diff options
Diffstat (limited to 'fs')
189 files changed, 2444 insertions, 1386 deletions
diff --git a/fs/9p/v9fs_vfs.h b/fs/9p/v9fs_vfs.h index 43c9f7de0314..f867b8d3e973 100644 --- a/fs/9p/v9fs_vfs.h +++ b/fs/9p/v9fs_vfs.h | |||
@@ -39,8 +39,8 @@ | |||
39 | 39 | ||
40 | extern struct file_system_type v9fs_fs_type; | 40 | extern struct file_system_type v9fs_fs_type; |
41 | extern struct address_space_operations v9fs_addr_operations; | 41 | extern struct address_space_operations v9fs_addr_operations; |
42 | extern struct file_operations v9fs_file_operations; | 42 | extern const struct file_operations v9fs_file_operations; |
43 | extern struct file_operations v9fs_dir_operations; | 43 | extern const struct file_operations v9fs_dir_operations; |
44 | extern struct dentry_operations v9fs_dentry_operations; | 44 | extern struct dentry_operations v9fs_dentry_operations; |
45 | 45 | ||
46 | struct inode *v9fs_get_inode(struct super_block *sb, int mode); | 46 | struct inode *v9fs_get_inode(struct super_block *sb, int mode); |
diff --git a/fs/9p/vfs_dir.c b/fs/9p/vfs_dir.c index 766f11f1215c..e32d5971039b 100644 --- a/fs/9p/vfs_dir.c +++ b/fs/9p/vfs_dir.c | |||
@@ -204,7 +204,7 @@ int v9fs_dir_release(struct inode *inode, struct file *filp) | |||
204 | return 0; | 204 | return 0; |
205 | } | 205 | } |
206 | 206 | ||
207 | struct file_operations v9fs_dir_operations = { | 207 | const struct file_operations v9fs_dir_operations = { |
208 | .read = generic_read_dir, | 208 | .read = generic_read_dir, |
209 | .readdir = v9fs_dir_readdir, | 209 | .readdir = v9fs_dir_readdir, |
210 | .open = v9fs_file_open, | 210 | .open = v9fs_file_open, |
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 59e744163407..083dcfcd158e 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c | |||
@@ -266,7 +266,7 @@ v9fs_file_write(struct file *filp, const char __user * data, | |||
266 | return total; | 266 | return total; |
267 | } | 267 | } |
268 | 268 | ||
269 | struct file_operations v9fs_file_operations = { | 269 | const struct file_operations v9fs_file_operations = { |
270 | .llseek = generic_file_llseek, | 270 | .llseek = generic_file_llseek, |
271 | .read = v9fs_file_read, | 271 | .read = v9fs_file_read, |
272 | .write = v9fs_file_write, | 272 | .write = v9fs_file_write, |
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h index f6cd01352cc8..29217ff36d44 100644 --- a/fs/adfs/adfs.h +++ b/fs/adfs/adfs.h | |||
@@ -85,7 +85,7 @@ void __adfs_error(struct super_block *sb, const char *function, | |||
85 | 85 | ||
86 | /* dir_*.c */ | 86 | /* dir_*.c */ |
87 | extern struct inode_operations adfs_dir_inode_operations; | 87 | extern struct inode_operations adfs_dir_inode_operations; |
88 | extern struct file_operations adfs_dir_operations; | 88 | extern const struct file_operations adfs_dir_operations; |
89 | extern struct dentry_operations adfs_dentry_operations; | 89 | extern struct dentry_operations adfs_dentry_operations; |
90 | extern struct adfs_dir_ops adfs_f_dir_ops; | 90 | extern struct adfs_dir_ops adfs_f_dir_ops; |
91 | extern struct adfs_dir_ops adfs_fplus_dir_ops; | 91 | extern struct adfs_dir_ops adfs_fplus_dir_ops; |
@@ -94,7 +94,7 @@ extern int adfs_dir_update(struct super_block *sb, struct object_info *obj); | |||
94 | 94 | ||
95 | /* file.c */ | 95 | /* file.c */ |
96 | extern struct inode_operations adfs_file_inode_operations; | 96 | extern struct inode_operations adfs_file_inode_operations; |
97 | extern struct file_operations adfs_file_operations; | 97 | extern const struct file_operations adfs_file_operations; |
98 | 98 | ||
99 | static inline __u32 signed_asl(__u32 val, signed int shift) | 99 | static inline __u32 signed_asl(__u32 val, signed int shift) |
100 | { | 100 | { |
diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index 0b4c3a028076..7b075fc397da 100644 --- a/fs/adfs/dir.c +++ b/fs/adfs/dir.c | |||
@@ -196,7 +196,7 @@ out: | |||
196 | return ret; | 196 | return ret; |
197 | } | 197 | } |
198 | 198 | ||
199 | struct file_operations adfs_dir_operations = { | 199 | const struct file_operations adfs_dir_operations = { |
200 | .read = generic_read_dir, | 200 | .read = generic_read_dir, |
201 | .readdir = adfs_readdir, | 201 | .readdir = adfs_readdir, |
202 | .fsync = file_fsync, | 202 | .fsync = file_fsync, |
diff --git a/fs/adfs/file.c b/fs/adfs/file.c index 6af10885f9d6..1014b9f2117b 100644 --- a/fs/adfs/file.c +++ b/fs/adfs/file.c | |||
@@ -25,7 +25,7 @@ | |||
25 | 25 | ||
26 | #include "adfs.h" | 26 | #include "adfs.h" |
27 | 27 | ||
28 | struct file_operations adfs_file_operations = { | 28 | const struct file_operations adfs_file_operations = { |
29 | .llseek = generic_file_llseek, | 29 | .llseek = generic_file_llseek, |
30 | .read = generic_file_read, | 30 | .read = generic_file_read, |
31 | .mmap = generic_file_mmap, | 31 | .mmap = generic_file_mmap, |
diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 0c6799f2137a..a43a876742b8 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h | |||
@@ -192,9 +192,9 @@ extern void affs_dir_truncate(struct inode *); | |||
192 | extern struct inode_operations affs_file_inode_operations; | 192 | extern struct inode_operations affs_file_inode_operations; |
193 | extern struct inode_operations affs_dir_inode_operations; | 193 | extern struct inode_operations affs_dir_inode_operations; |
194 | extern struct inode_operations affs_symlink_inode_operations; | 194 | extern struct inode_operations affs_symlink_inode_operations; |
195 | extern struct file_operations affs_file_operations; | 195 | extern const struct file_operations affs_file_operations; |
196 | extern struct file_operations affs_file_operations_ofs; | 196 | extern const struct file_operations affs_file_operations_ofs; |
197 | extern struct file_operations affs_dir_operations; | 197 | extern const struct file_operations affs_dir_operations; |
198 | extern struct address_space_operations affs_symlink_aops; | 198 | extern struct address_space_operations affs_symlink_aops; |
199 | extern struct address_space_operations affs_aops; | 199 | extern struct address_space_operations affs_aops; |
200 | extern struct address_space_operations affs_aops_ofs; | 200 | extern struct address_space_operations affs_aops_ofs; |
diff --git a/fs/affs/dir.c b/fs/affs/dir.c index 548efd0ee98c..5d9649fa1814 100644 --- a/fs/affs/dir.c +++ b/fs/affs/dir.c | |||
@@ -17,7 +17,7 @@ | |||
17 | 17 | ||
18 | static int affs_readdir(struct file *, void *, filldir_t); | 18 | static int affs_readdir(struct file *, void *, filldir_t); |
19 | 19 | ||
20 | struct file_operations affs_dir_operations = { | 20 | const struct file_operations affs_dir_operations = { |
21 | .read = generic_read_dir, | 21 | .read = generic_read_dir, |
22 | .readdir = affs_readdir, | 22 | .readdir = affs_readdir, |
23 | .fsync = file_fsync, | 23 | .fsync = file_fsync, |
diff --git a/fs/affs/file.c b/fs/affs/file.c index f72fb776ecdf..7076262af39b 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c | |||
@@ -25,7 +25,7 @@ static struct buffer_head *affs_get_extblock_slow(struct inode *inode, u32 ext); | |||
25 | static int affs_file_open(struct inode *inode, struct file *filp); | 25 | static int affs_file_open(struct inode *inode, struct file *filp); |
26 | static int affs_file_release(struct inode *inode, struct file *filp); | 26 | static int affs_file_release(struct inode *inode, struct file *filp); |
27 | 27 | ||
28 | struct file_operations affs_file_operations = { | 28 | const struct file_operations affs_file_operations = { |
29 | .llseek = generic_file_llseek, | 29 | .llseek = generic_file_llseek, |
30 | .read = generic_file_read, | 30 | .read = generic_file_read, |
31 | .write = generic_file_write, | 31 | .write = generic_file_write, |
diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 5c61c24dab2a..a6dff6a4f204 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c | |||
@@ -32,7 +32,7 @@ static int afs_d_delete(struct dentry *dentry); | |||
32 | static int afs_dir_lookup_filldir(void *_cookie, const char *name, int nlen, | 32 | static int afs_dir_lookup_filldir(void *_cookie, const char *name, int nlen, |
33 | loff_t fpos, ino_t ino, unsigned dtype); | 33 | loff_t fpos, ino_t ino, unsigned dtype); |
34 | 34 | ||
35 | struct file_operations afs_dir_file_operations = { | 35 | const struct file_operations afs_dir_file_operations = { |
36 | .open = afs_dir_open, | 36 | .open = afs_dir_open, |
37 | .readdir = afs_dir_readdir, | 37 | .readdir = afs_dir_readdir, |
38 | }; | 38 | }; |
diff --git a/fs/afs/file.c b/fs/afs/file.c index 150b19227922..7bb716887e29 100644 --- a/fs/afs/file.c +++ b/fs/afs/file.c | |||
@@ -28,7 +28,7 @@ static int afs_file_release(struct inode *inode, struct file *file); | |||
28 | #endif | 28 | #endif |
29 | 29 | ||
30 | static int afs_file_readpage(struct file *file, struct page *page); | 30 | static int afs_file_readpage(struct file *file, struct page *page); |
31 | static int afs_file_invalidatepage(struct page *page, unsigned long offset); | 31 | static void afs_file_invalidatepage(struct page *page, unsigned long offset); |
32 | static int afs_file_releasepage(struct page *page, gfp_t gfp_flags); | 32 | static int afs_file_releasepage(struct page *page, gfp_t gfp_flags); |
33 | 33 | ||
34 | struct inode_operations afs_file_inode_operations = { | 34 | struct inode_operations afs_file_inode_operations = { |
@@ -212,7 +212,7 @@ int afs_cache_get_page_cookie(struct page *page, | |||
212 | /* | 212 | /* |
213 | * invalidate part or all of a page | 213 | * invalidate part or all of a page |
214 | */ | 214 | */ |
215 | static int afs_file_invalidatepage(struct page *page, unsigned long offset) | 215 | static void afs_file_invalidatepage(struct page *page, unsigned long offset) |
216 | { | 216 | { |
217 | int ret = 1; | 217 | int ret = 1; |
218 | 218 | ||
@@ -238,11 +238,11 @@ static int afs_file_invalidatepage(struct page *page, unsigned long offset) | |||
238 | if (!PageWriteback(page)) | 238 | if (!PageWriteback(page)) |
239 | ret = page->mapping->a_ops->releasepage(page, | 239 | ret = page->mapping->a_ops->releasepage(page, |
240 | 0); | 240 | 0); |
241 | /* possibly should BUG_ON(!ret); - neilb */ | ||
241 | } | 242 | } |
242 | } | 243 | } |
243 | 244 | ||
244 | _leave(" = %d", ret); | 245 | _leave(" = %d", ret); |
245 | return ret; | ||
246 | } /* end afs_file_invalidatepage() */ | 246 | } /* end afs_file_invalidatepage() */ |
247 | 247 | ||
248 | /*****************************************************************************/ | 248 | /*****************************************************************************/ |
diff --git a/fs/afs/internal.h b/fs/afs/internal.h index ab8f87c66319..72febdf9a35a 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h | |||
@@ -64,7 +64,7 @@ extern struct cachefs_index_def afs_cache_cell_index_def; | |||
64 | * dir.c | 64 | * dir.c |
65 | */ | 65 | */ |
66 | extern struct inode_operations afs_dir_inode_operations; | 66 | extern struct inode_operations afs_dir_inode_operations; |
67 | extern struct file_operations afs_dir_file_operations; | 67 | extern const struct file_operations afs_dir_file_operations; |
68 | 68 | ||
69 | /* | 69 | /* |
70 | * file.c | 70 | * file.c |
@@ -105,7 +105,7 @@ extern struct cachefs_netfs afs_cache_netfs; | |||
105 | * mntpt.c | 105 | * mntpt.c |
106 | */ | 106 | */ |
107 | extern struct inode_operations afs_mntpt_inode_operations; | 107 | extern struct inode_operations afs_mntpt_inode_operations; |
108 | extern struct file_operations afs_mntpt_file_operations; | 108 | extern const struct file_operations afs_mntpt_file_operations; |
109 | extern struct afs_timer afs_mntpt_expiry_timer; | 109 | extern struct afs_timer afs_mntpt_expiry_timer; |
110 | extern struct afs_timer_ops afs_mntpt_expiry_timer_ops; | 110 | extern struct afs_timer_ops afs_mntpt_expiry_timer_ops; |
111 | extern unsigned long afs_mntpt_expiry_timeout; | 111 | extern unsigned long afs_mntpt_expiry_timeout; |
diff --git a/fs/afs/mntpt.c b/fs/afs/mntpt.c index 31ee06590de5..4e6eeb59b83c 100644 --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c | |||
@@ -32,7 +32,7 @@ static struct dentry *afs_mntpt_lookup(struct inode *dir, | |||
32 | static int afs_mntpt_open(struct inode *inode, struct file *file); | 32 | static int afs_mntpt_open(struct inode *inode, struct file *file); |
33 | static void *afs_mntpt_follow_link(struct dentry *dentry, struct nameidata *nd); | 33 | static void *afs_mntpt_follow_link(struct dentry *dentry, struct nameidata *nd); |
34 | 34 | ||
35 | struct file_operations afs_mntpt_file_operations = { | 35 | const struct file_operations afs_mntpt_file_operations = { |
36 | .open = afs_mntpt_open, | 36 | .open = afs_mntpt_open, |
37 | }; | 37 | }; |
38 | 38 | ||
diff --git a/fs/afs/proc.c b/fs/afs/proc.c index 9c81b8f7eef0..101d21b6c037 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c | |||
@@ -37,7 +37,7 @@ static struct seq_operations afs_proc_cells_ops = { | |||
37 | .show = afs_proc_cells_show, | 37 | .show = afs_proc_cells_show, |
38 | }; | 38 | }; |
39 | 39 | ||
40 | static struct file_operations afs_proc_cells_fops = { | 40 | static const struct file_operations afs_proc_cells_fops = { |
41 | .open = afs_proc_cells_open, | 41 | .open = afs_proc_cells_open, |
42 | .read = seq_read, | 42 | .read = seq_read, |
43 | .write = afs_proc_cells_write, | 43 | .write = afs_proc_cells_write, |
@@ -53,7 +53,7 @@ static ssize_t afs_proc_rootcell_write(struct file *file, | |||
53 | const char __user *buf, | 53 | const char __user *buf, |
54 | size_t size, loff_t *_pos); | 54 | size_t size, loff_t *_pos); |
55 | 55 | ||
56 | static struct file_operations afs_proc_rootcell_fops = { | 56 | static const struct file_operations afs_proc_rootcell_fops = { |
57 | .open = afs_proc_rootcell_open, | 57 | .open = afs_proc_rootcell_open, |
58 | .read = afs_proc_rootcell_read, | 58 | .read = afs_proc_rootcell_read, |
59 | .write = afs_proc_rootcell_write, | 59 | .write = afs_proc_rootcell_write, |
@@ -77,7 +77,7 @@ static struct seq_operations afs_proc_cell_volumes_ops = { | |||
77 | .show = afs_proc_cell_volumes_show, | 77 | .show = afs_proc_cell_volumes_show, |
78 | }; | 78 | }; |
79 | 79 | ||
80 | static struct file_operations afs_proc_cell_volumes_fops = { | 80 | static const struct file_operations afs_proc_cell_volumes_fops = { |
81 | .open = afs_proc_cell_volumes_open, | 81 | .open = afs_proc_cell_volumes_open, |
82 | .read = seq_read, | 82 | .read = seq_read, |
83 | .llseek = seq_lseek, | 83 | .llseek = seq_lseek, |
@@ -101,7 +101,7 @@ static struct seq_operations afs_proc_cell_vlservers_ops = { | |||
101 | .show = afs_proc_cell_vlservers_show, | 101 | .show = afs_proc_cell_vlservers_show, |
102 | }; | 102 | }; |
103 | 103 | ||
104 | static struct file_operations afs_proc_cell_vlservers_fops = { | 104 | static const struct file_operations afs_proc_cell_vlservers_fops = { |
105 | .open = afs_proc_cell_vlservers_open, | 105 | .open = afs_proc_cell_vlservers_open, |
106 | .read = seq_read, | 106 | .read = seq_read, |
107 | .llseek = seq_lseek, | 107 | .llseek = seq_lseek, |
@@ -124,7 +124,7 @@ static struct seq_operations afs_proc_cell_servers_ops = { | |||
124 | .show = afs_proc_cell_servers_show, | 124 | .show = afs_proc_cell_servers_show, |
125 | }; | 125 | }; |
126 | 126 | ||
127 | static struct file_operations afs_proc_cell_servers_fops = { | 127 | static const struct file_operations afs_proc_cell_servers_fops = { |
128 | .open = afs_proc_cell_servers_open, | 128 | .open = afs_proc_cell_servers_open, |
129 | .read = seq_read, | 129 | .read = seq_read, |
130 | .llseek = seq_lseek, | 130 | .llseek = seq_lseek, |
diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h index 990c28da5aec..a62327f1bdff 100644 --- a/fs/autofs/autofs_i.h +++ b/fs/autofs/autofs_i.h | |||
@@ -146,7 +146,7 @@ struct autofs_dir_ent *autofs_expire(struct super_block *,struct autofs_sb_info | |||
146 | 146 | ||
147 | extern struct inode_operations autofs_root_inode_operations; | 147 | extern struct inode_operations autofs_root_inode_operations; |
148 | extern struct inode_operations autofs_symlink_inode_operations; | 148 | extern struct inode_operations autofs_symlink_inode_operations; |
149 | extern struct file_operations autofs_root_operations; | 149 | extern const struct file_operations autofs_root_operations; |
150 | 150 | ||
151 | /* Initializing function */ | 151 | /* Initializing function */ |
152 | 152 | ||
diff --git a/fs/autofs/dirhash.c b/fs/autofs/dirhash.c index 5ccfcf26310d..3fded389d06b 100644 --- a/fs/autofs/dirhash.c +++ b/fs/autofs/dirhash.c | |||
@@ -92,7 +92,7 @@ struct autofs_dir_ent *autofs_expire(struct super_block *sb, | |||
92 | ; | 92 | ; |
93 | dput(dentry); | 93 | dput(dentry); |
94 | 94 | ||
95 | if ( may_umount(mnt) == 0 ) { | 95 | if ( may_umount(mnt) ) { |
96 | mntput(mnt); | 96 | mntput(mnt); |
97 | DPRINTK(("autofs: signaling expire on %s\n", ent->name)); | 97 | DPRINTK(("autofs: signaling expire on %s\n", ent->name)); |
98 | return ent; /* Expirable! */ | 98 | return ent; /* Expirable! */ |
diff --git a/fs/autofs/root.c b/fs/autofs/root.c index 870e2cf33016..9cac08d6a873 100644 --- a/fs/autofs/root.c +++ b/fs/autofs/root.c | |||
@@ -26,7 +26,7 @@ static int autofs_root_rmdir(struct inode *,struct dentry *); | |||
26 | static int autofs_root_mkdir(struct inode *,struct dentry *,int); | 26 | static int autofs_root_mkdir(struct inode *,struct dentry *,int); |
27 | static int autofs_root_ioctl(struct inode *, struct file *,unsigned int,unsigned long); | 27 | static int autofs_root_ioctl(struct inode *, struct file *,unsigned int,unsigned long); |
28 | 28 | ||
29 | struct file_operations autofs_root_operations = { | 29 | const struct file_operations autofs_root_operations = { |
30 | .read = generic_read_dir, | 30 | .read = generic_read_dir, |
31 | .readdir = autofs_root_readdir, | 31 | .readdir = autofs_root_readdir, |
32 | .ioctl = autofs_root_ioctl, | 32 | .ioctl = autofs_root_ioctl, |
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index f54c5b21f876..57c4903614e5 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h | |||
@@ -3,6 +3,7 @@ | |||
3 | * linux/fs/autofs/autofs_i.h | 3 | * linux/fs/autofs/autofs_i.h |
4 | * | 4 | * |
5 | * Copyright 1997-1998 Transmeta Corporation - All Rights Reserved | 5 | * Copyright 1997-1998 Transmeta Corporation - All Rights Reserved |
6 | * Copyright 2005-2006 Ian Kent <raven@themaw.net> | ||
6 | * | 7 | * |
7 | * This file is part of the Linux kernel and is made available under | 8 | * This file is part of the Linux kernel and is made available under |
8 | * the terms of the GNU General Public License, version 2, or at your | 9 | * the terms of the GNU General Public License, version 2, or at your |
@@ -41,14 +42,6 @@ | |||
41 | 42 | ||
42 | #define AUTOFS_SUPER_MAGIC 0x0187 | 43 | #define AUTOFS_SUPER_MAGIC 0x0187 |
43 | 44 | ||
44 | /* | ||
45 | * If the daemon returns a negative response (AUTOFS_IOC_FAIL) then the | ||
46 | * kernel will keep the negative response cached for up to the time given | ||
47 | * here, although the time can be shorter if the kernel throws the dcache | ||
48 | * entry away. This probably should be settable from user space. | ||
49 | */ | ||
50 | #define AUTOFS_NEGATIVE_TIMEOUT (60*HZ) /* 1 minute */ | ||
51 | |||
52 | /* Unified info structure. This is pointed to by both the dentry and | 45 | /* Unified info structure. This is pointed to by both the dentry and |
53 | inode structures. Each file in the filesystem has an instance of this | 46 | inode structures. Each file in the filesystem has an instance of this |
54 | structure. It holds a reference to the dentry, so dentries are never | 47 | structure. It holds a reference to the dentry, so dentries are never |
@@ -63,6 +56,7 @@ struct autofs_info { | |||
63 | 56 | ||
64 | struct autofs_sb_info *sbi; | 57 | struct autofs_sb_info *sbi; |
65 | unsigned long last_used; | 58 | unsigned long last_used; |
59 | atomic_t count; | ||
66 | 60 | ||
67 | mode_t mode; | 61 | mode_t mode; |
68 | size_t size; | 62 | size_t size; |
@@ -83,23 +77,37 @@ struct autofs_wait_queue { | |||
83 | int hash; | 77 | int hash; |
84 | int len; | 78 | int len; |
85 | char *name; | 79 | char *name; |
80 | u32 dev; | ||
81 | u64 ino; | ||
82 | uid_t uid; | ||
83 | gid_t gid; | ||
84 | pid_t pid; | ||
85 | pid_t tgid; | ||
86 | /* This is for status reporting upon return */ | 86 | /* This is for status reporting upon return */ |
87 | int status; | 87 | int status; |
88 | atomic_t notified; | 88 | atomic_t notify; |
89 | atomic_t wait_ctr; | 89 | atomic_t wait_ctr; |
90 | }; | 90 | }; |
91 | 91 | ||
92 | #define AUTOFS_SBI_MAGIC 0x6d4a556d | 92 | #define AUTOFS_SBI_MAGIC 0x6d4a556d |
93 | 93 | ||
94 | #define AUTOFS_TYPE_INDIRECT 0x0001 | ||
95 | #define AUTOFS_TYPE_DIRECT 0x0002 | ||
96 | #define AUTOFS_TYPE_OFFSET 0x0004 | ||
97 | |||
94 | struct autofs_sb_info { | 98 | struct autofs_sb_info { |
95 | u32 magic; | 99 | u32 magic; |
96 | struct dentry *root; | 100 | struct dentry *root; |
101 | int pipefd; | ||
97 | struct file *pipe; | 102 | struct file *pipe; |
98 | pid_t oz_pgrp; | 103 | pid_t oz_pgrp; |
99 | int catatonic; | 104 | int catatonic; |
100 | int version; | 105 | int version; |
101 | int sub_version; | 106 | int sub_version; |
107 | int min_proto; | ||
108 | int max_proto; | ||
102 | unsigned long exp_timeout; | 109 | unsigned long exp_timeout; |
110 | unsigned int type; | ||
103 | int reghost_enabled; | 111 | int reghost_enabled; |
104 | int needs_reghost; | 112 | int needs_reghost; |
105 | struct super_block *sb; | 113 | struct super_block *sb; |
@@ -166,8 +174,10 @@ int autofs4_expire_multi(struct super_block *, struct vfsmount *, | |||
166 | extern struct inode_operations autofs4_symlink_inode_operations; | 174 | extern struct inode_operations autofs4_symlink_inode_operations; |
167 | extern struct inode_operations autofs4_dir_inode_operations; | 175 | extern struct inode_operations autofs4_dir_inode_operations; |
168 | extern struct inode_operations autofs4_root_inode_operations; | 176 | extern struct inode_operations autofs4_root_inode_operations; |
169 | extern struct file_operations autofs4_dir_operations; | 177 | extern struct inode_operations autofs4_indirect_root_inode_operations; |
170 | extern struct file_operations autofs4_root_operations; | 178 | extern struct inode_operations autofs4_direct_root_inode_operations; |
179 | extern const struct file_operations autofs4_dir_operations; | ||
180 | extern const struct file_operations autofs4_root_operations; | ||
171 | 181 | ||
172 | /* Initializing function */ | 182 | /* Initializing function */ |
173 | 183 | ||
@@ -176,13 +186,6 @@ struct autofs_info *autofs4_init_ino(struct autofs_info *, struct autofs_sb_info | |||
176 | 186 | ||
177 | /* Queue management functions */ | 187 | /* Queue management functions */ |
178 | 188 | ||
179 | enum autofs_notify | ||
180 | { | ||
181 | NFY_NONE, | ||
182 | NFY_MOUNT, | ||
183 | NFY_EXPIRE | ||
184 | }; | ||
185 | |||
186 | int autofs4_wait(struct autofs_sb_info *,struct dentry *, enum autofs_notify); | 189 | int autofs4_wait(struct autofs_sb_info *,struct dentry *, enum autofs_notify); |
187 | int autofs4_wait_release(struct autofs_sb_info *,autofs_wqt_t,int); | 190 | int autofs4_wait_release(struct autofs_sb_info *,autofs_wqt_t,int); |
188 | void autofs4_catatonic_mode(struct autofs_sb_info *); | 191 | void autofs4_catatonic_mode(struct autofs_sb_info *); |
@@ -200,12 +203,22 @@ static inline int autofs4_follow_mount(struct vfsmount **mnt, struct dentry **de | |||
200 | return res; | 203 | return res; |
201 | } | 204 | } |
202 | 205 | ||
206 | static inline u32 autofs4_get_dev(struct autofs_sb_info *sbi) | ||
207 | { | ||
208 | return new_encode_dev(sbi->sb->s_dev); | ||
209 | } | ||
210 | |||
211 | static inline u64 autofs4_get_ino(struct autofs_sb_info *sbi) | ||
212 | { | ||
213 | return sbi->sb->s_root->d_inode->i_ino; | ||
214 | } | ||
215 | |||
203 | static inline int simple_positive(struct dentry *dentry) | 216 | static inline int simple_positive(struct dentry *dentry) |
204 | { | 217 | { |
205 | return dentry->d_inode && !d_unhashed(dentry); | 218 | return dentry->d_inode && !d_unhashed(dentry); |
206 | } | 219 | } |
207 | 220 | ||
208 | static inline int simple_empty_nolock(struct dentry *dentry) | 221 | static inline int __simple_empty(struct dentry *dentry) |
209 | { | 222 | { |
210 | struct dentry *child; | 223 | struct dentry *child; |
211 | int ret = 0; | 224 | int ret = 0; |
@@ -217,3 +230,6 @@ static inline int simple_empty_nolock(struct dentry *dentry) | |||
217 | out: | 230 | out: |
218 | return ret; | 231 | return ret; |
219 | } | 232 | } |
233 | |||
234 | void autofs4_dentry_release(struct dentry *); | ||
235 | |||
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index dc39589df165..b8ce02607d66 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c | |||
@@ -4,7 +4,7 @@ | |||
4 | * | 4 | * |
5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved | 5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved |
6 | * Copyright 1999-2000 Jeremy Fitzhardinge <jeremy@goop.org> | 6 | * Copyright 1999-2000 Jeremy Fitzhardinge <jeremy@goop.org> |
7 | * Copyright 2001-2003 Ian Kent <raven@themaw.net> | 7 | * Copyright 2001-2006 Ian Kent <raven@themaw.net> |
8 | * | 8 | * |
9 | * This file is part of the Linux kernel and is made available under | 9 | * This file is part of the Linux kernel and is made available under |
10 | * the terms of the GNU General Public License, version 2, or at your | 10 | * the terms of the GNU General Public License, version 2, or at your |
@@ -16,7 +16,7 @@ | |||
16 | 16 | ||
17 | static unsigned long now; | 17 | static unsigned long now; |
18 | 18 | ||
19 | /* Check if a dentry can be expired return 1 if it can else return 0 */ | 19 | /* Check if a dentry can be expired */ |
20 | static inline int autofs4_can_expire(struct dentry *dentry, | 20 | static inline int autofs4_can_expire(struct dentry *dentry, |
21 | unsigned long timeout, int do_now) | 21 | unsigned long timeout, int do_now) |
22 | { | 22 | { |
@@ -41,14 +41,14 @@ static inline int autofs4_can_expire(struct dentry *dentry, | |||
41 | attempts if expire fails the first time */ | 41 | attempts if expire fails the first time */ |
42 | ino->last_used = now; | 42 | ino->last_used = now; |
43 | } | 43 | } |
44 | |||
45 | return 1; | 44 | return 1; |
46 | } | 45 | } |
47 | 46 | ||
48 | /* Check a mount point for busyness return 1 if not busy, otherwise */ | 47 | /* Check a mount point for busyness */ |
49 | static int autofs4_check_mount(struct vfsmount *mnt, struct dentry *dentry) | 48 | static int autofs4_mount_busy(struct vfsmount *mnt, struct dentry *dentry) |
50 | { | 49 | { |
51 | int status = 0; | 50 | struct dentry *top = dentry; |
51 | int status = 1; | ||
52 | 52 | ||
53 | DPRINTK("dentry %p %.*s", | 53 | DPRINTK("dentry %p %.*s", |
54 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | 54 | dentry, (int)dentry->d_name.len, dentry->d_name.name); |
@@ -63,9 +63,14 @@ static int autofs4_check_mount(struct vfsmount *mnt, struct dentry *dentry) | |||
63 | if (is_autofs4_dentry(dentry)) | 63 | if (is_autofs4_dentry(dentry)) |
64 | goto done; | 64 | goto done; |
65 | 65 | ||
66 | /* The big question */ | 66 | /* Update the expiry counter if fs is busy */ |
67 | if (may_umount_tree(mnt) == 0) | 67 | if (!may_umount_tree(mnt)) { |
68 | status = 1; | 68 | struct autofs_info *ino = autofs4_dentry_ino(top); |
69 | ino->last_used = jiffies; | ||
70 | goto done; | ||
71 | } | ||
72 | |||
73 | status = 0; | ||
69 | done: | 74 | done: |
70 | DPRINTK("returning = %d", status); | 75 | DPRINTK("returning = %d", status); |
71 | mntput(mnt); | 76 | mntput(mnt); |
@@ -73,78 +78,124 @@ done: | |||
73 | return status; | 78 | return status; |
74 | } | 79 | } |
75 | 80 | ||
81 | /* | ||
82 | * Calculate next entry in top down tree traversal. | ||
83 | * From next_mnt in namespace.c - elegant. | ||
84 | */ | ||
85 | static struct dentry *next_dentry(struct dentry *p, struct dentry *root) | ||
86 | { | ||
87 | struct list_head *next = p->d_subdirs.next; | ||
88 | |||
89 | if (next == &p->d_subdirs) { | ||
90 | while (1) { | ||
91 | if (p == root) | ||
92 | return NULL; | ||
93 | next = p->d_u.d_child.next; | ||
94 | if (next != &p->d_parent->d_subdirs) | ||
95 | break; | ||
96 | p = p->d_parent; | ||
97 | } | ||
98 | } | ||
99 | return list_entry(next, struct dentry, d_u.d_child); | ||
100 | } | ||
101 | |||
102 | /* | ||
103 | * Check a direct mount point for busyness. | ||
104 | * Direct mounts have similar expiry semantics to tree mounts. | ||
105 | * The tree is not busy iff no mountpoints are busy and there are no | ||
106 | * autofs submounts. | ||
107 | */ | ||
108 | static int autofs4_direct_busy(struct vfsmount *mnt, | ||
109 | struct dentry *top, | ||
110 | unsigned long timeout, | ||
111 | int do_now) | ||
112 | { | ||
113 | DPRINTK("top %p %.*s", | ||
114 | top, (int) top->d_name.len, top->d_name.name); | ||
115 | |||
116 | /* If it's busy update the expiry counters */ | ||
117 | if (!may_umount_tree(mnt)) { | ||
118 | struct autofs_info *ino = autofs4_dentry_ino(top); | ||
119 | if (ino) | ||
120 | ino->last_used = jiffies; | ||
121 | return 1; | ||
122 | } | ||
123 | |||
124 | /* Timeout of a direct mount is determined by its top dentry */ | ||
125 | if (!autofs4_can_expire(top, timeout, do_now)) | ||
126 | return 1; | ||
127 | |||
128 | return 0; | ||
129 | } | ||
130 | |||
76 | /* Check a directory tree of mount points for busyness | 131 | /* Check a directory tree of mount points for busyness |
77 | * The tree is not busy iff no mountpoints are busy | 132 | * The tree is not busy iff no mountpoints are busy |
78 | * Return 1 if the tree is busy or 0 otherwise | ||
79 | */ | 133 | */ |
80 | static int autofs4_check_tree(struct vfsmount *mnt, | 134 | static int autofs4_tree_busy(struct vfsmount *mnt, |
81 | struct dentry *top, | 135 | struct dentry *top, |
82 | unsigned long timeout, | 136 | unsigned long timeout, |
83 | int do_now) | 137 | int do_now) |
84 | { | 138 | { |
85 | struct dentry *this_parent = top; | 139 | struct autofs_info *top_ino = autofs4_dentry_ino(top); |
86 | struct list_head *next; | 140 | struct dentry *p; |
87 | 141 | ||
88 | DPRINTK("parent %p %.*s", | 142 | DPRINTK("top %p %.*s", |
89 | top, (int)top->d_name.len, top->d_name.name); | 143 | top, (int)top->d_name.len, top->d_name.name); |
90 | 144 | ||
91 | /* Negative dentry - give up */ | 145 | /* Negative dentry - give up */ |
92 | if (!simple_positive(top)) | 146 | if (!simple_positive(top)) |
93 | return 0; | 147 | return 1; |
94 | |||
95 | /* Timeout of a tree mount is determined by its top dentry */ | ||
96 | if (!autofs4_can_expire(top, timeout, do_now)) | ||
97 | return 0; | ||
98 | |||
99 | /* Is someone visiting anywhere in the tree ? */ | ||
100 | if (may_umount_tree(mnt)) | ||
101 | return 0; | ||
102 | 148 | ||
103 | spin_lock(&dcache_lock); | 149 | spin_lock(&dcache_lock); |
104 | repeat: | 150 | for (p = top; p; p = next_dentry(p, top)) { |
105 | next = this_parent->d_subdirs.next; | ||
106 | resume: | ||
107 | while (next != &this_parent->d_subdirs) { | ||
108 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); | ||
109 | |||
110 | /* Negative dentry - give up */ | 151 | /* Negative dentry - give up */ |
111 | if (!simple_positive(dentry)) { | 152 | if (!simple_positive(p)) |
112 | next = next->next; | ||
113 | continue; | 153 | continue; |
114 | } | ||
115 | 154 | ||
116 | DPRINTK("dentry %p %.*s", | 155 | DPRINTK("dentry %p %.*s", |
117 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | 156 | p, (int) p->d_name.len, p->d_name.name); |
118 | |||
119 | if (!simple_empty_nolock(dentry)) { | ||
120 | this_parent = dentry; | ||
121 | goto repeat; | ||
122 | } | ||
123 | 157 | ||
124 | dentry = dget(dentry); | 158 | p = dget(p); |
125 | spin_unlock(&dcache_lock); | 159 | spin_unlock(&dcache_lock); |
126 | 160 | ||
127 | if (d_mountpoint(dentry)) { | 161 | /* |
128 | /* First busy => tree busy */ | 162 | * Is someone visiting anywhere in the subtree ? |
129 | if (!autofs4_check_mount(mnt, dentry)) { | 163 | * If there's no mount we need to check the usage |
130 | dput(dentry); | 164 | * count for the autofs dentry. |
131 | return 0; | 165 | * If the fs is busy update the expiry counter. |
166 | */ | ||
167 | if (d_mountpoint(p)) { | ||
168 | if (autofs4_mount_busy(mnt, p)) { | ||
169 | top_ino->last_used = jiffies; | ||
170 | dput(p); | ||
171 | return 1; | ||
172 | } | ||
173 | } else { | ||
174 | struct autofs_info *ino = autofs4_dentry_ino(p); | ||
175 | unsigned int ino_count = atomic_read(&ino->count); | ||
176 | |||
177 | /* allow for dget above and top is already dgot */ | ||
178 | if (p == top) | ||
179 | ino_count += 2; | ||
180 | else | ||
181 | ino_count++; | ||
182 | |||
183 | if (atomic_read(&p->d_count) > ino_count) { | ||
184 | top_ino->last_used = jiffies; | ||
185 | dput(p); | ||
186 | return 1; | ||
132 | } | 187 | } |
133 | } | 188 | } |
134 | 189 | dput(p); | |
135 | dput(dentry); | ||
136 | spin_lock(&dcache_lock); | 190 | spin_lock(&dcache_lock); |
137 | next = next->next; | ||
138 | } | ||
139 | |||
140 | if (this_parent != top) { | ||
141 | next = this_parent->d_u.d_child.next; | ||
142 | this_parent = this_parent->d_parent; | ||
143 | goto resume; | ||
144 | } | 191 | } |
145 | spin_unlock(&dcache_lock); | 192 | spin_unlock(&dcache_lock); |
146 | 193 | ||
147 | return 1; | 194 | /* Timeout of a tree mount is ultimately determined by its top dentry */ |
195 | if (!autofs4_can_expire(top, timeout, do_now)) | ||
196 | return 1; | ||
197 | |||
198 | return 0; | ||
148 | } | 199 | } |
149 | 200 | ||
150 | static struct dentry *autofs4_check_leaves(struct vfsmount *mnt, | 201 | static struct dentry *autofs4_check_leaves(struct vfsmount *mnt, |
@@ -152,58 +203,68 @@ static struct dentry *autofs4_check_leaves(struct vfsmount *mnt, | |||
152 | unsigned long timeout, | 203 | unsigned long timeout, |
153 | int do_now) | 204 | int do_now) |
154 | { | 205 | { |
155 | struct dentry *this_parent = parent; | 206 | struct dentry *p; |
156 | struct list_head *next; | ||
157 | 207 | ||
158 | DPRINTK("parent %p %.*s", | 208 | DPRINTK("parent %p %.*s", |
159 | parent, (int)parent->d_name.len, parent->d_name.name); | 209 | parent, (int)parent->d_name.len, parent->d_name.name); |
160 | 210 | ||
161 | spin_lock(&dcache_lock); | 211 | spin_lock(&dcache_lock); |
162 | repeat: | 212 | for (p = parent; p; p = next_dentry(p, parent)) { |
163 | next = this_parent->d_subdirs.next; | ||
164 | resume: | ||
165 | while (next != &this_parent->d_subdirs) { | ||
166 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); | ||
167 | |||
168 | /* Negative dentry - give up */ | 213 | /* Negative dentry - give up */ |
169 | if (!simple_positive(dentry)) { | 214 | if (!simple_positive(p)) |
170 | next = next->next; | ||
171 | continue; | 215 | continue; |
172 | } | ||
173 | 216 | ||
174 | DPRINTK("dentry %p %.*s", | 217 | DPRINTK("dentry %p %.*s", |
175 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | 218 | p, (int) p->d_name.len, p->d_name.name); |
176 | |||
177 | if (!list_empty(&dentry->d_subdirs)) { | ||
178 | this_parent = dentry; | ||
179 | goto repeat; | ||
180 | } | ||
181 | 219 | ||
182 | dentry = dget(dentry); | 220 | p = dget(p); |
183 | spin_unlock(&dcache_lock); | 221 | spin_unlock(&dcache_lock); |
184 | 222 | ||
185 | if (d_mountpoint(dentry)) { | 223 | if (d_mountpoint(p)) { |
186 | /* Can we expire this guy */ | ||
187 | if (!autofs4_can_expire(dentry, timeout, do_now)) | ||
188 | goto cont; | ||
189 | |||
190 | /* Can we umount this guy */ | 224 | /* Can we umount this guy */ |
191 | if (autofs4_check_mount(mnt, dentry)) | 225 | if (autofs4_mount_busy(mnt, p)) |
192 | return dentry; | 226 | goto cont; |
193 | 227 | ||
228 | /* Can we expire this guy */ | ||
229 | if (autofs4_can_expire(p, timeout, do_now)) | ||
230 | return p; | ||
194 | } | 231 | } |
195 | cont: | 232 | cont: |
196 | dput(dentry); | 233 | dput(p); |
197 | spin_lock(&dcache_lock); | 234 | spin_lock(&dcache_lock); |
198 | next = next->next; | ||
199 | } | 235 | } |
236 | spin_unlock(&dcache_lock); | ||
237 | return NULL; | ||
238 | } | ||
239 | |||
240 | /* Check if we can expire a direct mount (possibly a tree) */ | ||
241 | static struct dentry *autofs4_expire_direct(struct super_block *sb, | ||
242 | struct vfsmount *mnt, | ||
243 | struct autofs_sb_info *sbi, | ||
244 | int how) | ||
245 | { | ||
246 | unsigned long timeout; | ||
247 | struct dentry *root = dget(sb->s_root); | ||
248 | int do_now = how & AUTOFS_EXP_IMMEDIATE; | ||
249 | |||
250 | if (!sbi->exp_timeout || !root) | ||
251 | return NULL; | ||
252 | |||
253 | now = jiffies; | ||
254 | timeout = sbi->exp_timeout; | ||
255 | |||
256 | /* Lock the tree as we must expire as a whole */ | ||
257 | spin_lock(&sbi->fs_lock); | ||
258 | if (!autofs4_direct_busy(mnt, root, timeout, do_now)) { | ||
259 | struct autofs_info *ino = autofs4_dentry_ino(root); | ||
200 | 260 | ||
201 | if (this_parent != parent) { | 261 | /* Set this flag early to catch sys_chdir and the like */ |
202 | next = this_parent->d_u.d_child.next; | 262 | ino->flags |= AUTOFS_INF_EXPIRING; |
203 | this_parent = this_parent->d_parent; | 263 | spin_unlock(&sbi->fs_lock); |
204 | goto resume; | 264 | return root; |
205 | } | 265 | } |
206 | spin_unlock(&dcache_lock); | 266 | spin_unlock(&sbi->fs_lock); |
267 | dput(root); | ||
207 | 268 | ||
208 | return NULL; | 269 | return NULL; |
209 | } | 270 | } |
@@ -214,10 +275,10 @@ cont: | |||
214 | * - it is unused by any user process | 275 | * - it is unused by any user process |
215 | * - it has been unused for exp_timeout time | 276 | * - it has been unused for exp_timeout time |
216 | */ | 277 | */ |
217 | static struct dentry *autofs4_expire(struct super_block *sb, | 278 | static struct dentry *autofs4_expire_indirect(struct super_block *sb, |
218 | struct vfsmount *mnt, | 279 | struct vfsmount *mnt, |
219 | struct autofs_sb_info *sbi, | 280 | struct autofs_sb_info *sbi, |
220 | int how) | 281 | int how) |
221 | { | 282 | { |
222 | unsigned long timeout; | 283 | unsigned long timeout; |
223 | struct dentry *root = sb->s_root; | 284 | struct dentry *root = sb->s_root; |
@@ -241,7 +302,7 @@ static struct dentry *autofs4_expire(struct super_block *sb, | |||
241 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); | 302 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); |
242 | 303 | ||
243 | /* Negative dentry - give up */ | 304 | /* Negative dentry - give up */ |
244 | if ( !simple_positive(dentry) ) { | 305 | if (!simple_positive(dentry)) { |
245 | next = next->next; | 306 | next = next->next; |
246 | continue; | 307 | continue; |
247 | } | 308 | } |
@@ -249,31 +310,36 @@ static struct dentry *autofs4_expire(struct super_block *sb, | |||
249 | dentry = dget(dentry); | 310 | dentry = dget(dentry); |
250 | spin_unlock(&dcache_lock); | 311 | spin_unlock(&dcache_lock); |
251 | 312 | ||
252 | /* Case 1: indirect mount or top level direct mount */ | 313 | /* |
314 | * Case 1: (i) indirect mount or top level pseudo direct mount | ||
315 | * (autofs-4.1). | ||
316 | * (ii) indirect mount with offset mount, check the "/" | ||
317 | * offset (autofs-5.0+). | ||
318 | */ | ||
253 | if (d_mountpoint(dentry)) { | 319 | if (d_mountpoint(dentry)) { |
254 | DPRINTK("checking mountpoint %p %.*s", | 320 | DPRINTK("checking mountpoint %p %.*s", |
255 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | 321 | dentry, (int)dentry->d_name.len, dentry->d_name.name); |
256 | 322 | ||
257 | /* Can we expire this guy */ | 323 | /* Can we umount this guy */ |
258 | if (!autofs4_can_expire(dentry, timeout, do_now)) | 324 | if (autofs4_mount_busy(mnt, dentry)) |
259 | goto next; | 325 | goto next; |
260 | 326 | ||
261 | /* Can we umount this guy */ | 327 | /* Can we expire this guy */ |
262 | if (autofs4_check_mount(mnt, dentry)) { | 328 | if (autofs4_can_expire(dentry, timeout, do_now)) { |
263 | expired = dentry; | 329 | expired = dentry; |
264 | break; | 330 | break; |
265 | } | 331 | } |
266 | goto next; | 332 | goto next; |
267 | } | 333 | } |
268 | 334 | ||
269 | if ( simple_empty(dentry) ) | 335 | if (simple_empty(dentry)) |
270 | goto next; | 336 | goto next; |
271 | 337 | ||
272 | /* Case 2: tree mount, expire iff entire tree is not busy */ | 338 | /* Case 2: tree mount, expire iff entire tree is not busy */ |
273 | if (!exp_leaves) { | 339 | if (!exp_leaves) { |
274 | /* Lock the tree as we must expire as a whole */ | 340 | /* Lock the tree as we must expire as a whole */ |
275 | spin_lock(&sbi->fs_lock); | 341 | spin_lock(&sbi->fs_lock); |
276 | if (autofs4_check_tree(mnt, dentry, timeout, do_now)) { | 342 | if (!autofs4_tree_busy(mnt, dentry, timeout, do_now)) { |
277 | struct autofs_info *inf = autofs4_dentry_ino(dentry); | 343 | struct autofs_info *inf = autofs4_dentry_ino(dentry); |
278 | 344 | ||
279 | /* Set this flag early to catch sys_chdir and the like */ | 345 | /* Set this flag early to catch sys_chdir and the like */ |
@@ -283,7 +349,10 @@ static struct dentry *autofs4_expire(struct super_block *sb, | |||
283 | break; | 349 | break; |
284 | } | 350 | } |
285 | spin_unlock(&sbi->fs_lock); | 351 | spin_unlock(&sbi->fs_lock); |
286 | /* Case 3: direct mount, expire individual leaves */ | 352 | /* |
353 | * Case 3: pseudo direct mount, expire individual leaves | ||
354 | * (autofs-4.1). | ||
355 | */ | ||
287 | } else { | 356 | } else { |
288 | expired = autofs4_check_leaves(mnt, dentry, timeout, do_now); | 357 | expired = autofs4_check_leaves(mnt, dentry, timeout, do_now); |
289 | if (expired) { | 358 | if (expired) { |
@@ -297,7 +366,7 @@ next: | |||
297 | next = next->next; | 366 | next = next->next; |
298 | } | 367 | } |
299 | 368 | ||
300 | if ( expired ) { | 369 | if (expired) { |
301 | DPRINTK("returning %p %.*s", | 370 | DPRINTK("returning %p %.*s", |
302 | expired, (int)expired->d_name.len, expired->d_name.name); | 371 | expired, (int)expired->d_name.len, expired->d_name.name); |
303 | spin_lock(&dcache_lock); | 372 | spin_lock(&dcache_lock); |
@@ -325,7 +394,7 @@ int autofs4_expire_run(struct super_block *sb, | |||
325 | pkt.hdr.proto_version = sbi->version; | 394 | pkt.hdr.proto_version = sbi->version; |
326 | pkt.hdr.type = autofs_ptype_expire; | 395 | pkt.hdr.type = autofs_ptype_expire; |
327 | 396 | ||
328 | if ((dentry = autofs4_expire(sb, mnt, sbi, 0)) == NULL) | 397 | if ((dentry = autofs4_expire_indirect(sb, mnt, sbi, 0)) == NULL) |
329 | return -EAGAIN; | 398 | return -EAGAIN; |
330 | 399 | ||
331 | pkt.len = dentry->d_name.len; | 400 | pkt.len = dentry->d_name.len; |
@@ -351,17 +420,22 @@ int autofs4_expire_multi(struct super_block *sb, struct vfsmount *mnt, | |||
351 | if (arg && get_user(do_now, arg)) | 420 | if (arg && get_user(do_now, arg)) |
352 | return -EFAULT; | 421 | return -EFAULT; |
353 | 422 | ||
354 | if ((dentry = autofs4_expire(sb, mnt, sbi, do_now)) != NULL) { | 423 | if (sbi->type & AUTOFS_TYPE_DIRECT) |
355 | struct autofs_info *de_info = autofs4_dentry_ino(dentry); | 424 | dentry = autofs4_expire_direct(sb, mnt, sbi, do_now); |
425 | else | ||
426 | dentry = autofs4_expire_indirect(sb, mnt, sbi, do_now); | ||
427 | |||
428 | if (dentry) { | ||
429 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
356 | 430 | ||
357 | /* This is synchronous because it makes the daemon a | 431 | /* This is synchronous because it makes the daemon a |
358 | little easier */ | 432 | little easier */ |
359 | de_info->flags |= AUTOFS_INF_EXPIRING; | 433 | ino->flags |= AUTOFS_INF_EXPIRING; |
360 | ret = autofs4_wait(sbi, dentry, NFY_EXPIRE); | 434 | ret = autofs4_wait(sbi, dentry, NFY_EXPIRE); |
361 | de_info->flags &= ~AUTOFS_INF_EXPIRING; | 435 | ino->flags &= ~AUTOFS_INF_EXPIRING; |
362 | dput(dentry); | 436 | dput(dentry); |
363 | } | 437 | } |
364 | 438 | ||
365 | return ret; | 439 | return ret; |
366 | } | 440 | } |
367 | 441 | ||
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index 1ad98d48e550..fde78b110ddd 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c | |||
@@ -3,6 +3,7 @@ | |||
3 | * linux/fs/autofs/inode.c | 3 | * linux/fs/autofs/inode.c |
4 | * | 4 | * |
5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved | 5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved |
6 | * Copyright 2005-2006 Ian Kent <raven@themaw.net> | ||
6 | * | 7 | * |
7 | * This file is part of the Linux kernel and is made available under | 8 | * This file is part of the Linux kernel and is made available under |
8 | * the terms of the GNU General Public License, version 2, or at your | 9 | * the terms of the GNU General Public License, version 2, or at your |
@@ -13,6 +14,7 @@ | |||
13 | #include <linux/kernel.h> | 14 | #include <linux/kernel.h> |
14 | #include <linux/slab.h> | 15 | #include <linux/slab.h> |
15 | #include <linux/file.h> | 16 | #include <linux/file.h> |
17 | #include <linux/seq_file.h> | ||
16 | #include <linux/pagemap.h> | 18 | #include <linux/pagemap.h> |
17 | #include <linux/parser.h> | 19 | #include <linux/parser.h> |
18 | #include <linux/bitops.h> | 20 | #include <linux/bitops.h> |
@@ -46,6 +48,7 @@ struct autofs_info *autofs4_init_ino(struct autofs_info *ino, | |||
46 | ino->size = 0; | 48 | ino->size = 0; |
47 | 49 | ||
48 | ino->last_used = jiffies; | 50 | ino->last_used = jiffies; |
51 | atomic_set(&ino->count, 0); | ||
49 | 52 | ||
50 | ino->sbi = sbi; | 53 | ino->sbi = sbi; |
51 | 54 | ||
@@ -64,10 +67,19 @@ struct autofs_info *autofs4_init_ino(struct autofs_info *ino, | |||
64 | 67 | ||
65 | void autofs4_free_ino(struct autofs_info *ino) | 68 | void autofs4_free_ino(struct autofs_info *ino) |
66 | { | 69 | { |
70 | struct autofs_info *p_ino; | ||
71 | |||
67 | if (ino->dentry) { | 72 | if (ino->dentry) { |
68 | ino->dentry->d_fsdata = NULL; | 73 | ino->dentry->d_fsdata = NULL; |
69 | if (ino->dentry->d_inode) | 74 | if (ino->dentry->d_inode) { |
75 | struct dentry *parent = ino->dentry->d_parent; | ||
76 | if (atomic_dec_and_test(&ino->count)) { | ||
77 | p_ino = autofs4_dentry_ino(parent); | ||
78 | if (p_ino && parent != ino->dentry) | ||
79 | atomic_dec(&p_ino->count); | ||
80 | } | ||
70 | dput(ino->dentry); | 81 | dput(ino->dentry); |
82 | } | ||
71 | ino->dentry = NULL; | 83 | ino->dentry = NULL; |
72 | } | 84 | } |
73 | if (ino->free) | 85 | if (ino->free) |
@@ -145,20 +157,44 @@ static void autofs4_put_super(struct super_block *sb) | |||
145 | autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */ | 157 | autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */ |
146 | 158 | ||
147 | /* Clean up and release dangling references */ | 159 | /* Clean up and release dangling references */ |
148 | if (sbi) | 160 | autofs4_force_release(sbi); |
149 | autofs4_force_release(sbi); | ||
150 | 161 | ||
151 | kfree(sbi); | 162 | kfree(sbi); |
152 | 163 | ||
153 | DPRINTK("shutting down"); | 164 | DPRINTK("shutting down"); |
154 | } | 165 | } |
155 | 166 | ||
167 | static int autofs4_show_options(struct seq_file *m, struct vfsmount *mnt) | ||
168 | { | ||
169 | struct autofs_sb_info *sbi = autofs4_sbi(mnt->mnt_sb); | ||
170 | |||
171 | if (!sbi) | ||
172 | return 0; | ||
173 | |||
174 | seq_printf(m, ",fd=%d", sbi->pipefd); | ||
175 | seq_printf(m, ",pgrp=%d", sbi->oz_pgrp); | ||
176 | seq_printf(m, ",timeout=%lu", sbi->exp_timeout/HZ); | ||
177 | seq_printf(m, ",minproto=%d", sbi->min_proto); | ||
178 | seq_printf(m, ",maxproto=%d", sbi->max_proto); | ||
179 | |||
180 | if (sbi->type & AUTOFS_TYPE_OFFSET) | ||
181 | seq_printf(m, ",offset"); | ||
182 | else if (sbi->type & AUTOFS_TYPE_DIRECT) | ||
183 | seq_printf(m, ",direct"); | ||
184 | else | ||
185 | seq_printf(m, ",indirect"); | ||
186 | |||
187 | return 0; | ||
188 | } | ||
189 | |||
156 | static struct super_operations autofs4_sops = { | 190 | static struct super_operations autofs4_sops = { |
157 | .put_super = autofs4_put_super, | 191 | .put_super = autofs4_put_super, |
158 | .statfs = simple_statfs, | 192 | .statfs = simple_statfs, |
193 | .show_options = autofs4_show_options, | ||
159 | }; | 194 | }; |
160 | 195 | ||
161 | enum {Opt_err, Opt_fd, Opt_uid, Opt_gid, Opt_pgrp, Opt_minproto, Opt_maxproto}; | 196 | enum {Opt_err, Opt_fd, Opt_uid, Opt_gid, Opt_pgrp, Opt_minproto, Opt_maxproto, |
197 | Opt_indirect, Opt_direct, Opt_offset}; | ||
162 | 198 | ||
163 | static match_table_t tokens = { | 199 | static match_table_t tokens = { |
164 | {Opt_fd, "fd=%u"}, | 200 | {Opt_fd, "fd=%u"}, |
@@ -167,11 +203,15 @@ static match_table_t tokens = { | |||
167 | {Opt_pgrp, "pgrp=%u"}, | 203 | {Opt_pgrp, "pgrp=%u"}, |
168 | {Opt_minproto, "minproto=%u"}, | 204 | {Opt_minproto, "minproto=%u"}, |
169 | {Opt_maxproto, "maxproto=%u"}, | 205 | {Opt_maxproto, "maxproto=%u"}, |
206 | {Opt_indirect, "indirect"}, | ||
207 | {Opt_direct, "direct"}, | ||
208 | {Opt_offset, "offset"}, | ||
170 | {Opt_err, NULL} | 209 | {Opt_err, NULL} |
171 | }; | 210 | }; |
172 | 211 | ||
173 | static int parse_options(char *options, int *pipefd, uid_t *uid, gid_t *gid, | 212 | static int parse_options(char *options, int *pipefd, uid_t *uid, gid_t *gid, |
174 | pid_t *pgrp, int *minproto, int *maxproto) | 213 | pid_t *pgrp, unsigned int *type, |
214 | int *minproto, int *maxproto) | ||
175 | { | 215 | { |
176 | char *p; | 216 | char *p; |
177 | substring_t args[MAX_OPT_ARGS]; | 217 | substring_t args[MAX_OPT_ARGS]; |
@@ -225,6 +265,15 @@ static int parse_options(char *options, int *pipefd, uid_t *uid, gid_t *gid, | |||
225 | return 1; | 265 | return 1; |
226 | *maxproto = option; | 266 | *maxproto = option; |
227 | break; | 267 | break; |
268 | case Opt_indirect: | ||
269 | *type = AUTOFS_TYPE_INDIRECT; | ||
270 | break; | ||
271 | case Opt_direct: | ||
272 | *type = AUTOFS_TYPE_DIRECT; | ||
273 | break; | ||
274 | case Opt_offset: | ||
275 | *type = AUTOFS_TYPE_DIRECT | AUTOFS_TYPE_OFFSET; | ||
276 | break; | ||
228 | default: | 277 | default: |
229 | return 1; | 278 | return 1; |
230 | } | 279 | } |
@@ -243,6 +292,10 @@ static struct autofs_info *autofs4_mkroot(struct autofs_sb_info *sbi) | |||
243 | return ino; | 292 | return ino; |
244 | } | 293 | } |
245 | 294 | ||
295 | static struct dentry_operations autofs4_sb_dentry_operations = { | ||
296 | .d_release = autofs4_dentry_release, | ||
297 | }; | ||
298 | |||
246 | int autofs4_fill_super(struct super_block *s, void *data, int silent) | 299 | int autofs4_fill_super(struct super_block *s, void *data, int silent) |
247 | { | 300 | { |
248 | struct inode * root_inode; | 301 | struct inode * root_inode; |
@@ -251,7 +304,6 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent) | |||
251 | int pipefd; | 304 | int pipefd; |
252 | struct autofs_sb_info *sbi; | 305 | struct autofs_sb_info *sbi; |
253 | struct autofs_info *ino; | 306 | struct autofs_info *ino; |
254 | int minproto, maxproto; | ||
255 | 307 | ||
256 | sbi = (struct autofs_sb_info *) kmalloc(sizeof(*sbi), GFP_KERNEL); | 308 | sbi = (struct autofs_sb_info *) kmalloc(sizeof(*sbi), GFP_KERNEL); |
257 | if ( !sbi ) | 309 | if ( !sbi ) |
@@ -263,12 +315,16 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent) | |||
263 | s->s_fs_info = sbi; | 315 | s->s_fs_info = sbi; |
264 | sbi->magic = AUTOFS_SBI_MAGIC; | 316 | sbi->magic = AUTOFS_SBI_MAGIC; |
265 | sbi->root = NULL; | 317 | sbi->root = NULL; |
318 | sbi->pipefd = -1; | ||
266 | sbi->catatonic = 0; | 319 | sbi->catatonic = 0; |
267 | sbi->exp_timeout = 0; | 320 | sbi->exp_timeout = 0; |
268 | sbi->oz_pgrp = process_group(current); | 321 | sbi->oz_pgrp = process_group(current); |
269 | sbi->sb = s; | 322 | sbi->sb = s; |
270 | sbi->version = 0; | 323 | sbi->version = 0; |
271 | sbi->sub_version = 0; | 324 | sbi->sub_version = 0; |
325 | sbi->type = 0; | ||
326 | sbi->min_proto = 0; | ||
327 | sbi->max_proto = 0; | ||
272 | mutex_init(&sbi->wq_mutex); | 328 | mutex_init(&sbi->wq_mutex); |
273 | spin_lock_init(&sbi->fs_lock); | 329 | spin_lock_init(&sbi->fs_lock); |
274 | sbi->queues = NULL; | 330 | sbi->queues = NULL; |
@@ -285,38 +341,46 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent) | |||
285 | if (!ino) | 341 | if (!ino) |
286 | goto fail_free; | 342 | goto fail_free; |
287 | root_inode = autofs4_get_inode(s, ino); | 343 | root_inode = autofs4_get_inode(s, ino); |
288 | kfree(ino); | ||
289 | if (!root_inode) | 344 | if (!root_inode) |
290 | goto fail_free; | 345 | goto fail_ino; |
291 | 346 | ||
292 | root_inode->i_op = &autofs4_root_inode_operations; | ||
293 | root_inode->i_fop = &autofs4_root_operations; | ||
294 | root = d_alloc_root(root_inode); | 347 | root = d_alloc_root(root_inode); |
295 | pipe = NULL; | ||
296 | |||
297 | if (!root) | 348 | if (!root) |
298 | goto fail_iput; | 349 | goto fail_iput; |
350 | pipe = NULL; | ||
351 | |||
352 | root->d_op = &autofs4_sb_dentry_operations; | ||
353 | root->d_fsdata = ino; | ||
299 | 354 | ||
300 | /* Can this call block? */ | 355 | /* Can this call block? */ |
301 | if (parse_options(data, &pipefd, | 356 | if (parse_options(data, &pipefd, |
302 | &root_inode->i_uid, &root_inode->i_gid, | 357 | &root_inode->i_uid, &root_inode->i_gid, |
303 | &sbi->oz_pgrp, | 358 | &sbi->oz_pgrp, &sbi->type, |
304 | &minproto, &maxproto)) { | 359 | &sbi->min_proto, &sbi->max_proto)) { |
305 | printk("autofs: called with bogus options\n"); | 360 | printk("autofs: called with bogus options\n"); |
306 | goto fail_dput; | 361 | goto fail_dput; |
307 | } | 362 | } |
308 | 363 | ||
364 | root_inode->i_fop = &autofs4_root_operations; | ||
365 | root_inode->i_op = sbi->type & AUTOFS_TYPE_DIRECT ? | ||
366 | &autofs4_direct_root_inode_operations : | ||
367 | &autofs4_indirect_root_inode_operations; | ||
368 | |||
309 | /* Couldn't this be tested earlier? */ | 369 | /* Couldn't this be tested earlier? */ |
310 | if (maxproto < AUTOFS_MIN_PROTO_VERSION || | 370 | if (sbi->max_proto < AUTOFS_MIN_PROTO_VERSION || |
311 | minproto > AUTOFS_MAX_PROTO_VERSION) { | 371 | sbi->min_proto > AUTOFS_MAX_PROTO_VERSION) { |
312 | printk("autofs: kernel does not match daemon version " | 372 | printk("autofs: kernel does not match daemon version " |
313 | "daemon (%d, %d) kernel (%d, %d)\n", | 373 | "daemon (%d, %d) kernel (%d, %d)\n", |
314 | minproto, maxproto, | 374 | sbi->min_proto, sbi->max_proto, |
315 | AUTOFS_MIN_PROTO_VERSION, AUTOFS_MAX_PROTO_VERSION); | 375 | AUTOFS_MIN_PROTO_VERSION, AUTOFS_MAX_PROTO_VERSION); |
316 | goto fail_dput; | 376 | goto fail_dput; |
317 | } | 377 | } |
318 | 378 | ||
319 | sbi->version = maxproto > AUTOFS_MAX_PROTO_VERSION ? AUTOFS_MAX_PROTO_VERSION : maxproto; | 379 | /* Establish highest kernel protocol version */ |
380 | if (sbi->max_proto > AUTOFS_MAX_PROTO_VERSION) | ||
381 | sbi->version = AUTOFS_MAX_PROTO_VERSION; | ||
382 | else | ||
383 | sbi->version = sbi->max_proto; | ||
320 | sbi->sub_version = AUTOFS_PROTO_SUBVERSION; | 384 | sbi->sub_version = AUTOFS_PROTO_SUBVERSION; |
321 | 385 | ||
322 | DPRINTK("pipe fd = %d, pgrp = %u", pipefd, sbi->oz_pgrp); | 386 | DPRINTK("pipe fd = %d, pgrp = %u", pipefd, sbi->oz_pgrp); |
@@ -329,6 +393,7 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent) | |||
329 | if ( !pipe->f_op || !pipe->f_op->write ) | 393 | if ( !pipe->f_op || !pipe->f_op->write ) |
330 | goto fail_fput; | 394 | goto fail_fput; |
331 | sbi->pipe = pipe; | 395 | sbi->pipe = pipe; |
396 | sbi->pipefd = pipefd; | ||
332 | 397 | ||
333 | /* | 398 | /* |
334 | * Take a reference to the root dentry so we get a chance to | 399 | * Take a reference to the root dentry so we get a chance to |
@@ -356,6 +421,8 @@ fail_dput: | |||
356 | fail_iput: | 421 | fail_iput: |
357 | printk("autofs: get root dentry failed\n"); | 422 | printk("autofs: get root dentry failed\n"); |
358 | iput(root_inode); | 423 | iput(root_inode); |
424 | fail_ino: | ||
425 | kfree(ino); | ||
359 | fail_free: | 426 | fail_free: |
360 | kfree(sbi); | 427 | kfree(sbi); |
361 | fail_unlock: | 428 | fail_unlock: |
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 62d8d4acb8bb..84e030c8ddd0 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c | |||
@@ -4,7 +4,7 @@ | |||
4 | * | 4 | * |
5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved | 5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved |
6 | * Copyright 1999-2000 Jeremy Fitzhardinge <jeremy@goop.org> | 6 | * Copyright 1999-2000 Jeremy Fitzhardinge <jeremy@goop.org> |
7 | * Copyright 2001-2003 Ian Kent <raven@themaw.net> | 7 | * Copyright 2001-2006 Ian Kent <raven@themaw.net> |
8 | * | 8 | * |
9 | * This file is part of the Linux kernel and is made available under | 9 | * This file is part of the Linux kernel and is made available under |
10 | * the terms of the GNU General Public License, version 2, or at your | 10 | * the terms of the GNU General Public License, version 2, or at your |
@@ -30,9 +30,9 @@ static int autofs4_dir_close(struct inode *inode, struct file *file); | |||
30 | static int autofs4_dir_readdir(struct file * filp, void * dirent, filldir_t filldir); | 30 | static int autofs4_dir_readdir(struct file * filp, void * dirent, filldir_t filldir); |
31 | static int autofs4_root_readdir(struct file * filp, void * dirent, filldir_t filldir); | 31 | static int autofs4_root_readdir(struct file * filp, void * dirent, filldir_t filldir); |
32 | static struct dentry *autofs4_lookup(struct inode *,struct dentry *, struct nameidata *); | 32 | static struct dentry *autofs4_lookup(struct inode *,struct dentry *, struct nameidata *); |
33 | static int autofs4_dcache_readdir(struct file *, void *, filldir_t); | 33 | static void *autofs4_follow_link(struct dentry *, struct nameidata *); |
34 | 34 | ||
35 | struct file_operations autofs4_root_operations = { | 35 | const struct file_operations autofs4_root_operations = { |
36 | .open = dcache_dir_open, | 36 | .open = dcache_dir_open, |
37 | .release = dcache_dir_close, | 37 | .release = dcache_dir_close, |
38 | .read = generic_read_dir, | 38 | .read = generic_read_dir, |
@@ -40,14 +40,14 @@ struct file_operations autofs4_root_operations = { | |||
40 | .ioctl = autofs4_root_ioctl, | 40 | .ioctl = autofs4_root_ioctl, |
41 | }; | 41 | }; |
42 | 42 | ||
43 | struct file_operations autofs4_dir_operations = { | 43 | const struct file_operations autofs4_dir_operations = { |
44 | .open = autofs4_dir_open, | 44 | .open = autofs4_dir_open, |
45 | .release = autofs4_dir_close, | 45 | .release = autofs4_dir_close, |
46 | .read = generic_read_dir, | 46 | .read = generic_read_dir, |
47 | .readdir = autofs4_dir_readdir, | 47 | .readdir = autofs4_dir_readdir, |
48 | }; | 48 | }; |
49 | 49 | ||
50 | struct inode_operations autofs4_root_inode_operations = { | 50 | struct inode_operations autofs4_indirect_root_inode_operations = { |
51 | .lookup = autofs4_lookup, | 51 | .lookup = autofs4_lookup, |
52 | .unlink = autofs4_dir_unlink, | 52 | .unlink = autofs4_dir_unlink, |
53 | .symlink = autofs4_dir_symlink, | 53 | .symlink = autofs4_dir_symlink, |
@@ -55,6 +55,14 @@ struct inode_operations autofs4_root_inode_operations = { | |||
55 | .rmdir = autofs4_dir_rmdir, | 55 | .rmdir = autofs4_dir_rmdir, |
56 | }; | 56 | }; |
57 | 57 | ||
58 | struct inode_operations autofs4_direct_root_inode_operations = { | ||
59 | .lookup = autofs4_lookup, | ||
60 | .unlink = autofs4_dir_unlink, | ||
61 | .mkdir = autofs4_dir_mkdir, | ||
62 | .rmdir = autofs4_dir_rmdir, | ||
63 | .follow_link = autofs4_follow_link, | ||
64 | }; | ||
65 | |||
58 | struct inode_operations autofs4_dir_inode_operations = { | 66 | struct inode_operations autofs4_dir_inode_operations = { |
59 | .lookup = autofs4_lookup, | 67 | .lookup = autofs4_lookup, |
60 | .unlink = autofs4_dir_unlink, | 68 | .unlink = autofs4_dir_unlink, |
@@ -82,87 +90,7 @@ static int autofs4_root_readdir(struct file *file, void *dirent, | |||
82 | 90 | ||
83 | DPRINTK("needs_reghost = %d", sbi->needs_reghost); | 91 | DPRINTK("needs_reghost = %d", sbi->needs_reghost); |
84 | 92 | ||
85 | return autofs4_dcache_readdir(file, dirent, filldir); | 93 | return dcache_readdir(file, dirent, filldir); |
86 | } | ||
87 | |||
88 | /* Update usage from here to top of tree, so that scan of | ||
89 | top-level directories will give a useful result */ | ||
90 | static void autofs4_update_usage(struct vfsmount *mnt, struct dentry *dentry) | ||
91 | { | ||
92 | struct dentry *top = dentry->d_sb->s_root; | ||
93 | |||
94 | spin_lock(&dcache_lock); | ||
95 | for(; dentry != top; dentry = dentry->d_parent) { | ||
96 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
97 | |||
98 | if (ino) { | ||
99 | touch_atime(mnt, dentry); | ||
100 | ino->last_used = jiffies; | ||
101 | } | ||
102 | } | ||
103 | spin_unlock(&dcache_lock); | ||
104 | } | ||
105 | |||
106 | /* | ||
107 | * From 2.4 kernel readdir.c | ||
108 | */ | ||
109 | static int autofs4_dcache_readdir(struct file * filp, void * dirent, filldir_t filldir) | ||
110 | { | ||
111 | int i; | ||
112 | struct dentry *dentry = filp->f_dentry; | ||
113 | |||
114 | i = filp->f_pos; | ||
115 | switch (i) { | ||
116 | case 0: | ||
117 | if (filldir(dirent, ".", 1, i, dentry->d_inode->i_ino, DT_DIR) < 0) | ||
118 | break; | ||
119 | i++; | ||
120 | filp->f_pos++; | ||
121 | /* fallthrough */ | ||
122 | case 1: | ||
123 | if (filldir(dirent, "..", 2, i, dentry->d_parent->d_inode->i_ino, DT_DIR) < 0) | ||
124 | break; | ||
125 | i++; | ||
126 | filp->f_pos++; | ||
127 | /* fallthrough */ | ||
128 | default: { | ||
129 | struct list_head *list; | ||
130 | int j = i-2; | ||
131 | |||
132 | spin_lock(&dcache_lock); | ||
133 | list = dentry->d_subdirs.next; | ||
134 | |||
135 | for (;;) { | ||
136 | if (list == &dentry->d_subdirs) { | ||
137 | spin_unlock(&dcache_lock); | ||
138 | return 0; | ||
139 | } | ||
140 | if (!j) | ||
141 | break; | ||
142 | j--; | ||
143 | list = list->next; | ||
144 | } | ||
145 | |||
146 | while(1) { | ||
147 | struct dentry *de = list_entry(list, | ||
148 | struct dentry, d_u.d_child); | ||
149 | |||
150 | if (!d_unhashed(de) && de->d_inode) { | ||
151 | spin_unlock(&dcache_lock); | ||
152 | if (filldir(dirent, de->d_name.name, de->d_name.len, filp->f_pos, de->d_inode->i_ino, DT_UNKNOWN) < 0) | ||
153 | break; | ||
154 | spin_lock(&dcache_lock); | ||
155 | } | ||
156 | filp->f_pos++; | ||
157 | list = list->next; | ||
158 | if (list != &dentry->d_subdirs) | ||
159 | continue; | ||
160 | spin_unlock(&dcache_lock); | ||
161 | break; | ||
162 | } | ||
163 | } | ||
164 | } | ||
165 | return 0; | ||
166 | } | 94 | } |
167 | 95 | ||
168 | static int autofs4_dir_open(struct inode *inode, struct file *file) | 96 | static int autofs4_dir_open(struct inode *inode, struct file *file) |
@@ -170,8 +98,16 @@ static int autofs4_dir_open(struct inode *inode, struct file *file) | |||
170 | struct dentry *dentry = file->f_dentry; | 98 | struct dentry *dentry = file->f_dentry; |
171 | struct vfsmount *mnt = file->f_vfsmnt; | 99 | struct vfsmount *mnt = file->f_vfsmnt; |
172 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | 100 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
101 | struct dentry *cursor; | ||
173 | int status; | 102 | int status; |
174 | 103 | ||
104 | status = dcache_dir_open(inode, file); | ||
105 | if (status) | ||
106 | goto out; | ||
107 | |||
108 | cursor = file->private_data; | ||
109 | cursor->d_fsdata = NULL; | ||
110 | |||
175 | DPRINTK("file=%p dentry=%p %.*s", | 111 | DPRINTK("file=%p dentry=%p %.*s", |
176 | file, dentry, dentry->d_name.len, dentry->d_name.name); | 112 | file, dentry, dentry->d_name.len, dentry->d_name.name); |
177 | 113 | ||
@@ -180,12 +116,15 @@ static int autofs4_dir_open(struct inode *inode, struct file *file) | |||
180 | 116 | ||
181 | if (autofs4_ispending(dentry)) { | 117 | if (autofs4_ispending(dentry)) { |
182 | DPRINTK("dentry busy"); | 118 | DPRINTK("dentry busy"); |
183 | return -EBUSY; | 119 | dcache_dir_close(inode, file); |
120 | status = -EBUSY; | ||
121 | goto out; | ||
184 | } | 122 | } |
185 | 123 | ||
124 | status = -ENOENT; | ||
186 | if (!d_mountpoint(dentry) && dentry->d_op && dentry->d_op->d_revalidate) { | 125 | if (!d_mountpoint(dentry) && dentry->d_op && dentry->d_op->d_revalidate) { |
187 | struct nameidata nd; | 126 | struct nameidata nd; |
188 | int empty; | 127 | int empty, ret; |
189 | 128 | ||
190 | /* In case there are stale directory dentrys from a failed mount */ | 129 | /* In case there are stale directory dentrys from a failed mount */ |
191 | spin_lock(&dcache_lock); | 130 | spin_lock(&dcache_lock); |
@@ -195,13 +134,13 @@ static int autofs4_dir_open(struct inode *inode, struct file *file) | |||
195 | if (!empty) | 134 | if (!empty) |
196 | d_invalidate(dentry); | 135 | d_invalidate(dentry); |
197 | 136 | ||
198 | nd.dentry = dentry; | ||
199 | nd.mnt = mnt; | ||
200 | nd.flags = LOOKUP_DIRECTORY; | 137 | nd.flags = LOOKUP_DIRECTORY; |
201 | status = (dentry->d_op->d_revalidate)(dentry, &nd); | 138 | ret = (dentry->d_op->d_revalidate)(dentry, &nd); |
202 | 139 | ||
203 | if (!status) | 140 | if (!ret) { |
204 | return -ENOENT; | 141 | dcache_dir_close(inode, file); |
142 | goto out; | ||
143 | } | ||
205 | } | 144 | } |
206 | 145 | ||
207 | if (d_mountpoint(dentry)) { | 146 | if (d_mountpoint(dentry)) { |
@@ -212,25 +151,29 @@ static int autofs4_dir_open(struct inode *inode, struct file *file) | |||
212 | if (!autofs4_follow_mount(&fp_mnt, &fp_dentry)) { | 151 | if (!autofs4_follow_mount(&fp_mnt, &fp_dentry)) { |
213 | dput(fp_dentry); | 152 | dput(fp_dentry); |
214 | mntput(fp_mnt); | 153 | mntput(fp_mnt); |
215 | return -ENOENT; | 154 | dcache_dir_close(inode, file); |
155 | goto out; | ||
216 | } | 156 | } |
217 | 157 | ||
218 | fp = dentry_open(fp_dentry, fp_mnt, file->f_flags); | 158 | fp = dentry_open(fp_dentry, fp_mnt, file->f_flags); |
219 | status = PTR_ERR(fp); | 159 | status = PTR_ERR(fp); |
220 | if (IS_ERR(fp)) { | 160 | if (IS_ERR(fp)) { |
221 | file->private_data = NULL; | 161 | dcache_dir_close(inode, file); |
222 | return status; | 162 | goto out; |
223 | } | 163 | } |
224 | file->private_data = fp; | 164 | cursor->d_fsdata = fp; |
225 | } | 165 | } |
226 | out: | ||
227 | return 0; | 166 | return 0; |
167 | out: | ||
168 | return status; | ||
228 | } | 169 | } |
229 | 170 | ||
230 | static int autofs4_dir_close(struct inode *inode, struct file *file) | 171 | static int autofs4_dir_close(struct inode *inode, struct file *file) |
231 | { | 172 | { |
232 | struct dentry *dentry = file->f_dentry; | 173 | struct dentry *dentry = file->f_dentry; |
233 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | 174 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
175 | struct dentry *cursor = file->private_data; | ||
176 | int status = 0; | ||
234 | 177 | ||
235 | DPRINTK("file=%p dentry=%p %.*s", | 178 | DPRINTK("file=%p dentry=%p %.*s", |
236 | file, dentry, dentry->d_name.len, dentry->d_name.name); | 179 | file, dentry, dentry->d_name.len, dentry->d_name.name); |
@@ -240,26 +183,28 @@ static int autofs4_dir_close(struct inode *inode, struct file *file) | |||
240 | 183 | ||
241 | if (autofs4_ispending(dentry)) { | 184 | if (autofs4_ispending(dentry)) { |
242 | DPRINTK("dentry busy"); | 185 | DPRINTK("dentry busy"); |
243 | return -EBUSY; | 186 | status = -EBUSY; |
187 | goto out; | ||
244 | } | 188 | } |
245 | 189 | ||
246 | if (d_mountpoint(dentry)) { | 190 | if (d_mountpoint(dentry)) { |
247 | struct file *fp = file->private_data; | 191 | struct file *fp = cursor->d_fsdata; |
248 | 192 | if (!fp) { | |
249 | if (!fp) | 193 | status = -ENOENT; |
250 | return -ENOENT; | 194 | goto out; |
251 | 195 | } | |
252 | filp_close(fp, current->files); | 196 | filp_close(fp, current->files); |
253 | file->private_data = NULL; | ||
254 | } | 197 | } |
255 | out: | 198 | out: |
256 | return 0; | 199 | dcache_dir_close(inode, file); |
200 | return status; | ||
257 | } | 201 | } |
258 | 202 | ||
259 | static int autofs4_dir_readdir(struct file *file, void *dirent, filldir_t filldir) | 203 | static int autofs4_dir_readdir(struct file *file, void *dirent, filldir_t filldir) |
260 | { | 204 | { |
261 | struct dentry *dentry = file->f_dentry; | 205 | struct dentry *dentry = file->f_dentry; |
262 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | 206 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
207 | struct dentry *cursor = file->private_data; | ||
263 | int status; | 208 | int status; |
264 | 209 | ||
265 | DPRINTK("file=%p dentry=%p %.*s", | 210 | DPRINTK("file=%p dentry=%p %.*s", |
@@ -274,7 +219,7 @@ static int autofs4_dir_readdir(struct file *file, void *dirent, filldir_t filldi | |||
274 | } | 219 | } |
275 | 220 | ||
276 | if (d_mountpoint(dentry)) { | 221 | if (d_mountpoint(dentry)) { |
277 | struct file *fp = file->private_data; | 222 | struct file *fp = cursor->d_fsdata; |
278 | 223 | ||
279 | if (!fp) | 224 | if (!fp) |
280 | return -ENOENT; | 225 | return -ENOENT; |
@@ -289,27 +234,26 @@ static int autofs4_dir_readdir(struct file *file, void *dirent, filldir_t filldi | |||
289 | return status; | 234 | return status; |
290 | } | 235 | } |
291 | out: | 236 | out: |
292 | return autofs4_dcache_readdir(file, dirent, filldir); | 237 | return dcache_readdir(file, dirent, filldir); |
293 | } | 238 | } |
294 | 239 | ||
295 | static int try_to_fill_dentry(struct vfsmount *mnt, struct dentry *dentry, int flags) | 240 | static int try_to_fill_dentry(struct dentry *dentry, int flags) |
296 | { | 241 | { |
297 | struct super_block *sb = mnt->mnt_sb; | 242 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
298 | struct autofs_sb_info *sbi = autofs4_sbi(sb); | 243 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
299 | struct autofs_info *de_info = autofs4_dentry_ino(dentry); | ||
300 | int status = 0; | 244 | int status = 0; |
301 | 245 | ||
302 | /* Block on any pending expiry here; invalidate the dentry | 246 | /* Block on any pending expiry here; invalidate the dentry |
303 | when expiration is done to trigger mount request with a new | 247 | when expiration is done to trigger mount request with a new |
304 | dentry */ | 248 | dentry */ |
305 | if (de_info && (de_info->flags & AUTOFS_INF_EXPIRING)) { | 249 | if (ino && (ino->flags & AUTOFS_INF_EXPIRING)) { |
306 | DPRINTK("waiting for expire %p name=%.*s", | 250 | DPRINTK("waiting for expire %p name=%.*s", |
307 | dentry, dentry->d_name.len, dentry->d_name.name); | 251 | dentry, dentry->d_name.len, dentry->d_name.name); |
308 | 252 | ||
309 | status = autofs4_wait(sbi, dentry, NFY_NONE); | 253 | status = autofs4_wait(sbi, dentry, NFY_NONE); |
310 | 254 | ||
311 | DPRINTK("expire done status=%d", status); | 255 | DPRINTK("expire done status=%d", status); |
312 | 256 | ||
313 | /* | 257 | /* |
314 | * If the directory still exists the mount request must | 258 | * If the directory still exists the mount request must |
315 | * continue otherwise it can't be followed at the right | 259 | * continue otherwise it can't be followed at the right |
@@ -317,34 +261,36 @@ static int try_to_fill_dentry(struct vfsmount *mnt, struct dentry *dentry, int f | |||
317 | */ | 261 | */ |
318 | status = d_invalidate(dentry); | 262 | status = d_invalidate(dentry); |
319 | if (status != -EBUSY) | 263 | if (status != -EBUSY) |
320 | return 0; | 264 | return -ENOENT; |
321 | } | 265 | } |
322 | 266 | ||
323 | DPRINTK("dentry=%p %.*s ino=%p", | 267 | DPRINTK("dentry=%p %.*s ino=%p", |
324 | dentry, dentry->d_name.len, dentry->d_name.name, dentry->d_inode); | 268 | dentry, dentry->d_name.len, dentry->d_name.name, dentry->d_inode); |
325 | 269 | ||
326 | /* Wait for a pending mount, triggering one if there isn't one already */ | 270 | /* |
271 | * Wait for a pending mount, triggering one if there | ||
272 | * isn't one already | ||
273 | */ | ||
327 | if (dentry->d_inode == NULL) { | 274 | if (dentry->d_inode == NULL) { |
328 | DPRINTK("waiting for mount name=%.*s", | 275 | DPRINTK("waiting for mount name=%.*s", |
329 | dentry->d_name.len, dentry->d_name.name); | 276 | dentry->d_name.len, dentry->d_name.name); |
330 | 277 | ||
331 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); | 278 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); |
332 | 279 | ||
333 | DPRINTK("mount done status=%d", status); | 280 | DPRINTK("mount done status=%d", status); |
334 | 281 | ||
335 | if (status && dentry->d_inode) | 282 | if (status && dentry->d_inode) |
336 | return 0; /* Try to get the kernel to invalidate this dentry */ | 283 | return status; /* Try to get the kernel to invalidate this dentry */ |
337 | 284 | ||
338 | /* Turn this into a real negative dentry? */ | 285 | /* Turn this into a real negative dentry? */ |
339 | if (status == -ENOENT) { | 286 | if (status == -ENOENT) { |
340 | dentry->d_time = jiffies + AUTOFS_NEGATIVE_TIMEOUT; | ||
341 | spin_lock(&dentry->d_lock); | 287 | spin_lock(&dentry->d_lock); |
342 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; | 288 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; |
343 | spin_unlock(&dentry->d_lock); | 289 | spin_unlock(&dentry->d_lock); |
344 | return 1; | 290 | return status; |
345 | } else if (status) { | 291 | } else if (status) { |
346 | /* Return a negative dentry, but leave it "pending" */ | 292 | /* Return a negative dentry, but leave it "pending" */ |
347 | return 1; | 293 | return status; |
348 | } | 294 | } |
349 | /* Trigger mount for path component or follow link */ | 295 | /* Trigger mount for path component or follow link */ |
350 | } else if (flags & (LOOKUP_CONTINUE | LOOKUP_DIRECTORY) || | 296 | } else if (flags & (LOOKUP_CONTINUE | LOOKUP_DIRECTORY) || |
@@ -363,19 +309,87 @@ static int try_to_fill_dentry(struct vfsmount *mnt, struct dentry *dentry, int f | |||
363 | spin_lock(&dentry->d_lock); | 309 | spin_lock(&dentry->d_lock); |
364 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; | 310 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; |
365 | spin_unlock(&dentry->d_lock); | 311 | spin_unlock(&dentry->d_lock); |
366 | return 0; | 312 | return status; |
367 | } | 313 | } |
368 | } | 314 | } |
369 | 315 | ||
370 | /* We don't update the usages for the autofs daemon itself, this | 316 | /* Initialize expiry counter after successful mount */ |
371 | is necessary for recursive autofs mounts */ | 317 | if (ino) |
372 | if (!autofs4_oz_mode(sbi)) | 318 | ino->last_used = jiffies; |
373 | autofs4_update_usage(mnt, dentry); | ||
374 | 319 | ||
375 | spin_lock(&dentry->d_lock); | 320 | spin_lock(&dentry->d_lock); |
376 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; | 321 | dentry->d_flags &= ~DCACHE_AUTOFS_PENDING; |
377 | spin_unlock(&dentry->d_lock); | 322 | spin_unlock(&dentry->d_lock); |
378 | return 1; | 323 | return status; |
324 | } | ||
325 | |||
326 | /* For autofs direct mounts the follow link triggers the mount */ | ||
327 | static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd) | ||
328 | { | ||
329 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | ||
330 | int oz_mode = autofs4_oz_mode(sbi); | ||
331 | unsigned int lookup_type; | ||
332 | int status; | ||
333 | |||
334 | DPRINTK("dentry=%p %.*s oz_mode=%d nd->flags=%d", | ||
335 | dentry, dentry->d_name.len, dentry->d_name.name, oz_mode, | ||
336 | nd->flags); | ||
337 | |||
338 | /* If it's our master or we shouldn't trigger a mount we're done */ | ||
339 | lookup_type = nd->flags & (LOOKUP_CONTINUE | LOOKUP_DIRECTORY); | ||
340 | if (oz_mode || !lookup_type) | ||
341 | goto done; | ||
342 | |||
343 | /* | ||
344 | * If a request is pending wait for it. | ||
345 | * If it's a mount then it won't be expired till at least | ||
346 | * a liitle later and if it's an expire then we might need | ||
347 | * to mount it again. | ||
348 | */ | ||
349 | if (autofs4_ispending(dentry)) { | ||
350 | DPRINTK("waiting for active request %p name=%.*s", | ||
351 | dentry, dentry->d_name.len, dentry->d_name.name); | ||
352 | |||
353 | status = autofs4_wait(sbi, dentry, NFY_NONE); | ||
354 | |||
355 | DPRINTK("request done status=%d", status); | ||
356 | } | ||
357 | |||
358 | /* | ||
359 | * If the dentry contains directories then it is an | ||
360 | * autofs multi-mount with no root mount offset. So | ||
361 | * don't try to mount it again. | ||
362 | */ | ||
363 | spin_lock(&dcache_lock); | ||
364 | if (!d_mountpoint(dentry) && list_empty(&dentry->d_subdirs)) { | ||
365 | spin_unlock(&dcache_lock); | ||
366 | |||
367 | status = try_to_fill_dentry(dentry, 0); | ||
368 | if (status) | ||
369 | goto out_error; | ||
370 | |||
371 | /* | ||
372 | * The mount succeeded but if there is no root mount | ||
373 | * it must be an autofs multi-mount with no root offset | ||
374 | * so we don't need to follow the mount. | ||
375 | */ | ||
376 | if (d_mountpoint(dentry)) { | ||
377 | if (!autofs4_follow_mount(&nd->mnt, &nd->dentry)) { | ||
378 | status = -ENOENT; | ||
379 | goto out_error; | ||
380 | } | ||
381 | } | ||
382 | |||
383 | goto done; | ||
384 | } | ||
385 | spin_unlock(&dcache_lock); | ||
386 | |||
387 | done: | ||
388 | return NULL; | ||
389 | |||
390 | out_error: | ||
391 | path_release(nd); | ||
392 | return ERR_PTR(status); | ||
379 | } | 393 | } |
380 | 394 | ||
381 | /* | 395 | /* |
@@ -384,47 +398,43 @@ static int try_to_fill_dentry(struct vfsmount *mnt, struct dentry *dentry, int f | |||
384 | * yet completely filled in, and revalidate has to delay such | 398 | * yet completely filled in, and revalidate has to delay such |
385 | * lookups.. | 399 | * lookups.. |
386 | */ | 400 | */ |
387 | static int autofs4_revalidate(struct dentry * dentry, struct nameidata *nd) | 401 | static int autofs4_revalidate(struct dentry *dentry, struct nameidata *nd) |
388 | { | 402 | { |
389 | struct inode * dir = dentry->d_parent->d_inode; | 403 | struct inode *dir = dentry->d_parent->d_inode; |
390 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 404 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
391 | int oz_mode = autofs4_oz_mode(sbi); | 405 | int oz_mode = autofs4_oz_mode(sbi); |
392 | int flags = nd ? nd->flags : 0; | 406 | int flags = nd ? nd->flags : 0; |
393 | int status = 1; | 407 | int status = 0; |
394 | 408 | ||
395 | /* Pending dentry */ | 409 | /* Pending dentry */ |
396 | if (autofs4_ispending(dentry)) { | 410 | if (autofs4_ispending(dentry)) { |
397 | if (!oz_mode) | 411 | if (!oz_mode) |
398 | status = try_to_fill_dentry(nd->mnt, dentry, flags); | 412 | status = try_to_fill_dentry(dentry, flags); |
399 | return status; | 413 | return !status; |
400 | } | 414 | } |
401 | 415 | ||
402 | /* Negative dentry.. invalidate if "old" */ | 416 | /* Negative dentry.. invalidate if "old" */ |
403 | if (dentry->d_inode == NULL) | 417 | if (dentry->d_inode == NULL) |
404 | return (dentry->d_time - jiffies <= AUTOFS_NEGATIVE_TIMEOUT); | 418 | return 0; |
405 | 419 | ||
406 | /* Check for a non-mountpoint directory with no contents */ | 420 | /* Check for a non-mountpoint directory with no contents */ |
407 | spin_lock(&dcache_lock); | 421 | spin_lock(&dcache_lock); |
408 | if (S_ISDIR(dentry->d_inode->i_mode) && | 422 | if (S_ISDIR(dentry->d_inode->i_mode) && |
409 | !d_mountpoint(dentry) && | 423 | !d_mountpoint(dentry) && |
410 | list_empty(&dentry->d_subdirs)) { | 424 | __simple_empty(dentry)) { |
411 | DPRINTK("dentry=%p %.*s, emptydir", | 425 | DPRINTK("dentry=%p %.*s, emptydir", |
412 | dentry, dentry->d_name.len, dentry->d_name.name); | 426 | dentry, dentry->d_name.len, dentry->d_name.name); |
413 | spin_unlock(&dcache_lock); | 427 | spin_unlock(&dcache_lock); |
414 | if (!oz_mode) | 428 | if (!oz_mode) |
415 | status = try_to_fill_dentry(nd->mnt, dentry, flags); | 429 | status = try_to_fill_dentry(dentry, flags); |
416 | return status; | 430 | return !status; |
417 | } | 431 | } |
418 | spin_unlock(&dcache_lock); | 432 | spin_unlock(&dcache_lock); |
419 | 433 | ||
420 | /* Update the usage list */ | ||
421 | if (!oz_mode) | ||
422 | autofs4_update_usage(nd->mnt, dentry); | ||
423 | |||
424 | return 1; | 434 | return 1; |
425 | } | 435 | } |
426 | 436 | ||
427 | static void autofs4_dentry_release(struct dentry *de) | 437 | void autofs4_dentry_release(struct dentry *de) |
428 | { | 438 | { |
429 | struct autofs_info *inf; | 439 | struct autofs_info *inf; |
430 | 440 | ||
@@ -462,12 +472,13 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
462 | DPRINTK("name = %.*s", | 472 | DPRINTK("name = %.*s", |
463 | dentry->d_name.len, dentry->d_name.name); | 473 | dentry->d_name.len, dentry->d_name.name); |
464 | 474 | ||
475 | /* File name too long to exist */ | ||
465 | if (dentry->d_name.len > NAME_MAX) | 476 | if (dentry->d_name.len > NAME_MAX) |
466 | return ERR_PTR(-ENAMETOOLONG);/* File name too long to exist */ | 477 | return ERR_PTR(-ENAMETOOLONG); |
467 | 478 | ||
468 | sbi = autofs4_sbi(dir->i_sb); | 479 | sbi = autofs4_sbi(dir->i_sb); |
469 | |||
470 | oz_mode = autofs4_oz_mode(sbi); | 480 | oz_mode = autofs4_oz_mode(sbi); |
481 | |||
471 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", | 482 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", |
472 | current->pid, process_group(current), sbi->catatonic, oz_mode); | 483 | current->pid, process_group(current), sbi->catatonic, oz_mode); |
473 | 484 | ||
@@ -519,7 +530,7 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
519 | * doesn't do the right thing for all system calls, but it should | 530 | * doesn't do the right thing for all system calls, but it should |
520 | * be OK for the operations we permit from an autofs. | 531 | * be OK for the operations we permit from an autofs. |
521 | */ | 532 | */ |
522 | if ( dentry->d_inode && d_unhashed(dentry) ) | 533 | if (dentry->d_inode && d_unhashed(dentry)) |
523 | return ERR_PTR(-ENOENT); | 534 | return ERR_PTR(-ENOENT); |
524 | 535 | ||
525 | return NULL; | 536 | return NULL; |
@@ -531,6 +542,7 @@ static int autofs4_dir_symlink(struct inode *dir, | |||
531 | { | 542 | { |
532 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 543 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
533 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 544 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
545 | struct autofs_info *p_ino; | ||
534 | struct inode *inode; | 546 | struct inode *inode; |
535 | char *cp; | 547 | char *cp; |
536 | 548 | ||
@@ -564,6 +576,10 @@ static int autofs4_dir_symlink(struct inode *dir, | |||
564 | 576 | ||
565 | dentry->d_fsdata = ino; | 577 | dentry->d_fsdata = ino; |
566 | ino->dentry = dget(dentry); | 578 | ino->dentry = dget(dentry); |
579 | atomic_inc(&ino->count); | ||
580 | p_ino = autofs4_dentry_ino(dentry->d_parent); | ||
581 | if (p_ino && dentry->d_parent != dentry) | ||
582 | atomic_inc(&p_ino->count); | ||
567 | ino->inode = inode; | 583 | ino->inode = inode; |
568 | 584 | ||
569 | dir->i_mtime = CURRENT_TIME; | 585 | dir->i_mtime = CURRENT_TIME; |
@@ -590,11 +606,17 @@ static int autofs4_dir_unlink(struct inode *dir, struct dentry *dentry) | |||
590 | { | 606 | { |
591 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 607 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
592 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 608 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
609 | struct autofs_info *p_ino; | ||
593 | 610 | ||
594 | /* This allows root to remove symlinks */ | 611 | /* This allows root to remove symlinks */ |
595 | if ( !autofs4_oz_mode(sbi) && !capable(CAP_SYS_ADMIN) ) | 612 | if ( !autofs4_oz_mode(sbi) && !capable(CAP_SYS_ADMIN) ) |
596 | return -EACCES; | 613 | return -EACCES; |
597 | 614 | ||
615 | if (atomic_dec_and_test(&ino->count)) { | ||
616 | p_ino = autofs4_dentry_ino(dentry->d_parent); | ||
617 | if (p_ino && dentry->d_parent != dentry) | ||
618 | atomic_dec(&p_ino->count); | ||
619 | } | ||
598 | dput(ino->dentry); | 620 | dput(ino->dentry); |
599 | 621 | ||
600 | dentry->d_inode->i_size = 0; | 622 | dentry->d_inode->i_size = 0; |
@@ -611,6 +633,7 @@ static int autofs4_dir_rmdir(struct inode *dir, struct dentry *dentry) | |||
611 | { | 633 | { |
612 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 634 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
613 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 635 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
636 | struct autofs_info *p_ino; | ||
614 | 637 | ||
615 | if (!autofs4_oz_mode(sbi)) | 638 | if (!autofs4_oz_mode(sbi)) |
616 | return -EACCES; | 639 | return -EACCES; |
@@ -625,8 +648,12 @@ static int autofs4_dir_rmdir(struct inode *dir, struct dentry *dentry) | |||
625 | spin_unlock(&dentry->d_lock); | 648 | spin_unlock(&dentry->d_lock); |
626 | spin_unlock(&dcache_lock); | 649 | spin_unlock(&dcache_lock); |
627 | 650 | ||
651 | if (atomic_dec_and_test(&ino->count)) { | ||
652 | p_ino = autofs4_dentry_ino(dentry->d_parent); | ||
653 | if (p_ino && dentry->d_parent != dentry) | ||
654 | atomic_dec(&p_ino->count); | ||
655 | } | ||
628 | dput(ino->dentry); | 656 | dput(ino->dentry); |
629 | |||
630 | dentry->d_inode->i_size = 0; | 657 | dentry->d_inode->i_size = 0; |
631 | dentry->d_inode->i_nlink = 0; | 658 | dentry->d_inode->i_nlink = 0; |
632 | 659 | ||
@@ -640,6 +667,7 @@ static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
640 | { | 667 | { |
641 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 668 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
642 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 669 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
670 | struct autofs_info *p_ino; | ||
643 | struct inode *inode; | 671 | struct inode *inode; |
644 | 672 | ||
645 | if ( !autofs4_oz_mode(sbi) ) | 673 | if ( !autofs4_oz_mode(sbi) ) |
@@ -662,6 +690,10 @@ static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
662 | 690 | ||
663 | dentry->d_fsdata = ino; | 691 | dentry->d_fsdata = ino; |
664 | ino->dentry = dget(dentry); | 692 | ino->dentry = dget(dentry); |
693 | atomic_inc(&ino->count); | ||
694 | p_ino = autofs4_dentry_ino(dentry->d_parent); | ||
695 | if (p_ino && dentry->d_parent != dentry) | ||
696 | atomic_inc(&p_ino->count); | ||
665 | ino->inode = inode; | 697 | ino->inode = inode; |
666 | dir->i_nlink++; | 698 | dir->i_nlink++; |
667 | dir->i_mtime = CURRENT_TIME; | 699 | dir->i_mtime = CURRENT_TIME; |
@@ -745,7 +777,7 @@ static inline int autofs4_ask_umount(struct vfsmount *mnt, int __user *p) | |||
745 | { | 777 | { |
746 | int status = 0; | 778 | int status = 0; |
747 | 779 | ||
748 | if (may_umount(mnt) == 0) | 780 | if (may_umount(mnt)) |
749 | status = 1; | 781 | status = 1; |
750 | 782 | ||
751 | DPRINTK("returning %d", status); | 783 | DPRINTK("returning %d", status); |
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c index be78e9378c03..142ab6aa2aa1 100644 --- a/fs/autofs4/waitq.c +++ b/fs/autofs4/waitq.c | |||
@@ -3,7 +3,7 @@ | |||
3 | * linux/fs/autofs/waitq.c | 3 | * linux/fs/autofs/waitq.c |
4 | * | 4 | * |
5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved | 5 | * Copyright 1997-1998 Transmeta Corporation -- All Rights Reserved |
6 | * Copyright 2001-2003 Ian Kent <raven@themaw.net> | 6 | * Copyright 2001-2006 Ian Kent <raven@themaw.net> |
7 | * | 7 | * |
8 | * This file is part of the Linux kernel and is made available under | 8 | * This file is part of the Linux kernel and is made available under |
9 | * the terms of the GNU General Public License, version 2, or at your | 9 | * the terms of the GNU General Public License, version 2, or at your |
@@ -33,7 +33,7 @@ void autofs4_catatonic_mode(struct autofs_sb_info *sbi) | |||
33 | sbi->catatonic = 1; | 33 | sbi->catatonic = 1; |
34 | wq = sbi->queues; | 34 | wq = sbi->queues; |
35 | sbi->queues = NULL; /* Erase all wait queues */ | 35 | sbi->queues = NULL; /* Erase all wait queues */ |
36 | while ( wq ) { | 36 | while (wq) { |
37 | nwq = wq->next; | 37 | nwq = wq->next; |
38 | wq->status = -ENOENT; /* Magic is gone - report failure */ | 38 | wq->status = -ENOENT; /* Magic is gone - report failure */ |
39 | kfree(wq->name); | 39 | kfree(wq->name); |
@@ -45,7 +45,6 @@ void autofs4_catatonic_mode(struct autofs_sb_info *sbi) | |||
45 | fput(sbi->pipe); /* Close the pipe */ | 45 | fput(sbi->pipe); /* Close the pipe */ |
46 | sbi->pipe = NULL; | 46 | sbi->pipe = NULL; |
47 | } | 47 | } |
48 | |||
49 | shrink_dcache_sb(sbi->sb); | 48 | shrink_dcache_sb(sbi->sb); |
50 | } | 49 | } |
51 | 50 | ||
@@ -98,7 +97,10 @@ static void autofs4_notify_daemon(struct autofs_sb_info *sbi, | |||
98 | 97 | ||
99 | pkt.hdr.proto_version = sbi->version; | 98 | pkt.hdr.proto_version = sbi->version; |
100 | pkt.hdr.type = type; | 99 | pkt.hdr.type = type; |
101 | if (type == autofs_ptype_missing) { | 100 | switch (type) { |
101 | /* Kernel protocol v4 missing and expire packets */ | ||
102 | case autofs_ptype_missing: | ||
103 | { | ||
102 | struct autofs_packet_missing *mp = &pkt.missing; | 104 | struct autofs_packet_missing *mp = &pkt.missing; |
103 | 105 | ||
104 | pktsz = sizeof(*mp); | 106 | pktsz = sizeof(*mp); |
@@ -107,7 +109,10 @@ static void autofs4_notify_daemon(struct autofs_sb_info *sbi, | |||
107 | mp->len = wq->len; | 109 | mp->len = wq->len; |
108 | memcpy(mp->name, wq->name, wq->len); | 110 | memcpy(mp->name, wq->name, wq->len); |
109 | mp->name[wq->len] = '\0'; | 111 | mp->name[wq->len] = '\0'; |
110 | } else if (type == autofs_ptype_expire_multi) { | 112 | break; |
113 | } | ||
114 | case autofs_ptype_expire_multi: | ||
115 | { | ||
111 | struct autofs_packet_expire_multi *ep = &pkt.expire_multi; | 116 | struct autofs_packet_expire_multi *ep = &pkt.expire_multi; |
112 | 117 | ||
113 | pktsz = sizeof(*ep); | 118 | pktsz = sizeof(*ep); |
@@ -116,7 +121,34 @@ static void autofs4_notify_daemon(struct autofs_sb_info *sbi, | |||
116 | ep->len = wq->len; | 121 | ep->len = wq->len; |
117 | memcpy(ep->name, wq->name, wq->len); | 122 | memcpy(ep->name, wq->name, wq->len); |
118 | ep->name[wq->len] = '\0'; | 123 | ep->name[wq->len] = '\0'; |
119 | } else { | 124 | break; |
125 | } | ||
126 | /* | ||
127 | * Kernel protocol v5 packet for handling indirect and direct | ||
128 | * mount missing and expire requests | ||
129 | */ | ||
130 | case autofs_ptype_missing_indirect: | ||
131 | case autofs_ptype_expire_indirect: | ||
132 | case autofs_ptype_missing_direct: | ||
133 | case autofs_ptype_expire_direct: | ||
134 | { | ||
135 | struct autofs_v5_packet *packet = &pkt.v5_packet; | ||
136 | |||
137 | pktsz = sizeof(*packet); | ||
138 | |||
139 | packet->wait_queue_token = wq->wait_queue_token; | ||
140 | packet->len = wq->len; | ||
141 | memcpy(packet->name, wq->name, wq->len); | ||
142 | packet->name[wq->len] = '\0'; | ||
143 | packet->dev = wq->dev; | ||
144 | packet->ino = wq->ino; | ||
145 | packet->uid = wq->uid; | ||
146 | packet->gid = wq->gid; | ||
147 | packet->pid = wq->pid; | ||
148 | packet->tgid = wq->tgid; | ||
149 | break; | ||
150 | } | ||
151 | default: | ||
120 | printk("autofs4_notify_daemon: bad type %d!\n", type); | 152 | printk("autofs4_notify_daemon: bad type %d!\n", type); |
121 | return; | 153 | return; |
122 | } | 154 | } |
@@ -162,21 +194,29 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
162 | { | 194 | { |
163 | struct autofs_wait_queue *wq; | 195 | struct autofs_wait_queue *wq; |
164 | char *name; | 196 | char *name; |
165 | int len, status; | 197 | unsigned int len = 0; |
198 | unsigned int hash = 0; | ||
199 | int status; | ||
166 | 200 | ||
167 | /* In catatonic mode, we don't wait for nobody */ | 201 | /* In catatonic mode, we don't wait for nobody */ |
168 | if ( sbi->catatonic ) | 202 | if (sbi->catatonic) |
169 | return -ENOENT; | 203 | return -ENOENT; |
170 | 204 | ||
171 | name = kmalloc(NAME_MAX + 1, GFP_KERNEL); | 205 | name = kmalloc(NAME_MAX + 1, GFP_KERNEL); |
172 | if (!name) | 206 | if (!name) |
173 | return -ENOMEM; | 207 | return -ENOMEM; |
174 | 208 | ||
175 | len = autofs4_getpath(sbi, dentry, &name); | 209 | /* If this is a direct mount request create a dummy name */ |
176 | if (!len) { | 210 | if (IS_ROOT(dentry) && (sbi->type & AUTOFS_TYPE_DIRECT)) |
177 | kfree(name); | 211 | len = sprintf(name, "%p", dentry); |
178 | return -ENOENT; | 212 | else { |
213 | len = autofs4_getpath(sbi, dentry, &name); | ||
214 | if (!len) { | ||
215 | kfree(name); | ||
216 | return -ENOENT; | ||
217 | } | ||
179 | } | 218 | } |
219 | hash = full_name_hash(name, len); | ||
180 | 220 | ||
181 | if (mutex_lock_interruptible(&sbi->wq_mutex)) { | 221 | if (mutex_lock_interruptible(&sbi->wq_mutex)) { |
182 | kfree(name); | 222 | kfree(name); |
@@ -190,7 +230,7 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
190 | break; | 230 | break; |
191 | } | 231 | } |
192 | 232 | ||
193 | if ( !wq ) { | 233 | if (!wq) { |
194 | /* Can't wait for an expire if there's no mount */ | 234 | /* Can't wait for an expire if there's no mount */ |
195 | if (notify == NFY_NONE && !d_mountpoint(dentry)) { | 235 | if (notify == NFY_NONE && !d_mountpoint(dentry)) { |
196 | kfree(name); | 236 | kfree(name); |
@@ -200,7 +240,7 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
200 | 240 | ||
201 | /* Create a new wait queue */ | 241 | /* Create a new wait queue */ |
202 | wq = kmalloc(sizeof(struct autofs_wait_queue),GFP_KERNEL); | 242 | wq = kmalloc(sizeof(struct autofs_wait_queue),GFP_KERNEL); |
203 | if ( !wq ) { | 243 | if (!wq) { |
204 | kfree(name); | 244 | kfree(name); |
205 | mutex_unlock(&sbi->wq_mutex); | 245 | mutex_unlock(&sbi->wq_mutex); |
206 | return -ENOMEM; | 246 | return -ENOMEM; |
@@ -212,12 +252,18 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
212 | wq->next = sbi->queues; | 252 | wq->next = sbi->queues; |
213 | sbi->queues = wq; | 253 | sbi->queues = wq; |
214 | init_waitqueue_head(&wq->queue); | 254 | init_waitqueue_head(&wq->queue); |
215 | wq->hash = dentry->d_name.hash; | 255 | wq->hash = hash; |
216 | wq->name = name; | 256 | wq->name = name; |
217 | wq->len = len; | 257 | wq->len = len; |
258 | wq->dev = autofs4_get_dev(sbi); | ||
259 | wq->ino = autofs4_get_ino(sbi); | ||
260 | wq->uid = current->uid; | ||
261 | wq->gid = current->gid; | ||
262 | wq->pid = current->pid; | ||
263 | wq->tgid = current->tgid; | ||
218 | wq->status = -EINTR; /* Status return if interrupted */ | 264 | wq->status = -EINTR; /* Status return if interrupted */ |
219 | atomic_set(&wq->wait_ctr, 2); | 265 | atomic_set(&wq->wait_ctr, 2); |
220 | atomic_set(&wq->notified, 1); | 266 | atomic_set(&wq->notify, 1); |
221 | mutex_unlock(&sbi->wq_mutex); | 267 | mutex_unlock(&sbi->wq_mutex); |
222 | } else { | 268 | } else { |
223 | atomic_inc(&wq->wait_ctr); | 269 | atomic_inc(&wq->wait_ctr); |
@@ -227,9 +273,26 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
227 | (unsigned long) wq->wait_queue_token, wq->len, wq->name, notify); | 273 | (unsigned long) wq->wait_queue_token, wq->len, wq->name, notify); |
228 | } | 274 | } |
229 | 275 | ||
230 | if (notify != NFY_NONE && atomic_dec_and_test(&wq->notified)) { | 276 | if (notify != NFY_NONE && atomic_read(&wq->notify)) { |
231 | int type = (notify == NFY_MOUNT ? | 277 | int type; |
232 | autofs_ptype_missing : autofs_ptype_expire_multi); | 278 | |
279 | atomic_dec(&wq->notify); | ||
280 | |||
281 | if (sbi->version < 5) { | ||
282 | if (notify == NFY_MOUNT) | ||
283 | type = autofs_ptype_missing; | ||
284 | else | ||
285 | type = autofs_ptype_expire_multi; | ||
286 | } else { | ||
287 | if (notify == NFY_MOUNT) | ||
288 | type = (sbi->type & AUTOFS_TYPE_DIRECT) ? | ||
289 | autofs_ptype_missing_direct : | ||
290 | autofs_ptype_missing_indirect; | ||
291 | else | ||
292 | type = (sbi->type & AUTOFS_TYPE_DIRECT) ? | ||
293 | autofs_ptype_expire_direct : | ||
294 | autofs_ptype_expire_indirect; | ||
295 | } | ||
233 | 296 | ||
234 | DPRINTK("new wait id = 0x%08lx, name = %.*s, nfy=%d\n", | 297 | DPRINTK("new wait id = 0x%08lx, name = %.*s, nfy=%d\n", |
235 | (unsigned long) wq->wait_queue_token, wq->len, wq->name, notify); | 298 | (unsigned long) wq->wait_queue_token, wq->len, wq->name, notify); |
@@ -240,14 +303,14 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, | |||
240 | 303 | ||
241 | /* wq->name is NULL if and only if the lock is already released */ | 304 | /* wq->name is NULL if and only if the lock is already released */ |
242 | 305 | ||
243 | if ( sbi->catatonic ) { | 306 | if (sbi->catatonic) { |
244 | /* We might have slept, so check again for catatonic mode */ | 307 | /* We might have slept, so check again for catatonic mode */ |
245 | wq->status = -ENOENT; | 308 | wq->status = -ENOENT; |
246 | kfree(wq->name); | 309 | kfree(wq->name); |
247 | wq->name = NULL; | 310 | wq->name = NULL; |
248 | } | 311 | } |
249 | 312 | ||
250 | if ( wq->name ) { | 313 | if (wq->name) { |
251 | /* Block all but "shutdown" signals while waiting */ | 314 | /* Block all but "shutdown" signals while waiting */ |
252 | sigset_t oldset; | 315 | sigset_t oldset; |
253 | unsigned long irqflags; | 316 | unsigned long irqflags; |
@@ -283,12 +346,12 @@ int autofs4_wait_release(struct autofs_sb_info *sbi, autofs_wqt_t wait_queue_tok | |||
283 | struct autofs_wait_queue *wq, **wql; | 346 | struct autofs_wait_queue *wq, **wql; |
284 | 347 | ||
285 | mutex_lock(&sbi->wq_mutex); | 348 | mutex_lock(&sbi->wq_mutex); |
286 | for ( wql = &sbi->queues ; (wq = *wql) != 0 ; wql = &wq->next ) { | 349 | for (wql = &sbi->queues ; (wq = *wql) != 0 ; wql = &wq->next) { |
287 | if ( wq->wait_queue_token == wait_queue_token ) | 350 | if (wq->wait_queue_token == wait_queue_token) |
288 | break; | 351 | break; |
289 | } | 352 | } |
290 | 353 | ||
291 | if ( !wq ) { | 354 | if (!wq) { |
292 | mutex_unlock(&sbi->wq_mutex); | 355 | mutex_unlock(&sbi->wq_mutex); |
293 | return -EINVAL; | 356 | return -EINVAL; |
294 | } | 357 | } |
diff --git a/fs/bad_inode.c b/fs/bad_inode.c index e172180a1d8c..80599ae33966 100644 --- a/fs/bad_inode.c +++ b/fs/bad_inode.c | |||
@@ -22,7 +22,7 @@ static int return_EIO(void) | |||
22 | 22 | ||
23 | #define EIO_ERROR ((void *) (return_EIO)) | 23 | #define EIO_ERROR ((void *) (return_EIO)) |
24 | 24 | ||
25 | static struct file_operations bad_file_ops = | 25 | static const struct file_operations bad_file_ops = |
26 | { | 26 | { |
27 | .llseek = EIO_ERROR, | 27 | .llseek = EIO_ERROR, |
28 | .aio_read = EIO_ERROR, | 28 | .aio_read = EIO_ERROR, |
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 044a59587829..68ebd10f345d 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c | |||
@@ -64,7 +64,7 @@ static const struct super_operations befs_sops = { | |||
64 | /* slab cache for befs_inode_info objects */ | 64 | /* slab cache for befs_inode_info objects */ |
65 | static kmem_cache_t *befs_inode_cachep; | 65 | static kmem_cache_t *befs_inode_cachep; |
66 | 66 | ||
67 | static struct file_operations befs_dir_operations = { | 67 | static const struct file_operations befs_dir_operations = { |
68 | .read = generic_read_dir, | 68 | .read = generic_read_dir, |
69 | .readdir = befs_readdir, | 69 | .readdir = befs_readdir, |
70 | }; | 70 | }; |
diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h index 1fbc53f14aba..9d791004b21c 100644 --- a/fs/bfs/bfs.h +++ b/fs/bfs/bfs.h | |||
@@ -49,11 +49,11 @@ static inline struct bfs_inode_info *BFS_I(struct inode *inode) | |||
49 | 49 | ||
50 | /* file.c */ | 50 | /* file.c */ |
51 | extern struct inode_operations bfs_file_inops; | 51 | extern struct inode_operations bfs_file_inops; |
52 | extern struct file_operations bfs_file_operations; | 52 | extern const struct file_operations bfs_file_operations; |
53 | extern struct address_space_operations bfs_aops; | 53 | extern struct address_space_operations bfs_aops; |
54 | 54 | ||
55 | /* dir.c */ | 55 | /* dir.c */ |
56 | extern struct inode_operations bfs_dir_inops; | 56 | extern struct inode_operations bfs_dir_inops; |
57 | extern struct file_operations bfs_dir_operations; | 57 | extern const struct file_operations bfs_dir_operations; |
58 | 58 | ||
59 | #endif /* _FS_BFS_BFS_H */ | 59 | #endif /* _FS_BFS_BFS_H */ |
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 5af928fa0449..26fad9621738 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c | |||
@@ -70,7 +70,7 @@ static int bfs_readdir(struct file * f, void * dirent, filldir_t filldir) | |||
70 | return 0; | 70 | return 0; |
71 | } | 71 | } |
72 | 72 | ||
73 | struct file_operations bfs_dir_operations = { | 73 | const struct file_operations bfs_dir_operations = { |
74 | .read = generic_read_dir, | 74 | .read = generic_read_dir, |
75 | .readdir = bfs_readdir, | 75 | .readdir = bfs_readdir, |
76 | .fsync = file_fsync, | 76 | .fsync = file_fsync, |
diff --git a/fs/bfs/file.c b/fs/bfs/file.c index 807723b65daf..d83cd74a2e4e 100644 --- a/fs/bfs/file.c +++ b/fs/bfs/file.c | |||
@@ -17,7 +17,7 @@ | |||
17 | #define dprintf(x...) | 17 | #define dprintf(x...) |
18 | #endif | 18 | #endif |
19 | 19 | ||
20 | struct file_operations bfs_file_operations = { | 20 | const struct file_operations bfs_file_operations = { |
21 | .llseek = generic_file_llseek, | 21 | .llseek = generic_file_llseek, |
22 | .read = generic_file_read, | 22 | .read = generic_file_read, |
23 | .write = generic_file_write, | 23 | .write = generic_file_write, |
diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index 6a7b730c206b..d73d75591a39 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c | |||
@@ -600,7 +600,7 @@ static ssize_t bm_entry_write(struct file *file, const char __user *buffer, | |||
600 | return count; | 600 | return count; |
601 | } | 601 | } |
602 | 602 | ||
603 | static struct file_operations bm_entry_operations = { | 603 | static const struct file_operations bm_entry_operations = { |
604 | .read = bm_entry_read, | 604 | .read = bm_entry_read, |
605 | .write = bm_entry_write, | 605 | .write = bm_entry_write, |
606 | }; | 606 | }; |
@@ -668,7 +668,7 @@ out: | |||
668 | return count; | 668 | return count; |
669 | } | 669 | } |
670 | 670 | ||
671 | static struct file_operations bm_register_operations = { | 671 | static const struct file_operations bm_register_operations = { |
672 | .write = bm_register_write, | 672 | .write = bm_register_write, |
673 | }; | 673 | }; |
674 | 674 | ||
@@ -715,7 +715,7 @@ static ssize_t bm_status_write(struct file * file, const char __user * buffer, | |||
715 | return count; | 715 | return count; |
716 | } | 716 | } |
717 | 717 | ||
718 | static struct file_operations bm_status_operations = { | 718 | static const struct file_operations bm_status_operations = { |
719 | .read = bm_status_read, | 719 | .read = bm_status_read, |
720 | .write = bm_status_write, | 720 | .write = bm_status_write, |
721 | }; | 721 | }; |
@@ -30,7 +30,7 @@ | |||
30 | 30 | ||
31 | #define BIO_POOL_SIZE 256 | 31 | #define BIO_POOL_SIZE 256 |
32 | 32 | ||
33 | static kmem_cache_t *bio_slab; | 33 | static kmem_cache_t *bio_slab __read_mostly; |
34 | 34 | ||
35 | #define BIOVEC_NR_POOLS 6 | 35 | #define BIOVEC_NR_POOLS 6 |
36 | 36 | ||
@@ -39,7 +39,7 @@ static kmem_cache_t *bio_slab; | |||
39 | * basically we just need to survive | 39 | * basically we just need to survive |
40 | */ | 40 | */ |
41 | #define BIO_SPLIT_ENTRIES 8 | 41 | #define BIO_SPLIT_ENTRIES 8 |
42 | mempool_t *bio_split_pool; | 42 | mempool_t *bio_split_pool __read_mostly; |
43 | 43 | ||
44 | struct biovec_slab { | 44 | struct biovec_slab { |
45 | int nr_vecs; | 45 | int nr_vecs; |
@@ -1125,16 +1125,6 @@ struct bio_pair *bio_split(struct bio *bi, mempool_t *pool, int first_sectors) | |||
1125 | return bp; | 1125 | return bp; |
1126 | } | 1126 | } |
1127 | 1127 | ||
1128 | static void *bio_pair_alloc(gfp_t gfp_flags, void *data) | ||
1129 | { | ||
1130 | return kmalloc(sizeof(struct bio_pair), gfp_flags); | ||
1131 | } | ||
1132 | |||
1133 | static void bio_pair_free(void *bp, void *data) | ||
1134 | { | ||
1135 | kfree(bp); | ||
1136 | } | ||
1137 | |||
1138 | 1128 | ||
1139 | /* | 1129 | /* |
1140 | * create memory pools for biovec's in a bio_set. | 1130 | * create memory pools for biovec's in a bio_set. |
@@ -1151,8 +1141,7 @@ static int biovec_create_pools(struct bio_set *bs, int pool_entries, int scale) | |||
1151 | if (i >= scale) | 1141 | if (i >= scale) |
1152 | pool_entries >>= 1; | 1142 | pool_entries >>= 1; |
1153 | 1143 | ||
1154 | *bvp = mempool_create(pool_entries, mempool_alloc_slab, | 1144 | *bvp = mempool_create_slab_pool(pool_entries, bp->slab); |
1155 | mempool_free_slab, bp->slab); | ||
1156 | if (!*bvp) | 1145 | if (!*bvp) |
1157 | return -ENOMEM; | 1146 | return -ENOMEM; |
1158 | } | 1147 | } |
@@ -1189,9 +1178,7 @@ struct bio_set *bioset_create(int bio_pool_size, int bvec_pool_size, int scale) | |||
1189 | if (!bs) | 1178 | if (!bs) |
1190 | return NULL; | 1179 | return NULL; |
1191 | 1180 | ||
1192 | bs->bio_pool = mempool_create(bio_pool_size, mempool_alloc_slab, | 1181 | bs->bio_pool = mempool_create_slab_pool(bio_pool_size, bio_slab); |
1193 | mempool_free_slab, bio_slab); | ||
1194 | |||
1195 | if (!bs->bio_pool) | 1182 | if (!bs->bio_pool) |
1196 | goto bad; | 1183 | goto bad; |
1197 | 1184 | ||
@@ -1254,8 +1241,8 @@ static int __init init_bio(void) | |||
1254 | if (!fs_bio_set) | 1241 | if (!fs_bio_set) |
1255 | panic("bio: can't allocate bios\n"); | 1242 | panic("bio: can't allocate bios\n"); |
1256 | 1243 | ||
1257 | bio_split_pool = mempool_create(BIO_SPLIT_ENTRIES, | 1244 | bio_split_pool = mempool_create_kmalloc_pool(BIO_SPLIT_ENTRIES, |
1258 | bio_pair_alloc, bio_pair_free, NULL); | 1245 | sizeof(struct bio_pair)); |
1259 | if (!bio_split_pool) | 1246 | if (!bio_split_pool) |
1260 | panic("bio: can't create split pool\n"); | 1247 | panic("bio: can't create split pool\n"); |
1261 | 1248 | ||
diff --git a/fs/block_dev.c b/fs/block_dev.c index 573fc8e0b67a..af88c43043d5 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -131,9 +131,10 @@ blkdev_get_block(struct inode *inode, sector_t iblock, | |||
131 | 131 | ||
132 | static int | 132 | static int |
133 | blkdev_get_blocks(struct inode *inode, sector_t iblock, | 133 | blkdev_get_blocks(struct inode *inode, sector_t iblock, |
134 | unsigned long max_blocks, struct buffer_head *bh, int create) | 134 | struct buffer_head *bh, int create) |
135 | { | 135 | { |
136 | sector_t end_block = max_block(I_BDEV(inode)); | 136 | sector_t end_block = max_block(I_BDEV(inode)); |
137 | unsigned long max_blocks = bh->b_size >> inode->i_blkbits; | ||
137 | 138 | ||
138 | if ((iblock + max_blocks) > end_block) { | 139 | if ((iblock + max_blocks) > end_block) { |
139 | max_blocks = end_block - iblock; | 140 | max_blocks = end_block - iblock; |
@@ -234,7 +235,7 @@ static int block_fsync(struct file *filp, struct dentry *dentry, int datasync) | |||
234 | */ | 235 | */ |
235 | 236 | ||
236 | static __cacheline_aligned_in_smp DEFINE_SPINLOCK(bdev_lock); | 237 | static __cacheline_aligned_in_smp DEFINE_SPINLOCK(bdev_lock); |
237 | static kmem_cache_t * bdev_cachep; | 238 | static kmem_cache_t * bdev_cachep __read_mostly; |
238 | 239 | ||
239 | static struct inode *bdev_alloc_inode(struct super_block *sb) | 240 | static struct inode *bdev_alloc_inode(struct super_block *sb) |
240 | { | 241 | { |
@@ -265,6 +266,9 @@ static void init_once(void * foo, kmem_cache_t * cachep, unsigned long flags) | |||
265 | mutex_init(&bdev->bd_mount_mutex); | 266 | mutex_init(&bdev->bd_mount_mutex); |
266 | INIT_LIST_HEAD(&bdev->bd_inodes); | 267 | INIT_LIST_HEAD(&bdev->bd_inodes); |
267 | INIT_LIST_HEAD(&bdev->bd_list); | 268 | INIT_LIST_HEAD(&bdev->bd_list); |
269 | #ifdef CONFIG_SYSFS | ||
270 | INIT_LIST_HEAD(&bdev->bd_holder_list); | ||
271 | #endif | ||
268 | inode_init_once(&ei->vfs_inode); | 272 | inode_init_once(&ei->vfs_inode); |
269 | } | 273 | } |
270 | } | 274 | } |
@@ -308,7 +312,7 @@ static struct file_system_type bd_type = { | |||
308 | .kill_sb = kill_anon_super, | 312 | .kill_sb = kill_anon_super, |
309 | }; | 313 | }; |
310 | 314 | ||
311 | static struct vfsmount *bd_mnt; | 315 | static struct vfsmount *bd_mnt __read_mostly; |
312 | struct super_block *blockdev_superblock; | 316 | struct super_block *blockdev_superblock; |
313 | 317 | ||
314 | void __init bdev_cache_init(void) | 318 | void __init bdev_cache_init(void) |
@@ -489,6 +493,300 @@ void bd_release(struct block_device *bdev) | |||
489 | 493 | ||
490 | EXPORT_SYMBOL(bd_release); | 494 | EXPORT_SYMBOL(bd_release); |
491 | 495 | ||
496 | #ifdef CONFIG_SYSFS | ||
497 | /* | ||
498 | * Functions for bd_claim_by_kobject / bd_release_from_kobject | ||
499 | * | ||
500 | * If a kobject is passed to bd_claim_by_kobject() | ||
501 | * and the kobject has a parent directory, | ||
502 | * following symlinks are created: | ||
503 | * o from the kobject to the claimed bdev | ||
504 | * o from "holders" directory of the bdev to the parent of the kobject | ||
505 | * bd_release_from_kobject() removes these symlinks. | ||
506 | * | ||
507 | * Example: | ||
508 | * If /dev/dm-0 maps to /dev/sda, kobject corresponding to | ||
509 | * /sys/block/dm-0/slaves is passed to bd_claim_by_kobject(), then: | ||
510 | * /sys/block/dm-0/slaves/sda --> /sys/block/sda | ||
511 | * /sys/block/sda/holders/dm-0 --> /sys/block/dm-0 | ||
512 | */ | ||
513 | |||
514 | static struct kobject *bdev_get_kobj(struct block_device *bdev) | ||
515 | { | ||
516 | if (bdev->bd_contains != bdev) | ||
517 | return kobject_get(&bdev->bd_part->kobj); | ||
518 | else | ||
519 | return kobject_get(&bdev->bd_disk->kobj); | ||
520 | } | ||
521 | |||
522 | static struct kobject *bdev_get_holder(struct block_device *bdev) | ||
523 | { | ||
524 | if (bdev->bd_contains != bdev) | ||
525 | return kobject_get(bdev->bd_part->holder_dir); | ||
526 | else | ||
527 | return kobject_get(bdev->bd_disk->holder_dir); | ||
528 | } | ||
529 | |||
530 | static void add_symlink(struct kobject *from, struct kobject *to) | ||
531 | { | ||
532 | if (!from || !to) | ||
533 | return; | ||
534 | sysfs_create_link(from, to, kobject_name(to)); | ||
535 | } | ||
536 | |||
537 | static void del_symlink(struct kobject *from, struct kobject *to) | ||
538 | { | ||
539 | if (!from || !to) | ||
540 | return; | ||
541 | sysfs_remove_link(from, kobject_name(to)); | ||
542 | } | ||
543 | |||
544 | /* | ||
545 | * 'struct bd_holder' contains pointers to kobjects symlinked by | ||
546 | * bd_claim_by_kobject. | ||
547 | * It's connected to bd_holder_list which is protected by bdev->bd_sem. | ||
548 | */ | ||
549 | struct bd_holder { | ||
550 | struct list_head list; /* chain of holders of the bdev */ | ||
551 | int count; /* references from the holder */ | ||
552 | struct kobject *sdir; /* holder object, e.g. "/block/dm-0/slaves" */ | ||
553 | struct kobject *hdev; /* e.g. "/block/dm-0" */ | ||
554 | struct kobject *hdir; /* e.g. "/block/sda/holders" */ | ||
555 | struct kobject *sdev; /* e.g. "/block/sda" */ | ||
556 | }; | ||
557 | |||
558 | /* | ||
559 | * Get references of related kobjects at once. | ||
560 | * Returns 1 on success. 0 on failure. | ||
561 | * | ||
562 | * Should call bd_holder_release_dirs() after successful use. | ||
563 | */ | ||
564 | static int bd_holder_grab_dirs(struct block_device *bdev, | ||
565 | struct bd_holder *bo) | ||
566 | { | ||
567 | if (!bdev || !bo) | ||
568 | return 0; | ||
569 | |||
570 | bo->sdir = kobject_get(bo->sdir); | ||
571 | if (!bo->sdir) | ||
572 | return 0; | ||
573 | |||
574 | bo->hdev = kobject_get(bo->sdir->parent); | ||
575 | if (!bo->hdev) | ||
576 | goto fail_put_sdir; | ||
577 | |||
578 | bo->sdev = bdev_get_kobj(bdev); | ||
579 | if (!bo->sdev) | ||
580 | goto fail_put_hdev; | ||
581 | |||
582 | bo->hdir = bdev_get_holder(bdev); | ||
583 | if (!bo->hdir) | ||
584 | goto fail_put_sdev; | ||
585 | |||
586 | return 1; | ||
587 | |||
588 | fail_put_sdev: | ||
589 | kobject_put(bo->sdev); | ||
590 | fail_put_hdev: | ||
591 | kobject_put(bo->hdev); | ||
592 | fail_put_sdir: | ||
593 | kobject_put(bo->sdir); | ||
594 | |||
595 | return 0; | ||
596 | } | ||
597 | |||
598 | /* Put references of related kobjects at once. */ | ||
599 | static void bd_holder_release_dirs(struct bd_holder *bo) | ||
600 | { | ||
601 | kobject_put(bo->hdir); | ||
602 | kobject_put(bo->sdev); | ||
603 | kobject_put(bo->hdev); | ||
604 | kobject_put(bo->sdir); | ||
605 | } | ||
606 | |||
607 | static struct bd_holder *alloc_bd_holder(struct kobject *kobj) | ||
608 | { | ||
609 | struct bd_holder *bo; | ||
610 | |||
611 | bo = kzalloc(sizeof(*bo), GFP_KERNEL); | ||
612 | if (!bo) | ||
613 | return NULL; | ||
614 | |||
615 | bo->count = 1; | ||
616 | bo->sdir = kobj; | ||
617 | |||
618 | return bo; | ||
619 | } | ||
620 | |||
621 | static void free_bd_holder(struct bd_holder *bo) | ||
622 | { | ||
623 | kfree(bo); | ||
624 | } | ||
625 | |||
626 | /** | ||
627 | * add_bd_holder - create sysfs symlinks for bd_claim() relationship | ||
628 | * | ||
629 | * @bdev: block device to be bd_claimed | ||
630 | * @bo: preallocated and initialized by alloc_bd_holder() | ||
631 | * | ||
632 | * If there is no matching entry with @bo in @bdev->bd_holder_list, | ||
633 | * add @bo to the list, create symlinks. | ||
634 | * | ||
635 | * Returns 1 if @bo was added to the list. | ||
636 | * Returns 0 if @bo wasn't used by any reason and should be freed. | ||
637 | */ | ||
638 | static int add_bd_holder(struct block_device *bdev, struct bd_holder *bo) | ||
639 | { | ||
640 | struct bd_holder *tmp; | ||
641 | |||
642 | if (!bo) | ||
643 | return 0; | ||
644 | |||
645 | list_for_each_entry(tmp, &bdev->bd_holder_list, list) { | ||
646 | if (tmp->sdir == bo->sdir) { | ||
647 | tmp->count++; | ||
648 | return 0; | ||
649 | } | ||
650 | } | ||
651 | |||
652 | if (!bd_holder_grab_dirs(bdev, bo)) | ||
653 | return 0; | ||
654 | |||
655 | add_symlink(bo->sdir, bo->sdev); | ||
656 | add_symlink(bo->hdir, bo->hdev); | ||
657 | list_add_tail(&bo->list, &bdev->bd_holder_list); | ||
658 | return 1; | ||
659 | } | ||
660 | |||
661 | /** | ||
662 | * del_bd_holder - delete sysfs symlinks for bd_claim() relationship | ||
663 | * | ||
664 | * @bdev: block device to be bd_claimed | ||
665 | * @kobj: holder's kobject | ||
666 | * | ||
667 | * If there is matching entry with @kobj in @bdev->bd_holder_list | ||
668 | * and no other bd_claim() from the same kobject, | ||
669 | * remove the struct bd_holder from the list, delete symlinks for it. | ||
670 | * | ||
671 | * Returns a pointer to the struct bd_holder when it's removed from the list | ||
672 | * and ready to be freed. | ||
673 | * Returns NULL if matching claim isn't found or there is other bd_claim() | ||
674 | * by the same kobject. | ||
675 | */ | ||
676 | static struct bd_holder *del_bd_holder(struct block_device *bdev, | ||
677 | struct kobject *kobj) | ||
678 | { | ||
679 | struct bd_holder *bo; | ||
680 | |||
681 | list_for_each_entry(bo, &bdev->bd_holder_list, list) { | ||
682 | if (bo->sdir == kobj) { | ||
683 | bo->count--; | ||
684 | BUG_ON(bo->count < 0); | ||
685 | if (!bo->count) { | ||
686 | list_del(&bo->list); | ||
687 | del_symlink(bo->sdir, bo->sdev); | ||
688 | del_symlink(bo->hdir, bo->hdev); | ||
689 | bd_holder_release_dirs(bo); | ||
690 | return bo; | ||
691 | } | ||
692 | break; | ||
693 | } | ||
694 | } | ||
695 | |||
696 | return NULL; | ||
697 | } | ||
698 | |||
699 | /** | ||
700 | * bd_claim_by_kobject - bd_claim() with additional kobject signature | ||
701 | * | ||
702 | * @bdev: block device to be claimed | ||
703 | * @holder: holder's signature | ||
704 | * @kobj: holder's kobject | ||
705 | * | ||
706 | * Do bd_claim() and if it succeeds, create sysfs symlinks between | ||
707 | * the bdev and the holder's kobject. | ||
708 | * Use bd_release_from_kobject() when relesing the claimed bdev. | ||
709 | * | ||
710 | * Returns 0 on success. (same as bd_claim()) | ||
711 | * Returns errno on failure. | ||
712 | */ | ||
713 | static int bd_claim_by_kobject(struct block_device *bdev, void *holder, | ||
714 | struct kobject *kobj) | ||
715 | { | ||
716 | int res; | ||
717 | struct bd_holder *bo; | ||
718 | |||
719 | if (!kobj) | ||
720 | return -EINVAL; | ||
721 | |||
722 | bo = alloc_bd_holder(kobj); | ||
723 | if (!bo) | ||
724 | return -ENOMEM; | ||
725 | |||
726 | mutex_lock(&bdev->bd_mutex); | ||
727 | res = bd_claim(bdev, holder); | ||
728 | if (res || !add_bd_holder(bdev, bo)) | ||
729 | free_bd_holder(bo); | ||
730 | mutex_unlock(&bdev->bd_mutex); | ||
731 | |||
732 | return res; | ||
733 | } | ||
734 | |||
735 | /** | ||
736 | * bd_release_from_kobject - bd_release() with additional kobject signature | ||
737 | * | ||
738 | * @bdev: block device to be released | ||
739 | * @kobj: holder's kobject | ||
740 | * | ||
741 | * Do bd_release() and remove sysfs symlinks created by bd_claim_by_kobject(). | ||
742 | */ | ||
743 | static void bd_release_from_kobject(struct block_device *bdev, | ||
744 | struct kobject *kobj) | ||
745 | { | ||
746 | struct bd_holder *bo; | ||
747 | |||
748 | if (!kobj) | ||
749 | return; | ||
750 | |||
751 | mutex_lock(&bdev->bd_mutex); | ||
752 | bd_release(bdev); | ||
753 | if ((bo = del_bd_holder(bdev, kobj))) | ||
754 | free_bd_holder(bo); | ||
755 | mutex_unlock(&bdev->bd_mutex); | ||
756 | } | ||
757 | |||
758 | /** | ||
759 | * bd_claim_by_disk - wrapper function for bd_claim_by_kobject() | ||
760 | * | ||
761 | * @bdev: block device to be claimed | ||
762 | * @holder: holder's signature | ||
763 | * @disk: holder's gendisk | ||
764 | * | ||
765 | * Call bd_claim_by_kobject() with getting @disk->slave_dir. | ||
766 | */ | ||
767 | int bd_claim_by_disk(struct block_device *bdev, void *holder, | ||
768 | struct gendisk *disk) | ||
769 | { | ||
770 | return bd_claim_by_kobject(bdev, holder, kobject_get(disk->slave_dir)); | ||
771 | } | ||
772 | EXPORT_SYMBOL_GPL(bd_claim_by_disk); | ||
773 | |||
774 | /** | ||
775 | * bd_release_from_disk - wrapper function for bd_release_from_kobject() | ||
776 | * | ||
777 | * @bdev: block device to be claimed | ||
778 | * @disk: holder's gendisk | ||
779 | * | ||
780 | * Call bd_release_from_kobject() and put @disk->slave_dir. | ||
781 | */ | ||
782 | void bd_release_from_disk(struct block_device *bdev, struct gendisk *disk) | ||
783 | { | ||
784 | bd_release_from_kobject(bdev, disk->slave_dir); | ||
785 | kobject_put(disk->slave_dir); | ||
786 | } | ||
787 | EXPORT_SYMBOL_GPL(bd_release_from_disk); | ||
788 | #endif | ||
789 | |||
492 | /* | 790 | /* |
493 | * Tries to open block device by device number. Use it ONLY if you | 791 | * Tries to open block device by device number. Use it ONLY if you |
494 | * really do not have anything better - i.e. when you are behind a | 792 | * really do not have anything better - i.e. when you are behind a |
@@ -789,7 +1087,7 @@ struct address_space_operations def_blk_aops = { | |||
789 | .direct_IO = blkdev_direct_IO, | 1087 | .direct_IO = blkdev_direct_IO, |
790 | }; | 1088 | }; |
791 | 1089 | ||
792 | struct file_operations def_blk_fops = { | 1090 | const struct file_operations def_blk_fops = { |
793 | .open = blkdev_open, | 1091 | .open = blkdev_open, |
794 | .release = blkdev_close, | 1092 | .release = blkdev_close, |
795 | .llseek = block_llseek, | 1093 | .llseek = block_llseek, |
diff --git a/fs/buffer.c b/fs/buffer.c index 3b3ab5281920..23f1f3a68077 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -426,8 +426,10 @@ __find_get_block_slow(struct block_device *bdev, sector_t block) | |||
426 | if (all_mapped) { | 426 | if (all_mapped) { |
427 | printk("__find_get_block_slow() failed. " | 427 | printk("__find_get_block_slow() failed. " |
428 | "block=%llu, b_blocknr=%llu\n", | 428 | "block=%llu, b_blocknr=%llu\n", |
429 | (unsigned long long)block, (unsigned long long)bh->b_blocknr); | 429 | (unsigned long long)block, |
430 | printk("b_state=0x%08lx, b_size=%u\n", bh->b_state, bh->b_size); | 430 | (unsigned long long)bh->b_blocknr); |
431 | printk("b_state=0x%08lx, b_size=%zu\n", | ||
432 | bh->b_state, bh->b_size); | ||
431 | printk("device blocksize: %d\n", 1 << bd_inode->i_blkbits); | 433 | printk("device blocksize: %d\n", 1 << bd_inode->i_blkbits); |
432 | } | 434 | } |
433 | out_unlock: | 435 | out_unlock: |
@@ -491,7 +493,7 @@ static void free_more_memory(void) | |||
491 | wakeup_pdflush(1024); | 493 | wakeup_pdflush(1024); |
492 | yield(); | 494 | yield(); |
493 | 495 | ||
494 | for_each_pgdat(pgdat) { | 496 | for_each_online_pgdat(pgdat) { |
495 | zones = pgdat->node_zonelists[gfp_zone(GFP_NOFS)].zones; | 497 | zones = pgdat->node_zonelists[gfp_zone(GFP_NOFS)].zones; |
496 | if (*zones) | 498 | if (*zones) |
497 | try_to_free_pages(zones, GFP_NOFS); | 499 | try_to_free_pages(zones, GFP_NOFS); |
@@ -796,8 +798,7 @@ void mark_buffer_dirty_inode(struct buffer_head *bh, struct inode *inode) | |||
796 | if (!mapping->assoc_mapping) { | 798 | if (!mapping->assoc_mapping) { |
797 | mapping->assoc_mapping = buffer_mapping; | 799 | mapping->assoc_mapping = buffer_mapping; |
798 | } else { | 800 | } else { |
799 | if (mapping->assoc_mapping != buffer_mapping) | 801 | BUG_ON(mapping->assoc_mapping != buffer_mapping); |
800 | BUG(); | ||
801 | } | 802 | } |
802 | if (list_empty(&bh->b_assoc_buffers)) { | 803 | if (list_empty(&bh->b_assoc_buffers)) { |
803 | spin_lock(&buffer_mapping->private_lock); | 804 | spin_lock(&buffer_mapping->private_lock); |
@@ -1114,8 +1115,7 @@ grow_dev_page(struct block_device *bdev, sector_t block, | |||
1114 | if (!page) | 1115 | if (!page) |
1115 | return NULL; | 1116 | return NULL; |
1116 | 1117 | ||
1117 | if (!PageLocked(page)) | 1118 | BUG_ON(!PageLocked(page)); |
1118 | BUG(); | ||
1119 | 1119 | ||
1120 | if (page_has_buffers(page)) { | 1120 | if (page_has_buffers(page)) { |
1121 | bh = page_buffers(page); | 1121 | bh = page_buffers(page); |
@@ -1522,8 +1522,7 @@ void set_bh_page(struct buffer_head *bh, | |||
1522 | struct page *page, unsigned long offset) | 1522 | struct page *page, unsigned long offset) |
1523 | { | 1523 | { |
1524 | bh->b_page = page; | 1524 | bh->b_page = page; |
1525 | if (offset >= PAGE_SIZE) | 1525 | BUG_ON(offset >= PAGE_SIZE); |
1526 | BUG(); | ||
1527 | if (PageHighMem(page)) | 1526 | if (PageHighMem(page)) |
1528 | /* | 1527 | /* |
1529 | * This catches illegal uses and preserves the offset: | 1528 | * This catches illegal uses and preserves the offset: |
@@ -1593,11 +1592,10 @@ EXPORT_SYMBOL(try_to_release_page); | |||
1593 | * point. Because the caller is about to free (and possibly reuse) those | 1592 | * point. Because the caller is about to free (and possibly reuse) those |
1594 | * blocks on-disk. | 1593 | * blocks on-disk. |
1595 | */ | 1594 | */ |
1596 | int block_invalidatepage(struct page *page, unsigned long offset) | 1595 | void block_invalidatepage(struct page *page, unsigned long offset) |
1597 | { | 1596 | { |
1598 | struct buffer_head *head, *bh, *next; | 1597 | struct buffer_head *head, *bh, *next; |
1599 | unsigned int curr_off = 0; | 1598 | unsigned int curr_off = 0; |
1600 | int ret = 1; | ||
1601 | 1599 | ||
1602 | BUG_ON(!PageLocked(page)); | 1600 | BUG_ON(!PageLocked(page)); |
1603 | if (!page_has_buffers(page)) | 1601 | if (!page_has_buffers(page)) |
@@ -1624,19 +1622,18 @@ int block_invalidatepage(struct page *page, unsigned long offset) | |||
1624 | * so real IO is not possible anymore. | 1622 | * so real IO is not possible anymore. |
1625 | */ | 1623 | */ |
1626 | if (offset == 0) | 1624 | if (offset == 0) |
1627 | ret = try_to_release_page(page, 0); | 1625 | try_to_release_page(page, 0); |
1628 | out: | 1626 | out: |
1629 | return ret; | 1627 | return; |
1630 | } | 1628 | } |
1631 | EXPORT_SYMBOL(block_invalidatepage); | 1629 | EXPORT_SYMBOL(block_invalidatepage); |
1632 | 1630 | ||
1633 | int do_invalidatepage(struct page *page, unsigned long offset) | 1631 | void do_invalidatepage(struct page *page, unsigned long offset) |
1634 | { | 1632 | { |
1635 | int (*invalidatepage)(struct page *, unsigned long); | 1633 | void (*invalidatepage)(struct page *, unsigned long); |
1636 | invalidatepage = page->mapping->a_ops->invalidatepage; | 1634 | invalidatepage = page->mapping->a_ops->invalidatepage ? : |
1637 | if (invalidatepage == NULL) | 1635 | block_invalidatepage; |
1638 | invalidatepage = block_invalidatepage; | 1636 | (*invalidatepage)(page, offset); |
1639 | return (*invalidatepage)(page, offset); | ||
1640 | } | 1637 | } |
1641 | 1638 | ||
1642 | /* | 1639 | /* |
@@ -1738,6 +1735,7 @@ static int __block_write_full_page(struct inode *inode, struct page *page, | |||
1738 | sector_t block; | 1735 | sector_t block; |
1739 | sector_t last_block; | 1736 | sector_t last_block; |
1740 | struct buffer_head *bh, *head; | 1737 | struct buffer_head *bh, *head; |
1738 | const unsigned blocksize = 1 << inode->i_blkbits; | ||
1741 | int nr_underway = 0; | 1739 | int nr_underway = 0; |
1742 | 1740 | ||
1743 | BUG_ON(!PageLocked(page)); | 1741 | BUG_ON(!PageLocked(page)); |
@@ -1745,7 +1743,7 @@ static int __block_write_full_page(struct inode *inode, struct page *page, | |||
1745 | last_block = (i_size_read(inode) - 1) >> inode->i_blkbits; | 1743 | last_block = (i_size_read(inode) - 1) >> inode->i_blkbits; |
1746 | 1744 | ||
1747 | if (!page_has_buffers(page)) { | 1745 | if (!page_has_buffers(page)) { |
1748 | create_empty_buffers(page, 1 << inode->i_blkbits, | 1746 | create_empty_buffers(page, blocksize, |
1749 | (1 << BH_Dirty)|(1 << BH_Uptodate)); | 1747 | (1 << BH_Dirty)|(1 << BH_Uptodate)); |
1750 | } | 1748 | } |
1751 | 1749 | ||
@@ -1780,6 +1778,7 @@ static int __block_write_full_page(struct inode *inode, struct page *page, | |||
1780 | clear_buffer_dirty(bh); | 1778 | clear_buffer_dirty(bh); |
1781 | set_buffer_uptodate(bh); | 1779 | set_buffer_uptodate(bh); |
1782 | } else if (!buffer_mapped(bh) && buffer_dirty(bh)) { | 1780 | } else if (!buffer_mapped(bh) && buffer_dirty(bh)) { |
1781 | WARN_ON(bh->b_size != blocksize); | ||
1783 | err = get_block(inode, block, bh, 1); | 1782 | err = get_block(inode, block, bh, 1); |
1784 | if (err) | 1783 | if (err) |
1785 | goto recover; | 1784 | goto recover; |
@@ -1933,6 +1932,7 @@ static int __block_prepare_write(struct inode *inode, struct page *page, | |||
1933 | if (buffer_new(bh)) | 1932 | if (buffer_new(bh)) |
1934 | clear_buffer_new(bh); | 1933 | clear_buffer_new(bh); |
1935 | if (!buffer_mapped(bh)) { | 1934 | if (!buffer_mapped(bh)) { |
1935 | WARN_ON(bh->b_size != blocksize); | ||
1936 | err = get_block(inode, block, bh, 1); | 1936 | err = get_block(inode, block, bh, 1); |
1937 | if (err) | 1937 | if (err) |
1938 | break; | 1938 | break; |
@@ -2088,6 +2088,7 @@ int block_read_full_page(struct page *page, get_block_t *get_block) | |||
2088 | 2088 | ||
2089 | fully_mapped = 0; | 2089 | fully_mapped = 0; |
2090 | if (iblock < lblock) { | 2090 | if (iblock < lblock) { |
2091 | WARN_ON(bh->b_size != blocksize); | ||
2091 | err = get_block(inode, iblock, bh, 0); | 2092 | err = get_block(inode, iblock, bh, 0); |
2092 | if (err) | 2093 | if (err) |
2093 | SetPageError(page); | 2094 | SetPageError(page); |
@@ -2409,6 +2410,7 @@ int nobh_prepare_write(struct page *page, unsigned from, unsigned to, | |||
2409 | create = 1; | 2410 | create = 1; |
2410 | if (block_start >= to) | 2411 | if (block_start >= to) |
2411 | create = 0; | 2412 | create = 0; |
2413 | map_bh.b_size = blocksize; | ||
2412 | ret = get_block(inode, block_in_file + block_in_page, | 2414 | ret = get_block(inode, block_in_file + block_in_page, |
2413 | &map_bh, create); | 2415 | &map_bh, create); |
2414 | if (ret) | 2416 | if (ret) |
@@ -2669,6 +2671,7 @@ int block_truncate_page(struct address_space *mapping, | |||
2669 | 2671 | ||
2670 | err = 0; | 2672 | err = 0; |
2671 | if (!buffer_mapped(bh)) { | 2673 | if (!buffer_mapped(bh)) { |
2674 | WARN_ON(bh->b_size != blocksize); | ||
2672 | err = get_block(inode, iblock, bh, 0); | 2675 | err = get_block(inode, iblock, bh, 0); |
2673 | if (err) | 2676 | if (err) |
2674 | goto unlock; | 2677 | goto unlock; |
@@ -2755,6 +2758,7 @@ sector_t generic_block_bmap(struct address_space *mapping, sector_t block, | |||
2755 | struct inode *inode = mapping->host; | 2758 | struct inode *inode = mapping->host; |
2756 | tmp.b_state = 0; | 2759 | tmp.b_state = 0; |
2757 | tmp.b_blocknr = 0; | 2760 | tmp.b_blocknr = 0; |
2761 | tmp.b_size = 1 << inode->i_blkbits; | ||
2758 | get_block(inode, block, &tmp, 0); | 2762 | get_block(inode, block, &tmp, 0); |
2759 | return tmp.b_blocknr; | 2763 | return tmp.b_blocknr; |
2760 | } | 2764 | } |
@@ -3007,7 +3011,7 @@ out: | |||
3007 | } | 3011 | } |
3008 | EXPORT_SYMBOL(try_to_free_buffers); | 3012 | EXPORT_SYMBOL(try_to_free_buffers); |
3009 | 3013 | ||
3010 | int block_sync_page(struct page *page) | 3014 | void block_sync_page(struct page *page) |
3011 | { | 3015 | { |
3012 | struct address_space *mapping; | 3016 | struct address_space *mapping; |
3013 | 3017 | ||
@@ -3015,7 +3019,6 @@ int block_sync_page(struct page *page) | |||
3015 | mapping = page_mapping(page); | 3019 | mapping = page_mapping(page); |
3016 | if (mapping) | 3020 | if (mapping) |
3017 | blk_run_backing_dev(mapping->backing_dev_info, page); | 3021 | blk_run_backing_dev(mapping->backing_dev_info, page); |
3018 | return 0; | ||
3019 | } | 3022 | } |
3020 | 3023 | ||
3021 | /* | 3024 | /* |
diff --git a/fs/char_dev.c b/fs/char_dev.c index 8c6eb04d31e2..4e1b849f912f 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c | |||
@@ -250,7 +250,7 @@ int alloc_chrdev_region(dev_t *dev, unsigned baseminor, unsigned count, | |||
250 | } | 250 | } |
251 | 251 | ||
252 | int register_chrdev(unsigned int major, const char *name, | 252 | int register_chrdev(unsigned int major, const char *name, |
253 | struct file_operations *fops) | 253 | const struct file_operations *fops) |
254 | { | 254 | { |
255 | struct char_device_struct *cd; | 255 | struct char_device_struct *cd; |
256 | struct cdev *cdev; | 256 | struct cdev *cdev; |
@@ -406,7 +406,7 @@ static void cdev_purge(struct cdev *cdev) | |||
406 | * is contain the open that then fills in the correct operations | 406 | * is contain the open that then fills in the correct operations |
407 | * depending on the special file... | 407 | * depending on the special file... |
408 | */ | 408 | */ |
409 | struct file_operations def_chr_fops = { | 409 | const struct file_operations def_chr_fops = { |
410 | .open = chrdev_open, | 410 | .open = chrdev_open, |
411 | }; | 411 | }; |
412 | 412 | ||
@@ -473,7 +473,7 @@ struct cdev *cdev_alloc(void) | |||
473 | return p; | 473 | return p; |
474 | } | 474 | } |
475 | 475 | ||
476 | void cdev_init(struct cdev *cdev, struct file_operations *fops) | 476 | void cdev_init(struct cdev *cdev, const struct file_operations *fops) |
477 | { | 477 | { |
478 | memset(cdev, 0, sizeof *cdev); | 478 | memset(cdev, 0, sizeof *cdev); |
479 | INIT_LIST_HEAD(&cdev->list); | 479 | INIT_LIST_HEAD(&cdev->list); |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 221b3334b737..4bbc544857bc 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c | |||
@@ -583,7 +583,7 @@ struct inode_operations cifs_symlink_inode_ops = { | |||
583 | #endif | 583 | #endif |
584 | }; | 584 | }; |
585 | 585 | ||
586 | struct file_operations cifs_file_ops = { | 586 | const struct file_operations cifs_file_ops = { |
587 | .read = do_sync_read, | 587 | .read = do_sync_read, |
588 | .write = do_sync_write, | 588 | .write = do_sync_write, |
589 | .readv = generic_file_readv, | 589 | .readv = generic_file_readv, |
@@ -607,7 +607,7 @@ struct file_operations cifs_file_ops = { | |||
607 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ | 607 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ |
608 | }; | 608 | }; |
609 | 609 | ||
610 | struct file_operations cifs_file_direct_ops = { | 610 | const struct file_operations cifs_file_direct_ops = { |
611 | /* no mmap, no aio, no readv - | 611 | /* no mmap, no aio, no readv - |
612 | BB reevaluate whether they can be done with directio, no cache */ | 612 | BB reevaluate whether they can be done with directio, no cache */ |
613 | .read = cifs_user_read, | 613 | .read = cifs_user_read, |
@@ -626,7 +626,7 @@ struct file_operations cifs_file_direct_ops = { | |||
626 | .dir_notify = cifs_dir_notify, | 626 | .dir_notify = cifs_dir_notify, |
627 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ | 627 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ |
628 | }; | 628 | }; |
629 | struct file_operations cifs_file_nobrl_ops = { | 629 | const struct file_operations cifs_file_nobrl_ops = { |
630 | .read = do_sync_read, | 630 | .read = do_sync_read, |
631 | .write = do_sync_write, | 631 | .write = do_sync_write, |
632 | .readv = generic_file_readv, | 632 | .readv = generic_file_readv, |
@@ -649,7 +649,7 @@ struct file_operations cifs_file_nobrl_ops = { | |||
649 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ | 649 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ |
650 | }; | 650 | }; |
651 | 651 | ||
652 | struct file_operations cifs_file_direct_nobrl_ops = { | 652 | const struct file_operations cifs_file_direct_nobrl_ops = { |
653 | /* no mmap, no aio, no readv - | 653 | /* no mmap, no aio, no readv - |
654 | BB reevaluate whether they can be done with directio, no cache */ | 654 | BB reevaluate whether they can be done with directio, no cache */ |
655 | .read = cifs_user_read, | 655 | .read = cifs_user_read, |
@@ -668,7 +668,7 @@ struct file_operations cifs_file_direct_nobrl_ops = { | |||
668 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ | 668 | #endif /* CONFIG_CIFS_EXPERIMENTAL */ |
669 | }; | 669 | }; |
670 | 670 | ||
671 | struct file_operations cifs_dir_ops = { | 671 | const struct file_operations cifs_dir_ops = { |
672 | .readdir = cifs_readdir, | 672 | .readdir = cifs_readdir, |
673 | .release = cifs_closedir, | 673 | .release = cifs_closedir, |
674 | .read = generic_read_dir, | 674 | .read = generic_read_dir, |
@@ -738,10 +738,8 @@ cifs_init_request_bufs(void) | |||
738 | cERROR(1,("cifs_min_rcv set to maximum (64)")); | 738 | cERROR(1,("cifs_min_rcv set to maximum (64)")); |
739 | } | 739 | } |
740 | 740 | ||
741 | cifs_req_poolp = mempool_create(cifs_min_rcv, | 741 | cifs_req_poolp = mempool_create_slab_pool(cifs_min_rcv, |
742 | mempool_alloc_slab, | 742 | cifs_req_cachep); |
743 | mempool_free_slab, | ||
744 | cifs_req_cachep); | ||
745 | 743 | ||
746 | if(cifs_req_poolp == NULL) { | 744 | if(cifs_req_poolp == NULL) { |
747 | kmem_cache_destroy(cifs_req_cachep); | 745 | kmem_cache_destroy(cifs_req_cachep); |
@@ -771,10 +769,8 @@ cifs_init_request_bufs(void) | |||
771 | cFYI(1,("cifs_min_small set to maximum (256)")); | 769 | cFYI(1,("cifs_min_small set to maximum (256)")); |
772 | } | 770 | } |
773 | 771 | ||
774 | cifs_sm_req_poolp = mempool_create(cifs_min_small, | 772 | cifs_sm_req_poolp = mempool_create_slab_pool(cifs_min_small, |
775 | mempool_alloc_slab, | 773 | cifs_sm_req_cachep); |
776 | mempool_free_slab, | ||
777 | cifs_sm_req_cachep); | ||
778 | 774 | ||
779 | if(cifs_sm_req_poolp == NULL) { | 775 | if(cifs_sm_req_poolp == NULL) { |
780 | mempool_destroy(cifs_req_poolp); | 776 | mempool_destroy(cifs_req_poolp); |
@@ -808,10 +804,8 @@ cifs_init_mids(void) | |||
808 | if (cifs_mid_cachep == NULL) | 804 | if (cifs_mid_cachep == NULL) |
809 | return -ENOMEM; | 805 | return -ENOMEM; |
810 | 806 | ||
811 | cifs_mid_poolp = mempool_create(3 /* a reasonable min simultan opers */, | 807 | /* 3 is a reasonable minimum number of simultaneous operations */ |
812 | mempool_alloc_slab, | 808 | cifs_mid_poolp = mempool_create_slab_pool(3, cifs_mid_cachep); |
813 | mempool_free_slab, | ||
814 | cifs_mid_cachep); | ||
815 | if(cifs_mid_poolp == NULL) { | 809 | if(cifs_mid_poolp == NULL) { |
816 | kmem_cache_destroy(cifs_mid_cachep); | 810 | kmem_cache_destroy(cifs_mid_cachep); |
817 | return -ENOMEM; | 811 | return -ENOMEM; |
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 821a8eb22559..74f405ae4da3 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -61,10 +61,10 @@ extern struct inode_operations cifs_file_inode_ops; | |||
61 | extern struct inode_operations cifs_symlink_inode_ops; | 61 | extern struct inode_operations cifs_symlink_inode_ops; |
62 | 62 | ||
63 | /* Functions related to files and directories */ | 63 | /* Functions related to files and directories */ |
64 | extern struct file_operations cifs_file_ops; | 64 | extern const struct file_operations cifs_file_ops; |
65 | extern struct file_operations cifs_file_direct_ops; /* if directio mount */ | 65 | extern const struct file_operations cifs_file_direct_ops; /* if directio mount */ |
66 | extern struct file_operations cifs_file_nobrl_ops; | 66 | extern const struct file_operations cifs_file_nobrl_ops; |
67 | extern struct file_operations cifs_file_direct_nobrl_ops; /* if directio mount */ | 67 | extern const struct file_operations cifs_file_direct_nobrl_ops; /* if directio mount */ |
68 | extern int cifs_open(struct inode *inode, struct file *file); | 68 | extern int cifs_open(struct inode *inode, struct file *file); |
69 | extern int cifs_close(struct inode *inode, struct file *file); | 69 | extern int cifs_close(struct inode *inode, struct file *file); |
70 | extern int cifs_closedir(struct inode *inode, struct file *file); | 70 | extern int cifs_closedir(struct inode *inode, struct file *file); |
@@ -76,7 +76,7 @@ extern int cifs_lock(struct file *, int, struct file_lock *); | |||
76 | extern int cifs_fsync(struct file *, struct dentry *, int); | 76 | extern int cifs_fsync(struct file *, struct dentry *, int); |
77 | extern int cifs_flush(struct file *); | 77 | extern int cifs_flush(struct file *); |
78 | extern int cifs_file_mmap(struct file * , struct vm_area_struct *); | 78 | extern int cifs_file_mmap(struct file * , struct vm_area_struct *); |
79 | extern struct file_operations cifs_dir_ops; | 79 | extern const struct file_operations cifs_dir_ops; |
80 | extern int cifs_dir_open(struct inode *inode, struct file *file); | 80 | extern int cifs_dir_open(struct inode *inode, struct file *file); |
81 | extern int cifs_readdir(struct file *file, void *direntry, filldir_t filldir); | 81 | extern int cifs_readdir(struct file *file, void *direntry, filldir_t filldir); |
82 | extern int cifs_dir_notify(struct file *, unsigned long arg); | 82 | extern int cifs_dir_notify(struct file *, unsigned long arg); |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 165d67426381..fb49aef1f2ec 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -1339,7 +1339,7 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1339 | return rc; | 1339 | return rc; |
1340 | } | 1340 | } |
1341 | 1341 | ||
1342 | /* static int cifs_sync_page(struct page *page) | 1342 | /* static void cifs_sync_page(struct page *page) |
1343 | { | 1343 | { |
1344 | struct address_space *mapping; | 1344 | struct address_space *mapping; |
1345 | struct inode *inode; | 1345 | struct inode *inode; |
@@ -1353,16 +1353,18 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1353 | return 0; | 1353 | return 0; |
1354 | inode = mapping->host; | 1354 | inode = mapping->host; |
1355 | if (!inode) | 1355 | if (!inode) |
1356 | return 0; */ | 1356 | return; */ |
1357 | 1357 | ||
1358 | /* fill in rpages then | 1358 | /* fill in rpages then |
1359 | result = cifs_pagein_inode(inode, index, rpages); */ /* BB finish */ | 1359 | result = cifs_pagein_inode(inode, index, rpages); */ /* BB finish */ |
1360 | 1360 | ||
1361 | /* cFYI(1, ("rpages is %d for sync page of Index %ld ", rpages, index)); | 1361 | /* cFYI(1, ("rpages is %d for sync page of Index %ld ", rpages, index)); |
1362 | 1362 | ||
1363 | #if 0 | ||
1363 | if (rc < 0) | 1364 | if (rc < 0) |
1364 | return rc; | 1365 | return rc; |
1365 | return 0; | 1366 | return 0; |
1367 | #endif | ||
1366 | } */ | 1368 | } */ |
1367 | 1369 | ||
1368 | /* | 1370 | /* |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index ff93a9f81d1c..598eec9778f6 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -163,9 +163,9 @@ int cifs_get_inode_info_unix(struct inode **pinode, | |||
163 | 163 | ||
164 | if (num_of_bytes < end_of_file) | 164 | if (num_of_bytes < end_of_file) |
165 | cFYI(1, ("allocation size less than end of file")); | 165 | cFYI(1, ("allocation size less than end of file")); |
166 | cFYI(1, | 166 | cFYI(1, ("Size %ld and blocks %llu", |
167 | ("Size %ld and blocks %ld", | 167 | (unsigned long) inode->i_size, |
168 | (unsigned long) inode->i_size, inode->i_blocks)); | 168 | (unsigned long long)inode->i_blocks)); |
169 | if (S_ISREG(inode->i_mode)) { | 169 | if (S_ISREG(inode->i_mode)) { |
170 | cFYI(1, ("File inode")); | 170 | cFYI(1, ("File inode")); |
171 | inode->i_op = &cifs_file_inode_ops; | 171 | inode->i_op = &cifs_file_inode_ops; |
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index edb3b6eb34bc..488bd0d81dcf 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c | |||
@@ -197,10 +197,10 @@ static void fill_in_inode(struct inode *tmp_inode, | |||
197 | 197 | ||
198 | if (allocation_size < end_of_file) | 198 | if (allocation_size < end_of_file) |
199 | cFYI(1, ("May be sparse file, allocation less than file size")); | 199 | cFYI(1, ("May be sparse file, allocation less than file size")); |
200 | cFYI(1, | 200 | cFYI(1, ("File Size %ld and blocks %llu and blocksize %ld", |
201 | ("File Size %ld and blocks %ld and blocksize %ld", | 201 | (unsigned long)tmp_inode->i_size, |
202 | (unsigned long)tmp_inode->i_size, tmp_inode->i_blocks, | 202 | (unsigned long long)tmp_inode->i_blocks, |
203 | tmp_inode->i_blksize)); | 203 | tmp_inode->i_blksize)); |
204 | if (S_ISREG(tmp_inode->i_mode)) { | 204 | if (S_ISREG(tmp_inode->i_mode)) { |
205 | cFYI(1, ("File inode")); | 205 | cFYI(1, ("File inode")); |
206 | tmp_inode->i_op = &cifs_file_inode_ops; | 206 | tmp_inode->i_op = &cifs_file_inode_ops; |
diff --git a/fs/coda/dir.c b/fs/coda/dir.c index 54f76de8a686..71f2ea632e53 100644 --- a/fs/coda/dir.c +++ b/fs/coda/dir.c | |||
@@ -82,7 +82,7 @@ struct inode_operations coda_dir_inode_operations = | |||
82 | .setattr = coda_setattr, | 82 | .setattr = coda_setattr, |
83 | }; | 83 | }; |
84 | 84 | ||
85 | struct file_operations coda_dir_operations = { | 85 | const struct file_operations coda_dir_operations = { |
86 | .llseek = generic_file_llseek, | 86 | .llseek = generic_file_llseek, |
87 | .read = generic_read_dir, | 87 | .read = generic_read_dir, |
88 | .readdir = coda_readdir, | 88 | .readdir = coda_readdir, |
diff --git a/fs/coda/file.c b/fs/coda/file.c index 146a991d6eb5..7c2642431fa5 100644 --- a/fs/coda/file.c +++ b/fs/coda/file.c | |||
@@ -288,7 +288,7 @@ int coda_fsync(struct file *coda_file, struct dentry *coda_dentry, int datasync) | |||
288 | return err; | 288 | return err; |
289 | } | 289 | } |
290 | 290 | ||
291 | struct file_operations coda_file_operations = { | 291 | const struct file_operations coda_file_operations = { |
292 | .llseek = generic_file_llseek, | 292 | .llseek = generic_file_llseek, |
293 | .read = coda_file_read, | 293 | .read = coda_file_read, |
294 | .write = coda_file_write, | 294 | .write = coda_file_write, |
diff --git a/fs/coda/pioctl.c b/fs/coda/pioctl.c index 127714936c66..214822be87bd 100644 --- a/fs/coda/pioctl.c +++ b/fs/coda/pioctl.c | |||
@@ -36,7 +36,7 @@ struct inode_operations coda_ioctl_inode_operations = | |||
36 | .setattr = coda_setattr, | 36 | .setattr = coda_setattr, |
37 | }; | 37 | }; |
38 | 38 | ||
39 | struct file_operations coda_ioctl_operations = { | 39 | const struct file_operations coda_ioctl_operations = { |
40 | .owner = THIS_MODULE, | 40 | .owner = THIS_MODULE, |
41 | .ioctl = coda_pioctl, | 41 | .ioctl = coda_pioctl, |
42 | }; | 42 | }; |
diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index 98c74fe2e139..6c6771db36da 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c | |||
@@ -342,7 +342,7 @@ static int coda_psdev_release(struct inode * inode, struct file * file) | |||
342 | } | 342 | } |
343 | 343 | ||
344 | 344 | ||
345 | static struct file_operations coda_psdev_fops = { | 345 | static const struct file_operations coda_psdev_fops = { |
346 | .owner = THIS_MODULE, | 346 | .owner = THIS_MODULE, |
347 | .read = coda_psdev_read, | 347 | .read = coda_psdev_read, |
348 | .write = coda_psdev_write, | 348 | .write = coda_psdev_write, |
diff --git a/fs/compat.c b/fs/compat.c index ef5a0771592d..7f8e26ea427c 100644 --- a/fs/compat.c +++ b/fs/compat.c | |||
@@ -1639,15 +1639,6 @@ void compat_set_fd_set(unsigned long nr, compat_ulong_t __user *ufdset, | |||
1639 | * This is a virtual copy of sys_select from fs/select.c and probably | 1639 | * This is a virtual copy of sys_select from fs/select.c and probably |
1640 | * should be compared to it from time to time | 1640 | * should be compared to it from time to time |
1641 | */ | 1641 | */ |
1642 | static void *select_bits_alloc(int size) | ||
1643 | { | ||
1644 | return kmalloc(6 * size, GFP_KERNEL); | ||
1645 | } | ||
1646 | |||
1647 | static void select_bits_free(void *bits, int size) | ||
1648 | { | ||
1649 | kfree(bits); | ||
1650 | } | ||
1651 | 1642 | ||
1652 | /* | 1643 | /* |
1653 | * We can actually return ERESTARTSYS instead of EINTR, but I'd | 1644 | * We can actually return ERESTARTSYS instead of EINTR, but I'd |
@@ -1686,7 +1677,7 @@ int compat_core_sys_select(int n, compat_ulong_t __user *inp, | |||
1686 | */ | 1677 | */ |
1687 | ret = -ENOMEM; | 1678 | ret = -ENOMEM; |
1688 | size = FDS_BYTES(n); | 1679 | size = FDS_BYTES(n); |
1689 | bits = select_bits_alloc(size); | 1680 | bits = kmalloc(6 * size, GFP_KERNEL); |
1690 | if (!bits) | 1681 | if (!bits) |
1691 | goto out_nofds; | 1682 | goto out_nofds; |
1692 | fds.in = (unsigned long *) bits; | 1683 | fds.in = (unsigned long *) bits; |
@@ -1720,7 +1711,7 @@ int compat_core_sys_select(int n, compat_ulong_t __user *inp, | |||
1720 | compat_set_fd_set(n, exp, fds.res_ex); | 1711 | compat_set_fd_set(n, exp, fds.res_ex); |
1721 | 1712 | ||
1722 | out: | 1713 | out: |
1723 | select_bits_free(bits, size); | 1714 | kfree(bits); |
1724 | out_nofds: | 1715 | out_nofds: |
1725 | return ret; | 1716 | return ret; |
1726 | } | 1717 | } |
diff --git a/fs/configfs/configfs_internal.h b/fs/configfs/configfs_internal.h index f70e46951b37..3f4ff7a242b9 100644 --- a/fs/configfs/configfs_internal.h +++ b/fs/configfs/configfs_internal.h | |||
@@ -72,9 +72,9 @@ extern void configfs_release_fs(void); | |||
72 | 72 | ||
73 | extern struct rw_semaphore configfs_rename_sem; | 73 | extern struct rw_semaphore configfs_rename_sem; |
74 | extern struct super_block * configfs_sb; | 74 | extern struct super_block * configfs_sb; |
75 | extern struct file_operations configfs_dir_operations; | 75 | extern const struct file_operations configfs_dir_operations; |
76 | extern struct file_operations configfs_file_operations; | 76 | extern const struct file_operations configfs_file_operations; |
77 | extern struct file_operations bin_fops; | 77 | extern const struct file_operations bin_fops; |
78 | extern struct inode_operations configfs_dir_inode_operations; | 78 | extern struct inode_operations configfs_dir_inode_operations; |
79 | extern struct inode_operations configfs_symlink_inode_operations; | 79 | extern struct inode_operations configfs_symlink_inode_operations; |
80 | 80 | ||
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index ca60e3abef45..8ed9b06a9828 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c | |||
@@ -1027,7 +1027,7 @@ static loff_t configfs_dir_lseek(struct file * file, loff_t offset, int origin) | |||
1027 | return offset; | 1027 | return offset; |
1028 | } | 1028 | } |
1029 | 1029 | ||
1030 | struct file_operations configfs_dir_operations = { | 1030 | const struct file_operations configfs_dir_operations = { |
1031 | .open = configfs_dir_open, | 1031 | .open = configfs_dir_open, |
1032 | .release = configfs_dir_close, | 1032 | .release = configfs_dir_close, |
1033 | .llseek = configfs_dir_lseek, | 1033 | .llseek = configfs_dir_lseek, |
diff --git a/fs/configfs/file.c b/fs/configfs/file.c index 3921920d8716..f499803743e0 100644 --- a/fs/configfs/file.c +++ b/fs/configfs/file.c | |||
@@ -322,7 +322,7 @@ static int configfs_release(struct inode * inode, struct file * filp) | |||
322 | return 0; | 322 | return 0; |
323 | } | 323 | } |
324 | 324 | ||
325 | struct file_operations configfs_file_operations = { | 325 | const struct file_operations configfs_file_operations = { |
326 | .read = configfs_read_file, | 326 | .read = configfs_read_file, |
327 | .write = configfs_write_file, | 327 | .write = configfs_write_file, |
328 | .llseek = generic_file_llseek, | 328 | .llseek = generic_file_llseek, |
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index 8ad52f5bf255..9efcc3a164e8 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c | |||
@@ -22,16 +22,17 @@ | |||
22 | #include <linux/cramfs_fs_sb.h> | 22 | #include <linux/cramfs_fs_sb.h> |
23 | #include <linux/buffer_head.h> | 23 | #include <linux/buffer_head.h> |
24 | #include <linux/vfs.h> | 24 | #include <linux/vfs.h> |
25 | #include <linux/mutex.h> | ||
25 | #include <asm/semaphore.h> | 26 | #include <asm/semaphore.h> |
26 | 27 | ||
27 | #include <asm/uaccess.h> | 28 | #include <asm/uaccess.h> |
28 | 29 | ||
29 | static struct super_operations cramfs_ops; | 30 | static struct super_operations cramfs_ops; |
30 | static struct inode_operations cramfs_dir_inode_operations; | 31 | static struct inode_operations cramfs_dir_inode_operations; |
31 | static struct file_operations cramfs_directory_operations; | 32 | static const struct file_operations cramfs_directory_operations; |
32 | static struct address_space_operations cramfs_aops; | 33 | static struct address_space_operations cramfs_aops; |
33 | 34 | ||
34 | static DECLARE_MUTEX(read_mutex); | 35 | static DEFINE_MUTEX(read_mutex); |
35 | 36 | ||
36 | 37 | ||
37 | /* These two macros may change in future, to provide better st_ino | 38 | /* These two macros may change in future, to provide better st_ino |
@@ -250,20 +251,20 @@ static int cramfs_fill_super(struct super_block *sb, void *data, int silent) | |||
250 | memset(sbi, 0, sizeof(struct cramfs_sb_info)); | 251 | memset(sbi, 0, sizeof(struct cramfs_sb_info)); |
251 | 252 | ||
252 | /* Invalidate the read buffers on mount: think disk change.. */ | 253 | /* Invalidate the read buffers on mount: think disk change.. */ |
253 | down(&read_mutex); | 254 | mutex_lock(&read_mutex); |
254 | for (i = 0; i < READ_BUFFERS; i++) | 255 | for (i = 0; i < READ_BUFFERS; i++) |
255 | buffer_blocknr[i] = -1; | 256 | buffer_blocknr[i] = -1; |
256 | 257 | ||
257 | /* Read the first block and get the superblock from it */ | 258 | /* Read the first block and get the superblock from it */ |
258 | memcpy(&super, cramfs_read(sb, 0, sizeof(super)), sizeof(super)); | 259 | memcpy(&super, cramfs_read(sb, 0, sizeof(super)), sizeof(super)); |
259 | up(&read_mutex); | 260 | mutex_unlock(&read_mutex); |
260 | 261 | ||
261 | /* Do sanity checks on the superblock */ | 262 | /* Do sanity checks on the superblock */ |
262 | if (super.magic != CRAMFS_MAGIC) { | 263 | if (super.magic != CRAMFS_MAGIC) { |
263 | /* check at 512 byte offset */ | 264 | /* check at 512 byte offset */ |
264 | down(&read_mutex); | 265 | mutex_lock(&read_mutex); |
265 | memcpy(&super, cramfs_read(sb, 512, sizeof(super)), sizeof(super)); | 266 | memcpy(&super, cramfs_read(sb, 512, sizeof(super)), sizeof(super)); |
266 | up(&read_mutex); | 267 | mutex_unlock(&read_mutex); |
267 | if (super.magic != CRAMFS_MAGIC) { | 268 | if (super.magic != CRAMFS_MAGIC) { |
268 | if (!silent) | 269 | if (!silent) |
269 | printk(KERN_ERR "cramfs: wrong magic\n"); | 270 | printk(KERN_ERR "cramfs: wrong magic\n"); |
@@ -366,7 +367,7 @@ static int cramfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
366 | mode_t mode; | 367 | mode_t mode; |
367 | int namelen, error; | 368 | int namelen, error; |
368 | 369 | ||
369 | down(&read_mutex); | 370 | mutex_lock(&read_mutex); |
370 | de = cramfs_read(sb, OFFSET(inode) + offset, sizeof(*de)+256); | 371 | de = cramfs_read(sb, OFFSET(inode) + offset, sizeof(*de)+256); |
371 | name = (char *)(de+1); | 372 | name = (char *)(de+1); |
372 | 373 | ||
@@ -379,7 +380,7 @@ static int cramfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
379 | memcpy(buf, name, namelen); | 380 | memcpy(buf, name, namelen); |
380 | ino = CRAMINO(de); | 381 | ino = CRAMINO(de); |
381 | mode = de->mode; | 382 | mode = de->mode; |
382 | up(&read_mutex); | 383 | mutex_unlock(&read_mutex); |
383 | nextoffset = offset + sizeof(*de) + namelen; | 384 | nextoffset = offset + sizeof(*de) + namelen; |
384 | for (;;) { | 385 | for (;;) { |
385 | if (!namelen) { | 386 | if (!namelen) { |
@@ -410,7 +411,7 @@ static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, s | |||
410 | unsigned int offset = 0; | 411 | unsigned int offset = 0; |
411 | int sorted; | 412 | int sorted; |
412 | 413 | ||
413 | down(&read_mutex); | 414 | mutex_lock(&read_mutex); |
414 | sorted = CRAMFS_SB(dir->i_sb)->flags & CRAMFS_FLAG_SORTED_DIRS; | 415 | sorted = CRAMFS_SB(dir->i_sb)->flags & CRAMFS_FLAG_SORTED_DIRS; |
415 | while (offset < dir->i_size) { | 416 | while (offset < dir->i_size) { |
416 | struct cramfs_inode *de; | 417 | struct cramfs_inode *de; |
@@ -433,7 +434,7 @@ static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, s | |||
433 | 434 | ||
434 | for (;;) { | 435 | for (;;) { |
435 | if (!namelen) { | 436 | if (!namelen) { |
436 | up(&read_mutex); | 437 | mutex_unlock(&read_mutex); |
437 | return ERR_PTR(-EIO); | 438 | return ERR_PTR(-EIO); |
438 | } | 439 | } |
439 | if (name[namelen-1]) | 440 | if (name[namelen-1]) |
@@ -447,7 +448,7 @@ static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, s | |||
447 | continue; | 448 | continue; |
448 | if (!retval) { | 449 | if (!retval) { |
449 | struct cramfs_inode entry = *de; | 450 | struct cramfs_inode entry = *de; |
450 | up(&read_mutex); | 451 | mutex_unlock(&read_mutex); |
451 | d_add(dentry, get_cramfs_inode(dir->i_sb, &entry)); | 452 | d_add(dentry, get_cramfs_inode(dir->i_sb, &entry)); |
452 | return NULL; | 453 | return NULL; |
453 | } | 454 | } |
@@ -455,7 +456,7 @@ static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, s | |||
455 | if (sorted) | 456 | if (sorted) |
456 | break; | 457 | break; |
457 | } | 458 | } |
458 | up(&read_mutex); | 459 | mutex_unlock(&read_mutex); |
459 | d_add(dentry, NULL); | 460 | d_add(dentry, NULL); |
460 | return NULL; | 461 | return NULL; |
461 | } | 462 | } |
@@ -474,21 +475,21 @@ static int cramfs_readpage(struct file *file, struct page * page) | |||
474 | u32 start_offset, compr_len; | 475 | u32 start_offset, compr_len; |
475 | 476 | ||
476 | start_offset = OFFSET(inode) + maxblock*4; | 477 | start_offset = OFFSET(inode) + maxblock*4; |
477 | down(&read_mutex); | 478 | mutex_lock(&read_mutex); |
478 | if (page->index) | 479 | if (page->index) |
479 | start_offset = *(u32 *) cramfs_read(sb, blkptr_offset-4, 4); | 480 | start_offset = *(u32 *) cramfs_read(sb, blkptr_offset-4, 4); |
480 | compr_len = (*(u32 *) cramfs_read(sb, blkptr_offset, 4) - start_offset); | 481 | compr_len = (*(u32 *) cramfs_read(sb, blkptr_offset, 4) - start_offset); |
481 | up(&read_mutex); | 482 | mutex_unlock(&read_mutex); |
482 | pgdata = kmap(page); | 483 | pgdata = kmap(page); |
483 | if (compr_len == 0) | 484 | if (compr_len == 0) |
484 | ; /* hole */ | 485 | ; /* hole */ |
485 | else { | 486 | else { |
486 | down(&read_mutex); | 487 | mutex_lock(&read_mutex); |
487 | bytes_filled = cramfs_uncompress_block(pgdata, | 488 | bytes_filled = cramfs_uncompress_block(pgdata, |
488 | PAGE_CACHE_SIZE, | 489 | PAGE_CACHE_SIZE, |
489 | cramfs_read(sb, start_offset, compr_len), | 490 | cramfs_read(sb, start_offset, compr_len), |
490 | compr_len); | 491 | compr_len); |
491 | up(&read_mutex); | 492 | mutex_unlock(&read_mutex); |
492 | } | 493 | } |
493 | } else | 494 | } else |
494 | pgdata = kmap(page); | 495 | pgdata = kmap(page); |
@@ -511,7 +512,7 @@ static struct address_space_operations cramfs_aops = { | |||
511 | /* | 512 | /* |
512 | * A directory can only readdir | 513 | * A directory can only readdir |
513 | */ | 514 | */ |
514 | static struct file_operations cramfs_directory_operations = { | 515 | static const struct file_operations cramfs_directory_operations = { |
515 | .llseek = generic_file_llseek, | 516 | .llseek = generic_file_llseek, |
516 | .read = generic_read_dir, | 517 | .read = generic_read_dir, |
517 | .readdir = cramfs_readdir, | 518 | .readdir = cramfs_readdir, |
diff --git a/fs/dcache.c b/fs/dcache.c index 939584648504..19458d399502 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -34,9 +34,8 @@ | |||
34 | #include <linux/swap.h> | 34 | #include <linux/swap.h> |
35 | #include <linux/bootmem.h> | 35 | #include <linux/bootmem.h> |
36 | 36 | ||
37 | /* #define DCACHE_DEBUG 1 */ | ||
38 | 37 | ||
39 | int sysctl_vfs_cache_pressure = 100; | 38 | int sysctl_vfs_cache_pressure __read_mostly = 100; |
40 | EXPORT_SYMBOL_GPL(sysctl_vfs_cache_pressure); | 39 | EXPORT_SYMBOL_GPL(sysctl_vfs_cache_pressure); |
41 | 40 | ||
42 | __cacheline_aligned_in_smp DEFINE_SPINLOCK(dcache_lock); | 41 | __cacheline_aligned_in_smp DEFINE_SPINLOCK(dcache_lock); |
@@ -44,7 +43,7 @@ static seqlock_t rename_lock __cacheline_aligned_in_smp = SEQLOCK_UNLOCKED; | |||
44 | 43 | ||
45 | EXPORT_SYMBOL(dcache_lock); | 44 | EXPORT_SYMBOL(dcache_lock); |
46 | 45 | ||
47 | static kmem_cache_t *dentry_cache; | 46 | static kmem_cache_t *dentry_cache __read_mostly; |
48 | 47 | ||
49 | #define DNAME_INLINE_LEN (sizeof(struct dentry)-offsetof(struct dentry,d_iname)) | 48 | #define DNAME_INLINE_LEN (sizeof(struct dentry)-offsetof(struct dentry,d_iname)) |
50 | 49 | ||
@@ -59,9 +58,9 @@ static kmem_cache_t *dentry_cache; | |||
59 | #define D_HASHBITS d_hash_shift | 58 | #define D_HASHBITS d_hash_shift |
60 | #define D_HASHMASK d_hash_mask | 59 | #define D_HASHMASK d_hash_mask |
61 | 60 | ||
62 | static unsigned int d_hash_mask; | 61 | static unsigned int d_hash_mask __read_mostly; |
63 | static unsigned int d_hash_shift; | 62 | static unsigned int d_hash_shift __read_mostly; |
64 | static struct hlist_head *dentry_hashtable; | 63 | static struct hlist_head *dentry_hashtable __read_mostly; |
65 | static LIST_HEAD(dentry_unused); | 64 | static LIST_HEAD(dentry_unused); |
66 | 65 | ||
67 | /* Statistics gathering. */ | 66 | /* Statistics gathering. */ |
@@ -603,10 +602,6 @@ resume: | |||
603 | */ | 602 | */ |
604 | if (!list_empty(&dentry->d_subdirs)) { | 603 | if (!list_empty(&dentry->d_subdirs)) { |
605 | this_parent = dentry; | 604 | this_parent = dentry; |
606 | #ifdef DCACHE_DEBUG | ||
607 | printk(KERN_DEBUG "select_parent: descending to %s/%s, found=%d\n", | ||
608 | dentry->d_parent->d_name.name, dentry->d_name.name, found); | ||
609 | #endif | ||
610 | goto repeat; | 605 | goto repeat; |
611 | } | 606 | } |
612 | } | 607 | } |
@@ -616,10 +611,6 @@ dentry->d_parent->d_name.name, dentry->d_name.name, found); | |||
616 | if (this_parent != parent) { | 611 | if (this_parent != parent) { |
617 | next = this_parent->d_u.d_child.next; | 612 | next = this_parent->d_u.d_child.next; |
618 | this_parent = this_parent->d_parent; | 613 | this_parent = this_parent->d_parent; |
619 | #ifdef DCACHE_DEBUG | ||
620 | printk(KERN_DEBUG "select_parent: ascending to %s/%s, found=%d\n", | ||
621 | this_parent->d_parent->d_name.name, this_parent->d_name.name, found); | ||
622 | #endif | ||
623 | goto resume; | 614 | goto resume; |
624 | } | 615 | } |
625 | out: | 616 | out: |
@@ -798,7 +789,7 @@ struct dentry *d_alloc_name(struct dentry *parent, const char *name) | |||
798 | 789 | ||
799 | void d_instantiate(struct dentry *entry, struct inode * inode) | 790 | void d_instantiate(struct dentry *entry, struct inode * inode) |
800 | { | 791 | { |
801 | if (!list_empty(&entry->d_alias)) BUG(); | 792 | BUG_ON(!list_empty(&entry->d_alias)); |
802 | spin_lock(&dcache_lock); | 793 | spin_lock(&dcache_lock); |
803 | if (inode) | 794 | if (inode) |
804 | list_add(&entry->d_alias, &inode->i_dentry); | 795 | list_add(&entry->d_alias, &inode->i_dentry); |
@@ -1719,10 +1710,10 @@ static void __init dcache_init(unsigned long mempages) | |||
1719 | } | 1710 | } |
1720 | 1711 | ||
1721 | /* SLAB cache for __getname() consumers */ | 1712 | /* SLAB cache for __getname() consumers */ |
1722 | kmem_cache_t *names_cachep; | 1713 | kmem_cache_t *names_cachep __read_mostly; |
1723 | 1714 | ||
1724 | /* SLAB cache for file structures */ | 1715 | /* SLAB cache for file structures */ |
1725 | kmem_cache_t *filp_cachep; | 1716 | kmem_cache_t *filp_cachep __read_mostly; |
1726 | 1717 | ||
1727 | EXPORT_SYMBOL(d_genocide); | 1718 | EXPORT_SYMBOL(d_genocide); |
1728 | 1719 | ||
diff --git a/fs/dcookies.c b/fs/dcookies.c index f8274a8f83bd..8749339bf4f6 100644 --- a/fs/dcookies.c +++ b/fs/dcookies.c | |||
@@ -23,6 +23,7 @@ | |||
23 | #include <linux/mm.h> | 23 | #include <linux/mm.h> |
24 | #include <linux/errno.h> | 24 | #include <linux/errno.h> |
25 | #include <linux/dcookies.h> | 25 | #include <linux/dcookies.h> |
26 | #include <linux/mutex.h> | ||
26 | #include <asm/uaccess.h> | 27 | #include <asm/uaccess.h> |
27 | 28 | ||
28 | /* The dcookies are allocated from a kmem_cache and | 29 | /* The dcookies are allocated from a kmem_cache and |
@@ -36,10 +37,10 @@ struct dcookie_struct { | |||
36 | }; | 37 | }; |
37 | 38 | ||
38 | static LIST_HEAD(dcookie_users); | 39 | static LIST_HEAD(dcookie_users); |
39 | static DECLARE_MUTEX(dcookie_sem); | 40 | static DEFINE_MUTEX(dcookie_mutex); |
40 | static kmem_cache_t * dcookie_cache; | 41 | static kmem_cache_t *dcookie_cache __read_mostly; |
41 | static struct list_head * dcookie_hashtable; | 42 | static struct list_head *dcookie_hashtable __read_mostly; |
42 | static size_t hash_size; | 43 | static size_t hash_size __read_mostly; |
43 | 44 | ||
44 | static inline int is_live(void) | 45 | static inline int is_live(void) |
45 | { | 46 | { |
@@ -114,7 +115,7 @@ int get_dcookie(struct dentry * dentry, struct vfsmount * vfsmnt, | |||
114 | int err = 0; | 115 | int err = 0; |
115 | struct dcookie_struct * dcs; | 116 | struct dcookie_struct * dcs; |
116 | 117 | ||
117 | down(&dcookie_sem); | 118 | mutex_lock(&dcookie_mutex); |
118 | 119 | ||
119 | if (!is_live()) { | 120 | if (!is_live()) { |
120 | err = -EINVAL; | 121 | err = -EINVAL; |
@@ -134,7 +135,7 @@ int get_dcookie(struct dentry * dentry, struct vfsmount * vfsmnt, | |||
134 | *cookie = dcookie_value(dcs); | 135 | *cookie = dcookie_value(dcs); |
135 | 136 | ||
136 | out: | 137 | out: |
137 | up(&dcookie_sem); | 138 | mutex_unlock(&dcookie_mutex); |
138 | return err; | 139 | return err; |
139 | } | 140 | } |
140 | 141 | ||
@@ -157,7 +158,7 @@ asmlinkage long sys_lookup_dcookie(u64 cookie64, char __user * buf, size_t len) | |||
157 | if (!capable(CAP_SYS_ADMIN)) | 158 | if (!capable(CAP_SYS_ADMIN)) |
158 | return -EPERM; | 159 | return -EPERM; |
159 | 160 | ||
160 | down(&dcookie_sem); | 161 | mutex_lock(&dcookie_mutex); |
161 | 162 | ||
162 | if (!is_live()) { | 163 | if (!is_live()) { |
163 | err = -EINVAL; | 164 | err = -EINVAL; |
@@ -192,7 +193,7 @@ asmlinkage long sys_lookup_dcookie(u64 cookie64, char __user * buf, size_t len) | |||
192 | out_free: | 193 | out_free: |
193 | kfree(kbuf); | 194 | kfree(kbuf); |
194 | out: | 195 | out: |
195 | up(&dcookie_sem); | 196 | mutex_unlock(&dcookie_mutex); |
196 | return err; | 197 | return err; |
197 | } | 198 | } |
198 | 199 | ||
@@ -290,7 +291,7 @@ struct dcookie_user * dcookie_register(void) | |||
290 | { | 291 | { |
291 | struct dcookie_user * user; | 292 | struct dcookie_user * user; |
292 | 293 | ||
293 | down(&dcookie_sem); | 294 | mutex_lock(&dcookie_mutex); |
294 | 295 | ||
295 | user = kmalloc(sizeof(struct dcookie_user), GFP_KERNEL); | 296 | user = kmalloc(sizeof(struct dcookie_user), GFP_KERNEL); |
296 | if (!user) | 297 | if (!user) |
@@ -302,7 +303,7 @@ struct dcookie_user * dcookie_register(void) | |||
302 | list_add(&user->next, &dcookie_users); | 303 | list_add(&user->next, &dcookie_users); |
303 | 304 | ||
304 | out: | 305 | out: |
305 | up(&dcookie_sem); | 306 | mutex_unlock(&dcookie_mutex); |
306 | return user; | 307 | return user; |
307 | out_free: | 308 | out_free: |
308 | kfree(user); | 309 | kfree(user); |
@@ -313,7 +314,7 @@ out_free: | |||
313 | 314 | ||
314 | void dcookie_unregister(struct dcookie_user * user) | 315 | void dcookie_unregister(struct dcookie_user * user) |
315 | { | 316 | { |
316 | down(&dcookie_sem); | 317 | mutex_lock(&dcookie_mutex); |
317 | 318 | ||
318 | list_del(&user->next); | 319 | list_del(&user->next); |
319 | kfree(user); | 320 | kfree(user); |
@@ -321,7 +322,7 @@ void dcookie_unregister(struct dcookie_user * user) | |||
321 | if (!is_live()) | 322 | if (!is_live()) |
322 | dcookie_exit(); | 323 | dcookie_exit(); |
323 | 324 | ||
324 | up(&dcookie_sem); | 325 | mutex_unlock(&dcookie_mutex); |
325 | } | 326 | } |
326 | 327 | ||
327 | EXPORT_SYMBOL_GPL(dcookie_register); | 328 | EXPORT_SYMBOL_GPL(dcookie_register); |
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 40c4fc973fad..66a505422e5c 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c | |||
@@ -39,7 +39,7 @@ static int default_open(struct inode *inode, struct file *file) | |||
39 | return 0; | 39 | return 0; |
40 | } | 40 | } |
41 | 41 | ||
42 | struct file_operations debugfs_file_operations = { | 42 | const struct file_operations debugfs_file_operations = { |
43 | .read = default_read_file, | 43 | .read = default_read_file, |
44 | .write = default_write_file, | 44 | .write = default_write_file, |
45 | .open = default_open, | 45 | .open = default_open, |
@@ -213,7 +213,7 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf, | |||
213 | return count; | 213 | return count; |
214 | } | 214 | } |
215 | 215 | ||
216 | static struct file_operations fops_bool = { | 216 | static const struct file_operations fops_bool = { |
217 | .read = read_file_bool, | 217 | .read = read_file_bool, |
218 | .write = write_file_bool, | 218 | .write = write_file_bool, |
219 | .open = default_open, | 219 | .open = default_open, |
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index d4f1a2cddd47..85d166cdcae4 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -191,7 +191,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
191 | */ | 191 | */ |
192 | struct dentry *debugfs_create_file(const char *name, mode_t mode, | 192 | struct dentry *debugfs_create_file(const char *name, mode_t mode, |
193 | struct dentry *parent, void *data, | 193 | struct dentry *parent, void *data, |
194 | struct file_operations *fops) | 194 | const struct file_operations *fops) |
195 | { | 195 | { |
196 | struct dentry *dentry = NULL; | 196 | struct dentry *dentry = NULL; |
197 | int error; | 197 | int error; |
diff --git a/fs/devfs/base.c b/fs/devfs/base.c index b621521e09d4..52f5059c4f31 100644 --- a/fs/devfs/base.c +++ b/fs/devfs/base.c | |||
@@ -856,14 +856,14 @@ static int devfsd_close(struct inode *inode, struct file *file); | |||
856 | #ifdef CONFIG_DEVFS_DEBUG | 856 | #ifdef CONFIG_DEVFS_DEBUG |
857 | static ssize_t stat_read(struct file *file, char __user *buf, size_t len, | 857 | static ssize_t stat_read(struct file *file, char __user *buf, size_t len, |
858 | loff_t * ppos); | 858 | loff_t * ppos); |
859 | static struct file_operations stat_fops = { | 859 | static const struct file_operations stat_fops = { |
860 | .open = nonseekable_open, | 860 | .open = nonseekable_open, |
861 | .read = stat_read, | 861 | .read = stat_read, |
862 | }; | 862 | }; |
863 | #endif | 863 | #endif |
864 | 864 | ||
865 | /* Devfs daemon file operations */ | 865 | /* Devfs daemon file operations */ |
866 | static struct file_operations devfsd_fops = { | 866 | static const struct file_operations devfsd_fops = { |
867 | .open = nonseekable_open, | 867 | .open = nonseekable_open, |
868 | .read = devfsd_read, | 868 | .read = devfsd_read, |
869 | .ioctl = devfsd_ioctl, | 869 | .ioctl = devfsd_ioctl, |
@@ -1842,8 +1842,8 @@ static int try_modload(struct devfs_entry *parent, struct fs_info *fs_info, | |||
1842 | 1842 | ||
1843 | static struct inode_operations devfs_iops; | 1843 | static struct inode_operations devfs_iops; |
1844 | static struct inode_operations devfs_dir_iops; | 1844 | static struct inode_operations devfs_dir_iops; |
1845 | static struct file_operations devfs_fops; | 1845 | static const struct file_operations devfs_fops; |
1846 | static struct file_operations devfs_dir_fops; | 1846 | static const struct file_operations devfs_dir_fops; |
1847 | static struct inode_operations devfs_symlink_iops; | 1847 | static struct inode_operations devfs_symlink_iops; |
1848 | 1848 | ||
1849 | static int devfs_notify_change(struct dentry *dentry, struct iattr *iattr) | 1849 | static int devfs_notify_change(struct dentry *dentry, struct iattr *iattr) |
@@ -2061,11 +2061,11 @@ static int devfs_open(struct inode *inode, struct file *file) | |||
2061 | return err; | 2061 | return err; |
2062 | } /* End Function devfs_open */ | 2062 | } /* End Function devfs_open */ |
2063 | 2063 | ||
2064 | static struct file_operations devfs_fops = { | 2064 | static const struct file_operations devfs_fops = { |
2065 | .open = devfs_open, | 2065 | .open = devfs_open, |
2066 | }; | 2066 | }; |
2067 | 2067 | ||
2068 | static struct file_operations devfs_dir_fops = { | 2068 | static const struct file_operations devfs_dir_fops = { |
2069 | .read = generic_read_dir, | 2069 | .read = generic_read_dir, |
2070 | .readdir = devfs_readdir, | 2070 | .readdir = devfs_readdir, |
2071 | }; | 2071 | }; |
diff --git a/fs/direct-io.c b/fs/direct-io.c index 235ed8d1f11e..9d1d2aa73e42 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c | |||
@@ -86,12 +86,12 @@ struct dio { | |||
86 | unsigned first_block_in_page; /* doesn't change, Used only once */ | 86 | unsigned first_block_in_page; /* doesn't change, Used only once */ |
87 | int boundary; /* prev block is at a boundary */ | 87 | int boundary; /* prev block is at a boundary */ |
88 | int reap_counter; /* rate limit reaping */ | 88 | int reap_counter; /* rate limit reaping */ |
89 | get_blocks_t *get_blocks; /* block mapping function */ | 89 | get_block_t *get_block; /* block mapping function */ |
90 | dio_iodone_t *end_io; /* IO completion function */ | 90 | dio_iodone_t *end_io; /* IO completion function */ |
91 | sector_t final_block_in_bio; /* current final block in bio + 1 */ | 91 | sector_t final_block_in_bio; /* current final block in bio + 1 */ |
92 | sector_t next_block_for_io; /* next block to be put under IO, | 92 | sector_t next_block_for_io; /* next block to be put under IO, |
93 | in dio_blocks units */ | 93 | in dio_blocks units */ |
94 | struct buffer_head map_bh; /* last get_blocks() result */ | 94 | struct buffer_head map_bh; /* last get_block() result */ |
95 | 95 | ||
96 | /* | 96 | /* |
97 | * Deferred addition of a page to the dio. These variables are | 97 | * Deferred addition of a page to the dio. These variables are |
@@ -211,9 +211,9 @@ static struct page *dio_get_page(struct dio *dio) | |||
211 | 211 | ||
212 | /* | 212 | /* |
213 | * Called when all DIO BIO I/O has been completed - let the filesystem | 213 | * Called when all DIO BIO I/O has been completed - let the filesystem |
214 | * know, if it registered an interest earlier via get_blocks. Pass the | 214 | * know, if it registered an interest earlier via get_block. Pass the |
215 | * private field of the map buffer_head so that filesystems can use it | 215 | * private field of the map buffer_head so that filesystems can use it |
216 | * to hold additional state between get_blocks calls and dio_complete. | 216 | * to hold additional state between get_block calls and dio_complete. |
217 | */ | 217 | */ |
218 | static void dio_complete(struct dio *dio, loff_t offset, ssize_t bytes) | 218 | static void dio_complete(struct dio *dio, loff_t offset, ssize_t bytes) |
219 | { | 219 | { |
@@ -493,7 +493,7 @@ static int dio_bio_reap(struct dio *dio) | |||
493 | * The fs is allowed to map lots of blocks at once. If it wants to do that, | 493 | * The fs is allowed to map lots of blocks at once. If it wants to do that, |
494 | * it uses the passed inode-relative block number as the file offset, as usual. | 494 | * it uses the passed inode-relative block number as the file offset, as usual. |
495 | * | 495 | * |
496 | * get_blocks() is passed the number of i_blkbits-sized blocks which direct_io | 496 | * get_block() is passed the number of i_blkbits-sized blocks which direct_io |
497 | * has remaining to do. The fs should not map more than this number of blocks. | 497 | * has remaining to do. The fs should not map more than this number of blocks. |
498 | * | 498 | * |
499 | * If the fs has mapped a lot of blocks, it should populate bh->b_size to | 499 | * If the fs has mapped a lot of blocks, it should populate bh->b_size to |
@@ -506,7 +506,7 @@ static int dio_bio_reap(struct dio *dio) | |||
506 | * In the case of filesystem holes: the fs may return an arbitrarily-large | 506 | * In the case of filesystem holes: the fs may return an arbitrarily-large |
507 | * hole by returning an appropriate value in b_size and by clearing | 507 | * hole by returning an appropriate value in b_size and by clearing |
508 | * buffer_mapped(). However the direct-io code will only process holes one | 508 | * buffer_mapped(). However the direct-io code will only process holes one |
509 | * block at a time - it will repeatedly call get_blocks() as it walks the hole. | 509 | * block at a time - it will repeatedly call get_block() as it walks the hole. |
510 | */ | 510 | */ |
511 | static int get_more_blocks(struct dio *dio) | 511 | static int get_more_blocks(struct dio *dio) |
512 | { | 512 | { |
@@ -548,7 +548,8 @@ static int get_more_blocks(struct dio *dio) | |||
548 | * at a higher level for inside-i_size block-instantiating | 548 | * at a higher level for inside-i_size block-instantiating |
549 | * writes. | 549 | * writes. |
550 | */ | 550 | */ |
551 | ret = (*dio->get_blocks)(dio->inode, fs_startblk, fs_count, | 551 | map_bh->b_size = fs_count << dio->blkbits; |
552 | ret = (*dio->get_block)(dio->inode, fs_startblk, | ||
552 | map_bh, create); | 553 | map_bh, create); |
553 | } | 554 | } |
554 | return ret; | 555 | return ret; |
@@ -783,11 +784,11 @@ static void dio_zero_block(struct dio *dio, int end) | |||
783 | * happily perform page-sized but 512-byte aligned IOs. It is important that | 784 | * happily perform page-sized but 512-byte aligned IOs. It is important that |
784 | * blockdev IO be able to have fine alignment and large sizes. | 785 | * blockdev IO be able to have fine alignment and large sizes. |
785 | * | 786 | * |
786 | * So what we do is to permit the ->get_blocks function to populate bh.b_size | 787 | * So what we do is to permit the ->get_block function to populate bh.b_size |
787 | * with the size of IO which is permitted at this offset and this i_blkbits. | 788 | * with the size of IO which is permitted at this offset and this i_blkbits. |
788 | * | 789 | * |
789 | * For best results, the blockdev should be set up with 512-byte i_blkbits and | 790 | * For best results, the blockdev should be set up with 512-byte i_blkbits and |
790 | * it should set b_size to PAGE_SIZE or more inside get_blocks(). This gives | 791 | * it should set b_size to PAGE_SIZE or more inside get_block(). This gives |
791 | * fine alignment but still allows this function to work in PAGE_SIZE units. | 792 | * fine alignment but still allows this function to work in PAGE_SIZE units. |
792 | */ | 793 | */ |
793 | static int do_direct_IO(struct dio *dio) | 794 | static int do_direct_IO(struct dio *dio) |
@@ -947,7 +948,7 @@ out: | |||
947 | static ssize_t | 948 | static ssize_t |
948 | direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, | 949 | direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, |
949 | const struct iovec *iov, loff_t offset, unsigned long nr_segs, | 950 | const struct iovec *iov, loff_t offset, unsigned long nr_segs, |
950 | unsigned blkbits, get_blocks_t get_blocks, dio_iodone_t end_io, | 951 | unsigned blkbits, get_block_t get_block, dio_iodone_t end_io, |
951 | struct dio *dio) | 952 | struct dio *dio) |
952 | { | 953 | { |
953 | unsigned long user_addr; | 954 | unsigned long user_addr; |
@@ -969,7 +970,7 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, | |||
969 | 970 | ||
970 | dio->boundary = 0; | 971 | dio->boundary = 0; |
971 | dio->reap_counter = 0; | 972 | dio->reap_counter = 0; |
972 | dio->get_blocks = get_blocks; | 973 | dio->get_block = get_block; |
973 | dio->end_io = end_io; | 974 | dio->end_io = end_io; |
974 | dio->map_bh.b_private = NULL; | 975 | dio->map_bh.b_private = NULL; |
975 | dio->final_block_in_bio = -1; | 976 | dio->final_block_in_bio = -1; |
@@ -1177,7 +1178,7 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, | |||
1177 | ssize_t | 1178 | ssize_t |
1178 | __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, | 1179 | __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, |
1179 | struct block_device *bdev, const struct iovec *iov, loff_t offset, | 1180 | struct block_device *bdev, const struct iovec *iov, loff_t offset, |
1180 | unsigned long nr_segs, get_blocks_t get_blocks, dio_iodone_t end_io, | 1181 | unsigned long nr_segs, get_block_t get_block, dio_iodone_t end_io, |
1181 | int dio_lock_type) | 1182 | int dio_lock_type) |
1182 | { | 1183 | { |
1183 | int seg; | 1184 | int seg; |
@@ -1273,7 +1274,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, | |||
1273 | (end > i_size_read(inode))); | 1274 | (end > i_size_read(inode))); |
1274 | 1275 | ||
1275 | retval = direct_io_worker(rw, iocb, inode, iov, offset, | 1276 | retval = direct_io_worker(rw, iocb, inode, iov, offset, |
1276 | nr_segs, blkbits, get_blocks, end_io, dio); | 1277 | nr_segs, blkbits, get_block, end_io, dio); |
1277 | 1278 | ||
1278 | if (rw == READ && dio_lock_type == DIO_LOCKING) | 1279 | if (rw == READ && dio_lock_type == DIO_LOCKING) |
1279 | release_i_mutex = 0; | 1280 | release_i_mutex = 0; |
diff --git a/fs/dnotify.c b/fs/dnotify.c index f3b540dd5d11..f932591df5a4 100644 --- a/fs/dnotify.c +++ b/fs/dnotify.c | |||
@@ -21,9 +21,9 @@ | |||
21 | #include <linux/spinlock.h> | 21 | #include <linux/spinlock.h> |
22 | #include <linux/slab.h> | 22 | #include <linux/slab.h> |
23 | 23 | ||
24 | int dir_notify_enable = 1; | 24 | int dir_notify_enable __read_mostly = 1; |
25 | 25 | ||
26 | static kmem_cache_t *dn_cache; | 26 | static kmem_cache_t *dn_cache __read_mostly; |
27 | 27 | ||
28 | static void redo_inode_mask(struct inode *inode) | 28 | static void redo_inode_mask(struct inode *inode) |
29 | { | 29 | { |
diff --git a/fs/efs/dir.c b/fs/efs/dir.c index 777c614ff360..17f5b2d3c16a 100644 --- a/fs/efs/dir.c +++ b/fs/efs/dir.c | |||
@@ -10,7 +10,7 @@ | |||
10 | 10 | ||
11 | static int efs_readdir(struct file *, void *, filldir_t); | 11 | static int efs_readdir(struct file *, void *, filldir_t); |
12 | 12 | ||
13 | struct file_operations efs_dir_operations = { | 13 | const struct file_operations efs_dir_operations = { |
14 | .read = generic_read_dir, | 14 | .read = generic_read_dir, |
15 | .readdir = efs_readdir, | 15 | .readdir = efs_readdir, |
16 | }; | 16 | }; |
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index a0f682cdd03e..242fe1a66ce5 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c | |||
@@ -281,16 +281,16 @@ static struct mutex epmutex; | |||
281 | static struct poll_safewake psw; | 281 | static struct poll_safewake psw; |
282 | 282 | ||
283 | /* Slab cache used to allocate "struct epitem" */ | 283 | /* Slab cache used to allocate "struct epitem" */ |
284 | static kmem_cache_t *epi_cache; | 284 | static kmem_cache_t *epi_cache __read_mostly; |
285 | 285 | ||
286 | /* Slab cache used to allocate "struct eppoll_entry" */ | 286 | /* Slab cache used to allocate "struct eppoll_entry" */ |
287 | static kmem_cache_t *pwq_cache; | 287 | static kmem_cache_t *pwq_cache __read_mostly; |
288 | 288 | ||
289 | /* Virtual fs used to allocate inodes for eventpoll files */ | 289 | /* Virtual fs used to allocate inodes for eventpoll files */ |
290 | static struct vfsmount *eventpoll_mnt; | 290 | static struct vfsmount *eventpoll_mnt __read_mostly; |
291 | 291 | ||
292 | /* File callbacks that implement the eventpoll file behaviour */ | 292 | /* File callbacks that implement the eventpoll file behaviour */ |
293 | static struct file_operations eventpoll_fops = { | 293 | static const struct file_operations eventpoll_fops = { |
294 | .release = ep_eventpoll_close, | 294 | .release = ep_eventpoll_close, |
295 | .poll = ep_eventpoll_poll | 295 | .poll = ep_eventpoll_poll |
296 | }; | 296 | }; |
@@ -632,7 +632,7 @@ static int de_thread(struct task_struct *tsk) | |||
632 | * synchronize with any firing (by calling del_timer_sync) | 632 | * synchronize with any firing (by calling del_timer_sync) |
633 | * before we can safely let the old group leader die. | 633 | * before we can safely let the old group leader die. |
634 | */ | 634 | */ |
635 | sig->real_timer.data = current; | 635 | sig->tsk = current; |
636 | spin_unlock_irq(lock); | 636 | spin_unlock_irq(lock); |
637 | if (hrtimer_cancel(&sig->real_timer)) | 637 | if (hrtimer_cancel(&sig->real_timer)) |
638 | hrtimer_restart(&sig->real_timer); | 638 | hrtimer_restart(&sig->real_timer); |
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index b3dbd716cd3a..d672aa9f4061 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c | |||
@@ -416,8 +416,7 @@ void ext2_set_link(struct inode *dir, struct ext2_dir_entry_2 *de, | |||
416 | 416 | ||
417 | lock_page(page); | 417 | lock_page(page); |
418 | err = page->mapping->a_ops->prepare_write(NULL, page, from, to); | 418 | err = page->mapping->a_ops->prepare_write(NULL, page, from, to); |
419 | if (err) | 419 | BUG_ON(err); |
420 | BUG(); | ||
421 | de->inode = cpu_to_le32(inode->i_ino); | 420 | de->inode = cpu_to_le32(inode->i_ino); |
422 | ext2_set_de_type (de, inode); | 421 | ext2_set_de_type (de, inode); |
423 | err = ext2_commit_chunk(page, from, to); | 422 | err = ext2_commit_chunk(page, from, to); |
@@ -554,8 +553,7 @@ int ext2_delete_entry (struct ext2_dir_entry_2 * dir, struct page * page ) | |||
554 | from = (char*)pde - (char*)page_address(page); | 553 | from = (char*)pde - (char*)page_address(page); |
555 | lock_page(page); | 554 | lock_page(page); |
556 | err = mapping->a_ops->prepare_write(NULL, page, from, to); | 555 | err = mapping->a_ops->prepare_write(NULL, page, from, to); |
557 | if (err) | 556 | BUG_ON(err); |
558 | BUG(); | ||
559 | if (pde) | 557 | if (pde) |
560 | pde->rec_len = cpu_to_le16(to-from); | 558 | pde->rec_len = cpu_to_le16(to-from); |
561 | dir->inode = 0; | 559 | dir->inode = 0; |
@@ -660,7 +658,7 @@ not_empty: | |||
660 | return 0; | 658 | return 0; |
661 | } | 659 | } |
662 | 660 | ||
663 | struct file_operations ext2_dir_operations = { | 661 | const struct file_operations ext2_dir_operations = { |
664 | .llseek = generic_file_llseek, | 662 | .llseek = generic_file_llseek, |
665 | .read = generic_read_dir, | 663 | .read = generic_read_dir, |
666 | .readdir = ext2_readdir, | 664 | .readdir = ext2_readdir, |
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h index 11035ac7986f..9f74a62be555 100644 --- a/fs/ext2/ext2.h +++ b/fs/ext2/ext2.h | |||
@@ -154,12 +154,12 @@ extern void ext2_write_super (struct super_block *); | |||
154 | */ | 154 | */ |
155 | 155 | ||
156 | /* dir.c */ | 156 | /* dir.c */ |
157 | extern struct file_operations ext2_dir_operations; | 157 | extern const struct file_operations ext2_dir_operations; |
158 | 158 | ||
159 | /* file.c */ | 159 | /* file.c */ |
160 | extern struct inode_operations ext2_file_inode_operations; | 160 | extern struct inode_operations ext2_file_inode_operations; |
161 | extern struct file_operations ext2_file_operations; | 161 | extern const struct file_operations ext2_file_operations; |
162 | extern struct file_operations ext2_xip_file_operations; | 162 | extern const struct file_operations ext2_xip_file_operations; |
163 | 163 | ||
164 | /* inode.c */ | 164 | /* inode.c */ |
165 | extern struct address_space_operations ext2_aops; | 165 | extern struct address_space_operations ext2_aops; |
diff --git a/fs/ext2/file.c b/fs/ext2/file.c index a484412fc782..509cceca04db 100644 --- a/fs/ext2/file.c +++ b/fs/ext2/file.c | |||
@@ -39,7 +39,7 @@ static int ext2_release_file (struct inode * inode, struct file * filp) | |||
39 | * We have mostly NULL's here: the current defaults are ok for | 39 | * We have mostly NULL's here: the current defaults are ok for |
40 | * the ext2 filesystem. | 40 | * the ext2 filesystem. |
41 | */ | 41 | */ |
42 | struct file_operations ext2_file_operations = { | 42 | const struct file_operations ext2_file_operations = { |
43 | .llseek = generic_file_llseek, | 43 | .llseek = generic_file_llseek, |
44 | .read = generic_file_read, | 44 | .read = generic_file_read, |
45 | .write = generic_file_write, | 45 | .write = generic_file_write, |
@@ -56,7 +56,7 @@ struct file_operations ext2_file_operations = { | |||
56 | }; | 56 | }; |
57 | 57 | ||
58 | #ifdef CONFIG_EXT2_FS_XIP | 58 | #ifdef CONFIG_EXT2_FS_XIP |
59 | struct file_operations ext2_xip_file_operations = { | 59 | const struct file_operations ext2_xip_file_operations = { |
60 | .llseek = generic_file_llseek, | 60 | .llseek = generic_file_llseek, |
61 | .read = xip_file_read, | 61 | .read = xip_file_read, |
62 | .write = xip_file_write, | 62 | .write = xip_file_write, |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index a717837f272e..04af9c45dce2 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
@@ -667,18 +667,6 @@ static sector_t ext2_bmap(struct address_space *mapping, sector_t block) | |||
667 | return generic_block_bmap(mapping,block,ext2_get_block); | 667 | return generic_block_bmap(mapping,block,ext2_get_block); |
668 | } | 668 | } |
669 | 669 | ||
670 | static int | ||
671 | ext2_get_blocks(struct inode *inode, sector_t iblock, unsigned long max_blocks, | ||
672 | struct buffer_head *bh_result, int create) | ||
673 | { | ||
674 | int ret; | ||
675 | |||
676 | ret = ext2_get_block(inode, iblock, bh_result, create); | ||
677 | if (ret == 0) | ||
678 | bh_result->b_size = (1 << inode->i_blkbits); | ||
679 | return ret; | ||
680 | } | ||
681 | |||
682 | static ssize_t | 670 | static ssize_t |
683 | ext2_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, | 671 | ext2_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, |
684 | loff_t offset, unsigned long nr_segs) | 672 | loff_t offset, unsigned long nr_segs) |
@@ -687,7 +675,7 @@ ext2_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, | |||
687 | struct inode *inode = file->f_mapping->host; | 675 | struct inode *inode = file->f_mapping->host; |
688 | 676 | ||
689 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 677 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
690 | offset, nr_segs, ext2_get_blocks, NULL); | 678 | offset, nr_segs, ext2_get_block, NULL); |
691 | } | 679 | } |
692 | 680 | ||
693 | static int | 681 | static int |
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 46623f77666b..77927d6938f6 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c | |||
@@ -653,9 +653,11 @@ claim_block(spinlock_t *lock, int block, struct buffer_head *bh) | |||
653 | */ | 653 | */ |
654 | static int | 654 | static int |
655 | ext3_try_to_allocate(struct super_block *sb, handle_t *handle, int group, | 655 | ext3_try_to_allocate(struct super_block *sb, handle_t *handle, int group, |
656 | struct buffer_head *bitmap_bh, int goal, struct ext3_reserve_window *my_rsv) | 656 | struct buffer_head *bitmap_bh, int goal, |
657 | unsigned long *count, struct ext3_reserve_window *my_rsv) | ||
657 | { | 658 | { |
658 | int group_first_block, start, end; | 659 | int group_first_block, start, end; |
660 | unsigned long num = 0; | ||
659 | 661 | ||
660 | /* we do allocation within the reservation window if we have a window */ | 662 | /* we do allocation within the reservation window if we have a window */ |
661 | if (my_rsv) { | 663 | if (my_rsv) { |
@@ -713,8 +715,18 @@ repeat: | |||
713 | goto fail_access; | 715 | goto fail_access; |
714 | goto repeat; | 716 | goto repeat; |
715 | } | 717 | } |
716 | return goal; | 718 | num++; |
719 | goal++; | ||
720 | while (num < *count && goal < end | ||
721 | && ext3_test_allocatable(goal, bitmap_bh) | ||
722 | && claim_block(sb_bgl_lock(EXT3_SB(sb), group), goal, bitmap_bh)) { | ||
723 | num++; | ||
724 | goal++; | ||
725 | } | ||
726 | *count = num; | ||
727 | return goal - num; | ||
717 | fail_access: | 728 | fail_access: |
729 | *count = num; | ||
718 | return -1; | 730 | return -1; |
719 | } | 731 | } |
720 | 732 | ||
@@ -999,6 +1011,31 @@ retry: | |||
999 | goto retry; | 1011 | goto retry; |
1000 | } | 1012 | } |
1001 | 1013 | ||
1014 | static void try_to_extend_reservation(struct ext3_reserve_window_node *my_rsv, | ||
1015 | struct super_block *sb, int size) | ||
1016 | { | ||
1017 | struct ext3_reserve_window_node *next_rsv; | ||
1018 | struct rb_node *next; | ||
1019 | spinlock_t *rsv_lock = &EXT3_SB(sb)->s_rsv_window_lock; | ||
1020 | |||
1021 | if (!spin_trylock(rsv_lock)) | ||
1022 | return; | ||
1023 | |||
1024 | next = rb_next(&my_rsv->rsv_node); | ||
1025 | |||
1026 | if (!next) | ||
1027 | my_rsv->rsv_end += size; | ||
1028 | else { | ||
1029 | next_rsv = list_entry(next, struct ext3_reserve_window_node, rsv_node); | ||
1030 | |||
1031 | if ((next_rsv->rsv_start - my_rsv->rsv_end - 1) >= size) | ||
1032 | my_rsv->rsv_end += size; | ||
1033 | else | ||
1034 | my_rsv->rsv_end = next_rsv->rsv_start - 1; | ||
1035 | } | ||
1036 | spin_unlock(rsv_lock); | ||
1037 | } | ||
1038 | |||
1002 | /* | 1039 | /* |
1003 | * This is the main function used to allocate a new block and its reservation | 1040 | * This is the main function used to allocate a new block and its reservation |
1004 | * window. | 1041 | * window. |
@@ -1024,11 +1061,12 @@ static int | |||
1024 | ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle, | 1061 | ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle, |
1025 | unsigned int group, struct buffer_head *bitmap_bh, | 1062 | unsigned int group, struct buffer_head *bitmap_bh, |
1026 | int goal, struct ext3_reserve_window_node * my_rsv, | 1063 | int goal, struct ext3_reserve_window_node * my_rsv, |
1027 | int *errp) | 1064 | unsigned long *count, int *errp) |
1028 | { | 1065 | { |
1029 | unsigned long group_first_block; | 1066 | unsigned long group_first_block; |
1030 | int ret = 0; | 1067 | int ret = 0; |
1031 | int fatal; | 1068 | int fatal; |
1069 | unsigned long num = *count; | ||
1032 | 1070 | ||
1033 | *errp = 0; | 1071 | *errp = 0; |
1034 | 1072 | ||
@@ -1051,7 +1089,8 @@ ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle, | |||
1051 | * or last attempt to allocate a block with reservation turned on failed | 1089 | * or last attempt to allocate a block with reservation turned on failed |
1052 | */ | 1090 | */ |
1053 | if (my_rsv == NULL ) { | 1091 | if (my_rsv == NULL ) { |
1054 | ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, goal, NULL); | 1092 | ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, |
1093 | goal, count, NULL); | ||
1055 | goto out; | 1094 | goto out; |
1056 | } | 1095 | } |
1057 | /* | 1096 | /* |
@@ -1081,6 +1120,8 @@ ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle, | |||
1081 | while (1) { | 1120 | while (1) { |
1082 | if (rsv_is_empty(&my_rsv->rsv_window) || (ret < 0) || | 1121 | if (rsv_is_empty(&my_rsv->rsv_window) || (ret < 0) || |
1083 | !goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb)) { | 1122 | !goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb)) { |
1123 | if (my_rsv->rsv_goal_size < *count) | ||
1124 | my_rsv->rsv_goal_size = *count; | ||
1084 | ret = alloc_new_reservation(my_rsv, goal, sb, | 1125 | ret = alloc_new_reservation(my_rsv, goal, sb, |
1085 | group, bitmap_bh); | 1126 | group, bitmap_bh); |
1086 | if (ret < 0) | 1127 | if (ret < 0) |
@@ -1088,16 +1129,21 @@ ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle, | |||
1088 | 1129 | ||
1089 | if (!goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb)) | 1130 | if (!goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb)) |
1090 | goal = -1; | 1131 | goal = -1; |
1091 | } | 1132 | } else if (goal > 0 && (my_rsv->rsv_end-goal+1) < *count) |
1133 | try_to_extend_reservation(my_rsv, sb, | ||
1134 | *count-my_rsv->rsv_end + goal - 1); | ||
1135 | |||
1092 | if ((my_rsv->rsv_start >= group_first_block + EXT3_BLOCKS_PER_GROUP(sb)) | 1136 | if ((my_rsv->rsv_start >= group_first_block + EXT3_BLOCKS_PER_GROUP(sb)) |
1093 | || (my_rsv->rsv_end < group_first_block)) | 1137 | || (my_rsv->rsv_end < group_first_block)) |
1094 | BUG(); | 1138 | BUG(); |
1095 | ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, goal, | 1139 | ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, goal, |
1096 | &my_rsv->rsv_window); | 1140 | &num, &my_rsv->rsv_window); |
1097 | if (ret >= 0) { | 1141 | if (ret >= 0) { |
1098 | my_rsv->rsv_alloc_hit++; | 1142 | my_rsv->rsv_alloc_hit += num; |
1143 | *count = num; | ||
1099 | break; /* succeed */ | 1144 | break; /* succeed */ |
1100 | } | 1145 | } |
1146 | num = *count; | ||
1101 | } | 1147 | } |
1102 | out: | 1148 | out: |
1103 | if (ret >= 0) { | 1149 | if (ret >= 0) { |
@@ -1154,8 +1200,8 @@ int ext3_should_retry_alloc(struct super_block *sb, int *retries) | |||
1154 | * bitmap, and then for any free bit if that fails. | 1200 | * bitmap, and then for any free bit if that fails. |
1155 | * This function also updates quota and i_blocks field. | 1201 | * This function also updates quota and i_blocks field. |
1156 | */ | 1202 | */ |
1157 | int ext3_new_block(handle_t *handle, struct inode *inode, | 1203 | int ext3_new_blocks(handle_t *handle, struct inode *inode, |
1158 | unsigned long goal, int *errp) | 1204 | unsigned long goal, unsigned long *count, int *errp) |
1159 | { | 1205 | { |
1160 | struct buffer_head *bitmap_bh = NULL; | 1206 | struct buffer_head *bitmap_bh = NULL; |
1161 | struct buffer_head *gdp_bh; | 1207 | struct buffer_head *gdp_bh; |
@@ -1178,6 +1224,7 @@ int ext3_new_block(handle_t *handle, struct inode *inode, | |||
1178 | static int goal_hits, goal_attempts; | 1224 | static int goal_hits, goal_attempts; |
1179 | #endif | 1225 | #endif |
1180 | unsigned long ngroups; | 1226 | unsigned long ngroups; |
1227 | unsigned long num = *count; | ||
1181 | 1228 | ||
1182 | *errp = -ENOSPC; | 1229 | *errp = -ENOSPC; |
1183 | sb = inode->i_sb; | 1230 | sb = inode->i_sb; |
@@ -1189,7 +1236,7 @@ int ext3_new_block(handle_t *handle, struct inode *inode, | |||
1189 | /* | 1236 | /* |
1190 | * Check quota for allocation of this block. | 1237 | * Check quota for allocation of this block. |
1191 | */ | 1238 | */ |
1192 | if (DQUOT_ALLOC_BLOCK(inode, 1)) { | 1239 | if (DQUOT_ALLOC_BLOCK(inode, num)) { |
1193 | *errp = -EDQUOT; | 1240 | *errp = -EDQUOT; |
1194 | return 0; | 1241 | return 0; |
1195 | } | 1242 | } |
@@ -1244,7 +1291,7 @@ retry: | |||
1244 | if (!bitmap_bh) | 1291 | if (!bitmap_bh) |
1245 | goto io_error; | 1292 | goto io_error; |
1246 | ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no, | 1293 | ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no, |
1247 | bitmap_bh, ret_block, my_rsv, &fatal); | 1294 | bitmap_bh, ret_block, my_rsv, &num, &fatal); |
1248 | if (fatal) | 1295 | if (fatal) |
1249 | goto out; | 1296 | goto out; |
1250 | if (ret_block >= 0) | 1297 | if (ret_block >= 0) |
@@ -1281,7 +1328,7 @@ retry: | |||
1281 | if (!bitmap_bh) | 1328 | if (!bitmap_bh) |
1282 | goto io_error; | 1329 | goto io_error; |
1283 | ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no, | 1330 | ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no, |
1284 | bitmap_bh, -1, my_rsv, &fatal); | 1331 | bitmap_bh, -1, my_rsv, &num, &fatal); |
1285 | if (fatal) | 1332 | if (fatal) |
1286 | goto out; | 1333 | goto out; |
1287 | if (ret_block >= 0) | 1334 | if (ret_block >= 0) |
@@ -1316,13 +1363,15 @@ allocated: | |||
1316 | target_block = ret_block + group_no * EXT3_BLOCKS_PER_GROUP(sb) | 1363 | target_block = ret_block + group_no * EXT3_BLOCKS_PER_GROUP(sb) |
1317 | + le32_to_cpu(es->s_first_data_block); | 1364 | + le32_to_cpu(es->s_first_data_block); |
1318 | 1365 | ||
1319 | if (target_block == le32_to_cpu(gdp->bg_block_bitmap) || | 1366 | if (in_range(le32_to_cpu(gdp->bg_block_bitmap), target_block, num) || |
1320 | target_block == le32_to_cpu(gdp->bg_inode_bitmap) || | 1367 | in_range(le32_to_cpu(gdp->bg_inode_bitmap), target_block, num) || |
1321 | in_range(target_block, le32_to_cpu(gdp->bg_inode_table), | 1368 | in_range(target_block, le32_to_cpu(gdp->bg_inode_table), |
1369 | EXT3_SB(sb)->s_itb_per_group) || | ||
1370 | in_range(target_block + num - 1, le32_to_cpu(gdp->bg_inode_table), | ||
1322 | EXT3_SB(sb)->s_itb_per_group)) | 1371 | EXT3_SB(sb)->s_itb_per_group)) |
1323 | ext3_error(sb, "ext3_new_block", | 1372 | ext3_error(sb, "ext3_new_block", |
1324 | "Allocating block in system zone - " | 1373 | "Allocating block in system zone - " |
1325 | "block = %u", target_block); | 1374 | "blocks from %u, length %lu", target_block, num); |
1326 | 1375 | ||
1327 | performed_allocation = 1; | 1376 | performed_allocation = 1; |
1328 | 1377 | ||
@@ -1341,10 +1390,14 @@ allocated: | |||
1341 | jbd_lock_bh_state(bitmap_bh); | 1390 | jbd_lock_bh_state(bitmap_bh); |
1342 | spin_lock(sb_bgl_lock(sbi, group_no)); | 1391 | spin_lock(sb_bgl_lock(sbi, group_no)); |
1343 | if (buffer_jbd(bitmap_bh) && bh2jh(bitmap_bh)->b_committed_data) { | 1392 | if (buffer_jbd(bitmap_bh) && bh2jh(bitmap_bh)->b_committed_data) { |
1344 | if (ext3_test_bit(ret_block, | 1393 | int i; |
1345 | bh2jh(bitmap_bh)->b_committed_data)) { | 1394 | |
1346 | printk("%s: block was unexpectedly set in " | 1395 | for (i = 0; i < num; i++) { |
1347 | "b_committed_data\n", __FUNCTION__); | 1396 | if (ext3_test_bit(ret_block, |
1397 | bh2jh(bitmap_bh)->b_committed_data)) { | ||
1398 | printk("%s: block was unexpectedly set in " | ||
1399 | "b_committed_data\n", __FUNCTION__); | ||
1400 | } | ||
1348 | } | 1401 | } |
1349 | } | 1402 | } |
1350 | ext3_debug("found bit %d\n", ret_block); | 1403 | ext3_debug("found bit %d\n", ret_block); |
@@ -1355,7 +1408,7 @@ allocated: | |||
1355 | /* ret_block was blockgroup-relative. Now it becomes fs-relative */ | 1408 | /* ret_block was blockgroup-relative. Now it becomes fs-relative */ |
1356 | ret_block = target_block; | 1409 | ret_block = target_block; |
1357 | 1410 | ||
1358 | if (ret_block >= le32_to_cpu(es->s_blocks_count)) { | 1411 | if (ret_block + num - 1 >= le32_to_cpu(es->s_blocks_count)) { |
1359 | ext3_error(sb, "ext3_new_block", | 1412 | ext3_error(sb, "ext3_new_block", |
1360 | "block(%d) >= blocks count(%d) - " | 1413 | "block(%d) >= blocks count(%d) - " |
1361 | "block_group = %d, es == %p ", ret_block, | 1414 | "block_group = %d, es == %p ", ret_block, |
@@ -1373,9 +1426,9 @@ allocated: | |||
1373 | 1426 | ||
1374 | spin_lock(sb_bgl_lock(sbi, group_no)); | 1427 | spin_lock(sb_bgl_lock(sbi, group_no)); |
1375 | gdp->bg_free_blocks_count = | 1428 | gdp->bg_free_blocks_count = |
1376 | cpu_to_le16(le16_to_cpu(gdp->bg_free_blocks_count) - 1); | 1429 | cpu_to_le16(le16_to_cpu(gdp->bg_free_blocks_count) - num); |
1377 | spin_unlock(sb_bgl_lock(sbi, group_no)); | 1430 | spin_unlock(sb_bgl_lock(sbi, group_no)); |
1378 | percpu_counter_mod(&sbi->s_freeblocks_counter, -1); | 1431 | percpu_counter_mod(&sbi->s_freeblocks_counter, -num); |
1379 | 1432 | ||
1380 | BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor"); | 1433 | BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor"); |
1381 | err = ext3_journal_dirty_metadata(handle, gdp_bh); | 1434 | err = ext3_journal_dirty_metadata(handle, gdp_bh); |
@@ -1388,6 +1441,8 @@ allocated: | |||
1388 | 1441 | ||
1389 | *errp = 0; | 1442 | *errp = 0; |
1390 | brelse(bitmap_bh); | 1443 | brelse(bitmap_bh); |
1444 | DQUOT_FREE_BLOCK(inode, *count-num); | ||
1445 | *count = num; | ||
1391 | return ret_block; | 1446 | return ret_block; |
1392 | 1447 | ||
1393 | io_error: | 1448 | io_error: |
@@ -1401,11 +1456,19 @@ out: | |||
1401 | * Undo the block allocation | 1456 | * Undo the block allocation |
1402 | */ | 1457 | */ |
1403 | if (!performed_allocation) | 1458 | if (!performed_allocation) |
1404 | DQUOT_FREE_BLOCK(inode, 1); | 1459 | DQUOT_FREE_BLOCK(inode, *count); |
1405 | brelse(bitmap_bh); | 1460 | brelse(bitmap_bh); |
1406 | return 0; | 1461 | return 0; |
1407 | } | 1462 | } |
1408 | 1463 | ||
1464 | int ext3_new_block(handle_t *handle, struct inode *inode, | ||
1465 | unsigned long goal, int *errp) | ||
1466 | { | ||
1467 | unsigned long count = 1; | ||
1468 | |||
1469 | return ext3_new_blocks(handle, inode, goal, &count, errp); | ||
1470 | } | ||
1471 | |||
1409 | unsigned long ext3_count_free_blocks(struct super_block *sb) | 1472 | unsigned long ext3_count_free_blocks(struct super_block *sb) |
1410 | { | 1473 | { |
1411 | unsigned long desc_count; | 1474 | unsigned long desc_count; |
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c index 773459164bb2..f37528ed222e 100644 --- a/fs/ext3/dir.c +++ b/fs/ext3/dir.c | |||
@@ -39,7 +39,7 @@ static int ext3_dx_readdir(struct file * filp, | |||
39 | static int ext3_release_dir (struct inode * inode, | 39 | static int ext3_release_dir (struct inode * inode, |
40 | struct file * filp); | 40 | struct file * filp); |
41 | 41 | ||
42 | struct file_operations ext3_dir_operations = { | 42 | const struct file_operations ext3_dir_operations = { |
43 | .llseek = generic_file_llseek, | 43 | .llseek = generic_file_llseek, |
44 | .read = generic_read_dir, | 44 | .read = generic_read_dir, |
45 | .readdir = ext3_readdir, /* we take BKL. needed?*/ | 45 | .readdir = ext3_readdir, /* we take BKL. needed?*/ |
@@ -131,8 +131,9 @@ static int ext3_readdir(struct file * filp, | |||
131 | struct buffer_head *bh = NULL; | 131 | struct buffer_head *bh = NULL; |
132 | 132 | ||
133 | map_bh.b_state = 0; | 133 | map_bh.b_state = 0; |
134 | err = ext3_get_block_handle(NULL, inode, blk, &map_bh, 0, 0); | 134 | err = ext3_get_blocks_handle(NULL, inode, blk, 1, |
135 | if (!err) { | 135 | &map_bh, 0, 0); |
136 | if (err > 0) { | ||
136 | page_cache_readahead(sb->s_bdev->bd_inode->i_mapping, | 137 | page_cache_readahead(sb->s_bdev->bd_inode->i_mapping, |
137 | &filp->f_ra, | 138 | &filp->f_ra, |
138 | filp, | 139 | filp, |
diff --git a/fs/ext3/file.c b/fs/ext3/file.c index 59098ea56711..783a796220bb 100644 --- a/fs/ext3/file.c +++ b/fs/ext3/file.c | |||
@@ -105,7 +105,7 @@ force_commit: | |||
105 | return ret; | 105 | return ret; |
106 | } | 106 | } |
107 | 107 | ||
108 | struct file_operations ext3_file_operations = { | 108 | const struct file_operations ext3_file_operations = { |
109 | .llseek = generic_file_llseek, | 109 | .llseek = generic_file_llseek, |
110 | .read = do_sync_read, | 110 | .read = do_sync_read, |
111 | .write = do_sync_write, | 111 | .write = do_sync_write, |
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 2c361377e0a5..48ae0339af17 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -44,16 +44,16 @@ static int ext3_writepage_trans_blocks(struct inode *inode); | |||
44 | /* | 44 | /* |
45 | * Test whether an inode is a fast symlink. | 45 | * Test whether an inode is a fast symlink. |
46 | */ | 46 | */ |
47 | static inline int ext3_inode_is_fast_symlink(struct inode *inode) | 47 | static int ext3_inode_is_fast_symlink(struct inode *inode) |
48 | { | 48 | { |
49 | int ea_blocks = EXT3_I(inode)->i_file_acl ? | 49 | int ea_blocks = EXT3_I(inode)->i_file_acl ? |
50 | (inode->i_sb->s_blocksize >> 9) : 0; | 50 | (inode->i_sb->s_blocksize >> 9) : 0; |
51 | 51 | ||
52 | return (S_ISLNK(inode->i_mode) && | 52 | return (S_ISLNK(inode->i_mode) && inode->i_blocks - ea_blocks == 0); |
53 | inode->i_blocks - ea_blocks == 0); | ||
54 | } | 53 | } |
55 | 54 | ||
56 | /* The ext3 forget function must perform a revoke if we are freeing data | 55 | /* |
56 | * The ext3 forget function must perform a revoke if we are freeing data | ||
57 | * which has been journaled. Metadata (eg. indirect blocks) must be | 57 | * which has been journaled. Metadata (eg. indirect blocks) must be |
58 | * revoked in all cases. | 58 | * revoked in all cases. |
59 | * | 59 | * |
@@ -61,10 +61,8 @@ static inline int ext3_inode_is_fast_symlink(struct inode *inode) | |||
61 | * but there may still be a record of it in the journal, and that record | 61 | * but there may still be a record of it in the journal, and that record |
62 | * still needs to be revoked. | 62 | * still needs to be revoked. |
63 | */ | 63 | */ |
64 | 64 | int ext3_forget(handle_t *handle, int is_metadata, struct inode *inode, | |
65 | int ext3_forget(handle_t *handle, int is_metadata, | 65 | struct buffer_head *bh, int blocknr) |
66 | struct inode *inode, struct buffer_head *bh, | ||
67 | int blocknr) | ||
68 | { | 66 | { |
69 | int err; | 67 | int err; |
70 | 68 | ||
@@ -104,10 +102,9 @@ int ext3_forget(handle_t *handle, int is_metadata, | |||
104 | } | 102 | } |
105 | 103 | ||
106 | /* | 104 | /* |
107 | * Work out how many blocks we need to progress with the next chunk of a | 105 | * Work out how many blocks we need to proceed with the next chunk of a |
108 | * truncate transaction. | 106 | * truncate transaction. |
109 | */ | 107 | */ |
110 | |||
111 | static unsigned long blocks_for_truncate(struct inode *inode) | 108 | static unsigned long blocks_for_truncate(struct inode *inode) |
112 | { | 109 | { |
113 | unsigned long needed; | 110 | unsigned long needed; |
@@ -141,7 +138,6 @@ static unsigned long blocks_for_truncate(struct inode *inode) | |||
141 | * extend fails, we need to propagate the failure up and restart the | 138 | * extend fails, we need to propagate the failure up and restart the |
142 | * transaction in the top-level truncate loop. --sct | 139 | * transaction in the top-level truncate loop. --sct |
143 | */ | 140 | */ |
144 | |||
145 | static handle_t *start_transaction(struct inode *inode) | 141 | static handle_t *start_transaction(struct inode *inode) |
146 | { | 142 | { |
147 | handle_t *result; | 143 | handle_t *result; |
@@ -194,9 +190,11 @@ void ext3_delete_inode (struct inode * inode) | |||
194 | 190 | ||
195 | handle = start_transaction(inode); | 191 | handle = start_transaction(inode); |
196 | if (IS_ERR(handle)) { | 192 | if (IS_ERR(handle)) { |
197 | /* If we're going to skip the normal cleanup, we still | 193 | /* |
198 | * need to make sure that the in-core orphan linked list | 194 | * If we're going to skip the normal cleanup, we still need to |
199 | * is properly cleaned up. */ | 195 | * make sure that the in-core orphan linked list is properly |
196 | * cleaned up. | ||
197 | */ | ||
200 | ext3_orphan_del(NULL, inode); | 198 | ext3_orphan_del(NULL, inode); |
201 | goto no_delete; | 199 | goto no_delete; |
202 | } | 200 | } |
@@ -235,16 +233,6 @@ no_delete: | |||
235 | clear_inode(inode); /* We must guarantee clearing of inode... */ | 233 | clear_inode(inode); /* We must guarantee clearing of inode... */ |
236 | } | 234 | } |
237 | 235 | ||
238 | static int ext3_alloc_block (handle_t *handle, | ||
239 | struct inode * inode, unsigned long goal, int *err) | ||
240 | { | ||
241 | unsigned long result; | ||
242 | |||
243 | result = ext3_new_block(handle, inode, goal, err); | ||
244 | return result; | ||
245 | } | ||
246 | |||
247 | |||
248 | typedef struct { | 236 | typedef struct { |
249 | __le32 *p; | 237 | __le32 *p; |
250 | __le32 key; | 238 | __le32 key; |
@@ -257,7 +245,7 @@ static inline void add_chain(Indirect *p, struct buffer_head *bh, __le32 *v) | |||
257 | p->bh = bh; | 245 | p->bh = bh; |
258 | } | 246 | } |
259 | 247 | ||
260 | static inline int verify_chain(Indirect *from, Indirect *to) | 248 | static int verify_chain(Indirect *from, Indirect *to) |
261 | { | 249 | { |
262 | while (from <= to && from->key == *from->p) | 250 | while (from <= to && from->key == *from->p) |
263 | from++; | 251 | from++; |
@@ -327,10 +315,10 @@ static int ext3_block_to_path(struct inode *inode, | |||
327 | offsets[n++] = i_block & (ptrs - 1); | 315 | offsets[n++] = i_block & (ptrs - 1); |
328 | final = ptrs; | 316 | final = ptrs; |
329 | } else { | 317 | } else { |
330 | ext3_warning (inode->i_sb, "ext3_block_to_path", "block > big"); | 318 | ext3_warning(inode->i_sb, "ext3_block_to_path", "block > big"); |
331 | } | 319 | } |
332 | if (boundary) | 320 | if (boundary) |
333 | *boundary = (i_block & (ptrs - 1)) == (final - 1); | 321 | *boundary = final - 1 - (i_block & (ptrs - 1)); |
334 | return n; | 322 | return n; |
335 | } | 323 | } |
336 | 324 | ||
@@ -419,7 +407,6 @@ no_block: | |||
419 | * | 407 | * |
420 | * Caller must make sure that @ind is valid and will stay that way. | 408 | * Caller must make sure that @ind is valid and will stay that way. |
421 | */ | 409 | */ |
422 | |||
423 | static unsigned long ext3_find_near(struct inode *inode, Indirect *ind) | 410 | static unsigned long ext3_find_near(struct inode *inode, Indirect *ind) |
424 | { | 411 | { |
425 | struct ext3_inode_info *ei = EXT3_I(inode); | 412 | struct ext3_inode_info *ei = EXT3_I(inode); |
@@ -429,17 +416,18 @@ static unsigned long ext3_find_near(struct inode *inode, Indirect *ind) | |||
429 | unsigned long colour; | 416 | unsigned long colour; |
430 | 417 | ||
431 | /* Try to find previous block */ | 418 | /* Try to find previous block */ |
432 | for (p = ind->p - 1; p >= start; p--) | 419 | for (p = ind->p - 1; p >= start; p--) { |
433 | if (*p) | 420 | if (*p) |
434 | return le32_to_cpu(*p); | 421 | return le32_to_cpu(*p); |
422 | } | ||
435 | 423 | ||
436 | /* No such thing, so let's try location of indirect block */ | 424 | /* No such thing, so let's try location of indirect block */ |
437 | if (ind->bh) | 425 | if (ind->bh) |
438 | return ind->bh->b_blocknr; | 426 | return ind->bh->b_blocknr; |
439 | 427 | ||
440 | /* | 428 | /* |
441 | * It is going to be refered from inode itself? OK, just put it into | 429 | * It is going to be referred to from the inode itself? OK, just put it |
442 | * the same cylinder group then. | 430 | * into the same cylinder group then. |
443 | */ | 431 | */ |
444 | bg_start = (ei->i_block_group * EXT3_BLOCKS_PER_GROUP(inode->i_sb)) + | 432 | bg_start = (ei->i_block_group * EXT3_BLOCKS_PER_GROUP(inode->i_sb)) + |
445 | le32_to_cpu(EXT3_SB(inode->i_sb)->s_es->s_first_data_block); | 433 | le32_to_cpu(EXT3_SB(inode->i_sb)->s_es->s_first_data_block); |
@@ -463,7 +451,9 @@ static unsigned long ext3_find_near(struct inode *inode, Indirect *ind) | |||
463 | static unsigned long ext3_find_goal(struct inode *inode, long block, | 451 | static unsigned long ext3_find_goal(struct inode *inode, long block, |
464 | Indirect chain[4], Indirect *partial) | 452 | Indirect chain[4], Indirect *partial) |
465 | { | 453 | { |
466 | struct ext3_block_alloc_info *block_i = EXT3_I(inode)->i_block_alloc_info; | 454 | struct ext3_block_alloc_info *block_i; |
455 | |||
456 | block_i = EXT3_I(inode)->i_block_alloc_info; | ||
467 | 457 | ||
468 | /* | 458 | /* |
469 | * try the heuristic for sequential allocation, | 459 | * try the heuristic for sequential allocation, |
@@ -478,13 +468,113 @@ static unsigned long ext3_find_goal(struct inode *inode, long block, | |||
478 | } | 468 | } |
479 | 469 | ||
480 | /** | 470 | /** |
471 | * ext3_blks_to_allocate: Look up the block map and count the number | ||
472 | * of direct blocks need to be allocated for the given branch. | ||
473 | * | ||
474 | * @branch: chain of indirect blocks | ||
475 | * @k: number of blocks need for indirect blocks | ||
476 | * @blks: number of data blocks to be mapped. | ||
477 | * @blocks_to_boundary: the offset in the indirect block | ||
478 | * | ||
479 | * return the total number of blocks to be allocate, including the | ||
480 | * direct and indirect blocks. | ||
481 | */ | ||
482 | static int ext3_blks_to_allocate(Indirect *branch, int k, unsigned long blks, | ||
483 | int blocks_to_boundary) | ||
484 | { | ||
485 | unsigned long count = 0; | ||
486 | |||
487 | /* | ||
488 | * Simple case, [t,d]Indirect block(s) has not allocated yet | ||
489 | * then it's clear blocks on that path have not allocated | ||
490 | */ | ||
491 | if (k > 0) { | ||
492 | /* right now we don't handle cross boundary allocation */ | ||
493 | if (blks < blocks_to_boundary + 1) | ||
494 | count += blks; | ||
495 | else | ||
496 | count += blocks_to_boundary + 1; | ||
497 | return count; | ||
498 | } | ||
499 | |||
500 | count++; | ||
501 | while (count < blks && count <= blocks_to_boundary && | ||
502 | le32_to_cpu(*(branch[0].p + count)) == 0) { | ||
503 | count++; | ||
504 | } | ||
505 | return count; | ||
506 | } | ||
507 | |||
508 | /** | ||
509 | * ext3_alloc_blocks: multiple allocate blocks needed for a branch | ||
510 | * @indirect_blks: the number of blocks need to allocate for indirect | ||
511 | * blocks | ||
512 | * | ||
513 | * @new_blocks: on return it will store the new block numbers for | ||
514 | * the indirect blocks(if needed) and the first direct block, | ||
515 | * @blks: on return it will store the total number of allocated | ||
516 | * direct blocks | ||
517 | */ | ||
518 | static int ext3_alloc_blocks(handle_t *handle, struct inode *inode, | ||
519 | unsigned long goal, int indirect_blks, int blks, | ||
520 | unsigned long long new_blocks[4], int *err) | ||
521 | { | ||
522 | int target, i; | ||
523 | unsigned long count = 0; | ||
524 | int index = 0; | ||
525 | unsigned long current_block = 0; | ||
526 | int ret = 0; | ||
527 | |||
528 | /* | ||
529 | * Here we try to allocate the requested multiple blocks at once, | ||
530 | * on a best-effort basis. | ||
531 | * To build a branch, we should allocate blocks for | ||
532 | * the indirect blocks(if not allocated yet), and at least | ||
533 | * the first direct block of this branch. That's the | ||
534 | * minimum number of blocks need to allocate(required) | ||
535 | */ | ||
536 | target = blks + indirect_blks; | ||
537 | |||
538 | while (1) { | ||
539 | count = target; | ||
540 | /* allocating blocks for indirect blocks and direct blocks */ | ||
541 | current_block = ext3_new_blocks(handle,inode,goal,&count,err); | ||
542 | if (*err) | ||
543 | goto failed_out; | ||
544 | |||
545 | target -= count; | ||
546 | /* allocate blocks for indirect blocks */ | ||
547 | while (index < indirect_blks && count) { | ||
548 | new_blocks[index++] = current_block++; | ||
549 | count--; | ||
550 | } | ||
551 | |||
552 | if (count > 0) | ||
553 | break; | ||
554 | } | ||
555 | |||
556 | /* save the new block number for the first direct block */ | ||
557 | new_blocks[index] = current_block; | ||
558 | |||
559 | /* total number of blocks allocated for direct blocks */ | ||
560 | ret = count; | ||
561 | *err = 0; | ||
562 | return ret; | ||
563 | failed_out: | ||
564 | for (i = 0; i <index; i++) | ||
565 | ext3_free_blocks(handle, inode, new_blocks[i], 1); | ||
566 | return ret; | ||
567 | } | ||
568 | |||
569 | /** | ||
481 | * ext3_alloc_branch - allocate and set up a chain of blocks. | 570 | * ext3_alloc_branch - allocate and set up a chain of blocks. |
482 | * @inode: owner | 571 | * @inode: owner |
483 | * @num: depth of the chain (number of blocks to allocate) | 572 | * @indirect_blks: number of allocated indirect blocks |
573 | * @blks: number of allocated direct blocks | ||
484 | * @offsets: offsets (in the blocks) to store the pointers to next. | 574 | * @offsets: offsets (in the blocks) to store the pointers to next. |
485 | * @branch: place to store the chain in. | 575 | * @branch: place to store the chain in. |
486 | * | 576 | * |
487 | * This function allocates @num blocks, zeroes out all but the last one, | 577 | * This function allocates blocks, zeroes out all but the last one, |
488 | * links them into chain and (if we are synchronous) writes them to disk. | 578 | * links them into chain and (if we are synchronous) writes them to disk. |
489 | * In other words, it prepares a branch that can be spliced onto the | 579 | * In other words, it prepares a branch that can be spliced onto the |
490 | * inode. It stores the information about that chain in the branch[], in | 580 | * inode. It stores the information about that chain in the branch[], in |
@@ -501,97 +591,106 @@ static unsigned long ext3_find_goal(struct inode *inode, long block, | |||
501 | * ext3_alloc_block() (normally -ENOSPC). Otherwise we set the chain | 591 | * ext3_alloc_block() (normally -ENOSPC). Otherwise we set the chain |
502 | * as described above and return 0. | 592 | * as described above and return 0. |
503 | */ | 593 | */ |
504 | |||
505 | static int ext3_alloc_branch(handle_t *handle, struct inode *inode, | 594 | static int ext3_alloc_branch(handle_t *handle, struct inode *inode, |
506 | int num, | 595 | int indirect_blks, int *blks, unsigned long goal, |
507 | unsigned long goal, | 596 | int *offsets, Indirect *branch) |
508 | int *offsets, | ||
509 | Indirect *branch) | ||
510 | { | 597 | { |
511 | int blocksize = inode->i_sb->s_blocksize; | 598 | int blocksize = inode->i_sb->s_blocksize; |
512 | int n = 0, keys = 0; | 599 | int i, n = 0; |
513 | int err = 0; | 600 | int err = 0; |
514 | int i; | 601 | struct buffer_head *bh; |
515 | int parent = ext3_alloc_block(handle, inode, goal, &err); | 602 | int num; |
516 | 603 | unsigned long long new_blocks[4]; | |
517 | branch[0].key = cpu_to_le32(parent); | 604 | unsigned long long current_block; |
518 | if (parent) { | ||
519 | for (n = 1; n < num; n++) { | ||
520 | struct buffer_head *bh; | ||
521 | /* Allocate the next block */ | ||
522 | int nr = ext3_alloc_block(handle, inode, parent, &err); | ||
523 | if (!nr) | ||
524 | break; | ||
525 | branch[n].key = cpu_to_le32(nr); | ||
526 | 605 | ||
527 | /* | 606 | num = ext3_alloc_blocks(handle, inode, goal, indirect_blks, |
528 | * Get buffer_head for parent block, zero it out | 607 | *blks, new_blocks, &err); |
529 | * and set the pointer to new one, then send | 608 | if (err) |
530 | * parent to disk. | 609 | return err; |
531 | */ | ||
532 | bh = sb_getblk(inode->i_sb, parent); | ||
533 | if (!bh) | ||
534 | break; | ||
535 | keys = n+1; | ||
536 | branch[n].bh = bh; | ||
537 | lock_buffer(bh); | ||
538 | BUFFER_TRACE(bh, "call get_create_access"); | ||
539 | err = ext3_journal_get_create_access(handle, bh); | ||
540 | if (err) { | ||
541 | unlock_buffer(bh); | ||
542 | brelse(bh); | ||
543 | break; | ||
544 | } | ||
545 | 610 | ||
546 | memset(bh->b_data, 0, blocksize); | 611 | branch[0].key = cpu_to_le32(new_blocks[0]); |
547 | branch[n].p = (__le32*) bh->b_data + offsets[n]; | 612 | /* |
548 | *branch[n].p = branch[n].key; | 613 | * metadata blocks and data blocks are allocated. |
549 | BUFFER_TRACE(bh, "marking uptodate"); | 614 | */ |
550 | set_buffer_uptodate(bh); | 615 | for (n = 1; n <= indirect_blks; n++) { |
616 | /* | ||
617 | * Get buffer_head for parent block, zero it out | ||
618 | * and set the pointer to new one, then send | ||
619 | * parent to disk. | ||
620 | */ | ||
621 | bh = sb_getblk(inode->i_sb, new_blocks[n-1]); | ||
622 | branch[n].bh = bh; | ||
623 | lock_buffer(bh); | ||
624 | BUFFER_TRACE(bh, "call get_create_access"); | ||
625 | err = ext3_journal_get_create_access(handle, bh); | ||
626 | if (err) { | ||
551 | unlock_buffer(bh); | 627 | unlock_buffer(bh); |
628 | brelse(bh); | ||
629 | goto failed; | ||
630 | } | ||
552 | 631 | ||
553 | BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata"); | 632 | memset(bh->b_data, 0, blocksize); |
554 | err = ext3_journal_dirty_metadata(handle, bh); | 633 | branch[n].p = (__le32 *) bh->b_data + offsets[n]; |
555 | if (err) | 634 | branch[n].key = cpu_to_le32(new_blocks[n]); |
556 | break; | 635 | *branch[n].p = branch[n].key; |
557 | 636 | if ( n == indirect_blks) { | |
558 | parent = nr; | 637 | current_block = new_blocks[n]; |
638 | /* | ||
639 | * End of chain, update the last new metablock of | ||
640 | * the chain to point to the new allocated | ||
641 | * data blocks numbers | ||
642 | */ | ||
643 | for (i=1; i < num; i++) | ||
644 | *(branch[n].p + i) = cpu_to_le32(++current_block); | ||
559 | } | 645 | } |
560 | } | 646 | BUFFER_TRACE(bh, "marking uptodate"); |
561 | if (n == num) | 647 | set_buffer_uptodate(bh); |
562 | return 0; | 648 | unlock_buffer(bh); |
563 | 649 | ||
650 | BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata"); | ||
651 | err = ext3_journal_dirty_metadata(handle, bh); | ||
652 | if (err) | ||
653 | goto failed; | ||
654 | } | ||
655 | *blks = num; | ||
656 | return err; | ||
657 | failed: | ||
564 | /* Allocation failed, free what we already allocated */ | 658 | /* Allocation failed, free what we already allocated */ |
565 | for (i = 1; i < keys; i++) { | 659 | for (i = 1; i <= n ; i++) { |
566 | BUFFER_TRACE(branch[i].bh, "call journal_forget"); | 660 | BUFFER_TRACE(branch[i].bh, "call journal_forget"); |
567 | ext3_journal_forget(handle, branch[i].bh); | 661 | ext3_journal_forget(handle, branch[i].bh); |
568 | } | 662 | } |
569 | for (i = 0; i < keys; i++) | 663 | for (i = 0; i <indirect_blks; i++) |
570 | ext3_free_blocks(handle, inode, le32_to_cpu(branch[i].key), 1); | 664 | ext3_free_blocks(handle, inode, new_blocks[i], 1); |
665 | |||
666 | ext3_free_blocks(handle, inode, new_blocks[i], num); | ||
667 | |||
571 | return err; | 668 | return err; |
572 | } | 669 | } |
573 | 670 | ||
574 | /** | 671 | /** |
575 | * ext3_splice_branch - splice the allocated branch onto inode. | 672 | * ext3_splice_branch - splice the allocated branch onto inode. |
576 | * @inode: owner | 673 | * @inode: owner |
577 | * @block: (logical) number of block we are adding | 674 | * @block: (logical) number of block we are adding |
578 | * @chain: chain of indirect blocks (with a missing link - see | 675 | * @chain: chain of indirect blocks (with a missing link - see |
579 | * ext3_alloc_branch) | 676 | * ext3_alloc_branch) |
580 | * @where: location of missing link | 677 | * @where: location of missing link |
581 | * @num: number of blocks we are adding | 678 | * @num: number of indirect blocks we are adding |
582 | * | 679 | * @blks: number of direct blocks we are adding |
583 | * This function fills the missing link and does all housekeeping needed in | 680 | * |
584 | * inode (->i_blocks, etc.). In case of success we end up with the full | 681 | * This function fills the missing link and does all housekeeping needed in |
585 | * chain to new block and return 0. | 682 | * inode (->i_blocks, etc.). In case of success we end up with the full |
683 | * chain to new block and return 0. | ||
586 | */ | 684 | */ |
587 | 685 | static int ext3_splice_branch(handle_t *handle, struct inode *inode, | |
588 | static int ext3_splice_branch(handle_t *handle, struct inode *inode, long block, | 686 | long block, Indirect *where, int num, int blks) |
589 | Indirect chain[4], Indirect *where, int num) | ||
590 | { | 687 | { |
591 | int i; | 688 | int i; |
592 | int err = 0; | 689 | int err = 0; |
593 | struct ext3_block_alloc_info *block_i = EXT3_I(inode)->i_block_alloc_info; | 690 | struct ext3_block_alloc_info *block_i; |
691 | unsigned long current_block; | ||
594 | 692 | ||
693 | block_i = EXT3_I(inode)->i_block_alloc_info; | ||
595 | /* | 694 | /* |
596 | * If we're splicing into a [td]indirect block (as opposed to the | 695 | * If we're splicing into a [td]indirect block (as opposed to the |
597 | * inode) then we need to get write access to the [td]indirect block | 696 | * inode) then we need to get write access to the [td]indirect block |
@@ -608,13 +707,24 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode, long block, | |||
608 | *where->p = where->key; | 707 | *where->p = where->key; |
609 | 708 | ||
610 | /* | 709 | /* |
710 | * Update the host buffer_head or inode to point to more just allocated | ||
711 | * direct blocks blocks | ||
712 | */ | ||
713 | if (num == 0 && blks > 1) { | ||
714 | current_block = le32_to_cpu(where->key + 1); | ||
715 | for (i = 1; i < blks; i++) | ||
716 | *(where->p + i ) = cpu_to_le32(current_block++); | ||
717 | } | ||
718 | |||
719 | /* | ||
611 | * update the most recently allocated logical & physical block | 720 | * update the most recently allocated logical & physical block |
612 | * in i_block_alloc_info, to assist find the proper goal block for next | 721 | * in i_block_alloc_info, to assist find the proper goal block for next |
613 | * allocation | 722 | * allocation |
614 | */ | 723 | */ |
615 | if (block_i) { | 724 | if (block_i) { |
616 | block_i->last_alloc_logical_block = block; | 725 | block_i->last_alloc_logical_block = block + blks - 1; |
617 | block_i->last_alloc_physical_block = le32_to_cpu(where[num-1].key); | 726 | block_i->last_alloc_physical_block = |
727 | le32_to_cpu(where[num].key + blks - 1); | ||
618 | } | 728 | } |
619 | 729 | ||
620 | /* We are done with atomic stuff, now do the rest of housekeeping */ | 730 | /* We are done with atomic stuff, now do the rest of housekeeping */ |
@@ -625,7 +735,7 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode, long block, | |||
625 | /* had we spliced it onto indirect block? */ | 735 | /* had we spliced it onto indirect block? */ |
626 | if (where->bh) { | 736 | if (where->bh) { |
627 | /* | 737 | /* |
628 | * akpm: If we spliced it onto an indirect block, we haven't | 738 | * If we spliced it onto an indirect block, we haven't |
629 | * altered the inode. Note however that if it is being spliced | 739 | * altered the inode. Note however that if it is being spliced |
630 | * onto an indirect block at the very end of the file (the | 740 | * onto an indirect block at the very end of the file (the |
631 | * file is growing) then we *will* alter the inode to reflect | 741 | * file is growing) then we *will* alter the inode to reflect |
@@ -647,10 +757,13 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode, long block, | |||
647 | return err; | 757 | return err; |
648 | 758 | ||
649 | err_out: | 759 | err_out: |
650 | for (i = 1; i < num; i++) { | 760 | for (i = 1; i <= num; i++) { |
651 | BUFFER_TRACE(where[i].bh, "call journal_forget"); | 761 | BUFFER_TRACE(where[i].bh, "call journal_forget"); |
652 | ext3_journal_forget(handle, where[i].bh); | 762 | ext3_journal_forget(handle, where[i].bh); |
763 | ext3_free_blocks(handle,inode,le32_to_cpu(where[i-1].key),1); | ||
653 | } | 764 | } |
765 | ext3_free_blocks(handle, inode, le32_to_cpu(where[num].key), blks); | ||
766 | |||
654 | return err; | 767 | return err; |
655 | } | 768 | } |
656 | 769 | ||
@@ -666,26 +779,33 @@ err_out: | |||
666 | * allocations is needed - we simply release blocks and do not touch anything | 779 | * allocations is needed - we simply release blocks and do not touch anything |
667 | * reachable from inode. | 780 | * reachable from inode. |
668 | * | 781 | * |
669 | * akpm: `handle' can be NULL if create == 0. | 782 | * `handle' can be NULL if create == 0. |
670 | * | 783 | * |
671 | * The BKL may not be held on entry here. Be sure to take it early. | 784 | * The BKL may not be held on entry here. Be sure to take it early. |
785 | * return > 0, # of blocks mapped or allocated. | ||
786 | * return = 0, if plain lookup failed. | ||
787 | * return < 0, error case. | ||
672 | */ | 788 | */ |
673 | 789 | int ext3_get_blocks_handle(handle_t *handle, struct inode *inode, | |
674 | int | 790 | sector_t iblock, unsigned long maxblocks, |
675 | ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | 791 | struct buffer_head *bh_result, |
676 | struct buffer_head *bh_result, int create, int extend_disksize) | 792 | int create, int extend_disksize) |
677 | { | 793 | { |
678 | int err = -EIO; | 794 | int err = -EIO; |
679 | int offsets[4]; | 795 | int offsets[4]; |
680 | Indirect chain[4]; | 796 | Indirect chain[4]; |
681 | Indirect *partial; | 797 | Indirect *partial; |
682 | unsigned long goal; | 798 | unsigned long goal; |
683 | int left; | 799 | int indirect_blks; |
684 | int boundary = 0; | 800 | int blocks_to_boundary = 0; |
685 | const int depth = ext3_block_to_path(inode, iblock, offsets, &boundary); | 801 | int depth; |
686 | struct ext3_inode_info *ei = EXT3_I(inode); | 802 | struct ext3_inode_info *ei = EXT3_I(inode); |
803 | int count = 0; | ||
804 | unsigned long first_block = 0; | ||
805 | |||
687 | 806 | ||
688 | J_ASSERT(handle != NULL || create == 0); | 807 | J_ASSERT(handle != NULL || create == 0); |
808 | depth = ext3_block_to_path(inode,iblock,offsets,&blocks_to_boundary); | ||
689 | 809 | ||
690 | if (depth == 0) | 810 | if (depth == 0) |
691 | goto out; | 811 | goto out; |
@@ -694,8 +814,31 @@ ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | |||
694 | 814 | ||
695 | /* Simplest case - block found, no allocation needed */ | 815 | /* Simplest case - block found, no allocation needed */ |
696 | if (!partial) { | 816 | if (!partial) { |
817 | first_block = chain[depth - 1].key; | ||
697 | clear_buffer_new(bh_result); | 818 | clear_buffer_new(bh_result); |
698 | goto got_it; | 819 | count++; |
820 | /*map more blocks*/ | ||
821 | while (count < maxblocks && count <= blocks_to_boundary) { | ||
822 | if (!verify_chain(chain, partial)) { | ||
823 | /* | ||
824 | * Indirect block might be removed by | ||
825 | * truncate while we were reading it. | ||
826 | * Handling of that case: forget what we've | ||
827 | * got now. Flag the err as EAGAIN, so it | ||
828 | * will reread. | ||
829 | */ | ||
830 | err = -EAGAIN; | ||
831 | count = 0; | ||
832 | break; | ||
833 | } | ||
834 | if (le32_to_cpu(*(chain[depth-1].p+count) == | ||
835 | (first_block + count))) | ||
836 | count++; | ||
837 | else | ||
838 | break; | ||
839 | } | ||
840 | if (err != -EAGAIN) | ||
841 | goto got_it; | ||
699 | } | 842 | } |
700 | 843 | ||
701 | /* Next simple case - plain lookup or failed read of indirect block */ | 844 | /* Next simple case - plain lookup or failed read of indirect block */ |
@@ -723,6 +866,7 @@ ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | |||
723 | } | 866 | } |
724 | partial = ext3_get_branch(inode, depth, offsets, chain, &err); | 867 | partial = ext3_get_branch(inode, depth, offsets, chain, &err); |
725 | if (!partial) { | 868 | if (!partial) { |
869 | count++; | ||
726 | mutex_unlock(&ei->truncate_mutex); | 870 | mutex_unlock(&ei->truncate_mutex); |
727 | if (err) | 871 | if (err) |
728 | goto cleanup; | 872 | goto cleanup; |
@@ -740,12 +884,19 @@ ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | |||
740 | 884 | ||
741 | goal = ext3_find_goal(inode, iblock, chain, partial); | 885 | goal = ext3_find_goal(inode, iblock, chain, partial); |
742 | 886 | ||
743 | left = (chain + depth) - partial; | 887 | /* the number of blocks need to allocate for [d,t]indirect blocks */ |
888 | indirect_blks = (chain + depth) - partial - 1; | ||
744 | 889 | ||
745 | /* | 890 | /* |
891 | * Next look up the indirect map to count the totoal number of | ||
892 | * direct blocks to allocate for this branch. | ||
893 | */ | ||
894 | count = ext3_blks_to_allocate(partial, indirect_blks, | ||
895 | maxblocks, blocks_to_boundary); | ||
896 | /* | ||
746 | * Block out ext3_truncate while we alter the tree | 897 | * Block out ext3_truncate while we alter the tree |
747 | */ | 898 | */ |
748 | err = ext3_alloc_branch(handle, inode, left, goal, | 899 | err = ext3_alloc_branch(handle, inode, indirect_blks, &count, goal, |
749 | offsets + (partial - chain), partial); | 900 | offsets + (partial - chain), partial); |
750 | 901 | ||
751 | /* | 902 | /* |
@@ -756,8 +907,8 @@ ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | |||
756 | * may need to return -EAGAIN upwards in the worst case. --sct | 907 | * may need to return -EAGAIN upwards in the worst case. --sct |
757 | */ | 908 | */ |
758 | if (!err) | 909 | if (!err) |
759 | err = ext3_splice_branch(handle, inode, iblock, chain, | 910 | err = ext3_splice_branch(handle, inode, iblock, |
760 | partial, left); | 911 | partial, indirect_blks, count); |
761 | /* | 912 | /* |
762 | * i_disksize growing is protected by truncate_mutex. Don't forget to | 913 | * i_disksize growing is protected by truncate_mutex. Don't forget to |
763 | * protect it if you're about to implement concurrent | 914 | * protect it if you're about to implement concurrent |
@@ -772,8 +923,9 @@ ext3_get_block_handle(handle_t *handle, struct inode *inode, sector_t iblock, | |||
772 | set_buffer_new(bh_result); | 923 | set_buffer_new(bh_result); |
773 | got_it: | 924 | got_it: |
774 | map_bh(bh_result, inode->i_sb, le32_to_cpu(chain[depth-1].key)); | 925 | map_bh(bh_result, inode->i_sb, le32_to_cpu(chain[depth-1].key)); |
775 | if (boundary) | 926 | if (blocks_to_boundary == 0) |
776 | set_buffer_boundary(bh_result); | 927 | set_buffer_boundary(bh_result); |
928 | err = count; | ||
777 | /* Clean up and exit */ | 929 | /* Clean up and exit */ |
778 | partial = chain + depth - 1; /* the whole chain */ | 930 | partial = chain + depth - 1; /* the whole chain */ |
779 | cleanup: | 931 | cleanup: |
@@ -787,34 +939,21 @@ out: | |||
787 | return err; | 939 | return err; |
788 | } | 940 | } |
789 | 941 | ||
790 | static int ext3_get_block(struct inode *inode, sector_t iblock, | ||
791 | struct buffer_head *bh_result, int create) | ||
792 | { | ||
793 | handle_t *handle = NULL; | ||
794 | int ret; | ||
795 | |||
796 | if (create) { | ||
797 | handle = ext3_journal_current_handle(); | ||
798 | J_ASSERT(handle != 0); | ||
799 | } | ||
800 | ret = ext3_get_block_handle(handle, inode, iblock, | ||
801 | bh_result, create, 1); | ||
802 | return ret; | ||
803 | } | ||
804 | |||
805 | #define DIO_CREDITS (EXT3_RESERVE_TRANS_BLOCKS + 32) | 942 | #define DIO_CREDITS (EXT3_RESERVE_TRANS_BLOCKS + 32) |
806 | 943 | ||
807 | static int | 944 | static int ext3_get_block(struct inode *inode, sector_t iblock, |
808 | ext3_direct_io_get_blocks(struct inode *inode, sector_t iblock, | 945 | struct buffer_head *bh_result, int create) |
809 | unsigned long max_blocks, struct buffer_head *bh_result, | ||
810 | int create) | ||
811 | { | 946 | { |
812 | handle_t *handle = journal_current_handle(); | 947 | handle_t *handle = journal_current_handle(); |
813 | int ret = 0; | 948 | int ret = 0; |
949 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; | ||
814 | 950 | ||
815 | if (!handle) | 951 | if (!create) |
816 | goto get_block; /* A read */ | 952 | goto get_block; /* A read */ |
817 | 953 | ||
954 | if (max_blocks == 1) | ||
955 | goto get_block; /* A single block get */ | ||
956 | |||
818 | if (handle->h_transaction->t_state == T_LOCKED) { | 957 | if (handle->h_transaction->t_state == T_LOCKED) { |
819 | /* | 958 | /* |
820 | * Huge direct-io writes can hold off commits for long | 959 | * Huge direct-io writes can hold off commits for long |
@@ -841,18 +980,22 @@ ext3_direct_io_get_blocks(struct inode *inode, sector_t iblock, | |||
841 | } | 980 | } |
842 | 981 | ||
843 | get_block: | 982 | get_block: |
844 | if (ret == 0) | 983 | if (ret == 0) { |
845 | ret = ext3_get_block_handle(handle, inode, iblock, | 984 | ret = ext3_get_blocks_handle(handle, inode, iblock, |
846 | bh_result, create, 0); | 985 | max_blocks, bh_result, create, 0); |
847 | bh_result->b_size = (1 << inode->i_blkbits); | 986 | if (ret > 0) { |
987 | bh_result->b_size = (ret << inode->i_blkbits); | ||
988 | ret = 0; | ||
989 | } | ||
990 | } | ||
848 | return ret; | 991 | return ret; |
849 | } | 992 | } |
850 | 993 | ||
851 | /* | 994 | /* |
852 | * `handle' can be NULL if create is zero | 995 | * `handle' can be NULL if create is zero |
853 | */ | 996 | */ |
854 | struct buffer_head *ext3_getblk(handle_t *handle, struct inode * inode, | 997 | struct buffer_head *ext3_getblk(handle_t *handle, struct inode *inode, |
855 | long block, int create, int * errp) | 998 | long block, int create, int *errp) |
856 | { | 999 | { |
857 | struct buffer_head dummy; | 1000 | struct buffer_head dummy; |
858 | int fatal = 0, err; | 1001 | int fatal = 0, err; |
@@ -862,8 +1005,16 @@ struct buffer_head *ext3_getblk(handle_t *handle, struct inode * inode, | |||
862 | dummy.b_state = 0; | 1005 | dummy.b_state = 0; |
863 | dummy.b_blocknr = -1000; | 1006 | dummy.b_blocknr = -1000; |
864 | buffer_trace_init(&dummy.b_history); | 1007 | buffer_trace_init(&dummy.b_history); |
865 | *errp = ext3_get_block_handle(handle, inode, block, &dummy, create, 1); | 1008 | err = ext3_get_blocks_handle(handle, inode, block, 1, |
866 | if (!*errp && buffer_mapped(&dummy)) { | 1009 | &dummy, create, 1); |
1010 | if (err == 1) { | ||
1011 | err = 0; | ||
1012 | } else if (err >= 0) { | ||
1013 | WARN_ON(1); | ||
1014 | err = -EIO; | ||
1015 | } | ||
1016 | *errp = err; | ||
1017 | if (!err && buffer_mapped(&dummy)) { | ||
867 | struct buffer_head *bh; | 1018 | struct buffer_head *bh; |
868 | bh = sb_getblk(inode->i_sb, dummy.b_blocknr); | 1019 | bh = sb_getblk(inode->i_sb, dummy.b_blocknr); |
869 | if (!bh) { | 1020 | if (!bh) { |
@@ -874,17 +1025,18 @@ struct buffer_head *ext3_getblk(handle_t *handle, struct inode * inode, | |||
874 | J_ASSERT(create != 0); | 1025 | J_ASSERT(create != 0); |
875 | J_ASSERT(handle != 0); | 1026 | J_ASSERT(handle != 0); |
876 | 1027 | ||
877 | /* Now that we do not always journal data, we | 1028 | /* |
878 | should keep in mind whether this should | 1029 | * Now that we do not always journal data, we should |
879 | always journal the new buffer as metadata. | 1030 | * keep in mind whether this should always journal the |
880 | For now, regular file writes use | 1031 | * new buffer as metadata. For now, regular file |
881 | ext3_get_block instead, so it's not a | 1032 | * writes use ext3_get_block instead, so it's not a |
882 | problem. */ | 1033 | * problem. |
1034 | */ | ||
883 | lock_buffer(bh); | 1035 | lock_buffer(bh); |
884 | BUFFER_TRACE(bh, "call get_create_access"); | 1036 | BUFFER_TRACE(bh, "call get_create_access"); |
885 | fatal = ext3_journal_get_create_access(handle, bh); | 1037 | fatal = ext3_journal_get_create_access(handle, bh); |
886 | if (!fatal && !buffer_uptodate(bh)) { | 1038 | if (!fatal && !buffer_uptodate(bh)) { |
887 | memset(bh->b_data, 0, inode->i_sb->s_blocksize); | 1039 | memset(bh->b_data,0,inode->i_sb->s_blocksize); |
888 | set_buffer_uptodate(bh); | 1040 | set_buffer_uptodate(bh); |
889 | } | 1041 | } |
890 | unlock_buffer(bh); | 1042 | unlock_buffer(bh); |
@@ -906,7 +1058,7 @@ err: | |||
906 | return NULL; | 1058 | return NULL; |
907 | } | 1059 | } |
908 | 1060 | ||
909 | struct buffer_head *ext3_bread(handle_t *handle, struct inode * inode, | 1061 | struct buffer_head *ext3_bread(handle_t *handle, struct inode *inode, |
910 | int block, int create, int *err) | 1062 | int block, int create, int *err) |
911 | { | 1063 | { |
912 | struct buffer_head * bh; | 1064 | struct buffer_head * bh; |
@@ -982,9 +1134,8 @@ static int walk_page_buffers( handle_t *handle, | |||
982 | * is elevated. We'll still have enough credits for the tiny quotafile | 1134 | * is elevated. We'll still have enough credits for the tiny quotafile |
983 | * write. | 1135 | * write. |
984 | */ | 1136 | */ |
985 | 1137 | static int do_journal_get_write_access(handle_t *handle, | |
986 | static int do_journal_get_write_access(handle_t *handle, | 1138 | struct buffer_head *bh) |
987 | struct buffer_head *bh) | ||
988 | { | 1139 | { |
989 | if (!buffer_mapped(bh) || buffer_freed(bh)) | 1140 | if (!buffer_mapped(bh) || buffer_freed(bh)) |
990 | return 0; | 1141 | return 0; |
@@ -1025,8 +1176,7 @@ out: | |||
1025 | return ret; | 1176 | return ret; |
1026 | } | 1177 | } |
1027 | 1178 | ||
1028 | int | 1179 | int ext3_journal_dirty_data(handle_t *handle, struct buffer_head *bh) |
1029 | ext3_journal_dirty_data(handle_t *handle, struct buffer_head *bh) | ||
1030 | { | 1180 | { |
1031 | int err = journal_dirty_data(handle, bh); | 1181 | int err = journal_dirty_data(handle, bh); |
1032 | if (err) | 1182 | if (err) |
@@ -1051,7 +1201,6 @@ static int commit_write_fn(handle_t *handle, struct buffer_head *bh) | |||
1051 | * ext3 never places buffers on inode->i_mapping->private_list. metadata | 1201 | * ext3 never places buffers on inode->i_mapping->private_list. metadata |
1052 | * buffers are managed internally. | 1202 | * buffers are managed internally. |
1053 | */ | 1203 | */ |
1054 | |||
1055 | static int ext3_ordered_commit_write(struct file *file, struct page *page, | 1204 | static int ext3_ordered_commit_write(struct file *file, struct page *page, |
1056 | unsigned from, unsigned to) | 1205 | unsigned from, unsigned to) |
1057 | { | 1206 | { |
@@ -1261,7 +1410,7 @@ static int journal_dirty_data_fn(handle_t *handle, struct buffer_head *bh) | |||
1261 | * we don't need to open a transaction here. | 1410 | * we don't need to open a transaction here. |
1262 | */ | 1411 | */ |
1263 | static int ext3_ordered_writepage(struct page *page, | 1412 | static int ext3_ordered_writepage(struct page *page, |
1264 | struct writeback_control *wbc) | 1413 | struct writeback_control *wbc) |
1265 | { | 1414 | { |
1266 | struct inode *inode = page->mapping->host; | 1415 | struct inode *inode = page->mapping->host; |
1267 | struct buffer_head *page_bufs; | 1416 | struct buffer_head *page_bufs; |
@@ -1430,7 +1579,7 @@ ext3_readpages(struct file *file, struct address_space *mapping, | |||
1430 | return mpage_readpages(mapping, pages, nr_pages, ext3_get_block); | 1579 | return mpage_readpages(mapping, pages, nr_pages, ext3_get_block); |
1431 | } | 1580 | } |
1432 | 1581 | ||
1433 | static int ext3_invalidatepage(struct page *page, unsigned long offset) | 1582 | static void ext3_invalidatepage(struct page *page, unsigned long offset) |
1434 | { | 1583 | { |
1435 | journal_t *journal = EXT3_JOURNAL(page->mapping->host); | 1584 | journal_t *journal = EXT3_JOURNAL(page->mapping->host); |
1436 | 1585 | ||
@@ -1440,7 +1589,7 @@ static int ext3_invalidatepage(struct page *page, unsigned long offset) | |||
1440 | if (offset == 0) | 1589 | if (offset == 0) |
1441 | ClearPageChecked(page); | 1590 | ClearPageChecked(page); |
1442 | 1591 | ||
1443 | return journal_invalidatepage(journal, page, offset); | 1592 | journal_invalidatepage(journal, page, offset); |
1444 | } | 1593 | } |
1445 | 1594 | ||
1446 | static int ext3_releasepage(struct page *page, gfp_t wait) | 1595 | static int ext3_releasepage(struct page *page, gfp_t wait) |
@@ -1492,11 +1641,10 @@ static ssize_t ext3_direct_IO(int rw, struct kiocb *iocb, | |||
1492 | 1641 | ||
1493 | ret = blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 1642 | ret = blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
1494 | offset, nr_segs, | 1643 | offset, nr_segs, |
1495 | ext3_direct_io_get_blocks, NULL); | 1644 | ext3_get_block, NULL); |
1496 | 1645 | ||
1497 | /* | 1646 | /* |
1498 | * Reacquire the handle: ext3_direct_io_get_block() can restart the | 1647 | * Reacquire the handle: ext3_get_block() can restart the transaction |
1499 | * transaction | ||
1500 | */ | 1648 | */ |
1501 | handle = journal_current_handle(); | 1649 | handle = journal_current_handle(); |
1502 | 1650 | ||
@@ -1752,11 +1900,8 @@ static inline int all_zeroes(__le32 *p, __le32 *q) | |||
1752 | * c) free the subtrees growing from the inode past the @chain[0]. | 1900 | * c) free the subtrees growing from the inode past the @chain[0]. |
1753 | * (no partially truncated stuff there). */ | 1901 | * (no partially truncated stuff there). */ |
1754 | 1902 | ||
1755 | static Indirect *ext3_find_shared(struct inode *inode, | 1903 | static Indirect *ext3_find_shared(struct inode *inode, int depth, |
1756 | int depth, | 1904 | int offsets[4], Indirect chain[4], __le32 *top) |
1757 | int offsets[4], | ||
1758 | Indirect chain[4], | ||
1759 | __le32 *top) | ||
1760 | { | 1905 | { |
1761 | Indirect *partial, *p; | 1906 | Indirect *partial, *p; |
1762 | int k, err; | 1907 | int k, err; |
@@ -1795,8 +1940,7 @@ static Indirect *ext3_find_shared(struct inode *inode, | |||
1795 | } | 1940 | } |
1796 | /* Writer: end */ | 1941 | /* Writer: end */ |
1797 | 1942 | ||
1798 | while(partial > p) | 1943 | while(partial > p) { |
1799 | { | ||
1800 | brelse(partial->bh); | 1944 | brelse(partial->bh); |
1801 | partial--; | 1945 | partial--; |
1802 | } | 1946 | } |
@@ -1812,10 +1956,9 @@ no_top: | |||
1812 | * We release `count' blocks on disk, but (last - first) may be greater | 1956 | * We release `count' blocks on disk, but (last - first) may be greater |
1813 | * than `count' because there can be holes in there. | 1957 | * than `count' because there can be holes in there. |
1814 | */ | 1958 | */ |
1815 | static void | 1959 | static void ext3_clear_blocks(handle_t *handle, struct inode *inode, |
1816 | ext3_clear_blocks(handle_t *handle, struct inode *inode, struct buffer_head *bh, | 1960 | struct buffer_head *bh, unsigned long block_to_free, |
1817 | unsigned long block_to_free, unsigned long count, | 1961 | unsigned long count, __le32 *first, __le32 *last) |
1818 | __le32 *first, __le32 *last) | ||
1819 | { | 1962 | { |
1820 | __le32 *p; | 1963 | __le32 *p; |
1821 | if (try_to_extend_transaction(handle, inode)) { | 1964 | if (try_to_extend_transaction(handle, inode)) { |
@@ -2076,8 +2219,7 @@ static void ext3_free_branches(handle_t *handle, struct inode *inode, | |||
2076 | * that's fine - as long as they are linked from the inode, the post-crash | 2219 | * that's fine - as long as they are linked from the inode, the post-crash |
2077 | * ext3_truncate() run will find them and release them. | 2220 | * ext3_truncate() run will find them and release them. |
2078 | */ | 2221 | */ |
2079 | 2222 | void ext3_truncate(struct inode *inode) | |
2080 | void ext3_truncate(struct inode * inode) | ||
2081 | { | 2223 | { |
2082 | handle_t *handle; | 2224 | handle_t *handle; |
2083 | struct ext3_inode_info *ei = EXT3_I(inode); | 2225 | struct ext3_inode_info *ei = EXT3_I(inode); |
@@ -2201,29 +2343,26 @@ void ext3_truncate(struct inode * inode) | |||
2201 | do_indirects: | 2343 | do_indirects: |
2202 | /* Kill the remaining (whole) subtrees */ | 2344 | /* Kill the remaining (whole) subtrees */ |
2203 | switch (offsets[0]) { | 2345 | switch (offsets[0]) { |
2204 | default: | 2346 | default: |
2205 | nr = i_data[EXT3_IND_BLOCK]; | 2347 | nr = i_data[EXT3_IND_BLOCK]; |
2206 | if (nr) { | 2348 | if (nr) { |
2207 | ext3_free_branches(handle, inode, NULL, | 2349 | ext3_free_branches(handle, inode, NULL, &nr, &nr+1, 1); |
2208 | &nr, &nr+1, 1); | 2350 | i_data[EXT3_IND_BLOCK] = 0; |
2209 | i_data[EXT3_IND_BLOCK] = 0; | 2351 | } |
2210 | } | 2352 | case EXT3_IND_BLOCK: |
2211 | case EXT3_IND_BLOCK: | 2353 | nr = i_data[EXT3_DIND_BLOCK]; |
2212 | nr = i_data[EXT3_DIND_BLOCK]; | 2354 | if (nr) { |
2213 | if (nr) { | 2355 | ext3_free_branches(handle, inode, NULL, &nr, &nr+1, 2); |
2214 | ext3_free_branches(handle, inode, NULL, | 2356 | i_data[EXT3_DIND_BLOCK] = 0; |
2215 | &nr, &nr+1, 2); | 2357 | } |
2216 | i_data[EXT3_DIND_BLOCK] = 0; | 2358 | case EXT3_DIND_BLOCK: |
2217 | } | 2359 | nr = i_data[EXT3_TIND_BLOCK]; |
2218 | case EXT3_DIND_BLOCK: | 2360 | if (nr) { |
2219 | nr = i_data[EXT3_TIND_BLOCK]; | 2361 | ext3_free_branches(handle, inode, NULL, &nr, &nr+1, 3); |
2220 | if (nr) { | 2362 | i_data[EXT3_TIND_BLOCK] = 0; |
2221 | ext3_free_branches(handle, inode, NULL, | 2363 | } |
2222 | &nr, &nr+1, 3); | 2364 | case EXT3_TIND_BLOCK: |
2223 | i_data[EXT3_TIND_BLOCK] = 0; | 2365 | ; |
2224 | } | ||
2225 | case EXT3_TIND_BLOCK: | ||
2226 | ; | ||
2227 | } | 2366 | } |
2228 | 2367 | ||
2229 | ext3_discard_reservation(inode); | 2368 | ext3_discard_reservation(inode); |
@@ -2232,8 +2371,10 @@ do_indirects: | |||
2232 | inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC; | 2371 | inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC; |
2233 | ext3_mark_inode_dirty(handle, inode); | 2372 | ext3_mark_inode_dirty(handle, inode); |
2234 | 2373 | ||
2235 | /* In a multi-transaction truncate, we only make the final | 2374 | /* |
2236 | * transaction synchronous */ | 2375 | * In a multi-transaction truncate, we only make the final transaction |
2376 | * synchronous | ||
2377 | */ | ||
2237 | if (IS_SYNC(inode)) | 2378 | if (IS_SYNC(inode)) |
2238 | handle->h_sync = 1; | 2379 | handle->h_sync = 1; |
2239 | out_stop: | 2380 | out_stop: |
@@ -2259,20 +2400,16 @@ static unsigned long ext3_get_inode_block(struct super_block *sb, | |||
2259 | struct ext3_group_desc * gdp; | 2400 | struct ext3_group_desc * gdp; |
2260 | 2401 | ||
2261 | 2402 | ||
2262 | if ((ino != EXT3_ROOT_INO && | 2403 | if ((ino != EXT3_ROOT_INO && ino != EXT3_JOURNAL_INO && |
2263 | ino != EXT3_JOURNAL_INO && | 2404 | ino != EXT3_RESIZE_INO && ino < EXT3_FIRST_INO(sb)) || |
2264 | ino != EXT3_RESIZE_INO && | 2405 | ino > le32_to_cpu(EXT3_SB(sb)->s_es->s_inodes_count)) { |
2265 | ino < EXT3_FIRST_INO(sb)) || | 2406 | ext3_error(sb, "ext3_get_inode_block", |
2266 | ino > le32_to_cpu( | ||
2267 | EXT3_SB(sb)->s_es->s_inodes_count)) { | ||
2268 | ext3_error (sb, "ext3_get_inode_block", | ||
2269 | "bad inode number: %lu", ino); | 2407 | "bad inode number: %lu", ino); |
2270 | return 0; | 2408 | return 0; |
2271 | } | 2409 | } |
2272 | block_group = (ino - 1) / EXT3_INODES_PER_GROUP(sb); | 2410 | block_group = (ino - 1) / EXT3_INODES_PER_GROUP(sb); |
2273 | if (block_group >= EXT3_SB(sb)->s_groups_count) { | 2411 | if (block_group >= EXT3_SB(sb)->s_groups_count) { |
2274 | ext3_error (sb, "ext3_get_inode_block", | 2412 | ext3_error(sb,"ext3_get_inode_block","group >= groups count"); |
2275 | "group >= groups count"); | ||
2276 | return 0; | 2413 | return 0; |
2277 | } | 2414 | } |
2278 | smp_rmb(); | 2415 | smp_rmb(); |
@@ -2285,7 +2422,7 @@ static unsigned long ext3_get_inode_block(struct super_block *sb, | |||
2285 | return 0; | 2422 | return 0; |
2286 | } | 2423 | } |
2287 | 2424 | ||
2288 | gdp = (struct ext3_group_desc *) bh->b_data; | 2425 | gdp = (struct ext3_group_desc *)bh->b_data; |
2289 | /* | 2426 | /* |
2290 | * Figure out the offset within the block group inode table | 2427 | * Figure out the offset within the block group inode table |
2291 | */ | 2428 | */ |
@@ -2834,7 +2971,7 @@ err_out: | |||
2834 | 2971 | ||
2835 | 2972 | ||
2836 | /* | 2973 | /* |
2837 | * akpm: how many blocks doth make a writepage()? | 2974 | * How many blocks doth make a writepage()? |
2838 | * | 2975 | * |
2839 | * With N blocks per page, it may be: | 2976 | * With N blocks per page, it may be: |
2840 | * N data blocks | 2977 | * N data blocks |
@@ -2924,8 +3061,8 @@ ext3_reserve_inode_write(handle_t *handle, struct inode *inode, | |||
2924 | } | 3061 | } |
2925 | 3062 | ||
2926 | /* | 3063 | /* |
2927 | * akpm: What we do here is to mark the in-core inode as clean | 3064 | * What we do here is to mark the in-core inode as clean with respect to inode |
2928 | * with respect to inode dirtiness (it may still be data-dirty). | 3065 | * dirtiness (it may still be data-dirty). |
2929 | * This means that the in-core inode may be reaped by prune_icache | 3066 | * This means that the in-core inode may be reaped by prune_icache |
2930 | * without having to perform any I/O. This is a very good thing, | 3067 | * without having to perform any I/O. This is a very good thing, |
2931 | * because *any* task may call prune_icache - even ones which | 3068 | * because *any* task may call prune_icache - even ones which |
@@ -2957,7 +3094,7 @@ int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
2957 | } | 3094 | } |
2958 | 3095 | ||
2959 | /* | 3096 | /* |
2960 | * akpm: ext3_dirty_inode() is called from __mark_inode_dirty() | 3097 | * ext3_dirty_inode() is called from __mark_inode_dirty() |
2961 | * | 3098 | * |
2962 | * We're really interested in the case where a file is being extended. | 3099 | * We're really interested in the case where a file is being extended. |
2963 | * i_size has been changed by generic_commit_write() and we thus need | 3100 | * i_size has been changed by generic_commit_write() and we thus need |
@@ -2993,7 +3130,7 @@ out: | |||
2993 | return; | 3130 | return; |
2994 | } | 3131 | } |
2995 | 3132 | ||
2996 | #ifdef AKPM | 3133 | #if 0 |
2997 | /* | 3134 | /* |
2998 | * Bind an inode's backing buffer_head into this transaction, to prevent | 3135 | * Bind an inode's backing buffer_head into this transaction, to prevent |
2999 | * it from being flushed to disk early. Unlike | 3136 | * it from being flushed to disk early. Unlike |
@@ -3001,8 +3138,7 @@ out: | |||
3001 | * returns no iloc structure, so the caller needs to repeat the iloc | 3138 | * returns no iloc structure, so the caller needs to repeat the iloc |
3002 | * lookup to mark the inode dirty later. | 3139 | * lookup to mark the inode dirty later. |
3003 | */ | 3140 | */ |
3004 | static inline int | 3141 | static int ext3_pin_inode(handle_t *handle, struct inode *inode) |
3005 | ext3_pin_inode(handle_t *handle, struct inode *inode) | ||
3006 | { | 3142 | { |
3007 | struct ext3_iloc iloc; | 3143 | struct ext3_iloc iloc; |
3008 | 3144 | ||
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 86e443182de4..f8a5266ea1ff 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -1678,12 +1678,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
1678 | } | 1678 | } |
1679 | 1679 | ||
1680 | if (test_opt(sb, NOBH)) { | 1680 | if (test_opt(sb, NOBH)) { |
1681 | if (sb->s_blocksize_bits != PAGE_CACHE_SHIFT) { | ||
1682 | printk(KERN_WARNING "EXT3-fs: Ignoring nobh option " | ||
1683 | "since filesystem blocksize doesn't match " | ||
1684 | "pagesize\n"); | ||
1685 | clear_opt(sbi->s_mount_opt, NOBH); | ||
1686 | } | ||
1687 | if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { | 1681 | if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { |
1688 | printk(KERN_WARNING "EXT3-fs: Ignoring nobh option - " | 1682 | printk(KERN_WARNING "EXT3-fs: Ignoring nobh option - " |
1689 | "its supported only with writeback mode\n"); | 1683 | "its supported only with writeback mode\n"); |
diff --git a/fs/fat/dir.c b/fs/fat/dir.c index 4095bc149eb1..698b85bb1dd4 100644 --- a/fs/fat/dir.c +++ b/fs/fat/dir.c | |||
@@ -741,7 +741,7 @@ static int fat_dir_ioctl(struct inode * inode, struct file * filp, | |||
741 | return ret; | 741 | return ret; |
742 | } | 742 | } |
743 | 743 | ||
744 | struct file_operations fat_dir_operations = { | 744 | const struct file_operations fat_dir_operations = { |
745 | .read = generic_read_dir, | 745 | .read = generic_read_dir, |
746 | .readdir = fat_readdir, | 746 | .readdir = fat_readdir, |
747 | .ioctl = fat_dir_ioctl, | 747 | .ioctl = fat_dir_ioctl, |
diff --git a/fs/fat/file.c b/fs/fat/file.c index 88aa1ae13f9f..1ee25232e6af 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c | |||
@@ -112,7 +112,7 @@ int fat_generic_ioctl(struct inode *inode, struct file *filp, | |||
112 | } | 112 | } |
113 | } | 113 | } |
114 | 114 | ||
115 | struct file_operations fat_file_operations = { | 115 | const struct file_operations fat_file_operations = { |
116 | .llseek = generic_file_llseek, | 116 | .llseek = generic_file_llseek, |
117 | .read = do_sync_read, | 117 | .read = do_sync_read, |
118 | .write = do_sync_write, | 118 | .write = do_sync_write, |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 297300fe81c2..c1ce284f8a94 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -101,11 +101,11 @@ static int __fat_get_blocks(struct inode *inode, sector_t iblock, | |||
101 | } | 101 | } |
102 | 102 | ||
103 | static int fat_get_blocks(struct inode *inode, sector_t iblock, | 103 | static int fat_get_blocks(struct inode *inode, sector_t iblock, |
104 | unsigned long max_blocks, | ||
105 | struct buffer_head *bh_result, int create) | 104 | struct buffer_head *bh_result, int create) |
106 | { | 105 | { |
107 | struct super_block *sb = inode->i_sb; | 106 | struct super_block *sb = inode->i_sb; |
108 | int err; | 107 | int err; |
108 | unsigned long max_blocks = bh_result->b_size >> inode->i_blkbits; | ||
109 | 109 | ||
110 | err = __fat_get_blocks(inode, iblock, &max_blocks, bh_result, create); | 110 | err = __fat_get_blocks(inode, iblock, &max_blocks, bh_result, create); |
111 | if (err) | 111 | if (err) |
@@ -1435,9 +1435,6 @@ out_fail: | |||
1435 | 1435 | ||
1436 | EXPORT_SYMBOL_GPL(fat_fill_super); | 1436 | EXPORT_SYMBOL_GPL(fat_fill_super); |
1437 | 1437 | ||
1438 | int __init fat_cache_init(void); | ||
1439 | void fat_cache_destroy(void); | ||
1440 | |||
1441 | static int __init init_fat_fs(void) | 1438 | static int __init init_fat_fs(void) |
1442 | { | 1439 | { |
1443 | int err; | 1440 | int err; |
diff --git a/fs/fcntl.c b/fs/fcntl.c index 03c789560fb8..2a2479196f96 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c | |||
@@ -412,7 +412,7 @@ out: | |||
412 | 412 | ||
413 | /* Table to convert sigio signal codes into poll band bitmaps */ | 413 | /* Table to convert sigio signal codes into poll band bitmaps */ |
414 | 414 | ||
415 | static long band_table[NSIGPOLL] = { | 415 | static const long band_table[NSIGPOLL] = { |
416 | POLLIN | POLLRDNORM, /* POLL_IN */ | 416 | POLLIN | POLLRDNORM, /* POLL_IN */ |
417 | POLLOUT | POLLWRNORM | POLLWRBAND, /* POLL_OUT */ | 417 | POLLOUT | POLLWRNORM | POLLWRBAND, /* POLL_OUT */ |
418 | POLLIN | POLLRDNORM | POLLMSG, /* POLL_MSG */ | 418 | POLLIN | POLLRDNORM | POLLMSG, /* POLL_MSG */ |
@@ -531,7 +531,7 @@ int send_sigurg(struct fown_struct *fown) | |||
531 | } | 531 | } |
532 | 532 | ||
533 | static DEFINE_RWLOCK(fasync_lock); | 533 | static DEFINE_RWLOCK(fasync_lock); |
534 | static kmem_cache_t *fasync_cache; | 534 | static kmem_cache_t *fasync_cache __read_mostly; |
535 | 535 | ||
536 | /* | 536 | /* |
537 | * fasync_helper() is used by some character device drivers (mainly mice) | 537 | * fasync_helper() is used by some character device drivers (mainly mice) |
@@ -145,6 +145,6 @@ err_nocleanup: | |||
145 | * is contain the open that then fills in the correct operations | 145 | * is contain the open that then fills in the correct operations |
146 | * depending on the access mode of the file... | 146 | * depending on the access mode of the file... |
147 | */ | 147 | */ |
148 | struct file_operations def_fifo_fops = { | 148 | const struct file_operations def_fifo_fops = { |
149 | .open = fifo_open, /* will set read or write pipe_fops */ | 149 | .open = fifo_open, /* will set read or write pipe_fops */ |
150 | }; | 150 | }; |
@@ -373,6 +373,6 @@ static void __devinit fdtable_defer_list_init(int cpu) | |||
373 | void __init files_defer_init(void) | 373 | void __init files_defer_init(void) |
374 | { | 374 | { |
375 | int i; | 375 | int i; |
376 | for_each_cpu(i) | 376 | for_each_possible_cpu(i) |
377 | fdtable_defer_list_init(i); | 377 | fdtable_defer_list_init(i); |
378 | } | 378 | } |
diff --git a/fs/freevxfs/vxfs_extern.h b/fs/freevxfs/vxfs_extern.h index 927acf70c591..1cf1fe8466a2 100644 --- a/fs/freevxfs/vxfs_extern.h +++ b/fs/freevxfs/vxfs_extern.h | |||
@@ -63,7 +63,7 @@ extern void vxfs_clear_inode(struct inode *); | |||
63 | 63 | ||
64 | /* vxfs_lookup.c */ | 64 | /* vxfs_lookup.c */ |
65 | extern struct inode_operations vxfs_dir_inode_ops; | 65 | extern struct inode_operations vxfs_dir_inode_ops; |
66 | extern struct file_operations vxfs_dir_operations; | 66 | extern const struct file_operations vxfs_dir_operations; |
67 | 67 | ||
68 | /* vxfs_olt.c */ | 68 | /* vxfs_olt.c */ |
69 | extern int vxfs_read_olt(struct super_block *, u_long); | 69 | extern int vxfs_read_olt(struct super_block *, u_long); |
diff --git a/fs/freevxfs/vxfs_lookup.c b/fs/freevxfs/vxfs_lookup.c index 554eb455722c..29cce456c7ce 100644 --- a/fs/freevxfs/vxfs_lookup.c +++ b/fs/freevxfs/vxfs_lookup.c | |||
@@ -56,7 +56,7 @@ struct inode_operations vxfs_dir_inode_ops = { | |||
56 | .lookup = vxfs_lookup, | 56 | .lookup = vxfs_lookup, |
57 | }; | 57 | }; |
58 | 58 | ||
59 | struct file_operations vxfs_dir_operations = { | 59 | const struct file_operations vxfs_dir_operations = { |
60 | .readdir = vxfs_readdir, | 60 | .readdir = vxfs_readdir, |
61 | }; | 61 | }; |
62 | 62 | ||
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 0c9a2ee54c91..23d1f52eb1b8 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
@@ -922,7 +922,7 @@ static int fuse_dev_release(struct inode *inode, struct file *file) | |||
922 | return 0; | 922 | return 0; |
923 | } | 923 | } |
924 | 924 | ||
925 | struct file_operations fuse_dev_operations = { | 925 | const struct file_operations fuse_dev_operations = { |
926 | .owner = THIS_MODULE, | 926 | .owner = THIS_MODULE, |
927 | .llseek = no_llseek, | 927 | .llseek = no_llseek, |
928 | .read = fuse_dev_read, | 928 | .read = fuse_dev_read, |
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index c72a8a97935c..256355b80256 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c | |||
@@ -1170,7 +1170,7 @@ static struct inode_operations fuse_dir_inode_operations = { | |||
1170 | .removexattr = fuse_removexattr, | 1170 | .removexattr = fuse_removexattr, |
1171 | }; | 1171 | }; |
1172 | 1172 | ||
1173 | static struct file_operations fuse_dir_operations = { | 1173 | static const struct file_operations fuse_dir_operations = { |
1174 | .llseek = generic_file_llseek, | 1174 | .llseek = generic_file_llseek, |
1175 | .read = generic_read_dir, | 1175 | .read = generic_read_dir, |
1176 | .readdir = fuse_readdir, | 1176 | .readdir = fuse_readdir, |
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 6f05379b0a0d..975f2697e866 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
@@ -12,7 +12,7 @@ | |||
12 | #include <linux/slab.h> | 12 | #include <linux/slab.h> |
13 | #include <linux/kernel.h> | 13 | #include <linux/kernel.h> |
14 | 14 | ||
15 | static struct file_operations fuse_direct_io_file_operations; | 15 | static const struct file_operations fuse_direct_io_file_operations; |
16 | 16 | ||
17 | static int fuse_send_open(struct inode *inode, struct file *file, int isdir, | 17 | static int fuse_send_open(struct inode *inode, struct file *file, int isdir, |
18 | struct fuse_open_out *outargp) | 18 | struct fuse_open_out *outargp) |
@@ -611,7 +611,7 @@ static int fuse_set_page_dirty(struct page *page) | |||
611 | return 0; | 611 | return 0; |
612 | } | 612 | } |
613 | 613 | ||
614 | static struct file_operations fuse_file_operations = { | 614 | static const struct file_operations fuse_file_operations = { |
615 | .llseek = generic_file_llseek, | 615 | .llseek = generic_file_llseek, |
616 | .read = generic_file_read, | 616 | .read = generic_file_read, |
617 | .write = generic_file_write, | 617 | .write = generic_file_write, |
@@ -623,7 +623,7 @@ static struct file_operations fuse_file_operations = { | |||
623 | .sendfile = generic_file_sendfile, | 623 | .sendfile = generic_file_sendfile, |
624 | }; | 624 | }; |
625 | 625 | ||
626 | static struct file_operations fuse_direct_io_file_operations = { | 626 | static const struct file_operations fuse_direct_io_file_operations = { |
627 | .llseek = generic_file_llseek, | 627 | .llseek = generic_file_llseek, |
628 | .read = fuse_direct_read, | 628 | .read = fuse_direct_read, |
629 | .write = fuse_direct_write, | 629 | .write = fuse_direct_write, |
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 4a83adfec968..a16a04fcf41e 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h | |||
@@ -346,7 +346,7 @@ static inline u64 get_node_id(struct inode *inode) | |||
346 | } | 346 | } |
347 | 347 | ||
348 | /** Device operations */ | 348 | /** Device operations */ |
349 | extern struct file_operations fuse_dev_operations; | 349 | extern const struct file_operations fuse_dev_operations; |
350 | 350 | ||
351 | /** | 351 | /** |
352 | * This is the single global spinlock which protects FUSE's structures | 352 | * This is the single global spinlock which protects FUSE's structures |
diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index a7a7d77f3fd3..1e44dcfe49c4 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c | |||
@@ -306,8 +306,7 @@ void hfs_bnode_unhash(struct hfs_bnode *node) | |||
306 | for (p = &node->tree->node_hash[hfs_bnode_hash(node->this)]; | 306 | for (p = &node->tree->node_hash[hfs_bnode_hash(node->this)]; |
307 | *p && *p != node; p = &(*p)->next_hash) | 307 | *p && *p != node; p = &(*p)->next_hash) |
308 | ; | 308 | ; |
309 | if (!*p) | 309 | BUG_ON(!*p); |
310 | BUG(); | ||
311 | *p = node->next_hash; | 310 | *p = node->next_hash; |
312 | node->tree->node_hash_cnt--; | 311 | node->tree->node_hash_cnt--; |
313 | } | 312 | } |
@@ -415,8 +414,7 @@ struct hfs_bnode *hfs_bnode_create(struct hfs_btree *tree, u32 num) | |||
415 | spin_lock(&tree->hash_lock); | 414 | spin_lock(&tree->hash_lock); |
416 | node = hfs_bnode_findhash(tree, num); | 415 | node = hfs_bnode_findhash(tree, num); |
417 | spin_unlock(&tree->hash_lock); | 416 | spin_unlock(&tree->hash_lock); |
418 | if (node) | 417 | BUG_ON(node); |
419 | BUG(); | ||
420 | node = __hfs_bnode_create(tree, num); | 418 | node = __hfs_bnode_create(tree, num); |
421 | if (!node) | 419 | if (!node) |
422 | return ERR_PTR(-ENOMEM); | 420 | return ERR_PTR(-ENOMEM); |
@@ -459,8 +457,7 @@ void hfs_bnode_put(struct hfs_bnode *node) | |||
459 | 457 | ||
460 | dprint(DBG_BNODE_REFS, "put_node(%d:%d): %d\n", | 458 | dprint(DBG_BNODE_REFS, "put_node(%d:%d): %d\n", |
461 | node->tree->cnid, node->this, atomic_read(&node->refcnt)); | 459 | node->tree->cnid, node->this, atomic_read(&node->refcnt)); |
462 | if (!atomic_read(&node->refcnt)) | 460 | BUG_ON(!atomic_read(&node->refcnt)); |
463 | BUG(); | ||
464 | if (!atomic_dec_and_lock(&node->refcnt, &tree->hash_lock)) | 461 | if (!atomic_dec_and_lock(&node->refcnt, &tree->hash_lock)) |
465 | return; | 462 | return; |
466 | for (i = 0; i < tree->pages_per_bnode; i++) { | 463 | for (i = 0; i < tree->pages_per_bnode; i++) { |
diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c index 7bb11edd1488..d20131ce4b95 100644 --- a/fs/hfs/btree.c +++ b/fs/hfs/btree.c | |||
@@ -36,8 +36,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
36 | tree->inode = iget_locked(sb, id); | 36 | tree->inode = iget_locked(sb, id); |
37 | if (!tree->inode) | 37 | if (!tree->inode) |
38 | goto free_tree; | 38 | goto free_tree; |
39 | if (!(tree->inode->i_state & I_NEW)) | 39 | BUG_ON(!(tree->inode->i_state & I_NEW)); |
40 | BUG(); | ||
41 | { | 40 | { |
42 | struct hfs_mdb *mdb = HFS_SB(sb)->mdb; | 41 | struct hfs_mdb *mdb = HFS_SB(sb)->mdb; |
43 | HFS_I(tree->inode)->flags = 0; | 42 | HFS_I(tree->inode)->flags = 0; |
diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c index 534e5a7480ef..7cd8cc03aea7 100644 --- a/fs/hfs/dir.c +++ b/fs/hfs/dir.c | |||
@@ -313,7 +313,7 @@ static int hfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
313 | return res; | 313 | return res; |
314 | } | 314 | } |
315 | 315 | ||
316 | struct file_operations hfs_dir_operations = { | 316 | const struct file_operations hfs_dir_operations = { |
317 | .read = generic_read_dir, | 317 | .read = generic_read_dir, |
318 | .readdir = hfs_readdir, | 318 | .readdir = hfs_readdir, |
319 | .llseek = generic_file_llseek, | 319 | .llseek = generic_file_llseek, |
diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 18ce47ab1b71..3ed8663a8db1 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h | |||
@@ -169,7 +169,7 @@ extern int hfs_cat_move(u32, struct inode *, struct qstr *, | |||
169 | extern void hfs_cat_build_key(struct super_block *, btree_key *, u32, struct qstr *); | 169 | extern void hfs_cat_build_key(struct super_block *, btree_key *, u32, struct qstr *); |
170 | 170 | ||
171 | /* dir.c */ | 171 | /* dir.c */ |
172 | extern struct file_operations hfs_dir_operations; | 172 | extern const struct file_operations hfs_dir_operations; |
173 | extern struct inode_operations hfs_dir_inode_operations; | 173 | extern struct inode_operations hfs_dir_inode_operations; |
174 | 174 | ||
175 | /* extent.c */ | 175 | /* extent.c */ |
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index 39fd85b9b916..2d4ced22201b 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c | |||
@@ -17,7 +17,7 @@ | |||
17 | #include "hfs_fs.h" | 17 | #include "hfs_fs.h" |
18 | #include "btree.h" | 18 | #include "btree.h" |
19 | 19 | ||
20 | static struct file_operations hfs_file_operations; | 20 | static const struct file_operations hfs_file_operations; |
21 | static struct inode_operations hfs_file_inode_operations; | 21 | static struct inode_operations hfs_file_inode_operations; |
22 | 22 | ||
23 | /*================ Variable-like macros ================*/ | 23 | /*================ Variable-like macros ================*/ |
@@ -98,17 +98,6 @@ static int hfs_releasepage(struct page *page, gfp_t mask) | |||
98 | return res ? try_to_free_buffers(page) : 0; | 98 | return res ? try_to_free_buffers(page) : 0; |
99 | } | 99 | } |
100 | 100 | ||
101 | static int hfs_get_blocks(struct inode *inode, sector_t iblock, unsigned long max_blocks, | ||
102 | struct buffer_head *bh_result, int create) | ||
103 | { | ||
104 | int ret; | ||
105 | |||
106 | ret = hfs_get_block(inode, iblock, bh_result, create); | ||
107 | if (!ret) | ||
108 | bh_result->b_size = (1 << inode->i_blkbits); | ||
109 | return ret; | ||
110 | } | ||
111 | |||
112 | static ssize_t hfs_direct_IO(int rw, struct kiocb *iocb, | 101 | static ssize_t hfs_direct_IO(int rw, struct kiocb *iocb, |
113 | const struct iovec *iov, loff_t offset, unsigned long nr_segs) | 102 | const struct iovec *iov, loff_t offset, unsigned long nr_segs) |
114 | { | 103 | { |
@@ -116,7 +105,7 @@ static ssize_t hfs_direct_IO(int rw, struct kiocb *iocb, | |||
116 | struct inode *inode = file->f_dentry->d_inode->i_mapping->host; | 105 | struct inode *inode = file->f_dentry->d_inode->i_mapping->host; |
117 | 106 | ||
118 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 107 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
119 | offset, nr_segs, hfs_get_blocks, NULL); | 108 | offset, nr_segs, hfs_get_block, NULL); |
120 | } | 109 | } |
121 | 110 | ||
122 | static int hfs_writepages(struct address_space *mapping, | 111 | static int hfs_writepages(struct address_space *mapping, |
@@ -612,7 +601,7 @@ int hfs_inode_setattr(struct dentry *dentry, struct iattr * attr) | |||
612 | } | 601 | } |
613 | 602 | ||
614 | 603 | ||
615 | static struct file_operations hfs_file_operations = { | 604 | static const struct file_operations hfs_file_operations = { |
616 | .llseek = generic_file_llseek, | 605 | .llseek = generic_file_llseek, |
617 | .read = generic_file_read, | 606 | .read = generic_file_read, |
618 | .write = generic_file_write, | 607 | .write = generic_file_write, |
diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c index 01a6fe3a395c..1f9ece0de326 100644 --- a/fs/hfsplus/dir.c +++ b/fs/hfsplus/dir.c | |||
@@ -483,7 +483,7 @@ struct inode_operations hfsplus_dir_inode_operations = { | |||
483 | .rename = hfsplus_rename, | 483 | .rename = hfsplus_rename, |
484 | }; | 484 | }; |
485 | 485 | ||
486 | struct file_operations hfsplus_dir_operations = { | 486 | const struct file_operations hfsplus_dir_operations = { |
487 | .read = generic_read_dir, | 487 | .read = generic_read_dir, |
488 | .readdir = hfsplus_readdir, | 488 | .readdir = hfsplus_readdir, |
489 | .ioctl = hfsplus_ioctl, | 489 | .ioctl = hfsplus_ioctl, |
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index 12ed2b7d046b..acf66dba3e01 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c | |||
@@ -93,17 +93,6 @@ static int hfsplus_releasepage(struct page *page, gfp_t mask) | |||
93 | return res ? try_to_free_buffers(page) : 0; | 93 | return res ? try_to_free_buffers(page) : 0; |
94 | } | 94 | } |
95 | 95 | ||
96 | static int hfsplus_get_blocks(struct inode *inode, sector_t iblock, unsigned long max_blocks, | ||
97 | struct buffer_head *bh_result, int create) | ||
98 | { | ||
99 | int ret; | ||
100 | |||
101 | ret = hfsplus_get_block(inode, iblock, bh_result, create); | ||
102 | if (!ret) | ||
103 | bh_result->b_size = (1 << inode->i_blkbits); | ||
104 | return ret; | ||
105 | } | ||
106 | |||
107 | static ssize_t hfsplus_direct_IO(int rw, struct kiocb *iocb, | 96 | static ssize_t hfsplus_direct_IO(int rw, struct kiocb *iocb, |
108 | const struct iovec *iov, loff_t offset, unsigned long nr_segs) | 97 | const struct iovec *iov, loff_t offset, unsigned long nr_segs) |
109 | { | 98 | { |
@@ -111,7 +100,7 @@ static ssize_t hfsplus_direct_IO(int rw, struct kiocb *iocb, | |||
111 | struct inode *inode = file->f_dentry->d_inode->i_mapping->host; | 100 | struct inode *inode = file->f_dentry->d_inode->i_mapping->host; |
112 | 101 | ||
113 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 102 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
114 | offset, nr_segs, hfsplus_get_blocks, NULL); | 103 | offset, nr_segs, hfsplus_get_block, NULL); |
115 | } | 104 | } |
116 | 105 | ||
117 | static int hfsplus_writepages(struct address_space *mapping, | 106 | static int hfsplus_writepages(struct address_space *mapping, |
@@ -291,7 +280,7 @@ static struct inode_operations hfsplus_file_inode_operations = { | |||
291 | .listxattr = hfsplus_listxattr, | 280 | .listxattr = hfsplus_listxattr, |
292 | }; | 281 | }; |
293 | 282 | ||
294 | static struct file_operations hfsplus_file_operations = { | 283 | static const struct file_operations hfsplus_file_operations = { |
295 | .llseek = generic_file_llseek, | 284 | .llseek = generic_file_llseek, |
296 | .read = generic_file_read, | 285 | .read = generic_file_read, |
297 | .write = generic_file_write, | 286 | .write = generic_file_write, |
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index b3ad0bd0312f..bf0f8e16e433 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c | |||
@@ -384,7 +384,7 @@ int hostfs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
384 | return fsync_file(HOSTFS_I(dentry->d_inode)->fd, datasync); | 384 | return fsync_file(HOSTFS_I(dentry->d_inode)->fd, datasync); |
385 | } | 385 | } |
386 | 386 | ||
387 | static struct file_operations hostfs_file_fops = { | 387 | static const struct file_operations hostfs_file_fops = { |
388 | .llseek = generic_file_llseek, | 388 | .llseek = generic_file_llseek, |
389 | .read = generic_file_read, | 389 | .read = generic_file_read, |
390 | .sendfile = generic_file_sendfile, | 390 | .sendfile = generic_file_sendfile, |
@@ -399,7 +399,7 @@ static struct file_operations hostfs_file_fops = { | |||
399 | .fsync = hostfs_fsync, | 399 | .fsync = hostfs_fsync, |
400 | }; | 400 | }; |
401 | 401 | ||
402 | static struct file_operations hostfs_dir_fops = { | 402 | static const struct file_operations hostfs_dir_fops = { |
403 | .llseek = generic_file_llseek, | 403 | .llseek = generic_file_llseek, |
404 | .readdir = hostfs_readdir, | 404 | .readdir = hostfs_readdir, |
405 | .read = generic_read_dir, | 405 | .read = generic_read_dir, |
diff --git a/fs/hostfs/hostfs_user.c b/fs/hostfs/hostfs_user.c index b97809deba66..23b7cee72123 100644 --- a/fs/hostfs/hostfs_user.c +++ b/fs/hostfs/hostfs_user.c | |||
@@ -360,7 +360,6 @@ int do_statfs(char *root, long *bsize_out, long long *blocks_out, | |||
360 | spare_out[2] = buf.f_spare[2]; | 360 | spare_out[2] = buf.f_spare[2]; |
361 | spare_out[3] = buf.f_spare[3]; | 361 | spare_out[3] = buf.f_spare[3]; |
362 | spare_out[4] = buf.f_spare[4]; | 362 | spare_out[4] = buf.f_spare[4]; |
363 | spare_out[5] = buf.f_spare[5]; | ||
364 | return(0); | 363 | return(0); |
365 | } | 364 | } |
366 | 365 | ||
diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index 5591f9623aa2..ecc9180645ae 100644 --- a/fs/hpfs/dir.c +++ b/fs/hpfs/dir.c | |||
@@ -310,7 +310,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
310 | return ERR_PTR(-ENOENT); | 310 | return ERR_PTR(-ENOENT); |
311 | } | 311 | } |
312 | 312 | ||
313 | struct file_operations hpfs_dir_ops = | 313 | const struct file_operations hpfs_dir_ops = |
314 | { | 314 | { |
315 | .llseek = hpfs_dir_lseek, | 315 | .llseek = hpfs_dir_lseek, |
316 | .read = generic_read_dir, | 316 | .read = generic_read_dir, |
diff --git a/fs/hpfs/file.c b/fs/hpfs/file.c index 7c995ac4081b..d3b9fffe45a1 100644 --- a/fs/hpfs/file.c +++ b/fs/hpfs/file.c | |||
@@ -119,7 +119,7 @@ static ssize_t hpfs_file_write(struct file *file, const char __user *buf, | |||
119 | return retval; | 119 | return retval; |
120 | } | 120 | } |
121 | 121 | ||
122 | struct file_operations hpfs_file_ops = | 122 | const struct file_operations hpfs_file_ops = |
123 | { | 123 | { |
124 | .llseek = generic_file_llseek, | 124 | .llseek = generic_file_llseek, |
125 | .read = generic_file_read, | 125 | .read = generic_file_read, |
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index 4c6473ab3b34..29b7a3e55173 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h | |||
@@ -240,7 +240,7 @@ void hpfs_set_dentry_operations(struct dentry *); | |||
240 | /* dir.c */ | 240 | /* dir.c */ |
241 | 241 | ||
242 | struct dentry *hpfs_lookup(struct inode *, struct dentry *, struct nameidata *); | 242 | struct dentry *hpfs_lookup(struct inode *, struct dentry *, struct nameidata *); |
243 | extern struct file_operations hpfs_dir_ops; | 243 | extern const struct file_operations hpfs_dir_ops; |
244 | 244 | ||
245 | /* dnode.c */ | 245 | /* dnode.c */ |
246 | 246 | ||
@@ -266,7 +266,7 @@ void hpfs_set_ea(struct inode *, struct fnode *, char *, char *, int); | |||
266 | /* file.c */ | 266 | /* file.c */ |
267 | 267 | ||
268 | int hpfs_file_fsync(struct file *, struct dentry *, int); | 268 | int hpfs_file_fsync(struct file *, struct dentry *, int); |
269 | extern struct file_operations hpfs_file_ops; | 269 | extern const struct file_operations hpfs_file_ops; |
270 | extern struct inode_operations hpfs_file_iops; | 270 | extern struct inode_operations hpfs_file_iops; |
271 | extern struct address_space_operations hpfs_aops; | 271 | extern struct address_space_operations hpfs_aops; |
272 | 272 | ||
diff --git a/fs/hppfs/hppfs_kern.c b/fs/hppfs/hppfs_kern.c index a44dc5897399..2ba20cdb5baa 100644 --- a/fs/hppfs/hppfs_kern.c +++ b/fs/hppfs/hppfs_kern.c | |||
@@ -558,7 +558,7 @@ static loff_t hppfs_llseek(struct file *file, loff_t off, int where) | |||
558 | return(default_llseek(file, off, where)); | 558 | return(default_llseek(file, off, where)); |
559 | } | 559 | } |
560 | 560 | ||
561 | static struct file_operations hppfs_file_fops = { | 561 | static const struct file_operations hppfs_file_fops = { |
562 | .owner = NULL, | 562 | .owner = NULL, |
563 | .llseek = hppfs_llseek, | 563 | .llseek = hppfs_llseek, |
564 | .read = hppfs_read, | 564 | .read = hppfs_read, |
@@ -609,7 +609,7 @@ static int hppfs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
609 | return(0); | 609 | return(0); |
610 | } | 610 | } |
611 | 611 | ||
612 | static struct file_operations hppfs_dir_fops = { | 612 | static const struct file_operations hppfs_dir_fops = { |
613 | .owner = NULL, | 613 | .owner = NULL, |
614 | .readdir = hppfs_readdir, | 614 | .readdir = hppfs_readdir, |
615 | .open = hppfs_dir_open, | 615 | .open = hppfs_dir_open, |
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 25fa8bba8cb5..3a5b4e923455 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c | |||
@@ -35,7 +35,7 @@ | |||
35 | 35 | ||
36 | static struct super_operations hugetlbfs_ops; | 36 | static struct super_operations hugetlbfs_ops; |
37 | static struct address_space_operations hugetlbfs_aops; | 37 | static struct address_space_operations hugetlbfs_aops; |
38 | struct file_operations hugetlbfs_file_operations; | 38 | const struct file_operations hugetlbfs_file_operations; |
39 | static struct inode_operations hugetlbfs_dir_inode_operations; | 39 | static struct inode_operations hugetlbfs_dir_inode_operations; |
40 | static struct inode_operations hugetlbfs_inode_operations; | 40 | static struct inode_operations hugetlbfs_inode_operations; |
41 | 41 | ||
@@ -566,7 +566,7 @@ static void init_once(void *foo, kmem_cache_t *cachep, unsigned long flags) | |||
566 | inode_init_once(&ei->vfs_inode); | 566 | inode_init_once(&ei->vfs_inode); |
567 | } | 567 | } |
568 | 568 | ||
569 | struct file_operations hugetlbfs_file_operations = { | 569 | const struct file_operations hugetlbfs_file_operations = { |
570 | .mmap = hugetlbfs_file_mmap, | 570 | .mmap = hugetlbfs_file_mmap, |
571 | .fsync = simple_sync_file, | 571 | .fsync = simple_sync_file, |
572 | .get_unmapped_area = hugetlb_get_unmapped_area, | 572 | .get_unmapped_area = hugetlb_get_unmapped_area, |
diff --git a/fs/inode.c b/fs/inode.c index 85da11044adc..32b7c3375021 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
@@ -56,8 +56,8 @@ | |||
56 | #define I_HASHBITS i_hash_shift | 56 | #define I_HASHBITS i_hash_shift |
57 | #define I_HASHMASK i_hash_mask | 57 | #define I_HASHMASK i_hash_mask |
58 | 58 | ||
59 | static unsigned int i_hash_mask; | 59 | static unsigned int i_hash_mask __read_mostly; |
60 | static unsigned int i_hash_shift; | 60 | static unsigned int i_hash_shift __read_mostly; |
61 | 61 | ||
62 | /* | 62 | /* |
63 | * Each inode can be on two separate lists. One is | 63 | * Each inode can be on two separate lists. One is |
@@ -73,7 +73,7 @@ static unsigned int i_hash_shift; | |||
73 | 73 | ||
74 | LIST_HEAD(inode_in_use); | 74 | LIST_HEAD(inode_in_use); |
75 | LIST_HEAD(inode_unused); | 75 | LIST_HEAD(inode_unused); |
76 | static struct hlist_head *inode_hashtable; | 76 | static struct hlist_head *inode_hashtable __read_mostly; |
77 | 77 | ||
78 | /* | 78 | /* |
79 | * A simple spinlock to protect the list manipulations. | 79 | * A simple spinlock to protect the list manipulations. |
@@ -98,13 +98,13 @@ static DEFINE_MUTEX(iprune_mutex); | |||
98 | */ | 98 | */ |
99 | struct inodes_stat_t inodes_stat; | 99 | struct inodes_stat_t inodes_stat; |
100 | 100 | ||
101 | static kmem_cache_t * inode_cachep; | 101 | static kmem_cache_t * inode_cachep __read_mostly; |
102 | 102 | ||
103 | static struct inode *alloc_inode(struct super_block *sb) | 103 | static struct inode *alloc_inode(struct super_block *sb) |
104 | { | 104 | { |
105 | static struct address_space_operations empty_aops; | 105 | static struct address_space_operations empty_aops; |
106 | static struct inode_operations empty_iops; | 106 | static struct inode_operations empty_iops; |
107 | static struct file_operations empty_fops; | 107 | static const struct file_operations empty_fops; |
108 | struct inode *inode; | 108 | struct inode *inode; |
109 | 109 | ||
110 | if (sb->s_op->alloc_inode) | 110 | if (sb->s_op->alloc_inode) |
diff --git a/fs/inotify.c b/fs/inotify.c index a61e93e17853..367c487c014b 100644 --- a/fs/inotify.c +++ b/fs/inotify.c | |||
@@ -39,15 +39,15 @@ | |||
39 | 39 | ||
40 | static atomic_t inotify_cookie; | 40 | static atomic_t inotify_cookie; |
41 | 41 | ||
42 | static kmem_cache_t *watch_cachep; | 42 | static kmem_cache_t *watch_cachep __read_mostly; |
43 | static kmem_cache_t *event_cachep; | 43 | static kmem_cache_t *event_cachep __read_mostly; |
44 | 44 | ||
45 | static struct vfsmount *inotify_mnt; | 45 | static struct vfsmount *inotify_mnt __read_mostly; |
46 | 46 | ||
47 | /* these are configurable via /proc/sys/fs/inotify/ */ | 47 | /* these are configurable via /proc/sys/fs/inotify/ */ |
48 | int inotify_max_user_instances; | 48 | int inotify_max_user_instances __read_mostly; |
49 | int inotify_max_user_watches; | 49 | int inotify_max_user_watches __read_mostly; |
50 | int inotify_max_queued_events; | 50 | int inotify_max_queued_events __read_mostly; |
51 | 51 | ||
52 | /* | 52 | /* |
53 | * Lock ordering: | 53 | * Lock ordering: |
@@ -920,7 +920,7 @@ static long inotify_ioctl(struct file *file, unsigned int cmd, | |||
920 | return ret; | 920 | return ret; |
921 | } | 921 | } |
922 | 922 | ||
923 | static struct file_operations inotify_fops = { | 923 | static const struct file_operations inotify_fops = { |
924 | .poll = inotify_poll, | 924 | .poll = inotify_poll, |
925 | .read = inotify_read, | 925 | .read = inotify_read, |
926 | .release = inotify_release, | 926 | .release = inotify_release, |
diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c index 7901ac9f97ab..5440ea292c69 100644 --- a/fs/isofs/dir.c +++ b/fs/isofs/dir.c | |||
@@ -16,7 +16,7 @@ | |||
16 | 16 | ||
17 | static int isofs_readdir(struct file *, void *, filldir_t); | 17 | static int isofs_readdir(struct file *, void *, filldir_t); |
18 | 18 | ||
19 | struct file_operations isofs_dir_operations = | 19 | const struct file_operations isofs_dir_operations = |
20 | { | 20 | { |
21 | .read = generic_read_dir, | 21 | .read = generic_read_dir, |
22 | .readdir = isofs_readdir, | 22 | .readdir = isofs_readdir, |
diff --git a/fs/isofs/isofs.h b/fs/isofs/isofs.h index 439a19b1bf3e..b87ba066f5e7 100644 --- a/fs/isofs/isofs.h +++ b/fs/isofs/isofs.h | |||
@@ -175,6 +175,6 @@ isofs_normalize_block_and_offset(struct iso_directory_record* de, | |||
175 | } | 175 | } |
176 | 176 | ||
177 | extern struct inode_operations isofs_dir_inode_operations; | 177 | extern struct inode_operations isofs_dir_inode_operations; |
178 | extern struct file_operations isofs_dir_operations; | 178 | extern const struct file_operations isofs_dir_operations; |
179 | extern struct address_space_operations isofs_symlink_aops; | 179 | extern struct address_space_operations isofs_symlink_aops; |
180 | extern struct export_operations isofs_export_ops; | 180 | extern struct export_operations isofs_export_ops; |
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index ada31fa272e3..c609f5034fcd 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c | |||
@@ -1873,16 +1873,15 @@ zap_buffer_unlocked: | |||
1873 | } | 1873 | } |
1874 | 1874 | ||
1875 | /** | 1875 | /** |
1876 | * int journal_invalidatepage() | 1876 | * void journal_invalidatepage() |
1877 | * @journal: journal to use for flush... | 1877 | * @journal: journal to use for flush... |
1878 | * @page: page to flush | 1878 | * @page: page to flush |
1879 | * @offset: length of page to invalidate. | 1879 | * @offset: length of page to invalidate. |
1880 | * | 1880 | * |
1881 | * Reap page buffers containing data after offset in page. | 1881 | * Reap page buffers containing data after offset in page. |
1882 | * | 1882 | * |
1883 | * Return non-zero if the page's buffers were successfully reaped. | ||
1884 | */ | 1883 | */ |
1885 | int journal_invalidatepage(journal_t *journal, | 1884 | void journal_invalidatepage(journal_t *journal, |
1886 | struct page *page, | 1885 | struct page *page, |
1887 | unsigned long offset) | 1886 | unsigned long offset) |
1888 | { | 1887 | { |
@@ -1893,7 +1892,7 @@ int journal_invalidatepage(journal_t *journal, | |||
1893 | if (!PageLocked(page)) | 1892 | if (!PageLocked(page)) |
1894 | BUG(); | 1893 | BUG(); |
1895 | if (!page_has_buffers(page)) | 1894 | if (!page_has_buffers(page)) |
1896 | return 1; | 1895 | return; |
1897 | 1896 | ||
1898 | /* We will potentially be playing with lists other than just the | 1897 | /* We will potentially be playing with lists other than just the |
1899 | * data lists (especially for journaled data mode), so be | 1898 | * data lists (especially for journaled data mode), so be |
@@ -1916,11 +1915,9 @@ int journal_invalidatepage(journal_t *journal, | |||
1916 | } while (bh != head); | 1915 | } while (bh != head); |
1917 | 1916 | ||
1918 | if (!offset) { | 1917 | if (!offset) { |
1919 | if (!may_free || !try_to_free_buffers(page)) | 1918 | if (may_free && try_to_free_buffers(page)) |
1920 | return 0; | 1919 | J_ASSERT(!page_has_buffers(page)); |
1921 | J_ASSERT(!page_has_buffers(page)); | ||
1922 | } | 1920 | } |
1923 | return 1; | ||
1924 | } | 1921 | } |
1925 | 1922 | ||
1926 | /* | 1923 | /* |
diff --git a/fs/jffs/inode-v23.c b/fs/jffs/inode-v23.c index 5a4519e834da..020cc097c539 100644 --- a/fs/jffs/inode-v23.c +++ b/fs/jffs/inode-v23.c | |||
@@ -55,9 +55,9 @@ | |||
55 | static int jffs_remove(struct inode *dir, struct dentry *dentry, int type); | 55 | static int jffs_remove(struct inode *dir, struct dentry *dentry, int type); |
56 | 56 | ||
57 | static struct super_operations jffs_ops; | 57 | static struct super_operations jffs_ops; |
58 | static struct file_operations jffs_file_operations; | 58 | static const struct file_operations jffs_file_operations; |
59 | static struct inode_operations jffs_file_inode_operations; | 59 | static struct inode_operations jffs_file_inode_operations; |
60 | static struct file_operations jffs_dir_operations; | 60 | static const struct file_operations jffs_dir_operations; |
61 | static struct inode_operations jffs_dir_inode_operations; | 61 | static struct inode_operations jffs_dir_inode_operations; |
62 | static struct address_space_operations jffs_address_operations; | 62 | static struct address_space_operations jffs_address_operations; |
63 | 63 | ||
@@ -1629,7 +1629,7 @@ static int jffs_fsync(struct file *f, struct dentry *d, int datasync) | |||
1629 | } | 1629 | } |
1630 | 1630 | ||
1631 | 1631 | ||
1632 | static struct file_operations jffs_file_operations = | 1632 | static const struct file_operations jffs_file_operations = |
1633 | { | 1633 | { |
1634 | .open = generic_file_open, | 1634 | .open = generic_file_open, |
1635 | .llseek = generic_file_llseek, | 1635 | .llseek = generic_file_llseek, |
@@ -1649,7 +1649,7 @@ static struct inode_operations jffs_file_inode_operations = | |||
1649 | }; | 1649 | }; |
1650 | 1650 | ||
1651 | 1651 | ||
1652 | static struct file_operations jffs_dir_operations = | 1652 | static const struct file_operations jffs_dir_operations = |
1653 | { | 1653 | { |
1654 | .readdir = jffs_readdir, | 1654 | .readdir = jffs_readdir, |
1655 | }; | 1655 | }; |
diff --git a/fs/jffs2/compr_zlib.c b/fs/jffs2/compr_zlib.c index 4db8be8e90cc..5c63e0cdcf4c 100644 --- a/fs/jffs2/compr_zlib.c +++ b/fs/jffs2/compr_zlib.c | |||
@@ -33,13 +33,14 @@ | |||
33 | */ | 33 | */ |
34 | #define STREAM_END_SPACE 12 | 34 | #define STREAM_END_SPACE 12 |
35 | 35 | ||
36 | static DECLARE_MUTEX(deflate_sem); | 36 | static DEFINE_MUTEX(deflate_mutex); |
37 | static DECLARE_MUTEX(inflate_sem); | 37 | static DEFINE_MUTEX(inflate_mutex); |
38 | static z_stream inf_strm, def_strm; | 38 | static z_stream inf_strm, def_strm; |
39 | 39 | ||
40 | #ifdef __KERNEL__ /* Linux-only */ | 40 | #ifdef __KERNEL__ /* Linux-only */ |
41 | #include <linux/vmalloc.h> | 41 | #include <linux/vmalloc.h> |
42 | #include <linux/init.h> | 42 | #include <linux/init.h> |
43 | #include <linux/mutex.h> | ||
43 | 44 | ||
44 | static int __init alloc_workspaces(void) | 45 | static int __init alloc_workspaces(void) |
45 | { | 46 | { |
@@ -79,11 +80,11 @@ static int jffs2_zlib_compress(unsigned char *data_in, | |||
79 | if (*dstlen <= STREAM_END_SPACE) | 80 | if (*dstlen <= STREAM_END_SPACE) |
80 | return -1; | 81 | return -1; |
81 | 82 | ||
82 | down(&deflate_sem); | 83 | mutex_lock(&deflate_mutex); |
83 | 84 | ||
84 | if (Z_OK != zlib_deflateInit(&def_strm, 3)) { | 85 | if (Z_OK != zlib_deflateInit(&def_strm, 3)) { |
85 | printk(KERN_WARNING "deflateInit failed\n"); | 86 | printk(KERN_WARNING "deflateInit failed\n"); |
86 | up(&deflate_sem); | 87 | mutex_unlock(&deflate_mutex); |
87 | return -1; | 88 | return -1; |
88 | } | 89 | } |
89 | 90 | ||
@@ -104,7 +105,7 @@ static int jffs2_zlib_compress(unsigned char *data_in, | |||
104 | if (ret != Z_OK) { | 105 | if (ret != Z_OK) { |
105 | D1(printk(KERN_DEBUG "deflate in loop returned %d\n", ret)); | 106 | D1(printk(KERN_DEBUG "deflate in loop returned %d\n", ret)); |
106 | zlib_deflateEnd(&def_strm); | 107 | zlib_deflateEnd(&def_strm); |
107 | up(&deflate_sem); | 108 | mutex_unlock(&deflate_mutex); |
108 | return -1; | 109 | return -1; |
109 | } | 110 | } |
110 | } | 111 | } |
@@ -133,7 +134,7 @@ static int jffs2_zlib_compress(unsigned char *data_in, | |||
133 | *sourcelen = def_strm.total_in; | 134 | *sourcelen = def_strm.total_in; |
134 | ret = 0; | 135 | ret = 0; |
135 | out: | 136 | out: |
136 | up(&deflate_sem); | 137 | mutex_unlock(&deflate_mutex); |
137 | return ret; | 138 | return ret; |
138 | } | 139 | } |
139 | 140 | ||
@@ -145,7 +146,7 @@ static int jffs2_zlib_decompress(unsigned char *data_in, | |||
145 | int ret; | 146 | int ret; |
146 | int wbits = MAX_WBITS; | 147 | int wbits = MAX_WBITS; |
147 | 148 | ||
148 | down(&inflate_sem); | 149 | mutex_lock(&inflate_mutex); |
149 | 150 | ||
150 | inf_strm.next_in = data_in; | 151 | inf_strm.next_in = data_in; |
151 | inf_strm.avail_in = srclen; | 152 | inf_strm.avail_in = srclen; |
@@ -173,7 +174,7 @@ static int jffs2_zlib_decompress(unsigned char *data_in, | |||
173 | 174 | ||
174 | if (Z_OK != zlib_inflateInit2(&inf_strm, wbits)) { | 175 | if (Z_OK != zlib_inflateInit2(&inf_strm, wbits)) { |
175 | printk(KERN_WARNING "inflateInit failed\n"); | 176 | printk(KERN_WARNING "inflateInit failed\n"); |
176 | up(&inflate_sem); | 177 | mutex_unlock(&inflate_mutex); |
177 | return 1; | 178 | return 1; |
178 | } | 179 | } |
179 | 180 | ||
@@ -183,7 +184,7 @@ static int jffs2_zlib_decompress(unsigned char *data_in, | |||
183 | printk(KERN_NOTICE "inflate returned %d\n", ret); | 184 | printk(KERN_NOTICE "inflate returned %d\n", ret); |
184 | } | 185 | } |
185 | zlib_inflateEnd(&inf_strm); | 186 | zlib_inflateEnd(&inf_strm); |
186 | up(&inflate_sem); | 187 | mutex_unlock(&inflate_mutex); |
187 | return 0; | 188 | return 0; |
188 | } | 189 | } |
189 | 190 | ||
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index a7bf9cb2567f..8bc7a5018e40 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c | |||
@@ -37,7 +37,7 @@ static int jffs2_mknod (struct inode *,struct dentry *,int,dev_t); | |||
37 | static int jffs2_rename (struct inode *, struct dentry *, | 37 | static int jffs2_rename (struct inode *, struct dentry *, |
38 | struct inode *, struct dentry *); | 38 | struct inode *, struct dentry *); |
39 | 39 | ||
40 | struct file_operations jffs2_dir_operations = | 40 | const struct file_operations jffs2_dir_operations = |
41 | { | 41 | { |
42 | .read = generic_read_dir, | 42 | .read = generic_read_dir, |
43 | .readdir = jffs2_readdir, | 43 | .readdir = jffs2_readdir, |
diff --git a/fs/jffs2/file.c b/fs/jffs2/file.c index 935f273dc57b..9f4171213e58 100644 --- a/fs/jffs2/file.c +++ b/fs/jffs2/file.c | |||
@@ -38,7 +38,7 @@ int jffs2_fsync(struct file *filp, struct dentry *dentry, int datasync) | |||
38 | return 0; | 38 | return 0; |
39 | } | 39 | } |
40 | 40 | ||
41 | struct file_operations jffs2_file_operations = | 41 | const struct file_operations jffs2_file_operations = |
42 | { | 42 | { |
43 | .llseek = generic_file_llseek, | 43 | .llseek = generic_file_llseek, |
44 | .open = generic_file_open, | 44 | .open = generic_file_open, |
diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h index 59e7a393200c..d307cf548625 100644 --- a/fs/jffs2/os-linux.h +++ b/fs/jffs2/os-linux.h | |||
@@ -159,11 +159,11 @@ void jffs2_stop_garbage_collect_thread(struct jffs2_sb_info *c); | |||
159 | void jffs2_garbage_collect_trigger(struct jffs2_sb_info *c); | 159 | void jffs2_garbage_collect_trigger(struct jffs2_sb_info *c); |
160 | 160 | ||
161 | /* dir.c */ | 161 | /* dir.c */ |
162 | extern struct file_operations jffs2_dir_operations; | 162 | extern const struct file_operations jffs2_dir_operations; |
163 | extern struct inode_operations jffs2_dir_inode_operations; | 163 | extern struct inode_operations jffs2_dir_inode_operations; |
164 | 164 | ||
165 | /* file.c */ | 165 | /* file.c */ |
166 | extern struct file_operations jffs2_file_operations; | 166 | extern const struct file_operations jffs2_file_operations; |
167 | extern struct inode_operations jffs2_file_inode_operations; | 167 | extern struct inode_operations jffs2_file_inode_operations; |
168 | extern struct address_space_operations jffs2_file_address_operations; | 168 | extern struct address_space_operations jffs2_file_address_operations; |
169 | int jffs2_fsync(struct file *, struct dentry *, int); | 169 | int jffs2_fsync(struct file *, struct dentry *, int); |
diff --git a/fs/jfs/file.c b/fs/jfs/file.c index e1ac6e497e2b..1c9745be5ada 100644 --- a/fs/jfs/file.c +++ b/fs/jfs/file.c | |||
@@ -100,7 +100,7 @@ struct inode_operations jfs_file_inode_operations = { | |||
100 | #endif | 100 | #endif |
101 | }; | 101 | }; |
102 | 102 | ||
103 | struct file_operations jfs_file_operations = { | 103 | const struct file_operations jfs_file_operations = { |
104 | .open = jfs_open, | 104 | .open = jfs_open, |
105 | .llseek = generic_file_llseek, | 105 | .llseek = generic_file_llseek, |
106 | .write = generic_file_write, | 106 | .write = generic_file_write, |
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index 51a5fed90cca..04eb78f1252e 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
@@ -258,7 +258,8 @@ jfs_get_blocks(struct inode *ip, sector_t lblock, unsigned long max_blocks, | |||
258 | static int jfs_get_block(struct inode *ip, sector_t lblock, | 258 | static int jfs_get_block(struct inode *ip, sector_t lblock, |
259 | struct buffer_head *bh_result, int create) | 259 | struct buffer_head *bh_result, int create) |
260 | { | 260 | { |
261 | return jfs_get_blocks(ip, lblock, 1, bh_result, create); | 261 | return jfs_get_blocks(ip, lblock, bh_result->b_size >> ip->i_blkbits, |
262 | bh_result, create); | ||
262 | } | 263 | } |
263 | 264 | ||
264 | static int jfs_writepage(struct page *page, struct writeback_control *wbc) | 265 | static int jfs_writepage(struct page *page, struct writeback_control *wbc) |
@@ -301,7 +302,7 @@ static ssize_t jfs_direct_IO(int rw, struct kiocb *iocb, | |||
301 | struct inode *inode = file->f_mapping->host; | 302 | struct inode *inode = file->f_mapping->host; |
302 | 303 | ||
303 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 304 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
304 | offset, nr_segs, jfs_get_blocks, NULL); | 305 | offset, nr_segs, jfs_get_block, NULL); |
305 | } | 306 | } |
306 | 307 | ||
307 | struct address_space_operations jfs_aops = { | 308 | struct address_space_operations jfs_aops = { |
diff --git a/fs/jfs/jfs_inode.h b/fs/jfs/jfs_inode.h index 095d471b9f9a..c30072674464 100644 --- a/fs/jfs/jfs_inode.h +++ b/fs/jfs/jfs_inode.h | |||
@@ -35,9 +35,9 @@ extern void jfs_set_inode_flags(struct inode *); | |||
35 | 35 | ||
36 | extern struct address_space_operations jfs_aops; | 36 | extern struct address_space_operations jfs_aops; |
37 | extern struct inode_operations jfs_dir_inode_operations; | 37 | extern struct inode_operations jfs_dir_inode_operations; |
38 | extern struct file_operations jfs_dir_operations; | 38 | extern const struct file_operations jfs_dir_operations; |
39 | extern struct inode_operations jfs_file_inode_operations; | 39 | extern struct inode_operations jfs_file_inode_operations; |
40 | extern struct file_operations jfs_file_operations; | 40 | extern const struct file_operations jfs_file_operations; |
41 | extern struct inode_operations jfs_symlink_inode_operations; | 41 | extern struct inode_operations jfs_symlink_inode_operations; |
42 | extern struct dentry_operations jfs_ci_dentry_operations; | 42 | extern struct dentry_operations jfs_ci_dentry_operations; |
43 | #endif /* _H_JFS_INODE */ | 43 | #endif /* _H_JFS_INODE */ |
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 0b348b13b551..3315f0b1fbc0 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c | |||
@@ -69,6 +69,7 @@ | |||
69 | #include <linux/bio.h> | 69 | #include <linux/bio.h> |
70 | #include <linux/suspend.h> | 70 | #include <linux/suspend.h> |
71 | #include <linux/delay.h> | 71 | #include <linux/delay.h> |
72 | #include <linux/mutex.h> | ||
72 | #include "jfs_incore.h" | 73 | #include "jfs_incore.h" |
73 | #include "jfs_filsys.h" | 74 | #include "jfs_filsys.h" |
74 | #include "jfs_metapage.h" | 75 | #include "jfs_metapage.h" |
@@ -165,7 +166,7 @@ do { \ | |||
165 | */ | 166 | */ |
166 | static LIST_HEAD(jfs_external_logs); | 167 | static LIST_HEAD(jfs_external_logs); |
167 | static struct jfs_log *dummy_log = NULL; | 168 | static struct jfs_log *dummy_log = NULL; |
168 | static DECLARE_MUTEX(jfs_log_sem); | 169 | static DEFINE_MUTEX(jfs_log_mutex); |
169 | 170 | ||
170 | /* | 171 | /* |
171 | * forward references | 172 | * forward references |
@@ -1085,20 +1086,20 @@ int lmLogOpen(struct super_block *sb) | |||
1085 | if (sbi->mntflag & JFS_INLINELOG) | 1086 | if (sbi->mntflag & JFS_INLINELOG) |
1086 | return open_inline_log(sb); | 1087 | return open_inline_log(sb); |
1087 | 1088 | ||
1088 | down(&jfs_log_sem); | 1089 | mutex_lock(&jfs_log_mutex); |
1089 | list_for_each_entry(log, &jfs_external_logs, journal_list) { | 1090 | list_for_each_entry(log, &jfs_external_logs, journal_list) { |
1090 | if (log->bdev->bd_dev == sbi->logdev) { | 1091 | if (log->bdev->bd_dev == sbi->logdev) { |
1091 | if (memcmp(log->uuid, sbi->loguuid, | 1092 | if (memcmp(log->uuid, sbi->loguuid, |
1092 | sizeof(log->uuid))) { | 1093 | sizeof(log->uuid))) { |
1093 | jfs_warn("wrong uuid on JFS journal\n"); | 1094 | jfs_warn("wrong uuid on JFS journal\n"); |
1094 | up(&jfs_log_sem); | 1095 | mutex_unlock(&jfs_log_mutex); |
1095 | return -EINVAL; | 1096 | return -EINVAL; |
1096 | } | 1097 | } |
1097 | /* | 1098 | /* |
1098 | * add file system to log active file system list | 1099 | * add file system to log active file system list |
1099 | */ | 1100 | */ |
1100 | if ((rc = lmLogFileSystem(log, sbi, 1))) { | 1101 | if ((rc = lmLogFileSystem(log, sbi, 1))) { |
1101 | up(&jfs_log_sem); | 1102 | mutex_unlock(&jfs_log_mutex); |
1102 | return rc; | 1103 | return rc; |
1103 | } | 1104 | } |
1104 | goto journal_found; | 1105 | goto journal_found; |
@@ -1106,7 +1107,7 @@ int lmLogOpen(struct super_block *sb) | |||
1106 | } | 1107 | } |
1107 | 1108 | ||
1108 | if (!(log = kzalloc(sizeof(struct jfs_log), GFP_KERNEL))) { | 1109 | if (!(log = kzalloc(sizeof(struct jfs_log), GFP_KERNEL))) { |
1109 | up(&jfs_log_sem); | 1110 | mutex_unlock(&jfs_log_mutex); |
1110 | return -ENOMEM; | 1111 | return -ENOMEM; |
1111 | } | 1112 | } |
1112 | INIT_LIST_HEAD(&log->sb_list); | 1113 | INIT_LIST_HEAD(&log->sb_list); |
@@ -1151,7 +1152,7 @@ journal_found: | |||
1151 | sbi->log = log; | 1152 | sbi->log = log; |
1152 | LOG_UNLOCK(log); | 1153 | LOG_UNLOCK(log); |
1153 | 1154 | ||
1154 | up(&jfs_log_sem); | 1155 | mutex_unlock(&jfs_log_mutex); |
1155 | return 0; | 1156 | return 0; |
1156 | 1157 | ||
1157 | /* | 1158 | /* |
@@ -1168,7 +1169,7 @@ journal_found: | |||
1168 | blkdev_put(bdev); | 1169 | blkdev_put(bdev); |
1169 | 1170 | ||
1170 | free: /* free log descriptor */ | 1171 | free: /* free log descriptor */ |
1171 | up(&jfs_log_sem); | 1172 | mutex_unlock(&jfs_log_mutex); |
1172 | kfree(log); | 1173 | kfree(log); |
1173 | 1174 | ||
1174 | jfs_warn("lmLogOpen: exit(%d)", rc); | 1175 | jfs_warn("lmLogOpen: exit(%d)", rc); |
@@ -1212,11 +1213,11 @@ static int open_dummy_log(struct super_block *sb) | |||
1212 | { | 1213 | { |
1213 | int rc; | 1214 | int rc; |
1214 | 1215 | ||
1215 | down(&jfs_log_sem); | 1216 | mutex_lock(&jfs_log_mutex); |
1216 | if (!dummy_log) { | 1217 | if (!dummy_log) { |
1217 | dummy_log = kzalloc(sizeof(struct jfs_log), GFP_KERNEL); | 1218 | dummy_log = kzalloc(sizeof(struct jfs_log), GFP_KERNEL); |
1218 | if (!dummy_log) { | 1219 | if (!dummy_log) { |
1219 | up(&jfs_log_sem); | 1220 | mutex_unlock(&jfs_log_mutex); |
1220 | return -ENOMEM; | 1221 | return -ENOMEM; |
1221 | } | 1222 | } |
1222 | INIT_LIST_HEAD(&dummy_log->sb_list); | 1223 | INIT_LIST_HEAD(&dummy_log->sb_list); |
@@ -1229,7 +1230,7 @@ static int open_dummy_log(struct super_block *sb) | |||
1229 | if (rc) { | 1230 | if (rc) { |
1230 | kfree(dummy_log); | 1231 | kfree(dummy_log); |
1231 | dummy_log = NULL; | 1232 | dummy_log = NULL; |
1232 | up(&jfs_log_sem); | 1233 | mutex_unlock(&jfs_log_mutex); |
1233 | return rc; | 1234 | return rc; |
1234 | } | 1235 | } |
1235 | } | 1236 | } |
@@ -1238,7 +1239,7 @@ static int open_dummy_log(struct super_block *sb) | |||
1238 | list_add(&JFS_SBI(sb)->log_list, &dummy_log->sb_list); | 1239 | list_add(&JFS_SBI(sb)->log_list, &dummy_log->sb_list); |
1239 | JFS_SBI(sb)->log = dummy_log; | 1240 | JFS_SBI(sb)->log = dummy_log; |
1240 | LOG_UNLOCK(dummy_log); | 1241 | LOG_UNLOCK(dummy_log); |
1241 | up(&jfs_log_sem); | 1242 | mutex_unlock(&jfs_log_mutex); |
1242 | 1243 | ||
1243 | return 0; | 1244 | return 0; |
1244 | } | 1245 | } |
@@ -1466,7 +1467,7 @@ int lmLogClose(struct super_block *sb) | |||
1466 | 1467 | ||
1467 | jfs_info("lmLogClose: log:0x%p", log); | 1468 | jfs_info("lmLogClose: log:0x%p", log); |
1468 | 1469 | ||
1469 | down(&jfs_log_sem); | 1470 | mutex_lock(&jfs_log_mutex); |
1470 | LOG_LOCK(log); | 1471 | LOG_LOCK(log); |
1471 | list_del(&sbi->log_list); | 1472 | list_del(&sbi->log_list); |
1472 | LOG_UNLOCK(log); | 1473 | LOG_UNLOCK(log); |
@@ -1516,7 +1517,7 @@ int lmLogClose(struct super_block *sb) | |||
1516 | kfree(log); | 1517 | kfree(log); |
1517 | 1518 | ||
1518 | out: | 1519 | out: |
1519 | up(&jfs_log_sem); | 1520 | mutex_unlock(&jfs_log_mutex); |
1520 | jfs_info("lmLogClose: exit(%d)", rc); | 1521 | jfs_info("lmLogClose: exit(%d)", rc); |
1521 | return rc; | 1522 | return rc; |
1522 | } | 1523 | } |
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 5fbaeaadccd3..f28696f235c4 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c | |||
@@ -220,8 +220,8 @@ int __init metapage_init(void) | |||
220 | if (metapage_cache == NULL) | 220 | if (metapage_cache == NULL) |
221 | return -ENOMEM; | 221 | return -ENOMEM; |
222 | 222 | ||
223 | metapage_mempool = mempool_create(METAPOOL_MIN_PAGES, mempool_alloc_slab, | 223 | metapage_mempool = mempool_create_slab_pool(METAPOOL_MIN_PAGES, |
224 | mempool_free_slab, metapage_cache); | 224 | metapage_cache); |
225 | 225 | ||
226 | if (metapage_mempool == NULL) { | 226 | if (metapage_mempool == NULL) { |
227 | kmem_cache_destroy(metapage_cache); | 227 | kmem_cache_destroy(metapage_cache); |
@@ -578,14 +578,13 @@ static int metapage_releasepage(struct page *page, gfp_t gfp_mask) | |||
578 | return 0; | 578 | return 0; |
579 | } | 579 | } |
580 | 580 | ||
581 | static int metapage_invalidatepage(struct page *page, unsigned long offset) | 581 | static void metapage_invalidatepage(struct page *page, unsigned long offset) |
582 | { | 582 | { |
583 | BUG_ON(offset); | 583 | BUG_ON(offset); |
584 | 584 | ||
585 | if (PageWriteback(page)) | 585 | BUG_ON(PageWriteback(page)); |
586 | return 0; | ||
587 | 586 | ||
588 | return metapage_releasepage(page, 0); | 587 | metapage_releasepage(page, 0); |
589 | } | 588 | } |
590 | 589 | ||
591 | struct address_space_operations jfs_metapage_aops = { | 590 | struct address_space_operations jfs_metapage_aops = { |
diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index 309cee575f7d..09ea03f62277 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c | |||
@@ -1519,7 +1519,7 @@ struct inode_operations jfs_dir_inode_operations = { | |||
1519 | #endif | 1519 | #endif |
1520 | }; | 1520 | }; |
1521 | 1521 | ||
1522 | struct file_operations jfs_dir_operations = { | 1522 | const struct file_operations jfs_dir_operations = { |
1523 | .read = generic_read_dir, | 1523 | .read = generic_read_dir, |
1524 | .readdir = jfs_readdir, | 1524 | .readdir = jfs_readdir, |
1525 | .fsync = jfs_fsync, | 1525 | .fsync = jfs_fsync, |
diff --git a/fs/libfs.c b/fs/libfs.c index 4fdeaceb892c..7145ba7a48d0 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -179,7 +179,7 @@ ssize_t generic_read_dir(struct file *filp, char __user *buf, size_t siz, loff_t | |||
179 | return -EISDIR; | 179 | return -EISDIR; |
180 | } | 180 | } |
181 | 181 | ||
182 | struct file_operations simple_dir_operations = { | 182 | const struct file_operations simple_dir_operations = { |
183 | .open = dcache_dir_open, | 183 | .open = dcache_dir_open, |
184 | .release = dcache_dir_close, | 184 | .release = dcache_dir_close, |
185 | .llseek = dcache_dir_lseek, | 185 | .llseek = dcache_dir_lseek, |
diff --git a/fs/lockd/host.c b/fs/lockd/host.c index 112ebf8b8dfe..729ac427d359 100644 --- a/fs/lockd/host.c +++ b/fs/lockd/host.c | |||
@@ -16,6 +16,7 @@ | |||
16 | #include <linux/sunrpc/svc.h> | 16 | #include <linux/sunrpc/svc.h> |
17 | #include <linux/lockd/lockd.h> | 17 | #include <linux/lockd/lockd.h> |
18 | #include <linux/lockd/sm_inter.h> | 18 | #include <linux/lockd/sm_inter.h> |
19 | #include <linux/mutex.h> | ||
19 | 20 | ||
20 | 21 | ||
21 | #define NLMDBG_FACILITY NLMDBG_HOSTCACHE | 22 | #define NLMDBG_FACILITY NLMDBG_HOSTCACHE |
@@ -30,7 +31,7 @@ | |||
30 | static struct nlm_host * nlm_hosts[NLM_HOST_NRHASH]; | 31 | static struct nlm_host * nlm_hosts[NLM_HOST_NRHASH]; |
31 | static unsigned long next_gc; | 32 | static unsigned long next_gc; |
32 | static int nrhosts; | 33 | static int nrhosts; |
33 | static DECLARE_MUTEX(nlm_host_sema); | 34 | static DEFINE_MUTEX(nlm_host_mutex); |
34 | 35 | ||
35 | 36 | ||
36 | static void nlm_gc_hosts(void); | 37 | static void nlm_gc_hosts(void); |
@@ -71,7 +72,7 @@ nlm_lookup_host(int server, struct sockaddr_in *sin, | |||
71 | hash = NLM_ADDRHASH(sin->sin_addr.s_addr); | 72 | hash = NLM_ADDRHASH(sin->sin_addr.s_addr); |
72 | 73 | ||
73 | /* Lock hash table */ | 74 | /* Lock hash table */ |
74 | down(&nlm_host_sema); | 75 | mutex_lock(&nlm_host_mutex); |
75 | 76 | ||
76 | if (time_after_eq(jiffies, next_gc)) | 77 | if (time_after_eq(jiffies, next_gc)) |
77 | nlm_gc_hosts(); | 78 | nlm_gc_hosts(); |
@@ -91,7 +92,7 @@ nlm_lookup_host(int server, struct sockaddr_in *sin, | |||
91 | nlm_hosts[hash] = host; | 92 | nlm_hosts[hash] = host; |
92 | } | 93 | } |
93 | nlm_get_host(host); | 94 | nlm_get_host(host); |
94 | up(&nlm_host_sema); | 95 | mutex_unlock(&nlm_host_mutex); |
95 | return host; | 96 | return host; |
96 | } | 97 | } |
97 | } | 98 | } |
@@ -130,7 +131,7 @@ nlm_lookup_host(int server, struct sockaddr_in *sin, | |||
130 | next_gc = 0; | 131 | next_gc = 0; |
131 | 132 | ||
132 | nohost: | 133 | nohost: |
133 | up(&nlm_host_sema); | 134 | mutex_unlock(&nlm_host_mutex); |
134 | return host; | 135 | return host; |
135 | } | 136 | } |
136 | 137 | ||
@@ -141,19 +142,19 @@ nlm_find_client(void) | |||
141 | * and return it | 142 | * and return it |
142 | */ | 143 | */ |
143 | int hash; | 144 | int hash; |
144 | down(&nlm_host_sema); | 145 | mutex_lock(&nlm_host_mutex); |
145 | for (hash = 0 ; hash < NLM_HOST_NRHASH; hash++) { | 146 | for (hash = 0 ; hash < NLM_HOST_NRHASH; hash++) { |
146 | struct nlm_host *host, **hp; | 147 | struct nlm_host *host, **hp; |
147 | for (hp = &nlm_hosts[hash]; (host = *hp) != 0; hp = &host->h_next) { | 148 | for (hp = &nlm_hosts[hash]; (host = *hp) != 0; hp = &host->h_next) { |
148 | if (host->h_server && | 149 | if (host->h_server && |
149 | host->h_killed == 0) { | 150 | host->h_killed == 0) { |
150 | nlm_get_host(host); | 151 | nlm_get_host(host); |
151 | up(&nlm_host_sema); | 152 | mutex_unlock(&nlm_host_mutex); |
152 | return host; | 153 | return host; |
153 | } | 154 | } |
154 | } | 155 | } |
155 | } | 156 | } |
156 | up(&nlm_host_sema); | 157 | mutex_unlock(&nlm_host_mutex); |
157 | return NULL; | 158 | return NULL; |
158 | } | 159 | } |
159 | 160 | ||
@@ -265,7 +266,7 @@ nlm_shutdown_hosts(void) | |||
265 | int i; | 266 | int i; |
266 | 267 | ||
267 | dprintk("lockd: shutting down host module\n"); | 268 | dprintk("lockd: shutting down host module\n"); |
268 | down(&nlm_host_sema); | 269 | mutex_lock(&nlm_host_mutex); |
269 | 270 | ||
270 | /* First, make all hosts eligible for gc */ | 271 | /* First, make all hosts eligible for gc */ |
271 | dprintk("lockd: nuking all hosts...\n"); | 272 | dprintk("lockd: nuking all hosts...\n"); |
@@ -276,7 +277,7 @@ nlm_shutdown_hosts(void) | |||
276 | 277 | ||
277 | /* Then, perform a garbage collection pass */ | 278 | /* Then, perform a garbage collection pass */ |
278 | nlm_gc_hosts(); | 279 | nlm_gc_hosts(); |
279 | up(&nlm_host_sema); | 280 | mutex_unlock(&nlm_host_mutex); |
280 | 281 | ||
281 | /* complain if any hosts are left */ | 282 | /* complain if any hosts are left */ |
282 | if (nrhosts) { | 283 | if (nrhosts) { |
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index 5e85bde6c123..fd56c8872f34 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include <linux/slab.h> | 25 | #include <linux/slab.h> |
26 | #include <linux/smp.h> | 26 | #include <linux/smp.h> |
27 | #include <linux/smp_lock.h> | 27 | #include <linux/smp_lock.h> |
28 | #include <linux/mutex.h> | ||
28 | 29 | ||
29 | #include <linux/sunrpc/types.h> | 30 | #include <linux/sunrpc/types.h> |
30 | #include <linux/sunrpc/stats.h> | 31 | #include <linux/sunrpc/stats.h> |
@@ -43,13 +44,13 @@ static struct svc_program nlmsvc_program; | |||
43 | struct nlmsvc_binding * nlmsvc_ops; | 44 | struct nlmsvc_binding * nlmsvc_ops; |
44 | EXPORT_SYMBOL(nlmsvc_ops); | 45 | EXPORT_SYMBOL(nlmsvc_ops); |
45 | 46 | ||
46 | static DECLARE_MUTEX(nlmsvc_sema); | 47 | static DEFINE_MUTEX(nlmsvc_mutex); |
47 | static unsigned int nlmsvc_users; | 48 | static unsigned int nlmsvc_users; |
48 | static pid_t nlmsvc_pid; | 49 | static pid_t nlmsvc_pid; |
49 | int nlmsvc_grace_period; | 50 | int nlmsvc_grace_period; |
50 | unsigned long nlmsvc_timeout; | 51 | unsigned long nlmsvc_timeout; |
51 | 52 | ||
52 | static DECLARE_MUTEX_LOCKED(lockd_start); | 53 | static DECLARE_COMPLETION(lockd_start_done); |
53 | static DECLARE_WAIT_QUEUE_HEAD(lockd_exit); | 54 | static DECLARE_WAIT_QUEUE_HEAD(lockd_exit); |
54 | 55 | ||
55 | /* | 56 | /* |
@@ -112,7 +113,7 @@ lockd(struct svc_rqst *rqstp) | |||
112 | * Let our maker know we're running. | 113 | * Let our maker know we're running. |
113 | */ | 114 | */ |
114 | nlmsvc_pid = current->pid; | 115 | nlmsvc_pid = current->pid; |
115 | up(&lockd_start); | 116 | complete(&lockd_start_done); |
116 | 117 | ||
117 | daemonize("lockd"); | 118 | daemonize("lockd"); |
118 | 119 | ||
@@ -215,7 +216,7 @@ lockd_up(void) | |||
215 | struct svc_serv * serv; | 216 | struct svc_serv * serv; |
216 | int error = 0; | 217 | int error = 0; |
217 | 218 | ||
218 | down(&nlmsvc_sema); | 219 | mutex_lock(&nlmsvc_mutex); |
219 | /* | 220 | /* |
220 | * Unconditionally increment the user count ... this is | 221 | * Unconditionally increment the user count ... this is |
221 | * the number of clients who _want_ a lockd process. | 222 | * the number of clients who _want_ a lockd process. |
@@ -263,7 +264,7 @@ lockd_up(void) | |||
263 | "lockd_up: create thread failed, error=%d\n", error); | 264 | "lockd_up: create thread failed, error=%d\n", error); |
264 | goto destroy_and_out; | 265 | goto destroy_and_out; |
265 | } | 266 | } |
266 | down(&lockd_start); | 267 | wait_for_completion(&lockd_start_done); |
267 | 268 | ||
268 | /* | 269 | /* |
269 | * Note: svc_serv structures have an initial use count of 1, | 270 | * Note: svc_serv structures have an initial use count of 1, |
@@ -272,7 +273,7 @@ lockd_up(void) | |||
272 | destroy_and_out: | 273 | destroy_and_out: |
273 | svc_destroy(serv); | 274 | svc_destroy(serv); |
274 | out: | 275 | out: |
275 | up(&nlmsvc_sema); | 276 | mutex_unlock(&nlmsvc_mutex); |
276 | return error; | 277 | return error; |
277 | } | 278 | } |
278 | EXPORT_SYMBOL(lockd_up); | 279 | EXPORT_SYMBOL(lockd_up); |
@@ -285,7 +286,7 @@ lockd_down(void) | |||
285 | { | 286 | { |
286 | static int warned; | 287 | static int warned; |
287 | 288 | ||
288 | down(&nlmsvc_sema); | 289 | mutex_lock(&nlmsvc_mutex); |
289 | if (nlmsvc_users) { | 290 | if (nlmsvc_users) { |
290 | if (--nlmsvc_users) | 291 | if (--nlmsvc_users) |
291 | goto out; | 292 | goto out; |
@@ -315,7 +316,7 @@ lockd_down(void) | |||
315 | recalc_sigpending(); | 316 | recalc_sigpending(); |
316 | spin_unlock_irq(¤t->sighand->siglock); | 317 | spin_unlock_irq(¤t->sighand->siglock); |
317 | out: | 318 | out: |
318 | up(&nlmsvc_sema); | 319 | mutex_unlock(&nlmsvc_mutex); |
319 | } | 320 | } |
320 | EXPORT_SYMBOL(lockd_down); | 321 | EXPORT_SYMBOL(lockd_down); |
321 | 322 | ||
diff --git a/fs/lockd/svcsubs.c b/fs/lockd/svcsubs.c index c7a6e3ae44d6..a570e5c8a930 100644 --- a/fs/lockd/svcsubs.c +++ b/fs/lockd/svcsubs.c | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <linux/string.h> | 11 | #include <linux/string.h> |
12 | #include <linux/time.h> | 12 | #include <linux/time.h> |
13 | #include <linux/in.h> | 13 | #include <linux/in.h> |
14 | #include <linux/mutex.h> | ||
14 | #include <linux/sunrpc/svc.h> | 15 | #include <linux/sunrpc/svc.h> |
15 | #include <linux/sunrpc/clnt.h> | 16 | #include <linux/sunrpc/clnt.h> |
16 | #include <linux/nfsd/nfsfh.h> | 17 | #include <linux/nfsd/nfsfh.h> |
@@ -28,7 +29,7 @@ | |||
28 | #define FILE_HASH_BITS 5 | 29 | #define FILE_HASH_BITS 5 |
29 | #define FILE_NRHASH (1<<FILE_HASH_BITS) | 30 | #define FILE_NRHASH (1<<FILE_HASH_BITS) |
30 | static struct nlm_file * nlm_files[FILE_NRHASH]; | 31 | static struct nlm_file * nlm_files[FILE_NRHASH]; |
31 | static DECLARE_MUTEX(nlm_file_sema); | 32 | static DEFINE_MUTEX(nlm_file_mutex); |
32 | 33 | ||
33 | #ifdef NFSD_DEBUG | 34 | #ifdef NFSD_DEBUG |
34 | static inline void nlm_debug_print_fh(char *msg, struct nfs_fh *f) | 35 | static inline void nlm_debug_print_fh(char *msg, struct nfs_fh *f) |
@@ -91,7 +92,7 @@ nlm_lookup_file(struct svc_rqst *rqstp, struct nlm_file **result, | |||
91 | hash = file_hash(f); | 92 | hash = file_hash(f); |
92 | 93 | ||
93 | /* Lock file table */ | 94 | /* Lock file table */ |
94 | down(&nlm_file_sema); | 95 | mutex_lock(&nlm_file_mutex); |
95 | 96 | ||
96 | for (file = nlm_files[hash]; file; file = file->f_next) | 97 | for (file = nlm_files[hash]; file; file = file->f_next) |
97 | if (!nfs_compare_fh(&file->f_handle, f)) | 98 | if (!nfs_compare_fh(&file->f_handle, f)) |
@@ -130,7 +131,7 @@ found: | |||
130 | nfserr = 0; | 131 | nfserr = 0; |
131 | 132 | ||
132 | out_unlock: | 133 | out_unlock: |
133 | up(&nlm_file_sema); | 134 | mutex_unlock(&nlm_file_mutex); |
134 | return nfserr; | 135 | return nfserr; |
135 | 136 | ||
136 | out_free: | 137 | out_free: |
@@ -239,14 +240,14 @@ nlm_traverse_files(struct nlm_host *host, int action) | |||
239 | struct nlm_file *file, **fp; | 240 | struct nlm_file *file, **fp; |
240 | int i; | 241 | int i; |
241 | 242 | ||
242 | down(&nlm_file_sema); | 243 | mutex_lock(&nlm_file_mutex); |
243 | for (i = 0; i < FILE_NRHASH; i++) { | 244 | for (i = 0; i < FILE_NRHASH; i++) { |
244 | fp = nlm_files + i; | 245 | fp = nlm_files + i; |
245 | while ((file = *fp) != NULL) { | 246 | while ((file = *fp) != NULL) { |
246 | /* Traverse locks, blocks and shares of this file | 247 | /* Traverse locks, blocks and shares of this file |
247 | * and update file->f_locks count */ | 248 | * and update file->f_locks count */ |
248 | if (nlm_inspect_file(host, file, action)) { | 249 | if (nlm_inspect_file(host, file, action)) { |
249 | up(&nlm_file_sema); | 250 | mutex_unlock(&nlm_file_mutex); |
250 | return 1; | 251 | return 1; |
251 | } | 252 | } |
252 | 253 | ||
@@ -261,7 +262,7 @@ nlm_traverse_files(struct nlm_host *host, int action) | |||
261 | } | 262 | } |
262 | } | 263 | } |
263 | } | 264 | } |
264 | up(&nlm_file_sema); | 265 | mutex_unlock(&nlm_file_mutex); |
265 | return 0; | 266 | return 0; |
266 | } | 267 | } |
267 | 268 | ||
@@ -281,7 +282,7 @@ nlm_release_file(struct nlm_file *file) | |||
281 | file, file->f_count); | 282 | file, file->f_count); |
282 | 283 | ||
283 | /* Lock file table */ | 284 | /* Lock file table */ |
284 | down(&nlm_file_sema); | 285 | mutex_lock(&nlm_file_mutex); |
285 | 286 | ||
286 | /* If there are no more locks etc, delete the file */ | 287 | /* If there are no more locks etc, delete the file */ |
287 | if(--file->f_count == 0) { | 288 | if(--file->f_count == 0) { |
@@ -289,7 +290,7 @@ nlm_release_file(struct nlm_file *file) | |||
289 | nlm_delete_file(file); | 290 | nlm_delete_file(file); |
290 | } | 291 | } |
291 | 292 | ||
292 | up(&nlm_file_sema); | 293 | mutex_unlock(&nlm_file_mutex); |
293 | } | 294 | } |
294 | 295 | ||
295 | /* | 296 | /* |
diff --git a/fs/locks.c b/fs/locks.c index 56f996e98bbc..4d9e71d43e7e 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -142,7 +142,7 @@ int lease_break_time = 45; | |||
142 | static LIST_HEAD(file_lock_list); | 142 | static LIST_HEAD(file_lock_list); |
143 | static LIST_HEAD(blocked_list); | 143 | static LIST_HEAD(blocked_list); |
144 | 144 | ||
145 | static kmem_cache_t *filelock_cache; | 145 | static kmem_cache_t *filelock_cache __read_mostly; |
146 | 146 | ||
147 | /* Allocate an empty lock structure. */ | 147 | /* Allocate an empty lock structure. */ |
148 | static struct file_lock *locks_alloc_lock(void) | 148 | static struct file_lock *locks_alloc_lock(void) |
@@ -533,12 +533,7 @@ static void locks_delete_block(struct file_lock *waiter) | |||
533 | static void locks_insert_block(struct file_lock *blocker, | 533 | static void locks_insert_block(struct file_lock *blocker, |
534 | struct file_lock *waiter) | 534 | struct file_lock *waiter) |
535 | { | 535 | { |
536 | if (!list_empty(&waiter->fl_block)) { | 536 | BUG_ON(!list_empty(&waiter->fl_block)); |
537 | printk(KERN_ERR "locks_insert_block: removing duplicated lock " | ||
538 | "(pid=%d %Ld-%Ld type=%d)\n", waiter->fl_pid, | ||
539 | waiter->fl_start, waiter->fl_end, waiter->fl_type); | ||
540 | __locks_delete_block(waiter); | ||
541 | } | ||
542 | list_add_tail(&waiter->fl_block, &blocker->fl_block); | 537 | list_add_tail(&waiter->fl_block, &blocker->fl_block); |
543 | waiter->fl_next = blocker; | 538 | waiter->fl_next = blocker; |
544 | if (IS_POSIX(blocker)) | 539 | if (IS_POSIX(blocker)) |
@@ -797,9 +792,7 @@ out: | |||
797 | return error; | 792 | return error; |
798 | } | 793 | } |
799 | 794 | ||
800 | EXPORT_SYMBOL(posix_lock_file); | 795 | static int __posix_lock_file_conf(struct inode *inode, struct file_lock *request, struct file_lock *conflock) |
801 | |||
802 | static int __posix_lock_file(struct inode *inode, struct file_lock *request) | ||
803 | { | 796 | { |
804 | struct file_lock *fl; | 797 | struct file_lock *fl; |
805 | struct file_lock *new_fl, *new_fl2; | 798 | struct file_lock *new_fl, *new_fl2; |
@@ -823,6 +816,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request) | |||
823 | continue; | 816 | continue; |
824 | if (!posix_locks_conflict(request, fl)) | 817 | if (!posix_locks_conflict(request, fl)) |
825 | continue; | 818 | continue; |
819 | if (conflock) | ||
820 | locks_copy_lock(conflock, fl); | ||
826 | error = -EAGAIN; | 821 | error = -EAGAIN; |
827 | if (!(request->fl_flags & FL_SLEEP)) | 822 | if (!(request->fl_flags & FL_SLEEP)) |
828 | goto out; | 823 | goto out; |
@@ -992,8 +987,24 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request) | |||
992 | */ | 987 | */ |
993 | int posix_lock_file(struct file *filp, struct file_lock *fl) | 988 | int posix_lock_file(struct file *filp, struct file_lock *fl) |
994 | { | 989 | { |
995 | return __posix_lock_file(filp->f_dentry->d_inode, fl); | 990 | return __posix_lock_file_conf(filp->f_dentry->d_inode, fl, NULL); |
991 | } | ||
992 | EXPORT_SYMBOL(posix_lock_file); | ||
993 | |||
994 | /** | ||
995 | * posix_lock_file_conf - Apply a POSIX-style lock to a file | ||
996 | * @filp: The file to apply the lock to | ||
997 | * @fl: The lock to be applied | ||
998 | * @conflock: Place to return a copy of the conflicting lock, if found. | ||
999 | * | ||
1000 | * Except for the conflock parameter, acts just like posix_lock_file. | ||
1001 | */ | ||
1002 | int posix_lock_file_conf(struct file *filp, struct file_lock *fl, | ||
1003 | struct file_lock *conflock) | ||
1004 | { | ||
1005 | return __posix_lock_file_conf(filp->f_dentry->d_inode, fl, conflock); | ||
996 | } | 1006 | } |
1007 | EXPORT_SYMBOL(posix_lock_file_conf); | ||
997 | 1008 | ||
998 | /** | 1009 | /** |
999 | * posix_lock_file_wait - Apply a POSIX-style lock to a file | 1010 | * posix_lock_file_wait - Apply a POSIX-style lock to a file |
@@ -1009,7 +1020,7 @@ int posix_lock_file_wait(struct file *filp, struct file_lock *fl) | |||
1009 | int error; | 1020 | int error; |
1010 | might_sleep (); | 1021 | might_sleep (); |
1011 | for (;;) { | 1022 | for (;;) { |
1012 | error = __posix_lock_file(filp->f_dentry->d_inode, fl); | 1023 | error = posix_lock_file(filp, fl); |
1013 | if ((error != -EAGAIN) || !(fl->fl_flags & FL_SLEEP)) | 1024 | if ((error != -EAGAIN) || !(fl->fl_flags & FL_SLEEP)) |
1014 | break; | 1025 | break; |
1015 | error = wait_event_interruptible(fl->fl_wait, !fl->fl_next); | 1026 | error = wait_event_interruptible(fl->fl_wait, !fl->fl_next); |
@@ -1081,7 +1092,7 @@ int locks_mandatory_area(int read_write, struct inode *inode, | |||
1081 | fl.fl_end = offset + count - 1; | 1092 | fl.fl_end = offset + count - 1; |
1082 | 1093 | ||
1083 | for (;;) { | 1094 | for (;;) { |
1084 | error = __posix_lock_file(inode, &fl); | 1095 | error = __posix_lock_file_conf(inode, &fl, NULL); |
1085 | if (error != -EAGAIN) | 1096 | if (error != -EAGAIN) |
1086 | break; | 1097 | break; |
1087 | if (!(fl.fl_flags & FL_SLEEP)) | 1098 | if (!(fl.fl_flags & FL_SLEEP)) |
@@ -1694,7 +1705,7 @@ again: | |||
1694 | error = filp->f_op->lock(filp, cmd, file_lock); | 1705 | error = filp->f_op->lock(filp, cmd, file_lock); |
1695 | else { | 1706 | else { |
1696 | for (;;) { | 1707 | for (;;) { |
1697 | error = __posix_lock_file(inode, file_lock); | 1708 | error = posix_lock_file(filp, file_lock); |
1698 | if ((error != -EAGAIN) || (cmd == F_SETLK)) | 1709 | if ((error != -EAGAIN) || (cmd == F_SETLK)) |
1699 | break; | 1710 | break; |
1700 | error = wait_event_interruptible(file_lock->fl_wait, | 1711 | error = wait_event_interruptible(file_lock->fl_wait, |
@@ -1837,7 +1848,7 @@ again: | |||
1837 | error = filp->f_op->lock(filp, cmd, file_lock); | 1848 | error = filp->f_op->lock(filp, cmd, file_lock); |
1838 | else { | 1849 | else { |
1839 | for (;;) { | 1850 | for (;;) { |
1840 | error = __posix_lock_file(inode, file_lock); | 1851 | error = posix_lock_file(filp, file_lock); |
1841 | if ((error != -EAGAIN) || (cmd == F_SETLK64)) | 1852 | if ((error != -EAGAIN) || (cmd == F_SETLK64)) |
1842 | break; | 1853 | break; |
1843 | error = wait_event_interruptible(file_lock->fl_wait, | 1854 | error = wait_event_interruptible(file_lock->fl_wait, |
diff --git a/fs/mbcache.c b/fs/mbcache.c index 73e754fea2d8..e4fde1ab22cd 100644 --- a/fs/mbcache.c +++ b/fs/mbcache.c | |||
@@ -311,7 +311,7 @@ fail: | |||
311 | /* | 311 | /* |
312 | * mb_cache_shrink() | 312 | * mb_cache_shrink() |
313 | * | 313 | * |
314 | * Removes all cache entires of a device from the cache. All cache entries | 314 | * Removes all cache entries of a device from the cache. All cache entries |
315 | * currently in use cannot be freed, and thus remain in the cache. All others | 315 | * currently in use cannot be freed, and thus remain in the cache. All others |
316 | * are freed. | 316 | * are freed. |
317 | * | 317 | * |
diff --git a/fs/minix/dir.c b/fs/minix/dir.c index 732502aabc05..69224d1fe043 100644 --- a/fs/minix/dir.c +++ b/fs/minix/dir.c | |||
@@ -14,7 +14,7 @@ typedef struct minix_dir_entry minix_dirent; | |||
14 | 14 | ||
15 | static int minix_readdir(struct file *, void *, filldir_t); | 15 | static int minix_readdir(struct file *, void *, filldir_t); |
16 | 16 | ||
17 | struct file_operations minix_dir_operations = { | 17 | const struct file_operations minix_dir_operations = { |
18 | .read = generic_read_dir, | 18 | .read = generic_read_dir, |
19 | .readdir = minix_readdir, | 19 | .readdir = minix_readdir, |
20 | .fsync = minix_sync_file, | 20 | .fsync = minix_sync_file, |
diff --git a/fs/minix/file.c b/fs/minix/file.c index f1d77acb3f01..420b32882a10 100644 --- a/fs/minix/file.c +++ b/fs/minix/file.c | |||
@@ -15,7 +15,7 @@ | |||
15 | */ | 15 | */ |
16 | int minix_sync_file(struct file *, struct dentry *, int); | 16 | int minix_sync_file(struct file *, struct dentry *, int); |
17 | 17 | ||
18 | struct file_operations minix_file_operations = { | 18 | const struct file_operations minix_file_operations = { |
19 | .llseek = generic_file_llseek, | 19 | .llseek = generic_file_llseek, |
20 | .read = generic_file_read, | 20 | .read = generic_file_read, |
21 | .write = generic_file_write, | 21 | .write = generic_file_write, |
diff --git a/fs/minix/minix.h b/fs/minix/minix.h index e42a8bb89001..c55b77cdcc8e 100644 --- a/fs/minix/minix.h +++ b/fs/minix/minix.h | |||
@@ -81,8 +81,8 @@ extern int minix_sync_file(struct file *, struct dentry *, int); | |||
81 | 81 | ||
82 | extern struct inode_operations minix_file_inode_operations; | 82 | extern struct inode_operations minix_file_inode_operations; |
83 | extern struct inode_operations minix_dir_inode_operations; | 83 | extern struct inode_operations minix_dir_inode_operations; |
84 | extern struct file_operations minix_file_operations; | 84 | extern const struct file_operations minix_file_operations; |
85 | extern struct file_operations minix_dir_operations; | 85 | extern const struct file_operations minix_dir_operations; |
86 | extern struct dentry_operations minix_dentry_operations; | 86 | extern struct dentry_operations minix_dentry_operations; |
87 | 87 | ||
88 | static inline struct minix_sb_info *minix_sb(struct super_block *sb) | 88 | static inline struct minix_sb_info *minix_sb(struct super_block *sb) |
diff --git a/fs/mpage.c b/fs/mpage.c index e431cb3878d6..9bf2eb30e6f4 100644 --- a/fs/mpage.c +++ b/fs/mpage.c | |||
@@ -163,9 +163,19 @@ map_buffer_to_page(struct page *page, struct buffer_head *bh, int page_block) | |||
163 | } while (page_bh != head); | 163 | } while (page_bh != head); |
164 | } | 164 | } |
165 | 165 | ||
166 | /* | ||
167 | * This is the worker routine which does all the work of mapping the disk | ||
168 | * blocks and constructs largest possible bios, submits them for IO if the | ||
169 | * blocks are not contiguous on the disk. | ||
170 | * | ||
171 | * We pass a buffer_head back and forth and use its buffer_mapped() flag to | ||
172 | * represent the validity of its disk mapping and to decide when to do the next | ||
173 | * get_block() call. | ||
174 | */ | ||
166 | static struct bio * | 175 | static struct bio * |
167 | do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages, | 176 | do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages, |
168 | sector_t *last_block_in_bio, get_block_t get_block) | 177 | sector_t *last_block_in_bio, struct buffer_head *map_bh, |
178 | unsigned long *first_logical_block, get_block_t get_block) | ||
169 | { | 179 | { |
170 | struct inode *inode = page->mapping->host; | 180 | struct inode *inode = page->mapping->host; |
171 | const unsigned blkbits = inode->i_blkbits; | 181 | const unsigned blkbits = inode->i_blkbits; |
@@ -173,33 +183,72 @@ do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages, | |||
173 | const unsigned blocksize = 1 << blkbits; | 183 | const unsigned blocksize = 1 << blkbits; |
174 | sector_t block_in_file; | 184 | sector_t block_in_file; |
175 | sector_t last_block; | 185 | sector_t last_block; |
186 | sector_t last_block_in_file; | ||
176 | sector_t blocks[MAX_BUF_PER_PAGE]; | 187 | sector_t blocks[MAX_BUF_PER_PAGE]; |
177 | unsigned page_block; | 188 | unsigned page_block; |
178 | unsigned first_hole = blocks_per_page; | 189 | unsigned first_hole = blocks_per_page; |
179 | struct block_device *bdev = NULL; | 190 | struct block_device *bdev = NULL; |
180 | struct buffer_head bh; | ||
181 | int length; | 191 | int length; |
182 | int fully_mapped = 1; | 192 | int fully_mapped = 1; |
193 | unsigned nblocks; | ||
194 | unsigned relative_block; | ||
183 | 195 | ||
184 | if (page_has_buffers(page)) | 196 | if (page_has_buffers(page)) |
185 | goto confused; | 197 | goto confused; |
186 | 198 | ||
187 | block_in_file = (sector_t)page->index << (PAGE_CACHE_SHIFT - blkbits); | 199 | block_in_file = (sector_t)page->index << (PAGE_CACHE_SHIFT - blkbits); |
188 | last_block = (i_size_read(inode) + blocksize - 1) >> blkbits; | 200 | last_block = block_in_file + nr_pages * blocks_per_page; |
201 | last_block_in_file = (i_size_read(inode) + blocksize - 1) >> blkbits; | ||
202 | if (last_block > last_block_in_file) | ||
203 | last_block = last_block_in_file; | ||
204 | page_block = 0; | ||
205 | |||
206 | /* | ||
207 | * Map blocks using the result from the previous get_blocks call first. | ||
208 | */ | ||
209 | nblocks = map_bh->b_size >> blkbits; | ||
210 | if (buffer_mapped(map_bh) && block_in_file > *first_logical_block && | ||
211 | block_in_file < (*first_logical_block + nblocks)) { | ||
212 | unsigned map_offset = block_in_file - *first_logical_block; | ||
213 | unsigned last = nblocks - map_offset; | ||
214 | |||
215 | for (relative_block = 0; ; relative_block++) { | ||
216 | if (relative_block == last) { | ||
217 | clear_buffer_mapped(map_bh); | ||
218 | break; | ||
219 | } | ||
220 | if (page_block == blocks_per_page) | ||
221 | break; | ||
222 | blocks[page_block] = map_bh->b_blocknr + map_offset + | ||
223 | relative_block; | ||
224 | page_block++; | ||
225 | block_in_file++; | ||
226 | } | ||
227 | bdev = map_bh->b_bdev; | ||
228 | } | ||
229 | |||
230 | /* | ||
231 | * Then do more get_blocks calls until we are done with this page. | ||
232 | */ | ||
233 | map_bh->b_page = page; | ||
234 | while (page_block < blocks_per_page) { | ||
235 | map_bh->b_state = 0; | ||
236 | map_bh->b_size = 0; | ||
189 | 237 | ||
190 | bh.b_page = page; | ||
191 | for (page_block = 0; page_block < blocks_per_page; | ||
192 | page_block++, block_in_file++) { | ||
193 | bh.b_state = 0; | ||
194 | if (block_in_file < last_block) { | 238 | if (block_in_file < last_block) { |
195 | if (get_block(inode, block_in_file, &bh, 0)) | 239 | map_bh->b_size = (last_block-block_in_file) << blkbits; |
240 | if (get_block(inode, block_in_file, map_bh, 0)) | ||
196 | goto confused; | 241 | goto confused; |
242 | *first_logical_block = block_in_file; | ||
197 | } | 243 | } |
198 | 244 | ||
199 | if (!buffer_mapped(&bh)) { | 245 | if (!buffer_mapped(map_bh)) { |
200 | fully_mapped = 0; | 246 | fully_mapped = 0; |
201 | if (first_hole == blocks_per_page) | 247 | if (first_hole == blocks_per_page) |
202 | first_hole = page_block; | 248 | first_hole = page_block; |
249 | page_block++; | ||
250 | block_in_file++; | ||
251 | clear_buffer_mapped(map_bh); | ||
203 | continue; | 252 | continue; |
204 | } | 253 | } |
205 | 254 | ||
@@ -209,8 +258,8 @@ do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages, | |||
209 | * we just collected from get_block into the page's buffers | 258 | * we just collected from get_block into the page's buffers |
210 | * so readpage doesn't have to repeat the get_block call | 259 | * so readpage doesn't have to repeat the get_block call |
211 | */ | 260 | */ |
212 | if (buffer_uptodate(&bh)) { | 261 | if (buffer_uptodate(map_bh)) { |
213 | map_buffer_to_page(page, &bh, page_block); | 262 | map_buffer_to_page(page, map_bh, page_block); |
214 | goto confused; | 263 | goto confused; |
215 | } | 264 | } |
216 | 265 | ||
@@ -218,10 +267,20 @@ do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages, | |||
218 | goto confused; /* hole -> non-hole */ | 267 | goto confused; /* hole -> non-hole */ |
219 | 268 | ||
220 | /* Contiguous blocks? */ | 269 | /* Contiguous blocks? */ |
221 | if (page_block && blocks[page_block-1] != bh.b_blocknr-1) | 270 | if (page_block && blocks[page_block-1] != map_bh->b_blocknr-1) |
222 | goto confused; | 271 | goto confused; |
223 | blocks[page_block] = bh.b_blocknr; | 272 | nblocks = map_bh->b_size >> blkbits; |
224 | bdev = bh.b_bdev; | 273 | for (relative_block = 0; ; relative_block++) { |
274 | if (relative_block == nblocks) { | ||
275 | clear_buffer_mapped(map_bh); | ||
276 | break; | ||
277 | } else if (page_block == blocks_per_page) | ||
278 | break; | ||
279 | blocks[page_block] = map_bh->b_blocknr+relative_block; | ||
280 | page_block++; | ||
281 | block_in_file++; | ||
282 | } | ||
283 | bdev = map_bh->b_bdev; | ||
225 | } | 284 | } |
226 | 285 | ||
227 | if (first_hole != blocks_per_page) { | 286 | if (first_hole != blocks_per_page) { |
@@ -260,7 +319,7 @@ alloc_new: | |||
260 | goto alloc_new; | 319 | goto alloc_new; |
261 | } | 320 | } |
262 | 321 | ||
263 | if (buffer_boundary(&bh) || (first_hole != blocks_per_page)) | 322 | if (buffer_boundary(map_bh) || (first_hole != blocks_per_page)) |
264 | bio = mpage_bio_submit(READ, bio); | 323 | bio = mpage_bio_submit(READ, bio); |
265 | else | 324 | else |
266 | *last_block_in_bio = blocks[blocks_per_page - 1]; | 325 | *last_block_in_bio = blocks[blocks_per_page - 1]; |
@@ -331,7 +390,10 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages, | |||
331 | unsigned page_idx; | 390 | unsigned page_idx; |
332 | sector_t last_block_in_bio = 0; | 391 | sector_t last_block_in_bio = 0; |
333 | struct pagevec lru_pvec; | 392 | struct pagevec lru_pvec; |
393 | struct buffer_head map_bh; | ||
394 | unsigned long first_logical_block = 0; | ||
334 | 395 | ||
396 | clear_buffer_mapped(&map_bh); | ||
335 | pagevec_init(&lru_pvec, 0); | 397 | pagevec_init(&lru_pvec, 0); |
336 | for (page_idx = 0; page_idx < nr_pages; page_idx++) { | 398 | for (page_idx = 0; page_idx < nr_pages; page_idx++) { |
337 | struct page *page = list_entry(pages->prev, struct page, lru); | 399 | struct page *page = list_entry(pages->prev, struct page, lru); |
@@ -342,7 +404,9 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages, | |||
342 | page->index, GFP_KERNEL)) { | 404 | page->index, GFP_KERNEL)) { |
343 | bio = do_mpage_readpage(bio, page, | 405 | bio = do_mpage_readpage(bio, page, |
344 | nr_pages - page_idx, | 406 | nr_pages - page_idx, |
345 | &last_block_in_bio, get_block); | 407 | &last_block_in_bio, &map_bh, |
408 | &first_logical_block, | ||
409 | get_block); | ||
346 | if (!pagevec_add(&lru_pvec, page)) | 410 | if (!pagevec_add(&lru_pvec, page)) |
347 | __pagevec_lru_add(&lru_pvec); | 411 | __pagevec_lru_add(&lru_pvec); |
348 | } else { | 412 | } else { |
@@ -364,9 +428,12 @@ int mpage_readpage(struct page *page, get_block_t get_block) | |||
364 | { | 428 | { |
365 | struct bio *bio = NULL; | 429 | struct bio *bio = NULL; |
366 | sector_t last_block_in_bio = 0; | 430 | sector_t last_block_in_bio = 0; |
431 | struct buffer_head map_bh; | ||
432 | unsigned long first_logical_block = 0; | ||
367 | 433 | ||
368 | bio = do_mpage_readpage(bio, page, 1, | 434 | clear_buffer_mapped(&map_bh); |
369 | &last_block_in_bio, get_block); | 435 | bio = do_mpage_readpage(bio, page, 1, &last_block_in_bio, |
436 | &map_bh, &first_logical_block, get_block); | ||
370 | if (bio) | 437 | if (bio) |
371 | mpage_bio_submit(READ, bio); | 438 | mpage_bio_submit(READ, bio); |
372 | return 0; | 439 | return 0; |
@@ -472,6 +539,7 @@ __mpage_writepage(struct bio *bio, struct page *page, get_block_t get_block, | |||
472 | for (page_block = 0; page_block < blocks_per_page; ) { | 539 | for (page_block = 0; page_block < blocks_per_page; ) { |
473 | 540 | ||
474 | map_bh.b_state = 0; | 541 | map_bh.b_state = 0; |
542 | map_bh.b_size = 1 << blkbits; | ||
475 | if (get_block(inode, block_in_file, &map_bh, 1)) | 543 | if (get_block(inode, block_in_file, &map_bh, 1)) |
476 | goto confused; | 544 | goto confused; |
477 | if (buffer_new(&map_bh)) | 545 | if (buffer_new(&map_bh)) |
diff --git a/fs/namei.c b/fs/namei.c index 98dc2e134362..22f6e8d16aa8 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -546,6 +546,22 @@ struct path { | |||
546 | struct dentry *dentry; | 546 | struct dentry *dentry; |
547 | }; | 547 | }; |
548 | 548 | ||
549 | static inline void dput_path(struct path *path, struct nameidata *nd) | ||
550 | { | ||
551 | dput(path->dentry); | ||
552 | if (path->mnt != nd->mnt) | ||
553 | mntput(path->mnt); | ||
554 | } | ||
555 | |||
556 | static inline void path_to_nameidata(struct path *path, struct nameidata *nd) | ||
557 | { | ||
558 | dput(nd->dentry); | ||
559 | if (nd->mnt != path->mnt) | ||
560 | mntput(nd->mnt); | ||
561 | nd->mnt = path->mnt; | ||
562 | nd->dentry = path->dentry; | ||
563 | } | ||
564 | |||
549 | static __always_inline int __do_follow_link(struct path *path, struct nameidata *nd) | 565 | static __always_inline int __do_follow_link(struct path *path, struct nameidata *nd) |
550 | { | 566 | { |
551 | int error; | 567 | int error; |
@@ -555,8 +571,11 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
555 | touch_atime(path->mnt, dentry); | 571 | touch_atime(path->mnt, dentry); |
556 | nd_set_link(nd, NULL); | 572 | nd_set_link(nd, NULL); |
557 | 573 | ||
558 | if (path->mnt == nd->mnt) | 574 | if (path->mnt != nd->mnt) { |
559 | mntget(path->mnt); | 575 | path_to_nameidata(path, nd); |
576 | dget(dentry); | ||
577 | } | ||
578 | mntget(path->mnt); | ||
560 | cookie = dentry->d_inode->i_op->follow_link(dentry, nd); | 579 | cookie = dentry->d_inode->i_op->follow_link(dentry, nd); |
561 | error = PTR_ERR(cookie); | 580 | error = PTR_ERR(cookie); |
562 | if (!IS_ERR(cookie)) { | 581 | if (!IS_ERR(cookie)) { |
@@ -573,22 +592,6 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
573 | return error; | 592 | return error; |
574 | } | 593 | } |
575 | 594 | ||
576 | static inline void dput_path(struct path *path, struct nameidata *nd) | ||
577 | { | ||
578 | dput(path->dentry); | ||
579 | if (path->mnt != nd->mnt) | ||
580 | mntput(path->mnt); | ||
581 | } | ||
582 | |||
583 | static inline void path_to_nameidata(struct path *path, struct nameidata *nd) | ||
584 | { | ||
585 | dput(nd->dentry); | ||
586 | if (nd->mnt != path->mnt) | ||
587 | mntput(nd->mnt); | ||
588 | nd->mnt = path->mnt; | ||
589 | nd->dentry = path->dentry; | ||
590 | } | ||
591 | |||
592 | /* | 595 | /* |
593 | * This limits recursive symlink follows to 8, while | 596 | * This limits recursive symlink follows to 8, while |
594 | * limiting consecutive symlinks to 40. | 597 | * limiting consecutive symlinks to 40. |
diff --git a/fs/namespace.c b/fs/namespace.c index 71e75bcf4d28..bf478addb852 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -43,9 +43,9 @@ __cacheline_aligned_in_smp DEFINE_SPINLOCK(vfsmount_lock); | |||
43 | 43 | ||
44 | static int event; | 44 | static int event; |
45 | 45 | ||
46 | static struct list_head *mount_hashtable; | 46 | static struct list_head *mount_hashtable __read_mostly; |
47 | static int hash_mask __read_mostly, hash_bits __read_mostly; | 47 | static int hash_mask __read_mostly, hash_bits __read_mostly; |
48 | static kmem_cache_t *mnt_cache; | 48 | static kmem_cache_t *mnt_cache __read_mostly; |
49 | static struct rw_semaphore namespace_sem; | 49 | static struct rw_semaphore namespace_sem; |
50 | 50 | ||
51 | /* /sys/fs */ | 51 | /* /sys/fs */ |
@@ -459,9 +459,9 @@ int may_umount_tree(struct vfsmount *mnt) | |||
459 | spin_unlock(&vfsmount_lock); | 459 | spin_unlock(&vfsmount_lock); |
460 | 460 | ||
461 | if (actual_refs > minimum_refs) | 461 | if (actual_refs > minimum_refs) |
462 | return -EBUSY; | 462 | return 0; |
463 | 463 | ||
464 | return 0; | 464 | return 1; |
465 | } | 465 | } |
466 | 466 | ||
467 | EXPORT_SYMBOL(may_umount_tree); | 467 | EXPORT_SYMBOL(may_umount_tree); |
@@ -481,10 +481,10 @@ EXPORT_SYMBOL(may_umount_tree); | |||
481 | */ | 481 | */ |
482 | int may_umount(struct vfsmount *mnt) | 482 | int may_umount(struct vfsmount *mnt) |
483 | { | 483 | { |
484 | int ret = 0; | 484 | int ret = 1; |
485 | spin_lock(&vfsmount_lock); | 485 | spin_lock(&vfsmount_lock); |
486 | if (propagate_mount_busy(mnt, 2)) | 486 | if (propagate_mount_busy(mnt, 2)) |
487 | ret = -EBUSY; | 487 | ret = 0; |
488 | spin_unlock(&vfsmount_lock); | 488 | spin_unlock(&vfsmount_lock); |
489 | return ret; | 489 | return ret; |
490 | } | 490 | } |
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index cfd76f431dc0..f0860c602d8b 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c | |||
@@ -49,7 +49,7 @@ extern int ncp_symlink(struct inode *, struct dentry *, const char *); | |||
49 | #define ncp_symlink NULL | 49 | #define ncp_symlink NULL |
50 | #endif | 50 | #endif |
51 | 51 | ||
52 | struct file_operations ncp_dir_operations = | 52 | const struct file_operations ncp_dir_operations = |
53 | { | 53 | { |
54 | .read = generic_read_dir, | 54 | .read = generic_read_dir, |
55 | .readdir = ncp_readdir, | 55 | .readdir = ncp_readdir, |
diff --git a/fs/ncpfs/file.c b/fs/ncpfs/file.c index ebdad8f6398f..e6b7c67cf057 100644 --- a/fs/ncpfs/file.c +++ b/fs/ncpfs/file.c | |||
@@ -283,7 +283,7 @@ static int ncp_release(struct inode *inode, struct file *file) { | |||
283 | return 0; | 283 | return 0; |
284 | } | 284 | } |
285 | 285 | ||
286 | struct file_operations ncp_file_operations = | 286 | const struct file_operations ncp_file_operations = |
287 | { | 287 | { |
288 | .llseek = remote_llseek, | 288 | .llseek = remote_llseek, |
289 | .read = ncp_file_read, | 289 | .read = ncp_file_read, |
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 99d2cfbce863..90c95adc8c1b 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/sunrpc/svc.h> | 14 | #include <linux/sunrpc/svc.h> |
15 | #include <linux/sunrpc/svcsock.h> | 15 | #include <linux/sunrpc/svcsock.h> |
16 | #include <linux/nfs_fs.h> | 16 | #include <linux/nfs_fs.h> |
17 | #include <linux/mutex.h> | ||
17 | 18 | ||
18 | #include <net/inet_sock.h> | 19 | #include <net/inet_sock.h> |
19 | 20 | ||
@@ -31,7 +32,7 @@ struct nfs_callback_data { | |||
31 | }; | 32 | }; |
32 | 33 | ||
33 | static struct nfs_callback_data nfs_callback_info; | 34 | static struct nfs_callback_data nfs_callback_info; |
34 | static DECLARE_MUTEX(nfs_callback_sema); | 35 | static DEFINE_MUTEX(nfs_callback_mutex); |
35 | static struct svc_program nfs4_callback_program; | 36 | static struct svc_program nfs4_callback_program; |
36 | 37 | ||
37 | unsigned int nfs_callback_set_tcpport; | 38 | unsigned int nfs_callback_set_tcpport; |
@@ -95,7 +96,7 @@ int nfs_callback_up(void) | |||
95 | int ret = 0; | 96 | int ret = 0; |
96 | 97 | ||
97 | lock_kernel(); | 98 | lock_kernel(); |
98 | down(&nfs_callback_sema); | 99 | mutex_lock(&nfs_callback_mutex); |
99 | if (nfs_callback_info.users++ || nfs_callback_info.pid != 0) | 100 | if (nfs_callback_info.users++ || nfs_callback_info.pid != 0) |
100 | goto out; | 101 | goto out; |
101 | init_completion(&nfs_callback_info.started); | 102 | init_completion(&nfs_callback_info.started); |
@@ -121,7 +122,7 @@ int nfs_callback_up(void) | |||
121 | nfs_callback_info.serv = serv; | 122 | nfs_callback_info.serv = serv; |
122 | wait_for_completion(&nfs_callback_info.started); | 123 | wait_for_completion(&nfs_callback_info.started); |
123 | out: | 124 | out: |
124 | up(&nfs_callback_sema); | 125 | mutex_unlock(&nfs_callback_mutex); |
125 | unlock_kernel(); | 126 | unlock_kernel(); |
126 | return ret; | 127 | return ret; |
127 | out_destroy: | 128 | out_destroy: |
@@ -139,7 +140,7 @@ int nfs_callback_down(void) | |||
139 | int ret = 0; | 140 | int ret = 0; |
140 | 141 | ||
141 | lock_kernel(); | 142 | lock_kernel(); |
142 | down(&nfs_callback_sema); | 143 | mutex_lock(&nfs_callback_mutex); |
143 | nfs_callback_info.users--; | 144 | nfs_callback_info.users--; |
144 | do { | 145 | do { |
145 | if (nfs_callback_info.users != 0 || nfs_callback_info.pid == 0) | 146 | if (nfs_callback_info.users != 0 || nfs_callback_info.pid == 0) |
@@ -147,7 +148,7 @@ int nfs_callback_down(void) | |||
147 | if (kill_proc(nfs_callback_info.pid, SIGKILL, 1) < 0) | 148 | if (kill_proc(nfs_callback_info.pid, SIGKILL, 1) < 0) |
148 | break; | 149 | break; |
149 | } while (wait_for_completion_timeout(&nfs_callback_info.stopped, 5*HZ) == 0); | 150 | } while (wait_for_completion_timeout(&nfs_callback_info.stopped, 5*HZ) == 0); |
150 | up(&nfs_callback_sema); | 151 | mutex_unlock(&nfs_callback_mutex); |
151 | unlock_kernel(); | 152 | unlock_kernel(); |
152 | return ret; | 153 | return ret; |
153 | } | 154 | } |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 06c48b385c94..a23f34894167 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
@@ -54,7 +54,7 @@ static int nfs_rename(struct inode *, struct dentry *, | |||
54 | static int nfs_fsync_dir(struct file *, struct dentry *, int); | 54 | static int nfs_fsync_dir(struct file *, struct dentry *, int); |
55 | static loff_t nfs_llseek_dir(struct file *, loff_t, int); | 55 | static loff_t nfs_llseek_dir(struct file *, loff_t, int); |
56 | 56 | ||
57 | struct file_operations nfs_dir_operations = { | 57 | const struct file_operations nfs_dir_operations = { |
58 | .llseek = nfs_llseek_dir, | 58 | .llseek = nfs_llseek_dir, |
59 | .read = generic_read_dir, | 59 | .read = generic_read_dir, |
60 | .readdir = nfs_readdir, | 60 | .readdir = nfs_readdir, |
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 5263b2864a44..f1df2c8d9259 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
@@ -49,7 +49,7 @@ static int nfs_check_flags(int flags); | |||
49 | static int nfs_lock(struct file *filp, int cmd, struct file_lock *fl); | 49 | static int nfs_lock(struct file *filp, int cmd, struct file_lock *fl); |
50 | static int nfs_flock(struct file *filp, int cmd, struct file_lock *fl); | 50 | static int nfs_flock(struct file *filp, int cmd, struct file_lock *fl); |
51 | 51 | ||
52 | struct file_operations nfs_file_operations = { | 52 | const struct file_operations nfs_file_operations = { |
53 | .llseek = nfs_file_llseek, | 53 | .llseek = nfs_file_llseek, |
54 | .read = do_sync_read, | 54 | .read = do_sync_read, |
55 | .write = do_sync_write, | 55 | .write = do_sync_write, |
@@ -318,10 +318,9 @@ static int nfs_commit_write(struct file *file, struct page *page, unsigned offse | |||
318 | return status; | 318 | return status; |
319 | } | 319 | } |
320 | 320 | ||
321 | static int nfs_invalidate_page(struct page *page, unsigned long offset) | 321 | static void nfs_invalidate_page(struct page *page, unsigned long offset) |
322 | { | 322 | { |
323 | /* FIXME: we really should cancel any unstarted writes on this page */ | 323 | /* FIXME: we really should cancel any unstarted writes on this page */ |
324 | return 1; | ||
325 | } | 324 | } |
326 | 325 | ||
327 | static int nfs_release_page(struct page *page, gfp_t gfp) | 326 | static int nfs_release_page(struct page *page, gfp_t gfp) |
diff --git a/fs/nfs/read.c b/fs/nfs/read.c index 3961524fd4ab..624ca7146b6b 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c | |||
@@ -663,10 +663,8 @@ int nfs_init_readpagecache(void) | |||
663 | if (nfs_rdata_cachep == NULL) | 663 | if (nfs_rdata_cachep == NULL) |
664 | return -ENOMEM; | 664 | return -ENOMEM; |
665 | 665 | ||
666 | nfs_rdata_mempool = mempool_create(MIN_POOL_READ, | 666 | nfs_rdata_mempool = mempool_create_slab_pool(MIN_POOL_READ, |
667 | mempool_alloc_slab, | 667 | nfs_rdata_cachep); |
668 | mempool_free_slab, | ||
669 | nfs_rdata_cachep); | ||
670 | if (nfs_rdata_mempool == NULL) | 668 | if (nfs_rdata_mempool == NULL) |
671 | return -ENOMEM; | 669 | return -ENOMEM; |
672 | 670 | ||
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 3f5225404c97..4cfada2cc09f 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -1521,17 +1521,13 @@ int nfs_init_writepagecache(void) | |||
1521 | if (nfs_wdata_cachep == NULL) | 1521 | if (nfs_wdata_cachep == NULL) |
1522 | return -ENOMEM; | 1522 | return -ENOMEM; |
1523 | 1523 | ||
1524 | nfs_wdata_mempool = mempool_create(MIN_POOL_WRITE, | 1524 | nfs_wdata_mempool = mempool_create_slab_pool(MIN_POOL_WRITE, |
1525 | mempool_alloc_slab, | 1525 | nfs_wdata_cachep); |
1526 | mempool_free_slab, | ||
1527 | nfs_wdata_cachep); | ||
1528 | if (nfs_wdata_mempool == NULL) | 1526 | if (nfs_wdata_mempool == NULL) |
1529 | return -ENOMEM; | 1527 | return -ENOMEM; |
1530 | 1528 | ||
1531 | nfs_commit_mempool = mempool_create(MIN_POOL_COMMIT, | 1529 | nfs_commit_mempool = mempool_create_slab_pool(MIN_POOL_COMMIT, |
1532 | mempool_alloc_slab, | 1530 | nfs_wdata_cachep); |
1533 | mempool_free_slab, | ||
1534 | nfs_wdata_cachep); | ||
1535 | if (nfs_commit_mempool == NULL) | 1531 | if (nfs_commit_mempool == NULL) |
1536 | return -ENOMEM; | 1532 | return -ENOMEM; |
1537 | 1533 | ||
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index 417ec02df44f..c340be0a3f59 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c | |||
@@ -57,27 +57,17 @@ static int exp_verify_string(char *cp, int max); | |||
57 | #define EXPKEY_HASHMASK (EXPKEY_HASHMAX -1) | 57 | #define EXPKEY_HASHMASK (EXPKEY_HASHMAX -1) |
58 | static struct cache_head *expkey_table[EXPKEY_HASHMAX]; | 58 | static struct cache_head *expkey_table[EXPKEY_HASHMAX]; |
59 | 59 | ||
60 | static inline int svc_expkey_hash(struct svc_expkey *item) | 60 | static void expkey_put(struct kref *ref) |
61 | { | 61 | { |
62 | int hash = item->ek_fsidtype; | 62 | struct svc_expkey *key = container_of(ref, struct svc_expkey, h.ref); |
63 | char * cp = (char*)item->ek_fsid; | ||
64 | int len = key_len(item->ek_fsidtype); | ||
65 | 63 | ||
66 | hash ^= hash_mem(cp, len, EXPKEY_HASHBITS); | 64 | if (test_bit(CACHE_VALID, &key->h.flags) && |
67 | hash ^= hash_ptr(item->ek_client, EXPKEY_HASHBITS); | 65 | !test_bit(CACHE_NEGATIVE, &key->h.flags)) { |
68 | return hash & EXPKEY_HASHMASK; | 66 | dput(key->ek_dentry); |
69 | } | 67 | mntput(key->ek_mnt); |
70 | |||
71 | void expkey_put(struct cache_head *item, struct cache_detail *cd) | ||
72 | { | ||
73 | if (cache_put(item, cd)) { | ||
74 | struct svc_expkey *key = container_of(item, struct svc_expkey, h); | ||
75 | if (test_bit(CACHE_VALID, &item->flags) && | ||
76 | !test_bit(CACHE_NEGATIVE, &item->flags)) | ||
77 | exp_put(key->ek_export); | ||
78 | auth_domain_put(key->ek_client); | ||
79 | kfree(key); | ||
80 | } | 68 | } |
69 | auth_domain_put(key->ek_client); | ||
70 | kfree(key); | ||
81 | } | 71 | } |
82 | 72 | ||
83 | static void expkey_request(struct cache_detail *cd, | 73 | static void expkey_request(struct cache_detail *cd, |
@@ -95,7 +85,10 @@ static void expkey_request(struct cache_detail *cd, | |||
95 | (*bpp)[-1] = '\n'; | 85 | (*bpp)[-1] = '\n'; |
96 | } | 86 | } |
97 | 87 | ||
98 | static struct svc_expkey *svc_expkey_lookup(struct svc_expkey *, int); | 88 | static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old); |
89 | static struct svc_expkey *svc_expkey_lookup(struct svc_expkey *); | ||
90 | static struct cache_detail svc_expkey_cache; | ||
91 | |||
99 | static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen) | 92 | static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen) |
100 | { | 93 | { |
101 | /* client fsidtype fsid [path] */ | 94 | /* client fsidtype fsid [path] */ |
@@ -106,6 +99,7 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen) | |||
106 | int fsidtype; | 99 | int fsidtype; |
107 | char *ep; | 100 | char *ep; |
108 | struct svc_expkey key; | 101 | struct svc_expkey key; |
102 | struct svc_expkey *ek; | ||
109 | 103 | ||
110 | if (mesg[mlen-1] != '\n') | 104 | if (mesg[mlen-1] != '\n') |
111 | return -EINVAL; | 105 | return -EINVAL; |
@@ -150,40 +144,38 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen) | |||
150 | key.ek_fsidtype = fsidtype; | 144 | key.ek_fsidtype = fsidtype; |
151 | memcpy(key.ek_fsid, buf, len); | 145 | memcpy(key.ek_fsid, buf, len); |
152 | 146 | ||
147 | ek = svc_expkey_lookup(&key); | ||
148 | err = -ENOMEM; | ||
149 | if (!ek) | ||
150 | goto out; | ||
151 | |||
153 | /* now we want a pathname, or empty meaning NEGATIVE */ | 152 | /* now we want a pathname, or empty meaning NEGATIVE */ |
153 | err = -EINVAL; | ||
154 | if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) | 154 | if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) |
155 | goto out; | 155 | goto out; |
156 | dprintk("Path seems to be <%s>\n", buf); | 156 | dprintk("Path seems to be <%s>\n", buf); |
157 | err = 0; | 157 | err = 0; |
158 | if (len == 0) { | 158 | if (len == 0) { |
159 | struct svc_expkey *ek; | ||
160 | set_bit(CACHE_NEGATIVE, &key.h.flags); | 159 | set_bit(CACHE_NEGATIVE, &key.h.flags); |
161 | ek = svc_expkey_lookup(&key, 1); | 160 | ek = svc_expkey_update(&key, ek); |
162 | if (ek) | 161 | if (ek) |
163 | expkey_put(&ek->h, &svc_expkey_cache); | 162 | cache_put(&ek->h, &svc_expkey_cache); |
163 | else err = -ENOMEM; | ||
164 | } else { | 164 | } else { |
165 | struct nameidata nd; | 165 | struct nameidata nd; |
166 | struct svc_expkey *ek; | ||
167 | struct svc_export *exp; | ||
168 | err = path_lookup(buf, 0, &nd); | 166 | err = path_lookup(buf, 0, &nd); |
169 | if (err) | 167 | if (err) |
170 | goto out; | 168 | goto out; |
171 | 169 | ||
172 | dprintk("Found the path %s\n", buf); | 170 | dprintk("Found the path %s\n", buf); |
173 | exp = exp_get_by_name(dom, nd.mnt, nd.dentry, NULL); | 171 | key.ek_mnt = nd.mnt; |
174 | 172 | key.ek_dentry = nd.dentry; | |
175 | err = -ENOENT; | ||
176 | if (!exp) | ||
177 | goto out_nd; | ||
178 | key.ek_export = exp; | ||
179 | dprintk("And found export\n"); | ||
180 | 173 | ||
181 | ek = svc_expkey_lookup(&key, 1); | 174 | ek = svc_expkey_update(&key, ek); |
182 | if (ek) | 175 | if (ek) |
183 | expkey_put(&ek->h, &svc_expkey_cache); | 176 | cache_put(&ek->h, &svc_expkey_cache); |
184 | exp_put(exp); | 177 | else |
185 | err = 0; | 178 | err = -ENOMEM; |
186 | out_nd: | ||
187 | path_release(&nd); | 179 | path_release(&nd); |
188 | } | 180 | } |
189 | cache_flush(); | 181 | cache_flush(); |
@@ -214,35 +206,31 @@ static int expkey_show(struct seq_file *m, | |||
214 | if (test_bit(CACHE_VALID, &h->flags) && | 206 | if (test_bit(CACHE_VALID, &h->flags) && |
215 | !test_bit(CACHE_NEGATIVE, &h->flags)) { | 207 | !test_bit(CACHE_NEGATIVE, &h->flags)) { |
216 | seq_printf(m, " "); | 208 | seq_printf(m, " "); |
217 | seq_path(m, ek->ek_export->ex_mnt, ek->ek_export->ex_dentry, "\\ \t\n"); | 209 | seq_path(m, ek->ek_mnt, ek->ek_dentry, "\\ \t\n"); |
218 | } | 210 | } |
219 | seq_printf(m, "\n"); | 211 | seq_printf(m, "\n"); |
220 | return 0; | 212 | return 0; |
221 | } | 213 | } |
222 | |||
223 | struct cache_detail svc_expkey_cache = { | ||
224 | .owner = THIS_MODULE, | ||
225 | .hash_size = EXPKEY_HASHMAX, | ||
226 | .hash_table = expkey_table, | ||
227 | .name = "nfsd.fh", | ||
228 | .cache_put = expkey_put, | ||
229 | .cache_request = expkey_request, | ||
230 | .cache_parse = expkey_parse, | ||
231 | .cache_show = expkey_show, | ||
232 | }; | ||
233 | 214 | ||
234 | static inline int svc_expkey_match (struct svc_expkey *a, struct svc_expkey *b) | 215 | static inline int expkey_match (struct cache_head *a, struct cache_head *b) |
235 | { | 216 | { |
236 | if (a->ek_fsidtype != b->ek_fsidtype || | 217 | struct svc_expkey *orig = container_of(a, struct svc_expkey, h); |
237 | a->ek_client != b->ek_client || | 218 | struct svc_expkey *new = container_of(b, struct svc_expkey, h); |
238 | memcmp(a->ek_fsid, b->ek_fsid, key_len(a->ek_fsidtype)) != 0) | 219 | |
220 | if (orig->ek_fsidtype != new->ek_fsidtype || | ||
221 | orig->ek_client != new->ek_client || | ||
222 | memcmp(orig->ek_fsid, new->ek_fsid, key_len(orig->ek_fsidtype)) != 0) | ||
239 | return 0; | 223 | return 0; |
240 | return 1; | 224 | return 1; |
241 | } | 225 | } |
242 | 226 | ||
243 | static inline void svc_expkey_init(struct svc_expkey *new, struct svc_expkey *item) | 227 | static inline void expkey_init(struct cache_head *cnew, |
228 | struct cache_head *citem) | ||
244 | { | 229 | { |
245 | cache_get(&item->ek_client->h); | 230 | struct svc_expkey *new = container_of(cnew, struct svc_expkey, h); |
231 | struct svc_expkey *item = container_of(citem, struct svc_expkey, h); | ||
232 | |||
233 | kref_get(&item->ek_client->ref); | ||
246 | new->ek_client = item->ek_client; | 234 | new->ek_client = item->ek_client; |
247 | new->ek_fsidtype = item->ek_fsidtype; | 235 | new->ek_fsidtype = item->ek_fsidtype; |
248 | new->ek_fsid[0] = item->ek_fsid[0]; | 236 | new->ek_fsid[0] = item->ek_fsid[0]; |
@@ -250,39 +238,94 @@ static inline void svc_expkey_init(struct svc_expkey *new, struct svc_expkey *it | |||
250 | new->ek_fsid[2] = item->ek_fsid[2]; | 238 | new->ek_fsid[2] = item->ek_fsid[2]; |
251 | } | 239 | } |
252 | 240 | ||
253 | static inline void svc_expkey_update(struct svc_expkey *new, struct svc_expkey *item) | 241 | static inline void expkey_update(struct cache_head *cnew, |
242 | struct cache_head *citem) | ||
243 | { | ||
244 | struct svc_expkey *new = container_of(cnew, struct svc_expkey, h); | ||
245 | struct svc_expkey *item = container_of(citem, struct svc_expkey, h); | ||
246 | |||
247 | new->ek_mnt = mntget(item->ek_mnt); | ||
248 | new->ek_dentry = dget(item->ek_dentry); | ||
249 | } | ||
250 | |||
251 | static struct cache_head *expkey_alloc(void) | ||
254 | { | 252 | { |
255 | cache_get(&item->ek_export->h); | 253 | struct svc_expkey *i = kmalloc(sizeof(*i), GFP_KERNEL); |
256 | new->ek_export = item->ek_export; | 254 | if (i) |
255 | return &i->h; | ||
256 | else | ||
257 | return NULL; | ||
257 | } | 258 | } |
258 | 259 | ||
259 | static DefineSimpleCacheLookup(svc_expkey,0) /* no inplace updates */ | 260 | static struct cache_detail svc_expkey_cache = { |
261 | .owner = THIS_MODULE, | ||
262 | .hash_size = EXPKEY_HASHMAX, | ||
263 | .hash_table = expkey_table, | ||
264 | .name = "nfsd.fh", | ||
265 | .cache_put = expkey_put, | ||
266 | .cache_request = expkey_request, | ||
267 | .cache_parse = expkey_parse, | ||
268 | .cache_show = expkey_show, | ||
269 | .match = expkey_match, | ||
270 | .init = expkey_init, | ||
271 | .update = expkey_update, | ||
272 | .alloc = expkey_alloc, | ||
273 | }; | ||
260 | 274 | ||
261 | #define EXPORT_HASHBITS 8 | 275 | static struct svc_expkey * |
262 | #define EXPORT_HASHMAX (1<< EXPORT_HASHBITS) | 276 | svc_expkey_lookup(struct svc_expkey *item) |
263 | #define EXPORT_HASHMASK (EXPORT_HASHMAX -1) | 277 | { |
278 | struct cache_head *ch; | ||
279 | int hash = item->ek_fsidtype; | ||
280 | char * cp = (char*)item->ek_fsid; | ||
281 | int len = key_len(item->ek_fsidtype); | ||
264 | 282 | ||
265 | static struct cache_head *export_table[EXPORT_HASHMAX]; | 283 | hash ^= hash_mem(cp, len, EXPKEY_HASHBITS); |
284 | hash ^= hash_ptr(item->ek_client, EXPKEY_HASHBITS); | ||
285 | hash &= EXPKEY_HASHMASK; | ||
266 | 286 | ||
267 | static inline int svc_export_hash(struct svc_export *item) | 287 | ch = sunrpc_cache_lookup(&svc_expkey_cache, &item->h, |
288 | hash); | ||
289 | if (ch) | ||
290 | return container_of(ch, struct svc_expkey, h); | ||
291 | else | ||
292 | return NULL; | ||
293 | } | ||
294 | |||
295 | static struct svc_expkey * | ||
296 | svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old) | ||
268 | { | 297 | { |
269 | int rv; | 298 | struct cache_head *ch; |
299 | int hash = new->ek_fsidtype; | ||
300 | char * cp = (char*)new->ek_fsid; | ||
301 | int len = key_len(new->ek_fsidtype); | ||
270 | 302 | ||
271 | rv = hash_ptr(item->ex_client, EXPORT_HASHBITS); | 303 | hash ^= hash_mem(cp, len, EXPKEY_HASHBITS); |
272 | rv ^= hash_ptr(item->ex_dentry, EXPORT_HASHBITS); | 304 | hash ^= hash_ptr(new->ek_client, EXPKEY_HASHBITS); |
273 | rv ^= hash_ptr(item->ex_mnt, EXPORT_HASHBITS); | 305 | hash &= EXPKEY_HASHMASK; |
274 | return rv; | 306 | |
307 | ch = sunrpc_cache_update(&svc_expkey_cache, &new->h, | ||
308 | &old->h, hash); | ||
309 | if (ch) | ||
310 | return container_of(ch, struct svc_expkey, h); | ||
311 | else | ||
312 | return NULL; | ||
275 | } | 313 | } |
276 | 314 | ||
277 | void svc_export_put(struct cache_head *item, struct cache_detail *cd) | 315 | |
316 | #define EXPORT_HASHBITS 8 | ||
317 | #define EXPORT_HASHMAX (1<< EXPORT_HASHBITS) | ||
318 | #define EXPORT_HASHMASK (EXPORT_HASHMAX -1) | ||
319 | |||
320 | static struct cache_head *export_table[EXPORT_HASHMAX]; | ||
321 | |||
322 | static void svc_export_put(struct kref *ref) | ||
278 | { | 323 | { |
279 | if (cache_put(item, cd)) { | 324 | struct svc_export *exp = container_of(ref, struct svc_export, h.ref); |
280 | struct svc_export *exp = container_of(item, struct svc_export, h); | 325 | dput(exp->ex_dentry); |
281 | dput(exp->ex_dentry); | 326 | mntput(exp->ex_mnt); |
282 | mntput(exp->ex_mnt); | 327 | auth_domain_put(exp->ex_client); |
283 | auth_domain_put(exp->ex_client); | 328 | kfree(exp); |
284 | kfree(exp); | ||
285 | } | ||
286 | } | 329 | } |
287 | 330 | ||
288 | static void svc_export_request(struct cache_detail *cd, | 331 | static void svc_export_request(struct cache_detail *cd, |
@@ -304,7 +347,9 @@ static void svc_export_request(struct cache_detail *cd, | |||
304 | (*bpp)[-1] = '\n'; | 347 | (*bpp)[-1] = '\n'; |
305 | } | 348 | } |
306 | 349 | ||
307 | static struct svc_export *svc_export_lookup(struct svc_export *, int); | 350 | static struct svc_export *svc_export_update(struct svc_export *new, |
351 | struct svc_export *old); | ||
352 | static struct svc_export *svc_export_lookup(struct svc_export *); | ||
308 | 353 | ||
309 | static int check_export(struct inode *inode, int flags) | 354 | static int check_export(struct inode *inode, int flags) |
310 | { | 355 | { |
@@ -417,11 +462,16 @@ static int svc_export_parse(struct cache_detail *cd, char *mesg, int mlen) | |||
417 | if (err) goto out; | 462 | if (err) goto out; |
418 | } | 463 | } |
419 | 464 | ||
420 | expp = svc_export_lookup(&exp, 1); | 465 | expp = svc_export_lookup(&exp); |
421 | if (expp) | 466 | if (expp) |
422 | exp_put(expp); | 467 | expp = svc_export_update(&exp, expp); |
423 | err = 0; | 468 | else |
469 | err = -ENOMEM; | ||
424 | cache_flush(); | 470 | cache_flush(); |
471 | if (expp == NULL) | ||
472 | err = -ENOMEM; | ||
473 | else | ||
474 | exp_put(expp); | ||
425 | out: | 475 | out: |
426 | if (nd.dentry) | 476 | if (nd.dentry) |
427 | path_release(&nd); | 477 | path_release(&nd); |
@@ -455,6 +505,46 @@ static int svc_export_show(struct seq_file *m, | |||
455 | seq_puts(m, ")\n"); | 505 | seq_puts(m, ")\n"); |
456 | return 0; | 506 | return 0; |
457 | } | 507 | } |
508 | static int svc_export_match(struct cache_head *a, struct cache_head *b) | ||
509 | { | ||
510 | struct svc_export *orig = container_of(a, struct svc_export, h); | ||
511 | struct svc_export *new = container_of(b, struct svc_export, h); | ||
512 | return orig->ex_client == new->ex_client && | ||
513 | orig->ex_dentry == new->ex_dentry && | ||
514 | orig->ex_mnt == new->ex_mnt; | ||
515 | } | ||
516 | |||
517 | static void svc_export_init(struct cache_head *cnew, struct cache_head *citem) | ||
518 | { | ||
519 | struct svc_export *new = container_of(cnew, struct svc_export, h); | ||
520 | struct svc_export *item = container_of(citem, struct svc_export, h); | ||
521 | |||
522 | kref_get(&item->ex_client->ref); | ||
523 | new->ex_client = item->ex_client; | ||
524 | new->ex_dentry = dget(item->ex_dentry); | ||
525 | new->ex_mnt = mntget(item->ex_mnt); | ||
526 | } | ||
527 | |||
528 | static void export_update(struct cache_head *cnew, struct cache_head *citem) | ||
529 | { | ||
530 | struct svc_export *new = container_of(cnew, struct svc_export, h); | ||
531 | struct svc_export *item = container_of(citem, struct svc_export, h); | ||
532 | |||
533 | new->ex_flags = item->ex_flags; | ||
534 | new->ex_anon_uid = item->ex_anon_uid; | ||
535 | new->ex_anon_gid = item->ex_anon_gid; | ||
536 | new->ex_fsid = item->ex_fsid; | ||
537 | } | ||
538 | |||
539 | static struct cache_head *svc_export_alloc(void) | ||
540 | { | ||
541 | struct svc_export *i = kmalloc(sizeof(*i), GFP_KERNEL); | ||
542 | if (i) | ||
543 | return &i->h; | ||
544 | else | ||
545 | return NULL; | ||
546 | } | ||
547 | |||
458 | struct cache_detail svc_export_cache = { | 548 | struct cache_detail svc_export_cache = { |
459 | .owner = THIS_MODULE, | 549 | .owner = THIS_MODULE, |
460 | .hash_size = EXPORT_HASHMAX, | 550 | .hash_size = EXPORT_HASHMAX, |
@@ -464,34 +554,49 @@ struct cache_detail svc_export_cache = { | |||
464 | .cache_request = svc_export_request, | 554 | .cache_request = svc_export_request, |
465 | .cache_parse = svc_export_parse, | 555 | .cache_parse = svc_export_parse, |
466 | .cache_show = svc_export_show, | 556 | .cache_show = svc_export_show, |
557 | .match = svc_export_match, | ||
558 | .init = svc_export_init, | ||
559 | .update = export_update, | ||
560 | .alloc = svc_export_alloc, | ||
467 | }; | 561 | }; |
468 | 562 | ||
469 | static inline int svc_export_match(struct svc_export *a, struct svc_export *b) | 563 | static struct svc_export * |
564 | svc_export_lookup(struct svc_export *exp) | ||
470 | { | 565 | { |
471 | return a->ex_client == b->ex_client && | 566 | struct cache_head *ch; |
472 | a->ex_dentry == b->ex_dentry && | 567 | int hash; |
473 | a->ex_mnt == b->ex_mnt; | 568 | hash = hash_ptr(exp->ex_client, EXPORT_HASHBITS); |
474 | } | 569 | hash ^= hash_ptr(exp->ex_dentry, EXPORT_HASHBITS); |
475 | static inline void svc_export_init(struct svc_export *new, struct svc_export *item) | 570 | hash ^= hash_ptr(exp->ex_mnt, EXPORT_HASHBITS); |
476 | { | 571 | |
477 | cache_get(&item->ex_client->h); | 572 | ch = sunrpc_cache_lookup(&svc_export_cache, &exp->h, |
478 | new->ex_client = item->ex_client; | 573 | hash); |
479 | new->ex_dentry = dget(item->ex_dentry); | 574 | if (ch) |
480 | new->ex_mnt = mntget(item->ex_mnt); | 575 | return container_of(ch, struct svc_export, h); |
576 | else | ||
577 | return NULL; | ||
481 | } | 578 | } |
482 | 579 | ||
483 | static inline void svc_export_update(struct svc_export *new, struct svc_export *item) | 580 | static struct svc_export * |
581 | svc_export_update(struct svc_export *new, struct svc_export *old) | ||
484 | { | 582 | { |
485 | new->ex_flags = item->ex_flags; | 583 | struct cache_head *ch; |
486 | new->ex_anon_uid = item->ex_anon_uid; | 584 | int hash; |
487 | new->ex_anon_gid = item->ex_anon_gid; | 585 | hash = hash_ptr(old->ex_client, EXPORT_HASHBITS); |
488 | new->ex_fsid = item->ex_fsid; | 586 | hash ^= hash_ptr(old->ex_dentry, EXPORT_HASHBITS); |
587 | hash ^= hash_ptr(old->ex_mnt, EXPORT_HASHBITS); | ||
588 | |||
589 | ch = sunrpc_cache_update(&svc_export_cache, &new->h, | ||
590 | &old->h, | ||
591 | hash); | ||
592 | if (ch) | ||
593 | return container_of(ch, struct svc_export, h); | ||
594 | else | ||
595 | return NULL; | ||
489 | } | 596 | } |
490 | 597 | ||
491 | static DefineSimpleCacheLookup(svc_export,1) /* allow inplace updates */ | ||
492 | 598 | ||
493 | 599 | static struct svc_expkey * | |
494 | struct svc_expkey * | ||
495 | exp_find_key(svc_client *clp, int fsid_type, u32 *fsidv, struct cache_req *reqp) | 600 | exp_find_key(svc_client *clp, int fsid_type, u32 *fsidv, struct cache_req *reqp) |
496 | { | 601 | { |
497 | struct svc_expkey key, *ek; | 602 | struct svc_expkey key, *ek; |
@@ -504,7 +609,7 @@ exp_find_key(svc_client *clp, int fsid_type, u32 *fsidv, struct cache_req *reqp) | |||
504 | key.ek_fsidtype = fsid_type; | 609 | key.ek_fsidtype = fsid_type; |
505 | memcpy(key.ek_fsid, fsidv, key_len(fsid_type)); | 610 | memcpy(key.ek_fsid, fsidv, key_len(fsid_type)); |
506 | 611 | ||
507 | ek = svc_expkey_lookup(&key, 0); | 612 | ek = svc_expkey_lookup(&key); |
508 | if (ek != NULL) | 613 | if (ek != NULL) |
509 | if ((err = cache_check(&svc_expkey_cache, &ek->h, reqp))) | 614 | if ((err = cache_check(&svc_expkey_cache, &ek->h, reqp))) |
510 | ek = ERR_PTR(err); | 615 | ek = ERR_PTR(err); |
@@ -519,13 +624,16 @@ static int exp_set_key(svc_client *clp, int fsid_type, u32 *fsidv, | |||
519 | key.ek_client = clp; | 624 | key.ek_client = clp; |
520 | key.ek_fsidtype = fsid_type; | 625 | key.ek_fsidtype = fsid_type; |
521 | memcpy(key.ek_fsid, fsidv, key_len(fsid_type)); | 626 | memcpy(key.ek_fsid, fsidv, key_len(fsid_type)); |
522 | key.ek_export = exp; | 627 | key.ek_mnt = exp->ex_mnt; |
628 | key.ek_dentry = exp->ex_dentry; | ||
523 | key.h.expiry_time = NEVER; | 629 | key.h.expiry_time = NEVER; |
524 | key.h.flags = 0; | 630 | key.h.flags = 0; |
525 | 631 | ||
526 | ek = svc_expkey_lookup(&key, 1); | 632 | ek = svc_expkey_lookup(&key); |
633 | if (ek) | ||
634 | ek = svc_expkey_update(&key,ek); | ||
527 | if (ek) { | 635 | if (ek) { |
528 | expkey_put(&ek->h, &svc_expkey_cache); | 636 | cache_put(&ek->h, &svc_expkey_cache); |
529 | return 0; | 637 | return 0; |
530 | } | 638 | } |
531 | return -ENOMEM; | 639 | return -ENOMEM; |
@@ -573,7 +681,7 @@ exp_get_by_name(svc_client *clp, struct vfsmount *mnt, struct dentry *dentry, | |||
573 | key.ex_mnt = mnt; | 681 | key.ex_mnt = mnt; |
574 | key.ex_dentry = dentry; | 682 | key.ex_dentry = dentry; |
575 | 683 | ||
576 | exp = svc_export_lookup(&key, 0); | 684 | exp = svc_export_lookup(&key); |
577 | if (exp != NULL) | 685 | if (exp != NULL) |
578 | switch (cache_check(&svc_export_cache, &exp->h, reqp)) { | 686 | switch (cache_check(&svc_export_cache, &exp->h, reqp)) { |
579 | case 0: break; | 687 | case 0: break; |
@@ -654,7 +762,7 @@ static void exp_fsid_unhash(struct svc_export *exp) | |||
654 | ek = exp_get_fsid_key(exp->ex_client, exp->ex_fsid); | 762 | ek = exp_get_fsid_key(exp->ex_client, exp->ex_fsid); |
655 | if (ek && !IS_ERR(ek)) { | 763 | if (ek && !IS_ERR(ek)) { |
656 | ek->h.expiry_time = get_seconds()-1; | 764 | ek->h.expiry_time = get_seconds()-1; |
657 | expkey_put(&ek->h, &svc_expkey_cache); | 765 | cache_put(&ek->h, &svc_expkey_cache); |
658 | } | 766 | } |
659 | svc_expkey_cache.nextcheck = get_seconds(); | 767 | svc_expkey_cache.nextcheck = get_seconds(); |
660 | } | 768 | } |
@@ -692,7 +800,7 @@ static void exp_unhash(struct svc_export *exp) | |||
692 | ek = exp_get_key(exp->ex_client, inode->i_sb->s_dev, inode->i_ino); | 800 | ek = exp_get_key(exp->ex_client, inode->i_sb->s_dev, inode->i_ino); |
693 | if (ek && !IS_ERR(ek)) { | 801 | if (ek && !IS_ERR(ek)) { |
694 | ek->h.expiry_time = get_seconds()-1; | 802 | ek->h.expiry_time = get_seconds()-1; |
695 | expkey_put(&ek->h, &svc_expkey_cache); | 803 | cache_put(&ek->h, &svc_expkey_cache); |
696 | } | 804 | } |
697 | svc_expkey_cache.nextcheck = get_seconds(); | 805 | svc_expkey_cache.nextcheck = get_seconds(); |
698 | } | 806 | } |
@@ -741,8 +849,8 @@ exp_export(struct nfsctl_export *nxp) | |||
741 | if ((nxp->ex_flags & NFSEXP_FSID) && | 849 | if ((nxp->ex_flags & NFSEXP_FSID) && |
742 | (fsid_key = exp_get_fsid_key(clp, nxp->ex_dev)) && | 850 | (fsid_key = exp_get_fsid_key(clp, nxp->ex_dev)) && |
743 | !IS_ERR(fsid_key) && | 851 | !IS_ERR(fsid_key) && |
744 | fsid_key->ek_export && | 852 | fsid_key->ek_mnt && |
745 | fsid_key->ek_export != exp) | 853 | (fsid_key->ek_mnt != nd.mnt || fsid_key->ek_dentry != nd.dentry) ) |
746 | goto finish; | 854 | goto finish; |
747 | 855 | ||
748 | if (exp) { | 856 | if (exp) { |
@@ -775,13 +883,13 @@ exp_export(struct nfsctl_export *nxp) | |||
775 | new.ex_anon_gid = nxp->ex_anon_gid; | 883 | new.ex_anon_gid = nxp->ex_anon_gid; |
776 | new.ex_fsid = nxp->ex_dev; | 884 | new.ex_fsid = nxp->ex_dev; |
777 | 885 | ||
778 | exp = svc_export_lookup(&new, 1); | 886 | exp = svc_export_lookup(&new); |
887 | if (exp) | ||
888 | exp = svc_export_update(&new, exp); | ||
779 | 889 | ||
780 | if (exp == NULL) | 890 | if (!exp) |
781 | goto finish; | 891 | goto finish; |
782 | 892 | ||
783 | err = 0; | ||
784 | |||
785 | if (exp_hash(clp, exp) || | 893 | if (exp_hash(clp, exp) || |
786 | exp_fsid_hash(clp, exp)) { | 894 | exp_fsid_hash(clp, exp)) { |
787 | /* failed to create at least one index */ | 895 | /* failed to create at least one index */ |
@@ -794,7 +902,7 @@ finish: | |||
794 | if (exp) | 902 | if (exp) |
795 | exp_put(exp); | 903 | exp_put(exp); |
796 | if (fsid_key && !IS_ERR(fsid_key)) | 904 | if (fsid_key && !IS_ERR(fsid_key)) |
797 | expkey_put(&fsid_key->h, &svc_expkey_cache); | 905 | cache_put(&fsid_key->h, &svc_expkey_cache); |
798 | if (clp) | 906 | if (clp) |
799 | auth_domain_put(clp); | 907 | auth_domain_put(clp); |
800 | path_release(&nd); | 908 | path_release(&nd); |
@@ -912,6 +1020,24 @@ out: | |||
912 | return err; | 1020 | return err; |
913 | } | 1021 | } |
914 | 1022 | ||
1023 | struct svc_export * | ||
1024 | exp_find(struct auth_domain *clp, int fsid_type, u32 *fsidv, | ||
1025 | struct cache_req *reqp) | ||
1026 | { | ||
1027 | struct svc_export *exp; | ||
1028 | struct svc_expkey *ek = exp_find_key(clp, fsid_type, fsidv, reqp); | ||
1029 | if (!ek || IS_ERR(ek)) | ||
1030 | return ERR_PTR(PTR_ERR(ek)); | ||
1031 | |||
1032 | exp = exp_get_by_name(clp, ek->ek_mnt, ek->ek_dentry, reqp); | ||
1033 | cache_put(&ek->h, &svc_expkey_cache); | ||
1034 | |||
1035 | if (!exp || IS_ERR(exp)) | ||
1036 | return ERR_PTR(PTR_ERR(exp)); | ||
1037 | return exp; | ||
1038 | } | ||
1039 | |||
1040 | |||
915 | /* | 1041 | /* |
916 | * Called when we need the filehandle for the root of the pseudofs, | 1042 | * Called when we need the filehandle for the root of the pseudofs, |
917 | * for a given NFSv4 client. The root is defined to be the | 1043 | * for a given NFSv4 client. The root is defined to be the |
@@ -922,6 +1048,7 @@ exp_pseudoroot(struct auth_domain *clp, struct svc_fh *fhp, | |||
922 | struct cache_req *creq) | 1048 | struct cache_req *creq) |
923 | { | 1049 | { |
924 | struct svc_expkey *fsid_key; | 1050 | struct svc_expkey *fsid_key; |
1051 | struct svc_export *exp; | ||
925 | int rv; | 1052 | int rv; |
926 | u32 fsidv[2]; | 1053 | u32 fsidv[2]; |
927 | 1054 | ||
@@ -933,9 +1060,15 @@ exp_pseudoroot(struct auth_domain *clp, struct svc_fh *fhp, | |||
933 | if (!fsid_key || IS_ERR(fsid_key)) | 1060 | if (!fsid_key || IS_ERR(fsid_key)) |
934 | return nfserr_perm; | 1061 | return nfserr_perm; |
935 | 1062 | ||
936 | rv = fh_compose(fhp, fsid_key->ek_export, | 1063 | exp = exp_get_by_name(clp, fsid_key->ek_mnt, fsid_key->ek_dentry, creq); |
937 | fsid_key->ek_export->ex_dentry, NULL); | 1064 | if (exp == NULL) |
938 | expkey_put(&fsid_key->h, &svc_expkey_cache); | 1065 | rv = nfserr_perm; |
1066 | else if (IS_ERR(exp)) | ||
1067 | rv = nfserrno(PTR_ERR(exp)); | ||
1068 | else | ||
1069 | rv = fh_compose(fhp, exp, | ||
1070 | fsid_key->ek_dentry, NULL); | ||
1071 | cache_put(&fsid_key->h, &svc_expkey_cache); | ||
939 | return rv; | 1072 | return rv; |
940 | } | 1073 | } |
941 | 1074 | ||
@@ -1054,7 +1187,7 @@ static int e_show(struct seq_file *m, void *p) | |||
1054 | cache_get(&exp->h); | 1187 | cache_get(&exp->h); |
1055 | if (cache_check(&svc_export_cache, &exp->h, NULL)) | 1188 | if (cache_check(&svc_export_cache, &exp->h, NULL)) |
1056 | return 0; | 1189 | return 0; |
1057 | if (cache_put(&exp->h, &svc_export_cache)) BUG(); | 1190 | cache_put(&exp->h, &svc_export_cache); |
1058 | return svc_export_show(m, &svc_export_cache, cp); | 1191 | return svc_export_show(m, &svc_export_cache, cp); |
1059 | } | 1192 | } |
1060 | 1193 | ||
@@ -1129,7 +1262,6 @@ exp_delclient(struct nfsctl_client *ncp) | |||
1129 | */ | 1262 | */ |
1130 | if (dom) { | 1263 | if (dom) { |
1131 | err = auth_unix_forget_old(dom); | 1264 | err = auth_unix_forget_old(dom); |
1132 | dom->h.expiry_time = get_seconds(); | ||
1133 | auth_domain_put(dom); | 1265 | auth_domain_put(dom); |
1134 | } | 1266 | } |
1135 | 1267 | ||
diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c index 13369650cdf9..4b6aa60dfceb 100644 --- a/fs/nfsd/nfs4idmap.c +++ b/fs/nfsd/nfs4idmap.c | |||
@@ -76,21 +76,18 @@ struct ent { | |||
76 | char authname[IDMAP_NAMESZ]; | 76 | char authname[IDMAP_NAMESZ]; |
77 | }; | 77 | }; |
78 | 78 | ||
79 | #define DefineSimpleCacheLookupMap(STRUCT, FUNC) \ | ||
80 | DefineCacheLookup(struct STRUCT, h, FUNC##_lookup, \ | ||
81 | (struct STRUCT *item, int set), /*no setup */, \ | ||
82 | & FUNC##_cache, FUNC##_hash(item), FUNC##_match(item, tmp), \ | ||
83 | STRUCT##_init(new, item), STRUCT##_update(tmp, item), 0) | ||
84 | |||
85 | /* Common entry handling */ | 79 | /* Common entry handling */ |
86 | 80 | ||
87 | #define ENT_HASHBITS 8 | 81 | #define ENT_HASHBITS 8 |
88 | #define ENT_HASHMAX (1 << ENT_HASHBITS) | 82 | #define ENT_HASHMAX (1 << ENT_HASHBITS) |
89 | #define ENT_HASHMASK (ENT_HASHMAX - 1) | 83 | #define ENT_HASHMASK (ENT_HASHMAX - 1) |
90 | 84 | ||
91 | static inline void | 85 | static void |
92 | ent_init(struct ent *new, struct ent *itm) | 86 | ent_init(struct cache_head *cnew, struct cache_head *citm) |
93 | { | 87 | { |
88 | struct ent *new = container_of(cnew, struct ent, h); | ||
89 | struct ent *itm = container_of(citm, struct ent, h); | ||
90 | |||
94 | new->id = itm->id; | 91 | new->id = itm->id; |
95 | new->type = itm->type; | 92 | new->type = itm->type; |
96 | 93 | ||
@@ -98,19 +95,21 @@ ent_init(struct ent *new, struct ent *itm) | |||
98 | strlcpy(new->authname, itm->authname, sizeof(new->name)); | 95 | strlcpy(new->authname, itm->authname, sizeof(new->name)); |
99 | } | 96 | } |
100 | 97 | ||
101 | static inline void | 98 | static void |
102 | ent_update(struct ent *new, struct ent *itm) | 99 | ent_put(struct kref *ref) |
103 | { | 100 | { |
104 | ent_init(new, itm); | 101 | struct ent *map = container_of(ref, struct ent, h.ref); |
102 | kfree(map); | ||
105 | } | 103 | } |
106 | 104 | ||
107 | static void | 105 | static struct cache_head * |
108 | ent_put(struct cache_head *ch, struct cache_detail *cd) | 106 | ent_alloc(void) |
109 | { | 107 | { |
110 | if (cache_put(ch, cd)) { | 108 | struct ent *e = kmalloc(sizeof(*e), GFP_KERNEL); |
111 | struct ent *map = container_of(ch, struct ent, h); | 109 | if (e) |
112 | kfree(map); | 110 | return &e->h; |
113 | } | 111 | else |
112 | return NULL; | ||
114 | } | 113 | } |
115 | 114 | ||
116 | /* | 115 | /* |
@@ -149,9 +148,12 @@ idtoname_request(struct cache_detail *cd, struct cache_head *ch, char **bpp, | |||
149 | (*bpp)[-1] = '\n'; | 148 | (*bpp)[-1] = '\n'; |
150 | } | 149 | } |
151 | 150 | ||
152 | static inline int | 151 | static int |
153 | idtoname_match(struct ent *a, struct ent *b) | 152 | idtoname_match(struct cache_head *ca, struct cache_head *cb) |
154 | { | 153 | { |
154 | struct ent *a = container_of(ca, struct ent, h); | ||
155 | struct ent *b = container_of(cb, struct ent, h); | ||
156 | |||
155 | return (a->id == b->id && a->type == b->type && | 157 | return (a->id == b->id && a->type == b->type && |
156 | strcmp(a->authname, b->authname) == 0); | 158 | strcmp(a->authname, b->authname) == 0); |
157 | } | 159 | } |
@@ -184,7 +186,8 @@ warn_no_idmapd(struct cache_detail *detail) | |||
184 | 186 | ||
185 | 187 | ||
186 | static int idtoname_parse(struct cache_detail *, char *, int); | 188 | static int idtoname_parse(struct cache_detail *, char *, int); |
187 | static struct ent *idtoname_lookup(struct ent *, int); | 189 | static struct ent *idtoname_lookup(struct ent *); |
190 | static struct ent *idtoname_update(struct ent *, struct ent *); | ||
188 | 191 | ||
189 | static struct cache_detail idtoname_cache = { | 192 | static struct cache_detail idtoname_cache = { |
190 | .owner = THIS_MODULE, | 193 | .owner = THIS_MODULE, |
@@ -196,6 +199,10 @@ static struct cache_detail idtoname_cache = { | |||
196 | .cache_parse = idtoname_parse, | 199 | .cache_parse = idtoname_parse, |
197 | .cache_show = idtoname_show, | 200 | .cache_show = idtoname_show, |
198 | .warn_no_listener = warn_no_idmapd, | 201 | .warn_no_listener = warn_no_idmapd, |
202 | .match = idtoname_match, | ||
203 | .init = ent_init, | ||
204 | .update = ent_init, | ||
205 | .alloc = ent_alloc, | ||
199 | }; | 206 | }; |
200 | 207 | ||
201 | int | 208 | int |
@@ -238,6 +245,11 @@ idtoname_parse(struct cache_detail *cd, char *buf, int buflen) | |||
238 | if (ent.h.expiry_time == 0) | 245 | if (ent.h.expiry_time == 0) |
239 | goto out; | 246 | goto out; |
240 | 247 | ||
248 | error = -ENOMEM; | ||
249 | res = idtoname_lookup(&ent); | ||
250 | if (!res) | ||
251 | goto out; | ||
252 | |||
241 | /* Name */ | 253 | /* Name */ |
242 | error = qword_get(&buf, buf1, PAGE_SIZE); | 254 | error = qword_get(&buf, buf1, PAGE_SIZE); |
243 | if (error == -EINVAL) | 255 | if (error == -EINVAL) |
@@ -252,10 +264,11 @@ idtoname_parse(struct cache_detail *cd, char *buf, int buflen) | |||
252 | memcpy(ent.name, buf1, sizeof(ent.name)); | 264 | memcpy(ent.name, buf1, sizeof(ent.name)); |
253 | } | 265 | } |
254 | error = -ENOMEM; | 266 | error = -ENOMEM; |
255 | if ((res = idtoname_lookup(&ent, 1)) == NULL) | 267 | res = idtoname_update(&ent, res); |
268 | if (res == NULL) | ||
256 | goto out; | 269 | goto out; |
257 | 270 | ||
258 | ent_put(&res->h, &idtoname_cache); | 271 | cache_put(&res->h, &idtoname_cache); |
259 | 272 | ||
260 | error = 0; | 273 | error = 0; |
261 | out: | 274 | out: |
@@ -264,7 +277,31 @@ out: | |||
264 | return error; | 277 | return error; |
265 | } | 278 | } |
266 | 279 | ||
267 | static DefineSimpleCacheLookupMap(ent, idtoname); | 280 | |
281 | static struct ent * | ||
282 | idtoname_lookup(struct ent *item) | ||
283 | { | ||
284 | struct cache_head *ch = sunrpc_cache_lookup(&idtoname_cache, | ||
285 | &item->h, | ||
286 | idtoname_hash(item)); | ||
287 | if (ch) | ||
288 | return container_of(ch, struct ent, h); | ||
289 | else | ||
290 | return NULL; | ||
291 | } | ||
292 | |||
293 | static struct ent * | ||
294 | idtoname_update(struct ent *new, struct ent *old) | ||
295 | { | ||
296 | struct cache_head *ch = sunrpc_cache_update(&idtoname_cache, | ||
297 | &new->h, &old->h, | ||
298 | idtoname_hash(new)); | ||
299 | if (ch) | ||
300 | return container_of(ch, struct ent, h); | ||
301 | else | ||
302 | return NULL; | ||
303 | } | ||
304 | |||
268 | 305 | ||
269 | /* | 306 | /* |
270 | * Name -> ID cache | 307 | * Name -> ID cache |
@@ -291,9 +328,12 @@ nametoid_request(struct cache_detail *cd, struct cache_head *ch, char **bpp, | |||
291 | (*bpp)[-1] = '\n'; | 328 | (*bpp)[-1] = '\n'; |
292 | } | 329 | } |
293 | 330 | ||
294 | static inline int | 331 | static int |
295 | nametoid_match(struct ent *a, struct ent *b) | 332 | nametoid_match(struct cache_head *ca, struct cache_head *cb) |
296 | { | 333 | { |
334 | struct ent *a = container_of(ca, struct ent, h); | ||
335 | struct ent *b = container_of(cb, struct ent, h); | ||
336 | |||
297 | return (a->type == b->type && strcmp(a->name, b->name) == 0 && | 337 | return (a->type == b->type && strcmp(a->name, b->name) == 0 && |
298 | strcmp(a->authname, b->authname) == 0); | 338 | strcmp(a->authname, b->authname) == 0); |
299 | } | 339 | } |
@@ -317,7 +357,8 @@ nametoid_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h) | |||
317 | return 0; | 357 | return 0; |
318 | } | 358 | } |
319 | 359 | ||
320 | static struct ent *nametoid_lookup(struct ent *, int); | 360 | static struct ent *nametoid_lookup(struct ent *); |
361 | static struct ent *nametoid_update(struct ent *, struct ent *); | ||
321 | static int nametoid_parse(struct cache_detail *, char *, int); | 362 | static int nametoid_parse(struct cache_detail *, char *, int); |
322 | 363 | ||
323 | static struct cache_detail nametoid_cache = { | 364 | static struct cache_detail nametoid_cache = { |
@@ -330,6 +371,10 @@ static struct cache_detail nametoid_cache = { | |||
330 | .cache_parse = nametoid_parse, | 371 | .cache_parse = nametoid_parse, |
331 | .cache_show = nametoid_show, | 372 | .cache_show = nametoid_show, |
332 | .warn_no_listener = warn_no_idmapd, | 373 | .warn_no_listener = warn_no_idmapd, |
374 | .match = nametoid_match, | ||
375 | .init = ent_init, | ||
376 | .update = ent_init, | ||
377 | .alloc = ent_alloc, | ||
333 | }; | 378 | }; |
334 | 379 | ||
335 | static int | 380 | static int |
@@ -379,10 +424,14 @@ nametoid_parse(struct cache_detail *cd, char *buf, int buflen) | |||
379 | set_bit(CACHE_NEGATIVE, &ent.h.flags); | 424 | set_bit(CACHE_NEGATIVE, &ent.h.flags); |
380 | 425 | ||
381 | error = -ENOMEM; | 426 | error = -ENOMEM; |
382 | if ((res = nametoid_lookup(&ent, 1)) == NULL) | 427 | res = nametoid_lookup(&ent); |
428 | if (res == NULL) | ||
429 | goto out; | ||
430 | res = nametoid_update(&ent, res); | ||
431 | if (res == NULL) | ||
383 | goto out; | 432 | goto out; |
384 | 433 | ||
385 | ent_put(&res->h, &nametoid_cache); | 434 | cache_put(&res->h, &nametoid_cache); |
386 | error = 0; | 435 | error = 0; |
387 | out: | 436 | out: |
388 | kfree(buf1); | 437 | kfree(buf1); |
@@ -390,7 +439,30 @@ out: | |||
390 | return (error); | 439 | return (error); |
391 | } | 440 | } |
392 | 441 | ||
393 | static DefineSimpleCacheLookupMap(ent, nametoid); | 442 | |
443 | static struct ent * | ||
444 | nametoid_lookup(struct ent *item) | ||
445 | { | ||
446 | struct cache_head *ch = sunrpc_cache_lookup(&nametoid_cache, | ||
447 | &item->h, | ||
448 | nametoid_hash(item)); | ||
449 | if (ch) | ||
450 | return container_of(ch, struct ent, h); | ||
451 | else | ||
452 | return NULL; | ||
453 | } | ||
454 | |||
455 | static struct ent * | ||
456 | nametoid_update(struct ent *new, struct ent *old) | ||
457 | { | ||
458 | struct cache_head *ch = sunrpc_cache_update(&nametoid_cache, | ||
459 | &new->h, &old->h, | ||
460 | nametoid_hash(new)); | ||
461 | if (ch) | ||
462 | return container_of(ch, struct ent, h); | ||
463 | else | ||
464 | return NULL; | ||
465 | } | ||
394 | 466 | ||
395 | /* | 467 | /* |
396 | * Exported API | 468 | * Exported API |
@@ -458,24 +530,24 @@ idmap_defer(struct cache_req *req) | |||
458 | } | 530 | } |
459 | 531 | ||
460 | static inline int | 532 | static inline int |
461 | do_idmap_lookup(struct ent *(*lookup_fn)(struct ent *, int), struct ent *key, | 533 | do_idmap_lookup(struct ent *(*lookup_fn)(struct ent *), struct ent *key, |
462 | struct cache_detail *detail, struct ent **item, | 534 | struct cache_detail *detail, struct ent **item, |
463 | struct idmap_defer_req *mdr) | 535 | struct idmap_defer_req *mdr) |
464 | { | 536 | { |
465 | *item = lookup_fn(key, 0); | 537 | *item = lookup_fn(key); |
466 | if (!*item) | 538 | if (!*item) |
467 | return -ENOMEM; | 539 | return -ENOMEM; |
468 | return cache_check(detail, &(*item)->h, &mdr->req); | 540 | return cache_check(detail, &(*item)->h, &mdr->req); |
469 | } | 541 | } |
470 | 542 | ||
471 | static inline int | 543 | static inline int |
472 | do_idmap_lookup_nowait(struct ent *(*lookup_fn)(struct ent *, int), | 544 | do_idmap_lookup_nowait(struct ent *(*lookup_fn)(struct ent *), |
473 | struct ent *key, struct cache_detail *detail, | 545 | struct ent *key, struct cache_detail *detail, |
474 | struct ent **item) | 546 | struct ent **item) |
475 | { | 547 | { |
476 | int ret = -ENOMEM; | 548 | int ret = -ENOMEM; |
477 | 549 | ||
478 | *item = lookup_fn(key, 0); | 550 | *item = lookup_fn(key); |
479 | if (!*item) | 551 | if (!*item) |
480 | goto out_err; | 552 | goto out_err; |
481 | ret = -ETIMEDOUT; | 553 | ret = -ETIMEDOUT; |
@@ -488,7 +560,7 @@ do_idmap_lookup_nowait(struct ent *(*lookup_fn)(struct ent *, int), | |||
488 | goto out_put; | 560 | goto out_put; |
489 | return 0; | 561 | return 0; |
490 | out_put: | 562 | out_put: |
491 | ent_put(&(*item)->h, detail); | 563 | cache_put(&(*item)->h, detail); |
492 | out_err: | 564 | out_err: |
493 | *item = NULL; | 565 | *item = NULL; |
494 | return ret; | 566 | return ret; |
@@ -496,7 +568,7 @@ out_err: | |||
496 | 568 | ||
497 | static int | 569 | static int |
498 | idmap_lookup(struct svc_rqst *rqstp, | 570 | idmap_lookup(struct svc_rqst *rqstp, |
499 | struct ent *(*lookup_fn)(struct ent *, int), struct ent *key, | 571 | struct ent *(*lookup_fn)(struct ent *), struct ent *key, |
500 | struct cache_detail *detail, struct ent **item) | 572 | struct cache_detail *detail, struct ent **item) |
501 | { | 573 | { |
502 | struct idmap_defer_req *mdr; | 574 | struct idmap_defer_req *mdr; |
@@ -539,7 +611,7 @@ idmap_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namelen | |||
539 | if (ret) | 611 | if (ret) |
540 | return ret; | 612 | return ret; |
541 | *id = item->id; | 613 | *id = item->id; |
542 | ent_put(&item->h, &nametoid_cache); | 614 | cache_put(&item->h, &nametoid_cache); |
543 | return 0; | 615 | return 0; |
544 | } | 616 | } |
545 | 617 | ||
@@ -561,7 +633,7 @@ idmap_id_to_name(struct svc_rqst *rqstp, int type, uid_t id, char *name) | |||
561 | ret = strlen(item->name); | 633 | ret = strlen(item->name); |
562 | BUG_ON(ret > IDMAP_NAMESZ); | 634 | BUG_ON(ret > IDMAP_NAMESZ); |
563 | memcpy(name, item->name, ret); | 635 | memcpy(name, item->name, ret); |
564 | ent_put(&item->h, &idtoname_cache); | 636 | cache_put(&item->h, &idtoname_cache); |
565 | return ret; | 637 | return ret; |
566 | } | 638 | } |
567 | 639 | ||
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index f6ab762bea99..47ec112b266c 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -49,6 +49,7 @@ | |||
49 | #include <linux/nfsd/state.h> | 49 | #include <linux/nfsd/state.h> |
50 | #include <linux/nfsd/xdr4.h> | 50 | #include <linux/nfsd/xdr4.h> |
51 | #include <linux/namei.h> | 51 | #include <linux/namei.h> |
52 | #include <linux/mutex.h> | ||
52 | 53 | ||
53 | #define NFSDDBG_FACILITY NFSDDBG_PROC | 54 | #define NFSDDBG_FACILITY NFSDDBG_PROC |
54 | 55 | ||
@@ -77,11 +78,11 @@ static void nfs4_set_recdir(char *recdir); | |||
77 | 78 | ||
78 | /* Locking: | 79 | /* Locking: |
79 | * | 80 | * |
80 | * client_sema: | 81 | * client_mutex: |
81 | * protects clientid_hashtbl[], clientstr_hashtbl[], | 82 | * protects clientid_hashtbl[], clientstr_hashtbl[], |
82 | * unconfstr_hashtbl[], uncofid_hashtbl[]. | 83 | * unconfstr_hashtbl[], uncofid_hashtbl[]. |
83 | */ | 84 | */ |
84 | static DECLARE_MUTEX(client_sema); | 85 | static DEFINE_MUTEX(client_mutex); |
85 | 86 | ||
86 | static kmem_cache_t *stateowner_slab = NULL; | 87 | static kmem_cache_t *stateowner_slab = NULL; |
87 | static kmem_cache_t *file_slab = NULL; | 88 | static kmem_cache_t *file_slab = NULL; |
@@ -91,13 +92,13 @@ static kmem_cache_t *deleg_slab = NULL; | |||
91 | void | 92 | void |
92 | nfs4_lock_state(void) | 93 | nfs4_lock_state(void) |
93 | { | 94 | { |
94 | down(&client_sema); | 95 | mutex_lock(&client_mutex); |
95 | } | 96 | } |
96 | 97 | ||
97 | void | 98 | void |
98 | nfs4_unlock_state(void) | 99 | nfs4_unlock_state(void) |
99 | { | 100 | { |
100 | up(&client_sema); | 101 | mutex_unlock(&client_mutex); |
101 | } | 102 | } |
102 | 103 | ||
103 | static inline u32 | 104 | static inline u32 |
@@ -2749,37 +2750,31 @@ nfsd4_lock(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_lock | |||
2749 | * Note: locks.c uses the BKL to protect the inode's lock list. | 2750 | * Note: locks.c uses the BKL to protect the inode's lock list. |
2750 | */ | 2751 | */ |
2751 | 2752 | ||
2752 | status = posix_lock_file(filp, &file_lock); | 2753 | /* XXX?: Just to divert the locks_release_private at the start of |
2753 | dprintk("NFSD: nfsd4_lock: posix_lock_file status %d\n",status); | 2754 | * locks_copy_lock: */ |
2755 | conflock.fl_ops = NULL; | ||
2756 | conflock.fl_lmops = NULL; | ||
2757 | status = posix_lock_file_conf(filp, &file_lock, &conflock); | ||
2758 | dprintk("NFSD: nfsd4_lock: posix_lock_file_conf status %d\n",status); | ||
2754 | switch (-status) { | 2759 | switch (-status) { |
2755 | case 0: /* success! */ | 2760 | case 0: /* success! */ |
2756 | update_stateid(&lock_stp->st_stateid); | 2761 | update_stateid(&lock_stp->st_stateid); |
2757 | memcpy(&lock->lk_resp_stateid, &lock_stp->st_stateid, | 2762 | memcpy(&lock->lk_resp_stateid, &lock_stp->st_stateid, |
2758 | sizeof(stateid_t)); | 2763 | sizeof(stateid_t)); |
2759 | goto out; | 2764 | break; |
2760 | case (EAGAIN): | 2765 | case (EAGAIN): /* conflock holds conflicting lock */ |
2761 | goto conflicting_lock; | 2766 | status = nfserr_denied; |
2767 | dprintk("NFSD: nfsd4_lock: conflicting lock found!\n"); | ||
2768 | nfs4_set_lock_denied(&conflock, &lock->lk_denied); | ||
2769 | break; | ||
2762 | case (EDEADLK): | 2770 | case (EDEADLK): |
2763 | status = nfserr_deadlock; | 2771 | status = nfserr_deadlock; |
2764 | dprintk("NFSD: nfsd4_lock: posix_lock_file() failed! status %d\n",status); | 2772 | break; |
2765 | goto out; | ||
2766 | default: | 2773 | default: |
2767 | status = nfserrno(status); | 2774 | dprintk("NFSD: nfsd4_lock: posix_lock_file_conf() failed! status %d\n",status); |
2768 | dprintk("NFSD: nfsd4_lock: posix_lock_file() failed! status %d\n",status); | 2775 | status = nfserr_resource; |
2769 | goto out; | 2776 | break; |
2770 | } | ||
2771 | |||
2772 | conflicting_lock: | ||
2773 | dprintk("NFSD: nfsd4_lock: conflicting lock found!\n"); | ||
2774 | status = nfserr_denied; | ||
2775 | /* XXX There is a race here. Future patch needed to provide | ||
2776 | * an atomic posix_lock_and_test_file | ||
2777 | */ | ||
2778 | if (!posix_test_lock(filp, &file_lock, &conflock)) { | ||
2779 | status = nfserr_serverfault; | ||
2780 | goto out; | ||
2781 | } | 2777 | } |
2782 | nfs4_set_lock_denied(&conflock, &lock->lk_denied); | ||
2783 | out: | 2778 | out: |
2784 | if (status && lock->lk_is_new && lock_sop) | 2779 | if (status && lock->lk_is_new && lock_sop) |
2785 | release_stateowner(lock_sop); | 2780 | release_stateowner(lock_sop); |
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index c8960aff0968..3ef017b3b5bd 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c | |||
@@ -134,7 +134,7 @@ static ssize_t nfsctl_transaction_read(struct file *file, char __user *buf, size | |||
134 | return simple_transaction_read(file, buf, size, pos); | 134 | return simple_transaction_read(file, buf, size, pos); |
135 | } | 135 | } |
136 | 136 | ||
137 | static struct file_operations transaction_ops = { | 137 | static const struct file_operations transaction_ops = { |
138 | .write = nfsctl_transaction_write, | 138 | .write = nfsctl_transaction_write, |
139 | .read = nfsctl_transaction_read, | 139 | .read = nfsctl_transaction_read, |
140 | .release = simple_transaction_release, | 140 | .release = simple_transaction_release, |
@@ -146,7 +146,7 @@ static int exports_open(struct inode *inode, struct file *file) | |||
146 | return seq_open(file, &nfs_exports_op); | 146 | return seq_open(file, &nfs_exports_op); |
147 | } | 147 | } |
148 | 148 | ||
149 | static struct file_operations exports_operations = { | 149 | static const struct file_operations exports_operations = { |
150 | .open = exports_open, | 150 | .open = exports_open, |
151 | .read = seq_read, | 151 | .read = seq_read, |
152 | .llseek = seq_lseek, | 152 | .llseek = seq_lseek, |
diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 7a3e397b4ed3..3f2ec2e6d06c 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c | |||
@@ -506,7 +506,7 @@ fh_put(struct svc_fh *fhp) | |||
506 | nfsd_nr_put++; | 506 | nfsd_nr_put++; |
507 | } | 507 | } |
508 | if (exp) { | 508 | if (exp) { |
509 | svc_export_put(&exp->h, &svc_export_cache); | 509 | cache_put(&exp->h, &svc_export_cache); |
510 | fhp->fh_export = NULL; | 510 | fhp->fh_export = NULL; |
511 | } | 511 | } |
512 | return; | 512 | return; |
diff --git a/fs/nfsd/stats.c b/fs/nfsd/stats.c index 1cf955bcc526..57265d563804 100644 --- a/fs/nfsd/stats.c +++ b/fs/nfsd/stats.c | |||
@@ -80,7 +80,7 @@ static int nfsd_proc_open(struct inode *inode, struct file *file) | |||
80 | return single_open(file, nfsd_proc_show, NULL); | 80 | return single_open(file, nfsd_proc_show, NULL); |
81 | } | 81 | } |
82 | 82 | ||
83 | static struct file_operations nfsd_proc_fops = { | 83 | static const struct file_operations nfsd_proc_fops = { |
84 | .owner = THIS_MODULE, | 84 | .owner = THIS_MODULE, |
85 | .open = nfsd_proc_open, | 85 | .open = nfsd_proc_open, |
86 | .read = seq_read, | 86 | .read = seq_read, |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 5320e5afaddb..31018333dc38 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -706,7 +706,7 @@ nfsd_close(struct file *filp) | |||
706 | * after it. | 706 | * after it. |
707 | */ | 707 | */ |
708 | static inline int nfsd_dosync(struct file *filp, struct dentry *dp, | 708 | static inline int nfsd_dosync(struct file *filp, struct dentry *dp, |
709 | struct file_operations *fop) | 709 | const struct file_operations *fop) |
710 | { | 710 | { |
711 | struct inode *inode = dp->d_inode; | 711 | struct inode *inode = dp->d_inode; |
712 | int (*fsync) (struct file *, struct dentry *, int); | 712 | int (*fsync) (struct file *, struct dentry *, int); |
diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 9d9ed3fe371d..d1e2c6f9f05e 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c | |||
@@ -1553,7 +1553,7 @@ static int ntfs_dir_fsync(struct file *filp, struct dentry *dentry, | |||
1553 | 1553 | ||
1554 | #endif /* NTFS_RW */ | 1554 | #endif /* NTFS_RW */ |
1555 | 1555 | ||
1556 | struct file_operations ntfs_dir_ops = { | 1556 | const struct file_operations ntfs_dir_ops = { |
1557 | .llseek = generic_file_llseek, /* Seek inside directory. */ | 1557 | .llseek = generic_file_llseek, /* Seek inside directory. */ |
1558 | .read = generic_read_dir, /* Return -EISDIR. */ | 1558 | .read = generic_read_dir, /* Return -EISDIR. */ |
1559 | .readdir = ntfs_readdir, /* Read directory contents. */ | 1559 | .readdir = ntfs_readdir, /* Read directory contents. */ |
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index f5d057e4acc2..c63a83e8da98 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c | |||
@@ -2294,7 +2294,7 @@ static int ntfs_file_fsync(struct file *filp, struct dentry *dentry, | |||
2294 | 2294 | ||
2295 | #endif /* NTFS_RW */ | 2295 | #endif /* NTFS_RW */ |
2296 | 2296 | ||
2297 | struct file_operations ntfs_file_ops = { | 2297 | const struct file_operations ntfs_file_ops = { |
2298 | .llseek = generic_file_llseek, /* Seek inside file. */ | 2298 | .llseek = generic_file_llseek, /* Seek inside file. */ |
2299 | .read = generic_file_read, /* Read from file. */ | 2299 | .read = generic_file_read, /* Read from file. */ |
2300 | .aio_read = generic_file_aio_read, /* Async read from file. */ | 2300 | .aio_read = generic_file_aio_read, /* Async read from file. */ |
@@ -2337,6 +2337,6 @@ struct inode_operations ntfs_file_inode_ops = { | |||
2337 | #endif /* NTFS_RW */ | 2337 | #endif /* NTFS_RW */ |
2338 | }; | 2338 | }; |
2339 | 2339 | ||
2340 | struct file_operations ntfs_empty_file_ops = {}; | 2340 | const struct file_operations ntfs_empty_file_ops = {}; |
2341 | 2341 | ||
2342 | struct inode_operations ntfs_empty_inode_ops = {}; | 2342 | struct inode_operations ntfs_empty_inode_ops = {}; |
diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c index 0fd70295cca6..4af2ad1193ec 100644 --- a/fs/ntfs/logfile.c +++ b/fs/ntfs/logfile.c | |||
@@ -515,10 +515,10 @@ BOOL ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) | |||
515 | log_page_size = PAGE_CACHE_SIZE; | 515 | log_page_size = PAGE_CACHE_SIZE; |
516 | log_page_mask = log_page_size - 1; | 516 | log_page_mask = log_page_size - 1; |
517 | /* | 517 | /* |
518 | * Use generic_ffs() instead of ffs() to enable the compiler to | 518 | * Use ntfs_ffs() instead of ffs() to enable the compiler to |
519 | * optimize log_page_size and log_page_bits into constants. | 519 | * optimize log_page_size and log_page_bits into constants. |
520 | */ | 520 | */ |
521 | log_page_bits = generic_ffs(log_page_size) - 1; | 521 | log_page_bits = ntfs_ffs(log_page_size) - 1; |
522 | size &= ~(s64)(log_page_size - 1); | 522 | size &= ~(s64)(log_page_size - 1); |
523 | /* | 523 | /* |
524 | * Ensure the log file is big enough to store at least the two restart | 524 | * Ensure the log file is big enough to store at least the two restart |
diff --git a/fs/ntfs/mft.c b/fs/ntfs/mft.c index 4e72bc7afdf9..2438c00ec0ce 100644 --- a/fs/ntfs/mft.c +++ b/fs/ntfs/mft.c | |||
@@ -2670,7 +2670,7 @@ mft_rec_already_initialized: | |||
2670 | ni->name_len = 4; | 2670 | ni->name_len = 4; |
2671 | 2671 | ||
2672 | ni->itype.index.block_size = 4096; | 2672 | ni->itype.index.block_size = 4096; |
2673 | ni->itype.index.block_size_bits = generic_ffs(4096) - 1; | 2673 | ni->itype.index.block_size_bits = ntfs_ffs(4096) - 1; |
2674 | ni->itype.index.collation_rule = COLLATION_FILE_NAME; | 2674 | ni->itype.index.collation_rule = COLLATION_FILE_NAME; |
2675 | if (vol->cluster_size <= ni->itype.index.block_size) { | 2675 | if (vol->cluster_size <= ni->itype.index.block_size) { |
2676 | ni->itype.index.vcn_size = vol->cluster_size; | 2676 | ni->itype.index.vcn_size = vol->cluster_size; |
diff --git a/fs/ntfs/ntfs.h b/fs/ntfs/ntfs.h index 0624c8ef4d9c..bf7b3d7c0930 100644 --- a/fs/ntfs/ntfs.h +++ b/fs/ntfs/ntfs.h | |||
@@ -60,13 +60,13 @@ extern struct kmem_cache *ntfs_index_ctx_cache; | |||
60 | extern struct address_space_operations ntfs_aops; | 60 | extern struct address_space_operations ntfs_aops; |
61 | extern struct address_space_operations ntfs_mst_aops; | 61 | extern struct address_space_operations ntfs_mst_aops; |
62 | 62 | ||
63 | extern struct file_operations ntfs_file_ops; | 63 | extern const struct file_operations ntfs_file_ops; |
64 | extern struct inode_operations ntfs_file_inode_ops; | 64 | extern struct inode_operations ntfs_file_inode_ops; |
65 | 65 | ||
66 | extern struct file_operations ntfs_dir_ops; | 66 | extern const struct file_operations ntfs_dir_ops; |
67 | extern struct inode_operations ntfs_dir_inode_ops; | 67 | extern struct inode_operations ntfs_dir_inode_ops; |
68 | 68 | ||
69 | extern struct file_operations ntfs_empty_file_ops; | 69 | extern const struct file_operations ntfs_empty_file_ops; |
70 | extern struct inode_operations ntfs_empty_inode_ops; | 70 | extern struct inode_operations ntfs_empty_inode_ops; |
71 | 71 | ||
72 | extern struct export_operations ntfs_export_ops; | 72 | extern struct export_operations ntfs_export_ops; |
@@ -132,4 +132,33 @@ extern int ntfs_ucstonls(const ntfs_volume *vol, const ntfschar *ins, | |||
132 | /* From fs/ntfs/upcase.c */ | 132 | /* From fs/ntfs/upcase.c */ |
133 | extern ntfschar *generate_default_upcase(void); | 133 | extern ntfschar *generate_default_upcase(void); |
134 | 134 | ||
135 | static inline int ntfs_ffs(int x) | ||
136 | { | ||
137 | int r = 1; | ||
138 | |||
139 | if (!x) | ||
140 | return 0; | ||
141 | if (!(x & 0xffff)) { | ||
142 | x >>= 16; | ||
143 | r += 16; | ||
144 | } | ||
145 | if (!(x & 0xff)) { | ||
146 | x >>= 8; | ||
147 | r += 8; | ||
148 | } | ||
149 | if (!(x & 0xf)) { | ||
150 | x >>= 4; | ||
151 | r += 4; | ||
152 | } | ||
153 | if (!(x & 3)) { | ||
154 | x >>= 2; | ||
155 | r += 2; | ||
156 | } | ||
157 | if (!(x & 1)) { | ||
158 | x >>= 1; | ||
159 | r += 1; | ||
160 | } | ||
161 | return r; | ||
162 | } | ||
163 | |||
135 | #endif /* _LINUX_NTFS_H */ | 164 | #endif /* _LINUX_NTFS_H */ |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index bf931ba1d364..0d858d0b25be 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -540,7 +540,6 @@ bail: | |||
540 | * fs_count, map_bh, dio->rw == WRITE); | 540 | * fs_count, map_bh, dio->rw == WRITE); |
541 | */ | 541 | */ |
542 | static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, | 542 | static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, |
543 | unsigned long max_blocks, | ||
544 | struct buffer_head *bh_result, int create) | 543 | struct buffer_head *bh_result, int create) |
545 | { | 544 | { |
546 | int ret; | 545 | int ret; |
@@ -548,6 +547,7 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, | |||
548 | u64 p_blkno; | 547 | u64 p_blkno; |
549 | int contig_blocks; | 548 | int contig_blocks; |
550 | unsigned char blocksize_bits; | 549 | unsigned char blocksize_bits; |
550 | unsigned long max_blocks = bh_result->b_size >> inode->i_blkbits; | ||
551 | 551 | ||
552 | if (!inode || !bh_result) { | 552 | if (!inode || !bh_result) { |
553 | mlog(ML_ERROR, "inode or bh_result is null\n"); | 553 | mlog(ML_ERROR, "inode or bh_result is null\n"); |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 84f153aca692..64cd52860c87 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -2017,7 +2017,7 @@ out: | |||
2017 | return ret; | 2017 | return ret; |
2018 | } | 2018 | } |
2019 | 2019 | ||
2020 | static struct file_operations ocfs2_dlm_debug_fops = { | 2020 | static const struct file_operations ocfs2_dlm_debug_fops = { |
2021 | .open = ocfs2_dlm_debug_open, | 2021 | .open = ocfs2_dlm_debug_open, |
2022 | .release = ocfs2_dlm_debug_release, | 2022 | .release = ocfs2_dlm_debug_release, |
2023 | .read = seq_read, | 2023 | .read = seq_read, |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 4b4cbadd5838..34e903a6a46b 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
@@ -1176,7 +1176,7 @@ struct inode_operations ocfs2_special_file_iops = { | |||
1176 | .getattr = ocfs2_getattr, | 1176 | .getattr = ocfs2_getattr, |
1177 | }; | 1177 | }; |
1178 | 1178 | ||
1179 | struct file_operations ocfs2_fops = { | 1179 | const struct file_operations ocfs2_fops = { |
1180 | .read = do_sync_read, | 1180 | .read = do_sync_read, |
1181 | .write = do_sync_write, | 1181 | .write = do_sync_write, |
1182 | .sendfile = generic_file_sendfile, | 1182 | .sendfile = generic_file_sendfile, |
@@ -1188,7 +1188,7 @@ struct file_operations ocfs2_fops = { | |||
1188 | .aio_write = ocfs2_file_aio_write, | 1188 | .aio_write = ocfs2_file_aio_write, |
1189 | }; | 1189 | }; |
1190 | 1190 | ||
1191 | struct file_operations ocfs2_dops = { | 1191 | const struct file_operations ocfs2_dops = { |
1192 | .read = generic_read_dir, | 1192 | .read = generic_read_dir, |
1193 | .readdir = ocfs2_readdir, | 1193 | .readdir = ocfs2_readdir, |
1194 | .fsync = ocfs2_sync_file, | 1194 | .fsync = ocfs2_sync_file, |
diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h index a5ea33b24060..740c9e7ca599 100644 --- a/fs/ocfs2/file.h +++ b/fs/ocfs2/file.h | |||
@@ -26,8 +26,8 @@ | |||
26 | #ifndef OCFS2_FILE_H | 26 | #ifndef OCFS2_FILE_H |
27 | #define OCFS2_FILE_H | 27 | #define OCFS2_FILE_H |
28 | 28 | ||
29 | extern struct file_operations ocfs2_fops; | 29 | extern const struct file_operations ocfs2_fops; |
30 | extern struct file_operations ocfs2_dops; | 30 | extern const struct file_operations ocfs2_dops; |
31 | extern struct inode_operations ocfs2_file_iops; | 31 | extern struct inode_operations ocfs2_file_iops; |
32 | extern struct inode_operations ocfs2_special_file_iops; | 32 | extern struct inode_operations ocfs2_special_file_iops; |
33 | struct ocfs2_alloc_context; | 33 | struct ocfs2_alloc_context; |
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index ae3440ca083c..6a610ae53583 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c | |||
@@ -377,7 +377,7 @@ int ocfs2_journal_access(struct ocfs2_journal_handle *handle, | |||
377 | BUG_ON(!bh); | 377 | BUG_ON(!bh); |
378 | BUG_ON(!(handle->flags & OCFS2_HANDLE_STARTED)); | 378 | BUG_ON(!(handle->flags & OCFS2_HANDLE_STARTED)); |
379 | 379 | ||
380 | mlog_entry("bh->b_blocknr=%llu, type=%d (\"%s\"), bh->b_size = %hu\n", | 380 | mlog_entry("bh->b_blocknr=%llu, type=%d (\"%s\"), bh->b_size = %zu\n", |
381 | (unsigned long long)bh->b_blocknr, type, | 381 | (unsigned long long)bh->b_blocknr, type, |
382 | (type == OCFS2_JOURNAL_ACCESS_CREATE) ? | 382 | (type == OCFS2_JOURNAL_ACCESS_CREATE) ? |
383 | "OCFS2_JOURNAL_ACCESS_CREATE" : | 383 | "OCFS2_JOURNAL_ACCESS_CREATE" : |
@@ -582,7 +582,8 @@ int ocfs2_journal_init(struct ocfs2_journal *journal, int *dirty) | |||
582 | } | 582 | } |
583 | 583 | ||
584 | mlog(0, "inode->i_size = %lld\n", inode->i_size); | 584 | mlog(0, "inode->i_size = %lld\n", inode->i_size); |
585 | mlog(0, "inode->i_blocks = %lu\n", inode->i_blocks); | 585 | mlog(0, "inode->i_blocks = %llu\n", |
586 | (unsigned long long)inode->i_blocks); | ||
586 | mlog(0, "inode->ip_clusters = %u\n", OCFS2_I(inode)->ip_clusters); | 587 | mlog(0, "inode->ip_clusters = %u\n", OCFS2_I(inode)->ip_clusters); |
587 | 588 | ||
588 | /* call the kernels journal init function now */ | 589 | /* call the kernels journal init function now */ |
@@ -850,8 +851,9 @@ static int ocfs2_force_read_journal(struct inode *inode) | |||
850 | 851 | ||
851 | memset(bhs, 0, sizeof(struct buffer_head *) * CONCURRENT_JOURNAL_FILL); | 852 | memset(bhs, 0, sizeof(struct buffer_head *) * CONCURRENT_JOURNAL_FILL); |
852 | 853 | ||
853 | mlog(0, "Force reading %lu blocks\n", | 854 | mlog(0, "Force reading %llu blocks\n", |
854 | (inode->i_blocks >> (inode->i_sb->s_blocksize_bits - 9))); | 855 | (unsigned long long)(inode->i_blocks >> |
856 | (inode->i_sb->s_blocksize_bits - 9))); | ||
855 | 857 | ||
856 | v_blkno = 0; | 858 | v_blkno = 0; |
857 | while (v_blkno < | 859 | while (v_blkno < |
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 274f61d0cda9..0673862c8bdd 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c | |||
@@ -1444,8 +1444,9 @@ static int ocfs2_create_symlink_data(struct ocfs2_super *osb, | |||
1444 | * write i_size + 1 bytes. */ | 1444 | * write i_size + 1 bytes. */ |
1445 | blocks = (bytes_left + sb->s_blocksize - 1) >> sb->s_blocksize_bits; | 1445 | blocks = (bytes_left + sb->s_blocksize - 1) >> sb->s_blocksize_bits; |
1446 | 1446 | ||
1447 | mlog_entry("i_blocks = %lu, i_size = %llu, blocks = %d\n", | 1447 | mlog_entry("i_blocks = %llu, i_size = %llu, blocks = %d\n", |
1448 | inode->i_blocks, i_size_read(inode), blocks); | 1448 | (unsigned long long)inode->i_blocks, |
1449 | i_size_read(inode), blocks); | ||
1449 | 1450 | ||
1450 | /* Sanity check -- make sure we're going to fit. */ | 1451 | /* Sanity check -- make sure we're going to fit. */ |
1451 | if (bytes_left > | 1452 | if (bytes_left > |
diff --git a/fs/openpromfs/inode.c b/fs/openpromfs/inode.c index aeb0106890e4..0f14276a2e51 100644 --- a/fs/openpromfs/inode.c +++ b/fs/openpromfs/inode.c | |||
@@ -581,17 +581,17 @@ int property_release (struct inode *inode, struct file *filp) | |||
581 | return 0; | 581 | return 0; |
582 | } | 582 | } |
583 | 583 | ||
584 | static struct file_operations openpromfs_prop_ops = { | 584 | static const struct file_operations openpromfs_prop_ops = { |
585 | .read = property_read, | 585 | .read = property_read, |
586 | .write = property_write, | 586 | .write = property_write, |
587 | .release = property_release, | 587 | .release = property_release, |
588 | }; | 588 | }; |
589 | 589 | ||
590 | static struct file_operations openpromfs_nodenum_ops = { | 590 | static const struct file_operations openpromfs_nodenum_ops = { |
591 | .read = nodenum_read, | 591 | .read = nodenum_read, |
592 | }; | 592 | }; |
593 | 593 | ||
594 | static struct file_operations openprom_operations = { | 594 | static const struct file_operations openprom_operations = { |
595 | .read = generic_read_dir, | 595 | .read = generic_read_dir, |
596 | .readdir = openpromfs_readdir, | 596 | .readdir = openpromfs_readdir, |
597 | }; | 597 | }; |
diff --git a/fs/partitions/check.c b/fs/partitions/check.c index f924f459bdb8..af0cb4b9e784 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c | |||
@@ -297,6 +297,25 @@ struct kobj_type ktype_part = { | |||
297 | .sysfs_ops = &part_sysfs_ops, | 297 | .sysfs_ops = &part_sysfs_ops, |
298 | }; | 298 | }; |
299 | 299 | ||
300 | static inline void partition_sysfs_add_subdir(struct hd_struct *p) | ||
301 | { | ||
302 | struct kobject *k; | ||
303 | |||
304 | k = kobject_get(&p->kobj); | ||
305 | p->holder_dir = kobject_add_dir(k, "holders"); | ||
306 | kobject_put(k); | ||
307 | } | ||
308 | |||
309 | static inline void disk_sysfs_add_subdirs(struct gendisk *disk) | ||
310 | { | ||
311 | struct kobject *k; | ||
312 | |||
313 | k = kobject_get(&disk->kobj); | ||
314 | disk->holder_dir = kobject_add_dir(k, "holders"); | ||
315 | disk->slave_dir = kobject_add_dir(k, "slaves"); | ||
316 | kobject_put(k); | ||
317 | } | ||
318 | |||
300 | void delete_partition(struct gendisk *disk, int part) | 319 | void delete_partition(struct gendisk *disk, int part) |
301 | { | 320 | { |
302 | struct hd_struct *p = disk->part[part-1]; | 321 | struct hd_struct *p = disk->part[part-1]; |
@@ -310,6 +329,8 @@ void delete_partition(struct gendisk *disk, int part) | |||
310 | p->ios[0] = p->ios[1] = 0; | 329 | p->ios[0] = p->ios[1] = 0; |
311 | p->sectors[0] = p->sectors[1] = 0; | 330 | p->sectors[0] = p->sectors[1] = 0; |
312 | devfs_remove("%s/part%d", disk->devfs_name, part); | 331 | devfs_remove("%s/part%d", disk->devfs_name, part); |
332 | if (p->holder_dir) | ||
333 | kobject_unregister(p->holder_dir); | ||
313 | kobject_unregister(&p->kobj); | 334 | kobject_unregister(&p->kobj); |
314 | } | 335 | } |
315 | 336 | ||
@@ -337,6 +358,7 @@ void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len) | |||
337 | p->kobj.parent = &disk->kobj; | 358 | p->kobj.parent = &disk->kobj; |
338 | p->kobj.ktype = &ktype_part; | 359 | p->kobj.ktype = &ktype_part; |
339 | kobject_register(&p->kobj); | 360 | kobject_register(&p->kobj); |
361 | partition_sysfs_add_subdir(p); | ||
340 | disk->part[part-1] = p; | 362 | disk->part[part-1] = p; |
341 | } | 363 | } |
342 | 364 | ||
@@ -383,6 +405,7 @@ void register_disk(struct gendisk *disk) | |||
383 | if ((err = kobject_add(&disk->kobj))) | 405 | if ((err = kobject_add(&disk->kobj))) |
384 | return; | 406 | return; |
385 | disk_sysfs_symlinks(disk); | 407 | disk_sysfs_symlinks(disk); |
408 | disk_sysfs_add_subdirs(disk); | ||
386 | kobject_uevent(&disk->kobj, KOBJ_ADD); | 409 | kobject_uevent(&disk->kobj, KOBJ_ADD); |
387 | 410 | ||
388 | /* No minors to use for partitions */ | 411 | /* No minors to use for partitions */ |
@@ -483,6 +506,10 @@ void del_gendisk(struct gendisk *disk) | |||
483 | 506 | ||
484 | devfs_remove_disk(disk); | 507 | devfs_remove_disk(disk); |
485 | 508 | ||
509 | if (disk->holder_dir) | ||
510 | kobject_unregister(disk->holder_dir); | ||
511 | if (disk->slave_dir) | ||
512 | kobject_unregister(disk->slave_dir); | ||
486 | if (disk->driverfs_dev) { | 513 | if (disk->driverfs_dev) { |
487 | char *disk_name = make_block_name(disk); | 514 | char *disk_name = make_block_name(disk); |
488 | sysfs_remove_link(&disk->kobj, "device"); | 515 | sysfs_remove_link(&disk->kobj, "device"); |
diff --git a/fs/partitions/devfs.c b/fs/partitions/devfs.c index 87f50444fd39..3f0a780c9cec 100644 --- a/fs/partitions/devfs.c +++ b/fs/partitions/devfs.c | |||
@@ -6,7 +6,7 @@ | |||
6 | #include <linux/vmalloc.h> | 6 | #include <linux/vmalloc.h> |
7 | #include <linux/genhd.h> | 7 | #include <linux/genhd.h> |
8 | #include <linux/bitops.h> | 8 | #include <linux/bitops.h> |
9 | #include <asm/semaphore.h> | 9 | #include <linux/mutex.h> |
10 | 10 | ||
11 | 11 | ||
12 | struct unique_numspace { | 12 | struct unique_numspace { |
@@ -16,7 +16,7 @@ struct unique_numspace { | |||
16 | struct semaphore mutex; | 16 | struct semaphore mutex; |
17 | }; | 17 | }; |
18 | 18 | ||
19 | static DECLARE_MUTEX(numspace_mutex); | 19 | static DEFINE_MUTEX(numspace_mutex); |
20 | 20 | ||
21 | static int expand_numspace(struct unique_numspace *s) | 21 | static int expand_numspace(struct unique_numspace *s) |
22 | { | 22 | { |
@@ -48,7 +48,7 @@ static int alloc_unique_number(struct unique_numspace *s) | |||
48 | { | 48 | { |
49 | int rval = 0; | 49 | int rval = 0; |
50 | 50 | ||
51 | down(&numspace_mutex); | 51 | mutex_lock(&numspace_mutex); |
52 | if (s->num_free < 1) | 52 | if (s->num_free < 1) |
53 | rval = expand_numspace(s); | 53 | rval = expand_numspace(s); |
54 | if (!rval) { | 54 | if (!rval) { |
@@ -56,7 +56,7 @@ static int alloc_unique_number(struct unique_numspace *s) | |||
56 | --s->num_free; | 56 | --s->num_free; |
57 | __set_bit(rval, s->bits); | 57 | __set_bit(rval, s->bits); |
58 | } | 58 | } |
59 | up(&numspace_mutex); | 59 | mutex_unlock(&numspace_mutex); |
60 | 60 | ||
61 | return rval; | 61 | return rval; |
62 | } | 62 | } |
@@ -66,11 +66,11 @@ static void dealloc_unique_number(struct unique_numspace *s, int number) | |||
66 | int old_val; | 66 | int old_val; |
67 | 67 | ||
68 | if (number >= 0) { | 68 | if (number >= 0) { |
69 | down(&numspace_mutex); | 69 | mutex_lock(&numspace_mutex); |
70 | old_val = __test_and_clear_bit(number, s->bits); | 70 | old_val = __test_and_clear_bit(number, s->bits); |
71 | if (old_val) | 71 | if (old_val) |
72 | ++s->num_free; | 72 | ++s->num_free; |
73 | up(&numspace_mutex); | 73 | mutex_unlock(&numspace_mutex); |
74 | } | 74 | } |
75 | } | 75 | } |
76 | 76 | ||
@@ -568,7 +568,7 @@ pipe_rdwr_open(struct inode *inode, struct file *filp) | |||
568 | * The file_operations structs are not static because they | 568 | * The file_operations structs are not static because they |
569 | * are also used in linux/fs/fifo.c to do operations on FIFOs. | 569 | * are also used in linux/fs/fifo.c to do operations on FIFOs. |
570 | */ | 570 | */ |
571 | struct file_operations read_fifo_fops = { | 571 | const struct file_operations read_fifo_fops = { |
572 | .llseek = no_llseek, | 572 | .llseek = no_llseek, |
573 | .read = pipe_read, | 573 | .read = pipe_read, |
574 | .readv = pipe_readv, | 574 | .readv = pipe_readv, |
@@ -580,7 +580,7 @@ struct file_operations read_fifo_fops = { | |||
580 | .fasync = pipe_read_fasync, | 580 | .fasync = pipe_read_fasync, |
581 | }; | 581 | }; |
582 | 582 | ||
583 | struct file_operations write_fifo_fops = { | 583 | const struct file_operations write_fifo_fops = { |
584 | .llseek = no_llseek, | 584 | .llseek = no_llseek, |
585 | .read = bad_pipe_r, | 585 | .read = bad_pipe_r, |
586 | .write = pipe_write, | 586 | .write = pipe_write, |
@@ -592,7 +592,7 @@ struct file_operations write_fifo_fops = { | |||
592 | .fasync = pipe_write_fasync, | 592 | .fasync = pipe_write_fasync, |
593 | }; | 593 | }; |
594 | 594 | ||
595 | struct file_operations rdwr_fifo_fops = { | 595 | const struct file_operations rdwr_fifo_fops = { |
596 | .llseek = no_llseek, | 596 | .llseek = no_llseek, |
597 | .read = pipe_read, | 597 | .read = pipe_read, |
598 | .readv = pipe_readv, | 598 | .readv = pipe_readv, |
@@ -675,7 +675,7 @@ fail_page: | |||
675 | return NULL; | 675 | return NULL; |
676 | } | 676 | } |
677 | 677 | ||
678 | static struct vfsmount *pipe_mnt; | 678 | static struct vfsmount *pipe_mnt __read_mostly; |
679 | static int pipefs_delete_dentry(struct dentry *dentry) | 679 | static int pipefs_delete_dentry(struct dentry *dentry) |
680 | { | 680 | { |
681 | return 1; | 681 | return 1; |
diff --git a/fs/proc/array.c b/fs/proc/array.c index 7eb1bd7f800c..7a76ad570230 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c | |||
@@ -330,7 +330,6 @@ static int do_task_stat(struct task_struct *task, char * buffer, int whole) | |||
330 | unsigned long min_flt = 0, maj_flt = 0; | 330 | unsigned long min_flt = 0, maj_flt = 0; |
331 | cputime_t cutime, cstime, utime, stime; | 331 | cputime_t cutime, cstime, utime, stime; |
332 | unsigned long rsslim = 0; | 332 | unsigned long rsslim = 0; |
333 | DEFINE_KTIME(it_real_value); | ||
334 | struct task_struct *t; | 333 | struct task_struct *t; |
335 | char tcomm[sizeof(task->comm)]; | 334 | char tcomm[sizeof(task->comm)]; |
336 | 335 | ||
@@ -386,7 +385,6 @@ static int do_task_stat(struct task_struct *task, char * buffer, int whole) | |||
386 | utime = cputime_add(utime, task->signal->utime); | 385 | utime = cputime_add(utime, task->signal->utime); |
387 | stime = cputime_add(stime, task->signal->stime); | 386 | stime = cputime_add(stime, task->signal->stime); |
388 | } | 387 | } |
389 | it_real_value = task->signal->real_timer.expires; | ||
390 | } | 388 | } |
391 | ppid = pid_alive(task) ? task->group_leader->real_parent->tgid : 0; | 389 | ppid = pid_alive(task) ? task->group_leader->real_parent->tgid : 0; |
392 | read_unlock(&tasklist_lock); | 390 | read_unlock(&tasklist_lock); |
@@ -413,7 +411,7 @@ static int do_task_stat(struct task_struct *task, char * buffer, int whole) | |||
413 | start_time = nsec_to_clock_t(start_time); | 411 | start_time = nsec_to_clock_t(start_time); |
414 | 412 | ||
415 | res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \ | 413 | res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \ |
416 | %lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu \ | 414 | %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \ |
417 | %lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n", | 415 | %lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n", |
418 | task->pid, | 416 | task->pid, |
419 | tcomm, | 417 | tcomm, |
@@ -435,7 +433,6 @@ static int do_task_stat(struct task_struct *task, char * buffer, int whole) | |||
435 | priority, | 433 | priority, |
436 | nice, | 434 | nice, |
437 | num_threads, | 435 | num_threads, |
438 | (long) ktime_to_clock_t(it_real_value), | ||
439 | start_time, | 436 | start_time, |
440 | vsize, | 437 | vsize, |
441 | mm ? get_mm_rss(mm) : 0, | 438 | mm ? get_mm_rss(mm) : 0, |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 20e5c4509a43..4ba03009cf72 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -19,6 +19,7 @@ | |||
19 | #include <linux/idr.h> | 19 | #include <linux/idr.h> |
20 | #include <linux/namei.h> | 20 | #include <linux/namei.h> |
21 | #include <linux/bitops.h> | 21 | #include <linux/bitops.h> |
22 | #include <linux/spinlock.h> | ||
22 | #include <asm/uaccess.h> | 23 | #include <asm/uaccess.h> |
23 | 24 | ||
24 | #include "internal.h" | 25 | #include "internal.h" |
@@ -29,6 +30,8 @@ static ssize_t proc_file_write(struct file *file, const char __user *buffer, | |||
29 | size_t count, loff_t *ppos); | 30 | size_t count, loff_t *ppos); |
30 | static loff_t proc_file_lseek(struct file *, loff_t, int); | 31 | static loff_t proc_file_lseek(struct file *, loff_t, int); |
31 | 32 | ||
33 | DEFINE_SPINLOCK(proc_subdir_lock); | ||
34 | |||
32 | int proc_match(int len, const char *name, struct proc_dir_entry *de) | 35 | int proc_match(int len, const char *name, struct proc_dir_entry *de) |
33 | { | 36 | { |
34 | if (de->namelen != len) | 37 | if (de->namelen != len) |
@@ -277,7 +280,9 @@ static int xlate_proc_name(const char *name, | |||
277 | const char *cp = name, *next; | 280 | const char *cp = name, *next; |
278 | struct proc_dir_entry *de; | 281 | struct proc_dir_entry *de; |
279 | int len; | 282 | int len; |
283 | int rtn = 0; | ||
280 | 284 | ||
285 | spin_lock(&proc_subdir_lock); | ||
281 | de = &proc_root; | 286 | de = &proc_root; |
282 | while (1) { | 287 | while (1) { |
283 | next = strchr(cp, '/'); | 288 | next = strchr(cp, '/'); |
@@ -289,13 +294,17 @@ static int xlate_proc_name(const char *name, | |||
289 | if (proc_match(len, cp, de)) | 294 | if (proc_match(len, cp, de)) |
290 | break; | 295 | break; |
291 | } | 296 | } |
292 | if (!de) | 297 | if (!de) { |
293 | return -ENOENT; | 298 | rtn = -ENOENT; |
299 | goto out; | ||
300 | } | ||
294 | cp += len + 1; | 301 | cp += len + 1; |
295 | } | 302 | } |
296 | *residual = cp; | 303 | *residual = cp; |
297 | *ret = de; | 304 | *ret = de; |
298 | return 0; | 305 | out: |
306 | spin_unlock(&proc_subdir_lock); | ||
307 | return rtn; | ||
299 | } | 308 | } |
300 | 309 | ||
301 | static DEFINE_IDR(proc_inum_idr); | 310 | static DEFINE_IDR(proc_inum_idr); |
@@ -380,6 +389,7 @@ struct dentry *proc_lookup(struct inode * dir, struct dentry *dentry, struct nam | |||
380 | int error = -ENOENT; | 389 | int error = -ENOENT; |
381 | 390 | ||
382 | lock_kernel(); | 391 | lock_kernel(); |
392 | spin_lock(&proc_subdir_lock); | ||
383 | de = PDE(dir); | 393 | de = PDE(dir); |
384 | if (de) { | 394 | if (de) { |
385 | for (de = de->subdir; de ; de = de->next) { | 395 | for (de = de->subdir; de ; de = de->next) { |
@@ -388,12 +398,15 @@ struct dentry *proc_lookup(struct inode * dir, struct dentry *dentry, struct nam | |||
388 | if (!memcmp(dentry->d_name.name, de->name, de->namelen)) { | 398 | if (!memcmp(dentry->d_name.name, de->name, de->namelen)) { |
389 | unsigned int ino = de->low_ino; | 399 | unsigned int ino = de->low_ino; |
390 | 400 | ||
401 | spin_unlock(&proc_subdir_lock); | ||
391 | error = -EINVAL; | 402 | error = -EINVAL; |
392 | inode = proc_get_inode(dir->i_sb, ino, de); | 403 | inode = proc_get_inode(dir->i_sb, ino, de); |
404 | spin_lock(&proc_subdir_lock); | ||
393 | break; | 405 | break; |
394 | } | 406 | } |
395 | } | 407 | } |
396 | } | 408 | } |
409 | spin_unlock(&proc_subdir_lock); | ||
397 | unlock_kernel(); | 410 | unlock_kernel(); |
398 | 411 | ||
399 | if (inode) { | 412 | if (inode) { |
@@ -447,11 +460,13 @@ int proc_readdir(struct file * filp, | |||
447 | filp->f_pos++; | 460 | filp->f_pos++; |
448 | /* fall through */ | 461 | /* fall through */ |
449 | default: | 462 | default: |
463 | spin_lock(&proc_subdir_lock); | ||
450 | de = de->subdir; | 464 | de = de->subdir; |
451 | i -= 2; | 465 | i -= 2; |
452 | for (;;) { | 466 | for (;;) { |
453 | if (!de) { | 467 | if (!de) { |
454 | ret = 1; | 468 | ret = 1; |
469 | spin_unlock(&proc_subdir_lock); | ||
455 | goto out; | 470 | goto out; |
456 | } | 471 | } |
457 | if (!i) | 472 | if (!i) |
@@ -461,12 +476,16 @@ int proc_readdir(struct file * filp, | |||
461 | } | 476 | } |
462 | 477 | ||
463 | do { | 478 | do { |
479 | /* filldir passes info to user space */ | ||
480 | spin_unlock(&proc_subdir_lock); | ||
464 | if (filldir(dirent, de->name, de->namelen, filp->f_pos, | 481 | if (filldir(dirent, de->name, de->namelen, filp->f_pos, |
465 | de->low_ino, de->mode >> 12) < 0) | 482 | de->low_ino, de->mode >> 12) < 0) |
466 | goto out; | 483 | goto out; |
484 | spin_lock(&proc_subdir_lock); | ||
467 | filp->f_pos++; | 485 | filp->f_pos++; |
468 | de = de->next; | 486 | de = de->next; |
469 | } while (de); | 487 | } while (de); |
488 | spin_unlock(&proc_subdir_lock); | ||
470 | } | 489 | } |
471 | ret = 1; | 490 | ret = 1; |
472 | out: unlock_kernel(); | 491 | out: unlock_kernel(); |
@@ -500,9 +519,13 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp | |||
500 | if (i == 0) | 519 | if (i == 0) |
501 | return -EAGAIN; | 520 | return -EAGAIN; |
502 | dp->low_ino = i; | 521 | dp->low_ino = i; |
522 | |||
523 | spin_lock(&proc_subdir_lock); | ||
503 | dp->next = dir->subdir; | 524 | dp->next = dir->subdir; |
504 | dp->parent = dir; | 525 | dp->parent = dir; |
505 | dir->subdir = dp; | 526 | dir->subdir = dp; |
527 | spin_unlock(&proc_subdir_lock); | ||
528 | |||
506 | if (S_ISDIR(dp->mode)) { | 529 | if (S_ISDIR(dp->mode)) { |
507 | if (dp->proc_iops == NULL) { | 530 | if (dp->proc_iops == NULL) { |
508 | dp->proc_fops = &proc_dir_operations; | 531 | dp->proc_fops = &proc_dir_operations; |
@@ -537,7 +560,7 @@ static void proc_kill_inodes(struct proc_dir_entry *de) | |||
537 | struct file * filp = list_entry(p, struct file, f_u.fu_list); | 560 | struct file * filp = list_entry(p, struct file, f_u.fu_list); |
538 | struct dentry * dentry = filp->f_dentry; | 561 | struct dentry * dentry = filp->f_dentry; |
539 | struct inode * inode; | 562 | struct inode * inode; |
540 | struct file_operations *fops; | 563 | const struct file_operations *fops; |
541 | 564 | ||
542 | if (dentry->d_op != &proc_dentry_operations) | 565 | if (dentry->d_op != &proc_dentry_operations) |
543 | continue; | 566 | continue; |
@@ -694,6 +717,8 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) | |||
694 | if (!parent && xlate_proc_name(name, &parent, &fn) != 0) | 717 | if (!parent && xlate_proc_name(name, &parent, &fn) != 0) |
695 | goto out; | 718 | goto out; |
696 | len = strlen(fn); | 719 | len = strlen(fn); |
720 | |||
721 | spin_lock(&proc_subdir_lock); | ||
697 | for (p = &parent->subdir; *p; p=&(*p)->next ) { | 722 | for (p = &parent->subdir; *p; p=&(*p)->next ) { |
698 | if (!proc_match(len, fn, *p)) | 723 | if (!proc_match(len, fn, *p)) |
699 | continue; | 724 | continue; |
@@ -714,6 +739,7 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) | |||
714 | } | 739 | } |
715 | break; | 740 | break; |
716 | } | 741 | } |
742 | spin_unlock(&proc_subdir_lock); | ||
717 | out: | 743 | out: |
718 | return; | 744 | return; |
719 | } | 745 | } |
diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 95a1cf32b838..0502f17b860d 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h | |||
@@ -30,7 +30,7 @@ do { \ | |||
30 | 30 | ||
31 | #endif | 31 | #endif |
32 | 32 | ||
33 | extern void create_seq_entry(char *name, mode_t mode, struct file_operations *f); | 33 | extern void create_seq_entry(char *name, mode_t mode, const struct file_operations *f); |
34 | extern int proc_exe_link(struct inode *, struct dentry **, struct vfsmount **); | 34 | extern int proc_exe_link(struct inode *, struct dentry **, struct vfsmount **); |
35 | extern int proc_tid_stat(struct task_struct *, char *); | 35 | extern int proc_tid_stat(struct task_struct *, char *); |
36 | extern int proc_tgid_stat(struct task_struct *, char *); | 36 | extern int proc_tgid_stat(struct task_struct *, char *); |
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index adc2cd95169a..17f6e8fa1397 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c | |||
@@ -31,7 +31,7 @@ static int open_kcore(struct inode * inode, struct file * filp) | |||
31 | 31 | ||
32 | static ssize_t read_kcore(struct file *, char __user *, size_t, loff_t *); | 32 | static ssize_t read_kcore(struct file *, char __user *, size_t, loff_t *); |
33 | 33 | ||
34 | struct file_operations proc_kcore_operations = { | 34 | const struct file_operations proc_kcore_operations = { |
35 | .read = read_kcore, | 35 | .read = read_kcore, |
36 | .open = open_kcore, | 36 | .open = open_kcore, |
37 | }; | 37 | }; |
diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index 10d37bf25206..ff3b90b56e9d 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c | |||
@@ -47,7 +47,7 @@ static unsigned int kmsg_poll(struct file *file, poll_table *wait) | |||
47 | } | 47 | } |
48 | 48 | ||
49 | 49 | ||
50 | struct file_operations proc_kmsg_operations = { | 50 | const struct file_operations proc_kmsg_operations = { |
51 | .read = kmsg_read, | 51 | .read = kmsg_read, |
52 | .poll = kmsg_poll, | 52 | .poll = kmsg_poll, |
53 | .open = kmsg_open, | 53 | .open = kmsg_open, |
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index 9bdd077d6f55..596b4b4f1cc8 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c | |||
@@ -136,9 +136,11 @@ void proc_device_tree_add_node(struct device_node *np, | |||
136 | * properties are quite unimportant for us though, thus we | 136 | * properties are quite unimportant for us though, thus we |
137 | * simply "skip" them here, but we do have to check. | 137 | * simply "skip" them here, but we do have to check. |
138 | */ | 138 | */ |
139 | spin_lock(&proc_subdir_lock); | ||
139 | for (ent = de->subdir; ent != NULL; ent = ent->next) | 140 | for (ent = de->subdir; ent != NULL; ent = ent->next) |
140 | if (!strcmp(ent->name, pp->name)) | 141 | if (!strcmp(ent->name, pp->name)) |
141 | break; | 142 | break; |
143 | spin_unlock(&proc_subdir_lock); | ||
142 | if (ent != NULL) { | 144 | if (ent != NULL) { |
143 | printk(KERN_WARNING "device-tree: property \"%s\" name" | 145 | printk(KERN_WARNING "device-tree: property \"%s\" name" |
144 | " conflicts with node in %s\n", pp->name, | 146 | " conflicts with node in %s\n", pp->name, |
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index 1e9ea37d457e..ef5a3323f4b5 100644 --- a/fs/proc/proc_misc.c +++ b/fs/proc/proc_misc.c | |||
@@ -534,7 +534,7 @@ static int show_stat(struct seq_file *p, void *v) | |||
534 | if (wall_to_monotonic.tv_nsec) | 534 | if (wall_to_monotonic.tv_nsec) |
535 | --jif; | 535 | --jif; |
536 | 536 | ||
537 | for_each_cpu(i) { | 537 | for_each_possible_cpu(i) { |
538 | int j; | 538 | int j; |
539 | 539 | ||
540 | user = cputime64_add(user, kstat_cpu(i).cpustat.user); | 540 | user = cputime64_add(user, kstat_cpu(i).cpustat.user); |
@@ -731,7 +731,7 @@ static struct file_operations proc_sysrq_trigger_operations = { | |||
731 | 731 | ||
732 | struct proc_dir_entry *proc_root_kcore; | 732 | struct proc_dir_entry *proc_root_kcore; |
733 | 733 | ||
734 | void create_seq_entry(char *name, mode_t mode, struct file_operations *f) | 734 | void create_seq_entry(char *name, mode_t mode, const struct file_operations *f) |
735 | { | 735 | { |
736 | struct proc_dir_entry *entry; | 736 | struct proc_dir_entry *entry; |
737 | entry = create_proc_entry(name, mode, NULL); | 737 | entry = create_proc_entry(name, mode, NULL); |
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 4063fb32f78c..7efa73d44c9a 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c | |||
@@ -172,7 +172,7 @@ static int open_vmcore(struct inode *inode, struct file *filp) | |||
172 | return 0; | 172 | return 0; |
173 | } | 173 | } |
174 | 174 | ||
175 | struct file_operations proc_vmcore_operations = { | 175 | const struct file_operations proc_vmcore_operations = { |
176 | .read = read_vmcore, | 176 | .read = read_vmcore, |
177 | .open = open_vmcore, | 177 | .open = open_vmcore, |
178 | }; | 178 | }; |
diff --git a/fs/qnx4/dir.c b/fs/qnx4/dir.c index 7a8f5595c26f..9031948fefd0 100644 --- a/fs/qnx4/dir.c +++ b/fs/qnx4/dir.c | |||
@@ -81,7 +81,7 @@ out: | |||
81 | return 0; | 81 | return 0; |
82 | } | 82 | } |
83 | 83 | ||
84 | struct file_operations qnx4_dir_operations = | 84 | const struct file_operations qnx4_dir_operations = |
85 | { | 85 | { |
86 | .read = generic_read_dir, | 86 | .read = generic_read_dir, |
87 | .readdir = qnx4_readdir, | 87 | .readdir = qnx4_readdir, |
diff --git a/fs/qnx4/file.c b/fs/qnx4/file.c index c33963fded9e..62af4b1348bd 100644 --- a/fs/qnx4/file.c +++ b/fs/qnx4/file.c | |||
@@ -19,7 +19,7 @@ | |||
19 | * We have mostly NULL's here: the current defaults are ok for | 19 | * We have mostly NULL's here: the current defaults are ok for |
20 | * the qnx4 filesystem. | 20 | * the qnx4 filesystem. |
21 | */ | 21 | */ |
22 | struct file_operations qnx4_file_operations = | 22 | const struct file_operations qnx4_file_operations = |
23 | { | 23 | { |
24 | .llseek = generic_file_llseek, | 24 | .llseek = generic_file_llseek, |
25 | .read = generic_file_read, | 25 | .read = generic_file_read, |
diff --git a/fs/ramfs/file-mmu.c b/fs/ramfs/file-mmu.c index 6ada2095b9ac..00a933eb820c 100644 --- a/fs/ramfs/file-mmu.c +++ b/fs/ramfs/file-mmu.c | |||
@@ -32,7 +32,7 @@ struct address_space_operations ramfs_aops = { | |||
32 | .commit_write = simple_commit_write | 32 | .commit_write = simple_commit_write |
33 | }; | 33 | }; |
34 | 34 | ||
35 | struct file_operations ramfs_file_operations = { | 35 | const struct file_operations ramfs_file_operations = { |
36 | .read = generic_file_read, | 36 | .read = generic_file_read, |
37 | .write = generic_file_write, | 37 | .write = generic_file_write, |
38 | .mmap = generic_file_mmap, | 38 | .mmap = generic_file_mmap, |
diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c index b1ca234068f6..f443a84b98a5 100644 --- a/fs/ramfs/file-nommu.c +++ b/fs/ramfs/file-nommu.c | |||
@@ -33,7 +33,7 @@ struct address_space_operations ramfs_aops = { | |||
33 | .commit_write = simple_commit_write | 33 | .commit_write = simple_commit_write |
34 | }; | 34 | }; |
35 | 35 | ||
36 | struct file_operations ramfs_file_operations = { | 36 | const struct file_operations ramfs_file_operations = { |
37 | .mmap = ramfs_nommu_mmap, | 37 | .mmap = ramfs_nommu_mmap, |
38 | .get_unmapped_area = ramfs_nommu_get_unmapped_area, | 38 | .get_unmapped_area = ramfs_nommu_get_unmapped_area, |
39 | .read = generic_file_read, | 39 | .read = generic_file_read, |
diff --git a/fs/ramfs/internal.h b/fs/ramfs/internal.h index 272c8a7120b0..313237631b49 100644 --- a/fs/ramfs/internal.h +++ b/fs/ramfs/internal.h | |||
@@ -11,5 +11,5 @@ | |||
11 | 11 | ||
12 | 12 | ||
13 | extern struct address_space_operations ramfs_aops; | 13 | extern struct address_space_operations ramfs_aops; |
14 | extern struct file_operations ramfs_file_operations; | 14 | extern const struct file_operations ramfs_file_operations; |
15 | extern struct inode_operations ramfs_file_inode_operations; | 15 | extern struct inode_operations ramfs_file_inode_operations; |
diff --git a/fs/read_write.c b/fs/read_write.c index 34b1bf259efd..6256ca81a718 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -19,7 +19,7 @@ | |||
19 | #include <asm/uaccess.h> | 19 | #include <asm/uaccess.h> |
20 | #include <asm/unistd.h> | 20 | #include <asm/unistd.h> |
21 | 21 | ||
22 | struct file_operations generic_ro_fops = { | 22 | const struct file_operations generic_ro_fops = { |
23 | .llseek = generic_file_llseek, | 23 | .llseek = generic_file_llseek, |
24 | .read = generic_file_read, | 24 | .read = generic_file_read, |
25 | .mmap = generic_file_readonly_mmap, | 25 | .mmap = generic_file_readonly_mmap, |
diff --git a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c index d71ac6579289..973c819f8033 100644 --- a/fs/reiserfs/dir.c +++ b/fs/reiserfs/dir.c | |||
@@ -18,7 +18,7 @@ static int reiserfs_readdir(struct file *, void *, filldir_t); | |||
18 | static int reiserfs_dir_fsync(struct file *filp, struct dentry *dentry, | 18 | static int reiserfs_dir_fsync(struct file *filp, struct dentry *dentry, |
19 | int datasync); | 19 | int datasync); |
20 | 20 | ||
21 | struct file_operations reiserfs_dir_operations = { | 21 | const struct file_operations reiserfs_dir_operations = { |
22 | .read = generic_read_dir, | 22 | .read = generic_read_dir, |
23 | .readdir = reiserfs_readdir, | 23 | .readdir = reiserfs_readdir, |
24 | .fsync = reiserfs_dir_fsync, | 24 | .fsync = reiserfs_dir_fsync, |
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c index d0c1e865963e..010094d14da6 100644 --- a/fs/reiserfs/file.c +++ b/fs/reiserfs/file.c | |||
@@ -1566,7 +1566,7 @@ static ssize_t reiserfs_aio_write(struct kiocb *iocb, const char __user * buf, | |||
1566 | return generic_file_aio_write(iocb, buf, count, pos); | 1566 | return generic_file_aio_write(iocb, buf, count, pos); |
1567 | } | 1567 | } |
1568 | 1568 | ||
1569 | struct file_operations reiserfs_file_operations = { | 1569 | const struct file_operations reiserfs_file_operations = { |
1570 | .read = generic_file_read, | 1570 | .read = generic_file_read, |
1571 | .write = reiserfs_file_write, | 1571 | .write = reiserfs_file_write, |
1572 | .ioctl = reiserfs_ioctl, | 1572 | .ioctl = reiserfs_ioctl, |
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index d60f6238c66a..9857e50f85e7 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
@@ -466,7 +466,6 @@ static int reiserfs_get_block_create_0(struct inode *inode, sector_t block, | |||
466 | direct_IO request. */ | 466 | direct_IO request. */ |
467 | static int reiserfs_get_blocks_direct_io(struct inode *inode, | 467 | static int reiserfs_get_blocks_direct_io(struct inode *inode, |
468 | sector_t iblock, | 468 | sector_t iblock, |
469 | unsigned long max_blocks, | ||
470 | struct buffer_head *bh_result, | 469 | struct buffer_head *bh_result, |
471 | int create) | 470 | int create) |
472 | { | 471 | { |
@@ -2793,7 +2792,7 @@ static int invalidatepage_can_drop(struct inode *inode, struct buffer_head *bh) | |||
2793 | } | 2792 | } |
2794 | 2793 | ||
2795 | /* clm -- taken from fs/buffer.c:block_invalidate_page */ | 2794 | /* clm -- taken from fs/buffer.c:block_invalidate_page */ |
2796 | static int reiserfs_invalidatepage(struct page *page, unsigned long offset) | 2795 | static void reiserfs_invalidatepage(struct page *page, unsigned long offset) |
2797 | { | 2796 | { |
2798 | struct buffer_head *head, *bh, *next; | 2797 | struct buffer_head *head, *bh, *next; |
2799 | struct inode *inode = page->mapping->host; | 2798 | struct inode *inode = page->mapping->host; |
@@ -2832,10 +2831,12 @@ static int reiserfs_invalidatepage(struct page *page, unsigned long offset) | |||
2832 | * The get_block cached value has been unconditionally invalidated, | 2831 | * The get_block cached value has been unconditionally invalidated, |
2833 | * so real IO is not possible anymore. | 2832 | * so real IO is not possible anymore. |
2834 | */ | 2833 | */ |
2835 | if (!offset && ret) | 2834 | if (!offset && ret) { |
2836 | ret = try_to_release_page(page, 0); | 2835 | ret = try_to_release_page(page, 0); |
2836 | /* maybe should BUG_ON(!ret); - neilb */ | ||
2837 | } | ||
2837 | out: | 2838 | out: |
2838 | return ret; | 2839 | return; |
2839 | } | 2840 | } |
2840 | 2841 | ||
2841 | static int reiserfs_set_page_dirty(struct page *page) | 2842 | static int reiserfs_set_page_dirty(struct page *page) |
diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c index 78b40621b88b..27bd3a1df2ad 100644 --- a/fs/reiserfs/prints.c +++ b/fs/reiserfs/prints.c | |||
@@ -143,7 +143,7 @@ static void sprintf_buffer_head(char *buf, struct buffer_head *bh) | |||
143 | char b[BDEVNAME_SIZE]; | 143 | char b[BDEVNAME_SIZE]; |
144 | 144 | ||
145 | sprintf(buf, | 145 | sprintf(buf, |
146 | "dev %s, size %d, blocknr %llu, count %d, state 0x%lx, page %p, (%s, %s, %s)", | 146 | "dev %s, size %zd, blocknr %llu, count %d, state 0x%lx, page %p, (%s, %s, %s)", |
147 | bdevname(bh->b_bdev, b), bh->b_size, | 147 | bdevname(bh->b_bdev, b), bh->b_size, |
148 | (unsigned long long)bh->b_blocknr, atomic_read(&(bh->b_count)), | 148 | (unsigned long long)bh->b_blocknr, atomic_read(&(bh->b_count)), |
149 | bh->b_state, bh->b_page, | 149 | bh->b_state, bh->b_page, |
diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c index ef6caed9336b..731688e1cfe3 100644 --- a/fs/reiserfs/procfs.c +++ b/fs/reiserfs/procfs.c | |||
@@ -470,7 +470,7 @@ static int r_open(struct inode *inode, struct file *file) | |||
470 | return ret; | 470 | return ret; |
471 | } | 471 | } |
472 | 472 | ||
473 | static struct file_operations r_file_operations = { | 473 | static const struct file_operations r_file_operations = { |
474 | .open = r_open, | 474 | .open = r_open, |
475 | .read = seq_read, | 475 | .read = seq_read, |
476 | .llseek = seq_lseek, | 476 | .llseek = seq_lseek, |
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c index c2fc424d7d5c..9b9eda7b335c 100644 --- a/fs/romfs/inode.c +++ b/fs/romfs/inode.c | |||
@@ -463,7 +463,7 @@ static struct address_space_operations romfs_aops = { | |||
463 | .readpage = romfs_readpage | 463 | .readpage = romfs_readpage |
464 | }; | 464 | }; |
465 | 465 | ||
466 | static struct file_operations romfs_dir_operations = { | 466 | static const struct file_operations romfs_dir_operations = { |
467 | .read = generic_read_dir, | 467 | .read = generic_read_dir, |
468 | .readdir = romfs_readdir, | 468 | .readdir = romfs_readdir, |
469 | }; | 469 | }; |
diff --git a/fs/select.c b/fs/select.c index 1815a57d2255..b3a3a1326af6 100644 --- a/fs/select.c +++ b/fs/select.c | |||
@@ -29,12 +29,6 @@ | |||
29 | #define ROUND_UP(x,y) (((x)+(y)-1)/(y)) | 29 | #define ROUND_UP(x,y) (((x)+(y)-1)/(y)) |
30 | #define DEFAULT_POLLMASK (POLLIN | POLLOUT | POLLRDNORM | POLLWRNORM) | 30 | #define DEFAULT_POLLMASK (POLLIN | POLLOUT | POLLRDNORM | POLLWRNORM) |
31 | 31 | ||
32 | struct poll_table_entry { | ||
33 | struct file * filp; | ||
34 | wait_queue_t wait; | ||
35 | wait_queue_head_t * wait_address; | ||
36 | }; | ||
37 | |||
38 | struct poll_table_page { | 32 | struct poll_table_page { |
39 | struct poll_table_page * next; | 33 | struct poll_table_page * next; |
40 | struct poll_table_entry * entry; | 34 | struct poll_table_entry * entry; |
@@ -64,13 +58,23 @@ void poll_initwait(struct poll_wqueues *pwq) | |||
64 | init_poll_funcptr(&pwq->pt, __pollwait); | 58 | init_poll_funcptr(&pwq->pt, __pollwait); |
65 | pwq->error = 0; | 59 | pwq->error = 0; |
66 | pwq->table = NULL; | 60 | pwq->table = NULL; |
61 | pwq->inline_index = 0; | ||
67 | } | 62 | } |
68 | 63 | ||
69 | EXPORT_SYMBOL(poll_initwait); | 64 | EXPORT_SYMBOL(poll_initwait); |
70 | 65 | ||
66 | static void free_poll_entry(struct poll_table_entry *entry) | ||
67 | { | ||
68 | remove_wait_queue(entry->wait_address,&entry->wait); | ||
69 | fput(entry->filp); | ||
70 | } | ||
71 | |||
71 | void poll_freewait(struct poll_wqueues *pwq) | 72 | void poll_freewait(struct poll_wqueues *pwq) |
72 | { | 73 | { |
73 | struct poll_table_page * p = pwq->table; | 74 | struct poll_table_page * p = pwq->table; |
75 | int i; | ||
76 | for (i = 0; i < pwq->inline_index; i++) | ||
77 | free_poll_entry(pwq->inline_entries + i); | ||
74 | while (p) { | 78 | while (p) { |
75 | struct poll_table_entry * entry; | 79 | struct poll_table_entry * entry; |
76 | struct poll_table_page *old; | 80 | struct poll_table_page *old; |
@@ -78,8 +82,7 @@ void poll_freewait(struct poll_wqueues *pwq) | |||
78 | entry = p->entry; | 82 | entry = p->entry; |
79 | do { | 83 | do { |
80 | entry--; | 84 | entry--; |
81 | remove_wait_queue(entry->wait_address,&entry->wait); | 85 | free_poll_entry(entry); |
82 | fput(entry->filp); | ||
83 | } while (entry > p->entries); | 86 | } while (entry > p->entries); |
84 | old = p; | 87 | old = p; |
85 | p = p->next; | 88 | p = p->next; |
@@ -89,12 +92,14 @@ void poll_freewait(struct poll_wqueues *pwq) | |||
89 | 92 | ||
90 | EXPORT_SYMBOL(poll_freewait); | 93 | EXPORT_SYMBOL(poll_freewait); |
91 | 94 | ||
92 | static void __pollwait(struct file *filp, wait_queue_head_t *wait_address, | 95 | static struct poll_table_entry *poll_get_entry(poll_table *_p) |
93 | poll_table *_p) | ||
94 | { | 96 | { |
95 | struct poll_wqueues *p = container_of(_p, struct poll_wqueues, pt); | 97 | struct poll_wqueues *p = container_of(_p, struct poll_wqueues, pt); |
96 | struct poll_table_page *table = p->table; | 98 | struct poll_table_page *table = p->table; |
97 | 99 | ||
100 | if (p->inline_index < N_INLINE_POLL_ENTRIES) | ||
101 | return p->inline_entries + p->inline_index++; | ||
102 | |||
98 | if (!table || POLL_TABLE_FULL(table)) { | 103 | if (!table || POLL_TABLE_FULL(table)) { |
99 | struct poll_table_page *new_table; | 104 | struct poll_table_page *new_table; |
100 | 105 | ||
@@ -102,7 +107,7 @@ static void __pollwait(struct file *filp, wait_queue_head_t *wait_address, | |||
102 | if (!new_table) { | 107 | if (!new_table) { |
103 | p->error = -ENOMEM; | 108 | p->error = -ENOMEM; |
104 | __set_current_state(TASK_RUNNING); | 109 | __set_current_state(TASK_RUNNING); |
105 | return; | 110 | return NULL; |
106 | } | 111 | } |
107 | new_table->entry = new_table->entries; | 112 | new_table->entry = new_table->entries; |
108 | new_table->next = table; | 113 | new_table->next = table; |
@@ -110,16 +115,21 @@ static void __pollwait(struct file *filp, wait_queue_head_t *wait_address, | |||
110 | table = new_table; | 115 | table = new_table; |
111 | } | 116 | } |
112 | 117 | ||
113 | /* Add a new entry */ | 118 | return table->entry++; |
114 | { | 119 | } |
115 | struct poll_table_entry * entry = table->entry; | 120 | |
116 | table->entry = entry+1; | 121 | /* Add a new entry */ |
117 | get_file(filp); | 122 | static void __pollwait(struct file *filp, wait_queue_head_t *wait_address, |
118 | entry->filp = filp; | 123 | poll_table *p) |
119 | entry->wait_address = wait_address; | 124 | { |
120 | init_waitqueue_entry(&entry->wait, current); | 125 | struct poll_table_entry *entry = poll_get_entry(p); |
121 | add_wait_queue(wait_address,&entry->wait); | 126 | if (!entry) |
122 | } | 127 | return; |
128 | get_file(filp); | ||
129 | entry->filp = filp; | ||
130 | entry->wait_address = wait_address; | ||
131 | init_waitqueue_entry(&entry->wait, current); | ||
132 | add_wait_queue(wait_address,&entry->wait); | ||
123 | } | 133 | } |
124 | 134 | ||
125 | #define FDS_IN(fds, n) (fds->in + n) | 135 | #define FDS_IN(fds, n) (fds->in + n) |
@@ -210,7 +220,7 @@ int do_select(int n, fd_set_bits *fds, s64 *timeout) | |||
210 | for (i = 0; i < n; ++rinp, ++routp, ++rexp) { | 220 | for (i = 0; i < n; ++rinp, ++routp, ++rexp) { |
211 | unsigned long in, out, ex, all_bits, bit = 1, mask, j; | 221 | unsigned long in, out, ex, all_bits, bit = 1, mask, j; |
212 | unsigned long res_in = 0, res_out = 0, res_ex = 0; | 222 | unsigned long res_in = 0, res_out = 0, res_ex = 0; |
213 | struct file_operations *f_op = NULL; | 223 | const struct file_operations *f_op = NULL; |
214 | struct file *file = NULL; | 224 | struct file *file = NULL; |
215 | 225 | ||
216 | in = *inp++; out = *outp++; ex = *exp++; | 226 | in = *inp++; out = *outp++; ex = *exp++; |
@@ -221,17 +231,18 @@ int do_select(int n, fd_set_bits *fds, s64 *timeout) | |||
221 | } | 231 | } |
222 | 232 | ||
223 | for (j = 0; j < __NFDBITS; ++j, ++i, bit <<= 1) { | 233 | for (j = 0; j < __NFDBITS; ++j, ++i, bit <<= 1) { |
234 | int fput_needed; | ||
224 | if (i >= n) | 235 | if (i >= n) |
225 | break; | 236 | break; |
226 | if (!(bit & all_bits)) | 237 | if (!(bit & all_bits)) |
227 | continue; | 238 | continue; |
228 | file = fget(i); | 239 | file = fget_light(i, &fput_needed); |
229 | if (file) { | 240 | if (file) { |
230 | f_op = file->f_op; | 241 | f_op = file->f_op; |
231 | mask = DEFAULT_POLLMASK; | 242 | mask = DEFAULT_POLLMASK; |
232 | if (f_op && f_op->poll) | 243 | if (f_op && f_op->poll) |
233 | mask = (*f_op->poll)(file, retval ? NULL : wait); | 244 | mask = (*f_op->poll)(file, retval ? NULL : wait); |
234 | fput(file); | 245 | fput_light(file, fput_needed); |
235 | if ((mask & POLLIN_SET) && (in & bit)) { | 246 | if ((mask & POLLIN_SET) && (in & bit)) { |
236 | res_in |= bit; | 247 | res_in |= bit; |
237 | retval++; | 248 | retval++; |
@@ -284,16 +295,6 @@ int do_select(int n, fd_set_bits *fds, s64 *timeout) | |||
284 | return retval; | 295 | return retval; |
285 | } | 296 | } |
286 | 297 | ||
287 | static void *select_bits_alloc(int size) | ||
288 | { | ||
289 | return kmalloc(6 * size, GFP_KERNEL); | ||
290 | } | ||
291 | |||
292 | static void select_bits_free(void *bits, int size) | ||
293 | { | ||
294 | kfree(bits); | ||
295 | } | ||
296 | |||
297 | /* | 298 | /* |
298 | * We can actually return ERESTARTSYS instead of EINTR, but I'd | 299 | * We can actually return ERESTARTSYS instead of EINTR, but I'd |
299 | * like to be certain this leads to no problems. So I return | 300 | * like to be certain this leads to no problems. So I return |
@@ -312,6 +313,8 @@ static int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp, | |||
312 | char *bits; | 313 | char *bits; |
313 | int ret, size, max_fdset; | 314 | int ret, size, max_fdset; |
314 | struct fdtable *fdt; | 315 | struct fdtable *fdt; |
316 | /* Allocate small arguments on the stack to save memory and be faster */ | ||
317 | char stack_fds[SELECT_STACK_ALLOC]; | ||
315 | 318 | ||
316 | ret = -EINVAL; | 319 | ret = -EINVAL; |
317 | if (n < 0) | 320 | if (n < 0) |
@@ -332,7 +335,10 @@ static int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp, | |||
332 | */ | 335 | */ |
333 | ret = -ENOMEM; | 336 | ret = -ENOMEM; |
334 | size = FDS_BYTES(n); | 337 | size = FDS_BYTES(n); |
335 | bits = select_bits_alloc(size); | 338 | if (6*size < SELECT_STACK_ALLOC) |
339 | bits = stack_fds; | ||
340 | else | ||
341 | bits = kmalloc(6 * size, GFP_KERNEL); | ||
336 | if (!bits) | 342 | if (!bits) |
337 | goto out_nofds; | 343 | goto out_nofds; |
338 | fds.in = (unsigned long *) bits; | 344 | fds.in = (unsigned long *) bits; |
@@ -367,7 +373,8 @@ static int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp, | |||
367 | ret = -EFAULT; | 373 | ret = -EFAULT; |
368 | 374 | ||
369 | out: | 375 | out: |
370 | select_bits_free(bits, size); | 376 | if (bits != stack_fds) |
377 | kfree(bits); | ||
371 | out_nofds: | 378 | out_nofds: |
372 | return ret; | 379 | return ret; |
373 | } | 380 | } |
@@ -551,14 +558,15 @@ static void do_pollfd(unsigned int num, struct pollfd * fdpage, | |||
551 | fdp = fdpage+i; | 558 | fdp = fdpage+i; |
552 | fd = fdp->fd; | 559 | fd = fdp->fd; |
553 | if (fd >= 0) { | 560 | if (fd >= 0) { |
554 | struct file * file = fget(fd); | 561 | int fput_needed; |
562 | struct file * file = fget_light(fd, &fput_needed); | ||
555 | mask = POLLNVAL; | 563 | mask = POLLNVAL; |
556 | if (file != NULL) { | 564 | if (file != NULL) { |
557 | mask = DEFAULT_POLLMASK; | 565 | mask = DEFAULT_POLLMASK; |
558 | if (file->f_op && file->f_op->poll) | 566 | if (file->f_op && file->f_op->poll) |
559 | mask = file->f_op->poll(file, *pwait); | 567 | mask = file->f_op->poll(file, *pwait); |
560 | mask &= fdp->events | POLLERR | POLLHUP; | 568 | mask &= fdp->events | POLLERR | POLLHUP; |
561 | fput(file); | 569 | fput_light(file, fput_needed); |
562 | } | 570 | } |
563 | if (mask) { | 571 | if (mask) { |
564 | *pwait = NULL; | 572 | *pwait = NULL; |
@@ -619,6 +627,9 @@ static int do_poll(unsigned int nfds, struct poll_list *list, | |||
619 | return count; | 627 | return count; |
620 | } | 628 | } |
621 | 629 | ||
630 | #define N_STACK_PPS ((sizeof(stack_pps) - sizeof(struct poll_list)) / \ | ||
631 | sizeof(struct pollfd)) | ||
632 | |||
622 | int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, s64 *timeout) | 633 | int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, s64 *timeout) |
623 | { | 634 | { |
624 | struct poll_wqueues table; | 635 | struct poll_wqueues table; |
@@ -628,6 +639,9 @@ int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, s64 *timeout) | |||
628 | struct poll_list *walk; | 639 | struct poll_list *walk; |
629 | struct fdtable *fdt; | 640 | struct fdtable *fdt; |
630 | int max_fdset; | 641 | int max_fdset; |
642 | /* Allocate small arguments on the stack to save memory and be faster */ | ||
643 | char stack_pps[POLL_STACK_ALLOC]; | ||
644 | struct poll_list *stack_pp = NULL; | ||
631 | 645 | ||
632 | /* Do a sanity check on nfds ... */ | 646 | /* Do a sanity check on nfds ... */ |
633 | rcu_read_lock(); | 647 | rcu_read_lock(); |
@@ -645,14 +659,23 @@ int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, s64 *timeout) | |||
645 | err = -ENOMEM; | 659 | err = -ENOMEM; |
646 | while(i!=0) { | 660 | while(i!=0) { |
647 | struct poll_list *pp; | 661 | struct poll_list *pp; |
648 | pp = kmalloc(sizeof(struct poll_list)+ | 662 | int num, size; |
649 | sizeof(struct pollfd)* | 663 | if (stack_pp == NULL) |
650 | (i>POLLFD_PER_PAGE?POLLFD_PER_PAGE:i), | 664 | num = N_STACK_PPS; |
651 | GFP_KERNEL); | 665 | else |
652 | if(pp==NULL) | 666 | num = POLLFD_PER_PAGE; |
653 | goto out_fds; | 667 | if (num > i) |
668 | num = i; | ||
669 | size = sizeof(struct poll_list) + sizeof(struct pollfd)*num; | ||
670 | if (!stack_pp) | ||
671 | stack_pp = pp = (struct poll_list *)stack_pps; | ||
672 | else { | ||
673 | pp = kmalloc(size, GFP_KERNEL); | ||
674 | if (!pp) | ||
675 | goto out_fds; | ||
676 | } | ||
654 | pp->next=NULL; | 677 | pp->next=NULL; |
655 | pp->len = (i>POLLFD_PER_PAGE?POLLFD_PER_PAGE:i); | 678 | pp->len = num; |
656 | if (head == NULL) | 679 | if (head == NULL) |
657 | head = pp; | 680 | head = pp; |
658 | else | 681 | else |
@@ -660,7 +683,7 @@ int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, s64 *timeout) | |||
660 | 683 | ||
661 | walk = pp; | 684 | walk = pp; |
662 | if (copy_from_user(pp->entries, ufds + nfds-i, | 685 | if (copy_from_user(pp->entries, ufds + nfds-i, |
663 | sizeof(struct pollfd)*pp->len)) { | 686 | sizeof(struct pollfd)*num)) { |
664 | err = -EFAULT; | 687 | err = -EFAULT; |
665 | goto out_fds; | 688 | goto out_fds; |
666 | } | 689 | } |
@@ -689,7 +712,8 @@ out_fds: | |||
689 | walk = head; | 712 | walk = head; |
690 | while(walk!=NULL) { | 713 | while(walk!=NULL) { |
691 | struct poll_list *pp = walk->next; | 714 | struct poll_list *pp = walk->next; |
692 | kfree(walk); | 715 | if (walk != stack_pp) |
716 | kfree(walk); | ||
693 | walk = pp; | 717 | walk = pp; |
694 | } | 718 | } |
695 | poll_freewait(&table); | 719 | poll_freewait(&table); |
diff --git a/fs/smbfs/dir.c b/fs/smbfs/dir.c index 0424d06b147e..34c7a11d91f0 100644 --- a/fs/smbfs/dir.c +++ b/fs/smbfs/dir.c | |||
@@ -34,7 +34,7 @@ static int smb_rename(struct inode *, struct dentry *, | |||
34 | static int smb_make_node(struct inode *,struct dentry *,int,dev_t); | 34 | static int smb_make_node(struct inode *,struct dentry *,int,dev_t); |
35 | static int smb_link(struct dentry *, struct inode *, struct dentry *); | 35 | static int smb_link(struct dentry *, struct inode *, struct dentry *); |
36 | 36 | ||
37 | struct file_operations smb_dir_operations = | 37 | const struct file_operations smb_dir_operations = |
38 | { | 38 | { |
39 | .read = generic_read_dir, | 39 | .read = generic_read_dir, |
40 | .readdir = smb_readdir, | 40 | .readdir = smb_readdir, |
diff --git a/fs/smbfs/file.c b/fs/smbfs/file.c index 7042e62726a4..c56bd99a9701 100644 --- a/fs/smbfs/file.c +++ b/fs/smbfs/file.c | |||
@@ -401,7 +401,7 @@ smb_file_permission(struct inode *inode, int mask, struct nameidata *nd) | |||
401 | return error; | 401 | return error; |
402 | } | 402 | } |
403 | 403 | ||
404 | struct file_operations smb_file_operations = | 404 | const struct file_operations smb_file_operations = |
405 | { | 405 | { |
406 | .llseek = remote_llseek, | 406 | .llseek = remote_llseek, |
407 | .read = smb_file_read, | 407 | .read = smb_file_read, |
diff --git a/fs/smbfs/proto.h b/fs/smbfs/proto.h index e866ec8660d0..47664597e6b1 100644 --- a/fs/smbfs/proto.h +++ b/fs/smbfs/proto.h | |||
@@ -35,7 +35,7 @@ extern int smb_proc_symlink(struct smb_sb_info *server, struct dentry *d, const | |||
35 | extern int smb_proc_link(struct smb_sb_info *server, struct dentry *dentry, struct dentry *new_dentry); | 35 | extern int smb_proc_link(struct smb_sb_info *server, struct dentry *dentry, struct dentry *new_dentry); |
36 | extern void smb_install_null_ops(struct smb_ops *ops); | 36 | extern void smb_install_null_ops(struct smb_ops *ops); |
37 | /* dir.c */ | 37 | /* dir.c */ |
38 | extern struct file_operations smb_dir_operations; | 38 | extern const struct file_operations smb_dir_operations; |
39 | extern struct inode_operations smb_dir_inode_operations; | 39 | extern struct inode_operations smb_dir_inode_operations; |
40 | extern struct inode_operations smb_dir_inode_operations_unix; | 40 | extern struct inode_operations smb_dir_inode_operations_unix; |
41 | extern void smb_new_dentry(struct dentry *dentry); | 41 | extern void smb_new_dentry(struct dentry *dentry); |
@@ -64,7 +64,7 @@ extern int smb_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat | |||
64 | extern int smb_notify_change(struct dentry *dentry, struct iattr *attr); | 64 | extern int smb_notify_change(struct dentry *dentry, struct iattr *attr); |
65 | /* file.c */ | 65 | /* file.c */ |
66 | extern struct address_space_operations smb_file_aops; | 66 | extern struct address_space_operations smb_file_aops; |
67 | extern struct file_operations smb_file_operations; | 67 | extern const struct file_operations smb_file_operations; |
68 | extern struct inode_operations smb_file_inode_operations; | 68 | extern struct inode_operations smb_file_inode_operations; |
69 | /* ioctl.c */ | 69 | /* ioctl.c */ |
70 | extern int smb_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, unsigned long arg); | 70 | extern int smb_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, unsigned long arg); |
diff --git a/fs/super.c b/fs/super.c index 8743e9bbb297..a66f66bb8049 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -37,6 +37,7 @@ | |||
37 | #include <linux/writeback.h> /* for the emergency remount stuff */ | 37 | #include <linux/writeback.h> /* for the emergency remount stuff */ |
38 | #include <linux/idr.h> | 38 | #include <linux/idr.h> |
39 | #include <linux/kobject.h> | 39 | #include <linux/kobject.h> |
40 | #include <linux/mutex.h> | ||
40 | #include <asm/uaccess.h> | 41 | #include <asm/uaccess.h> |
41 | 42 | ||
42 | 43 | ||
@@ -380,9 +381,9 @@ restart: | |||
380 | void sync_filesystems(int wait) | 381 | void sync_filesystems(int wait) |
381 | { | 382 | { |
382 | struct super_block *sb; | 383 | struct super_block *sb; |
383 | static DECLARE_MUTEX(mutex); | 384 | static DEFINE_MUTEX(mutex); |
384 | 385 | ||
385 | down(&mutex); /* Could be down_interruptible */ | 386 | mutex_lock(&mutex); /* Could be down_interruptible */ |
386 | spin_lock(&sb_lock); | 387 | spin_lock(&sb_lock); |
387 | list_for_each_entry(sb, &super_blocks, s_list) { | 388 | list_for_each_entry(sb, &super_blocks, s_list) { |
388 | if (!sb->s_op->sync_fs) | 389 | if (!sb->s_op->sync_fs) |
@@ -411,7 +412,7 @@ restart: | |||
411 | goto restart; | 412 | goto restart; |
412 | } | 413 | } |
413 | spin_unlock(&sb_lock); | 414 | spin_unlock(&sb_lock); |
414 | up(&mutex); | 415 | mutex_unlock(&mutex); |
415 | } | 416 | } |
416 | 417 | ||
417 | /** | 418 | /** |
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 78899eeab974..c16a93c353c0 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c | |||
@@ -163,7 +163,7 @@ static int release(struct inode * inode, struct file * file) | |||
163 | return 0; | 163 | return 0; |
164 | } | 164 | } |
165 | 165 | ||
166 | struct file_operations bin_fops = { | 166 | const struct file_operations bin_fops = { |
167 | .read = read, | 167 | .read = read, |
168 | .write = write, | 168 | .write = write, |
169 | .mmap = mmap, | 169 | .mmap = mmap, |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 9ee956864445..f26880a4785e 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -503,7 +503,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin) | |||
503 | return offset; | 503 | return offset; |
504 | } | 504 | } |
505 | 505 | ||
506 | struct file_operations sysfs_dir_operations = { | 506 | const struct file_operations sysfs_dir_operations = { |
507 | .open = sysfs_dir_open, | 507 | .open = sysfs_dir_open, |
508 | .release = sysfs_dir_close, | 508 | .release = sysfs_dir_close, |
509 | .llseek = sysfs_dir_lseek, | 509 | .llseek = sysfs_dir_lseek, |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 5e83e7246788..830f76fa098c 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
@@ -348,7 +348,7 @@ static int sysfs_release(struct inode * inode, struct file * filp) | |||
348 | return 0; | 348 | return 0; |
349 | } | 349 | } |
350 | 350 | ||
351 | struct file_operations sysfs_file_operations = { | 351 | const struct file_operations sysfs_file_operations = { |
352 | .read = sysfs_read_file, | 352 | .read = sysfs_read_file, |
353 | .write = sysfs_write_file, | 353 | .write = sysfs_write_file, |
354 | .llseek = generic_file_llseek, | 354 | .llseek = generic_file_llseek, |
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index cf11d5b789d9..32958a7c50e9 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
@@ -21,9 +21,9 @@ extern int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); | |||
21 | 21 | ||
22 | extern struct rw_semaphore sysfs_rename_sem; | 22 | extern struct rw_semaphore sysfs_rename_sem; |
23 | extern struct super_block * sysfs_sb; | 23 | extern struct super_block * sysfs_sb; |
24 | extern struct file_operations sysfs_dir_operations; | 24 | extern const struct file_operations sysfs_dir_operations; |
25 | extern struct file_operations sysfs_file_operations; | 25 | extern const struct file_operations sysfs_file_operations; |
26 | extern struct file_operations bin_fops; | 26 | extern const struct file_operations bin_fops; |
27 | extern struct inode_operations sysfs_dir_inode_operations; | 27 | extern struct inode_operations sysfs_dir_inode_operations; |
28 | extern struct inode_operations sysfs_symlink_inode_operations; | 28 | extern struct inode_operations sysfs_symlink_inode_operations; |
29 | 29 | ||
diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c index cce8b05cba5a..8c66e9270dd6 100644 --- a/fs/sysv/dir.c +++ b/fs/sysv/dir.c | |||
@@ -20,7 +20,7 @@ | |||
20 | 20 | ||
21 | static int sysv_readdir(struct file *, void *, filldir_t); | 21 | static int sysv_readdir(struct file *, void *, filldir_t); |
22 | 22 | ||
23 | struct file_operations sysv_dir_operations = { | 23 | const struct file_operations sysv_dir_operations = { |
24 | .read = generic_read_dir, | 24 | .read = generic_read_dir, |
25 | .readdir = sysv_readdir, | 25 | .readdir = sysv_readdir, |
26 | .fsync = sysv_sync_file, | 26 | .fsync = sysv_sync_file, |
diff --git a/fs/sysv/file.c b/fs/sysv/file.c index da69abc06240..a59e303135fa 100644 --- a/fs/sysv/file.c +++ b/fs/sysv/file.c | |||
@@ -19,7 +19,7 @@ | |||
19 | * We have mostly NULLs here: the current defaults are OK for | 19 | * We have mostly NULLs here: the current defaults are OK for |
20 | * the coh filesystem. | 20 | * the coh filesystem. |
21 | */ | 21 | */ |
22 | struct file_operations sysv_file_operations = { | 22 | const struct file_operations sysv_file_operations = { |
23 | .llseek = generic_file_llseek, | 23 | .llseek = generic_file_llseek, |
24 | .read = generic_file_read, | 24 | .read = generic_file_read, |
25 | .write = generic_file_write, | 25 | .write = generic_file_write, |
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h index b7f9b4a42aab..393a480e4deb 100644 --- a/fs/sysv/sysv.h +++ b/fs/sysv/sysv.h | |||
@@ -159,8 +159,8 @@ extern ino_t sysv_inode_by_name(struct dentry *); | |||
159 | extern struct inode_operations sysv_file_inode_operations; | 159 | extern struct inode_operations sysv_file_inode_operations; |
160 | extern struct inode_operations sysv_dir_inode_operations; | 160 | extern struct inode_operations sysv_dir_inode_operations; |
161 | extern struct inode_operations sysv_fast_symlink_inode_operations; | 161 | extern struct inode_operations sysv_fast_symlink_inode_operations; |
162 | extern struct file_operations sysv_file_operations; | 162 | extern const struct file_operations sysv_file_operations; |
163 | extern struct file_operations sysv_dir_operations; | 163 | extern const struct file_operations sysv_dir_operations; |
164 | extern struct address_space_operations sysv_aops; | 164 | extern struct address_space_operations sysv_aops; |
165 | extern struct super_operations sysv_sops; | 165 | extern struct super_operations sysv_sops; |
166 | extern struct dentry_operations sysv_dentry_operations; | 166 | extern struct dentry_operations sysv_dentry_operations; |
diff --git a/fs/udf/dir.c b/fs/udf/dir.c index f5222527fe39..8c28efa3b8ff 100644 --- a/fs/udf/dir.c +++ b/fs/udf/dir.c | |||
@@ -42,7 +42,7 @@ static int do_udf_readdir(struct inode *, struct file *, filldir_t, void *); | |||
42 | 42 | ||
43 | /* readdir and lookup functions */ | 43 | /* readdir and lookup functions */ |
44 | 44 | ||
45 | struct file_operations udf_dir_operations = { | 45 | const struct file_operations udf_dir_operations = { |
46 | .read = generic_read_dir, | 46 | .read = generic_read_dir, |
47 | .readdir = udf_readdir, | 47 | .readdir = udf_readdir, |
48 | .ioctl = udf_ioctl, | 48 | .ioctl = udf_ioctl, |
diff --git a/fs/udf/file.c b/fs/udf/file.c index a6f2acc1f15c..e34b00e303f1 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c | |||
@@ -248,7 +248,7 @@ static int udf_release_file(struct inode * inode, struct file * filp) | |||
248 | return 0; | 248 | return 0; |
249 | } | 249 | } |
250 | 250 | ||
251 | struct file_operations udf_file_operations = { | 251 | const struct file_operations udf_file_operations = { |
252 | .read = generic_file_read, | 252 | .read = generic_file_read, |
253 | .ioctl = udf_ioctl, | 253 | .ioctl = udf_ioctl, |
254 | .open = generic_file_open, | 254 | .open = generic_file_open, |
diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index 1d5800e0cbe7..023e19ba5a2e 100644 --- a/fs/udf/udfdecl.h +++ b/fs/udf/udfdecl.h | |||
@@ -44,9 +44,9 @@ struct buffer_head; | |||
44 | struct super_block; | 44 | struct super_block; |
45 | 45 | ||
46 | extern struct inode_operations udf_dir_inode_operations; | 46 | extern struct inode_operations udf_dir_inode_operations; |
47 | extern struct file_operations udf_dir_operations; | 47 | extern const struct file_operations udf_dir_operations; |
48 | extern struct inode_operations udf_file_inode_operations; | 48 | extern struct inode_operations udf_file_inode_operations; |
49 | extern struct file_operations udf_file_operations; | 49 | extern const struct file_operations udf_file_operations; |
50 | extern struct address_space_operations udf_aops; | 50 | extern struct address_space_operations udf_aops; |
51 | extern struct address_space_operations udf_adinicb_aops; | 51 | extern struct address_space_operations udf_adinicb_aops; |
52 | extern struct address_space_operations udf_symlink_aops; | 52 | extern struct address_space_operations udf_symlink_aops; |
diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 7c10c68902ae..1a561202d3f4 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c | |||
@@ -620,7 +620,7 @@ int ufs_empty_dir (struct inode * inode) | |||
620 | return 1; | 620 | return 1; |
621 | } | 621 | } |
622 | 622 | ||
623 | struct file_operations ufs_dir_operations = { | 623 | const struct file_operations ufs_dir_operations = { |
624 | .read = generic_read_dir, | 624 | .read = generic_read_dir, |
625 | .readdir = ufs_readdir, | 625 | .readdir = ufs_readdir, |
626 | .fsync = file_fsync, | 626 | .fsync = file_fsync, |
diff --git a/fs/ufs/file.c b/fs/ufs/file.c index 62ad481810ef..312fd3f86313 100644 --- a/fs/ufs/file.c +++ b/fs/ufs/file.c | |||
@@ -31,7 +31,7 @@ | |||
31 | * the ufs filesystem. | 31 | * the ufs filesystem. |
32 | */ | 32 | */ |
33 | 33 | ||
34 | struct file_operations ufs_file_operations = { | 34 | const struct file_operations ufs_file_operations = { |
35 | .llseek = generic_file_llseek, | 35 | .llseek = generic_file_llseek, |
36 | .read = generic_file_read, | 36 | .read = generic_file_read, |
37 | .write = generic_file_write, | 37 | .write = generic_file_write, |
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index 97fc056130eb..c02f7c5b7462 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
@@ -1310,20 +1310,21 @@ xfs_get_block( | |||
1310 | struct buffer_head *bh_result, | 1310 | struct buffer_head *bh_result, |
1311 | int create) | 1311 | int create) |
1312 | { | 1312 | { |
1313 | return __xfs_get_block(inode, iblock, 0, bh_result, | 1313 | return __xfs_get_block(inode, iblock, |
1314 | create, 0, BMAPI_WRITE); | 1314 | bh_result->b_size >> inode->i_blkbits, |
1315 | bh_result, create, 0, BMAPI_WRITE); | ||
1315 | } | 1316 | } |
1316 | 1317 | ||
1317 | STATIC int | 1318 | STATIC int |
1318 | xfs_get_blocks_direct( | 1319 | xfs_get_blocks_direct( |
1319 | struct inode *inode, | 1320 | struct inode *inode, |
1320 | sector_t iblock, | 1321 | sector_t iblock, |
1321 | unsigned long max_blocks, | ||
1322 | struct buffer_head *bh_result, | 1322 | struct buffer_head *bh_result, |
1323 | int create) | 1323 | int create) |
1324 | { | 1324 | { |
1325 | return __xfs_get_block(inode, iblock, max_blocks, bh_result, | 1325 | return __xfs_get_block(inode, iblock, |
1326 | create, 1, BMAPI_WRITE|BMAPI_DIRECT); | 1326 | bh_result->b_size >> inode->i_blkbits, |
1327 | bh_result, create, 1, BMAPI_WRITE|BMAPI_DIRECT); | ||
1327 | } | 1328 | } |
1328 | 1329 | ||
1329 | STATIC void | 1330 | STATIC void |
@@ -1442,14 +1443,14 @@ xfs_vm_readpages( | |||
1442 | return mpage_readpages(mapping, pages, nr_pages, xfs_get_block); | 1443 | return mpage_readpages(mapping, pages, nr_pages, xfs_get_block); |
1443 | } | 1444 | } |
1444 | 1445 | ||
1445 | STATIC int | 1446 | STATIC void |
1446 | xfs_vm_invalidatepage( | 1447 | xfs_vm_invalidatepage( |
1447 | struct page *page, | 1448 | struct page *page, |
1448 | unsigned long offset) | 1449 | unsigned long offset) |
1449 | { | 1450 | { |
1450 | xfs_page_trace(XFS_INVALIDPAGE_ENTER, | 1451 | xfs_page_trace(XFS_INVALIDPAGE_ENTER, |
1451 | page->mapping->host, page, offset); | 1452 | page->mapping->host, page, offset); |
1452 | return block_invalidatepage(page, offset); | 1453 | block_invalidatepage(page, offset); |
1453 | } | 1454 | } |
1454 | 1455 | ||
1455 | struct address_space_operations xfs_address_space_operations = { | 1456 | struct address_space_operations xfs_address_space_operations = { |
diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c index 185567a6a561..85997b1205f5 100644 --- a/fs/xfs/linux-2.6/xfs_file.c +++ b/fs/xfs/linux-2.6/xfs_file.c | |||
@@ -528,7 +528,7 @@ open_exec_out: | |||
528 | } | 528 | } |
529 | #endif /* HAVE_FOP_OPEN_EXEC */ | 529 | #endif /* HAVE_FOP_OPEN_EXEC */ |
530 | 530 | ||
531 | struct file_operations xfs_file_operations = { | 531 | const struct file_operations xfs_file_operations = { |
532 | .llseek = generic_file_llseek, | 532 | .llseek = generic_file_llseek, |
533 | .read = do_sync_read, | 533 | .read = do_sync_read, |
534 | .write = do_sync_write, | 534 | .write = do_sync_write, |
@@ -550,7 +550,7 @@ struct file_operations xfs_file_operations = { | |||
550 | #endif | 550 | #endif |
551 | }; | 551 | }; |
552 | 552 | ||
553 | struct file_operations xfs_invis_file_operations = { | 553 | const struct file_operations xfs_invis_file_operations = { |
554 | .llseek = generic_file_llseek, | 554 | .llseek = generic_file_llseek, |
555 | .read = do_sync_read, | 555 | .read = do_sync_read, |
556 | .write = do_sync_write, | 556 | .write = do_sync_write, |
@@ -570,7 +570,7 @@ struct file_operations xfs_invis_file_operations = { | |||
570 | }; | 570 | }; |
571 | 571 | ||
572 | 572 | ||
573 | struct file_operations xfs_dir_file_operations = { | 573 | const struct file_operations xfs_dir_file_operations = { |
574 | .read = generic_read_dir, | 574 | .read = generic_read_dir, |
575 | .readdir = xfs_file_readdir, | 575 | .readdir = xfs_file_readdir, |
576 | .unlocked_ioctl = xfs_file_ioctl, | 576 | .unlocked_ioctl = xfs_file_ioctl, |
diff --git a/fs/xfs/linux-2.6/xfs_iops.h b/fs/xfs/linux-2.6/xfs_iops.h index a8417d7af5f9..ad6173da5678 100644 --- a/fs/xfs/linux-2.6/xfs_iops.h +++ b/fs/xfs/linux-2.6/xfs_iops.h | |||
@@ -22,9 +22,9 @@ extern struct inode_operations xfs_inode_operations; | |||
22 | extern struct inode_operations xfs_dir_inode_operations; | 22 | extern struct inode_operations xfs_dir_inode_operations; |
23 | extern struct inode_operations xfs_symlink_inode_operations; | 23 | extern struct inode_operations xfs_symlink_inode_operations; |
24 | 24 | ||
25 | extern struct file_operations xfs_file_operations; | 25 | extern const struct file_operations xfs_file_operations; |
26 | extern struct file_operations xfs_dir_file_operations; | 26 | extern const struct file_operations xfs_dir_file_operations; |
27 | extern struct file_operations xfs_invis_file_operations; | 27 | extern const struct file_operations xfs_invis_file_operations; |
28 | 28 | ||
29 | extern int xfs_ioctl(struct bhv_desc *, struct inode *, struct file *, | 29 | extern int xfs_ioctl(struct bhv_desc *, struct inode *, struct file *, |
30 | int, unsigned int, void __user *); | 30 | int, unsigned int, void __user *); |
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index 8355faf8ffde..1884300417e3 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c | |||
@@ -375,9 +375,8 @@ xfs_init_zones(void) | |||
375 | if (!xfs_ioend_zone) | 375 | if (!xfs_ioend_zone) |
376 | goto out_destroy_vnode_zone; | 376 | goto out_destroy_vnode_zone; |
377 | 377 | ||
378 | xfs_ioend_pool = mempool_create(4 * MAX_BUF_PER_PAGE, | 378 | xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE, |
379 | mempool_alloc_slab, mempool_free_slab, | 379 | xfs_ioend_zone); |
380 | xfs_ioend_zone); | ||
381 | if (!xfs_ioend_pool) | 380 | if (!xfs_ioend_pool) |
382 | goto out_free_ioend_zone; | 381 | goto out_free_ioend_zone; |
383 | return 0; | 382 | return 0; |