diff options
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ext4/extents.c | 2 | ||||
-rw-r--r-- | fs/ext4/inode.c | 8 | ||||
-rw-r--r-- | fs/ext4/super.c | 9 |
3 files changed, 14 insertions, 5 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index ac77d8b8251d..6132353dcf62 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
@@ -342,7 +342,7 @@ static int ext4_valid_extent_idx(struct inode *inode, | |||
342 | ext4_fsblk_t block = idx_pblock(ext_idx); | 342 | ext4_fsblk_t block = idx_pblock(ext_idx); |
343 | struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es; | 343 | struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es; |
344 | if (unlikely(block < le32_to_cpu(es->s_first_data_block) || | 344 | if (unlikely(block < le32_to_cpu(es->s_first_data_block) || |
345 | (block > ext4_blocks_count(es)))) | 345 | (block >= ext4_blocks_count(es)))) |
346 | return 0; | 346 | return 0; |
347 | else | 347 | else |
348 | return 1; | 348 | return 1; |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index a2e7952bc5f9..c6bd6ced3bb7 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -372,16 +372,16 @@ static int ext4_block_to_path(struct inode *inode, | |||
372 | } | 372 | } |
373 | 373 | ||
374 | static int __ext4_check_blockref(const char *function, struct inode *inode, | 374 | static int __ext4_check_blockref(const char *function, struct inode *inode, |
375 | unsigned int *p, unsigned int max) { | 375 | __le32 *p, unsigned int max) { |
376 | 376 | ||
377 | unsigned int maxblocks = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es); | 377 | unsigned int maxblocks = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es); |
378 | unsigned int *bref = p; | 378 | __le32 *bref = p; |
379 | while (bref < p+max) { | 379 | while (bref < p+max) { |
380 | if (unlikely(*bref >= maxblocks)) { | 380 | if (unlikely(le32_to_cpu(*bref) >= maxblocks)) { |
381 | ext4_error(inode->i_sb, function, | 381 | ext4_error(inode->i_sb, function, |
382 | "block reference %u >= max (%u) " | 382 | "block reference %u >= max (%u) " |
383 | "in inode #%lu, offset=%d", | 383 | "in inode #%lu, offset=%d", |
384 | *bref, maxblocks, | 384 | le32_to_cpu(*bref), maxblocks, |
385 | inode->i_ino, (int)(bref-p)); | 385 | inode->i_ino, (int)(bref-p)); |
386 | return -EIO; | 386 | return -EIO; |
387 | } | 387 | } |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9987bba99db3..2958f4e6f222 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -2508,6 +2508,15 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2508 | if (EXT4_BLOCKS_PER_GROUP(sb) == 0) | 2508 | if (EXT4_BLOCKS_PER_GROUP(sb) == 0) |
2509 | goto cantfind_ext4; | 2509 | goto cantfind_ext4; |
2510 | 2510 | ||
2511 | /* check blocks count against device size */ | ||
2512 | blocks_count = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits; | ||
2513 | if (blocks_count && ext4_blocks_count(es) > blocks_count) { | ||
2514 | printk(KERN_WARNING "EXT4-fs: bad geometry: block count %llu " | ||
2515 | "exceeds size of device (%llu blocks)\n", | ||
2516 | ext4_blocks_count(es), blocks_count); | ||
2517 | goto failed_mount; | ||
2518 | } | ||
2519 | |||
2511 | /* | 2520 | /* |
2512 | * It makes no sense for the first data block to be beyond the end | 2521 | * It makes no sense for the first data block to be beyond the end |
2513 | * of the filesystem. | 2522 | * of the filesystem. |