diff options
Diffstat (limited to 'fs')
207 files changed, 3848 insertions, 4443 deletions
diff --git a/fs/9p/v9fs_vfs.h b/fs/9p/v9fs_vfs.h index c295ba786edd..f0c7de78e205 100644 --- a/fs/9p/v9fs_vfs.h +++ b/fs/9p/v9fs_vfs.h | |||
@@ -41,8 +41,8 @@ extern struct file_system_type v9fs_fs_type; | |||
41 | extern const struct address_space_operations v9fs_addr_operations; | 41 | extern const struct address_space_operations v9fs_addr_operations; |
42 | extern const struct file_operations v9fs_file_operations; | 42 | extern const struct file_operations v9fs_file_operations; |
43 | extern const struct file_operations v9fs_dir_operations; | 43 | extern const struct file_operations v9fs_dir_operations; |
44 | extern struct dentry_operations v9fs_dentry_operations; | 44 | extern const struct dentry_operations v9fs_dentry_operations; |
45 | extern struct dentry_operations v9fs_cached_dentry_operations; | 45 | extern const struct dentry_operations v9fs_cached_dentry_operations; |
46 | 46 | ||
47 | struct inode *v9fs_get_inode(struct super_block *sb, int mode); | 47 | struct inode *v9fs_get_inode(struct super_block *sb, int mode); |
48 | ino_t v9fs_qid2ino(struct p9_qid *qid); | 48 | ino_t v9fs_qid2ino(struct p9_qid *qid); |
diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c index 06dcc7c4f234..d74325295b1e 100644 --- a/fs/9p/vfs_dentry.c +++ b/fs/9p/vfs_dentry.c | |||
@@ -104,12 +104,12 @@ void v9fs_dentry_release(struct dentry *dentry) | |||
104 | } | 104 | } |
105 | } | 105 | } |
106 | 106 | ||
107 | struct dentry_operations v9fs_cached_dentry_operations = { | 107 | const struct dentry_operations v9fs_cached_dentry_operations = { |
108 | .d_delete = v9fs_cached_dentry_delete, | 108 | .d_delete = v9fs_cached_dentry_delete, |
109 | .d_release = v9fs_dentry_release, | 109 | .d_release = v9fs_dentry_release, |
110 | }; | 110 | }; |
111 | 111 | ||
112 | struct dentry_operations v9fs_dentry_operations = { | 112 | const struct dentry_operations v9fs_dentry_operations = { |
113 | .d_delete = v9fs_dentry_delete, | 113 | .d_delete = v9fs_dentry_delete, |
114 | .d_release = v9fs_dentry_release, | 114 | .d_release = v9fs_dentry_release, |
115 | }; | 115 | }; |
diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c index 93212e40221a..5f8ab8adb5f5 100644 --- a/fs/9p/vfs_super.c +++ b/fs/9p/vfs_super.c | |||
@@ -168,8 +168,9 @@ static int v9fs_get_sb(struct file_system_type *fs_type, int flags, | |||
168 | p9stat_free(st); | 168 | p9stat_free(st); |
169 | kfree(st); | 169 | kfree(st); |
170 | 170 | ||
171 | P9_DPRINTK(P9_DEBUG_VFS, " return simple set mount\n"); | 171 | P9_DPRINTK(P9_DEBUG_VFS, " simple set mount, return 0\n"); |
172 | return simple_set_mnt(mnt, sb); | 172 | simple_set_mnt(mnt, sb); |
173 | return 0; | ||
173 | 174 | ||
174 | release_sb: | 175 | release_sb: |
175 | if (sb) { | 176 | if (sb) { |
diff --git a/fs/Kconfig b/fs/Kconfig index 93945dd0b1ae..cef8b18ceaa3 100644 --- a/fs/Kconfig +++ b/fs/Kconfig | |||
@@ -56,61 +56,7 @@ endif # BLOCK | |||
56 | 56 | ||
57 | source "fs/notify/Kconfig" | 57 | source "fs/notify/Kconfig" |
58 | 58 | ||
59 | config QUOTA | 59 | source "fs/quota/Kconfig" |
60 | bool "Quota support" | ||
61 | help | ||
62 | If you say Y here, you will be able to set per user limits for disk | ||
63 | usage (also called disk quotas). Currently, it works for the | ||
64 | ext2, ext3, and reiserfs file system. ext3 also supports journalled | ||
65 | quotas for which you don't need to run quotacheck(8) after an unclean | ||
66 | shutdown. | ||
67 | For further details, read the Quota mini-HOWTO, available from | ||
68 | <http://www.tldp.org/docs.html#howto>, or the documentation provided | ||
69 | with the quota tools. Probably the quota support is only useful for | ||
70 | multi user systems. If unsure, say N. | ||
71 | |||
72 | config QUOTA_NETLINK_INTERFACE | ||
73 | bool "Report quota messages through netlink interface" | ||
74 | depends on QUOTA && NET | ||
75 | help | ||
76 | If you say Y here, quota warnings (about exceeding softlimit, reaching | ||
77 | hardlimit, etc.) will be reported through netlink interface. If unsure, | ||
78 | say Y. | ||
79 | |||
80 | config PRINT_QUOTA_WARNING | ||
81 | bool "Print quota warnings to console (OBSOLETE)" | ||
82 | depends on QUOTA | ||
83 | default y | ||
84 | help | ||
85 | If you say Y here, quota warnings (about exceeding softlimit, reaching | ||
86 | hardlimit, etc.) will be printed to the process' controlling terminal. | ||
87 | Note that this behavior is currently deprecated and may go away in | ||
88 | future. Please use notification via netlink socket instead. | ||
89 | |||
90 | # Generic support for tree structured quota files. Seleted when needed. | ||
91 | config QUOTA_TREE | ||
92 | tristate | ||
93 | |||
94 | config QFMT_V1 | ||
95 | tristate "Old quota format support" | ||
96 | depends on QUOTA | ||
97 | help | ||
98 | This quota format was (is) used by kernels earlier than 2.4.22. If | ||
99 | you have quota working and you don't want to convert to new quota | ||
100 | format say Y here. | ||
101 | |||
102 | config QFMT_V2 | ||
103 | tristate "Quota format v2 support" | ||
104 | depends on QUOTA | ||
105 | select QUOTA_TREE | ||
106 | help | ||
107 | This quota format allows using quotas with 32-bit UIDs/GIDs. If you | ||
108 | need this functionality say Y here. | ||
109 | |||
110 | config QUOTACTL | ||
111 | bool | ||
112 | depends on XFS_QUOTA || QUOTA | ||
113 | default y | ||
114 | 60 | ||
115 | source "fs/autofs/Kconfig" | 61 | source "fs/autofs/Kconfig" |
116 | source "fs/autofs4/Kconfig" | 62 | source "fs/autofs4/Kconfig" |
diff --git a/fs/Makefile b/fs/Makefile index dc20db348679..6e82a307bcd4 100644 --- a/fs/Makefile +++ b/fs/Makefile | |||
@@ -51,11 +51,7 @@ obj-$(CONFIG_FS_POSIX_ACL) += posix_acl.o xattr_acl.o | |||
51 | obj-$(CONFIG_NFS_COMMON) += nfs_common/ | 51 | obj-$(CONFIG_NFS_COMMON) += nfs_common/ |
52 | obj-$(CONFIG_GENERIC_ACL) += generic_acl.o | 52 | obj-$(CONFIG_GENERIC_ACL) += generic_acl.o |
53 | 53 | ||
54 | obj-$(CONFIG_QUOTA) += dquot.o | 54 | obj-y += quota/ |
55 | obj-$(CONFIG_QFMT_V1) += quota_v1.o | ||
56 | obj-$(CONFIG_QFMT_V2) += quota_v2.o | ||
57 | obj-$(CONFIG_QUOTA_TREE) += quota_tree.o | ||
58 | obj-$(CONFIG_QUOTACTL) += quota.o | ||
59 | 55 | ||
60 | obj-$(CONFIG_PROC_FS) += proc/ | 56 | obj-$(CONFIG_PROC_FS) += proc/ |
61 | obj-y += partitions/ | 57 | obj-y += partitions/ |
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h index 831157502d5a..e0a85dbeeb88 100644 --- a/fs/adfs/adfs.h +++ b/fs/adfs/adfs.h | |||
@@ -86,7 +86,7 @@ void __adfs_error(struct super_block *sb, const char *function, | |||
86 | /* dir_*.c */ | 86 | /* dir_*.c */ |
87 | extern const struct inode_operations adfs_dir_inode_operations; | 87 | extern const struct inode_operations adfs_dir_inode_operations; |
88 | extern const struct file_operations adfs_dir_operations; | 88 | extern const struct file_operations adfs_dir_operations; |
89 | extern struct dentry_operations adfs_dentry_operations; | 89 | extern const struct dentry_operations adfs_dentry_operations; |
90 | extern struct adfs_dir_ops adfs_f_dir_ops; | 90 | extern struct adfs_dir_ops adfs_f_dir_ops; |
91 | extern struct adfs_dir_ops adfs_fplus_dir_ops; | 91 | extern struct adfs_dir_ops adfs_fplus_dir_ops; |
92 | 92 | ||
diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index 85a30e929800..e867ccf37246 100644 --- a/fs/adfs/dir.c +++ b/fs/adfs/dir.c | |||
@@ -263,7 +263,7 @@ adfs_compare(struct dentry *parent, struct qstr *entry, struct qstr *name) | |||
263 | return 0; | 263 | return 0; |
264 | } | 264 | } |
265 | 265 | ||
266 | struct dentry_operations adfs_dentry_operations = { | 266 | const struct dentry_operations adfs_dentry_operations = { |
267 | .d_hash = adfs_hash, | 267 | .d_hash = adfs_hash, |
268 | .d_compare = adfs_compare, | 268 | .d_compare = adfs_compare, |
269 | }; | 269 | }; |
diff --git a/fs/affs/affs.h b/fs/affs/affs.h index e9ec915f7553..1a2d5e3c7f4e 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h | |||
@@ -199,8 +199,7 @@ extern const struct address_space_operations affs_symlink_aops; | |||
199 | extern const struct address_space_operations affs_aops; | 199 | extern const struct address_space_operations affs_aops; |
200 | extern const struct address_space_operations affs_aops_ofs; | 200 | extern const struct address_space_operations affs_aops_ofs; |
201 | 201 | ||
202 | extern struct dentry_operations affs_dentry_operations; | 202 | extern const struct dentry_operations affs_dentry_operations; |
203 | extern struct dentry_operations affs_dentry_operations_intl; | ||
204 | 203 | ||
205 | static inline void | 204 | static inline void |
206 | affs_set_blocksize(struct super_block *sb, int size) | 205 | affs_set_blocksize(struct super_block *sb, int size) |
diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 805573005de6..7d0f0a30f7a3 100644 --- a/fs/affs/amigaffs.c +++ b/fs/affs/amigaffs.c | |||
@@ -179,14 +179,18 @@ affs_remove_link(struct dentry *dentry) | |||
179 | affs_lock_dir(dir); | 179 | affs_lock_dir(dir); |
180 | affs_fix_dcache(dentry, link_ino); | 180 | affs_fix_dcache(dentry, link_ino); |
181 | retval = affs_remove_hash(dir, link_bh); | 181 | retval = affs_remove_hash(dir, link_bh); |
182 | if (retval) | 182 | if (retval) { |
183 | affs_unlock_dir(dir); | ||
183 | goto done; | 184 | goto done; |
185 | } | ||
184 | mark_buffer_dirty_inode(link_bh, inode); | 186 | mark_buffer_dirty_inode(link_bh, inode); |
185 | 187 | ||
186 | memcpy(AFFS_TAIL(sb, bh)->name, AFFS_TAIL(sb, link_bh)->name, 32); | 188 | memcpy(AFFS_TAIL(sb, bh)->name, AFFS_TAIL(sb, link_bh)->name, 32); |
187 | retval = affs_insert_hash(dir, bh); | 189 | retval = affs_insert_hash(dir, bh); |
188 | if (retval) | 190 | if (retval) { |
191 | affs_unlock_dir(dir); | ||
189 | goto done; | 192 | goto done; |
193 | } | ||
190 | mark_buffer_dirty_inode(bh, inode); | 194 | mark_buffer_dirty_inode(bh, inode); |
191 | 195 | ||
192 | affs_unlock_dir(dir); | 196 | affs_unlock_dir(dir); |
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index cfcf1b6cf82b..960d336ec694 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c | |||
@@ -19,12 +19,12 @@ static int affs_intl_toupper(int ch); | |||
19 | static int affs_intl_hash_dentry(struct dentry *, struct qstr *); | 19 | static int affs_intl_hash_dentry(struct dentry *, struct qstr *); |
20 | static int affs_intl_compare_dentry(struct dentry *, struct qstr *, struct qstr *); | 20 | static int affs_intl_compare_dentry(struct dentry *, struct qstr *, struct qstr *); |
21 | 21 | ||
22 | struct dentry_operations affs_dentry_operations = { | 22 | const struct dentry_operations affs_dentry_operations = { |
23 | .d_hash = affs_hash_dentry, | 23 | .d_hash = affs_hash_dentry, |
24 | .d_compare = affs_compare_dentry, | 24 | .d_compare = affs_compare_dentry, |
25 | }; | 25 | }; |
26 | 26 | ||
27 | static struct dentry_operations affs_intl_dentry_operations = { | 27 | static const struct dentry_operations affs_intl_dentry_operations = { |
28 | .d_hash = affs_intl_hash_dentry, | 28 | .d_hash = affs_intl_hash_dentry, |
29 | .d_compare = affs_intl_compare_dentry, | 29 | .d_compare = affs_intl_compare_dentry, |
30 | }; | 30 | }; |
diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 99cf390641f7..9bd757774c9e 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c | |||
@@ -62,7 +62,7 @@ const struct inode_operations afs_dir_inode_operations = { | |||
62 | .setattr = afs_setattr, | 62 | .setattr = afs_setattr, |
63 | }; | 63 | }; |
64 | 64 | ||
65 | static struct dentry_operations afs_fs_dentry_operations = { | 65 | static const struct dentry_operations afs_fs_dentry_operations = { |
66 | .d_revalidate = afs_d_revalidate, | 66 | .d_revalidate = afs_d_revalidate, |
67 | .d_delete = afs_d_delete, | 67 | .d_delete = afs_d_delete, |
68 | .d_release = afs_d_release, | 68 | .d_release = afs_d_release, |
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index 3bbdb9d02376..1dd96d4406c0 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c | |||
@@ -48,7 +48,7 @@ static struct file_system_type anon_inode_fs_type = { | |||
48 | .get_sb = anon_inodefs_get_sb, | 48 | .get_sb = anon_inodefs_get_sb, |
49 | .kill_sb = kill_anon_super, | 49 | .kill_sb = kill_anon_super, |
50 | }; | 50 | }; |
51 | static struct dentry_operations anon_inodefs_dentry_operations = { | 51 | static const struct dentry_operations anon_inodefs_dentry_operations = { |
52 | .d_delete = anon_inodefs_delete_dentry, | 52 | .d_delete = anon_inodefs_delete_dentry, |
53 | }; | 53 | }; |
54 | 54 | ||
@@ -173,7 +173,8 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
173 | if (!error) { | 173 | if (!error) { |
174 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || | 174 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || |
175 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) | 175 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) |
176 | error = DQUOT_TRANSFER(inode, attr) ? -EDQUOT : 0; | 176 | error = vfs_dq_transfer(inode, attr) ? |
177 | -EDQUOT : 0; | ||
177 | if (!error) | 178 | if (!error) |
178 | error = inode_setattr(inode, attr); | 179 | error = inode_setattr(inode, attr); |
179 | } | 180 | } |
diff --git a/fs/autofs/root.c b/fs/autofs/root.c index 8aacade56956..4a1401cea0a1 100644 --- a/fs/autofs/root.c +++ b/fs/autofs/root.c | |||
@@ -192,7 +192,7 @@ static int autofs_revalidate(struct dentry * dentry, struct nameidata *nd) | |||
192 | return 1; | 192 | return 1; |
193 | } | 193 | } |
194 | 194 | ||
195 | static struct dentry_operations autofs_dentry_operations = { | 195 | static const struct dentry_operations autofs_dentry_operations = { |
196 | .d_revalidate = autofs_revalidate, | 196 | .d_revalidate = autofs_revalidate, |
197 | }; | 197 | }; |
198 | 198 | ||
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index 716e12b627b2..69c8142da838 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c | |||
@@ -310,7 +310,7 @@ static struct autofs_info *autofs4_mkroot(struct autofs_sb_info *sbi) | |||
310 | return ino; | 310 | return ino; |
311 | } | 311 | } |
312 | 312 | ||
313 | static struct dentry_operations autofs4_sb_dentry_operations = { | 313 | static const struct dentry_operations autofs4_sb_dentry_operations = { |
314 | .d_release = autofs4_dentry_release, | 314 | .d_release = autofs4_dentry_release, |
315 | }; | 315 | }; |
316 | 316 | ||
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 2a41c2a7fc52..74b1469a9504 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c | |||
@@ -349,13 +349,13 @@ void autofs4_dentry_release(struct dentry *de) | |||
349 | } | 349 | } |
350 | 350 | ||
351 | /* For dentries of directories in the root dir */ | 351 | /* For dentries of directories in the root dir */ |
352 | static struct dentry_operations autofs4_root_dentry_operations = { | 352 | static const struct dentry_operations autofs4_root_dentry_operations = { |
353 | .d_revalidate = autofs4_revalidate, | 353 | .d_revalidate = autofs4_revalidate, |
354 | .d_release = autofs4_dentry_release, | 354 | .d_release = autofs4_dentry_release, |
355 | }; | 355 | }; |
356 | 356 | ||
357 | /* For other dentries */ | 357 | /* For other dentries */ |
358 | static struct dentry_operations autofs4_dentry_operations = { | 358 | static const struct dentry_operations autofs4_dentry_operations = { |
359 | .d_revalidate = autofs4_revalidate, | 359 | .d_revalidate = autofs4_revalidate, |
360 | .d_release = autofs4_dentry_release, | 360 | .d_release = autofs4_dentry_release, |
361 | }; | 361 | }; |
diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c index fe2b1aa2464e..31c46a241bac 100644 --- a/fs/bio-integrity.c +++ b/fs/bio-integrity.c | |||
@@ -26,23 +26,23 @@ | |||
26 | #include <linux/workqueue.h> | 26 | #include <linux/workqueue.h> |
27 | 27 | ||
28 | static struct kmem_cache *bio_integrity_slab __read_mostly; | 28 | static struct kmem_cache *bio_integrity_slab __read_mostly; |
29 | static mempool_t *bio_integrity_pool; | ||
30 | static struct bio_set *integrity_bio_set; | ||
29 | static struct workqueue_struct *kintegrityd_wq; | 31 | static struct workqueue_struct *kintegrityd_wq; |
30 | 32 | ||
31 | /** | 33 | /** |
32 | * bio_integrity_alloc_bioset - Allocate integrity payload and attach it to bio | 34 | * bio_integrity_alloc - Allocate integrity payload and attach it to bio |
33 | * @bio: bio to attach integrity metadata to | 35 | * @bio: bio to attach integrity metadata to |
34 | * @gfp_mask: Memory allocation mask | 36 | * @gfp_mask: Memory allocation mask |
35 | * @nr_vecs: Number of integrity metadata scatter-gather elements | 37 | * @nr_vecs: Number of integrity metadata scatter-gather elements |
36 | * @bs: bio_set to allocate from | ||
37 | * | 38 | * |
38 | * Description: This function prepares a bio for attaching integrity | 39 | * Description: This function prepares a bio for attaching integrity |
39 | * metadata. nr_vecs specifies the maximum number of pages containing | 40 | * metadata. nr_vecs specifies the maximum number of pages containing |
40 | * integrity metadata that can be attached. | 41 | * integrity metadata that can be attached. |
41 | */ | 42 | */ |
42 | struct bio_integrity_payload *bio_integrity_alloc_bioset(struct bio *bio, | 43 | struct bio_integrity_payload *bio_integrity_alloc(struct bio *bio, |
43 | gfp_t gfp_mask, | 44 | gfp_t gfp_mask, |
44 | unsigned int nr_vecs, | 45 | unsigned int nr_vecs) |
45 | struct bio_set *bs) | ||
46 | { | 46 | { |
47 | struct bio_integrity_payload *bip; | 47 | struct bio_integrity_payload *bip; |
48 | struct bio_vec *iv; | 48 | struct bio_vec *iv; |
@@ -50,7 +50,7 @@ struct bio_integrity_payload *bio_integrity_alloc_bioset(struct bio *bio, | |||
50 | 50 | ||
51 | BUG_ON(bio == NULL); | 51 | BUG_ON(bio == NULL); |
52 | 52 | ||
53 | bip = mempool_alloc(bs->bio_integrity_pool, gfp_mask); | 53 | bip = mempool_alloc(bio_integrity_pool, gfp_mask); |
54 | if (unlikely(bip == NULL)) { | 54 | if (unlikely(bip == NULL)) { |
55 | printk(KERN_ERR "%s: could not alloc bip\n", __func__); | 55 | printk(KERN_ERR "%s: could not alloc bip\n", __func__); |
56 | return NULL; | 56 | return NULL; |
@@ -58,10 +58,10 @@ struct bio_integrity_payload *bio_integrity_alloc_bioset(struct bio *bio, | |||
58 | 58 | ||
59 | memset(bip, 0, sizeof(*bip)); | 59 | memset(bip, 0, sizeof(*bip)); |
60 | 60 | ||
61 | iv = bvec_alloc_bs(gfp_mask, nr_vecs, &idx, bs); | 61 | iv = bvec_alloc_bs(gfp_mask, nr_vecs, &idx, integrity_bio_set); |
62 | if (unlikely(iv == NULL)) { | 62 | if (unlikely(iv == NULL)) { |
63 | printk(KERN_ERR "%s: could not alloc bip_vec\n", __func__); | 63 | printk(KERN_ERR "%s: could not alloc bip_vec\n", __func__); |
64 | mempool_free(bip, bs->bio_integrity_pool); | 64 | mempool_free(bip, bio_integrity_pool); |
65 | return NULL; | 65 | return NULL; |
66 | } | 66 | } |
67 | 67 | ||
@@ -72,35 +72,16 @@ struct bio_integrity_payload *bio_integrity_alloc_bioset(struct bio *bio, | |||
72 | 72 | ||
73 | return bip; | 73 | return bip; |
74 | } | 74 | } |
75 | EXPORT_SYMBOL(bio_integrity_alloc_bioset); | ||
76 | |||
77 | /** | ||
78 | * bio_integrity_alloc - Allocate integrity payload and attach it to bio | ||
79 | * @bio: bio to attach integrity metadata to | ||
80 | * @gfp_mask: Memory allocation mask | ||
81 | * @nr_vecs: Number of integrity metadata scatter-gather elements | ||
82 | * | ||
83 | * Description: This function prepares a bio for attaching integrity | ||
84 | * metadata. nr_vecs specifies the maximum number of pages containing | ||
85 | * integrity metadata that can be attached. | ||
86 | */ | ||
87 | struct bio_integrity_payload *bio_integrity_alloc(struct bio *bio, | ||
88 | gfp_t gfp_mask, | ||
89 | unsigned int nr_vecs) | ||
90 | { | ||
91 | return bio_integrity_alloc_bioset(bio, gfp_mask, nr_vecs, fs_bio_set); | ||
92 | } | ||
93 | EXPORT_SYMBOL(bio_integrity_alloc); | 75 | EXPORT_SYMBOL(bio_integrity_alloc); |
94 | 76 | ||
95 | /** | 77 | /** |
96 | * bio_integrity_free - Free bio integrity payload | 78 | * bio_integrity_free - Free bio integrity payload |
97 | * @bio: bio containing bip to be freed | 79 | * @bio: bio containing bip to be freed |
98 | * @bs: bio_set this bio was allocated from | ||
99 | * | 80 | * |
100 | * Description: Used to free the integrity portion of a bio. Usually | 81 | * Description: Used to free the integrity portion of a bio. Usually |
101 | * called from bio_free(). | 82 | * called from bio_free(). |
102 | */ | 83 | */ |
103 | void bio_integrity_free(struct bio *bio, struct bio_set *bs) | 84 | void bio_integrity_free(struct bio *bio) |
104 | { | 85 | { |
105 | struct bio_integrity_payload *bip = bio->bi_integrity; | 86 | struct bio_integrity_payload *bip = bio->bi_integrity; |
106 | 87 | ||
@@ -111,8 +92,8 @@ void bio_integrity_free(struct bio *bio, struct bio_set *bs) | |||
111 | && bip->bip_buf != NULL) | 92 | && bip->bip_buf != NULL) |
112 | kfree(bip->bip_buf); | 93 | kfree(bip->bip_buf); |
113 | 94 | ||
114 | bvec_free_bs(bs, bip->bip_vec, bip->bip_pool); | 95 | bvec_free_bs(integrity_bio_set, bip->bip_vec, bip->bip_pool); |
115 | mempool_free(bip, bs->bio_integrity_pool); | 96 | mempool_free(bip, bio_integrity_pool); |
116 | 97 | ||
117 | bio->bi_integrity = NULL; | 98 | bio->bi_integrity = NULL; |
118 | } | 99 | } |
@@ -686,19 +667,17 @@ EXPORT_SYMBOL(bio_integrity_split); | |||
686 | * @bio: New bio | 667 | * @bio: New bio |
687 | * @bio_src: Original bio | 668 | * @bio_src: Original bio |
688 | * @gfp_mask: Memory allocation mask | 669 | * @gfp_mask: Memory allocation mask |
689 | * @bs: bio_set to allocate bip from | ||
690 | * | 670 | * |
691 | * Description: Called to allocate a bip when cloning a bio | 671 | * Description: Called to allocate a bip when cloning a bio |
692 | */ | 672 | */ |
693 | int bio_integrity_clone(struct bio *bio, struct bio *bio_src, | 673 | int bio_integrity_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp_mask) |
694 | gfp_t gfp_mask, struct bio_set *bs) | ||
695 | { | 674 | { |
696 | struct bio_integrity_payload *bip_src = bio_src->bi_integrity; | 675 | struct bio_integrity_payload *bip_src = bio_src->bi_integrity; |
697 | struct bio_integrity_payload *bip; | 676 | struct bio_integrity_payload *bip; |
698 | 677 | ||
699 | BUG_ON(bip_src == NULL); | 678 | BUG_ON(bip_src == NULL); |
700 | 679 | ||
701 | bip = bio_integrity_alloc_bioset(bio, gfp_mask, bip_src->bip_vcnt, bs); | 680 | bip = bio_integrity_alloc(bio, gfp_mask, bip_src->bip_vcnt); |
702 | 681 | ||
703 | if (bip == NULL) | 682 | if (bip == NULL) |
704 | return -EIO; | 683 | return -EIO; |
@@ -714,37 +693,25 @@ int bio_integrity_clone(struct bio *bio, struct bio *bio_src, | |||
714 | } | 693 | } |
715 | EXPORT_SYMBOL(bio_integrity_clone); | 694 | EXPORT_SYMBOL(bio_integrity_clone); |
716 | 695 | ||
717 | int bioset_integrity_create(struct bio_set *bs, int pool_size) | 696 | static int __init bio_integrity_init(void) |
718 | { | 697 | { |
719 | bs->bio_integrity_pool = mempool_create_slab_pool(pool_size, | 698 | kintegrityd_wq = create_workqueue("kintegrityd"); |
720 | bio_integrity_slab); | ||
721 | if (!bs->bio_integrity_pool) | ||
722 | return -1; | ||
723 | |||
724 | return 0; | ||
725 | } | ||
726 | EXPORT_SYMBOL(bioset_integrity_create); | ||
727 | 699 | ||
728 | void bioset_integrity_free(struct bio_set *bs) | 700 | if (!kintegrityd_wq) |
729 | { | 701 | panic("Failed to create kintegrityd\n"); |
730 | if (bs->bio_integrity_pool) | ||
731 | mempool_destroy(bs->bio_integrity_pool); | ||
732 | } | ||
733 | EXPORT_SYMBOL(bioset_integrity_free); | ||
734 | 702 | ||
735 | void __init bio_integrity_init_slab(void) | ||
736 | { | ||
737 | bio_integrity_slab = KMEM_CACHE(bio_integrity_payload, | 703 | bio_integrity_slab = KMEM_CACHE(bio_integrity_payload, |
738 | SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 704 | SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
739 | } | ||
740 | 705 | ||
741 | static int __init integrity_init(void) | 706 | bio_integrity_pool = mempool_create_slab_pool(BIO_POOL_SIZE, |
742 | { | 707 | bio_integrity_slab); |
743 | kintegrityd_wq = create_workqueue("kintegrityd"); | 708 | if (!bio_integrity_pool) |
709 | panic("bio_integrity: can't allocate bip pool\n"); | ||
744 | 710 | ||
745 | if (!kintegrityd_wq) | 711 | integrity_bio_set = bioset_create(BIO_POOL_SIZE, 0); |
746 | panic("Failed to create kintegrityd\n"); | 712 | if (!integrity_bio_set) |
713 | panic("bio_integrity: can't allocate bio_set\n"); | ||
747 | 714 | ||
748 | return 0; | 715 | return 0; |
749 | } | 716 | } |
750 | subsys_initcall(integrity_init); | 717 | subsys_initcall(bio_integrity_init); |
@@ -248,7 +248,7 @@ void bio_free(struct bio *bio, struct bio_set *bs) | |||
248 | bvec_free_bs(bs, bio->bi_io_vec, BIO_POOL_IDX(bio)); | 248 | bvec_free_bs(bs, bio->bi_io_vec, BIO_POOL_IDX(bio)); |
249 | 249 | ||
250 | if (bio_integrity(bio)) | 250 | if (bio_integrity(bio)) |
251 | bio_integrity_free(bio, bs); | 251 | bio_integrity_free(bio); |
252 | 252 | ||
253 | /* | 253 | /* |
254 | * If we have front padding, adjust the bio pointer before freeing | 254 | * If we have front padding, adjust the bio pointer before freeing |
@@ -301,48 +301,51 @@ void bio_init(struct bio *bio) | |||
301 | **/ | 301 | **/ |
302 | struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs) | 302 | struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs) |
303 | { | 303 | { |
304 | struct bio_vec *bvl = NULL; | ||
304 | struct bio *bio = NULL; | 305 | struct bio *bio = NULL; |
305 | void *uninitialized_var(p); | 306 | unsigned long idx = 0; |
307 | void *p = NULL; | ||
306 | 308 | ||
307 | if (bs) { | 309 | if (bs) { |
308 | p = mempool_alloc(bs->bio_pool, gfp_mask); | 310 | p = mempool_alloc(bs->bio_pool, gfp_mask); |
309 | 311 | if (!p) | |
310 | if (p) | 312 | goto err; |
311 | bio = p + bs->front_pad; | 313 | bio = p + bs->front_pad; |
312 | } else | 314 | } else { |
313 | bio = kmalloc(sizeof(*bio), gfp_mask); | 315 | bio = kmalloc(sizeof(*bio), gfp_mask); |
316 | if (!bio) | ||
317 | goto err; | ||
318 | } | ||
314 | 319 | ||
315 | if (likely(bio)) { | 320 | bio_init(bio); |
316 | struct bio_vec *bvl = NULL; | 321 | |
317 | 322 | if (unlikely(!nr_iovecs)) | |
318 | bio_init(bio); | 323 | goto out_set; |
319 | if (likely(nr_iovecs)) { | 324 | |
320 | unsigned long uninitialized_var(idx); | 325 | if (nr_iovecs <= BIO_INLINE_VECS) { |
321 | 326 | bvl = bio->bi_inline_vecs; | |
322 | if (nr_iovecs <= BIO_INLINE_VECS) { | 327 | nr_iovecs = BIO_INLINE_VECS; |
323 | idx = 0; | 328 | } else { |
324 | bvl = bio->bi_inline_vecs; | 329 | bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, bs); |
325 | nr_iovecs = BIO_INLINE_VECS; | 330 | if (unlikely(!bvl)) |
326 | } else { | 331 | goto err_free; |
327 | bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, | 332 | |
328 | bs); | 333 | nr_iovecs = bvec_nr_vecs(idx); |
329 | nr_iovecs = bvec_nr_vecs(idx); | ||
330 | } | ||
331 | if (unlikely(!bvl)) { | ||
332 | if (bs) | ||
333 | mempool_free(p, bs->bio_pool); | ||
334 | else | ||
335 | kfree(bio); | ||
336 | bio = NULL; | ||
337 | goto out; | ||
338 | } | ||
339 | bio->bi_flags |= idx << BIO_POOL_OFFSET; | ||
340 | bio->bi_max_vecs = nr_iovecs; | ||
341 | } | ||
342 | bio->bi_io_vec = bvl; | ||
343 | } | 334 | } |
344 | out: | 335 | bio->bi_flags |= idx << BIO_POOL_OFFSET; |
336 | bio->bi_max_vecs = nr_iovecs; | ||
337 | out_set: | ||
338 | bio->bi_io_vec = bvl; | ||
339 | |||
345 | return bio; | 340 | return bio; |
341 | |||
342 | err_free: | ||
343 | if (bs) | ||
344 | mempool_free(p, bs->bio_pool); | ||
345 | else | ||
346 | kfree(bio); | ||
347 | err: | ||
348 | return NULL; | ||
346 | } | 349 | } |
347 | 350 | ||
348 | struct bio *bio_alloc(gfp_t gfp_mask, int nr_iovecs) | 351 | struct bio *bio_alloc(gfp_t gfp_mask, int nr_iovecs) |
@@ -463,7 +466,7 @@ struct bio *bio_clone(struct bio *bio, gfp_t gfp_mask) | |||
463 | if (bio_integrity(bio)) { | 466 | if (bio_integrity(bio)) { |
464 | int ret; | 467 | int ret; |
465 | 468 | ||
466 | ret = bio_integrity_clone(b, bio, gfp_mask, fs_bio_set); | 469 | ret = bio_integrity_clone(b, bio, gfp_mask); |
467 | 470 | ||
468 | if (ret < 0) { | 471 | if (ret < 0) { |
469 | bio_put(b); | 472 | bio_put(b); |
@@ -1526,7 +1529,6 @@ void bioset_free(struct bio_set *bs) | |||
1526 | if (bs->bio_pool) | 1529 | if (bs->bio_pool) |
1527 | mempool_destroy(bs->bio_pool); | 1530 | mempool_destroy(bs->bio_pool); |
1528 | 1531 | ||
1529 | bioset_integrity_free(bs); | ||
1530 | biovec_free_pools(bs); | 1532 | biovec_free_pools(bs); |
1531 | bio_put_slab(bs); | 1533 | bio_put_slab(bs); |
1532 | 1534 | ||
@@ -1567,9 +1569,6 @@ struct bio_set *bioset_create(unsigned int pool_size, unsigned int front_pad) | |||
1567 | if (!bs->bio_pool) | 1569 | if (!bs->bio_pool) |
1568 | goto bad; | 1570 | goto bad; |
1569 | 1571 | ||
1570 | if (bioset_integrity_create(bs, pool_size)) | ||
1571 | goto bad; | ||
1572 | |||
1573 | if (!biovec_create_pools(bs, pool_size)) | 1572 | if (!biovec_create_pools(bs, pool_size)) |
1574 | return bs; | 1573 | return bs; |
1575 | 1574 | ||
@@ -1586,6 +1585,13 @@ static void __init biovec_init_slabs(void) | |||
1586 | int size; | 1585 | int size; |
1587 | struct biovec_slab *bvs = bvec_slabs + i; | 1586 | struct biovec_slab *bvs = bvec_slabs + i; |
1588 | 1587 | ||
1588 | #ifndef CONFIG_BLK_DEV_INTEGRITY | ||
1589 | if (bvs->nr_vecs <= BIO_INLINE_VECS) { | ||
1590 | bvs->slab = NULL; | ||
1591 | continue; | ||
1592 | } | ||
1593 | #endif | ||
1594 | |||
1589 | size = bvs->nr_vecs * sizeof(struct bio_vec); | 1595 | size = bvs->nr_vecs * sizeof(struct bio_vec); |
1590 | bvs->slab = kmem_cache_create(bvs->name, size, 0, | 1596 | bvs->slab = kmem_cache_create(bvs->name, size, 0, |
1591 | SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); | 1597 | SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); |
@@ -1600,7 +1606,6 @@ static int __init init_bio(void) | |||
1600 | if (!bio_slabs) | 1606 | if (!bio_slabs) |
1601 | panic("bio: can't allocate bios\n"); | 1607 | panic("bio: can't allocate bios\n"); |
1602 | 1608 | ||
1603 | bio_integrity_init_slab(); | ||
1604 | biovec_init_slabs(); | 1609 | biovec_init_slabs(); |
1605 | 1610 | ||
1606 | fs_bio_set = bioset_create(BIO_POOL_SIZE, 0); | 1611 | fs_bio_set = bioset_create(BIO_POOL_SIZE, 0); |
diff --git a/fs/block_dev.c b/fs/block_dev.c index b3c1efff5e1d..8c3c6899ccf3 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <linux/module.h> | 18 | #include <linux/module.h> |
19 | #include <linux/blkpg.h> | 19 | #include <linux/blkpg.h> |
20 | #include <linux/buffer_head.h> | 20 | #include <linux/buffer_head.h> |
21 | #include <linux/pagevec.h> | ||
21 | #include <linux/writeback.h> | 22 | #include <linux/writeback.h> |
22 | #include <linux/mpage.h> | 23 | #include <linux/mpage.h> |
23 | #include <linux/mount.h> | 24 | #include <linux/mount.h> |
@@ -174,6 +175,151 @@ blkdev_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, | |||
174 | iov, offset, nr_segs, blkdev_get_blocks, NULL); | 175 | iov, offset, nr_segs, blkdev_get_blocks, NULL); |
175 | } | 176 | } |
176 | 177 | ||
178 | /* | ||
179 | * Write out and wait upon all the dirty data associated with a block | ||
180 | * device via its mapping. Does not take the superblock lock. | ||
181 | */ | ||
182 | int sync_blockdev(struct block_device *bdev) | ||
183 | { | ||
184 | int ret = 0; | ||
185 | |||
186 | if (bdev) | ||
187 | ret = filemap_write_and_wait(bdev->bd_inode->i_mapping); | ||
188 | return ret; | ||
189 | } | ||
190 | EXPORT_SYMBOL(sync_blockdev); | ||
191 | |||
192 | /* | ||
193 | * Write out and wait upon all dirty data associated with this | ||
194 | * device. Filesystem data as well as the underlying block | ||
195 | * device. Takes the superblock lock. | ||
196 | */ | ||
197 | int fsync_bdev(struct block_device *bdev) | ||
198 | { | ||
199 | struct super_block *sb = get_super(bdev); | ||
200 | if (sb) { | ||
201 | int res = fsync_super(sb); | ||
202 | drop_super(sb); | ||
203 | return res; | ||
204 | } | ||
205 | return sync_blockdev(bdev); | ||
206 | } | ||
207 | |||
208 | /** | ||
209 | * freeze_bdev -- lock a filesystem and force it into a consistent state | ||
210 | * @bdev: blockdevice to lock | ||
211 | * | ||
212 | * This takes the block device bd_mount_sem to make sure no new mounts | ||
213 | * happen on bdev until thaw_bdev() is called. | ||
214 | * If a superblock is found on this device, we take the s_umount semaphore | ||
215 | * on it to make sure nobody unmounts until the snapshot creation is done. | ||
216 | * The reference counter (bd_fsfreeze_count) guarantees that only the last | ||
217 | * unfreeze process can unfreeze the frozen filesystem actually when multiple | ||
218 | * freeze requests arrive simultaneously. It counts up in freeze_bdev() and | ||
219 | * count down in thaw_bdev(). When it becomes 0, thaw_bdev() will unfreeze | ||
220 | * actually. | ||
221 | */ | ||
222 | struct super_block *freeze_bdev(struct block_device *bdev) | ||
223 | { | ||
224 | struct super_block *sb; | ||
225 | int error = 0; | ||
226 | |||
227 | mutex_lock(&bdev->bd_fsfreeze_mutex); | ||
228 | if (bdev->bd_fsfreeze_count > 0) { | ||
229 | bdev->bd_fsfreeze_count++; | ||
230 | sb = get_super(bdev); | ||
231 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
232 | return sb; | ||
233 | } | ||
234 | bdev->bd_fsfreeze_count++; | ||
235 | |||
236 | down(&bdev->bd_mount_sem); | ||
237 | sb = get_super(bdev); | ||
238 | if (sb && !(sb->s_flags & MS_RDONLY)) { | ||
239 | sb->s_frozen = SB_FREEZE_WRITE; | ||
240 | smp_wmb(); | ||
241 | |||
242 | __fsync_super(sb); | ||
243 | |||
244 | sb->s_frozen = SB_FREEZE_TRANS; | ||
245 | smp_wmb(); | ||
246 | |||
247 | sync_blockdev(sb->s_bdev); | ||
248 | |||
249 | if (sb->s_op->freeze_fs) { | ||
250 | error = sb->s_op->freeze_fs(sb); | ||
251 | if (error) { | ||
252 | printk(KERN_ERR | ||
253 | "VFS:Filesystem freeze failed\n"); | ||
254 | sb->s_frozen = SB_UNFROZEN; | ||
255 | drop_super(sb); | ||
256 | up(&bdev->bd_mount_sem); | ||
257 | bdev->bd_fsfreeze_count--; | ||
258 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
259 | return ERR_PTR(error); | ||
260 | } | ||
261 | } | ||
262 | } | ||
263 | |||
264 | sync_blockdev(bdev); | ||
265 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
266 | |||
267 | return sb; /* thaw_bdev releases s->s_umount and bd_mount_sem */ | ||
268 | } | ||
269 | EXPORT_SYMBOL(freeze_bdev); | ||
270 | |||
271 | /** | ||
272 | * thaw_bdev -- unlock filesystem | ||
273 | * @bdev: blockdevice to unlock | ||
274 | * @sb: associated superblock | ||
275 | * | ||
276 | * Unlocks the filesystem and marks it writeable again after freeze_bdev(). | ||
277 | */ | ||
278 | int thaw_bdev(struct block_device *bdev, struct super_block *sb) | ||
279 | { | ||
280 | int error = 0; | ||
281 | |||
282 | mutex_lock(&bdev->bd_fsfreeze_mutex); | ||
283 | if (!bdev->bd_fsfreeze_count) { | ||
284 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
285 | return -EINVAL; | ||
286 | } | ||
287 | |||
288 | bdev->bd_fsfreeze_count--; | ||
289 | if (bdev->bd_fsfreeze_count > 0) { | ||
290 | if (sb) | ||
291 | drop_super(sb); | ||
292 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
293 | return 0; | ||
294 | } | ||
295 | |||
296 | if (sb) { | ||
297 | BUG_ON(sb->s_bdev != bdev); | ||
298 | if (!(sb->s_flags & MS_RDONLY)) { | ||
299 | if (sb->s_op->unfreeze_fs) { | ||
300 | error = sb->s_op->unfreeze_fs(sb); | ||
301 | if (error) { | ||
302 | printk(KERN_ERR | ||
303 | "VFS:Filesystem thaw failed\n"); | ||
304 | sb->s_frozen = SB_FREEZE_TRANS; | ||
305 | bdev->bd_fsfreeze_count++; | ||
306 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
307 | return error; | ||
308 | } | ||
309 | } | ||
310 | sb->s_frozen = SB_UNFROZEN; | ||
311 | smp_wmb(); | ||
312 | wake_up(&sb->s_wait_unfrozen); | ||
313 | } | ||
314 | drop_super(sb); | ||
315 | } | ||
316 | |||
317 | up(&bdev->bd_mount_sem); | ||
318 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
319 | return 0; | ||
320 | } | ||
321 | EXPORT_SYMBOL(thaw_bdev); | ||
322 | |||
177 | static int blkdev_writepage(struct page *page, struct writeback_control *wbc) | 323 | static int blkdev_writepage(struct page *page, struct writeback_control *wbc) |
178 | { | 324 | { |
179 | return block_write_full_page(page, blkdev_get_block, wbc); | 325 | return block_write_full_page(page, blkdev_get_block, wbc); |
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 3e18175248e0..6ec80c0fc869 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -2385,7 +2385,7 @@ void btrfs_btree_balance_dirty(struct btrfs_root *root, unsigned long nr) | |||
2385 | unsigned long thresh = 32 * 1024 * 1024; | 2385 | unsigned long thresh = 32 * 1024 * 1024; |
2386 | tree = &BTRFS_I(root->fs_info->btree_inode)->io_tree; | 2386 | tree = &BTRFS_I(root->fs_info->btree_inode)->io_tree; |
2387 | 2387 | ||
2388 | if (current_is_pdflush() || current->flags & PF_MEMALLOC) | 2388 | if (current->flags & PF_MEMALLOC) |
2389 | return; | 2389 | return; |
2390 | 2390 | ||
2391 | num_dirty = count_range_bits(tree, &start, (u64)-1, | 2391 | num_dirty = count_range_bits(tree, &start, (u64)-1, |
diff --git a/fs/buffer.c b/fs/buffer.c index 891e1c78e4f1..a2fd743d97cb 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -166,151 +166,6 @@ void end_buffer_write_sync(struct buffer_head *bh, int uptodate) | |||
166 | } | 166 | } |
167 | 167 | ||
168 | /* | 168 | /* |
169 | * Write out and wait upon all the dirty data associated with a block | ||
170 | * device via its mapping. Does not take the superblock lock. | ||
171 | */ | ||
172 | int sync_blockdev(struct block_device *bdev) | ||
173 | { | ||
174 | int ret = 0; | ||
175 | |||
176 | if (bdev) | ||
177 | ret = filemap_write_and_wait(bdev->bd_inode->i_mapping); | ||
178 | return ret; | ||
179 | } | ||
180 | EXPORT_SYMBOL(sync_blockdev); | ||
181 | |||
182 | /* | ||
183 | * Write out and wait upon all dirty data associated with this | ||
184 | * device. Filesystem data as well as the underlying block | ||
185 | * device. Takes the superblock lock. | ||
186 | */ | ||
187 | int fsync_bdev(struct block_device *bdev) | ||
188 | { | ||
189 | struct super_block *sb = get_super(bdev); | ||
190 | if (sb) { | ||
191 | int res = fsync_super(sb); | ||
192 | drop_super(sb); | ||
193 | return res; | ||
194 | } | ||
195 | return sync_blockdev(bdev); | ||
196 | } | ||
197 | |||
198 | /** | ||
199 | * freeze_bdev -- lock a filesystem and force it into a consistent state | ||
200 | * @bdev: blockdevice to lock | ||
201 | * | ||
202 | * This takes the block device bd_mount_sem to make sure no new mounts | ||
203 | * happen on bdev until thaw_bdev() is called. | ||
204 | * If a superblock is found on this device, we take the s_umount semaphore | ||
205 | * on it to make sure nobody unmounts until the snapshot creation is done. | ||
206 | * The reference counter (bd_fsfreeze_count) guarantees that only the last | ||
207 | * unfreeze process can unfreeze the frozen filesystem actually when multiple | ||
208 | * freeze requests arrive simultaneously. It counts up in freeze_bdev() and | ||
209 | * count down in thaw_bdev(). When it becomes 0, thaw_bdev() will unfreeze | ||
210 | * actually. | ||
211 | */ | ||
212 | struct super_block *freeze_bdev(struct block_device *bdev) | ||
213 | { | ||
214 | struct super_block *sb; | ||
215 | int error = 0; | ||
216 | |||
217 | mutex_lock(&bdev->bd_fsfreeze_mutex); | ||
218 | if (bdev->bd_fsfreeze_count > 0) { | ||
219 | bdev->bd_fsfreeze_count++; | ||
220 | sb = get_super(bdev); | ||
221 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
222 | return sb; | ||
223 | } | ||
224 | bdev->bd_fsfreeze_count++; | ||
225 | |||
226 | down(&bdev->bd_mount_sem); | ||
227 | sb = get_super(bdev); | ||
228 | if (sb && !(sb->s_flags & MS_RDONLY)) { | ||
229 | sb->s_frozen = SB_FREEZE_WRITE; | ||
230 | smp_wmb(); | ||
231 | |||
232 | __fsync_super(sb); | ||
233 | |||
234 | sb->s_frozen = SB_FREEZE_TRANS; | ||
235 | smp_wmb(); | ||
236 | |||
237 | sync_blockdev(sb->s_bdev); | ||
238 | |||
239 | if (sb->s_op->freeze_fs) { | ||
240 | error = sb->s_op->freeze_fs(sb); | ||
241 | if (error) { | ||
242 | printk(KERN_ERR | ||
243 | "VFS:Filesystem freeze failed\n"); | ||
244 | sb->s_frozen = SB_UNFROZEN; | ||
245 | drop_super(sb); | ||
246 | up(&bdev->bd_mount_sem); | ||
247 | bdev->bd_fsfreeze_count--; | ||
248 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
249 | return ERR_PTR(error); | ||
250 | } | ||
251 | } | ||
252 | } | ||
253 | |||
254 | sync_blockdev(bdev); | ||
255 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
256 | |||
257 | return sb; /* thaw_bdev releases s->s_umount and bd_mount_sem */ | ||
258 | } | ||
259 | EXPORT_SYMBOL(freeze_bdev); | ||
260 | |||
261 | /** | ||
262 | * thaw_bdev -- unlock filesystem | ||
263 | * @bdev: blockdevice to unlock | ||
264 | * @sb: associated superblock | ||
265 | * | ||
266 | * Unlocks the filesystem and marks it writeable again after freeze_bdev(). | ||
267 | */ | ||
268 | int thaw_bdev(struct block_device *bdev, struct super_block *sb) | ||
269 | { | ||
270 | int error = 0; | ||
271 | |||
272 | mutex_lock(&bdev->bd_fsfreeze_mutex); | ||
273 | if (!bdev->bd_fsfreeze_count) { | ||
274 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
275 | return -EINVAL; | ||
276 | } | ||
277 | |||
278 | bdev->bd_fsfreeze_count--; | ||
279 | if (bdev->bd_fsfreeze_count > 0) { | ||
280 | if (sb) | ||
281 | drop_super(sb); | ||
282 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
283 | return 0; | ||
284 | } | ||
285 | |||
286 | if (sb) { | ||
287 | BUG_ON(sb->s_bdev != bdev); | ||
288 | if (!(sb->s_flags & MS_RDONLY)) { | ||
289 | if (sb->s_op->unfreeze_fs) { | ||
290 | error = sb->s_op->unfreeze_fs(sb); | ||
291 | if (error) { | ||
292 | printk(KERN_ERR | ||
293 | "VFS:Filesystem thaw failed\n"); | ||
294 | sb->s_frozen = SB_FREEZE_TRANS; | ||
295 | bdev->bd_fsfreeze_count++; | ||
296 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
297 | return error; | ||
298 | } | ||
299 | } | ||
300 | sb->s_frozen = SB_UNFROZEN; | ||
301 | smp_wmb(); | ||
302 | wake_up(&sb->s_wait_unfrozen); | ||
303 | } | ||
304 | drop_super(sb); | ||
305 | } | ||
306 | |||
307 | up(&bdev->bd_mount_sem); | ||
308 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
309 | return 0; | ||
310 | } | ||
311 | EXPORT_SYMBOL(thaw_bdev); | ||
312 | |||
313 | /* | ||
314 | * Various filesystems appear to want __find_get_block to be non-blocking. | 169 | * Various filesystems appear to want __find_get_block to be non-blocking. |
315 | * But it's the page lock which protects the buffers. To get around this, | 170 | * But it's the page lock which protects the buffers. To get around this, |
316 | * we get exclusion from try_to_free_buffers with the blockdev mapping's | 171 | * we get exclusion from try_to_free_buffers with the blockdev mapping's |
diff --git a/fs/cifs/CHANGES b/fs/cifs/CHANGES index 851388fafc73..65984006192c 100644 --- a/fs/cifs/CHANGES +++ b/fs/cifs/CHANGES | |||
@@ -6,7 +6,16 @@ the server to treat subsequent connections, especially those that | |||
6 | are authenticated as guest, as reconnections, invalidating the earlier | 6 | are authenticated as guest, as reconnections, invalidating the earlier |
7 | user's smb session. This fix allows cifs to mount multiple times to the | 7 | user's smb session. This fix allows cifs to mount multiple times to the |
8 | same server with different userids without risking invalidating earlier | 8 | same server with different userids without risking invalidating earlier |
9 | established security contexts. | 9 | established security contexts. fsync now sends SMB Flush operation |
10 | to better ensure that we wait for server to write all of the data to | ||
11 | server disk (not just write it over the network). Add new mount | ||
12 | parameter to allow user to disable sending the (slow) SMB flush on | ||
13 | fsync if desired (fsync still flushes all cached write data to the server). | ||
14 | Posix file open support added (turned off after one attempt if server | ||
15 | fails to support it properly, as with Samba server versions prior to 3.3.2) | ||
16 | Fix "redzone overwritten" bug in cifs_put_tcon (CIFSTcon may allocate too | ||
17 | little memory for the "nativeFileSystem" field returned by the server | ||
18 | during mount). | ||
10 | 19 | ||
11 | Version 1.56 | 20 | Version 1.56 |
12 | ------------ | 21 | ------------ |
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index 341a98965bd0..6994a0f54f02 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig | |||
@@ -118,6 +118,18 @@ config CIFS_DEBUG2 | |||
118 | option can be turned off unless you are debugging | 118 | option can be turned off unless you are debugging |
119 | cifs problems. If unsure, say N. | 119 | cifs problems. If unsure, say N. |
120 | 120 | ||
121 | config CIFS_DFS_UPCALL | ||
122 | bool "DFS feature support" | ||
123 | depends on CIFS && KEYS | ||
124 | help | ||
125 | Distributed File System (DFS) support is used to access shares | ||
126 | transparently in an enterprise name space, even if the share | ||
127 | moves to a different server. This feature also enables | ||
128 | an upcall mechanism for CIFS which contacts userspace helper | ||
129 | utilities to provide server name resolution (host names to | ||
130 | IP addresses) which is needed for implicit mounts of DFS junction | ||
131 | points. If unsure, say N. | ||
132 | |||
121 | config CIFS_EXPERIMENTAL | 133 | config CIFS_EXPERIMENTAL |
122 | bool "CIFS Experimental Features (EXPERIMENTAL)" | 134 | bool "CIFS Experimental Features (EXPERIMENTAL)" |
123 | depends on CIFS && EXPERIMENTAL | 135 | depends on CIFS && EXPERIMENTAL |
@@ -131,12 +143,3 @@ config CIFS_EXPERIMENTAL | |||
131 | (which is disabled by default). See the file fs/cifs/README | 143 | (which is disabled by default). See the file fs/cifs/README |
132 | for more details. If unsure, say N. | 144 | for more details. If unsure, say N. |
133 | 145 | ||
134 | config CIFS_DFS_UPCALL | ||
135 | bool "DFS feature support (EXPERIMENTAL)" | ||
136 | depends on CIFS_EXPERIMENTAL | ||
137 | depends on KEYS | ||
138 | help | ||
139 | Enables an upcall mechanism for CIFS which contacts userspace | ||
140 | helper utilities to provide server name resolution (host names to | ||
141 | IP addresses) which is needed for implicit mounts of DFS junction | ||
142 | points. If unsure, say N. | ||
diff --git a/fs/cifs/README b/fs/cifs/README index da4515e3be20..07434181623b 100644 --- a/fs/cifs/README +++ b/fs/cifs/README | |||
@@ -472,6 +472,19 @@ A partial list of the supported mount options follows: | |||
472 | even if the cifs server would support posix advisory locks. | 472 | even if the cifs server would support posix advisory locks. |
473 | "forcemand" is accepted as a shorter form of this mount | 473 | "forcemand" is accepted as a shorter form of this mount |
474 | option. | 474 | option. |
475 | nostrictsync If this mount option is set, when an application does an | ||
476 | fsync call then the cifs client does not send an SMB Flush | ||
477 | to the server (to force the server to write all dirty data | ||
478 | for this file immediately to disk), although cifs still sends | ||
479 | all dirty (cached) file data to the server and waits for the | ||
480 | server to respond to the write. Since SMB Flush can be | ||
481 | very slow, and some servers may be reliable enough (to risk | ||
482 | delaying slightly flushing the data to disk on the server), | ||
483 | turning on this option may be useful to improve performance for | ||
484 | applications that fsync too much, at a small risk of server | ||
485 | crash. If this mount option is not set, by default cifs will | ||
486 | send an SMB flush request (and wait for a response) on every | ||
487 | fsync call. | ||
475 | nodfs Disable DFS (global name space support) even if the | 488 | nodfs Disable DFS (global name space support) even if the |
476 | server claims to support it. This can help work around | 489 | server claims to support it. This can help work around |
477 | a problem with parsing of DFS paths with Samba server | 490 | a problem with parsing of DFS paths with Samba server |
@@ -692,13 +705,14 @@ require this helper. Note that NTLMv2 security (which does not require the | |||
692 | cifs.upcall helper program), instead of using Kerberos, is sufficient for | 705 | cifs.upcall helper program), instead of using Kerberos, is sufficient for |
693 | some use cases. | 706 | some use cases. |
694 | 707 | ||
695 | Enabling DFS support (used to access shares transparently in an MS-DFS | 708 | DFS support allows transparent redirection to shares in an MS-DFS name space. |
696 | global name space) requires that CONFIG_CIFS_EXPERIMENTAL be enabled. In | 709 | In addition, DFS support for target shares which are specified as UNC |
697 | addition, DFS support for target shares which are specified as UNC | ||
698 | names which begin with host names (rather than IP addresses) requires | 710 | names which begin with host names (rather than IP addresses) requires |
699 | a user space helper (such as cifs.upcall) to be present in order to | 711 | a user space helper (such as cifs.upcall) to be present in order to |
700 | translate host names to ip address, and the user space helper must also | 712 | translate host names to ip address, and the user space helper must also |
701 | be configured in the file /etc/request-key.conf | 713 | be configured in the file /etc/request-key.conf. Samba, Windows servers and |
714 | many NAS appliances support DFS as a way of constructing a global name | ||
715 | space to ease network configuration and improve reliability. | ||
702 | 716 | ||
703 | To use cifs Kerberos and DFS support, the Linux keyutils package should be | 717 | To use cifs Kerberos and DFS support, the Linux keyutils package should be |
704 | installed and something like the following lines should be added to the | 718 | installed and something like the following lines should be added to the |
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 490e34bbf27a..877e4d9a1159 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c | |||
@@ -340,6 +340,8 @@ static int cifs_stats_proc_show(struct seq_file *m, void *v) | |||
340 | seq_printf(m, "\nWrites: %d Bytes: %lld", | 340 | seq_printf(m, "\nWrites: %d Bytes: %lld", |
341 | atomic_read(&tcon->num_writes), | 341 | atomic_read(&tcon->num_writes), |
342 | (long long)(tcon->bytes_written)); | 342 | (long long)(tcon->bytes_written)); |
343 | seq_printf(m, "\nFlushes: %d", | ||
344 | atomic_read(&tcon->num_flushes)); | ||
343 | seq_printf(m, "\nLocks: %d HardLinks: %d " | 345 | seq_printf(m, "\nLocks: %d HardLinks: %d " |
344 | "Symlinks: %d", | 346 | "Symlinks: %d", |
345 | atomic_read(&tcon->num_locks), | 347 | atomic_read(&tcon->num_locks), |
diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c index 85c0a74d034d..5fdbf8a14472 100644 --- a/fs/cifs/cifs_dfs_ref.c +++ b/fs/cifs/cifs_dfs_ref.c | |||
@@ -104,9 +104,9 @@ static char *cifs_get_share_name(const char *node_name) | |||
104 | 104 | ||
105 | 105 | ||
106 | /** | 106 | /** |
107 | * compose_mount_options - creates mount options for refferral | 107 | * cifs_compose_mount_options - creates mount options for refferral |
108 | * @sb_mountdata: parent/root DFS mount options (template) | 108 | * @sb_mountdata: parent/root DFS mount options (template) |
109 | * @dentry: point where we are going to mount | 109 | * @fullpath: full path in UNC format |
110 | * @ref: server's referral | 110 | * @ref: server's referral |
111 | * @devname: pointer for saving device name | 111 | * @devname: pointer for saving device name |
112 | * | 112 | * |
@@ -116,8 +116,8 @@ static char *cifs_get_share_name(const char *node_name) | |||
116 | * Returns: pointer to new mount options or ERR_PTR. | 116 | * Returns: pointer to new mount options or ERR_PTR. |
117 | * Caller is responcible for freeing retunrned value if it is not error. | 117 | * Caller is responcible for freeing retunrned value if it is not error. |
118 | */ | 118 | */ |
119 | static char *compose_mount_options(const char *sb_mountdata, | 119 | char *cifs_compose_mount_options(const char *sb_mountdata, |
120 | struct dentry *dentry, | 120 | const char *fullpath, |
121 | const struct dfs_info3_param *ref, | 121 | const struct dfs_info3_param *ref, |
122 | char **devname) | 122 | char **devname) |
123 | { | 123 | { |
@@ -128,7 +128,6 @@ static char *compose_mount_options(const char *sb_mountdata, | |||
128 | char *srvIP = NULL; | 128 | char *srvIP = NULL; |
129 | char sep = ','; | 129 | char sep = ','; |
130 | int off, noff; | 130 | int off, noff; |
131 | char *fullpath; | ||
132 | 131 | ||
133 | if (sb_mountdata == NULL) | 132 | if (sb_mountdata == NULL) |
134 | return ERR_PTR(-EINVAL); | 133 | return ERR_PTR(-EINVAL); |
@@ -202,17 +201,6 @@ static char *compose_mount_options(const char *sb_mountdata, | |||
202 | goto compose_mount_options_err; | 201 | goto compose_mount_options_err; |
203 | } | 202 | } |
204 | 203 | ||
205 | /* | ||
206 | * this function gives us a path with a double backslash prefix. We | ||
207 | * require a single backslash for DFS. Temporarily increment fullpath | ||
208 | * to put it in the proper form and decrement before freeing it. | ||
209 | */ | ||
210 | fullpath = build_path_from_dentry(dentry); | ||
211 | if (!fullpath) { | ||
212 | rc = -ENOMEM; | ||
213 | goto compose_mount_options_err; | ||
214 | } | ||
215 | ++fullpath; | ||
216 | tkn_e = strchr(tkn_e + 1, '\\'); | 204 | tkn_e = strchr(tkn_e + 1, '\\'); |
217 | if (tkn_e || (strlen(fullpath) - ref->path_consumed)) { | 205 | if (tkn_e || (strlen(fullpath) - ref->path_consumed)) { |
218 | strncat(mountdata, &sep, 1); | 206 | strncat(mountdata, &sep, 1); |
@@ -221,8 +209,6 @@ static char *compose_mount_options(const char *sb_mountdata, | |||
221 | strcat(mountdata, tkn_e + 1); | 209 | strcat(mountdata, tkn_e + 1); |
222 | strcat(mountdata, fullpath + ref->path_consumed); | 210 | strcat(mountdata, fullpath + ref->path_consumed); |
223 | } | 211 | } |
224 | --fullpath; | ||
225 | kfree(fullpath); | ||
226 | 212 | ||
227 | /*cFYI(1,("%s: parent mountdata: %s", __func__,sb_mountdata));*/ | 213 | /*cFYI(1,("%s: parent mountdata: %s", __func__,sb_mountdata));*/ |
228 | /*cFYI(1, ("%s: submount mountdata: %s", __func__, mountdata ));*/ | 214 | /*cFYI(1, ("%s: submount mountdata: %s", __func__, mountdata ));*/ |
@@ -245,10 +231,20 @@ static struct vfsmount *cifs_dfs_do_refmount(const struct vfsmount *mnt_parent, | |||
245 | struct vfsmount *mnt; | 231 | struct vfsmount *mnt; |
246 | char *mountdata; | 232 | char *mountdata; |
247 | char *devname = NULL; | 233 | char *devname = NULL; |
234 | char *fullpath; | ||
248 | 235 | ||
249 | cifs_sb = CIFS_SB(dentry->d_inode->i_sb); | 236 | cifs_sb = CIFS_SB(dentry->d_inode->i_sb); |
250 | mountdata = compose_mount_options(cifs_sb->mountdata, | 237 | /* |
251 | dentry, ref, &devname); | 238 | * this function gives us a path with a double backslash prefix. We |
239 | * require a single backslash for DFS. | ||
240 | */ | ||
241 | fullpath = build_path_from_dentry(dentry); | ||
242 | if (!fullpath) | ||
243 | return ERR_PTR(-ENOMEM); | ||
244 | |||
245 | mountdata = cifs_compose_mount_options(cifs_sb->mountdata, | ||
246 | fullpath + 1, ref, &devname); | ||
247 | kfree(fullpath); | ||
252 | 248 | ||
253 | if (IS_ERR(mountdata)) | 249 | if (IS_ERR(mountdata)) |
254 | return (struct vfsmount *)mountdata; | 250 | return (struct vfsmount *)mountdata; |
diff --git a/fs/cifs/cifs_fs_sb.h b/fs/cifs/cifs_fs_sb.h index c4c306f7b06f..4797787c6a44 100644 --- a/fs/cifs/cifs_fs_sb.h +++ b/fs/cifs/cifs_fs_sb.h | |||
@@ -32,6 +32,7 @@ | |||
32 | #define CIFS_MOUNT_OVERR_GID 0x800 /* override gid returned from server */ | 32 | #define CIFS_MOUNT_OVERR_GID 0x800 /* override gid returned from server */ |
33 | #define CIFS_MOUNT_DYNPERM 0x1000 /* allow in-memory only mode setting */ | 33 | #define CIFS_MOUNT_DYNPERM 0x1000 /* allow in-memory only mode setting */ |
34 | #define CIFS_MOUNT_NOPOSIXBRL 0x2000 /* mandatory not posix byte range lock */ | 34 | #define CIFS_MOUNT_NOPOSIXBRL 0x2000 /* mandatory not posix byte range lock */ |
35 | #define CIFS_MOUNT_NOSSYNC 0x4000 /* don't do slow SMBflush on every sync*/ | ||
35 | 36 | ||
36 | struct cifs_sb_info { | 37 | struct cifs_sb_info { |
37 | struct cifsTconInfo *tcon; /* primary mount */ | 38 | struct cifsTconInfo *tcon; /* primary mount */ |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 13ea53251dcf..38491fd3871d 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c | |||
@@ -606,7 +606,8 @@ cifs_get_sb(struct file_system_type *fs_type, | |||
606 | return rc; | 606 | return rc; |
607 | } | 607 | } |
608 | sb->s_flags |= MS_ACTIVE; | 608 | sb->s_flags |= MS_ACTIVE; |
609 | return simple_set_mnt(mnt, sb); | 609 | simple_set_mnt(mnt, sb); |
610 | return 0; | ||
610 | } | 611 | } |
611 | 612 | ||
612 | static ssize_t cifs_file_aio_write(struct kiocb *iocb, const struct iovec *iov, | 613 | static ssize_t cifs_file_aio_write(struct kiocb *iocb, const struct iovec *iov, |
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 2b1d28a9ee28..77e190dc2883 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -78,8 +78,8 @@ extern int cifs_dir_open(struct inode *inode, struct file *file); | |||
78 | extern int cifs_readdir(struct file *file, void *direntry, filldir_t filldir); | 78 | extern int cifs_readdir(struct file *file, void *direntry, filldir_t filldir); |
79 | 79 | ||
80 | /* Functions related to dir entries */ | 80 | /* Functions related to dir entries */ |
81 | extern struct dentry_operations cifs_dentry_ops; | 81 | extern const struct dentry_operations cifs_dentry_ops; |
82 | extern struct dentry_operations cifs_ci_dentry_ops; | 82 | extern const struct dentry_operations cifs_ci_dentry_ops; |
83 | 83 | ||
84 | /* Functions related to symlinks */ | 84 | /* Functions related to symlinks */ |
85 | extern void *cifs_follow_link(struct dentry *direntry, struct nameidata *nd); | 85 | extern void *cifs_follow_link(struct dentry *direntry, struct nameidata *nd); |
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index e004f6db5fc8..9fbf4dff5da6 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
@@ -254,6 +254,7 @@ struct cifsTconInfo { | |||
254 | atomic_t num_smbs_sent; | 254 | atomic_t num_smbs_sent; |
255 | atomic_t num_writes; | 255 | atomic_t num_writes; |
256 | atomic_t num_reads; | 256 | atomic_t num_reads; |
257 | atomic_t num_flushes; | ||
257 | atomic_t num_oplock_brks; | 258 | atomic_t num_oplock_brks; |
258 | atomic_t num_opens; | 259 | atomic_t num_opens; |
259 | atomic_t num_closes; | 260 | atomic_t num_closes; |
@@ -298,6 +299,7 @@ struct cifsTconInfo { | |||
298 | bool unix_ext:1; /* if false disable Linux extensions to CIFS protocol | 299 | bool unix_ext:1; /* if false disable Linux extensions to CIFS protocol |
299 | for this mount even if server would support */ | 300 | for this mount even if server would support */ |
300 | bool local_lease:1; /* check leases (only) on local system not remote */ | 301 | bool local_lease:1; /* check leases (only) on local system not remote */ |
302 | bool broken_posix_open; /* e.g. Samba server versions < 3.3.2, 3.2.9 */ | ||
301 | bool need_reconnect:1; /* connection reset, tid now invalid */ | 303 | bool need_reconnect:1; /* connection reset, tid now invalid */ |
302 | /* BB add field for back pointer to sb struct(s)? */ | 304 | /* BB add field for back pointer to sb struct(s)? */ |
303 | }; | 305 | }; |
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index b4e2e9f0ee3d..b370489c8da5 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h | |||
@@ -1,7 +1,7 @@ | |||
1 | /* | 1 | /* |
2 | * fs/cifs/cifspdu.h | 2 | * fs/cifs/cifspdu.h |
3 | * | 3 | * |
4 | * Copyright (c) International Business Machines Corp., 2002,2008 | 4 | * Copyright (c) International Business Machines Corp., 2002,2009 |
5 | * Author(s): Steve French (sfrench@us.ibm.com) | 5 | * Author(s): Steve French (sfrench@us.ibm.com) |
6 | * | 6 | * |
7 | * This library is free software; you can redistribute it and/or modify | 7 | * This library is free software; you can redistribute it and/or modify |
@@ -23,6 +23,7 @@ | |||
23 | #define _CIFSPDU_H | 23 | #define _CIFSPDU_H |
24 | 24 | ||
25 | #include <net/sock.h> | 25 | #include <net/sock.h> |
26 | #include "smbfsctl.h" | ||
26 | 27 | ||
27 | #ifdef CONFIG_CIFS_WEAK_PW_HASH | 28 | #ifdef CONFIG_CIFS_WEAK_PW_HASH |
28 | #define LANMAN_PROT 0 | 29 | #define LANMAN_PROT 0 |
@@ -34,15 +35,15 @@ | |||
34 | #define POSIX_PROT (CIFS_PROT+1) | 35 | #define POSIX_PROT (CIFS_PROT+1) |
35 | #define BAD_PROT 0xFFFF | 36 | #define BAD_PROT 0xFFFF |
36 | 37 | ||
37 | /* SMB command codes */ | 38 | /* SMB command codes: |
38 | /* | 39 | * Note some commands have minimal (wct=0,bcc=0), or uninteresting, responses |
39 | * Some commands have minimal (wct=0,bcc=0), or uninteresting, responses | ||
40 | * (ie which include no useful data other than the SMB error code itself). | 40 | * (ie which include no useful data other than the SMB error code itself). |
41 | * Knowing this helps avoid response buffer allocations and copy in some cases | 41 | * This can allow us to avoid response buffer allocations and copy in some cases |
42 | */ | 42 | */ |
43 | #define SMB_COM_CREATE_DIRECTORY 0x00 /* trivial response */ | 43 | #define SMB_COM_CREATE_DIRECTORY 0x00 /* trivial response */ |
44 | #define SMB_COM_DELETE_DIRECTORY 0x01 /* trivial response */ | 44 | #define SMB_COM_DELETE_DIRECTORY 0x01 /* trivial response */ |
45 | #define SMB_COM_CLOSE 0x04 /* triv req/rsp, timestamp ignored */ | 45 | #define SMB_COM_CLOSE 0x04 /* triv req/rsp, timestamp ignored */ |
46 | #define SMB_COM_FLUSH 0x05 /* triv req/rsp */ | ||
46 | #define SMB_COM_DELETE 0x06 /* trivial response */ | 47 | #define SMB_COM_DELETE 0x06 /* trivial response */ |
47 | #define SMB_COM_RENAME 0x07 /* trivial response */ | 48 | #define SMB_COM_RENAME 0x07 /* trivial response */ |
48 | #define SMB_COM_QUERY_INFORMATION 0x08 /* aka getattr */ | 49 | #define SMB_COM_QUERY_INFORMATION 0x08 /* aka getattr */ |
@@ -790,6 +791,12 @@ typedef struct smb_com_close_rsp { | |||
790 | __u16 ByteCount; /* bct = 0 */ | 791 | __u16 ByteCount; /* bct = 0 */ |
791 | } __attribute__((packed)) CLOSE_RSP; | 792 | } __attribute__((packed)) CLOSE_RSP; |
792 | 793 | ||
794 | typedef struct smb_com_flush_req { | ||
795 | struct smb_hdr hdr; /* wct = 1 */ | ||
796 | __u16 FileID; | ||
797 | __u16 ByteCount; /* 0 */ | ||
798 | } __attribute__((packed)) FLUSH_REQ; | ||
799 | |||
793 | typedef struct smb_com_findclose_req { | 800 | typedef struct smb_com_findclose_req { |
794 | struct smb_hdr hdr; /* wct = 1 */ | 801 | struct smb_hdr hdr; /* wct = 1 */ |
795 | __u16 FileID; | 802 | __u16 FileID; |
@@ -1924,19 +1931,19 @@ typedef struct smb_com_transaction2_get_dfs_refer_req { | |||
1924 | #define DFS_TYPE_ROOT 0x0001 | 1931 | #define DFS_TYPE_ROOT 0x0001 |
1925 | 1932 | ||
1926 | /* Referral Entry Flags */ | 1933 | /* Referral Entry Flags */ |
1927 | #define DFS_NAME_LIST_REF 0x0200 | 1934 | #define DFS_NAME_LIST_REF 0x0200 /* set for domain or DC referral responses */ |
1935 | #define DFS_TARGET_SET_BOUNDARY 0x0400 /* only valid with version 4 dfs req */ | ||
1928 | 1936 | ||
1929 | typedef struct dfs_referral_level_3 { | 1937 | typedef struct dfs_referral_level_3 { /* version 4 is same, + one flag bit */ |
1930 | __le16 VersionNumber; | 1938 | __le16 VersionNumber; /* must be 3 or 4 */ |
1931 | __le16 Size; | 1939 | __le16 Size; |
1932 | __le16 ServerType; /* 0x0001 = root targets; 0x0000 = link targets */ | 1940 | __le16 ServerType; /* 0x0001 = root targets; 0x0000 = link targets */ |
1933 | __le16 ReferralEntryFlags; /* 0x0200 bit set only for domain | 1941 | __le16 ReferralEntryFlags; |
1934 | or DC referral responce */ | ||
1935 | __le32 TimeToLive; | 1942 | __le32 TimeToLive; |
1936 | __le16 DfsPathOffset; | 1943 | __le16 DfsPathOffset; |
1937 | __le16 DfsAlternatePathOffset; | 1944 | __le16 DfsAlternatePathOffset; |
1938 | __le16 NetworkAddressOffset; /* offset of the link target */ | 1945 | __le16 NetworkAddressOffset; /* offset of the link target */ |
1939 | __le16 ServiceSiteGuid; | 1946 | __u8 ServiceSiteGuid[16]; /* MBZ, ignored */ |
1940 | } __attribute__((packed)) REFERRAL3; | 1947 | } __attribute__((packed)) REFERRAL3; |
1941 | 1948 | ||
1942 | typedef struct smb_com_transaction_get_dfs_refer_rsp { | 1949 | typedef struct smb_com_transaction_get_dfs_refer_rsp { |
@@ -1946,48 +1953,15 @@ typedef struct smb_com_transaction_get_dfs_refer_rsp { | |||
1946 | __u8 Pad; | 1953 | __u8 Pad; |
1947 | __le16 PathConsumed; | 1954 | __le16 PathConsumed; |
1948 | __le16 NumberOfReferrals; | 1955 | __le16 NumberOfReferrals; |
1949 | __le16 DFSFlags; | 1956 | __le32 DFSFlags; |
1950 | __u16 Pad2; | ||
1951 | REFERRAL3 referrals[1]; /* array of level 3 dfs_referral structures */ | 1957 | REFERRAL3 referrals[1]; /* array of level 3 dfs_referral structures */ |
1952 | /* followed by the strings pointed to by the referral structures */ | 1958 | /* followed by the strings pointed to by the referral structures */ |
1953 | } __attribute__((packed)) TRANSACTION2_GET_DFS_REFER_RSP; | 1959 | } __attribute__((packed)) TRANSACTION2_GET_DFS_REFER_RSP; |
1954 | 1960 | ||
1955 | /* DFS Flags */ | 1961 | /* DFS Flags */ |
1956 | #define DFSREF_REFERRAL_SERVER 0x0001 | 1962 | #define DFSREF_REFERRAL_SERVER 0x00000001 /* all targets are DFS roots */ |
1957 | #define DFSREF_STORAGE_SERVER 0x0002 | 1963 | #define DFSREF_STORAGE_SERVER 0x00000002 /* no further ref requests needed */ |
1958 | 1964 | #define DFSREF_TARGET_FAILBACK 0x00000004 /* only for DFS referral version 4 */ | |
1959 | /* IOCTL information */ | ||
1960 | /* | ||
1961 | * List of ioctl function codes that look to be of interest to remote clients | ||
1962 | * like this one. Need to do some experimentation to make sure they all work | ||
1963 | * remotely. Some of the following, such as the encryption/compression ones | ||
1964 | * would be invoked from tools via a specialized hook into the VFS rather | ||
1965 | * than via the standard vfs entry points | ||
1966 | */ | ||
1967 | #define FSCTL_REQUEST_OPLOCK_LEVEL_1 0x00090000 | ||
1968 | #define FSCTL_REQUEST_OPLOCK_LEVEL_2 0x00090004 | ||
1969 | #define FSCTL_REQUEST_BATCH_OPLOCK 0x00090008 | ||
1970 | #define FSCTL_LOCK_VOLUME 0x00090018 | ||
1971 | #define FSCTL_UNLOCK_VOLUME 0x0009001C | ||
1972 | #define FSCTL_GET_COMPRESSION 0x0009003C | ||
1973 | #define FSCTL_SET_COMPRESSION 0x0009C040 | ||
1974 | #define FSCTL_REQUEST_FILTER_OPLOCK 0x0009008C | ||
1975 | #define FSCTL_FILESYS_GET_STATISTICS 0x00090090 | ||
1976 | #define FSCTL_SET_REPARSE_POINT 0x000900A4 | ||
1977 | #define FSCTL_GET_REPARSE_POINT 0x000900A8 | ||
1978 | #define FSCTL_DELETE_REPARSE_POINT 0x000900AC | ||
1979 | #define FSCTL_SET_SPARSE 0x000900C4 | ||
1980 | #define FSCTL_SET_ZERO_DATA 0x000900C8 | ||
1981 | #define FSCTL_SET_ENCRYPTION 0x000900D7 | ||
1982 | #define FSCTL_ENCRYPTION_FSCTL_IO 0x000900DB | ||
1983 | #define FSCTL_WRITE_RAW_ENCRYPTED 0x000900DF | ||
1984 | #define FSCTL_READ_RAW_ENCRYPTED 0x000900E3 | ||
1985 | #define FSCTL_SIS_COPYFILE 0x00090100 | ||
1986 | #define FSCTL_SIS_LINK_FILES 0x0009C104 | ||
1987 | |||
1988 | #define IO_REPARSE_TAG_MOUNT_POINT 0xA0000003 | ||
1989 | #define IO_REPARSE_TAG_HSM 0xC0000004 | ||
1990 | #define IO_REPARSE_TAG_SIS 0x80000007 | ||
1991 | 1965 | ||
1992 | /* | 1966 | /* |
1993 | ************************************************************************ | 1967 | ************************************************************************ |
@@ -2508,8 +2482,6 @@ struct data_blob { | |||
2508 | 6) Use nanosecond timestamps throughout all time fields if | 2482 | 6) Use nanosecond timestamps throughout all time fields if |
2509 | corresponding attribute flag is set | 2483 | corresponding attribute flag is set |
2510 | 7) sendfile - handle based copy | 2484 | 7) sendfile - handle based copy |
2511 | 8) Direct i/o | ||
2512 | 9) Misc fcntls? | ||
2513 | 2485 | ||
2514 | what about fixing 64 bit alignment | 2486 | what about fixing 64 bit alignment |
2515 | 2487 | ||
@@ -2628,7 +2600,5 @@ typedef struct file_chattr_info { | |||
2628 | __le64 mode; /* list of actual attribute bits on this inode */ | 2600 | __le64 mode; /* list of actual attribute bits on this inode */ |
2629 | } __attribute__((packed)) FILE_CHATTR_INFO; /* ext attributes | 2601 | } __attribute__((packed)) FILE_CHATTR_INFO; /* ext attributes |
2630 | (chattr, chflags) level 0x206 */ | 2602 | (chattr, chflags) level 0x206 */ |
2631 | 2603 | #endif /* POSIX */ | |
2632 | #endif | ||
2633 | |||
2634 | #endif /* _CIFSPDU_H */ | 2604 | #endif /* _CIFSPDU_H */ |
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index 083dfc57c7a3..4167716d32f2 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h | |||
@@ -44,6 +44,9 @@ extern void _FreeXid(unsigned int); | |||
44 | extern char *build_path_from_dentry(struct dentry *); | 44 | extern char *build_path_from_dentry(struct dentry *); |
45 | extern char *cifs_build_path_to_root(struct cifs_sb_info *cifs_sb); | 45 | extern char *cifs_build_path_to_root(struct cifs_sb_info *cifs_sb); |
46 | extern char *build_wildcard_path_from_dentry(struct dentry *direntry); | 46 | extern char *build_wildcard_path_from_dentry(struct dentry *direntry); |
47 | extern char *cifs_compose_mount_options(const char *sb_mountdata, | ||
48 | const char *fullpath, const struct dfs_info3_param *ref, | ||
49 | char **devname); | ||
47 | /* extern void renew_parental_timestamps(struct dentry *direntry);*/ | 50 | /* extern void renew_parental_timestamps(struct dentry *direntry);*/ |
48 | extern int SendReceive(const unsigned int /* xid */ , struct cifsSesInfo *, | 51 | extern int SendReceive(const unsigned int /* xid */ , struct cifsSesInfo *, |
49 | struct smb_hdr * /* input */ , | 52 | struct smb_hdr * /* input */ , |
@@ -92,6 +95,9 @@ extern u64 cifs_UnixTimeToNT(struct timespec); | |||
92 | extern __le64 cnvrtDosCifsTm(__u16 date, __u16 time); | 95 | extern __le64 cnvrtDosCifsTm(__u16 date, __u16 time); |
93 | extern struct timespec cnvrtDosUnixTm(__u16 date, __u16 time); | 96 | extern struct timespec cnvrtDosUnixTm(__u16 date, __u16 time); |
94 | 97 | ||
98 | extern int cifs_posix_open(char *full_path, struct inode **pinode, | ||
99 | struct super_block *sb, int mode, int oflags, | ||
100 | int *poplock, __u16 *pnetfid, int xid); | ||
95 | extern void posix_fill_in_inode(struct inode *tmp_inode, | 101 | extern void posix_fill_in_inode(struct inode *tmp_inode, |
96 | FILE_UNIX_BASIC_INFO *pData, int isNewInode); | 102 | FILE_UNIX_BASIC_INFO *pData, int isNewInode); |
97 | extern struct inode *cifs_new_inode(struct super_block *sb, __u64 *inum); | 103 | extern struct inode *cifs_new_inode(struct super_block *sb, __u64 *inum); |
@@ -281,6 +287,9 @@ extern int CIFSPOSIXCreate(const int xid, struct cifsTconInfo *tcon, | |||
281 | extern int CIFSSMBClose(const int xid, struct cifsTconInfo *tcon, | 287 | extern int CIFSSMBClose(const int xid, struct cifsTconInfo *tcon, |
282 | const int smb_file_id); | 288 | const int smb_file_id); |
283 | 289 | ||
290 | extern int CIFSSMBFlush(const int xid, struct cifsTconInfo *tcon, | ||
291 | const int smb_file_id); | ||
292 | |||
284 | extern int CIFSSMBRead(const int xid, struct cifsTconInfo *tcon, | 293 | extern int CIFSSMBRead(const int xid, struct cifsTconInfo *tcon, |
285 | const int netfid, unsigned int count, | 294 | const int netfid, unsigned int count, |
286 | const __u64 lseek, unsigned int *nbytes, char **buf, | 295 | const __u64 lseek, unsigned int *nbytes, char **buf, |
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 939e2f76b959..bc09c998631f 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c | |||
@@ -1934,6 +1934,27 @@ CIFSSMBClose(const int xid, struct cifsTconInfo *tcon, int smb_file_id) | |||
1934 | } | 1934 | } |
1935 | 1935 | ||
1936 | int | 1936 | int |
1937 | CIFSSMBFlush(const int xid, struct cifsTconInfo *tcon, int smb_file_id) | ||
1938 | { | ||
1939 | int rc = 0; | ||
1940 | FLUSH_REQ *pSMB = NULL; | ||
1941 | cFYI(1, ("In CIFSSMBFlush")); | ||
1942 | |||
1943 | rc = small_smb_init(SMB_COM_FLUSH, 1, tcon, (void **) &pSMB); | ||
1944 | if (rc) | ||
1945 | return rc; | ||
1946 | |||
1947 | pSMB->FileID = (__u16) smb_file_id; | ||
1948 | pSMB->ByteCount = 0; | ||
1949 | rc = SendReceiveNoRsp(xid, tcon->ses, (struct smb_hdr *) pSMB, 0); | ||
1950 | cifs_stats_inc(&tcon->num_flushes); | ||
1951 | if (rc) | ||
1952 | cERROR(1, ("Send error in Flush = %d", rc)); | ||
1953 | |||
1954 | return rc; | ||
1955 | } | ||
1956 | |||
1957 | int | ||
1937 | CIFSSMBRename(const int xid, struct cifsTconInfo *tcon, | 1958 | CIFSSMBRename(const int xid, struct cifsTconInfo *tcon, |
1938 | const char *fromName, const char *toName, | 1959 | const char *fromName, const char *toName, |
1939 | const struct nls_table *nls_codepage, int remap) | 1960 | const struct nls_table *nls_codepage, int remap) |
@@ -2356,8 +2377,10 @@ winCreateHardLinkRetry: | |||
2356 | PATH_MAX, nls_codepage, remap); | 2377 | PATH_MAX, nls_codepage, remap); |
2357 | name_len++; /* trailing null */ | 2378 | name_len++; /* trailing null */ |
2358 | name_len *= 2; | 2379 | name_len *= 2; |
2359 | pSMB->OldFileName[name_len] = 0; /* pad */ | 2380 | |
2360 | pSMB->OldFileName[name_len + 1] = 0x04; | 2381 | /* protocol specifies ASCII buffer format (0x04) for unicode */ |
2382 | pSMB->OldFileName[name_len] = 0x04; | ||
2383 | pSMB->OldFileName[name_len + 1] = 0x00; /* pad */ | ||
2361 | name_len2 = | 2384 | name_len2 = |
2362 | cifsConvertToUCS((__le16 *)&pSMB->OldFileName[name_len + 2], | 2385 | cifsConvertToUCS((__le16 *)&pSMB->OldFileName[name_len + 2], |
2363 | toName, PATH_MAX, nls_codepage, remap); | 2386 | toName, PATH_MAX, nls_codepage, remap); |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index da0f4ffa0613..0de3b5615a22 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -95,6 +95,7 @@ struct smb_vol { | |||
95 | bool local_lease:1; /* check leases only on local system, not remote */ | 95 | bool local_lease:1; /* check leases only on local system, not remote */ |
96 | bool noblocksnd:1; | 96 | bool noblocksnd:1; |
97 | bool noautotune:1; | 97 | bool noautotune:1; |
98 | bool nostrictsync:1; /* do not force expensive SMBflush on every sync */ | ||
98 | unsigned int rsize; | 99 | unsigned int rsize; |
99 | unsigned int wsize; | 100 | unsigned int wsize; |
100 | unsigned int sockopt; | 101 | unsigned int sockopt; |
@@ -1274,6 +1275,10 @@ cifs_parse_mount_options(char *options, const char *devname, | |||
1274 | vol->intr = 0; | 1275 | vol->intr = 0; |
1275 | } else if (strnicmp(data, "intr", 4) == 0) { | 1276 | } else if (strnicmp(data, "intr", 4) == 0) { |
1276 | vol->intr = 1; | 1277 | vol->intr = 1; |
1278 | } else if (strnicmp(data, "nostrictsync", 12) == 0) { | ||
1279 | vol->nostrictsync = 1; | ||
1280 | } else if (strnicmp(data, "strictsync", 10) == 0) { | ||
1281 | vol->nostrictsync = 0; | ||
1277 | } else if (strnicmp(data, "serverino", 7) == 0) { | 1282 | } else if (strnicmp(data, "serverino", 7) == 0) { |
1278 | vol->server_ino = 1; | 1283 | vol->server_ino = 1; |
1279 | } else if (strnicmp(data, "noserverino", 9) == 0) { | 1284 | } else if (strnicmp(data, "noserverino", 9) == 0) { |
@@ -2160,6 +2165,8 @@ static void setup_cifs_sb(struct smb_vol *pvolume_info, | |||
2160 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_UNX_EMUL; | 2165 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_UNX_EMUL; |
2161 | if (pvolume_info->nobrl) | 2166 | if (pvolume_info->nobrl) |
2162 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_NO_BRL; | 2167 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_NO_BRL; |
2168 | if (pvolume_info->nostrictsync) | ||
2169 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_NOSSYNC; | ||
2163 | if (pvolume_info->mand_lock) | 2170 | if (pvolume_info->mand_lock) |
2164 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_NOPOSIXBRL; | 2171 | cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_NOPOSIXBRL; |
2165 | if (pvolume_info->cifs_acl) | 2172 | if (pvolume_info->cifs_acl) |
@@ -3667,7 +3674,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses, | |||
3667 | BCC(smb_buffer_response)) { | 3674 | BCC(smb_buffer_response)) { |
3668 | kfree(tcon->nativeFileSystem); | 3675 | kfree(tcon->nativeFileSystem); |
3669 | tcon->nativeFileSystem = | 3676 | tcon->nativeFileSystem = |
3670 | kzalloc(length + 2, GFP_KERNEL); | 3677 | kzalloc(2*(length + 1), GFP_KERNEL); |
3671 | if (tcon->nativeFileSystem) | 3678 | if (tcon->nativeFileSystem) |
3672 | cifs_strfromUCS_le( | 3679 | cifs_strfromUCS_le( |
3673 | tcon->nativeFileSystem, | 3680 | tcon->nativeFileSystem, |
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 89fb72832652..2f35cccfcd8d 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
@@ -129,7 +129,7 @@ cifs_bp_rename_retry: | |||
129 | return full_path; | 129 | return full_path; |
130 | } | 130 | } |
131 | 131 | ||
132 | static int cifs_posix_open(char *full_path, struct inode **pinode, | 132 | int cifs_posix_open(char *full_path, struct inode **pinode, |
133 | struct super_block *sb, int mode, int oflags, | 133 | struct super_block *sb, int mode, int oflags, |
134 | int *poplock, __u16 *pnetfid, int xid) | 134 | int *poplock, __u16 *pnetfid, int xid) |
135 | { | 135 | { |
@@ -187,7 +187,9 @@ static int cifs_posix_open(char *full_path, struct inode **pinode, | |||
187 | if (!pinode) | 187 | if (!pinode) |
188 | goto posix_open_ret; /* caller does not need info */ | 188 | goto posix_open_ret; /* caller does not need info */ |
189 | 189 | ||
190 | *pinode = cifs_new_inode(sb, &presp_data->UniqueId); | 190 | if (*pinode == NULL) |
191 | *pinode = cifs_new_inode(sb, &presp_data->UniqueId); | ||
192 | /* else an inode was passed in. Update its info, don't create one */ | ||
191 | 193 | ||
192 | /* We do not need to close the file if new_inode fails since | 194 | /* We do not need to close the file if new_inode fails since |
193 | the caller will retry qpathinfo as long as inode is null */ | 195 | the caller will retry qpathinfo as long as inode is null */ |
@@ -699,7 +701,7 @@ cifs_d_revalidate(struct dentry *direntry, struct nameidata *nd) | |||
699 | return rc; | 701 | return rc; |
700 | } */ | 702 | } */ |
701 | 703 | ||
702 | struct dentry_operations cifs_dentry_ops = { | 704 | const struct dentry_operations cifs_dentry_ops = { |
703 | .d_revalidate = cifs_d_revalidate, | 705 | .d_revalidate = cifs_d_revalidate, |
704 | /* d_delete: cifs_d_delete, */ /* not needed except for debugging */ | 706 | /* d_delete: cifs_d_delete, */ /* not needed except for debugging */ |
705 | }; | 707 | }; |
@@ -737,7 +739,7 @@ static int cifs_ci_compare(struct dentry *dentry, struct qstr *a, | |||
737 | return 1; | 739 | return 1; |
738 | } | 740 | } |
739 | 741 | ||
740 | struct dentry_operations cifs_ci_dentry_ops = { | 742 | const struct dentry_operations cifs_ci_dentry_ops = { |
741 | .d_revalidate = cifs_d_revalidate, | 743 | .d_revalidate = cifs_d_revalidate, |
742 | .d_hash = cifs_ci_hash, | 744 | .d_hash = cifs_ci_hash, |
743 | .d_compare = cifs_ci_compare, | 745 | .d_compare = cifs_ci_compare, |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 12bb656fbe75..81747acca4c4 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -78,8 +78,36 @@ static inline int cifs_convert_flags(unsigned int flags) | |||
78 | return (READ_CONTROL | FILE_WRITE_ATTRIBUTES | FILE_READ_ATTRIBUTES | | 78 | return (READ_CONTROL | FILE_WRITE_ATTRIBUTES | FILE_READ_ATTRIBUTES | |
79 | FILE_WRITE_EA | FILE_APPEND_DATA | FILE_WRITE_DATA | | 79 | FILE_WRITE_EA | FILE_APPEND_DATA | FILE_WRITE_DATA | |
80 | FILE_READ_DATA); | 80 | FILE_READ_DATA); |
81 | } | ||
81 | 82 | ||
83 | static inline fmode_t cifs_posix_convert_flags(unsigned int flags) | ||
84 | { | ||
85 | fmode_t posix_flags = 0; | ||
82 | 86 | ||
87 | if ((flags & O_ACCMODE) == O_RDONLY) | ||
88 | posix_flags = FMODE_READ; | ||
89 | else if ((flags & O_ACCMODE) == O_WRONLY) | ||
90 | posix_flags = FMODE_WRITE; | ||
91 | else if ((flags & O_ACCMODE) == O_RDWR) { | ||
92 | /* GENERIC_ALL is too much permission to request | ||
93 | can cause unnecessary access denied on create */ | ||
94 | /* return GENERIC_ALL; */ | ||
95 | posix_flags = FMODE_READ | FMODE_WRITE; | ||
96 | } | ||
97 | /* can not map O_CREAT or O_EXCL or O_TRUNC flags when | ||
98 | reopening a file. They had their effect on the original open */ | ||
99 | if (flags & O_APPEND) | ||
100 | posix_flags |= (fmode_t)O_APPEND; | ||
101 | if (flags & O_SYNC) | ||
102 | posix_flags |= (fmode_t)O_SYNC; | ||
103 | if (flags & O_DIRECTORY) | ||
104 | posix_flags |= (fmode_t)O_DIRECTORY; | ||
105 | if (flags & O_NOFOLLOW) | ||
106 | posix_flags |= (fmode_t)O_NOFOLLOW; | ||
107 | if (flags & O_DIRECT) | ||
108 | posix_flags |= (fmode_t)O_DIRECT; | ||
109 | |||
110 | return posix_flags; | ||
83 | } | 111 | } |
84 | 112 | ||
85 | static inline int cifs_get_disposition(unsigned int flags) | 113 | static inline int cifs_get_disposition(unsigned int flags) |
@@ -97,6 +125,80 @@ static inline int cifs_get_disposition(unsigned int flags) | |||
97 | } | 125 | } |
98 | 126 | ||
99 | /* all arguments to this function must be checked for validity in caller */ | 127 | /* all arguments to this function must be checked for validity in caller */ |
128 | static inline int cifs_posix_open_inode_helper(struct inode *inode, | ||
129 | struct file *file, struct cifsInodeInfo *pCifsInode, | ||
130 | struct cifsFileInfo *pCifsFile, int oplock, u16 netfid) | ||
131 | { | ||
132 | struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb); | ||
133 | /* struct timespec temp; */ /* BB REMOVEME BB */ | ||
134 | |||
135 | file->private_data = kmalloc(sizeof(struct cifsFileInfo), GFP_KERNEL); | ||
136 | if (file->private_data == NULL) | ||
137 | return -ENOMEM; | ||
138 | pCifsFile = cifs_init_private(file->private_data, inode, file, netfid); | ||
139 | write_lock(&GlobalSMBSeslock); | ||
140 | list_add(&pCifsFile->tlist, &cifs_sb->tcon->openFileList); | ||
141 | |||
142 | pCifsInode = CIFS_I(file->f_path.dentry->d_inode); | ||
143 | if (pCifsInode == NULL) { | ||
144 | write_unlock(&GlobalSMBSeslock); | ||
145 | return -EINVAL; | ||
146 | } | ||
147 | |||
148 | /* want handles we can use to read with first | ||
149 | in the list so we do not have to walk the | ||
150 | list to search for one in write_begin */ | ||
151 | if ((file->f_flags & O_ACCMODE) == O_WRONLY) { | ||
152 | list_add_tail(&pCifsFile->flist, | ||
153 | &pCifsInode->openFileList); | ||
154 | } else { | ||
155 | list_add(&pCifsFile->flist, | ||
156 | &pCifsInode->openFileList); | ||
157 | } | ||
158 | |||
159 | if (pCifsInode->clientCanCacheRead) { | ||
160 | /* we have the inode open somewhere else | ||
161 | no need to discard cache data */ | ||
162 | goto psx_client_can_cache; | ||
163 | } | ||
164 | |||
165 | /* BB FIXME need to fix this check to move it earlier into posix_open | ||
166 | BB fIX following section BB FIXME */ | ||
167 | |||
168 | /* if not oplocked, invalidate inode pages if mtime or file | ||
169 | size changed */ | ||
170 | /* temp = cifs_NTtimeToUnix(le64_to_cpu(buf->LastWriteTime)); | ||
171 | if (timespec_equal(&file->f_path.dentry->d_inode->i_mtime, &temp) && | ||
172 | (file->f_path.dentry->d_inode->i_size == | ||
173 | (loff_t)le64_to_cpu(buf->EndOfFile))) { | ||
174 | cFYI(1, ("inode unchanged on server")); | ||
175 | } else { | ||
176 | if (file->f_path.dentry->d_inode->i_mapping) { | ||
177 | rc = filemap_write_and_wait(file->f_path.dentry->d_inode->i_mapping); | ||
178 | if (rc != 0) | ||
179 | CIFS_I(file->f_path.dentry->d_inode)->write_behind_rc = rc; | ||
180 | } | ||
181 | cFYI(1, ("invalidating remote inode since open detected it " | ||
182 | "changed")); | ||
183 | invalidate_remote_inode(file->f_path.dentry->d_inode); | ||
184 | } */ | ||
185 | |||
186 | psx_client_can_cache: | ||
187 | if ((oplock & 0xF) == OPLOCK_EXCLUSIVE) { | ||
188 | pCifsInode->clientCanCacheAll = true; | ||
189 | pCifsInode->clientCanCacheRead = true; | ||
190 | cFYI(1, ("Exclusive Oplock granted on inode %p", | ||
191 | file->f_path.dentry->d_inode)); | ||
192 | } else if ((oplock & 0xF) == OPLOCK_READ) | ||
193 | pCifsInode->clientCanCacheRead = true; | ||
194 | |||
195 | /* will have to change the unlock if we reenable the | ||
196 | filemap_fdatawrite (which does not seem necessary */ | ||
197 | write_unlock(&GlobalSMBSeslock); | ||
198 | return 0; | ||
199 | } | ||
200 | |||
201 | /* all arguments to this function must be checked for validity in caller */ | ||
100 | static inline int cifs_open_inode_helper(struct inode *inode, struct file *file, | 202 | static inline int cifs_open_inode_helper(struct inode *inode, struct file *file, |
101 | struct cifsInodeInfo *pCifsInode, struct cifsFileInfo *pCifsFile, | 203 | struct cifsInodeInfo *pCifsInode, struct cifsFileInfo *pCifsFile, |
102 | struct cifsTconInfo *pTcon, int *oplock, FILE_ALL_INFO *buf, | 204 | struct cifsTconInfo *pTcon, int *oplock, FILE_ALL_INFO *buf, |
@@ -167,7 +269,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
167 | int rc = -EACCES; | 269 | int rc = -EACCES; |
168 | int xid, oplock; | 270 | int xid, oplock; |
169 | struct cifs_sb_info *cifs_sb; | 271 | struct cifs_sb_info *cifs_sb; |
170 | struct cifsTconInfo *pTcon; | 272 | struct cifsTconInfo *tcon; |
171 | struct cifsFileInfo *pCifsFile; | 273 | struct cifsFileInfo *pCifsFile; |
172 | struct cifsInodeInfo *pCifsInode; | 274 | struct cifsInodeInfo *pCifsInode; |
173 | struct list_head *tmp; | 275 | struct list_head *tmp; |
@@ -180,7 +282,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
180 | xid = GetXid(); | 282 | xid = GetXid(); |
181 | 283 | ||
182 | cifs_sb = CIFS_SB(inode->i_sb); | 284 | cifs_sb = CIFS_SB(inode->i_sb); |
183 | pTcon = cifs_sb->tcon; | 285 | tcon = cifs_sb->tcon; |
184 | 286 | ||
185 | if (file->f_flags & O_CREAT) { | 287 | if (file->f_flags & O_CREAT) { |
186 | /* search inode for this file and fill in file->private_data */ | 288 | /* search inode for this file and fill in file->private_data */ |
@@ -220,6 +322,45 @@ int cifs_open(struct inode *inode, struct file *file) | |||
220 | 322 | ||
221 | cFYI(1, ("inode = 0x%p file flags are 0x%x for %s", | 323 | cFYI(1, ("inode = 0x%p file flags are 0x%x for %s", |
222 | inode, file->f_flags, full_path)); | 324 | inode, file->f_flags, full_path)); |
325 | |||
326 | if (oplockEnabled) | ||
327 | oplock = REQ_OPLOCK; | ||
328 | else | ||
329 | oplock = 0; | ||
330 | |||
331 | if (!tcon->broken_posix_open && tcon->unix_ext && | ||
332 | (tcon->ses->capabilities & CAP_UNIX) && | ||
333 | (CIFS_UNIX_POSIX_PATH_OPS_CAP & | ||
334 | le64_to_cpu(tcon->fsUnixInfo.Capability))) { | ||
335 | int oflags = (int) cifs_posix_convert_flags(file->f_flags); | ||
336 | /* can not refresh inode info since size could be stale */ | ||
337 | rc = cifs_posix_open(full_path, &inode, inode->i_sb, | ||
338 | cifs_sb->mnt_file_mode /* ignored */, | ||
339 | oflags, &oplock, &netfid, xid); | ||
340 | if (rc == 0) { | ||
341 | cFYI(1, ("posix open succeeded")); | ||
342 | /* no need for special case handling of setting mode | ||
343 | on read only files needed here */ | ||
344 | |||
345 | cifs_posix_open_inode_helper(inode, file, pCifsInode, | ||
346 | pCifsFile, oplock, netfid); | ||
347 | goto out; | ||
348 | } else if ((rc == -EINVAL) || (rc == -EOPNOTSUPP)) { | ||
349 | if (tcon->ses->serverNOS) | ||
350 | cERROR(1, ("server %s of type %s returned" | ||
351 | " unexpected error on SMB posix open" | ||
352 | ", disabling posix open support." | ||
353 | " Check if server update available.", | ||
354 | tcon->ses->serverName, | ||
355 | tcon->ses->serverNOS)); | ||
356 | tcon->broken_posix_open = true; | ||
357 | } else if ((rc != -EIO) && (rc != -EREMOTE) && | ||
358 | (rc != -EOPNOTSUPP)) /* path not found or net err */ | ||
359 | goto out; | ||
360 | /* else fallthrough to retry open the old way on network i/o | ||
361 | or DFS errors */ | ||
362 | } | ||
363 | |||
223 | desiredAccess = cifs_convert_flags(file->f_flags); | 364 | desiredAccess = cifs_convert_flags(file->f_flags); |
224 | 365 | ||
225 | /********************************************************************* | 366 | /********************************************************************* |
@@ -248,11 +389,6 @@ int cifs_open(struct inode *inode, struct file *file) | |||
248 | 389 | ||
249 | disposition = cifs_get_disposition(file->f_flags); | 390 | disposition = cifs_get_disposition(file->f_flags); |
250 | 391 | ||
251 | if (oplockEnabled) | ||
252 | oplock = REQ_OPLOCK; | ||
253 | else | ||
254 | oplock = 0; | ||
255 | |||
256 | /* BB pass O_SYNC flag through on file attributes .. BB */ | 392 | /* BB pass O_SYNC flag through on file attributes .. BB */ |
257 | 393 | ||
258 | /* Also refresh inode by passing in file_info buf returned by SMBOpen | 394 | /* Also refresh inode by passing in file_info buf returned by SMBOpen |
@@ -269,7 +405,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
269 | } | 405 | } |
270 | 406 | ||
271 | if (cifs_sb->tcon->ses->capabilities & CAP_NT_SMBS) | 407 | if (cifs_sb->tcon->ses->capabilities & CAP_NT_SMBS) |
272 | rc = CIFSSMBOpen(xid, pTcon, full_path, disposition, | 408 | rc = CIFSSMBOpen(xid, tcon, full_path, disposition, |
273 | desiredAccess, CREATE_NOT_DIR, &netfid, &oplock, buf, | 409 | desiredAccess, CREATE_NOT_DIR, &netfid, &oplock, buf, |
274 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags | 410 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags |
275 | & CIFS_MOUNT_MAP_SPECIAL_CHR); | 411 | & CIFS_MOUNT_MAP_SPECIAL_CHR); |
@@ -278,7 +414,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
278 | 414 | ||
279 | if (rc == -EIO) { | 415 | if (rc == -EIO) { |
280 | /* Old server, try legacy style OpenX */ | 416 | /* Old server, try legacy style OpenX */ |
281 | rc = SMBLegacyOpen(xid, pTcon, full_path, disposition, | 417 | rc = SMBLegacyOpen(xid, tcon, full_path, disposition, |
282 | desiredAccess, CREATE_NOT_DIR, &netfid, &oplock, buf, | 418 | desiredAccess, CREATE_NOT_DIR, &netfid, &oplock, buf, |
283 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags | 419 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags |
284 | & CIFS_MOUNT_MAP_SPECIAL_CHR); | 420 | & CIFS_MOUNT_MAP_SPECIAL_CHR); |
@@ -295,12 +431,12 @@ int cifs_open(struct inode *inode, struct file *file) | |||
295 | } | 431 | } |
296 | pCifsFile = cifs_init_private(file->private_data, inode, file, netfid); | 432 | pCifsFile = cifs_init_private(file->private_data, inode, file, netfid); |
297 | write_lock(&GlobalSMBSeslock); | 433 | write_lock(&GlobalSMBSeslock); |
298 | list_add(&pCifsFile->tlist, &pTcon->openFileList); | 434 | list_add(&pCifsFile->tlist, &tcon->openFileList); |
299 | 435 | ||
300 | pCifsInode = CIFS_I(file->f_path.dentry->d_inode); | 436 | pCifsInode = CIFS_I(file->f_path.dentry->d_inode); |
301 | if (pCifsInode) { | 437 | if (pCifsInode) { |
302 | rc = cifs_open_inode_helper(inode, file, pCifsInode, | 438 | rc = cifs_open_inode_helper(inode, file, pCifsInode, |
303 | pCifsFile, pTcon, | 439 | pCifsFile, tcon, |
304 | &oplock, buf, full_path, xid); | 440 | &oplock, buf, full_path, xid); |
305 | } else { | 441 | } else { |
306 | write_unlock(&GlobalSMBSeslock); | 442 | write_unlock(&GlobalSMBSeslock); |
@@ -309,7 +445,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
309 | if (oplock & CIFS_CREATE_ACTION) { | 445 | if (oplock & CIFS_CREATE_ACTION) { |
310 | /* time to set mode which we can not set earlier due to | 446 | /* time to set mode which we can not set earlier due to |
311 | problems creating new read-only files */ | 447 | problems creating new read-only files */ |
312 | if (pTcon->unix_ext) { | 448 | if (tcon->unix_ext) { |
313 | struct cifs_unix_set_info_args args = { | 449 | struct cifs_unix_set_info_args args = { |
314 | .mode = inode->i_mode, | 450 | .mode = inode->i_mode, |
315 | .uid = NO_CHANGE_64, | 451 | .uid = NO_CHANGE_64, |
@@ -319,7 +455,7 @@ int cifs_open(struct inode *inode, struct file *file) | |||
319 | .mtime = NO_CHANGE_64, | 455 | .mtime = NO_CHANGE_64, |
320 | .device = 0, | 456 | .device = 0, |
321 | }; | 457 | }; |
322 | CIFSSMBUnixSetInfo(xid, pTcon, full_path, &args, | 458 | CIFSSMBUnixSetInfo(xid, tcon, full_path, &args, |
323 | cifs_sb->local_nls, | 459 | cifs_sb->local_nls, |
324 | cifs_sb->mnt_cifs_flags & | 460 | cifs_sb->mnt_cifs_flags & |
325 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 461 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
@@ -349,7 +485,7 @@ static int cifs_reopen_file(struct file *file, bool can_flush) | |||
349 | int rc = -EACCES; | 485 | int rc = -EACCES; |
350 | int xid, oplock; | 486 | int xid, oplock; |
351 | struct cifs_sb_info *cifs_sb; | 487 | struct cifs_sb_info *cifs_sb; |
352 | struct cifsTconInfo *pTcon; | 488 | struct cifsTconInfo *tcon; |
353 | struct cifsFileInfo *pCifsFile; | 489 | struct cifsFileInfo *pCifsFile; |
354 | struct cifsInodeInfo *pCifsInode; | 490 | struct cifsInodeInfo *pCifsInode; |
355 | struct inode *inode; | 491 | struct inode *inode; |
@@ -387,7 +523,7 @@ static int cifs_reopen_file(struct file *file, bool can_flush) | |||
387 | } | 523 | } |
388 | 524 | ||
389 | cifs_sb = CIFS_SB(inode->i_sb); | 525 | cifs_sb = CIFS_SB(inode->i_sb); |
390 | pTcon = cifs_sb->tcon; | 526 | tcon = cifs_sb->tcon; |
391 | 527 | ||
392 | /* can not grab rename sem here because various ops, including | 528 | /* can not grab rename sem here because various ops, including |
393 | those that already have the rename sem can end up causing writepage | 529 | those that already have the rename sem can end up causing writepage |
@@ -404,20 +540,37 @@ reopen_error_exit: | |||
404 | 540 | ||
405 | cFYI(1, ("inode = 0x%p file flags 0x%x for %s", | 541 | cFYI(1, ("inode = 0x%p file flags 0x%x for %s", |
406 | inode, file->f_flags, full_path)); | 542 | inode, file->f_flags, full_path)); |
407 | desiredAccess = cifs_convert_flags(file->f_flags); | ||
408 | 543 | ||
409 | if (oplockEnabled) | 544 | if (oplockEnabled) |
410 | oplock = REQ_OPLOCK; | 545 | oplock = REQ_OPLOCK; |
411 | else | 546 | else |
412 | oplock = 0; | 547 | oplock = 0; |
413 | 548 | ||
549 | if (tcon->unix_ext && (tcon->ses->capabilities & CAP_UNIX) && | ||
550 | (CIFS_UNIX_POSIX_PATH_OPS_CAP & | ||
551 | le64_to_cpu(tcon->fsUnixInfo.Capability))) { | ||
552 | int oflags = (int) cifs_posix_convert_flags(file->f_flags); | ||
553 | /* can not refresh inode info since size could be stale */ | ||
554 | rc = cifs_posix_open(full_path, NULL, inode->i_sb, | ||
555 | cifs_sb->mnt_file_mode /* ignored */, | ||
556 | oflags, &oplock, &netfid, xid); | ||
557 | if (rc == 0) { | ||
558 | cFYI(1, ("posix reopen succeeded")); | ||
559 | goto reopen_success; | ||
560 | } | ||
561 | /* fallthrough to retry open the old way on errors, especially | ||
562 | in the reconnect path it is important to retry hard */ | ||
563 | } | ||
564 | |||
565 | desiredAccess = cifs_convert_flags(file->f_flags); | ||
566 | |||
414 | /* Can not refresh inode by passing in file_info buf to be returned | 567 | /* Can not refresh inode by passing in file_info buf to be returned |
415 | by SMBOpen and then calling get_inode_info with returned buf | 568 | by SMBOpen and then calling get_inode_info with returned buf |
416 | since file might have write behind data that needs to be flushed | 569 | since file might have write behind data that needs to be flushed |
417 | and server version of file size can be stale. If we knew for sure | 570 | and server version of file size can be stale. If we knew for sure |
418 | that inode was not dirty locally we could do this */ | 571 | that inode was not dirty locally we could do this */ |
419 | 572 | ||
420 | rc = CIFSSMBOpen(xid, pTcon, full_path, disposition, desiredAccess, | 573 | rc = CIFSSMBOpen(xid, tcon, full_path, disposition, desiredAccess, |
421 | CREATE_NOT_DIR, &netfid, &oplock, NULL, | 574 | CREATE_NOT_DIR, &netfid, &oplock, NULL, |
422 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags & | 575 | cifs_sb->local_nls, cifs_sb->mnt_cifs_flags & |
423 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 576 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
@@ -426,6 +579,7 @@ reopen_error_exit: | |||
426 | cFYI(1, ("cifs_open returned 0x%x", rc)); | 579 | cFYI(1, ("cifs_open returned 0x%x", rc)); |
427 | cFYI(1, ("oplock: %d", oplock)); | 580 | cFYI(1, ("oplock: %d", oplock)); |
428 | } else { | 581 | } else { |
582 | reopen_success: | ||
429 | pCifsFile->netfid = netfid; | 583 | pCifsFile->netfid = netfid; |
430 | pCifsFile->invalidHandle = false; | 584 | pCifsFile->invalidHandle = false; |
431 | up(&pCifsFile->fh_sem); | 585 | up(&pCifsFile->fh_sem); |
@@ -439,7 +593,7 @@ reopen_error_exit: | |||
439 | go to server to get inode info */ | 593 | go to server to get inode info */ |
440 | pCifsInode->clientCanCacheAll = false; | 594 | pCifsInode->clientCanCacheAll = false; |
441 | pCifsInode->clientCanCacheRead = false; | 595 | pCifsInode->clientCanCacheRead = false; |
442 | if (pTcon->unix_ext) | 596 | if (tcon->unix_ext) |
443 | rc = cifs_get_inode_info_unix(&inode, | 597 | rc = cifs_get_inode_info_unix(&inode, |
444 | full_path, inode->i_sb, xid); | 598 | full_path, inode->i_sb, xid); |
445 | else | 599 | else |
@@ -467,7 +621,6 @@ reopen_error_exit: | |||
467 | cifs_relock_file(pCifsFile); | 621 | cifs_relock_file(pCifsFile); |
468 | } | 622 | } |
469 | } | 623 | } |
470 | |||
471 | kfree(full_path); | 624 | kfree(full_path); |
472 | FreeXid(xid); | 625 | FreeXid(xid); |
473 | return rc; | 626 | return rc; |
@@ -1523,6 +1676,9 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1523 | { | 1676 | { |
1524 | int xid; | 1677 | int xid; |
1525 | int rc = 0; | 1678 | int rc = 0; |
1679 | struct cifsTconInfo *tcon; | ||
1680 | struct cifsFileInfo *smbfile = | ||
1681 | (struct cifsFileInfo *)file->private_data; | ||
1526 | struct inode *inode = file->f_path.dentry->d_inode; | 1682 | struct inode *inode = file->f_path.dentry->d_inode; |
1527 | 1683 | ||
1528 | xid = GetXid(); | 1684 | xid = GetXid(); |
@@ -1534,7 +1690,12 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1534 | if (rc == 0) { | 1690 | if (rc == 0) { |
1535 | rc = CIFS_I(inode)->write_behind_rc; | 1691 | rc = CIFS_I(inode)->write_behind_rc; |
1536 | CIFS_I(inode)->write_behind_rc = 0; | 1692 | CIFS_I(inode)->write_behind_rc = 0; |
1693 | tcon = CIFS_SB(inode->i_sb)->tcon; | ||
1694 | if (!rc && tcon && smbfile && | ||
1695 | !(CIFS_SB(inode->i_sb)->mnt_cifs_flags & CIFS_MOUNT_NOSSYNC)) | ||
1696 | rc = CIFSSMBFlush(xid, tcon, smbfile->netfid); | ||
1537 | } | 1697 | } |
1698 | |||
1538 | FreeXid(xid); | 1699 | FreeXid(xid); |
1539 | return rc; | 1700 | return rc; |
1540 | } | 1701 | } |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 4690a360c855..a8797cc60805 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -763,6 +763,9 @@ cifs_set_file_info(struct inode *inode, struct iattr *attrs, int xid, | |||
763 | struct cifsTconInfo *pTcon = cifs_sb->tcon; | 763 | struct cifsTconInfo *pTcon = cifs_sb->tcon; |
764 | FILE_BASIC_INFO info_buf; | 764 | FILE_BASIC_INFO info_buf; |
765 | 765 | ||
766 | if (attrs == NULL) | ||
767 | return -EINVAL; | ||
768 | |||
766 | if (attrs->ia_valid & ATTR_ATIME) { | 769 | if (attrs->ia_valid & ATTR_ATIME) { |
767 | set_time = true; | 770 | set_time = true; |
768 | info_buf.LastAccessTime = | 771 | info_buf.LastAccessTime = |
diff --git a/fs/cifs/smbfsctl.h b/fs/cifs/smbfsctl.h new file mode 100644 index 000000000000..7056b891e087 --- /dev/null +++ b/fs/cifs/smbfsctl.h | |||
@@ -0,0 +1,84 @@ | |||
1 | /* | ||
2 | * fs/cifs/smbfsctl.h: SMB, CIFS, SMB2 FSCTL definitions | ||
3 | * | ||
4 | * Copyright (c) International Business Machines Corp., 2002,2009 | ||
5 | * Author(s): Steve French (sfrench@us.ibm.com) | ||
6 | * | ||
7 | * This library is free software; you can redistribute it and/or modify | ||
8 | * it under the terms of the GNU Lesser General Public License as published | ||
9 | * by the Free Software Foundation; either version 2.1 of the License, or | ||
10 | * (at your option) any later version. | ||
11 | * | ||
12 | * This library is distributed in the hope that it will be useful, | ||
13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See | ||
15 | * the GNU Lesser General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU Lesser General Public License | ||
18 | * along with this library; if not, write to the Free Software | ||
19 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
20 | */ | ||
21 | |||
22 | /* IOCTL information */ | ||
23 | /* | ||
24 | * List of ioctl/fsctl function codes that are or could be useful in the | ||
25 | * future to remote clients like cifs or SMB2 client. There is probably | ||
26 | * a slightly larger set of fsctls that NTFS local filesystem could handle, | ||
27 | * including the seven below that we do not have struct definitions for. | ||
28 | * Even with protocol definitions for most of these now available, we still | ||
29 | * need to do some experimentation to identify which are practical to do | ||
30 | * remotely. Some of the following, such as the encryption/compression ones | ||
31 | * could be invoked from tools via a specialized hook into the VFS rather | ||
32 | * than via the standard vfs entry points | ||
33 | */ | ||
34 | #define FSCTL_REQUEST_OPLOCK_LEVEL_1 0x00090000 | ||
35 | #define FSCTL_REQUEST_OPLOCK_LEVEL_2 0x00090004 | ||
36 | #define FSCTL_REQUEST_BATCH_OPLOCK 0x00090008 | ||
37 | #define FSCTL_LOCK_VOLUME 0x00090018 | ||
38 | #define FSCTL_UNLOCK_VOLUME 0x0009001C | ||
39 | #define FSCTL_IS_PATHNAME_VALID 0x0009002C /* BB add struct */ | ||
40 | #define FSCTL_GET_COMPRESSION 0x0009003C /* BB add struct */ | ||
41 | #define FSCTL_SET_COMPRESSION 0x0009C040 /* BB add struct */ | ||
42 | #define FSCTL_QUERY_FAT_BPB 0x00090058 /* BB add struct */ | ||
43 | /* Verify the next FSCTL number, we had it as 0x00090090 before */ | ||
44 | #define FSCTL_FILESYSTEM_GET_STATS 0x00090060 /* BB add struct */ | ||
45 | #define FSCTL_GET_NTFS_VOLUME_DATA 0x00090064 /* BB add struct */ | ||
46 | #define FSCTL_GET_RETRIEVAL_POINTERS 0x00090073 /* BB add struct */ | ||
47 | #define FSCTL_IS_VOLUME_DIRTY 0x00090078 /* BB add struct */ | ||
48 | #define FSCTL_ALLOW_EXTENDED_DASD_IO 0x00090083 /* BB add struct */ | ||
49 | #define FSCTL_REQUEST_FILTER_OPLOCK 0x0009008C | ||
50 | #define FSCTL_FIND_FILES_BY_SID 0x0009008F /* BB add struct */ | ||
51 | #define FSCTL_SET_OBJECT_ID 0x00090098 /* BB add struct */ | ||
52 | #define FSCTL_GET_OBJECT_ID 0x0009009C /* BB add struct */ | ||
53 | #define FSCTL_DELETE_OBJECT_ID 0x000900A0 /* BB add struct */ | ||
54 | #define FSCTL_SET_REPARSE_POINT 0x000900A4 /* BB add struct */ | ||
55 | #define FSCTL_GET_REPARSE_POINT 0x000900A8 /* BB add struct */ | ||
56 | #define FSCTL_DELETE_REPARSE_POINT 0x000900AC /* BB add struct */ | ||
57 | #define FSCTL_SET_OBJECT_ID_EXTENDED 0x000900BC /* BB add struct */ | ||
58 | #define FSCTL_CREATE_OR_GET_OBJECT_ID 0x000900C0 /* BB add struct */ | ||
59 | #define FSCTL_SET_SPARSE 0x000900C4 /* BB add struct */ | ||
60 | #define FSCTL_SET_ZERO_DATA 0x000900C8 /* BB add struct */ | ||
61 | #define FSCTL_SET_ENCRYPTION 0x000900D7 /* BB add struct */ | ||
62 | #define FSCTL_ENCRYPTION_FSCTL_IO 0x000900DB /* BB add struct */ | ||
63 | #define FSCTL_WRITE_RAW_ENCRYPTED 0x000900DF /* BB add struct */ | ||
64 | #define FSCTL_READ_RAW_ENCRYPTED 0x000900E3 /* BB add struct */ | ||
65 | #define FSCTL_READ_FILE_USN_DATA 0x000900EB /* BB add struct */ | ||
66 | #define FSCTL_WRITE_USN_CLOSE_RECORD 0x000900EF /* BB add struct */ | ||
67 | #define FSCTL_SIS_COPYFILE 0x00090100 /* BB add struct */ | ||
68 | #define FSCTL_RECALL_FILE 0x00090117 /* BB add struct */ | ||
69 | #define FSCTL_QUERY_SPARING_INFO 0x00090138 /* BB add struct */ | ||
70 | #define FSCTL_SET_ZERO_ON_DEALLOC 0x00090194 /* BB add struct */ | ||
71 | #define FSCTL_SET_SHORT_NAME_BEHAVIOR 0x000901B4 /* BB add struct */ | ||
72 | #define FSCTL_QUERY_ALLOCATED_RANGES 0x000940CF /* BB add struct */ | ||
73 | #define FSCTL_SET_DEFECT_MANAGEMENT 0x00098134 /* BB add struct */ | ||
74 | #define FSCTL_SIS_LINK_FILES 0x0009C104 | ||
75 | #define FSCTL_PIPE_PEEK 0x0011400C /* BB add struct */ | ||
76 | #define FSCTL_PIPE_TRANSCEIVE 0x0011C017 /* BB add struct */ | ||
77 | /* strange that the number for this op is not sequential with previous op */ | ||
78 | #define FSCTL_PIPE_WAIT 0x00110018 /* BB add struct */ | ||
79 | #define FSCTL_LMR_GET_LINK_TRACK_INF 0x001400E8 /* BB add struct */ | ||
80 | #define FSCTL_LMR_SET_LINK_TRACK_INF 0x001400EC /* BB add struct */ | ||
81 | |||
82 | #define IO_REPARSE_TAG_MOUNT_POINT 0xA0000003 | ||
83 | #define IO_REPARSE_TAG_HSM 0xC0000004 | ||
84 | #define IO_REPARSE_TAG_SIS 0x80000007 | ||
diff --git a/fs/coda/dir.c b/fs/coda/dir.c index 75b1fa90b2cb..4bb9d0a5decc 100644 --- a/fs/coda/dir.c +++ b/fs/coda/dir.c | |||
@@ -59,7 +59,7 @@ static int coda_return_EIO(void) | |||
59 | } | 59 | } |
60 | #define CODA_EIO_ERROR ((void *) (coda_return_EIO)) | 60 | #define CODA_EIO_ERROR ((void *) (coda_return_EIO)) |
61 | 61 | ||
62 | static struct dentry_operations coda_dentry_operations = | 62 | static const struct dentry_operations coda_dentry_operations = |
63 | { | 63 | { |
64 | .d_revalidate = coda_dentry_revalidate, | 64 | .d_revalidate = coda_dentry_revalidate, |
65 | .d_delete = coda_dentry_delete, | 65 | .d_delete = coda_dentry_delete, |
diff --git a/fs/compat.c b/fs/compat.c index d0145ca27572..55efdfebdf5a 100644 --- a/fs/compat.c +++ b/fs/compat.c | |||
@@ -378,6 +378,34 @@ out: | |||
378 | return error; | 378 | return error; |
379 | } | 379 | } |
380 | 380 | ||
381 | /* | ||
382 | * This is a copy of sys_ustat, just dealing with a structure layout. | ||
383 | * Given how simple this syscall is that apporach is more maintainable | ||
384 | * than the various conversion hacks. | ||
385 | */ | ||
386 | asmlinkage long compat_sys_ustat(unsigned dev, struct compat_ustat __user *u) | ||
387 | { | ||
388 | struct super_block *sb; | ||
389 | struct compat_ustat tmp; | ||
390 | struct kstatfs sbuf; | ||
391 | int err; | ||
392 | |||
393 | sb = user_get_super(new_decode_dev(dev)); | ||
394 | if (!sb) | ||
395 | return -EINVAL; | ||
396 | err = vfs_statfs(sb->s_root, &sbuf); | ||
397 | drop_super(sb); | ||
398 | if (err) | ||
399 | return err; | ||
400 | |||
401 | memset(&tmp, 0, sizeof(struct compat_ustat)); | ||
402 | tmp.f_tfree = sbuf.f_bfree; | ||
403 | tmp.f_tinode = sbuf.f_ffree; | ||
404 | if (copy_to_user(u, &tmp, sizeof(struct compat_ustat))) | ||
405 | return -EFAULT; | ||
406 | return 0; | ||
407 | } | ||
408 | |||
381 | static int get_compat_flock(struct flock *kfl, struct compat_flock __user *ufl) | 409 | static int get_compat_flock(struct flock *kfl, struct compat_flock __user *ufl) |
382 | { | 410 | { |
383 | if (!access_ok(VERIFY_READ, ufl, sizeof(*ufl)) || | 411 | if (!access_ok(VERIFY_READ, ufl, sizeof(*ufl)) || |
@@ -1392,22 +1420,28 @@ int compat_do_execve(char * filename, | |||
1392 | { | 1420 | { |
1393 | struct linux_binprm *bprm; | 1421 | struct linux_binprm *bprm; |
1394 | struct file *file; | 1422 | struct file *file; |
1423 | struct files_struct *displaced; | ||
1395 | int retval; | 1424 | int retval; |
1396 | 1425 | ||
1426 | retval = unshare_files(&displaced); | ||
1427 | if (retval) | ||
1428 | goto out_ret; | ||
1429 | |||
1397 | retval = -ENOMEM; | 1430 | retval = -ENOMEM; |
1398 | bprm = kzalloc(sizeof(*bprm), GFP_KERNEL); | 1431 | bprm = kzalloc(sizeof(*bprm), GFP_KERNEL); |
1399 | if (!bprm) | 1432 | if (!bprm) |
1400 | goto out_ret; | 1433 | goto out_files; |
1401 | 1434 | ||
1402 | retval = mutex_lock_interruptible(¤t->cred_exec_mutex); | 1435 | retval = mutex_lock_interruptible(¤t->cred_exec_mutex); |
1403 | if (retval < 0) | 1436 | if (retval < 0) |
1404 | goto out_free; | 1437 | goto out_free; |
1438 | current->in_execve = 1; | ||
1405 | 1439 | ||
1406 | retval = -ENOMEM; | 1440 | retval = -ENOMEM; |
1407 | bprm->cred = prepare_exec_creds(); | 1441 | bprm->cred = prepare_exec_creds(); |
1408 | if (!bprm->cred) | 1442 | if (!bprm->cred) |
1409 | goto out_unlock; | 1443 | goto out_unlock; |
1410 | check_unsafe_exec(bprm, current->files); | 1444 | check_unsafe_exec(bprm); |
1411 | 1445 | ||
1412 | file = open_exec(filename); | 1446 | file = open_exec(filename); |
1413 | retval = PTR_ERR(file); | 1447 | retval = PTR_ERR(file); |
@@ -1454,9 +1488,12 @@ int compat_do_execve(char * filename, | |||
1454 | goto out; | 1488 | goto out; |
1455 | 1489 | ||
1456 | /* execve succeeded */ | 1490 | /* execve succeeded */ |
1491 | current->in_execve = 0; | ||
1457 | mutex_unlock(¤t->cred_exec_mutex); | 1492 | mutex_unlock(¤t->cred_exec_mutex); |
1458 | acct_update_integrals(current); | 1493 | acct_update_integrals(current); |
1459 | free_bprm(bprm); | 1494 | free_bprm(bprm); |
1495 | if (displaced) | ||
1496 | put_files_struct(displaced); | ||
1460 | return retval; | 1497 | return retval; |
1461 | 1498 | ||
1462 | out: | 1499 | out: |
@@ -1470,11 +1507,15 @@ out_file: | |||
1470 | } | 1507 | } |
1471 | 1508 | ||
1472 | out_unlock: | 1509 | out_unlock: |
1510 | current->in_execve = 0; | ||
1473 | mutex_unlock(¤t->cred_exec_mutex); | 1511 | mutex_unlock(¤t->cred_exec_mutex); |
1474 | 1512 | ||
1475 | out_free: | 1513 | out_free: |
1476 | free_bprm(bprm); | 1514 | free_bprm(bprm); |
1477 | 1515 | ||
1516 | out_files: | ||
1517 | if (displaced) | ||
1518 | reset_files_struct(displaced); | ||
1478 | out_ret: | 1519 | out_ret: |
1479 | return retval; | 1520 | return retval; |
1480 | } | 1521 | } |
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 45e59d3c7f1f..ff786687e93b 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c | |||
@@ -522,6 +522,11 @@ static int dev_ifsioc(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
522 | if (err) | 522 | if (err) |
523 | return -EFAULT; | 523 | return -EFAULT; |
524 | break; | 524 | break; |
525 | case SIOCSHWTSTAMP: | ||
526 | if (copy_from_user(&ifr, uifr32, sizeof(*uifr32))) | ||
527 | return -EFAULT; | ||
528 | ifr.ifr_data = compat_ptr(uifr32->ifr_ifru.ifru_data); | ||
529 | break; | ||
525 | default: | 530 | default: |
526 | if (copy_from_user(&ifr, uifr32, sizeof(*uifr32))) | 531 | if (copy_from_user(&ifr, uifr32, sizeof(*uifr32))) |
527 | return -EFAULT; | 532 | return -EFAULT; |
@@ -1993,6 +1998,8 @@ COMPATIBLE_IOCTL(TUNSETGROUP) | |||
1993 | COMPATIBLE_IOCTL(TUNGETFEATURES) | 1998 | COMPATIBLE_IOCTL(TUNGETFEATURES) |
1994 | COMPATIBLE_IOCTL(TUNSETOFFLOAD) | 1999 | COMPATIBLE_IOCTL(TUNSETOFFLOAD) |
1995 | COMPATIBLE_IOCTL(TUNSETTXFILTER) | 2000 | COMPATIBLE_IOCTL(TUNSETTXFILTER) |
2001 | COMPATIBLE_IOCTL(TUNGETSNDBUF) | ||
2002 | COMPATIBLE_IOCTL(TUNSETSNDBUF) | ||
1996 | /* Big V */ | 2003 | /* Big V */ |
1997 | COMPATIBLE_IOCTL(VT_SETMODE) | 2004 | COMPATIBLE_IOCTL(VT_SETMODE) |
1998 | COMPATIBLE_IOCTL(VT_GETMODE) | 2005 | COMPATIBLE_IOCTL(VT_GETMODE) |
@@ -2566,6 +2573,7 @@ HANDLE_IOCTL(SIOCSIFMAP, dev_ifsioc) | |||
2566 | HANDLE_IOCTL(SIOCGIFADDR, dev_ifsioc) | 2573 | HANDLE_IOCTL(SIOCGIFADDR, dev_ifsioc) |
2567 | HANDLE_IOCTL(SIOCSIFADDR, dev_ifsioc) | 2574 | HANDLE_IOCTL(SIOCSIFADDR, dev_ifsioc) |
2568 | HANDLE_IOCTL(SIOCSIFHWBROADCAST, dev_ifsioc) | 2575 | HANDLE_IOCTL(SIOCSIFHWBROADCAST, dev_ifsioc) |
2576 | HANDLE_IOCTL(SIOCSHWTSTAMP, dev_ifsioc) | ||
2569 | 2577 | ||
2570 | /* ioctls used by appletalk ddp.c */ | 2578 | /* ioctls used by appletalk ddp.c */ |
2571 | HANDLE_IOCTL(SIOCATALKDIFADDR, dev_ifsioc) | 2579 | HANDLE_IOCTL(SIOCATALKDIFADDR, dev_ifsioc) |
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 8e93341f3e82..05373db21a4e 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c | |||
@@ -72,7 +72,7 @@ static int configfs_d_delete(struct dentry *dentry) | |||
72 | return 1; | 72 | return 1; |
73 | } | 73 | } |
74 | 74 | ||
75 | static struct dentry_operations configfs_dentry_ops = { | 75 | static const struct dentry_operations configfs_dentry_ops = { |
76 | .d_iput = configfs_d_iput, | 76 | .d_iput = configfs_d_iput, |
77 | /* simple_delete_dentry() isn't exported */ | 77 | /* simple_delete_dentry() isn't exported */ |
78 | .d_delete = configfs_d_delete, | 78 | .d_delete = configfs_d_delete, |
diff --git a/fs/dcache.c b/fs/dcache.c index 07e2d4a44bda..90bbd7e1b116 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -1247,15 +1247,18 @@ struct dentry *d_add_ci(struct dentry *dentry, struct inode *inode, | |||
1247 | struct dentry *found; | 1247 | struct dentry *found; |
1248 | struct dentry *new; | 1248 | struct dentry *new; |
1249 | 1249 | ||
1250 | /* Does a dentry matching the name exist already? */ | 1250 | /* |
1251 | * First check if a dentry matching the name already exists, | ||
1252 | * if not go ahead and create it now. | ||
1253 | */ | ||
1251 | found = d_hash_and_lookup(dentry->d_parent, name); | 1254 | found = d_hash_and_lookup(dentry->d_parent, name); |
1252 | /* If not, create it now and return */ | ||
1253 | if (!found) { | 1255 | if (!found) { |
1254 | new = d_alloc(dentry->d_parent, name); | 1256 | new = d_alloc(dentry->d_parent, name); |
1255 | if (!new) { | 1257 | if (!new) { |
1256 | error = -ENOMEM; | 1258 | error = -ENOMEM; |
1257 | goto err_out; | 1259 | goto err_out; |
1258 | } | 1260 | } |
1261 | |||
1259 | found = d_splice_alias(inode, new); | 1262 | found = d_splice_alias(inode, new); |
1260 | if (found) { | 1263 | if (found) { |
1261 | dput(new); | 1264 | dput(new); |
@@ -1263,61 +1266,46 @@ struct dentry *d_add_ci(struct dentry *dentry, struct inode *inode, | |||
1263 | } | 1266 | } |
1264 | return new; | 1267 | return new; |
1265 | } | 1268 | } |
1266 | /* Matching dentry exists, check if it is negative. */ | 1269 | |
1270 | /* | ||
1271 | * If a matching dentry exists, and it's not negative use it. | ||
1272 | * | ||
1273 | * Decrement the reference count to balance the iget() done | ||
1274 | * earlier on. | ||
1275 | */ | ||
1267 | if (found->d_inode) { | 1276 | if (found->d_inode) { |
1268 | if (unlikely(found->d_inode != inode)) { | 1277 | if (unlikely(found->d_inode != inode)) { |
1269 | /* This can't happen because bad inodes are unhashed. */ | 1278 | /* This can't happen because bad inodes are unhashed. */ |
1270 | BUG_ON(!is_bad_inode(inode)); | 1279 | BUG_ON(!is_bad_inode(inode)); |
1271 | BUG_ON(!is_bad_inode(found->d_inode)); | 1280 | BUG_ON(!is_bad_inode(found->d_inode)); |
1272 | } | 1281 | } |
1273 | /* | ||
1274 | * Already have the inode and the dentry attached, decrement | ||
1275 | * the reference count to balance the iget() done | ||
1276 | * earlier on. We found the dentry using d_lookup() so it | ||
1277 | * cannot be disconnected and thus we do not need to worry | ||
1278 | * about any NFS/disconnectedness issues here. | ||
1279 | */ | ||
1280 | iput(inode); | 1282 | iput(inode); |
1281 | return found; | 1283 | return found; |
1282 | } | 1284 | } |
1285 | |||
1283 | /* | 1286 | /* |
1284 | * Negative dentry: instantiate it unless the inode is a directory and | 1287 | * Negative dentry: instantiate it unless the inode is a directory and |
1285 | * has a 'disconnected' dentry (i.e. IS_ROOT and DCACHE_DISCONNECTED), | 1288 | * already has a dentry. |
1286 | * in which case d_move() that in place of the found dentry. | ||
1287 | */ | 1289 | */ |
1288 | if (!S_ISDIR(inode->i_mode)) { | ||
1289 | /* Not a directory; everything is easy. */ | ||
1290 | d_instantiate(found, inode); | ||
1291 | return found; | ||
1292 | } | ||
1293 | spin_lock(&dcache_lock); | 1290 | spin_lock(&dcache_lock); |
1294 | if (list_empty(&inode->i_dentry)) { | 1291 | if (!S_ISDIR(inode->i_mode) || list_empty(&inode->i_dentry)) { |
1295 | /* | ||
1296 | * Directory without a 'disconnected' dentry; we need to do | ||
1297 | * d_instantiate() by hand because it takes dcache_lock which | ||
1298 | * we already hold. | ||
1299 | */ | ||
1300 | __d_instantiate(found, inode); | 1292 | __d_instantiate(found, inode); |
1301 | spin_unlock(&dcache_lock); | 1293 | spin_unlock(&dcache_lock); |
1302 | security_d_instantiate(found, inode); | 1294 | security_d_instantiate(found, inode); |
1303 | return found; | 1295 | return found; |
1304 | } | 1296 | } |
1297 | |||
1305 | /* | 1298 | /* |
1306 | * Directory with a 'disconnected' dentry; get a reference to the | 1299 | * In case a directory already has a (disconnected) entry grab a |
1307 | * 'disconnected' dentry. | 1300 | * reference to it, move it in place and use it. |
1308 | */ | 1301 | */ |
1309 | new = list_entry(inode->i_dentry.next, struct dentry, d_alias); | 1302 | new = list_entry(inode->i_dentry.next, struct dentry, d_alias); |
1310 | dget_locked(new); | 1303 | dget_locked(new); |
1311 | spin_unlock(&dcache_lock); | 1304 | spin_unlock(&dcache_lock); |
1312 | /* Do security vodoo. */ | ||
1313 | security_d_instantiate(found, inode); | 1305 | security_d_instantiate(found, inode); |
1314 | /* Move new in place of found. */ | ||
1315 | d_move(new, found); | 1306 | d_move(new, found); |
1316 | /* Balance the iget() we did above. */ | ||
1317 | iput(inode); | 1307 | iput(inode); |
1318 | /* Throw away found. */ | ||
1319 | dput(found); | 1308 | dput(found); |
1320 | /* Use new as the actual dentry. */ | ||
1321 | return new; | 1309 | return new; |
1322 | 1310 | ||
1323 | err_out: | 1311 | err_out: |
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index bff4052b05e7..63a4a59e4148 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c | |||
@@ -322,177 +322,81 @@ static int compare_init_pts_sb(struct super_block *s, void *p) | |||
322 | } | 322 | } |
323 | 323 | ||
324 | /* | 324 | /* |
325 | * Safely parse the mount options in @data and update @opts. | 325 | * devpts_get_sb() |
326 | * | 326 | * |
327 | * devpts ends up parsing options two times during mount, due to the | 327 | * If the '-o newinstance' mount option was specified, mount a new |
328 | * two modes of operation it supports. The first parse occurs in | 328 | * (private) instance of devpts. PTYs created in this instance are |
329 | * devpts_get_sb() when determining the mode (single-instance or | 329 | * independent of the PTYs in other devpts instances. |
330 | * multi-instance mode). The second parse happens in devpts_remount() | ||
331 | * or new_pts_mount() depending on the mode. | ||
332 | * | 330 | * |
333 | * Parsing of options modifies the @data making subsequent parsing | 331 | * If the '-o newinstance' option was not specified, mount/remount the |
334 | * incorrect. So make a local copy of @data and parse it. | 332 | * initial kernel mount of devpts. This type of mount gives the |
333 | * legacy, single-instance semantics. | ||
335 | * | 334 | * |
336 | * Return: 0 On success, -errno on error | 335 | * The 'newinstance' option is needed to support multiple namespace |
337 | */ | 336 | * semantics in devpts while preserving backward compatibility of the |
338 | static int safe_parse_mount_options(void *data, struct pts_mount_opts *opts) | 337 | * current 'single-namespace' semantics. i.e all mounts of devpts |
339 | { | 338 | * without the 'newinstance' mount option should bind to the initial |
340 | int rc; | 339 | * kernel mount, like get_sb_single(). |
341 | void *datacp; | ||
342 | |||
343 | if (!data) | ||
344 | return 0; | ||
345 | |||
346 | /* Use kstrdup() ? */ | ||
347 | datacp = kmalloc(PAGE_SIZE, GFP_KERNEL); | ||
348 | if (!datacp) | ||
349 | return -ENOMEM; | ||
350 | |||
351 | memcpy(datacp, data, PAGE_SIZE); | ||
352 | rc = parse_mount_options((char *)datacp, PARSE_MOUNT, opts); | ||
353 | kfree(datacp); | ||
354 | |||
355 | return rc; | ||
356 | } | ||
357 | |||
358 | /* | ||
359 | * Mount a new (private) instance of devpts. PTYs created in this | ||
360 | * instance are independent of the PTYs in other devpts instances. | ||
361 | */ | ||
362 | static int new_pts_mount(struct file_system_type *fs_type, int flags, | ||
363 | void *data, struct vfsmount *mnt) | ||
364 | { | ||
365 | int err; | ||
366 | struct pts_fs_info *fsi; | ||
367 | struct pts_mount_opts *opts; | ||
368 | |||
369 | err = get_sb_nodev(fs_type, flags, data, devpts_fill_super, mnt); | ||
370 | if (err) | ||
371 | return err; | ||
372 | |||
373 | fsi = DEVPTS_SB(mnt->mnt_sb); | ||
374 | opts = &fsi->mount_opts; | ||
375 | |||
376 | err = parse_mount_options(data, PARSE_MOUNT, opts); | ||
377 | if (err) | ||
378 | goto fail; | ||
379 | |||
380 | err = mknod_ptmx(mnt->mnt_sb); | ||
381 | if (err) | ||
382 | goto fail; | ||
383 | |||
384 | return 0; | ||
385 | |||
386 | fail: | ||
387 | dput(mnt->mnt_sb->s_root); | ||
388 | deactivate_super(mnt->mnt_sb); | ||
389 | return err; | ||
390 | } | ||
391 | |||
392 | /* | ||
393 | * Check if 'newinstance' mount option was specified in @data. | ||
394 | * | 340 | * |
395 | * Return: -errno on error (eg: invalid mount options specified) | 341 | * Mounts with 'newinstance' option create a new, private namespace. |
396 | * : 1 if 'newinstance' mount option was specified | ||
397 | * : 0 if 'newinstance' mount option was NOT specified | ||
398 | */ | ||
399 | static int is_new_instance_mount(void *data) | ||
400 | { | ||
401 | int rc; | ||
402 | struct pts_mount_opts opts; | ||
403 | |||
404 | if (!data) | ||
405 | return 0; | ||
406 | |||
407 | rc = safe_parse_mount_options(data, &opts); | ||
408 | if (!rc) | ||
409 | rc = opts.newinstance; | ||
410 | |||
411 | return rc; | ||
412 | } | ||
413 | |||
414 | /* | ||
415 | * get_init_pts_sb() | ||
416 | * | ||
417 | * This interface is needed to support multiple namespace semantics in | ||
418 | * devpts while preserving backward compatibility of the current 'single- | ||
419 | * namespace' semantics. i.e all mounts of devpts without the 'newinstance' | ||
420 | * mount option should bind to the initial kernel mount, like | ||
421 | * get_sb_single(). | ||
422 | * | 342 | * |
423 | * Mounts with 'newinstance' option create a new private namespace. | 343 | * NOTE: |
424 | * | 344 | * |
425 | * But for single-mount semantics, devpts cannot use get_sb_single(), | 345 | * For single-mount semantics, devpts cannot use get_sb_single(), |
426 | * because get_sb_single()/sget() find and use the super-block from | 346 | * because get_sb_single()/sget() find and use the super-block from |
427 | * the most recent mount of devpts. But that recent mount may be a | 347 | * the most recent mount of devpts. But that recent mount may be a |
428 | * 'newinstance' mount and get_sb_single() would pick the newinstance | 348 | * 'newinstance' mount and get_sb_single() would pick the newinstance |
429 | * super-block instead of the initial super-block. | 349 | * super-block instead of the initial super-block. |
430 | * | ||
431 | * This interface is identical to get_sb_single() except that it | ||
432 | * consistently selects the 'single-namespace' superblock even in the | ||
433 | * presence of the private namespace (i.e 'newinstance') super-blocks. | ||
434 | */ | 350 | */ |
435 | static int get_init_pts_sb(struct file_system_type *fs_type, int flags, | 351 | static int devpts_get_sb(struct file_system_type *fs_type, |
436 | void *data, struct vfsmount *mnt) | 352 | int flags, const char *dev_name, void *data, struct vfsmount *mnt) |
437 | { | 353 | { |
438 | struct super_block *s; | ||
439 | int error; | 354 | int error; |
355 | struct pts_mount_opts opts; | ||
356 | struct super_block *s; | ||
357 | |||
358 | memset(&opts, 0, sizeof(opts)); | ||
359 | if (data) { | ||
360 | error = parse_mount_options(data, PARSE_MOUNT, &opts); | ||
361 | if (error) | ||
362 | return error; | ||
363 | } | ||
364 | |||
365 | if (opts.newinstance) | ||
366 | s = sget(fs_type, NULL, set_anon_super, NULL); | ||
367 | else | ||
368 | s = sget(fs_type, compare_init_pts_sb, set_anon_super, NULL); | ||
440 | 369 | ||
441 | s = sget(fs_type, compare_init_pts_sb, set_anon_super, NULL); | ||
442 | if (IS_ERR(s)) | 370 | if (IS_ERR(s)) |
443 | return PTR_ERR(s); | 371 | return PTR_ERR(s); |
444 | 372 | ||
445 | if (!s->s_root) { | 373 | if (!s->s_root) { |
446 | s->s_flags = flags; | 374 | s->s_flags = flags; |
447 | error = devpts_fill_super(s, data, flags & MS_SILENT ? 1 : 0); | 375 | error = devpts_fill_super(s, data, flags & MS_SILENT ? 1 : 0); |
448 | if (error) { | 376 | if (error) |
449 | up_write(&s->s_umount); | 377 | goto out_undo_sget; |
450 | deactivate_super(s); | ||
451 | return error; | ||
452 | } | ||
453 | s->s_flags |= MS_ACTIVE; | 378 | s->s_flags |= MS_ACTIVE; |
454 | } | 379 | } |
455 | do_remount_sb(s, flags, data, 0); | ||
456 | return simple_set_mnt(mnt, s); | ||
457 | } | ||
458 | 380 | ||
459 | /* | 381 | simple_set_mnt(mnt, s); |
460 | * Mount or remount the initial kernel mount of devpts. This type of | ||
461 | * mount maintains the legacy, single-instance semantics, while the | ||
462 | * kernel still allows multiple-instances. | ||
463 | */ | ||
464 | static int init_pts_mount(struct file_system_type *fs_type, int flags, | ||
465 | void *data, struct vfsmount *mnt) | ||
466 | { | ||
467 | int err; | ||
468 | 382 | ||
469 | err = get_init_pts_sb(fs_type, flags, data, mnt); | 383 | memcpy(&(DEVPTS_SB(s))->mount_opts, &opts, sizeof(opts)); |
470 | if (err) | ||
471 | return err; | ||
472 | 384 | ||
473 | err = mknod_ptmx(mnt->mnt_sb); | 385 | error = mknod_ptmx(s); |
474 | if (err) { | 386 | if (error) |
475 | dput(mnt->mnt_sb->s_root); | 387 | goto out_dput; |
476 | deactivate_super(mnt->mnt_sb); | ||
477 | } | ||
478 | 388 | ||
479 | return err; | 389 | return 0; |
480 | } | ||
481 | |||
482 | static int devpts_get_sb(struct file_system_type *fs_type, | ||
483 | int flags, const char *dev_name, void *data, struct vfsmount *mnt) | ||
484 | { | ||
485 | int new; | ||
486 | |||
487 | new = is_new_instance_mount(data); | ||
488 | if (new < 0) | ||
489 | return new; | ||
490 | 390 | ||
491 | if (new) | 391 | out_dput: |
492 | return new_pts_mount(fs_type, flags, data, mnt); | 392 | dput(s->s_root); |
493 | 393 | ||
494 | return init_pts_mount(fs_type, flags, data, mnt); | 394 | out_undo_sget: |
395 | up_write(&s->s_umount); | ||
396 | deactivate_super(s); | ||
397 | return error; | ||
495 | } | 398 | } |
399 | |||
496 | #else | 400 | #else |
497 | /* | 401 | /* |
498 | * This supports only the legacy single-instance semantics (no | 402 | * This supports only the legacy single-instance semantics (no |
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c index 92969f879a17..858fba14aaa6 100644 --- a/fs/dlm/dir.c +++ b/fs/dlm/dir.c | |||
@@ -156,7 +156,7 @@ void dlm_dir_remove_entry(struct dlm_ls *ls, int nodeid, char *name, int namelen | |||
156 | 156 | ||
157 | bucket = dir_hash(ls, name, namelen); | 157 | bucket = dir_hash(ls, name, namelen); |
158 | 158 | ||
159 | write_lock(&ls->ls_dirtbl[bucket].lock); | 159 | spin_lock(&ls->ls_dirtbl[bucket].lock); |
160 | 160 | ||
161 | de = search_bucket(ls, name, namelen, bucket); | 161 | de = search_bucket(ls, name, namelen, bucket); |
162 | 162 | ||
@@ -173,7 +173,7 @@ void dlm_dir_remove_entry(struct dlm_ls *ls, int nodeid, char *name, int namelen | |||
173 | list_del(&de->list); | 173 | list_del(&de->list); |
174 | kfree(de); | 174 | kfree(de); |
175 | out: | 175 | out: |
176 | write_unlock(&ls->ls_dirtbl[bucket].lock); | 176 | spin_unlock(&ls->ls_dirtbl[bucket].lock); |
177 | } | 177 | } |
178 | 178 | ||
179 | void dlm_dir_clear(struct dlm_ls *ls) | 179 | void dlm_dir_clear(struct dlm_ls *ls) |
@@ -185,14 +185,14 @@ void dlm_dir_clear(struct dlm_ls *ls) | |||
185 | DLM_ASSERT(list_empty(&ls->ls_recover_list), ); | 185 | DLM_ASSERT(list_empty(&ls->ls_recover_list), ); |
186 | 186 | ||
187 | for (i = 0; i < ls->ls_dirtbl_size; i++) { | 187 | for (i = 0; i < ls->ls_dirtbl_size; i++) { |
188 | write_lock(&ls->ls_dirtbl[i].lock); | 188 | spin_lock(&ls->ls_dirtbl[i].lock); |
189 | head = &ls->ls_dirtbl[i].list; | 189 | head = &ls->ls_dirtbl[i].list; |
190 | while (!list_empty(head)) { | 190 | while (!list_empty(head)) { |
191 | de = list_entry(head->next, struct dlm_direntry, list); | 191 | de = list_entry(head->next, struct dlm_direntry, list); |
192 | list_del(&de->list); | 192 | list_del(&de->list); |
193 | put_free_de(ls, de); | 193 | put_free_de(ls, de); |
194 | } | 194 | } |
195 | write_unlock(&ls->ls_dirtbl[i].lock); | 195 | spin_unlock(&ls->ls_dirtbl[i].lock); |
196 | } | 196 | } |
197 | } | 197 | } |
198 | 198 | ||
@@ -307,17 +307,17 @@ static int get_entry(struct dlm_ls *ls, int nodeid, char *name, | |||
307 | 307 | ||
308 | bucket = dir_hash(ls, name, namelen); | 308 | bucket = dir_hash(ls, name, namelen); |
309 | 309 | ||
310 | write_lock(&ls->ls_dirtbl[bucket].lock); | 310 | spin_lock(&ls->ls_dirtbl[bucket].lock); |
311 | de = search_bucket(ls, name, namelen, bucket); | 311 | de = search_bucket(ls, name, namelen, bucket); |
312 | if (de) { | 312 | if (de) { |
313 | *r_nodeid = de->master_nodeid; | 313 | *r_nodeid = de->master_nodeid; |
314 | write_unlock(&ls->ls_dirtbl[bucket].lock); | 314 | spin_unlock(&ls->ls_dirtbl[bucket].lock); |
315 | if (*r_nodeid == nodeid) | 315 | if (*r_nodeid == nodeid) |
316 | return -EEXIST; | 316 | return -EEXIST; |
317 | return 0; | 317 | return 0; |
318 | } | 318 | } |
319 | 319 | ||
320 | write_unlock(&ls->ls_dirtbl[bucket].lock); | 320 | spin_unlock(&ls->ls_dirtbl[bucket].lock); |
321 | 321 | ||
322 | if (namelen > DLM_RESNAME_MAXLEN) | 322 | if (namelen > DLM_RESNAME_MAXLEN) |
323 | return -EINVAL; | 323 | return -EINVAL; |
@@ -330,7 +330,7 @@ static int get_entry(struct dlm_ls *ls, int nodeid, char *name, | |||
330 | de->length = namelen; | 330 | de->length = namelen; |
331 | memcpy(de->name, name, namelen); | 331 | memcpy(de->name, name, namelen); |
332 | 332 | ||
333 | write_lock(&ls->ls_dirtbl[bucket].lock); | 333 | spin_lock(&ls->ls_dirtbl[bucket].lock); |
334 | tmp = search_bucket(ls, name, namelen, bucket); | 334 | tmp = search_bucket(ls, name, namelen, bucket); |
335 | if (tmp) { | 335 | if (tmp) { |
336 | kfree(de); | 336 | kfree(de); |
@@ -339,7 +339,7 @@ static int get_entry(struct dlm_ls *ls, int nodeid, char *name, | |||
339 | list_add_tail(&de->list, &ls->ls_dirtbl[bucket].list); | 339 | list_add_tail(&de->list, &ls->ls_dirtbl[bucket].list); |
340 | } | 340 | } |
341 | *r_nodeid = de->master_nodeid; | 341 | *r_nodeid = de->master_nodeid; |
342 | write_unlock(&ls->ls_dirtbl[bucket].lock); | 342 | spin_unlock(&ls->ls_dirtbl[bucket].lock); |
343 | return 0; | 343 | return 0; |
344 | } | 344 | } |
345 | 345 | ||
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h index 076e86f38bc8..d01ca0a711db 100644 --- a/fs/dlm/dlm_internal.h +++ b/fs/dlm/dlm_internal.h | |||
@@ -99,7 +99,7 @@ struct dlm_direntry { | |||
99 | 99 | ||
100 | struct dlm_dirtable { | 100 | struct dlm_dirtable { |
101 | struct list_head list; | 101 | struct list_head list; |
102 | rwlock_t lock; | 102 | spinlock_t lock; |
103 | }; | 103 | }; |
104 | 104 | ||
105 | struct dlm_rsbtable { | 105 | struct dlm_rsbtable { |
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 01e7d39c5fba..205ec95b347e 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c | |||
@@ -835,7 +835,7 @@ static int add_to_waiters(struct dlm_lkb *lkb, int mstype) | |||
835 | lkb->lkb_wait_count++; | 835 | lkb->lkb_wait_count++; |
836 | hold_lkb(lkb); | 836 | hold_lkb(lkb); |
837 | 837 | ||
838 | log_debug(ls, "add overlap %x cur %d new %d count %d flags %x", | 838 | log_debug(ls, "addwait %x cur %d overlap %d count %d f %x", |
839 | lkb->lkb_id, lkb->lkb_wait_type, mstype, | 839 | lkb->lkb_id, lkb->lkb_wait_type, mstype, |
840 | lkb->lkb_wait_count, lkb->lkb_flags); | 840 | lkb->lkb_wait_count, lkb->lkb_flags); |
841 | goto out; | 841 | goto out; |
@@ -851,7 +851,7 @@ static int add_to_waiters(struct dlm_lkb *lkb, int mstype) | |||
851 | list_add(&lkb->lkb_wait_reply, &ls->ls_waiters); | 851 | list_add(&lkb->lkb_wait_reply, &ls->ls_waiters); |
852 | out: | 852 | out: |
853 | if (error) | 853 | if (error) |
854 | log_error(ls, "add_to_waiters %x error %d flags %x %d %d %s", | 854 | log_error(ls, "addwait error %x %d flags %x %d %d %s", |
855 | lkb->lkb_id, error, lkb->lkb_flags, mstype, | 855 | lkb->lkb_id, error, lkb->lkb_flags, mstype, |
856 | lkb->lkb_wait_type, lkb->lkb_resource->res_name); | 856 | lkb->lkb_wait_type, lkb->lkb_resource->res_name); |
857 | mutex_unlock(&ls->ls_waiters_mutex); | 857 | mutex_unlock(&ls->ls_waiters_mutex); |
@@ -863,23 +863,55 @@ static int add_to_waiters(struct dlm_lkb *lkb, int mstype) | |||
863 | request reply on the requestqueue) between dlm_recover_waiters_pre() which | 863 | request reply on the requestqueue) between dlm_recover_waiters_pre() which |
864 | set RESEND and dlm_recover_waiters_post() */ | 864 | set RESEND and dlm_recover_waiters_post() */ |
865 | 865 | ||
866 | static int _remove_from_waiters(struct dlm_lkb *lkb, int mstype) | 866 | static int _remove_from_waiters(struct dlm_lkb *lkb, int mstype, |
867 | struct dlm_message *ms) | ||
867 | { | 868 | { |
868 | struct dlm_ls *ls = lkb->lkb_resource->res_ls; | 869 | struct dlm_ls *ls = lkb->lkb_resource->res_ls; |
869 | int overlap_done = 0; | 870 | int overlap_done = 0; |
870 | 871 | ||
871 | if (is_overlap_unlock(lkb) && (mstype == DLM_MSG_UNLOCK_REPLY)) { | 872 | if (is_overlap_unlock(lkb) && (mstype == DLM_MSG_UNLOCK_REPLY)) { |
873 | log_debug(ls, "remwait %x unlock_reply overlap", lkb->lkb_id); | ||
872 | lkb->lkb_flags &= ~DLM_IFL_OVERLAP_UNLOCK; | 874 | lkb->lkb_flags &= ~DLM_IFL_OVERLAP_UNLOCK; |
873 | overlap_done = 1; | 875 | overlap_done = 1; |
874 | goto out_del; | 876 | goto out_del; |
875 | } | 877 | } |
876 | 878 | ||
877 | if (is_overlap_cancel(lkb) && (mstype == DLM_MSG_CANCEL_REPLY)) { | 879 | if (is_overlap_cancel(lkb) && (mstype == DLM_MSG_CANCEL_REPLY)) { |
880 | log_debug(ls, "remwait %x cancel_reply overlap", lkb->lkb_id); | ||
878 | lkb->lkb_flags &= ~DLM_IFL_OVERLAP_CANCEL; | 881 | lkb->lkb_flags &= ~DLM_IFL_OVERLAP_CANCEL; |
879 | overlap_done = 1; | 882 | overlap_done = 1; |
880 | goto out_del; | 883 | goto out_del; |
881 | } | 884 | } |
882 | 885 | ||
886 | /* Cancel state was preemptively cleared by a successful convert, | ||
887 | see next comment, nothing to do. */ | ||
888 | |||
889 | if ((mstype == DLM_MSG_CANCEL_REPLY) && | ||
890 | (lkb->lkb_wait_type != DLM_MSG_CANCEL)) { | ||
891 | log_debug(ls, "remwait %x cancel_reply wait_type %d", | ||
892 | lkb->lkb_id, lkb->lkb_wait_type); | ||
893 | return -1; | ||
894 | } | ||
895 | |||
896 | /* Remove for the convert reply, and premptively remove for the | ||
897 | cancel reply. A convert has been granted while there's still | ||
898 | an outstanding cancel on it (the cancel is moot and the result | ||
899 | in the cancel reply should be 0). We preempt the cancel reply | ||
900 | because the app gets the convert result and then can follow up | ||
901 | with another op, like convert. This subsequent op would see the | ||
902 | lingering state of the cancel and fail with -EBUSY. */ | ||
903 | |||
904 | if ((mstype == DLM_MSG_CONVERT_REPLY) && | ||
905 | (lkb->lkb_wait_type == DLM_MSG_CONVERT) && | ||
906 | is_overlap_cancel(lkb) && ms && !ms->m_result) { | ||
907 | log_debug(ls, "remwait %x convert_reply zap overlap_cancel", | ||
908 | lkb->lkb_id); | ||
909 | lkb->lkb_wait_type = 0; | ||
910 | lkb->lkb_flags &= ~DLM_IFL_OVERLAP_CANCEL; | ||
911 | lkb->lkb_wait_count--; | ||
912 | goto out_del; | ||
913 | } | ||
914 | |||
883 | /* N.B. type of reply may not always correspond to type of original | 915 | /* N.B. type of reply may not always correspond to type of original |
884 | msg due to lookup->request optimization, verify others? */ | 916 | msg due to lookup->request optimization, verify others? */ |
885 | 917 | ||
@@ -888,8 +920,8 @@ static int _remove_from_waiters(struct dlm_lkb *lkb, int mstype) | |||
888 | goto out_del; | 920 | goto out_del; |
889 | } | 921 | } |
890 | 922 | ||
891 | log_error(ls, "remove_from_waiters lkid %x flags %x types %d %d", | 923 | log_error(ls, "remwait error %x reply %d flags %x no wait_type", |
892 | lkb->lkb_id, lkb->lkb_flags, mstype, lkb->lkb_wait_type); | 924 | lkb->lkb_id, mstype, lkb->lkb_flags); |
893 | return -1; | 925 | return -1; |
894 | 926 | ||
895 | out_del: | 927 | out_del: |
@@ -899,7 +931,7 @@ static int _remove_from_waiters(struct dlm_lkb *lkb, int mstype) | |||
899 | this would happen */ | 931 | this would happen */ |
900 | 932 | ||
901 | if (overlap_done && lkb->lkb_wait_type) { | 933 | if (overlap_done && lkb->lkb_wait_type) { |
902 | log_error(ls, "remove_from_waiters %x reply %d give up on %d", | 934 | log_error(ls, "remwait error %x reply %d wait_type %d overlap", |
903 | lkb->lkb_id, mstype, lkb->lkb_wait_type); | 935 | lkb->lkb_id, mstype, lkb->lkb_wait_type); |
904 | lkb->lkb_wait_count--; | 936 | lkb->lkb_wait_count--; |
905 | lkb->lkb_wait_type = 0; | 937 | lkb->lkb_wait_type = 0; |
@@ -921,7 +953,7 @@ static int remove_from_waiters(struct dlm_lkb *lkb, int mstype) | |||
921 | int error; | 953 | int error; |
922 | 954 | ||
923 | mutex_lock(&ls->ls_waiters_mutex); | 955 | mutex_lock(&ls->ls_waiters_mutex); |
924 | error = _remove_from_waiters(lkb, mstype); | 956 | error = _remove_from_waiters(lkb, mstype, NULL); |
925 | mutex_unlock(&ls->ls_waiters_mutex); | 957 | mutex_unlock(&ls->ls_waiters_mutex); |
926 | return error; | 958 | return error; |
927 | } | 959 | } |
@@ -936,7 +968,7 @@ static int remove_from_waiters_ms(struct dlm_lkb *lkb, struct dlm_message *ms) | |||
936 | 968 | ||
937 | if (ms != &ls->ls_stub_ms) | 969 | if (ms != &ls->ls_stub_ms) |
938 | mutex_lock(&ls->ls_waiters_mutex); | 970 | mutex_lock(&ls->ls_waiters_mutex); |
939 | error = _remove_from_waiters(lkb, ms->m_type); | 971 | error = _remove_from_waiters(lkb, ms->m_type, ms); |
940 | if (ms != &ls->ls_stub_ms) | 972 | if (ms != &ls->ls_stub_ms) |
941 | mutex_unlock(&ls->ls_waiters_mutex); | 973 | mutex_unlock(&ls->ls_waiters_mutex); |
942 | return error; | 974 | return error; |
@@ -2083,6 +2115,11 @@ static int validate_lock_args(struct dlm_ls *ls, struct dlm_lkb *lkb, | |||
2083 | lkb->lkb_timeout_cs = args->timeout; | 2115 | lkb->lkb_timeout_cs = args->timeout; |
2084 | rv = 0; | 2116 | rv = 0; |
2085 | out: | 2117 | out: |
2118 | if (rv) | ||
2119 | log_debug(ls, "validate_lock_args %d %x %x %x %d %d %s", | ||
2120 | rv, lkb->lkb_id, lkb->lkb_flags, args->flags, | ||
2121 | lkb->lkb_status, lkb->lkb_wait_type, | ||
2122 | lkb->lkb_resource->res_name); | ||
2086 | return rv; | 2123 | return rv; |
2087 | } | 2124 | } |
2088 | 2125 | ||
@@ -2149,6 +2186,13 @@ static int validate_unlock_args(struct dlm_lkb *lkb, struct dlm_args *args) | |||
2149 | goto out; | 2186 | goto out; |
2150 | } | 2187 | } |
2151 | 2188 | ||
2189 | /* there's nothing to cancel */ | ||
2190 | if (lkb->lkb_status == DLM_LKSTS_GRANTED && | ||
2191 | !lkb->lkb_wait_type) { | ||
2192 | rv = -EBUSY; | ||
2193 | goto out; | ||
2194 | } | ||
2195 | |||
2152 | switch (lkb->lkb_wait_type) { | 2196 | switch (lkb->lkb_wait_type) { |
2153 | case DLM_MSG_LOOKUP: | 2197 | case DLM_MSG_LOOKUP: |
2154 | case DLM_MSG_REQUEST: | 2198 | case DLM_MSG_REQUEST: |
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index aa32e5f02493..cd8e2df3c295 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c | |||
@@ -487,7 +487,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace, | |||
487 | goto out_lkbfree; | 487 | goto out_lkbfree; |
488 | for (i = 0; i < size; i++) { | 488 | for (i = 0; i < size; i++) { |
489 | INIT_LIST_HEAD(&ls->ls_dirtbl[i].list); | 489 | INIT_LIST_HEAD(&ls->ls_dirtbl[i].list); |
490 | rwlock_init(&ls->ls_dirtbl[i].lock); | 490 | spin_lock_init(&ls->ls_dirtbl[i].lock); |
491 | } | 491 | } |
492 | 492 | ||
493 | INIT_LIST_HEAD(&ls->ls_waiters); | 493 | INIT_LIST_HEAD(&ls->ls_waiters); |
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 103a5ebd1371..609108a83267 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c | |||
@@ -2,7 +2,7 @@ | |||
2 | ******************************************************************************* | 2 | ******************************************************************************* |
3 | ** | 3 | ** |
4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | 4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. |
5 | ** Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. | 5 | ** Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved. |
6 | ** | 6 | ** |
7 | ** This copyrighted material is made available to anyone wishing to use, | 7 | ** This copyrighted material is made available to anyone wishing to use, |
8 | ** modify, copy, or redistribute it subject to the terms and conditions | 8 | ** modify, copy, or redistribute it subject to the terms and conditions |
@@ -21,7 +21,7 @@ | |||
21 | * | 21 | * |
22 | * Cluster nodes are referred to by their nodeids. nodeids are | 22 | * Cluster nodes are referred to by their nodeids. nodeids are |
23 | * simply 32 bit numbers to the locking module - if they need to | 23 | * simply 32 bit numbers to the locking module - if they need to |
24 | * be expanded for the cluster infrastructure then that is it's | 24 | * be expanded for the cluster infrastructure then that is its |
25 | * responsibility. It is this layer's | 25 | * responsibility. It is this layer's |
26 | * responsibility to resolve these into IP address or | 26 | * responsibility to resolve these into IP address or |
27 | * whatever it needs for inter-node communication. | 27 | * whatever it needs for inter-node communication. |
@@ -36,9 +36,9 @@ | |||
36 | * of high load. Also, this way, the sending thread can collect together | 36 | * of high load. Also, this way, the sending thread can collect together |
37 | * messages bound for one node and send them in one block. | 37 | * messages bound for one node and send them in one block. |
38 | * | 38 | * |
39 | * lowcomms will choose to use wither TCP or SCTP as its transport layer | 39 | * lowcomms will choose to use either TCP or SCTP as its transport layer |
40 | * depending on the configuration variable 'protocol'. This should be set | 40 | * depending on the configuration variable 'protocol'. This should be set |
41 | * to 0 (default) for TCP or 1 for SCTP. It shouldbe configured using a | 41 | * to 0 (default) for TCP or 1 for SCTP. It should be configured using a |
42 | * cluster-wide mechanism as it must be the same on all nodes of the cluster | 42 | * cluster-wide mechanism as it must be the same on all nodes of the cluster |
43 | * for the DLM to function. | 43 | * for the DLM to function. |
44 | * | 44 | * |
@@ -48,11 +48,11 @@ | |||
48 | #include <net/sock.h> | 48 | #include <net/sock.h> |
49 | #include <net/tcp.h> | 49 | #include <net/tcp.h> |
50 | #include <linux/pagemap.h> | 50 | #include <linux/pagemap.h> |
51 | #include <linux/idr.h> | ||
52 | #include <linux/file.h> | 51 | #include <linux/file.h> |
53 | #include <linux/mutex.h> | 52 | #include <linux/mutex.h> |
54 | #include <linux/sctp.h> | 53 | #include <linux/sctp.h> |
55 | #include <net/sctp/user.h> | 54 | #include <net/sctp/user.h> |
55 | #include <net/ipv6.h> | ||
56 | 56 | ||
57 | #include "dlm_internal.h" | 57 | #include "dlm_internal.h" |
58 | #include "lowcomms.h" | 58 | #include "lowcomms.h" |
@@ -60,6 +60,7 @@ | |||
60 | #include "config.h" | 60 | #include "config.h" |
61 | 61 | ||
62 | #define NEEDED_RMEM (4*1024*1024) | 62 | #define NEEDED_RMEM (4*1024*1024) |
63 | #define CONN_HASH_SIZE 32 | ||
63 | 64 | ||
64 | struct cbuf { | 65 | struct cbuf { |
65 | unsigned int base; | 66 | unsigned int base; |
@@ -114,6 +115,7 @@ struct connection { | |||
114 | int retries; | 115 | int retries; |
115 | #define MAX_CONNECT_RETRIES 3 | 116 | #define MAX_CONNECT_RETRIES 3 |
116 | int sctp_assoc; | 117 | int sctp_assoc; |
118 | struct hlist_node list; | ||
117 | struct connection *othercon; | 119 | struct connection *othercon; |
118 | struct work_struct rwork; /* Receive workqueue */ | 120 | struct work_struct rwork; /* Receive workqueue */ |
119 | struct work_struct swork; /* Send workqueue */ | 121 | struct work_struct swork; /* Send workqueue */ |
@@ -138,14 +140,37 @@ static int dlm_local_count; | |||
138 | static struct workqueue_struct *recv_workqueue; | 140 | static struct workqueue_struct *recv_workqueue; |
139 | static struct workqueue_struct *send_workqueue; | 141 | static struct workqueue_struct *send_workqueue; |
140 | 142 | ||
141 | static DEFINE_IDR(connections_idr); | 143 | static struct hlist_head connection_hash[CONN_HASH_SIZE]; |
142 | static DEFINE_MUTEX(connections_lock); | 144 | static DEFINE_MUTEX(connections_lock); |
143 | static int max_nodeid; | ||
144 | static struct kmem_cache *con_cache; | 145 | static struct kmem_cache *con_cache; |
145 | 146 | ||
146 | static void process_recv_sockets(struct work_struct *work); | 147 | static void process_recv_sockets(struct work_struct *work); |
147 | static void process_send_sockets(struct work_struct *work); | 148 | static void process_send_sockets(struct work_struct *work); |
148 | 149 | ||
150 | |||
151 | /* This is deliberately very simple because most clusters have simple | ||
152 | sequential nodeids, so we should be able to go straight to a connection | ||
153 | struct in the array */ | ||
154 | static inline int nodeid_hash(int nodeid) | ||
155 | { | ||
156 | return nodeid & (CONN_HASH_SIZE-1); | ||
157 | } | ||
158 | |||
159 | static struct connection *__find_con(int nodeid) | ||
160 | { | ||
161 | int r; | ||
162 | struct hlist_node *h; | ||
163 | struct connection *con; | ||
164 | |||
165 | r = nodeid_hash(nodeid); | ||
166 | |||
167 | hlist_for_each_entry(con, h, &connection_hash[r], list) { | ||
168 | if (con->nodeid == nodeid) | ||
169 | return con; | ||
170 | } | ||
171 | return NULL; | ||
172 | } | ||
173 | |||
149 | /* | 174 | /* |
150 | * If 'allocation' is zero then we don't attempt to create a new | 175 | * If 'allocation' is zero then we don't attempt to create a new |
151 | * connection structure for this node. | 176 | * connection structure for this node. |
@@ -154,31 +179,17 @@ static struct connection *__nodeid2con(int nodeid, gfp_t alloc) | |||
154 | { | 179 | { |
155 | struct connection *con = NULL; | 180 | struct connection *con = NULL; |
156 | int r; | 181 | int r; |
157 | int n; | ||
158 | 182 | ||
159 | con = idr_find(&connections_idr, nodeid); | 183 | con = __find_con(nodeid); |
160 | if (con || !alloc) | 184 | if (con || !alloc) |
161 | return con; | 185 | return con; |
162 | 186 | ||
163 | r = idr_pre_get(&connections_idr, alloc); | ||
164 | if (!r) | ||
165 | return NULL; | ||
166 | |||
167 | con = kmem_cache_zalloc(con_cache, alloc); | 187 | con = kmem_cache_zalloc(con_cache, alloc); |
168 | if (!con) | 188 | if (!con) |
169 | return NULL; | 189 | return NULL; |
170 | 190 | ||
171 | r = idr_get_new_above(&connections_idr, con, nodeid, &n); | 191 | r = nodeid_hash(nodeid); |
172 | if (r) { | 192 | hlist_add_head(&con->list, &connection_hash[r]); |
173 | kmem_cache_free(con_cache, con); | ||
174 | return NULL; | ||
175 | } | ||
176 | |||
177 | if (n != nodeid) { | ||
178 | idr_remove(&connections_idr, n); | ||
179 | kmem_cache_free(con_cache, con); | ||
180 | return NULL; | ||
181 | } | ||
182 | 193 | ||
183 | con->nodeid = nodeid; | 194 | con->nodeid = nodeid; |
184 | mutex_init(&con->sock_mutex); | 195 | mutex_init(&con->sock_mutex); |
@@ -189,19 +200,30 @@ static struct connection *__nodeid2con(int nodeid, gfp_t alloc) | |||
189 | 200 | ||
190 | /* Setup action pointers for child sockets */ | 201 | /* Setup action pointers for child sockets */ |
191 | if (con->nodeid) { | 202 | if (con->nodeid) { |
192 | struct connection *zerocon = idr_find(&connections_idr, 0); | 203 | struct connection *zerocon = __find_con(0); |
193 | 204 | ||
194 | con->connect_action = zerocon->connect_action; | 205 | con->connect_action = zerocon->connect_action; |
195 | if (!con->rx_action) | 206 | if (!con->rx_action) |
196 | con->rx_action = zerocon->rx_action; | 207 | con->rx_action = zerocon->rx_action; |
197 | } | 208 | } |
198 | 209 | ||
199 | if (nodeid > max_nodeid) | ||
200 | max_nodeid = nodeid; | ||
201 | |||
202 | return con; | 210 | return con; |
203 | } | 211 | } |
204 | 212 | ||
213 | /* Loop round all connections */ | ||
214 | static void foreach_conn(void (*conn_func)(struct connection *c)) | ||
215 | { | ||
216 | int i; | ||
217 | struct hlist_node *h, *n; | ||
218 | struct connection *con; | ||
219 | |||
220 | for (i = 0; i < CONN_HASH_SIZE; i++) { | ||
221 | hlist_for_each_entry_safe(con, h, n, &connection_hash[i], list){ | ||
222 | conn_func(con); | ||
223 | } | ||
224 | } | ||
225 | } | ||
226 | |||
205 | static struct connection *nodeid2con(int nodeid, gfp_t allocation) | 227 | static struct connection *nodeid2con(int nodeid, gfp_t allocation) |
206 | { | 228 | { |
207 | struct connection *con; | 229 | struct connection *con; |
@@ -217,14 +239,17 @@ static struct connection *nodeid2con(int nodeid, gfp_t allocation) | |||
217 | static struct connection *assoc2con(int assoc_id) | 239 | static struct connection *assoc2con(int assoc_id) |
218 | { | 240 | { |
219 | int i; | 241 | int i; |
242 | struct hlist_node *h; | ||
220 | struct connection *con; | 243 | struct connection *con; |
221 | 244 | ||
222 | mutex_lock(&connections_lock); | 245 | mutex_lock(&connections_lock); |
223 | for (i=0; i<=max_nodeid; i++) { | 246 | |
224 | con = __nodeid2con(i, 0); | 247 | for (i = 0 ; i < CONN_HASH_SIZE; i++) { |
225 | if (con && con->sctp_assoc == assoc_id) { | 248 | hlist_for_each_entry(con, h, &connection_hash[i], list) { |
226 | mutex_unlock(&connections_lock); | 249 | if (con && con->sctp_assoc == assoc_id) { |
227 | return con; | 250 | mutex_unlock(&connections_lock); |
251 | return con; | ||
252 | } | ||
228 | } | 253 | } |
229 | } | 254 | } |
230 | mutex_unlock(&connections_lock); | 255 | mutex_unlock(&connections_lock); |
@@ -250,8 +275,7 @@ static int nodeid_to_addr(int nodeid, struct sockaddr *retaddr) | |||
250 | } else { | 275 | } else { |
251 | struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &addr; | 276 | struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &addr; |
252 | struct sockaddr_in6 *ret6 = (struct sockaddr_in6 *) retaddr; | 277 | struct sockaddr_in6 *ret6 = (struct sockaddr_in6 *) retaddr; |
253 | memcpy(&ret6->sin6_addr, &in6->sin6_addr, | 278 | ipv6_addr_copy(&ret6->sin6_addr, &in6->sin6_addr); |
254 | sizeof(in6->sin6_addr)); | ||
255 | } | 279 | } |
256 | 280 | ||
257 | return 0; | 281 | return 0; |
@@ -376,25 +400,23 @@ static void sctp_send_shutdown(sctp_assoc_t associd) | |||
376 | log_print("send EOF to node failed: %d", ret); | 400 | log_print("send EOF to node failed: %d", ret); |
377 | } | 401 | } |
378 | 402 | ||
403 | static void sctp_init_failed_foreach(struct connection *con) | ||
404 | { | ||
405 | con->sctp_assoc = 0; | ||
406 | if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) { | ||
407 | if (!test_and_set_bit(CF_WRITE_PENDING, &con->flags)) | ||
408 | queue_work(send_workqueue, &con->swork); | ||
409 | } | ||
410 | } | ||
411 | |||
379 | /* INIT failed but we don't know which node... | 412 | /* INIT failed but we don't know which node... |
380 | restart INIT on all pending nodes */ | 413 | restart INIT on all pending nodes */ |
381 | static void sctp_init_failed(void) | 414 | static void sctp_init_failed(void) |
382 | { | 415 | { |
383 | int i; | ||
384 | struct connection *con; | ||
385 | |||
386 | mutex_lock(&connections_lock); | 416 | mutex_lock(&connections_lock); |
387 | for (i=1; i<=max_nodeid; i++) { | 417 | |
388 | con = __nodeid2con(i, 0); | 418 | foreach_conn(sctp_init_failed_foreach); |
389 | if (!con) | 419 | |
390 | continue; | ||
391 | con->sctp_assoc = 0; | ||
392 | if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) { | ||
393 | if (!test_and_set_bit(CF_WRITE_PENDING, &con->flags)) { | ||
394 | queue_work(send_workqueue, &con->swork); | ||
395 | } | ||
396 | } | ||
397 | } | ||
398 | mutex_unlock(&connections_lock); | 420 | mutex_unlock(&connections_lock); |
399 | } | 421 | } |
400 | 422 | ||
@@ -1313,13 +1335,10 @@ out_connect: | |||
1313 | 1335 | ||
1314 | static void clean_one_writequeue(struct connection *con) | 1336 | static void clean_one_writequeue(struct connection *con) |
1315 | { | 1337 | { |
1316 | struct list_head *list; | 1338 | struct writequeue_entry *e, *safe; |
1317 | struct list_head *temp; | ||
1318 | 1339 | ||
1319 | spin_lock(&con->writequeue_lock); | 1340 | spin_lock(&con->writequeue_lock); |
1320 | list_for_each_safe(list, temp, &con->writequeue) { | 1341 | list_for_each_entry_safe(e, safe, &con->writequeue, list) { |
1321 | struct writequeue_entry *e = | ||
1322 | list_entry(list, struct writequeue_entry, list); | ||
1323 | list_del(&e->list); | 1342 | list_del(&e->list); |
1324 | free_entry(e); | 1343 | free_entry(e); |
1325 | } | 1344 | } |
@@ -1369,14 +1388,7 @@ static void process_send_sockets(struct work_struct *work) | |||
1369 | /* Discard all entries on the write queues */ | 1388 | /* Discard all entries on the write queues */ |
1370 | static void clean_writequeues(void) | 1389 | static void clean_writequeues(void) |
1371 | { | 1390 | { |
1372 | int nodeid; | 1391 | foreach_conn(clean_one_writequeue); |
1373 | |||
1374 | for (nodeid = 1; nodeid <= max_nodeid; nodeid++) { | ||
1375 | struct connection *con = __nodeid2con(nodeid, 0); | ||
1376 | |||
1377 | if (con) | ||
1378 | clean_one_writequeue(con); | ||
1379 | } | ||
1380 | } | 1392 | } |
1381 | 1393 | ||
1382 | static void work_stop(void) | 1394 | static void work_stop(void) |
@@ -1406,23 +1418,29 @@ static int work_start(void) | |||
1406 | return 0; | 1418 | return 0; |
1407 | } | 1419 | } |
1408 | 1420 | ||
1409 | void dlm_lowcomms_stop(void) | 1421 | static void stop_conn(struct connection *con) |
1410 | { | 1422 | { |
1411 | int i; | 1423 | con->flags |= 0x0F; |
1412 | struct connection *con; | 1424 | if (con->sock) |
1425 | con->sock->sk->sk_user_data = NULL; | ||
1426 | } | ||
1413 | 1427 | ||
1428 | static void free_conn(struct connection *con) | ||
1429 | { | ||
1430 | close_connection(con, true); | ||
1431 | if (con->othercon) | ||
1432 | kmem_cache_free(con_cache, con->othercon); | ||
1433 | hlist_del(&con->list); | ||
1434 | kmem_cache_free(con_cache, con); | ||
1435 | } | ||
1436 | |||
1437 | void dlm_lowcomms_stop(void) | ||
1438 | { | ||
1414 | /* Set all the flags to prevent any | 1439 | /* Set all the flags to prevent any |
1415 | socket activity. | 1440 | socket activity. |
1416 | */ | 1441 | */ |
1417 | mutex_lock(&connections_lock); | 1442 | mutex_lock(&connections_lock); |
1418 | for (i = 0; i <= max_nodeid; i++) { | 1443 | foreach_conn(stop_conn); |
1419 | con = __nodeid2con(i, 0); | ||
1420 | if (con) { | ||
1421 | con->flags |= 0x0F; | ||
1422 | if (con->sock) | ||
1423 | con->sock->sk->sk_user_data = NULL; | ||
1424 | } | ||
1425 | } | ||
1426 | mutex_unlock(&connections_lock); | 1444 | mutex_unlock(&connections_lock); |
1427 | 1445 | ||
1428 | work_stop(); | 1446 | work_stop(); |
@@ -1430,25 +1448,20 @@ void dlm_lowcomms_stop(void) | |||
1430 | mutex_lock(&connections_lock); | 1448 | mutex_lock(&connections_lock); |
1431 | clean_writequeues(); | 1449 | clean_writequeues(); |
1432 | 1450 | ||
1433 | for (i = 0; i <= max_nodeid; i++) { | 1451 | foreach_conn(free_conn); |
1434 | con = __nodeid2con(i, 0); | 1452 | |
1435 | if (con) { | ||
1436 | close_connection(con, true); | ||
1437 | if (con->othercon) | ||
1438 | kmem_cache_free(con_cache, con->othercon); | ||
1439 | kmem_cache_free(con_cache, con); | ||
1440 | } | ||
1441 | } | ||
1442 | max_nodeid = 0; | ||
1443 | mutex_unlock(&connections_lock); | 1453 | mutex_unlock(&connections_lock); |
1444 | kmem_cache_destroy(con_cache); | 1454 | kmem_cache_destroy(con_cache); |
1445 | idr_init(&connections_idr); | ||
1446 | } | 1455 | } |
1447 | 1456 | ||
1448 | int dlm_lowcomms_start(void) | 1457 | int dlm_lowcomms_start(void) |
1449 | { | 1458 | { |
1450 | int error = -EINVAL; | 1459 | int error = -EINVAL; |
1451 | struct connection *con; | 1460 | struct connection *con; |
1461 | int i; | ||
1462 | |||
1463 | for (i = 0; i < CONN_HASH_SIZE; i++) | ||
1464 | INIT_HLIST_HEAD(&connection_hash[i]); | ||
1452 | 1465 | ||
1453 | init_local(); | 1466 | init_local(); |
1454 | if (!dlm_local_count) { | 1467 | if (!dlm_local_count) { |
diff --git a/fs/dlm/user.c b/fs/dlm/user.c index 065149e84f42..ebce994ab0b7 100644 --- a/fs/dlm/user.c +++ b/fs/dlm/user.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2006-2008 Red Hat, Inc. All rights reserved. | 2 | * Copyright (C) 2006-2009 Red Hat, Inc. All rights reserved. |
3 | * | 3 | * |
4 | * This copyrighted material is made available to anyone wishing to use, | 4 | * This copyrighted material is made available to anyone wishing to use, |
5 | * modify, copy, or redistribute it subject to the terms and conditions | 5 | * modify, copy, or redistribute it subject to the terms and conditions |
@@ -84,7 +84,7 @@ struct dlm_lock_result32 { | |||
84 | 84 | ||
85 | static void compat_input(struct dlm_write_request *kb, | 85 | static void compat_input(struct dlm_write_request *kb, |
86 | struct dlm_write_request32 *kb32, | 86 | struct dlm_write_request32 *kb32, |
87 | size_t count) | 87 | int namelen) |
88 | { | 88 | { |
89 | kb->version[0] = kb32->version[0]; | 89 | kb->version[0] = kb32->version[0]; |
90 | kb->version[1] = kb32->version[1]; | 90 | kb->version[1] = kb32->version[1]; |
@@ -96,8 +96,7 @@ static void compat_input(struct dlm_write_request *kb, | |||
96 | kb->cmd == DLM_USER_REMOVE_LOCKSPACE) { | 96 | kb->cmd == DLM_USER_REMOVE_LOCKSPACE) { |
97 | kb->i.lspace.flags = kb32->i.lspace.flags; | 97 | kb->i.lspace.flags = kb32->i.lspace.flags; |
98 | kb->i.lspace.minor = kb32->i.lspace.minor; | 98 | kb->i.lspace.minor = kb32->i.lspace.minor; |
99 | memcpy(kb->i.lspace.name, kb32->i.lspace.name, count - | 99 | memcpy(kb->i.lspace.name, kb32->i.lspace.name, namelen); |
100 | offsetof(struct dlm_write_request32, i.lspace.name)); | ||
101 | } else if (kb->cmd == DLM_USER_PURGE) { | 100 | } else if (kb->cmd == DLM_USER_PURGE) { |
102 | kb->i.purge.nodeid = kb32->i.purge.nodeid; | 101 | kb->i.purge.nodeid = kb32->i.purge.nodeid; |
103 | kb->i.purge.pid = kb32->i.purge.pid; | 102 | kb->i.purge.pid = kb32->i.purge.pid; |
@@ -115,8 +114,7 @@ static void compat_input(struct dlm_write_request *kb, | |||
115 | kb->i.lock.bastaddr = (void *)(long)kb32->i.lock.bastaddr; | 114 | kb->i.lock.bastaddr = (void *)(long)kb32->i.lock.bastaddr; |
116 | kb->i.lock.lksb = (void *)(long)kb32->i.lock.lksb; | 115 | kb->i.lock.lksb = (void *)(long)kb32->i.lock.lksb; |
117 | memcpy(kb->i.lock.lvb, kb32->i.lock.lvb, DLM_USER_LVB_LEN); | 116 | memcpy(kb->i.lock.lvb, kb32->i.lock.lvb, DLM_USER_LVB_LEN); |
118 | memcpy(kb->i.lock.name, kb32->i.lock.name, count - | 117 | memcpy(kb->i.lock.name, kb32->i.lock.name, namelen); |
119 | offsetof(struct dlm_write_request32, i.lock.name)); | ||
120 | } | 118 | } |
121 | } | 119 | } |
122 | 120 | ||
@@ -539,9 +537,16 @@ static ssize_t device_write(struct file *file, const char __user *buf, | |||
539 | #ifdef CONFIG_COMPAT | 537 | #ifdef CONFIG_COMPAT |
540 | if (!kbuf->is64bit) { | 538 | if (!kbuf->is64bit) { |
541 | struct dlm_write_request32 *k32buf; | 539 | struct dlm_write_request32 *k32buf; |
540 | int namelen = 0; | ||
541 | |||
542 | if (count > sizeof(struct dlm_write_request32)) | ||
543 | namelen = count - sizeof(struct dlm_write_request32); | ||
544 | |||
542 | k32buf = (struct dlm_write_request32 *)kbuf; | 545 | k32buf = (struct dlm_write_request32 *)kbuf; |
543 | kbuf = kmalloc(count + 1 + (sizeof(struct dlm_write_request) - | 546 | |
544 | sizeof(struct dlm_write_request32)), GFP_KERNEL); | 547 | /* add 1 after namelen so that the name string is terminated */ |
548 | kbuf = kzalloc(sizeof(struct dlm_write_request) + namelen + 1, | ||
549 | GFP_KERNEL); | ||
545 | if (!kbuf) { | 550 | if (!kbuf) { |
546 | kfree(k32buf); | 551 | kfree(k32buf); |
547 | return -ENOMEM; | 552 | return -ENOMEM; |
@@ -549,7 +554,8 @@ static ssize_t device_write(struct file *file, const char __user *buf, | |||
549 | 554 | ||
550 | if (proc) | 555 | if (proc) |
551 | set_bit(DLM_PROC_FLAGS_COMPAT, &proc->flags); | 556 | set_bit(DLM_PROC_FLAGS_COMPAT, &proc->flags); |
552 | compat_input(kbuf, k32buf, count + 1); | 557 | |
558 | compat_input(kbuf, k32buf, namelen); | ||
553 | kfree(k32buf); | 559 | kfree(k32buf); |
554 | } | 560 | } |
555 | #endif | 561 | #endif |
diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 3e5637fc3779..44d725f612cf 100644 --- a/fs/drop_caches.c +++ b/fs/drop_caches.c | |||
@@ -18,7 +18,7 @@ static void drop_pagecache_sb(struct super_block *sb) | |||
18 | 18 | ||
19 | spin_lock(&inode_lock); | 19 | spin_lock(&inode_lock); |
20 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { | 20 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { |
21 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) | 21 | if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) |
22 | continue; | 22 | continue; |
23 | if (inode->i_mapping->nrpages == 0) | 23 | if (inode->i_mapping->nrpages == 0) |
24 | continue; | 24 | continue; |
diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index 5e596583946c..2dda5ade75bc 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs/dentry.c | |||
@@ -89,7 +89,7 @@ static void ecryptfs_d_release(struct dentry *dentry) | |||
89 | return; | 89 | return; |
90 | } | 90 | } |
91 | 91 | ||
92 | struct dentry_operations ecryptfs_dops = { | 92 | const struct dentry_operations ecryptfs_dops = { |
93 | .d_revalidate = ecryptfs_d_revalidate, | 93 | .d_revalidate = ecryptfs_d_revalidate, |
94 | .d_release = ecryptfs_d_release, | 94 | .d_release = ecryptfs_d_release, |
95 | }; | 95 | }; |
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h index ac749d4d644f..064c5820e4e5 100644 --- a/fs/ecryptfs/ecryptfs_kernel.h +++ b/fs/ecryptfs/ecryptfs_kernel.h | |||
@@ -580,7 +580,7 @@ extern const struct inode_operations ecryptfs_main_iops; | |||
580 | extern const struct inode_operations ecryptfs_dir_iops; | 580 | extern const struct inode_operations ecryptfs_dir_iops; |
581 | extern const struct inode_operations ecryptfs_symlink_iops; | 581 | extern const struct inode_operations ecryptfs_symlink_iops; |
582 | extern const struct super_operations ecryptfs_sops; | 582 | extern const struct super_operations ecryptfs_sops; |
583 | extern struct dentry_operations ecryptfs_dops; | 583 | extern const struct dentry_operations ecryptfs_dops; |
584 | extern struct address_space_operations ecryptfs_aops; | 584 | extern struct address_space_operations ecryptfs_aops; |
585 | extern int ecryptfs_verbosity; | 585 | extern int ecryptfs_verbosity; |
586 | extern unsigned int ecryptfs_message_buf_len; | 586 | extern unsigned int ecryptfs_message_buf_len; |
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 011b9b8c90c6..c5c424f23fd5 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c | |||
@@ -417,10 +417,10 @@ static int ep_remove(struct eventpoll *ep, struct epitem *epi) | |||
417 | ep_unregister_pollwait(ep, epi); | 417 | ep_unregister_pollwait(ep, epi); |
418 | 418 | ||
419 | /* Remove the current item from the list of epoll hooks */ | 419 | /* Remove the current item from the list of epoll hooks */ |
420 | spin_lock(&file->f_ep_lock); | 420 | spin_lock(&file->f_lock); |
421 | if (ep_is_linked(&epi->fllink)) | 421 | if (ep_is_linked(&epi->fllink)) |
422 | list_del_init(&epi->fllink); | 422 | list_del_init(&epi->fllink); |
423 | spin_unlock(&file->f_ep_lock); | 423 | spin_unlock(&file->f_lock); |
424 | 424 | ||
425 | rb_erase(&epi->rbn, &ep->rbr); | 425 | rb_erase(&epi->rbn, &ep->rbr); |
426 | 426 | ||
@@ -538,7 +538,7 @@ void eventpoll_release_file(struct file *file) | |||
538 | struct epitem *epi; | 538 | struct epitem *epi; |
539 | 539 | ||
540 | /* | 540 | /* |
541 | * We don't want to get "file->f_ep_lock" because it is not | 541 | * We don't want to get "file->f_lock" because it is not |
542 | * necessary. It is not necessary because we're in the "struct file" | 542 | * necessary. It is not necessary because we're in the "struct file" |
543 | * cleanup path, and this means that noone is using this file anymore. | 543 | * cleanup path, and this means that noone is using this file anymore. |
544 | * So, for example, epoll_ctl() cannot hit here sicne if we reach this | 544 | * So, for example, epoll_ctl() cannot hit here sicne if we reach this |
@@ -547,6 +547,8 @@ void eventpoll_release_file(struct file *file) | |||
547 | * will correctly serialize the operation. We do need to acquire | 547 | * will correctly serialize the operation. We do need to acquire |
548 | * "ep->mtx" after "epmutex" because ep_remove() requires it when called | 548 | * "ep->mtx" after "epmutex" because ep_remove() requires it when called |
549 | * from anywhere but ep_free(). | 549 | * from anywhere but ep_free(). |
550 | * | ||
551 | * Besides, ep_remove() acquires the lock, so we can't hold it here. | ||
550 | */ | 552 | */ |
551 | mutex_lock(&epmutex); | 553 | mutex_lock(&epmutex); |
552 | 554 | ||
@@ -785,9 +787,9 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, | |||
785 | goto error_unregister; | 787 | goto error_unregister; |
786 | 788 | ||
787 | /* Add the current item to the list of active epoll hook for this file */ | 789 | /* Add the current item to the list of active epoll hook for this file */ |
788 | spin_lock(&tfile->f_ep_lock); | 790 | spin_lock(&tfile->f_lock); |
789 | list_add_tail(&epi->fllink, &tfile->f_ep_links); | 791 | list_add_tail(&epi->fllink, &tfile->f_ep_links); |
790 | spin_unlock(&tfile->f_ep_lock); | 792 | spin_unlock(&tfile->f_lock); |
791 | 793 | ||
792 | /* | 794 | /* |
793 | * Add the current item to the RB tree. All RB tree operations are | 795 | * Add the current item to the RB tree. All RB tree operations are |
@@ -45,6 +45,7 @@ | |||
45 | #include <linux/proc_fs.h> | 45 | #include <linux/proc_fs.h> |
46 | #include <linux/mount.h> | 46 | #include <linux/mount.h> |
47 | #include <linux/security.h> | 47 | #include <linux/security.h> |
48 | #include <linux/ima.h> | ||
48 | #include <linux/syscalls.h> | 49 | #include <linux/syscalls.h> |
49 | #include <linux/tsacct_kern.h> | 50 | #include <linux/tsacct_kern.h> |
50 | #include <linux/cn_proc.h> | 51 | #include <linux/cn_proc.h> |
@@ -127,6 +128,9 @@ SYSCALL_DEFINE1(uselib, const char __user *, library) | |||
127 | MAY_READ | MAY_EXEC | MAY_OPEN); | 128 | MAY_READ | MAY_EXEC | MAY_OPEN); |
128 | if (error) | 129 | if (error) |
129 | goto exit; | 130 | goto exit; |
131 | error = ima_path_check(&nd.path, MAY_READ | MAY_EXEC | MAY_OPEN); | ||
132 | if (error) | ||
133 | goto exit; | ||
130 | 134 | ||
131 | file = nameidata_to_filp(&nd, O_RDONLY|O_LARGEFILE); | 135 | file = nameidata_to_filp(&nd, O_RDONLY|O_LARGEFILE); |
132 | error = PTR_ERR(file); | 136 | error = PTR_ERR(file); |
@@ -674,6 +678,9 @@ struct file *open_exec(const char *name) | |||
674 | err = inode_permission(nd.path.dentry->d_inode, MAY_EXEC | MAY_OPEN); | 678 | err = inode_permission(nd.path.dentry->d_inode, MAY_EXEC | MAY_OPEN); |
675 | if (err) | 679 | if (err) |
676 | goto out_path_put; | 680 | goto out_path_put; |
681 | err = ima_path_check(&nd.path, MAY_EXEC | MAY_OPEN); | ||
682 | if (err) | ||
683 | goto out_path_put; | ||
677 | 684 | ||
678 | file = nameidata_to_filp(&nd, O_RDONLY|O_LARGEFILE); | 685 | file = nameidata_to_filp(&nd, O_RDONLY|O_LARGEFILE); |
679 | if (IS_ERR(file)) | 686 | if (IS_ERR(file)) |
@@ -1049,28 +1056,24 @@ EXPORT_SYMBOL(install_exec_creds); | |||
1049 | * - the caller must hold current->cred_exec_mutex to protect against | 1056 | * - the caller must hold current->cred_exec_mutex to protect against |
1050 | * PTRACE_ATTACH | 1057 | * PTRACE_ATTACH |
1051 | */ | 1058 | */ |
1052 | void check_unsafe_exec(struct linux_binprm *bprm, struct files_struct *files) | 1059 | void check_unsafe_exec(struct linux_binprm *bprm) |
1053 | { | 1060 | { |
1054 | struct task_struct *p = current, *t; | 1061 | struct task_struct *p = current, *t; |
1055 | unsigned long flags; | 1062 | unsigned long flags; |
1056 | unsigned n_fs, n_files, n_sighand; | 1063 | unsigned n_fs, n_sighand; |
1057 | 1064 | ||
1058 | bprm->unsafe = tracehook_unsafe_exec(p); | 1065 | bprm->unsafe = tracehook_unsafe_exec(p); |
1059 | 1066 | ||
1060 | n_fs = 1; | 1067 | n_fs = 1; |
1061 | n_files = 1; | ||
1062 | n_sighand = 1; | 1068 | n_sighand = 1; |
1063 | lock_task_sighand(p, &flags); | 1069 | lock_task_sighand(p, &flags); |
1064 | for (t = next_thread(p); t != p; t = next_thread(t)) { | 1070 | for (t = next_thread(p); t != p; t = next_thread(t)) { |
1065 | if (t->fs == p->fs) | 1071 | if (t->fs == p->fs) |
1066 | n_fs++; | 1072 | n_fs++; |
1067 | if (t->files == files) | ||
1068 | n_files++; | ||
1069 | n_sighand++; | 1073 | n_sighand++; |
1070 | } | 1074 | } |
1071 | 1075 | ||
1072 | if (atomic_read(&p->fs->count) > n_fs || | 1076 | if (atomic_read(&p->fs->count) > n_fs || |
1073 | atomic_read(&p->files->count) > n_files || | ||
1074 | atomic_read(&p->sighand->count) > n_sighand) | 1077 | atomic_read(&p->sighand->count) > n_sighand) |
1075 | bprm->unsafe |= LSM_UNSAFE_SHARE; | 1078 | bprm->unsafe |= LSM_UNSAFE_SHARE; |
1076 | 1079 | ||
@@ -1184,6 +1187,9 @@ int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs) | |||
1184 | retval = security_bprm_check(bprm); | 1187 | retval = security_bprm_check(bprm); |
1185 | if (retval) | 1188 | if (retval) |
1186 | return retval; | 1189 | return retval; |
1190 | retval = ima_bprm_check(bprm); | ||
1191 | if (retval) | ||
1192 | return retval; | ||
1187 | 1193 | ||
1188 | /* kernel module loader fixup */ | 1194 | /* kernel module loader fixup */ |
1189 | /* so we don't try to load run modprobe in kernel space. */ | 1195 | /* so we don't try to load run modprobe in kernel space. */ |
@@ -1284,12 +1290,13 @@ int do_execve(char * filename, | |||
1284 | retval = mutex_lock_interruptible(¤t->cred_exec_mutex); | 1290 | retval = mutex_lock_interruptible(¤t->cred_exec_mutex); |
1285 | if (retval < 0) | 1291 | if (retval < 0) |
1286 | goto out_free; | 1292 | goto out_free; |
1293 | current->in_execve = 1; | ||
1287 | 1294 | ||
1288 | retval = -ENOMEM; | 1295 | retval = -ENOMEM; |
1289 | bprm->cred = prepare_exec_creds(); | 1296 | bprm->cred = prepare_exec_creds(); |
1290 | if (!bprm->cred) | 1297 | if (!bprm->cred) |
1291 | goto out_unlock; | 1298 | goto out_unlock; |
1292 | check_unsafe_exec(bprm, displaced); | 1299 | check_unsafe_exec(bprm); |
1293 | 1300 | ||
1294 | file = open_exec(filename); | 1301 | file = open_exec(filename); |
1295 | retval = PTR_ERR(file); | 1302 | retval = PTR_ERR(file); |
@@ -1337,6 +1344,7 @@ int do_execve(char * filename, | |||
1337 | goto out; | 1344 | goto out; |
1338 | 1345 | ||
1339 | /* execve succeeded */ | 1346 | /* execve succeeded */ |
1347 | current->in_execve = 0; | ||
1340 | mutex_unlock(¤t->cred_exec_mutex); | 1348 | mutex_unlock(¤t->cred_exec_mutex); |
1341 | acct_update_integrals(current); | 1349 | acct_update_integrals(current); |
1342 | free_bprm(bprm); | 1350 | free_bprm(bprm); |
@@ -1355,6 +1363,7 @@ out_file: | |||
1355 | } | 1363 | } |
1356 | 1364 | ||
1357 | out_unlock: | 1365 | out_unlock: |
1366 | current->in_execve = 0; | ||
1358 | mutex_unlock(¤t->cred_exec_mutex); | 1367 | mutex_unlock(¤t->cred_exec_mutex); |
1359 | 1368 | ||
1360 | out_free: | 1369 | out_free: |
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 4a29d6376081..7f8d2e5a7ea6 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c | |||
@@ -570,7 +570,7 @@ do_more: | |||
570 | error_return: | 570 | error_return: |
571 | brelse(bitmap_bh); | 571 | brelse(bitmap_bh); |
572 | release_blocks(sb, freed); | 572 | release_blocks(sb, freed); |
573 | DQUOT_FREE_BLOCK(inode, freed); | 573 | vfs_dq_free_block(inode, freed); |
574 | } | 574 | } |
575 | 575 | ||
576 | /** | 576 | /** |
@@ -1247,7 +1247,7 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal, | |||
1247 | /* | 1247 | /* |
1248 | * Check quota for allocation of this block. | 1248 | * Check quota for allocation of this block. |
1249 | */ | 1249 | */ |
1250 | if (DQUOT_ALLOC_BLOCK(inode, num)) { | 1250 | if (vfs_dq_alloc_block(inode, num)) { |
1251 | *errp = -EDQUOT; | 1251 | *errp = -EDQUOT; |
1252 | return 0; | 1252 | return 0; |
1253 | } | 1253 | } |
@@ -1409,7 +1409,7 @@ allocated: | |||
1409 | 1409 | ||
1410 | *errp = 0; | 1410 | *errp = 0; |
1411 | brelse(bitmap_bh); | 1411 | brelse(bitmap_bh); |
1412 | DQUOT_FREE_BLOCK(inode, *count-num); | 1412 | vfs_dq_free_block(inode, *count-num); |
1413 | *count = num; | 1413 | *count = num; |
1414 | return ret_block; | 1414 | return ret_block; |
1415 | 1415 | ||
@@ -1420,7 +1420,7 @@ out: | |||
1420 | * Undo the block allocation | 1420 | * Undo the block allocation |
1421 | */ | 1421 | */ |
1422 | if (!performed_allocation) | 1422 | if (!performed_allocation) |
1423 | DQUOT_FREE_BLOCK(inode, *count); | 1423 | vfs_dq_free_block(inode, *count); |
1424 | brelse(bitmap_bh); | 1424 | brelse(bitmap_bh); |
1425 | return 0; | 1425 | return 0; |
1426 | } | 1426 | } |
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c index 66321a877e74..15387c9c17d8 100644 --- a/fs/ext2/ialloc.c +++ b/fs/ext2/ialloc.c | |||
@@ -121,8 +121,8 @@ void ext2_free_inode (struct inode * inode) | |||
121 | if (!is_bad_inode(inode)) { | 121 | if (!is_bad_inode(inode)) { |
122 | /* Quota is already initialized in iput() */ | 122 | /* Quota is already initialized in iput() */ |
123 | ext2_xattr_delete_inode(inode); | 123 | ext2_xattr_delete_inode(inode); |
124 | DQUOT_FREE_INODE(inode); | 124 | vfs_dq_free_inode(inode); |
125 | DQUOT_DROP(inode); | 125 | vfs_dq_drop(inode); |
126 | } | 126 | } |
127 | 127 | ||
128 | es = EXT2_SB(sb)->s_es; | 128 | es = EXT2_SB(sb)->s_es; |
@@ -586,7 +586,7 @@ got: | |||
586 | goto fail_drop; | 586 | goto fail_drop; |
587 | } | 587 | } |
588 | 588 | ||
589 | if (DQUOT_ALLOC_INODE(inode)) { | 589 | if (vfs_dq_alloc_inode(inode)) { |
590 | err = -EDQUOT; | 590 | err = -EDQUOT; |
591 | goto fail_drop; | 591 | goto fail_drop; |
592 | } | 592 | } |
@@ -605,10 +605,10 @@ got: | |||
605 | return inode; | 605 | return inode; |
606 | 606 | ||
607 | fail_free_drop: | 607 | fail_free_drop: |
608 | DQUOT_FREE_INODE(inode); | 608 | vfs_dq_free_inode(inode); |
609 | 609 | ||
610 | fail_drop: | 610 | fail_drop: |
611 | DQUOT_DROP(inode); | 611 | vfs_dq_drop(inode); |
612 | inode->i_flags |= S_NOQUOTA; | 612 | inode->i_flags |= S_NOQUOTA; |
613 | inode->i_nlink = 0; | 613 | inode->i_nlink = 0; |
614 | unlock_new_inode(inode); | 614 | unlock_new_inode(inode); |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 23fff2f87783..b43b95563663 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
@@ -1444,7 +1444,7 @@ int ext2_setattr(struct dentry *dentry, struct iattr *iattr) | |||
1444 | return error; | 1444 | return error; |
1445 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | 1445 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || |
1446 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | 1446 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { |
1447 | error = DQUOT_TRANSFER(inode, iattr) ? -EDQUOT : 0; | 1447 | error = vfs_dq_transfer(inode, iattr) ? -EDQUOT : 0; |
1448 | if (error) | 1448 | if (error) |
1449 | return error; | 1449 | return error; |
1450 | } | 1450 | } |
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 7c6e3606f0ec..f983225266dc 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -1331,6 +1331,7 @@ static ssize_t ext2_quota_read(struct super_block *sb, int type, char *data, | |||
1331 | sb->s_blocksize - offset : toread; | 1331 | sb->s_blocksize - offset : toread; |
1332 | 1332 | ||
1333 | tmp_bh.b_state = 0; | 1333 | tmp_bh.b_state = 0; |
1334 | tmp_bh.b_size = sb->s_blocksize; | ||
1334 | err = ext2_get_block(inode, blk, &tmp_bh, 0); | 1335 | err = ext2_get_block(inode, blk, &tmp_bh, 0); |
1335 | if (err < 0) | 1336 | if (err < 0) |
1336 | return err; | 1337 | return err; |
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 987a5261cc2e..7913531ec6d5 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c | |||
@@ -642,7 +642,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
642 | ea_bdebug(new_bh, "reusing block"); | 642 | ea_bdebug(new_bh, "reusing block"); |
643 | 643 | ||
644 | error = -EDQUOT; | 644 | error = -EDQUOT; |
645 | if (DQUOT_ALLOC_BLOCK(inode, 1)) { | 645 | if (vfs_dq_alloc_block(inode, 1)) { |
646 | unlock_buffer(new_bh); | 646 | unlock_buffer(new_bh); |
647 | goto cleanup; | 647 | goto cleanup; |
648 | } | 648 | } |
@@ -699,7 +699,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
699 | * as if nothing happened and cleanup the unused block */ | 699 | * as if nothing happened and cleanup the unused block */ |
700 | if (error && error != -ENOSPC) { | 700 | if (error && error != -ENOSPC) { |
701 | if (new_bh && new_bh != old_bh) | 701 | if (new_bh && new_bh != old_bh) |
702 | DQUOT_FREE_BLOCK(inode, 1); | 702 | vfs_dq_free_block(inode, 1); |
703 | goto cleanup; | 703 | goto cleanup; |
704 | } | 704 | } |
705 | } else | 705 | } else |
@@ -731,7 +731,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
731 | le32_add_cpu(&HDR(old_bh)->h_refcount, -1); | 731 | le32_add_cpu(&HDR(old_bh)->h_refcount, -1); |
732 | if (ce) | 732 | if (ce) |
733 | mb_cache_entry_release(ce); | 733 | mb_cache_entry_release(ce); |
734 | DQUOT_FREE_BLOCK(inode, 1); | 734 | vfs_dq_free_block(inode, 1); |
735 | mark_buffer_dirty(old_bh); | 735 | mark_buffer_dirty(old_bh); |
736 | ea_bdebug(old_bh, "refcount now=%d", | 736 | ea_bdebug(old_bh, "refcount now=%d", |
737 | le32_to_cpu(HDR(old_bh)->h_refcount)); | 737 | le32_to_cpu(HDR(old_bh)->h_refcount)); |
@@ -794,7 +794,7 @@ ext2_xattr_delete_inode(struct inode *inode) | |||
794 | mark_buffer_dirty(bh); | 794 | mark_buffer_dirty(bh); |
795 | if (IS_SYNC(inode)) | 795 | if (IS_SYNC(inode)) |
796 | sync_dirty_buffer(bh); | 796 | sync_dirty_buffer(bh); |
797 | DQUOT_FREE_BLOCK(inode, 1); | 797 | vfs_dq_free_block(inode, 1); |
798 | } | 798 | } |
799 | EXT2_I(inode)->i_file_acl = 0; | 799 | EXT2_I(inode)->i_file_acl = 0; |
800 | 800 | ||
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 0dbf1c048475..225202db8974 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c | |||
@@ -676,7 +676,7 @@ void ext3_free_blocks(handle_t *handle, struct inode *inode, | |||
676 | } | 676 | } |
677 | ext3_free_blocks_sb(handle, sb, block, count, &dquot_freed_blocks); | 677 | ext3_free_blocks_sb(handle, sb, block, count, &dquot_freed_blocks); |
678 | if (dquot_freed_blocks) | 678 | if (dquot_freed_blocks) |
679 | DQUOT_FREE_BLOCK(inode, dquot_freed_blocks); | 679 | vfs_dq_free_block(inode, dquot_freed_blocks); |
680 | return; | 680 | return; |
681 | } | 681 | } |
682 | 682 | ||
@@ -1502,7 +1502,7 @@ ext3_fsblk_t ext3_new_blocks(handle_t *handle, struct inode *inode, | |||
1502 | /* | 1502 | /* |
1503 | * Check quota for allocation of this block. | 1503 | * Check quota for allocation of this block. |
1504 | */ | 1504 | */ |
1505 | if (DQUOT_ALLOC_BLOCK(inode, num)) { | 1505 | if (vfs_dq_alloc_block(inode, num)) { |
1506 | *errp = -EDQUOT; | 1506 | *errp = -EDQUOT; |
1507 | return 0; | 1507 | return 0; |
1508 | } | 1508 | } |
@@ -1714,7 +1714,7 @@ allocated: | |||
1714 | 1714 | ||
1715 | *errp = 0; | 1715 | *errp = 0; |
1716 | brelse(bitmap_bh); | 1716 | brelse(bitmap_bh); |
1717 | DQUOT_FREE_BLOCK(inode, *count-num); | 1717 | vfs_dq_free_block(inode, *count-num); |
1718 | *count = num; | 1718 | *count = num; |
1719 | return ret_block; | 1719 | return ret_block; |
1720 | 1720 | ||
@@ -1729,7 +1729,7 @@ out: | |||
1729 | * Undo the block allocation | 1729 | * Undo the block allocation |
1730 | */ | 1730 | */ |
1731 | if (!performed_allocation) | 1731 | if (!performed_allocation) |
1732 | DQUOT_FREE_BLOCK(inode, *count); | 1732 | vfs_dq_free_block(inode, *count); |
1733 | brelse(bitmap_bh); | 1733 | brelse(bitmap_bh); |
1734 | return 0; | 1734 | return 0; |
1735 | } | 1735 | } |
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c index 8de6c720e510..dd13d60d524b 100644 --- a/fs/ext3/ialloc.c +++ b/fs/ext3/ialloc.c | |||
@@ -123,10 +123,10 @@ void ext3_free_inode (handle_t *handle, struct inode * inode) | |||
123 | * Note: we must free any quota before locking the superblock, | 123 | * Note: we must free any quota before locking the superblock, |
124 | * as writing the quota to disk may need the lock as well. | 124 | * as writing the quota to disk may need the lock as well. |
125 | */ | 125 | */ |
126 | DQUOT_INIT(inode); | 126 | vfs_dq_init(inode); |
127 | ext3_xattr_delete_inode(handle, inode); | 127 | ext3_xattr_delete_inode(handle, inode); |
128 | DQUOT_FREE_INODE(inode); | 128 | vfs_dq_free_inode(inode); |
129 | DQUOT_DROP(inode); | 129 | vfs_dq_drop(inode); |
130 | 130 | ||
131 | is_directory = S_ISDIR(inode->i_mode); | 131 | is_directory = S_ISDIR(inode->i_mode); |
132 | 132 | ||
@@ -589,7 +589,7 @@ got: | |||
589 | sizeof(struct ext3_inode) - EXT3_GOOD_OLD_INODE_SIZE : 0; | 589 | sizeof(struct ext3_inode) - EXT3_GOOD_OLD_INODE_SIZE : 0; |
590 | 590 | ||
591 | ret = inode; | 591 | ret = inode; |
592 | if(DQUOT_ALLOC_INODE(inode)) { | 592 | if (vfs_dq_alloc_inode(inode)) { |
593 | err = -EDQUOT; | 593 | err = -EDQUOT; |
594 | goto fail_drop; | 594 | goto fail_drop; |
595 | } | 595 | } |
@@ -620,10 +620,10 @@ really_out: | |||
620 | return ret; | 620 | return ret; |
621 | 621 | ||
622 | fail_free_drop: | 622 | fail_free_drop: |
623 | DQUOT_FREE_INODE(inode); | 623 | vfs_dq_free_inode(inode); |
624 | 624 | ||
625 | fail_drop: | 625 | fail_drop: |
626 | DQUOT_DROP(inode); | 626 | vfs_dq_drop(inode); |
627 | inode->i_flags |= S_NOQUOTA; | 627 | inode->i_flags |= S_NOQUOTA; |
628 | inode->i_nlink = 0; | 628 | inode->i_nlink = 0; |
629 | unlock_new_inode(inode); | 629 | unlock_new_inode(inode); |
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 5fa453b49a64..4a09ff169870 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -1435,6 +1435,10 @@ static int journal_dirty_data_fn(handle_t *handle, struct buffer_head *bh) | |||
1435 | return 0; | 1435 | return 0; |
1436 | } | 1436 | } |
1437 | 1437 | ||
1438 | static int buffer_unmapped(handle_t *handle, struct buffer_head *bh) | ||
1439 | { | ||
1440 | return !buffer_mapped(bh); | ||
1441 | } | ||
1438 | /* | 1442 | /* |
1439 | * Note that we always start a transaction even if we're not journalling | 1443 | * Note that we always start a transaction even if we're not journalling |
1440 | * data. This is to preserve ordering: any hole instantiation within | 1444 | * data. This is to preserve ordering: any hole instantiation within |
@@ -1505,6 +1509,15 @@ static int ext3_ordered_writepage(struct page *page, | |||
1505 | if (ext3_journal_current_handle()) | 1509 | if (ext3_journal_current_handle()) |
1506 | goto out_fail; | 1510 | goto out_fail; |
1507 | 1511 | ||
1512 | if (!page_has_buffers(page)) { | ||
1513 | create_empty_buffers(page, inode->i_sb->s_blocksize, | ||
1514 | (1 << BH_Dirty)|(1 << BH_Uptodate)); | ||
1515 | } else if (!walk_page_buffers(NULL, page_buffers(page), 0, PAGE_CACHE_SIZE, NULL, buffer_unmapped)) { | ||
1516 | /* Provide NULL instead of get_block so that we catch bugs if buffers weren't really mapped */ | ||
1517 | return block_write_full_page(page, NULL, wbc); | ||
1518 | } | ||
1519 | page_bufs = page_buffers(page); | ||
1520 | |||
1508 | handle = ext3_journal_start(inode, ext3_writepage_trans_blocks(inode)); | 1521 | handle = ext3_journal_start(inode, ext3_writepage_trans_blocks(inode)); |
1509 | 1522 | ||
1510 | if (IS_ERR(handle)) { | 1523 | if (IS_ERR(handle)) { |
@@ -1512,11 +1525,6 @@ static int ext3_ordered_writepage(struct page *page, | |||
1512 | goto out_fail; | 1525 | goto out_fail; |
1513 | } | 1526 | } |
1514 | 1527 | ||
1515 | if (!page_has_buffers(page)) { | ||
1516 | create_empty_buffers(page, inode->i_sb->s_blocksize, | ||
1517 | (1 << BH_Dirty)|(1 << BH_Uptodate)); | ||
1518 | } | ||
1519 | page_bufs = page_buffers(page); | ||
1520 | walk_page_buffers(handle, page_bufs, 0, | 1528 | walk_page_buffers(handle, page_bufs, 0, |
1521 | PAGE_CACHE_SIZE, NULL, bget_one); | 1529 | PAGE_CACHE_SIZE, NULL, bget_one); |
1522 | 1530 | ||
@@ -3055,7 +3063,7 @@ int ext3_setattr(struct dentry *dentry, struct iattr *attr) | |||
3055 | error = PTR_ERR(handle); | 3063 | error = PTR_ERR(handle); |
3056 | goto err_out; | 3064 | goto err_out; |
3057 | } | 3065 | } |
3058 | error = DQUOT_TRANSFER(inode, attr) ? -EDQUOT : 0; | 3066 | error = vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; |
3059 | if (error) { | 3067 | if (error) { |
3060 | ext3_journal_stop(handle); | 3068 | ext3_journal_stop(handle); |
3061 | return error; | 3069 | return error; |
@@ -3146,7 +3154,7 @@ static int ext3_writepage_trans_blocks(struct inode *inode) | |||
3146 | ret = 2 * (bpp + indirects) + 2; | 3154 | ret = 2 * (bpp + indirects) + 2; |
3147 | 3155 | ||
3148 | #ifdef CONFIG_QUOTA | 3156 | #ifdef CONFIG_QUOTA |
3149 | /* We know that structure was already allocated during DQUOT_INIT so | 3157 | /* We know that structure was already allocated during vfs_dq_init so |
3150 | * we will be updating only the data blocks + inodes */ | 3158 | * we will be updating only the data blocks + inodes */ |
3151 | ret += 2*EXT3_QUOTA_TRANS_BLOCKS(inode->i_sb); | 3159 | ret += 2*EXT3_QUOTA_TRANS_BLOCKS(inode->i_sb); |
3152 | #endif | 3160 | #endif |
@@ -3237,7 +3245,7 @@ int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
3237 | * i_size has been changed by generic_commit_write() and we thus need | 3245 | * i_size has been changed by generic_commit_write() and we thus need |
3238 | * to include the updated inode in the current transaction. | 3246 | * to include the updated inode in the current transaction. |
3239 | * | 3247 | * |
3240 | * Also, DQUOT_ALLOC_SPACE() will always dirty the inode when blocks | 3248 | * Also, vfs_dq_alloc_space() will always dirty the inode when blocks |
3241 | * are allocated to the file. | 3249 | * are allocated to the file. |
3242 | * | 3250 | * |
3243 | * If the inode is marked synchronous, we don't honour that here - doing | 3251 | * If the inode is marked synchronous, we don't honour that here - doing |
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 4db4ffa1edad..e2fc63cbba8b 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c | |||
@@ -2049,7 +2049,7 @@ static int ext3_rmdir (struct inode * dir, struct dentry *dentry) | |||
2049 | 2049 | ||
2050 | /* Initialize quotas before so that eventual writes go in | 2050 | /* Initialize quotas before so that eventual writes go in |
2051 | * separate transaction */ | 2051 | * separate transaction */ |
2052 | DQUOT_INIT(dentry->d_inode); | 2052 | vfs_dq_init(dentry->d_inode); |
2053 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2053 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2054 | if (IS_ERR(handle)) | 2054 | if (IS_ERR(handle)) |
2055 | return PTR_ERR(handle); | 2055 | return PTR_ERR(handle); |
@@ -2108,7 +2108,7 @@ static int ext3_unlink(struct inode * dir, struct dentry *dentry) | |||
2108 | 2108 | ||
2109 | /* Initialize quotas before so that eventual writes go | 2109 | /* Initialize quotas before so that eventual writes go |
2110 | * in separate transaction */ | 2110 | * in separate transaction */ |
2111 | DQUOT_INIT(dentry->d_inode); | 2111 | vfs_dq_init(dentry->d_inode); |
2112 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2112 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2113 | if (IS_ERR(handle)) | 2113 | if (IS_ERR(handle)) |
2114 | return PTR_ERR(handle); | 2114 | return PTR_ERR(handle); |
@@ -2272,7 +2272,7 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, | |||
2272 | /* Initialize quotas before so that eventual writes go | 2272 | /* Initialize quotas before so that eventual writes go |
2273 | * in separate transaction */ | 2273 | * in separate transaction */ |
2274 | if (new_dentry->d_inode) | 2274 | if (new_dentry->d_inode) |
2275 | DQUOT_INIT(new_dentry->d_inode); | 2275 | vfs_dq_init(new_dentry->d_inode); |
2276 | handle = ext3_journal_start(old_dir, 2 * | 2276 | handle = ext3_journal_start(old_dir, 2 * |
2277 | EXT3_DATA_TRANS_BLOCKS(old_dir->i_sb) + | 2277 | EXT3_DATA_TRANS_BLOCKS(old_dir->i_sb) + |
2278 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 2); | 2278 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 2); |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 4a970411a458..9e5b8e387e1e 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -707,8 +707,6 @@ static int bdev_try_to_free_page(struct super_block *sb, struct page *page, | |||
707 | #define QTYPE2NAME(t) ((t)==USRQUOTA?"user":"group") | 707 | #define QTYPE2NAME(t) ((t)==USRQUOTA?"user":"group") |
708 | #define QTYPE2MOPT(on, t) ((t)==USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA)) | 708 | #define QTYPE2MOPT(on, t) ((t)==USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA)) |
709 | 709 | ||
710 | static int ext3_dquot_initialize(struct inode *inode, int type); | ||
711 | static int ext3_dquot_drop(struct inode *inode); | ||
712 | static int ext3_write_dquot(struct dquot *dquot); | 710 | static int ext3_write_dquot(struct dquot *dquot); |
713 | static int ext3_acquire_dquot(struct dquot *dquot); | 711 | static int ext3_acquire_dquot(struct dquot *dquot); |
714 | static int ext3_release_dquot(struct dquot *dquot); | 712 | static int ext3_release_dquot(struct dquot *dquot); |
@@ -723,8 +721,8 @@ static ssize_t ext3_quota_write(struct super_block *sb, int type, | |||
723 | const char *data, size_t len, loff_t off); | 721 | const char *data, size_t len, loff_t off); |
724 | 722 | ||
725 | static struct dquot_operations ext3_quota_operations = { | 723 | static struct dquot_operations ext3_quota_operations = { |
726 | .initialize = ext3_dquot_initialize, | 724 | .initialize = dquot_initialize, |
727 | .drop = ext3_dquot_drop, | 725 | .drop = dquot_drop, |
728 | .alloc_space = dquot_alloc_space, | 726 | .alloc_space = dquot_alloc_space, |
729 | .alloc_inode = dquot_alloc_inode, | 727 | .alloc_inode = dquot_alloc_inode, |
730 | .free_space = dquot_free_space, | 728 | .free_space = dquot_free_space, |
@@ -1438,7 +1436,7 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
1438 | } | 1436 | } |
1439 | 1437 | ||
1440 | list_add(&EXT3_I(inode)->i_orphan, &EXT3_SB(sb)->s_orphan); | 1438 | list_add(&EXT3_I(inode)->i_orphan, &EXT3_SB(sb)->s_orphan); |
1441 | DQUOT_INIT(inode); | 1439 | vfs_dq_init(inode); |
1442 | if (inode->i_nlink) { | 1440 | if (inode->i_nlink) { |
1443 | printk(KERN_DEBUG | 1441 | printk(KERN_DEBUG |
1444 | "%s: truncating inode %lu to %Ld bytes\n", | 1442 | "%s: truncating inode %lu to %Ld bytes\n", |
@@ -2702,7 +2700,7 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf) | |||
2702 | * Process 1 Process 2 | 2700 | * Process 1 Process 2 |
2703 | * ext3_create() quota_sync() | 2701 | * ext3_create() quota_sync() |
2704 | * journal_start() write_dquot() | 2702 | * journal_start() write_dquot() |
2705 | * DQUOT_INIT() down(dqio_mutex) | 2703 | * vfs_dq_init() down(dqio_mutex) |
2706 | * down(dqio_mutex) journal_start() | 2704 | * down(dqio_mutex) journal_start() |
2707 | * | 2705 | * |
2708 | */ | 2706 | */ |
@@ -2714,44 +2712,6 @@ static inline struct inode *dquot_to_inode(struct dquot *dquot) | |||
2714 | return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type]; | 2712 | return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type]; |
2715 | } | 2713 | } |
2716 | 2714 | ||
2717 | static int ext3_dquot_initialize(struct inode *inode, int type) | ||
2718 | { | ||
2719 | handle_t *handle; | ||
2720 | int ret, err; | ||
2721 | |||
2722 | /* We may create quota structure so we need to reserve enough blocks */ | ||
2723 | handle = ext3_journal_start(inode, 2*EXT3_QUOTA_INIT_BLOCKS(inode->i_sb)); | ||
2724 | if (IS_ERR(handle)) | ||
2725 | return PTR_ERR(handle); | ||
2726 | ret = dquot_initialize(inode, type); | ||
2727 | err = ext3_journal_stop(handle); | ||
2728 | if (!ret) | ||
2729 | ret = err; | ||
2730 | return ret; | ||
2731 | } | ||
2732 | |||
2733 | static int ext3_dquot_drop(struct inode *inode) | ||
2734 | { | ||
2735 | handle_t *handle; | ||
2736 | int ret, err; | ||
2737 | |||
2738 | /* We may delete quota structure so we need to reserve enough blocks */ | ||
2739 | handle = ext3_journal_start(inode, 2*EXT3_QUOTA_DEL_BLOCKS(inode->i_sb)); | ||
2740 | if (IS_ERR(handle)) { | ||
2741 | /* | ||
2742 | * We call dquot_drop() anyway to at least release references | ||
2743 | * to quota structures so that umount does not hang. | ||
2744 | */ | ||
2745 | dquot_drop(inode); | ||
2746 | return PTR_ERR(handle); | ||
2747 | } | ||
2748 | ret = dquot_drop(inode); | ||
2749 | err = ext3_journal_stop(handle); | ||
2750 | if (!ret) | ||
2751 | ret = err; | ||
2752 | return ret; | ||
2753 | } | ||
2754 | |||
2755 | static int ext3_write_dquot(struct dquot *dquot) | 2715 | static int ext3_write_dquot(struct dquot *dquot) |
2756 | { | 2716 | { |
2757 | int ret, err; | 2717 | int ret, err; |
diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c index 175414ac2210..83b7be849bd5 100644 --- a/fs/ext3/xattr.c +++ b/fs/ext3/xattr.c | |||
@@ -498,7 +498,7 @@ ext3_xattr_release_block(handle_t *handle, struct inode *inode, | |||
498 | error = ext3_journal_dirty_metadata(handle, bh); | 498 | error = ext3_journal_dirty_metadata(handle, bh); |
499 | if (IS_SYNC(inode)) | 499 | if (IS_SYNC(inode)) |
500 | handle->h_sync = 1; | 500 | handle->h_sync = 1; |
501 | DQUOT_FREE_BLOCK(inode, 1); | 501 | vfs_dq_free_block(inode, 1); |
502 | ea_bdebug(bh, "refcount now=%d; releasing", | 502 | ea_bdebug(bh, "refcount now=%d; releasing", |
503 | le32_to_cpu(BHDR(bh)->h_refcount)); | 503 | le32_to_cpu(BHDR(bh)->h_refcount)); |
504 | if (ce) | 504 | if (ce) |
@@ -774,7 +774,7 @@ inserted: | |||
774 | /* The old block is released after updating | 774 | /* The old block is released after updating |
775 | the inode. */ | 775 | the inode. */ |
776 | error = -EDQUOT; | 776 | error = -EDQUOT; |
777 | if (DQUOT_ALLOC_BLOCK(inode, 1)) | 777 | if (vfs_dq_alloc_block(inode, 1)) |
778 | goto cleanup; | 778 | goto cleanup; |
779 | error = ext3_journal_get_write_access(handle, | 779 | error = ext3_journal_get_write_access(handle, |
780 | new_bh); | 780 | new_bh); |
@@ -848,7 +848,7 @@ cleanup: | |||
848 | return error; | 848 | return error; |
849 | 849 | ||
850 | cleanup_dquot: | 850 | cleanup_dquot: |
851 | DQUOT_FREE_BLOCK(inode, 1); | 851 | vfs_dq_free_block(inode, 1); |
852 | goto cleanup; | 852 | goto cleanup; |
853 | 853 | ||
854 | bad_block: | 854 | bad_block: |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index de9459b4cb94..38f40d55899c 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -536,7 +536,7 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, | |||
536 | ext4_mb_free_blocks(handle, inode, block, count, | 536 | ext4_mb_free_blocks(handle, inode, block, count, |
537 | metadata, &dquot_freed_blocks); | 537 | metadata, &dquot_freed_blocks); |
538 | if (dquot_freed_blocks) | 538 | if (dquot_freed_blocks) |
539 | DQUOT_FREE_BLOCK(inode, dquot_freed_blocks); | 539 | vfs_dq_free_block(inode, dquot_freed_blocks); |
540 | return; | 540 | return; |
541 | } | 541 | } |
542 | 542 | ||
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index b0c87dce66a3..6083bb38057b 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -20,6 +20,7 @@ | |||
20 | #include <linux/blkdev.h> | 20 | #include <linux/blkdev.h> |
21 | #include <linux/magic.h> | 21 | #include <linux/magic.h> |
22 | #include <linux/jbd2.h> | 22 | #include <linux/jbd2.h> |
23 | #include <linux/quota.h> | ||
23 | #include "ext4_i.h" | 24 | #include "ext4_i.h" |
24 | 25 | ||
25 | /* | 26 | /* |
@@ -1098,6 +1099,7 @@ extern int ext4_chunk_trans_blocks(struct inode *, int nrblocks); | |||
1098 | extern int ext4_block_truncate_page(handle_t *handle, | 1099 | extern int ext4_block_truncate_page(handle_t *handle, |
1099 | struct address_space *mapping, loff_t from); | 1100 | struct address_space *mapping, loff_t from); |
1100 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page); | 1101 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page); |
1102 | extern qsize_t ext4_get_reserved_space(struct inode *inode); | ||
1101 | 1103 | ||
1102 | /* ioctl.c */ | 1104 | /* ioctl.c */ |
1103 | extern long ext4_ioctl(struct file *, unsigned int, unsigned long); | 1105 | extern long ext4_ioctl(struct file *, unsigned int, unsigned long); |
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 2d2b3585ee91..fb51b40e3e8f 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -220,10 +220,10 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
220 | * Note: we must free any quota before locking the superblock, | 220 | * Note: we must free any quota before locking the superblock, |
221 | * as writing the quota to disk may need the lock as well. | 221 | * as writing the quota to disk may need the lock as well. |
222 | */ | 222 | */ |
223 | DQUOT_INIT(inode); | 223 | vfs_dq_init(inode); |
224 | ext4_xattr_delete_inode(handle, inode); | 224 | ext4_xattr_delete_inode(handle, inode); |
225 | DQUOT_FREE_INODE(inode); | 225 | vfs_dq_free_inode(inode); |
226 | DQUOT_DROP(inode); | 226 | vfs_dq_drop(inode); |
227 | 227 | ||
228 | is_directory = S_ISDIR(inode->i_mode); | 228 | is_directory = S_ISDIR(inode->i_mode); |
229 | 229 | ||
@@ -915,7 +915,7 @@ got: | |||
915 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; | 915 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; |
916 | 916 | ||
917 | ret = inode; | 917 | ret = inode; |
918 | if (DQUOT_ALLOC_INODE(inode)) { | 918 | if (vfs_dq_alloc_inode(inode)) { |
919 | err = -EDQUOT; | 919 | err = -EDQUOT; |
920 | goto fail_drop; | 920 | goto fail_drop; |
921 | } | 921 | } |
@@ -956,10 +956,10 @@ really_out: | |||
956 | return ret; | 956 | return ret; |
957 | 957 | ||
958 | fail_free_drop: | 958 | fail_free_drop: |
959 | DQUOT_FREE_INODE(inode); | 959 | vfs_dq_free_inode(inode); |
960 | 960 | ||
961 | fail_drop: | 961 | fail_drop: |
962 | DQUOT_DROP(inode); | 962 | vfs_dq_drop(inode); |
963 | inode->i_flags |= S_NOQUOTA; | 963 | inode->i_flags |= S_NOQUOTA; |
964 | inode->i_nlink = 0; | 964 | inode->i_nlink = 0; |
965 | unlock_new_inode(inode); | 965 | unlock_new_inode(inode); |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index c7fed5b18745..71d3ecd5db79 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -975,6 +975,17 @@ out: | |||
975 | return err; | 975 | return err; |
976 | } | 976 | } |
977 | 977 | ||
978 | qsize_t ext4_get_reserved_space(struct inode *inode) | ||
979 | { | ||
980 | unsigned long long total; | ||
981 | |||
982 | spin_lock(&EXT4_I(inode)->i_block_reservation_lock); | ||
983 | total = EXT4_I(inode)->i_reserved_data_blocks + | ||
984 | EXT4_I(inode)->i_reserved_meta_blocks; | ||
985 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | ||
986 | |||
987 | return total; | ||
988 | } | ||
978 | /* | 989 | /* |
979 | * Calculate the number of metadata blocks need to reserve | 990 | * Calculate the number of metadata blocks need to reserve |
980 | * to allocate @blocks for non extent file based file | 991 | * to allocate @blocks for non extent file based file |
@@ -1036,8 +1047,14 @@ static void ext4_da_update_reserve_space(struct inode *inode, int used) | |||
1036 | /* update per-inode reservations */ | 1047 | /* update per-inode reservations */ |
1037 | BUG_ON(used > EXT4_I(inode)->i_reserved_data_blocks); | 1048 | BUG_ON(used > EXT4_I(inode)->i_reserved_data_blocks); |
1038 | EXT4_I(inode)->i_reserved_data_blocks -= used; | 1049 | EXT4_I(inode)->i_reserved_data_blocks -= used; |
1039 | |||
1040 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | 1050 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); |
1051 | |||
1052 | /* | ||
1053 | * free those over-booking quota for metadata blocks | ||
1054 | */ | ||
1055 | |||
1056 | if (mdb_free) | ||
1057 | vfs_dq_release_reservation_block(inode, mdb_free); | ||
1041 | } | 1058 | } |
1042 | 1059 | ||
1043 | /* | 1060 | /* |
@@ -1553,8 +1570,8 @@ static int ext4_journalled_write_end(struct file *file, | |||
1553 | static int ext4_da_reserve_space(struct inode *inode, int nrblocks) | 1570 | static int ext4_da_reserve_space(struct inode *inode, int nrblocks) |
1554 | { | 1571 | { |
1555 | int retries = 0; | 1572 | int retries = 0; |
1556 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); | 1573 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); |
1557 | unsigned long md_needed, mdblocks, total = 0; | 1574 | unsigned long md_needed, mdblocks, total = 0; |
1558 | 1575 | ||
1559 | /* | 1576 | /* |
1560 | * recalculate the amount of metadata blocks to reserve | 1577 | * recalculate the amount of metadata blocks to reserve |
@@ -1570,12 +1587,23 @@ repeat: | |||
1570 | md_needed = mdblocks - EXT4_I(inode)->i_reserved_meta_blocks; | 1587 | md_needed = mdblocks - EXT4_I(inode)->i_reserved_meta_blocks; |
1571 | total = md_needed + nrblocks; | 1588 | total = md_needed + nrblocks; |
1572 | 1589 | ||
1590 | /* | ||
1591 | * Make quota reservation here to prevent quota overflow | ||
1592 | * later. Real quota accounting is done at pages writeout | ||
1593 | * time. | ||
1594 | */ | ||
1595 | if (vfs_dq_reserve_block(inode, total)) { | ||
1596 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | ||
1597 | return -EDQUOT; | ||
1598 | } | ||
1599 | |||
1573 | if (ext4_claim_free_blocks(sbi, total)) { | 1600 | if (ext4_claim_free_blocks(sbi, total)) { |
1574 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | 1601 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); |
1575 | if (ext4_should_retry_alloc(inode->i_sb, &retries)) { | 1602 | if (ext4_should_retry_alloc(inode->i_sb, &retries)) { |
1576 | yield(); | 1603 | yield(); |
1577 | goto repeat; | 1604 | goto repeat; |
1578 | } | 1605 | } |
1606 | vfs_dq_release_reservation_block(inode, total); | ||
1579 | return -ENOSPC; | 1607 | return -ENOSPC; |
1580 | } | 1608 | } |
1581 | EXT4_I(inode)->i_reserved_data_blocks += nrblocks; | 1609 | EXT4_I(inode)->i_reserved_data_blocks += nrblocks; |
@@ -1629,6 +1657,8 @@ static void ext4_da_release_space(struct inode *inode, int to_free) | |||
1629 | BUG_ON(mdb > EXT4_I(inode)->i_reserved_meta_blocks); | 1657 | BUG_ON(mdb > EXT4_I(inode)->i_reserved_meta_blocks); |
1630 | EXT4_I(inode)->i_reserved_meta_blocks = mdb; | 1658 | EXT4_I(inode)->i_reserved_meta_blocks = mdb; |
1631 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | 1659 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); |
1660 | |||
1661 | vfs_dq_release_reservation_block(inode, release); | ||
1632 | } | 1662 | } |
1633 | 1663 | ||
1634 | static void ext4_da_page_release_reservation(struct page *page, | 1664 | static void ext4_da_page_release_reservation(struct page *page, |
@@ -4612,7 +4642,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
4612 | error = PTR_ERR(handle); | 4642 | error = PTR_ERR(handle); |
4613 | goto err_out; | 4643 | goto err_out; |
4614 | } | 4644 | } |
4615 | error = DQUOT_TRANSFER(inode, attr) ? -EDQUOT : 0; | 4645 | error = vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; |
4616 | if (error) { | 4646 | if (error) { |
4617 | ext4_journal_stop(handle); | 4647 | ext4_journal_stop(handle); |
4618 | return error; | 4648 | return error; |
@@ -4991,7 +5021,7 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
4991 | * i_size has been changed by generic_commit_write() and we thus need | 5021 | * i_size has been changed by generic_commit_write() and we thus need |
4992 | * to include the updated inode in the current transaction. | 5022 | * to include the updated inode in the current transaction. |
4993 | * | 5023 | * |
4994 | * Also, DQUOT_ALLOC_SPACE() will always dirty the inode when blocks | 5024 | * Also, vfs_dq_alloc_block() will always dirty the inode when blocks |
4995 | * are allocated to the file. | 5025 | * are allocated to the file. |
4996 | * | 5026 | * |
4997 | * If the inode is marked synchronous, we don't honour that here - doing | 5027 | * If the inode is marked synchronous, we don't honour that here - doing |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 9f61e62f435f..b038188bd039 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -3086,9 +3086,12 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, | |||
3086 | if (!(ac->ac_flags & EXT4_MB_DELALLOC_RESERVED)) | 3086 | if (!(ac->ac_flags & EXT4_MB_DELALLOC_RESERVED)) |
3087 | /* release all the reserved blocks if non delalloc */ | 3087 | /* release all the reserved blocks if non delalloc */ |
3088 | percpu_counter_sub(&sbi->s_dirtyblocks_counter, reserv_blks); | 3088 | percpu_counter_sub(&sbi->s_dirtyblocks_counter, reserv_blks); |
3089 | else | 3089 | else { |
3090 | percpu_counter_sub(&sbi->s_dirtyblocks_counter, | 3090 | percpu_counter_sub(&sbi->s_dirtyblocks_counter, |
3091 | ac->ac_b_ex.fe_len); | 3091 | ac->ac_b_ex.fe_len); |
3092 | /* convert reserved quota blocks to real quota blocks */ | ||
3093 | vfs_dq_claim_block(ac->ac_inode, ac->ac_b_ex.fe_len); | ||
3094 | } | ||
3092 | 3095 | ||
3093 | if (sbi->s_log_groups_per_flex) { | 3096 | if (sbi->s_log_groups_per_flex) { |
3094 | ext4_group_t flex_group = ext4_flex_group(sbi, | 3097 | ext4_group_t flex_group = ext4_flex_group(sbi, |
@@ -4544,7 +4547,7 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle, | |||
4544 | struct ext4_sb_info *sbi; | 4547 | struct ext4_sb_info *sbi; |
4545 | struct super_block *sb; | 4548 | struct super_block *sb; |
4546 | ext4_fsblk_t block = 0; | 4549 | ext4_fsblk_t block = 0; |
4547 | unsigned int inquota; | 4550 | unsigned int inquota = 0; |
4548 | unsigned int reserv_blks = 0; | 4551 | unsigned int reserv_blks = 0; |
4549 | 4552 | ||
4550 | sb = ar->inode->i_sb; | 4553 | sb = ar->inode->i_sb; |
@@ -4562,9 +4565,17 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle, | |||
4562 | (unsigned long long) ar->pleft, | 4565 | (unsigned long long) ar->pleft, |
4563 | (unsigned long long) ar->pright); | 4566 | (unsigned long long) ar->pright); |
4564 | 4567 | ||
4565 | if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) { | 4568 | /* |
4566 | /* | 4569 | * For delayed allocation, we could skip the ENOSPC and |
4567 | * With delalloc we already reserved the blocks | 4570 | * EDQUOT check, as blocks and quotas have been already |
4571 | * reserved when data being copied into pagecache. | ||
4572 | */ | ||
4573 | if (EXT4_I(ar->inode)->i_delalloc_reserved_flag) | ||
4574 | ar->flags |= EXT4_MB_DELALLOC_RESERVED; | ||
4575 | else { | ||
4576 | /* Without delayed allocation we need to verify | ||
4577 | * there is enough free blocks to do block allocation | ||
4578 | * and verify allocation doesn't exceed the quota limits. | ||
4568 | */ | 4579 | */ |
4569 | while (ar->len && ext4_claim_free_blocks(sbi, ar->len)) { | 4580 | while (ar->len && ext4_claim_free_blocks(sbi, ar->len)) { |
4570 | /* let others to free the space */ | 4581 | /* let others to free the space */ |
@@ -4576,19 +4587,16 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle, | |||
4576 | return 0; | 4587 | return 0; |
4577 | } | 4588 | } |
4578 | reserv_blks = ar->len; | 4589 | reserv_blks = ar->len; |
4590 | while (ar->len && vfs_dq_alloc_block(ar->inode, ar->len)) { | ||
4591 | ar->flags |= EXT4_MB_HINT_NOPREALLOC; | ||
4592 | ar->len--; | ||
4593 | } | ||
4594 | inquota = ar->len; | ||
4595 | if (ar->len == 0) { | ||
4596 | *errp = -EDQUOT; | ||
4597 | goto out3; | ||
4598 | } | ||
4579 | } | 4599 | } |
4580 | while (ar->len && DQUOT_ALLOC_BLOCK(ar->inode, ar->len)) { | ||
4581 | ar->flags |= EXT4_MB_HINT_NOPREALLOC; | ||
4582 | ar->len--; | ||
4583 | } | ||
4584 | if (ar->len == 0) { | ||
4585 | *errp = -EDQUOT; | ||
4586 | goto out3; | ||
4587 | } | ||
4588 | inquota = ar->len; | ||
4589 | |||
4590 | if (EXT4_I(ar->inode)->i_delalloc_reserved_flag) | ||
4591 | ar->flags |= EXT4_MB_DELALLOC_RESERVED; | ||
4592 | 4600 | ||
4593 | ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS); | 4601 | ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS); |
4594 | if (!ac) { | 4602 | if (!ac) { |
@@ -4654,8 +4662,8 @@ repeat: | |||
4654 | out2: | 4662 | out2: |
4655 | kmem_cache_free(ext4_ac_cachep, ac); | 4663 | kmem_cache_free(ext4_ac_cachep, ac); |
4656 | out1: | 4664 | out1: |
4657 | if (ar->len < inquota) | 4665 | if (inquota && ar->len < inquota) |
4658 | DQUOT_FREE_BLOCK(ar->inode, inquota - ar->len); | 4666 | vfs_dq_free_block(ar->inode, inquota - ar->len); |
4659 | out3: | 4667 | out3: |
4660 | if (!ar->len) { | 4668 | if (!ar->len) { |
4661 | if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) | 4669 | if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index ba702bd7910d..83410244d3ee 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -2092,7 +2092,7 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry) | |||
2092 | 2092 | ||
2093 | /* Initialize quotas before so that eventual writes go in | 2093 | /* Initialize quotas before so that eventual writes go in |
2094 | * separate transaction */ | 2094 | * separate transaction */ |
2095 | DQUOT_INIT(dentry->d_inode); | 2095 | vfs_dq_init(dentry->d_inode); |
2096 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2096 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2097 | if (IS_ERR(handle)) | 2097 | if (IS_ERR(handle)) |
2098 | return PTR_ERR(handle); | 2098 | return PTR_ERR(handle); |
@@ -2151,7 +2151,7 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry) | |||
2151 | 2151 | ||
2152 | /* Initialize quotas before so that eventual writes go | 2152 | /* Initialize quotas before so that eventual writes go |
2153 | * in separate transaction */ | 2153 | * in separate transaction */ |
2154 | DQUOT_INIT(dentry->d_inode); | 2154 | vfs_dq_init(dentry->d_inode); |
2155 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2155 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2156 | if (IS_ERR(handle)) | 2156 | if (IS_ERR(handle)) |
2157 | return PTR_ERR(handle); | 2157 | return PTR_ERR(handle); |
@@ -2318,7 +2318,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2318 | /* Initialize quotas before so that eventual writes go | 2318 | /* Initialize quotas before so that eventual writes go |
2319 | * in separate transaction */ | 2319 | * in separate transaction */ |
2320 | if (new_dentry->d_inode) | 2320 | if (new_dentry->d_inode) |
2321 | DQUOT_INIT(new_dentry->d_inode); | 2321 | vfs_dq_init(new_dentry->d_inode); |
2322 | handle = ext4_journal_start(old_dir, 2 * | 2322 | handle = ext4_journal_start(old_dir, 2 * |
2323 | EXT4_DATA_TRANS_BLOCKS(old_dir->i_sb) + | 2323 | EXT4_DATA_TRANS_BLOCKS(old_dir->i_sb) + |
2324 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 2); | 2324 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 2); |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 39d1993cfa13..f7371a6a923d 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -926,8 +926,6 @@ static int bdev_try_to_free_page(struct super_block *sb, struct page *page, gfp_ | |||
926 | #define QTYPE2NAME(t) ((t) == USRQUOTA ? "user" : "group") | 926 | #define QTYPE2NAME(t) ((t) == USRQUOTA ? "user" : "group") |
927 | #define QTYPE2MOPT(on, t) ((t) == USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA)) | 927 | #define QTYPE2MOPT(on, t) ((t) == USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA)) |
928 | 928 | ||
929 | static int ext4_dquot_initialize(struct inode *inode, int type); | ||
930 | static int ext4_dquot_drop(struct inode *inode); | ||
931 | static int ext4_write_dquot(struct dquot *dquot); | 929 | static int ext4_write_dquot(struct dquot *dquot); |
932 | static int ext4_acquire_dquot(struct dquot *dquot); | 930 | static int ext4_acquire_dquot(struct dquot *dquot); |
933 | static int ext4_release_dquot(struct dquot *dquot); | 931 | static int ext4_release_dquot(struct dquot *dquot); |
@@ -942,9 +940,13 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
942 | const char *data, size_t len, loff_t off); | 940 | const char *data, size_t len, loff_t off); |
943 | 941 | ||
944 | static struct dquot_operations ext4_quota_operations = { | 942 | static struct dquot_operations ext4_quota_operations = { |
945 | .initialize = ext4_dquot_initialize, | 943 | .initialize = dquot_initialize, |
946 | .drop = ext4_dquot_drop, | 944 | .drop = dquot_drop, |
947 | .alloc_space = dquot_alloc_space, | 945 | .alloc_space = dquot_alloc_space, |
946 | .reserve_space = dquot_reserve_space, | ||
947 | .claim_space = dquot_claim_space, | ||
948 | .release_rsv = dquot_release_reserved_space, | ||
949 | .get_reserved_space = ext4_get_reserved_space, | ||
948 | .alloc_inode = dquot_alloc_inode, | 950 | .alloc_inode = dquot_alloc_inode, |
949 | .free_space = dquot_free_space, | 951 | .free_space = dquot_free_space, |
950 | .free_inode = dquot_free_inode, | 952 | .free_inode = dquot_free_inode, |
@@ -1802,7 +1804,7 @@ static void ext4_orphan_cleanup(struct super_block *sb, | |||
1802 | } | 1804 | } |
1803 | 1805 | ||
1804 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); | 1806 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); |
1805 | DQUOT_INIT(inode); | 1807 | vfs_dq_init(inode); |
1806 | if (inode->i_nlink) { | 1808 | if (inode->i_nlink) { |
1807 | printk(KERN_DEBUG | 1809 | printk(KERN_DEBUG |
1808 | "%s: truncating inode %lu to %lld bytes\n", | 1810 | "%s: truncating inode %lu to %lld bytes\n", |
@@ -3367,8 +3369,8 @@ static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
3367 | * is locked for write. Otherwise the are possible deadlocks: | 3369 | * is locked for write. Otherwise the are possible deadlocks: |
3368 | * Process 1 Process 2 | 3370 | * Process 1 Process 2 |
3369 | * ext4_create() quota_sync() | 3371 | * ext4_create() quota_sync() |
3370 | * jbd2_journal_start() write_dquot() | 3372 | * jbd2_journal_start() write_dquot() |
3371 | * DQUOT_INIT() down(dqio_mutex) | 3373 | * vfs_dq_init() down(dqio_mutex) |
3372 | * down(dqio_mutex) jbd2_journal_start() | 3374 | * down(dqio_mutex) jbd2_journal_start() |
3373 | * | 3375 | * |
3374 | */ | 3376 | */ |
@@ -3380,44 +3382,6 @@ static inline struct inode *dquot_to_inode(struct dquot *dquot) | |||
3380 | return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type]; | 3382 | return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type]; |
3381 | } | 3383 | } |
3382 | 3384 | ||
3383 | static int ext4_dquot_initialize(struct inode *inode, int type) | ||
3384 | { | ||
3385 | handle_t *handle; | ||
3386 | int ret, err; | ||
3387 | |||
3388 | /* We may create quota structure so we need to reserve enough blocks */ | ||
3389 | handle = ext4_journal_start(inode, 2*EXT4_QUOTA_INIT_BLOCKS(inode->i_sb)); | ||
3390 | if (IS_ERR(handle)) | ||
3391 | return PTR_ERR(handle); | ||
3392 | ret = dquot_initialize(inode, type); | ||
3393 | err = ext4_journal_stop(handle); | ||
3394 | if (!ret) | ||
3395 | ret = err; | ||
3396 | return ret; | ||
3397 | } | ||
3398 | |||
3399 | static int ext4_dquot_drop(struct inode *inode) | ||
3400 | { | ||
3401 | handle_t *handle; | ||
3402 | int ret, err; | ||
3403 | |||
3404 | /* We may delete quota structure so we need to reserve enough blocks */ | ||
3405 | handle = ext4_journal_start(inode, 2*EXT4_QUOTA_DEL_BLOCKS(inode->i_sb)); | ||
3406 | if (IS_ERR(handle)) { | ||
3407 | /* | ||
3408 | * We call dquot_drop() anyway to at least release references | ||
3409 | * to quota structures so that umount does not hang. | ||
3410 | */ | ||
3411 | dquot_drop(inode); | ||
3412 | return PTR_ERR(handle); | ||
3413 | } | ||
3414 | ret = dquot_drop(inode); | ||
3415 | err = ext4_journal_stop(handle); | ||
3416 | if (!ret) | ||
3417 | ret = err; | ||
3418 | return ret; | ||
3419 | } | ||
3420 | |||
3421 | static int ext4_write_dquot(struct dquot *dquot) | 3385 | static int ext4_write_dquot(struct dquot *dquot) |
3422 | { | 3386 | { |
3423 | int ret, err; | 3387 | int ret, err; |
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 157ce6589c54..62b31c246994 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c | |||
@@ -490,7 +490,7 @@ ext4_xattr_release_block(handle_t *handle, struct inode *inode, | |||
490 | error = ext4_handle_dirty_metadata(handle, inode, bh); | 490 | error = ext4_handle_dirty_metadata(handle, inode, bh); |
491 | if (IS_SYNC(inode)) | 491 | if (IS_SYNC(inode)) |
492 | ext4_handle_sync(handle); | 492 | ext4_handle_sync(handle); |
493 | DQUOT_FREE_BLOCK(inode, 1); | 493 | vfs_dq_free_block(inode, 1); |
494 | ea_bdebug(bh, "refcount now=%d; releasing", | 494 | ea_bdebug(bh, "refcount now=%d; releasing", |
495 | le32_to_cpu(BHDR(bh)->h_refcount)); | 495 | le32_to_cpu(BHDR(bh)->h_refcount)); |
496 | if (ce) | 496 | if (ce) |
@@ -784,7 +784,7 @@ inserted: | |||
784 | /* The old block is released after updating | 784 | /* The old block is released after updating |
785 | the inode. */ | 785 | the inode. */ |
786 | error = -EDQUOT; | 786 | error = -EDQUOT; |
787 | if (DQUOT_ALLOC_BLOCK(inode, 1)) | 787 | if (vfs_dq_alloc_block(inode, 1)) |
788 | goto cleanup; | 788 | goto cleanup; |
789 | error = ext4_journal_get_write_access(handle, | 789 | error = ext4_journal_get_write_access(handle, |
790 | new_bh); | 790 | new_bh); |
@@ -860,7 +860,7 @@ cleanup: | |||
860 | return error; | 860 | return error; |
861 | 861 | ||
862 | cleanup_dquot: | 862 | cleanup_dquot: |
863 | DQUOT_FREE_BLOCK(inode, 1); | 863 | vfs_dq_free_block(inode, 1); |
864 | goto cleanup; | 864 | goto cleanup; |
865 | 865 | ||
866 | bad_block: | 866 | bad_block: |
diff --git a/fs/fat/namei_msdos.c b/fs/fat/namei_msdos.c index 7ba03a4acbe0..da3f361a37dd 100644 --- a/fs/fat/namei_msdos.c +++ b/fs/fat/namei_msdos.c | |||
@@ -188,7 +188,7 @@ old_compare: | |||
188 | goto out; | 188 | goto out; |
189 | } | 189 | } |
190 | 190 | ||
191 | static struct dentry_operations msdos_dentry_operations = { | 191 | static const struct dentry_operations msdos_dentry_operations = { |
192 | .d_hash = msdos_hash, | 192 | .d_hash = msdos_hash, |
193 | .d_compare = msdos_cmp, | 193 | .d_compare = msdos_cmp, |
194 | }; | 194 | }; |
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c index 8ae32e37673c..a0e00e3a46e9 100644 --- a/fs/fat/namei_vfat.c +++ b/fs/fat/namei_vfat.c | |||
@@ -166,13 +166,13 @@ static int vfat_cmp(struct dentry *dentry, struct qstr *a, struct qstr *b) | |||
166 | return 1; | 166 | return 1; |
167 | } | 167 | } |
168 | 168 | ||
169 | static struct dentry_operations vfat_ci_dentry_ops = { | 169 | static const struct dentry_operations vfat_ci_dentry_ops = { |
170 | .d_revalidate = vfat_revalidate_ci, | 170 | .d_revalidate = vfat_revalidate_ci, |
171 | .d_hash = vfat_hashi, | 171 | .d_hash = vfat_hashi, |
172 | .d_compare = vfat_cmpi, | 172 | .d_compare = vfat_cmpi, |
173 | }; | 173 | }; |
174 | 174 | ||
175 | static struct dentry_operations vfat_dentry_ops = { | 175 | static const struct dentry_operations vfat_dentry_ops = { |
176 | .d_revalidate = vfat_revalidate, | 176 | .d_revalidate = vfat_revalidate, |
177 | .d_hash = vfat_hash, | 177 | .d_hash = vfat_hash, |
178 | .d_compare = vfat_cmp, | 178 | .d_compare = vfat_cmp, |
diff --git a/fs/fcntl.c b/fs/fcntl.c index bd215cc791da..cc8e4de2fee5 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c | |||
@@ -141,7 +141,7 @@ SYSCALL_DEFINE1(dup, unsigned int, fildes) | |||
141 | return ret; | 141 | return ret; |
142 | } | 142 | } |
143 | 143 | ||
144 | #define SETFL_MASK (O_APPEND | O_NONBLOCK | O_NDELAY | FASYNC | O_DIRECT | O_NOATIME) | 144 | #define SETFL_MASK (O_APPEND | O_NONBLOCK | O_NDELAY | O_DIRECT | O_NOATIME) |
145 | 145 | ||
146 | static int setfl(int fd, struct file * filp, unsigned long arg) | 146 | static int setfl(int fd, struct file * filp, unsigned long arg) |
147 | { | 147 | { |
@@ -177,21 +177,21 @@ static int setfl(int fd, struct file * filp, unsigned long arg) | |||
177 | return error; | 177 | return error; |
178 | 178 | ||
179 | /* | 179 | /* |
180 | * We still need a lock here for now to keep multiple FASYNC calls | 180 | * ->fasync() is responsible for setting the FASYNC bit. |
181 | * from racing with each other. | ||
182 | */ | 181 | */ |
183 | lock_kernel(); | 182 | if (((arg ^ filp->f_flags) & FASYNC) && filp->f_op && |
184 | if ((arg ^ filp->f_flags) & FASYNC) { | 183 | filp->f_op->fasync) { |
185 | if (filp->f_op && filp->f_op->fasync) { | 184 | error = filp->f_op->fasync(fd, filp, (arg & FASYNC) != 0); |
186 | error = filp->f_op->fasync(fd, filp, (arg & FASYNC) != 0); | 185 | if (error < 0) |
187 | if (error < 0) | 186 | goto out; |
188 | goto out; | 187 | if (error > 0) |
189 | } | 188 | error = 0; |
190 | } | 189 | } |
191 | 190 | spin_lock(&filp->f_lock); | |
192 | filp->f_flags = (arg & SETFL_MASK) | (filp->f_flags & ~SETFL_MASK); | 191 | filp->f_flags = (arg & SETFL_MASK) | (filp->f_flags & ~SETFL_MASK); |
192 | spin_unlock(&filp->f_lock); | ||
193 | |||
193 | out: | 194 | out: |
194 | unlock_kernel(); | ||
195 | return error; | 195 | return error; |
196 | } | 196 | } |
197 | 197 | ||
@@ -516,7 +516,7 @@ static DEFINE_RWLOCK(fasync_lock); | |||
516 | static struct kmem_cache *fasync_cache __read_mostly; | 516 | static struct kmem_cache *fasync_cache __read_mostly; |
517 | 517 | ||
518 | /* | 518 | /* |
519 | * fasync_helper() is used by some character device drivers (mainly mice) | 519 | * fasync_helper() is used by almost all character device drivers |
520 | * to set up the fasync queue. It returns negative on error, 0 if it did | 520 | * to set up the fasync queue. It returns negative on error, 0 if it did |
521 | * no changes and positive if it added/deleted the entry. | 521 | * no changes and positive if it added/deleted the entry. |
522 | */ | 522 | */ |
@@ -531,6 +531,12 @@ int fasync_helper(int fd, struct file * filp, int on, struct fasync_struct **fap | |||
531 | if (!new) | 531 | if (!new) |
532 | return -ENOMEM; | 532 | return -ENOMEM; |
533 | } | 533 | } |
534 | |||
535 | /* | ||
536 | * We need to take f_lock first since it's not an IRQ-safe | ||
537 | * lock. | ||
538 | */ | ||
539 | spin_lock(&filp->f_lock); | ||
534 | write_lock_irq(&fasync_lock); | 540 | write_lock_irq(&fasync_lock); |
535 | for (fp = fapp; (fa = *fp) != NULL; fp = &fa->fa_next) { | 541 | for (fp = fapp; (fa = *fp) != NULL; fp = &fa->fa_next) { |
536 | if (fa->fa_file == filp) { | 542 | if (fa->fa_file == filp) { |
@@ -555,7 +561,12 @@ int fasync_helper(int fd, struct file * filp, int on, struct fasync_struct **fap | |||
555 | result = 1; | 561 | result = 1; |
556 | } | 562 | } |
557 | out: | 563 | out: |
564 | if (on) | ||
565 | filp->f_flags |= FASYNC; | ||
566 | else | ||
567 | filp->f_flags &= ~FASYNC; | ||
558 | write_unlock_irq(&fasync_lock); | 568 | write_unlock_irq(&fasync_lock); |
569 | spin_unlock(&filp->f_lock); | ||
559 | return result; | 570 | return result; |
560 | } | 571 | } |
561 | 572 | ||
diff --git a/fs/file_table.c b/fs/file_table.c index bbeeac6efa1a..b74a8e1da913 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
@@ -13,6 +13,7 @@ | |||
13 | #include <linux/module.h> | 13 | #include <linux/module.h> |
14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
15 | #include <linux/security.h> | 15 | #include <linux/security.h> |
16 | #include <linux/ima.h> | ||
16 | #include <linux/eventpoll.h> | 17 | #include <linux/eventpoll.h> |
17 | #include <linux/rcupdate.h> | 18 | #include <linux/rcupdate.h> |
18 | #include <linux/mount.h> | 19 | #include <linux/mount.h> |
@@ -127,6 +128,7 @@ struct file *get_empty_filp(void) | |||
127 | atomic_long_set(&f->f_count, 1); | 128 | atomic_long_set(&f->f_count, 1); |
128 | rwlock_init(&f->f_owner.lock); | 129 | rwlock_init(&f->f_owner.lock); |
129 | f->f_cred = get_cred(cred); | 130 | f->f_cred = get_cred(cred); |
131 | spin_lock_init(&f->f_lock); | ||
130 | eventpoll_init_file(f); | 132 | eventpoll_init_file(f); |
131 | /* f->f_version: 0 */ | 133 | /* f->f_version: 0 */ |
132 | return f; | 134 | return f; |
@@ -279,6 +281,7 @@ void __fput(struct file *file) | |||
279 | if (file->f_op && file->f_op->release) | 281 | if (file->f_op && file->f_op->release) |
280 | file->f_op->release(inode, file); | 282 | file->f_op->release(inode, file); |
281 | security_file_free(file); | 283 | security_file_free(file); |
284 | ima_file_free(file); | ||
282 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL)) | 285 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL)) |
283 | cdev_put(inode->i_cdev); | 286 | cdev_put(inode->i_cdev); |
284 | fops_put(file->f_op); | 287 | fops_put(file->f_op); |
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index fdff346e96fd..06da05261e04 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c | |||
@@ -224,7 +224,7 @@ static int invalid_nodeid(u64 nodeid) | |||
224 | return !nodeid || nodeid == FUSE_ROOT_ID; | 224 | return !nodeid || nodeid == FUSE_ROOT_ID; |
225 | } | 225 | } |
226 | 226 | ||
227 | struct dentry_operations fuse_dentry_operations = { | 227 | const struct dentry_operations fuse_dentry_operations = { |
228 | .d_revalidate = fuse_dentry_revalidate, | 228 | .d_revalidate = fuse_dentry_revalidate, |
229 | }; | 229 | }; |
230 | 230 | ||
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index d9fdb7cec538..821d10f719bd 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
@@ -1465,7 +1465,7 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin) | |||
1465 | case SEEK_END: | 1465 | case SEEK_END: |
1466 | retval = fuse_update_attributes(inode, NULL, file, NULL); | 1466 | retval = fuse_update_attributes(inode, NULL, file, NULL); |
1467 | if (retval) | 1467 | if (retval) |
1468 | return retval; | 1468 | goto exit; |
1469 | offset += i_size_read(inode); | 1469 | offset += i_size_read(inode); |
1470 | break; | 1470 | break; |
1471 | case SEEK_CUR: | 1471 | case SEEK_CUR: |
@@ -1479,6 +1479,7 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin) | |||
1479 | } | 1479 | } |
1480 | retval = offset; | 1480 | retval = offset; |
1481 | } | 1481 | } |
1482 | exit: | ||
1482 | mutex_unlock(&inode->i_mutex); | 1483 | mutex_unlock(&inode->i_mutex); |
1483 | return retval; | 1484 | return retval; |
1484 | } | 1485 | } |
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 5e64b815a5a1..6fc5aedaa0d5 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h | |||
@@ -493,7 +493,7 @@ static inline u64 get_node_id(struct inode *inode) | |||
493 | /** Device operations */ | 493 | /** Device operations */ |
494 | extern const struct file_operations fuse_dev_operations; | 494 | extern const struct file_operations fuse_dev_operations; |
495 | 495 | ||
496 | extern struct dentry_operations fuse_dentry_operations; | 496 | extern const struct dentry_operations fuse_dentry_operations; |
497 | 497 | ||
498 | /** | 498 | /** |
499 | * Get a filled in inode | 499 | * Get a filled in inode |
diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig index e563a6449811..3a981b7f64ca 100644 --- a/fs/gfs2/Kconfig +++ b/fs/gfs2/Kconfig | |||
@@ -1,6 +1,10 @@ | |||
1 | config GFS2_FS | 1 | config GFS2_FS |
2 | tristate "GFS2 file system support" | 2 | tristate "GFS2 file system support" |
3 | depends on EXPERIMENTAL && (64BIT || LBD) | 3 | depends on EXPERIMENTAL && (64BIT || LBD) |
4 | select DLM if GFS2_FS_LOCKING_DLM | ||
5 | select CONFIGFS_FS if GFS2_FS_LOCKING_DLM | ||
6 | select SYSFS if GFS2_FS_LOCKING_DLM | ||
7 | select IP_SCTP if DLM_SCTP | ||
4 | select FS_POSIX_ACL | 8 | select FS_POSIX_ACL |
5 | select CRC32 | 9 | select CRC32 |
6 | help | 10 | help |
@@ -18,17 +22,16 @@ config GFS2_FS | |||
18 | the locking module below. Documentation and utilities for GFS2 can | 22 | the locking module below. Documentation and utilities for GFS2 can |
19 | be found here: http://sources.redhat.com/cluster | 23 | be found here: http://sources.redhat.com/cluster |
20 | 24 | ||
21 | The "nolock" lock module is now built in to GFS2 by default. | 25 | The "nolock" lock module is now built in to GFS2 by default. If |
26 | you want to use the DLM, be sure to enable HOTPLUG and IPv4/6 | ||
27 | networking. | ||
22 | 28 | ||
23 | config GFS2_FS_LOCKING_DLM | 29 | config GFS2_FS_LOCKING_DLM |
24 | tristate "GFS2 DLM locking module" | 30 | bool "GFS2 DLM locking" |
25 | depends on GFS2_FS && SYSFS && NET && INET && (IPV6 || IPV6=n) | 31 | depends on (GFS2_FS!=n) && NET && INET && (IPV6 || IPV6=n) && HOTPLUG |
26 | select IP_SCTP if DLM_SCTP | ||
27 | select CONFIGFS_FS | ||
28 | select DLM | ||
29 | help | 32 | help |
30 | Multiple node locking module for GFS2 | 33 | Multiple node locking module for GFS2 |
31 | 34 | ||
32 | Most users of GFS2 will require this module. It provides the locking | 35 | Most users of GFS2 will require this. It provides the locking |
33 | interface between GFS2 and the DLM, which is required to use GFS2 | 36 | interface between GFS2 and the DLM, which is required to use GFS2 |
34 | in a cluster environment. | 37 | in a cluster environment. |
diff --git a/fs/gfs2/Makefile b/fs/gfs2/Makefile index c1b4ec6a9650..a851ea4bdf70 100644 --- a/fs/gfs2/Makefile +++ b/fs/gfs2/Makefile | |||
@@ -1,9 +1,9 @@ | |||
1 | obj-$(CONFIG_GFS2_FS) += gfs2.o | 1 | obj-$(CONFIG_GFS2_FS) += gfs2.o |
2 | gfs2-y := acl.o bmap.o dir.o eaops.o eattr.o glock.o \ | 2 | gfs2-y := acl.o bmap.o dir.o eaops.o eattr.o glock.o \ |
3 | glops.o inode.o log.o lops.o locking.o main.o meta_io.o \ | 3 | glops.o inode.o log.o lops.o main.o meta_io.o \ |
4 | mount.o ops_address.o ops_dentry.o ops_export.o ops_file.o \ | 4 | mount.o ops_address.o ops_dentry.o ops_export.o ops_file.o \ |
5 | ops_fstype.o ops_inode.o ops_super.o quota.o \ | 5 | ops_fstype.o ops_inode.o ops_super.o quota.o \ |
6 | recovery.o rgrp.o super.o sys.o trans.o util.o | 6 | recovery.o rgrp.o super.o sys.o trans.o util.o |
7 | 7 | ||
8 | obj-$(CONFIG_GFS2_FS_LOCKING_DLM) += locking/dlm/ | 8 | gfs2-$(CONFIG_GFS2_FS_LOCKING_DLM) += lock_dlm.o |
9 | 9 | ||
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index e335dceb6a4f..43764f4fa763 100644 --- a/fs/gfs2/acl.c +++ b/fs/gfs2/acl.c | |||
@@ -15,7 +15,6 @@ | |||
15 | #include <linux/posix_acl.h> | 15 | #include <linux/posix_acl.h> |
16 | #include <linux/posix_acl_xattr.h> | 16 | #include <linux/posix_acl_xattr.h> |
17 | #include <linux/gfs2_ondisk.h> | 17 | #include <linux/gfs2_ondisk.h> |
18 | #include <linux/lm_interface.h> | ||
19 | 18 | ||
20 | #include "gfs2.h" | 19 | #include "gfs2.h" |
21 | #include "incore.h" | 20 | #include "incore.h" |
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 11ffc56f1f81..3a5d3f883e10 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
15 | #include <linux/crc32.h> | 15 | #include <linux/crc32.h> |
16 | #include <linux/lm_interface.h> | ||
17 | 16 | ||
18 | #include "gfs2.h" | 17 | #include "gfs2.h" |
19 | #include "incore.h" | 18 | #include "incore.h" |
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index b7c8e5c70791..aef4d0c06748 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c | |||
@@ -60,7 +60,6 @@ | |||
60 | #include <linux/gfs2_ondisk.h> | 60 | #include <linux/gfs2_ondisk.h> |
61 | #include <linux/crc32.h> | 61 | #include <linux/crc32.h> |
62 | #include <linux/vmalloc.h> | 62 | #include <linux/vmalloc.h> |
63 | #include <linux/lm_interface.h> | ||
64 | 63 | ||
65 | #include "gfs2.h" | 64 | #include "gfs2.h" |
66 | #include "incore.h" | 65 | #include "incore.h" |
diff --git a/fs/gfs2/eaops.c b/fs/gfs2/eaops.c index f114ba2b3557..dee9b03e5b37 100644 --- a/fs/gfs2/eaops.c +++ b/fs/gfs2/eaops.c | |||
@@ -14,7 +14,6 @@ | |||
14 | #include <linux/capability.h> | 14 | #include <linux/capability.h> |
15 | #include <linux/xattr.h> | 15 | #include <linux/xattr.h> |
16 | #include <linux/gfs2_ondisk.h> | 16 | #include <linux/gfs2_ondisk.h> |
17 | #include <linux/lm_interface.h> | ||
18 | #include <asm/uaccess.h> | 17 | #include <asm/uaccess.h> |
19 | 18 | ||
20 | #include "gfs2.h" | 19 | #include "gfs2.h" |
diff --git a/fs/gfs2/eattr.c b/fs/gfs2/eattr.c index 0d1c76d906ae..899763aed217 100644 --- a/fs/gfs2/eattr.c +++ b/fs/gfs2/eattr.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/xattr.h> | 14 | #include <linux/xattr.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/lm_interface.h> | ||
17 | #include <asm/uaccess.h> | 16 | #include <asm/uaccess.h> |
18 | 17 | ||
19 | #include "gfs2.h" | 18 | #include "gfs2.h" |
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 6b983aef785d..3984e47d1d33 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
@@ -10,7 +10,6 @@ | |||
10 | #include <linux/sched.h> | 10 | #include <linux/sched.h> |
11 | #include <linux/slab.h> | 11 | #include <linux/slab.h> |
12 | #include <linux/spinlock.h> | 12 | #include <linux/spinlock.h> |
13 | #include <linux/completion.h> | ||
14 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
15 | #include <linux/delay.h> | 14 | #include <linux/delay.h> |
16 | #include <linux/sort.h> | 15 | #include <linux/sort.h> |
@@ -18,7 +17,6 @@ | |||
18 | #include <linux/kallsyms.h> | 17 | #include <linux/kallsyms.h> |
19 | #include <linux/gfs2_ondisk.h> | 18 | #include <linux/gfs2_ondisk.h> |
20 | #include <linux/list.h> | 19 | #include <linux/list.h> |
21 | #include <linux/lm_interface.h> | ||
22 | #include <linux/wait.h> | 20 | #include <linux/wait.h> |
23 | #include <linux/module.h> | 21 | #include <linux/module.h> |
24 | #include <linux/rwsem.h> | 22 | #include <linux/rwsem.h> |
@@ -155,13 +153,10 @@ static void glock_free(struct gfs2_glock *gl) | |||
155 | struct gfs2_sbd *sdp = gl->gl_sbd; | 153 | struct gfs2_sbd *sdp = gl->gl_sbd; |
156 | struct inode *aspace = gl->gl_aspace; | 154 | struct inode *aspace = gl->gl_aspace; |
157 | 155 | ||
158 | if (sdp->sd_lockstruct.ls_ops->lm_put_lock) | ||
159 | sdp->sd_lockstruct.ls_ops->lm_put_lock(gl->gl_lock); | ||
160 | |||
161 | if (aspace) | 156 | if (aspace) |
162 | gfs2_aspace_put(aspace); | 157 | gfs2_aspace_put(aspace); |
163 | 158 | ||
164 | kmem_cache_free(gfs2_glock_cachep, gl); | 159 | sdp->sd_lockstruct.ls_ops->lm_put_lock(gfs2_glock_cachep, gl); |
165 | } | 160 | } |
166 | 161 | ||
167 | /** | 162 | /** |
@@ -172,6 +167,7 @@ static void glock_free(struct gfs2_glock *gl) | |||
172 | 167 | ||
173 | static void gfs2_glock_hold(struct gfs2_glock *gl) | 168 | static void gfs2_glock_hold(struct gfs2_glock *gl) |
174 | { | 169 | { |
170 | GLOCK_BUG_ON(gl, atomic_read(&gl->gl_ref) == 0); | ||
175 | atomic_inc(&gl->gl_ref); | 171 | atomic_inc(&gl->gl_ref); |
176 | } | 172 | } |
177 | 173 | ||
@@ -211,17 +207,15 @@ int gfs2_glock_put(struct gfs2_glock *gl) | |||
211 | atomic_dec(&lru_count); | 207 | atomic_dec(&lru_count); |
212 | } | 208 | } |
213 | spin_unlock(&lru_lock); | 209 | spin_unlock(&lru_lock); |
214 | GLOCK_BUG_ON(gl, gl->gl_state != LM_ST_UNLOCKED); | ||
215 | GLOCK_BUG_ON(gl, !list_empty(&gl->gl_lru)); | ||
216 | GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders)); | 210 | GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders)); |
217 | glock_free(gl); | 211 | glock_free(gl); |
218 | rv = 1; | 212 | rv = 1; |
219 | goto out; | 213 | goto out; |
220 | } | 214 | } |
221 | write_unlock(gl_lock_addr(gl->gl_hash)); | ||
222 | /* 1 for being hashed, 1 for having state != LM_ST_UNLOCKED */ | 215 | /* 1 for being hashed, 1 for having state != LM_ST_UNLOCKED */ |
223 | if (atomic_read(&gl->gl_ref) == 2) | 216 | if (atomic_read(&gl->gl_ref) == 2) |
224 | gfs2_glock_schedule_for_reclaim(gl); | 217 | gfs2_glock_schedule_for_reclaim(gl); |
218 | write_unlock(gl_lock_addr(gl->gl_hash)); | ||
225 | out: | 219 | out: |
226 | return rv; | 220 | return rv; |
227 | } | 221 | } |
@@ -256,27 +250,6 @@ static struct gfs2_glock *search_bucket(unsigned int hash, | |||
256 | } | 250 | } |
257 | 251 | ||
258 | /** | 252 | /** |
259 | * gfs2_glock_find() - Find glock by lock number | ||
260 | * @sdp: The GFS2 superblock | ||
261 | * @name: The lock name | ||
262 | * | ||
263 | * Returns: NULL, or the struct gfs2_glock with the requested number | ||
264 | */ | ||
265 | |||
266 | static struct gfs2_glock *gfs2_glock_find(const struct gfs2_sbd *sdp, | ||
267 | const struct lm_lockname *name) | ||
268 | { | ||
269 | unsigned int hash = gl_hash(sdp, name); | ||
270 | struct gfs2_glock *gl; | ||
271 | |||
272 | read_lock(gl_lock_addr(hash)); | ||
273 | gl = search_bucket(hash, sdp, name); | ||
274 | read_unlock(gl_lock_addr(hash)); | ||
275 | |||
276 | return gl; | ||
277 | } | ||
278 | |||
279 | /** | ||
280 | * may_grant - check if its ok to grant a new lock | 253 | * may_grant - check if its ok to grant a new lock |
281 | * @gl: The glock | 254 | * @gl: The glock |
282 | * @gh: The lock request which we wish to grant | 255 | * @gh: The lock request which we wish to grant |
@@ -523,7 +496,7 @@ out_locked: | |||
523 | } | 496 | } |
524 | 497 | ||
525 | static unsigned int gfs2_lm_lock(struct gfs2_sbd *sdp, void *lock, | 498 | static unsigned int gfs2_lm_lock(struct gfs2_sbd *sdp, void *lock, |
526 | unsigned int cur_state, unsigned int req_state, | 499 | unsigned int req_state, |
527 | unsigned int flags) | 500 | unsigned int flags) |
528 | { | 501 | { |
529 | int ret = LM_OUT_ERROR; | 502 | int ret = LM_OUT_ERROR; |
@@ -532,7 +505,7 @@ static unsigned int gfs2_lm_lock(struct gfs2_sbd *sdp, void *lock, | |||
532 | return req_state == LM_ST_UNLOCKED ? 0 : req_state; | 505 | return req_state == LM_ST_UNLOCKED ? 0 : req_state; |
533 | 506 | ||
534 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | 507 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) |
535 | ret = sdp->sd_lockstruct.ls_ops->lm_lock(lock, cur_state, | 508 | ret = sdp->sd_lockstruct.ls_ops->lm_lock(lock, |
536 | req_state, flags); | 509 | req_state, flags); |
537 | return ret; | 510 | return ret; |
538 | } | 511 | } |
@@ -575,7 +548,7 @@ __acquires(&gl->gl_spin) | |||
575 | gl->gl_state == LM_ST_DEFERRED) && | 548 | gl->gl_state == LM_ST_DEFERRED) && |
576 | !(lck_flags & (LM_FLAG_TRY | LM_FLAG_TRY_1CB))) | 549 | !(lck_flags & (LM_FLAG_TRY | LM_FLAG_TRY_1CB))) |
577 | lck_flags |= LM_FLAG_TRY_1CB; | 550 | lck_flags |= LM_FLAG_TRY_1CB; |
578 | ret = gfs2_lm_lock(sdp, gl->gl_lock, gl->gl_state, target, lck_flags); | 551 | ret = gfs2_lm_lock(sdp, gl, target, lck_flags); |
579 | 552 | ||
580 | if (!(ret & LM_OUT_ASYNC)) { | 553 | if (!(ret & LM_OUT_ASYNC)) { |
581 | finish_xmote(gl, ret); | 554 | finish_xmote(gl, ret); |
@@ -624,10 +597,11 @@ __acquires(&gl->gl_spin) | |||
624 | 597 | ||
625 | GLOCK_BUG_ON(gl, test_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags)); | 598 | GLOCK_BUG_ON(gl, test_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags)); |
626 | 599 | ||
600 | down_read(&gfs2_umount_flush_sem); | ||
627 | if (test_bit(GLF_DEMOTE, &gl->gl_flags) && | 601 | if (test_bit(GLF_DEMOTE, &gl->gl_flags) && |
628 | gl->gl_demote_state != gl->gl_state) { | 602 | gl->gl_demote_state != gl->gl_state) { |
629 | if (find_first_holder(gl)) | 603 | if (find_first_holder(gl)) |
630 | goto out; | 604 | goto out_unlock; |
631 | if (nonblock) | 605 | if (nonblock) |
632 | goto out_sched; | 606 | goto out_sched; |
633 | set_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags); | 607 | set_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags); |
@@ -638,23 +612,26 @@ __acquires(&gl->gl_spin) | |||
638 | gfs2_demote_wake(gl); | 612 | gfs2_demote_wake(gl); |
639 | ret = do_promote(gl); | 613 | ret = do_promote(gl); |
640 | if (ret == 0) | 614 | if (ret == 0) |
641 | goto out; | 615 | goto out_unlock; |
642 | if (ret == 2) | 616 | if (ret == 2) |
643 | return; | 617 | goto out_sem; |
644 | gh = find_first_waiter(gl); | 618 | gh = find_first_waiter(gl); |
645 | gl->gl_target = gh->gh_state; | 619 | gl->gl_target = gh->gh_state; |
646 | if (!(gh->gh_flags & (LM_FLAG_TRY | LM_FLAG_TRY_1CB))) | 620 | if (!(gh->gh_flags & (LM_FLAG_TRY | LM_FLAG_TRY_1CB))) |
647 | do_error(gl, 0); /* Fail queued try locks */ | 621 | do_error(gl, 0); /* Fail queued try locks */ |
648 | } | 622 | } |
649 | do_xmote(gl, gh, gl->gl_target); | 623 | do_xmote(gl, gh, gl->gl_target); |
624 | out_sem: | ||
625 | up_read(&gfs2_umount_flush_sem); | ||
650 | return; | 626 | return; |
651 | 627 | ||
652 | out_sched: | 628 | out_sched: |
653 | gfs2_glock_hold(gl); | 629 | gfs2_glock_hold(gl); |
654 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | 630 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) |
655 | gfs2_glock_put(gl); | 631 | gfs2_glock_put(gl); |
656 | out: | 632 | out_unlock: |
657 | clear_bit(GLF_LOCK, &gl->gl_flags); | 633 | clear_bit(GLF_LOCK, &gl->gl_flags); |
634 | goto out_sem; | ||
658 | } | 635 | } |
659 | 636 | ||
660 | static void glock_work_func(struct work_struct *work) | 637 | static void glock_work_func(struct work_struct *work) |
@@ -681,18 +658,6 @@ static void glock_work_func(struct work_struct *work) | |||
681 | gfs2_glock_put(gl); | 658 | gfs2_glock_put(gl); |
682 | } | 659 | } |
683 | 660 | ||
684 | static int gfs2_lm_get_lock(struct gfs2_sbd *sdp, struct lm_lockname *name, | ||
685 | void **lockp) | ||
686 | { | ||
687 | int error = -EIO; | ||
688 | if (!sdp->sd_lockstruct.ls_ops->lm_get_lock) | ||
689 | return 0; | ||
690 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
691 | error = sdp->sd_lockstruct.ls_ops->lm_get_lock( | ||
692 | sdp->sd_lockstruct.ls_lockspace, name, lockp); | ||
693 | return error; | ||
694 | } | ||
695 | |||
696 | /** | 661 | /** |
697 | * gfs2_glock_get() - Get a glock, or create one if one doesn't exist | 662 | * gfs2_glock_get() - Get a glock, or create one if one doesn't exist |
698 | * @sdp: The GFS2 superblock | 663 | * @sdp: The GFS2 superblock |
@@ -719,10 +684,11 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
719 | gl = search_bucket(hash, sdp, &name); | 684 | gl = search_bucket(hash, sdp, &name); |
720 | read_unlock(gl_lock_addr(hash)); | 685 | read_unlock(gl_lock_addr(hash)); |
721 | 686 | ||
722 | if (gl || !create) { | 687 | *glp = gl; |
723 | *glp = gl; | 688 | if (gl) |
724 | return 0; | 689 | return 0; |
725 | } | 690 | if (!create) |
691 | return -ENOENT; | ||
726 | 692 | ||
727 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); | 693 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); |
728 | if (!gl) | 694 | if (!gl) |
@@ -736,7 +702,9 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
736 | gl->gl_demote_state = LM_ST_EXCLUSIVE; | 702 | gl->gl_demote_state = LM_ST_EXCLUSIVE; |
737 | gl->gl_hash = hash; | 703 | gl->gl_hash = hash; |
738 | gl->gl_ops = glops; | 704 | gl->gl_ops = glops; |
739 | gl->gl_stamp = jiffies; | 705 | snprintf(gl->gl_strname, GDLM_STRNAME_BYTES, "%8x%16llx", name.ln_type, (unsigned long long)number); |
706 | memset(&gl->gl_lksb, 0, sizeof(struct dlm_lksb)); | ||
707 | gl->gl_lksb.sb_lvbptr = gl->gl_lvb; | ||
740 | gl->gl_tchange = jiffies; | 708 | gl->gl_tchange = jiffies; |
741 | gl->gl_object = NULL; | 709 | gl->gl_object = NULL; |
742 | gl->gl_sbd = sdp; | 710 | gl->gl_sbd = sdp; |
@@ -753,10 +721,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
753 | } | 721 | } |
754 | } | 722 | } |
755 | 723 | ||
756 | error = gfs2_lm_get_lock(sdp, &name, &gl->gl_lock); | ||
757 | if (error) | ||
758 | goto fail_aspace; | ||
759 | |||
760 | write_lock(gl_lock_addr(hash)); | 724 | write_lock(gl_lock_addr(hash)); |
761 | tmp = search_bucket(hash, sdp, &name); | 725 | tmp = search_bucket(hash, sdp, &name); |
762 | if (tmp) { | 726 | if (tmp) { |
@@ -772,9 +736,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
772 | 736 | ||
773 | return 0; | 737 | return 0; |
774 | 738 | ||
775 | fail_aspace: | ||
776 | if (gl->gl_aspace) | ||
777 | gfs2_aspace_put(gl->gl_aspace); | ||
778 | fail: | 739 | fail: |
779 | kmem_cache_free(gfs2_glock_cachep, gl); | 740 | kmem_cache_free(gfs2_glock_cachep, gl); |
780 | return error; | 741 | return error; |
@@ -966,7 +927,7 @@ do_cancel: | |||
966 | if (!(gh->gh_flags & LM_FLAG_PRIORITY)) { | 927 | if (!(gh->gh_flags & LM_FLAG_PRIORITY)) { |
967 | spin_unlock(&gl->gl_spin); | 928 | spin_unlock(&gl->gl_spin); |
968 | if (sdp->sd_lockstruct.ls_ops->lm_cancel) | 929 | if (sdp->sd_lockstruct.ls_ops->lm_cancel) |
969 | sdp->sd_lockstruct.ls_ops->lm_cancel(gl->gl_lock); | 930 | sdp->sd_lockstruct.ls_ops->lm_cancel(gl); |
970 | spin_lock(&gl->gl_spin); | 931 | spin_lock(&gl->gl_spin); |
971 | } | 932 | } |
972 | return; | 933 | return; |
@@ -1051,7 +1012,6 @@ void gfs2_glock_dq(struct gfs2_holder *gh) | |||
1051 | spin_lock(&gl->gl_spin); | 1012 | spin_lock(&gl->gl_spin); |
1052 | clear_bit(GLF_LOCK, &gl->gl_flags); | 1013 | clear_bit(GLF_LOCK, &gl->gl_flags); |
1053 | } | 1014 | } |
1054 | gl->gl_stamp = jiffies; | ||
1055 | if (list_empty(&gl->gl_holders) && | 1015 | if (list_empty(&gl->gl_holders) && |
1056 | !test_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && | 1016 | !test_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && |
1057 | !test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1017 | !test_bit(GLF_DEMOTE, &gl->gl_flags)) |
@@ -1240,70 +1200,13 @@ void gfs2_glock_dq_uninit_m(unsigned int num_gh, struct gfs2_holder *ghs) | |||
1240 | gfs2_glock_dq_uninit(&ghs[x]); | 1200 | gfs2_glock_dq_uninit(&ghs[x]); |
1241 | } | 1201 | } |
1242 | 1202 | ||
1243 | static int gfs2_lm_hold_lvb(struct gfs2_sbd *sdp, void *lock, char **lvbp) | 1203 | void gfs2_glock_cb(struct gfs2_glock *gl, unsigned int state) |
1244 | { | ||
1245 | int error = -EIO; | ||
1246 | if (!sdp->sd_lockstruct.ls_ops->lm_hold_lvb) | ||
1247 | return 0; | ||
1248 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
1249 | error = sdp->sd_lockstruct.ls_ops->lm_hold_lvb(lock, lvbp); | ||
1250 | return error; | ||
1251 | } | ||
1252 | |||
1253 | /** | ||
1254 | * gfs2_lvb_hold - attach a LVB from a glock | ||
1255 | * @gl: The glock in question | ||
1256 | * | ||
1257 | */ | ||
1258 | |||
1259 | int gfs2_lvb_hold(struct gfs2_glock *gl) | ||
1260 | { | ||
1261 | int error; | ||
1262 | |||
1263 | if (!atomic_read(&gl->gl_lvb_count)) { | ||
1264 | error = gfs2_lm_hold_lvb(gl->gl_sbd, gl->gl_lock, &gl->gl_lvb); | ||
1265 | if (error) | ||
1266 | return error; | ||
1267 | gfs2_glock_hold(gl); | ||
1268 | } | ||
1269 | atomic_inc(&gl->gl_lvb_count); | ||
1270 | |||
1271 | return 0; | ||
1272 | } | ||
1273 | |||
1274 | /** | ||
1275 | * gfs2_lvb_unhold - detach a LVB from a glock | ||
1276 | * @gl: The glock in question | ||
1277 | * | ||
1278 | */ | ||
1279 | |||
1280 | void gfs2_lvb_unhold(struct gfs2_glock *gl) | ||
1281 | { | ||
1282 | struct gfs2_sbd *sdp = gl->gl_sbd; | ||
1283 | |||
1284 | gfs2_glock_hold(gl); | ||
1285 | gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_lvb_count) > 0); | ||
1286 | if (atomic_dec_and_test(&gl->gl_lvb_count)) { | ||
1287 | if (sdp->sd_lockstruct.ls_ops->lm_unhold_lvb) | ||
1288 | sdp->sd_lockstruct.ls_ops->lm_unhold_lvb(gl->gl_lock, gl->gl_lvb); | ||
1289 | gl->gl_lvb = NULL; | ||
1290 | gfs2_glock_put(gl); | ||
1291 | } | ||
1292 | gfs2_glock_put(gl); | ||
1293 | } | ||
1294 | |||
1295 | static void blocking_cb(struct gfs2_sbd *sdp, struct lm_lockname *name, | ||
1296 | unsigned int state) | ||
1297 | { | 1204 | { |
1298 | struct gfs2_glock *gl; | ||
1299 | unsigned long delay = 0; | 1205 | unsigned long delay = 0; |
1300 | unsigned long holdtime; | 1206 | unsigned long holdtime; |
1301 | unsigned long now = jiffies; | 1207 | unsigned long now = jiffies; |
1302 | 1208 | ||
1303 | gl = gfs2_glock_find(sdp, name); | 1209 | gfs2_glock_hold(gl); |
1304 | if (!gl) | ||
1305 | return; | ||
1306 | |||
1307 | holdtime = gl->gl_tchange + gl->gl_ops->go_min_hold_time; | 1210 | holdtime = gl->gl_tchange + gl->gl_ops->go_min_hold_time; |
1308 | if (time_before(now, holdtime)) | 1211 | if (time_before(now, holdtime)) |
1309 | delay = holdtime - now; | 1212 | delay = holdtime - now; |
@@ -1317,74 +1220,33 @@ static void blocking_cb(struct gfs2_sbd *sdp, struct lm_lockname *name, | |||
1317 | gfs2_glock_put(gl); | 1220 | gfs2_glock_put(gl); |
1318 | } | 1221 | } |
1319 | 1222 | ||
1320 | static void gfs2_jdesc_make_dirty(struct gfs2_sbd *sdp, unsigned int jid) | ||
1321 | { | ||
1322 | struct gfs2_jdesc *jd; | ||
1323 | |||
1324 | spin_lock(&sdp->sd_jindex_spin); | ||
1325 | list_for_each_entry(jd, &sdp->sd_jindex_list, jd_list) { | ||
1326 | if (jd->jd_jid != jid) | ||
1327 | continue; | ||
1328 | jd->jd_dirty = 1; | ||
1329 | break; | ||
1330 | } | ||
1331 | spin_unlock(&sdp->sd_jindex_spin); | ||
1332 | } | ||
1333 | |||
1334 | /** | 1223 | /** |
1335 | * gfs2_glock_cb - Callback used by locking module | 1224 | * gfs2_glock_complete - Callback used by locking |
1336 | * @sdp: Pointer to the superblock | 1225 | * @gl: Pointer to the glock |
1337 | * @type: Type of callback | 1226 | * @ret: The return value from the dlm |
1338 | * @data: Type dependent data pointer | ||
1339 | * | 1227 | * |
1340 | * Called by the locking module when it wants to tell us something. | ||
1341 | * Either we need to drop a lock, one of our ASYNC requests completed, or | ||
1342 | * a journal from another client needs to be recovered. | ||
1343 | */ | 1228 | */ |
1344 | 1229 | ||
1345 | void gfs2_glock_cb(void *cb_data, unsigned int type, void *data) | 1230 | void gfs2_glock_complete(struct gfs2_glock *gl, int ret) |
1346 | { | 1231 | { |
1347 | struct gfs2_sbd *sdp = cb_data; | 1232 | struct lm_lockstruct *ls = &gl->gl_sbd->sd_lockstruct; |
1348 | 1233 | gl->gl_reply = ret; | |
1349 | switch (type) { | 1234 | if (unlikely(test_bit(DFL_BLOCK_LOCKS, &ls->ls_flags))) { |
1350 | case LM_CB_NEED_E: | 1235 | struct gfs2_holder *gh; |
1351 | blocking_cb(sdp, data, LM_ST_UNLOCKED); | 1236 | spin_lock(&gl->gl_spin); |
1352 | return; | 1237 | gh = find_first_waiter(gl); |
1353 | 1238 | if ((!(gh && (gh->gh_flags & LM_FLAG_NOEXP)) && | |
1354 | case LM_CB_NEED_D: | 1239 | (gl->gl_target != LM_ST_UNLOCKED)) || |
1355 | blocking_cb(sdp, data, LM_ST_DEFERRED); | 1240 | ((ret & ~LM_OUT_ST_MASK) != 0)) |
1356 | return; | 1241 | set_bit(GLF_FROZEN, &gl->gl_flags); |
1357 | 1242 | spin_unlock(&gl->gl_spin); | |
1358 | case LM_CB_NEED_S: | 1243 | if (test_bit(GLF_FROZEN, &gl->gl_flags)) |
1359 | blocking_cb(sdp, data, LM_ST_SHARED); | ||
1360 | return; | ||
1361 | |||
1362 | case LM_CB_ASYNC: { | ||
1363 | struct lm_async_cb *async = data; | ||
1364 | struct gfs2_glock *gl; | ||
1365 | |||
1366 | down_read(&gfs2_umount_flush_sem); | ||
1367 | gl = gfs2_glock_find(sdp, &async->lc_name); | ||
1368 | if (gfs2_assert_warn(sdp, gl)) | ||
1369 | return; | 1244 | return; |
1370 | gl->gl_reply = async->lc_ret; | ||
1371 | set_bit(GLF_REPLY_PENDING, &gl->gl_flags); | ||
1372 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | ||
1373 | gfs2_glock_put(gl); | ||
1374 | up_read(&gfs2_umount_flush_sem); | ||
1375 | return; | ||
1376 | } | ||
1377 | |||
1378 | case LM_CB_NEED_RECOVERY: | ||
1379 | gfs2_jdesc_make_dirty(sdp, *(unsigned int *)data); | ||
1380 | if (sdp->sd_recoverd_process) | ||
1381 | wake_up_process(sdp->sd_recoverd_process); | ||
1382 | return; | ||
1383 | |||
1384 | default: | ||
1385 | gfs2_assert_warn(sdp, 0); | ||
1386 | return; | ||
1387 | } | 1245 | } |
1246 | set_bit(GLF_REPLY_PENDING, &gl->gl_flags); | ||
1247 | gfs2_glock_hold(gl); | ||
1248 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | ||
1249 | gfs2_glock_put(gl); | ||
1388 | } | 1250 | } |
1389 | 1251 | ||
1390 | /** | 1252 | /** |
@@ -1515,6 +1377,25 @@ out: | |||
1515 | return has_entries; | 1377 | return has_entries; |
1516 | } | 1378 | } |
1517 | 1379 | ||
1380 | |||
1381 | /** | ||
1382 | * thaw_glock - thaw out a glock which has an unprocessed reply waiting | ||
1383 | * @gl: The glock to thaw | ||
1384 | * | ||
1385 | * N.B. When we freeze a glock, we leave a ref to the glock outstanding, | ||
1386 | * so this has to result in the ref count being dropped by one. | ||
1387 | */ | ||
1388 | |||
1389 | static void thaw_glock(struct gfs2_glock *gl) | ||
1390 | { | ||
1391 | if (!test_and_clear_bit(GLF_FROZEN, &gl->gl_flags)) | ||
1392 | return; | ||
1393 | set_bit(GLF_REPLY_PENDING, &gl->gl_flags); | ||
1394 | gfs2_glock_hold(gl); | ||
1395 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | ||
1396 | gfs2_glock_put(gl); | ||
1397 | } | ||
1398 | |||
1518 | /** | 1399 | /** |
1519 | * clear_glock - look at a glock and see if we can free it from glock cache | 1400 | * clear_glock - look at a glock and see if we can free it from glock cache |
1520 | * @gl: the glock to look at | 1401 | * @gl: the glock to look at |
@@ -1540,6 +1421,20 @@ static void clear_glock(struct gfs2_glock *gl) | |||
1540 | } | 1421 | } |
1541 | 1422 | ||
1542 | /** | 1423 | /** |
1424 | * gfs2_glock_thaw - Thaw any frozen glocks | ||
1425 | * @sdp: The super block | ||
1426 | * | ||
1427 | */ | ||
1428 | |||
1429 | void gfs2_glock_thaw(struct gfs2_sbd *sdp) | ||
1430 | { | ||
1431 | unsigned x; | ||
1432 | |||
1433 | for (x = 0; x < GFS2_GL_HASH_SIZE; x++) | ||
1434 | examine_bucket(thaw_glock, sdp, x); | ||
1435 | } | ||
1436 | |||
1437 | /** | ||
1543 | * gfs2_gl_hash_clear - Empty out the glock hash table | 1438 | * gfs2_gl_hash_clear - Empty out the glock hash table |
1544 | * @sdp: the filesystem | 1439 | * @sdp: the filesystem |
1545 | * @wait: wait until it's all gone | 1440 | * @wait: wait until it's all gone |
@@ -1619,7 +1514,7 @@ static const char *hflags2str(char *buf, unsigned flags, unsigned long iflags) | |||
1619 | if (flags & LM_FLAG_NOEXP) | 1514 | if (flags & LM_FLAG_NOEXP) |
1620 | *p++ = 'e'; | 1515 | *p++ = 'e'; |
1621 | if (flags & LM_FLAG_ANY) | 1516 | if (flags & LM_FLAG_ANY) |
1622 | *p++ = 'a'; | 1517 | *p++ = 'A'; |
1623 | if (flags & LM_FLAG_PRIORITY) | 1518 | if (flags & LM_FLAG_PRIORITY) |
1624 | *p++ = 'p'; | 1519 | *p++ = 'p'; |
1625 | if (flags & GL_ASYNC) | 1520 | if (flags & GL_ASYNC) |
@@ -1683,6 +1578,10 @@ static const char *gflags2str(char *buf, const unsigned long *gflags) | |||
1683 | *p++ = 'i'; | 1578 | *p++ = 'i'; |
1684 | if (test_bit(GLF_REPLY_PENDING, gflags)) | 1579 | if (test_bit(GLF_REPLY_PENDING, gflags)) |
1685 | *p++ = 'r'; | 1580 | *p++ = 'r'; |
1581 | if (test_bit(GLF_INITIAL, gflags)) | ||
1582 | *p++ = 'I'; | ||
1583 | if (test_bit(GLF_FROZEN, gflags)) | ||
1584 | *p++ = 'F'; | ||
1686 | *p = 0; | 1585 | *p = 0; |
1687 | return buf; | 1586 | return buf; |
1688 | } | 1587 | } |
@@ -1717,14 +1616,13 @@ static int __dump_glock(struct seq_file *seq, const struct gfs2_glock *gl) | |||
1717 | dtime *= 1000000/HZ; /* demote time in uSec */ | 1616 | dtime *= 1000000/HZ; /* demote time in uSec */ |
1718 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1617 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) |
1719 | dtime = 0; | 1618 | dtime = 0; |
1720 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llu f:%s t:%s d:%s/%llu l:%d a:%d r:%d\n", | 1619 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llu f:%s t:%s d:%s/%llu a:%d r:%d\n", |
1721 | state2str(gl->gl_state), | 1620 | state2str(gl->gl_state), |
1722 | gl->gl_name.ln_type, | 1621 | gl->gl_name.ln_type, |
1723 | (unsigned long long)gl->gl_name.ln_number, | 1622 | (unsigned long long)gl->gl_name.ln_number, |
1724 | gflags2str(gflags_buf, &gl->gl_flags), | 1623 | gflags2str(gflags_buf, &gl->gl_flags), |
1725 | state2str(gl->gl_target), | 1624 | state2str(gl->gl_target), |
1726 | state2str(gl->gl_demote_state), dtime, | 1625 | state2str(gl->gl_demote_state), dtime, |
1727 | atomic_read(&gl->gl_lvb_count), | ||
1728 | atomic_read(&gl->gl_ail_count), | 1626 | atomic_read(&gl->gl_ail_count), |
1729 | atomic_read(&gl->gl_ref)); | 1627 | atomic_read(&gl->gl_ref)); |
1730 | 1628 | ||
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h index 543ec7ecfbda..a602a28f6f08 100644 --- a/fs/gfs2/glock.h +++ b/fs/gfs2/glock.h | |||
@@ -11,15 +11,130 @@ | |||
11 | #define __GLOCK_DOT_H__ | 11 | #define __GLOCK_DOT_H__ |
12 | 12 | ||
13 | #include <linux/sched.h> | 13 | #include <linux/sched.h> |
14 | #include <linux/parser.h> | ||
14 | #include "incore.h" | 15 | #include "incore.h" |
15 | 16 | ||
16 | /* Flags for lock requests; used in gfs2_holder gh_flag field. | 17 | /* Options for hostdata parser */ |
17 | From lm_interface.h: | 18 | |
19 | enum { | ||
20 | Opt_jid, | ||
21 | Opt_id, | ||
22 | Opt_first, | ||
23 | Opt_nodir, | ||
24 | Opt_err, | ||
25 | }; | ||
26 | |||
27 | /* | ||
28 | * lm_lockname types | ||
29 | */ | ||
30 | |||
31 | #define LM_TYPE_RESERVED 0x00 | ||
32 | #define LM_TYPE_NONDISK 0x01 | ||
33 | #define LM_TYPE_INODE 0x02 | ||
34 | #define LM_TYPE_RGRP 0x03 | ||
35 | #define LM_TYPE_META 0x04 | ||
36 | #define LM_TYPE_IOPEN 0x05 | ||
37 | #define LM_TYPE_FLOCK 0x06 | ||
38 | #define LM_TYPE_PLOCK 0x07 | ||
39 | #define LM_TYPE_QUOTA 0x08 | ||
40 | #define LM_TYPE_JOURNAL 0x09 | ||
41 | |||
42 | /* | ||
43 | * lm_lock() states | ||
44 | * | ||
45 | * SHARED is compatible with SHARED, not with DEFERRED or EX. | ||
46 | * DEFERRED is compatible with DEFERRED, not with SHARED or EX. | ||
47 | */ | ||
48 | |||
49 | #define LM_ST_UNLOCKED 0 | ||
50 | #define LM_ST_EXCLUSIVE 1 | ||
51 | #define LM_ST_DEFERRED 2 | ||
52 | #define LM_ST_SHARED 3 | ||
53 | |||
54 | /* | ||
55 | * lm_lock() flags | ||
56 | * | ||
57 | * LM_FLAG_TRY | ||
58 | * Don't wait to acquire the lock if it can't be granted immediately. | ||
59 | * | ||
60 | * LM_FLAG_TRY_1CB | ||
61 | * Send one blocking callback if TRY is set and the lock is not granted. | ||
62 | * | ||
63 | * LM_FLAG_NOEXP | ||
64 | * GFS sets this flag on lock requests it makes while doing journal recovery. | ||
65 | * These special requests should not be blocked due to the recovery like | ||
66 | * ordinary locks would be. | ||
67 | * | ||
68 | * LM_FLAG_ANY | ||
69 | * A SHARED request may also be granted in DEFERRED, or a DEFERRED request may | ||
70 | * also be granted in SHARED. The preferred state is whichever is compatible | ||
71 | * with other granted locks, or the specified state if no other locks exist. | ||
72 | * | ||
73 | * LM_FLAG_PRIORITY | ||
74 | * Override fairness considerations. Suppose a lock is held in a shared state | ||
75 | * and there is a pending request for the deferred state. A shared lock | ||
76 | * request with the priority flag would be allowed to bypass the deferred | ||
77 | * request and directly join the other shared lock. A shared lock request | ||
78 | * without the priority flag might be forced to wait until the deferred | ||
79 | * requested had acquired and released the lock. | ||
80 | */ | ||
81 | |||
18 | #define LM_FLAG_TRY 0x00000001 | 82 | #define LM_FLAG_TRY 0x00000001 |
19 | #define LM_FLAG_TRY_1CB 0x00000002 | 83 | #define LM_FLAG_TRY_1CB 0x00000002 |
20 | #define LM_FLAG_NOEXP 0x00000004 | 84 | #define LM_FLAG_NOEXP 0x00000004 |
21 | #define LM_FLAG_ANY 0x00000008 | 85 | #define LM_FLAG_ANY 0x00000008 |
22 | #define LM_FLAG_PRIORITY 0x00000010 */ | 86 | #define LM_FLAG_PRIORITY 0x00000010 |
87 | #define GL_ASYNC 0x00000040 | ||
88 | #define GL_EXACT 0x00000080 | ||
89 | #define GL_SKIP 0x00000100 | ||
90 | #define GL_ATIME 0x00000200 | ||
91 | #define GL_NOCACHE 0x00000400 | ||
92 | |||
93 | /* | ||
94 | * lm_lock() and lm_async_cb return flags | ||
95 | * | ||
96 | * LM_OUT_ST_MASK | ||
97 | * Masks the lower two bits of lock state in the returned value. | ||
98 | * | ||
99 | * LM_OUT_CANCELED | ||
100 | * The lock request was canceled. | ||
101 | * | ||
102 | * LM_OUT_ASYNC | ||
103 | * The result of the request will be returned in an LM_CB_ASYNC callback. | ||
104 | * | ||
105 | */ | ||
106 | |||
107 | #define LM_OUT_ST_MASK 0x00000003 | ||
108 | #define LM_OUT_CANCELED 0x00000008 | ||
109 | #define LM_OUT_ASYNC 0x00000080 | ||
110 | #define LM_OUT_ERROR 0x00000100 | ||
111 | |||
112 | /* | ||
113 | * lm_recovery_done() messages | ||
114 | */ | ||
115 | |||
116 | #define LM_RD_GAVEUP 308 | ||
117 | #define LM_RD_SUCCESS 309 | ||
118 | |||
119 | #define GLR_TRYFAILED 13 | ||
120 | |||
121 | struct lm_lockops { | ||
122 | const char *lm_proto_name; | ||
123 | int (*lm_mount) (struct gfs2_sbd *sdp, const char *fsname); | ||
124 | void (*lm_unmount) (struct gfs2_sbd *sdp); | ||
125 | void (*lm_withdraw) (struct gfs2_sbd *sdp); | ||
126 | void (*lm_put_lock) (struct kmem_cache *cachep, void *gl); | ||
127 | unsigned int (*lm_lock) (struct gfs2_glock *gl, | ||
128 | unsigned int req_state, unsigned int flags); | ||
129 | void (*lm_cancel) (struct gfs2_glock *gl); | ||
130 | const match_table_t *lm_tokens; | ||
131 | }; | ||
132 | |||
133 | #define LM_FLAG_TRY 0x00000001 | ||
134 | #define LM_FLAG_TRY_1CB 0x00000002 | ||
135 | #define LM_FLAG_NOEXP 0x00000004 | ||
136 | #define LM_FLAG_ANY 0x00000008 | ||
137 | #define LM_FLAG_PRIORITY 0x00000010 | ||
23 | 138 | ||
24 | #define GL_ASYNC 0x00000040 | 139 | #define GL_ASYNC 0x00000040 |
25 | #define GL_EXACT 0x00000080 | 140 | #define GL_EXACT 0x00000080 |
@@ -128,10 +243,12 @@ static inline int gfs2_glock_nq_init(struct gfs2_glock *gl, | |||
128 | int gfs2_lvb_hold(struct gfs2_glock *gl); | 243 | int gfs2_lvb_hold(struct gfs2_glock *gl); |
129 | void gfs2_lvb_unhold(struct gfs2_glock *gl); | 244 | void gfs2_lvb_unhold(struct gfs2_glock *gl); |
130 | 245 | ||
131 | void gfs2_glock_cb(void *cb_data, unsigned int type, void *data); | 246 | void gfs2_glock_cb(struct gfs2_glock *gl, unsigned int state); |
247 | void gfs2_glock_complete(struct gfs2_glock *gl, int ret); | ||
132 | void gfs2_reclaim_glock(struct gfs2_sbd *sdp); | 248 | void gfs2_reclaim_glock(struct gfs2_sbd *sdp); |
133 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp); | 249 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp); |
134 | void gfs2_glock_finish_truncate(struct gfs2_inode *ip); | 250 | void gfs2_glock_finish_truncate(struct gfs2_inode *ip); |
251 | void gfs2_glock_thaw(struct gfs2_sbd *sdp); | ||
135 | 252 | ||
136 | int __init gfs2_glock_init(void); | 253 | int __init gfs2_glock_init(void); |
137 | void gfs2_glock_exit(void); | 254 | void gfs2_glock_exit(void); |
@@ -141,4 +258,6 @@ void gfs2_delete_debugfs_file(struct gfs2_sbd *sdp); | |||
141 | int gfs2_register_debugfs(void); | 258 | int gfs2_register_debugfs(void); |
142 | void gfs2_unregister_debugfs(void); | 259 | void gfs2_unregister_debugfs(void); |
143 | 260 | ||
261 | extern const struct lm_lockops gfs2_dlm_ops; | ||
262 | |||
144 | #endif /* __GLOCK_DOT_H__ */ | 263 | #endif /* __GLOCK_DOT_H__ */ |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 8522d3aa64fc..bf23a62aa925 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
@@ -12,7 +12,6 @@ | |||
12 | #include <linux/completion.h> | 12 | #include <linux/completion.h> |
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
15 | #include <linux/lm_interface.h> | ||
16 | #include <linux/bio.h> | 15 | #include <linux/bio.h> |
17 | 16 | ||
18 | #include "gfs2.h" | 17 | #include "gfs2.h" |
@@ -38,20 +37,25 @@ | |||
38 | static void gfs2_ail_empty_gl(struct gfs2_glock *gl) | 37 | static void gfs2_ail_empty_gl(struct gfs2_glock *gl) |
39 | { | 38 | { |
40 | struct gfs2_sbd *sdp = gl->gl_sbd; | 39 | struct gfs2_sbd *sdp = gl->gl_sbd; |
41 | unsigned int blocks; | ||
42 | struct list_head *head = &gl->gl_ail_list; | 40 | struct list_head *head = &gl->gl_ail_list; |
43 | struct gfs2_bufdata *bd; | 41 | struct gfs2_bufdata *bd; |
44 | struct buffer_head *bh; | 42 | struct buffer_head *bh; |
45 | int error; | 43 | struct gfs2_trans tr; |
46 | 44 | ||
47 | blocks = atomic_read(&gl->gl_ail_count); | 45 | memset(&tr, 0, sizeof(tr)); |
48 | if (!blocks) | 46 | tr.tr_revokes = atomic_read(&gl->gl_ail_count); |
49 | return; | ||
50 | 47 | ||
51 | error = gfs2_trans_begin(sdp, 0, blocks); | 48 | if (!tr.tr_revokes) |
52 | if (gfs2_assert_withdraw(sdp, !error)) | ||
53 | return; | 49 | return; |
54 | 50 | ||
51 | /* A shortened, inline version of gfs2_trans_begin() */ | ||
52 | tr.tr_reserved = 1 + gfs2_struct2blk(sdp, tr.tr_revokes, sizeof(u64)); | ||
53 | tr.tr_ip = (unsigned long)__builtin_return_address(0); | ||
54 | INIT_LIST_HEAD(&tr.tr_list_buf); | ||
55 | gfs2_log_reserve(sdp, tr.tr_reserved); | ||
56 | BUG_ON(current->journal_info); | ||
57 | current->journal_info = &tr; | ||
58 | |||
55 | gfs2_log_lock(sdp); | 59 | gfs2_log_lock(sdp); |
56 | while (!list_empty(head)) { | 60 | while (!list_empty(head)) { |
57 | bd = list_entry(head->next, struct gfs2_bufdata, | 61 | bd = list_entry(head->next, struct gfs2_bufdata, |
@@ -72,29 +76,7 @@ static void gfs2_ail_empty_gl(struct gfs2_glock *gl) | |||
72 | } | 76 | } |
73 | 77 | ||
74 | /** | 78 | /** |
75 | * gfs2_pte_inval - Sync and invalidate all PTEs associated with a glock | 79 | * rgrp_go_sync - sync out the metadata for this glock |
76 | * @gl: the glock | ||
77 | * | ||
78 | */ | ||
79 | |||
80 | static void gfs2_pte_inval(struct gfs2_glock *gl) | ||
81 | { | ||
82 | struct gfs2_inode *ip; | ||
83 | struct inode *inode; | ||
84 | |||
85 | ip = gl->gl_object; | ||
86 | inode = &ip->i_inode; | ||
87 | if (!ip || !S_ISREG(inode->i_mode)) | ||
88 | return; | ||
89 | |||
90 | unmap_shared_mapping_range(inode->i_mapping, 0, 0); | ||
91 | if (test_bit(GIF_SW_PAGED, &ip->i_flags)) | ||
92 | set_bit(GLF_DIRTY, &gl->gl_flags); | ||
93 | |||
94 | } | ||
95 | |||
96 | /** | ||
97 | * meta_go_sync - sync out the metadata for this glock | ||
98 | * @gl: the glock | 80 | * @gl: the glock |
99 | * | 81 | * |
100 | * Called when demoting or unlocking an EX glock. We must flush | 82 | * Called when demoting or unlocking an EX glock. We must flush |
@@ -102,36 +84,42 @@ static void gfs2_pte_inval(struct gfs2_glock *gl) | |||
102 | * not return to caller to demote/unlock the glock until I/O is complete. | 84 | * not return to caller to demote/unlock the glock until I/O is complete. |
103 | */ | 85 | */ |
104 | 86 | ||
105 | static void meta_go_sync(struct gfs2_glock *gl) | 87 | static void rgrp_go_sync(struct gfs2_glock *gl) |
106 | { | 88 | { |
107 | if (gl->gl_state != LM_ST_EXCLUSIVE) | 89 | struct address_space *metamapping = gl->gl_aspace->i_mapping; |
90 | int error; | ||
91 | |||
92 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) | ||
108 | return; | 93 | return; |
94 | BUG_ON(gl->gl_state != LM_ST_EXCLUSIVE); | ||
109 | 95 | ||
110 | if (test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) { | 96 | gfs2_log_flush(gl->gl_sbd, gl); |
111 | gfs2_log_flush(gl->gl_sbd, gl); | 97 | filemap_fdatawrite(metamapping); |
112 | gfs2_meta_sync(gl); | 98 | error = filemap_fdatawait(metamapping); |
113 | gfs2_ail_empty_gl(gl); | 99 | mapping_set_error(metamapping, error); |
114 | } | 100 | gfs2_ail_empty_gl(gl); |
115 | } | 101 | } |
116 | 102 | ||
117 | /** | 103 | /** |
118 | * meta_go_inval - invalidate the metadata for this glock | 104 | * rgrp_go_inval - invalidate the metadata for this glock |
119 | * @gl: the glock | 105 | * @gl: the glock |
120 | * @flags: | 106 | * @flags: |
121 | * | 107 | * |
108 | * We never used LM_ST_DEFERRED with resource groups, so that we | ||
109 | * should always see the metadata flag set here. | ||
110 | * | ||
122 | */ | 111 | */ |
123 | 112 | ||
124 | static void meta_go_inval(struct gfs2_glock *gl, int flags) | 113 | static void rgrp_go_inval(struct gfs2_glock *gl, int flags) |
125 | { | 114 | { |
126 | if (!(flags & DIO_METADATA)) | 115 | struct address_space *mapping = gl->gl_aspace->i_mapping; |
127 | return; | ||
128 | 116 | ||
129 | gfs2_meta_inval(gl); | 117 | BUG_ON(!(flags & DIO_METADATA)); |
130 | if (gl->gl_object == GFS2_I(gl->gl_sbd->sd_rindex)) | 118 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
131 | gl->gl_sbd->sd_rindex_uptodate = 0; | 119 | truncate_inode_pages(mapping, 0); |
132 | else if (gl->gl_ops == &gfs2_rgrp_glops && gl->gl_object) { | ||
133 | struct gfs2_rgrpd *rgd = (struct gfs2_rgrpd *)gl->gl_object; | ||
134 | 120 | ||
121 | if (gl->gl_object) { | ||
122 | struct gfs2_rgrpd *rgd = (struct gfs2_rgrpd *)gl->gl_object; | ||
135 | rgd->rd_flags &= ~GFS2_RDF_UPTODATE; | 123 | rgd->rd_flags &= ~GFS2_RDF_UPTODATE; |
136 | } | 124 | } |
137 | } | 125 | } |
@@ -148,48 +136,54 @@ static void inode_go_sync(struct gfs2_glock *gl) | |||
148 | struct address_space *metamapping = gl->gl_aspace->i_mapping; | 136 | struct address_space *metamapping = gl->gl_aspace->i_mapping; |
149 | int error; | 137 | int error; |
150 | 138 | ||
151 | if (gl->gl_state != LM_ST_UNLOCKED) | ||
152 | gfs2_pte_inval(gl); | ||
153 | if (gl->gl_state != LM_ST_EXCLUSIVE) | ||
154 | return; | ||
155 | |||
156 | if (ip && !S_ISREG(ip->i_inode.i_mode)) | 139 | if (ip && !S_ISREG(ip->i_inode.i_mode)) |
157 | ip = NULL; | 140 | ip = NULL; |
141 | if (ip && test_and_clear_bit(GIF_SW_PAGED, &ip->i_flags)) | ||
142 | unmap_shared_mapping_range(ip->i_inode.i_mapping, 0, 0); | ||
143 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) | ||
144 | return; | ||
158 | 145 | ||
159 | if (test_bit(GLF_DIRTY, &gl->gl_flags)) { | 146 | BUG_ON(gl->gl_state != LM_ST_EXCLUSIVE); |
160 | gfs2_log_flush(gl->gl_sbd, gl); | 147 | |
161 | filemap_fdatawrite(metamapping); | 148 | gfs2_log_flush(gl->gl_sbd, gl); |
162 | if (ip) { | 149 | filemap_fdatawrite(metamapping); |
163 | struct address_space *mapping = ip->i_inode.i_mapping; | 150 | if (ip) { |
164 | filemap_fdatawrite(mapping); | 151 | struct address_space *mapping = ip->i_inode.i_mapping; |
165 | error = filemap_fdatawait(mapping); | 152 | filemap_fdatawrite(mapping); |
166 | mapping_set_error(mapping, error); | 153 | error = filemap_fdatawait(mapping); |
167 | } | 154 | mapping_set_error(mapping, error); |
168 | error = filemap_fdatawait(metamapping); | ||
169 | mapping_set_error(metamapping, error); | ||
170 | clear_bit(GLF_DIRTY, &gl->gl_flags); | ||
171 | gfs2_ail_empty_gl(gl); | ||
172 | } | 155 | } |
156 | error = filemap_fdatawait(metamapping); | ||
157 | mapping_set_error(metamapping, error); | ||
158 | gfs2_ail_empty_gl(gl); | ||
173 | } | 159 | } |
174 | 160 | ||
175 | /** | 161 | /** |
176 | * inode_go_inval - prepare a inode glock to be released | 162 | * inode_go_inval - prepare a inode glock to be released |
177 | * @gl: the glock | 163 | * @gl: the glock |
178 | * @flags: | 164 | * @flags: |
165 | * | ||
166 | * Normally we invlidate everything, but if we are moving into | ||
167 | * LM_ST_DEFERRED from LM_ST_SHARED or LM_ST_EXCLUSIVE then we | ||
168 | * can keep hold of the metadata, since it won't have changed. | ||
179 | * | 169 | * |
180 | */ | 170 | */ |
181 | 171 | ||
182 | static void inode_go_inval(struct gfs2_glock *gl, int flags) | 172 | static void inode_go_inval(struct gfs2_glock *gl, int flags) |
183 | { | 173 | { |
184 | struct gfs2_inode *ip = gl->gl_object; | 174 | struct gfs2_inode *ip = gl->gl_object; |
185 | int meta = (flags & DIO_METADATA); | ||
186 | 175 | ||
187 | if (meta) { | 176 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
188 | gfs2_meta_inval(gl); | 177 | |
178 | if (flags & DIO_METADATA) { | ||
179 | struct address_space *mapping = gl->gl_aspace->i_mapping; | ||
180 | truncate_inode_pages(mapping, 0); | ||
189 | if (ip) | 181 | if (ip) |
190 | set_bit(GIF_INVALID, &ip->i_flags); | 182 | set_bit(GIF_INVALID, &ip->i_flags); |
191 | } | 183 | } |
192 | 184 | ||
185 | if (ip == GFS2_I(gl->gl_sbd->sd_rindex)) | ||
186 | gl->gl_sbd->sd_rindex_uptodate = 0; | ||
193 | if (ip && S_ISREG(ip->i_inode.i_mode)) | 187 | if (ip && S_ISREG(ip->i_inode.i_mode)) |
194 | truncate_inode_pages(ip->i_inode.i_mapping, 0); | 188 | truncate_inode_pages(ip->i_inode.i_mapping, 0); |
195 | } | 189 | } |
@@ -390,20 +384,7 @@ static int trans_go_demote_ok(const struct gfs2_glock *gl) | |||
390 | return 0; | 384 | return 0; |
391 | } | 385 | } |
392 | 386 | ||
393 | /** | ||
394 | * quota_go_demote_ok - Check to see if it's ok to unlock a quota glock | ||
395 | * @gl: the glock | ||
396 | * | ||
397 | * Returns: 1 if it's ok | ||
398 | */ | ||
399 | |||
400 | static int quota_go_demote_ok(const struct gfs2_glock *gl) | ||
401 | { | ||
402 | return !atomic_read(&gl->gl_lvb_count); | ||
403 | } | ||
404 | |||
405 | const struct gfs2_glock_operations gfs2_meta_glops = { | 387 | const struct gfs2_glock_operations gfs2_meta_glops = { |
406 | .go_xmote_th = meta_go_sync, | ||
407 | .go_type = LM_TYPE_META, | 388 | .go_type = LM_TYPE_META, |
408 | }; | 389 | }; |
409 | 390 | ||
@@ -418,8 +399,8 @@ const struct gfs2_glock_operations gfs2_inode_glops = { | |||
418 | }; | 399 | }; |
419 | 400 | ||
420 | const struct gfs2_glock_operations gfs2_rgrp_glops = { | 401 | const struct gfs2_glock_operations gfs2_rgrp_glops = { |
421 | .go_xmote_th = meta_go_sync, | 402 | .go_xmote_th = rgrp_go_sync, |
422 | .go_inval = meta_go_inval, | 403 | .go_inval = rgrp_go_inval, |
423 | .go_demote_ok = rgrp_go_demote_ok, | 404 | .go_demote_ok = rgrp_go_demote_ok, |
424 | .go_lock = rgrp_go_lock, | 405 | .go_lock = rgrp_go_lock, |
425 | .go_unlock = rgrp_go_unlock, | 406 | .go_unlock = rgrp_go_unlock, |
@@ -448,7 +429,6 @@ const struct gfs2_glock_operations gfs2_nondisk_glops = { | |||
448 | }; | 429 | }; |
449 | 430 | ||
450 | const struct gfs2_glock_operations gfs2_quota_glops = { | 431 | const struct gfs2_glock_operations gfs2_quota_glops = { |
451 | .go_demote_ok = quota_go_demote_ok, | ||
452 | .go_type = LM_TYPE_QUOTA, | 432 | .go_type = LM_TYPE_QUOTA, |
453 | }; | 433 | }; |
454 | 434 | ||
@@ -456,3 +436,15 @@ const struct gfs2_glock_operations gfs2_journal_glops = { | |||
456 | .go_type = LM_TYPE_JOURNAL, | 436 | .go_type = LM_TYPE_JOURNAL, |
457 | }; | 437 | }; |
458 | 438 | ||
439 | const struct gfs2_glock_operations *gfs2_glops_list[] = { | ||
440 | [LM_TYPE_META] = &gfs2_meta_glops, | ||
441 | [LM_TYPE_INODE] = &gfs2_inode_glops, | ||
442 | [LM_TYPE_RGRP] = &gfs2_rgrp_glops, | ||
443 | [LM_TYPE_NONDISK] = &gfs2_trans_glops, | ||
444 | [LM_TYPE_IOPEN] = &gfs2_iopen_glops, | ||
445 | [LM_TYPE_FLOCK] = &gfs2_flock_glops, | ||
446 | [LM_TYPE_NONDISK] = &gfs2_nondisk_glops, | ||
447 | [LM_TYPE_QUOTA] = &gfs2_quota_glops, | ||
448 | [LM_TYPE_JOURNAL] = &gfs2_journal_glops, | ||
449 | }; | ||
450 | |||
diff --git a/fs/gfs2/glops.h b/fs/gfs2/glops.h index a1d9b5b024e6..b3aa2e3210fd 100644 --- a/fs/gfs2/glops.h +++ b/fs/gfs2/glops.h | |||
@@ -21,5 +21,6 @@ extern const struct gfs2_glock_operations gfs2_flock_glops; | |||
21 | extern const struct gfs2_glock_operations gfs2_nondisk_glops; | 21 | extern const struct gfs2_glock_operations gfs2_nondisk_glops; |
22 | extern const struct gfs2_glock_operations gfs2_quota_glops; | 22 | extern const struct gfs2_glock_operations gfs2_quota_glops; |
23 | extern const struct gfs2_glock_operations gfs2_journal_glops; | 23 | extern const struct gfs2_glock_operations gfs2_journal_glops; |
24 | extern const struct gfs2_glock_operations *gfs2_glops_list[]; | ||
24 | 25 | ||
25 | #endif /* __GLOPS_DOT_H__ */ | 26 | #endif /* __GLOPS_DOT_H__ */ |
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 608849d00021..399d1b978049 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h | |||
@@ -12,6 +12,8 @@ | |||
12 | 12 | ||
13 | #include <linux/fs.h> | 13 | #include <linux/fs.h> |
14 | #include <linux/workqueue.h> | 14 | #include <linux/workqueue.h> |
15 | #include <linux/dlm.h> | ||
16 | #include <linux/buffer_head.h> | ||
15 | 17 | ||
16 | #define DIO_WAIT 0x00000010 | 18 | #define DIO_WAIT 0x00000010 |
17 | #define DIO_METADATA 0x00000020 | 19 | #define DIO_METADATA 0x00000020 |
@@ -26,6 +28,7 @@ struct gfs2_trans; | |||
26 | struct gfs2_ail; | 28 | struct gfs2_ail; |
27 | struct gfs2_jdesc; | 29 | struct gfs2_jdesc; |
28 | struct gfs2_sbd; | 30 | struct gfs2_sbd; |
31 | struct lm_lockops; | ||
29 | 32 | ||
30 | typedef void (*gfs2_glop_bh_t) (struct gfs2_glock *gl, unsigned int ret); | 33 | typedef void (*gfs2_glop_bh_t) (struct gfs2_glock *gl, unsigned int ret); |
31 | 34 | ||
@@ -121,6 +124,28 @@ struct gfs2_bufdata { | |||
121 | struct list_head bd_ail_gl_list; | 124 | struct list_head bd_ail_gl_list; |
122 | }; | 125 | }; |
123 | 126 | ||
127 | /* | ||
128 | * Internally, we prefix things with gdlm_ and GDLM_ (for gfs-dlm) since a | ||
129 | * prefix of lock_dlm_ gets awkward. | ||
130 | */ | ||
131 | |||
132 | #define GDLM_STRNAME_BYTES 25 | ||
133 | #define GDLM_LVB_SIZE 32 | ||
134 | |||
135 | enum { | ||
136 | DFL_BLOCK_LOCKS = 0, | ||
137 | }; | ||
138 | |||
139 | struct lm_lockname { | ||
140 | u64 ln_number; | ||
141 | unsigned int ln_type; | ||
142 | }; | ||
143 | |||
144 | #define lm_name_equal(name1, name2) \ | ||
145 | (((name1)->ln_number == (name2)->ln_number) && \ | ||
146 | ((name1)->ln_type == (name2)->ln_type)) | ||
147 | |||
148 | |||
124 | struct gfs2_glock_operations { | 149 | struct gfs2_glock_operations { |
125 | void (*go_xmote_th) (struct gfs2_glock *gl); | 150 | void (*go_xmote_th) (struct gfs2_glock *gl); |
126 | int (*go_xmote_bh) (struct gfs2_glock *gl, struct gfs2_holder *gh); | 151 | int (*go_xmote_bh) (struct gfs2_glock *gl, struct gfs2_holder *gh); |
@@ -162,6 +187,8 @@ enum { | |||
162 | GLF_LFLUSH = 7, | 187 | GLF_LFLUSH = 7, |
163 | GLF_INVALIDATE_IN_PROGRESS = 8, | 188 | GLF_INVALIDATE_IN_PROGRESS = 8, |
164 | GLF_REPLY_PENDING = 9, | 189 | GLF_REPLY_PENDING = 9, |
190 | GLF_INITIAL = 10, | ||
191 | GLF_FROZEN = 11, | ||
165 | }; | 192 | }; |
166 | 193 | ||
167 | struct gfs2_glock { | 194 | struct gfs2_glock { |
@@ -176,16 +203,15 @@ struct gfs2_glock { | |||
176 | unsigned int gl_target; | 203 | unsigned int gl_target; |
177 | unsigned int gl_reply; | 204 | unsigned int gl_reply; |
178 | unsigned int gl_hash; | 205 | unsigned int gl_hash; |
206 | unsigned int gl_req; | ||
179 | unsigned int gl_demote_state; /* state requested by remote node */ | 207 | unsigned int gl_demote_state; /* state requested by remote node */ |
180 | unsigned long gl_demote_time; /* time of first demote request */ | 208 | unsigned long gl_demote_time; /* time of first demote request */ |
181 | struct list_head gl_holders; | 209 | struct list_head gl_holders; |
182 | 210 | ||
183 | const struct gfs2_glock_operations *gl_ops; | 211 | const struct gfs2_glock_operations *gl_ops; |
184 | void *gl_lock; | 212 | char gl_strname[GDLM_STRNAME_BYTES]; |
185 | char *gl_lvb; | 213 | struct dlm_lksb gl_lksb; |
186 | atomic_t gl_lvb_count; | 214 | char gl_lvb[32]; |
187 | |||
188 | unsigned long gl_stamp; | ||
189 | unsigned long gl_tchange; | 215 | unsigned long gl_tchange; |
190 | void *gl_object; | 216 | void *gl_object; |
191 | 217 | ||
@@ -283,7 +309,9 @@ enum { | |||
283 | 309 | ||
284 | struct gfs2_quota_data { | 310 | struct gfs2_quota_data { |
285 | struct list_head qd_list; | 311 | struct list_head qd_list; |
286 | unsigned int qd_count; | 312 | struct list_head qd_reclaim; |
313 | |||
314 | atomic_t qd_count; | ||
287 | 315 | ||
288 | u32 qd_id; | 316 | u32 qd_id; |
289 | unsigned long qd_flags; /* QDF_... */ | 317 | unsigned long qd_flags; /* QDF_... */ |
@@ -303,7 +331,6 @@ struct gfs2_quota_data { | |||
303 | 331 | ||
304 | u64 qd_sync_gen; | 332 | u64 qd_sync_gen; |
305 | unsigned long qd_last_warn; | 333 | unsigned long qd_last_warn; |
306 | unsigned long qd_last_touched; | ||
307 | }; | 334 | }; |
308 | 335 | ||
309 | struct gfs2_trans { | 336 | struct gfs2_trans { |
@@ -390,7 +417,7 @@ struct gfs2_args { | |||
390 | unsigned int ar_suiddir:1; /* suiddir support */ | 417 | unsigned int ar_suiddir:1; /* suiddir support */ |
391 | unsigned int ar_data:2; /* ordered/writeback */ | 418 | unsigned int ar_data:2; /* ordered/writeback */ |
392 | unsigned int ar_meta:1; /* mount metafs */ | 419 | unsigned int ar_meta:1; /* mount metafs */ |
393 | unsigned int ar_num_glockd; /* Number of glockd threads */ | 420 | unsigned int ar_discard:1; /* discard requests */ |
394 | }; | 421 | }; |
395 | 422 | ||
396 | struct gfs2_tune { | 423 | struct gfs2_tune { |
@@ -406,7 +433,6 @@ struct gfs2_tune { | |||
406 | unsigned int gt_quota_warn_period; /* Secs between quota warn msgs */ | 433 | unsigned int gt_quota_warn_period; /* Secs between quota warn msgs */ |
407 | unsigned int gt_quota_scale_num; /* Numerator */ | 434 | unsigned int gt_quota_scale_num; /* Numerator */ |
408 | unsigned int gt_quota_scale_den; /* Denominator */ | 435 | unsigned int gt_quota_scale_den; /* Denominator */ |
409 | unsigned int gt_quota_cache_secs; | ||
410 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ | 436 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ |
411 | unsigned int gt_new_files_jdata; | 437 | unsigned int gt_new_files_jdata; |
412 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ | 438 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ |
@@ -445,6 +471,31 @@ struct gfs2_sb_host { | |||
445 | 471 | ||
446 | char sb_lockproto[GFS2_LOCKNAME_LEN]; | 472 | char sb_lockproto[GFS2_LOCKNAME_LEN]; |
447 | char sb_locktable[GFS2_LOCKNAME_LEN]; | 473 | char sb_locktable[GFS2_LOCKNAME_LEN]; |
474 | u8 sb_uuid[16]; | ||
475 | }; | ||
476 | |||
477 | /* | ||
478 | * lm_mount() return values | ||
479 | * | ||
480 | * ls_jid - the journal ID this node should use | ||
481 | * ls_first - this node is the first to mount the file system | ||
482 | * ls_lockspace - lock module's context for this file system | ||
483 | * ls_ops - lock module's functions | ||
484 | */ | ||
485 | |||
486 | struct lm_lockstruct { | ||
487 | u32 ls_id; | ||
488 | unsigned int ls_jid; | ||
489 | unsigned int ls_first; | ||
490 | unsigned int ls_first_done; | ||
491 | unsigned int ls_nodir; | ||
492 | const struct lm_lockops *ls_ops; | ||
493 | unsigned long ls_flags; | ||
494 | dlm_lockspace_t *ls_dlm; | ||
495 | |||
496 | int ls_recover_jid; | ||
497 | int ls_recover_jid_done; | ||
498 | int ls_recover_jid_status; | ||
448 | }; | 499 | }; |
449 | 500 | ||
450 | struct gfs2_sbd { | 501 | struct gfs2_sbd { |
@@ -520,7 +571,6 @@ struct gfs2_sbd { | |||
520 | spinlock_t sd_jindex_spin; | 571 | spinlock_t sd_jindex_spin; |
521 | struct mutex sd_jindex_mutex; | 572 | struct mutex sd_jindex_mutex; |
522 | unsigned int sd_journals; | 573 | unsigned int sd_journals; |
523 | unsigned long sd_jindex_refresh_time; | ||
524 | 574 | ||
525 | struct gfs2_jdesc *sd_jdesc; | 575 | struct gfs2_jdesc *sd_jdesc; |
526 | struct gfs2_holder sd_journal_gh; | 576 | struct gfs2_holder sd_journal_gh; |
@@ -540,7 +590,6 @@ struct gfs2_sbd { | |||
540 | 590 | ||
541 | struct list_head sd_quota_list; | 591 | struct list_head sd_quota_list; |
542 | atomic_t sd_quota_count; | 592 | atomic_t sd_quota_count; |
543 | spinlock_t sd_quota_spin; | ||
544 | struct mutex sd_quota_mutex; | 593 | struct mutex sd_quota_mutex; |
545 | wait_queue_head_t sd_quota_wait; | 594 | wait_queue_head_t sd_quota_wait; |
546 | struct list_head sd_trunc_list; | 595 | struct list_head sd_trunc_list; |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 3b87c188da41..7b277d449155 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -16,7 +16,6 @@ | |||
16 | #include <linux/sort.h> | 16 | #include <linux/sort.h> |
17 | #include <linux/gfs2_ondisk.h> | 17 | #include <linux/gfs2_ondisk.h> |
18 | #include <linux/crc32.h> | 18 | #include <linux/crc32.h> |
19 | #include <linux/lm_interface.h> | ||
20 | #include <linux/security.h> | 19 | #include <linux/security.h> |
21 | #include <linux/time.h> | 20 | #include <linux/time.h> |
22 | 21 | ||
@@ -137,16 +136,16 @@ void gfs2_set_iop(struct inode *inode) | |||
137 | 136 | ||
138 | if (S_ISREG(mode)) { | 137 | if (S_ISREG(mode)) { |
139 | inode->i_op = &gfs2_file_iops; | 138 | inode->i_op = &gfs2_file_iops; |
140 | if (sdp->sd_args.ar_localflocks) | 139 | if (gfs2_localflocks(sdp)) |
141 | inode->i_fop = &gfs2_file_fops_nolock; | 140 | inode->i_fop = gfs2_file_fops_nolock; |
142 | else | 141 | else |
143 | inode->i_fop = &gfs2_file_fops; | 142 | inode->i_fop = gfs2_file_fops; |
144 | } else if (S_ISDIR(mode)) { | 143 | } else if (S_ISDIR(mode)) { |
145 | inode->i_op = &gfs2_dir_iops; | 144 | inode->i_op = &gfs2_dir_iops; |
146 | if (sdp->sd_args.ar_localflocks) | 145 | if (gfs2_localflocks(sdp)) |
147 | inode->i_fop = &gfs2_dir_fops_nolock; | 146 | inode->i_fop = gfs2_dir_fops_nolock; |
148 | else | 147 | else |
149 | inode->i_fop = &gfs2_dir_fops; | 148 | inode->i_fop = gfs2_dir_fops; |
150 | } else if (S_ISLNK(mode)) { | 149 | } else if (S_ISLNK(mode)) { |
151 | inode->i_op = &gfs2_symlink_iops; | 150 | inode->i_op = &gfs2_symlink_iops; |
152 | } else { | 151 | } else { |
diff --git a/fs/gfs2/inode.h b/fs/gfs2/inode.h index d5329364cdff..dca4fee3078b 100644 --- a/fs/gfs2/inode.h +++ b/fs/gfs2/inode.h | |||
@@ -101,12 +101,26 @@ void gfs2_dinode_print(const struct gfs2_inode *ip); | |||
101 | extern const struct inode_operations gfs2_file_iops; | 101 | extern const struct inode_operations gfs2_file_iops; |
102 | extern const struct inode_operations gfs2_dir_iops; | 102 | extern const struct inode_operations gfs2_dir_iops; |
103 | extern const struct inode_operations gfs2_symlink_iops; | 103 | extern const struct inode_operations gfs2_symlink_iops; |
104 | extern const struct file_operations gfs2_file_fops; | 104 | extern const struct file_operations *gfs2_file_fops_nolock; |
105 | extern const struct file_operations gfs2_dir_fops; | 105 | extern const struct file_operations *gfs2_dir_fops_nolock; |
106 | extern const struct file_operations gfs2_file_fops_nolock; | ||
107 | extern const struct file_operations gfs2_dir_fops_nolock; | ||
108 | 106 | ||
109 | extern void gfs2_set_inode_flags(struct inode *inode); | 107 | extern void gfs2_set_inode_flags(struct inode *inode); |
108 | |||
109 | #ifdef CONFIG_GFS2_FS_LOCKING_DLM | ||
110 | extern const struct file_operations *gfs2_file_fops; | ||
111 | extern const struct file_operations *gfs2_dir_fops; | ||
112 | static inline int gfs2_localflocks(const struct gfs2_sbd *sdp) | ||
113 | { | ||
114 | return sdp->sd_args.ar_localflocks; | ||
115 | } | ||
116 | #else /* Single node only */ | ||
117 | #define gfs2_file_fops NULL | ||
118 | #define gfs2_dir_fops NULL | ||
119 | static inline int gfs2_localflocks(const struct gfs2_sbd *sdp) | ||
120 | { | ||
121 | return 1; | ||
122 | } | ||
123 | #endif /* CONFIG_GFS2_FS_LOCKING_DLM */ | ||
110 | 124 | ||
111 | #endif /* __INODE_DOT_H__ */ | 125 | #endif /* __INODE_DOT_H__ */ |
112 | 126 | ||
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c new file mode 100644 index 000000000000..46df988323bc --- /dev/null +++ b/fs/gfs2/lock_dlm.c | |||
@@ -0,0 +1,241 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include <linux/fs.h> | ||
11 | #include <linux/dlm.h> | ||
12 | #include <linux/types.h> | ||
13 | #include <linux/gfs2_ondisk.h> | ||
14 | |||
15 | #include "incore.h" | ||
16 | #include "glock.h" | ||
17 | #include "util.h" | ||
18 | |||
19 | |||
20 | static void gdlm_ast(void *arg) | ||
21 | { | ||
22 | struct gfs2_glock *gl = arg; | ||
23 | unsigned ret = gl->gl_state; | ||
24 | |||
25 | BUG_ON(gl->gl_lksb.sb_flags & DLM_SBF_DEMOTED); | ||
26 | |||
27 | if (gl->gl_lksb.sb_flags & DLM_SBF_VALNOTVALID) | ||
28 | memset(gl->gl_lvb, 0, GDLM_LVB_SIZE); | ||
29 | |||
30 | switch (gl->gl_lksb.sb_status) { | ||
31 | case -DLM_EUNLOCK: /* Unlocked, so glock can be freed */ | ||
32 | kmem_cache_free(gfs2_glock_cachep, gl); | ||
33 | return; | ||
34 | case -DLM_ECANCEL: /* Cancel while getting lock */ | ||
35 | ret |= LM_OUT_CANCELED; | ||
36 | goto out; | ||
37 | case -EAGAIN: /* Try lock fails */ | ||
38 | goto out; | ||
39 | case -EINVAL: /* Invalid */ | ||
40 | case -ENOMEM: /* Out of memory */ | ||
41 | ret |= LM_OUT_ERROR; | ||
42 | goto out; | ||
43 | case 0: /* Success */ | ||
44 | break; | ||
45 | default: /* Something unexpected */ | ||
46 | BUG(); | ||
47 | } | ||
48 | |||
49 | ret = gl->gl_req; | ||
50 | if (gl->gl_lksb.sb_flags & DLM_SBF_ALTMODE) { | ||
51 | if (gl->gl_req == LM_ST_SHARED) | ||
52 | ret = LM_ST_DEFERRED; | ||
53 | else if (gl->gl_req == LM_ST_DEFERRED) | ||
54 | ret = LM_ST_SHARED; | ||
55 | else | ||
56 | BUG(); | ||
57 | } | ||
58 | |||
59 | set_bit(GLF_INITIAL, &gl->gl_flags); | ||
60 | gfs2_glock_complete(gl, ret); | ||
61 | return; | ||
62 | out: | ||
63 | if (!test_bit(GLF_INITIAL, &gl->gl_flags)) | ||
64 | gl->gl_lksb.sb_lkid = 0; | ||
65 | gfs2_glock_complete(gl, ret); | ||
66 | } | ||
67 | |||
68 | static void gdlm_bast(void *arg, int mode) | ||
69 | { | ||
70 | struct gfs2_glock *gl = arg; | ||
71 | |||
72 | switch (mode) { | ||
73 | case DLM_LOCK_EX: | ||
74 | gfs2_glock_cb(gl, LM_ST_UNLOCKED); | ||
75 | break; | ||
76 | case DLM_LOCK_CW: | ||
77 | gfs2_glock_cb(gl, LM_ST_DEFERRED); | ||
78 | break; | ||
79 | case DLM_LOCK_PR: | ||
80 | gfs2_glock_cb(gl, LM_ST_SHARED); | ||
81 | break; | ||
82 | default: | ||
83 | printk(KERN_ERR "unknown bast mode %d", mode); | ||
84 | BUG(); | ||
85 | } | ||
86 | } | ||
87 | |||
88 | /* convert gfs lock-state to dlm lock-mode */ | ||
89 | |||
90 | static int make_mode(const unsigned int lmstate) | ||
91 | { | ||
92 | switch (lmstate) { | ||
93 | case LM_ST_UNLOCKED: | ||
94 | return DLM_LOCK_NL; | ||
95 | case LM_ST_EXCLUSIVE: | ||
96 | return DLM_LOCK_EX; | ||
97 | case LM_ST_DEFERRED: | ||
98 | return DLM_LOCK_CW; | ||
99 | case LM_ST_SHARED: | ||
100 | return DLM_LOCK_PR; | ||
101 | } | ||
102 | printk(KERN_ERR "unknown LM state %d", lmstate); | ||
103 | BUG(); | ||
104 | return -1; | ||
105 | } | ||
106 | |||
107 | static u32 make_flags(const u32 lkid, const unsigned int gfs_flags, | ||
108 | const int req) | ||
109 | { | ||
110 | u32 lkf = 0; | ||
111 | |||
112 | if (gfs_flags & LM_FLAG_TRY) | ||
113 | lkf |= DLM_LKF_NOQUEUE; | ||
114 | |||
115 | if (gfs_flags & LM_FLAG_TRY_1CB) { | ||
116 | lkf |= DLM_LKF_NOQUEUE; | ||
117 | lkf |= DLM_LKF_NOQUEUEBAST; | ||
118 | } | ||
119 | |||
120 | if (gfs_flags & LM_FLAG_PRIORITY) { | ||
121 | lkf |= DLM_LKF_NOORDER; | ||
122 | lkf |= DLM_LKF_HEADQUE; | ||
123 | } | ||
124 | |||
125 | if (gfs_flags & LM_FLAG_ANY) { | ||
126 | if (req == DLM_LOCK_PR) | ||
127 | lkf |= DLM_LKF_ALTCW; | ||
128 | else if (req == DLM_LOCK_CW) | ||
129 | lkf |= DLM_LKF_ALTPR; | ||
130 | else | ||
131 | BUG(); | ||
132 | } | ||
133 | |||
134 | if (lkid != 0) | ||
135 | lkf |= DLM_LKF_CONVERT; | ||
136 | |||
137 | lkf |= DLM_LKF_VALBLK; | ||
138 | |||
139 | return lkf; | ||
140 | } | ||
141 | |||
142 | static unsigned int gdlm_lock(struct gfs2_glock *gl, | ||
143 | unsigned int req_state, unsigned int flags) | ||
144 | { | ||
145 | struct lm_lockstruct *ls = &gl->gl_sbd->sd_lockstruct; | ||
146 | int error; | ||
147 | int req; | ||
148 | u32 lkf; | ||
149 | |||
150 | gl->gl_req = req_state; | ||
151 | req = make_mode(req_state); | ||
152 | lkf = make_flags(gl->gl_lksb.sb_lkid, flags, req); | ||
153 | |||
154 | /* | ||
155 | * Submit the actual lock request. | ||
156 | */ | ||
157 | |||
158 | error = dlm_lock(ls->ls_dlm, req, &gl->gl_lksb, lkf, gl->gl_strname, | ||
159 | GDLM_STRNAME_BYTES - 1, 0, gdlm_ast, gl, gdlm_bast); | ||
160 | if (error == -EAGAIN) | ||
161 | return 0; | ||
162 | if (error) | ||
163 | return LM_OUT_ERROR; | ||
164 | return LM_OUT_ASYNC; | ||
165 | } | ||
166 | |||
167 | static void gdlm_put_lock(struct kmem_cache *cachep, void *ptr) | ||
168 | { | ||
169 | struct gfs2_glock *gl = ptr; | ||
170 | struct lm_lockstruct *ls = &gl->gl_sbd->sd_lockstruct; | ||
171 | int error; | ||
172 | |||
173 | if (gl->gl_lksb.sb_lkid == 0) { | ||
174 | kmem_cache_free(cachep, gl); | ||
175 | return; | ||
176 | } | ||
177 | |||
178 | error = dlm_unlock(ls->ls_dlm, gl->gl_lksb.sb_lkid, DLM_LKF_VALBLK, | ||
179 | NULL, gl); | ||
180 | if (error) { | ||
181 | printk(KERN_ERR "gdlm_unlock %x,%llx err=%d\n", | ||
182 | gl->gl_name.ln_type, | ||
183 | (unsigned long long)gl->gl_name.ln_number, error); | ||
184 | return; | ||
185 | } | ||
186 | } | ||
187 | |||
188 | static void gdlm_cancel(struct gfs2_glock *gl) | ||
189 | { | ||
190 | struct lm_lockstruct *ls = &gl->gl_sbd->sd_lockstruct; | ||
191 | dlm_unlock(ls->ls_dlm, gl->gl_lksb.sb_lkid, DLM_LKF_CANCEL, NULL, gl); | ||
192 | } | ||
193 | |||
194 | static int gdlm_mount(struct gfs2_sbd *sdp, const char *fsname) | ||
195 | { | ||
196 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
197 | int error; | ||
198 | |||
199 | if (fsname == NULL) { | ||
200 | fs_info(sdp, "no fsname found\n"); | ||
201 | return -EINVAL; | ||
202 | } | ||
203 | |||
204 | error = dlm_new_lockspace(fsname, strlen(fsname), &ls->ls_dlm, | ||
205 | DLM_LSFL_FS | DLM_LSFL_NEWEXCL | | ||
206 | (ls->ls_nodir ? DLM_LSFL_NODIR : 0), | ||
207 | GDLM_LVB_SIZE); | ||
208 | if (error) | ||
209 | printk(KERN_ERR "dlm_new_lockspace error %d", error); | ||
210 | |||
211 | return error; | ||
212 | } | ||
213 | |||
214 | static void gdlm_unmount(struct gfs2_sbd *sdp) | ||
215 | { | ||
216 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
217 | |||
218 | if (ls->ls_dlm) { | ||
219 | dlm_release_lockspace(ls->ls_dlm, 2); | ||
220 | ls->ls_dlm = NULL; | ||
221 | } | ||
222 | } | ||
223 | |||
224 | static const match_table_t dlm_tokens = { | ||
225 | { Opt_jid, "jid=%d"}, | ||
226 | { Opt_id, "id=%d"}, | ||
227 | { Opt_first, "first=%d"}, | ||
228 | { Opt_nodir, "nodir=%d"}, | ||
229 | { Opt_err, NULL }, | ||
230 | }; | ||
231 | |||
232 | const struct lm_lockops gfs2_dlm_ops = { | ||
233 | .lm_proto_name = "lock_dlm", | ||
234 | .lm_mount = gdlm_mount, | ||
235 | .lm_unmount = gdlm_unmount, | ||
236 | .lm_put_lock = gdlm_put_lock, | ||
237 | .lm_lock = gdlm_lock, | ||
238 | .lm_cancel = gdlm_cancel, | ||
239 | .lm_tokens = &dlm_tokens, | ||
240 | }; | ||
241 | |||
diff --git a/fs/gfs2/locking.c b/fs/gfs2/locking.c deleted file mode 100644 index 523243a13a21..000000000000 --- a/fs/gfs2/locking.c +++ /dev/null | |||
@@ -1,232 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include <linux/module.h> | ||
11 | #include <linux/init.h> | ||
12 | #include <linux/string.h> | ||
13 | #include <linux/slab.h> | ||
14 | #include <linux/wait.h> | ||
15 | #include <linux/sched.h> | ||
16 | #include <linux/kmod.h> | ||
17 | #include <linux/fs.h> | ||
18 | #include <linux/delay.h> | ||
19 | #include <linux/lm_interface.h> | ||
20 | |||
21 | struct lmh_wrapper { | ||
22 | struct list_head lw_list; | ||
23 | const struct lm_lockops *lw_ops; | ||
24 | }; | ||
25 | |||
26 | static int nolock_mount(char *table_name, char *host_data, | ||
27 | lm_callback_t cb, void *cb_data, | ||
28 | unsigned int min_lvb_size, int flags, | ||
29 | struct lm_lockstruct *lockstruct, | ||
30 | struct kobject *fskobj); | ||
31 | |||
32 | /* List of registered low-level locking protocols. A file system selects one | ||
33 | of them by name at mount time, e.g. lock_nolock, lock_dlm. */ | ||
34 | |||
35 | static const struct lm_lockops nolock_ops = { | ||
36 | .lm_proto_name = "lock_nolock", | ||
37 | .lm_mount = nolock_mount, | ||
38 | }; | ||
39 | |||
40 | static struct lmh_wrapper nolock_proto = { | ||
41 | .lw_list = LIST_HEAD_INIT(nolock_proto.lw_list), | ||
42 | .lw_ops = &nolock_ops, | ||
43 | }; | ||
44 | |||
45 | static LIST_HEAD(lmh_list); | ||
46 | static DEFINE_MUTEX(lmh_lock); | ||
47 | |||
48 | static int nolock_mount(char *table_name, char *host_data, | ||
49 | lm_callback_t cb, void *cb_data, | ||
50 | unsigned int min_lvb_size, int flags, | ||
51 | struct lm_lockstruct *lockstruct, | ||
52 | struct kobject *fskobj) | ||
53 | { | ||
54 | char *c; | ||
55 | unsigned int jid; | ||
56 | |||
57 | c = strstr(host_data, "jid="); | ||
58 | if (!c) | ||
59 | jid = 0; | ||
60 | else { | ||
61 | c += 4; | ||
62 | sscanf(c, "%u", &jid); | ||
63 | } | ||
64 | |||
65 | lockstruct->ls_jid = jid; | ||
66 | lockstruct->ls_first = 1; | ||
67 | lockstruct->ls_lvb_size = min_lvb_size; | ||
68 | lockstruct->ls_ops = &nolock_ops; | ||
69 | lockstruct->ls_flags = LM_LSFLAG_LOCAL; | ||
70 | |||
71 | return 0; | ||
72 | } | ||
73 | |||
74 | /** | ||
75 | * gfs2_register_lockproto - Register a low-level locking protocol | ||
76 | * @proto: the protocol definition | ||
77 | * | ||
78 | * Returns: 0 on success, -EXXX on failure | ||
79 | */ | ||
80 | |||
81 | int gfs2_register_lockproto(const struct lm_lockops *proto) | ||
82 | { | ||
83 | struct lmh_wrapper *lw; | ||
84 | |||
85 | mutex_lock(&lmh_lock); | ||
86 | |||
87 | list_for_each_entry(lw, &lmh_list, lw_list) { | ||
88 | if (!strcmp(lw->lw_ops->lm_proto_name, proto->lm_proto_name)) { | ||
89 | mutex_unlock(&lmh_lock); | ||
90 | printk(KERN_INFO "GFS2: protocol %s already exists\n", | ||
91 | proto->lm_proto_name); | ||
92 | return -EEXIST; | ||
93 | } | ||
94 | } | ||
95 | |||
96 | lw = kzalloc(sizeof(struct lmh_wrapper), GFP_KERNEL); | ||
97 | if (!lw) { | ||
98 | mutex_unlock(&lmh_lock); | ||
99 | return -ENOMEM; | ||
100 | } | ||
101 | |||
102 | lw->lw_ops = proto; | ||
103 | list_add(&lw->lw_list, &lmh_list); | ||
104 | |||
105 | mutex_unlock(&lmh_lock); | ||
106 | |||
107 | return 0; | ||
108 | } | ||
109 | |||
110 | /** | ||
111 | * gfs2_unregister_lockproto - Unregister a low-level locking protocol | ||
112 | * @proto: the protocol definition | ||
113 | * | ||
114 | */ | ||
115 | |||
116 | void gfs2_unregister_lockproto(const struct lm_lockops *proto) | ||
117 | { | ||
118 | struct lmh_wrapper *lw; | ||
119 | |||
120 | mutex_lock(&lmh_lock); | ||
121 | |||
122 | list_for_each_entry(lw, &lmh_list, lw_list) { | ||
123 | if (!strcmp(lw->lw_ops->lm_proto_name, proto->lm_proto_name)) { | ||
124 | list_del(&lw->lw_list); | ||
125 | mutex_unlock(&lmh_lock); | ||
126 | kfree(lw); | ||
127 | return; | ||
128 | } | ||
129 | } | ||
130 | |||
131 | mutex_unlock(&lmh_lock); | ||
132 | |||
133 | printk(KERN_WARNING "GFS2: can't unregister lock protocol %s\n", | ||
134 | proto->lm_proto_name); | ||
135 | } | ||
136 | |||
137 | /** | ||
138 | * gfs2_mount_lockproto - Mount a lock protocol | ||
139 | * @proto_name - the name of the protocol | ||
140 | * @table_name - the name of the lock space | ||
141 | * @host_data - data specific to this host | ||
142 | * @cb - the callback to the code using the lock module | ||
143 | * @sdp - The GFS2 superblock | ||
144 | * @min_lvb_size - the mininum LVB size that the caller can deal with | ||
145 | * @flags - LM_MFLAG_* | ||
146 | * @lockstruct - a structure returned describing the mount | ||
147 | * | ||
148 | * Returns: 0 on success, -EXXX on failure | ||
149 | */ | ||
150 | |||
151 | int gfs2_mount_lockproto(char *proto_name, char *table_name, char *host_data, | ||
152 | lm_callback_t cb, void *cb_data, | ||
153 | unsigned int min_lvb_size, int flags, | ||
154 | struct lm_lockstruct *lockstruct, | ||
155 | struct kobject *fskobj) | ||
156 | { | ||
157 | struct lmh_wrapper *lw = NULL; | ||
158 | int try = 0; | ||
159 | int error, found; | ||
160 | |||
161 | |||
162 | retry: | ||
163 | mutex_lock(&lmh_lock); | ||
164 | |||
165 | if (list_empty(&nolock_proto.lw_list)) | ||
166 | list_add(&nolock_proto.lw_list, &lmh_list); | ||
167 | |||
168 | found = 0; | ||
169 | list_for_each_entry(lw, &lmh_list, lw_list) { | ||
170 | if (!strcmp(lw->lw_ops->lm_proto_name, proto_name)) { | ||
171 | found = 1; | ||
172 | break; | ||
173 | } | ||
174 | } | ||
175 | |||
176 | if (!found) { | ||
177 | if (!try && capable(CAP_SYS_MODULE)) { | ||
178 | try = 1; | ||
179 | mutex_unlock(&lmh_lock); | ||
180 | request_module(proto_name); | ||
181 | goto retry; | ||
182 | } | ||
183 | printk(KERN_INFO "GFS2: can't find protocol %s\n", proto_name); | ||
184 | error = -ENOENT; | ||
185 | goto out; | ||
186 | } | ||
187 | |||
188 | if (lw->lw_ops->lm_owner && | ||
189 | !try_module_get(lw->lw_ops->lm_owner)) { | ||
190 | try = 0; | ||
191 | mutex_unlock(&lmh_lock); | ||
192 | msleep(1000); | ||
193 | goto retry; | ||
194 | } | ||
195 | |||
196 | error = lw->lw_ops->lm_mount(table_name, host_data, cb, cb_data, | ||
197 | min_lvb_size, flags, lockstruct, fskobj); | ||
198 | if (error) | ||
199 | module_put(lw->lw_ops->lm_owner); | ||
200 | out: | ||
201 | mutex_unlock(&lmh_lock); | ||
202 | return error; | ||
203 | } | ||
204 | |||
205 | void gfs2_unmount_lockproto(struct lm_lockstruct *lockstruct) | ||
206 | { | ||
207 | mutex_lock(&lmh_lock); | ||
208 | if (lockstruct->ls_ops->lm_unmount) | ||
209 | lockstruct->ls_ops->lm_unmount(lockstruct->ls_lockspace); | ||
210 | if (lockstruct->ls_ops->lm_owner) | ||
211 | module_put(lockstruct->ls_ops->lm_owner); | ||
212 | mutex_unlock(&lmh_lock); | ||
213 | } | ||
214 | |||
215 | /** | ||
216 | * gfs2_withdraw_lockproto - abnormally unmount a lock module | ||
217 | * @lockstruct: the lockstruct passed into mount | ||
218 | * | ||
219 | */ | ||
220 | |||
221 | void gfs2_withdraw_lockproto(struct lm_lockstruct *lockstruct) | ||
222 | { | ||
223 | mutex_lock(&lmh_lock); | ||
224 | lockstruct->ls_ops->lm_withdraw(lockstruct->ls_lockspace); | ||
225 | if (lockstruct->ls_ops->lm_owner) | ||
226 | module_put(lockstruct->ls_ops->lm_owner); | ||
227 | mutex_unlock(&lmh_lock); | ||
228 | } | ||
229 | |||
230 | EXPORT_SYMBOL_GPL(gfs2_register_lockproto); | ||
231 | EXPORT_SYMBOL_GPL(gfs2_unregister_lockproto); | ||
232 | |||
diff --git a/fs/gfs2/locking/dlm/Makefile b/fs/gfs2/locking/dlm/Makefile deleted file mode 100644 index 2609bb6cd013..000000000000 --- a/fs/gfs2/locking/dlm/Makefile +++ /dev/null | |||
@@ -1,3 +0,0 @@ | |||
1 | obj-$(CONFIG_GFS2_FS_LOCKING_DLM) += lock_dlm.o | ||
2 | lock_dlm-y := lock.o main.o mount.o sysfs.o thread.o | ||
3 | |||
diff --git a/fs/gfs2/locking/dlm/lock.c b/fs/gfs2/locking/dlm/lock.c deleted file mode 100644 index 2482c9047505..000000000000 --- a/fs/gfs2/locking/dlm/lock.c +++ /dev/null | |||
@@ -1,708 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include "lock_dlm.h" | ||
11 | |||
12 | static char junk_lvb[GDLM_LVB_SIZE]; | ||
13 | |||
14 | |||
15 | /* convert dlm lock-mode to gfs lock-state */ | ||
16 | |||
17 | static s16 gdlm_make_lmstate(s16 dlmmode) | ||
18 | { | ||
19 | switch (dlmmode) { | ||
20 | case DLM_LOCK_IV: | ||
21 | case DLM_LOCK_NL: | ||
22 | return LM_ST_UNLOCKED; | ||
23 | case DLM_LOCK_EX: | ||
24 | return LM_ST_EXCLUSIVE; | ||
25 | case DLM_LOCK_CW: | ||
26 | return LM_ST_DEFERRED; | ||
27 | case DLM_LOCK_PR: | ||
28 | return LM_ST_SHARED; | ||
29 | } | ||
30 | gdlm_assert(0, "unknown DLM mode %d", dlmmode); | ||
31 | return -1; | ||
32 | } | ||
33 | |||
34 | /* A lock placed on this queue is re-submitted to DLM as soon as the lock_dlm | ||
35 | thread gets to it. */ | ||
36 | |||
37 | static void queue_submit(struct gdlm_lock *lp) | ||
38 | { | ||
39 | struct gdlm_ls *ls = lp->ls; | ||
40 | |||
41 | spin_lock(&ls->async_lock); | ||
42 | list_add_tail(&lp->delay_list, &ls->submit); | ||
43 | spin_unlock(&ls->async_lock); | ||
44 | wake_up(&ls->thread_wait); | ||
45 | } | ||
46 | |||
47 | static void wake_up_ast(struct gdlm_lock *lp) | ||
48 | { | ||
49 | clear_bit(LFL_AST_WAIT, &lp->flags); | ||
50 | smp_mb__after_clear_bit(); | ||
51 | wake_up_bit(&lp->flags, LFL_AST_WAIT); | ||
52 | } | ||
53 | |||
54 | static void gdlm_delete_lp(struct gdlm_lock *lp) | ||
55 | { | ||
56 | struct gdlm_ls *ls = lp->ls; | ||
57 | |||
58 | spin_lock(&ls->async_lock); | ||
59 | if (!list_empty(&lp->delay_list)) | ||
60 | list_del_init(&lp->delay_list); | ||
61 | ls->all_locks_count--; | ||
62 | spin_unlock(&ls->async_lock); | ||
63 | |||
64 | kfree(lp); | ||
65 | } | ||
66 | |||
67 | static void gdlm_queue_delayed(struct gdlm_lock *lp) | ||
68 | { | ||
69 | struct gdlm_ls *ls = lp->ls; | ||
70 | |||
71 | spin_lock(&ls->async_lock); | ||
72 | list_add_tail(&lp->delay_list, &ls->delayed); | ||
73 | spin_unlock(&ls->async_lock); | ||
74 | } | ||
75 | |||
76 | static void process_complete(struct gdlm_lock *lp) | ||
77 | { | ||
78 | struct gdlm_ls *ls = lp->ls; | ||
79 | struct lm_async_cb acb; | ||
80 | |||
81 | memset(&acb, 0, sizeof(acb)); | ||
82 | |||
83 | if (lp->lksb.sb_status == -DLM_ECANCEL) { | ||
84 | log_info("complete dlm cancel %x,%llx flags %lx", | ||
85 | lp->lockname.ln_type, | ||
86 | (unsigned long long)lp->lockname.ln_number, | ||
87 | lp->flags); | ||
88 | |||
89 | lp->req = lp->cur; | ||
90 | acb.lc_ret |= LM_OUT_CANCELED; | ||
91 | if (lp->cur == DLM_LOCK_IV) | ||
92 | lp->lksb.sb_lkid = 0; | ||
93 | goto out; | ||
94 | } | ||
95 | |||
96 | if (test_and_clear_bit(LFL_DLM_UNLOCK, &lp->flags)) { | ||
97 | if (lp->lksb.sb_status != -DLM_EUNLOCK) { | ||
98 | log_info("unlock sb_status %d %x,%llx flags %lx", | ||
99 | lp->lksb.sb_status, lp->lockname.ln_type, | ||
100 | (unsigned long long)lp->lockname.ln_number, | ||
101 | lp->flags); | ||
102 | return; | ||
103 | } | ||
104 | |||
105 | lp->cur = DLM_LOCK_IV; | ||
106 | lp->req = DLM_LOCK_IV; | ||
107 | lp->lksb.sb_lkid = 0; | ||
108 | |||
109 | if (test_and_clear_bit(LFL_UNLOCK_DELETE, &lp->flags)) { | ||
110 | gdlm_delete_lp(lp); | ||
111 | return; | ||
112 | } | ||
113 | goto out; | ||
114 | } | ||
115 | |||
116 | if (lp->lksb.sb_flags & DLM_SBF_VALNOTVALID) | ||
117 | memset(lp->lksb.sb_lvbptr, 0, GDLM_LVB_SIZE); | ||
118 | |||
119 | if (lp->lksb.sb_flags & DLM_SBF_ALTMODE) { | ||
120 | if (lp->req == DLM_LOCK_PR) | ||
121 | lp->req = DLM_LOCK_CW; | ||
122 | else if (lp->req == DLM_LOCK_CW) | ||
123 | lp->req = DLM_LOCK_PR; | ||
124 | } | ||
125 | |||
126 | /* | ||
127 | * A canceled lock request. The lock was just taken off the delayed | ||
128 | * list and was never even submitted to dlm. | ||
129 | */ | ||
130 | |||
131 | if (test_and_clear_bit(LFL_CANCEL, &lp->flags)) { | ||
132 | log_info("complete internal cancel %x,%llx", | ||
133 | lp->lockname.ln_type, | ||
134 | (unsigned long long)lp->lockname.ln_number); | ||
135 | lp->req = lp->cur; | ||
136 | acb.lc_ret |= LM_OUT_CANCELED; | ||
137 | goto out; | ||
138 | } | ||
139 | |||
140 | /* | ||
141 | * An error occured. | ||
142 | */ | ||
143 | |||
144 | if (lp->lksb.sb_status) { | ||
145 | /* a "normal" error */ | ||
146 | if ((lp->lksb.sb_status == -EAGAIN) && | ||
147 | (lp->lkf & DLM_LKF_NOQUEUE)) { | ||
148 | lp->req = lp->cur; | ||
149 | if (lp->cur == DLM_LOCK_IV) | ||
150 | lp->lksb.sb_lkid = 0; | ||
151 | goto out; | ||
152 | } | ||
153 | |||
154 | /* this could only happen with cancels I think */ | ||
155 | log_info("ast sb_status %d %x,%llx flags %lx", | ||
156 | lp->lksb.sb_status, lp->lockname.ln_type, | ||
157 | (unsigned long long)lp->lockname.ln_number, | ||
158 | lp->flags); | ||
159 | return; | ||
160 | } | ||
161 | |||
162 | /* | ||
163 | * This is an AST for an EX->EX conversion for sync_lvb from GFS. | ||
164 | */ | ||
165 | |||
166 | if (test_and_clear_bit(LFL_SYNC_LVB, &lp->flags)) { | ||
167 | wake_up_ast(lp); | ||
168 | return; | ||
169 | } | ||
170 | |||
171 | /* | ||
172 | * A lock has been demoted to NL because it initially completed during | ||
173 | * BLOCK_LOCKS. Now it must be requested in the originally requested | ||
174 | * mode. | ||
175 | */ | ||
176 | |||
177 | if (test_and_clear_bit(LFL_REREQUEST, &lp->flags)) { | ||
178 | gdlm_assert(lp->req == DLM_LOCK_NL, "%x,%llx", | ||
179 | lp->lockname.ln_type, | ||
180 | (unsigned long long)lp->lockname.ln_number); | ||
181 | gdlm_assert(lp->prev_req > DLM_LOCK_NL, "%x,%llx", | ||
182 | lp->lockname.ln_type, | ||
183 | (unsigned long long)lp->lockname.ln_number); | ||
184 | |||
185 | lp->cur = DLM_LOCK_NL; | ||
186 | lp->req = lp->prev_req; | ||
187 | lp->prev_req = DLM_LOCK_IV; | ||
188 | lp->lkf &= ~DLM_LKF_CONVDEADLK; | ||
189 | |||
190 | set_bit(LFL_NOCACHE, &lp->flags); | ||
191 | |||
192 | if (test_bit(DFL_BLOCK_LOCKS, &ls->flags) && | ||
193 | !test_bit(LFL_NOBLOCK, &lp->flags)) | ||
194 | gdlm_queue_delayed(lp); | ||
195 | else | ||
196 | queue_submit(lp); | ||
197 | return; | ||
198 | } | ||
199 | |||
200 | /* | ||
201 | * A request is granted during dlm recovery. It may be granted | ||
202 | * because the locks of a failed node were cleared. In that case, | ||
203 | * there may be inconsistent data beneath this lock and we must wait | ||
204 | * for recovery to complete to use it. When gfs recovery is done this | ||
205 | * granted lock will be converted to NL and then reacquired in this | ||
206 | * granted state. | ||
207 | */ | ||
208 | |||
209 | if (test_bit(DFL_BLOCK_LOCKS, &ls->flags) && | ||
210 | !test_bit(LFL_NOBLOCK, &lp->flags) && | ||
211 | lp->req != DLM_LOCK_NL) { | ||
212 | |||
213 | lp->cur = lp->req; | ||
214 | lp->prev_req = lp->req; | ||
215 | lp->req = DLM_LOCK_NL; | ||
216 | lp->lkf |= DLM_LKF_CONVERT; | ||
217 | lp->lkf &= ~DLM_LKF_CONVDEADLK; | ||
218 | |||
219 | log_debug("rereq %x,%llx id %x %d,%d", | ||
220 | lp->lockname.ln_type, | ||
221 | (unsigned long long)lp->lockname.ln_number, | ||
222 | lp->lksb.sb_lkid, lp->cur, lp->req); | ||
223 | |||
224 | set_bit(LFL_REREQUEST, &lp->flags); | ||
225 | queue_submit(lp); | ||
226 | return; | ||
227 | } | ||
228 | |||
229 | /* | ||
230 | * DLM demoted the lock to NL before it was granted so GFS must be | ||
231 | * told it cannot cache data for this lock. | ||
232 | */ | ||
233 | |||
234 | if (lp->lksb.sb_flags & DLM_SBF_DEMOTED) | ||
235 | set_bit(LFL_NOCACHE, &lp->flags); | ||
236 | |||
237 | out: | ||
238 | /* | ||
239 | * This is an internal lock_dlm lock | ||
240 | */ | ||
241 | |||
242 | if (test_bit(LFL_INLOCK, &lp->flags)) { | ||
243 | clear_bit(LFL_NOBLOCK, &lp->flags); | ||
244 | lp->cur = lp->req; | ||
245 | wake_up_ast(lp); | ||
246 | return; | ||
247 | } | ||
248 | |||
249 | /* | ||
250 | * Normal completion of a lock request. Tell GFS it now has the lock. | ||
251 | */ | ||
252 | |||
253 | clear_bit(LFL_NOBLOCK, &lp->flags); | ||
254 | lp->cur = lp->req; | ||
255 | |||
256 | acb.lc_name = lp->lockname; | ||
257 | acb.lc_ret |= gdlm_make_lmstate(lp->cur); | ||
258 | |||
259 | ls->fscb(ls->sdp, LM_CB_ASYNC, &acb); | ||
260 | } | ||
261 | |||
262 | static void gdlm_ast(void *astarg) | ||
263 | { | ||
264 | struct gdlm_lock *lp = astarg; | ||
265 | clear_bit(LFL_ACTIVE, &lp->flags); | ||
266 | process_complete(lp); | ||
267 | } | ||
268 | |||
269 | static void process_blocking(struct gdlm_lock *lp, int bast_mode) | ||
270 | { | ||
271 | struct gdlm_ls *ls = lp->ls; | ||
272 | unsigned int cb = 0; | ||
273 | |||
274 | switch (gdlm_make_lmstate(bast_mode)) { | ||
275 | case LM_ST_EXCLUSIVE: | ||
276 | cb = LM_CB_NEED_E; | ||
277 | break; | ||
278 | case LM_ST_DEFERRED: | ||
279 | cb = LM_CB_NEED_D; | ||
280 | break; | ||
281 | case LM_ST_SHARED: | ||
282 | cb = LM_CB_NEED_S; | ||
283 | break; | ||
284 | default: | ||
285 | gdlm_assert(0, "unknown bast mode %u", bast_mode); | ||
286 | } | ||
287 | |||
288 | ls->fscb(ls->sdp, cb, &lp->lockname); | ||
289 | } | ||
290 | |||
291 | |||
292 | static void gdlm_bast(void *astarg, int mode) | ||
293 | { | ||
294 | struct gdlm_lock *lp = astarg; | ||
295 | |||
296 | if (!mode) { | ||
297 | printk(KERN_INFO "lock_dlm: bast mode zero %x,%llx\n", | ||
298 | lp->lockname.ln_type, | ||
299 | (unsigned long long)lp->lockname.ln_number); | ||
300 | return; | ||
301 | } | ||
302 | |||
303 | process_blocking(lp, mode); | ||
304 | } | ||
305 | |||
306 | /* convert gfs lock-state to dlm lock-mode */ | ||
307 | |||
308 | static s16 make_mode(s16 lmstate) | ||
309 | { | ||
310 | switch (lmstate) { | ||
311 | case LM_ST_UNLOCKED: | ||
312 | return DLM_LOCK_NL; | ||
313 | case LM_ST_EXCLUSIVE: | ||
314 | return DLM_LOCK_EX; | ||
315 | case LM_ST_DEFERRED: | ||
316 | return DLM_LOCK_CW; | ||
317 | case LM_ST_SHARED: | ||
318 | return DLM_LOCK_PR; | ||
319 | } | ||
320 | gdlm_assert(0, "unknown LM state %d", lmstate); | ||
321 | return -1; | ||
322 | } | ||
323 | |||
324 | |||
325 | /* verify agreement with GFS on the current lock state, NB: DLM_LOCK_NL and | ||
326 | DLM_LOCK_IV are both considered LM_ST_UNLOCKED by GFS. */ | ||
327 | |||
328 | static void check_cur_state(struct gdlm_lock *lp, unsigned int cur_state) | ||
329 | { | ||
330 | s16 cur = make_mode(cur_state); | ||
331 | if (lp->cur != DLM_LOCK_IV) | ||
332 | gdlm_assert(lp->cur == cur, "%d, %d", lp->cur, cur); | ||
333 | } | ||
334 | |||
335 | static inline unsigned int make_flags(struct gdlm_lock *lp, | ||
336 | unsigned int gfs_flags, | ||
337 | s16 cur, s16 req) | ||
338 | { | ||
339 | unsigned int lkf = 0; | ||
340 | |||
341 | if (gfs_flags & LM_FLAG_TRY) | ||
342 | lkf |= DLM_LKF_NOQUEUE; | ||
343 | |||
344 | if (gfs_flags & LM_FLAG_TRY_1CB) { | ||
345 | lkf |= DLM_LKF_NOQUEUE; | ||
346 | lkf |= DLM_LKF_NOQUEUEBAST; | ||
347 | } | ||
348 | |||
349 | if (gfs_flags & LM_FLAG_PRIORITY) { | ||
350 | lkf |= DLM_LKF_NOORDER; | ||
351 | lkf |= DLM_LKF_HEADQUE; | ||
352 | } | ||
353 | |||
354 | if (gfs_flags & LM_FLAG_ANY) { | ||
355 | if (req == DLM_LOCK_PR) | ||
356 | lkf |= DLM_LKF_ALTCW; | ||
357 | else if (req == DLM_LOCK_CW) | ||
358 | lkf |= DLM_LKF_ALTPR; | ||
359 | } | ||
360 | |||
361 | if (lp->lksb.sb_lkid != 0) { | ||
362 | lkf |= DLM_LKF_CONVERT; | ||
363 | } | ||
364 | |||
365 | if (lp->lvb) | ||
366 | lkf |= DLM_LKF_VALBLK; | ||
367 | |||
368 | return lkf; | ||
369 | } | ||
370 | |||
371 | /* make_strname - convert GFS lock numbers to a string */ | ||
372 | |||
373 | static inline void make_strname(const struct lm_lockname *lockname, | ||
374 | struct gdlm_strname *str) | ||
375 | { | ||
376 | sprintf(str->name, "%8x%16llx", lockname->ln_type, | ||
377 | (unsigned long long)lockname->ln_number); | ||
378 | str->namelen = GDLM_STRNAME_BYTES; | ||
379 | } | ||
380 | |||
381 | static int gdlm_create_lp(struct gdlm_ls *ls, struct lm_lockname *name, | ||
382 | struct gdlm_lock **lpp) | ||
383 | { | ||
384 | struct gdlm_lock *lp; | ||
385 | |||
386 | lp = kzalloc(sizeof(struct gdlm_lock), GFP_NOFS); | ||
387 | if (!lp) | ||
388 | return -ENOMEM; | ||
389 | |||
390 | lp->lockname = *name; | ||
391 | make_strname(name, &lp->strname); | ||
392 | lp->ls = ls; | ||
393 | lp->cur = DLM_LOCK_IV; | ||
394 | INIT_LIST_HEAD(&lp->delay_list); | ||
395 | |||
396 | spin_lock(&ls->async_lock); | ||
397 | ls->all_locks_count++; | ||
398 | spin_unlock(&ls->async_lock); | ||
399 | |||
400 | *lpp = lp; | ||
401 | return 0; | ||
402 | } | ||
403 | |||
404 | int gdlm_get_lock(void *lockspace, struct lm_lockname *name, | ||
405 | void **lockp) | ||
406 | { | ||
407 | struct gdlm_lock *lp; | ||
408 | int error; | ||
409 | |||
410 | error = gdlm_create_lp(lockspace, name, &lp); | ||
411 | |||
412 | *lockp = lp; | ||
413 | return error; | ||
414 | } | ||
415 | |||
416 | void gdlm_put_lock(void *lock) | ||
417 | { | ||
418 | gdlm_delete_lp(lock); | ||
419 | } | ||
420 | |||
421 | unsigned int gdlm_do_lock(struct gdlm_lock *lp) | ||
422 | { | ||
423 | struct gdlm_ls *ls = lp->ls; | ||
424 | int error, bast = 1; | ||
425 | |||
426 | /* | ||
427 | * When recovery is in progress, delay lock requests for submission | ||
428 | * once recovery is done. Requests for recovery (NOEXP) and unlocks | ||
429 | * can pass. | ||
430 | */ | ||
431 | |||
432 | if (test_bit(DFL_BLOCK_LOCKS, &ls->flags) && | ||
433 | !test_bit(LFL_NOBLOCK, &lp->flags) && lp->req != DLM_LOCK_NL) { | ||
434 | gdlm_queue_delayed(lp); | ||
435 | return LM_OUT_ASYNC; | ||
436 | } | ||
437 | |||
438 | /* | ||
439 | * Submit the actual lock request. | ||
440 | */ | ||
441 | |||
442 | if (test_bit(LFL_NOBAST, &lp->flags)) | ||
443 | bast = 0; | ||
444 | |||
445 | set_bit(LFL_ACTIVE, &lp->flags); | ||
446 | |||
447 | log_debug("lk %x,%llx id %x %d,%d %x", lp->lockname.ln_type, | ||
448 | (unsigned long long)lp->lockname.ln_number, lp->lksb.sb_lkid, | ||
449 | lp->cur, lp->req, lp->lkf); | ||
450 | |||
451 | error = dlm_lock(ls->dlm_lockspace, lp->req, &lp->lksb, lp->lkf, | ||
452 | lp->strname.name, lp->strname.namelen, 0, gdlm_ast, | ||
453 | lp, bast ? gdlm_bast : NULL); | ||
454 | |||
455 | if ((error == -EAGAIN) && (lp->lkf & DLM_LKF_NOQUEUE)) { | ||
456 | lp->lksb.sb_status = -EAGAIN; | ||
457 | gdlm_ast(lp); | ||
458 | error = 0; | ||
459 | } | ||
460 | |||
461 | if (error) { | ||
462 | log_error("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x " | ||
463 | "flags=%lx", ls->fsname, lp->lockname.ln_type, | ||
464 | (unsigned long long)lp->lockname.ln_number, error, | ||
465 | lp->cur, lp->req, lp->lkf, lp->flags); | ||
466 | return LM_OUT_ERROR; | ||
467 | } | ||
468 | return LM_OUT_ASYNC; | ||
469 | } | ||
470 | |||
471 | static unsigned int gdlm_do_unlock(struct gdlm_lock *lp) | ||
472 | { | ||
473 | struct gdlm_ls *ls = lp->ls; | ||
474 | unsigned int lkf = 0; | ||
475 | int error; | ||
476 | |||
477 | set_bit(LFL_DLM_UNLOCK, &lp->flags); | ||
478 | set_bit(LFL_ACTIVE, &lp->flags); | ||
479 | |||
480 | if (lp->lvb) | ||
481 | lkf = DLM_LKF_VALBLK; | ||
482 | |||
483 | log_debug("un %x,%llx %x %d %x", lp->lockname.ln_type, | ||
484 | (unsigned long long)lp->lockname.ln_number, | ||
485 | lp->lksb.sb_lkid, lp->cur, lkf); | ||
486 | |||
487 | error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, lkf, NULL, lp); | ||
488 | |||
489 | if (error) { | ||
490 | log_error("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x " | ||
491 | "flags=%lx", ls->fsname, lp->lockname.ln_type, | ||
492 | (unsigned long long)lp->lockname.ln_number, error, | ||
493 | lp->cur, lp->req, lp->lkf, lp->flags); | ||
494 | return LM_OUT_ERROR; | ||
495 | } | ||
496 | return LM_OUT_ASYNC; | ||
497 | } | ||
498 | |||
499 | unsigned int gdlm_lock(void *lock, unsigned int cur_state, | ||
500 | unsigned int req_state, unsigned int flags) | ||
501 | { | ||
502 | struct gdlm_lock *lp = lock; | ||
503 | |||
504 | if (req_state == LM_ST_UNLOCKED) | ||
505 | return gdlm_unlock(lock, cur_state); | ||
506 | |||
507 | if (req_state == LM_ST_UNLOCKED) | ||
508 | return gdlm_unlock(lock, cur_state); | ||
509 | |||
510 | clear_bit(LFL_DLM_CANCEL, &lp->flags); | ||
511 | if (flags & LM_FLAG_NOEXP) | ||
512 | set_bit(LFL_NOBLOCK, &lp->flags); | ||
513 | |||
514 | check_cur_state(lp, cur_state); | ||
515 | lp->req = make_mode(req_state); | ||
516 | lp->lkf = make_flags(lp, flags, lp->cur, lp->req); | ||
517 | |||
518 | return gdlm_do_lock(lp); | ||
519 | } | ||
520 | |||
521 | unsigned int gdlm_unlock(void *lock, unsigned int cur_state) | ||
522 | { | ||
523 | struct gdlm_lock *lp = lock; | ||
524 | |||
525 | clear_bit(LFL_DLM_CANCEL, &lp->flags); | ||
526 | if (lp->cur == DLM_LOCK_IV) | ||
527 | return 0; | ||
528 | return gdlm_do_unlock(lp); | ||
529 | } | ||
530 | |||
531 | void gdlm_cancel(void *lock) | ||
532 | { | ||
533 | struct gdlm_lock *lp = lock; | ||
534 | struct gdlm_ls *ls = lp->ls; | ||
535 | int error, delay_list = 0; | ||
536 | |||
537 | if (test_bit(LFL_DLM_CANCEL, &lp->flags)) | ||
538 | return; | ||
539 | |||
540 | log_info("gdlm_cancel %x,%llx flags %lx", lp->lockname.ln_type, | ||
541 | (unsigned long long)lp->lockname.ln_number, lp->flags); | ||
542 | |||
543 | spin_lock(&ls->async_lock); | ||
544 | if (!list_empty(&lp->delay_list)) { | ||
545 | list_del_init(&lp->delay_list); | ||
546 | delay_list = 1; | ||
547 | } | ||
548 | spin_unlock(&ls->async_lock); | ||
549 | |||
550 | if (delay_list) { | ||
551 | set_bit(LFL_CANCEL, &lp->flags); | ||
552 | set_bit(LFL_ACTIVE, &lp->flags); | ||
553 | gdlm_ast(lp); | ||
554 | return; | ||
555 | } | ||
556 | |||
557 | if (!test_bit(LFL_ACTIVE, &lp->flags) || | ||
558 | test_bit(LFL_DLM_UNLOCK, &lp->flags)) { | ||
559 | log_info("gdlm_cancel skip %x,%llx flags %lx", | ||
560 | lp->lockname.ln_type, | ||
561 | (unsigned long long)lp->lockname.ln_number, lp->flags); | ||
562 | return; | ||
563 | } | ||
564 | |||
565 | /* the lock is blocked in the dlm */ | ||
566 | |||
567 | set_bit(LFL_DLM_CANCEL, &lp->flags); | ||
568 | set_bit(LFL_ACTIVE, &lp->flags); | ||
569 | |||
570 | error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, DLM_LKF_CANCEL, | ||
571 | NULL, lp); | ||
572 | |||
573 | log_info("gdlm_cancel rv %d %x,%llx flags %lx", error, | ||
574 | lp->lockname.ln_type, | ||
575 | (unsigned long long)lp->lockname.ln_number, lp->flags); | ||
576 | |||
577 | if (error == -EBUSY) | ||
578 | clear_bit(LFL_DLM_CANCEL, &lp->flags); | ||
579 | } | ||
580 | |||
581 | static int gdlm_add_lvb(struct gdlm_lock *lp) | ||
582 | { | ||
583 | char *lvb; | ||
584 | |||
585 | lvb = kzalloc(GDLM_LVB_SIZE, GFP_NOFS); | ||
586 | if (!lvb) | ||
587 | return -ENOMEM; | ||
588 | |||
589 | lp->lksb.sb_lvbptr = lvb; | ||
590 | lp->lvb = lvb; | ||
591 | return 0; | ||
592 | } | ||
593 | |||
594 | static void gdlm_del_lvb(struct gdlm_lock *lp) | ||
595 | { | ||
596 | kfree(lp->lvb); | ||
597 | lp->lvb = NULL; | ||
598 | lp->lksb.sb_lvbptr = NULL; | ||
599 | } | ||
600 | |||
601 | static int gdlm_ast_wait(void *word) | ||
602 | { | ||
603 | schedule(); | ||
604 | return 0; | ||
605 | } | ||
606 | |||
607 | /* This can do a synchronous dlm request (requiring a lock_dlm thread to get | ||
608 | the completion) because gfs won't call hold_lvb() during a callback (from | ||
609 | the context of a lock_dlm thread). */ | ||
610 | |||
611 | static int hold_null_lock(struct gdlm_lock *lp) | ||
612 | { | ||
613 | struct gdlm_lock *lpn = NULL; | ||
614 | int error; | ||
615 | |||
616 | if (lp->hold_null) { | ||
617 | printk(KERN_INFO "lock_dlm: lvb already held\n"); | ||
618 | return 0; | ||
619 | } | ||
620 | |||
621 | error = gdlm_create_lp(lp->ls, &lp->lockname, &lpn); | ||
622 | if (error) | ||
623 | goto out; | ||
624 | |||
625 | lpn->lksb.sb_lvbptr = junk_lvb; | ||
626 | lpn->lvb = junk_lvb; | ||
627 | |||
628 | lpn->req = DLM_LOCK_NL; | ||
629 | lpn->lkf = DLM_LKF_VALBLK | DLM_LKF_EXPEDITE; | ||
630 | set_bit(LFL_NOBAST, &lpn->flags); | ||
631 | set_bit(LFL_INLOCK, &lpn->flags); | ||
632 | set_bit(LFL_AST_WAIT, &lpn->flags); | ||
633 | |||
634 | gdlm_do_lock(lpn); | ||
635 | wait_on_bit(&lpn->flags, LFL_AST_WAIT, gdlm_ast_wait, TASK_UNINTERRUPTIBLE); | ||
636 | error = lpn->lksb.sb_status; | ||
637 | if (error) { | ||
638 | printk(KERN_INFO "lock_dlm: hold_null_lock dlm error %d\n", | ||
639 | error); | ||
640 | gdlm_delete_lp(lpn); | ||
641 | lpn = NULL; | ||
642 | } | ||
643 | out: | ||
644 | lp->hold_null = lpn; | ||
645 | return error; | ||
646 | } | ||
647 | |||
648 | /* This cannot do a synchronous dlm request (requiring a lock_dlm thread to get | ||
649 | the completion) because gfs may call unhold_lvb() during a callback (from | ||
650 | the context of a lock_dlm thread) which could cause a deadlock since the | ||
651 | other lock_dlm thread could be engaged in recovery. */ | ||
652 | |||
653 | static void unhold_null_lock(struct gdlm_lock *lp) | ||
654 | { | ||
655 | struct gdlm_lock *lpn = lp->hold_null; | ||
656 | |||
657 | gdlm_assert(lpn, "%x,%llx", lp->lockname.ln_type, | ||
658 | (unsigned long long)lp->lockname.ln_number); | ||
659 | lpn->lksb.sb_lvbptr = NULL; | ||
660 | lpn->lvb = NULL; | ||
661 | set_bit(LFL_UNLOCK_DELETE, &lpn->flags); | ||
662 | gdlm_do_unlock(lpn); | ||
663 | lp->hold_null = NULL; | ||
664 | } | ||
665 | |||
666 | /* Acquire a NL lock because gfs requires the value block to remain | ||
667 | intact on the resource while the lvb is "held" even if it's holding no locks | ||
668 | on the resource. */ | ||
669 | |||
670 | int gdlm_hold_lvb(void *lock, char **lvbp) | ||
671 | { | ||
672 | struct gdlm_lock *lp = lock; | ||
673 | int error; | ||
674 | |||
675 | error = gdlm_add_lvb(lp); | ||
676 | if (error) | ||
677 | return error; | ||
678 | |||
679 | *lvbp = lp->lvb; | ||
680 | |||
681 | error = hold_null_lock(lp); | ||
682 | if (error) | ||
683 | gdlm_del_lvb(lp); | ||
684 | |||
685 | return error; | ||
686 | } | ||
687 | |||
688 | void gdlm_unhold_lvb(void *lock, char *lvb) | ||
689 | { | ||
690 | struct gdlm_lock *lp = lock; | ||
691 | |||
692 | unhold_null_lock(lp); | ||
693 | gdlm_del_lvb(lp); | ||
694 | } | ||
695 | |||
696 | void gdlm_submit_delayed(struct gdlm_ls *ls) | ||
697 | { | ||
698 | struct gdlm_lock *lp, *safe; | ||
699 | |||
700 | spin_lock(&ls->async_lock); | ||
701 | list_for_each_entry_safe(lp, safe, &ls->delayed, delay_list) { | ||
702 | list_del_init(&lp->delay_list); | ||
703 | list_add_tail(&lp->delay_list, &ls->submit); | ||
704 | } | ||
705 | spin_unlock(&ls->async_lock); | ||
706 | wake_up(&ls->thread_wait); | ||
707 | } | ||
708 | |||
diff --git a/fs/gfs2/locking/dlm/lock_dlm.h b/fs/gfs2/locking/dlm/lock_dlm.h deleted file mode 100644 index 3c98e7c6f93b..000000000000 --- a/fs/gfs2/locking/dlm/lock_dlm.h +++ /dev/null | |||
@@ -1,166 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #ifndef LOCK_DLM_DOT_H | ||
11 | #define LOCK_DLM_DOT_H | ||
12 | |||
13 | #include <linux/module.h> | ||
14 | #include <linux/slab.h> | ||
15 | #include <linux/spinlock.h> | ||
16 | #include <linux/types.h> | ||
17 | #include <linux/string.h> | ||
18 | #include <linux/list.h> | ||
19 | #include <linux/socket.h> | ||
20 | #include <linux/delay.h> | ||
21 | #include <linux/kthread.h> | ||
22 | #include <linux/kobject.h> | ||
23 | #include <linux/fcntl.h> | ||
24 | #include <linux/wait.h> | ||
25 | #include <net/sock.h> | ||
26 | |||
27 | #include <linux/dlm.h> | ||
28 | #include <linux/dlm_plock.h> | ||
29 | #include <linux/lm_interface.h> | ||
30 | |||
31 | /* | ||
32 | * Internally, we prefix things with gdlm_ and GDLM_ (for gfs-dlm) since a | ||
33 | * prefix of lock_dlm_ gets awkward. Externally, GFS refers to this module | ||
34 | * as "lock_dlm". | ||
35 | */ | ||
36 | |||
37 | #define GDLM_STRNAME_BYTES 24 | ||
38 | #define GDLM_LVB_SIZE 32 | ||
39 | #define GDLM_DROP_COUNT 0 | ||
40 | #define GDLM_DROP_PERIOD 60 | ||
41 | #define GDLM_NAME_LEN 128 | ||
42 | |||
43 | /* GFS uses 12 bytes to identify a resource (32 bit type + 64 bit number). | ||
44 | We sprintf these numbers into a 24 byte string of hex values to make them | ||
45 | human-readable (to make debugging simpler.) */ | ||
46 | |||
47 | struct gdlm_strname { | ||
48 | unsigned char name[GDLM_STRNAME_BYTES]; | ||
49 | unsigned short namelen; | ||
50 | }; | ||
51 | |||
52 | enum { | ||
53 | DFL_BLOCK_LOCKS = 0, | ||
54 | DFL_SPECTATOR = 1, | ||
55 | DFL_WITHDRAW = 2, | ||
56 | }; | ||
57 | |||
58 | struct gdlm_ls { | ||
59 | u32 id; | ||
60 | int jid; | ||
61 | int first; | ||
62 | int first_done; | ||
63 | unsigned long flags; | ||
64 | struct kobject kobj; | ||
65 | char clustername[GDLM_NAME_LEN]; | ||
66 | char fsname[GDLM_NAME_LEN]; | ||
67 | int fsflags; | ||
68 | dlm_lockspace_t *dlm_lockspace; | ||
69 | lm_callback_t fscb; | ||
70 | struct gfs2_sbd *sdp; | ||
71 | int recover_jid; | ||
72 | int recover_jid_done; | ||
73 | int recover_jid_status; | ||
74 | spinlock_t async_lock; | ||
75 | struct list_head delayed; | ||
76 | struct list_head submit; | ||
77 | u32 all_locks_count; | ||
78 | wait_queue_head_t wait_control; | ||
79 | struct task_struct *thread; | ||
80 | wait_queue_head_t thread_wait; | ||
81 | }; | ||
82 | |||
83 | enum { | ||
84 | LFL_NOBLOCK = 0, | ||
85 | LFL_NOCACHE = 1, | ||
86 | LFL_DLM_UNLOCK = 2, | ||
87 | LFL_DLM_CANCEL = 3, | ||
88 | LFL_SYNC_LVB = 4, | ||
89 | LFL_FORCE_PROMOTE = 5, | ||
90 | LFL_REREQUEST = 6, | ||
91 | LFL_ACTIVE = 7, | ||
92 | LFL_INLOCK = 8, | ||
93 | LFL_CANCEL = 9, | ||
94 | LFL_NOBAST = 10, | ||
95 | LFL_HEADQUE = 11, | ||
96 | LFL_UNLOCK_DELETE = 12, | ||
97 | LFL_AST_WAIT = 13, | ||
98 | }; | ||
99 | |||
100 | struct gdlm_lock { | ||
101 | struct gdlm_ls *ls; | ||
102 | struct lm_lockname lockname; | ||
103 | struct gdlm_strname strname; | ||
104 | char *lvb; | ||
105 | struct dlm_lksb lksb; | ||
106 | |||
107 | s16 cur; | ||
108 | s16 req; | ||
109 | s16 prev_req; | ||
110 | u32 lkf; /* dlm flags DLM_LKF_ */ | ||
111 | unsigned long flags; /* lock_dlm flags LFL_ */ | ||
112 | |||
113 | struct list_head delay_list; /* delayed */ | ||
114 | struct gdlm_lock *hold_null; /* NL lock for hold_lvb */ | ||
115 | }; | ||
116 | |||
117 | #define gdlm_assert(assertion, fmt, args...) \ | ||
118 | do { \ | ||
119 | if (unlikely(!(assertion))) { \ | ||
120 | printk(KERN_EMERG "lock_dlm: fatal assertion failed \"%s\"\n" \ | ||
121 | "lock_dlm: " fmt "\n", \ | ||
122 | #assertion, ##args); \ | ||
123 | BUG(); \ | ||
124 | } \ | ||
125 | } while (0) | ||
126 | |||
127 | #define log_print(lev, fmt, arg...) printk(lev "lock_dlm: " fmt "\n" , ## arg) | ||
128 | #define log_info(fmt, arg...) log_print(KERN_INFO , fmt , ## arg) | ||
129 | #define log_error(fmt, arg...) log_print(KERN_ERR , fmt , ## arg) | ||
130 | #ifdef LOCK_DLM_LOG_DEBUG | ||
131 | #define log_debug(fmt, arg...) log_print(KERN_DEBUG , fmt , ## arg) | ||
132 | #else | ||
133 | #define log_debug(fmt, arg...) | ||
134 | #endif | ||
135 | |||
136 | /* sysfs.c */ | ||
137 | |||
138 | int gdlm_sysfs_init(void); | ||
139 | void gdlm_sysfs_exit(void); | ||
140 | int gdlm_kobject_setup(struct gdlm_ls *, struct kobject *); | ||
141 | void gdlm_kobject_release(struct gdlm_ls *); | ||
142 | |||
143 | /* thread.c */ | ||
144 | |||
145 | int gdlm_init_threads(struct gdlm_ls *); | ||
146 | void gdlm_release_threads(struct gdlm_ls *); | ||
147 | |||
148 | /* lock.c */ | ||
149 | |||
150 | void gdlm_submit_delayed(struct gdlm_ls *); | ||
151 | unsigned int gdlm_do_lock(struct gdlm_lock *); | ||
152 | |||
153 | int gdlm_get_lock(void *, struct lm_lockname *, void **); | ||
154 | void gdlm_put_lock(void *); | ||
155 | unsigned int gdlm_lock(void *, unsigned int, unsigned int, unsigned int); | ||
156 | unsigned int gdlm_unlock(void *, unsigned int); | ||
157 | void gdlm_cancel(void *); | ||
158 | int gdlm_hold_lvb(void *, char **); | ||
159 | void gdlm_unhold_lvb(void *, char *); | ||
160 | |||
161 | /* mount.c */ | ||
162 | |||
163 | extern const struct lm_lockops gdlm_ops; | ||
164 | |||
165 | #endif | ||
166 | |||
diff --git a/fs/gfs2/locking/dlm/main.c b/fs/gfs2/locking/dlm/main.c deleted file mode 100644 index b9a03a7ff801..000000000000 --- a/fs/gfs2/locking/dlm/main.c +++ /dev/null | |||
@@ -1,48 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include <linux/init.h> | ||
11 | |||
12 | #include "lock_dlm.h" | ||
13 | |||
14 | static int __init init_lock_dlm(void) | ||
15 | { | ||
16 | int error; | ||
17 | |||
18 | error = gfs2_register_lockproto(&gdlm_ops); | ||
19 | if (error) { | ||
20 | printk(KERN_WARNING "lock_dlm: can't register protocol: %d\n", | ||
21 | error); | ||
22 | return error; | ||
23 | } | ||
24 | |||
25 | error = gdlm_sysfs_init(); | ||
26 | if (error) { | ||
27 | gfs2_unregister_lockproto(&gdlm_ops); | ||
28 | return error; | ||
29 | } | ||
30 | |||
31 | printk(KERN_INFO | ||
32 | "Lock_DLM (built %s %s) installed\n", __DATE__, __TIME__); | ||
33 | return 0; | ||
34 | } | ||
35 | |||
36 | static void __exit exit_lock_dlm(void) | ||
37 | { | ||
38 | gdlm_sysfs_exit(); | ||
39 | gfs2_unregister_lockproto(&gdlm_ops); | ||
40 | } | ||
41 | |||
42 | module_init(init_lock_dlm); | ||
43 | module_exit(exit_lock_dlm); | ||
44 | |||
45 | MODULE_DESCRIPTION("GFS DLM Locking Module"); | ||
46 | MODULE_AUTHOR("Red Hat, Inc."); | ||
47 | MODULE_LICENSE("GPL"); | ||
48 | |||
diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c deleted file mode 100644 index 1aa7eb6a0226..000000000000 --- a/fs/gfs2/locking/dlm/mount.c +++ /dev/null | |||
@@ -1,276 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include "lock_dlm.h" | ||
11 | |||
12 | const struct lm_lockops gdlm_ops; | ||
13 | |||
14 | |||
15 | static struct gdlm_ls *init_gdlm(lm_callback_t cb, struct gfs2_sbd *sdp, | ||
16 | int flags, char *table_name) | ||
17 | { | ||
18 | struct gdlm_ls *ls; | ||
19 | char buf[256], *p; | ||
20 | |||
21 | ls = kzalloc(sizeof(struct gdlm_ls), GFP_KERNEL); | ||
22 | if (!ls) | ||
23 | return NULL; | ||
24 | |||
25 | ls->fscb = cb; | ||
26 | ls->sdp = sdp; | ||
27 | ls->fsflags = flags; | ||
28 | spin_lock_init(&ls->async_lock); | ||
29 | INIT_LIST_HEAD(&ls->delayed); | ||
30 | INIT_LIST_HEAD(&ls->submit); | ||
31 | init_waitqueue_head(&ls->thread_wait); | ||
32 | init_waitqueue_head(&ls->wait_control); | ||
33 | ls->jid = -1; | ||
34 | |||
35 | strncpy(buf, table_name, 256); | ||
36 | buf[255] = '\0'; | ||
37 | |||
38 | p = strchr(buf, ':'); | ||
39 | if (!p) { | ||
40 | log_info("invalid table_name \"%s\"", table_name); | ||
41 | kfree(ls); | ||
42 | return NULL; | ||
43 | } | ||
44 | *p = '\0'; | ||
45 | p++; | ||
46 | |||
47 | strncpy(ls->clustername, buf, GDLM_NAME_LEN); | ||
48 | strncpy(ls->fsname, p, GDLM_NAME_LEN); | ||
49 | |||
50 | return ls; | ||
51 | } | ||
52 | |||
53 | static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir) | ||
54 | { | ||
55 | char data[256]; | ||
56 | char *options, *x, *y; | ||
57 | int error = 0; | ||
58 | |||
59 | memset(data, 0, 256); | ||
60 | strncpy(data, data_arg, 255); | ||
61 | |||
62 | if (!strlen(data)) { | ||
63 | log_error("no mount options, (u)mount helpers not installed"); | ||
64 | return -EINVAL; | ||
65 | } | ||
66 | |||
67 | for (options = data; (x = strsep(&options, ":")); ) { | ||
68 | if (!*x) | ||
69 | continue; | ||
70 | |||
71 | y = strchr(x, '='); | ||
72 | if (y) | ||
73 | *y++ = 0; | ||
74 | |||
75 | if (!strcmp(x, "jid")) { | ||
76 | if (!y) { | ||
77 | log_error("need argument to jid"); | ||
78 | error = -EINVAL; | ||
79 | break; | ||
80 | } | ||
81 | sscanf(y, "%u", &ls->jid); | ||
82 | |||
83 | } else if (!strcmp(x, "first")) { | ||
84 | if (!y) { | ||
85 | log_error("need argument to first"); | ||
86 | error = -EINVAL; | ||
87 | break; | ||
88 | } | ||
89 | sscanf(y, "%u", &ls->first); | ||
90 | |||
91 | } else if (!strcmp(x, "id")) { | ||
92 | if (!y) { | ||
93 | log_error("need argument to id"); | ||
94 | error = -EINVAL; | ||
95 | break; | ||
96 | } | ||
97 | sscanf(y, "%u", &ls->id); | ||
98 | |||
99 | } else if (!strcmp(x, "nodir")) { | ||
100 | if (!y) { | ||
101 | log_error("need argument to nodir"); | ||
102 | error = -EINVAL; | ||
103 | break; | ||
104 | } | ||
105 | sscanf(y, "%u", nodir); | ||
106 | |||
107 | } else { | ||
108 | log_error("unkonwn option: %s", x); | ||
109 | error = -EINVAL; | ||
110 | break; | ||
111 | } | ||
112 | } | ||
113 | |||
114 | return error; | ||
115 | } | ||
116 | |||
117 | static int gdlm_mount(char *table_name, char *host_data, | ||
118 | lm_callback_t cb, void *cb_data, | ||
119 | unsigned int min_lvb_size, int flags, | ||
120 | struct lm_lockstruct *lockstruct, | ||
121 | struct kobject *fskobj) | ||
122 | { | ||
123 | struct gdlm_ls *ls; | ||
124 | int error = -ENOMEM, nodir = 0; | ||
125 | |||
126 | if (min_lvb_size > GDLM_LVB_SIZE) | ||
127 | goto out; | ||
128 | |||
129 | ls = init_gdlm(cb, cb_data, flags, table_name); | ||
130 | if (!ls) | ||
131 | goto out; | ||
132 | |||
133 | error = make_args(ls, host_data, &nodir); | ||
134 | if (error) | ||
135 | goto out; | ||
136 | |||
137 | error = gdlm_init_threads(ls); | ||
138 | if (error) | ||
139 | goto out_free; | ||
140 | |||
141 | error = gdlm_kobject_setup(ls, fskobj); | ||
142 | if (error) | ||
143 | goto out_thread; | ||
144 | |||
145 | error = dlm_new_lockspace(ls->fsname, strlen(ls->fsname), | ||
146 | &ls->dlm_lockspace, | ||
147 | DLM_LSFL_FS | DLM_LSFL_NEWEXCL | | ||
148 | (nodir ? DLM_LSFL_NODIR : 0), | ||
149 | GDLM_LVB_SIZE); | ||
150 | if (error) { | ||
151 | log_error("dlm_new_lockspace error %d", error); | ||
152 | goto out_kobj; | ||
153 | } | ||
154 | |||
155 | lockstruct->ls_jid = ls->jid; | ||
156 | lockstruct->ls_first = ls->first; | ||
157 | lockstruct->ls_lockspace = ls; | ||
158 | lockstruct->ls_ops = &gdlm_ops; | ||
159 | lockstruct->ls_flags = 0; | ||
160 | lockstruct->ls_lvb_size = GDLM_LVB_SIZE; | ||
161 | return 0; | ||
162 | |||
163 | out_kobj: | ||
164 | gdlm_kobject_release(ls); | ||
165 | out_thread: | ||
166 | gdlm_release_threads(ls); | ||
167 | out_free: | ||
168 | kfree(ls); | ||
169 | out: | ||
170 | return error; | ||
171 | } | ||
172 | |||
173 | static void gdlm_unmount(void *lockspace) | ||
174 | { | ||
175 | struct gdlm_ls *ls = lockspace; | ||
176 | |||
177 | log_debug("unmount flags %lx", ls->flags); | ||
178 | |||
179 | /* FIXME: serialize unmount and withdraw in case they | ||
180 | happen at once. Also, if unmount follows withdraw, | ||
181 | wait for withdraw to finish. */ | ||
182 | |||
183 | if (test_bit(DFL_WITHDRAW, &ls->flags)) | ||
184 | goto out; | ||
185 | |||
186 | gdlm_kobject_release(ls); | ||
187 | dlm_release_lockspace(ls->dlm_lockspace, 2); | ||
188 | gdlm_release_threads(ls); | ||
189 | BUG_ON(ls->all_locks_count); | ||
190 | out: | ||
191 | kfree(ls); | ||
192 | } | ||
193 | |||
194 | static void gdlm_recovery_done(void *lockspace, unsigned int jid, | ||
195 | unsigned int message) | ||
196 | { | ||
197 | char env_jid[20]; | ||
198 | char env_status[20]; | ||
199 | char *envp[] = { env_jid, env_status, NULL }; | ||
200 | struct gdlm_ls *ls = lockspace; | ||
201 | ls->recover_jid_done = jid; | ||
202 | ls->recover_jid_status = message; | ||
203 | sprintf(env_jid, "JID=%d", jid); | ||
204 | sprintf(env_status, "RECOVERY=%s", | ||
205 | message == LM_RD_SUCCESS ? "Done" : "Failed"); | ||
206 | kobject_uevent_env(&ls->kobj, KOBJ_CHANGE, envp); | ||
207 | } | ||
208 | |||
209 | static void gdlm_others_may_mount(void *lockspace) | ||
210 | { | ||
211 | char *message = "FIRSTMOUNT=Done"; | ||
212 | char *envp[] = { message, NULL }; | ||
213 | struct gdlm_ls *ls = lockspace; | ||
214 | ls->first_done = 1; | ||
215 | kobject_uevent_env(&ls->kobj, KOBJ_CHANGE, envp); | ||
216 | } | ||
217 | |||
218 | /* Userspace gets the offline uevent, blocks new gfs locks on | ||
219 | other mounters, and lets us know (sets WITHDRAW flag). Then, | ||
220 | userspace leaves the mount group while we leave the lockspace. */ | ||
221 | |||
222 | static void gdlm_withdraw(void *lockspace) | ||
223 | { | ||
224 | struct gdlm_ls *ls = lockspace; | ||
225 | |||
226 | kobject_uevent(&ls->kobj, KOBJ_OFFLINE); | ||
227 | |||
228 | wait_event_interruptible(ls->wait_control, | ||
229 | test_bit(DFL_WITHDRAW, &ls->flags)); | ||
230 | |||
231 | dlm_release_lockspace(ls->dlm_lockspace, 2); | ||
232 | gdlm_release_threads(ls); | ||
233 | gdlm_kobject_release(ls); | ||
234 | } | ||
235 | |||
236 | static int gdlm_plock(void *lockspace, struct lm_lockname *name, | ||
237 | struct file *file, int cmd, struct file_lock *fl) | ||
238 | { | ||
239 | struct gdlm_ls *ls = lockspace; | ||
240 | return dlm_posix_lock(ls->dlm_lockspace, name->ln_number, file, cmd, fl); | ||
241 | } | ||
242 | |||
243 | static int gdlm_punlock(void *lockspace, struct lm_lockname *name, | ||
244 | struct file *file, struct file_lock *fl) | ||
245 | { | ||
246 | struct gdlm_ls *ls = lockspace; | ||
247 | return dlm_posix_unlock(ls->dlm_lockspace, name->ln_number, file, fl); | ||
248 | } | ||
249 | |||
250 | static int gdlm_plock_get(void *lockspace, struct lm_lockname *name, | ||
251 | struct file *file, struct file_lock *fl) | ||
252 | { | ||
253 | struct gdlm_ls *ls = lockspace; | ||
254 | return dlm_posix_get(ls->dlm_lockspace, name->ln_number, file, fl); | ||
255 | } | ||
256 | |||
257 | const struct lm_lockops gdlm_ops = { | ||
258 | .lm_proto_name = "lock_dlm", | ||
259 | .lm_mount = gdlm_mount, | ||
260 | .lm_others_may_mount = gdlm_others_may_mount, | ||
261 | .lm_unmount = gdlm_unmount, | ||
262 | .lm_withdraw = gdlm_withdraw, | ||
263 | .lm_get_lock = gdlm_get_lock, | ||
264 | .lm_put_lock = gdlm_put_lock, | ||
265 | .lm_lock = gdlm_lock, | ||
266 | .lm_unlock = gdlm_unlock, | ||
267 | .lm_plock = gdlm_plock, | ||
268 | .lm_punlock = gdlm_punlock, | ||
269 | .lm_plock_get = gdlm_plock_get, | ||
270 | .lm_cancel = gdlm_cancel, | ||
271 | .lm_hold_lvb = gdlm_hold_lvb, | ||
272 | .lm_unhold_lvb = gdlm_unhold_lvb, | ||
273 | .lm_recovery_done = gdlm_recovery_done, | ||
274 | .lm_owner = THIS_MODULE, | ||
275 | }; | ||
276 | |||
diff --git a/fs/gfs2/locking/dlm/sysfs.c b/fs/gfs2/locking/dlm/sysfs.c deleted file mode 100644 index 9b7edcf7bd49..000000000000 --- a/fs/gfs2/locking/dlm/sysfs.c +++ /dev/null | |||
@@ -1,226 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include <linux/ctype.h> | ||
11 | #include <linux/stat.h> | ||
12 | |||
13 | #include "lock_dlm.h" | ||
14 | |||
15 | static ssize_t proto_name_show(struct gdlm_ls *ls, char *buf) | ||
16 | { | ||
17 | return sprintf(buf, "%s\n", gdlm_ops.lm_proto_name); | ||
18 | } | ||
19 | |||
20 | static ssize_t block_show(struct gdlm_ls *ls, char *buf) | ||
21 | { | ||
22 | ssize_t ret; | ||
23 | int val = 0; | ||
24 | |||
25 | if (test_bit(DFL_BLOCK_LOCKS, &ls->flags)) | ||
26 | val = 1; | ||
27 | ret = sprintf(buf, "%d\n", val); | ||
28 | return ret; | ||
29 | } | ||
30 | |||
31 | static ssize_t block_store(struct gdlm_ls *ls, const char *buf, size_t len) | ||
32 | { | ||
33 | ssize_t ret = len; | ||
34 | int val; | ||
35 | |||
36 | val = simple_strtol(buf, NULL, 0); | ||
37 | |||
38 | if (val == 1) | ||
39 | set_bit(DFL_BLOCK_LOCKS, &ls->flags); | ||
40 | else if (val == 0) { | ||
41 | clear_bit(DFL_BLOCK_LOCKS, &ls->flags); | ||
42 | gdlm_submit_delayed(ls); | ||
43 | } else { | ||
44 | ret = -EINVAL; | ||
45 | } | ||
46 | return ret; | ||
47 | } | ||
48 | |||
49 | static ssize_t withdraw_show(struct gdlm_ls *ls, char *buf) | ||
50 | { | ||
51 | ssize_t ret; | ||
52 | int val = 0; | ||
53 | |||
54 | if (test_bit(DFL_WITHDRAW, &ls->flags)) | ||
55 | val = 1; | ||
56 | ret = sprintf(buf, "%d\n", val); | ||
57 | return ret; | ||
58 | } | ||
59 | |||
60 | static ssize_t withdraw_store(struct gdlm_ls *ls, const char *buf, size_t len) | ||
61 | { | ||
62 | ssize_t ret = len; | ||
63 | int val; | ||
64 | |||
65 | val = simple_strtol(buf, NULL, 0); | ||
66 | |||
67 | if (val == 1) | ||
68 | set_bit(DFL_WITHDRAW, &ls->flags); | ||
69 | else | ||
70 | ret = -EINVAL; | ||
71 | wake_up(&ls->wait_control); | ||
72 | return ret; | ||
73 | } | ||
74 | |||
75 | static ssize_t id_show(struct gdlm_ls *ls, char *buf) | ||
76 | { | ||
77 | return sprintf(buf, "%u\n", ls->id); | ||
78 | } | ||
79 | |||
80 | static ssize_t jid_show(struct gdlm_ls *ls, char *buf) | ||
81 | { | ||
82 | return sprintf(buf, "%d\n", ls->jid); | ||
83 | } | ||
84 | |||
85 | static ssize_t first_show(struct gdlm_ls *ls, char *buf) | ||
86 | { | ||
87 | return sprintf(buf, "%d\n", ls->first); | ||
88 | } | ||
89 | |||
90 | static ssize_t first_done_show(struct gdlm_ls *ls, char *buf) | ||
91 | { | ||
92 | return sprintf(buf, "%d\n", ls->first_done); | ||
93 | } | ||
94 | |||
95 | static ssize_t recover_show(struct gdlm_ls *ls, char *buf) | ||
96 | { | ||
97 | return sprintf(buf, "%d\n", ls->recover_jid); | ||
98 | } | ||
99 | |||
100 | static ssize_t recover_store(struct gdlm_ls *ls, const char *buf, size_t len) | ||
101 | { | ||
102 | ls->recover_jid = simple_strtol(buf, NULL, 0); | ||
103 | ls->fscb(ls->sdp, LM_CB_NEED_RECOVERY, &ls->recover_jid); | ||
104 | return len; | ||
105 | } | ||
106 | |||
107 | static ssize_t recover_done_show(struct gdlm_ls *ls, char *buf) | ||
108 | { | ||
109 | return sprintf(buf, "%d\n", ls->recover_jid_done); | ||
110 | } | ||
111 | |||
112 | static ssize_t recover_status_show(struct gdlm_ls *ls, char *buf) | ||
113 | { | ||
114 | return sprintf(buf, "%d\n", ls->recover_jid_status); | ||
115 | } | ||
116 | |||
117 | struct gdlm_attr { | ||
118 | struct attribute attr; | ||
119 | ssize_t (*show)(struct gdlm_ls *, char *); | ||
120 | ssize_t (*store)(struct gdlm_ls *, const char *, size_t); | ||
121 | }; | ||
122 | |||
123 | #define GDLM_ATTR(_name,_mode,_show,_store) \ | ||
124 | static struct gdlm_attr gdlm_attr_##_name = __ATTR(_name,_mode,_show,_store) | ||
125 | |||
126 | GDLM_ATTR(proto_name, 0444, proto_name_show, NULL); | ||
127 | GDLM_ATTR(block, 0644, block_show, block_store); | ||
128 | GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store); | ||
129 | GDLM_ATTR(id, 0444, id_show, NULL); | ||
130 | GDLM_ATTR(jid, 0444, jid_show, NULL); | ||
131 | GDLM_ATTR(first, 0444, first_show, NULL); | ||
132 | GDLM_ATTR(first_done, 0444, first_done_show, NULL); | ||
133 | GDLM_ATTR(recover, 0644, recover_show, recover_store); | ||
134 | GDLM_ATTR(recover_done, 0444, recover_done_show, NULL); | ||
135 | GDLM_ATTR(recover_status, 0444, recover_status_show, NULL); | ||
136 | |||
137 | static struct attribute *gdlm_attrs[] = { | ||
138 | &gdlm_attr_proto_name.attr, | ||
139 | &gdlm_attr_block.attr, | ||
140 | &gdlm_attr_withdraw.attr, | ||
141 | &gdlm_attr_id.attr, | ||
142 | &gdlm_attr_jid.attr, | ||
143 | &gdlm_attr_first.attr, | ||
144 | &gdlm_attr_first_done.attr, | ||
145 | &gdlm_attr_recover.attr, | ||
146 | &gdlm_attr_recover_done.attr, | ||
147 | &gdlm_attr_recover_status.attr, | ||
148 | NULL, | ||
149 | }; | ||
150 | |||
151 | static ssize_t gdlm_attr_show(struct kobject *kobj, struct attribute *attr, | ||
152 | char *buf) | ||
153 | { | ||
154 | struct gdlm_ls *ls = container_of(kobj, struct gdlm_ls, kobj); | ||
155 | struct gdlm_attr *a = container_of(attr, struct gdlm_attr, attr); | ||
156 | return a->show ? a->show(ls, buf) : 0; | ||
157 | } | ||
158 | |||
159 | static ssize_t gdlm_attr_store(struct kobject *kobj, struct attribute *attr, | ||
160 | const char *buf, size_t len) | ||
161 | { | ||
162 | struct gdlm_ls *ls = container_of(kobj, struct gdlm_ls, kobj); | ||
163 | struct gdlm_attr *a = container_of(attr, struct gdlm_attr, attr); | ||
164 | return a->store ? a->store(ls, buf, len) : len; | ||
165 | } | ||
166 | |||
167 | static struct sysfs_ops gdlm_attr_ops = { | ||
168 | .show = gdlm_attr_show, | ||
169 | .store = gdlm_attr_store, | ||
170 | }; | ||
171 | |||
172 | static struct kobj_type gdlm_ktype = { | ||
173 | .default_attrs = gdlm_attrs, | ||
174 | .sysfs_ops = &gdlm_attr_ops, | ||
175 | }; | ||
176 | |||
177 | static struct kset *gdlm_kset; | ||
178 | |||
179 | int gdlm_kobject_setup(struct gdlm_ls *ls, struct kobject *fskobj) | ||
180 | { | ||
181 | int error; | ||
182 | |||
183 | ls->kobj.kset = gdlm_kset; | ||
184 | error = kobject_init_and_add(&ls->kobj, &gdlm_ktype, fskobj, | ||
185 | "lock_module"); | ||
186 | if (error) | ||
187 | log_error("can't register kobj %d", error); | ||
188 | kobject_uevent(&ls->kobj, KOBJ_ADD); | ||
189 | |||
190 | return error; | ||
191 | } | ||
192 | |||
193 | void gdlm_kobject_release(struct gdlm_ls *ls) | ||
194 | { | ||
195 | kobject_put(&ls->kobj); | ||
196 | } | ||
197 | |||
198 | static int gdlm_uevent(struct kset *kset, struct kobject *kobj, | ||
199 | struct kobj_uevent_env *env) | ||
200 | { | ||
201 | struct gdlm_ls *ls = container_of(kobj, struct gdlm_ls, kobj); | ||
202 | add_uevent_var(env, "LOCKTABLE=%s:%s", ls->clustername, ls->fsname); | ||
203 | add_uevent_var(env, "LOCKPROTO=lock_dlm"); | ||
204 | return 0; | ||
205 | } | ||
206 | |||
207 | static struct kset_uevent_ops gdlm_uevent_ops = { | ||
208 | .uevent = gdlm_uevent, | ||
209 | }; | ||
210 | |||
211 | |||
212 | int gdlm_sysfs_init(void) | ||
213 | { | ||
214 | gdlm_kset = kset_create_and_add("lock_dlm", &gdlm_uevent_ops, kernel_kobj); | ||
215 | if (!gdlm_kset) { | ||
216 | printk(KERN_WARNING "%s: can not create kset\n", __func__); | ||
217 | return -ENOMEM; | ||
218 | } | ||
219 | return 0; | ||
220 | } | ||
221 | |||
222 | void gdlm_sysfs_exit(void) | ||
223 | { | ||
224 | kset_unregister(gdlm_kset); | ||
225 | } | ||
226 | |||
diff --git a/fs/gfs2/locking/dlm/thread.c b/fs/gfs2/locking/dlm/thread.c deleted file mode 100644 index 38823efd698c..000000000000 --- a/fs/gfs2/locking/dlm/thread.c +++ /dev/null | |||
@@ -1,68 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2005 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #include "lock_dlm.h" | ||
11 | |||
12 | static inline int no_work(struct gdlm_ls *ls) | ||
13 | { | ||
14 | int ret; | ||
15 | |||
16 | spin_lock(&ls->async_lock); | ||
17 | ret = list_empty(&ls->submit); | ||
18 | spin_unlock(&ls->async_lock); | ||
19 | |||
20 | return ret; | ||
21 | } | ||
22 | |||
23 | static int gdlm_thread(void *data) | ||
24 | { | ||
25 | struct gdlm_ls *ls = (struct gdlm_ls *) data; | ||
26 | struct gdlm_lock *lp = NULL; | ||
27 | |||
28 | while (!kthread_should_stop()) { | ||
29 | wait_event_interruptible(ls->thread_wait, | ||
30 | !no_work(ls) || kthread_should_stop()); | ||
31 | |||
32 | spin_lock(&ls->async_lock); | ||
33 | |||
34 | if (!list_empty(&ls->submit)) { | ||
35 | lp = list_entry(ls->submit.next, struct gdlm_lock, | ||
36 | delay_list); | ||
37 | list_del_init(&lp->delay_list); | ||
38 | spin_unlock(&ls->async_lock); | ||
39 | gdlm_do_lock(lp); | ||
40 | spin_lock(&ls->async_lock); | ||
41 | } | ||
42 | spin_unlock(&ls->async_lock); | ||
43 | } | ||
44 | |||
45 | return 0; | ||
46 | } | ||
47 | |||
48 | int gdlm_init_threads(struct gdlm_ls *ls) | ||
49 | { | ||
50 | struct task_struct *p; | ||
51 | int error; | ||
52 | |||
53 | p = kthread_run(gdlm_thread, ls, "lock_dlm"); | ||
54 | error = IS_ERR(p); | ||
55 | if (error) { | ||
56 | log_error("can't start lock_dlm thread %d", error); | ||
57 | return error; | ||
58 | } | ||
59 | ls->thread = p; | ||
60 | |||
61 | return 0; | ||
62 | } | ||
63 | |||
64 | void gdlm_release_threads(struct gdlm_ls *ls) | ||
65 | { | ||
66 | kthread_stop(ls->thread); | ||
67 | } | ||
68 | |||
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index ad305854bdc6..98918a756410 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c | |||
@@ -14,7 +14,6 @@ | |||
14 | #include <linux/buffer_head.h> | 14 | #include <linux/buffer_head.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/crc32.h> | 16 | #include <linux/crc32.h> |
17 | #include <linux/lm_interface.h> | ||
18 | #include <linux/delay.h> | 17 | #include <linux/delay.h> |
19 | #include <linux/kthread.h> | 18 | #include <linux/kthread.h> |
20 | #include <linux/freezer.h> | 19 | #include <linux/freezer.h> |
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 4390f6f4047d..80e4f5f898bb 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/completion.h> | 13 | #include <linux/completion.h> |
14 | #include <linux/buffer_head.h> | 14 | #include <linux/buffer_head.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/lm_interface.h> | ||
17 | 16 | ||
18 | #include "gfs2.h" | 17 | #include "gfs2.h" |
19 | #include "incore.h" | 18 | #include "incore.h" |
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index 7cacfde32194..a6892ed0840a 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c | |||
@@ -14,7 +14,6 @@ | |||
14 | #include <linux/module.h> | 14 | #include <linux/module.h> |
15 | #include <linux/init.h> | 15 | #include <linux/init.h> |
16 | #include <linux/gfs2_ondisk.h> | 16 | #include <linux/gfs2_ondisk.h> |
17 | #include <linux/lm_interface.h> | ||
18 | #include <asm/atomic.h> | 17 | #include <asm/atomic.h> |
19 | 18 | ||
20 | #include "gfs2.h" | 19 | #include "gfs2.h" |
@@ -23,6 +22,12 @@ | |||
23 | #include "sys.h" | 22 | #include "sys.h" |
24 | #include "util.h" | 23 | #include "util.h" |
25 | #include "glock.h" | 24 | #include "glock.h" |
25 | #include "quota.h" | ||
26 | |||
27 | static struct shrinker qd_shrinker = { | ||
28 | .shrink = gfs2_shrink_qd_memory, | ||
29 | .seeks = DEFAULT_SEEKS, | ||
30 | }; | ||
26 | 31 | ||
27 | static void gfs2_init_inode_once(void *foo) | 32 | static void gfs2_init_inode_once(void *foo) |
28 | { | 33 | { |
@@ -41,8 +46,6 @@ static void gfs2_init_glock_once(void *foo) | |||
41 | INIT_HLIST_NODE(&gl->gl_list); | 46 | INIT_HLIST_NODE(&gl->gl_list); |
42 | spin_lock_init(&gl->gl_spin); | 47 | spin_lock_init(&gl->gl_spin); |
43 | INIT_LIST_HEAD(&gl->gl_holders); | 48 | INIT_LIST_HEAD(&gl->gl_holders); |
44 | gl->gl_lvb = NULL; | ||
45 | atomic_set(&gl->gl_lvb_count, 0); | ||
46 | INIT_LIST_HEAD(&gl->gl_lru); | 49 | INIT_LIST_HEAD(&gl->gl_lru); |
47 | INIT_LIST_HEAD(&gl->gl_ail_list); | 50 | INIT_LIST_HEAD(&gl->gl_ail_list); |
48 | atomic_set(&gl->gl_ail_count, 0); | 51 | atomic_set(&gl->gl_ail_count, 0); |
@@ -100,6 +103,8 @@ static int __init init_gfs2_fs(void) | |||
100 | if (!gfs2_quotad_cachep) | 103 | if (!gfs2_quotad_cachep) |
101 | goto fail; | 104 | goto fail; |
102 | 105 | ||
106 | register_shrinker(&qd_shrinker); | ||
107 | |||
103 | error = register_filesystem(&gfs2_fs_type); | 108 | error = register_filesystem(&gfs2_fs_type); |
104 | if (error) | 109 | if (error) |
105 | goto fail; | 110 | goto fail; |
@@ -117,6 +122,7 @@ static int __init init_gfs2_fs(void) | |||
117 | fail_unregister: | 122 | fail_unregister: |
118 | unregister_filesystem(&gfs2_fs_type); | 123 | unregister_filesystem(&gfs2_fs_type); |
119 | fail: | 124 | fail: |
125 | unregister_shrinker(&qd_shrinker); | ||
120 | gfs2_glock_exit(); | 126 | gfs2_glock_exit(); |
121 | 127 | ||
122 | if (gfs2_quotad_cachep) | 128 | if (gfs2_quotad_cachep) |
@@ -145,6 +151,7 @@ fail: | |||
145 | 151 | ||
146 | static void __exit exit_gfs2_fs(void) | 152 | static void __exit exit_gfs2_fs(void) |
147 | { | 153 | { |
154 | unregister_shrinker(&qd_shrinker); | ||
148 | gfs2_glock_exit(); | 155 | gfs2_glock_exit(); |
149 | gfs2_unregister_debugfs(); | 156 | gfs2_unregister_debugfs(); |
150 | unregister_filesystem(&gfs2_fs_type); | 157 | unregister_filesystem(&gfs2_fs_type); |
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 09853620c951..8d6f13256b26 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/delay.h> | 19 | #include <linux/delay.h> |
20 | #include <linux/bio.h> | 20 | #include <linux/bio.h> |
21 | #include <linux/gfs2_ondisk.h> | 21 | #include <linux/gfs2_ondisk.h> |
22 | #include <linux/lm_interface.h> | ||
23 | 22 | ||
24 | #include "gfs2.h" | 23 | #include "gfs2.h" |
25 | #include "incore.h" | 24 | #include "incore.h" |
@@ -90,27 +89,6 @@ void gfs2_aspace_put(struct inode *aspace) | |||
90 | } | 89 | } |
91 | 90 | ||
92 | /** | 91 | /** |
93 | * gfs2_meta_inval - Invalidate all buffers associated with a glock | ||
94 | * @gl: the glock | ||
95 | * | ||
96 | */ | ||
97 | |||
98 | void gfs2_meta_inval(struct gfs2_glock *gl) | ||
99 | { | ||
100 | struct gfs2_sbd *sdp = gl->gl_sbd; | ||
101 | struct inode *aspace = gl->gl_aspace; | ||
102 | struct address_space *mapping = gl->gl_aspace->i_mapping; | ||
103 | |||
104 | gfs2_assert_withdraw(sdp, !atomic_read(&gl->gl_ail_count)); | ||
105 | |||
106 | atomic_inc(&aspace->i_writecount); | ||
107 | truncate_inode_pages(mapping, 0); | ||
108 | atomic_dec(&aspace->i_writecount); | ||
109 | |||
110 | gfs2_assert_withdraw(sdp, !mapping->nrpages); | ||
111 | } | ||
112 | |||
113 | /** | ||
114 | * gfs2_meta_sync - Sync all buffers associated with a glock | 92 | * gfs2_meta_sync - Sync all buffers associated with a glock |
115 | * @gl: The glock | 93 | * @gl: The glock |
116 | * | 94 | * |
diff --git a/fs/gfs2/meta_io.h b/fs/gfs2/meta_io.h index b1a5f3674d43..de270c2f9b63 100644 --- a/fs/gfs2/meta_io.h +++ b/fs/gfs2/meta_io.h | |||
@@ -40,7 +40,6 @@ static inline void gfs2_buffer_copy_tail(struct buffer_head *to_bh, | |||
40 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp); | 40 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp); |
41 | void gfs2_aspace_put(struct inode *aspace); | 41 | void gfs2_aspace_put(struct inode *aspace); |
42 | 42 | ||
43 | void gfs2_meta_inval(struct gfs2_glock *gl); | ||
44 | void gfs2_meta_sync(struct gfs2_glock *gl); | 43 | void gfs2_meta_sync(struct gfs2_glock *gl); |
45 | 44 | ||
46 | struct buffer_head *gfs2_meta_new(struct gfs2_glock *gl, u64 blkno); | 45 | struct buffer_head *gfs2_meta_new(struct gfs2_glock *gl, u64 blkno); |
diff --git a/fs/gfs2/mount.c b/fs/gfs2/mount.c index 3cb0a44ba023..f7e8527a21e0 100644 --- a/fs/gfs2/mount.c +++ b/fs/gfs2/mount.c | |||
@@ -12,12 +12,11 @@ | |||
12 | #include <linux/completion.h> | 12 | #include <linux/completion.h> |
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
15 | #include <linux/lm_interface.h> | ||
16 | #include <linux/parser.h> | 15 | #include <linux/parser.h> |
17 | 16 | ||
18 | #include "gfs2.h" | 17 | #include "gfs2.h" |
19 | #include "incore.h" | 18 | #include "incore.h" |
20 | #include "mount.h" | 19 | #include "super.h" |
21 | #include "sys.h" | 20 | #include "sys.h" |
22 | #include "util.h" | 21 | #include "util.h" |
23 | 22 | ||
@@ -37,11 +36,15 @@ enum { | |||
37 | Opt_quota_off, | 36 | Opt_quota_off, |
38 | Opt_quota_account, | 37 | Opt_quota_account, |
39 | Opt_quota_on, | 38 | Opt_quota_on, |
39 | Opt_quota, | ||
40 | Opt_noquota, | ||
40 | Opt_suiddir, | 41 | Opt_suiddir, |
41 | Opt_nosuiddir, | 42 | Opt_nosuiddir, |
42 | Opt_data_writeback, | 43 | Opt_data_writeback, |
43 | Opt_data_ordered, | 44 | Opt_data_ordered, |
44 | Opt_meta, | 45 | Opt_meta, |
46 | Opt_discard, | ||
47 | Opt_nodiscard, | ||
45 | Opt_err, | 48 | Opt_err, |
46 | }; | 49 | }; |
47 | 50 | ||
@@ -61,11 +64,15 @@ static const match_table_t tokens = { | |||
61 | {Opt_quota_off, "quota=off"}, | 64 | {Opt_quota_off, "quota=off"}, |
62 | {Opt_quota_account, "quota=account"}, | 65 | {Opt_quota_account, "quota=account"}, |
63 | {Opt_quota_on, "quota=on"}, | 66 | {Opt_quota_on, "quota=on"}, |
67 | {Opt_quota, "quota"}, | ||
68 | {Opt_noquota, "noquota"}, | ||
64 | {Opt_suiddir, "suiddir"}, | 69 | {Opt_suiddir, "suiddir"}, |
65 | {Opt_nosuiddir, "nosuiddir"}, | 70 | {Opt_nosuiddir, "nosuiddir"}, |
66 | {Opt_data_writeback, "data=writeback"}, | 71 | {Opt_data_writeback, "data=writeback"}, |
67 | {Opt_data_ordered, "data=ordered"}, | 72 | {Opt_data_ordered, "data=ordered"}, |
68 | {Opt_meta, "meta"}, | 73 | {Opt_meta, "meta"}, |
74 | {Opt_discard, "discard"}, | ||
75 | {Opt_nodiscard, "nodiscard"}, | ||
69 | {Opt_err, NULL} | 76 | {Opt_err, NULL} |
70 | }; | 77 | }; |
71 | 78 | ||
@@ -77,101 +84,46 @@ static const match_table_t tokens = { | |||
77 | * Return: errno | 84 | * Return: errno |
78 | */ | 85 | */ |
79 | 86 | ||
80 | int gfs2_mount_args(struct gfs2_sbd *sdp, char *data_arg, int remount) | 87 | int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *options) |
81 | { | 88 | { |
82 | struct gfs2_args *args = &sdp->sd_args; | 89 | char *o; |
83 | char *data = data_arg; | 90 | int token; |
84 | char *options, *o, *v; | 91 | substring_t tmp[MAX_OPT_ARGS]; |
85 | int error = 0; | ||
86 | |||
87 | if (!remount) { | ||
88 | /* Set some defaults */ | ||
89 | args->ar_quota = GFS2_QUOTA_DEFAULT; | ||
90 | args->ar_data = GFS2_DATA_DEFAULT; | ||
91 | } | ||
92 | 92 | ||
93 | /* Split the options into tokens with the "," character and | 93 | /* Split the options into tokens with the "," character and |
94 | process them */ | 94 | process them */ |
95 | 95 | ||
96 | for (options = data; (o = strsep(&options, ",")); ) { | 96 | while (1) { |
97 | int token; | 97 | o = strsep(&options, ","); |
98 | substring_t tmp[MAX_OPT_ARGS]; | 98 | if (o == NULL) |
99 | 99 | break; | |
100 | if (!*o) | 100 | if (*o == '\0') |
101 | continue; | 101 | continue; |
102 | 102 | ||
103 | token = match_token(o, tokens, tmp); | 103 | token = match_token(o, tokens, tmp); |
104 | switch (token) { | 104 | switch (token) { |
105 | case Opt_lockproto: | 105 | case Opt_lockproto: |
106 | v = match_strdup(&tmp[0]); | 106 | match_strlcpy(args->ar_lockproto, &tmp[0], |
107 | if (!v) { | 107 | GFS2_LOCKNAME_LEN); |
108 | fs_info(sdp, "no memory for lockproto\n"); | ||
109 | error = -ENOMEM; | ||
110 | goto out_error; | ||
111 | } | ||
112 | |||
113 | if (remount && strcmp(v, args->ar_lockproto)) { | ||
114 | kfree(v); | ||
115 | goto cant_remount; | ||
116 | } | ||
117 | |||
118 | strncpy(args->ar_lockproto, v, GFS2_LOCKNAME_LEN); | ||
119 | args->ar_lockproto[GFS2_LOCKNAME_LEN - 1] = 0; | ||
120 | kfree(v); | ||
121 | break; | 108 | break; |
122 | case Opt_locktable: | 109 | case Opt_locktable: |
123 | v = match_strdup(&tmp[0]); | 110 | match_strlcpy(args->ar_locktable, &tmp[0], |
124 | if (!v) { | 111 | GFS2_LOCKNAME_LEN); |
125 | fs_info(sdp, "no memory for locktable\n"); | ||
126 | error = -ENOMEM; | ||
127 | goto out_error; | ||
128 | } | ||
129 | |||
130 | if (remount && strcmp(v, args->ar_locktable)) { | ||
131 | kfree(v); | ||
132 | goto cant_remount; | ||
133 | } | ||
134 | |||
135 | strncpy(args->ar_locktable, v, GFS2_LOCKNAME_LEN); | ||
136 | args->ar_locktable[GFS2_LOCKNAME_LEN - 1] = 0; | ||
137 | kfree(v); | ||
138 | break; | 112 | break; |
139 | case Opt_hostdata: | 113 | case Opt_hostdata: |
140 | v = match_strdup(&tmp[0]); | 114 | match_strlcpy(args->ar_hostdata, &tmp[0], |
141 | if (!v) { | 115 | GFS2_LOCKNAME_LEN); |
142 | fs_info(sdp, "no memory for hostdata\n"); | ||
143 | error = -ENOMEM; | ||
144 | goto out_error; | ||
145 | } | ||
146 | |||
147 | if (remount && strcmp(v, args->ar_hostdata)) { | ||
148 | kfree(v); | ||
149 | goto cant_remount; | ||
150 | } | ||
151 | |||
152 | strncpy(args->ar_hostdata, v, GFS2_LOCKNAME_LEN); | ||
153 | args->ar_hostdata[GFS2_LOCKNAME_LEN - 1] = 0; | ||
154 | kfree(v); | ||
155 | break; | 116 | break; |
156 | case Opt_spectator: | 117 | case Opt_spectator: |
157 | if (remount && !args->ar_spectator) | ||
158 | goto cant_remount; | ||
159 | args->ar_spectator = 1; | 118 | args->ar_spectator = 1; |
160 | sdp->sd_vfs->s_flags |= MS_RDONLY; | ||
161 | break; | 119 | break; |
162 | case Opt_ignore_local_fs: | 120 | case Opt_ignore_local_fs: |
163 | if (remount && !args->ar_ignore_local_fs) | ||
164 | goto cant_remount; | ||
165 | args->ar_ignore_local_fs = 1; | 121 | args->ar_ignore_local_fs = 1; |
166 | break; | 122 | break; |
167 | case Opt_localflocks: | 123 | case Opt_localflocks: |
168 | if (remount && !args->ar_localflocks) | ||
169 | goto cant_remount; | ||
170 | args->ar_localflocks = 1; | 124 | args->ar_localflocks = 1; |
171 | break; | 125 | break; |
172 | case Opt_localcaching: | 126 | case Opt_localcaching: |
173 | if (remount && !args->ar_localcaching) | ||
174 | goto cant_remount; | ||
175 | args->ar_localcaching = 1; | 127 | args->ar_localcaching = 1; |
176 | break; | 128 | break; |
177 | case Opt_debug: | 129 | case Opt_debug: |
@@ -181,25 +133,23 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, char *data_arg, int remount) | |||
181 | args->ar_debug = 0; | 133 | args->ar_debug = 0; |
182 | break; | 134 | break; |
183 | case Opt_upgrade: | 135 | case Opt_upgrade: |
184 | if (remount && !args->ar_upgrade) | ||
185 | goto cant_remount; | ||
186 | args->ar_upgrade = 1; | 136 | args->ar_upgrade = 1; |
187 | break; | 137 | break; |
188 | case Opt_acl: | 138 | case Opt_acl: |
189 | args->ar_posix_acl = 1; | 139 | args->ar_posix_acl = 1; |
190 | sdp->sd_vfs->s_flags |= MS_POSIXACL; | ||
191 | break; | 140 | break; |
192 | case Opt_noacl: | 141 | case Opt_noacl: |
193 | args->ar_posix_acl = 0; | 142 | args->ar_posix_acl = 0; |
194 | sdp->sd_vfs->s_flags &= ~MS_POSIXACL; | ||
195 | break; | 143 | break; |
196 | case Opt_quota_off: | 144 | case Opt_quota_off: |
145 | case Opt_noquota: | ||
197 | args->ar_quota = GFS2_QUOTA_OFF; | 146 | args->ar_quota = GFS2_QUOTA_OFF; |
198 | break; | 147 | break; |
199 | case Opt_quota_account: | 148 | case Opt_quota_account: |
200 | args->ar_quota = GFS2_QUOTA_ACCOUNT; | 149 | args->ar_quota = GFS2_QUOTA_ACCOUNT; |
201 | break; | 150 | break; |
202 | case Opt_quota_on: | 151 | case Opt_quota_on: |
152 | case Opt_quota: | ||
203 | args->ar_quota = GFS2_QUOTA_ON; | 153 | args->ar_quota = GFS2_QUOTA_ON; |
204 | break; | 154 | break; |
205 | case Opt_suiddir: | 155 | case Opt_suiddir: |
@@ -215,29 +165,21 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, char *data_arg, int remount) | |||
215 | args->ar_data = GFS2_DATA_ORDERED; | 165 | args->ar_data = GFS2_DATA_ORDERED; |
216 | break; | 166 | break; |
217 | case Opt_meta: | 167 | case Opt_meta: |
218 | if (remount && args->ar_meta != 1) | ||
219 | goto cant_remount; | ||
220 | args->ar_meta = 1; | 168 | args->ar_meta = 1; |
221 | break; | 169 | break; |
170 | case Opt_discard: | ||
171 | args->ar_discard = 1; | ||
172 | break; | ||
173 | case Opt_nodiscard: | ||
174 | args->ar_discard = 0; | ||
175 | break; | ||
222 | case Opt_err: | 176 | case Opt_err: |
223 | default: | 177 | default: |
224 | fs_info(sdp, "unknown option: %s\n", o); | 178 | fs_info(sdp, "invalid mount option: %s\n", o); |
225 | error = -EINVAL; | 179 | return -EINVAL; |
226 | goto out_error; | ||
227 | } | 180 | } |
228 | } | 181 | } |
229 | 182 | ||
230 | out_error: | 183 | return 0; |
231 | if (error) | ||
232 | fs_info(sdp, "invalid mount option(s)\n"); | ||
233 | |||
234 | if (data != data_arg) | ||
235 | kfree(data); | ||
236 | |||
237 | return error; | ||
238 | |||
239 | cant_remount: | ||
240 | fs_info(sdp, "can't remount with option %s\n", o); | ||
241 | return -EINVAL; | ||
242 | } | 184 | } |
243 | 185 | ||
diff --git a/fs/gfs2/mount.h b/fs/gfs2/mount.h deleted file mode 100644 index 401288acfdf3..000000000000 --- a/fs/gfs2/mount.h +++ /dev/null | |||
@@ -1,17 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | ||
3 | * Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved. | ||
4 | * | ||
5 | * This copyrighted material is made available to anyone wishing to use, | ||
6 | * modify, copy, or redistribute it subject to the terms and conditions | ||
7 | * of the GNU General Public License version 2. | ||
8 | */ | ||
9 | |||
10 | #ifndef __MOUNT_DOT_H__ | ||
11 | #define __MOUNT_DOT_H__ | ||
12 | |||
13 | struct gfs2_sbd; | ||
14 | |||
15 | int gfs2_mount_args(struct gfs2_sbd *sdp, char *data_arg, int remount); | ||
16 | |||
17 | #endif /* __MOUNT_DOT_H__ */ | ||
diff --git a/fs/gfs2/ops_address.c b/fs/gfs2/ops_address.c index 4ddab67867eb..a6dde1751e17 100644 --- a/fs/gfs2/ops_address.c +++ b/fs/gfs2/ops_address.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/writeback.h> | 19 | #include <linux/writeback.h> |
20 | #include <linux/swap.h> | 20 | #include <linux/swap.h> |
21 | #include <linux/gfs2_ondisk.h> | 21 | #include <linux/gfs2_ondisk.h> |
22 | #include <linux/lm_interface.h> | ||
23 | #include <linux/backing-dev.h> | 22 | #include <linux/backing-dev.h> |
24 | 23 | ||
25 | #include "gfs2.h" | 24 | #include "gfs2.h" |
@@ -442,6 +441,7 @@ static int stuffed_readpage(struct gfs2_inode *ip, struct page *page) | |||
442 | */ | 441 | */ |
443 | if (unlikely(page->index)) { | 442 | if (unlikely(page->index)) { |
444 | zero_user(page, 0, PAGE_CACHE_SIZE); | 443 | zero_user(page, 0, PAGE_CACHE_SIZE); |
444 | SetPageUptodate(page); | ||
445 | return 0; | 445 | return 0; |
446 | } | 446 | } |
447 | 447 | ||
@@ -1096,6 +1096,7 @@ static const struct address_space_operations gfs2_writeback_aops = { | |||
1096 | .releasepage = gfs2_releasepage, | 1096 | .releasepage = gfs2_releasepage, |
1097 | .direct_IO = gfs2_direct_IO, | 1097 | .direct_IO = gfs2_direct_IO, |
1098 | .migratepage = buffer_migrate_page, | 1098 | .migratepage = buffer_migrate_page, |
1099 | .is_partially_uptodate = block_is_partially_uptodate, | ||
1099 | }; | 1100 | }; |
1100 | 1101 | ||
1101 | static const struct address_space_operations gfs2_ordered_aops = { | 1102 | static const struct address_space_operations gfs2_ordered_aops = { |
@@ -1111,6 +1112,7 @@ static const struct address_space_operations gfs2_ordered_aops = { | |||
1111 | .releasepage = gfs2_releasepage, | 1112 | .releasepage = gfs2_releasepage, |
1112 | .direct_IO = gfs2_direct_IO, | 1113 | .direct_IO = gfs2_direct_IO, |
1113 | .migratepage = buffer_migrate_page, | 1114 | .migratepage = buffer_migrate_page, |
1115 | .is_partially_uptodate = block_is_partially_uptodate, | ||
1114 | }; | 1116 | }; |
1115 | 1117 | ||
1116 | static const struct address_space_operations gfs2_jdata_aops = { | 1118 | static const struct address_space_operations gfs2_jdata_aops = { |
@@ -1125,6 +1127,7 @@ static const struct address_space_operations gfs2_jdata_aops = { | |||
1125 | .bmap = gfs2_bmap, | 1127 | .bmap = gfs2_bmap, |
1126 | .invalidatepage = gfs2_invalidatepage, | 1128 | .invalidatepage = gfs2_invalidatepage, |
1127 | .releasepage = gfs2_releasepage, | 1129 | .releasepage = gfs2_releasepage, |
1130 | .is_partially_uptodate = block_is_partially_uptodate, | ||
1128 | }; | 1131 | }; |
1129 | 1132 | ||
1130 | void gfs2_set_aops(struct inode *inode) | 1133 | void gfs2_set_aops(struct inode *inode) |
diff --git a/fs/gfs2/ops_dentry.c b/fs/gfs2/ops_dentry.c index c2ad36330ca3..022c66cd5606 100644 --- a/fs/gfs2/ops_dentry.c +++ b/fs/gfs2/ops_dentry.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
15 | #include <linux/crc32.h> | 15 | #include <linux/crc32.h> |
16 | #include <linux/lm_interface.h> | ||
17 | 16 | ||
18 | #include "gfs2.h" | 17 | #include "gfs2.h" |
19 | #include "incore.h" | 18 | #include "incore.h" |
@@ -108,7 +107,7 @@ static int gfs2_dhash(struct dentry *dentry, struct qstr *str) | |||
108 | return 0; | 107 | return 0; |
109 | } | 108 | } |
110 | 109 | ||
111 | struct dentry_operations gfs2_dops = { | 110 | const struct dentry_operations gfs2_dops = { |
112 | .d_revalidate = gfs2_drevalidate, | 111 | .d_revalidate = gfs2_drevalidate, |
113 | .d_hash = gfs2_dhash, | 112 | .d_hash = gfs2_dhash, |
114 | }; | 113 | }; |
diff --git a/fs/gfs2/ops_export.c b/fs/gfs2/ops_export.c index 7fdeb14ddd1a..9200ef221716 100644 --- a/fs/gfs2/ops_export.c +++ b/fs/gfs2/ops_export.c | |||
@@ -14,7 +14,6 @@ | |||
14 | #include <linux/exportfs.h> | 14 | #include <linux/exportfs.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/crc32.h> | 16 | #include <linux/crc32.h> |
17 | #include <linux/lm_interface.h> | ||
18 | 17 | ||
19 | #include "gfs2.h" | 18 | #include "gfs2.h" |
20 | #include "incore.h" | 19 | #include "incore.h" |
diff --git a/fs/gfs2/ops_file.c b/fs/gfs2/ops_file.c index 93fe41b67f97..3b9e8de3500b 100644 --- a/fs/gfs2/ops_file.c +++ b/fs/gfs2/ops_file.c | |||
@@ -20,9 +20,10 @@ | |||
20 | #include <linux/gfs2_ondisk.h> | 20 | #include <linux/gfs2_ondisk.h> |
21 | #include <linux/ext2_fs.h> | 21 | #include <linux/ext2_fs.h> |
22 | #include <linux/crc32.h> | 22 | #include <linux/crc32.h> |
23 | #include <linux/lm_interface.h> | ||
24 | #include <linux/writeback.h> | 23 | #include <linux/writeback.h> |
25 | #include <asm/uaccess.h> | 24 | #include <asm/uaccess.h> |
25 | #include <linux/dlm.h> | ||
26 | #include <linux/dlm_plock.h> | ||
26 | 27 | ||
27 | #include "gfs2.h" | 28 | #include "gfs2.h" |
28 | #include "incore.h" | 29 | #include "incore.h" |
@@ -354,7 +355,9 @@ static int gfs2_page_mkwrite(struct vm_area_struct *vma, struct page *page) | |||
354 | if (ret) | 355 | if (ret) |
355 | goto out; | 356 | goto out; |
356 | 357 | ||
358 | set_bit(GLF_DIRTY, &ip->i_gl->gl_flags); | ||
357 | set_bit(GIF_SW_PAGED, &ip->i_flags); | 359 | set_bit(GIF_SW_PAGED, &ip->i_flags); |
360 | |||
358 | ret = gfs2_write_alloc_required(ip, pos, PAGE_CACHE_SIZE, &alloc_required); | 361 | ret = gfs2_write_alloc_required(ip, pos, PAGE_CACHE_SIZE, &alloc_required); |
359 | if (ret || !alloc_required) | 362 | if (ret || !alloc_required) |
360 | goto out_unlock; | 363 | goto out_unlock; |
@@ -560,57 +563,24 @@ static int gfs2_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
560 | return ret; | 563 | return ret; |
561 | } | 564 | } |
562 | 565 | ||
566 | #ifdef CONFIG_GFS2_FS_LOCKING_DLM | ||
567 | |||
563 | /** | 568 | /** |
564 | * gfs2_setlease - acquire/release a file lease | 569 | * gfs2_setlease - acquire/release a file lease |
565 | * @file: the file pointer | 570 | * @file: the file pointer |
566 | * @arg: lease type | 571 | * @arg: lease type |
567 | * @fl: file lock | 572 | * @fl: file lock |
568 | * | 573 | * |
574 | * We don't currently have a way to enforce a lease across the whole | ||
575 | * cluster; until we do, disable leases (by just returning -EINVAL), | ||
576 | * unless the administrator has requested purely local locking. | ||
577 | * | ||
569 | * Returns: errno | 578 | * Returns: errno |
570 | */ | 579 | */ |
571 | 580 | ||
572 | static int gfs2_setlease(struct file *file, long arg, struct file_lock **fl) | 581 | static int gfs2_setlease(struct file *file, long arg, struct file_lock **fl) |
573 | { | 582 | { |
574 | struct gfs2_sbd *sdp = GFS2_SB(file->f_mapping->host); | 583 | return -EINVAL; |
575 | |||
576 | /* | ||
577 | * We don't currently have a way to enforce a lease across the whole | ||
578 | * cluster; until we do, disable leases (by just returning -EINVAL), | ||
579 | * unless the administrator has requested purely local locking. | ||
580 | */ | ||
581 | if (!sdp->sd_args.ar_localflocks) | ||
582 | return -EINVAL; | ||
583 | return generic_setlease(file, arg, fl); | ||
584 | } | ||
585 | |||
586 | static int gfs2_lm_plock_get(struct gfs2_sbd *sdp, struct lm_lockname *name, | ||
587 | struct file *file, struct file_lock *fl) | ||
588 | { | ||
589 | int error = -EIO; | ||
590 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
591 | error = sdp->sd_lockstruct.ls_ops->lm_plock_get( | ||
592 | sdp->sd_lockstruct.ls_lockspace, name, file, fl); | ||
593 | return error; | ||
594 | } | ||
595 | |||
596 | static int gfs2_lm_plock(struct gfs2_sbd *sdp, struct lm_lockname *name, | ||
597 | struct file *file, int cmd, struct file_lock *fl) | ||
598 | { | ||
599 | int error = -EIO; | ||
600 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
601 | error = sdp->sd_lockstruct.ls_ops->lm_plock( | ||
602 | sdp->sd_lockstruct.ls_lockspace, name, file, cmd, fl); | ||
603 | return error; | ||
604 | } | ||
605 | |||
606 | static int gfs2_lm_punlock(struct gfs2_sbd *sdp, struct lm_lockname *name, | ||
607 | struct file *file, struct file_lock *fl) | ||
608 | { | ||
609 | int error = -EIO; | ||
610 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
611 | error = sdp->sd_lockstruct.ls_ops->lm_punlock( | ||
612 | sdp->sd_lockstruct.ls_lockspace, name, file, fl); | ||
613 | return error; | ||
614 | } | 584 | } |
615 | 585 | ||
616 | /** | 586 | /** |
@@ -626,9 +596,7 @@ static int gfs2_lock(struct file *file, int cmd, struct file_lock *fl) | |||
626 | { | 596 | { |
627 | struct gfs2_inode *ip = GFS2_I(file->f_mapping->host); | 597 | struct gfs2_inode *ip = GFS2_I(file->f_mapping->host); |
628 | struct gfs2_sbd *sdp = GFS2_SB(file->f_mapping->host); | 598 | struct gfs2_sbd *sdp = GFS2_SB(file->f_mapping->host); |
629 | struct lm_lockname name = | 599 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; |
630 | { .ln_number = ip->i_no_addr, | ||
631 | .ln_type = LM_TYPE_PLOCK }; | ||
632 | 600 | ||
633 | if (!(fl->fl_flags & FL_POSIX)) | 601 | if (!(fl->fl_flags & FL_POSIX)) |
634 | return -ENOLCK; | 602 | return -ENOLCK; |
@@ -640,12 +608,14 @@ static int gfs2_lock(struct file *file, int cmd, struct file_lock *fl) | |||
640 | cmd = F_SETLK; | 608 | cmd = F_SETLK; |
641 | fl->fl_type = F_UNLCK; | 609 | fl->fl_type = F_UNLCK; |
642 | } | 610 | } |
611 | if (unlikely(test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | ||
612 | return -EIO; | ||
643 | if (IS_GETLK(cmd)) | 613 | if (IS_GETLK(cmd)) |
644 | return gfs2_lm_plock_get(sdp, &name, file, fl); | 614 | return dlm_posix_get(ls->ls_dlm, ip->i_no_addr, file, fl); |
645 | else if (fl->fl_type == F_UNLCK) | 615 | else if (fl->fl_type == F_UNLCK) |
646 | return gfs2_lm_punlock(sdp, &name, file, fl); | 616 | return dlm_posix_unlock(ls->ls_dlm, ip->i_no_addr, file, fl); |
647 | else | 617 | else |
648 | return gfs2_lm_plock(sdp, &name, file, cmd, fl); | 618 | return dlm_posix_lock(ls->ls_dlm, ip->i_no_addr, file, cmd, fl); |
649 | } | 619 | } |
650 | 620 | ||
651 | static int do_flock(struct file *file, int cmd, struct file_lock *fl) | 621 | static int do_flock(struct file *file, int cmd, struct file_lock *fl) |
@@ -732,7 +702,7 @@ static int gfs2_flock(struct file *file, int cmd, struct file_lock *fl) | |||
732 | } | 702 | } |
733 | } | 703 | } |
734 | 704 | ||
735 | const struct file_operations gfs2_file_fops = { | 705 | const struct file_operations *gfs2_file_fops = &(const struct file_operations){ |
736 | .llseek = gfs2_llseek, | 706 | .llseek = gfs2_llseek, |
737 | .read = do_sync_read, | 707 | .read = do_sync_read, |
738 | .aio_read = generic_file_aio_read, | 708 | .aio_read = generic_file_aio_read, |
@@ -750,7 +720,7 @@ const struct file_operations gfs2_file_fops = { | |||
750 | .setlease = gfs2_setlease, | 720 | .setlease = gfs2_setlease, |
751 | }; | 721 | }; |
752 | 722 | ||
753 | const struct file_operations gfs2_dir_fops = { | 723 | const struct file_operations *gfs2_dir_fops = &(const struct file_operations){ |
754 | .readdir = gfs2_readdir, | 724 | .readdir = gfs2_readdir, |
755 | .unlocked_ioctl = gfs2_ioctl, | 725 | .unlocked_ioctl = gfs2_ioctl, |
756 | .open = gfs2_open, | 726 | .open = gfs2_open, |
@@ -760,7 +730,9 @@ const struct file_operations gfs2_dir_fops = { | |||
760 | .flock = gfs2_flock, | 730 | .flock = gfs2_flock, |
761 | }; | 731 | }; |
762 | 732 | ||
763 | const struct file_operations gfs2_file_fops_nolock = { | 733 | #endif /* CONFIG_GFS2_FS_LOCKING_DLM */ |
734 | |||
735 | const struct file_operations *gfs2_file_fops_nolock = &(const struct file_operations){ | ||
764 | .llseek = gfs2_llseek, | 736 | .llseek = gfs2_llseek, |
765 | .read = do_sync_read, | 737 | .read = do_sync_read, |
766 | .aio_read = generic_file_aio_read, | 738 | .aio_read = generic_file_aio_read, |
@@ -773,10 +745,10 @@ const struct file_operations gfs2_file_fops_nolock = { | |||
773 | .fsync = gfs2_fsync, | 745 | .fsync = gfs2_fsync, |
774 | .splice_read = generic_file_splice_read, | 746 | .splice_read = generic_file_splice_read, |
775 | .splice_write = generic_file_splice_write, | 747 | .splice_write = generic_file_splice_write, |
776 | .setlease = gfs2_setlease, | 748 | .setlease = generic_setlease, |
777 | }; | 749 | }; |
778 | 750 | ||
779 | const struct file_operations gfs2_dir_fops_nolock = { | 751 | const struct file_operations *gfs2_dir_fops_nolock = &(const struct file_operations){ |
780 | .readdir = gfs2_readdir, | 752 | .readdir = gfs2_readdir, |
781 | .unlocked_ioctl = gfs2_ioctl, | 753 | .unlocked_ioctl = gfs2_ioctl, |
782 | .open = gfs2_open, | 754 | .open = gfs2_open, |
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index f91eebdde581..51883b3ad89c 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c | |||
@@ -17,7 +17,6 @@ | |||
17 | #include <linux/namei.h> | 17 | #include <linux/namei.h> |
18 | #include <linux/mount.h> | 18 | #include <linux/mount.h> |
19 | #include <linux/gfs2_ondisk.h> | 19 | #include <linux/gfs2_ondisk.h> |
20 | #include <linux/lm_interface.h> | ||
21 | 20 | ||
22 | #include "gfs2.h" | 21 | #include "gfs2.h" |
23 | #include "incore.h" | 22 | #include "incore.h" |
@@ -25,7 +24,6 @@ | |||
25 | #include "glock.h" | 24 | #include "glock.h" |
26 | #include "glops.h" | 25 | #include "glops.h" |
27 | #include "inode.h" | 26 | #include "inode.h" |
28 | #include "mount.h" | ||
29 | #include "recovery.h" | 27 | #include "recovery.h" |
30 | #include "rgrp.h" | 28 | #include "rgrp.h" |
31 | #include "super.h" | 29 | #include "super.h" |
@@ -64,7 +62,6 @@ static void gfs2_tune_init(struct gfs2_tune *gt) | |||
64 | gt->gt_quota_warn_period = 10; | 62 | gt->gt_quota_warn_period = 10; |
65 | gt->gt_quota_scale_num = 1; | 63 | gt->gt_quota_scale_num = 1; |
66 | gt->gt_quota_scale_den = 1; | 64 | gt->gt_quota_scale_den = 1; |
67 | gt->gt_quota_cache_secs = 300; | ||
68 | gt->gt_quota_quantum = 60; | 65 | gt->gt_quota_quantum = 60; |
69 | gt->gt_new_files_jdata = 0; | 66 | gt->gt_new_files_jdata = 0; |
70 | gt->gt_max_readahead = 1 << 18; | 67 | gt->gt_max_readahead = 1 << 18; |
@@ -100,7 +97,6 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) | |||
100 | mutex_init(&sdp->sd_jindex_mutex); | 97 | mutex_init(&sdp->sd_jindex_mutex); |
101 | 98 | ||
102 | INIT_LIST_HEAD(&sdp->sd_quota_list); | 99 | INIT_LIST_HEAD(&sdp->sd_quota_list); |
103 | spin_lock_init(&sdp->sd_quota_spin); | ||
104 | mutex_init(&sdp->sd_quota_mutex); | 100 | mutex_init(&sdp->sd_quota_mutex); |
105 | init_waitqueue_head(&sdp->sd_quota_wait); | 101 | init_waitqueue_head(&sdp->sd_quota_wait); |
106 | INIT_LIST_HEAD(&sdp->sd_trunc_list); | 102 | INIT_LIST_HEAD(&sdp->sd_trunc_list); |
@@ -238,6 +234,7 @@ static void gfs2_sb_in(struct gfs2_sb_host *sb, const void *buf) | |||
238 | 234 | ||
239 | memcpy(sb->sb_lockproto, str->sb_lockproto, GFS2_LOCKNAME_LEN); | 235 | memcpy(sb->sb_lockproto, str->sb_lockproto, GFS2_LOCKNAME_LEN); |
240 | memcpy(sb->sb_locktable, str->sb_locktable, GFS2_LOCKNAME_LEN); | 236 | memcpy(sb->sb_locktable, str->sb_locktable, GFS2_LOCKNAME_LEN); |
237 | memcpy(sb->sb_uuid, str->sb_uuid, 16); | ||
241 | } | 238 | } |
242 | 239 | ||
243 | /** | 240 | /** |
@@ -299,15 +296,15 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector) | |||
299 | __free_page(page); | 296 | __free_page(page); |
300 | return 0; | 297 | return 0; |
301 | } | 298 | } |
299 | |||
302 | /** | 300 | /** |
303 | * gfs2_read_sb - Read super block | 301 | * gfs2_read_sb - Read super block |
304 | * @sdp: The GFS2 superblock | 302 | * @sdp: The GFS2 superblock |
305 | * @gl: the glock for the superblock (assumed to be held) | ||
306 | * @silent: Don't print message if mount fails | 303 | * @silent: Don't print message if mount fails |
307 | * | 304 | * |
308 | */ | 305 | */ |
309 | 306 | ||
310 | static int gfs2_read_sb(struct gfs2_sbd *sdp, struct gfs2_glock *gl, int silent) | 307 | static int gfs2_read_sb(struct gfs2_sbd *sdp, int silent) |
311 | { | 308 | { |
312 | u32 hash_blocks, ind_blocks, leaf_blocks; | 309 | u32 hash_blocks, ind_blocks, leaf_blocks; |
313 | u32 tmp_blocks; | 310 | u32 tmp_blocks; |
@@ -527,7 +524,7 @@ static int init_sb(struct gfs2_sbd *sdp, int silent) | |||
527 | return ret; | 524 | return ret; |
528 | } | 525 | } |
529 | 526 | ||
530 | ret = gfs2_read_sb(sdp, sb_gh.gh_gl, silent); | 527 | ret = gfs2_read_sb(sdp, silent); |
531 | if (ret) { | 528 | if (ret) { |
532 | fs_err(sdp, "can't read superblock: %d\n", ret); | 529 | fs_err(sdp, "can't read superblock: %d\n", ret); |
533 | goto out; | 530 | goto out; |
@@ -630,13 +627,13 @@ static int map_journal_extents(struct gfs2_sbd *sdp) | |||
630 | return rc; | 627 | return rc; |
631 | } | 628 | } |
632 | 629 | ||
633 | static void gfs2_lm_others_may_mount(struct gfs2_sbd *sdp) | 630 | static void gfs2_others_may_mount(struct gfs2_sbd *sdp) |
634 | { | 631 | { |
635 | if (!sdp->sd_lockstruct.ls_ops->lm_others_may_mount) | 632 | char *message = "FIRSTMOUNT=Done"; |
636 | return; | 633 | char *envp[] = { message, NULL }; |
637 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | 634 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; |
638 | sdp->sd_lockstruct.ls_ops->lm_others_may_mount( | 635 | ls->ls_first_done = 1; |
639 | sdp->sd_lockstruct.ls_lockspace); | 636 | kobject_uevent_env(&sdp->sd_kobj, KOBJ_CHANGE, envp); |
640 | } | 637 | } |
641 | 638 | ||
642 | /** | 639 | /** |
@@ -796,7 +793,7 @@ static int init_journal(struct gfs2_sbd *sdp, int undo) | |||
796 | } | 793 | } |
797 | } | 794 | } |
798 | 795 | ||
799 | gfs2_lm_others_may_mount(sdp); | 796 | gfs2_others_may_mount(sdp); |
800 | } else if (!sdp->sd_args.ar_spectator) { | 797 | } else if (!sdp->sd_args.ar_spectator) { |
801 | error = gfs2_recover_journal(sdp->sd_jdesc); | 798 | error = gfs2_recover_journal(sdp->sd_jdesc); |
802 | if (error) { | 799 | if (error) { |
@@ -1005,7 +1002,6 @@ static int init_threads(struct gfs2_sbd *sdp, int undo) | |||
1005 | goto fail_quotad; | 1002 | goto fail_quotad; |
1006 | 1003 | ||
1007 | sdp->sd_log_flush_time = jiffies; | 1004 | sdp->sd_log_flush_time = jiffies; |
1008 | sdp->sd_jindex_refresh_time = jiffies; | ||
1009 | 1005 | ||
1010 | p = kthread_run(gfs2_logd, sdp, "gfs2_logd"); | 1006 | p = kthread_run(gfs2_logd, sdp, "gfs2_logd"); |
1011 | error = IS_ERR(p); | 1007 | error = IS_ERR(p); |
@@ -1033,6 +1029,17 @@ fail: | |||
1033 | return error; | 1029 | return error; |
1034 | } | 1030 | } |
1035 | 1031 | ||
1032 | static const match_table_t nolock_tokens = { | ||
1033 | { Opt_jid, "jid=%d\n", }, | ||
1034 | { Opt_err, NULL }, | ||
1035 | }; | ||
1036 | |||
1037 | static const struct lm_lockops nolock_ops = { | ||
1038 | .lm_proto_name = "lock_nolock", | ||
1039 | .lm_put_lock = kmem_cache_free, | ||
1040 | .lm_tokens = &nolock_tokens, | ||
1041 | }; | ||
1042 | |||
1036 | /** | 1043 | /** |
1037 | * gfs2_lm_mount - mount a locking protocol | 1044 | * gfs2_lm_mount - mount a locking protocol |
1038 | * @sdp: the filesystem | 1045 | * @sdp: the filesystem |
@@ -1044,31 +1051,73 @@ fail: | |||
1044 | 1051 | ||
1045 | static int gfs2_lm_mount(struct gfs2_sbd *sdp, int silent) | 1052 | static int gfs2_lm_mount(struct gfs2_sbd *sdp, int silent) |
1046 | { | 1053 | { |
1047 | char *proto = sdp->sd_proto_name; | 1054 | const struct lm_lockops *lm; |
1048 | char *table = sdp->sd_table_name; | 1055 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; |
1049 | int flags = LM_MFLAG_CONV_NODROP; | 1056 | struct gfs2_args *args = &sdp->sd_args; |
1050 | int error; | 1057 | const char *proto = sdp->sd_proto_name; |
1058 | const char *table = sdp->sd_table_name; | ||
1059 | const char *fsname; | ||
1060 | char *o, *options; | ||
1061 | int ret; | ||
1051 | 1062 | ||
1052 | if (sdp->sd_args.ar_spectator) | 1063 | if (!strcmp("lock_nolock", proto)) { |
1053 | flags |= LM_MFLAG_SPECTATOR; | 1064 | lm = &nolock_ops; |
1065 | sdp->sd_args.ar_localflocks = 1; | ||
1066 | sdp->sd_args.ar_localcaching = 1; | ||
1067 | #ifdef CONFIG_GFS2_FS_LOCKING_DLM | ||
1068 | } else if (!strcmp("lock_dlm", proto)) { | ||
1069 | lm = &gfs2_dlm_ops; | ||
1070 | #endif | ||
1071 | } else { | ||
1072 | printk(KERN_INFO "GFS2: can't find protocol %s\n", proto); | ||
1073 | return -ENOENT; | ||
1074 | } | ||
1054 | 1075 | ||
1055 | fs_info(sdp, "Trying to join cluster \"%s\", \"%s\"\n", proto, table); | 1076 | fs_info(sdp, "Trying to join cluster \"%s\", \"%s\"\n", proto, table); |
1056 | 1077 | ||
1057 | error = gfs2_mount_lockproto(proto, table, sdp->sd_args.ar_hostdata, | 1078 | ls->ls_ops = lm; |
1058 | gfs2_glock_cb, sdp, | 1079 | ls->ls_first = 1; |
1059 | GFS2_MIN_LVB_SIZE, flags, | 1080 | ls->ls_id = 0; |
1060 | &sdp->sd_lockstruct, &sdp->sd_kobj); | ||
1061 | if (error) { | ||
1062 | fs_info(sdp, "can't mount proto=%s, table=%s, hostdata=%s\n", | ||
1063 | proto, table, sdp->sd_args.ar_hostdata); | ||
1064 | goto out; | ||
1065 | } | ||
1066 | 1081 | ||
1067 | if (gfs2_assert_warn(sdp, sdp->sd_lockstruct.ls_ops) || | 1082 | for (options = args->ar_hostdata; (o = strsep(&options, ":")); ) { |
1068 | gfs2_assert_warn(sdp, sdp->sd_lockstruct.ls_lvb_size >= | 1083 | substring_t tmp[MAX_OPT_ARGS]; |
1069 | GFS2_MIN_LVB_SIZE)) { | 1084 | int token, option; |
1070 | gfs2_unmount_lockproto(&sdp->sd_lockstruct); | 1085 | |
1071 | goto out; | 1086 | if (!o || !*o) |
1087 | continue; | ||
1088 | |||
1089 | token = match_token(o, *lm->lm_tokens, tmp); | ||
1090 | switch (token) { | ||
1091 | case Opt_jid: | ||
1092 | ret = match_int(&tmp[0], &option); | ||
1093 | if (ret || option < 0) | ||
1094 | goto hostdata_error; | ||
1095 | ls->ls_jid = option; | ||
1096 | break; | ||
1097 | case Opt_id: | ||
1098 | ret = match_int(&tmp[0], &option); | ||
1099 | if (ret) | ||
1100 | goto hostdata_error; | ||
1101 | ls->ls_id = option; | ||
1102 | break; | ||
1103 | case Opt_first: | ||
1104 | ret = match_int(&tmp[0], &option); | ||
1105 | if (ret || (option != 0 && option != 1)) | ||
1106 | goto hostdata_error; | ||
1107 | ls->ls_first = option; | ||
1108 | break; | ||
1109 | case Opt_nodir: | ||
1110 | ret = match_int(&tmp[0], &option); | ||
1111 | if (ret || (option != 0 && option != 1)) | ||
1112 | goto hostdata_error; | ||
1113 | ls->ls_nodir = option; | ||
1114 | break; | ||
1115 | case Opt_err: | ||
1116 | default: | ||
1117 | hostdata_error: | ||
1118 | fs_info(sdp, "unknown hostdata (%s)\n", o); | ||
1119 | return -EINVAL; | ||
1120 | } | ||
1072 | } | 1121 | } |
1073 | 1122 | ||
1074 | if (sdp->sd_args.ar_spectator) | 1123 | if (sdp->sd_args.ar_spectator) |
@@ -1077,22 +1126,25 @@ static int gfs2_lm_mount(struct gfs2_sbd *sdp, int silent) | |||
1077 | snprintf(sdp->sd_fsname, GFS2_FSNAME_LEN, "%s.%u", table, | 1126 | snprintf(sdp->sd_fsname, GFS2_FSNAME_LEN, "%s.%u", table, |
1078 | sdp->sd_lockstruct.ls_jid); | 1127 | sdp->sd_lockstruct.ls_jid); |
1079 | 1128 | ||
1080 | fs_info(sdp, "Joined cluster. Now mounting FS...\n"); | 1129 | fsname = strchr(table, ':'); |
1081 | 1130 | if (fsname) | |
1082 | if ((sdp->sd_lockstruct.ls_flags & LM_LSFLAG_LOCAL) && | 1131 | fsname++; |
1083 | !sdp->sd_args.ar_ignore_local_fs) { | 1132 | if (lm->lm_mount == NULL) { |
1084 | sdp->sd_args.ar_localflocks = 1; | 1133 | fs_info(sdp, "Now mounting FS...\n"); |
1085 | sdp->sd_args.ar_localcaching = 1; | 1134 | return 0; |
1086 | } | 1135 | } |
1087 | 1136 | ret = lm->lm_mount(sdp, fsname); | |
1088 | out: | 1137 | if (ret == 0) |
1089 | return error; | 1138 | fs_info(sdp, "Joined cluster. Now mounting FS...\n"); |
1139 | return ret; | ||
1090 | } | 1140 | } |
1091 | 1141 | ||
1092 | void gfs2_lm_unmount(struct gfs2_sbd *sdp) | 1142 | void gfs2_lm_unmount(struct gfs2_sbd *sdp) |
1093 | { | 1143 | { |
1094 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | 1144 | const struct lm_lockops *lm = sdp->sd_lockstruct.ls_ops; |
1095 | gfs2_unmount_lockproto(&sdp->sd_lockstruct); | 1145 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags)) && |
1146 | lm->lm_unmount) | ||
1147 | lm->lm_unmount(sdp); | ||
1096 | } | 1148 | } |
1097 | 1149 | ||
1098 | /** | 1150 | /** |
@@ -1116,12 +1168,20 @@ static int fill_super(struct super_block *sb, void *data, int silent) | |||
1116 | return -ENOMEM; | 1168 | return -ENOMEM; |
1117 | } | 1169 | } |
1118 | 1170 | ||
1119 | error = gfs2_mount_args(sdp, (char *)data, 0); | 1171 | sdp->sd_args.ar_quota = GFS2_QUOTA_DEFAULT; |
1172 | sdp->sd_args.ar_data = GFS2_DATA_DEFAULT; | ||
1173 | |||
1174 | error = gfs2_mount_args(sdp, &sdp->sd_args, data); | ||
1120 | if (error) { | 1175 | if (error) { |
1121 | printk(KERN_WARNING "GFS2: can't parse mount arguments\n"); | 1176 | printk(KERN_WARNING "GFS2: can't parse mount arguments\n"); |
1122 | goto fail; | 1177 | goto fail; |
1123 | } | 1178 | } |
1124 | 1179 | ||
1180 | if (sdp->sd_args.ar_spectator) | ||
1181 | sb->s_flags |= MS_RDONLY; | ||
1182 | if (sdp->sd_args.ar_posix_acl) | ||
1183 | sb->s_flags |= MS_POSIXACL; | ||
1184 | |||
1125 | sb->s_magic = GFS2_MAGIC; | 1185 | sb->s_magic = GFS2_MAGIC; |
1126 | sb->s_op = &gfs2_super_ops; | 1186 | sb->s_op = &gfs2_super_ops; |
1127 | sb->s_export_op = &gfs2_export_ops; | 1187 | sb->s_export_op = &gfs2_export_ops; |
@@ -1199,6 +1259,8 @@ fail_sb: | |||
1199 | dput(sdp->sd_root_dir); | 1259 | dput(sdp->sd_root_dir); |
1200 | if (sdp->sd_master_dir) | 1260 | if (sdp->sd_master_dir) |
1201 | dput(sdp->sd_master_dir); | 1261 | dput(sdp->sd_master_dir); |
1262 | if (sb->s_root) | ||
1263 | dput(sb->s_root); | ||
1202 | sb->s_root = NULL; | 1264 | sb->s_root = NULL; |
1203 | fail_locking: | 1265 | fail_locking: |
1204 | init_locking(sdp, &mount_gh, UNDO); | 1266 | init_locking(sdp, &mount_gh, UNDO); |
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 49877546beb9..abd5429ae285 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
@@ -18,7 +18,6 @@ | |||
18 | #include <linux/posix_acl.h> | 18 | #include <linux/posix_acl.h> |
19 | #include <linux/gfs2_ondisk.h> | 19 | #include <linux/gfs2_ondisk.h> |
20 | #include <linux/crc32.h> | 20 | #include <linux/crc32.h> |
21 | #include <linux/lm_interface.h> | ||
22 | #include <linux/fiemap.h> | 21 | #include <linux/fiemap.h> |
23 | #include <asm/uaccess.h> | 22 | #include <asm/uaccess.h> |
24 | 23 | ||
diff --git a/fs/gfs2/ops_super.c b/fs/gfs2/ops_super.c index 320323d03479..458019569dcb 100644 --- a/fs/gfs2/ops_super.c +++ b/fs/gfs2/ops_super.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/delay.h> | 19 | #include <linux/delay.h> |
20 | #include <linux/gfs2_ondisk.h> | 20 | #include <linux/gfs2_ondisk.h> |
21 | #include <linux/crc32.h> | 21 | #include <linux/crc32.h> |
22 | #include <linux/lm_interface.h> | ||
23 | #include <linux/time.h> | 22 | #include <linux/time.h> |
24 | 23 | ||
25 | #include "gfs2.h" | 24 | #include "gfs2.h" |
@@ -27,7 +26,6 @@ | |||
27 | #include "glock.h" | 26 | #include "glock.h" |
28 | #include "inode.h" | 27 | #include "inode.h" |
29 | #include "log.h" | 28 | #include "log.h" |
30 | #include "mount.h" | ||
31 | #include "quota.h" | 29 | #include "quota.h" |
32 | #include "recovery.h" | 30 | #include "recovery.h" |
33 | #include "rgrp.h" | 31 | #include "rgrp.h" |
@@ -40,6 +38,8 @@ | |||
40 | #include "bmap.h" | 38 | #include "bmap.h" |
41 | #include "meta_io.h" | 39 | #include "meta_io.h" |
42 | 40 | ||
41 | #define args_neq(a1, a2, x) ((a1)->ar_##x != (a2)->ar_##x) | ||
42 | |||
43 | /** | 43 | /** |
44 | * gfs2_write_inode - Make sure the inode is stable on the disk | 44 | * gfs2_write_inode - Make sure the inode is stable on the disk |
45 | * @inode: The inode | 45 | * @inode: The inode |
@@ -435,25 +435,45 @@ static int gfs2_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
435 | static int gfs2_remount_fs(struct super_block *sb, int *flags, char *data) | 435 | static int gfs2_remount_fs(struct super_block *sb, int *flags, char *data) |
436 | { | 436 | { |
437 | struct gfs2_sbd *sdp = sb->s_fs_info; | 437 | struct gfs2_sbd *sdp = sb->s_fs_info; |
438 | struct gfs2_args args = sdp->sd_args; /* Default to current settings */ | ||
438 | int error; | 439 | int error; |
439 | 440 | ||
440 | error = gfs2_mount_args(sdp, data, 1); | 441 | error = gfs2_mount_args(sdp, &args, data); |
441 | if (error) | 442 | if (error) |
442 | return error; | 443 | return error; |
443 | 444 | ||
445 | /* Not allowed to change locking details */ | ||
446 | if (strcmp(args.ar_lockproto, sdp->sd_args.ar_lockproto) || | ||
447 | strcmp(args.ar_locktable, sdp->sd_args.ar_locktable) || | ||
448 | strcmp(args.ar_hostdata, sdp->sd_args.ar_hostdata)) | ||
449 | return -EINVAL; | ||
450 | |||
451 | /* Some flags must not be changed */ | ||
452 | if (args_neq(&args, &sdp->sd_args, spectator) || | ||
453 | args_neq(&args, &sdp->sd_args, ignore_local_fs) || | ||
454 | args_neq(&args, &sdp->sd_args, localflocks) || | ||
455 | args_neq(&args, &sdp->sd_args, localcaching) || | ||
456 | args_neq(&args, &sdp->sd_args, meta)) | ||
457 | return -EINVAL; | ||
458 | |||
444 | if (sdp->sd_args.ar_spectator) | 459 | if (sdp->sd_args.ar_spectator) |
445 | *flags |= MS_RDONLY; | 460 | *flags |= MS_RDONLY; |
446 | else { | 461 | |
447 | if (*flags & MS_RDONLY) { | 462 | if ((sb->s_flags ^ *flags) & MS_RDONLY) { |
448 | if (!(sb->s_flags & MS_RDONLY)) | 463 | if (*flags & MS_RDONLY) |
449 | error = gfs2_make_fs_ro(sdp); | 464 | error = gfs2_make_fs_ro(sdp); |
450 | } else if (!(*flags & MS_RDONLY) && | 465 | else |
451 | (sb->s_flags & MS_RDONLY)) { | ||
452 | error = gfs2_make_fs_rw(sdp); | 466 | error = gfs2_make_fs_rw(sdp); |
453 | } | 467 | if (error) |
468 | return error; | ||
454 | } | 469 | } |
455 | 470 | ||
456 | return error; | 471 | sdp->sd_args = args; |
472 | if (sdp->sd_args.ar_posix_acl) | ||
473 | sb->s_flags |= MS_POSIXACL; | ||
474 | else | ||
475 | sb->s_flags &= ~MS_POSIXACL; | ||
476 | return 0; | ||
457 | } | 477 | } |
458 | 478 | ||
459 | /** | 479 | /** |
@@ -588,6 +608,8 @@ static int gfs2_show_options(struct seq_file *s, struct vfsmount *mnt) | |||
588 | } | 608 | } |
589 | seq_printf(s, ",data=%s", state); | 609 | seq_printf(s, ",data=%s", state); |
590 | } | 610 | } |
611 | if (args->ar_discard) | ||
612 | seq_printf(s, ",discard"); | ||
591 | 613 | ||
592 | return 0; | 614 | return 0; |
593 | } | 615 | } |
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index b08d09696b3e..8d53f66b5bcc 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c | |||
@@ -45,7 +45,6 @@ | |||
45 | #include <linux/fs.h> | 45 | #include <linux/fs.h> |
46 | #include <linux/bio.h> | 46 | #include <linux/bio.h> |
47 | #include <linux/gfs2_ondisk.h> | 47 | #include <linux/gfs2_ondisk.h> |
48 | #include <linux/lm_interface.h> | ||
49 | #include <linux/kthread.h> | 48 | #include <linux/kthread.h> |
50 | #include <linux/freezer.h> | 49 | #include <linux/freezer.h> |
51 | 50 | ||
@@ -80,6 +79,51 @@ struct gfs2_quota_change_host { | |||
80 | u32 qc_id; | 79 | u32 qc_id; |
81 | }; | 80 | }; |
82 | 81 | ||
82 | static LIST_HEAD(qd_lru_list); | ||
83 | static atomic_t qd_lru_count = ATOMIC_INIT(0); | ||
84 | static spinlock_t qd_lru_lock = SPIN_LOCK_UNLOCKED; | ||
85 | |||
86 | int gfs2_shrink_qd_memory(int nr, gfp_t gfp_mask) | ||
87 | { | ||
88 | struct gfs2_quota_data *qd; | ||
89 | struct gfs2_sbd *sdp; | ||
90 | |||
91 | if (nr == 0) | ||
92 | goto out; | ||
93 | |||
94 | if (!(gfp_mask & __GFP_FS)) | ||
95 | return -1; | ||
96 | |||
97 | spin_lock(&qd_lru_lock); | ||
98 | while (nr && !list_empty(&qd_lru_list)) { | ||
99 | qd = list_entry(qd_lru_list.next, | ||
100 | struct gfs2_quota_data, qd_reclaim); | ||
101 | sdp = qd->qd_gl->gl_sbd; | ||
102 | |||
103 | /* Free from the filesystem-specific list */ | ||
104 | list_del(&qd->qd_list); | ||
105 | |||
106 | gfs2_assert_warn(sdp, !qd->qd_change); | ||
107 | gfs2_assert_warn(sdp, !qd->qd_slot_count); | ||
108 | gfs2_assert_warn(sdp, !qd->qd_bh_count); | ||
109 | |||
110 | gfs2_glock_put(qd->qd_gl); | ||
111 | atomic_dec(&sdp->sd_quota_count); | ||
112 | |||
113 | /* Delete it from the common reclaim list */ | ||
114 | list_del_init(&qd->qd_reclaim); | ||
115 | atomic_dec(&qd_lru_count); | ||
116 | spin_unlock(&qd_lru_lock); | ||
117 | kmem_cache_free(gfs2_quotad_cachep, qd); | ||
118 | spin_lock(&qd_lru_lock); | ||
119 | nr--; | ||
120 | } | ||
121 | spin_unlock(&qd_lru_lock); | ||
122 | |||
123 | out: | ||
124 | return (atomic_read(&qd_lru_count) * sysctl_vfs_cache_pressure) / 100; | ||
125 | } | ||
126 | |||
83 | static u64 qd2offset(struct gfs2_quota_data *qd) | 127 | static u64 qd2offset(struct gfs2_quota_data *qd) |
84 | { | 128 | { |
85 | u64 offset; | 129 | u64 offset; |
@@ -100,22 +144,18 @@ static int qd_alloc(struct gfs2_sbd *sdp, int user, u32 id, | |||
100 | if (!qd) | 144 | if (!qd) |
101 | return -ENOMEM; | 145 | return -ENOMEM; |
102 | 146 | ||
103 | qd->qd_count = 1; | 147 | atomic_set(&qd->qd_count, 1); |
104 | qd->qd_id = id; | 148 | qd->qd_id = id; |
105 | if (user) | 149 | if (user) |
106 | set_bit(QDF_USER, &qd->qd_flags); | 150 | set_bit(QDF_USER, &qd->qd_flags); |
107 | qd->qd_slot = -1; | 151 | qd->qd_slot = -1; |
152 | INIT_LIST_HEAD(&qd->qd_reclaim); | ||
108 | 153 | ||
109 | error = gfs2_glock_get(sdp, 2 * (u64)id + !user, | 154 | error = gfs2_glock_get(sdp, 2 * (u64)id + !user, |
110 | &gfs2_quota_glops, CREATE, &qd->qd_gl); | 155 | &gfs2_quota_glops, CREATE, &qd->qd_gl); |
111 | if (error) | 156 | if (error) |
112 | goto fail; | 157 | goto fail; |
113 | 158 | ||
114 | error = gfs2_lvb_hold(qd->qd_gl); | ||
115 | gfs2_glock_put(qd->qd_gl); | ||
116 | if (error) | ||
117 | goto fail; | ||
118 | |||
119 | *qdp = qd; | 159 | *qdp = qd; |
120 | 160 | ||
121 | return 0; | 161 | return 0; |
@@ -135,11 +175,17 @@ static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | |||
135 | 175 | ||
136 | for (;;) { | 176 | for (;;) { |
137 | found = 0; | 177 | found = 0; |
138 | spin_lock(&sdp->sd_quota_spin); | 178 | spin_lock(&qd_lru_lock); |
139 | list_for_each_entry(qd, &sdp->sd_quota_list, qd_list) { | 179 | list_for_each_entry(qd, &sdp->sd_quota_list, qd_list) { |
140 | if (qd->qd_id == id && | 180 | if (qd->qd_id == id && |
141 | !test_bit(QDF_USER, &qd->qd_flags) == !user) { | 181 | !test_bit(QDF_USER, &qd->qd_flags) == !user) { |
142 | qd->qd_count++; | 182 | if (!atomic_read(&qd->qd_count) && |
183 | !list_empty(&qd->qd_reclaim)) { | ||
184 | /* Remove it from reclaim list */ | ||
185 | list_del_init(&qd->qd_reclaim); | ||
186 | atomic_dec(&qd_lru_count); | ||
187 | } | ||
188 | atomic_inc(&qd->qd_count); | ||
143 | found = 1; | 189 | found = 1; |
144 | break; | 190 | break; |
145 | } | 191 | } |
@@ -155,11 +201,11 @@ static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | |||
155 | new_qd = NULL; | 201 | new_qd = NULL; |
156 | } | 202 | } |
157 | 203 | ||
158 | spin_unlock(&sdp->sd_quota_spin); | 204 | spin_unlock(&qd_lru_lock); |
159 | 205 | ||
160 | if (qd || !create) { | 206 | if (qd || !create) { |
161 | if (new_qd) { | 207 | if (new_qd) { |
162 | gfs2_lvb_unhold(new_qd->qd_gl); | 208 | gfs2_glock_put(new_qd->qd_gl); |
163 | kmem_cache_free(gfs2_quotad_cachep, new_qd); | 209 | kmem_cache_free(gfs2_quotad_cachep, new_qd); |
164 | } | 210 | } |
165 | *qdp = qd; | 211 | *qdp = qd; |
@@ -175,21 +221,18 @@ static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | |||
175 | static void qd_hold(struct gfs2_quota_data *qd) | 221 | static void qd_hold(struct gfs2_quota_data *qd) |
176 | { | 222 | { |
177 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 223 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; |
178 | 224 | gfs2_assert(sdp, atomic_read(&qd->qd_count)); | |
179 | spin_lock(&sdp->sd_quota_spin); | 225 | atomic_inc(&qd->qd_count); |
180 | gfs2_assert(sdp, qd->qd_count); | ||
181 | qd->qd_count++; | ||
182 | spin_unlock(&sdp->sd_quota_spin); | ||
183 | } | 226 | } |
184 | 227 | ||
185 | static void qd_put(struct gfs2_quota_data *qd) | 228 | static void qd_put(struct gfs2_quota_data *qd) |
186 | { | 229 | { |
187 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 230 | if (atomic_dec_and_lock(&qd->qd_count, &qd_lru_lock)) { |
188 | spin_lock(&sdp->sd_quota_spin); | 231 | /* Add to the reclaim list */ |
189 | gfs2_assert(sdp, qd->qd_count); | 232 | list_add_tail(&qd->qd_reclaim, &qd_lru_list); |
190 | if (!--qd->qd_count) | 233 | atomic_inc(&qd_lru_count); |
191 | qd->qd_last_touched = jiffies; | 234 | spin_unlock(&qd_lru_lock); |
192 | spin_unlock(&sdp->sd_quota_spin); | 235 | } |
193 | } | 236 | } |
194 | 237 | ||
195 | static int slot_get(struct gfs2_quota_data *qd) | 238 | static int slot_get(struct gfs2_quota_data *qd) |
@@ -198,10 +241,10 @@ static int slot_get(struct gfs2_quota_data *qd) | |||
198 | unsigned int c, o = 0, b; | 241 | unsigned int c, o = 0, b; |
199 | unsigned char byte = 0; | 242 | unsigned char byte = 0; |
200 | 243 | ||
201 | spin_lock(&sdp->sd_quota_spin); | 244 | spin_lock(&qd_lru_lock); |
202 | 245 | ||
203 | if (qd->qd_slot_count++) { | 246 | if (qd->qd_slot_count++) { |
204 | spin_unlock(&sdp->sd_quota_spin); | 247 | spin_unlock(&qd_lru_lock); |
205 | return 0; | 248 | return 0; |
206 | } | 249 | } |
207 | 250 | ||
@@ -225,13 +268,13 @@ found: | |||
225 | 268 | ||
226 | sdp->sd_quota_bitmap[c][o] |= 1 << b; | 269 | sdp->sd_quota_bitmap[c][o] |= 1 << b; |
227 | 270 | ||
228 | spin_unlock(&sdp->sd_quota_spin); | 271 | spin_unlock(&qd_lru_lock); |
229 | 272 | ||
230 | return 0; | 273 | return 0; |
231 | 274 | ||
232 | fail: | 275 | fail: |
233 | qd->qd_slot_count--; | 276 | qd->qd_slot_count--; |
234 | spin_unlock(&sdp->sd_quota_spin); | 277 | spin_unlock(&qd_lru_lock); |
235 | return -ENOSPC; | 278 | return -ENOSPC; |
236 | } | 279 | } |
237 | 280 | ||
@@ -239,23 +282,23 @@ static void slot_hold(struct gfs2_quota_data *qd) | |||
239 | { | 282 | { |
240 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 283 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; |
241 | 284 | ||
242 | spin_lock(&sdp->sd_quota_spin); | 285 | spin_lock(&qd_lru_lock); |
243 | gfs2_assert(sdp, qd->qd_slot_count); | 286 | gfs2_assert(sdp, qd->qd_slot_count); |
244 | qd->qd_slot_count++; | 287 | qd->qd_slot_count++; |
245 | spin_unlock(&sdp->sd_quota_spin); | 288 | spin_unlock(&qd_lru_lock); |
246 | } | 289 | } |
247 | 290 | ||
248 | static void slot_put(struct gfs2_quota_data *qd) | 291 | static void slot_put(struct gfs2_quota_data *qd) |
249 | { | 292 | { |
250 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 293 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; |
251 | 294 | ||
252 | spin_lock(&sdp->sd_quota_spin); | 295 | spin_lock(&qd_lru_lock); |
253 | gfs2_assert(sdp, qd->qd_slot_count); | 296 | gfs2_assert(sdp, qd->qd_slot_count); |
254 | if (!--qd->qd_slot_count) { | 297 | if (!--qd->qd_slot_count) { |
255 | gfs2_icbit_munge(sdp, sdp->sd_quota_bitmap, qd->qd_slot, 0); | 298 | gfs2_icbit_munge(sdp, sdp->sd_quota_bitmap, qd->qd_slot, 0); |
256 | qd->qd_slot = -1; | 299 | qd->qd_slot = -1; |
257 | } | 300 | } |
258 | spin_unlock(&sdp->sd_quota_spin); | 301 | spin_unlock(&qd_lru_lock); |
259 | } | 302 | } |
260 | 303 | ||
261 | static int bh_get(struct gfs2_quota_data *qd) | 304 | static int bh_get(struct gfs2_quota_data *qd) |
@@ -330,7 +373,7 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp) | |||
330 | if (sdp->sd_vfs->s_flags & MS_RDONLY) | 373 | if (sdp->sd_vfs->s_flags & MS_RDONLY) |
331 | return 0; | 374 | return 0; |
332 | 375 | ||
333 | spin_lock(&sdp->sd_quota_spin); | 376 | spin_lock(&qd_lru_lock); |
334 | 377 | ||
335 | list_for_each_entry(qd, &sdp->sd_quota_list, qd_list) { | 378 | list_for_each_entry(qd, &sdp->sd_quota_list, qd_list) { |
336 | if (test_bit(QDF_LOCKED, &qd->qd_flags) || | 379 | if (test_bit(QDF_LOCKED, &qd->qd_flags) || |
@@ -341,8 +384,8 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp) | |||
341 | list_move_tail(&qd->qd_list, &sdp->sd_quota_list); | 384 | list_move_tail(&qd->qd_list, &sdp->sd_quota_list); |
342 | 385 | ||
343 | set_bit(QDF_LOCKED, &qd->qd_flags); | 386 | set_bit(QDF_LOCKED, &qd->qd_flags); |
344 | gfs2_assert_warn(sdp, qd->qd_count); | 387 | gfs2_assert_warn(sdp, atomic_read(&qd->qd_count)); |
345 | qd->qd_count++; | 388 | atomic_inc(&qd->qd_count); |
346 | qd->qd_change_sync = qd->qd_change; | 389 | qd->qd_change_sync = qd->qd_change; |
347 | gfs2_assert_warn(sdp, qd->qd_slot_count); | 390 | gfs2_assert_warn(sdp, qd->qd_slot_count); |
348 | qd->qd_slot_count++; | 391 | qd->qd_slot_count++; |
@@ -354,7 +397,7 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp) | |||
354 | if (!found) | 397 | if (!found) |
355 | qd = NULL; | 398 | qd = NULL; |
356 | 399 | ||
357 | spin_unlock(&sdp->sd_quota_spin); | 400 | spin_unlock(&qd_lru_lock); |
358 | 401 | ||
359 | if (qd) { | 402 | if (qd) { |
360 | gfs2_assert_warn(sdp, qd->qd_change_sync); | 403 | gfs2_assert_warn(sdp, qd->qd_change_sync); |
@@ -379,24 +422,24 @@ static int qd_trylock(struct gfs2_quota_data *qd) | |||
379 | if (sdp->sd_vfs->s_flags & MS_RDONLY) | 422 | if (sdp->sd_vfs->s_flags & MS_RDONLY) |
380 | return 0; | 423 | return 0; |
381 | 424 | ||
382 | spin_lock(&sdp->sd_quota_spin); | 425 | spin_lock(&qd_lru_lock); |
383 | 426 | ||
384 | if (test_bit(QDF_LOCKED, &qd->qd_flags) || | 427 | if (test_bit(QDF_LOCKED, &qd->qd_flags) || |
385 | !test_bit(QDF_CHANGE, &qd->qd_flags)) { | 428 | !test_bit(QDF_CHANGE, &qd->qd_flags)) { |
386 | spin_unlock(&sdp->sd_quota_spin); | 429 | spin_unlock(&qd_lru_lock); |
387 | return 0; | 430 | return 0; |
388 | } | 431 | } |
389 | 432 | ||
390 | list_move_tail(&qd->qd_list, &sdp->sd_quota_list); | 433 | list_move_tail(&qd->qd_list, &sdp->sd_quota_list); |
391 | 434 | ||
392 | set_bit(QDF_LOCKED, &qd->qd_flags); | 435 | set_bit(QDF_LOCKED, &qd->qd_flags); |
393 | gfs2_assert_warn(sdp, qd->qd_count); | 436 | gfs2_assert_warn(sdp, atomic_read(&qd->qd_count)); |
394 | qd->qd_count++; | 437 | atomic_inc(&qd->qd_count); |
395 | qd->qd_change_sync = qd->qd_change; | 438 | qd->qd_change_sync = qd->qd_change; |
396 | gfs2_assert_warn(sdp, qd->qd_slot_count); | 439 | gfs2_assert_warn(sdp, qd->qd_slot_count); |
397 | qd->qd_slot_count++; | 440 | qd->qd_slot_count++; |
398 | 441 | ||
399 | spin_unlock(&sdp->sd_quota_spin); | 442 | spin_unlock(&qd_lru_lock); |
400 | 443 | ||
401 | gfs2_assert_warn(sdp, qd->qd_change_sync); | 444 | gfs2_assert_warn(sdp, qd->qd_change_sync); |
402 | if (bh_get(qd)) { | 445 | if (bh_get(qd)) { |
@@ -556,9 +599,9 @@ static void do_qc(struct gfs2_quota_data *qd, s64 change) | |||
556 | x = be64_to_cpu(qc->qc_change) + change; | 599 | x = be64_to_cpu(qc->qc_change) + change; |
557 | qc->qc_change = cpu_to_be64(x); | 600 | qc->qc_change = cpu_to_be64(x); |
558 | 601 | ||
559 | spin_lock(&sdp->sd_quota_spin); | 602 | spin_lock(&qd_lru_lock); |
560 | qd->qd_change = x; | 603 | qd->qd_change = x; |
561 | spin_unlock(&sdp->sd_quota_spin); | 604 | spin_unlock(&qd_lru_lock); |
562 | 605 | ||
563 | if (!x) { | 606 | if (!x) { |
564 | gfs2_assert_warn(sdp, test_bit(QDF_CHANGE, &qd->qd_flags)); | 607 | gfs2_assert_warn(sdp, test_bit(QDF_CHANGE, &qd->qd_flags)); |
@@ -802,8 +845,8 @@ restart: | |||
802 | loff_t pos; | 845 | loff_t pos; |
803 | gfs2_glock_dq_uninit(q_gh); | 846 | gfs2_glock_dq_uninit(q_gh); |
804 | error = gfs2_glock_nq_init(qd->qd_gl, | 847 | error = gfs2_glock_nq_init(qd->qd_gl, |
805 | LM_ST_EXCLUSIVE, GL_NOCACHE, | 848 | LM_ST_EXCLUSIVE, GL_NOCACHE, |
806 | q_gh); | 849 | q_gh); |
807 | if (error) | 850 | if (error) |
808 | return error; | 851 | return error; |
809 | 852 | ||
@@ -820,7 +863,6 @@ restart: | |||
820 | 863 | ||
821 | gfs2_glock_dq_uninit(&i_gh); | 864 | gfs2_glock_dq_uninit(&i_gh); |
822 | 865 | ||
823 | |||
824 | gfs2_quota_in(&q, buf); | 866 | gfs2_quota_in(&q, buf); |
825 | qlvb = (struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; | 867 | qlvb = (struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; |
826 | qlvb->qb_magic = cpu_to_be32(GFS2_MAGIC); | 868 | qlvb->qb_magic = cpu_to_be32(GFS2_MAGIC); |
@@ -890,9 +932,9 @@ static int need_sync(struct gfs2_quota_data *qd) | |||
890 | if (!qd->qd_qb.qb_limit) | 932 | if (!qd->qd_qb.qb_limit) |
891 | return 0; | 933 | return 0; |
892 | 934 | ||
893 | spin_lock(&sdp->sd_quota_spin); | 935 | spin_lock(&qd_lru_lock); |
894 | value = qd->qd_change; | 936 | value = qd->qd_change; |
895 | spin_unlock(&sdp->sd_quota_spin); | 937 | spin_unlock(&qd_lru_lock); |
896 | 938 | ||
897 | spin_lock(>->gt_spin); | 939 | spin_lock(>->gt_spin); |
898 | num = gt->gt_quota_scale_num; | 940 | num = gt->gt_quota_scale_num; |
@@ -985,9 +1027,9 @@ int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid) | |||
985 | continue; | 1027 | continue; |
986 | 1028 | ||
987 | value = (s64)be64_to_cpu(qd->qd_qb.qb_value); | 1029 | value = (s64)be64_to_cpu(qd->qd_qb.qb_value); |
988 | spin_lock(&sdp->sd_quota_spin); | 1030 | spin_lock(&qd_lru_lock); |
989 | value += qd->qd_change; | 1031 | value += qd->qd_change; |
990 | spin_unlock(&sdp->sd_quota_spin); | 1032 | spin_unlock(&qd_lru_lock); |
991 | 1033 | ||
992 | if (be64_to_cpu(qd->qd_qb.qb_limit) && (s64)be64_to_cpu(qd->qd_qb.qb_limit) < value) { | 1034 | if (be64_to_cpu(qd->qd_qb.qb_limit) && (s64)be64_to_cpu(qd->qd_qb.qb_limit) < value) { |
993 | print_message(qd, "exceeded"); | 1035 | print_message(qd, "exceeded"); |
@@ -1171,13 +1213,12 @@ int gfs2_quota_init(struct gfs2_sbd *sdp) | |||
1171 | qd->qd_change = qc.qc_change; | 1213 | qd->qd_change = qc.qc_change; |
1172 | qd->qd_slot = slot; | 1214 | qd->qd_slot = slot; |
1173 | qd->qd_slot_count = 1; | 1215 | qd->qd_slot_count = 1; |
1174 | qd->qd_last_touched = jiffies; | ||
1175 | 1216 | ||
1176 | spin_lock(&sdp->sd_quota_spin); | 1217 | spin_lock(&qd_lru_lock); |
1177 | gfs2_icbit_munge(sdp, sdp->sd_quota_bitmap, slot, 1); | 1218 | gfs2_icbit_munge(sdp, sdp->sd_quota_bitmap, slot, 1); |
1178 | list_add(&qd->qd_list, &sdp->sd_quota_list); | 1219 | list_add(&qd->qd_list, &sdp->sd_quota_list); |
1179 | atomic_inc(&sdp->sd_quota_count); | 1220 | atomic_inc(&sdp->sd_quota_count); |
1180 | spin_unlock(&sdp->sd_quota_spin); | 1221 | spin_unlock(&qd_lru_lock); |
1181 | 1222 | ||
1182 | found++; | 1223 | found++; |
1183 | } | 1224 | } |
@@ -1197,73 +1238,48 @@ fail: | |||
1197 | return error; | 1238 | return error; |
1198 | } | 1239 | } |
1199 | 1240 | ||
1200 | static void gfs2_quota_scan(struct gfs2_sbd *sdp) | ||
1201 | { | ||
1202 | struct gfs2_quota_data *qd, *safe; | ||
1203 | LIST_HEAD(dead); | ||
1204 | |||
1205 | spin_lock(&sdp->sd_quota_spin); | ||
1206 | list_for_each_entry_safe(qd, safe, &sdp->sd_quota_list, qd_list) { | ||
1207 | if (!qd->qd_count && | ||
1208 | time_after_eq(jiffies, qd->qd_last_touched + | ||
1209 | gfs2_tune_get(sdp, gt_quota_cache_secs) * HZ)) { | ||
1210 | list_move(&qd->qd_list, &dead); | ||
1211 | gfs2_assert_warn(sdp, | ||
1212 | atomic_read(&sdp->sd_quota_count) > 0); | ||
1213 | atomic_dec(&sdp->sd_quota_count); | ||
1214 | } | ||
1215 | } | ||
1216 | spin_unlock(&sdp->sd_quota_spin); | ||
1217 | |||
1218 | while (!list_empty(&dead)) { | ||
1219 | qd = list_entry(dead.next, struct gfs2_quota_data, qd_list); | ||
1220 | list_del(&qd->qd_list); | ||
1221 | |||
1222 | gfs2_assert_warn(sdp, !qd->qd_change); | ||
1223 | gfs2_assert_warn(sdp, !qd->qd_slot_count); | ||
1224 | gfs2_assert_warn(sdp, !qd->qd_bh_count); | ||
1225 | |||
1226 | gfs2_lvb_unhold(qd->qd_gl); | ||
1227 | kmem_cache_free(gfs2_quotad_cachep, qd); | ||
1228 | } | ||
1229 | } | ||
1230 | |||
1231 | void gfs2_quota_cleanup(struct gfs2_sbd *sdp) | 1241 | void gfs2_quota_cleanup(struct gfs2_sbd *sdp) |
1232 | { | 1242 | { |
1233 | struct list_head *head = &sdp->sd_quota_list; | 1243 | struct list_head *head = &sdp->sd_quota_list; |
1234 | struct gfs2_quota_data *qd; | 1244 | struct gfs2_quota_data *qd; |
1235 | unsigned int x; | 1245 | unsigned int x; |
1236 | 1246 | ||
1237 | spin_lock(&sdp->sd_quota_spin); | 1247 | spin_lock(&qd_lru_lock); |
1238 | while (!list_empty(head)) { | 1248 | while (!list_empty(head)) { |
1239 | qd = list_entry(head->prev, struct gfs2_quota_data, qd_list); | 1249 | qd = list_entry(head->prev, struct gfs2_quota_data, qd_list); |
1240 | 1250 | ||
1241 | if (qd->qd_count > 1 || | 1251 | if (atomic_read(&qd->qd_count) > 1 || |
1242 | (qd->qd_count && !test_bit(QDF_CHANGE, &qd->qd_flags))) { | 1252 | (atomic_read(&qd->qd_count) && |
1253 | !test_bit(QDF_CHANGE, &qd->qd_flags))) { | ||
1243 | list_move(&qd->qd_list, head); | 1254 | list_move(&qd->qd_list, head); |
1244 | spin_unlock(&sdp->sd_quota_spin); | 1255 | spin_unlock(&qd_lru_lock); |
1245 | schedule(); | 1256 | schedule(); |
1246 | spin_lock(&sdp->sd_quota_spin); | 1257 | spin_lock(&qd_lru_lock); |
1247 | continue; | 1258 | continue; |
1248 | } | 1259 | } |
1249 | 1260 | ||
1250 | list_del(&qd->qd_list); | 1261 | list_del(&qd->qd_list); |
1262 | /* Also remove if this qd exists in the reclaim list */ | ||
1263 | if (!list_empty(&qd->qd_reclaim)) { | ||
1264 | list_del_init(&qd->qd_reclaim); | ||
1265 | atomic_dec(&qd_lru_count); | ||
1266 | } | ||
1251 | atomic_dec(&sdp->sd_quota_count); | 1267 | atomic_dec(&sdp->sd_quota_count); |
1252 | spin_unlock(&sdp->sd_quota_spin); | 1268 | spin_unlock(&qd_lru_lock); |
1253 | 1269 | ||
1254 | if (!qd->qd_count) { | 1270 | if (!atomic_read(&qd->qd_count)) { |
1255 | gfs2_assert_warn(sdp, !qd->qd_change); | 1271 | gfs2_assert_warn(sdp, !qd->qd_change); |
1256 | gfs2_assert_warn(sdp, !qd->qd_slot_count); | 1272 | gfs2_assert_warn(sdp, !qd->qd_slot_count); |
1257 | } else | 1273 | } else |
1258 | gfs2_assert_warn(sdp, qd->qd_slot_count == 1); | 1274 | gfs2_assert_warn(sdp, qd->qd_slot_count == 1); |
1259 | gfs2_assert_warn(sdp, !qd->qd_bh_count); | 1275 | gfs2_assert_warn(sdp, !qd->qd_bh_count); |
1260 | 1276 | ||
1261 | gfs2_lvb_unhold(qd->qd_gl); | 1277 | gfs2_glock_put(qd->qd_gl); |
1262 | kmem_cache_free(gfs2_quotad_cachep, qd); | 1278 | kmem_cache_free(gfs2_quotad_cachep, qd); |
1263 | 1279 | ||
1264 | spin_lock(&sdp->sd_quota_spin); | 1280 | spin_lock(&qd_lru_lock); |
1265 | } | 1281 | } |
1266 | spin_unlock(&sdp->sd_quota_spin); | 1282 | spin_unlock(&qd_lru_lock); |
1267 | 1283 | ||
1268 | gfs2_assert_warn(sdp, !atomic_read(&sdp->sd_quota_count)); | 1284 | gfs2_assert_warn(sdp, !atomic_read(&sdp->sd_quota_count)); |
1269 | 1285 | ||
@@ -1341,9 +1357,6 @@ int gfs2_quotad(void *data) | |||
1341 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync, t, | 1357 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync, t, |
1342 | "ad_timeo, &tune->gt_quota_quantum); | 1358 | "ad_timeo, &tune->gt_quota_quantum); |
1343 | 1359 | ||
1344 | /* FIXME: This should be turned into a shrinker */ | ||
1345 | gfs2_quota_scan(sdp); | ||
1346 | |||
1347 | /* Check for & recover partially truncated inodes */ | 1360 | /* Check for & recover partially truncated inodes */ |
1348 | quotad_check_trunc_list(sdp); | 1361 | quotad_check_trunc_list(sdp); |
1349 | 1362 | ||
diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h index cec9032be97d..0fa5fa63d0e8 100644 --- a/fs/gfs2/quota.h +++ b/fs/gfs2/quota.h | |||
@@ -49,4 +49,6 @@ static inline int gfs2_quota_lock_check(struct gfs2_inode *ip) | |||
49 | return ret; | 49 | return ret; |
50 | } | 50 | } |
51 | 51 | ||
52 | extern int gfs2_shrink_qd_memory(int nr, gfp_t gfp_mask); | ||
53 | |||
52 | #endif /* __QUOTA_DOT_H__ */ | 54 | #endif /* __QUOTA_DOT_H__ */ |
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c index efd09c3d2b26..247e8f7d6b3d 100644 --- a/fs/gfs2/recovery.c +++ b/fs/gfs2/recovery.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
15 | #include <linux/crc32.h> | 15 | #include <linux/crc32.h> |
16 | #include <linux/lm_interface.h> | ||
17 | #include <linux/kthread.h> | 16 | #include <linux/kthread.h> |
18 | #include <linux/freezer.h> | 17 | #include <linux/freezer.h> |
19 | 18 | ||
@@ -427,20 +426,23 @@ static int clean_journal(struct gfs2_jdesc *jd, struct gfs2_log_header_host *hea | |||
427 | } | 426 | } |
428 | 427 | ||
429 | 428 | ||
430 | static void gfs2_lm_recovery_done(struct gfs2_sbd *sdp, unsigned int jid, | 429 | static void gfs2_recovery_done(struct gfs2_sbd *sdp, unsigned int jid, |
431 | unsigned int message) | 430 | unsigned int message) |
432 | { | 431 | { |
433 | if (!sdp->sd_lockstruct.ls_ops->lm_recovery_done) | 432 | char env_jid[20]; |
434 | return; | 433 | char env_status[20]; |
435 | 434 | char *envp[] = { env_jid, env_status, NULL }; | |
436 | if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) | 435 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; |
437 | sdp->sd_lockstruct.ls_ops->lm_recovery_done( | 436 | ls->ls_recover_jid_done = jid; |
438 | sdp->sd_lockstruct.ls_lockspace, jid, message); | 437 | ls->ls_recover_jid_status = message; |
438 | sprintf(env_jid, "JID=%d", jid); | ||
439 | sprintf(env_status, "RECOVERY=%s", | ||
440 | message == LM_RD_SUCCESS ? "Done" : "Failed"); | ||
441 | kobject_uevent_env(&sdp->sd_kobj, KOBJ_CHANGE, envp); | ||
439 | } | 442 | } |
440 | 443 | ||
441 | |||
442 | /** | 444 | /** |
443 | * gfs2_recover_journal - recovery a given journal | 445 | * gfs2_recover_journal - recover a given journal |
444 | * @jd: the struct gfs2_jdesc describing the journal | 446 | * @jd: the struct gfs2_jdesc describing the journal |
445 | * | 447 | * |
446 | * Acquire the journal's lock, check to see if the journal is clean, and | 448 | * Acquire the journal's lock, check to see if the journal is clean, and |
@@ -561,7 +563,7 @@ int gfs2_recover_journal(struct gfs2_jdesc *jd) | |||
561 | if (jd->jd_jid != sdp->sd_lockstruct.ls_jid) | 563 | if (jd->jd_jid != sdp->sd_lockstruct.ls_jid) |
562 | gfs2_glock_dq_uninit(&ji_gh); | 564 | gfs2_glock_dq_uninit(&ji_gh); |
563 | 565 | ||
564 | gfs2_lm_recovery_done(sdp, jd->jd_jid, LM_RD_SUCCESS); | 566 | gfs2_recovery_done(sdp, jd->jd_jid, LM_RD_SUCCESS); |
565 | 567 | ||
566 | if (jd->jd_jid != sdp->sd_lockstruct.ls_jid) | 568 | if (jd->jd_jid != sdp->sd_lockstruct.ls_jid) |
567 | gfs2_glock_dq_uninit(&j_gh); | 569 | gfs2_glock_dq_uninit(&j_gh); |
@@ -581,7 +583,7 @@ fail_gunlock_j: | |||
581 | fs_info(sdp, "jid=%u: %s\n", jd->jd_jid, (error) ? "Failed" : "Done"); | 583 | fs_info(sdp, "jid=%u: %s\n", jd->jd_jid, (error) ? "Failed" : "Done"); |
582 | 584 | ||
583 | fail: | 585 | fail: |
584 | gfs2_lm_recovery_done(sdp, jd->jd_jid, LM_RD_GAVEUP); | 586 | gfs2_recovery_done(sdp, jd->jd_jid, LM_RD_GAVEUP); |
585 | return error; | 587 | return error; |
586 | } | 588 | } |
587 | 589 | ||
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 8b01c635d925..f03d024038ea 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c | |||
@@ -13,8 +13,8 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/lm_interface.h> | ||
17 | #include <linux/prefetch.h> | 16 | #include <linux/prefetch.h> |
17 | #include <linux/blkdev.h> | ||
18 | 18 | ||
19 | #include "gfs2.h" | 19 | #include "gfs2.h" |
20 | #include "incore.h" | 20 | #include "incore.h" |
@@ -132,81 +132,90 @@ static inline unsigned char gfs2_testbit(struct gfs2_rgrpd *rgd, | |||
132 | } | 132 | } |
133 | 133 | ||
134 | /** | 134 | /** |
135 | * gfs2_bit_search | ||
136 | * @ptr: Pointer to bitmap data | ||
137 | * @mask: Mask to use (normally 0x55555.... but adjusted for search start) | ||
138 | * @state: The state we are searching for | ||
139 | * | ||
140 | * We xor the bitmap data with a patter which is the bitwise opposite | ||
141 | * of what we are looking for, this gives rise to a pattern of ones | ||
142 | * wherever there is a match. Since we have two bits per entry, we | ||
143 | * take this pattern, shift it down by one place and then and it with | ||
144 | * the original. All the even bit positions (0,2,4, etc) then represent | ||
145 | * successful matches, so we mask with 0x55555..... to remove the unwanted | ||
146 | * odd bit positions. | ||
147 | * | ||
148 | * This allows searching of a whole u64 at once (32 blocks) with a | ||
149 | * single test (on 64 bit arches). | ||
150 | */ | ||
151 | |||
152 | static inline u64 gfs2_bit_search(const __le64 *ptr, u64 mask, u8 state) | ||
153 | { | ||
154 | u64 tmp; | ||
155 | static const u64 search[] = { | ||
156 | [0] = 0xffffffffffffffffULL, | ||
157 | [1] = 0xaaaaaaaaaaaaaaaaULL, | ||
158 | [2] = 0x5555555555555555ULL, | ||
159 | [3] = 0x0000000000000000ULL, | ||
160 | }; | ||
161 | tmp = le64_to_cpu(*ptr) ^ search[state]; | ||
162 | tmp &= (tmp >> 1); | ||
163 | tmp &= mask; | ||
164 | return tmp; | ||
165 | } | ||
166 | |||
167 | /** | ||
135 | * gfs2_bitfit - Search an rgrp's bitmap buffer to find a bit-pair representing | 168 | * gfs2_bitfit - Search an rgrp's bitmap buffer to find a bit-pair representing |
136 | * a block in a given allocation state. | 169 | * a block in a given allocation state. |
137 | * @buffer: the buffer that holds the bitmaps | 170 | * @buffer: the buffer that holds the bitmaps |
138 | * @buflen: the length (in bytes) of the buffer | 171 | * @len: the length (in bytes) of the buffer |
139 | * @goal: start search at this block's bit-pair (within @buffer) | 172 | * @goal: start search at this block's bit-pair (within @buffer) |
140 | * @old_state: GFS2_BLKST_XXX the state of the block we're looking for. | 173 | * @state: GFS2_BLKST_XXX the state of the block we're looking for. |
141 | * | 174 | * |
142 | * Scope of @goal and returned block number is only within this bitmap buffer, | 175 | * Scope of @goal and returned block number is only within this bitmap buffer, |
143 | * not entire rgrp or filesystem. @buffer will be offset from the actual | 176 | * not entire rgrp or filesystem. @buffer will be offset from the actual |
144 | * beginning of a bitmap block buffer, skipping any header structures. | 177 | * beginning of a bitmap block buffer, skipping any header structures, but |
178 | * headers are always a multiple of 64 bits long so that the buffer is | ||
179 | * always aligned to a 64 bit boundary. | ||
180 | * | ||
181 | * The size of the buffer is in bytes, but is it assumed that it is | ||
182 | * always ok to to read a complete multiple of 64 bits at the end | ||
183 | * of the block in case the end is no aligned to a natural boundary. | ||
145 | * | 184 | * |
146 | * Return: the block number (bitmap buffer scope) that was found | 185 | * Return: the block number (bitmap buffer scope) that was found |
147 | */ | 186 | */ |
148 | 187 | ||
149 | static u32 gfs2_bitfit(const u8 *buffer, unsigned int buflen, u32 goal, | 188 | static u32 gfs2_bitfit(const u8 *buf, const unsigned int len, |
150 | u8 old_state) | 189 | u32 goal, u8 state) |
151 | { | 190 | { |
152 | const u8 *byte, *start, *end; | 191 | u32 spoint = (goal << 1) & ((8*sizeof(u64)) - 1); |
153 | int bit, startbit; | 192 | const __le64 *ptr = ((__le64 *)buf) + (goal >> 5); |
154 | u32 g1, g2, misaligned; | 193 | const __le64 *end = (__le64 *)(buf + ALIGN(len, sizeof(u64))); |
155 | unsigned long *plong; | 194 | u64 tmp; |
156 | unsigned long lskipval; | 195 | u64 mask = 0x5555555555555555ULL; |
157 | 196 | u32 bit; | |
158 | lskipval = (old_state & GFS2_BLKST_USED) ? LBITSKIP00 : LBITSKIP55; | 197 | |
159 | g1 = (goal / GFS2_NBBY); | 198 | BUG_ON(state > 3); |
160 | start = buffer + g1; | 199 | |
161 | byte = start; | 200 | /* Mask off bits we don't care about at the start of the search */ |
162 | end = buffer + buflen; | 201 | mask <<= spoint; |
163 | g2 = ALIGN(g1, sizeof(unsigned long)); | 202 | tmp = gfs2_bit_search(ptr, mask, state); |
164 | plong = (unsigned long *)(buffer + g2); | 203 | ptr++; |
165 | startbit = bit = (goal % GFS2_NBBY) * GFS2_BIT_SIZE; | 204 | while(tmp == 0 && ptr < end) { |
166 | misaligned = g2 - g1; | 205 | tmp = gfs2_bit_search(ptr, 0x5555555555555555ULL, state); |
167 | if (!misaligned) | 206 | ptr++; |
168 | goto ulong_aligned; | ||
169 | /* parse the bitmap a byte at a time */ | ||
170 | misaligned: | ||
171 | while (byte < end) { | ||
172 | if (((*byte >> bit) & GFS2_BIT_MASK) == old_state) { | ||
173 | return goal + | ||
174 | (((byte - start) * GFS2_NBBY) + | ||
175 | ((bit - startbit) >> 1)); | ||
176 | } | ||
177 | bit += GFS2_BIT_SIZE; | ||
178 | if (bit >= GFS2_NBBY * GFS2_BIT_SIZE) { | ||
179 | bit = 0; | ||
180 | byte++; | ||
181 | misaligned--; | ||
182 | if (!misaligned) { | ||
183 | plong = (unsigned long *)byte; | ||
184 | goto ulong_aligned; | ||
185 | } | ||
186 | } | ||
187 | } | ||
188 | return BFITNOENT; | ||
189 | |||
190 | /* parse the bitmap a unsigned long at a time */ | ||
191 | ulong_aligned: | ||
192 | /* Stop at "end - 1" or else prefetch can go past the end and segfault. | ||
193 | We could "if" it but we'd lose some of the performance gained. | ||
194 | This way will only slow down searching the very last 4/8 bytes | ||
195 | depending on architecture. I've experimented with several ways | ||
196 | of writing this section such as using an else before the goto | ||
197 | but this one seems to be the fastest. */ | ||
198 | while ((unsigned char *)plong < end - sizeof(unsigned long)) { | ||
199 | prefetch(plong + 1); | ||
200 | if (((*plong) & LBITMASK) != lskipval) | ||
201 | break; | ||
202 | plong++; | ||
203 | } | ||
204 | if ((unsigned char *)plong < end) { | ||
205 | byte = (const u8 *)plong; | ||
206 | misaligned += sizeof(unsigned long) - 1; | ||
207 | goto misaligned; | ||
208 | } | 207 | } |
209 | return BFITNOENT; | 208 | /* Mask off any bits which are more than len bytes from the start */ |
209 | if (ptr == end && (len & (sizeof(u64) - 1))) | ||
210 | tmp &= (((u64)~0) >> (64 - 8*(len & (sizeof(u64) - 1)))); | ||
211 | /* Didn't find anything, so return */ | ||
212 | if (tmp == 0) | ||
213 | return BFITNOENT; | ||
214 | ptr--; | ||
215 | bit = fls64(tmp); | ||
216 | bit--; /* fls64 always adds one to the bit count */ | ||
217 | bit /= 2; /* two bits per entry in the bitmap */ | ||
218 | return (((const unsigned char *)ptr - buf) * GFS2_NBBY) + bit; | ||
210 | } | 219 | } |
211 | 220 | ||
212 | /** | 221 | /** |
@@ -831,6 +840,58 @@ void gfs2_rgrp_bh_put(struct gfs2_rgrpd *rgd) | |||
831 | spin_unlock(&sdp->sd_rindex_spin); | 840 | spin_unlock(&sdp->sd_rindex_spin); |
832 | } | 841 | } |
833 | 842 | ||
843 | static void gfs2_rgrp_send_discards(struct gfs2_sbd *sdp, u64 offset, | ||
844 | const struct gfs2_bitmap *bi) | ||
845 | { | ||
846 | struct super_block *sb = sdp->sd_vfs; | ||
847 | struct block_device *bdev = sb->s_bdev; | ||
848 | const unsigned int sects_per_blk = sdp->sd_sb.sb_bsize / | ||
849 | bdev_hardsect_size(sb->s_bdev); | ||
850 | u64 blk; | ||
851 | sector_t start = 0; | ||
852 | sector_t nr_sects = 0; | ||
853 | int rv; | ||
854 | unsigned int x; | ||
855 | |||
856 | for (x = 0; x < bi->bi_len; x++) { | ||
857 | const u8 *orig = bi->bi_bh->b_data + bi->bi_offset + x; | ||
858 | const u8 *clone = bi->bi_clone + bi->bi_offset + x; | ||
859 | u8 diff = ~(*orig | (*orig >> 1)) & (*clone | (*clone >> 1)); | ||
860 | diff &= 0x55; | ||
861 | if (diff == 0) | ||
862 | continue; | ||
863 | blk = offset + ((bi->bi_start + x) * GFS2_NBBY); | ||
864 | blk *= sects_per_blk; /* convert to sectors */ | ||
865 | while(diff) { | ||
866 | if (diff & 1) { | ||
867 | if (nr_sects == 0) | ||
868 | goto start_new_extent; | ||
869 | if ((start + nr_sects) != blk) { | ||
870 | rv = blkdev_issue_discard(bdev, start, | ||
871 | nr_sects, GFP_NOFS); | ||
872 | if (rv) | ||
873 | goto fail; | ||
874 | nr_sects = 0; | ||
875 | start_new_extent: | ||
876 | start = blk; | ||
877 | } | ||
878 | nr_sects += sects_per_blk; | ||
879 | } | ||
880 | diff >>= 2; | ||
881 | blk += sects_per_blk; | ||
882 | } | ||
883 | } | ||
884 | if (nr_sects) { | ||
885 | rv = blkdev_issue_discard(bdev, start, nr_sects, GFP_NOFS); | ||
886 | if (rv) | ||
887 | goto fail; | ||
888 | } | ||
889 | return; | ||
890 | fail: | ||
891 | fs_warn(sdp, "error %d on discard request, turning discards off for this filesystem", rv); | ||
892 | sdp->sd_args.ar_discard = 0; | ||
893 | } | ||
894 | |||
834 | void gfs2_rgrp_repolish_clones(struct gfs2_rgrpd *rgd) | 895 | void gfs2_rgrp_repolish_clones(struct gfs2_rgrpd *rgd) |
835 | { | 896 | { |
836 | struct gfs2_sbd *sdp = rgd->rd_sbd; | 897 | struct gfs2_sbd *sdp = rgd->rd_sbd; |
@@ -841,6 +902,8 @@ void gfs2_rgrp_repolish_clones(struct gfs2_rgrpd *rgd) | |||
841 | struct gfs2_bitmap *bi = rgd->rd_bits + x; | 902 | struct gfs2_bitmap *bi = rgd->rd_bits + x; |
842 | if (!bi->bi_clone) | 903 | if (!bi->bi_clone) |
843 | continue; | 904 | continue; |
905 | if (sdp->sd_args.ar_discard) | ||
906 | gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bi); | ||
844 | memcpy(bi->bi_clone + bi->bi_offset, | 907 | memcpy(bi->bi_clone + bi->bi_offset, |
845 | bi->bi_bh->b_data + bi->bi_offset, bi->bi_len); | 908 | bi->bi_bh->b_data + bi->bi_offset, bi->bi_len); |
846 | } | 909 | } |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 141b781f2fcc..601913e0a482 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -15,7 +15,6 @@ | |||
15 | #include <linux/crc32.h> | 15 | #include <linux/crc32.h> |
16 | #include <linux/gfs2_ondisk.h> | 16 | #include <linux/gfs2_ondisk.h> |
17 | #include <linux/bio.h> | 17 | #include <linux/bio.h> |
18 | #include <linux/lm_interface.h> | ||
19 | 18 | ||
20 | #include "gfs2.h" | 19 | #include "gfs2.h" |
21 | #include "incore.h" | 20 | #include "incore.h" |
@@ -339,7 +338,6 @@ static int gfs2_lock_fs_check_clean(struct gfs2_sbd *sdp, | |||
339 | struct gfs2_holder *t_gh) | 338 | struct gfs2_holder *t_gh) |
340 | { | 339 | { |
341 | struct gfs2_inode *ip; | 340 | struct gfs2_inode *ip; |
342 | struct gfs2_holder ji_gh; | ||
343 | struct gfs2_jdesc *jd; | 341 | struct gfs2_jdesc *jd; |
344 | struct lfcc *lfcc; | 342 | struct lfcc *lfcc; |
345 | LIST_HEAD(list); | 343 | LIST_HEAD(list); |
@@ -387,7 +385,6 @@ out: | |||
387 | gfs2_glock_dq_uninit(&lfcc->gh); | 385 | gfs2_glock_dq_uninit(&lfcc->gh); |
388 | kfree(lfcc); | 386 | kfree(lfcc); |
389 | } | 387 | } |
390 | gfs2_glock_dq_uninit(&ji_gh); | ||
391 | return error; | 388 | return error; |
392 | } | 389 | } |
393 | 390 | ||
diff --git a/fs/gfs2/super.h b/fs/gfs2/super.h index f6b8b00ad881..b56413e3e40d 100644 --- a/fs/gfs2/super.h +++ b/fs/gfs2/super.h | |||
@@ -14,7 +14,7 @@ | |||
14 | #include <linux/dcache.h> | 14 | #include <linux/dcache.h> |
15 | #include "incore.h" | 15 | #include "incore.h" |
16 | 16 | ||
17 | void gfs2_lm_unmount(struct gfs2_sbd *sdp); | 17 | extern void gfs2_lm_unmount(struct gfs2_sbd *sdp); |
18 | 18 | ||
19 | static inline unsigned int gfs2_jindex_size(struct gfs2_sbd *sdp) | 19 | static inline unsigned int gfs2_jindex_size(struct gfs2_sbd *sdp) |
20 | { | 20 | { |
@@ -27,27 +27,29 @@ static inline unsigned int gfs2_jindex_size(struct gfs2_sbd *sdp) | |||
27 | 27 | ||
28 | void gfs2_jindex_free(struct gfs2_sbd *sdp); | 28 | void gfs2_jindex_free(struct gfs2_sbd *sdp); |
29 | 29 | ||
30 | struct gfs2_jdesc *gfs2_jdesc_find(struct gfs2_sbd *sdp, unsigned int jid); | 30 | extern int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *data); |
31 | int gfs2_jdesc_check(struct gfs2_jdesc *jd); | ||
32 | 31 | ||
33 | int gfs2_lookup_in_master_dir(struct gfs2_sbd *sdp, char *filename, | 32 | extern struct gfs2_jdesc *gfs2_jdesc_find(struct gfs2_sbd *sdp, unsigned int jid); |
34 | struct gfs2_inode **ipp); | 33 | extern int gfs2_jdesc_check(struct gfs2_jdesc *jd); |
35 | 34 | ||
36 | int gfs2_make_fs_rw(struct gfs2_sbd *sdp); | 35 | extern int gfs2_lookup_in_master_dir(struct gfs2_sbd *sdp, char *filename, |
36 | struct gfs2_inode **ipp); | ||
37 | 37 | ||
38 | int gfs2_statfs_init(struct gfs2_sbd *sdp); | 38 | extern int gfs2_make_fs_rw(struct gfs2_sbd *sdp); |
39 | void gfs2_statfs_change(struct gfs2_sbd *sdp, | ||
40 | s64 total, s64 free, s64 dinodes); | ||
41 | int gfs2_statfs_sync(struct gfs2_sbd *sdp); | ||
42 | 39 | ||
43 | int gfs2_freeze_fs(struct gfs2_sbd *sdp); | 40 | extern int gfs2_statfs_init(struct gfs2_sbd *sdp); |
44 | void gfs2_unfreeze_fs(struct gfs2_sbd *sdp); | 41 | extern void gfs2_statfs_change(struct gfs2_sbd *sdp, s64 total, s64 free, |
42 | s64 dinodes); | ||
43 | extern int gfs2_statfs_sync(struct gfs2_sbd *sdp); | ||
44 | |||
45 | extern int gfs2_freeze_fs(struct gfs2_sbd *sdp); | ||
46 | extern void gfs2_unfreeze_fs(struct gfs2_sbd *sdp); | ||
45 | 47 | ||
46 | extern struct file_system_type gfs2_fs_type; | 48 | extern struct file_system_type gfs2_fs_type; |
47 | extern struct file_system_type gfs2meta_fs_type; | 49 | extern struct file_system_type gfs2meta_fs_type; |
48 | extern const struct export_operations gfs2_export_ops; | 50 | extern const struct export_operations gfs2_export_ops; |
49 | extern const struct super_operations gfs2_super_ops; | 51 | extern const struct super_operations gfs2_super_ops; |
50 | extern struct dentry_operations gfs2_dops; | 52 | extern const struct dentry_operations gfs2_dops; |
51 | 53 | ||
52 | #endif /* __SUPER_DOT_H__ */ | 54 | #endif /* __SUPER_DOT_H__ */ |
53 | 55 | ||
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 26c1fa777a95..7655f5025fec 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c | |||
@@ -14,9 +14,8 @@ | |||
14 | #include <linux/buffer_head.h> | 14 | #include <linux/buffer_head.h> |
15 | #include <linux/module.h> | 15 | #include <linux/module.h> |
16 | #include <linux/kobject.h> | 16 | #include <linux/kobject.h> |
17 | #include <linux/gfs2_ondisk.h> | ||
18 | #include <linux/lm_interface.h> | ||
19 | #include <asm/uaccess.h> | 17 | #include <asm/uaccess.h> |
18 | #include <linux/gfs2_ondisk.h> | ||
20 | 19 | ||
21 | #include "gfs2.h" | 20 | #include "gfs2.h" |
22 | #include "incore.h" | 21 | #include "incore.h" |
@@ -25,6 +24,7 @@ | |||
25 | #include "glock.h" | 24 | #include "glock.h" |
26 | #include "quota.h" | 25 | #include "quota.h" |
27 | #include "util.h" | 26 | #include "util.h" |
27 | #include "glops.h" | ||
28 | 28 | ||
29 | static ssize_t id_show(struct gfs2_sbd *sdp, char *buf) | 29 | static ssize_t id_show(struct gfs2_sbd *sdp, char *buf) |
30 | { | 30 | { |
@@ -37,6 +37,30 @@ static ssize_t fsname_show(struct gfs2_sbd *sdp, char *buf) | |||
37 | return snprintf(buf, PAGE_SIZE, "%s\n", sdp->sd_fsname); | 37 | return snprintf(buf, PAGE_SIZE, "%s\n", sdp->sd_fsname); |
38 | } | 38 | } |
39 | 39 | ||
40 | static int gfs2_uuid_valid(const u8 *uuid) | ||
41 | { | ||
42 | int i; | ||
43 | |||
44 | for (i = 0; i < 16; i++) { | ||
45 | if (uuid[i]) | ||
46 | return 1; | ||
47 | } | ||
48 | return 0; | ||
49 | } | ||
50 | |||
51 | static ssize_t uuid_show(struct gfs2_sbd *sdp, char *buf) | ||
52 | { | ||
53 | const u8 *uuid = sdp->sd_sb.sb_uuid; | ||
54 | buf[0] = '\0'; | ||
55 | if (!gfs2_uuid_valid(uuid)) | ||
56 | return 0; | ||
57 | return snprintf(buf, PAGE_SIZE, "%02X%02X%02X%02X-%02X%02X-" | ||
58 | "%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X\n", | ||
59 | uuid[0], uuid[1], uuid[2], uuid[3], uuid[4], uuid[5], | ||
60 | uuid[6], uuid[7], uuid[8], uuid[9], uuid[10], uuid[11], | ||
61 | uuid[12], uuid[13], uuid[14], uuid[15]); | ||
62 | } | ||
63 | |||
40 | static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf) | 64 | static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf) |
41 | { | 65 | { |
42 | unsigned int count; | 66 | unsigned int count; |
@@ -148,6 +172,46 @@ static ssize_t quota_refresh_group_store(struct gfs2_sbd *sdp, const char *buf, | |||
148 | return len; | 172 | return len; |
149 | } | 173 | } |
150 | 174 | ||
175 | static ssize_t demote_rq_store(struct gfs2_sbd *sdp, const char *buf, size_t len) | ||
176 | { | ||
177 | struct gfs2_glock *gl; | ||
178 | const struct gfs2_glock_operations *glops; | ||
179 | unsigned int glmode; | ||
180 | unsigned int gltype; | ||
181 | unsigned long long glnum; | ||
182 | char mode[16]; | ||
183 | int rv; | ||
184 | |||
185 | if (!capable(CAP_SYS_ADMIN)) | ||
186 | return -EACCES; | ||
187 | |||
188 | rv = sscanf(buf, "%u:%llu %15s", &gltype, &glnum, | ||
189 | mode); | ||
190 | if (rv != 3) | ||
191 | return -EINVAL; | ||
192 | |||
193 | if (strcmp(mode, "EX") == 0) | ||
194 | glmode = LM_ST_UNLOCKED; | ||
195 | else if ((strcmp(mode, "CW") == 0) || (strcmp(mode, "DF") == 0)) | ||
196 | glmode = LM_ST_DEFERRED; | ||
197 | else if ((strcmp(mode, "PR") == 0) || (strcmp(mode, "SH") == 0)) | ||
198 | glmode = LM_ST_SHARED; | ||
199 | else | ||
200 | return -EINVAL; | ||
201 | |||
202 | if (gltype > LM_TYPE_JOURNAL) | ||
203 | return -EINVAL; | ||
204 | glops = gfs2_glops_list[gltype]; | ||
205 | if (glops == NULL) | ||
206 | return -EINVAL; | ||
207 | rv = gfs2_glock_get(sdp, glnum, glops, 0, &gl); | ||
208 | if (rv) | ||
209 | return rv; | ||
210 | gfs2_glock_cb(gl, glmode); | ||
211 | gfs2_glock_put(gl); | ||
212 | return len; | ||
213 | } | ||
214 | |||
151 | struct gfs2_attr { | 215 | struct gfs2_attr { |
152 | struct attribute attr; | 216 | struct attribute attr; |
153 | ssize_t (*show)(struct gfs2_sbd *, char *); | 217 | ssize_t (*show)(struct gfs2_sbd *, char *); |
@@ -159,22 +223,26 @@ static struct gfs2_attr gfs2_attr_##name = __ATTR(name, mode, show, store) | |||
159 | 223 | ||
160 | GFS2_ATTR(id, 0444, id_show, NULL); | 224 | GFS2_ATTR(id, 0444, id_show, NULL); |
161 | GFS2_ATTR(fsname, 0444, fsname_show, NULL); | 225 | GFS2_ATTR(fsname, 0444, fsname_show, NULL); |
226 | GFS2_ATTR(uuid, 0444, uuid_show, NULL); | ||
162 | GFS2_ATTR(freeze, 0644, freeze_show, freeze_store); | 227 | GFS2_ATTR(freeze, 0644, freeze_show, freeze_store); |
163 | GFS2_ATTR(withdraw, 0644, withdraw_show, withdraw_store); | 228 | GFS2_ATTR(withdraw, 0644, withdraw_show, withdraw_store); |
164 | GFS2_ATTR(statfs_sync, 0200, NULL, statfs_sync_store); | 229 | GFS2_ATTR(statfs_sync, 0200, NULL, statfs_sync_store); |
165 | GFS2_ATTR(quota_sync, 0200, NULL, quota_sync_store); | 230 | GFS2_ATTR(quota_sync, 0200, NULL, quota_sync_store); |
166 | GFS2_ATTR(quota_refresh_user, 0200, NULL, quota_refresh_user_store); | 231 | GFS2_ATTR(quota_refresh_user, 0200, NULL, quota_refresh_user_store); |
167 | GFS2_ATTR(quota_refresh_group, 0200, NULL, quota_refresh_group_store); | 232 | GFS2_ATTR(quota_refresh_group, 0200, NULL, quota_refresh_group_store); |
233 | GFS2_ATTR(demote_rq, 0200, NULL, demote_rq_store); | ||
168 | 234 | ||
169 | static struct attribute *gfs2_attrs[] = { | 235 | static struct attribute *gfs2_attrs[] = { |
170 | &gfs2_attr_id.attr, | 236 | &gfs2_attr_id.attr, |
171 | &gfs2_attr_fsname.attr, | 237 | &gfs2_attr_fsname.attr, |
238 | &gfs2_attr_uuid.attr, | ||
172 | &gfs2_attr_freeze.attr, | 239 | &gfs2_attr_freeze.attr, |
173 | &gfs2_attr_withdraw.attr, | 240 | &gfs2_attr_withdraw.attr, |
174 | &gfs2_attr_statfs_sync.attr, | 241 | &gfs2_attr_statfs_sync.attr, |
175 | &gfs2_attr_quota_sync.attr, | 242 | &gfs2_attr_quota_sync.attr, |
176 | &gfs2_attr_quota_refresh_user.attr, | 243 | &gfs2_attr_quota_refresh_user.attr, |
177 | &gfs2_attr_quota_refresh_group.attr, | 244 | &gfs2_attr_quota_refresh_group.attr, |
245 | &gfs2_attr_demote_rq.attr, | ||
178 | NULL, | 246 | NULL, |
179 | }; | 247 | }; |
180 | 248 | ||
@@ -224,14 +292,145 @@ static struct lockstruct_attr lockstruct_attr_##name = __ATTR_RO(name) | |||
224 | 292 | ||
225 | LOCKSTRUCT_ATTR(jid, "%u\n"); | 293 | LOCKSTRUCT_ATTR(jid, "%u\n"); |
226 | LOCKSTRUCT_ATTR(first, "%u\n"); | 294 | LOCKSTRUCT_ATTR(first, "%u\n"); |
227 | LOCKSTRUCT_ATTR(lvb_size, "%u\n"); | ||
228 | LOCKSTRUCT_ATTR(flags, "%d\n"); | ||
229 | 295 | ||
230 | static struct attribute *lockstruct_attrs[] = { | 296 | static struct attribute *lockstruct_attrs[] = { |
231 | &lockstruct_attr_jid.attr, | 297 | &lockstruct_attr_jid.attr, |
232 | &lockstruct_attr_first.attr, | 298 | &lockstruct_attr_first.attr, |
233 | &lockstruct_attr_lvb_size.attr, | 299 | NULL, |
234 | &lockstruct_attr_flags.attr, | 300 | }; |
301 | |||
302 | /* | ||
303 | * lock_module. Originally from lock_dlm | ||
304 | */ | ||
305 | |||
306 | static ssize_t proto_name_show(struct gfs2_sbd *sdp, char *buf) | ||
307 | { | ||
308 | const struct lm_lockops *ops = sdp->sd_lockstruct.ls_ops; | ||
309 | return sprintf(buf, "%s\n", ops->lm_proto_name); | ||
310 | } | ||
311 | |||
312 | static ssize_t block_show(struct gfs2_sbd *sdp, char *buf) | ||
313 | { | ||
314 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
315 | ssize_t ret; | ||
316 | int val = 0; | ||
317 | |||
318 | if (test_bit(DFL_BLOCK_LOCKS, &ls->ls_flags)) | ||
319 | val = 1; | ||
320 | ret = sprintf(buf, "%d\n", val); | ||
321 | return ret; | ||
322 | } | ||
323 | |||
324 | static ssize_t block_store(struct gfs2_sbd *sdp, const char *buf, size_t len) | ||
325 | { | ||
326 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
327 | ssize_t ret = len; | ||
328 | int val; | ||
329 | |||
330 | val = simple_strtol(buf, NULL, 0); | ||
331 | |||
332 | if (val == 1) | ||
333 | set_bit(DFL_BLOCK_LOCKS, &ls->ls_flags); | ||
334 | else if (val == 0) { | ||
335 | clear_bit(DFL_BLOCK_LOCKS, &ls->ls_flags); | ||
336 | smp_mb__after_clear_bit(); | ||
337 | gfs2_glock_thaw(sdp); | ||
338 | } else { | ||
339 | ret = -EINVAL; | ||
340 | } | ||
341 | return ret; | ||
342 | } | ||
343 | |||
344 | static ssize_t lkid_show(struct gfs2_sbd *sdp, char *buf) | ||
345 | { | ||
346 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
347 | return sprintf(buf, "%u\n", ls->ls_id); | ||
348 | } | ||
349 | |||
350 | static ssize_t lkfirst_show(struct gfs2_sbd *sdp, char *buf) | ||
351 | { | ||
352 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
353 | return sprintf(buf, "%d\n", ls->ls_first); | ||
354 | } | ||
355 | |||
356 | static ssize_t first_done_show(struct gfs2_sbd *sdp, char *buf) | ||
357 | { | ||
358 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
359 | return sprintf(buf, "%d\n", ls->ls_first_done); | ||
360 | } | ||
361 | |||
362 | static ssize_t recover_show(struct gfs2_sbd *sdp, char *buf) | ||
363 | { | ||
364 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
365 | return sprintf(buf, "%d\n", ls->ls_recover_jid); | ||
366 | } | ||
367 | |||
368 | static void gfs2_jdesc_make_dirty(struct gfs2_sbd *sdp, unsigned int jid) | ||
369 | { | ||
370 | struct gfs2_jdesc *jd; | ||
371 | |||
372 | spin_lock(&sdp->sd_jindex_spin); | ||
373 | list_for_each_entry(jd, &sdp->sd_jindex_list, jd_list) { | ||
374 | if (jd->jd_jid != jid) | ||
375 | continue; | ||
376 | jd->jd_dirty = 1; | ||
377 | break; | ||
378 | } | ||
379 | spin_unlock(&sdp->sd_jindex_spin); | ||
380 | } | ||
381 | |||
382 | static ssize_t recover_store(struct gfs2_sbd *sdp, const char *buf, size_t len) | ||
383 | { | ||
384 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
385 | ls->ls_recover_jid = simple_strtol(buf, NULL, 0); | ||
386 | gfs2_jdesc_make_dirty(sdp, ls->ls_recover_jid); | ||
387 | if (sdp->sd_recoverd_process) | ||
388 | wake_up_process(sdp->sd_recoverd_process); | ||
389 | return len; | ||
390 | } | ||
391 | |||
392 | static ssize_t recover_done_show(struct gfs2_sbd *sdp, char *buf) | ||
393 | { | ||
394 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
395 | return sprintf(buf, "%d\n", ls->ls_recover_jid_done); | ||
396 | } | ||
397 | |||
398 | static ssize_t recover_status_show(struct gfs2_sbd *sdp, char *buf) | ||
399 | { | ||
400 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
401 | return sprintf(buf, "%d\n", ls->ls_recover_jid_status); | ||
402 | } | ||
403 | |||
404 | struct gdlm_attr { | ||
405 | struct attribute attr; | ||
406 | ssize_t (*show)(struct gfs2_sbd *sdp, char *); | ||
407 | ssize_t (*store)(struct gfs2_sbd *sdp, const char *, size_t); | ||
408 | }; | ||
409 | |||
410 | #define GDLM_ATTR(_name,_mode,_show,_store) \ | ||
411 | static struct gdlm_attr gdlm_attr_##_name = __ATTR(_name,_mode,_show,_store) | ||
412 | |||
413 | GDLM_ATTR(proto_name, 0444, proto_name_show, NULL); | ||
414 | GDLM_ATTR(block, 0644, block_show, block_store); | ||
415 | GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store); | ||
416 | GDLM_ATTR(id, 0444, lkid_show, NULL); | ||
417 | GDLM_ATTR(first, 0444, lkfirst_show, NULL); | ||
418 | GDLM_ATTR(first_done, 0444, first_done_show, NULL); | ||
419 | GDLM_ATTR(recover, 0644, recover_show, recover_store); | ||
420 | GDLM_ATTR(recover_done, 0444, recover_done_show, NULL); | ||
421 | GDLM_ATTR(recover_status, 0444, recover_status_show, NULL); | ||
422 | |||
423 | static struct attribute *lock_module_attrs[] = { | ||
424 | &gdlm_attr_proto_name.attr, | ||
425 | &gdlm_attr_block.attr, | ||
426 | &gdlm_attr_withdraw.attr, | ||
427 | &gdlm_attr_id.attr, | ||
428 | &lockstruct_attr_jid.attr, | ||
429 | &gdlm_attr_first.attr, | ||
430 | &gdlm_attr_first_done.attr, | ||
431 | &gdlm_attr_recover.attr, | ||
432 | &gdlm_attr_recover_done.attr, | ||
433 | &gdlm_attr_recover_status.attr, | ||
235 | NULL, | 434 | NULL, |
236 | }; | 435 | }; |
237 | 436 | ||
@@ -373,7 +572,6 @@ TUNE_ATTR(complain_secs, 0); | |||
373 | TUNE_ATTR(statfs_slow, 0); | 572 | TUNE_ATTR(statfs_slow, 0); |
374 | TUNE_ATTR(new_files_jdata, 0); | 573 | TUNE_ATTR(new_files_jdata, 0); |
375 | TUNE_ATTR(quota_simul_sync, 1); | 574 | TUNE_ATTR(quota_simul_sync, 1); |
376 | TUNE_ATTR(quota_cache_secs, 1); | ||
377 | TUNE_ATTR(stall_secs, 1); | 575 | TUNE_ATTR(stall_secs, 1); |
378 | TUNE_ATTR(statfs_quantum, 1); | 576 | TUNE_ATTR(statfs_quantum, 1); |
379 | TUNE_ATTR_DAEMON(recoverd_secs, recoverd_process); | 577 | TUNE_ATTR_DAEMON(recoverd_secs, recoverd_process); |
@@ -389,7 +587,6 @@ static struct attribute *tune_attrs[] = { | |||
389 | &tune_attr_complain_secs.attr, | 587 | &tune_attr_complain_secs.attr, |
390 | &tune_attr_statfs_slow.attr, | 588 | &tune_attr_statfs_slow.attr, |
391 | &tune_attr_quota_simul_sync.attr, | 589 | &tune_attr_quota_simul_sync.attr, |
392 | &tune_attr_quota_cache_secs.attr, | ||
393 | &tune_attr_stall_secs.attr, | 590 | &tune_attr_stall_secs.attr, |
394 | &tune_attr_statfs_quantum.attr, | 591 | &tune_attr_statfs_quantum.attr, |
395 | &tune_attr_recoverd_secs.attr, | 592 | &tune_attr_recoverd_secs.attr, |
@@ -414,6 +611,11 @@ static struct attribute_group tune_group = { | |||
414 | .attrs = tune_attrs, | 611 | .attrs = tune_attrs, |
415 | }; | 612 | }; |
416 | 613 | ||
614 | static struct attribute_group lock_module_group = { | ||
615 | .name = "lock_module", | ||
616 | .attrs = lock_module_attrs, | ||
617 | }; | ||
618 | |||
417 | int gfs2_sys_fs_add(struct gfs2_sbd *sdp) | 619 | int gfs2_sys_fs_add(struct gfs2_sbd *sdp) |
418 | { | 620 | { |
419 | int error; | 621 | int error; |
@@ -436,9 +638,15 @@ int gfs2_sys_fs_add(struct gfs2_sbd *sdp) | |||
436 | if (error) | 638 | if (error) |
437 | goto fail_args; | 639 | goto fail_args; |
438 | 640 | ||
641 | error = sysfs_create_group(&sdp->sd_kobj, &lock_module_group); | ||
642 | if (error) | ||
643 | goto fail_tune; | ||
644 | |||
439 | kobject_uevent(&sdp->sd_kobj, KOBJ_ADD); | 645 | kobject_uevent(&sdp->sd_kobj, KOBJ_ADD); |
440 | return 0; | 646 | return 0; |
441 | 647 | ||
648 | fail_tune: | ||
649 | sysfs_remove_group(&sdp->sd_kobj, &tune_group); | ||
442 | fail_args: | 650 | fail_args: |
443 | sysfs_remove_group(&sdp->sd_kobj, &args_group); | 651 | sysfs_remove_group(&sdp->sd_kobj, &args_group); |
444 | fail_lockstruct: | 652 | fail_lockstruct: |
@@ -455,15 +663,27 @@ void gfs2_sys_fs_del(struct gfs2_sbd *sdp) | |||
455 | sysfs_remove_group(&sdp->sd_kobj, &tune_group); | 663 | sysfs_remove_group(&sdp->sd_kobj, &tune_group); |
456 | sysfs_remove_group(&sdp->sd_kobj, &args_group); | 664 | sysfs_remove_group(&sdp->sd_kobj, &args_group); |
457 | sysfs_remove_group(&sdp->sd_kobj, &lockstruct_group); | 665 | sysfs_remove_group(&sdp->sd_kobj, &lockstruct_group); |
666 | sysfs_remove_group(&sdp->sd_kobj, &lock_module_group); | ||
458 | kobject_put(&sdp->sd_kobj); | 667 | kobject_put(&sdp->sd_kobj); |
459 | } | 668 | } |
460 | 669 | ||
670 | |||
461 | static int gfs2_uevent(struct kset *kset, struct kobject *kobj, | 671 | static int gfs2_uevent(struct kset *kset, struct kobject *kobj, |
462 | struct kobj_uevent_env *env) | 672 | struct kobj_uevent_env *env) |
463 | { | 673 | { |
464 | struct gfs2_sbd *sdp = container_of(kobj, struct gfs2_sbd, sd_kobj); | 674 | struct gfs2_sbd *sdp = container_of(kobj, struct gfs2_sbd, sd_kobj); |
675 | const u8 *uuid = sdp->sd_sb.sb_uuid; | ||
676 | |||
465 | add_uevent_var(env, "LOCKTABLE=%s", sdp->sd_table_name); | 677 | add_uevent_var(env, "LOCKTABLE=%s", sdp->sd_table_name); |
466 | add_uevent_var(env, "LOCKPROTO=%s", sdp->sd_proto_name); | 678 | add_uevent_var(env, "LOCKPROTO=%s", sdp->sd_proto_name); |
679 | if (gfs2_uuid_valid(uuid)) { | ||
680 | add_uevent_var(env, "UUID=%02X%02X%02X%02X-%02X%02X-%02X%02X-" | ||
681 | "%02X%02X-%02X%02X%02X%02X%02X%02X", | ||
682 | uuid[0], uuid[1], uuid[2], uuid[3], uuid[4], | ||
683 | uuid[5], uuid[6], uuid[7], uuid[8], uuid[9], | ||
684 | uuid[10], uuid[11], uuid[12], uuid[13], | ||
685 | uuid[14], uuid[15]); | ||
686 | } | ||
467 | return 0; | 687 | return 0; |
468 | } | 688 | } |
469 | 689 | ||
diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c index f677b8a83f0c..053752d4b27f 100644 --- a/fs/gfs2/trans.c +++ b/fs/gfs2/trans.c | |||
@@ -12,9 +12,8 @@ | |||
12 | #include <linux/spinlock.h> | 12 | #include <linux/spinlock.h> |
13 | #include <linux/completion.h> | 13 | #include <linux/completion.h> |
14 | #include <linux/buffer_head.h> | 14 | #include <linux/buffer_head.h> |
15 | #include <linux/gfs2_ondisk.h> | ||
16 | #include <linux/kallsyms.h> | 15 | #include <linux/kallsyms.h> |
17 | #include <linux/lm_interface.h> | 16 | #include <linux/gfs2_ondisk.h> |
18 | 17 | ||
19 | #include "gfs2.h" | 18 | #include "gfs2.h" |
20 | #include "incore.h" | 19 | #include "incore.h" |
@@ -88,9 +87,11 @@ void gfs2_trans_end(struct gfs2_sbd *sdp) | |||
88 | 87 | ||
89 | if (!tr->tr_touched) { | 88 | if (!tr->tr_touched) { |
90 | gfs2_log_release(sdp, tr->tr_reserved); | 89 | gfs2_log_release(sdp, tr->tr_reserved); |
91 | gfs2_glock_dq(&tr->tr_t_gh); | 90 | if (tr->tr_t_gh.gh_gl) { |
92 | gfs2_holder_uninit(&tr->tr_t_gh); | 91 | gfs2_glock_dq(&tr->tr_t_gh); |
93 | kfree(tr); | 92 | gfs2_holder_uninit(&tr->tr_t_gh); |
93 | kfree(tr); | ||
94 | } | ||
94 | return; | 95 | return; |
95 | } | 96 | } |
96 | 97 | ||
@@ -106,9 +107,11 @@ void gfs2_trans_end(struct gfs2_sbd *sdp) | |||
106 | } | 107 | } |
107 | 108 | ||
108 | gfs2_log_commit(sdp, tr); | 109 | gfs2_log_commit(sdp, tr); |
109 | gfs2_glock_dq(&tr->tr_t_gh); | 110 | if (tr->tr_t_gh.gh_gl) { |
110 | gfs2_holder_uninit(&tr->tr_t_gh); | 111 | gfs2_glock_dq(&tr->tr_t_gh); |
111 | kfree(tr); | 112 | gfs2_holder_uninit(&tr->tr_t_gh); |
113 | kfree(tr); | ||
114 | } | ||
112 | 115 | ||
113 | if (sdp->sd_vfs->s_flags & MS_SYNCHRONOUS) | 116 | if (sdp->sd_vfs->s_flags & MS_SYNCHRONOUS) |
114 | gfs2_log_flush(sdp, NULL); | 117 | gfs2_log_flush(sdp, NULL); |
diff --git a/fs/gfs2/util.c b/fs/gfs2/util.c index 374f50e95496..9d12b1118ba0 100644 --- a/fs/gfs2/util.c +++ b/fs/gfs2/util.c | |||
@@ -13,7 +13,6 @@ | |||
13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
14 | #include <linux/crc32.h> | 14 | #include <linux/crc32.h> |
15 | #include <linux/gfs2_ondisk.h> | 15 | #include <linux/gfs2_ondisk.h> |
16 | #include <linux/lm_interface.h> | ||
17 | #include <asm/uaccess.h> | 16 | #include <asm/uaccess.h> |
18 | 17 | ||
19 | #include "gfs2.h" | 18 | #include "gfs2.h" |
@@ -35,6 +34,8 @@ void gfs2_assert_i(struct gfs2_sbd *sdp) | |||
35 | 34 | ||
36 | int gfs2_lm_withdraw(struct gfs2_sbd *sdp, char *fmt, ...) | 35 | int gfs2_lm_withdraw(struct gfs2_sbd *sdp, char *fmt, ...) |
37 | { | 36 | { |
37 | struct lm_lockstruct *ls = &sdp->sd_lockstruct; | ||
38 | const struct lm_lockops *lm = ls->ls_ops; | ||
38 | va_list args; | 39 | va_list args; |
39 | 40 | ||
40 | if (test_and_set_bit(SDF_SHUTDOWN, &sdp->sd_flags)) | 41 | if (test_and_set_bit(SDF_SHUTDOWN, &sdp->sd_flags)) |
@@ -47,8 +48,12 @@ int gfs2_lm_withdraw(struct gfs2_sbd *sdp, char *fmt, ...) | |||
47 | fs_err(sdp, "about to withdraw this file system\n"); | 48 | fs_err(sdp, "about to withdraw this file system\n"); |
48 | BUG_ON(sdp->sd_args.ar_debug); | 49 | BUG_ON(sdp->sd_args.ar_debug); |
49 | 50 | ||
50 | fs_err(sdp, "telling LM to withdraw\n"); | 51 | kobject_uevent(&sdp->sd_kobj, KOBJ_OFFLINE); |
51 | gfs2_withdraw_lockproto(&sdp->sd_lockstruct); | 52 | |
53 | if (lm->lm_unmount) { | ||
54 | fs_err(sdp, "telling LM to unmount\n"); | ||
55 | lm->lm_unmount(sdp); | ||
56 | } | ||
52 | fs_err(sdp, "withdrawn\n"); | 57 | fs_err(sdp, "withdrawn\n"); |
53 | dump_stack(); | 58 | dump_stack(); |
54 | 59 | ||
diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 9955232fdf8c..052387e11671 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h | |||
@@ -213,7 +213,7 @@ extern void hfs_mdb_put(struct super_block *); | |||
213 | extern int hfs_part_find(struct super_block *, sector_t *, sector_t *); | 213 | extern int hfs_part_find(struct super_block *, sector_t *, sector_t *); |
214 | 214 | ||
215 | /* string.c */ | 215 | /* string.c */ |
216 | extern struct dentry_operations hfs_dentry_operations; | 216 | extern const struct dentry_operations hfs_dentry_operations; |
217 | 217 | ||
218 | extern int hfs_hash_dentry(struct dentry *, struct qstr *); | 218 | extern int hfs_hash_dentry(struct dentry *, struct qstr *); |
219 | extern int hfs_strcmp(const unsigned char *, unsigned int, | 219 | extern int hfs_strcmp(const unsigned char *, unsigned int, |
diff --git a/fs/hfs/sysdep.c b/fs/hfs/sysdep.c index 5bf89ec01cd4..7478f5c219aa 100644 --- a/fs/hfs/sysdep.c +++ b/fs/hfs/sysdep.c | |||
@@ -31,7 +31,7 @@ static int hfs_revalidate_dentry(struct dentry *dentry, struct nameidata *nd) | |||
31 | return 1; | 31 | return 1; |
32 | } | 32 | } |
33 | 33 | ||
34 | struct dentry_operations hfs_dentry_operations = | 34 | const struct dentry_operations hfs_dentry_operations = |
35 | { | 35 | { |
36 | .d_revalidate = hfs_revalidate_dentry, | 36 | .d_revalidate = hfs_revalidate_dentry, |
37 | .d_hash = hfs_hash_dentry, | 37 | .d_hash = hfs_hash_dentry, |
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h index f027a905225f..5c10d803d9df 100644 --- a/fs/hfsplus/hfsplus_fs.h +++ b/fs/hfsplus/hfsplus_fs.h | |||
@@ -327,7 +327,7 @@ void hfsplus_file_truncate(struct inode *); | |||
327 | /* inode.c */ | 327 | /* inode.c */ |
328 | extern const struct address_space_operations hfsplus_aops; | 328 | extern const struct address_space_operations hfsplus_aops; |
329 | extern const struct address_space_operations hfsplus_btree_aops; | 329 | extern const struct address_space_operations hfsplus_btree_aops; |
330 | extern struct dentry_operations hfsplus_dentry_operations; | 330 | extern const struct dentry_operations hfsplus_dentry_operations; |
331 | 331 | ||
332 | void hfsplus_inode_read_fork(struct inode *, struct hfsplus_fork_raw *); | 332 | void hfsplus_inode_read_fork(struct inode *, struct hfsplus_fork_raw *); |
333 | void hfsplus_inode_write_fork(struct inode *, struct hfsplus_fork_raw *); | 333 | void hfsplus_inode_write_fork(struct inode *, struct hfsplus_fork_raw *); |
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index f105ee9e1cc4..1bcf597c0562 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c | |||
@@ -137,7 +137,7 @@ const struct address_space_operations hfsplus_aops = { | |||
137 | .writepages = hfsplus_writepages, | 137 | .writepages = hfsplus_writepages, |
138 | }; | 138 | }; |
139 | 139 | ||
140 | struct dentry_operations hfsplus_dentry_operations = { | 140 | const struct dentry_operations hfsplus_dentry_operations = { |
141 | .d_hash = hfsplus_hash_dentry, | 141 | .d_hash = hfsplus_hash_dentry, |
142 | .d_compare = hfsplus_compare_dentry, | 142 | .d_compare = hfsplus_compare_dentry, |
143 | }; | 143 | }; |
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 5c538e0ec14b..fe02ad4740e7 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c | |||
@@ -31,12 +31,12 @@ static inline struct hostfs_inode_info *HOSTFS_I(struct inode *inode) | |||
31 | 31 | ||
32 | #define FILE_HOSTFS_I(file) HOSTFS_I((file)->f_path.dentry->d_inode) | 32 | #define FILE_HOSTFS_I(file) HOSTFS_I((file)->f_path.dentry->d_inode) |
33 | 33 | ||
34 | int hostfs_d_delete(struct dentry *dentry) | 34 | static int hostfs_d_delete(struct dentry *dentry) |
35 | { | 35 | { |
36 | return 1; | 36 | return 1; |
37 | } | 37 | } |
38 | 38 | ||
39 | struct dentry_operations hostfs_dentry_ops = { | 39 | static const struct dentry_operations hostfs_dentry_ops = { |
40 | .d_delete = hostfs_d_delete, | 40 | .d_delete = hostfs_d_delete, |
41 | }; | 41 | }; |
42 | 42 | ||
diff --git a/fs/hpfs/dentry.c b/fs/hpfs/dentry.c index 08319126b2af..940d6d150bee 100644 --- a/fs/hpfs/dentry.c +++ b/fs/hpfs/dentry.c | |||
@@ -49,7 +49,7 @@ static int hpfs_compare_dentry(struct dentry *dentry, struct qstr *a, struct qst | |||
49 | return 0; | 49 | return 0; |
50 | } | 50 | } |
51 | 51 | ||
52 | static struct dentry_operations hpfs_dentry_operations = { | 52 | static const struct dentry_operations hpfs_dentry_operations = { |
53 | .d_hash = hpfs_hash_dentry, | 53 | .d_hash = hpfs_hash_dentry, |
54 | .d_compare = hpfs_compare_dentry, | 54 | .d_compare = hpfs_compare_dentry, |
55 | }; | 55 | }; |
diff --git a/fs/inode.c b/fs/inode.c index 826fb0b9d1c3..d06d6d268de9 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
@@ -17,6 +17,7 @@ | |||
17 | #include <linux/hash.h> | 17 | #include <linux/hash.h> |
18 | #include <linux/swap.h> | 18 | #include <linux/swap.h> |
19 | #include <linux/security.h> | 19 | #include <linux/security.h> |
20 | #include <linux/ima.h> | ||
20 | #include <linux/pagemap.h> | 21 | #include <linux/pagemap.h> |
21 | #include <linux/cdev.h> | 22 | #include <linux/cdev.h> |
22 | #include <linux/bootmem.h> | 23 | #include <linux/bootmem.h> |
@@ -147,13 +148,13 @@ struct inode *inode_init_always(struct super_block *sb, struct inode *inode) | |||
147 | inode->i_cdev = NULL; | 148 | inode->i_cdev = NULL; |
148 | inode->i_rdev = 0; | 149 | inode->i_rdev = 0; |
149 | inode->dirtied_when = 0; | 150 | inode->dirtied_when = 0; |
150 | if (security_inode_alloc(inode)) { | 151 | |
151 | if (inode->i_sb->s_op->destroy_inode) | 152 | if (security_inode_alloc(inode)) |
152 | inode->i_sb->s_op->destroy_inode(inode); | 153 | goto out_free_inode; |
153 | else | 154 | |
154 | kmem_cache_free(inode_cachep, (inode)); | 155 | /* allocate and initialize an i_integrity */ |
155 | return NULL; | 156 | if (ima_inode_alloc(inode)) |
156 | } | 157 | goto out_free_security; |
157 | 158 | ||
158 | spin_lock_init(&inode->i_lock); | 159 | spin_lock_init(&inode->i_lock); |
159 | lockdep_set_class(&inode->i_lock, &sb->s_type->i_lock_key); | 160 | lockdep_set_class(&inode->i_lock, &sb->s_type->i_lock_key); |
@@ -189,6 +190,15 @@ struct inode *inode_init_always(struct super_block *sb, struct inode *inode) | |||
189 | inode->i_mapping = mapping; | 190 | inode->i_mapping = mapping; |
190 | 191 | ||
191 | return inode; | 192 | return inode; |
193 | |||
194 | out_free_security: | ||
195 | security_inode_free(inode); | ||
196 | out_free_inode: | ||
197 | if (inode->i_sb->s_op->destroy_inode) | ||
198 | inode->i_sb->s_op->destroy_inode(inode); | ||
199 | else | ||
200 | kmem_cache_free(inode_cachep, (inode)); | ||
201 | return NULL; | ||
192 | } | 202 | } |
193 | EXPORT_SYMBOL(inode_init_always); | 203 | EXPORT_SYMBOL(inode_init_always); |
194 | 204 | ||
@@ -284,7 +294,7 @@ void clear_inode(struct inode *inode) | |||
284 | BUG_ON(!(inode->i_state & I_FREEING)); | 294 | BUG_ON(!(inode->i_state & I_FREEING)); |
285 | BUG_ON(inode->i_state & I_CLEAR); | 295 | BUG_ON(inode->i_state & I_CLEAR); |
286 | inode_sync_wait(inode); | 296 | inode_sync_wait(inode); |
287 | DQUOT_DROP(inode); | 297 | vfs_dq_drop(inode); |
288 | if (inode->i_sb->s_op->clear_inode) | 298 | if (inode->i_sb->s_op->clear_inode) |
289 | inode->i_sb->s_op->clear_inode(inode); | 299 | inode->i_sb->s_op->clear_inode(inode); |
290 | if (S_ISBLK(inode->i_mode) && inode->i_bdev) | 300 | if (S_ISBLK(inode->i_mode) && inode->i_bdev) |
@@ -356,6 +366,8 @@ static int invalidate_list(struct list_head *head, struct list_head *dispose) | |||
356 | if (tmp == head) | 366 | if (tmp == head) |
357 | break; | 367 | break; |
358 | inode = list_entry(tmp, struct inode, i_sb_list); | 368 | inode = list_entry(tmp, struct inode, i_sb_list); |
369 | if (inode->i_state & I_NEW) | ||
370 | continue; | ||
359 | invalidate_inode_buffers(inode); | 371 | invalidate_inode_buffers(inode); |
360 | if (!atomic_read(&inode->i_count)) { | 372 | if (!atomic_read(&inode->i_count)) { |
361 | list_move(&inode->i_list, dispose); | 373 | list_move(&inode->i_list, dispose); |
@@ -1158,7 +1170,7 @@ void generic_delete_inode(struct inode *inode) | |||
1158 | if (op->delete_inode) { | 1170 | if (op->delete_inode) { |
1159 | void (*delete)(struct inode *) = op->delete_inode; | 1171 | void (*delete)(struct inode *) = op->delete_inode; |
1160 | if (!is_bad_inode(inode)) | 1172 | if (!is_bad_inode(inode)) |
1161 | DQUOT_INIT(inode); | 1173 | vfs_dq_init(inode); |
1162 | /* Filesystems implementing their own | 1174 | /* Filesystems implementing their own |
1163 | * s_op->delete_inode are required to call | 1175 | * s_op->delete_inode are required to call |
1164 | * truncate_inode_pages and clear_inode() | 1176 | * truncate_inode_pages and clear_inode() |
@@ -1290,6 +1302,40 @@ sector_t bmap(struct inode * inode, sector_t block) | |||
1290 | } | 1302 | } |
1291 | EXPORT_SYMBOL(bmap); | 1303 | EXPORT_SYMBOL(bmap); |
1292 | 1304 | ||
1305 | /* | ||
1306 | * With relative atime, only update atime if the previous atime is | ||
1307 | * earlier than either the ctime or mtime or if at least a day has | ||
1308 | * passed since the last atime update. | ||
1309 | */ | ||
1310 | static int relatime_need_update(struct vfsmount *mnt, struct inode *inode, | ||
1311 | struct timespec now) | ||
1312 | { | ||
1313 | |||
1314 | if (!(mnt->mnt_flags & MNT_RELATIME)) | ||
1315 | return 1; | ||
1316 | /* | ||
1317 | * Is mtime younger than atime? If yes, update atime: | ||
1318 | */ | ||
1319 | if (timespec_compare(&inode->i_mtime, &inode->i_atime) >= 0) | ||
1320 | return 1; | ||
1321 | /* | ||
1322 | * Is ctime younger than atime? If yes, update atime: | ||
1323 | */ | ||
1324 | if (timespec_compare(&inode->i_ctime, &inode->i_atime) >= 0) | ||
1325 | return 1; | ||
1326 | |||
1327 | /* | ||
1328 | * Is the previous atime value older than a day? If yes, | ||
1329 | * update atime: | ||
1330 | */ | ||
1331 | if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60) | ||
1332 | return 1; | ||
1333 | /* | ||
1334 | * Good, we can skip the atime update: | ||
1335 | */ | ||
1336 | return 0; | ||
1337 | } | ||
1338 | |||
1293 | /** | 1339 | /** |
1294 | * touch_atime - update the access time | 1340 | * touch_atime - update the access time |
1295 | * @mnt: mount the inode is accessed on | 1341 | * @mnt: mount the inode is accessed on |
@@ -1317,17 +1363,12 @@ void touch_atime(struct vfsmount *mnt, struct dentry *dentry) | |||
1317 | goto out; | 1363 | goto out; |
1318 | if ((mnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode)) | 1364 | if ((mnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode)) |
1319 | goto out; | 1365 | goto out; |
1320 | if (mnt->mnt_flags & MNT_RELATIME) { | ||
1321 | /* | ||
1322 | * With relative atime, only update atime if the previous | ||
1323 | * atime is earlier than either the ctime or mtime. | ||
1324 | */ | ||
1325 | if (timespec_compare(&inode->i_mtime, &inode->i_atime) < 0 && | ||
1326 | timespec_compare(&inode->i_ctime, &inode->i_atime) < 0) | ||
1327 | goto out; | ||
1328 | } | ||
1329 | 1366 | ||
1330 | now = current_fs_time(inode->i_sb); | 1367 | now = current_fs_time(inode->i_sb); |
1368 | |||
1369 | if (!relatime_need_update(mnt, inode, now)) | ||
1370 | goto out; | ||
1371 | |||
1331 | if (timespec_equal(&inode->i_atime, &now)) | 1372 | if (timespec_equal(&inode->i_atime, &now)) |
1332 | goto out; | 1373 | goto out; |
1333 | 1374 | ||
diff --git a/fs/internal.h b/fs/internal.h index 0d8ac497b3d5..53af885f1732 100644 --- a/fs/internal.h +++ b/fs/internal.h | |||
@@ -43,7 +43,7 @@ extern void __init chrdev_init(void); | |||
43 | /* | 43 | /* |
44 | * exec.c | 44 | * exec.c |
45 | */ | 45 | */ |
46 | extern void check_unsafe_exec(struct linux_binprm *, struct files_struct *); | 46 | extern void check_unsafe_exec(struct linux_binprm *); |
47 | 47 | ||
48 | /* | 48 | /* |
49 | * namespace.c | 49 | * namespace.c |
diff --git a/fs/ioctl.c b/fs/ioctl.c index 240ec63984cb..ac2d47e43926 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c | |||
@@ -404,10 +404,12 @@ static int ioctl_fionbio(struct file *filp, int __user *argp) | |||
404 | if (O_NONBLOCK != O_NDELAY) | 404 | if (O_NONBLOCK != O_NDELAY) |
405 | flag |= O_NDELAY; | 405 | flag |= O_NDELAY; |
406 | #endif | 406 | #endif |
407 | spin_lock(&filp->f_lock); | ||
407 | if (on) | 408 | if (on) |
408 | filp->f_flags |= flag; | 409 | filp->f_flags |= flag; |
409 | else | 410 | else |
410 | filp->f_flags &= ~flag; | 411 | filp->f_flags &= ~flag; |
412 | spin_unlock(&filp->f_lock); | ||
411 | return error; | 413 | return error; |
412 | } | 414 | } |
413 | 415 | ||
@@ -425,18 +427,12 @@ static int ioctl_fioasync(unsigned int fd, struct file *filp, | |||
425 | /* Did FASYNC state change ? */ | 427 | /* Did FASYNC state change ? */ |
426 | if ((flag ^ filp->f_flags) & FASYNC) { | 428 | if ((flag ^ filp->f_flags) & FASYNC) { |
427 | if (filp->f_op && filp->f_op->fasync) | 429 | if (filp->f_op && filp->f_op->fasync) |
430 | /* fasync() adjusts filp->f_flags */ | ||
428 | error = filp->f_op->fasync(fd, filp, on); | 431 | error = filp->f_op->fasync(fd, filp, on); |
429 | else | 432 | else |
430 | error = -ENOTTY; | 433 | error = -ENOTTY; |
431 | } | 434 | } |
432 | if (error) | 435 | return error < 0 ? error : 0; |
433 | return error; | ||
434 | |||
435 | if (on) | ||
436 | filp->f_flags |= FASYNC; | ||
437 | else | ||
438 | filp->f_flags &= ~FASYNC; | ||
439 | return error; | ||
440 | } | 436 | } |
441 | 437 | ||
442 | static int ioctl_fsfreeze(struct file *filp) | 438 | static int ioctl_fsfreeze(struct file *filp) |
@@ -499,17 +495,11 @@ int do_vfs_ioctl(struct file *filp, unsigned int fd, unsigned int cmd, | |||
499 | break; | 495 | break; |
500 | 496 | ||
501 | case FIONBIO: | 497 | case FIONBIO: |
502 | /* BKL needed to avoid races tweaking f_flags */ | ||
503 | lock_kernel(); | ||
504 | error = ioctl_fionbio(filp, argp); | 498 | error = ioctl_fionbio(filp, argp); |
505 | unlock_kernel(); | ||
506 | break; | 499 | break; |
507 | 500 | ||
508 | case FIOASYNC: | 501 | case FIOASYNC: |
509 | /* BKL needed to avoid races tweaking f_flags */ | ||
510 | lock_kernel(); | ||
511 | error = ioctl_fioasync(fd, filp, argp); | 502 | error = ioctl_fioasync(fd, filp, argp); |
512 | unlock_kernel(); | ||
513 | break; | 503 | break; |
514 | 504 | ||
515 | case FIOQSIZE: | 505 | case FIOQSIZE: |
diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c index 6147ec3643a0..13d2eddd0692 100644 --- a/fs/isofs/inode.c +++ b/fs/isofs/inode.c | |||
@@ -114,7 +114,7 @@ static const struct super_operations isofs_sops = { | |||
114 | }; | 114 | }; |
115 | 115 | ||
116 | 116 | ||
117 | static struct dentry_operations isofs_dentry_ops[] = { | 117 | static const struct dentry_operations isofs_dentry_ops[] = { |
118 | { | 118 | { |
119 | .d_hash = isofs_hash, | 119 | .d_hash = isofs_hash, |
120 | .d_compare = isofs_dentry_cmp, | 120 | .d_compare = isofs_dentry_cmp, |
diff --git a/fs/jfs/Kconfig b/fs/jfs/Kconfig index 9ff619a6f9cc..57cef19951db 100644 --- a/fs/jfs/Kconfig +++ b/fs/jfs/Kconfig | |||
@@ -1,6 +1,7 @@ | |||
1 | config JFS_FS | 1 | config JFS_FS |
2 | tristate "JFS filesystem support" | 2 | tristate "JFS filesystem support" |
3 | select NLS | 3 | select NLS |
4 | select CRC32 | ||
4 | help | 5 | help |
5 | This is a port of IBM's Journaled Filesystem . More information is | 6 | This is a port of IBM's Journaled Filesystem . More information is |
6 | available in the file <file:Documentation/filesystems/jfs.txt>. | 7 | available in the file <file:Documentation/filesystems/jfs.txt>. |
diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index d3e5c33665de..a166c1669e82 100644 --- a/fs/jfs/acl.c +++ b/fs/jfs/acl.c | |||
@@ -233,7 +233,7 @@ int jfs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
233 | 233 | ||
234 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | 234 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || |
235 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | 235 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { |
236 | if (DQUOT_TRANSFER(inode, iattr)) | 236 | if (vfs_dq_transfer(inode, iattr)) |
237 | return -EDQUOT; | 237 | return -EDQUOT; |
238 | } | 238 | } |
239 | 239 | ||
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index b00ee9f05a06..b2ae190a77ba 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
@@ -158,9 +158,9 @@ void jfs_delete_inode(struct inode *inode) | |||
158 | /* | 158 | /* |
159 | * Free the inode from the quota allocation. | 159 | * Free the inode from the quota allocation. |
160 | */ | 160 | */ |
161 | DQUOT_INIT(inode); | 161 | vfs_dq_init(inode); |
162 | DQUOT_FREE_INODE(inode); | 162 | vfs_dq_free_inode(inode); |
163 | DQUOT_DROP(inode); | 163 | vfs_dq_drop(inode); |
164 | } | 164 | } |
165 | 165 | ||
166 | clear_inode(inode); | 166 | clear_inode(inode); |
diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c index 4dcc05819998..925871e9887b 100644 --- a/fs/jfs/jfs_dtree.c +++ b/fs/jfs/jfs_dtree.c | |||
@@ -381,10 +381,10 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot) | |||
381 | * It's time to move the inline table to an external | 381 | * It's time to move the inline table to an external |
382 | * page and begin to build the xtree | 382 | * page and begin to build the xtree |
383 | */ | 383 | */ |
384 | if (DQUOT_ALLOC_BLOCK(ip, sbi->nbperpage)) | 384 | if (vfs_dq_alloc_block(ip, sbi->nbperpage)) |
385 | goto clean_up; | 385 | goto clean_up; |
386 | if (dbAlloc(ip, 0, sbi->nbperpage, &xaddr)) { | 386 | if (dbAlloc(ip, 0, sbi->nbperpage, &xaddr)) { |
387 | DQUOT_FREE_BLOCK(ip, sbi->nbperpage); | 387 | vfs_dq_free_block(ip, sbi->nbperpage); |
388 | goto clean_up; | 388 | goto clean_up; |
389 | } | 389 | } |
390 | 390 | ||
@@ -408,7 +408,7 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot) | |||
408 | memcpy(&jfs_ip->i_dirtable, temp_table, | 408 | memcpy(&jfs_ip->i_dirtable, temp_table, |
409 | sizeof (temp_table)); | 409 | sizeof (temp_table)); |
410 | dbFree(ip, xaddr, sbi->nbperpage); | 410 | dbFree(ip, xaddr, sbi->nbperpage); |
411 | DQUOT_FREE_BLOCK(ip, sbi->nbperpage); | 411 | vfs_dq_free_block(ip, sbi->nbperpage); |
412 | goto clean_up; | 412 | goto clean_up; |
413 | } | 413 | } |
414 | ip->i_size = PSIZE; | 414 | ip->i_size = PSIZE; |
@@ -1027,7 +1027,7 @@ static int dtSplitUp(tid_t tid, | |||
1027 | n = xlen; | 1027 | n = xlen; |
1028 | 1028 | ||
1029 | /* Allocate blocks to quota. */ | 1029 | /* Allocate blocks to quota. */ |
1030 | if (DQUOT_ALLOC_BLOCK(ip, n)) { | 1030 | if (vfs_dq_alloc_block(ip, n)) { |
1031 | rc = -EDQUOT; | 1031 | rc = -EDQUOT; |
1032 | goto extendOut; | 1032 | goto extendOut; |
1033 | } | 1033 | } |
@@ -1308,7 +1308,7 @@ static int dtSplitUp(tid_t tid, | |||
1308 | 1308 | ||
1309 | /* Rollback quota allocation */ | 1309 | /* Rollback quota allocation */ |
1310 | if (rc && quota_allocation) | 1310 | if (rc && quota_allocation) |
1311 | DQUOT_FREE_BLOCK(ip, quota_allocation); | 1311 | vfs_dq_free_block(ip, quota_allocation); |
1312 | 1312 | ||
1313 | dtSplitUp_Exit: | 1313 | dtSplitUp_Exit: |
1314 | 1314 | ||
@@ -1369,7 +1369,7 @@ static int dtSplitPage(tid_t tid, struct inode *ip, struct dtsplit * split, | |||
1369 | return -EIO; | 1369 | return -EIO; |
1370 | 1370 | ||
1371 | /* Allocate blocks to quota. */ | 1371 | /* Allocate blocks to quota. */ |
1372 | if (DQUOT_ALLOC_BLOCK(ip, lengthPXD(pxd))) { | 1372 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { |
1373 | release_metapage(rmp); | 1373 | release_metapage(rmp); |
1374 | return -EDQUOT; | 1374 | return -EDQUOT; |
1375 | } | 1375 | } |
@@ -1916,7 +1916,7 @@ static int dtSplitRoot(tid_t tid, | |||
1916 | rp = rmp->data; | 1916 | rp = rmp->data; |
1917 | 1917 | ||
1918 | /* Allocate blocks to quota. */ | 1918 | /* Allocate blocks to quota. */ |
1919 | if (DQUOT_ALLOC_BLOCK(ip, lengthPXD(pxd))) { | 1919 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { |
1920 | release_metapage(rmp); | 1920 | release_metapage(rmp); |
1921 | return -EDQUOT; | 1921 | return -EDQUOT; |
1922 | } | 1922 | } |
@@ -2287,7 +2287,7 @@ static int dtDeleteUp(tid_t tid, struct inode *ip, | |||
2287 | xlen = lengthPXD(&fp->header.self); | 2287 | xlen = lengthPXD(&fp->header.self); |
2288 | 2288 | ||
2289 | /* Free quota allocation. */ | 2289 | /* Free quota allocation. */ |
2290 | DQUOT_FREE_BLOCK(ip, xlen); | 2290 | vfs_dq_free_block(ip, xlen); |
2291 | 2291 | ||
2292 | /* free/invalidate its buffer page */ | 2292 | /* free/invalidate its buffer page */ |
2293 | discard_metapage(fmp); | 2293 | discard_metapage(fmp); |
@@ -2363,7 +2363,7 @@ static int dtDeleteUp(tid_t tid, struct inode *ip, | |||
2363 | xlen = lengthPXD(&p->header.self); | 2363 | xlen = lengthPXD(&p->header.self); |
2364 | 2364 | ||
2365 | /* Free quota allocation */ | 2365 | /* Free quota allocation */ |
2366 | DQUOT_FREE_BLOCK(ip, xlen); | 2366 | vfs_dq_free_block(ip, xlen); |
2367 | 2367 | ||
2368 | /* free/invalidate its buffer page */ | 2368 | /* free/invalidate its buffer page */ |
2369 | discard_metapage(mp); | 2369 | discard_metapage(mp); |
diff --git a/fs/jfs/jfs_extent.c b/fs/jfs/jfs_extent.c index 7ae1e3281de9..bbbd5f202e37 100644 --- a/fs/jfs/jfs_extent.c +++ b/fs/jfs/jfs_extent.c | |||
@@ -141,7 +141,7 @@ extAlloc(struct inode *ip, s64 xlen, s64 pno, xad_t * xp, bool abnr) | |||
141 | } | 141 | } |
142 | 142 | ||
143 | /* Allocate blocks to quota. */ | 143 | /* Allocate blocks to quota. */ |
144 | if (DQUOT_ALLOC_BLOCK(ip, nxlen)) { | 144 | if (vfs_dq_alloc_block(ip, nxlen)) { |
145 | dbFree(ip, nxaddr, (s64) nxlen); | 145 | dbFree(ip, nxaddr, (s64) nxlen); |
146 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 146 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
147 | return -EDQUOT; | 147 | return -EDQUOT; |
@@ -164,7 +164,7 @@ extAlloc(struct inode *ip, s64 xlen, s64 pno, xad_t * xp, bool abnr) | |||
164 | */ | 164 | */ |
165 | if (rc) { | 165 | if (rc) { |
166 | dbFree(ip, nxaddr, nxlen); | 166 | dbFree(ip, nxaddr, nxlen); |
167 | DQUOT_FREE_BLOCK(ip, nxlen); | 167 | vfs_dq_free_block(ip, nxlen); |
168 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 168 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
169 | return (rc); | 169 | return (rc); |
170 | } | 170 | } |
@@ -256,7 +256,7 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
256 | goto exit; | 256 | goto exit; |
257 | 257 | ||
258 | /* Allocat blocks to quota. */ | 258 | /* Allocat blocks to quota. */ |
259 | if (DQUOT_ALLOC_BLOCK(ip, nxlen)) { | 259 | if (vfs_dq_alloc_block(ip, nxlen)) { |
260 | dbFree(ip, nxaddr, (s64) nxlen); | 260 | dbFree(ip, nxaddr, (s64) nxlen); |
261 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 261 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
262 | return -EDQUOT; | 262 | return -EDQUOT; |
@@ -297,7 +297,7 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
297 | /* extend the extent */ | 297 | /* extend the extent */ |
298 | if ((rc = xtExtend(0, ip, xoff + xlen, (int) nextend, 0))) { | 298 | if ((rc = xtExtend(0, ip, xoff + xlen, (int) nextend, 0))) { |
299 | dbFree(ip, xaddr + xlen, delta); | 299 | dbFree(ip, xaddr + xlen, delta); |
300 | DQUOT_FREE_BLOCK(ip, nxlen); | 300 | vfs_dq_free_block(ip, nxlen); |
301 | goto exit; | 301 | goto exit; |
302 | } | 302 | } |
303 | } else { | 303 | } else { |
@@ -308,7 +308,7 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
308 | */ | 308 | */ |
309 | if ((rc = xtTailgate(0, ip, xoff, (int) ntail, nxaddr, 0))) { | 309 | if ((rc = xtTailgate(0, ip, xoff, (int) ntail, nxaddr, 0))) { |
310 | dbFree(ip, nxaddr, nxlen); | 310 | dbFree(ip, nxaddr, nxlen); |
311 | DQUOT_FREE_BLOCK(ip, nxlen); | 311 | vfs_dq_free_block(ip, nxlen); |
312 | goto exit; | 312 | goto exit; |
313 | } | 313 | } |
314 | } | 314 | } |
@@ -362,11 +362,12 @@ exit: | |||
362 | int extHint(struct inode *ip, s64 offset, xad_t * xp) | 362 | int extHint(struct inode *ip, s64 offset, xad_t * xp) |
363 | { | 363 | { |
364 | struct super_block *sb = ip->i_sb; | 364 | struct super_block *sb = ip->i_sb; |
365 | struct xadlist xadl; | 365 | int nbperpage = JFS_SBI(sb)->nbperpage; |
366 | struct lxdlist lxdl; | ||
367 | lxd_t lxd; | ||
368 | s64 prev; | 366 | s64 prev; |
369 | int rc, nbperpage = JFS_SBI(sb)->nbperpage; | 367 | int rc = 0; |
368 | s64 xaddr; | ||
369 | int xlen; | ||
370 | int xflag; | ||
370 | 371 | ||
371 | /* init the hint as "no hint provided" */ | 372 | /* init the hint as "no hint provided" */ |
372 | XADaddress(xp, 0); | 373 | XADaddress(xp, 0); |
@@ -376,46 +377,30 @@ int extHint(struct inode *ip, s64 offset, xad_t * xp) | |||
376 | */ | 377 | */ |
377 | prev = ((offset & ~POFFSET) >> JFS_SBI(sb)->l2bsize) - nbperpage; | 378 | prev = ((offset & ~POFFSET) >> JFS_SBI(sb)->l2bsize) - nbperpage; |
378 | 379 | ||
379 | /* if the offsets in the first page of the file, | 380 | /* if the offset is in the first page of the file, no hint provided. |
380 | * no hint provided. | ||
381 | */ | 381 | */ |
382 | if (prev < 0) | 382 | if (prev < 0) |
383 | return (0); | 383 | goto out; |
384 | |||
385 | /* prepare to lookup the previous page's extent info */ | ||
386 | lxdl.maxnlxd = 1; | ||
387 | lxdl.nlxd = 1; | ||
388 | lxdl.lxd = &lxd; | ||
389 | LXDoffset(&lxd, prev) | ||
390 | LXDlength(&lxd, nbperpage); | ||
391 | |||
392 | xadl.maxnxad = 1; | ||
393 | xadl.nxad = 0; | ||
394 | xadl.xad = xp; | ||
395 | |||
396 | /* perform the lookup */ | ||
397 | if ((rc = xtLookupList(ip, &lxdl, &xadl, 0))) | ||
398 | return (rc); | ||
399 | |||
400 | /* check if no extent exists for the previous page. | ||
401 | * this is possible for sparse files. | ||
402 | */ | ||
403 | if (xadl.nxad == 0) { | ||
404 | // assert(ISSPARSE(ip)); | ||
405 | return (0); | ||
406 | } | ||
407 | 384 | ||
408 | /* only preserve the abnr flag within the xad flags | 385 | rc = xtLookup(ip, prev, nbperpage, &xflag, &xaddr, &xlen, 0); |
409 | * of the returned hint. | ||
410 | */ | ||
411 | xp->flag &= XAD_NOTRECORDED; | ||
412 | 386 | ||
413 | if(xadl.nxad != 1 || lengthXAD(xp) != nbperpage) { | 387 | if ((rc == 0) && xlen) { |
414 | jfs_error(ip->i_sb, "extHint: corrupt xtree"); | 388 | if (xlen != nbperpage) { |
415 | return -EIO; | 389 | jfs_error(ip->i_sb, "extHint: corrupt xtree"); |
416 | } | 390 | rc = -EIO; |
391 | } | ||
392 | XADaddress(xp, xaddr); | ||
393 | XADlength(xp, xlen); | ||
394 | /* | ||
395 | * only preserve the abnr flag within the xad flags | ||
396 | * of the returned hint. | ||
397 | */ | ||
398 | xp->flag = xflag & XAD_NOTRECORDED; | ||
399 | } else | ||
400 | rc = 0; | ||
417 | 401 | ||
418 | return (0); | 402 | out: |
403 | return (rc); | ||
419 | } | 404 | } |
420 | 405 | ||
421 | 406 | ||
diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c index 0f94381ca6d0..346057218edc 100644 --- a/fs/jfs/jfs_imap.c +++ b/fs/jfs/jfs_imap.c | |||
@@ -57,12 +57,6 @@ | |||
57 | #include "jfs_debug.h" | 57 | #include "jfs_debug.h" |
58 | 58 | ||
59 | /* | 59 | /* |
60 | * __mark_inode_dirty expects inodes to be hashed. Since we don't want | ||
61 | * special inodes in the fileset inode space, we make them appear hashed, | ||
62 | * but do not put on any lists. | ||
63 | */ | ||
64 | |||
65 | /* | ||
66 | * imap locks | 60 | * imap locks |
67 | */ | 61 | */ |
68 | /* iag free list lock */ | 62 | /* iag free list lock */ |
@@ -497,7 +491,9 @@ struct inode *diReadSpecial(struct super_block *sb, ino_t inum, int secondary) | |||
497 | release_metapage(mp); | 491 | release_metapage(mp); |
498 | 492 | ||
499 | /* | 493 | /* |
500 | * that will look hashed, but won't be on any list; hlist_del() | 494 | * __mark_inode_dirty expects inodes to be hashed. Since we don't |
495 | * want special inodes in the fileset inode space, we make them | ||
496 | * appear hashed, but do not put on any lists. hlist_del() | ||
501 | * will work fine and require no locking. | 497 | * will work fine and require no locking. |
502 | */ | 498 | */ |
503 | ip->i_hash.pprev = &ip->i_hash.next; | 499 | ip->i_hash.pprev = &ip->i_hash.next; |
diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c index d4d142c2edd4..dc0e02159ac9 100644 --- a/fs/jfs/jfs_inode.c +++ b/fs/jfs/jfs_inode.c | |||
@@ -116,7 +116,7 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
116 | /* | 116 | /* |
117 | * Allocate inode to quota. | 117 | * Allocate inode to quota. |
118 | */ | 118 | */ |
119 | if (DQUOT_ALLOC_INODE(inode)) { | 119 | if (vfs_dq_alloc_inode(inode)) { |
120 | rc = -EDQUOT; | 120 | rc = -EDQUOT; |
121 | goto fail_drop; | 121 | goto fail_drop; |
122 | } | 122 | } |
@@ -162,7 +162,7 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
162 | return inode; | 162 | return inode; |
163 | 163 | ||
164 | fail_drop: | 164 | fail_drop: |
165 | DQUOT_DROP(inode); | 165 | vfs_dq_drop(inode); |
166 | inode->i_flags |= S_NOQUOTA; | 166 | inode->i_flags |= S_NOQUOTA; |
167 | fail_unlock: | 167 | fail_unlock: |
168 | inode->i_nlink = 0; | 168 | inode->i_nlink = 0; |
diff --git a/fs/jfs/jfs_inode.h b/fs/jfs/jfs_inode.h index adb2fafcc544..1eff7db34d63 100644 --- a/fs/jfs/jfs_inode.h +++ b/fs/jfs/jfs_inode.h | |||
@@ -47,5 +47,5 @@ extern const struct file_operations jfs_dir_operations; | |||
47 | extern const struct inode_operations jfs_file_inode_operations; | 47 | extern const struct inode_operations jfs_file_inode_operations; |
48 | extern const struct file_operations jfs_file_operations; | 48 | extern const struct file_operations jfs_file_operations; |
49 | extern const struct inode_operations jfs_symlink_inode_operations; | 49 | extern const struct inode_operations jfs_symlink_inode_operations; |
50 | extern struct dentry_operations jfs_ci_dentry_operations; | 50 | extern const struct dentry_operations jfs_ci_dentry_operations; |
51 | #endif /* _H_JFS_INODE */ | 51 | #endif /* _H_JFS_INODE */ |
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index c350057087dd..07b6c5dfb4b6 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c | |||
@@ -369,6 +369,7 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc) | |||
369 | unsigned long bio_bytes = 0; | 369 | unsigned long bio_bytes = 0; |
370 | unsigned long bio_offset = 0; | 370 | unsigned long bio_offset = 0; |
371 | int offset; | 371 | int offset; |
372 | int bad_blocks = 0; | ||
372 | 373 | ||
373 | page_start = (sector_t)page->index << | 374 | page_start = (sector_t)page->index << |
374 | (PAGE_CACHE_SHIFT - inode->i_blkbits); | 375 | (PAGE_CACHE_SHIFT - inode->i_blkbits); |
@@ -394,6 +395,7 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc) | |||
394 | } | 395 | } |
395 | 396 | ||
396 | clear_bit(META_dirty, &mp->flag); | 397 | clear_bit(META_dirty, &mp->flag); |
398 | set_bit(META_io, &mp->flag); | ||
397 | block_offset = offset >> inode->i_blkbits; | 399 | block_offset = offset >> inode->i_blkbits; |
398 | lblock = page_start + block_offset; | 400 | lblock = page_start + block_offset; |
399 | if (bio) { | 401 | if (bio) { |
@@ -402,7 +404,6 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc) | |||
402 | len = min(xlen, blocks_per_mp); | 404 | len = min(xlen, blocks_per_mp); |
403 | xlen -= len; | 405 | xlen -= len; |
404 | bio_bytes += len << inode->i_blkbits; | 406 | bio_bytes += len << inode->i_blkbits; |
405 | set_bit(META_io, &mp->flag); | ||
406 | continue; | 407 | continue; |
407 | } | 408 | } |
408 | /* Not contiguous */ | 409 | /* Not contiguous */ |
@@ -424,12 +425,14 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc) | |||
424 | xlen = (PAGE_CACHE_SIZE - offset) >> inode->i_blkbits; | 425 | xlen = (PAGE_CACHE_SIZE - offset) >> inode->i_blkbits; |
425 | pblock = metapage_get_blocks(inode, lblock, &xlen); | 426 | pblock = metapage_get_blocks(inode, lblock, &xlen); |
426 | if (!pblock) { | 427 | if (!pblock) { |
427 | /* Need better error handling */ | ||
428 | printk(KERN_ERR "JFS: metapage_get_blocks failed\n"); | 428 | printk(KERN_ERR "JFS: metapage_get_blocks failed\n"); |
429 | dec_io(page, last_write_complete); | 429 | /* |
430 | * We already called inc_io(), but can't cancel it | ||
431 | * with dec_io() until we're done with the page | ||
432 | */ | ||
433 | bad_blocks++; | ||
430 | continue; | 434 | continue; |
431 | } | 435 | } |
432 | set_bit(META_io, &mp->flag); | ||
433 | len = min(xlen, (int)JFS_SBI(inode->i_sb)->nbperpage); | 436 | len = min(xlen, (int)JFS_SBI(inode->i_sb)->nbperpage); |
434 | 437 | ||
435 | bio = bio_alloc(GFP_NOFS, 1); | 438 | bio = bio_alloc(GFP_NOFS, 1); |
@@ -459,6 +462,9 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc) | |||
459 | 462 | ||
460 | unlock_page(page); | 463 | unlock_page(page); |
461 | 464 | ||
465 | if (bad_blocks) | ||
466 | goto err_out; | ||
467 | |||
462 | if (nr_underway == 0) | 468 | if (nr_underway == 0) |
463 | end_page_writeback(page); | 469 | end_page_writeback(page); |
464 | 470 | ||
@@ -474,7 +480,9 @@ skip: | |||
474 | bio_put(bio); | 480 | bio_put(bio); |
475 | unlock_page(page); | 481 | unlock_page(page); |
476 | dec_io(page, last_write_complete); | 482 | dec_io(page, last_write_complete); |
477 | 483 | err_out: | |
484 | while (bad_blocks--) | ||
485 | dec_io(page, last_write_complete); | ||
478 | return -EIO; | 486 | return -EIO; |
479 | } | 487 | } |
480 | 488 | ||
diff --git a/fs/jfs/jfs_types.h b/fs/jfs/jfs_types.h index 649f9817accd..43ea3713c083 100644 --- a/fs/jfs/jfs_types.h +++ b/fs/jfs/jfs_types.h | |||
@@ -58,35 +58,6 @@ struct timestruc_t { | |||
58 | #define ONES 0xffffffffu /* all bit on */ | 58 | #define ONES 0xffffffffu /* all bit on */ |
59 | 59 | ||
60 | /* | 60 | /* |
61 | * logical xd (lxd) | ||
62 | */ | ||
63 | typedef struct { | ||
64 | unsigned len:24; | ||
65 | unsigned off1:8; | ||
66 | u32 off2; | ||
67 | } lxd_t; | ||
68 | |||
69 | /* lxd_t field construction */ | ||
70 | #define LXDlength(lxd, length32) ( (lxd)->len = length32 ) | ||
71 | #define LXDoffset(lxd, offset64)\ | ||
72 | {\ | ||
73 | (lxd)->off1 = ((s64)offset64) >> 32;\ | ||
74 | (lxd)->off2 = (offset64) & 0xffffffff;\ | ||
75 | } | ||
76 | |||
77 | /* lxd_t field extraction */ | ||
78 | #define lengthLXD(lxd) ( (lxd)->len ) | ||
79 | #define offsetLXD(lxd)\ | ||
80 | ( ((s64)((lxd)->off1)) << 32 | (lxd)->off2 ) | ||
81 | |||
82 | /* lxd list */ | ||
83 | struct lxdlist { | ||
84 | s16 maxnlxd; | ||
85 | s16 nlxd; | ||
86 | lxd_t *lxd; | ||
87 | }; | ||
88 | |||
89 | /* | ||
90 | * physical xd (pxd) | 61 | * physical xd (pxd) |
91 | */ | 62 | */ |
92 | typedef struct { | 63 | typedef struct { |
diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c index ae3acafb447b..d654a6458648 100644 --- a/fs/jfs/jfs_xtree.c +++ b/fs/jfs/jfs_xtree.c | |||
@@ -164,11 +164,8 @@ int xtLookup(struct inode *ip, s64 lstart, | |||
164 | /* is lookup offset beyond eof ? */ | 164 | /* is lookup offset beyond eof ? */ |
165 | size = ((u64) ip->i_size + (JFS_SBI(ip->i_sb)->bsize - 1)) >> | 165 | size = ((u64) ip->i_size + (JFS_SBI(ip->i_sb)->bsize - 1)) >> |
166 | JFS_SBI(ip->i_sb)->l2bsize; | 166 | JFS_SBI(ip->i_sb)->l2bsize; |
167 | if (lstart >= size) { | 167 | if (lstart >= size) |
168 | jfs_err("xtLookup: lstart (0x%lx) >= size (0x%lx)", | ||
169 | (ulong) lstart, (ulong) size); | ||
170 | return 0; | 168 | return 0; |
171 | } | ||
172 | } | 169 | } |
173 | 170 | ||
174 | /* | 171 | /* |
@@ -220,264 +217,6 @@ int xtLookup(struct inode *ip, s64 lstart, | |||
220 | return rc; | 217 | return rc; |
221 | } | 218 | } |
222 | 219 | ||
223 | |||
224 | /* | ||
225 | * xtLookupList() | ||
226 | * | ||
227 | * function: map a single logical extent into a list of physical extent; | ||
228 | * | ||
229 | * parameter: | ||
230 | * struct inode *ip, | ||
231 | * struct lxdlist *lxdlist, lxd list (in) | ||
232 | * struct xadlist *xadlist, xad list (in/out) | ||
233 | * int flag) | ||
234 | * | ||
235 | * coverage of lxd by xad under assumption of | ||
236 | * . lxd's are ordered and disjoint. | ||
237 | * . xad's are ordered and disjoint. | ||
238 | * | ||
239 | * return: | ||
240 | * 0: success | ||
241 | * | ||
242 | * note: a page being written (even a single byte) is backed fully, | ||
243 | * except the last page which is only backed with blocks | ||
244 | * required to cover the last byte; | ||
245 | * the extent backing a page is fully contained within an xad; | ||
246 | */ | ||
247 | int xtLookupList(struct inode *ip, struct lxdlist * lxdlist, | ||
248 | struct xadlist * xadlist, int flag) | ||
249 | { | ||
250 | int rc = 0; | ||
251 | struct btstack btstack; | ||
252 | int cmp; | ||
253 | s64 bn; | ||
254 | struct metapage *mp; | ||
255 | xtpage_t *p; | ||
256 | int index; | ||
257 | lxd_t *lxd; | ||
258 | xad_t *xad, *pxd; | ||
259 | s64 size, lstart, lend, xstart, xend, pstart; | ||
260 | s64 llen, xlen, plen; | ||
261 | s64 xaddr, paddr; | ||
262 | int nlxd, npxd, maxnpxd; | ||
263 | |||
264 | npxd = xadlist->nxad = 0; | ||
265 | maxnpxd = xadlist->maxnxad; | ||
266 | pxd = xadlist->xad; | ||
267 | |||
268 | nlxd = lxdlist->nlxd; | ||
269 | lxd = lxdlist->lxd; | ||
270 | |||
271 | lstart = offsetLXD(lxd); | ||
272 | llen = lengthLXD(lxd); | ||
273 | lend = lstart + llen; | ||
274 | |||
275 | size = (ip->i_size + (JFS_SBI(ip->i_sb)->bsize - 1)) >> | ||
276 | JFS_SBI(ip->i_sb)->l2bsize; | ||
277 | |||
278 | /* | ||
279 | * search for the xad entry covering the logical extent | ||
280 | */ | ||
281 | search: | ||
282 | if (lstart >= size) | ||
283 | return 0; | ||
284 | |||
285 | if ((rc = xtSearch(ip, lstart, NULL, &cmp, &btstack, 0))) | ||
286 | return rc; | ||
287 | |||
288 | /* | ||
289 | * compute the physical extent covering logical extent | ||
290 | * | ||
291 | * N.B. search may have failed (e.g., hole in sparse file), | ||
292 | * and returned the index of the next entry. | ||
293 | */ | ||
294 | //map: | ||
295 | /* retrieve search result */ | ||
296 | XT_GETSEARCH(ip, btstack.top, bn, mp, p, index); | ||
297 | |||
298 | /* is xad on the next sibling page ? */ | ||
299 | if (index == le16_to_cpu(p->header.nextindex)) { | ||
300 | if (p->header.flag & BT_ROOT) | ||
301 | goto mapend; | ||
302 | |||
303 | if ((bn = le64_to_cpu(p->header.next)) == 0) | ||
304 | goto mapend; | ||
305 | |||
306 | XT_PUTPAGE(mp); | ||
307 | |||
308 | /* get next sibling page */ | ||
309 | XT_GETPAGE(ip, bn, mp, PSIZE, p, rc); | ||
310 | if (rc) | ||
311 | return rc; | ||
312 | |||
313 | index = XTENTRYSTART; | ||
314 | } | ||
315 | |||
316 | xad = &p->xad[index]; | ||
317 | |||
318 | /* | ||
319 | * is lxd covered by xad ? | ||
320 | */ | ||
321 | compare: | ||
322 | xstart = offsetXAD(xad); | ||
323 | xlen = lengthXAD(xad); | ||
324 | xend = xstart + xlen; | ||
325 | xaddr = addressXAD(xad); | ||
326 | |||
327 | compare1: | ||
328 | if (xstart < lstart) | ||
329 | goto compare2; | ||
330 | |||
331 | /* (lstart <= xstart) */ | ||
332 | |||
333 | /* lxd is NOT covered by xad */ | ||
334 | if (lend <= xstart) { | ||
335 | /* | ||
336 | * get next lxd | ||
337 | */ | ||
338 | if (--nlxd == 0) | ||
339 | goto mapend; | ||
340 | lxd++; | ||
341 | |||
342 | lstart = offsetLXD(lxd); | ||
343 | llen = lengthLXD(lxd); | ||
344 | lend = lstart + llen; | ||
345 | if (lstart >= size) | ||
346 | goto mapend; | ||
347 | |||
348 | /* compare with the current xad */ | ||
349 | goto compare1; | ||
350 | } | ||
351 | /* lxd is covered by xad */ | ||
352 | else { /* (xstart < lend) */ | ||
353 | |||
354 | /* initialize new pxd */ | ||
355 | pstart = xstart; | ||
356 | plen = min(lend - xstart, xlen); | ||
357 | paddr = xaddr; | ||
358 | |||
359 | goto cover; | ||
360 | } | ||
361 | |||
362 | /* (xstart < lstart) */ | ||
363 | compare2: | ||
364 | /* lxd is covered by xad */ | ||
365 | if (lstart < xend) { | ||
366 | /* initialize new pxd */ | ||
367 | pstart = lstart; | ||
368 | plen = min(xend - lstart, llen); | ||
369 | paddr = xaddr + (lstart - xstart); | ||
370 | |||
371 | goto cover; | ||
372 | } | ||
373 | /* lxd is NOT covered by xad */ | ||
374 | else { /* (xend <= lstart) */ | ||
375 | |||
376 | /* | ||
377 | * get next xad | ||
378 | * | ||
379 | * linear search next xad covering lxd on | ||
380 | * the current xad page, and then tree search | ||
381 | */ | ||
382 | if (index == le16_to_cpu(p->header.nextindex) - 1) { | ||
383 | if (p->header.flag & BT_ROOT) | ||
384 | goto mapend; | ||
385 | |||
386 | XT_PUTPAGE(mp); | ||
387 | goto search; | ||
388 | } else { | ||
389 | index++; | ||
390 | xad++; | ||
391 | |||
392 | /* compare with new xad */ | ||
393 | goto compare; | ||
394 | } | ||
395 | } | ||
396 | |||
397 | /* | ||
398 | * lxd is covered by xad and a new pxd has been initialized | ||
399 | * (lstart <= xstart < lend) or (xstart < lstart < xend) | ||
400 | */ | ||
401 | cover: | ||
402 | /* finalize pxd corresponding to current xad */ | ||
403 | XT_PUTENTRY(pxd, xad->flag, pstart, plen, paddr); | ||
404 | |||
405 | if (++npxd >= maxnpxd) | ||
406 | goto mapend; | ||
407 | pxd++; | ||
408 | |||
409 | /* | ||
410 | * lxd is fully covered by xad | ||
411 | */ | ||
412 | if (lend <= xend) { | ||
413 | /* | ||
414 | * get next lxd | ||
415 | */ | ||
416 | if (--nlxd == 0) | ||
417 | goto mapend; | ||
418 | lxd++; | ||
419 | |||
420 | lstart = offsetLXD(lxd); | ||
421 | llen = lengthLXD(lxd); | ||
422 | lend = lstart + llen; | ||
423 | if (lstart >= size) | ||
424 | goto mapend; | ||
425 | |||
426 | /* | ||
427 | * test for old xad covering new lxd | ||
428 | * (old xstart < new lstart) | ||
429 | */ | ||
430 | goto compare2; | ||
431 | } | ||
432 | /* | ||
433 | * lxd is partially covered by xad | ||
434 | */ | ||
435 | else { /* (xend < lend) */ | ||
436 | |||
437 | /* | ||
438 | * get next xad | ||
439 | * | ||
440 | * linear search next xad covering lxd on | ||
441 | * the current xad page, and then next xad page search | ||
442 | */ | ||
443 | if (index == le16_to_cpu(p->header.nextindex) - 1) { | ||
444 | if (p->header.flag & BT_ROOT) | ||
445 | goto mapend; | ||
446 | |||
447 | if ((bn = le64_to_cpu(p->header.next)) == 0) | ||
448 | goto mapend; | ||
449 | |||
450 | XT_PUTPAGE(mp); | ||
451 | |||
452 | /* get next sibling page */ | ||
453 | XT_GETPAGE(ip, bn, mp, PSIZE, p, rc); | ||
454 | if (rc) | ||
455 | return rc; | ||
456 | |||
457 | index = XTENTRYSTART; | ||
458 | xad = &p->xad[index]; | ||
459 | } else { | ||
460 | index++; | ||
461 | xad++; | ||
462 | } | ||
463 | |||
464 | /* | ||
465 | * test for new xad covering old lxd | ||
466 | * (old lstart < new xstart) | ||
467 | */ | ||
468 | goto compare; | ||
469 | } | ||
470 | |||
471 | mapend: | ||
472 | xadlist->nxad = npxd; | ||
473 | |||
474 | //out: | ||
475 | XT_PUTPAGE(mp); | ||
476 | |||
477 | return rc; | ||
478 | } | ||
479 | |||
480 | |||
481 | /* | 220 | /* |
482 | * xtSearch() | 221 | * xtSearch() |
483 | * | 222 | * |
@@ -846,10 +585,10 @@ int xtInsert(tid_t tid, /* transaction id */ | |||
846 | hint = addressXAD(xad) + lengthXAD(xad) - 1; | 585 | hint = addressXAD(xad) + lengthXAD(xad) - 1; |
847 | } else | 586 | } else |
848 | hint = 0; | 587 | hint = 0; |
849 | if ((rc = DQUOT_ALLOC_BLOCK(ip, xlen))) | 588 | if ((rc = vfs_dq_alloc_block(ip, xlen))) |
850 | goto out; | 589 | goto out; |
851 | if ((rc = dbAlloc(ip, hint, (s64) xlen, &xaddr))) { | 590 | if ((rc = dbAlloc(ip, hint, (s64) xlen, &xaddr))) { |
852 | DQUOT_FREE_BLOCK(ip, xlen); | 591 | vfs_dq_free_block(ip, xlen); |
853 | goto out; | 592 | goto out; |
854 | } | 593 | } |
855 | } | 594 | } |
@@ -878,7 +617,7 @@ int xtInsert(tid_t tid, /* transaction id */ | |||
878 | /* undo data extent allocation */ | 617 | /* undo data extent allocation */ |
879 | if (*xaddrp == 0) { | 618 | if (*xaddrp == 0) { |
880 | dbFree(ip, xaddr, (s64) xlen); | 619 | dbFree(ip, xaddr, (s64) xlen); |
881 | DQUOT_FREE_BLOCK(ip, xlen); | 620 | vfs_dq_free_block(ip, xlen); |
882 | } | 621 | } |
883 | return rc; | 622 | return rc; |
884 | } | 623 | } |
@@ -1246,7 +985,7 @@ xtSplitPage(tid_t tid, struct inode *ip, | |||
1246 | rbn = addressPXD(pxd); | 985 | rbn = addressPXD(pxd); |
1247 | 986 | ||
1248 | /* Allocate blocks to quota. */ | 987 | /* Allocate blocks to quota. */ |
1249 | if (DQUOT_ALLOC_BLOCK(ip, lengthPXD(pxd))) { | 988 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { |
1250 | rc = -EDQUOT; | 989 | rc = -EDQUOT; |
1251 | goto clean_up; | 990 | goto clean_up; |
1252 | } | 991 | } |
@@ -1456,7 +1195,7 @@ xtSplitPage(tid_t tid, struct inode *ip, | |||
1456 | 1195 | ||
1457 | /* Rollback quota allocation. */ | 1196 | /* Rollback quota allocation. */ |
1458 | if (quota_allocation) | 1197 | if (quota_allocation) |
1459 | DQUOT_FREE_BLOCK(ip, quota_allocation); | 1198 | vfs_dq_free_block(ip, quota_allocation); |
1460 | 1199 | ||
1461 | return (rc); | 1200 | return (rc); |
1462 | } | 1201 | } |
@@ -1513,7 +1252,7 @@ xtSplitRoot(tid_t tid, | |||
1513 | return -EIO; | 1252 | return -EIO; |
1514 | 1253 | ||
1515 | /* Allocate blocks to quota. */ | 1254 | /* Allocate blocks to quota. */ |
1516 | if (DQUOT_ALLOC_BLOCK(ip, lengthPXD(pxd))) { | 1255 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { |
1517 | release_metapage(rmp); | 1256 | release_metapage(rmp); |
1518 | return -EDQUOT; | 1257 | return -EDQUOT; |
1519 | } | 1258 | } |
@@ -3941,7 +3680,7 @@ s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsize, int flag) | |||
3941 | ip->i_size = newsize; | 3680 | ip->i_size = newsize; |
3942 | 3681 | ||
3943 | /* update quota allocation to reflect freed blocks */ | 3682 | /* update quota allocation to reflect freed blocks */ |
3944 | DQUOT_FREE_BLOCK(ip, nfreed); | 3683 | vfs_dq_free_block(ip, nfreed); |
3945 | 3684 | ||
3946 | /* | 3685 | /* |
3947 | * free tlock of invalidated pages | 3686 | * free tlock of invalidated pages |
diff --git a/fs/jfs/jfs_xtree.h b/fs/jfs/jfs_xtree.h index 70815c8a3d6a..08c0c749b986 100644 --- a/fs/jfs/jfs_xtree.h +++ b/fs/jfs/jfs_xtree.h | |||
@@ -110,8 +110,6 @@ typedef union { | |||
110 | */ | 110 | */ |
111 | extern int xtLookup(struct inode *ip, s64 lstart, s64 llen, | 111 | extern int xtLookup(struct inode *ip, s64 lstart, s64 llen, |
112 | int *pflag, s64 * paddr, int *plen, int flag); | 112 | int *pflag, s64 * paddr, int *plen, int flag); |
113 | extern int xtLookupList(struct inode *ip, struct lxdlist * lxdlist, | ||
114 | struct xadlist * xadlist, int flag); | ||
115 | extern void xtInitRoot(tid_t tid, struct inode *ip); | 113 | extern void xtInitRoot(tid_t tid, struct inode *ip); |
116 | extern int xtInsert(tid_t tid, struct inode *ip, | 114 | extern int xtInsert(tid_t tid, struct inode *ip, |
117 | int xflag, s64 xoff, int xlen, s64 * xaddrp, int flag); | 115 | int xflag, s64 xoff, int xlen, s64 * xaddrp, int flag); |
diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index b4de56b851e4..514ee2edb92a 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c | |||
@@ -35,7 +35,7 @@ | |||
35 | /* | 35 | /* |
36 | * forward references | 36 | * forward references |
37 | */ | 37 | */ |
38 | struct dentry_operations jfs_ci_dentry_operations; | 38 | const struct dentry_operations jfs_ci_dentry_operations; |
39 | 39 | ||
40 | static s64 commitZeroLink(tid_t, struct inode *); | 40 | static s64 commitZeroLink(tid_t, struct inode *); |
41 | 41 | ||
@@ -356,7 +356,7 @@ static int jfs_rmdir(struct inode *dip, struct dentry *dentry) | |||
356 | jfs_info("jfs_rmdir: dip:0x%p name:%s", dip, dentry->d_name.name); | 356 | jfs_info("jfs_rmdir: dip:0x%p name:%s", dip, dentry->d_name.name); |
357 | 357 | ||
358 | /* Init inode for quota operations. */ | 358 | /* Init inode for quota operations. */ |
359 | DQUOT_INIT(ip); | 359 | vfs_dq_init(ip); |
360 | 360 | ||
361 | /* directory must be empty to be removed */ | 361 | /* directory must be empty to be removed */ |
362 | if (!dtEmpty(ip)) { | 362 | if (!dtEmpty(ip)) { |
@@ -483,7 +483,7 @@ static int jfs_unlink(struct inode *dip, struct dentry *dentry) | |||
483 | jfs_info("jfs_unlink: dip:0x%p name:%s", dip, dentry->d_name.name); | 483 | jfs_info("jfs_unlink: dip:0x%p name:%s", dip, dentry->d_name.name); |
484 | 484 | ||
485 | /* Init inode for quota operations. */ | 485 | /* Init inode for quota operations. */ |
486 | DQUOT_INIT(ip); | 486 | vfs_dq_init(ip); |
487 | 487 | ||
488 | if ((rc = get_UCSname(&dname, dentry))) | 488 | if ((rc = get_UCSname(&dname, dentry))) |
489 | goto out; | 489 | goto out; |
@@ -1136,7 +1136,7 @@ static int jfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1136 | } else if (new_ip) { | 1136 | } else if (new_ip) { |
1137 | IWRITE_LOCK(new_ip, RDWRLOCK_NORMAL); | 1137 | IWRITE_LOCK(new_ip, RDWRLOCK_NORMAL); |
1138 | /* Init inode for quota operations. */ | 1138 | /* Init inode for quota operations. */ |
1139 | DQUOT_INIT(new_ip); | 1139 | vfs_dq_init(new_ip); |
1140 | } | 1140 | } |
1141 | 1141 | ||
1142 | /* | 1142 | /* |
@@ -1595,7 +1595,7 @@ out: | |||
1595 | return result; | 1595 | return result; |
1596 | } | 1596 | } |
1597 | 1597 | ||
1598 | struct dentry_operations jfs_ci_dentry_operations = | 1598 | const struct dentry_operations jfs_ci_dentry_operations = |
1599 | { | 1599 | { |
1600 | .d_hash = jfs_ci_hash, | 1600 | .d_hash = jfs_ci_hash, |
1601 | .d_compare = jfs_ci_compare, | 1601 | .d_compare = jfs_ci_compare, |
diff --git a/fs/jfs/super.c b/fs/jfs/super.c index b37d1f78b854..6f21adf9479a 100644 --- a/fs/jfs/super.c +++ b/fs/jfs/super.c | |||
@@ -29,6 +29,7 @@ | |||
29 | #include <linux/posix_acl.h> | 29 | #include <linux/posix_acl.h> |
30 | #include <linux/buffer_head.h> | 30 | #include <linux/buffer_head.h> |
31 | #include <linux/exportfs.h> | 31 | #include <linux/exportfs.h> |
32 | #include <linux/crc32.h> | ||
32 | #include <asm/uaccess.h> | 33 | #include <asm/uaccess.h> |
33 | #include <linux/seq_file.h> | 34 | #include <linux/seq_file.h> |
34 | 35 | ||
@@ -168,6 +169,9 @@ static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
168 | buf->f_files = maxinodes; | 169 | buf->f_files = maxinodes; |
169 | buf->f_ffree = maxinodes - (atomic_read(&imap->im_numinos) - | 170 | buf->f_ffree = maxinodes - (atomic_read(&imap->im_numinos) - |
170 | atomic_read(&imap->im_numfree)); | 171 | atomic_read(&imap->im_numfree)); |
172 | buf->f_fsid.val[0] = (u32)crc32_le(0, sbi->uuid, sizeof(sbi->uuid)/2); | ||
173 | buf->f_fsid.val[1] = (u32)crc32_le(0, sbi->uuid + sizeof(sbi->uuid)/2, | ||
174 | sizeof(sbi->uuid)/2); | ||
171 | 175 | ||
172 | buf->f_namelen = JFS_NAME_MAX; | 176 | buf->f_namelen = JFS_NAME_MAX; |
173 | return 0; | 177 | return 0; |
diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c index 9b7f2cdaae0a..61dfa8173ebc 100644 --- a/fs/jfs/xattr.c +++ b/fs/jfs/xattr.c | |||
@@ -260,14 +260,14 @@ static int ea_write(struct inode *ip, struct jfs_ea_list *ealist, int size, | |||
260 | nblocks = (size + (sb->s_blocksize - 1)) >> sb->s_blocksize_bits; | 260 | nblocks = (size + (sb->s_blocksize - 1)) >> sb->s_blocksize_bits; |
261 | 261 | ||
262 | /* Allocate new blocks to quota. */ | 262 | /* Allocate new blocks to quota. */ |
263 | if (DQUOT_ALLOC_BLOCK(ip, nblocks)) { | 263 | if (vfs_dq_alloc_block(ip, nblocks)) { |
264 | return -EDQUOT; | 264 | return -EDQUOT; |
265 | } | 265 | } |
266 | 266 | ||
267 | rc = dbAlloc(ip, INOHINT(ip), nblocks, &blkno); | 267 | rc = dbAlloc(ip, INOHINT(ip), nblocks, &blkno); |
268 | if (rc) { | 268 | if (rc) { |
269 | /*Rollback quota allocation. */ | 269 | /*Rollback quota allocation. */ |
270 | DQUOT_FREE_BLOCK(ip, nblocks); | 270 | vfs_dq_free_block(ip, nblocks); |
271 | return rc; | 271 | return rc; |
272 | } | 272 | } |
273 | 273 | ||
@@ -332,7 +332,7 @@ static int ea_write(struct inode *ip, struct jfs_ea_list *ealist, int size, | |||
332 | 332 | ||
333 | failed: | 333 | failed: |
334 | /* Rollback quota allocation. */ | 334 | /* Rollback quota allocation. */ |
335 | DQUOT_FREE_BLOCK(ip, nblocks); | 335 | vfs_dq_free_block(ip, nblocks); |
336 | 336 | ||
337 | dbFree(ip, blkno, nblocks); | 337 | dbFree(ip, blkno, nblocks); |
338 | return rc; | 338 | return rc; |
@@ -538,7 +538,7 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) | |||
538 | 538 | ||
539 | if (blocks_needed > current_blocks) { | 539 | if (blocks_needed > current_blocks) { |
540 | /* Allocate new blocks to quota. */ | 540 | /* Allocate new blocks to quota. */ |
541 | if (DQUOT_ALLOC_BLOCK(inode, blocks_needed)) | 541 | if (vfs_dq_alloc_block(inode, blocks_needed)) |
542 | return -EDQUOT; | 542 | return -EDQUOT; |
543 | 543 | ||
544 | quota_allocation = blocks_needed; | 544 | quota_allocation = blocks_needed; |
@@ -602,7 +602,7 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) | |||
602 | clean_up: | 602 | clean_up: |
603 | /* Rollback quota allocation */ | 603 | /* Rollback quota allocation */ |
604 | if (quota_allocation) | 604 | if (quota_allocation) |
605 | DQUOT_FREE_BLOCK(inode, quota_allocation); | 605 | vfs_dq_free_block(inode, quota_allocation); |
606 | 606 | ||
607 | return (rc); | 607 | return (rc); |
608 | } | 608 | } |
@@ -677,7 +677,7 @@ static int ea_put(tid_t tid, struct inode *inode, struct ea_buffer *ea_buf, | |||
677 | 677 | ||
678 | /* If old blocks exist, they must be removed from quota allocation. */ | 678 | /* If old blocks exist, they must be removed from quota allocation. */ |
679 | if (old_blocks) | 679 | if (old_blocks) |
680 | DQUOT_FREE_BLOCK(inode, old_blocks); | 680 | vfs_dq_free_block(inode, old_blocks); |
681 | 681 | ||
682 | inode->i_ctime = CURRENT_TIME; | 682 | inode->i_ctime = CURRENT_TIME; |
683 | 683 | ||
diff --git a/fs/libfs.c b/fs/libfs.c index 49b44099dabb..4910a36f516e 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -44,7 +44,7 @@ static int simple_delete_dentry(struct dentry *dentry) | |||
44 | */ | 44 | */ |
45 | struct dentry *simple_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 45 | struct dentry *simple_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) |
46 | { | 46 | { |
47 | static struct dentry_operations simple_dentry_operations = { | 47 | static const struct dentry_operations simple_dentry_operations = { |
48 | .d_delete = simple_delete_dentry, | 48 | .d_delete = simple_delete_dentry, |
49 | }; | 49 | }; |
50 | 50 | ||
@@ -242,7 +242,8 @@ int get_sb_pseudo(struct file_system_type *fs_type, char *name, | |||
242 | d_instantiate(dentry, root); | 242 | d_instantiate(dentry, root); |
243 | s->s_root = dentry; | 243 | s->s_root = dentry; |
244 | s->s_flags |= MS_ACTIVE; | 244 | s->s_flags |= MS_ACTIVE; |
245 | return simple_set_mnt(mnt, s); | 245 | simple_set_mnt(mnt, s); |
246 | return 0; | ||
246 | 247 | ||
247 | Enomem: | 248 | Enomem: |
248 | up_write(&s->s_umount); | 249 | up_write(&s->s_umount); |
diff --git a/fs/namei.c b/fs/namei.c index bbc15c237558..d040ce11785d 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -24,6 +24,7 @@ | |||
24 | #include <linux/fsnotify.h> | 24 | #include <linux/fsnotify.h> |
25 | #include <linux/personality.h> | 25 | #include <linux/personality.h> |
26 | #include <linux/security.h> | 26 | #include <linux/security.h> |
27 | #include <linux/ima.h> | ||
27 | #include <linux/syscalls.h> | 28 | #include <linux/syscalls.h> |
28 | #include <linux/mount.h> | 29 | #include <linux/mount.h> |
29 | #include <linux/audit.h> | 30 | #include <linux/audit.h> |
@@ -850,6 +851,8 @@ static int __link_path_walk(const char *name, struct nameidata *nd) | |||
850 | if (err == -EAGAIN) | 851 | if (err == -EAGAIN) |
851 | err = inode_permission(nd->path.dentry->d_inode, | 852 | err = inode_permission(nd->path.dentry->d_inode, |
852 | MAY_EXEC); | 853 | MAY_EXEC); |
854 | if (!err) | ||
855 | err = ima_path_check(&nd->path, MAY_EXEC); | ||
853 | if (err) | 856 | if (err) |
854 | break; | 857 | break; |
855 | 858 | ||
@@ -1470,7 +1473,7 @@ int vfs_create(struct inode *dir, struct dentry *dentry, int mode, | |||
1470 | error = security_inode_create(dir, dentry, mode); | 1473 | error = security_inode_create(dir, dentry, mode); |
1471 | if (error) | 1474 | if (error) |
1472 | return error; | 1475 | return error; |
1473 | DQUOT_INIT(dir); | 1476 | vfs_dq_init(dir); |
1474 | error = dir->i_op->create(dir, dentry, mode, nd); | 1477 | error = dir->i_op->create(dir, dentry, mode, nd); |
1475 | if (!error) | 1478 | if (!error) |
1476 | fsnotify_create(dir, dentry); | 1479 | fsnotify_create(dir, dentry); |
@@ -1486,29 +1489,32 @@ int may_open(struct path *path, int acc_mode, int flag) | |||
1486 | if (!inode) | 1489 | if (!inode) |
1487 | return -ENOENT; | 1490 | return -ENOENT; |
1488 | 1491 | ||
1489 | if (S_ISLNK(inode->i_mode)) | 1492 | switch (inode->i_mode & S_IFMT) { |
1493 | case S_IFLNK: | ||
1490 | return -ELOOP; | 1494 | return -ELOOP; |
1491 | 1495 | case S_IFDIR: | |
1492 | if (S_ISDIR(inode->i_mode) && (acc_mode & MAY_WRITE)) | 1496 | if (acc_mode & MAY_WRITE) |
1493 | return -EISDIR; | 1497 | return -EISDIR; |
1494 | 1498 | break; | |
1495 | /* | 1499 | case S_IFBLK: |
1496 | * FIFO's, sockets and device files are special: they don't | 1500 | case S_IFCHR: |
1497 | * actually live on the filesystem itself, and as such you | ||
1498 | * can write to them even if the filesystem is read-only. | ||
1499 | */ | ||
1500 | if (S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) { | ||
1501 | flag &= ~O_TRUNC; | ||
1502 | } else if (S_ISBLK(inode->i_mode) || S_ISCHR(inode->i_mode)) { | ||
1503 | if (path->mnt->mnt_flags & MNT_NODEV) | 1501 | if (path->mnt->mnt_flags & MNT_NODEV) |
1504 | return -EACCES; | 1502 | return -EACCES; |
1505 | 1503 | /*FALLTHRU*/ | |
1504 | case S_IFIFO: | ||
1505 | case S_IFSOCK: | ||
1506 | flag &= ~O_TRUNC; | 1506 | flag &= ~O_TRUNC; |
1507 | break; | ||
1507 | } | 1508 | } |
1508 | 1509 | ||
1509 | error = inode_permission(inode, acc_mode); | 1510 | error = inode_permission(inode, acc_mode); |
1510 | if (error) | 1511 | if (error) |
1511 | return error; | 1512 | return error; |
1513 | |||
1514 | error = ima_path_check(path, | ||
1515 | acc_mode & (MAY_READ | MAY_WRITE | MAY_EXEC)); | ||
1516 | if (error) | ||
1517 | return error; | ||
1512 | /* | 1518 | /* |
1513 | * An append-only file must be opened in append mode for writing. | 1519 | * An append-only file must be opened in append mode for writing. |
1514 | */ | 1520 | */ |
@@ -1544,7 +1550,7 @@ int may_open(struct path *path, int acc_mode, int flag) | |||
1544 | error = security_path_truncate(path, 0, | 1550 | error = security_path_truncate(path, 0, |
1545 | ATTR_MTIME|ATTR_CTIME|ATTR_OPEN); | 1551 | ATTR_MTIME|ATTR_CTIME|ATTR_OPEN); |
1546 | if (!error) { | 1552 | if (!error) { |
1547 | DQUOT_INIT(inode); | 1553 | vfs_dq_init(inode); |
1548 | 1554 | ||
1549 | error = do_truncate(dentry, 0, | 1555 | error = do_truncate(dentry, 0, |
1550 | ATTR_MTIME|ATTR_CTIME|ATTR_OPEN, | 1556 | ATTR_MTIME|ATTR_CTIME|ATTR_OPEN, |
@@ -1555,7 +1561,7 @@ int may_open(struct path *path, int acc_mode, int flag) | |||
1555 | return error; | 1561 | return error; |
1556 | } else | 1562 | } else |
1557 | if (flag & FMODE_WRITE) | 1563 | if (flag & FMODE_WRITE) |
1558 | DQUOT_INIT(inode); | 1564 | vfs_dq_init(inode); |
1559 | 1565 | ||
1560 | return 0; | 1566 | return 0; |
1561 | } | 1567 | } |
@@ -1938,7 +1944,7 @@ int vfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev) | |||
1938 | if (error) | 1944 | if (error) |
1939 | return error; | 1945 | return error; |
1940 | 1946 | ||
1941 | DQUOT_INIT(dir); | 1947 | vfs_dq_init(dir); |
1942 | error = dir->i_op->mknod(dir, dentry, mode, dev); | 1948 | error = dir->i_op->mknod(dir, dentry, mode, dev); |
1943 | if (!error) | 1949 | if (!error) |
1944 | fsnotify_create(dir, dentry); | 1950 | fsnotify_create(dir, dentry); |
@@ -2037,7 +2043,7 @@ int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
2037 | if (error) | 2043 | if (error) |
2038 | return error; | 2044 | return error; |
2039 | 2045 | ||
2040 | DQUOT_INIT(dir); | 2046 | vfs_dq_init(dir); |
2041 | error = dir->i_op->mkdir(dir, dentry, mode); | 2047 | error = dir->i_op->mkdir(dir, dentry, mode); |
2042 | if (!error) | 2048 | if (!error) |
2043 | fsnotify_mkdir(dir, dentry); | 2049 | fsnotify_mkdir(dir, dentry); |
@@ -2123,7 +2129,7 @@ int vfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
2123 | if (!dir->i_op->rmdir) | 2129 | if (!dir->i_op->rmdir) |
2124 | return -EPERM; | 2130 | return -EPERM; |
2125 | 2131 | ||
2126 | DQUOT_INIT(dir); | 2132 | vfs_dq_init(dir); |
2127 | 2133 | ||
2128 | mutex_lock(&dentry->d_inode->i_mutex); | 2134 | mutex_lock(&dentry->d_inode->i_mutex); |
2129 | dentry_unhash(dentry); | 2135 | dentry_unhash(dentry); |
@@ -2210,7 +2216,7 @@ int vfs_unlink(struct inode *dir, struct dentry *dentry) | |||
2210 | if (!dir->i_op->unlink) | 2216 | if (!dir->i_op->unlink) |
2211 | return -EPERM; | 2217 | return -EPERM; |
2212 | 2218 | ||
2213 | DQUOT_INIT(dir); | 2219 | vfs_dq_init(dir); |
2214 | 2220 | ||
2215 | mutex_lock(&dentry->d_inode->i_mutex); | 2221 | mutex_lock(&dentry->d_inode->i_mutex); |
2216 | if (d_mountpoint(dentry)) | 2222 | if (d_mountpoint(dentry)) |
@@ -2321,7 +2327,7 @@ int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname) | |||
2321 | if (error) | 2327 | if (error) |
2322 | return error; | 2328 | return error; |
2323 | 2329 | ||
2324 | DQUOT_INIT(dir); | 2330 | vfs_dq_init(dir); |
2325 | error = dir->i_op->symlink(dir, dentry, oldname); | 2331 | error = dir->i_op->symlink(dir, dentry, oldname); |
2326 | if (!error) | 2332 | if (!error) |
2327 | fsnotify_create(dir, dentry); | 2333 | fsnotify_create(dir, dentry); |
@@ -2405,7 +2411,7 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de | |||
2405 | return error; | 2411 | return error; |
2406 | 2412 | ||
2407 | mutex_lock(&inode->i_mutex); | 2413 | mutex_lock(&inode->i_mutex); |
2408 | DQUOT_INIT(dir); | 2414 | vfs_dq_init(dir); |
2409 | error = dir->i_op->link(old_dentry, dir, new_dentry); | 2415 | error = dir->i_op->link(old_dentry, dir, new_dentry); |
2410 | mutex_unlock(&inode->i_mutex); | 2416 | mutex_unlock(&inode->i_mutex); |
2411 | if (!error) | 2417 | if (!error) |
@@ -2604,8 +2610,8 @@ int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2604 | if (!old_dir->i_op->rename) | 2610 | if (!old_dir->i_op->rename) |
2605 | return -EPERM; | 2611 | return -EPERM; |
2606 | 2612 | ||
2607 | DQUOT_INIT(old_dir); | 2613 | vfs_dq_init(old_dir); |
2608 | DQUOT_INIT(new_dir); | 2614 | vfs_dq_init(new_dir); |
2609 | 2615 | ||
2610 | old_name = fsnotify_oldname_init(old_dentry->d_name.name); | 2616 | old_name = fsnotify_oldname_init(old_dentry->d_name.name); |
2611 | 2617 | ||
diff --git a/fs/namespace.c b/fs/namespace.c index 06f8e63f6cb1..0a42e0e96027 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -397,11 +397,10 @@ static void __mnt_unmake_readonly(struct vfsmount *mnt) | |||
397 | spin_unlock(&vfsmount_lock); | 397 | spin_unlock(&vfsmount_lock); |
398 | } | 398 | } |
399 | 399 | ||
400 | int simple_set_mnt(struct vfsmount *mnt, struct super_block *sb) | 400 | void simple_set_mnt(struct vfsmount *mnt, struct super_block *sb) |
401 | { | 401 | { |
402 | mnt->mnt_sb = sb; | 402 | mnt->mnt_sb = sb; |
403 | mnt->mnt_root = dget(sb->s_root); | 403 | mnt->mnt_root = dget(sb->s_root); |
404 | return 0; | ||
405 | } | 404 | } |
406 | 405 | ||
407 | EXPORT_SYMBOL(simple_set_mnt); | 406 | EXPORT_SYMBOL(simple_set_mnt); |
@@ -780,6 +779,7 @@ static void show_mnt_opts(struct seq_file *m, struct vfsmount *mnt) | |||
780 | { MNT_NOATIME, ",noatime" }, | 779 | { MNT_NOATIME, ",noatime" }, |
781 | { MNT_NODIRATIME, ",nodiratime" }, | 780 | { MNT_NODIRATIME, ",nodiratime" }, |
782 | { MNT_RELATIME, ",relatime" }, | 781 | { MNT_RELATIME, ",relatime" }, |
782 | { MNT_STRICTATIME, ",strictatime" }, | ||
783 | { 0, NULL } | 783 | { 0, NULL } |
784 | }; | 784 | }; |
785 | const struct proc_fs_info *fs_infop; | 785 | const struct proc_fs_info *fs_infop; |
@@ -1919,6 +1919,9 @@ long do_mount(char *dev_name, char *dir_name, char *type_page, | |||
1919 | if (data_page) | 1919 | if (data_page) |
1920 | ((char *)data_page)[PAGE_SIZE - 1] = 0; | 1920 | ((char *)data_page)[PAGE_SIZE - 1] = 0; |
1921 | 1921 | ||
1922 | /* Default to relatime */ | ||
1923 | mnt_flags |= MNT_RELATIME; | ||
1924 | |||
1922 | /* Separate the per-mountpoint flags */ | 1925 | /* Separate the per-mountpoint flags */ |
1923 | if (flags & MS_NOSUID) | 1926 | if (flags & MS_NOSUID) |
1924 | mnt_flags |= MNT_NOSUID; | 1927 | mnt_flags |= MNT_NOSUID; |
@@ -1930,13 +1933,14 @@ long do_mount(char *dev_name, char *dir_name, char *type_page, | |||
1930 | mnt_flags |= MNT_NOATIME; | 1933 | mnt_flags |= MNT_NOATIME; |
1931 | if (flags & MS_NODIRATIME) | 1934 | if (flags & MS_NODIRATIME) |
1932 | mnt_flags |= MNT_NODIRATIME; | 1935 | mnt_flags |= MNT_NODIRATIME; |
1933 | if (flags & MS_RELATIME) | 1936 | if (flags & MS_STRICTATIME) |
1934 | mnt_flags |= MNT_RELATIME; | 1937 | mnt_flags &= ~(MNT_RELATIME | MNT_NOATIME); |
1935 | if (flags & MS_RDONLY) | 1938 | if (flags & MS_RDONLY) |
1936 | mnt_flags |= MNT_READONLY; | 1939 | mnt_flags |= MNT_READONLY; |
1937 | 1940 | ||
1938 | flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE | | 1941 | flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE | |
1939 | MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT); | 1942 | MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT | |
1943 | MS_STRICTATIME); | ||
1940 | 1944 | ||
1941 | /* ... and get the mountpoint */ | 1945 | /* ... and get the mountpoint */ |
1942 | retval = kern_path(dir_name, LOOKUP_FOLLOW, &path); | 1946 | retval = kern_path(dir_name, LOOKUP_FOLLOW, &path); |
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 07e9715b8658..9c590722d87e 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c | |||
@@ -79,7 +79,7 @@ static int ncp_hash_dentry(struct dentry *, struct qstr *); | |||
79 | static int ncp_compare_dentry (struct dentry *, struct qstr *, struct qstr *); | 79 | static int ncp_compare_dentry (struct dentry *, struct qstr *, struct qstr *); |
80 | static int ncp_delete_dentry(struct dentry *); | 80 | static int ncp_delete_dentry(struct dentry *); |
81 | 81 | ||
82 | static struct dentry_operations ncp_dentry_operations = | 82 | static const struct dentry_operations ncp_dentry_operations = |
83 | { | 83 | { |
84 | .d_revalidate = ncp_lookup_validate, | 84 | .d_revalidate = ncp_lookup_validate, |
85 | .d_hash = ncp_hash_dentry, | 85 | .d_hash = ncp_hash_dentry, |
@@ -87,7 +87,7 @@ static struct dentry_operations ncp_dentry_operations = | |||
87 | .d_delete = ncp_delete_dentry, | 87 | .d_delete = ncp_delete_dentry, |
88 | }; | 88 | }; |
89 | 89 | ||
90 | struct dentry_operations ncp_root_dentry_operations = | 90 | const struct dentry_operations ncp_root_dentry_operations = |
91 | { | 91 | { |
92 | .d_hash = ncp_hash_dentry, | 92 | .d_hash = ncp_hash_dentry, |
93 | .d_compare = ncp_compare_dentry, | 93 | .d_compare = ncp_compare_dentry, |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 672368f865ca..78bf72fc1db3 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
@@ -899,7 +899,7 @@ static void nfs_dentry_iput(struct dentry *dentry, struct inode *inode) | |||
899 | iput(inode); | 899 | iput(inode); |
900 | } | 900 | } |
901 | 901 | ||
902 | struct dentry_operations nfs_dentry_operations = { | 902 | const struct dentry_operations nfs_dentry_operations = { |
903 | .d_revalidate = nfs_lookup_revalidate, | 903 | .d_revalidate = nfs_lookup_revalidate, |
904 | .d_delete = nfs_dentry_delete, | 904 | .d_delete = nfs_dentry_delete, |
905 | .d_iput = nfs_dentry_iput, | 905 | .d_iput = nfs_dentry_iput, |
@@ -967,7 +967,7 @@ out: | |||
967 | #ifdef CONFIG_NFS_V4 | 967 | #ifdef CONFIG_NFS_V4 |
968 | static int nfs_open_revalidate(struct dentry *, struct nameidata *); | 968 | static int nfs_open_revalidate(struct dentry *, struct nameidata *); |
969 | 969 | ||
970 | struct dentry_operations nfs4_dentry_operations = { | 970 | const struct dentry_operations nfs4_dentry_operations = { |
971 | .d_revalidate = nfs_open_revalidate, | 971 | .d_revalidate = nfs_open_revalidate, |
972 | .d_delete = nfs_dentry_delete, | 972 | .d_delete = nfs_dentry_delete, |
973 | .d_iput = nfs_dentry_iput, | 973 | .d_iput = nfs_dentry_iput, |
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index 4e4d33204376..84345deab26f 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h | |||
@@ -179,7 +179,7 @@ struct nfs4_state_recovery_ops { | |||
179 | int (*recover_lock)(struct nfs4_state *, struct file_lock *); | 179 | int (*recover_lock)(struct nfs4_state *, struct file_lock *); |
180 | }; | 180 | }; |
181 | 181 | ||
182 | extern struct dentry_operations nfs4_dentry_operations; | 182 | extern const struct dentry_operations nfs4_dentry_operations; |
183 | extern const struct inode_operations nfs4_dir_inode_operations; | 183 | extern const struct inode_operations nfs4_dir_inode_operations; |
184 | 184 | ||
185 | /* inode.c */ | 185 | /* inode.c */ |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 6e50aaa56ca2..78376b6c0236 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -356,7 +356,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, | |||
356 | put_write_access(inode); | 356 | put_write_access(inode); |
357 | goto out_nfserr; | 357 | goto out_nfserr; |
358 | } | 358 | } |
359 | DQUOT_INIT(inode); | 359 | vfs_dq_init(inode); |
360 | } | 360 | } |
361 | 361 | ||
362 | /* sanitize the mode change */ | 362 | /* sanitize the mode change */ |
@@ -723,7 +723,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, | |||
723 | else | 723 | else |
724 | flags = O_WRONLY|O_LARGEFILE; | 724 | flags = O_WRONLY|O_LARGEFILE; |
725 | 725 | ||
726 | DQUOT_INIT(inode); | 726 | vfs_dq_init(inode); |
727 | } | 727 | } |
728 | *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), | 728 | *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), |
729 | flags, cred); | 729 | flags, cred); |
@@ -998,8 +998,11 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, | |||
998 | 998 | ||
999 | if (!EX_ISSYNC(exp)) | 999 | if (!EX_ISSYNC(exp)) |
1000 | stable = 0; | 1000 | stable = 0; |
1001 | if (stable && !EX_WGATHER(exp)) | 1001 | if (stable && !EX_WGATHER(exp)) { |
1002 | spin_lock(&file->f_lock); | ||
1002 | file->f_flags |= O_SYNC; | 1003 | file->f_flags |= O_SYNC; |
1004 | spin_unlock(&file->f_lock); | ||
1005 | } | ||
1003 | 1006 | ||
1004 | /* Write the data. */ | 1007 | /* Write the data. */ |
1005 | oldfs = get_fs(); set_fs(KERNEL_DS); | 1008 | oldfs = get_fs(); set_fs(KERNEL_DS); |
diff --git a/fs/notify/inotify/inotify.c b/fs/notify/inotify/inotify.c index 331f2e88e284..220c13f0d73d 100644 --- a/fs/notify/inotify/inotify.c +++ b/fs/notify/inotify/inotify.c | |||
@@ -380,6 +380,14 @@ void inotify_unmount_inodes(struct list_head *list) | |||
380 | struct list_head *watches; | 380 | struct list_head *watches; |
381 | 381 | ||
382 | /* | 382 | /* |
383 | * We cannot __iget() an inode in state I_CLEAR, I_FREEING, | ||
384 | * I_WILL_FREE, or I_NEW which is fine because by that point | ||
385 | * the inode cannot have any associated watches. | ||
386 | */ | ||
387 | if (inode->i_state & (I_CLEAR|I_FREEING|I_WILL_FREE|I_NEW)) | ||
388 | continue; | ||
389 | |||
390 | /* | ||
383 | * If i_count is zero, the inode cannot have any watches and | 391 | * If i_count is zero, the inode cannot have any watches and |
384 | * doing an __iget/iput with MS_ACTIVE clear would actually | 392 | * doing an __iget/iput with MS_ACTIVE clear would actually |
385 | * evict all inodes with zero i_count from icache which is | 393 | * evict all inodes with zero i_count from icache which is |
@@ -388,14 +396,6 @@ void inotify_unmount_inodes(struct list_head *list) | |||
388 | if (!atomic_read(&inode->i_count)) | 396 | if (!atomic_read(&inode->i_count)) |
389 | continue; | 397 | continue; |
390 | 398 | ||
391 | /* | ||
392 | * We cannot __iget() an inode in state I_CLEAR, I_FREEING, or | ||
393 | * I_WILL_FREE which is fine because by that point the inode | ||
394 | * cannot have any associated watches. | ||
395 | */ | ||
396 | if (inode->i_state & (I_CLEAR | I_FREEING | I_WILL_FREE)) | ||
397 | continue; | ||
398 | |||
399 | need_iput_tmp = need_iput; | 399 | need_iput_tmp = need_iput; |
400 | need_iput = NULL; | 400 | need_iput = NULL; |
401 | /* In case inotify_remove_watch_locked() drops a reference. */ | 401 | /* In case inotify_remove_watch_locked() drops a reference. */ |
diff --git a/fs/ocfs2/dcache.c b/fs/ocfs2/dcache.c index e9d7c2038c0f..7d604480557a 100644 --- a/fs/ocfs2/dcache.c +++ b/fs/ocfs2/dcache.c | |||
@@ -455,7 +455,7 @@ out_move: | |||
455 | d_move(dentry, target); | 455 | d_move(dentry, target); |
456 | } | 456 | } |
457 | 457 | ||
458 | struct dentry_operations ocfs2_dentry_ops = { | 458 | const struct dentry_operations ocfs2_dentry_ops = { |
459 | .d_revalidate = ocfs2_dentry_revalidate, | 459 | .d_revalidate = ocfs2_dentry_revalidate, |
460 | .d_iput = ocfs2_dentry_iput, | 460 | .d_iput = ocfs2_dentry_iput, |
461 | }; | 461 | }; |
diff --git a/fs/ocfs2/dcache.h b/fs/ocfs2/dcache.h index d06e16c06640..faa12e75f98d 100644 --- a/fs/ocfs2/dcache.h +++ b/fs/ocfs2/dcache.h | |||
@@ -26,7 +26,7 @@ | |||
26 | #ifndef OCFS2_DCACHE_H | 26 | #ifndef OCFS2_DCACHE_H |
27 | #define OCFS2_DCACHE_H | 27 | #define OCFS2_DCACHE_H |
28 | 28 | ||
29 | extern struct dentry_operations ocfs2_dentry_ops; | 29 | extern const struct dentry_operations ocfs2_dentry_ops; |
30 | 30 | ||
31 | struct ocfs2_dentry_lock { | 31 | struct ocfs2_dentry_lock { |
32 | /* Use count of dentry lock */ | 32 | /* Use count of dentry lock */ |
@@ -273,7 +273,7 @@ static long do_sys_truncate(const char __user *pathname, loff_t length) | |||
273 | if (!error) | 273 | if (!error) |
274 | error = security_path_truncate(&path, length, 0); | 274 | error = security_path_truncate(&path, length, 0); |
275 | if (!error) { | 275 | if (!error) { |
276 | DQUOT_INIT(inode); | 276 | vfs_dq_init(inode); |
277 | error = do_truncate(path.dentry, length, 0, NULL); | 277 | error = do_truncate(path.dentry, length, 0, NULL); |
278 | } | 278 | } |
279 | 279 | ||
diff --git a/fs/partitions/check.c b/fs/partitions/check.c index 6d720243f5f4..38e337d51ced 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c | |||
@@ -400,7 +400,7 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, | |||
400 | pdev->devt = devt; | 400 | pdev->devt = devt; |
401 | 401 | ||
402 | /* delay uevent until 'holders' subdir is created */ | 402 | /* delay uevent until 'holders' subdir is created */ |
403 | pdev->uevent_suppress = 1; | 403 | dev_set_uevent_suppress(pdev, 1); |
404 | err = device_add(pdev); | 404 | err = device_add(pdev); |
405 | if (err) | 405 | if (err) |
406 | goto out_put; | 406 | goto out_put; |
@@ -410,7 +410,7 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, | |||
410 | if (!p->holder_dir) | 410 | if (!p->holder_dir) |
411 | goto out_del; | 411 | goto out_del; |
412 | 412 | ||
413 | pdev->uevent_suppress = 0; | 413 | dev_set_uevent_suppress(pdev, 0); |
414 | if (flags & ADDPART_FLAG_WHOLEDISK) { | 414 | if (flags & ADDPART_FLAG_WHOLEDISK) { |
415 | err = device_create_file(pdev, &dev_attr_whole_disk); | 415 | err = device_create_file(pdev, &dev_attr_whole_disk); |
416 | if (err) | 416 | if (err) |
@@ -422,7 +422,7 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, | |||
422 | rcu_assign_pointer(ptbl->part[partno], p); | 422 | rcu_assign_pointer(ptbl->part[partno], p); |
423 | 423 | ||
424 | /* suppress uevent if the disk supresses it */ | 424 | /* suppress uevent if the disk supresses it */ |
425 | if (!ddev->uevent_suppress) | 425 | if (!dev_get_uevent_suppress(pdev)) |
426 | kobject_uevent(&pdev->kobj, KOBJ_ADD); | 426 | kobject_uevent(&pdev->kobj, KOBJ_ADD); |
427 | 427 | ||
428 | return p; | 428 | return p; |
@@ -455,7 +455,7 @@ void register_disk(struct gendisk *disk) | |||
455 | dev_set_name(ddev, disk->disk_name); | 455 | dev_set_name(ddev, disk->disk_name); |
456 | 456 | ||
457 | /* delay uevents, until we scanned partition table */ | 457 | /* delay uevents, until we scanned partition table */ |
458 | ddev->uevent_suppress = 1; | 458 | dev_set_uevent_suppress(ddev, 1); |
459 | 459 | ||
460 | if (device_add(ddev)) | 460 | if (device_add(ddev)) |
461 | return; | 461 | return; |
@@ -490,7 +490,7 @@ void register_disk(struct gendisk *disk) | |||
490 | 490 | ||
491 | exit: | 491 | exit: |
492 | /* announce disk after possible partitions are created */ | 492 | /* announce disk after possible partitions are created */ |
493 | ddev->uevent_suppress = 0; | 493 | dev_set_uevent_suppress(ddev, 0); |
494 | kobject_uevent(&ddev->kobj, KOBJ_ADD); | 494 | kobject_uevent(&ddev->kobj, KOBJ_ADD); |
495 | 495 | ||
496 | /* announce possible partitions */ | 496 | /* announce possible partitions */ |
diff --git a/fs/partitions/ibm.c b/fs/partitions/ibm.c index 1e064c4a4f86..46297683cd34 100644 --- a/fs/partitions/ibm.c +++ b/fs/partitions/ibm.c | |||
@@ -21,20 +21,38 @@ | |||
21 | * compute the block number from a | 21 | * compute the block number from a |
22 | * cyl-cyl-head-head structure | 22 | * cyl-cyl-head-head structure |
23 | */ | 23 | */ |
24 | static inline int | 24 | static sector_t |
25 | cchh2blk (struct vtoc_cchh *ptr, struct hd_geometry *geo) { | 25 | cchh2blk (struct vtoc_cchh *ptr, struct hd_geometry *geo) { |
26 | return ptr->cc * geo->heads * geo->sectors + | 26 | |
27 | ptr->hh * geo->sectors; | 27 | sector_t cyl; |
28 | __u16 head; | ||
29 | |||
30 | /*decode cylinder and heads for large volumes */ | ||
31 | cyl = ptr->hh & 0xFFF0; | ||
32 | cyl <<= 12; | ||
33 | cyl |= ptr->cc; | ||
34 | head = ptr->hh & 0x000F; | ||
35 | return cyl * geo->heads * geo->sectors + | ||
36 | head * geo->sectors; | ||
28 | } | 37 | } |
29 | 38 | ||
30 | /* | 39 | /* |
31 | * compute the block number from a | 40 | * compute the block number from a |
32 | * cyl-cyl-head-head-block structure | 41 | * cyl-cyl-head-head-block structure |
33 | */ | 42 | */ |
34 | static inline int | 43 | static sector_t |
35 | cchhb2blk (struct vtoc_cchhb *ptr, struct hd_geometry *geo) { | 44 | cchhb2blk (struct vtoc_cchhb *ptr, struct hd_geometry *geo) { |
36 | return ptr->cc * geo->heads * geo->sectors + | 45 | |
37 | ptr->hh * geo->sectors + | 46 | sector_t cyl; |
47 | __u16 head; | ||
48 | |||
49 | /*decode cylinder and heads for large volumes */ | ||
50 | cyl = ptr->hh & 0xFFF0; | ||
51 | cyl <<= 12; | ||
52 | cyl |= ptr->cc; | ||
53 | head = ptr->hh & 0x000F; | ||
54 | return cyl * geo->heads * geo->sectors + | ||
55 | head * geo->sectors + | ||
38 | ptr->b; | 56 | ptr->b; |
39 | } | 57 | } |
40 | 58 | ||
@@ -43,14 +61,15 @@ cchhb2blk (struct vtoc_cchhb *ptr, struct hd_geometry *geo) { | |||
43 | int | 61 | int |
44 | ibm_partition(struct parsed_partitions *state, struct block_device *bdev) | 62 | ibm_partition(struct parsed_partitions *state, struct block_device *bdev) |
45 | { | 63 | { |
46 | int blocksize, offset, size,res; | 64 | int blocksize, res; |
47 | loff_t i_size; | 65 | loff_t i_size, offset, size, fmt_size; |
48 | dasd_information2_t *info; | 66 | dasd_information2_t *info; |
49 | struct hd_geometry *geo; | 67 | struct hd_geometry *geo; |
50 | char type[5] = {0,}; | 68 | char type[5] = {0,}; |
51 | char name[7] = {0,}; | 69 | char name[7] = {0,}; |
52 | union label_t { | 70 | union label_t { |
53 | struct vtoc_volume_label vol; | 71 | struct vtoc_volume_label_cdl vol; |
72 | struct vtoc_volume_label_ldl lnx; | ||
54 | struct vtoc_cms_label cms; | 73 | struct vtoc_cms_label cms; |
55 | } *label; | 74 | } *label; |
56 | unsigned char *data; | 75 | unsigned char *data; |
@@ -85,14 +104,16 @@ ibm_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
85 | if (data == NULL) | 104 | if (data == NULL) |
86 | goto out_readerr; | 105 | goto out_readerr; |
87 | 106 | ||
88 | strncpy (type, data, 4); | ||
89 | if ((!info->FBA_layout) && (!strcmp(info->type, "ECKD"))) | ||
90 | strncpy(name, data + 8, 6); | ||
91 | else | ||
92 | strncpy(name, data + 4, 6); | ||
93 | memcpy(label, data, sizeof(union label_t)); | 107 | memcpy(label, data, sizeof(union label_t)); |
94 | put_dev_sector(sect); | 108 | put_dev_sector(sect); |
95 | 109 | ||
110 | if ((!info->FBA_layout) && (!strcmp(info->type, "ECKD"))) { | ||
111 | strncpy(type, label->vol.vollbl, 4); | ||
112 | strncpy(name, label->vol.volid, 6); | ||
113 | } else { | ||
114 | strncpy(type, label->lnx.vollbl, 4); | ||
115 | strncpy(name, label->lnx.volid, 6); | ||
116 | } | ||
96 | EBCASC(type, 4); | 117 | EBCASC(type, 4); |
97 | EBCASC(name, 6); | 118 | EBCASC(name, 6); |
98 | 119 | ||
@@ -110,36 +131,54 @@ ibm_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
110 | /* | 131 | /* |
111 | * VM style CMS1 labeled disk | 132 | * VM style CMS1 labeled disk |
112 | */ | 133 | */ |
134 | blocksize = label->cms.block_size; | ||
113 | if (label->cms.disk_offset != 0) { | 135 | if (label->cms.disk_offset != 0) { |
114 | printk("CMS1/%8s(MDSK):", name); | 136 | printk("CMS1/%8s(MDSK):", name); |
115 | /* disk is reserved minidisk */ | 137 | /* disk is reserved minidisk */ |
116 | blocksize = label->cms.block_size; | ||
117 | offset = label->cms.disk_offset; | 138 | offset = label->cms.disk_offset; |
118 | size = (label->cms.block_count - 1) | 139 | size = (label->cms.block_count - 1) |
119 | * (blocksize >> 9); | 140 | * (blocksize >> 9); |
120 | } else { | 141 | } else { |
121 | printk("CMS1/%8s:", name); | 142 | printk("CMS1/%8s:", name); |
122 | offset = (info->label_block + 1); | 143 | offset = (info->label_block + 1); |
123 | size = i_size >> 9; | 144 | size = label->cms.block_count |
145 | * (blocksize >> 9); | ||
124 | } | 146 | } |
147 | put_partition(state, 1, offset*(blocksize >> 9), | ||
148 | size-offset*(blocksize >> 9)); | ||
125 | } else { | 149 | } else { |
126 | /* | 150 | if (strncmp(type, "LNX1", 4) == 0) { |
127 | * Old style LNX1 or unlabeled disk | 151 | printk("LNX1/%8s:", name); |
128 | */ | 152 | if (label->lnx.ldl_version == 0xf2) { |
129 | if (strncmp(type, "LNX1", 4) == 0) | 153 | fmt_size = label->lnx.formatted_blocks |
130 | printk ("LNX1/%8s:", name); | 154 | * (blocksize >> 9); |
131 | else | 155 | } else if (!strcmp(info->type, "ECKD")) { |
156 | /* formated w/o large volume support */ | ||
157 | fmt_size = geo->cylinders * geo->heads | ||
158 | * geo->sectors * (blocksize >> 9); | ||
159 | } else { | ||
160 | /* old label and no usable disk geometry | ||
161 | * (e.g. DIAG) */ | ||
162 | fmt_size = i_size >> 9; | ||
163 | } | ||
164 | size = i_size >> 9; | ||
165 | if (fmt_size < size) | ||
166 | size = fmt_size; | ||
167 | offset = (info->label_block + 1); | ||
168 | } else { | ||
169 | /* unlabeled disk */ | ||
132 | printk("(nonl)"); | 170 | printk("(nonl)"); |
133 | offset = (info->label_block + 1); | 171 | size = i_size >> 9; |
134 | size = i_size >> 9; | 172 | offset = (info->label_block + 1); |
135 | } | 173 | } |
136 | put_partition(state, 1, offset*(blocksize >> 9), | 174 | put_partition(state, 1, offset*(blocksize >> 9), |
137 | size-offset*(blocksize >> 9)); | 175 | size-offset*(blocksize >> 9)); |
176 | } | ||
138 | } else if (info->format == DASD_FORMAT_CDL) { | 177 | } else if (info->format == DASD_FORMAT_CDL) { |
139 | /* | 178 | /* |
140 | * New style CDL formatted disk | 179 | * New style CDL formatted disk |
141 | */ | 180 | */ |
142 | unsigned int blk; | 181 | sector_t blk; |
143 | int counter; | 182 | int counter; |
144 | 183 | ||
145 | /* | 184 | /* |
@@ -166,7 +205,8 @@ ibm_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
166 | /* skip FMT4 / FMT5 / FMT7 labels */ | 205 | /* skip FMT4 / FMT5 / FMT7 labels */ |
167 | if (f1.DS1FMTID == _ascebc['4'] | 206 | if (f1.DS1FMTID == _ascebc['4'] |
168 | || f1.DS1FMTID == _ascebc['5'] | 207 | || f1.DS1FMTID == _ascebc['5'] |
169 | || f1.DS1FMTID == _ascebc['7']) { | 208 | || f1.DS1FMTID == _ascebc['7'] |
209 | || f1.DS1FMTID == _ascebc['9']) { | ||
170 | blk++; | 210 | blk++; |
171 | data = read_dev_sector(bdev, blk * | 211 | data = read_dev_sector(bdev, blk * |
172 | (blocksize/512), | 212 | (blocksize/512), |
@@ -174,8 +214,9 @@ ibm_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
174 | continue; | 214 | continue; |
175 | } | 215 | } |
176 | 216 | ||
177 | /* only FMT1 valid at this point */ | 217 | /* only FMT1 and 8 labels valid at this point */ |
178 | if (f1.DS1FMTID != _ascebc['1']) | 218 | if (f1.DS1FMTID != _ascebc['1'] && |
219 | f1.DS1FMTID != _ascebc['8']) | ||
179 | break; | 220 | break; |
180 | 221 | ||
181 | /* OK, we got valid partition data */ | 222 | /* OK, we got valid partition data */ |
@@ -667,10 +667,7 @@ pipe_read_fasync(int fd, struct file *filp, int on) | |||
667 | retval = fasync_helper(fd, filp, on, &inode->i_pipe->fasync_readers); | 667 | retval = fasync_helper(fd, filp, on, &inode->i_pipe->fasync_readers); |
668 | mutex_unlock(&inode->i_mutex); | 668 | mutex_unlock(&inode->i_mutex); |
669 | 669 | ||
670 | if (retval < 0) | 670 | return retval; |
671 | return retval; | ||
672 | |||
673 | return 0; | ||
674 | } | 671 | } |
675 | 672 | ||
676 | 673 | ||
@@ -684,10 +681,7 @@ pipe_write_fasync(int fd, struct file *filp, int on) | |||
684 | retval = fasync_helper(fd, filp, on, &inode->i_pipe->fasync_writers); | 681 | retval = fasync_helper(fd, filp, on, &inode->i_pipe->fasync_writers); |
685 | mutex_unlock(&inode->i_mutex); | 682 | mutex_unlock(&inode->i_mutex); |
686 | 683 | ||
687 | if (retval < 0) | 684 | return retval; |
688 | return retval; | ||
689 | |||
690 | return 0; | ||
691 | } | 685 | } |
692 | 686 | ||
693 | 687 | ||
@@ -706,11 +700,7 @@ pipe_rdwr_fasync(int fd, struct file *filp, int on) | |||
706 | fasync_helper(-1, filp, 0, &pipe->fasync_readers); | 700 | fasync_helper(-1, filp, 0, &pipe->fasync_readers); |
707 | } | 701 | } |
708 | mutex_unlock(&inode->i_mutex); | 702 | mutex_unlock(&inode->i_mutex); |
709 | 703 | return retval; | |
710 | if (retval < 0) | ||
711 | return retval; | ||
712 | |||
713 | return 0; | ||
714 | } | 704 | } |
715 | 705 | ||
716 | 706 | ||
@@ -870,7 +860,7 @@ static char *pipefs_dname(struct dentry *dentry, char *buffer, int buflen) | |||
870 | dentry->d_inode->i_ino); | 860 | dentry->d_inode->i_ino); |
871 | } | 861 | } |
872 | 862 | ||
873 | static struct dentry_operations pipefs_dentry_operations = { | 863 | static const struct dentry_operations pipefs_dentry_operations = { |
874 | .d_delete = pipefs_delete_dentry, | 864 | .d_delete = pipefs_delete_dentry, |
875 | .d_dname = pipefs_dname, | 865 | .d_dname = pipefs_dname, |
876 | }; | 866 | }; |
@@ -1034,11 +1024,6 @@ int do_pipe_flags(int *fd, int flags) | |||
1034 | return error; | 1024 | return error; |
1035 | } | 1025 | } |
1036 | 1026 | ||
1037 | int do_pipe(int *fd) | ||
1038 | { | ||
1039 | return do_pipe_flags(fd, 0); | ||
1040 | } | ||
1041 | |||
1042 | /* | 1027 | /* |
1043 | * sys_pipe() is the normal C calling standard for creating | 1028 | * sys_pipe() is the normal C calling standard for creating |
1044 | * a pipe. It's not the way Unix traditionally does this, though. | 1029 | * a pipe. It's not the way Unix traditionally does this, though. |
diff --git a/fs/proc/base.c b/fs/proc/base.c index beaa0ce3b82e..e0afd326b688 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c | |||
@@ -146,15 +146,22 @@ static unsigned int pid_entry_count_dirs(const struct pid_entry *entries, | |||
146 | return count; | 146 | return count; |
147 | } | 147 | } |
148 | 148 | ||
149 | static struct fs_struct *get_fs_struct(struct task_struct *task) | 149 | static int get_fs_path(struct task_struct *task, struct path *path, bool root) |
150 | { | 150 | { |
151 | struct fs_struct *fs; | 151 | struct fs_struct *fs; |
152 | int result = -ENOENT; | ||
153 | |||
152 | task_lock(task); | 154 | task_lock(task); |
153 | fs = task->fs; | 155 | fs = task->fs; |
154 | if(fs) | 156 | if (fs) { |
155 | atomic_inc(&fs->count); | 157 | read_lock(&fs->lock); |
158 | *path = root ? fs->root : fs->pwd; | ||
159 | path_get(path); | ||
160 | read_unlock(&fs->lock); | ||
161 | result = 0; | ||
162 | } | ||
156 | task_unlock(task); | 163 | task_unlock(task); |
157 | return fs; | 164 | return result; |
158 | } | 165 | } |
159 | 166 | ||
160 | static int get_nr_threads(struct task_struct *tsk) | 167 | static int get_nr_threads(struct task_struct *tsk) |
@@ -172,42 +179,24 @@ static int get_nr_threads(struct task_struct *tsk) | |||
172 | static int proc_cwd_link(struct inode *inode, struct path *path) | 179 | static int proc_cwd_link(struct inode *inode, struct path *path) |
173 | { | 180 | { |
174 | struct task_struct *task = get_proc_task(inode); | 181 | struct task_struct *task = get_proc_task(inode); |
175 | struct fs_struct *fs = NULL; | ||
176 | int result = -ENOENT; | 182 | int result = -ENOENT; |
177 | 183 | ||
178 | if (task) { | 184 | if (task) { |
179 | fs = get_fs_struct(task); | 185 | result = get_fs_path(task, path, 0); |
180 | put_task_struct(task); | 186 | put_task_struct(task); |
181 | } | 187 | } |
182 | if (fs) { | ||
183 | read_lock(&fs->lock); | ||
184 | *path = fs->pwd; | ||
185 | path_get(&fs->pwd); | ||
186 | read_unlock(&fs->lock); | ||
187 | result = 0; | ||
188 | put_fs_struct(fs); | ||
189 | } | ||
190 | return result; | 188 | return result; |
191 | } | 189 | } |
192 | 190 | ||
193 | static int proc_root_link(struct inode *inode, struct path *path) | 191 | static int proc_root_link(struct inode *inode, struct path *path) |
194 | { | 192 | { |
195 | struct task_struct *task = get_proc_task(inode); | 193 | struct task_struct *task = get_proc_task(inode); |
196 | struct fs_struct *fs = NULL; | ||
197 | int result = -ENOENT; | 194 | int result = -ENOENT; |
198 | 195 | ||
199 | if (task) { | 196 | if (task) { |
200 | fs = get_fs_struct(task); | 197 | result = get_fs_path(task, path, 1); |
201 | put_task_struct(task); | 198 | put_task_struct(task); |
202 | } | 199 | } |
203 | if (fs) { | ||
204 | read_lock(&fs->lock); | ||
205 | *path = fs->root; | ||
206 | path_get(&fs->root); | ||
207 | read_unlock(&fs->lock); | ||
208 | result = 0; | ||
209 | put_fs_struct(fs); | ||
210 | } | ||
211 | return result; | 200 | return result; |
212 | } | 201 | } |
213 | 202 | ||
@@ -596,7 +585,6 @@ static int mounts_open_common(struct inode *inode, struct file *file, | |||
596 | struct task_struct *task = get_proc_task(inode); | 585 | struct task_struct *task = get_proc_task(inode); |
597 | struct nsproxy *nsp; | 586 | struct nsproxy *nsp; |
598 | struct mnt_namespace *ns = NULL; | 587 | struct mnt_namespace *ns = NULL; |
599 | struct fs_struct *fs = NULL; | ||
600 | struct path root; | 588 | struct path root; |
601 | struct proc_mounts *p; | 589 | struct proc_mounts *p; |
602 | int ret = -EINVAL; | 590 | int ret = -EINVAL; |
@@ -610,22 +598,16 @@ static int mounts_open_common(struct inode *inode, struct file *file, | |||
610 | get_mnt_ns(ns); | 598 | get_mnt_ns(ns); |
611 | } | 599 | } |
612 | rcu_read_unlock(); | 600 | rcu_read_unlock(); |
613 | if (ns) | 601 | if (ns && get_fs_path(task, &root, 1) == 0) |
614 | fs = get_fs_struct(task); | 602 | ret = 0; |
615 | put_task_struct(task); | 603 | put_task_struct(task); |
616 | } | 604 | } |
617 | 605 | ||
618 | if (!ns) | 606 | if (!ns) |
619 | goto err; | 607 | goto err; |
620 | if (!fs) | 608 | if (ret) |
621 | goto err_put_ns; | 609 | goto err_put_ns; |
622 | 610 | ||
623 | read_lock(&fs->lock); | ||
624 | root = fs->root; | ||
625 | path_get(&root); | ||
626 | read_unlock(&fs->lock); | ||
627 | put_fs_struct(fs); | ||
628 | |||
629 | ret = -ENOMEM; | 611 | ret = -ENOMEM; |
630 | p = kmalloc(sizeof(struct proc_mounts), GFP_KERNEL); | 612 | p = kmalloc(sizeof(struct proc_mounts), GFP_KERNEL); |
631 | if (!p) | 613 | if (!p) |
@@ -1545,7 +1527,7 @@ static int pid_delete_dentry(struct dentry * dentry) | |||
1545 | return !proc_pid(dentry->d_inode)->tasks[PIDTYPE_PID].first; | 1527 | return !proc_pid(dentry->d_inode)->tasks[PIDTYPE_PID].first; |
1546 | } | 1528 | } |
1547 | 1529 | ||
1548 | static struct dentry_operations pid_dentry_operations = | 1530 | static const struct dentry_operations pid_dentry_operations = |
1549 | { | 1531 | { |
1550 | .d_revalidate = pid_revalidate, | 1532 | .d_revalidate = pid_revalidate, |
1551 | .d_delete = pid_delete_dentry, | 1533 | .d_delete = pid_delete_dentry, |
@@ -1717,7 +1699,7 @@ static int tid_fd_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1717 | return 0; | 1699 | return 0; |
1718 | } | 1700 | } |
1719 | 1701 | ||
1720 | static struct dentry_operations tid_fd_dentry_operations = | 1702 | static const struct dentry_operations tid_fd_dentry_operations = |
1721 | { | 1703 | { |
1722 | .d_revalidate = tid_fd_revalidate, | 1704 | .d_revalidate = tid_fd_revalidate, |
1723 | .d_delete = pid_delete_dentry, | 1705 | .d_delete = pid_delete_dentry, |
@@ -2339,7 +2321,7 @@ static int proc_base_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
2339 | return 0; | 2321 | return 0; |
2340 | } | 2322 | } |
2341 | 2323 | ||
2342 | static struct dentry_operations proc_base_dentry_operations = | 2324 | static const struct dentry_operations proc_base_dentry_operations = |
2343 | { | 2325 | { |
2344 | .d_revalidate = proc_base_revalidate, | 2326 | .d_revalidate = proc_base_revalidate, |
2345 | .d_delete = pid_delete_dentry, | 2327 | .d_delete = pid_delete_dentry, |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index db7fa5cab988..5d2989e9dcc1 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -363,7 +363,7 @@ static int proc_delete_dentry(struct dentry * dentry) | |||
363 | return 1; | 363 | return 1; |
364 | } | 364 | } |
365 | 365 | ||
366 | static struct dentry_operations proc_dentry_operations = | 366 | static const struct dentry_operations proc_dentry_operations = |
367 | { | 367 | { |
368 | .d_delete = proc_delete_dentry, | 368 | .d_delete = proc_delete_dentry, |
369 | }; | 369 | }; |
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 94fcfff6863a..9b1e4e9a16bf 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c | |||
@@ -7,7 +7,7 @@ | |||
7 | #include <linux/security.h> | 7 | #include <linux/security.h> |
8 | #include "internal.h" | 8 | #include "internal.h" |
9 | 9 | ||
10 | static struct dentry_operations proc_sys_dentry_operations; | 10 | static const struct dentry_operations proc_sys_dentry_operations; |
11 | static const struct file_operations proc_sys_file_operations; | 11 | static const struct file_operations proc_sys_file_operations; |
12 | static const struct inode_operations proc_sys_inode_operations; | 12 | static const struct inode_operations proc_sys_inode_operations; |
13 | static const struct file_operations proc_sys_dir_file_operations; | 13 | static const struct file_operations proc_sys_dir_file_operations; |
@@ -396,7 +396,7 @@ static int proc_sys_compare(struct dentry *dir, struct qstr *qstr, | |||
396 | return !sysctl_is_seen(PROC_I(dentry->d_inode)->sysctl); | 396 | return !sysctl_is_seen(PROC_I(dentry->d_inode)->sysctl); |
397 | } | 397 | } |
398 | 398 | ||
399 | static struct dentry_operations proc_sys_dentry_operations = { | 399 | static const struct dentry_operations proc_sys_dentry_operations = { |
400 | .d_revalidate = proc_sys_revalidate, | 400 | .d_revalidate = proc_sys_revalidate, |
401 | .d_delete = proc_sys_delete, | 401 | .d_delete = proc_sys_delete, |
402 | .d_compare = proc_sys_compare, | 402 | .d_compare = proc_sys_compare, |
diff --git a/fs/proc/root.c b/fs/proc/root.c index f6299a25594e..1e15a2b176e8 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
@@ -83,7 +83,8 @@ static int proc_get_sb(struct file_system_type *fs_type, | |||
83 | ns->proc_mnt = mnt; | 83 | ns->proc_mnt = mnt; |
84 | } | 84 | } |
85 | 85 | ||
86 | return simple_set_mnt(mnt, sb); | 86 | simple_set_mnt(mnt, sb); |
87 | return 0; | ||
87 | } | 88 | } |
88 | 89 | ||
89 | static void proc_kill_sb(struct super_block *sb) | 90 | static void proc_kill_sb(struct super_block *sb) |
diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig new file mode 100644 index 000000000000..8047e01ef46b --- /dev/null +++ b/fs/quota/Kconfig | |||
@@ -0,0 +1,59 @@ | |||
1 | # | ||
2 | # Quota configuration | ||
3 | # | ||
4 | |||
5 | config QUOTA | ||
6 | bool "Quota support" | ||
7 | help | ||
8 | If you say Y here, you will be able to set per user limits for disk | ||
9 | usage (also called disk quotas). Currently, it works for the | ||
10 | ext2, ext3, and reiserfs file system. ext3 also supports journalled | ||
11 | quotas for which you don't need to run quotacheck(8) after an unclean | ||
12 | shutdown. | ||
13 | For further details, read the Quota mini-HOWTO, available from | ||
14 | <http://www.tldp.org/docs.html#howto>, or the documentation provided | ||
15 | with the quota tools. Probably the quota support is only useful for | ||
16 | multi user systems. If unsure, say N. | ||
17 | |||
18 | config QUOTA_NETLINK_INTERFACE | ||
19 | bool "Report quota messages through netlink interface" | ||
20 | depends on QUOTA && NET | ||
21 | help | ||
22 | If you say Y here, quota warnings (about exceeding softlimit, reaching | ||
23 | hardlimit, etc.) will be reported through netlink interface. If unsure, | ||
24 | say Y. | ||
25 | |||
26 | config PRINT_QUOTA_WARNING | ||
27 | bool "Print quota warnings to console (OBSOLETE)" | ||
28 | depends on QUOTA | ||
29 | default y | ||
30 | help | ||
31 | If you say Y here, quota warnings (about exceeding softlimit, reaching | ||
32 | hardlimit, etc.) will be printed to the process' controlling terminal. | ||
33 | Note that this behavior is currently deprecated and may go away in | ||
34 | future. Please use notification via netlink socket instead. | ||
35 | |||
36 | # Generic support for tree structured quota files. Selected when needed. | ||
37 | config QUOTA_TREE | ||
38 | tristate | ||
39 | |||
40 | config QFMT_V1 | ||
41 | tristate "Old quota format support" | ||
42 | depends on QUOTA | ||
43 | help | ||
44 | This quota format was (is) used by kernels earlier than 2.4.22. If | ||
45 | you have quota working and you don't want to convert to new quota | ||
46 | format say Y here. | ||
47 | |||
48 | config QFMT_V2 | ||
49 | tristate "Quota format v2 support" | ||
50 | depends on QUOTA | ||
51 | select QUOTA_TREE | ||
52 | help | ||
53 | This quota format allows using quotas with 32-bit UIDs/GIDs. If you | ||
54 | need this functionality say Y here. | ||
55 | |||
56 | config QUOTACTL | ||
57 | bool | ||
58 | depends on XFS_QUOTA || QUOTA | ||
59 | default y | ||
diff --git a/fs/quota/Makefile b/fs/quota/Makefile new file mode 100644 index 000000000000..385a0831cc99 --- /dev/null +++ b/fs/quota/Makefile | |||
@@ -0,0 +1,14 @@ | |||
1 | # | ||
2 | # Makefile for the Linux filesystems. | ||
3 | # | ||
4 | # 14 Sep 2000, Christoph Hellwig <hch@infradead.org> | ||
5 | # Rewritten to use lists instead of if-statements. | ||
6 | # | ||
7 | |||
8 | obj-y := | ||
9 | |||
10 | obj-$(CONFIG_QUOTA) += dquot.o | ||
11 | obj-$(CONFIG_QFMT_V1) += quota_v1.o | ||
12 | obj-$(CONFIG_QFMT_V2) += quota_v2.o | ||
13 | obj-$(CONFIG_QUOTA_TREE) += quota_tree.o | ||
14 | obj-$(CONFIG_QUOTACTL) += quota.o | ||
diff --git a/fs/dquot.c b/fs/quota/dquot.c index bca3cac4bee7..2ca967a5ef77 100644 --- a/fs/dquot.c +++ b/fs/quota/dquot.c | |||
@@ -129,9 +129,10 @@ | |||
129 | * i_mutex on quota files is special (it's below dqio_mutex) | 129 | * i_mutex on quota files is special (it's below dqio_mutex) |
130 | */ | 130 | */ |
131 | 131 | ||
132 | static DEFINE_SPINLOCK(dq_list_lock); | 132 | static __cacheline_aligned_in_smp DEFINE_SPINLOCK(dq_list_lock); |
133 | static DEFINE_SPINLOCK(dq_state_lock); | 133 | static __cacheline_aligned_in_smp DEFINE_SPINLOCK(dq_state_lock); |
134 | DEFINE_SPINLOCK(dq_data_lock); | 134 | __cacheline_aligned_in_smp DEFINE_SPINLOCK(dq_data_lock); |
135 | EXPORT_SYMBOL(dq_data_lock); | ||
135 | 136 | ||
136 | static char *quotatypes[] = INITQFNAMES; | 137 | static char *quotatypes[] = INITQFNAMES; |
137 | static struct quota_format_type *quota_formats; /* List of registered formats */ | 138 | static struct quota_format_type *quota_formats; /* List of registered formats */ |
@@ -148,35 +149,46 @@ int register_quota_format(struct quota_format_type *fmt) | |||
148 | spin_unlock(&dq_list_lock); | 149 | spin_unlock(&dq_list_lock); |
149 | return 0; | 150 | return 0; |
150 | } | 151 | } |
152 | EXPORT_SYMBOL(register_quota_format); | ||
151 | 153 | ||
152 | void unregister_quota_format(struct quota_format_type *fmt) | 154 | void unregister_quota_format(struct quota_format_type *fmt) |
153 | { | 155 | { |
154 | struct quota_format_type **actqf; | 156 | struct quota_format_type **actqf; |
155 | 157 | ||
156 | spin_lock(&dq_list_lock); | 158 | spin_lock(&dq_list_lock); |
157 | for (actqf = "a_formats; *actqf && *actqf != fmt; actqf = &(*actqf)->qf_next); | 159 | for (actqf = "a_formats; *actqf && *actqf != fmt; |
160 | actqf = &(*actqf)->qf_next) | ||
161 | ; | ||
158 | if (*actqf) | 162 | if (*actqf) |
159 | *actqf = (*actqf)->qf_next; | 163 | *actqf = (*actqf)->qf_next; |
160 | spin_unlock(&dq_list_lock); | 164 | spin_unlock(&dq_list_lock); |
161 | } | 165 | } |
166 | EXPORT_SYMBOL(unregister_quota_format); | ||
162 | 167 | ||
163 | static struct quota_format_type *find_quota_format(int id) | 168 | static struct quota_format_type *find_quota_format(int id) |
164 | { | 169 | { |
165 | struct quota_format_type *actqf; | 170 | struct quota_format_type *actqf; |
166 | 171 | ||
167 | spin_lock(&dq_list_lock); | 172 | spin_lock(&dq_list_lock); |
168 | for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next); | 173 | for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; |
174 | actqf = actqf->qf_next) | ||
175 | ; | ||
169 | if (!actqf || !try_module_get(actqf->qf_owner)) { | 176 | if (!actqf || !try_module_get(actqf->qf_owner)) { |
170 | int qm; | 177 | int qm; |
171 | 178 | ||
172 | spin_unlock(&dq_list_lock); | 179 | spin_unlock(&dq_list_lock); |
173 | 180 | ||
174 | for (qm = 0; module_names[qm].qm_fmt_id && module_names[qm].qm_fmt_id != id; qm++); | 181 | for (qm = 0; module_names[qm].qm_fmt_id && |
175 | if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name)) | 182 | module_names[qm].qm_fmt_id != id; qm++) |
183 | ; | ||
184 | if (!module_names[qm].qm_fmt_id || | ||
185 | request_module(module_names[qm].qm_mod_name)) | ||
176 | return NULL; | 186 | return NULL; |
177 | 187 | ||
178 | spin_lock(&dq_list_lock); | 188 | spin_lock(&dq_list_lock); |
179 | for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next); | 189 | for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; |
190 | actqf = actqf->qf_next) | ||
191 | ; | ||
180 | if (actqf && !try_module_get(actqf->qf_owner)) | 192 | if (actqf && !try_module_get(actqf->qf_owner)) |
181 | actqf = NULL; | 193 | actqf = NULL; |
182 | } | 194 | } |
@@ -215,6 +227,7 @@ static unsigned int dq_hash_bits, dq_hash_mask; | |||
215 | static struct hlist_head *dquot_hash; | 227 | static struct hlist_head *dquot_hash; |
216 | 228 | ||
217 | struct dqstats dqstats; | 229 | struct dqstats dqstats; |
230 | EXPORT_SYMBOL(dqstats); | ||
218 | 231 | ||
219 | static inline unsigned int | 232 | static inline unsigned int |
220 | hashfn(const struct super_block *sb, unsigned int id, int type) | 233 | hashfn(const struct super_block *sb, unsigned int id, int type) |
@@ -230,7 +243,8 @@ hashfn(const struct super_block *sb, unsigned int id, int type) | |||
230 | */ | 243 | */ |
231 | static inline void insert_dquot_hash(struct dquot *dquot) | 244 | static inline void insert_dquot_hash(struct dquot *dquot) |
232 | { | 245 | { |
233 | struct hlist_head *head = dquot_hash + hashfn(dquot->dq_sb, dquot->dq_id, dquot->dq_type); | 246 | struct hlist_head *head; |
247 | head = dquot_hash + hashfn(dquot->dq_sb, dquot->dq_id, dquot->dq_type); | ||
234 | hlist_add_head(&dquot->dq_hash, head); | 248 | hlist_add_head(&dquot->dq_hash, head); |
235 | } | 249 | } |
236 | 250 | ||
@@ -239,17 +253,19 @@ static inline void remove_dquot_hash(struct dquot *dquot) | |||
239 | hlist_del_init(&dquot->dq_hash); | 253 | hlist_del_init(&dquot->dq_hash); |
240 | } | 254 | } |
241 | 255 | ||
242 | static inline struct dquot *find_dquot(unsigned int hashent, struct super_block *sb, unsigned int id, int type) | 256 | static struct dquot *find_dquot(unsigned int hashent, struct super_block *sb, |
257 | unsigned int id, int type) | ||
243 | { | 258 | { |
244 | struct hlist_node *node; | 259 | struct hlist_node *node; |
245 | struct dquot *dquot; | 260 | struct dquot *dquot; |
246 | 261 | ||
247 | hlist_for_each (node, dquot_hash+hashent) { | 262 | hlist_for_each (node, dquot_hash+hashent) { |
248 | dquot = hlist_entry(node, struct dquot, dq_hash); | 263 | dquot = hlist_entry(node, struct dquot, dq_hash); |
249 | if (dquot->dq_sb == sb && dquot->dq_id == id && dquot->dq_type == type) | 264 | if (dquot->dq_sb == sb && dquot->dq_id == id && |
265 | dquot->dq_type == type) | ||
250 | return dquot; | 266 | return dquot; |
251 | } | 267 | } |
252 | return NODQUOT; | 268 | return NULL; |
253 | } | 269 | } |
254 | 270 | ||
255 | /* Add a dquot to the tail of the free list */ | 271 | /* Add a dquot to the tail of the free list */ |
@@ -309,6 +325,7 @@ int dquot_mark_dquot_dirty(struct dquot *dquot) | |||
309 | spin_unlock(&dq_list_lock); | 325 | spin_unlock(&dq_list_lock); |
310 | return 0; | 326 | return 0; |
311 | } | 327 | } |
328 | EXPORT_SYMBOL(dquot_mark_dquot_dirty); | ||
312 | 329 | ||
313 | /* This function needs dq_list_lock */ | 330 | /* This function needs dq_list_lock */ |
314 | static inline int clear_dquot_dirty(struct dquot *dquot) | 331 | static inline int clear_dquot_dirty(struct dquot *dquot) |
@@ -345,8 +362,10 @@ int dquot_acquire(struct dquot *dquot) | |||
345 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags) && !dquot->dq_off) { | 362 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags) && !dquot->dq_off) { |
346 | ret = dqopt->ops[dquot->dq_type]->commit_dqblk(dquot); | 363 | ret = dqopt->ops[dquot->dq_type]->commit_dqblk(dquot); |
347 | /* Write the info if needed */ | 364 | /* Write the info if needed */ |
348 | if (info_dirty(&dqopt->info[dquot->dq_type])) | 365 | if (info_dirty(&dqopt->info[dquot->dq_type])) { |
349 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info(dquot->dq_sb, dquot->dq_type); | 366 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info( |
367 | dquot->dq_sb, dquot->dq_type); | ||
368 | } | ||
350 | if (ret < 0) | 369 | if (ret < 0) |
351 | goto out_iolock; | 370 | goto out_iolock; |
352 | if (ret2 < 0) { | 371 | if (ret2 < 0) { |
@@ -360,6 +379,7 @@ out_iolock: | |||
360 | mutex_unlock(&dquot->dq_lock); | 379 | mutex_unlock(&dquot->dq_lock); |
361 | return ret; | 380 | return ret; |
362 | } | 381 | } |
382 | EXPORT_SYMBOL(dquot_acquire); | ||
363 | 383 | ||
364 | /* | 384 | /* |
365 | * Write dquot to disk | 385 | * Write dquot to disk |
@@ -380,8 +400,10 @@ int dquot_commit(struct dquot *dquot) | |||
380 | * => we have better not writing it */ | 400 | * => we have better not writing it */ |
381 | if (test_bit(DQ_ACTIVE_B, &dquot->dq_flags)) { | 401 | if (test_bit(DQ_ACTIVE_B, &dquot->dq_flags)) { |
382 | ret = dqopt->ops[dquot->dq_type]->commit_dqblk(dquot); | 402 | ret = dqopt->ops[dquot->dq_type]->commit_dqblk(dquot); |
383 | if (info_dirty(&dqopt->info[dquot->dq_type])) | 403 | if (info_dirty(&dqopt->info[dquot->dq_type])) { |
384 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info(dquot->dq_sb, dquot->dq_type); | 404 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info( |
405 | dquot->dq_sb, dquot->dq_type); | ||
406 | } | ||
385 | if (ret >= 0) | 407 | if (ret >= 0) |
386 | ret = ret2; | 408 | ret = ret2; |
387 | } | 409 | } |
@@ -389,6 +411,7 @@ out_sem: | |||
389 | mutex_unlock(&dqopt->dqio_mutex); | 411 | mutex_unlock(&dqopt->dqio_mutex); |
390 | return ret; | 412 | return ret; |
391 | } | 413 | } |
414 | EXPORT_SYMBOL(dquot_commit); | ||
392 | 415 | ||
393 | /* | 416 | /* |
394 | * Release dquot | 417 | * Release dquot |
@@ -406,8 +429,10 @@ int dquot_release(struct dquot *dquot) | |||
406 | if (dqopt->ops[dquot->dq_type]->release_dqblk) { | 429 | if (dqopt->ops[dquot->dq_type]->release_dqblk) { |
407 | ret = dqopt->ops[dquot->dq_type]->release_dqblk(dquot); | 430 | ret = dqopt->ops[dquot->dq_type]->release_dqblk(dquot); |
408 | /* Write the info */ | 431 | /* Write the info */ |
409 | if (info_dirty(&dqopt->info[dquot->dq_type])) | 432 | if (info_dirty(&dqopt->info[dquot->dq_type])) { |
410 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info(dquot->dq_sb, dquot->dq_type); | 433 | ret2 = dqopt->ops[dquot->dq_type]->write_file_info( |
434 | dquot->dq_sb, dquot->dq_type); | ||
435 | } | ||
411 | if (ret >= 0) | 436 | if (ret >= 0) |
412 | ret = ret2; | 437 | ret = ret2; |
413 | } | 438 | } |
@@ -417,6 +442,7 @@ out_dqlock: | |||
417 | mutex_unlock(&dquot->dq_lock); | 442 | mutex_unlock(&dquot->dq_lock); |
418 | return ret; | 443 | return ret; |
419 | } | 444 | } |
445 | EXPORT_SYMBOL(dquot_release); | ||
420 | 446 | ||
421 | void dquot_destroy(struct dquot *dquot) | 447 | void dquot_destroy(struct dquot *dquot) |
422 | { | 448 | { |
@@ -516,6 +542,7 @@ out: | |||
516 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); | 542 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); |
517 | return ret; | 543 | return ret; |
518 | } | 544 | } |
545 | EXPORT_SYMBOL(dquot_scan_active); | ||
519 | 546 | ||
520 | int vfs_quota_sync(struct super_block *sb, int type) | 547 | int vfs_quota_sync(struct super_block *sb, int type) |
521 | { | 548 | { |
@@ -533,7 +560,8 @@ int vfs_quota_sync(struct super_block *sb, int type) | |||
533 | spin_lock(&dq_list_lock); | 560 | spin_lock(&dq_list_lock); |
534 | dirty = &dqopt->info[cnt].dqi_dirty_list; | 561 | dirty = &dqopt->info[cnt].dqi_dirty_list; |
535 | while (!list_empty(dirty)) { | 562 | while (!list_empty(dirty)) { |
536 | dquot = list_first_entry(dirty, struct dquot, dq_dirty); | 563 | dquot = list_first_entry(dirty, struct dquot, |
564 | dq_dirty); | ||
537 | /* Dirty and inactive can be only bad dquot... */ | 565 | /* Dirty and inactive can be only bad dquot... */ |
538 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags)) { | 566 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags)) { |
539 | clear_dquot_dirty(dquot); | 567 | clear_dquot_dirty(dquot); |
@@ -563,6 +591,7 @@ int vfs_quota_sync(struct super_block *sb, int type) | |||
563 | 591 | ||
564 | return 0; | 592 | return 0; |
565 | } | 593 | } |
594 | EXPORT_SYMBOL(vfs_quota_sync); | ||
566 | 595 | ||
567 | /* Free unused dquots from cache */ | 596 | /* Free unused dquots from cache */ |
568 | static void prune_dqcache(int count) | 597 | static void prune_dqcache(int count) |
@@ -672,6 +701,7 @@ we_slept: | |||
672 | put_dquot_last(dquot); | 701 | put_dquot_last(dquot); |
673 | spin_unlock(&dq_list_lock); | 702 | spin_unlock(&dq_list_lock); |
674 | } | 703 | } |
704 | EXPORT_SYMBOL(dqput); | ||
675 | 705 | ||
676 | struct dquot *dquot_alloc(struct super_block *sb, int type) | 706 | struct dquot *dquot_alloc(struct super_block *sb, int type) |
677 | { | 707 | { |
@@ -685,7 +715,7 @@ static struct dquot *get_empty_dquot(struct super_block *sb, int type) | |||
685 | 715 | ||
686 | dquot = sb->dq_op->alloc_dquot(sb, type); | 716 | dquot = sb->dq_op->alloc_dquot(sb, type); |
687 | if(!dquot) | 717 | if(!dquot) |
688 | return NODQUOT; | 718 | return NULL; |
689 | 719 | ||
690 | mutex_init(&dquot->dq_lock); | 720 | mutex_init(&dquot->dq_lock); |
691 | INIT_LIST_HEAD(&dquot->dq_free); | 721 | INIT_LIST_HEAD(&dquot->dq_free); |
@@ -711,10 +741,10 @@ static struct dquot *get_empty_dquot(struct super_block *sb, int type) | |||
711 | struct dquot *dqget(struct super_block *sb, unsigned int id, int type) | 741 | struct dquot *dqget(struct super_block *sb, unsigned int id, int type) |
712 | { | 742 | { |
713 | unsigned int hashent = hashfn(sb, id, type); | 743 | unsigned int hashent = hashfn(sb, id, type); |
714 | struct dquot *dquot = NODQUOT, *empty = NODQUOT; | 744 | struct dquot *dquot = NULL, *empty = NULL; |
715 | 745 | ||
716 | if (!sb_has_quota_active(sb, type)) | 746 | if (!sb_has_quota_active(sb, type)) |
717 | return NODQUOT; | 747 | return NULL; |
718 | we_slept: | 748 | we_slept: |
719 | spin_lock(&dq_list_lock); | 749 | spin_lock(&dq_list_lock); |
720 | spin_lock(&dq_state_lock); | 750 | spin_lock(&dq_state_lock); |
@@ -725,15 +755,17 @@ we_slept: | |||
725 | } | 755 | } |
726 | spin_unlock(&dq_state_lock); | 756 | spin_unlock(&dq_state_lock); |
727 | 757 | ||
728 | if ((dquot = find_dquot(hashent, sb, id, type)) == NODQUOT) { | 758 | dquot = find_dquot(hashent, sb, id, type); |
729 | if (empty == NODQUOT) { | 759 | if (!dquot) { |
760 | if (!empty) { | ||
730 | spin_unlock(&dq_list_lock); | 761 | spin_unlock(&dq_list_lock); |
731 | if ((empty = get_empty_dquot(sb, type)) == NODQUOT) | 762 | empty = get_empty_dquot(sb, type); |
763 | if (!empty) | ||
732 | schedule(); /* Try to wait for a moment... */ | 764 | schedule(); /* Try to wait for a moment... */ |
733 | goto we_slept; | 765 | goto we_slept; |
734 | } | 766 | } |
735 | dquot = empty; | 767 | dquot = empty; |
736 | empty = NODQUOT; | 768 | empty = NULL; |
737 | dquot->dq_id = id; | 769 | dquot->dq_id = id; |
738 | /* all dquots go on the inuse_list */ | 770 | /* all dquots go on the inuse_list */ |
739 | put_inuse(dquot); | 771 | put_inuse(dquot); |
@@ -749,13 +781,14 @@ we_slept: | |||
749 | dqstats.lookups++; | 781 | dqstats.lookups++; |
750 | spin_unlock(&dq_list_lock); | 782 | spin_unlock(&dq_list_lock); |
751 | } | 783 | } |
752 | /* Wait for dq_lock - after this we know that either dquot_release() is already | 784 | /* Wait for dq_lock - after this we know that either dquot_release() is |
753 | * finished or it will be canceled due to dq_count > 1 test */ | 785 | * already finished or it will be canceled due to dq_count > 1 test */ |
754 | wait_on_dquot(dquot); | 786 | wait_on_dquot(dquot); |
755 | /* Read the dquot and instantiate it (everything done only if needed) */ | 787 | /* Read the dquot / allocate space in quota file */ |
756 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags) && sb->dq_op->acquire_dquot(dquot) < 0) { | 788 | if (!test_bit(DQ_ACTIVE_B, &dquot->dq_flags) && |
789 | sb->dq_op->acquire_dquot(dquot) < 0) { | ||
757 | dqput(dquot); | 790 | dqput(dquot); |
758 | dquot = NODQUOT; | 791 | dquot = NULL; |
759 | goto out; | 792 | goto out; |
760 | } | 793 | } |
761 | #ifdef __DQUOT_PARANOIA | 794 | #ifdef __DQUOT_PARANOIA |
@@ -767,6 +800,7 @@ out: | |||
767 | 800 | ||
768 | return dquot; | 801 | return dquot; |
769 | } | 802 | } |
803 | EXPORT_SYMBOL(dqget); | ||
770 | 804 | ||
771 | static int dqinit_needed(struct inode *inode, int type) | 805 | static int dqinit_needed(struct inode *inode, int type) |
772 | { | 806 | { |
@@ -775,9 +809,9 @@ static int dqinit_needed(struct inode *inode, int type) | |||
775 | if (IS_NOQUOTA(inode)) | 809 | if (IS_NOQUOTA(inode)) |
776 | return 0; | 810 | return 0; |
777 | if (type != -1) | 811 | if (type != -1) |
778 | return inode->i_dquot[type] == NODQUOT; | 812 | return !inode->i_dquot[type]; |
779 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 813 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
780 | if (inode->i_dquot[cnt] == NODQUOT) | 814 | if (!inode->i_dquot[cnt]) |
781 | return 1; | 815 | return 1; |
782 | return 0; | 816 | return 0; |
783 | } | 817 | } |
@@ -789,12 +823,12 @@ static void add_dquot_ref(struct super_block *sb, int type) | |||
789 | 823 | ||
790 | spin_lock(&inode_lock); | 824 | spin_lock(&inode_lock); |
791 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { | 825 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { |
826 | if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) | ||
827 | continue; | ||
792 | if (!atomic_read(&inode->i_writecount)) | 828 | if (!atomic_read(&inode->i_writecount)) |
793 | continue; | 829 | continue; |
794 | if (!dqinit_needed(inode, type)) | 830 | if (!dqinit_needed(inode, type)) |
795 | continue; | 831 | continue; |
796 | if (inode->i_state & (I_FREEING|I_WILL_FREE)) | ||
797 | continue; | ||
798 | 832 | ||
799 | __iget(inode); | 833 | __iget(inode); |
800 | spin_unlock(&inode_lock); | 834 | spin_unlock(&inode_lock); |
@@ -813,7 +847,10 @@ static void add_dquot_ref(struct super_block *sb, int type) | |||
813 | iput(old_inode); | 847 | iput(old_inode); |
814 | } | 848 | } |
815 | 849 | ||
816 | /* Return 0 if dqput() won't block (note that 1 doesn't necessarily mean blocking) */ | 850 | /* |
851 | * Return 0 if dqput() won't block. | ||
852 | * (note that 1 doesn't necessarily mean blocking) | ||
853 | */ | ||
817 | static inline int dqput_blocks(struct dquot *dquot) | 854 | static inline int dqput_blocks(struct dquot *dquot) |
818 | { | 855 | { |
819 | if (atomic_read(&dquot->dq_count) <= 1) | 856 | if (atomic_read(&dquot->dq_count) <= 1) |
@@ -821,22 +858,27 @@ static inline int dqput_blocks(struct dquot *dquot) | |||
821 | return 0; | 858 | return 0; |
822 | } | 859 | } |
823 | 860 | ||
824 | /* Remove references to dquots from inode - add dquot to list for freeing if needed */ | 861 | /* |
825 | /* We can't race with anybody because we hold dqptr_sem for writing... */ | 862 | * Remove references to dquots from inode and add dquot to list for freeing |
863 | * if we have the last referece to dquot | ||
864 | * We can't race with anybody because we hold dqptr_sem for writing... | ||
865 | */ | ||
826 | static int remove_inode_dquot_ref(struct inode *inode, int type, | 866 | static int remove_inode_dquot_ref(struct inode *inode, int type, |
827 | struct list_head *tofree_head) | 867 | struct list_head *tofree_head) |
828 | { | 868 | { |
829 | struct dquot *dquot = inode->i_dquot[type]; | 869 | struct dquot *dquot = inode->i_dquot[type]; |
830 | 870 | ||
831 | inode->i_dquot[type] = NODQUOT; | 871 | inode->i_dquot[type] = NULL; |
832 | if (dquot != NODQUOT) { | 872 | if (dquot) { |
833 | if (dqput_blocks(dquot)) { | 873 | if (dqput_blocks(dquot)) { |
834 | #ifdef __DQUOT_PARANOIA | 874 | #ifdef __DQUOT_PARANOIA |
835 | if (atomic_read(&dquot->dq_count) != 1) | 875 | if (atomic_read(&dquot->dq_count) != 1) |
836 | printk(KERN_WARNING "VFS: Adding dquot with dq_count %d to dispose list.\n", atomic_read(&dquot->dq_count)); | 876 | printk(KERN_WARNING "VFS: Adding dquot with dq_count %d to dispose list.\n", atomic_read(&dquot->dq_count)); |
837 | #endif | 877 | #endif |
838 | spin_lock(&dq_list_lock); | 878 | spin_lock(&dq_list_lock); |
839 | list_add(&dquot->dq_free, tofree_head); /* As dquot must have currently users it can't be on the free list... */ | 879 | /* As dquot must have currently users it can't be on |
880 | * the free list... */ | ||
881 | list_add(&dquot->dq_free, tofree_head); | ||
840 | spin_unlock(&dq_list_lock); | 882 | spin_unlock(&dq_list_lock); |
841 | return 1; | 883 | return 1; |
842 | } | 884 | } |
@@ -846,19 +888,22 @@ static int remove_inode_dquot_ref(struct inode *inode, int type, | |||
846 | return 0; | 888 | return 0; |
847 | } | 889 | } |
848 | 890 | ||
849 | /* Free list of dquots - called from inode.c */ | 891 | /* |
850 | /* dquots are removed from inodes, no new references can be got so we are the only ones holding reference */ | 892 | * Free list of dquots |
893 | * Dquots are removed from inodes and no new references can be got so we are | ||
894 | * the only ones holding reference | ||
895 | */ | ||
851 | static void put_dquot_list(struct list_head *tofree_head) | 896 | static void put_dquot_list(struct list_head *tofree_head) |
852 | { | 897 | { |
853 | struct list_head *act_head; | 898 | struct list_head *act_head; |
854 | struct dquot *dquot; | 899 | struct dquot *dquot; |
855 | 900 | ||
856 | act_head = tofree_head->next; | 901 | act_head = tofree_head->next; |
857 | /* So now we have dquots on the list... Just free them */ | ||
858 | while (act_head != tofree_head) { | 902 | while (act_head != tofree_head) { |
859 | dquot = list_entry(act_head, struct dquot, dq_free); | 903 | dquot = list_entry(act_head, struct dquot, dq_free); |
860 | act_head = act_head->next; | 904 | act_head = act_head->next; |
861 | list_del_init(&dquot->dq_free); /* Remove dquot from the list so we won't have problems... */ | 905 | /* Remove dquot from the list so we won't have problems... */ |
906 | list_del_init(&dquot->dq_free); | ||
862 | dqput(dquot); | 907 | dqput(dquot); |
863 | } | 908 | } |
864 | } | 909 | } |
@@ -870,6 +915,12 @@ static void remove_dquot_ref(struct super_block *sb, int type, | |||
870 | 915 | ||
871 | spin_lock(&inode_lock); | 916 | spin_lock(&inode_lock); |
872 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { | 917 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { |
918 | /* | ||
919 | * We have to scan also I_NEW inodes because they can already | ||
920 | * have quota pointer initialized. Luckily, we need to touch | ||
921 | * only quota pointers and these have separate locking | ||
922 | * (dqptr_sem). | ||
923 | */ | ||
873 | if (!IS_NOQUOTA(inode)) | 924 | if (!IS_NOQUOTA(inode)) |
874 | remove_inode_dquot_ref(inode, type, tofree_head); | 925 | remove_inode_dquot_ref(inode, type, tofree_head); |
875 | } | 926 | } |
@@ -899,7 +950,29 @@ static inline void dquot_incr_space(struct dquot *dquot, qsize_t number) | |||
899 | dquot->dq_dqb.dqb_curspace += number; | 950 | dquot->dq_dqb.dqb_curspace += number; |
900 | } | 951 | } |
901 | 952 | ||
902 | static inline void dquot_decr_inodes(struct dquot *dquot, qsize_t number) | 953 | static inline void dquot_resv_space(struct dquot *dquot, qsize_t number) |
954 | { | ||
955 | dquot->dq_dqb.dqb_rsvspace += number; | ||
956 | } | ||
957 | |||
958 | /* | ||
959 | * Claim reserved quota space | ||
960 | */ | ||
961 | static void dquot_claim_reserved_space(struct dquot *dquot, | ||
962 | qsize_t number) | ||
963 | { | ||
964 | WARN_ON(dquot->dq_dqb.dqb_rsvspace < number); | ||
965 | dquot->dq_dqb.dqb_curspace += number; | ||
966 | dquot->dq_dqb.dqb_rsvspace -= number; | ||
967 | } | ||
968 | |||
969 | static inline | ||
970 | void dquot_free_reserved_space(struct dquot *dquot, qsize_t number) | ||
971 | { | ||
972 | dquot->dq_dqb.dqb_rsvspace -= number; | ||
973 | } | ||
974 | |||
975 | static void dquot_decr_inodes(struct dquot *dquot, qsize_t number) | ||
903 | { | 976 | { |
904 | if (sb_dqopt(dquot->dq_sb)->flags & DQUOT_NEGATIVE_USAGE || | 977 | if (sb_dqopt(dquot->dq_sb)->flags & DQUOT_NEGATIVE_USAGE || |
905 | dquot->dq_dqb.dqb_curinodes >= number) | 978 | dquot->dq_dqb.dqb_curinodes >= number) |
@@ -911,7 +984,7 @@ static inline void dquot_decr_inodes(struct dquot *dquot, qsize_t number) | |||
911 | clear_bit(DQ_INODES_B, &dquot->dq_flags); | 984 | clear_bit(DQ_INODES_B, &dquot->dq_flags); |
912 | } | 985 | } |
913 | 986 | ||
914 | static inline void dquot_decr_space(struct dquot *dquot, qsize_t number) | 987 | static void dquot_decr_space(struct dquot *dquot, qsize_t number) |
915 | { | 988 | { |
916 | if (sb_dqopt(dquot->dq_sb)->flags & DQUOT_NEGATIVE_USAGE || | 989 | if (sb_dqopt(dquot->dq_sb)->flags & DQUOT_NEGATIVE_USAGE || |
917 | dquot->dq_dqb.dqb_curspace >= number) | 990 | dquot->dq_dqb.dqb_curspace >= number) |
@@ -938,7 +1011,7 @@ static int warning_issued(struct dquot *dquot, const int warntype) | |||
938 | #ifdef CONFIG_PRINT_QUOTA_WARNING | 1011 | #ifdef CONFIG_PRINT_QUOTA_WARNING |
939 | static int flag_print_warnings = 1; | 1012 | static int flag_print_warnings = 1; |
940 | 1013 | ||
941 | static inline int need_print_warning(struct dquot *dquot) | 1014 | static int need_print_warning(struct dquot *dquot) |
942 | { | 1015 | { |
943 | if (!flag_print_warnings) | 1016 | if (!flag_print_warnings) |
944 | return 0; | 1017 | return 0; |
@@ -1057,10 +1130,7 @@ static void send_warning(const struct dquot *dquot, const char warntype) | |||
1057 | goto attr_err_out; | 1130 | goto attr_err_out; |
1058 | genlmsg_end(skb, msg_head); | 1131 | genlmsg_end(skb, msg_head); |
1059 | 1132 | ||
1060 | ret = genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); | 1133 | genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); |
1061 | if (ret < 0 && ret != -ESRCH) | ||
1062 | printk(KERN_ERR | ||
1063 | "VFS: Failed to send notification message: %d\n", ret); | ||
1064 | return; | 1134 | return; |
1065 | attr_err_out: | 1135 | attr_err_out: |
1066 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); | 1136 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); |
@@ -1068,13 +1138,17 @@ err_out: | |||
1068 | kfree_skb(skb); | 1138 | kfree_skb(skb); |
1069 | } | 1139 | } |
1070 | #endif | 1140 | #endif |
1071 | 1141 | /* | |
1072 | static inline void flush_warnings(struct dquot * const *dquots, char *warntype) | 1142 | * Write warnings to the console and send warning messages over netlink. |
1143 | * | ||
1144 | * Note that this function can sleep. | ||
1145 | */ | ||
1146 | static void flush_warnings(struct dquot *const *dquots, char *warntype) | ||
1073 | { | 1147 | { |
1074 | int i; | 1148 | int i; |
1075 | 1149 | ||
1076 | for (i = 0; i < MAXQUOTAS; i++) | 1150 | for (i = 0; i < MAXQUOTAS; i++) |
1077 | if (dquots[i] != NODQUOT && warntype[i] != QUOTA_NL_NOWARN && | 1151 | if (dquots[i] && warntype[i] != QUOTA_NL_NOWARN && |
1078 | !warning_issued(dquots[i], warntype[i])) { | 1152 | !warning_issued(dquots[i], warntype[i])) { |
1079 | #ifdef CONFIG_PRINT_QUOTA_WARNING | 1153 | #ifdef CONFIG_PRINT_QUOTA_WARNING |
1080 | print_warning(dquots[i], warntype[i]); | 1154 | print_warning(dquots[i], warntype[i]); |
@@ -1085,42 +1159,47 @@ static inline void flush_warnings(struct dquot * const *dquots, char *warntype) | |||
1085 | } | 1159 | } |
1086 | } | 1160 | } |
1087 | 1161 | ||
1088 | static inline char ignore_hardlimit(struct dquot *dquot) | 1162 | static int ignore_hardlimit(struct dquot *dquot) |
1089 | { | 1163 | { |
1090 | struct mem_dqinfo *info = &sb_dqopt(dquot->dq_sb)->info[dquot->dq_type]; | 1164 | struct mem_dqinfo *info = &sb_dqopt(dquot->dq_sb)->info[dquot->dq_type]; |
1091 | 1165 | ||
1092 | return capable(CAP_SYS_RESOURCE) && | 1166 | return capable(CAP_SYS_RESOURCE) && |
1093 | (info->dqi_format->qf_fmt_id != QFMT_VFS_OLD || !(info->dqi_flags & V1_DQF_RSQUASH)); | 1167 | (info->dqi_format->qf_fmt_id != QFMT_VFS_OLD || |
1168 | !(info->dqi_flags & V1_DQF_RSQUASH)); | ||
1094 | } | 1169 | } |
1095 | 1170 | ||
1096 | /* needs dq_data_lock */ | 1171 | /* needs dq_data_lock */ |
1097 | static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) | 1172 | static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) |
1098 | { | 1173 | { |
1174 | qsize_t newinodes = dquot->dq_dqb.dqb_curinodes + inodes; | ||
1175 | |||
1099 | *warntype = QUOTA_NL_NOWARN; | 1176 | *warntype = QUOTA_NL_NOWARN; |
1100 | if (!sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type) || | 1177 | if (!sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type) || |
1101 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) | 1178 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) |
1102 | return QUOTA_OK; | 1179 | return QUOTA_OK; |
1103 | 1180 | ||
1104 | if (dquot->dq_dqb.dqb_ihardlimit && | 1181 | if (dquot->dq_dqb.dqb_ihardlimit && |
1105 | (dquot->dq_dqb.dqb_curinodes + inodes) > dquot->dq_dqb.dqb_ihardlimit && | 1182 | newinodes > dquot->dq_dqb.dqb_ihardlimit && |
1106 | !ignore_hardlimit(dquot)) { | 1183 | !ignore_hardlimit(dquot)) { |
1107 | *warntype = QUOTA_NL_IHARDWARN; | 1184 | *warntype = QUOTA_NL_IHARDWARN; |
1108 | return NO_QUOTA; | 1185 | return NO_QUOTA; |
1109 | } | 1186 | } |
1110 | 1187 | ||
1111 | if (dquot->dq_dqb.dqb_isoftlimit && | 1188 | if (dquot->dq_dqb.dqb_isoftlimit && |
1112 | (dquot->dq_dqb.dqb_curinodes + inodes) > dquot->dq_dqb.dqb_isoftlimit && | 1189 | newinodes > dquot->dq_dqb.dqb_isoftlimit && |
1113 | dquot->dq_dqb.dqb_itime && get_seconds() >= dquot->dq_dqb.dqb_itime && | 1190 | dquot->dq_dqb.dqb_itime && |
1191 | get_seconds() >= dquot->dq_dqb.dqb_itime && | ||
1114 | !ignore_hardlimit(dquot)) { | 1192 | !ignore_hardlimit(dquot)) { |
1115 | *warntype = QUOTA_NL_ISOFTLONGWARN; | 1193 | *warntype = QUOTA_NL_ISOFTLONGWARN; |
1116 | return NO_QUOTA; | 1194 | return NO_QUOTA; |
1117 | } | 1195 | } |
1118 | 1196 | ||
1119 | if (dquot->dq_dqb.dqb_isoftlimit && | 1197 | if (dquot->dq_dqb.dqb_isoftlimit && |
1120 | (dquot->dq_dqb.dqb_curinodes + inodes) > dquot->dq_dqb.dqb_isoftlimit && | 1198 | newinodes > dquot->dq_dqb.dqb_isoftlimit && |
1121 | dquot->dq_dqb.dqb_itime == 0) { | 1199 | dquot->dq_dqb.dqb_itime == 0) { |
1122 | *warntype = QUOTA_NL_ISOFTWARN; | 1200 | *warntype = QUOTA_NL_ISOFTWARN; |
1123 | dquot->dq_dqb.dqb_itime = get_seconds() + sb_dqopt(dquot->dq_sb)->info[dquot->dq_type].dqi_igrace; | 1201 | dquot->dq_dqb.dqb_itime = get_seconds() + |
1202 | sb_dqopt(dquot->dq_sb)->info[dquot->dq_type].dqi_igrace; | ||
1124 | } | 1203 | } |
1125 | 1204 | ||
1126 | return QUOTA_OK; | 1205 | return QUOTA_OK; |
@@ -1129,13 +1208,19 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) | |||
1129 | /* needs dq_data_lock */ | 1208 | /* needs dq_data_lock */ |
1130 | static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *warntype) | 1209 | static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *warntype) |
1131 | { | 1210 | { |
1211 | qsize_t tspace; | ||
1212 | struct super_block *sb = dquot->dq_sb; | ||
1213 | |||
1132 | *warntype = QUOTA_NL_NOWARN; | 1214 | *warntype = QUOTA_NL_NOWARN; |
1133 | if (!sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type) || | 1215 | if (!sb_has_quota_limits_enabled(sb, dquot->dq_type) || |
1134 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) | 1216 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) |
1135 | return QUOTA_OK; | 1217 | return QUOTA_OK; |
1136 | 1218 | ||
1219 | tspace = dquot->dq_dqb.dqb_curspace + dquot->dq_dqb.dqb_rsvspace | ||
1220 | + space; | ||
1221 | |||
1137 | if (dquot->dq_dqb.dqb_bhardlimit && | 1222 | if (dquot->dq_dqb.dqb_bhardlimit && |
1138 | dquot->dq_dqb.dqb_curspace + space > dquot->dq_dqb.dqb_bhardlimit && | 1223 | tspace > dquot->dq_dqb.dqb_bhardlimit && |
1139 | !ignore_hardlimit(dquot)) { | 1224 | !ignore_hardlimit(dquot)) { |
1140 | if (!prealloc) | 1225 | if (!prealloc) |
1141 | *warntype = QUOTA_NL_BHARDWARN; | 1226 | *warntype = QUOTA_NL_BHARDWARN; |
@@ -1143,8 +1228,9 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1143 | } | 1228 | } |
1144 | 1229 | ||
1145 | if (dquot->dq_dqb.dqb_bsoftlimit && | 1230 | if (dquot->dq_dqb.dqb_bsoftlimit && |
1146 | dquot->dq_dqb.dqb_curspace + space > dquot->dq_dqb.dqb_bsoftlimit && | 1231 | tspace > dquot->dq_dqb.dqb_bsoftlimit && |
1147 | dquot->dq_dqb.dqb_btime && get_seconds() >= dquot->dq_dqb.dqb_btime && | 1232 | dquot->dq_dqb.dqb_btime && |
1233 | get_seconds() >= dquot->dq_dqb.dqb_btime && | ||
1148 | !ignore_hardlimit(dquot)) { | 1234 | !ignore_hardlimit(dquot)) { |
1149 | if (!prealloc) | 1235 | if (!prealloc) |
1150 | *warntype = QUOTA_NL_BSOFTLONGWARN; | 1236 | *warntype = QUOTA_NL_BSOFTLONGWARN; |
@@ -1152,11 +1238,12 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1152 | } | 1238 | } |
1153 | 1239 | ||
1154 | if (dquot->dq_dqb.dqb_bsoftlimit && | 1240 | if (dquot->dq_dqb.dqb_bsoftlimit && |
1155 | dquot->dq_dqb.dqb_curspace + space > dquot->dq_dqb.dqb_bsoftlimit && | 1241 | tspace > dquot->dq_dqb.dqb_bsoftlimit && |
1156 | dquot->dq_dqb.dqb_btime == 0) { | 1242 | dquot->dq_dqb.dqb_btime == 0) { |
1157 | if (!prealloc) { | 1243 | if (!prealloc) { |
1158 | *warntype = QUOTA_NL_BSOFTWARN; | 1244 | *warntype = QUOTA_NL_BSOFTWARN; |
1159 | dquot->dq_dqb.dqb_btime = get_seconds() + sb_dqopt(dquot->dq_sb)->info[dquot->dq_type].dqi_bgrace; | 1245 | dquot->dq_dqb.dqb_btime = get_seconds() + |
1246 | sb_dqopt(sb)->info[dquot->dq_type].dqi_bgrace; | ||
1160 | } | 1247 | } |
1161 | else | 1248 | else |
1162 | /* | 1249 | /* |
@@ -1171,15 +1258,18 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1171 | 1258 | ||
1172 | static int info_idq_free(struct dquot *dquot, qsize_t inodes) | 1259 | static int info_idq_free(struct dquot *dquot, qsize_t inodes) |
1173 | { | 1260 | { |
1261 | qsize_t newinodes; | ||
1262 | |||
1174 | if (test_bit(DQ_FAKE_B, &dquot->dq_flags) || | 1263 | if (test_bit(DQ_FAKE_B, &dquot->dq_flags) || |
1175 | dquot->dq_dqb.dqb_curinodes <= dquot->dq_dqb.dqb_isoftlimit || | 1264 | dquot->dq_dqb.dqb_curinodes <= dquot->dq_dqb.dqb_isoftlimit || |
1176 | !sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type)) | 1265 | !sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type)) |
1177 | return QUOTA_NL_NOWARN; | 1266 | return QUOTA_NL_NOWARN; |
1178 | 1267 | ||
1179 | if (dquot->dq_dqb.dqb_curinodes - inodes <= dquot->dq_dqb.dqb_isoftlimit) | 1268 | newinodes = dquot->dq_dqb.dqb_curinodes - inodes; |
1269 | if (newinodes <= dquot->dq_dqb.dqb_isoftlimit) | ||
1180 | return QUOTA_NL_ISOFTBELOW; | 1270 | return QUOTA_NL_ISOFTBELOW; |
1181 | if (dquot->dq_dqb.dqb_curinodes >= dquot->dq_dqb.dqb_ihardlimit && | 1271 | if (dquot->dq_dqb.dqb_curinodes >= dquot->dq_dqb.dqb_ihardlimit && |
1182 | dquot->dq_dqb.dqb_curinodes - inodes < dquot->dq_dqb.dqb_ihardlimit) | 1272 | newinodes < dquot->dq_dqb.dqb_ihardlimit) |
1183 | return QUOTA_NL_IHARDBELOW; | 1273 | return QUOTA_NL_IHARDBELOW; |
1184 | return QUOTA_NL_NOWARN; | 1274 | return QUOTA_NL_NOWARN; |
1185 | } | 1275 | } |
@@ -1206,7 +1296,7 @@ int dquot_initialize(struct inode *inode, int type) | |||
1206 | { | 1296 | { |
1207 | unsigned int id = 0; | 1297 | unsigned int id = 0; |
1208 | int cnt, ret = 0; | 1298 | int cnt, ret = 0; |
1209 | struct dquot *got[MAXQUOTAS] = { NODQUOT, NODQUOT }; | 1299 | struct dquot *got[MAXQUOTAS] = { NULL, NULL }; |
1210 | struct super_block *sb = inode->i_sb; | 1300 | struct super_block *sb = inode->i_sb; |
1211 | 1301 | ||
1212 | /* First test before acquiring mutex - solves deadlocks when we | 1302 | /* First test before acquiring mutex - solves deadlocks when we |
@@ -1239,9 +1329,9 @@ int dquot_initialize(struct inode *inode, int type) | |||
1239 | /* Avoid races with quotaoff() */ | 1329 | /* Avoid races with quotaoff() */ |
1240 | if (!sb_has_quota_active(sb, cnt)) | 1330 | if (!sb_has_quota_active(sb, cnt)) |
1241 | continue; | 1331 | continue; |
1242 | if (inode->i_dquot[cnt] == NODQUOT) { | 1332 | if (!inode->i_dquot[cnt]) { |
1243 | inode->i_dquot[cnt] = got[cnt]; | 1333 | inode->i_dquot[cnt] = got[cnt]; |
1244 | got[cnt] = NODQUOT; | 1334 | got[cnt] = NULL; |
1245 | } | 1335 | } |
1246 | } | 1336 | } |
1247 | out_err: | 1337 | out_err: |
@@ -1251,6 +1341,7 @@ out_err: | |||
1251 | dqput(got[cnt]); | 1341 | dqput(got[cnt]); |
1252 | return ret; | 1342 | return ret; |
1253 | } | 1343 | } |
1344 | EXPORT_SYMBOL(dquot_initialize); | ||
1254 | 1345 | ||
1255 | /* | 1346 | /* |
1256 | * Release all quotas referenced by inode | 1347 | * Release all quotas referenced by inode |
@@ -1263,7 +1354,7 @@ int dquot_drop(struct inode *inode) | |||
1263 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1354 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1264 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1355 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1265 | put[cnt] = inode->i_dquot[cnt]; | 1356 | put[cnt] = inode->i_dquot[cnt]; |
1266 | inode->i_dquot[cnt] = NODQUOT; | 1357 | inode->i_dquot[cnt] = NULL; |
1267 | } | 1358 | } |
1268 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1359 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1269 | 1360 | ||
@@ -1271,6 +1362,7 @@ int dquot_drop(struct inode *inode) | |||
1271 | dqput(put[cnt]); | 1362 | dqput(put[cnt]); |
1272 | return 0; | 1363 | return 0; |
1273 | } | 1364 | } |
1365 | EXPORT_SYMBOL(dquot_drop); | ||
1274 | 1366 | ||
1275 | /* Wrapper to remove references to quota structures from inode */ | 1367 | /* Wrapper to remove references to quota structures from inode */ |
1276 | void vfs_dq_drop(struct inode *inode) | 1368 | void vfs_dq_drop(struct inode *inode) |
@@ -1287,12 +1379,13 @@ void vfs_dq_drop(struct inode *inode) | |||
1287 | * must assure that nobody can come after the DQUOT_DROP and | 1379 | * must assure that nobody can come after the DQUOT_DROP and |
1288 | * add quota pointers back anyway */ | 1380 | * add quota pointers back anyway */ |
1289 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1381 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1290 | if (inode->i_dquot[cnt] != NODQUOT) | 1382 | if (inode->i_dquot[cnt]) |
1291 | break; | 1383 | break; |
1292 | if (cnt < MAXQUOTAS) | 1384 | if (cnt < MAXQUOTAS) |
1293 | inode->i_sb->dq_op->drop(inode); | 1385 | inode->i_sb->dq_op->drop(inode); |
1294 | } | 1386 | } |
1295 | } | 1387 | } |
1388 | EXPORT_SYMBOL(vfs_dq_drop); | ||
1296 | 1389 | ||
1297 | /* | 1390 | /* |
1298 | * Following four functions update i_blocks+i_bytes fields and | 1391 | * Following four functions update i_blocks+i_bytes fields and |
@@ -1306,51 +1399,93 @@ void vfs_dq_drop(struct inode *inode) | |||
1306 | /* | 1399 | /* |
1307 | * This operation can block, but only after everything is updated | 1400 | * This operation can block, but only after everything is updated |
1308 | */ | 1401 | */ |
1309 | int dquot_alloc_space(struct inode *inode, qsize_t number, int warn) | 1402 | int __dquot_alloc_space(struct inode *inode, qsize_t number, |
1403 | int warn, int reserve) | ||
1310 | { | 1404 | { |
1311 | int cnt, ret = NO_QUOTA; | 1405 | int cnt, ret = QUOTA_OK; |
1312 | char warntype[MAXQUOTAS]; | 1406 | char warntype[MAXQUOTAS]; |
1313 | 1407 | ||
1314 | /* First test before acquiring mutex - solves deadlocks when we | ||
1315 | * re-enter the quota code and are already holding the mutex */ | ||
1316 | if (IS_NOQUOTA(inode)) { | ||
1317 | out_add: | ||
1318 | inode_add_bytes(inode, number); | ||
1319 | return QUOTA_OK; | ||
1320 | } | ||
1321 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1408 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1322 | warntype[cnt] = QUOTA_NL_NOWARN; | 1409 | warntype[cnt] = QUOTA_NL_NOWARN; |
1323 | 1410 | ||
1324 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1325 | if (IS_NOQUOTA(inode)) { /* Now we can do reliable test... */ | ||
1326 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1327 | goto out_add; | ||
1328 | } | ||
1329 | spin_lock(&dq_data_lock); | 1411 | spin_lock(&dq_data_lock); |
1330 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1412 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1331 | if (inode->i_dquot[cnt] == NODQUOT) | 1413 | if (!inode->i_dquot[cnt]) |
1332 | continue; | 1414 | continue; |
1333 | if (check_bdq(inode->i_dquot[cnt], number, warn, warntype+cnt) == NO_QUOTA) | 1415 | if (check_bdq(inode->i_dquot[cnt], number, warn, warntype+cnt) |
1334 | goto warn_put_all; | 1416 | == NO_QUOTA) { |
1417 | ret = NO_QUOTA; | ||
1418 | goto out_unlock; | ||
1419 | } | ||
1335 | } | 1420 | } |
1336 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1421 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1337 | if (inode->i_dquot[cnt] == NODQUOT) | 1422 | if (!inode->i_dquot[cnt]) |
1338 | continue; | 1423 | continue; |
1339 | dquot_incr_space(inode->i_dquot[cnt], number); | 1424 | if (reserve) |
1425 | dquot_resv_space(inode->i_dquot[cnt], number); | ||
1426 | else | ||
1427 | dquot_incr_space(inode->i_dquot[cnt], number); | ||
1340 | } | 1428 | } |
1341 | inode_add_bytes(inode, number); | 1429 | if (!reserve) |
1342 | ret = QUOTA_OK; | 1430 | inode_add_bytes(inode, number); |
1343 | warn_put_all: | 1431 | out_unlock: |
1344 | spin_unlock(&dq_data_lock); | 1432 | spin_unlock(&dq_data_lock); |
1345 | if (ret == QUOTA_OK) | ||
1346 | /* Dirtify all the dquots - this can block when journalling */ | ||
1347 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | ||
1348 | if (inode->i_dquot[cnt]) | ||
1349 | mark_dquot_dirty(inode->i_dquot[cnt]); | ||
1350 | flush_warnings(inode->i_dquot, warntype); | 1433 | flush_warnings(inode->i_dquot, warntype); |
1434 | return ret; | ||
1435 | } | ||
1436 | |||
1437 | int dquot_alloc_space(struct inode *inode, qsize_t number, int warn) | ||
1438 | { | ||
1439 | int cnt, ret = QUOTA_OK; | ||
1440 | |||
1441 | /* | ||
1442 | * First test before acquiring mutex - solves deadlocks when we | ||
1443 | * re-enter the quota code and are already holding the mutex | ||
1444 | */ | ||
1445 | if (IS_NOQUOTA(inode)) { | ||
1446 | inode_add_bytes(inode, number); | ||
1447 | goto out; | ||
1448 | } | ||
1449 | |||
1450 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1451 | if (IS_NOQUOTA(inode)) { | ||
1452 | inode_add_bytes(inode, number); | ||
1453 | goto out_unlock; | ||
1454 | } | ||
1455 | |||
1456 | ret = __dquot_alloc_space(inode, number, warn, 0); | ||
1457 | if (ret == NO_QUOTA) | ||
1458 | goto out_unlock; | ||
1459 | |||
1460 | /* Dirtify all the dquots - this can block when journalling */ | ||
1461 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | ||
1462 | if (inode->i_dquot[cnt]) | ||
1463 | mark_dquot_dirty(inode->i_dquot[cnt]); | ||
1464 | out_unlock: | ||
1351 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1465 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1466 | out: | ||
1352 | return ret; | 1467 | return ret; |
1353 | } | 1468 | } |
1469 | EXPORT_SYMBOL(dquot_alloc_space); | ||
1470 | |||
1471 | int dquot_reserve_space(struct inode *inode, qsize_t number, int warn) | ||
1472 | { | ||
1473 | int ret = QUOTA_OK; | ||
1474 | |||
1475 | if (IS_NOQUOTA(inode)) | ||
1476 | goto out; | ||
1477 | |||
1478 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1479 | if (IS_NOQUOTA(inode)) | ||
1480 | goto out_unlock; | ||
1481 | |||
1482 | ret = __dquot_alloc_space(inode, number, warn, 1); | ||
1483 | out_unlock: | ||
1484 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1485 | out: | ||
1486 | return ret; | ||
1487 | } | ||
1488 | EXPORT_SYMBOL(dquot_reserve_space); | ||
1354 | 1489 | ||
1355 | /* | 1490 | /* |
1356 | * This operation can block, but only after everything is updated | 1491 | * This operation can block, but only after everything is updated |
@@ -1373,14 +1508,15 @@ int dquot_alloc_inode(const struct inode *inode, qsize_t number) | |||
1373 | } | 1508 | } |
1374 | spin_lock(&dq_data_lock); | 1509 | spin_lock(&dq_data_lock); |
1375 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1510 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1376 | if (inode->i_dquot[cnt] == NODQUOT) | 1511 | if (!inode->i_dquot[cnt]) |
1377 | continue; | 1512 | continue; |
1378 | if (check_idq(inode->i_dquot[cnt], number, warntype+cnt) == NO_QUOTA) | 1513 | if (check_idq(inode->i_dquot[cnt], number, warntype+cnt) |
1514 | == NO_QUOTA) | ||
1379 | goto warn_put_all; | 1515 | goto warn_put_all; |
1380 | } | 1516 | } |
1381 | 1517 | ||
1382 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1518 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1383 | if (inode->i_dquot[cnt] == NODQUOT) | 1519 | if (!inode->i_dquot[cnt]) |
1384 | continue; | 1520 | continue; |
1385 | dquot_incr_inodes(inode->i_dquot[cnt], number); | 1521 | dquot_incr_inodes(inode->i_dquot[cnt], number); |
1386 | } | 1522 | } |
@@ -1396,6 +1532,73 @@ warn_put_all: | |||
1396 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1532 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1397 | return ret; | 1533 | return ret; |
1398 | } | 1534 | } |
1535 | EXPORT_SYMBOL(dquot_alloc_inode); | ||
1536 | |||
1537 | int dquot_claim_space(struct inode *inode, qsize_t number) | ||
1538 | { | ||
1539 | int cnt; | ||
1540 | int ret = QUOTA_OK; | ||
1541 | |||
1542 | if (IS_NOQUOTA(inode)) { | ||
1543 | inode_add_bytes(inode, number); | ||
1544 | goto out; | ||
1545 | } | ||
1546 | |||
1547 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1548 | if (IS_NOQUOTA(inode)) { | ||
1549 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1550 | inode_add_bytes(inode, number); | ||
1551 | goto out; | ||
1552 | } | ||
1553 | |||
1554 | spin_lock(&dq_data_lock); | ||
1555 | /* Claim reserved quotas to allocated quotas */ | ||
1556 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | ||
1557 | if (inode->i_dquot[cnt]) | ||
1558 | dquot_claim_reserved_space(inode->i_dquot[cnt], | ||
1559 | number); | ||
1560 | } | ||
1561 | /* Update inode bytes */ | ||
1562 | inode_add_bytes(inode, number); | ||
1563 | spin_unlock(&dq_data_lock); | ||
1564 | /* Dirtify all the dquots - this can block when journalling */ | ||
1565 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | ||
1566 | if (inode->i_dquot[cnt]) | ||
1567 | mark_dquot_dirty(inode->i_dquot[cnt]); | ||
1568 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1569 | out: | ||
1570 | return ret; | ||
1571 | } | ||
1572 | EXPORT_SYMBOL(dquot_claim_space); | ||
1573 | |||
1574 | /* | ||
1575 | * Release reserved quota space | ||
1576 | */ | ||
1577 | void dquot_release_reserved_space(struct inode *inode, qsize_t number) | ||
1578 | { | ||
1579 | int cnt; | ||
1580 | |||
1581 | if (IS_NOQUOTA(inode)) | ||
1582 | goto out; | ||
1583 | |||
1584 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1585 | if (IS_NOQUOTA(inode)) | ||
1586 | goto out_unlock; | ||
1587 | |||
1588 | spin_lock(&dq_data_lock); | ||
1589 | /* Release reserved dquots */ | ||
1590 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | ||
1591 | if (inode->i_dquot[cnt]) | ||
1592 | dquot_free_reserved_space(inode->i_dquot[cnt], number); | ||
1593 | } | ||
1594 | spin_unlock(&dq_data_lock); | ||
1595 | |||
1596 | out_unlock: | ||
1597 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1598 | out: | ||
1599 | return; | ||
1600 | } | ||
1601 | EXPORT_SYMBOL(dquot_release_reserved_space); | ||
1399 | 1602 | ||
1400 | /* | 1603 | /* |
1401 | * This operation can block, but only after everything is updated | 1604 | * This operation can block, but only after everything is updated |
@@ -1421,7 +1624,7 @@ out_sub: | |||
1421 | } | 1624 | } |
1422 | spin_lock(&dq_data_lock); | 1625 | spin_lock(&dq_data_lock); |
1423 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1626 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1424 | if (inode->i_dquot[cnt] == NODQUOT) | 1627 | if (!inode->i_dquot[cnt]) |
1425 | continue; | 1628 | continue; |
1426 | warntype[cnt] = info_bdq_free(inode->i_dquot[cnt], number); | 1629 | warntype[cnt] = info_bdq_free(inode->i_dquot[cnt], number); |
1427 | dquot_decr_space(inode->i_dquot[cnt], number); | 1630 | dquot_decr_space(inode->i_dquot[cnt], number); |
@@ -1436,6 +1639,7 @@ out_sub: | |||
1436 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1639 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1437 | return QUOTA_OK; | 1640 | return QUOTA_OK; |
1438 | } | 1641 | } |
1642 | EXPORT_SYMBOL(dquot_free_space); | ||
1439 | 1643 | ||
1440 | /* | 1644 | /* |
1441 | * This operation can block, but only after everything is updated | 1645 | * This operation can block, but only after everything is updated |
@@ -1458,7 +1662,7 @@ int dquot_free_inode(const struct inode *inode, qsize_t number) | |||
1458 | } | 1662 | } |
1459 | spin_lock(&dq_data_lock); | 1663 | spin_lock(&dq_data_lock); |
1460 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1664 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1461 | if (inode->i_dquot[cnt] == NODQUOT) | 1665 | if (!inode->i_dquot[cnt]) |
1462 | continue; | 1666 | continue; |
1463 | warntype[cnt] = info_idq_free(inode->i_dquot[cnt], number); | 1667 | warntype[cnt] = info_idq_free(inode->i_dquot[cnt], number); |
1464 | dquot_decr_inodes(inode->i_dquot[cnt], number); | 1668 | dquot_decr_inodes(inode->i_dquot[cnt], number); |
@@ -1472,6 +1676,20 @@ int dquot_free_inode(const struct inode *inode, qsize_t number) | |||
1472 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1676 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1473 | return QUOTA_OK; | 1677 | return QUOTA_OK; |
1474 | } | 1678 | } |
1679 | EXPORT_SYMBOL(dquot_free_inode); | ||
1680 | |||
1681 | /* | ||
1682 | * call back function, get reserved quota space from underlying fs | ||
1683 | */ | ||
1684 | qsize_t dquot_get_reserved_space(struct inode *inode) | ||
1685 | { | ||
1686 | qsize_t reserved_space = 0; | ||
1687 | |||
1688 | if (sb_any_quota_active(inode->i_sb) && | ||
1689 | inode->i_sb->dq_op->get_reserved_space) | ||
1690 | reserved_space = inode->i_sb->dq_op->get_reserved_space(inode); | ||
1691 | return reserved_space; | ||
1692 | } | ||
1475 | 1693 | ||
1476 | /* | 1694 | /* |
1477 | * Transfer the number of inode and blocks from one diskquota to an other. | 1695 | * Transfer the number of inode and blocks from one diskquota to an other. |
@@ -1481,7 +1699,8 @@ int dquot_free_inode(const struct inode *inode, qsize_t number) | |||
1481 | */ | 1699 | */ |
1482 | int dquot_transfer(struct inode *inode, struct iattr *iattr) | 1700 | int dquot_transfer(struct inode *inode, struct iattr *iattr) |
1483 | { | 1701 | { |
1484 | qsize_t space; | 1702 | qsize_t space, cur_space; |
1703 | qsize_t rsv_space = 0; | ||
1485 | struct dquot *transfer_from[MAXQUOTAS]; | 1704 | struct dquot *transfer_from[MAXQUOTAS]; |
1486 | struct dquot *transfer_to[MAXQUOTAS]; | 1705 | struct dquot *transfer_to[MAXQUOTAS]; |
1487 | int cnt, ret = QUOTA_OK; | 1706 | int cnt, ret = QUOTA_OK; |
@@ -1496,22 +1715,16 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1496 | return QUOTA_OK; | 1715 | return QUOTA_OK; |
1497 | /* Initialize the arrays */ | 1716 | /* Initialize the arrays */ |
1498 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1717 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1499 | transfer_from[cnt] = NODQUOT; | 1718 | transfer_from[cnt] = NULL; |
1500 | transfer_to[cnt] = NODQUOT; | 1719 | transfer_to[cnt] = NULL; |
1501 | warntype_to[cnt] = QUOTA_NL_NOWARN; | 1720 | warntype_to[cnt] = QUOTA_NL_NOWARN; |
1502 | switch (cnt) { | ||
1503 | case USRQUOTA: | ||
1504 | if (!chuid) | ||
1505 | continue; | ||
1506 | transfer_to[cnt] = dqget(inode->i_sb, iattr->ia_uid, cnt); | ||
1507 | break; | ||
1508 | case GRPQUOTA: | ||
1509 | if (!chgid) | ||
1510 | continue; | ||
1511 | transfer_to[cnt] = dqget(inode->i_sb, iattr->ia_gid, cnt); | ||
1512 | break; | ||
1513 | } | ||
1514 | } | 1721 | } |
1722 | if (chuid) | ||
1723 | transfer_to[USRQUOTA] = dqget(inode->i_sb, iattr->ia_uid, | ||
1724 | USRQUOTA); | ||
1725 | if (chgid) | ||
1726 | transfer_to[GRPQUOTA] = dqget(inode->i_sb, iattr->ia_gid, | ||
1727 | GRPQUOTA); | ||
1515 | 1728 | ||
1516 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1729 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1517 | /* Now recheck reliably when holding dqptr_sem */ | 1730 | /* Now recheck reliably when holding dqptr_sem */ |
@@ -1520,10 +1733,12 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1520 | goto put_all; | 1733 | goto put_all; |
1521 | } | 1734 | } |
1522 | spin_lock(&dq_data_lock); | 1735 | spin_lock(&dq_data_lock); |
1523 | space = inode_get_bytes(inode); | 1736 | cur_space = inode_get_bytes(inode); |
1737 | rsv_space = dquot_get_reserved_space(inode); | ||
1738 | space = cur_space + rsv_space; | ||
1524 | /* Build the transfer_from list and check the limits */ | 1739 | /* Build the transfer_from list and check the limits */ |
1525 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1740 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1526 | if (transfer_to[cnt] == NODQUOT) | 1741 | if (!transfer_to[cnt]) |
1527 | continue; | 1742 | continue; |
1528 | transfer_from[cnt] = inode->i_dquot[cnt]; | 1743 | transfer_from[cnt] = inode->i_dquot[cnt]; |
1529 | if (check_idq(transfer_to[cnt], 1, warntype_to + cnt) == | 1744 | if (check_idq(transfer_to[cnt], 1, warntype_to + cnt) == |
@@ -1539,7 +1754,7 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1539 | /* | 1754 | /* |
1540 | * Skip changes for same uid or gid or for turned off quota-type. | 1755 | * Skip changes for same uid or gid or for turned off quota-type. |
1541 | */ | 1756 | */ |
1542 | if (transfer_to[cnt] == NODQUOT) | 1757 | if (!transfer_to[cnt]) |
1543 | continue; | 1758 | continue; |
1544 | 1759 | ||
1545 | /* Due to IO error we might not have transfer_from[] structure */ | 1760 | /* Due to IO error we might not have transfer_from[] structure */ |
@@ -1549,11 +1764,14 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1549 | warntype_from_space[cnt] = | 1764 | warntype_from_space[cnt] = |
1550 | info_bdq_free(transfer_from[cnt], space); | 1765 | info_bdq_free(transfer_from[cnt], space); |
1551 | dquot_decr_inodes(transfer_from[cnt], 1); | 1766 | dquot_decr_inodes(transfer_from[cnt], 1); |
1552 | dquot_decr_space(transfer_from[cnt], space); | 1767 | dquot_decr_space(transfer_from[cnt], cur_space); |
1768 | dquot_free_reserved_space(transfer_from[cnt], | ||
1769 | rsv_space); | ||
1553 | } | 1770 | } |
1554 | 1771 | ||
1555 | dquot_incr_inodes(transfer_to[cnt], 1); | 1772 | dquot_incr_inodes(transfer_to[cnt], 1); |
1556 | dquot_incr_space(transfer_to[cnt], space); | 1773 | dquot_incr_space(transfer_to[cnt], cur_space); |
1774 | dquot_resv_space(transfer_to[cnt], rsv_space); | ||
1557 | 1775 | ||
1558 | inode->i_dquot[cnt] = transfer_to[cnt]; | 1776 | inode->i_dquot[cnt] = transfer_to[cnt]; |
1559 | } | 1777 | } |
@@ -1567,7 +1785,7 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1567 | if (transfer_to[cnt]) { | 1785 | if (transfer_to[cnt]) { |
1568 | mark_dquot_dirty(transfer_to[cnt]); | 1786 | mark_dquot_dirty(transfer_to[cnt]); |
1569 | /* The reference we got is transferred to the inode */ | 1787 | /* The reference we got is transferred to the inode */ |
1570 | transfer_to[cnt] = NODQUOT; | 1788 | transfer_to[cnt] = NULL; |
1571 | } | 1789 | } |
1572 | } | 1790 | } |
1573 | warn_put_all: | 1791 | warn_put_all: |
@@ -1585,10 +1803,11 @@ over_quota: | |||
1585 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1803 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1586 | /* Clear dquot pointers we don't want to dqput() */ | 1804 | /* Clear dquot pointers we don't want to dqput() */ |
1587 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1805 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1588 | transfer_from[cnt] = NODQUOT; | 1806 | transfer_from[cnt] = NULL; |
1589 | ret = NO_QUOTA; | 1807 | ret = NO_QUOTA; |
1590 | goto warn_put_all; | 1808 | goto warn_put_all; |
1591 | } | 1809 | } |
1810 | EXPORT_SYMBOL(dquot_transfer); | ||
1592 | 1811 | ||
1593 | /* Wrapper for transferring ownership of an inode */ | 1812 | /* Wrapper for transferring ownership of an inode */ |
1594 | int vfs_dq_transfer(struct inode *inode, struct iattr *iattr) | 1813 | int vfs_dq_transfer(struct inode *inode, struct iattr *iattr) |
@@ -1600,7 +1819,7 @@ int vfs_dq_transfer(struct inode *inode, struct iattr *iattr) | |||
1600 | } | 1819 | } |
1601 | return 0; | 1820 | return 0; |
1602 | } | 1821 | } |
1603 | 1822 | EXPORT_SYMBOL(vfs_dq_transfer); | |
1604 | 1823 | ||
1605 | /* | 1824 | /* |
1606 | * Write info of quota file to disk | 1825 | * Write info of quota file to disk |
@@ -1615,6 +1834,7 @@ int dquot_commit_info(struct super_block *sb, int type) | |||
1615 | mutex_unlock(&dqopt->dqio_mutex); | 1834 | mutex_unlock(&dqopt->dqio_mutex); |
1616 | return ret; | 1835 | return ret; |
1617 | } | 1836 | } |
1837 | EXPORT_SYMBOL(dquot_commit_info); | ||
1618 | 1838 | ||
1619 | /* | 1839 | /* |
1620 | * Definitions of diskquota operations. | 1840 | * Definitions of diskquota operations. |
@@ -1700,8 +1920,8 @@ int vfs_quota_disable(struct super_block *sb, int type, unsigned int flags) | |||
1700 | drop_dquot_ref(sb, cnt); | 1920 | drop_dquot_ref(sb, cnt); |
1701 | invalidate_dquots(sb, cnt); | 1921 | invalidate_dquots(sb, cnt); |
1702 | /* | 1922 | /* |
1703 | * Now all dquots should be invalidated, all writes done so we should be only | 1923 | * Now all dquots should be invalidated, all writes done so we |
1704 | * users of the info. No locks needed. | 1924 | * should be only users of the info. No locks needed. |
1705 | */ | 1925 | */ |
1706 | if (info_dirty(&dqopt->info[cnt])) | 1926 | if (info_dirty(&dqopt->info[cnt])) |
1707 | sb->dq_op->write_info(sb, cnt); | 1927 | sb->dq_op->write_info(sb, cnt); |
@@ -1739,10 +1959,12 @@ int vfs_quota_disable(struct super_block *sb, int type, unsigned int flags) | |||
1739 | /* If quota was reenabled in the meantime, we have | 1959 | /* If quota was reenabled in the meantime, we have |
1740 | * nothing to do */ | 1960 | * nothing to do */ |
1741 | if (!sb_has_quota_loaded(sb, cnt)) { | 1961 | if (!sb_has_quota_loaded(sb, cnt)) { |
1742 | mutex_lock_nested(&toputinode[cnt]->i_mutex, I_MUTEX_QUOTA); | 1962 | mutex_lock_nested(&toputinode[cnt]->i_mutex, |
1963 | I_MUTEX_QUOTA); | ||
1743 | toputinode[cnt]->i_flags &= ~(S_IMMUTABLE | | 1964 | toputinode[cnt]->i_flags &= ~(S_IMMUTABLE | |
1744 | S_NOATIME | S_NOQUOTA); | 1965 | S_NOATIME | S_NOQUOTA); |
1745 | truncate_inode_pages(&toputinode[cnt]->i_data, 0); | 1966 | truncate_inode_pages(&toputinode[cnt]->i_data, |
1967 | 0); | ||
1746 | mutex_unlock(&toputinode[cnt]->i_mutex); | 1968 | mutex_unlock(&toputinode[cnt]->i_mutex); |
1747 | mark_inode_dirty(toputinode[cnt]); | 1969 | mark_inode_dirty(toputinode[cnt]); |
1748 | } | 1970 | } |
@@ -1767,13 +1989,14 @@ put_inodes: | |||
1767 | } | 1989 | } |
1768 | return ret; | 1990 | return ret; |
1769 | } | 1991 | } |
1992 | EXPORT_SYMBOL(vfs_quota_disable); | ||
1770 | 1993 | ||
1771 | int vfs_quota_off(struct super_block *sb, int type, int remount) | 1994 | int vfs_quota_off(struct super_block *sb, int type, int remount) |
1772 | { | 1995 | { |
1773 | return vfs_quota_disable(sb, type, remount ? DQUOT_SUSPENDED : | 1996 | return vfs_quota_disable(sb, type, remount ? DQUOT_SUSPENDED : |
1774 | (DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED)); | 1997 | (DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED)); |
1775 | } | 1998 | } |
1776 | 1999 | EXPORT_SYMBOL(vfs_quota_off); | |
1777 | /* | 2000 | /* |
1778 | * Turn quotas on on a device | 2001 | * Turn quotas on on a device |
1779 | */ | 2002 | */ |
@@ -1831,7 +2054,8 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id, | |||
1831 | * possible) Also nobody should write to the file - we use | 2054 | * possible) Also nobody should write to the file - we use |
1832 | * special IO operations which ignore the immutable bit. */ | 2055 | * special IO operations which ignore the immutable bit. */ |
1833 | down_write(&dqopt->dqptr_sem); | 2056 | down_write(&dqopt->dqptr_sem); |
1834 | oldflags = inode->i_flags & (S_NOATIME | S_IMMUTABLE | S_NOQUOTA); | 2057 | oldflags = inode->i_flags & (S_NOATIME | S_IMMUTABLE | |
2058 | S_NOQUOTA); | ||
1835 | inode->i_flags |= S_NOQUOTA | S_NOATIME | S_IMMUTABLE; | 2059 | inode->i_flags |= S_NOQUOTA | S_NOATIME | S_IMMUTABLE; |
1836 | up_write(&dqopt->dqptr_sem); | 2060 | up_write(&dqopt->dqptr_sem); |
1837 | sb->dq_op->drop(inode); | 2061 | sb->dq_op->drop(inode); |
@@ -1850,7 +2074,8 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id, | |||
1850 | dqopt->info[type].dqi_fmt_id = format_id; | 2074 | dqopt->info[type].dqi_fmt_id = format_id; |
1851 | INIT_LIST_HEAD(&dqopt->info[type].dqi_dirty_list); | 2075 | INIT_LIST_HEAD(&dqopt->info[type].dqi_dirty_list); |
1852 | mutex_lock(&dqopt->dqio_mutex); | 2076 | mutex_lock(&dqopt->dqio_mutex); |
1853 | if ((error = dqopt->ops[type]->read_file_info(sb, type)) < 0) { | 2077 | error = dqopt->ops[type]->read_file_info(sb, type); |
2078 | if (error < 0) { | ||
1854 | mutex_unlock(&dqopt->dqio_mutex); | 2079 | mutex_unlock(&dqopt->dqio_mutex); |
1855 | goto out_file_init; | 2080 | goto out_file_init; |
1856 | } | 2081 | } |
@@ -1930,6 +2155,7 @@ int vfs_quota_on_path(struct super_block *sb, int type, int format_id, | |||
1930 | DQUOT_LIMITS_ENABLED); | 2155 | DQUOT_LIMITS_ENABLED); |
1931 | return error; | 2156 | return error; |
1932 | } | 2157 | } |
2158 | EXPORT_SYMBOL(vfs_quota_on_path); | ||
1933 | 2159 | ||
1934 | int vfs_quota_on(struct super_block *sb, int type, int format_id, char *name, | 2160 | int vfs_quota_on(struct super_block *sb, int type, int format_id, char *name, |
1935 | int remount) | 2161 | int remount) |
@@ -1947,6 +2173,7 @@ int vfs_quota_on(struct super_block *sb, int type, int format_id, char *name, | |||
1947 | } | 2173 | } |
1948 | return error; | 2174 | return error; |
1949 | } | 2175 | } |
2176 | EXPORT_SYMBOL(vfs_quota_on); | ||
1950 | 2177 | ||
1951 | /* | 2178 | /* |
1952 | * More powerful function for turning on quotas allowing setting | 2179 | * More powerful function for turning on quotas allowing setting |
@@ -1993,6 +2220,7 @@ out_lock: | |||
1993 | load_quota: | 2220 | load_quota: |
1994 | return vfs_load_quota_inode(inode, type, format_id, flags); | 2221 | return vfs_load_quota_inode(inode, type, format_id, flags); |
1995 | } | 2222 | } |
2223 | EXPORT_SYMBOL(vfs_quota_enable); | ||
1996 | 2224 | ||
1997 | /* | 2225 | /* |
1998 | * This function is used when filesystem needs to initialize quotas | 2226 | * This function is used when filesystem needs to initialize quotas |
@@ -2022,6 +2250,7 @@ out: | |||
2022 | dput(dentry); | 2250 | dput(dentry); |
2023 | return error; | 2251 | return error; |
2024 | } | 2252 | } |
2253 | EXPORT_SYMBOL(vfs_quota_on_mount); | ||
2025 | 2254 | ||
2026 | /* Wrapper to turn on quotas when remounting rw */ | 2255 | /* Wrapper to turn on quotas when remounting rw */ |
2027 | int vfs_dq_quota_on_remount(struct super_block *sb) | 2256 | int vfs_dq_quota_on_remount(struct super_block *sb) |
@@ -2038,6 +2267,7 @@ int vfs_dq_quota_on_remount(struct super_block *sb) | |||
2038 | } | 2267 | } |
2039 | return ret; | 2268 | return ret; |
2040 | } | 2269 | } |
2270 | EXPORT_SYMBOL(vfs_dq_quota_on_remount); | ||
2041 | 2271 | ||
2042 | static inline qsize_t qbtos(qsize_t blocks) | 2272 | static inline qsize_t qbtos(qsize_t blocks) |
2043 | { | 2273 | { |
@@ -2057,7 +2287,7 @@ static void do_get_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2057 | spin_lock(&dq_data_lock); | 2287 | spin_lock(&dq_data_lock); |
2058 | di->dqb_bhardlimit = stoqb(dm->dqb_bhardlimit); | 2288 | di->dqb_bhardlimit = stoqb(dm->dqb_bhardlimit); |
2059 | di->dqb_bsoftlimit = stoqb(dm->dqb_bsoftlimit); | 2289 | di->dqb_bsoftlimit = stoqb(dm->dqb_bsoftlimit); |
2060 | di->dqb_curspace = dm->dqb_curspace; | 2290 | di->dqb_curspace = dm->dqb_curspace + dm->dqb_rsvspace; |
2061 | di->dqb_ihardlimit = dm->dqb_ihardlimit; | 2291 | di->dqb_ihardlimit = dm->dqb_ihardlimit; |
2062 | di->dqb_isoftlimit = dm->dqb_isoftlimit; | 2292 | di->dqb_isoftlimit = dm->dqb_isoftlimit; |
2063 | di->dqb_curinodes = dm->dqb_curinodes; | 2293 | di->dqb_curinodes = dm->dqb_curinodes; |
@@ -2067,18 +2297,20 @@ static void do_get_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2067 | spin_unlock(&dq_data_lock); | 2297 | spin_unlock(&dq_data_lock); |
2068 | } | 2298 | } |
2069 | 2299 | ||
2070 | int vfs_get_dqblk(struct super_block *sb, int type, qid_t id, struct if_dqblk *di) | 2300 | int vfs_get_dqblk(struct super_block *sb, int type, qid_t id, |
2301 | struct if_dqblk *di) | ||
2071 | { | 2302 | { |
2072 | struct dquot *dquot; | 2303 | struct dquot *dquot; |
2073 | 2304 | ||
2074 | dquot = dqget(sb, id, type); | 2305 | dquot = dqget(sb, id, type); |
2075 | if (dquot == NODQUOT) | 2306 | if (!dquot) |
2076 | return -ESRCH; | 2307 | return -ESRCH; |
2077 | do_get_dqblk(dquot, di); | 2308 | do_get_dqblk(dquot, di); |
2078 | dqput(dquot); | 2309 | dqput(dquot); |
2079 | 2310 | ||
2080 | return 0; | 2311 | return 0; |
2081 | } | 2312 | } |
2313 | EXPORT_SYMBOL(vfs_get_dqblk); | ||
2082 | 2314 | ||
2083 | /* Generic routine for setting common part of quota structure */ | 2315 | /* Generic routine for setting common part of quota structure */ |
2084 | static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) | 2316 | static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) |
@@ -2097,7 +2329,7 @@ static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2097 | 2329 | ||
2098 | spin_lock(&dq_data_lock); | 2330 | spin_lock(&dq_data_lock); |
2099 | if (di->dqb_valid & QIF_SPACE) { | 2331 | if (di->dqb_valid & QIF_SPACE) { |
2100 | dm->dqb_curspace = di->dqb_curspace; | 2332 | dm->dqb_curspace = di->dqb_curspace - dm->dqb_rsvspace; |
2101 | check_blim = 1; | 2333 | check_blim = 1; |
2102 | __set_bit(DQ_LASTSET_B + QIF_SPACE_B, &dquot->dq_flags); | 2334 | __set_bit(DQ_LASTSET_B + QIF_SPACE_B, &dquot->dq_flags); |
2103 | } | 2335 | } |
@@ -2130,22 +2362,25 @@ static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2130 | } | 2362 | } |
2131 | 2363 | ||
2132 | if (check_blim) { | 2364 | if (check_blim) { |
2133 | if (!dm->dqb_bsoftlimit || dm->dqb_curspace < dm->dqb_bsoftlimit) { | 2365 | if (!dm->dqb_bsoftlimit || |
2366 | dm->dqb_curspace < dm->dqb_bsoftlimit) { | ||
2134 | dm->dqb_btime = 0; | 2367 | dm->dqb_btime = 0; |
2135 | clear_bit(DQ_BLKS_B, &dquot->dq_flags); | 2368 | clear_bit(DQ_BLKS_B, &dquot->dq_flags); |
2136 | } | 2369 | } else if (!(di->dqb_valid & QIF_BTIME)) |
2137 | else if (!(di->dqb_valid & QIF_BTIME)) /* Set grace only if user hasn't provided his own... */ | 2370 | /* Set grace only if user hasn't provided his own... */ |
2138 | dm->dqb_btime = get_seconds() + dqi->dqi_bgrace; | 2371 | dm->dqb_btime = get_seconds() + dqi->dqi_bgrace; |
2139 | } | 2372 | } |
2140 | if (check_ilim) { | 2373 | if (check_ilim) { |
2141 | if (!dm->dqb_isoftlimit || dm->dqb_curinodes < dm->dqb_isoftlimit) { | 2374 | if (!dm->dqb_isoftlimit || |
2375 | dm->dqb_curinodes < dm->dqb_isoftlimit) { | ||
2142 | dm->dqb_itime = 0; | 2376 | dm->dqb_itime = 0; |
2143 | clear_bit(DQ_INODES_B, &dquot->dq_flags); | 2377 | clear_bit(DQ_INODES_B, &dquot->dq_flags); |
2144 | } | 2378 | } else if (!(di->dqb_valid & QIF_ITIME)) |
2145 | else if (!(di->dqb_valid & QIF_ITIME)) /* Set grace only if user hasn't provided his own... */ | 2379 | /* Set grace only if user hasn't provided his own... */ |
2146 | dm->dqb_itime = get_seconds() + dqi->dqi_igrace; | 2380 | dm->dqb_itime = get_seconds() + dqi->dqi_igrace; |
2147 | } | 2381 | } |
2148 | if (dm->dqb_bhardlimit || dm->dqb_bsoftlimit || dm->dqb_ihardlimit || dm->dqb_isoftlimit) | 2382 | if (dm->dqb_bhardlimit || dm->dqb_bsoftlimit || dm->dqb_ihardlimit || |
2383 | dm->dqb_isoftlimit) | ||
2149 | clear_bit(DQ_FAKE_B, &dquot->dq_flags); | 2384 | clear_bit(DQ_FAKE_B, &dquot->dq_flags); |
2150 | else | 2385 | else |
2151 | set_bit(DQ_FAKE_B, &dquot->dq_flags); | 2386 | set_bit(DQ_FAKE_B, &dquot->dq_flags); |
@@ -2155,7 +2390,8 @@ static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2155 | return 0; | 2390 | return 0; |
2156 | } | 2391 | } |
2157 | 2392 | ||
2158 | int vfs_set_dqblk(struct super_block *sb, int type, qid_t id, struct if_dqblk *di) | 2393 | int vfs_set_dqblk(struct super_block *sb, int type, qid_t id, |
2394 | struct if_dqblk *di) | ||
2159 | { | 2395 | { |
2160 | struct dquot *dquot; | 2396 | struct dquot *dquot; |
2161 | int rc; | 2397 | int rc; |
@@ -2170,6 +2406,7 @@ int vfs_set_dqblk(struct super_block *sb, int type, qid_t id, struct if_dqblk *d | |||
2170 | out: | 2406 | out: |
2171 | return rc; | 2407 | return rc; |
2172 | } | 2408 | } |
2409 | EXPORT_SYMBOL(vfs_set_dqblk); | ||
2173 | 2410 | ||
2174 | /* Generic routine for getting common part of quota file information */ | 2411 | /* Generic routine for getting common part of quota file information */ |
2175 | int vfs_get_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) | 2412 | int vfs_get_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) |
@@ -2191,6 +2428,7 @@ int vfs_get_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) | |||
2191 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); | 2428 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); |
2192 | return 0; | 2429 | return 0; |
2193 | } | 2430 | } |
2431 | EXPORT_SYMBOL(vfs_get_dqinfo); | ||
2194 | 2432 | ||
2195 | /* Generic routine for setting common part of quota file information */ | 2433 | /* Generic routine for setting common part of quota file information */ |
2196 | int vfs_set_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) | 2434 | int vfs_set_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) |
@@ -2210,7 +2448,8 @@ int vfs_set_dqinfo(struct super_block *sb, int type, struct if_dqinfo *ii) | |||
2210 | if (ii->dqi_valid & IIF_IGRACE) | 2448 | if (ii->dqi_valid & IIF_IGRACE) |
2211 | mi->dqi_igrace = ii->dqi_igrace; | 2449 | mi->dqi_igrace = ii->dqi_igrace; |
2212 | if (ii->dqi_valid & IIF_FLAGS) | 2450 | if (ii->dqi_valid & IIF_FLAGS) |
2213 | mi->dqi_flags = (mi->dqi_flags & ~DQF_MASK) | (ii->dqi_flags & DQF_MASK); | 2451 | mi->dqi_flags = (mi->dqi_flags & ~DQF_MASK) | |
2452 | (ii->dqi_flags & DQF_MASK); | ||
2214 | spin_unlock(&dq_data_lock); | 2453 | spin_unlock(&dq_data_lock); |
2215 | mark_info_dirty(sb, type); | 2454 | mark_info_dirty(sb, type); |
2216 | /* Force write to disk */ | 2455 | /* Force write to disk */ |
@@ -2219,6 +2458,7 @@ out: | |||
2219 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); | 2458 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); |
2220 | return err; | 2459 | return err; |
2221 | } | 2460 | } |
2461 | EXPORT_SYMBOL(vfs_set_dqinfo); | ||
2222 | 2462 | ||
2223 | struct quotactl_ops vfs_quotactl_ops = { | 2463 | struct quotactl_ops vfs_quotactl_ops = { |
2224 | .quota_on = vfs_quota_on, | 2464 | .quota_on = vfs_quota_on, |
@@ -2368,43 +2608,10 @@ static int __init dquot_init(void) | |||
2368 | 2608 | ||
2369 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | 2609 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE |
2370 | if (genl_register_family("a_genl_family) != 0) | 2610 | if (genl_register_family("a_genl_family) != 0) |
2371 | printk(KERN_ERR "VFS: Failed to create quota netlink interface.\n"); | 2611 | printk(KERN_ERR |
2612 | "VFS: Failed to create quota netlink interface.\n"); | ||
2372 | #endif | 2613 | #endif |
2373 | 2614 | ||
2374 | return 0; | 2615 | return 0; |
2375 | } | 2616 | } |
2376 | module_init(dquot_init); | 2617 | module_init(dquot_init); |
2377 | |||
2378 | EXPORT_SYMBOL(register_quota_format); | ||
2379 | EXPORT_SYMBOL(unregister_quota_format); | ||
2380 | EXPORT_SYMBOL(dqstats); | ||
2381 | EXPORT_SYMBOL(dq_data_lock); | ||
2382 | EXPORT_SYMBOL(vfs_quota_enable); | ||
2383 | EXPORT_SYMBOL(vfs_quota_on); | ||
2384 | EXPORT_SYMBOL(vfs_quota_on_path); | ||
2385 | EXPORT_SYMBOL(vfs_quota_on_mount); | ||
2386 | EXPORT_SYMBOL(vfs_quota_disable); | ||
2387 | EXPORT_SYMBOL(vfs_quota_off); | ||
2388 | EXPORT_SYMBOL(dquot_scan_active); | ||
2389 | EXPORT_SYMBOL(vfs_quota_sync); | ||
2390 | EXPORT_SYMBOL(vfs_get_dqinfo); | ||
2391 | EXPORT_SYMBOL(vfs_set_dqinfo); | ||
2392 | EXPORT_SYMBOL(vfs_get_dqblk); | ||
2393 | EXPORT_SYMBOL(vfs_set_dqblk); | ||
2394 | EXPORT_SYMBOL(dquot_commit); | ||
2395 | EXPORT_SYMBOL(dquot_commit_info); | ||
2396 | EXPORT_SYMBOL(dquot_acquire); | ||
2397 | EXPORT_SYMBOL(dquot_release); | ||
2398 | EXPORT_SYMBOL(dquot_mark_dquot_dirty); | ||
2399 | EXPORT_SYMBOL(dquot_initialize); | ||
2400 | EXPORT_SYMBOL(dquot_drop); | ||
2401 | EXPORT_SYMBOL(vfs_dq_drop); | ||
2402 | EXPORT_SYMBOL(dqget); | ||
2403 | EXPORT_SYMBOL(dqput); | ||
2404 | EXPORT_SYMBOL(dquot_alloc_space); | ||
2405 | EXPORT_SYMBOL(dquot_alloc_inode); | ||
2406 | EXPORT_SYMBOL(dquot_free_space); | ||
2407 | EXPORT_SYMBOL(dquot_free_inode); | ||
2408 | EXPORT_SYMBOL(dquot_transfer); | ||
2409 | EXPORT_SYMBOL(vfs_dq_transfer); | ||
2410 | EXPORT_SYMBOL(vfs_dq_quota_on_remount); | ||
diff --git a/fs/quota.c b/fs/quota/quota.c index d76ada914f98..b7f5a468f076 100644 --- a/fs/quota.c +++ b/fs/quota/quota.c | |||
@@ -20,7 +20,8 @@ | |||
20 | #include <linux/types.h> | 20 | #include <linux/types.h> |
21 | 21 | ||
22 | /* Check validity of generic quotactl commands */ | 22 | /* Check validity of generic quotactl commands */ |
23 | static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, qid_t id) | 23 | static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, |
24 | qid_t id) | ||
24 | { | 25 | { |
25 | if (type >= MAXQUOTAS) | 26 | if (type >= MAXQUOTAS) |
26 | return -EINVAL; | 27 | return -EINVAL; |
@@ -72,7 +73,8 @@ static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, qid | |||
72 | case Q_SETINFO: | 73 | case Q_SETINFO: |
73 | case Q_SETQUOTA: | 74 | case Q_SETQUOTA: |
74 | case Q_GETQUOTA: | 75 | case Q_GETQUOTA: |
75 | /* This is just informative test so we are satisfied without a lock */ | 76 | /* This is just an informative test so we are satisfied |
77 | * without the lock */ | ||
76 | if (!sb_has_quota_active(sb, type)) | 78 | if (!sb_has_quota_active(sb, type)) |
77 | return -ESRCH; | 79 | return -ESRCH; |
78 | } | 80 | } |
@@ -92,7 +94,8 @@ static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, qid | |||
92 | } | 94 | } |
93 | 95 | ||
94 | /* Check validity of XFS Quota Manager commands */ | 96 | /* Check validity of XFS Quota Manager commands */ |
95 | static int xqm_quotactl_valid(struct super_block *sb, int type, int cmd, qid_t id) | 97 | static int xqm_quotactl_valid(struct super_block *sb, int type, int cmd, |
98 | qid_t id) | ||
96 | { | 99 | { |
97 | if (type >= XQM_MAXQUOTAS) | 100 | if (type >= XQM_MAXQUOTAS) |
98 | return -EINVAL; | 101 | return -EINVAL; |
@@ -142,7 +145,8 @@ static int xqm_quotactl_valid(struct super_block *sb, int type, int cmd, qid_t i | |||
142 | return 0; | 145 | return 0; |
143 | } | 146 | } |
144 | 147 | ||
145 | static int check_quotactl_valid(struct super_block *sb, int type, int cmd, qid_t id) | 148 | static int check_quotactl_valid(struct super_block *sb, int type, int cmd, |
149 | qid_t id) | ||
146 | { | 150 | { |
147 | int error; | 151 | int error; |
148 | 152 | ||
@@ -180,7 +184,8 @@ static void quota_sync_sb(struct super_block *sb, int type) | |||
180 | continue; | 184 | continue; |
181 | if (!sb_has_quota_active(sb, cnt)) | 185 | if (!sb_has_quota_active(sb, cnt)) |
182 | continue; | 186 | continue; |
183 | mutex_lock_nested(&sb_dqopt(sb)->files[cnt]->i_mutex, I_MUTEX_QUOTA); | 187 | mutex_lock_nested(&sb_dqopt(sb)->files[cnt]->i_mutex, |
188 | I_MUTEX_QUOTA); | ||
184 | truncate_inode_pages(&sb_dqopt(sb)->files[cnt]->i_data, 0); | 189 | truncate_inode_pages(&sb_dqopt(sb)->files[cnt]->i_data, 0); |
185 | mutex_unlock(&sb_dqopt(sb)->files[cnt]->i_mutex); | 190 | mutex_unlock(&sb_dqopt(sb)->files[cnt]->i_mutex); |
186 | } | 191 | } |
@@ -200,14 +205,15 @@ void sync_dquots(struct super_block *sb, int type) | |||
200 | spin_lock(&sb_lock); | 205 | spin_lock(&sb_lock); |
201 | restart: | 206 | restart: |
202 | list_for_each_entry(sb, &super_blocks, s_list) { | 207 | list_for_each_entry(sb, &super_blocks, s_list) { |
203 | /* This test just improves performance so it needn't be reliable... */ | 208 | /* This test just improves performance so it needn't be |
209 | * reliable... */ | ||
204 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 210 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
205 | if (type != -1 && type != cnt) | 211 | if (type != -1 && type != cnt) |
206 | continue; | 212 | continue; |
207 | if (!sb_has_quota_active(sb, cnt)) | 213 | if (!sb_has_quota_active(sb, cnt)) |
208 | continue; | 214 | continue; |
209 | if (!info_dirty(&sb_dqopt(sb)->info[cnt]) && | 215 | if (!info_dirty(&sb_dqopt(sb)->info[cnt]) && |
210 | list_empty(&sb_dqopt(sb)->info[cnt].dqi_dirty_list)) | 216 | list_empty(&sb_dqopt(sb)->info[cnt].dqi_dirty_list)) |
211 | continue; | 217 | continue; |
212 | break; | 218 | break; |
213 | } | 219 | } |
@@ -227,7 +233,8 @@ restart: | |||
227 | } | 233 | } |
228 | 234 | ||
229 | /* Copy parameters and call proper function */ | 235 | /* Copy parameters and call proper function */ |
230 | static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void __user *addr) | 236 | static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, |
237 | void __user *addr) | ||
231 | { | 238 | { |
232 | int ret; | 239 | int ret; |
233 | 240 | ||
@@ -235,7 +242,8 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void | |||
235 | case Q_QUOTAON: { | 242 | case Q_QUOTAON: { |
236 | char *pathname; | 243 | char *pathname; |
237 | 244 | ||
238 | if (IS_ERR(pathname = getname(addr))) | 245 | pathname = getname(addr); |
246 | if (IS_ERR(pathname)) | ||
239 | return PTR_ERR(pathname); | 247 | return PTR_ERR(pathname); |
240 | ret = sb->s_qcop->quota_on(sb, type, id, pathname, 0); | 248 | ret = sb->s_qcop->quota_on(sb, type, id, pathname, 0); |
241 | putname(pathname); | 249 | putname(pathname); |
@@ -261,7 +269,8 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void | |||
261 | case Q_GETINFO: { | 269 | case Q_GETINFO: { |
262 | struct if_dqinfo info; | 270 | struct if_dqinfo info; |
263 | 271 | ||
264 | if ((ret = sb->s_qcop->get_info(sb, type, &info))) | 272 | ret = sb->s_qcop->get_info(sb, type, &info); |
273 | if (ret) | ||
265 | return ret; | 274 | return ret; |
266 | if (copy_to_user(addr, &info, sizeof(info))) | 275 | if (copy_to_user(addr, &info, sizeof(info))) |
267 | return -EFAULT; | 276 | return -EFAULT; |
@@ -277,7 +286,8 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void | |||
277 | case Q_GETQUOTA: { | 286 | case Q_GETQUOTA: { |
278 | struct if_dqblk idq; | 287 | struct if_dqblk idq; |
279 | 288 | ||
280 | if ((ret = sb->s_qcop->get_dqblk(sb, type, id, &idq))) | 289 | ret = sb->s_qcop->get_dqblk(sb, type, id, &idq); |
290 | if (ret) | ||
281 | return ret; | 291 | return ret; |
282 | if (copy_to_user(addr, &idq, sizeof(idq))) | 292 | if (copy_to_user(addr, &idq, sizeof(idq))) |
283 | return -EFAULT; | 293 | return -EFAULT; |
@@ -322,7 +332,8 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void | |||
322 | case Q_XGETQUOTA: { | 332 | case Q_XGETQUOTA: { |
323 | struct fs_disk_quota fdq; | 333 | struct fs_disk_quota fdq; |
324 | 334 | ||
325 | if ((ret = sb->s_qcop->get_xquota(sb, type, id, &fdq))) | 335 | ret = sb->s_qcop->get_xquota(sb, type, id, &fdq); |
336 | if (ret) | ||
326 | return ret; | 337 | return ret; |
327 | if (copy_to_user(addr, &fdq, sizeof(fdq))) | 338 | if (copy_to_user(addr, &fdq, sizeof(fdq))) |
328 | return -EFAULT; | 339 | return -EFAULT; |
@@ -341,7 +352,7 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, void | |||
341 | * look up a superblock on which quota ops will be performed | 352 | * look up a superblock on which quota ops will be performed |
342 | * - use the name of a block device to find the superblock thereon | 353 | * - use the name of a block device to find the superblock thereon |
343 | */ | 354 | */ |
344 | static inline struct super_block *quotactl_block(const char __user *special) | 355 | static struct super_block *quotactl_block(const char __user *special) |
345 | { | 356 | { |
346 | #ifdef CONFIG_BLOCK | 357 | #ifdef CONFIG_BLOCK |
347 | struct block_device *bdev; | 358 | struct block_device *bdev; |
diff --git a/fs/quota_tree.c b/fs/quota/quota_tree.c index 953404c95b17..f81f4bcfb178 100644 --- a/fs/quota_tree.c +++ b/fs/quota/quota_tree.c | |||
@@ -22,8 +22,6 @@ MODULE_LICENSE("GPL"); | |||
22 | 22 | ||
23 | #define __QUOTA_QT_PARANOIA | 23 | #define __QUOTA_QT_PARANOIA |
24 | 24 | ||
25 | typedef char *dqbuf_t; | ||
26 | |||
27 | static int get_index(struct qtree_mem_dqinfo *info, qid_t id, int depth) | 25 | static int get_index(struct qtree_mem_dqinfo *info, qid_t id, int depth) |
28 | { | 26 | { |
29 | unsigned int epb = info->dqi_usable_bs >> 2; | 27 | unsigned int epb = info->dqi_usable_bs >> 2; |
@@ -35,46 +33,42 @@ static int get_index(struct qtree_mem_dqinfo *info, qid_t id, int depth) | |||
35 | } | 33 | } |
36 | 34 | ||
37 | /* Number of entries in one blocks */ | 35 | /* Number of entries in one blocks */ |
38 | static inline int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info) | 36 | static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info) |
39 | { | 37 | { |
40 | return (info->dqi_usable_bs - sizeof(struct qt_disk_dqdbheader)) | 38 | return (info->dqi_usable_bs - sizeof(struct qt_disk_dqdbheader)) |
41 | / info->dqi_entry_size; | 39 | / info->dqi_entry_size; |
42 | } | 40 | } |
43 | 41 | ||
44 | static dqbuf_t getdqbuf(size_t size) | 42 | static char *getdqbuf(size_t size) |
45 | { | 43 | { |
46 | dqbuf_t buf = kmalloc(size, GFP_NOFS); | 44 | char *buf = kmalloc(size, GFP_NOFS); |
47 | if (!buf) | 45 | if (!buf) |
48 | printk(KERN_WARNING "VFS: Not enough memory for quota buffers.\n"); | 46 | printk(KERN_WARNING |
47 | "VFS: Not enough memory for quota buffers.\n"); | ||
49 | return buf; | 48 | return buf; |
50 | } | 49 | } |
51 | 50 | ||
52 | static inline void freedqbuf(dqbuf_t buf) | 51 | static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf) |
53 | { | ||
54 | kfree(buf); | ||
55 | } | ||
56 | |||
57 | static inline ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, dqbuf_t buf) | ||
58 | { | 52 | { |
59 | struct super_block *sb = info->dqi_sb; | 53 | struct super_block *sb = info->dqi_sb; |
60 | 54 | ||
61 | memset(buf, 0, info->dqi_usable_bs); | 55 | memset(buf, 0, info->dqi_usable_bs); |
62 | return sb->s_op->quota_read(sb, info->dqi_type, (char *)buf, | 56 | return sb->s_op->quota_read(sb, info->dqi_type, buf, |
63 | info->dqi_usable_bs, blk << info->dqi_blocksize_bits); | 57 | info->dqi_usable_bs, blk << info->dqi_blocksize_bits); |
64 | } | 58 | } |
65 | 59 | ||
66 | static inline ssize_t write_blk(struct qtree_mem_dqinfo *info, uint blk, dqbuf_t buf) | 60 | static ssize_t write_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf) |
67 | { | 61 | { |
68 | struct super_block *sb = info->dqi_sb; | 62 | struct super_block *sb = info->dqi_sb; |
69 | 63 | ||
70 | return sb->s_op->quota_write(sb, info->dqi_type, (char *)buf, | 64 | return sb->s_op->quota_write(sb, info->dqi_type, buf, |
71 | info->dqi_usable_bs, blk << info->dqi_blocksize_bits); | 65 | info->dqi_usable_bs, blk << info->dqi_blocksize_bits); |
72 | } | 66 | } |
73 | 67 | ||
74 | /* Remove empty block from list and return it */ | 68 | /* Remove empty block from list and return it */ |
75 | static int get_free_dqblk(struct qtree_mem_dqinfo *info) | 69 | static int get_free_dqblk(struct qtree_mem_dqinfo *info) |
76 | { | 70 | { |
77 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 71 | char *buf = getdqbuf(info->dqi_usable_bs); |
78 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; | 72 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; |
79 | int ret, blk; | 73 | int ret, blk; |
80 | 74 | ||
@@ -98,12 +92,12 @@ static int get_free_dqblk(struct qtree_mem_dqinfo *info) | |||
98 | mark_info_dirty(info->dqi_sb, info->dqi_type); | 92 | mark_info_dirty(info->dqi_sb, info->dqi_type); |
99 | ret = blk; | 93 | ret = blk; |
100 | out_buf: | 94 | out_buf: |
101 | freedqbuf(buf); | 95 | kfree(buf); |
102 | return ret; | 96 | return ret; |
103 | } | 97 | } |
104 | 98 | ||
105 | /* Insert empty block to the list */ | 99 | /* Insert empty block to the list */ |
106 | static int put_free_dqblk(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint blk) | 100 | static int put_free_dqblk(struct qtree_mem_dqinfo *info, char *buf, uint blk) |
107 | { | 101 | { |
108 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; | 102 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; |
109 | int err; | 103 | int err; |
@@ -120,9 +114,10 @@ static int put_free_dqblk(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint blk) | |||
120 | } | 114 | } |
121 | 115 | ||
122 | /* Remove given block from the list of blocks with free entries */ | 116 | /* Remove given block from the list of blocks with free entries */ |
123 | static int remove_free_dqentry(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint blk) | 117 | static int remove_free_dqentry(struct qtree_mem_dqinfo *info, char *buf, |
118 | uint blk) | ||
124 | { | 119 | { |
125 | dqbuf_t tmpbuf = getdqbuf(info->dqi_usable_bs); | 120 | char *tmpbuf = getdqbuf(info->dqi_usable_bs); |
126 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; | 121 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; |
127 | uint nextblk = le32_to_cpu(dh->dqdh_next_free); | 122 | uint nextblk = le32_to_cpu(dh->dqdh_next_free); |
128 | uint prevblk = le32_to_cpu(dh->dqdh_prev_free); | 123 | uint prevblk = le32_to_cpu(dh->dqdh_prev_free); |
@@ -153,21 +148,24 @@ static int remove_free_dqentry(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint | |||
153 | info->dqi_free_entry = nextblk; | 148 | info->dqi_free_entry = nextblk; |
154 | mark_info_dirty(info->dqi_sb, info->dqi_type); | 149 | mark_info_dirty(info->dqi_sb, info->dqi_type); |
155 | } | 150 | } |
156 | freedqbuf(tmpbuf); | 151 | kfree(tmpbuf); |
157 | dh->dqdh_next_free = dh->dqdh_prev_free = cpu_to_le32(0); | 152 | dh->dqdh_next_free = dh->dqdh_prev_free = cpu_to_le32(0); |
158 | /* No matter whether write succeeds block is out of list */ | 153 | /* No matter whether write succeeds block is out of list */ |
159 | if (write_blk(info, blk, buf) < 0) | 154 | if (write_blk(info, blk, buf) < 0) |
160 | printk(KERN_ERR "VFS: Can't write block (%u) with free entries.\n", blk); | 155 | printk(KERN_ERR |
156 | "VFS: Can't write block (%u) with free entries.\n", | ||
157 | blk); | ||
161 | return 0; | 158 | return 0; |
162 | out_buf: | 159 | out_buf: |
163 | freedqbuf(tmpbuf); | 160 | kfree(tmpbuf); |
164 | return err; | 161 | return err; |
165 | } | 162 | } |
166 | 163 | ||
167 | /* Insert given block to the beginning of list with free entries */ | 164 | /* Insert given block to the beginning of list with free entries */ |
168 | static int insert_free_dqentry(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint blk) | 165 | static int insert_free_dqentry(struct qtree_mem_dqinfo *info, char *buf, |
166 | uint blk) | ||
169 | { | 167 | { |
170 | dqbuf_t tmpbuf = getdqbuf(info->dqi_usable_bs); | 168 | char *tmpbuf = getdqbuf(info->dqi_usable_bs); |
171 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; | 169 | struct qt_disk_dqdbheader *dh = (struct qt_disk_dqdbheader *)buf; |
172 | int err; | 170 | int err; |
173 | 171 | ||
@@ -188,12 +186,12 @@ static int insert_free_dqentry(struct qtree_mem_dqinfo *info, dqbuf_t buf, uint | |||
188 | if (err < 0) | 186 | if (err < 0) |
189 | goto out_buf; | 187 | goto out_buf; |
190 | } | 188 | } |
191 | freedqbuf(tmpbuf); | 189 | kfree(tmpbuf); |
192 | info->dqi_free_entry = blk; | 190 | info->dqi_free_entry = blk; |
193 | mark_info_dirty(info->dqi_sb, info->dqi_type); | 191 | mark_info_dirty(info->dqi_sb, info->dqi_type); |
194 | return 0; | 192 | return 0; |
195 | out_buf: | 193 | out_buf: |
196 | freedqbuf(tmpbuf); | 194 | kfree(tmpbuf); |
197 | return err; | 195 | return err; |
198 | } | 196 | } |
199 | 197 | ||
@@ -215,7 +213,7 @@ static uint find_free_dqentry(struct qtree_mem_dqinfo *info, | |||
215 | { | 213 | { |
216 | uint blk, i; | 214 | uint blk, i; |
217 | struct qt_disk_dqdbheader *dh; | 215 | struct qt_disk_dqdbheader *dh; |
218 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 216 | char *buf = getdqbuf(info->dqi_usable_bs); |
219 | char *ddquot; | 217 | char *ddquot; |
220 | 218 | ||
221 | *err = 0; | 219 | *err = 0; |
@@ -233,11 +231,12 @@ static uint find_free_dqentry(struct qtree_mem_dqinfo *info, | |||
233 | blk = get_free_dqblk(info); | 231 | blk = get_free_dqblk(info); |
234 | if ((int)blk < 0) { | 232 | if ((int)blk < 0) { |
235 | *err = blk; | 233 | *err = blk; |
236 | freedqbuf(buf); | 234 | kfree(buf); |
237 | return 0; | 235 | return 0; |
238 | } | 236 | } |
239 | memset(buf, 0, info->dqi_usable_bs); | 237 | memset(buf, 0, info->dqi_usable_bs); |
240 | /* This is enough as block is already zeroed and entry list is empty... */ | 238 | /* This is enough as the block is already zeroed and the entry |
239 | * list is empty... */ | ||
241 | info->dqi_free_entry = blk; | 240 | info->dqi_free_entry = blk; |
242 | mark_info_dirty(dquot->dq_sb, dquot->dq_type); | 241 | mark_info_dirty(dquot->dq_sb, dquot->dq_type); |
243 | } | 242 | } |
@@ -253,9 +252,12 @@ static uint find_free_dqentry(struct qtree_mem_dqinfo *info, | |||
253 | } | 252 | } |
254 | le16_add_cpu(&dh->dqdh_entries, 1); | 253 | le16_add_cpu(&dh->dqdh_entries, 1); |
255 | /* Find free structure in block */ | 254 | /* Find free structure in block */ |
256 | for (i = 0, ddquot = ((char *)buf) + sizeof(struct qt_disk_dqdbheader); | 255 | ddquot = buf + sizeof(struct qt_disk_dqdbheader); |
257 | i < qtree_dqstr_in_blk(info) && !qtree_entry_unused(info, ddquot); | 256 | for (i = 0; i < qtree_dqstr_in_blk(info); i++) { |
258 | i++, ddquot += info->dqi_entry_size); | 257 | if (qtree_entry_unused(info, ddquot)) |
258 | break; | ||
259 | ddquot += info->dqi_entry_size; | ||
260 | } | ||
259 | #ifdef __QUOTA_QT_PARANOIA | 261 | #ifdef __QUOTA_QT_PARANOIA |
260 | if (i == qtree_dqstr_in_blk(info)) { | 262 | if (i == qtree_dqstr_in_blk(info)) { |
261 | printk(KERN_ERR "VFS: find_free_dqentry(): Data block full " | 263 | printk(KERN_ERR "VFS: find_free_dqentry(): Data block full " |
@@ -273,10 +275,10 @@ static uint find_free_dqentry(struct qtree_mem_dqinfo *info, | |||
273 | dquot->dq_off = (blk << info->dqi_blocksize_bits) + | 275 | dquot->dq_off = (blk << info->dqi_blocksize_bits) + |
274 | sizeof(struct qt_disk_dqdbheader) + | 276 | sizeof(struct qt_disk_dqdbheader) + |
275 | i * info->dqi_entry_size; | 277 | i * info->dqi_entry_size; |
276 | freedqbuf(buf); | 278 | kfree(buf); |
277 | return blk; | 279 | return blk; |
278 | out_buf: | 280 | out_buf: |
279 | freedqbuf(buf); | 281 | kfree(buf); |
280 | return 0; | 282 | return 0; |
281 | } | 283 | } |
282 | 284 | ||
@@ -284,7 +286,7 @@ out_buf: | |||
284 | static int do_insert_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, | 286 | static int do_insert_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, |
285 | uint *treeblk, int depth) | 287 | uint *treeblk, int depth) |
286 | { | 288 | { |
287 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 289 | char *buf = getdqbuf(info->dqi_usable_bs); |
288 | int ret = 0, newson = 0, newact = 0; | 290 | int ret = 0, newson = 0, newact = 0; |
289 | __le32 *ref; | 291 | __le32 *ref; |
290 | uint newblk; | 292 | uint newblk; |
@@ -333,7 +335,7 @@ static int do_insert_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, | |||
333 | put_free_dqblk(info, buf, *treeblk); | 335 | put_free_dqblk(info, buf, *treeblk); |
334 | } | 336 | } |
335 | out_buf: | 337 | out_buf: |
336 | freedqbuf(buf); | 338 | kfree(buf); |
337 | return ret; | 339 | return ret; |
338 | } | 340 | } |
339 | 341 | ||
@@ -346,14 +348,15 @@ static inline int dq_insert_tree(struct qtree_mem_dqinfo *info, | |||
346 | } | 348 | } |
347 | 349 | ||
348 | /* | 350 | /* |
349 | * We don't have to be afraid of deadlocks as we never have quotas on quota files... | 351 | * We don't have to be afraid of deadlocks as we never have quotas on quota |
352 | * files... | ||
350 | */ | 353 | */ |
351 | int qtree_write_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | 354 | int qtree_write_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) |
352 | { | 355 | { |
353 | int type = dquot->dq_type; | 356 | int type = dquot->dq_type; |
354 | struct super_block *sb = dquot->dq_sb; | 357 | struct super_block *sb = dquot->dq_sb; |
355 | ssize_t ret; | 358 | ssize_t ret; |
356 | dqbuf_t ddquot = getdqbuf(info->dqi_entry_size); | 359 | char *ddquot = getdqbuf(info->dqi_entry_size); |
357 | 360 | ||
358 | if (!ddquot) | 361 | if (!ddquot) |
359 | return -ENOMEM; | 362 | return -ENOMEM; |
@@ -364,15 +367,15 @@ int qtree_write_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
364 | if (ret < 0) { | 367 | if (ret < 0) { |
365 | printk(KERN_ERR "VFS: Error %zd occurred while " | 368 | printk(KERN_ERR "VFS: Error %zd occurred while " |
366 | "creating quota.\n", ret); | 369 | "creating quota.\n", ret); |
367 | freedqbuf(ddquot); | 370 | kfree(ddquot); |
368 | return ret; | 371 | return ret; |
369 | } | 372 | } |
370 | } | 373 | } |
371 | spin_lock(&dq_data_lock); | 374 | spin_lock(&dq_data_lock); |
372 | info->dqi_ops->mem2disk_dqblk(ddquot, dquot); | 375 | info->dqi_ops->mem2disk_dqblk(ddquot, dquot); |
373 | spin_unlock(&dq_data_lock); | 376 | spin_unlock(&dq_data_lock); |
374 | ret = sb->s_op->quota_write(sb, type, (char *)ddquot, | 377 | ret = sb->s_op->quota_write(sb, type, ddquot, info->dqi_entry_size, |
375 | info->dqi_entry_size, dquot->dq_off); | 378 | dquot->dq_off); |
376 | if (ret != info->dqi_entry_size) { | 379 | if (ret != info->dqi_entry_size) { |
377 | printk(KERN_WARNING "VFS: dquota write failed on dev %s\n", | 380 | printk(KERN_WARNING "VFS: dquota write failed on dev %s\n", |
378 | sb->s_id); | 381 | sb->s_id); |
@@ -382,7 +385,7 @@ int qtree_write_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
382 | ret = 0; | 385 | ret = 0; |
383 | } | 386 | } |
384 | dqstats.writes++; | 387 | dqstats.writes++; |
385 | freedqbuf(ddquot); | 388 | kfree(ddquot); |
386 | 389 | ||
387 | return ret; | 390 | return ret; |
388 | } | 391 | } |
@@ -393,7 +396,7 @@ static int free_dqentry(struct qtree_mem_dqinfo *info, struct dquot *dquot, | |||
393 | uint blk) | 396 | uint blk) |
394 | { | 397 | { |
395 | struct qt_disk_dqdbheader *dh; | 398 | struct qt_disk_dqdbheader *dh; |
396 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 399 | char *buf = getdqbuf(info->dqi_usable_bs); |
397 | int ret = 0; | 400 | int ret = 0; |
398 | 401 | ||
399 | if (!buf) | 402 | if (!buf) |
@@ -444,7 +447,7 @@ static int free_dqentry(struct qtree_mem_dqinfo *info, struct dquot *dquot, | |||
444 | } | 447 | } |
445 | dquot->dq_off = 0; /* Quota is now unattached */ | 448 | dquot->dq_off = 0; /* Quota is now unattached */ |
446 | out_buf: | 449 | out_buf: |
447 | freedqbuf(buf); | 450 | kfree(buf); |
448 | return ret; | 451 | return ret; |
449 | } | 452 | } |
450 | 453 | ||
@@ -452,7 +455,7 @@ out_buf: | |||
452 | static int remove_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, | 455 | static int remove_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, |
453 | uint *blk, int depth) | 456 | uint *blk, int depth) |
454 | { | 457 | { |
455 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 458 | char *buf = getdqbuf(info->dqi_usable_bs); |
456 | int ret = 0; | 459 | int ret = 0; |
457 | uint newblk; | 460 | uint newblk; |
458 | __le32 *ref = (__le32 *)buf; | 461 | __le32 *ref = (__le32 *)buf; |
@@ -475,9 +478,8 @@ static int remove_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, | |||
475 | int i; | 478 | int i; |
476 | ref[get_index(info, dquot->dq_id, depth)] = cpu_to_le32(0); | 479 | ref[get_index(info, dquot->dq_id, depth)] = cpu_to_le32(0); |
477 | /* Block got empty? */ | 480 | /* Block got empty? */ |
478 | for (i = 0; | 481 | for (i = 0; i < (info->dqi_usable_bs >> 2) && !ref[i]; i++) |
479 | i < (info->dqi_usable_bs >> 2) && !ref[i]; | 482 | ; |
480 | i++); | ||
481 | /* Don't put the root block into the free block list */ | 483 | /* Don't put the root block into the free block list */ |
482 | if (i == (info->dqi_usable_bs >> 2) | 484 | if (i == (info->dqi_usable_bs >> 2) |
483 | && *blk != QT_TREEOFF) { | 485 | && *blk != QT_TREEOFF) { |
@@ -491,7 +493,7 @@ static int remove_tree(struct qtree_mem_dqinfo *info, struct dquot *dquot, | |||
491 | } | 493 | } |
492 | } | 494 | } |
493 | out_buf: | 495 | out_buf: |
494 | freedqbuf(buf); | 496 | kfree(buf); |
495 | return ret; | 497 | return ret; |
496 | } | 498 | } |
497 | 499 | ||
@@ -510,7 +512,7 @@ EXPORT_SYMBOL(qtree_delete_dquot); | |||
510 | static loff_t find_block_dqentry(struct qtree_mem_dqinfo *info, | 512 | static loff_t find_block_dqentry(struct qtree_mem_dqinfo *info, |
511 | struct dquot *dquot, uint blk) | 513 | struct dquot *dquot, uint blk) |
512 | { | 514 | { |
513 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 515 | char *buf = getdqbuf(info->dqi_usable_bs); |
514 | loff_t ret = 0; | 516 | loff_t ret = 0; |
515 | int i; | 517 | int i; |
516 | char *ddquot; | 518 | char *ddquot; |
@@ -522,9 +524,12 @@ static loff_t find_block_dqentry(struct qtree_mem_dqinfo *info, | |||
522 | printk(KERN_ERR "VFS: Can't read quota tree block %u.\n", blk); | 524 | printk(KERN_ERR "VFS: Can't read quota tree block %u.\n", blk); |
523 | goto out_buf; | 525 | goto out_buf; |
524 | } | 526 | } |
525 | for (i = 0, ddquot = ((char *)buf) + sizeof(struct qt_disk_dqdbheader); | 527 | ddquot = buf + sizeof(struct qt_disk_dqdbheader); |
526 | i < qtree_dqstr_in_blk(info) && !info->dqi_ops->is_id(ddquot, dquot); | 528 | for (i = 0; i < qtree_dqstr_in_blk(info); i++) { |
527 | i++, ddquot += info->dqi_entry_size); | 529 | if (info->dqi_ops->is_id(ddquot, dquot)) |
530 | break; | ||
531 | ddquot += info->dqi_entry_size; | ||
532 | } | ||
528 | if (i == qtree_dqstr_in_blk(info)) { | 533 | if (i == qtree_dqstr_in_blk(info)) { |
529 | printk(KERN_ERR "VFS: Quota for id %u referenced " | 534 | printk(KERN_ERR "VFS: Quota for id %u referenced " |
530 | "but not present.\n", dquot->dq_id); | 535 | "but not present.\n", dquot->dq_id); |
@@ -535,7 +540,7 @@ static loff_t find_block_dqentry(struct qtree_mem_dqinfo *info, | |||
535 | qt_disk_dqdbheader) + i * info->dqi_entry_size; | 540 | qt_disk_dqdbheader) + i * info->dqi_entry_size; |
536 | } | 541 | } |
537 | out_buf: | 542 | out_buf: |
538 | freedqbuf(buf); | 543 | kfree(buf); |
539 | return ret; | 544 | return ret; |
540 | } | 545 | } |
541 | 546 | ||
@@ -543,7 +548,7 @@ out_buf: | |||
543 | static loff_t find_tree_dqentry(struct qtree_mem_dqinfo *info, | 548 | static loff_t find_tree_dqentry(struct qtree_mem_dqinfo *info, |
544 | struct dquot *dquot, uint blk, int depth) | 549 | struct dquot *dquot, uint blk, int depth) |
545 | { | 550 | { |
546 | dqbuf_t buf = getdqbuf(info->dqi_usable_bs); | 551 | char *buf = getdqbuf(info->dqi_usable_bs); |
547 | loff_t ret = 0; | 552 | loff_t ret = 0; |
548 | __le32 *ref = (__le32 *)buf; | 553 | __le32 *ref = (__le32 *)buf; |
549 | 554 | ||
@@ -563,7 +568,7 @@ static loff_t find_tree_dqentry(struct qtree_mem_dqinfo *info, | |||
563 | else | 568 | else |
564 | ret = find_block_dqentry(info, dquot, blk); | 569 | ret = find_block_dqentry(info, dquot, blk); |
565 | out_buf: | 570 | out_buf: |
566 | freedqbuf(buf); | 571 | kfree(buf); |
567 | return ret; | 572 | return ret; |
568 | } | 573 | } |
569 | 574 | ||
@@ -579,7 +584,7 @@ int qtree_read_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
579 | int type = dquot->dq_type; | 584 | int type = dquot->dq_type; |
580 | struct super_block *sb = dquot->dq_sb; | 585 | struct super_block *sb = dquot->dq_sb; |
581 | loff_t offset; | 586 | loff_t offset; |
582 | dqbuf_t ddquot; | 587 | char *ddquot; |
583 | int ret = 0; | 588 | int ret = 0; |
584 | 589 | ||
585 | #ifdef __QUOTA_QT_PARANOIA | 590 | #ifdef __QUOTA_QT_PARANOIA |
@@ -607,8 +612,8 @@ int qtree_read_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
607 | ddquot = getdqbuf(info->dqi_entry_size); | 612 | ddquot = getdqbuf(info->dqi_entry_size); |
608 | if (!ddquot) | 613 | if (!ddquot) |
609 | return -ENOMEM; | 614 | return -ENOMEM; |
610 | ret = sb->s_op->quota_read(sb, type, (char *)ddquot, | 615 | ret = sb->s_op->quota_read(sb, type, ddquot, info->dqi_entry_size, |
611 | info->dqi_entry_size, dquot->dq_off); | 616 | dquot->dq_off); |
612 | if (ret != info->dqi_entry_size) { | 617 | if (ret != info->dqi_entry_size) { |
613 | if (ret >= 0) | 618 | if (ret >= 0) |
614 | ret = -EIO; | 619 | ret = -EIO; |
@@ -616,7 +621,7 @@ int qtree_read_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
616 | "structure for id %u.\n", dquot->dq_id); | 621 | "structure for id %u.\n", dquot->dq_id); |
617 | set_bit(DQ_FAKE_B, &dquot->dq_flags); | 622 | set_bit(DQ_FAKE_B, &dquot->dq_flags); |
618 | memset(&dquot->dq_dqb, 0, sizeof(struct mem_dqblk)); | 623 | memset(&dquot->dq_dqb, 0, sizeof(struct mem_dqblk)); |
619 | freedqbuf(ddquot); | 624 | kfree(ddquot); |
620 | goto out; | 625 | goto out; |
621 | } | 626 | } |
622 | spin_lock(&dq_data_lock); | 627 | spin_lock(&dq_data_lock); |
@@ -627,7 +632,7 @@ int qtree_read_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | |||
627 | !dquot->dq_dqb.dqb_isoftlimit) | 632 | !dquot->dq_dqb.dqb_isoftlimit) |
628 | set_bit(DQ_FAKE_B, &dquot->dq_flags); | 633 | set_bit(DQ_FAKE_B, &dquot->dq_flags); |
629 | spin_unlock(&dq_data_lock); | 634 | spin_unlock(&dq_data_lock); |
630 | freedqbuf(ddquot); | 635 | kfree(ddquot); |
631 | out: | 636 | out: |
632 | dqstats.reads++; | 637 | dqstats.reads++; |
633 | return ret; | 638 | return ret; |
@@ -638,7 +643,8 @@ EXPORT_SYMBOL(qtree_read_dquot); | |||
638 | * the only one operating on dquot (thanks to dq_lock) */ | 643 | * the only one operating on dquot (thanks to dq_lock) */ |
639 | int qtree_release_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) | 644 | int qtree_release_dquot(struct qtree_mem_dqinfo *info, struct dquot *dquot) |
640 | { | 645 | { |
641 | if (test_bit(DQ_FAKE_B, &dquot->dq_flags) && !(dquot->dq_dqb.dqb_curinodes | dquot->dq_dqb.dqb_curspace)) | 646 | if (test_bit(DQ_FAKE_B, &dquot->dq_flags) && |
647 | !(dquot->dq_dqb.dqb_curinodes | dquot->dq_dqb.dqb_curspace)) | ||
642 | return qtree_delete_dquot(info, dquot); | 648 | return qtree_delete_dquot(info, dquot); |
643 | return 0; | 649 | return 0; |
644 | } | 650 | } |
diff --git a/fs/quota_tree.h b/fs/quota/quota_tree.h index a1ab8db81a51..a1ab8db81a51 100644 --- a/fs/quota_tree.h +++ b/fs/quota/quota_tree.h | |||
diff --git a/fs/quota_v1.c b/fs/quota/quota_v1.c index b4af1c69ad16..0edcf42b1778 100644 --- a/fs/quota_v1.c +++ b/fs/quota/quota_v1.c | |||
@@ -62,11 +62,14 @@ static int v1_read_dqblk(struct dquot *dquot) | |||
62 | 62 | ||
63 | /* Set structure to 0s in case read fails/is after end of file */ | 63 | /* Set structure to 0s in case read fails/is after end of file */ |
64 | memset(&dqblk, 0, sizeof(struct v1_disk_dqblk)); | 64 | memset(&dqblk, 0, sizeof(struct v1_disk_dqblk)); |
65 | dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk, sizeof(struct v1_disk_dqblk), v1_dqoff(dquot->dq_id)); | 65 | dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk, |
66 | sizeof(struct v1_disk_dqblk), v1_dqoff(dquot->dq_id)); | ||
66 | 67 | ||
67 | v1_disk2mem_dqblk(&dquot->dq_dqb, &dqblk); | 68 | v1_disk2mem_dqblk(&dquot->dq_dqb, &dqblk); |
68 | if (dquot->dq_dqb.dqb_bhardlimit == 0 && dquot->dq_dqb.dqb_bsoftlimit == 0 && | 69 | if (dquot->dq_dqb.dqb_bhardlimit == 0 && |
69 | dquot->dq_dqb.dqb_ihardlimit == 0 && dquot->dq_dqb.dqb_isoftlimit == 0) | 70 | dquot->dq_dqb.dqb_bsoftlimit == 0 && |
71 | dquot->dq_dqb.dqb_ihardlimit == 0 && | ||
72 | dquot->dq_dqb.dqb_isoftlimit == 0) | ||
70 | set_bit(DQ_FAKE_B, &dquot->dq_flags); | 73 | set_bit(DQ_FAKE_B, &dquot->dq_flags); |
71 | dqstats.reads++; | 74 | dqstats.reads++; |
72 | 75 | ||
@@ -81,13 +84,16 @@ static int v1_commit_dqblk(struct dquot *dquot) | |||
81 | 84 | ||
82 | v1_mem2disk_dqblk(&dqblk, &dquot->dq_dqb); | 85 | v1_mem2disk_dqblk(&dqblk, &dquot->dq_dqb); |
83 | if (dquot->dq_id == 0) { | 86 | if (dquot->dq_id == 0) { |
84 | dqblk.dqb_btime = sb_dqopt(dquot->dq_sb)->info[type].dqi_bgrace; | 87 | dqblk.dqb_btime = |
85 | dqblk.dqb_itime = sb_dqopt(dquot->dq_sb)->info[type].dqi_igrace; | 88 | sb_dqopt(dquot->dq_sb)->info[type].dqi_bgrace; |
89 | dqblk.dqb_itime = | ||
90 | sb_dqopt(dquot->dq_sb)->info[type].dqi_igrace; | ||
86 | } | 91 | } |
87 | ret = 0; | 92 | ret = 0; |
88 | if (sb_dqopt(dquot->dq_sb)->files[type]) | 93 | if (sb_dqopt(dquot->dq_sb)->files[type]) |
89 | ret = dquot->dq_sb->s_op->quota_write(dquot->dq_sb, type, (char *)&dqblk, | 94 | ret = dquot->dq_sb->s_op->quota_write(dquot->dq_sb, type, |
90 | sizeof(struct v1_disk_dqblk), v1_dqoff(dquot->dq_id)); | 95 | (char *)&dqblk, sizeof(struct v1_disk_dqblk), |
96 | v1_dqoff(dquot->dq_id)); | ||
91 | if (ret != sizeof(struct v1_disk_dqblk)) { | 97 | if (ret != sizeof(struct v1_disk_dqblk)) { |
92 | printk(KERN_WARNING "VFS: dquota write failed on dev %s\n", | 98 | printk(KERN_WARNING "VFS: dquota write failed on dev %s\n", |
93 | dquot->dq_sb->s_id); | 99 | dquot->dq_sb->s_id); |
@@ -130,15 +136,20 @@ static int v1_check_quota_file(struct super_block *sb, int type) | |||
130 | return 0; | 136 | return 0; |
131 | blocks = isize >> BLOCK_SIZE_BITS; | 137 | blocks = isize >> BLOCK_SIZE_BITS; |
132 | off = isize & (BLOCK_SIZE - 1); | 138 | off = isize & (BLOCK_SIZE - 1); |
133 | if ((blocks % sizeof(struct v1_disk_dqblk) * BLOCK_SIZE + off) % sizeof(struct v1_disk_dqblk)) | 139 | if ((blocks % sizeof(struct v1_disk_dqblk) * BLOCK_SIZE + off) % |
140 | sizeof(struct v1_disk_dqblk)) | ||
134 | return 0; | 141 | return 0; |
135 | /* Doublecheck whether we didn't get file with new format - with old quotactl() this could happen */ | 142 | /* Doublecheck whether we didn't get file with new format - with old |
136 | size = sb->s_op->quota_read(sb, type, (char *)&dqhead, sizeof(struct v2_disk_dqheader), 0); | 143 | * quotactl() this could happen */ |
144 | size = sb->s_op->quota_read(sb, type, (char *)&dqhead, | ||
145 | sizeof(struct v2_disk_dqheader), 0); | ||
137 | if (size != sizeof(struct v2_disk_dqheader)) | 146 | if (size != sizeof(struct v2_disk_dqheader)) |
138 | return 1; /* Probably not new format */ | 147 | return 1; /* Probably not new format */ |
139 | if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type]) | 148 | if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type]) |
140 | return 1; /* Definitely not new format */ | 149 | return 1; /* Definitely not new format */ |
141 | printk(KERN_INFO "VFS: %s: Refusing to turn on old quota format on given file. It probably contains newer quota format.\n", sb->s_id); | 150 | printk(KERN_INFO |
151 | "VFS: %s: Refusing to turn on old quota format on given file." | ||
152 | " It probably contains newer quota format.\n", sb->s_id); | ||
142 | return 0; /* Seems like a new format file -> refuse it */ | 153 | return 0; /* Seems like a new format file -> refuse it */ |
143 | } | 154 | } |
144 | 155 | ||
@@ -148,7 +159,9 @@ static int v1_read_file_info(struct super_block *sb, int type) | |||
148 | struct v1_disk_dqblk dqblk; | 159 | struct v1_disk_dqblk dqblk; |
149 | int ret; | 160 | int ret; |
150 | 161 | ||
151 | if ((ret = sb->s_op->quota_read(sb, type, (char *)&dqblk, sizeof(struct v1_disk_dqblk), v1_dqoff(0))) != sizeof(struct v1_disk_dqblk)) { | 162 | ret = sb->s_op->quota_read(sb, type, (char *)&dqblk, |
163 | sizeof(struct v1_disk_dqblk), v1_dqoff(0)); | ||
164 | if (ret != sizeof(struct v1_disk_dqblk)) { | ||
152 | if (ret >= 0) | 165 | if (ret >= 0) |
153 | ret = -EIO; | 166 | ret = -EIO; |
154 | goto out; | 167 | goto out; |
@@ -157,8 +170,10 @@ static int v1_read_file_info(struct super_block *sb, int type) | |||
157 | /* limits are stored as unsigned 32-bit data */ | 170 | /* limits are stored as unsigned 32-bit data */ |
158 | dqopt->info[type].dqi_maxblimit = 0xffffffff; | 171 | dqopt->info[type].dqi_maxblimit = 0xffffffff; |
159 | dqopt->info[type].dqi_maxilimit = 0xffffffff; | 172 | dqopt->info[type].dqi_maxilimit = 0xffffffff; |
160 | dqopt->info[type].dqi_igrace = dqblk.dqb_itime ? dqblk.dqb_itime : MAX_IQ_TIME; | 173 | dqopt->info[type].dqi_igrace = |
161 | dqopt->info[type].dqi_bgrace = dqblk.dqb_btime ? dqblk.dqb_btime : MAX_DQ_TIME; | 174 | dqblk.dqb_itime ? dqblk.dqb_itime : MAX_IQ_TIME; |
175 | dqopt->info[type].dqi_bgrace = | ||
176 | dqblk.dqb_btime ? dqblk.dqb_btime : MAX_DQ_TIME; | ||
162 | out: | 177 | out: |
163 | return ret; | 178 | return ret; |
164 | } | 179 | } |
@@ -170,8 +185,9 @@ static int v1_write_file_info(struct super_block *sb, int type) | |||
170 | int ret; | 185 | int ret; |
171 | 186 | ||
172 | dqopt->info[type].dqi_flags &= ~DQF_INFO_DIRTY; | 187 | dqopt->info[type].dqi_flags &= ~DQF_INFO_DIRTY; |
173 | if ((ret = sb->s_op->quota_read(sb, type, (char *)&dqblk, | 188 | ret = sb->s_op->quota_read(sb, type, (char *)&dqblk, |
174 | sizeof(struct v1_disk_dqblk), v1_dqoff(0))) != sizeof(struct v1_disk_dqblk)) { | 189 | sizeof(struct v1_disk_dqblk), v1_dqoff(0)); |
190 | if (ret != sizeof(struct v1_disk_dqblk)) { | ||
175 | if (ret >= 0) | 191 | if (ret >= 0) |
176 | ret = -EIO; | 192 | ret = -EIO; |
177 | goto out; | 193 | goto out; |
diff --git a/fs/quota_v2.c b/fs/quota/quota_v2.c index b618b563635c..a5475fb1ae44 100644 --- a/fs/quota_v2.c +++ b/fs/quota/quota_v2.c | |||
@@ -54,7 +54,8 @@ static int v2_check_quota_file(struct super_block *sb, int type) | |||
54 | static const uint quota_magics[] = V2_INITQMAGICS; | 54 | static const uint quota_magics[] = V2_INITQMAGICS; |
55 | static const uint quota_versions[] = V2_INITQVERSIONS; | 55 | static const uint quota_versions[] = V2_INITQVERSIONS; |
56 | 56 | ||
57 | size = sb->s_op->quota_read(sb, type, (char *)&dqhead, sizeof(struct v2_disk_dqheader), 0); | 57 | size = sb->s_op->quota_read(sb, type, (char *)&dqhead, |
58 | sizeof(struct v2_disk_dqheader), 0); | ||
58 | if (size != sizeof(struct v2_disk_dqheader)) { | 59 | if (size != sizeof(struct v2_disk_dqheader)) { |
59 | printk("quota_v2: failed read expected=%zd got=%zd\n", | 60 | printk("quota_v2: failed read expected=%zd got=%zd\n", |
60 | sizeof(struct v2_disk_dqheader), size); | 61 | sizeof(struct v2_disk_dqheader), size); |
diff --git a/fs/quotaio_v1.h b/fs/quota/quotaio_v1.h index 746654b5de70..746654b5de70 100644 --- a/fs/quotaio_v1.h +++ b/fs/quota/quotaio_v1.h | |||
diff --git a/fs/quotaio_v2.h b/fs/quota/quotaio_v2.h index 530fe580685c..530fe580685c 100644 --- a/fs/quotaio_v2.h +++ b/fs/quota/quotaio_v2.h | |||
diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c index 5d7c7ececa64..995ef1d6686c 100644 --- a/fs/ramfs/file-nommu.c +++ b/fs/ramfs/file-nommu.c | |||
@@ -18,7 +18,6 @@ | |||
18 | #include <linux/string.h> | 18 | #include <linux/string.h> |
19 | #include <linux/backing-dev.h> | 19 | #include <linux/backing-dev.h> |
20 | #include <linux/ramfs.h> | 20 | #include <linux/ramfs.h> |
21 | #include <linux/quotaops.h> | ||
22 | #include <linux/pagevec.h> | 21 | #include <linux/pagevec.h> |
23 | #include <linux/mman.h> | 22 | #include <linux/mman.h> |
24 | 23 | ||
@@ -205,11 +204,6 @@ static int ramfs_nommu_setattr(struct dentry *dentry, struct iattr *ia) | |||
205 | if (ret) | 204 | if (ret) |
206 | return ret; | 205 | return ret; |
207 | 206 | ||
208 | /* by providing our own setattr() method, we skip this quotaism */ | ||
209 | if ((old_ia_valid & ATTR_UID && ia->ia_uid != inode->i_uid) || | ||
210 | (old_ia_valid & ATTR_GID && ia->ia_gid != inode->i_gid)) | ||
211 | ret = DQUOT_TRANSFER(inode, ia) ? -EDQUOT : 0; | ||
212 | |||
213 | /* pick out size-changing events */ | 207 | /* pick out size-changing events */ |
214 | if (ia->ia_valid & ATTR_SIZE) { | 208 | if (ia->ia_valid & ATTR_SIZE) { |
215 | loff_t size = i_size_read(inode); | 209 | loff_t size = i_size_read(inode); |
diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c index 9fc228703ef0..e716161ab325 100644 --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c | |||
@@ -425,7 +425,7 @@ static void _reiserfs_free_block(struct reiserfs_transaction_handle *th, | |||
425 | 425 | ||
426 | journal_mark_dirty(th, s, sbh); | 426 | journal_mark_dirty(th, s, sbh); |
427 | if (for_unformatted) | 427 | if (for_unformatted) |
428 | DQUOT_FREE_BLOCK_NODIRTY(inode, 1); | 428 | vfs_dq_free_block_nodirty(inode, 1); |
429 | } | 429 | } |
430 | 430 | ||
431 | void reiserfs_free_block(struct reiserfs_transaction_handle *th, | 431 | void reiserfs_free_block(struct reiserfs_transaction_handle *th, |
@@ -1049,7 +1049,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1049 | amount_needed, hint->inode->i_uid); | 1049 | amount_needed, hint->inode->i_uid); |
1050 | #endif | 1050 | #endif |
1051 | quota_ret = | 1051 | quota_ret = |
1052 | DQUOT_ALLOC_BLOCK_NODIRTY(hint->inode, amount_needed); | 1052 | vfs_dq_alloc_block_nodirty(hint->inode, amount_needed); |
1053 | if (quota_ret) /* Quota exceeded? */ | 1053 | if (quota_ret) /* Quota exceeded? */ |
1054 | return QUOTA_EXCEEDED; | 1054 | return QUOTA_EXCEEDED; |
1055 | if (hint->preallocate && hint->prealloc_size) { | 1055 | if (hint->preallocate && hint->prealloc_size) { |
@@ -1058,8 +1058,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1058 | "reiserquota: allocating (prealloc) %d blocks id=%u", | 1058 | "reiserquota: allocating (prealloc) %d blocks id=%u", |
1059 | hint->prealloc_size, hint->inode->i_uid); | 1059 | hint->prealloc_size, hint->inode->i_uid); |
1060 | #endif | 1060 | #endif |
1061 | quota_ret = | 1061 | quota_ret = vfs_dq_prealloc_block_nodirty(hint->inode, |
1062 | DQUOT_PREALLOC_BLOCK_NODIRTY(hint->inode, | ||
1063 | hint->prealloc_size); | 1062 | hint->prealloc_size); |
1064 | if (quota_ret) | 1063 | if (quota_ret) |
1065 | hint->preallocate = hint->prealloc_size = 0; | 1064 | hint->preallocate = hint->prealloc_size = 0; |
@@ -1092,7 +1091,10 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1092 | nr_allocated, | 1091 | nr_allocated, |
1093 | hint->inode->i_uid); | 1092 | hint->inode->i_uid); |
1094 | #endif | 1093 | #endif |
1095 | DQUOT_FREE_BLOCK_NODIRTY(hint->inode, amount_needed + hint->prealloc_size - nr_allocated); /* Free not allocated blocks */ | 1094 | /* Free not allocated blocks */ |
1095 | vfs_dq_free_block_nodirty(hint->inode, | ||
1096 | amount_needed + hint->prealloc_size - | ||
1097 | nr_allocated); | ||
1096 | } | 1098 | } |
1097 | while (nr_allocated--) | 1099 | while (nr_allocated--) |
1098 | reiserfs_free_block(hint->th, hint->inode, | 1100 | reiserfs_free_block(hint->th, hint->inode, |
@@ -1123,7 +1125,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1123 | REISERFS_I(hint->inode)->i_prealloc_count, | 1125 | REISERFS_I(hint->inode)->i_prealloc_count, |
1124 | hint->inode->i_uid); | 1126 | hint->inode->i_uid); |
1125 | #endif | 1127 | #endif |
1126 | DQUOT_FREE_BLOCK_NODIRTY(hint->inode, amount_needed + | 1128 | vfs_dq_free_block_nodirty(hint->inode, amount_needed + |
1127 | hint->prealloc_size - nr_allocated - | 1129 | hint->prealloc_size - nr_allocated - |
1128 | REISERFS_I(hint->inode)-> | 1130 | REISERFS_I(hint->inode)-> |
1129 | i_prealloc_count); | 1131 | i_prealloc_count); |
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index b090d2dd2a8e..6fd0f47e45db 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
@@ -52,8 +52,8 @@ void reiserfs_delete_inode(struct inode *inode) | |||
52 | /* Do quota update inside a transaction for journaled quotas. We must do that | 52 | /* Do quota update inside a transaction for journaled quotas. We must do that |
53 | * after delete_object so that quota updates go into the same transaction as | 53 | * after delete_object so that quota updates go into the same transaction as |
54 | * stat data deletion */ | 54 | * stat data deletion */ |
55 | if (!err) | 55 | if (!err) |
56 | DQUOT_FREE_INODE(inode); | 56 | vfs_dq_free_inode(inode); |
57 | 57 | ||
58 | if (journal_end(&th, inode->i_sb, jbegin_count)) | 58 | if (journal_end(&th, inode->i_sb, jbegin_count)) |
59 | goto out; | 59 | goto out; |
@@ -1761,7 +1761,7 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, | |||
1761 | 1761 | ||
1762 | BUG_ON(!th->t_trans_id); | 1762 | BUG_ON(!th->t_trans_id); |
1763 | 1763 | ||
1764 | if (DQUOT_ALLOC_INODE(inode)) { | 1764 | if (vfs_dq_alloc_inode(inode)) { |
1765 | err = -EDQUOT; | 1765 | err = -EDQUOT; |
1766 | goto out_end_trans; | 1766 | goto out_end_trans; |
1767 | } | 1767 | } |
@@ -1957,12 +1957,12 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, | |||
1957 | INODE_PKEY(inode)->k_objectid = 0; | 1957 | INODE_PKEY(inode)->k_objectid = 0; |
1958 | 1958 | ||
1959 | /* Quota change must be inside a transaction for journaling */ | 1959 | /* Quota change must be inside a transaction for journaling */ |
1960 | DQUOT_FREE_INODE(inode); | 1960 | vfs_dq_free_inode(inode); |
1961 | 1961 | ||
1962 | out_end_trans: | 1962 | out_end_trans: |
1963 | journal_end(th, th->t_super, th->t_blocks_allocated); | 1963 | journal_end(th, th->t_super, th->t_blocks_allocated); |
1964 | /* Drop can be outside and it needs more credits so it's better to have it outside */ | 1964 | /* Drop can be outside and it needs more credits so it's better to have it outside */ |
1965 | DQUOT_DROP(inode); | 1965 | vfs_dq_drop(inode); |
1966 | inode->i_flags |= S_NOQUOTA; | 1966 | inode->i_flags |= S_NOQUOTA; |
1967 | make_bad_inode(inode); | 1967 | make_bad_inode(inode); |
1968 | 1968 | ||
@@ -3114,7 +3114,7 @@ int reiserfs_setattr(struct dentry *dentry, struct iattr *attr) | |||
3114 | if (error) | 3114 | if (error) |
3115 | goto out; | 3115 | goto out; |
3116 | error = | 3116 | error = |
3117 | DQUOT_TRANSFER(inode, attr) ? -EDQUOT : 0; | 3117 | vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; |
3118 | if (error) { | 3118 | if (error) { |
3119 | journal_end(&th, inode->i_sb, | 3119 | journal_end(&th, inode->i_sb, |
3120 | jbegin_count); | 3120 | jbegin_count); |
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c index 9d1070e741fc..efd4d720718e 100644 --- a/fs/reiserfs/namei.c +++ b/fs/reiserfs/namei.c | |||
@@ -552,7 +552,7 @@ static int reiserfs_add_entry(struct reiserfs_transaction_handle *th, | |||
552 | */ | 552 | */ |
553 | static int drop_new_inode(struct inode *inode) | 553 | static int drop_new_inode(struct inode *inode) |
554 | { | 554 | { |
555 | DQUOT_DROP(inode); | 555 | vfs_dq_drop(inode); |
556 | make_bad_inode(inode); | 556 | make_bad_inode(inode); |
557 | inode->i_flags |= S_NOQUOTA; | 557 | inode->i_flags |= S_NOQUOTA; |
558 | iput(inode); | 558 | iput(inode); |
@@ -560,7 +560,7 @@ static int drop_new_inode(struct inode *inode) | |||
560 | } | 560 | } |
561 | 561 | ||
562 | /* utility function that does setup for reiserfs_new_inode. | 562 | /* utility function that does setup for reiserfs_new_inode. |
563 | ** DQUOT_INIT needs lots of credits so it's better to have it | 563 | ** vfs_dq_init needs lots of credits so it's better to have it |
564 | ** outside of a transaction, so we had to pull some bits of | 564 | ** outside of a transaction, so we had to pull some bits of |
565 | ** reiserfs_new_inode out into this func. | 565 | ** reiserfs_new_inode out into this func. |
566 | */ | 566 | */ |
@@ -583,7 +583,7 @@ static int new_inode_init(struct inode *inode, struct inode *dir, int mode) | |||
583 | } else { | 583 | } else { |
584 | inode->i_gid = current_fsgid(); | 584 | inode->i_gid = current_fsgid(); |
585 | } | 585 | } |
586 | DQUOT_INIT(inode); | 586 | vfs_dq_init(inode); |
587 | return 0; | 587 | return 0; |
588 | } | 588 | } |
589 | 589 | ||
diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index e23303daa868..d036ee5b1c81 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c | |||
@@ -1262,7 +1262,7 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th, | |||
1262 | "reiserquota delete_item(): freeing %u, id=%u type=%c", | 1262 | "reiserquota delete_item(): freeing %u, id=%u type=%c", |
1263 | quota_cut_bytes, inode->i_uid, head2type(&s_ih)); | 1263 | quota_cut_bytes, inode->i_uid, head2type(&s_ih)); |
1264 | #endif | 1264 | #endif |
1265 | DQUOT_FREE_SPACE_NODIRTY(inode, quota_cut_bytes); | 1265 | vfs_dq_free_space_nodirty(inode, quota_cut_bytes); |
1266 | 1266 | ||
1267 | /* Return deleted body length */ | 1267 | /* Return deleted body length */ |
1268 | return ret_value; | 1268 | return ret_value; |
@@ -1346,7 +1346,7 @@ void reiserfs_delete_solid_item(struct reiserfs_transaction_handle *th, | |||
1346 | quota_cut_bytes, inode->i_uid, | 1346 | quota_cut_bytes, inode->i_uid, |
1347 | key2type(key)); | 1347 | key2type(key)); |
1348 | #endif | 1348 | #endif |
1349 | DQUOT_FREE_SPACE_NODIRTY(inode, | 1349 | vfs_dq_free_space_nodirty(inode, |
1350 | quota_cut_bytes); | 1350 | quota_cut_bytes); |
1351 | } | 1351 | } |
1352 | break; | 1352 | break; |
@@ -1696,7 +1696,7 @@ int reiserfs_cut_from_item(struct reiserfs_transaction_handle *th, | |||
1696 | "reiserquota cut_from_item(): freeing %u id=%u type=%c", | 1696 | "reiserquota cut_from_item(): freeing %u id=%u type=%c", |
1697 | quota_cut_bytes, inode->i_uid, '?'); | 1697 | quota_cut_bytes, inode->i_uid, '?'); |
1698 | #endif | 1698 | #endif |
1699 | DQUOT_FREE_SPACE_NODIRTY(inode, quota_cut_bytes); | 1699 | vfs_dq_free_space_nodirty(inode, quota_cut_bytes); |
1700 | return ret_value; | 1700 | return ret_value; |
1701 | } | 1701 | } |
1702 | 1702 | ||
@@ -1931,7 +1931,7 @@ int reiserfs_paste_into_item(struct reiserfs_transaction_handle *th, struct tree | |||
1931 | key2type(&(key->on_disk_key))); | 1931 | key2type(&(key->on_disk_key))); |
1932 | #endif | 1932 | #endif |
1933 | 1933 | ||
1934 | if (DQUOT_ALLOC_SPACE_NODIRTY(inode, pasted_size)) { | 1934 | if (vfs_dq_alloc_space_nodirty(inode, pasted_size)) { |
1935 | pathrelse(search_path); | 1935 | pathrelse(search_path); |
1936 | return -EDQUOT; | 1936 | return -EDQUOT; |
1937 | } | 1937 | } |
@@ -1987,7 +1987,7 @@ int reiserfs_paste_into_item(struct reiserfs_transaction_handle *th, struct tree | |||
1987 | pasted_size, inode->i_uid, | 1987 | pasted_size, inode->i_uid, |
1988 | key2type(&(key->on_disk_key))); | 1988 | key2type(&(key->on_disk_key))); |
1989 | #endif | 1989 | #endif |
1990 | DQUOT_FREE_SPACE_NODIRTY(inode, pasted_size); | 1990 | vfs_dq_free_space_nodirty(inode, pasted_size); |
1991 | return retval; | 1991 | return retval; |
1992 | } | 1992 | } |
1993 | 1993 | ||
@@ -2025,7 +2025,7 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th, | |||
2025 | #endif | 2025 | #endif |
2026 | /* We can't dirty inode here. It would be immediately written but | 2026 | /* We can't dirty inode here. It would be immediately written but |
2027 | * appropriate stat item isn't inserted yet... */ | 2027 | * appropriate stat item isn't inserted yet... */ |
2028 | if (DQUOT_ALLOC_SPACE_NODIRTY(inode, quota_bytes)) { | 2028 | if (vfs_dq_alloc_space_nodirty(inode, quota_bytes)) { |
2029 | pathrelse(path); | 2029 | pathrelse(path); |
2030 | return -EDQUOT; | 2030 | return -EDQUOT; |
2031 | } | 2031 | } |
@@ -2076,6 +2076,6 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th, | |||
2076 | quota_bytes, inode->i_uid, head2type(ih)); | 2076 | quota_bytes, inode->i_uid, head2type(ih)); |
2077 | #endif | 2077 | #endif |
2078 | if (inode) | 2078 | if (inode) |
2079 | DQUOT_FREE_SPACE_NODIRTY(inode, quota_bytes); | 2079 | vfs_dq_free_space_nodirty(inode, quota_bytes); |
2080 | return retval; | 2080 | return retval; |
2081 | } | 2081 | } |
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index d7519b951500..972250c62896 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c | |||
@@ -248,7 +248,7 @@ static int finish_unfinished(struct super_block *s) | |||
248 | retval = remove_save_link_only(s, &save_link_key, 0); | 248 | retval = remove_save_link_only(s, &save_link_key, 0); |
249 | continue; | 249 | continue; |
250 | } | 250 | } |
251 | DQUOT_INIT(inode); | 251 | vfs_dq_init(inode); |
252 | 252 | ||
253 | if (truncate && S_ISDIR(inode->i_mode)) { | 253 | if (truncate && S_ISDIR(inode->i_mode)) { |
254 | /* We got a truncate request for a dir which is impossible. | 254 | /* We got a truncate request for a dir which is impossible. |
@@ -628,8 +628,6 @@ static const struct super_operations reiserfs_sops = { | |||
628 | #ifdef CONFIG_QUOTA | 628 | #ifdef CONFIG_QUOTA |
629 | #define QTYPE2NAME(t) ((t)==USRQUOTA?"user":"group") | 629 | #define QTYPE2NAME(t) ((t)==USRQUOTA?"user":"group") |
630 | 630 | ||
631 | static int reiserfs_dquot_initialize(struct inode *, int); | ||
632 | static int reiserfs_dquot_drop(struct inode *); | ||
633 | static int reiserfs_write_dquot(struct dquot *); | 631 | static int reiserfs_write_dquot(struct dquot *); |
634 | static int reiserfs_acquire_dquot(struct dquot *); | 632 | static int reiserfs_acquire_dquot(struct dquot *); |
635 | static int reiserfs_release_dquot(struct dquot *); | 633 | static int reiserfs_release_dquot(struct dquot *); |
@@ -638,8 +636,8 @@ static int reiserfs_write_info(struct super_block *, int); | |||
638 | static int reiserfs_quota_on(struct super_block *, int, int, char *, int); | 636 | static int reiserfs_quota_on(struct super_block *, int, int, char *, int); |
639 | 637 | ||
640 | static struct dquot_operations reiserfs_quota_operations = { | 638 | static struct dquot_operations reiserfs_quota_operations = { |
641 | .initialize = reiserfs_dquot_initialize, | 639 | .initialize = dquot_initialize, |
642 | .drop = reiserfs_dquot_drop, | 640 | .drop = dquot_drop, |
643 | .alloc_space = dquot_alloc_space, | 641 | .alloc_space = dquot_alloc_space, |
644 | .alloc_inode = dquot_alloc_inode, | 642 | .alloc_inode = dquot_alloc_inode, |
645 | .free_space = dquot_free_space, | 643 | .free_space = dquot_free_space, |
@@ -1910,58 +1908,6 @@ static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
1910 | } | 1908 | } |
1911 | 1909 | ||
1912 | #ifdef CONFIG_QUOTA | 1910 | #ifdef CONFIG_QUOTA |
1913 | static int reiserfs_dquot_initialize(struct inode *inode, int type) | ||
1914 | { | ||
1915 | struct reiserfs_transaction_handle th; | ||
1916 | int ret, err; | ||
1917 | |||
1918 | /* We may create quota structure so we need to reserve enough blocks */ | ||
1919 | reiserfs_write_lock(inode->i_sb); | ||
1920 | ret = | ||
1921 | journal_begin(&th, inode->i_sb, | ||
1922 | 2 * REISERFS_QUOTA_INIT_BLOCKS(inode->i_sb)); | ||
1923 | if (ret) | ||
1924 | goto out; | ||
1925 | ret = dquot_initialize(inode, type); | ||
1926 | err = | ||
1927 | journal_end(&th, inode->i_sb, | ||
1928 | 2 * REISERFS_QUOTA_INIT_BLOCKS(inode->i_sb)); | ||
1929 | if (!ret && err) | ||
1930 | ret = err; | ||
1931 | out: | ||
1932 | reiserfs_write_unlock(inode->i_sb); | ||
1933 | return ret; | ||
1934 | } | ||
1935 | |||
1936 | static int reiserfs_dquot_drop(struct inode *inode) | ||
1937 | { | ||
1938 | struct reiserfs_transaction_handle th; | ||
1939 | int ret, err; | ||
1940 | |||
1941 | /* We may delete quota structure so we need to reserve enough blocks */ | ||
1942 | reiserfs_write_lock(inode->i_sb); | ||
1943 | ret = | ||
1944 | journal_begin(&th, inode->i_sb, | ||
1945 | 2 * REISERFS_QUOTA_DEL_BLOCKS(inode->i_sb)); | ||
1946 | if (ret) { | ||
1947 | /* | ||
1948 | * We call dquot_drop() anyway to at least release references | ||
1949 | * to quota structures so that umount does not hang. | ||
1950 | */ | ||
1951 | dquot_drop(inode); | ||
1952 | goto out; | ||
1953 | } | ||
1954 | ret = dquot_drop(inode); | ||
1955 | err = | ||
1956 | journal_end(&th, inode->i_sb, | ||
1957 | 2 * REISERFS_QUOTA_DEL_BLOCKS(inode->i_sb)); | ||
1958 | if (!ret && err) | ||
1959 | ret = err; | ||
1960 | out: | ||
1961 | reiserfs_write_unlock(inode->i_sb); | ||
1962 | return ret; | ||
1963 | } | ||
1964 | |||
1965 | static int reiserfs_write_dquot(struct dquot *dquot) | 1911 | static int reiserfs_write_dquot(struct dquot *dquot) |
1966 | { | 1912 | { |
1967 | struct reiserfs_transaction_handle th; | 1913 | struct reiserfs_transaction_handle th; |
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 1baafec64331..e52743e77000 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c | |||
@@ -60,14 +60,14 @@ | |||
60 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) | 60 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) |
61 | { | 61 | { |
62 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 62 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
63 | DQUOT_INIT(dir); | 63 | vfs_dq_init(dir); |
64 | return dir->i_op->create(dir, dentry, mode, NULL); | 64 | return dir->i_op->create(dir, dentry, mode, NULL); |
65 | } | 65 | } |
66 | 66 | ||
67 | static int xattr_mkdir(struct inode *dir, struct dentry *dentry, int mode) | 67 | static int xattr_mkdir(struct inode *dir, struct dentry *dentry, int mode) |
68 | { | 68 | { |
69 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 69 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
70 | DQUOT_INIT(dir); | 70 | vfs_dq_init(dir); |
71 | return dir->i_op->mkdir(dir, dentry, mode); | 71 | return dir->i_op->mkdir(dir, dentry, mode); |
72 | } | 72 | } |
73 | 73 | ||
@@ -79,7 +79,7 @@ static int xattr_unlink(struct inode *dir, struct dentry *dentry) | |||
79 | { | 79 | { |
80 | int error; | 80 | int error; |
81 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 81 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
82 | DQUOT_INIT(dir); | 82 | vfs_dq_init(dir); |
83 | 83 | ||
84 | mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD); | 84 | mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD); |
85 | error = dir->i_op->unlink(dir, dentry); | 85 | error = dir->i_op->unlink(dir, dentry); |
@@ -94,7 +94,7 @@ static int xattr_rmdir(struct inode *dir, struct dentry *dentry) | |||
94 | { | 94 | { |
95 | int error; | 95 | int error; |
96 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 96 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
97 | DQUOT_INIT(dir); | 97 | vfs_dq_init(dir); |
98 | 98 | ||
99 | mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD); | 99 | mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD); |
100 | dentry_unhash(dentry); | 100 | dentry_unhash(dentry); |
@@ -958,7 +958,7 @@ xattr_lookup_poison(struct dentry *dentry, struct qstr *q1, struct qstr *name) | |||
958 | return 1; | 958 | return 1; |
959 | } | 959 | } |
960 | 960 | ||
961 | static struct dentry_operations xattr_lookup_poison_ops = { | 961 | static const struct dentry_operations xattr_lookup_poison_ops = { |
962 | .d_compare = xattr_lookup_poison, | 962 | .d_compare = xattr_lookup_poison, |
963 | }; | 963 | }; |
964 | 964 | ||
diff --git a/fs/smbfs/dir.c b/fs/smbfs/dir.c index e7ddd0328ddc..3e4803b4427e 100644 --- a/fs/smbfs/dir.c +++ b/fs/smbfs/dir.c | |||
@@ -277,7 +277,7 @@ static int smb_hash_dentry(struct dentry *, struct qstr *); | |||
277 | static int smb_compare_dentry(struct dentry *, struct qstr *, struct qstr *); | 277 | static int smb_compare_dentry(struct dentry *, struct qstr *, struct qstr *); |
278 | static int smb_delete_dentry(struct dentry *); | 278 | static int smb_delete_dentry(struct dentry *); |
279 | 279 | ||
280 | static struct dentry_operations smbfs_dentry_operations = | 280 | static const struct dentry_operations smbfs_dentry_operations = |
281 | { | 281 | { |
282 | .d_revalidate = smb_lookup_validate, | 282 | .d_revalidate = smb_lookup_validate, |
283 | .d_hash = smb_hash_dentry, | 283 | .d_hash = smb_hash_dentry, |
@@ -285,7 +285,7 @@ static struct dentry_operations smbfs_dentry_operations = | |||
285 | .d_delete = smb_delete_dentry, | 285 | .d_delete = smb_delete_dentry, |
286 | }; | 286 | }; |
287 | 287 | ||
288 | static struct dentry_operations smbfs_dentry_operations_case = | 288 | static const struct dentry_operations smbfs_dentry_operations_case = |
289 | { | 289 | { |
290 | .d_revalidate = smb_lookup_validate, | 290 | .d_revalidate = smb_lookup_validate, |
291 | .d_delete = smb_delete_dentry, | 291 | .d_delete = smb_delete_dentry, |
diff --git a/fs/super.c b/fs/super.c index 6ce501447ada..2ba481518ba7 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -197,7 +197,7 @@ void deactivate_super(struct super_block *s) | |||
197 | if (atomic_dec_and_lock(&s->s_active, &sb_lock)) { | 197 | if (atomic_dec_and_lock(&s->s_active, &sb_lock)) { |
198 | s->s_count -= S_BIAS-1; | 198 | s->s_count -= S_BIAS-1; |
199 | spin_unlock(&sb_lock); | 199 | spin_unlock(&sb_lock); |
200 | DQUOT_OFF(s, 0); | 200 | vfs_dq_off(s, 0); |
201 | down_write(&s->s_umount); | 201 | down_write(&s->s_umount); |
202 | fs->kill_sb(s); | 202 | fs->kill_sb(s); |
203 | put_filesystem(fs); | 203 | put_filesystem(fs); |
@@ -266,7 +266,7 @@ EXPORT_SYMBOL(unlock_super); | |||
266 | void __fsync_super(struct super_block *sb) | 266 | void __fsync_super(struct super_block *sb) |
267 | { | 267 | { |
268 | sync_inodes_sb(sb, 0); | 268 | sync_inodes_sb(sb, 0); |
269 | DQUOT_SYNC(sb); | 269 | vfs_dq_sync(sb); |
270 | lock_super(sb); | 270 | lock_super(sb); |
271 | if (sb->s_dirt && sb->s_op->write_super) | 271 | if (sb->s_dirt && sb->s_op->write_super) |
272 | sb->s_op->write_super(sb); | 272 | sb->s_op->write_super(sb); |
@@ -655,7 +655,7 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
655 | mark_files_ro(sb); | 655 | mark_files_ro(sb); |
656 | else if (!fs_may_remount_ro(sb)) | 656 | else if (!fs_may_remount_ro(sb)) |
657 | return -EBUSY; | 657 | return -EBUSY; |
658 | retval = DQUOT_OFF(sb, 1); | 658 | retval = vfs_dq_off(sb, 1); |
659 | if (retval < 0 && retval != -ENOSYS) | 659 | if (retval < 0 && retval != -ENOSYS) |
660 | return -EBUSY; | 660 | return -EBUSY; |
661 | } | 661 | } |
@@ -670,11 +670,11 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
670 | } | 670 | } |
671 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); | 671 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); |
672 | if (remount_rw) | 672 | if (remount_rw) |
673 | DQUOT_ON_REMOUNT(sb); | 673 | vfs_dq_quota_on_remount(sb); |
674 | return 0; | 674 | return 0; |
675 | } | 675 | } |
676 | 676 | ||
677 | static void do_emergency_remount(unsigned long foo) | 677 | static void do_emergency_remount(struct work_struct *work) |
678 | { | 678 | { |
679 | struct super_block *sb; | 679 | struct super_block *sb; |
680 | 680 | ||
@@ -697,12 +697,19 @@ static void do_emergency_remount(unsigned long foo) | |||
697 | spin_lock(&sb_lock); | 697 | spin_lock(&sb_lock); |
698 | } | 698 | } |
699 | spin_unlock(&sb_lock); | 699 | spin_unlock(&sb_lock); |
700 | kfree(work); | ||
700 | printk("Emergency Remount complete\n"); | 701 | printk("Emergency Remount complete\n"); |
701 | } | 702 | } |
702 | 703 | ||
703 | void emergency_remount(void) | 704 | void emergency_remount(void) |
704 | { | 705 | { |
705 | pdflush_operation(do_emergency_remount, 0); | 706 | struct work_struct *work; |
707 | |||
708 | work = kmalloc(sizeof(*work), GFP_ATOMIC); | ||
709 | if (work) { | ||
710 | INIT_WORK(work, do_emergency_remount); | ||
711 | schedule_work(work); | ||
712 | } | ||
706 | } | 713 | } |
707 | 714 | ||
708 | /* | 715 | /* |
@@ -831,7 +838,8 @@ int get_sb_bdev(struct file_system_type *fs_type, | |||
831 | bdev->bd_super = s; | 838 | bdev->bd_super = s; |
832 | } | 839 | } |
833 | 840 | ||
834 | return simple_set_mnt(mnt, s); | 841 | simple_set_mnt(mnt, s); |
842 | return 0; | ||
835 | 843 | ||
836 | error_s: | 844 | error_s: |
837 | error = PTR_ERR(s); | 845 | error = PTR_ERR(s); |
@@ -877,7 +885,8 @@ int get_sb_nodev(struct file_system_type *fs_type, | |||
877 | return error; | 885 | return error; |
878 | } | 886 | } |
879 | s->s_flags |= MS_ACTIVE; | 887 | s->s_flags |= MS_ACTIVE; |
880 | return simple_set_mnt(mnt, s); | 888 | simple_set_mnt(mnt, s); |
889 | return 0; | ||
881 | } | 890 | } |
882 | 891 | ||
883 | EXPORT_SYMBOL(get_sb_nodev); | 892 | EXPORT_SYMBOL(get_sb_nodev); |
@@ -909,7 +918,8 @@ int get_sb_single(struct file_system_type *fs_type, | |||
909 | s->s_flags |= MS_ACTIVE; | 918 | s->s_flags |= MS_ACTIVE; |
910 | } | 919 | } |
911 | do_remount_sb(s, flags, data, 0); | 920 | do_remount_sb(s, flags, data, 0); |
912 | return simple_set_mnt(mnt, s); | 921 | simple_set_mnt(mnt, s); |
922 | return 0; | ||
913 | } | 923 | } |
914 | 924 | ||
915 | EXPORT_SYMBOL(get_sb_single); | 925 | EXPORT_SYMBOL(get_sb_single); |
@@ -25,7 +25,7 @@ static void do_sync(unsigned long wait) | |||
25 | { | 25 | { |
26 | wakeup_pdflush(0); | 26 | wakeup_pdflush(0); |
27 | sync_inodes(0); /* All mappings, inodes and their blockdevs */ | 27 | sync_inodes(0); /* All mappings, inodes and their blockdevs */ |
28 | DQUOT_SYNC(NULL); | 28 | vfs_dq_sync(NULL); |
29 | sync_supers(); /* Write the superblocks */ | 29 | sync_supers(); /* Write the superblocks */ |
30 | sync_filesystems(0); /* Start syncing the filesystems */ | 30 | sync_filesystems(0); /* Start syncing the filesystems */ |
31 | sync_filesystems(wait); /* Waitingly sync the filesystems */ | 31 | sync_filesystems(wait); /* Waitingly sync the filesystems */ |
@@ -42,9 +42,21 @@ SYSCALL_DEFINE0(sync) | |||
42 | return 0; | 42 | return 0; |
43 | } | 43 | } |
44 | 44 | ||
45 | static void do_sync_work(struct work_struct *work) | ||
46 | { | ||
47 | do_sync(0); | ||
48 | kfree(work); | ||
49 | } | ||
50 | |||
45 | void emergency_sync(void) | 51 | void emergency_sync(void) |
46 | { | 52 | { |
47 | pdflush_operation(do_sync, 0); | 53 | struct work_struct *work; |
54 | |||
55 | work = kmalloc(sizeof(*work), GFP_ATOMIC); | ||
56 | if (work) { | ||
57 | INIT_WORK(work, do_sync_work); | ||
58 | schedule_work(work); | ||
59 | } | ||
48 | } | 60 | } |
49 | 61 | ||
50 | /* | 62 | /* |
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index f2c478c3424e..07703d3ff4a1 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c | |||
@@ -21,15 +21,28 @@ | |||
21 | #include <linux/module.h> | 21 | #include <linux/module.h> |
22 | #include <linux/slab.h> | 22 | #include <linux/slab.h> |
23 | #include <linux/mutex.h> | 23 | #include <linux/mutex.h> |
24 | #include <linux/mm.h> | ||
24 | 25 | ||
25 | #include <asm/uaccess.h> | 26 | #include <asm/uaccess.h> |
26 | 27 | ||
27 | #include "sysfs.h" | 28 | #include "sysfs.h" |
28 | 29 | ||
30 | /* | ||
31 | * There's one bin_buffer for each open file. | ||
32 | * | ||
33 | * filp->private_data points to bin_buffer and | ||
34 | * sysfs_dirent->s_bin_attr.buffers points to a the bin_buffer s | ||
35 | * sysfs_dirent->s_bin_attr.buffers is protected by sysfs_bin_lock | ||
36 | */ | ||
37 | static DEFINE_MUTEX(sysfs_bin_lock); | ||
38 | |||
29 | struct bin_buffer { | 39 | struct bin_buffer { |
30 | struct mutex mutex; | 40 | struct mutex mutex; |
31 | void *buffer; | 41 | void *buffer; |
32 | int mmapped; | 42 | int mmapped; |
43 | struct vm_operations_struct *vm_ops; | ||
44 | struct file *file; | ||
45 | struct hlist_node list; | ||
33 | }; | 46 | }; |
34 | 47 | ||
35 | static int | 48 | static int |
@@ -168,6 +181,175 @@ out_free: | |||
168 | return count; | 181 | return count; |
169 | } | 182 | } |
170 | 183 | ||
184 | static void bin_vma_open(struct vm_area_struct *vma) | ||
185 | { | ||
186 | struct file *file = vma->vm_file; | ||
187 | struct bin_buffer *bb = file->private_data; | ||
188 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
189 | |||
190 | if (!bb->vm_ops || !bb->vm_ops->open) | ||
191 | return; | ||
192 | |||
193 | if (!sysfs_get_active_two(attr_sd)) | ||
194 | return; | ||
195 | |||
196 | bb->vm_ops->open(vma); | ||
197 | |||
198 | sysfs_put_active_two(attr_sd); | ||
199 | } | ||
200 | |||
201 | static void bin_vma_close(struct vm_area_struct *vma) | ||
202 | { | ||
203 | struct file *file = vma->vm_file; | ||
204 | struct bin_buffer *bb = file->private_data; | ||
205 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
206 | |||
207 | if (!bb->vm_ops || !bb->vm_ops->close) | ||
208 | return; | ||
209 | |||
210 | if (!sysfs_get_active_two(attr_sd)) | ||
211 | return; | ||
212 | |||
213 | bb->vm_ops->close(vma); | ||
214 | |||
215 | sysfs_put_active_two(attr_sd); | ||
216 | } | ||
217 | |||
218 | static int bin_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | ||
219 | { | ||
220 | struct file *file = vma->vm_file; | ||
221 | struct bin_buffer *bb = file->private_data; | ||
222 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
223 | int ret; | ||
224 | |||
225 | if (!bb->vm_ops || !bb->vm_ops->fault) | ||
226 | return VM_FAULT_SIGBUS; | ||
227 | |||
228 | if (!sysfs_get_active_two(attr_sd)) | ||
229 | return VM_FAULT_SIGBUS; | ||
230 | |||
231 | ret = bb->vm_ops->fault(vma, vmf); | ||
232 | |||
233 | sysfs_put_active_two(attr_sd); | ||
234 | return ret; | ||
235 | } | ||
236 | |||
237 | static int bin_page_mkwrite(struct vm_area_struct *vma, struct page *page) | ||
238 | { | ||
239 | struct file *file = vma->vm_file; | ||
240 | struct bin_buffer *bb = file->private_data; | ||
241 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
242 | int ret; | ||
243 | |||
244 | if (!bb->vm_ops) | ||
245 | return -EINVAL; | ||
246 | |||
247 | if (!bb->vm_ops->page_mkwrite) | ||
248 | return 0; | ||
249 | |||
250 | if (!sysfs_get_active_two(attr_sd)) | ||
251 | return -EINVAL; | ||
252 | |||
253 | ret = bb->vm_ops->page_mkwrite(vma, page); | ||
254 | |||
255 | sysfs_put_active_two(attr_sd); | ||
256 | return ret; | ||
257 | } | ||
258 | |||
259 | static int bin_access(struct vm_area_struct *vma, unsigned long addr, | ||
260 | void *buf, int len, int write) | ||
261 | { | ||
262 | struct file *file = vma->vm_file; | ||
263 | struct bin_buffer *bb = file->private_data; | ||
264 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
265 | int ret; | ||
266 | |||
267 | if (!bb->vm_ops || !bb->vm_ops->access) | ||
268 | return -EINVAL; | ||
269 | |||
270 | if (!sysfs_get_active_two(attr_sd)) | ||
271 | return -EINVAL; | ||
272 | |||
273 | ret = bb->vm_ops->access(vma, addr, buf, len, write); | ||
274 | |||
275 | sysfs_put_active_two(attr_sd); | ||
276 | return ret; | ||
277 | } | ||
278 | |||
279 | #ifdef CONFIG_NUMA | ||
280 | static int bin_set_policy(struct vm_area_struct *vma, struct mempolicy *new) | ||
281 | { | ||
282 | struct file *file = vma->vm_file; | ||
283 | struct bin_buffer *bb = file->private_data; | ||
284 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
285 | int ret; | ||
286 | |||
287 | if (!bb->vm_ops || !bb->vm_ops->set_policy) | ||
288 | return 0; | ||
289 | |||
290 | if (!sysfs_get_active_two(attr_sd)) | ||
291 | return -EINVAL; | ||
292 | |||
293 | ret = bb->vm_ops->set_policy(vma, new); | ||
294 | |||
295 | sysfs_put_active_two(attr_sd); | ||
296 | return ret; | ||
297 | } | ||
298 | |||
299 | static struct mempolicy *bin_get_policy(struct vm_area_struct *vma, | ||
300 | unsigned long addr) | ||
301 | { | ||
302 | struct file *file = vma->vm_file; | ||
303 | struct bin_buffer *bb = file->private_data; | ||
304 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
305 | struct mempolicy *pol; | ||
306 | |||
307 | if (!bb->vm_ops || !bb->vm_ops->get_policy) | ||
308 | return vma->vm_policy; | ||
309 | |||
310 | if (!sysfs_get_active_two(attr_sd)) | ||
311 | return vma->vm_policy; | ||
312 | |||
313 | pol = bb->vm_ops->get_policy(vma, addr); | ||
314 | |||
315 | sysfs_put_active_two(attr_sd); | ||
316 | return pol; | ||
317 | } | ||
318 | |||
319 | static int bin_migrate(struct vm_area_struct *vma, const nodemask_t *from, | ||
320 | const nodemask_t *to, unsigned long flags) | ||
321 | { | ||
322 | struct file *file = vma->vm_file; | ||
323 | struct bin_buffer *bb = file->private_data; | ||
324 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
325 | int ret; | ||
326 | |||
327 | if (!bb->vm_ops || !bb->vm_ops->migrate) | ||
328 | return 0; | ||
329 | |||
330 | if (!sysfs_get_active_two(attr_sd)) | ||
331 | return 0; | ||
332 | |||
333 | ret = bb->vm_ops->migrate(vma, from, to, flags); | ||
334 | |||
335 | sysfs_put_active_two(attr_sd); | ||
336 | return ret; | ||
337 | } | ||
338 | #endif | ||
339 | |||
340 | static struct vm_operations_struct bin_vm_ops = { | ||
341 | .open = bin_vma_open, | ||
342 | .close = bin_vma_close, | ||
343 | .fault = bin_fault, | ||
344 | .page_mkwrite = bin_page_mkwrite, | ||
345 | .access = bin_access, | ||
346 | #ifdef CONFIG_NUMA | ||
347 | .set_policy = bin_set_policy, | ||
348 | .get_policy = bin_get_policy, | ||
349 | .migrate = bin_migrate, | ||
350 | #endif | ||
351 | }; | ||
352 | |||
171 | static int mmap(struct file *file, struct vm_area_struct *vma) | 353 | static int mmap(struct file *file, struct vm_area_struct *vma) |
172 | { | 354 | { |
173 | struct bin_buffer *bb = file->private_data; | 355 | struct bin_buffer *bb = file->private_data; |
@@ -179,18 +361,37 @@ static int mmap(struct file *file, struct vm_area_struct *vma) | |||
179 | mutex_lock(&bb->mutex); | 361 | mutex_lock(&bb->mutex); |
180 | 362 | ||
181 | /* need attr_sd for attr, its parent for kobj */ | 363 | /* need attr_sd for attr, its parent for kobj */ |
364 | rc = -ENODEV; | ||
182 | if (!sysfs_get_active_two(attr_sd)) | 365 | if (!sysfs_get_active_two(attr_sd)) |
183 | return -ENODEV; | 366 | goto out_unlock; |
184 | 367 | ||
185 | rc = -EINVAL; | 368 | rc = -EINVAL; |
186 | if (attr->mmap) | 369 | if (!attr->mmap) |
187 | rc = attr->mmap(kobj, attr, vma); | 370 | goto out_put; |
371 | |||
372 | rc = attr->mmap(kobj, attr, vma); | ||
373 | if (rc) | ||
374 | goto out_put; | ||
188 | 375 | ||
189 | if (rc == 0 && !bb->mmapped) | 376 | /* |
190 | bb->mmapped = 1; | 377 | * PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup() |
191 | else | 378 | * to satisfy versions of X which crash if the mmap fails: that |
192 | sysfs_put_active_two(attr_sd); | 379 | * substitutes a new vm_file, and we don't then want bin_vm_ops. |
380 | */ | ||
381 | if (vma->vm_file != file) | ||
382 | goto out_put; | ||
193 | 383 | ||
384 | rc = -EINVAL; | ||
385 | if (bb->mmapped && bb->vm_ops != vma->vm_ops) | ||
386 | goto out_put; | ||
387 | |||
388 | rc = 0; | ||
389 | bb->mmapped = 1; | ||
390 | bb->vm_ops = vma->vm_ops; | ||
391 | vma->vm_ops = &bin_vm_ops; | ||
392 | out_put: | ||
393 | sysfs_put_active_two(attr_sd); | ||
394 | out_unlock: | ||
194 | mutex_unlock(&bb->mutex); | 395 | mutex_unlock(&bb->mutex); |
195 | 396 | ||
196 | return rc; | 397 | return rc; |
@@ -223,8 +424,13 @@ static int open(struct inode * inode, struct file * file) | |||
223 | goto err_out; | 424 | goto err_out; |
224 | 425 | ||
225 | mutex_init(&bb->mutex); | 426 | mutex_init(&bb->mutex); |
427 | bb->file = file; | ||
226 | file->private_data = bb; | 428 | file->private_data = bb; |
227 | 429 | ||
430 | mutex_lock(&sysfs_bin_lock); | ||
431 | hlist_add_head(&bb->list, &attr_sd->s_bin_attr.buffers); | ||
432 | mutex_unlock(&sysfs_bin_lock); | ||
433 | |||
228 | /* open succeeded, put active references */ | 434 | /* open succeeded, put active references */ |
229 | sysfs_put_active_two(attr_sd); | 435 | sysfs_put_active_two(attr_sd); |
230 | return 0; | 436 | return 0; |
@@ -237,11 +443,12 @@ static int open(struct inode * inode, struct file * file) | |||
237 | 443 | ||
238 | static int release(struct inode * inode, struct file * file) | 444 | static int release(struct inode * inode, struct file * file) |
239 | { | 445 | { |
240 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
241 | struct bin_buffer *bb = file->private_data; | 446 | struct bin_buffer *bb = file->private_data; |
242 | 447 | ||
243 | if (bb->mmapped) | 448 | mutex_lock(&sysfs_bin_lock); |
244 | sysfs_put_active_two(attr_sd); | 449 | hlist_del(&bb->list); |
450 | mutex_unlock(&sysfs_bin_lock); | ||
451 | |||
245 | kfree(bb->buffer); | 452 | kfree(bb->buffer); |
246 | kfree(bb); | 453 | kfree(bb); |
247 | return 0; | 454 | return 0; |
@@ -256,6 +463,26 @@ const struct file_operations bin_fops = { | |||
256 | .release = release, | 463 | .release = release, |
257 | }; | 464 | }; |
258 | 465 | ||
466 | |||
467 | void unmap_bin_file(struct sysfs_dirent *attr_sd) | ||
468 | { | ||
469 | struct bin_buffer *bb; | ||
470 | struct hlist_node *tmp; | ||
471 | |||
472 | if (sysfs_type(attr_sd) != SYSFS_KOBJ_BIN_ATTR) | ||
473 | return; | ||
474 | |||
475 | mutex_lock(&sysfs_bin_lock); | ||
476 | |||
477 | hlist_for_each_entry(bb, tmp, &attr_sd->s_bin_attr.buffers, list) { | ||
478 | struct inode *inode = bb->file->f_path.dentry->d_inode; | ||
479 | |||
480 | unmap_mapping_range(inode->i_mapping, 0, 0, 1); | ||
481 | } | ||
482 | |||
483 | mutex_unlock(&sysfs_bin_lock); | ||
484 | } | ||
485 | |||
259 | /** | 486 | /** |
260 | * sysfs_create_bin_file - create binary file for object. | 487 | * sysfs_create_bin_file - create binary file for object. |
261 | * @kobj: object. | 488 | * @kobj: object. |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 82d3b79d0e08..d88d0fac9fa5 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -302,7 +302,7 @@ static void sysfs_d_iput(struct dentry * dentry, struct inode * inode) | |||
302 | iput(inode); | 302 | iput(inode); |
303 | } | 303 | } |
304 | 304 | ||
305 | static struct dentry_operations sysfs_dentry_ops = { | 305 | static const struct dentry_operations sysfs_dentry_ops = { |
306 | .d_iput = sysfs_d_iput, | 306 | .d_iput = sysfs_d_iput, |
307 | }; | 307 | }; |
308 | 308 | ||
@@ -434,6 +434,26 @@ int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) | |||
434 | } | 434 | } |
435 | 435 | ||
436 | /** | 436 | /** |
437 | * sysfs_pathname - return full path to sysfs dirent | ||
438 | * @sd: sysfs_dirent whose path we want | ||
439 | * @path: caller allocated buffer | ||
440 | * | ||
441 | * Gives the name "/" to the sysfs_root entry; any path returned | ||
442 | * is relative to wherever sysfs is mounted. | ||
443 | * | ||
444 | * XXX: does no error checking on @path size | ||
445 | */ | ||
446 | static char *sysfs_pathname(struct sysfs_dirent *sd, char *path) | ||
447 | { | ||
448 | if (sd->s_parent) { | ||
449 | sysfs_pathname(sd->s_parent, path); | ||
450 | strcat(path, "/"); | ||
451 | } | ||
452 | strcat(path, sd->s_name); | ||
453 | return path; | ||
454 | } | ||
455 | |||
456 | /** | ||
437 | * sysfs_add_one - add sysfs_dirent to parent | 457 | * sysfs_add_one - add sysfs_dirent to parent |
438 | * @acxt: addrm context to use | 458 | * @acxt: addrm context to use |
439 | * @sd: sysfs_dirent to be added | 459 | * @sd: sysfs_dirent to be added |
@@ -458,8 +478,16 @@ int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) | |||
458 | int ret; | 478 | int ret; |
459 | 479 | ||
460 | ret = __sysfs_add_one(acxt, sd); | 480 | ret = __sysfs_add_one(acxt, sd); |
461 | WARN(ret == -EEXIST, KERN_WARNING "sysfs: duplicate filename '%s' " | 481 | if (ret == -EEXIST) { |
462 | "can not be created\n", sd->s_name); | 482 | char *path = kzalloc(PATH_MAX, GFP_KERNEL); |
483 | WARN(1, KERN_WARNING | ||
484 | "sysfs: cannot create duplicate filename '%s'\n", | ||
485 | (path == NULL) ? sd->s_name : | ||
486 | strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"), | ||
487 | sd->s_name)); | ||
488 | kfree(path); | ||
489 | } | ||
490 | |||
463 | return ret; | 491 | return ret; |
464 | } | 492 | } |
465 | 493 | ||
@@ -581,6 +609,7 @@ void sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt) | |||
581 | 609 | ||
582 | sysfs_drop_dentry(sd); | 610 | sysfs_drop_dentry(sd); |
583 | sysfs_deactivate(sd); | 611 | sysfs_deactivate(sd); |
612 | unmap_bin_file(sd); | ||
584 | sysfs_put(sd); | 613 | sysfs_put(sd); |
585 | } | 614 | } |
586 | } | 615 | } |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 1f4a3f877262..289c43a47263 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
@@ -659,13 +659,16 @@ void sysfs_remove_file_from_group(struct kobject *kobj, | |||
659 | EXPORT_SYMBOL_GPL(sysfs_remove_file_from_group); | 659 | EXPORT_SYMBOL_GPL(sysfs_remove_file_from_group); |
660 | 660 | ||
661 | struct sysfs_schedule_callback_struct { | 661 | struct sysfs_schedule_callback_struct { |
662 | struct kobject *kobj; | 662 | struct list_head workq_list; |
663 | struct kobject *kobj; | ||
663 | void (*func)(void *); | 664 | void (*func)(void *); |
664 | void *data; | 665 | void *data; |
665 | struct module *owner; | 666 | struct module *owner; |
666 | struct work_struct work; | 667 | struct work_struct work; |
667 | }; | 668 | }; |
668 | 669 | ||
670 | static DEFINE_MUTEX(sysfs_workq_mutex); | ||
671 | static LIST_HEAD(sysfs_workq); | ||
669 | static void sysfs_schedule_callback_work(struct work_struct *work) | 672 | static void sysfs_schedule_callback_work(struct work_struct *work) |
670 | { | 673 | { |
671 | struct sysfs_schedule_callback_struct *ss = container_of(work, | 674 | struct sysfs_schedule_callback_struct *ss = container_of(work, |
@@ -674,6 +677,9 @@ static void sysfs_schedule_callback_work(struct work_struct *work) | |||
674 | (ss->func)(ss->data); | 677 | (ss->func)(ss->data); |
675 | kobject_put(ss->kobj); | 678 | kobject_put(ss->kobj); |
676 | module_put(ss->owner); | 679 | module_put(ss->owner); |
680 | mutex_lock(&sysfs_workq_mutex); | ||
681 | list_del(&ss->workq_list); | ||
682 | mutex_unlock(&sysfs_workq_mutex); | ||
677 | kfree(ss); | 683 | kfree(ss); |
678 | } | 684 | } |
679 | 685 | ||
@@ -695,15 +701,25 @@ static void sysfs_schedule_callback_work(struct work_struct *work) | |||
695 | * until @func returns. | 701 | * until @func returns. |
696 | * | 702 | * |
697 | * Returns 0 if the request was submitted, -ENOMEM if storage could not | 703 | * Returns 0 if the request was submitted, -ENOMEM if storage could not |
698 | * be allocated, -ENODEV if a reference to @owner isn't available. | 704 | * be allocated, -ENODEV if a reference to @owner isn't available, |
705 | * -EAGAIN if a callback has already been scheduled for @kobj. | ||
699 | */ | 706 | */ |
700 | int sysfs_schedule_callback(struct kobject *kobj, void (*func)(void *), | 707 | int sysfs_schedule_callback(struct kobject *kobj, void (*func)(void *), |
701 | void *data, struct module *owner) | 708 | void *data, struct module *owner) |
702 | { | 709 | { |
703 | struct sysfs_schedule_callback_struct *ss; | 710 | struct sysfs_schedule_callback_struct *ss, *tmp; |
704 | 711 | ||
705 | if (!try_module_get(owner)) | 712 | if (!try_module_get(owner)) |
706 | return -ENODEV; | 713 | return -ENODEV; |
714 | |||
715 | mutex_lock(&sysfs_workq_mutex); | ||
716 | list_for_each_entry_safe(ss, tmp, &sysfs_workq, workq_list) | ||
717 | if (ss->kobj == kobj) { | ||
718 | mutex_unlock(&sysfs_workq_mutex); | ||
719 | return -EAGAIN; | ||
720 | } | ||
721 | mutex_unlock(&sysfs_workq_mutex); | ||
722 | |||
707 | ss = kmalloc(sizeof(*ss), GFP_KERNEL); | 723 | ss = kmalloc(sizeof(*ss), GFP_KERNEL); |
708 | if (!ss) { | 724 | if (!ss) { |
709 | module_put(owner); | 725 | module_put(owner); |
@@ -715,6 +731,10 @@ int sysfs_schedule_callback(struct kobject *kobj, void (*func)(void *), | |||
715 | ss->data = data; | 731 | ss->data = data; |
716 | ss->owner = owner; | 732 | ss->owner = owner; |
717 | INIT_WORK(&ss->work, sysfs_schedule_callback_work); | 733 | INIT_WORK(&ss->work, sysfs_schedule_callback_work); |
734 | INIT_LIST_HEAD(&ss->workq_list); | ||
735 | mutex_lock(&sysfs_workq_mutex); | ||
736 | list_add_tail(&ss->workq_list, &sysfs_workq); | ||
737 | mutex_unlock(&sysfs_workq_mutex); | ||
718 | schedule_work(&ss->work); | 738 | schedule_work(&ss->work); |
719 | return 0; | 739 | return 0; |
720 | } | 740 | } |
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index dfa3d94cfc74..555f0ff988df 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c | |||
@@ -147,6 +147,7 @@ static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode) | |||
147 | { | 147 | { |
148 | struct bin_attribute *bin_attr; | 148 | struct bin_attribute *bin_attr; |
149 | 149 | ||
150 | inode->i_private = sysfs_get(sd); | ||
150 | inode->i_mapping->a_ops = &sysfs_aops; | 151 | inode->i_mapping->a_ops = &sysfs_aops; |
151 | inode->i_mapping->backing_dev_info = &sysfs_backing_dev_info; | 152 | inode->i_mapping->backing_dev_info = &sysfs_backing_dev_info; |
152 | inode->i_op = &sysfs_inode_operations; | 153 | inode->i_op = &sysfs_inode_operations; |
@@ -214,6 +215,22 @@ struct inode * sysfs_get_inode(struct sysfs_dirent *sd) | |||
214 | return inode; | 215 | return inode; |
215 | } | 216 | } |
216 | 217 | ||
218 | /* | ||
219 | * The sysfs_dirent serves as both an inode and a directory entry for sysfs. | ||
220 | * To prevent the sysfs inode numbers from being freed prematurely we take a | ||
221 | * reference to sysfs_dirent from the sysfs inode. A | ||
222 | * super_operations.delete_inode() implementation is needed to drop that | ||
223 | * reference upon inode destruction. | ||
224 | */ | ||
225 | void sysfs_delete_inode(struct inode *inode) | ||
226 | { | ||
227 | struct sysfs_dirent *sd = inode->i_private; | ||
228 | |||
229 | truncate_inode_pages(&inode->i_data, 0); | ||
230 | clear_inode(inode); | ||
231 | sysfs_put(sd); | ||
232 | } | ||
233 | |||
217 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name) | 234 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name) |
218 | { | 235 | { |
219 | struct sysfs_addrm_cxt acxt; | 236 | struct sysfs_addrm_cxt acxt; |
diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index ab343e371d64..49749955ccaf 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c | |||
@@ -17,11 +17,10 @@ | |||
17 | #include <linux/pagemap.h> | 17 | #include <linux/pagemap.h> |
18 | #include <linux/init.h> | 18 | #include <linux/init.h> |
19 | #include <linux/module.h> | 19 | #include <linux/module.h> |
20 | #include <linux/magic.h> | ||
20 | 21 | ||
21 | #include "sysfs.h" | 22 | #include "sysfs.h" |
22 | 23 | ||
23 | /* Random magic number */ | ||
24 | #define SYSFS_MAGIC 0x62656572 | ||
25 | 24 | ||
26 | static struct vfsmount *sysfs_mount; | 25 | static struct vfsmount *sysfs_mount; |
27 | struct super_block * sysfs_sb = NULL; | 26 | struct super_block * sysfs_sb = NULL; |
@@ -30,6 +29,7 @@ struct kmem_cache *sysfs_dir_cachep; | |||
30 | static const struct super_operations sysfs_ops = { | 29 | static const struct super_operations sysfs_ops = { |
31 | .statfs = simple_statfs, | 30 | .statfs = simple_statfs, |
32 | .drop_inode = generic_delete_inode, | 31 | .drop_inode = generic_delete_inode, |
32 | .delete_inode = sysfs_delete_inode, | ||
33 | }; | 33 | }; |
34 | 34 | ||
35 | struct sysfs_dirent sysfs_root = { | 35 | struct sysfs_dirent sysfs_root = { |
@@ -53,7 +53,9 @@ static int sysfs_fill_super(struct super_block *sb, void *data, int silent) | |||
53 | sysfs_sb = sb; | 53 | sysfs_sb = sb; |
54 | 54 | ||
55 | /* get root inode, initialize and unlock it */ | 55 | /* get root inode, initialize and unlock it */ |
56 | mutex_lock(&sysfs_mutex); | ||
56 | inode = sysfs_get_inode(&sysfs_root); | 57 | inode = sysfs_get_inode(&sysfs_root); |
58 | mutex_unlock(&sysfs_mutex); | ||
57 | if (!inode) { | 59 | if (!inode) { |
58 | pr_debug("sysfs: could not get root inode\n"); | 60 | pr_debug("sysfs: could not get root inode\n"); |
59 | return -ENOMEM; | 61 | return -ENOMEM; |
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index 93c6d6b27c4d..3fa0d98481e2 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
@@ -28,6 +28,7 @@ struct sysfs_elem_attr { | |||
28 | 28 | ||
29 | struct sysfs_elem_bin_attr { | 29 | struct sysfs_elem_bin_attr { |
30 | struct bin_attribute *bin_attr; | 30 | struct bin_attribute *bin_attr; |
31 | struct hlist_head buffers; | ||
31 | }; | 32 | }; |
32 | 33 | ||
33 | /* | 34 | /* |
@@ -145,6 +146,7 @@ static inline void __sysfs_put(struct sysfs_dirent *sd) | |||
145 | * inode.c | 146 | * inode.c |
146 | */ | 147 | */ |
147 | struct inode *sysfs_get_inode(struct sysfs_dirent *sd); | 148 | struct inode *sysfs_get_inode(struct sysfs_dirent *sd); |
149 | void sysfs_delete_inode(struct inode *inode); | ||
148 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); | 150 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); |
149 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name); | 151 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name); |
150 | int sysfs_inode_init(void); | 152 | int sysfs_inode_init(void); |
@@ -163,6 +165,7 @@ int sysfs_add_file_mode(struct sysfs_dirent *dir_sd, | |||
163 | * bin.c | 165 | * bin.c |
164 | */ | 166 | */ |
165 | extern const struct file_operations bin_fops; | 167 | extern const struct file_operations bin_fops; |
168 | void unmap_bin_file(struct sysfs_dirent *attr_sd); | ||
166 | 169 | ||
167 | /* | 170 | /* |
168 | * symlink.c | 171 | * symlink.c |
diff --git a/fs/sysv/namei.c b/fs/sysv/namei.c index a1f1ef33e81c..33e047b59b8d 100644 --- a/fs/sysv/namei.c +++ b/fs/sysv/namei.c | |||
@@ -38,7 +38,7 @@ static int sysv_hash(struct dentry *dentry, struct qstr *qstr) | |||
38 | return 0; | 38 | return 0; |
39 | } | 39 | } |
40 | 40 | ||
41 | struct dentry_operations sysv_dentry_operations = { | 41 | const struct dentry_operations sysv_dentry_operations = { |
42 | .d_hash = sysv_hash, | 42 | .d_hash = sysv_hash, |
43 | }; | 43 | }; |
44 | 44 | ||
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h index 38ebe3f85b3d..5784a318c883 100644 --- a/fs/sysv/sysv.h +++ b/fs/sysv/sysv.h | |||
@@ -170,7 +170,7 @@ extern const struct file_operations sysv_file_operations; | |||
170 | extern const struct file_operations sysv_dir_operations; | 170 | extern const struct file_operations sysv_dir_operations; |
171 | extern const struct address_space_operations sysv_aops; | 171 | extern const struct address_space_operations sysv_aops; |
172 | extern const struct super_operations sysv_sops; | 172 | extern const struct super_operations sysv_sops; |
173 | extern struct dentry_operations sysv_dentry_operations; | 173 | extern const struct dentry_operations sysv_dentry_operations; |
174 | 174 | ||
175 | 175 | ||
176 | enum { | 176 | enum { |
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 1182b66a5491..c5c98355459a 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -2034,7 +2034,8 @@ static int ubifs_get_sb(struct file_system_type *fs_type, int flags, | |||
2034 | /* 'fill_super()' opens ubi again so we must close it here */ | 2034 | /* 'fill_super()' opens ubi again so we must close it here */ |
2035 | ubi_close_volume(ubi); | 2035 | ubi_close_volume(ubi); |
2036 | 2036 | ||
2037 | return simple_set_mnt(mnt, sb); | 2037 | simple_set_mnt(mnt, sb); |
2038 | return 0; | ||
2038 | 2039 | ||
2039 | out_deact: | 2040 | out_deact: |
2040 | up_write(&sb->s_umount); | 2041 | up_write(&sb->s_umount); |
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index 1b809bd494bd..2bb788a2acb1 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c | |||
@@ -206,7 +206,7 @@ static void udf_bitmap_free_blocks(struct super_block *sb, | |||
206 | ((char *)bh->b_data)[(bit + i) >> 3]); | 206 | ((char *)bh->b_data)[(bit + i) >> 3]); |
207 | } else { | 207 | } else { |
208 | if (inode) | 208 | if (inode) |
209 | DQUOT_FREE_BLOCK(inode, 1); | 209 | vfs_dq_free_block(inode, 1); |
210 | udf_add_free_space(sbi, sbi->s_partition, 1); | 210 | udf_add_free_space(sbi, sbi->s_partition, 1); |
211 | } | 211 | } |
212 | } | 212 | } |
@@ -261,11 +261,11 @@ static int udf_bitmap_prealloc_blocks(struct super_block *sb, | |||
261 | while (bit < (sb->s_blocksize << 3) && block_count > 0) { | 261 | while (bit < (sb->s_blocksize << 3) && block_count > 0) { |
262 | if (!udf_test_bit(bit, bh->b_data)) | 262 | if (!udf_test_bit(bit, bh->b_data)) |
263 | goto out; | 263 | goto out; |
264 | else if (DQUOT_PREALLOC_BLOCK(inode, 1)) | 264 | else if (vfs_dq_prealloc_block(inode, 1)) |
265 | goto out; | 265 | goto out; |
266 | else if (!udf_clear_bit(bit, bh->b_data)) { | 266 | else if (!udf_clear_bit(bit, bh->b_data)) { |
267 | udf_debug("bit already cleared for block %d\n", bit); | 267 | udf_debug("bit already cleared for block %d\n", bit); |
268 | DQUOT_FREE_BLOCK(inode, 1); | 268 | vfs_dq_free_block(inode, 1); |
269 | goto out; | 269 | goto out; |
270 | } | 270 | } |
271 | block_count--; | 271 | block_count--; |
@@ -393,7 +393,7 @@ got_block: | |||
393 | /* | 393 | /* |
394 | * Check quota for allocation of this block. | 394 | * Check quota for allocation of this block. |
395 | */ | 395 | */ |
396 | if (inode && DQUOT_ALLOC_BLOCK(inode, 1)) { | 396 | if (inode && vfs_dq_alloc_block(inode, 1)) { |
397 | mutex_unlock(&sbi->s_alloc_mutex); | 397 | mutex_unlock(&sbi->s_alloc_mutex); |
398 | *err = -EDQUOT; | 398 | *err = -EDQUOT; |
399 | return 0; | 399 | return 0; |
@@ -452,7 +452,7 @@ static void udf_table_free_blocks(struct super_block *sb, | |||
452 | /* We do this up front - There are some error conditions that | 452 | /* We do this up front - There are some error conditions that |
453 | could occure, but.. oh well */ | 453 | could occure, but.. oh well */ |
454 | if (inode) | 454 | if (inode) |
455 | DQUOT_FREE_BLOCK(inode, count); | 455 | vfs_dq_free_block(inode, count); |
456 | if (udf_add_free_space(sbi, sbi->s_partition, count)) | 456 | if (udf_add_free_space(sbi, sbi->s_partition, count)) |
457 | mark_buffer_dirty(sbi->s_lvid_bh); | 457 | mark_buffer_dirty(sbi->s_lvid_bh); |
458 | 458 | ||
@@ -700,7 +700,7 @@ static int udf_table_prealloc_blocks(struct super_block *sb, | |||
700 | epos.offset -= adsize; | 700 | epos.offset -= adsize; |
701 | 701 | ||
702 | alloc_count = (elen >> sb->s_blocksize_bits); | 702 | alloc_count = (elen >> sb->s_blocksize_bits); |
703 | if (inode && DQUOT_PREALLOC_BLOCK(inode, | 703 | if (inode && vfs_dq_prealloc_block(inode, |
704 | alloc_count > block_count ? block_count : alloc_count)) | 704 | alloc_count > block_count ? block_count : alloc_count)) |
705 | alloc_count = 0; | 705 | alloc_count = 0; |
706 | else if (alloc_count > block_count) { | 706 | else if (alloc_count > block_count) { |
@@ -806,7 +806,7 @@ static int udf_table_new_block(struct super_block *sb, | |||
806 | goal_eloc.logicalBlockNum++; | 806 | goal_eloc.logicalBlockNum++; |
807 | goal_elen -= sb->s_blocksize; | 807 | goal_elen -= sb->s_blocksize; |
808 | 808 | ||
809 | if (inode && DQUOT_ALLOC_BLOCK(inode, 1)) { | 809 | if (inode && vfs_dq_alloc_block(inode, 1)) { |
810 | brelse(goal_epos.bh); | 810 | brelse(goal_epos.bh); |
811 | mutex_unlock(&sbi->s_alloc_mutex); | 811 | mutex_unlock(&sbi->s_alloc_mutex); |
812 | *err = -EDQUOT; | 812 | *err = -EDQUOT; |
diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c index 31fc84297ddb..47dbe5613f90 100644 --- a/fs/udf/ialloc.c +++ b/fs/udf/ialloc.c | |||
@@ -36,8 +36,8 @@ void udf_free_inode(struct inode *inode) | |||
36 | * Note: we must free any quota before locking the superblock, | 36 | * Note: we must free any quota before locking the superblock, |
37 | * as writing the quota to disk may need the lock as well. | 37 | * as writing the quota to disk may need the lock as well. |
38 | */ | 38 | */ |
39 | DQUOT_FREE_INODE(inode); | 39 | vfs_dq_free_inode(inode); |
40 | DQUOT_DROP(inode); | 40 | vfs_dq_drop(inode); |
41 | 41 | ||
42 | clear_inode(inode); | 42 | clear_inode(inode); |
43 | 43 | ||
@@ -154,8 +154,8 @@ struct inode *udf_new_inode(struct inode *dir, int mode, int *err) | |||
154 | insert_inode_hash(inode); | 154 | insert_inode_hash(inode); |
155 | mark_inode_dirty(inode); | 155 | mark_inode_dirty(inode); |
156 | 156 | ||
157 | if (DQUOT_ALLOC_INODE(inode)) { | 157 | if (vfs_dq_alloc_inode(inode)) { |
158 | DQUOT_DROP(inode); | 158 | vfs_dq_drop(inode); |
159 | inode->i_flags |= S_NOQUOTA; | 159 | inode->i_flags |= S_NOQUOTA; |
160 | inode->i_nlink = 0; | 160 | inode->i_nlink = 0; |
161 | iput(inode); | 161 | iput(inode); |
diff --git a/fs/ufs/balloc.c b/fs/ufs/balloc.c index 0d9ada173739..54c16ec95dff 100644 --- a/fs/ufs/balloc.c +++ b/fs/ufs/balloc.c | |||
@@ -85,7 +85,7 @@ void ufs_free_fragments(struct inode *inode, u64 fragment, unsigned count) | |||
85 | "bit already cleared for fragment %u", i); | 85 | "bit already cleared for fragment %u", i); |
86 | } | 86 | } |
87 | 87 | ||
88 | DQUOT_FREE_BLOCK (inode, count); | 88 | vfs_dq_free_block(inode, count); |
89 | 89 | ||
90 | 90 | ||
91 | fs32_add(sb, &ucg->cg_cs.cs_nffree, count); | 91 | fs32_add(sb, &ucg->cg_cs.cs_nffree, count); |
@@ -195,7 +195,7 @@ do_more: | |||
195 | ubh_setblock(UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); | 195 | ubh_setblock(UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); |
196 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) | 196 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) |
197 | ufs_clusteracct (sb, ucpi, blkno, 1); | 197 | ufs_clusteracct (sb, ucpi, blkno, 1); |
198 | DQUOT_FREE_BLOCK(inode, uspi->s_fpb); | 198 | vfs_dq_free_block(inode, uspi->s_fpb); |
199 | 199 | ||
200 | fs32_add(sb, &ucg->cg_cs.cs_nbfree, 1); | 200 | fs32_add(sb, &ucg->cg_cs.cs_nbfree, 1); |
201 | uspi->cs_total.cs_nbfree++; | 201 | uspi->cs_total.cs_nbfree++; |
@@ -556,7 +556,7 @@ static u64 ufs_add_fragments(struct inode *inode, u64 fragment, | |||
556 | fs32_add(sb, &ucg->cg_frsum[fragsize - count], 1); | 556 | fs32_add(sb, &ucg->cg_frsum[fragsize - count], 1); |
557 | for (i = oldcount; i < newcount; i++) | 557 | for (i = oldcount; i < newcount; i++) |
558 | ubh_clrbit (UCPI_UBH(ucpi), ucpi->c_freeoff, fragno + i); | 558 | ubh_clrbit (UCPI_UBH(ucpi), ucpi->c_freeoff, fragno + i); |
559 | if(DQUOT_ALLOC_BLOCK(inode, count)) { | 559 | if (vfs_dq_alloc_block(inode, count)) { |
560 | *err = -EDQUOT; | 560 | *err = -EDQUOT; |
561 | return 0; | 561 | return 0; |
562 | } | 562 | } |
@@ -664,7 +664,7 @@ cg_found: | |||
664 | for (i = count; i < uspi->s_fpb; i++) | 664 | for (i = count; i < uspi->s_fpb; i++) |
665 | ubh_setbit (UCPI_UBH(ucpi), ucpi->c_freeoff, goal + i); | 665 | ubh_setbit (UCPI_UBH(ucpi), ucpi->c_freeoff, goal + i); |
666 | i = uspi->s_fpb - count; | 666 | i = uspi->s_fpb - count; |
667 | DQUOT_FREE_BLOCK(inode, i); | 667 | vfs_dq_free_block(inode, i); |
668 | 668 | ||
669 | fs32_add(sb, &ucg->cg_cs.cs_nffree, i); | 669 | fs32_add(sb, &ucg->cg_cs.cs_nffree, i); |
670 | uspi->cs_total.cs_nffree += i; | 670 | uspi->cs_total.cs_nffree += i; |
@@ -676,7 +676,7 @@ cg_found: | |||
676 | result = ufs_bitmap_search (sb, ucpi, goal, allocsize); | 676 | result = ufs_bitmap_search (sb, ucpi, goal, allocsize); |
677 | if (result == INVBLOCK) | 677 | if (result == INVBLOCK) |
678 | return 0; | 678 | return 0; |
679 | if(DQUOT_ALLOC_BLOCK(inode, count)) { | 679 | if (vfs_dq_alloc_block(inode, count)) { |
680 | *err = -EDQUOT; | 680 | *err = -EDQUOT; |
681 | return 0; | 681 | return 0; |
682 | } | 682 | } |
@@ -747,7 +747,7 @@ gotit: | |||
747 | ubh_clrblock (UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); | 747 | ubh_clrblock (UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); |
748 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) | 748 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) |
749 | ufs_clusteracct (sb, ucpi, blkno, -1); | 749 | ufs_clusteracct (sb, ucpi, blkno, -1); |
750 | if(DQUOT_ALLOC_BLOCK(inode, uspi->s_fpb)) { | 750 | if (vfs_dq_alloc_block(inode, uspi->s_fpb)) { |
751 | *err = -EDQUOT; | 751 | *err = -EDQUOT; |
752 | return INVBLOCK; | 752 | return INVBLOCK; |
753 | } | 753 | } |
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c index 6f5dcf006096..3527c00fef0d 100644 --- a/fs/ufs/ialloc.c +++ b/fs/ufs/ialloc.c | |||
@@ -95,8 +95,8 @@ void ufs_free_inode (struct inode * inode) | |||
95 | 95 | ||
96 | is_directory = S_ISDIR(inode->i_mode); | 96 | is_directory = S_ISDIR(inode->i_mode); |
97 | 97 | ||
98 | DQUOT_FREE_INODE(inode); | 98 | vfs_dq_free_inode(inode); |
99 | DQUOT_DROP(inode); | 99 | vfs_dq_drop(inode); |
100 | 100 | ||
101 | clear_inode (inode); | 101 | clear_inode (inode); |
102 | 102 | ||
@@ -355,8 +355,8 @@ cg_found: | |||
355 | 355 | ||
356 | unlock_super (sb); | 356 | unlock_super (sb); |
357 | 357 | ||
358 | if (DQUOT_ALLOC_INODE(inode)) { | 358 | if (vfs_dq_alloc_inode(inode)) { |
359 | DQUOT_DROP(inode); | 359 | vfs_dq_drop(inode); |
360 | err = -EDQUOT; | 360 | err = -EDQUOT; |
361 | goto fail_without_unlock; | 361 | goto fail_without_unlock; |
362 | } | 362 | } |
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index 39f877898565..3d2512c21f05 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c | |||
@@ -622,7 +622,6 @@ static int ufs1_read_inode(struct inode *inode, struct ufs_inode *ufs_inode) | |||
622 | struct ufs_inode_info *ufsi = UFS_I(inode); | 622 | struct ufs_inode_info *ufsi = UFS_I(inode); |
623 | struct super_block *sb = inode->i_sb; | 623 | struct super_block *sb = inode->i_sb; |
624 | mode_t mode; | 624 | mode_t mode; |
625 | unsigned i; | ||
626 | 625 | ||
627 | /* | 626 | /* |
628 | * Copy data to the in-core inode. | 627 | * Copy data to the in-core inode. |
@@ -655,11 +654,12 @@ static int ufs1_read_inode(struct inode *inode, struct ufs_inode *ufs_inode) | |||
655 | 654 | ||
656 | 655 | ||
657 | if (S_ISCHR(mode) || S_ISBLK(mode) || inode->i_blocks) { | 656 | if (S_ISCHR(mode) || S_ISBLK(mode) || inode->i_blocks) { |
658 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR); i++) | 657 | memcpy(ufsi->i_u1.i_data, &ufs_inode->ui_u2.ui_addr, |
659 | ufsi->i_u1.i_data[i] = ufs_inode->ui_u2.ui_addr.ui_db[i]; | 658 | sizeof(ufs_inode->ui_u2.ui_addr)); |
660 | } else { | 659 | } else { |
661 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) | 660 | memcpy(ufsi->i_u1.i_symlink, ufs_inode->ui_u2.ui_symlink, |
662 | ufsi->i_u1.i_symlink[i] = ufs_inode->ui_u2.ui_symlink[i]; | 661 | sizeof(ufs_inode->ui_u2.ui_symlink) - 1); |
662 | ufsi->i_u1.i_symlink[sizeof(ufs_inode->ui_u2.ui_symlink) - 1] = 0; | ||
663 | } | 663 | } |
664 | return 0; | 664 | return 0; |
665 | } | 665 | } |
@@ -669,7 +669,6 @@ static int ufs2_read_inode(struct inode *inode, struct ufs2_inode *ufs2_inode) | |||
669 | struct ufs_inode_info *ufsi = UFS_I(inode); | 669 | struct ufs_inode_info *ufsi = UFS_I(inode); |
670 | struct super_block *sb = inode->i_sb; | 670 | struct super_block *sb = inode->i_sb; |
671 | mode_t mode; | 671 | mode_t mode; |
672 | unsigned i; | ||
673 | 672 | ||
674 | UFSD("Reading ufs2 inode, ino %lu\n", inode->i_ino); | 673 | UFSD("Reading ufs2 inode, ino %lu\n", inode->i_ino); |
675 | /* | 674 | /* |
@@ -704,12 +703,12 @@ static int ufs2_read_inode(struct inode *inode, struct ufs2_inode *ufs2_inode) | |||
704 | */ | 703 | */ |
705 | 704 | ||
706 | if (S_ISCHR(mode) || S_ISBLK(mode) || inode->i_blocks) { | 705 | if (S_ISCHR(mode) || S_ISBLK(mode) || inode->i_blocks) { |
707 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR); i++) | 706 | memcpy(ufsi->i_u1.u2_i_data, &ufs2_inode->ui_u2.ui_addr, |
708 | ufsi->i_u1.u2_i_data[i] = | 707 | sizeof(ufs2_inode->ui_u2.ui_addr)); |
709 | ufs2_inode->ui_u2.ui_addr.ui_db[i]; | ||
710 | } else { | 708 | } else { |
711 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) | 709 | memcpy(ufsi->i_u1.i_symlink, ufs2_inode->ui_u2.ui_symlink, |
712 | ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i]; | 710 | sizeof(ufs2_inode->ui_u2.ui_symlink) - 1); |
711 | ufsi->i_u1.i_symlink[sizeof(ufs2_inode->ui_u2.ui_symlink) - 1] = 0; | ||
713 | } | 712 | } |
714 | return 0; | 713 | return 0; |
715 | } | 714 | } |
@@ -781,7 +780,6 @@ static void ufs1_update_inode(struct inode *inode, struct ufs_inode *ufs_inode) | |||
781 | { | 780 | { |
782 | struct super_block *sb = inode->i_sb; | 781 | struct super_block *sb = inode->i_sb; |
783 | struct ufs_inode_info *ufsi = UFS_I(inode); | 782 | struct ufs_inode_info *ufsi = UFS_I(inode); |
784 | unsigned i; | ||
785 | 783 | ||
786 | ufs_inode->ui_mode = cpu_to_fs16(sb, inode->i_mode); | 784 | ufs_inode->ui_mode = cpu_to_fs16(sb, inode->i_mode); |
787 | ufs_inode->ui_nlink = cpu_to_fs16(sb, inode->i_nlink); | 785 | ufs_inode->ui_nlink = cpu_to_fs16(sb, inode->i_nlink); |
@@ -809,12 +807,12 @@ static void ufs1_update_inode(struct inode *inode, struct ufs_inode *ufs_inode) | |||
809 | /* ufs_inode->ui_u2.ui_addr.ui_db[0] = cpu_to_fs32(sb, inode->i_rdev); */ | 807 | /* ufs_inode->ui_u2.ui_addr.ui_db[0] = cpu_to_fs32(sb, inode->i_rdev); */ |
810 | ufs_inode->ui_u2.ui_addr.ui_db[0] = ufsi->i_u1.i_data[0]; | 808 | ufs_inode->ui_u2.ui_addr.ui_db[0] = ufsi->i_u1.i_data[0]; |
811 | } else if (inode->i_blocks) { | 809 | } else if (inode->i_blocks) { |
812 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR); i++) | 810 | memcpy(&ufs_inode->ui_u2.ui_addr, ufsi->i_u1.i_data, |
813 | ufs_inode->ui_u2.ui_addr.ui_db[i] = ufsi->i_u1.i_data[i]; | 811 | sizeof(ufs_inode->ui_u2.ui_addr)); |
814 | } | 812 | } |
815 | else { | 813 | else { |
816 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) | 814 | memcpy(&ufs_inode->ui_u2.ui_symlink, ufsi->i_u1.i_symlink, |
817 | ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i]; | 815 | sizeof(ufs_inode->ui_u2.ui_symlink)); |
818 | } | 816 | } |
819 | 817 | ||
820 | if (!inode->i_nlink) | 818 | if (!inode->i_nlink) |
@@ -825,7 +823,6 @@ static void ufs2_update_inode(struct inode *inode, struct ufs2_inode *ufs_inode) | |||
825 | { | 823 | { |
826 | struct super_block *sb = inode->i_sb; | 824 | struct super_block *sb = inode->i_sb; |
827 | struct ufs_inode_info *ufsi = UFS_I(inode); | 825 | struct ufs_inode_info *ufsi = UFS_I(inode); |
828 | unsigned i; | ||
829 | 826 | ||
830 | UFSD("ENTER\n"); | 827 | UFSD("ENTER\n"); |
831 | ufs_inode->ui_mode = cpu_to_fs16(sb, inode->i_mode); | 828 | ufs_inode->ui_mode = cpu_to_fs16(sb, inode->i_mode); |
@@ -850,11 +847,11 @@ static void ufs2_update_inode(struct inode *inode, struct ufs2_inode *ufs_inode) | |||
850 | /* ufs_inode->ui_u2.ui_addr.ui_db[0] = cpu_to_fs32(sb, inode->i_rdev); */ | 847 | /* ufs_inode->ui_u2.ui_addr.ui_db[0] = cpu_to_fs32(sb, inode->i_rdev); */ |
851 | ufs_inode->ui_u2.ui_addr.ui_db[0] = ufsi->i_u1.u2_i_data[0]; | 848 | ufs_inode->ui_u2.ui_addr.ui_db[0] = ufsi->i_u1.u2_i_data[0]; |
852 | } else if (inode->i_blocks) { | 849 | } else if (inode->i_blocks) { |
853 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR); i++) | 850 | memcpy(&ufs_inode->ui_u2.ui_addr, ufsi->i_u1.u2_i_data, |
854 | ufs_inode->ui_u2.ui_addr.ui_db[i] = ufsi->i_u1.u2_i_data[i]; | 851 | sizeof(ufs_inode->ui_u2.ui_addr)); |
855 | } else { | 852 | } else { |
856 | for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) | 853 | memcpy(&ufs_inode->ui_u2.ui_symlink, ufsi->i_u1.i_symlink, |
857 | ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i]; | 854 | sizeof(ufs_inode->ui_u2.ui_symlink)); |
858 | } | 855 | } |
859 | 856 | ||
860 | if (!inode->i_nlink) | 857 | if (!inode->i_nlink) |
diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c index e3a9b1fac75a..23119fe7ad62 100644 --- a/fs/ufs/namei.c +++ b/fs/ufs/namei.c | |||
@@ -147,7 +147,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry, | |||
147 | } else { | 147 | } else { |
148 | /* fast symlink */ | 148 | /* fast symlink */ |
149 | inode->i_op = &ufs_fast_symlink_inode_operations; | 149 | inode->i_op = &ufs_fast_symlink_inode_operations; |
150 | memcpy((char*)&UFS_I(inode)->i_u1.i_data,symname,l); | 150 | memcpy(UFS_I(inode)->i_u1.i_symlink, symname, l); |
151 | inode->i_size = l-1; | 151 | inode->i_size = l-1; |
152 | } | 152 | } |
153 | mark_inode_dirty(inode); | 153 | mark_inode_dirty(inode); |
diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 261a1c2f22dd..e1c1fc5ee239 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c | |||
@@ -636,6 +636,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent) | |||
636 | unsigned block_size, super_block_size; | 636 | unsigned block_size, super_block_size; |
637 | unsigned flags; | 637 | unsigned flags; |
638 | unsigned super_block_offset; | 638 | unsigned super_block_offset; |
639 | unsigned maxsymlen; | ||
639 | int ret = -EINVAL; | 640 | int ret = -EINVAL; |
640 | 641 | ||
641 | uspi = NULL; | 642 | uspi = NULL; |
@@ -1069,6 +1070,16 @@ magic_found: | |||
1069 | uspi->s_maxsymlinklen = | 1070 | uspi->s_maxsymlinklen = |
1070 | fs32_to_cpu(sb, usb3->fs_un2.fs_44.fs_maxsymlinklen); | 1071 | fs32_to_cpu(sb, usb3->fs_un2.fs_44.fs_maxsymlinklen); |
1071 | 1072 | ||
1073 | if (uspi->fs_magic == UFS2_MAGIC) | ||
1074 | maxsymlen = 2 * 4 * (UFS_NDADDR + UFS_NINDIR); | ||
1075 | else | ||
1076 | maxsymlen = 4 * (UFS_NDADDR + UFS_NINDIR); | ||
1077 | if (uspi->s_maxsymlinklen > maxsymlen) { | ||
1078 | ufs_warning(sb, __func__, "ufs_read_super: excessive maximum " | ||
1079 | "fast symlink size (%u)\n", uspi->s_maxsymlinklen); | ||
1080 | uspi->s_maxsymlinklen = maxsymlen; | ||
1081 | } | ||
1082 | |||
1072 | inode = ufs_iget(sb, UFS_ROOTINO); | 1083 | inode = ufs_iget(sb, UFS_ROOTINO); |
1073 | if (IS_ERR(inode)) { | 1084 | if (IS_ERR(inode)) { |
1074 | ret = PTR_ERR(inode); | 1085 | ret = PTR_ERR(inode); |
diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h index 11c035168ea6..69b3427d7885 100644 --- a/fs/ufs/ufs.h +++ b/fs/ufs/ufs.h | |||
@@ -23,7 +23,7 @@ struct ufs_sb_info { | |||
23 | struct ufs_inode_info { | 23 | struct ufs_inode_info { |
24 | union { | 24 | union { |
25 | __fs32 i_data[15]; | 25 | __fs32 i_data[15]; |
26 | __u8 i_symlink[4*15]; | 26 | __u8 i_symlink[2 * 4 * 15]; |
27 | __fs64 u2_i_data[15]; | 27 | __fs64 u2_i_data[15]; |
28 | } i_u1; | 28 | } i_u1; |
29 | __u32 i_flags; | 29 | __u32 i_flags; |