diff options
Diffstat (limited to 'fs')
202 files changed, 5756 insertions, 4285 deletions
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h index 9cc18775b832..2ff622f6f547 100644 --- a/fs/adfs/adfs.h +++ b/fs/adfs/adfs.h | |||
@@ -121,7 +121,7 @@ struct adfs_discmap { | |||
121 | 121 | ||
122 | /* Inode stuff */ | 122 | /* Inode stuff */ |
123 | struct inode *adfs_iget(struct super_block *sb, struct object_info *obj); | 123 | struct inode *adfs_iget(struct super_block *sb, struct object_info *obj); |
124 | int adfs_write_inode(struct inode *inode,int unused); | 124 | int adfs_write_inode(struct inode *inode, struct writeback_control *wbc); |
125 | int adfs_notify_change(struct dentry *dentry, struct iattr *attr); | 125 | int adfs_notify_change(struct dentry *dentry, struct iattr *attr); |
126 | 126 | ||
127 | /* map.c */ | 127 | /* map.c */ |
diff --git a/fs/adfs/inode.c b/fs/adfs/inode.c index 3f57ce4bee5d..0f5e30978135 100644 --- a/fs/adfs/inode.c +++ b/fs/adfs/inode.c | |||
@@ -9,6 +9,7 @@ | |||
9 | */ | 9 | */ |
10 | #include <linux/smp_lock.h> | 10 | #include <linux/smp_lock.h> |
11 | #include <linux/buffer_head.h> | 11 | #include <linux/buffer_head.h> |
12 | #include <linux/writeback.h> | ||
12 | #include "adfs.h" | 13 | #include "adfs.h" |
13 | 14 | ||
14 | /* | 15 | /* |
@@ -360,7 +361,7 @@ out: | |||
360 | * The adfs-specific inode data has already been updated by | 361 | * The adfs-specific inode data has already been updated by |
361 | * adfs_notify_change() | 362 | * adfs_notify_change() |
362 | */ | 363 | */ |
363 | int adfs_write_inode(struct inode *inode, int wait) | 364 | int adfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
364 | { | 365 | { |
365 | struct super_block *sb = inode->i_sb; | 366 | struct super_block *sb = inode->i_sb; |
366 | struct object_info obj; | 367 | struct object_info obj; |
@@ -375,7 +376,7 @@ int adfs_write_inode(struct inode *inode, int wait) | |||
375 | obj.attr = ADFS_I(inode)->attr; | 376 | obj.attr = ADFS_I(inode)->attr; |
376 | obj.size = inode->i_size; | 377 | obj.size = inode->i_size; |
377 | 378 | ||
378 | ret = adfs_dir_update(sb, &obj, wait); | 379 | ret = adfs_dir_update(sb, &obj, wbc->sync_mode == WB_SYNC_ALL); |
379 | unlock_kernel(); | 380 | unlock_kernel(); |
380 | return ret; | 381 | return ret; |
381 | } | 382 | } |
diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 0e40caaba456..861dae68ac12 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h | |||
@@ -175,7 +175,8 @@ extern void affs_delete_inode(struct inode *inode); | |||
175 | extern void affs_clear_inode(struct inode *inode); | 175 | extern void affs_clear_inode(struct inode *inode); |
176 | extern struct inode *affs_iget(struct super_block *sb, | 176 | extern struct inode *affs_iget(struct super_block *sb, |
177 | unsigned long ino); | 177 | unsigned long ino); |
178 | extern int affs_write_inode(struct inode *inode, int); | 178 | extern int affs_write_inode(struct inode *inode, |
179 | struct writeback_control *wbc); | ||
179 | extern int affs_add_entry(struct inode *dir, struct inode *inode, struct dentry *dentry, s32 type); | 180 | extern int affs_add_entry(struct inode *dir, struct inode *inode, struct dentry *dentry, s32 type); |
180 | 181 | ||
181 | /* file.c */ | 182 | /* file.c */ |
diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 3c4ec7d864c4..c9744d771d98 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c | |||
@@ -166,7 +166,7 @@ bad_inode: | |||
166 | } | 166 | } |
167 | 167 | ||
168 | int | 168 | int |
169 | affs_write_inode(struct inode *inode, int unused) | 169 | affs_write_inode(struct inode *inode, struct writeback_control *wbc) |
170 | { | 170 | { |
171 | struct super_block *sb = inode->i_sb; | 171 | struct super_block *sb = inode->i_sb; |
172 | struct buffer_head *bh; | 172 | struct buffer_head *bh; |
diff --git a/fs/afs/internal.h b/fs/afs/internal.h index 6ece2a13bf71..c54dad4e6063 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h | |||
@@ -733,7 +733,6 @@ extern int afs_write_end(struct file *file, struct address_space *mapping, | |||
733 | struct page *page, void *fsdata); | 733 | struct page *page, void *fsdata); |
734 | extern int afs_writepage(struct page *, struct writeback_control *); | 734 | extern int afs_writepage(struct page *, struct writeback_control *); |
735 | extern int afs_writepages(struct address_space *, struct writeback_control *); | 735 | extern int afs_writepages(struct address_space *, struct writeback_control *); |
736 | extern int afs_write_inode(struct inode *, int); | ||
737 | extern void afs_pages_written_back(struct afs_vnode *, struct afs_call *); | 736 | extern void afs_pages_written_back(struct afs_vnode *, struct afs_call *); |
738 | extern ssize_t afs_file_write(struct kiocb *, const struct iovec *, | 737 | extern ssize_t afs_file_write(struct kiocb *, const struct iovec *, |
739 | unsigned long, loff_t); | 738 | unsigned long, loff_t); |
diff --git a/fs/afs/super.c b/fs/afs/super.c index e1ea1c240b6a..14f6431598ad 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c | |||
@@ -48,7 +48,6 @@ struct file_system_type afs_fs_type = { | |||
48 | static const struct super_operations afs_super_ops = { | 48 | static const struct super_operations afs_super_ops = { |
49 | .statfs = afs_statfs, | 49 | .statfs = afs_statfs, |
50 | .alloc_inode = afs_alloc_inode, | 50 | .alloc_inode = afs_alloc_inode, |
51 | .write_inode = afs_write_inode, | ||
52 | .destroy_inode = afs_destroy_inode, | 51 | .destroy_inode = afs_destroy_inode, |
53 | .clear_inode = afs_clear_inode, | 52 | .clear_inode = afs_clear_inode, |
54 | .put_super = afs_put_super, | 53 | .put_super = afs_put_super, |
diff --git a/fs/afs/write.c b/fs/afs/write.c index 5e15a21dbf9f..3bed54a294d4 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c | |||
@@ -585,27 +585,6 @@ int afs_writepages(struct address_space *mapping, | |||
585 | } | 585 | } |
586 | 586 | ||
587 | /* | 587 | /* |
588 | * write an inode back | ||
589 | */ | ||
590 | int afs_write_inode(struct inode *inode, int sync) | ||
591 | { | ||
592 | struct afs_vnode *vnode = AFS_FS_I(inode); | ||
593 | int ret; | ||
594 | |||
595 | _enter("{%x:%u},", vnode->fid.vid, vnode->fid.vnode); | ||
596 | |||
597 | ret = 0; | ||
598 | if (sync) { | ||
599 | ret = filemap_fdatawait(inode->i_mapping); | ||
600 | if (ret < 0) | ||
601 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); | ||
602 | } | ||
603 | |||
604 | _leave(" = %d", ret); | ||
605 | return ret; | ||
606 | } | ||
607 | |||
608 | /* | ||
609 | * completion of write to server | 588 | * completion of write to server |
610 | */ | 589 | */ |
611 | void afs_pages_written_back(struct afs_vnode *vnode, struct afs_call *call) | 590 | void afs_pages_written_back(struct afs_vnode *vnode, struct afs_call *call) |
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 0118d67221b2..3d283abf67d7 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h | |||
@@ -60,11 +60,6 @@ do { \ | |||
60 | current->pid, __func__, ##args); \ | 60 | current->pid, __func__, ##args); \ |
61 | } while (0) | 61 | } while (0) |
62 | 62 | ||
63 | struct rehash_entry { | ||
64 | struct task_struct *task; | ||
65 | struct list_head list; | ||
66 | }; | ||
67 | |||
68 | /* Unified info structure. This is pointed to by both the dentry and | 63 | /* Unified info structure. This is pointed to by both the dentry and |
69 | inode structures. Each file in the filesystem has an instance of this | 64 | inode structures. Each file in the filesystem has an instance of this |
70 | structure. It holds a reference to the dentry, so dentries are never | 65 | structure. It holds a reference to the dentry, so dentries are never |
@@ -81,7 +76,6 @@ struct autofs_info { | |||
81 | 76 | ||
82 | struct list_head active; | 77 | struct list_head active; |
83 | int active_count; | 78 | int active_count; |
84 | struct list_head rehash_list; | ||
85 | 79 | ||
86 | struct list_head expiring; | 80 | struct list_head expiring; |
87 | 81 | ||
@@ -104,7 +98,6 @@ struct autofs_info { | |||
104 | #define AUTOFS_INF_EXPIRING (1<<0) /* dentry is in the process of expiring */ | 98 | #define AUTOFS_INF_EXPIRING (1<<0) /* dentry is in the process of expiring */ |
105 | #define AUTOFS_INF_MOUNTPOINT (1<<1) /* mountpoint status for direct expire */ | 99 | #define AUTOFS_INF_MOUNTPOINT (1<<1) /* mountpoint status for direct expire */ |
106 | #define AUTOFS_INF_PENDING (1<<2) /* dentry pending mount */ | 100 | #define AUTOFS_INF_PENDING (1<<2) /* dentry pending mount */ |
107 | #define AUTOFS_INF_REHASH (1<<3) /* dentry in transit to ->lookup() */ | ||
108 | 101 | ||
109 | struct autofs_wait_queue { | 102 | struct autofs_wait_queue { |
110 | wait_queue_head_t queue; | 103 | wait_queue_head_t queue; |
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 00bf8fcb245f..c8a80dffb455 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c | |||
@@ -544,10 +544,9 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp, | |||
544 | goto out; | 544 | goto out; |
545 | devid = new_encode_dev(path.mnt->mnt_sb->s_dev); | 545 | devid = new_encode_dev(path.mnt->mnt_sb->s_dev); |
546 | err = 0; | 546 | err = 0; |
547 | if (path.dentry->d_inode && | 547 | if (path.mnt->mnt_root == path.dentry) { |
548 | path.mnt->mnt_root == path.dentry) { | ||
549 | err = 1; | 548 | err = 1; |
550 | magic = path.dentry->d_inode->i_sb->s_magic; | 549 | magic = path.mnt->mnt_sb->s_magic; |
551 | } | 550 | } |
552 | } else { | 551 | } else { |
553 | dev_t dev = sbi->sb->s_dev; | 552 | dev_t dev = sbi->sb->s_dev; |
@@ -560,10 +559,8 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp, | |||
560 | 559 | ||
561 | err = have_submounts(path.dentry); | 560 | err = have_submounts(path.dentry); |
562 | 561 | ||
563 | if (path.mnt->mnt_mountpoint != path.mnt->mnt_root) { | 562 | if (follow_down(&path)) |
564 | if (follow_down(&path)) | 563 | magic = path.mnt->mnt_sb->s_magic; |
565 | magic = path.mnt->mnt_sb->s_magic; | ||
566 | } | ||
567 | } | 564 | } |
568 | 565 | ||
569 | param->ismountpoint.out.devid = devid; | 566 | param->ismountpoint.out.devid = devid; |
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index 74bc9aa6df31..a796c9417fb1 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c | |||
@@ -279,7 +279,6 @@ struct dentry *autofs4_expire_direct(struct super_block *sb, | |||
279 | root->d_mounted--; | 279 | root->d_mounted--; |
280 | } | 280 | } |
281 | ino->flags |= AUTOFS_INF_EXPIRING; | 281 | ino->flags |= AUTOFS_INF_EXPIRING; |
282 | autofs4_add_expiring(root); | ||
283 | init_completion(&ino->expire_complete); | 282 | init_completion(&ino->expire_complete); |
284 | spin_unlock(&sbi->fs_lock); | 283 | spin_unlock(&sbi->fs_lock); |
285 | return root; | 284 | return root; |
@@ -407,7 +406,6 @@ found: | |||
407 | expired, (int)expired->d_name.len, expired->d_name.name); | 406 | expired, (int)expired->d_name.len, expired->d_name.name); |
408 | ino = autofs4_dentry_ino(expired); | 407 | ino = autofs4_dentry_ino(expired); |
409 | ino->flags |= AUTOFS_INF_EXPIRING; | 408 | ino->flags |= AUTOFS_INF_EXPIRING; |
410 | autofs4_add_expiring(expired); | ||
411 | init_completion(&ino->expire_complete); | 409 | init_completion(&ino->expire_complete); |
412 | spin_unlock(&sbi->fs_lock); | 410 | spin_unlock(&sbi->fs_lock); |
413 | spin_lock(&dcache_lock); | 411 | spin_lock(&dcache_lock); |
@@ -435,7 +433,7 @@ int autofs4_expire_wait(struct dentry *dentry) | |||
435 | 433 | ||
436 | DPRINTK("expire done status=%d", status); | 434 | DPRINTK("expire done status=%d", status); |
437 | 435 | ||
438 | if (d_unhashed(dentry) && IS_DEADDIR(dentry->d_inode)) | 436 | if (d_unhashed(dentry)) |
439 | return -EAGAIN; | 437 | return -EAGAIN; |
440 | 438 | ||
441 | return status; | 439 | return status; |
@@ -475,7 +473,6 @@ int autofs4_expire_run(struct super_block *sb, | |||
475 | spin_lock(&sbi->fs_lock); | 473 | spin_lock(&sbi->fs_lock); |
476 | ino = autofs4_dentry_ino(dentry); | 474 | ino = autofs4_dentry_ino(dentry); |
477 | ino->flags &= ~AUTOFS_INF_EXPIRING; | 475 | ino->flags &= ~AUTOFS_INF_EXPIRING; |
478 | autofs4_del_expiring(dentry); | ||
479 | complete_all(&ino->expire_complete); | 476 | complete_all(&ino->expire_complete); |
480 | spin_unlock(&sbi->fs_lock); | 477 | spin_unlock(&sbi->fs_lock); |
481 | 478 | ||
@@ -506,7 +503,6 @@ int autofs4_do_expire_multi(struct super_block *sb, struct vfsmount *mnt, | |||
506 | ino->flags &= ~AUTOFS_INF_MOUNTPOINT; | 503 | ino->flags &= ~AUTOFS_INF_MOUNTPOINT; |
507 | } | 504 | } |
508 | ino->flags &= ~AUTOFS_INF_EXPIRING; | 505 | ino->flags &= ~AUTOFS_INF_EXPIRING; |
509 | autofs4_del_expiring(dentry); | ||
510 | complete_all(&ino->expire_complete); | 506 | complete_all(&ino->expire_complete); |
511 | spin_unlock(&sbi->fs_lock); | 507 | spin_unlock(&sbi->fs_lock); |
512 | dput(dentry); | 508 | dput(dentry); |
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index d0a3de247458..821b2b955dac 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c | |||
@@ -49,7 +49,6 @@ struct autofs_info *autofs4_init_ino(struct autofs_info *ino, | |||
49 | ino->dentry = NULL; | 49 | ino->dentry = NULL; |
50 | ino->size = 0; | 50 | ino->size = 0; |
51 | INIT_LIST_HEAD(&ino->active); | 51 | INIT_LIST_HEAD(&ino->active); |
52 | INIT_LIST_HEAD(&ino->rehash_list); | ||
53 | ino->active_count = 0; | 52 | ino->active_count = 0; |
54 | INIT_LIST_HEAD(&ino->expiring); | 53 | INIT_LIST_HEAD(&ino->expiring); |
55 | atomic_set(&ino->count, 0); | 54 | atomic_set(&ino->count, 0); |
@@ -97,63 +96,6 @@ void autofs4_free_ino(struct autofs_info *ino) | |||
97 | kfree(ino); | 96 | kfree(ino); |
98 | } | 97 | } |
99 | 98 | ||
100 | /* | ||
101 | * Deal with the infamous "Busy inodes after umount ..." message. | ||
102 | * | ||
103 | * Clean up the dentry tree. This happens with autofs if the user | ||
104 | * space program goes away due to a SIGKILL, SIGSEGV etc. | ||
105 | */ | ||
106 | static void autofs4_force_release(struct autofs_sb_info *sbi) | ||
107 | { | ||
108 | struct dentry *this_parent = sbi->sb->s_root; | ||
109 | struct list_head *next; | ||
110 | |||
111 | if (!sbi->sb->s_root) | ||
112 | return; | ||
113 | |||
114 | spin_lock(&dcache_lock); | ||
115 | repeat: | ||
116 | next = this_parent->d_subdirs.next; | ||
117 | resume: | ||
118 | while (next != &this_parent->d_subdirs) { | ||
119 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); | ||
120 | |||
121 | /* Negative dentry - don`t care */ | ||
122 | if (!simple_positive(dentry)) { | ||
123 | next = next->next; | ||
124 | continue; | ||
125 | } | ||
126 | |||
127 | if (!list_empty(&dentry->d_subdirs)) { | ||
128 | this_parent = dentry; | ||
129 | goto repeat; | ||
130 | } | ||
131 | |||
132 | next = next->next; | ||
133 | spin_unlock(&dcache_lock); | ||
134 | |||
135 | DPRINTK("dentry %p %.*s", | ||
136 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | ||
137 | |||
138 | dput(dentry); | ||
139 | spin_lock(&dcache_lock); | ||
140 | } | ||
141 | |||
142 | if (this_parent != sbi->sb->s_root) { | ||
143 | struct dentry *dentry = this_parent; | ||
144 | |||
145 | next = this_parent->d_u.d_child.next; | ||
146 | this_parent = this_parent->d_parent; | ||
147 | spin_unlock(&dcache_lock); | ||
148 | DPRINTK("parent dentry %p %.*s", | ||
149 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | ||
150 | dput(dentry); | ||
151 | spin_lock(&dcache_lock); | ||
152 | goto resume; | ||
153 | } | ||
154 | spin_unlock(&dcache_lock); | ||
155 | } | ||
156 | |||
157 | void autofs4_kill_sb(struct super_block *sb) | 99 | void autofs4_kill_sb(struct super_block *sb) |
158 | { | 100 | { |
159 | struct autofs_sb_info *sbi = autofs4_sbi(sb); | 101 | struct autofs_sb_info *sbi = autofs4_sbi(sb); |
@@ -170,15 +112,12 @@ void autofs4_kill_sb(struct super_block *sb) | |||
170 | /* Free wait queues, close pipe */ | 112 | /* Free wait queues, close pipe */ |
171 | autofs4_catatonic_mode(sbi); | 113 | autofs4_catatonic_mode(sbi); |
172 | 114 | ||
173 | /* Clean up and release dangling references */ | ||
174 | autofs4_force_release(sbi); | ||
175 | |||
176 | sb->s_fs_info = NULL; | 115 | sb->s_fs_info = NULL; |
177 | kfree(sbi); | 116 | kfree(sbi); |
178 | 117 | ||
179 | out_kill_sb: | 118 | out_kill_sb: |
180 | DPRINTK("shutting down"); | 119 | DPRINTK("shutting down"); |
181 | kill_anon_super(sb); | 120 | kill_litter_super(sb); |
182 | } | 121 | } |
183 | 122 | ||
184 | static int autofs4_show_options(struct seq_file *m, struct vfsmount *mnt) | 123 | static int autofs4_show_options(struct seq_file *m, struct vfsmount *mnt) |
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 30cc9ddf4b70..a015b49891df 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c | |||
@@ -104,99 +104,6 @@ static void autofs4_del_active(struct dentry *dentry) | |||
104 | return; | 104 | return; |
105 | } | 105 | } |
106 | 106 | ||
107 | static void autofs4_add_rehash_entry(struct autofs_info *ino, | ||
108 | struct rehash_entry *entry) | ||
109 | { | ||
110 | entry->task = current; | ||
111 | INIT_LIST_HEAD(&entry->list); | ||
112 | list_add(&entry->list, &ino->rehash_list); | ||
113 | return; | ||
114 | } | ||
115 | |||
116 | static void autofs4_remove_rehash_entry(struct autofs_info *ino) | ||
117 | { | ||
118 | struct list_head *head = &ino->rehash_list; | ||
119 | struct rehash_entry *entry; | ||
120 | list_for_each_entry(entry, head, list) { | ||
121 | if (entry->task == current) { | ||
122 | list_del(&entry->list); | ||
123 | kfree(entry); | ||
124 | break; | ||
125 | } | ||
126 | } | ||
127 | return; | ||
128 | } | ||
129 | |||
130 | static void autofs4_remove_rehash_entrys(struct autofs_info *ino) | ||
131 | { | ||
132 | struct autofs_sb_info *sbi = ino->sbi; | ||
133 | struct rehash_entry *entry, *next; | ||
134 | struct list_head *head; | ||
135 | |||
136 | spin_lock(&sbi->fs_lock); | ||
137 | spin_lock(&sbi->lookup_lock); | ||
138 | if (!(ino->flags & AUTOFS_INF_REHASH)) { | ||
139 | spin_unlock(&sbi->lookup_lock); | ||
140 | spin_unlock(&sbi->fs_lock); | ||
141 | return; | ||
142 | } | ||
143 | ino->flags &= ~AUTOFS_INF_REHASH; | ||
144 | head = &ino->rehash_list; | ||
145 | list_for_each_entry_safe(entry, next, head, list) { | ||
146 | list_del(&entry->list); | ||
147 | kfree(entry); | ||
148 | } | ||
149 | spin_unlock(&sbi->lookup_lock); | ||
150 | spin_unlock(&sbi->fs_lock); | ||
151 | dput(ino->dentry); | ||
152 | |||
153 | return; | ||
154 | } | ||
155 | |||
156 | static void autofs4_revalidate_drop(struct dentry *dentry, | ||
157 | struct rehash_entry *entry) | ||
158 | { | ||
159 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | ||
160 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
161 | /* | ||
162 | * Add to the active list so we can pick this up in | ||
163 | * ->lookup(). Also add an entry to a rehash list so | ||
164 | * we know when there are no dentrys in flight so we | ||
165 | * know when we can rehash the dentry. | ||
166 | */ | ||
167 | spin_lock(&sbi->lookup_lock); | ||
168 | if (list_empty(&ino->active)) | ||
169 | list_add(&ino->active, &sbi->active_list); | ||
170 | autofs4_add_rehash_entry(ino, entry); | ||
171 | spin_unlock(&sbi->lookup_lock); | ||
172 | if (!(ino->flags & AUTOFS_INF_REHASH)) { | ||
173 | ino->flags |= AUTOFS_INF_REHASH; | ||
174 | dget(dentry); | ||
175 | spin_lock(&dentry->d_lock); | ||
176 | __d_drop(dentry); | ||
177 | spin_unlock(&dentry->d_lock); | ||
178 | } | ||
179 | return; | ||
180 | } | ||
181 | |||
182 | static void autofs4_revalidate_rehash(struct dentry *dentry) | ||
183 | { | ||
184 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | ||
185 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
186 | if (ino->flags & AUTOFS_INF_REHASH) { | ||
187 | spin_lock(&sbi->lookup_lock); | ||
188 | autofs4_remove_rehash_entry(ino); | ||
189 | if (list_empty(&ino->rehash_list)) { | ||
190 | spin_unlock(&sbi->lookup_lock); | ||
191 | ino->flags &= ~AUTOFS_INF_REHASH; | ||
192 | d_rehash(dentry); | ||
193 | dput(ino->dentry); | ||
194 | } else | ||
195 | spin_unlock(&sbi->lookup_lock); | ||
196 | } | ||
197 | return; | ||
198 | } | ||
199 | |||
200 | static unsigned int autofs4_need_mount(unsigned int flags) | 107 | static unsigned int autofs4_need_mount(unsigned int flags) |
201 | { | 108 | { |
202 | unsigned int res = 0; | 109 | unsigned int res = 0; |
@@ -236,7 +143,7 @@ out: | |||
236 | return dcache_dir_open(inode, file); | 143 | return dcache_dir_open(inode, file); |
237 | } | 144 | } |
238 | 145 | ||
239 | static int try_to_fill_dentry(struct dentry *dentry) | 146 | static int try_to_fill_dentry(struct dentry *dentry, int flags) |
240 | { | 147 | { |
241 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | 148 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
242 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 149 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
@@ -249,17 +156,55 @@ static int try_to_fill_dentry(struct dentry *dentry) | |||
249 | * Wait for a pending mount, triggering one if there | 156 | * Wait for a pending mount, triggering one if there |
250 | * isn't one already | 157 | * isn't one already |
251 | */ | 158 | */ |
252 | DPRINTK("waiting for mount name=%.*s", | 159 | if (dentry->d_inode == NULL) { |
253 | dentry->d_name.len, dentry->d_name.name); | 160 | DPRINTK("waiting for mount name=%.*s", |
161 | dentry->d_name.len, dentry->d_name.name); | ||
254 | 162 | ||
255 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); | 163 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); |
256 | 164 | ||
257 | DPRINTK("mount done status=%d", status); | 165 | DPRINTK("mount done status=%d", status); |
258 | 166 | ||
259 | /* Update expiry counter */ | 167 | /* Turn this into a real negative dentry? */ |
260 | ino->last_used = jiffies; | 168 | if (status == -ENOENT) { |
169 | spin_lock(&sbi->fs_lock); | ||
170 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
171 | spin_unlock(&sbi->fs_lock); | ||
172 | return status; | ||
173 | } else if (status) { | ||
174 | /* Return a negative dentry, but leave it "pending" */ | ||
175 | return status; | ||
176 | } | ||
177 | /* Trigger mount for path component or follow link */ | ||
178 | } else if (ino->flags & AUTOFS_INF_PENDING || | ||
179 | autofs4_need_mount(flags) || | ||
180 | current->link_count) { | ||
181 | DPRINTK("waiting for mount name=%.*s", | ||
182 | dentry->d_name.len, dentry->d_name.name); | ||
261 | 183 | ||
262 | return status; | 184 | spin_lock(&sbi->fs_lock); |
185 | ino->flags |= AUTOFS_INF_PENDING; | ||
186 | spin_unlock(&sbi->fs_lock); | ||
187 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); | ||
188 | |||
189 | DPRINTK("mount done status=%d", status); | ||
190 | |||
191 | if (status) { | ||
192 | spin_lock(&sbi->fs_lock); | ||
193 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
194 | spin_unlock(&sbi->fs_lock); | ||
195 | return status; | ||
196 | } | ||
197 | } | ||
198 | |||
199 | /* Initialize expiry counter after successful mount */ | ||
200 | if (ino) | ||
201 | ino->last_used = jiffies; | ||
202 | |||
203 | spin_lock(&sbi->fs_lock); | ||
204 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
205 | spin_unlock(&sbi->fs_lock); | ||
206 | |||
207 | return 0; | ||
263 | } | 208 | } |
264 | 209 | ||
265 | /* For autofs direct mounts the follow link triggers the mount */ | 210 | /* For autofs direct mounts the follow link triggers the mount */ |
@@ -313,16 +258,10 @@ static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd) | |||
313 | */ | 258 | */ |
314 | if (ino->flags & AUTOFS_INF_PENDING || | 259 | if (ino->flags & AUTOFS_INF_PENDING || |
315 | (!d_mountpoint(dentry) && list_empty(&dentry->d_subdirs))) { | 260 | (!d_mountpoint(dentry) && list_empty(&dentry->d_subdirs))) { |
316 | ino->flags |= AUTOFS_INF_PENDING; | ||
317 | spin_unlock(&dcache_lock); | 261 | spin_unlock(&dcache_lock); |
318 | spin_unlock(&sbi->fs_lock); | 262 | spin_unlock(&sbi->fs_lock); |
319 | 263 | ||
320 | status = try_to_fill_dentry(dentry); | 264 | status = try_to_fill_dentry(dentry, 0); |
321 | |||
322 | spin_lock(&sbi->fs_lock); | ||
323 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
324 | spin_unlock(&sbi->fs_lock); | ||
325 | |||
326 | if (status) | 265 | if (status) |
327 | goto out_error; | 266 | goto out_error; |
328 | 267 | ||
@@ -361,47 +300,18 @@ static int autofs4_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
361 | { | 300 | { |
362 | struct inode *dir = dentry->d_parent->d_inode; | 301 | struct inode *dir = dentry->d_parent->d_inode; |
363 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 302 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
364 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 303 | int oz_mode = autofs4_oz_mode(sbi); |
365 | struct rehash_entry *entry; | ||
366 | int flags = nd ? nd->flags : 0; | 304 | int flags = nd ? nd->flags : 0; |
367 | unsigned int mutex_aquired; | 305 | int status = 1; |
368 | 306 | ||
369 | DPRINTK("name = %.*s oz_mode = %d", | ||
370 | dentry->d_name.len, dentry->d_name.name, oz_mode); | ||
371 | |||
372 | /* Daemon never causes a mount to trigger */ | ||
373 | if (autofs4_oz_mode(sbi)) | ||
374 | return 1; | ||
375 | |||
376 | entry = kmalloc(sizeof(struct rehash_entry), GFP_KERNEL); | ||
377 | if (!entry) | ||
378 | return -ENOMEM; | ||
379 | |||
380 | mutex_aquired = mutex_trylock(&dir->i_mutex); | ||
381 | |||
382 | spin_lock(&sbi->fs_lock); | ||
383 | spin_lock(&dcache_lock); | ||
384 | /* Pending dentry */ | 307 | /* Pending dentry */ |
308 | spin_lock(&sbi->fs_lock); | ||
385 | if (autofs4_ispending(dentry)) { | 309 | if (autofs4_ispending(dentry)) { |
386 | int status; | 310 | /* The daemon never causes a mount to trigger */ |
387 | |||
388 | /* | ||
389 | * We can only unhash and send this to ->lookup() if | ||
390 | * the directory mutex is held over d_revalidate() and | ||
391 | * ->lookup(). This prevents the VFS from incorrectly | ||
392 | * seeing the dentry as non-existent. | ||
393 | */ | ||
394 | ino->flags |= AUTOFS_INF_PENDING; | ||
395 | if (!mutex_aquired) { | ||
396 | autofs4_revalidate_drop(dentry, entry); | ||
397 | spin_unlock(&dcache_lock); | ||
398 | spin_unlock(&sbi->fs_lock); | ||
399 | return 0; | ||
400 | } | ||
401 | spin_unlock(&dcache_lock); | ||
402 | spin_unlock(&sbi->fs_lock); | 311 | spin_unlock(&sbi->fs_lock); |
403 | mutex_unlock(&dir->i_mutex); | 312 | |
404 | kfree(entry); | 313 | if (oz_mode) |
314 | return 1; | ||
405 | 315 | ||
406 | /* | 316 | /* |
407 | * If the directory has gone away due to an expire | 317 | * If the directory has gone away due to an expire |
@@ -415,82 +325,45 @@ static int autofs4_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
415 | * A zero status is success otherwise we have a | 325 | * A zero status is success otherwise we have a |
416 | * negative error code. | 326 | * negative error code. |
417 | */ | 327 | */ |
418 | status = try_to_fill_dentry(dentry); | 328 | status = try_to_fill_dentry(dentry, flags); |
419 | |||
420 | spin_lock(&sbi->fs_lock); | ||
421 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
422 | spin_unlock(&sbi->fs_lock); | ||
423 | |||
424 | if (status == 0) | 329 | if (status == 0) |
425 | return 1; | 330 | return 1; |
426 | 331 | ||
427 | return status; | 332 | return status; |
428 | } | 333 | } |
334 | spin_unlock(&sbi->fs_lock); | ||
335 | |||
336 | /* Negative dentry.. invalidate if "old" */ | ||
337 | if (dentry->d_inode == NULL) | ||
338 | return 0; | ||
429 | 339 | ||
430 | /* Check for a non-mountpoint directory with no contents */ | 340 | /* Check for a non-mountpoint directory with no contents */ |
341 | spin_lock(&dcache_lock); | ||
431 | if (S_ISDIR(dentry->d_inode->i_mode) && | 342 | if (S_ISDIR(dentry->d_inode->i_mode) && |
432 | !d_mountpoint(dentry) && list_empty(&dentry->d_subdirs)) { | 343 | !d_mountpoint(dentry) && list_empty(&dentry->d_subdirs)) { |
433 | DPRINTK("dentry=%p %.*s, emptydir", | 344 | DPRINTK("dentry=%p %.*s, emptydir", |
434 | dentry, dentry->d_name.len, dentry->d_name.name); | 345 | dentry, dentry->d_name.len, dentry->d_name.name); |
346 | spin_unlock(&dcache_lock); | ||
435 | 347 | ||
436 | if (autofs4_need_mount(flags) || current->link_count) { | 348 | /* The daemon never causes a mount to trigger */ |
437 | int status; | 349 | if (oz_mode) |
438 | 350 | return 1; | |
439 | /* | ||
440 | * We can only unhash and send this to ->lookup() if | ||
441 | * the directory mutex is held over d_revalidate() and | ||
442 | * ->lookup(). This prevents the VFS from incorrectly | ||
443 | * seeing the dentry as non-existent. | ||
444 | */ | ||
445 | ino->flags |= AUTOFS_INF_PENDING; | ||
446 | if (!mutex_aquired) { | ||
447 | autofs4_revalidate_drop(dentry, entry); | ||
448 | spin_unlock(&dcache_lock); | ||
449 | spin_unlock(&sbi->fs_lock); | ||
450 | return 0; | ||
451 | } | ||
452 | spin_unlock(&dcache_lock); | ||
453 | spin_unlock(&sbi->fs_lock); | ||
454 | mutex_unlock(&dir->i_mutex); | ||
455 | kfree(entry); | ||
456 | |||
457 | /* | ||
458 | * A zero status is success otherwise we have a | ||
459 | * negative error code. | ||
460 | */ | ||
461 | status = try_to_fill_dentry(dentry); | ||
462 | |||
463 | spin_lock(&sbi->fs_lock); | ||
464 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
465 | spin_unlock(&sbi->fs_lock); | ||
466 | 351 | ||
467 | if (status == 0) | 352 | /* |
468 | return 1; | 353 | * A zero status is success otherwise we have a |
354 | * negative error code. | ||
355 | */ | ||
356 | status = try_to_fill_dentry(dentry, flags); | ||
357 | if (status == 0) | ||
358 | return 1; | ||
469 | 359 | ||
470 | return status; | 360 | return status; |
471 | } | ||
472 | } | 361 | } |
473 | spin_unlock(&dcache_lock); | 362 | spin_unlock(&dcache_lock); |
474 | spin_unlock(&sbi->fs_lock); | ||
475 | |||
476 | if (mutex_aquired) | ||
477 | mutex_unlock(&dir->i_mutex); | ||
478 | |||
479 | kfree(entry); | ||
480 | 363 | ||
481 | return 1; | 364 | return 1; |
482 | } | 365 | } |
483 | 366 | ||
484 | static void autofs4_free_rehash_entrys(struct autofs_info *inf) | ||
485 | { | ||
486 | struct list_head *head = &inf->rehash_list; | ||
487 | struct rehash_entry *entry, *next; | ||
488 | list_for_each_entry_safe(entry, next, head, list) { | ||
489 | list_del(&entry->list); | ||
490 | kfree(entry); | ||
491 | } | ||
492 | } | ||
493 | |||
494 | void autofs4_dentry_release(struct dentry *de) | 367 | void autofs4_dentry_release(struct dentry *de) |
495 | { | 368 | { |
496 | struct autofs_info *inf; | 369 | struct autofs_info *inf; |
@@ -509,8 +382,6 @@ void autofs4_dentry_release(struct dentry *de) | |||
509 | list_del(&inf->active); | 382 | list_del(&inf->active); |
510 | if (!list_empty(&inf->expiring)) | 383 | if (!list_empty(&inf->expiring)) |
511 | list_del(&inf->expiring); | 384 | list_del(&inf->expiring); |
512 | if (!list_empty(&inf->rehash_list)) | ||
513 | autofs4_free_rehash_entrys(inf); | ||
514 | spin_unlock(&sbi->lookup_lock); | 385 | spin_unlock(&sbi->lookup_lock); |
515 | } | 386 | } |
516 | 387 | ||
@@ -543,7 +414,6 @@ static struct dentry *autofs4_lookup_active(struct dentry *dentry) | |||
543 | const unsigned char *str = name->name; | 414 | const unsigned char *str = name->name; |
544 | struct list_head *p, *head; | 415 | struct list_head *p, *head; |
545 | 416 | ||
546 | restart: | ||
547 | spin_lock(&dcache_lock); | 417 | spin_lock(&dcache_lock); |
548 | spin_lock(&sbi->lookup_lock); | 418 | spin_lock(&sbi->lookup_lock); |
549 | head = &sbi->active_list; | 419 | head = &sbi->active_list; |
@@ -561,19 +431,6 @@ restart: | |||
561 | if (atomic_read(&active->d_count) == 0) | 431 | if (atomic_read(&active->d_count) == 0) |
562 | goto next; | 432 | goto next; |
563 | 433 | ||
564 | if (active->d_inode && IS_DEADDIR(active->d_inode)) { | ||
565 | if (!list_empty(&ino->rehash_list)) { | ||
566 | dget(active); | ||
567 | spin_unlock(&active->d_lock); | ||
568 | spin_unlock(&sbi->lookup_lock); | ||
569 | spin_unlock(&dcache_lock); | ||
570 | autofs4_remove_rehash_entrys(ino); | ||
571 | dput(active); | ||
572 | goto restart; | ||
573 | } | ||
574 | goto next; | ||
575 | } | ||
576 | |||
577 | qstr = &active->d_name; | 434 | qstr = &active->d_name; |
578 | 435 | ||
579 | if (active->d_name.hash != hash) | 436 | if (active->d_name.hash != hash) |
@@ -586,11 +443,13 @@ restart: | |||
586 | if (memcmp(qstr->name, str, len)) | 443 | if (memcmp(qstr->name, str, len)) |
587 | goto next; | 444 | goto next; |
588 | 445 | ||
589 | dget(active); | 446 | if (d_unhashed(active)) { |
590 | spin_unlock(&active->d_lock); | 447 | dget(active); |
591 | spin_unlock(&sbi->lookup_lock); | 448 | spin_unlock(&active->d_lock); |
592 | spin_unlock(&dcache_lock); | 449 | spin_unlock(&sbi->lookup_lock); |
593 | return active; | 450 | spin_unlock(&dcache_lock); |
451 | return active; | ||
452 | } | ||
594 | next: | 453 | next: |
595 | spin_unlock(&active->d_lock); | 454 | spin_unlock(&active->d_lock); |
596 | } | 455 | } |
@@ -639,11 +498,13 @@ static struct dentry *autofs4_lookup_expiring(struct dentry *dentry) | |||
639 | if (memcmp(qstr->name, str, len)) | 498 | if (memcmp(qstr->name, str, len)) |
640 | goto next; | 499 | goto next; |
641 | 500 | ||
642 | dget(expiring); | 501 | if (d_unhashed(expiring)) { |
643 | spin_unlock(&expiring->d_lock); | 502 | dget(expiring); |
644 | spin_unlock(&sbi->lookup_lock); | 503 | spin_unlock(&expiring->d_lock); |
645 | spin_unlock(&dcache_lock); | 504 | spin_unlock(&sbi->lookup_lock); |
646 | return expiring; | 505 | spin_unlock(&dcache_lock); |
506 | return expiring; | ||
507 | } | ||
647 | next: | 508 | next: |
648 | spin_unlock(&expiring->d_lock); | 509 | spin_unlock(&expiring->d_lock); |
649 | } | 510 | } |
@@ -653,48 +514,6 @@ next: | |||
653 | return NULL; | 514 | return NULL; |
654 | } | 515 | } |
655 | 516 | ||
656 | static struct autofs_info *init_new_dentry(struct autofs_sb_info *sbi, | ||
657 | struct dentry *dentry, int oz_mode) | ||
658 | { | ||
659 | struct autofs_info *ino; | ||
660 | |||
661 | /* | ||
662 | * Mark the dentry incomplete but don't hash it. We do this | ||
663 | * to serialize our inode creation operations (symlink and | ||
664 | * mkdir) which prevents deadlock during the callback to | ||
665 | * the daemon. Subsequent user space lookups for the same | ||
666 | * dentry are placed on the wait queue while the daemon | ||
667 | * itself is allowed passage unresticted so the create | ||
668 | * operation itself can then hash the dentry. Finally, | ||
669 | * we check for the hashed dentry and return the newly | ||
670 | * hashed dentry. | ||
671 | */ | ||
672 | dentry->d_op = &autofs4_root_dentry_operations; | ||
673 | |||
674 | /* | ||
675 | * And we need to ensure that the same dentry is used for | ||
676 | * all following lookup calls until it is hashed so that | ||
677 | * the dentry flags are persistent throughout the request. | ||
678 | */ | ||
679 | ino = autofs4_init_ino(NULL, sbi, 0555); | ||
680 | if (!ino) | ||
681 | return ERR_PTR(-ENOMEM); | ||
682 | |||
683 | dentry->d_fsdata = ino; | ||
684 | ino->dentry = dentry; | ||
685 | |||
686 | /* | ||
687 | * Only set the mount pending flag for new dentrys not created | ||
688 | * by the daemon. | ||
689 | */ | ||
690 | if (!oz_mode) | ||
691 | ino->flags |= AUTOFS_INF_PENDING; | ||
692 | |||
693 | d_instantiate(dentry, NULL); | ||
694 | |||
695 | return ino; | ||
696 | } | ||
697 | |||
698 | /* Lookups in the root directory */ | 517 | /* Lookups in the root directory */ |
699 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 518 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) |
700 | { | 519 | { |
@@ -702,7 +521,6 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
702 | struct autofs_info *ino; | 521 | struct autofs_info *ino; |
703 | struct dentry *expiring, *active; | 522 | struct dentry *expiring, *active; |
704 | int oz_mode; | 523 | int oz_mode; |
705 | int status = 0; | ||
706 | 524 | ||
707 | DPRINTK("name = %.*s", | 525 | DPRINTK("name = %.*s", |
708 | dentry->d_name.len, dentry->d_name.name); | 526 | dentry->d_name.len, dentry->d_name.name); |
@@ -717,26 +535,44 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
717 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", | 535 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", |
718 | current->pid, task_pgrp_nr(current), sbi->catatonic, oz_mode); | 536 | current->pid, task_pgrp_nr(current), sbi->catatonic, oz_mode); |
719 | 537 | ||
720 | spin_lock(&sbi->fs_lock); | ||
721 | active = autofs4_lookup_active(dentry); | 538 | active = autofs4_lookup_active(dentry); |
722 | if (active) { | 539 | if (active) { |
723 | dentry = active; | 540 | dentry = active; |
724 | ino = autofs4_dentry_ino(dentry); | 541 | ino = autofs4_dentry_ino(dentry); |
725 | /* If this came from revalidate, rehash it */ | ||
726 | autofs4_revalidate_rehash(dentry); | ||
727 | spin_unlock(&sbi->fs_lock); | ||
728 | } else { | 542 | } else { |
729 | spin_unlock(&sbi->fs_lock); | 543 | /* |
730 | ino = init_new_dentry(sbi, dentry, oz_mode); | 544 | * Mark the dentry incomplete but don't hash it. We do this |
731 | if (IS_ERR(ino)) | 545 | * to serialize our inode creation operations (symlink and |
732 | return (struct dentry *) ino; | 546 | * mkdir) which prevents deadlock during the callback to |
733 | } | 547 | * the daemon. Subsequent user space lookups for the same |
548 | * dentry are placed on the wait queue while the daemon | ||
549 | * itself is allowed passage unresticted so the create | ||
550 | * operation itself can then hash the dentry. Finally, | ||
551 | * we check for the hashed dentry and return the newly | ||
552 | * hashed dentry. | ||
553 | */ | ||
554 | dentry->d_op = &autofs4_root_dentry_operations; | ||
555 | |||
556 | /* | ||
557 | * And we need to ensure that the same dentry is used for | ||
558 | * all following lookup calls until it is hashed so that | ||
559 | * the dentry flags are persistent throughout the request. | ||
560 | */ | ||
561 | ino = autofs4_init_ino(NULL, sbi, 0555); | ||
562 | if (!ino) | ||
563 | return ERR_PTR(-ENOMEM); | ||
734 | 564 | ||
735 | autofs4_add_active(dentry); | 565 | dentry->d_fsdata = ino; |
566 | ino->dentry = dentry; | ||
567 | |||
568 | autofs4_add_active(dentry); | ||
569 | |||
570 | d_instantiate(dentry, NULL); | ||
571 | } | ||
736 | 572 | ||
737 | if (!oz_mode) { | 573 | if (!oz_mode) { |
738 | expiring = autofs4_lookup_expiring(dentry); | ||
739 | mutex_unlock(&dir->i_mutex); | 574 | mutex_unlock(&dir->i_mutex); |
575 | expiring = autofs4_lookup_expiring(dentry); | ||
740 | if (expiring) { | 576 | if (expiring) { |
741 | /* | 577 | /* |
742 | * If we are racing with expire the request might not | 578 | * If we are racing with expire the request might not |
@@ -744,22 +580,23 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
744 | * so it must have been successful, so just wait for it. | 580 | * so it must have been successful, so just wait for it. |
745 | */ | 581 | */ |
746 | autofs4_expire_wait(expiring); | 582 | autofs4_expire_wait(expiring); |
583 | autofs4_del_expiring(expiring); | ||
747 | dput(expiring); | 584 | dput(expiring); |
748 | } | 585 | } |
749 | status = try_to_fill_dentry(dentry); | 586 | |
750 | mutex_lock(&dir->i_mutex); | ||
751 | spin_lock(&sbi->fs_lock); | 587 | spin_lock(&sbi->fs_lock); |
752 | ino->flags &= ~AUTOFS_INF_PENDING; | 588 | ino->flags |= AUTOFS_INF_PENDING; |
753 | spin_unlock(&sbi->fs_lock); | 589 | spin_unlock(&sbi->fs_lock); |
590 | if (dentry->d_op && dentry->d_op->d_revalidate) | ||
591 | (dentry->d_op->d_revalidate)(dentry, nd); | ||
592 | mutex_lock(&dir->i_mutex); | ||
754 | } | 593 | } |
755 | 594 | ||
756 | autofs4_del_active(dentry); | ||
757 | |||
758 | /* | 595 | /* |
759 | * If we had a mount fail, check if we had to handle | 596 | * If we are still pending, check if we had to handle |
760 | * a signal. If so we can force a restart.. | 597 | * a signal. If so we can force a restart.. |
761 | */ | 598 | */ |
762 | if (status) { | 599 | if (ino->flags & AUTOFS_INF_PENDING) { |
763 | /* See if we were interrupted */ | 600 | /* See if we were interrupted */ |
764 | if (signal_pending(current)) { | 601 | if (signal_pending(current)) { |
765 | sigset_t *sigset = ¤t->pending.signal; | 602 | sigset_t *sigset = ¤t->pending.signal; |
@@ -771,46 +608,43 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
771 | return ERR_PTR(-ERESTARTNOINTR); | 608 | return ERR_PTR(-ERESTARTNOINTR); |
772 | } | 609 | } |
773 | } | 610 | } |
774 | } | 611 | if (!oz_mode) { |
775 | 612 | spin_lock(&sbi->fs_lock); | |
776 | /* | 613 | ino->flags &= ~AUTOFS_INF_PENDING; |
777 | * User space can (and has done in the past) remove and re-create | 614 | spin_unlock(&sbi->fs_lock); |
778 | * this directory during the callback. This can leave us with an | ||
779 | * unhashed dentry, but a successful mount! So we need to | ||
780 | * perform another cached lookup in case the dentry now exists. | ||
781 | */ | ||
782 | if (!oz_mode && !have_submounts(dentry)) { | ||
783 | struct dentry *new; | ||
784 | new = d_lookup(dentry->d_parent, &dentry->d_name); | ||
785 | if (new) { | ||
786 | if (active) | ||
787 | dput(active); | ||
788 | return new; | ||
789 | } else { | ||
790 | if (!status) | ||
791 | status = -ENOENT; | ||
792 | } | 615 | } |
793 | } | 616 | } |
794 | 617 | ||
795 | /* | 618 | /* |
796 | * If we had a mount failure, return status to user space. | 619 | * If this dentry is unhashed, then we shouldn't honour this |
797 | * If the mount succeeded and we used a dentry from the active queue | 620 | * lookup. Returning ENOENT here doesn't do the right thing |
798 | * return it. | 621 | * for all system calls, but it should be OK for the operations |
622 | * we permit from an autofs. | ||
799 | */ | 623 | */ |
800 | if (status) { | 624 | if (!oz_mode && d_unhashed(dentry)) { |
801 | dentry = ERR_PTR(status); | ||
802 | if (active) | ||
803 | dput(active); | ||
804 | return dentry; | ||
805 | } else { | ||
806 | /* | 625 | /* |
807 | * Valid successful mount, return active dentry or NULL | 626 | * A user space application can (and has done in the past) |
808 | * for a new dentry. | 627 | * remove and re-create this directory during the callback. |
628 | * This can leave us with an unhashed dentry, but a | ||
629 | * successful mount! So we need to perform another | ||
630 | * cached lookup in case the dentry now exists. | ||
809 | */ | 631 | */ |
632 | struct dentry *parent = dentry->d_parent; | ||
633 | struct dentry *new = d_lookup(parent, &dentry->d_name); | ||
634 | if (new != NULL) | ||
635 | dentry = new; | ||
636 | else | ||
637 | dentry = ERR_PTR(-ENOENT); | ||
638 | |||
810 | if (active) | 639 | if (active) |
811 | return active; | 640 | dput(active); |
641 | |||
642 | return dentry; | ||
812 | } | 643 | } |
813 | 644 | ||
645 | if (active) | ||
646 | return active; | ||
647 | |||
814 | return NULL; | 648 | return NULL; |
815 | } | 649 | } |
816 | 650 | ||
@@ -834,6 +668,8 @@ static int autofs4_dir_symlink(struct inode *dir, | |||
834 | if (!ino) | 668 | if (!ino) |
835 | return -ENOMEM; | 669 | return -ENOMEM; |
836 | 670 | ||
671 | autofs4_del_active(dentry); | ||
672 | |||
837 | ino->size = strlen(symname); | 673 | ino->size = strlen(symname); |
838 | cp = kmalloc(ino->size + 1, GFP_KERNEL); | 674 | cp = kmalloc(ino->size + 1, GFP_KERNEL); |
839 | if (!cp) { | 675 | if (!cp) { |
@@ -910,6 +746,7 @@ static int autofs4_dir_unlink(struct inode *dir, struct dentry *dentry) | |||
910 | dir->i_mtime = CURRENT_TIME; | 746 | dir->i_mtime = CURRENT_TIME; |
911 | 747 | ||
912 | spin_lock(&dcache_lock); | 748 | spin_lock(&dcache_lock); |
749 | autofs4_add_expiring(dentry); | ||
913 | spin_lock(&dentry->d_lock); | 750 | spin_lock(&dentry->d_lock); |
914 | __d_drop(dentry); | 751 | __d_drop(dentry); |
915 | spin_unlock(&dentry->d_lock); | 752 | spin_unlock(&dentry->d_lock); |
@@ -935,6 +772,7 @@ static int autofs4_dir_rmdir(struct inode *dir, struct dentry *dentry) | |||
935 | spin_unlock(&dcache_lock); | 772 | spin_unlock(&dcache_lock); |
936 | return -ENOTEMPTY; | 773 | return -ENOTEMPTY; |
937 | } | 774 | } |
775 | autofs4_add_expiring(dentry); | ||
938 | spin_lock(&dentry->d_lock); | 776 | spin_lock(&dentry->d_lock); |
939 | __d_drop(dentry); | 777 | __d_drop(dentry); |
940 | spin_unlock(&dentry->d_lock); | 778 | spin_unlock(&dentry->d_lock); |
@@ -972,6 +810,8 @@ static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
972 | if (!ino) | 810 | if (!ino) |
973 | return -ENOMEM; | 811 | return -ENOMEM; |
974 | 812 | ||
813 | autofs4_del_active(dentry); | ||
814 | |||
975 | inode = autofs4_get_inode(dir->i_sb, ino); | 815 | inode = autofs4_get_inode(dir->i_sb, ino); |
976 | if (!inode) { | 816 | if (!inode) { |
977 | if (!dentry->d_fsdata) | 817 | if (!dentry->d_fsdata) |
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 8f3d9fd89604..f22a7d3dc362 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
@@ -15,6 +15,7 @@ | |||
15 | #include <linux/smp_lock.h> | 15 | #include <linux/smp_lock.h> |
16 | #include <linux/buffer_head.h> | 16 | #include <linux/buffer_head.h> |
17 | #include <linux/vfs.h> | 17 | #include <linux/vfs.h> |
18 | #include <linux/writeback.h> | ||
18 | #include <asm/uaccess.h> | 19 | #include <asm/uaccess.h> |
19 | #include "bfs.h" | 20 | #include "bfs.h" |
20 | 21 | ||
@@ -98,7 +99,7 @@ error: | |||
98 | return ERR_PTR(-EIO); | 99 | return ERR_PTR(-EIO); |
99 | } | 100 | } |
100 | 101 | ||
101 | static int bfs_write_inode(struct inode *inode, int wait) | 102 | static int bfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
102 | { | 103 | { |
103 | struct bfs_sb_info *info = BFS_SB(inode->i_sb); | 104 | struct bfs_sb_info *info = BFS_SB(inode->i_sb); |
104 | unsigned int ino = (u16)inode->i_ino; | 105 | unsigned int ino = (u16)inode->i_ino; |
@@ -147,7 +148,7 @@ static int bfs_write_inode(struct inode *inode, int wait) | |||
147 | di->i_eoffset = cpu_to_le32(i_sblock * BFS_BSIZE + inode->i_size - 1); | 148 | di->i_eoffset = cpu_to_le32(i_sblock * BFS_BSIZE + inode->i_size - 1); |
148 | 149 | ||
149 | mark_buffer_dirty(bh); | 150 | mark_buffer_dirty(bh); |
150 | if (wait) { | 151 | if (wbc->sync_mode == WB_SYNC_ALL) { |
151 | sync_dirty_buffer(bh); | 152 | sync_dirty_buffer(bh); |
152 | if (buffer_req(bh) && !buffer_uptodate(bh)) | 153 | if (buffer_req(bh) && !buffer_uptodate(bh)) |
153 | err = -EIO; | 154 | err = -EIO; |
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 2aa8ec6a0981..8b5cfdd4bfc1 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
@@ -2326,7 +2326,7 @@ int btrfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); | |||
2326 | int btrfs_readpage(struct file *file, struct page *page); | 2326 | int btrfs_readpage(struct file *file, struct page *page); |
2327 | void btrfs_delete_inode(struct inode *inode); | 2327 | void btrfs_delete_inode(struct inode *inode); |
2328 | void btrfs_put_inode(struct inode *inode); | 2328 | void btrfs_put_inode(struct inode *inode); |
2329 | int btrfs_write_inode(struct inode *inode, int wait); | 2329 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc); |
2330 | void btrfs_dirty_inode(struct inode *inode); | 2330 | void btrfs_dirty_inode(struct inode *inode); |
2331 | struct inode *btrfs_alloc_inode(struct super_block *sb); | 2331 | struct inode *btrfs_alloc_inode(struct super_block *sb); |
2332 | void btrfs_destroy_inode(struct inode *inode); | 2332 | void btrfs_destroy_inode(struct inode *inode); |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 4deb280f8969..c41db6d45ab6 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
@@ -3968,7 +3968,7 @@ err: | |||
3968 | return ret; | 3968 | return ret; |
3969 | } | 3969 | } |
3970 | 3970 | ||
3971 | int btrfs_write_inode(struct inode *inode, int wait) | 3971 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
3972 | { | 3972 | { |
3973 | struct btrfs_root *root = BTRFS_I(inode)->root; | 3973 | struct btrfs_root *root = BTRFS_I(inode)->root; |
3974 | struct btrfs_trans_handle *trans; | 3974 | struct btrfs_trans_handle *trans; |
@@ -3977,7 +3977,7 @@ int btrfs_write_inode(struct inode *inode, int wait) | |||
3977 | if (root->fs_info->btree_inode == inode) | 3977 | if (root->fs_info->btree_inode == inode) |
3978 | return 0; | 3978 | return 0; |
3979 | 3979 | ||
3980 | if (wait) { | 3980 | if (wbc->sync_mode == WB_SYNC_ALL) { |
3981 | trans = btrfs_join_transaction(root, 1); | 3981 | trans = btrfs_join_transaction(root, 1); |
3982 | btrfs_set_trans_block_group(trans, inode); | 3982 | btrfs_set_trans_block_group(trans, inode); |
3983 | ret = btrfs_commit_transaction(trans, root); | 3983 | ret = btrfs_commit_transaction(trans, root); |
diff --git a/fs/cifs/CHANGES b/fs/cifs/CHANGES index 49503d2edc7e..bc0025cdd1c9 100644 --- a/fs/cifs/CHANGES +++ b/fs/cifs/CHANGES | |||
@@ -1,6 +1,7 @@ | |||
1 | Version 1.62 | 1 | Version 1.62 |
2 | ------------ | 2 | ------------ |
3 | Add sockopt=TCP_NODELAY mount option. | 3 | Add sockopt=TCP_NODELAY mount option. EA (xattr) routines hardened |
4 | to more strictly handle corrupt frames. | ||
4 | 5 | ||
5 | Version 1.61 | 6 | Version 1.61 |
6 | ------------ | 7 | ------------ |
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index ed751bb657db..a1c817eb291a 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
@@ -205,7 +205,7 @@ struct cifsUidInfo { | |||
205 | struct cifsSesInfo { | 205 | struct cifsSesInfo { |
206 | struct list_head smb_ses_list; | 206 | struct list_head smb_ses_list; |
207 | struct list_head tcon_list; | 207 | struct list_head tcon_list; |
208 | struct semaphore sesSem; | 208 | struct mutex session_mutex; |
209 | #if 0 | 209 | #if 0 |
210 | struct cifsUidInfo *uidInfo; /* pointer to user info */ | 210 | struct cifsUidInfo *uidInfo; /* pointer to user info */ |
211 | #endif | 211 | #endif |
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index 3877737f96a6..14d036d8db11 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h | |||
@@ -415,10 +415,10 @@ struct smb_hdr { | |||
415 | __u8 WordCount; | 415 | __u8 WordCount; |
416 | } __attribute__((packed)); | 416 | } __attribute__((packed)); |
417 | /* given a pointer to an smb_hdr retrieve the value of byte count */ | 417 | /* given a pointer to an smb_hdr retrieve the value of byte count */ |
418 | #define BCC(smb_var) (*(__u16 *)((char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount))) | 418 | #define BCC(smb_var) (*(__u16 *)((char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount))) |
419 | #define BCC_LE(smb_var) (*(__le16 *)((char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount))) | 419 | #define BCC_LE(smb_var) (*(__le16 *)((char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount))) |
420 | /* given a pointer to an smb_hdr retrieve the pointer to the byte area */ | 420 | /* given a pointer to an smb_hdr retrieve the pointer to the byte area */ |
421 | #define pByteArea(smb_var) ((unsigned char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount) + 2) | 421 | #define pByteArea(smb_var) ((unsigned char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount) + 2) |
422 | 422 | ||
423 | /* | 423 | /* |
424 | * Computer Name Length (since Netbios name was length 16 with last byte 0x20) | 424 | * Computer Name Length (since Netbios name was length 16 with last byte 0x20) |
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index 5646727e33f5..88e2bc44ac58 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h | |||
@@ -363,13 +363,10 @@ extern int CIFSSMBNotify(const int xid, struct cifsTconInfo *tcon, | |||
363 | __u32 filter, struct file *file, int multishot, | 363 | __u32 filter, struct file *file, int multishot, |
364 | const struct nls_table *nls_codepage); | 364 | const struct nls_table *nls_codepage); |
365 | extern ssize_t CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, | 365 | extern ssize_t CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, |
366 | const unsigned char *searchName, char *EAData, | 366 | const unsigned char *searchName, |
367 | const unsigned char *ea_name, char *EAData, | ||
367 | size_t bufsize, const struct nls_table *nls_codepage, | 368 | size_t bufsize, const struct nls_table *nls_codepage, |
368 | int remap_special_chars); | 369 | int remap_special_chars); |
369 | extern ssize_t CIFSSMBQueryEA(const int xid, struct cifsTconInfo *tcon, | ||
370 | const unsigned char *searchName, const unsigned char *ea_name, | ||
371 | unsigned char *ea_value, size_t buf_size, | ||
372 | const struct nls_table *nls_codepage, int remap_special_chars); | ||
373 | extern int CIFSSMBSetEA(const int xid, struct cifsTconInfo *tcon, | 370 | extern int CIFSSMBSetEA(const int xid, struct cifsTconInfo *tcon, |
374 | const char *fileName, const char *ea_name, | 371 | const char *fileName, const char *ea_name, |
375 | const void *ea_value, const __u16 ea_value_len, | 372 | const void *ea_value, const __u16 ea_value_len, |
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 941441d3e386..9d17df3e0768 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c | |||
@@ -170,19 +170,19 @@ cifs_reconnect_tcon(struct cifsTconInfo *tcon, int smb_command) | |||
170 | * need to prevent multiple threads trying to simultaneously | 170 | * need to prevent multiple threads trying to simultaneously |
171 | * reconnect the same SMB session | 171 | * reconnect the same SMB session |
172 | */ | 172 | */ |
173 | down(&ses->sesSem); | 173 | mutex_lock(&ses->session_mutex); |
174 | if (ses->need_reconnect) | 174 | if (ses->need_reconnect) |
175 | rc = cifs_setup_session(0, ses, nls_codepage); | 175 | rc = cifs_setup_session(0, ses, nls_codepage); |
176 | 176 | ||
177 | /* do we need to reconnect tcon? */ | 177 | /* do we need to reconnect tcon? */ |
178 | if (rc || !tcon->need_reconnect) { | 178 | if (rc || !tcon->need_reconnect) { |
179 | up(&ses->sesSem); | 179 | mutex_unlock(&ses->session_mutex); |
180 | goto out; | 180 | goto out; |
181 | } | 181 | } |
182 | 182 | ||
183 | mark_open_files_invalid(tcon); | 183 | mark_open_files_invalid(tcon); |
184 | rc = CIFSTCon(0, ses, tcon->treeName, tcon, nls_codepage); | 184 | rc = CIFSTCon(0, ses, tcon->treeName, tcon, nls_codepage); |
185 | up(&ses->sesSem); | 185 | mutex_unlock(&ses->session_mutex); |
186 | cFYI(1, ("reconnect tcon rc = %d", rc)); | 186 | cFYI(1, ("reconnect tcon rc = %d", rc)); |
187 | 187 | ||
188 | if (rc) | 188 | if (rc) |
@@ -700,13 +700,13 @@ CIFSSMBLogoff(const int xid, struct cifsSesInfo *ses) | |||
700 | if (!ses || !ses->server) | 700 | if (!ses || !ses->server) |
701 | return -EIO; | 701 | return -EIO; |
702 | 702 | ||
703 | down(&ses->sesSem); | 703 | mutex_lock(&ses->session_mutex); |
704 | if (ses->need_reconnect) | 704 | if (ses->need_reconnect) |
705 | goto session_already_dead; /* no need to send SMBlogoff if uid | 705 | goto session_already_dead; /* no need to send SMBlogoff if uid |
706 | already closed due to reconnect */ | 706 | already closed due to reconnect */ |
707 | rc = small_smb_init(SMB_COM_LOGOFF_ANDX, 2, NULL, (void **)&pSMB); | 707 | rc = small_smb_init(SMB_COM_LOGOFF_ANDX, 2, NULL, (void **)&pSMB); |
708 | if (rc) { | 708 | if (rc) { |
709 | up(&ses->sesSem); | 709 | mutex_unlock(&ses->session_mutex); |
710 | return rc; | 710 | return rc; |
711 | } | 711 | } |
712 | 712 | ||
@@ -721,7 +721,7 @@ CIFSSMBLogoff(const int xid, struct cifsSesInfo *ses) | |||
721 | pSMB->AndXCommand = 0xFF; | 721 | pSMB->AndXCommand = 0xFF; |
722 | rc = SendReceiveNoRsp(xid, ses, (struct smb_hdr *) pSMB, 0); | 722 | rc = SendReceiveNoRsp(xid, ses, (struct smb_hdr *) pSMB, 0); |
723 | session_already_dead: | 723 | session_already_dead: |
724 | up(&ses->sesSem); | 724 | mutex_unlock(&ses->session_mutex); |
725 | 725 | ||
726 | /* if session dead then we do not need to do ulogoff, | 726 | /* if session dead then we do not need to do ulogoff, |
727 | since server closed smb session, no sense reporting | 727 | since server closed smb session, no sense reporting |
@@ -5269,22 +5269,34 @@ int CIFSSMBNotify(const int xid, struct cifsTconInfo *tcon, | |||
5269 | cifs_buf_release(pSMB); | 5269 | cifs_buf_release(pSMB); |
5270 | return rc; | 5270 | return rc; |
5271 | } | 5271 | } |
5272 | |||
5272 | #ifdef CONFIG_CIFS_XATTR | 5273 | #ifdef CONFIG_CIFS_XATTR |
5274 | /* | ||
5275 | * Do a path-based QUERY_ALL_EAS call and parse the result. This is a common | ||
5276 | * function used by listxattr and getxattr type calls. When ea_name is set, | ||
5277 | * it looks for that attribute name and stuffs that value into the EAData | ||
5278 | * buffer. When ea_name is NULL, it stuffs a list of attribute names into the | ||
5279 | * buffer. In both cases, the return value is either the length of the | ||
5280 | * resulting data or a negative error code. If EAData is a NULL pointer then | ||
5281 | * the data isn't copied to it, but the length is returned. | ||
5282 | */ | ||
5273 | ssize_t | 5283 | ssize_t |
5274 | CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, | 5284 | CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, |
5275 | const unsigned char *searchName, | 5285 | const unsigned char *searchName, const unsigned char *ea_name, |
5276 | char *EAData, size_t buf_size, | 5286 | char *EAData, size_t buf_size, |
5277 | const struct nls_table *nls_codepage, int remap) | 5287 | const struct nls_table *nls_codepage, int remap) |
5278 | { | 5288 | { |
5279 | /* BB assumes one setup word */ | 5289 | /* BB assumes one setup word */ |
5280 | TRANSACTION2_QPI_REQ *pSMB = NULL; | 5290 | TRANSACTION2_QPI_REQ *pSMB = NULL; |
5281 | TRANSACTION2_QPI_RSP *pSMBr = NULL; | 5291 | TRANSACTION2_QPI_RSP *pSMBr = NULL; |
5282 | int rc = 0; | 5292 | int rc = 0; |
5283 | int bytes_returned; | 5293 | int bytes_returned; |
5284 | int name_len; | 5294 | int list_len; |
5295 | struct fealist *ea_response_data; | ||
5285 | struct fea *temp_fea; | 5296 | struct fea *temp_fea; |
5286 | char *temp_ptr; | 5297 | char *temp_ptr; |
5287 | __u16 params, byte_count; | 5298 | char *end_of_smb; |
5299 | __u16 params, byte_count, data_offset; | ||
5288 | 5300 | ||
5289 | cFYI(1, ("In Query All EAs path %s", searchName)); | 5301 | cFYI(1, ("In Query All EAs path %s", searchName)); |
5290 | QAllEAsRetry: | 5302 | QAllEAsRetry: |
@@ -5294,22 +5306,22 @@ QAllEAsRetry: | |||
5294 | return rc; | 5306 | return rc; |
5295 | 5307 | ||
5296 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { | 5308 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { |
5297 | name_len = | 5309 | list_len = |
5298 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, | 5310 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, |
5299 | PATH_MAX, nls_codepage, remap); | 5311 | PATH_MAX, nls_codepage, remap); |
5300 | name_len++; /* trailing null */ | 5312 | list_len++; /* trailing null */ |
5301 | name_len *= 2; | 5313 | list_len *= 2; |
5302 | } else { /* BB improve the check for buffer overruns BB */ | 5314 | } else { /* BB improve the check for buffer overruns BB */ |
5303 | name_len = strnlen(searchName, PATH_MAX); | 5315 | list_len = strnlen(searchName, PATH_MAX); |
5304 | name_len++; /* trailing null */ | 5316 | list_len++; /* trailing null */ |
5305 | strncpy(pSMB->FileName, searchName, name_len); | 5317 | strncpy(pSMB->FileName, searchName, list_len); |
5306 | } | 5318 | } |
5307 | 5319 | ||
5308 | params = 2 /* level */ + 4 /* reserved */ + name_len /* includes NUL */; | 5320 | params = 2 /* level */ + 4 /* reserved */ + list_len /* includes NUL */; |
5309 | pSMB->TotalDataCount = 0; | 5321 | pSMB->TotalDataCount = 0; |
5310 | pSMB->MaxParameterCount = cpu_to_le16(2); | 5322 | pSMB->MaxParameterCount = cpu_to_le16(2); |
5311 | /* BB find exact max SMB PDU from sess structure BB */ | 5323 | /* BB find exact max SMB PDU from sess structure BB */ |
5312 | pSMB->MaxDataCount = cpu_to_le16(4000); | 5324 | pSMB->MaxDataCount = cpu_to_le16(CIFSMaxBufSize); |
5313 | pSMB->MaxSetupCount = 0; | 5325 | pSMB->MaxSetupCount = 0; |
5314 | pSMB->Reserved = 0; | 5326 | pSMB->Reserved = 0; |
5315 | pSMB->Flags = 0; | 5327 | pSMB->Flags = 0; |
@@ -5334,237 +5346,117 @@ QAllEAsRetry: | |||
5334 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 5346 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); |
5335 | if (rc) { | 5347 | if (rc) { |
5336 | cFYI(1, ("Send error in QueryAllEAs = %d", rc)); | 5348 | cFYI(1, ("Send error in QueryAllEAs = %d", rc)); |
5337 | } else { /* decode response */ | 5349 | goto QAllEAsOut; |
5338 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 5350 | } |
5339 | 5351 | ||
5340 | /* BB also check enough total bytes returned */ | 5352 | |
5341 | /* BB we need to improve the validity checking | 5353 | /* BB also check enough total bytes returned */ |
5342 | of these trans2 responses */ | 5354 | /* BB we need to improve the validity checking |
5343 | if (rc || (pSMBr->ByteCount < 4)) | 5355 | of these trans2 responses */ |
5344 | rc = -EIO; /* bad smb */ | 5356 | |
5345 | /* else if (pFindData){ | 5357 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); |
5346 | memcpy((char *) pFindData, | 5358 | if (rc || (pSMBr->ByteCount < 4)) { |
5347 | (char *) &pSMBr->hdr.Protocol + | 5359 | rc = -EIO; /* bad smb */ |
5348 | data_offset, kl); | 5360 | goto QAllEAsOut; |
5349 | }*/ else { | ||
5350 | /* check that length of list is not more than bcc */ | ||
5351 | /* check that each entry does not go beyond length | ||
5352 | of list */ | ||
5353 | /* check that each element of each entry does not | ||
5354 | go beyond end of list */ | ||
5355 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); | ||
5356 | struct fealist *ea_response_data; | ||
5357 | rc = 0; | ||
5358 | /* validate_trans2_offsets() */ | ||
5359 | /* BB check if start of smb + data_offset > &bcc+ bcc */ | ||
5360 | ea_response_data = (struct fealist *) | ||
5361 | (((char *) &pSMBr->hdr.Protocol) + | ||
5362 | data_offset); | ||
5363 | name_len = le32_to_cpu(ea_response_data->list_len); | ||
5364 | cFYI(1, ("ea length %d", name_len)); | ||
5365 | if (name_len <= 8) { | ||
5366 | /* returned EA size zeroed at top of function */ | ||
5367 | cFYI(1, ("empty EA list returned from server")); | ||
5368 | } else { | ||
5369 | /* account for ea list len */ | ||
5370 | name_len -= 4; | ||
5371 | temp_fea = ea_response_data->list; | ||
5372 | temp_ptr = (char *)temp_fea; | ||
5373 | while (name_len > 0) { | ||
5374 | __u16 value_len; | ||
5375 | name_len -= 4; | ||
5376 | temp_ptr += 4; | ||
5377 | rc += temp_fea->name_len; | ||
5378 | /* account for prefix user. and trailing null */ | ||
5379 | rc = rc + 5 + 1; | ||
5380 | if (rc < (int)buf_size) { | ||
5381 | memcpy(EAData, "user.", 5); | ||
5382 | EAData += 5; | ||
5383 | memcpy(EAData, temp_ptr, | ||
5384 | temp_fea->name_len); | ||
5385 | EAData += temp_fea->name_len; | ||
5386 | /* null terminate name */ | ||
5387 | *EAData = 0; | ||
5388 | EAData = EAData + 1; | ||
5389 | } else if (buf_size == 0) { | ||
5390 | /* skip copy - calc size only */ | ||
5391 | } else { | ||
5392 | /* stop before overrun buffer */ | ||
5393 | rc = -ERANGE; | ||
5394 | break; | ||
5395 | } | ||
5396 | name_len -= temp_fea->name_len; | ||
5397 | temp_ptr += temp_fea->name_len; | ||
5398 | /* account for trailing null */ | ||
5399 | name_len--; | ||
5400 | temp_ptr++; | ||
5401 | value_len = | ||
5402 | le16_to_cpu(temp_fea->value_len); | ||
5403 | name_len -= value_len; | ||
5404 | temp_ptr += value_len; | ||
5405 | /* BB check that temp_ptr is still | ||
5406 | within the SMB BB*/ | ||
5407 | |||
5408 | /* no trailing null to account for | ||
5409 | in value len */ | ||
5410 | /* go on to next EA */ | ||
5411 | temp_fea = (struct fea *)temp_ptr; | ||
5412 | } | ||
5413 | } | ||
5414 | } | ||
5415 | } | 5361 | } |
5416 | cifs_buf_release(pSMB); | ||
5417 | if (rc == -EAGAIN) | ||
5418 | goto QAllEAsRetry; | ||
5419 | 5362 | ||
5420 | return (ssize_t)rc; | 5363 | /* check that length of list is not more than bcc */ |
5421 | } | 5364 | /* check that each entry does not go beyond length |
5365 | of list */ | ||
5366 | /* check that each element of each entry does not | ||
5367 | go beyond end of list */ | ||
5368 | /* validate_trans2_offsets() */ | ||
5369 | /* BB check if start of smb + data_offset > &bcc+ bcc */ | ||
5422 | 5370 | ||
5423 | ssize_t CIFSSMBQueryEA(const int xid, struct cifsTconInfo *tcon, | 5371 | data_offset = le16_to_cpu(pSMBr->t2.DataOffset); |
5424 | const unsigned char *searchName, const unsigned char *ea_name, | 5372 | ea_response_data = (struct fealist *) |
5425 | unsigned char *ea_value, size_t buf_size, | 5373 | (((char *) &pSMBr->hdr.Protocol) + data_offset); |
5426 | const struct nls_table *nls_codepage, int remap) | ||
5427 | { | ||
5428 | TRANSACTION2_QPI_REQ *pSMB = NULL; | ||
5429 | TRANSACTION2_QPI_RSP *pSMBr = NULL; | ||
5430 | int rc = 0; | ||
5431 | int bytes_returned; | ||
5432 | int name_len; | ||
5433 | struct fea *temp_fea; | ||
5434 | char *temp_ptr; | ||
5435 | __u16 params, byte_count; | ||
5436 | 5374 | ||
5437 | cFYI(1, ("In Query EA path %s", searchName)); | 5375 | list_len = le32_to_cpu(ea_response_data->list_len); |
5438 | QEARetry: | 5376 | cFYI(1, ("ea length %d", list_len)); |
5439 | rc = smb_init(SMB_COM_TRANSACTION2, 15, tcon, (void **) &pSMB, | 5377 | if (list_len <= 8) { |
5440 | (void **) &pSMBr); | 5378 | cFYI(1, ("empty EA list returned from server")); |
5441 | if (rc) | 5379 | goto QAllEAsOut; |
5442 | return rc; | 5380 | } |
5443 | 5381 | ||
5444 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { | 5382 | /* make sure list_len doesn't go past end of SMB */ |
5445 | name_len = | 5383 | end_of_smb = (char *)pByteArea(&pSMBr->hdr) + BCC(&pSMBr->hdr); |
5446 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, | 5384 | if ((char *)ea_response_data + list_len > end_of_smb) { |
5447 | PATH_MAX, nls_codepage, remap); | 5385 | cFYI(1, ("EA list appears to go beyond SMB")); |
5448 | name_len++; /* trailing null */ | 5386 | rc = -EIO; |
5449 | name_len *= 2; | 5387 | goto QAllEAsOut; |
5450 | } else { /* BB improve the check for buffer overruns BB */ | ||
5451 | name_len = strnlen(searchName, PATH_MAX); | ||
5452 | name_len++; /* trailing null */ | ||
5453 | strncpy(pSMB->FileName, searchName, name_len); | ||
5454 | } | 5388 | } |
5455 | 5389 | ||
5456 | params = 2 /* level */ + 4 /* reserved */ + name_len /* includes NUL */; | 5390 | /* account for ea list len */ |
5457 | pSMB->TotalDataCount = 0; | 5391 | list_len -= 4; |
5458 | pSMB->MaxParameterCount = cpu_to_le16(2); | 5392 | temp_fea = ea_response_data->list; |
5459 | /* BB find exact max SMB PDU from sess structure BB */ | 5393 | temp_ptr = (char *)temp_fea; |
5460 | pSMB->MaxDataCount = cpu_to_le16(4000); | 5394 | while (list_len > 0) { |
5461 | pSMB->MaxSetupCount = 0; | 5395 | unsigned int name_len; |
5462 | pSMB->Reserved = 0; | 5396 | __u16 value_len; |
5463 | pSMB->Flags = 0; | 5397 | |
5464 | pSMB->Timeout = 0; | 5398 | list_len -= 4; |
5465 | pSMB->Reserved2 = 0; | 5399 | temp_ptr += 4; |
5466 | pSMB->ParameterOffset = cpu_to_le16(offsetof( | 5400 | /* make sure we can read name_len and value_len */ |
5467 | struct smb_com_transaction2_qpi_req, InformationLevel) - 4); | 5401 | if (list_len < 0) { |
5468 | pSMB->DataCount = 0; | 5402 | cFYI(1, ("EA entry goes beyond length of list")); |
5469 | pSMB->DataOffset = 0; | 5403 | rc = -EIO; |
5470 | pSMB->SetupCount = 1; | 5404 | goto QAllEAsOut; |
5471 | pSMB->Reserved3 = 0; | 5405 | } |
5472 | pSMB->SubCommand = cpu_to_le16(TRANS2_QUERY_PATH_INFORMATION); | ||
5473 | byte_count = params + 1 /* pad */ ; | ||
5474 | pSMB->TotalParameterCount = cpu_to_le16(params); | ||
5475 | pSMB->ParameterCount = pSMB->TotalParameterCount; | ||
5476 | pSMB->InformationLevel = cpu_to_le16(SMB_INFO_QUERY_ALL_EAS); | ||
5477 | pSMB->Reserved4 = 0; | ||
5478 | pSMB->hdr.smb_buf_length += byte_count; | ||
5479 | pSMB->ByteCount = cpu_to_le16(byte_count); | ||
5480 | 5406 | ||
5481 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, | 5407 | name_len = temp_fea->name_len; |
5482 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 5408 | value_len = le16_to_cpu(temp_fea->value_len); |
5483 | if (rc) { | 5409 | list_len -= name_len + 1 + value_len; |
5484 | cFYI(1, ("Send error in Query EA = %d", rc)); | 5410 | if (list_len < 0) { |
5485 | } else { /* decode response */ | 5411 | cFYI(1, ("EA entry goes beyond length of list")); |
5486 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 5412 | rc = -EIO; |
5413 | goto QAllEAsOut; | ||
5414 | } | ||
5487 | 5415 | ||
5488 | /* BB also check enough total bytes returned */ | 5416 | if (ea_name) { |
5489 | /* BB we need to improve the validity checking | 5417 | if (strncmp(ea_name, temp_ptr, name_len) == 0) { |
5490 | of these trans2 responses */ | 5418 | temp_ptr += name_len + 1; |
5491 | if (rc || (pSMBr->ByteCount < 4)) | 5419 | rc = value_len; |
5492 | rc = -EIO; /* bad smb */ | 5420 | if (buf_size == 0) |
5493 | /* else if (pFindData){ | 5421 | goto QAllEAsOut; |
5494 | memcpy((char *) pFindData, | 5422 | if ((size_t)value_len > buf_size) { |
5495 | (char *) &pSMBr->hdr.Protocol + | 5423 | rc = -ERANGE; |
5496 | data_offset, kl); | 5424 | goto QAllEAsOut; |
5497 | }*/ else { | ||
5498 | /* check that length of list is not more than bcc */ | ||
5499 | /* check that each entry does not go beyond length | ||
5500 | of list */ | ||
5501 | /* check that each element of each entry does not | ||
5502 | go beyond end of list */ | ||
5503 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); | ||
5504 | struct fealist *ea_response_data; | ||
5505 | rc = -ENODATA; | ||
5506 | /* validate_trans2_offsets() */ | ||
5507 | /* BB check if start of smb + data_offset > &bcc+ bcc*/ | ||
5508 | ea_response_data = (struct fealist *) | ||
5509 | (((char *) &pSMBr->hdr.Protocol) + | ||
5510 | data_offset); | ||
5511 | name_len = le32_to_cpu(ea_response_data->list_len); | ||
5512 | cFYI(1, ("ea length %d", name_len)); | ||
5513 | if (name_len <= 8) { | ||
5514 | /* returned EA size zeroed at top of function */ | ||
5515 | cFYI(1, ("empty EA list returned from server")); | ||
5516 | } else { | ||
5517 | /* account for ea list len */ | ||
5518 | name_len -= 4; | ||
5519 | temp_fea = ea_response_data->list; | ||
5520 | temp_ptr = (char *)temp_fea; | ||
5521 | /* loop through checking if we have a matching | ||
5522 | name and then return the associated value */ | ||
5523 | while (name_len > 0) { | ||
5524 | __u16 value_len; | ||
5525 | name_len -= 4; | ||
5526 | temp_ptr += 4; | ||
5527 | value_len = | ||
5528 | le16_to_cpu(temp_fea->value_len); | ||
5529 | /* BB validate that value_len falls within SMB, | ||
5530 | even though maximum for name_len is 255 */ | ||
5531 | if (memcmp(temp_fea->name, ea_name, | ||
5532 | temp_fea->name_len) == 0) { | ||
5533 | /* found a match */ | ||
5534 | rc = value_len; | ||
5535 | /* account for prefix user. and trailing null */ | ||
5536 | if (rc <= (int)buf_size) { | ||
5537 | memcpy(ea_value, | ||
5538 | temp_fea->name+temp_fea->name_len+1, | ||
5539 | rc); | ||
5540 | /* ea values, unlike ea | ||
5541 | names, are not null | ||
5542 | terminated */ | ||
5543 | } else if (buf_size == 0) { | ||
5544 | /* skip copy - calc size only */ | ||
5545 | } else { | ||
5546 | /* stop before overrun buffer */ | ||
5547 | rc = -ERANGE; | ||
5548 | } | ||
5549 | break; | ||
5550 | } | ||
5551 | name_len -= temp_fea->name_len; | ||
5552 | temp_ptr += temp_fea->name_len; | ||
5553 | /* account for trailing null */ | ||
5554 | name_len--; | ||
5555 | temp_ptr++; | ||
5556 | name_len -= value_len; | ||
5557 | temp_ptr += value_len; | ||
5558 | /* No trailing null to account for in | ||
5559 | value_len. Go on to next EA */ | ||
5560 | temp_fea = (struct fea *)temp_ptr; | ||
5561 | } | 5425 | } |
5426 | memcpy(EAData, temp_ptr, value_len); | ||
5427 | goto QAllEAsOut; | ||
5428 | } | ||
5429 | } else { | ||
5430 | /* account for prefix user. and trailing null */ | ||
5431 | rc += (5 + 1 + name_len); | ||
5432 | if (rc < (int) buf_size) { | ||
5433 | memcpy(EAData, "user.", 5); | ||
5434 | EAData += 5; | ||
5435 | memcpy(EAData, temp_ptr, name_len); | ||
5436 | EAData += name_len; | ||
5437 | /* null terminate name */ | ||
5438 | *EAData = 0; | ||
5439 | ++EAData; | ||
5440 | } else if (buf_size == 0) { | ||
5441 | /* skip copy - calc size only */ | ||
5442 | } else { | ||
5443 | /* stop before overrun buffer */ | ||
5444 | rc = -ERANGE; | ||
5445 | break; | ||
5562 | } | 5446 | } |
5563 | } | 5447 | } |
5448 | temp_ptr += name_len + 1 + value_len; | ||
5449 | temp_fea = (struct fea *)temp_ptr; | ||
5564 | } | 5450 | } |
5451 | |||
5452 | /* didn't find the named attribute */ | ||
5453 | if (ea_name) | ||
5454 | rc = -ENODATA; | ||
5455 | |||
5456 | QAllEAsOut: | ||
5565 | cifs_buf_release(pSMB); | 5457 | cifs_buf_release(pSMB); |
5566 | if (rc == -EAGAIN) | 5458 | if (rc == -EAGAIN) |
5567 | goto QEARetry; | 5459 | goto QAllEAsRetry; |
5568 | 5460 | ||
5569 | return (ssize_t)rc; | 5461 | return (ssize_t)rc; |
5570 | } | 5462 | } |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 2e9e09ca0e30..45eb6cba793f 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -2388,13 +2388,13 @@ try_mount_again: | |||
2388 | */ | 2388 | */ |
2389 | cifs_put_tcp_session(srvTcp); | 2389 | cifs_put_tcp_session(srvTcp); |
2390 | 2390 | ||
2391 | down(&pSesInfo->sesSem); | 2391 | mutex_lock(&pSesInfo->session_mutex); |
2392 | if (pSesInfo->need_reconnect) { | 2392 | if (pSesInfo->need_reconnect) { |
2393 | cFYI(1, ("Session needs reconnect")); | 2393 | cFYI(1, ("Session needs reconnect")); |
2394 | rc = cifs_setup_session(xid, pSesInfo, | 2394 | rc = cifs_setup_session(xid, pSesInfo, |
2395 | cifs_sb->local_nls); | 2395 | cifs_sb->local_nls); |
2396 | } | 2396 | } |
2397 | up(&pSesInfo->sesSem); | 2397 | mutex_unlock(&pSesInfo->session_mutex); |
2398 | } else if (!rc) { | 2398 | } else if (!rc) { |
2399 | cFYI(1, ("Existing smb sess not found")); | 2399 | cFYI(1, ("Existing smb sess not found")); |
2400 | pSesInfo = sesInfoAlloc(); | 2400 | pSesInfo = sesInfoAlloc(); |
@@ -2437,12 +2437,12 @@ try_mount_again: | |||
2437 | } | 2437 | } |
2438 | pSesInfo->linux_uid = volume_info->linux_uid; | 2438 | pSesInfo->linux_uid = volume_info->linux_uid; |
2439 | pSesInfo->overrideSecFlg = volume_info->secFlg; | 2439 | pSesInfo->overrideSecFlg = volume_info->secFlg; |
2440 | down(&pSesInfo->sesSem); | 2440 | mutex_lock(&pSesInfo->session_mutex); |
2441 | 2441 | ||
2442 | /* BB FIXME need to pass vol->secFlgs BB */ | 2442 | /* BB FIXME need to pass vol->secFlgs BB */ |
2443 | rc = cifs_setup_session(xid, pSesInfo, | 2443 | rc = cifs_setup_session(xid, pSesInfo, |
2444 | cifs_sb->local_nls); | 2444 | cifs_sb->local_nls); |
2445 | up(&pSesInfo->sesSem); | 2445 | mutex_unlock(&pSesInfo->session_mutex); |
2446 | } | 2446 | } |
2447 | 2447 | ||
2448 | /* search for existing tcon to this server share */ | 2448 | /* search for existing tcon to this server share */ |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 057e1dae12ab..3d8f8a96f5a3 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -2289,9 +2289,9 @@ cifs_oplock_break(struct slow_work *work) | |||
2289 | if (inode && S_ISREG(inode->i_mode)) { | 2289 | if (inode && S_ISREG(inode->i_mode)) { |
2290 | #ifdef CONFIG_CIFS_EXPERIMENTAL | 2290 | #ifdef CONFIG_CIFS_EXPERIMENTAL |
2291 | if (cinode->clientCanCacheAll == 0) | 2291 | if (cinode->clientCanCacheAll == 0) |
2292 | break_lease(inode, FMODE_READ); | 2292 | break_lease(inode, O_RDONLY); |
2293 | else if (cinode->clientCanCacheRead == 0) | 2293 | else if (cinode->clientCanCacheRead == 0) |
2294 | break_lease(inode, FMODE_WRITE); | 2294 | break_lease(inode, O_WRONLY); |
2295 | #endif | 2295 | #endif |
2296 | rc = filemap_fdatawrite(inode->i_mapping); | 2296 | rc = filemap_fdatawrite(inode->i_mapping); |
2297 | if (cinode->clientCanCacheRead == 0) { | 2297 | if (cinode->clientCanCacheRead == 0) { |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index e3fda978f481..8bdbc818164c 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -111,6 +111,7 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr) | |||
111 | 111 | ||
112 | cifs_i->delete_pending = fattr->cf_flags & CIFS_FATTR_DELETE_PENDING; | 112 | cifs_i->delete_pending = fattr->cf_flags & CIFS_FATTR_DELETE_PENDING; |
113 | 113 | ||
114 | cifs_i->server_eof = fattr->cf_eof; | ||
114 | /* | 115 | /* |
115 | * Can't safely change the file size here if the client is writing to | 116 | * Can't safely change the file size here if the client is writing to |
116 | * it due to potential races. | 117 | * it due to potential races. |
@@ -366,7 +367,7 @@ static int cifs_sfu_mode(struct cifs_fattr *fattr, const unsigned char *path, | |||
366 | char ea_value[4]; | 367 | char ea_value[4]; |
367 | __u32 mode; | 368 | __u32 mode; |
368 | 369 | ||
369 | rc = CIFSSMBQueryEA(xid, cifs_sb->tcon, path, "SETFILEBITS", | 370 | rc = CIFSSMBQAllEAs(xid, cifs_sb->tcon, path, "SETFILEBITS", |
370 | ea_value, 4 /* size of buf */, cifs_sb->local_nls, | 371 | ea_value, 4 /* size of buf */, cifs_sb->local_nls, |
371 | cifs_sb->mnt_cifs_flags & | 372 | cifs_sb->mnt_cifs_flags & |
372 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 373 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index d27d4ec6579b..d1474996a812 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c | |||
@@ -79,7 +79,7 @@ sesInfoAlloc(void) | |||
79 | ++ret_buf->ses_count; | 79 | ++ret_buf->ses_count; |
80 | INIT_LIST_HEAD(&ret_buf->smb_ses_list); | 80 | INIT_LIST_HEAD(&ret_buf->smb_ses_list); |
81 | INIT_LIST_HEAD(&ret_buf->tcon_list); | 81 | INIT_LIST_HEAD(&ret_buf->tcon_list); |
82 | init_MUTEX(&ret_buf->sesSem); | 82 | mutex_init(&ret_buf->session_mutex); |
83 | } | 83 | } |
84 | return ret_buf; | 84 | return ret_buf; |
85 | } | 85 | } |
diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c index a75afa3dd9e1..3e2ef0de1209 100644 --- a/fs/cifs/xattr.c +++ b/fs/cifs/xattr.c | |||
@@ -244,7 +244,7 @@ ssize_t cifs_getxattr(struct dentry *direntry, const char *ea_name, | |||
244 | /* revalidate/getattr then populate from inode */ | 244 | /* revalidate/getattr then populate from inode */ |
245 | } /* BB add else when above is implemented */ | 245 | } /* BB add else when above is implemented */ |
246 | ea_name += 5; /* skip past user. prefix */ | 246 | ea_name += 5; /* skip past user. prefix */ |
247 | rc = CIFSSMBQueryEA(xid, pTcon, full_path, ea_name, ea_value, | 247 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, ea_name, ea_value, |
248 | buf_size, cifs_sb->local_nls, | 248 | buf_size, cifs_sb->local_nls, |
249 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 249 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
250 | } else if (strncmp(ea_name, CIFS_XATTR_OS2_PREFIX, 4) == 0) { | 250 | } else if (strncmp(ea_name, CIFS_XATTR_OS2_PREFIX, 4) == 0) { |
@@ -252,7 +252,7 @@ ssize_t cifs_getxattr(struct dentry *direntry, const char *ea_name, | |||
252 | goto get_ea_exit; | 252 | goto get_ea_exit; |
253 | 253 | ||
254 | ea_name += 4; /* skip past os2. prefix */ | 254 | ea_name += 4; /* skip past os2. prefix */ |
255 | rc = CIFSSMBQueryEA(xid, pTcon, full_path, ea_name, ea_value, | 255 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, ea_name, ea_value, |
256 | buf_size, cifs_sb->local_nls, | 256 | buf_size, cifs_sb->local_nls, |
257 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 257 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
258 | } else if (strncmp(ea_name, POSIX_ACL_XATTR_ACCESS, | 258 | } else if (strncmp(ea_name, POSIX_ACL_XATTR_ACCESS, |
@@ -364,8 +364,8 @@ ssize_t cifs_listxattr(struct dentry *direntry, char *data, size_t buf_size) | |||
364 | /* if proc/fs/cifs/streamstoxattr is set then | 364 | /* if proc/fs/cifs/streamstoxattr is set then |
365 | search server for EAs or streams to | 365 | search server for EAs or streams to |
366 | returns as xattrs */ | 366 | returns as xattrs */ |
367 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, data, buf_size, | 367 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, NULL, data, |
368 | cifs_sb->local_nls, | 368 | buf_size, cifs_sb->local_nls, |
369 | cifs_sb->mnt_cifs_flags & | 369 | cifs_sb->mnt_cifs_flags & |
370 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 370 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
371 | 371 | ||
diff --git a/fs/dcache.c b/fs/dcache.c index 953173a293a9..f1358e5c3a59 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -257,6 +257,7 @@ kill_it: | |||
257 | if (dentry) | 257 | if (dentry) |
258 | goto repeat; | 258 | goto repeat; |
259 | } | 259 | } |
260 | EXPORT_SYMBOL(dput); | ||
260 | 261 | ||
261 | /** | 262 | /** |
262 | * d_invalidate - invalidate a dentry | 263 | * d_invalidate - invalidate a dentry |
@@ -314,6 +315,7 @@ int d_invalidate(struct dentry * dentry) | |||
314 | spin_unlock(&dcache_lock); | 315 | spin_unlock(&dcache_lock); |
315 | return 0; | 316 | return 0; |
316 | } | 317 | } |
318 | EXPORT_SYMBOL(d_invalidate); | ||
317 | 319 | ||
318 | /* This should be called _only_ with dcache_lock held */ | 320 | /* This should be called _only_ with dcache_lock held */ |
319 | 321 | ||
@@ -328,6 +330,7 @@ struct dentry * dget_locked(struct dentry *dentry) | |||
328 | { | 330 | { |
329 | return __dget_locked(dentry); | 331 | return __dget_locked(dentry); |
330 | } | 332 | } |
333 | EXPORT_SYMBOL(dget_locked); | ||
331 | 334 | ||
332 | /** | 335 | /** |
333 | * d_find_alias - grab a hashed alias of inode | 336 | * d_find_alias - grab a hashed alias of inode |
@@ -384,6 +387,7 @@ struct dentry * d_find_alias(struct inode *inode) | |||
384 | } | 387 | } |
385 | return de; | 388 | return de; |
386 | } | 389 | } |
390 | EXPORT_SYMBOL(d_find_alias); | ||
387 | 391 | ||
388 | /* | 392 | /* |
389 | * Try to kill dentries associated with this inode. | 393 | * Try to kill dentries associated with this inode. |
@@ -408,6 +412,7 @@ restart: | |||
408 | } | 412 | } |
409 | spin_unlock(&dcache_lock); | 413 | spin_unlock(&dcache_lock); |
410 | } | 414 | } |
415 | EXPORT_SYMBOL(d_prune_aliases); | ||
411 | 416 | ||
412 | /* | 417 | /* |
413 | * Throw away a dentry - free the inode, dput the parent. This requires that | 418 | * Throw away a dentry - free the inode, dput the parent. This requires that |
@@ -610,6 +615,7 @@ void shrink_dcache_sb(struct super_block * sb) | |||
610 | { | 615 | { |
611 | __shrink_dcache_sb(sb, NULL, 0); | 616 | __shrink_dcache_sb(sb, NULL, 0); |
612 | } | 617 | } |
618 | EXPORT_SYMBOL(shrink_dcache_sb); | ||
613 | 619 | ||
614 | /* | 620 | /* |
615 | * destroy a single subtree of dentries for unmount | 621 | * destroy a single subtree of dentries for unmount |
@@ -792,6 +798,7 @@ positive: | |||
792 | spin_unlock(&dcache_lock); | 798 | spin_unlock(&dcache_lock); |
793 | return 1; | 799 | return 1; |
794 | } | 800 | } |
801 | EXPORT_SYMBOL(have_submounts); | ||
795 | 802 | ||
796 | /* | 803 | /* |
797 | * Search the dentry child list for the specified parent, | 804 | * Search the dentry child list for the specified parent, |
@@ -876,6 +883,7 @@ void shrink_dcache_parent(struct dentry * parent) | |||
876 | while ((found = select_parent(parent)) != 0) | 883 | while ((found = select_parent(parent)) != 0) |
877 | __shrink_dcache_sb(sb, &found, 0); | 884 | __shrink_dcache_sb(sb, &found, 0); |
878 | } | 885 | } |
886 | EXPORT_SYMBOL(shrink_dcache_parent); | ||
879 | 887 | ||
880 | /* | 888 | /* |
881 | * Scan `nr' dentries and return the number which remain. | 889 | * Scan `nr' dentries and return the number which remain. |
@@ -968,6 +976,7 @@ struct dentry *d_alloc(struct dentry * parent, const struct qstr *name) | |||
968 | 976 | ||
969 | return dentry; | 977 | return dentry; |
970 | } | 978 | } |
979 | EXPORT_SYMBOL(d_alloc); | ||
971 | 980 | ||
972 | struct dentry *d_alloc_name(struct dentry *parent, const char *name) | 981 | struct dentry *d_alloc_name(struct dentry *parent, const char *name) |
973 | { | 982 | { |
@@ -1012,6 +1021,7 @@ void d_instantiate(struct dentry *entry, struct inode * inode) | |||
1012 | spin_unlock(&dcache_lock); | 1021 | spin_unlock(&dcache_lock); |
1013 | security_d_instantiate(entry, inode); | 1022 | security_d_instantiate(entry, inode); |
1014 | } | 1023 | } |
1024 | EXPORT_SYMBOL(d_instantiate); | ||
1015 | 1025 | ||
1016 | /** | 1026 | /** |
1017 | * d_instantiate_unique - instantiate a non-aliased dentry | 1027 | * d_instantiate_unique - instantiate a non-aliased dentry |
@@ -1108,6 +1118,7 @@ struct dentry * d_alloc_root(struct inode * root_inode) | |||
1108 | } | 1118 | } |
1109 | return res; | 1119 | return res; |
1110 | } | 1120 | } |
1121 | EXPORT_SYMBOL(d_alloc_root); | ||
1111 | 1122 | ||
1112 | static inline struct hlist_head *d_hash(struct dentry *parent, | 1123 | static inline struct hlist_head *d_hash(struct dentry *parent, |
1113 | unsigned long hash) | 1124 | unsigned long hash) |
@@ -1211,7 +1222,6 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) | |||
1211 | BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED)); | 1222 | BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED)); |
1212 | spin_unlock(&dcache_lock); | 1223 | spin_unlock(&dcache_lock); |
1213 | security_d_instantiate(new, inode); | 1224 | security_d_instantiate(new, inode); |
1214 | d_rehash(dentry); | ||
1215 | d_move(new, dentry); | 1225 | d_move(new, dentry); |
1216 | iput(inode); | 1226 | iput(inode); |
1217 | } else { | 1227 | } else { |
@@ -1225,6 +1235,7 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) | |||
1225 | d_add(dentry, inode); | 1235 | d_add(dentry, inode); |
1226 | return new; | 1236 | return new; |
1227 | } | 1237 | } |
1238 | EXPORT_SYMBOL(d_splice_alias); | ||
1228 | 1239 | ||
1229 | /** | 1240 | /** |
1230 | * d_add_ci - lookup or allocate new dentry with case-exact name | 1241 | * d_add_ci - lookup or allocate new dentry with case-exact name |
@@ -1314,6 +1325,7 @@ err_out: | |||
1314 | iput(inode); | 1325 | iput(inode); |
1315 | return ERR_PTR(error); | 1326 | return ERR_PTR(error); |
1316 | } | 1327 | } |
1328 | EXPORT_SYMBOL(d_add_ci); | ||
1317 | 1329 | ||
1318 | /** | 1330 | /** |
1319 | * d_lookup - search for a dentry | 1331 | * d_lookup - search for a dentry |
@@ -1357,6 +1369,7 @@ struct dentry * d_lookup(struct dentry * parent, struct qstr * name) | |||
1357 | } while (read_seqretry(&rename_lock, seq)); | 1369 | } while (read_seqretry(&rename_lock, seq)); |
1358 | return dentry; | 1370 | return dentry; |
1359 | } | 1371 | } |
1372 | EXPORT_SYMBOL(d_lookup); | ||
1360 | 1373 | ||
1361 | struct dentry * __d_lookup(struct dentry * parent, struct qstr * name) | 1374 | struct dentry * __d_lookup(struct dentry * parent, struct qstr * name) |
1362 | { | 1375 | { |
@@ -1483,6 +1496,7 @@ int d_validate(struct dentry *dentry, struct dentry *dparent) | |||
1483 | out: | 1496 | out: |
1484 | return 0; | 1497 | return 0; |
1485 | } | 1498 | } |
1499 | EXPORT_SYMBOL(d_validate); | ||
1486 | 1500 | ||
1487 | /* | 1501 | /* |
1488 | * When a file is deleted, we have two options: | 1502 | * When a file is deleted, we have two options: |
@@ -1528,6 +1542,7 @@ void d_delete(struct dentry * dentry) | |||
1528 | 1542 | ||
1529 | fsnotify_nameremove(dentry, isdir); | 1543 | fsnotify_nameremove(dentry, isdir); |
1530 | } | 1544 | } |
1545 | EXPORT_SYMBOL(d_delete); | ||
1531 | 1546 | ||
1532 | static void __d_rehash(struct dentry * entry, struct hlist_head *list) | 1547 | static void __d_rehash(struct dentry * entry, struct hlist_head *list) |
1533 | { | 1548 | { |
@@ -1556,6 +1571,7 @@ void d_rehash(struct dentry * entry) | |||
1556 | spin_unlock(&entry->d_lock); | 1571 | spin_unlock(&entry->d_lock); |
1557 | spin_unlock(&dcache_lock); | 1572 | spin_unlock(&dcache_lock); |
1558 | } | 1573 | } |
1574 | EXPORT_SYMBOL(d_rehash); | ||
1559 | 1575 | ||
1560 | /* | 1576 | /* |
1561 | * When switching names, the actual string doesn't strictly have to | 1577 | * When switching names, the actual string doesn't strictly have to |
@@ -1702,6 +1718,7 @@ void d_move(struct dentry * dentry, struct dentry * target) | |||
1702 | d_move_locked(dentry, target); | 1718 | d_move_locked(dentry, target); |
1703 | spin_unlock(&dcache_lock); | 1719 | spin_unlock(&dcache_lock); |
1704 | } | 1720 | } |
1721 | EXPORT_SYMBOL(d_move); | ||
1705 | 1722 | ||
1706 | /** | 1723 | /** |
1707 | * d_ancestor - search for an ancestor | 1724 | * d_ancestor - search for an ancestor |
@@ -1868,6 +1885,7 @@ shouldnt_be_hashed: | |||
1868 | spin_unlock(&dcache_lock); | 1885 | spin_unlock(&dcache_lock); |
1869 | BUG(); | 1886 | BUG(); |
1870 | } | 1887 | } |
1888 | EXPORT_SYMBOL_GPL(d_materialise_unique); | ||
1871 | 1889 | ||
1872 | static int prepend(char **buffer, int *buflen, const char *str, int namelen) | 1890 | static int prepend(char **buffer, int *buflen, const char *str, int namelen) |
1873 | { | 1891 | { |
@@ -2005,6 +2023,7 @@ char *d_path(const struct path *path, char *buf, int buflen) | |||
2005 | path_put(&root); | 2023 | path_put(&root); |
2006 | return res; | 2024 | return res; |
2007 | } | 2025 | } |
2026 | EXPORT_SYMBOL(d_path); | ||
2008 | 2027 | ||
2009 | /* | 2028 | /* |
2010 | * Helper function for dentry_operations.d_dname() members | 2029 | * Helper function for dentry_operations.d_dname() members |
@@ -2171,6 +2190,30 @@ int is_subdir(struct dentry *new_dentry, struct dentry *old_dentry) | |||
2171 | return result; | 2190 | return result; |
2172 | } | 2191 | } |
2173 | 2192 | ||
2193 | int path_is_under(struct path *path1, struct path *path2) | ||
2194 | { | ||
2195 | struct vfsmount *mnt = path1->mnt; | ||
2196 | struct dentry *dentry = path1->dentry; | ||
2197 | int res; | ||
2198 | spin_lock(&vfsmount_lock); | ||
2199 | if (mnt != path2->mnt) { | ||
2200 | for (;;) { | ||
2201 | if (mnt->mnt_parent == mnt) { | ||
2202 | spin_unlock(&vfsmount_lock); | ||
2203 | return 0; | ||
2204 | } | ||
2205 | if (mnt->mnt_parent == path2->mnt) | ||
2206 | break; | ||
2207 | mnt = mnt->mnt_parent; | ||
2208 | } | ||
2209 | dentry = mnt->mnt_mountpoint; | ||
2210 | } | ||
2211 | res = is_subdir(dentry, path2->dentry); | ||
2212 | spin_unlock(&vfsmount_lock); | ||
2213 | return res; | ||
2214 | } | ||
2215 | EXPORT_SYMBOL(path_is_under); | ||
2216 | |||
2174 | void d_genocide(struct dentry *root) | 2217 | void d_genocide(struct dentry *root) |
2175 | { | 2218 | { |
2176 | struct dentry *this_parent = root; | 2219 | struct dentry *this_parent = root; |
@@ -2228,6 +2271,7 @@ ino_t find_inode_number(struct dentry *dir, struct qstr *name) | |||
2228 | } | 2271 | } |
2229 | return ino; | 2272 | return ino; |
2230 | } | 2273 | } |
2274 | EXPORT_SYMBOL(find_inode_number); | ||
2231 | 2275 | ||
2232 | static __initdata unsigned long dhash_entries; | 2276 | static __initdata unsigned long dhash_entries; |
2233 | static int __init set_dhash_entries(char *str) | 2277 | static int __init set_dhash_entries(char *str) |
@@ -2297,6 +2341,7 @@ static void __init dcache_init(void) | |||
2297 | 2341 | ||
2298 | /* SLAB cache for __getname() consumers */ | 2342 | /* SLAB cache for __getname() consumers */ |
2299 | struct kmem_cache *names_cachep __read_mostly; | 2343 | struct kmem_cache *names_cachep __read_mostly; |
2344 | EXPORT_SYMBOL(names_cachep); | ||
2300 | 2345 | ||
2301 | EXPORT_SYMBOL(d_genocide); | 2346 | EXPORT_SYMBOL(d_genocide); |
2302 | 2347 | ||
@@ -2326,26 +2371,3 @@ void __init vfs_caches_init(unsigned long mempages) | |||
2326 | bdev_cache_init(); | 2371 | bdev_cache_init(); |
2327 | chrdev_init(); | 2372 | chrdev_init(); |
2328 | } | 2373 | } |
2329 | |||
2330 | EXPORT_SYMBOL(d_alloc); | ||
2331 | EXPORT_SYMBOL(d_alloc_root); | ||
2332 | EXPORT_SYMBOL(d_delete); | ||
2333 | EXPORT_SYMBOL(d_find_alias); | ||
2334 | EXPORT_SYMBOL(d_instantiate); | ||
2335 | EXPORT_SYMBOL(d_invalidate); | ||
2336 | EXPORT_SYMBOL(d_lookup); | ||
2337 | EXPORT_SYMBOL(d_move); | ||
2338 | EXPORT_SYMBOL_GPL(d_materialise_unique); | ||
2339 | EXPORT_SYMBOL(d_path); | ||
2340 | EXPORT_SYMBOL(d_prune_aliases); | ||
2341 | EXPORT_SYMBOL(d_rehash); | ||
2342 | EXPORT_SYMBOL(d_splice_alias); | ||
2343 | EXPORT_SYMBOL(d_add_ci); | ||
2344 | EXPORT_SYMBOL(d_validate); | ||
2345 | EXPORT_SYMBOL(dget_locked); | ||
2346 | EXPORT_SYMBOL(dput); | ||
2347 | EXPORT_SYMBOL(find_inode_number); | ||
2348 | EXPORT_SYMBOL(have_submounts); | ||
2349 | EXPORT_SYMBOL(names_cachep); | ||
2350 | EXPORT_SYMBOL(shrink_dcache_parent); | ||
2351 | EXPORT_SYMBOL(shrink_dcache_sb); | ||
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 274ac865bae8..049d6c36da09 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -496,7 +496,7 @@ struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, | |||
496 | } | 496 | } |
497 | d_move(old_dentry, dentry); | 497 | d_move(old_dentry, dentry); |
498 | fsnotify_move(old_dir->d_inode, new_dir->d_inode, old_name, | 498 | fsnotify_move(old_dir->d_inode, new_dir->d_inode, old_name, |
499 | old_dentry->d_name.name, S_ISDIR(old_dentry->d_inode->i_mode), | 499 | S_ISDIR(old_dentry->d_inode->i_mode), |
500 | NULL, old_dentry); | 500 | NULL, old_dentry); |
501 | fsnotify_oldname_free(old_name); | 501 | fsnotify_oldname_free(old_name); |
502 | unlock_rename(new_dir, old_dir); | 502 | unlock_rename(new_dir, old_dir); |
diff --git a/fs/exofs/common.h b/fs/exofs/common.h index b1b178e61718..f0d520312d8b 100644 --- a/fs/exofs/common.h +++ b/fs/exofs/common.h | |||
@@ -55,6 +55,8 @@ | |||
55 | /* exofs Application specific page/attribute */ | 55 | /* exofs Application specific page/attribute */ |
56 | # define EXOFS_APAGE_FS_DATA (OSD_APAGE_APP_DEFINED_FIRST + 3) | 56 | # define EXOFS_APAGE_FS_DATA (OSD_APAGE_APP_DEFINED_FIRST + 3) |
57 | # define EXOFS_ATTR_INODE_DATA 1 | 57 | # define EXOFS_ATTR_INODE_DATA 1 |
58 | # define EXOFS_ATTR_INODE_FILE_LAYOUT 2 | ||
59 | # define EXOFS_ATTR_INODE_DIR_LAYOUT 3 | ||
58 | 60 | ||
59 | /* | 61 | /* |
60 | * The maximum number of files we can have is limited by the size of the | 62 | * The maximum number of files we can have is limited by the size of the |
@@ -206,4 +208,41 @@ enum { | |||
206 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ | 208 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ |
207 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) | 209 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) |
208 | 210 | ||
211 | /* | ||
212 | * The on-disk (optional) layout structure. | ||
213 | * sits in an EXOFS_ATTR_INODE_FILE_LAYOUT or EXOFS_ATTR_INODE_DIR_LAYOUT | ||
214 | * attribute, attached to any inode, usually to a directory. | ||
215 | */ | ||
216 | |||
217 | enum exofs_inode_layout_gen_functions { | ||
218 | LAYOUT_MOVING_WINDOW = 0, | ||
219 | LAYOUT_IMPLICT = 1, | ||
220 | }; | ||
221 | |||
222 | struct exofs_on_disk_inode_layout { | ||
223 | __le16 gen_func; /* One of enum exofs_inode_layout_gen_functions */ | ||
224 | __le16 pad; | ||
225 | union { | ||
226 | /* gen_func == LAYOUT_MOVING_WINDOW (default) */ | ||
227 | struct exofs_layout_sliding_window { | ||
228 | __le32 num_devices; /* first n devices in global-table*/ | ||
229 | } sliding_window __packed; | ||
230 | |||
231 | /* gen_func == LAYOUT_IMPLICT */ | ||
232 | struct exofs_layout_implict_list { | ||
233 | struct exofs_dt_data_map data_map; | ||
234 | /* Variable array of size data_map.cb_num_comps. These | ||
235 | * are device indexes of the devices in the global table | ||
236 | */ | ||
237 | __le32 dev_indexes[]; | ||
238 | } implict __packed; | ||
239 | }; | ||
240 | } __packed; | ||
241 | |||
242 | static inline size_t exofs_on_disk_inode_layout_size(unsigned max_devs) | ||
243 | { | ||
244 | return sizeof(struct exofs_on_disk_inode_layout) + | ||
245 | max_devs * sizeof(__le32); | ||
246 | } | ||
247 | |||
209 | #endif /*ifndef __EXOFS_COM_H__*/ | 248 | #endif /*ifndef __EXOFS_COM_H__*/ |
diff --git a/fs/exofs/exofs.h b/fs/exofs/exofs.h index c35fd4623986..8442e353309f 100644 --- a/fs/exofs/exofs.h +++ b/fs/exofs/exofs.h | |||
@@ -55,12 +55,28 @@ | |||
55 | /* u64 has problems with printk this will cast it to unsigned long long */ | 55 | /* u64 has problems with printk this will cast it to unsigned long long */ |
56 | #define _LLU(x) (unsigned long long)(x) | 56 | #define _LLU(x) (unsigned long long)(x) |
57 | 57 | ||
58 | struct exofs_layout { | ||
59 | osd_id s_pid; /* partition ID of file system*/ | ||
60 | |||
61 | /* Our way of looking at the data_map */ | ||
62 | unsigned stripe_unit; | ||
63 | unsigned mirrors_p1; | ||
64 | |||
65 | unsigned group_width; | ||
66 | u64 group_depth; | ||
67 | unsigned group_count; | ||
68 | |||
69 | enum exofs_inode_layout_gen_functions lay_func; | ||
70 | |||
71 | unsigned s_numdevs; /* Num of devices in array */ | ||
72 | struct osd_dev *s_ods[0]; /* Variable length */ | ||
73 | }; | ||
74 | |||
58 | /* | 75 | /* |
59 | * our extension to the in-memory superblock | 76 | * our extension to the in-memory superblock |
60 | */ | 77 | */ |
61 | struct exofs_sb_info { | 78 | struct exofs_sb_info { |
62 | struct exofs_fscb s_fscb; /* Written often, pre-allocate*/ | 79 | struct exofs_fscb s_fscb; /* Written often, pre-allocate*/ |
63 | osd_id s_pid; /* partition ID of file system*/ | ||
64 | int s_timeout; /* timeout for OSD operations */ | 80 | int s_timeout; /* timeout for OSD operations */ |
65 | uint64_t s_nextid; /* highest object ID used */ | 81 | uint64_t s_nextid; /* highest object ID used */ |
66 | uint32_t s_numfiles; /* number of files on fs */ | 82 | uint32_t s_numfiles; /* number of files on fs */ |
@@ -69,22 +85,27 @@ struct exofs_sb_info { | |||
69 | atomic_t s_curr_pending; /* number of pending commands */ | 85 | atomic_t s_curr_pending; /* number of pending commands */ |
70 | uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */ | 86 | uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */ |
71 | 87 | ||
72 | struct pnfs_osd_data_map data_map; /* Default raid to use */ | 88 | struct pnfs_osd_data_map data_map; /* Default raid to use |
73 | unsigned s_numdevs; /* Num of devices in array */ | 89 | * FIXME: Needed ? |
74 | struct osd_dev *s_ods[1]; /* Variable length, minimum 1 */ | 90 | */ |
91 | /* struct exofs_layout dir_layout;*/ /* Default dir layout */ | ||
92 | struct exofs_layout layout; /* Default files layout, | ||
93 | * contains the variable osd_dev | ||
94 | * array. Keep last */ | ||
95 | struct osd_dev *_min_one_dev[1]; /* Place holder for one dev */ | ||
75 | }; | 96 | }; |
76 | 97 | ||
77 | /* | 98 | /* |
78 | * our extension to the in-memory inode | 99 | * our extension to the in-memory inode |
79 | */ | 100 | */ |
80 | struct exofs_i_info { | 101 | struct exofs_i_info { |
102 | struct inode vfs_inode; /* normal in-memory inode */ | ||
103 | wait_queue_head_t i_wq; /* wait queue for inode */ | ||
81 | unsigned long i_flags; /* various atomic flags */ | 104 | unsigned long i_flags; /* various atomic flags */ |
82 | uint32_t i_data[EXOFS_IDATA];/*short symlink names and device #s*/ | 105 | uint32_t i_data[EXOFS_IDATA];/*short symlink names and device #s*/ |
83 | uint32_t i_dir_start_lookup; /* which page to start lookup */ | 106 | uint32_t i_dir_start_lookup; /* which page to start lookup */ |
84 | wait_queue_head_t i_wq; /* wait queue for inode */ | ||
85 | uint64_t i_commit_size; /* the object's written length */ | 107 | uint64_t i_commit_size; /* the object's written length */ |
86 | uint8_t i_cred[OSD_CAP_LEN];/* all-powerful credential */ | 108 | uint8_t i_cred[OSD_CAP_LEN];/* all-powerful credential */ |
87 | struct inode vfs_inode; /* normal in-memory inode */ | ||
88 | }; | 109 | }; |
89 | 110 | ||
90 | static inline osd_id exofs_oi_objno(struct exofs_i_info *oi) | 111 | static inline osd_id exofs_oi_objno(struct exofs_i_info *oi) |
@@ -101,7 +122,7 @@ struct exofs_io_state { | |||
101 | void *private; | 122 | void *private; |
102 | exofs_io_done_fn done; | 123 | exofs_io_done_fn done; |
103 | 124 | ||
104 | struct exofs_sb_info *sbi; | 125 | struct exofs_layout *layout; |
105 | struct osd_obj_id obj; | 126 | struct osd_obj_id obj; |
106 | u8 *cred; | 127 | u8 *cred; |
107 | 128 | ||
@@ -109,7 +130,11 @@ struct exofs_io_state { | |||
109 | loff_t offset; | 130 | loff_t offset; |
110 | unsigned long length; | 131 | unsigned long length; |
111 | void *kern_buff; | 132 | void *kern_buff; |
112 | struct bio *bio; | 133 | |
134 | struct page **pages; | ||
135 | unsigned nr_pages; | ||
136 | unsigned pgbase; | ||
137 | unsigned pages_consumed; | ||
113 | 138 | ||
114 | /* Attributes */ | 139 | /* Attributes */ |
115 | unsigned in_attr_len; | 140 | unsigned in_attr_len; |
@@ -122,6 +147,9 @@ struct exofs_io_state { | |||
122 | struct exofs_per_dev_state { | 147 | struct exofs_per_dev_state { |
123 | struct osd_request *or; | 148 | struct osd_request *or; |
124 | struct bio *bio; | 149 | struct bio *bio; |
150 | loff_t offset; | ||
151 | unsigned length; | ||
152 | unsigned dev; | ||
125 | } per_dev[]; | 153 | } per_dev[]; |
126 | }; | 154 | }; |
127 | 155 | ||
@@ -175,6 +203,12 @@ static inline struct exofs_i_info *exofs_i(struct inode *inode) | |||
175 | } | 203 | } |
176 | 204 | ||
177 | /* | 205 | /* |
206 | * Given a layout, object_number and stripe_index return the associated global | ||
207 | * dev_index | ||
208 | */ | ||
209 | unsigned exofs_layout_od_id(struct exofs_layout *layout, | ||
210 | osd_id obj_no, unsigned layout_index); | ||
211 | /* | ||
178 | * Maximum count of links to a file | 212 | * Maximum count of links to a file |
179 | */ | 213 | */ |
180 | #define EXOFS_LINK_MAX 32000 | 214 | #define EXOFS_LINK_MAX 32000 |
@@ -189,7 +223,8 @@ void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], | |||
189 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, | 223 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, |
190 | u64 offset, void *p, unsigned length); | 224 | u64 offset, void *p, unsigned length); |
191 | 225 | ||
192 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** ios); | 226 | int exofs_get_io_state(struct exofs_layout *layout, |
227 | struct exofs_io_state **ios); | ||
193 | void exofs_put_io_state(struct exofs_io_state *ios); | 228 | void exofs_put_io_state(struct exofs_io_state *ios); |
194 | 229 | ||
195 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid); | 230 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid); |
@@ -226,7 +261,7 @@ int exofs_write_begin(struct file *file, struct address_space *mapping, | |||
226 | struct page **pagep, void **fsdata); | 261 | struct page **pagep, void **fsdata); |
227 | extern struct inode *exofs_iget(struct super_block *, unsigned long); | 262 | extern struct inode *exofs_iget(struct super_block *, unsigned long); |
228 | struct inode *exofs_new_inode(struct inode *, int); | 263 | struct inode *exofs_new_inode(struct inode *, int); |
229 | extern int exofs_write_inode(struct inode *, int); | 264 | extern int exofs_write_inode(struct inode *, struct writeback_control *wbc); |
230 | extern void exofs_delete_inode(struct inode *); | 265 | extern void exofs_delete_inode(struct inode *); |
231 | 266 | ||
232 | /* dir.c: */ | 267 | /* dir.c: */ |
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 2afbcebeda71..a17e4b733e35 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c | |||
@@ -41,16 +41,18 @@ | |||
41 | 41 | ||
42 | enum { BIO_MAX_PAGES_KMALLOC = | 42 | enum { BIO_MAX_PAGES_KMALLOC = |
43 | (PAGE_SIZE - sizeof(struct bio)) / sizeof(struct bio_vec), | 43 | (PAGE_SIZE - sizeof(struct bio)) / sizeof(struct bio_vec), |
44 | MAX_PAGES_KMALLOC = | ||
45 | PAGE_SIZE / sizeof(struct page *), | ||
44 | }; | 46 | }; |
45 | 47 | ||
46 | struct page_collect { | 48 | struct page_collect { |
47 | struct exofs_sb_info *sbi; | 49 | struct exofs_sb_info *sbi; |
48 | struct request_queue *req_q; | ||
49 | struct inode *inode; | 50 | struct inode *inode; |
50 | unsigned expected_pages; | 51 | unsigned expected_pages; |
51 | struct exofs_io_state *ios; | 52 | struct exofs_io_state *ios; |
52 | 53 | ||
53 | struct bio *bio; | 54 | struct page **pages; |
55 | unsigned alloc_pages; | ||
54 | unsigned nr_pages; | 56 | unsigned nr_pages; |
55 | unsigned long length; | 57 | unsigned long length; |
56 | loff_t pg_first; /* keep 64bit also in 32-arches */ | 58 | loff_t pg_first; /* keep 64bit also in 32-arches */ |
@@ -62,15 +64,12 @@ static void _pcol_init(struct page_collect *pcol, unsigned expected_pages, | |||
62 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; | 64 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; |
63 | 65 | ||
64 | pcol->sbi = sbi; | 66 | pcol->sbi = sbi; |
65 | /* Create master bios on first Q, later on cloning, each clone will be | ||
66 | * allocated on it's destination Q | ||
67 | */ | ||
68 | pcol->req_q = osd_request_queue(sbi->s_ods[0]); | ||
69 | pcol->inode = inode; | 67 | pcol->inode = inode; |
70 | pcol->expected_pages = expected_pages; | 68 | pcol->expected_pages = expected_pages; |
71 | 69 | ||
72 | pcol->ios = NULL; | 70 | pcol->ios = NULL; |
73 | pcol->bio = NULL; | 71 | pcol->pages = NULL; |
72 | pcol->alloc_pages = 0; | ||
74 | pcol->nr_pages = 0; | 73 | pcol->nr_pages = 0; |
75 | pcol->length = 0; | 74 | pcol->length = 0; |
76 | pcol->pg_first = -1; | 75 | pcol->pg_first = -1; |
@@ -80,7 +79,8 @@ static void _pcol_reset(struct page_collect *pcol) | |||
80 | { | 79 | { |
81 | pcol->expected_pages -= min(pcol->nr_pages, pcol->expected_pages); | 80 | pcol->expected_pages -= min(pcol->nr_pages, pcol->expected_pages); |
82 | 81 | ||
83 | pcol->bio = NULL; | 82 | pcol->pages = NULL; |
83 | pcol->alloc_pages = 0; | ||
84 | pcol->nr_pages = 0; | 84 | pcol->nr_pages = 0; |
85 | pcol->length = 0; | 85 | pcol->length = 0; |
86 | pcol->pg_first = -1; | 86 | pcol->pg_first = -1; |
@@ -90,38 +90,43 @@ static void _pcol_reset(struct page_collect *pcol) | |||
90 | * it might not end here. don't be left with nothing | 90 | * it might not end here. don't be left with nothing |
91 | */ | 91 | */ |
92 | if (!pcol->expected_pages) | 92 | if (!pcol->expected_pages) |
93 | pcol->expected_pages = BIO_MAX_PAGES_KMALLOC; | 93 | pcol->expected_pages = MAX_PAGES_KMALLOC; |
94 | } | 94 | } |
95 | 95 | ||
96 | static int pcol_try_alloc(struct page_collect *pcol) | 96 | static int pcol_try_alloc(struct page_collect *pcol) |
97 | { | 97 | { |
98 | int pages = min_t(unsigned, pcol->expected_pages, | 98 | unsigned pages = min_t(unsigned, pcol->expected_pages, |
99 | BIO_MAX_PAGES_KMALLOC); | 99 | MAX_PAGES_KMALLOC); |
100 | 100 | ||
101 | if (!pcol->ios) { /* First time allocate io_state */ | 101 | if (!pcol->ios) { /* First time allocate io_state */ |
102 | int ret = exofs_get_io_state(pcol->sbi, &pcol->ios); | 102 | int ret = exofs_get_io_state(&pcol->sbi->layout, &pcol->ios); |
103 | 103 | ||
104 | if (ret) | 104 | if (ret) |
105 | return ret; | 105 | return ret; |
106 | } | 106 | } |
107 | 107 | ||
108 | /* TODO: easily support bio chaining */ | ||
109 | pages = min_t(unsigned, pages, | ||
110 | pcol->sbi->layout.group_width * BIO_MAX_PAGES_KMALLOC); | ||
111 | |||
108 | for (; pages; pages >>= 1) { | 112 | for (; pages; pages >>= 1) { |
109 | pcol->bio = bio_kmalloc(GFP_KERNEL, pages); | 113 | pcol->pages = kmalloc(pages * sizeof(struct page *), |
110 | if (likely(pcol->bio)) | 114 | GFP_KERNEL); |
115 | if (likely(pcol->pages)) { | ||
116 | pcol->alloc_pages = pages; | ||
111 | return 0; | 117 | return 0; |
118 | } | ||
112 | } | 119 | } |
113 | 120 | ||
114 | EXOFS_ERR("Failed to bio_kmalloc expected_pages=%u\n", | 121 | EXOFS_ERR("Failed to kmalloc expected_pages=%u\n", |
115 | pcol->expected_pages); | 122 | pcol->expected_pages); |
116 | return -ENOMEM; | 123 | return -ENOMEM; |
117 | } | 124 | } |
118 | 125 | ||
119 | static void pcol_free(struct page_collect *pcol) | 126 | static void pcol_free(struct page_collect *pcol) |
120 | { | 127 | { |
121 | if (pcol->bio) { | 128 | kfree(pcol->pages); |
122 | bio_put(pcol->bio); | 129 | pcol->pages = NULL; |
123 | pcol->bio = NULL; | ||
124 | } | ||
125 | 130 | ||
126 | if (pcol->ios) { | 131 | if (pcol->ios) { |
127 | exofs_put_io_state(pcol->ios); | 132 | exofs_put_io_state(pcol->ios); |
@@ -132,11 +137,10 @@ static void pcol_free(struct page_collect *pcol) | |||
132 | static int pcol_add_page(struct page_collect *pcol, struct page *page, | 137 | static int pcol_add_page(struct page_collect *pcol, struct page *page, |
133 | unsigned len) | 138 | unsigned len) |
134 | { | 139 | { |
135 | int added_len = bio_add_pc_page(pcol->req_q, pcol->bio, page, len, 0); | 140 | if (unlikely(pcol->nr_pages >= pcol->alloc_pages)) |
136 | if (unlikely(len != added_len)) | ||
137 | return -ENOMEM; | 141 | return -ENOMEM; |
138 | 142 | ||
139 | ++pcol->nr_pages; | 143 | pcol->pages[pcol->nr_pages++] = page; |
140 | pcol->length += len; | 144 | pcol->length += len; |
141 | return 0; | 145 | return 0; |
142 | } | 146 | } |
@@ -181,7 +185,6 @@ static void update_write_page(struct page *page, int ret) | |||
181 | */ | 185 | */ |
182 | static int __readpages_done(struct page_collect *pcol, bool do_unlock) | 186 | static int __readpages_done(struct page_collect *pcol, bool do_unlock) |
183 | { | 187 | { |
184 | struct bio_vec *bvec; | ||
185 | int i; | 188 | int i; |
186 | u64 resid; | 189 | u64 resid; |
187 | u64 good_bytes; | 190 | u64 good_bytes; |
@@ -193,13 +196,13 @@ static int __readpages_done(struct page_collect *pcol, bool do_unlock) | |||
193 | else | 196 | else |
194 | good_bytes = pcol->length - resid; | 197 | good_bytes = pcol->length - resid; |
195 | 198 | ||
196 | EXOFS_DBGMSG("readpages_done(0x%lx) good_bytes=0x%llx" | 199 | EXOFS_DBGMSG2("readpages_done(0x%lx) good_bytes=0x%llx" |
197 | " length=0x%lx nr_pages=%u\n", | 200 | " length=0x%lx nr_pages=%u\n", |
198 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, | 201 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, |
199 | pcol->nr_pages); | 202 | pcol->nr_pages); |
200 | 203 | ||
201 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 204 | for (i = 0; i < pcol->nr_pages; i++) { |
202 | struct page *page = bvec->bv_page; | 205 | struct page *page = pcol->pages[i]; |
203 | struct inode *inode = page->mapping->host; | 206 | struct inode *inode = page->mapping->host; |
204 | int page_stat; | 207 | int page_stat; |
205 | 208 | ||
@@ -218,11 +221,11 @@ static int __readpages_done(struct page_collect *pcol, bool do_unlock) | |||
218 | ret = update_read_page(page, page_stat); | 221 | ret = update_read_page(page, page_stat); |
219 | if (do_unlock) | 222 | if (do_unlock) |
220 | unlock_page(page); | 223 | unlock_page(page); |
221 | length += bvec->bv_len; | 224 | length += PAGE_SIZE; |
222 | } | 225 | } |
223 | 226 | ||
224 | pcol_free(pcol); | 227 | pcol_free(pcol); |
225 | EXOFS_DBGMSG("readpages_done END\n"); | 228 | EXOFS_DBGMSG2("readpages_done END\n"); |
226 | return ret; | 229 | return ret; |
227 | } | 230 | } |
228 | 231 | ||
@@ -238,11 +241,10 @@ static void readpages_done(struct exofs_io_state *ios, void *p) | |||
238 | 241 | ||
239 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) | 242 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) |
240 | { | 243 | { |
241 | struct bio_vec *bvec; | ||
242 | int i; | 244 | int i; |
243 | 245 | ||
244 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 246 | for (i = 0; i < pcol->nr_pages; i++) { |
245 | struct page *page = bvec->bv_page; | 247 | struct page *page = pcol->pages[i]; |
246 | 248 | ||
247 | if (rw == READ) | 249 | if (rw == READ) |
248 | update_read_page(page, ret); | 250 | update_read_page(page, ret); |
@@ -260,13 +262,14 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
260 | struct page_collect *pcol_copy = NULL; | 262 | struct page_collect *pcol_copy = NULL; |
261 | int ret; | 263 | int ret; |
262 | 264 | ||
263 | if (!pcol->bio) | 265 | if (!pcol->pages) |
264 | return 0; | 266 | return 0; |
265 | 267 | ||
266 | /* see comment in _readpage() about sync reads */ | 268 | /* see comment in _readpage() about sync reads */ |
267 | WARN_ON(is_sync && (pcol->nr_pages != 1)); | 269 | WARN_ON(is_sync && (pcol->nr_pages != 1)); |
268 | 270 | ||
269 | ios->bio = pcol->bio; | 271 | ios->pages = pcol->pages; |
272 | ios->nr_pages = pcol->nr_pages; | ||
270 | ios->length = pcol->length; | 273 | ios->length = pcol->length; |
271 | ios->offset = pcol->pg_first << PAGE_CACHE_SHIFT; | 274 | ios->offset = pcol->pg_first << PAGE_CACHE_SHIFT; |
272 | 275 | ||
@@ -290,7 +293,7 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
290 | 293 | ||
291 | atomic_inc(&pcol->sbi->s_curr_pending); | 294 | atomic_inc(&pcol->sbi->s_curr_pending); |
292 | 295 | ||
293 | EXOFS_DBGMSG("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", | 296 | EXOFS_DBGMSG2("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", |
294 | ios->obj.id, _LLU(ios->offset), pcol->length); | 297 | ios->obj.id, _LLU(ios->offset), pcol->length); |
295 | 298 | ||
296 | /* pages ownership was passed to pcol_copy */ | 299 | /* pages ownership was passed to pcol_copy */ |
@@ -366,7 +369,7 @@ try_again: | |||
366 | goto try_again; | 369 | goto try_again; |
367 | } | 370 | } |
368 | 371 | ||
369 | if (!pcol->bio) { | 372 | if (!pcol->pages) { |
370 | ret = pcol_try_alloc(pcol); | 373 | ret = pcol_try_alloc(pcol); |
371 | if (unlikely(ret)) | 374 | if (unlikely(ret)) |
372 | goto fail; | 375 | goto fail; |
@@ -448,7 +451,6 @@ static int exofs_readpage(struct file *file, struct page *page) | |||
448 | static void writepages_done(struct exofs_io_state *ios, void *p) | 451 | static void writepages_done(struct exofs_io_state *ios, void *p) |
449 | { | 452 | { |
450 | struct page_collect *pcol = p; | 453 | struct page_collect *pcol = p; |
451 | struct bio_vec *bvec; | ||
452 | int i; | 454 | int i; |
453 | u64 resid; | 455 | u64 resid; |
454 | u64 good_bytes; | 456 | u64 good_bytes; |
@@ -462,13 +464,13 @@ static void writepages_done(struct exofs_io_state *ios, void *p) | |||
462 | else | 464 | else |
463 | good_bytes = pcol->length - resid; | 465 | good_bytes = pcol->length - resid; |
464 | 466 | ||
465 | EXOFS_DBGMSG("writepages_done(0x%lx) good_bytes=0x%llx" | 467 | EXOFS_DBGMSG2("writepages_done(0x%lx) good_bytes=0x%llx" |
466 | " length=0x%lx nr_pages=%u\n", | 468 | " length=0x%lx nr_pages=%u\n", |
467 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, | 469 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, |
468 | pcol->nr_pages); | 470 | pcol->nr_pages); |
469 | 471 | ||
470 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 472 | for (i = 0; i < pcol->nr_pages; i++) { |
471 | struct page *page = bvec->bv_page; | 473 | struct page *page = pcol->pages[i]; |
472 | struct inode *inode = page->mapping->host; | 474 | struct inode *inode = page->mapping->host; |
473 | int page_stat; | 475 | int page_stat; |
474 | 476 | ||
@@ -485,12 +487,12 @@ static void writepages_done(struct exofs_io_state *ios, void *p) | |||
485 | EXOFS_DBGMSG2(" writepages_done(0x%lx, 0x%lx) status=%d\n", | 487 | EXOFS_DBGMSG2(" writepages_done(0x%lx, 0x%lx) status=%d\n", |
486 | inode->i_ino, page->index, page_stat); | 488 | inode->i_ino, page->index, page_stat); |
487 | 489 | ||
488 | length += bvec->bv_len; | 490 | length += PAGE_SIZE; |
489 | } | 491 | } |
490 | 492 | ||
491 | pcol_free(pcol); | 493 | pcol_free(pcol); |
492 | kfree(pcol); | 494 | kfree(pcol); |
493 | EXOFS_DBGMSG("writepages_done END\n"); | 495 | EXOFS_DBGMSG2("writepages_done END\n"); |
494 | } | 496 | } |
495 | 497 | ||
496 | static int write_exec(struct page_collect *pcol) | 498 | static int write_exec(struct page_collect *pcol) |
@@ -500,7 +502,7 @@ static int write_exec(struct page_collect *pcol) | |||
500 | struct page_collect *pcol_copy = NULL; | 502 | struct page_collect *pcol_copy = NULL; |
501 | int ret; | 503 | int ret; |
502 | 504 | ||
503 | if (!pcol->bio) | 505 | if (!pcol->pages) |
504 | return 0; | 506 | return 0; |
505 | 507 | ||
506 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); | 508 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); |
@@ -512,9 +514,8 @@ static int write_exec(struct page_collect *pcol) | |||
512 | 514 | ||
513 | *pcol_copy = *pcol; | 515 | *pcol_copy = *pcol; |
514 | 516 | ||
515 | pcol_copy->bio->bi_rw |= (1 << BIO_RW); /* FIXME: bio_set_dir() */ | 517 | ios->pages = pcol_copy->pages; |
516 | 518 | ios->nr_pages = pcol_copy->nr_pages; | |
517 | ios->bio = pcol_copy->bio; | ||
518 | ios->offset = pcol_copy->pg_first << PAGE_CACHE_SHIFT; | 519 | ios->offset = pcol_copy->pg_first << PAGE_CACHE_SHIFT; |
519 | ios->length = pcol_copy->length; | 520 | ios->length = pcol_copy->length; |
520 | ios->done = writepages_done; | 521 | ios->done = writepages_done; |
@@ -527,7 +528,7 @@ static int write_exec(struct page_collect *pcol) | |||
527 | } | 528 | } |
528 | 529 | ||
529 | atomic_inc(&pcol->sbi->s_curr_pending); | 530 | atomic_inc(&pcol->sbi->s_curr_pending); |
530 | EXOFS_DBGMSG("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", | 531 | EXOFS_DBGMSG2("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", |
531 | pcol->inode->i_ino, pcol->pg_first, _LLU(ios->offset), | 532 | pcol->inode->i_ino, pcol->pg_first, _LLU(ios->offset), |
532 | pcol->length); | 533 | pcol->length); |
533 | /* pages ownership was passed to pcol_copy */ | 534 | /* pages ownership was passed to pcol_copy */ |
@@ -605,7 +606,7 @@ try_again: | |||
605 | goto try_again; | 606 | goto try_again; |
606 | } | 607 | } |
607 | 608 | ||
608 | if (!pcol->bio) { | 609 | if (!pcol->pages) { |
609 | ret = pcol_try_alloc(pcol); | 610 | ret = pcol_try_alloc(pcol); |
610 | if (unlikely(ret)) | 611 | if (unlikely(ret)) |
611 | goto fail; | 612 | goto fail; |
@@ -616,7 +617,7 @@ try_again: | |||
616 | 617 | ||
617 | ret = pcol_add_page(pcol, page, len); | 618 | ret = pcol_add_page(pcol, page, len); |
618 | if (unlikely(ret)) { | 619 | if (unlikely(ret)) { |
619 | EXOFS_DBGMSG("Failed pcol_add_page " | 620 | EXOFS_DBGMSG2("Failed pcol_add_page " |
620 | "nr_pages=%u total_length=0x%lx\n", | 621 | "nr_pages=%u total_length=0x%lx\n", |
621 | pcol->nr_pages, pcol->length); | 622 | pcol->nr_pages, pcol->length); |
622 | 623 | ||
@@ -663,7 +664,7 @@ static int exofs_writepages(struct address_space *mapping, | |||
663 | if (expected_pages < 32L) | 664 | if (expected_pages < 32L) |
664 | expected_pages = 32L; | 665 | expected_pages = 32L; |
665 | 666 | ||
666 | EXOFS_DBGMSG("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx " | 667 | EXOFS_DBGMSG2("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx " |
667 | "nrpages=%lu start=0x%lx end=0x%lx expected_pages=%ld\n", | 668 | "nrpages=%lu start=0x%lx end=0x%lx expected_pages=%ld\n", |
668 | mapping->host->i_ino, wbc->range_start, wbc->range_end, | 669 | mapping->host->i_ino, wbc->range_start, wbc->range_end, |
669 | mapping->nrpages, start, end, expected_pages); | 670 | mapping->nrpages, start, end, expected_pages); |
@@ -859,20 +860,33 @@ int exofs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
859 | return error; | 860 | return error; |
860 | } | 861 | } |
861 | 862 | ||
863 | static const struct osd_attr g_attr_inode_file_layout = ATTR_DEF( | ||
864 | EXOFS_APAGE_FS_DATA, | ||
865 | EXOFS_ATTR_INODE_FILE_LAYOUT, | ||
866 | 0); | ||
867 | static const struct osd_attr g_attr_inode_dir_layout = ATTR_DEF( | ||
868 | EXOFS_APAGE_FS_DATA, | ||
869 | EXOFS_ATTR_INODE_DIR_LAYOUT, | ||
870 | 0); | ||
871 | |||
862 | /* | 872 | /* |
863 | * Read an inode from the OSD, and return it as is. We also return the size | 873 | * Read the Linux inode info from the OSD, and return it as is. In exofs the |
864 | * attribute in the 'obj_size' argument. | 874 | * inode info is in an application specific page/attribute of the osd-object. |
865 | */ | 875 | */ |
866 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | 876 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, |
867 | struct exofs_fcb *inode, uint64_t *obj_size) | 877 | struct exofs_fcb *inode) |
868 | { | 878 | { |
869 | struct exofs_sb_info *sbi = sb->s_fs_info; | 879 | struct exofs_sb_info *sbi = sb->s_fs_info; |
870 | struct osd_attr attrs[2]; | 880 | struct osd_attr attrs[] = { |
881 | [0] = g_attr_inode_data, | ||
882 | [1] = g_attr_inode_file_layout, | ||
883 | [2] = g_attr_inode_dir_layout, | ||
884 | }; | ||
871 | struct exofs_io_state *ios; | 885 | struct exofs_io_state *ios; |
886 | struct exofs_on_disk_inode_layout *layout; | ||
872 | int ret; | 887 | int ret; |
873 | 888 | ||
874 | *obj_size = ~0; | 889 | ret = exofs_get_io_state(&sbi->layout, &ios); |
875 | ret = exofs_get_io_state(sbi, &ios); | ||
876 | if (unlikely(ret)) { | 890 | if (unlikely(ret)) { |
877 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); | 891 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
878 | return ret; | 892 | return ret; |
@@ -882,14 +896,25 @@ static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | |||
882 | exofs_make_credential(oi->i_cred, &ios->obj); | 896 | exofs_make_credential(oi->i_cred, &ios->obj); |
883 | ios->cred = oi->i_cred; | 897 | ios->cred = oi->i_cred; |
884 | 898 | ||
885 | attrs[0] = g_attr_inode_data; | 899 | attrs[1].len = exofs_on_disk_inode_layout_size(sbi->layout.s_numdevs); |
886 | attrs[1] = g_attr_logical_length; | 900 | attrs[2].len = exofs_on_disk_inode_layout_size(sbi->layout.s_numdevs); |
901 | |||
887 | ios->in_attr = attrs; | 902 | ios->in_attr = attrs; |
888 | ios->in_attr_len = ARRAY_SIZE(attrs); | 903 | ios->in_attr_len = ARRAY_SIZE(attrs); |
889 | 904 | ||
890 | ret = exofs_sbi_read(ios); | 905 | ret = exofs_sbi_read(ios); |
891 | if (ret) | 906 | if (unlikely(ret)) { |
907 | EXOFS_ERR("object(0x%llx) corrupted, return empty file=>%d\n", | ||
908 | _LLU(ios->obj.id), ret); | ||
909 | memset(inode, 0, sizeof(*inode)); | ||
910 | inode->i_mode = 0040000 | (0777 & ~022); | ||
911 | /* If object is lost on target we might as well enable it's | ||
912 | * delete. | ||
913 | */ | ||
914 | if ((ret == -ENOENT) || (ret == -EINVAL)) | ||
915 | ret = 0; | ||
892 | goto out; | 916 | goto out; |
917 | } | ||
893 | 918 | ||
894 | ret = extract_attr_from_ios(ios, &attrs[0]); | 919 | ret = extract_attr_from_ios(ios, &attrs[0]); |
895 | if (ret) { | 920 | if (ret) { |
@@ -901,11 +926,33 @@ static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | |||
901 | 926 | ||
902 | ret = extract_attr_from_ios(ios, &attrs[1]); | 927 | ret = extract_attr_from_ios(ios, &attrs[1]); |
903 | if (ret) { | 928 | if (ret) { |
904 | EXOFS_ERR("%s: extract_attr of logical_length failed\n", | 929 | EXOFS_ERR("%s: extract_attr of inode_data failed\n", __func__); |
905 | __func__); | 930 | goto out; |
931 | } | ||
932 | if (attrs[1].len) { | ||
933 | layout = attrs[1].val_ptr; | ||
934 | if (layout->gen_func != cpu_to_le16(LAYOUT_MOVING_WINDOW)) { | ||
935 | EXOFS_ERR("%s: unsupported files layout %d\n", | ||
936 | __func__, layout->gen_func); | ||
937 | ret = -ENOTSUPP; | ||
938 | goto out; | ||
939 | } | ||
940 | } | ||
941 | |||
942 | ret = extract_attr_from_ios(ios, &attrs[2]); | ||
943 | if (ret) { | ||
944 | EXOFS_ERR("%s: extract_attr of inode_data failed\n", __func__); | ||
906 | goto out; | 945 | goto out; |
907 | } | 946 | } |
908 | *obj_size = get_unaligned_be64(attrs[1].val_ptr); | 947 | if (attrs[2].len) { |
948 | layout = attrs[2].val_ptr; | ||
949 | if (layout->gen_func != cpu_to_le16(LAYOUT_MOVING_WINDOW)) { | ||
950 | EXOFS_ERR("%s: unsupported meta-data layout %d\n", | ||
951 | __func__, layout->gen_func); | ||
952 | ret = -ENOTSUPP; | ||
953 | goto out; | ||
954 | } | ||
955 | } | ||
909 | 956 | ||
910 | out: | 957 | out: |
911 | exofs_put_io_state(ios); | 958 | exofs_put_io_state(ios); |
@@ -925,7 +972,6 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
925 | struct exofs_i_info *oi; | 972 | struct exofs_i_info *oi; |
926 | struct exofs_fcb fcb; | 973 | struct exofs_fcb fcb; |
927 | struct inode *inode; | 974 | struct inode *inode; |
928 | uint64_t obj_size; | ||
929 | int ret; | 975 | int ret; |
930 | 976 | ||
931 | inode = iget_locked(sb, ino); | 977 | inode = iget_locked(sb, ino); |
@@ -937,7 +983,7 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
937 | __oi_init(oi); | 983 | __oi_init(oi); |
938 | 984 | ||
939 | /* read the inode from the osd */ | 985 | /* read the inode from the osd */ |
940 | ret = exofs_get_inode(sb, oi, &fcb, &obj_size); | 986 | ret = exofs_get_inode(sb, oi, &fcb); |
941 | if (ret) | 987 | if (ret) |
942 | goto bad_inode; | 988 | goto bad_inode; |
943 | 989 | ||
@@ -958,13 +1004,6 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
958 | inode->i_blkbits = EXOFS_BLKSHIFT; | 1004 | inode->i_blkbits = EXOFS_BLKSHIFT; |
959 | inode->i_generation = le32_to_cpu(fcb.i_generation); | 1005 | inode->i_generation = le32_to_cpu(fcb.i_generation); |
960 | 1006 | ||
961 | if ((inode->i_size != obj_size) && | ||
962 | (!exofs_inode_is_fast_symlink(inode))) { | ||
963 | EXOFS_ERR("WARNING: Size of inode=%llu != object=%llu\n", | ||
964 | inode->i_size, _LLU(obj_size)); | ||
965 | /* FIXME: call exofs_inode_recovery() */ | ||
966 | } | ||
967 | |||
968 | oi->i_dir_start_lookup = 0; | 1007 | oi->i_dir_start_lookup = 0; |
969 | 1008 | ||
970 | if ((inode->i_nlink == 0) && (inode->i_mode == 0)) { | 1009 | if ((inode->i_nlink == 0) && (inode->i_mode == 0)) { |
@@ -1043,7 +1082,7 @@ static void create_done(struct exofs_io_state *ios, void *p) | |||
1043 | 1082 | ||
1044 | if (unlikely(ret)) { | 1083 | if (unlikely(ret)) { |
1045 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", | 1084 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", |
1046 | _LLU(exofs_oi_objno(oi)), _LLU(sbi->s_pid)); | 1085 | _LLU(exofs_oi_objno(oi)), _LLU(sbi->layout.s_pid)); |
1047 | /*TODO: When FS is corrupted creation can fail, object already | 1086 | /*TODO: When FS is corrupted creation can fail, object already |
1048 | * exist. Get rid of this asynchronous creation, if exist | 1087 | * exist. Get rid of this asynchronous creation, if exist |
1049 | * increment the obj counter and try the next object. Until we | 1088 | * increment the obj counter and try the next object. Until we |
@@ -1104,7 +1143,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) | |||
1104 | 1143 | ||
1105 | mark_inode_dirty(inode); | 1144 | mark_inode_dirty(inode); |
1106 | 1145 | ||
1107 | ret = exofs_get_io_state(sbi, &ios); | 1146 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1108 | if (unlikely(ret)) { | 1147 | if (unlikely(ret)) { |
1109 | EXOFS_ERR("exofs_new_inode: exofs_get_io_state failed\n"); | 1148 | EXOFS_ERR("exofs_new_inode: exofs_get_io_state failed\n"); |
1110 | return ERR_PTR(ret); | 1149 | return ERR_PTR(ret); |
@@ -1170,8 +1209,10 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1170 | int ret; | 1209 | int ret; |
1171 | 1210 | ||
1172 | args = kzalloc(sizeof(*args), GFP_KERNEL); | 1211 | args = kzalloc(sizeof(*args), GFP_KERNEL); |
1173 | if (!args) | 1212 | if (!args) { |
1213 | EXOFS_DBGMSG("Faild kzalloc of args\n"); | ||
1174 | return -ENOMEM; | 1214 | return -ENOMEM; |
1215 | } | ||
1175 | 1216 | ||
1176 | fcb = &args->fcb; | 1217 | fcb = &args->fcb; |
1177 | 1218 | ||
@@ -1200,7 +1241,7 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1200 | } else | 1241 | } else |
1201 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); | 1242 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); |
1202 | 1243 | ||
1203 | ret = exofs_get_io_state(sbi, &ios); | 1244 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1204 | if (unlikely(ret)) { | 1245 | if (unlikely(ret)) { |
1205 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); | 1246 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
1206 | goto free_args; | 1247 | goto free_args; |
@@ -1234,13 +1275,14 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1234 | free_args: | 1275 | free_args: |
1235 | kfree(args); | 1276 | kfree(args); |
1236 | out: | 1277 | out: |
1237 | EXOFS_DBGMSG("ret=>%d\n", ret); | 1278 | EXOFS_DBGMSG("(0x%lx) do_sync=%d ret=>%d\n", |
1279 | inode->i_ino, do_sync, ret); | ||
1238 | return ret; | 1280 | return ret; |
1239 | } | 1281 | } |
1240 | 1282 | ||
1241 | int exofs_write_inode(struct inode *inode, int wait) | 1283 | int exofs_write_inode(struct inode *inode, struct writeback_control *wbc) |
1242 | { | 1284 | { |
1243 | return exofs_update_inode(inode, wait); | 1285 | return exofs_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
1244 | } | 1286 | } |
1245 | 1287 | ||
1246 | /* | 1288 | /* |
@@ -1283,7 +1325,7 @@ void exofs_delete_inode(struct inode *inode) | |||
1283 | 1325 | ||
1284 | clear_inode(inode); | 1326 | clear_inode(inode); |
1285 | 1327 | ||
1286 | ret = exofs_get_io_state(sbi, &ios); | 1328 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1287 | if (unlikely(ret)) { | 1329 | if (unlikely(ret)) { |
1288 | EXOFS_ERR("%s: exofs_get_io_state failed\n", __func__); | 1330 | EXOFS_ERR("%s: exofs_get_io_state failed\n", __func__); |
1289 | return; | 1331 | return; |
diff --git a/fs/exofs/ios.c b/fs/exofs/ios.c index 5bad01fa1f9f..5293bc411d17 100644 --- a/fs/exofs/ios.c +++ b/fs/exofs/ios.c | |||
@@ -23,9 +23,13 @@ | |||
23 | */ | 23 | */ |
24 | 24 | ||
25 | #include <scsi/scsi_device.h> | 25 | #include <scsi/scsi_device.h> |
26 | #include <asm/div64.h> | ||
26 | 27 | ||
27 | #include "exofs.h" | 28 | #include "exofs.h" |
28 | 29 | ||
30 | #define EXOFS_DBGMSG2(M...) do {} while (0) | ||
31 | /* #define EXOFS_DBGMSG2 EXOFS_DBGMSG */ | ||
32 | |||
29 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) | 33 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) |
30 | { | 34 | { |
31 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); | 35 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); |
@@ -64,21 +68,24 @@ out: | |||
64 | return ret; | 68 | return ret; |
65 | } | 69 | } |
66 | 70 | ||
67 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** pios) | 71 | int exofs_get_io_state(struct exofs_layout *layout, |
72 | struct exofs_io_state **pios) | ||
68 | { | 73 | { |
69 | struct exofs_io_state *ios; | 74 | struct exofs_io_state *ios; |
70 | 75 | ||
71 | /*TODO: Maybe use kmem_cach per sbi of size | 76 | /*TODO: Maybe use kmem_cach per sbi of size |
72 | * exofs_io_state_size(sbi->s_numdevs) | 77 | * exofs_io_state_size(layout->s_numdevs) |
73 | */ | 78 | */ |
74 | ios = kzalloc(exofs_io_state_size(sbi->s_numdevs), GFP_KERNEL); | 79 | ios = kzalloc(exofs_io_state_size(layout->s_numdevs), GFP_KERNEL); |
75 | if (unlikely(!ios)) { | 80 | if (unlikely(!ios)) { |
81 | EXOFS_DBGMSG("Faild kzalloc bytes=%d\n", | ||
82 | exofs_io_state_size(layout->s_numdevs)); | ||
76 | *pios = NULL; | 83 | *pios = NULL; |
77 | return -ENOMEM; | 84 | return -ENOMEM; |
78 | } | 85 | } |
79 | 86 | ||
80 | ios->sbi = sbi; | 87 | ios->layout = layout; |
81 | ios->obj.partition = sbi->s_pid; | 88 | ios->obj.partition = layout->s_pid; |
82 | *pios = ios; | 89 | *pios = ios; |
83 | return 0; | 90 | return 0; |
84 | } | 91 | } |
@@ -101,6 +108,29 @@ void exofs_put_io_state(struct exofs_io_state *ios) | |||
101 | } | 108 | } |
102 | } | 109 | } |
103 | 110 | ||
111 | unsigned exofs_layout_od_id(struct exofs_layout *layout, | ||
112 | osd_id obj_no, unsigned layout_index) | ||
113 | { | ||
114 | /* switch (layout->lay_func) { | ||
115 | case LAYOUT_MOVING_WINDOW: | ||
116 | {*/ | ||
117 | unsigned dev_mod = obj_no; | ||
118 | |||
119 | return (layout_index + dev_mod * layout->mirrors_p1) % | ||
120 | layout->s_numdevs; | ||
121 | /* } | ||
122 | case LAYOUT_FUNC_IMPLICT: | ||
123 | return layout->devs[layout_index]; | ||
124 | }*/ | ||
125 | } | ||
126 | |||
127 | static inline struct osd_dev *exofs_ios_od(struct exofs_io_state *ios, | ||
128 | unsigned layout_index) | ||
129 | { | ||
130 | return ios->layout->s_ods[ | ||
131 | exofs_layout_od_id(ios->layout, ios->obj.id, layout_index)]; | ||
132 | } | ||
133 | |||
104 | static void _sync_done(struct exofs_io_state *ios, void *p) | 134 | static void _sync_done(struct exofs_io_state *ios, void *p) |
105 | { | 135 | { |
106 | struct completion *waiting = p; | 136 | struct completion *waiting = p; |
@@ -168,6 +198,21 @@ static int exofs_io_execute(struct exofs_io_state *ios) | |||
168 | return ret; | 198 | return ret; |
169 | } | 199 | } |
170 | 200 | ||
201 | static void _clear_bio(struct bio *bio) | ||
202 | { | ||
203 | struct bio_vec *bv; | ||
204 | unsigned i; | ||
205 | |||
206 | __bio_for_each_segment(bv, bio, i, 0) { | ||
207 | unsigned this_count = bv->bv_len; | ||
208 | |||
209 | if (likely(PAGE_SIZE == this_count)) | ||
210 | clear_highpage(bv->bv_page); | ||
211 | else | ||
212 | zero_user(bv->bv_page, bv->bv_offset, this_count); | ||
213 | } | ||
214 | } | ||
215 | |||
171 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | 216 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid) |
172 | { | 217 | { |
173 | enum osd_err_priority acumulated_osd_err = 0; | 218 | enum osd_err_priority acumulated_osd_err = 0; |
@@ -176,16 +221,25 @@ int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | |||
176 | 221 | ||
177 | for (i = 0; i < ios->numdevs; i++) { | 222 | for (i = 0; i < ios->numdevs; i++) { |
178 | struct osd_sense_info osi; | 223 | struct osd_sense_info osi; |
179 | int ret = osd_req_decode_sense(ios->per_dev[i].or, &osi); | 224 | struct osd_request *or = ios->per_dev[i].or; |
225 | int ret; | ||
226 | |||
227 | if (unlikely(!or)) | ||
228 | continue; | ||
180 | 229 | ||
230 | ret = osd_req_decode_sense(or, &osi); | ||
181 | if (likely(!ret)) | 231 | if (likely(!ret)) |
182 | continue; | 232 | continue; |
183 | 233 | ||
184 | if (unlikely(ret == -EFAULT)) { | 234 | if (OSD_ERR_PRI_CLEAR_PAGES == osi.osd_err_pri) { |
185 | EXOFS_DBGMSG("%s: EFAULT Need page clear\n", __func__); | 235 | /* start read offset passed endof file */ |
186 | /*FIXME: All the pages in this device range should: | 236 | _clear_bio(ios->per_dev[i].bio); |
187 | * clear_highpage(page); | 237 | EXOFS_DBGMSG("start read offset passed end of file " |
188 | */ | 238 | "offset=0x%llx, length=0x%llx\n", |
239 | _LLU(ios->per_dev[i].offset), | ||
240 | _LLU(ios->per_dev[i].length)); | ||
241 | |||
242 | continue; /* we recovered */ | ||
189 | } | 243 | } |
190 | 244 | ||
191 | if (osi.osd_err_pri >= acumulated_osd_err) { | 245 | if (osi.osd_err_pri >= acumulated_osd_err) { |
@@ -205,14 +259,259 @@ int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | |||
205 | return acumulated_lin_err; | 259 | return acumulated_lin_err; |
206 | } | 260 | } |
207 | 261 | ||
262 | /* | ||
263 | * L - logical offset into the file | ||
264 | * | ||
265 | * U - The number of bytes in a stripe within a group | ||
266 | * | ||
267 | * U = stripe_unit * group_width | ||
268 | * | ||
269 | * T - The number of bytes striped within a group of component objects | ||
270 | * (before advancing to the next group) | ||
271 | * | ||
272 | * T = stripe_unit * group_width * group_depth | ||
273 | * | ||
274 | * S - The number of bytes striped across all component objects | ||
275 | * before the pattern repeats | ||
276 | * | ||
277 | * S = stripe_unit * group_width * group_depth * group_count | ||
278 | * | ||
279 | * M - The "major" (i.e., across all components) stripe number | ||
280 | * | ||
281 | * M = L / S | ||
282 | * | ||
283 | * G - Counts the groups from the beginning of the major stripe | ||
284 | * | ||
285 | * G = (L - (M * S)) / T [or (L % S) / T] | ||
286 | * | ||
287 | * H - The byte offset within the group | ||
288 | * | ||
289 | * H = (L - (M * S)) % T [or (L % S) % T] | ||
290 | * | ||
291 | * N - The "minor" (i.e., across the group) stripe number | ||
292 | * | ||
293 | * N = H / U | ||
294 | * | ||
295 | * C - The component index coresponding to L | ||
296 | * | ||
297 | * C = (H - (N * U)) / stripe_unit + G * group_width | ||
298 | * [or (L % U) / stripe_unit + G * group_width] | ||
299 | * | ||
300 | * O - The component offset coresponding to L | ||
301 | * | ||
302 | * O = L % stripe_unit + N * stripe_unit + M * group_depth * stripe_unit | ||
303 | */ | ||
304 | struct _striping_info { | ||
305 | u64 obj_offset; | ||
306 | u64 group_length; | ||
307 | u64 total_group_length; | ||
308 | u64 Major; | ||
309 | unsigned dev; | ||
310 | unsigned unit_off; | ||
311 | }; | ||
312 | |||
313 | static void _calc_stripe_info(struct exofs_io_state *ios, u64 file_offset, | ||
314 | struct _striping_info *si) | ||
315 | { | ||
316 | u32 stripe_unit = ios->layout->stripe_unit; | ||
317 | u32 group_width = ios->layout->group_width; | ||
318 | u64 group_depth = ios->layout->group_depth; | ||
319 | |||
320 | u32 U = stripe_unit * group_width; | ||
321 | u64 T = U * group_depth; | ||
322 | u64 S = T * ios->layout->group_count; | ||
323 | u64 M = div64_u64(file_offset, S); | ||
324 | |||
325 | /* | ||
326 | G = (L - (M * S)) / T | ||
327 | H = (L - (M * S)) % T | ||
328 | */ | ||
329 | u64 LmodS = file_offset - M * S; | ||
330 | u32 G = div64_u64(LmodS, T); | ||
331 | u64 H = LmodS - G * T; | ||
332 | |||
333 | u32 N = div_u64(H, U); | ||
334 | |||
335 | /* "H - (N * U)" is just "H % U" so it's bound to u32 */ | ||
336 | si->dev = (u32)(H - (N * U)) / stripe_unit + G * group_width; | ||
337 | si->dev *= ios->layout->mirrors_p1; | ||
338 | |||
339 | div_u64_rem(file_offset, stripe_unit, &si->unit_off); | ||
340 | |||
341 | si->obj_offset = si->unit_off + (N * stripe_unit) + | ||
342 | (M * group_depth * stripe_unit); | ||
343 | |||
344 | si->group_length = T - H; | ||
345 | si->total_group_length = T; | ||
346 | si->Major = M; | ||
347 | } | ||
348 | |||
349 | static int _add_stripe_unit(struct exofs_io_state *ios, unsigned *cur_pg, | ||
350 | unsigned pgbase, struct exofs_per_dev_state *per_dev, | ||
351 | int cur_len) | ||
352 | { | ||
353 | unsigned pg = *cur_pg; | ||
354 | struct request_queue *q = | ||
355 | osd_request_queue(exofs_ios_od(ios, per_dev->dev)); | ||
356 | |||
357 | per_dev->length += cur_len; | ||
358 | |||
359 | if (per_dev->bio == NULL) { | ||
360 | unsigned pages_in_stripe = ios->layout->group_width * | ||
361 | (ios->layout->stripe_unit / PAGE_SIZE); | ||
362 | unsigned bio_size = (ios->nr_pages + pages_in_stripe) / | ||
363 | ios->layout->group_width; | ||
364 | |||
365 | per_dev->bio = bio_kmalloc(GFP_KERNEL, bio_size); | ||
366 | if (unlikely(!per_dev->bio)) { | ||
367 | EXOFS_DBGMSG("Faild to allocate BIO size=%u\n", | ||
368 | bio_size); | ||
369 | return -ENOMEM; | ||
370 | } | ||
371 | } | ||
372 | |||
373 | while (cur_len > 0) { | ||
374 | unsigned pglen = min_t(unsigned, PAGE_SIZE - pgbase, cur_len); | ||
375 | unsigned added_len; | ||
376 | |||
377 | BUG_ON(ios->nr_pages <= pg); | ||
378 | cur_len -= pglen; | ||
379 | |||
380 | added_len = bio_add_pc_page(q, per_dev->bio, ios->pages[pg], | ||
381 | pglen, pgbase); | ||
382 | if (unlikely(pglen != added_len)) | ||
383 | return -ENOMEM; | ||
384 | pgbase = 0; | ||
385 | ++pg; | ||
386 | } | ||
387 | BUG_ON(cur_len); | ||
388 | |||
389 | *cur_pg = pg; | ||
390 | return 0; | ||
391 | } | ||
392 | |||
393 | static int _prepare_one_group(struct exofs_io_state *ios, u64 length, | ||
394 | struct _striping_info *si, unsigned first_comp) | ||
395 | { | ||
396 | unsigned stripe_unit = ios->layout->stripe_unit; | ||
397 | unsigned mirrors_p1 = ios->layout->mirrors_p1; | ||
398 | unsigned devs_in_group = ios->layout->group_width * mirrors_p1; | ||
399 | unsigned dev = si->dev; | ||
400 | unsigned first_dev = dev - (dev % devs_in_group); | ||
401 | unsigned comp = first_comp + (dev - first_dev); | ||
402 | unsigned max_comp = ios->numdevs ? ios->numdevs - mirrors_p1 : 0; | ||
403 | unsigned cur_pg = ios->pages_consumed; | ||
404 | int ret = 0; | ||
405 | |||
406 | while (length) { | ||
407 | struct exofs_per_dev_state *per_dev = &ios->per_dev[comp]; | ||
408 | unsigned cur_len, page_off = 0; | ||
409 | |||
410 | if (!per_dev->length) { | ||
411 | per_dev->dev = dev; | ||
412 | if (dev < si->dev) { | ||
413 | per_dev->offset = si->obj_offset + stripe_unit - | ||
414 | si->unit_off; | ||
415 | cur_len = stripe_unit; | ||
416 | } else if (dev == si->dev) { | ||
417 | per_dev->offset = si->obj_offset; | ||
418 | cur_len = stripe_unit - si->unit_off; | ||
419 | page_off = si->unit_off & ~PAGE_MASK; | ||
420 | BUG_ON(page_off && (page_off != ios->pgbase)); | ||
421 | } else { /* dev > si->dev */ | ||
422 | per_dev->offset = si->obj_offset - si->unit_off; | ||
423 | cur_len = stripe_unit; | ||
424 | } | ||
425 | |||
426 | if (max_comp < comp) | ||
427 | max_comp = comp; | ||
428 | |||
429 | dev += mirrors_p1; | ||
430 | dev = (dev % devs_in_group) + first_dev; | ||
431 | } else { | ||
432 | cur_len = stripe_unit; | ||
433 | } | ||
434 | if (cur_len >= length) | ||
435 | cur_len = length; | ||
436 | |||
437 | ret = _add_stripe_unit(ios, &cur_pg, page_off , per_dev, | ||
438 | cur_len); | ||
439 | if (unlikely(ret)) | ||
440 | goto out; | ||
441 | |||
442 | comp += mirrors_p1; | ||
443 | comp = (comp % devs_in_group) + first_comp; | ||
444 | |||
445 | length -= cur_len; | ||
446 | } | ||
447 | out: | ||
448 | ios->numdevs = max_comp + mirrors_p1; | ||
449 | ios->pages_consumed = cur_pg; | ||
450 | return ret; | ||
451 | } | ||
452 | |||
453 | static int _prepare_for_striping(struct exofs_io_state *ios) | ||
454 | { | ||
455 | u64 length = ios->length; | ||
456 | struct _striping_info si; | ||
457 | unsigned devs_in_group = ios->layout->group_width * | ||
458 | ios->layout->mirrors_p1; | ||
459 | unsigned first_comp = 0; | ||
460 | int ret = 0; | ||
461 | |||
462 | _calc_stripe_info(ios, ios->offset, &si); | ||
463 | |||
464 | if (!ios->pages) { | ||
465 | if (ios->kern_buff) { | ||
466 | struct exofs_per_dev_state *per_dev = &ios->per_dev[0]; | ||
467 | |||
468 | per_dev->offset = si.obj_offset; | ||
469 | per_dev->dev = si.dev; | ||
470 | |||
471 | /* no cross device without page array */ | ||
472 | BUG_ON((ios->layout->group_width > 1) && | ||
473 | (si.unit_off + ios->length > | ||
474 | ios->layout->stripe_unit)); | ||
475 | } | ||
476 | ios->numdevs = ios->layout->mirrors_p1; | ||
477 | return 0; | ||
478 | } | ||
479 | |||
480 | while (length) { | ||
481 | if (length < si.group_length) | ||
482 | si.group_length = length; | ||
483 | |||
484 | ret = _prepare_one_group(ios, si.group_length, &si, first_comp); | ||
485 | if (unlikely(ret)) | ||
486 | goto out; | ||
487 | |||
488 | length -= si.group_length; | ||
489 | |||
490 | si.group_length = si.total_group_length; | ||
491 | si.unit_off = 0; | ||
492 | ++si.Major; | ||
493 | si.obj_offset = si.Major * ios->layout->stripe_unit * | ||
494 | ios->layout->group_depth; | ||
495 | |||
496 | si.dev = (si.dev - (si.dev % devs_in_group)) + devs_in_group; | ||
497 | si.dev %= ios->layout->s_numdevs; | ||
498 | |||
499 | first_comp += devs_in_group; | ||
500 | first_comp %= ios->layout->s_numdevs; | ||
501 | } | ||
502 | |||
503 | out: | ||
504 | return ret; | ||
505 | } | ||
506 | |||
208 | int exofs_sbi_create(struct exofs_io_state *ios) | 507 | int exofs_sbi_create(struct exofs_io_state *ios) |
209 | { | 508 | { |
210 | int i, ret; | 509 | int i, ret; |
211 | 510 | ||
212 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 511 | for (i = 0; i < ios->layout->s_numdevs; i++) { |
213 | struct osd_request *or; | 512 | struct osd_request *or; |
214 | 513 | ||
215 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 514 | or = osd_start_request(exofs_ios_od(ios, i), GFP_KERNEL); |
216 | if (unlikely(!or)) { | 515 | if (unlikely(!or)) { |
217 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 516 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
218 | ret = -ENOMEM; | 517 | ret = -ENOMEM; |
@@ -233,10 +532,10 @@ int exofs_sbi_remove(struct exofs_io_state *ios) | |||
233 | { | 532 | { |
234 | int i, ret; | 533 | int i, ret; |
235 | 534 | ||
236 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 535 | for (i = 0; i < ios->layout->s_numdevs; i++) { |
237 | struct osd_request *or; | 536 | struct osd_request *or; |
238 | 537 | ||
239 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 538 | or = osd_start_request(exofs_ios_od(ios, i), GFP_KERNEL); |
240 | if (unlikely(!or)) { | 539 | if (unlikely(!or)) { |
241 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 540 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
242 | ret = -ENOMEM; | 541 | ret = -ENOMEM; |
@@ -253,51 +552,74 @@ out: | |||
253 | return ret; | 552 | return ret; |
254 | } | 553 | } |
255 | 554 | ||
256 | int exofs_sbi_write(struct exofs_io_state *ios) | 555 | static int _sbi_write_mirror(struct exofs_io_state *ios, int cur_comp) |
257 | { | 556 | { |
258 | int i, ret; | 557 | struct exofs_per_dev_state *master_dev = &ios->per_dev[cur_comp]; |
558 | unsigned dev = ios->per_dev[cur_comp].dev; | ||
559 | unsigned last_comp = cur_comp + ios->layout->mirrors_p1; | ||
560 | int ret = 0; | ||
259 | 561 | ||
260 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 562 | if (ios->pages && !master_dev->length) |
563 | return 0; /* Just an empty slot */ | ||
564 | |||
565 | for (; cur_comp < last_comp; ++cur_comp, ++dev) { | ||
566 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
261 | struct osd_request *or; | 567 | struct osd_request *or; |
262 | 568 | ||
263 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 569 | or = osd_start_request(exofs_ios_od(ios, dev), GFP_KERNEL); |
264 | if (unlikely(!or)) { | 570 | if (unlikely(!or)) { |
265 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 571 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
266 | ret = -ENOMEM; | 572 | ret = -ENOMEM; |
267 | goto out; | 573 | goto out; |
268 | } | 574 | } |
269 | ios->per_dev[i].or = or; | 575 | per_dev->or = or; |
270 | ios->numdevs++; | 576 | per_dev->offset = master_dev->offset; |
271 | 577 | ||
272 | if (ios->bio) { | 578 | if (ios->pages) { |
273 | struct bio *bio; | 579 | struct bio *bio; |
274 | 580 | ||
275 | if (i != 0) { | 581 | if (per_dev != master_dev) { |
276 | bio = bio_kmalloc(GFP_KERNEL, | 582 | bio = bio_kmalloc(GFP_KERNEL, |
277 | ios->bio->bi_max_vecs); | 583 | master_dev->bio->bi_max_vecs); |
278 | if (unlikely(!bio)) { | 584 | if (unlikely(!bio)) { |
585 | EXOFS_DBGMSG( | ||
586 | "Faild to allocate BIO size=%u\n", | ||
587 | master_dev->bio->bi_max_vecs); | ||
279 | ret = -ENOMEM; | 588 | ret = -ENOMEM; |
280 | goto out; | 589 | goto out; |
281 | } | 590 | } |
282 | 591 | ||
283 | __bio_clone(bio, ios->bio); | 592 | __bio_clone(bio, master_dev->bio); |
284 | bio->bi_bdev = NULL; | 593 | bio->bi_bdev = NULL; |
285 | bio->bi_next = NULL; | 594 | bio->bi_next = NULL; |
286 | ios->per_dev[i].bio = bio; | 595 | per_dev->length = master_dev->length; |
596 | per_dev->bio = bio; | ||
597 | per_dev->dev = dev; | ||
287 | } else { | 598 | } else { |
288 | bio = ios->bio; | 599 | bio = master_dev->bio; |
600 | /* FIXME: bio_set_dir() */ | ||
601 | bio->bi_rw |= (1 << BIO_RW); | ||
289 | } | 602 | } |
290 | 603 | ||
291 | osd_req_write(or, &ios->obj, ios->offset, bio, | 604 | osd_req_write(or, &ios->obj, per_dev->offset, bio, |
292 | ios->length); | 605 | per_dev->length); |
293 | /* EXOFS_DBGMSG("write sync=%d\n", sync);*/ | 606 | EXOFS_DBGMSG("write(0x%llx) offset=0x%llx " |
607 | "length=0x%llx dev=%d\n", | ||
608 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
609 | _LLU(per_dev->length), dev); | ||
294 | } else if (ios->kern_buff) { | 610 | } else if (ios->kern_buff) { |
295 | osd_req_write_kern(or, &ios->obj, ios->offset, | 611 | ret = osd_req_write_kern(or, &ios->obj, per_dev->offset, |
296 | ios->kern_buff, ios->length); | 612 | ios->kern_buff, ios->length); |
297 | /* EXOFS_DBGMSG("write_kern sync=%d\n", sync);*/ | 613 | if (unlikely(ret)) |
614 | goto out; | ||
615 | EXOFS_DBGMSG2("write_kern(0x%llx) offset=0x%llx " | ||
616 | "length=0x%llx dev=%d\n", | ||
617 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
618 | _LLU(ios->length), dev); | ||
298 | } else { | 619 | } else { |
299 | osd_req_set_attributes(or, &ios->obj); | 620 | osd_req_set_attributes(or, &ios->obj); |
300 | /* EXOFS_DBGMSG("set_attributes sync=%d\n", sync);*/ | 621 | EXOFS_DBGMSG2("obj(0x%llx) set_attributes=%d dev=%d\n", |
622 | _LLU(ios->obj.id), ios->out_attr_len, dev); | ||
301 | } | 623 | } |
302 | 624 | ||
303 | if (ios->out_attr) | 625 | if (ios->out_attr) |
@@ -308,54 +630,93 @@ int exofs_sbi_write(struct exofs_io_state *ios) | |||
308 | osd_req_add_get_attr_list(or, ios->in_attr, | 630 | osd_req_add_get_attr_list(or, ios->in_attr, |
309 | ios->in_attr_len); | 631 | ios->in_attr_len); |
310 | } | 632 | } |
311 | ret = exofs_io_execute(ios); | ||
312 | 633 | ||
313 | out: | 634 | out: |
314 | return ret; | 635 | return ret; |
315 | } | 636 | } |
316 | 637 | ||
317 | int exofs_sbi_read(struct exofs_io_state *ios) | 638 | int exofs_sbi_write(struct exofs_io_state *ios) |
318 | { | 639 | { |
319 | int i, ret; | 640 | int i; |
641 | int ret; | ||
320 | 642 | ||
321 | for (i = 0; i < 1; i++) { | 643 | ret = _prepare_for_striping(ios); |
322 | struct osd_request *or; | 644 | if (unlikely(ret)) |
323 | unsigned first_dev = (unsigned)ios->obj.id; | 645 | return ret; |
324 | 646 | ||
325 | first_dev %= ios->sbi->s_numdevs; | 647 | for (i = 0; i < ios->numdevs; i += ios->layout->mirrors_p1) { |
326 | or = osd_start_request(ios->sbi->s_ods[first_dev], GFP_KERNEL); | 648 | ret = _sbi_write_mirror(ios, i); |
327 | if (unlikely(!or)) { | 649 | if (unlikely(ret)) |
328 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 650 | return ret; |
329 | ret = -ENOMEM; | 651 | } |
330 | goto out; | ||
331 | } | ||
332 | ios->per_dev[i].or = or; | ||
333 | ios->numdevs++; | ||
334 | 652 | ||
335 | if (ios->bio) { | 653 | ret = exofs_io_execute(ios); |
336 | osd_req_read(or, &ios->obj, ios->offset, ios->bio, | 654 | return ret; |
337 | ios->length); | 655 | } |
338 | /* EXOFS_DBGMSG("read sync=%d\n", sync);*/ | ||
339 | } else if (ios->kern_buff) { | ||
340 | osd_req_read_kern(or, &ios->obj, ios->offset, | ||
341 | ios->kern_buff, ios->length); | ||
342 | /* EXOFS_DBGMSG("read_kern sync=%d\n", sync);*/ | ||
343 | } else { | ||
344 | osd_req_get_attributes(or, &ios->obj); | ||
345 | /* EXOFS_DBGMSG("get_attributes sync=%d\n", sync);*/ | ||
346 | } | ||
347 | 656 | ||
348 | if (ios->out_attr) | 657 | static int _sbi_read_mirror(struct exofs_io_state *ios, unsigned cur_comp) |
349 | osd_req_add_set_attr_list(or, ios->out_attr, | 658 | { |
350 | ios->out_attr_len); | 659 | struct osd_request *or; |
660 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
661 | unsigned first_dev = (unsigned)ios->obj.id; | ||
351 | 662 | ||
352 | if (ios->in_attr) | 663 | if (ios->pages && !per_dev->length) |
353 | osd_req_add_get_attr_list(or, ios->in_attr, | 664 | return 0; /* Just an empty slot */ |
354 | ios->in_attr_len); | 665 | |
666 | first_dev = per_dev->dev + first_dev % ios->layout->mirrors_p1; | ||
667 | or = osd_start_request(exofs_ios_od(ios, first_dev), GFP_KERNEL); | ||
668 | if (unlikely(!or)) { | ||
669 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
670 | return -ENOMEM; | ||
355 | } | 671 | } |
356 | ret = exofs_io_execute(ios); | 672 | per_dev->or = or; |
673 | |||
674 | if (ios->pages) { | ||
675 | osd_req_read(or, &ios->obj, per_dev->offset, | ||
676 | per_dev->bio, per_dev->length); | ||
677 | EXOFS_DBGMSG("read(0x%llx) offset=0x%llx length=0x%llx" | ||
678 | " dev=%d\n", _LLU(ios->obj.id), | ||
679 | _LLU(per_dev->offset), _LLU(per_dev->length), | ||
680 | first_dev); | ||
681 | } else if (ios->kern_buff) { | ||
682 | int ret = osd_req_read_kern(or, &ios->obj, per_dev->offset, | ||
683 | ios->kern_buff, ios->length); | ||
684 | EXOFS_DBGMSG2("read_kern(0x%llx) offset=0x%llx " | ||
685 | "length=0x%llx dev=%d ret=>%d\n", | ||
686 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
687 | _LLU(ios->length), first_dev, ret); | ||
688 | if (unlikely(ret)) | ||
689 | return ret; | ||
690 | } else { | ||
691 | osd_req_get_attributes(or, &ios->obj); | ||
692 | EXOFS_DBGMSG2("obj(0x%llx) get_attributes=%d dev=%d\n", | ||
693 | _LLU(ios->obj.id), ios->in_attr_len, first_dev); | ||
694 | } | ||
695 | if (ios->out_attr) | ||
696 | osd_req_add_set_attr_list(or, ios->out_attr, ios->out_attr_len); | ||
357 | 697 | ||
358 | out: | 698 | if (ios->in_attr) |
699 | osd_req_add_get_attr_list(or, ios->in_attr, ios->in_attr_len); | ||
700 | |||
701 | return 0; | ||
702 | } | ||
703 | |||
704 | int exofs_sbi_read(struct exofs_io_state *ios) | ||
705 | { | ||
706 | int i; | ||
707 | int ret; | ||
708 | |||
709 | ret = _prepare_for_striping(ios); | ||
710 | if (unlikely(ret)) | ||
711 | return ret; | ||
712 | |||
713 | for (i = 0; i < ios->numdevs; i += ios->layout->mirrors_p1) { | ||
714 | ret = _sbi_read_mirror(ios, i); | ||
715 | if (unlikely(ret)) | ||
716 | return ret; | ||
717 | } | ||
718 | |||
719 | ret = exofs_io_execute(ios); | ||
359 | return ret; | 720 | return ret; |
360 | } | 721 | } |
361 | 722 | ||
@@ -380,42 +741,82 @@ int extract_attr_from_ios(struct exofs_io_state *ios, struct osd_attr *attr) | |||
380 | return -EIO; | 741 | return -EIO; |
381 | } | 742 | } |
382 | 743 | ||
744 | static int _truncate_mirrors(struct exofs_io_state *ios, unsigned cur_comp, | ||
745 | struct osd_attr *attr) | ||
746 | { | ||
747 | int last_comp = cur_comp + ios->layout->mirrors_p1; | ||
748 | |||
749 | for (; cur_comp < last_comp; ++cur_comp) { | ||
750 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
751 | struct osd_request *or; | ||
752 | |||
753 | or = osd_start_request(exofs_ios_od(ios, cur_comp), GFP_KERNEL); | ||
754 | if (unlikely(!or)) { | ||
755 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
756 | return -ENOMEM; | ||
757 | } | ||
758 | per_dev->or = or; | ||
759 | |||
760 | osd_req_set_attributes(or, &ios->obj); | ||
761 | osd_req_add_set_attr_list(or, attr, 1); | ||
762 | } | ||
763 | |||
764 | return 0; | ||
765 | } | ||
766 | |||
383 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 size) | 767 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 size) |
384 | { | 768 | { |
385 | struct exofs_sb_info *sbi = oi->vfs_inode.i_sb->s_fs_info; | 769 | struct exofs_sb_info *sbi = oi->vfs_inode.i_sb->s_fs_info; |
386 | struct exofs_io_state *ios; | 770 | struct exofs_io_state *ios; |
387 | struct osd_attr attr; | 771 | struct exofs_trunc_attr { |
388 | __be64 newsize; | 772 | struct osd_attr attr; |
773 | __be64 newsize; | ||
774 | } *size_attrs; | ||
775 | struct _striping_info si; | ||
389 | int i, ret; | 776 | int i, ret; |
390 | 777 | ||
391 | if (exofs_get_io_state(sbi, &ios)) | 778 | ret = exofs_get_io_state(&sbi->layout, &ios); |
392 | return -ENOMEM; | 779 | if (unlikely(ret)) |
780 | return ret; | ||
781 | |||
782 | size_attrs = kcalloc(ios->layout->group_width, sizeof(*size_attrs), | ||
783 | GFP_KERNEL); | ||
784 | if (unlikely(!size_attrs)) { | ||
785 | ret = -ENOMEM; | ||
786 | goto out; | ||
787 | } | ||
393 | 788 | ||
394 | ios->obj.id = exofs_oi_objno(oi); | 789 | ios->obj.id = exofs_oi_objno(oi); |
395 | ios->cred = oi->i_cred; | 790 | ios->cred = oi->i_cred; |
396 | 791 | ||
397 | newsize = cpu_to_be64(size); | 792 | ios->numdevs = ios->layout->s_numdevs; |
398 | attr = g_attr_logical_length; | 793 | _calc_stripe_info(ios, size, &si); |
399 | attr.val_ptr = &newsize; | ||
400 | 794 | ||
401 | for (i = 0; i < sbi->s_numdevs; i++) { | 795 | for (i = 0; i < ios->layout->group_width; ++i) { |
402 | struct osd_request *or; | 796 | struct exofs_trunc_attr *size_attr = &size_attrs[i]; |
797 | u64 obj_size; | ||
403 | 798 | ||
404 | or = osd_start_request(sbi->s_ods[i], GFP_KERNEL); | 799 | if (i < si.dev) |
405 | if (unlikely(!or)) { | 800 | obj_size = si.obj_offset + |
406 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 801 | ios->layout->stripe_unit - si.unit_off; |
407 | ret = -ENOMEM; | 802 | else if (i == si.dev) |
408 | goto out; | 803 | obj_size = si.obj_offset; |
409 | } | 804 | else /* i > si.dev */ |
410 | ios->per_dev[i].or = or; | 805 | obj_size = si.obj_offset - si.unit_off; |
411 | ios->numdevs++; | ||
412 | 806 | ||
413 | osd_req_set_attributes(or, &ios->obj); | 807 | size_attr->newsize = cpu_to_be64(obj_size); |
414 | osd_req_add_set_attr_list(or, &attr, 1); | 808 | size_attr->attr = g_attr_logical_length; |
809 | size_attr->attr.val_ptr = &size_attr->newsize; | ||
810 | |||
811 | ret = _truncate_mirrors(ios, i * ios->layout->mirrors_p1, | ||
812 | &size_attr->attr); | ||
813 | if (unlikely(ret)) | ||
814 | goto out; | ||
415 | } | 815 | } |
416 | ret = exofs_io_execute(ios); | 816 | ret = exofs_io_execute(ios); |
417 | 817 | ||
418 | out: | 818 | out: |
819 | kfree(size_attrs); | ||
419 | exofs_put_io_state(ios); | 820 | exofs_put_io_state(ios); |
420 | return ret; | 821 | return ret; |
421 | } | 822 | } |
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index a1d1e77b12eb..6cf5e4e84d61 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c | |||
@@ -210,7 +210,7 @@ int exofs_sync_fs(struct super_block *sb, int wait) | |||
210 | sbi = sb->s_fs_info; | 210 | sbi = sb->s_fs_info; |
211 | fscb = &sbi->s_fscb; | 211 | fscb = &sbi->s_fscb; |
212 | 212 | ||
213 | ret = exofs_get_io_state(sbi, &ios); | 213 | ret = exofs_get_io_state(&sbi->layout, &ios); |
214 | if (ret) | 214 | if (ret) |
215 | goto out; | 215 | goto out; |
216 | 216 | ||
@@ -264,12 +264,12 @@ static void _exofs_print_device(const char *msg, const char *dev_path, | |||
264 | 264 | ||
265 | void exofs_free_sbi(struct exofs_sb_info *sbi) | 265 | void exofs_free_sbi(struct exofs_sb_info *sbi) |
266 | { | 266 | { |
267 | while (sbi->s_numdevs) { | 267 | while (sbi->layout.s_numdevs) { |
268 | int i = --sbi->s_numdevs; | 268 | int i = --sbi->layout.s_numdevs; |
269 | struct osd_dev *od = sbi->s_ods[i]; | 269 | struct osd_dev *od = sbi->layout.s_ods[i]; |
270 | 270 | ||
271 | if (od) { | 271 | if (od) { |
272 | sbi->s_ods[i] = NULL; | 272 | sbi->layout.s_ods[i] = NULL; |
273 | osduld_put_device(od); | 273 | osduld_put_device(od); |
274 | } | 274 | } |
275 | } | 275 | } |
@@ -298,7 +298,8 @@ static void exofs_put_super(struct super_block *sb) | |||
298 | msecs_to_jiffies(100)); | 298 | msecs_to_jiffies(100)); |
299 | } | 299 | } |
300 | 300 | ||
301 | _exofs_print_device("Unmounting", NULL, sbi->s_ods[0], sbi->s_pid); | 301 | _exofs_print_device("Unmounting", NULL, sbi->layout.s_ods[0], |
302 | sbi->layout.s_pid); | ||
302 | 303 | ||
303 | exofs_free_sbi(sbi); | 304 | exofs_free_sbi(sbi); |
304 | sb->s_fs_info = NULL; | 305 | sb->s_fs_info = NULL; |
@@ -307,6 +308,8 @@ static void exofs_put_super(struct super_block *sb) | |||
307 | static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, | 308 | static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, |
308 | struct exofs_device_table *dt) | 309 | struct exofs_device_table *dt) |
309 | { | 310 | { |
311 | u64 stripe_length; | ||
312 | |||
310 | sbi->data_map.odm_num_comps = | 313 | sbi->data_map.odm_num_comps = |
311 | le32_to_cpu(dt->dt_data_map.cb_num_comps); | 314 | le32_to_cpu(dt->dt_data_map.cb_num_comps); |
312 | sbi->data_map.odm_stripe_unit = | 315 | sbi->data_map.odm_stripe_unit = |
@@ -320,14 +323,63 @@ static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, | |||
320 | sbi->data_map.odm_raid_algorithm = | 323 | sbi->data_map.odm_raid_algorithm = |
321 | le32_to_cpu(dt->dt_data_map.cb_raid_algorithm); | 324 | le32_to_cpu(dt->dt_data_map.cb_raid_algorithm); |
322 | 325 | ||
323 | /* FIXME: Hard coded mirror only for now. if not so do not mount */ | 326 | /* FIXME: Only raid0 for now. if not so, do not mount */ |
324 | if ((sbi->data_map.odm_num_comps != numdevs) || | 327 | if (sbi->data_map.odm_num_comps != numdevs) { |
325 | (sbi->data_map.odm_stripe_unit != EXOFS_BLKSIZE) || | 328 | EXOFS_ERR("odm_num_comps(%u) != numdevs(%u)\n", |
326 | (sbi->data_map.odm_raid_algorithm != PNFS_OSD_RAID_0) || | 329 | sbi->data_map.odm_num_comps, numdevs); |
327 | (sbi->data_map.odm_mirror_cnt != (numdevs - 1))) | ||
328 | return -EINVAL; | 330 | return -EINVAL; |
329 | else | 331 | } |
330 | return 0; | 332 | if (sbi->data_map.odm_raid_algorithm != PNFS_OSD_RAID_0) { |
333 | EXOFS_ERR("Only RAID_0 for now\n"); | ||
334 | return -EINVAL; | ||
335 | } | ||
336 | if (0 != (numdevs % (sbi->data_map.odm_mirror_cnt + 1))) { | ||
337 | EXOFS_ERR("Data Map wrong, numdevs=%d mirrors=%d\n", | ||
338 | numdevs, sbi->data_map.odm_mirror_cnt); | ||
339 | return -EINVAL; | ||
340 | } | ||
341 | |||
342 | if (0 != (sbi->data_map.odm_stripe_unit & ~PAGE_MASK)) { | ||
343 | EXOFS_ERR("Stripe Unit(0x%llx)" | ||
344 | " must be Multples of PAGE_SIZE(0x%lx)\n", | ||
345 | _LLU(sbi->data_map.odm_stripe_unit), PAGE_SIZE); | ||
346 | return -EINVAL; | ||
347 | } | ||
348 | |||
349 | sbi->layout.stripe_unit = sbi->data_map.odm_stripe_unit; | ||
350 | sbi->layout.mirrors_p1 = sbi->data_map.odm_mirror_cnt + 1; | ||
351 | |||
352 | if (sbi->data_map.odm_group_width) { | ||
353 | sbi->layout.group_width = sbi->data_map.odm_group_width; | ||
354 | sbi->layout.group_depth = sbi->data_map.odm_group_depth; | ||
355 | if (!sbi->layout.group_depth) { | ||
356 | EXOFS_ERR("group_depth == 0 && group_width != 0\n"); | ||
357 | return -EINVAL; | ||
358 | } | ||
359 | sbi->layout.group_count = sbi->data_map.odm_num_comps / | ||
360 | sbi->layout.mirrors_p1 / | ||
361 | sbi->data_map.odm_group_width; | ||
362 | } else { | ||
363 | if (sbi->data_map.odm_group_depth) { | ||
364 | printk(KERN_NOTICE "Warning: group_depth ignored " | ||
365 | "group_width == 0 && group_depth == %d\n", | ||
366 | sbi->data_map.odm_group_depth); | ||
367 | sbi->data_map.odm_group_depth = 0; | ||
368 | } | ||
369 | sbi->layout.group_width = sbi->data_map.odm_num_comps / | ||
370 | sbi->layout.mirrors_p1; | ||
371 | sbi->layout.group_depth = -1; | ||
372 | sbi->layout.group_count = 1; | ||
373 | } | ||
374 | |||
375 | stripe_length = (u64)sbi->layout.group_width * sbi->layout.stripe_unit; | ||
376 | if (stripe_length >= (1ULL << 32)) { | ||
377 | EXOFS_ERR("Total Stripe length(0x%llx)" | ||
378 | " >= 32bit is not supported\n", _LLU(stripe_length)); | ||
379 | return -EINVAL; | ||
380 | } | ||
381 | |||
382 | return 0; | ||
331 | } | 383 | } |
332 | 384 | ||
333 | /* @odi is valid only as long as @fscb_dev is valid */ | 385 | /* @odi is valid only as long as @fscb_dev is valid */ |
@@ -361,7 +413,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
361 | { | 413 | { |
362 | struct exofs_sb_info *sbi = *psbi; | 414 | struct exofs_sb_info *sbi = *psbi; |
363 | struct osd_dev *fscb_od; | 415 | struct osd_dev *fscb_od; |
364 | struct osd_obj_id obj = {.partition = sbi->s_pid, | 416 | struct osd_obj_id obj = {.partition = sbi->layout.s_pid, |
365 | .id = EXOFS_DEVTABLE_ID}; | 417 | .id = EXOFS_DEVTABLE_ID}; |
366 | struct exofs_device_table *dt; | 418 | struct exofs_device_table *dt; |
367 | unsigned table_bytes = table_count * sizeof(dt->dt_dev_table[0]) + | 419 | unsigned table_bytes = table_count * sizeof(dt->dt_dev_table[0]) + |
@@ -376,9 +428,9 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
376 | return -ENOMEM; | 428 | return -ENOMEM; |
377 | } | 429 | } |
378 | 430 | ||
379 | fscb_od = sbi->s_ods[0]; | 431 | fscb_od = sbi->layout.s_ods[0]; |
380 | sbi->s_ods[0] = NULL; | 432 | sbi->layout.s_ods[0] = NULL; |
381 | sbi->s_numdevs = 0; | 433 | sbi->layout.s_numdevs = 0; |
382 | ret = exofs_read_kern(fscb_od, sbi->s_cred, &obj, 0, dt, table_bytes); | 434 | ret = exofs_read_kern(fscb_od, sbi->s_cred, &obj, 0, dt, table_bytes); |
383 | if (unlikely(ret)) { | 435 | if (unlikely(ret)) { |
384 | EXOFS_ERR("ERROR: reading device table\n"); | 436 | EXOFS_ERR("ERROR: reading device table\n"); |
@@ -397,14 +449,15 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
397 | goto out; | 449 | goto out; |
398 | 450 | ||
399 | if (likely(numdevs > 1)) { | 451 | if (likely(numdevs > 1)) { |
400 | unsigned size = numdevs * sizeof(sbi->s_ods[0]); | 452 | unsigned size = numdevs * sizeof(sbi->layout.s_ods[0]); |
401 | 453 | ||
402 | sbi = krealloc(sbi, sizeof(*sbi) + size, GFP_KERNEL); | 454 | sbi = krealloc(sbi, sizeof(*sbi) + size, GFP_KERNEL); |
403 | if (unlikely(!sbi)) { | 455 | if (unlikely(!sbi)) { |
404 | ret = -ENOMEM; | 456 | ret = -ENOMEM; |
405 | goto out; | 457 | goto out; |
406 | } | 458 | } |
407 | memset(&sbi->s_ods[1], 0, size - sizeof(sbi->s_ods[0])); | 459 | memset(&sbi->layout.s_ods[1], 0, |
460 | size - sizeof(sbi->layout.s_ods[0])); | ||
408 | *psbi = sbi; | 461 | *psbi = sbi; |
409 | } | 462 | } |
410 | 463 | ||
@@ -427,8 +480,8 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
427 | * line. We always keep them in device-table order. | 480 | * line. We always keep them in device-table order. |
428 | */ | 481 | */ |
429 | if (fscb_od && osduld_device_same(fscb_od, &odi)) { | 482 | if (fscb_od && osduld_device_same(fscb_od, &odi)) { |
430 | sbi->s_ods[i] = fscb_od; | 483 | sbi->layout.s_ods[i] = fscb_od; |
431 | ++sbi->s_numdevs; | 484 | ++sbi->layout.s_numdevs; |
432 | fscb_od = NULL; | 485 | fscb_od = NULL; |
433 | continue; | 486 | continue; |
434 | } | 487 | } |
@@ -441,8 +494,8 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
441 | goto out; | 494 | goto out; |
442 | } | 495 | } |
443 | 496 | ||
444 | sbi->s_ods[i] = od; | 497 | sbi->layout.s_ods[i] = od; |
445 | ++sbi->s_numdevs; | 498 | ++sbi->layout.s_numdevs; |
446 | 499 | ||
447 | /* Read the fscb of the other devices to make sure the FS | 500 | /* Read the fscb of the other devices to make sure the FS |
448 | * partition is there. | 501 | * partition is there. |
@@ -499,9 +552,15 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
499 | goto free_sbi; | 552 | goto free_sbi; |
500 | } | 553 | } |
501 | 554 | ||
502 | sbi->s_ods[0] = od; | 555 | /* Default layout in case we do not have a device-table */ |
503 | sbi->s_numdevs = 1; | 556 | sbi->layout.stripe_unit = PAGE_SIZE; |
504 | sbi->s_pid = opts->pid; | 557 | sbi->layout.mirrors_p1 = 1; |
558 | sbi->layout.group_width = 1; | ||
559 | sbi->layout.group_depth = -1; | ||
560 | sbi->layout.group_count = 1; | ||
561 | sbi->layout.s_ods[0] = od; | ||
562 | sbi->layout.s_numdevs = 1; | ||
563 | sbi->layout.s_pid = opts->pid; | ||
505 | sbi->s_timeout = opts->timeout; | 564 | sbi->s_timeout = opts->timeout; |
506 | 565 | ||
507 | /* fill in some other data by hand */ | 566 | /* fill in some other data by hand */ |
@@ -514,7 +573,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
514 | sb->s_bdev = NULL; | 573 | sb->s_bdev = NULL; |
515 | sb->s_dev = 0; | 574 | sb->s_dev = 0; |
516 | 575 | ||
517 | obj.partition = sbi->s_pid; | 576 | obj.partition = sbi->layout.s_pid; |
518 | obj.id = EXOFS_SUPER_ID; | 577 | obj.id = EXOFS_SUPER_ID; |
519 | exofs_make_credential(sbi->s_cred, &obj); | 578 | exofs_make_credential(sbi->s_cred, &obj); |
520 | 579 | ||
@@ -578,13 +637,13 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
578 | goto free_sbi; | 637 | goto free_sbi; |
579 | } | 638 | } |
580 | 639 | ||
581 | _exofs_print_device("Mounting", opts->dev_name, sbi->s_ods[0], | 640 | _exofs_print_device("Mounting", opts->dev_name, sbi->layout.s_ods[0], |
582 | sbi->s_pid); | 641 | sbi->layout.s_pid); |
583 | return 0; | 642 | return 0; |
584 | 643 | ||
585 | free_sbi: | 644 | free_sbi: |
586 | EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n", | 645 | EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n", |
587 | opts->dev_name, sbi->s_pid, ret); | 646 | opts->dev_name, sbi->layout.s_pid, ret); |
588 | exofs_free_sbi(sbi); | 647 | exofs_free_sbi(sbi); |
589 | return ret; | 648 | return ret; |
590 | } | 649 | } |
@@ -627,7 +686,7 @@ static int exofs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
627 | uint8_t cred_a[OSD_CAP_LEN]; | 686 | uint8_t cred_a[OSD_CAP_LEN]; |
628 | int ret; | 687 | int ret; |
629 | 688 | ||
630 | ret = exofs_get_io_state(sbi, &ios); | 689 | ret = exofs_get_io_state(&sbi->layout, &ios); |
631 | if (ret) { | 690 | if (ret) { |
632 | EXOFS_DBGMSG("exofs_get_io_state failed.\n"); | 691 | EXOFS_DBGMSG("exofs_get_io_state failed.\n"); |
633 | return ret; | 692 | return ret; |
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h index 061914add3cf..0b038e47ad2f 100644 --- a/fs/ext2/ext2.h +++ b/fs/ext2/ext2.h | |||
@@ -118,7 +118,7 @@ extern unsigned long ext2_count_free (struct buffer_head *, unsigned); | |||
118 | 118 | ||
119 | /* inode.c */ | 119 | /* inode.c */ |
120 | extern struct inode *ext2_iget (struct super_block *, unsigned long); | 120 | extern struct inode *ext2_iget (struct super_block *, unsigned long); |
121 | extern int ext2_write_inode (struct inode *, int); | 121 | extern int ext2_write_inode (struct inode *, struct writeback_control *); |
122 | extern void ext2_delete_inode (struct inode *); | 122 | extern void ext2_delete_inode (struct inode *); |
123 | extern int ext2_sync_inode (struct inode *); | 123 | extern int ext2_sync_inode (struct inode *); |
124 | extern int ext2_get_block(struct inode *, sector_t, struct buffer_head *, int); | 124 | extern int ext2_get_block(struct inode *, sector_t, struct buffer_head *, int); |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 45ff49f0a4b5..fc13cc119aad 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
@@ -41,6 +41,8 @@ MODULE_AUTHOR("Remy Card and others"); | |||
41 | MODULE_DESCRIPTION("Second Extended Filesystem"); | 41 | MODULE_DESCRIPTION("Second Extended Filesystem"); |
42 | MODULE_LICENSE("GPL"); | 42 | MODULE_LICENSE("GPL"); |
43 | 43 | ||
44 | static int __ext2_write_inode(struct inode *inode, int do_sync); | ||
45 | |||
44 | /* | 46 | /* |
45 | * Test whether an inode is a fast symlink. | 47 | * Test whether an inode is a fast symlink. |
46 | */ | 48 | */ |
@@ -66,7 +68,7 @@ void ext2_delete_inode (struct inode * inode) | |||
66 | goto no_delete; | 68 | goto no_delete; |
67 | EXT2_I(inode)->i_dtime = get_seconds(); | 69 | EXT2_I(inode)->i_dtime = get_seconds(); |
68 | mark_inode_dirty(inode); | 70 | mark_inode_dirty(inode); |
69 | ext2_write_inode(inode, inode_needs_sync(inode)); | 71 | __ext2_write_inode(inode, inode_needs_sync(inode)); |
70 | 72 | ||
71 | inode->i_size = 0; | 73 | inode->i_size = 0; |
72 | if (inode->i_blocks) | 74 | if (inode->i_blocks) |
@@ -1337,7 +1339,7 @@ bad_inode: | |||
1337 | return ERR_PTR(ret); | 1339 | return ERR_PTR(ret); |
1338 | } | 1340 | } |
1339 | 1341 | ||
1340 | int ext2_write_inode(struct inode *inode, int do_sync) | 1342 | static int __ext2_write_inode(struct inode *inode, int do_sync) |
1341 | { | 1343 | { |
1342 | struct ext2_inode_info *ei = EXT2_I(inode); | 1344 | struct ext2_inode_info *ei = EXT2_I(inode); |
1343 | struct super_block *sb = inode->i_sb; | 1345 | struct super_block *sb = inode->i_sb; |
@@ -1442,6 +1444,11 @@ int ext2_write_inode(struct inode *inode, int do_sync) | |||
1442 | return err; | 1444 | return err; |
1443 | } | 1445 | } |
1444 | 1446 | ||
1447 | int ext2_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
1448 | { | ||
1449 | return __ext2_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
1450 | } | ||
1451 | |||
1445 | int ext2_sync_inode(struct inode *inode) | 1452 | int ext2_sync_inode(struct inode *inode) |
1446 | { | 1453 | { |
1447 | struct writeback_control wbc = { | 1454 | struct writeback_control wbc = { |
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index ffbbc65e3f68..7f920b7263a4 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -3107,7 +3107,7 @@ out_brelse: | |||
3107 | * `stuff()' is running, and the new i_size will be lost. Plus the inode | 3107 | * `stuff()' is running, and the new i_size will be lost. Plus the inode |
3108 | * will no longer be on the superblock's dirty inode list. | 3108 | * will no longer be on the superblock's dirty inode list. |
3109 | */ | 3109 | */ |
3110 | int ext3_write_inode(struct inode *inode, int wait) | 3110 | int ext3_write_inode(struct inode *inode, struct writeback_control *wbc) |
3111 | { | 3111 | { |
3112 | if (current->flags & PF_MEMALLOC) | 3112 | if (current->flags & PF_MEMALLOC) |
3113 | return 0; | 3113 | return 0; |
@@ -3118,7 +3118,7 @@ int ext3_write_inode(struct inode *inode, int wait) | |||
3118 | return -EIO; | 3118 | return -EIO; |
3119 | } | 3119 | } |
3120 | 3120 | ||
3121 | if (!wait) | 3121 | if (wbc->sync_mode != WB_SYNC_ALL) |
3122 | return 0; | 3122 | return 0; |
3123 | 3123 | ||
3124 | return ext3_force_commit(inode->i_sb); | 3124 | return ext3_force_commit(inode->i_sb); |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 22bc7435d913..d2f37a5516c7 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -97,8 +97,8 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
97 | /* If checksum is bad mark all blocks used to prevent allocation | 97 | /* If checksum is bad mark all blocks used to prevent allocation |
98 | * essentially implementing a per-group read-only flag. */ | 98 | * essentially implementing a per-group read-only flag. */ |
99 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { | 99 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { |
100 | ext4_error(sb, __func__, | 100 | ext4_error(sb, "Checksum bad for group %u", |
101 | "Checksum bad for group %u", block_group); | 101 | block_group); |
102 | ext4_free_blks_set(sb, gdp, 0); | 102 | ext4_free_blks_set(sb, gdp, 0); |
103 | ext4_free_inodes_set(sb, gdp, 0); | 103 | ext4_free_inodes_set(sb, gdp, 0); |
104 | ext4_itable_unused_set(sb, gdp, 0); | 104 | ext4_itable_unused_set(sb, gdp, 0); |
@@ -130,8 +130,7 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
130 | * to make sure we calculate the right free blocks | 130 | * to make sure we calculate the right free blocks |
131 | */ | 131 | */ |
132 | group_blocks = ext4_blocks_count(sbi->s_es) - | 132 | group_blocks = ext4_blocks_count(sbi->s_es) - |
133 | le32_to_cpu(sbi->s_es->s_first_data_block) - | 133 | ext4_group_first_block_no(sb, ngroups - 1); |
134 | (EXT4_BLOCKS_PER_GROUP(sb) * (ngroups - 1)); | ||
135 | } else { | 134 | } else { |
136 | group_blocks = EXT4_BLOCKS_PER_GROUP(sb); | 135 | group_blocks = EXT4_BLOCKS_PER_GROUP(sb); |
137 | } | 136 | } |
@@ -189,9 +188,6 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
189 | * when a file system is mounted (see ext4_fill_super). | 188 | * when a file system is mounted (see ext4_fill_super). |
190 | */ | 189 | */ |
191 | 190 | ||
192 | |||
193 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
194 | |||
195 | /** | 191 | /** |
196 | * ext4_get_group_desc() -- load group descriptor from disk | 192 | * ext4_get_group_desc() -- load group descriptor from disk |
197 | * @sb: super block | 193 | * @sb: super block |
@@ -210,10 +206,8 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb, | |||
210 | struct ext4_sb_info *sbi = EXT4_SB(sb); | 206 | struct ext4_sb_info *sbi = EXT4_SB(sb); |
211 | 207 | ||
212 | if (block_group >= ngroups) { | 208 | if (block_group >= ngroups) { |
213 | ext4_error(sb, "ext4_get_group_desc", | 209 | ext4_error(sb, "block_group >= groups_count - block_group = %u," |
214 | "block_group >= groups_count - " | 210 | " groups_count = %u", block_group, ngroups); |
215 | "block_group = %u, groups_count = %u", | ||
216 | block_group, ngroups); | ||
217 | 211 | ||
218 | return NULL; | 212 | return NULL; |
219 | } | 213 | } |
@@ -221,8 +215,7 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb, | |||
221 | group_desc = block_group >> EXT4_DESC_PER_BLOCK_BITS(sb); | 215 | group_desc = block_group >> EXT4_DESC_PER_BLOCK_BITS(sb); |
222 | offset = block_group & (EXT4_DESC_PER_BLOCK(sb) - 1); | 216 | offset = block_group & (EXT4_DESC_PER_BLOCK(sb) - 1); |
223 | if (!sbi->s_group_desc[group_desc]) { | 217 | if (!sbi->s_group_desc[group_desc]) { |
224 | ext4_error(sb, "ext4_get_group_desc", | 218 | ext4_error(sb, "Group descriptor not loaded - " |
225 | "Group descriptor not loaded - " | ||
226 | "block_group = %u, group_desc = %u, desc = %u", | 219 | "block_group = %u, group_desc = %u, desc = %u", |
227 | block_group, group_desc, offset); | 220 | block_group, group_desc, offset); |
228 | return NULL; | 221 | return NULL; |
@@ -282,9 +275,7 @@ static int ext4_valid_block_bitmap(struct super_block *sb, | |||
282 | return 1; | 275 | return 1; |
283 | 276 | ||
284 | err_out: | 277 | err_out: |
285 | ext4_error(sb, __func__, | 278 | ext4_error(sb, "Invalid block bitmap - block_group = %d, block = %llu", |
286 | "Invalid block bitmap - " | ||
287 | "block_group = %d, block = %llu", | ||
288 | block_group, bitmap_blk); | 279 | block_group, bitmap_blk); |
289 | return 0; | 280 | return 0; |
290 | } | 281 | } |
@@ -311,8 +302,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
311 | bitmap_blk = ext4_block_bitmap(sb, desc); | 302 | bitmap_blk = ext4_block_bitmap(sb, desc); |
312 | bh = sb_getblk(sb, bitmap_blk); | 303 | bh = sb_getblk(sb, bitmap_blk); |
313 | if (unlikely(!bh)) { | 304 | if (unlikely(!bh)) { |
314 | ext4_error(sb, __func__, | 305 | ext4_error(sb, "Cannot read block bitmap - " |
315 | "Cannot read block bitmap - " | ||
316 | "block_group = %u, block_bitmap = %llu", | 306 | "block_group = %u, block_bitmap = %llu", |
317 | block_group, bitmap_blk); | 307 | block_group, bitmap_blk); |
318 | return NULL; | 308 | return NULL; |
@@ -354,8 +344,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
354 | set_bitmap_uptodate(bh); | 344 | set_bitmap_uptodate(bh); |
355 | if (bh_submit_read(bh) < 0) { | 345 | if (bh_submit_read(bh) < 0) { |
356 | put_bh(bh); | 346 | put_bh(bh); |
357 | ext4_error(sb, __func__, | 347 | ext4_error(sb, "Cannot read block bitmap - " |
358 | "Cannot read block bitmap - " | ||
359 | "block_group = %u, block_bitmap = %llu", | 348 | "block_group = %u, block_bitmap = %llu", |
360 | block_group, bitmap_blk); | 349 | block_group, bitmap_blk); |
361 | return NULL; | 350 | return NULL; |
@@ -419,8 +408,7 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | |||
419 | in_range(block, ext4_inode_table(sb, desc), sbi->s_itb_per_group) || | 408 | in_range(block, ext4_inode_table(sb, desc), sbi->s_itb_per_group) || |
420 | in_range(block + count - 1, ext4_inode_table(sb, desc), | 409 | in_range(block + count - 1, ext4_inode_table(sb, desc), |
421 | sbi->s_itb_per_group)) { | 410 | sbi->s_itb_per_group)) { |
422 | ext4_error(sb, __func__, | 411 | ext4_error(sb, "Adding blocks in system zones - " |
423 | "Adding blocks in system zones - " | ||
424 | "Block = %llu, count = %lu", | 412 | "Block = %llu, count = %lu", |
425 | block, count); | 413 | block, count); |
426 | goto error_return; | 414 | goto error_return; |
@@ -453,8 +441,7 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | |||
453 | BUFFER_TRACE(bitmap_bh, "clear bit"); | 441 | BUFFER_TRACE(bitmap_bh, "clear bit"); |
454 | if (!ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), | 442 | if (!ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), |
455 | bit + i, bitmap_bh->b_data)) { | 443 | bit + i, bitmap_bh->b_data)) { |
456 | ext4_error(sb, __func__, | 444 | ext4_error(sb, "bit already cleared for block %llu", |
457 | "bit already cleared for block %llu", | ||
458 | (ext4_fsblk_t)(block + i)); | 445 | (ext4_fsblk_t)(block + i)); |
459 | BUFFER_TRACE(bitmap_bh, "bit already cleared"); | 446 | BUFFER_TRACE(bitmap_bh, "bit already cleared"); |
460 | } else { | 447 | } else { |
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index a60ab9aad57d..983f0e127493 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c | |||
@@ -205,14 +205,14 @@ void ext4_release_system_zone(struct super_block *sb) | |||
205 | entry = rb_entry(n, struct ext4_system_zone, node); | 205 | entry = rb_entry(n, struct ext4_system_zone, node); |
206 | kmem_cache_free(ext4_system_zone_cachep, entry); | 206 | kmem_cache_free(ext4_system_zone_cachep, entry); |
207 | if (!parent) | 207 | if (!parent) |
208 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 208 | EXT4_SB(sb)->system_blks = RB_ROOT; |
209 | else if (parent->rb_left == n) | 209 | else if (parent->rb_left == n) |
210 | parent->rb_left = NULL; | 210 | parent->rb_left = NULL; |
211 | else if (parent->rb_right == n) | 211 | else if (parent->rb_right == n) |
212 | parent->rb_right = NULL; | 212 | parent->rb_right = NULL; |
213 | n = parent; | 213 | n = parent; |
214 | } | 214 | } |
215 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 215 | EXT4_SB(sb)->system_blks = RB_ROOT; |
216 | } | 216 | } |
217 | 217 | ||
218 | /* | 218 | /* |
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 9dc93168e262..86cb6d86a048 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c | |||
@@ -83,10 +83,12 @@ int ext4_check_dir_entry(const char *function, struct inode *dir, | |||
83 | error_msg = "inode out of bounds"; | 83 | error_msg = "inode out of bounds"; |
84 | 84 | ||
85 | if (error_msg != NULL) | 85 | if (error_msg != NULL) |
86 | ext4_error(dir->i_sb, function, | 86 | __ext4_error(dir->i_sb, function, |
87 | "bad entry in directory #%lu: %s - " | 87 | "bad entry in directory #%lu: %s - block=%llu" |
88 | "offset=%u, inode=%u, rec_len=%d, name_len=%d", | 88 | "offset=%u(%u), inode=%u, rec_len=%d, name_len=%d", |
89 | dir->i_ino, error_msg, offset, | 89 | dir->i_ino, error_msg, |
90 | (unsigned long long) bh->b_blocknr, | ||
91 | (unsigned) (offset%bh->b_size), offset, | ||
90 | le32_to_cpu(de->inode), | 92 | le32_to_cpu(de->inode), |
91 | rlen, de->name_len); | 93 | rlen, de->name_len); |
92 | return error_msg == NULL ? 1 : 0; | 94 | return error_msg == NULL ? 1 : 0; |
@@ -150,7 +152,7 @@ static int ext4_readdir(struct file *filp, | |||
150 | */ | 152 | */ |
151 | if (!bh) { | 153 | if (!bh) { |
152 | if (!dir_has_error) { | 154 | if (!dir_has_error) { |
153 | ext4_error(sb, __func__, "directory #%lu " | 155 | ext4_error(sb, "directory #%lu " |
154 | "contains a hole at offset %Lu", | 156 | "contains a hole at offset %Lu", |
155 | inode->i_ino, | 157 | inode->i_ino, |
156 | (unsigned long long) filp->f_pos); | 158 | (unsigned long long) filp->f_pos); |
@@ -303,7 +305,7 @@ static void free_rb_tree_fname(struct rb_root *root) | |||
303 | kfree(old); | 305 | kfree(old); |
304 | } | 306 | } |
305 | if (!parent) | 307 | if (!parent) |
306 | root->rb_node = NULL; | 308 | *root = RB_ROOT; |
307 | else if (parent->rb_left == n) | 309 | else if (parent->rb_left == n) |
308 | parent->rb_left = NULL; | 310 | parent->rb_left = NULL; |
309 | else if (parent->rb_right == n) | 311 | else if (parent->rb_right == n) |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 874d169a193e..bf938cf7c5f0 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -53,6 +53,12 @@ | |||
53 | #define ext4_debug(f, a...) do {} while (0) | 53 | #define ext4_debug(f, a...) do {} while (0) |
54 | #endif | 54 | #endif |
55 | 55 | ||
56 | #define EXT4_ERROR_INODE(inode, fmt, a...) \ | ||
57 | ext4_error_inode(__func__, (inode), (fmt), ## a); | ||
58 | |||
59 | #define EXT4_ERROR_FILE(file, fmt, a...) \ | ||
60 | ext4_error_file(__func__, (file), (fmt), ## a); | ||
61 | |||
56 | /* data type for block offset of block group */ | 62 | /* data type for block offset of block group */ |
57 | typedef int ext4_grpblk_t; | 63 | typedef int ext4_grpblk_t; |
58 | 64 | ||
@@ -133,14 +139,14 @@ struct mpage_da_data { | |||
133 | int pages_written; | 139 | int pages_written; |
134 | int retval; | 140 | int retval; |
135 | }; | 141 | }; |
136 | #define DIO_AIO_UNWRITTEN 0x1 | 142 | #define EXT4_IO_UNWRITTEN 0x1 |
137 | typedef struct ext4_io_end { | 143 | typedef struct ext4_io_end { |
138 | struct list_head list; /* per-file finished AIO list */ | 144 | struct list_head list; /* per-file finished AIO list */ |
139 | struct inode *inode; /* file being written to */ | 145 | struct inode *inode; /* file being written to */ |
140 | unsigned int flag; /* unwritten or not */ | 146 | unsigned int flag; /* unwritten or not */ |
141 | int error; /* I/O error code */ | 147 | struct page *page; /* page struct for buffer write */ |
142 | ext4_lblk_t offset; /* offset in the file */ | 148 | loff_t offset; /* offset in the file */ |
143 | size_t size; /* size of the extent */ | 149 | ssize_t size; /* size of the extent */ |
144 | struct work_struct work; /* data work queue */ | 150 | struct work_struct work; /* data work queue */ |
145 | } ext4_io_end_t; | 151 | } ext4_io_end_t; |
146 | 152 | ||
@@ -284,10 +290,12 @@ struct flex_groups { | |||
284 | #define EXT4_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/ | 290 | #define EXT4_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/ |
285 | #define EXT4_HUGE_FILE_FL 0x00040000 /* Set to each huge file */ | 291 | #define EXT4_HUGE_FILE_FL 0x00040000 /* Set to each huge file */ |
286 | #define EXT4_EXTENTS_FL 0x00080000 /* Inode uses extents */ | 292 | #define EXT4_EXTENTS_FL 0x00080000 /* Inode uses extents */ |
293 | #define EXT4_EA_INODE_FL 0x00200000 /* Inode used for large EA */ | ||
294 | #define EXT4_EOFBLOCKS_FL 0x00400000 /* Blocks allocated beyond EOF */ | ||
287 | #define EXT4_RESERVED_FL 0x80000000 /* reserved for ext4 lib */ | 295 | #define EXT4_RESERVED_FL 0x80000000 /* reserved for ext4 lib */ |
288 | 296 | ||
289 | #define EXT4_FL_USER_VISIBLE 0x000BDFFF /* User visible flags */ | 297 | #define EXT4_FL_USER_VISIBLE 0x004BDFFF /* User visible flags */ |
290 | #define EXT4_FL_USER_MODIFIABLE 0x000B80FF /* User modifiable flags */ | 298 | #define EXT4_FL_USER_MODIFIABLE 0x004B80FF /* User modifiable flags */ |
291 | 299 | ||
292 | /* Flags that should be inherited by new inodes from their parent. */ | 300 | /* Flags that should be inherited by new inodes from their parent. */ |
293 | #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\ | 301 | #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\ |
@@ -313,17 +321,6 @@ static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags) | |||
313 | return flags & EXT4_OTHER_FLMASK; | 321 | return flags & EXT4_OTHER_FLMASK; |
314 | } | 322 | } |
315 | 323 | ||
316 | /* | ||
317 | * Inode dynamic state flags | ||
318 | */ | ||
319 | #define EXT4_STATE_JDATA 0x00000001 /* journaled data exists */ | ||
320 | #define EXT4_STATE_NEW 0x00000002 /* inode is newly created */ | ||
321 | #define EXT4_STATE_XATTR 0x00000004 /* has in-inode xattrs */ | ||
322 | #define EXT4_STATE_NO_EXPAND 0x00000008 /* No space for expansion */ | ||
323 | #define EXT4_STATE_DA_ALLOC_CLOSE 0x00000010 /* Alloc DA blks on close */ | ||
324 | #define EXT4_STATE_EXT_MIGRATE 0x00000020 /* Inode is migrating */ | ||
325 | #define EXT4_STATE_DIO_UNWRITTEN 0x00000040 /* need convert on dio done*/ | ||
326 | |||
327 | /* Used to pass group descriptor data when online resize is done */ | 324 | /* Used to pass group descriptor data when online resize is done */ |
328 | struct ext4_new_group_input { | 325 | struct ext4_new_group_input { |
329 | __u32 group; /* Group number for this data */ | 326 | __u32 group; /* Group number for this data */ |
@@ -364,19 +361,20 @@ struct ext4_new_group_data { | |||
364 | /* caller is from the direct IO path, request to creation of an | 361 | /* caller is from the direct IO path, request to creation of an |
365 | unitialized extents if not allocated, split the uninitialized | 362 | unitialized extents if not allocated, split the uninitialized |
366 | extent if blocks has been preallocated already*/ | 363 | extent if blocks has been preallocated already*/ |
367 | #define EXT4_GET_BLOCKS_DIO 0x0008 | 364 | #define EXT4_GET_BLOCKS_PRE_IO 0x0008 |
368 | #define EXT4_GET_BLOCKS_CONVERT 0x0010 | 365 | #define EXT4_GET_BLOCKS_CONVERT 0x0010 |
369 | #define EXT4_GET_BLOCKS_DIO_CREATE_EXT (EXT4_GET_BLOCKS_DIO|\ | 366 | #define EXT4_GET_BLOCKS_IO_CREATE_EXT (EXT4_GET_BLOCKS_PRE_IO|\ |
367 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) | ||
368 | /* Convert extent to initialized after IO complete */ | ||
369 | #define EXT4_GET_BLOCKS_IO_CONVERT_EXT (EXT4_GET_BLOCKS_CONVERT|\ | ||
370 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) | 370 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) |
371 | /* Convert extent to initialized after direct IO complete */ | ||
372 | #define EXT4_GET_BLOCKS_DIO_CONVERT_EXT (EXT4_GET_BLOCKS_CONVERT|\ | ||
373 | EXT4_GET_BLOCKS_DIO_CREATE_EXT) | ||
374 | 371 | ||
375 | /* | 372 | /* |
376 | * Flags used by ext4_free_blocks | 373 | * Flags used by ext4_free_blocks |
377 | */ | 374 | */ |
378 | #define EXT4_FREE_BLOCKS_METADATA 0x0001 | 375 | #define EXT4_FREE_BLOCKS_METADATA 0x0001 |
379 | #define EXT4_FREE_BLOCKS_FORGET 0x0002 | 376 | #define EXT4_FREE_BLOCKS_FORGET 0x0002 |
377 | #define EXT4_FREE_BLOCKS_VALIDATED 0x0004 | ||
380 | 378 | ||
381 | /* | 379 | /* |
382 | * ioctl commands | 380 | * ioctl commands |
@@ -630,7 +628,7 @@ struct ext4_inode_info { | |||
630 | * near to their parent directory's inode. | 628 | * near to their parent directory's inode. |
631 | */ | 629 | */ |
632 | ext4_group_t i_block_group; | 630 | ext4_group_t i_block_group; |
633 | __u32 i_state; /* Dynamic state flags for ext4 */ | 631 | unsigned long i_state_flags; /* Dynamic state flags */ |
634 | 632 | ||
635 | ext4_lblk_t i_dir_start_lookup; | 633 | ext4_lblk_t i_dir_start_lookup; |
636 | #ifdef CONFIG_EXT4_FS_XATTR | 634 | #ifdef CONFIG_EXT4_FS_XATTR |
@@ -708,8 +706,9 @@ struct ext4_inode_info { | |||
708 | qsize_t i_reserved_quota; | 706 | qsize_t i_reserved_quota; |
709 | #endif | 707 | #endif |
710 | 708 | ||
711 | /* completed async DIOs that might need unwritten extents handling */ | 709 | /* completed IOs that might need unwritten extents handling */ |
712 | struct list_head i_aio_dio_complete_list; | 710 | struct list_head i_completed_io_list; |
711 | spinlock_t i_completed_io_lock; | ||
713 | /* current io_end structure for async DIO write*/ | 712 | /* current io_end structure for async DIO write*/ |
714 | ext4_io_end_t *cur_aio_dio; | 713 | ext4_io_end_t *cur_aio_dio; |
715 | 714 | ||
@@ -760,6 +759,7 @@ struct ext4_inode_info { | |||
760 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ | 759 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ |
761 | #define EXT4_MOUNT_USRQUOTA 0x100000 /* "old" user quota */ | 760 | #define EXT4_MOUNT_USRQUOTA 0x100000 /* "old" user quota */ |
762 | #define EXT4_MOUNT_GRPQUOTA 0x200000 /* "old" group quota */ | 761 | #define EXT4_MOUNT_GRPQUOTA 0x200000 /* "old" group quota */ |
762 | #define EXT4_MOUNT_DIOREAD_NOLOCK 0x400000 /* Enable support for dio read nolocking */ | ||
763 | #define EXT4_MOUNT_JOURNAL_CHECKSUM 0x800000 /* Journal checksums */ | 763 | #define EXT4_MOUNT_JOURNAL_CHECKSUM 0x800000 /* Journal checksums */ |
764 | #define EXT4_MOUNT_JOURNAL_ASYNC_COMMIT 0x1000000 /* Journal Async Commit */ | 764 | #define EXT4_MOUNT_JOURNAL_ASYNC_COMMIT 0x1000000 /* Journal Async Commit */ |
765 | #define EXT4_MOUNT_I_VERSION 0x2000000 /* i_version support */ | 765 | #define EXT4_MOUNT_I_VERSION 0x2000000 /* i_version support */ |
@@ -1014,7 +1014,7 @@ struct ext4_sb_info { | |||
1014 | atomic_t s_lock_busy; | 1014 | atomic_t s_lock_busy; |
1015 | 1015 | ||
1016 | /* locality groups */ | 1016 | /* locality groups */ |
1017 | struct ext4_locality_group *s_locality_groups; | 1017 | struct ext4_locality_group __percpu *s_locality_groups; |
1018 | 1018 | ||
1019 | /* for write statistics */ | 1019 | /* for write statistics */ |
1020 | unsigned long s_sectors_written_start; | 1020 | unsigned long s_sectors_written_start; |
@@ -1050,6 +1050,34 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) | |||
1050 | (ino >= EXT4_FIRST_INO(sb) && | 1050 | (ino >= EXT4_FIRST_INO(sb) && |
1051 | ino <= le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count)); | 1051 | ino <= le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count)); |
1052 | } | 1052 | } |
1053 | |||
1054 | /* | ||
1055 | * Inode dynamic state flags | ||
1056 | */ | ||
1057 | enum { | ||
1058 | EXT4_STATE_JDATA, /* journaled data exists */ | ||
1059 | EXT4_STATE_NEW, /* inode is newly created */ | ||
1060 | EXT4_STATE_XATTR, /* has in-inode xattrs */ | ||
1061 | EXT4_STATE_NO_EXPAND, /* No space for expansion */ | ||
1062 | EXT4_STATE_DA_ALLOC_CLOSE, /* Alloc DA blks on close */ | ||
1063 | EXT4_STATE_EXT_MIGRATE, /* Inode is migrating */ | ||
1064 | EXT4_STATE_DIO_UNWRITTEN, /* need convert on dio done*/ | ||
1065 | }; | ||
1066 | |||
1067 | static inline int ext4_test_inode_state(struct inode *inode, int bit) | ||
1068 | { | ||
1069 | return test_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1070 | } | ||
1071 | |||
1072 | static inline void ext4_set_inode_state(struct inode *inode, int bit) | ||
1073 | { | ||
1074 | set_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1075 | } | ||
1076 | |||
1077 | static inline void ext4_clear_inode_state(struct inode *inode, int bit) | ||
1078 | { | ||
1079 | clear_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1080 | } | ||
1053 | #else | 1081 | #else |
1054 | /* Assume that user mode programs are passing in an ext4fs superblock, not | 1082 | /* Assume that user mode programs are passing in an ext4fs superblock, not |
1055 | * a kernel struct super_block. This will allow us to call the feature-test | 1083 | * a kernel struct super_block. This will allow us to call the feature-test |
@@ -1126,6 +1154,8 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) | |||
1126 | #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 | 1154 | #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 |
1127 | #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 | 1155 | #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 |
1128 | #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 | 1156 | #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 |
1157 | #define EXT4_FEATURE_INCOMPAT_EA_INODE 0x0400 /* EA in inode */ | ||
1158 | #define EXT4_FEATURE_INCOMPAT_DIRDATA 0x1000 /* data in dirent */ | ||
1129 | 1159 | ||
1130 | #define EXT4_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR | 1160 | #define EXT4_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR |
1131 | #define EXT4_FEATURE_INCOMPAT_SUPP (EXT4_FEATURE_INCOMPAT_FILETYPE| \ | 1161 | #define EXT4_FEATURE_INCOMPAT_SUPP (EXT4_FEATURE_INCOMPAT_FILETYPE| \ |
@@ -1416,7 +1446,7 @@ int ext4_get_block(struct inode *inode, sector_t iblock, | |||
1416 | struct buffer_head *bh_result, int create); | 1446 | struct buffer_head *bh_result, int create); |
1417 | 1447 | ||
1418 | extern struct inode *ext4_iget(struct super_block *, unsigned long); | 1448 | extern struct inode *ext4_iget(struct super_block *, unsigned long); |
1419 | extern int ext4_write_inode(struct inode *, int); | 1449 | extern int ext4_write_inode(struct inode *, struct writeback_control *); |
1420 | extern int ext4_setattr(struct dentry *, struct iattr *); | 1450 | extern int ext4_setattr(struct dentry *, struct iattr *); |
1421 | extern int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, | 1451 | extern int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, |
1422 | struct kstat *stat); | 1452 | struct kstat *stat); |
@@ -1439,7 +1469,7 @@ extern int ext4_block_truncate_page(handle_t *handle, | |||
1439 | struct address_space *mapping, loff_t from); | 1469 | struct address_space *mapping, loff_t from); |
1440 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); | 1470 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); |
1441 | extern qsize_t *ext4_get_reserved_space(struct inode *inode); | 1471 | extern qsize_t *ext4_get_reserved_space(struct inode *inode); |
1442 | extern int flush_aio_dio_completed_IO(struct inode *inode); | 1472 | extern int flush_completed_IO(struct inode *inode); |
1443 | extern void ext4_da_update_reserve_space(struct inode *inode, | 1473 | extern void ext4_da_update_reserve_space(struct inode *inode, |
1444 | int used, int quota_claim); | 1474 | int used, int quota_claim); |
1445 | /* ioctl.c */ | 1475 | /* ioctl.c */ |
@@ -1465,13 +1495,20 @@ extern int ext4_group_extend(struct super_block *sb, | |||
1465 | ext4_fsblk_t n_blocks_count); | 1495 | ext4_fsblk_t n_blocks_count); |
1466 | 1496 | ||
1467 | /* super.c */ | 1497 | /* super.c */ |
1468 | extern void ext4_error(struct super_block *, const char *, const char *, ...) | 1498 | extern void __ext4_error(struct super_block *, const char *, const char *, ...) |
1499 | __attribute__ ((format (printf, 3, 4))); | ||
1500 | #define ext4_error(sb, message...) __ext4_error(sb, __func__, ## message) | ||
1501 | extern void ext4_error_inode(const char *, struct inode *, const char *, ...) | ||
1502 | __attribute__ ((format (printf, 3, 4))); | ||
1503 | extern void ext4_error_file(const char *, struct file *, const char *, ...) | ||
1469 | __attribute__ ((format (printf, 3, 4))); | 1504 | __attribute__ ((format (printf, 3, 4))); |
1470 | extern void __ext4_std_error(struct super_block *, const char *, int); | 1505 | extern void __ext4_std_error(struct super_block *, const char *, int); |
1471 | extern void ext4_abort(struct super_block *, const char *, const char *, ...) | 1506 | extern void ext4_abort(struct super_block *, const char *, const char *, ...) |
1472 | __attribute__ ((format (printf, 3, 4))); | 1507 | __attribute__ ((format (printf, 3, 4))); |
1473 | extern void ext4_warning(struct super_block *, const char *, const char *, ...) | 1508 | extern void __ext4_warning(struct super_block *, const char *, |
1509 | const char *, ...) | ||
1474 | __attribute__ ((format (printf, 3, 4))); | 1510 | __attribute__ ((format (printf, 3, 4))); |
1511 | #define ext4_warning(sb, message...) __ext4_warning(sb, __func__, ## message) | ||
1475 | extern void ext4_msg(struct super_block *, const char *, const char *, ...) | 1512 | extern void ext4_msg(struct super_block *, const char *, const char *, ...) |
1476 | __attribute__ ((format (printf, 3, 4))); | 1513 | __attribute__ ((format (printf, 3, 4))); |
1477 | extern void ext4_grp_locked_error(struct super_block *, ext4_group_t, | 1514 | extern void ext4_grp_locked_error(struct super_block *, ext4_group_t, |
@@ -1744,7 +1781,7 @@ extern void ext4_ext_release(struct super_block *); | |||
1744 | extern long ext4_fallocate(struct inode *inode, int mode, loff_t offset, | 1781 | extern long ext4_fallocate(struct inode *inode, int mode, loff_t offset, |
1745 | loff_t len); | 1782 | loff_t len); |
1746 | extern int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | 1783 | extern int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, |
1747 | loff_t len); | 1784 | ssize_t len); |
1748 | extern int ext4_get_blocks(handle_t *handle, struct inode *inode, | 1785 | extern int ext4_get_blocks(handle_t *handle, struct inode *inode, |
1749 | sector_t block, unsigned int max_blocks, | 1786 | sector_t block, unsigned int max_blocks, |
1750 | struct buffer_head *bh, int flags); | 1787 | struct buffer_head *bh, int flags); |
@@ -1756,6 +1793,15 @@ extern int ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1756 | __u64 len, __u64 *moved_len); | 1793 | __u64 len, __u64 *moved_len); |
1757 | 1794 | ||
1758 | 1795 | ||
1796 | /* BH_Uninit flag: blocks are allocated but uninitialized on disk */ | ||
1797 | enum ext4_state_bits { | ||
1798 | BH_Uninit /* blocks are allocated but uninitialized on disk */ | ||
1799 | = BH_JBDPrivateStart, | ||
1800 | }; | ||
1801 | |||
1802 | BUFFER_FNS(Uninit, uninit) | ||
1803 | TAS_BUFFER_FNS(Uninit, uninit) | ||
1804 | |||
1759 | /* | 1805 | /* |
1760 | * Add new method to test wether block and inode bitmaps are properly | 1806 | * Add new method to test wether block and inode bitmaps are properly |
1761 | * initialized. With uninit_bg reading the block from disk is not enough | 1807 | * initialized. With uninit_bg reading the block from disk is not enough |
@@ -1773,6 +1819,8 @@ static inline void set_bitmap_uptodate(struct buffer_head *bh) | |||
1773 | set_bit(BH_BITMAP_UPTODATE, &(bh)->b_state); | 1819 | set_bit(BH_BITMAP_UPTODATE, &(bh)->b_state); |
1774 | } | 1820 | } |
1775 | 1821 | ||
1822 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
1823 | |||
1776 | #endif /* __KERNEL__ */ | 1824 | #endif /* __KERNEL__ */ |
1777 | 1825 | ||
1778 | #endif /* _EXT4_H */ | 1826 | #endif /* _EXT4_H */ |
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c index b57e5c711b6d..53d2764d71ca 100644 --- a/fs/ext4/ext4_jbd2.c +++ b/fs/ext4/ext4_jbd2.c | |||
@@ -125,14 +125,14 @@ int __ext4_handle_dirty_metadata(const char *where, handle_t *handle, | |||
125 | ext4_journal_abort_handle(where, __func__, bh, | 125 | ext4_journal_abort_handle(where, __func__, bh, |
126 | handle, err); | 126 | handle, err); |
127 | } else { | 127 | } else { |
128 | if (inode && bh) | 128 | if (inode) |
129 | mark_buffer_dirty_inode(bh, inode); | 129 | mark_buffer_dirty_inode(bh, inode); |
130 | else | 130 | else |
131 | mark_buffer_dirty(bh); | 131 | mark_buffer_dirty(bh); |
132 | if (inode && inode_needs_sync(inode)) { | 132 | if (inode && inode_needs_sync(inode)) { |
133 | sync_dirty_buffer(bh); | 133 | sync_dirty_buffer(bh); |
134 | if (buffer_req(bh) && !buffer_uptodate(bh)) { | 134 | if (buffer_req(bh) && !buffer_uptodate(bh)) { |
135 | ext4_error(inode->i_sb, __func__, | 135 | ext4_error(inode->i_sb, |
136 | "IO error syncing inode, " | 136 | "IO error syncing inode, " |
137 | "inode=%lu, block=%llu", | 137 | "inode=%lu, block=%llu", |
138 | inode->i_ino, | 138 | inode->i_ino, |
diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h index 05eca817d704..b79ad5126468 100644 --- a/fs/ext4/ext4_jbd2.h +++ b/fs/ext4/ext4_jbd2.h | |||
@@ -304,4 +304,28 @@ static inline int ext4_should_writeback_data(struct inode *inode) | |||
304 | return 0; | 304 | return 0; |
305 | } | 305 | } |
306 | 306 | ||
307 | /* | ||
308 | * This function controls whether or not we should try to go down the | ||
309 | * dioread_nolock code paths, which makes it safe to avoid taking | ||
310 | * i_mutex for direct I/O reads. This only works for extent-based | ||
311 | * files, and it doesn't work for nobh or if data journaling is | ||
312 | * enabled, since the dioread_nolock code uses b_private to pass | ||
313 | * information back to the I/O completion handler, and this conflicts | ||
314 | * with the jbd's use of b_private. | ||
315 | */ | ||
316 | static inline int ext4_should_dioread_nolock(struct inode *inode) | ||
317 | { | ||
318 | if (!test_opt(inode->i_sb, DIOREAD_NOLOCK)) | ||
319 | return 0; | ||
320 | if (test_opt(inode->i_sb, NOBH)) | ||
321 | return 0; | ||
322 | if (!S_ISREG(inode->i_mode)) | ||
323 | return 0; | ||
324 | if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL)) | ||
325 | return 0; | ||
326 | if (ext4_should_journal_data(inode)) | ||
327 | return 0; | ||
328 | return 1; | ||
329 | } | ||
330 | |||
307 | #endif /* _EXT4_JBD2_H */ | 331 | #endif /* _EXT4_JBD2_H */ |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 765a4826b118..94c8ee81f5e1 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
@@ -195,8 +195,7 @@ static ext4_fsblk_t ext4_ext_find_goal(struct inode *inode, | |||
195 | if (S_ISREG(inode->i_mode)) | 195 | if (S_ISREG(inode->i_mode)) |
196 | block_group++; | 196 | block_group++; |
197 | } | 197 | } |
198 | bg_start = (block_group * EXT4_BLOCKS_PER_GROUP(inode->i_sb)) + | 198 | bg_start = ext4_group_first_block_no(inode->i_sb, block_group); |
199 | le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_first_data_block); | ||
200 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; | 199 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; |
201 | 200 | ||
202 | /* | 201 | /* |
@@ -440,7 +439,7 @@ static int __ext4_ext_check(const char *function, struct inode *inode, | |||
440 | return 0; | 439 | return 0; |
441 | 440 | ||
442 | corrupted: | 441 | corrupted: |
443 | ext4_error(inode->i_sb, function, | 442 | __ext4_error(inode->i_sb, function, |
444 | "bad header/extent in inode #%lu: %s - magic %x, " | 443 | "bad header/extent in inode #%lu: %s - magic %x, " |
445 | "entries %u, max %u(%u), depth %u(%u)", | 444 | "entries %u, max %u(%u), depth %u(%u)", |
446 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), | 445 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), |
@@ -703,7 +702,12 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
703 | } | 702 | } |
704 | eh = ext_block_hdr(bh); | 703 | eh = ext_block_hdr(bh); |
705 | ppos++; | 704 | ppos++; |
706 | BUG_ON(ppos > depth); | 705 | if (unlikely(ppos > depth)) { |
706 | put_bh(bh); | ||
707 | EXT4_ERROR_INODE(inode, | ||
708 | "ppos %d > depth %d", ppos, depth); | ||
709 | goto err; | ||
710 | } | ||
707 | path[ppos].p_bh = bh; | 711 | path[ppos].p_bh = bh; |
708 | path[ppos].p_hdr = eh; | 712 | path[ppos].p_hdr = eh; |
709 | i--; | 713 | i--; |
@@ -749,7 +753,12 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode, | |||
749 | if (err) | 753 | if (err) |
750 | return err; | 754 | return err; |
751 | 755 | ||
752 | BUG_ON(logical == le32_to_cpu(curp->p_idx->ei_block)); | 756 | if (unlikely(logical == le32_to_cpu(curp->p_idx->ei_block))) { |
757 | EXT4_ERROR_INODE(inode, | ||
758 | "logical %d == ei_block %d!", | ||
759 | logical, le32_to_cpu(curp->p_idx->ei_block)); | ||
760 | return -EIO; | ||
761 | } | ||
753 | len = EXT_MAX_INDEX(curp->p_hdr) - curp->p_idx; | 762 | len = EXT_MAX_INDEX(curp->p_hdr) - curp->p_idx; |
754 | if (logical > le32_to_cpu(curp->p_idx->ei_block)) { | 763 | if (logical > le32_to_cpu(curp->p_idx->ei_block)) { |
755 | /* insert after */ | 764 | /* insert after */ |
@@ -779,9 +788,17 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode, | |||
779 | ext4_idx_store_pblock(ix, ptr); | 788 | ext4_idx_store_pblock(ix, ptr); |
780 | le16_add_cpu(&curp->p_hdr->eh_entries, 1); | 789 | le16_add_cpu(&curp->p_hdr->eh_entries, 1); |
781 | 790 | ||
782 | BUG_ON(le16_to_cpu(curp->p_hdr->eh_entries) | 791 | if (unlikely(le16_to_cpu(curp->p_hdr->eh_entries) |
783 | > le16_to_cpu(curp->p_hdr->eh_max)); | 792 | > le16_to_cpu(curp->p_hdr->eh_max))) { |
784 | BUG_ON(ix > EXT_LAST_INDEX(curp->p_hdr)); | 793 | EXT4_ERROR_INODE(inode, |
794 | "logical %d == ei_block %d!", | ||
795 | logical, le32_to_cpu(curp->p_idx->ei_block)); | ||
796 | return -EIO; | ||
797 | } | ||
798 | if (unlikely(ix > EXT_LAST_INDEX(curp->p_hdr))) { | ||
799 | EXT4_ERROR_INODE(inode, "ix > EXT_LAST_INDEX!"); | ||
800 | return -EIO; | ||
801 | } | ||
785 | 802 | ||
786 | err = ext4_ext_dirty(handle, inode, curp); | 803 | err = ext4_ext_dirty(handle, inode, curp); |
787 | ext4_std_error(inode->i_sb, err); | 804 | ext4_std_error(inode->i_sb, err); |
@@ -819,7 +836,10 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
819 | 836 | ||
820 | /* if current leaf will be split, then we should use | 837 | /* if current leaf will be split, then we should use |
821 | * border from split point */ | 838 | * border from split point */ |
822 | BUG_ON(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr)); | 839 | if (unlikely(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr))) { |
840 | EXT4_ERROR_INODE(inode, "p_ext > EXT_MAX_EXTENT!"); | ||
841 | return -EIO; | ||
842 | } | ||
823 | if (path[depth].p_ext != EXT_MAX_EXTENT(path[depth].p_hdr)) { | 843 | if (path[depth].p_ext != EXT_MAX_EXTENT(path[depth].p_hdr)) { |
824 | border = path[depth].p_ext[1].ee_block; | 844 | border = path[depth].p_ext[1].ee_block; |
825 | ext_debug("leaf will be split." | 845 | ext_debug("leaf will be split." |
@@ -860,7 +880,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
860 | 880 | ||
861 | /* initialize new leaf */ | 881 | /* initialize new leaf */ |
862 | newblock = ablocks[--a]; | 882 | newblock = ablocks[--a]; |
863 | BUG_ON(newblock == 0); | 883 | if (unlikely(newblock == 0)) { |
884 | EXT4_ERROR_INODE(inode, "newblock == 0!"); | ||
885 | err = -EIO; | ||
886 | goto cleanup; | ||
887 | } | ||
864 | bh = sb_getblk(inode->i_sb, newblock); | 888 | bh = sb_getblk(inode->i_sb, newblock); |
865 | if (!bh) { | 889 | if (!bh) { |
866 | err = -EIO; | 890 | err = -EIO; |
@@ -880,7 +904,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
880 | ex = EXT_FIRST_EXTENT(neh); | 904 | ex = EXT_FIRST_EXTENT(neh); |
881 | 905 | ||
882 | /* move remainder of path[depth] to the new leaf */ | 906 | /* move remainder of path[depth] to the new leaf */ |
883 | BUG_ON(path[depth].p_hdr->eh_entries != path[depth].p_hdr->eh_max); | 907 | if (unlikely(path[depth].p_hdr->eh_entries != |
908 | path[depth].p_hdr->eh_max)) { | ||
909 | EXT4_ERROR_INODE(inode, "eh_entries %d != eh_max %d!", | ||
910 | path[depth].p_hdr->eh_entries, | ||
911 | path[depth].p_hdr->eh_max); | ||
912 | err = -EIO; | ||
913 | goto cleanup; | ||
914 | } | ||
884 | /* start copy from next extent */ | 915 | /* start copy from next extent */ |
885 | /* TODO: we could do it by single memmove */ | 916 | /* TODO: we could do it by single memmove */ |
886 | m = 0; | 917 | m = 0; |
@@ -927,7 +958,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
927 | 958 | ||
928 | /* create intermediate indexes */ | 959 | /* create intermediate indexes */ |
929 | k = depth - at - 1; | 960 | k = depth - at - 1; |
930 | BUG_ON(k < 0); | 961 | if (unlikely(k < 0)) { |
962 | EXT4_ERROR_INODE(inode, "k %d < 0!", k); | ||
963 | err = -EIO; | ||
964 | goto cleanup; | ||
965 | } | ||
931 | if (k) | 966 | if (k) |
932 | ext_debug("create %d intermediate indices\n", k); | 967 | ext_debug("create %d intermediate indices\n", k); |
933 | /* insert new index into current index block */ | 968 | /* insert new index into current index block */ |
@@ -964,8 +999,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
964 | 999 | ||
965 | ext_debug("cur 0x%p, last 0x%p\n", path[i].p_idx, | 1000 | ext_debug("cur 0x%p, last 0x%p\n", path[i].p_idx, |
966 | EXT_MAX_INDEX(path[i].p_hdr)); | 1001 | EXT_MAX_INDEX(path[i].p_hdr)); |
967 | BUG_ON(EXT_MAX_INDEX(path[i].p_hdr) != | 1002 | if (unlikely(EXT_MAX_INDEX(path[i].p_hdr) != |
968 | EXT_LAST_INDEX(path[i].p_hdr)); | 1003 | EXT_LAST_INDEX(path[i].p_hdr))) { |
1004 | EXT4_ERROR_INODE(inode, | ||
1005 | "EXT_MAX_INDEX != EXT_LAST_INDEX ee_block %d!", | ||
1006 | le32_to_cpu(path[i].p_ext->ee_block)); | ||
1007 | err = -EIO; | ||
1008 | goto cleanup; | ||
1009 | } | ||
969 | while (path[i].p_idx <= EXT_MAX_INDEX(path[i].p_hdr)) { | 1010 | while (path[i].p_idx <= EXT_MAX_INDEX(path[i].p_hdr)) { |
970 | ext_debug("%d: move %d:%llu in new index %llu\n", i, | 1011 | ext_debug("%d: move %d:%llu in new index %llu\n", i, |
971 | le32_to_cpu(path[i].p_idx->ei_block), | 1012 | le32_to_cpu(path[i].p_idx->ei_block), |
@@ -1203,7 +1244,10 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path, | |||
1203 | struct ext4_extent *ex; | 1244 | struct ext4_extent *ex; |
1204 | int depth, ee_len; | 1245 | int depth, ee_len; |
1205 | 1246 | ||
1206 | BUG_ON(path == NULL); | 1247 | if (unlikely(path == NULL)) { |
1248 | EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical); | ||
1249 | return -EIO; | ||
1250 | } | ||
1207 | depth = path->p_depth; | 1251 | depth = path->p_depth; |
1208 | *phys = 0; | 1252 | *phys = 0; |
1209 | 1253 | ||
@@ -1217,15 +1261,33 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path, | |||
1217 | ex = path[depth].p_ext; | 1261 | ex = path[depth].p_ext; |
1218 | ee_len = ext4_ext_get_actual_len(ex); | 1262 | ee_len = ext4_ext_get_actual_len(ex); |
1219 | if (*logical < le32_to_cpu(ex->ee_block)) { | 1263 | if (*logical < le32_to_cpu(ex->ee_block)) { |
1220 | BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex); | 1264 | if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) { |
1265 | EXT4_ERROR_INODE(inode, | ||
1266 | "EXT_FIRST_EXTENT != ex *logical %d ee_block %d!", | ||
1267 | *logical, le32_to_cpu(ex->ee_block)); | ||
1268 | return -EIO; | ||
1269 | } | ||
1221 | while (--depth >= 0) { | 1270 | while (--depth >= 0) { |
1222 | ix = path[depth].p_idx; | 1271 | ix = path[depth].p_idx; |
1223 | BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr)); | 1272 | if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) { |
1273 | EXT4_ERROR_INODE(inode, | ||
1274 | "ix (%d) != EXT_FIRST_INDEX (%d) (depth %d)!", | ||
1275 | ix != NULL ? ix->ei_block : 0, | ||
1276 | EXT_FIRST_INDEX(path[depth].p_hdr) != NULL ? | ||
1277 | EXT_FIRST_INDEX(path[depth].p_hdr)->ei_block : 0, | ||
1278 | depth); | ||
1279 | return -EIO; | ||
1280 | } | ||
1224 | } | 1281 | } |
1225 | return 0; | 1282 | return 0; |
1226 | } | 1283 | } |
1227 | 1284 | ||
1228 | BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len)); | 1285 | if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) { |
1286 | EXT4_ERROR_INODE(inode, | ||
1287 | "logical %d < ee_block %d + ee_len %d!", | ||
1288 | *logical, le32_to_cpu(ex->ee_block), ee_len); | ||
1289 | return -EIO; | ||
1290 | } | ||
1229 | 1291 | ||
1230 | *logical = le32_to_cpu(ex->ee_block) + ee_len - 1; | 1292 | *logical = le32_to_cpu(ex->ee_block) + ee_len - 1; |
1231 | *phys = ext_pblock(ex) + ee_len - 1; | 1293 | *phys = ext_pblock(ex) + ee_len - 1; |
@@ -1251,7 +1313,10 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path, | |||
1251 | int depth; /* Note, NOT eh_depth; depth from top of tree */ | 1313 | int depth; /* Note, NOT eh_depth; depth from top of tree */ |
1252 | int ee_len; | 1314 | int ee_len; |
1253 | 1315 | ||
1254 | BUG_ON(path == NULL); | 1316 | if (unlikely(path == NULL)) { |
1317 | EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical); | ||
1318 | return -EIO; | ||
1319 | } | ||
1255 | depth = path->p_depth; | 1320 | depth = path->p_depth; |
1256 | *phys = 0; | 1321 | *phys = 0; |
1257 | 1322 | ||
@@ -1265,17 +1330,32 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path, | |||
1265 | ex = path[depth].p_ext; | 1330 | ex = path[depth].p_ext; |
1266 | ee_len = ext4_ext_get_actual_len(ex); | 1331 | ee_len = ext4_ext_get_actual_len(ex); |
1267 | if (*logical < le32_to_cpu(ex->ee_block)) { | 1332 | if (*logical < le32_to_cpu(ex->ee_block)) { |
1268 | BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex); | 1333 | if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) { |
1334 | EXT4_ERROR_INODE(inode, | ||
1335 | "first_extent(path[%d].p_hdr) != ex", | ||
1336 | depth); | ||
1337 | return -EIO; | ||
1338 | } | ||
1269 | while (--depth >= 0) { | 1339 | while (--depth >= 0) { |
1270 | ix = path[depth].p_idx; | 1340 | ix = path[depth].p_idx; |
1271 | BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr)); | 1341 | if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) { |
1342 | EXT4_ERROR_INODE(inode, | ||
1343 | "ix != EXT_FIRST_INDEX *logical %d!", | ||
1344 | *logical); | ||
1345 | return -EIO; | ||
1346 | } | ||
1272 | } | 1347 | } |
1273 | *logical = le32_to_cpu(ex->ee_block); | 1348 | *logical = le32_to_cpu(ex->ee_block); |
1274 | *phys = ext_pblock(ex); | 1349 | *phys = ext_pblock(ex); |
1275 | return 0; | 1350 | return 0; |
1276 | } | 1351 | } |
1277 | 1352 | ||
1278 | BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len)); | 1353 | if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) { |
1354 | EXT4_ERROR_INODE(inode, | ||
1355 | "logical %d < ee_block %d + ee_len %d!", | ||
1356 | *logical, le32_to_cpu(ex->ee_block), ee_len); | ||
1357 | return -EIO; | ||
1358 | } | ||
1279 | 1359 | ||
1280 | if (ex != EXT_LAST_EXTENT(path[depth].p_hdr)) { | 1360 | if (ex != EXT_LAST_EXTENT(path[depth].p_hdr)) { |
1281 | /* next allocated block in this leaf */ | 1361 | /* next allocated block in this leaf */ |
@@ -1414,8 +1494,12 @@ static int ext4_ext_correct_indexes(handle_t *handle, struct inode *inode, | |||
1414 | 1494 | ||
1415 | eh = path[depth].p_hdr; | 1495 | eh = path[depth].p_hdr; |
1416 | ex = path[depth].p_ext; | 1496 | ex = path[depth].p_ext; |
1417 | BUG_ON(ex == NULL); | 1497 | |
1418 | BUG_ON(eh == NULL); | 1498 | if (unlikely(ex == NULL || eh == NULL)) { |
1499 | EXT4_ERROR_INODE(inode, | ||
1500 | "ex %p == NULL or eh %p == NULL", ex, eh); | ||
1501 | return -EIO; | ||
1502 | } | ||
1419 | 1503 | ||
1420 | if (depth == 0) { | 1504 | if (depth == 0) { |
1421 | /* there is no tree at all */ | 1505 | /* there is no tree at all */ |
@@ -1538,8 +1622,9 @@ int ext4_ext_try_to_merge(struct inode *inode, | |||
1538 | merge_done = 1; | 1622 | merge_done = 1; |
1539 | WARN_ON(eh->eh_entries == 0); | 1623 | WARN_ON(eh->eh_entries == 0); |
1540 | if (!eh->eh_entries) | 1624 | if (!eh->eh_entries) |
1541 | ext4_error(inode->i_sb, "ext4_ext_try_to_merge", | 1625 | ext4_error(inode->i_sb, |
1542 | "inode#%lu, eh->eh_entries = 0!", inode->i_ino); | 1626 | "inode#%lu, eh->eh_entries = 0!", |
1627 | inode->i_ino); | ||
1543 | } | 1628 | } |
1544 | 1629 | ||
1545 | return merge_done; | 1630 | return merge_done; |
@@ -1612,13 +1697,19 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, | |||
1612 | ext4_lblk_t next; | 1697 | ext4_lblk_t next; |
1613 | unsigned uninitialized = 0; | 1698 | unsigned uninitialized = 0; |
1614 | 1699 | ||
1615 | BUG_ON(ext4_ext_get_actual_len(newext) == 0); | 1700 | if (unlikely(ext4_ext_get_actual_len(newext) == 0)) { |
1701 | EXT4_ERROR_INODE(inode, "ext4_ext_get_actual_len(newext) == 0"); | ||
1702 | return -EIO; | ||
1703 | } | ||
1616 | depth = ext_depth(inode); | 1704 | depth = ext_depth(inode); |
1617 | ex = path[depth].p_ext; | 1705 | ex = path[depth].p_ext; |
1618 | BUG_ON(path[depth].p_hdr == NULL); | 1706 | if (unlikely(path[depth].p_hdr == NULL)) { |
1707 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | ||
1708 | return -EIO; | ||
1709 | } | ||
1619 | 1710 | ||
1620 | /* try to insert block into found extent and return */ | 1711 | /* try to insert block into found extent and return */ |
1621 | if (ex && (flag != EXT4_GET_BLOCKS_DIO_CREATE_EXT) | 1712 | if (ex && !(flag & EXT4_GET_BLOCKS_PRE_IO) |
1622 | && ext4_can_extents_be_merged(inode, ex, newext)) { | 1713 | && ext4_can_extents_be_merged(inode, ex, newext)) { |
1623 | ext_debug("append [%d]%d block to %d:[%d]%d (from %llu)\n", | 1714 | ext_debug("append [%d]%d block to %d:[%d]%d (from %llu)\n", |
1624 | ext4_ext_is_uninitialized(newext), | 1715 | ext4_ext_is_uninitialized(newext), |
@@ -1739,7 +1830,7 @@ has_space: | |||
1739 | 1830 | ||
1740 | merge: | 1831 | merge: |
1741 | /* try to merge extents to the right */ | 1832 | /* try to merge extents to the right */ |
1742 | if (flag != EXT4_GET_BLOCKS_DIO_CREATE_EXT) | 1833 | if (!(flag & EXT4_GET_BLOCKS_PRE_IO)) |
1743 | ext4_ext_try_to_merge(inode, path, nearex); | 1834 | ext4_ext_try_to_merge(inode, path, nearex); |
1744 | 1835 | ||
1745 | /* try to merge extents to the left */ | 1836 | /* try to merge extents to the left */ |
@@ -1787,7 +1878,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block, | |||
1787 | } | 1878 | } |
1788 | 1879 | ||
1789 | depth = ext_depth(inode); | 1880 | depth = ext_depth(inode); |
1790 | BUG_ON(path[depth].p_hdr == NULL); | 1881 | if (unlikely(path[depth].p_hdr == NULL)) { |
1882 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | ||
1883 | err = -EIO; | ||
1884 | break; | ||
1885 | } | ||
1791 | ex = path[depth].p_ext; | 1886 | ex = path[depth].p_ext; |
1792 | next = ext4_ext_next_allocated_block(path); | 1887 | next = ext4_ext_next_allocated_block(path); |
1793 | 1888 | ||
@@ -1838,7 +1933,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block, | |||
1838 | cbex.ec_type = EXT4_EXT_CACHE_EXTENT; | 1933 | cbex.ec_type = EXT4_EXT_CACHE_EXTENT; |
1839 | } | 1934 | } |
1840 | 1935 | ||
1841 | BUG_ON(cbex.ec_len == 0); | 1936 | if (unlikely(cbex.ec_len == 0)) { |
1937 | EXT4_ERROR_INODE(inode, "cbex.ec_len == 0"); | ||
1938 | err = -EIO; | ||
1939 | break; | ||
1940 | } | ||
1842 | err = func(inode, path, &cbex, ex, cbdata); | 1941 | err = func(inode, path, &cbex, ex, cbdata); |
1843 | ext4_ext_drop_refs(path); | 1942 | ext4_ext_drop_refs(path); |
1844 | 1943 | ||
@@ -1952,7 +2051,7 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block, | |||
1952 | 2051 | ||
1953 | BUG_ON(cex->ec_type != EXT4_EXT_CACHE_GAP && | 2052 | BUG_ON(cex->ec_type != EXT4_EXT_CACHE_GAP && |
1954 | cex->ec_type != EXT4_EXT_CACHE_EXTENT); | 2053 | cex->ec_type != EXT4_EXT_CACHE_EXTENT); |
1955 | if (block >= cex->ec_block && block < cex->ec_block + cex->ec_len) { | 2054 | if (in_range(block, cex->ec_block, cex->ec_len)) { |
1956 | ex->ee_block = cpu_to_le32(cex->ec_block); | 2055 | ex->ee_block = cpu_to_le32(cex->ec_block); |
1957 | ext4_ext_store_pblock(ex, cex->ec_start); | 2056 | ext4_ext_store_pblock(ex, cex->ec_start); |
1958 | ex->ee_len = cpu_to_le16(cex->ec_len); | 2057 | ex->ee_len = cpu_to_le16(cex->ec_len); |
@@ -1981,7 +2080,10 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode, | |||
1981 | /* free index block */ | 2080 | /* free index block */ |
1982 | path--; | 2081 | path--; |
1983 | leaf = idx_pblock(path->p_idx); | 2082 | leaf = idx_pblock(path->p_idx); |
1984 | BUG_ON(path->p_hdr->eh_entries == 0); | 2083 | if (unlikely(path->p_hdr->eh_entries == 0)) { |
2084 | EXT4_ERROR_INODE(inode, "path->p_hdr->eh_entries == 0"); | ||
2085 | return -EIO; | ||
2086 | } | ||
1985 | err = ext4_ext_get_access(handle, inode, path); | 2087 | err = ext4_ext_get_access(handle, inode, path); |
1986 | if (err) | 2088 | if (err) |
1987 | return err; | 2089 | return err; |
@@ -2119,8 +2221,10 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode, | |||
2119 | if (!path[depth].p_hdr) | 2221 | if (!path[depth].p_hdr) |
2120 | path[depth].p_hdr = ext_block_hdr(path[depth].p_bh); | 2222 | path[depth].p_hdr = ext_block_hdr(path[depth].p_bh); |
2121 | eh = path[depth].p_hdr; | 2223 | eh = path[depth].p_hdr; |
2122 | BUG_ON(eh == NULL); | 2224 | if (unlikely(path[depth].p_hdr == NULL)) { |
2123 | 2225 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | |
2226 | return -EIO; | ||
2227 | } | ||
2124 | /* find where to start removing */ | 2228 | /* find where to start removing */ |
2125 | ex = EXT_LAST_EXTENT(eh); | 2229 | ex = EXT_LAST_EXTENT(eh); |
2126 | 2230 | ||
@@ -2983,7 +3087,7 @@ fix_extent_len: | |||
2983 | ext4_ext_dirty(handle, inode, path + depth); | 3087 | ext4_ext_dirty(handle, inode, path + depth); |
2984 | return err; | 3088 | return err; |
2985 | } | 3089 | } |
2986 | static int ext4_convert_unwritten_extents_dio(handle_t *handle, | 3090 | static int ext4_convert_unwritten_extents_endio(handle_t *handle, |
2987 | struct inode *inode, | 3091 | struct inode *inode, |
2988 | struct ext4_ext_path *path) | 3092 | struct ext4_ext_path *path) |
2989 | { | 3093 | { |
@@ -3063,8 +3167,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
3063 | flags, allocated); | 3167 | flags, allocated); |
3064 | ext4_ext_show_leaf(inode, path); | 3168 | ext4_ext_show_leaf(inode, path); |
3065 | 3169 | ||
3066 | /* DIO get_block() before submit the IO, split the extent */ | 3170 | /* get_block() before submit the IO, split the extent */ |
3067 | if (flags == EXT4_GET_BLOCKS_DIO_CREATE_EXT) { | 3171 | if ((flags & EXT4_GET_BLOCKS_PRE_IO)) { |
3068 | ret = ext4_split_unwritten_extents(handle, | 3172 | ret = ext4_split_unwritten_extents(handle, |
3069 | inode, path, iblock, | 3173 | inode, path, iblock, |
3070 | max_blocks, flags); | 3174 | max_blocks, flags); |
@@ -3074,14 +3178,16 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
3074 | * completed | 3178 | * completed |
3075 | */ | 3179 | */ |
3076 | if (io) | 3180 | if (io) |
3077 | io->flag = DIO_AIO_UNWRITTEN; | 3181 | io->flag = EXT4_IO_UNWRITTEN; |
3078 | else | 3182 | else |
3079 | EXT4_I(inode)->i_state |= EXT4_STATE_DIO_UNWRITTEN; | 3183 | ext4_set_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN); |
3184 | if (ext4_should_dioread_nolock(inode)) | ||
3185 | set_buffer_uninit(bh_result); | ||
3080 | goto out; | 3186 | goto out; |
3081 | } | 3187 | } |
3082 | /* async DIO end_io complete, convert the filled extent to written */ | 3188 | /* IO end_io complete, convert the filled extent to written */ |
3083 | if (flags == EXT4_GET_BLOCKS_DIO_CONVERT_EXT) { | 3189 | if ((flags & EXT4_GET_BLOCKS_CONVERT)) { |
3084 | ret = ext4_convert_unwritten_extents_dio(handle, inode, | 3190 | ret = ext4_convert_unwritten_extents_endio(handle, inode, |
3085 | path); | 3191 | path); |
3086 | if (ret >= 0) | 3192 | if (ret >= 0) |
3087 | ext4_update_inode_fsync_trans(handle, inode, 1); | 3193 | ext4_update_inode_fsync_trans(handle, inode, 1); |
@@ -3185,7 +3291,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3185 | { | 3291 | { |
3186 | struct ext4_ext_path *path = NULL; | 3292 | struct ext4_ext_path *path = NULL; |
3187 | struct ext4_extent_header *eh; | 3293 | struct ext4_extent_header *eh; |
3188 | struct ext4_extent newex, *ex; | 3294 | struct ext4_extent newex, *ex, *last_ex; |
3189 | ext4_fsblk_t newblock; | 3295 | ext4_fsblk_t newblock; |
3190 | int err = 0, depth, ret, cache_type; | 3296 | int err = 0, depth, ret, cache_type; |
3191 | unsigned int allocated = 0; | 3297 | unsigned int allocated = 0; |
@@ -3237,10 +3343,10 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3237 | * this situation is possible, though, _during_ tree modification; | 3343 | * this situation is possible, though, _during_ tree modification; |
3238 | * this is why assert can't be put in ext4_ext_find_extent() | 3344 | * this is why assert can't be put in ext4_ext_find_extent() |
3239 | */ | 3345 | */ |
3240 | if (path[depth].p_ext == NULL && depth != 0) { | 3346 | if (unlikely(path[depth].p_ext == NULL && depth != 0)) { |
3241 | ext4_error(inode->i_sb, __func__, "bad extent address " | 3347 | EXT4_ERROR_INODE(inode, "bad extent address " |
3242 | "inode: %lu, iblock: %d, depth: %d", | 3348 | "iblock: %d, depth: %d pblock %lld", |
3243 | inode->i_ino, iblock, depth); | 3349 | iblock, depth, path[depth].p_block); |
3244 | err = -EIO; | 3350 | err = -EIO; |
3245 | goto out2; | 3351 | goto out2; |
3246 | } | 3352 | } |
@@ -3258,7 +3364,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3258 | */ | 3364 | */ |
3259 | ee_len = ext4_ext_get_actual_len(ex); | 3365 | ee_len = ext4_ext_get_actual_len(ex); |
3260 | /* if found extent covers block, simply return it */ | 3366 | /* if found extent covers block, simply return it */ |
3261 | if (iblock >= ee_block && iblock < ee_block + ee_len) { | 3367 | if (in_range(iblock, ee_block, ee_len)) { |
3262 | newblock = iblock - ee_block + ee_start; | 3368 | newblock = iblock - ee_block + ee_start; |
3263 | /* number of remaining blocks in the extent */ | 3369 | /* number of remaining blocks in the extent */ |
3264 | allocated = ee_len - (iblock - ee_block); | 3370 | allocated = ee_len - (iblock - ee_block); |
@@ -3350,21 +3456,35 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3350 | if (flags & EXT4_GET_BLOCKS_UNINIT_EXT){ | 3456 | if (flags & EXT4_GET_BLOCKS_UNINIT_EXT){ |
3351 | ext4_ext_mark_uninitialized(&newex); | 3457 | ext4_ext_mark_uninitialized(&newex); |
3352 | /* | 3458 | /* |
3353 | * io_end structure was created for every async | 3459 | * io_end structure was created for every IO write to an |
3354 | * direct IO write to the middle of the file. | 3460 | * uninitialized extent. To avoid unecessary conversion, |
3355 | * To avoid unecessary convertion for every aio dio rewrite | 3461 | * here we flag the IO that really needs the conversion. |
3356 | * to the mid of file, here we flag the IO that is really | ||
3357 | * need the convertion. | ||
3358 | * For non asycn direct IO case, flag the inode state | 3462 | * For non asycn direct IO case, flag the inode state |
3359 | * that we need to perform convertion when IO is done. | 3463 | * that we need to perform convertion when IO is done. |
3360 | */ | 3464 | */ |
3361 | if (flags == EXT4_GET_BLOCKS_DIO_CREATE_EXT) { | 3465 | if ((flags & EXT4_GET_BLOCKS_PRE_IO)) { |
3362 | if (io) | 3466 | if (io) |
3363 | io->flag = DIO_AIO_UNWRITTEN; | 3467 | io->flag = EXT4_IO_UNWRITTEN; |
3364 | else | 3468 | else |
3365 | EXT4_I(inode)->i_state |= | 3469 | ext4_set_inode_state(inode, |
3366 | EXT4_STATE_DIO_UNWRITTEN;; | 3470 | EXT4_STATE_DIO_UNWRITTEN); |
3471 | } | ||
3472 | if (ext4_should_dioread_nolock(inode)) | ||
3473 | set_buffer_uninit(bh_result); | ||
3474 | } | ||
3475 | |||
3476 | if (unlikely(EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL)) { | ||
3477 | if (unlikely(!eh->eh_entries)) { | ||
3478 | EXT4_ERROR_INODE(inode, | ||
3479 | "eh->eh_entries == 0 ee_block %d", | ||
3480 | ex->ee_block); | ||
3481 | err = -EIO; | ||
3482 | goto out2; | ||
3367 | } | 3483 | } |
3484 | last_ex = EXT_LAST_EXTENT(eh); | ||
3485 | if (iblock + ar.len > le32_to_cpu(last_ex->ee_block) | ||
3486 | + ext4_ext_get_actual_len(last_ex)) | ||
3487 | EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL; | ||
3368 | } | 3488 | } |
3369 | err = ext4_ext_insert_extent(handle, inode, path, &newex, flags); | 3489 | err = ext4_ext_insert_extent(handle, inode, path, &newex, flags); |
3370 | if (err) { | 3490 | if (err) { |
@@ -3499,6 +3619,13 @@ static void ext4_falloc_update_inode(struct inode *inode, | |||
3499 | i_size_write(inode, new_size); | 3619 | i_size_write(inode, new_size); |
3500 | if (new_size > EXT4_I(inode)->i_disksize) | 3620 | if (new_size > EXT4_I(inode)->i_disksize) |
3501 | ext4_update_i_disksize(inode, new_size); | 3621 | ext4_update_i_disksize(inode, new_size); |
3622 | } else { | ||
3623 | /* | ||
3624 | * Mark that we allocate beyond EOF so the subsequent truncate | ||
3625 | * can proceed even if the new size is the same as i_size. | ||
3626 | */ | ||
3627 | if (new_size > i_size_read(inode)) | ||
3628 | EXT4_I(inode)->i_flags |= EXT4_EOFBLOCKS_FL; | ||
3502 | } | 3629 | } |
3503 | 3630 | ||
3504 | } | 3631 | } |
@@ -3603,7 +3730,7 @@ retry: | |||
3603 | * Returns 0 on success. | 3730 | * Returns 0 on success. |
3604 | */ | 3731 | */ |
3605 | int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | 3732 | int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, |
3606 | loff_t len) | 3733 | ssize_t len) |
3607 | { | 3734 | { |
3608 | handle_t *handle; | 3735 | handle_t *handle; |
3609 | ext4_lblk_t block; | 3736 | ext4_lblk_t block; |
@@ -3635,7 +3762,7 @@ int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | |||
3635 | map_bh.b_state = 0; | 3762 | map_bh.b_state = 0; |
3636 | ret = ext4_get_blocks(handle, inode, block, | 3763 | ret = ext4_get_blocks(handle, inode, block, |
3637 | max_blocks, &map_bh, | 3764 | max_blocks, &map_bh, |
3638 | EXT4_GET_BLOCKS_DIO_CONVERT_EXT); | 3765 | EXT4_GET_BLOCKS_IO_CONVERT_EXT); |
3639 | if (ret <= 0) { | 3766 | if (ret <= 0) { |
3640 | WARN_ON(ret <= 0); | 3767 | WARN_ON(ret <= 0); |
3641 | printk(KERN_ERR "%s: ext4_ext_get_blocks " | 3768 | printk(KERN_ERR "%s: ext4_ext_get_blocks " |
@@ -3739,7 +3866,7 @@ static int ext4_xattr_fiemap(struct inode *inode, | |||
3739 | int error = 0; | 3866 | int error = 0; |
3740 | 3867 | ||
3741 | /* in-inode? */ | 3868 | /* in-inode? */ |
3742 | if (EXT4_I(inode)->i_state & EXT4_STATE_XATTR) { | 3869 | if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) { |
3743 | struct ext4_iloc iloc; | 3870 | struct ext4_iloc iloc; |
3744 | int offset; /* offset of xattr in inode */ | 3871 | int offset; /* offset of xattr in inode */ |
3745 | 3872 | ||
@@ -3767,7 +3894,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | |||
3767 | __u64 start, __u64 len) | 3894 | __u64 start, __u64 len) |
3768 | { | 3895 | { |
3769 | ext4_lblk_t start_blk; | 3896 | ext4_lblk_t start_blk; |
3770 | ext4_lblk_t len_blks; | ||
3771 | int error = 0; | 3897 | int error = 0; |
3772 | 3898 | ||
3773 | /* fallback to generic here if not in extents fmt */ | 3899 | /* fallback to generic here if not in extents fmt */ |
@@ -3781,8 +3907,14 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | |||
3781 | if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { | 3907 | if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { |
3782 | error = ext4_xattr_fiemap(inode, fieinfo); | 3908 | error = ext4_xattr_fiemap(inode, fieinfo); |
3783 | } else { | 3909 | } else { |
3910 | ext4_lblk_t len_blks; | ||
3911 | __u64 last_blk; | ||
3912 | |||
3784 | start_blk = start >> inode->i_sb->s_blocksize_bits; | 3913 | start_blk = start >> inode->i_sb->s_blocksize_bits; |
3785 | len_blks = len >> inode->i_sb->s_blocksize_bits; | 3914 | last_blk = (start + len - 1) >> inode->i_sb->s_blocksize_bits; |
3915 | if (last_blk >= EXT_MAX_BLOCK) | ||
3916 | last_blk = EXT_MAX_BLOCK-1; | ||
3917 | len_blks = ((ext4_lblk_t) last_blk) - start_blk + 1; | ||
3786 | 3918 | ||
3787 | /* | 3919 | /* |
3788 | * Walk the extent tree gathering extent information. | 3920 | * Walk the extent tree gathering extent information. |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index a08a12998c49..d0776e410f34 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -36,9 +36,9 @@ | |||
36 | */ | 36 | */ |
37 | static int ext4_release_file(struct inode *inode, struct file *filp) | 37 | static int ext4_release_file(struct inode *inode, struct file *filp) |
38 | { | 38 | { |
39 | if (EXT4_I(inode)->i_state & EXT4_STATE_DA_ALLOC_CLOSE) { | 39 | if (ext4_test_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE)) { |
40 | ext4_alloc_da_blocks(inode); | 40 | ext4_alloc_da_blocks(inode); |
41 | EXT4_I(inode)->i_state &= ~EXT4_STATE_DA_ALLOC_CLOSE; | 41 | ext4_clear_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE); |
42 | } | 42 | } |
43 | /* if we are the last writer on the inode, drop the block reservation */ | 43 | /* if we are the last writer on the inode, drop the block reservation */ |
44 | if ((filp->f_mode & FMODE_WRITE) && | 44 | if ((filp->f_mode & FMODE_WRITE) && |
@@ -117,11 +117,9 @@ static int ext4_file_open(struct inode * inode, struct file * filp) | |||
117 | * devices or filesystem images. | 117 | * devices or filesystem images. |
118 | */ | 118 | */ |
119 | memset(buf, 0, sizeof(buf)); | 119 | memset(buf, 0, sizeof(buf)); |
120 | path.mnt = mnt->mnt_parent; | 120 | path.mnt = mnt; |
121 | path.dentry = mnt->mnt_mountpoint; | 121 | path.dentry = mnt->mnt_root; |
122 | path_get(&path); | ||
123 | cp = d_path(&path, buf, sizeof(buf)); | 122 | cp = d_path(&path, buf, sizeof(buf)); |
124 | path_put(&path); | ||
125 | if (!IS_ERR(cp)) { | 123 | if (!IS_ERR(cp)) { |
126 | memcpy(sbi->s_es->s_last_mounted, cp, | 124 | memcpy(sbi->s_es->s_last_mounted, cp, |
127 | sizeof(sbi->s_es->s_last_mounted)); | 125 | sizeof(sbi->s_es->s_last_mounted)); |
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 98bd140aad01..0d0c3239c1cd 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c | |||
@@ -63,7 +63,7 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) | |||
63 | if (inode->i_sb->s_flags & MS_RDONLY) | 63 | if (inode->i_sb->s_flags & MS_RDONLY) |
64 | return 0; | 64 | return 0; |
65 | 65 | ||
66 | ret = flush_aio_dio_completed_IO(inode); | 66 | ret = flush_completed_IO(inode); |
67 | if (ret < 0) | 67 | if (ret < 0) |
68 | return ret; | 68 | return ret; |
69 | 69 | ||
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 9bb2bb9f67ad..361c0b9962a8 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -76,8 +76,7 @@ unsigned ext4_init_inode_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
76 | /* If checksum is bad mark all blocks and inodes use to prevent | 76 | /* If checksum is bad mark all blocks and inodes use to prevent |
77 | * allocation, essentially implementing a per-group read-only flag. */ | 77 | * allocation, essentially implementing a per-group read-only flag. */ |
78 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { | 78 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { |
79 | ext4_error(sb, __func__, "Checksum bad for group %u", | 79 | ext4_error(sb, "Checksum bad for group %u", block_group); |
80 | block_group); | ||
81 | ext4_free_blks_set(sb, gdp, 0); | 80 | ext4_free_blks_set(sb, gdp, 0); |
82 | ext4_free_inodes_set(sb, gdp, 0); | 81 | ext4_free_inodes_set(sb, gdp, 0); |
83 | ext4_itable_unused_set(sb, gdp, 0); | 82 | ext4_itable_unused_set(sb, gdp, 0); |
@@ -111,8 +110,7 @@ ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
111 | bitmap_blk = ext4_inode_bitmap(sb, desc); | 110 | bitmap_blk = ext4_inode_bitmap(sb, desc); |
112 | bh = sb_getblk(sb, bitmap_blk); | 111 | bh = sb_getblk(sb, bitmap_blk); |
113 | if (unlikely(!bh)) { | 112 | if (unlikely(!bh)) { |
114 | ext4_error(sb, __func__, | 113 | ext4_error(sb, "Cannot read inode bitmap - " |
115 | "Cannot read inode bitmap - " | ||
116 | "block_group = %u, inode_bitmap = %llu", | 114 | "block_group = %u, inode_bitmap = %llu", |
117 | block_group, bitmap_blk); | 115 | block_group, bitmap_blk); |
118 | return NULL; | 116 | return NULL; |
@@ -153,8 +151,7 @@ ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
153 | set_bitmap_uptodate(bh); | 151 | set_bitmap_uptodate(bh); |
154 | if (bh_submit_read(bh) < 0) { | 152 | if (bh_submit_read(bh) < 0) { |
155 | put_bh(bh); | 153 | put_bh(bh); |
156 | ext4_error(sb, __func__, | 154 | ext4_error(sb, "Cannot read inode bitmap - " |
157 | "Cannot read inode bitmap - " | ||
158 | "block_group = %u, inode_bitmap = %llu", | 155 | "block_group = %u, inode_bitmap = %llu", |
159 | block_group, bitmap_blk); | 156 | block_group, bitmap_blk); |
160 | return NULL; | 157 | return NULL; |
@@ -229,8 +226,7 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
229 | 226 | ||
230 | es = EXT4_SB(sb)->s_es; | 227 | es = EXT4_SB(sb)->s_es; |
231 | if (ino < EXT4_FIRST_INO(sb) || ino > le32_to_cpu(es->s_inodes_count)) { | 228 | if (ino < EXT4_FIRST_INO(sb) || ino > le32_to_cpu(es->s_inodes_count)) { |
232 | ext4_error(sb, "ext4_free_inode", | 229 | ext4_error(sb, "reserved or nonexistent inode %lu", ino); |
233 | "reserved or nonexistent inode %lu", ino); | ||
234 | goto error_return; | 230 | goto error_return; |
235 | } | 231 | } |
236 | block_group = (ino - 1) / EXT4_INODES_PER_GROUP(sb); | 232 | block_group = (ino - 1) / EXT4_INODES_PER_GROUP(sb); |
@@ -248,8 +244,7 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
248 | cleared = ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), | 244 | cleared = ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), |
249 | bit, bitmap_bh->b_data); | 245 | bit, bitmap_bh->b_data); |
250 | if (!cleared) | 246 | if (!cleared) |
251 | ext4_error(sb, "ext4_free_inode", | 247 | ext4_error(sb, "bit already cleared for inode %lu", ino); |
252 | "bit already cleared for inode %lu", ino); | ||
253 | else { | 248 | else { |
254 | gdp = ext4_get_group_desc(sb, block_group, &bh2); | 249 | gdp = ext4_get_group_desc(sb, block_group, &bh2); |
255 | 250 | ||
@@ -736,8 +731,7 @@ static int ext4_claim_inode(struct super_block *sb, | |||
736 | if ((group == 0 && ino < EXT4_FIRST_INO(sb)) || | 731 | if ((group == 0 && ino < EXT4_FIRST_INO(sb)) || |
737 | ino > EXT4_INODES_PER_GROUP(sb)) { | 732 | ino > EXT4_INODES_PER_GROUP(sb)) { |
738 | ext4_unlock_group(sb, group); | 733 | ext4_unlock_group(sb, group); |
739 | ext4_error(sb, __func__, | 734 | ext4_error(sb, "reserved inode or inode > inodes count - " |
740 | "reserved inode or inode > inodes count - " | ||
741 | "block_group = %u, inode=%lu", group, | 735 | "block_group = %u, inode=%lu", group, |
742 | ino + group * EXT4_INODES_PER_GROUP(sb)); | 736 | ino + group * EXT4_INODES_PER_GROUP(sb)); |
743 | return 1; | 737 | return 1; |
@@ -904,7 +898,7 @@ repeat_in_this_group: | |||
904 | BUFFER_TRACE(inode_bitmap_bh, | 898 | BUFFER_TRACE(inode_bitmap_bh, |
905 | "call ext4_handle_dirty_metadata"); | 899 | "call ext4_handle_dirty_metadata"); |
906 | err = ext4_handle_dirty_metadata(handle, | 900 | err = ext4_handle_dirty_metadata(handle, |
907 | inode, | 901 | NULL, |
908 | inode_bitmap_bh); | 902 | inode_bitmap_bh); |
909 | if (err) | 903 | if (err) |
910 | goto fail; | 904 | goto fail; |
@@ -1029,7 +1023,8 @@ got: | |||
1029 | inode->i_generation = sbi->s_next_generation++; | 1023 | inode->i_generation = sbi->s_next_generation++; |
1030 | spin_unlock(&sbi->s_next_gen_lock); | 1024 | spin_unlock(&sbi->s_next_gen_lock); |
1031 | 1025 | ||
1032 | ei->i_state = EXT4_STATE_NEW; | 1026 | ei->i_state_flags = 0; |
1027 | ext4_set_inode_state(inode, EXT4_STATE_NEW); | ||
1033 | 1028 | ||
1034 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; | 1029 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; |
1035 | 1030 | ||
@@ -1098,8 +1093,7 @@ struct inode *ext4_orphan_get(struct super_block *sb, unsigned long ino) | |||
1098 | 1093 | ||
1099 | /* Error cases - e2fsck has already cleaned up for us */ | 1094 | /* Error cases - e2fsck has already cleaned up for us */ |
1100 | if (ino > max_ino) { | 1095 | if (ino > max_ino) { |
1101 | ext4_warning(sb, __func__, | 1096 | ext4_warning(sb, "bad orphan ino %lu! e2fsck was run?", ino); |
1102 | "bad orphan ino %lu! e2fsck was run?", ino); | ||
1103 | goto error; | 1097 | goto error; |
1104 | } | 1098 | } |
1105 | 1099 | ||
@@ -1107,8 +1101,7 @@ struct inode *ext4_orphan_get(struct super_block *sb, unsigned long ino) | |||
1107 | bit = (ino - 1) % EXT4_INODES_PER_GROUP(sb); | 1101 | bit = (ino - 1) % EXT4_INODES_PER_GROUP(sb); |
1108 | bitmap_bh = ext4_read_inode_bitmap(sb, block_group); | 1102 | bitmap_bh = ext4_read_inode_bitmap(sb, block_group); |
1109 | if (!bitmap_bh) { | 1103 | if (!bitmap_bh) { |
1110 | ext4_warning(sb, __func__, | 1104 | ext4_warning(sb, "inode bitmap error for orphan %lu", ino); |
1111 | "inode bitmap error for orphan %lu", ino); | ||
1112 | goto error; | 1105 | goto error; |
1113 | } | 1106 | } |
1114 | 1107 | ||
@@ -1140,8 +1133,7 @@ iget_failed: | |||
1140 | err = PTR_ERR(inode); | 1133 | err = PTR_ERR(inode); |
1141 | inode = NULL; | 1134 | inode = NULL; |
1142 | bad_orphan: | 1135 | bad_orphan: |
1143 | ext4_warning(sb, __func__, | 1136 | ext4_warning(sb, "bad orphan inode %lu! e2fsck was run?", ino); |
1144 | "bad orphan inode %lu! e2fsck was run?", ino); | ||
1145 | printk(KERN_NOTICE "ext4_test_bit(bit=%d, block=%llu) = %d\n", | 1137 | printk(KERN_NOTICE "ext4_test_bit(bit=%d, block=%llu) = %d\n", |
1146 | bit, (unsigned long long)bitmap_bh->b_blocknr, | 1138 | bit, (unsigned long long)bitmap_bh->b_blocknr, |
1147 | ext4_test_bit(bit, bitmap_bh->b_data)); | 1139 | ext4_test_bit(bit, bitmap_bh->b_data)); |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index bec222ca9ba4..986120f30066 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -38,6 +38,7 @@ | |||
38 | #include <linux/uio.h> | 38 | #include <linux/uio.h> |
39 | #include <linux/bio.h> | 39 | #include <linux/bio.h> |
40 | #include <linux/workqueue.h> | 40 | #include <linux/workqueue.h> |
41 | #include <linux/kernel.h> | ||
41 | 42 | ||
42 | #include "ext4_jbd2.h" | 43 | #include "ext4_jbd2.h" |
43 | #include "xattr.h" | 44 | #include "xattr.h" |
@@ -197,7 +198,7 @@ void ext4_delete_inode(struct inode *inode) | |||
197 | inode->i_size = 0; | 198 | inode->i_size = 0; |
198 | err = ext4_mark_inode_dirty(handle, inode); | 199 | err = ext4_mark_inode_dirty(handle, inode); |
199 | if (err) { | 200 | if (err) { |
200 | ext4_warning(inode->i_sb, __func__, | 201 | ext4_warning(inode->i_sb, |
201 | "couldn't mark inode dirty (err %d)", err); | 202 | "couldn't mark inode dirty (err %d)", err); |
202 | goto stop_handle; | 203 | goto stop_handle; |
203 | } | 204 | } |
@@ -215,7 +216,7 @@ void ext4_delete_inode(struct inode *inode) | |||
215 | if (err > 0) | 216 | if (err > 0) |
216 | err = ext4_journal_restart(handle, 3); | 217 | err = ext4_journal_restart(handle, 3); |
217 | if (err != 0) { | 218 | if (err != 0) { |
218 | ext4_warning(inode->i_sb, __func__, | 219 | ext4_warning(inode->i_sb, |
219 | "couldn't extend journal (err %d)", err); | 220 | "couldn't extend journal (err %d)", err); |
220 | stop_handle: | 221 | stop_handle: |
221 | ext4_journal_stop(handle); | 222 | ext4_journal_stop(handle); |
@@ -326,8 +327,7 @@ static int ext4_block_to_path(struct inode *inode, | |||
326 | offsets[n++] = i_block & (ptrs - 1); | 327 | offsets[n++] = i_block & (ptrs - 1); |
327 | final = ptrs; | 328 | final = ptrs; |
328 | } else { | 329 | } else { |
329 | ext4_warning(inode->i_sb, "ext4_block_to_path", | 330 | ext4_warning(inode->i_sb, "block %lu > max in inode %lu", |
330 | "block %lu > max in inode %lu", | ||
331 | i_block + direct_blocks + | 331 | i_block + direct_blocks + |
332 | indirect_blocks + double_blocks, inode->i_ino); | 332 | indirect_blocks + double_blocks, inode->i_ino); |
333 | } | 333 | } |
@@ -347,7 +347,7 @@ static int __ext4_check_blockref(const char *function, struct inode *inode, | |||
347 | if (blk && | 347 | if (blk && |
348 | unlikely(!ext4_data_block_valid(EXT4_SB(inode->i_sb), | 348 | unlikely(!ext4_data_block_valid(EXT4_SB(inode->i_sb), |
349 | blk, 1))) { | 349 | blk, 1))) { |
350 | ext4_error(inode->i_sb, function, | 350 | __ext4_error(inode->i_sb, function, |
351 | "invalid block reference %u " | 351 | "invalid block reference %u " |
352 | "in inode #%lu", blk, inode->i_ino); | 352 | "in inode #%lu", blk, inode->i_ino); |
353 | return -EIO; | 353 | return -EIO; |
@@ -610,7 +610,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode, | |||
610 | if (*err) | 610 | if (*err) |
611 | goto failed_out; | 611 | goto failed_out; |
612 | 612 | ||
613 | BUG_ON(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS); | 613 | if (unlikely(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS)) { |
614 | EXT4_ERROR_INODE(inode, | ||
615 | "current_block %llu + count %lu > %d!", | ||
616 | current_block, count, | ||
617 | EXT4_MAX_BLOCK_FILE_PHYS); | ||
618 | *err = -EIO; | ||
619 | goto failed_out; | ||
620 | } | ||
614 | 621 | ||
615 | target -= count; | 622 | target -= count; |
616 | /* allocate blocks for indirect blocks */ | 623 | /* allocate blocks for indirect blocks */ |
@@ -646,7 +653,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode, | |||
646 | ar.flags = EXT4_MB_HINT_DATA; | 653 | ar.flags = EXT4_MB_HINT_DATA; |
647 | 654 | ||
648 | current_block = ext4_mb_new_blocks(handle, &ar, err); | 655 | current_block = ext4_mb_new_blocks(handle, &ar, err); |
649 | BUG_ON(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS); | 656 | if (unlikely(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS)) { |
657 | EXT4_ERROR_INODE(inode, | ||
658 | "current_block %llu + ar.len %d > %d!", | ||
659 | current_block, ar.len, | ||
660 | EXT4_MAX_BLOCK_FILE_PHYS); | ||
661 | *err = -EIO; | ||
662 | goto failed_out; | ||
663 | } | ||
650 | 664 | ||
651 | if (*err && (target == blks)) { | 665 | if (*err && (target == blks)) { |
652 | /* | 666 | /* |
@@ -1064,6 +1078,7 @@ void ext4_da_update_reserve_space(struct inode *inode, | |||
1064 | int mdb_free = 0, allocated_meta_blocks = 0; | 1078 | int mdb_free = 0, allocated_meta_blocks = 0; |
1065 | 1079 | ||
1066 | spin_lock(&ei->i_block_reservation_lock); | 1080 | spin_lock(&ei->i_block_reservation_lock); |
1081 | trace_ext4_da_update_reserve_space(inode, used); | ||
1067 | if (unlikely(used > ei->i_reserved_data_blocks)) { | 1082 | if (unlikely(used > ei->i_reserved_data_blocks)) { |
1068 | ext4_msg(inode->i_sb, KERN_NOTICE, "%s: ino %lu, used %d " | 1083 | ext4_msg(inode->i_sb, KERN_NOTICE, "%s: ino %lu, used %d " |
1069 | "with only %d reserved data blocks\n", | 1084 | "with only %d reserved data blocks\n", |
@@ -1127,7 +1142,7 @@ static int check_block_validity(struct inode *inode, const char *msg, | |||
1127 | sector_t logical, sector_t phys, int len) | 1142 | sector_t logical, sector_t phys, int len) |
1128 | { | 1143 | { |
1129 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), phys, len)) { | 1144 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), phys, len)) { |
1130 | ext4_error(inode->i_sb, msg, | 1145 | __ext4_error(inode->i_sb, msg, |
1131 | "inode #%lu logical block %llu mapped to %llu " | 1146 | "inode #%lu logical block %llu mapped to %llu " |
1132 | "(size %d)", inode->i_ino, | 1147 | "(size %d)", inode->i_ino, |
1133 | (unsigned long long) logical, | 1148 | (unsigned long long) logical, |
@@ -1309,7 +1324,7 @@ int ext4_get_blocks(handle_t *handle, struct inode *inode, sector_t block, | |||
1309 | * i_data's format changing. Force the migrate | 1324 | * i_data's format changing. Force the migrate |
1310 | * to fail by clearing migrate flags | 1325 | * to fail by clearing migrate flags |
1311 | */ | 1326 | */ |
1312 | EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE; | 1327 | ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
1313 | } | 1328 | } |
1314 | 1329 | ||
1315 | /* | 1330 | /* |
@@ -1537,6 +1552,8 @@ static void ext4_truncate_failed_write(struct inode *inode) | |||
1537 | ext4_truncate(inode); | 1552 | ext4_truncate(inode); |
1538 | } | 1553 | } |
1539 | 1554 | ||
1555 | static int ext4_get_block_write(struct inode *inode, sector_t iblock, | ||
1556 | struct buffer_head *bh_result, int create); | ||
1540 | static int ext4_write_begin(struct file *file, struct address_space *mapping, | 1557 | static int ext4_write_begin(struct file *file, struct address_space *mapping, |
1541 | loff_t pos, unsigned len, unsigned flags, | 1558 | loff_t pos, unsigned len, unsigned flags, |
1542 | struct page **pagep, void **fsdata) | 1559 | struct page **pagep, void **fsdata) |
@@ -1578,8 +1595,12 @@ retry: | |||
1578 | } | 1595 | } |
1579 | *pagep = page; | 1596 | *pagep = page; |
1580 | 1597 | ||
1581 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, fsdata, | 1598 | if (ext4_should_dioread_nolock(inode)) |
1582 | ext4_get_block); | 1599 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, |
1600 | fsdata, ext4_get_block_write); | ||
1601 | else | ||
1602 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, | ||
1603 | fsdata, ext4_get_block); | ||
1583 | 1604 | ||
1584 | if (!ret && ext4_should_journal_data(inode)) { | 1605 | if (!ret && ext4_should_journal_data(inode)) { |
1585 | ret = walk_page_buffers(handle, page_buffers(page), | 1606 | ret = walk_page_buffers(handle, page_buffers(page), |
@@ -1796,7 +1817,7 @@ static int ext4_journalled_write_end(struct file *file, | |||
1796 | new_i_size = pos + copied; | 1817 | new_i_size = pos + copied; |
1797 | if (new_i_size > inode->i_size) | 1818 | if (new_i_size > inode->i_size) |
1798 | i_size_write(inode, pos+copied); | 1819 | i_size_write(inode, pos+copied); |
1799 | EXT4_I(inode)->i_state |= EXT4_STATE_JDATA; | 1820 | ext4_set_inode_state(inode, EXT4_STATE_JDATA); |
1800 | if (new_i_size > EXT4_I(inode)->i_disksize) { | 1821 | if (new_i_size > EXT4_I(inode)->i_disksize) { |
1801 | ext4_update_i_disksize(inode, new_i_size); | 1822 | ext4_update_i_disksize(inode, new_i_size); |
1802 | ret2 = ext4_mark_inode_dirty(handle, inode); | 1823 | ret2 = ext4_mark_inode_dirty(handle, inode); |
@@ -1850,6 +1871,7 @@ repeat: | |||
1850 | spin_lock(&ei->i_block_reservation_lock); | 1871 | spin_lock(&ei->i_block_reservation_lock); |
1851 | md_reserved = ei->i_reserved_meta_blocks; | 1872 | md_reserved = ei->i_reserved_meta_blocks; |
1852 | md_needed = ext4_calc_metadata_amount(inode, lblock); | 1873 | md_needed = ext4_calc_metadata_amount(inode, lblock); |
1874 | trace_ext4_da_reserve_space(inode, md_needed); | ||
1853 | spin_unlock(&ei->i_block_reservation_lock); | 1875 | spin_unlock(&ei->i_block_reservation_lock); |
1854 | 1876 | ||
1855 | /* | 1877 | /* |
@@ -2096,6 +2118,8 @@ static void mpage_put_bnr_to_bhs(struct mpage_da_data *mpd, sector_t logical, | |||
2096 | } else if (buffer_mapped(bh)) | 2118 | } else if (buffer_mapped(bh)) |
2097 | BUG_ON(bh->b_blocknr != pblock); | 2119 | BUG_ON(bh->b_blocknr != pblock); |
2098 | 2120 | ||
2121 | if (buffer_uninit(exbh)) | ||
2122 | set_buffer_uninit(bh); | ||
2099 | cur_logical++; | 2123 | cur_logical++; |
2100 | pblock++; | 2124 | pblock++; |
2101 | } while ((bh = bh->b_this_page) != head); | 2125 | } while ((bh = bh->b_this_page) != head); |
@@ -2138,17 +2162,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd, | |||
2138 | break; | 2162 | break; |
2139 | for (i = 0; i < nr_pages; i++) { | 2163 | for (i = 0; i < nr_pages; i++) { |
2140 | struct page *page = pvec.pages[i]; | 2164 | struct page *page = pvec.pages[i]; |
2141 | index = page->index; | 2165 | if (page->index > end) |
2142 | if (index > end) | ||
2143 | break; | 2166 | break; |
2144 | index++; | ||
2145 | |||
2146 | BUG_ON(!PageLocked(page)); | 2167 | BUG_ON(!PageLocked(page)); |
2147 | BUG_ON(PageWriteback(page)); | 2168 | BUG_ON(PageWriteback(page)); |
2148 | block_invalidatepage(page, 0); | 2169 | block_invalidatepage(page, 0); |
2149 | ClearPageUptodate(page); | 2170 | ClearPageUptodate(page); |
2150 | unlock_page(page); | 2171 | unlock_page(page); |
2151 | } | 2172 | } |
2173 | index = pvec.pages[nr_pages - 1]->index + 1; | ||
2174 | pagevec_release(&pvec); | ||
2152 | } | 2175 | } |
2153 | return; | 2176 | return; |
2154 | } | 2177 | } |
@@ -2225,6 +2248,8 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd) | |||
2225 | */ | 2248 | */ |
2226 | new.b_state = 0; | 2249 | new.b_state = 0; |
2227 | get_blocks_flags = EXT4_GET_BLOCKS_CREATE; | 2250 | get_blocks_flags = EXT4_GET_BLOCKS_CREATE; |
2251 | if (ext4_should_dioread_nolock(mpd->inode)) | ||
2252 | get_blocks_flags |= EXT4_GET_BLOCKS_IO_CREATE_EXT; | ||
2228 | if (mpd->b_state & (1 << BH_Delay)) | 2253 | if (mpd->b_state & (1 << BH_Delay)) |
2229 | get_blocks_flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE; | 2254 | get_blocks_flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE; |
2230 | 2255 | ||
@@ -2635,11 +2660,14 @@ static int __ext4_journalled_writepage(struct page *page, | |||
2635 | ret = err; | 2660 | ret = err; |
2636 | 2661 | ||
2637 | walk_page_buffers(handle, page_bufs, 0, len, NULL, bput_one); | 2662 | walk_page_buffers(handle, page_bufs, 0, len, NULL, bput_one); |
2638 | EXT4_I(inode)->i_state |= EXT4_STATE_JDATA; | 2663 | ext4_set_inode_state(inode, EXT4_STATE_JDATA); |
2639 | out: | 2664 | out: |
2640 | return ret; | 2665 | return ret; |
2641 | } | 2666 | } |
2642 | 2667 | ||
2668 | static int ext4_set_bh_endio(struct buffer_head *bh, struct inode *inode); | ||
2669 | static void ext4_end_io_buffer_write(struct buffer_head *bh, int uptodate); | ||
2670 | |||
2643 | /* | 2671 | /* |
2644 | * Note that we don't need to start a transaction unless we're journaling data | 2672 | * Note that we don't need to start a transaction unless we're journaling data |
2645 | * because we should have holes filled from ext4_page_mkwrite(). We even don't | 2673 | * because we should have holes filled from ext4_page_mkwrite(). We even don't |
@@ -2687,7 +2715,7 @@ static int ext4_writepage(struct page *page, | |||
2687 | int ret = 0; | 2715 | int ret = 0; |
2688 | loff_t size; | 2716 | loff_t size; |
2689 | unsigned int len; | 2717 | unsigned int len; |
2690 | struct buffer_head *page_bufs; | 2718 | struct buffer_head *page_bufs = NULL; |
2691 | struct inode *inode = page->mapping->host; | 2719 | struct inode *inode = page->mapping->host; |
2692 | 2720 | ||
2693 | trace_ext4_writepage(inode, page); | 2721 | trace_ext4_writepage(inode, page); |
@@ -2763,7 +2791,11 @@ static int ext4_writepage(struct page *page, | |||
2763 | 2791 | ||
2764 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) | 2792 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) |
2765 | ret = nobh_writepage(page, noalloc_get_block_write, wbc); | 2793 | ret = nobh_writepage(page, noalloc_get_block_write, wbc); |
2766 | else | 2794 | else if (page_bufs && buffer_uninit(page_bufs)) { |
2795 | ext4_set_bh_endio(page_bufs, inode); | ||
2796 | ret = block_write_full_page_endio(page, noalloc_get_block_write, | ||
2797 | wbc, ext4_end_io_buffer_write); | ||
2798 | } else | ||
2767 | ret = block_write_full_page(page, noalloc_get_block_write, | 2799 | ret = block_write_full_page(page, noalloc_get_block_write, |
2768 | wbc); | 2800 | wbc); |
2769 | 2801 | ||
@@ -3306,7 +3338,8 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) | |||
3306 | filemap_write_and_wait(mapping); | 3338 | filemap_write_and_wait(mapping); |
3307 | } | 3339 | } |
3308 | 3340 | ||
3309 | if (EXT4_JOURNAL(inode) && EXT4_I(inode)->i_state & EXT4_STATE_JDATA) { | 3341 | if (EXT4_JOURNAL(inode) && |
3342 | ext4_test_inode_state(inode, EXT4_STATE_JDATA)) { | ||
3310 | /* | 3343 | /* |
3311 | * This is a REALLY heavyweight approach, but the use of | 3344 | * This is a REALLY heavyweight approach, but the use of |
3312 | * bmap on dirty files is expected to be extremely rare: | 3345 | * bmap on dirty files is expected to be extremely rare: |
@@ -3325,7 +3358,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) | |||
3325 | * everything they get. | 3358 | * everything they get. |
3326 | */ | 3359 | */ |
3327 | 3360 | ||
3328 | EXT4_I(inode)->i_state &= ~EXT4_STATE_JDATA; | 3361 | ext4_clear_inode_state(inode, EXT4_STATE_JDATA); |
3329 | journal = EXT4_JOURNAL(inode); | 3362 | journal = EXT4_JOURNAL(inode); |
3330 | jbd2_journal_lock_updates(journal); | 3363 | jbd2_journal_lock_updates(journal); |
3331 | err = jbd2_journal_flush(journal); | 3364 | err = jbd2_journal_flush(journal); |
@@ -3350,11 +3383,45 @@ ext4_readpages(struct file *file, struct address_space *mapping, | |||
3350 | return mpage_readpages(mapping, pages, nr_pages, ext4_get_block); | 3383 | return mpage_readpages(mapping, pages, nr_pages, ext4_get_block); |
3351 | } | 3384 | } |
3352 | 3385 | ||
3386 | static void ext4_free_io_end(ext4_io_end_t *io) | ||
3387 | { | ||
3388 | BUG_ON(!io); | ||
3389 | if (io->page) | ||
3390 | put_page(io->page); | ||
3391 | iput(io->inode); | ||
3392 | kfree(io); | ||
3393 | } | ||
3394 | |||
3395 | static void ext4_invalidatepage_free_endio(struct page *page, unsigned long offset) | ||
3396 | { | ||
3397 | struct buffer_head *head, *bh; | ||
3398 | unsigned int curr_off = 0; | ||
3399 | |||
3400 | if (!page_has_buffers(page)) | ||
3401 | return; | ||
3402 | head = bh = page_buffers(page); | ||
3403 | do { | ||
3404 | if (offset <= curr_off && test_clear_buffer_uninit(bh) | ||
3405 | && bh->b_private) { | ||
3406 | ext4_free_io_end(bh->b_private); | ||
3407 | bh->b_private = NULL; | ||
3408 | bh->b_end_io = NULL; | ||
3409 | } | ||
3410 | curr_off = curr_off + bh->b_size; | ||
3411 | bh = bh->b_this_page; | ||
3412 | } while (bh != head); | ||
3413 | } | ||
3414 | |||
3353 | static void ext4_invalidatepage(struct page *page, unsigned long offset) | 3415 | static void ext4_invalidatepage(struct page *page, unsigned long offset) |
3354 | { | 3416 | { |
3355 | journal_t *journal = EXT4_JOURNAL(page->mapping->host); | 3417 | journal_t *journal = EXT4_JOURNAL(page->mapping->host); |
3356 | 3418 | ||
3357 | /* | 3419 | /* |
3420 | * free any io_end structure allocated for buffers to be discarded | ||
3421 | */ | ||
3422 | if (ext4_should_dioread_nolock(page->mapping->host)) | ||
3423 | ext4_invalidatepage_free_endio(page, offset); | ||
3424 | /* | ||
3358 | * If it's a full truncate we just forget about the pending dirtying | 3425 | * If it's a full truncate we just forget about the pending dirtying |
3359 | */ | 3426 | */ |
3360 | if (offset == 0) | 3427 | if (offset == 0) |
@@ -3425,7 +3492,14 @@ static ssize_t ext4_ind_direct_IO(int rw, struct kiocb *iocb, | |||
3425 | } | 3492 | } |
3426 | 3493 | ||
3427 | retry: | 3494 | retry: |
3428 | ret = blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 3495 | if (rw == READ && ext4_should_dioread_nolock(inode)) |
3496 | ret = blockdev_direct_IO_no_locking(rw, iocb, inode, | ||
3497 | inode->i_sb->s_bdev, iov, | ||
3498 | offset, nr_segs, | ||
3499 | ext4_get_block, NULL); | ||
3500 | else | ||
3501 | ret = blockdev_direct_IO(rw, iocb, inode, | ||
3502 | inode->i_sb->s_bdev, iov, | ||
3429 | offset, nr_segs, | 3503 | offset, nr_segs, |
3430 | ext4_get_block, NULL); | 3504 | ext4_get_block, NULL); |
3431 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) | 3505 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |
@@ -3441,6 +3515,9 @@ retry: | |||
3441 | * but cannot extend i_size. Bail out and pretend | 3515 | * but cannot extend i_size. Bail out and pretend |
3442 | * the write failed... */ | 3516 | * the write failed... */ |
3443 | ret = PTR_ERR(handle); | 3517 | ret = PTR_ERR(handle); |
3518 | if (inode->i_nlink) | ||
3519 | ext4_orphan_del(NULL, inode); | ||
3520 | |||
3444 | goto out; | 3521 | goto out; |
3445 | } | 3522 | } |
3446 | if (inode->i_nlink) | 3523 | if (inode->i_nlink) |
@@ -3468,75 +3545,63 @@ out: | |||
3468 | return ret; | 3545 | return ret; |
3469 | } | 3546 | } |
3470 | 3547 | ||
3471 | static int ext4_get_block_dio_write(struct inode *inode, sector_t iblock, | 3548 | static int ext4_get_block_write(struct inode *inode, sector_t iblock, |
3472 | struct buffer_head *bh_result, int create) | 3549 | struct buffer_head *bh_result, int create) |
3473 | { | 3550 | { |
3474 | handle_t *handle = NULL; | 3551 | handle_t *handle = ext4_journal_current_handle(); |
3475 | int ret = 0; | 3552 | int ret = 0; |
3476 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; | 3553 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; |
3477 | int dio_credits; | 3554 | int dio_credits; |
3555 | int started = 0; | ||
3478 | 3556 | ||
3479 | ext4_debug("ext4_get_block_dio_write: inode %lu, create flag %d\n", | 3557 | ext4_debug("ext4_get_block_write: inode %lu, create flag %d\n", |
3480 | inode->i_ino, create); | 3558 | inode->i_ino, create); |
3481 | /* | 3559 | /* |
3482 | * DIO VFS code passes create = 0 flag for write to | 3560 | * ext4_get_block in prepare for a DIO write or buffer write. |
3483 | * the middle of file. It does this to avoid block | 3561 | * We allocate an uinitialized extent if blocks haven't been allocated. |
3484 | * allocation for holes, to prevent expose stale data | 3562 | * The extent will be converted to initialized after IO complete. |
3485 | * out when there is parallel buffered read (which does | ||
3486 | * not hold the i_mutex lock) while direct IO write has | ||
3487 | * not completed. DIO request on holes finally falls back | ||
3488 | * to buffered IO for this reason. | ||
3489 | * | ||
3490 | * For ext4 extent based file, since we support fallocate, | ||
3491 | * new allocated extent as uninitialized, for holes, we | ||
3492 | * could fallocate blocks for holes, thus parallel | ||
3493 | * buffered IO read will zero out the page when read on | ||
3494 | * a hole while parallel DIO write to the hole has not completed. | ||
3495 | * | ||
3496 | * when we come here, we know it's a direct IO write to | ||
3497 | * to the middle of file (<i_size) | ||
3498 | * so it's safe to override the create flag from VFS. | ||
3499 | */ | 3563 | */ |
3500 | create = EXT4_GET_BLOCKS_DIO_CREATE_EXT; | 3564 | create = EXT4_GET_BLOCKS_IO_CREATE_EXT; |
3501 | 3565 | ||
3502 | if (max_blocks > DIO_MAX_BLOCKS) | 3566 | if (!handle) { |
3503 | max_blocks = DIO_MAX_BLOCKS; | 3567 | if (max_blocks > DIO_MAX_BLOCKS) |
3504 | dio_credits = ext4_chunk_trans_blocks(inode, max_blocks); | 3568 | max_blocks = DIO_MAX_BLOCKS; |
3505 | handle = ext4_journal_start(inode, dio_credits); | 3569 | dio_credits = ext4_chunk_trans_blocks(inode, max_blocks); |
3506 | if (IS_ERR(handle)) { | 3570 | handle = ext4_journal_start(inode, dio_credits); |
3507 | ret = PTR_ERR(handle); | 3571 | if (IS_ERR(handle)) { |
3508 | goto out; | 3572 | ret = PTR_ERR(handle); |
3573 | goto out; | ||
3574 | } | ||
3575 | started = 1; | ||
3509 | } | 3576 | } |
3577 | |||
3510 | ret = ext4_get_blocks(handle, inode, iblock, max_blocks, bh_result, | 3578 | ret = ext4_get_blocks(handle, inode, iblock, max_blocks, bh_result, |
3511 | create); | 3579 | create); |
3512 | if (ret > 0) { | 3580 | if (ret > 0) { |
3513 | bh_result->b_size = (ret << inode->i_blkbits); | 3581 | bh_result->b_size = (ret << inode->i_blkbits); |
3514 | ret = 0; | 3582 | ret = 0; |
3515 | } | 3583 | } |
3516 | ext4_journal_stop(handle); | 3584 | if (started) |
3585 | ext4_journal_stop(handle); | ||
3517 | out: | 3586 | out: |
3518 | return ret; | 3587 | return ret; |
3519 | } | 3588 | } |
3520 | 3589 | ||
3521 | static void ext4_free_io_end(ext4_io_end_t *io) | 3590 | static void dump_completed_IO(struct inode * inode) |
3522 | { | ||
3523 | BUG_ON(!io); | ||
3524 | iput(io->inode); | ||
3525 | kfree(io); | ||
3526 | } | ||
3527 | static void dump_aio_dio_list(struct inode * inode) | ||
3528 | { | 3591 | { |
3529 | #ifdef EXT4_DEBUG | 3592 | #ifdef EXT4_DEBUG |
3530 | struct list_head *cur, *before, *after; | 3593 | struct list_head *cur, *before, *after; |
3531 | ext4_io_end_t *io, *io0, *io1; | 3594 | ext4_io_end_t *io, *io0, *io1; |
3595 | unsigned long flags; | ||
3532 | 3596 | ||
3533 | if (list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)){ | 3597 | if (list_empty(&EXT4_I(inode)->i_completed_io_list)){ |
3534 | ext4_debug("inode %lu aio dio list is empty\n", inode->i_ino); | 3598 | ext4_debug("inode %lu completed_io list is empty\n", inode->i_ino); |
3535 | return; | 3599 | return; |
3536 | } | 3600 | } |
3537 | 3601 | ||
3538 | ext4_debug("Dump inode %lu aio_dio_completed_IO list \n", inode->i_ino); | 3602 | ext4_debug("Dump inode %lu completed_io list \n", inode->i_ino); |
3539 | list_for_each_entry(io, &EXT4_I(inode)->i_aio_dio_complete_list, list){ | 3603 | spin_lock_irqsave(&EXT4_I(inode)->i_completed_io_lock, flags); |
3604 | list_for_each_entry(io, &EXT4_I(inode)->i_completed_io_list, list){ | ||
3540 | cur = &io->list; | 3605 | cur = &io->list; |
3541 | before = cur->prev; | 3606 | before = cur->prev; |
3542 | io0 = container_of(before, ext4_io_end_t, list); | 3607 | io0 = container_of(before, ext4_io_end_t, list); |
@@ -3546,32 +3611,31 @@ static void dump_aio_dio_list(struct inode * inode) | |||
3546 | ext4_debug("io 0x%p from inode %lu,prev 0x%p,next 0x%p\n", | 3611 | ext4_debug("io 0x%p from inode %lu,prev 0x%p,next 0x%p\n", |
3547 | io, inode->i_ino, io0, io1); | 3612 | io, inode->i_ino, io0, io1); |
3548 | } | 3613 | } |
3614 | spin_unlock_irqrestore(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3549 | #endif | 3615 | #endif |
3550 | } | 3616 | } |
3551 | 3617 | ||
3552 | /* | 3618 | /* |
3553 | * check a range of space and convert unwritten extents to written. | 3619 | * check a range of space and convert unwritten extents to written. |
3554 | */ | 3620 | */ |
3555 | static int ext4_end_aio_dio_nolock(ext4_io_end_t *io) | 3621 | static int ext4_end_io_nolock(ext4_io_end_t *io) |
3556 | { | 3622 | { |
3557 | struct inode *inode = io->inode; | 3623 | struct inode *inode = io->inode; |
3558 | loff_t offset = io->offset; | 3624 | loff_t offset = io->offset; |
3559 | size_t size = io->size; | 3625 | ssize_t size = io->size; |
3560 | int ret = 0; | 3626 | int ret = 0; |
3561 | 3627 | ||
3562 | ext4_debug("end_aio_dio_onlock: io 0x%p from inode %lu,list->next 0x%p," | 3628 | ext4_debug("ext4_end_io_nolock: io 0x%p from inode %lu,list->next 0x%p," |
3563 | "list->prev 0x%p\n", | 3629 | "list->prev 0x%p\n", |
3564 | io, inode->i_ino, io->list.next, io->list.prev); | 3630 | io, inode->i_ino, io->list.next, io->list.prev); |
3565 | 3631 | ||
3566 | if (list_empty(&io->list)) | 3632 | if (list_empty(&io->list)) |
3567 | return ret; | 3633 | return ret; |
3568 | 3634 | ||
3569 | if (io->flag != DIO_AIO_UNWRITTEN) | 3635 | if (io->flag != EXT4_IO_UNWRITTEN) |
3570 | return ret; | 3636 | return ret; |
3571 | 3637 | ||
3572 | if (offset + size <= i_size_read(inode)) | 3638 | ret = ext4_convert_unwritten_extents(inode, offset, size); |
3573 | ret = ext4_convert_unwritten_extents(inode, offset, size); | ||
3574 | |||
3575 | if (ret < 0) { | 3639 | if (ret < 0) { |
3576 | printk(KERN_EMERG "%s: failed to convert unwritten" | 3640 | printk(KERN_EMERG "%s: failed to convert unwritten" |
3577 | "extents to written extents, error is %d" | 3641 | "extents to written extents, error is %d" |
@@ -3584,50 +3648,64 @@ static int ext4_end_aio_dio_nolock(ext4_io_end_t *io) | |||
3584 | io->flag = 0; | 3648 | io->flag = 0; |
3585 | return ret; | 3649 | return ret; |
3586 | } | 3650 | } |
3651 | |||
3587 | /* | 3652 | /* |
3588 | * work on completed aio dio IO, to convert unwritten extents to extents | 3653 | * work on completed aio dio IO, to convert unwritten extents to extents |
3589 | */ | 3654 | */ |
3590 | static void ext4_end_aio_dio_work(struct work_struct *work) | 3655 | static void ext4_end_io_work(struct work_struct *work) |
3591 | { | 3656 | { |
3592 | ext4_io_end_t *io = container_of(work, ext4_io_end_t, work); | 3657 | ext4_io_end_t *io = container_of(work, ext4_io_end_t, work); |
3593 | struct inode *inode = io->inode; | 3658 | struct inode *inode = io->inode; |
3594 | int ret = 0; | 3659 | struct ext4_inode_info *ei = EXT4_I(inode); |
3660 | unsigned long flags; | ||
3661 | int ret; | ||
3595 | 3662 | ||
3596 | mutex_lock(&inode->i_mutex); | 3663 | mutex_lock(&inode->i_mutex); |
3597 | ret = ext4_end_aio_dio_nolock(io); | 3664 | ret = ext4_end_io_nolock(io); |
3598 | if (ret >= 0) { | 3665 | if (ret < 0) { |
3599 | if (!list_empty(&io->list)) | 3666 | mutex_unlock(&inode->i_mutex); |
3600 | list_del_init(&io->list); | 3667 | return; |
3601 | ext4_free_io_end(io); | ||
3602 | } | 3668 | } |
3669 | |||
3670 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); | ||
3671 | if (!list_empty(&io->list)) | ||
3672 | list_del_init(&io->list); | ||
3673 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3603 | mutex_unlock(&inode->i_mutex); | 3674 | mutex_unlock(&inode->i_mutex); |
3675 | ext4_free_io_end(io); | ||
3604 | } | 3676 | } |
3677 | |||
3605 | /* | 3678 | /* |
3606 | * This function is called from ext4_sync_file(). | 3679 | * This function is called from ext4_sync_file(). |
3607 | * | 3680 | * |
3608 | * When AIO DIO IO is completed, the work to convert unwritten | 3681 | * When IO is completed, the work to convert unwritten extents to |
3609 | * extents to written is queued on workqueue but may not get immediately | 3682 | * written is queued on workqueue but may not get immediately |
3610 | * scheduled. When fsync is called, we need to ensure the | 3683 | * scheduled. When fsync is called, we need to ensure the |
3611 | * conversion is complete before fsync returns. | 3684 | * conversion is complete before fsync returns. |
3612 | * The inode keeps track of a list of completed AIO from DIO path | 3685 | * The inode keeps track of a list of pending/completed IO that |
3613 | * that might needs to do the conversion. This function walks through | 3686 | * might needs to do the conversion. This function walks through |
3614 | * the list and convert the related unwritten extents to written. | 3687 | * the list and convert the related unwritten extents for completed IO |
3688 | * to written. | ||
3689 | * The function return the number of pending IOs on success. | ||
3615 | */ | 3690 | */ |
3616 | int flush_aio_dio_completed_IO(struct inode *inode) | 3691 | int flush_completed_IO(struct inode *inode) |
3617 | { | 3692 | { |
3618 | ext4_io_end_t *io; | 3693 | ext4_io_end_t *io; |
3694 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
3695 | unsigned long flags; | ||
3619 | int ret = 0; | 3696 | int ret = 0; |
3620 | int ret2 = 0; | 3697 | int ret2 = 0; |
3621 | 3698 | ||
3622 | if (list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)) | 3699 | if (list_empty(&ei->i_completed_io_list)) |
3623 | return ret; | 3700 | return ret; |
3624 | 3701 | ||
3625 | dump_aio_dio_list(inode); | 3702 | dump_completed_IO(inode); |
3626 | while (!list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)){ | 3703 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); |
3627 | io = list_entry(EXT4_I(inode)->i_aio_dio_complete_list.next, | 3704 | while (!list_empty(&ei->i_completed_io_list)){ |
3705 | io = list_entry(ei->i_completed_io_list.next, | ||
3628 | ext4_io_end_t, list); | 3706 | ext4_io_end_t, list); |
3629 | /* | 3707 | /* |
3630 | * Calling ext4_end_aio_dio_nolock() to convert completed | 3708 | * Calling ext4_end_io_nolock() to convert completed |
3631 | * IO to written. | 3709 | * IO to written. |
3632 | * | 3710 | * |
3633 | * When ext4_sync_file() is called, run_queue() may already | 3711 | * When ext4_sync_file() is called, run_queue() may already |
@@ -3640,20 +3718,23 @@ int flush_aio_dio_completed_IO(struct inode *inode) | |||
3640 | * avoid double converting from both fsync and background work | 3718 | * avoid double converting from both fsync and background work |
3641 | * queue work. | 3719 | * queue work. |
3642 | */ | 3720 | */ |
3643 | ret = ext4_end_aio_dio_nolock(io); | 3721 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); |
3722 | ret = ext4_end_io_nolock(io); | ||
3723 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); | ||
3644 | if (ret < 0) | 3724 | if (ret < 0) |
3645 | ret2 = ret; | 3725 | ret2 = ret; |
3646 | else | 3726 | else |
3647 | list_del_init(&io->list); | 3727 | list_del_init(&io->list); |
3648 | } | 3728 | } |
3729 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3649 | return (ret2 < 0) ? ret2 : 0; | 3730 | return (ret2 < 0) ? ret2 : 0; |
3650 | } | 3731 | } |
3651 | 3732 | ||
3652 | static ext4_io_end_t *ext4_init_io_end (struct inode *inode) | 3733 | static ext4_io_end_t *ext4_init_io_end (struct inode *inode, gfp_t flags) |
3653 | { | 3734 | { |
3654 | ext4_io_end_t *io = NULL; | 3735 | ext4_io_end_t *io = NULL; |
3655 | 3736 | ||
3656 | io = kmalloc(sizeof(*io), GFP_NOFS); | 3737 | io = kmalloc(sizeof(*io), flags); |
3657 | 3738 | ||
3658 | if (io) { | 3739 | if (io) { |
3659 | igrab(inode); | 3740 | igrab(inode); |
@@ -3661,8 +3742,8 @@ static ext4_io_end_t *ext4_init_io_end (struct inode *inode) | |||
3661 | io->flag = 0; | 3742 | io->flag = 0; |
3662 | io->offset = 0; | 3743 | io->offset = 0; |
3663 | io->size = 0; | 3744 | io->size = 0; |
3664 | io->error = 0; | 3745 | io->page = NULL; |
3665 | INIT_WORK(&io->work, ext4_end_aio_dio_work); | 3746 | INIT_WORK(&io->work, ext4_end_io_work); |
3666 | INIT_LIST_HEAD(&io->list); | 3747 | INIT_LIST_HEAD(&io->list); |
3667 | } | 3748 | } |
3668 | 3749 | ||
@@ -3674,6 +3755,8 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3674 | { | 3755 | { |
3675 | ext4_io_end_t *io_end = iocb->private; | 3756 | ext4_io_end_t *io_end = iocb->private; |
3676 | struct workqueue_struct *wq; | 3757 | struct workqueue_struct *wq; |
3758 | unsigned long flags; | ||
3759 | struct ext4_inode_info *ei; | ||
3677 | 3760 | ||
3678 | /* if not async direct IO or dio with 0 bytes write, just return */ | 3761 | /* if not async direct IO or dio with 0 bytes write, just return */ |
3679 | if (!io_end || !size) | 3762 | if (!io_end || !size) |
@@ -3685,7 +3768,7 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3685 | size); | 3768 | size); |
3686 | 3769 | ||
3687 | /* if not aio dio with unwritten extents, just free io and return */ | 3770 | /* if not aio dio with unwritten extents, just free io and return */ |
3688 | if (io_end->flag != DIO_AIO_UNWRITTEN){ | 3771 | if (io_end->flag != EXT4_IO_UNWRITTEN){ |
3689 | ext4_free_io_end(io_end); | 3772 | ext4_free_io_end(io_end); |
3690 | iocb->private = NULL; | 3773 | iocb->private = NULL; |
3691 | return; | 3774 | return; |
@@ -3693,16 +3776,85 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3693 | 3776 | ||
3694 | io_end->offset = offset; | 3777 | io_end->offset = offset; |
3695 | io_end->size = size; | 3778 | io_end->size = size; |
3779 | io_end->flag = EXT4_IO_UNWRITTEN; | ||
3696 | wq = EXT4_SB(io_end->inode->i_sb)->dio_unwritten_wq; | 3780 | wq = EXT4_SB(io_end->inode->i_sb)->dio_unwritten_wq; |
3697 | 3781 | ||
3698 | /* queue the work to convert unwritten extents to written */ | 3782 | /* queue the work to convert unwritten extents to written */ |
3699 | queue_work(wq, &io_end->work); | 3783 | queue_work(wq, &io_end->work); |
3700 | 3784 | ||
3701 | /* Add the io_end to per-inode completed aio dio list*/ | 3785 | /* Add the io_end to per-inode completed aio dio list*/ |
3702 | list_add_tail(&io_end->list, | 3786 | ei = EXT4_I(io_end->inode); |
3703 | &EXT4_I(io_end->inode)->i_aio_dio_complete_list); | 3787 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); |
3788 | list_add_tail(&io_end->list, &ei->i_completed_io_list); | ||
3789 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3704 | iocb->private = NULL; | 3790 | iocb->private = NULL; |
3705 | } | 3791 | } |
3792 | |||
3793 | static void ext4_end_io_buffer_write(struct buffer_head *bh, int uptodate) | ||
3794 | { | ||
3795 | ext4_io_end_t *io_end = bh->b_private; | ||
3796 | struct workqueue_struct *wq; | ||
3797 | struct inode *inode; | ||
3798 | unsigned long flags; | ||
3799 | |||
3800 | if (!test_clear_buffer_uninit(bh) || !io_end) | ||
3801 | goto out; | ||
3802 | |||
3803 | if (!(io_end->inode->i_sb->s_flags & MS_ACTIVE)) { | ||
3804 | printk("sb umounted, discard end_io request for inode %lu\n", | ||
3805 | io_end->inode->i_ino); | ||
3806 | ext4_free_io_end(io_end); | ||
3807 | goto out; | ||
3808 | } | ||
3809 | |||
3810 | io_end->flag = EXT4_IO_UNWRITTEN; | ||
3811 | inode = io_end->inode; | ||
3812 | |||
3813 | /* Add the io_end to per-inode completed io list*/ | ||
3814 | spin_lock_irqsave(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3815 | list_add_tail(&io_end->list, &EXT4_I(inode)->i_completed_io_list); | ||
3816 | spin_unlock_irqrestore(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3817 | |||
3818 | wq = EXT4_SB(inode->i_sb)->dio_unwritten_wq; | ||
3819 | /* queue the work to convert unwritten extents to written */ | ||
3820 | queue_work(wq, &io_end->work); | ||
3821 | out: | ||
3822 | bh->b_private = NULL; | ||
3823 | bh->b_end_io = NULL; | ||
3824 | clear_buffer_uninit(bh); | ||
3825 | end_buffer_async_write(bh, uptodate); | ||
3826 | } | ||
3827 | |||
3828 | static int ext4_set_bh_endio(struct buffer_head *bh, struct inode *inode) | ||
3829 | { | ||
3830 | ext4_io_end_t *io_end; | ||
3831 | struct page *page = bh->b_page; | ||
3832 | loff_t offset = (sector_t)page->index << PAGE_CACHE_SHIFT; | ||
3833 | size_t size = bh->b_size; | ||
3834 | |||
3835 | retry: | ||
3836 | io_end = ext4_init_io_end(inode, GFP_ATOMIC); | ||
3837 | if (!io_end) { | ||
3838 | if (printk_ratelimit()) | ||
3839 | printk(KERN_WARNING "%s: allocation fail\n", __func__); | ||
3840 | schedule(); | ||
3841 | goto retry; | ||
3842 | } | ||
3843 | io_end->offset = offset; | ||
3844 | io_end->size = size; | ||
3845 | /* | ||
3846 | * We need to hold a reference to the page to make sure it | ||
3847 | * doesn't get evicted before ext4_end_io_work() has a chance | ||
3848 | * to convert the extent from written to unwritten. | ||
3849 | */ | ||
3850 | io_end->page = page; | ||
3851 | get_page(io_end->page); | ||
3852 | |||
3853 | bh->b_private = io_end; | ||
3854 | bh->b_end_io = ext4_end_io_buffer_write; | ||
3855 | return 0; | ||
3856 | } | ||
3857 | |||
3706 | /* | 3858 | /* |
3707 | * For ext4 extent files, ext4 will do direct-io write to holes, | 3859 | * For ext4 extent files, ext4 will do direct-io write to holes, |
3708 | * preallocated extents, and those write extend the file, no need to | 3860 | * preallocated extents, and those write extend the file, no need to |
@@ -3756,7 +3908,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3756 | iocb->private = NULL; | 3908 | iocb->private = NULL; |
3757 | EXT4_I(inode)->cur_aio_dio = NULL; | 3909 | EXT4_I(inode)->cur_aio_dio = NULL; |
3758 | if (!is_sync_kiocb(iocb)) { | 3910 | if (!is_sync_kiocb(iocb)) { |
3759 | iocb->private = ext4_init_io_end(inode); | 3911 | iocb->private = ext4_init_io_end(inode, GFP_NOFS); |
3760 | if (!iocb->private) | 3912 | if (!iocb->private) |
3761 | return -ENOMEM; | 3913 | return -ENOMEM; |
3762 | /* | 3914 | /* |
@@ -3772,7 +3924,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3772 | ret = blockdev_direct_IO(rw, iocb, inode, | 3924 | ret = blockdev_direct_IO(rw, iocb, inode, |
3773 | inode->i_sb->s_bdev, iov, | 3925 | inode->i_sb->s_bdev, iov, |
3774 | offset, nr_segs, | 3926 | offset, nr_segs, |
3775 | ext4_get_block_dio_write, | 3927 | ext4_get_block_write, |
3776 | ext4_end_io_dio); | 3928 | ext4_end_io_dio); |
3777 | if (iocb->private) | 3929 | if (iocb->private) |
3778 | EXT4_I(inode)->cur_aio_dio = NULL; | 3930 | EXT4_I(inode)->cur_aio_dio = NULL; |
@@ -3793,8 +3945,8 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3793 | if (ret != -EIOCBQUEUED && ret <= 0 && iocb->private) { | 3945 | if (ret != -EIOCBQUEUED && ret <= 0 && iocb->private) { |
3794 | ext4_free_io_end(iocb->private); | 3946 | ext4_free_io_end(iocb->private); |
3795 | iocb->private = NULL; | 3947 | iocb->private = NULL; |
3796 | } else if (ret > 0 && (EXT4_I(inode)->i_state & | 3948 | } else if (ret > 0 && ext4_test_inode_state(inode, |
3797 | EXT4_STATE_DIO_UNWRITTEN)) { | 3949 | EXT4_STATE_DIO_UNWRITTEN)) { |
3798 | int err; | 3950 | int err; |
3799 | /* | 3951 | /* |
3800 | * for non AIO case, since the IO is already | 3952 | * for non AIO case, since the IO is already |
@@ -3804,7 +3956,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3804 | offset, ret); | 3956 | offset, ret); |
3805 | if (err < 0) | 3957 | if (err < 0) |
3806 | ret = err; | 3958 | ret = err; |
3807 | EXT4_I(inode)->i_state &= ~EXT4_STATE_DIO_UNWRITTEN; | 3959 | ext4_clear_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN); |
3808 | } | 3960 | } |
3809 | return ret; | 3961 | return ret; |
3810 | } | 3962 | } |
@@ -4135,18 +4287,27 @@ no_top: | |||
4135 | * We release `count' blocks on disk, but (last - first) may be greater | 4287 | * We release `count' blocks on disk, but (last - first) may be greater |
4136 | * than `count' because there can be holes in there. | 4288 | * than `count' because there can be holes in there. |
4137 | */ | 4289 | */ |
4138 | static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | 4290 | static int ext4_clear_blocks(handle_t *handle, struct inode *inode, |
4139 | struct buffer_head *bh, | 4291 | struct buffer_head *bh, |
4140 | ext4_fsblk_t block_to_free, | 4292 | ext4_fsblk_t block_to_free, |
4141 | unsigned long count, __le32 *first, | 4293 | unsigned long count, __le32 *first, |
4142 | __le32 *last) | 4294 | __le32 *last) |
4143 | { | 4295 | { |
4144 | __le32 *p; | 4296 | __le32 *p; |
4145 | int flags = EXT4_FREE_BLOCKS_FORGET; | 4297 | int flags = EXT4_FREE_BLOCKS_FORGET | EXT4_FREE_BLOCKS_VALIDATED; |
4146 | 4298 | ||
4147 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) | 4299 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) |
4148 | flags |= EXT4_FREE_BLOCKS_METADATA; | 4300 | flags |= EXT4_FREE_BLOCKS_METADATA; |
4149 | 4301 | ||
4302 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), block_to_free, | ||
4303 | count)) { | ||
4304 | ext4_error(inode->i_sb, "inode #%lu: " | ||
4305 | "attempt to clear blocks %llu len %lu, invalid", | ||
4306 | inode->i_ino, (unsigned long long) block_to_free, | ||
4307 | count); | ||
4308 | return 1; | ||
4309 | } | ||
4310 | |||
4150 | if (try_to_extend_transaction(handle, inode)) { | 4311 | if (try_to_extend_transaction(handle, inode)) { |
4151 | if (bh) { | 4312 | if (bh) { |
4152 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); | 4313 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); |
@@ -4165,6 +4326,7 @@ static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | |||
4165 | *p = 0; | 4326 | *p = 0; |
4166 | 4327 | ||
4167 | ext4_free_blocks(handle, inode, 0, block_to_free, count, flags); | 4328 | ext4_free_blocks(handle, inode, 0, block_to_free, count, flags); |
4329 | return 0; | ||
4168 | } | 4330 | } |
4169 | 4331 | ||
4170 | /** | 4332 | /** |
@@ -4220,9 +4382,10 @@ static void ext4_free_data(handle_t *handle, struct inode *inode, | |||
4220 | } else if (nr == block_to_free + count) { | 4382 | } else if (nr == block_to_free + count) { |
4221 | count++; | 4383 | count++; |
4222 | } else { | 4384 | } else { |
4223 | ext4_clear_blocks(handle, inode, this_bh, | 4385 | if (ext4_clear_blocks(handle, inode, this_bh, |
4224 | block_to_free, | 4386 | block_to_free, count, |
4225 | count, block_to_free_p, p); | 4387 | block_to_free_p, p)) |
4388 | break; | ||
4226 | block_to_free = nr; | 4389 | block_to_free = nr; |
4227 | block_to_free_p = p; | 4390 | block_to_free_p = p; |
4228 | count = 1; | 4391 | count = 1; |
@@ -4246,7 +4409,7 @@ static void ext4_free_data(handle_t *handle, struct inode *inode, | |||
4246 | if ((EXT4_JOURNAL(inode) == NULL) || bh2jh(this_bh)) | 4409 | if ((EXT4_JOURNAL(inode) == NULL) || bh2jh(this_bh)) |
4247 | ext4_handle_dirty_metadata(handle, inode, this_bh); | 4410 | ext4_handle_dirty_metadata(handle, inode, this_bh); |
4248 | else | 4411 | else |
4249 | ext4_error(inode->i_sb, __func__, | 4412 | ext4_error(inode->i_sb, |
4250 | "circular indirect block detected, " | 4413 | "circular indirect block detected, " |
4251 | "inode=%lu, block=%llu", | 4414 | "inode=%lu, block=%llu", |
4252 | inode->i_ino, | 4415 | inode->i_ino, |
@@ -4286,6 +4449,16 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, | |||
4286 | if (!nr) | 4449 | if (!nr) |
4287 | continue; /* A hole */ | 4450 | continue; /* A hole */ |
4288 | 4451 | ||
4452 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), | ||
4453 | nr, 1)) { | ||
4454 | ext4_error(inode->i_sb, | ||
4455 | "indirect mapped block in inode " | ||
4456 | "#%lu invalid (level %d, blk #%lu)", | ||
4457 | inode->i_ino, depth, | ||
4458 | (unsigned long) nr); | ||
4459 | break; | ||
4460 | } | ||
4461 | |||
4289 | /* Go read the buffer for the next level down */ | 4462 | /* Go read the buffer for the next level down */ |
4290 | bh = sb_bread(inode->i_sb, nr); | 4463 | bh = sb_bread(inode->i_sb, nr); |
4291 | 4464 | ||
@@ -4294,7 +4467,7 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, | |||
4294 | * (should be rare). | 4467 | * (should be rare). |
4295 | */ | 4468 | */ |
4296 | if (!bh) { | 4469 | if (!bh) { |
4297 | ext4_error(inode->i_sb, "ext4_free_branches", | 4470 | ext4_error(inode->i_sb, |
4298 | "Read failure, inode=%lu, block=%llu", | 4471 | "Read failure, inode=%lu, block=%llu", |
4299 | inode->i_ino, nr); | 4472 | inode->i_ino, nr); |
4300 | continue; | 4473 | continue; |
@@ -4438,8 +4611,10 @@ void ext4_truncate(struct inode *inode) | |||
4438 | if (!ext4_can_truncate(inode)) | 4611 | if (!ext4_can_truncate(inode)) |
4439 | return; | 4612 | return; |
4440 | 4613 | ||
4614 | EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL; | ||
4615 | |||
4441 | if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC)) | 4616 | if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC)) |
4442 | ei->i_state |= EXT4_STATE_DA_ALLOC_CLOSE; | 4617 | ext4_set_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE); |
4443 | 4618 | ||
4444 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { | 4619 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { |
4445 | ext4_ext_truncate(inode); | 4620 | ext4_ext_truncate(inode); |
@@ -4609,9 +4784,8 @@ static int __ext4_get_inode_loc(struct inode *inode, | |||
4609 | 4784 | ||
4610 | bh = sb_getblk(sb, block); | 4785 | bh = sb_getblk(sb, block); |
4611 | if (!bh) { | 4786 | if (!bh) { |
4612 | ext4_error(sb, "ext4_get_inode_loc", "unable to read " | 4787 | ext4_error(sb, "unable to read inode block - " |
4613 | "inode block - inode=%lu, block=%llu", | 4788 | "inode=%lu, block=%llu", inode->i_ino, block); |
4614 | inode->i_ino, block); | ||
4615 | return -EIO; | 4789 | return -EIO; |
4616 | } | 4790 | } |
4617 | if (!buffer_uptodate(bh)) { | 4791 | if (!buffer_uptodate(bh)) { |
@@ -4709,9 +4883,8 @@ make_io: | |||
4709 | submit_bh(READ_META, bh); | 4883 | submit_bh(READ_META, bh); |
4710 | wait_on_buffer(bh); | 4884 | wait_on_buffer(bh); |
4711 | if (!buffer_uptodate(bh)) { | 4885 | if (!buffer_uptodate(bh)) { |
4712 | ext4_error(sb, __func__, | 4886 | ext4_error(sb, "unable to read inode block - inode=%lu," |
4713 | "unable to read inode block - inode=%lu, " | 4887 | " block=%llu", inode->i_ino, block); |
4714 | "block=%llu", inode->i_ino, block); | ||
4715 | brelse(bh); | 4888 | brelse(bh); |
4716 | return -EIO; | 4889 | return -EIO; |
4717 | } | 4890 | } |
@@ -4725,7 +4898,7 @@ int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc) | |||
4725 | { | 4898 | { |
4726 | /* We have all inode data except xattrs in memory here. */ | 4899 | /* We have all inode data except xattrs in memory here. */ |
4727 | return __ext4_get_inode_loc(inode, iloc, | 4900 | return __ext4_get_inode_loc(inode, iloc, |
4728 | !(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)); | 4901 | !ext4_test_inode_state(inode, EXT4_STATE_XATTR)); |
4729 | } | 4902 | } |
4730 | 4903 | ||
4731 | void ext4_set_inode_flags(struct inode *inode) | 4904 | void ext4_set_inode_flags(struct inode *inode) |
@@ -4819,7 +4992,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4819 | } | 4992 | } |
4820 | inode->i_nlink = le16_to_cpu(raw_inode->i_links_count); | 4993 | inode->i_nlink = le16_to_cpu(raw_inode->i_links_count); |
4821 | 4994 | ||
4822 | ei->i_state = 0; | 4995 | ei->i_state_flags = 0; |
4823 | ei->i_dir_start_lookup = 0; | 4996 | ei->i_dir_start_lookup = 0; |
4824 | ei->i_dtime = le32_to_cpu(raw_inode->i_dtime); | 4997 | ei->i_dtime = le32_to_cpu(raw_inode->i_dtime); |
4825 | /* We now have enough fields to check if the inode was active or not. | 4998 | /* We now have enough fields to check if the inode was active or not. |
@@ -4902,7 +5075,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4902 | EXT4_GOOD_OLD_INODE_SIZE + | 5075 | EXT4_GOOD_OLD_INODE_SIZE + |
4903 | ei->i_extra_isize; | 5076 | ei->i_extra_isize; |
4904 | if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) | 5077 | if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) |
4905 | ei->i_state |= EXT4_STATE_XATTR; | 5078 | ext4_set_inode_state(inode, EXT4_STATE_XATTR); |
4906 | } | 5079 | } |
4907 | } else | 5080 | } else |
4908 | ei->i_extra_isize = 0; | 5081 | ei->i_extra_isize = 0; |
@@ -4922,8 +5095,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4922 | ret = 0; | 5095 | ret = 0; |
4923 | if (ei->i_file_acl && | 5096 | if (ei->i_file_acl && |
4924 | !ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) { | 5097 | !ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) { |
4925 | ext4_error(sb, __func__, | 5098 | ext4_error(sb, "bad extended attribute block %llu inode #%lu", |
4926 | "bad extended attribute block %llu in inode #%lu", | ||
4927 | ei->i_file_acl, inode->i_ino); | 5099 | ei->i_file_acl, inode->i_ino); |
4928 | ret = -EIO; | 5100 | ret = -EIO; |
4929 | goto bad_inode; | 5101 | goto bad_inode; |
@@ -4969,8 +5141,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4969 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); | 5141 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); |
4970 | } else { | 5142 | } else { |
4971 | ret = -EIO; | 5143 | ret = -EIO; |
4972 | ext4_error(inode->i_sb, __func__, | 5144 | ext4_error(inode->i_sb, "bogus i_mode (%o) for inode=%lu", |
4973 | "bogus i_mode (%o) for inode=%lu", | ||
4974 | inode->i_mode, inode->i_ino); | 5145 | inode->i_mode, inode->i_ino); |
4975 | goto bad_inode; | 5146 | goto bad_inode; |
4976 | } | 5147 | } |
@@ -5042,7 +5213,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5042 | 5213 | ||
5043 | /* For fields not not tracking in the in-memory inode, | 5214 | /* For fields not not tracking in the in-memory inode, |
5044 | * initialise them to zero for new inodes. */ | 5215 | * initialise them to zero for new inodes. */ |
5045 | if (ei->i_state & EXT4_STATE_NEW) | 5216 | if (ext4_test_inode_state(inode, EXT4_STATE_NEW)) |
5046 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); | 5217 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); |
5047 | 5218 | ||
5048 | ext4_get_inode_flags(ei); | 5219 | ext4_get_inode_flags(ei); |
@@ -5106,7 +5277,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5106 | EXT4_FEATURE_RO_COMPAT_LARGE_FILE); | 5277 | EXT4_FEATURE_RO_COMPAT_LARGE_FILE); |
5107 | sb->s_dirt = 1; | 5278 | sb->s_dirt = 1; |
5108 | ext4_handle_sync(handle); | 5279 | ext4_handle_sync(handle); |
5109 | err = ext4_handle_dirty_metadata(handle, inode, | 5280 | err = ext4_handle_dirty_metadata(handle, NULL, |
5110 | EXT4_SB(sb)->s_sbh); | 5281 | EXT4_SB(sb)->s_sbh); |
5111 | } | 5282 | } |
5112 | } | 5283 | } |
@@ -5135,10 +5306,10 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5135 | } | 5306 | } |
5136 | 5307 | ||
5137 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); | 5308 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); |
5138 | rc = ext4_handle_dirty_metadata(handle, inode, bh); | 5309 | rc = ext4_handle_dirty_metadata(handle, NULL, bh); |
5139 | if (!err) | 5310 | if (!err) |
5140 | err = rc; | 5311 | err = rc; |
5141 | ei->i_state &= ~EXT4_STATE_NEW; | 5312 | ext4_clear_inode_state(inode, EXT4_STATE_NEW); |
5142 | 5313 | ||
5143 | ext4_update_inode_fsync_trans(handle, inode, 0); | 5314 | ext4_update_inode_fsync_trans(handle, inode, 0); |
5144 | out_brelse: | 5315 | out_brelse: |
@@ -5182,7 +5353,7 @@ out_brelse: | |||
5182 | * `stuff()' is running, and the new i_size will be lost. Plus the inode | 5353 | * `stuff()' is running, and the new i_size will be lost. Plus the inode |
5183 | * will no longer be on the superblock's dirty inode list. | 5354 | * will no longer be on the superblock's dirty inode list. |
5184 | */ | 5355 | */ |
5185 | int ext4_write_inode(struct inode *inode, int wait) | 5356 | int ext4_write_inode(struct inode *inode, struct writeback_control *wbc) |
5186 | { | 5357 | { |
5187 | int err; | 5358 | int err; |
5188 | 5359 | ||
@@ -5196,7 +5367,7 @@ int ext4_write_inode(struct inode *inode, int wait) | |||
5196 | return -EIO; | 5367 | return -EIO; |
5197 | } | 5368 | } |
5198 | 5369 | ||
5199 | if (!wait) | 5370 | if (wbc->sync_mode != WB_SYNC_ALL) |
5200 | return 0; | 5371 | return 0; |
5201 | 5372 | ||
5202 | err = ext4_force_commit(inode->i_sb); | 5373 | err = ext4_force_commit(inode->i_sb); |
@@ -5206,13 +5377,11 @@ int ext4_write_inode(struct inode *inode, int wait) | |||
5206 | err = ext4_get_inode_loc(inode, &iloc); | 5377 | err = ext4_get_inode_loc(inode, &iloc); |
5207 | if (err) | 5378 | if (err) |
5208 | return err; | 5379 | return err; |
5209 | if (wait) | 5380 | if (wbc->sync_mode == WB_SYNC_ALL) |
5210 | sync_dirty_buffer(iloc.bh); | 5381 | sync_dirty_buffer(iloc.bh); |
5211 | if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) { | 5382 | if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) { |
5212 | ext4_error(inode->i_sb, __func__, | 5383 | ext4_error(inode->i_sb, "IO error syncing inode, " |
5213 | "IO error syncing inode, " | 5384 | "inode=%lu, block=%llu", inode->i_ino, |
5214 | "inode=%lu, block=%llu", | ||
5215 | inode->i_ino, | ||
5216 | (unsigned long long)iloc.bh->b_blocknr); | 5385 | (unsigned long long)iloc.bh->b_blocknr); |
5217 | err = -EIO; | 5386 | err = -EIO; |
5218 | } | 5387 | } |
@@ -5295,7 +5464,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5295 | } | 5464 | } |
5296 | 5465 | ||
5297 | if (S_ISREG(inode->i_mode) && | 5466 | if (S_ISREG(inode->i_mode) && |
5298 | attr->ia_valid & ATTR_SIZE && attr->ia_size < inode->i_size) { | 5467 | attr->ia_valid & ATTR_SIZE && |
5468 | (attr->ia_size < inode->i_size || | ||
5469 | (EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL))) { | ||
5299 | handle_t *handle; | 5470 | handle_t *handle; |
5300 | 5471 | ||
5301 | handle = ext4_journal_start(inode, 3); | 5472 | handle = ext4_journal_start(inode, 3); |
@@ -5326,6 +5497,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5326 | goto err_out; | 5497 | goto err_out; |
5327 | } | 5498 | } |
5328 | } | 5499 | } |
5500 | /* ext4_truncate will clear the flag */ | ||
5501 | if ((EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL)) | ||
5502 | ext4_truncate(inode); | ||
5329 | } | 5503 | } |
5330 | 5504 | ||
5331 | rc = inode_setattr(inode, attr); | 5505 | rc = inode_setattr(inode, attr); |
@@ -5564,8 +5738,8 @@ static int ext4_expand_extra_isize(struct inode *inode, | |||
5564 | entry = IFIRST(header); | 5738 | entry = IFIRST(header); |
5565 | 5739 | ||
5566 | /* No extended attributes present */ | 5740 | /* No extended attributes present */ |
5567 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR) || | 5741 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR) || |
5568 | header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) { | 5742 | header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) { |
5569 | memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE, 0, | 5743 | memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE, 0, |
5570 | new_extra_isize); | 5744 | new_extra_isize); |
5571 | EXT4_I(inode)->i_extra_isize = new_extra_isize; | 5745 | EXT4_I(inode)->i_extra_isize = new_extra_isize; |
@@ -5609,7 +5783,7 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
5609 | err = ext4_reserve_inode_write(handle, inode, &iloc); | 5783 | err = ext4_reserve_inode_write(handle, inode, &iloc); |
5610 | if (ext4_handle_valid(handle) && | 5784 | if (ext4_handle_valid(handle) && |
5611 | EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize && | 5785 | EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize && |
5612 | !(EXT4_I(inode)->i_state & EXT4_STATE_NO_EXPAND)) { | 5786 | !ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND)) { |
5613 | /* | 5787 | /* |
5614 | * We need extra buffer credits since we may write into EA block | 5788 | * We need extra buffer credits since we may write into EA block |
5615 | * with this same handle. If journal_extend fails, then it will | 5789 | * with this same handle. If journal_extend fails, then it will |
@@ -5623,10 +5797,11 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
5623 | sbi->s_want_extra_isize, | 5797 | sbi->s_want_extra_isize, |
5624 | iloc, handle); | 5798 | iloc, handle); |
5625 | if (ret) { | 5799 | if (ret) { |
5626 | EXT4_I(inode)->i_state |= EXT4_STATE_NO_EXPAND; | 5800 | ext4_set_inode_state(inode, |
5801 | EXT4_STATE_NO_EXPAND); | ||
5627 | if (mnt_count != | 5802 | if (mnt_count != |
5628 | le16_to_cpu(sbi->s_es->s_mnt_count)) { | 5803 | le16_to_cpu(sbi->s_es->s_mnt_count)) { |
5629 | ext4_warning(inode->i_sb, __func__, | 5804 | ext4_warning(inode->i_sb, |
5630 | "Unable to expand inode %lu. Delete" | 5805 | "Unable to expand inode %lu. Delete" |
5631 | " some EAs or run e2fsck.", | 5806 | " some EAs or run e2fsck.", |
5632 | inode->i_ino); | 5807 | inode->i_ino); |
@@ -5690,7 +5865,7 @@ static int ext4_pin_inode(handle_t *handle, struct inode *inode) | |||
5690 | err = jbd2_journal_get_write_access(handle, iloc.bh); | 5865 | err = jbd2_journal_get_write_access(handle, iloc.bh); |
5691 | if (!err) | 5866 | if (!err) |
5692 | err = ext4_handle_dirty_metadata(handle, | 5867 | err = ext4_handle_dirty_metadata(handle, |
5693 | inode, | 5868 | NULL, |
5694 | iloc.bh); | 5869 | iloc.bh); |
5695 | brelse(iloc.bh); | 5870 | brelse(iloc.bh); |
5696 | } | 5871 | } |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index b63d193126db..016d0249294f 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
@@ -92,6 +92,15 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
92 | flags &= ~EXT4_EXTENTS_FL; | 92 | flags &= ~EXT4_EXTENTS_FL; |
93 | } | 93 | } |
94 | 94 | ||
95 | if (flags & EXT4_EOFBLOCKS_FL) { | ||
96 | /* we don't support adding EOFBLOCKS flag */ | ||
97 | if (!(oldflags & EXT4_EOFBLOCKS_FL)) { | ||
98 | err = -EOPNOTSUPP; | ||
99 | goto flags_out; | ||
100 | } | ||
101 | } else if (oldflags & EXT4_EOFBLOCKS_FL) | ||
102 | ext4_truncate(inode); | ||
103 | |||
95 | handle = ext4_journal_start(inode, 1); | 104 | handle = ext4_journal_start(inode, 1); |
96 | if (IS_ERR(handle)) { | 105 | if (IS_ERR(handle)) { |
97 | err = PTR_ERR(handle); | 106 | err = PTR_ERR(handle); |
@@ -249,7 +258,8 @@ setversion_out: | |||
249 | if (me.moved_len > 0) | 258 | if (me.moved_len > 0) |
250 | file_remove_suid(donor_filp); | 259 | file_remove_suid(donor_filp); |
251 | 260 | ||
252 | if (copy_to_user((struct move_extent *)arg, &me, sizeof(me))) | 261 | if (copy_to_user((struct move_extent __user *)arg, |
262 | &me, sizeof(me))) | ||
253 | err = -EFAULT; | 263 | err = -EFAULT; |
254 | mext_out: | 264 | mext_out: |
255 | fput(donor_filp); | 265 | fput(donor_filp); |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 0b905781e8e6..506713a2ebd8 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -441,10 +441,9 @@ static void mb_free_blocks_double(struct inode *inode, struct ext4_buddy *e4b, | |||
441 | for (i = 0; i < count; i++) { | 441 | for (i = 0; i < count; i++) { |
442 | if (!mb_test_bit(first + i, e4b->bd_info->bb_bitmap)) { | 442 | if (!mb_test_bit(first + i, e4b->bd_info->bb_bitmap)) { |
443 | ext4_fsblk_t blocknr; | 443 | ext4_fsblk_t blocknr; |
444 | blocknr = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb); | 444 | |
445 | blocknr = ext4_group_first_block_no(sb, e4b->bd_group); | ||
445 | blocknr += first + i; | 446 | blocknr += first + i; |
446 | blocknr += | ||
447 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
448 | ext4_grp_locked_error(sb, e4b->bd_group, | 447 | ext4_grp_locked_error(sb, e4b->bd_group, |
449 | __func__, "double-free of inode" | 448 | __func__, "double-free of inode" |
450 | " %lu's block %llu(bit %u in group %u)", | 449 | " %lu's block %llu(bit %u in group %u)", |
@@ -1255,10 +1254,9 @@ static void mb_free_blocks(struct inode *inode, struct ext4_buddy *e4b, | |||
1255 | 1254 | ||
1256 | if (!mb_test_bit(block, EXT4_MB_BITMAP(e4b))) { | 1255 | if (!mb_test_bit(block, EXT4_MB_BITMAP(e4b))) { |
1257 | ext4_fsblk_t blocknr; | 1256 | ext4_fsblk_t blocknr; |
1258 | blocknr = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb); | 1257 | |
1258 | blocknr = ext4_group_first_block_no(sb, e4b->bd_group); | ||
1259 | blocknr += block; | 1259 | blocknr += block; |
1260 | blocknr += | ||
1261 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
1262 | ext4_grp_locked_error(sb, e4b->bd_group, | 1260 | ext4_grp_locked_error(sb, e4b->bd_group, |
1263 | __func__, "double-free of inode" | 1261 | __func__, "double-free of inode" |
1264 | " %lu's block %llu(bit %u in group %u)", | 1262 | " %lu's block %llu(bit %u in group %u)", |
@@ -1631,7 +1629,6 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, | |||
1631 | int max; | 1629 | int max; |
1632 | int err; | 1630 | int err; |
1633 | struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); | 1631 | struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); |
1634 | struct ext4_super_block *es = sbi->s_es; | ||
1635 | struct ext4_free_extent ex; | 1632 | struct ext4_free_extent ex; |
1636 | 1633 | ||
1637 | if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) | 1634 | if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) |
@@ -1648,8 +1645,8 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, | |||
1648 | if (max >= ac->ac_g_ex.fe_len && ac->ac_g_ex.fe_len == sbi->s_stripe) { | 1645 | if (max >= ac->ac_g_ex.fe_len && ac->ac_g_ex.fe_len == sbi->s_stripe) { |
1649 | ext4_fsblk_t start; | 1646 | ext4_fsblk_t start; |
1650 | 1647 | ||
1651 | start = (e4b->bd_group * EXT4_BLOCKS_PER_GROUP(ac->ac_sb)) + | 1648 | start = ext4_group_first_block_no(ac->ac_sb, e4b->bd_group) + |
1652 | ex.fe_start + le32_to_cpu(es->s_first_data_block); | 1649 | ex.fe_start; |
1653 | /* use do_div to get remainder (would be 64-bit modulo) */ | 1650 | /* use do_div to get remainder (would be 64-bit modulo) */ |
1654 | if (do_div(start, sbi->s_stripe) == 0) { | 1651 | if (do_div(start, sbi->s_stripe) == 0) { |
1655 | ac->ac_found++; | 1652 | ac->ac_found++; |
@@ -1803,8 +1800,8 @@ void ext4_mb_scan_aligned(struct ext4_allocation_context *ac, | |||
1803 | BUG_ON(sbi->s_stripe == 0); | 1800 | BUG_ON(sbi->s_stripe == 0); |
1804 | 1801 | ||
1805 | /* find first stripe-aligned block in group */ | 1802 | /* find first stripe-aligned block in group */ |
1806 | first_group_block = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb) | 1803 | first_group_block = ext4_group_first_block_no(sb, e4b->bd_group); |
1807 | + le32_to_cpu(sbi->s_es->s_first_data_block); | 1804 | |
1808 | a = first_group_block + sbi->s_stripe - 1; | 1805 | a = first_group_block + sbi->s_stripe - 1; |
1809 | do_div(a, sbi->s_stripe); | 1806 | do_div(a, sbi->s_stripe); |
1810 | i = (a * sbi->s_stripe) - first_group_block; | 1807 | i = (a * sbi->s_stripe) - first_group_block; |
@@ -2256,7 +2253,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, | |||
2256 | 2253 | ||
2257 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); | 2254 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); |
2258 | init_rwsem(&meta_group_info[i]->alloc_sem); | 2255 | init_rwsem(&meta_group_info[i]->alloc_sem); |
2259 | meta_group_info[i]->bb_free_root.rb_node = NULL; | 2256 | meta_group_info[i]->bb_free_root = RB_ROOT; |
2260 | 2257 | ||
2261 | #ifdef DOUBLE_CHECK | 2258 | #ifdef DOUBLE_CHECK |
2262 | { | 2259 | { |
@@ -2560,12 +2557,9 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) | |||
2560 | ext4_unlock_group(sb, entry->group); | 2557 | ext4_unlock_group(sb, entry->group); |
2561 | if (test_opt(sb, DISCARD)) { | 2558 | if (test_opt(sb, DISCARD)) { |
2562 | ext4_fsblk_t discard_block; | 2559 | ext4_fsblk_t discard_block; |
2563 | struct ext4_super_block *es = EXT4_SB(sb)->s_es; | ||
2564 | 2560 | ||
2565 | discard_block = (ext4_fsblk_t)entry->group * | 2561 | discard_block = entry->start_blk + |
2566 | EXT4_BLOCKS_PER_GROUP(sb) | 2562 | ext4_group_first_block_no(sb, entry->group); |
2567 | + entry->start_blk | ||
2568 | + le32_to_cpu(es->s_first_data_block); | ||
2569 | trace_ext4_discard_blocks(sb, | 2563 | trace_ext4_discard_blocks(sb, |
2570 | (unsigned long long)discard_block, | 2564 | (unsigned long long)discard_block, |
2571 | entry->count); | 2565 | entry->count); |
@@ -2703,14 +2697,11 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, | |||
2703 | if (err) | 2697 | if (err) |
2704 | goto out_err; | 2698 | goto out_err; |
2705 | 2699 | ||
2706 | block = ac->ac_b_ex.fe_group * EXT4_BLOCKS_PER_GROUP(sb) | 2700 | block = ext4_grp_offs_to_block(sb, &ac->ac_b_ex); |
2707 | + ac->ac_b_ex.fe_start | ||
2708 | + le32_to_cpu(es->s_first_data_block); | ||
2709 | 2701 | ||
2710 | len = ac->ac_b_ex.fe_len; | 2702 | len = ac->ac_b_ex.fe_len; |
2711 | if (!ext4_data_block_valid(sbi, block, len)) { | 2703 | if (!ext4_data_block_valid(sbi, block, len)) { |
2712 | ext4_error(sb, __func__, | 2704 | ext4_error(sb, "Allocating blocks %llu-%llu which overlap " |
2713 | "Allocating blocks %llu-%llu which overlap " | ||
2714 | "fs metadata\n", block, block+len); | 2705 | "fs metadata\n", block, block+len); |
2715 | /* File system mounted not to panic on error | 2706 | /* File system mounted not to panic on error |
2716 | * Fix the bitmap and repeat the block allocation | 2707 | * Fix the bitmap and repeat the block allocation |
@@ -3161,9 +3152,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac) | |||
3161 | /* The max size of hash table is PREALLOC_TB_SIZE */ | 3152 | /* The max size of hash table is PREALLOC_TB_SIZE */ |
3162 | order = PREALLOC_TB_SIZE - 1; | 3153 | order = PREALLOC_TB_SIZE - 1; |
3163 | 3154 | ||
3164 | goal_block = ac->ac_g_ex.fe_group * EXT4_BLOCKS_PER_GROUP(ac->ac_sb) + | 3155 | goal_block = ext4_grp_offs_to_block(ac->ac_sb, &ac->ac_g_ex); |
3165 | ac->ac_g_ex.fe_start + | ||
3166 | le32_to_cpu(EXT4_SB(ac->ac_sb)->s_es->s_first_data_block); | ||
3167 | /* | 3156 | /* |
3168 | * search for the prealloc space that is having | 3157 | * search for the prealloc space that is having |
3169 | * minimal distance from the goal block. | 3158 | * minimal distance from the goal block. |
@@ -3526,8 +3515,7 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh, | |||
3526 | if (bit >= end) | 3515 | if (bit >= end) |
3527 | break; | 3516 | break; |
3528 | next = mb_find_next_bit(bitmap_bh->b_data, end, bit); | 3517 | next = mb_find_next_bit(bitmap_bh->b_data, end, bit); |
3529 | start = group * EXT4_BLOCKS_PER_GROUP(sb) + bit + | 3518 | start = ext4_group_first_block_no(sb, group) + bit; |
3530 | le32_to_cpu(sbi->s_es->s_first_data_block); | ||
3531 | mb_debug(1, " free preallocated %u/%u in group %u\n", | 3519 | mb_debug(1, " free preallocated %u/%u in group %u\n", |
3532 | (unsigned) start, (unsigned) next - bit, | 3520 | (unsigned) start, (unsigned) next - bit, |
3533 | (unsigned) group); | 3521 | (unsigned) group); |
@@ -3623,15 +3611,13 @@ ext4_mb_discard_group_preallocations(struct super_block *sb, | |||
3623 | 3611 | ||
3624 | bitmap_bh = ext4_read_block_bitmap(sb, group); | 3612 | bitmap_bh = ext4_read_block_bitmap(sb, group); |
3625 | if (bitmap_bh == NULL) { | 3613 | if (bitmap_bh == NULL) { |
3626 | ext4_error(sb, __func__, "Error in reading block " | 3614 | ext4_error(sb, "Error reading block bitmap for %u", group); |
3627 | "bitmap for %u", group); | ||
3628 | return 0; | 3615 | return 0; |
3629 | } | 3616 | } |
3630 | 3617 | ||
3631 | err = ext4_mb_load_buddy(sb, group, &e4b); | 3618 | err = ext4_mb_load_buddy(sb, group, &e4b); |
3632 | if (err) { | 3619 | if (err) { |
3633 | ext4_error(sb, __func__, "Error in loading buddy " | 3620 | ext4_error(sb, "Error loading buddy information for %u", group); |
3634 | "information for %u", group); | ||
3635 | put_bh(bitmap_bh); | 3621 | put_bh(bitmap_bh); |
3636 | return 0; | 3622 | return 0; |
3637 | } | 3623 | } |
@@ -3804,15 +3790,15 @@ repeat: | |||
3804 | 3790 | ||
3805 | err = ext4_mb_load_buddy(sb, group, &e4b); | 3791 | err = ext4_mb_load_buddy(sb, group, &e4b); |
3806 | if (err) { | 3792 | if (err) { |
3807 | ext4_error(sb, __func__, "Error in loading buddy " | 3793 | ext4_error(sb, "Error loading buddy information for %u", |
3808 | "information for %u", group); | 3794 | group); |
3809 | continue; | 3795 | continue; |
3810 | } | 3796 | } |
3811 | 3797 | ||
3812 | bitmap_bh = ext4_read_block_bitmap(sb, group); | 3798 | bitmap_bh = ext4_read_block_bitmap(sb, group); |
3813 | if (bitmap_bh == NULL) { | 3799 | if (bitmap_bh == NULL) { |
3814 | ext4_error(sb, __func__, "Error in reading block " | 3800 | ext4_error(sb, "Error reading block bitmap for %u", |
3815 | "bitmap for %u", group); | 3801 | group); |
3816 | ext4_mb_release_desc(&e4b); | 3802 | ext4_mb_release_desc(&e4b); |
3817 | continue; | 3803 | continue; |
3818 | } | 3804 | } |
@@ -3938,7 +3924,7 @@ static void ext4_mb_group_or_file(struct ext4_allocation_context *ac) | |||
3938 | 3924 | ||
3939 | /* don't use group allocation for large files */ | 3925 | /* don't use group allocation for large files */ |
3940 | size = max(size, isize); | 3926 | size = max(size, isize); |
3941 | if (size >= sbi->s_mb_stream_request) { | 3927 | if (size > sbi->s_mb_stream_request) { |
3942 | ac->ac_flags |= EXT4_MB_STREAM_ALLOC; | 3928 | ac->ac_flags |= EXT4_MB_STREAM_ALLOC; |
3943 | return; | 3929 | return; |
3944 | } | 3930 | } |
@@ -4077,8 +4063,8 @@ ext4_mb_discard_lg_preallocations(struct super_block *sb, | |||
4077 | 4063 | ||
4078 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); | 4064 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); |
4079 | if (ext4_mb_load_buddy(sb, group, &e4b)) { | 4065 | if (ext4_mb_load_buddy(sb, group, &e4b)) { |
4080 | ext4_error(sb, __func__, "Error in loading buddy " | 4066 | ext4_error(sb, "Error loading buddy information for %u", |
4081 | "information for %u", group); | 4067 | group); |
4082 | continue; | 4068 | continue; |
4083 | } | 4069 | } |
4084 | ext4_lock_group(sb, group); | 4070 | ext4_lock_group(sb, group); |
@@ -4476,10 +4462,10 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, | |||
4476 | 4462 | ||
4477 | sbi = EXT4_SB(sb); | 4463 | sbi = EXT4_SB(sb); |
4478 | es = EXT4_SB(sb)->s_es; | 4464 | es = EXT4_SB(sb)->s_es; |
4479 | if (!ext4_data_block_valid(sbi, block, count)) { | 4465 | if (!(flags & EXT4_FREE_BLOCKS_VALIDATED) && |
4480 | ext4_error(sb, __func__, | 4466 | !ext4_data_block_valid(sbi, block, count)) { |
4481 | "Freeing blocks not in datazone - " | 4467 | ext4_error(sb, "Freeing blocks not in datazone - " |
4482 | "block = %llu, count = %lu", block, count); | 4468 | "block = %llu, count = %lu", block, count); |
4483 | goto error_return; | 4469 | goto error_return; |
4484 | } | 4470 | } |
4485 | 4471 | ||
@@ -4547,8 +4533,7 @@ do_more: | |||
4547 | in_range(block + count - 1, ext4_inode_table(sb, gdp), | 4533 | in_range(block + count - 1, ext4_inode_table(sb, gdp), |
4548 | EXT4_SB(sb)->s_itb_per_group)) { | 4534 | EXT4_SB(sb)->s_itb_per_group)) { |
4549 | 4535 | ||
4550 | ext4_error(sb, __func__, | 4536 | ext4_error(sb, "Freeing blocks in system zone - " |
4551 | "Freeing blocks in system zone - " | ||
4552 | "Block = %llu, count = %lu", block, count); | 4537 | "Block = %llu, count = %lu", block, count); |
4553 | /* err = 0. ext4_std_error should be a no op */ | 4538 | /* err = 0. ext4_std_error should be a no op */ |
4554 | goto error_return; | 4539 | goto error_return; |
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h index 436521cae456..b619322c76f0 100644 --- a/fs/ext4/mballoc.h +++ b/fs/ext4/mballoc.h | |||
@@ -220,16 +220,9 @@ struct ext4_buddy { | |||
220 | #define EXT4_MB_BITMAP(e4b) ((e4b)->bd_bitmap) | 220 | #define EXT4_MB_BITMAP(e4b) ((e4b)->bd_bitmap) |
221 | #define EXT4_MB_BUDDY(e4b) ((e4b)->bd_buddy) | 221 | #define EXT4_MB_BUDDY(e4b) ((e4b)->bd_buddy) |
222 | 222 | ||
223 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
224 | |||
225 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, | 223 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, |
226 | struct ext4_free_extent *fex) | 224 | struct ext4_free_extent *fex) |
227 | { | 225 | { |
228 | ext4_fsblk_t block; | 226 | return ext4_group_first_block_no(sb, fex->fe_group) + fex->fe_start; |
229 | |||
230 | block = (ext4_fsblk_t) fex->fe_group * EXT4_BLOCKS_PER_GROUP(sb) | ||
231 | + fex->fe_start | ||
232 | + le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
233 | return block; | ||
234 | } | 227 | } |
235 | #endif | 228 | #endif |
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c index 81415814b00b..8b87bd0eac95 100644 --- a/fs/ext4/migrate.c +++ b/fs/ext4/migrate.c | |||
@@ -365,12 +365,12 @@ static int ext4_ext_swap_inode_data(handle_t *handle, struct inode *inode, | |||
365 | * happened after we started the migrate. We need to | 365 | * happened after we started the migrate. We need to |
366 | * fail the migrate | 366 | * fail the migrate |
367 | */ | 367 | */ |
368 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_EXT_MIGRATE)) { | 368 | if (!ext4_test_inode_state(inode, EXT4_STATE_EXT_MIGRATE)) { |
369 | retval = -EAGAIN; | 369 | retval = -EAGAIN; |
370 | up_write(&EXT4_I(inode)->i_data_sem); | 370 | up_write(&EXT4_I(inode)->i_data_sem); |
371 | goto err_out; | 371 | goto err_out; |
372 | } else | 372 | } else |
373 | EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE; | 373 | ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
374 | /* | 374 | /* |
375 | * We have the extent map build with the tmp inode. | 375 | * We have the extent map build with the tmp inode. |
376 | * Now copy the i_data across | 376 | * Now copy the i_data across |
@@ -503,14 +503,10 @@ int ext4_ext_migrate(struct inode *inode) | |||
503 | } | 503 | } |
504 | i_size_write(tmp_inode, i_size_read(inode)); | 504 | i_size_write(tmp_inode, i_size_read(inode)); |
505 | /* | 505 | /* |
506 | * We don't want the inode to be reclaimed | 506 | * Set the i_nlink to zero so it will be deleted later |
507 | * if we got interrupted in between. We have | 507 | * when we drop inode reference. |
508 | * this tmp inode carrying reference to the | ||
509 | * data blocks of the original file. We set | ||
510 | * the i_nlink to zero at the last stage after | ||
511 | * switching the original file to extent format | ||
512 | */ | 508 | */ |
513 | tmp_inode->i_nlink = 1; | 509 | tmp_inode->i_nlink = 0; |
514 | 510 | ||
515 | ext4_ext_tree_init(handle, tmp_inode); | 511 | ext4_ext_tree_init(handle, tmp_inode); |
516 | ext4_orphan_add(handle, tmp_inode); | 512 | ext4_orphan_add(handle, tmp_inode); |
@@ -533,10 +529,20 @@ int ext4_ext_migrate(struct inode *inode) | |||
533 | * allocation. | 529 | * allocation. |
534 | */ | 530 | */ |
535 | down_read((&EXT4_I(inode)->i_data_sem)); | 531 | down_read((&EXT4_I(inode)->i_data_sem)); |
536 | EXT4_I(inode)->i_state |= EXT4_STATE_EXT_MIGRATE; | 532 | ext4_set_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
537 | up_read((&EXT4_I(inode)->i_data_sem)); | 533 | up_read((&EXT4_I(inode)->i_data_sem)); |
538 | 534 | ||
539 | handle = ext4_journal_start(inode, 1); | 535 | handle = ext4_journal_start(inode, 1); |
536 | if (IS_ERR(handle)) { | ||
537 | /* | ||
538 | * It is impossible to update on-disk structures without | ||
539 | * a handle, so just rollback in-core changes and live other | ||
540 | * work to orphan_list_cleanup() | ||
541 | */ | ||
542 | ext4_orphan_del(NULL, tmp_inode); | ||
543 | retval = PTR_ERR(handle); | ||
544 | goto out; | ||
545 | } | ||
540 | 546 | ||
541 | ei = EXT4_I(inode); | 547 | ei = EXT4_I(inode); |
542 | i_data = ei->i_data; | 548 | i_data = ei->i_data; |
@@ -618,15 +624,8 @@ err_out: | |||
618 | 624 | ||
619 | /* Reset the extent details */ | 625 | /* Reset the extent details */ |
620 | ext4_ext_tree_init(handle, tmp_inode); | 626 | ext4_ext_tree_init(handle, tmp_inode); |
621 | |||
622 | /* | ||
623 | * Set the i_nlink to zero so that | ||
624 | * generic_drop_inode really deletes the | ||
625 | * inode | ||
626 | */ | ||
627 | tmp_inode->i_nlink = 0; | ||
628 | |||
629 | ext4_journal_stop(handle); | 627 | ext4_journal_stop(handle); |
628 | out: | ||
630 | unlock_new_inode(tmp_inode); | 629 | unlock_new_inode(tmp_inode); |
631 | iput(tmp_inode); | 630 | iput(tmp_inode); |
632 | 631 | ||
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 82c415be87a4..aa5fe28d180f 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c | |||
@@ -152,12 +152,12 @@ mext_check_null_inode(struct inode *inode1, struct inode *inode2, | |||
152 | int ret = 0; | 152 | int ret = 0; |
153 | 153 | ||
154 | if (inode1 == NULL) { | 154 | if (inode1 == NULL) { |
155 | ext4_error(inode2->i_sb, function, | 155 | __ext4_error(inode2->i_sb, function, |
156 | "Both inodes should not be NULL: " | 156 | "Both inodes should not be NULL: " |
157 | "inode1 NULL inode2 %lu", inode2->i_ino); | 157 | "inode1 NULL inode2 %lu", inode2->i_ino); |
158 | ret = -EIO; | 158 | ret = -EIO; |
159 | } else if (inode2 == NULL) { | 159 | } else if (inode2 == NULL) { |
160 | ext4_error(inode1->i_sb, function, | 160 | __ext4_error(inode1->i_sb, function, |
161 | "Both inodes should not be NULL: " | 161 | "Both inodes should not be NULL: " |
162 | "inode1 %lu inode2 NULL", inode1->i_ino); | 162 | "inode1 %lu inode2 NULL", inode1->i_ino); |
163 | ret = -EIO; | 163 | ret = -EIO; |
@@ -252,6 +252,7 @@ mext_insert_across_blocks(handle_t *handle, struct inode *orig_inode, | |||
252 | } | 252 | } |
253 | 253 | ||
254 | o_start->ee_len = start_ext->ee_len; | 254 | o_start->ee_len = start_ext->ee_len; |
255 | eblock = le32_to_cpu(start_ext->ee_block); | ||
255 | new_flag = 1; | 256 | new_flag = 1; |
256 | 257 | ||
257 | } else if (start_ext->ee_len && new_ext->ee_len && | 258 | } else if (start_ext->ee_len && new_ext->ee_len && |
@@ -262,6 +263,7 @@ mext_insert_across_blocks(handle_t *handle, struct inode *orig_inode, | |||
262 | * orig |------------------------------| | 263 | * orig |------------------------------| |
263 | */ | 264 | */ |
264 | o_start->ee_len = start_ext->ee_len; | 265 | o_start->ee_len = start_ext->ee_len; |
266 | eblock = le32_to_cpu(start_ext->ee_block); | ||
265 | new_flag = 1; | 267 | new_flag = 1; |
266 | 268 | ||
267 | } else if (!start_ext->ee_len && new_ext->ee_len && | 269 | } else if (!start_ext->ee_len && new_ext->ee_len && |
@@ -475,7 +477,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
475 | struct ext4_extent *oext, *o_start, *o_end, *prev_ext; | 477 | struct ext4_extent *oext, *o_start, *o_end, *prev_ext; |
476 | struct ext4_extent new_ext, start_ext, end_ext; | 478 | struct ext4_extent new_ext, start_ext, end_ext; |
477 | ext4_lblk_t new_ext_end; | 479 | ext4_lblk_t new_ext_end; |
478 | ext4_fsblk_t new_phys_end; | ||
479 | int oext_alen, new_ext_alen, end_ext_alen; | 480 | int oext_alen, new_ext_alen, end_ext_alen; |
480 | int depth = ext_depth(orig_inode); | 481 | int depth = ext_depth(orig_inode); |
481 | int ret; | 482 | int ret; |
@@ -489,7 +490,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
489 | new_ext.ee_len = dext->ee_len; | 490 | new_ext.ee_len = dext->ee_len; |
490 | new_ext_alen = ext4_ext_get_actual_len(&new_ext); | 491 | new_ext_alen = ext4_ext_get_actual_len(&new_ext); |
491 | new_ext_end = le32_to_cpu(new_ext.ee_block) + new_ext_alen - 1; | 492 | new_ext_end = le32_to_cpu(new_ext.ee_block) + new_ext_alen - 1; |
492 | new_phys_end = ext_pblock(&new_ext) + new_ext_alen - 1; | ||
493 | 493 | ||
494 | /* | 494 | /* |
495 | * Case: original extent is first | 495 | * Case: original extent is first |
@@ -502,6 +502,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
502 | le32_to_cpu(oext->ee_block) + oext_alen) { | 502 | le32_to_cpu(oext->ee_block) + oext_alen) { |
503 | start_ext.ee_len = cpu_to_le16(le32_to_cpu(new_ext.ee_block) - | 503 | start_ext.ee_len = cpu_to_le16(le32_to_cpu(new_ext.ee_block) - |
504 | le32_to_cpu(oext->ee_block)); | 504 | le32_to_cpu(oext->ee_block)); |
505 | start_ext.ee_block = oext->ee_block; | ||
505 | copy_extent_status(oext, &start_ext); | 506 | copy_extent_status(oext, &start_ext); |
506 | } else if (oext > EXT_FIRST_EXTENT(orig_path[depth].p_hdr)) { | 507 | } else if (oext > EXT_FIRST_EXTENT(orig_path[depth].p_hdr)) { |
507 | prev_ext = oext - 1; | 508 | prev_ext = oext - 1; |
@@ -515,6 +516,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
515 | start_ext.ee_len = cpu_to_le16( | 516 | start_ext.ee_len = cpu_to_le16( |
516 | ext4_ext_get_actual_len(prev_ext) + | 517 | ext4_ext_get_actual_len(prev_ext) + |
517 | new_ext_alen); | 518 | new_ext_alen); |
519 | start_ext.ee_block = oext->ee_block; | ||
518 | copy_extent_status(prev_ext, &start_ext); | 520 | copy_extent_status(prev_ext, &start_ext); |
519 | new_ext.ee_len = 0; | 521 | new_ext.ee_len = 0; |
520 | } | 522 | } |
@@ -526,7 +528,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
526 | * new_ext |-------| | 528 | * new_ext |-------| |
527 | */ | 529 | */ |
528 | if (le32_to_cpu(oext->ee_block) + oext_alen - 1 < new_ext_end) { | 530 | if (le32_to_cpu(oext->ee_block) + oext_alen - 1 < new_ext_end) { |
529 | ext4_error(orig_inode->i_sb, __func__, | 531 | ext4_error(orig_inode->i_sb, |
530 | "new_ext_end(%u) should be less than or equal to " | 532 | "new_ext_end(%u) should be less than or equal to " |
531 | "oext->ee_block(%u) + oext_alen(%d) - 1", | 533 | "oext->ee_block(%u) + oext_alen(%d) - 1", |
532 | new_ext_end, le32_to_cpu(oext->ee_block), | 534 | new_ext_end, le32_to_cpu(oext->ee_block), |
@@ -689,12 +691,12 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
689 | while (1) { | 691 | while (1) { |
690 | /* The extent for donor must be found. */ | 692 | /* The extent for donor must be found. */ |
691 | if (!dext) { | 693 | if (!dext) { |
692 | ext4_error(donor_inode->i_sb, __func__, | 694 | ext4_error(donor_inode->i_sb, |
693 | "The extent for donor must be found"); | 695 | "The extent for donor must be found"); |
694 | *err = -EIO; | 696 | *err = -EIO; |
695 | goto out; | 697 | goto out; |
696 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { | 698 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { |
697 | ext4_error(donor_inode->i_sb, __func__, | 699 | ext4_error(donor_inode->i_sb, |
698 | "Donor offset(%u) and the first block of donor " | 700 | "Donor offset(%u) and the first block of donor " |
699 | "extent(%u) should be equal", | 701 | "extent(%u) should be equal", |
700 | donor_off, | 702 | donor_off, |
@@ -928,7 +930,7 @@ out2: | |||
928 | } | 930 | } |
929 | 931 | ||
930 | /** | 932 | /** |
931 | * mext_check_argumants - Check whether move extent can be done | 933 | * mext_check_arguments - Check whether move extent can be done |
932 | * | 934 | * |
933 | * @orig_inode: original inode | 935 | * @orig_inode: original inode |
934 | * @donor_inode: donor inode | 936 | * @donor_inode: donor inode |
@@ -949,14 +951,6 @@ mext_check_arguments(struct inode *orig_inode, | |||
949 | unsigned int blkbits = orig_inode->i_blkbits; | 951 | unsigned int blkbits = orig_inode->i_blkbits; |
950 | unsigned int blocksize = 1 << blkbits; | 952 | unsigned int blocksize = 1 << blkbits; |
951 | 953 | ||
952 | /* Regular file check */ | ||
953 | if (!S_ISREG(orig_inode->i_mode) || !S_ISREG(donor_inode->i_mode)) { | ||
954 | ext4_debug("ext4 move extent: The argument files should be " | ||
955 | "regular file [ino:orig %lu, donor %lu]\n", | ||
956 | orig_inode->i_ino, donor_inode->i_ino); | ||
957 | return -EINVAL; | ||
958 | } | ||
959 | |||
960 | if (donor_inode->i_mode & (S_ISUID|S_ISGID)) { | 954 | if (donor_inode->i_mode & (S_ISUID|S_ISGID)) { |
961 | ext4_debug("ext4 move extent: suid or sgid is set" | 955 | ext4_debug("ext4 move extent: suid or sgid is set" |
962 | " to donor file [ino:orig %lu, donor %lu]\n", | 956 | " to donor file [ino:orig %lu, donor %lu]\n", |
@@ -1204,6 +1198,14 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1204 | return -EINVAL; | 1198 | return -EINVAL; |
1205 | } | 1199 | } |
1206 | 1200 | ||
1201 | /* Regular file check */ | ||
1202 | if (!S_ISREG(orig_inode->i_mode) || !S_ISREG(donor_inode->i_mode)) { | ||
1203 | ext4_debug("ext4 move extent: The argument files should be " | ||
1204 | "regular file [ino:orig %lu, donor %lu]\n", | ||
1205 | orig_inode->i_ino, donor_inode->i_ino); | ||
1206 | return -EINVAL; | ||
1207 | } | ||
1208 | |||
1207 | /* Protect orig and donor inodes against a truncate */ | 1209 | /* Protect orig and donor inodes against a truncate */ |
1208 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); | 1210 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); |
1209 | if (ret1 < 0) | 1211 | if (ret1 < 0) |
@@ -1351,7 +1353,7 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1351 | if (ret1 < 0) | 1353 | if (ret1 < 0) |
1352 | break; | 1354 | break; |
1353 | if (*moved_len > len) { | 1355 | if (*moved_len > len) { |
1354 | ext4_error(orig_inode->i_sb, __func__, | 1356 | ext4_error(orig_inode->i_sb, |
1355 | "We replaced blocks too much! " | 1357 | "We replaced blocks too much! " |
1356 | "sum of replaced: %llu requested: %llu", | 1358 | "sum of replaced: %llu requested: %llu", |
1357 | *moved_len, len); | 1359 | *moved_len, len); |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 7f3d2d75a0dc..0c070fabd108 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -383,8 +383,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
383 | if (root->info.hash_version != DX_HASH_TEA && | 383 | if (root->info.hash_version != DX_HASH_TEA && |
384 | root->info.hash_version != DX_HASH_HALF_MD4 && | 384 | root->info.hash_version != DX_HASH_HALF_MD4 && |
385 | root->info.hash_version != DX_HASH_LEGACY) { | 385 | root->info.hash_version != DX_HASH_LEGACY) { |
386 | ext4_warning(dir->i_sb, __func__, | 386 | ext4_warning(dir->i_sb, "Unrecognised inode hash code %d", |
387 | "Unrecognised inode hash code %d", | ||
388 | root->info.hash_version); | 387 | root->info.hash_version); |
389 | brelse(bh); | 388 | brelse(bh); |
390 | *err = ERR_BAD_DX_DIR; | 389 | *err = ERR_BAD_DX_DIR; |
@@ -399,8 +398,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
399 | hash = hinfo->hash; | 398 | hash = hinfo->hash; |
400 | 399 | ||
401 | if (root->info.unused_flags & 1) { | 400 | if (root->info.unused_flags & 1) { |
402 | ext4_warning(dir->i_sb, __func__, | 401 | ext4_warning(dir->i_sb, "Unimplemented inode hash flags: %#06x", |
403 | "Unimplemented inode hash flags: %#06x", | ||
404 | root->info.unused_flags); | 402 | root->info.unused_flags); |
405 | brelse(bh); | 403 | brelse(bh); |
406 | *err = ERR_BAD_DX_DIR; | 404 | *err = ERR_BAD_DX_DIR; |
@@ -408,8 +406,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
408 | } | 406 | } |
409 | 407 | ||
410 | if ((indirect = root->info.indirect_levels) > 1) { | 408 | if ((indirect = root->info.indirect_levels) > 1) { |
411 | ext4_warning(dir->i_sb, __func__, | 409 | ext4_warning(dir->i_sb, "Unimplemented inode hash depth: %#06x", |
412 | "Unimplemented inode hash depth: %#06x", | ||
413 | root->info.indirect_levels); | 410 | root->info.indirect_levels); |
414 | brelse(bh); | 411 | brelse(bh); |
415 | *err = ERR_BAD_DX_DIR; | 412 | *err = ERR_BAD_DX_DIR; |
@@ -421,8 +418,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
421 | 418 | ||
422 | if (dx_get_limit(entries) != dx_root_limit(dir, | 419 | if (dx_get_limit(entries) != dx_root_limit(dir, |
423 | root->info.info_length)) { | 420 | root->info.info_length)) { |
424 | ext4_warning(dir->i_sb, __func__, | 421 | ext4_warning(dir->i_sb, "dx entry: limit != root limit"); |
425 | "dx entry: limit != root limit"); | ||
426 | brelse(bh); | 422 | brelse(bh); |
427 | *err = ERR_BAD_DX_DIR; | 423 | *err = ERR_BAD_DX_DIR; |
428 | goto fail; | 424 | goto fail; |
@@ -433,7 +429,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
433 | { | 429 | { |
434 | count = dx_get_count(entries); | 430 | count = dx_get_count(entries); |
435 | if (!count || count > dx_get_limit(entries)) { | 431 | if (!count || count > dx_get_limit(entries)) { |
436 | ext4_warning(dir->i_sb, __func__, | 432 | ext4_warning(dir->i_sb, |
437 | "dx entry: no count or count > limit"); | 433 | "dx entry: no count or count > limit"); |
438 | brelse(bh); | 434 | brelse(bh); |
439 | *err = ERR_BAD_DX_DIR; | 435 | *err = ERR_BAD_DX_DIR; |
@@ -478,7 +474,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
478 | goto fail2; | 474 | goto fail2; |
479 | at = entries = ((struct dx_node *) bh->b_data)->entries; | 475 | at = entries = ((struct dx_node *) bh->b_data)->entries; |
480 | if (dx_get_limit(entries) != dx_node_limit (dir)) { | 476 | if (dx_get_limit(entries) != dx_node_limit (dir)) { |
481 | ext4_warning(dir->i_sb, __func__, | 477 | ext4_warning(dir->i_sb, |
482 | "dx entry: limit != node limit"); | 478 | "dx entry: limit != node limit"); |
483 | brelse(bh); | 479 | brelse(bh); |
484 | *err = ERR_BAD_DX_DIR; | 480 | *err = ERR_BAD_DX_DIR; |
@@ -494,7 +490,7 @@ fail2: | |||
494 | } | 490 | } |
495 | fail: | 491 | fail: |
496 | if (*err == ERR_BAD_DX_DIR) | 492 | if (*err == ERR_BAD_DX_DIR) |
497 | ext4_warning(dir->i_sb, __func__, | 493 | ext4_warning(dir->i_sb, |
498 | "Corrupt dir inode %ld, running e2fsck is " | 494 | "Corrupt dir inode %ld, running e2fsck is " |
499 | "recommended.", dir->i_ino); | 495 | "recommended.", dir->i_ino); |
500 | return NULL; | 496 | return NULL; |
@@ -947,9 +943,8 @@ restart: | |||
947 | wait_on_buffer(bh); | 943 | wait_on_buffer(bh); |
948 | if (!buffer_uptodate(bh)) { | 944 | if (!buffer_uptodate(bh)) { |
949 | /* read error, skip block & hope for the best */ | 945 | /* read error, skip block & hope for the best */ |
950 | ext4_error(sb, __func__, "reading directory #%lu " | 946 | ext4_error(sb, "reading directory #%lu offset %lu", |
951 | "offset %lu", dir->i_ino, | 947 | dir->i_ino, (unsigned long)block); |
952 | (unsigned long)block); | ||
953 | brelse(bh); | 948 | brelse(bh); |
954 | goto next; | 949 | goto next; |
955 | } | 950 | } |
@@ -1041,7 +1036,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, const struct q | |||
1041 | retval = ext4_htree_next_block(dir, hash, frame, | 1036 | retval = ext4_htree_next_block(dir, hash, frame, |
1042 | frames, NULL); | 1037 | frames, NULL); |
1043 | if (retval < 0) { | 1038 | if (retval < 0) { |
1044 | ext4_warning(sb, __func__, | 1039 | ext4_warning(sb, |
1045 | "error reading index page in directory #%lu", | 1040 | "error reading index page in directory #%lu", |
1046 | dir->i_ino); | 1041 | dir->i_ino); |
1047 | *err = retval; | 1042 | *err = retval; |
@@ -1071,14 +1066,13 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, stru | |||
1071 | __u32 ino = le32_to_cpu(de->inode); | 1066 | __u32 ino = le32_to_cpu(de->inode); |
1072 | brelse(bh); | 1067 | brelse(bh); |
1073 | if (!ext4_valid_inum(dir->i_sb, ino)) { | 1068 | if (!ext4_valid_inum(dir->i_sb, ino)) { |
1074 | ext4_error(dir->i_sb, "ext4_lookup", | 1069 | ext4_error(dir->i_sb, "bad inode number: %u", ino); |
1075 | "bad inode number: %u", ino); | ||
1076 | return ERR_PTR(-EIO); | 1070 | return ERR_PTR(-EIO); |
1077 | } | 1071 | } |
1078 | inode = ext4_iget(dir->i_sb, ino); | 1072 | inode = ext4_iget(dir->i_sb, ino); |
1079 | if (unlikely(IS_ERR(inode))) { | 1073 | if (unlikely(IS_ERR(inode))) { |
1080 | if (PTR_ERR(inode) == -ESTALE) { | 1074 | if (PTR_ERR(inode) == -ESTALE) { |
1081 | ext4_error(dir->i_sb, __func__, | 1075 | ext4_error(dir->i_sb, |
1082 | "deleted inode referenced: %u", | 1076 | "deleted inode referenced: %u", |
1083 | ino); | 1077 | ino); |
1084 | return ERR_PTR(-EIO); | 1078 | return ERR_PTR(-EIO); |
@@ -1110,7 +1104,7 @@ struct dentry *ext4_get_parent(struct dentry *child) | |||
1110 | brelse(bh); | 1104 | brelse(bh); |
1111 | 1105 | ||
1112 | if (!ext4_valid_inum(child->d_inode->i_sb, ino)) { | 1106 | if (!ext4_valid_inum(child->d_inode->i_sb, ino)) { |
1113 | ext4_error(child->d_inode->i_sb, "ext4_get_parent", | 1107 | ext4_error(child->d_inode->i_sb, |
1114 | "bad inode number: %u", ino); | 1108 | "bad inode number: %u", ino); |
1115 | return ERR_PTR(-EIO); | 1109 | return ERR_PTR(-EIO); |
1116 | } | 1110 | } |
@@ -1410,7 +1404,7 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, | |||
1410 | de = (struct ext4_dir_entry_2 *)((char *)fde + | 1404 | de = (struct ext4_dir_entry_2 *)((char *)fde + |
1411 | ext4_rec_len_from_disk(fde->rec_len, blocksize)); | 1405 | ext4_rec_len_from_disk(fde->rec_len, blocksize)); |
1412 | if ((char *) de >= (((char *) root) + blocksize)) { | 1406 | if ((char *) de >= (((char *) root) + blocksize)) { |
1413 | ext4_error(dir->i_sb, __func__, | 1407 | ext4_error(dir->i_sb, |
1414 | "invalid rec_len for '..' in inode %lu", | 1408 | "invalid rec_len for '..' in inode %lu", |
1415 | dir->i_ino); | 1409 | dir->i_ino); |
1416 | brelse(bh); | 1410 | brelse(bh); |
@@ -1575,8 +1569,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | |||
1575 | 1569 | ||
1576 | if (levels && (dx_get_count(frames->entries) == | 1570 | if (levels && (dx_get_count(frames->entries) == |
1577 | dx_get_limit(frames->entries))) { | 1571 | dx_get_limit(frames->entries))) { |
1578 | ext4_warning(sb, __func__, | 1572 | ext4_warning(sb, "Directory index full!"); |
1579 | "Directory index full!"); | ||
1580 | err = -ENOSPC; | 1573 | err = -ENOSPC; |
1581 | goto cleanup; | 1574 | goto cleanup; |
1582 | } | 1575 | } |
@@ -1922,11 +1915,11 @@ static int empty_dir(struct inode *inode) | |||
1922 | if (inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2) || | 1915 | if (inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2) || |
1923 | !(bh = ext4_bread(NULL, inode, 0, 0, &err))) { | 1916 | !(bh = ext4_bread(NULL, inode, 0, 0, &err))) { |
1924 | if (err) | 1917 | if (err) |
1925 | ext4_error(inode->i_sb, __func__, | 1918 | ext4_error(inode->i_sb, |
1926 | "error %d reading directory #%lu offset 0", | 1919 | "error %d reading directory #%lu offset 0", |
1927 | err, inode->i_ino); | 1920 | err, inode->i_ino); |
1928 | else | 1921 | else |
1929 | ext4_warning(inode->i_sb, __func__, | 1922 | ext4_warning(inode->i_sb, |
1930 | "bad directory (dir #%lu) - no data block", | 1923 | "bad directory (dir #%lu) - no data block", |
1931 | inode->i_ino); | 1924 | inode->i_ino); |
1932 | return 1; | 1925 | return 1; |
@@ -1937,7 +1930,7 @@ static int empty_dir(struct inode *inode) | |||
1937 | !le32_to_cpu(de1->inode) || | 1930 | !le32_to_cpu(de1->inode) || |
1938 | strcmp(".", de->name) || | 1931 | strcmp(".", de->name) || |
1939 | strcmp("..", de1->name)) { | 1932 | strcmp("..", de1->name)) { |
1940 | ext4_warning(inode->i_sb, "empty_dir", | 1933 | ext4_warning(inode->i_sb, |
1941 | "bad directory (dir #%lu) - no `.' or `..'", | 1934 | "bad directory (dir #%lu) - no `.' or `..'", |
1942 | inode->i_ino); | 1935 | inode->i_ino); |
1943 | brelse(bh); | 1936 | brelse(bh); |
@@ -1955,7 +1948,7 @@ static int empty_dir(struct inode *inode) | |||
1955 | offset >> EXT4_BLOCK_SIZE_BITS(sb), 0, &err); | 1948 | offset >> EXT4_BLOCK_SIZE_BITS(sb), 0, &err); |
1956 | if (!bh) { | 1949 | if (!bh) { |
1957 | if (err) | 1950 | if (err) |
1958 | ext4_error(sb, __func__, | 1951 | ext4_error(sb, |
1959 | "error %d reading directory" | 1952 | "error %d reading directory" |
1960 | " #%lu offset %u", | 1953 | " #%lu offset %u", |
1961 | err, inode->i_ino, offset); | 1954 | err, inode->i_ino, offset); |
@@ -2026,11 +2019,18 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) | |||
2026 | err = ext4_reserve_inode_write(handle, inode, &iloc); | 2019 | err = ext4_reserve_inode_write(handle, inode, &iloc); |
2027 | if (err) | 2020 | if (err) |
2028 | goto out_unlock; | 2021 | goto out_unlock; |
2022 | /* | ||
2023 | * Due to previous errors inode may be already a part of on-disk | ||
2024 | * orphan list. If so skip on-disk list modification. | ||
2025 | */ | ||
2026 | if (NEXT_ORPHAN(inode) && NEXT_ORPHAN(inode) <= | ||
2027 | (le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count))) | ||
2028 | goto mem_insert; | ||
2029 | 2029 | ||
2030 | /* Insert this inode at the head of the on-disk orphan list... */ | 2030 | /* Insert this inode at the head of the on-disk orphan list... */ |
2031 | NEXT_ORPHAN(inode) = le32_to_cpu(EXT4_SB(sb)->s_es->s_last_orphan); | 2031 | NEXT_ORPHAN(inode) = le32_to_cpu(EXT4_SB(sb)->s_es->s_last_orphan); |
2032 | EXT4_SB(sb)->s_es->s_last_orphan = cpu_to_le32(inode->i_ino); | 2032 | EXT4_SB(sb)->s_es->s_last_orphan = cpu_to_le32(inode->i_ino); |
2033 | err = ext4_handle_dirty_metadata(handle, inode, EXT4_SB(sb)->s_sbh); | 2033 | err = ext4_handle_dirty_metadata(handle, NULL, EXT4_SB(sb)->s_sbh); |
2034 | rc = ext4_mark_iloc_dirty(handle, inode, &iloc); | 2034 | rc = ext4_mark_iloc_dirty(handle, inode, &iloc); |
2035 | if (!err) | 2035 | if (!err) |
2036 | err = rc; | 2036 | err = rc; |
@@ -2043,6 +2043,7 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) | |||
2043 | * | 2043 | * |
2044 | * This is safe: on error we're going to ignore the orphan list | 2044 | * This is safe: on error we're going to ignore the orphan list |
2045 | * anyway on the next recovery. */ | 2045 | * anyway on the next recovery. */ |
2046 | mem_insert: | ||
2046 | if (!err) | 2047 | if (!err) |
2047 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); | 2048 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); |
2048 | 2049 | ||
@@ -2102,7 +2103,7 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode) | |||
2102 | if (err) | 2103 | if (err) |
2103 | goto out_brelse; | 2104 | goto out_brelse; |
2104 | sbi->s_es->s_last_orphan = cpu_to_le32(ino_next); | 2105 | sbi->s_es->s_last_orphan = cpu_to_le32(ino_next); |
2105 | err = ext4_handle_dirty_metadata(handle, inode, sbi->s_sbh); | 2106 | err = ext4_handle_dirty_metadata(handle, NULL, sbi->s_sbh); |
2106 | } else { | 2107 | } else { |
2107 | struct ext4_iloc iloc2; | 2108 | struct ext4_iloc iloc2; |
2108 | struct inode *i_prev = | 2109 | struct inode *i_prev = |
@@ -2171,7 +2172,7 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry) | |||
2171 | if (retval) | 2172 | if (retval) |
2172 | goto end_rmdir; | 2173 | goto end_rmdir; |
2173 | if (!EXT4_DIR_LINK_EMPTY(inode)) | 2174 | if (!EXT4_DIR_LINK_EMPTY(inode)) |
2174 | ext4_warning(inode->i_sb, "ext4_rmdir", | 2175 | ext4_warning(inode->i_sb, |
2175 | "empty directory has too many links (%d)", | 2176 | "empty directory has too many links (%d)", |
2176 | inode->i_nlink); | 2177 | inode->i_nlink); |
2177 | inode->i_version++; | 2178 | inode->i_version++; |
@@ -2225,7 +2226,7 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry) | |||
2225 | goto end_unlink; | 2226 | goto end_unlink; |
2226 | 2227 | ||
2227 | if (!inode->i_nlink) { | 2228 | if (!inode->i_nlink) { |
2228 | ext4_warning(inode->i_sb, "ext4_unlink", | 2229 | ext4_warning(inode->i_sb, |
2229 | "Deleting nonexistent file (%lu), %d", | 2230 | "Deleting nonexistent file (%lu), %d", |
2230 | inode->i_ino, inode->i_nlink); | 2231 | inode->i_ino, inode->i_nlink); |
2231 | inode->i_nlink = 1; | 2232 | inode->i_nlink = 1; |
@@ -2479,7 +2480,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2479 | } | 2480 | } |
2480 | } | 2481 | } |
2481 | if (retval) { | 2482 | if (retval) { |
2482 | ext4_warning(old_dir->i_sb, "ext4_rename", | 2483 | ext4_warning(old_dir->i_sb, |
2483 | "Deleting old file (%lu), %d, error=%d", | 2484 | "Deleting old file (%lu), %d, error=%d", |
2484 | old_dir->i_ino, old_dir->i_nlink, retval); | 2485 | old_dir->i_ino, old_dir->i_nlink, retval); |
2485 | } | 2486 | } |
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 3b2c5541d8a6..5692c48754a0 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c | |||
@@ -48,65 +48,54 @@ static int verify_group_input(struct super_block *sb, | |||
48 | 48 | ||
49 | ext4_get_group_no_and_offset(sb, start, NULL, &offset); | 49 | ext4_get_group_no_and_offset(sb, start, NULL, &offset); |
50 | if (group != sbi->s_groups_count) | 50 | if (group != sbi->s_groups_count) |
51 | ext4_warning(sb, __func__, | 51 | ext4_warning(sb, "Cannot add at group %u (only %u groups)", |
52 | "Cannot add at group %u (only %u groups)", | ||
53 | input->group, sbi->s_groups_count); | 52 | input->group, sbi->s_groups_count); |
54 | else if (offset != 0) | 53 | else if (offset != 0) |
55 | ext4_warning(sb, __func__, "Last group not full"); | 54 | ext4_warning(sb, "Last group not full"); |
56 | else if (input->reserved_blocks > input->blocks_count / 5) | 55 | else if (input->reserved_blocks > input->blocks_count / 5) |
57 | ext4_warning(sb, __func__, "Reserved blocks too high (%u)", | 56 | ext4_warning(sb, "Reserved blocks too high (%u)", |
58 | input->reserved_blocks); | 57 | input->reserved_blocks); |
59 | else if (free_blocks_count < 0) | 58 | else if (free_blocks_count < 0) |
60 | ext4_warning(sb, __func__, "Bad blocks count %u", | 59 | ext4_warning(sb, "Bad blocks count %u", |
61 | input->blocks_count); | 60 | input->blocks_count); |
62 | else if (!(bh = sb_bread(sb, end - 1))) | 61 | else if (!(bh = sb_bread(sb, end - 1))) |
63 | ext4_warning(sb, __func__, | 62 | ext4_warning(sb, "Cannot read last block (%llu)", |
64 | "Cannot read last block (%llu)", | ||
65 | end - 1); | 63 | end - 1); |
66 | else if (outside(input->block_bitmap, start, end)) | 64 | else if (outside(input->block_bitmap, start, end)) |
67 | ext4_warning(sb, __func__, | 65 | ext4_warning(sb, "Block bitmap not in group (block %llu)", |
68 | "Block bitmap not in group (block %llu)", | ||
69 | (unsigned long long)input->block_bitmap); | 66 | (unsigned long long)input->block_bitmap); |
70 | else if (outside(input->inode_bitmap, start, end)) | 67 | else if (outside(input->inode_bitmap, start, end)) |
71 | ext4_warning(sb, __func__, | 68 | ext4_warning(sb, "Inode bitmap not in group (block %llu)", |
72 | "Inode bitmap not in group (block %llu)", | ||
73 | (unsigned long long)input->inode_bitmap); | 69 | (unsigned long long)input->inode_bitmap); |
74 | else if (outside(input->inode_table, start, end) || | 70 | else if (outside(input->inode_table, start, end) || |
75 | outside(itend - 1, start, end)) | 71 | outside(itend - 1, start, end)) |
76 | ext4_warning(sb, __func__, | 72 | ext4_warning(sb, "Inode table not in group (blocks %llu-%llu)", |
77 | "Inode table not in group (blocks %llu-%llu)", | ||
78 | (unsigned long long)input->inode_table, itend - 1); | 73 | (unsigned long long)input->inode_table, itend - 1); |
79 | else if (input->inode_bitmap == input->block_bitmap) | 74 | else if (input->inode_bitmap == input->block_bitmap) |
80 | ext4_warning(sb, __func__, | 75 | ext4_warning(sb, "Block bitmap same as inode bitmap (%llu)", |
81 | "Block bitmap same as inode bitmap (%llu)", | ||
82 | (unsigned long long)input->block_bitmap); | 76 | (unsigned long long)input->block_bitmap); |
83 | else if (inside(input->block_bitmap, input->inode_table, itend)) | 77 | else if (inside(input->block_bitmap, input->inode_table, itend)) |
84 | ext4_warning(sb, __func__, | 78 | ext4_warning(sb, "Block bitmap (%llu) in inode table " |
85 | "Block bitmap (%llu) in inode table (%llu-%llu)", | 79 | "(%llu-%llu)", |
86 | (unsigned long long)input->block_bitmap, | 80 | (unsigned long long)input->block_bitmap, |
87 | (unsigned long long)input->inode_table, itend - 1); | 81 | (unsigned long long)input->inode_table, itend - 1); |
88 | else if (inside(input->inode_bitmap, input->inode_table, itend)) | 82 | else if (inside(input->inode_bitmap, input->inode_table, itend)) |
89 | ext4_warning(sb, __func__, | 83 | ext4_warning(sb, "Inode bitmap (%llu) in inode table " |
90 | "Inode bitmap (%llu) in inode table (%llu-%llu)", | 84 | "(%llu-%llu)", |
91 | (unsigned long long)input->inode_bitmap, | 85 | (unsigned long long)input->inode_bitmap, |
92 | (unsigned long long)input->inode_table, itend - 1); | 86 | (unsigned long long)input->inode_table, itend - 1); |
93 | else if (inside(input->block_bitmap, start, metaend)) | 87 | else if (inside(input->block_bitmap, start, metaend)) |
94 | ext4_warning(sb, __func__, | 88 | ext4_warning(sb, "Block bitmap (%llu) in GDT table (%llu-%llu)", |
95 | "Block bitmap (%llu) in GDT table" | ||
96 | " (%llu-%llu)", | ||
97 | (unsigned long long)input->block_bitmap, | 89 | (unsigned long long)input->block_bitmap, |
98 | start, metaend - 1); | 90 | start, metaend - 1); |
99 | else if (inside(input->inode_bitmap, start, metaend)) | 91 | else if (inside(input->inode_bitmap, start, metaend)) |
100 | ext4_warning(sb, __func__, | 92 | ext4_warning(sb, "Inode bitmap (%llu) in GDT table (%llu-%llu)", |
101 | "Inode bitmap (%llu) in GDT table" | ||
102 | " (%llu-%llu)", | ||
103 | (unsigned long long)input->inode_bitmap, | 93 | (unsigned long long)input->inode_bitmap, |
104 | start, metaend - 1); | 94 | start, metaend - 1); |
105 | else if (inside(input->inode_table, start, metaend) || | 95 | else if (inside(input->inode_table, start, metaend) || |
106 | inside(itend - 1, start, metaend)) | 96 | inside(itend - 1, start, metaend)) |
107 | ext4_warning(sb, __func__, | 97 | ext4_warning(sb, "Inode table (%llu-%llu) overlaps GDT table " |
108 | "Inode table (%llu-%llu) overlaps" | 98 | "(%llu-%llu)", |
109 | "GDT table (%llu-%llu)", | ||
110 | (unsigned long long)input->inode_table, | 99 | (unsigned long long)input->inode_table, |
111 | itend - 1, start, metaend - 1); | 100 | itend - 1, start, metaend - 1); |
112 | else | 101 | else |
@@ -364,8 +353,7 @@ static int verify_reserved_gdb(struct super_block *sb, | |||
364 | while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) { | 353 | while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) { |
365 | if (le32_to_cpu(*p++) != | 354 | if (le32_to_cpu(*p++) != |
366 | grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){ | 355 | grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){ |
367 | ext4_warning(sb, __func__, | 356 | ext4_warning(sb, "reserved GDT %llu" |
368 | "reserved GDT %llu" | ||
369 | " missing grp %d (%llu)", | 357 | " missing grp %d (%llu)", |
370 | blk, grp, | 358 | blk, grp, |
371 | grp * | 359 | grp * |
@@ -420,8 +408,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
420 | */ | 408 | */ |
421 | if (EXT4_SB(sb)->s_sbh->b_blocknr != | 409 | if (EXT4_SB(sb)->s_sbh->b_blocknr != |
422 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { | 410 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { |
423 | ext4_warning(sb, __func__, | 411 | ext4_warning(sb, "won't resize using backup superblock at %llu", |
424 | "won't resize using backup superblock at %llu", | ||
425 | (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); | 412 | (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); |
426 | return -EPERM; | 413 | return -EPERM; |
427 | } | 414 | } |
@@ -444,8 +431,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
444 | 431 | ||
445 | data = (__le32 *)dind->b_data; | 432 | data = (__le32 *)dind->b_data; |
446 | if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) { | 433 | if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) { |
447 | ext4_warning(sb, __func__, | 434 | ext4_warning(sb, "new group %u GDT block %llu not reserved", |
448 | "new group %u GDT block %llu not reserved", | ||
449 | input->group, gdblock); | 435 | input->group, gdblock); |
450 | err = -EINVAL; | 436 | err = -EINVAL; |
451 | goto exit_dind; | 437 | goto exit_dind; |
@@ -468,7 +454,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
468 | GFP_NOFS); | 454 | GFP_NOFS); |
469 | if (!n_group_desc) { | 455 | if (!n_group_desc) { |
470 | err = -ENOMEM; | 456 | err = -ENOMEM; |
471 | ext4_warning(sb, __func__, | 457 | ext4_warning(sb, |
472 | "not enough memory for %lu groups", gdb_num + 1); | 458 | "not enough memory for %lu groups", gdb_num + 1); |
473 | goto exit_inode; | 459 | goto exit_inode; |
474 | } | 460 | } |
@@ -567,8 +553,7 @@ static int reserve_backup_gdb(handle_t *handle, struct inode *inode, | |||
567 | /* Get each reserved primary GDT block and verify it holds backups */ | 553 | /* Get each reserved primary GDT block and verify it holds backups */ |
568 | for (res = 0; res < reserved_gdb; res++, blk++) { | 554 | for (res = 0; res < reserved_gdb; res++, blk++) { |
569 | if (le32_to_cpu(*data) != blk) { | 555 | if (le32_to_cpu(*data) != blk) { |
570 | ext4_warning(sb, __func__, | 556 | ext4_warning(sb, "reserved block %llu" |
571 | "reserved block %llu" | ||
572 | " not at offset %ld", | 557 | " not at offset %ld", |
573 | blk, | 558 | blk, |
574 | (long)(data - (__le32 *)dind->b_data)); | 559 | (long)(data - (__le32 *)dind->b_data)); |
@@ -713,8 +698,7 @@ static void update_backups(struct super_block *sb, | |||
713 | */ | 698 | */ |
714 | exit_err: | 699 | exit_err: |
715 | if (err) { | 700 | if (err) { |
716 | ext4_warning(sb, __func__, | 701 | ext4_warning(sb, "can't update backup for group %u (err %d), " |
717 | "can't update backup for group %u (err %d), " | ||
718 | "forcing fsck on next reboot", group, err); | 702 | "forcing fsck on next reboot", group, err); |
719 | sbi->s_mount_state &= ~EXT4_VALID_FS; | 703 | sbi->s_mount_state &= ~EXT4_VALID_FS; |
720 | sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS); | 704 | sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS); |
@@ -753,20 +737,19 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
753 | 737 | ||
754 | if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb, | 738 | if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb, |
755 | EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) { | 739 | EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) { |
756 | ext4_warning(sb, __func__, | 740 | ext4_warning(sb, "Can't resize non-sparse filesystem further"); |
757 | "Can't resize non-sparse filesystem further"); | ||
758 | return -EPERM; | 741 | return -EPERM; |
759 | } | 742 | } |
760 | 743 | ||
761 | if (ext4_blocks_count(es) + input->blocks_count < | 744 | if (ext4_blocks_count(es) + input->blocks_count < |
762 | ext4_blocks_count(es)) { | 745 | ext4_blocks_count(es)) { |
763 | ext4_warning(sb, __func__, "blocks_count overflow"); | 746 | ext4_warning(sb, "blocks_count overflow"); |
764 | return -EINVAL; | 747 | return -EINVAL; |
765 | } | 748 | } |
766 | 749 | ||
767 | if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) < | 750 | if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) < |
768 | le32_to_cpu(es->s_inodes_count)) { | 751 | le32_to_cpu(es->s_inodes_count)) { |
769 | ext4_warning(sb, __func__, "inodes_count overflow"); | 752 | ext4_warning(sb, "inodes_count overflow"); |
770 | return -EINVAL; | 753 | return -EINVAL; |
771 | } | 754 | } |
772 | 755 | ||
@@ -774,14 +757,13 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
774 | if (!EXT4_HAS_COMPAT_FEATURE(sb, | 757 | if (!EXT4_HAS_COMPAT_FEATURE(sb, |
775 | EXT4_FEATURE_COMPAT_RESIZE_INODE) | 758 | EXT4_FEATURE_COMPAT_RESIZE_INODE) |
776 | || !le16_to_cpu(es->s_reserved_gdt_blocks)) { | 759 | || !le16_to_cpu(es->s_reserved_gdt_blocks)) { |
777 | ext4_warning(sb, __func__, | 760 | ext4_warning(sb, |
778 | "No reserved GDT blocks, can't resize"); | 761 | "No reserved GDT blocks, can't resize"); |
779 | return -EPERM; | 762 | return -EPERM; |
780 | } | 763 | } |
781 | inode = ext4_iget(sb, EXT4_RESIZE_INO); | 764 | inode = ext4_iget(sb, EXT4_RESIZE_INO); |
782 | if (IS_ERR(inode)) { | 765 | if (IS_ERR(inode)) { |
783 | ext4_warning(sb, __func__, | 766 | ext4_warning(sb, "Error opening resize inode"); |
784 | "Error opening resize inode"); | ||
785 | return PTR_ERR(inode); | 767 | return PTR_ERR(inode); |
786 | } | 768 | } |
787 | } | 769 | } |
@@ -810,8 +792,7 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
810 | 792 | ||
811 | mutex_lock(&sbi->s_resize_lock); | 793 | mutex_lock(&sbi->s_resize_lock); |
812 | if (input->group != sbi->s_groups_count) { | 794 | if (input->group != sbi->s_groups_count) { |
813 | ext4_warning(sb, __func__, | 795 | ext4_warning(sb, "multiple resizers run on filesystem!"); |
814 | "multiple resizers run on filesystem!"); | ||
815 | err = -EBUSY; | 796 | err = -EBUSY; |
816 | goto exit_journal; | 797 | goto exit_journal; |
817 | } | 798 | } |
@@ -997,13 +978,12 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
997 | " too large to resize to %llu blocks safely\n", | 978 | " too large to resize to %llu blocks safely\n", |
998 | sb->s_id, n_blocks_count); | 979 | sb->s_id, n_blocks_count); |
999 | if (sizeof(sector_t) < 8) | 980 | if (sizeof(sector_t) < 8) |
1000 | ext4_warning(sb, __func__, "CONFIG_LBDAF not enabled"); | 981 | ext4_warning(sb, "CONFIG_LBDAF not enabled"); |
1001 | return -EINVAL; | 982 | return -EINVAL; |
1002 | } | 983 | } |
1003 | 984 | ||
1004 | if (n_blocks_count < o_blocks_count) { | 985 | if (n_blocks_count < o_blocks_count) { |
1005 | ext4_warning(sb, __func__, | 986 | ext4_warning(sb, "can't shrink FS - resize aborted"); |
1006 | "can't shrink FS - resize aborted"); | ||
1007 | return -EBUSY; | 987 | return -EBUSY; |
1008 | } | 988 | } |
1009 | 989 | ||
@@ -1011,15 +991,14 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1011 | ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last); | 991 | ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last); |
1012 | 992 | ||
1013 | if (last == 0) { | 993 | if (last == 0) { |
1014 | ext4_warning(sb, __func__, | 994 | ext4_warning(sb, "need to use ext2online to resize further"); |
1015 | "need to use ext2online to resize further"); | ||
1016 | return -EPERM; | 995 | return -EPERM; |
1017 | } | 996 | } |
1018 | 997 | ||
1019 | add = EXT4_BLOCKS_PER_GROUP(sb) - last; | 998 | add = EXT4_BLOCKS_PER_GROUP(sb) - last; |
1020 | 999 | ||
1021 | if (o_blocks_count + add < o_blocks_count) { | 1000 | if (o_blocks_count + add < o_blocks_count) { |
1022 | ext4_warning(sb, __func__, "blocks_count overflow"); | 1001 | ext4_warning(sb, "blocks_count overflow"); |
1023 | return -EINVAL; | 1002 | return -EINVAL; |
1024 | } | 1003 | } |
1025 | 1004 | ||
@@ -1027,16 +1006,13 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1027 | add = n_blocks_count - o_blocks_count; | 1006 | add = n_blocks_count - o_blocks_count; |
1028 | 1007 | ||
1029 | if (o_blocks_count + add < n_blocks_count) | 1008 | if (o_blocks_count + add < n_blocks_count) |
1030 | ext4_warning(sb, __func__, | 1009 | ext4_warning(sb, "will only finish group (%llu blocks, %u new)", |
1031 | "will only finish group (%llu" | ||
1032 | " blocks, %u new)", | ||
1033 | o_blocks_count + add, add); | 1010 | o_blocks_count + add, add); |
1034 | 1011 | ||
1035 | /* See if the device is actually as big as what was requested */ | 1012 | /* See if the device is actually as big as what was requested */ |
1036 | bh = sb_bread(sb, o_blocks_count + add - 1); | 1013 | bh = sb_bread(sb, o_blocks_count + add - 1); |
1037 | if (!bh) { | 1014 | if (!bh) { |
1038 | ext4_warning(sb, __func__, | 1015 | ext4_warning(sb, "can't read last block, resize aborted"); |
1039 | "can't read last block, resize aborted"); | ||
1040 | return -ENOSPC; | 1016 | return -ENOSPC; |
1041 | } | 1017 | } |
1042 | brelse(bh); | 1018 | brelse(bh); |
@@ -1047,14 +1023,13 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1047 | handle = ext4_journal_start_sb(sb, 3); | 1023 | handle = ext4_journal_start_sb(sb, 3); |
1048 | if (IS_ERR(handle)) { | 1024 | if (IS_ERR(handle)) { |
1049 | err = PTR_ERR(handle); | 1025 | err = PTR_ERR(handle); |
1050 | ext4_warning(sb, __func__, "error %d on journal start", err); | 1026 | ext4_warning(sb, "error %d on journal start", err); |
1051 | goto exit_put; | 1027 | goto exit_put; |
1052 | } | 1028 | } |
1053 | 1029 | ||
1054 | mutex_lock(&EXT4_SB(sb)->s_resize_lock); | 1030 | mutex_lock(&EXT4_SB(sb)->s_resize_lock); |
1055 | if (o_blocks_count != ext4_blocks_count(es)) { | 1031 | if (o_blocks_count != ext4_blocks_count(es)) { |
1056 | ext4_warning(sb, __func__, | 1032 | ext4_warning(sb, "multiple resizers run on filesystem!"); |
1057 | "multiple resizers run on filesystem!"); | ||
1058 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); | 1033 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); |
1059 | ext4_journal_stop(handle); | 1034 | ext4_journal_stop(handle); |
1060 | err = -EBUSY; | 1035 | err = -EBUSY; |
@@ -1063,8 +1038,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1063 | 1038 | ||
1064 | if ((err = ext4_journal_get_write_access(handle, | 1039 | if ((err = ext4_journal_get_write_access(handle, |
1065 | EXT4_SB(sb)->s_sbh))) { | 1040 | EXT4_SB(sb)->s_sbh))) { |
1066 | ext4_warning(sb, __func__, | 1041 | ext4_warning(sb, "error %d on journal write access", err); |
1067 | "error %d on journal write access", err); | ||
1068 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); | 1042 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); |
1069 | ext4_journal_stop(handle); | 1043 | ext4_journal_stop(handle); |
1070 | goto exit_put; | 1044 | goto exit_put; |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index edcf3b0239d1..2b83b96cb2eb 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -333,7 +333,7 @@ static void ext4_handle_error(struct super_block *sb) | |||
333 | sb->s_id); | 333 | sb->s_id); |
334 | } | 334 | } |
335 | 335 | ||
336 | void ext4_error(struct super_block *sb, const char *function, | 336 | void __ext4_error(struct super_block *sb, const char *function, |
337 | const char *fmt, ...) | 337 | const char *fmt, ...) |
338 | { | 338 | { |
339 | va_list args; | 339 | va_list args; |
@@ -347,6 +347,42 @@ void ext4_error(struct super_block *sb, const char *function, | |||
347 | ext4_handle_error(sb); | 347 | ext4_handle_error(sb); |
348 | } | 348 | } |
349 | 349 | ||
350 | void ext4_error_inode(const char *function, struct inode *inode, | ||
351 | const char *fmt, ...) | ||
352 | { | ||
353 | va_list args; | ||
354 | |||
355 | va_start(args, fmt); | ||
356 | printk(KERN_CRIT "EXT4-fs error (device %s): %s: inode #%lu: (comm %s) ", | ||
357 | inode->i_sb->s_id, function, inode->i_ino, current->comm); | ||
358 | vprintk(fmt, args); | ||
359 | printk("\n"); | ||
360 | va_end(args); | ||
361 | |||
362 | ext4_handle_error(inode->i_sb); | ||
363 | } | ||
364 | |||
365 | void ext4_error_file(const char *function, struct file *file, | ||
366 | const char *fmt, ...) | ||
367 | { | ||
368 | va_list args; | ||
369 | struct inode *inode = file->f_dentry->d_inode; | ||
370 | char pathname[80], *path; | ||
371 | |||
372 | va_start(args, fmt); | ||
373 | path = d_path(&(file->f_path), pathname, sizeof(pathname)); | ||
374 | if (!path) | ||
375 | path = "(unknown)"; | ||
376 | printk(KERN_CRIT | ||
377 | "EXT4-fs error (device %s): %s: inode #%lu (comm %s path %s): ", | ||
378 | inode->i_sb->s_id, function, inode->i_ino, current->comm, path); | ||
379 | vprintk(fmt, args); | ||
380 | printk("\n"); | ||
381 | va_end(args); | ||
382 | |||
383 | ext4_handle_error(inode->i_sb); | ||
384 | } | ||
385 | |||
350 | static const char *ext4_decode_error(struct super_block *sb, int errno, | 386 | static const char *ext4_decode_error(struct super_block *sb, int errno, |
351 | char nbuf[16]) | 387 | char nbuf[16]) |
352 | { | 388 | { |
@@ -450,7 +486,7 @@ void ext4_msg (struct super_block * sb, const char *prefix, | |||
450 | va_end(args); | 486 | va_end(args); |
451 | } | 487 | } |
452 | 488 | ||
453 | void ext4_warning(struct super_block *sb, const char *function, | 489 | void __ext4_warning(struct super_block *sb, const char *function, |
454 | const char *fmt, ...) | 490 | const char *fmt, ...) |
455 | { | 491 | { |
456 | va_list args; | 492 | va_list args; |
@@ -507,7 +543,7 @@ void ext4_update_dynamic_rev(struct super_block *sb) | |||
507 | if (le32_to_cpu(es->s_rev_level) > EXT4_GOOD_OLD_REV) | 543 | if (le32_to_cpu(es->s_rev_level) > EXT4_GOOD_OLD_REV) |
508 | return; | 544 | return; |
509 | 545 | ||
510 | ext4_warning(sb, __func__, | 546 | ext4_warning(sb, |
511 | "updating to rev %d because of new feature flag, " | 547 | "updating to rev %d because of new feature flag, " |
512 | "running e2fsck is recommended", | 548 | "running e2fsck is recommended", |
513 | EXT4_DYNAMIC_REV); | 549 | EXT4_DYNAMIC_REV); |
@@ -708,7 +744,8 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) | |||
708 | #ifdef CONFIG_QUOTA | 744 | #ifdef CONFIG_QUOTA |
709 | ei->i_reserved_quota = 0; | 745 | ei->i_reserved_quota = 0; |
710 | #endif | 746 | #endif |
711 | INIT_LIST_HEAD(&ei->i_aio_dio_complete_list); | 747 | INIT_LIST_HEAD(&ei->i_completed_io_list); |
748 | spin_lock_init(&ei->i_completed_io_lock); | ||
712 | ei->cur_aio_dio = NULL; | 749 | ei->cur_aio_dio = NULL; |
713 | ei->i_sync_tid = 0; | 750 | ei->i_sync_tid = 0; |
714 | ei->i_datasync_tid = 0; | 751 | ei->i_datasync_tid = 0; |
@@ -797,10 +834,10 @@ static inline void ext4_show_quota_options(struct seq_file *seq, | |||
797 | if (sbi->s_qf_names[GRPQUOTA]) | 834 | if (sbi->s_qf_names[GRPQUOTA]) |
798 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); | 835 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); |
799 | 836 | ||
800 | if (sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA) | 837 | if (test_opt(sb, USRQUOTA)) |
801 | seq_puts(seq, ",usrquota"); | 838 | seq_puts(seq, ",usrquota"); |
802 | 839 | ||
803 | if (sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA) | 840 | if (test_opt(sb, GRPQUOTA)) |
804 | seq_puts(seq, ",grpquota"); | 841 | seq_puts(seq, ",grpquota"); |
805 | #endif | 842 | #endif |
806 | } | 843 | } |
@@ -927,6 +964,9 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
927 | if (test_opt(sb, NOLOAD)) | 964 | if (test_opt(sb, NOLOAD)) |
928 | seq_puts(seq, ",norecovery"); | 965 | seq_puts(seq, ",norecovery"); |
929 | 966 | ||
967 | if (test_opt(sb, DIOREAD_NOLOCK)) | ||
968 | seq_puts(seq, ",dioread_nolock"); | ||
969 | |||
930 | ext4_show_quota_options(seq, sb); | 970 | ext4_show_quota_options(seq, sb); |
931 | 971 | ||
932 | return 0; | 972 | return 0; |
@@ -1100,6 +1140,7 @@ enum { | |||
1100 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, | 1140 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, |
1101 | Opt_block_validity, Opt_noblock_validity, | 1141 | Opt_block_validity, Opt_noblock_validity, |
1102 | Opt_inode_readahead_blks, Opt_journal_ioprio, | 1142 | Opt_inode_readahead_blks, Opt_journal_ioprio, |
1143 | Opt_dioread_nolock, Opt_dioread_lock, | ||
1103 | Opt_discard, Opt_nodiscard, | 1144 | Opt_discard, Opt_nodiscard, |
1104 | }; | 1145 | }; |
1105 | 1146 | ||
@@ -1167,6 +1208,8 @@ static const match_table_t tokens = { | |||
1167 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, | 1208 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, |
1168 | {Opt_auto_da_alloc, "auto_da_alloc"}, | 1209 | {Opt_auto_da_alloc, "auto_da_alloc"}, |
1169 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, | 1210 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, |
1211 | {Opt_dioread_nolock, "dioread_nolock"}, | ||
1212 | {Opt_dioread_lock, "dioread_lock"}, | ||
1170 | {Opt_discard, "discard"}, | 1213 | {Opt_discard, "discard"}, |
1171 | {Opt_nodiscard, "nodiscard"}, | 1214 | {Opt_nodiscard, "nodiscard"}, |
1172 | {Opt_err, NULL}, | 1215 | {Opt_err, NULL}, |
@@ -1196,6 +1239,66 @@ static ext4_fsblk_t get_sb_block(void **data) | |||
1196 | } | 1239 | } |
1197 | 1240 | ||
1198 | #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3)) | 1241 | #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3)) |
1242 | static char deprecated_msg[] = "Mount option \"%s\" will be removed by %s\n" | ||
1243 | "Contact linux-ext4@vger.kernel.org if you think we should keep it.\n"; | ||
1244 | |||
1245 | #ifdef CONFIG_QUOTA | ||
1246 | static int set_qf_name(struct super_block *sb, int qtype, substring_t *args) | ||
1247 | { | ||
1248 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
1249 | char *qname; | ||
1250 | |||
1251 | if (sb_any_quota_loaded(sb) && | ||
1252 | !sbi->s_qf_names[qtype]) { | ||
1253 | ext4_msg(sb, KERN_ERR, | ||
1254 | "Cannot change journaled " | ||
1255 | "quota options when quota turned on"); | ||
1256 | return 0; | ||
1257 | } | ||
1258 | qname = match_strdup(args); | ||
1259 | if (!qname) { | ||
1260 | ext4_msg(sb, KERN_ERR, | ||
1261 | "Not enough memory for storing quotafile name"); | ||
1262 | return 0; | ||
1263 | } | ||
1264 | if (sbi->s_qf_names[qtype] && | ||
1265 | strcmp(sbi->s_qf_names[qtype], qname)) { | ||
1266 | ext4_msg(sb, KERN_ERR, | ||
1267 | "%s quota file already specified", QTYPE2NAME(qtype)); | ||
1268 | kfree(qname); | ||
1269 | return 0; | ||
1270 | } | ||
1271 | sbi->s_qf_names[qtype] = qname; | ||
1272 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
1273 | ext4_msg(sb, KERN_ERR, | ||
1274 | "quotafile must be on filesystem root"); | ||
1275 | kfree(sbi->s_qf_names[qtype]); | ||
1276 | sbi->s_qf_names[qtype] = NULL; | ||
1277 | return 0; | ||
1278 | } | ||
1279 | set_opt(sbi->s_mount_opt, QUOTA); | ||
1280 | return 1; | ||
1281 | } | ||
1282 | |||
1283 | static int clear_qf_name(struct super_block *sb, int qtype) | ||
1284 | { | ||
1285 | |||
1286 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
1287 | |||
1288 | if (sb_any_quota_loaded(sb) && | ||
1289 | sbi->s_qf_names[qtype]) { | ||
1290 | ext4_msg(sb, KERN_ERR, "Cannot change journaled quota options" | ||
1291 | " when quota turned on"); | ||
1292 | return 0; | ||
1293 | } | ||
1294 | /* | ||
1295 | * The space will be released later when all options are confirmed | ||
1296 | * to be correct | ||
1297 | */ | ||
1298 | sbi->s_qf_names[qtype] = NULL; | ||
1299 | return 1; | ||
1300 | } | ||
1301 | #endif | ||
1199 | 1302 | ||
1200 | static int parse_options(char *options, struct super_block *sb, | 1303 | static int parse_options(char *options, struct super_block *sb, |
1201 | unsigned long *journal_devnum, | 1304 | unsigned long *journal_devnum, |
@@ -1208,8 +1311,7 @@ static int parse_options(char *options, struct super_block *sb, | |||
1208 | int data_opt = 0; | 1311 | int data_opt = 0; |
1209 | int option; | 1312 | int option; |
1210 | #ifdef CONFIG_QUOTA | 1313 | #ifdef CONFIG_QUOTA |
1211 | int qtype, qfmt; | 1314 | int qfmt; |
1212 | char *qname; | ||
1213 | #endif | 1315 | #endif |
1214 | 1316 | ||
1215 | if (!options) | 1317 | if (!options) |
@@ -1220,19 +1322,31 @@ static int parse_options(char *options, struct super_block *sb, | |||
1220 | if (!*p) | 1322 | if (!*p) |
1221 | continue; | 1323 | continue; |
1222 | 1324 | ||
1325 | /* | ||
1326 | * Initialize args struct so we know whether arg was | ||
1327 | * found; some options take optional arguments. | ||
1328 | */ | ||
1329 | args[0].to = args[0].from = 0; | ||
1223 | token = match_token(p, tokens, args); | 1330 | token = match_token(p, tokens, args); |
1224 | switch (token) { | 1331 | switch (token) { |
1225 | case Opt_bsd_df: | 1332 | case Opt_bsd_df: |
1333 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1226 | clear_opt(sbi->s_mount_opt, MINIX_DF); | 1334 | clear_opt(sbi->s_mount_opt, MINIX_DF); |
1227 | break; | 1335 | break; |
1228 | case Opt_minix_df: | 1336 | case Opt_minix_df: |
1337 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1229 | set_opt(sbi->s_mount_opt, MINIX_DF); | 1338 | set_opt(sbi->s_mount_opt, MINIX_DF); |
1339 | |||
1230 | break; | 1340 | break; |
1231 | case Opt_grpid: | 1341 | case Opt_grpid: |
1342 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1232 | set_opt(sbi->s_mount_opt, GRPID); | 1343 | set_opt(sbi->s_mount_opt, GRPID); |
1344 | |||
1233 | break; | 1345 | break; |
1234 | case Opt_nogrpid: | 1346 | case Opt_nogrpid: |
1347 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1235 | clear_opt(sbi->s_mount_opt, GRPID); | 1348 | clear_opt(sbi->s_mount_opt, GRPID); |
1349 | |||
1236 | break; | 1350 | break; |
1237 | case Opt_resuid: | 1351 | case Opt_resuid: |
1238 | if (match_int(&args[0], &option)) | 1352 | if (match_int(&args[0], &option)) |
@@ -1369,14 +1483,13 @@ static int parse_options(char *options, struct super_block *sb, | |||
1369 | data_opt = EXT4_MOUNT_WRITEBACK_DATA; | 1483 | data_opt = EXT4_MOUNT_WRITEBACK_DATA; |
1370 | datacheck: | 1484 | datacheck: |
1371 | if (is_remount) { | 1485 | if (is_remount) { |
1372 | if ((sbi->s_mount_opt & EXT4_MOUNT_DATA_FLAGS) | 1486 | if (test_opt(sb, DATA_FLAGS) != data_opt) { |
1373 | != data_opt) { | ||
1374 | ext4_msg(sb, KERN_ERR, | 1487 | ext4_msg(sb, KERN_ERR, |
1375 | "Cannot change data mode on remount"); | 1488 | "Cannot change data mode on remount"); |
1376 | return 0; | 1489 | return 0; |
1377 | } | 1490 | } |
1378 | } else { | 1491 | } else { |
1379 | sbi->s_mount_opt &= ~EXT4_MOUNT_DATA_FLAGS; | 1492 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); |
1380 | sbi->s_mount_opt |= data_opt; | 1493 | sbi->s_mount_opt |= data_opt; |
1381 | } | 1494 | } |
1382 | break; | 1495 | break; |
@@ -1388,63 +1501,22 @@ static int parse_options(char *options, struct super_block *sb, | |||
1388 | break; | 1501 | break; |
1389 | #ifdef CONFIG_QUOTA | 1502 | #ifdef CONFIG_QUOTA |
1390 | case Opt_usrjquota: | 1503 | case Opt_usrjquota: |
1391 | qtype = USRQUOTA; | 1504 | if (!set_qf_name(sb, USRQUOTA, &args[0])) |
1392 | goto set_qf_name; | ||
1393 | case Opt_grpjquota: | ||
1394 | qtype = GRPQUOTA; | ||
1395 | set_qf_name: | ||
1396 | if (sb_any_quota_loaded(sb) && | ||
1397 | !sbi->s_qf_names[qtype]) { | ||
1398 | ext4_msg(sb, KERN_ERR, | ||
1399 | "Cannot change journaled " | ||
1400 | "quota options when quota turned on"); | ||
1401 | return 0; | 1505 | return 0; |
1402 | } | 1506 | break; |
1403 | qname = match_strdup(&args[0]); | 1507 | case Opt_grpjquota: |
1404 | if (!qname) { | 1508 | if (!set_qf_name(sb, GRPQUOTA, &args[0])) |
1405 | ext4_msg(sb, KERN_ERR, | ||
1406 | "Not enough memory for " | ||
1407 | "storing quotafile name"); | ||
1408 | return 0; | ||
1409 | } | ||
1410 | if (sbi->s_qf_names[qtype] && | ||
1411 | strcmp(sbi->s_qf_names[qtype], qname)) { | ||
1412 | ext4_msg(sb, KERN_ERR, | ||
1413 | "%s quota file already " | ||
1414 | "specified", QTYPE2NAME(qtype)); | ||
1415 | kfree(qname); | ||
1416 | return 0; | ||
1417 | } | ||
1418 | sbi->s_qf_names[qtype] = qname; | ||
1419 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
1420 | ext4_msg(sb, KERN_ERR, | ||
1421 | "quotafile must be on " | ||
1422 | "filesystem root"); | ||
1423 | kfree(sbi->s_qf_names[qtype]); | ||
1424 | sbi->s_qf_names[qtype] = NULL; | ||
1425 | return 0; | 1509 | return 0; |
1426 | } | ||
1427 | set_opt(sbi->s_mount_opt, QUOTA); | ||
1428 | break; | 1510 | break; |
1429 | case Opt_offusrjquota: | 1511 | case Opt_offusrjquota: |
1430 | qtype = USRQUOTA; | 1512 | if (!clear_qf_name(sb, USRQUOTA)) |
1431 | goto clear_qf_name; | 1513 | return 0; |
1514 | break; | ||
1432 | case Opt_offgrpjquota: | 1515 | case Opt_offgrpjquota: |
1433 | qtype = GRPQUOTA; | 1516 | if (!clear_qf_name(sb, GRPQUOTA)) |
1434 | clear_qf_name: | ||
1435 | if (sb_any_quota_loaded(sb) && | ||
1436 | sbi->s_qf_names[qtype]) { | ||
1437 | ext4_msg(sb, KERN_ERR, "Cannot change " | ||
1438 | "journaled quota options when " | ||
1439 | "quota turned on"); | ||
1440 | return 0; | 1517 | return 0; |
1441 | } | ||
1442 | /* | ||
1443 | * The space will be released later when all options | ||
1444 | * are confirmed to be correct | ||
1445 | */ | ||
1446 | sbi->s_qf_names[qtype] = NULL; | ||
1447 | break; | 1518 | break; |
1519 | |||
1448 | case Opt_jqfmt_vfsold: | 1520 | case Opt_jqfmt_vfsold: |
1449 | qfmt = QFMT_VFS_OLD; | 1521 | qfmt = QFMT_VFS_OLD; |
1450 | goto set_qf_format; | 1522 | goto set_qf_format; |
@@ -1509,10 +1581,11 @@ set_qf_format: | |||
1509 | clear_opt(sbi->s_mount_opt, BARRIER); | 1581 | clear_opt(sbi->s_mount_opt, BARRIER); |
1510 | break; | 1582 | break; |
1511 | case Opt_barrier: | 1583 | case Opt_barrier: |
1512 | if (match_int(&args[0], &option)) { | 1584 | if (args[0].from) { |
1513 | set_opt(sbi->s_mount_opt, BARRIER); | 1585 | if (match_int(&args[0], &option)) |
1514 | break; | 1586 | return 0; |
1515 | } | 1587 | } else |
1588 | option = 1; /* No argument, default to 1 */ | ||
1516 | if (option) | 1589 | if (option) |
1517 | set_opt(sbi->s_mount_opt, BARRIER); | 1590 | set_opt(sbi->s_mount_opt, BARRIER); |
1518 | else | 1591 | else |
@@ -1585,10 +1658,11 @@ set_qf_format: | |||
1585 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); | 1658 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); |
1586 | break; | 1659 | break; |
1587 | case Opt_auto_da_alloc: | 1660 | case Opt_auto_da_alloc: |
1588 | if (match_int(&args[0], &option)) { | 1661 | if (args[0].from) { |
1589 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | 1662 | if (match_int(&args[0], &option)) |
1590 | break; | 1663 | return 0; |
1591 | } | 1664 | } else |
1665 | option = 1; /* No argument, default to 1 */ | ||
1592 | if (option) | 1666 | if (option) |
1593 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | 1667 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); |
1594 | else | 1668 | else |
@@ -1600,6 +1674,12 @@ set_qf_format: | |||
1600 | case Opt_nodiscard: | 1674 | case Opt_nodiscard: |
1601 | clear_opt(sbi->s_mount_opt, DISCARD); | 1675 | clear_opt(sbi->s_mount_opt, DISCARD); |
1602 | break; | 1676 | break; |
1677 | case Opt_dioread_nolock: | ||
1678 | set_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
1679 | break; | ||
1680 | case Opt_dioread_lock: | ||
1681 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
1682 | break; | ||
1603 | default: | 1683 | default: |
1604 | ext4_msg(sb, KERN_ERR, | 1684 | ext4_msg(sb, KERN_ERR, |
1605 | "Unrecognized mount option \"%s\" " | 1685 | "Unrecognized mount option \"%s\" " |
@@ -1609,18 +1689,13 @@ set_qf_format: | |||
1609 | } | 1689 | } |
1610 | #ifdef CONFIG_QUOTA | 1690 | #ifdef CONFIG_QUOTA |
1611 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { | 1691 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { |
1612 | if ((sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA) && | 1692 | if (test_opt(sb, USRQUOTA) && sbi->s_qf_names[USRQUOTA]) |
1613 | sbi->s_qf_names[USRQUOTA]) | ||
1614 | clear_opt(sbi->s_mount_opt, USRQUOTA); | 1693 | clear_opt(sbi->s_mount_opt, USRQUOTA); |
1615 | 1694 | ||
1616 | if ((sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA) && | 1695 | if (test_opt(sb, GRPQUOTA) && sbi->s_qf_names[GRPQUOTA]) |
1617 | sbi->s_qf_names[GRPQUOTA]) | ||
1618 | clear_opt(sbi->s_mount_opt, GRPQUOTA); | 1696 | clear_opt(sbi->s_mount_opt, GRPQUOTA); |
1619 | 1697 | ||
1620 | if ((sbi->s_qf_names[USRQUOTA] && | 1698 | if (test_opt(sb, GRPQUOTA) || test_opt(sb, USRQUOTA)) { |
1621 | (sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA)) || | ||
1622 | (sbi->s_qf_names[GRPQUOTA] && | ||
1623 | (sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA))) { | ||
1624 | ext4_msg(sb, KERN_ERR, "old and new quota " | 1699 | ext4_msg(sb, KERN_ERR, "old and new quota " |
1625 | "format mixing"); | 1700 | "format mixing"); |
1626 | return 0; | 1701 | return 0; |
@@ -2423,8 +2498,11 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2423 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); | 2498 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); |
2424 | if (def_mount_opts & EXT4_DEFM_DEBUG) | 2499 | if (def_mount_opts & EXT4_DEFM_DEBUG) |
2425 | set_opt(sbi->s_mount_opt, DEBUG); | 2500 | set_opt(sbi->s_mount_opt, DEBUG); |
2426 | if (def_mount_opts & EXT4_DEFM_BSDGROUPS) | 2501 | if (def_mount_opts & EXT4_DEFM_BSDGROUPS) { |
2502 | ext4_msg(sb, KERN_WARNING, deprecated_msg, "bsdgroups", | ||
2503 | "2.6.38"); | ||
2427 | set_opt(sbi->s_mount_opt, GRPID); | 2504 | set_opt(sbi->s_mount_opt, GRPID); |
2505 | } | ||
2428 | if (def_mount_opts & EXT4_DEFM_UID16) | 2506 | if (def_mount_opts & EXT4_DEFM_UID16) |
2429 | set_opt(sbi->s_mount_opt, NO_UID32); | 2507 | set_opt(sbi->s_mount_opt, NO_UID32); |
2430 | #ifdef CONFIG_EXT4_FS_XATTR | 2508 | #ifdef CONFIG_EXT4_FS_XATTR |
@@ -2436,11 +2514,11 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2436 | set_opt(sbi->s_mount_opt, POSIX_ACL); | 2514 | set_opt(sbi->s_mount_opt, POSIX_ACL); |
2437 | #endif | 2515 | #endif |
2438 | if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA) | 2516 | if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA) |
2439 | sbi->s_mount_opt |= EXT4_MOUNT_JOURNAL_DATA; | 2517 | set_opt(sbi->s_mount_opt, JOURNAL_DATA); |
2440 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED) | 2518 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED) |
2441 | sbi->s_mount_opt |= EXT4_MOUNT_ORDERED_DATA; | 2519 | set_opt(sbi->s_mount_opt, ORDERED_DATA); |
2442 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK) | 2520 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK) |
2443 | sbi->s_mount_opt |= EXT4_MOUNT_WRITEBACK_DATA; | 2521 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); |
2444 | 2522 | ||
2445 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC) | 2523 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC) |
2446 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); | 2524 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); |
@@ -2468,7 +2546,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2468 | goto failed_mount; | 2546 | goto failed_mount; |
2469 | 2547 | ||
2470 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 2548 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
2471 | ((sbi->s_mount_opt & EXT4_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 2549 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
2472 | 2550 | ||
2473 | if (le32_to_cpu(es->s_rev_level) == EXT4_GOOD_OLD_REV && | 2551 | if (le32_to_cpu(es->s_rev_level) == EXT4_GOOD_OLD_REV && |
2474 | (EXT4_HAS_COMPAT_FEATURE(sb, ~0U) || | 2552 | (EXT4_HAS_COMPAT_FEATURE(sb, ~0U) || |
@@ -2757,7 +2835,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2757 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { | 2835 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { |
2758 | ext4_msg(sb, KERN_ERR, "required journal recovery " | 2836 | ext4_msg(sb, KERN_ERR, "required journal recovery " |
2759 | "suppressed and not mounted read-only"); | 2837 | "suppressed and not mounted read-only"); |
2760 | goto failed_mount4; | 2838 | goto failed_mount_wq; |
2761 | } else { | 2839 | } else { |
2762 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); | 2840 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); |
2763 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); | 2841 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); |
@@ -2770,7 +2848,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2770 | !jbd2_journal_set_features(EXT4_SB(sb)->s_journal, 0, 0, | 2848 | !jbd2_journal_set_features(EXT4_SB(sb)->s_journal, 0, 0, |
2771 | JBD2_FEATURE_INCOMPAT_64BIT)) { | 2849 | JBD2_FEATURE_INCOMPAT_64BIT)) { |
2772 | ext4_msg(sb, KERN_ERR, "Failed to set 64-bit journal feature"); | 2850 | ext4_msg(sb, KERN_ERR, "Failed to set 64-bit journal feature"); |
2773 | goto failed_mount4; | 2851 | goto failed_mount_wq; |
2774 | } | 2852 | } |
2775 | 2853 | ||
2776 | if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) { | 2854 | if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) { |
@@ -2809,7 +2887,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2809 | (sbi->s_journal, 0, 0, JBD2_FEATURE_INCOMPAT_REVOKE)) { | 2887 | (sbi->s_journal, 0, 0, JBD2_FEATURE_INCOMPAT_REVOKE)) { |
2810 | ext4_msg(sb, KERN_ERR, "Journal does not support " | 2888 | ext4_msg(sb, KERN_ERR, "Journal does not support " |
2811 | "requested data journaling mode"); | 2889 | "requested data journaling mode"); |
2812 | goto failed_mount4; | 2890 | goto failed_mount_wq; |
2813 | } | 2891 | } |
2814 | default: | 2892 | default: |
2815 | break; | 2893 | break; |
@@ -2817,13 +2895,17 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2817 | set_task_ioprio(sbi->s_journal->j_task, journal_ioprio); | 2895 | set_task_ioprio(sbi->s_journal->j_task, journal_ioprio); |
2818 | 2896 | ||
2819 | no_journal: | 2897 | no_journal: |
2820 | |||
2821 | if (test_opt(sb, NOBH)) { | 2898 | if (test_opt(sb, NOBH)) { |
2822 | if (!(test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_WRITEBACK_DATA)) { | 2899 | if (!(test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_WRITEBACK_DATA)) { |
2823 | ext4_msg(sb, KERN_WARNING, "Ignoring nobh option - " | 2900 | ext4_msg(sb, KERN_WARNING, "Ignoring nobh option - " |
2824 | "its supported only with writeback mode"); | 2901 | "its supported only with writeback mode"); |
2825 | clear_opt(sbi->s_mount_opt, NOBH); | 2902 | clear_opt(sbi->s_mount_opt, NOBH); |
2826 | } | 2903 | } |
2904 | if (test_opt(sb, DIOREAD_NOLOCK)) { | ||
2905 | ext4_msg(sb, KERN_WARNING, "dioread_nolock option is " | ||
2906 | "not supported with nobh mode"); | ||
2907 | goto failed_mount_wq; | ||
2908 | } | ||
2827 | } | 2909 | } |
2828 | EXT4_SB(sb)->dio_unwritten_wq = create_workqueue("ext4-dio-unwritten"); | 2910 | EXT4_SB(sb)->dio_unwritten_wq = create_workqueue("ext4-dio-unwritten"); |
2829 | if (!EXT4_SB(sb)->dio_unwritten_wq) { | 2911 | if (!EXT4_SB(sb)->dio_unwritten_wq) { |
@@ -2888,6 +2970,18 @@ no_journal: | |||
2888 | "requested data journaling mode"); | 2970 | "requested data journaling mode"); |
2889 | clear_opt(sbi->s_mount_opt, DELALLOC); | 2971 | clear_opt(sbi->s_mount_opt, DELALLOC); |
2890 | } | 2972 | } |
2973 | if (test_opt(sb, DIOREAD_NOLOCK)) { | ||
2974 | if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) { | ||
2975 | ext4_msg(sb, KERN_WARNING, "Ignoring dioread_nolock " | ||
2976 | "option - requested data journaling mode"); | ||
2977 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
2978 | } | ||
2979 | if (sb->s_blocksize < PAGE_SIZE) { | ||
2980 | ext4_msg(sb, KERN_WARNING, "Ignoring dioread_nolock " | ||
2981 | "option - block size is too small"); | ||
2982 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
2983 | } | ||
2984 | } | ||
2891 | 2985 | ||
2892 | err = ext4_setup_system_zone(sb); | 2986 | err = ext4_setup_system_zone(sb); |
2893 | if (err) { | 2987 | if (err) { |
@@ -3351,10 +3445,9 @@ static void ext4_clear_journal_err(struct super_block *sb, | |||
3351 | char nbuf[16]; | 3445 | char nbuf[16]; |
3352 | 3446 | ||
3353 | errstr = ext4_decode_error(sb, j_errno, nbuf); | 3447 | errstr = ext4_decode_error(sb, j_errno, nbuf); |
3354 | ext4_warning(sb, __func__, "Filesystem error recorded " | 3448 | ext4_warning(sb, "Filesystem error recorded " |
3355 | "from previous mount: %s", errstr); | 3449 | "from previous mount: %s", errstr); |
3356 | ext4_warning(sb, __func__, "Marking fs in need of " | 3450 | ext4_warning(sb, "Marking fs in need of filesystem check."); |
3357 | "filesystem check."); | ||
3358 | 3451 | ||
3359 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; | 3452 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; |
3360 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); | 3453 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); |
@@ -3505,7 +3598,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) | |||
3505 | ext4_abort(sb, __func__, "Abort forced by user"); | 3598 | ext4_abort(sb, __func__, "Abort forced by user"); |
3506 | 3599 | ||
3507 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 3600 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
3508 | ((sbi->s_mount_opt & EXT4_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 3601 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
3509 | 3602 | ||
3510 | es = sbi->s_es; | 3603 | es = sbi->s_es; |
3511 | 3604 | ||
@@ -3908,9 +4001,7 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
3908 | ext4_lblk_t blk = off >> EXT4_BLOCK_SIZE_BITS(sb); | 4001 | ext4_lblk_t blk = off >> EXT4_BLOCK_SIZE_BITS(sb); |
3909 | int err = 0; | 4002 | int err = 0; |
3910 | int offset = off & (sb->s_blocksize - 1); | 4003 | int offset = off & (sb->s_blocksize - 1); |
3911 | int tocopy; | ||
3912 | int journal_quota = EXT4_SB(sb)->s_qf_names[type] != NULL; | 4004 | int journal_quota = EXT4_SB(sb)->s_qf_names[type] != NULL; |
3913 | size_t towrite = len; | ||
3914 | struct buffer_head *bh; | 4005 | struct buffer_head *bh; |
3915 | handle_t *handle = journal_current_handle(); | 4006 | handle_t *handle = journal_current_handle(); |
3916 | 4007 | ||
@@ -3920,52 +4011,53 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
3920 | (unsigned long long)off, (unsigned long long)len); | 4011 | (unsigned long long)off, (unsigned long long)len); |
3921 | return -EIO; | 4012 | return -EIO; |
3922 | } | 4013 | } |
4014 | /* | ||
4015 | * Since we account only one data block in transaction credits, | ||
4016 | * then it is impossible to cross a block boundary. | ||
4017 | */ | ||
4018 | if (sb->s_blocksize - offset < len) { | ||
4019 | ext4_msg(sb, KERN_WARNING, "Quota write (off=%llu, len=%llu)" | ||
4020 | " cancelled because not block aligned", | ||
4021 | (unsigned long long)off, (unsigned long long)len); | ||
4022 | return -EIO; | ||
4023 | } | ||
4024 | |||
3923 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); | 4025 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); |
3924 | while (towrite > 0) { | 4026 | bh = ext4_bread(handle, inode, blk, 1, &err); |
3925 | tocopy = sb->s_blocksize - offset < towrite ? | 4027 | if (!bh) |
3926 | sb->s_blocksize - offset : towrite; | 4028 | goto out; |
3927 | bh = ext4_bread(handle, inode, blk, 1, &err); | 4029 | if (journal_quota) { |
3928 | if (!bh) | 4030 | err = ext4_journal_get_write_access(handle, bh); |
4031 | if (err) { | ||
4032 | brelse(bh); | ||
3929 | goto out; | 4033 | goto out; |
3930 | if (journal_quota) { | ||
3931 | err = ext4_journal_get_write_access(handle, bh); | ||
3932 | if (err) { | ||
3933 | brelse(bh); | ||
3934 | goto out; | ||
3935 | } | ||
3936 | } | 4034 | } |
3937 | lock_buffer(bh); | ||
3938 | memcpy(bh->b_data+offset, data, tocopy); | ||
3939 | flush_dcache_page(bh->b_page); | ||
3940 | unlock_buffer(bh); | ||
3941 | if (journal_quota) | ||
3942 | err = ext4_handle_dirty_metadata(handle, NULL, bh); | ||
3943 | else { | ||
3944 | /* Always do at least ordered writes for quotas */ | ||
3945 | err = ext4_jbd2_file_inode(handle, inode); | ||
3946 | mark_buffer_dirty(bh); | ||
3947 | } | ||
3948 | brelse(bh); | ||
3949 | if (err) | ||
3950 | goto out; | ||
3951 | offset = 0; | ||
3952 | towrite -= tocopy; | ||
3953 | data += tocopy; | ||
3954 | blk++; | ||
3955 | } | 4035 | } |
4036 | lock_buffer(bh); | ||
4037 | memcpy(bh->b_data+offset, data, len); | ||
4038 | flush_dcache_page(bh->b_page); | ||
4039 | unlock_buffer(bh); | ||
4040 | if (journal_quota) | ||
4041 | err = ext4_handle_dirty_metadata(handle, NULL, bh); | ||
4042 | else { | ||
4043 | /* Always do at least ordered writes for quotas */ | ||
4044 | err = ext4_jbd2_file_inode(handle, inode); | ||
4045 | mark_buffer_dirty(bh); | ||
4046 | } | ||
4047 | brelse(bh); | ||
3956 | out: | 4048 | out: |
3957 | if (len == towrite) { | 4049 | if (err) { |
3958 | mutex_unlock(&inode->i_mutex); | 4050 | mutex_unlock(&inode->i_mutex); |
3959 | return err; | 4051 | return err; |
3960 | } | 4052 | } |
3961 | if (inode->i_size < off+len-towrite) { | 4053 | if (inode->i_size < off + len) { |
3962 | i_size_write(inode, off+len-towrite); | 4054 | i_size_write(inode, off + len); |
3963 | EXT4_I(inode)->i_disksize = inode->i_size; | 4055 | EXT4_I(inode)->i_disksize = inode->i_size; |
3964 | } | 4056 | } |
3965 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 4057 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
3966 | ext4_mark_inode_dirty(handle, inode); | 4058 | ext4_mark_inode_dirty(handle, inode); |
3967 | mutex_unlock(&inode->i_mutex); | 4059 | mutex_unlock(&inode->i_mutex); |
3968 | return len - towrite; | 4060 | return len; |
3969 | } | 4061 | } |
3970 | 4062 | ||
3971 | #endif | 4063 | #endif |
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index ab3a95ee5e7e..b4c5aa8489d8 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c | |||
@@ -227,7 +227,8 @@ ext4_xattr_block_get(struct inode *inode, int name_index, const char *name, | |||
227 | ea_bdebug(bh, "b_count=%d, refcount=%d", | 227 | ea_bdebug(bh, "b_count=%d, refcount=%d", |
228 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); | 228 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); |
229 | if (ext4_xattr_check_block(bh)) { | 229 | if (ext4_xattr_check_block(bh)) { |
230 | bad_block: ext4_error(inode->i_sb, __func__, | 230 | bad_block: |
231 | ext4_error(inode->i_sb, | ||
231 | "inode %lu: bad block %llu", inode->i_ino, | 232 | "inode %lu: bad block %llu", inode->i_ino, |
232 | EXT4_I(inode)->i_file_acl); | 233 | EXT4_I(inode)->i_file_acl); |
233 | error = -EIO; | 234 | error = -EIO; |
@@ -267,7 +268,7 @@ ext4_xattr_ibody_get(struct inode *inode, int name_index, const char *name, | |||
267 | void *end; | 268 | void *end; |
268 | int error; | 269 | int error; |
269 | 270 | ||
270 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)) | 271 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) |
271 | return -ENODATA; | 272 | return -ENODATA; |
272 | error = ext4_get_inode_loc(inode, &iloc); | 273 | error = ext4_get_inode_loc(inode, &iloc); |
273 | if (error) | 274 | if (error) |
@@ -371,7 +372,7 @@ ext4_xattr_block_list(struct dentry *dentry, char *buffer, size_t buffer_size) | |||
371 | ea_bdebug(bh, "b_count=%d, refcount=%d", | 372 | ea_bdebug(bh, "b_count=%d, refcount=%d", |
372 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); | 373 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); |
373 | if (ext4_xattr_check_block(bh)) { | 374 | if (ext4_xattr_check_block(bh)) { |
374 | ext4_error(inode->i_sb, __func__, | 375 | ext4_error(inode->i_sb, |
375 | "inode %lu: bad block %llu", inode->i_ino, | 376 | "inode %lu: bad block %llu", inode->i_ino, |
376 | EXT4_I(inode)->i_file_acl); | 377 | EXT4_I(inode)->i_file_acl); |
377 | error = -EIO; | 378 | error = -EIO; |
@@ -396,7 +397,7 @@ ext4_xattr_ibody_list(struct dentry *dentry, char *buffer, size_t buffer_size) | |||
396 | void *end; | 397 | void *end; |
397 | int error; | 398 | int error; |
398 | 399 | ||
399 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)) | 400 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) |
400 | return 0; | 401 | return 0; |
401 | error = ext4_get_inode_loc(inode, &iloc); | 402 | error = ext4_get_inode_loc(inode, &iloc); |
402 | if (error) | 403 | if (error) |
@@ -665,9 +666,8 @@ ext4_xattr_block_find(struct inode *inode, struct ext4_xattr_info *i, | |||
665 | atomic_read(&(bs->bh->b_count)), | 666 | atomic_read(&(bs->bh->b_count)), |
666 | le32_to_cpu(BHDR(bs->bh)->h_refcount)); | 667 | le32_to_cpu(BHDR(bs->bh)->h_refcount)); |
667 | if (ext4_xattr_check_block(bs->bh)) { | 668 | if (ext4_xattr_check_block(bs->bh)) { |
668 | ext4_error(sb, __func__, | 669 | ext4_error(sb, "inode %lu: bad block %llu", |
669 | "inode %lu: bad block %llu", inode->i_ino, | 670 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
670 | EXT4_I(inode)->i_file_acl); | ||
671 | error = -EIO; | 671 | error = -EIO; |
672 | goto cleanup; | 672 | goto cleanup; |
673 | } | 673 | } |
@@ -880,9 +880,8 @@ cleanup_dquot: | |||
880 | goto cleanup; | 880 | goto cleanup; |
881 | 881 | ||
882 | bad_block: | 882 | bad_block: |
883 | ext4_error(inode->i_sb, __func__, | 883 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
884 | "inode %lu: bad block %llu", inode->i_ino, | 884 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
885 | EXT4_I(inode)->i_file_acl); | ||
886 | goto cleanup; | 885 | goto cleanup; |
887 | 886 | ||
888 | #undef header | 887 | #undef header |
@@ -908,7 +907,7 @@ ext4_xattr_ibody_find(struct inode *inode, struct ext4_xattr_info *i, | |||
908 | is->s.base = is->s.first = IFIRST(header); | 907 | is->s.base = is->s.first = IFIRST(header); |
909 | is->s.here = is->s.first; | 908 | is->s.here = is->s.first; |
910 | is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size; | 909 | is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size; |
911 | if (EXT4_I(inode)->i_state & EXT4_STATE_XATTR) { | 910 | if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) { |
912 | error = ext4_xattr_check_names(IFIRST(header), is->s.end); | 911 | error = ext4_xattr_check_names(IFIRST(header), is->s.end); |
913 | if (error) | 912 | if (error) |
914 | return error; | 913 | return error; |
@@ -940,10 +939,10 @@ ext4_xattr_ibody_set(handle_t *handle, struct inode *inode, | |||
940 | header = IHDR(inode, ext4_raw_inode(&is->iloc)); | 939 | header = IHDR(inode, ext4_raw_inode(&is->iloc)); |
941 | if (!IS_LAST_ENTRY(s->first)) { | 940 | if (!IS_LAST_ENTRY(s->first)) { |
942 | header->h_magic = cpu_to_le32(EXT4_XATTR_MAGIC); | 941 | header->h_magic = cpu_to_le32(EXT4_XATTR_MAGIC); |
943 | EXT4_I(inode)->i_state |= EXT4_STATE_XATTR; | 942 | ext4_set_inode_state(inode, EXT4_STATE_XATTR); |
944 | } else { | 943 | } else { |
945 | header->h_magic = cpu_to_le32(0); | 944 | header->h_magic = cpu_to_le32(0); |
946 | EXT4_I(inode)->i_state &= ~EXT4_STATE_XATTR; | 945 | ext4_clear_inode_state(inode, EXT4_STATE_XATTR); |
947 | } | 946 | } |
948 | return 0; | 947 | return 0; |
949 | } | 948 | } |
@@ -986,8 +985,8 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
986 | if (strlen(name) > 255) | 985 | if (strlen(name) > 255) |
987 | return -ERANGE; | 986 | return -ERANGE; |
988 | down_write(&EXT4_I(inode)->xattr_sem); | 987 | down_write(&EXT4_I(inode)->xattr_sem); |
989 | no_expand = EXT4_I(inode)->i_state & EXT4_STATE_NO_EXPAND; | 988 | no_expand = ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND); |
990 | EXT4_I(inode)->i_state |= EXT4_STATE_NO_EXPAND; | 989 | ext4_set_inode_state(inode, EXT4_STATE_NO_EXPAND); |
991 | 990 | ||
992 | error = ext4_get_inode_loc(inode, &is.iloc); | 991 | error = ext4_get_inode_loc(inode, &is.iloc); |
993 | if (error) | 992 | if (error) |
@@ -997,10 +996,10 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
997 | if (error) | 996 | if (error) |
998 | goto cleanup; | 997 | goto cleanup; |
999 | 998 | ||
1000 | if (EXT4_I(inode)->i_state & EXT4_STATE_NEW) { | 999 | if (ext4_test_inode_state(inode, EXT4_STATE_NEW)) { |
1001 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); | 1000 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); |
1002 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); | 1001 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); |
1003 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NEW; | 1002 | ext4_clear_inode_state(inode, EXT4_STATE_NEW); |
1004 | } | 1003 | } |
1005 | 1004 | ||
1006 | error = ext4_xattr_ibody_find(inode, &i, &is); | 1005 | error = ext4_xattr_ibody_find(inode, &i, &is); |
@@ -1052,7 +1051,7 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
1052 | ext4_xattr_update_super_block(handle, inode->i_sb); | 1051 | ext4_xattr_update_super_block(handle, inode->i_sb); |
1053 | inode->i_ctime = ext4_current_time(inode); | 1052 | inode->i_ctime = ext4_current_time(inode); |
1054 | if (!value) | 1053 | if (!value) |
1055 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NO_EXPAND; | 1054 | ext4_clear_inode_state(inode, EXT4_STATE_NO_EXPAND); |
1056 | error = ext4_mark_iloc_dirty(handle, inode, &is.iloc); | 1055 | error = ext4_mark_iloc_dirty(handle, inode, &is.iloc); |
1057 | /* | 1056 | /* |
1058 | * The bh is consumed by ext4_mark_iloc_dirty, even with | 1057 | * The bh is consumed by ext4_mark_iloc_dirty, even with |
@@ -1067,7 +1066,7 @@ cleanup: | |||
1067 | brelse(is.iloc.bh); | 1066 | brelse(is.iloc.bh); |
1068 | brelse(bs.bh); | 1067 | brelse(bs.bh); |
1069 | if (no_expand == 0) | 1068 | if (no_expand == 0) |
1070 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NO_EXPAND; | 1069 | ext4_clear_inode_state(inode, EXT4_STATE_NO_EXPAND); |
1071 | up_write(&EXT4_I(inode)->xattr_sem); | 1070 | up_write(&EXT4_I(inode)->xattr_sem); |
1072 | return error; | 1071 | return error; |
1073 | } | 1072 | } |
@@ -1195,9 +1194,8 @@ retry: | |||
1195 | if (!bh) | 1194 | if (!bh) |
1196 | goto cleanup; | 1195 | goto cleanup; |
1197 | if (ext4_xattr_check_block(bh)) { | 1196 | if (ext4_xattr_check_block(bh)) { |
1198 | ext4_error(inode->i_sb, __func__, | 1197 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
1199 | "inode %lu: bad block %llu", inode->i_ino, | 1198 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1200 | EXT4_I(inode)->i_file_acl); | ||
1201 | error = -EIO; | 1199 | error = -EIO; |
1202 | goto cleanup; | 1200 | goto cleanup; |
1203 | } | 1201 | } |
@@ -1302,6 +1300,8 @@ retry: | |||
1302 | 1300 | ||
1303 | /* Remove the chosen entry from the inode */ | 1301 | /* Remove the chosen entry from the inode */ |
1304 | error = ext4_xattr_ibody_set(handle, inode, &i, is); | 1302 | error = ext4_xattr_ibody_set(handle, inode, &i, is); |
1303 | if (error) | ||
1304 | goto cleanup; | ||
1305 | 1305 | ||
1306 | entry = IFIRST(header); | 1306 | entry = IFIRST(header); |
1307 | if (entry_size + EXT4_XATTR_SIZE(size) >= new_extra_isize) | 1307 | if (entry_size + EXT4_XATTR_SIZE(size) >= new_extra_isize) |
@@ -1372,16 +1372,14 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode) | |||
1372 | goto cleanup; | 1372 | goto cleanup; |
1373 | bh = sb_bread(inode->i_sb, EXT4_I(inode)->i_file_acl); | 1373 | bh = sb_bread(inode->i_sb, EXT4_I(inode)->i_file_acl); |
1374 | if (!bh) { | 1374 | if (!bh) { |
1375 | ext4_error(inode->i_sb, __func__, | 1375 | ext4_error(inode->i_sb, "inode %lu: block %llu read error", |
1376 | "inode %lu: block %llu read error", inode->i_ino, | 1376 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1377 | EXT4_I(inode)->i_file_acl); | ||
1378 | goto cleanup; | 1377 | goto cleanup; |
1379 | } | 1378 | } |
1380 | if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) || | 1379 | if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) || |
1381 | BHDR(bh)->h_blocks != cpu_to_le32(1)) { | 1380 | BHDR(bh)->h_blocks != cpu_to_le32(1)) { |
1382 | ext4_error(inode->i_sb, __func__, | 1381 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
1383 | "inode %lu: bad block %llu", inode->i_ino, | 1382 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1384 | EXT4_I(inode)->i_file_acl); | ||
1385 | goto cleanup; | 1383 | goto cleanup; |
1386 | } | 1384 | } |
1387 | ext4_xattr_release_block(handle, inode, bh); | 1385 | ext4_xattr_release_block(handle, inode, bh); |
@@ -1506,7 +1504,7 @@ again: | |||
1506 | } | 1504 | } |
1507 | bh = sb_bread(inode->i_sb, ce->e_block); | 1505 | bh = sb_bread(inode->i_sb, ce->e_block); |
1508 | if (!bh) { | 1506 | if (!bh) { |
1509 | ext4_error(inode->i_sb, __func__, | 1507 | ext4_error(inode->i_sb, |
1510 | "inode %lu: block %lu read error", | 1508 | "inode %lu: block %lu read error", |
1511 | inode->i_ino, (unsigned long) ce->e_block); | 1509 | inode->i_ino, (unsigned long) ce->e_block); |
1512 | } else if (le32_to_cpu(BHDR(bh)->h_refcount) >= | 1510 | } else if (le32_to_cpu(BHDR(bh)->h_refcount) >= |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 14da530b05ca..fbeecdc194dc 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -577,7 +577,7 @@ static inline loff_t fat_i_pos_read(struct msdos_sb_info *sbi, | |||
577 | return i_pos; | 577 | return i_pos; |
578 | } | 578 | } |
579 | 579 | ||
580 | static int fat_write_inode(struct inode *inode, int wait) | 580 | static int __fat_write_inode(struct inode *inode, int wait) |
581 | { | 581 | { |
582 | struct super_block *sb = inode->i_sb; | 582 | struct super_block *sb = inode->i_sb; |
583 | struct msdos_sb_info *sbi = MSDOS_SB(sb); | 583 | struct msdos_sb_info *sbi = MSDOS_SB(sb); |
@@ -634,9 +634,14 @@ retry: | |||
634 | return err; | 634 | return err; |
635 | } | 635 | } |
636 | 636 | ||
637 | static int fat_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
638 | { | ||
639 | return __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
640 | } | ||
641 | |||
637 | int fat_sync_inode(struct inode *inode) | 642 | int fat_sync_inode(struct inode *inode) |
638 | { | 643 | { |
639 | return fat_write_inode(inode, 1); | 644 | return __fat_write_inode(inode, 1); |
640 | } | 645 | } |
641 | 646 | ||
642 | EXPORT_SYMBOL_GPL(fat_sync_inode); | 647 | EXPORT_SYMBOL_GPL(fat_sync_inode); |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 1a7c42c64ff4..76fc4d594acb 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -381,10 +381,10 @@ static void queue_io(struct bdi_writeback *wb, unsigned long *older_than_this) | |||
381 | move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); | 381 | move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); |
382 | } | 382 | } |
383 | 383 | ||
384 | static int write_inode(struct inode *inode, int sync) | 384 | static int write_inode(struct inode *inode, struct writeback_control *wbc) |
385 | { | 385 | { |
386 | if (inode->i_sb->s_op->write_inode && !is_bad_inode(inode)) | 386 | if (inode->i_sb->s_op->write_inode && !is_bad_inode(inode)) |
387 | return inode->i_sb->s_op->write_inode(inode, sync); | 387 | return inode->i_sb->s_op->write_inode(inode, wbc); |
388 | return 0; | 388 | return 0; |
389 | } | 389 | } |
390 | 390 | ||
@@ -421,7 +421,6 @@ static int | |||
421 | writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | 421 | writeback_single_inode(struct inode *inode, struct writeback_control *wbc) |
422 | { | 422 | { |
423 | struct address_space *mapping = inode->i_mapping; | 423 | struct address_space *mapping = inode->i_mapping; |
424 | int wait = wbc->sync_mode == WB_SYNC_ALL; | ||
425 | unsigned dirty; | 424 | unsigned dirty; |
426 | int ret; | 425 | int ret; |
427 | 426 | ||
@@ -439,7 +438,7 @@ writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | |||
439 | * We'll have another go at writing back this inode when we | 438 | * We'll have another go at writing back this inode when we |
440 | * completed a full scan of b_io. | 439 | * completed a full scan of b_io. |
441 | */ | 440 | */ |
442 | if (!wait) { | 441 | if (wbc->sync_mode != WB_SYNC_ALL) { |
443 | requeue_io(inode); | 442 | requeue_io(inode); |
444 | return 0; | 443 | return 0; |
445 | } | 444 | } |
@@ -461,15 +460,20 @@ writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | |||
461 | 460 | ||
462 | ret = do_writepages(mapping, wbc); | 461 | ret = do_writepages(mapping, wbc); |
463 | 462 | ||
464 | /* Don't write the inode if only I_DIRTY_PAGES was set */ | 463 | /* |
465 | if (dirty & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) { | 464 | * Make sure to wait on the data before writing out the metadata. |
466 | int err = write_inode(inode, wait); | 465 | * This is important for filesystems that modify metadata on data |
466 | * I/O completion. | ||
467 | */ | ||
468 | if (wbc->sync_mode == WB_SYNC_ALL) { | ||
469 | int err = filemap_fdatawait(mapping); | ||
467 | if (ret == 0) | 470 | if (ret == 0) |
468 | ret = err; | 471 | ret = err; |
469 | } | 472 | } |
470 | 473 | ||
471 | if (wait) { | 474 | /* Don't write the inode if only I_DIRTY_PAGES was set */ |
472 | int err = filemap_fdatawait(mapping); | 475 | if (dirty & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) { |
476 | int err = write_inode(inode, wbc); | ||
473 | if (ret == 0) | 477 | if (ret == 0) |
474 | ret = err; | 478 | ret = err; |
475 | } | 479 | } |
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 51d9e33d634f..eb7e9423691f 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
@@ -865,13 +865,10 @@ static int fuse_notify_inval_inode(struct fuse_conn *fc, unsigned int size, | |||
865 | 865 | ||
866 | down_read(&fc->killsb); | 866 | down_read(&fc->killsb); |
867 | err = -ENOENT; | 867 | err = -ENOENT; |
868 | if (!fc->sb) | 868 | if (fc->sb) { |
869 | goto err_unlock; | 869 | err = fuse_reverse_inval_inode(fc->sb, outarg.ino, |
870 | 870 | outarg.off, outarg.len); | |
871 | err = fuse_reverse_inval_inode(fc->sb, outarg.ino, | 871 | } |
872 | outarg.off, outarg.len); | ||
873 | |||
874 | err_unlock: | ||
875 | up_read(&fc->killsb); | 872 | up_read(&fc->killsb); |
876 | return err; | 873 | return err; |
877 | 874 | ||
@@ -884,10 +881,15 @@ static int fuse_notify_inval_entry(struct fuse_conn *fc, unsigned int size, | |||
884 | struct fuse_copy_state *cs) | 881 | struct fuse_copy_state *cs) |
885 | { | 882 | { |
886 | struct fuse_notify_inval_entry_out outarg; | 883 | struct fuse_notify_inval_entry_out outarg; |
887 | int err = -EINVAL; | 884 | int err = -ENOMEM; |
888 | char buf[FUSE_NAME_MAX+1]; | 885 | char *buf; |
889 | struct qstr name; | 886 | struct qstr name; |
890 | 887 | ||
888 | buf = kzalloc(FUSE_NAME_MAX + 1, GFP_KERNEL); | ||
889 | if (!buf) | ||
890 | goto err; | ||
891 | |||
892 | err = -EINVAL; | ||
891 | if (size < sizeof(outarg)) | 893 | if (size < sizeof(outarg)) |
892 | goto err; | 894 | goto err; |
893 | 895 | ||
@@ -910,16 +912,14 @@ static int fuse_notify_inval_entry(struct fuse_conn *fc, unsigned int size, | |||
910 | 912 | ||
911 | down_read(&fc->killsb); | 913 | down_read(&fc->killsb); |
912 | err = -ENOENT; | 914 | err = -ENOENT; |
913 | if (!fc->sb) | 915 | if (fc->sb) |
914 | goto err_unlock; | 916 | err = fuse_reverse_inval_entry(fc->sb, outarg.parent, &name); |
915 | |||
916 | err = fuse_reverse_inval_entry(fc->sb, outarg.parent, &name); | ||
917 | |||
918 | err_unlock: | ||
919 | up_read(&fc->killsb); | 917 | up_read(&fc->killsb); |
918 | kfree(buf); | ||
920 | return err; | 919 | return err; |
921 | 920 | ||
922 | err: | 921 | err: |
922 | kfree(buf); | ||
923 | fuse_copy_finish(cs); | 923 | fuse_copy_finish(cs); |
924 | return err; | 924 | return err; |
925 | } | 925 | } |
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 7b8da9415267..0c1d0b82dcf1 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c | |||
@@ -1061,8 +1061,8 @@ out: | |||
1061 | 1061 | ||
1062 | int gfs2_releasepage(struct page *page, gfp_t gfp_mask) | 1062 | int gfs2_releasepage(struct page *page, gfp_t gfp_mask) |
1063 | { | 1063 | { |
1064 | struct inode *aspace = page->mapping->host; | 1064 | struct address_space *mapping = page->mapping; |
1065 | struct gfs2_sbd *sdp = aspace->i_sb->s_fs_info; | 1065 | struct gfs2_sbd *sdp = gfs2_mapping2sbd(mapping); |
1066 | struct buffer_head *bh, *head; | 1066 | struct buffer_head *bh, *head; |
1067 | struct gfs2_bufdata *bd; | 1067 | struct gfs2_bufdata *bd; |
1068 | 1068 | ||
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index f42663325931..454d4b4eb36b 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/list.h> | 19 | #include <linux/list.h> |
20 | #include <linux/wait.h> | 20 | #include <linux/wait.h> |
21 | #include <linux/module.h> | 21 | #include <linux/module.h> |
22 | #include <linux/rwsem.h> | ||
23 | #include <asm/uaccess.h> | 22 | #include <asm/uaccess.h> |
24 | #include <linux/seq_file.h> | 23 | #include <linux/seq_file.h> |
25 | #include <linux/debugfs.h> | 24 | #include <linux/debugfs.h> |
@@ -60,7 +59,6 @@ static int __dump_glock(struct seq_file *seq, const struct gfs2_glock *gl); | |||
60 | #define GLOCK_BUG_ON(gl,x) do { if (unlikely(x)) { __dump_glock(NULL, gl); BUG(); } } while(0) | 59 | #define GLOCK_BUG_ON(gl,x) do { if (unlikely(x)) { __dump_glock(NULL, gl); BUG(); } } while(0) |
61 | static void do_xmote(struct gfs2_glock *gl, struct gfs2_holder *gh, unsigned int target); | 60 | static void do_xmote(struct gfs2_glock *gl, struct gfs2_holder *gh, unsigned int target); |
62 | 61 | ||
63 | static DECLARE_RWSEM(gfs2_umount_flush_sem); | ||
64 | static struct dentry *gfs2_root; | 62 | static struct dentry *gfs2_root; |
65 | static struct workqueue_struct *glock_workqueue; | 63 | static struct workqueue_struct *glock_workqueue; |
66 | struct workqueue_struct *gfs2_delete_workqueue; | 64 | struct workqueue_struct *gfs2_delete_workqueue; |
@@ -154,12 +152,14 @@ static unsigned int gl_hash(const struct gfs2_sbd *sdp, | |||
154 | static void glock_free(struct gfs2_glock *gl) | 152 | static void glock_free(struct gfs2_glock *gl) |
155 | { | 153 | { |
156 | struct gfs2_sbd *sdp = gl->gl_sbd; | 154 | struct gfs2_sbd *sdp = gl->gl_sbd; |
157 | struct inode *aspace = gl->gl_aspace; | 155 | struct address_space *mapping = gfs2_glock2aspace(gl); |
156 | struct kmem_cache *cachep = gfs2_glock_cachep; | ||
158 | 157 | ||
159 | if (aspace) | 158 | GLOCK_BUG_ON(gl, mapping && mapping->nrpages); |
160 | gfs2_aspace_put(aspace); | ||
161 | trace_gfs2_glock_put(gl); | 159 | trace_gfs2_glock_put(gl); |
162 | sdp->sd_lockstruct.ls_ops->lm_put_lock(gfs2_glock_cachep, gl); | 160 | if (mapping) |
161 | cachep = gfs2_glock_aspace_cachep; | ||
162 | sdp->sd_lockstruct.ls_ops->lm_put_lock(cachep, gl); | ||
163 | } | 163 | } |
164 | 164 | ||
165 | /** | 165 | /** |
@@ -712,7 +712,6 @@ static void glock_work_func(struct work_struct *work) | |||
712 | finish_xmote(gl, gl->gl_reply); | 712 | finish_xmote(gl, gl->gl_reply); |
713 | drop_ref = 1; | 713 | drop_ref = 1; |
714 | } | 714 | } |
715 | down_read(&gfs2_umount_flush_sem); | ||
716 | spin_lock(&gl->gl_spin); | 715 | spin_lock(&gl->gl_spin); |
717 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && | 716 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && |
718 | gl->gl_state != LM_ST_UNLOCKED && | 717 | gl->gl_state != LM_ST_UNLOCKED && |
@@ -725,7 +724,6 @@ static void glock_work_func(struct work_struct *work) | |||
725 | } | 724 | } |
726 | run_queue(gl, 0); | 725 | run_queue(gl, 0); |
727 | spin_unlock(&gl->gl_spin); | 726 | spin_unlock(&gl->gl_spin); |
728 | up_read(&gfs2_umount_flush_sem); | ||
729 | if (!delay || | 727 | if (!delay || |
730 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) | 728 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) |
731 | gfs2_glock_put(gl); | 729 | gfs2_glock_put(gl); |
@@ -750,10 +748,11 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
750 | const struct gfs2_glock_operations *glops, int create, | 748 | const struct gfs2_glock_operations *glops, int create, |
751 | struct gfs2_glock **glp) | 749 | struct gfs2_glock **glp) |
752 | { | 750 | { |
751 | struct super_block *s = sdp->sd_vfs; | ||
753 | struct lm_lockname name = { .ln_number = number, .ln_type = glops->go_type }; | 752 | struct lm_lockname name = { .ln_number = number, .ln_type = glops->go_type }; |
754 | struct gfs2_glock *gl, *tmp; | 753 | struct gfs2_glock *gl, *tmp; |
755 | unsigned int hash = gl_hash(sdp, &name); | 754 | unsigned int hash = gl_hash(sdp, &name); |
756 | int error; | 755 | struct address_space *mapping; |
757 | 756 | ||
758 | read_lock(gl_lock_addr(hash)); | 757 | read_lock(gl_lock_addr(hash)); |
759 | gl = search_bucket(hash, sdp, &name); | 758 | gl = search_bucket(hash, sdp, &name); |
@@ -765,7 +764,10 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
765 | if (!create) | 764 | if (!create) |
766 | return -ENOENT; | 765 | return -ENOENT; |
767 | 766 | ||
768 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); | 767 | if (glops->go_flags & GLOF_ASPACE) |
768 | gl = kmem_cache_alloc(gfs2_glock_aspace_cachep, GFP_KERNEL); | ||
769 | else | ||
770 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); | ||
769 | if (!gl) | 771 | if (!gl) |
770 | return -ENOMEM; | 772 | return -ENOMEM; |
771 | 773 | ||
@@ -784,18 +786,18 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
784 | gl->gl_tchange = jiffies; | 786 | gl->gl_tchange = jiffies; |
785 | gl->gl_object = NULL; | 787 | gl->gl_object = NULL; |
786 | gl->gl_sbd = sdp; | 788 | gl->gl_sbd = sdp; |
787 | gl->gl_aspace = NULL; | ||
788 | INIT_DELAYED_WORK(&gl->gl_work, glock_work_func); | 789 | INIT_DELAYED_WORK(&gl->gl_work, glock_work_func); |
789 | INIT_WORK(&gl->gl_delete, delete_work_func); | 790 | INIT_WORK(&gl->gl_delete, delete_work_func); |
790 | 791 | ||
791 | /* If this glock protects actual on-disk data or metadata blocks, | 792 | mapping = gfs2_glock2aspace(gl); |
792 | create a VFS inode to manage the pages/buffers holding them. */ | 793 | if (mapping) { |
793 | if (glops == &gfs2_inode_glops || glops == &gfs2_rgrp_glops) { | 794 | mapping->a_ops = &gfs2_meta_aops; |
794 | gl->gl_aspace = gfs2_aspace_get(sdp); | 795 | mapping->host = s->s_bdev->bd_inode; |
795 | if (!gl->gl_aspace) { | 796 | mapping->flags = 0; |
796 | error = -ENOMEM; | 797 | mapping_set_gfp_mask(mapping, GFP_NOFS); |
797 | goto fail; | 798 | mapping->assoc_mapping = NULL; |
798 | } | 799 | mapping->backing_dev_info = s->s_bdi; |
800 | mapping->writeback_index = 0; | ||
799 | } | 801 | } |
800 | 802 | ||
801 | write_lock(gl_lock_addr(hash)); | 803 | write_lock(gl_lock_addr(hash)); |
@@ -812,10 +814,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
812 | *glp = gl; | 814 | *glp = gl; |
813 | 815 | ||
814 | return 0; | 816 | return 0; |
815 | |||
816 | fail: | ||
817 | kmem_cache_free(gfs2_glock_cachep, gl); | ||
818 | return error; | ||
819 | } | 817 | } |
820 | 818 | ||
821 | /** | 819 | /** |
@@ -1510,35 +1508,10 @@ void gfs2_glock_thaw(struct gfs2_sbd *sdp) | |||
1510 | 1508 | ||
1511 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp) | 1509 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp) |
1512 | { | 1510 | { |
1513 | unsigned long t; | ||
1514 | unsigned int x; | 1511 | unsigned int x; |
1515 | int cont; | ||
1516 | 1512 | ||
1517 | t = jiffies; | 1513 | for (x = 0; x < GFS2_GL_HASH_SIZE; x++) |
1518 | 1514 | examine_bucket(clear_glock, sdp, x); | |
1519 | for (;;) { | ||
1520 | cont = 0; | ||
1521 | for (x = 0; x < GFS2_GL_HASH_SIZE; x++) { | ||
1522 | if (examine_bucket(clear_glock, sdp, x)) | ||
1523 | cont = 1; | ||
1524 | } | ||
1525 | |||
1526 | if (!cont) | ||
1527 | break; | ||
1528 | |||
1529 | if (time_after_eq(jiffies, | ||
1530 | t + gfs2_tune_get(sdp, gt_stall_secs) * HZ)) { | ||
1531 | fs_warn(sdp, "Unmount seems to be stalled. " | ||
1532 | "Dumping lock state...\n"); | ||
1533 | gfs2_dump_lockstate(sdp); | ||
1534 | t = jiffies; | ||
1535 | } | ||
1536 | |||
1537 | down_write(&gfs2_umount_flush_sem); | ||
1538 | invalidate_inodes(sdp->sd_vfs); | ||
1539 | up_write(&gfs2_umount_flush_sem); | ||
1540 | msleep(10); | ||
1541 | } | ||
1542 | flush_workqueue(glock_workqueue); | 1515 | flush_workqueue(glock_workqueue); |
1543 | wait_event(sdp->sd_glock_wait, atomic_read(&sdp->sd_glock_disposal) == 0); | 1516 | wait_event(sdp->sd_glock_wait, atomic_read(&sdp->sd_glock_disposal) == 0); |
1544 | gfs2_dump_lockstate(sdp); | 1517 | gfs2_dump_lockstate(sdp); |
@@ -1685,7 +1658,7 @@ static int __dump_glock(struct seq_file *seq, const struct gfs2_glock *gl) | |||
1685 | dtime *= 1000000/HZ; /* demote time in uSec */ | 1658 | dtime *= 1000000/HZ; /* demote time in uSec */ |
1686 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1659 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) |
1687 | dtime = 0; | 1660 | dtime = 0; |
1688 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llu f:%s t:%s d:%s/%llu a:%d r:%d\n", | 1661 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llx f:%s t:%s d:%s/%llu a:%d r:%d\n", |
1689 | state2str(gl->gl_state), | 1662 | state2str(gl->gl_state), |
1690 | gl->gl_name.ln_type, | 1663 | gl->gl_name.ln_type, |
1691 | (unsigned long long)gl->gl_name.ln_number, | 1664 | (unsigned long long)gl->gl_name.ln_number, |
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h index c0262faf4725..2bda1911b156 100644 --- a/fs/gfs2/glock.h +++ b/fs/gfs2/glock.h | |||
@@ -180,6 +180,13 @@ static inline int gfs2_glock_is_held_shrd(struct gfs2_glock *gl) | |||
180 | return gl->gl_state == LM_ST_SHARED; | 180 | return gl->gl_state == LM_ST_SHARED; |
181 | } | 181 | } |
182 | 182 | ||
183 | static inline struct address_space *gfs2_glock2aspace(struct gfs2_glock *gl) | ||
184 | { | ||
185 | if (gl->gl_ops->go_flags & GLOF_ASPACE) | ||
186 | return (struct address_space *)(gl + 1); | ||
187 | return NULL; | ||
188 | } | ||
189 | |||
183 | int gfs2_glock_get(struct gfs2_sbd *sdp, | 190 | int gfs2_glock_get(struct gfs2_sbd *sdp, |
184 | u64 number, const struct gfs2_glock_operations *glops, | 191 | u64 number, const struct gfs2_glock_operations *glops, |
185 | int create, struct gfs2_glock **glp); | 192 | int create, struct gfs2_glock **glp); |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 78554acc0605..38e3749d476c 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
@@ -87,7 +87,7 @@ static void gfs2_ail_empty_gl(struct gfs2_glock *gl) | |||
87 | 87 | ||
88 | static void rgrp_go_sync(struct gfs2_glock *gl) | 88 | static void rgrp_go_sync(struct gfs2_glock *gl) |
89 | { | 89 | { |
90 | struct address_space *metamapping = gl->gl_aspace->i_mapping; | 90 | struct address_space *metamapping = gfs2_glock2aspace(gl); |
91 | int error; | 91 | int error; |
92 | 92 | ||
93 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) | 93 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) |
@@ -113,7 +113,7 @@ static void rgrp_go_sync(struct gfs2_glock *gl) | |||
113 | 113 | ||
114 | static void rgrp_go_inval(struct gfs2_glock *gl, int flags) | 114 | static void rgrp_go_inval(struct gfs2_glock *gl, int flags) |
115 | { | 115 | { |
116 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 116 | struct address_space *mapping = gfs2_glock2aspace(gl); |
117 | 117 | ||
118 | BUG_ON(!(flags & DIO_METADATA)); | 118 | BUG_ON(!(flags & DIO_METADATA)); |
119 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); | 119 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
@@ -134,7 +134,7 @@ static void rgrp_go_inval(struct gfs2_glock *gl, int flags) | |||
134 | static void inode_go_sync(struct gfs2_glock *gl) | 134 | static void inode_go_sync(struct gfs2_glock *gl) |
135 | { | 135 | { |
136 | struct gfs2_inode *ip = gl->gl_object; | 136 | struct gfs2_inode *ip = gl->gl_object; |
137 | struct address_space *metamapping = gl->gl_aspace->i_mapping; | 137 | struct address_space *metamapping = gfs2_glock2aspace(gl); |
138 | int error; | 138 | int error; |
139 | 139 | ||
140 | if (ip && !S_ISREG(ip->i_inode.i_mode)) | 140 | if (ip && !S_ISREG(ip->i_inode.i_mode)) |
@@ -183,7 +183,7 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags) | |||
183 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); | 183 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
184 | 184 | ||
185 | if (flags & DIO_METADATA) { | 185 | if (flags & DIO_METADATA) { |
186 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 186 | struct address_space *mapping = gfs2_glock2aspace(gl); |
187 | truncate_inode_pages(mapping, 0); | 187 | truncate_inode_pages(mapping, 0); |
188 | if (ip) { | 188 | if (ip) { |
189 | set_bit(GIF_INVALID, &ip->i_flags); | 189 | set_bit(GIF_INVALID, &ip->i_flags); |
@@ -282,7 +282,8 @@ static int inode_go_dump(struct seq_file *seq, const struct gfs2_glock *gl) | |||
282 | 282 | ||
283 | static int rgrp_go_demote_ok(const struct gfs2_glock *gl) | 283 | static int rgrp_go_demote_ok(const struct gfs2_glock *gl) |
284 | { | 284 | { |
285 | return !gl->gl_aspace->i_mapping->nrpages; | 285 | const struct address_space *mapping = (const struct address_space *)(gl + 1); |
286 | return !mapping->nrpages; | ||
286 | } | 287 | } |
287 | 288 | ||
288 | /** | 289 | /** |
@@ -387,8 +388,7 @@ static void iopen_go_callback(struct gfs2_glock *gl) | |||
387 | struct gfs2_inode *ip = (struct gfs2_inode *)gl->gl_object; | 388 | struct gfs2_inode *ip = (struct gfs2_inode *)gl->gl_object; |
388 | 389 | ||
389 | if (gl->gl_demote_state == LM_ST_UNLOCKED && | 390 | if (gl->gl_demote_state == LM_ST_UNLOCKED && |
390 | gl->gl_state == LM_ST_SHARED && | 391 | gl->gl_state == LM_ST_SHARED && ip) { |
391 | ip && test_bit(GIF_USER, &ip->i_flags)) { | ||
392 | gfs2_glock_hold(gl); | 392 | gfs2_glock_hold(gl); |
393 | if (queue_work(gfs2_delete_workqueue, &gl->gl_delete) == 0) | 393 | if (queue_work(gfs2_delete_workqueue, &gl->gl_delete) == 0) |
394 | gfs2_glock_put_nolock(gl); | 394 | gfs2_glock_put_nolock(gl); |
@@ -407,6 +407,7 @@ const struct gfs2_glock_operations gfs2_inode_glops = { | |||
407 | .go_dump = inode_go_dump, | 407 | .go_dump = inode_go_dump, |
408 | .go_type = LM_TYPE_INODE, | 408 | .go_type = LM_TYPE_INODE, |
409 | .go_min_hold_time = HZ / 5, | 409 | .go_min_hold_time = HZ / 5, |
410 | .go_flags = GLOF_ASPACE, | ||
410 | }; | 411 | }; |
411 | 412 | ||
412 | const struct gfs2_glock_operations gfs2_rgrp_glops = { | 413 | const struct gfs2_glock_operations gfs2_rgrp_glops = { |
@@ -418,6 +419,7 @@ const struct gfs2_glock_operations gfs2_rgrp_glops = { | |||
418 | .go_dump = gfs2_rgrp_dump, | 419 | .go_dump = gfs2_rgrp_dump, |
419 | .go_type = LM_TYPE_RGRP, | 420 | .go_type = LM_TYPE_RGRP, |
420 | .go_min_hold_time = HZ / 5, | 421 | .go_min_hold_time = HZ / 5, |
422 | .go_flags = GLOF_ASPACE, | ||
421 | }; | 423 | }; |
422 | 424 | ||
423 | const struct gfs2_glock_operations gfs2_trans_glops = { | 425 | const struct gfs2_glock_operations gfs2_trans_glops = { |
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index bc0ad158e6b4..b8025e51cabf 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h | |||
@@ -162,6 +162,8 @@ struct gfs2_glock_operations { | |||
162 | void (*go_callback) (struct gfs2_glock *gl); | 162 | void (*go_callback) (struct gfs2_glock *gl); |
163 | const int go_type; | 163 | const int go_type; |
164 | const unsigned long go_min_hold_time; | 164 | const unsigned long go_min_hold_time; |
165 | const unsigned long go_flags; | ||
166 | #define GLOF_ASPACE 1 | ||
165 | }; | 167 | }; |
166 | 168 | ||
167 | enum { | 169 | enum { |
@@ -225,7 +227,6 @@ struct gfs2_glock { | |||
225 | 227 | ||
226 | struct gfs2_sbd *gl_sbd; | 228 | struct gfs2_sbd *gl_sbd; |
227 | 229 | ||
228 | struct inode *gl_aspace; | ||
229 | struct list_head gl_ail_list; | 230 | struct list_head gl_ail_list; |
230 | atomic_t gl_ail_count; | 231 | atomic_t gl_ail_count; |
231 | struct delayed_work gl_work; | 232 | struct delayed_work gl_work; |
@@ -258,7 +259,6 @@ enum { | |||
258 | GIF_INVALID = 0, | 259 | GIF_INVALID = 0, |
259 | GIF_QD_LOCKED = 1, | 260 | GIF_QD_LOCKED = 1, |
260 | GIF_SW_PAGED = 3, | 261 | GIF_SW_PAGED = 3, |
261 | GIF_USER = 4, /* user inode, not metadata addr space */ | ||
262 | }; | 262 | }; |
263 | 263 | ||
264 | 264 | ||
@@ -451,7 +451,6 @@ struct gfs2_tune { | |||
451 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ | 451 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ |
452 | unsigned int gt_new_files_jdata; | 452 | unsigned int gt_new_files_jdata; |
453 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ | 453 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ |
454 | unsigned int gt_stall_secs; /* Detects trouble! */ | ||
455 | unsigned int gt_complain_secs; | 454 | unsigned int gt_complain_secs; |
456 | unsigned int gt_statfs_quantum; | 455 | unsigned int gt_statfs_quantum; |
457 | unsigned int gt_statfs_slow; | 456 | unsigned int gt_statfs_slow; |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 6e220f4eee7d..b1bf2694fb2b 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -45,7 +45,7 @@ static int iget_test(struct inode *inode, void *opaque) | |||
45 | struct gfs2_inode *ip = GFS2_I(inode); | 45 | struct gfs2_inode *ip = GFS2_I(inode); |
46 | u64 *no_addr = opaque; | 46 | u64 *no_addr = opaque; |
47 | 47 | ||
48 | if (ip->i_no_addr == *no_addr && test_bit(GIF_USER, &ip->i_flags)) | 48 | if (ip->i_no_addr == *no_addr) |
49 | return 1; | 49 | return 1; |
50 | 50 | ||
51 | return 0; | 51 | return 0; |
@@ -58,7 +58,6 @@ static int iget_set(struct inode *inode, void *opaque) | |||
58 | 58 | ||
59 | inode->i_ino = (unsigned long)*no_addr; | 59 | inode->i_ino = (unsigned long)*no_addr; |
60 | ip->i_no_addr = *no_addr; | 60 | ip->i_no_addr = *no_addr; |
61 | set_bit(GIF_USER, &ip->i_flags); | ||
62 | return 0; | 61 | return 0; |
63 | } | 62 | } |
64 | 63 | ||
@@ -84,7 +83,7 @@ static int iget_skip_test(struct inode *inode, void *opaque) | |||
84 | struct gfs2_inode *ip = GFS2_I(inode); | 83 | struct gfs2_inode *ip = GFS2_I(inode); |
85 | struct gfs2_skip_data *data = opaque; | 84 | struct gfs2_skip_data *data = opaque; |
86 | 85 | ||
87 | if (ip->i_no_addr == data->no_addr && test_bit(GIF_USER, &ip->i_flags)){ | 86 | if (ip->i_no_addr == data->no_addr) { |
88 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE)){ | 87 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE)){ |
89 | data->skipped = 1; | 88 | data->skipped = 1; |
90 | return 0; | 89 | return 0; |
@@ -103,7 +102,6 @@ static int iget_skip_set(struct inode *inode, void *opaque) | |||
103 | return 1; | 102 | return 1; |
104 | inode->i_ino = (unsigned long)(data->no_addr); | 103 | inode->i_ino = (unsigned long)(data->no_addr); |
105 | ip->i_no_addr = data->no_addr; | 104 | ip->i_no_addr = data->no_addr; |
106 | set_bit(GIF_USER, &ip->i_flags); | ||
107 | return 0; | 105 | return 0; |
108 | } | 106 | } |
109 | 107 | ||
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c index 0e5e0e7022e5..569b46240f61 100644 --- a/fs/gfs2/lock_dlm.c +++ b/fs/gfs2/lock_dlm.c | |||
@@ -30,7 +30,10 @@ static void gdlm_ast(void *arg) | |||
30 | 30 | ||
31 | switch (gl->gl_lksb.sb_status) { | 31 | switch (gl->gl_lksb.sb_status) { |
32 | case -DLM_EUNLOCK: /* Unlocked, so glock can be freed */ | 32 | case -DLM_EUNLOCK: /* Unlocked, so glock can be freed */ |
33 | kmem_cache_free(gfs2_glock_cachep, gl); | 33 | if (gl->gl_ops->go_flags & GLOF_ASPACE) |
34 | kmem_cache_free(gfs2_glock_aspace_cachep, gl); | ||
35 | else | ||
36 | kmem_cache_free(gfs2_glock_cachep, gl); | ||
34 | if (atomic_dec_and_test(&sdp->sd_glock_disposal)) | 37 | if (atomic_dec_and_test(&sdp->sd_glock_disposal)) |
35 | wake_up(&sdp->sd_glock_wait); | 38 | wake_up(&sdp->sd_glock_wait); |
36 | return; | 39 | return; |
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index de97632ba32f..adc260fbea90 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c | |||
@@ -528,9 +528,9 @@ static void databuf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le) | |||
528 | gfs2_pin(sdp, bd->bd_bh); | 528 | gfs2_pin(sdp, bd->bd_bh); |
529 | tr->tr_num_databuf_new++; | 529 | tr->tr_num_databuf_new++; |
530 | sdp->sd_log_num_databuf++; | 530 | sdp->sd_log_num_databuf++; |
531 | list_add(&le->le_list, &sdp->sd_log_le_databuf); | 531 | list_add_tail(&le->le_list, &sdp->sd_log_le_databuf); |
532 | } else { | 532 | } else { |
533 | list_add(&le->le_list, &sdp->sd_log_le_ordered); | 533 | list_add_tail(&le->le_list, &sdp->sd_log_le_ordered); |
534 | } | 534 | } |
535 | out: | 535 | out: |
536 | gfs2_log_unlock(sdp); | 536 | gfs2_log_unlock(sdp); |
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index 5b31f7741a8f..a88fadc704bb 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c | |||
@@ -52,6 +52,22 @@ static void gfs2_init_glock_once(void *foo) | |||
52 | atomic_set(&gl->gl_ail_count, 0); | 52 | atomic_set(&gl->gl_ail_count, 0); |
53 | } | 53 | } |
54 | 54 | ||
55 | static void gfs2_init_gl_aspace_once(void *foo) | ||
56 | { | ||
57 | struct gfs2_glock *gl = foo; | ||
58 | struct address_space *mapping = (struct address_space *)(gl + 1); | ||
59 | |||
60 | gfs2_init_glock_once(gl); | ||
61 | memset(mapping, 0, sizeof(*mapping)); | ||
62 | INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC); | ||
63 | spin_lock_init(&mapping->tree_lock); | ||
64 | spin_lock_init(&mapping->i_mmap_lock); | ||
65 | INIT_LIST_HEAD(&mapping->private_list); | ||
66 | spin_lock_init(&mapping->private_lock); | ||
67 | INIT_RAW_PRIO_TREE_ROOT(&mapping->i_mmap); | ||
68 | INIT_LIST_HEAD(&mapping->i_mmap_nonlinear); | ||
69 | } | ||
70 | |||
55 | /** | 71 | /** |
56 | * init_gfs2_fs - Register GFS2 as a filesystem | 72 | * init_gfs2_fs - Register GFS2 as a filesystem |
57 | * | 73 | * |
@@ -78,6 +94,14 @@ static int __init init_gfs2_fs(void) | |||
78 | if (!gfs2_glock_cachep) | 94 | if (!gfs2_glock_cachep) |
79 | goto fail; | 95 | goto fail; |
80 | 96 | ||
97 | gfs2_glock_aspace_cachep = kmem_cache_create("gfs2_glock (aspace)", | ||
98 | sizeof(struct gfs2_glock) + | ||
99 | sizeof(struct address_space), | ||
100 | 0, 0, gfs2_init_gl_aspace_once); | ||
101 | |||
102 | if (!gfs2_glock_aspace_cachep) | ||
103 | goto fail; | ||
104 | |||
81 | gfs2_inode_cachep = kmem_cache_create("gfs2_inode", | 105 | gfs2_inode_cachep = kmem_cache_create("gfs2_inode", |
82 | sizeof(struct gfs2_inode), | 106 | sizeof(struct gfs2_inode), |
83 | 0, SLAB_RECLAIM_ACCOUNT| | 107 | 0, SLAB_RECLAIM_ACCOUNT| |
@@ -144,6 +168,9 @@ fail: | |||
144 | if (gfs2_inode_cachep) | 168 | if (gfs2_inode_cachep) |
145 | kmem_cache_destroy(gfs2_inode_cachep); | 169 | kmem_cache_destroy(gfs2_inode_cachep); |
146 | 170 | ||
171 | if (gfs2_glock_aspace_cachep) | ||
172 | kmem_cache_destroy(gfs2_glock_aspace_cachep); | ||
173 | |||
147 | if (gfs2_glock_cachep) | 174 | if (gfs2_glock_cachep) |
148 | kmem_cache_destroy(gfs2_glock_cachep); | 175 | kmem_cache_destroy(gfs2_glock_cachep); |
149 | 176 | ||
@@ -169,6 +196,7 @@ static void __exit exit_gfs2_fs(void) | |||
169 | kmem_cache_destroy(gfs2_rgrpd_cachep); | 196 | kmem_cache_destroy(gfs2_rgrpd_cachep); |
170 | kmem_cache_destroy(gfs2_bufdata_cachep); | 197 | kmem_cache_destroy(gfs2_bufdata_cachep); |
171 | kmem_cache_destroy(gfs2_inode_cachep); | 198 | kmem_cache_destroy(gfs2_inode_cachep); |
199 | kmem_cache_destroy(gfs2_glock_aspace_cachep); | ||
172 | kmem_cache_destroy(gfs2_glock_cachep); | 200 | kmem_cache_destroy(gfs2_glock_cachep); |
173 | 201 | ||
174 | gfs2_sys_uninit(); | 202 | gfs2_sys_uninit(); |
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 6f68a5f18eb8..0bb12c80937a 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c | |||
@@ -93,49 +93,13 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb | |||
93 | return err; | 93 | return err; |
94 | } | 94 | } |
95 | 95 | ||
96 | static const struct address_space_operations aspace_aops = { | 96 | const struct address_space_operations gfs2_meta_aops = { |
97 | .writepage = gfs2_aspace_writepage, | 97 | .writepage = gfs2_aspace_writepage, |
98 | .releasepage = gfs2_releasepage, | 98 | .releasepage = gfs2_releasepage, |
99 | .sync_page = block_sync_page, | 99 | .sync_page = block_sync_page, |
100 | }; | 100 | }; |
101 | 101 | ||
102 | /** | 102 | /** |
103 | * gfs2_aspace_get - Create and initialize a struct inode structure | ||
104 | * @sdp: the filesystem the aspace is in | ||
105 | * | ||
106 | * Right now a struct inode is just a struct inode. Maybe Linux | ||
107 | * will supply a more lightweight address space construct (that works) | ||
108 | * in the future. | ||
109 | * | ||
110 | * Make sure pages/buffers in this aspace aren't in high memory. | ||
111 | * | ||
112 | * Returns: the aspace | ||
113 | */ | ||
114 | |||
115 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp) | ||
116 | { | ||
117 | struct inode *aspace; | ||
118 | struct gfs2_inode *ip; | ||
119 | |||
120 | aspace = new_inode(sdp->sd_vfs); | ||
121 | if (aspace) { | ||
122 | mapping_set_gfp_mask(aspace->i_mapping, GFP_NOFS); | ||
123 | aspace->i_mapping->a_ops = &aspace_aops; | ||
124 | aspace->i_size = MAX_LFS_FILESIZE; | ||
125 | ip = GFS2_I(aspace); | ||
126 | clear_bit(GIF_USER, &ip->i_flags); | ||
127 | insert_inode_hash(aspace); | ||
128 | } | ||
129 | return aspace; | ||
130 | } | ||
131 | |||
132 | void gfs2_aspace_put(struct inode *aspace) | ||
133 | { | ||
134 | remove_inode_hash(aspace); | ||
135 | iput(aspace); | ||
136 | } | ||
137 | |||
138 | /** | ||
139 | * gfs2_meta_sync - Sync all buffers associated with a glock | 103 | * gfs2_meta_sync - Sync all buffers associated with a glock |
140 | * @gl: The glock | 104 | * @gl: The glock |
141 | * | 105 | * |
@@ -143,7 +107,7 @@ void gfs2_aspace_put(struct inode *aspace) | |||
143 | 107 | ||
144 | void gfs2_meta_sync(struct gfs2_glock *gl) | 108 | void gfs2_meta_sync(struct gfs2_glock *gl) |
145 | { | 109 | { |
146 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 110 | struct address_space *mapping = gfs2_glock2aspace(gl); |
147 | int error; | 111 | int error; |
148 | 112 | ||
149 | filemap_fdatawrite(mapping); | 113 | filemap_fdatawrite(mapping); |
@@ -164,7 +128,7 @@ void gfs2_meta_sync(struct gfs2_glock *gl) | |||
164 | 128 | ||
165 | struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, u64 blkno, int create) | 129 | struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, u64 blkno, int create) |
166 | { | 130 | { |
167 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 131 | struct address_space *mapping = gfs2_glock2aspace(gl); |
168 | struct gfs2_sbd *sdp = gl->gl_sbd; | 132 | struct gfs2_sbd *sdp = gl->gl_sbd; |
169 | struct page *page; | 133 | struct page *page; |
170 | struct buffer_head *bh; | 134 | struct buffer_head *bh; |
@@ -344,8 +308,10 @@ void gfs2_attach_bufdata(struct gfs2_glock *gl, struct buffer_head *bh, | |||
344 | 308 | ||
345 | void gfs2_remove_from_journal(struct buffer_head *bh, struct gfs2_trans *tr, int meta) | 309 | void gfs2_remove_from_journal(struct buffer_head *bh, struct gfs2_trans *tr, int meta) |
346 | { | 310 | { |
347 | struct gfs2_sbd *sdp = GFS2_SB(bh->b_page->mapping->host); | 311 | struct address_space *mapping = bh->b_page->mapping; |
312 | struct gfs2_sbd *sdp = gfs2_mapping2sbd(mapping); | ||
348 | struct gfs2_bufdata *bd = bh->b_private; | 313 | struct gfs2_bufdata *bd = bh->b_private; |
314 | |||
349 | if (test_clear_buffer_pinned(bh)) { | 315 | if (test_clear_buffer_pinned(bh)) { |
350 | list_del_init(&bd->bd_le.le_list); | 316 | list_del_init(&bd->bd_le.le_list); |
351 | if (meta) { | 317 | if (meta) { |
diff --git a/fs/gfs2/meta_io.h b/fs/gfs2/meta_io.h index de270c2f9b63..6a1d9ba16411 100644 --- a/fs/gfs2/meta_io.h +++ b/fs/gfs2/meta_io.h | |||
@@ -37,8 +37,16 @@ static inline void gfs2_buffer_copy_tail(struct buffer_head *to_bh, | |||
37 | 0, from_head - to_head); | 37 | 0, from_head - to_head); |
38 | } | 38 | } |
39 | 39 | ||
40 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp); | 40 | extern const struct address_space_operations gfs2_meta_aops; |
41 | void gfs2_aspace_put(struct inode *aspace); | 41 | |
42 | static inline struct gfs2_sbd *gfs2_mapping2sbd(struct address_space *mapping) | ||
43 | { | ||
44 | struct inode *inode = mapping->host; | ||
45 | if (mapping->a_ops == &gfs2_meta_aops) | ||
46 | return (((struct gfs2_glock *)mapping) - 1)->gl_sbd; | ||
47 | else | ||
48 | return inode->i_sb->s_fs_info; | ||
49 | } | ||
42 | 50 | ||
43 | void gfs2_meta_sync(struct gfs2_glock *gl); | 51 | void gfs2_meta_sync(struct gfs2_glock *gl); |
44 | 52 | ||
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index a86ed6381566..a054b526dc08 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c | |||
@@ -65,7 +65,6 @@ static void gfs2_tune_init(struct gfs2_tune *gt) | |||
65 | gt->gt_quota_scale_den = 1; | 65 | gt->gt_quota_scale_den = 1; |
66 | gt->gt_new_files_jdata = 0; | 66 | gt->gt_new_files_jdata = 0; |
67 | gt->gt_max_readahead = 1 << 18; | 67 | gt->gt_max_readahead = 1 << 18; |
68 | gt->gt_stall_secs = 600; | ||
69 | gt->gt_complain_secs = 10; | 68 | gt->gt_complain_secs = 10; |
70 | } | 69 | } |
71 | 70 | ||
@@ -1241,10 +1240,9 @@ fail_sb: | |||
1241 | fail_locking: | 1240 | fail_locking: |
1242 | init_locking(sdp, &mount_gh, UNDO); | 1241 | init_locking(sdp, &mount_gh, UNDO); |
1243 | fail_lm: | 1242 | fail_lm: |
1243 | invalidate_inodes(sb); | ||
1244 | gfs2_gl_hash_clear(sdp); | 1244 | gfs2_gl_hash_clear(sdp); |
1245 | gfs2_lm_unmount(sdp); | 1245 | gfs2_lm_unmount(sdp); |
1246 | while (invalidate_inodes(sb)) | ||
1247 | yield(); | ||
1248 | fail_sys: | 1246 | fail_sys: |
1249 | gfs2_sys_fs_del(sdp); | 1247 | gfs2_sys_fs_del(sdp); |
1250 | fail: | 1248 | fail: |
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 84350e1be66d..4e64352d49de 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
@@ -976,122 +976,62 @@ out: | |||
976 | } | 976 | } |
977 | 977 | ||
978 | /** | 978 | /** |
979 | * gfs2_readlinki - return the contents of a symlink | 979 | * gfs2_follow_link - Follow a symbolic link |
980 | * @ip: the symlink's inode | 980 | * @dentry: The dentry of the link |
981 | * @buf: a pointer to the buffer to be filled | 981 | * @nd: Data that we pass to vfs_follow_link() |
982 | * @len: a pointer to the length of @buf | ||
983 | * | 982 | * |
984 | * If @buf is too small, a piece of memory is kmalloc()ed and needs | 983 | * This can handle symlinks of any size. |
985 | * to be freed by the caller. | ||
986 | * | 984 | * |
987 | * Returns: errno | 985 | * Returns: 0 on success or error code |
988 | */ | 986 | */ |
989 | 987 | ||
990 | static int gfs2_readlinki(struct gfs2_inode *ip, char **buf, unsigned int *len) | 988 | static void *gfs2_follow_link(struct dentry *dentry, struct nameidata *nd) |
991 | { | 989 | { |
990 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | ||
992 | struct gfs2_holder i_gh; | 991 | struct gfs2_holder i_gh; |
993 | struct buffer_head *dibh; | 992 | struct buffer_head *dibh; |
994 | unsigned int x; | 993 | unsigned int x; |
994 | char *buf; | ||
995 | int error; | 995 | int error; |
996 | 996 | ||
997 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, 0, &i_gh); | 997 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, 0, &i_gh); |
998 | error = gfs2_glock_nq(&i_gh); | 998 | error = gfs2_glock_nq(&i_gh); |
999 | if (error) { | 999 | if (error) { |
1000 | gfs2_holder_uninit(&i_gh); | 1000 | gfs2_holder_uninit(&i_gh); |
1001 | return error; | 1001 | nd_set_link(nd, ERR_PTR(error)); |
1002 | return NULL; | ||
1002 | } | 1003 | } |
1003 | 1004 | ||
1004 | if (!ip->i_disksize) { | 1005 | if (!ip->i_disksize) { |
1005 | gfs2_consist_inode(ip); | 1006 | gfs2_consist_inode(ip); |
1006 | error = -EIO; | 1007 | buf = ERR_PTR(-EIO); |
1007 | goto out; | 1008 | goto out; |
1008 | } | 1009 | } |
1009 | 1010 | ||
1010 | error = gfs2_meta_inode_buffer(ip, &dibh); | 1011 | error = gfs2_meta_inode_buffer(ip, &dibh); |
1011 | if (error) | 1012 | if (error) { |
1013 | buf = ERR_PTR(error); | ||
1012 | goto out; | 1014 | goto out; |
1013 | |||
1014 | x = ip->i_disksize + 1; | ||
1015 | if (x > *len) { | ||
1016 | *buf = kmalloc(x, GFP_NOFS); | ||
1017 | if (!*buf) { | ||
1018 | error = -ENOMEM; | ||
1019 | goto out_brelse; | ||
1020 | } | ||
1021 | } | 1015 | } |
1022 | 1016 | ||
1023 | memcpy(*buf, dibh->b_data + sizeof(struct gfs2_dinode), x); | 1017 | x = ip->i_disksize + 1; |
1024 | *len = x; | 1018 | buf = kmalloc(x, GFP_NOFS); |
1025 | 1019 | if (!buf) | |
1026 | out_brelse: | 1020 | buf = ERR_PTR(-ENOMEM); |
1021 | else | ||
1022 | memcpy(buf, dibh->b_data + sizeof(struct gfs2_dinode), x); | ||
1027 | brelse(dibh); | 1023 | brelse(dibh); |
1028 | out: | 1024 | out: |
1029 | gfs2_glock_dq_uninit(&i_gh); | 1025 | gfs2_glock_dq_uninit(&i_gh); |
1030 | return error; | 1026 | nd_set_link(nd, buf); |
1031 | } | 1027 | return NULL; |
1032 | |||
1033 | /** | ||
1034 | * gfs2_readlink - Read the value of a symlink | ||
1035 | * @dentry: the symlink | ||
1036 | * @buf: the buffer to read the symlink data into | ||
1037 | * @size: the size of the buffer | ||
1038 | * | ||
1039 | * Returns: errno | ||
1040 | */ | ||
1041 | |||
1042 | static int gfs2_readlink(struct dentry *dentry, char __user *user_buf, | ||
1043 | int user_size) | ||
1044 | { | ||
1045 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | ||
1046 | char array[GFS2_FAST_NAME_SIZE], *buf = array; | ||
1047 | unsigned int len = GFS2_FAST_NAME_SIZE; | ||
1048 | int error; | ||
1049 | |||
1050 | error = gfs2_readlinki(ip, &buf, &len); | ||
1051 | if (error) | ||
1052 | return error; | ||
1053 | |||
1054 | if (user_size > len - 1) | ||
1055 | user_size = len - 1; | ||
1056 | |||
1057 | if (copy_to_user(user_buf, buf, user_size)) | ||
1058 | error = -EFAULT; | ||
1059 | else | ||
1060 | error = user_size; | ||
1061 | |||
1062 | if (buf != array) | ||
1063 | kfree(buf); | ||
1064 | |||
1065 | return error; | ||
1066 | } | 1028 | } |
1067 | 1029 | ||
1068 | /** | 1030 | static void gfs2_put_link(struct dentry *dentry, struct nameidata *nd, void *p) |
1069 | * gfs2_follow_link - Follow a symbolic link | ||
1070 | * @dentry: The dentry of the link | ||
1071 | * @nd: Data that we pass to vfs_follow_link() | ||
1072 | * | ||
1073 | * This can handle symlinks of any size. It is optimised for symlinks | ||
1074 | * under GFS2_FAST_NAME_SIZE. | ||
1075 | * | ||
1076 | * Returns: 0 on success or error code | ||
1077 | */ | ||
1078 | |||
1079 | static void *gfs2_follow_link(struct dentry *dentry, struct nameidata *nd) | ||
1080 | { | 1031 | { |
1081 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | 1032 | char *s = nd_get_link(nd); |
1082 | char array[GFS2_FAST_NAME_SIZE], *buf = array; | 1033 | if (!IS_ERR(s)) |
1083 | unsigned int len = GFS2_FAST_NAME_SIZE; | 1034 | kfree(s); |
1084 | int error; | ||
1085 | |||
1086 | error = gfs2_readlinki(ip, &buf, &len); | ||
1087 | if (!error) { | ||
1088 | error = vfs_follow_link(nd, buf); | ||
1089 | if (buf != array) | ||
1090 | kfree(buf); | ||
1091 | } else | ||
1092 | path_put(&nd->path); | ||
1093 | |||
1094 | return ERR_PTR(error); | ||
1095 | } | 1035 | } |
1096 | 1036 | ||
1097 | /** | 1037 | /** |
@@ -1426,8 +1366,9 @@ const struct inode_operations gfs2_dir_iops = { | |||
1426 | }; | 1366 | }; |
1427 | 1367 | ||
1428 | const struct inode_operations gfs2_symlink_iops = { | 1368 | const struct inode_operations gfs2_symlink_iops = { |
1429 | .readlink = gfs2_readlink, | 1369 | .readlink = generic_readlink, |
1430 | .follow_link = gfs2_follow_link, | 1370 | .follow_link = gfs2_follow_link, |
1371 | .put_link = gfs2_put_link, | ||
1431 | .permission = gfs2_permission, | 1372 | .permission = gfs2_permission, |
1432 | .setattr = gfs2_setattr, | 1373 | .setattr = gfs2_setattr, |
1433 | .getattr = gfs2_getattr, | 1374 | .getattr = gfs2_getattr, |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index a8c2bcd0fcc8..50aac606b990 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/crc32.h> | 22 | #include <linux/crc32.h> |
23 | #include <linux/time.h> | 23 | #include <linux/time.h> |
24 | #include <linux/wait.h> | 24 | #include <linux/wait.h> |
25 | #include <linux/writeback.h> | ||
25 | 26 | ||
26 | #include "gfs2.h" | 27 | #include "gfs2.h" |
27 | #include "incore.h" | 28 | #include "incore.h" |
@@ -711,7 +712,7 @@ void gfs2_unfreeze_fs(struct gfs2_sbd *sdp) | |||
711 | * Returns: errno | 712 | * Returns: errno |
712 | */ | 713 | */ |
713 | 714 | ||
714 | static int gfs2_write_inode(struct inode *inode, int sync) | 715 | static int gfs2_write_inode(struct inode *inode, struct writeback_control *wbc) |
715 | { | 716 | { |
716 | struct gfs2_inode *ip = GFS2_I(inode); | 717 | struct gfs2_inode *ip = GFS2_I(inode); |
717 | struct gfs2_sbd *sdp = GFS2_SB(inode); | 718 | struct gfs2_sbd *sdp = GFS2_SB(inode); |
@@ -722,8 +723,7 @@ static int gfs2_write_inode(struct inode *inode, int sync) | |||
722 | int ret = 0; | 723 | int ret = 0; |
723 | 724 | ||
724 | /* Check this is a "normal" inode, etc */ | 725 | /* Check this is a "normal" inode, etc */ |
725 | if (!test_bit(GIF_USER, &ip->i_flags) || | 726 | if (current->flags & PF_MEMALLOC) |
726 | (current->flags & PF_MEMALLOC)) | ||
727 | return 0; | 727 | return 0; |
728 | ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); | 728 | ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); |
729 | if (ret) | 729 | if (ret) |
@@ -746,7 +746,7 @@ static int gfs2_write_inode(struct inode *inode, int sync) | |||
746 | do_unlock: | 746 | do_unlock: |
747 | gfs2_glock_dq_uninit(&gh); | 747 | gfs2_glock_dq_uninit(&gh); |
748 | do_flush: | 748 | do_flush: |
749 | if (sync != 0) | 749 | if (wbc->sync_mode == WB_SYNC_ALL) |
750 | gfs2_log_flush(GFS2_SB(inode), ip->i_gl); | 750 | gfs2_log_flush(GFS2_SB(inode), ip->i_gl); |
751 | return ret; | 751 | return ret; |
752 | } | 752 | } |
@@ -860,6 +860,7 @@ restart: | |||
860 | gfs2_clear_rgrpd(sdp); | 860 | gfs2_clear_rgrpd(sdp); |
861 | gfs2_jindex_free(sdp); | 861 | gfs2_jindex_free(sdp); |
862 | /* Take apart glock structures and buffer lists */ | 862 | /* Take apart glock structures and buffer lists */ |
863 | invalidate_inodes(sdp->sd_vfs); | ||
863 | gfs2_gl_hash_clear(sdp); | 864 | gfs2_gl_hash_clear(sdp); |
864 | /* Unmount the locking protocol */ | 865 | /* Unmount the locking protocol */ |
865 | gfs2_lm_unmount(sdp); | 866 | gfs2_lm_unmount(sdp); |
@@ -1194,7 +1195,7 @@ static void gfs2_drop_inode(struct inode *inode) | |||
1194 | { | 1195 | { |
1195 | struct gfs2_inode *ip = GFS2_I(inode); | 1196 | struct gfs2_inode *ip = GFS2_I(inode); |
1196 | 1197 | ||
1197 | if (test_bit(GIF_USER, &ip->i_flags) && inode->i_nlink) { | 1198 | if (inode->i_nlink) { |
1198 | struct gfs2_glock *gl = ip->i_iopen_gh.gh_gl; | 1199 | struct gfs2_glock *gl = ip->i_iopen_gh.gh_gl; |
1199 | if (gl && test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1200 | if (gl && test_bit(GLF_DEMOTE, &gl->gl_flags)) |
1200 | clear_nlink(inode); | 1201 | clear_nlink(inode); |
@@ -1212,18 +1213,12 @@ static void gfs2_clear_inode(struct inode *inode) | |||
1212 | { | 1213 | { |
1213 | struct gfs2_inode *ip = GFS2_I(inode); | 1214 | struct gfs2_inode *ip = GFS2_I(inode); |
1214 | 1215 | ||
1215 | /* This tells us its a "real" inode and not one which only | 1216 | ip->i_gl->gl_object = NULL; |
1216 | * serves to contain an address space (see rgrp.c, meta_io.c) | 1217 | gfs2_glock_put(ip->i_gl); |
1217 | * which therefore doesn't have its own glocks. | 1218 | ip->i_gl = NULL; |
1218 | */ | 1219 | if (ip->i_iopen_gh.gh_gl) { |
1219 | if (test_bit(GIF_USER, &ip->i_flags)) { | 1220 | ip->i_iopen_gh.gh_gl->gl_object = NULL; |
1220 | ip->i_gl->gl_object = NULL; | 1221 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); |
1221 | gfs2_glock_put(ip->i_gl); | ||
1222 | ip->i_gl = NULL; | ||
1223 | if (ip->i_iopen_gh.gh_gl) { | ||
1224 | ip->i_iopen_gh.gh_gl->gl_object = NULL; | ||
1225 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); | ||
1226 | } | ||
1227 | } | 1222 | } |
1228 | } | 1223 | } |
1229 | 1224 | ||
@@ -1358,9 +1353,6 @@ static void gfs2_delete_inode(struct inode *inode) | |||
1358 | struct gfs2_holder gh; | 1353 | struct gfs2_holder gh; |
1359 | int error; | 1354 | int error; |
1360 | 1355 | ||
1361 | if (!test_bit(GIF_USER, &ip->i_flags)) | ||
1362 | goto out; | ||
1363 | |||
1364 | error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); | 1356 | error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); |
1365 | if (unlikely(error)) { | 1357 | if (unlikely(error)) { |
1366 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); | 1358 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); |
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 4496cc37a0fa..b5f1a46133c8 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c | |||
@@ -478,7 +478,6 @@ TUNE_ATTR(complain_secs, 0); | |||
478 | TUNE_ATTR(statfs_slow, 0); | 478 | TUNE_ATTR(statfs_slow, 0); |
479 | TUNE_ATTR(new_files_jdata, 0); | 479 | TUNE_ATTR(new_files_jdata, 0); |
480 | TUNE_ATTR(quota_simul_sync, 1); | 480 | TUNE_ATTR(quota_simul_sync, 1); |
481 | TUNE_ATTR(stall_secs, 1); | ||
482 | TUNE_ATTR(statfs_quantum, 1); | 481 | TUNE_ATTR(statfs_quantum, 1); |
483 | TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store); | 482 | TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store); |
484 | 483 | ||
@@ -491,7 +490,6 @@ static struct attribute *tune_attrs[] = { | |||
491 | &tune_attr_complain_secs.attr, | 490 | &tune_attr_complain_secs.attr, |
492 | &tune_attr_statfs_slow.attr, | 491 | &tune_attr_statfs_slow.attr, |
493 | &tune_attr_quota_simul_sync.attr, | 492 | &tune_attr_quota_simul_sync.attr, |
494 | &tune_attr_stall_secs.attr, | ||
495 | &tune_attr_statfs_quantum.attr, | 493 | &tune_attr_statfs_quantum.attr, |
496 | &tune_attr_quota_scale.attr, | 494 | &tune_attr_quota_scale.attr, |
497 | &tune_attr_new_files_jdata.attr, | 495 | &tune_attr_new_files_jdata.attr, |
diff --git a/fs/gfs2/util.c b/fs/gfs2/util.c index f6a7efa34eb9..226f2bfbf16a 100644 --- a/fs/gfs2/util.c +++ b/fs/gfs2/util.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include "util.h" | 21 | #include "util.h" |
22 | 22 | ||
23 | struct kmem_cache *gfs2_glock_cachep __read_mostly; | 23 | struct kmem_cache *gfs2_glock_cachep __read_mostly; |
24 | struct kmem_cache *gfs2_glock_aspace_cachep __read_mostly; | ||
24 | struct kmem_cache *gfs2_inode_cachep __read_mostly; | 25 | struct kmem_cache *gfs2_inode_cachep __read_mostly; |
25 | struct kmem_cache *gfs2_bufdata_cachep __read_mostly; | 26 | struct kmem_cache *gfs2_bufdata_cachep __read_mostly; |
26 | struct kmem_cache *gfs2_rgrpd_cachep __read_mostly; | 27 | struct kmem_cache *gfs2_rgrpd_cachep __read_mostly; |
diff --git a/fs/gfs2/util.h b/fs/gfs2/util.h index 33e96b0ce9ab..b432e04600de 100644 --- a/fs/gfs2/util.h +++ b/fs/gfs2/util.h | |||
@@ -145,6 +145,7 @@ gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__); | |||
145 | 145 | ||
146 | 146 | ||
147 | extern struct kmem_cache *gfs2_glock_cachep; | 147 | extern struct kmem_cache *gfs2_glock_cachep; |
148 | extern struct kmem_cache *gfs2_glock_aspace_cachep; | ||
148 | extern struct kmem_cache *gfs2_inode_cachep; | 149 | extern struct kmem_cache *gfs2_inode_cachep; |
149 | extern struct kmem_cache *gfs2_bufdata_cachep; | 150 | extern struct kmem_cache *gfs2_bufdata_cachep; |
150 | extern struct kmem_cache *gfs2_rgrpd_cachep; | 151 | extern struct kmem_cache *gfs2_rgrpd_cachep; |
diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 052387e11671..fe35e3b626c4 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h | |||
@@ -188,7 +188,7 @@ extern const struct address_space_operations hfs_btree_aops; | |||
188 | 188 | ||
189 | extern struct inode *hfs_new_inode(struct inode *, struct qstr *, int); | 189 | extern struct inode *hfs_new_inode(struct inode *, struct qstr *, int); |
190 | extern void hfs_inode_write_fork(struct inode *, struct hfs_extent *, __be32 *, __be32 *); | 190 | extern void hfs_inode_write_fork(struct inode *, struct hfs_extent *, __be32 *, __be32 *); |
191 | extern int hfs_write_inode(struct inode *, int); | 191 | extern int hfs_write_inode(struct inode *, struct writeback_control *); |
192 | extern int hfs_inode_setattr(struct dentry *, struct iattr *); | 192 | extern int hfs_inode_setattr(struct dentry *, struct iattr *); |
193 | extern void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, | 193 | extern void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, |
194 | __be32 log_size, __be32 phys_size, u32 clump_size); | 194 | __be32 log_size, __be32 phys_size, u32 clump_size); |
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index a1cbff2b4d99..14f5cb1b9fdc 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c | |||
@@ -381,7 +381,7 @@ void hfs_inode_write_fork(struct inode *inode, struct hfs_extent *ext, | |||
381 | HFS_SB(inode->i_sb)->alloc_blksz); | 381 | HFS_SB(inode->i_sb)->alloc_blksz); |
382 | } | 382 | } |
383 | 383 | ||
384 | int hfs_write_inode(struct inode *inode, int unused) | 384 | int hfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
385 | { | 385 | { |
386 | struct inode *main_inode = inode; | 386 | struct inode *main_inode = inode; |
387 | struct hfs_find_data fd; | 387 | struct hfs_find_data fd; |
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 43022f3d5148..74b473a8ef92 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c | |||
@@ -87,7 +87,8 @@ bad_inode: | |||
87 | return ERR_PTR(err); | 87 | return ERR_PTR(err); |
88 | } | 88 | } |
89 | 89 | ||
90 | static int hfsplus_write_inode(struct inode *inode, int unused) | 90 | static int hfsplus_write_inode(struct inode *inode, |
91 | struct writeback_control *wbc) | ||
91 | { | 92 | { |
92 | struct hfsplus_vh *vhdr; | 93 | struct hfsplus_vh *vhdr; |
93 | int ret = 0; | 94 | int ret = 0; |
diff --git a/fs/hpfs/anode.c b/fs/hpfs/anode.c index 1aa88c4e0964..6a2f04bf3df0 100644 --- a/fs/hpfs/anode.c +++ b/fs/hpfs/anode.c | |||
@@ -353,7 +353,7 @@ int hpfs_ea_read(struct super_block *s, secno a, int ano, unsigned pos, | |||
353 | } | 353 | } |
354 | 354 | ||
355 | int hpfs_ea_write(struct super_block *s, secno a, int ano, unsigned pos, | 355 | int hpfs_ea_write(struct super_block *s, secno a, int ano, unsigned pos, |
356 | unsigned len, char *buf) | 356 | unsigned len, const char *buf) |
357 | { | 357 | { |
358 | struct buffer_head *bh; | 358 | struct buffer_head *bh; |
359 | char *data; | 359 | char *data; |
diff --git a/fs/hpfs/dentry.c b/fs/hpfs/dentry.c index 940d6d150bee..67d9d36b3d5f 100644 --- a/fs/hpfs/dentry.c +++ b/fs/hpfs/dentry.c | |||
@@ -20,8 +20,8 @@ static int hpfs_hash_dentry(struct dentry *dentry, struct qstr *qstr) | |||
20 | 20 | ||
21 | if (l == 1) if (qstr->name[0]=='.') goto x; | 21 | if (l == 1) if (qstr->name[0]=='.') goto x; |
22 | if (l == 2) if (qstr->name[0]=='.' || qstr->name[1]=='.') goto x; | 22 | if (l == 2) if (qstr->name[0]=='.' || qstr->name[1]=='.') goto x; |
23 | hpfs_adjust_length((char *)qstr->name, &l); | 23 | hpfs_adjust_length(qstr->name, &l); |
24 | /*if (hpfs_chk_name((char *)qstr->name,&l))*/ | 24 | /*if (hpfs_chk_name(qstr->name,&l))*/ |
25 | /*return -ENAMETOOLONG;*/ | 25 | /*return -ENAMETOOLONG;*/ |
26 | /*return -ENOENT;*/ | 26 | /*return -ENOENT;*/ |
27 | x: | 27 | x: |
@@ -38,14 +38,16 @@ static int hpfs_compare_dentry(struct dentry *dentry, struct qstr *a, struct qst | |||
38 | { | 38 | { |
39 | unsigned al=a->len; | 39 | unsigned al=a->len; |
40 | unsigned bl=b->len; | 40 | unsigned bl=b->len; |
41 | hpfs_adjust_length((char *)a->name, &al); | 41 | hpfs_adjust_length(a->name, &al); |
42 | /*hpfs_adjust_length((char *)b->name, &bl);*/ | 42 | /*hpfs_adjust_length(b->name, &bl);*/ |
43 | /* 'a' is the qstr of an already existing dentry, so the name | 43 | /* 'a' is the qstr of an already existing dentry, so the name |
44 | * must be valid. 'b' must be validated first. | 44 | * must be valid. 'b' must be validated first. |
45 | */ | 45 | */ |
46 | 46 | ||
47 | if (hpfs_chk_name((char *)b->name, &bl)) return 1; | 47 | if (hpfs_chk_name(b->name, &bl)) |
48 | if (hpfs_compare_names(dentry->d_sb, (char *)a->name, al, (char *)b->name, bl, 0)) return 1; | 48 | return 1; |
49 | if (hpfs_compare_names(dentry->d_sb, a->name, al, b->name, bl, 0)) | ||
50 | return 1; | ||
49 | return 0; | 51 | return 0; |
50 | } | 52 | } |
51 | 53 | ||
diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index 8865c94f55f6..26e3964a4b8c 100644 --- a/fs/hpfs/dir.c +++ b/fs/hpfs/dir.c | |||
@@ -59,7 +59,7 @@ static int hpfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
59 | struct hpfs_dirent *de; | 59 | struct hpfs_dirent *de; |
60 | int lc; | 60 | int lc; |
61 | long old_pos; | 61 | long old_pos; |
62 | char *tempname; | 62 | unsigned char *tempname; |
63 | int c1, c2 = 0; | 63 | int c1, c2 = 0; |
64 | int ret = 0; | 64 | int ret = 0; |
65 | 65 | ||
@@ -158,11 +158,11 @@ static int hpfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
158 | tempname = hpfs_translate_name(inode->i_sb, de->name, de->namelen, lc, de->not_8x3); | 158 | tempname = hpfs_translate_name(inode->i_sb, de->name, de->namelen, lc, de->not_8x3); |
159 | if (filldir(dirent, tempname, de->namelen, old_pos, de->fnode, DT_UNKNOWN) < 0) { | 159 | if (filldir(dirent, tempname, de->namelen, old_pos, de->fnode, DT_UNKNOWN) < 0) { |
160 | filp->f_pos = old_pos; | 160 | filp->f_pos = old_pos; |
161 | if (tempname != (char *)de->name) kfree(tempname); | 161 | if (tempname != de->name) kfree(tempname); |
162 | hpfs_brelse4(&qbh); | 162 | hpfs_brelse4(&qbh); |
163 | goto out; | 163 | goto out; |
164 | } | 164 | } |
165 | if (tempname != (char *)de->name) kfree(tempname); | 165 | if (tempname != de->name) kfree(tempname); |
166 | hpfs_brelse4(&qbh); | 166 | hpfs_brelse4(&qbh); |
167 | } | 167 | } |
168 | out: | 168 | out: |
@@ -187,7 +187,7 @@ out: | |||
187 | 187 | ||
188 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 188 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) |
189 | { | 189 | { |
190 | const char *name = dentry->d_name.name; | 190 | const unsigned char *name = dentry->d_name.name; |
191 | unsigned len = dentry->d_name.len; | 191 | unsigned len = dentry->d_name.len; |
192 | struct quad_buffer_head qbh; | 192 | struct quad_buffer_head qbh; |
193 | struct hpfs_dirent *de; | 193 | struct hpfs_dirent *de; |
@@ -197,7 +197,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
197 | struct hpfs_inode_info *hpfs_result; | 197 | struct hpfs_inode_info *hpfs_result; |
198 | 198 | ||
199 | lock_kernel(); | 199 | lock_kernel(); |
200 | if ((err = hpfs_chk_name((char *)name, &len))) { | 200 | if ((err = hpfs_chk_name(name, &len))) { |
201 | if (err == -ENAMETOOLONG) { | 201 | if (err == -ENAMETOOLONG) { |
202 | unlock_kernel(); | 202 | unlock_kernel(); |
203 | return ERR_PTR(-ENAMETOOLONG); | 203 | return ERR_PTR(-ENAMETOOLONG); |
@@ -209,7 +209,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
209 | * '.' and '..' will never be passed here. | 209 | * '.' and '..' will never be passed here. |
210 | */ | 210 | */ |
211 | 211 | ||
212 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *) name, len, NULL, &qbh); | 212 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, NULL, &qbh); |
213 | 213 | ||
214 | /* | 214 | /* |
215 | * This is not really a bailout, just means file not found. | 215 | * This is not really a bailout, just means file not found. |
@@ -250,7 +250,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
250 | hpfs_result = hpfs_i(result); | 250 | hpfs_result = hpfs_i(result); |
251 | if (!de->directory) hpfs_result->i_parent_dir = dir->i_ino; | 251 | if (!de->directory) hpfs_result->i_parent_dir = dir->i_ino; |
252 | 252 | ||
253 | hpfs_decide_conv(result, (char *)name, len); | 253 | hpfs_decide_conv(result, name, len); |
254 | 254 | ||
255 | if (de->has_acl || de->has_xtd_perm) if (!(dir->i_sb->s_flags & MS_RDONLY)) { | 255 | if (de->has_acl || de->has_xtd_perm) if (!(dir->i_sb->s_flags & MS_RDONLY)) { |
256 | hpfs_error(result->i_sb, "ACLs or XPERM found. This is probably HPFS386. This driver doesn't support it now. Send me some info on these structures"); | 256 | hpfs_error(result->i_sb, "ACLs or XPERM found. This is probably HPFS386. This driver doesn't support it now. Send me some info on these structures"); |
diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c index fe83c2b7d2d8..9b2ffadfc8c4 100644 --- a/fs/hpfs/dnode.c +++ b/fs/hpfs/dnode.c | |||
@@ -158,7 +158,8 @@ static void set_last_pointer(struct super_block *s, struct dnode *d, dnode_secno | |||
158 | 158 | ||
159 | /* Add an entry to dnode and don't care if it grows over 2048 bytes */ | 159 | /* Add an entry to dnode and don't care if it grows over 2048 bytes */ |
160 | 160 | ||
161 | struct hpfs_dirent *hpfs_add_de(struct super_block *s, struct dnode *d, unsigned char *name, | 161 | struct hpfs_dirent *hpfs_add_de(struct super_block *s, struct dnode *d, |
162 | const unsigned char *name, | ||
162 | unsigned namelen, secno down_ptr) | 163 | unsigned namelen, secno down_ptr) |
163 | { | 164 | { |
164 | struct hpfs_dirent *de; | 165 | struct hpfs_dirent *de; |
@@ -223,7 +224,7 @@ static void fix_up_ptrs(struct super_block *s, struct dnode *d) | |||
223 | /* Add an entry to dnode and do dnode splitting if required */ | 224 | /* Add an entry to dnode and do dnode splitting if required */ |
224 | 225 | ||
225 | static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | 226 | static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, |
226 | unsigned char *name, unsigned namelen, | 227 | const unsigned char *name, unsigned namelen, |
227 | struct hpfs_dirent *new_de, dnode_secno down_ptr) | 228 | struct hpfs_dirent *new_de, dnode_secno down_ptr) |
228 | { | 229 | { |
229 | struct quad_buffer_head qbh, qbh1, qbh2; | 230 | struct quad_buffer_head qbh, qbh1, qbh2; |
@@ -231,7 +232,7 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
231 | dnode_secno adno, rdno; | 232 | dnode_secno adno, rdno; |
232 | struct hpfs_dirent *de; | 233 | struct hpfs_dirent *de; |
233 | struct hpfs_dirent nde; | 234 | struct hpfs_dirent nde; |
234 | char *nname; | 235 | unsigned char *nname; |
235 | int h; | 236 | int h; |
236 | int pos; | 237 | int pos; |
237 | struct buffer_head *bh; | 238 | struct buffer_head *bh; |
@@ -305,7 +306,9 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
305 | pos++; | 306 | pos++; |
306 | } | 307 | } |
307 | copy_de(new_de = &nde, de); | 308 | copy_de(new_de = &nde, de); |
308 | memcpy(name = nname, de->name, namelen = de->namelen); | 309 | memcpy(nname, de->name, de->namelen); |
310 | name = nname; | ||
311 | namelen = de->namelen; | ||
309 | for_all_poss(i, hpfs_pos_subst, ((loff_t)dno << 4) | pos, 4); | 312 | for_all_poss(i, hpfs_pos_subst, ((loff_t)dno << 4) | pos, 4); |
310 | down_ptr = adno; | 313 | down_ptr = adno; |
311 | set_last_pointer(i->i_sb, ad, de->down ? de_down_pointer(de) : 0); | 314 | set_last_pointer(i->i_sb, ad, de->down ? de_down_pointer(de) : 0); |
@@ -368,7 +371,8 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
368 | * I hope, now it's finally bug-free. | 371 | * I hope, now it's finally bug-free. |
369 | */ | 372 | */ |
370 | 373 | ||
371 | int hpfs_add_dirent(struct inode *i, unsigned char *name, unsigned namelen, | 374 | int hpfs_add_dirent(struct inode *i, |
375 | const unsigned char *name, unsigned namelen, | ||
372 | struct hpfs_dirent *new_de, int cdepth) | 376 | struct hpfs_dirent *new_de, int cdepth) |
373 | { | 377 | { |
374 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); | 378 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); |
@@ -897,7 +901,8 @@ struct hpfs_dirent *map_pos_dirent(struct inode *inode, loff_t *posp, | |||
897 | 901 | ||
898 | /* Find a dirent in tree */ | 902 | /* Find a dirent in tree */ |
899 | 903 | ||
900 | struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno, char *name, unsigned len, | 904 | struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno, |
905 | const unsigned char *name, unsigned len, | ||
901 | dnode_secno *dd, struct quad_buffer_head *qbh) | 906 | dnode_secno *dd, struct quad_buffer_head *qbh) |
902 | { | 907 | { |
903 | struct dnode *dnode; | 908 | struct dnode *dnode; |
@@ -988,8 +993,8 @@ void hpfs_remove_dtree(struct super_block *s, dnode_secno dno) | |||
988 | struct hpfs_dirent *map_fnode_dirent(struct super_block *s, fnode_secno fno, | 993 | struct hpfs_dirent *map_fnode_dirent(struct super_block *s, fnode_secno fno, |
989 | struct fnode *f, struct quad_buffer_head *qbh) | 994 | struct fnode *f, struct quad_buffer_head *qbh) |
990 | { | 995 | { |
991 | char *name1; | 996 | unsigned char *name1; |
992 | char *name2; | 997 | unsigned char *name2; |
993 | int name1len, name2len; | 998 | int name1len, name2len; |
994 | struct dnode *d; | 999 | struct dnode *d; |
995 | dnode_secno dno, downd; | 1000 | dnode_secno dno, downd; |
diff --git a/fs/hpfs/ea.c b/fs/hpfs/ea.c index 547a8384571f..45e53d972b42 100644 --- a/fs/hpfs/ea.c +++ b/fs/hpfs/ea.c | |||
@@ -62,8 +62,8 @@ static char *get_indirect_ea(struct super_block *s, int ano, secno a, int size) | |||
62 | return ret; | 62 | return ret; |
63 | } | 63 | } |
64 | 64 | ||
65 | static void set_indirect_ea(struct super_block *s, int ano, secno a, char *data, | 65 | static void set_indirect_ea(struct super_block *s, int ano, secno a, |
66 | int size) | 66 | const char *data, int size) |
67 | { | 67 | { |
68 | hpfs_ea_write(s, a, ano, 0, size, data); | 68 | hpfs_ea_write(s, a, ano, 0, size, data); |
69 | } | 69 | } |
@@ -186,7 +186,8 @@ char *hpfs_get_ea(struct super_block *s, struct fnode *fnode, char *key, int *si | |||
186 | * This driver can't change sizes of eas ('cause I just don't need it). | 186 | * This driver can't change sizes of eas ('cause I just don't need it). |
187 | */ | 187 | */ |
188 | 188 | ||
189 | void hpfs_set_ea(struct inode *inode, struct fnode *fnode, char *key, char *data, int size) | 189 | void hpfs_set_ea(struct inode *inode, struct fnode *fnode, const char *key, |
190 | const char *data, int size) | ||
190 | { | 191 | { |
191 | fnode_secno fno = inode->i_ino; | 192 | fnode_secno fno = inode->i_ino; |
192 | struct super_block *s = inode->i_sb; | 193 | struct super_block *s = inode->i_sb; |
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index 701ca54c0867..97bf738cd5d6 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h | |||
@@ -215,7 +215,7 @@ secno hpfs_bplus_lookup(struct super_block *, struct inode *, struct bplus_heade | |||
215 | secno hpfs_add_sector_to_btree(struct super_block *, secno, int, unsigned); | 215 | secno hpfs_add_sector_to_btree(struct super_block *, secno, int, unsigned); |
216 | void hpfs_remove_btree(struct super_block *, struct bplus_header *); | 216 | void hpfs_remove_btree(struct super_block *, struct bplus_header *); |
217 | int hpfs_ea_read(struct super_block *, secno, int, unsigned, unsigned, char *); | 217 | int hpfs_ea_read(struct super_block *, secno, int, unsigned, unsigned, char *); |
218 | int hpfs_ea_write(struct super_block *, secno, int, unsigned, unsigned, char *); | 218 | int hpfs_ea_write(struct super_block *, secno, int, unsigned, unsigned, const char *); |
219 | void hpfs_ea_remove(struct super_block *, secno, int, unsigned); | 219 | void hpfs_ea_remove(struct super_block *, secno, int, unsigned); |
220 | void hpfs_truncate_btree(struct super_block *, secno, int, unsigned); | 220 | void hpfs_truncate_btree(struct super_block *, secno, int, unsigned); |
221 | void hpfs_remove_fnode(struct super_block *, fnode_secno fno); | 221 | void hpfs_remove_fnode(struct super_block *, fnode_secno fno); |
@@ -244,13 +244,17 @@ extern const struct file_operations hpfs_dir_ops; | |||
244 | 244 | ||
245 | void hpfs_add_pos(struct inode *, loff_t *); | 245 | void hpfs_add_pos(struct inode *, loff_t *); |
246 | void hpfs_del_pos(struct inode *, loff_t *); | 246 | void hpfs_del_pos(struct inode *, loff_t *); |
247 | struct hpfs_dirent *hpfs_add_de(struct super_block *, struct dnode *, unsigned char *, unsigned, secno); | 247 | struct hpfs_dirent *hpfs_add_de(struct super_block *, struct dnode *, |
248 | int hpfs_add_dirent(struct inode *, unsigned char *, unsigned, struct hpfs_dirent *, int); | 248 | const unsigned char *, unsigned, secno); |
249 | int hpfs_add_dirent(struct inode *, const unsigned char *, unsigned, | ||
250 | struct hpfs_dirent *, int); | ||
249 | int hpfs_remove_dirent(struct inode *, dnode_secno, struct hpfs_dirent *, struct quad_buffer_head *, int); | 251 | int hpfs_remove_dirent(struct inode *, dnode_secno, struct hpfs_dirent *, struct quad_buffer_head *, int); |
250 | void hpfs_count_dnodes(struct super_block *, dnode_secno, int *, int *, int *); | 252 | void hpfs_count_dnodes(struct super_block *, dnode_secno, int *, int *, int *); |
251 | dnode_secno hpfs_de_as_down_as_possible(struct super_block *, dnode_secno dno); | 253 | dnode_secno hpfs_de_as_down_as_possible(struct super_block *, dnode_secno dno); |
252 | struct hpfs_dirent *map_pos_dirent(struct inode *, loff_t *, struct quad_buffer_head *); | 254 | struct hpfs_dirent *map_pos_dirent(struct inode *, loff_t *, struct quad_buffer_head *); |
253 | struct hpfs_dirent *map_dirent(struct inode *, dnode_secno, char *, unsigned, dnode_secno *, struct quad_buffer_head *); | 255 | struct hpfs_dirent *map_dirent(struct inode *, dnode_secno, |
256 | const unsigned char *, unsigned, dnode_secno *, | ||
257 | struct quad_buffer_head *); | ||
254 | void hpfs_remove_dtree(struct super_block *, dnode_secno); | 258 | void hpfs_remove_dtree(struct super_block *, dnode_secno); |
255 | struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct fnode *, struct quad_buffer_head *); | 259 | struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct fnode *, struct quad_buffer_head *); |
256 | 260 | ||
@@ -259,7 +263,8 @@ struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct f | |||
259 | void hpfs_ea_ext_remove(struct super_block *, secno, int, unsigned); | 263 | void hpfs_ea_ext_remove(struct super_block *, secno, int, unsigned); |
260 | int hpfs_read_ea(struct super_block *, struct fnode *, char *, char *, int); | 264 | int hpfs_read_ea(struct super_block *, struct fnode *, char *, char *, int); |
261 | char *hpfs_get_ea(struct super_block *, struct fnode *, char *, int *); | 265 | char *hpfs_get_ea(struct super_block *, struct fnode *, char *, int *); |
262 | void hpfs_set_ea(struct inode *, struct fnode *, char *, char *, int); | 266 | void hpfs_set_ea(struct inode *, struct fnode *, const char *, |
267 | const char *, int); | ||
263 | 268 | ||
264 | /* file.c */ | 269 | /* file.c */ |
265 | 270 | ||
@@ -282,7 +287,7 @@ void hpfs_delete_inode(struct inode *); | |||
282 | 287 | ||
283 | unsigned *hpfs_map_dnode_bitmap(struct super_block *, struct quad_buffer_head *); | 288 | unsigned *hpfs_map_dnode_bitmap(struct super_block *, struct quad_buffer_head *); |
284 | unsigned *hpfs_map_bitmap(struct super_block *, unsigned, struct quad_buffer_head *, char *); | 289 | unsigned *hpfs_map_bitmap(struct super_block *, unsigned, struct quad_buffer_head *, char *); |
285 | char *hpfs_load_code_page(struct super_block *, secno); | 290 | unsigned char *hpfs_load_code_page(struct super_block *, secno); |
286 | secno *hpfs_load_bitmap_directory(struct super_block *, secno bmp); | 291 | secno *hpfs_load_bitmap_directory(struct super_block *, secno bmp); |
287 | struct fnode *hpfs_map_fnode(struct super_block *s, ino_t, struct buffer_head **); | 292 | struct fnode *hpfs_map_fnode(struct super_block *s, ino_t, struct buffer_head **); |
288 | struct anode *hpfs_map_anode(struct super_block *s, anode_secno, struct buffer_head **); | 293 | struct anode *hpfs_map_anode(struct super_block *s, anode_secno, struct buffer_head **); |
@@ -292,12 +297,13 @@ dnode_secno hpfs_fnode_dno(struct super_block *s, ino_t ino); | |||
292 | /* name.c */ | 297 | /* name.c */ |
293 | 298 | ||
294 | unsigned char hpfs_upcase(unsigned char *, unsigned char); | 299 | unsigned char hpfs_upcase(unsigned char *, unsigned char); |
295 | int hpfs_chk_name(unsigned char *, unsigned *); | 300 | int hpfs_chk_name(const unsigned char *, unsigned *); |
296 | char *hpfs_translate_name(struct super_block *, unsigned char *, unsigned, int, int); | 301 | unsigned char *hpfs_translate_name(struct super_block *, unsigned char *, unsigned, int, int); |
297 | int hpfs_compare_names(struct super_block *, unsigned char *, unsigned, unsigned char *, unsigned, int); | 302 | int hpfs_compare_names(struct super_block *, const unsigned char *, unsigned, |
298 | int hpfs_is_name_long(unsigned char *, unsigned); | 303 | const unsigned char *, unsigned, int); |
299 | void hpfs_adjust_length(unsigned char *, unsigned *); | 304 | int hpfs_is_name_long(const unsigned char *, unsigned); |
300 | void hpfs_decide_conv(struct inode *, unsigned char *, unsigned); | 305 | void hpfs_adjust_length(const unsigned char *, unsigned *); |
306 | void hpfs_decide_conv(struct inode *, const unsigned char *, unsigned); | ||
301 | 307 | ||
302 | /* namei.c */ | 308 | /* namei.c */ |
303 | 309 | ||
diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c index fe703ae46bc7..ff90affb94e1 100644 --- a/fs/hpfs/inode.c +++ b/fs/hpfs/inode.c | |||
@@ -46,7 +46,7 @@ void hpfs_read_inode(struct inode *i) | |||
46 | struct fnode *fnode; | 46 | struct fnode *fnode; |
47 | struct super_block *sb = i->i_sb; | 47 | struct super_block *sb = i->i_sb; |
48 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); | 48 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); |
49 | unsigned char *ea; | 49 | void *ea; |
50 | int ea_size; | 50 | int ea_size; |
51 | 51 | ||
52 | if (!(fnode = hpfs_map_fnode(sb, i->i_ino, &bh))) { | 52 | if (!(fnode = hpfs_map_fnode(sb, i->i_ino, &bh))) { |
@@ -112,7 +112,7 @@ void hpfs_read_inode(struct inode *i) | |||
112 | } | 112 | } |
113 | } | 113 | } |
114 | if (fnode->dirflag) { | 114 | if (fnode->dirflag) { |
115 | unsigned n_dnodes, n_subdirs; | 115 | int n_dnodes, n_subdirs; |
116 | i->i_mode |= S_IFDIR; | 116 | i->i_mode |= S_IFDIR; |
117 | i->i_op = &hpfs_dir_iops; | 117 | i->i_op = &hpfs_dir_iops; |
118 | i->i_fop = &hpfs_dir_ops; | 118 | i->i_fop = &hpfs_dir_ops; |
diff --git a/fs/hpfs/map.c b/fs/hpfs/map.c index c4724589b2eb..840d033ecee8 100644 --- a/fs/hpfs/map.c +++ b/fs/hpfs/map.c | |||
@@ -35,7 +35,7 @@ unsigned int *hpfs_map_bitmap(struct super_block *s, unsigned bmp_block, | |||
35 | * lowercasing table | 35 | * lowercasing table |
36 | */ | 36 | */ |
37 | 37 | ||
38 | char *hpfs_load_code_page(struct super_block *s, secno cps) | 38 | unsigned char *hpfs_load_code_page(struct super_block *s, secno cps) |
39 | { | 39 | { |
40 | struct buffer_head *bh; | 40 | struct buffer_head *bh; |
41 | secno cpds; | 41 | secno cpds; |
@@ -71,7 +71,7 @@ char *hpfs_load_code_page(struct super_block *s, secno cps) | |||
71 | brelse(bh); | 71 | brelse(bh); |
72 | return NULL; | 72 | return NULL; |
73 | } | 73 | } |
74 | ptr = (char *)cpd + cpd->offs[cpi] + 6; | 74 | ptr = (unsigned char *)cpd + cpd->offs[cpi] + 6; |
75 | if (!(cp_table = kmalloc(256, GFP_KERNEL))) { | 75 | if (!(cp_table = kmalloc(256, GFP_KERNEL))) { |
76 | printk("HPFS: out of memory for code page table\n"); | 76 | printk("HPFS: out of memory for code page table\n"); |
77 | brelse(bh); | 77 | brelse(bh); |
@@ -217,7 +217,7 @@ struct dnode *hpfs_map_dnode(struct super_block *s, unsigned secno, | |||
217 | if ((dnode = hpfs_map_4sectors(s, secno, qbh, DNODE_RD_AHEAD))) | 217 | if ((dnode = hpfs_map_4sectors(s, secno, qbh, DNODE_RD_AHEAD))) |
218 | if (hpfs_sb(s)->sb_chk) { | 218 | if (hpfs_sb(s)->sb_chk) { |
219 | unsigned p, pp = 0; | 219 | unsigned p, pp = 0; |
220 | unsigned char *d = (char *)dnode; | 220 | unsigned char *d = (unsigned char *)dnode; |
221 | int b = 0; | 221 | int b = 0; |
222 | if (dnode->magic != DNODE_MAGIC) { | 222 | if (dnode->magic != DNODE_MAGIC) { |
223 | hpfs_error(s, "bad magic on dnode %08x", secno); | 223 | hpfs_error(s, "bad magic on dnode %08x", secno); |
diff --git a/fs/hpfs/name.c b/fs/hpfs/name.c index 1f4a964384eb..f24736d7a439 100644 --- a/fs/hpfs/name.c +++ b/fs/hpfs/name.c | |||
@@ -8,16 +8,16 @@ | |||
8 | 8 | ||
9 | #include "hpfs_fn.h" | 9 | #include "hpfs_fn.h" |
10 | 10 | ||
11 | static char *text_postfix[]={ | 11 | static const char *text_postfix[]={ |
12 | ".ASM", ".BAS", ".BAT", ".C", ".CC", ".CFG", ".CMD", ".CON", ".CPP", ".DEF", | 12 | ".ASM", ".BAS", ".BAT", ".C", ".CC", ".CFG", ".CMD", ".CON", ".CPP", ".DEF", |
13 | ".DOC", ".DPR", ".ERX", ".H", ".HPP", ".HTM", ".HTML", ".JAVA", ".LOG", ".PAS", | 13 | ".DOC", ".DPR", ".ERX", ".H", ".HPP", ".HTM", ".HTML", ".JAVA", ".LOG", ".PAS", |
14 | ".RC", ".TEX", ".TXT", ".Y", ""}; | 14 | ".RC", ".TEX", ".TXT", ".Y", ""}; |
15 | 15 | ||
16 | static char *text_prefix[]={ | 16 | static const char *text_prefix[]={ |
17 | "AUTOEXEC.", "CHANGES", "COPYING", "CONFIG.", "CREDITS", "FAQ", "FILE_ID.DIZ", | 17 | "AUTOEXEC.", "CHANGES", "COPYING", "CONFIG.", "CREDITS", "FAQ", "FILE_ID.DIZ", |
18 | "MAKEFILE", "READ.ME", "README", "TERMCAP", ""}; | 18 | "MAKEFILE", "READ.ME", "README", "TERMCAP", ""}; |
19 | 19 | ||
20 | void hpfs_decide_conv(struct inode *inode, unsigned char *name, unsigned len) | 20 | void hpfs_decide_conv(struct inode *inode, const unsigned char *name, unsigned len) |
21 | { | 21 | { |
22 | struct hpfs_inode_info *hpfs_inode = hpfs_i(inode); | 22 | struct hpfs_inode_info *hpfs_inode = hpfs_i(inode); |
23 | int i; | 23 | int i; |
@@ -71,7 +71,7 @@ static inline unsigned char locase(unsigned char *dir, unsigned char a) | |||
71 | return dir[a]; | 71 | return dir[a]; |
72 | } | 72 | } |
73 | 73 | ||
74 | int hpfs_chk_name(unsigned char *name, unsigned *len) | 74 | int hpfs_chk_name(const unsigned char *name, unsigned *len) |
75 | { | 75 | { |
76 | int i; | 76 | int i; |
77 | if (*len > 254) return -ENAMETOOLONG; | 77 | if (*len > 254) return -ENAMETOOLONG; |
@@ -83,10 +83,10 @@ int hpfs_chk_name(unsigned char *name, unsigned *len) | |||
83 | return 0; | 83 | return 0; |
84 | } | 84 | } |
85 | 85 | ||
86 | char *hpfs_translate_name(struct super_block *s, unsigned char *from, | 86 | unsigned char *hpfs_translate_name(struct super_block *s, unsigned char *from, |
87 | unsigned len, int lc, int lng) | 87 | unsigned len, int lc, int lng) |
88 | { | 88 | { |
89 | char *to; | 89 | unsigned char *to; |
90 | int i; | 90 | int i; |
91 | if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { | 91 | if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { |
92 | printk("HPFS: Long name flag mismatch - name "); | 92 | printk("HPFS: Long name flag mismatch - name "); |
@@ -103,8 +103,9 @@ char *hpfs_translate_name(struct super_block *s, unsigned char *from, | |||
103 | return to; | 103 | return to; |
104 | } | 104 | } |
105 | 105 | ||
106 | int hpfs_compare_names(struct super_block *s, unsigned char *n1, unsigned l1, | 106 | int hpfs_compare_names(struct super_block *s, |
107 | unsigned char *n2, unsigned l2, int last) | 107 | const unsigned char *n1, unsigned l1, |
108 | const unsigned char *n2, unsigned l2, int last) | ||
108 | { | 109 | { |
109 | unsigned l = l1 < l2 ? l1 : l2; | 110 | unsigned l = l1 < l2 ? l1 : l2; |
110 | unsigned i; | 111 | unsigned i; |
@@ -120,7 +121,7 @@ int hpfs_compare_names(struct super_block *s, unsigned char *n1, unsigned l1, | |||
120 | return 0; | 121 | return 0; |
121 | } | 122 | } |
122 | 123 | ||
123 | int hpfs_is_name_long(unsigned char *name, unsigned len) | 124 | int hpfs_is_name_long(const unsigned char *name, unsigned len) |
124 | { | 125 | { |
125 | int i,j; | 126 | int i,j; |
126 | for (i = 0; i < len && name[i] != '.'; i++) | 127 | for (i = 0; i < len && name[i] != '.'; i++) |
@@ -134,7 +135,7 @@ int hpfs_is_name_long(unsigned char *name, unsigned len) | |||
134 | 135 | ||
135 | /* OS/2 clears dots and spaces at the end of file name, so we have to */ | 136 | /* OS/2 clears dots and spaces at the end of file name, so we have to */ |
136 | 137 | ||
137 | void hpfs_adjust_length(unsigned char *name, unsigned *len) | 138 | void hpfs_adjust_length(const unsigned char *name, unsigned *len) |
138 | { | 139 | { |
139 | if (!*len) return; | 140 | if (!*len) return; |
140 | if (*len == 1 && name[0] == '.') return; | 141 | if (*len == 1 && name[0] == '.') return; |
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 82b9c4ba9ed0..11c2b4080f65 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c | |||
@@ -11,7 +11,7 @@ | |||
11 | 11 | ||
12 | static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | 12 | static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) |
13 | { | 13 | { |
14 | const char *name = dentry->d_name.name; | 14 | const unsigned char *name = dentry->d_name.name; |
15 | unsigned len = dentry->d_name.len; | 15 | unsigned len = dentry->d_name.len; |
16 | struct quad_buffer_head qbh0; | 16 | struct quad_buffer_head qbh0; |
17 | struct buffer_head *bh; | 17 | struct buffer_head *bh; |
@@ -24,7 +24,7 @@ static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
24 | int r; | 24 | int r; |
25 | struct hpfs_dirent dee; | 25 | struct hpfs_dirent dee; |
26 | int err; | 26 | int err; |
27 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 27 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
28 | lock_kernel(); | 28 | lock_kernel(); |
29 | err = -ENOSPC; | 29 | err = -ENOSPC; |
30 | fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); | 30 | fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); |
@@ -62,7 +62,7 @@ static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
62 | result->i_mode &= ~0222; | 62 | result->i_mode &= ~0222; |
63 | 63 | ||
64 | mutex_lock(&hpfs_i(dir)->i_mutex); | 64 | mutex_lock(&hpfs_i(dir)->i_mutex); |
65 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 65 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
66 | if (r == 1) | 66 | if (r == 1) |
67 | goto bail3; | 67 | goto bail3; |
68 | if (r == -1) { | 68 | if (r == -1) { |
@@ -121,7 +121,7 @@ bail: | |||
121 | 121 | ||
122 | static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struct nameidata *nd) | 122 | static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struct nameidata *nd) |
123 | { | 123 | { |
124 | const char *name = dentry->d_name.name; | 124 | const unsigned char *name = dentry->d_name.name; |
125 | unsigned len = dentry->d_name.len; | 125 | unsigned len = dentry->d_name.len; |
126 | struct inode *result = NULL; | 126 | struct inode *result = NULL; |
127 | struct buffer_head *bh; | 127 | struct buffer_head *bh; |
@@ -130,7 +130,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
130 | int r; | 130 | int r; |
131 | struct hpfs_dirent dee; | 131 | struct hpfs_dirent dee; |
132 | int err; | 132 | int err; |
133 | if ((err = hpfs_chk_name((char *)name, &len))) | 133 | if ((err = hpfs_chk_name(name, &len))) |
134 | return err==-ENOENT ? -EINVAL : err; | 134 | return err==-ENOENT ? -EINVAL : err; |
135 | lock_kernel(); | 135 | lock_kernel(); |
136 | err = -ENOSPC; | 136 | err = -ENOSPC; |
@@ -155,7 +155,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
155 | result->i_op = &hpfs_file_iops; | 155 | result->i_op = &hpfs_file_iops; |
156 | result->i_fop = &hpfs_file_ops; | 156 | result->i_fop = &hpfs_file_ops; |
157 | result->i_nlink = 1; | 157 | result->i_nlink = 1; |
158 | hpfs_decide_conv(result, (char *)name, len); | 158 | hpfs_decide_conv(result, name, len); |
159 | hpfs_i(result)->i_parent_dir = dir->i_ino; | 159 | hpfs_i(result)->i_parent_dir = dir->i_ino; |
160 | result->i_ctime.tv_sec = result->i_mtime.tv_sec = result->i_atime.tv_sec = local_to_gmt(dir->i_sb, dee.creation_date); | 160 | result->i_ctime.tv_sec = result->i_mtime.tv_sec = result->i_atime.tv_sec = local_to_gmt(dir->i_sb, dee.creation_date); |
161 | result->i_ctime.tv_nsec = 0; | 161 | result->i_ctime.tv_nsec = 0; |
@@ -170,7 +170,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
170 | hpfs_i(result)->mmu_private = 0; | 170 | hpfs_i(result)->mmu_private = 0; |
171 | 171 | ||
172 | mutex_lock(&hpfs_i(dir)->i_mutex); | 172 | mutex_lock(&hpfs_i(dir)->i_mutex); |
173 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 173 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
174 | if (r == 1) | 174 | if (r == 1) |
175 | goto bail2; | 175 | goto bail2; |
176 | if (r == -1) { | 176 | if (r == -1) { |
@@ -211,7 +211,7 @@ bail: | |||
211 | 211 | ||
212 | static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev) | 212 | static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev) |
213 | { | 213 | { |
214 | const char *name = dentry->d_name.name; | 214 | const unsigned char *name = dentry->d_name.name; |
215 | unsigned len = dentry->d_name.len; | 215 | unsigned len = dentry->d_name.len; |
216 | struct buffer_head *bh; | 216 | struct buffer_head *bh; |
217 | struct fnode *fnode; | 217 | struct fnode *fnode; |
@@ -220,7 +220,7 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t | |||
220 | struct hpfs_dirent dee; | 220 | struct hpfs_dirent dee; |
221 | struct inode *result = NULL; | 221 | struct inode *result = NULL; |
222 | int err; | 222 | int err; |
223 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 223 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
224 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; | 224 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; |
225 | if (!new_valid_dev(rdev)) | 225 | if (!new_valid_dev(rdev)) |
226 | return -EINVAL; | 226 | return -EINVAL; |
@@ -256,7 +256,7 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t | |||
256 | init_special_inode(result, mode, rdev); | 256 | init_special_inode(result, mode, rdev); |
257 | 257 | ||
258 | mutex_lock(&hpfs_i(dir)->i_mutex); | 258 | mutex_lock(&hpfs_i(dir)->i_mutex); |
259 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 259 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
260 | if (r == 1) | 260 | if (r == 1) |
261 | goto bail2; | 261 | goto bail2; |
262 | if (r == -1) { | 262 | if (r == -1) { |
@@ -289,7 +289,7 @@ bail: | |||
289 | 289 | ||
290 | static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *symlink) | 290 | static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *symlink) |
291 | { | 291 | { |
292 | const char *name = dentry->d_name.name; | 292 | const unsigned char *name = dentry->d_name.name; |
293 | unsigned len = dentry->d_name.len; | 293 | unsigned len = dentry->d_name.len; |
294 | struct buffer_head *bh; | 294 | struct buffer_head *bh; |
295 | struct fnode *fnode; | 295 | struct fnode *fnode; |
@@ -298,7 +298,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
298 | struct hpfs_dirent dee; | 298 | struct hpfs_dirent dee; |
299 | struct inode *result; | 299 | struct inode *result; |
300 | int err; | 300 | int err; |
301 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 301 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
302 | lock_kernel(); | 302 | lock_kernel(); |
303 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) { | 303 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) { |
304 | unlock_kernel(); | 304 | unlock_kernel(); |
@@ -335,7 +335,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
335 | result->i_data.a_ops = &hpfs_symlink_aops; | 335 | result->i_data.a_ops = &hpfs_symlink_aops; |
336 | 336 | ||
337 | mutex_lock(&hpfs_i(dir)->i_mutex); | 337 | mutex_lock(&hpfs_i(dir)->i_mutex); |
338 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 338 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
339 | if (r == 1) | 339 | if (r == 1) |
340 | goto bail2; | 340 | goto bail2; |
341 | if (r == -1) { | 341 | if (r == -1) { |
@@ -345,7 +345,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
345 | fnode->len = len; | 345 | fnode->len = len; |
346 | memcpy(fnode->name, name, len > 15 ? 15 : len); | 346 | memcpy(fnode->name, name, len > 15 ? 15 : len); |
347 | fnode->up = dir->i_ino; | 347 | fnode->up = dir->i_ino; |
348 | hpfs_set_ea(result, fnode, "SYMLINK", (char *)symlink, strlen(symlink)); | 348 | hpfs_set_ea(result, fnode, "SYMLINK", symlink, strlen(symlink)); |
349 | mark_buffer_dirty(bh); | 349 | mark_buffer_dirty(bh); |
350 | brelse(bh); | 350 | brelse(bh); |
351 | 351 | ||
@@ -369,7 +369,7 @@ bail: | |||
369 | 369 | ||
370 | static int hpfs_unlink(struct inode *dir, struct dentry *dentry) | 370 | static int hpfs_unlink(struct inode *dir, struct dentry *dentry) |
371 | { | 371 | { |
372 | const char *name = dentry->d_name.name; | 372 | const unsigned char *name = dentry->d_name.name; |
373 | unsigned len = dentry->d_name.len; | 373 | unsigned len = dentry->d_name.len; |
374 | struct quad_buffer_head qbh; | 374 | struct quad_buffer_head qbh; |
375 | struct hpfs_dirent *de; | 375 | struct hpfs_dirent *de; |
@@ -381,12 +381,12 @@ static int hpfs_unlink(struct inode *dir, struct dentry *dentry) | |||
381 | int err; | 381 | int err; |
382 | 382 | ||
383 | lock_kernel(); | 383 | lock_kernel(); |
384 | hpfs_adjust_length((char *)name, &len); | 384 | hpfs_adjust_length(name, &len); |
385 | again: | 385 | again: |
386 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); | 386 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); |
387 | mutex_lock(&hpfs_i(dir)->i_mutex); | 387 | mutex_lock(&hpfs_i(dir)->i_mutex); |
388 | err = -ENOENT; | 388 | err = -ENOENT; |
389 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *)name, len, &dno, &qbh); | 389 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, &dno, &qbh); |
390 | if (!de) | 390 | if (!de) |
391 | goto out; | 391 | goto out; |
392 | 392 | ||
@@ -413,22 +413,25 @@ again: | |||
413 | 413 | ||
414 | mutex_unlock(&hpfs_i(dir)->i_mutex); | 414 | mutex_unlock(&hpfs_i(dir)->i_mutex); |
415 | mutex_unlock(&hpfs_i(inode)->i_parent_mutex); | 415 | mutex_unlock(&hpfs_i(inode)->i_parent_mutex); |
416 | d_drop(dentry); | 416 | dentry_unhash(dentry); |
417 | spin_lock(&dentry->d_lock); | 417 | if (!d_unhashed(dentry)) { |
418 | if (atomic_read(&dentry->d_count) > 1 || | 418 | dput(dentry); |
419 | generic_permission(inode, MAY_WRITE, NULL) || | 419 | unlock_kernel(); |
420 | return -ENOSPC; | ||
421 | } | ||
422 | if (generic_permission(inode, MAY_WRITE, NULL) || | ||
420 | !S_ISREG(inode->i_mode) || | 423 | !S_ISREG(inode->i_mode) || |
421 | get_write_access(inode)) { | 424 | get_write_access(inode)) { |
422 | spin_unlock(&dentry->d_lock); | ||
423 | d_rehash(dentry); | 425 | d_rehash(dentry); |
426 | dput(dentry); | ||
424 | } else { | 427 | } else { |
425 | struct iattr newattrs; | 428 | struct iattr newattrs; |
426 | spin_unlock(&dentry->d_lock); | ||
427 | /*printk("HPFS: truncating file before delete.\n");*/ | 429 | /*printk("HPFS: truncating file before delete.\n");*/ |
428 | newattrs.ia_size = 0; | 430 | newattrs.ia_size = 0; |
429 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; | 431 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; |
430 | err = notify_change(dentry, &newattrs); | 432 | err = notify_change(dentry, &newattrs); |
431 | put_write_access(inode); | 433 | put_write_access(inode); |
434 | dput(dentry); | ||
432 | if (!err) | 435 | if (!err) |
433 | goto again; | 436 | goto again; |
434 | } | 437 | } |
@@ -451,7 +454,7 @@ out: | |||
451 | 454 | ||
452 | static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) | 455 | static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) |
453 | { | 456 | { |
454 | const char *name = dentry->d_name.name; | 457 | const unsigned char *name = dentry->d_name.name; |
455 | unsigned len = dentry->d_name.len; | 458 | unsigned len = dentry->d_name.len; |
456 | struct quad_buffer_head qbh; | 459 | struct quad_buffer_head qbh; |
457 | struct hpfs_dirent *de; | 460 | struct hpfs_dirent *de; |
@@ -462,12 +465,12 @@ static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
462 | int err; | 465 | int err; |
463 | int r; | 466 | int r; |
464 | 467 | ||
465 | hpfs_adjust_length((char *)name, &len); | 468 | hpfs_adjust_length(name, &len); |
466 | lock_kernel(); | 469 | lock_kernel(); |
467 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); | 470 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); |
468 | mutex_lock(&hpfs_i(dir)->i_mutex); | 471 | mutex_lock(&hpfs_i(dir)->i_mutex); |
469 | err = -ENOENT; | 472 | err = -ENOENT; |
470 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *)name, len, &dno, &qbh); | 473 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, &dno, &qbh); |
471 | if (!de) | 474 | if (!de) |
472 | goto out; | 475 | goto out; |
473 | 476 | ||
@@ -546,10 +549,10 @@ const struct address_space_operations hpfs_symlink_aops = { | |||
546 | static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | 549 | static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, |
547 | struct inode *new_dir, struct dentry *new_dentry) | 550 | struct inode *new_dir, struct dentry *new_dentry) |
548 | { | 551 | { |
549 | char *old_name = (char *)old_dentry->d_name.name; | 552 | const unsigned char *old_name = old_dentry->d_name.name; |
550 | int old_len = old_dentry->d_name.len; | 553 | unsigned old_len = old_dentry->d_name.len; |
551 | char *new_name = (char *)new_dentry->d_name.name; | 554 | const unsigned char *new_name = new_dentry->d_name.name; |
552 | int new_len = new_dentry->d_name.len; | 555 | unsigned new_len = new_dentry->d_name.len; |
553 | struct inode *i = old_dentry->d_inode; | 556 | struct inode *i = old_dentry->d_inode; |
554 | struct inode *new_inode = new_dentry->d_inode; | 557 | struct inode *new_inode = new_dentry->d_inode; |
555 | struct quad_buffer_head qbh, qbh1; | 558 | struct quad_buffer_head qbh, qbh1; |
@@ -560,9 +563,9 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
560 | struct buffer_head *bh; | 563 | struct buffer_head *bh; |
561 | struct fnode *fnode; | 564 | struct fnode *fnode; |
562 | int err; | 565 | int err; |
563 | if ((err = hpfs_chk_name((char *)new_name, &new_len))) return err; | 566 | if ((err = hpfs_chk_name(new_name, &new_len))) return err; |
564 | err = 0; | 567 | err = 0; |
565 | hpfs_adjust_length((char *)old_name, &old_len); | 568 | hpfs_adjust_length(old_name, &old_len); |
566 | 569 | ||
567 | lock_kernel(); | 570 | lock_kernel(); |
568 | /* order doesn't matter, due to VFS exclusion */ | 571 | /* order doesn't matter, due to VFS exclusion */ |
@@ -579,7 +582,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
579 | goto end1; | 582 | goto end1; |
580 | } | 583 | } |
581 | 584 | ||
582 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, (char *)old_name, old_len, &dno, &qbh))) { | 585 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, old_name, old_len, &dno, &qbh))) { |
583 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed"); | 586 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed"); |
584 | err = -ENOENT; | 587 | err = -ENOENT; |
585 | goto end1; | 588 | goto end1; |
@@ -590,7 +593,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
590 | if (new_inode) { | 593 | if (new_inode) { |
591 | int r; | 594 | int r; |
592 | if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) { | 595 | if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) { |
593 | if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, (char *)new_name, new_len, NULL, &qbh1))) { | 596 | if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, new_name, new_len, NULL, &qbh1))) { |
594 | clear_nlink(new_inode); | 597 | clear_nlink(new_inode); |
595 | copy_de(nde, &de); | 598 | copy_de(nde, &de); |
596 | memcpy(nde->name, new_name, new_len); | 599 | memcpy(nde->name, new_name, new_len); |
@@ -618,7 +621,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
618 | } | 621 | } |
619 | 622 | ||
620 | if (new_dir == old_dir) | 623 | if (new_dir == old_dir) |
621 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, (char *)old_name, old_len, &dno, &qbh))) { | 624 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, old_name, old_len, &dno, &qbh))) { |
622 | hpfs_unlock_creation(i->i_sb); | 625 | hpfs_unlock_creation(i->i_sb); |
623 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed at #2"); | 626 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed at #2"); |
624 | err = -ENOENT; | 627 | err = -ENOENT; |
@@ -648,7 +651,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
648 | brelse(bh); | 651 | brelse(bh); |
649 | } | 652 | } |
650 | hpfs_i(i)->i_conv = hpfs_sb(i->i_sb)->sb_conv; | 653 | hpfs_i(i)->i_conv = hpfs_sb(i->i_sb)->sb_conv; |
651 | hpfs_decide_conv(i, (char *)new_name, new_len); | 654 | hpfs_decide_conv(i, new_name, new_len); |
652 | end1: | 655 | end1: |
653 | if (old_dir != new_dir) | 656 | if (old_dir != new_dir) |
654 | mutex_unlock(&hpfs_i(new_dir)->i_mutex); | 657 | mutex_unlock(&hpfs_i(new_dir)->i_mutex); |
diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c index 7239efc690d8..2e4dfa8593da 100644 --- a/fs/hppfs/hppfs.c +++ b/fs/hppfs/hppfs.c | |||
@@ -718,7 +718,7 @@ static int hppfs_fill_super(struct super_block *sb, void *d, int silent) | |||
718 | struct vfsmount *proc_mnt; | 718 | struct vfsmount *proc_mnt; |
719 | int err = -ENOENT; | 719 | int err = -ENOENT; |
720 | 720 | ||
721 | proc_mnt = do_kern_mount("proc", 0, "proc", NULL); | 721 | proc_mnt = mntget(current->nsproxy->pid_ns->proc_mnt); |
722 | if (IS_ERR(proc_mnt)) | 722 | if (IS_ERR(proc_mnt)) |
723 | goto out; | 723 | goto out; |
724 | 724 | ||
diff --git a/fs/internal.h b/fs/internal.h index e96a1667d749..8a03a5447bdf 100644 --- a/fs/internal.h +++ b/fs/internal.h | |||
@@ -70,6 +70,8 @@ extern struct vfsmount *copy_tree(struct vfsmount *, struct dentry *, int); | |||
70 | 70 | ||
71 | extern void __init mnt_init(void); | 71 | extern void __init mnt_init(void); |
72 | 72 | ||
73 | extern spinlock_t vfsmount_lock; | ||
74 | |||
73 | /* | 75 | /* |
74 | * fs_struct.c | 76 | * fs_struct.c |
75 | */ | 77 | */ |
diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c index 886849370950..30beb11ef928 100644 --- a/fs/jbd2/checkpoint.c +++ b/fs/jbd2/checkpoint.c | |||
@@ -507,6 +507,7 @@ int jbd2_cleanup_journal_tail(journal_t *journal) | |||
507 | if (blocknr < journal->j_tail) | 507 | if (blocknr < journal->j_tail) |
508 | freed = freed + journal->j_last - journal->j_first; | 508 | freed = freed + journal->j_last - journal->j_first; |
509 | 509 | ||
510 | trace_jbd2_cleanup_journal_tail(journal, first_tid, blocknr, freed); | ||
510 | jbd_debug(1, | 511 | jbd_debug(1, |
511 | "Cleaning journal tail from %d to %d (offset %lu), " | 512 | "Cleaning journal tail from %d to %d (offset %lu), " |
512 | "freeing %lu\n", | 513 | "freeing %lu\n", |
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index 1bc74b6f26d2..671da7fb7ffd 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c | |||
@@ -883,8 +883,7 @@ restart_loop: | |||
883 | spin_unlock(&journal->j_list_lock); | 883 | spin_unlock(&journal->j_list_lock); |
884 | bh = jh2bh(jh); | 884 | bh = jh2bh(jh); |
885 | jbd_lock_bh_state(bh); | 885 | jbd_lock_bh_state(bh); |
886 | J_ASSERT_JH(jh, jh->b_transaction == commit_transaction || | 886 | J_ASSERT_JH(jh, jh->b_transaction == commit_transaction); |
887 | jh->b_transaction == journal->j_running_transaction); | ||
888 | 887 | ||
889 | /* | 888 | /* |
890 | * If there is undo-protected committed data against | 889 | * If there is undo-protected committed data against |
@@ -930,12 +929,12 @@ restart_loop: | |||
930 | /* A buffer which has been freed while still being | 929 | /* A buffer which has been freed while still being |
931 | * journaled by a previous transaction may end up still | 930 | * journaled by a previous transaction may end up still |
932 | * being dirty here, but we want to avoid writing back | 931 | * being dirty here, but we want to avoid writing back |
933 | * that buffer in the future now that the last use has | 932 | * that buffer in the future after the "add to orphan" |
934 | * been committed. That's not only a performance gain, | 933 | * operation been committed, That's not only a performance |
935 | * it also stops aliasing problems if the buffer is left | 934 | * gain, it also stops aliasing problems if the buffer is |
936 | * behind for writeback and gets reallocated for another | 935 | * left behind for writeback and gets reallocated for another |
937 | * use in a different page. */ | 936 | * use in a different page. */ |
938 | if (buffer_freed(bh)) { | 937 | if (buffer_freed(bh) && !jh->b_next_transaction) { |
939 | clear_buffer_freed(bh); | 938 | clear_buffer_freed(bh); |
940 | clear_buffer_jbddirty(bh); | 939 | clear_buffer_jbddirty(bh); |
941 | } | 940 | } |
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index ac0d027595d0..c03d4dce4d76 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c | |||
@@ -39,6 +39,8 @@ | |||
39 | #include <linux/seq_file.h> | 39 | #include <linux/seq_file.h> |
40 | #include <linux/math64.h> | 40 | #include <linux/math64.h> |
41 | #include <linux/hash.h> | 41 | #include <linux/hash.h> |
42 | #include <linux/log2.h> | ||
43 | #include <linux/vmalloc.h> | ||
42 | 44 | ||
43 | #define CREATE_TRACE_POINTS | 45 | #define CREATE_TRACE_POINTS |
44 | #include <trace/events/jbd2.h> | 46 | #include <trace/events/jbd2.h> |
@@ -93,6 +95,7 @@ EXPORT_SYMBOL(jbd2_journal_begin_ordered_truncate); | |||
93 | 95 | ||
94 | static int journal_convert_superblock_v1(journal_t *, journal_superblock_t *); | 96 | static int journal_convert_superblock_v1(journal_t *, journal_superblock_t *); |
95 | static void __journal_abort_soft (journal_t *journal, int errno); | 97 | static void __journal_abort_soft (journal_t *journal, int errno); |
98 | static int jbd2_journal_create_slab(size_t slab_size); | ||
96 | 99 | ||
97 | /* | 100 | /* |
98 | * Helper function used to manage commit timeouts | 101 | * Helper function used to manage commit timeouts |
@@ -1248,6 +1251,13 @@ int jbd2_journal_load(journal_t *journal) | |||
1248 | } | 1251 | } |
1249 | } | 1252 | } |
1250 | 1253 | ||
1254 | /* | ||
1255 | * Create a slab for this blocksize | ||
1256 | */ | ||
1257 | err = jbd2_journal_create_slab(be32_to_cpu(sb->s_blocksize)); | ||
1258 | if (err) | ||
1259 | return err; | ||
1260 | |||
1251 | /* Let the recovery code check whether it needs to recover any | 1261 | /* Let the recovery code check whether it needs to recover any |
1252 | * data from the journal. */ | 1262 | * data from the journal. */ |
1253 | if (jbd2_journal_recover(journal)) | 1263 | if (jbd2_journal_recover(journal)) |
@@ -1807,6 +1817,127 @@ size_t journal_tag_bytes(journal_t *journal) | |||
1807 | } | 1817 | } |
1808 | 1818 | ||
1809 | /* | 1819 | /* |
1820 | * JBD memory management | ||
1821 | * | ||
1822 | * These functions are used to allocate block-sized chunks of memory | ||
1823 | * used for making copies of buffer_head data. Very often it will be | ||
1824 | * page-sized chunks of data, but sometimes it will be in | ||
1825 | * sub-page-size chunks. (For example, 16k pages on Power systems | ||
1826 | * with a 4k block file system.) For blocks smaller than a page, we | ||
1827 | * use a SLAB allocator. There are slab caches for each block size, | ||
1828 | * which are allocated at mount time, if necessary, and we only free | ||
1829 | * (all of) the slab caches when/if the jbd2 module is unloaded. For | ||
1830 | * this reason we don't need to a mutex to protect access to | ||
1831 | * jbd2_slab[] allocating or releasing memory; only in | ||
1832 | * jbd2_journal_create_slab(). | ||
1833 | */ | ||
1834 | #define JBD2_MAX_SLABS 8 | ||
1835 | static struct kmem_cache *jbd2_slab[JBD2_MAX_SLABS]; | ||
1836 | static DECLARE_MUTEX(jbd2_slab_create_sem); | ||
1837 | |||
1838 | static const char *jbd2_slab_names[JBD2_MAX_SLABS] = { | ||
1839 | "jbd2_1k", "jbd2_2k", "jbd2_4k", "jbd2_8k", | ||
1840 | "jbd2_16k", "jbd2_32k", "jbd2_64k", "jbd2_128k" | ||
1841 | }; | ||
1842 | |||
1843 | |||
1844 | static void jbd2_journal_destroy_slabs(void) | ||
1845 | { | ||
1846 | int i; | ||
1847 | |||
1848 | for (i = 0; i < JBD2_MAX_SLABS; i++) { | ||
1849 | if (jbd2_slab[i]) | ||
1850 | kmem_cache_destroy(jbd2_slab[i]); | ||
1851 | jbd2_slab[i] = NULL; | ||
1852 | } | ||
1853 | } | ||
1854 | |||
1855 | static int jbd2_journal_create_slab(size_t size) | ||
1856 | { | ||
1857 | int i = order_base_2(size) - 10; | ||
1858 | size_t slab_size; | ||
1859 | |||
1860 | if (size == PAGE_SIZE) | ||
1861 | return 0; | ||
1862 | |||
1863 | if (i >= JBD2_MAX_SLABS) | ||
1864 | return -EINVAL; | ||
1865 | |||
1866 | if (unlikely(i < 0)) | ||
1867 | i = 0; | ||
1868 | down(&jbd2_slab_create_sem); | ||
1869 | if (jbd2_slab[i]) { | ||
1870 | up(&jbd2_slab_create_sem); | ||
1871 | return 0; /* Already created */ | ||
1872 | } | ||
1873 | |||
1874 | slab_size = 1 << (i+10); | ||
1875 | jbd2_slab[i] = kmem_cache_create(jbd2_slab_names[i], slab_size, | ||
1876 | slab_size, 0, NULL); | ||
1877 | up(&jbd2_slab_create_sem); | ||
1878 | if (!jbd2_slab[i]) { | ||
1879 | printk(KERN_EMERG "JBD2: no memory for jbd2_slab cache\n"); | ||
1880 | return -ENOMEM; | ||
1881 | } | ||
1882 | return 0; | ||
1883 | } | ||
1884 | |||
1885 | static struct kmem_cache *get_slab(size_t size) | ||
1886 | { | ||
1887 | int i = order_base_2(size) - 10; | ||
1888 | |||
1889 | BUG_ON(i >= JBD2_MAX_SLABS); | ||
1890 | if (unlikely(i < 0)) | ||
1891 | i = 0; | ||
1892 | BUG_ON(jbd2_slab[i] == 0); | ||
1893 | return jbd2_slab[i]; | ||
1894 | } | ||
1895 | |||
1896 | void *jbd2_alloc(size_t size, gfp_t flags) | ||
1897 | { | ||
1898 | void *ptr; | ||
1899 | |||
1900 | BUG_ON(size & (size-1)); /* Must be a power of 2 */ | ||
1901 | |||
1902 | flags |= __GFP_REPEAT; | ||
1903 | if (size == PAGE_SIZE) | ||
1904 | ptr = (void *)__get_free_pages(flags, 0); | ||
1905 | else if (size > PAGE_SIZE) { | ||
1906 | int order = get_order(size); | ||
1907 | |||
1908 | if (order < 3) | ||
1909 | ptr = (void *)__get_free_pages(flags, order); | ||
1910 | else | ||
1911 | ptr = vmalloc(size); | ||
1912 | } else | ||
1913 | ptr = kmem_cache_alloc(get_slab(size), flags); | ||
1914 | |||
1915 | /* Check alignment; SLUB has gotten this wrong in the past, | ||
1916 | * and this can lead to user data corruption! */ | ||
1917 | BUG_ON(((unsigned long) ptr) & (size-1)); | ||
1918 | |||
1919 | return ptr; | ||
1920 | } | ||
1921 | |||
1922 | void jbd2_free(void *ptr, size_t size) | ||
1923 | { | ||
1924 | if (size == PAGE_SIZE) { | ||
1925 | free_pages((unsigned long)ptr, 0); | ||
1926 | return; | ||
1927 | } | ||
1928 | if (size > PAGE_SIZE) { | ||
1929 | int order = get_order(size); | ||
1930 | |||
1931 | if (order < 3) | ||
1932 | free_pages((unsigned long)ptr, order); | ||
1933 | else | ||
1934 | vfree(ptr); | ||
1935 | return; | ||
1936 | } | ||
1937 | kmem_cache_free(get_slab(size), ptr); | ||
1938 | }; | ||
1939 | |||
1940 | /* | ||
1810 | * Journal_head storage management | 1941 | * Journal_head storage management |
1811 | */ | 1942 | */ |
1812 | static struct kmem_cache *jbd2_journal_head_cache; | 1943 | static struct kmem_cache *jbd2_journal_head_cache; |
@@ -2204,6 +2335,7 @@ static void jbd2_journal_destroy_caches(void) | |||
2204 | jbd2_journal_destroy_revoke_caches(); | 2335 | jbd2_journal_destroy_revoke_caches(); |
2205 | jbd2_journal_destroy_jbd2_journal_head_cache(); | 2336 | jbd2_journal_destroy_jbd2_journal_head_cache(); |
2206 | jbd2_journal_destroy_handle_cache(); | 2337 | jbd2_journal_destroy_handle_cache(); |
2338 | jbd2_journal_destroy_slabs(); | ||
2207 | } | 2339 | } |
2208 | 2340 | ||
2209 | static int __init journal_init(void) | 2341 | static int __init journal_init(void) |
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index a0512700542f..bfc70f57900f 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c | |||
@@ -1727,6 +1727,21 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1727 | if (!jh) | 1727 | if (!jh) |
1728 | goto zap_buffer_no_jh; | 1728 | goto zap_buffer_no_jh; |
1729 | 1729 | ||
1730 | /* | ||
1731 | * We cannot remove the buffer from checkpoint lists until the | ||
1732 | * transaction adding inode to orphan list (let's call it T) | ||
1733 | * is committed. Otherwise if the transaction changing the | ||
1734 | * buffer would be cleaned from the journal before T is | ||
1735 | * committed, a crash will cause that the correct contents of | ||
1736 | * the buffer will be lost. On the other hand we have to | ||
1737 | * clear the buffer dirty bit at latest at the moment when the | ||
1738 | * transaction marking the buffer as freed in the filesystem | ||
1739 | * structures is committed because from that moment on the | ||
1740 | * buffer can be reallocated and used by a different page. | ||
1741 | * Since the block hasn't been freed yet but the inode has | ||
1742 | * already been added to orphan list, it is safe for us to add | ||
1743 | * the buffer to BJ_Forget list of the newest transaction. | ||
1744 | */ | ||
1730 | transaction = jh->b_transaction; | 1745 | transaction = jh->b_transaction; |
1731 | if (transaction == NULL) { | 1746 | if (transaction == NULL) { |
1732 | /* First case: not on any transaction. If it | 1747 | /* First case: not on any transaction. If it |
@@ -1783,16 +1798,15 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1783 | } else if (transaction == journal->j_committing_transaction) { | 1798 | } else if (transaction == journal->j_committing_transaction) { |
1784 | JBUFFER_TRACE(jh, "on committing transaction"); | 1799 | JBUFFER_TRACE(jh, "on committing transaction"); |
1785 | /* | 1800 | /* |
1786 | * If it is committing, we simply cannot touch it. We | 1801 | * The buffer is committing, we simply cannot touch |
1787 | * can remove it's next_transaction pointer from the | 1802 | * it. So we just set j_next_transaction to the |
1788 | * running transaction if that is set, but nothing | 1803 | * running transaction (if there is one) and mark |
1789 | * else. */ | 1804 | * buffer as freed so that commit code knows it should |
1805 | * clear dirty bits when it is done with the buffer. | ||
1806 | */ | ||
1790 | set_buffer_freed(bh); | 1807 | set_buffer_freed(bh); |
1791 | if (jh->b_next_transaction) { | 1808 | if (journal->j_running_transaction && buffer_jbddirty(bh)) |
1792 | J_ASSERT(jh->b_next_transaction == | 1809 | jh->b_next_transaction = journal->j_running_transaction; |
1793 | journal->j_running_transaction); | ||
1794 | jh->b_next_transaction = NULL; | ||
1795 | } | ||
1796 | jbd2_journal_put_journal_head(jh); | 1810 | jbd2_journal_put_journal_head(jh); |
1797 | spin_unlock(&journal->j_list_lock); | 1811 | spin_unlock(&journal->j_list_lock); |
1798 | jbd_unlock_bh_state(bh); | 1812 | jbd_unlock_bh_state(bh); |
@@ -1969,7 +1983,7 @@ void jbd2_journal_file_buffer(struct journal_head *jh, | |||
1969 | */ | 1983 | */ |
1970 | void __jbd2_journal_refile_buffer(struct journal_head *jh) | 1984 | void __jbd2_journal_refile_buffer(struct journal_head *jh) |
1971 | { | 1985 | { |
1972 | int was_dirty; | 1986 | int was_dirty, jlist; |
1973 | struct buffer_head *bh = jh2bh(jh); | 1987 | struct buffer_head *bh = jh2bh(jh); |
1974 | 1988 | ||
1975 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); | 1989 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); |
@@ -1991,8 +2005,13 @@ void __jbd2_journal_refile_buffer(struct journal_head *jh) | |||
1991 | __jbd2_journal_temp_unlink_buffer(jh); | 2005 | __jbd2_journal_temp_unlink_buffer(jh); |
1992 | jh->b_transaction = jh->b_next_transaction; | 2006 | jh->b_transaction = jh->b_next_transaction; |
1993 | jh->b_next_transaction = NULL; | 2007 | jh->b_next_transaction = NULL; |
1994 | __jbd2_journal_file_buffer(jh, jh->b_transaction, | 2008 | if (buffer_freed(bh)) |
1995 | jh->b_modified ? BJ_Metadata : BJ_Reserved); | 2009 | jlist = BJ_Forget; |
2010 | else if (jh->b_modified) | ||
2011 | jlist = BJ_Metadata; | ||
2012 | else | ||
2013 | jlist = BJ_Reserved; | ||
2014 | __jbd2_journal_file_buffer(jh, jh->b_transaction, jlist); | ||
1996 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); | 2015 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); |
1997 | 2016 | ||
1998 | if (was_dirty) | 2017 | if (was_dirty) |
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index c694a5f15380..9dd126276c9f 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/buffer_head.h> | 22 | #include <linux/buffer_head.h> |
23 | #include <linux/pagemap.h> | 23 | #include <linux/pagemap.h> |
24 | #include <linux/quotaops.h> | 24 | #include <linux/quotaops.h> |
25 | #include <linux/writeback.h> | ||
25 | #include "jfs_incore.h" | 26 | #include "jfs_incore.h" |
26 | #include "jfs_inode.h" | 27 | #include "jfs_inode.h" |
27 | #include "jfs_filsys.h" | 28 | #include "jfs_filsys.h" |
@@ -120,8 +121,10 @@ int jfs_commit_inode(struct inode *inode, int wait) | |||
120 | return rc; | 121 | return rc; |
121 | } | 122 | } |
122 | 123 | ||
123 | int jfs_write_inode(struct inode *inode, int wait) | 124 | int jfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
124 | { | 125 | { |
126 | int wait = wbc->sync_mode == WB_SYNC_ALL; | ||
127 | |||
125 | if (test_cflag(COMMIT_Nolink, inode)) | 128 | if (test_cflag(COMMIT_Nolink, inode)) |
126 | return 0; | 129 | return 0; |
127 | /* | 130 | /* |
diff --git a/fs/jfs/jfs_inode.h b/fs/jfs/jfs_inode.h index 4b91b2787835..79e2c79661df 100644 --- a/fs/jfs/jfs_inode.h +++ b/fs/jfs/jfs_inode.h | |||
@@ -26,7 +26,7 @@ extern long jfs_ioctl(struct file *, unsigned int, unsigned long); | |||
26 | extern long jfs_compat_ioctl(struct file *, unsigned int, unsigned long); | 26 | extern long jfs_compat_ioctl(struct file *, unsigned int, unsigned long); |
27 | extern struct inode *jfs_iget(struct super_block *, unsigned long); | 27 | extern struct inode *jfs_iget(struct super_block *, unsigned long); |
28 | extern int jfs_commit_inode(struct inode *, int); | 28 | extern int jfs_commit_inode(struct inode *, int); |
29 | extern int jfs_write_inode(struct inode*, int); | 29 | extern int jfs_write_inode(struct inode *, struct writeback_control *); |
30 | extern void jfs_delete_inode(struct inode *); | 30 | extern void jfs_delete_inode(struct inode *); |
31 | extern void jfs_dirty_inode(struct inode *); | 31 | extern void jfs_dirty_inode(struct inode *); |
32 | extern void jfs_truncate(struct inode *); | 32 | extern void jfs_truncate(struct inode *); |
diff --git a/fs/libfs.c b/fs/libfs.c index 6e8d17e1dc4c..9e50bcf55857 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -338,28 +338,14 @@ int simple_readpage(struct file *file, struct page *page) | |||
338 | return 0; | 338 | return 0; |
339 | } | 339 | } |
340 | 340 | ||
341 | int simple_prepare_write(struct file *file, struct page *page, | ||
342 | unsigned from, unsigned to) | ||
343 | { | ||
344 | if (!PageUptodate(page)) { | ||
345 | if (to - from != PAGE_CACHE_SIZE) | ||
346 | zero_user_segments(page, | ||
347 | 0, from, | ||
348 | to, PAGE_CACHE_SIZE); | ||
349 | } | ||
350 | return 0; | ||
351 | } | ||
352 | |||
353 | int simple_write_begin(struct file *file, struct address_space *mapping, | 341 | int simple_write_begin(struct file *file, struct address_space *mapping, |
354 | loff_t pos, unsigned len, unsigned flags, | 342 | loff_t pos, unsigned len, unsigned flags, |
355 | struct page **pagep, void **fsdata) | 343 | struct page **pagep, void **fsdata) |
356 | { | 344 | { |
357 | struct page *page; | 345 | struct page *page; |
358 | pgoff_t index; | 346 | pgoff_t index; |
359 | unsigned from; | ||
360 | 347 | ||
361 | index = pos >> PAGE_CACHE_SHIFT; | 348 | index = pos >> PAGE_CACHE_SHIFT; |
362 | from = pos & (PAGE_CACHE_SIZE - 1); | ||
363 | 349 | ||
364 | page = grab_cache_page_write_begin(mapping, index, flags); | 350 | page = grab_cache_page_write_begin(mapping, index, flags); |
365 | if (!page) | 351 | if (!page) |
@@ -367,43 +353,59 @@ int simple_write_begin(struct file *file, struct address_space *mapping, | |||
367 | 353 | ||
368 | *pagep = page; | 354 | *pagep = page; |
369 | 355 | ||
370 | return simple_prepare_write(file, page, from, from+len); | 356 | if (!PageUptodate(page) && (len != PAGE_CACHE_SIZE)) { |
371 | } | 357 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); |
372 | |||
373 | static int simple_commit_write(struct file *file, struct page *page, | ||
374 | unsigned from, unsigned to) | ||
375 | { | ||
376 | struct inode *inode = page->mapping->host; | ||
377 | loff_t pos = ((loff_t)page->index << PAGE_CACHE_SHIFT) + to; | ||
378 | 358 | ||
379 | if (!PageUptodate(page)) | 359 | zero_user_segments(page, 0, from, from + len, PAGE_CACHE_SIZE); |
380 | SetPageUptodate(page); | 360 | } |
381 | /* | ||
382 | * No need to use i_size_read() here, the i_size | ||
383 | * cannot change under us because we hold the i_mutex. | ||
384 | */ | ||
385 | if (pos > inode->i_size) | ||
386 | i_size_write(inode, pos); | ||
387 | set_page_dirty(page); | ||
388 | return 0; | 361 | return 0; |
389 | } | 362 | } |
390 | 363 | ||
364 | /** | ||
365 | * simple_write_end - .write_end helper for non-block-device FSes | ||
366 | * @available: See .write_end of address_space_operations | ||
367 | * @file: " | ||
368 | * @mapping: " | ||
369 | * @pos: " | ||
370 | * @len: " | ||
371 | * @copied: " | ||
372 | * @page: " | ||
373 | * @fsdata: " | ||
374 | * | ||
375 | * simple_write_end does the minimum needed for updating a page after writing is | ||
376 | * done. It has the same API signature as the .write_end of | ||
377 | * address_space_operations vector. So it can just be set onto .write_end for | ||
378 | * FSes that don't need any other processing. i_mutex is assumed to be held. | ||
379 | * Block based filesystems should use generic_write_end(). | ||
380 | * NOTE: Even though i_size might get updated by this function, mark_inode_dirty | ||
381 | * is not called, so a filesystem that actually does store data in .write_inode | ||
382 | * should extend on what's done here with a call to mark_inode_dirty() in the | ||
383 | * case that i_size has changed. | ||
384 | */ | ||
391 | int simple_write_end(struct file *file, struct address_space *mapping, | 385 | int simple_write_end(struct file *file, struct address_space *mapping, |
392 | loff_t pos, unsigned len, unsigned copied, | 386 | loff_t pos, unsigned len, unsigned copied, |
393 | struct page *page, void *fsdata) | 387 | struct page *page, void *fsdata) |
394 | { | 388 | { |
395 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); | 389 | struct inode *inode = page->mapping->host; |
390 | loff_t last_pos = pos + copied; | ||
396 | 391 | ||
397 | /* zero the stale part of the page if we did a short copy */ | 392 | /* zero the stale part of the page if we did a short copy */ |
398 | if (copied < len) { | 393 | if (copied < len) { |
399 | void *kaddr = kmap_atomic(page, KM_USER0); | 394 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); |
400 | memset(kaddr + from + copied, 0, len - copied); | 395 | |
401 | flush_dcache_page(page); | 396 | zero_user(page, from + copied, len - copied); |
402 | kunmap_atomic(kaddr, KM_USER0); | ||
403 | } | 397 | } |
404 | 398 | ||
405 | simple_commit_write(file, page, from, from+copied); | 399 | if (!PageUptodate(page)) |
400 | SetPageUptodate(page); | ||
401 | /* | ||
402 | * No need to use i_size_read() here, the i_size | ||
403 | * cannot change under us because we hold the i_mutex. | ||
404 | */ | ||
405 | if (last_pos > inode->i_size) | ||
406 | i_size_write(inode, last_pos); | ||
406 | 407 | ||
408 | set_page_dirty(page); | ||
407 | unlock_page(page); | 409 | unlock_page(page); |
408 | page_cache_release(page); | 410 | page_cache_release(page); |
409 | 411 | ||
@@ -853,7 +855,6 @@ EXPORT_SYMBOL(simple_getattr); | |||
853 | EXPORT_SYMBOL(simple_link); | 855 | EXPORT_SYMBOL(simple_link); |
854 | EXPORT_SYMBOL(simple_lookup); | 856 | EXPORT_SYMBOL(simple_lookup); |
855 | EXPORT_SYMBOL(simple_pin_fs); | 857 | EXPORT_SYMBOL(simple_pin_fs); |
856 | EXPORT_UNUSED_SYMBOL(simple_prepare_write); | ||
857 | EXPORT_SYMBOL(simple_readpage); | 858 | EXPORT_SYMBOL(simple_readpage); |
858 | EXPORT_SYMBOL(simple_release_fs); | 859 | EXPORT_SYMBOL(simple_release_fs); |
859 | EXPORT_SYMBOL(simple_rename); | 860 | EXPORT_SYMBOL(simple_rename); |
diff --git a/fs/locks.c b/fs/locks.c index a8794f233bc9..ae9ded026b7c 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -1182,8 +1182,9 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1182 | struct file_lock *fl; | 1182 | struct file_lock *fl; |
1183 | unsigned long break_time; | 1183 | unsigned long break_time; |
1184 | int i_have_this_lease = 0; | 1184 | int i_have_this_lease = 0; |
1185 | int want_write = (mode & O_ACCMODE) != O_RDONLY; | ||
1185 | 1186 | ||
1186 | new_fl = lease_alloc(NULL, mode & FMODE_WRITE ? F_WRLCK : F_RDLCK); | 1187 | new_fl = lease_alloc(NULL, want_write ? F_WRLCK : F_RDLCK); |
1187 | 1188 | ||
1188 | lock_kernel(); | 1189 | lock_kernel(); |
1189 | 1190 | ||
@@ -1197,7 +1198,7 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1197 | if (fl->fl_owner == current->files) | 1198 | if (fl->fl_owner == current->files) |
1198 | i_have_this_lease = 1; | 1199 | i_have_this_lease = 1; |
1199 | 1200 | ||
1200 | if (mode & FMODE_WRITE) { | 1201 | if (want_write) { |
1201 | /* If we want write access, we have to revoke any lease. */ | 1202 | /* If we want write access, we have to revoke any lease. */ |
1202 | future = F_UNLCK | F_INPROGRESS; | 1203 | future = F_UNLCK | F_INPROGRESS; |
1203 | } else if (flock->fl_type & F_INPROGRESS) { | 1204 | } else if (flock->fl_type & F_INPROGRESS) { |
diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 74ea82d72164..756f8c93780c 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c | |||
@@ -17,8 +17,10 @@ | |||
17 | #include <linux/init.h> | 17 | #include <linux/init.h> |
18 | #include <linux/highuid.h> | 18 | #include <linux/highuid.h> |
19 | #include <linux/vfs.h> | 19 | #include <linux/vfs.h> |
20 | #include <linux/writeback.h> | ||
20 | 21 | ||
21 | static int minix_write_inode(struct inode * inode, int wait); | 22 | static int minix_write_inode(struct inode *inode, |
23 | struct writeback_control *wbc); | ||
22 | static int minix_statfs(struct dentry *dentry, struct kstatfs *buf); | 24 | static int minix_statfs(struct dentry *dentry, struct kstatfs *buf); |
23 | static int minix_remount (struct super_block * sb, int * flags, char * data); | 25 | static int minix_remount (struct super_block * sb, int * flags, char * data); |
24 | 26 | ||
@@ -552,7 +554,7 @@ static struct buffer_head * V2_minix_update_inode(struct inode * inode) | |||
552 | return bh; | 554 | return bh; |
553 | } | 555 | } |
554 | 556 | ||
555 | static int minix_write_inode(struct inode *inode, int wait) | 557 | static int minix_write_inode(struct inode *inode, struct writeback_control *wbc) |
556 | { | 558 | { |
557 | int err = 0; | 559 | int err = 0; |
558 | struct buffer_head *bh; | 560 | struct buffer_head *bh; |
@@ -563,7 +565,7 @@ static int minix_write_inode(struct inode *inode, int wait) | |||
563 | bh = V2_minix_update_inode(inode); | 565 | bh = V2_minix_update_inode(inode); |
564 | if (!bh) | 566 | if (!bh) |
565 | return -EIO; | 567 | return -EIO; |
566 | if (wait && buffer_dirty(bh)) { | 568 | if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) { |
567 | sync_dirty_buffer(bh); | 569 | sync_dirty_buffer(bh); |
568 | if (buffer_req(bh) && !buffer_uptodate(bh)) { | 570 | if (buffer_req(bh) && !buffer_uptodate(bh)) { |
569 | printk("IO error syncing minix inode [%s:%08lx]\n", | 571 | printk("IO error syncing minix inode [%s:%08lx]\n", |
diff --git a/fs/namei.c b/fs/namei.c index 06abd2bf473c..3d9d2f965f84 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -497,8 +497,6 @@ static int link_path_walk(const char *, struct nameidata *); | |||
497 | 497 | ||
498 | static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *link) | 498 | static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *link) |
499 | { | 499 | { |
500 | int res = 0; | ||
501 | char *name; | ||
502 | if (IS_ERR(link)) | 500 | if (IS_ERR(link)) |
503 | goto fail; | 501 | goto fail; |
504 | 502 | ||
@@ -509,22 +507,7 @@ static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *l | |||
509 | path_get(&nd->root); | 507 | path_get(&nd->root); |
510 | } | 508 | } |
511 | 509 | ||
512 | res = link_path_walk(link, nd); | 510 | return link_path_walk(link, nd); |
513 | if (nd->depth || res || nd->last_type!=LAST_NORM) | ||
514 | return res; | ||
515 | /* | ||
516 | * If it is an iterative symlinks resolution in open_namei() we | ||
517 | * have to copy the last component. And all that crap because of | ||
518 | * bloody create() on broken symlinks. Furrfu... | ||
519 | */ | ||
520 | name = __getname(); | ||
521 | if (unlikely(!name)) { | ||
522 | path_put(&nd->path); | ||
523 | return -ENOMEM; | ||
524 | } | ||
525 | strcpy(name, nd->last.name); | ||
526 | nd->last.name = name; | ||
527 | return 0; | ||
528 | fail: | 511 | fail: |
529 | path_put(&nd->path); | 512 | path_put(&nd->path); |
530 | return PTR_ERR(link); | 513 | return PTR_ERR(link); |
@@ -546,10 +529,10 @@ static inline void path_to_nameidata(struct path *path, struct nameidata *nd) | |||
546 | nd->path.dentry = path->dentry; | 529 | nd->path.dentry = path->dentry; |
547 | } | 530 | } |
548 | 531 | ||
549 | static __always_inline int __do_follow_link(struct path *path, struct nameidata *nd) | 532 | static __always_inline int |
533 | __do_follow_link(struct path *path, struct nameidata *nd, void **p) | ||
550 | { | 534 | { |
551 | int error; | 535 | int error; |
552 | void *cookie; | ||
553 | struct dentry *dentry = path->dentry; | 536 | struct dentry *dentry = path->dentry; |
554 | 537 | ||
555 | touch_atime(path->mnt, dentry); | 538 | touch_atime(path->mnt, dentry); |
@@ -561,9 +544,9 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
561 | } | 544 | } |
562 | mntget(path->mnt); | 545 | mntget(path->mnt); |
563 | nd->last_type = LAST_BIND; | 546 | nd->last_type = LAST_BIND; |
564 | cookie = dentry->d_inode->i_op->follow_link(dentry, nd); | 547 | *p = dentry->d_inode->i_op->follow_link(dentry, nd); |
565 | error = PTR_ERR(cookie); | 548 | error = PTR_ERR(*p); |
566 | if (!IS_ERR(cookie)) { | 549 | if (!IS_ERR(*p)) { |
567 | char *s = nd_get_link(nd); | 550 | char *s = nd_get_link(nd); |
568 | error = 0; | 551 | error = 0; |
569 | if (s) | 552 | if (s) |
@@ -573,8 +556,6 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
573 | if (error) | 556 | if (error) |
574 | path_put(&nd->path); | 557 | path_put(&nd->path); |
575 | } | 558 | } |
576 | if (dentry->d_inode->i_op->put_link) | ||
577 | dentry->d_inode->i_op->put_link(dentry, nd, cookie); | ||
578 | } | 559 | } |
579 | return error; | 560 | return error; |
580 | } | 561 | } |
@@ -588,6 +569,7 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
588 | */ | 569 | */ |
589 | static inline int do_follow_link(struct path *path, struct nameidata *nd) | 570 | static inline int do_follow_link(struct path *path, struct nameidata *nd) |
590 | { | 571 | { |
572 | void *cookie; | ||
591 | int err = -ELOOP; | 573 | int err = -ELOOP; |
592 | if (current->link_count >= MAX_NESTED_LINKS) | 574 | if (current->link_count >= MAX_NESTED_LINKS) |
593 | goto loop; | 575 | goto loop; |
@@ -601,7 +583,9 @@ static inline int do_follow_link(struct path *path, struct nameidata *nd) | |||
601 | current->link_count++; | 583 | current->link_count++; |
602 | current->total_link_count++; | 584 | current->total_link_count++; |
603 | nd->depth++; | 585 | nd->depth++; |
604 | err = __do_follow_link(path, nd); | 586 | err = __do_follow_link(path, nd, &cookie); |
587 | if (!IS_ERR(cookie) && path->dentry->d_inode->i_op->put_link) | ||
588 | path->dentry->d_inode->i_op->put_link(path->dentry, nd, cookie); | ||
605 | path_put(path); | 589 | path_put(path); |
606 | current->link_count--; | 590 | current->link_count--; |
607 | nd->depth--; | 591 | nd->depth--; |
@@ -688,33 +672,20 @@ static __always_inline void follow_dotdot(struct nameidata *nd) | |||
688 | set_root(nd); | 672 | set_root(nd); |
689 | 673 | ||
690 | while(1) { | 674 | while(1) { |
691 | struct vfsmount *parent; | ||
692 | struct dentry *old = nd->path.dentry; | 675 | struct dentry *old = nd->path.dentry; |
693 | 676 | ||
694 | if (nd->path.dentry == nd->root.dentry && | 677 | if (nd->path.dentry == nd->root.dentry && |
695 | nd->path.mnt == nd->root.mnt) { | 678 | nd->path.mnt == nd->root.mnt) { |
696 | break; | 679 | break; |
697 | } | 680 | } |
698 | spin_lock(&dcache_lock); | ||
699 | if (nd->path.dentry != nd->path.mnt->mnt_root) { | 681 | if (nd->path.dentry != nd->path.mnt->mnt_root) { |
700 | nd->path.dentry = dget(nd->path.dentry->d_parent); | 682 | /* rare case of legitimate dget_parent()... */ |
701 | spin_unlock(&dcache_lock); | 683 | nd->path.dentry = dget_parent(nd->path.dentry); |
702 | dput(old); | 684 | dput(old); |
703 | break; | 685 | break; |
704 | } | 686 | } |
705 | spin_unlock(&dcache_lock); | 687 | if (!follow_up(&nd->path)) |
706 | spin_lock(&vfsmount_lock); | ||
707 | parent = nd->path.mnt->mnt_parent; | ||
708 | if (parent == nd->path.mnt) { | ||
709 | spin_unlock(&vfsmount_lock); | ||
710 | break; | 688 | break; |
711 | } | ||
712 | mntget(parent); | ||
713 | nd->path.dentry = dget(nd->path.mnt->mnt_mountpoint); | ||
714 | spin_unlock(&vfsmount_lock); | ||
715 | dput(old); | ||
716 | mntput(nd->path.mnt); | ||
717 | nd->path.mnt = parent; | ||
718 | } | 689 | } |
719 | follow_mount(&nd->path); | 690 | follow_mount(&nd->path); |
720 | } | 691 | } |
@@ -1346,7 +1317,7 @@ static int may_delete(struct inode *dir,struct dentry *victim,int isdir) | |||
1346 | return -ENOENT; | 1317 | return -ENOENT; |
1347 | 1318 | ||
1348 | BUG_ON(victim->d_parent->d_inode != dir); | 1319 | BUG_ON(victim->d_parent->d_inode != dir); |
1349 | audit_inode_child(victim->d_name.name, victim, dir); | 1320 | audit_inode_child(victim, dir); |
1350 | 1321 | ||
1351 | error = inode_permission(dir, MAY_WRITE | MAY_EXEC); | 1322 | error = inode_permission(dir, MAY_WRITE | MAY_EXEC); |
1352 | if (error) | 1323 | if (error) |
@@ -1387,22 +1358,6 @@ static inline int may_create(struct inode *dir, struct dentry *child) | |||
1387 | return inode_permission(dir, MAY_WRITE | MAY_EXEC); | 1358 | return inode_permission(dir, MAY_WRITE | MAY_EXEC); |
1388 | } | 1359 | } |
1389 | 1360 | ||
1390 | /* | ||
1391 | * O_DIRECTORY translates into forcing a directory lookup. | ||
1392 | */ | ||
1393 | static inline int lookup_flags(unsigned int f) | ||
1394 | { | ||
1395 | unsigned long retval = LOOKUP_FOLLOW; | ||
1396 | |||
1397 | if (f & O_NOFOLLOW) | ||
1398 | retval &= ~LOOKUP_FOLLOW; | ||
1399 | |||
1400 | if (f & O_DIRECTORY) | ||
1401 | retval |= LOOKUP_DIRECTORY; | ||
1402 | |||
1403 | return retval; | ||
1404 | } | ||
1405 | |||
1406 | /* | 1361 | /* |
1407 | * p1 and p2 should be directories on the same fs. | 1362 | * p1 and p2 should be directories on the same fs. |
1408 | */ | 1363 | */ |
@@ -1501,7 +1456,7 @@ int may_open(struct path *path, int acc_mode, int flag) | |||
1501 | * An append-only file must be opened in append mode for writing. | 1456 | * An append-only file must be opened in append mode for writing. |
1502 | */ | 1457 | */ |
1503 | if (IS_APPEND(inode)) { | 1458 | if (IS_APPEND(inode)) { |
1504 | if ((flag & FMODE_WRITE) && !(flag & O_APPEND)) | 1459 | if ((flag & O_ACCMODE) != O_RDONLY && !(flag & O_APPEND)) |
1505 | return -EPERM; | 1460 | return -EPERM; |
1506 | if (flag & O_TRUNC) | 1461 | if (flag & O_TRUNC) |
1507 | return -EPERM; | 1462 | return -EPERM; |
@@ -1545,7 +1500,7 @@ static int handle_truncate(struct path *path) | |||
1545 | * what get passed to sys_open(). | 1500 | * what get passed to sys_open(). |
1546 | */ | 1501 | */ |
1547 | static int __open_namei_create(struct nameidata *nd, struct path *path, | 1502 | static int __open_namei_create(struct nameidata *nd, struct path *path, |
1548 | int flag, int mode) | 1503 | int open_flag, int mode) |
1549 | { | 1504 | { |
1550 | int error; | 1505 | int error; |
1551 | struct dentry *dir = nd->path.dentry; | 1506 | struct dentry *dir = nd->path.dentry; |
@@ -1563,7 +1518,7 @@ out_unlock: | |||
1563 | if (error) | 1518 | if (error) |
1564 | return error; | 1519 | return error; |
1565 | /* Don't check for write permission, don't truncate */ | 1520 | /* Don't check for write permission, don't truncate */ |
1566 | return may_open(&nd->path, 0, flag & ~O_TRUNC); | 1521 | return may_open(&nd->path, 0, open_flag & ~O_TRUNC); |
1567 | } | 1522 | } |
1568 | 1523 | ||
1569 | /* | 1524 | /* |
@@ -1601,129 +1556,132 @@ static int open_will_truncate(int flag, struct inode *inode) | |||
1601 | return (flag & O_TRUNC); | 1556 | return (flag & O_TRUNC); |
1602 | } | 1557 | } |
1603 | 1558 | ||
1604 | /* | 1559 | static struct file *finish_open(struct nameidata *nd, |
1605 | * Note that the low bits of the passed in "open_flag" | 1560 | int open_flag, int acc_mode) |
1606 | * are not the same as in the local variable "flag". See | ||
1607 | * open_to_namei_flags() for more details. | ||
1608 | */ | ||
1609 | struct file *do_filp_open(int dfd, const char *pathname, | ||
1610 | int open_flag, int mode, int acc_mode) | ||
1611 | { | 1561 | { |
1612 | struct file *filp; | 1562 | struct file *filp; |
1613 | struct nameidata nd; | ||
1614 | int error; | ||
1615 | struct path path; | ||
1616 | struct dentry *dir; | ||
1617 | int count = 0; | ||
1618 | int will_truncate; | 1563 | int will_truncate; |
1619 | int flag = open_to_namei_flags(open_flag); | 1564 | int error; |
1620 | int force_reval = 0; | ||
1621 | 1565 | ||
1566 | will_truncate = open_will_truncate(open_flag, nd->path.dentry->d_inode); | ||
1567 | if (will_truncate) { | ||
1568 | error = mnt_want_write(nd->path.mnt); | ||
1569 | if (error) | ||
1570 | goto exit; | ||
1571 | } | ||
1572 | error = may_open(&nd->path, acc_mode, open_flag); | ||
1573 | if (error) { | ||
1574 | if (will_truncate) | ||
1575 | mnt_drop_write(nd->path.mnt); | ||
1576 | goto exit; | ||
1577 | } | ||
1578 | filp = nameidata_to_filp(nd); | ||
1579 | if (!IS_ERR(filp)) { | ||
1580 | error = ima_file_check(filp, acc_mode); | ||
1581 | if (error) { | ||
1582 | fput(filp); | ||
1583 | filp = ERR_PTR(error); | ||
1584 | } | ||
1585 | } | ||
1586 | if (!IS_ERR(filp)) { | ||
1587 | if (will_truncate) { | ||
1588 | error = handle_truncate(&nd->path); | ||
1589 | if (error) { | ||
1590 | fput(filp); | ||
1591 | filp = ERR_PTR(error); | ||
1592 | } | ||
1593 | } | ||
1594 | } | ||
1622 | /* | 1595 | /* |
1623 | * O_SYNC is implemented as __O_SYNC|O_DSYNC. As many places only | 1596 | * It is now safe to drop the mnt write |
1624 | * check for O_DSYNC if the need any syncing at all we enforce it's | 1597 | * because the filp has had a write taken |
1625 | * always set instead of having to deal with possibly weird behaviour | 1598 | * on its behalf. |
1626 | * for malicious applications setting only __O_SYNC. | ||
1627 | */ | 1599 | */ |
1628 | if (open_flag & __O_SYNC) | 1600 | if (will_truncate) |
1629 | open_flag |= O_DSYNC; | 1601 | mnt_drop_write(nd->path.mnt); |
1630 | 1602 | return filp; | |
1631 | if (!acc_mode) | ||
1632 | acc_mode = MAY_OPEN | ACC_MODE(open_flag); | ||
1633 | 1603 | ||
1634 | /* O_TRUNC implies we need access checks for write permissions */ | 1604 | exit: |
1635 | if (flag & O_TRUNC) | 1605 | if (!IS_ERR(nd->intent.open.file)) |
1636 | acc_mode |= MAY_WRITE; | 1606 | release_open_intent(nd); |
1607 | path_put(&nd->path); | ||
1608 | return ERR_PTR(error); | ||
1609 | } | ||
1637 | 1610 | ||
1638 | /* Allow the LSM permission hook to distinguish append | 1611 | static struct file *do_last(struct nameidata *nd, struct path *path, |
1639 | access from general write access. */ | 1612 | int open_flag, int acc_mode, |
1640 | if (flag & O_APPEND) | 1613 | int mode, const char *pathname, |
1641 | acc_mode |= MAY_APPEND; | 1614 | int *want_dir) |
1615 | { | ||
1616 | struct dentry *dir = nd->path.dentry; | ||
1617 | struct file *filp; | ||
1618 | int error = -EISDIR; | ||
1642 | 1619 | ||
1643 | /* | 1620 | switch (nd->last_type) { |
1644 | * The simplest case - just a plain lookup. | 1621 | case LAST_DOTDOT: |
1645 | */ | 1622 | follow_dotdot(nd); |
1646 | if (!(flag & O_CREAT)) { | 1623 | dir = nd->path.dentry; |
1647 | filp = get_empty_filp(); | 1624 | if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) { |
1648 | 1625 | if (!dir->d_op->d_revalidate(dir, nd)) { | |
1649 | if (filp == NULL) | 1626 | error = -ESTALE; |
1650 | return ERR_PTR(-ENFILE); | 1627 | goto exit; |
1651 | nd.intent.open.file = filp; | ||
1652 | filp->f_flags = open_flag; | ||
1653 | nd.intent.open.flags = flag; | ||
1654 | nd.intent.open.create_mode = 0; | ||
1655 | error = do_path_lookup(dfd, pathname, | ||
1656 | lookup_flags(flag)|LOOKUP_OPEN, &nd); | ||
1657 | if (IS_ERR(nd.intent.open.file)) { | ||
1658 | if (error == 0) { | ||
1659 | error = PTR_ERR(nd.intent.open.file); | ||
1660 | path_put(&nd.path); | ||
1661 | } | 1628 | } |
1662 | } else if (error) | 1629 | } |
1663 | release_open_intent(&nd); | 1630 | /* fallthrough */ |
1664 | if (error) | 1631 | case LAST_DOT: |
1665 | return ERR_PTR(error); | 1632 | case LAST_ROOT: |
1633 | if (open_flag & O_CREAT) | ||
1634 | goto exit; | ||
1635 | /* fallthrough */ | ||
1636 | case LAST_BIND: | ||
1637 | audit_inode(pathname, dir); | ||
1666 | goto ok; | 1638 | goto ok; |
1667 | } | 1639 | } |
1668 | 1640 | ||
1669 | /* | 1641 | /* trailing slashes? */ |
1670 | * Create - we need to know the parent. | 1642 | if (nd->last.name[nd->last.len]) { |
1671 | */ | 1643 | if (open_flag & O_CREAT) |
1672 | reval: | 1644 | goto exit; |
1673 | error = path_init(dfd, pathname, LOOKUP_PARENT, &nd); | 1645 | *want_dir = 1; |
1674 | if (error) | ||
1675 | return ERR_PTR(error); | ||
1676 | if (force_reval) | ||
1677 | nd.flags |= LOOKUP_REVAL; | ||
1678 | error = path_walk(pathname, &nd); | ||
1679 | if (error) { | ||
1680 | if (nd.root.mnt) | ||
1681 | path_put(&nd.root); | ||
1682 | return ERR_PTR(error); | ||
1683 | } | 1646 | } |
1684 | if (unlikely(!audit_dummy_context())) | ||
1685 | audit_inode(pathname, nd.path.dentry); | ||
1686 | 1647 | ||
1687 | /* | 1648 | /* just plain open? */ |
1688 | * We have the parent and last component. First of all, check | 1649 | if (!(open_flag & O_CREAT)) { |
1689 | * that we are not asked to creat(2) an obvious directory - that | 1650 | error = do_lookup(nd, &nd->last, path); |
1690 | * will not do. | 1651 | if (error) |
1691 | */ | 1652 | goto exit; |
1692 | error = -EISDIR; | 1653 | error = -ENOENT; |
1693 | if (nd.last_type != LAST_NORM || nd.last.name[nd.last.len]) | 1654 | if (!path->dentry->d_inode) |
1694 | goto exit_parent; | 1655 | goto exit_dput; |
1656 | if (path->dentry->d_inode->i_op->follow_link) | ||
1657 | return NULL; | ||
1658 | error = -ENOTDIR; | ||
1659 | if (*want_dir & !path->dentry->d_inode->i_op->lookup) | ||
1660 | goto exit_dput; | ||
1661 | path_to_nameidata(path, nd); | ||
1662 | audit_inode(pathname, nd->path.dentry); | ||
1663 | goto ok; | ||
1664 | } | ||
1695 | 1665 | ||
1696 | error = -ENFILE; | 1666 | /* OK, it's O_CREAT */ |
1697 | filp = get_empty_filp(); | ||
1698 | if (filp == NULL) | ||
1699 | goto exit_parent; | ||
1700 | nd.intent.open.file = filp; | ||
1701 | filp->f_flags = open_flag; | ||
1702 | nd.intent.open.flags = flag; | ||
1703 | nd.intent.open.create_mode = mode; | ||
1704 | dir = nd.path.dentry; | ||
1705 | nd.flags &= ~LOOKUP_PARENT; | ||
1706 | nd.flags |= LOOKUP_CREATE | LOOKUP_OPEN; | ||
1707 | if (flag & O_EXCL) | ||
1708 | nd.flags |= LOOKUP_EXCL; | ||
1709 | mutex_lock(&dir->d_inode->i_mutex); | 1667 | mutex_lock(&dir->d_inode->i_mutex); |
1710 | path.dentry = lookup_hash(&nd); | ||
1711 | path.mnt = nd.path.mnt; | ||
1712 | 1668 | ||
1713 | do_last: | 1669 | path->dentry = lookup_hash(nd); |
1714 | error = PTR_ERR(path.dentry); | 1670 | path->mnt = nd->path.mnt; |
1715 | if (IS_ERR(path.dentry)) { | 1671 | |
1672 | error = PTR_ERR(path->dentry); | ||
1673 | if (IS_ERR(path->dentry)) { | ||
1716 | mutex_unlock(&dir->d_inode->i_mutex); | 1674 | mutex_unlock(&dir->d_inode->i_mutex); |
1717 | goto exit; | 1675 | goto exit; |
1718 | } | 1676 | } |
1719 | 1677 | ||
1720 | if (IS_ERR(nd.intent.open.file)) { | 1678 | if (IS_ERR(nd->intent.open.file)) { |
1721 | error = PTR_ERR(nd.intent.open.file); | 1679 | error = PTR_ERR(nd->intent.open.file); |
1722 | goto exit_mutex_unlock; | 1680 | goto exit_mutex_unlock; |
1723 | } | 1681 | } |
1724 | 1682 | ||
1725 | /* Negative dentry, just create the file */ | 1683 | /* Negative dentry, just create the file */ |
1726 | if (!path.dentry->d_inode) { | 1684 | if (!path->dentry->d_inode) { |
1727 | /* | 1685 | /* |
1728 | * This write is needed to ensure that a | 1686 | * This write is needed to ensure that a |
1729 | * ro->rw transition does not occur between | 1687 | * ro->rw transition does not occur between |
@@ -1731,18 +1689,16 @@ do_last: | |||
1731 | * a permanent write count is taken through | 1689 | * a permanent write count is taken through |
1732 | * the 'struct file' in nameidata_to_filp(). | 1690 | * the 'struct file' in nameidata_to_filp(). |
1733 | */ | 1691 | */ |
1734 | error = mnt_want_write(nd.path.mnt); | 1692 | error = mnt_want_write(nd->path.mnt); |
1735 | if (error) | 1693 | if (error) |
1736 | goto exit_mutex_unlock; | 1694 | goto exit_mutex_unlock; |
1737 | error = __open_namei_create(&nd, &path, flag, mode); | 1695 | error = __open_namei_create(nd, path, open_flag, mode); |
1738 | if (error) { | 1696 | if (error) { |
1739 | mnt_drop_write(nd.path.mnt); | 1697 | mnt_drop_write(nd->path.mnt); |
1740 | goto exit; | 1698 | goto exit; |
1741 | } | 1699 | } |
1742 | filp = nameidata_to_filp(&nd); | 1700 | filp = nameidata_to_filp(nd); |
1743 | mnt_drop_write(nd.path.mnt); | 1701 | mnt_drop_write(nd->path.mnt); |
1744 | if (nd.root.mnt) | ||
1745 | path_put(&nd.root); | ||
1746 | if (!IS_ERR(filp)) { | 1702 | if (!IS_ERR(filp)) { |
1747 | error = ima_file_check(filp, acc_mode); | 1703 | error = ima_file_check(filp, acc_mode); |
1748 | if (error) { | 1704 | if (error) { |
@@ -1757,147 +1713,181 @@ do_last: | |||
1757 | * It already exists. | 1713 | * It already exists. |
1758 | */ | 1714 | */ |
1759 | mutex_unlock(&dir->d_inode->i_mutex); | 1715 | mutex_unlock(&dir->d_inode->i_mutex); |
1760 | audit_inode(pathname, path.dentry); | 1716 | audit_inode(pathname, path->dentry); |
1761 | 1717 | ||
1762 | error = -EEXIST; | 1718 | error = -EEXIST; |
1763 | if (flag & O_EXCL) | 1719 | if (open_flag & O_EXCL) |
1764 | goto exit_dput; | 1720 | goto exit_dput; |
1765 | 1721 | ||
1766 | if (__follow_mount(&path)) { | 1722 | if (__follow_mount(path)) { |
1767 | error = -ELOOP; | 1723 | error = -ELOOP; |
1768 | if (flag & O_NOFOLLOW) | 1724 | if (open_flag & O_NOFOLLOW) |
1769 | goto exit_dput; | 1725 | goto exit_dput; |
1770 | } | 1726 | } |
1771 | 1727 | ||
1772 | error = -ENOENT; | 1728 | error = -ENOENT; |
1773 | if (!path.dentry->d_inode) | 1729 | if (!path->dentry->d_inode) |
1774 | goto exit_dput; | 1730 | goto exit_dput; |
1775 | if (path.dentry->d_inode->i_op->follow_link) | ||
1776 | goto do_link; | ||
1777 | 1731 | ||
1778 | path_to_nameidata(&path, &nd); | 1732 | if (path->dentry->d_inode->i_op->follow_link) |
1733 | return NULL; | ||
1734 | |||
1735 | path_to_nameidata(path, nd); | ||
1779 | error = -EISDIR; | 1736 | error = -EISDIR; |
1780 | if (S_ISDIR(path.dentry->d_inode->i_mode)) | 1737 | if (S_ISDIR(path->dentry->d_inode->i_mode)) |
1781 | goto exit; | 1738 | goto exit; |
1782 | ok: | 1739 | ok: |
1740 | filp = finish_open(nd, open_flag, acc_mode); | ||
1741 | return filp; | ||
1742 | |||
1743 | exit_mutex_unlock: | ||
1744 | mutex_unlock(&dir->d_inode->i_mutex); | ||
1745 | exit_dput: | ||
1746 | path_put_conditional(path, nd); | ||
1747 | exit: | ||
1748 | if (!IS_ERR(nd->intent.open.file)) | ||
1749 | release_open_intent(nd); | ||
1750 | path_put(&nd->path); | ||
1751 | return ERR_PTR(error); | ||
1752 | } | ||
1753 | |||
1754 | /* | ||
1755 | * Note that the low bits of the passed in "open_flag" | ||
1756 | * are not the same as in the local variable "flag". See | ||
1757 | * open_to_namei_flags() for more details. | ||
1758 | */ | ||
1759 | struct file *do_filp_open(int dfd, const char *pathname, | ||
1760 | int open_flag, int mode, int acc_mode) | ||
1761 | { | ||
1762 | struct file *filp; | ||
1763 | struct nameidata nd; | ||
1764 | int error; | ||
1765 | struct path path; | ||
1766 | int count = 0; | ||
1767 | int flag = open_to_namei_flags(open_flag); | ||
1768 | int force_reval = 0; | ||
1769 | int want_dir = open_flag & O_DIRECTORY; | ||
1770 | |||
1771 | if (!(open_flag & O_CREAT)) | ||
1772 | mode = 0; | ||
1773 | |||
1783 | /* | 1774 | /* |
1784 | * Consider: | 1775 | * O_SYNC is implemented as __O_SYNC|O_DSYNC. As many places only |
1785 | * 1. may_open() truncates a file | 1776 | * check for O_DSYNC if the need any syncing at all we enforce it's |
1786 | * 2. a rw->ro mount transition occurs | 1777 | * always set instead of having to deal with possibly weird behaviour |
1787 | * 3. nameidata_to_filp() fails due to | 1778 | * for malicious applications setting only __O_SYNC. |
1788 | * the ro mount. | ||
1789 | * That would be inconsistent, and should | ||
1790 | * be avoided. Taking this mnt write here | ||
1791 | * ensures that (2) can not occur. | ||
1792 | */ | 1779 | */ |
1793 | will_truncate = open_will_truncate(flag, nd.path.dentry->d_inode); | 1780 | if (open_flag & __O_SYNC) |
1794 | if (will_truncate) { | 1781 | open_flag |= O_DSYNC; |
1795 | error = mnt_want_write(nd.path.mnt); | 1782 | |
1796 | if (error) | 1783 | if (!acc_mode) |
1797 | goto exit; | 1784 | acc_mode = MAY_OPEN | ACC_MODE(open_flag); |
1798 | } | 1785 | |
1799 | error = may_open(&nd.path, acc_mode, flag); | 1786 | /* O_TRUNC implies we need access checks for write permissions */ |
1787 | if (open_flag & O_TRUNC) | ||
1788 | acc_mode |= MAY_WRITE; | ||
1789 | |||
1790 | /* Allow the LSM permission hook to distinguish append | ||
1791 | access from general write access. */ | ||
1792 | if (open_flag & O_APPEND) | ||
1793 | acc_mode |= MAY_APPEND; | ||
1794 | |||
1795 | /* find the parent */ | ||
1796 | reval: | ||
1797 | error = path_init(dfd, pathname, LOOKUP_PARENT, &nd); | ||
1798 | if (error) | ||
1799 | return ERR_PTR(error); | ||
1800 | if (force_reval) | ||
1801 | nd.flags |= LOOKUP_REVAL; | ||
1802 | |||
1803 | current->total_link_count = 0; | ||
1804 | error = link_path_walk(pathname, &nd); | ||
1800 | if (error) { | 1805 | if (error) { |
1801 | if (will_truncate) | 1806 | filp = ERR_PTR(error); |
1802 | mnt_drop_write(nd.path.mnt); | 1807 | goto out; |
1803 | goto exit; | ||
1804 | } | 1808 | } |
1805 | filp = nameidata_to_filp(&nd); | 1809 | if (unlikely(!audit_dummy_context()) && (open_flag & O_CREAT)) |
1806 | if (!IS_ERR(filp)) { | 1810 | audit_inode(pathname, nd.path.dentry); |
1807 | error = ima_file_check(filp, acc_mode); | 1811 | |
1808 | if (error) { | 1812 | /* |
1809 | fput(filp); | 1813 | * We have the parent and last component. |
1814 | */ | ||
1815 | |||
1816 | error = -ENFILE; | ||
1817 | filp = get_empty_filp(); | ||
1818 | if (filp == NULL) | ||
1819 | goto exit_parent; | ||
1820 | nd.intent.open.file = filp; | ||
1821 | filp->f_flags = open_flag; | ||
1822 | nd.intent.open.flags = flag; | ||
1823 | nd.intent.open.create_mode = mode; | ||
1824 | nd.flags &= ~LOOKUP_PARENT; | ||
1825 | nd.flags |= LOOKUP_OPEN; | ||
1826 | if (open_flag & O_CREAT) { | ||
1827 | nd.flags |= LOOKUP_CREATE; | ||
1828 | if (open_flag & O_EXCL) | ||
1829 | nd.flags |= LOOKUP_EXCL; | ||
1830 | } | ||
1831 | filp = do_last(&nd, &path, open_flag, acc_mode, mode, pathname, &want_dir); | ||
1832 | while (unlikely(!filp)) { /* trailing symlink */ | ||
1833 | struct path holder; | ||
1834 | struct inode *inode = path.dentry->d_inode; | ||
1835 | void *cookie; | ||
1836 | error = -ELOOP; | ||
1837 | /* S_ISDIR part is a temporary automount kludge */ | ||
1838 | if ((open_flag & O_NOFOLLOW) && !S_ISDIR(inode->i_mode)) | ||
1839 | goto exit_dput; | ||
1840 | if (count++ == 32) | ||
1841 | goto exit_dput; | ||
1842 | /* | ||
1843 | * This is subtle. Instead of calling do_follow_link() we do | ||
1844 | * the thing by hands. The reason is that this way we have zero | ||
1845 | * link_count and path_walk() (called from ->follow_link) | ||
1846 | * honoring LOOKUP_PARENT. After that we have the parent and | ||
1847 | * last component, i.e. we are in the same situation as after | ||
1848 | * the first path_walk(). Well, almost - if the last component | ||
1849 | * is normal we get its copy stored in nd->last.name and we will | ||
1850 | * have to putname() it when we are done. Procfs-like symlinks | ||
1851 | * just set LAST_BIND. | ||
1852 | */ | ||
1853 | nd.flags |= LOOKUP_PARENT; | ||
1854 | error = security_inode_follow_link(path.dentry, &nd); | ||
1855 | if (error) | ||
1856 | goto exit_dput; | ||
1857 | error = __do_follow_link(&path, &nd, &cookie); | ||
1858 | if (unlikely(error)) { | ||
1859 | /* nd.path had been dropped */ | ||
1860 | if (!IS_ERR(cookie) && inode->i_op->put_link) | ||
1861 | inode->i_op->put_link(path.dentry, &nd, cookie); | ||
1862 | path_put(&path); | ||
1863 | release_open_intent(&nd); | ||
1810 | filp = ERR_PTR(error); | 1864 | filp = ERR_PTR(error); |
1865 | goto out; | ||
1811 | } | 1866 | } |
1867 | holder = path; | ||
1868 | nd.flags &= ~LOOKUP_PARENT; | ||
1869 | filp = do_last(&nd, &path, open_flag, acc_mode, mode, pathname, &want_dir); | ||
1870 | if (inode->i_op->put_link) | ||
1871 | inode->i_op->put_link(holder.dentry, &nd, cookie); | ||
1872 | path_put(&holder); | ||
1812 | } | 1873 | } |
1813 | if (!IS_ERR(filp)) { | 1874 | out: |
1814 | if (will_truncate) { | ||
1815 | error = handle_truncate(&nd.path); | ||
1816 | if (error) { | ||
1817 | fput(filp); | ||
1818 | filp = ERR_PTR(error); | ||
1819 | } | ||
1820 | } | ||
1821 | } | ||
1822 | /* | ||
1823 | * It is now safe to drop the mnt write | ||
1824 | * because the filp has had a write taken | ||
1825 | * on its behalf. | ||
1826 | */ | ||
1827 | if (will_truncate) | ||
1828 | mnt_drop_write(nd.path.mnt); | ||
1829 | if (nd.root.mnt) | 1875 | if (nd.root.mnt) |
1830 | path_put(&nd.root); | 1876 | path_put(&nd.root); |
1877 | if (filp == ERR_PTR(-ESTALE) && !force_reval) { | ||
1878 | force_reval = 1; | ||
1879 | goto reval; | ||
1880 | } | ||
1831 | return filp; | 1881 | return filp; |
1832 | 1882 | ||
1833 | exit_mutex_unlock: | ||
1834 | mutex_unlock(&dir->d_inode->i_mutex); | ||
1835 | exit_dput: | 1883 | exit_dput: |
1836 | path_put_conditional(&path, &nd); | 1884 | path_put_conditional(&path, &nd); |
1837 | exit: | ||
1838 | if (!IS_ERR(nd.intent.open.file)) | 1885 | if (!IS_ERR(nd.intent.open.file)) |
1839 | release_open_intent(&nd); | 1886 | release_open_intent(&nd); |
1840 | exit_parent: | 1887 | exit_parent: |
1841 | if (nd.root.mnt) | ||
1842 | path_put(&nd.root); | ||
1843 | path_put(&nd.path); | 1888 | path_put(&nd.path); |
1844 | return ERR_PTR(error); | 1889 | filp = ERR_PTR(error); |
1845 | 1890 | goto out; | |
1846 | do_link: | ||
1847 | error = -ELOOP; | ||
1848 | if (flag & O_NOFOLLOW) | ||
1849 | goto exit_dput; | ||
1850 | /* | ||
1851 | * This is subtle. Instead of calling do_follow_link() we do the | ||
1852 | * thing by hands. The reason is that this way we have zero link_count | ||
1853 | * and path_walk() (called from ->follow_link) honoring LOOKUP_PARENT. | ||
1854 | * After that we have the parent and last component, i.e. | ||
1855 | * we are in the same situation as after the first path_walk(). | ||
1856 | * Well, almost - if the last component is normal we get its copy | ||
1857 | * stored in nd->last.name and we will have to putname() it when we | ||
1858 | * are done. Procfs-like symlinks just set LAST_BIND. | ||
1859 | */ | ||
1860 | nd.flags |= LOOKUP_PARENT; | ||
1861 | error = security_inode_follow_link(path.dentry, &nd); | ||
1862 | if (error) | ||
1863 | goto exit_dput; | ||
1864 | error = __do_follow_link(&path, &nd); | ||
1865 | path_put(&path); | ||
1866 | if (error) { | ||
1867 | /* Does someone understand code flow here? Or it is only | ||
1868 | * me so stupid? Anathema to whoever designed this non-sense | ||
1869 | * with "intent.open". | ||
1870 | */ | ||
1871 | release_open_intent(&nd); | ||
1872 | if (nd.root.mnt) | ||
1873 | path_put(&nd.root); | ||
1874 | if (error == -ESTALE && !force_reval) { | ||
1875 | force_reval = 1; | ||
1876 | goto reval; | ||
1877 | } | ||
1878 | return ERR_PTR(error); | ||
1879 | } | ||
1880 | nd.flags &= ~LOOKUP_PARENT; | ||
1881 | if (nd.last_type == LAST_BIND) | ||
1882 | goto ok; | ||
1883 | error = -EISDIR; | ||
1884 | if (nd.last_type != LAST_NORM) | ||
1885 | goto exit; | ||
1886 | if (nd.last.name[nd.last.len]) { | ||
1887 | __putname(nd.last.name); | ||
1888 | goto exit; | ||
1889 | } | ||
1890 | error = -ELOOP; | ||
1891 | if (count++==32) { | ||
1892 | __putname(nd.last.name); | ||
1893 | goto exit; | ||
1894 | } | ||
1895 | dir = nd.path.dentry; | ||
1896 | mutex_lock(&dir->d_inode->i_mutex); | ||
1897 | path.dentry = lookup_hash(&nd); | ||
1898 | path.mnt = nd.path.mnt; | ||
1899 | __putname(nd.last.name); | ||
1900 | goto do_last; | ||
1901 | } | 1891 | } |
1902 | 1892 | ||
1903 | /** | 1893 | /** |
@@ -2264,8 +2254,11 @@ int vfs_unlink(struct inode *dir, struct dentry *dentry) | |||
2264 | error = -EBUSY; | 2254 | error = -EBUSY; |
2265 | else { | 2255 | else { |
2266 | error = security_inode_unlink(dir, dentry); | 2256 | error = security_inode_unlink(dir, dentry); |
2267 | if (!error) | 2257 | if (!error) { |
2268 | error = dir->i_op->unlink(dir, dentry); | 2258 | error = dir->i_op->unlink(dir, dentry); |
2259 | if (!error) | ||
2260 | dentry->d_inode->i_flags |= S_DEAD; | ||
2261 | } | ||
2269 | } | 2262 | } |
2270 | mutex_unlock(&dentry->d_inode->i_mutex); | 2263 | mutex_unlock(&dentry->d_inode->i_mutex); |
2271 | 2264 | ||
@@ -2616,6 +2609,8 @@ static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, | |||
2616 | else | 2609 | else |
2617 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); | 2610 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); |
2618 | if (!error) { | 2611 | if (!error) { |
2612 | if (target) | ||
2613 | target->i_flags |= S_DEAD; | ||
2619 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) | 2614 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) |
2620 | d_move(old_dentry, new_dentry); | 2615 | d_move(old_dentry, new_dentry); |
2621 | } | 2616 | } |
@@ -2655,11 +2650,9 @@ int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2655 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); | 2650 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); |
2656 | else | 2651 | else |
2657 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry); | 2652 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry); |
2658 | if (!error) { | 2653 | if (!error) |
2659 | const char *new_name = old_dentry->d_name.name; | 2654 | fsnotify_move(old_dir, new_dir, old_name, is_dir, |
2660 | fsnotify_move(old_dir, new_dir, old_name, new_name, is_dir, | ||
2661 | new_dentry->d_inode, old_dentry); | 2655 | new_dentry->d_inode, old_dentry); |
2662 | } | ||
2663 | fsnotify_oldname_free(old_name); | 2656 | fsnotify_oldname_free(old_name); |
2664 | 2657 | ||
2665 | return error; | 2658 | return error; |
diff --git a/fs/namespace.c b/fs/namespace.c index c768f733c8d6..8174c8ab5c70 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -573,7 +573,7 @@ static struct vfsmount *clone_mnt(struct vfsmount *old, struct dentry *root, | |||
573 | mnt->mnt_master = old; | 573 | mnt->mnt_master = old; |
574 | CLEAR_MNT_SHARED(mnt); | 574 | CLEAR_MNT_SHARED(mnt); |
575 | } else if (!(flag & CL_PRIVATE)) { | 575 | } else if (!(flag & CL_PRIVATE)) { |
576 | if ((flag & CL_PROPAGATION) || IS_MNT_SHARED(old)) | 576 | if ((flag & CL_MAKE_SHARED) || IS_MNT_SHARED(old)) |
577 | list_add(&mnt->mnt_share, &old->mnt_share); | 577 | list_add(&mnt->mnt_share, &old->mnt_share); |
578 | if (IS_MNT_SLAVE(old)) | 578 | if (IS_MNT_SLAVE(old)) |
579 | list_add(&mnt->mnt_slave, &old->mnt_slave); | 579 | list_add(&mnt->mnt_slave, &old->mnt_slave); |
@@ -737,6 +737,21 @@ static void m_stop(struct seq_file *m, void *v) | |||
737 | up_read(&namespace_sem); | 737 | up_read(&namespace_sem); |
738 | } | 738 | } |
739 | 739 | ||
740 | int mnt_had_events(struct proc_mounts *p) | ||
741 | { | ||
742 | struct mnt_namespace *ns = p->ns; | ||
743 | int res = 0; | ||
744 | |||
745 | spin_lock(&vfsmount_lock); | ||
746 | if (p->event != ns->event) { | ||
747 | p->event = ns->event; | ||
748 | res = 1; | ||
749 | } | ||
750 | spin_unlock(&vfsmount_lock); | ||
751 | |||
752 | return res; | ||
753 | } | ||
754 | |||
740 | struct proc_fs_info { | 755 | struct proc_fs_info { |
741 | int flag; | 756 | int flag; |
742 | const char *str; | 757 | const char *str; |
@@ -1121,8 +1136,15 @@ SYSCALL_DEFINE2(umount, char __user *, name, int, flags) | |||
1121 | { | 1136 | { |
1122 | struct path path; | 1137 | struct path path; |
1123 | int retval; | 1138 | int retval; |
1139 | int lookup_flags = 0; | ||
1124 | 1140 | ||
1125 | retval = user_path(name, &path); | 1141 | if (flags & ~(MNT_FORCE | MNT_DETACH | MNT_EXPIRE | UMOUNT_NOFOLLOW)) |
1142 | return -EINVAL; | ||
1143 | |||
1144 | if (!(flags & UMOUNT_NOFOLLOW)) | ||
1145 | lookup_flags |= LOOKUP_FOLLOW; | ||
1146 | |||
1147 | retval = user_path_at(AT_FDCWD, name, lookup_flags, &path); | ||
1126 | if (retval) | 1148 | if (retval) |
1127 | goto out; | 1149 | goto out; |
1128 | retval = -EINVAL; | 1150 | retval = -EINVAL; |
@@ -1246,6 +1268,21 @@ void drop_collected_mounts(struct vfsmount *mnt) | |||
1246 | release_mounts(&umount_list); | 1268 | release_mounts(&umount_list); |
1247 | } | 1269 | } |
1248 | 1270 | ||
1271 | int iterate_mounts(int (*f)(struct vfsmount *, void *), void *arg, | ||
1272 | struct vfsmount *root) | ||
1273 | { | ||
1274 | struct vfsmount *mnt; | ||
1275 | int res = f(root, arg); | ||
1276 | if (res) | ||
1277 | return res; | ||
1278 | list_for_each_entry(mnt, &root->mnt_list, mnt_list) { | ||
1279 | res = f(mnt, arg); | ||
1280 | if (res) | ||
1281 | return res; | ||
1282 | } | ||
1283 | return 0; | ||
1284 | } | ||
1285 | |||
1249 | static void cleanup_group_ids(struct vfsmount *mnt, struct vfsmount *end) | 1286 | static void cleanup_group_ids(struct vfsmount *mnt, struct vfsmount *end) |
1250 | { | 1287 | { |
1251 | struct vfsmount *p; | 1288 | struct vfsmount *p; |
@@ -1538,7 +1575,7 @@ static int do_remount(struct path *path, int flags, int mnt_flags, | |||
1538 | err = do_remount_sb(sb, flags, data, 0); | 1575 | err = do_remount_sb(sb, flags, data, 0); |
1539 | if (!err) { | 1576 | if (!err) { |
1540 | spin_lock(&vfsmount_lock); | 1577 | spin_lock(&vfsmount_lock); |
1541 | mnt_flags |= path->mnt->mnt_flags & MNT_PNODE_MASK; | 1578 | mnt_flags |= path->mnt->mnt_flags & MNT_PROPAGATION_MASK; |
1542 | path->mnt->mnt_flags = mnt_flags; | 1579 | path->mnt->mnt_flags = mnt_flags; |
1543 | spin_unlock(&vfsmount_lock); | 1580 | spin_unlock(&vfsmount_lock); |
1544 | } | 1581 | } |
@@ -1671,7 +1708,7 @@ int do_add_mount(struct vfsmount *newmnt, struct path *path, | |||
1671 | { | 1708 | { |
1672 | int err; | 1709 | int err; |
1673 | 1710 | ||
1674 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD); | 1711 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD | MNT_INTERNAL); |
1675 | 1712 | ||
1676 | down_write(&namespace_sem); | 1713 | down_write(&namespace_sem); |
1677 | /* Something was mounted here while we slept */ | 1714 | /* Something was mounted here while we slept */ |
@@ -2314,17 +2351,13 @@ void __init mnt_init(void) | |||
2314 | 2351 | ||
2315 | void put_mnt_ns(struct mnt_namespace *ns) | 2352 | void put_mnt_ns(struct mnt_namespace *ns) |
2316 | { | 2353 | { |
2317 | struct vfsmount *root; | ||
2318 | LIST_HEAD(umount_list); | 2354 | LIST_HEAD(umount_list); |
2319 | 2355 | ||
2320 | if (!atomic_dec_and_lock(&ns->count, &vfsmount_lock)) | 2356 | if (!atomic_dec_and_test(&ns->count)) |
2321 | return; | 2357 | return; |
2322 | root = ns->root; | ||
2323 | ns->root = NULL; | ||
2324 | spin_unlock(&vfsmount_lock); | ||
2325 | down_write(&namespace_sem); | 2358 | down_write(&namespace_sem); |
2326 | spin_lock(&vfsmount_lock); | 2359 | spin_lock(&vfsmount_lock); |
2327 | umount_tree(root, 0, &umount_list); | 2360 | umount_tree(ns->root, 0, &umount_list); |
2328 | spin_unlock(&vfsmount_lock); | 2361 | spin_unlock(&vfsmount_lock); |
2329 | up_write(&namespace_sem); | 2362 | up_write(&namespace_sem); |
2330 | release_mounts(&umount_list); | 2363 | release_mounts(&umount_list); |
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index f141bde7756a..7f9ecc46f3fb 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c | |||
@@ -97,16 +97,12 @@ u64 nfs_compat_user_ino64(u64 fileid) | |||
97 | return ino; | 97 | return ino; |
98 | } | 98 | } |
99 | 99 | ||
100 | int nfs_write_inode(struct inode *inode, int sync) | 100 | int nfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
101 | { | 101 | { |
102 | int ret; | 102 | int ret; |
103 | 103 | ||
104 | if (sync) { | 104 | ret = nfs_commit_inode(inode, |
105 | ret = filemap_fdatawait(inode->i_mapping); | 105 | wbc->sync_mode == WB_SYNC_ALL ? FLUSH_SYNC : 0); |
106 | if (ret == 0) | ||
107 | ret = nfs_commit_inode(inode, FLUSH_SYNC); | ||
108 | } else | ||
109 | ret = nfs_commit_inode(inode, 0); | ||
110 | if (ret >= 0) | 106 | if (ret >= 0) |
111 | return 0; | 107 | return 0; |
112 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); | 108 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); |
@@ -574,14 +570,14 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) | |||
574 | nfs_revalidate_inode(server, inode); | 570 | nfs_revalidate_inode(server, inode); |
575 | } | 571 | } |
576 | 572 | ||
577 | static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, struct dentry *dentry, struct rpc_cred *cred) | 573 | static struct nfs_open_context *alloc_nfs_open_context(struct path *path, struct rpc_cred *cred) |
578 | { | 574 | { |
579 | struct nfs_open_context *ctx; | 575 | struct nfs_open_context *ctx; |
580 | 576 | ||
581 | ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); | 577 | ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); |
582 | if (ctx != NULL) { | 578 | if (ctx != NULL) { |
583 | ctx->path.dentry = dget(dentry); | 579 | ctx->path = *path; |
584 | ctx->path.mnt = mntget(mnt); | 580 | path_get(&ctx->path); |
585 | ctx->cred = get_rpccred(cred); | 581 | ctx->cred = get_rpccred(cred); |
586 | ctx->state = NULL; | 582 | ctx->state = NULL; |
587 | ctx->lockowner = current->files; | 583 | ctx->lockowner = current->files; |
@@ -686,7 +682,7 @@ int nfs_open(struct inode *inode, struct file *filp) | |||
686 | cred = rpc_lookup_cred(); | 682 | cred = rpc_lookup_cred(); |
687 | if (IS_ERR(cred)) | 683 | if (IS_ERR(cred)) |
688 | return PTR_ERR(cred); | 684 | return PTR_ERR(cred); |
689 | ctx = alloc_nfs_open_context(filp->f_path.mnt, filp->f_path.dentry, cred); | 685 | ctx = alloc_nfs_open_context(&filp->f_path, cred); |
690 | put_rpccred(cred); | 686 | put_rpccred(cred); |
691 | if (ctx == NULL) | 687 | if (ctx == NULL) |
692 | return -ENOMEM; | 688 | return -ENOMEM; |
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 29e464d23b32..11f82f03c5de 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h | |||
@@ -211,7 +211,7 @@ extern int nfs_access_cache_shrinker(int nr_to_scan, gfp_t gfp_mask); | |||
211 | extern struct workqueue_struct *nfsiod_workqueue; | 211 | extern struct workqueue_struct *nfsiod_workqueue; |
212 | extern struct inode *nfs_alloc_inode(struct super_block *sb); | 212 | extern struct inode *nfs_alloc_inode(struct super_block *sb); |
213 | extern void nfs_destroy_inode(struct inode *); | 213 | extern void nfs_destroy_inode(struct inode *); |
214 | extern int nfs_write_inode(struct inode *,int); | 214 | extern int nfs_write_inode(struct inode *, struct writeback_control *); |
215 | extern void nfs_clear_inode(struct inode *); | 215 | extern void nfs_clear_inode(struct inode *); |
216 | #ifdef CONFIG_NFS_V4 | 216 | #ifdef CONFIG_NFS_V4 |
217 | extern void nfs4_clear_inode(struct inode *); | 217 | extern void nfs4_clear_inode(struct inode *); |
diff --git a/fs/nfs/iostat.h b/fs/nfs/iostat.h index 46d779abafd3..1d8d5c813b01 100644 --- a/fs/nfs/iostat.h +++ b/fs/nfs/iostat.h | |||
@@ -57,12 +57,12 @@ static inline void nfs_add_fscache_stats(struct inode *inode, | |||
57 | } | 57 | } |
58 | #endif | 58 | #endif |
59 | 59 | ||
60 | static inline struct nfs_iostats *nfs_alloc_iostats(void) | 60 | static inline struct nfs_iostats __percpu *nfs_alloc_iostats(void) |
61 | { | 61 | { |
62 | return alloc_percpu(struct nfs_iostats); | 62 | return alloc_percpu(struct nfs_iostats); |
63 | } | 63 | } |
64 | 64 | ||
65 | static inline void nfs_free_iostats(struct nfs_iostats *stats) | 65 | static inline void nfs_free_iostats(struct nfs_iostats __percpu *stats) |
66 | { | 66 | { |
67 | if (stats != NULL) | 67 | if (stats != NULL) |
68 | free_percpu(stats); | 68 | free_percpu(stats); |
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 375f0fae2c6a..84d83be25a98 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -724,8 +724,8 @@ static struct nfs4_opendata *nfs4_opendata_alloc(struct path *path, | |||
724 | p->o_arg.seqid = nfs_alloc_seqid(&sp->so_seqid); | 724 | p->o_arg.seqid = nfs_alloc_seqid(&sp->so_seqid); |
725 | if (p->o_arg.seqid == NULL) | 725 | if (p->o_arg.seqid == NULL) |
726 | goto err_free; | 726 | goto err_free; |
727 | p->path.mnt = mntget(path->mnt); | 727 | path_get(path); |
728 | p->path.dentry = dget(path->dentry); | 728 | p->path = *path; |
729 | p->dir = parent; | 729 | p->dir = parent; |
730 | p->owner = sp; | 730 | p->owner = sp; |
731 | atomic_inc(&sp->so_count); | 731 | atomic_inc(&sp->so_count); |
@@ -1944,8 +1944,8 @@ int nfs4_do_close(struct path *path, struct nfs4_state *state, int wait) | |||
1944 | calldata->res.seqid = calldata->arg.seqid; | 1944 | calldata->res.seqid = calldata->arg.seqid; |
1945 | calldata->res.server = server; | 1945 | calldata->res.server = server; |
1946 | calldata->res.seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; | 1946 | calldata->res.seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; |
1947 | calldata->path.mnt = mntget(path->mnt); | 1947 | path_get(path); |
1948 | calldata->path.dentry = dget(path->dentry); | 1948 | calldata->path = *path; |
1949 | 1949 | ||
1950 | msg.rpc_argp = &calldata->arg, | 1950 | msg.rpc_argp = &calldata->arg, |
1951 | msg.rpc_resp = &calldata->res, | 1951 | msg.rpc_resp = &calldata->res, |
diff --git a/fs/nfsctl.c b/fs/nfsctl.c index d3854d94b7cf..bf9cbd242ddd 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c | |||
@@ -36,10 +36,9 @@ static struct file *do_open(char *name, int flags) | |||
36 | return ERR_PTR(error); | 36 | return ERR_PTR(error); |
37 | 37 | ||
38 | if (flags == O_RDWR) | 38 | if (flags == O_RDWR) |
39 | error = may_open(&nd.path, MAY_READ|MAY_WRITE, | 39 | error = may_open(&nd.path, MAY_READ|MAY_WRITE, flags); |
40 | FMODE_READ|FMODE_WRITE); | ||
41 | else | 40 | else |
42 | error = may_open(&nd.path, MAY_WRITE, FMODE_WRITE); | 41 | error = may_open(&nd.path, MAY_WRITE, flags); |
43 | 42 | ||
44 | if (!error) | 43 | if (!error) |
45 | return dentry_open(nd.path.dentry, nd.path.mnt, flags, | 44 | return dentry_open(nd.path.dentry, nd.path.mnt, flags, |
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index a8587e90fd5a..bbf72d8f9fc0 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c | |||
@@ -2121,9 +2121,15 @@ out_acl: | |||
2121 | * and this is the root of a cross-mounted filesystem. | 2121 | * and this is the root of a cross-mounted filesystem. |
2122 | */ | 2122 | */ |
2123 | if (ignore_crossmnt == 0 && | 2123 | if (ignore_crossmnt == 0 && |
2124 | exp->ex_path.mnt->mnt_root->d_inode == dentry->d_inode) { | 2124 | dentry == exp->ex_path.mnt->mnt_root) { |
2125 | err = vfs_getattr(exp->ex_path.mnt->mnt_parent, | 2125 | struct path path = exp->ex_path; |
2126 | exp->ex_path.mnt->mnt_mountpoint, &stat); | 2126 | path_get(&path); |
2127 | while (follow_up(&path)) { | ||
2128 | if (path.dentry != path.mnt->mnt_root) | ||
2129 | break; | ||
2130 | } | ||
2131 | err = vfs_getattr(path.mnt, path.dentry, &stat); | ||
2132 | path_put(&path); | ||
2127 | if (err) | 2133 | if (err) |
2128 | goto out_nfserr; | 2134 | goto out_nfserr; |
2129 | } | 2135 | } |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 09e9fc043600..8eca17df4f63 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -360,7 +360,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, | |||
360 | * If we are changing the size of the file, then | 360 | * If we are changing the size of the file, then |
361 | * we need to break all leases. | 361 | * we need to break all leases. |
362 | */ | 362 | */ |
363 | host_err = break_lease(inode, FMODE_WRITE | O_NONBLOCK); | 363 | host_err = break_lease(inode, O_WRONLY | O_NONBLOCK); |
364 | if (host_err == -EWOULDBLOCK) | 364 | if (host_err == -EWOULDBLOCK) |
365 | host_err = -ETIMEDOUT; | 365 | host_err = -ETIMEDOUT; |
366 | if (host_err) /* ENOMEM or EWOULDBLOCK */ | 366 | if (host_err) /* ENOMEM or EWOULDBLOCK */ |
@@ -732,7 +732,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, | |||
732 | * Check to see if there are any leases on this file. | 732 | * Check to see if there are any leases on this file. |
733 | * This may block while leases are broken. | 733 | * This may block while leases are broken. |
734 | */ | 734 | */ |
735 | host_err = break_lease(inode, O_NONBLOCK | ((access & NFSD_MAY_WRITE) ? FMODE_WRITE : 0)); | 735 | host_err = break_lease(inode, O_NONBLOCK | ((access & NFSD_MAY_WRITE) ? O_WRONLY : 0)); |
736 | if (host_err == -EWOULDBLOCK) | 736 | if (host_err == -EWOULDBLOCK) |
737 | host_err = -ETIMEDOUT; | 737 | host_err = -ETIMEDOUT; |
738 | if (host_err) /* NOMEM or WOULDBLOCK */ | 738 | if (host_err) /* NOMEM or WOULDBLOCK */ |
diff --git a/fs/nilfs2/dat.c b/fs/nilfs2/dat.c index 187dd07ba86c..9d1e5de91afb 100644 --- a/fs/nilfs2/dat.c +++ b/fs/nilfs2/dat.c | |||
@@ -388,8 +388,7 @@ int nilfs_dat_translate(struct inode *dat, __u64 vblocknr, sector_t *blocknrp) | |||
388 | ret = -ENOENT; | 388 | ret = -ENOENT; |
389 | goto out; | 389 | goto out; |
390 | } | 390 | } |
391 | if (blocknrp != NULL) | 391 | *blocknrp = blocknr; |
392 | *blocknrp = blocknr; | ||
393 | 392 | ||
394 | out: | 393 | out: |
395 | kunmap_atomic(kaddr, KM_USER0); | 394 | kunmap_atomic(kaddr, KM_USER0); |
diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index 76d803e060a9..0092840492ee 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c | |||
@@ -224,7 +224,7 @@ fail: | |||
224 | * len <= NILFS_NAME_LEN and de != NULL are guaranteed by caller. | 224 | * len <= NILFS_NAME_LEN and de != NULL are guaranteed by caller. |
225 | */ | 225 | */ |
226 | static int | 226 | static int |
227 | nilfs_match(int len, const char * const name, struct nilfs_dir_entry *de) | 227 | nilfs_match(int len, const unsigned char *name, struct nilfs_dir_entry *de) |
228 | { | 228 | { |
229 | if (len != de->name_len) | 229 | if (len != de->name_len) |
230 | return 0; | 230 | return 0; |
@@ -349,11 +349,11 @@ done: | |||
349 | * Entry is guaranteed to be valid. | 349 | * Entry is guaranteed to be valid. |
350 | */ | 350 | */ |
351 | struct nilfs_dir_entry * | 351 | struct nilfs_dir_entry * |
352 | nilfs_find_entry(struct inode *dir, struct dentry *dentry, | 352 | nilfs_find_entry(struct inode *dir, const struct qstr *qstr, |
353 | struct page **res_page) | 353 | struct page **res_page) |
354 | { | 354 | { |
355 | const char *name = dentry->d_name.name; | 355 | const unsigned char *name = qstr->name; |
356 | int namelen = dentry->d_name.len; | 356 | int namelen = qstr->len; |
357 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); | 357 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); |
358 | unsigned long start, n; | 358 | unsigned long start, n; |
359 | unsigned long npages = dir_pages(dir); | 359 | unsigned long npages = dir_pages(dir); |
@@ -424,13 +424,13 @@ struct nilfs_dir_entry *nilfs_dotdot(struct inode *dir, struct page **p) | |||
424 | return de; | 424 | return de; |
425 | } | 425 | } |
426 | 426 | ||
427 | ino_t nilfs_inode_by_name(struct inode *dir, struct dentry *dentry) | 427 | ino_t nilfs_inode_by_name(struct inode *dir, const struct qstr *qstr) |
428 | { | 428 | { |
429 | ino_t res = 0; | 429 | ino_t res = 0; |
430 | struct nilfs_dir_entry *de; | 430 | struct nilfs_dir_entry *de; |
431 | struct page *page; | 431 | struct page *page; |
432 | 432 | ||
433 | de = nilfs_find_entry(dir, dentry, &page); | 433 | de = nilfs_find_entry(dir, qstr, &page); |
434 | if (de) { | 434 | if (de) { |
435 | res = le64_to_cpu(de->inode); | 435 | res = le64_to_cpu(de->inode); |
436 | kunmap(page); | 436 | kunmap(page); |
@@ -465,7 +465,7 @@ void nilfs_set_link(struct inode *dir, struct nilfs_dir_entry *de, | |||
465 | int nilfs_add_link(struct dentry *dentry, struct inode *inode) | 465 | int nilfs_add_link(struct dentry *dentry, struct inode *inode) |
466 | { | 466 | { |
467 | struct inode *dir = dentry->d_parent->d_inode; | 467 | struct inode *dir = dentry->d_parent->d_inode; |
468 | const char *name = dentry->d_name.name; | 468 | const unsigned char *name = dentry->d_name.name; |
469 | int namelen = dentry->d_name.len; | 469 | int namelen = dentry->d_name.len; |
470 | unsigned chunk_size = nilfs_chunk_size(dir); | 470 | unsigned chunk_size = nilfs_chunk_size(dir); |
471 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); | 471 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); |
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index d6b2b83de363..313d0a21da48 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <linux/capability.h> /* capable() */ | 26 | #include <linux/capability.h> /* capable() */ |
27 | #include <linux/uaccess.h> /* copy_from_user(), copy_to_user() */ | 27 | #include <linux/uaccess.h> /* copy_from_user(), copy_to_user() */ |
28 | #include <linux/vmalloc.h> | 28 | #include <linux/vmalloc.h> |
29 | #include <linux/mount.h> /* mnt_want_write(), mnt_drop_write() */ | ||
29 | #include <linux/nilfs2_fs.h> | 30 | #include <linux/nilfs2_fs.h> |
30 | #include "nilfs.h" | 31 | #include "nilfs.h" |
31 | #include "segment.h" | 32 | #include "segment.h" |
@@ -107,20 +108,28 @@ static int nilfs_ioctl_change_cpmode(struct inode *inode, struct file *filp, | |||
107 | 108 | ||
108 | if (!capable(CAP_SYS_ADMIN)) | 109 | if (!capable(CAP_SYS_ADMIN)) |
109 | return -EPERM; | 110 | return -EPERM; |
111 | |||
112 | ret = mnt_want_write(filp->f_path.mnt); | ||
113 | if (ret) | ||
114 | return ret; | ||
115 | |||
116 | ret = -EFAULT; | ||
110 | if (copy_from_user(&cpmode, argp, sizeof(cpmode))) | 117 | if (copy_from_user(&cpmode, argp, sizeof(cpmode))) |
111 | return -EFAULT; | 118 | goto out; |
112 | 119 | ||
113 | mutex_lock(&nilfs->ns_mount_mutex); | 120 | mutex_lock(&nilfs->ns_mount_mutex); |
121 | |||
114 | nilfs_transaction_begin(inode->i_sb, &ti, 0); | 122 | nilfs_transaction_begin(inode->i_sb, &ti, 0); |
115 | ret = nilfs_cpfile_change_cpmode( | 123 | ret = nilfs_cpfile_change_cpmode( |
116 | cpfile, cpmode.cm_cno, cpmode.cm_mode); | 124 | cpfile, cpmode.cm_cno, cpmode.cm_mode); |
117 | if (unlikely(ret < 0)) { | 125 | if (unlikely(ret < 0)) |
118 | nilfs_transaction_abort(inode->i_sb); | 126 | nilfs_transaction_abort(inode->i_sb); |
119 | mutex_unlock(&nilfs->ns_mount_mutex); | 127 | else |
120 | return ret; | 128 | nilfs_transaction_commit(inode->i_sb); /* never fails */ |
121 | } | 129 | |
122 | nilfs_transaction_commit(inode->i_sb); /* never fails */ | ||
123 | mutex_unlock(&nilfs->ns_mount_mutex); | 130 | mutex_unlock(&nilfs->ns_mount_mutex); |
131 | out: | ||
132 | mnt_drop_write(filp->f_path.mnt); | ||
124 | return ret; | 133 | return ret; |
125 | } | 134 | } |
126 | 135 | ||
@@ -135,16 +144,23 @@ nilfs_ioctl_delete_checkpoint(struct inode *inode, struct file *filp, | |||
135 | 144 | ||
136 | if (!capable(CAP_SYS_ADMIN)) | 145 | if (!capable(CAP_SYS_ADMIN)) |
137 | return -EPERM; | 146 | return -EPERM; |
147 | |||
148 | ret = mnt_want_write(filp->f_path.mnt); | ||
149 | if (ret) | ||
150 | return ret; | ||
151 | |||
152 | ret = -EFAULT; | ||
138 | if (copy_from_user(&cno, argp, sizeof(cno))) | 153 | if (copy_from_user(&cno, argp, sizeof(cno))) |
139 | return -EFAULT; | 154 | goto out; |
140 | 155 | ||
141 | nilfs_transaction_begin(inode->i_sb, &ti, 0); | 156 | nilfs_transaction_begin(inode->i_sb, &ti, 0); |
142 | ret = nilfs_cpfile_delete_checkpoint(cpfile, cno); | 157 | ret = nilfs_cpfile_delete_checkpoint(cpfile, cno); |
143 | if (unlikely(ret < 0)) { | 158 | if (unlikely(ret < 0)) |
144 | nilfs_transaction_abort(inode->i_sb); | 159 | nilfs_transaction_abort(inode->i_sb); |
145 | return ret; | 160 | else |
146 | } | 161 | nilfs_transaction_commit(inode->i_sb); /* never fails */ |
147 | nilfs_transaction_commit(inode->i_sb); /* never fails */ | 162 | out: |
163 | mnt_drop_write(filp->f_path.mnt); | ||
148 | return ret; | 164 | return ret; |
149 | } | 165 | } |
150 | 166 | ||
@@ -496,12 +512,19 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
496 | if (!capable(CAP_SYS_ADMIN)) | 512 | if (!capable(CAP_SYS_ADMIN)) |
497 | return -EPERM; | 513 | return -EPERM; |
498 | 514 | ||
515 | ret = mnt_want_write(filp->f_path.mnt); | ||
516 | if (ret) | ||
517 | return ret; | ||
518 | |||
519 | ret = -EFAULT; | ||
499 | if (copy_from_user(argv, argp, sizeof(argv))) | 520 | if (copy_from_user(argv, argp, sizeof(argv))) |
500 | return -EFAULT; | 521 | goto out; |
501 | 522 | ||
523 | ret = -EINVAL; | ||
502 | nsegs = argv[4].v_nmembs; | 524 | nsegs = argv[4].v_nmembs; |
503 | if (argv[4].v_size != argsz[4]) | 525 | if (argv[4].v_size != argsz[4]) |
504 | return -EINVAL; | 526 | goto out; |
527 | |||
505 | /* | 528 | /* |
506 | * argv[4] points to segment numbers this ioctl cleans. We | 529 | * argv[4] points to segment numbers this ioctl cleans. We |
507 | * use kmalloc() for its buffer because memory used for the | 530 | * use kmalloc() for its buffer because memory used for the |
@@ -509,9 +532,10 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
509 | */ | 532 | */ |
510 | kbufs[4] = memdup_user((void __user *)(unsigned long)argv[4].v_base, | 533 | kbufs[4] = memdup_user((void __user *)(unsigned long)argv[4].v_base, |
511 | nsegs * sizeof(__u64)); | 534 | nsegs * sizeof(__u64)); |
512 | if (IS_ERR(kbufs[4])) | 535 | if (IS_ERR(kbufs[4])) { |
513 | return PTR_ERR(kbufs[4]); | 536 | ret = PTR_ERR(kbufs[4]); |
514 | 537 | goto out; | |
538 | } | ||
515 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; | 539 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; |
516 | 540 | ||
517 | for (n = 0; n < 4; n++) { | 541 | for (n = 0; n < 4; n++) { |
@@ -563,10 +587,12 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
563 | nilfs_remove_all_gcinode(nilfs); | 587 | nilfs_remove_all_gcinode(nilfs); |
564 | clear_nilfs_gc_running(nilfs); | 588 | clear_nilfs_gc_running(nilfs); |
565 | 589 | ||
566 | out_free: | 590 | out_free: |
567 | while (--n >= 0) | 591 | while (--n >= 0) |
568 | vfree(kbufs[n]); | 592 | vfree(kbufs[n]); |
569 | kfree(kbufs[4]); | 593 | kfree(kbufs[4]); |
594 | out: | ||
595 | mnt_drop_write(filp->f_path.mnt); | ||
570 | return ret; | 596 | return ret; |
571 | } | 597 | } |
572 | 598 | ||
@@ -575,13 +601,17 @@ static int nilfs_ioctl_sync(struct inode *inode, struct file *filp, | |||
575 | { | 601 | { |
576 | __u64 cno; | 602 | __u64 cno; |
577 | int ret; | 603 | int ret; |
604 | struct the_nilfs *nilfs; | ||
578 | 605 | ||
579 | ret = nilfs_construct_segment(inode->i_sb); | 606 | ret = nilfs_construct_segment(inode->i_sb); |
580 | if (ret < 0) | 607 | if (ret < 0) |
581 | return ret; | 608 | return ret; |
582 | 609 | ||
583 | if (argp != NULL) { | 610 | if (argp != NULL) { |
584 | cno = NILFS_SB(inode->i_sb)->s_nilfs->ns_cno - 1; | 611 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; |
612 | down_read(&nilfs->ns_segctor_sem); | ||
613 | cno = nilfs->ns_cno - 1; | ||
614 | up_read(&nilfs->ns_segctor_sem); | ||
585 | if (copy_to_user(argp, &cno, sizeof(cno))) | 615 | if (copy_to_user(argp, &cno, sizeof(cno))) |
586 | return -EFAULT; | 616 | return -EFAULT; |
587 | } | 617 | } |
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 07ba838ef089..ad6ed2cf19b4 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c | |||
@@ -67,7 +67,7 @@ nilfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | |||
67 | if (dentry->d_name.len > NILFS_NAME_LEN) | 67 | if (dentry->d_name.len > NILFS_NAME_LEN) |
68 | return ERR_PTR(-ENAMETOOLONG); | 68 | return ERR_PTR(-ENAMETOOLONG); |
69 | 69 | ||
70 | ino = nilfs_inode_by_name(dir, dentry); | 70 | ino = nilfs_inode_by_name(dir, &dentry->d_name); |
71 | inode = NULL; | 71 | inode = NULL; |
72 | if (ino) { | 72 | if (ino) { |
73 | inode = nilfs_iget(dir->i_sb, ino); | 73 | inode = nilfs_iget(dir->i_sb, ino); |
@@ -81,10 +81,7 @@ struct dentry *nilfs_get_parent(struct dentry *child) | |||
81 | { | 81 | { |
82 | unsigned long ino; | 82 | unsigned long ino; |
83 | struct inode *inode; | 83 | struct inode *inode; |
84 | struct dentry dotdot; | 84 | struct qstr dotdot = {.name = "..", .len = 2}; |
85 | |||
86 | dotdot.d_name.name = ".."; | ||
87 | dotdot.d_name.len = 2; | ||
88 | 85 | ||
89 | ino = nilfs_inode_by_name(child->d_inode, &dotdot); | 86 | ino = nilfs_inode_by_name(child->d_inode, &dotdot); |
90 | if (!ino) | 87 | if (!ino) |
@@ -296,7 +293,7 @@ static int nilfs_do_unlink(struct inode *dir, struct dentry *dentry) | |||
296 | int err; | 293 | int err; |
297 | 294 | ||
298 | err = -ENOENT; | 295 | err = -ENOENT; |
299 | de = nilfs_find_entry(dir, dentry, &page); | 296 | de = nilfs_find_entry(dir, &dentry->d_name, &page); |
300 | if (!de) | 297 | if (!de) |
301 | goto out; | 298 | goto out; |
302 | 299 | ||
@@ -389,7 +386,7 @@ static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
389 | return err; | 386 | return err; |
390 | 387 | ||
391 | err = -ENOENT; | 388 | err = -ENOENT; |
392 | old_de = nilfs_find_entry(old_dir, old_dentry, &old_page); | 389 | old_de = nilfs_find_entry(old_dir, &old_dentry->d_name, &old_page); |
393 | if (!old_de) | 390 | if (!old_de) |
394 | goto out; | 391 | goto out; |
395 | 392 | ||
@@ -409,7 +406,7 @@ static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
409 | goto out_dir; | 406 | goto out_dir; |
410 | 407 | ||
411 | err = -ENOENT; | 408 | err = -ENOENT; |
412 | new_de = nilfs_find_entry(new_dir, new_dentry, &new_page); | 409 | new_de = nilfs_find_entry(new_dir, &new_dentry->d_name, &new_page); |
413 | if (!new_de) | 410 | if (!new_de) |
414 | goto out_dir; | 411 | goto out_dir; |
415 | inc_nlink(old_inode); | 412 | inc_nlink(old_inode); |
diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h index 4da6f67e9a91..8723e5bfd071 100644 --- a/fs/nilfs2/nilfs.h +++ b/fs/nilfs2/nilfs.h | |||
@@ -217,10 +217,10 @@ static inline int nilfs_init_acl(struct inode *inode, struct inode *dir) | |||
217 | 217 | ||
218 | /* dir.c */ | 218 | /* dir.c */ |
219 | extern int nilfs_add_link(struct dentry *, struct inode *); | 219 | extern int nilfs_add_link(struct dentry *, struct inode *); |
220 | extern ino_t nilfs_inode_by_name(struct inode *, struct dentry *); | 220 | extern ino_t nilfs_inode_by_name(struct inode *, const struct qstr *); |
221 | extern int nilfs_make_empty(struct inode *, struct inode *); | 221 | extern int nilfs_make_empty(struct inode *, struct inode *); |
222 | extern struct nilfs_dir_entry * | 222 | extern struct nilfs_dir_entry * |
223 | nilfs_find_entry(struct inode *, struct dentry *, struct page **); | 223 | nilfs_find_entry(struct inode *, const struct qstr *, struct page **); |
224 | extern int nilfs_delete_entry(struct nilfs_dir_entry *, struct page *); | 224 | extern int nilfs_delete_entry(struct nilfs_dir_entry *, struct page *); |
225 | extern int nilfs_empty_dir(struct inode *); | 225 | extern int nilfs_empty_dir(struct inode *); |
226 | extern struct nilfs_dir_entry *nilfs_dotdot(struct inode *, struct page **); | 226 | extern struct nilfs_dir_entry *nilfs_dotdot(struct inode *, struct page **); |
diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c index c9c96c7825dc..017bedc761a0 100644 --- a/fs/nilfs2/recovery.c +++ b/fs/nilfs2/recovery.c | |||
@@ -39,7 +39,6 @@ enum { | |||
39 | NILFS_SEG_FAIL_IO, | 39 | NILFS_SEG_FAIL_IO, |
40 | NILFS_SEG_FAIL_MAGIC, | 40 | NILFS_SEG_FAIL_MAGIC, |
41 | NILFS_SEG_FAIL_SEQ, | 41 | NILFS_SEG_FAIL_SEQ, |
42 | NILFS_SEG_FAIL_CHECKSUM_SEGSUM, | ||
43 | NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT, | 42 | NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT, |
44 | NILFS_SEG_FAIL_CHECKSUM_FULL, | 43 | NILFS_SEG_FAIL_CHECKSUM_FULL, |
45 | NILFS_SEG_FAIL_CONSISTENCY, | 44 | NILFS_SEG_FAIL_CONSISTENCY, |
@@ -71,10 +70,6 @@ static int nilfs_warn_segment_error(int err) | |||
71 | printk(KERN_WARNING | 70 | printk(KERN_WARNING |
72 | "NILFS warning: Sequence number mismatch\n"); | 71 | "NILFS warning: Sequence number mismatch\n"); |
73 | break; | 72 | break; |
74 | case NILFS_SEG_FAIL_CHECKSUM_SEGSUM: | ||
75 | printk(KERN_WARNING | ||
76 | "NILFS warning: Checksum error in segment summary\n"); | ||
77 | break; | ||
78 | case NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT: | 73 | case NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT: |
79 | printk(KERN_WARNING | 74 | printk(KERN_WARNING |
80 | "NILFS warning: Checksum error in super root\n"); | 75 | "NILFS warning: Checksum error in super root\n"); |
@@ -206,19 +201,15 @@ int nilfs_read_super_root_block(struct super_block *sb, sector_t sr_block, | |||
206 | * @pseg_start: start disk block number of partial segment | 201 | * @pseg_start: start disk block number of partial segment |
207 | * @seg_seq: sequence number requested | 202 | * @seg_seq: sequence number requested |
208 | * @ssi: pointer to nilfs_segsum_info struct to store information | 203 | * @ssi: pointer to nilfs_segsum_info struct to store information |
209 | * @full_check: full check flag | ||
210 | * (0: only checks segment summary CRC, 1: data CRC) | ||
211 | */ | 204 | */ |
212 | static int | 205 | static int |
213 | load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, | 206 | load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, |
214 | u64 seg_seq, struct nilfs_segsum_info *ssi, | 207 | u64 seg_seq, struct nilfs_segsum_info *ssi) |
215 | int full_check) | ||
216 | { | 208 | { |
217 | struct buffer_head *bh_sum; | 209 | struct buffer_head *bh_sum; |
218 | struct nilfs_segment_summary *sum; | 210 | struct nilfs_segment_summary *sum; |
219 | unsigned long offset, nblock; | 211 | unsigned long nblock; |
220 | u64 check_bytes; | 212 | u32 crc; |
221 | u32 crc, crc_sum; | ||
222 | int ret = NILFS_SEG_FAIL_IO; | 213 | int ret = NILFS_SEG_FAIL_IO; |
223 | 214 | ||
224 | bh_sum = sb_bread(sbi->s_super, pseg_start); | 215 | bh_sum = sb_bread(sbi->s_super, pseg_start); |
@@ -237,34 +228,24 @@ load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, | |||
237 | ret = NILFS_SEG_FAIL_SEQ; | 228 | ret = NILFS_SEG_FAIL_SEQ; |
238 | goto failed; | 229 | goto failed; |
239 | } | 230 | } |
240 | if (full_check) { | ||
241 | offset = sizeof(sum->ss_datasum); | ||
242 | check_bytes = | ||
243 | ((u64)ssi->nblocks << sbi->s_super->s_blocksize_bits); | ||
244 | nblock = ssi->nblocks; | ||
245 | crc_sum = le32_to_cpu(sum->ss_datasum); | ||
246 | ret = NILFS_SEG_FAIL_CHECKSUM_FULL; | ||
247 | } else { /* only checks segment summary */ | ||
248 | offset = sizeof(sum->ss_datasum) + sizeof(sum->ss_sumsum); | ||
249 | check_bytes = ssi->sumbytes; | ||
250 | nblock = ssi->nsumblk; | ||
251 | crc_sum = le32_to_cpu(sum->ss_sumsum); | ||
252 | ret = NILFS_SEG_FAIL_CHECKSUM_SEGSUM; | ||
253 | } | ||
254 | 231 | ||
232 | nblock = ssi->nblocks; | ||
255 | if (unlikely(nblock == 0 || | 233 | if (unlikely(nblock == 0 || |
256 | nblock > sbi->s_nilfs->ns_blocks_per_segment)) { | 234 | nblock > sbi->s_nilfs->ns_blocks_per_segment)) { |
257 | /* This limits the number of blocks read in the CRC check */ | 235 | /* This limits the number of blocks read in the CRC check */ |
258 | ret = NILFS_SEG_FAIL_CONSISTENCY; | 236 | ret = NILFS_SEG_FAIL_CONSISTENCY; |
259 | goto failed; | 237 | goto failed; |
260 | } | 238 | } |
261 | if (calc_crc_cont(sbi, bh_sum, &crc, offset, check_bytes, | 239 | if (calc_crc_cont(sbi, bh_sum, &crc, sizeof(sum->ss_datasum), |
240 | ((u64)nblock << sbi->s_super->s_blocksize_bits), | ||
262 | pseg_start, nblock)) { | 241 | pseg_start, nblock)) { |
263 | ret = NILFS_SEG_FAIL_IO; | 242 | ret = NILFS_SEG_FAIL_IO; |
264 | goto failed; | 243 | goto failed; |
265 | } | 244 | } |
266 | if (crc == crc_sum) | 245 | if (crc == le32_to_cpu(sum->ss_datasum)) |
267 | ret = 0; | 246 | ret = 0; |
247 | else | ||
248 | ret = NILFS_SEG_FAIL_CHECKSUM_FULL; | ||
268 | failed: | 249 | failed: |
269 | brelse(bh_sum); | 250 | brelse(bh_sum); |
270 | out: | 251 | out: |
@@ -598,7 +579,7 @@ static int nilfs_do_roll_forward(struct the_nilfs *nilfs, | |||
598 | 579 | ||
599 | while (segnum != ri->ri_segnum || pseg_start <= ri->ri_pseg_start) { | 580 | while (segnum != ri->ri_segnum || pseg_start <= ri->ri_pseg_start) { |
600 | 581 | ||
601 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); | 582 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi); |
602 | if (ret) { | 583 | if (ret) { |
603 | if (ret == NILFS_SEG_FAIL_IO) { | 584 | if (ret == NILFS_SEG_FAIL_IO) { |
604 | err = -EIO; | 585 | err = -EIO; |
@@ -821,7 +802,7 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
821 | 802 | ||
822 | for (;;) { | 803 | for (;;) { |
823 | /* Load segment summary */ | 804 | /* Load segment summary */ |
824 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); | 805 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi); |
825 | if (ret) { | 806 | if (ret) { |
826 | if (ret == NILFS_SEG_FAIL_IO) | 807 | if (ret == NILFS_SEG_FAIL_IO) |
827 | goto failed; | 808 | goto failed; |
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index 645c78656aa0..ab56fe44e377 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c | |||
@@ -40,6 +40,11 @@ struct nilfs_write_info { | |||
40 | }; | 40 | }; |
41 | 41 | ||
42 | 42 | ||
43 | static int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, | ||
44 | struct the_nilfs *nilfs); | ||
45 | static int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf); | ||
46 | |||
47 | |||
43 | static struct kmem_cache *nilfs_segbuf_cachep; | 48 | static struct kmem_cache *nilfs_segbuf_cachep; |
44 | 49 | ||
45 | static void nilfs_segbuf_init_once(void *obj) | 50 | static void nilfs_segbuf_init_once(void *obj) |
@@ -302,6 +307,19 @@ void nilfs_truncate_logs(struct list_head *logs, | |||
302 | } | 307 | } |
303 | } | 308 | } |
304 | 309 | ||
310 | int nilfs_write_logs(struct list_head *logs, struct the_nilfs *nilfs) | ||
311 | { | ||
312 | struct nilfs_segment_buffer *segbuf; | ||
313 | int ret = 0; | ||
314 | |||
315 | list_for_each_entry(segbuf, logs, sb_list) { | ||
316 | ret = nilfs_segbuf_write(segbuf, nilfs); | ||
317 | if (ret) | ||
318 | break; | ||
319 | } | ||
320 | return ret; | ||
321 | } | ||
322 | |||
305 | int nilfs_wait_on_logs(struct list_head *logs) | 323 | int nilfs_wait_on_logs(struct list_head *logs) |
306 | { | 324 | { |
307 | struct nilfs_segment_buffer *segbuf; | 325 | struct nilfs_segment_buffer *segbuf; |
diff --git a/fs/nilfs2/segbuf.h b/fs/nilfs2/segbuf.h index 6af1630fb401..94dfd3517bc0 100644 --- a/fs/nilfs2/segbuf.h +++ b/fs/nilfs2/segbuf.h | |||
@@ -166,13 +166,10 @@ nilfs_segbuf_add_file_buffer(struct nilfs_segment_buffer *segbuf, | |||
166 | segbuf->sb_sum.nfileblk++; | 166 | segbuf->sb_sum.nfileblk++; |
167 | } | 167 | } |
168 | 168 | ||
169 | int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, | ||
170 | struct the_nilfs *nilfs); | ||
171 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf); | ||
172 | |||
173 | void nilfs_clear_logs(struct list_head *logs); | 169 | void nilfs_clear_logs(struct list_head *logs); |
174 | void nilfs_truncate_logs(struct list_head *logs, | 170 | void nilfs_truncate_logs(struct list_head *logs, |
175 | struct nilfs_segment_buffer *last); | 171 | struct nilfs_segment_buffer *last); |
172 | int nilfs_write_logs(struct list_head *logs, struct the_nilfs *nilfs); | ||
176 | int nilfs_wait_on_logs(struct list_head *logs); | 173 | int nilfs_wait_on_logs(struct list_head *logs); |
177 | 174 | ||
178 | static inline void nilfs_destroy_logs(struct list_head *logs) | 175 | static inline void nilfs_destroy_logs(struct list_head *logs) |
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 105b508b47a8..ada2f1b947a3 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c | |||
@@ -1764,14 +1764,9 @@ static int nilfs_segctor_prepare_write(struct nilfs_sc_info *sci, | |||
1764 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, | 1764 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, |
1765 | struct the_nilfs *nilfs) | 1765 | struct the_nilfs *nilfs) |
1766 | { | 1766 | { |
1767 | struct nilfs_segment_buffer *segbuf; | 1767 | int ret; |
1768 | int ret = 0; | ||
1769 | 1768 | ||
1770 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1769 | ret = nilfs_write_logs(&sci->sc_segbufs, nilfs); |
1771 | ret = nilfs_segbuf_write(segbuf, nilfs); | ||
1772 | if (ret) | ||
1773 | break; | ||
1774 | } | ||
1775 | list_splice_tail_init(&sci->sc_segbufs, &sci->sc_write_logs); | 1770 | list_splice_tail_init(&sci->sc_segbufs, &sci->sc_write_logs); |
1776 | return ret; | 1771 | return ret; |
1777 | } | 1772 | } |
@@ -1937,8 +1932,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
1937 | { | 1932 | { |
1938 | struct nilfs_segment_buffer *segbuf; | 1933 | struct nilfs_segment_buffer *segbuf; |
1939 | struct page *bd_page = NULL, *fs_page = NULL; | 1934 | struct page *bd_page = NULL, *fs_page = NULL; |
1940 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 1935 | struct the_nilfs *nilfs = sci->sc_sbi->s_nilfs; |
1941 | struct the_nilfs *nilfs = sbi->s_nilfs; | ||
1942 | int update_sr = (sci->sc_super_root != NULL); | 1936 | int update_sr = (sci->sc_super_root != NULL); |
1943 | 1937 | ||
1944 | list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) { | 1938 | list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) { |
@@ -2020,7 +2014,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
2020 | if (update_sr) { | 2014 | if (update_sr) { |
2021 | nilfs_set_last_segment(nilfs, segbuf->sb_pseg_start, | 2015 | nilfs_set_last_segment(nilfs, segbuf->sb_pseg_start, |
2022 | segbuf->sb_sum.seg_seq, nilfs->ns_cno++); | 2016 | segbuf->sb_sum.seg_seq, nilfs->ns_cno++); |
2023 | sbi->s_super->s_dirt = 1; | 2017 | set_nilfs_sb_dirty(nilfs); |
2024 | 2018 | ||
2025 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); | 2019 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); |
2026 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); | 2020 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); |
@@ -2425,43 +2419,43 @@ int nilfs_construct_dsync_segment(struct super_block *sb, struct inode *inode, | |||
2425 | return err; | 2419 | return err; |
2426 | } | 2420 | } |
2427 | 2421 | ||
2428 | struct nilfs_segctor_req { | ||
2429 | int mode; | ||
2430 | __u32 seq_accepted; | ||
2431 | int sc_err; /* construction failure */ | ||
2432 | int sb_err; /* super block writeback failure */ | ||
2433 | }; | ||
2434 | |||
2435 | #define FLUSH_FILE_BIT (0x1) /* data file only */ | 2422 | #define FLUSH_FILE_BIT (0x1) /* data file only */ |
2436 | #define FLUSH_DAT_BIT (1 << NILFS_DAT_INO) /* DAT only */ | 2423 | #define FLUSH_DAT_BIT (1 << NILFS_DAT_INO) /* DAT only */ |
2437 | 2424 | ||
2438 | static void nilfs_segctor_accept(struct nilfs_sc_info *sci, | 2425 | /** |
2439 | struct nilfs_segctor_req *req) | 2426 | * nilfs_segctor_accept - record accepted sequence count of log-write requests |
2427 | * @sci: segment constructor object | ||
2428 | */ | ||
2429 | static void nilfs_segctor_accept(struct nilfs_sc_info *sci) | ||
2440 | { | 2430 | { |
2441 | req->sc_err = req->sb_err = 0; | ||
2442 | spin_lock(&sci->sc_state_lock); | 2431 | spin_lock(&sci->sc_state_lock); |
2443 | req->seq_accepted = sci->sc_seq_request; | 2432 | sci->sc_seq_accepted = sci->sc_seq_request; |
2444 | spin_unlock(&sci->sc_state_lock); | 2433 | spin_unlock(&sci->sc_state_lock); |
2445 | 2434 | ||
2446 | if (sci->sc_timer) | 2435 | if (sci->sc_timer) |
2447 | del_timer_sync(sci->sc_timer); | 2436 | del_timer_sync(sci->sc_timer); |
2448 | } | 2437 | } |
2449 | 2438 | ||
2450 | static void nilfs_segctor_notify(struct nilfs_sc_info *sci, | 2439 | /** |
2451 | struct nilfs_segctor_req *req) | 2440 | * nilfs_segctor_notify - notify the result of request to caller threads |
2441 | * @sci: segment constructor object | ||
2442 | * @mode: mode of log forming | ||
2443 | * @err: error code to be notified | ||
2444 | */ | ||
2445 | static void nilfs_segctor_notify(struct nilfs_sc_info *sci, int mode, int err) | ||
2452 | { | 2446 | { |
2453 | /* Clear requests (even when the construction failed) */ | 2447 | /* Clear requests (even when the construction failed) */ |
2454 | spin_lock(&sci->sc_state_lock); | 2448 | spin_lock(&sci->sc_state_lock); |
2455 | 2449 | ||
2456 | if (req->mode == SC_LSEG_SR) { | 2450 | if (mode == SC_LSEG_SR) { |
2457 | sci->sc_state &= ~NILFS_SEGCTOR_COMMIT; | 2451 | sci->sc_state &= ~NILFS_SEGCTOR_COMMIT; |
2458 | sci->sc_seq_done = req->seq_accepted; | 2452 | sci->sc_seq_done = sci->sc_seq_accepted; |
2459 | nilfs_segctor_wakeup(sci, req->sc_err ? : req->sb_err); | 2453 | nilfs_segctor_wakeup(sci, err); |
2460 | sci->sc_flush_request = 0; | 2454 | sci->sc_flush_request = 0; |
2461 | } else { | 2455 | } else { |
2462 | if (req->mode == SC_FLUSH_FILE) | 2456 | if (mode == SC_FLUSH_FILE) |
2463 | sci->sc_flush_request &= ~FLUSH_FILE_BIT; | 2457 | sci->sc_flush_request &= ~FLUSH_FILE_BIT; |
2464 | else if (req->mode == SC_FLUSH_DAT) | 2458 | else if (mode == SC_FLUSH_DAT) |
2465 | sci->sc_flush_request &= ~FLUSH_DAT_BIT; | 2459 | sci->sc_flush_request &= ~FLUSH_DAT_BIT; |
2466 | 2460 | ||
2467 | /* re-enable timer if checkpoint creation was not done */ | 2461 | /* re-enable timer if checkpoint creation was not done */ |
@@ -2472,30 +2466,37 @@ static void nilfs_segctor_notify(struct nilfs_sc_info *sci, | |||
2472 | spin_unlock(&sci->sc_state_lock); | 2466 | spin_unlock(&sci->sc_state_lock); |
2473 | } | 2467 | } |
2474 | 2468 | ||
2475 | static int nilfs_segctor_construct(struct nilfs_sc_info *sci, | 2469 | /** |
2476 | struct nilfs_segctor_req *req) | 2470 | * nilfs_segctor_construct - form logs and write them to disk |
2471 | * @sci: segment constructor object | ||
2472 | * @mode: mode of log forming | ||
2473 | */ | ||
2474 | static int nilfs_segctor_construct(struct nilfs_sc_info *sci, int mode) | ||
2477 | { | 2475 | { |
2478 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2476 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2479 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2477 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2480 | int err = 0; | 2478 | int err = 0; |
2481 | 2479 | ||
2480 | nilfs_segctor_accept(sci); | ||
2481 | |||
2482 | if (nilfs_discontinued(nilfs)) | 2482 | if (nilfs_discontinued(nilfs)) |
2483 | req->mode = SC_LSEG_SR; | 2483 | mode = SC_LSEG_SR; |
2484 | if (!nilfs_segctor_confirm(sci)) { | 2484 | if (!nilfs_segctor_confirm(sci)) |
2485 | err = nilfs_segctor_do_construct(sci, req->mode); | 2485 | err = nilfs_segctor_do_construct(sci, mode); |
2486 | req->sc_err = err; | 2486 | |
2487 | } | ||
2488 | if (likely(!err)) { | 2487 | if (likely(!err)) { |
2489 | if (req->mode != SC_FLUSH_DAT) | 2488 | if (mode != SC_FLUSH_DAT) |
2490 | atomic_set(&nilfs->ns_ndirtyblks, 0); | 2489 | atomic_set(&nilfs->ns_ndirtyblks, 0); |
2491 | if (test_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags) && | 2490 | if (test_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags) && |
2492 | nilfs_discontinued(nilfs)) { | 2491 | nilfs_discontinued(nilfs)) { |
2493 | down_write(&nilfs->ns_sem); | 2492 | down_write(&nilfs->ns_sem); |
2494 | req->sb_err = nilfs_commit_super(sbi, | 2493 | err = nilfs_commit_super( |
2495 | nilfs_altsb_need_update(nilfs)); | 2494 | sbi, nilfs_altsb_need_update(nilfs)); |
2496 | up_write(&nilfs->ns_sem); | 2495 | up_write(&nilfs->ns_sem); |
2497 | } | 2496 | } |
2498 | } | 2497 | } |
2498 | |||
2499 | nilfs_segctor_notify(sci, mode, err); | ||
2499 | return err; | 2500 | return err; |
2500 | } | 2501 | } |
2501 | 2502 | ||
@@ -2526,7 +2527,6 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2526 | struct nilfs_sc_info *sci = NILFS_SC(sbi); | 2527 | struct nilfs_sc_info *sci = NILFS_SC(sbi); |
2527 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2528 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2528 | struct nilfs_transaction_info ti; | 2529 | struct nilfs_transaction_info ti; |
2529 | struct nilfs_segctor_req req = { .mode = SC_LSEG_SR }; | ||
2530 | int err; | 2530 | int err; |
2531 | 2531 | ||
2532 | if (unlikely(!sci)) | 2532 | if (unlikely(!sci)) |
@@ -2547,10 +2547,8 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2547 | list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes); | 2547 | list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes); |
2548 | 2548 | ||
2549 | for (;;) { | 2549 | for (;;) { |
2550 | nilfs_segctor_accept(sci, &req); | 2550 | err = nilfs_segctor_construct(sci, SC_LSEG_SR); |
2551 | err = nilfs_segctor_construct(sci, &req); | ||
2552 | nilfs_remove_written_gcinodes(nilfs, &sci->sc_gc_inodes); | 2551 | nilfs_remove_written_gcinodes(nilfs, &sci->sc_gc_inodes); |
2553 | nilfs_segctor_notify(sci, &req); | ||
2554 | 2552 | ||
2555 | if (likely(!err)) | 2553 | if (likely(!err)) |
2556 | break; | 2554 | break; |
@@ -2560,6 +2558,16 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2560 | set_current_state(TASK_INTERRUPTIBLE); | 2558 | set_current_state(TASK_INTERRUPTIBLE); |
2561 | schedule_timeout(sci->sc_interval); | 2559 | schedule_timeout(sci->sc_interval); |
2562 | } | 2560 | } |
2561 | if (nilfs_test_opt(sbi, DISCARD)) { | ||
2562 | int ret = nilfs_discard_segments(nilfs, sci->sc_freesegs, | ||
2563 | sci->sc_nfreesegs); | ||
2564 | if (ret) { | ||
2565 | printk(KERN_WARNING | ||
2566 | "NILFS warning: error %d on discard request, " | ||
2567 | "turning discards off for the device\n", ret); | ||
2568 | nilfs_clear_opt(sbi, DISCARD); | ||
2569 | } | ||
2570 | } | ||
2563 | 2571 | ||
2564 | out_unlock: | 2572 | out_unlock: |
2565 | sci->sc_freesegs = NULL; | 2573 | sci->sc_freesegs = NULL; |
@@ -2573,13 +2581,9 @@ static void nilfs_segctor_thread_construct(struct nilfs_sc_info *sci, int mode) | |||
2573 | { | 2581 | { |
2574 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2582 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2575 | struct nilfs_transaction_info ti; | 2583 | struct nilfs_transaction_info ti; |
2576 | struct nilfs_segctor_req req = { .mode = mode }; | ||
2577 | 2584 | ||
2578 | nilfs_transaction_lock(sbi, &ti, 0); | 2585 | nilfs_transaction_lock(sbi, &ti, 0); |
2579 | 2586 | nilfs_segctor_construct(sci, mode); | |
2580 | nilfs_segctor_accept(sci, &req); | ||
2581 | nilfs_segctor_construct(sci, &req); | ||
2582 | nilfs_segctor_notify(sci, &req); | ||
2583 | 2587 | ||
2584 | /* | 2588 | /* |
2585 | * Unclosed segment should be retried. We do this using sc_timer. | 2589 | * Unclosed segment should be retried. We do this using sc_timer. |
@@ -2635,6 +2639,7 @@ static int nilfs_segctor_flush_mode(struct nilfs_sc_info *sci) | |||
2635 | static int nilfs_segctor_thread(void *arg) | 2639 | static int nilfs_segctor_thread(void *arg) |
2636 | { | 2640 | { |
2637 | struct nilfs_sc_info *sci = (struct nilfs_sc_info *)arg; | 2641 | struct nilfs_sc_info *sci = (struct nilfs_sc_info *)arg; |
2642 | struct the_nilfs *nilfs = sci->sc_sbi->s_nilfs; | ||
2638 | struct timer_list timer; | 2643 | struct timer_list timer; |
2639 | int timeout = 0; | 2644 | int timeout = 0; |
2640 | 2645 | ||
@@ -2680,7 +2685,6 @@ static int nilfs_segctor_thread(void *arg) | |||
2680 | } else { | 2685 | } else { |
2681 | DEFINE_WAIT(wait); | 2686 | DEFINE_WAIT(wait); |
2682 | int should_sleep = 1; | 2687 | int should_sleep = 1; |
2683 | struct the_nilfs *nilfs; | ||
2684 | 2688 | ||
2685 | prepare_to_wait(&sci->sc_wait_daemon, &wait, | 2689 | prepare_to_wait(&sci->sc_wait_daemon, &wait, |
2686 | TASK_INTERRUPTIBLE); | 2690 | TASK_INTERRUPTIBLE); |
@@ -2701,8 +2705,8 @@ static int nilfs_segctor_thread(void *arg) | |||
2701 | finish_wait(&sci->sc_wait_daemon, &wait); | 2705 | finish_wait(&sci->sc_wait_daemon, &wait); |
2702 | timeout = ((sci->sc_state & NILFS_SEGCTOR_COMMIT) && | 2706 | timeout = ((sci->sc_state & NILFS_SEGCTOR_COMMIT) && |
2703 | time_after_eq(jiffies, sci->sc_timer->expires)); | 2707 | time_after_eq(jiffies, sci->sc_timer->expires)); |
2704 | nilfs = sci->sc_sbi->s_nilfs; | 2708 | |
2705 | if (sci->sc_super->s_dirt && nilfs_sb_need_update(nilfs)) | 2709 | if (nilfs_sb_dirty(nilfs) && nilfs_sb_need_update(nilfs)) |
2706 | set_nilfs_discontinued(nilfs); | 2710 | set_nilfs_discontinued(nilfs); |
2707 | } | 2711 | } |
2708 | goto loop; | 2712 | goto loop; |
@@ -2797,12 +2801,9 @@ static void nilfs_segctor_write_out(struct nilfs_sc_info *sci) | |||
2797 | do { | 2801 | do { |
2798 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2802 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2799 | struct nilfs_transaction_info ti; | 2803 | struct nilfs_transaction_info ti; |
2800 | struct nilfs_segctor_req req = { .mode = SC_LSEG_SR }; | ||
2801 | 2804 | ||
2802 | nilfs_transaction_lock(sbi, &ti, 0); | 2805 | nilfs_transaction_lock(sbi, &ti, 0); |
2803 | nilfs_segctor_accept(sci, &req); | 2806 | ret = nilfs_segctor_construct(sci, SC_LSEG_SR); |
2804 | ret = nilfs_segctor_construct(sci, &req); | ||
2805 | nilfs_segctor_notify(sci, &req); | ||
2806 | nilfs_transaction_unlock(sbi); | 2807 | nilfs_transaction_unlock(sbi); |
2807 | 2808 | ||
2808 | } while (ret && retrycount-- > 0); | 2809 | } while (ret && retrycount-- > 0); |
@@ -2865,8 +2866,15 @@ int nilfs_attach_segment_constructor(struct nilfs_sb_info *sbi) | |||
2865 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2866 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2866 | int err; | 2867 | int err; |
2867 | 2868 | ||
2868 | /* Each field of nilfs_segctor is cleared through the initialization | 2869 | if (NILFS_SC(sbi)) { |
2869 | of super-block info */ | 2870 | /* |
2871 | * This happens if the filesystem was remounted | ||
2872 | * read/write after nilfs_error degenerated it into a | ||
2873 | * read-only mount. | ||
2874 | */ | ||
2875 | nilfs_detach_segment_constructor(sbi); | ||
2876 | } | ||
2877 | |||
2870 | sbi->s_sc_info = nilfs_segctor_new(sbi); | 2878 | sbi->s_sc_info = nilfs_segctor_new(sbi); |
2871 | if (!sbi->s_sc_info) | 2879 | if (!sbi->s_sc_info) |
2872 | return -ENOMEM; | 2880 | return -ENOMEM; |
diff --git a/fs/nilfs2/segment.h b/fs/nilfs2/segment.h index 3d3ab2f9864c..3155e0c7f415 100644 --- a/fs/nilfs2/segment.h +++ b/fs/nilfs2/segment.h | |||
@@ -116,6 +116,7 @@ struct nilfs_segsum_pointer { | |||
116 | * @sc_wait_daemon: Daemon wait queue | 116 | * @sc_wait_daemon: Daemon wait queue |
117 | * @sc_wait_task: Start/end wait queue to control segctord task | 117 | * @sc_wait_task: Start/end wait queue to control segctord task |
118 | * @sc_seq_request: Request counter | 118 | * @sc_seq_request: Request counter |
119 | * @sc_seq_accept: Accepted request count | ||
119 | * @sc_seq_done: Completion counter | 120 | * @sc_seq_done: Completion counter |
120 | * @sc_sync: Request of explicit sync operation | 121 | * @sc_sync: Request of explicit sync operation |
121 | * @sc_interval: Timeout value of background construction | 122 | * @sc_interval: Timeout value of background construction |
@@ -169,6 +170,7 @@ struct nilfs_sc_info { | |||
169 | wait_queue_head_t sc_wait_task; | 170 | wait_queue_head_t sc_wait_task; |
170 | 171 | ||
171 | __u32 sc_seq_request; | 172 | __u32 sc_seq_request; |
173 | __u32 sc_seq_accepted; | ||
172 | __u32 sc_seq_done; | 174 | __u32 sc_seq_done; |
173 | 175 | ||
174 | int sc_sync; | 176 | int sc_sync; |
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 8173faee31e6..92579cc4c935 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
@@ -96,9 +96,6 @@ void nilfs_error(struct super_block *sb, const char *function, | |||
96 | if (!(sb->s_flags & MS_RDONLY)) { | 96 | if (!(sb->s_flags & MS_RDONLY)) { |
97 | struct the_nilfs *nilfs = sbi->s_nilfs; | 97 | struct the_nilfs *nilfs = sbi->s_nilfs; |
98 | 98 | ||
99 | if (!nilfs_test_opt(sbi, ERRORS_CONT)) | ||
100 | nilfs_detach_segment_constructor(sbi); | ||
101 | |||
102 | down_write(&nilfs->ns_sem); | 99 | down_write(&nilfs->ns_sem); |
103 | if (!(nilfs->ns_mount_state & NILFS_ERROR_FS)) { | 100 | if (!(nilfs->ns_mount_state & NILFS_ERROR_FS)) { |
104 | nilfs->ns_mount_state |= NILFS_ERROR_FS; | 101 | nilfs->ns_mount_state |= NILFS_ERROR_FS; |
@@ -301,7 +298,7 @@ int nilfs_commit_super(struct nilfs_sb_info *sbi, int dupsb) | |||
301 | memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); | 298 | memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); |
302 | nilfs->ns_sbwtime[1] = t; | 299 | nilfs->ns_sbwtime[1] = t; |
303 | } | 300 | } |
304 | sbi->s_super->s_dirt = 0; | 301 | clear_nilfs_sb_dirty(nilfs); |
305 | return nilfs_sync_super(sbi, dupsb); | 302 | return nilfs_sync_super(sbi, dupsb); |
306 | } | 303 | } |
307 | 304 | ||
@@ -345,7 +342,7 @@ static int nilfs_sync_fs(struct super_block *sb, int wait) | |||
345 | err = nilfs_construct_segment(sb); | 342 | err = nilfs_construct_segment(sb); |
346 | 343 | ||
347 | down_write(&nilfs->ns_sem); | 344 | down_write(&nilfs->ns_sem); |
348 | if (sb->s_dirt) | 345 | if (nilfs_sb_dirty(nilfs)) |
349 | nilfs_commit_super(sbi, 1); | 346 | nilfs_commit_super(sbi, 1); |
350 | up_write(&nilfs->ns_sem); | 347 | up_write(&nilfs->ns_sem); |
351 | 348 | ||
@@ -481,6 +478,8 @@ static int nilfs_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
481 | seq_printf(seq, ",order=strict"); | 478 | seq_printf(seq, ",order=strict"); |
482 | if (nilfs_test_opt(sbi, NORECOVERY)) | 479 | if (nilfs_test_opt(sbi, NORECOVERY)) |
483 | seq_printf(seq, ",norecovery"); | 480 | seq_printf(seq, ",norecovery"); |
481 | if (nilfs_test_opt(sbi, DISCARD)) | ||
482 | seq_printf(seq, ",discard"); | ||
484 | 483 | ||
485 | return 0; | 484 | return 0; |
486 | } | 485 | } |
@@ -550,7 +549,7 @@ static const struct export_operations nilfs_export_ops = { | |||
550 | enum { | 549 | enum { |
551 | Opt_err_cont, Opt_err_panic, Opt_err_ro, | 550 | Opt_err_cont, Opt_err_panic, Opt_err_ro, |
552 | Opt_nobarrier, Opt_snapshot, Opt_order, Opt_norecovery, | 551 | Opt_nobarrier, Opt_snapshot, Opt_order, Opt_norecovery, |
553 | Opt_err, | 552 | Opt_discard, Opt_err, |
554 | }; | 553 | }; |
555 | 554 | ||
556 | static match_table_t tokens = { | 555 | static match_table_t tokens = { |
@@ -561,6 +560,7 @@ static match_table_t tokens = { | |||
561 | {Opt_snapshot, "cp=%u"}, | 560 | {Opt_snapshot, "cp=%u"}, |
562 | {Opt_order, "order=%s"}, | 561 | {Opt_order, "order=%s"}, |
563 | {Opt_norecovery, "norecovery"}, | 562 | {Opt_norecovery, "norecovery"}, |
563 | {Opt_discard, "discard"}, | ||
564 | {Opt_err, NULL} | 564 | {Opt_err, NULL} |
565 | }; | 565 | }; |
566 | 566 | ||
@@ -614,6 +614,9 @@ static int parse_options(char *options, struct super_block *sb) | |||
614 | case Opt_norecovery: | 614 | case Opt_norecovery: |
615 | nilfs_set_opt(sbi, NORECOVERY); | 615 | nilfs_set_opt(sbi, NORECOVERY); |
616 | break; | 616 | break; |
617 | case Opt_discard: | ||
618 | nilfs_set_opt(sbi, DISCARD); | ||
619 | break; | ||
617 | default: | 620 | default: |
618 | printk(KERN_ERR | 621 | printk(KERN_ERR |
619 | "NILFS: Unrecognized mount option \"%s\"\n", p); | 622 | "NILFS: Unrecognized mount option \"%s\"\n", p); |
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 6241e1722efc..92733d5651d2 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c | |||
@@ -646,6 +646,44 @@ int init_nilfs(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, char *data) | |||
646 | goto out; | 646 | goto out; |
647 | } | 647 | } |
648 | 648 | ||
649 | int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump, | ||
650 | size_t nsegs) | ||
651 | { | ||
652 | sector_t seg_start, seg_end; | ||
653 | sector_t start = 0, nblocks = 0; | ||
654 | unsigned int sects_per_block; | ||
655 | __u64 *sn; | ||
656 | int ret = 0; | ||
657 | |||
658 | sects_per_block = (1 << nilfs->ns_blocksize_bits) / | ||
659 | bdev_logical_block_size(nilfs->ns_bdev); | ||
660 | for (sn = segnump; sn < segnump + nsegs; sn++) { | ||
661 | nilfs_get_segment_range(nilfs, *sn, &seg_start, &seg_end); | ||
662 | |||
663 | if (!nblocks) { | ||
664 | start = seg_start; | ||
665 | nblocks = seg_end - seg_start + 1; | ||
666 | } else if (start + nblocks == seg_start) { | ||
667 | nblocks += seg_end - seg_start + 1; | ||
668 | } else { | ||
669 | ret = blkdev_issue_discard(nilfs->ns_bdev, | ||
670 | start * sects_per_block, | ||
671 | nblocks * sects_per_block, | ||
672 | GFP_NOFS, | ||
673 | DISCARD_FL_BARRIER); | ||
674 | if (ret < 0) | ||
675 | return ret; | ||
676 | nblocks = 0; | ||
677 | } | ||
678 | } | ||
679 | if (nblocks) | ||
680 | ret = blkdev_issue_discard(nilfs->ns_bdev, | ||
681 | start * sects_per_block, | ||
682 | nblocks * sects_per_block, | ||
683 | GFP_NOFS, DISCARD_FL_BARRIER); | ||
684 | return ret; | ||
685 | } | ||
686 | |||
649 | int nilfs_count_free_blocks(struct the_nilfs *nilfs, sector_t *nblocks) | 687 | int nilfs_count_free_blocks(struct the_nilfs *nilfs, sector_t *nblocks) |
650 | { | 688 | { |
651 | struct inode *dat = nilfs_dat_inode(nilfs); | 689 | struct inode *dat = nilfs_dat_inode(nilfs); |
diff --git a/fs/nilfs2/the_nilfs.h b/fs/nilfs2/the_nilfs.h index 589786e33464..e9795f1724d7 100644 --- a/fs/nilfs2/the_nilfs.h +++ b/fs/nilfs2/the_nilfs.h | |||
@@ -38,6 +38,7 @@ enum { | |||
38 | the latest checkpoint was loaded */ | 38 | the latest checkpoint was loaded */ |
39 | THE_NILFS_DISCONTINUED, /* 'next' pointer chain has broken */ | 39 | THE_NILFS_DISCONTINUED, /* 'next' pointer chain has broken */ |
40 | THE_NILFS_GC_RUNNING, /* gc process is running */ | 40 | THE_NILFS_GC_RUNNING, /* gc process is running */ |
41 | THE_NILFS_SB_DIRTY, /* super block is dirty */ | ||
41 | }; | 42 | }; |
42 | 43 | ||
43 | /** | 44 | /** |
@@ -197,6 +198,7 @@ THE_NILFS_FNS(INIT, init) | |||
197 | THE_NILFS_FNS(LOADED, loaded) | 198 | THE_NILFS_FNS(LOADED, loaded) |
198 | THE_NILFS_FNS(DISCONTINUED, discontinued) | 199 | THE_NILFS_FNS(DISCONTINUED, discontinued) |
199 | THE_NILFS_FNS(GC_RUNNING, gc_running) | 200 | THE_NILFS_FNS(GC_RUNNING, gc_running) |
201 | THE_NILFS_FNS(SB_DIRTY, sb_dirty) | ||
200 | 202 | ||
201 | /* Minimum interval of periodical update of superblocks (in seconds) */ | 203 | /* Minimum interval of periodical update of superblocks (in seconds) */ |
202 | #define NILFS_SB_FREQ 10 | 204 | #define NILFS_SB_FREQ 10 |
@@ -221,6 +223,7 @@ struct the_nilfs *find_or_create_nilfs(struct block_device *); | |||
221 | void put_nilfs(struct the_nilfs *); | 223 | void put_nilfs(struct the_nilfs *); |
222 | int init_nilfs(struct the_nilfs *, struct nilfs_sb_info *, char *); | 224 | int init_nilfs(struct the_nilfs *, struct nilfs_sb_info *, char *); |
223 | int load_nilfs(struct the_nilfs *, struct nilfs_sb_info *); | 225 | int load_nilfs(struct the_nilfs *, struct nilfs_sb_info *); |
226 | int nilfs_discard_segments(struct the_nilfs *, __u64 *, size_t); | ||
224 | int nilfs_count_free_blocks(struct the_nilfs *, sector_t *); | 227 | int nilfs_count_free_blocks(struct the_nilfs *, sector_t *); |
225 | struct nilfs_sb_info *nilfs_find_sbinfo(struct the_nilfs *, int, __u64); | 228 | struct nilfs_sb_info *nilfs_find_sbinfo(struct the_nilfs *, int, __u64); |
226 | int nilfs_checkpoint_is_mounted(struct the_nilfs *, __u64, int); | 229 | int nilfs_checkpoint_is_mounted(struct the_nilfs *, __u64, int); |
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index a94e8bd8eb1f..472cdf29ef82 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c | |||
@@ -29,14 +29,12 @@ | |||
29 | #include <linux/init.h> /* module_init */ | 29 | #include <linux/init.h> /* module_init */ |
30 | #include <linux/inotify.h> | 30 | #include <linux/inotify.h> |
31 | #include <linux/kernel.h> /* roundup() */ | 31 | #include <linux/kernel.h> /* roundup() */ |
32 | #include <linux/magic.h> /* superblock magic number */ | ||
33 | #include <linux/mount.h> /* mntget */ | ||
34 | #include <linux/namei.h> /* LOOKUP_FOLLOW */ | 32 | #include <linux/namei.h> /* LOOKUP_FOLLOW */ |
35 | #include <linux/path.h> /* struct path */ | ||
36 | #include <linux/sched.h> /* struct user */ | 33 | #include <linux/sched.h> /* struct user */ |
37 | #include <linux/slab.h> /* struct kmem_cache */ | 34 | #include <linux/slab.h> /* struct kmem_cache */ |
38 | #include <linux/syscalls.h> | 35 | #include <linux/syscalls.h> |
39 | #include <linux/types.h> | 36 | #include <linux/types.h> |
37 | #include <linux/anon_inodes.h> | ||
40 | #include <linux/uaccess.h> | 38 | #include <linux/uaccess.h> |
41 | #include <linux/poll.h> | 39 | #include <linux/poll.h> |
42 | #include <linux/wait.h> | 40 | #include <linux/wait.h> |
@@ -45,8 +43,6 @@ | |||
45 | 43 | ||
46 | #include <asm/ioctls.h> | 44 | #include <asm/ioctls.h> |
47 | 45 | ||
48 | static struct vfsmount *inotify_mnt __read_mostly; | ||
49 | |||
50 | /* these are configurable via /proc/sys/fs/inotify/ */ | 46 | /* these are configurable via /proc/sys/fs/inotify/ */ |
51 | static int inotify_max_user_instances __read_mostly; | 47 | static int inotify_max_user_instances __read_mostly; |
52 | static int inotify_max_queued_events __read_mostly; | 48 | static int inotify_max_queued_events __read_mostly; |
@@ -645,9 +641,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
645 | { | 641 | { |
646 | struct fsnotify_group *group; | 642 | struct fsnotify_group *group; |
647 | struct user_struct *user; | 643 | struct user_struct *user; |
648 | struct file *filp; | 644 | int ret; |
649 | struct path path; | ||
650 | int fd, ret; | ||
651 | 645 | ||
652 | /* Check the IN_* constants for consistency. */ | 646 | /* Check the IN_* constants for consistency. */ |
653 | BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC); | 647 | BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC); |
@@ -656,10 +650,6 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
656 | if (flags & ~(IN_CLOEXEC | IN_NONBLOCK)) | 650 | if (flags & ~(IN_CLOEXEC | IN_NONBLOCK)) |
657 | return -EINVAL; | 651 | return -EINVAL; |
658 | 652 | ||
659 | fd = get_unused_fd_flags(flags & O_CLOEXEC); | ||
660 | if (fd < 0) | ||
661 | return fd; | ||
662 | |||
663 | user = get_current_user(); | 653 | user = get_current_user(); |
664 | if (unlikely(atomic_read(&user->inotify_devs) >= | 654 | if (unlikely(atomic_read(&user->inotify_devs) >= |
665 | inotify_max_user_instances)) { | 655 | inotify_max_user_instances)) { |
@@ -676,27 +666,14 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
676 | 666 | ||
677 | atomic_inc(&user->inotify_devs); | 667 | atomic_inc(&user->inotify_devs); |
678 | 668 | ||
679 | path.mnt = inotify_mnt; | 669 | ret = anon_inode_getfd("inotify", &inotify_fops, group, |
680 | path.dentry = inotify_mnt->mnt_root; | 670 | O_RDONLY | flags); |
681 | path_get(&path); | 671 | if (ret >= 0) |
682 | filp = alloc_file(&path, FMODE_READ, &inotify_fops); | 672 | return ret; |
683 | if (!filp) | ||
684 | goto Enfile; | ||
685 | 673 | ||
686 | filp->f_flags = O_RDONLY | (flags & O_NONBLOCK); | ||
687 | filp->private_data = group; | ||
688 | |||
689 | fd_install(fd, filp); | ||
690 | |||
691 | return fd; | ||
692 | |||
693 | Enfile: | ||
694 | ret = -ENFILE; | ||
695 | path_put(&path); | ||
696 | atomic_dec(&user->inotify_devs); | 674 | atomic_dec(&user->inotify_devs); |
697 | out_free_uid: | 675 | out_free_uid: |
698 | free_uid(user); | 676 | free_uid(user); |
699 | put_unused_fd(fd); | ||
700 | return ret; | 677 | return ret; |
701 | } | 678 | } |
702 | 679 | ||
@@ -783,20 +760,6 @@ out: | |||
783 | return ret; | 760 | return ret; |
784 | } | 761 | } |
785 | 762 | ||
786 | static int | ||
787 | inotify_get_sb(struct file_system_type *fs_type, int flags, | ||
788 | const char *dev_name, void *data, struct vfsmount *mnt) | ||
789 | { | ||
790 | return get_sb_pseudo(fs_type, "inotify", NULL, | ||
791 | INOTIFYFS_SUPER_MAGIC, mnt); | ||
792 | } | ||
793 | |||
794 | static struct file_system_type inotify_fs_type = { | ||
795 | .name = "inotifyfs", | ||
796 | .get_sb = inotify_get_sb, | ||
797 | .kill_sb = kill_anon_super, | ||
798 | }; | ||
799 | |||
800 | /* | 763 | /* |
801 | * inotify_user_setup - Our initialization function. Note that we cannnot return | 764 | * inotify_user_setup - Our initialization function. Note that we cannnot return |
802 | * error because we have compiled-in VFS hooks. So an (unlikely) failure here | 765 | * error because we have compiled-in VFS hooks. So an (unlikely) failure here |
@@ -804,16 +767,6 @@ static struct file_system_type inotify_fs_type = { | |||
804 | */ | 767 | */ |
805 | static int __init inotify_user_setup(void) | 768 | static int __init inotify_user_setup(void) |
806 | { | 769 | { |
807 | int ret; | ||
808 | |||
809 | ret = register_filesystem(&inotify_fs_type); | ||
810 | if (unlikely(ret)) | ||
811 | panic("inotify: register_filesystem returned %d!\n", ret); | ||
812 | |||
813 | inotify_mnt = kern_mount(&inotify_fs_type); | ||
814 | if (IS_ERR(inotify_mnt)) | ||
815 | panic("inotify: kern_mount ret %ld!\n", PTR_ERR(inotify_mnt)); | ||
816 | |||
817 | inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark_entry, SLAB_PANIC); | 770 | inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark_entry, SLAB_PANIC); |
818 | event_priv_cachep = KMEM_CACHE(inotify_event_private_data, SLAB_PANIC); | 771 | event_priv_cachep = KMEM_CACHE(inotify_event_private_data, SLAB_PANIC); |
819 | 772 | ||
diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 5a9e34475e37..9173e82a45d1 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c | |||
@@ -1545,7 +1545,7 @@ static int ntfs_dir_fsync(struct file *filp, struct dentry *dentry, | |||
1545 | write_inode_now(bmp_vi, !datasync); | 1545 | write_inode_now(bmp_vi, !datasync); |
1546 | iput(bmp_vi); | 1546 | iput(bmp_vi); |
1547 | } | 1547 | } |
1548 | ret = ntfs_write_inode(vi, 1); | 1548 | ret = __ntfs_write_inode(vi, 1); |
1549 | write_inode_now(vi, !datasync); | 1549 | write_inode_now(vi, !datasync); |
1550 | err = sync_blockdev(vi->i_sb->s_bdev); | 1550 | err = sync_blockdev(vi->i_sb->s_bdev); |
1551 | if (unlikely(err && !ret)) | 1551 | if (unlikely(err && !ret)) |
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 43179ddd336f..b681c71d7069 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c | |||
@@ -2182,7 +2182,7 @@ static int ntfs_file_fsync(struct file *filp, struct dentry *dentry, | |||
2182 | ntfs_debug("Entering for inode 0x%lx.", vi->i_ino); | 2182 | ntfs_debug("Entering for inode 0x%lx.", vi->i_ino); |
2183 | BUG_ON(S_ISDIR(vi->i_mode)); | 2183 | BUG_ON(S_ISDIR(vi->i_mode)); |
2184 | if (!datasync || !NInoNonResident(NTFS_I(vi))) | 2184 | if (!datasync || !NInoNonResident(NTFS_I(vi))) |
2185 | ret = ntfs_write_inode(vi, 1); | 2185 | ret = __ntfs_write_inode(vi, 1); |
2186 | write_inode_now(vi, !datasync); | 2186 | write_inode_now(vi, !datasync); |
2187 | /* | 2187 | /* |
2188 | * NOTE: If we were to use mapping->private_list (see ext2 and | 2188 | * NOTE: If we were to use mapping->private_list (see ext2 and |
diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index dc2505abb6d7..4b57fb1eac2a 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c | |||
@@ -2957,7 +2957,7 @@ out: | |||
2957 | * | 2957 | * |
2958 | * Return 0 on success and -errno on error. | 2958 | * Return 0 on success and -errno on error. |
2959 | */ | 2959 | */ |
2960 | int ntfs_write_inode(struct inode *vi, int sync) | 2960 | int __ntfs_write_inode(struct inode *vi, int sync) |
2961 | { | 2961 | { |
2962 | sle64 nt; | 2962 | sle64 nt; |
2963 | ntfs_inode *ni = NTFS_I(vi); | 2963 | ntfs_inode *ni = NTFS_I(vi); |
diff --git a/fs/ntfs/inode.h b/fs/ntfs/inode.h index 117eaf8032a3..9a113544605d 100644 --- a/fs/ntfs/inode.h +++ b/fs/ntfs/inode.h | |||
@@ -307,12 +307,12 @@ extern void ntfs_truncate_vfs(struct inode *vi); | |||
307 | 307 | ||
308 | extern int ntfs_setattr(struct dentry *dentry, struct iattr *attr); | 308 | extern int ntfs_setattr(struct dentry *dentry, struct iattr *attr); |
309 | 309 | ||
310 | extern int ntfs_write_inode(struct inode *vi, int sync); | 310 | extern int __ntfs_write_inode(struct inode *vi, int sync); |
311 | 311 | ||
312 | static inline void ntfs_commit_inode(struct inode *vi) | 312 | static inline void ntfs_commit_inode(struct inode *vi) |
313 | { | 313 | { |
314 | if (!is_bad_inode(vi)) | 314 | if (!is_bad_inode(vi)) |
315 | ntfs_write_inode(vi, 1); | 315 | __ntfs_write_inode(vi, 1); |
316 | return; | 316 | return; |
317 | } | 317 | } |
318 | 318 | ||
diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 80b04770e8e9..1cf39dfaee7a 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c | |||
@@ -39,6 +39,7 @@ | |||
39 | #include "dir.h" | 39 | #include "dir.h" |
40 | #include "debug.h" | 40 | #include "debug.h" |
41 | #include "index.h" | 41 | #include "index.h" |
42 | #include "inode.h" | ||
42 | #include "aops.h" | 43 | #include "aops.h" |
43 | #include "layout.h" | 44 | #include "layout.h" |
44 | #include "malloc.h" | 45 | #include "malloc.h" |
@@ -2662,6 +2663,13 @@ static int ntfs_statfs(struct dentry *dentry, struct kstatfs *sfs) | |||
2662 | return 0; | 2663 | return 0; |
2663 | } | 2664 | } |
2664 | 2665 | ||
2666 | #ifdef NTFS_RW | ||
2667 | static int ntfs_write_inode(struct inode *vi, struct writeback_control *wbc) | ||
2668 | { | ||
2669 | return __ntfs_write_inode(vi, wbc->sync_mode == WB_SYNC_ALL); | ||
2670 | } | ||
2671 | #endif | ||
2672 | |||
2665 | /** | 2673 | /** |
2666 | * The complete super operations. | 2674 | * The complete super operations. |
2667 | */ | 2675 | */ |
diff --git a/fs/ocfs2/Makefile b/fs/ocfs2/Makefile index 600d2d2ade11..791c0886c060 100644 --- a/fs/ocfs2/Makefile +++ b/fs/ocfs2/Makefile | |||
@@ -46,6 +46,7 @@ ocfs2_stackglue-objs := stackglue.o | |||
46 | ocfs2_stack_o2cb-objs := stack_o2cb.o | 46 | ocfs2_stack_o2cb-objs := stack_o2cb.o |
47 | ocfs2_stack_user-objs := stack_user.o | 47 | ocfs2_stack_user-objs := stack_user.o |
48 | 48 | ||
49 | obj-$(CONFIG_OCFS2_FS) += dlmfs/ | ||
49 | # cluster/ is always needed when OCFS2_FS for masklog support | 50 | # cluster/ is always needed when OCFS2_FS for masklog support |
50 | obj-$(CONFIG_OCFS2_FS) += cluster/ | 51 | obj-$(CONFIG_OCFS2_FS) += cluster/ |
51 | obj-$(CONFIG_OCFS2_FS_O2CB) += dlm/ | 52 | obj-$(CONFIG_OCFS2_FS_O2CB) += dlm/ |
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 20538dd832a4..9f8bd913c51e 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c | |||
@@ -1050,7 +1050,8 @@ static int ocfs2_create_new_meta_bhs(handle_t *handle, | |||
1050 | strcpy(eb->h_signature, OCFS2_EXTENT_BLOCK_SIGNATURE); | 1050 | strcpy(eb->h_signature, OCFS2_EXTENT_BLOCK_SIGNATURE); |
1051 | eb->h_blkno = cpu_to_le64(first_blkno); | 1051 | eb->h_blkno = cpu_to_le64(first_blkno); |
1052 | eb->h_fs_generation = cpu_to_le32(osb->fs_generation); | 1052 | eb->h_fs_generation = cpu_to_le32(osb->fs_generation); |
1053 | eb->h_suballoc_slot = cpu_to_le16(osb->slot_num); | 1053 | eb->h_suballoc_slot = |
1054 | cpu_to_le16(meta_ac->ac_alloc_slot); | ||
1054 | eb->h_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1055 | eb->h_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1055 | eb->h_list.l_count = | 1056 | eb->h_list.l_count = |
1056 | cpu_to_le16(ocfs2_extent_recs_per_eb(osb->sb)); | 1057 | cpu_to_le16(ocfs2_extent_recs_per_eb(osb->sb)); |
@@ -6037,7 +6038,7 @@ static void ocfs2_truncate_log_worker(struct work_struct *work) | |||
6037 | if (status < 0) | 6038 | if (status < 0) |
6038 | mlog_errno(status); | 6039 | mlog_errno(status); |
6039 | else | 6040 | else |
6040 | ocfs2_init_inode_steal_slot(osb); | 6041 | ocfs2_init_steal_slots(osb); |
6041 | 6042 | ||
6042 | mlog_exit(status); | 6043 | mlog_exit(status); |
6043 | } | 6044 | } |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 7d04c171567d..21441ddb5506 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -577,8 +577,9 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, | |||
577 | goto bail; | 577 | goto bail; |
578 | } | 578 | } |
579 | 579 | ||
580 | /* We should already CoW the refcounted extent. */ | 580 | /* We should already CoW the refcounted extent in case of create. */ |
581 | BUG_ON(ext_flags & OCFS2_EXT_REFCOUNTED); | 581 | BUG_ON(create && (ext_flags & OCFS2_EXT_REFCOUNTED)); |
582 | |||
582 | /* | 583 | /* |
583 | * get_more_blocks() expects us to describe a hole by clearing | 584 | * get_more_blocks() expects us to describe a hole by clearing |
584 | * the mapped bit on bh_result(). | 585 | * the mapped bit on bh_result(). |
diff --git a/fs/ocfs2/cluster/masklog.c b/fs/ocfs2/cluster/masklog.c index 1cd2934de615..b39da877b12f 100644 --- a/fs/ocfs2/cluster/masklog.c +++ b/fs/ocfs2/cluster/masklog.c | |||
@@ -112,6 +112,7 @@ static struct mlog_attribute mlog_attrs[MLOG_MAX_BITS] = { | |||
112 | define_mask(XATTR), | 112 | define_mask(XATTR), |
113 | define_mask(QUOTA), | 113 | define_mask(QUOTA), |
114 | define_mask(REFCOUNT), | 114 | define_mask(REFCOUNT), |
115 | define_mask(BASTS), | ||
115 | define_mask(ERROR), | 116 | define_mask(ERROR), |
116 | define_mask(NOTICE), | 117 | define_mask(NOTICE), |
117 | define_mask(KTHREAD), | 118 | define_mask(KTHREAD), |
diff --git a/fs/ocfs2/cluster/masklog.h b/fs/ocfs2/cluster/masklog.h index 9b4d11726cf2..3dfddbec32f2 100644 --- a/fs/ocfs2/cluster/masklog.h +++ b/fs/ocfs2/cluster/masklog.h | |||
@@ -114,6 +114,7 @@ | |||
114 | #define ML_XATTR 0x0000000020000000ULL /* ocfs2 extended attributes */ | 114 | #define ML_XATTR 0x0000000020000000ULL /* ocfs2 extended attributes */ |
115 | #define ML_QUOTA 0x0000000040000000ULL /* ocfs2 quota operations */ | 115 | #define ML_QUOTA 0x0000000040000000ULL /* ocfs2 quota operations */ |
116 | #define ML_REFCOUNT 0x0000000080000000ULL /* refcount tree operations */ | 116 | #define ML_REFCOUNT 0x0000000080000000ULL /* refcount tree operations */ |
117 | #define ML_BASTS 0x0000001000000000ULL /* dlmglue asts and basts */ | ||
117 | /* bits that are infrequently given and frequently matched in the high word */ | 118 | /* bits that are infrequently given and frequently matched in the high word */ |
118 | #define ML_ERROR 0x0000000100000000ULL /* sent to KERN_ERR */ | 119 | #define ML_ERROR 0x0000000100000000ULL /* sent to KERN_ERR */ |
119 | #define ML_NOTICE 0x0000000200000000ULL /* setn to KERN_NOTICE */ | 120 | #define ML_NOTICE 0x0000000200000000ULL /* setn to KERN_NOTICE */ |
@@ -194,9 +195,9 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits; | |||
194 | * previous token if args expands to nothing. | 195 | * previous token if args expands to nothing. |
195 | */ | 196 | */ |
196 | #define __mlog_printk(level, fmt, args...) \ | 197 | #define __mlog_printk(level, fmt, args...) \ |
197 | printk(level "(%u,%lu):%s:%d " fmt, task_pid_nr(current), \ | 198 | printk(level "(%s,%u,%lu):%s:%d " fmt, current->comm, \ |
198 | __mlog_cpu_guess, __PRETTY_FUNCTION__, __LINE__ , \ | 199 | task_pid_nr(current), __mlog_cpu_guess, \ |
199 | ##args) | 200 | __PRETTY_FUNCTION__, __LINE__ , ##args) |
200 | 201 | ||
201 | #define mlog(mask, fmt, args...) do { \ | 202 | #define mlog(mask, fmt, args...) do { \ |
202 | u64 __m = MLOG_MASK_PREFIX | (mask); \ | 203 | u64 __m = MLOG_MASK_PREFIX | (mask); \ |
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index a63ea4d74e67..efd77d071c80 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c | |||
@@ -2439,7 +2439,7 @@ static int ocfs2_dx_dir_attach_index(struct ocfs2_super *osb, | |||
2439 | dx_root = (struct ocfs2_dx_root_block *)dx_root_bh->b_data; | 2439 | dx_root = (struct ocfs2_dx_root_block *)dx_root_bh->b_data; |
2440 | memset(dx_root, 0, osb->sb->s_blocksize); | 2440 | memset(dx_root, 0, osb->sb->s_blocksize); |
2441 | strcpy(dx_root->dr_signature, OCFS2_DX_ROOT_SIGNATURE); | 2441 | strcpy(dx_root->dr_signature, OCFS2_DX_ROOT_SIGNATURE); |
2442 | dx_root->dr_suballoc_slot = cpu_to_le16(osb->slot_num); | 2442 | dx_root->dr_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
2443 | dx_root->dr_suballoc_bit = cpu_to_le16(dr_suballoc_bit); | 2443 | dx_root->dr_suballoc_bit = cpu_to_le16(dr_suballoc_bit); |
2444 | dx_root->dr_fs_generation = cpu_to_le32(osb->fs_generation); | 2444 | dx_root->dr_fs_generation = cpu_to_le32(osb->fs_generation); |
2445 | dx_root->dr_blkno = cpu_to_le64(dr_blkno); | 2445 | dx_root->dr_blkno = cpu_to_le64(dr_blkno); |
diff --git a/fs/ocfs2/dlm/Makefile b/fs/ocfs2/dlm/Makefile index 190361375700..dcebf0d920fa 100644 --- a/fs/ocfs2/dlm/Makefile +++ b/fs/ocfs2/dlm/Makefile | |||
@@ -1,8 +1,7 @@ | |||
1 | EXTRA_CFLAGS += -Ifs/ocfs2 | 1 | EXTRA_CFLAGS += -Ifs/ocfs2 |
2 | 2 | ||
3 | obj-$(CONFIG_OCFS2_FS_O2CB) += ocfs2_dlm.o ocfs2_dlmfs.o | 3 | obj-$(CONFIG_OCFS2_FS_O2CB) += ocfs2_dlm.o |
4 | 4 | ||
5 | ocfs2_dlm-objs := dlmdomain.o dlmdebug.o dlmthread.o dlmrecovery.o \ | 5 | ocfs2_dlm-objs := dlmdomain.o dlmdebug.o dlmthread.o dlmrecovery.o \ |
6 | dlmmaster.o dlmast.o dlmconvert.o dlmlock.o dlmunlock.o dlmver.o | 6 | dlmmaster.o dlmast.o dlmconvert.o dlmlock.o dlmunlock.o dlmver.o |
7 | 7 | ||
8 | ocfs2_dlmfs-objs := userdlm.o dlmfs.o dlmfsver.o | ||
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 344bcf90cbf4..b4f99de2caf3 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c | |||
@@ -310,7 +310,7 @@ static int dlm_recovery_thread(void *data) | |||
310 | mlog(0, "dlm thread running for %s...\n", dlm->name); | 310 | mlog(0, "dlm thread running for %s...\n", dlm->name); |
311 | 311 | ||
312 | while (!kthread_should_stop()) { | 312 | while (!kthread_should_stop()) { |
313 | if (dlm_joined(dlm)) { | 313 | if (dlm_domain_fully_joined(dlm)) { |
314 | status = dlm_do_recovery(dlm); | 314 | status = dlm_do_recovery(dlm); |
315 | if (status == -EAGAIN) { | 315 | if (status == -EAGAIN) { |
316 | /* do not sleep, recheck immediately. */ | 316 | /* do not sleep, recheck immediately. */ |
diff --git a/fs/ocfs2/dlmfs/Makefile b/fs/ocfs2/dlmfs/Makefile new file mode 100644 index 000000000000..df69b4856d0d --- /dev/null +++ b/fs/ocfs2/dlmfs/Makefile | |||
@@ -0,0 +1,5 @@ | |||
1 | EXTRA_CFLAGS += -Ifs/ocfs2 | ||
2 | |||
3 | obj-$(CONFIG_OCFS2_FS) += ocfs2_dlmfs.o | ||
4 | |||
5 | ocfs2_dlmfs-objs := userdlm.o dlmfs.o dlmfsver.o | ||
diff --git a/fs/ocfs2/dlm/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c index 02bf17808bdc..1b0de157a08c 100644 --- a/fs/ocfs2/dlm/dlmfs.c +++ b/fs/ocfs2/dlmfs/dlmfs.c | |||
@@ -43,24 +43,17 @@ | |||
43 | #include <linux/init.h> | 43 | #include <linux/init.h> |
44 | #include <linux/string.h> | 44 | #include <linux/string.h> |
45 | #include <linux/backing-dev.h> | 45 | #include <linux/backing-dev.h> |
46 | #include <linux/poll.h> | ||
46 | 47 | ||
47 | #include <asm/uaccess.h> | 48 | #include <asm/uaccess.h> |
48 | 49 | ||
49 | 50 | #include "stackglue.h" | |
50 | #include "cluster/nodemanager.h" | ||
51 | #include "cluster/heartbeat.h" | ||
52 | #include "cluster/tcp.h" | ||
53 | |||
54 | #include "dlmapi.h" | ||
55 | |||
56 | #include "userdlm.h" | 51 | #include "userdlm.h" |
57 | |||
58 | #include "dlmfsver.h" | 52 | #include "dlmfsver.h" |
59 | 53 | ||
60 | #define MLOG_MASK_PREFIX ML_DLMFS | 54 | #define MLOG_MASK_PREFIX ML_DLMFS |
61 | #include "cluster/masklog.h" | 55 | #include "cluster/masklog.h" |
62 | 56 | ||
63 | #include "ocfs2_lockingver.h" | ||
64 | 57 | ||
65 | static const struct super_operations dlmfs_ops; | 58 | static const struct super_operations dlmfs_ops; |
66 | static const struct file_operations dlmfs_file_operations; | 59 | static const struct file_operations dlmfs_file_operations; |
@@ -71,15 +64,46 @@ static struct kmem_cache *dlmfs_inode_cache; | |||
71 | 64 | ||
72 | struct workqueue_struct *user_dlm_worker; | 65 | struct workqueue_struct *user_dlm_worker; |
73 | 66 | ||
67 | |||
68 | |||
74 | /* | 69 | /* |
75 | * This is the userdlmfs locking protocol version. | 70 | * These are the ABI capabilities of dlmfs. |
71 | * | ||
72 | * Over time, dlmfs has added some features that were not part of the | ||
73 | * initial ABI. Unfortunately, some of these features are not detectable | ||
74 | * via standard usage. For example, Linux's default poll always returns | ||
75 | * POLLIN, so there is no way for a caller of poll(2) to know when dlmfs | ||
76 | * added poll support. Instead, we provide this list of new capabilities. | ||
77 | * | ||
78 | * Capabilities is a read-only attribute. We do it as a module parameter | ||
79 | * so we can discover it whether dlmfs is built in, loaded, or even not | ||
80 | * loaded. | ||
76 | * | 81 | * |
77 | * See fs/ocfs2/dlmglue.c for more details on locking versions. | 82 | * The ABI features are local to this machine's dlmfs mount. This is |
83 | * distinct from the locking protocol, which is concerned with inter-node | ||
84 | * interaction. | ||
85 | * | ||
86 | * Capabilities: | ||
87 | * - bast : POLLIN against the file descriptor of a held lock | ||
88 | * signifies a bast fired on the lock. | ||
78 | */ | 89 | */ |
79 | static const struct dlm_protocol_version user_locking_protocol = { | 90 | #define DLMFS_CAPABILITIES "bast stackglue" |
80 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | 91 | extern int param_set_dlmfs_capabilities(const char *val, |
81 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | 92 | struct kernel_param *kp) |
82 | }; | 93 | { |
94 | printk(KERN_ERR "%s: readonly parameter\n", kp->name); | ||
95 | return -EINVAL; | ||
96 | } | ||
97 | static int param_get_dlmfs_capabilities(char *buffer, | ||
98 | struct kernel_param *kp) | ||
99 | { | ||
100 | return strlcpy(buffer, DLMFS_CAPABILITIES, | ||
101 | strlen(DLMFS_CAPABILITIES) + 1); | ||
102 | } | ||
103 | module_param_call(capabilities, param_set_dlmfs_capabilities, | ||
104 | param_get_dlmfs_capabilities, NULL, 0444); | ||
105 | MODULE_PARM_DESC(capabilities, DLMFS_CAPABILITIES); | ||
106 | |||
83 | 107 | ||
84 | /* | 108 | /* |
85 | * decodes a set of open flags into a valid lock level and a set of flags. | 109 | * decodes a set of open flags into a valid lock level and a set of flags. |
@@ -179,13 +203,46 @@ static int dlmfs_file_release(struct inode *inode, | |||
179 | return 0; | 203 | return 0; |
180 | } | 204 | } |
181 | 205 | ||
206 | /* | ||
207 | * We do ->setattr() just to override size changes. Our size is the size | ||
208 | * of the LVB and nothing else. | ||
209 | */ | ||
210 | static int dlmfs_file_setattr(struct dentry *dentry, struct iattr *attr) | ||
211 | { | ||
212 | int error; | ||
213 | struct inode *inode = dentry->d_inode; | ||
214 | |||
215 | attr->ia_valid &= ~ATTR_SIZE; | ||
216 | error = inode_change_ok(inode, attr); | ||
217 | if (!error) | ||
218 | error = inode_setattr(inode, attr); | ||
219 | |||
220 | return error; | ||
221 | } | ||
222 | |||
223 | static unsigned int dlmfs_file_poll(struct file *file, poll_table *wait) | ||
224 | { | ||
225 | int event = 0; | ||
226 | struct inode *inode = file->f_path.dentry->d_inode; | ||
227 | struct dlmfs_inode_private *ip = DLMFS_I(inode); | ||
228 | |||
229 | poll_wait(file, &ip->ip_lockres.l_event, wait); | ||
230 | |||
231 | spin_lock(&ip->ip_lockres.l_lock); | ||
232 | if (ip->ip_lockres.l_flags & USER_LOCK_BLOCKED) | ||
233 | event = POLLIN | POLLRDNORM; | ||
234 | spin_unlock(&ip->ip_lockres.l_lock); | ||
235 | |||
236 | return event; | ||
237 | } | ||
238 | |||
182 | static ssize_t dlmfs_file_read(struct file *filp, | 239 | static ssize_t dlmfs_file_read(struct file *filp, |
183 | char __user *buf, | 240 | char __user *buf, |
184 | size_t count, | 241 | size_t count, |
185 | loff_t *ppos) | 242 | loff_t *ppos) |
186 | { | 243 | { |
187 | int bytes_left; | 244 | int bytes_left; |
188 | ssize_t readlen; | 245 | ssize_t readlen, got; |
189 | char *lvb_buf; | 246 | char *lvb_buf; |
190 | struct inode *inode = filp->f_path.dentry->d_inode; | 247 | struct inode *inode = filp->f_path.dentry->d_inode; |
191 | 248 | ||
@@ -211,9 +268,13 @@ static ssize_t dlmfs_file_read(struct file *filp, | |||
211 | if (!lvb_buf) | 268 | if (!lvb_buf) |
212 | return -ENOMEM; | 269 | return -ENOMEM; |
213 | 270 | ||
214 | user_dlm_read_lvb(inode, lvb_buf, readlen); | 271 | got = user_dlm_read_lvb(inode, lvb_buf, readlen); |
215 | bytes_left = __copy_to_user(buf, lvb_buf, readlen); | 272 | if (got) { |
216 | readlen -= bytes_left; | 273 | BUG_ON(got != readlen); |
274 | bytes_left = __copy_to_user(buf, lvb_buf, readlen); | ||
275 | readlen -= bytes_left; | ||
276 | } else | ||
277 | readlen = 0; | ||
217 | 278 | ||
218 | kfree(lvb_buf); | 279 | kfree(lvb_buf); |
219 | 280 | ||
@@ -272,7 +333,7 @@ static void dlmfs_init_once(void *foo) | |||
272 | struct dlmfs_inode_private *ip = | 333 | struct dlmfs_inode_private *ip = |
273 | (struct dlmfs_inode_private *) foo; | 334 | (struct dlmfs_inode_private *) foo; |
274 | 335 | ||
275 | ip->ip_dlm = NULL; | 336 | ip->ip_conn = NULL; |
276 | ip->ip_parent = NULL; | 337 | ip->ip_parent = NULL; |
277 | 338 | ||
278 | inode_init_once(&ip->ip_vfs_inode); | 339 | inode_init_once(&ip->ip_vfs_inode); |
@@ -314,14 +375,14 @@ static void dlmfs_clear_inode(struct inode *inode) | |||
314 | goto clear_fields; | 375 | goto clear_fields; |
315 | } | 376 | } |
316 | 377 | ||
317 | mlog(0, "we're a directory, ip->ip_dlm = 0x%p\n", ip->ip_dlm); | 378 | mlog(0, "we're a directory, ip->ip_conn = 0x%p\n", ip->ip_conn); |
318 | /* we must be a directory. If required, lets unregister the | 379 | /* we must be a directory. If required, lets unregister the |
319 | * dlm context now. */ | 380 | * dlm context now. */ |
320 | if (ip->ip_dlm) | 381 | if (ip->ip_conn) |
321 | user_dlm_unregister_context(ip->ip_dlm); | 382 | user_dlm_unregister(ip->ip_conn); |
322 | clear_fields: | 383 | clear_fields: |
323 | ip->ip_parent = NULL; | 384 | ip->ip_parent = NULL; |
324 | ip->ip_dlm = NULL; | 385 | ip->ip_conn = NULL; |
325 | } | 386 | } |
326 | 387 | ||
327 | static struct backing_dev_info dlmfs_backing_dev_info = { | 388 | static struct backing_dev_info dlmfs_backing_dev_info = { |
@@ -371,7 +432,7 @@ static struct inode *dlmfs_get_inode(struct inode *parent, | |||
371 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 432 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
372 | 433 | ||
373 | ip = DLMFS_I(inode); | 434 | ip = DLMFS_I(inode); |
374 | ip->ip_dlm = DLMFS_I(parent)->ip_dlm; | 435 | ip->ip_conn = DLMFS_I(parent)->ip_conn; |
375 | 436 | ||
376 | switch (mode & S_IFMT) { | 437 | switch (mode & S_IFMT) { |
377 | default: | 438 | default: |
@@ -425,13 +486,12 @@ static int dlmfs_mkdir(struct inode * dir, | |||
425 | struct inode *inode = NULL; | 486 | struct inode *inode = NULL; |
426 | struct qstr *domain = &dentry->d_name; | 487 | struct qstr *domain = &dentry->d_name; |
427 | struct dlmfs_inode_private *ip; | 488 | struct dlmfs_inode_private *ip; |
428 | struct dlm_ctxt *dlm; | 489 | struct ocfs2_cluster_connection *conn; |
429 | struct dlm_protocol_version proto = user_locking_protocol; | ||
430 | 490 | ||
431 | mlog(0, "mkdir %.*s\n", domain->len, domain->name); | 491 | mlog(0, "mkdir %.*s\n", domain->len, domain->name); |
432 | 492 | ||
433 | /* verify that we have a proper domain */ | 493 | /* verify that we have a proper domain */ |
434 | if (domain->len >= O2NM_MAX_NAME_LEN) { | 494 | if (domain->len >= GROUP_NAME_MAX) { |
435 | status = -EINVAL; | 495 | status = -EINVAL; |
436 | mlog(ML_ERROR, "invalid domain name for directory.\n"); | 496 | mlog(ML_ERROR, "invalid domain name for directory.\n"); |
437 | goto bail; | 497 | goto bail; |
@@ -446,14 +506,14 @@ static int dlmfs_mkdir(struct inode * dir, | |||
446 | 506 | ||
447 | ip = DLMFS_I(inode); | 507 | ip = DLMFS_I(inode); |
448 | 508 | ||
449 | dlm = user_dlm_register_context(domain, &proto); | 509 | conn = user_dlm_register(domain); |
450 | if (IS_ERR(dlm)) { | 510 | if (IS_ERR(conn)) { |
451 | status = PTR_ERR(dlm); | 511 | status = PTR_ERR(conn); |
452 | mlog(ML_ERROR, "Error %d could not register domain \"%.*s\"\n", | 512 | mlog(ML_ERROR, "Error %d could not register domain \"%.*s\"\n", |
453 | status, domain->len, domain->name); | 513 | status, domain->len, domain->name); |
454 | goto bail; | 514 | goto bail; |
455 | } | 515 | } |
456 | ip->ip_dlm = dlm; | 516 | ip->ip_conn = conn; |
457 | 517 | ||
458 | inc_nlink(dir); | 518 | inc_nlink(dir); |
459 | d_instantiate(dentry, inode); | 519 | d_instantiate(dentry, inode); |
@@ -549,6 +609,7 @@ static int dlmfs_fill_super(struct super_block * sb, | |||
549 | static const struct file_operations dlmfs_file_operations = { | 609 | static const struct file_operations dlmfs_file_operations = { |
550 | .open = dlmfs_file_open, | 610 | .open = dlmfs_file_open, |
551 | .release = dlmfs_file_release, | 611 | .release = dlmfs_file_release, |
612 | .poll = dlmfs_file_poll, | ||
552 | .read = dlmfs_file_read, | 613 | .read = dlmfs_file_read, |
553 | .write = dlmfs_file_write, | 614 | .write = dlmfs_file_write, |
554 | }; | 615 | }; |
@@ -576,6 +637,7 @@ static const struct super_operations dlmfs_ops = { | |||
576 | 637 | ||
577 | static const struct inode_operations dlmfs_file_inode_operations = { | 638 | static const struct inode_operations dlmfs_file_inode_operations = { |
578 | .getattr = simple_getattr, | 639 | .getattr = simple_getattr, |
640 | .setattr = dlmfs_file_setattr, | ||
579 | }; | 641 | }; |
580 | 642 | ||
581 | static int dlmfs_get_sb(struct file_system_type *fs_type, | 643 | static int dlmfs_get_sb(struct file_system_type *fs_type, |
@@ -620,6 +682,7 @@ static int __init init_dlmfs_fs(void) | |||
620 | } | 682 | } |
621 | cleanup_worker = 1; | 683 | cleanup_worker = 1; |
622 | 684 | ||
685 | user_dlm_set_locking_protocol(); | ||
623 | status = register_filesystem(&dlmfs_fs_type); | 686 | status = register_filesystem(&dlmfs_fs_type); |
624 | bail: | 687 | bail: |
625 | if (status) { | 688 | if (status) { |
diff --git a/fs/ocfs2/dlm/dlmfsver.c b/fs/ocfs2/dlmfs/dlmfsver.c index a733b3321f83..a733b3321f83 100644 --- a/fs/ocfs2/dlm/dlmfsver.c +++ b/fs/ocfs2/dlmfs/dlmfsver.c | |||
diff --git a/fs/ocfs2/dlm/dlmfsver.h b/fs/ocfs2/dlmfs/dlmfsver.h index f35eadbed25c..f35eadbed25c 100644 --- a/fs/ocfs2/dlm/dlmfsver.h +++ b/fs/ocfs2/dlmfs/dlmfsver.h | |||
diff --git a/fs/ocfs2/dlm/userdlm.c b/fs/ocfs2/dlmfs/userdlm.c index 4cb1d3dae250..0499e3fb7bdb 100644 --- a/fs/ocfs2/dlm/userdlm.c +++ b/fs/ocfs2/dlmfs/userdlm.c | |||
@@ -34,18 +34,19 @@ | |||
34 | #include <linux/types.h> | 34 | #include <linux/types.h> |
35 | #include <linux/crc32.h> | 35 | #include <linux/crc32.h> |
36 | 36 | ||
37 | 37 | #include "ocfs2_lockingver.h" | |
38 | #include "cluster/nodemanager.h" | 38 | #include "stackglue.h" |
39 | #include "cluster/heartbeat.h" | ||
40 | #include "cluster/tcp.h" | ||
41 | |||
42 | #include "dlmapi.h" | ||
43 | |||
44 | #include "userdlm.h" | 39 | #include "userdlm.h" |
45 | 40 | ||
46 | #define MLOG_MASK_PREFIX ML_DLMFS | 41 | #define MLOG_MASK_PREFIX ML_DLMFS |
47 | #include "cluster/masklog.h" | 42 | #include "cluster/masklog.h" |
48 | 43 | ||
44 | |||
45 | static inline struct user_lock_res *user_lksb_to_lock_res(struct ocfs2_dlm_lksb *lksb) | ||
46 | { | ||
47 | return container_of(lksb, struct user_lock_res, l_lksb); | ||
48 | } | ||
49 | |||
49 | static inline int user_check_wait_flag(struct user_lock_res *lockres, | 50 | static inline int user_check_wait_flag(struct user_lock_res *lockres, |
50 | int flag) | 51 | int flag) |
51 | { | 52 | { |
@@ -73,15 +74,15 @@ static inline void user_wait_on_blocked_lock(struct user_lock_res *lockres) | |||
73 | } | 74 | } |
74 | 75 | ||
75 | /* I heart container_of... */ | 76 | /* I heart container_of... */ |
76 | static inline struct dlm_ctxt * | 77 | static inline struct ocfs2_cluster_connection * |
77 | dlm_ctxt_from_user_lockres(struct user_lock_res *lockres) | 78 | cluster_connection_from_user_lockres(struct user_lock_res *lockres) |
78 | { | 79 | { |
79 | struct dlmfs_inode_private *ip; | 80 | struct dlmfs_inode_private *ip; |
80 | 81 | ||
81 | ip = container_of(lockres, | 82 | ip = container_of(lockres, |
82 | struct dlmfs_inode_private, | 83 | struct dlmfs_inode_private, |
83 | ip_lockres); | 84 | ip_lockres); |
84 | return ip->ip_dlm; | 85 | return ip->ip_conn; |
85 | } | 86 | } |
86 | 87 | ||
87 | static struct inode * | 88 | static struct inode * |
@@ -103,9 +104,9 @@ static inline void user_recover_from_dlm_error(struct user_lock_res *lockres) | |||
103 | } | 104 | } |
104 | 105 | ||
105 | #define user_log_dlm_error(_func, _stat, _lockres) do { \ | 106 | #define user_log_dlm_error(_func, _stat, _lockres) do { \ |
106 | mlog(ML_ERROR, "Dlm error \"%s\" while calling %s on " \ | 107 | mlog(ML_ERROR, "Dlm error %d while calling %s on " \ |
107 | "resource %.*s: %s\n", dlm_errname(_stat), _func, \ | 108 | "resource %.*s\n", _stat, _func, \ |
108 | _lockres->l_namelen, _lockres->l_name, dlm_errmsg(_stat)); \ | 109 | _lockres->l_namelen, _lockres->l_name); \ |
109 | } while (0) | 110 | } while (0) |
110 | 111 | ||
111 | /* WARNING: This function lives in a world where the only three lock | 112 | /* WARNING: This function lives in a world where the only three lock |
@@ -113,34 +114,35 @@ static inline void user_recover_from_dlm_error(struct user_lock_res *lockres) | |||
113 | * lock types are added. */ | 114 | * lock types are added. */ |
114 | static inline int user_highest_compat_lock_level(int level) | 115 | static inline int user_highest_compat_lock_level(int level) |
115 | { | 116 | { |
116 | int new_level = LKM_EXMODE; | 117 | int new_level = DLM_LOCK_EX; |
117 | 118 | ||
118 | if (level == LKM_EXMODE) | 119 | if (level == DLM_LOCK_EX) |
119 | new_level = LKM_NLMODE; | 120 | new_level = DLM_LOCK_NL; |
120 | else if (level == LKM_PRMODE) | 121 | else if (level == DLM_LOCK_PR) |
121 | new_level = LKM_PRMODE; | 122 | new_level = DLM_LOCK_PR; |
122 | return new_level; | 123 | return new_level; |
123 | } | 124 | } |
124 | 125 | ||
125 | static void user_ast(void *opaque) | 126 | static void user_ast(struct ocfs2_dlm_lksb *lksb) |
126 | { | 127 | { |
127 | struct user_lock_res *lockres = opaque; | 128 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
128 | struct dlm_lockstatus *lksb; | 129 | int status; |
129 | 130 | ||
130 | mlog(0, "AST fired for lockres %.*s\n", lockres->l_namelen, | 131 | mlog(ML_BASTS, "AST fired for lockres %.*s, level %d => %d\n", |
131 | lockres->l_name); | 132 | lockres->l_namelen, lockres->l_name, lockres->l_level, |
133 | lockres->l_requested); | ||
132 | 134 | ||
133 | spin_lock(&lockres->l_lock); | 135 | spin_lock(&lockres->l_lock); |
134 | 136 | ||
135 | lksb = &(lockres->l_lksb); | 137 | status = ocfs2_dlm_lock_status(&lockres->l_lksb); |
136 | if (lksb->status != DLM_NORMAL) { | 138 | if (status) { |
137 | mlog(ML_ERROR, "lksb status value of %u on lockres %.*s\n", | 139 | mlog(ML_ERROR, "lksb status value of %u on lockres %.*s\n", |
138 | lksb->status, lockres->l_namelen, lockres->l_name); | 140 | status, lockres->l_namelen, lockres->l_name); |
139 | spin_unlock(&lockres->l_lock); | 141 | spin_unlock(&lockres->l_lock); |
140 | return; | 142 | return; |
141 | } | 143 | } |
142 | 144 | ||
143 | mlog_bug_on_msg(lockres->l_requested == LKM_IVMODE, | 145 | mlog_bug_on_msg(lockres->l_requested == DLM_LOCK_IV, |
144 | "Lockres %.*s, requested ivmode. flags 0x%x\n", | 146 | "Lockres %.*s, requested ivmode. flags 0x%x\n", |
145 | lockres->l_namelen, lockres->l_name, lockres->l_flags); | 147 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
146 | 148 | ||
@@ -148,13 +150,13 @@ static void user_ast(void *opaque) | |||
148 | if (lockres->l_requested < lockres->l_level) { | 150 | if (lockres->l_requested < lockres->l_level) { |
149 | if (lockres->l_requested <= | 151 | if (lockres->l_requested <= |
150 | user_highest_compat_lock_level(lockres->l_blocking)) { | 152 | user_highest_compat_lock_level(lockres->l_blocking)) { |
151 | lockres->l_blocking = LKM_NLMODE; | 153 | lockres->l_blocking = DLM_LOCK_NL; |
152 | lockres->l_flags &= ~USER_LOCK_BLOCKED; | 154 | lockres->l_flags &= ~USER_LOCK_BLOCKED; |
153 | } | 155 | } |
154 | } | 156 | } |
155 | 157 | ||
156 | lockres->l_level = lockres->l_requested; | 158 | lockres->l_level = lockres->l_requested; |
157 | lockres->l_requested = LKM_IVMODE; | 159 | lockres->l_requested = DLM_LOCK_IV; |
158 | lockres->l_flags |= USER_LOCK_ATTACHED; | 160 | lockres->l_flags |= USER_LOCK_ATTACHED; |
159 | lockres->l_flags &= ~USER_LOCK_BUSY; | 161 | lockres->l_flags &= ~USER_LOCK_BUSY; |
160 | 162 | ||
@@ -193,11 +195,11 @@ static void __user_dlm_cond_queue_lockres(struct user_lock_res *lockres) | |||
193 | return; | 195 | return; |
194 | 196 | ||
195 | switch (lockres->l_blocking) { | 197 | switch (lockres->l_blocking) { |
196 | case LKM_EXMODE: | 198 | case DLM_LOCK_EX: |
197 | if (!lockres->l_ex_holders && !lockres->l_ro_holders) | 199 | if (!lockres->l_ex_holders && !lockres->l_ro_holders) |
198 | queue = 1; | 200 | queue = 1; |
199 | break; | 201 | break; |
200 | case LKM_PRMODE: | 202 | case DLM_LOCK_PR: |
201 | if (!lockres->l_ex_holders) | 203 | if (!lockres->l_ex_holders) |
202 | queue = 1; | 204 | queue = 1; |
203 | break; | 205 | break; |
@@ -209,12 +211,12 @@ static void __user_dlm_cond_queue_lockres(struct user_lock_res *lockres) | |||
209 | __user_dlm_queue_lockres(lockres); | 211 | __user_dlm_queue_lockres(lockres); |
210 | } | 212 | } |
211 | 213 | ||
212 | static void user_bast(void *opaque, int level) | 214 | static void user_bast(struct ocfs2_dlm_lksb *lksb, int level) |
213 | { | 215 | { |
214 | struct user_lock_res *lockres = opaque; | 216 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
215 | 217 | ||
216 | mlog(0, "Blocking AST fired for lockres %.*s. Blocking level %d\n", | 218 | mlog(ML_BASTS, "BAST fired for lockres %.*s, blocking %d, level %d\n", |
217 | lockres->l_namelen, lockres->l_name, level); | 219 | lockres->l_namelen, lockres->l_name, level, lockres->l_level); |
218 | 220 | ||
219 | spin_lock(&lockres->l_lock); | 221 | spin_lock(&lockres->l_lock); |
220 | lockres->l_flags |= USER_LOCK_BLOCKED; | 222 | lockres->l_flags |= USER_LOCK_BLOCKED; |
@@ -227,15 +229,15 @@ static void user_bast(void *opaque, int level) | |||
227 | wake_up(&lockres->l_event); | 229 | wake_up(&lockres->l_event); |
228 | } | 230 | } |
229 | 231 | ||
230 | static void user_unlock_ast(void *opaque, enum dlm_status status) | 232 | static void user_unlock_ast(struct ocfs2_dlm_lksb *lksb, int status) |
231 | { | 233 | { |
232 | struct user_lock_res *lockres = opaque; | 234 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
233 | 235 | ||
234 | mlog(0, "UNLOCK AST called on lock %.*s\n", lockres->l_namelen, | 236 | mlog(ML_BASTS, "UNLOCK AST fired for lockres %.*s, flags 0x%x\n", |
235 | lockres->l_name); | 237 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
236 | 238 | ||
237 | if (status != DLM_NORMAL && status != DLM_CANCELGRANT) | 239 | if (status) |
238 | mlog(ML_ERROR, "Dlm returns status %d\n", status); | 240 | mlog(ML_ERROR, "dlm returns status %d\n", status); |
239 | 241 | ||
240 | spin_lock(&lockres->l_lock); | 242 | spin_lock(&lockres->l_lock); |
241 | /* The teardown flag gets set early during the unlock process, | 243 | /* The teardown flag gets set early during the unlock process, |
@@ -243,7 +245,7 @@ static void user_unlock_ast(void *opaque, enum dlm_status status) | |||
243 | * for a concurrent cancel. */ | 245 | * for a concurrent cancel. */ |
244 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN | 246 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN |
245 | && !(lockres->l_flags & USER_LOCK_IN_CANCEL)) { | 247 | && !(lockres->l_flags & USER_LOCK_IN_CANCEL)) { |
246 | lockres->l_level = LKM_IVMODE; | 248 | lockres->l_level = DLM_LOCK_IV; |
247 | } else if (status == DLM_CANCELGRANT) { | 249 | } else if (status == DLM_CANCELGRANT) { |
248 | /* We tried to cancel a convert request, but it was | 250 | /* We tried to cancel a convert request, but it was |
249 | * already granted. Don't clear the busy flag - the | 251 | * already granted. Don't clear the busy flag - the |
@@ -254,7 +256,7 @@ static void user_unlock_ast(void *opaque, enum dlm_status status) | |||
254 | } else { | 256 | } else { |
255 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); | 257 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); |
256 | /* Cancel succeeded, we want to re-queue */ | 258 | /* Cancel succeeded, we want to re-queue */ |
257 | lockres->l_requested = LKM_IVMODE; /* cancel an | 259 | lockres->l_requested = DLM_LOCK_IV; /* cancel an |
258 | * upconvert | 260 | * upconvert |
259 | * request. */ | 261 | * request. */ |
260 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; | 262 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; |
@@ -271,6 +273,21 @@ out_noclear: | |||
271 | wake_up(&lockres->l_event); | 273 | wake_up(&lockres->l_event); |
272 | } | 274 | } |
273 | 275 | ||
276 | /* | ||
277 | * This is the userdlmfs locking protocol version. | ||
278 | * | ||
279 | * See fs/ocfs2/dlmglue.c for more details on locking versions. | ||
280 | */ | ||
281 | static struct ocfs2_locking_protocol user_dlm_lproto = { | ||
282 | .lp_max_version = { | ||
283 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
284 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
285 | }, | ||
286 | .lp_lock_ast = user_ast, | ||
287 | .lp_blocking_ast = user_bast, | ||
288 | .lp_unlock_ast = user_unlock_ast, | ||
289 | }; | ||
290 | |||
274 | static inline void user_dlm_drop_inode_ref(struct user_lock_res *lockres) | 291 | static inline void user_dlm_drop_inode_ref(struct user_lock_res *lockres) |
275 | { | 292 | { |
276 | struct inode *inode; | 293 | struct inode *inode; |
@@ -283,10 +300,10 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
283 | int new_level, status; | 300 | int new_level, status; |
284 | struct user_lock_res *lockres = | 301 | struct user_lock_res *lockres = |
285 | container_of(work, struct user_lock_res, l_work); | 302 | container_of(work, struct user_lock_res, l_work); |
286 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 303 | struct ocfs2_cluster_connection *conn = |
304 | cluster_connection_from_user_lockres(lockres); | ||
287 | 305 | ||
288 | mlog(0, "processing lockres %.*s\n", lockres->l_namelen, | 306 | mlog(0, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
289 | lockres->l_name); | ||
290 | 307 | ||
291 | spin_lock(&lockres->l_lock); | 308 | spin_lock(&lockres->l_lock); |
292 | 309 | ||
@@ -304,17 +321,23 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
304 | * flag, and finally we might get another bast which re-queues | 321 | * flag, and finally we might get another bast which re-queues |
305 | * us before our ast for the downconvert is called. */ | 322 | * us before our ast for the downconvert is called. */ |
306 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) { | 323 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) { |
324 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_BLOCKED\n", | ||
325 | lockres->l_namelen, lockres->l_name); | ||
307 | spin_unlock(&lockres->l_lock); | 326 | spin_unlock(&lockres->l_lock); |
308 | goto drop_ref; | 327 | goto drop_ref; |
309 | } | 328 | } |
310 | 329 | ||
311 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { | 330 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
331 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_TEARDOWN\n", | ||
332 | lockres->l_namelen, lockres->l_name); | ||
312 | spin_unlock(&lockres->l_lock); | 333 | spin_unlock(&lockres->l_lock); |
313 | goto drop_ref; | 334 | goto drop_ref; |
314 | } | 335 | } |
315 | 336 | ||
316 | if (lockres->l_flags & USER_LOCK_BUSY) { | 337 | if (lockres->l_flags & USER_LOCK_BUSY) { |
317 | if (lockres->l_flags & USER_LOCK_IN_CANCEL) { | 338 | if (lockres->l_flags & USER_LOCK_IN_CANCEL) { |
339 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_CANCEL\n", | ||
340 | lockres->l_namelen, lockres->l_name); | ||
318 | spin_unlock(&lockres->l_lock); | 341 | spin_unlock(&lockres->l_lock); |
319 | goto drop_ref; | 342 | goto drop_ref; |
320 | } | 343 | } |
@@ -322,32 +345,31 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
322 | lockres->l_flags |= USER_LOCK_IN_CANCEL; | 345 | lockres->l_flags |= USER_LOCK_IN_CANCEL; |
323 | spin_unlock(&lockres->l_lock); | 346 | spin_unlock(&lockres->l_lock); |
324 | 347 | ||
325 | status = dlmunlock(dlm, | 348 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, |
326 | &lockres->l_lksb, | 349 | DLM_LKF_CANCEL); |
327 | LKM_CANCEL, | 350 | if (status) |
328 | user_unlock_ast, | 351 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
329 | lockres); | ||
330 | if (status != DLM_NORMAL) | ||
331 | user_log_dlm_error("dlmunlock", status, lockres); | ||
332 | goto drop_ref; | 352 | goto drop_ref; |
333 | } | 353 | } |
334 | 354 | ||
335 | /* If there are still incompat holders, we can exit safely | 355 | /* If there are still incompat holders, we can exit safely |
336 | * without worrying about re-queueing this lock as that will | 356 | * without worrying about re-queueing this lock as that will |
337 | * happen on the last call to user_cluster_unlock. */ | 357 | * happen on the last call to user_cluster_unlock. */ |
338 | if ((lockres->l_blocking == LKM_EXMODE) | 358 | if ((lockres->l_blocking == DLM_LOCK_EX) |
339 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { | 359 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { |
340 | spin_unlock(&lockres->l_lock); | 360 | spin_unlock(&lockres->l_lock); |
341 | mlog(0, "can't downconvert for ex: ro = %u, ex = %u\n", | 361 | mlog(ML_BASTS, "lockres %.*s, EX/PR Holders %u,%u\n", |
342 | lockres->l_ro_holders, lockres->l_ex_holders); | 362 | lockres->l_namelen, lockres->l_name, |
363 | lockres->l_ex_holders, lockres->l_ro_holders); | ||
343 | goto drop_ref; | 364 | goto drop_ref; |
344 | } | 365 | } |
345 | 366 | ||
346 | if ((lockres->l_blocking == LKM_PRMODE) | 367 | if ((lockres->l_blocking == DLM_LOCK_PR) |
347 | && lockres->l_ex_holders) { | 368 | && lockres->l_ex_holders) { |
348 | spin_unlock(&lockres->l_lock); | 369 | spin_unlock(&lockres->l_lock); |
349 | mlog(0, "can't downconvert for pr: ex = %u\n", | 370 | mlog(ML_BASTS, "lockres %.*s, EX Holders %u\n", |
350 | lockres->l_ex_holders); | 371 | lockres->l_namelen, lockres->l_name, |
372 | lockres->l_ex_holders); | ||
351 | goto drop_ref; | 373 | goto drop_ref; |
352 | } | 374 | } |
353 | 375 | ||
@@ -355,22 +377,17 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
355 | new_level = user_highest_compat_lock_level(lockres->l_blocking); | 377 | new_level = user_highest_compat_lock_level(lockres->l_blocking); |
356 | lockres->l_requested = new_level; | 378 | lockres->l_requested = new_level; |
357 | lockres->l_flags |= USER_LOCK_BUSY; | 379 | lockres->l_flags |= USER_LOCK_BUSY; |
358 | mlog(0, "Downconvert lock from %d to %d\n", | 380 | mlog(ML_BASTS, "lockres %.*s, downconvert %d => %d\n", |
359 | lockres->l_level, new_level); | 381 | lockres->l_namelen, lockres->l_name, lockres->l_level, new_level); |
360 | spin_unlock(&lockres->l_lock); | 382 | spin_unlock(&lockres->l_lock); |
361 | 383 | ||
362 | /* need lock downconvert request now... */ | 384 | /* need lock downconvert request now... */ |
363 | status = dlmlock(dlm, | 385 | status = ocfs2_dlm_lock(conn, new_level, &lockres->l_lksb, |
364 | new_level, | 386 | DLM_LKF_CONVERT|DLM_LKF_VALBLK, |
365 | &lockres->l_lksb, | 387 | lockres->l_name, |
366 | LKM_CONVERT|LKM_VALBLK, | 388 | lockres->l_namelen); |
367 | lockres->l_name, | 389 | if (status) { |
368 | lockres->l_namelen, | 390 | user_log_dlm_error("ocfs2_dlm_lock", status, lockres); |
369 | user_ast, | ||
370 | lockres, | ||
371 | user_bast); | ||
372 | if (status != DLM_NORMAL) { | ||
373 | user_log_dlm_error("dlmlock", status, lockres); | ||
374 | user_recover_from_dlm_error(lockres); | 391 | user_recover_from_dlm_error(lockres); |
375 | } | 392 | } |
376 | 393 | ||
@@ -382,10 +399,10 @@ static inline void user_dlm_inc_holders(struct user_lock_res *lockres, | |||
382 | int level) | 399 | int level) |
383 | { | 400 | { |
384 | switch(level) { | 401 | switch(level) { |
385 | case LKM_EXMODE: | 402 | case DLM_LOCK_EX: |
386 | lockres->l_ex_holders++; | 403 | lockres->l_ex_holders++; |
387 | break; | 404 | break; |
388 | case LKM_PRMODE: | 405 | case DLM_LOCK_PR: |
389 | lockres->l_ro_holders++; | 406 | lockres->l_ro_holders++; |
390 | break; | 407 | break; |
391 | default: | 408 | default: |
@@ -410,20 +427,19 @@ int user_dlm_cluster_lock(struct user_lock_res *lockres, | |||
410 | int lkm_flags) | 427 | int lkm_flags) |
411 | { | 428 | { |
412 | int status, local_flags; | 429 | int status, local_flags; |
413 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 430 | struct ocfs2_cluster_connection *conn = |
431 | cluster_connection_from_user_lockres(lockres); | ||
414 | 432 | ||
415 | if (level != LKM_EXMODE && | 433 | if (level != DLM_LOCK_EX && |
416 | level != LKM_PRMODE) { | 434 | level != DLM_LOCK_PR) { |
417 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", | 435 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
418 | lockres->l_namelen, lockres->l_name); | 436 | lockres->l_namelen, lockres->l_name); |
419 | status = -EINVAL; | 437 | status = -EINVAL; |
420 | goto bail; | 438 | goto bail; |
421 | } | 439 | } |
422 | 440 | ||
423 | mlog(0, "lockres %.*s: asking for %s lock, passed flags = 0x%x\n", | 441 | mlog(ML_BASTS, "lockres %.*s, level %d, flags = 0x%x\n", |
424 | lockres->l_namelen, lockres->l_name, | 442 | lockres->l_namelen, lockres->l_name, level, lkm_flags); |
425 | (level == LKM_EXMODE) ? "LKM_EXMODE" : "LKM_PRMODE", | ||
426 | lkm_flags); | ||
427 | 443 | ||
428 | again: | 444 | again: |
429 | if (signal_pending(current)) { | 445 | if (signal_pending(current)) { |
@@ -457,35 +473,26 @@ again: | |||
457 | } | 473 | } |
458 | 474 | ||
459 | if (level > lockres->l_level) { | 475 | if (level > lockres->l_level) { |
460 | local_flags = lkm_flags | LKM_VALBLK; | 476 | local_flags = lkm_flags | DLM_LKF_VALBLK; |
461 | if (lockres->l_level != LKM_IVMODE) | 477 | if (lockres->l_level != DLM_LOCK_IV) |
462 | local_flags |= LKM_CONVERT; | 478 | local_flags |= DLM_LKF_CONVERT; |
463 | 479 | ||
464 | lockres->l_requested = level; | 480 | lockres->l_requested = level; |
465 | lockres->l_flags |= USER_LOCK_BUSY; | 481 | lockres->l_flags |= USER_LOCK_BUSY; |
466 | spin_unlock(&lockres->l_lock); | 482 | spin_unlock(&lockres->l_lock); |
467 | 483 | ||
468 | BUG_ON(level == LKM_IVMODE); | 484 | BUG_ON(level == DLM_LOCK_IV); |
469 | BUG_ON(level == LKM_NLMODE); | 485 | BUG_ON(level == DLM_LOCK_NL); |
470 | 486 | ||
471 | /* call dlm_lock to upgrade lock now */ | 487 | /* call dlm_lock to upgrade lock now */ |
472 | status = dlmlock(dlm, | 488 | status = ocfs2_dlm_lock(conn, level, &lockres->l_lksb, |
473 | level, | 489 | local_flags, lockres->l_name, |
474 | &lockres->l_lksb, | 490 | lockres->l_namelen); |
475 | local_flags, | 491 | if (status) { |
476 | lockres->l_name, | 492 | if ((lkm_flags & DLM_LKF_NOQUEUE) && |
477 | lockres->l_namelen, | 493 | (status != -EAGAIN)) |
478 | user_ast, | 494 | user_log_dlm_error("ocfs2_dlm_lock", |
479 | lockres, | 495 | status, lockres); |
480 | user_bast); | ||
481 | if (status != DLM_NORMAL) { | ||
482 | if ((lkm_flags & LKM_NOQUEUE) && | ||
483 | (status == DLM_NOTQUEUED)) | ||
484 | status = -EAGAIN; | ||
485 | else { | ||
486 | user_log_dlm_error("dlmlock", status, lockres); | ||
487 | status = -EINVAL; | ||
488 | } | ||
489 | user_recover_from_dlm_error(lockres); | 496 | user_recover_from_dlm_error(lockres); |
490 | goto bail; | 497 | goto bail; |
491 | } | 498 | } |
@@ -506,11 +513,11 @@ static inline void user_dlm_dec_holders(struct user_lock_res *lockres, | |||
506 | int level) | 513 | int level) |
507 | { | 514 | { |
508 | switch(level) { | 515 | switch(level) { |
509 | case LKM_EXMODE: | 516 | case DLM_LOCK_EX: |
510 | BUG_ON(!lockres->l_ex_holders); | 517 | BUG_ON(!lockres->l_ex_holders); |
511 | lockres->l_ex_holders--; | 518 | lockres->l_ex_holders--; |
512 | break; | 519 | break; |
513 | case LKM_PRMODE: | 520 | case DLM_LOCK_PR: |
514 | BUG_ON(!lockres->l_ro_holders); | 521 | BUG_ON(!lockres->l_ro_holders); |
515 | lockres->l_ro_holders--; | 522 | lockres->l_ro_holders--; |
516 | break; | 523 | break; |
@@ -522,8 +529,8 @@ static inline void user_dlm_dec_holders(struct user_lock_res *lockres, | |||
522 | void user_dlm_cluster_unlock(struct user_lock_res *lockres, | 529 | void user_dlm_cluster_unlock(struct user_lock_res *lockres, |
523 | int level) | 530 | int level) |
524 | { | 531 | { |
525 | if (level != LKM_EXMODE && | 532 | if (level != DLM_LOCK_EX && |
526 | level != LKM_PRMODE) { | 533 | level != DLM_LOCK_PR) { |
527 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", | 534 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
528 | lockres->l_namelen, lockres->l_name); | 535 | lockres->l_namelen, lockres->l_name); |
529 | return; | 536 | return; |
@@ -540,33 +547,40 @@ void user_dlm_write_lvb(struct inode *inode, | |||
540 | unsigned int len) | 547 | unsigned int len) |
541 | { | 548 | { |
542 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; | 549 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
543 | char *lvb = lockres->l_lksb.lvb; | 550 | char *lvb; |
544 | 551 | ||
545 | BUG_ON(len > DLM_LVB_LEN); | 552 | BUG_ON(len > DLM_LVB_LEN); |
546 | 553 | ||
547 | spin_lock(&lockres->l_lock); | 554 | spin_lock(&lockres->l_lock); |
548 | 555 | ||
549 | BUG_ON(lockres->l_level < LKM_EXMODE); | 556 | BUG_ON(lockres->l_level < DLM_LOCK_EX); |
557 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); | ||
550 | memcpy(lvb, val, len); | 558 | memcpy(lvb, val, len); |
551 | 559 | ||
552 | spin_unlock(&lockres->l_lock); | 560 | spin_unlock(&lockres->l_lock); |
553 | } | 561 | } |
554 | 562 | ||
555 | void user_dlm_read_lvb(struct inode *inode, | 563 | ssize_t user_dlm_read_lvb(struct inode *inode, |
556 | char *val, | 564 | char *val, |
557 | unsigned int len) | 565 | unsigned int len) |
558 | { | 566 | { |
559 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; | 567 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
560 | char *lvb = lockres->l_lksb.lvb; | 568 | char *lvb; |
569 | ssize_t ret = len; | ||
561 | 570 | ||
562 | BUG_ON(len > DLM_LVB_LEN); | 571 | BUG_ON(len > DLM_LVB_LEN); |
563 | 572 | ||
564 | spin_lock(&lockres->l_lock); | 573 | spin_lock(&lockres->l_lock); |
565 | 574 | ||
566 | BUG_ON(lockres->l_level < LKM_PRMODE); | 575 | BUG_ON(lockres->l_level < DLM_LOCK_PR); |
567 | memcpy(val, lvb, len); | 576 | if (ocfs2_dlm_lvb_valid(&lockres->l_lksb)) { |
577 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); | ||
578 | memcpy(val, lvb, len); | ||
579 | } else | ||
580 | ret = 0; | ||
568 | 581 | ||
569 | spin_unlock(&lockres->l_lock); | 582 | spin_unlock(&lockres->l_lock); |
583 | return ret; | ||
570 | } | 584 | } |
571 | 585 | ||
572 | void user_dlm_lock_res_init(struct user_lock_res *lockres, | 586 | void user_dlm_lock_res_init(struct user_lock_res *lockres, |
@@ -576,9 +590,9 @@ void user_dlm_lock_res_init(struct user_lock_res *lockres, | |||
576 | 590 | ||
577 | spin_lock_init(&lockres->l_lock); | 591 | spin_lock_init(&lockres->l_lock); |
578 | init_waitqueue_head(&lockres->l_event); | 592 | init_waitqueue_head(&lockres->l_event); |
579 | lockres->l_level = LKM_IVMODE; | 593 | lockres->l_level = DLM_LOCK_IV; |
580 | lockres->l_requested = LKM_IVMODE; | 594 | lockres->l_requested = DLM_LOCK_IV; |
581 | lockres->l_blocking = LKM_IVMODE; | 595 | lockres->l_blocking = DLM_LOCK_IV; |
582 | 596 | ||
583 | /* should have been checked before getting here. */ | 597 | /* should have been checked before getting here. */ |
584 | BUG_ON(dentry->d_name.len >= USER_DLM_LOCK_ID_MAX_LEN); | 598 | BUG_ON(dentry->d_name.len >= USER_DLM_LOCK_ID_MAX_LEN); |
@@ -592,9 +606,10 @@ void user_dlm_lock_res_init(struct user_lock_res *lockres, | |||
592 | int user_dlm_destroy_lock(struct user_lock_res *lockres) | 606 | int user_dlm_destroy_lock(struct user_lock_res *lockres) |
593 | { | 607 | { |
594 | int status = -EBUSY; | 608 | int status = -EBUSY; |
595 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 609 | struct ocfs2_cluster_connection *conn = |
610 | cluster_connection_from_user_lockres(lockres); | ||
596 | 611 | ||
597 | mlog(0, "asked to destroy %.*s\n", lockres->l_namelen, lockres->l_name); | 612 | mlog(ML_BASTS, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
598 | 613 | ||
599 | spin_lock(&lockres->l_lock); | 614 | spin_lock(&lockres->l_lock); |
600 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { | 615 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
@@ -627,14 +642,9 @@ int user_dlm_destroy_lock(struct user_lock_res *lockres) | |||
627 | lockres->l_flags |= USER_LOCK_BUSY; | 642 | lockres->l_flags |= USER_LOCK_BUSY; |
628 | spin_unlock(&lockres->l_lock); | 643 | spin_unlock(&lockres->l_lock); |
629 | 644 | ||
630 | status = dlmunlock(dlm, | 645 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, DLM_LKF_VALBLK); |
631 | &lockres->l_lksb, | 646 | if (status) { |
632 | LKM_VALBLK, | 647 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
633 | user_unlock_ast, | ||
634 | lockres); | ||
635 | if (status != DLM_NORMAL) { | ||
636 | user_log_dlm_error("dlmunlock", status, lockres); | ||
637 | status = -EINVAL; | ||
638 | goto bail; | 648 | goto bail; |
639 | } | 649 | } |
640 | 650 | ||
@@ -645,32 +655,34 @@ bail: | |||
645 | return status; | 655 | return status; |
646 | } | 656 | } |
647 | 657 | ||
648 | struct dlm_ctxt *user_dlm_register_context(struct qstr *name, | 658 | static void user_dlm_recovery_handler_noop(int node_num, |
649 | struct dlm_protocol_version *proto) | 659 | void *recovery_data) |
650 | { | 660 | { |
651 | struct dlm_ctxt *dlm; | 661 | /* We ignore recovery events */ |
652 | u32 dlm_key; | 662 | return; |
653 | char *domain; | 663 | } |
654 | |||
655 | domain = kmalloc(name->len + 1, GFP_NOFS); | ||
656 | if (!domain) { | ||
657 | mlog_errno(-ENOMEM); | ||
658 | return ERR_PTR(-ENOMEM); | ||
659 | } | ||
660 | 664 | ||
661 | dlm_key = crc32_le(0, name->name, name->len); | 665 | void user_dlm_set_locking_protocol(void) |
666 | { | ||
667 | ocfs2_stack_glue_set_max_proto_version(&user_dlm_lproto.lp_max_version); | ||
668 | } | ||
662 | 669 | ||
663 | snprintf(domain, name->len + 1, "%.*s", name->len, name->name); | 670 | struct ocfs2_cluster_connection *user_dlm_register(struct qstr *name) |
671 | { | ||
672 | int rc; | ||
673 | struct ocfs2_cluster_connection *conn; | ||
664 | 674 | ||
665 | dlm = dlm_register_domain(domain, dlm_key, proto); | 675 | rc = ocfs2_cluster_connect_agnostic(name->name, name->len, |
666 | if (IS_ERR(dlm)) | 676 | &user_dlm_lproto, |
667 | mlog_errno(PTR_ERR(dlm)); | 677 | user_dlm_recovery_handler_noop, |
678 | NULL, &conn); | ||
679 | if (rc) | ||
680 | mlog_errno(rc); | ||
668 | 681 | ||
669 | kfree(domain); | 682 | return rc ? ERR_PTR(rc) : conn; |
670 | return dlm; | ||
671 | } | 683 | } |
672 | 684 | ||
673 | void user_dlm_unregister_context(struct dlm_ctxt *dlm) | 685 | void user_dlm_unregister(struct ocfs2_cluster_connection *conn) |
674 | { | 686 | { |
675 | dlm_unregister_domain(dlm); | 687 | ocfs2_cluster_disconnect(conn, 0); |
676 | } | 688 | } |
diff --git a/fs/ocfs2/dlm/userdlm.h b/fs/ocfs2/dlmfs/userdlm.h index 0c3cc03c61fa..3b42d79531d7 100644 --- a/fs/ocfs2/dlm/userdlm.h +++ b/fs/ocfs2/dlmfs/userdlm.h | |||
@@ -57,7 +57,7 @@ struct user_lock_res { | |||
57 | int l_level; | 57 | int l_level; |
58 | unsigned int l_ro_holders; | 58 | unsigned int l_ro_holders; |
59 | unsigned int l_ex_holders; | 59 | unsigned int l_ex_holders; |
60 | struct dlm_lockstatus l_lksb; | 60 | struct ocfs2_dlm_lksb l_lksb; |
61 | 61 | ||
62 | int l_requested; | 62 | int l_requested; |
63 | int l_blocking; | 63 | int l_blocking; |
@@ -80,15 +80,15 @@ void user_dlm_cluster_unlock(struct user_lock_res *lockres, | |||
80 | void user_dlm_write_lvb(struct inode *inode, | 80 | void user_dlm_write_lvb(struct inode *inode, |
81 | const char *val, | 81 | const char *val, |
82 | unsigned int len); | 82 | unsigned int len); |
83 | void user_dlm_read_lvb(struct inode *inode, | 83 | ssize_t user_dlm_read_lvb(struct inode *inode, |
84 | char *val, | 84 | char *val, |
85 | unsigned int len); | 85 | unsigned int len); |
86 | struct dlm_ctxt *user_dlm_register_context(struct qstr *name, | 86 | struct ocfs2_cluster_connection *user_dlm_register(struct qstr *name); |
87 | struct dlm_protocol_version *proto); | 87 | void user_dlm_unregister(struct ocfs2_cluster_connection *conn); |
88 | void user_dlm_unregister_context(struct dlm_ctxt *dlm); | 88 | void user_dlm_set_locking_protocol(void); |
89 | 89 | ||
90 | struct dlmfs_inode_private { | 90 | struct dlmfs_inode_private { |
91 | struct dlm_ctxt *ip_dlm; | 91 | struct ocfs2_cluster_connection *ip_conn; |
92 | 92 | ||
93 | struct user_lock_res ip_lockres; /* unused for directories. */ | 93 | struct user_lock_res ip_lockres; /* unused for directories. */ |
94 | struct inode *ip_parent; | 94 | struct inode *ip_parent; |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index e044019cb3b1..8298608d4165 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -297,6 +297,11 @@ static inline int ocfs2_is_inode_lock(struct ocfs2_lock_res *lockres) | |||
297 | lockres->l_type == OCFS2_LOCK_TYPE_OPEN; | 297 | lockres->l_type == OCFS2_LOCK_TYPE_OPEN; |
298 | } | 298 | } |
299 | 299 | ||
300 | static inline struct ocfs2_lock_res *ocfs2_lksb_to_lock_res(struct ocfs2_dlm_lksb *lksb) | ||
301 | { | ||
302 | return container_of(lksb, struct ocfs2_lock_res, l_lksb); | ||
303 | } | ||
304 | |||
300 | static inline struct inode *ocfs2_lock_res_inode(struct ocfs2_lock_res *lockres) | 305 | static inline struct inode *ocfs2_lock_res_inode(struct ocfs2_lock_res *lockres) |
301 | { | 306 | { |
302 | BUG_ON(!ocfs2_is_inode_lock(lockres)); | 307 | BUG_ON(!ocfs2_is_inode_lock(lockres)); |
@@ -927,6 +932,10 @@ static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres, | |||
927 | lockres->l_blocking = level; | 932 | lockres->l_blocking = level; |
928 | } | 933 | } |
929 | 934 | ||
935 | mlog(ML_BASTS, "lockres %s, block %d, level %d, l_block %d, dwn %d\n", | ||
936 | lockres->l_name, level, lockres->l_level, lockres->l_blocking, | ||
937 | needs_downconvert); | ||
938 | |||
930 | if (needs_downconvert) | 939 | if (needs_downconvert) |
931 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); | 940 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); |
932 | 941 | ||
@@ -1040,18 +1049,17 @@ static unsigned int lockres_set_pending(struct ocfs2_lock_res *lockres) | |||
1040 | return lockres->l_pending_gen; | 1049 | return lockres->l_pending_gen; |
1041 | } | 1050 | } |
1042 | 1051 | ||
1043 | 1052 | static void ocfs2_blocking_ast(struct ocfs2_dlm_lksb *lksb, int level) | |
1044 | static void ocfs2_blocking_ast(void *opaque, int level) | ||
1045 | { | 1053 | { |
1046 | struct ocfs2_lock_res *lockres = opaque; | 1054 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); |
1047 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); | 1055 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); |
1048 | int needs_downconvert; | 1056 | int needs_downconvert; |
1049 | unsigned long flags; | 1057 | unsigned long flags; |
1050 | 1058 | ||
1051 | BUG_ON(level <= DLM_LOCK_NL); | 1059 | BUG_ON(level <= DLM_LOCK_NL); |
1052 | 1060 | ||
1053 | mlog(0, "BAST fired for lockres %s, blocking %d, level %d type %s\n", | 1061 | mlog(ML_BASTS, "BAST fired for lockres %s, blocking %d, level %d, " |
1054 | lockres->l_name, level, lockres->l_level, | 1062 | "type %s\n", lockres->l_name, level, lockres->l_level, |
1055 | ocfs2_lock_type_string(lockres->l_type)); | 1063 | ocfs2_lock_type_string(lockres->l_type)); |
1056 | 1064 | ||
1057 | /* | 1065 | /* |
@@ -1072,9 +1080,9 @@ static void ocfs2_blocking_ast(void *opaque, int level) | |||
1072 | ocfs2_wake_downconvert_thread(osb); | 1080 | ocfs2_wake_downconvert_thread(osb); |
1073 | } | 1081 | } |
1074 | 1082 | ||
1075 | static void ocfs2_locking_ast(void *opaque) | 1083 | static void ocfs2_locking_ast(struct ocfs2_dlm_lksb *lksb) |
1076 | { | 1084 | { |
1077 | struct ocfs2_lock_res *lockres = opaque; | 1085 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); |
1078 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); | 1086 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); |
1079 | unsigned long flags; | 1087 | unsigned long flags; |
1080 | int status; | 1088 | int status; |
@@ -1095,6 +1103,10 @@ static void ocfs2_locking_ast(void *opaque) | |||
1095 | return; | 1103 | return; |
1096 | } | 1104 | } |
1097 | 1105 | ||
1106 | mlog(ML_BASTS, "AST fired for lockres %s, action %d, unlock %d, " | ||
1107 | "level %d => %d\n", lockres->l_name, lockres->l_action, | ||
1108 | lockres->l_unlock_action, lockres->l_level, lockres->l_requested); | ||
1109 | |||
1098 | switch(lockres->l_action) { | 1110 | switch(lockres->l_action) { |
1099 | case OCFS2_AST_ATTACH: | 1111 | case OCFS2_AST_ATTACH: |
1100 | ocfs2_generic_handle_attach_action(lockres); | 1112 | ocfs2_generic_handle_attach_action(lockres); |
@@ -1107,8 +1119,8 @@ static void ocfs2_locking_ast(void *opaque) | |||
1107 | ocfs2_generic_handle_downconvert_action(lockres); | 1119 | ocfs2_generic_handle_downconvert_action(lockres); |
1108 | break; | 1120 | break; |
1109 | default: | 1121 | default: |
1110 | mlog(ML_ERROR, "lockres %s: ast fired with invalid action: %u " | 1122 | mlog(ML_ERROR, "lockres %s: AST fired with invalid action: %u, " |
1111 | "lockres flags = 0x%lx, unlock action: %u\n", | 1123 | "flags 0x%lx, unlock: %u\n", |
1112 | lockres->l_name, lockres->l_action, lockres->l_flags, | 1124 | lockres->l_name, lockres->l_action, lockres->l_flags, |
1113 | lockres->l_unlock_action); | 1125 | lockres->l_unlock_action); |
1114 | BUG(); | 1126 | BUG(); |
@@ -1134,6 +1146,88 @@ out: | |||
1134 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 1146 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
1135 | } | 1147 | } |
1136 | 1148 | ||
1149 | static void ocfs2_unlock_ast(struct ocfs2_dlm_lksb *lksb, int error) | ||
1150 | { | ||
1151 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); | ||
1152 | unsigned long flags; | ||
1153 | |||
1154 | mlog_entry_void(); | ||
1155 | |||
1156 | mlog(ML_BASTS, "UNLOCK AST fired for lockres %s, action = %d\n", | ||
1157 | lockres->l_name, lockres->l_unlock_action); | ||
1158 | |||
1159 | spin_lock_irqsave(&lockres->l_lock, flags); | ||
1160 | if (error) { | ||
1161 | mlog(ML_ERROR, "Dlm passes error %d for lock %s, " | ||
1162 | "unlock_action %d\n", error, lockres->l_name, | ||
1163 | lockres->l_unlock_action); | ||
1164 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
1165 | mlog_exit_void(); | ||
1166 | return; | ||
1167 | } | ||
1168 | |||
1169 | switch(lockres->l_unlock_action) { | ||
1170 | case OCFS2_UNLOCK_CANCEL_CONVERT: | ||
1171 | mlog(0, "Cancel convert success for %s\n", lockres->l_name); | ||
1172 | lockres->l_action = OCFS2_AST_INVALID; | ||
1173 | /* Downconvert thread may have requeued this lock, we | ||
1174 | * need to wake it. */ | ||
1175 | if (lockres->l_flags & OCFS2_LOCK_BLOCKED) | ||
1176 | ocfs2_wake_downconvert_thread(ocfs2_get_lockres_osb(lockres)); | ||
1177 | break; | ||
1178 | case OCFS2_UNLOCK_DROP_LOCK: | ||
1179 | lockres->l_level = DLM_LOCK_IV; | ||
1180 | break; | ||
1181 | default: | ||
1182 | BUG(); | ||
1183 | } | ||
1184 | |||
1185 | lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); | ||
1186 | lockres->l_unlock_action = OCFS2_UNLOCK_INVALID; | ||
1187 | wake_up(&lockres->l_event); | ||
1188 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
1189 | |||
1190 | mlog_exit_void(); | ||
1191 | } | ||
1192 | |||
1193 | /* | ||
1194 | * This is the filesystem locking protocol. It provides the lock handling | ||
1195 | * hooks for the underlying DLM. It has a maximum version number. | ||
1196 | * The version number allows interoperability with systems running at | ||
1197 | * the same major number and an equal or smaller minor number. | ||
1198 | * | ||
1199 | * Whenever the filesystem does new things with locks (adds or removes a | ||
1200 | * lock, orders them differently, does different things underneath a lock), | ||
1201 | * the version must be changed. The protocol is negotiated when joining | ||
1202 | * the dlm domain. A node may join the domain if its major version is | ||
1203 | * identical to all other nodes and its minor version is greater than | ||
1204 | * or equal to all other nodes. When its minor version is greater than | ||
1205 | * the other nodes, it will run at the minor version specified by the | ||
1206 | * other nodes. | ||
1207 | * | ||
1208 | * If a locking change is made that will not be compatible with older | ||
1209 | * versions, the major number must be increased and the minor version set | ||
1210 | * to zero. If a change merely adds a behavior that can be disabled when | ||
1211 | * speaking to older versions, the minor version must be increased. If a | ||
1212 | * change adds a fully backwards compatible change (eg, LVB changes that | ||
1213 | * are just ignored by older versions), the version does not need to be | ||
1214 | * updated. | ||
1215 | */ | ||
1216 | static struct ocfs2_locking_protocol lproto = { | ||
1217 | .lp_max_version = { | ||
1218 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
1219 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
1220 | }, | ||
1221 | .lp_lock_ast = ocfs2_locking_ast, | ||
1222 | .lp_blocking_ast = ocfs2_blocking_ast, | ||
1223 | .lp_unlock_ast = ocfs2_unlock_ast, | ||
1224 | }; | ||
1225 | |||
1226 | void ocfs2_set_locking_protocol(void) | ||
1227 | { | ||
1228 | ocfs2_stack_glue_set_max_proto_version(&lproto.lp_max_version); | ||
1229 | } | ||
1230 | |||
1137 | static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres, | 1231 | static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres, |
1138 | int convert) | 1232 | int convert) |
1139 | { | 1233 | { |
@@ -1189,8 +1283,7 @@ static int ocfs2_lock_create(struct ocfs2_super *osb, | |||
1189 | &lockres->l_lksb, | 1283 | &lockres->l_lksb, |
1190 | dlm_flags, | 1284 | dlm_flags, |
1191 | lockres->l_name, | 1285 | lockres->l_name, |
1192 | OCFS2_LOCK_ID_MAX_LEN - 1, | 1286 | OCFS2_LOCK_ID_MAX_LEN - 1); |
1193 | lockres); | ||
1194 | lockres_clear_pending(lockres, gen, osb); | 1287 | lockres_clear_pending(lockres, gen, osb); |
1195 | if (ret) { | 1288 | if (ret) { |
1196 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 1289 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -1412,7 +1505,7 @@ again: | |||
1412 | BUG_ON(level == DLM_LOCK_IV); | 1505 | BUG_ON(level == DLM_LOCK_IV); |
1413 | BUG_ON(level == DLM_LOCK_NL); | 1506 | BUG_ON(level == DLM_LOCK_NL); |
1414 | 1507 | ||
1415 | mlog(0, "lock %s, convert from %d to level = %d\n", | 1508 | mlog(ML_BASTS, "lockres %s, convert from %d to %d\n", |
1416 | lockres->l_name, lockres->l_level, level); | 1509 | lockres->l_name, lockres->l_level, level); |
1417 | 1510 | ||
1418 | /* call dlm_lock to upgrade lock now */ | 1511 | /* call dlm_lock to upgrade lock now */ |
@@ -1421,8 +1514,7 @@ again: | |||
1421 | &lockres->l_lksb, | 1514 | &lockres->l_lksb, |
1422 | lkm_flags, | 1515 | lkm_flags, |
1423 | lockres->l_name, | 1516 | lockres->l_name, |
1424 | OCFS2_LOCK_ID_MAX_LEN - 1, | 1517 | OCFS2_LOCK_ID_MAX_LEN - 1); |
1425 | lockres); | ||
1426 | lockres_clear_pending(lockres, gen, osb); | 1518 | lockres_clear_pending(lockres, gen, osb); |
1427 | if (ret) { | 1519 | if (ret) { |
1428 | if (!(lkm_flags & DLM_LKF_NOQUEUE) || | 1520 | if (!(lkm_flags & DLM_LKF_NOQUEUE) || |
@@ -1859,8 +1951,7 @@ int ocfs2_file_lock(struct file *file, int ex, int trylock) | |||
1859 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 1951 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
1860 | 1952 | ||
1861 | ret = ocfs2_dlm_lock(osb->cconn, level, &lockres->l_lksb, lkm_flags, | 1953 | ret = ocfs2_dlm_lock(osb->cconn, level, &lockres->l_lksb, lkm_flags, |
1862 | lockres->l_name, OCFS2_LOCK_ID_MAX_LEN - 1, | 1954 | lockres->l_name, OCFS2_LOCK_ID_MAX_LEN - 1); |
1863 | lockres); | ||
1864 | if (ret) { | 1955 | if (ret) { |
1865 | if (!trylock || (ret != -EAGAIN)) { | 1956 | if (!trylock || (ret != -EAGAIN)) { |
1866 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 1957 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -2989,7 +3080,7 @@ int ocfs2_dlm_init(struct ocfs2_super *osb) | |||
2989 | status = ocfs2_cluster_connect(osb->osb_cluster_stack, | 3080 | status = ocfs2_cluster_connect(osb->osb_cluster_stack, |
2990 | osb->uuid_str, | 3081 | osb->uuid_str, |
2991 | strlen(osb->uuid_str), | 3082 | strlen(osb->uuid_str), |
2992 | ocfs2_do_node_down, osb, | 3083 | &lproto, ocfs2_do_node_down, osb, |
2993 | &conn); | 3084 | &conn); |
2994 | if (status) { | 3085 | if (status) { |
2995 | mlog_errno(status); | 3086 | mlog_errno(status); |
@@ -3056,50 +3147,6 @@ void ocfs2_dlm_shutdown(struct ocfs2_super *osb, | |||
3056 | mlog_exit_void(); | 3147 | mlog_exit_void(); |
3057 | } | 3148 | } |
3058 | 3149 | ||
3059 | static void ocfs2_unlock_ast(void *opaque, int error) | ||
3060 | { | ||
3061 | struct ocfs2_lock_res *lockres = opaque; | ||
3062 | unsigned long flags; | ||
3063 | |||
3064 | mlog_entry_void(); | ||
3065 | |||
3066 | mlog(0, "UNLOCK AST called on lock %s, action = %d\n", lockres->l_name, | ||
3067 | lockres->l_unlock_action); | ||
3068 | |||
3069 | spin_lock_irqsave(&lockres->l_lock, flags); | ||
3070 | if (error) { | ||
3071 | mlog(ML_ERROR, "Dlm passes error %d for lock %s, " | ||
3072 | "unlock_action %d\n", error, lockres->l_name, | ||
3073 | lockres->l_unlock_action); | ||
3074 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
3075 | mlog_exit_void(); | ||
3076 | return; | ||
3077 | } | ||
3078 | |||
3079 | switch(lockres->l_unlock_action) { | ||
3080 | case OCFS2_UNLOCK_CANCEL_CONVERT: | ||
3081 | mlog(0, "Cancel convert success for %s\n", lockres->l_name); | ||
3082 | lockres->l_action = OCFS2_AST_INVALID; | ||
3083 | /* Downconvert thread may have requeued this lock, we | ||
3084 | * need to wake it. */ | ||
3085 | if (lockres->l_flags & OCFS2_LOCK_BLOCKED) | ||
3086 | ocfs2_wake_downconvert_thread(ocfs2_get_lockres_osb(lockres)); | ||
3087 | break; | ||
3088 | case OCFS2_UNLOCK_DROP_LOCK: | ||
3089 | lockres->l_level = DLM_LOCK_IV; | ||
3090 | break; | ||
3091 | default: | ||
3092 | BUG(); | ||
3093 | } | ||
3094 | |||
3095 | lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); | ||
3096 | lockres->l_unlock_action = OCFS2_UNLOCK_INVALID; | ||
3097 | wake_up(&lockres->l_event); | ||
3098 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
3099 | |||
3100 | mlog_exit_void(); | ||
3101 | } | ||
3102 | |||
3103 | static int ocfs2_drop_lock(struct ocfs2_super *osb, | 3150 | static int ocfs2_drop_lock(struct ocfs2_super *osb, |
3104 | struct ocfs2_lock_res *lockres) | 3151 | struct ocfs2_lock_res *lockres) |
3105 | { | 3152 | { |
@@ -3167,8 +3214,7 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb, | |||
3167 | 3214 | ||
3168 | mlog(0, "lock %s\n", lockres->l_name); | 3215 | mlog(0, "lock %s\n", lockres->l_name); |
3169 | 3216 | ||
3170 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, lkm_flags, | 3217 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, lkm_flags); |
3171 | lockres); | ||
3172 | if (ret) { | 3218 | if (ret) { |
3173 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); | 3219 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); |
3174 | mlog(ML_ERROR, "lockres flags: %lu\n", lockres->l_flags); | 3220 | mlog(ML_ERROR, "lockres flags: %lu\n", lockres->l_flags); |
@@ -3276,13 +3322,20 @@ static unsigned int ocfs2_prepare_downconvert(struct ocfs2_lock_res *lockres, | |||
3276 | BUG_ON(lockres->l_blocking <= DLM_LOCK_NL); | 3322 | BUG_ON(lockres->l_blocking <= DLM_LOCK_NL); |
3277 | 3323 | ||
3278 | if (lockres->l_level <= new_level) { | 3324 | if (lockres->l_level <= new_level) { |
3279 | mlog(ML_ERROR, "lockres->l_level (%d) <= new_level (%d)\n", | 3325 | mlog(ML_ERROR, "lockres %s, lvl %d <= %d, blcklst %d, mask %d, " |
3280 | lockres->l_level, new_level); | 3326 | "type %d, flags 0x%lx, hold %d %d, act %d %d, req %d, " |
3327 | "block %d, pgen %d\n", lockres->l_name, lockres->l_level, | ||
3328 | new_level, list_empty(&lockres->l_blocked_list), | ||
3329 | list_empty(&lockres->l_mask_waiters), lockres->l_type, | ||
3330 | lockres->l_flags, lockres->l_ro_holders, | ||
3331 | lockres->l_ex_holders, lockres->l_action, | ||
3332 | lockres->l_unlock_action, lockres->l_requested, | ||
3333 | lockres->l_blocking, lockres->l_pending_gen); | ||
3281 | BUG(); | 3334 | BUG(); |
3282 | } | 3335 | } |
3283 | 3336 | ||
3284 | mlog(0, "lock %s, new_level = %d, l_blocking = %d\n", | 3337 | mlog(ML_BASTS, "lockres %s, level %d => %d, blocking %d\n", |
3285 | lockres->l_name, new_level, lockres->l_blocking); | 3338 | lockres->l_name, lockres->l_level, new_level, lockres->l_blocking); |
3286 | 3339 | ||
3287 | lockres->l_action = OCFS2_AST_DOWNCONVERT; | 3340 | lockres->l_action = OCFS2_AST_DOWNCONVERT; |
3288 | lockres->l_requested = new_level; | 3341 | lockres->l_requested = new_level; |
@@ -3301,6 +3354,9 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb, | |||
3301 | 3354 | ||
3302 | mlog_entry_void(); | 3355 | mlog_entry_void(); |
3303 | 3356 | ||
3357 | mlog(ML_BASTS, "lockres %s, level %d => %d\n", lockres->l_name, | ||
3358 | lockres->l_level, new_level); | ||
3359 | |||
3304 | if (lvb) | 3360 | if (lvb) |
3305 | dlm_flags |= DLM_LKF_VALBLK; | 3361 | dlm_flags |= DLM_LKF_VALBLK; |
3306 | 3362 | ||
@@ -3309,8 +3365,7 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb, | |||
3309 | &lockres->l_lksb, | 3365 | &lockres->l_lksb, |
3310 | dlm_flags, | 3366 | dlm_flags, |
3311 | lockres->l_name, | 3367 | lockres->l_name, |
3312 | OCFS2_LOCK_ID_MAX_LEN - 1, | 3368 | OCFS2_LOCK_ID_MAX_LEN - 1); |
3313 | lockres); | ||
3314 | lockres_clear_pending(lockres, generation, osb); | 3369 | lockres_clear_pending(lockres, generation, osb); |
3315 | if (ret) { | 3370 | if (ret) { |
3316 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 3371 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -3331,14 +3386,12 @@ static int ocfs2_prepare_cancel_convert(struct ocfs2_super *osb, | |||
3331 | assert_spin_locked(&lockres->l_lock); | 3386 | assert_spin_locked(&lockres->l_lock); |
3332 | 3387 | ||
3333 | mlog_entry_void(); | 3388 | mlog_entry_void(); |
3334 | mlog(0, "lock %s\n", lockres->l_name); | ||
3335 | 3389 | ||
3336 | if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) { | 3390 | if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) { |
3337 | /* If we're already trying to cancel a lock conversion | 3391 | /* If we're already trying to cancel a lock conversion |
3338 | * then just drop the spinlock and allow the caller to | 3392 | * then just drop the spinlock and allow the caller to |
3339 | * requeue this lock. */ | 3393 | * requeue this lock. */ |
3340 | 3394 | mlog(ML_BASTS, "lockres %s, skip convert\n", lockres->l_name); | |
3341 | mlog(0, "Lockres %s, skip convert\n", lockres->l_name); | ||
3342 | return 0; | 3395 | return 0; |
3343 | } | 3396 | } |
3344 | 3397 | ||
@@ -3353,6 +3406,8 @@ static int ocfs2_prepare_cancel_convert(struct ocfs2_super *osb, | |||
3353 | "lock %s, invalid flags: 0x%lx\n", | 3406 | "lock %s, invalid flags: 0x%lx\n", |
3354 | lockres->l_name, lockres->l_flags); | 3407 | lockres->l_name, lockres->l_flags); |
3355 | 3408 | ||
3409 | mlog(ML_BASTS, "lockres %s\n", lockres->l_name); | ||
3410 | |||
3356 | return 1; | 3411 | return 1; |
3357 | } | 3412 | } |
3358 | 3413 | ||
@@ -3362,16 +3417,15 @@ static int ocfs2_cancel_convert(struct ocfs2_super *osb, | |||
3362 | int ret; | 3417 | int ret; |
3363 | 3418 | ||
3364 | mlog_entry_void(); | 3419 | mlog_entry_void(); |
3365 | mlog(0, "lock %s\n", lockres->l_name); | ||
3366 | 3420 | ||
3367 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, | 3421 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, |
3368 | DLM_LKF_CANCEL, lockres); | 3422 | DLM_LKF_CANCEL); |
3369 | if (ret) { | 3423 | if (ret) { |
3370 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); | 3424 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); |
3371 | ocfs2_recover_from_dlm_error(lockres, 0); | 3425 | ocfs2_recover_from_dlm_error(lockres, 0); |
3372 | } | 3426 | } |
3373 | 3427 | ||
3374 | mlog(0, "lock %s return from ocfs2_dlm_unlock\n", lockres->l_name); | 3428 | mlog(ML_BASTS, "lockres %s\n", lockres->l_name); |
3375 | 3429 | ||
3376 | mlog_exit(ret); | 3430 | mlog_exit(ret); |
3377 | return ret; | 3431 | return ret; |
@@ -3428,8 +3482,11 @@ recheck: | |||
3428 | * at the same time they set OCFS2_DLM_BUSY. They must | 3482 | * at the same time they set OCFS2_DLM_BUSY. They must |
3429 | * clear OCFS2_DLM_PENDING after dlm_lock() returns. | 3483 | * clear OCFS2_DLM_PENDING after dlm_lock() returns. |
3430 | */ | 3484 | */ |
3431 | if (lockres->l_flags & OCFS2_LOCK_PENDING) | 3485 | if (lockres->l_flags & OCFS2_LOCK_PENDING) { |
3486 | mlog(ML_BASTS, "lockres %s, ReQ: Pending\n", | ||
3487 | lockres->l_name); | ||
3432 | goto leave_requeue; | 3488 | goto leave_requeue; |
3489 | } | ||
3433 | 3490 | ||
3434 | ctl->requeue = 1; | 3491 | ctl->requeue = 1; |
3435 | ret = ocfs2_prepare_cancel_convert(osb, lockres); | 3492 | ret = ocfs2_prepare_cancel_convert(osb, lockres); |
@@ -3461,6 +3518,7 @@ recheck: | |||
3461 | */ | 3518 | */ |
3462 | if (lockres->l_level == DLM_LOCK_NL) { | 3519 | if (lockres->l_level == DLM_LOCK_NL) { |
3463 | BUG_ON(lockres->l_ex_holders || lockres->l_ro_holders); | 3520 | BUG_ON(lockres->l_ex_holders || lockres->l_ro_holders); |
3521 | mlog(ML_BASTS, "lockres %s, Aborting dc\n", lockres->l_name); | ||
3464 | lockres->l_blocking = DLM_LOCK_NL; | 3522 | lockres->l_blocking = DLM_LOCK_NL; |
3465 | lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED); | 3523 | lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED); |
3466 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 3524 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
@@ -3470,28 +3528,41 @@ recheck: | |||
3470 | /* if we're blocking an exclusive and we have *any* holders, | 3528 | /* if we're blocking an exclusive and we have *any* holders, |
3471 | * then requeue. */ | 3529 | * then requeue. */ |
3472 | if ((lockres->l_blocking == DLM_LOCK_EX) | 3530 | if ((lockres->l_blocking == DLM_LOCK_EX) |
3473 | && (lockres->l_ex_holders || lockres->l_ro_holders)) | 3531 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { |
3532 | mlog(ML_BASTS, "lockres %s, ReQ: EX/PR Holders %u,%u\n", | ||
3533 | lockres->l_name, lockres->l_ex_holders, | ||
3534 | lockres->l_ro_holders); | ||
3474 | goto leave_requeue; | 3535 | goto leave_requeue; |
3536 | } | ||
3475 | 3537 | ||
3476 | /* If it's a PR we're blocking, then only | 3538 | /* If it's a PR we're blocking, then only |
3477 | * requeue if we've got any EX holders */ | 3539 | * requeue if we've got any EX holders */ |
3478 | if (lockres->l_blocking == DLM_LOCK_PR && | 3540 | if (lockres->l_blocking == DLM_LOCK_PR && |
3479 | lockres->l_ex_holders) | 3541 | lockres->l_ex_holders) { |
3542 | mlog(ML_BASTS, "lockres %s, ReQ: EX Holders %u\n", | ||
3543 | lockres->l_name, lockres->l_ex_holders); | ||
3480 | goto leave_requeue; | 3544 | goto leave_requeue; |
3545 | } | ||
3481 | 3546 | ||
3482 | /* | 3547 | /* |
3483 | * Can we get a lock in this state if the holder counts are | 3548 | * Can we get a lock in this state if the holder counts are |
3484 | * zero? The meta data unblock code used to check this. | 3549 | * zero? The meta data unblock code used to check this. |
3485 | */ | 3550 | */ |
3486 | if ((lockres->l_ops->flags & LOCK_TYPE_REQUIRES_REFRESH) | 3551 | if ((lockres->l_ops->flags & LOCK_TYPE_REQUIRES_REFRESH) |
3487 | && (lockres->l_flags & OCFS2_LOCK_REFRESHING)) | 3552 | && (lockres->l_flags & OCFS2_LOCK_REFRESHING)) { |
3553 | mlog(ML_BASTS, "lockres %s, ReQ: Lock Refreshing\n", | ||
3554 | lockres->l_name); | ||
3488 | goto leave_requeue; | 3555 | goto leave_requeue; |
3556 | } | ||
3489 | 3557 | ||
3490 | new_level = ocfs2_highest_compat_lock_level(lockres->l_blocking); | 3558 | new_level = ocfs2_highest_compat_lock_level(lockres->l_blocking); |
3491 | 3559 | ||
3492 | if (lockres->l_ops->check_downconvert | 3560 | if (lockres->l_ops->check_downconvert |
3493 | && !lockres->l_ops->check_downconvert(lockres, new_level)) | 3561 | && !lockres->l_ops->check_downconvert(lockres, new_level)) { |
3562 | mlog(ML_BASTS, "lockres %s, ReQ: Checkpointing\n", | ||
3563 | lockres->l_name); | ||
3494 | goto leave_requeue; | 3564 | goto leave_requeue; |
3565 | } | ||
3495 | 3566 | ||
3496 | /* If we get here, then we know that there are no more | 3567 | /* If we get here, then we know that there are no more |
3497 | * incompatible holders (and anyone asking for an incompatible | 3568 | * incompatible holders (and anyone asking for an incompatible |
@@ -3509,13 +3580,19 @@ recheck: | |||
3509 | 3580 | ||
3510 | ctl->unblock_action = lockres->l_ops->downconvert_worker(lockres, blocking); | 3581 | ctl->unblock_action = lockres->l_ops->downconvert_worker(lockres, blocking); |
3511 | 3582 | ||
3512 | if (ctl->unblock_action == UNBLOCK_STOP_POST) | 3583 | if (ctl->unblock_action == UNBLOCK_STOP_POST) { |
3584 | mlog(ML_BASTS, "lockres %s, UNBLOCK_STOP_POST\n", | ||
3585 | lockres->l_name); | ||
3513 | goto leave; | 3586 | goto leave; |
3587 | } | ||
3514 | 3588 | ||
3515 | spin_lock_irqsave(&lockres->l_lock, flags); | 3589 | spin_lock_irqsave(&lockres->l_lock, flags); |
3516 | if ((blocking != lockres->l_blocking) || (level != lockres->l_level)) { | 3590 | if ((blocking != lockres->l_blocking) || (level != lockres->l_level)) { |
3517 | /* If this changed underneath us, then we can't drop | 3591 | /* If this changed underneath us, then we can't drop |
3518 | * it just yet. */ | 3592 | * it just yet. */ |
3593 | mlog(ML_BASTS, "lockres %s, block=%d:%d, level=%d:%d, " | ||
3594 | "Recheck\n", lockres->l_name, blocking, | ||
3595 | lockres->l_blocking, level, lockres->l_level); | ||
3519 | goto recheck; | 3596 | goto recheck; |
3520 | } | 3597 | } |
3521 | 3598 | ||
@@ -3910,45 +3987,6 @@ void ocfs2_refcount_unlock(struct ocfs2_refcount_tree *ref_tree, int ex) | |||
3910 | ocfs2_cluster_unlock(osb, lockres, level); | 3987 | ocfs2_cluster_unlock(osb, lockres, level); |
3911 | } | 3988 | } |
3912 | 3989 | ||
3913 | /* | ||
3914 | * This is the filesystem locking protocol. It provides the lock handling | ||
3915 | * hooks for the underlying DLM. It has a maximum version number. | ||
3916 | * The version number allows interoperability with systems running at | ||
3917 | * the same major number and an equal or smaller minor number. | ||
3918 | * | ||
3919 | * Whenever the filesystem does new things with locks (adds or removes a | ||
3920 | * lock, orders them differently, does different things underneath a lock), | ||
3921 | * the version must be changed. The protocol is negotiated when joining | ||
3922 | * the dlm domain. A node may join the domain if its major version is | ||
3923 | * identical to all other nodes and its minor version is greater than | ||
3924 | * or equal to all other nodes. When its minor version is greater than | ||
3925 | * the other nodes, it will run at the minor version specified by the | ||
3926 | * other nodes. | ||
3927 | * | ||
3928 | * If a locking change is made that will not be compatible with older | ||
3929 | * versions, the major number must be increased and the minor version set | ||
3930 | * to zero. If a change merely adds a behavior that can be disabled when | ||
3931 | * speaking to older versions, the minor version must be increased. If a | ||
3932 | * change adds a fully backwards compatible change (eg, LVB changes that | ||
3933 | * are just ignored by older versions), the version does not need to be | ||
3934 | * updated. | ||
3935 | */ | ||
3936 | static struct ocfs2_locking_protocol lproto = { | ||
3937 | .lp_max_version = { | ||
3938 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
3939 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
3940 | }, | ||
3941 | .lp_lock_ast = ocfs2_locking_ast, | ||
3942 | .lp_blocking_ast = ocfs2_blocking_ast, | ||
3943 | .lp_unlock_ast = ocfs2_unlock_ast, | ||
3944 | }; | ||
3945 | |||
3946 | void ocfs2_set_locking_protocol(void) | ||
3947 | { | ||
3948 | ocfs2_stack_glue_set_locking_protocol(&lproto); | ||
3949 | } | ||
3950 | |||
3951 | |||
3952 | static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, | 3990 | static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, |
3953 | struct ocfs2_lock_res *lockres) | 3991 | struct ocfs2_lock_res *lockres) |
3954 | { | 3992 | { |
@@ -3965,7 +4003,7 @@ static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, | |||
3965 | BUG_ON(!lockres); | 4003 | BUG_ON(!lockres); |
3966 | BUG_ON(!lockres->l_ops); | 4004 | BUG_ON(!lockres->l_ops); |
3967 | 4005 | ||
3968 | mlog(0, "lockres %s blocked.\n", lockres->l_name); | 4006 | mlog(ML_BASTS, "lockres %s blocked\n", lockres->l_name); |
3969 | 4007 | ||
3970 | /* Detect whether a lock has been marked as going away while | 4008 | /* Detect whether a lock has been marked as going away while |
3971 | * the downconvert thread was processing other things. A lock can | 4009 | * the downconvert thread was processing other things. A lock can |
@@ -3988,7 +4026,7 @@ unqueue: | |||
3988 | } else | 4026 | } else |
3989 | ocfs2_schedule_blocked_lock(osb, lockres); | 4027 | ocfs2_schedule_blocked_lock(osb, lockres); |
3990 | 4028 | ||
3991 | mlog(0, "lockres %s, requeue = %s.\n", lockres->l_name, | 4029 | mlog(ML_BASTS, "lockres %s, requeue = %s.\n", lockres->l_name, |
3992 | ctl.requeue ? "yes" : "no"); | 4030 | ctl.requeue ? "yes" : "no"); |
3993 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 4031 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
3994 | 4032 | ||
@@ -4010,7 +4048,7 @@ static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, | |||
4010 | /* Do not schedule a lock for downconvert when it's on | 4048 | /* Do not schedule a lock for downconvert when it's on |
4011 | * the way to destruction - any nodes wanting access | 4049 | * the way to destruction - any nodes wanting access |
4012 | * to the resource will get it soon. */ | 4050 | * to the resource will get it soon. */ |
4013 | mlog(0, "Lockres %s won't be scheduled: flags 0x%lx\n", | 4051 | mlog(ML_BASTS, "lockres %s won't be scheduled: flags 0x%lx\n", |
4014 | lockres->l_name, lockres->l_flags); | 4052 | lockres->l_name, lockres->l_flags); |
4015 | return; | 4053 | return; |
4016 | } | 4054 | } |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 364105291282..17947dc8341e 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
@@ -997,10 +997,9 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
997 | } | 997 | } |
998 | 998 | ||
999 | if (size_change && attr->ia_size != i_size_read(inode)) { | 999 | if (size_change && attr->ia_size != i_size_read(inode)) { |
1000 | if (attr->ia_size > sb->s_maxbytes) { | 1000 | status = inode_newsize_ok(inode, attr->ia_size); |
1001 | status = -EFBIG; | 1001 | if (status) |
1002 | goto bail_unlock; | 1002 | goto bail_unlock; |
1003 | } | ||
1004 | 1003 | ||
1005 | if (i_size_read(inode) > attr->ia_size) { | 1004 | if (i_size_read(inode) > attr->ia_size) { |
1006 | if (ocfs2_should_order_data(inode)) { | 1005 | if (ocfs2_should_order_data(inode)) { |
@@ -1840,6 +1839,8 @@ static int ocfs2_prepare_inode_for_write(struct dentry *dentry, | |||
1840 | &meta_level); | 1839 | &meta_level); |
1841 | if (has_refcount) | 1840 | if (has_refcount) |
1842 | *has_refcount = 1; | 1841 | *has_refcount = 1; |
1842 | if (direct_io) | ||
1843 | *direct_io = 0; | ||
1843 | } | 1844 | } |
1844 | 1845 | ||
1845 | if (ret < 0) { | 1846 | if (ret < 0) { |
@@ -1863,10 +1864,6 @@ static int ocfs2_prepare_inode_for_write(struct dentry *dentry, | |||
1863 | break; | 1864 | break; |
1864 | } | 1865 | } |
1865 | 1866 | ||
1866 | if (has_refcount && *has_refcount == 1) { | ||
1867 | *direct_io = 0; | ||
1868 | break; | ||
1869 | } | ||
1870 | /* | 1867 | /* |
1871 | * Allowing concurrent direct writes means | 1868 | * Allowing concurrent direct writes means |
1872 | * i_size changes wouldn't be synchronized, so | 1869 | * i_size changes wouldn't be synchronized, so |
@@ -2047,7 +2044,7 @@ out_dio: | |||
2047 | * async dio is going to do it in the future or an end_io after an | 2044 | * async dio is going to do it in the future or an end_io after an |
2048 | * error has already done it. | 2045 | * error has already done it. |
2049 | */ | 2046 | */ |
2050 | if (ret == -EIOCBQUEUED || !ocfs2_iocb_is_rw_locked(iocb)) { | 2047 | if ((ret == -EIOCBQUEUED) || (!ocfs2_iocb_is_rw_locked(iocb))) { |
2051 | rw_level = -1; | 2048 | rw_level = -1; |
2052 | have_alloc_sem = 0; | 2049 | have_alloc_sem = 0; |
2053 | } | 2050 | } |
diff --git a/fs/ocfs2/ioctl.h b/fs/ocfs2/ioctl.h index cf9a5ee30fef..0cd5323bd3f0 100644 --- a/fs/ocfs2/ioctl.h +++ b/fs/ocfs2/ioctl.h | |||
@@ -7,10 +7,10 @@ | |||
7 | * | 7 | * |
8 | */ | 8 | */ |
9 | 9 | ||
10 | #ifndef OCFS2_IOCTL_H | 10 | #ifndef OCFS2_IOCTL_PROTO_H |
11 | #define OCFS2_IOCTL_H | 11 | #define OCFS2_IOCTL_PROTO_H |
12 | 12 | ||
13 | long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); | 13 | long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); |
14 | long ocfs2_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg); | 14 | long ocfs2_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg); |
15 | 15 | ||
16 | #endif /* OCFS2_IOCTL_H */ | 16 | #endif /* OCFS2_IOCTL_PROTO_H */ |
diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c index ac10f83edb95..ca992d91f511 100644 --- a/fs/ocfs2/localalloc.c +++ b/fs/ocfs2/localalloc.c | |||
@@ -476,7 +476,7 @@ out_mutex: | |||
476 | 476 | ||
477 | out: | 477 | out: |
478 | if (!status) | 478 | if (!status) |
479 | ocfs2_init_inode_steal_slot(osb); | 479 | ocfs2_init_steal_slots(osb); |
480 | mlog_exit(status); | 480 | mlog_exit(status); |
481 | return status; | 481 | return status; |
482 | } | 482 | } |
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h index 740f448041e2..1238b491db90 100644 --- a/fs/ocfs2/ocfs2.h +++ b/fs/ocfs2/ocfs2.h | |||
@@ -42,6 +42,7 @@ | |||
42 | 42 | ||
43 | #include "ocfs2_fs.h" | 43 | #include "ocfs2_fs.h" |
44 | #include "ocfs2_lockid.h" | 44 | #include "ocfs2_lockid.h" |
45 | #include "ocfs2_ioctl.h" | ||
45 | 46 | ||
46 | /* For struct ocfs2_blockcheck_stats */ | 47 | /* For struct ocfs2_blockcheck_stats */ |
47 | #include "blockcheck.h" | 48 | #include "blockcheck.h" |
@@ -159,7 +160,7 @@ struct ocfs2_lock_res { | |||
159 | int l_level; | 160 | int l_level; |
160 | unsigned int l_ro_holders; | 161 | unsigned int l_ro_holders; |
161 | unsigned int l_ex_holders; | 162 | unsigned int l_ex_holders; |
162 | union ocfs2_dlm_lksb l_lksb; | 163 | struct ocfs2_dlm_lksb l_lksb; |
163 | 164 | ||
164 | /* used from AST/BAST funcs. */ | 165 | /* used from AST/BAST funcs. */ |
165 | enum ocfs2_ast_action l_action; | 166 | enum ocfs2_ast_action l_action; |
@@ -305,7 +306,9 @@ struct ocfs2_super | |||
305 | u32 s_next_generation; | 306 | u32 s_next_generation; |
306 | unsigned long osb_flags; | 307 | unsigned long osb_flags; |
307 | s16 s_inode_steal_slot; | 308 | s16 s_inode_steal_slot; |
309 | s16 s_meta_steal_slot; | ||
308 | atomic_t s_num_inodes_stolen; | 310 | atomic_t s_num_inodes_stolen; |
311 | atomic_t s_num_meta_stolen; | ||
309 | 312 | ||
310 | unsigned long s_mount_opt; | 313 | unsigned long s_mount_opt; |
311 | unsigned int s_atime_quantum; | 314 | unsigned int s_atime_quantum; |
@@ -760,33 +763,6 @@ static inline unsigned int ocfs2_megabytes_to_clusters(struct super_block *sb, | |||
760 | return megs << (20 - OCFS2_SB(sb)->s_clustersize_bits); | 763 | return megs << (20 - OCFS2_SB(sb)->s_clustersize_bits); |
761 | } | 764 | } |
762 | 765 | ||
763 | static inline void ocfs2_init_inode_steal_slot(struct ocfs2_super *osb) | ||
764 | { | ||
765 | spin_lock(&osb->osb_lock); | ||
766 | osb->s_inode_steal_slot = OCFS2_INVALID_SLOT; | ||
767 | spin_unlock(&osb->osb_lock); | ||
768 | atomic_set(&osb->s_num_inodes_stolen, 0); | ||
769 | } | ||
770 | |||
771 | static inline void ocfs2_set_inode_steal_slot(struct ocfs2_super *osb, | ||
772 | s16 slot) | ||
773 | { | ||
774 | spin_lock(&osb->osb_lock); | ||
775 | osb->s_inode_steal_slot = slot; | ||
776 | spin_unlock(&osb->osb_lock); | ||
777 | } | ||
778 | |||
779 | static inline s16 ocfs2_get_inode_steal_slot(struct ocfs2_super *osb) | ||
780 | { | ||
781 | s16 slot; | ||
782 | |||
783 | spin_lock(&osb->osb_lock); | ||
784 | slot = osb->s_inode_steal_slot; | ||
785 | spin_unlock(&osb->osb_lock); | ||
786 | |||
787 | return slot; | ||
788 | } | ||
789 | |||
790 | #define ocfs2_set_bit ext2_set_bit | 766 | #define ocfs2_set_bit ext2_set_bit |
791 | #define ocfs2_clear_bit ext2_clear_bit | 767 | #define ocfs2_clear_bit ext2_clear_bit |
792 | #define ocfs2_test_bit ext2_test_bit | 768 | #define ocfs2_test_bit ext2_test_bit |
diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 7638a38c32bc..bb37218a7978 100644 --- a/fs/ocfs2/ocfs2_fs.h +++ b/fs/ocfs2/ocfs2_fs.h | |||
@@ -254,63 +254,6 @@ | |||
254 | * refcount tree */ | 254 | * refcount tree */ |
255 | 255 | ||
256 | /* | 256 | /* |
257 | * ioctl commands | ||
258 | */ | ||
259 | #define OCFS2_IOC_GETFLAGS _IOR('f', 1, long) | ||
260 | #define OCFS2_IOC_SETFLAGS _IOW('f', 2, long) | ||
261 | #define OCFS2_IOC32_GETFLAGS _IOR('f', 1, int) | ||
262 | #define OCFS2_IOC32_SETFLAGS _IOW('f', 2, int) | ||
263 | |||
264 | /* | ||
265 | * Space reservation / allocation / free ioctls and argument structure | ||
266 | * are designed to be compatible with XFS. | ||
267 | * | ||
268 | * ALLOCSP* and FREESP* are not and will never be supported, but are | ||
269 | * included here for completeness. | ||
270 | */ | ||
271 | struct ocfs2_space_resv { | ||
272 | __s16 l_type; | ||
273 | __s16 l_whence; | ||
274 | __s64 l_start; | ||
275 | __s64 l_len; /* len == 0 means until end of file */ | ||
276 | __s32 l_sysid; | ||
277 | __u32 l_pid; | ||
278 | __s32 l_pad[4]; /* reserve area */ | ||
279 | }; | ||
280 | |||
281 | #define OCFS2_IOC_ALLOCSP _IOW ('X', 10, struct ocfs2_space_resv) | ||
282 | #define OCFS2_IOC_FREESP _IOW ('X', 11, struct ocfs2_space_resv) | ||
283 | #define OCFS2_IOC_RESVSP _IOW ('X', 40, struct ocfs2_space_resv) | ||
284 | #define OCFS2_IOC_UNRESVSP _IOW ('X', 41, struct ocfs2_space_resv) | ||
285 | #define OCFS2_IOC_ALLOCSP64 _IOW ('X', 36, struct ocfs2_space_resv) | ||
286 | #define OCFS2_IOC_FREESP64 _IOW ('X', 37, struct ocfs2_space_resv) | ||
287 | #define OCFS2_IOC_RESVSP64 _IOW ('X', 42, struct ocfs2_space_resv) | ||
288 | #define OCFS2_IOC_UNRESVSP64 _IOW ('X', 43, struct ocfs2_space_resv) | ||
289 | |||
290 | /* Used to pass group descriptor data when online resize is done */ | ||
291 | struct ocfs2_new_group_input { | ||
292 | __u64 group; /* Group descriptor's blkno. */ | ||
293 | __u32 clusters; /* Total number of clusters in this group */ | ||
294 | __u32 frees; /* Total free clusters in this group */ | ||
295 | __u16 chain; /* Chain for this group */ | ||
296 | __u16 reserved1; | ||
297 | __u32 reserved2; | ||
298 | }; | ||
299 | |||
300 | #define OCFS2_IOC_GROUP_EXTEND _IOW('o', 1, int) | ||
301 | #define OCFS2_IOC_GROUP_ADD _IOW('o', 2,struct ocfs2_new_group_input) | ||
302 | #define OCFS2_IOC_GROUP_ADD64 _IOW('o', 3,struct ocfs2_new_group_input) | ||
303 | |||
304 | /* Used to pass 2 file names to reflink. */ | ||
305 | struct reflink_arguments { | ||
306 | __u64 old_path; | ||
307 | __u64 new_path; | ||
308 | __u64 preserve; | ||
309 | }; | ||
310 | #define OCFS2_IOC_REFLINK _IOW('o', 4, struct reflink_arguments) | ||
311 | |||
312 | |||
313 | /* | ||
314 | * Journal Flags (ocfs2_dinode.id1.journal1.i_flags) | 257 | * Journal Flags (ocfs2_dinode.id1.journal1.i_flags) |
315 | */ | 258 | */ |
316 | #define OCFS2_JOURNAL_DIRTY_FL (0x00000001) /* Journal needs recovery */ | 259 | #define OCFS2_JOURNAL_DIRTY_FL (0x00000001) /* Journal needs recovery */ |
diff --git a/fs/ocfs2/ocfs2_ioctl.h b/fs/ocfs2/ocfs2_ioctl.h new file mode 100644 index 000000000000..2d3420af1a83 --- /dev/null +++ b/fs/ocfs2/ocfs2_ioctl.h | |||
@@ -0,0 +1,79 @@ | |||
1 | /* -*- mode: c; c-basic-offset: 8; -*- | ||
2 | * vim: noexpandtab sw=8 ts=8 sts=0: | ||
3 | * | ||
4 | * ocfs2_ioctl.h | ||
5 | * | ||
6 | * Defines OCFS2 ioctls. | ||
7 | * | ||
8 | * Copyright (C) 2010 Oracle. All rights reserved. | ||
9 | * | ||
10 | * This program is free software; you can redistribute it and/or | ||
11 | * modify it under the terms of the GNU General Public | ||
12 | * License, version 2, as published by the Free Software Foundation. | ||
13 | * | ||
14 | * This program is distributed in the hope that it will be useful, | ||
15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
17 | * General Public License for more details. | ||
18 | */ | ||
19 | |||
20 | #ifndef OCFS2_IOCTL_H | ||
21 | #define OCFS2_IOCTL_H | ||
22 | |||
23 | /* | ||
24 | * ioctl commands | ||
25 | */ | ||
26 | #define OCFS2_IOC_GETFLAGS _IOR('f', 1, long) | ||
27 | #define OCFS2_IOC_SETFLAGS _IOW('f', 2, long) | ||
28 | #define OCFS2_IOC32_GETFLAGS _IOR('f', 1, int) | ||
29 | #define OCFS2_IOC32_SETFLAGS _IOW('f', 2, int) | ||
30 | |||
31 | /* | ||
32 | * Space reservation / allocation / free ioctls and argument structure | ||
33 | * are designed to be compatible with XFS. | ||
34 | * | ||
35 | * ALLOCSP* and FREESP* are not and will never be supported, but are | ||
36 | * included here for completeness. | ||
37 | */ | ||
38 | struct ocfs2_space_resv { | ||
39 | __s16 l_type; | ||
40 | __s16 l_whence; | ||
41 | __s64 l_start; | ||
42 | __s64 l_len; /* len == 0 means until end of file */ | ||
43 | __s32 l_sysid; | ||
44 | __u32 l_pid; | ||
45 | __s32 l_pad[4]; /* reserve area */ | ||
46 | }; | ||
47 | |||
48 | #define OCFS2_IOC_ALLOCSP _IOW ('X', 10, struct ocfs2_space_resv) | ||
49 | #define OCFS2_IOC_FREESP _IOW ('X', 11, struct ocfs2_space_resv) | ||
50 | #define OCFS2_IOC_RESVSP _IOW ('X', 40, struct ocfs2_space_resv) | ||
51 | #define OCFS2_IOC_UNRESVSP _IOW ('X', 41, struct ocfs2_space_resv) | ||
52 | #define OCFS2_IOC_ALLOCSP64 _IOW ('X', 36, struct ocfs2_space_resv) | ||
53 | #define OCFS2_IOC_FREESP64 _IOW ('X', 37, struct ocfs2_space_resv) | ||
54 | #define OCFS2_IOC_RESVSP64 _IOW ('X', 42, struct ocfs2_space_resv) | ||
55 | #define OCFS2_IOC_UNRESVSP64 _IOW ('X', 43, struct ocfs2_space_resv) | ||
56 | |||
57 | /* Used to pass group descriptor data when online resize is done */ | ||
58 | struct ocfs2_new_group_input { | ||
59 | __u64 group; /* Group descriptor's blkno. */ | ||
60 | __u32 clusters; /* Total number of clusters in this group */ | ||
61 | __u32 frees; /* Total free clusters in this group */ | ||
62 | __u16 chain; /* Chain for this group */ | ||
63 | __u16 reserved1; | ||
64 | __u32 reserved2; | ||
65 | }; | ||
66 | |||
67 | #define OCFS2_IOC_GROUP_EXTEND _IOW('o', 1, int) | ||
68 | #define OCFS2_IOC_GROUP_ADD _IOW('o', 2,struct ocfs2_new_group_input) | ||
69 | #define OCFS2_IOC_GROUP_ADD64 _IOW('o', 3,struct ocfs2_new_group_input) | ||
70 | |||
71 | /* Used to pass 2 file names to reflink. */ | ||
72 | struct reflink_arguments { | ||
73 | __u64 old_path; | ||
74 | __u64 new_path; | ||
75 | __u64 preserve; | ||
76 | }; | ||
77 | #define OCFS2_IOC_REFLINK _IOW('o', 4, struct reflink_arguments) | ||
78 | |||
79 | #endif /* OCFS2_IOCTL_H */ | ||
diff --git a/fs/ocfs2/ocfs2_lockingver.h b/fs/ocfs2/ocfs2_lockingver.h index 82d5eeac0fff..2e45c8d2ea7e 100644 --- a/fs/ocfs2/ocfs2_lockingver.h +++ b/fs/ocfs2/ocfs2_lockingver.h | |||
@@ -23,6 +23,8 @@ | |||
23 | /* | 23 | /* |
24 | * The protocol version for ocfs2 cluster locking. See dlmglue.c for | 24 | * The protocol version for ocfs2 cluster locking. See dlmglue.c for |
25 | * more details. | 25 | * more details. |
26 | * | ||
27 | * 1.0 - Initial locking version from ocfs2 1.4. | ||
26 | */ | 28 | */ |
27 | #define OCFS2_LOCKING_PROTOCOL_MAJOR 1 | 29 | #define OCFS2_LOCKING_PROTOCOL_MAJOR 1 |
28 | #define OCFS2_LOCKING_PROTOCOL_MINOR 0 | 30 | #define OCFS2_LOCKING_PROTOCOL_MINOR 0 |
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index f3ae10cde841..9e96921dffda 100644 --- a/fs/ocfs2/refcounttree.c +++ b/fs/ocfs2/refcounttree.c | |||
@@ -626,7 +626,7 @@ static int ocfs2_create_refcount_tree(struct inode *inode, | |||
626 | rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 626 | rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
627 | memset(rb, 0, inode->i_sb->s_blocksize); | 627 | memset(rb, 0, inode->i_sb->s_blocksize); |
628 | strcpy((void *)rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); | 628 | strcpy((void *)rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); |
629 | rb->rf_suballoc_slot = cpu_to_le16(osb->slot_num); | 629 | rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
630 | rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 630 | rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
631 | rb->rf_fs_generation = cpu_to_le32(osb->fs_generation); | 631 | rb->rf_fs_generation = cpu_to_le32(osb->fs_generation); |
632 | rb->rf_blkno = cpu_to_le64(first_blkno); | 632 | rb->rf_blkno = cpu_to_le64(first_blkno); |
@@ -1330,7 +1330,7 @@ static int ocfs2_expand_inline_ref_root(handle_t *handle, | |||
1330 | memcpy(new_bh->b_data, ref_root_bh->b_data, sb->s_blocksize); | 1330 | memcpy(new_bh->b_data, ref_root_bh->b_data, sb->s_blocksize); |
1331 | 1331 | ||
1332 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 1332 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
1333 | new_rb->rf_suballoc_slot = cpu_to_le16(OCFS2_SB(sb)->slot_num); | 1333 | new_rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
1334 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1334 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1335 | new_rb->rf_blkno = cpu_to_le64(blkno); | 1335 | new_rb->rf_blkno = cpu_to_le64(blkno); |
1336 | new_rb->rf_cpos = cpu_to_le32(0); | 1336 | new_rb->rf_cpos = cpu_to_le32(0); |
@@ -1576,7 +1576,7 @@ static int ocfs2_new_leaf_refcount_block(handle_t *handle, | |||
1576 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 1576 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
1577 | memset(new_rb, 0, sb->s_blocksize); | 1577 | memset(new_rb, 0, sb->s_blocksize); |
1578 | strcpy((void *)new_rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); | 1578 | strcpy((void *)new_rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); |
1579 | new_rb->rf_suballoc_slot = cpu_to_le16(OCFS2_SB(sb)->slot_num); | 1579 | new_rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
1580 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1580 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1581 | new_rb->rf_fs_generation = cpu_to_le32(OCFS2_SB(sb)->fs_generation); | 1581 | new_rb->rf_fs_generation = cpu_to_le32(OCFS2_SB(sb)->fs_generation); |
1582 | new_rb->rf_blkno = cpu_to_le64(blkno); | 1582 | new_rb->rf_blkno = cpu_to_le64(blkno); |
diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 3038c92af493..7020e1253ffa 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c | |||
@@ -161,24 +161,23 @@ static int dlm_status_to_errno(enum dlm_status status) | |||
161 | 161 | ||
162 | static void o2dlm_lock_ast_wrapper(void *astarg) | 162 | static void o2dlm_lock_ast_wrapper(void *astarg) |
163 | { | 163 | { |
164 | BUG_ON(o2cb_stack.sp_proto == NULL); | 164 | struct ocfs2_dlm_lksb *lksb = astarg; |
165 | 165 | ||
166 | o2cb_stack.sp_proto->lp_lock_ast(astarg); | 166 | lksb->lksb_conn->cc_proto->lp_lock_ast(lksb); |
167 | } | 167 | } |
168 | 168 | ||
169 | static void o2dlm_blocking_ast_wrapper(void *astarg, int level) | 169 | static void o2dlm_blocking_ast_wrapper(void *astarg, int level) |
170 | { | 170 | { |
171 | BUG_ON(o2cb_stack.sp_proto == NULL); | 171 | struct ocfs2_dlm_lksb *lksb = astarg; |
172 | 172 | ||
173 | o2cb_stack.sp_proto->lp_blocking_ast(astarg, level); | 173 | lksb->lksb_conn->cc_proto->lp_blocking_ast(lksb, level); |
174 | } | 174 | } |
175 | 175 | ||
176 | static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) | 176 | static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) |
177 | { | 177 | { |
178 | struct ocfs2_dlm_lksb *lksb = astarg; | ||
178 | int error = dlm_status_to_errno(status); | 179 | int error = dlm_status_to_errno(status); |
179 | 180 | ||
180 | BUG_ON(o2cb_stack.sp_proto == NULL); | ||
181 | |||
182 | /* | 181 | /* |
183 | * In o2dlm, you can get both the lock_ast() for the lock being | 182 | * In o2dlm, you can get both the lock_ast() for the lock being |
184 | * granted and the unlock_ast() for the CANCEL failing. A | 183 | * granted and the unlock_ast() for the CANCEL failing. A |
@@ -193,16 +192,15 @@ static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) | |||
193 | if (status == DLM_CANCELGRANT) | 192 | if (status == DLM_CANCELGRANT) |
194 | return; | 193 | return; |
195 | 194 | ||
196 | o2cb_stack.sp_proto->lp_unlock_ast(astarg, error); | 195 | lksb->lksb_conn->cc_proto->lp_unlock_ast(lksb, error); |
197 | } | 196 | } |
198 | 197 | ||
199 | static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, | 198 | static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, |
200 | int mode, | 199 | int mode, |
201 | union ocfs2_dlm_lksb *lksb, | 200 | struct ocfs2_dlm_lksb *lksb, |
202 | u32 flags, | 201 | u32 flags, |
203 | void *name, | 202 | void *name, |
204 | unsigned int namelen, | 203 | unsigned int namelen) |
205 | void *astarg) | ||
206 | { | 204 | { |
207 | enum dlm_status status; | 205 | enum dlm_status status; |
208 | int o2dlm_mode = mode_to_o2dlm(mode); | 206 | int o2dlm_mode = mode_to_o2dlm(mode); |
@@ -211,28 +209,27 @@ static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, | |||
211 | 209 | ||
212 | status = dlmlock(conn->cc_lockspace, o2dlm_mode, &lksb->lksb_o2dlm, | 210 | status = dlmlock(conn->cc_lockspace, o2dlm_mode, &lksb->lksb_o2dlm, |
213 | o2dlm_flags, name, namelen, | 211 | o2dlm_flags, name, namelen, |
214 | o2dlm_lock_ast_wrapper, astarg, | 212 | o2dlm_lock_ast_wrapper, lksb, |
215 | o2dlm_blocking_ast_wrapper); | 213 | o2dlm_blocking_ast_wrapper); |
216 | ret = dlm_status_to_errno(status); | 214 | ret = dlm_status_to_errno(status); |
217 | return ret; | 215 | return ret; |
218 | } | 216 | } |
219 | 217 | ||
220 | static int o2cb_dlm_unlock(struct ocfs2_cluster_connection *conn, | 218 | static int o2cb_dlm_unlock(struct ocfs2_cluster_connection *conn, |
221 | union ocfs2_dlm_lksb *lksb, | 219 | struct ocfs2_dlm_lksb *lksb, |
222 | u32 flags, | 220 | u32 flags) |
223 | void *astarg) | ||
224 | { | 221 | { |
225 | enum dlm_status status; | 222 | enum dlm_status status; |
226 | int o2dlm_flags = flags_to_o2dlm(flags); | 223 | int o2dlm_flags = flags_to_o2dlm(flags); |
227 | int ret; | 224 | int ret; |
228 | 225 | ||
229 | status = dlmunlock(conn->cc_lockspace, &lksb->lksb_o2dlm, | 226 | status = dlmunlock(conn->cc_lockspace, &lksb->lksb_o2dlm, |
230 | o2dlm_flags, o2dlm_unlock_ast_wrapper, astarg); | 227 | o2dlm_flags, o2dlm_unlock_ast_wrapper, lksb); |
231 | ret = dlm_status_to_errno(status); | 228 | ret = dlm_status_to_errno(status); |
232 | return ret; | 229 | return ret; |
233 | } | 230 | } |
234 | 231 | ||
235 | static int o2cb_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 232 | static int o2cb_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
236 | { | 233 | { |
237 | return dlm_status_to_errno(lksb->lksb_o2dlm.status); | 234 | return dlm_status_to_errno(lksb->lksb_o2dlm.status); |
238 | } | 235 | } |
@@ -242,17 +239,17 @@ static int o2cb_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | |||
242 | * contents, it will zero out the LVB. Thus the caller can always trust | 239 | * contents, it will zero out the LVB. Thus the caller can always trust |
243 | * the contents. | 240 | * the contents. |
244 | */ | 241 | */ |
245 | static int o2cb_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 242 | static int o2cb_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
246 | { | 243 | { |
247 | return 1; | 244 | return 1; |
248 | } | 245 | } |
249 | 246 | ||
250 | static void *o2cb_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 247 | static void *o2cb_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
251 | { | 248 | { |
252 | return (void *)(lksb->lksb_o2dlm.lvb); | 249 | return (void *)(lksb->lksb_o2dlm.lvb); |
253 | } | 250 | } |
254 | 251 | ||
255 | static void o2cb_dump_lksb(union ocfs2_dlm_lksb *lksb) | 252 | static void o2cb_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
256 | { | 253 | { |
257 | dlm_print_one_lock(lksb->lksb_o2dlm.lockid); | 254 | dlm_print_one_lock(lksb->lksb_o2dlm.lockid); |
258 | } | 255 | } |
@@ -280,7 +277,7 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn) | |||
280 | struct dlm_protocol_version fs_version; | 277 | struct dlm_protocol_version fs_version; |
281 | 278 | ||
282 | BUG_ON(conn == NULL); | 279 | BUG_ON(conn == NULL); |
283 | BUG_ON(o2cb_stack.sp_proto == NULL); | 280 | BUG_ON(conn->cc_proto == NULL); |
284 | 281 | ||
285 | /* for now we only have one cluster/node, make sure we see it | 282 | /* for now we only have one cluster/node, make sure we see it |
286 | * in the heartbeat universe */ | 283 | * in the heartbeat universe */ |
diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index da78a2a334fd..5ae8812b2864 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c | |||
@@ -25,7 +25,6 @@ | |||
25 | #include <linux/reboot.h> | 25 | #include <linux/reboot.h> |
26 | #include <asm/uaccess.h> | 26 | #include <asm/uaccess.h> |
27 | 27 | ||
28 | #include "ocfs2.h" /* For struct ocfs2_lock_res */ | ||
29 | #include "stackglue.h" | 28 | #include "stackglue.h" |
30 | 29 | ||
31 | #include <linux/dlm_plock.h> | 30 | #include <linux/dlm_plock.h> |
@@ -63,8 +62,8 @@ | |||
63 | * negotiated by the client. The client negotiates based on the maximum | 62 | * negotiated by the client. The client negotiates based on the maximum |
64 | * version advertised in /sys/fs/ocfs2/max_locking_protocol. The major | 63 | * version advertised in /sys/fs/ocfs2/max_locking_protocol. The major |
65 | * number from the "SETV" message must match | 64 | * number from the "SETV" message must match |
66 | * ocfs2_user_plugin.sp_proto->lp_max_version.pv_major, and the minor number | 65 | * ocfs2_user_plugin.sp_max_proto.pv_major, and the minor number |
67 | * must be less than or equal to ...->lp_max_version.pv_minor. | 66 | * must be less than or equal to ...sp_max_version.pv_minor. |
68 | * | 67 | * |
69 | * Once this information has been set, mounts will be allowed. From this | 68 | * Once this information has been set, mounts will be allowed. From this |
70 | * point on, the "DOWN" message can be sent for node down notification. | 69 | * point on, the "DOWN" message can be sent for node down notification. |
@@ -401,7 +400,7 @@ static int ocfs2_control_do_setversion_msg(struct file *file, | |||
401 | char *ptr = NULL; | 400 | char *ptr = NULL; |
402 | struct ocfs2_control_private *p = file->private_data; | 401 | struct ocfs2_control_private *p = file->private_data; |
403 | struct ocfs2_protocol_version *max = | 402 | struct ocfs2_protocol_version *max = |
404 | &ocfs2_user_plugin.sp_proto->lp_max_version; | 403 | &ocfs2_user_plugin.sp_max_proto; |
405 | 404 | ||
406 | if (ocfs2_control_get_handshake_state(file) != | 405 | if (ocfs2_control_get_handshake_state(file) != |
407 | OCFS2_CONTROL_HANDSHAKE_PROTOCOL) | 406 | OCFS2_CONTROL_HANDSHAKE_PROTOCOL) |
@@ -664,18 +663,10 @@ static void ocfs2_control_exit(void) | |||
664 | -rc); | 663 | -rc); |
665 | } | 664 | } |
666 | 665 | ||
667 | static struct dlm_lksb *fsdlm_astarg_to_lksb(void *astarg) | ||
668 | { | ||
669 | struct ocfs2_lock_res *res = astarg; | ||
670 | return &res->l_lksb.lksb_fsdlm; | ||
671 | } | ||
672 | |||
673 | static void fsdlm_lock_ast_wrapper(void *astarg) | 666 | static void fsdlm_lock_ast_wrapper(void *astarg) |
674 | { | 667 | { |
675 | struct dlm_lksb *lksb = fsdlm_astarg_to_lksb(astarg); | 668 | struct ocfs2_dlm_lksb *lksb = astarg; |
676 | int status = lksb->sb_status; | 669 | int status = lksb->lksb_fsdlm.sb_status; |
677 | |||
678 | BUG_ON(ocfs2_user_plugin.sp_proto == NULL); | ||
679 | 670 | ||
680 | /* | 671 | /* |
681 | * For now we're punting on the issue of other non-standard errors | 672 | * For now we're punting on the issue of other non-standard errors |
@@ -688,25 +679,24 @@ static void fsdlm_lock_ast_wrapper(void *astarg) | |||
688 | */ | 679 | */ |
689 | 680 | ||
690 | if (status == -DLM_EUNLOCK || status == -DLM_ECANCEL) | 681 | if (status == -DLM_EUNLOCK || status == -DLM_ECANCEL) |
691 | ocfs2_user_plugin.sp_proto->lp_unlock_ast(astarg, 0); | 682 | lksb->lksb_conn->cc_proto->lp_unlock_ast(lksb, 0); |
692 | else | 683 | else |
693 | ocfs2_user_plugin.sp_proto->lp_lock_ast(astarg); | 684 | lksb->lksb_conn->cc_proto->lp_lock_ast(lksb); |
694 | } | 685 | } |
695 | 686 | ||
696 | static void fsdlm_blocking_ast_wrapper(void *astarg, int level) | 687 | static void fsdlm_blocking_ast_wrapper(void *astarg, int level) |
697 | { | 688 | { |
698 | BUG_ON(ocfs2_user_plugin.sp_proto == NULL); | 689 | struct ocfs2_dlm_lksb *lksb = astarg; |
699 | 690 | ||
700 | ocfs2_user_plugin.sp_proto->lp_blocking_ast(astarg, level); | 691 | lksb->lksb_conn->cc_proto->lp_blocking_ast(lksb, level); |
701 | } | 692 | } |
702 | 693 | ||
703 | static int user_dlm_lock(struct ocfs2_cluster_connection *conn, | 694 | static int user_dlm_lock(struct ocfs2_cluster_connection *conn, |
704 | int mode, | 695 | int mode, |
705 | union ocfs2_dlm_lksb *lksb, | 696 | struct ocfs2_dlm_lksb *lksb, |
706 | u32 flags, | 697 | u32 flags, |
707 | void *name, | 698 | void *name, |
708 | unsigned int namelen, | 699 | unsigned int namelen) |
709 | void *astarg) | ||
710 | { | 700 | { |
711 | int ret; | 701 | int ret; |
712 | 702 | ||
@@ -716,36 +706,35 @@ static int user_dlm_lock(struct ocfs2_cluster_connection *conn, | |||
716 | 706 | ||
717 | ret = dlm_lock(conn->cc_lockspace, mode, &lksb->lksb_fsdlm, | 707 | ret = dlm_lock(conn->cc_lockspace, mode, &lksb->lksb_fsdlm, |
718 | flags|DLM_LKF_NODLCKWT, name, namelen, 0, | 708 | flags|DLM_LKF_NODLCKWT, name, namelen, 0, |
719 | fsdlm_lock_ast_wrapper, astarg, | 709 | fsdlm_lock_ast_wrapper, lksb, |
720 | fsdlm_blocking_ast_wrapper); | 710 | fsdlm_blocking_ast_wrapper); |
721 | return ret; | 711 | return ret; |
722 | } | 712 | } |
723 | 713 | ||
724 | static int user_dlm_unlock(struct ocfs2_cluster_connection *conn, | 714 | static int user_dlm_unlock(struct ocfs2_cluster_connection *conn, |
725 | union ocfs2_dlm_lksb *lksb, | 715 | struct ocfs2_dlm_lksb *lksb, |
726 | u32 flags, | 716 | u32 flags) |
727 | void *astarg) | ||
728 | { | 717 | { |
729 | int ret; | 718 | int ret; |
730 | 719 | ||
731 | ret = dlm_unlock(conn->cc_lockspace, lksb->lksb_fsdlm.sb_lkid, | 720 | ret = dlm_unlock(conn->cc_lockspace, lksb->lksb_fsdlm.sb_lkid, |
732 | flags, &lksb->lksb_fsdlm, astarg); | 721 | flags, &lksb->lksb_fsdlm, lksb); |
733 | return ret; | 722 | return ret; |
734 | } | 723 | } |
735 | 724 | ||
736 | static int user_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 725 | static int user_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
737 | { | 726 | { |
738 | return lksb->lksb_fsdlm.sb_status; | 727 | return lksb->lksb_fsdlm.sb_status; |
739 | } | 728 | } |
740 | 729 | ||
741 | static int user_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 730 | static int user_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
742 | { | 731 | { |
743 | int invalid = lksb->lksb_fsdlm.sb_flags & DLM_SBF_VALNOTVALID; | 732 | int invalid = lksb->lksb_fsdlm.sb_flags & DLM_SBF_VALNOTVALID; |
744 | 733 | ||
745 | return !invalid; | 734 | return !invalid; |
746 | } | 735 | } |
747 | 736 | ||
748 | static void *user_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 737 | static void *user_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
749 | { | 738 | { |
750 | if (!lksb->lksb_fsdlm.sb_lvbptr) | 739 | if (!lksb->lksb_fsdlm.sb_lvbptr) |
751 | lksb->lksb_fsdlm.sb_lvbptr = (char *)lksb + | 740 | lksb->lksb_fsdlm.sb_lvbptr = (char *)lksb + |
@@ -753,7 +742,7 @@ static void *user_dlm_lvb(union ocfs2_dlm_lksb *lksb) | |||
753 | return (void *)(lksb->lksb_fsdlm.sb_lvbptr); | 742 | return (void *)(lksb->lksb_fsdlm.sb_lvbptr); |
754 | } | 743 | } |
755 | 744 | ||
756 | static void user_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb) | 745 | static void user_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
757 | { | 746 | { |
758 | } | 747 | } |
759 | 748 | ||
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index f3df0baa9a48..39abf89697ed 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c | |||
@@ -36,7 +36,7 @@ | |||
36 | #define OCFS2_STACK_PLUGIN_USER "user" | 36 | #define OCFS2_STACK_PLUGIN_USER "user" |
37 | #define OCFS2_MAX_HB_CTL_PATH 256 | 37 | #define OCFS2_MAX_HB_CTL_PATH 256 |
38 | 38 | ||
39 | static struct ocfs2_locking_protocol *lproto; | 39 | static struct ocfs2_protocol_version locking_max_version; |
40 | static DEFINE_SPINLOCK(ocfs2_stack_lock); | 40 | static DEFINE_SPINLOCK(ocfs2_stack_lock); |
41 | static LIST_HEAD(ocfs2_stack_list); | 41 | static LIST_HEAD(ocfs2_stack_list); |
42 | static char cluster_stack_name[OCFS2_STACK_LABEL_LEN + 1]; | 42 | static char cluster_stack_name[OCFS2_STACK_LABEL_LEN + 1]; |
@@ -176,7 +176,7 @@ int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin) | |||
176 | spin_lock(&ocfs2_stack_lock); | 176 | spin_lock(&ocfs2_stack_lock); |
177 | if (!ocfs2_stack_lookup(plugin->sp_name)) { | 177 | if (!ocfs2_stack_lookup(plugin->sp_name)) { |
178 | plugin->sp_count = 0; | 178 | plugin->sp_count = 0; |
179 | plugin->sp_proto = lproto; | 179 | plugin->sp_max_proto = locking_max_version; |
180 | list_add(&plugin->sp_list, &ocfs2_stack_list); | 180 | list_add(&plugin->sp_list, &ocfs2_stack_list); |
181 | printk(KERN_INFO "ocfs2: Registered cluster interface %s\n", | 181 | printk(KERN_INFO "ocfs2: Registered cluster interface %s\n", |
182 | plugin->sp_name); | 182 | plugin->sp_name); |
@@ -213,77 +213,76 @@ void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin) | |||
213 | } | 213 | } |
214 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_unregister); | 214 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_unregister); |
215 | 215 | ||
216 | void ocfs2_stack_glue_set_locking_protocol(struct ocfs2_locking_protocol *proto) | 216 | void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_proto) |
217 | { | 217 | { |
218 | struct ocfs2_stack_plugin *p; | 218 | struct ocfs2_stack_plugin *p; |
219 | 219 | ||
220 | BUG_ON(proto == NULL); | ||
221 | |||
222 | spin_lock(&ocfs2_stack_lock); | 220 | spin_lock(&ocfs2_stack_lock); |
223 | BUG_ON(active_stack != NULL); | 221 | if (memcmp(max_proto, &locking_max_version, |
222 | sizeof(struct ocfs2_protocol_version))) { | ||
223 | BUG_ON(locking_max_version.pv_major != 0); | ||
224 | 224 | ||
225 | lproto = proto; | 225 | locking_max_version = *max_proto; |
226 | list_for_each_entry(p, &ocfs2_stack_list, sp_list) { | 226 | list_for_each_entry(p, &ocfs2_stack_list, sp_list) { |
227 | p->sp_proto = lproto; | 227 | p->sp_max_proto = locking_max_version; |
228 | } | ||
228 | } | 229 | } |
229 | |||
230 | spin_unlock(&ocfs2_stack_lock); | 230 | spin_unlock(&ocfs2_stack_lock); |
231 | } | 231 | } |
232 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_set_locking_protocol); | 232 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_set_max_proto_version); |
233 | 233 | ||
234 | 234 | ||
235 | /* | 235 | /* |
236 | * The ocfs2_dlm_lock() and ocfs2_dlm_unlock() functions take | 236 | * The ocfs2_dlm_lock() and ocfs2_dlm_unlock() functions take no argument |
237 | * "struct ocfs2_lock_res *astarg" instead of "void *astarg" because the | 237 | * for the ast and bast functions. They will pass the lksb to the ast |
238 | * underlying stack plugins need to pilfer the lksb off of the lock_res. | 238 | * and bast. The caller can wrap the lksb with their own structure to |
239 | * If some other structure needs to be passed as an astarg, the plugins | 239 | * get more information. |
240 | * will need to be given a different avenue to the lksb. | ||
241 | */ | 240 | */ |
242 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, | 241 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, |
243 | int mode, | 242 | int mode, |
244 | union ocfs2_dlm_lksb *lksb, | 243 | struct ocfs2_dlm_lksb *lksb, |
245 | u32 flags, | 244 | u32 flags, |
246 | void *name, | 245 | void *name, |
247 | unsigned int namelen, | 246 | unsigned int namelen) |
248 | struct ocfs2_lock_res *astarg) | ||
249 | { | 247 | { |
250 | BUG_ON(lproto == NULL); | 248 | if (!lksb->lksb_conn) |
251 | 249 | lksb->lksb_conn = conn; | |
250 | else | ||
251 | BUG_ON(lksb->lksb_conn != conn); | ||
252 | return active_stack->sp_ops->dlm_lock(conn, mode, lksb, flags, | 252 | return active_stack->sp_ops->dlm_lock(conn, mode, lksb, flags, |
253 | name, namelen, astarg); | 253 | name, namelen); |
254 | } | 254 | } |
255 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock); | 255 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock); |
256 | 256 | ||
257 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, | 257 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, |
258 | union ocfs2_dlm_lksb *lksb, | 258 | struct ocfs2_dlm_lksb *lksb, |
259 | u32 flags, | 259 | u32 flags) |
260 | struct ocfs2_lock_res *astarg) | ||
261 | { | 260 | { |
262 | BUG_ON(lproto == NULL); | 261 | BUG_ON(lksb->lksb_conn == NULL); |
263 | 262 | ||
264 | return active_stack->sp_ops->dlm_unlock(conn, lksb, flags, astarg); | 263 | return active_stack->sp_ops->dlm_unlock(conn, lksb, flags); |
265 | } | 264 | } |
266 | EXPORT_SYMBOL_GPL(ocfs2_dlm_unlock); | 265 | EXPORT_SYMBOL_GPL(ocfs2_dlm_unlock); |
267 | 266 | ||
268 | int ocfs2_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 267 | int ocfs2_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
269 | { | 268 | { |
270 | return active_stack->sp_ops->lock_status(lksb); | 269 | return active_stack->sp_ops->lock_status(lksb); |
271 | } | 270 | } |
272 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock_status); | 271 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock_status); |
273 | 272 | ||
274 | int ocfs2_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 273 | int ocfs2_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
275 | { | 274 | { |
276 | return active_stack->sp_ops->lvb_valid(lksb); | 275 | return active_stack->sp_ops->lvb_valid(lksb); |
277 | } | 276 | } |
278 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb_valid); | 277 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb_valid); |
279 | 278 | ||
280 | void *ocfs2_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 279 | void *ocfs2_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
281 | { | 280 | { |
282 | return active_stack->sp_ops->lock_lvb(lksb); | 281 | return active_stack->sp_ops->lock_lvb(lksb); |
283 | } | 282 | } |
284 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb); | 283 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb); |
285 | 284 | ||
286 | void ocfs2_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb) | 285 | void ocfs2_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
287 | { | 286 | { |
288 | active_stack->sp_ops->dump_lksb(lksb); | 287 | active_stack->sp_ops->dump_lksb(lksb); |
289 | } | 288 | } |
@@ -312,6 +311,7 @@ EXPORT_SYMBOL_GPL(ocfs2_plock); | |||
312 | int ocfs2_cluster_connect(const char *stack_name, | 311 | int ocfs2_cluster_connect(const char *stack_name, |
313 | const char *group, | 312 | const char *group, |
314 | int grouplen, | 313 | int grouplen, |
314 | struct ocfs2_locking_protocol *lproto, | ||
315 | void (*recovery_handler)(int node_num, | 315 | void (*recovery_handler)(int node_num, |
316 | void *recovery_data), | 316 | void *recovery_data), |
317 | void *recovery_data, | 317 | void *recovery_data, |
@@ -329,6 +329,12 @@ int ocfs2_cluster_connect(const char *stack_name, | |||
329 | goto out; | 329 | goto out; |
330 | } | 330 | } |
331 | 331 | ||
332 | if (memcmp(&lproto->lp_max_version, &locking_max_version, | ||
333 | sizeof(struct ocfs2_protocol_version))) { | ||
334 | rc = -EINVAL; | ||
335 | goto out; | ||
336 | } | ||
337 | |||
332 | new_conn = kzalloc(sizeof(struct ocfs2_cluster_connection), | 338 | new_conn = kzalloc(sizeof(struct ocfs2_cluster_connection), |
333 | GFP_KERNEL); | 339 | GFP_KERNEL); |
334 | if (!new_conn) { | 340 | if (!new_conn) { |
@@ -341,6 +347,7 @@ int ocfs2_cluster_connect(const char *stack_name, | |||
341 | new_conn->cc_recovery_handler = recovery_handler; | 347 | new_conn->cc_recovery_handler = recovery_handler; |
342 | new_conn->cc_recovery_data = recovery_data; | 348 | new_conn->cc_recovery_data = recovery_data; |
343 | 349 | ||
350 | new_conn->cc_proto = lproto; | ||
344 | /* Start the new connection at our maximum compatibility level */ | 351 | /* Start the new connection at our maximum compatibility level */ |
345 | new_conn->cc_version = lproto->lp_max_version; | 352 | new_conn->cc_version = lproto->lp_max_version; |
346 | 353 | ||
@@ -366,6 +373,24 @@ out: | |||
366 | } | 373 | } |
367 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect); | 374 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect); |
368 | 375 | ||
376 | /* The caller will ensure all nodes have the same cluster stack */ | ||
377 | int ocfs2_cluster_connect_agnostic(const char *group, | ||
378 | int grouplen, | ||
379 | struct ocfs2_locking_protocol *lproto, | ||
380 | void (*recovery_handler)(int node_num, | ||
381 | void *recovery_data), | ||
382 | void *recovery_data, | ||
383 | struct ocfs2_cluster_connection **conn) | ||
384 | { | ||
385 | char *stack_name = NULL; | ||
386 | |||
387 | if (cluster_stack_name[0]) | ||
388 | stack_name = cluster_stack_name; | ||
389 | return ocfs2_cluster_connect(stack_name, group, grouplen, lproto, | ||
390 | recovery_handler, recovery_data, conn); | ||
391 | } | ||
392 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect_agnostic); | ||
393 | |||
369 | /* If hangup_pending is 0, the stack driver will be dropped */ | 394 | /* If hangup_pending is 0, the stack driver will be dropped */ |
370 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, | 395 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, |
371 | int hangup_pending) | 396 | int hangup_pending) |
@@ -453,10 +478,10 @@ static ssize_t ocfs2_max_locking_protocol_show(struct kobject *kobj, | |||
453 | ssize_t ret = 0; | 478 | ssize_t ret = 0; |
454 | 479 | ||
455 | spin_lock(&ocfs2_stack_lock); | 480 | spin_lock(&ocfs2_stack_lock); |
456 | if (lproto) | 481 | if (locking_max_version.pv_major) |
457 | ret = snprintf(buf, PAGE_SIZE, "%u.%u\n", | 482 | ret = snprintf(buf, PAGE_SIZE, "%u.%u\n", |
458 | lproto->lp_max_version.pv_major, | 483 | locking_max_version.pv_major, |
459 | lproto->lp_max_version.pv_minor); | 484 | locking_max_version.pv_minor); |
460 | spin_unlock(&ocfs2_stack_lock); | 485 | spin_unlock(&ocfs2_stack_lock); |
461 | 486 | ||
462 | return ret; | 487 | return ret; |
@@ -685,7 +710,10 @@ static int __init ocfs2_stack_glue_init(void) | |||
685 | 710 | ||
686 | static void __exit ocfs2_stack_glue_exit(void) | 711 | static void __exit ocfs2_stack_glue_exit(void) |
687 | { | 712 | { |
688 | lproto = NULL; | 713 | memset(&locking_max_version, 0, |
714 | sizeof(struct ocfs2_protocol_version)); | ||
715 | locking_max_version.pv_major = 0; | ||
716 | locking_max_version.pv_minor = 0; | ||
689 | ocfs2_sysfs_exit(); | 717 | ocfs2_sysfs_exit(); |
690 | if (ocfs2_table_header) | 718 | if (ocfs2_table_header) |
691 | unregister_sysctl_table(ocfs2_table_header); | 719 | unregister_sysctl_table(ocfs2_table_header); |
diff --git a/fs/ocfs2/stackglue.h b/fs/ocfs2/stackglue.h index 03a44d60eac9..8ce7398ae1d2 100644 --- a/fs/ocfs2/stackglue.h +++ b/fs/ocfs2/stackglue.h | |||
@@ -56,17 +56,6 @@ struct ocfs2_protocol_version { | |||
56 | }; | 56 | }; |
57 | 57 | ||
58 | /* | 58 | /* |
59 | * The ocfs2_locking_protocol defines the handlers called on ocfs2's behalf. | ||
60 | */ | ||
61 | struct ocfs2_locking_protocol { | ||
62 | struct ocfs2_protocol_version lp_max_version; | ||
63 | void (*lp_lock_ast)(void *astarg); | ||
64 | void (*lp_blocking_ast)(void *astarg, int level); | ||
65 | void (*lp_unlock_ast)(void *astarg, int error); | ||
66 | }; | ||
67 | |||
68 | |||
69 | /* | ||
70 | * The dlm_lockstatus struct includes lvb space, but the dlm_lksb struct only | 59 | * The dlm_lockstatus struct includes lvb space, but the dlm_lksb struct only |
71 | * has a pointer to separately allocated lvb space. This struct exists only to | 60 | * has a pointer to separately allocated lvb space. This struct exists only to |
72 | * include in the lksb union to make space for a combined dlm_lksb and lvb. | 61 | * include in the lksb union to make space for a combined dlm_lksb and lvb. |
@@ -81,12 +70,27 @@ struct fsdlm_lksb_plus_lvb { | |||
81 | * size of the union is known. Lock status structures are embedded in | 70 | * size of the union is known. Lock status structures are embedded in |
82 | * ocfs2 inodes. | 71 | * ocfs2 inodes. |
83 | */ | 72 | */ |
84 | union ocfs2_dlm_lksb { | 73 | struct ocfs2_cluster_connection; |
85 | struct dlm_lockstatus lksb_o2dlm; | 74 | struct ocfs2_dlm_lksb { |
86 | struct dlm_lksb lksb_fsdlm; | 75 | union { |
87 | struct fsdlm_lksb_plus_lvb padding; | 76 | struct dlm_lockstatus lksb_o2dlm; |
77 | struct dlm_lksb lksb_fsdlm; | ||
78 | struct fsdlm_lksb_plus_lvb padding; | ||
79 | }; | ||
80 | struct ocfs2_cluster_connection *lksb_conn; | ||
81 | }; | ||
82 | |||
83 | /* | ||
84 | * The ocfs2_locking_protocol defines the handlers called on ocfs2's behalf. | ||
85 | */ | ||
86 | struct ocfs2_locking_protocol { | ||
87 | struct ocfs2_protocol_version lp_max_version; | ||
88 | void (*lp_lock_ast)(struct ocfs2_dlm_lksb *lksb); | ||
89 | void (*lp_blocking_ast)(struct ocfs2_dlm_lksb *lksb, int level); | ||
90 | void (*lp_unlock_ast)(struct ocfs2_dlm_lksb *lksb, int error); | ||
88 | }; | 91 | }; |
89 | 92 | ||
93 | |||
90 | /* | 94 | /* |
91 | * A cluster connection. Mostly opaque to ocfs2, the connection holds | 95 | * A cluster connection. Mostly opaque to ocfs2, the connection holds |
92 | * state for the underlying stack. ocfs2 does use cc_version to determine | 96 | * state for the underlying stack. ocfs2 does use cc_version to determine |
@@ -96,6 +100,7 @@ struct ocfs2_cluster_connection { | |||
96 | char cc_name[GROUP_NAME_MAX]; | 100 | char cc_name[GROUP_NAME_MAX]; |
97 | int cc_namelen; | 101 | int cc_namelen; |
98 | struct ocfs2_protocol_version cc_version; | 102 | struct ocfs2_protocol_version cc_version; |
103 | struct ocfs2_locking_protocol *cc_proto; | ||
99 | void (*cc_recovery_handler)(int node_num, void *recovery_data); | 104 | void (*cc_recovery_handler)(int node_num, void *recovery_data); |
100 | void *cc_recovery_data; | 105 | void *cc_recovery_data; |
101 | void *cc_lockspace; | 106 | void *cc_lockspace; |
@@ -155,27 +160,29 @@ struct ocfs2_stack_operations { | |||
155 | * | 160 | * |
156 | * ast and bast functions are not part of the call because the | 161 | * ast and bast functions are not part of the call because the |
157 | * stack will likely want to wrap ast and bast calls before passing | 162 | * stack will likely want to wrap ast and bast calls before passing |
158 | * them to stack->sp_proto. | 163 | * them to stack->sp_proto. There is no astarg. The lksb will |
164 | * be passed back to the ast and bast functions. The caller can | ||
165 | * use this to find their object. | ||
159 | */ | 166 | */ |
160 | int (*dlm_lock)(struct ocfs2_cluster_connection *conn, | 167 | int (*dlm_lock)(struct ocfs2_cluster_connection *conn, |
161 | int mode, | 168 | int mode, |
162 | union ocfs2_dlm_lksb *lksb, | 169 | struct ocfs2_dlm_lksb *lksb, |
163 | u32 flags, | 170 | u32 flags, |
164 | void *name, | 171 | void *name, |
165 | unsigned int namelen, | 172 | unsigned int namelen); |
166 | void *astarg); | ||
167 | 173 | ||
168 | /* | 174 | /* |
169 | * Call the underlying dlm unlock function. The ->dlm_unlock() | 175 | * Call the underlying dlm unlock function. The ->dlm_unlock() |
170 | * function should convert the flags as appropriate. | 176 | * function should convert the flags as appropriate. |
171 | * | 177 | * |
172 | * The unlock ast is not passed, as the stack will want to wrap | 178 | * The unlock ast is not passed, as the stack will want to wrap |
173 | * it before calling stack->sp_proto->lp_unlock_ast(). | 179 | * it before calling stack->sp_proto->lp_unlock_ast(). There is |
180 | * no astarg. The lksb will be passed back to the unlock ast | ||
181 | * function. The caller can use this to find their object. | ||
174 | */ | 182 | */ |
175 | int (*dlm_unlock)(struct ocfs2_cluster_connection *conn, | 183 | int (*dlm_unlock)(struct ocfs2_cluster_connection *conn, |
176 | union ocfs2_dlm_lksb *lksb, | 184 | struct ocfs2_dlm_lksb *lksb, |
177 | u32 flags, | 185 | u32 flags); |
178 | void *astarg); | ||
179 | 186 | ||
180 | /* | 187 | /* |
181 | * Return the status of the current lock status block. The fs | 188 | * Return the status of the current lock status block. The fs |
@@ -183,17 +190,17 @@ struct ocfs2_stack_operations { | |||
183 | * callback pulls out the stack-specific lksb, converts the status | 190 | * callback pulls out the stack-specific lksb, converts the status |
184 | * to a proper errno, and returns it. | 191 | * to a proper errno, and returns it. |
185 | */ | 192 | */ |
186 | int (*lock_status)(union ocfs2_dlm_lksb *lksb); | 193 | int (*lock_status)(struct ocfs2_dlm_lksb *lksb); |
187 | 194 | ||
188 | /* | 195 | /* |
189 | * Return non-zero if the LVB is valid. | 196 | * Return non-zero if the LVB is valid. |
190 | */ | 197 | */ |
191 | int (*lvb_valid)(union ocfs2_dlm_lksb *lksb); | 198 | int (*lvb_valid)(struct ocfs2_dlm_lksb *lksb); |
192 | 199 | ||
193 | /* | 200 | /* |
194 | * Pull the lvb pointer off of the stack-specific lksb. | 201 | * Pull the lvb pointer off of the stack-specific lksb. |
195 | */ | 202 | */ |
196 | void *(*lock_lvb)(union ocfs2_dlm_lksb *lksb); | 203 | void *(*lock_lvb)(struct ocfs2_dlm_lksb *lksb); |
197 | 204 | ||
198 | /* | 205 | /* |
199 | * Cluster-aware posix locks | 206 | * Cluster-aware posix locks |
@@ -210,7 +217,7 @@ struct ocfs2_stack_operations { | |||
210 | * This is an optoinal debugging hook. If provided, the | 217 | * This is an optoinal debugging hook. If provided, the |
211 | * stack can dump debugging information about this lock. | 218 | * stack can dump debugging information about this lock. |
212 | */ | 219 | */ |
213 | void (*dump_lksb)(union ocfs2_dlm_lksb *lksb); | 220 | void (*dump_lksb)(struct ocfs2_dlm_lksb *lksb); |
214 | }; | 221 | }; |
215 | 222 | ||
216 | /* | 223 | /* |
@@ -226,7 +233,7 @@ struct ocfs2_stack_plugin { | |||
226 | /* These are managed by the stackglue code. */ | 233 | /* These are managed by the stackglue code. */ |
227 | struct list_head sp_list; | 234 | struct list_head sp_list; |
228 | unsigned int sp_count; | 235 | unsigned int sp_count; |
229 | struct ocfs2_locking_protocol *sp_proto; | 236 | struct ocfs2_protocol_version sp_max_proto; |
230 | }; | 237 | }; |
231 | 238 | ||
232 | 239 | ||
@@ -234,10 +241,22 @@ struct ocfs2_stack_plugin { | |||
234 | int ocfs2_cluster_connect(const char *stack_name, | 241 | int ocfs2_cluster_connect(const char *stack_name, |
235 | const char *group, | 242 | const char *group, |
236 | int grouplen, | 243 | int grouplen, |
244 | struct ocfs2_locking_protocol *lproto, | ||
237 | void (*recovery_handler)(int node_num, | 245 | void (*recovery_handler)(int node_num, |
238 | void *recovery_data), | 246 | void *recovery_data), |
239 | void *recovery_data, | 247 | void *recovery_data, |
240 | struct ocfs2_cluster_connection **conn); | 248 | struct ocfs2_cluster_connection **conn); |
249 | /* | ||
250 | * Used by callers that don't store their stack name. They must ensure | ||
251 | * all nodes have the same stack. | ||
252 | */ | ||
253 | int ocfs2_cluster_connect_agnostic(const char *group, | ||
254 | int grouplen, | ||
255 | struct ocfs2_locking_protocol *lproto, | ||
256 | void (*recovery_handler)(int node_num, | ||
257 | void *recovery_data), | ||
258 | void *recovery_data, | ||
259 | struct ocfs2_cluster_connection **conn); | ||
241 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, | 260 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, |
242 | int hangup_pending); | 261 | int hangup_pending); |
243 | void ocfs2_cluster_hangup(const char *group, int grouplen); | 262 | void ocfs2_cluster_hangup(const char *group, int grouplen); |
@@ -246,26 +265,24 @@ int ocfs2_cluster_this_node(unsigned int *node); | |||
246 | struct ocfs2_lock_res; | 265 | struct ocfs2_lock_res; |
247 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, | 266 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, |
248 | int mode, | 267 | int mode, |
249 | union ocfs2_dlm_lksb *lksb, | 268 | struct ocfs2_dlm_lksb *lksb, |
250 | u32 flags, | 269 | u32 flags, |
251 | void *name, | 270 | void *name, |
252 | unsigned int namelen, | 271 | unsigned int namelen); |
253 | struct ocfs2_lock_res *astarg); | ||
254 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, | 272 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, |
255 | union ocfs2_dlm_lksb *lksb, | 273 | struct ocfs2_dlm_lksb *lksb, |
256 | u32 flags, | 274 | u32 flags); |
257 | struct ocfs2_lock_res *astarg); | ||
258 | 275 | ||
259 | int ocfs2_dlm_lock_status(union ocfs2_dlm_lksb *lksb); | 276 | int ocfs2_dlm_lock_status(struct ocfs2_dlm_lksb *lksb); |
260 | int ocfs2_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb); | 277 | int ocfs2_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb); |
261 | void *ocfs2_dlm_lvb(union ocfs2_dlm_lksb *lksb); | 278 | void *ocfs2_dlm_lvb(struct ocfs2_dlm_lksb *lksb); |
262 | void ocfs2_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb); | 279 | void ocfs2_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb); |
263 | 280 | ||
264 | int ocfs2_stack_supports_plocks(void); | 281 | int ocfs2_stack_supports_plocks(void); |
265 | int ocfs2_plock(struct ocfs2_cluster_connection *conn, u64 ino, | 282 | int ocfs2_plock(struct ocfs2_cluster_connection *conn, u64 ino, |
266 | struct file *file, int cmd, struct file_lock *fl); | 283 | struct file *file, int cmd, struct file_lock *fl); |
267 | 284 | ||
268 | void ocfs2_stack_glue_set_locking_protocol(struct ocfs2_locking_protocol *proto); | 285 | void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_proto); |
269 | 286 | ||
270 | 287 | ||
271 | /* Used by stack plugins */ | 288 | /* Used by stack plugins */ |
diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index c30b644d9572..c3c60bc3e072 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c | |||
@@ -51,7 +51,7 @@ | |||
51 | #define ALLOC_NEW_GROUP 0x1 | 51 | #define ALLOC_NEW_GROUP 0x1 |
52 | #define ALLOC_GROUPS_FROM_GLOBAL 0x2 | 52 | #define ALLOC_GROUPS_FROM_GLOBAL 0x2 |
53 | 53 | ||
54 | #define OCFS2_MAX_INODES_TO_STEAL 1024 | 54 | #define OCFS2_MAX_TO_STEAL 1024 |
55 | 55 | ||
56 | static inline void ocfs2_debug_bg(struct ocfs2_group_desc *bg); | 56 | static inline void ocfs2_debug_bg(struct ocfs2_group_desc *bg); |
57 | static inline void ocfs2_debug_suballoc_inode(struct ocfs2_dinode *fe); | 57 | static inline void ocfs2_debug_suballoc_inode(struct ocfs2_dinode *fe); |
@@ -637,12 +637,113 @@ bail: | |||
637 | return status; | 637 | return status; |
638 | } | 638 | } |
639 | 639 | ||
640 | static void ocfs2_init_inode_steal_slot(struct ocfs2_super *osb) | ||
641 | { | ||
642 | spin_lock(&osb->osb_lock); | ||
643 | osb->s_inode_steal_slot = OCFS2_INVALID_SLOT; | ||
644 | spin_unlock(&osb->osb_lock); | ||
645 | atomic_set(&osb->s_num_inodes_stolen, 0); | ||
646 | } | ||
647 | |||
648 | static void ocfs2_init_meta_steal_slot(struct ocfs2_super *osb) | ||
649 | { | ||
650 | spin_lock(&osb->osb_lock); | ||
651 | osb->s_meta_steal_slot = OCFS2_INVALID_SLOT; | ||
652 | spin_unlock(&osb->osb_lock); | ||
653 | atomic_set(&osb->s_num_meta_stolen, 0); | ||
654 | } | ||
655 | |||
656 | void ocfs2_init_steal_slots(struct ocfs2_super *osb) | ||
657 | { | ||
658 | ocfs2_init_inode_steal_slot(osb); | ||
659 | ocfs2_init_meta_steal_slot(osb); | ||
660 | } | ||
661 | |||
662 | static void __ocfs2_set_steal_slot(struct ocfs2_super *osb, int slot, int type) | ||
663 | { | ||
664 | spin_lock(&osb->osb_lock); | ||
665 | if (type == INODE_ALLOC_SYSTEM_INODE) | ||
666 | osb->s_inode_steal_slot = slot; | ||
667 | else if (type == EXTENT_ALLOC_SYSTEM_INODE) | ||
668 | osb->s_meta_steal_slot = slot; | ||
669 | spin_unlock(&osb->osb_lock); | ||
670 | } | ||
671 | |||
672 | static int __ocfs2_get_steal_slot(struct ocfs2_super *osb, int type) | ||
673 | { | ||
674 | int slot = OCFS2_INVALID_SLOT; | ||
675 | |||
676 | spin_lock(&osb->osb_lock); | ||
677 | if (type == INODE_ALLOC_SYSTEM_INODE) | ||
678 | slot = osb->s_inode_steal_slot; | ||
679 | else if (type == EXTENT_ALLOC_SYSTEM_INODE) | ||
680 | slot = osb->s_meta_steal_slot; | ||
681 | spin_unlock(&osb->osb_lock); | ||
682 | |||
683 | return slot; | ||
684 | } | ||
685 | |||
686 | static int ocfs2_get_inode_steal_slot(struct ocfs2_super *osb) | ||
687 | { | ||
688 | return __ocfs2_get_steal_slot(osb, INODE_ALLOC_SYSTEM_INODE); | ||
689 | } | ||
690 | |||
691 | static int ocfs2_get_meta_steal_slot(struct ocfs2_super *osb) | ||
692 | { | ||
693 | return __ocfs2_get_steal_slot(osb, EXTENT_ALLOC_SYSTEM_INODE); | ||
694 | } | ||
695 | |||
696 | static int ocfs2_steal_resource(struct ocfs2_super *osb, | ||
697 | struct ocfs2_alloc_context *ac, | ||
698 | int type) | ||
699 | { | ||
700 | int i, status = -ENOSPC; | ||
701 | int slot = __ocfs2_get_steal_slot(osb, type); | ||
702 | |||
703 | /* Start to steal resource from the first slot after ours. */ | ||
704 | if (slot == OCFS2_INVALID_SLOT) | ||
705 | slot = osb->slot_num + 1; | ||
706 | |||
707 | for (i = 0; i < osb->max_slots; i++, slot++) { | ||
708 | if (slot == osb->max_slots) | ||
709 | slot = 0; | ||
710 | |||
711 | if (slot == osb->slot_num) | ||
712 | continue; | ||
713 | |||
714 | status = ocfs2_reserve_suballoc_bits(osb, ac, | ||
715 | type, | ||
716 | (u32)slot, NULL, | ||
717 | NOT_ALLOC_NEW_GROUP); | ||
718 | if (status >= 0) { | ||
719 | __ocfs2_set_steal_slot(osb, slot, type); | ||
720 | break; | ||
721 | } | ||
722 | |||
723 | ocfs2_free_ac_resource(ac); | ||
724 | } | ||
725 | |||
726 | return status; | ||
727 | } | ||
728 | |||
729 | static int ocfs2_steal_inode(struct ocfs2_super *osb, | ||
730 | struct ocfs2_alloc_context *ac) | ||
731 | { | ||
732 | return ocfs2_steal_resource(osb, ac, INODE_ALLOC_SYSTEM_INODE); | ||
733 | } | ||
734 | |||
735 | static int ocfs2_steal_meta(struct ocfs2_super *osb, | ||
736 | struct ocfs2_alloc_context *ac) | ||
737 | { | ||
738 | return ocfs2_steal_resource(osb, ac, EXTENT_ALLOC_SYSTEM_INODE); | ||
739 | } | ||
740 | |||
640 | int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, | 741 | int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, |
641 | int blocks, | 742 | int blocks, |
642 | struct ocfs2_alloc_context **ac) | 743 | struct ocfs2_alloc_context **ac) |
643 | { | 744 | { |
644 | int status; | 745 | int status; |
645 | u32 slot; | 746 | int slot = ocfs2_get_meta_steal_slot(osb); |
646 | 747 | ||
647 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); | 748 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); |
648 | if (!(*ac)) { | 749 | if (!(*ac)) { |
@@ -653,12 +754,34 @@ int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, | |||
653 | 754 | ||
654 | (*ac)->ac_bits_wanted = blocks; | 755 | (*ac)->ac_bits_wanted = blocks; |
655 | (*ac)->ac_which = OCFS2_AC_USE_META; | 756 | (*ac)->ac_which = OCFS2_AC_USE_META; |
656 | slot = osb->slot_num; | ||
657 | (*ac)->ac_group_search = ocfs2_block_group_search; | 757 | (*ac)->ac_group_search = ocfs2_block_group_search; |
658 | 758 | ||
759 | if (slot != OCFS2_INVALID_SLOT && | ||
760 | atomic_read(&osb->s_num_meta_stolen) < OCFS2_MAX_TO_STEAL) | ||
761 | goto extent_steal; | ||
762 | |||
763 | atomic_set(&osb->s_num_meta_stolen, 0); | ||
659 | status = ocfs2_reserve_suballoc_bits(osb, (*ac), | 764 | status = ocfs2_reserve_suballoc_bits(osb, (*ac), |
660 | EXTENT_ALLOC_SYSTEM_INODE, | 765 | EXTENT_ALLOC_SYSTEM_INODE, |
661 | slot, NULL, ALLOC_NEW_GROUP); | 766 | (u32)osb->slot_num, NULL, |
767 | ALLOC_NEW_GROUP); | ||
768 | |||
769 | |||
770 | if (status >= 0) { | ||
771 | status = 0; | ||
772 | if (slot != OCFS2_INVALID_SLOT) | ||
773 | ocfs2_init_meta_steal_slot(osb); | ||
774 | goto bail; | ||
775 | } else if (status < 0 && status != -ENOSPC) { | ||
776 | mlog_errno(status); | ||
777 | goto bail; | ||
778 | } | ||
779 | |||
780 | ocfs2_free_ac_resource(*ac); | ||
781 | |||
782 | extent_steal: | ||
783 | status = ocfs2_steal_meta(osb, *ac); | ||
784 | atomic_inc(&osb->s_num_meta_stolen); | ||
662 | if (status < 0) { | 785 | if (status < 0) { |
663 | if (status != -ENOSPC) | 786 | if (status != -ENOSPC) |
664 | mlog_errno(status); | 787 | mlog_errno(status); |
@@ -685,43 +808,11 @@ int ocfs2_reserve_new_metadata(struct ocfs2_super *osb, | |||
685 | ac); | 808 | ac); |
686 | } | 809 | } |
687 | 810 | ||
688 | static int ocfs2_steal_inode_from_other_nodes(struct ocfs2_super *osb, | ||
689 | struct ocfs2_alloc_context *ac) | ||
690 | { | ||
691 | int i, status = -ENOSPC; | ||
692 | s16 slot = ocfs2_get_inode_steal_slot(osb); | ||
693 | |||
694 | /* Start to steal inodes from the first slot after ours. */ | ||
695 | if (slot == OCFS2_INVALID_SLOT) | ||
696 | slot = osb->slot_num + 1; | ||
697 | |||
698 | for (i = 0; i < osb->max_slots; i++, slot++) { | ||
699 | if (slot == osb->max_slots) | ||
700 | slot = 0; | ||
701 | |||
702 | if (slot == osb->slot_num) | ||
703 | continue; | ||
704 | |||
705 | status = ocfs2_reserve_suballoc_bits(osb, ac, | ||
706 | INODE_ALLOC_SYSTEM_INODE, | ||
707 | slot, NULL, | ||
708 | NOT_ALLOC_NEW_GROUP); | ||
709 | if (status >= 0) { | ||
710 | ocfs2_set_inode_steal_slot(osb, slot); | ||
711 | break; | ||
712 | } | ||
713 | |||
714 | ocfs2_free_ac_resource(ac); | ||
715 | } | ||
716 | |||
717 | return status; | ||
718 | } | ||
719 | |||
720 | int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | 811 | int ocfs2_reserve_new_inode(struct ocfs2_super *osb, |
721 | struct ocfs2_alloc_context **ac) | 812 | struct ocfs2_alloc_context **ac) |
722 | { | 813 | { |
723 | int status; | 814 | int status; |
724 | s16 slot = ocfs2_get_inode_steal_slot(osb); | 815 | int slot = ocfs2_get_inode_steal_slot(osb); |
725 | u64 alloc_group; | 816 | u64 alloc_group; |
726 | 817 | ||
727 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); | 818 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); |
@@ -754,14 +845,14 @@ int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | |||
754 | * need to check our slots to see whether there is some space for us. | 845 | * need to check our slots to see whether there is some space for us. |
755 | */ | 846 | */ |
756 | if (slot != OCFS2_INVALID_SLOT && | 847 | if (slot != OCFS2_INVALID_SLOT && |
757 | atomic_read(&osb->s_num_inodes_stolen) < OCFS2_MAX_INODES_TO_STEAL) | 848 | atomic_read(&osb->s_num_inodes_stolen) < OCFS2_MAX_TO_STEAL) |
758 | goto inode_steal; | 849 | goto inode_steal; |
759 | 850 | ||
760 | atomic_set(&osb->s_num_inodes_stolen, 0); | 851 | atomic_set(&osb->s_num_inodes_stolen, 0); |
761 | alloc_group = osb->osb_inode_alloc_group; | 852 | alloc_group = osb->osb_inode_alloc_group; |
762 | status = ocfs2_reserve_suballoc_bits(osb, *ac, | 853 | status = ocfs2_reserve_suballoc_bits(osb, *ac, |
763 | INODE_ALLOC_SYSTEM_INODE, | 854 | INODE_ALLOC_SYSTEM_INODE, |
764 | osb->slot_num, | 855 | (u32)osb->slot_num, |
765 | &alloc_group, | 856 | &alloc_group, |
766 | ALLOC_NEW_GROUP | | 857 | ALLOC_NEW_GROUP | |
767 | ALLOC_GROUPS_FROM_GLOBAL); | 858 | ALLOC_GROUPS_FROM_GLOBAL); |
@@ -789,7 +880,7 @@ int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | |||
789 | ocfs2_free_ac_resource(*ac); | 880 | ocfs2_free_ac_resource(*ac); |
790 | 881 | ||
791 | inode_steal: | 882 | inode_steal: |
792 | status = ocfs2_steal_inode_from_other_nodes(osb, *ac); | 883 | status = ocfs2_steal_inode(osb, *ac); |
793 | atomic_inc(&osb->s_num_inodes_stolen); | 884 | atomic_inc(&osb->s_num_inodes_stolen); |
794 | if (status < 0) { | 885 | if (status < 0) { |
795 | if (status != -ENOSPC) | 886 | if (status != -ENOSPC) |
diff --git a/fs/ocfs2/suballoc.h b/fs/ocfs2/suballoc.h index 8c9a78a43164..fa60723c43e8 100644 --- a/fs/ocfs2/suballoc.h +++ b/fs/ocfs2/suballoc.h | |||
@@ -56,6 +56,7 @@ struct ocfs2_alloc_context { | |||
56 | is the same as ~0 - unlimited */ | 56 | is the same as ~0 - unlimited */ |
57 | }; | 57 | }; |
58 | 58 | ||
59 | void ocfs2_init_steal_slots(struct ocfs2_super *osb); | ||
59 | void ocfs2_free_alloc_context(struct ocfs2_alloc_context *ac); | 60 | void ocfs2_free_alloc_context(struct ocfs2_alloc_context *ac); |
60 | static inline int ocfs2_alloc_context_bits_left(struct ocfs2_alloc_context *ac) | 61 | static inline int ocfs2_alloc_context_bits_left(struct ocfs2_alloc_context *ac) |
61 | { | 62 | { |
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 755cd49a5ef3..dee03197a494 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c | |||
@@ -69,6 +69,7 @@ | |||
69 | #include "xattr.h" | 69 | #include "xattr.h" |
70 | #include "quota.h" | 70 | #include "quota.h" |
71 | #include "refcounttree.h" | 71 | #include "refcounttree.h" |
72 | #include "suballoc.h" | ||
72 | 73 | ||
73 | #include "buffer_head_io.h" | 74 | #include "buffer_head_io.h" |
74 | 75 | ||
@@ -301,9 +302,12 @@ static int ocfs2_osb_dump(struct ocfs2_super *osb, char *buf, int len) | |||
301 | 302 | ||
302 | spin_lock(&osb->osb_lock); | 303 | spin_lock(&osb->osb_lock); |
303 | out += snprintf(buf + out, len - out, | 304 | out += snprintf(buf + out, len - out, |
304 | "%10s => Slot: %d NumStolen: %d\n", "Steal", | 305 | "%10s => InodeSlot: %d StolenInodes: %d, " |
306 | "MetaSlot: %d StolenMeta: %d\n", "Steal", | ||
305 | osb->s_inode_steal_slot, | 307 | osb->s_inode_steal_slot, |
306 | atomic_read(&osb->s_num_inodes_stolen)); | 308 | atomic_read(&osb->s_num_inodes_stolen), |
309 | osb->s_meta_steal_slot, | ||
310 | atomic_read(&osb->s_num_meta_stolen)); | ||
307 | spin_unlock(&osb->osb_lock); | 311 | spin_unlock(&osb->osb_lock); |
308 | 312 | ||
309 | out += snprintf(buf + out, len - out, "OrphanScan => "); | 313 | out += snprintf(buf + out, len - out, "OrphanScan => "); |
@@ -1997,7 +2001,7 @@ static int ocfs2_initialize_super(struct super_block *sb, | |||
1997 | osb->blocked_lock_count = 0; | 2001 | osb->blocked_lock_count = 0; |
1998 | spin_lock_init(&osb->osb_lock); | 2002 | spin_lock_init(&osb->osb_lock); |
1999 | spin_lock_init(&osb->osb_xattr_lock); | 2003 | spin_lock_init(&osb->osb_xattr_lock); |
2000 | ocfs2_init_inode_steal_slot(osb); | 2004 | ocfs2_init_steal_slots(osb); |
2001 | 2005 | ||
2002 | atomic_set(&osb->alloc_stats.moves, 0); | 2006 | atomic_set(&osb->alloc_stats.moves, 0); |
2003 | atomic_set(&osb->alloc_stats.local_data, 0); | 2007 | atomic_set(&osb->alloc_stats.local_data, 0); |
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8fc6fb071c6d..d1b0d386f6d1 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c | |||
@@ -116,10 +116,11 @@ static struct xattr_handler *ocfs2_xattr_handler_map[OCFS2_XATTR_MAX] = { | |||
116 | }; | 116 | }; |
117 | 117 | ||
118 | struct ocfs2_xattr_info { | 118 | struct ocfs2_xattr_info { |
119 | int name_index; | 119 | int xi_name_index; |
120 | const char *name; | 120 | const char *xi_name; |
121 | const void *value; | 121 | int xi_name_len; |
122 | size_t value_len; | 122 | const void *xi_value; |
123 | size_t xi_value_len; | ||
123 | }; | 124 | }; |
124 | 125 | ||
125 | struct ocfs2_xattr_search { | 126 | struct ocfs2_xattr_search { |
@@ -137,6 +138,115 @@ struct ocfs2_xattr_search { | |||
137 | int not_found; | 138 | int not_found; |
138 | }; | 139 | }; |
139 | 140 | ||
141 | /* Operations on struct ocfs2_xa_entry */ | ||
142 | struct ocfs2_xa_loc; | ||
143 | struct ocfs2_xa_loc_operations { | ||
144 | /* | ||
145 | * Journal functions | ||
146 | */ | ||
147 | int (*xlo_journal_access)(handle_t *handle, struct ocfs2_xa_loc *loc, | ||
148 | int type); | ||
149 | void (*xlo_journal_dirty)(handle_t *handle, struct ocfs2_xa_loc *loc); | ||
150 | |||
151 | /* | ||
152 | * Return a pointer to the appropriate buffer in loc->xl_storage | ||
153 | * at the given offset from loc->xl_header. | ||
154 | */ | ||
155 | void *(*xlo_offset_pointer)(struct ocfs2_xa_loc *loc, int offset); | ||
156 | |||
157 | /* Can we reuse the existing entry for the new value? */ | ||
158 | int (*xlo_can_reuse)(struct ocfs2_xa_loc *loc, | ||
159 | struct ocfs2_xattr_info *xi); | ||
160 | |||
161 | /* How much space is needed for the new value? */ | ||
162 | int (*xlo_check_space)(struct ocfs2_xa_loc *loc, | ||
163 | struct ocfs2_xattr_info *xi); | ||
164 | |||
165 | /* | ||
166 | * Return the offset of the first name+value pair. This is | ||
167 | * the start of our downward-filling free space. | ||
168 | */ | ||
169 | int (*xlo_get_free_start)(struct ocfs2_xa_loc *loc); | ||
170 | |||
171 | /* | ||
172 | * Remove the name+value at this location. Do whatever is | ||
173 | * appropriate with the remaining name+value pairs. | ||
174 | */ | ||
175 | void (*xlo_wipe_namevalue)(struct ocfs2_xa_loc *loc); | ||
176 | |||
177 | /* Fill xl_entry with a new entry */ | ||
178 | void (*xlo_add_entry)(struct ocfs2_xa_loc *loc, u32 name_hash); | ||
179 | |||
180 | /* Add name+value storage to an entry */ | ||
181 | void (*xlo_add_namevalue)(struct ocfs2_xa_loc *loc, int size); | ||
182 | |||
183 | /* | ||
184 | * Initialize the value buf's access and bh fields for this entry. | ||
185 | * ocfs2_xa_fill_value_buf() will handle the xv pointer. | ||
186 | */ | ||
187 | void (*xlo_fill_value_buf)(struct ocfs2_xa_loc *loc, | ||
188 | struct ocfs2_xattr_value_buf *vb); | ||
189 | }; | ||
190 | |||
191 | /* | ||
192 | * Describes an xattr entry location. This is a memory structure | ||
193 | * tracking the on-disk structure. | ||
194 | */ | ||
195 | struct ocfs2_xa_loc { | ||
196 | /* This xattr belongs to this inode */ | ||
197 | struct inode *xl_inode; | ||
198 | |||
199 | /* The ocfs2_xattr_header inside the on-disk storage. Not NULL. */ | ||
200 | struct ocfs2_xattr_header *xl_header; | ||
201 | |||
202 | /* Bytes from xl_header to the end of the storage */ | ||
203 | int xl_size; | ||
204 | |||
205 | /* | ||
206 | * The ocfs2_xattr_entry this location describes. If this is | ||
207 | * NULL, this location describes the on-disk structure where it | ||
208 | * would have been. | ||
209 | */ | ||
210 | struct ocfs2_xattr_entry *xl_entry; | ||
211 | |||
212 | /* | ||
213 | * Internal housekeeping | ||
214 | */ | ||
215 | |||
216 | /* Buffer(s) containing this entry */ | ||
217 | void *xl_storage; | ||
218 | |||
219 | /* Operations on the storage backing this location */ | ||
220 | const struct ocfs2_xa_loc_operations *xl_ops; | ||
221 | }; | ||
222 | |||
223 | /* | ||
224 | * Convenience functions to calculate how much space is needed for a | ||
225 | * given name+value pair | ||
226 | */ | ||
227 | static int namevalue_size(int name_len, uint64_t value_len) | ||
228 | { | ||
229 | if (value_len > OCFS2_XATTR_INLINE_SIZE) | ||
230 | return OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
231 | else | ||
232 | return OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(value_len); | ||
233 | } | ||
234 | |||
235 | static int namevalue_size_xi(struct ocfs2_xattr_info *xi) | ||
236 | { | ||
237 | return namevalue_size(xi->xi_name_len, xi->xi_value_len); | ||
238 | } | ||
239 | |||
240 | static int namevalue_size_xe(struct ocfs2_xattr_entry *xe) | ||
241 | { | ||
242 | u64 value_len = le64_to_cpu(xe->xe_value_size); | ||
243 | |||
244 | BUG_ON((value_len > OCFS2_XATTR_INLINE_SIZE) && | ||
245 | ocfs2_xattr_is_local(xe)); | ||
246 | return namevalue_size(xe->xe_name_len, value_len); | ||
247 | } | ||
248 | |||
249 | |||
140 | static int ocfs2_xattr_bucket_get_name_value(struct super_block *sb, | 250 | static int ocfs2_xattr_bucket_get_name_value(struct super_block *sb, |
141 | struct ocfs2_xattr_header *xh, | 251 | struct ocfs2_xattr_header *xh, |
142 | int index, | 252 | int index, |
@@ -212,14 +322,6 @@ static inline u16 ocfs2_blocks_per_xattr_bucket(struct super_block *sb) | |||
212 | return OCFS2_XATTR_BUCKET_SIZE / (1 << sb->s_blocksize_bits); | 322 | return OCFS2_XATTR_BUCKET_SIZE / (1 << sb->s_blocksize_bits); |
213 | } | 323 | } |
214 | 324 | ||
215 | static inline u16 ocfs2_xattr_max_xe_in_bucket(struct super_block *sb) | ||
216 | { | ||
217 | u16 len = sb->s_blocksize - | ||
218 | offsetof(struct ocfs2_xattr_header, xh_entries); | ||
219 | |||
220 | return len / sizeof(struct ocfs2_xattr_entry); | ||
221 | } | ||
222 | |||
223 | #define bucket_blkno(_b) ((_b)->bu_bhs[0]->b_blocknr) | 325 | #define bucket_blkno(_b) ((_b)->bu_bhs[0]->b_blocknr) |
224 | #define bucket_block(_b, _n) ((_b)->bu_bhs[(_n)]->b_data) | 326 | #define bucket_block(_b, _n) ((_b)->bu_bhs[(_n)]->b_data) |
225 | #define bucket_xh(_b) ((struct ocfs2_xattr_header *)bucket_block((_b), 0)) | 327 | #define bucket_xh(_b) ((struct ocfs2_xattr_header *)bucket_block((_b), 0)) |
@@ -463,35 +565,22 @@ static u32 ocfs2_xattr_name_hash(struct inode *inode, | |||
463 | return hash; | 565 | return hash; |
464 | } | 566 | } |
465 | 567 | ||
466 | /* | 568 | static int ocfs2_xattr_entry_real_size(int name_len, size_t value_len) |
467 | * ocfs2_xattr_hash_entry() | ||
468 | * | ||
469 | * Compute the hash of an extended attribute. | ||
470 | */ | ||
471 | static void ocfs2_xattr_hash_entry(struct inode *inode, | ||
472 | struct ocfs2_xattr_header *header, | ||
473 | struct ocfs2_xattr_entry *entry) | ||
474 | { | 569 | { |
475 | u32 hash = 0; | 570 | return namevalue_size(name_len, value_len) + |
476 | char *name = (char *)header + le16_to_cpu(entry->xe_name_offset); | 571 | sizeof(struct ocfs2_xattr_entry); |
477 | |||
478 | hash = ocfs2_xattr_name_hash(inode, name, entry->xe_name_len); | ||
479 | entry->xe_name_hash = cpu_to_le32(hash); | ||
480 | |||
481 | return; | ||
482 | } | 572 | } |
483 | 573 | ||
484 | static int ocfs2_xattr_entry_real_size(int name_len, size_t value_len) | 574 | static int ocfs2_xi_entry_usage(struct ocfs2_xattr_info *xi) |
485 | { | 575 | { |
486 | int size = 0; | 576 | return namevalue_size_xi(xi) + |
487 | 577 | sizeof(struct ocfs2_xattr_entry); | |
488 | if (value_len <= OCFS2_XATTR_INLINE_SIZE) | 578 | } |
489 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(value_len); | ||
490 | else | ||
491 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
492 | size += sizeof(struct ocfs2_xattr_entry); | ||
493 | 579 | ||
494 | return size; | 580 | static int ocfs2_xe_entry_usage(struct ocfs2_xattr_entry *xe) |
581 | { | ||
582 | return namevalue_size_xe(xe) + | ||
583 | sizeof(struct ocfs2_xattr_entry); | ||
495 | } | 584 | } |
496 | 585 | ||
497 | int ocfs2_calc_security_init(struct inode *dir, | 586 | int ocfs2_calc_security_init(struct inode *dir, |
@@ -1308,452 +1397,897 @@ out: | |||
1308 | return ret; | 1397 | return ret; |
1309 | } | 1398 | } |
1310 | 1399 | ||
1311 | static int ocfs2_xattr_cleanup(struct inode *inode, | 1400 | static int ocfs2_xa_check_space_helper(int needed_space, int free_start, |
1312 | handle_t *handle, | 1401 | int num_entries) |
1313 | struct ocfs2_xattr_info *xi, | ||
1314 | struct ocfs2_xattr_search *xs, | ||
1315 | struct ocfs2_xattr_value_buf *vb, | ||
1316 | size_t offs) | ||
1317 | { | 1402 | { |
1318 | int ret = 0; | 1403 | int free_space; |
1319 | size_t name_len = strlen(xi->name); | ||
1320 | void *val = xs->base + offs; | ||
1321 | size_t size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
1322 | 1404 | ||
1323 | ret = vb->vb_access(handle, INODE_CACHE(inode), vb->vb_bh, | 1405 | if (!needed_space) |
1324 | OCFS2_JOURNAL_ACCESS_WRITE); | 1406 | return 0; |
1325 | if (ret) { | ||
1326 | mlog_errno(ret); | ||
1327 | goto out; | ||
1328 | } | ||
1329 | /* Decrease xattr count */ | ||
1330 | le16_add_cpu(&xs->header->xh_count, -1); | ||
1331 | /* Remove the xattr entry and tree root which has already be set*/ | ||
1332 | memset((void *)xs->here, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1333 | memset(val, 0, size); | ||
1334 | 1407 | ||
1335 | ret = ocfs2_journal_dirty(handle, vb->vb_bh); | 1408 | free_space = free_start - |
1336 | if (ret < 0) | 1409 | sizeof(struct ocfs2_xattr_header) - |
1337 | mlog_errno(ret); | 1410 | (num_entries * sizeof(struct ocfs2_xattr_entry)) - |
1338 | out: | 1411 | OCFS2_XATTR_HEADER_GAP; |
1339 | return ret; | 1412 | if (free_space < 0) |
1413 | return -EIO; | ||
1414 | if (free_space < needed_space) | ||
1415 | return -ENOSPC; | ||
1416 | |||
1417 | return 0; | ||
1340 | } | 1418 | } |
1341 | 1419 | ||
1342 | static int ocfs2_xattr_update_entry(struct inode *inode, | 1420 | static int ocfs2_xa_journal_access(handle_t *handle, struct ocfs2_xa_loc *loc, |
1343 | handle_t *handle, | 1421 | int type) |
1344 | struct ocfs2_xattr_info *xi, | ||
1345 | struct ocfs2_xattr_search *xs, | ||
1346 | struct ocfs2_xattr_value_buf *vb, | ||
1347 | size_t offs) | ||
1348 | { | 1422 | { |
1349 | int ret; | 1423 | return loc->xl_ops->xlo_journal_access(handle, loc, type); |
1424 | } | ||
1350 | 1425 | ||
1351 | ret = vb->vb_access(handle, INODE_CACHE(inode), vb->vb_bh, | 1426 | static void ocfs2_xa_journal_dirty(handle_t *handle, struct ocfs2_xa_loc *loc) |
1352 | OCFS2_JOURNAL_ACCESS_WRITE); | 1427 | { |
1353 | if (ret) { | 1428 | loc->xl_ops->xlo_journal_dirty(handle, loc); |
1354 | mlog_errno(ret); | 1429 | } |
1355 | goto out; | ||
1356 | } | ||
1357 | 1430 | ||
1358 | xs->here->xe_name_offset = cpu_to_le16(offs); | 1431 | /* Give a pointer into the storage for the given offset */ |
1359 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | 1432 | static void *ocfs2_xa_offset_pointer(struct ocfs2_xa_loc *loc, int offset) |
1360 | if (xi->value_len <= OCFS2_XATTR_INLINE_SIZE) | 1433 | { |
1361 | ocfs2_xattr_set_local(xs->here, 1); | 1434 | BUG_ON(offset >= loc->xl_size); |
1362 | else | 1435 | return loc->xl_ops->xlo_offset_pointer(loc, offset); |
1363 | ocfs2_xattr_set_local(xs->here, 0); | 1436 | } |
1364 | ocfs2_xattr_hash_entry(inode, xs->header, xs->here); | ||
1365 | 1437 | ||
1366 | ret = ocfs2_journal_dirty(handle, vb->vb_bh); | 1438 | /* |
1367 | if (ret < 0) | 1439 | * Wipe the name+value pair and allow the storage to reclaim it. This |
1368 | mlog_errno(ret); | 1440 | * must be followed by either removal of the entry or a call to |
1369 | out: | 1441 | * ocfs2_xa_add_namevalue(). |
1370 | return ret; | 1442 | */ |
1443 | static void ocfs2_xa_wipe_namevalue(struct ocfs2_xa_loc *loc) | ||
1444 | { | ||
1445 | loc->xl_ops->xlo_wipe_namevalue(loc); | ||
1371 | } | 1446 | } |
1372 | 1447 | ||
1373 | /* | 1448 | /* |
1374 | * ocfs2_xattr_set_value_outside() | 1449 | * Find lowest offset to a name+value pair. This is the start of our |
1375 | * | 1450 | * downward-growing free space. |
1376 | * Set large size value in B tree. | ||
1377 | */ | 1451 | */ |
1378 | static int ocfs2_xattr_set_value_outside(struct inode *inode, | 1452 | static int ocfs2_xa_get_free_start(struct ocfs2_xa_loc *loc) |
1379 | struct ocfs2_xattr_info *xi, | ||
1380 | struct ocfs2_xattr_search *xs, | ||
1381 | struct ocfs2_xattr_set_ctxt *ctxt, | ||
1382 | struct ocfs2_xattr_value_buf *vb, | ||
1383 | size_t offs) | ||
1384 | { | 1453 | { |
1385 | size_t name_len = strlen(xi->name); | 1454 | return loc->xl_ops->xlo_get_free_start(loc); |
1386 | void *val = xs->base + offs; | 1455 | } |
1387 | struct ocfs2_xattr_value_root *xv = NULL; | ||
1388 | size_t size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
1389 | int ret = 0; | ||
1390 | 1456 | ||
1391 | memset(val, 0, size); | 1457 | /* Can we reuse loc->xl_entry for xi? */ |
1392 | memcpy(val, xi->name, name_len); | 1458 | static int ocfs2_xa_can_reuse_entry(struct ocfs2_xa_loc *loc, |
1393 | xv = (struct ocfs2_xattr_value_root *) | 1459 | struct ocfs2_xattr_info *xi) |
1394 | (val + OCFS2_XATTR_SIZE(name_len)); | 1460 | { |
1395 | xv->xr_clusters = 0; | 1461 | return loc->xl_ops->xlo_can_reuse(loc, xi); |
1396 | xv->xr_last_eb_blk = 0; | 1462 | } |
1397 | xv->xr_list.l_tree_depth = 0; | 1463 | |
1398 | xv->xr_list.l_count = cpu_to_le16(1); | 1464 | /* How much free space is needed to set the new value */ |
1399 | xv->xr_list.l_next_free_rec = 0; | 1465 | static int ocfs2_xa_check_space(struct ocfs2_xa_loc *loc, |
1400 | vb->vb_xv = xv; | 1466 | struct ocfs2_xattr_info *xi) |
1401 | 1467 | { | |
1402 | ret = ocfs2_xattr_value_truncate(inode, vb, xi->value_len, ctxt); | 1468 | return loc->xl_ops->xlo_check_space(loc, xi); |
1403 | if (ret < 0) { | 1469 | } |
1404 | mlog_errno(ret); | 1470 | |
1405 | return ret; | 1471 | static void ocfs2_xa_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) |
1472 | { | ||
1473 | loc->xl_ops->xlo_add_entry(loc, name_hash); | ||
1474 | loc->xl_entry->xe_name_hash = cpu_to_le32(name_hash); | ||
1475 | /* | ||
1476 | * We can't leave the new entry's xe_name_offset at zero or | ||
1477 | * add_namevalue() will go nuts. We set it to the size of our | ||
1478 | * storage so that it can never be less than any other entry. | ||
1479 | */ | ||
1480 | loc->xl_entry->xe_name_offset = cpu_to_le16(loc->xl_size); | ||
1481 | } | ||
1482 | |||
1483 | static void ocfs2_xa_add_namevalue(struct ocfs2_xa_loc *loc, | ||
1484 | struct ocfs2_xattr_info *xi) | ||
1485 | { | ||
1486 | int size = namevalue_size_xi(xi); | ||
1487 | int nameval_offset; | ||
1488 | char *nameval_buf; | ||
1489 | |||
1490 | loc->xl_ops->xlo_add_namevalue(loc, size); | ||
1491 | loc->xl_entry->xe_value_size = cpu_to_le64(xi->xi_value_len); | ||
1492 | loc->xl_entry->xe_name_len = xi->xi_name_len; | ||
1493 | ocfs2_xattr_set_type(loc->xl_entry, xi->xi_name_index); | ||
1494 | ocfs2_xattr_set_local(loc->xl_entry, | ||
1495 | xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE); | ||
1496 | |||
1497 | nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1498 | nameval_buf = ocfs2_xa_offset_pointer(loc, nameval_offset); | ||
1499 | memset(nameval_buf, 0, size); | ||
1500 | memcpy(nameval_buf, xi->xi_name, xi->xi_name_len); | ||
1501 | } | ||
1502 | |||
1503 | static void ocfs2_xa_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1504 | struct ocfs2_xattr_value_buf *vb) | ||
1505 | { | ||
1506 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1507 | int name_size = OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len); | ||
1508 | |||
1509 | /* Value bufs are for value trees */ | ||
1510 | BUG_ON(ocfs2_xattr_is_local(loc->xl_entry)); | ||
1511 | BUG_ON(namevalue_size_xe(loc->xl_entry) != | ||
1512 | (name_size + OCFS2_XATTR_ROOT_SIZE)); | ||
1513 | |||
1514 | loc->xl_ops->xlo_fill_value_buf(loc, vb); | ||
1515 | vb->vb_xv = | ||
1516 | (struct ocfs2_xattr_value_root *)ocfs2_xa_offset_pointer(loc, | ||
1517 | nameval_offset + | ||
1518 | name_size); | ||
1519 | } | ||
1520 | |||
1521 | static int ocfs2_xa_block_journal_access(handle_t *handle, | ||
1522 | struct ocfs2_xa_loc *loc, int type) | ||
1523 | { | ||
1524 | struct buffer_head *bh = loc->xl_storage; | ||
1525 | ocfs2_journal_access_func access; | ||
1526 | |||
1527 | if (loc->xl_size == (bh->b_size - | ||
1528 | offsetof(struct ocfs2_xattr_block, | ||
1529 | xb_attrs.xb_header))) | ||
1530 | access = ocfs2_journal_access_xb; | ||
1531 | else | ||
1532 | access = ocfs2_journal_access_di; | ||
1533 | return access(handle, INODE_CACHE(loc->xl_inode), bh, type); | ||
1534 | } | ||
1535 | |||
1536 | static void ocfs2_xa_block_journal_dirty(handle_t *handle, | ||
1537 | struct ocfs2_xa_loc *loc) | ||
1538 | { | ||
1539 | struct buffer_head *bh = loc->xl_storage; | ||
1540 | |||
1541 | ocfs2_journal_dirty(handle, bh); | ||
1542 | } | ||
1543 | |||
1544 | static void *ocfs2_xa_block_offset_pointer(struct ocfs2_xa_loc *loc, | ||
1545 | int offset) | ||
1546 | { | ||
1547 | return (char *)loc->xl_header + offset; | ||
1548 | } | ||
1549 | |||
1550 | static int ocfs2_xa_block_can_reuse(struct ocfs2_xa_loc *loc, | ||
1551 | struct ocfs2_xattr_info *xi) | ||
1552 | { | ||
1553 | /* | ||
1554 | * Block storage is strict. If the sizes aren't exact, we will | ||
1555 | * remove the old one and reinsert the new. | ||
1556 | */ | ||
1557 | return namevalue_size_xe(loc->xl_entry) == | ||
1558 | namevalue_size_xi(xi); | ||
1559 | } | ||
1560 | |||
1561 | static int ocfs2_xa_block_get_free_start(struct ocfs2_xa_loc *loc) | ||
1562 | { | ||
1563 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1564 | int i, count = le16_to_cpu(xh->xh_count); | ||
1565 | int offset, free_start = loc->xl_size; | ||
1566 | |||
1567 | for (i = 0; i < count; i++) { | ||
1568 | offset = le16_to_cpu(xh->xh_entries[i].xe_name_offset); | ||
1569 | if (offset < free_start) | ||
1570 | free_start = offset; | ||
1406 | } | 1571 | } |
1407 | ret = ocfs2_xattr_update_entry(inode, ctxt->handle, xi, xs, vb, offs); | 1572 | |
1408 | if (ret < 0) { | 1573 | return free_start; |
1409 | mlog_errno(ret); | 1574 | } |
1410 | return ret; | 1575 | |
1576 | static int ocfs2_xa_block_check_space(struct ocfs2_xa_loc *loc, | ||
1577 | struct ocfs2_xattr_info *xi) | ||
1578 | { | ||
1579 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1580 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1581 | int needed_space = ocfs2_xi_entry_usage(xi); | ||
1582 | |||
1583 | /* | ||
1584 | * Block storage will reclaim the original entry before inserting | ||
1585 | * the new value, so we only need the difference. If the new | ||
1586 | * entry is smaller than the old one, we don't need anything. | ||
1587 | */ | ||
1588 | if (loc->xl_entry) { | ||
1589 | /* Don't need space if we're reusing! */ | ||
1590 | if (ocfs2_xa_can_reuse_entry(loc, xi)) | ||
1591 | needed_space = 0; | ||
1592 | else | ||
1593 | needed_space -= ocfs2_xe_entry_usage(loc->xl_entry); | ||
1411 | } | 1594 | } |
1412 | ret = __ocfs2_xattr_set_value_outside(inode, ctxt->handle, vb, | 1595 | if (needed_space < 0) |
1413 | xi->value, xi->value_len); | 1596 | needed_space = 0; |
1414 | if (ret < 0) | 1597 | return ocfs2_xa_check_space_helper(needed_space, free_start, count); |
1415 | mlog_errno(ret); | 1598 | } |
1416 | 1599 | ||
1417 | return ret; | 1600 | /* |
1601 | * Block storage for xattrs keeps the name+value pairs compacted. When | ||
1602 | * we remove one, we have to shift any that preceded it towards the end. | ||
1603 | */ | ||
1604 | static void ocfs2_xa_block_wipe_namevalue(struct ocfs2_xa_loc *loc) | ||
1605 | { | ||
1606 | int i, offset; | ||
1607 | int namevalue_offset, first_namevalue_offset, namevalue_size; | ||
1608 | struct ocfs2_xattr_entry *entry = loc->xl_entry; | ||
1609 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1610 | int count = le16_to_cpu(xh->xh_count); | ||
1611 | |||
1612 | namevalue_offset = le16_to_cpu(entry->xe_name_offset); | ||
1613 | namevalue_size = namevalue_size_xe(entry); | ||
1614 | first_namevalue_offset = ocfs2_xa_get_free_start(loc); | ||
1615 | |||
1616 | /* Shift the name+value pairs */ | ||
1617 | memmove((char *)xh + first_namevalue_offset + namevalue_size, | ||
1618 | (char *)xh + first_namevalue_offset, | ||
1619 | namevalue_offset - first_namevalue_offset); | ||
1620 | memset((char *)xh + first_namevalue_offset, 0, namevalue_size); | ||
1621 | |||
1622 | /* Now tell xh->xh_entries about it */ | ||
1623 | for (i = 0; i < count; i++) { | ||
1624 | offset = le16_to_cpu(xh->xh_entries[i].xe_name_offset); | ||
1625 | if (offset < namevalue_offset) | ||
1626 | le16_add_cpu(&xh->xh_entries[i].xe_name_offset, | ||
1627 | namevalue_size); | ||
1628 | } | ||
1629 | |||
1630 | /* | ||
1631 | * Note that we don't update xh_free_start or xh_name_value_len | ||
1632 | * because they're not used in block-stored xattrs. | ||
1633 | */ | ||
1634 | } | ||
1635 | |||
1636 | static void ocfs2_xa_block_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) | ||
1637 | { | ||
1638 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1639 | loc->xl_entry = &(loc->xl_header->xh_entries[count]); | ||
1640 | le16_add_cpu(&loc->xl_header->xh_count, 1); | ||
1641 | memset(loc->xl_entry, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1642 | } | ||
1643 | |||
1644 | static void ocfs2_xa_block_add_namevalue(struct ocfs2_xa_loc *loc, int size) | ||
1645 | { | ||
1646 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1647 | |||
1648 | loc->xl_entry->xe_name_offset = cpu_to_le16(free_start - size); | ||
1649 | } | ||
1650 | |||
1651 | static void ocfs2_xa_block_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1652 | struct ocfs2_xattr_value_buf *vb) | ||
1653 | { | ||
1654 | struct buffer_head *bh = loc->xl_storage; | ||
1655 | |||
1656 | if (loc->xl_size == (bh->b_size - | ||
1657 | offsetof(struct ocfs2_xattr_block, | ||
1658 | xb_attrs.xb_header))) | ||
1659 | vb->vb_access = ocfs2_journal_access_xb; | ||
1660 | else | ||
1661 | vb->vb_access = ocfs2_journal_access_di; | ||
1662 | vb->vb_bh = bh; | ||
1418 | } | 1663 | } |
1419 | 1664 | ||
1420 | /* | 1665 | /* |
1421 | * ocfs2_xattr_set_entry_local() | 1666 | * Operations for xattrs stored in blocks. This includes inline inode |
1422 | * | 1667 | * storage and unindexed ocfs2_xattr_blocks. |
1423 | * Set, replace or remove extended attribute in local. | ||
1424 | */ | 1668 | */ |
1425 | static void ocfs2_xattr_set_entry_local(struct inode *inode, | 1669 | static const struct ocfs2_xa_loc_operations ocfs2_xa_block_loc_ops = { |
1426 | struct ocfs2_xattr_info *xi, | 1670 | .xlo_journal_access = ocfs2_xa_block_journal_access, |
1427 | struct ocfs2_xattr_search *xs, | 1671 | .xlo_journal_dirty = ocfs2_xa_block_journal_dirty, |
1428 | struct ocfs2_xattr_entry *last, | 1672 | .xlo_offset_pointer = ocfs2_xa_block_offset_pointer, |
1429 | size_t min_offs) | 1673 | .xlo_check_space = ocfs2_xa_block_check_space, |
1674 | .xlo_can_reuse = ocfs2_xa_block_can_reuse, | ||
1675 | .xlo_get_free_start = ocfs2_xa_block_get_free_start, | ||
1676 | .xlo_wipe_namevalue = ocfs2_xa_block_wipe_namevalue, | ||
1677 | .xlo_add_entry = ocfs2_xa_block_add_entry, | ||
1678 | .xlo_add_namevalue = ocfs2_xa_block_add_namevalue, | ||
1679 | .xlo_fill_value_buf = ocfs2_xa_block_fill_value_buf, | ||
1680 | }; | ||
1681 | |||
1682 | static int ocfs2_xa_bucket_journal_access(handle_t *handle, | ||
1683 | struct ocfs2_xa_loc *loc, int type) | ||
1430 | { | 1684 | { |
1431 | size_t name_len = strlen(xi->name); | 1685 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; |
1432 | int i; | ||
1433 | 1686 | ||
1434 | if (xi->value && xs->not_found) { | 1687 | return ocfs2_xattr_bucket_journal_access(handle, bucket, type); |
1435 | /* Insert the new xattr entry. */ | 1688 | } |
1436 | le16_add_cpu(&xs->header->xh_count, 1); | 1689 | |
1437 | ocfs2_xattr_set_type(last, xi->name_index); | 1690 | static void ocfs2_xa_bucket_journal_dirty(handle_t *handle, |
1438 | ocfs2_xattr_set_local(last, 1); | 1691 | struct ocfs2_xa_loc *loc) |
1439 | last->xe_name_len = name_len; | 1692 | { |
1440 | } else { | 1693 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; |
1441 | void *first_val; | 1694 | |
1442 | void *val; | 1695 | ocfs2_xattr_bucket_journal_dirty(handle, bucket); |
1443 | size_t offs, size; | 1696 | } |
1444 | 1697 | ||
1445 | first_val = xs->base + min_offs; | 1698 | static void *ocfs2_xa_bucket_offset_pointer(struct ocfs2_xa_loc *loc, |
1446 | offs = le16_to_cpu(xs->here->xe_name_offset); | 1699 | int offset) |
1447 | val = xs->base + offs; | 1700 | { |
1448 | 1701 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | |
1449 | if (le64_to_cpu(xs->here->xe_value_size) > | 1702 | int block, block_offset; |
1450 | OCFS2_XATTR_INLINE_SIZE) | 1703 | |
1451 | size = OCFS2_XATTR_SIZE(name_len) + | 1704 | /* The header is at the front of the bucket */ |
1452 | OCFS2_XATTR_ROOT_SIZE; | 1705 | block = offset >> loc->xl_inode->i_sb->s_blocksize_bits; |
1706 | block_offset = offset % loc->xl_inode->i_sb->s_blocksize; | ||
1707 | |||
1708 | return bucket_block(bucket, block) + block_offset; | ||
1709 | } | ||
1710 | |||
1711 | static int ocfs2_xa_bucket_can_reuse(struct ocfs2_xa_loc *loc, | ||
1712 | struct ocfs2_xattr_info *xi) | ||
1713 | { | ||
1714 | return namevalue_size_xe(loc->xl_entry) >= | ||
1715 | namevalue_size_xi(xi); | ||
1716 | } | ||
1717 | |||
1718 | static int ocfs2_xa_bucket_get_free_start(struct ocfs2_xa_loc *loc) | ||
1719 | { | ||
1720 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | ||
1721 | return le16_to_cpu(bucket_xh(bucket)->xh_free_start); | ||
1722 | } | ||
1723 | |||
1724 | static int ocfs2_bucket_align_free_start(struct super_block *sb, | ||
1725 | int free_start, int size) | ||
1726 | { | ||
1727 | /* | ||
1728 | * We need to make sure that the name+value pair fits within | ||
1729 | * one block. | ||
1730 | */ | ||
1731 | if (((free_start - size) >> sb->s_blocksize_bits) != | ||
1732 | ((free_start - 1) >> sb->s_blocksize_bits)) | ||
1733 | free_start -= free_start % sb->s_blocksize; | ||
1734 | |||
1735 | return free_start; | ||
1736 | } | ||
1737 | |||
1738 | static int ocfs2_xa_bucket_check_space(struct ocfs2_xa_loc *loc, | ||
1739 | struct ocfs2_xattr_info *xi) | ||
1740 | { | ||
1741 | int rc; | ||
1742 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1743 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1744 | int needed_space = ocfs2_xi_entry_usage(xi); | ||
1745 | int size = namevalue_size_xi(xi); | ||
1746 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1747 | |||
1748 | /* | ||
1749 | * Bucket storage does not reclaim name+value pairs it cannot | ||
1750 | * reuse. They live as holes until the bucket fills, and then | ||
1751 | * the bucket is defragmented. However, the bucket can reclaim | ||
1752 | * the ocfs2_xattr_entry. | ||
1753 | */ | ||
1754 | if (loc->xl_entry) { | ||
1755 | /* Don't need space if we're reusing! */ | ||
1756 | if (ocfs2_xa_can_reuse_entry(loc, xi)) | ||
1757 | needed_space = 0; | ||
1453 | else | 1758 | else |
1454 | size = OCFS2_XATTR_SIZE(name_len) + | 1759 | needed_space -= sizeof(struct ocfs2_xattr_entry); |
1455 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | 1760 | } |
1456 | 1761 | BUG_ON(needed_space < 0); | |
1457 | if (xi->value && size == OCFS2_XATTR_SIZE(name_len) + | ||
1458 | OCFS2_XATTR_SIZE(xi->value_len)) { | ||
1459 | /* The old and the new value have the | ||
1460 | same size. Just replace the value. */ | ||
1461 | ocfs2_xattr_set_local(xs->here, 1); | ||
1462 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | ||
1463 | /* Clear value bytes. */ | ||
1464 | memset(val + OCFS2_XATTR_SIZE(name_len), | ||
1465 | 0, | ||
1466 | OCFS2_XATTR_SIZE(xi->value_len)); | ||
1467 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | ||
1468 | xi->value, | ||
1469 | xi->value_len); | ||
1470 | return; | ||
1471 | } | ||
1472 | /* Remove the old name+value. */ | ||
1473 | memmove(first_val + size, first_val, val - first_val); | ||
1474 | memset(first_val, 0, size); | ||
1475 | xs->here->xe_name_hash = 0; | ||
1476 | xs->here->xe_name_offset = 0; | ||
1477 | ocfs2_xattr_set_local(xs->here, 1); | ||
1478 | xs->here->xe_value_size = 0; | ||
1479 | |||
1480 | min_offs += size; | ||
1481 | |||
1482 | /* Adjust all value offsets. */ | ||
1483 | last = xs->header->xh_entries; | ||
1484 | for (i = 0 ; i < le16_to_cpu(xs->header->xh_count); i++) { | ||
1485 | size_t o = le16_to_cpu(last->xe_name_offset); | ||
1486 | |||
1487 | if (o < offs) | ||
1488 | last->xe_name_offset = cpu_to_le16(o + size); | ||
1489 | last += 1; | ||
1490 | } | ||
1491 | 1762 | ||
1492 | if (!xi->value) { | 1763 | if (free_start < size) { |
1493 | /* Remove the old entry. */ | 1764 | if (needed_space) |
1494 | last -= 1; | 1765 | return -ENOSPC; |
1495 | memmove(xs->here, xs->here + 1, | 1766 | } else { |
1496 | (void *)last - (void *)xs->here); | 1767 | /* |
1497 | memset(last, 0, sizeof(struct ocfs2_xattr_entry)); | 1768 | * First we check if it would fit in the first place. |
1498 | le16_add_cpu(&xs->header->xh_count, -1); | 1769 | * Below, we align the free start to a block. This may |
1499 | } | 1770 | * slide us below the minimum gap. By checking unaligned |
1771 | * first, we avoid that error. | ||
1772 | */ | ||
1773 | rc = ocfs2_xa_check_space_helper(needed_space, free_start, | ||
1774 | count); | ||
1775 | if (rc) | ||
1776 | return rc; | ||
1777 | free_start = ocfs2_bucket_align_free_start(sb, free_start, | ||
1778 | size); | ||
1500 | } | 1779 | } |
1501 | if (xi->value) { | 1780 | return ocfs2_xa_check_space_helper(needed_space, free_start, count); |
1502 | /* Insert the new name+value. */ | 1781 | } |
1503 | size_t size = OCFS2_XATTR_SIZE(name_len) + | 1782 | |
1504 | OCFS2_XATTR_SIZE(xi->value_len); | 1783 | static void ocfs2_xa_bucket_wipe_namevalue(struct ocfs2_xa_loc *loc) |
1505 | void *val = xs->base + min_offs - size; | 1784 | { |
1785 | le16_add_cpu(&loc->xl_header->xh_name_value_len, | ||
1786 | -namevalue_size_xe(loc->xl_entry)); | ||
1787 | } | ||
1506 | 1788 | ||
1507 | xs->here->xe_name_offset = cpu_to_le16(min_offs - size); | 1789 | static void ocfs2_xa_bucket_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) |
1508 | memset(val, 0, size); | 1790 | { |
1509 | memcpy(val, xi->name, name_len); | 1791 | struct ocfs2_xattr_header *xh = loc->xl_header; |
1510 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | 1792 | int count = le16_to_cpu(xh->xh_count); |
1511 | xi->value, | 1793 | int low = 0, high = count - 1, tmp; |
1512 | xi->value_len); | 1794 | struct ocfs2_xattr_entry *tmp_xe; |
1513 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | 1795 | |
1514 | ocfs2_xattr_set_local(xs->here, 1); | 1796 | /* |
1515 | ocfs2_xattr_hash_entry(inode, xs->header, xs->here); | 1797 | * We keep buckets sorted by name_hash, so we need to find |
1798 | * our insert place. | ||
1799 | */ | ||
1800 | while (low <= high && count) { | ||
1801 | tmp = (low + high) / 2; | ||
1802 | tmp_xe = &xh->xh_entries[tmp]; | ||
1803 | |||
1804 | if (name_hash > le32_to_cpu(tmp_xe->xe_name_hash)) | ||
1805 | low = tmp + 1; | ||
1806 | else if (name_hash < le32_to_cpu(tmp_xe->xe_name_hash)) | ||
1807 | high = tmp - 1; | ||
1808 | else { | ||
1809 | low = tmp; | ||
1810 | break; | ||
1811 | } | ||
1516 | } | 1812 | } |
1517 | 1813 | ||
1518 | return; | 1814 | if (low != count) |
1815 | memmove(&xh->xh_entries[low + 1], | ||
1816 | &xh->xh_entries[low], | ||
1817 | ((count - low) * sizeof(struct ocfs2_xattr_entry))); | ||
1818 | |||
1819 | le16_add_cpu(&xh->xh_count, 1); | ||
1820 | loc->xl_entry = &xh->xh_entries[low]; | ||
1821 | memset(loc->xl_entry, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1822 | } | ||
1823 | |||
1824 | static void ocfs2_xa_bucket_add_namevalue(struct ocfs2_xa_loc *loc, int size) | ||
1825 | { | ||
1826 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1827 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1828 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1829 | int nameval_offset; | ||
1830 | |||
1831 | free_start = ocfs2_bucket_align_free_start(sb, free_start, size); | ||
1832 | nameval_offset = free_start - size; | ||
1833 | loc->xl_entry->xe_name_offset = cpu_to_le16(nameval_offset); | ||
1834 | xh->xh_free_start = cpu_to_le16(nameval_offset); | ||
1835 | le16_add_cpu(&xh->xh_name_value_len, size); | ||
1836 | |||
1837 | } | ||
1838 | |||
1839 | static void ocfs2_xa_bucket_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1840 | struct ocfs2_xattr_value_buf *vb) | ||
1841 | { | ||
1842 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | ||
1843 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1844 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1845 | int size = namevalue_size_xe(loc->xl_entry); | ||
1846 | int block_offset = nameval_offset >> sb->s_blocksize_bits; | ||
1847 | |||
1848 | /* Values are not allowed to straddle block boundaries */ | ||
1849 | BUG_ON(block_offset != | ||
1850 | ((nameval_offset + size - 1) >> sb->s_blocksize_bits)); | ||
1851 | /* We expect the bucket to be filled in */ | ||
1852 | BUG_ON(!bucket->bu_bhs[block_offset]); | ||
1853 | |||
1854 | vb->vb_access = ocfs2_journal_access; | ||
1855 | vb->vb_bh = bucket->bu_bhs[block_offset]; | ||
1856 | } | ||
1857 | |||
1858 | /* Operations for xattrs stored in buckets. */ | ||
1859 | static const struct ocfs2_xa_loc_operations ocfs2_xa_bucket_loc_ops = { | ||
1860 | .xlo_journal_access = ocfs2_xa_bucket_journal_access, | ||
1861 | .xlo_journal_dirty = ocfs2_xa_bucket_journal_dirty, | ||
1862 | .xlo_offset_pointer = ocfs2_xa_bucket_offset_pointer, | ||
1863 | .xlo_check_space = ocfs2_xa_bucket_check_space, | ||
1864 | .xlo_can_reuse = ocfs2_xa_bucket_can_reuse, | ||
1865 | .xlo_get_free_start = ocfs2_xa_bucket_get_free_start, | ||
1866 | .xlo_wipe_namevalue = ocfs2_xa_bucket_wipe_namevalue, | ||
1867 | .xlo_add_entry = ocfs2_xa_bucket_add_entry, | ||
1868 | .xlo_add_namevalue = ocfs2_xa_bucket_add_namevalue, | ||
1869 | .xlo_fill_value_buf = ocfs2_xa_bucket_fill_value_buf, | ||
1870 | }; | ||
1871 | |||
1872 | static unsigned int ocfs2_xa_value_clusters(struct ocfs2_xa_loc *loc) | ||
1873 | { | ||
1874 | struct ocfs2_xattr_value_buf vb; | ||
1875 | |||
1876 | if (ocfs2_xattr_is_local(loc->xl_entry)) | ||
1877 | return 0; | ||
1878 | |||
1879 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
1880 | return le32_to_cpu(vb.vb_xv->xr_clusters); | ||
1881 | } | ||
1882 | |||
1883 | static int ocfs2_xa_value_truncate(struct ocfs2_xa_loc *loc, u64 bytes, | ||
1884 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
1885 | { | ||
1886 | int trunc_rc, access_rc; | ||
1887 | struct ocfs2_xattr_value_buf vb; | ||
1888 | |||
1889 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
1890 | trunc_rc = ocfs2_xattr_value_truncate(loc->xl_inode, &vb, bytes, | ||
1891 | ctxt); | ||
1892 | |||
1893 | /* | ||
1894 | * The caller of ocfs2_xa_value_truncate() has already called | ||
1895 | * ocfs2_xa_journal_access on the loc. However, The truncate code | ||
1896 | * calls ocfs2_extend_trans(). This may commit the previous | ||
1897 | * transaction and open a new one. If this is a bucket, truncate | ||
1898 | * could leave only vb->vb_bh set up for journaling. Meanwhile, | ||
1899 | * the caller is expecting to dirty the entire bucket. So we must | ||
1900 | * reset the journal work. We do this even if truncate has failed, | ||
1901 | * as it could have failed after committing the extend. | ||
1902 | */ | ||
1903 | access_rc = ocfs2_xa_journal_access(ctxt->handle, loc, | ||
1904 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
1905 | |||
1906 | /* Errors in truncate take precedence */ | ||
1907 | return trunc_rc ? trunc_rc : access_rc; | ||
1908 | } | ||
1909 | |||
1910 | static void ocfs2_xa_remove_entry(struct ocfs2_xa_loc *loc) | ||
1911 | { | ||
1912 | int index, count; | ||
1913 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1914 | struct ocfs2_xattr_entry *entry = loc->xl_entry; | ||
1915 | |||
1916 | ocfs2_xa_wipe_namevalue(loc); | ||
1917 | loc->xl_entry = NULL; | ||
1918 | |||
1919 | le16_add_cpu(&xh->xh_count, -1); | ||
1920 | count = le16_to_cpu(xh->xh_count); | ||
1921 | |||
1922 | /* | ||
1923 | * Only zero out the entry if there are more remaining. This is | ||
1924 | * important for an empty bucket, as it keeps track of the | ||
1925 | * bucket's hash value. It doesn't hurt empty block storage. | ||
1926 | */ | ||
1927 | if (count) { | ||
1928 | index = ((char *)entry - (char *)&xh->xh_entries) / | ||
1929 | sizeof(struct ocfs2_xattr_entry); | ||
1930 | memmove(&xh->xh_entries[index], &xh->xh_entries[index + 1], | ||
1931 | (count - index) * sizeof(struct ocfs2_xattr_entry)); | ||
1932 | memset(&xh->xh_entries[count], 0, | ||
1933 | sizeof(struct ocfs2_xattr_entry)); | ||
1934 | } | ||
1519 | } | 1935 | } |
1520 | 1936 | ||
1521 | /* | 1937 | /* |
1522 | * ocfs2_xattr_set_entry() | 1938 | * If we have a problem adjusting the size of an external value during |
1939 | * ocfs2_xa_prepare_entry() or ocfs2_xa_remove(), we may have an xattr | ||
1940 | * in an intermediate state. For example, the value may be partially | ||
1941 | * truncated. | ||
1942 | * | ||
1943 | * If the value tree hasn't changed, the extend/truncate went nowhere. | ||
1944 | * We have nothing to do. The caller can treat it as a straight error. | ||
1523 | * | 1945 | * |
1524 | * Set extended attribute entry into inode or block. | 1946 | * If the value tree got partially truncated, we now have a corrupted |
1947 | * extended attribute. We're going to wipe its entry and leak the | ||
1948 | * clusters. Better to leak some storage than leave a corrupt entry. | ||
1525 | * | 1949 | * |
1526 | * If extended attribute value size > OCFS2_XATTR_INLINE_SIZE, | 1950 | * If the value tree grew, it obviously didn't grow enough for the |
1527 | * We first insert tree root(ocfs2_xattr_value_root) with set_entry_local(), | 1951 | * new entry. We're not going to try and reclaim those clusters either. |
1528 | * then set value in B tree with set_value_outside(). | 1952 | * If there was already an external value there (orig_clusters != 0), |
1953 | * the new clusters are attached safely and we can just leave the old | ||
1954 | * value in place. If there was no external value there, we remove | ||
1955 | * the entry. | ||
1956 | * | ||
1957 | * This way, the xattr block we store in the journal will be consistent. | ||
1958 | * If the size change broke because of the journal, no changes will hit | ||
1959 | * disk anyway. | ||
1529 | */ | 1960 | */ |
1530 | static int ocfs2_xattr_set_entry(struct inode *inode, | 1961 | static void ocfs2_xa_cleanup_value_truncate(struct ocfs2_xa_loc *loc, |
1531 | struct ocfs2_xattr_info *xi, | 1962 | const char *what, |
1532 | struct ocfs2_xattr_search *xs, | 1963 | unsigned int orig_clusters) |
1533 | struct ocfs2_xattr_set_ctxt *ctxt, | 1964 | { |
1534 | int flag) | 1965 | unsigned int new_clusters = ocfs2_xa_value_clusters(loc); |
1535 | { | 1966 | char *nameval_buf = ocfs2_xa_offset_pointer(loc, |
1536 | struct ocfs2_xattr_entry *last; | 1967 | le16_to_cpu(loc->xl_entry->xe_name_offset)); |
1537 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 1968 | |
1538 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; | 1969 | if (new_clusters < orig_clusters) { |
1539 | size_t min_offs = xs->end - xs->base, name_len = strlen(xi->name); | 1970 | mlog(ML_ERROR, |
1540 | size_t size_l = 0; | 1971 | "Partial truncate while %s xattr %.*s. Leaking " |
1541 | handle_t *handle = ctxt->handle; | 1972 | "%u clusters and removing the entry\n", |
1542 | int free, i, ret; | 1973 | what, loc->xl_entry->xe_name_len, nameval_buf, |
1543 | struct ocfs2_xattr_info xi_l = { | 1974 | orig_clusters - new_clusters); |
1544 | .name_index = xi->name_index, | 1975 | ocfs2_xa_remove_entry(loc); |
1545 | .name = xi->name, | 1976 | } else if (!orig_clusters) { |
1546 | .value = xi->value, | 1977 | mlog(ML_ERROR, |
1547 | .value_len = xi->value_len, | 1978 | "Unable to allocate an external value for xattr " |
1548 | }; | 1979 | "%.*s safely. Leaking %u clusters and removing the " |
1549 | struct ocfs2_xattr_value_buf vb = { | 1980 | "entry\n", |
1550 | .vb_bh = xs->xattr_bh, | 1981 | loc->xl_entry->xe_name_len, nameval_buf, |
1551 | .vb_access = ocfs2_journal_access_di, | 1982 | new_clusters - orig_clusters); |
1552 | }; | 1983 | ocfs2_xa_remove_entry(loc); |
1984 | } else if (new_clusters > orig_clusters) | ||
1985 | mlog(ML_ERROR, | ||
1986 | "Unable to grow xattr %.*s safely. %u new clusters " | ||
1987 | "have been added, but the value will not be " | ||
1988 | "modified\n", | ||
1989 | loc->xl_entry->xe_name_len, nameval_buf, | ||
1990 | new_clusters - orig_clusters); | ||
1991 | } | ||
1992 | |||
1993 | static int ocfs2_xa_remove(struct ocfs2_xa_loc *loc, | ||
1994 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
1995 | { | ||
1996 | int rc = 0; | ||
1997 | unsigned int orig_clusters; | ||
1998 | |||
1999 | if (!ocfs2_xattr_is_local(loc->xl_entry)) { | ||
2000 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2001 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2002 | if (rc) { | ||
2003 | mlog_errno(rc); | ||
2004 | /* | ||
2005 | * Since this is remove, we can return 0 if | ||
2006 | * ocfs2_xa_cleanup_value_truncate() is going to | ||
2007 | * wipe the entry anyway. So we check the | ||
2008 | * cluster count as well. | ||
2009 | */ | ||
2010 | if (orig_clusters != ocfs2_xa_value_clusters(loc)) | ||
2011 | rc = 0; | ||
2012 | ocfs2_xa_cleanup_value_truncate(loc, "removing", | ||
2013 | orig_clusters); | ||
2014 | if (rc) | ||
2015 | goto out; | ||
2016 | } | ||
2017 | } | ||
1553 | 2018 | ||
1554 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | 2019 | ocfs2_xa_remove_entry(loc); |
1555 | BUG_ON(xs->xattr_bh == xs->inode_bh); | ||
1556 | vb.vb_access = ocfs2_journal_access_xb; | ||
1557 | } else | ||
1558 | BUG_ON(xs->xattr_bh != xs->inode_bh); | ||
1559 | 2020 | ||
1560 | /* Compute min_offs, last and free space. */ | 2021 | out: |
1561 | last = xs->header->xh_entries; | 2022 | return rc; |
2023 | } | ||
1562 | 2024 | ||
1563 | for (i = 0 ; i < le16_to_cpu(xs->header->xh_count); i++) { | 2025 | static void ocfs2_xa_install_value_root(struct ocfs2_xa_loc *loc) |
1564 | size_t offs = le16_to_cpu(last->xe_name_offset); | 2026 | { |
1565 | if (offs < min_offs) | 2027 | int name_size = OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len); |
1566 | min_offs = offs; | 2028 | char *nameval_buf; |
1567 | last += 1; | ||
1568 | } | ||
1569 | 2029 | ||
1570 | free = min_offs - ((void *)last - xs->base) - OCFS2_XATTR_HEADER_GAP; | 2030 | nameval_buf = ocfs2_xa_offset_pointer(loc, |
1571 | if (free < 0) | 2031 | le16_to_cpu(loc->xl_entry->xe_name_offset)); |
1572 | return -EIO; | 2032 | memcpy(nameval_buf + name_size, &def_xv, OCFS2_XATTR_ROOT_SIZE); |
2033 | } | ||
1573 | 2034 | ||
1574 | if (!xs->not_found) { | 2035 | /* |
1575 | size_t size = 0; | 2036 | * Take an existing entry and make it ready for the new value. This |
1576 | if (ocfs2_xattr_is_local(xs->here)) | 2037 | * won't allocate space, but it may free space. It should be ready for |
1577 | size = OCFS2_XATTR_SIZE(name_len) + | 2038 | * ocfs2_xa_prepare_entry() to finish the work. |
1578 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | 2039 | */ |
1579 | else | 2040 | static int ocfs2_xa_reuse_entry(struct ocfs2_xa_loc *loc, |
1580 | size = OCFS2_XATTR_SIZE(name_len) + | 2041 | struct ocfs2_xattr_info *xi, |
1581 | OCFS2_XATTR_ROOT_SIZE; | 2042 | struct ocfs2_xattr_set_ctxt *ctxt) |
1582 | free += (size + sizeof(struct ocfs2_xattr_entry)); | 2043 | { |
1583 | } | 2044 | int rc = 0; |
1584 | /* Check free space in inode or block */ | 2045 | int name_size = OCFS2_XATTR_SIZE(xi->xi_name_len); |
1585 | if (xi->value && xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2046 | unsigned int orig_clusters; |
1586 | if (free < sizeof(struct ocfs2_xattr_entry) + | 2047 | char *nameval_buf; |
1587 | OCFS2_XATTR_SIZE(name_len) + | 2048 | int xe_local = ocfs2_xattr_is_local(loc->xl_entry); |
1588 | OCFS2_XATTR_ROOT_SIZE) { | 2049 | int xi_local = xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE; |
1589 | ret = -ENOSPC; | 2050 | |
1590 | goto out; | 2051 | BUG_ON(OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len) != |
2052 | name_size); | ||
2053 | |||
2054 | nameval_buf = ocfs2_xa_offset_pointer(loc, | ||
2055 | le16_to_cpu(loc->xl_entry->xe_name_offset)); | ||
2056 | if (xe_local) { | ||
2057 | memset(nameval_buf + name_size, 0, | ||
2058 | namevalue_size_xe(loc->xl_entry) - name_size); | ||
2059 | if (!xi_local) | ||
2060 | ocfs2_xa_install_value_root(loc); | ||
2061 | } else { | ||
2062 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2063 | if (xi_local) { | ||
2064 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2065 | if (rc < 0) | ||
2066 | mlog_errno(rc); | ||
2067 | else | ||
2068 | memset(nameval_buf + name_size, 0, | ||
2069 | namevalue_size_xe(loc->xl_entry) - | ||
2070 | name_size); | ||
2071 | } else if (le64_to_cpu(loc->xl_entry->xe_value_size) > | ||
2072 | xi->xi_value_len) { | ||
2073 | rc = ocfs2_xa_value_truncate(loc, xi->xi_value_len, | ||
2074 | ctxt); | ||
2075 | if (rc < 0) | ||
2076 | mlog_errno(rc); | ||
1591 | } | 2077 | } |
1592 | size_l = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | 2078 | |
1593 | xi_l.value = (void *)&def_xv; | 2079 | if (rc) { |
1594 | xi_l.value_len = OCFS2_XATTR_ROOT_SIZE; | 2080 | ocfs2_xa_cleanup_value_truncate(loc, "reusing", |
1595 | } else if (xi->value) { | 2081 | orig_clusters); |
1596 | if (free < sizeof(struct ocfs2_xattr_entry) + | ||
1597 | OCFS2_XATTR_SIZE(name_len) + | ||
1598 | OCFS2_XATTR_SIZE(xi->value_len)) { | ||
1599 | ret = -ENOSPC; | ||
1600 | goto out; | 2082 | goto out; |
1601 | } | 2083 | } |
1602 | } | 2084 | } |
1603 | 2085 | ||
1604 | if (!xs->not_found) { | 2086 | loc->xl_entry->xe_value_size = cpu_to_le64(xi->xi_value_len); |
1605 | /* For existing extended attribute */ | 2087 | ocfs2_xattr_set_local(loc->xl_entry, xi_local); |
1606 | size_t size = OCFS2_XATTR_SIZE(name_len) + | ||
1607 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | ||
1608 | size_t offs = le16_to_cpu(xs->here->xe_name_offset); | ||
1609 | void *val = xs->base + offs; | ||
1610 | 2088 | ||
1611 | if (ocfs2_xattr_is_local(xs->here) && size == size_l) { | 2089 | out: |
1612 | /* Replace existing local xattr with tree root */ | 2090 | return rc; |
1613 | ret = ocfs2_xattr_set_value_outside(inode, xi, xs, | 2091 | } |
1614 | ctxt, &vb, offs); | ||
1615 | if (ret < 0) | ||
1616 | mlog_errno(ret); | ||
1617 | goto out; | ||
1618 | } else if (!ocfs2_xattr_is_local(xs->here)) { | ||
1619 | /* For existing xattr which has value outside */ | ||
1620 | vb.vb_xv = (struct ocfs2_xattr_value_root *) | ||
1621 | (val + OCFS2_XATTR_SIZE(name_len)); | ||
1622 | 2092 | ||
1623 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2093 | /* |
1624 | /* | 2094 | * Prepares loc->xl_entry to receive the new xattr. This includes |
1625 | * If new value need set outside also, | 2095 | * properly setting up the name+value pair region. If loc->xl_entry |
1626 | * first truncate old value to new value, | 2096 | * already exists, it will take care of modifying it appropriately. |
1627 | * then set new value with set_value_outside(). | 2097 | * |
1628 | */ | 2098 | * Note that this modifies the data. You did journal_access already, |
1629 | ret = ocfs2_xattr_value_truncate(inode, | 2099 | * right? |
1630 | &vb, | 2100 | */ |
1631 | xi->value_len, | 2101 | static int ocfs2_xa_prepare_entry(struct ocfs2_xa_loc *loc, |
1632 | ctxt); | 2102 | struct ocfs2_xattr_info *xi, |
1633 | if (ret < 0) { | 2103 | u32 name_hash, |
1634 | mlog_errno(ret); | 2104 | struct ocfs2_xattr_set_ctxt *ctxt) |
1635 | goto out; | 2105 | { |
1636 | } | 2106 | int rc = 0; |
2107 | unsigned int orig_clusters; | ||
2108 | __le64 orig_value_size = 0; | ||
1637 | 2109 | ||
1638 | ret = ocfs2_xattr_update_entry(inode, | 2110 | rc = ocfs2_xa_check_space(loc, xi); |
1639 | handle, | 2111 | if (rc) |
1640 | xi, | 2112 | goto out; |
1641 | xs, | ||
1642 | &vb, | ||
1643 | offs); | ||
1644 | if (ret < 0) { | ||
1645 | mlog_errno(ret); | ||
1646 | goto out; | ||
1647 | } | ||
1648 | 2113 | ||
1649 | ret = __ocfs2_xattr_set_value_outside(inode, | 2114 | if (loc->xl_entry) { |
1650 | handle, | 2115 | if (ocfs2_xa_can_reuse_entry(loc, xi)) { |
1651 | &vb, | 2116 | orig_value_size = loc->xl_entry->xe_value_size; |
1652 | xi->value, | 2117 | rc = ocfs2_xa_reuse_entry(loc, xi, ctxt); |
1653 | xi->value_len); | 2118 | if (rc) |
1654 | if (ret < 0) | 2119 | goto out; |
1655 | mlog_errno(ret); | 2120 | goto alloc_value; |
2121 | } | ||
2122 | |||
2123 | if (!ocfs2_xattr_is_local(loc->xl_entry)) { | ||
2124 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2125 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2126 | if (rc) { | ||
2127 | mlog_errno(rc); | ||
2128 | ocfs2_xa_cleanup_value_truncate(loc, | ||
2129 | "overwriting", | ||
2130 | orig_clusters); | ||
1656 | goto out; | 2131 | goto out; |
1657 | } else { | ||
1658 | /* | ||
1659 | * If new value need set in local, | ||
1660 | * just trucate old value to zero. | ||
1661 | */ | ||
1662 | ret = ocfs2_xattr_value_truncate(inode, | ||
1663 | &vb, | ||
1664 | 0, | ||
1665 | ctxt); | ||
1666 | if (ret < 0) | ||
1667 | mlog_errno(ret); | ||
1668 | } | 2132 | } |
1669 | } | 2133 | } |
2134 | ocfs2_xa_wipe_namevalue(loc); | ||
2135 | } else | ||
2136 | ocfs2_xa_add_entry(loc, name_hash); | ||
2137 | |||
2138 | /* | ||
2139 | * If we get here, we have a blank entry. Fill it. We grow our | ||
2140 | * name+value pair back from the end. | ||
2141 | */ | ||
2142 | ocfs2_xa_add_namevalue(loc, xi); | ||
2143 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) | ||
2144 | ocfs2_xa_install_value_root(loc); | ||
2145 | |||
2146 | alloc_value: | ||
2147 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
2148 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2149 | rc = ocfs2_xa_value_truncate(loc, xi->xi_value_len, ctxt); | ||
2150 | if (rc < 0) { | ||
2151 | /* | ||
2152 | * If we tried to grow an existing external value, | ||
2153 | * ocfs2_xa_cleanuP-value_truncate() is going to | ||
2154 | * let it stand. We have to restore its original | ||
2155 | * value size. | ||
2156 | */ | ||
2157 | loc->xl_entry->xe_value_size = orig_value_size; | ||
2158 | ocfs2_xa_cleanup_value_truncate(loc, "growing", | ||
2159 | orig_clusters); | ||
2160 | mlog_errno(rc); | ||
2161 | } | ||
1670 | } | 2162 | } |
1671 | 2163 | ||
1672 | ret = ocfs2_journal_access_di(handle, INODE_CACHE(inode), xs->inode_bh, | 2164 | out: |
2165 | return rc; | ||
2166 | } | ||
2167 | |||
2168 | /* | ||
2169 | * Store the value portion of the name+value pair. This will skip | ||
2170 | * values that are stored externally. Their tree roots were set up | ||
2171 | * by ocfs2_xa_prepare_entry(). | ||
2172 | */ | ||
2173 | static int ocfs2_xa_store_value(struct ocfs2_xa_loc *loc, | ||
2174 | struct ocfs2_xattr_info *xi, | ||
2175 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2176 | { | ||
2177 | int rc = 0; | ||
2178 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
2179 | int name_size = OCFS2_XATTR_SIZE(xi->xi_name_len); | ||
2180 | char *nameval_buf; | ||
2181 | struct ocfs2_xattr_value_buf vb; | ||
2182 | |||
2183 | nameval_buf = ocfs2_xa_offset_pointer(loc, nameval_offset); | ||
2184 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
2185 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
2186 | rc = __ocfs2_xattr_set_value_outside(loc->xl_inode, | ||
2187 | ctxt->handle, &vb, | ||
2188 | xi->xi_value, | ||
2189 | xi->xi_value_len); | ||
2190 | } else | ||
2191 | memcpy(nameval_buf + name_size, xi->xi_value, xi->xi_value_len); | ||
2192 | |||
2193 | return rc; | ||
2194 | } | ||
2195 | |||
2196 | static int ocfs2_xa_set(struct ocfs2_xa_loc *loc, | ||
2197 | struct ocfs2_xattr_info *xi, | ||
2198 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2199 | { | ||
2200 | int ret; | ||
2201 | u32 name_hash = ocfs2_xattr_name_hash(loc->xl_inode, xi->xi_name, | ||
2202 | xi->xi_name_len); | ||
2203 | |||
2204 | ret = ocfs2_xa_journal_access(ctxt->handle, loc, | ||
1673 | OCFS2_JOURNAL_ACCESS_WRITE); | 2205 | OCFS2_JOURNAL_ACCESS_WRITE); |
1674 | if (ret) { | 2206 | if (ret) { |
1675 | mlog_errno(ret); | 2207 | mlog_errno(ret); |
1676 | goto out; | 2208 | goto out; |
1677 | } | 2209 | } |
1678 | 2210 | ||
1679 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | ||
1680 | ret = vb.vb_access(handle, INODE_CACHE(inode), vb.vb_bh, | ||
1681 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
1682 | if (ret) { | ||
1683 | mlog_errno(ret); | ||
1684 | goto out; | ||
1685 | } | ||
1686 | } | ||
1687 | |||
1688 | /* | 2211 | /* |
1689 | * Set value in local, include set tree root in local. | 2212 | * From here on out, everything is going to modify the buffer a |
1690 | * This is the first step for value size >INLINE_SIZE. | 2213 | * little. Errors are going to leave the xattr header in a |
2214 | * sane state. Thus, even with errors we dirty the sucker. | ||
1691 | */ | 2215 | */ |
1692 | ocfs2_xattr_set_entry_local(inode, &xi_l, xs, last, min_offs); | ||
1693 | 2216 | ||
1694 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | 2217 | /* Don't worry, we are never called with !xi_value and !xl_entry */ |
1695 | ret = ocfs2_journal_dirty(handle, xs->xattr_bh); | 2218 | if (!xi->xi_value) { |
1696 | if (ret < 0) { | 2219 | ret = ocfs2_xa_remove(loc, ctxt); |
1697 | mlog_errno(ret); | 2220 | goto out_dirty; |
1698 | goto out; | ||
1699 | } | ||
1700 | } | 2221 | } |
1701 | 2222 | ||
1702 | if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL) && | 2223 | ret = ocfs2_xa_prepare_entry(loc, xi, name_hash, ctxt); |
1703 | (flag & OCFS2_INLINE_XATTR_FL)) { | 2224 | if (ret) { |
1704 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 2225 | if (ret != -ENOSPC) |
1705 | unsigned int xattrsize = osb->s_xattr_inline_size; | 2226 | mlog_errno(ret); |
1706 | 2227 | goto out_dirty; | |
1707 | /* | ||
1708 | * Adjust extent record count or inline data size | ||
1709 | * to reserve space for extended attribute. | ||
1710 | */ | ||
1711 | if (oi->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | ||
1712 | struct ocfs2_inline_data *idata = &di->id2.i_data; | ||
1713 | le16_add_cpu(&idata->id_count, -xattrsize); | ||
1714 | } else if (!(ocfs2_inode_is_fast_symlink(inode))) { | ||
1715 | struct ocfs2_extent_list *el = &di->id2.i_list; | ||
1716 | le16_add_cpu(&el->l_count, -(xattrsize / | ||
1717 | sizeof(struct ocfs2_extent_rec))); | ||
1718 | } | ||
1719 | di->i_xattr_inline_size = cpu_to_le16(xattrsize); | ||
1720 | } | 2228 | } |
1721 | /* Update xattr flag */ | ||
1722 | spin_lock(&oi->ip_lock); | ||
1723 | oi->ip_dyn_features |= flag; | ||
1724 | di->i_dyn_features = cpu_to_le16(oi->ip_dyn_features); | ||
1725 | spin_unlock(&oi->ip_lock); | ||
1726 | 2229 | ||
1727 | ret = ocfs2_journal_dirty(handle, xs->inode_bh); | 2230 | ret = ocfs2_xa_store_value(loc, xi, ctxt); |
1728 | if (ret < 0) | 2231 | if (ret) |
1729 | mlog_errno(ret); | 2232 | mlog_errno(ret); |
1730 | 2233 | ||
1731 | if (!ret && xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2234 | out_dirty: |
1732 | /* | 2235 | ocfs2_xa_journal_dirty(ctxt->handle, loc); |
1733 | * Set value outside in B tree. | ||
1734 | * This is the second step for value size > INLINE_SIZE. | ||
1735 | */ | ||
1736 | size_t offs = le16_to_cpu(xs->here->xe_name_offset); | ||
1737 | ret = ocfs2_xattr_set_value_outside(inode, xi, xs, ctxt, | ||
1738 | &vb, offs); | ||
1739 | if (ret < 0) { | ||
1740 | int ret2; | ||
1741 | 2236 | ||
1742 | mlog_errno(ret); | ||
1743 | /* | ||
1744 | * If set value outside failed, we have to clean | ||
1745 | * the junk tree root we have already set in local. | ||
1746 | */ | ||
1747 | ret2 = ocfs2_xattr_cleanup(inode, ctxt->handle, | ||
1748 | xi, xs, &vb, offs); | ||
1749 | if (ret2 < 0) | ||
1750 | mlog_errno(ret2); | ||
1751 | } | ||
1752 | } | ||
1753 | out: | 2237 | out: |
1754 | return ret; | 2238 | return ret; |
1755 | } | 2239 | } |
1756 | 2240 | ||
2241 | static void ocfs2_init_dinode_xa_loc(struct ocfs2_xa_loc *loc, | ||
2242 | struct inode *inode, | ||
2243 | struct buffer_head *bh, | ||
2244 | struct ocfs2_xattr_entry *entry) | ||
2245 | { | ||
2246 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)bh->b_data; | ||
2247 | |||
2248 | BUG_ON(!(OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_XATTR_FL)); | ||
2249 | |||
2250 | loc->xl_inode = inode; | ||
2251 | loc->xl_ops = &ocfs2_xa_block_loc_ops; | ||
2252 | loc->xl_storage = bh; | ||
2253 | loc->xl_entry = entry; | ||
2254 | loc->xl_size = le16_to_cpu(di->i_xattr_inline_size); | ||
2255 | loc->xl_header = | ||
2256 | (struct ocfs2_xattr_header *)(bh->b_data + bh->b_size - | ||
2257 | loc->xl_size); | ||
2258 | } | ||
2259 | |||
2260 | static void ocfs2_init_xattr_block_xa_loc(struct ocfs2_xa_loc *loc, | ||
2261 | struct inode *inode, | ||
2262 | struct buffer_head *bh, | ||
2263 | struct ocfs2_xattr_entry *entry) | ||
2264 | { | ||
2265 | struct ocfs2_xattr_block *xb = | ||
2266 | (struct ocfs2_xattr_block *)bh->b_data; | ||
2267 | |||
2268 | BUG_ON(le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED); | ||
2269 | |||
2270 | loc->xl_inode = inode; | ||
2271 | loc->xl_ops = &ocfs2_xa_block_loc_ops; | ||
2272 | loc->xl_storage = bh; | ||
2273 | loc->xl_header = &(xb->xb_attrs.xb_header); | ||
2274 | loc->xl_entry = entry; | ||
2275 | loc->xl_size = bh->b_size - offsetof(struct ocfs2_xattr_block, | ||
2276 | xb_attrs.xb_header); | ||
2277 | } | ||
2278 | |||
2279 | static void ocfs2_init_xattr_bucket_xa_loc(struct ocfs2_xa_loc *loc, | ||
2280 | struct ocfs2_xattr_bucket *bucket, | ||
2281 | struct ocfs2_xattr_entry *entry) | ||
2282 | { | ||
2283 | loc->xl_inode = bucket->bu_inode; | ||
2284 | loc->xl_ops = &ocfs2_xa_bucket_loc_ops; | ||
2285 | loc->xl_storage = bucket; | ||
2286 | loc->xl_header = bucket_xh(bucket); | ||
2287 | loc->xl_entry = entry; | ||
2288 | loc->xl_size = OCFS2_XATTR_BUCKET_SIZE; | ||
2289 | } | ||
2290 | |||
1757 | /* | 2291 | /* |
1758 | * In xattr remove, if it is stored outside and refcounted, we may have | 2292 | * In xattr remove, if it is stored outside and refcounted, we may have |
1759 | * the chance to split the refcount tree. So need the allocators. | 2293 | * the chance to split the refcount tree. So need the allocators. |
@@ -2149,6 +2683,55 @@ static int ocfs2_xattr_ibody_find(struct inode *inode, | |||
2149 | return 0; | 2683 | return 0; |
2150 | } | 2684 | } |
2151 | 2685 | ||
2686 | static int ocfs2_xattr_ibody_init(struct inode *inode, | ||
2687 | struct buffer_head *di_bh, | ||
2688 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2689 | { | ||
2690 | int ret; | ||
2691 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | ||
2692 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)di_bh->b_data; | ||
2693 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | ||
2694 | unsigned int xattrsize = osb->s_xattr_inline_size; | ||
2695 | |||
2696 | if (!ocfs2_xattr_has_space_inline(inode, di)) { | ||
2697 | ret = -ENOSPC; | ||
2698 | goto out; | ||
2699 | } | ||
2700 | |||
2701 | ret = ocfs2_journal_access_di(ctxt->handle, INODE_CACHE(inode), di_bh, | ||
2702 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
2703 | if (ret) { | ||
2704 | mlog_errno(ret); | ||
2705 | goto out; | ||
2706 | } | ||
2707 | |||
2708 | /* | ||
2709 | * Adjust extent record count or inline data size | ||
2710 | * to reserve space for extended attribute. | ||
2711 | */ | ||
2712 | if (oi->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | ||
2713 | struct ocfs2_inline_data *idata = &di->id2.i_data; | ||
2714 | le16_add_cpu(&idata->id_count, -xattrsize); | ||
2715 | } else if (!(ocfs2_inode_is_fast_symlink(inode))) { | ||
2716 | struct ocfs2_extent_list *el = &di->id2.i_list; | ||
2717 | le16_add_cpu(&el->l_count, -(xattrsize / | ||
2718 | sizeof(struct ocfs2_extent_rec))); | ||
2719 | } | ||
2720 | di->i_xattr_inline_size = cpu_to_le16(xattrsize); | ||
2721 | |||
2722 | spin_lock(&oi->ip_lock); | ||
2723 | oi->ip_dyn_features |= OCFS2_INLINE_XATTR_FL|OCFS2_HAS_XATTR_FL; | ||
2724 | di->i_dyn_features = cpu_to_le16(oi->ip_dyn_features); | ||
2725 | spin_unlock(&oi->ip_lock); | ||
2726 | |||
2727 | ret = ocfs2_journal_dirty(ctxt->handle, di_bh); | ||
2728 | if (ret < 0) | ||
2729 | mlog_errno(ret); | ||
2730 | |||
2731 | out: | ||
2732 | return ret; | ||
2733 | } | ||
2734 | |||
2152 | /* | 2735 | /* |
2153 | * ocfs2_xattr_ibody_set() | 2736 | * ocfs2_xattr_ibody_set() |
2154 | * | 2737 | * |
@@ -2160,9 +2743,10 @@ static int ocfs2_xattr_ibody_set(struct inode *inode, | |||
2160 | struct ocfs2_xattr_search *xs, | 2743 | struct ocfs2_xattr_search *xs, |
2161 | struct ocfs2_xattr_set_ctxt *ctxt) | 2744 | struct ocfs2_xattr_set_ctxt *ctxt) |
2162 | { | 2745 | { |
2746 | int ret; | ||
2163 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 2747 | struct ocfs2_inode_info *oi = OCFS2_I(inode); |
2164 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; | 2748 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; |
2165 | int ret; | 2749 | struct ocfs2_xa_loc loc; |
2166 | 2750 | ||
2167 | if (inode->i_sb->s_blocksize == OCFS2_MIN_BLOCKSIZE) | 2751 | if (inode->i_sb->s_blocksize == OCFS2_MIN_BLOCKSIZE) |
2168 | return -ENOSPC; | 2752 | return -ENOSPC; |
@@ -2175,8 +2759,25 @@ static int ocfs2_xattr_ibody_set(struct inode *inode, | |||
2175 | } | 2759 | } |
2176 | } | 2760 | } |
2177 | 2761 | ||
2178 | ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt, | 2762 | if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL)) { |
2179 | (OCFS2_INLINE_XATTR_FL | OCFS2_HAS_XATTR_FL)); | 2763 | ret = ocfs2_xattr_ibody_init(inode, xs->inode_bh, ctxt); |
2764 | if (ret) { | ||
2765 | if (ret != -ENOSPC) | ||
2766 | mlog_errno(ret); | ||
2767 | goto out; | ||
2768 | } | ||
2769 | } | ||
2770 | |||
2771 | ocfs2_init_dinode_xa_loc(&loc, inode, xs->inode_bh, | ||
2772 | xs->not_found ? NULL : xs->here); | ||
2773 | ret = ocfs2_xa_set(&loc, xi, ctxt); | ||
2774 | if (ret) { | ||
2775 | if (ret != -ENOSPC) | ||
2776 | mlog_errno(ret); | ||
2777 | goto out; | ||
2778 | } | ||
2779 | xs->here = loc.xl_entry; | ||
2780 | |||
2180 | out: | 2781 | out: |
2181 | up_write(&oi->ip_alloc_sem); | 2782 | up_write(&oi->ip_alloc_sem); |
2182 | 2783 | ||
@@ -2236,12 +2837,11 @@ cleanup: | |||
2236 | return ret; | 2837 | return ret; |
2237 | } | 2838 | } |
2238 | 2839 | ||
2239 | static int ocfs2_create_xattr_block(handle_t *handle, | 2840 | static int ocfs2_create_xattr_block(struct inode *inode, |
2240 | struct inode *inode, | ||
2241 | struct buffer_head *inode_bh, | 2841 | struct buffer_head *inode_bh, |
2242 | struct ocfs2_alloc_context *meta_ac, | 2842 | struct ocfs2_xattr_set_ctxt *ctxt, |
2243 | struct buffer_head **ret_bh, | 2843 | int indexed, |
2244 | int indexed) | 2844 | struct buffer_head **ret_bh) |
2245 | { | 2845 | { |
2246 | int ret; | 2846 | int ret; |
2247 | u16 suballoc_bit_start; | 2847 | u16 suballoc_bit_start; |
@@ -2252,14 +2852,14 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2252 | struct buffer_head *new_bh = NULL; | 2852 | struct buffer_head *new_bh = NULL; |
2253 | struct ocfs2_xattr_block *xblk; | 2853 | struct ocfs2_xattr_block *xblk; |
2254 | 2854 | ||
2255 | ret = ocfs2_journal_access_di(handle, INODE_CACHE(inode), inode_bh, | 2855 | ret = ocfs2_journal_access_di(ctxt->handle, INODE_CACHE(inode), |
2256 | OCFS2_JOURNAL_ACCESS_CREATE); | 2856 | inode_bh, OCFS2_JOURNAL_ACCESS_CREATE); |
2257 | if (ret < 0) { | 2857 | if (ret < 0) { |
2258 | mlog_errno(ret); | 2858 | mlog_errno(ret); |
2259 | goto end; | 2859 | goto end; |
2260 | } | 2860 | } |
2261 | 2861 | ||
2262 | ret = ocfs2_claim_metadata(osb, handle, meta_ac, 1, | 2862 | ret = ocfs2_claim_metadata(osb, ctxt->handle, ctxt->meta_ac, 1, |
2263 | &suballoc_bit_start, &num_got, | 2863 | &suballoc_bit_start, &num_got, |
2264 | &first_blkno); | 2864 | &first_blkno); |
2265 | if (ret < 0) { | 2865 | if (ret < 0) { |
@@ -2270,7 +2870,7 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2270 | new_bh = sb_getblk(inode->i_sb, first_blkno); | 2870 | new_bh = sb_getblk(inode->i_sb, first_blkno); |
2271 | ocfs2_set_new_buffer_uptodate(INODE_CACHE(inode), new_bh); | 2871 | ocfs2_set_new_buffer_uptodate(INODE_CACHE(inode), new_bh); |
2272 | 2872 | ||
2273 | ret = ocfs2_journal_access_xb(handle, INODE_CACHE(inode), | 2873 | ret = ocfs2_journal_access_xb(ctxt->handle, INODE_CACHE(inode), |
2274 | new_bh, | 2874 | new_bh, |
2275 | OCFS2_JOURNAL_ACCESS_CREATE); | 2875 | OCFS2_JOURNAL_ACCESS_CREATE); |
2276 | if (ret < 0) { | 2876 | if (ret < 0) { |
@@ -2282,11 +2882,10 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2282 | xblk = (struct ocfs2_xattr_block *)new_bh->b_data; | 2882 | xblk = (struct ocfs2_xattr_block *)new_bh->b_data; |
2283 | memset(xblk, 0, inode->i_sb->s_blocksize); | 2883 | memset(xblk, 0, inode->i_sb->s_blocksize); |
2284 | strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE); | 2884 | strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE); |
2285 | xblk->xb_suballoc_slot = cpu_to_le16(osb->slot_num); | 2885 | xblk->xb_suballoc_slot = cpu_to_le16(ctxt->meta_ac->ac_alloc_slot); |
2286 | xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 2886 | xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
2287 | xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation); | 2887 | xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation); |
2288 | xblk->xb_blkno = cpu_to_le64(first_blkno); | 2888 | xblk->xb_blkno = cpu_to_le64(first_blkno); |
2289 | |||
2290 | if (indexed) { | 2889 | if (indexed) { |
2291 | struct ocfs2_xattr_tree_root *xr = &xblk->xb_attrs.xb_root; | 2890 | struct ocfs2_xattr_tree_root *xr = &xblk->xb_attrs.xb_root; |
2292 | xr->xt_clusters = cpu_to_le32(1); | 2891 | xr->xt_clusters = cpu_to_le32(1); |
@@ -2297,14 +2896,17 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2297 | xr->xt_list.l_next_free_rec = cpu_to_le16(1); | 2896 | xr->xt_list.l_next_free_rec = cpu_to_le16(1); |
2298 | xblk->xb_flags = cpu_to_le16(OCFS2_XATTR_INDEXED); | 2897 | xblk->xb_flags = cpu_to_le16(OCFS2_XATTR_INDEXED); |
2299 | } | 2898 | } |
2899 | ocfs2_journal_dirty(ctxt->handle, new_bh); | ||
2300 | 2900 | ||
2301 | ret = ocfs2_journal_dirty(handle, new_bh); | 2901 | /* Add it to the inode */ |
2302 | if (ret < 0) { | ||
2303 | mlog_errno(ret); | ||
2304 | goto end; | ||
2305 | } | ||
2306 | di->i_xattr_loc = cpu_to_le64(first_blkno); | 2902 | di->i_xattr_loc = cpu_to_le64(first_blkno); |
2307 | ocfs2_journal_dirty(handle, inode_bh); | 2903 | |
2904 | spin_lock(&OCFS2_I(inode)->ip_lock); | ||
2905 | OCFS2_I(inode)->ip_dyn_features |= OCFS2_HAS_XATTR_FL; | ||
2906 | di->i_dyn_features = cpu_to_le16(OCFS2_I(inode)->ip_dyn_features); | ||
2907 | spin_unlock(&OCFS2_I(inode)->ip_lock); | ||
2908 | |||
2909 | ocfs2_journal_dirty(ctxt->handle, inode_bh); | ||
2308 | 2910 | ||
2309 | *ret_bh = new_bh; | 2911 | *ret_bh = new_bh; |
2310 | new_bh = NULL; | 2912 | new_bh = NULL; |
@@ -2326,13 +2928,13 @@ static int ocfs2_xattr_block_set(struct inode *inode, | |||
2326 | struct ocfs2_xattr_set_ctxt *ctxt) | 2928 | struct ocfs2_xattr_set_ctxt *ctxt) |
2327 | { | 2929 | { |
2328 | struct buffer_head *new_bh = NULL; | 2930 | struct buffer_head *new_bh = NULL; |
2329 | handle_t *handle = ctxt->handle; | ||
2330 | struct ocfs2_xattr_block *xblk = NULL; | 2931 | struct ocfs2_xattr_block *xblk = NULL; |
2331 | int ret; | 2932 | int ret; |
2933 | struct ocfs2_xa_loc loc; | ||
2332 | 2934 | ||
2333 | if (!xs->xattr_bh) { | 2935 | if (!xs->xattr_bh) { |
2334 | ret = ocfs2_create_xattr_block(handle, inode, xs->inode_bh, | 2936 | ret = ocfs2_create_xattr_block(inode, xs->inode_bh, ctxt, |
2335 | ctxt->meta_ac, &new_bh, 0); | 2937 | 0, &new_bh); |
2336 | if (ret) { | 2938 | if (ret) { |
2337 | mlog_errno(ret); | 2939 | mlog_errno(ret); |
2338 | goto end; | 2940 | goto end; |
@@ -2348,21 +2950,25 @@ static int ocfs2_xattr_block_set(struct inode *inode, | |||
2348 | xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data; | 2950 | xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data; |
2349 | 2951 | ||
2350 | if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) { | 2952 | if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) { |
2351 | /* Set extended attribute into external block */ | 2953 | ocfs2_init_xattr_block_xa_loc(&loc, inode, xs->xattr_bh, |
2352 | ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt, | 2954 | xs->not_found ? NULL : xs->here); |
2353 | OCFS2_HAS_XATTR_FL); | ||
2354 | if (!ret || ret != -ENOSPC) | ||
2355 | goto end; | ||
2356 | 2955 | ||
2357 | ret = ocfs2_xattr_create_index_block(inode, xs, ctxt); | 2956 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
2358 | if (ret) | 2957 | if (!ret) |
2958 | xs->here = loc.xl_entry; | ||
2959 | else if (ret != -ENOSPC) | ||
2359 | goto end; | 2960 | goto end; |
2961 | else { | ||
2962 | ret = ocfs2_xattr_create_index_block(inode, xs, ctxt); | ||
2963 | if (ret) | ||
2964 | goto end; | ||
2965 | } | ||
2360 | } | 2966 | } |
2361 | 2967 | ||
2362 | ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs, ctxt); | 2968 | if (le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED) |
2969 | ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs, ctxt); | ||
2363 | 2970 | ||
2364 | end: | 2971 | end: |
2365 | |||
2366 | return ret; | 2972 | return ret; |
2367 | } | 2973 | } |
2368 | 2974 | ||
@@ -2371,7 +2977,6 @@ static int ocfs2_xattr_can_be_in_inode(struct inode *inode, | |||
2371 | struct ocfs2_xattr_info *xi, | 2977 | struct ocfs2_xattr_info *xi, |
2372 | struct ocfs2_xattr_search *xs) | 2978 | struct ocfs2_xattr_search *xs) |
2373 | { | 2979 | { |
2374 | u64 value_size; | ||
2375 | struct ocfs2_xattr_entry *last; | 2980 | struct ocfs2_xattr_entry *last; |
2376 | int free, i; | 2981 | int free, i; |
2377 | size_t min_offs = xs->end - xs->base; | 2982 | size_t min_offs = xs->end - xs->base; |
@@ -2394,13 +2999,7 @@ static int ocfs2_xattr_can_be_in_inode(struct inode *inode, | |||
2394 | 2999 | ||
2395 | BUG_ON(!xs->not_found); | 3000 | BUG_ON(!xs->not_found); |
2396 | 3001 | ||
2397 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 3002 | if (free >= (sizeof(struct ocfs2_xattr_entry) + namevalue_size_xi(xi))) |
2398 | value_size = OCFS2_XATTR_ROOT_SIZE; | ||
2399 | else | ||
2400 | value_size = OCFS2_XATTR_SIZE(xi->value_len); | ||
2401 | |||
2402 | if (free >= sizeof(struct ocfs2_xattr_entry) + | ||
2403 | OCFS2_XATTR_SIZE(strlen(xi->name)) + value_size) | ||
2404 | return 1; | 3003 | return 1; |
2405 | 3004 | ||
2406 | return 0; | 3005 | return 0; |
@@ -2424,7 +3023,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2424 | char *base = NULL; | 3023 | char *base = NULL; |
2425 | int name_offset, name_len = 0; | 3024 | int name_offset, name_len = 0; |
2426 | u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb, | 3025 | u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb, |
2427 | xi->value_len); | 3026 | xi->xi_value_len); |
2428 | u64 value_size; | 3027 | u64 value_size; |
2429 | 3028 | ||
2430 | /* | 3029 | /* |
@@ -2432,14 +3031,14 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2432 | * No matter whether we replace an old one or add a new one, | 3031 | * No matter whether we replace an old one or add a new one, |
2433 | * we need this for writing. | 3032 | * we need this for writing. |
2434 | */ | 3033 | */ |
2435 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 3034 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) |
2436 | credits += new_clusters * | 3035 | credits += new_clusters * |
2437 | ocfs2_clusters_to_blocks(inode->i_sb, 1); | 3036 | ocfs2_clusters_to_blocks(inode->i_sb, 1); |
2438 | 3037 | ||
2439 | if (xis->not_found && xbs->not_found) { | 3038 | if (xis->not_found && xbs->not_found) { |
2440 | credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb); | 3039 | credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb); |
2441 | 3040 | ||
2442 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 3041 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { |
2443 | clusters_add += new_clusters; | 3042 | clusters_add += new_clusters; |
2444 | credits += ocfs2_calc_extend_credits(inode->i_sb, | 3043 | credits += ocfs2_calc_extend_credits(inode->i_sb, |
2445 | &def_xv.xv.xr_list, | 3044 | &def_xv.xv.xr_list, |
@@ -2484,7 +3083,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2484 | * The credits for removing the value tree will be extended | 3083 | * The credits for removing the value tree will be extended |
2485 | * by ocfs2_remove_extent itself. | 3084 | * by ocfs2_remove_extent itself. |
2486 | */ | 3085 | */ |
2487 | if (!xi->value) { | 3086 | if (!xi->xi_value) { |
2488 | if (!ocfs2_xattr_is_local(xe)) | 3087 | if (!ocfs2_xattr_is_local(xe)) |
2489 | credits += ocfs2_remove_extent_credits(inode->i_sb); | 3088 | credits += ocfs2_remove_extent_credits(inode->i_sb); |
2490 | 3089 | ||
@@ -2514,7 +3113,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2514 | } | 3113 | } |
2515 | } | 3114 | } |
2516 | 3115 | ||
2517 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 3116 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { |
2518 | /* the new values will be stored outside. */ | 3117 | /* the new values will be stored outside. */ |
2519 | u32 old_clusters = 0; | 3118 | u32 old_clusters = 0; |
2520 | 3119 | ||
@@ -2547,9 +3146,10 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2547 | * value, we don't need any allocation, otherwise we have | 3146 | * value, we don't need any allocation, otherwise we have |
2548 | * to guess metadata allocation. | 3147 | * to guess metadata allocation. |
2549 | */ | 3148 | */ |
2550 | if ((ocfs2_xattr_is_local(xe) && value_size >= xi->value_len) || | 3149 | if ((ocfs2_xattr_is_local(xe) && |
3150 | (value_size >= xi->xi_value_len)) || | ||
2551 | (!ocfs2_xattr_is_local(xe) && | 3151 | (!ocfs2_xattr_is_local(xe) && |
2552 | OCFS2_XATTR_ROOT_SIZE >= xi->value_len)) | 3152 | OCFS2_XATTR_ROOT_SIZE >= xi->xi_value_len)) |
2553 | goto out; | 3153 | goto out; |
2554 | } | 3154 | } |
2555 | 3155 | ||
@@ -2639,7 +3239,7 @@ static int ocfs2_init_xattr_set_ctxt(struct inode *inode, | |||
2639 | 3239 | ||
2640 | meta_add += extra_meta; | 3240 | meta_add += extra_meta; |
2641 | mlog(0, "Set xattr %s, reserve meta blocks = %d, clusters = %d, " | 3241 | mlog(0, "Set xattr %s, reserve meta blocks = %d, clusters = %d, " |
2642 | "credits = %d\n", xi->name, meta_add, clusters_add, *credits); | 3242 | "credits = %d\n", xi->xi_name, meta_add, clusters_add, *credits); |
2643 | 3243 | ||
2644 | if (meta_add) { | 3244 | if (meta_add) { |
2645 | ret = ocfs2_reserve_new_metadata_blocks(osb, meta_add, | 3245 | ret = ocfs2_reserve_new_metadata_blocks(osb, meta_add, |
@@ -2679,7 +3279,7 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2679 | { | 3279 | { |
2680 | int ret = 0, credits, old_found; | 3280 | int ret = 0, credits, old_found; |
2681 | 3281 | ||
2682 | if (!xi->value) { | 3282 | if (!xi->xi_value) { |
2683 | /* Remove existing extended attribute */ | 3283 | /* Remove existing extended attribute */ |
2684 | if (!xis->not_found) | 3284 | if (!xis->not_found) |
2685 | ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt); | 3285 | ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt); |
@@ -2693,8 +3293,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2693 | * If succeed and that extended attribute existing in | 3293 | * If succeed and that extended attribute existing in |
2694 | * external block, then we will remove it. | 3294 | * external block, then we will remove it. |
2695 | */ | 3295 | */ |
2696 | xi->value = NULL; | 3296 | xi->xi_value = NULL; |
2697 | xi->value_len = 0; | 3297 | xi->xi_value_len = 0; |
2698 | 3298 | ||
2699 | old_found = xis->not_found; | 3299 | old_found = xis->not_found; |
2700 | xis->not_found = -ENODATA; | 3300 | xis->not_found = -ENODATA; |
@@ -2722,8 +3322,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2722 | } else if (ret == -ENOSPC) { | 3322 | } else if (ret == -ENOSPC) { |
2723 | if (di->i_xattr_loc && !xbs->xattr_bh) { | 3323 | if (di->i_xattr_loc && !xbs->xattr_bh) { |
2724 | ret = ocfs2_xattr_block_find(inode, | 3324 | ret = ocfs2_xattr_block_find(inode, |
2725 | xi->name_index, | 3325 | xi->xi_name_index, |
2726 | xi->name, xbs); | 3326 | xi->xi_name, xbs); |
2727 | if (ret) | 3327 | if (ret) |
2728 | goto out; | 3328 | goto out; |
2729 | 3329 | ||
@@ -2762,8 +3362,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2762 | * If succeed and that extended attribute | 3362 | * If succeed and that extended attribute |
2763 | * existing in inode, we will remove it. | 3363 | * existing in inode, we will remove it. |
2764 | */ | 3364 | */ |
2765 | xi->value = NULL; | 3365 | xi->xi_value = NULL; |
2766 | xi->value_len = 0; | 3366 | xi->xi_value_len = 0; |
2767 | xbs->not_found = -ENODATA; | 3367 | xbs->not_found = -ENODATA; |
2768 | ret = ocfs2_calc_xattr_set_need(inode, | 3368 | ret = ocfs2_calc_xattr_set_need(inode, |
2769 | di, | 3369 | di, |
@@ -2829,10 +3429,11 @@ int ocfs2_xattr_set_handle(handle_t *handle, | |||
2829 | int ret; | 3429 | int ret; |
2830 | 3430 | ||
2831 | struct ocfs2_xattr_info xi = { | 3431 | struct ocfs2_xattr_info xi = { |
2832 | .name_index = name_index, | 3432 | .xi_name_index = name_index, |
2833 | .name = name, | 3433 | .xi_name = name, |
2834 | .value = value, | 3434 | .xi_name_len = strlen(name), |
2835 | .value_len = value_len, | 3435 | .xi_value = value, |
3436 | .xi_value_len = value_len, | ||
2836 | }; | 3437 | }; |
2837 | 3438 | ||
2838 | struct ocfs2_xattr_search xis = { | 3439 | struct ocfs2_xattr_search xis = { |
@@ -2912,10 +3513,11 @@ int ocfs2_xattr_set(struct inode *inode, | |||
2912 | struct ocfs2_refcount_tree *ref_tree = NULL; | 3513 | struct ocfs2_refcount_tree *ref_tree = NULL; |
2913 | 3514 | ||
2914 | struct ocfs2_xattr_info xi = { | 3515 | struct ocfs2_xattr_info xi = { |
2915 | .name_index = name_index, | 3516 | .xi_name_index = name_index, |
2916 | .name = name, | 3517 | .xi_name = name, |
2917 | .value = value, | 3518 | .xi_name_len = strlen(name), |
2918 | .value_len = value_len, | 3519 | .xi_value = value, |
3520 | .xi_value_len = value_len, | ||
2919 | }; | 3521 | }; |
2920 | 3522 | ||
2921 | struct ocfs2_xattr_search xis = { | 3523 | struct ocfs2_xattr_search xis = { |
@@ -3759,7 +4361,7 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode, | |||
3759 | struct ocfs2_xattr_bucket *bucket) | 4361 | struct ocfs2_xattr_bucket *bucket) |
3760 | { | 4362 | { |
3761 | int ret, i; | 4363 | int ret, i; |
3762 | size_t end, offset, len, value_len; | 4364 | size_t end, offset, len; |
3763 | struct ocfs2_xattr_header *xh; | 4365 | struct ocfs2_xattr_header *xh; |
3764 | char *entries, *buf, *bucket_buf = NULL; | 4366 | char *entries, *buf, *bucket_buf = NULL; |
3765 | u64 blkno = bucket_blkno(bucket); | 4367 | u64 blkno = bucket_blkno(bucket); |
@@ -3813,12 +4415,7 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode, | |||
3813 | end = OCFS2_XATTR_BUCKET_SIZE; | 4415 | end = OCFS2_XATTR_BUCKET_SIZE; |
3814 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++, xe++) { | 4416 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++, xe++) { |
3815 | offset = le16_to_cpu(xe->xe_name_offset); | 4417 | offset = le16_to_cpu(xe->xe_name_offset); |
3816 | if (ocfs2_xattr_is_local(xe)) | 4418 | len = namevalue_size_xe(xe); |
3817 | value_len = OCFS2_XATTR_SIZE( | ||
3818 | le64_to_cpu(xe->xe_value_size)); | ||
3819 | else | ||
3820 | value_len = OCFS2_XATTR_ROOT_SIZE; | ||
3821 | len = OCFS2_XATTR_SIZE(xe->xe_name_len) + value_len; | ||
3822 | 4419 | ||
3823 | /* | 4420 | /* |
3824 | * We must make sure that the name/value pair | 4421 | * We must make sure that the name/value pair |
@@ -4007,7 +4604,7 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4007 | int new_bucket_head) | 4604 | int new_bucket_head) |
4008 | { | 4605 | { |
4009 | int ret, i; | 4606 | int ret, i; |
4010 | int count, start, len, name_value_len = 0, xe_len, name_offset = 0; | 4607 | int count, start, len, name_value_len = 0, name_offset = 0; |
4011 | struct ocfs2_xattr_bucket *s_bucket = NULL, *t_bucket = NULL; | 4608 | struct ocfs2_xattr_bucket *s_bucket = NULL, *t_bucket = NULL; |
4012 | struct ocfs2_xattr_header *xh; | 4609 | struct ocfs2_xattr_header *xh; |
4013 | struct ocfs2_xattr_entry *xe; | 4610 | struct ocfs2_xattr_entry *xe; |
@@ -4098,13 +4695,7 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4098 | name_value_len = 0; | 4695 | name_value_len = 0; |
4099 | for (i = 0; i < start; i++) { | 4696 | for (i = 0; i < start; i++) { |
4100 | xe = &xh->xh_entries[i]; | 4697 | xe = &xh->xh_entries[i]; |
4101 | xe_len = OCFS2_XATTR_SIZE(xe->xe_name_len); | 4698 | name_value_len += namevalue_size_xe(xe); |
4102 | if (ocfs2_xattr_is_local(xe)) | ||
4103 | xe_len += | ||
4104 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4105 | else | ||
4106 | xe_len += OCFS2_XATTR_ROOT_SIZE; | ||
4107 | name_value_len += xe_len; | ||
4108 | if (le16_to_cpu(xe->xe_name_offset) < name_offset) | 4699 | if (le16_to_cpu(xe->xe_name_offset) < name_offset) |
4109 | name_offset = le16_to_cpu(xe->xe_name_offset); | 4700 | name_offset = le16_to_cpu(xe->xe_name_offset); |
4110 | } | 4701 | } |
@@ -4134,12 +4725,6 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4134 | xh->xh_free_start = cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); | 4725 | xh->xh_free_start = cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); |
4135 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++) { | 4726 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++) { |
4136 | xe = &xh->xh_entries[i]; | 4727 | xe = &xh->xh_entries[i]; |
4137 | xe_len = OCFS2_XATTR_SIZE(xe->xe_name_len); | ||
4138 | if (ocfs2_xattr_is_local(xe)) | ||
4139 | xe_len += | ||
4140 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4141 | else | ||
4142 | xe_len += OCFS2_XATTR_ROOT_SIZE; | ||
4143 | if (le16_to_cpu(xe->xe_name_offset) < | 4728 | if (le16_to_cpu(xe->xe_name_offset) < |
4144 | le16_to_cpu(xh->xh_free_start)) | 4729 | le16_to_cpu(xh->xh_free_start)) |
4145 | xh->xh_free_start = xe->xe_name_offset; | 4730 | xh->xh_free_start = xe->xe_name_offset; |
@@ -4751,195 +5336,6 @@ static inline char *ocfs2_xattr_bucket_get_val(struct inode *inode, | |||
4751 | } | 5336 | } |
4752 | 5337 | ||
4753 | /* | 5338 | /* |
4754 | * Handle the normal xattr set, including replace, delete and new. | ||
4755 | * | ||
4756 | * Note: "local" indicates the real data's locality. So we can't | ||
4757 | * just its bucket locality by its length. | ||
4758 | */ | ||
4759 | static void ocfs2_xattr_set_entry_normal(struct inode *inode, | ||
4760 | struct ocfs2_xattr_info *xi, | ||
4761 | struct ocfs2_xattr_search *xs, | ||
4762 | u32 name_hash, | ||
4763 | int local) | ||
4764 | { | ||
4765 | struct ocfs2_xattr_entry *last, *xe; | ||
4766 | int name_len = strlen(xi->name); | ||
4767 | struct ocfs2_xattr_header *xh = xs->header; | ||
4768 | u16 count = le16_to_cpu(xh->xh_count), start; | ||
4769 | size_t blocksize = inode->i_sb->s_blocksize; | ||
4770 | char *val; | ||
4771 | size_t offs, size, new_size; | ||
4772 | |||
4773 | last = &xh->xh_entries[count]; | ||
4774 | if (!xs->not_found) { | ||
4775 | xe = xs->here; | ||
4776 | offs = le16_to_cpu(xe->xe_name_offset); | ||
4777 | if (ocfs2_xattr_is_local(xe)) | ||
4778 | size = OCFS2_XATTR_SIZE(name_len) + | ||
4779 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4780 | else | ||
4781 | size = OCFS2_XATTR_SIZE(name_len) + | ||
4782 | OCFS2_XATTR_SIZE(OCFS2_XATTR_ROOT_SIZE); | ||
4783 | |||
4784 | /* | ||
4785 | * If the new value will be stored outside, xi->value has been | ||
4786 | * initalized as an empty ocfs2_xattr_value_root, and the same | ||
4787 | * goes with xi->value_len, so we can set new_size safely here. | ||
4788 | * See ocfs2_xattr_set_in_bucket. | ||
4789 | */ | ||
4790 | new_size = OCFS2_XATTR_SIZE(name_len) + | ||
4791 | OCFS2_XATTR_SIZE(xi->value_len); | ||
4792 | |||
4793 | le16_add_cpu(&xh->xh_name_value_len, -size); | ||
4794 | if (xi->value) { | ||
4795 | if (new_size > size) | ||
4796 | goto set_new_name_value; | ||
4797 | |||
4798 | /* Now replace the old value with new one. */ | ||
4799 | if (local) | ||
4800 | xe->xe_value_size = cpu_to_le64(xi->value_len); | ||
4801 | else | ||
4802 | xe->xe_value_size = 0; | ||
4803 | |||
4804 | val = ocfs2_xattr_bucket_get_val(inode, | ||
4805 | xs->bucket, offs); | ||
4806 | memset(val + OCFS2_XATTR_SIZE(name_len), 0, | ||
4807 | size - OCFS2_XATTR_SIZE(name_len)); | ||
4808 | if (OCFS2_XATTR_SIZE(xi->value_len) > 0) | ||
4809 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | ||
4810 | xi->value, xi->value_len); | ||
4811 | |||
4812 | le16_add_cpu(&xh->xh_name_value_len, new_size); | ||
4813 | ocfs2_xattr_set_local(xe, local); | ||
4814 | return; | ||
4815 | } else { | ||
4816 | /* | ||
4817 | * Remove the old entry if there is more than one. | ||
4818 | * We don't remove the last entry so that we can | ||
4819 | * use it to indicate the hash value of the empty | ||
4820 | * bucket. | ||
4821 | */ | ||
4822 | last -= 1; | ||
4823 | le16_add_cpu(&xh->xh_count, -1); | ||
4824 | if (xh->xh_count) { | ||
4825 | memmove(xe, xe + 1, | ||
4826 | (void *)last - (void *)xe); | ||
4827 | memset(last, 0, | ||
4828 | sizeof(struct ocfs2_xattr_entry)); | ||
4829 | } else | ||
4830 | xh->xh_free_start = | ||
4831 | cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); | ||
4832 | |||
4833 | return; | ||
4834 | } | ||
4835 | } else { | ||
4836 | /* find a new entry for insert. */ | ||
4837 | int low = 0, high = count - 1, tmp; | ||
4838 | struct ocfs2_xattr_entry *tmp_xe; | ||
4839 | |||
4840 | while (low <= high && count) { | ||
4841 | tmp = (low + high) / 2; | ||
4842 | tmp_xe = &xh->xh_entries[tmp]; | ||
4843 | |||
4844 | if (name_hash > le32_to_cpu(tmp_xe->xe_name_hash)) | ||
4845 | low = tmp + 1; | ||
4846 | else if (name_hash < | ||
4847 | le32_to_cpu(tmp_xe->xe_name_hash)) | ||
4848 | high = tmp - 1; | ||
4849 | else { | ||
4850 | low = tmp; | ||
4851 | break; | ||
4852 | } | ||
4853 | } | ||
4854 | |||
4855 | xe = &xh->xh_entries[low]; | ||
4856 | if (low != count) | ||
4857 | memmove(xe + 1, xe, (void *)last - (void *)xe); | ||
4858 | |||
4859 | le16_add_cpu(&xh->xh_count, 1); | ||
4860 | memset(xe, 0, sizeof(struct ocfs2_xattr_entry)); | ||
4861 | xe->xe_name_hash = cpu_to_le32(name_hash); | ||
4862 | xe->xe_name_len = name_len; | ||
4863 | ocfs2_xattr_set_type(xe, xi->name_index); | ||
4864 | } | ||
4865 | |||
4866 | set_new_name_value: | ||
4867 | /* Insert the new name+value. */ | ||
4868 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(xi->value_len); | ||
4869 | |||
4870 | /* | ||
4871 | * We must make sure that the name/value pair | ||
4872 | * exists in the same block. | ||
4873 | */ | ||
4874 | offs = le16_to_cpu(xh->xh_free_start); | ||
4875 | start = offs - size; | ||
4876 | |||
4877 | if (start >> inode->i_sb->s_blocksize_bits != | ||
4878 | (offs - 1) >> inode->i_sb->s_blocksize_bits) { | ||
4879 | offs = offs - offs % blocksize; | ||
4880 | xh->xh_free_start = cpu_to_le16(offs); | ||
4881 | } | ||
4882 | |||
4883 | val = ocfs2_xattr_bucket_get_val(inode, xs->bucket, offs - size); | ||
4884 | xe->xe_name_offset = cpu_to_le16(offs - size); | ||
4885 | |||
4886 | memset(val, 0, size); | ||
4887 | memcpy(val, xi->name, name_len); | ||
4888 | memcpy(val + OCFS2_XATTR_SIZE(name_len), xi->value, xi->value_len); | ||
4889 | |||
4890 | xe->xe_value_size = cpu_to_le64(xi->value_len); | ||
4891 | ocfs2_xattr_set_local(xe, local); | ||
4892 | xs->here = xe; | ||
4893 | le16_add_cpu(&xh->xh_free_start, -size); | ||
4894 | le16_add_cpu(&xh->xh_name_value_len, size); | ||
4895 | |||
4896 | return; | ||
4897 | } | ||
4898 | |||
4899 | /* | ||
4900 | * Set the xattr entry in the specified bucket. | ||
4901 | * The bucket is indicated by xs->bucket and it should have the enough | ||
4902 | * space for the xattr insertion. | ||
4903 | */ | ||
4904 | static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode, | ||
4905 | handle_t *handle, | ||
4906 | struct ocfs2_xattr_info *xi, | ||
4907 | struct ocfs2_xattr_search *xs, | ||
4908 | u32 name_hash, | ||
4909 | int local) | ||
4910 | { | ||
4911 | int ret; | ||
4912 | u64 blkno; | ||
4913 | |||
4914 | mlog(0, "Set xattr entry len = %lu index = %d in bucket %llu\n", | ||
4915 | (unsigned long)xi->value_len, xi->name_index, | ||
4916 | (unsigned long long)bucket_blkno(xs->bucket)); | ||
4917 | |||
4918 | if (!xs->bucket->bu_bhs[1]) { | ||
4919 | blkno = bucket_blkno(xs->bucket); | ||
4920 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
4921 | ret = ocfs2_read_xattr_bucket(xs->bucket, blkno); | ||
4922 | if (ret) { | ||
4923 | mlog_errno(ret); | ||
4924 | goto out; | ||
4925 | } | ||
4926 | } | ||
4927 | |||
4928 | ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket, | ||
4929 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
4930 | if (ret < 0) { | ||
4931 | mlog_errno(ret); | ||
4932 | goto out; | ||
4933 | } | ||
4934 | |||
4935 | ocfs2_xattr_set_entry_normal(inode, xi, xs, name_hash, local); | ||
4936 | ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket); | ||
4937 | |||
4938 | out: | ||
4939 | return ret; | ||
4940 | } | ||
4941 | |||
4942 | /* | ||
4943 | * Truncate the specified xe_off entry in xattr bucket. | 5339 | * Truncate the specified xe_off entry in xattr bucket. |
4944 | * bucket is indicated by header_bh and len is the new length. | 5340 | * bucket is indicated by header_bh and len is the new length. |
4945 | * Both the ocfs2_xattr_value_root and the entry will be updated here. | 5341 | * Both the ocfs2_xattr_value_root and the entry will be updated here. |
@@ -5009,66 +5405,6 @@ out: | |||
5009 | return ret; | 5405 | return ret; |
5010 | } | 5406 | } |
5011 | 5407 | ||
5012 | static int ocfs2_xattr_bucket_value_truncate_xs(struct inode *inode, | ||
5013 | struct ocfs2_xattr_search *xs, | ||
5014 | int len, | ||
5015 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5016 | { | ||
5017 | int ret, offset; | ||
5018 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5019 | struct ocfs2_xattr_header *xh = (struct ocfs2_xattr_header *)xs->base; | ||
5020 | |||
5021 | BUG_ON(!xs->bucket->bu_bhs[0] || !xe || ocfs2_xattr_is_local(xe)); | ||
5022 | |||
5023 | offset = xe - xh->xh_entries; | ||
5024 | ret = ocfs2_xattr_bucket_value_truncate(inode, xs->bucket, | ||
5025 | offset, len, ctxt); | ||
5026 | if (ret) | ||
5027 | mlog_errno(ret); | ||
5028 | |||
5029 | return ret; | ||
5030 | } | ||
5031 | |||
5032 | static int ocfs2_xattr_bucket_set_value_outside(struct inode *inode, | ||
5033 | handle_t *handle, | ||
5034 | struct ocfs2_xattr_search *xs, | ||
5035 | char *val, | ||
5036 | int value_len) | ||
5037 | { | ||
5038 | int ret, offset, block_off; | ||
5039 | struct ocfs2_xattr_value_root *xv; | ||
5040 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5041 | struct ocfs2_xattr_header *xh = bucket_xh(xs->bucket); | ||
5042 | void *base; | ||
5043 | struct ocfs2_xattr_value_buf vb = { | ||
5044 | .vb_access = ocfs2_journal_access, | ||
5045 | }; | ||
5046 | |||
5047 | BUG_ON(!xs->base || !xe || ocfs2_xattr_is_local(xe)); | ||
5048 | |||
5049 | ret = ocfs2_xattr_bucket_get_name_value(inode->i_sb, xh, | ||
5050 | xe - xh->xh_entries, | ||
5051 | &block_off, | ||
5052 | &offset); | ||
5053 | if (ret) { | ||
5054 | mlog_errno(ret); | ||
5055 | goto out; | ||
5056 | } | ||
5057 | |||
5058 | base = bucket_block(xs->bucket, block_off); | ||
5059 | xv = (struct ocfs2_xattr_value_root *)(base + offset + | ||
5060 | OCFS2_XATTR_SIZE(xe->xe_name_len)); | ||
5061 | |||
5062 | vb.vb_xv = xv; | ||
5063 | vb.vb_bh = xs->bucket->bu_bhs[block_off]; | ||
5064 | ret = __ocfs2_xattr_set_value_outside(inode, handle, | ||
5065 | &vb, val, value_len); | ||
5066 | if (ret) | ||
5067 | mlog_errno(ret); | ||
5068 | out: | ||
5069 | return ret; | ||
5070 | } | ||
5071 | |||
5072 | static int ocfs2_rm_xattr_cluster(struct inode *inode, | 5408 | static int ocfs2_rm_xattr_cluster(struct inode *inode, |
5073 | struct buffer_head *root_bh, | 5409 | struct buffer_head *root_bh, |
5074 | u64 blkno, | 5410 | u64 blkno, |
@@ -5167,128 +5503,6 @@ out: | |||
5167 | return ret; | 5503 | return ret; |
5168 | } | 5504 | } |
5169 | 5505 | ||
5170 | static void ocfs2_xattr_bucket_remove_xs(struct inode *inode, | ||
5171 | handle_t *handle, | ||
5172 | struct ocfs2_xattr_search *xs) | ||
5173 | { | ||
5174 | struct ocfs2_xattr_header *xh = bucket_xh(xs->bucket); | ||
5175 | struct ocfs2_xattr_entry *last = &xh->xh_entries[ | ||
5176 | le16_to_cpu(xh->xh_count) - 1]; | ||
5177 | int ret = 0; | ||
5178 | |||
5179 | ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket, | ||
5180 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
5181 | if (ret) { | ||
5182 | mlog_errno(ret); | ||
5183 | return; | ||
5184 | } | ||
5185 | |||
5186 | /* Remove the old entry. */ | ||
5187 | memmove(xs->here, xs->here + 1, | ||
5188 | (void *)last - (void *)xs->here); | ||
5189 | memset(last, 0, sizeof(struct ocfs2_xattr_entry)); | ||
5190 | le16_add_cpu(&xh->xh_count, -1); | ||
5191 | |||
5192 | ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket); | ||
5193 | } | ||
5194 | |||
5195 | /* | ||
5196 | * Set the xattr name/value in the bucket specified in xs. | ||
5197 | * | ||
5198 | * As the new value in xi may be stored in the bucket or in an outside cluster, | ||
5199 | * we divide the whole process into 3 steps: | ||
5200 | * 1. insert name/value in the bucket(ocfs2_xattr_set_entry_in_bucket) | ||
5201 | * 2. truncate of the outside cluster(ocfs2_xattr_bucket_value_truncate_xs) | ||
5202 | * 3. Set the value to the outside cluster(ocfs2_xattr_bucket_set_value_outside) | ||
5203 | * 4. If the clusters for the new outside value can't be allocated, we need | ||
5204 | * to free the xattr we allocated in set. | ||
5205 | */ | ||
5206 | static int ocfs2_xattr_set_in_bucket(struct inode *inode, | ||
5207 | struct ocfs2_xattr_info *xi, | ||
5208 | struct ocfs2_xattr_search *xs, | ||
5209 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5210 | { | ||
5211 | int ret, local = 1; | ||
5212 | size_t value_len; | ||
5213 | char *val = (char *)xi->value; | ||
5214 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5215 | u32 name_hash = ocfs2_xattr_name_hash(inode, xi->name, | ||
5216 | strlen(xi->name)); | ||
5217 | |||
5218 | if (!xs->not_found && !ocfs2_xattr_is_local(xe)) { | ||
5219 | /* | ||
5220 | * We need to truncate the xattr storage first. | ||
5221 | * | ||
5222 | * If both the old and new value are stored to | ||
5223 | * outside block, we only need to truncate | ||
5224 | * the storage and then set the value outside. | ||
5225 | * | ||
5226 | * If the new value should be stored within block, | ||
5227 | * we should free all the outside block first and | ||
5228 | * the modification to the xattr block will be done | ||
5229 | * by following steps. | ||
5230 | */ | ||
5231 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | ||
5232 | value_len = xi->value_len; | ||
5233 | else | ||
5234 | value_len = 0; | ||
5235 | |||
5236 | ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs, | ||
5237 | value_len, | ||
5238 | ctxt); | ||
5239 | if (ret) | ||
5240 | goto out; | ||
5241 | |||
5242 | if (value_len) | ||
5243 | goto set_value_outside; | ||
5244 | } | ||
5245 | |||
5246 | value_len = xi->value_len; | ||
5247 | /* So we have to handle the inside block change now. */ | ||
5248 | if (value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
5249 | /* | ||
5250 | * If the new value will be stored outside of block, | ||
5251 | * initalize a new empty value root and insert it first. | ||
5252 | */ | ||
5253 | local = 0; | ||
5254 | xi->value = &def_xv; | ||
5255 | xi->value_len = OCFS2_XATTR_ROOT_SIZE; | ||
5256 | } | ||
5257 | |||
5258 | ret = ocfs2_xattr_set_entry_in_bucket(inode, ctxt->handle, xi, xs, | ||
5259 | name_hash, local); | ||
5260 | if (ret) { | ||
5261 | mlog_errno(ret); | ||
5262 | goto out; | ||
5263 | } | ||
5264 | |||
5265 | if (value_len <= OCFS2_XATTR_INLINE_SIZE) | ||
5266 | goto out; | ||
5267 | |||
5268 | /* allocate the space now for the outside block storage. */ | ||
5269 | ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs, | ||
5270 | value_len, ctxt); | ||
5271 | if (ret) { | ||
5272 | mlog_errno(ret); | ||
5273 | |||
5274 | if (xs->not_found) { | ||
5275 | /* | ||
5276 | * We can't allocate enough clusters for outside | ||
5277 | * storage and we have allocated xattr already, | ||
5278 | * so need to remove it. | ||
5279 | */ | ||
5280 | ocfs2_xattr_bucket_remove_xs(inode, ctxt->handle, xs); | ||
5281 | } | ||
5282 | goto out; | ||
5283 | } | ||
5284 | |||
5285 | set_value_outside: | ||
5286 | ret = ocfs2_xattr_bucket_set_value_outside(inode, ctxt->handle, | ||
5287 | xs, val, value_len); | ||
5288 | out: | ||
5289 | return ret; | ||
5290 | } | ||
5291 | |||
5292 | /* | 5506 | /* |
5293 | * check whether the xattr bucket is filled up with the same hash value. | 5507 | * check whether the xattr bucket is filled up with the same hash value. |
5294 | * If we want to insert the xattr with the same hash, return -ENOSPC. | 5508 | * If we want to insert the xattr with the same hash, return -ENOSPC. |
@@ -5317,156 +5531,116 @@ static int ocfs2_check_xattr_bucket_collision(struct inode *inode, | |||
5317 | return 0; | 5531 | return 0; |
5318 | } | 5532 | } |
5319 | 5533 | ||
5320 | static int ocfs2_xattr_set_entry_index_block(struct inode *inode, | 5534 | /* |
5321 | struct ocfs2_xattr_info *xi, | 5535 | * Try to set the entry in the current bucket. If we fail, the caller |
5322 | struct ocfs2_xattr_search *xs, | 5536 | * will handle getting us another bucket. |
5323 | struct ocfs2_xattr_set_ctxt *ctxt) | 5537 | */ |
5538 | static int ocfs2_xattr_set_entry_bucket(struct inode *inode, | ||
5539 | struct ocfs2_xattr_info *xi, | ||
5540 | struct ocfs2_xattr_search *xs, | ||
5541 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5324 | { | 5542 | { |
5325 | struct ocfs2_xattr_header *xh; | 5543 | int ret; |
5326 | struct ocfs2_xattr_entry *xe; | 5544 | struct ocfs2_xa_loc loc; |
5327 | u16 count, header_size, xh_free_start; | ||
5328 | int free, max_free, need, old; | ||
5329 | size_t value_size = 0, name_len = strlen(xi->name); | ||
5330 | size_t blocksize = inode->i_sb->s_blocksize; | ||
5331 | int ret, allocation = 0; | ||
5332 | |||
5333 | mlog_entry("Set xattr %s in xattr index block\n", xi->name); | ||
5334 | |||
5335 | try_again: | ||
5336 | xh = xs->header; | ||
5337 | count = le16_to_cpu(xh->xh_count); | ||
5338 | xh_free_start = le16_to_cpu(xh->xh_free_start); | ||
5339 | header_size = sizeof(struct ocfs2_xattr_header) + | ||
5340 | count * sizeof(struct ocfs2_xattr_entry); | ||
5341 | max_free = OCFS2_XATTR_BUCKET_SIZE - header_size - | ||
5342 | le16_to_cpu(xh->xh_name_value_len) - OCFS2_XATTR_HEADER_GAP; | ||
5343 | |||
5344 | mlog_bug_on_msg(header_size > blocksize, "bucket %llu has header size " | ||
5345 | "of %u which exceed block size\n", | ||
5346 | (unsigned long long)bucket_blkno(xs->bucket), | ||
5347 | header_size); | ||
5348 | 5545 | ||
5349 | if (xi->value && xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 5546 | mlog_entry("Set xattr %s in xattr bucket\n", xi->xi_name); |
5350 | value_size = OCFS2_XATTR_ROOT_SIZE; | ||
5351 | else if (xi->value) | ||
5352 | value_size = OCFS2_XATTR_SIZE(xi->value_len); | ||
5353 | 5547 | ||
5354 | if (xs->not_found) | 5548 | ocfs2_init_xattr_bucket_xa_loc(&loc, xs->bucket, |
5355 | need = sizeof(struct ocfs2_xattr_entry) + | 5549 | xs->not_found ? NULL : xs->here); |
5356 | OCFS2_XATTR_SIZE(name_len) + value_size; | 5550 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
5357 | else { | 5551 | if (!ret) { |
5358 | need = value_size + OCFS2_XATTR_SIZE(name_len); | 5552 | xs->here = loc.xl_entry; |
5553 | goto out; | ||
5554 | } | ||
5555 | if (ret != -ENOSPC) { | ||
5556 | mlog_errno(ret); | ||
5557 | goto out; | ||
5558 | } | ||
5359 | 5559 | ||
5360 | /* | 5560 | /* Ok, we need space. Let's try defragmenting the bucket. */ |
5361 | * We only replace the old value if the new length is smaller | 5561 | ret = ocfs2_defrag_xattr_bucket(inode, ctxt->handle, |
5362 | * than the old one. Otherwise we will allocate new space in the | 5562 | xs->bucket); |
5363 | * bucket to store it. | 5563 | if (ret) { |
5364 | */ | 5564 | mlog_errno(ret); |
5365 | xe = xs->here; | 5565 | goto out; |
5366 | if (ocfs2_xattr_is_local(xe)) | 5566 | } |
5367 | old = OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
5368 | else | ||
5369 | old = OCFS2_XATTR_SIZE(OCFS2_XATTR_ROOT_SIZE); | ||
5370 | 5567 | ||
5371 | if (old >= value_size) | 5568 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
5372 | need = 0; | 5569 | if (!ret) { |
5570 | xs->here = loc.xl_entry; | ||
5571 | goto out; | ||
5373 | } | 5572 | } |
5573 | if (ret != -ENOSPC) | ||
5574 | mlog_errno(ret); | ||
5374 | 5575 | ||
5375 | free = xh_free_start - header_size - OCFS2_XATTR_HEADER_GAP; | ||
5376 | /* | ||
5377 | * We need to make sure the new name/value pair | ||
5378 | * can exist in the same block. | ||
5379 | */ | ||
5380 | if (xh_free_start % blocksize < need) | ||
5381 | free -= xh_free_start % blocksize; | ||
5382 | |||
5383 | mlog(0, "xs->not_found = %d, in xattr bucket %llu: free = %d, " | ||
5384 | "need = %d, max_free = %d, xh_free_start = %u, xh_name_value_len =" | ||
5385 | " %u\n", xs->not_found, | ||
5386 | (unsigned long long)bucket_blkno(xs->bucket), | ||
5387 | free, need, max_free, le16_to_cpu(xh->xh_free_start), | ||
5388 | le16_to_cpu(xh->xh_name_value_len)); | ||
5389 | |||
5390 | if (free < need || | ||
5391 | (xs->not_found && | ||
5392 | count == ocfs2_xattr_max_xe_in_bucket(inode->i_sb))) { | ||
5393 | if (need <= max_free && | ||
5394 | count < ocfs2_xattr_max_xe_in_bucket(inode->i_sb)) { | ||
5395 | /* | ||
5396 | * We can create the space by defragment. Since only the | ||
5397 | * name/value will be moved, the xe shouldn't be changed | ||
5398 | * in xs. | ||
5399 | */ | ||
5400 | ret = ocfs2_defrag_xattr_bucket(inode, ctxt->handle, | ||
5401 | xs->bucket); | ||
5402 | if (ret) { | ||
5403 | mlog_errno(ret); | ||
5404 | goto out; | ||
5405 | } | ||
5406 | 5576 | ||
5407 | xh_free_start = le16_to_cpu(xh->xh_free_start); | 5577 | out: |
5408 | free = xh_free_start - header_size | 5578 | mlog_exit(ret); |
5409 | - OCFS2_XATTR_HEADER_GAP; | 5579 | return ret; |
5410 | if (xh_free_start % blocksize < need) | 5580 | } |
5411 | free -= xh_free_start % blocksize; | ||
5412 | 5581 | ||
5413 | if (free >= need) | 5582 | static int ocfs2_xattr_set_entry_index_block(struct inode *inode, |
5414 | goto xattr_set; | 5583 | struct ocfs2_xattr_info *xi, |
5584 | struct ocfs2_xattr_search *xs, | ||
5585 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5586 | { | ||
5587 | int ret; | ||
5415 | 5588 | ||
5416 | mlog(0, "Can't get enough space for xattr insert by " | 5589 | mlog_entry("Set xattr %s in xattr index block\n", xi->xi_name); |
5417 | "defragment. Need %u bytes, but we have %d, so " | ||
5418 | "allocate new bucket for it.\n", need, free); | ||
5419 | } | ||
5420 | 5590 | ||
5421 | /* | 5591 | ret = ocfs2_xattr_set_entry_bucket(inode, xi, xs, ctxt); |
5422 | * We have to add new buckets or clusters and one | 5592 | if (!ret) |
5423 | * allocation should leave us enough space for insert. | 5593 | goto out; |
5424 | */ | 5594 | if (ret != -ENOSPC) { |
5425 | BUG_ON(allocation); | 5595 | mlog_errno(ret); |
5596 | goto out; | ||
5597 | } | ||
5426 | 5598 | ||
5427 | /* | 5599 | /* Ack, need more space. Let's try to get another bucket! */ |
5428 | * We do not allow for overlapping ranges between buckets. And | ||
5429 | * the maximum number of collisions we will allow for then is | ||
5430 | * one bucket's worth, so check it here whether we need to | ||
5431 | * add a new bucket for the insert. | ||
5432 | */ | ||
5433 | ret = ocfs2_check_xattr_bucket_collision(inode, | ||
5434 | xs->bucket, | ||
5435 | xi->name); | ||
5436 | if (ret) { | ||
5437 | mlog_errno(ret); | ||
5438 | goto out; | ||
5439 | } | ||
5440 | 5600 | ||
5441 | ret = ocfs2_add_new_xattr_bucket(inode, | 5601 | /* |
5442 | xs->xattr_bh, | 5602 | * We do not allow for overlapping ranges between buckets. And |
5603 | * the maximum number of collisions we will allow for then is | ||
5604 | * one bucket's worth, so check it here whether we need to | ||
5605 | * add a new bucket for the insert. | ||
5606 | */ | ||
5607 | ret = ocfs2_check_xattr_bucket_collision(inode, | ||
5443 | xs->bucket, | 5608 | xs->bucket, |
5444 | ctxt); | 5609 | xi->xi_name); |
5445 | if (ret) { | 5610 | if (ret) { |
5446 | mlog_errno(ret); | 5611 | mlog_errno(ret); |
5447 | goto out; | 5612 | goto out; |
5448 | } | 5613 | } |
5449 | 5614 | ||
5450 | /* | 5615 | ret = ocfs2_add_new_xattr_bucket(inode, |
5451 | * ocfs2_add_new_xattr_bucket() will have updated | 5616 | xs->xattr_bh, |
5452 | * xs->bucket if it moved, but it will not have updated | 5617 | xs->bucket, |
5453 | * any of the other search fields. Thus, we drop it and | 5618 | ctxt); |
5454 | * re-search. Everything should be cached, so it'll be | 5619 | if (ret) { |
5455 | * quick. | 5620 | mlog_errno(ret); |
5456 | */ | 5621 | goto out; |
5457 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
5458 | ret = ocfs2_xattr_index_block_find(inode, xs->xattr_bh, | ||
5459 | xi->name_index, | ||
5460 | xi->name, xs); | ||
5461 | if (ret && ret != -ENODATA) | ||
5462 | goto out; | ||
5463 | xs->not_found = ret; | ||
5464 | allocation = 1; | ||
5465 | goto try_again; | ||
5466 | } | 5622 | } |
5467 | 5623 | ||
5468 | xattr_set: | 5624 | /* |
5469 | ret = ocfs2_xattr_set_in_bucket(inode, xi, xs, ctxt); | 5625 | * ocfs2_add_new_xattr_bucket() will have updated |
5626 | * xs->bucket if it moved, but it will not have updated | ||
5627 | * any of the other search fields. Thus, we drop it and | ||
5628 | * re-search. Everything should be cached, so it'll be | ||
5629 | * quick. | ||
5630 | */ | ||
5631 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
5632 | ret = ocfs2_xattr_index_block_find(inode, xs->xattr_bh, | ||
5633 | xi->xi_name_index, | ||
5634 | xi->xi_name, xs); | ||
5635 | if (ret && ret != -ENODATA) | ||
5636 | goto out; | ||
5637 | xs->not_found = ret; | ||
5638 | |||
5639 | /* Ok, we have a new bucket, let's try again */ | ||
5640 | ret = ocfs2_xattr_set_entry_bucket(inode, xi, xs, ctxt); | ||
5641 | if (ret && (ret != -ENOSPC)) | ||
5642 | mlog_errno(ret); | ||
5643 | |||
5470 | out: | 5644 | out: |
5471 | mlog_exit(ret); | 5645 | mlog_exit(ret); |
5472 | return ret; | 5646 | return ret; |
@@ -5678,7 +5852,7 @@ static int ocfs2_prepare_refcount_xattr(struct inode *inode, | |||
5678 | * refcount tree, and make the original extent become 3. So we will need | 5852 | * refcount tree, and make the original extent become 3. So we will need |
5679 | * 2 * cluster more extent recs at most. | 5853 | * 2 * cluster more extent recs at most. |
5680 | */ | 5854 | */ |
5681 | if (!xi->value || xi->value_len <= OCFS2_XATTR_INLINE_SIZE) { | 5855 | if (!xi->xi_value || xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE) { |
5682 | 5856 | ||
5683 | ret = ocfs2_refcounted_xattr_delete_need(inode, | 5857 | ret = ocfs2_refcounted_xattr_delete_need(inode, |
5684 | &(*ref_tree)->rf_ci, | 5858 | &(*ref_tree)->rf_ci, |
@@ -6354,9 +6528,11 @@ static int ocfs2_create_empty_xattr_block(struct inode *inode, | |||
6354 | int indexed) | 6528 | int indexed) |
6355 | { | 6529 | { |
6356 | int ret; | 6530 | int ret; |
6357 | handle_t *handle; | ||
6358 | struct ocfs2_alloc_context *meta_ac; | 6531 | struct ocfs2_alloc_context *meta_ac; |
6359 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 6532 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
6533 | struct ocfs2_xattr_set_ctxt ctxt = { | ||
6534 | .meta_ac = meta_ac, | ||
6535 | }; | ||
6360 | 6536 | ||
6361 | ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac); | 6537 | ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac); |
6362 | if (ret < 0) { | 6538 | if (ret < 0) { |
@@ -6364,21 +6540,21 @@ static int ocfs2_create_empty_xattr_block(struct inode *inode, | |||
6364 | return ret; | 6540 | return ret; |
6365 | } | 6541 | } |
6366 | 6542 | ||
6367 | handle = ocfs2_start_trans(osb, OCFS2_XATTR_BLOCK_CREATE_CREDITS); | 6543 | ctxt.handle = ocfs2_start_trans(osb, OCFS2_XATTR_BLOCK_CREATE_CREDITS); |
6368 | if (IS_ERR(handle)) { | 6544 | if (IS_ERR(ctxt.handle)) { |
6369 | ret = PTR_ERR(handle); | 6545 | ret = PTR_ERR(ctxt.handle); |
6370 | mlog_errno(ret); | 6546 | mlog_errno(ret); |
6371 | goto out; | 6547 | goto out; |
6372 | } | 6548 | } |
6373 | 6549 | ||
6374 | mlog(0, "create new xattr block for inode %llu, index = %d\n", | 6550 | mlog(0, "create new xattr block for inode %llu, index = %d\n", |
6375 | (unsigned long long)fe_bh->b_blocknr, indexed); | 6551 | (unsigned long long)fe_bh->b_blocknr, indexed); |
6376 | ret = ocfs2_create_xattr_block(handle, inode, fe_bh, | 6552 | ret = ocfs2_create_xattr_block(inode, fe_bh, &ctxt, indexed, |
6377 | meta_ac, ret_bh, indexed); | 6553 | ret_bh); |
6378 | if (ret) | 6554 | if (ret) |
6379 | mlog_errno(ret); | 6555 | mlog_errno(ret); |
6380 | 6556 | ||
6381 | ocfs2_commit_trans(osb, handle); | 6557 | ocfs2_commit_trans(osb, ctxt.handle); |
6382 | out: | 6558 | out: |
6383 | ocfs2_free_alloc_context(meta_ac); | 6559 | ocfs2_free_alloc_context(meta_ac); |
6384 | return ret; | 6560 | return ret; |
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index f3b7c1541f3a..75d9b5ba1d45 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <linux/parser.h> | 11 | #include <linux/parser.h> |
12 | #include <linux/buffer_head.h> | 12 | #include <linux/buffer_head.h> |
13 | #include <linux/vmalloc.h> | 13 | #include <linux/vmalloc.h> |
14 | #include <linux/writeback.h> | ||
14 | #include <linux/crc-itu-t.h> | 15 | #include <linux/crc-itu-t.h> |
15 | #include "omfs.h" | 16 | #include "omfs.h" |
16 | 17 | ||
@@ -89,7 +90,7 @@ static void omfs_update_checksums(struct omfs_inode *oi) | |||
89 | oi->i_head.h_check_xor = xor; | 90 | oi->i_head.h_check_xor = xor; |
90 | } | 91 | } |
91 | 92 | ||
92 | static int omfs_write_inode(struct inode *inode, int wait) | 93 | static int __omfs_write_inode(struct inode *inode, int wait) |
93 | { | 94 | { |
94 | struct omfs_inode *oi; | 95 | struct omfs_inode *oi; |
95 | struct omfs_sb_info *sbi = OMFS_SB(inode->i_sb); | 96 | struct omfs_sb_info *sbi = OMFS_SB(inode->i_sb); |
@@ -162,9 +163,14 @@ out: | |||
162 | return ret; | 163 | return ret; |
163 | } | 164 | } |
164 | 165 | ||
166 | static int omfs_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
167 | { | ||
168 | return __omfs_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
169 | } | ||
170 | |||
165 | int omfs_sync_inode(struct inode *inode) | 171 | int omfs_sync_inode(struct inode *inode) |
166 | { | 172 | { |
167 | return omfs_write_inode(inode, 1); | 173 | return __omfs_write_inode(inode, 1); |
168 | } | 174 | } |
169 | 175 | ||
170 | /* | 176 | /* |
@@ -270,7 +270,7 @@ static long do_sys_truncate(const char __user *pathname, loff_t length) | |||
270 | * Make sure that there are no leases. get_write_access() protects | 270 | * Make sure that there are no leases. get_write_access() protects |
271 | * against the truncate racing with a lease-granting setlease(). | 271 | * against the truncate racing with a lease-granting setlease(). |
272 | */ | 272 | */ |
273 | error = break_lease(inode, FMODE_WRITE); | 273 | error = break_lease(inode, O_WRONLY); |
274 | if (error) | 274 | if (error) |
275 | goto put_write_and_out; | 275 | goto put_write_and_out; |
276 | 276 | ||
diff --git a/fs/pnode.c b/fs/pnode.c index 8d5f392ec3d3..5cc564a83149 100644 --- a/fs/pnode.c +++ b/fs/pnode.c | |||
@@ -86,7 +86,7 @@ static int do_make_slave(struct vfsmount *mnt) | |||
86 | 86 | ||
87 | /* | 87 | /* |
88 | * slave 'mnt' to a peer mount that has the | 88 | * slave 'mnt' to a peer mount that has the |
89 | * same root dentry. If none is available than | 89 | * same root dentry. If none is available then |
90 | * slave it to anything that is available. | 90 | * slave it to anything that is available. |
91 | */ | 91 | */ |
92 | while ((peer_mnt = next_peer(peer_mnt)) != mnt && | 92 | while ((peer_mnt = next_peer(peer_mnt)) != mnt && |
@@ -147,6 +147,11 @@ void change_mnt_propagation(struct vfsmount *mnt, int type) | |||
147 | * get the next mount in the propagation tree. | 147 | * get the next mount in the propagation tree. |
148 | * @m: the mount seen last | 148 | * @m: the mount seen last |
149 | * @origin: the original mount from where the tree walk initiated | 149 | * @origin: the original mount from where the tree walk initiated |
150 | * | ||
151 | * Note that peer groups form contiguous segments of slave lists. | ||
152 | * We rely on that in get_source() to be able to find out if | ||
153 | * vfsmount found while iterating with propagation_next() is | ||
154 | * a peer of one we'd found earlier. | ||
150 | */ | 155 | */ |
151 | static struct vfsmount *propagation_next(struct vfsmount *m, | 156 | static struct vfsmount *propagation_next(struct vfsmount *m, |
152 | struct vfsmount *origin) | 157 | struct vfsmount *origin) |
@@ -186,10 +191,6 @@ static struct vfsmount *get_source(struct vfsmount *dest, | |||
186 | { | 191 | { |
187 | struct vfsmount *p_last_src = NULL; | 192 | struct vfsmount *p_last_src = NULL; |
188 | struct vfsmount *p_last_dest = NULL; | 193 | struct vfsmount *p_last_dest = NULL; |
189 | *type = CL_PROPAGATION; | ||
190 | |||
191 | if (IS_MNT_SHARED(dest)) | ||
192 | *type |= CL_MAKE_SHARED; | ||
193 | 194 | ||
194 | while (last_dest != dest->mnt_master) { | 195 | while (last_dest != dest->mnt_master) { |
195 | p_last_dest = last_dest; | 196 | p_last_dest = last_dest; |
@@ -202,13 +203,18 @@ static struct vfsmount *get_source(struct vfsmount *dest, | |||
202 | do { | 203 | do { |
203 | p_last_dest = next_peer(p_last_dest); | 204 | p_last_dest = next_peer(p_last_dest); |
204 | } while (IS_MNT_NEW(p_last_dest)); | 205 | } while (IS_MNT_NEW(p_last_dest)); |
206 | /* is that a peer of the earlier? */ | ||
207 | if (dest == p_last_dest) { | ||
208 | *type = CL_MAKE_SHARED; | ||
209 | return p_last_src; | ||
210 | } | ||
205 | } | 211 | } |
206 | 212 | /* slave of the earlier, then */ | |
207 | if (dest != p_last_dest) { | 213 | *type = CL_SLAVE; |
208 | *type |= CL_SLAVE; | 214 | /* beginning of peer group among the slaves? */ |
209 | return last_src; | 215 | if (IS_MNT_SHARED(dest)) |
210 | } else | 216 | *type |= CL_MAKE_SHARED; |
211 | return p_last_src; | 217 | return last_src; |
212 | } | 218 | } |
213 | 219 | ||
214 | /* | 220 | /* |
diff --git a/fs/pnode.h b/fs/pnode.h index 958665d662af..1ea4ae1efcd3 100644 --- a/fs/pnode.h +++ b/fs/pnode.h | |||
@@ -21,12 +21,11 @@ | |||
21 | #define CL_SLAVE 0x02 | 21 | #define CL_SLAVE 0x02 |
22 | #define CL_COPY_ALL 0x04 | 22 | #define CL_COPY_ALL 0x04 |
23 | #define CL_MAKE_SHARED 0x08 | 23 | #define CL_MAKE_SHARED 0x08 |
24 | #define CL_PROPAGATION 0x10 | 24 | #define CL_PRIVATE 0x10 |
25 | #define CL_PRIVATE 0x20 | ||
26 | 25 | ||
27 | static inline void set_mnt_shared(struct vfsmount *mnt) | 26 | static inline void set_mnt_shared(struct vfsmount *mnt) |
28 | { | 27 | { |
29 | mnt->mnt_flags &= ~MNT_PNODE_MASK; | 28 | mnt->mnt_flags &= ~MNT_SHARED_MASK; |
30 | mnt->mnt_flags |= MNT_SHARED; | 29 | mnt->mnt_flags |= MNT_SHARED; |
31 | } | 30 | } |
32 | 31 | ||
diff --git a/fs/proc/base.c b/fs/proc/base.c index 623e2ffb5d2b..a7310841c831 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c | |||
@@ -647,17 +647,11 @@ static int mounts_release(struct inode *inode, struct file *file) | |||
647 | static unsigned mounts_poll(struct file *file, poll_table *wait) | 647 | static unsigned mounts_poll(struct file *file, poll_table *wait) |
648 | { | 648 | { |
649 | struct proc_mounts *p = file->private_data; | 649 | struct proc_mounts *p = file->private_data; |
650 | struct mnt_namespace *ns = p->ns; | ||
651 | unsigned res = POLLIN | POLLRDNORM; | 650 | unsigned res = POLLIN | POLLRDNORM; |
652 | 651 | ||
653 | poll_wait(file, &ns->poll, wait); | 652 | poll_wait(file, &p->ns->poll, wait); |
654 | 653 | if (mnt_had_events(p)) | |
655 | spin_lock(&vfsmount_lock); | ||
656 | if (p->event != ns->event) { | ||
657 | p->event = ns->event; | ||
658 | res |= POLLERR | POLLPRI; | 654 | res |= POLLERR | POLLPRI; |
659 | } | ||
660 | spin_unlock(&vfsmount_lock); | ||
661 | 655 | ||
662 | return res; | 656 | return res; |
663 | } | 657 | } |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 480cb1065eec..9580abeadeb3 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -662,6 +662,7 @@ struct proc_dir_entry *proc_symlink(const char *name, | |||
662 | } | 662 | } |
663 | return ent; | 663 | return ent; |
664 | } | 664 | } |
665 | EXPORT_SYMBOL(proc_symlink); | ||
665 | 666 | ||
666 | struct proc_dir_entry *proc_mkdir_mode(const char *name, mode_t mode, | 667 | struct proc_dir_entry *proc_mkdir_mode(const char *name, mode_t mode, |
667 | struct proc_dir_entry *parent) | 668 | struct proc_dir_entry *parent) |
@@ -700,6 +701,7 @@ struct proc_dir_entry *proc_mkdir(const char *name, | |||
700 | { | 701 | { |
701 | return proc_mkdir_mode(name, S_IRUGO | S_IXUGO, parent); | 702 | return proc_mkdir_mode(name, S_IRUGO | S_IXUGO, parent); |
702 | } | 703 | } |
704 | EXPORT_SYMBOL(proc_mkdir); | ||
703 | 705 | ||
704 | struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, | 706 | struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, |
705 | struct proc_dir_entry *parent) | 707 | struct proc_dir_entry *parent) |
@@ -728,6 +730,7 @@ struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, | |||
728 | } | 730 | } |
729 | return ent; | 731 | return ent; |
730 | } | 732 | } |
733 | EXPORT_SYMBOL(create_proc_entry); | ||
731 | 734 | ||
732 | struct proc_dir_entry *proc_create_data(const char *name, mode_t mode, | 735 | struct proc_dir_entry *proc_create_data(const char *name, mode_t mode, |
733 | struct proc_dir_entry *parent, | 736 | struct proc_dir_entry *parent, |
@@ -762,6 +765,7 @@ out_free: | |||
762 | out: | 765 | out: |
763 | return NULL; | 766 | return NULL; |
764 | } | 767 | } |
768 | EXPORT_SYMBOL(proc_create_data); | ||
765 | 769 | ||
766 | static void free_proc_entry(struct proc_dir_entry *de) | 770 | static void free_proc_entry(struct proc_dir_entry *de) |
767 | { | 771 | { |
@@ -853,3 +857,4 @@ continue_removing: | |||
853 | de->parent->name, de->name, de->subdir->name); | 857 | de->parent->name, de->name, de->subdir->name); |
854 | pde_put(de); | 858 | pde_put(de); |
855 | } | 859 | } |
860 | EXPORT_SYMBOL(remove_proc_entry); | ||
diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index 7ca78346d3f0..cfe90a48a6e8 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c | |||
@@ -12,37 +12,37 @@ | |||
12 | #include <linux/poll.h> | 12 | #include <linux/poll.h> |
13 | #include <linux/proc_fs.h> | 13 | #include <linux/proc_fs.h> |
14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
15 | #include <linux/syslog.h> | ||
15 | 16 | ||
16 | #include <asm/uaccess.h> | 17 | #include <asm/uaccess.h> |
17 | #include <asm/io.h> | 18 | #include <asm/io.h> |
18 | 19 | ||
19 | extern wait_queue_head_t log_wait; | 20 | extern wait_queue_head_t log_wait; |
20 | 21 | ||
21 | extern int do_syslog(int type, char __user *bug, int count); | ||
22 | |||
23 | static int kmsg_open(struct inode * inode, struct file * file) | 22 | static int kmsg_open(struct inode * inode, struct file * file) |
24 | { | 23 | { |
25 | return do_syslog(1,NULL,0); | 24 | return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_FILE); |
26 | } | 25 | } |
27 | 26 | ||
28 | static int kmsg_release(struct inode * inode, struct file * file) | 27 | static int kmsg_release(struct inode * inode, struct file * file) |
29 | { | 28 | { |
30 | (void) do_syslog(0,NULL,0); | 29 | (void) do_syslog(SYSLOG_ACTION_CLOSE, NULL, 0, SYSLOG_FROM_FILE); |
31 | return 0; | 30 | return 0; |
32 | } | 31 | } |
33 | 32 | ||
34 | static ssize_t kmsg_read(struct file *file, char __user *buf, | 33 | static ssize_t kmsg_read(struct file *file, char __user *buf, |
35 | size_t count, loff_t *ppos) | 34 | size_t count, loff_t *ppos) |
36 | { | 35 | { |
37 | if ((file->f_flags & O_NONBLOCK) && !do_syslog(9, NULL, 0)) | 36 | if ((file->f_flags & O_NONBLOCK) && |
37 | !do_syslog(SYSLOG_ACTION_SIZE_UNREAD, NULL, 0, SYSLOG_FROM_FILE)) | ||
38 | return -EAGAIN; | 38 | return -EAGAIN; |
39 | return do_syslog(2, buf, count); | 39 | return do_syslog(SYSLOG_ACTION_READ, buf, count, SYSLOG_FROM_FILE); |
40 | } | 40 | } |
41 | 41 | ||
42 | static unsigned int kmsg_poll(struct file *file, poll_table *wait) | 42 | static unsigned int kmsg_poll(struct file *file, poll_table *wait) |
43 | { | 43 | { |
44 | poll_wait(file, &log_wait, wait); | 44 | poll_wait(file, &log_wait, wait); |
45 | if (do_syslog(9, NULL, 0)) | 45 | if (do_syslog(SYSLOG_ACTION_SIZE_UNREAD, NULL, 0, SYSLOG_FROM_FILE)) |
46 | return POLLIN | POLLRDNORM; | 46 | return POLLIN | POLLRDNORM; |
47 | return 0; | 47 | return 0; |
48 | } | 48 | } |
diff --git a/fs/proc/root.c b/fs/proc/root.c index b080b791d9e3..757c069f2a65 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
@@ -220,9 +220,3 @@ void pid_ns_release_proc(struct pid_namespace *ns) | |||
220 | { | 220 | { |
221 | mntput(ns->proc_mnt); | 221 | mntput(ns->proc_mnt); |
222 | } | 222 | } |
223 | |||
224 | EXPORT_SYMBOL(proc_symlink); | ||
225 | EXPORT_SYMBOL(proc_mkdir); | ||
226 | EXPORT_SYMBOL(create_proc_entry); | ||
227 | EXPORT_SYMBOL(proc_create_data); | ||
228 | EXPORT_SYMBOL(remove_proc_entry); | ||
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index b8671a54e8ed..d1da94b82d8f 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
@@ -1618,7 +1618,7 @@ int reiserfs_encode_fh(struct dentry *dentry, __u32 * data, int *lenp, | |||
1618 | ** to properly mark inodes for datasync and such, but only actually | 1618 | ** to properly mark inodes for datasync and such, but only actually |
1619 | ** does something when called for a synchronous update. | 1619 | ** does something when called for a synchronous update. |
1620 | */ | 1620 | */ |
1621 | int reiserfs_write_inode(struct inode *inode, int do_sync) | 1621 | int reiserfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
1622 | { | 1622 | { |
1623 | struct reiserfs_transaction_handle th; | 1623 | struct reiserfs_transaction_handle th; |
1624 | int jbegin_count = 1; | 1624 | int jbegin_count = 1; |
@@ -1630,7 +1630,7 @@ int reiserfs_write_inode(struct inode *inode, int do_sync) | |||
1630 | ** inode needs to reach disk for safety, and they can safely be | 1630 | ** inode needs to reach disk for safety, and they can safely be |
1631 | ** ignored because the altered inode has already been logged. | 1631 | ** ignored because the altered inode has already been logged. |
1632 | */ | 1632 | */ |
1633 | if (do_sync && !(current->flags & PF_MEMALLOC)) { | 1633 | if (wbc->sync_mode == WB_SYNC_ALL && !(current->flags & PF_MEMALLOC)) { |
1634 | reiserfs_write_lock(inode->i_sb); | 1634 | reiserfs_write_lock(inode->i_sb); |
1635 | if (!journal_begin(&th, inode->i_sb, jbegin_count)) { | 1635 | if (!journal_begin(&th, inode->i_sb, jbegin_count)) { |
1636 | reiserfs_update_sd(&th, inode); | 1636 | reiserfs_update_sd(&th, inode); |
diff --git a/fs/squashfs/Makefile b/fs/squashfs/Makefile index 70e3244fa30f..df8a19ef870d 100644 --- a/fs/squashfs/Makefile +++ b/fs/squashfs/Makefile | |||
@@ -4,4 +4,4 @@ | |||
4 | 4 | ||
5 | obj-$(CONFIG_SQUASHFS) += squashfs.o | 5 | obj-$(CONFIG_SQUASHFS) += squashfs.o |
6 | squashfs-y += block.o cache.o dir.o export.o file.o fragment.o id.o inode.o | 6 | squashfs-y += block.o cache.o dir.o export.o file.o fragment.o id.o inode.o |
7 | squashfs-y += namei.o super.o symlink.o | 7 | squashfs-y += namei.o super.o symlink.o zlib_wrapper.o decompressor.o |
diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c index 2a7960310349..1cb0d81b164b 100644 --- a/fs/squashfs/block.c +++ b/fs/squashfs/block.c | |||
@@ -29,15 +29,14 @@ | |||
29 | #include <linux/fs.h> | 29 | #include <linux/fs.h> |
30 | #include <linux/vfs.h> | 30 | #include <linux/vfs.h> |
31 | #include <linux/slab.h> | 31 | #include <linux/slab.h> |
32 | #include <linux/mutex.h> | ||
33 | #include <linux/string.h> | 32 | #include <linux/string.h> |
34 | #include <linux/buffer_head.h> | 33 | #include <linux/buffer_head.h> |
35 | #include <linux/zlib.h> | ||
36 | 34 | ||
37 | #include "squashfs_fs.h" | 35 | #include "squashfs_fs.h" |
38 | #include "squashfs_fs_sb.h" | 36 | #include "squashfs_fs_sb.h" |
39 | #include "squashfs_fs_i.h" | 37 | #include "squashfs_fs_i.h" |
40 | #include "squashfs.h" | 38 | #include "squashfs.h" |
39 | #include "decompressor.h" | ||
41 | 40 | ||
42 | /* | 41 | /* |
43 | * Read the metadata block length, this is stored in the first two | 42 | * Read the metadata block length, this is stored in the first two |
@@ -153,72 +152,10 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index, | |||
153 | } | 152 | } |
154 | 153 | ||
155 | if (compressed) { | 154 | if (compressed) { |
156 | int zlib_err = 0, zlib_init = 0; | 155 | length = squashfs_decompress(msblk, buffer, bh, b, offset, |
157 | 156 | length, srclength, pages); | |
158 | /* | 157 | if (length < 0) |
159 | * Uncompress block. | 158 | goto read_failure; |
160 | */ | ||
161 | |||
162 | mutex_lock(&msblk->read_data_mutex); | ||
163 | |||
164 | msblk->stream.avail_out = 0; | ||
165 | msblk->stream.avail_in = 0; | ||
166 | |||
167 | bytes = length; | ||
168 | do { | ||
169 | if (msblk->stream.avail_in == 0 && k < b) { | ||
170 | avail = min(bytes, msblk->devblksize - offset); | ||
171 | bytes -= avail; | ||
172 | wait_on_buffer(bh[k]); | ||
173 | if (!buffer_uptodate(bh[k])) | ||
174 | goto release_mutex; | ||
175 | |||
176 | if (avail == 0) { | ||
177 | offset = 0; | ||
178 | put_bh(bh[k++]); | ||
179 | continue; | ||
180 | } | ||
181 | |||
182 | msblk->stream.next_in = bh[k]->b_data + offset; | ||
183 | msblk->stream.avail_in = avail; | ||
184 | offset = 0; | ||
185 | } | ||
186 | |||
187 | if (msblk->stream.avail_out == 0 && page < pages) { | ||
188 | msblk->stream.next_out = buffer[page++]; | ||
189 | msblk->stream.avail_out = PAGE_CACHE_SIZE; | ||
190 | } | ||
191 | |||
192 | if (!zlib_init) { | ||
193 | zlib_err = zlib_inflateInit(&msblk->stream); | ||
194 | if (zlib_err != Z_OK) { | ||
195 | ERROR("zlib_inflateInit returned" | ||
196 | " unexpected result 0x%x," | ||
197 | " srclength %d\n", zlib_err, | ||
198 | srclength); | ||
199 | goto release_mutex; | ||
200 | } | ||
201 | zlib_init = 1; | ||
202 | } | ||
203 | |||
204 | zlib_err = zlib_inflate(&msblk->stream, Z_SYNC_FLUSH); | ||
205 | |||
206 | if (msblk->stream.avail_in == 0 && k < b) | ||
207 | put_bh(bh[k++]); | ||
208 | } while (zlib_err == Z_OK); | ||
209 | |||
210 | if (zlib_err != Z_STREAM_END) { | ||
211 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
212 | goto release_mutex; | ||
213 | } | ||
214 | |||
215 | zlib_err = zlib_inflateEnd(&msblk->stream); | ||
216 | if (zlib_err != Z_OK) { | ||
217 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
218 | goto release_mutex; | ||
219 | } | ||
220 | length = msblk->stream.total_out; | ||
221 | mutex_unlock(&msblk->read_data_mutex); | ||
222 | } else { | 159 | } else { |
223 | /* | 160 | /* |
224 | * Block is uncompressed. | 161 | * Block is uncompressed. |
@@ -255,9 +192,6 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index, | |||
255 | kfree(bh); | 192 | kfree(bh); |
256 | return length; | 193 | return length; |
257 | 194 | ||
258 | release_mutex: | ||
259 | mutex_unlock(&msblk->read_data_mutex); | ||
260 | |||
261 | block_release: | 195 | block_release: |
262 | for (; k < b; k++) | 196 | for (; k < b; k++) |
263 | put_bh(bh[k]); | 197 | put_bh(bh[k]); |
diff --git a/fs/squashfs/cache.c b/fs/squashfs/cache.c index 40c98fa6b5d6..57314bee9059 100644 --- a/fs/squashfs/cache.c +++ b/fs/squashfs/cache.c | |||
@@ -51,7 +51,6 @@ | |||
51 | #include <linux/sched.h> | 51 | #include <linux/sched.h> |
52 | #include <linux/spinlock.h> | 52 | #include <linux/spinlock.h> |
53 | #include <linux/wait.h> | 53 | #include <linux/wait.h> |
54 | #include <linux/zlib.h> | ||
55 | #include <linux/pagemap.h> | 54 | #include <linux/pagemap.h> |
56 | 55 | ||
57 | #include "squashfs_fs.h" | 56 | #include "squashfs_fs.h" |
diff --git a/fs/squashfs/decompressor.c b/fs/squashfs/decompressor.c new file mode 100644 index 000000000000..157478da6ac9 --- /dev/null +++ b/fs/squashfs/decompressor.c | |||
@@ -0,0 +1,68 @@ | |||
1 | /* | ||
2 | * Squashfs - a compressed read only filesystem for Linux | ||
3 | * | ||
4 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
5 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
6 | * | ||
7 | * This program is free software; you can redistribute it and/or | ||
8 | * modify it under the terms of the GNU General Public License | ||
9 | * as published by the Free Software Foundation; either version 2, | ||
10 | * or (at your option) any later version. | ||
11 | * | ||
12 | * This program is distributed in the hope that it will be useful, | ||
13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
15 | * GNU General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU General Public License | ||
18 | * along with this program; if not, write to the Free Software | ||
19 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
20 | * | ||
21 | * decompressor.c | ||
22 | */ | ||
23 | |||
24 | #include <linux/types.h> | ||
25 | #include <linux/mutex.h> | ||
26 | #include <linux/buffer_head.h> | ||
27 | |||
28 | #include "squashfs_fs.h" | ||
29 | #include "squashfs_fs_sb.h" | ||
30 | #include "squashfs_fs_i.h" | ||
31 | #include "decompressor.h" | ||
32 | #include "squashfs.h" | ||
33 | |||
34 | /* | ||
35 | * This file (and decompressor.h) implements a decompressor framework for | ||
36 | * Squashfs, allowing multiple decompressors to be easily supported | ||
37 | */ | ||
38 | |||
39 | static const struct squashfs_decompressor squashfs_lzma_unsupported_comp_ops = { | ||
40 | NULL, NULL, NULL, LZMA_COMPRESSION, "lzma", 0 | ||
41 | }; | ||
42 | |||
43 | static const struct squashfs_decompressor squashfs_lzo_unsupported_comp_ops = { | ||
44 | NULL, NULL, NULL, LZO_COMPRESSION, "lzo", 0 | ||
45 | }; | ||
46 | |||
47 | static const struct squashfs_decompressor squashfs_unknown_comp_ops = { | ||
48 | NULL, NULL, NULL, 0, "unknown", 0 | ||
49 | }; | ||
50 | |||
51 | static const struct squashfs_decompressor *decompressor[] = { | ||
52 | &squashfs_zlib_comp_ops, | ||
53 | &squashfs_lzma_unsupported_comp_ops, | ||
54 | &squashfs_lzo_unsupported_comp_ops, | ||
55 | &squashfs_unknown_comp_ops | ||
56 | }; | ||
57 | |||
58 | |||
59 | const struct squashfs_decompressor *squashfs_lookup_decompressor(int id) | ||
60 | { | ||
61 | int i; | ||
62 | |||
63 | for (i = 0; decompressor[i]->id; i++) | ||
64 | if (id == decompressor[i]->id) | ||
65 | break; | ||
66 | |||
67 | return decompressor[i]; | ||
68 | } | ||
diff --git a/fs/squashfs/decompressor.h b/fs/squashfs/decompressor.h new file mode 100644 index 000000000000..7425f80783f6 --- /dev/null +++ b/fs/squashfs/decompressor.h | |||
@@ -0,0 +1,55 @@ | |||
1 | #ifndef DECOMPRESSOR_H | ||
2 | #define DECOMPRESSOR_H | ||
3 | /* | ||
4 | * Squashfs - a compressed read only filesystem for Linux | ||
5 | * | ||
6 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
7 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
8 | * | ||
9 | * This program is free software; you can redistribute it and/or | ||
10 | * modify it under the terms of the GNU General Public License | ||
11 | * as published by the Free Software Foundation; either version 2, | ||
12 | * or (at your option) any later version. | ||
13 | * | ||
14 | * This program is distributed in the hope that it will be useful, | ||
15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
17 | * GNU General Public License for more details. | ||
18 | * | ||
19 | * You should have received a copy of the GNU General Public License | ||
20 | * along with this program; if not, write to the Free Software | ||
21 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
22 | * | ||
23 | * decompressor.h | ||
24 | */ | ||
25 | |||
26 | struct squashfs_decompressor { | ||
27 | void *(*init)(struct squashfs_sb_info *); | ||
28 | void (*free)(void *); | ||
29 | int (*decompress)(struct squashfs_sb_info *, void **, | ||
30 | struct buffer_head **, int, int, int, int, int); | ||
31 | int id; | ||
32 | char *name; | ||
33 | int supported; | ||
34 | }; | ||
35 | |||
36 | static inline void *squashfs_decompressor_init(struct squashfs_sb_info *msblk) | ||
37 | { | ||
38 | return msblk->decompressor->init(msblk); | ||
39 | } | ||
40 | |||
41 | static inline void squashfs_decompressor_free(struct squashfs_sb_info *msblk, | ||
42 | void *s) | ||
43 | { | ||
44 | if (msblk->decompressor) | ||
45 | msblk->decompressor->free(s); | ||
46 | } | ||
47 | |||
48 | static inline int squashfs_decompress(struct squashfs_sb_info *msblk, | ||
49 | void **buffer, struct buffer_head **bh, int b, int offset, int length, | ||
50 | int srclength, int pages) | ||
51 | { | ||
52 | return msblk->decompressor->decompress(msblk, buffer, bh, b, offset, | ||
53 | length, srclength, pages); | ||
54 | } | ||
55 | #endif | ||
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c index 566b0eaed868..12b933ac6585 100644 --- a/fs/squashfs/dir.c +++ b/fs/squashfs/dir.c | |||
@@ -30,7 +30,6 @@ | |||
30 | #include <linux/fs.h> | 30 | #include <linux/fs.h> |
31 | #include <linux/vfs.h> | 31 | #include <linux/vfs.h> |
32 | #include <linux/slab.h> | 32 | #include <linux/slab.h> |
33 | #include <linux/zlib.h> | ||
34 | 33 | ||
35 | #include "squashfs_fs.h" | 34 | #include "squashfs_fs.h" |
36 | #include "squashfs_fs_sb.h" | 35 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/export.c b/fs/squashfs/export.c index 2b1b8fe5e037..7f93d5a9ee05 100644 --- a/fs/squashfs/export.c +++ b/fs/squashfs/export.c | |||
@@ -39,7 +39,6 @@ | |||
39 | #include <linux/vfs.h> | 39 | #include <linux/vfs.h> |
40 | #include <linux/dcache.h> | 40 | #include <linux/dcache.h> |
41 | #include <linux/exportfs.h> | 41 | #include <linux/exportfs.h> |
42 | #include <linux/zlib.h> | ||
43 | #include <linux/slab.h> | 42 | #include <linux/slab.h> |
44 | 43 | ||
45 | #include "squashfs_fs.h" | 44 | #include "squashfs_fs.h" |
diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c index 717767d831df..a25c5060bdcb 100644 --- a/fs/squashfs/file.c +++ b/fs/squashfs/file.c | |||
@@ -47,7 +47,6 @@ | |||
47 | #include <linux/string.h> | 47 | #include <linux/string.h> |
48 | #include <linux/pagemap.h> | 48 | #include <linux/pagemap.h> |
49 | #include <linux/mutex.h> | 49 | #include <linux/mutex.h> |
50 | #include <linux/zlib.h> | ||
51 | 50 | ||
52 | #include "squashfs_fs.h" | 51 | #include "squashfs_fs.h" |
53 | #include "squashfs_fs_sb.h" | 52 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/fragment.c b/fs/squashfs/fragment.c index b5a2c15bbbc7..7c90bbd6879d 100644 --- a/fs/squashfs/fragment.c +++ b/fs/squashfs/fragment.c | |||
@@ -36,7 +36,6 @@ | |||
36 | #include <linux/fs.h> | 36 | #include <linux/fs.h> |
37 | #include <linux/vfs.h> | 37 | #include <linux/vfs.h> |
38 | #include <linux/slab.h> | 38 | #include <linux/slab.h> |
39 | #include <linux/zlib.h> | ||
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/id.c b/fs/squashfs/id.c index 3795b837ba28..b7f64bcd2b70 100644 --- a/fs/squashfs/id.c +++ b/fs/squashfs/id.c | |||
@@ -34,7 +34,6 @@ | |||
34 | #include <linux/fs.h> | 34 | #include <linux/fs.h> |
35 | #include <linux/vfs.h> | 35 | #include <linux/vfs.h> |
36 | #include <linux/slab.h> | 36 | #include <linux/slab.h> |
37 | #include <linux/zlib.h> | ||
38 | 37 | ||
39 | #include "squashfs_fs.h" | 38 | #include "squashfs_fs.h" |
40 | #include "squashfs_fs_sb.h" | 39 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index 9101dbde39ec..49daaf669e41 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c | |||
@@ -40,7 +40,6 @@ | |||
40 | 40 | ||
41 | #include <linux/fs.h> | 41 | #include <linux/fs.h> |
42 | #include <linux/vfs.h> | 42 | #include <linux/vfs.h> |
43 | #include <linux/zlib.h> | ||
44 | 43 | ||
45 | #include "squashfs_fs.h" | 44 | #include "squashfs_fs.h" |
46 | #include "squashfs_fs_sb.h" | 45 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c index 9e398653b22b..5266bd8ad932 100644 --- a/fs/squashfs/namei.c +++ b/fs/squashfs/namei.c | |||
@@ -57,7 +57,6 @@ | |||
57 | #include <linux/slab.h> | 57 | #include <linux/slab.h> |
58 | #include <linux/string.h> | 58 | #include <linux/string.h> |
59 | #include <linux/dcache.h> | 59 | #include <linux/dcache.h> |
60 | #include <linux/zlib.h> | ||
61 | 60 | ||
62 | #include "squashfs_fs.h" | 61 | #include "squashfs_fs.h" |
63 | #include "squashfs_fs_sb.h" | 62 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/squashfs.h b/fs/squashfs/squashfs.h index 0e9feb6adf7e..fe2587af5512 100644 --- a/fs/squashfs/squashfs.h +++ b/fs/squashfs/squashfs.h | |||
@@ -51,6 +51,9 @@ extern struct squashfs_cache_entry *squashfs_get_datablock(struct super_block *, | |||
51 | u64, int); | 51 | u64, int); |
52 | extern int squashfs_read_table(struct super_block *, void *, u64, int); | 52 | extern int squashfs_read_table(struct super_block *, void *, u64, int); |
53 | 53 | ||
54 | /* decompressor.c */ | ||
55 | extern const struct squashfs_decompressor *squashfs_lookup_decompressor(int); | ||
56 | |||
54 | /* export.c */ | 57 | /* export.c */ |
55 | extern __le64 *squashfs_read_inode_lookup_table(struct super_block *, u64, | 58 | extern __le64 *squashfs_read_inode_lookup_table(struct super_block *, u64, |
56 | unsigned int); | 59 | unsigned int); |
@@ -71,7 +74,7 @@ extern struct inode *squashfs_iget(struct super_block *, long long, | |||
71 | extern int squashfs_read_inode(struct inode *, long long); | 74 | extern int squashfs_read_inode(struct inode *, long long); |
72 | 75 | ||
73 | /* | 76 | /* |
74 | * Inodes and files operations | 77 | * Inodes, files and decompressor operations |
75 | */ | 78 | */ |
76 | 79 | ||
77 | /* dir.c */ | 80 | /* dir.c */ |
@@ -88,3 +91,6 @@ extern const struct inode_operations squashfs_dir_inode_ops; | |||
88 | 91 | ||
89 | /* symlink.c */ | 92 | /* symlink.c */ |
90 | extern const struct address_space_operations squashfs_symlink_aops; | 93 | extern const struct address_space_operations squashfs_symlink_aops; |
94 | |||
95 | /* zlib_wrapper.c */ | ||
96 | extern const struct squashfs_decompressor squashfs_zlib_comp_ops; | ||
diff --git a/fs/squashfs/squashfs_fs.h b/fs/squashfs/squashfs_fs.h index 283daafc568e..79024245ea00 100644 --- a/fs/squashfs/squashfs_fs.h +++ b/fs/squashfs/squashfs_fs.h | |||
@@ -183,8 +183,6 @@ | |||
183 | #define SQUASHFS_MAX_FILE_SIZE (1LL << \ | 183 | #define SQUASHFS_MAX_FILE_SIZE (1LL << \ |
184 | (SQUASHFS_MAX_FILE_SIZE_LOG - 2)) | 184 | (SQUASHFS_MAX_FILE_SIZE_LOG - 2)) |
185 | 185 | ||
186 | #define SQUASHFS_MARKER_BYTE 0xff | ||
187 | |||
188 | /* meta index cache */ | 186 | /* meta index cache */ |
189 | #define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int)) | 187 | #define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int)) |
190 | #define SQUASHFS_META_ENTRIES 127 | 188 | #define SQUASHFS_META_ENTRIES 127 |
@@ -211,7 +209,9 @@ struct meta_index { | |||
211 | /* | 209 | /* |
212 | * definitions for structures on disk | 210 | * definitions for structures on disk |
213 | */ | 211 | */ |
214 | #define ZLIB_COMPRESSION 1 | 212 | #define ZLIB_COMPRESSION 1 |
213 | #define LZMA_COMPRESSION 2 | ||
214 | #define LZO_COMPRESSION 3 | ||
215 | 215 | ||
216 | struct squashfs_super_block { | 216 | struct squashfs_super_block { |
217 | __le32 s_magic; | 217 | __le32 s_magic; |
diff --git a/fs/squashfs/squashfs_fs_sb.h b/fs/squashfs/squashfs_fs_sb.h index c8c65614dd1c..2e77dc547e25 100644 --- a/fs/squashfs/squashfs_fs_sb.h +++ b/fs/squashfs/squashfs_fs_sb.h | |||
@@ -52,25 +52,25 @@ struct squashfs_cache_entry { | |||
52 | }; | 52 | }; |
53 | 53 | ||
54 | struct squashfs_sb_info { | 54 | struct squashfs_sb_info { |
55 | int devblksize; | 55 | const struct squashfs_decompressor *decompressor; |
56 | int devblksize_log2; | 56 | int devblksize; |
57 | struct squashfs_cache *block_cache; | 57 | int devblksize_log2; |
58 | struct squashfs_cache *fragment_cache; | 58 | struct squashfs_cache *block_cache; |
59 | struct squashfs_cache *read_page; | 59 | struct squashfs_cache *fragment_cache; |
60 | int next_meta_index; | 60 | struct squashfs_cache *read_page; |
61 | __le64 *id_table; | 61 | int next_meta_index; |
62 | __le64 *fragment_index; | 62 | __le64 *id_table; |
63 | unsigned int *fragment_index_2; | 63 | __le64 *fragment_index; |
64 | struct mutex read_data_mutex; | 64 | struct mutex read_data_mutex; |
65 | struct mutex meta_index_mutex; | 65 | struct mutex meta_index_mutex; |
66 | struct meta_index *meta_index; | 66 | struct meta_index *meta_index; |
67 | z_stream stream; | 67 | void *stream; |
68 | __le64 *inode_lookup_table; | 68 | __le64 *inode_lookup_table; |
69 | u64 inode_table; | 69 | u64 inode_table; |
70 | u64 directory_table; | 70 | u64 directory_table; |
71 | unsigned int block_size; | 71 | unsigned int block_size; |
72 | unsigned short block_log; | 72 | unsigned short block_log; |
73 | long long bytes_used; | 73 | long long bytes_used; |
74 | unsigned int inodes; | 74 | unsigned int inodes; |
75 | }; | 75 | }; |
76 | #endif | 76 | #endif |
diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c index 6c197ef53add..3550aec2f655 100644 --- a/fs/squashfs/super.c +++ b/fs/squashfs/super.c | |||
@@ -35,34 +35,41 @@ | |||
35 | #include <linux/pagemap.h> | 35 | #include <linux/pagemap.h> |
36 | #include <linux/init.h> | 36 | #include <linux/init.h> |
37 | #include <linux/module.h> | 37 | #include <linux/module.h> |
38 | #include <linux/zlib.h> | ||
39 | #include <linux/magic.h> | 38 | #include <linux/magic.h> |
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
43 | #include "squashfs_fs_i.h" | 42 | #include "squashfs_fs_i.h" |
44 | #include "squashfs.h" | 43 | #include "squashfs.h" |
44 | #include "decompressor.h" | ||
45 | 45 | ||
46 | static struct file_system_type squashfs_fs_type; | 46 | static struct file_system_type squashfs_fs_type; |
47 | static const struct super_operations squashfs_super_ops; | 47 | static const struct super_operations squashfs_super_ops; |
48 | 48 | ||
49 | static int supported_squashfs_filesystem(short major, short minor, short comp) | 49 | static const struct squashfs_decompressor *supported_squashfs_filesystem(short |
50 | major, short minor, short id) | ||
50 | { | 51 | { |
52 | const struct squashfs_decompressor *decompressor; | ||
53 | |||
51 | if (major < SQUASHFS_MAJOR) { | 54 | if (major < SQUASHFS_MAJOR) { |
52 | ERROR("Major/Minor mismatch, older Squashfs %d.%d " | 55 | ERROR("Major/Minor mismatch, older Squashfs %d.%d " |
53 | "filesystems are unsupported\n", major, minor); | 56 | "filesystems are unsupported\n", major, minor); |
54 | return -EINVAL; | 57 | return NULL; |
55 | } else if (major > SQUASHFS_MAJOR || minor > SQUASHFS_MINOR) { | 58 | } else if (major > SQUASHFS_MAJOR || minor > SQUASHFS_MINOR) { |
56 | ERROR("Major/Minor mismatch, trying to mount newer " | 59 | ERROR("Major/Minor mismatch, trying to mount newer " |
57 | "%d.%d filesystem\n", major, minor); | 60 | "%d.%d filesystem\n", major, minor); |
58 | ERROR("Please update your kernel\n"); | 61 | ERROR("Please update your kernel\n"); |
59 | return -EINVAL; | 62 | return NULL; |
60 | } | 63 | } |
61 | 64 | ||
62 | if (comp != ZLIB_COMPRESSION) | 65 | decompressor = squashfs_lookup_decompressor(id); |
63 | return -EINVAL; | 66 | if (!decompressor->supported) { |
67 | ERROR("Filesystem uses \"%s\" compression. This is not " | ||
68 | "supported\n", decompressor->name); | ||
69 | return NULL; | ||
70 | } | ||
64 | 71 | ||
65 | return 0; | 72 | return decompressor; |
66 | } | 73 | } |
67 | 74 | ||
68 | 75 | ||
@@ -87,13 +94,6 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
87 | } | 94 | } |
88 | msblk = sb->s_fs_info; | 95 | msblk = sb->s_fs_info; |
89 | 96 | ||
90 | msblk->stream.workspace = kmalloc(zlib_inflate_workspacesize(), | ||
91 | GFP_KERNEL); | ||
92 | if (msblk->stream.workspace == NULL) { | ||
93 | ERROR("Failed to allocate zlib workspace\n"); | ||
94 | goto failure; | ||
95 | } | ||
96 | |||
97 | sblk = kzalloc(sizeof(*sblk), GFP_KERNEL); | 97 | sblk = kzalloc(sizeof(*sblk), GFP_KERNEL); |
98 | if (sblk == NULL) { | 98 | if (sblk == NULL) { |
99 | ERROR("Failed to allocate squashfs_super_block\n"); | 99 | ERROR("Failed to allocate squashfs_super_block\n"); |
@@ -120,25 +120,25 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
120 | goto failed_mount; | 120 | goto failed_mount; |
121 | } | 121 | } |
122 | 122 | ||
123 | err = -EINVAL; | ||
124 | |||
123 | /* Check it is a SQUASHFS superblock */ | 125 | /* Check it is a SQUASHFS superblock */ |
124 | sb->s_magic = le32_to_cpu(sblk->s_magic); | 126 | sb->s_magic = le32_to_cpu(sblk->s_magic); |
125 | if (sb->s_magic != SQUASHFS_MAGIC) { | 127 | if (sb->s_magic != SQUASHFS_MAGIC) { |
126 | if (!silent) | 128 | if (!silent) |
127 | ERROR("Can't find a SQUASHFS superblock on %s\n", | 129 | ERROR("Can't find a SQUASHFS superblock on %s\n", |
128 | bdevname(sb->s_bdev, b)); | 130 | bdevname(sb->s_bdev, b)); |
129 | err = -EINVAL; | ||
130 | goto failed_mount; | 131 | goto failed_mount; |
131 | } | 132 | } |
132 | 133 | ||
133 | /* Check the MAJOR & MINOR versions and compression type */ | 134 | /* Check the MAJOR & MINOR versions and lookup compression type */ |
134 | err = supported_squashfs_filesystem(le16_to_cpu(sblk->s_major), | 135 | msblk->decompressor = supported_squashfs_filesystem( |
136 | le16_to_cpu(sblk->s_major), | ||
135 | le16_to_cpu(sblk->s_minor), | 137 | le16_to_cpu(sblk->s_minor), |
136 | le16_to_cpu(sblk->compression)); | 138 | le16_to_cpu(sblk->compression)); |
137 | if (err < 0) | 139 | if (msblk->decompressor == NULL) |
138 | goto failed_mount; | 140 | goto failed_mount; |
139 | 141 | ||
140 | err = -EINVAL; | ||
141 | |||
142 | /* | 142 | /* |
143 | * Check if there's xattrs in the filesystem. These are not | 143 | * Check if there's xattrs in the filesystem. These are not |
144 | * supported in this version, so warn that they will be ignored. | 144 | * supported in this version, so warn that they will be ignored. |
@@ -205,6 +205,10 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
205 | 205 | ||
206 | err = -ENOMEM; | 206 | err = -ENOMEM; |
207 | 207 | ||
208 | msblk->stream = squashfs_decompressor_init(msblk); | ||
209 | if (msblk->stream == NULL) | ||
210 | goto failed_mount; | ||
211 | |||
208 | msblk->block_cache = squashfs_cache_init("metadata", | 212 | msblk->block_cache = squashfs_cache_init("metadata", |
209 | SQUASHFS_CACHED_BLKS, SQUASHFS_METADATA_SIZE); | 213 | SQUASHFS_CACHED_BLKS, SQUASHFS_METADATA_SIZE); |
210 | if (msblk->block_cache == NULL) | 214 | if (msblk->block_cache == NULL) |
@@ -292,17 +296,16 @@ failed_mount: | |||
292 | squashfs_cache_delete(msblk->block_cache); | 296 | squashfs_cache_delete(msblk->block_cache); |
293 | squashfs_cache_delete(msblk->fragment_cache); | 297 | squashfs_cache_delete(msblk->fragment_cache); |
294 | squashfs_cache_delete(msblk->read_page); | 298 | squashfs_cache_delete(msblk->read_page); |
299 | squashfs_decompressor_free(msblk, msblk->stream); | ||
295 | kfree(msblk->inode_lookup_table); | 300 | kfree(msblk->inode_lookup_table); |
296 | kfree(msblk->fragment_index); | 301 | kfree(msblk->fragment_index); |
297 | kfree(msblk->id_table); | 302 | kfree(msblk->id_table); |
298 | kfree(msblk->stream.workspace); | ||
299 | kfree(sb->s_fs_info); | 303 | kfree(sb->s_fs_info); |
300 | sb->s_fs_info = NULL; | 304 | sb->s_fs_info = NULL; |
301 | kfree(sblk); | 305 | kfree(sblk); |
302 | return err; | 306 | return err; |
303 | 307 | ||
304 | failure: | 308 | failure: |
305 | kfree(msblk->stream.workspace); | ||
306 | kfree(sb->s_fs_info); | 309 | kfree(sb->s_fs_info); |
307 | sb->s_fs_info = NULL; | 310 | sb->s_fs_info = NULL; |
308 | return -ENOMEM; | 311 | return -ENOMEM; |
@@ -346,10 +349,10 @@ static void squashfs_put_super(struct super_block *sb) | |||
346 | squashfs_cache_delete(sbi->block_cache); | 349 | squashfs_cache_delete(sbi->block_cache); |
347 | squashfs_cache_delete(sbi->fragment_cache); | 350 | squashfs_cache_delete(sbi->fragment_cache); |
348 | squashfs_cache_delete(sbi->read_page); | 351 | squashfs_cache_delete(sbi->read_page); |
352 | squashfs_decompressor_free(sbi, sbi->stream); | ||
349 | kfree(sbi->id_table); | 353 | kfree(sbi->id_table); |
350 | kfree(sbi->fragment_index); | 354 | kfree(sbi->fragment_index); |
351 | kfree(sbi->meta_index); | 355 | kfree(sbi->meta_index); |
352 | kfree(sbi->stream.workspace); | ||
353 | kfree(sb->s_fs_info); | 356 | kfree(sb->s_fs_info); |
354 | sb->s_fs_info = NULL; | 357 | sb->s_fs_info = NULL; |
355 | } | 358 | } |
diff --git a/fs/squashfs/symlink.c b/fs/squashfs/symlink.c index 83d87880aac8..e80be2022a7f 100644 --- a/fs/squashfs/symlink.c +++ b/fs/squashfs/symlink.c | |||
@@ -36,7 +36,6 @@ | |||
36 | #include <linux/slab.h> | 36 | #include <linux/slab.h> |
37 | #include <linux/string.h> | 37 | #include <linux/string.h> |
38 | #include <linux/pagemap.h> | 38 | #include <linux/pagemap.h> |
39 | #include <linux/zlib.h> | ||
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/zlib_wrapper.c b/fs/squashfs/zlib_wrapper.c new file mode 100644 index 000000000000..4dd70e04333b --- /dev/null +++ b/fs/squashfs/zlib_wrapper.c | |||
@@ -0,0 +1,150 @@ | |||
1 | /* | ||
2 | * Squashfs - a compressed read only filesystem for Linux | ||
3 | * | ||
4 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
5 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
6 | * | ||
7 | * This program is free software; you can redistribute it and/or | ||
8 | * modify it under the terms of the GNU General Public License | ||
9 | * as published by the Free Software Foundation; either version 2, | ||
10 | * or (at your option) any later version. | ||
11 | * | ||
12 | * This program is distributed in the hope that it will be useful, | ||
13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
15 | * GNU General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU General Public License | ||
18 | * along with this program; if not, write to the Free Software | ||
19 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
20 | * | ||
21 | * zlib_wrapper.c | ||
22 | */ | ||
23 | |||
24 | |||
25 | #include <linux/mutex.h> | ||
26 | #include <linux/buffer_head.h> | ||
27 | #include <linux/zlib.h> | ||
28 | |||
29 | #include "squashfs_fs.h" | ||
30 | #include "squashfs_fs_sb.h" | ||
31 | #include "squashfs_fs_i.h" | ||
32 | #include "squashfs.h" | ||
33 | #include "decompressor.h" | ||
34 | |||
35 | static void *zlib_init(struct squashfs_sb_info *dummy) | ||
36 | { | ||
37 | z_stream *stream = kmalloc(sizeof(z_stream), GFP_KERNEL); | ||
38 | if (stream == NULL) | ||
39 | goto failed; | ||
40 | stream->workspace = kmalloc(zlib_inflate_workspacesize(), | ||
41 | GFP_KERNEL); | ||
42 | if (stream->workspace == NULL) | ||
43 | goto failed; | ||
44 | |||
45 | return stream; | ||
46 | |||
47 | failed: | ||
48 | ERROR("Failed to allocate zlib workspace\n"); | ||
49 | kfree(stream); | ||
50 | return NULL; | ||
51 | } | ||
52 | |||
53 | |||
54 | static void zlib_free(void *strm) | ||
55 | { | ||
56 | z_stream *stream = strm; | ||
57 | |||
58 | if (stream) | ||
59 | kfree(stream->workspace); | ||
60 | kfree(stream); | ||
61 | } | ||
62 | |||
63 | |||
64 | static int zlib_uncompress(struct squashfs_sb_info *msblk, void **buffer, | ||
65 | struct buffer_head **bh, int b, int offset, int length, int srclength, | ||
66 | int pages) | ||
67 | { | ||
68 | int zlib_err = 0, zlib_init = 0; | ||
69 | int avail, bytes, k = 0, page = 0; | ||
70 | z_stream *stream = msblk->stream; | ||
71 | |||
72 | mutex_lock(&msblk->read_data_mutex); | ||
73 | |||
74 | stream->avail_out = 0; | ||
75 | stream->avail_in = 0; | ||
76 | |||
77 | bytes = length; | ||
78 | do { | ||
79 | if (stream->avail_in == 0 && k < b) { | ||
80 | avail = min(bytes, msblk->devblksize - offset); | ||
81 | bytes -= avail; | ||
82 | wait_on_buffer(bh[k]); | ||
83 | if (!buffer_uptodate(bh[k])) | ||
84 | goto release_mutex; | ||
85 | |||
86 | if (avail == 0) { | ||
87 | offset = 0; | ||
88 | put_bh(bh[k++]); | ||
89 | continue; | ||
90 | } | ||
91 | |||
92 | stream->next_in = bh[k]->b_data + offset; | ||
93 | stream->avail_in = avail; | ||
94 | offset = 0; | ||
95 | } | ||
96 | |||
97 | if (stream->avail_out == 0 && page < pages) { | ||
98 | stream->next_out = buffer[page++]; | ||
99 | stream->avail_out = PAGE_CACHE_SIZE; | ||
100 | } | ||
101 | |||
102 | if (!zlib_init) { | ||
103 | zlib_err = zlib_inflateInit(stream); | ||
104 | if (zlib_err != Z_OK) { | ||
105 | ERROR("zlib_inflateInit returned unexpected " | ||
106 | "result 0x%x, srclength %d\n", | ||
107 | zlib_err, srclength); | ||
108 | goto release_mutex; | ||
109 | } | ||
110 | zlib_init = 1; | ||
111 | } | ||
112 | |||
113 | zlib_err = zlib_inflate(stream, Z_SYNC_FLUSH); | ||
114 | |||
115 | if (stream->avail_in == 0 && k < b) | ||
116 | put_bh(bh[k++]); | ||
117 | } while (zlib_err == Z_OK); | ||
118 | |||
119 | if (zlib_err != Z_STREAM_END) { | ||
120 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
121 | goto release_mutex; | ||
122 | } | ||
123 | |||
124 | zlib_err = zlib_inflateEnd(stream); | ||
125 | if (zlib_err != Z_OK) { | ||
126 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
127 | goto release_mutex; | ||
128 | } | ||
129 | |||
130 | mutex_unlock(&msblk->read_data_mutex); | ||
131 | return stream->total_out; | ||
132 | |||
133 | release_mutex: | ||
134 | mutex_unlock(&msblk->read_data_mutex); | ||
135 | |||
136 | for (; k < b; k++) | ||
137 | put_bh(bh[k]); | ||
138 | |||
139 | return -EIO; | ||
140 | } | ||
141 | |||
142 | const struct squashfs_decompressor squashfs_zlib_comp_ops = { | ||
143 | .init = zlib_init, | ||
144 | .free = zlib_free, | ||
145 | .decompress = zlib_uncompress, | ||
146 | .id = ZLIB_COMPRESSION, | ||
147 | .name = "zlib", | ||
148 | .supported = 1 | ||
149 | }; | ||
150 | |||
diff --git a/fs/super.c b/fs/super.c index aff046b0fe78..f35ac6022109 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -568,7 +568,7 @@ out: | |||
568 | int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | 568 | int do_remount_sb(struct super_block *sb, int flags, void *data, int force) |
569 | { | 569 | { |
570 | int retval; | 570 | int retval; |
571 | int remount_rw; | 571 | int remount_rw, remount_ro; |
572 | 572 | ||
573 | if (sb->s_frozen != SB_UNFROZEN) | 573 | if (sb->s_frozen != SB_UNFROZEN) |
574 | return -EBUSY; | 574 | return -EBUSY; |
@@ -583,9 +583,12 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
583 | shrink_dcache_sb(sb); | 583 | shrink_dcache_sb(sb); |
584 | sync_filesystem(sb); | 584 | sync_filesystem(sb); |
585 | 585 | ||
586 | remount_ro = (flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY); | ||
587 | remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY); | ||
588 | |||
586 | /* If we are remounting RDONLY and current sb is read/write, | 589 | /* If we are remounting RDONLY and current sb is read/write, |
587 | make sure there are no rw files opened */ | 590 | make sure there are no rw files opened */ |
588 | if ((flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY)) { | 591 | if (remount_ro) { |
589 | if (force) | 592 | if (force) |
590 | mark_files_ro(sb); | 593 | mark_files_ro(sb); |
591 | else if (!fs_may_remount_ro(sb)) | 594 | else if (!fs_may_remount_ro(sb)) |
@@ -594,7 +597,6 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
594 | if (retval < 0 && retval != -ENOSYS) | 597 | if (retval < 0 && retval != -ENOSYS) |
595 | return -EBUSY; | 598 | return -EBUSY; |
596 | } | 599 | } |
597 | remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY); | ||
598 | 600 | ||
599 | if (sb->s_op->remount_fs) { | 601 | if (sb->s_op->remount_fs) { |
600 | retval = sb->s_op->remount_fs(sb, &flags, data); | 602 | retval = sb->s_op->remount_fs(sb, &flags, data); |
@@ -604,6 +606,16 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
604 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); | 606 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); |
605 | if (remount_rw) | 607 | if (remount_rw) |
606 | vfs_dq_quota_on_remount(sb); | 608 | vfs_dq_quota_on_remount(sb); |
609 | /* | ||
610 | * Some filesystems modify their metadata via some other path than the | ||
611 | * bdev buffer cache (eg. use a private mapping, or directories in | ||
612 | * pagecache, etc). Also file data modifications go via their own | ||
613 | * mappings. So If we try to mount readonly then copy the filesystem | ||
614 | * from bdev, we could get stale data, so invalidate it to give a best | ||
615 | * effort at coherency. | ||
616 | */ | ||
617 | if (remount_ro && sb->s_bdev) | ||
618 | invalidate_bdev(sb->s_bdev); | ||
607 | return 0; | 619 | return 0; |
608 | } | 620 | } |
609 | 621 | ||
@@ -925,6 +937,9 @@ vfs_kern_mount(struct file_system_type *type, int flags, const char *name, void | |||
925 | if (!mnt) | 937 | if (!mnt) |
926 | goto out; | 938 | goto out; |
927 | 939 | ||
940 | if (flags & MS_KERNMOUNT) | ||
941 | mnt->mnt_flags = MNT_INTERNAL; | ||
942 | |||
928 | if (data && !(type->fs_flags & FS_BINARY_MOUNTDATA)) { | 943 | if (data && !(type->fs_flags & FS_BINARY_MOUNTDATA)) { |
929 | secdata = alloc_secdata(); | 944 | secdata = alloc_secdata(); |
930 | if (!secdata) | 945 | if (!secdata) |
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index 9824743832a7..4573734d723d 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <linux/init.h> | 26 | #include <linux/init.h> |
27 | #include <linux/buffer_head.h> | 27 | #include <linux/buffer_head.h> |
28 | #include <linux/vfs.h> | 28 | #include <linux/vfs.h> |
29 | #include <linux/writeback.h> | ||
29 | #include <linux/namei.h> | 30 | #include <linux/namei.h> |
30 | #include <asm/byteorder.h> | 31 | #include <asm/byteorder.h> |
31 | #include "sysv.h" | 32 | #include "sysv.h" |
@@ -246,7 +247,7 @@ bad_inode: | |||
246 | return ERR_PTR(-EIO); | 247 | return ERR_PTR(-EIO); |
247 | } | 248 | } |
248 | 249 | ||
249 | int sysv_write_inode(struct inode *inode, int wait) | 250 | static int __sysv_write_inode(struct inode *inode, int wait) |
250 | { | 251 | { |
251 | struct super_block * sb = inode->i_sb; | 252 | struct super_block * sb = inode->i_sb; |
252 | struct sysv_sb_info * sbi = SYSV_SB(sb); | 253 | struct sysv_sb_info * sbi = SYSV_SB(sb); |
@@ -296,9 +297,14 @@ int sysv_write_inode(struct inode *inode, int wait) | |||
296 | return 0; | 297 | return 0; |
297 | } | 298 | } |
298 | 299 | ||
300 | int sysv_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
301 | { | ||
302 | return __sysv_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
303 | } | ||
304 | |||
299 | int sysv_sync_inode(struct inode *inode) | 305 | int sysv_sync_inode(struct inode *inode) |
300 | { | 306 | { |
301 | return sysv_write_inode(inode, 1); | 307 | return __sysv_write_inode(inode, 1); |
302 | } | 308 | } |
303 | 309 | ||
304 | static void sysv_delete_inode(struct inode *inode) | 310 | static void sysv_delete_inode(struct inode *inode) |
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h index 53786eb5cf60..94cb9b4d76c2 100644 --- a/fs/sysv/sysv.h +++ b/fs/sysv/sysv.h | |||
@@ -142,7 +142,7 @@ extern int __sysv_write_begin(struct file *file, struct address_space *mapping, | |||
142 | 142 | ||
143 | /* inode.c */ | 143 | /* inode.c */ |
144 | extern struct inode *sysv_iget(struct super_block *, unsigned int); | 144 | extern struct inode *sysv_iget(struct super_block *, unsigned int); |
145 | extern int sysv_write_inode(struct inode *, int); | 145 | extern int sysv_write_inode(struct inode *, struct writeback_control *wbc); |
146 | extern int sysv_sync_inode(struct inode *); | 146 | extern int sysv_sync_inode(struct inode *); |
147 | extern void sysv_set_inode(struct inode *, dev_t); | 147 | extern void sysv_set_inode(struct inode *, dev_t); |
148 | extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *); | 148 | extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *); |
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 552fb0111fff..401e503d44a1 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
@@ -1120,7 +1120,7 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1120 | if (release) | 1120 | if (release) |
1121 | ubifs_release_budget(c, &ino_req); | 1121 | ubifs_release_budget(c, &ino_req); |
1122 | if (IS_SYNC(old_inode)) | 1122 | if (IS_SYNC(old_inode)) |
1123 | err = old_inode->i_sb->s_op->write_inode(old_inode, 1); | 1123 | err = old_inode->i_sb->s_op->write_inode(old_inode, NULL); |
1124 | return err; | 1124 | return err; |
1125 | 1125 | ||
1126 | out_cancel: | 1126 | out_cancel: |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 16a6444330ec..e26c02ab6cd5 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c | |||
@@ -1011,7 +1011,7 @@ static int ubifs_writepage(struct page *page, struct writeback_control *wbc) | |||
1011 | /* Is the page fully inside @i_size? */ | 1011 | /* Is the page fully inside @i_size? */ |
1012 | if (page->index < end_index) { | 1012 | if (page->index < end_index) { |
1013 | if (page->index >= synced_i_size >> PAGE_CACHE_SHIFT) { | 1013 | if (page->index >= synced_i_size >> PAGE_CACHE_SHIFT) { |
1014 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1014 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1015 | if (err) | 1015 | if (err) |
1016 | goto out_unlock; | 1016 | goto out_unlock; |
1017 | /* | 1017 | /* |
@@ -1039,7 +1039,7 @@ static int ubifs_writepage(struct page *page, struct writeback_control *wbc) | |||
1039 | kunmap_atomic(kaddr, KM_USER0); | 1039 | kunmap_atomic(kaddr, KM_USER0); |
1040 | 1040 | ||
1041 | if (i_size > synced_i_size) { | 1041 | if (i_size > synced_i_size) { |
1042 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1042 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1043 | if (err) | 1043 | if (err) |
1044 | goto out_unlock; | 1044 | goto out_unlock; |
1045 | } | 1045 | } |
@@ -1242,7 +1242,7 @@ static int do_setattr(struct ubifs_info *c, struct inode *inode, | |||
1242 | if (release) | 1242 | if (release) |
1243 | ubifs_release_budget(c, &req); | 1243 | ubifs_release_budget(c, &req); |
1244 | if (IS_SYNC(inode)) | 1244 | if (IS_SYNC(inode)) |
1245 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1245 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1246 | return err; | 1246 | return err; |
1247 | 1247 | ||
1248 | out: | 1248 | out: |
@@ -1316,7 +1316,7 @@ int ubifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1316 | * the inode unless this is a 'datasync()' call. | 1316 | * the inode unless this is a 'datasync()' call. |
1317 | */ | 1317 | */ |
1318 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { | 1318 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { |
1319 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1319 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1320 | if (err) | 1320 | if (err) |
1321 | return err; | 1321 | return err; |
1322 | } | 1322 | } |
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 43f9d19a6f33..4d2f2157dd3f 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -283,7 +283,7 @@ static void ubifs_destroy_inode(struct inode *inode) | |||
283 | /* | 283 | /* |
284 | * Note, Linux write-back code calls this without 'i_mutex'. | 284 | * Note, Linux write-back code calls this without 'i_mutex'. |
285 | */ | 285 | */ |
286 | static int ubifs_write_inode(struct inode *inode, int wait) | 286 | static int ubifs_write_inode(struct inode *inode, struct writeback_control *wbc) |
287 | { | 287 | { |
288 | int err = 0; | 288 | int err = 0; |
289 | struct ubifs_info *c = inode->i_sb->s_fs_info; | 289 | struct ubifs_info *c = inode->i_sb->s_fs_info; |
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index e2ff180173a2..ccc3ad7242d4 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c | |||
@@ -551,7 +551,7 @@ static void udf_table_free_blocks(struct super_block *sb, | |||
551 | } | 551 | } |
552 | 552 | ||
553 | if (epos.offset + (2 * adsize) > sb->s_blocksize) { | 553 | if (epos.offset + (2 * adsize) > sb->s_blocksize) { |
554 | char *sptr, *dptr; | 554 | unsigned char *sptr, *dptr; |
555 | int loffset; | 555 | int loffset; |
556 | 556 | ||
557 | brelse(oepos.bh); | 557 | brelse(oepos.bh); |
diff --git a/fs/udf/dir.c b/fs/udf/dir.c index 61d9a76a3a69..f0f2a436251e 100644 --- a/fs/udf/dir.c +++ b/fs/udf/dir.c | |||
@@ -45,8 +45,8 @@ static int do_udf_readdir(struct inode *dir, struct file *filp, | |||
45 | int block, iblock; | 45 | int block, iblock; |
46 | loff_t nf_pos = (filp->f_pos - 1) << 2; | 46 | loff_t nf_pos = (filp->f_pos - 1) << 2; |
47 | int flen; | 47 | int flen; |
48 | char *fname = NULL; | 48 | unsigned char *fname = NULL; |
49 | char *nameptr; | 49 | unsigned char *nameptr; |
50 | uint16_t liu; | 50 | uint16_t liu; |
51 | uint8_t lfi; | 51 | uint8_t lfi; |
52 | loff_t size = udf_ext0_offset(dir) + dir->i_size; | 52 | loff_t size = udf_ext0_offset(dir) + dir->i_size; |
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index c7da1a32b364..b57ab0402d89 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
@@ -1379,12 +1379,12 @@ static mode_t udf_convert_permissions(struct fileEntry *fe) | |||
1379 | return mode; | 1379 | return mode; |
1380 | } | 1380 | } |
1381 | 1381 | ||
1382 | int udf_write_inode(struct inode *inode, int sync) | 1382 | int udf_write_inode(struct inode *inode, struct writeback_control *wbc) |
1383 | { | 1383 | { |
1384 | int ret; | 1384 | int ret; |
1385 | 1385 | ||
1386 | lock_kernel(); | 1386 | lock_kernel(); |
1387 | ret = udf_update_inode(inode, sync); | 1387 | ret = udf_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
1388 | unlock_kernel(); | 1388 | unlock_kernel(); |
1389 | 1389 | ||
1390 | return ret; | 1390 | return ret; |
@@ -1678,7 +1678,7 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos, | |||
1678 | return -1; | 1678 | return -1; |
1679 | 1679 | ||
1680 | if (epos->offset + (2 * adsize) > inode->i_sb->s_blocksize) { | 1680 | if (epos->offset + (2 * adsize) > inode->i_sb->s_blocksize) { |
1681 | char *sptr, *dptr; | 1681 | unsigned char *sptr, *dptr; |
1682 | struct buffer_head *nbh; | 1682 | struct buffer_head *nbh; |
1683 | int err, loffset; | 1683 | int err, loffset; |
1684 | struct kernel_lb_addr obloc = epos->block; | 1684 | struct kernel_lb_addr obloc = epos->block; |
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 96757e3e3e04..db423ab078b1 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c | |||
@@ -34,8 +34,8 @@ | |||
34 | #include <linux/crc-itu-t.h> | 34 | #include <linux/crc-itu-t.h> |
35 | #include <linux/exportfs.h> | 35 | #include <linux/exportfs.h> |
36 | 36 | ||
37 | static inline int udf_match(int len1, const char *name1, int len2, | 37 | static inline int udf_match(int len1, const unsigned char *name1, int len2, |
38 | const char *name2) | 38 | const unsigned char *name2) |
39 | { | 39 | { |
40 | if (len1 != len2) | 40 | if (len1 != len2) |
41 | return 0; | 41 | return 0; |
@@ -142,15 +142,15 @@ int udf_write_fi(struct inode *inode, struct fileIdentDesc *cfi, | |||
142 | } | 142 | } |
143 | 143 | ||
144 | static struct fileIdentDesc *udf_find_entry(struct inode *dir, | 144 | static struct fileIdentDesc *udf_find_entry(struct inode *dir, |
145 | struct qstr *child, | 145 | const struct qstr *child, |
146 | struct udf_fileident_bh *fibh, | 146 | struct udf_fileident_bh *fibh, |
147 | struct fileIdentDesc *cfi) | 147 | struct fileIdentDesc *cfi) |
148 | { | 148 | { |
149 | struct fileIdentDesc *fi = NULL; | 149 | struct fileIdentDesc *fi = NULL; |
150 | loff_t f_pos; | 150 | loff_t f_pos; |
151 | int block, flen; | 151 | int block, flen; |
152 | char *fname = NULL; | 152 | unsigned char *fname = NULL; |
153 | char *nameptr; | 153 | unsigned char *nameptr; |
154 | uint8_t lfi; | 154 | uint8_t lfi; |
155 | uint16_t liu; | 155 | uint16_t liu; |
156 | loff_t size; | 156 | loff_t size; |
@@ -308,7 +308,7 @@ static struct fileIdentDesc *udf_add_entry(struct inode *dir, | |||
308 | { | 308 | { |
309 | struct super_block *sb = dir->i_sb; | 309 | struct super_block *sb = dir->i_sb; |
310 | struct fileIdentDesc *fi = NULL; | 310 | struct fileIdentDesc *fi = NULL; |
311 | char *name = NULL; | 311 | unsigned char *name = NULL; |
312 | int namelen; | 312 | int namelen; |
313 | loff_t f_pos; | 313 | loff_t f_pos; |
314 | loff_t size = udf_ext0_offset(dir) + dir->i_size; | 314 | loff_t size = udf_ext0_offset(dir) + dir->i_size; |
@@ -895,16 +895,16 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
895 | { | 895 | { |
896 | struct inode *inode; | 896 | struct inode *inode; |
897 | struct pathComponent *pc; | 897 | struct pathComponent *pc; |
898 | char *compstart; | 898 | const char *compstart; |
899 | struct udf_fileident_bh fibh; | 899 | struct udf_fileident_bh fibh; |
900 | struct extent_position epos = {}; | 900 | struct extent_position epos = {}; |
901 | int eoffset, elen = 0; | 901 | int eoffset, elen = 0; |
902 | struct fileIdentDesc *fi; | 902 | struct fileIdentDesc *fi; |
903 | struct fileIdentDesc cfi; | 903 | struct fileIdentDesc cfi; |
904 | char *ea; | 904 | uint8_t *ea; |
905 | int err; | 905 | int err; |
906 | int block; | 906 | int block; |
907 | char *name = NULL; | 907 | unsigned char *name = NULL; |
908 | int namelen; | 908 | int namelen; |
909 | struct buffer_head *bh; | 909 | struct buffer_head *bh; |
910 | struct udf_inode_info *iinfo; | 910 | struct udf_inode_info *iinfo; |
@@ -982,7 +982,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
982 | 982 | ||
983 | pc = (struct pathComponent *)(ea + elen); | 983 | pc = (struct pathComponent *)(ea + elen); |
984 | 984 | ||
985 | compstart = (char *)symname; | 985 | compstart = symname; |
986 | 986 | ||
987 | do { | 987 | do { |
988 | symname++; | 988 | symname++; |
diff --git a/fs/udf/symlink.c b/fs/udf/symlink.c index c3265e1385d4..852e91845688 100644 --- a/fs/udf/symlink.c +++ b/fs/udf/symlink.c | |||
@@ -32,12 +32,12 @@ | |||
32 | #include <linux/buffer_head.h> | 32 | #include <linux/buffer_head.h> |
33 | #include "udf_i.h" | 33 | #include "udf_i.h" |
34 | 34 | ||
35 | static void udf_pc_to_char(struct super_block *sb, char *from, int fromlen, | 35 | static void udf_pc_to_char(struct super_block *sb, unsigned char *from, |
36 | char *to) | 36 | int fromlen, unsigned char *to) |
37 | { | 37 | { |
38 | struct pathComponent *pc; | 38 | struct pathComponent *pc; |
39 | int elen = 0; | 39 | int elen = 0; |
40 | char *p = to; | 40 | unsigned char *p = to; |
41 | 41 | ||
42 | while (elen < fromlen) { | 42 | while (elen < fromlen) { |
43 | pc = (struct pathComponent *)(from + elen); | 43 | pc = (struct pathComponent *)(from + elen); |
@@ -75,9 +75,9 @@ static int udf_symlink_filler(struct file *file, struct page *page) | |||
75 | { | 75 | { |
76 | struct inode *inode = page->mapping->host; | 76 | struct inode *inode = page->mapping->host; |
77 | struct buffer_head *bh = NULL; | 77 | struct buffer_head *bh = NULL; |
78 | char *symlink; | 78 | unsigned char *symlink; |
79 | int err = -EIO; | 79 | int err = -EIO; |
80 | char *p = kmap(page); | 80 | unsigned char *p = kmap(page); |
81 | struct udf_inode_info *iinfo; | 81 | struct udf_inode_info *iinfo; |
82 | 82 | ||
83 | lock_kernel(); | 83 | lock_kernel(); |
diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index 8d46f4294ee7..4223ac855da9 100644 --- a/fs/udf/udfdecl.h +++ b/fs/udf/udfdecl.h | |||
@@ -142,7 +142,7 @@ extern void udf_truncate(struct inode *); | |||
142 | extern void udf_read_inode(struct inode *); | 142 | extern void udf_read_inode(struct inode *); |
143 | extern void udf_delete_inode(struct inode *); | 143 | extern void udf_delete_inode(struct inode *); |
144 | extern void udf_clear_inode(struct inode *); | 144 | extern void udf_clear_inode(struct inode *); |
145 | extern int udf_write_inode(struct inode *, int); | 145 | extern int udf_write_inode(struct inode *, struct writeback_control *wbc); |
146 | extern long udf_block_map(struct inode *, sector_t); | 146 | extern long udf_block_map(struct inode *, sector_t); |
147 | extern int udf_extend_file(struct inode *, struct extent_position *, | 147 | extern int udf_extend_file(struct inode *, struct extent_position *, |
148 | struct kernel_long_ad *, sector_t); | 148 | struct kernel_long_ad *, sector_t); |
diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 22af68f8b682..317a0d444f6b 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c | |||
@@ -31,7 +31,7 @@ | |||
31 | * len <= UFS_MAXNAMLEN and de != NULL are guaranteed by caller. | 31 | * len <= UFS_MAXNAMLEN and de != NULL are guaranteed by caller. |
32 | */ | 32 | */ |
33 | static inline int ufs_match(struct super_block *sb, int len, | 33 | static inline int ufs_match(struct super_block *sb, int len, |
34 | const char * const name, struct ufs_dir_entry * de) | 34 | const unsigned char *name, struct ufs_dir_entry *de) |
35 | { | 35 | { |
36 | if (len != ufs_get_de_namlen(sb, de)) | 36 | if (len != ufs_get_de_namlen(sb, de)) |
37 | return 0; | 37 | return 0; |
@@ -70,7 +70,7 @@ static inline unsigned long ufs_dir_pages(struct inode *inode) | |||
70 | return (inode->i_size+PAGE_CACHE_SIZE-1)>>PAGE_CACHE_SHIFT; | 70 | return (inode->i_size+PAGE_CACHE_SIZE-1)>>PAGE_CACHE_SHIFT; |
71 | } | 71 | } |
72 | 72 | ||
73 | ino_t ufs_inode_by_name(struct inode *dir, struct qstr *qstr) | 73 | ino_t ufs_inode_by_name(struct inode *dir, const struct qstr *qstr) |
74 | { | 74 | { |
75 | ino_t res = 0; | 75 | ino_t res = 0; |
76 | struct ufs_dir_entry *de; | 76 | struct ufs_dir_entry *de; |
@@ -249,11 +249,11 @@ struct ufs_dir_entry *ufs_dotdot(struct inode *dir, struct page **p) | |||
249 | * (as a parameter - res_dir). Page is returned mapped and unlocked. | 249 | * (as a parameter - res_dir). Page is returned mapped and unlocked. |
250 | * Entry is guaranteed to be valid. | 250 | * Entry is guaranteed to be valid. |
251 | */ | 251 | */ |
252 | struct ufs_dir_entry *ufs_find_entry(struct inode *dir, struct qstr *qstr, | 252 | struct ufs_dir_entry *ufs_find_entry(struct inode *dir, const struct qstr *qstr, |
253 | struct page **res_page) | 253 | struct page **res_page) |
254 | { | 254 | { |
255 | struct super_block *sb = dir->i_sb; | 255 | struct super_block *sb = dir->i_sb; |
256 | const char *name = qstr->name; | 256 | const unsigned char *name = qstr->name; |
257 | int namelen = qstr->len; | 257 | int namelen = qstr->len; |
258 | unsigned reclen = UFS_DIR_REC_LEN(namelen); | 258 | unsigned reclen = UFS_DIR_REC_LEN(namelen); |
259 | unsigned long start, n; | 259 | unsigned long start, n; |
@@ -313,7 +313,7 @@ found: | |||
313 | int ufs_add_link(struct dentry *dentry, struct inode *inode) | 313 | int ufs_add_link(struct dentry *dentry, struct inode *inode) |
314 | { | 314 | { |
315 | struct inode *dir = dentry->d_parent->d_inode; | 315 | struct inode *dir = dentry->d_parent->d_inode; |
316 | const char *name = dentry->d_name.name; | 316 | const unsigned char *name = dentry->d_name.name; |
317 | int namelen = dentry->d_name.len; | 317 | int namelen = dentry->d_name.len; |
318 | struct super_block *sb = dir->i_sb; | 318 | struct super_block *sb = dir->i_sb; |
319 | unsigned reclen = UFS_DIR_REC_LEN(namelen); | 319 | unsigned reclen = UFS_DIR_REC_LEN(namelen); |
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index 09aef49beedb..80b68c3702d1 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c | |||
@@ -36,6 +36,7 @@ | |||
36 | #include <linux/mm.h> | 36 | #include <linux/mm.h> |
37 | #include <linux/smp_lock.h> | 37 | #include <linux/smp_lock.h> |
38 | #include <linux/buffer_head.h> | 38 | #include <linux/buffer_head.h> |
39 | #include <linux/writeback.h> | ||
39 | #include <linux/quotaops.h> | 40 | #include <linux/quotaops.h> |
40 | 41 | ||
41 | #include "ufs_fs.h" | 42 | #include "ufs_fs.h" |
@@ -891,11 +892,11 @@ static int ufs_update_inode(struct inode * inode, int do_sync) | |||
891 | return 0; | 892 | return 0; |
892 | } | 893 | } |
893 | 894 | ||
894 | int ufs_write_inode (struct inode * inode, int wait) | 895 | int ufs_write_inode(struct inode *inode, struct writeback_control *wbc) |
895 | { | 896 | { |
896 | int ret; | 897 | int ret; |
897 | lock_kernel(); | 898 | lock_kernel(); |
898 | ret = ufs_update_inode (inode, wait); | 899 | ret = ufs_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
899 | unlock_kernel(); | 900 | unlock_kernel(); |
900 | return ret; | 901 | return ret; |
901 | } | 902 | } |
diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h index 0b4c39bc0d9e..43f9f5d5670e 100644 --- a/fs/ufs/ufs.h +++ b/fs/ufs/ufs.h | |||
@@ -86,9 +86,9 @@ extern void ufs_put_cylinder (struct super_block *, unsigned); | |||
86 | /* dir.c */ | 86 | /* dir.c */ |
87 | extern const struct inode_operations ufs_dir_inode_operations; | 87 | extern const struct inode_operations ufs_dir_inode_operations; |
88 | extern int ufs_add_link (struct dentry *, struct inode *); | 88 | extern int ufs_add_link (struct dentry *, struct inode *); |
89 | extern ino_t ufs_inode_by_name(struct inode *, struct qstr *); | 89 | extern ino_t ufs_inode_by_name(struct inode *, const struct qstr *); |
90 | extern int ufs_make_empty(struct inode *, struct inode *); | 90 | extern int ufs_make_empty(struct inode *, struct inode *); |
91 | extern struct ufs_dir_entry *ufs_find_entry(struct inode *, struct qstr *, struct page **); | 91 | extern struct ufs_dir_entry *ufs_find_entry(struct inode *, const struct qstr *, struct page **); |
92 | extern int ufs_delete_entry(struct inode *, struct ufs_dir_entry *, struct page *); | 92 | extern int ufs_delete_entry(struct inode *, struct ufs_dir_entry *, struct page *); |
93 | extern int ufs_empty_dir (struct inode *); | 93 | extern int ufs_empty_dir (struct inode *); |
94 | extern struct ufs_dir_entry *ufs_dotdot(struct inode *, struct page **); | 94 | extern struct ufs_dir_entry *ufs_dotdot(struct inode *, struct page **); |
@@ -106,7 +106,7 @@ extern struct inode * ufs_new_inode (struct inode *, int); | |||
106 | 106 | ||
107 | /* inode.c */ | 107 | /* inode.c */ |
108 | extern struct inode *ufs_iget(struct super_block *, unsigned long); | 108 | extern struct inode *ufs_iget(struct super_block *, unsigned long); |
109 | extern int ufs_write_inode (struct inode *, int); | 109 | extern int ufs_write_inode (struct inode *, struct writeback_control *); |
110 | extern int ufs_sync_inode (struct inode *); | 110 | extern int ufs_sync_inode (struct inode *); |
111 | extern void ufs_delete_inode (struct inode *); | 111 | extern void ufs_delete_inode (struct inode *); |
112 | extern struct buffer_head * ufs_bread (struct inode *, unsigned, int, int *); | 112 | extern struct buffer_head * ufs_bread (struct inode *, unsigned, int, int *); |
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index 25ea2408118f..71345a370d9f 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c | |||
@@ -1063,7 +1063,7 @@ xfs_log_inode( | |||
1063 | STATIC int | 1063 | STATIC int |
1064 | xfs_fs_write_inode( | 1064 | xfs_fs_write_inode( |
1065 | struct inode *inode, | 1065 | struct inode *inode, |
1066 | int sync) | 1066 | struct writeback_control *wbc) |
1067 | { | 1067 | { |
1068 | struct xfs_inode *ip = XFS_I(inode); | 1068 | struct xfs_inode *ip = XFS_I(inode); |
1069 | struct xfs_mount *mp = ip->i_mount; | 1069 | struct xfs_mount *mp = ip->i_mount; |
@@ -1074,11 +1074,7 @@ xfs_fs_write_inode( | |||
1074 | if (XFS_FORCED_SHUTDOWN(mp)) | 1074 | if (XFS_FORCED_SHUTDOWN(mp)) |
1075 | return XFS_ERROR(EIO); | 1075 | return XFS_ERROR(EIO); |
1076 | 1076 | ||
1077 | if (sync) { | 1077 | if (wbc->sync_mode == WB_SYNC_ALL) { |
1078 | error = xfs_wait_on_pages(ip, 0, -1); | ||
1079 | if (error) | ||
1080 | goto out; | ||
1081 | |||
1082 | /* | 1078 | /* |
1083 | * Make sure the inode has hit stable storage. By using the | 1079 | * Make sure the inode has hit stable storage. By using the |
1084 | * log and the fsync transactions we reduce the IOs we have | 1080 | * log and the fsync transactions we reduce the IOs we have |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index 70504fcf14cd..14dafd608230 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -245,7 +245,7 @@ typedef struct xfs_mount { | |||
245 | struct xfs_qmops *m_qm_ops; /* vector of XQM ops */ | 245 | struct xfs_qmops *m_qm_ops; /* vector of XQM ops */ |
246 | atomic_t m_active_trans; /* number trans frozen */ | 246 | atomic_t m_active_trans; /* number trans frozen */ |
247 | #ifdef HAVE_PERCPU_SB | 247 | #ifdef HAVE_PERCPU_SB |
248 | xfs_icsb_cnts_t *m_sb_cnts; /* per-cpu superblock counters */ | 248 | xfs_icsb_cnts_t __percpu *m_sb_cnts; /* per-cpu superblock counters */ |
249 | unsigned long m_icsb_counters; /* disabled per-cpu counters */ | 249 | unsigned long m_icsb_counters; /* disabled per-cpu counters */ |
250 | struct notifier_block m_icsb_notifier; /* hotplug cpu notifier */ | 250 | struct notifier_block m_icsb_notifier; /* hotplug cpu notifier */ |
251 | struct mutex m_icsb_mutex; /* balancer sync lock */ | 251 | struct mutex m_icsb_mutex; /* balancer sync lock */ |