diff options
Diffstat (limited to 'fs')
320 files changed, 9672 insertions, 8855 deletions
diff --git a/fs/Kconfig b/fs/Kconfig index 64d44efad7a5..f8fccaaad628 100644 --- a/fs/Kconfig +++ b/fs/Kconfig | |||
| @@ -6,6 +6,10 @@ menu "File systems" | |||
| 6 | 6 | ||
| 7 | if BLOCK | 7 | if BLOCK |
| 8 | 8 | ||
| 9 | config FS_JOURNAL_INFO | ||
| 10 | bool | ||
| 11 | default n | ||
| 12 | |||
| 9 | source "fs/ext2/Kconfig" | 13 | source "fs/ext2/Kconfig" |
| 10 | source "fs/ext3/Kconfig" | 14 | source "fs/ext3/Kconfig" |
| 11 | source "fs/ext4/Kconfig" | 15 | source "fs/ext4/Kconfig" |
diff --git a/fs/afs/write.c b/fs/afs/write.c index c63a3c8beb73..5e15a21dbf9f 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c | |||
| @@ -671,7 +671,6 @@ ssize_t afs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
| 671 | struct afs_vnode *vnode = AFS_FS_I(dentry->d_inode); | 671 | struct afs_vnode *vnode = AFS_FS_I(dentry->d_inode); |
| 672 | ssize_t result; | 672 | ssize_t result; |
| 673 | size_t count = iov_length(iov, nr_segs); | 673 | size_t count = iov_length(iov, nr_segs); |
| 674 | int ret; | ||
| 675 | 674 | ||
| 676 | _enter("{%x.%u},{%zu},%lu,", | 675 | _enter("{%x.%u},{%zu},%lu,", |
| 677 | vnode->fid.vid, vnode->fid.vnode, count, nr_segs); | 676 | vnode->fid.vid, vnode->fid.vnode, count, nr_segs); |
| @@ -691,13 +690,6 @@ ssize_t afs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
| 691 | return result; | 690 | return result; |
| 692 | } | 691 | } |
| 693 | 692 | ||
| 694 | /* return error values for O_SYNC and IS_SYNC() */ | ||
| 695 | if (IS_SYNC(&vnode->vfs_inode) || iocb->ki_filp->f_flags & O_SYNC) { | ||
| 696 | ret = afs_fsync(iocb->ki_filp, dentry, 1); | ||
| 697 | if (ret < 0) | ||
| 698 | result = ret; | ||
| 699 | } | ||
| 700 | |||
| 701 | _leave(" = %zd", result); | 693 | _leave(" = %zd", result); |
| 702 | return result; | 694 | return result; |
| 703 | } | 695 | } |
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/aio_abi.h> | 15 | #include <linux/aio_abi.h> |
| 16 | #include <linux/module.h> | 16 | #include <linux/module.h> |
| 17 | #include <linux/syscalls.h> | 17 | #include <linux/syscalls.h> |
| 18 | #include <linux/backing-dev.h> | ||
| 18 | #include <linux/uio.h> | 19 | #include <linux/uio.h> |
| 19 | 20 | ||
| 20 | #define DEBUG 0 | 21 | #define DEBUG 0 |
| @@ -32,6 +33,9 @@ | |||
| 32 | #include <linux/workqueue.h> | 33 | #include <linux/workqueue.h> |
| 33 | #include <linux/security.h> | 34 | #include <linux/security.h> |
| 34 | #include <linux/eventfd.h> | 35 | #include <linux/eventfd.h> |
| 36 | #include <linux/blkdev.h> | ||
| 37 | #include <linux/mempool.h> | ||
| 38 | #include <linux/hash.h> | ||
| 35 | 39 | ||
| 36 | #include <asm/kmap_types.h> | 40 | #include <asm/kmap_types.h> |
| 37 | #include <asm/uaccess.h> | 41 | #include <asm/uaccess.h> |
| @@ -60,6 +64,14 @@ static DECLARE_WORK(fput_work, aio_fput_routine); | |||
| 60 | static DEFINE_SPINLOCK(fput_lock); | 64 | static DEFINE_SPINLOCK(fput_lock); |
| 61 | static LIST_HEAD(fput_head); | 65 | static LIST_HEAD(fput_head); |
| 62 | 66 | ||
| 67 | #define AIO_BATCH_HASH_BITS 3 /* allocated on-stack, so don't go crazy */ | ||
| 68 | #define AIO_BATCH_HASH_SIZE (1 << AIO_BATCH_HASH_BITS) | ||
| 69 | struct aio_batch_entry { | ||
| 70 | struct hlist_node list; | ||
| 71 | struct address_space *mapping; | ||
| 72 | }; | ||
| 73 | mempool_t *abe_pool; | ||
| 74 | |||
| 63 | static void aio_kick_handler(struct work_struct *); | 75 | static void aio_kick_handler(struct work_struct *); |
| 64 | static void aio_queue_work(struct kioctx *); | 76 | static void aio_queue_work(struct kioctx *); |
| 65 | 77 | ||
| @@ -73,6 +85,8 @@ static int __init aio_setup(void) | |||
| 73 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 85 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
| 74 | 86 | ||
| 75 | aio_wq = create_workqueue("aio"); | 87 | aio_wq = create_workqueue("aio"); |
| 88 | abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry)); | ||
| 89 | BUG_ON(!abe_pool); | ||
| 76 | 90 | ||
| 77 | pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page)); | 91 | pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page)); |
| 78 | 92 | ||
| @@ -1531,8 +1545,44 @@ static int aio_wake_function(wait_queue_t *wait, unsigned mode, | |||
| 1531 | return 1; | 1545 | return 1; |
| 1532 | } | 1546 | } |
| 1533 | 1547 | ||
| 1548 | static void aio_batch_add(struct address_space *mapping, | ||
| 1549 | struct hlist_head *batch_hash) | ||
| 1550 | { | ||
| 1551 | struct aio_batch_entry *abe; | ||
| 1552 | struct hlist_node *pos; | ||
| 1553 | unsigned bucket; | ||
| 1554 | |||
| 1555 | bucket = hash_ptr(mapping, AIO_BATCH_HASH_BITS); | ||
| 1556 | hlist_for_each_entry(abe, pos, &batch_hash[bucket], list) { | ||
| 1557 | if (abe->mapping == mapping) | ||
| 1558 | return; | ||
| 1559 | } | ||
| 1560 | |||
| 1561 | abe = mempool_alloc(abe_pool, GFP_KERNEL); | ||
| 1562 | BUG_ON(!igrab(mapping->host)); | ||
| 1563 | abe->mapping = mapping; | ||
| 1564 | hlist_add_head(&abe->list, &batch_hash[bucket]); | ||
| 1565 | return; | ||
| 1566 | } | ||
| 1567 | |||
| 1568 | static void aio_batch_free(struct hlist_head *batch_hash) | ||
| 1569 | { | ||
| 1570 | struct aio_batch_entry *abe; | ||
| 1571 | struct hlist_node *pos, *n; | ||
| 1572 | int i; | ||
| 1573 | |||
| 1574 | for (i = 0; i < AIO_BATCH_HASH_SIZE; i++) { | ||
| 1575 | hlist_for_each_entry_safe(abe, pos, n, &batch_hash[i], list) { | ||
| 1576 | blk_run_address_space(abe->mapping); | ||
| 1577 | iput(abe->mapping->host); | ||
| 1578 | hlist_del(&abe->list); | ||
| 1579 | mempool_free(abe, abe_pool); | ||
| 1580 | } | ||
| 1581 | } | ||
| 1582 | } | ||
| 1583 | |||
| 1534 | static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | 1584 | static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, |
| 1535 | struct iocb *iocb) | 1585 | struct iocb *iocb, struct hlist_head *batch_hash) |
| 1536 | { | 1586 | { |
| 1537 | struct kiocb *req; | 1587 | struct kiocb *req; |
| 1538 | struct file *file; | 1588 | struct file *file; |
| @@ -1608,6 +1658,12 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | |||
| 1608 | ; | 1658 | ; |
| 1609 | } | 1659 | } |
| 1610 | spin_unlock_irq(&ctx->ctx_lock); | 1660 | spin_unlock_irq(&ctx->ctx_lock); |
| 1661 | if (req->ki_opcode == IOCB_CMD_PREAD || | ||
| 1662 | req->ki_opcode == IOCB_CMD_PREADV || | ||
| 1663 | req->ki_opcode == IOCB_CMD_PWRITE || | ||
| 1664 | req->ki_opcode == IOCB_CMD_PWRITEV) | ||
| 1665 | aio_batch_add(file->f_mapping, batch_hash); | ||
| 1666 | |||
| 1611 | aio_put_req(req); /* drop extra ref to req */ | 1667 | aio_put_req(req); /* drop extra ref to req */ |
| 1612 | return 0; | 1668 | return 0; |
| 1613 | 1669 | ||
| @@ -1635,6 +1691,7 @@ SYSCALL_DEFINE3(io_submit, aio_context_t, ctx_id, long, nr, | |||
| 1635 | struct kioctx *ctx; | 1691 | struct kioctx *ctx; |
| 1636 | long ret = 0; | 1692 | long ret = 0; |
| 1637 | int i; | 1693 | int i; |
| 1694 | struct hlist_head batch_hash[AIO_BATCH_HASH_SIZE] = { { 0, }, }; | ||
| 1638 | 1695 | ||
| 1639 | if (unlikely(nr < 0)) | 1696 | if (unlikely(nr < 0)) |
| 1640 | return -EINVAL; | 1697 | return -EINVAL; |
| @@ -1666,10 +1723,11 @@ SYSCALL_DEFINE3(io_submit, aio_context_t, ctx_id, long, nr, | |||
| 1666 | break; | 1723 | break; |
| 1667 | } | 1724 | } |
| 1668 | 1725 | ||
| 1669 | ret = io_submit_one(ctx, user_iocb, &tmp); | 1726 | ret = io_submit_one(ctx, user_iocb, &tmp, batch_hash); |
| 1670 | if (ret) | 1727 | if (ret) |
| 1671 | break; | 1728 | break; |
| 1672 | } | 1729 | } |
| 1730 | aio_batch_free(batch_hash); | ||
| 1673 | 1731 | ||
| 1674 | put_ioctx(ctx); | 1732 | put_ioctx(ctx); |
| 1675 | return i ? i : ret; | 1733 | return i ? i : ret; |
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index b9b3bb51b1e4..d15ea1790bfb 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c | |||
| @@ -767,7 +767,7 @@ static int load_elf_binary(struct linux_binprm *bprm, struct pt_regs *regs) | |||
| 767 | 767 | ||
| 768 | current->mm->start_stack = bprm->p; | 768 | current->mm->start_stack = bprm->p; |
| 769 | 769 | ||
| 770 | /* Now we do a little grungy work by mmaping the ELF image into | 770 | /* Now we do a little grungy work by mmapping the ELF image into |
| 771 | the correct location in memory. */ | 771 | the correct location in memory. */ |
| 772 | for(i = 0, elf_ppnt = elf_phdata; | 772 | for(i = 0, elf_ppnt = elf_phdata; |
| 773 | i < loc->elf_ex.e_phnum; i++, elf_ppnt++) { | 773 | i < loc->elf_ex.e_phnum; i++, elf_ppnt++) { |
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 38502c67987c..79d2b1aa389f 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c | |||
| @@ -380,7 +380,8 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm, | |||
| 380 | down_write(¤t->mm->mmap_sem); | 380 | down_write(¤t->mm->mmap_sem); |
| 381 | current->mm->start_brk = do_mmap(NULL, 0, stack_size, | 381 | current->mm->start_brk = do_mmap(NULL, 0, stack_size, |
| 382 | PROT_READ | PROT_WRITE | PROT_EXEC, | 382 | PROT_READ | PROT_WRITE | PROT_EXEC, |
| 383 | MAP_PRIVATE | MAP_ANONYMOUS | MAP_GROWSDOWN, | 383 | MAP_PRIVATE | MAP_ANONYMOUS | |
| 384 | MAP_UNINITIALIZED | MAP_GROWSDOWN, | ||
| 384 | 0); | 385 | 0); |
| 385 | 386 | ||
| 386 | if (IS_ERR_VALUE(current->mm->start_brk)) { | 387 | if (IS_ERR_VALUE(current->mm->start_brk)) { |
| @@ -272,7 +272,7 @@ EXPORT_SYMBOL(bio_init); | |||
| 272 | * for a &struct bio to become free. If a %NULL @bs is passed in, we will | 272 | * for a &struct bio to become free. If a %NULL @bs is passed in, we will |
| 273 | * fall back to just using @kmalloc to allocate the required memory. | 273 | * fall back to just using @kmalloc to allocate the required memory. |
| 274 | * | 274 | * |
| 275 | * Note that the caller must set ->bi_destructor on succesful return | 275 | * Note that the caller must set ->bi_destructor on successful return |
| 276 | * of a bio, to do the appropriate freeing of the bio once the reference | 276 | * of a bio, to do the appropriate freeing of the bio once the reference |
| 277 | * count drops to zero. | 277 | * count drops to zero. |
| 278 | **/ | 278 | **/ |
| @@ -1393,6 +1393,18 @@ void bio_check_pages_dirty(struct bio *bio) | |||
| 1393 | } | 1393 | } |
| 1394 | } | 1394 | } |
| 1395 | 1395 | ||
| 1396 | #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE | ||
| 1397 | void bio_flush_dcache_pages(struct bio *bi) | ||
| 1398 | { | ||
| 1399 | int i; | ||
| 1400 | struct bio_vec *bvec; | ||
| 1401 | |||
| 1402 | bio_for_each_segment(bvec, bi, i) | ||
| 1403 | flush_dcache_page(bvec->bv_page); | ||
| 1404 | } | ||
| 1405 | EXPORT_SYMBOL(bio_flush_dcache_pages); | ||
| 1406 | #endif | ||
| 1407 | |||
| 1396 | /** | 1408 | /** |
| 1397 | * bio_endio - end I/O on a bio | 1409 | * bio_endio - end I/O on a bio |
| 1398 | * @bio: bio | 1410 | * @bio: bio |
diff --git a/fs/block_dev.c b/fs/block_dev.c index 8bed0557d88c..73d6a735b8f3 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
| @@ -405,7 +405,17 @@ static loff_t block_llseek(struct file *file, loff_t offset, int origin) | |||
| 405 | 405 | ||
| 406 | static int block_fsync(struct file *filp, struct dentry *dentry, int datasync) | 406 | static int block_fsync(struct file *filp, struct dentry *dentry, int datasync) |
| 407 | { | 407 | { |
| 408 | return sync_blockdev(I_BDEV(filp->f_mapping->host)); | 408 | struct block_device *bdev = I_BDEV(filp->f_mapping->host); |
| 409 | int error; | ||
| 410 | |||
| 411 | error = sync_blockdev(bdev); | ||
| 412 | if (error) | ||
| 413 | return error; | ||
| 414 | |||
| 415 | error = blkdev_issue_flush(bdev, NULL); | ||
| 416 | if (error == -EOPNOTSUPP) | ||
| 417 | error = 0; | ||
| 418 | return error; | ||
| 409 | } | 419 | } |
| 410 | 420 | ||
| 411 | /* | 421 | /* |
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig index 7bb3c020e570..402afe0a0bfb 100644 --- a/fs/btrfs/Kconfig +++ b/fs/btrfs/Kconfig | |||
| @@ -4,6 +4,7 @@ config BTRFS_FS | |||
| 4 | select LIBCRC32C | 4 | select LIBCRC32C |
| 5 | select ZLIB_INFLATE | 5 | select ZLIB_INFLATE |
| 6 | select ZLIB_DEFLATE | 6 | select ZLIB_DEFLATE |
| 7 | select FS_JOURNAL_INFO | ||
| 7 | help | 8 | help |
| 8 | Btrfs is a new filesystem with extents, writable snapshotting, | 9 | Btrfs is a new filesystem with extents, writable snapshotting, |
| 9 | support for multiple devices and many more features. | 10 | support for multiple devices and many more features. |
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index ccbdcb54ec5d..46bea0f4dc7b 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c | |||
| @@ -256,7 +256,7 @@ out: | |||
| 256 | * Insert @em into @tree or perform a simple forward/backward merge with | 256 | * Insert @em into @tree or perform a simple forward/backward merge with |
| 257 | * existing mappings. The extent_map struct passed in will be inserted | 257 | * existing mappings. The extent_map struct passed in will be inserted |
| 258 | * into the tree directly, with an additional reference taken, or a | 258 | * into the tree directly, with an additional reference taken, or a |
| 259 | * reference dropped if the merge attempt was sucessfull. | 259 | * reference dropped if the merge attempt was successfull. |
| 260 | */ | 260 | */ |
| 261 | int add_extent_mapping(struct extent_map_tree *tree, | 261 | int add_extent_mapping(struct extent_map_tree *tree, |
| 262 | struct extent_map *em) | 262 | struct extent_map *em) |
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 06550affbd27..77f759302e12 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
| @@ -909,7 +909,7 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf, | |||
| 909 | unsigned long last_index; | 909 | unsigned long last_index; |
| 910 | int will_write; | 910 | int will_write; |
| 911 | 911 | ||
| 912 | will_write = ((file->f_flags & O_SYNC) || IS_SYNC(inode) || | 912 | will_write = ((file->f_flags & O_DSYNC) || IS_SYNC(inode) || |
| 913 | (file->f_flags & O_DIRECT)); | 913 | (file->f_flags & O_DIRECT)); |
| 914 | 914 | ||
| 915 | nrptrs = min((count + PAGE_CACHE_SIZE - 1) / PAGE_CACHE_SIZE, | 915 | nrptrs = min((count + PAGE_CACHE_SIZE - 1) / PAGE_CACHE_SIZE, |
| @@ -1076,7 +1076,7 @@ out_nolock: | |||
| 1076 | if (err) | 1076 | if (err) |
| 1077 | num_written = err; | 1077 | num_written = err; |
| 1078 | 1078 | ||
| 1079 | if ((file->f_flags & O_SYNC) || IS_SYNC(inode)) { | 1079 | if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) { |
| 1080 | trans = btrfs_start_transaction(root, 1); | 1080 | trans = btrfs_start_transaction(root, 1); |
| 1081 | ret = btrfs_log_dentry_safe(trans, root, | 1081 | ret = btrfs_log_dentry_safe(trans, root, |
| 1082 | file->f_dentry); | 1082 | file->f_dentry); |
diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c index 4618516dd994..c2413561ea75 100644 --- a/fs/cachefiles/daemon.c +++ b/fs/cachefiles/daemon.c | |||
| @@ -21,6 +21,7 @@ | |||
| 21 | #include <linux/mount.h> | 21 | #include <linux/mount.h> |
| 22 | #include <linux/statfs.h> | 22 | #include <linux/statfs.h> |
| 23 | #include <linux/ctype.h> | 23 | #include <linux/ctype.h> |
| 24 | #include <linux/string.h> | ||
| 24 | #include <linux/fs_struct.h> | 25 | #include <linux/fs_struct.h> |
| 25 | #include "internal.h" | 26 | #include "internal.h" |
| 26 | 27 | ||
| @@ -257,8 +258,7 @@ static ssize_t cachefiles_daemon_write(struct file *file, | |||
| 257 | if (args == data) | 258 | if (args == data) |
| 258 | goto error; | 259 | goto error; |
| 259 | *args = '\0'; | 260 | *args = '\0'; |
| 260 | for (args++; isspace(*args); args++) | 261 | args = skip_spaces(++args); |
| 261 | continue; | ||
| 262 | } | 262 | } |
| 263 | 263 | ||
| 264 | /* run the appropriate command handler */ | 264 | /* run the appropriate command handler */ |
diff --git a/fs/cifs/README b/fs/cifs/README index 79c1a93400be..a727b7cb075f 100644 --- a/fs/cifs/README +++ b/fs/cifs/README | |||
| @@ -423,7 +423,7 @@ A partial list of the supported mount options follows: | |||
| 423 | source name to use to represent the client netbios machine | 423 | source name to use to represent the client netbios machine |
| 424 | name when doing the RFC1001 netbios session initialize. | 424 | name when doing the RFC1001 netbios session initialize. |
| 425 | direct Do not do inode data caching on files opened on this mount. | 425 | direct Do not do inode data caching on files opened on this mount. |
| 426 | This precludes mmaping files on this mount. In some cases | 426 | This precludes mmapping files on this mount. In some cases |
| 427 | with fast networks and little or no caching benefits on the | 427 | with fast networks and little or no caching benefits on the |
| 428 | client (e.g. when the application is doing large sequential | 428 | client (e.g. when the application is doing large sequential |
| 429 | reads bigger than page size without rereading the same data) | 429 | reads bigger than page size without rereading the same data) |
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index 5d0fde18039c..4b35f7ec0583 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
| @@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | /* | 40 | /* |
| 41 | * MAX_REQ is the maximum number of requests that WE will send | 41 | * MAX_REQ is the maximum number of requests that WE will send |
| 42 | * on one socket concurently. It also matches the most common | 42 | * on one socket concurrently. It also matches the most common |
| 43 | * value of max multiplex returned by servers. We may | 43 | * value of max multiplex returned by servers. We may |
| 44 | * eventually want to use the negotiated value (in case | 44 | * eventually want to use the negotiated value (in case |
| 45 | * future servers can handle more) when we are more confident that | 45 | * future servers can handle more) when we are more confident that |
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index 2d07f890a842..3877737f96a6 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h | |||
| @@ -1227,7 +1227,7 @@ typedef struct smb_com_setattr_rsp { | |||
| 1227 | /* empty wct response to setattr */ | 1227 | /* empty wct response to setattr */ |
| 1228 | 1228 | ||
| 1229 | /*******************************************************/ | 1229 | /*******************************************************/ |
| 1230 | /* NT Transact structure defintions follow */ | 1230 | /* NT Transact structure definitions follow */ |
| 1231 | /* Currently only ioctl, acl (get security descriptor) */ | 1231 | /* Currently only ioctl, acl (get security descriptor) */ |
| 1232 | /* and notify are implemented */ | 1232 | /* and notify are implemented */ |
| 1233 | /*******************************************************/ | 1233 | /*******************************************************/ |
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 1f42f772865a..6ccf7262d1b7 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
| @@ -214,7 +214,8 @@ int cifs_posix_open(char *full_path, struct inode **pinode, | |||
| 214 | posix_flags |= SMB_O_EXCL; | 214 | posix_flags |= SMB_O_EXCL; |
| 215 | if (oflags & O_TRUNC) | 215 | if (oflags & O_TRUNC) |
| 216 | posix_flags |= SMB_O_TRUNC; | 216 | posix_flags |= SMB_O_TRUNC; |
| 217 | if (oflags & O_SYNC) | 217 | /* be safe and imply O_SYNC for O_DSYNC */ |
| 218 | if (oflags & O_DSYNC) | ||
| 218 | posix_flags |= SMB_O_SYNC; | 219 | posix_flags |= SMB_O_SYNC; |
| 219 | if (oflags & O_DIRECTORY) | 220 | if (oflags & O_DIRECTORY) |
| 220 | posix_flags |= SMB_O_DIRECTORY; | 221 | posix_flags |= SMB_O_DIRECTORY; |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 429337eb7afe..057e1dae12ab 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
| @@ -76,8 +76,10 @@ static inline fmode_t cifs_posix_convert_flags(unsigned int flags) | |||
| 76 | reopening a file. They had their effect on the original open */ | 76 | reopening a file. They had their effect on the original open */ |
| 77 | if (flags & O_APPEND) | 77 | if (flags & O_APPEND) |
| 78 | posix_flags |= (fmode_t)O_APPEND; | 78 | posix_flags |= (fmode_t)O_APPEND; |
| 79 | if (flags & O_SYNC) | 79 | if (flags & O_DSYNC) |
| 80 | posix_flags |= (fmode_t)O_SYNC; | 80 | posix_flags |= (fmode_t)O_DSYNC; |
| 81 | if (flags & __O_SYNC) | ||
| 82 | posix_flags |= (fmode_t)__O_SYNC; | ||
| 81 | if (flags & O_DIRECTORY) | 83 | if (flags & O_DIRECTORY) |
| 82 | posix_flags |= (fmode_t)O_DIRECTORY; | 84 | posix_flags |= (fmode_t)O_DIRECTORY; |
| 83 | if (flags & O_NOFOLLOW) | 85 | if (flags & O_NOFOLLOW) |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index cababd8a52df..cf18ee765590 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
| @@ -914,8 +914,8 @@ undo_setattr: | |||
| 914 | /* | 914 | /* |
| 915 | * If dentry->d_inode is null (usually meaning the cached dentry | 915 | * If dentry->d_inode is null (usually meaning the cached dentry |
| 916 | * is a negative dentry) then we would attempt a standard SMB delete, but | 916 | * is a negative dentry) then we would attempt a standard SMB delete, but |
| 917 | * if that fails we can not attempt the fall back mechanisms on EACESS | 917 | * if that fails we can not attempt the fall back mechanisms on EACCESS |
| 918 | * but will return the EACESS to the caller. Note that the VFS does not call | 918 | * but will return the EACCESS to the caller. Note that the VFS does not call |
| 919 | * unlink on negative dentries currently. | 919 | * unlink on negative dentries currently. |
| 920 | */ | 920 | */ |
| 921 | int cifs_unlink(struct inode *dir, struct dentry *dentry) | 921 | int cifs_unlink(struct inode *dir, struct dentry *dentry) |
diff --git a/fs/cifs/smbdes.c b/fs/cifs/smbdes.c index 224a1f478966..b6b6dcb500bf 100644 --- a/fs/cifs/smbdes.c +++ b/fs/cifs/smbdes.c | |||
| @@ -371,7 +371,7 @@ E_P24(unsigned char *p21, const unsigned char *c8, unsigned char *p24) | |||
| 371 | smbhash(p24 + 16, c8, p21 + 14, 1); | 371 | smbhash(p24 + 16, c8, p21 + 14, 1); |
| 372 | } | 372 | } |
| 373 | 373 | ||
| 374 | #if 0 /* currently unsued */ | 374 | #if 0 /* currently unused */ |
| 375 | static void | 375 | static void |
| 376 | D_P16(unsigned char *p14, unsigned char *in, unsigned char *out) | 376 | D_P16(unsigned char *p14, unsigned char *in, unsigned char *out) |
| 377 | { | 377 | { |
diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index 43c96ce29614..c6405ce3c50e 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c | |||
| @@ -17,28 +17,25 @@ static struct ctl_table_header *fs_table_header; | |||
| 17 | 17 | ||
| 18 | static ctl_table coda_table[] = { | 18 | static ctl_table coda_table[] = { |
| 19 | { | 19 | { |
| 20 | .ctl_name = CTL_UNNUMBERED, | ||
| 21 | .procname = "timeout", | 20 | .procname = "timeout", |
| 22 | .data = &coda_timeout, | 21 | .data = &coda_timeout, |
| 23 | .maxlen = sizeof(int), | 22 | .maxlen = sizeof(int), |
| 24 | .mode = 0644, | 23 | .mode = 0644, |
| 25 | .proc_handler = &proc_dointvec | 24 | .proc_handler = proc_dointvec |
| 26 | }, | 25 | }, |
| 27 | { | 26 | { |
| 28 | .ctl_name = CTL_UNNUMBERED, | ||
| 29 | .procname = "hard", | 27 | .procname = "hard", |
| 30 | .data = &coda_hard, | 28 | .data = &coda_hard, |
| 31 | .maxlen = sizeof(int), | 29 | .maxlen = sizeof(int), |
| 32 | .mode = 0644, | 30 | .mode = 0644, |
| 33 | .proc_handler = &proc_dointvec | 31 | .proc_handler = proc_dointvec |
| 34 | }, | 32 | }, |
| 35 | { | 33 | { |
| 36 | .ctl_name = CTL_UNNUMBERED, | ||
| 37 | .procname = "fake_statfs", | 34 | .procname = "fake_statfs", |
| 38 | .data = &coda_fake_statfs, | 35 | .data = &coda_fake_statfs, |
| 39 | .maxlen = sizeof(int), | 36 | .maxlen = sizeof(int), |
| 40 | .mode = 0600, | 37 | .mode = 0600, |
| 41 | .proc_handler = &proc_dointvec | 38 | .proc_handler = proc_dointvec |
| 42 | }, | 39 | }, |
| 43 | {} | 40 | {} |
| 44 | }; | 41 | }; |
| @@ -46,7 +43,6 @@ static ctl_table coda_table[] = { | |||
| 46 | #ifdef CONFIG_SYSCTL | 43 | #ifdef CONFIG_SYSCTL |
| 47 | static ctl_table fs_table[] = { | 44 | static ctl_table fs_table[] = { |
| 48 | { | 45 | { |
| 49 | .ctl_name = CTL_UNNUMBERED, | ||
| 50 | .procname = "coda", | 46 | .procname = "coda", |
| 51 | .mode = 0555, | 47 | .mode = 0555, |
| 52 | .child = coda_table | 48 | .child = coda_table |
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index d84e7058c298..14cbc831422a 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c | |||
| @@ -111,43 +111,40 @@ | |||
| 111 | #include <linux/dvb/frontend.h> | 111 | #include <linux/dvb/frontend.h> |
| 112 | #include <linux/dvb/video.h> | 112 | #include <linux/dvb/video.h> |
| 113 | 113 | ||
| 114 | #include <linux/sort.h> | ||
| 115 | |||
| 114 | #ifdef CONFIG_SPARC | 116 | #ifdef CONFIG_SPARC |
| 115 | #include <asm/fbio.h> | 117 | #include <asm/fbio.h> |
| 116 | #endif | 118 | #endif |
| 117 | 119 | ||
| 118 | static int do_ioctl32_pointer(unsigned int fd, unsigned int cmd, | 120 | static int w_long(unsigned int fd, unsigned int cmd, |
| 119 | unsigned long arg, struct file *f) | 121 | compat_ulong_t __user *argp) |
| 120 | { | ||
| 121 | return sys_ioctl(fd, cmd, (unsigned long)compat_ptr(arg)); | ||
| 122 | } | ||
| 123 | |||
| 124 | static int w_long(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 125 | { | 122 | { |
| 126 | mm_segment_t old_fs = get_fs(); | 123 | mm_segment_t old_fs = get_fs(); |
| 127 | int err; | 124 | int err; |
| 128 | unsigned long val; | 125 | unsigned long val; |
| 129 | 126 | ||
| 130 | set_fs (KERNEL_DS); | 127 | set_fs (KERNEL_DS); |
| 131 | err = sys_ioctl(fd, cmd, (unsigned long)&val); | 128 | err = sys_ioctl(fd, cmd, (unsigned long)&val); |
| 132 | set_fs (old_fs); | 129 | set_fs (old_fs); |
| 133 | if (!err && put_user(val, (u32 __user *)compat_ptr(arg))) | 130 | if (!err && put_user(val, argp)) |
| 134 | return -EFAULT; | 131 | return -EFAULT; |
| 135 | return err; | 132 | return err; |
| 136 | } | 133 | } |
| 137 | 134 | ||
| 138 | static int rw_long(unsigned int fd, unsigned int cmd, unsigned long arg) | 135 | static int rw_long(unsigned int fd, unsigned int cmd, |
| 136 | compat_ulong_t __user *argp) | ||
| 139 | { | 137 | { |
| 140 | mm_segment_t old_fs = get_fs(); | 138 | mm_segment_t old_fs = get_fs(); |
| 141 | u32 __user *argptr = compat_ptr(arg); | ||
| 142 | int err; | 139 | int err; |
| 143 | unsigned long val; | 140 | unsigned long val; |
| 144 | 141 | ||
| 145 | if(get_user(val, argptr)) | 142 | if(get_user(val, argp)) |
| 146 | return -EFAULT; | 143 | return -EFAULT; |
| 147 | set_fs (KERNEL_DS); | 144 | set_fs (KERNEL_DS); |
| 148 | err = sys_ioctl(fd, cmd, (unsigned long)&val); | 145 | err = sys_ioctl(fd, cmd, (unsigned long)&val); |
| 149 | set_fs (old_fs); | 146 | set_fs (old_fs); |
| 150 | if (!err && put_user(val, argptr)) | 147 | if (!err && put_user(val, argp)) |
| 151 | return -EFAULT; | 148 | return -EFAULT; |
| 152 | return err; | 149 | return err; |
| 153 | } | 150 | } |
| @@ -161,7 +158,8 @@ struct compat_video_event { | |||
| 161 | } u; | 158 | } u; |
| 162 | }; | 159 | }; |
| 163 | 160 | ||
| 164 | static int do_video_get_event(unsigned int fd, unsigned int cmd, unsigned long arg) | 161 | static int do_video_get_event(unsigned int fd, unsigned int cmd, |
| 162 | struct compat_video_event __user *up) | ||
| 165 | { | 163 | { |
| 166 | struct video_event kevent; | 164 | struct video_event kevent; |
| 167 | mm_segment_t old_fs = get_fs(); | 165 | mm_segment_t old_fs = get_fs(); |
| @@ -172,8 +170,6 @@ static int do_video_get_event(unsigned int fd, unsigned int cmd, unsigned long a | |||
| 172 | set_fs(old_fs); | 170 | set_fs(old_fs); |
| 173 | 171 | ||
| 174 | if (!err) { | 172 | if (!err) { |
| 175 | struct compat_video_event __user *up = compat_ptr(arg); | ||
| 176 | |||
| 177 | err = put_user(kevent.type, &up->type); | 173 | err = put_user(kevent.type, &up->type); |
| 178 | err |= put_user(kevent.timestamp, &up->timestamp); | 174 | err |= put_user(kevent.timestamp, &up->timestamp); |
| 179 | err |= put_user(kevent.u.size.w, &up->u.size.w); | 175 | err |= put_user(kevent.u.size.w, &up->u.size.w); |
| @@ -192,15 +188,14 @@ struct compat_video_still_picture { | |||
| 192 | int32_t size; | 188 | int32_t size; |
| 193 | }; | 189 | }; |
| 194 | 190 | ||
| 195 | static int do_video_stillpicture(unsigned int fd, unsigned int cmd, unsigned long arg) | 191 | static int do_video_stillpicture(unsigned int fd, unsigned int cmd, |
| 192 | struct compat_video_still_picture __user *up) | ||
| 196 | { | 193 | { |
| 197 | struct compat_video_still_picture __user *up; | ||
| 198 | struct video_still_picture __user *up_native; | 194 | struct video_still_picture __user *up_native; |
| 199 | compat_uptr_t fp; | 195 | compat_uptr_t fp; |
| 200 | int32_t size; | 196 | int32_t size; |
| 201 | int err; | 197 | int err; |
| 202 | 198 | ||
| 203 | up = (struct compat_video_still_picture __user *) arg; | ||
| 204 | err = get_user(fp, &up->iFrame); | 199 | err = get_user(fp, &up->iFrame); |
| 205 | err |= get_user(size, &up->size); | 200 | err |= get_user(size, &up->size); |
| 206 | if (err) | 201 | if (err) |
| @@ -224,14 +219,13 @@ struct compat_video_spu_palette { | |||
| 224 | compat_uptr_t palette; | 219 | compat_uptr_t palette; |
| 225 | }; | 220 | }; |
| 226 | 221 | ||
| 227 | static int do_video_set_spu_palette(unsigned int fd, unsigned int cmd, unsigned long arg) | 222 | static int do_video_set_spu_palette(unsigned int fd, unsigned int cmd, |
| 223 | struct compat_video_spu_palette __user *up) | ||
| 228 | { | 224 | { |
| 229 | struct compat_video_spu_palette __user *up; | ||
| 230 | struct video_spu_palette __user *up_native; | 225 | struct video_spu_palette __user *up_native; |
| 231 | compat_uptr_t palp; | 226 | compat_uptr_t palp; |
| 232 | int length, err; | 227 | int length, err; |
| 233 | 228 | ||
| 234 | up = (struct compat_video_spu_palette __user *) arg; | ||
| 235 | err = get_user(palp, &up->palette); | 229 | err = get_user(palp, &up->palette); |
| 236 | err |= get_user(length, &up->length); | 230 | err |= get_user(length, &up->length); |
| 237 | 231 | ||
| @@ -246,428 +240,6 @@ static int do_video_set_spu_palette(unsigned int fd, unsigned int cmd, unsigned | |||
| 246 | return err; | 240 | return err; |
| 247 | } | 241 | } |
| 248 | 242 | ||
| 249 | #ifdef CONFIG_NET | ||
| 250 | static int do_siocgstamp(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 251 | { | ||
| 252 | struct compat_timeval __user *up = compat_ptr(arg); | ||
| 253 | struct timeval ktv; | ||
| 254 | mm_segment_t old_fs = get_fs(); | ||
| 255 | int err; | ||
| 256 | |||
| 257 | set_fs(KERNEL_DS); | ||
| 258 | err = sys_ioctl(fd, cmd, (unsigned long)&ktv); | ||
| 259 | set_fs(old_fs); | ||
| 260 | if(!err) { | ||
| 261 | err = put_user(ktv.tv_sec, &up->tv_sec); | ||
| 262 | err |= __put_user(ktv.tv_usec, &up->tv_usec); | ||
| 263 | } | ||
| 264 | return err; | ||
| 265 | } | ||
| 266 | |||
| 267 | static int do_siocgstampns(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 268 | { | ||
| 269 | struct compat_timespec __user *up = compat_ptr(arg); | ||
| 270 | struct timespec kts; | ||
| 271 | mm_segment_t old_fs = get_fs(); | ||
| 272 | int err; | ||
| 273 | |||
| 274 | set_fs(KERNEL_DS); | ||
| 275 | err = sys_ioctl(fd, cmd, (unsigned long)&kts); | ||
| 276 | set_fs(old_fs); | ||
| 277 | if (!err) { | ||
| 278 | err = put_user(kts.tv_sec, &up->tv_sec); | ||
| 279 | err |= __put_user(kts.tv_nsec, &up->tv_nsec); | ||
| 280 | } | ||
| 281 | return err; | ||
| 282 | } | ||
| 283 | |||
| 284 | struct ifmap32 { | ||
| 285 | compat_ulong_t mem_start; | ||
| 286 | compat_ulong_t mem_end; | ||
| 287 | unsigned short base_addr; | ||
| 288 | unsigned char irq; | ||
| 289 | unsigned char dma; | ||
| 290 | unsigned char port; | ||
| 291 | }; | ||
| 292 | |||
| 293 | struct ifreq32 { | ||
| 294 | #define IFHWADDRLEN 6 | ||
| 295 | #define IFNAMSIZ 16 | ||
| 296 | union { | ||
| 297 | char ifrn_name[IFNAMSIZ]; /* if name, e.g. "en0" */ | ||
| 298 | } ifr_ifrn; | ||
| 299 | union { | ||
| 300 | struct sockaddr ifru_addr; | ||
| 301 | struct sockaddr ifru_dstaddr; | ||
| 302 | struct sockaddr ifru_broadaddr; | ||
| 303 | struct sockaddr ifru_netmask; | ||
| 304 | struct sockaddr ifru_hwaddr; | ||
| 305 | short ifru_flags; | ||
| 306 | compat_int_t ifru_ivalue; | ||
| 307 | compat_int_t ifru_mtu; | ||
| 308 | struct ifmap32 ifru_map; | ||
| 309 | char ifru_slave[IFNAMSIZ]; /* Just fits the size */ | ||
| 310 | char ifru_newname[IFNAMSIZ]; | ||
| 311 | compat_caddr_t ifru_data; | ||
| 312 | /* XXXX? ifru_settings should be here */ | ||
| 313 | } ifr_ifru; | ||
| 314 | }; | ||
| 315 | |||
| 316 | struct ifconf32 { | ||
| 317 | compat_int_t ifc_len; /* size of buffer */ | ||
| 318 | compat_caddr_t ifcbuf; | ||
| 319 | }; | ||
| 320 | |||
| 321 | static int dev_ifname32(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 322 | { | ||
| 323 | struct ifreq __user *uifr; | ||
| 324 | int err; | ||
| 325 | |||
| 326 | uifr = compat_alloc_user_space(sizeof(struct ifreq)); | ||
| 327 | if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))) | ||
| 328 | return -EFAULT; | ||
| 329 | |||
| 330 | err = sys_ioctl(fd, SIOCGIFNAME, (unsigned long)uifr); | ||
| 331 | if (err) | ||
| 332 | return err; | ||
| 333 | |||
| 334 | if (copy_in_user(compat_ptr(arg), uifr, sizeof(struct ifreq32))) | ||
| 335 | return -EFAULT; | ||
| 336 | |||
| 337 | return 0; | ||
| 338 | } | ||
| 339 | |||
| 340 | static int dev_ifconf(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 341 | { | ||
| 342 | struct ifconf32 ifc32; | ||
| 343 | struct ifconf ifc; | ||
| 344 | struct ifconf __user *uifc; | ||
| 345 | struct ifreq32 __user *ifr32; | ||
| 346 | struct ifreq __user *ifr; | ||
| 347 | unsigned int i, j; | ||
| 348 | int err; | ||
| 349 | |||
| 350 | if (copy_from_user(&ifc32, compat_ptr(arg), sizeof(struct ifconf32))) | ||
| 351 | return -EFAULT; | ||
| 352 | |||
| 353 | if (ifc32.ifcbuf == 0) { | ||
| 354 | ifc32.ifc_len = 0; | ||
| 355 | ifc.ifc_len = 0; | ||
| 356 | ifc.ifc_req = NULL; | ||
| 357 | uifc = compat_alloc_user_space(sizeof(struct ifconf)); | ||
| 358 | } else { | ||
| 359 | size_t len =((ifc32.ifc_len / sizeof (struct ifreq32)) + 1) * | ||
| 360 | sizeof (struct ifreq); | ||
| 361 | uifc = compat_alloc_user_space(sizeof(struct ifconf) + len); | ||
| 362 | ifc.ifc_len = len; | ||
| 363 | ifr = ifc.ifc_req = (void __user *)(uifc + 1); | ||
| 364 | ifr32 = compat_ptr(ifc32.ifcbuf); | ||
| 365 | for (i = 0; i < ifc32.ifc_len; i += sizeof (struct ifreq32)) { | ||
| 366 | if (copy_in_user(ifr, ifr32, sizeof(struct ifreq32))) | ||
| 367 | return -EFAULT; | ||
| 368 | ifr++; | ||
| 369 | ifr32++; | ||
| 370 | } | ||
| 371 | } | ||
| 372 | if (copy_to_user(uifc, &ifc, sizeof(struct ifconf))) | ||
| 373 | return -EFAULT; | ||
| 374 | |||
| 375 | err = sys_ioctl (fd, SIOCGIFCONF, (unsigned long)uifc); | ||
| 376 | if (err) | ||
| 377 | return err; | ||
| 378 | |||
| 379 | if (copy_from_user(&ifc, uifc, sizeof(struct ifconf))) | ||
| 380 | return -EFAULT; | ||
| 381 | |||
| 382 | ifr = ifc.ifc_req; | ||
| 383 | ifr32 = compat_ptr(ifc32.ifcbuf); | ||
| 384 | for (i = 0, j = 0; | ||
| 385 | i + sizeof (struct ifreq32) <= ifc32.ifc_len && j < ifc.ifc_len; | ||
| 386 | i += sizeof (struct ifreq32), j += sizeof (struct ifreq)) { | ||
| 387 | if (copy_in_user(ifr32, ifr, sizeof (struct ifreq32))) | ||
| 388 | return -EFAULT; | ||
| 389 | ifr32++; | ||
| 390 | ifr++; | ||
| 391 | } | ||
| 392 | |||
| 393 | if (ifc32.ifcbuf == 0) { | ||
| 394 | /* Translate from 64-bit structure multiple to | ||
| 395 | * a 32-bit one. | ||
| 396 | */ | ||
| 397 | i = ifc.ifc_len; | ||
| 398 | i = ((i / sizeof(struct ifreq)) * sizeof(struct ifreq32)); | ||
| 399 | ifc32.ifc_len = i; | ||
| 400 | } else { | ||
| 401 | ifc32.ifc_len = i; | ||
| 402 | } | ||
| 403 | if (copy_to_user(compat_ptr(arg), &ifc32, sizeof(struct ifconf32))) | ||
| 404 | return -EFAULT; | ||
| 405 | |||
| 406 | return 0; | ||
| 407 | } | ||
| 408 | |||
| 409 | static int ethtool_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 410 | { | ||
| 411 | struct ifreq __user *ifr; | ||
| 412 | struct ifreq32 __user *ifr32; | ||
| 413 | u32 data; | ||
| 414 | void __user *datap; | ||
| 415 | |||
| 416 | ifr = compat_alloc_user_space(sizeof(*ifr)); | ||
| 417 | ifr32 = compat_ptr(arg); | ||
| 418 | |||
| 419 | if (copy_in_user(&ifr->ifr_name, &ifr32->ifr_name, IFNAMSIZ)) | ||
| 420 | return -EFAULT; | ||
| 421 | |||
| 422 | if (get_user(data, &ifr32->ifr_ifru.ifru_data)) | ||
| 423 | return -EFAULT; | ||
| 424 | |||
| 425 | datap = compat_ptr(data); | ||
| 426 | if (put_user(datap, &ifr->ifr_ifru.ifru_data)) | ||
| 427 | return -EFAULT; | ||
| 428 | |||
| 429 | return sys_ioctl(fd, cmd, (unsigned long) ifr); | ||
| 430 | } | ||
| 431 | |||
| 432 | static int bond_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 433 | { | ||
| 434 | struct ifreq kifr; | ||
| 435 | struct ifreq __user *uifr; | ||
| 436 | struct ifreq32 __user *ifr32 = compat_ptr(arg); | ||
| 437 | mm_segment_t old_fs; | ||
| 438 | int err; | ||
| 439 | u32 data; | ||
| 440 | void __user *datap; | ||
| 441 | |||
| 442 | switch (cmd) { | ||
| 443 | case SIOCBONDENSLAVE: | ||
| 444 | case SIOCBONDRELEASE: | ||
| 445 | case SIOCBONDSETHWADDR: | ||
| 446 | case SIOCBONDCHANGEACTIVE: | ||
| 447 | if (copy_from_user(&kifr, ifr32, sizeof(struct ifreq32))) | ||
| 448 | return -EFAULT; | ||
| 449 | |||
| 450 | old_fs = get_fs(); | ||
| 451 | set_fs (KERNEL_DS); | ||
| 452 | err = sys_ioctl (fd, cmd, (unsigned long)&kifr); | ||
| 453 | set_fs (old_fs); | ||
| 454 | |||
| 455 | return err; | ||
| 456 | case SIOCBONDSLAVEINFOQUERY: | ||
| 457 | case SIOCBONDINFOQUERY: | ||
| 458 | uifr = compat_alloc_user_space(sizeof(*uifr)); | ||
| 459 | if (copy_in_user(&uifr->ifr_name, &ifr32->ifr_name, IFNAMSIZ)) | ||
| 460 | return -EFAULT; | ||
| 461 | |||
| 462 | if (get_user(data, &ifr32->ifr_ifru.ifru_data)) | ||
| 463 | return -EFAULT; | ||
| 464 | |||
| 465 | datap = compat_ptr(data); | ||
| 466 | if (put_user(datap, &uifr->ifr_ifru.ifru_data)) | ||
| 467 | return -EFAULT; | ||
| 468 | |||
| 469 | return sys_ioctl (fd, cmd, (unsigned long)uifr); | ||
| 470 | default: | ||
| 471 | return -EINVAL; | ||
| 472 | }; | ||
| 473 | } | ||
| 474 | |||
| 475 | static int siocdevprivate_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 476 | { | ||
| 477 | struct ifreq __user *u_ifreq64; | ||
| 478 | struct ifreq32 __user *u_ifreq32 = compat_ptr(arg); | ||
| 479 | char tmp_buf[IFNAMSIZ]; | ||
| 480 | void __user *data64; | ||
| 481 | u32 data32; | ||
| 482 | |||
| 483 | if (copy_from_user(&tmp_buf[0], &(u_ifreq32->ifr_ifrn.ifrn_name[0]), | ||
| 484 | IFNAMSIZ)) | ||
| 485 | return -EFAULT; | ||
| 486 | if (__get_user(data32, &u_ifreq32->ifr_ifru.ifru_data)) | ||
| 487 | return -EFAULT; | ||
| 488 | data64 = compat_ptr(data32); | ||
| 489 | |||
| 490 | u_ifreq64 = compat_alloc_user_space(sizeof(*u_ifreq64)); | ||
| 491 | |||
| 492 | /* Don't check these user accesses, just let that get trapped | ||
| 493 | * in the ioctl handler instead. | ||
| 494 | */ | ||
| 495 | if (copy_to_user(&u_ifreq64->ifr_ifrn.ifrn_name[0], &tmp_buf[0], | ||
| 496 | IFNAMSIZ)) | ||
| 497 | return -EFAULT; | ||
| 498 | if (__put_user(data64, &u_ifreq64->ifr_ifru.ifru_data)) | ||
| 499 | return -EFAULT; | ||
| 500 | |||
| 501 | return sys_ioctl(fd, cmd, (unsigned long) u_ifreq64); | ||
| 502 | } | ||
| 503 | |||
| 504 | static int dev_ifsioc(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 505 | { | ||
| 506 | struct ifreq ifr; | ||
| 507 | struct ifreq32 __user *uifr32; | ||
| 508 | struct ifmap32 __user *uifmap32; | ||
| 509 | mm_segment_t old_fs; | ||
| 510 | int err; | ||
| 511 | |||
| 512 | uifr32 = compat_ptr(arg); | ||
| 513 | uifmap32 = &uifr32->ifr_ifru.ifru_map; | ||
| 514 | switch (cmd) { | ||
| 515 | case SIOCSIFMAP: | ||
| 516 | err = copy_from_user(&ifr, uifr32, sizeof(ifr.ifr_name)); | ||
| 517 | err |= __get_user(ifr.ifr_map.mem_start, &uifmap32->mem_start); | ||
| 518 | err |= __get_user(ifr.ifr_map.mem_end, &uifmap32->mem_end); | ||
| 519 | err |= __get_user(ifr.ifr_map.base_addr, &uifmap32->base_addr); | ||
| 520 | err |= __get_user(ifr.ifr_map.irq, &uifmap32->irq); | ||
| 521 | err |= __get_user(ifr.ifr_map.dma, &uifmap32->dma); | ||
| 522 | err |= __get_user(ifr.ifr_map.port, &uifmap32->port); | ||
| 523 | if (err) | ||
| 524 | return -EFAULT; | ||
| 525 | break; | ||
| 526 | case SIOCSHWTSTAMP: | ||
| 527 | if (copy_from_user(&ifr, uifr32, sizeof(*uifr32))) | ||
| 528 | return -EFAULT; | ||
| 529 | ifr.ifr_data = compat_ptr(uifr32->ifr_ifru.ifru_data); | ||
| 530 | break; | ||
| 531 | default: | ||
| 532 | if (copy_from_user(&ifr, uifr32, sizeof(*uifr32))) | ||
| 533 | return -EFAULT; | ||
| 534 | break; | ||
| 535 | } | ||
| 536 | old_fs = get_fs(); | ||
| 537 | set_fs (KERNEL_DS); | ||
| 538 | err = sys_ioctl (fd, cmd, (unsigned long)&ifr); | ||
| 539 | set_fs (old_fs); | ||
| 540 | if (!err) { | ||
| 541 | switch (cmd) { | ||
| 542 | /* TUNSETIFF is defined as _IOW, it should be _IORW | ||
| 543 | * as the data is copied back to user space, but that | ||
| 544 | * cannot be fixed without breaking all existing apps. | ||
| 545 | */ | ||
| 546 | case TUNSETIFF: | ||
| 547 | case TUNGETIFF: | ||
| 548 | case SIOCGIFFLAGS: | ||
| 549 | case SIOCGIFMETRIC: | ||
| 550 | case SIOCGIFMTU: | ||
| 551 | case SIOCGIFMEM: | ||
| 552 | case SIOCGIFHWADDR: | ||
| 553 | case SIOCGIFINDEX: | ||
| 554 | case SIOCGIFADDR: | ||
| 555 | case SIOCGIFBRDADDR: | ||
| 556 | case SIOCGIFDSTADDR: | ||
| 557 | case SIOCGIFNETMASK: | ||
| 558 | case SIOCGIFTXQLEN: | ||
| 559 | if (copy_to_user(uifr32, &ifr, sizeof(*uifr32))) | ||
| 560 | return -EFAULT; | ||
| 561 | break; | ||
| 562 | case SIOCGIFMAP: | ||
| 563 | err = copy_to_user(uifr32, &ifr, sizeof(ifr.ifr_name)); | ||
| 564 | err |= __put_user(ifr.ifr_map.mem_start, &uifmap32->mem_start); | ||
| 565 | err |= __put_user(ifr.ifr_map.mem_end, &uifmap32->mem_end); | ||
| 566 | err |= __put_user(ifr.ifr_map.base_addr, &uifmap32->base_addr); | ||
| 567 | err |= __put_user(ifr.ifr_map.irq, &uifmap32->irq); | ||
| 568 | err |= __put_user(ifr.ifr_map.dma, &uifmap32->dma); | ||
| 569 | err |= __put_user(ifr.ifr_map.port, &uifmap32->port); | ||
| 570 | if (err) | ||
| 571 | err = -EFAULT; | ||
| 572 | break; | ||
| 573 | } | ||
| 574 | } | ||
| 575 | return err; | ||
| 576 | } | ||
| 577 | |||
| 578 | struct rtentry32 { | ||
| 579 | u32 rt_pad1; | ||
| 580 | struct sockaddr rt_dst; /* target address */ | ||
| 581 | struct sockaddr rt_gateway; /* gateway addr (RTF_GATEWAY) */ | ||
| 582 | struct sockaddr rt_genmask; /* target network mask (IP) */ | ||
| 583 | unsigned short rt_flags; | ||
| 584 | short rt_pad2; | ||
| 585 | u32 rt_pad3; | ||
| 586 | unsigned char rt_tos; | ||
| 587 | unsigned char rt_class; | ||
| 588 | short rt_pad4; | ||
| 589 | short rt_metric; /* +1 for binary compatibility! */ | ||
| 590 | /* char * */ u32 rt_dev; /* forcing the device at add */ | ||
| 591 | u32 rt_mtu; /* per route MTU/Window */ | ||
| 592 | u32 rt_window; /* Window clamping */ | ||
| 593 | unsigned short rt_irtt; /* Initial RTT */ | ||
| 594 | |||
| 595 | }; | ||
| 596 | |||
| 597 | struct in6_rtmsg32 { | ||
| 598 | struct in6_addr rtmsg_dst; | ||
| 599 | struct in6_addr rtmsg_src; | ||
| 600 | struct in6_addr rtmsg_gateway; | ||
| 601 | u32 rtmsg_type; | ||
| 602 | u16 rtmsg_dst_len; | ||
| 603 | u16 rtmsg_src_len; | ||
| 604 | u32 rtmsg_metric; | ||
| 605 | u32 rtmsg_info; | ||
| 606 | u32 rtmsg_flags; | ||
| 607 | s32 rtmsg_ifindex; | ||
| 608 | }; | ||
| 609 | |||
| 610 | static int routing_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 611 | { | ||
| 612 | int ret; | ||
| 613 | void *r = NULL; | ||
| 614 | struct in6_rtmsg r6; | ||
| 615 | struct rtentry r4; | ||
| 616 | char devname[16]; | ||
| 617 | u32 rtdev; | ||
| 618 | mm_segment_t old_fs = get_fs(); | ||
| 619 | |||
| 620 | struct socket *mysock = sockfd_lookup(fd, &ret); | ||
| 621 | |||
| 622 | if (mysock && mysock->sk && mysock->sk->sk_family == AF_INET6) { /* ipv6 */ | ||
| 623 | struct in6_rtmsg32 __user *ur6 = compat_ptr(arg); | ||
| 624 | ret = copy_from_user (&r6.rtmsg_dst, &(ur6->rtmsg_dst), | ||
| 625 | 3 * sizeof(struct in6_addr)); | ||
| 626 | ret |= __get_user (r6.rtmsg_type, &(ur6->rtmsg_type)); | ||
| 627 | ret |= __get_user (r6.rtmsg_dst_len, &(ur6->rtmsg_dst_len)); | ||
| 628 | ret |= __get_user (r6.rtmsg_src_len, &(ur6->rtmsg_src_len)); | ||
| 629 | ret |= __get_user (r6.rtmsg_metric, &(ur6->rtmsg_metric)); | ||
| 630 | ret |= __get_user (r6.rtmsg_info, &(ur6->rtmsg_info)); | ||
| 631 | ret |= __get_user (r6.rtmsg_flags, &(ur6->rtmsg_flags)); | ||
| 632 | ret |= __get_user (r6.rtmsg_ifindex, &(ur6->rtmsg_ifindex)); | ||
| 633 | |||
| 634 | r = (void *) &r6; | ||
| 635 | } else { /* ipv4 */ | ||
| 636 | struct rtentry32 __user *ur4 = compat_ptr(arg); | ||
| 637 | ret = copy_from_user (&r4.rt_dst, &(ur4->rt_dst), | ||
| 638 | 3 * sizeof(struct sockaddr)); | ||
| 639 | ret |= __get_user (r4.rt_flags, &(ur4->rt_flags)); | ||
| 640 | ret |= __get_user (r4.rt_metric, &(ur4->rt_metric)); | ||
| 641 | ret |= __get_user (r4.rt_mtu, &(ur4->rt_mtu)); | ||
| 642 | ret |= __get_user (r4.rt_window, &(ur4->rt_window)); | ||
| 643 | ret |= __get_user (r4.rt_irtt, &(ur4->rt_irtt)); | ||
| 644 | ret |= __get_user (rtdev, &(ur4->rt_dev)); | ||
| 645 | if (rtdev) { | ||
| 646 | ret |= copy_from_user (devname, compat_ptr(rtdev), 15); | ||
| 647 | r4.rt_dev = devname; devname[15] = 0; | ||
| 648 | } else | ||
| 649 | r4.rt_dev = NULL; | ||
| 650 | |||
| 651 | r = (void *) &r4; | ||
| 652 | } | ||
| 653 | |||
| 654 | if (ret) { | ||
| 655 | ret = -EFAULT; | ||
| 656 | goto out; | ||
| 657 | } | ||
| 658 | |||
| 659 | set_fs (KERNEL_DS); | ||
| 660 | ret = sys_ioctl (fd, cmd, (unsigned long) r); | ||
| 661 | set_fs (old_fs); | ||
| 662 | |||
| 663 | out: | ||
| 664 | if (mysock) | ||
| 665 | sockfd_put(mysock); | ||
| 666 | |||
| 667 | return ret; | ||
| 668 | } | ||
| 669 | #endif | ||
| 670 | |||
| 671 | #ifdef CONFIG_BLOCK | 243 | #ifdef CONFIG_BLOCK |
| 672 | typedef struct sg_io_hdr32 { | 244 | typedef struct sg_io_hdr32 { |
| 673 | compat_int_t interface_id; /* [i] 'S' for SCSI generic (required) */ | 245 | compat_int_t interface_id; /* [i] 'S' for SCSI generic (required) */ |
| @@ -721,16 +293,15 @@ static int sg_build_iovec(sg_io_hdr_t __user *sgio, void __user *dxferp, u16 iov | |||
| 721 | return 0; | 293 | return 0; |
| 722 | } | 294 | } |
| 723 | 295 | ||
| 724 | static int sg_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | 296 | static int sg_ioctl_trans(unsigned int fd, unsigned int cmd, |
| 297 | sg_io_hdr32_t __user *sgio32) | ||
| 725 | { | 298 | { |
| 726 | sg_io_hdr_t __user *sgio; | 299 | sg_io_hdr_t __user *sgio; |
| 727 | sg_io_hdr32_t __user *sgio32; | ||
| 728 | u16 iovec_count; | 300 | u16 iovec_count; |
| 729 | u32 data; | 301 | u32 data; |
| 730 | void __user *dxferp; | 302 | void __user *dxferp; |
| 731 | int err; | 303 | int err; |
| 732 | 304 | ||
| 733 | sgio32 = compat_ptr(arg); | ||
| 734 | if (get_user(iovec_count, &sgio32->iovec_count)) | 305 | if (get_user(iovec_count, &sgio32->iovec_count)) |
| 735 | return -EFAULT; | 306 | return -EFAULT; |
| 736 | 307 | ||
| @@ -820,11 +391,11 @@ struct compat_sg_req_info { /* used by SG_GET_REQUEST_TABLE ioctl() */ | |||
| 820 | int unused; | 391 | int unused; |
| 821 | }; | 392 | }; |
| 822 | 393 | ||
| 823 | static int sg_grt_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | 394 | static int sg_grt_trans(unsigned int fd, unsigned int cmd, struct |
| 395 | compat_sg_req_info __user *o) | ||
| 824 | { | 396 | { |
| 825 | int err, i; | 397 | int err, i; |
| 826 | sg_req_info_t __user *r; | 398 | sg_req_info_t __user *r; |
| 827 | struct compat_sg_req_info __user *o = (void __user *)arg; | ||
| 828 | r = compat_alloc_user_space(sizeof(sg_req_info_t)*SG_MAX_QUEUE); | 399 | r = compat_alloc_user_space(sizeof(sg_req_info_t)*SG_MAX_QUEUE); |
| 829 | err = sys_ioctl(fd,cmd,(unsigned long)r); | 400 | err = sys_ioctl(fd,cmd,(unsigned long)r); |
| 830 | if (err < 0) | 401 | if (err < 0) |
| @@ -852,9 +423,9 @@ struct sock_fprog32 { | |||
| 852 | #define PPPIOCSPASS32 _IOW('t', 71, struct sock_fprog32) | 423 | #define PPPIOCSPASS32 _IOW('t', 71, struct sock_fprog32) |
| 853 | #define PPPIOCSACTIVE32 _IOW('t', 70, struct sock_fprog32) | 424 | #define PPPIOCSACTIVE32 _IOW('t', 70, struct sock_fprog32) |
| 854 | 425 | ||
| 855 | static int ppp_sock_fprog_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | 426 | static int ppp_sock_fprog_ioctl_trans(unsigned int fd, unsigned int cmd, |
| 427 | struct sock_fprog32 __user *u_fprog32) | ||
| 856 | { | 428 | { |
| 857 | struct sock_fprog32 __user *u_fprog32 = compat_ptr(arg); | ||
| 858 | struct sock_fprog __user *u_fprog64 = compat_alloc_user_space(sizeof(struct sock_fprog)); | 429 | struct sock_fprog __user *u_fprog64 = compat_alloc_user_space(sizeof(struct sock_fprog)); |
| 859 | void __user *fptr64; | 430 | void __user *fptr64; |
| 860 | u32 fptr32; | 431 | u32 fptr32; |
| @@ -891,15 +462,14 @@ struct ppp_idle32 { | |||
| 891 | }; | 462 | }; |
| 892 | #define PPPIOCGIDLE32 _IOR('t', 63, struct ppp_idle32) | 463 | #define PPPIOCGIDLE32 _IOR('t', 63, struct ppp_idle32) |
| 893 | 464 | ||
| 894 | static int ppp_gidle(unsigned int fd, unsigned int cmd, unsigned long arg) | 465 | static int ppp_gidle(unsigned int fd, unsigned int cmd, |
| 466 | struct ppp_idle32 __user *idle32) | ||
| 895 | { | 467 | { |
| 896 | struct ppp_idle __user *idle; | 468 | struct ppp_idle __user *idle; |
| 897 | struct ppp_idle32 __user *idle32; | ||
| 898 | __kernel_time_t xmit, recv; | 469 | __kernel_time_t xmit, recv; |
| 899 | int err; | 470 | int err; |
| 900 | 471 | ||
| 901 | idle = compat_alloc_user_space(sizeof(*idle)); | 472 | idle = compat_alloc_user_space(sizeof(*idle)); |
| 902 | idle32 = compat_ptr(arg); | ||
| 903 | 473 | ||
| 904 | err = sys_ioctl(fd, PPPIOCGIDLE, (unsigned long) idle); | 474 | err = sys_ioctl(fd, PPPIOCGIDLE, (unsigned long) idle); |
| 905 | 475 | ||
| @@ -913,15 +483,14 @@ static int ppp_gidle(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
| 913 | return err; | 483 | return err; |
| 914 | } | 484 | } |
| 915 | 485 | ||
| 916 | static int ppp_scompress(unsigned int fd, unsigned int cmd, unsigned long arg) | 486 | static int ppp_scompress(unsigned int fd, unsigned int cmd, |
| 487 | struct ppp_option_data32 __user *odata32) | ||
| 917 | { | 488 | { |
| 918 | struct ppp_option_data __user *odata; | 489 | struct ppp_option_data __user *odata; |
| 919 | struct ppp_option_data32 __user *odata32; | ||
| 920 | __u32 data; | 490 | __u32 data; |
| 921 | void __user *datap; | 491 | void __user *datap; |
| 922 | 492 | ||
| 923 | odata = compat_alloc_user_space(sizeof(*odata)); | 493 | odata = compat_alloc_user_space(sizeof(*odata)); |
| 924 | odata32 = compat_ptr(arg); | ||
| 925 | 494 | ||
| 926 | if (get_user(data, &odata32->ptr)) | 495 | if (get_user(data, &odata32->ptr)) |
| 927 | return -EFAULT; | 496 | return -EFAULT; |
| @@ -937,35 +506,6 @@ static int ppp_scompress(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
| 937 | return sys_ioctl(fd, PPPIOCSCOMPRESS, (unsigned long) odata); | 506 | return sys_ioctl(fd, PPPIOCSCOMPRESS, (unsigned long) odata); |
| 938 | } | 507 | } |
| 939 | 508 | ||
| 940 | static int ppp_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 941 | { | ||
| 942 | int err; | ||
| 943 | |||
| 944 | switch (cmd) { | ||
| 945 | case PPPIOCGIDLE32: | ||
| 946 | err = ppp_gidle(fd, cmd, arg); | ||
| 947 | break; | ||
| 948 | |||
| 949 | case PPPIOCSCOMPRESS32: | ||
| 950 | err = ppp_scompress(fd, cmd, arg); | ||
| 951 | break; | ||
| 952 | |||
| 953 | default: | ||
| 954 | do { | ||
| 955 | static int count; | ||
| 956 | if (++count <= 20) | ||
| 957 | printk("ppp_ioctl: Unknown cmd fd(%d) " | ||
| 958 | "cmd(%08x) arg(%08x)\n", | ||
| 959 | (int)fd, (unsigned int)cmd, (unsigned int)arg); | ||
| 960 | } while(0); | ||
| 961 | err = -EINVAL; | ||
| 962 | break; | ||
| 963 | }; | ||
| 964 | |||
| 965 | return err; | ||
| 966 | } | ||
| 967 | |||
| 968 | |||
| 969 | #ifdef CONFIG_BLOCK | 509 | #ifdef CONFIG_BLOCK |
| 970 | struct mtget32 { | 510 | struct mtget32 { |
| 971 | compat_long_t mt_type; | 511 | compat_long_t mt_type; |
| @@ -983,7 +523,7 @@ struct mtpos32 { | |||
| 983 | }; | 523 | }; |
| 984 | #define MTIOCPOS32 _IOR('m', 3, struct mtpos32) | 524 | #define MTIOCPOS32 _IOR('m', 3, struct mtpos32) |
| 985 | 525 | ||
| 986 | static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | 526 | static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, void __user *argp) |
| 987 | { | 527 | { |
| 988 | mm_segment_t old_fs = get_fs(); | 528 | mm_segment_t old_fs = get_fs(); |
| 989 | struct mtget get; | 529 | struct mtget get; |
| @@ -1003,15 +543,6 @@ static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
| 1003 | kcmd = MTIOCGET; | 543 | kcmd = MTIOCGET; |
| 1004 | karg = &get; | 544 | karg = &get; |
| 1005 | break; | 545 | break; |
| 1006 | default: | ||
| 1007 | do { | ||
| 1008 | static int count; | ||
| 1009 | if (++count <= 20) | ||
| 1010 | printk("mt_ioctl: Unknown cmd fd(%d) " | ||
| 1011 | "cmd(%08x) arg(%08x)\n", | ||
| 1012 | (int)fd, (unsigned int)cmd, (unsigned int)arg); | ||
| 1013 | } while(0); | ||
| 1014 | return -EINVAL; | ||
| 1015 | } | 546 | } |
| 1016 | set_fs (KERNEL_DS); | 547 | set_fs (KERNEL_DS); |
| 1017 | err = sys_ioctl (fd, kcmd, (unsigned long)karg); | 548 | err = sys_ioctl (fd, kcmd, (unsigned long)karg); |
| @@ -1020,11 +551,11 @@ static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
| 1020 | return err; | 551 | return err; |
| 1021 | switch (cmd) { | 552 | switch (cmd) { |
| 1022 | case MTIOCPOS32: | 553 | case MTIOCPOS32: |
| 1023 | upos32 = compat_ptr(arg); | 554 | upos32 = argp; |
| 1024 | err = __put_user(pos.mt_blkno, &upos32->mt_blkno); | 555 | err = __put_user(pos.mt_blkno, &upos32->mt_blkno); |
| 1025 | break; | 556 | break; |
| 1026 | case MTIOCGET32: | 557 | case MTIOCGET32: |
| 1027 | umget32 = compat_ptr(arg); | 558 | umget32 = argp; |
| 1028 | err = __put_user(get.mt_type, &umget32->mt_type); | 559 | err = __put_user(get.mt_type, &umget32->mt_type); |
| 1029 | err |= __put_user(get.mt_resid, &umget32->mt_resid); | 560 | err |= __put_user(get.mt_resid, &umget32->mt_resid); |
| 1030 | err |= __put_user(get.mt_dsreg, &umget32->mt_dsreg); | 561 | err |= __put_user(get.mt_dsreg, &umget32->mt_dsreg); |
| @@ -1039,162 +570,8 @@ static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | |||
| 1039 | 570 | ||
| 1040 | #endif /* CONFIG_BLOCK */ | 571 | #endif /* CONFIG_BLOCK */ |
| 1041 | 572 | ||
| 1042 | #ifdef CONFIG_VT | 573 | static int do_smb_getmountuid(unsigned int fd, unsigned int cmd, |
| 1043 | 574 | compat_uid_t __user *argp) | |
| 1044 | static int vt_check(struct file *file) | ||
| 1045 | { | ||
| 1046 | struct tty_struct *tty; | ||
| 1047 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 1048 | struct vc_data *vc; | ||
| 1049 | |||
| 1050 | if (file->f_op->unlocked_ioctl != tty_ioctl) | ||
| 1051 | return -EINVAL; | ||
| 1052 | |||
| 1053 | tty = (struct tty_struct *)file->private_data; | ||
| 1054 | if (tty_paranoia_check(tty, inode, "tty_ioctl")) | ||
| 1055 | return -EINVAL; | ||
| 1056 | |||
| 1057 | if (tty->ops->ioctl != vt_ioctl) | ||
| 1058 | return -EINVAL; | ||
| 1059 | |||
| 1060 | vc = (struct vc_data *)tty->driver_data; | ||
| 1061 | if (!vc_cons_allocated(vc->vc_num)) /* impossible? */ | ||
| 1062 | return -ENOIOCTLCMD; | ||
| 1063 | |||
| 1064 | /* | ||
| 1065 | * To have permissions to do most of the vt ioctls, we either have | ||
| 1066 | * to be the owner of the tty, or have CAP_SYS_TTY_CONFIG. | ||
| 1067 | */ | ||
| 1068 | if (current->signal->tty == tty || capable(CAP_SYS_TTY_CONFIG)) | ||
| 1069 | return 1; | ||
| 1070 | return 0; | ||
| 1071 | } | ||
| 1072 | |||
| 1073 | struct consolefontdesc32 { | ||
| 1074 | unsigned short charcount; /* characters in font (256 or 512) */ | ||
| 1075 | unsigned short charheight; /* scan lines per character (1-32) */ | ||
| 1076 | compat_caddr_t chardata; /* font data in expanded form */ | ||
| 1077 | }; | ||
| 1078 | |||
| 1079 | static int do_fontx_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg, struct file *file) | ||
| 1080 | { | ||
| 1081 | struct consolefontdesc32 __user *user_cfd = compat_ptr(arg); | ||
| 1082 | struct console_font_op op; | ||
| 1083 | compat_caddr_t data; | ||
| 1084 | int i, perm; | ||
| 1085 | |||
| 1086 | perm = vt_check(file); | ||
| 1087 | if (perm < 0) return perm; | ||
| 1088 | |||
| 1089 | switch (cmd) { | ||
| 1090 | case PIO_FONTX: | ||
| 1091 | if (!perm) | ||
| 1092 | return -EPERM; | ||
| 1093 | op.op = KD_FONT_OP_SET; | ||
| 1094 | op.flags = 0; | ||
| 1095 | op.width = 8; | ||
| 1096 | if (get_user(op.height, &user_cfd->charheight) || | ||
| 1097 | get_user(op.charcount, &user_cfd->charcount) || | ||
| 1098 | get_user(data, &user_cfd->chardata)) | ||
| 1099 | return -EFAULT; | ||
| 1100 | op.data = compat_ptr(data); | ||
| 1101 | return con_font_op(vc_cons[fg_console].d, &op); | ||
| 1102 | case GIO_FONTX: | ||
| 1103 | op.op = KD_FONT_OP_GET; | ||
| 1104 | op.flags = 0; | ||
| 1105 | op.width = 8; | ||
| 1106 | if (get_user(op.height, &user_cfd->charheight) || | ||
| 1107 | get_user(op.charcount, &user_cfd->charcount) || | ||
| 1108 | get_user(data, &user_cfd->chardata)) | ||
| 1109 | return -EFAULT; | ||
| 1110 | if (!data) | ||
| 1111 | return 0; | ||
| 1112 | op.data = compat_ptr(data); | ||
| 1113 | i = con_font_op(vc_cons[fg_console].d, &op); | ||
| 1114 | if (i) | ||
| 1115 | return i; | ||
| 1116 | if (put_user(op.height, &user_cfd->charheight) || | ||
| 1117 | put_user(op.charcount, &user_cfd->charcount) || | ||
| 1118 | put_user((compat_caddr_t)(unsigned long)op.data, | ||
| 1119 | &user_cfd->chardata)) | ||
| 1120 | return -EFAULT; | ||
| 1121 | return 0; | ||
| 1122 | } | ||
| 1123 | return -EINVAL; | ||
| 1124 | } | ||
| 1125 | |||
| 1126 | struct console_font_op32 { | ||
| 1127 | compat_uint_t op; /* operation code KD_FONT_OP_* */ | ||
| 1128 | compat_uint_t flags; /* KD_FONT_FLAG_* */ | ||
| 1129 | compat_uint_t width, height; /* font size */ | ||
| 1130 | compat_uint_t charcount; | ||
| 1131 | compat_caddr_t data; /* font data with height fixed to 32 */ | ||
| 1132 | }; | ||
| 1133 | |||
| 1134 | static int do_kdfontop_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg, struct file *file) | ||
| 1135 | { | ||
| 1136 | struct console_font_op op; | ||
| 1137 | struct console_font_op32 __user *fontop = compat_ptr(arg); | ||
| 1138 | int perm = vt_check(file), i; | ||
| 1139 | struct vc_data *vc; | ||
| 1140 | |||
| 1141 | if (perm < 0) return perm; | ||
| 1142 | |||
| 1143 | if (copy_from_user(&op, fontop, sizeof(struct console_font_op32))) | ||
| 1144 | return -EFAULT; | ||
| 1145 | if (!perm && op.op != KD_FONT_OP_GET) | ||
| 1146 | return -EPERM; | ||
| 1147 | op.data = compat_ptr(((struct console_font_op32 *)&op)->data); | ||
| 1148 | op.flags |= KD_FONT_FLAG_OLD; | ||
| 1149 | vc = ((struct tty_struct *)file->private_data)->driver_data; | ||
| 1150 | i = con_font_op(vc, &op); | ||
| 1151 | if (i) | ||
| 1152 | return i; | ||
| 1153 | ((struct console_font_op32 *)&op)->data = (unsigned long)op.data; | ||
| 1154 | if (copy_to_user(fontop, &op, sizeof(struct console_font_op32))) | ||
| 1155 | return -EFAULT; | ||
| 1156 | return 0; | ||
| 1157 | } | ||
| 1158 | |||
| 1159 | struct unimapdesc32 { | ||
| 1160 | unsigned short entry_ct; | ||
| 1161 | compat_caddr_t entries; | ||
| 1162 | }; | ||
| 1163 | |||
| 1164 | static int do_unimap_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg, struct file *file) | ||
| 1165 | { | ||
| 1166 | struct unimapdesc32 tmp; | ||
| 1167 | struct unimapdesc32 __user *user_ud = compat_ptr(arg); | ||
| 1168 | int perm = vt_check(file); | ||
| 1169 | struct vc_data *vc; | ||
| 1170 | |||
| 1171 | if (perm < 0) | ||
| 1172 | return perm; | ||
| 1173 | if (copy_from_user(&tmp, user_ud, sizeof tmp)) | ||
| 1174 | return -EFAULT; | ||
| 1175 | if (tmp.entries) | ||
| 1176 | if (!access_ok(VERIFY_WRITE, compat_ptr(tmp.entries), | ||
| 1177 | tmp.entry_ct*sizeof(struct unipair))) | ||
| 1178 | return -EFAULT; | ||
| 1179 | vc = ((struct tty_struct *)file->private_data)->driver_data; | ||
| 1180 | switch (cmd) { | ||
| 1181 | case PIO_UNIMAP: | ||
| 1182 | if (!perm) | ||
| 1183 | return -EPERM; | ||
| 1184 | return con_set_unimap(vc, tmp.entry_ct, | ||
| 1185 | compat_ptr(tmp.entries)); | ||
| 1186 | case GIO_UNIMAP: | ||
| 1187 | if (!perm && fg_console != vc->vc_num) | ||
| 1188 | return -EPERM; | ||
| 1189 | return con_get_unimap(vc, tmp.entry_ct, &(user_ud->entry_ct), | ||
| 1190 | compat_ptr(tmp.entries)); | ||
| 1191 | } | ||
| 1192 | return 0; | ||
| 1193 | } | ||
| 1194 | |||
| 1195 | #endif /* CONFIG_VT */ | ||
| 1196 | |||
| 1197 | static int do_smb_getmountuid(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1198 | { | 575 | { |
| 1199 | mm_segment_t old_fs = get_fs(); | 576 | mm_segment_t old_fs = get_fs(); |
| 1200 | __kernel_uid_t kuid; | 577 | __kernel_uid_t kuid; |
| @@ -1207,184 +584,15 @@ static int do_smb_getmountuid(unsigned int fd, unsigned int cmd, unsigned long a | |||
| 1207 | set_fs(old_fs); | 584 | set_fs(old_fs); |
| 1208 | 585 | ||
| 1209 | if (err >= 0) | 586 | if (err >= 0) |
| 1210 | err = put_user(kuid, (compat_uid_t __user *)compat_ptr(arg)); | 587 | err = put_user(kuid, argp); |
| 1211 | 588 | ||
| 1212 | return err; | 589 | return err; |
| 1213 | } | 590 | } |
| 1214 | 591 | ||
| 1215 | struct atmif_sioc32 { | 592 | static int ioc_settimeout(unsigned int fd, unsigned int cmd, |
| 1216 | compat_int_t number; | 593 | compat_ulong_t __user *argp) |
| 1217 | compat_int_t length; | ||
| 1218 | compat_caddr_t arg; | ||
| 1219 | }; | ||
| 1220 | |||
| 1221 | struct atm_iobuf32 { | ||
| 1222 | compat_int_t length; | ||
| 1223 | compat_caddr_t buffer; | ||
| 1224 | }; | ||
| 1225 | |||
| 1226 | #define ATM_GETLINKRATE32 _IOW('a', ATMIOC_ITF+1, struct atmif_sioc32) | ||
| 1227 | #define ATM_GETNAMES32 _IOW('a', ATMIOC_ITF+3, struct atm_iobuf32) | ||
| 1228 | #define ATM_GETTYPE32 _IOW('a', ATMIOC_ITF+4, struct atmif_sioc32) | ||
| 1229 | #define ATM_GETESI32 _IOW('a', ATMIOC_ITF+5, struct atmif_sioc32) | ||
| 1230 | #define ATM_GETADDR32 _IOW('a', ATMIOC_ITF+6, struct atmif_sioc32) | ||
| 1231 | #define ATM_RSTADDR32 _IOW('a', ATMIOC_ITF+7, struct atmif_sioc32) | ||
| 1232 | #define ATM_ADDADDR32 _IOW('a', ATMIOC_ITF+8, struct atmif_sioc32) | ||
| 1233 | #define ATM_DELADDR32 _IOW('a', ATMIOC_ITF+9, struct atmif_sioc32) | ||
| 1234 | #define ATM_GETCIRANGE32 _IOW('a', ATMIOC_ITF+10, struct atmif_sioc32) | ||
| 1235 | #define ATM_SETCIRANGE32 _IOW('a', ATMIOC_ITF+11, struct atmif_sioc32) | ||
| 1236 | #define ATM_SETESI32 _IOW('a', ATMIOC_ITF+12, struct atmif_sioc32) | ||
| 1237 | #define ATM_SETESIF32 _IOW('a', ATMIOC_ITF+13, struct atmif_sioc32) | ||
| 1238 | #define ATM_GETSTAT32 _IOW('a', ATMIOC_SARCOM+0, struct atmif_sioc32) | ||
| 1239 | #define ATM_GETSTATZ32 _IOW('a', ATMIOC_SARCOM+1, struct atmif_sioc32) | ||
| 1240 | #define ATM_GETLOOP32 _IOW('a', ATMIOC_SARCOM+2, struct atmif_sioc32) | ||
| 1241 | #define ATM_SETLOOP32 _IOW('a', ATMIOC_SARCOM+3, struct atmif_sioc32) | ||
| 1242 | #define ATM_QUERYLOOP32 _IOW('a', ATMIOC_SARCOM+4, struct atmif_sioc32) | ||
| 1243 | |||
| 1244 | static struct { | ||
| 1245 | unsigned int cmd32; | ||
| 1246 | unsigned int cmd; | ||
| 1247 | } atm_ioctl_map[] = { | ||
| 1248 | { ATM_GETLINKRATE32, ATM_GETLINKRATE }, | ||
| 1249 | { ATM_GETNAMES32, ATM_GETNAMES }, | ||
| 1250 | { ATM_GETTYPE32, ATM_GETTYPE }, | ||
| 1251 | { ATM_GETESI32, ATM_GETESI }, | ||
| 1252 | { ATM_GETADDR32, ATM_GETADDR }, | ||
| 1253 | { ATM_RSTADDR32, ATM_RSTADDR }, | ||
| 1254 | { ATM_ADDADDR32, ATM_ADDADDR }, | ||
| 1255 | { ATM_DELADDR32, ATM_DELADDR }, | ||
| 1256 | { ATM_GETCIRANGE32, ATM_GETCIRANGE }, | ||
| 1257 | { ATM_SETCIRANGE32, ATM_SETCIRANGE }, | ||
| 1258 | { ATM_SETESI32, ATM_SETESI }, | ||
| 1259 | { ATM_SETESIF32, ATM_SETESIF }, | ||
| 1260 | { ATM_GETSTAT32, ATM_GETSTAT }, | ||
| 1261 | { ATM_GETSTATZ32, ATM_GETSTATZ }, | ||
| 1262 | { ATM_GETLOOP32, ATM_GETLOOP }, | ||
| 1263 | { ATM_SETLOOP32, ATM_SETLOOP }, | ||
| 1264 | { ATM_QUERYLOOP32, ATM_QUERYLOOP } | ||
| 1265 | }; | ||
| 1266 | |||
| 1267 | #define NR_ATM_IOCTL ARRAY_SIZE(atm_ioctl_map) | ||
| 1268 | |||
| 1269 | static int do_atm_iobuf(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1270 | { | 594 | { |
| 1271 | struct atm_iobuf __user *iobuf; | 595 | return rw_long(fd, AUTOFS_IOC_SETTIMEOUT, argp); |
| 1272 | struct atm_iobuf32 __user *iobuf32; | ||
| 1273 | u32 data; | ||
| 1274 | void __user *datap; | ||
| 1275 | int len, err; | ||
| 1276 | |||
| 1277 | iobuf = compat_alloc_user_space(sizeof(*iobuf)); | ||
| 1278 | iobuf32 = compat_ptr(arg); | ||
| 1279 | |||
| 1280 | if (get_user(len, &iobuf32->length) || | ||
| 1281 | get_user(data, &iobuf32->buffer)) | ||
| 1282 | return -EFAULT; | ||
| 1283 | datap = compat_ptr(data); | ||
| 1284 | if (put_user(len, &iobuf->length) || | ||
| 1285 | put_user(datap, &iobuf->buffer)) | ||
| 1286 | return -EFAULT; | ||
| 1287 | |||
| 1288 | err = sys_ioctl(fd, cmd, (unsigned long)iobuf); | ||
| 1289 | |||
| 1290 | if (!err) { | ||
| 1291 | if (copy_in_user(&iobuf32->length, &iobuf->length, | ||
| 1292 | sizeof(int))) | ||
| 1293 | err = -EFAULT; | ||
| 1294 | } | ||
| 1295 | |||
| 1296 | return err; | ||
| 1297 | } | ||
| 1298 | |||
| 1299 | static int do_atmif_sioc(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1300 | { | ||
| 1301 | struct atmif_sioc __user *sioc; | ||
| 1302 | struct atmif_sioc32 __user *sioc32; | ||
| 1303 | u32 data; | ||
| 1304 | void __user *datap; | ||
| 1305 | int err; | ||
| 1306 | |||
| 1307 | sioc = compat_alloc_user_space(sizeof(*sioc)); | ||
| 1308 | sioc32 = compat_ptr(arg); | ||
| 1309 | |||
| 1310 | if (copy_in_user(&sioc->number, &sioc32->number, 2 * sizeof(int)) || | ||
| 1311 | get_user(data, &sioc32->arg)) | ||
| 1312 | return -EFAULT; | ||
| 1313 | datap = compat_ptr(data); | ||
| 1314 | if (put_user(datap, &sioc->arg)) | ||
| 1315 | return -EFAULT; | ||
| 1316 | |||
| 1317 | err = sys_ioctl(fd, cmd, (unsigned long) sioc); | ||
| 1318 | |||
| 1319 | if (!err) { | ||
| 1320 | if (copy_in_user(&sioc32->length, &sioc->length, | ||
| 1321 | sizeof(int))) | ||
| 1322 | err = -EFAULT; | ||
| 1323 | } | ||
| 1324 | return err; | ||
| 1325 | } | ||
| 1326 | |||
| 1327 | static int do_atm_ioctl(unsigned int fd, unsigned int cmd32, unsigned long arg) | ||
| 1328 | { | ||
| 1329 | int i; | ||
| 1330 | unsigned int cmd = 0; | ||
| 1331 | |||
| 1332 | switch (cmd32) { | ||
| 1333 | case SONET_GETSTAT: | ||
| 1334 | case SONET_GETSTATZ: | ||
| 1335 | case SONET_GETDIAG: | ||
| 1336 | case SONET_SETDIAG: | ||
| 1337 | case SONET_CLRDIAG: | ||
| 1338 | case SONET_SETFRAMING: | ||
| 1339 | case SONET_GETFRAMING: | ||
| 1340 | case SONET_GETFRSENSE: | ||
| 1341 | return do_atmif_sioc(fd, cmd32, arg); | ||
| 1342 | } | ||
| 1343 | |||
| 1344 | for (i = 0; i < NR_ATM_IOCTL; i++) { | ||
| 1345 | if (cmd32 == atm_ioctl_map[i].cmd32) { | ||
| 1346 | cmd = atm_ioctl_map[i].cmd; | ||
| 1347 | break; | ||
| 1348 | } | ||
| 1349 | } | ||
| 1350 | if (i == NR_ATM_IOCTL) | ||
| 1351 | return -EINVAL; | ||
| 1352 | |||
| 1353 | switch (cmd) { | ||
| 1354 | case ATM_GETNAMES: | ||
| 1355 | return do_atm_iobuf(fd, cmd, arg); | ||
| 1356 | |||
| 1357 | case ATM_GETLINKRATE: | ||
| 1358 | case ATM_GETTYPE: | ||
| 1359 | case ATM_GETESI: | ||
| 1360 | case ATM_GETADDR: | ||
| 1361 | case ATM_RSTADDR: | ||
| 1362 | case ATM_ADDADDR: | ||
| 1363 | case ATM_DELADDR: | ||
| 1364 | case ATM_GETCIRANGE: | ||
| 1365 | case ATM_SETCIRANGE: | ||
| 1366 | case ATM_SETESI: | ||
| 1367 | case ATM_SETESIF: | ||
| 1368 | case ATM_GETSTAT: | ||
| 1369 | case ATM_GETSTATZ: | ||
| 1370 | case ATM_GETLOOP: | ||
| 1371 | case ATM_SETLOOP: | ||
| 1372 | case ATM_QUERYLOOP: | ||
| 1373 | return do_atmif_sioc(fd, cmd, arg); | ||
| 1374 | } | ||
| 1375 | |||
| 1376 | return -EINVAL; | ||
| 1377 | } | ||
| 1378 | |||
| 1379 | static __used int | ||
| 1380 | ret_einval(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1381 | { | ||
| 1382 | return -EINVAL; | ||
| 1383 | } | ||
| 1384 | |||
| 1385 | static int ioc_settimeout(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1386 | { | ||
| 1387 | return rw_long(fd, AUTOFS_IOC_SETTIMEOUT, arg); | ||
| 1388 | } | 596 | } |
| 1389 | 597 | ||
| 1390 | /* Bluetooth ioctls */ | 598 | /* Bluetooth ioctls */ |
| @@ -1442,7 +650,8 @@ static int set_raw32_request(struct raw_config_request *req, struct raw32_config | |||
| 1442 | return ret ? -EFAULT : 0; | 650 | return ret ? -EFAULT : 0; |
| 1443 | } | 651 | } |
| 1444 | 652 | ||
| 1445 | static int raw_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | 653 | static int raw_ioctl(unsigned fd, unsigned cmd, |
| 654 | struct raw32_config_request __user *user_req) | ||
| 1446 | { | 655 | { |
| 1447 | int ret; | 656 | int ret; |
| 1448 | 657 | ||
| @@ -1450,7 +659,6 @@ static int raw_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | |||
| 1450 | case RAW_SETBIND: | 659 | case RAW_SETBIND: |
| 1451 | case RAW_GETBIND: { | 660 | case RAW_GETBIND: { |
| 1452 | struct raw_config_request req; | 661 | struct raw_config_request req; |
| 1453 | struct raw32_config_request __user *user_req = compat_ptr(arg); | ||
| 1454 | mm_segment_t oldfs = get_fs(); | 662 | mm_segment_t oldfs = get_fs(); |
| 1455 | 663 | ||
| 1456 | if ((ret = get_raw32_request(&req, user_req))) | 664 | if ((ret = get_raw32_request(&req, user_req))) |
| @@ -1465,9 +673,6 @@ static int raw_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | |||
| 1465 | } | 673 | } |
| 1466 | break; | 674 | break; |
| 1467 | } | 675 | } |
| 1468 | default: | ||
| 1469 | ret = sys_ioctl(fd, cmd, arg); | ||
| 1470 | break; | ||
| 1471 | } | 676 | } |
| 1472 | return ret; | 677 | return ret; |
| 1473 | } | 678 | } |
| @@ -1495,11 +700,11 @@ struct serial_struct32 { | |||
| 1495 | compat_int_t reserved[1]; | 700 | compat_int_t reserved[1]; |
| 1496 | }; | 701 | }; |
| 1497 | 702 | ||
| 1498 | static int serial_struct_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | 703 | static int serial_struct_ioctl(unsigned fd, unsigned cmd, |
| 704 | struct serial_struct32 __user *ss32) | ||
| 1499 | { | 705 | { |
| 1500 | typedef struct serial_struct SS; | 706 | typedef struct serial_struct SS; |
| 1501 | typedef struct serial_struct32 SS32; | 707 | typedef struct serial_struct32 SS32; |
| 1502 | struct serial_struct32 __user *ss32 = compat_ptr(arg); | ||
| 1503 | int err; | 708 | int err; |
| 1504 | struct serial_struct ss; | 709 | struct serial_struct ss; |
| 1505 | mm_segment_t oldseg = get_fs(); | 710 | mm_segment_t oldseg = get_fs(); |
| @@ -1537,96 +742,6 @@ static int serial_struct_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | |||
| 1537 | return err; | 742 | return err; |
| 1538 | } | 743 | } |
| 1539 | 744 | ||
| 1540 | struct usbdevfs_ctrltransfer32 { | ||
| 1541 | u8 bRequestType; | ||
| 1542 | u8 bRequest; | ||
| 1543 | u16 wValue; | ||
| 1544 | u16 wIndex; | ||
| 1545 | u16 wLength; | ||
| 1546 | u32 timeout; /* in milliseconds */ | ||
| 1547 | compat_caddr_t data; | ||
| 1548 | }; | ||
| 1549 | |||
| 1550 | #define USBDEVFS_CONTROL32 _IOWR('U', 0, struct usbdevfs_ctrltransfer32) | ||
| 1551 | |||
| 1552 | static int do_usbdevfs_control(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1553 | { | ||
| 1554 | struct usbdevfs_ctrltransfer32 __user *p32 = compat_ptr(arg); | ||
| 1555 | struct usbdevfs_ctrltransfer __user *p; | ||
| 1556 | __u32 udata; | ||
| 1557 | p = compat_alloc_user_space(sizeof(*p)); | ||
| 1558 | if (copy_in_user(p, p32, (sizeof(*p32) - sizeof(compat_caddr_t))) || | ||
| 1559 | get_user(udata, &p32->data) || | ||
| 1560 | put_user(compat_ptr(udata), &p->data)) | ||
| 1561 | return -EFAULT; | ||
| 1562 | return sys_ioctl(fd, USBDEVFS_CONTROL, (unsigned long)p); | ||
| 1563 | } | ||
| 1564 | |||
| 1565 | |||
| 1566 | struct usbdevfs_bulktransfer32 { | ||
| 1567 | compat_uint_t ep; | ||
| 1568 | compat_uint_t len; | ||
| 1569 | compat_uint_t timeout; /* in milliseconds */ | ||
| 1570 | compat_caddr_t data; | ||
| 1571 | }; | ||
| 1572 | |||
| 1573 | #define USBDEVFS_BULK32 _IOWR('U', 2, struct usbdevfs_bulktransfer32) | ||
| 1574 | |||
| 1575 | static int do_usbdevfs_bulk(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1576 | { | ||
| 1577 | struct usbdevfs_bulktransfer32 __user *p32 = compat_ptr(arg); | ||
| 1578 | struct usbdevfs_bulktransfer __user *p; | ||
| 1579 | compat_uint_t n; | ||
| 1580 | compat_caddr_t addr; | ||
| 1581 | |||
| 1582 | p = compat_alloc_user_space(sizeof(*p)); | ||
| 1583 | |||
| 1584 | if (get_user(n, &p32->ep) || put_user(n, &p->ep) || | ||
| 1585 | get_user(n, &p32->len) || put_user(n, &p->len) || | ||
| 1586 | get_user(n, &p32->timeout) || put_user(n, &p->timeout) || | ||
| 1587 | get_user(addr, &p32->data) || put_user(compat_ptr(addr), &p->data)) | ||
| 1588 | return -EFAULT; | ||
| 1589 | |||
| 1590 | return sys_ioctl(fd, USBDEVFS_BULK, (unsigned long)p); | ||
| 1591 | } | ||
| 1592 | |||
| 1593 | |||
| 1594 | /* | ||
| 1595 | * USBDEVFS_SUBMITURB, USBDEVFS_REAPURB and USBDEVFS_REAPURBNDELAY | ||
| 1596 | * are handled in usbdevfs core. -Christopher Li | ||
| 1597 | */ | ||
| 1598 | |||
| 1599 | struct usbdevfs_disconnectsignal32 { | ||
| 1600 | compat_int_t signr; | ||
| 1601 | compat_caddr_t context; | ||
| 1602 | }; | ||
| 1603 | |||
| 1604 | #define USBDEVFS_DISCSIGNAL32 _IOR('U', 14, struct usbdevfs_disconnectsignal32) | ||
| 1605 | |||
| 1606 | static int do_usbdevfs_discsignal(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1607 | { | ||
| 1608 | struct usbdevfs_disconnectsignal kdis; | ||
| 1609 | struct usbdevfs_disconnectsignal32 __user *udis; | ||
| 1610 | mm_segment_t old_fs; | ||
| 1611 | u32 uctx; | ||
| 1612 | int err; | ||
| 1613 | |||
| 1614 | udis = compat_ptr(arg); | ||
| 1615 | |||
| 1616 | if (get_user(kdis.signr, &udis->signr) || | ||
| 1617 | __get_user(uctx, &udis->context)) | ||
| 1618 | return -EFAULT; | ||
| 1619 | |||
| 1620 | kdis.context = compat_ptr(uctx); | ||
| 1621 | |||
| 1622 | old_fs = get_fs(); | ||
| 1623 | set_fs(KERNEL_DS); | ||
| 1624 | err = sys_ioctl(fd, USBDEVFS_DISCSIGNAL, (unsigned long) &kdis); | ||
| 1625 | set_fs(old_fs); | ||
| 1626 | |||
| 1627 | return err; | ||
| 1628 | } | ||
| 1629 | |||
| 1630 | /* | 745 | /* |
| 1631 | * I2C layer ioctls | 746 | * I2C layer ioctls |
| 1632 | */ | 747 | */ |
| @@ -1655,9 +770,9 @@ struct i2c_rdwr_aligned { | |||
| 1655 | struct i2c_msg msgs[0]; | 770 | struct i2c_msg msgs[0]; |
| 1656 | }; | 771 | }; |
| 1657 | 772 | ||
| 1658 | static int do_i2c_rdwr_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | 773 | static int do_i2c_rdwr_ioctl(unsigned int fd, unsigned int cmd, |
| 774 | struct i2c_rdwr_ioctl_data32 __user *udata) | ||
| 1659 | { | 775 | { |
| 1660 | struct i2c_rdwr_ioctl_data32 __user *udata = compat_ptr(arg); | ||
| 1661 | struct i2c_rdwr_aligned __user *tdata; | 776 | struct i2c_rdwr_aligned __user *tdata; |
| 1662 | struct i2c_msg __user *tmsgs; | 777 | struct i2c_msg __user *tmsgs; |
| 1663 | struct i2c_msg32 __user *umsgs; | 778 | struct i2c_msg32 __user *umsgs; |
| @@ -1691,10 +806,10 @@ static int do_i2c_rdwr_ioctl(unsigned int fd, unsigned int cmd, unsigned long ar | |||
| 1691 | return sys_ioctl(fd, cmd, (unsigned long)tdata); | 806 | return sys_ioctl(fd, cmd, (unsigned long)tdata); |
| 1692 | } | 807 | } |
| 1693 | 808 | ||
| 1694 | static int do_i2c_smbus_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | 809 | static int do_i2c_smbus_ioctl(unsigned int fd, unsigned int cmd, |
| 810 | struct i2c_smbus_ioctl_data32 __user *udata) | ||
| 1695 | { | 811 | { |
| 1696 | struct i2c_smbus_ioctl_data __user *tdata; | 812 | struct i2c_smbus_ioctl_data __user *tdata; |
| 1697 | struct i2c_smbus_ioctl_data32 __user *udata; | ||
| 1698 | compat_caddr_t datap; | 813 | compat_caddr_t datap; |
| 1699 | 814 | ||
| 1700 | tdata = compat_alloc_user_space(sizeof(*tdata)); | 815 | tdata = compat_alloc_user_space(sizeof(*tdata)); |
| @@ -1703,7 +818,6 @@ static int do_i2c_smbus_ioctl(unsigned int fd, unsigned int cmd, unsigned long a | |||
| 1703 | if (!access_ok(VERIFY_WRITE, tdata, sizeof(*tdata))) | 818 | if (!access_ok(VERIFY_WRITE, tdata, sizeof(*tdata))) |
| 1704 | return -EFAULT; | 819 | return -EFAULT; |
| 1705 | 820 | ||
| 1706 | udata = compat_ptr(arg); | ||
| 1707 | if (!access_ok(VERIFY_READ, udata, sizeof(*udata))) | 821 | if (!access_ok(VERIFY_READ, udata, sizeof(*udata))) |
| 1708 | return -EFAULT; | 822 | return -EFAULT; |
| 1709 | 823 | ||
| @@ -1718,27 +832,12 @@ static int do_i2c_smbus_ioctl(unsigned int fd, unsigned int cmd, unsigned long a | |||
| 1718 | return sys_ioctl(fd, cmd, (unsigned long)tdata); | 832 | return sys_ioctl(fd, cmd, (unsigned long)tdata); |
| 1719 | } | 833 | } |
| 1720 | 834 | ||
| 1721 | /* Since old style bridge ioctl's endup using SIOCDEVPRIVATE | ||
| 1722 | * for some operations; this forces use of the newer bridge-utils that | ||
| 1723 | * use compatible ioctls | ||
| 1724 | */ | ||
| 1725 | static int old_bridge_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1726 | { | ||
| 1727 | u32 tmp; | ||
| 1728 | |||
| 1729 | if (get_user(tmp, (u32 __user *) arg)) | ||
| 1730 | return -EFAULT; | ||
| 1731 | if (tmp == BRCTL_GET_VERSION) | ||
| 1732 | return BRCTL_VERSION + 1; | ||
| 1733 | return -EINVAL; | ||
| 1734 | } | ||
| 1735 | |||
| 1736 | #define RTC_IRQP_READ32 _IOR('p', 0x0b, compat_ulong_t) | 835 | #define RTC_IRQP_READ32 _IOR('p', 0x0b, compat_ulong_t) |
| 1737 | #define RTC_IRQP_SET32 _IOW('p', 0x0c, compat_ulong_t) | 836 | #define RTC_IRQP_SET32 _IOW('p', 0x0c, compat_ulong_t) |
| 1738 | #define RTC_EPOCH_READ32 _IOR('p', 0x0d, compat_ulong_t) | 837 | #define RTC_EPOCH_READ32 _IOR('p', 0x0d, compat_ulong_t) |
| 1739 | #define RTC_EPOCH_SET32 _IOW('p', 0x0e, compat_ulong_t) | 838 | #define RTC_EPOCH_SET32 _IOW('p', 0x0e, compat_ulong_t) |
| 1740 | 839 | ||
| 1741 | static int rtc_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | 840 | static int rtc_ioctl(unsigned fd, unsigned cmd, void __user *argp) |
| 1742 | { | 841 | { |
| 1743 | mm_segment_t oldfs = get_fs(); | 842 | mm_segment_t oldfs = get_fs(); |
| 1744 | compat_ulong_t val32; | 843 | compat_ulong_t val32; |
| @@ -1756,29 +855,14 @@ static int rtc_ioctl(unsigned fd, unsigned cmd, unsigned long arg) | |||
| 1756 | if (ret) | 855 | if (ret) |
| 1757 | return ret; | 856 | return ret; |
| 1758 | val32 = kval; | 857 | val32 = kval; |
| 1759 | return put_user(val32, (unsigned int __user *)arg); | 858 | return put_user(val32, (unsigned int __user *)argp); |
| 1760 | case RTC_IRQP_SET32: | 859 | case RTC_IRQP_SET32: |
| 1761 | return sys_ioctl(fd, RTC_IRQP_SET, arg); | 860 | return sys_ioctl(fd, RTC_IRQP_SET, (unsigned long)argp); |
| 1762 | case RTC_EPOCH_SET32: | 861 | case RTC_EPOCH_SET32: |
| 1763 | return sys_ioctl(fd, RTC_EPOCH_SET, arg); | 862 | return sys_ioctl(fd, RTC_EPOCH_SET, (unsigned long)argp); |
| 1764 | default: | ||
| 1765 | /* unreached */ | ||
| 1766 | return -ENOIOCTLCMD; | ||
| 1767 | } | 863 | } |
| 1768 | } | ||
| 1769 | 864 | ||
| 1770 | static int | 865 | return -ENOIOCTLCMD; |
| 1771 | lp_timeout_trans(unsigned int fd, unsigned int cmd, unsigned long arg) | ||
| 1772 | { | ||
| 1773 | struct compat_timeval __user *tc = (struct compat_timeval __user *)arg; | ||
| 1774 | struct timeval __user *tn = compat_alloc_user_space(sizeof(struct timeval)); | ||
| 1775 | struct timeval ts; | ||
| 1776 | if (get_user(ts.tv_sec, &tc->tv_sec) || | ||
| 1777 | get_user(ts.tv_usec, &tc->tv_usec) || | ||
| 1778 | put_user(ts.tv_sec, &tn->tv_sec) || | ||
| 1779 | put_user(ts.tv_usec, &tn->tv_usec)) | ||
| 1780 | return -EFAULT; | ||
| 1781 | return sys_ioctl(fd, cmd, (unsigned long)tn); | ||
| 1782 | } | 866 | } |
| 1783 | 867 | ||
| 1784 | /* on ia32 l_start is on a 32-bit boundary */ | 868 | /* on ia32 l_start is on a 32-bit boundary */ |
| @@ -1798,9 +882,9 @@ struct space_resv_32 { | |||
| 1798 | #define FS_IOC_RESVSP64_32 _IOW ('X', 42, struct space_resv_32) | 882 | #define FS_IOC_RESVSP64_32 _IOW ('X', 42, struct space_resv_32) |
| 1799 | 883 | ||
| 1800 | /* just account for different alignment */ | 884 | /* just account for different alignment */ |
| 1801 | static int compat_ioctl_preallocate(struct file *file, unsigned long arg) | 885 | static int compat_ioctl_preallocate(struct file *file, |
| 886 | struct space_resv_32 __user *p32) | ||
| 1802 | { | 887 | { |
| 1803 | struct space_resv_32 __user *p32 = compat_ptr(arg); | ||
| 1804 | struct space_resv __user *p = compat_alloc_user_space(sizeof(*p)); | 888 | struct space_resv __user *p = compat_alloc_user_space(sizeof(*p)); |
| 1805 | 889 | ||
| 1806 | if (copy_in_user(&p->l_type, &p32->l_type, sizeof(s16)) || | 890 | if (copy_in_user(&p->l_type, &p32->l_type, sizeof(s16)) || |
| @@ -1816,27 +900,13 @@ static int compat_ioctl_preallocate(struct file *file, unsigned long arg) | |||
| 1816 | } | 900 | } |
| 1817 | #endif | 901 | #endif |
| 1818 | 902 | ||
| 903 | /* | ||
| 904 | * simple reversible transform to make our table more evenly | ||
| 905 | * distributed after sorting. | ||
| 906 | */ | ||
| 907 | #define XFORM(i) (((i) ^ ((i) << 27) ^ ((i) << 17)) & 0xffffffff) | ||
| 1819 | 908 | ||
| 1820 | typedef int (*ioctl_trans_handler_t)(unsigned int, unsigned int, | 909 | #define COMPATIBLE_IOCTL(cmd) XFORM(cmd), |
| 1821 | unsigned long, struct file *); | ||
| 1822 | |||
| 1823 | struct ioctl_trans { | ||
| 1824 | unsigned long cmd; | ||
| 1825 | ioctl_trans_handler_t handler; | ||
| 1826 | struct ioctl_trans *next; | ||
| 1827 | }; | ||
| 1828 | |||
| 1829 | #define HANDLE_IOCTL(cmd,handler) \ | ||
| 1830 | { (cmd), (ioctl_trans_handler_t)(handler) }, | ||
| 1831 | |||
| 1832 | /* pointer to compatible structure or no argument */ | ||
| 1833 | #define COMPATIBLE_IOCTL(cmd) \ | ||
| 1834 | { (cmd), do_ioctl32_pointer }, | ||
| 1835 | |||
| 1836 | /* argument is an unsigned long integer, not a pointer */ | ||
| 1837 | #define ULONG_IOCTL(cmd) \ | ||
| 1838 | { (cmd), (ioctl_trans_handler_t)sys_ioctl }, | ||
| 1839 | |||
| 1840 | /* ioctl should not be warned about even if it's not implemented. | 910 | /* ioctl should not be warned about even if it's not implemented. |
| 1841 | Valid reasons to use this: | 911 | Valid reasons to use this: |
| 1842 | - It is implemented with ->compat_ioctl on some device, but programs | 912 | - It is implemented with ->compat_ioctl on some device, but programs |
| @@ -1846,7 +916,7 @@ struct ioctl_trans { | |||
| 1846 | Most other reasons are not valid. */ | 916 | Most other reasons are not valid. */ |
| 1847 | #define IGNORE_IOCTL(cmd) COMPATIBLE_IOCTL(cmd) | 917 | #define IGNORE_IOCTL(cmd) COMPATIBLE_IOCTL(cmd) |
| 1848 | 918 | ||
| 1849 | static struct ioctl_trans ioctl_start[] = { | 919 | static unsigned int ioctl_pointer[] = { |
| 1850 | /* compatible ioctls first */ | 920 | /* compatible ioctls first */ |
| 1851 | COMPATIBLE_IOCTL(0x4B50) /* KDGHWCLK - not in the kernel, but don't complain */ | 921 | COMPATIBLE_IOCTL(0x4B50) /* KDGHWCLK - not in the kernel, but don't complain */ |
| 1852 | COMPATIBLE_IOCTL(0x4B51) /* KDSHWCLK - not in the kernel, but don't complain */ | 922 | COMPATIBLE_IOCTL(0x4B51) /* KDSHWCLK - not in the kernel, but don't complain */ |
| @@ -1857,7 +927,6 @@ COMPATIBLE_IOCTL(TCSETA) | |||
| 1857 | COMPATIBLE_IOCTL(TCSETAW) | 927 | COMPATIBLE_IOCTL(TCSETAW) |
| 1858 | COMPATIBLE_IOCTL(TCSETAF) | 928 | COMPATIBLE_IOCTL(TCSETAF) |
| 1859 | COMPATIBLE_IOCTL(TCSBRK) | 929 | COMPATIBLE_IOCTL(TCSBRK) |
| 1860 | ULONG_IOCTL(TCSBRKP) | ||
| 1861 | COMPATIBLE_IOCTL(TCXONC) | 930 | COMPATIBLE_IOCTL(TCXONC) |
| 1862 | COMPATIBLE_IOCTL(TCFLSH) | 931 | COMPATIBLE_IOCTL(TCFLSH) |
| 1863 | COMPATIBLE_IOCTL(TCGETS) | 932 | COMPATIBLE_IOCTL(TCGETS) |
| @@ -1867,7 +936,6 @@ COMPATIBLE_IOCTL(TCSETSF) | |||
| 1867 | COMPATIBLE_IOCTL(TIOCLINUX) | 936 | COMPATIBLE_IOCTL(TIOCLINUX) |
| 1868 | COMPATIBLE_IOCTL(TIOCSBRK) | 937 | COMPATIBLE_IOCTL(TIOCSBRK) |
| 1869 | COMPATIBLE_IOCTL(TIOCCBRK) | 938 | COMPATIBLE_IOCTL(TIOCCBRK) |
| 1870 | ULONG_IOCTL(TIOCMIWAIT) | ||
| 1871 | COMPATIBLE_IOCTL(TIOCGICOUNT) | 939 | COMPATIBLE_IOCTL(TIOCGICOUNT) |
| 1872 | /* Little t */ | 940 | /* Little t */ |
| 1873 | COMPATIBLE_IOCTL(TIOCGETD) | 941 | COMPATIBLE_IOCTL(TIOCGETD) |
| @@ -1889,7 +957,6 @@ COMPATIBLE_IOCTL(TIOCSTI) | |||
| 1889 | COMPATIBLE_IOCTL(TIOCOUTQ) | 957 | COMPATIBLE_IOCTL(TIOCOUTQ) |
| 1890 | COMPATIBLE_IOCTL(TIOCSPGRP) | 958 | COMPATIBLE_IOCTL(TIOCSPGRP) |
| 1891 | COMPATIBLE_IOCTL(TIOCGPGRP) | 959 | COMPATIBLE_IOCTL(TIOCGPGRP) |
| 1892 | ULONG_IOCTL(TIOCSCTTY) | ||
| 1893 | COMPATIBLE_IOCTL(TIOCGPTN) | 960 | COMPATIBLE_IOCTL(TIOCGPTN) |
| 1894 | COMPATIBLE_IOCTL(TIOCSPTLCK) | 961 | COMPATIBLE_IOCTL(TIOCSPTLCK) |
| 1895 | COMPATIBLE_IOCTL(TIOCSERGETLSR) | 962 | COMPATIBLE_IOCTL(TIOCSERGETLSR) |
| @@ -1912,44 +979,11 @@ COMPATIBLE_IOCTL(FIGETBSZ) | |||
| 1912 | /* 'X' - originally XFS but some now in the VFS */ | 979 | /* 'X' - originally XFS but some now in the VFS */ |
| 1913 | COMPATIBLE_IOCTL(FIFREEZE) | 980 | COMPATIBLE_IOCTL(FIFREEZE) |
| 1914 | COMPATIBLE_IOCTL(FITHAW) | 981 | COMPATIBLE_IOCTL(FITHAW) |
| 1915 | /* RAID */ | ||
| 1916 | COMPATIBLE_IOCTL(RAID_VERSION) | ||
| 1917 | COMPATIBLE_IOCTL(GET_ARRAY_INFO) | ||
| 1918 | COMPATIBLE_IOCTL(GET_DISK_INFO) | ||
| 1919 | COMPATIBLE_IOCTL(PRINT_RAID_DEBUG) | ||
| 1920 | COMPATIBLE_IOCTL(RAID_AUTORUN) | ||
| 1921 | COMPATIBLE_IOCTL(CLEAR_ARRAY) | ||
| 1922 | COMPATIBLE_IOCTL(ADD_NEW_DISK) | ||
| 1923 | ULONG_IOCTL(HOT_REMOVE_DISK) | ||
| 1924 | COMPATIBLE_IOCTL(SET_ARRAY_INFO) | ||
| 1925 | COMPATIBLE_IOCTL(SET_DISK_INFO) | ||
| 1926 | COMPATIBLE_IOCTL(WRITE_RAID_INFO) | ||
| 1927 | COMPATIBLE_IOCTL(UNPROTECT_ARRAY) | ||
| 1928 | COMPATIBLE_IOCTL(PROTECT_ARRAY) | ||
| 1929 | ULONG_IOCTL(HOT_ADD_DISK) | ||
| 1930 | ULONG_IOCTL(SET_DISK_FAULTY) | ||
| 1931 | COMPATIBLE_IOCTL(RUN_ARRAY) | ||
| 1932 | COMPATIBLE_IOCTL(STOP_ARRAY) | ||
| 1933 | COMPATIBLE_IOCTL(STOP_ARRAY_RO) | ||
| 1934 | COMPATIBLE_IOCTL(RESTART_ARRAY_RW) | ||
| 1935 | COMPATIBLE_IOCTL(GET_BITMAP_FILE) | ||
| 1936 | ULONG_IOCTL(SET_BITMAP_FILE) | ||
| 1937 | /* Big K */ | ||
| 1938 | COMPATIBLE_IOCTL(PIO_FONT) | ||
| 1939 | COMPATIBLE_IOCTL(GIO_FONT) | ||
| 1940 | COMPATIBLE_IOCTL(PIO_CMAP) | ||
| 1941 | COMPATIBLE_IOCTL(GIO_CMAP) | ||
| 1942 | ULONG_IOCTL(KDSIGACCEPT) | ||
| 1943 | COMPATIBLE_IOCTL(KDGETKEYCODE) | 982 | COMPATIBLE_IOCTL(KDGETKEYCODE) |
| 1944 | COMPATIBLE_IOCTL(KDSETKEYCODE) | 983 | COMPATIBLE_IOCTL(KDSETKEYCODE) |
| 1945 | ULONG_IOCTL(KIOCSOUND) | ||
| 1946 | ULONG_IOCTL(KDMKTONE) | ||
| 1947 | COMPATIBLE_IOCTL(KDGKBTYPE) | 984 | COMPATIBLE_IOCTL(KDGKBTYPE) |
| 1948 | ULONG_IOCTL(KDSETMODE) | ||
| 1949 | COMPATIBLE_IOCTL(KDGETMODE) | 985 | COMPATIBLE_IOCTL(KDGETMODE) |
| 1950 | ULONG_IOCTL(KDSKBMODE) | ||
| 1951 | COMPATIBLE_IOCTL(KDGKBMODE) | 986 | COMPATIBLE_IOCTL(KDGKBMODE) |
| 1952 | ULONG_IOCTL(KDSKBMETA) | ||
| 1953 | COMPATIBLE_IOCTL(KDGKBMETA) | 987 | COMPATIBLE_IOCTL(KDGKBMETA) |
| 1954 | COMPATIBLE_IOCTL(KDGKBENT) | 988 | COMPATIBLE_IOCTL(KDGKBENT) |
| 1955 | COMPATIBLE_IOCTL(KDSKBENT) | 989 | COMPATIBLE_IOCTL(KDSKBENT) |
| @@ -1959,15 +993,7 @@ COMPATIBLE_IOCTL(KDGKBDIACR) | |||
| 1959 | COMPATIBLE_IOCTL(KDSKBDIACR) | 993 | COMPATIBLE_IOCTL(KDSKBDIACR) |
| 1960 | COMPATIBLE_IOCTL(KDKBDREP) | 994 | COMPATIBLE_IOCTL(KDKBDREP) |
| 1961 | COMPATIBLE_IOCTL(KDGKBLED) | 995 | COMPATIBLE_IOCTL(KDGKBLED) |
| 1962 | ULONG_IOCTL(KDSKBLED) | ||
| 1963 | COMPATIBLE_IOCTL(KDGETLED) | 996 | COMPATIBLE_IOCTL(KDGETLED) |
| 1964 | ULONG_IOCTL(KDSETLED) | ||
| 1965 | COMPATIBLE_IOCTL(GIO_SCRNMAP) | ||
| 1966 | COMPATIBLE_IOCTL(PIO_SCRNMAP) | ||
| 1967 | COMPATIBLE_IOCTL(GIO_UNISCRNMAP) | ||
| 1968 | COMPATIBLE_IOCTL(PIO_UNISCRNMAP) | ||
| 1969 | COMPATIBLE_IOCTL(PIO_FONTRESET) | ||
| 1970 | COMPATIBLE_IOCTL(PIO_UNIMAPCLR) | ||
| 1971 | #ifdef CONFIG_BLOCK | 997 | #ifdef CONFIG_BLOCK |
| 1972 | /* Big S */ | 998 | /* Big S */ |
| 1973 | COMPATIBLE_IOCTL(SCSI_IOCTL_GET_IDLUN) | 999 | COMPATIBLE_IOCTL(SCSI_IOCTL_GET_IDLUN) |
| @@ -1979,32 +1005,6 @@ COMPATIBLE_IOCTL(SCSI_IOCTL_SEND_COMMAND) | |||
| 1979 | COMPATIBLE_IOCTL(SCSI_IOCTL_PROBE_HOST) | 1005 | COMPATIBLE_IOCTL(SCSI_IOCTL_PROBE_HOST) |
| 1980 | COMPATIBLE_IOCTL(SCSI_IOCTL_GET_PCI) | 1006 | COMPATIBLE_IOCTL(SCSI_IOCTL_GET_PCI) |
| 1981 | #endif | 1007 | #endif |
| 1982 | /* Big T */ | ||
| 1983 | COMPATIBLE_IOCTL(TUNSETNOCSUM) | ||
| 1984 | COMPATIBLE_IOCTL(TUNSETDEBUG) | ||
| 1985 | COMPATIBLE_IOCTL(TUNSETPERSIST) | ||
| 1986 | COMPATIBLE_IOCTL(TUNSETOWNER) | ||
| 1987 | COMPATIBLE_IOCTL(TUNSETLINK) | ||
| 1988 | COMPATIBLE_IOCTL(TUNSETGROUP) | ||
| 1989 | COMPATIBLE_IOCTL(TUNGETFEATURES) | ||
| 1990 | COMPATIBLE_IOCTL(TUNSETOFFLOAD) | ||
| 1991 | COMPATIBLE_IOCTL(TUNSETTXFILTER) | ||
| 1992 | COMPATIBLE_IOCTL(TUNGETSNDBUF) | ||
| 1993 | COMPATIBLE_IOCTL(TUNSETSNDBUF) | ||
| 1994 | /* Big V */ | ||
| 1995 | COMPATIBLE_IOCTL(VT_SETMODE) | ||
| 1996 | COMPATIBLE_IOCTL(VT_GETMODE) | ||
| 1997 | COMPATIBLE_IOCTL(VT_GETSTATE) | ||
| 1998 | COMPATIBLE_IOCTL(VT_OPENQRY) | ||
| 1999 | ULONG_IOCTL(VT_ACTIVATE) | ||
| 2000 | ULONG_IOCTL(VT_WAITACTIVE) | ||
| 2001 | ULONG_IOCTL(VT_RELDISP) | ||
| 2002 | ULONG_IOCTL(VT_DISALLOCATE) | ||
| 2003 | COMPATIBLE_IOCTL(VT_RESIZE) | ||
| 2004 | COMPATIBLE_IOCTL(VT_RESIZEX) | ||
| 2005 | COMPATIBLE_IOCTL(VT_LOCKSWITCH) | ||
| 2006 | COMPATIBLE_IOCTL(VT_UNLOCKSWITCH) | ||
| 2007 | COMPATIBLE_IOCTL(VT_GETHIFONTMASK) | ||
| 2008 | /* Little p (/dev/rtc, /dev/envctrl, etc.) */ | 1008 | /* Little p (/dev/rtc, /dev/envctrl, etc.) */ |
| 2009 | COMPATIBLE_IOCTL(RTC_AIE_ON) | 1009 | COMPATIBLE_IOCTL(RTC_AIE_ON) |
| 2010 | COMPATIBLE_IOCTL(RTC_AIE_OFF) | 1010 | COMPATIBLE_IOCTL(RTC_AIE_OFF) |
| @@ -2032,36 +1032,13 @@ COMPATIBLE_IOCTL(_IOW('p', 21, int[7])) /* RTCSET */ | |||
| 2032 | COMPATIBLE_IOCTL(MTIOCTOP) | 1032 | COMPATIBLE_IOCTL(MTIOCTOP) |
| 2033 | /* Socket level stuff */ | 1033 | /* Socket level stuff */ |
| 2034 | COMPATIBLE_IOCTL(FIOQSIZE) | 1034 | COMPATIBLE_IOCTL(FIOQSIZE) |
| 2035 | COMPATIBLE_IOCTL(FIOSETOWN) | ||
| 2036 | COMPATIBLE_IOCTL(SIOCSPGRP) | ||
| 2037 | COMPATIBLE_IOCTL(FIOGETOWN) | ||
| 2038 | COMPATIBLE_IOCTL(SIOCGPGRP) | ||
| 2039 | COMPATIBLE_IOCTL(SIOCATMARK) | ||
| 2040 | COMPATIBLE_IOCTL(SIOCSIFLINK) | ||
| 2041 | COMPATIBLE_IOCTL(SIOCSIFENCAP) | ||
| 2042 | COMPATIBLE_IOCTL(SIOCGIFENCAP) | ||
| 2043 | COMPATIBLE_IOCTL(SIOCSIFNAME) | ||
| 2044 | COMPATIBLE_IOCTL(SIOCSARP) | ||
| 2045 | COMPATIBLE_IOCTL(SIOCGARP) | ||
| 2046 | COMPATIBLE_IOCTL(SIOCDARP) | ||
| 2047 | COMPATIBLE_IOCTL(SIOCSRARP) | ||
| 2048 | COMPATIBLE_IOCTL(SIOCGRARP) | ||
| 2049 | COMPATIBLE_IOCTL(SIOCDRARP) | ||
| 2050 | COMPATIBLE_IOCTL(SIOCADDDLCI) | ||
| 2051 | COMPATIBLE_IOCTL(SIOCDELDLCI) | ||
| 2052 | COMPATIBLE_IOCTL(SIOCGMIIPHY) | ||
| 2053 | COMPATIBLE_IOCTL(SIOCGMIIREG) | ||
| 2054 | COMPATIBLE_IOCTL(SIOCSMIIREG) | ||
| 2055 | COMPATIBLE_IOCTL(SIOCGIFVLAN) | ||
| 2056 | COMPATIBLE_IOCTL(SIOCSIFVLAN) | ||
| 2057 | COMPATIBLE_IOCTL(SIOCBRADDBR) | ||
| 2058 | COMPATIBLE_IOCTL(SIOCBRDELBR) | ||
| 2059 | #ifdef CONFIG_BLOCK | 1035 | #ifdef CONFIG_BLOCK |
| 1036 | /* loop */ | ||
| 1037 | IGNORE_IOCTL(LOOP_CLR_FD) | ||
| 2060 | /* SG stuff */ | 1038 | /* SG stuff */ |
| 2061 | COMPATIBLE_IOCTL(SG_SET_TIMEOUT) | 1039 | COMPATIBLE_IOCTL(SG_SET_TIMEOUT) |
| 2062 | COMPATIBLE_IOCTL(SG_GET_TIMEOUT) | 1040 | COMPATIBLE_IOCTL(SG_GET_TIMEOUT) |
| 2063 | COMPATIBLE_IOCTL(SG_EMULATED_HOST) | 1041 | COMPATIBLE_IOCTL(SG_EMULATED_HOST) |
| 2064 | ULONG_IOCTL(SG_SET_TRANSFORM) | ||
| 2065 | COMPATIBLE_IOCTL(SG_GET_TRANSFORM) | 1042 | COMPATIBLE_IOCTL(SG_GET_TRANSFORM) |
| 2066 | COMPATIBLE_IOCTL(SG_SET_RESERVED_SIZE) | 1043 | COMPATIBLE_IOCTL(SG_SET_RESERVED_SIZE) |
| 2067 | COMPATIBLE_IOCTL(SG_GET_RESERVED_SIZE) | 1044 | COMPATIBLE_IOCTL(SG_GET_RESERVED_SIZE) |
| @@ -2115,8 +1092,6 @@ COMPATIBLE_IOCTL(PPPIOCGCHAN) | |||
| 2115 | /* PPPOX */ | 1092 | /* PPPOX */ |
| 2116 | COMPATIBLE_IOCTL(PPPOEIOCSFWD) | 1093 | COMPATIBLE_IOCTL(PPPOEIOCSFWD) |
| 2117 | COMPATIBLE_IOCTL(PPPOEIOCDFWD) | 1094 | COMPATIBLE_IOCTL(PPPOEIOCDFWD) |
| 2118 | /* LP */ | ||
| 2119 | COMPATIBLE_IOCTL(LPGETSTATUS) | ||
| 2120 | /* ppdev */ | 1095 | /* ppdev */ |
| 2121 | COMPATIBLE_IOCTL(PPSETMODE) | 1096 | COMPATIBLE_IOCTL(PPSETMODE) |
| 2122 | COMPATIBLE_IOCTL(PPRSTATUS) | 1097 | COMPATIBLE_IOCTL(PPRSTATUS) |
| @@ -2298,8 +1273,6 @@ COMPATIBLE_IOCTL(SOUND_MIXER_GETLEVELS) | |||
| 2298 | COMPATIBLE_IOCTL(SOUND_MIXER_SETLEVELS) | 1273 | COMPATIBLE_IOCTL(SOUND_MIXER_SETLEVELS) |
| 2299 | COMPATIBLE_IOCTL(OSS_GETVERSION) | 1274 | COMPATIBLE_IOCTL(OSS_GETVERSION) |
| 2300 | /* AUTOFS */ | 1275 | /* AUTOFS */ |
| 2301 | ULONG_IOCTL(AUTOFS_IOC_READY) | ||
| 2302 | ULONG_IOCTL(AUTOFS_IOC_FAIL) | ||
| 2303 | COMPATIBLE_IOCTL(AUTOFS_IOC_CATATONIC) | 1276 | COMPATIBLE_IOCTL(AUTOFS_IOC_CATATONIC) |
| 2304 | COMPATIBLE_IOCTL(AUTOFS_IOC_PROTOVER) | 1277 | COMPATIBLE_IOCTL(AUTOFS_IOC_PROTOVER) |
| 2305 | COMPATIBLE_IOCTL(AUTOFS_IOC_EXPIRE) | 1278 | COMPATIBLE_IOCTL(AUTOFS_IOC_EXPIRE) |
| @@ -2311,22 +1284,6 @@ COMPATIBLE_IOCTL(RAW_SETBIND) | |||
| 2311 | COMPATIBLE_IOCTL(RAW_GETBIND) | 1284 | COMPATIBLE_IOCTL(RAW_GETBIND) |
| 2312 | /* SMB ioctls which do not need any translations */ | 1285 | /* SMB ioctls which do not need any translations */ |
| 2313 | COMPATIBLE_IOCTL(SMB_IOC_NEWCONN) | 1286 | COMPATIBLE_IOCTL(SMB_IOC_NEWCONN) |
| 2314 | /* Little a */ | ||
| 2315 | COMPATIBLE_IOCTL(ATMSIGD_CTRL) | ||
| 2316 | COMPATIBLE_IOCTL(ATMARPD_CTRL) | ||
| 2317 | COMPATIBLE_IOCTL(ATMLEC_CTRL) | ||
| 2318 | COMPATIBLE_IOCTL(ATMLEC_MCAST) | ||
| 2319 | COMPATIBLE_IOCTL(ATMLEC_DATA) | ||
| 2320 | COMPATIBLE_IOCTL(ATM_SETSC) | ||
| 2321 | COMPATIBLE_IOCTL(SIOCSIFATMTCP) | ||
| 2322 | COMPATIBLE_IOCTL(SIOCMKCLIP) | ||
| 2323 | COMPATIBLE_IOCTL(ATMARP_MKIP) | ||
| 2324 | COMPATIBLE_IOCTL(ATMARP_SETENTRY) | ||
| 2325 | COMPATIBLE_IOCTL(ATMARP_ENCAP) | ||
| 2326 | COMPATIBLE_IOCTL(ATMTCP_CREATE) | ||
| 2327 | COMPATIBLE_IOCTL(ATMTCP_REMOVE) | ||
| 2328 | COMPATIBLE_IOCTL(ATMMPC_CTRL) | ||
| 2329 | COMPATIBLE_IOCTL(ATMMPC_DATA) | ||
| 2330 | /* Watchdog */ | 1287 | /* Watchdog */ |
| 2331 | COMPATIBLE_IOCTL(WDIOC_GETSUPPORT) | 1288 | COMPATIBLE_IOCTL(WDIOC_GETSUPPORT) |
| 2332 | COMPATIBLE_IOCTL(WDIOC_GETSTATUS) | 1289 | COMPATIBLE_IOCTL(WDIOC_GETSTATUS) |
| @@ -2408,30 +1365,11 @@ COMPATIBLE_IOCTL(PCIIOC_CONTROLLER) | |||
| 2408 | COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO) | 1365 | COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO) |
| 2409 | COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM) | 1366 | COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM) |
| 2410 | COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE) | 1367 | COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE) |
| 2411 | /* USB */ | ||
| 2412 | COMPATIBLE_IOCTL(USBDEVFS_RESETEP) | ||
| 2413 | COMPATIBLE_IOCTL(USBDEVFS_SETINTERFACE) | ||
| 2414 | COMPATIBLE_IOCTL(USBDEVFS_SETCONFIGURATION) | ||
| 2415 | COMPATIBLE_IOCTL(USBDEVFS_GETDRIVER) | ||
| 2416 | COMPATIBLE_IOCTL(USBDEVFS_DISCARDURB) | ||
| 2417 | COMPATIBLE_IOCTL(USBDEVFS_CLAIMINTERFACE) | ||
| 2418 | COMPATIBLE_IOCTL(USBDEVFS_RELEASEINTERFACE) | ||
| 2419 | COMPATIBLE_IOCTL(USBDEVFS_CONNECTINFO) | ||
| 2420 | COMPATIBLE_IOCTL(USBDEVFS_HUB_PORTINFO) | ||
| 2421 | COMPATIBLE_IOCTL(USBDEVFS_RESET) | ||
| 2422 | COMPATIBLE_IOCTL(USBDEVFS_SUBMITURB32) | ||
| 2423 | COMPATIBLE_IOCTL(USBDEVFS_REAPURB32) | ||
| 2424 | COMPATIBLE_IOCTL(USBDEVFS_REAPURBNDELAY32) | ||
| 2425 | COMPATIBLE_IOCTL(USBDEVFS_CLEAR_HALT) | ||
| 2426 | /* NBD */ | 1368 | /* NBD */ |
| 2427 | ULONG_IOCTL(NBD_SET_SOCK) | ||
| 2428 | ULONG_IOCTL(NBD_SET_BLKSIZE) | ||
| 2429 | ULONG_IOCTL(NBD_SET_SIZE) | ||
| 2430 | COMPATIBLE_IOCTL(NBD_DO_IT) | 1369 | COMPATIBLE_IOCTL(NBD_DO_IT) |
| 2431 | COMPATIBLE_IOCTL(NBD_CLEAR_SOCK) | 1370 | COMPATIBLE_IOCTL(NBD_CLEAR_SOCK) |
| 2432 | COMPATIBLE_IOCTL(NBD_CLEAR_QUE) | 1371 | COMPATIBLE_IOCTL(NBD_CLEAR_QUE) |
| 2433 | COMPATIBLE_IOCTL(NBD_PRINT_DEBUG) | 1372 | COMPATIBLE_IOCTL(NBD_PRINT_DEBUG) |
| 2434 | ULONG_IOCTL(NBD_SET_SIZE_BLOCKS) | ||
| 2435 | COMPATIBLE_IOCTL(NBD_DISCONNECT) | 1373 | COMPATIBLE_IOCTL(NBD_DISCONNECT) |
| 2436 | /* i2c */ | 1374 | /* i2c */ |
| 2437 | COMPATIBLE_IOCTL(I2C_SLAVE) | 1375 | COMPATIBLE_IOCTL(I2C_SLAVE) |
| @@ -2531,131 +1469,13 @@ COMPATIBLE_IOCTL(JSIOCGAXES) | |||
| 2531 | COMPATIBLE_IOCTL(JSIOCGBUTTONS) | 1469 | COMPATIBLE_IOCTL(JSIOCGBUTTONS) |
| 2532 | COMPATIBLE_IOCTL(JSIOCGNAME(0)) | 1470 | COMPATIBLE_IOCTL(JSIOCGNAME(0)) |
| 2533 | 1471 | ||
| 2534 | /* now things that need handlers */ | ||
| 2535 | #ifdef CONFIG_NET | ||
| 2536 | HANDLE_IOCTL(SIOCGIFNAME, dev_ifname32) | ||
| 2537 | HANDLE_IOCTL(SIOCGIFCONF, dev_ifconf) | ||
| 2538 | HANDLE_IOCTL(SIOCGIFFLAGS, dev_ifsioc) | ||
| 2539 | HANDLE_IOCTL(SIOCSIFFLAGS, dev_ifsioc) | ||
| 2540 | HANDLE_IOCTL(SIOCGIFMETRIC, dev_ifsioc) | ||
| 2541 | HANDLE_IOCTL(SIOCSIFMETRIC, dev_ifsioc) | ||
| 2542 | HANDLE_IOCTL(SIOCGIFMTU, dev_ifsioc) | ||
| 2543 | HANDLE_IOCTL(SIOCSIFMTU, dev_ifsioc) | ||
| 2544 | HANDLE_IOCTL(SIOCGIFMEM, dev_ifsioc) | ||
| 2545 | HANDLE_IOCTL(SIOCSIFMEM, dev_ifsioc) | ||
| 2546 | HANDLE_IOCTL(SIOCGIFHWADDR, dev_ifsioc) | ||
| 2547 | HANDLE_IOCTL(SIOCSIFHWADDR, dev_ifsioc) | ||
| 2548 | HANDLE_IOCTL(SIOCADDMULTI, dev_ifsioc) | ||
| 2549 | HANDLE_IOCTL(SIOCDELMULTI, dev_ifsioc) | ||
| 2550 | HANDLE_IOCTL(SIOCGIFINDEX, dev_ifsioc) | ||
| 2551 | HANDLE_IOCTL(SIOCGIFMAP, dev_ifsioc) | ||
| 2552 | HANDLE_IOCTL(SIOCSIFMAP, dev_ifsioc) | ||
| 2553 | HANDLE_IOCTL(SIOCGIFADDR, dev_ifsioc) | ||
| 2554 | HANDLE_IOCTL(SIOCSIFADDR, dev_ifsioc) | ||
| 2555 | HANDLE_IOCTL(SIOCSIFHWBROADCAST, dev_ifsioc) | ||
| 2556 | HANDLE_IOCTL(SIOCSHWTSTAMP, dev_ifsioc) | ||
| 2557 | |||
| 2558 | /* ioctls used by appletalk ddp.c */ | ||
| 2559 | HANDLE_IOCTL(SIOCATALKDIFADDR, dev_ifsioc) | ||
| 2560 | HANDLE_IOCTL(SIOCDIFADDR, dev_ifsioc) | ||
| 2561 | HANDLE_IOCTL(SIOCSARP, dev_ifsioc) | ||
| 2562 | HANDLE_IOCTL(SIOCDARP, dev_ifsioc) | ||
| 2563 | |||
| 2564 | HANDLE_IOCTL(SIOCGIFBRDADDR, dev_ifsioc) | ||
| 2565 | HANDLE_IOCTL(SIOCSIFBRDADDR, dev_ifsioc) | ||
| 2566 | HANDLE_IOCTL(SIOCGIFDSTADDR, dev_ifsioc) | ||
| 2567 | HANDLE_IOCTL(SIOCSIFDSTADDR, dev_ifsioc) | ||
| 2568 | HANDLE_IOCTL(SIOCGIFNETMASK, dev_ifsioc) | ||
| 2569 | HANDLE_IOCTL(SIOCSIFNETMASK, dev_ifsioc) | ||
| 2570 | HANDLE_IOCTL(SIOCSIFPFLAGS, dev_ifsioc) | ||
| 2571 | HANDLE_IOCTL(SIOCGIFPFLAGS, dev_ifsioc) | ||
| 2572 | HANDLE_IOCTL(SIOCGIFTXQLEN, dev_ifsioc) | ||
| 2573 | HANDLE_IOCTL(SIOCSIFTXQLEN, dev_ifsioc) | ||
| 2574 | HANDLE_IOCTL(TUNSETIFF, dev_ifsioc) | ||
| 2575 | HANDLE_IOCTL(TUNGETIFF, dev_ifsioc) | ||
| 2576 | HANDLE_IOCTL(SIOCETHTOOL, ethtool_ioctl) | ||
| 2577 | HANDLE_IOCTL(SIOCBONDENSLAVE, bond_ioctl) | ||
| 2578 | HANDLE_IOCTL(SIOCBONDRELEASE, bond_ioctl) | ||
| 2579 | HANDLE_IOCTL(SIOCBONDSETHWADDR, bond_ioctl) | ||
| 2580 | HANDLE_IOCTL(SIOCBONDSLAVEINFOQUERY, bond_ioctl) | ||
| 2581 | HANDLE_IOCTL(SIOCBONDINFOQUERY, bond_ioctl) | ||
| 2582 | HANDLE_IOCTL(SIOCBONDCHANGEACTIVE, bond_ioctl) | ||
| 2583 | HANDLE_IOCTL(SIOCADDRT, routing_ioctl) | ||
| 2584 | HANDLE_IOCTL(SIOCDELRT, routing_ioctl) | ||
| 2585 | HANDLE_IOCTL(SIOCBRADDIF, dev_ifsioc) | ||
| 2586 | HANDLE_IOCTL(SIOCBRDELIF, dev_ifsioc) | ||
| 2587 | /* Note SIOCRTMSG is no longer, so this is safe and * the user would have seen just an -EINVAL anyways. */ | ||
| 2588 | HANDLE_IOCTL(SIOCRTMSG, ret_einval) | ||
| 2589 | HANDLE_IOCTL(SIOCGSTAMP, do_siocgstamp) | ||
| 2590 | HANDLE_IOCTL(SIOCGSTAMPNS, do_siocgstampns) | ||
| 2591 | #endif | ||
| 2592 | #ifdef CONFIG_BLOCK | ||
| 2593 | HANDLE_IOCTL(SG_IO,sg_ioctl_trans) | ||
| 2594 | HANDLE_IOCTL(SG_GET_REQUEST_TABLE, sg_grt_trans) | ||
| 2595 | #endif | ||
| 2596 | HANDLE_IOCTL(PPPIOCGIDLE32, ppp_ioctl_trans) | ||
| 2597 | HANDLE_IOCTL(PPPIOCSCOMPRESS32, ppp_ioctl_trans) | ||
| 2598 | HANDLE_IOCTL(PPPIOCSPASS32, ppp_sock_fprog_ioctl_trans) | ||
| 2599 | HANDLE_IOCTL(PPPIOCSACTIVE32, ppp_sock_fprog_ioctl_trans) | ||
| 2600 | #ifdef CONFIG_BLOCK | ||
| 2601 | HANDLE_IOCTL(MTIOCGET32, mt_ioctl_trans) | ||
| 2602 | HANDLE_IOCTL(MTIOCPOS32, mt_ioctl_trans) | ||
| 2603 | #endif | ||
| 2604 | #define AUTOFS_IOC_SETTIMEOUT32 _IOWR(0x93,0x64,unsigned int) | ||
| 2605 | HANDLE_IOCTL(AUTOFS_IOC_SETTIMEOUT32, ioc_settimeout) | ||
| 2606 | #ifdef CONFIG_VT | ||
| 2607 | HANDLE_IOCTL(PIO_FONTX, do_fontx_ioctl) | ||
| 2608 | HANDLE_IOCTL(GIO_FONTX, do_fontx_ioctl) | ||
| 2609 | HANDLE_IOCTL(PIO_UNIMAP, do_unimap_ioctl) | ||
| 2610 | HANDLE_IOCTL(GIO_UNIMAP, do_unimap_ioctl) | ||
| 2611 | HANDLE_IOCTL(KDFONTOP, do_kdfontop_ioctl) | ||
| 2612 | #endif | ||
| 2613 | /* One SMB ioctl needs translations. */ | ||
| 2614 | #define SMB_IOC_GETMOUNTUID_32 _IOR('u', 1, compat_uid_t) | ||
| 2615 | HANDLE_IOCTL(SMB_IOC_GETMOUNTUID_32, do_smb_getmountuid) | ||
| 2616 | HANDLE_IOCTL(ATM_GETLINKRATE32, do_atm_ioctl) | ||
| 2617 | HANDLE_IOCTL(ATM_GETNAMES32, do_atm_ioctl) | ||
| 2618 | HANDLE_IOCTL(ATM_GETTYPE32, do_atm_ioctl) | ||
| 2619 | HANDLE_IOCTL(ATM_GETESI32, do_atm_ioctl) | ||
| 2620 | HANDLE_IOCTL(ATM_GETADDR32, do_atm_ioctl) | ||
| 2621 | HANDLE_IOCTL(ATM_RSTADDR32, do_atm_ioctl) | ||
| 2622 | HANDLE_IOCTL(ATM_ADDADDR32, do_atm_ioctl) | ||
| 2623 | HANDLE_IOCTL(ATM_DELADDR32, do_atm_ioctl) | ||
| 2624 | HANDLE_IOCTL(ATM_GETCIRANGE32, do_atm_ioctl) | ||
| 2625 | HANDLE_IOCTL(ATM_SETCIRANGE32, do_atm_ioctl) | ||
| 2626 | HANDLE_IOCTL(ATM_SETESI32, do_atm_ioctl) | ||
| 2627 | HANDLE_IOCTL(ATM_SETESIF32, do_atm_ioctl) | ||
| 2628 | HANDLE_IOCTL(ATM_GETSTAT32, do_atm_ioctl) | ||
| 2629 | HANDLE_IOCTL(ATM_GETSTATZ32, do_atm_ioctl) | ||
| 2630 | HANDLE_IOCTL(ATM_GETLOOP32, do_atm_ioctl) | ||
| 2631 | HANDLE_IOCTL(ATM_SETLOOP32, do_atm_ioctl) | ||
| 2632 | HANDLE_IOCTL(ATM_QUERYLOOP32, do_atm_ioctl) | ||
| 2633 | HANDLE_IOCTL(SONET_GETSTAT, do_atm_ioctl) | ||
| 2634 | HANDLE_IOCTL(SONET_GETSTATZ, do_atm_ioctl) | ||
| 2635 | HANDLE_IOCTL(SONET_GETDIAG, do_atm_ioctl) | ||
| 2636 | HANDLE_IOCTL(SONET_SETDIAG, do_atm_ioctl) | ||
| 2637 | HANDLE_IOCTL(SONET_CLRDIAG, do_atm_ioctl) | ||
| 2638 | HANDLE_IOCTL(SONET_SETFRAMING, do_atm_ioctl) | ||
| 2639 | HANDLE_IOCTL(SONET_GETFRAMING, do_atm_ioctl) | ||
| 2640 | HANDLE_IOCTL(SONET_GETFRSENSE, do_atm_ioctl) | ||
| 2641 | /* block stuff */ | ||
| 2642 | #ifdef CONFIG_BLOCK | ||
| 2643 | /* loop */ | ||
| 2644 | IGNORE_IOCTL(LOOP_CLR_FD) | ||
| 2645 | /* Raw devices */ | ||
| 2646 | HANDLE_IOCTL(RAW_SETBIND, raw_ioctl) | ||
| 2647 | HANDLE_IOCTL(RAW_GETBIND, raw_ioctl) | ||
| 2648 | #endif | ||
| 2649 | /* Serial */ | ||
| 2650 | HANDLE_IOCTL(TIOCGSERIAL, serial_struct_ioctl) | ||
| 2651 | HANDLE_IOCTL(TIOCSSERIAL, serial_struct_ioctl) | ||
| 2652 | #ifdef TIOCGLTC | 1472 | #ifdef TIOCGLTC |
| 2653 | COMPATIBLE_IOCTL(TIOCGLTC) | 1473 | COMPATIBLE_IOCTL(TIOCGLTC) |
| 2654 | COMPATIBLE_IOCTL(TIOCSLTC) | 1474 | COMPATIBLE_IOCTL(TIOCSLTC) |
| 2655 | #endif | 1475 | #endif |
| 2656 | #ifdef TIOCSTART | 1476 | #ifdef TIOCSTART |
| 2657 | /* | 1477 | /* |
| 2658 | * For these two we have defintions in ioctls.h and/or termios.h on | 1478 | * For these two we have definitions in ioctls.h and/or termios.h on |
| 2659 | * some architectures but no actual implemention. Some applications | 1479 | * some architectures but no actual implemention. Some applications |
| 2660 | * like bash call them if they are defined in the headers, so we provide | 1480 | * like bash call them if they are defined in the headers, so we provide |
| 2661 | * entries here to avoid syslog message spew. | 1481 | * entries here to avoid syslog message spew. |
| @@ -2663,43 +1483,6 @@ COMPATIBLE_IOCTL(TIOCSLTC) | |||
| 2663 | COMPATIBLE_IOCTL(TIOCSTART) | 1483 | COMPATIBLE_IOCTL(TIOCSTART) |
| 2664 | COMPATIBLE_IOCTL(TIOCSTOP) | 1484 | COMPATIBLE_IOCTL(TIOCSTOP) |
| 2665 | #endif | 1485 | #endif |
| 2666 | /* Usbdevfs */ | ||
| 2667 | HANDLE_IOCTL(USBDEVFS_CONTROL32, do_usbdevfs_control) | ||
| 2668 | HANDLE_IOCTL(USBDEVFS_BULK32, do_usbdevfs_bulk) | ||
| 2669 | HANDLE_IOCTL(USBDEVFS_DISCSIGNAL32, do_usbdevfs_discsignal) | ||
| 2670 | COMPATIBLE_IOCTL(USBDEVFS_IOCTL32) | ||
| 2671 | /* i2c */ | ||
| 2672 | HANDLE_IOCTL(I2C_FUNCS, w_long) | ||
| 2673 | HANDLE_IOCTL(I2C_RDWR, do_i2c_rdwr_ioctl) | ||
| 2674 | HANDLE_IOCTL(I2C_SMBUS, do_i2c_smbus_ioctl) | ||
| 2675 | /* bridge */ | ||
| 2676 | HANDLE_IOCTL(SIOCSIFBR, old_bridge_ioctl) | ||
| 2677 | HANDLE_IOCTL(SIOCGIFBR, old_bridge_ioctl) | ||
| 2678 | /* Not implemented in the native kernel */ | ||
| 2679 | IGNORE_IOCTL(SIOCGIFCOUNT) | ||
| 2680 | HANDLE_IOCTL(RTC_IRQP_READ32, rtc_ioctl) | ||
| 2681 | HANDLE_IOCTL(RTC_IRQP_SET32, rtc_ioctl) | ||
| 2682 | HANDLE_IOCTL(RTC_EPOCH_READ32, rtc_ioctl) | ||
| 2683 | HANDLE_IOCTL(RTC_EPOCH_SET32, rtc_ioctl) | ||
| 2684 | |||
| 2685 | /* dvb */ | ||
| 2686 | HANDLE_IOCTL(VIDEO_GET_EVENT, do_video_get_event) | ||
| 2687 | HANDLE_IOCTL(VIDEO_STILLPICTURE, do_video_stillpicture) | ||
| 2688 | HANDLE_IOCTL(VIDEO_SET_SPU_PALETTE, do_video_set_spu_palette) | ||
| 2689 | |||
| 2690 | /* parport */ | ||
| 2691 | COMPATIBLE_IOCTL(LPTIME) | ||
| 2692 | COMPATIBLE_IOCTL(LPCHAR) | ||
| 2693 | COMPATIBLE_IOCTL(LPABORTOPEN) | ||
| 2694 | COMPATIBLE_IOCTL(LPCAREFUL) | ||
| 2695 | COMPATIBLE_IOCTL(LPWAIT) | ||
| 2696 | COMPATIBLE_IOCTL(LPSETIRQ) | ||
| 2697 | COMPATIBLE_IOCTL(LPGETSTATUS) | ||
| 2698 | COMPATIBLE_IOCTL(LPGETSTATUS) | ||
| 2699 | COMPATIBLE_IOCTL(LPRESET) | ||
| 2700 | /*LPGETSTATS not implemented, but no kernels seem to compile it in anyways*/ | ||
| 2701 | COMPATIBLE_IOCTL(LPGETFLAGS) | ||
| 2702 | HANDLE_IOCTL(LPSETTIMEOUT, lp_timeout_trans) | ||
| 2703 | 1486 | ||
| 2704 | /* fat 'r' ioctls. These are handled by fat with ->compat_ioctl, | 1487 | /* fat 'r' ioctls. These are handled by fat with ->compat_ioctl, |
| 2705 | but we don't want warnings on other file systems. So declare | 1488 | but we don't want warnings on other file systems. So declare |
| @@ -2727,12 +1510,110 @@ IGNORE_IOCTL(FBIOGCURSOR32) | |||
| 2727 | #endif | 1510 | #endif |
| 2728 | }; | 1511 | }; |
| 2729 | 1512 | ||
| 2730 | #define IOCTL_HASHSIZE 256 | 1513 | /* |
| 2731 | static struct ioctl_trans *ioctl32_hash_table[IOCTL_HASHSIZE]; | 1514 | * Convert common ioctl arguments based on their command number |
| 2732 | 1515 | * | |
| 2733 | static inline unsigned long ioctl32_hash(unsigned long cmd) | 1516 | * Please do not add any code in here. Instead, implement |
| 1517 | * a compat_ioctl operation in the place that handleѕ the | ||
| 1518 | * ioctl for the native case. | ||
| 1519 | */ | ||
| 1520 | static long do_ioctl_trans(int fd, unsigned int cmd, | ||
| 1521 | unsigned long arg, struct file *file) | ||
| 2734 | { | 1522 | { |
| 2735 | return (((cmd >> 6) ^ (cmd >> 4) ^ cmd)) % IOCTL_HASHSIZE; | 1523 | void __user *argp = compat_ptr(arg); |
| 1524 | |||
| 1525 | switch (cmd) { | ||
| 1526 | case PPPIOCGIDLE32: | ||
| 1527 | return ppp_gidle(fd, cmd, argp); | ||
| 1528 | case PPPIOCSCOMPRESS32: | ||
| 1529 | return ppp_scompress(fd, cmd, argp); | ||
| 1530 | case PPPIOCSPASS32: | ||
| 1531 | case PPPIOCSACTIVE32: | ||
| 1532 | return ppp_sock_fprog_ioctl_trans(fd, cmd, argp); | ||
| 1533 | #ifdef CONFIG_BLOCK | ||
| 1534 | case SG_IO: | ||
| 1535 | return sg_ioctl_trans(fd, cmd, argp); | ||
| 1536 | case SG_GET_REQUEST_TABLE: | ||
| 1537 | return sg_grt_trans(fd, cmd, argp); | ||
| 1538 | case MTIOCGET32: | ||
| 1539 | case MTIOCPOS32: | ||
| 1540 | return mt_ioctl_trans(fd, cmd, argp); | ||
| 1541 | /* Raw devices */ | ||
| 1542 | case RAW_SETBIND: | ||
| 1543 | case RAW_GETBIND: | ||
| 1544 | return raw_ioctl(fd, cmd, argp); | ||
| 1545 | #endif | ||
| 1546 | #define AUTOFS_IOC_SETTIMEOUT32 _IOWR(0x93,0x64,unsigned int) | ||
| 1547 | case AUTOFS_IOC_SETTIMEOUT32: | ||
| 1548 | return ioc_settimeout(fd, cmd, argp); | ||
| 1549 | /* One SMB ioctl needs translations. */ | ||
| 1550 | #define SMB_IOC_GETMOUNTUID_32 _IOR('u', 1, compat_uid_t) | ||
| 1551 | case SMB_IOC_GETMOUNTUID_32: | ||
| 1552 | return do_smb_getmountuid(fd, cmd, argp); | ||
| 1553 | /* Serial */ | ||
| 1554 | case TIOCGSERIAL: | ||
| 1555 | case TIOCSSERIAL: | ||
| 1556 | return serial_struct_ioctl(fd, cmd, argp); | ||
| 1557 | /* i2c */ | ||
| 1558 | case I2C_FUNCS: | ||
| 1559 | return w_long(fd, cmd, argp); | ||
| 1560 | case I2C_RDWR: | ||
| 1561 | return do_i2c_rdwr_ioctl(fd, cmd, argp); | ||
| 1562 | case I2C_SMBUS: | ||
| 1563 | return do_i2c_smbus_ioctl(fd, cmd, argp); | ||
| 1564 | /* Not implemented in the native kernel */ | ||
| 1565 | case RTC_IRQP_READ32: | ||
| 1566 | case RTC_IRQP_SET32: | ||
| 1567 | case RTC_EPOCH_READ32: | ||
| 1568 | case RTC_EPOCH_SET32: | ||
| 1569 | return rtc_ioctl(fd, cmd, argp); | ||
| 1570 | |||
| 1571 | /* dvb */ | ||
| 1572 | case VIDEO_GET_EVENT: | ||
| 1573 | return do_video_get_event(fd, cmd, argp); | ||
| 1574 | case VIDEO_STILLPICTURE: | ||
| 1575 | return do_video_stillpicture(fd, cmd, argp); | ||
| 1576 | case VIDEO_SET_SPU_PALETTE: | ||
| 1577 | return do_video_set_spu_palette(fd, cmd, argp); | ||
| 1578 | } | ||
| 1579 | |||
| 1580 | /* | ||
| 1581 | * These take an integer instead of a pointer as 'arg', | ||
| 1582 | * so we must not do a compat_ptr() translation. | ||
| 1583 | */ | ||
| 1584 | switch (cmd) { | ||
| 1585 | /* Big T */ | ||
| 1586 | case TCSBRKP: | ||
| 1587 | case TIOCMIWAIT: | ||
| 1588 | case TIOCSCTTY: | ||
| 1589 | /* RAID */ | ||
| 1590 | case HOT_REMOVE_DISK: | ||
| 1591 | case HOT_ADD_DISK: | ||
| 1592 | case SET_DISK_FAULTY: | ||
| 1593 | case SET_BITMAP_FILE: | ||
| 1594 | /* Big K */ | ||
| 1595 | case KDSIGACCEPT: | ||
| 1596 | case KIOCSOUND: | ||
| 1597 | case KDMKTONE: | ||
| 1598 | case KDSETMODE: | ||
| 1599 | case KDSKBMODE: | ||
| 1600 | case KDSKBMETA: | ||
| 1601 | case KDSKBLED: | ||
| 1602 | case KDSETLED: | ||
| 1603 | /* SG stuff */ | ||
| 1604 | case SG_SET_TRANSFORM: | ||
| 1605 | /* AUTOFS */ | ||
| 1606 | case AUTOFS_IOC_READY: | ||
| 1607 | case AUTOFS_IOC_FAIL: | ||
| 1608 | /* NBD */ | ||
| 1609 | case NBD_SET_SOCK: | ||
| 1610 | case NBD_SET_BLKSIZE: | ||
| 1611 | case NBD_SET_SIZE: | ||
| 1612 | case NBD_SET_SIZE_BLOCKS: | ||
| 1613 | return do_vfs_ioctl(file, fd, cmd, arg); | ||
| 1614 | } | ||
| 1615 | |||
| 1616 | return -ENOIOCTLCMD; | ||
| 2736 | } | 1617 | } |
| 2737 | 1618 | ||
| 2738 | static void compat_ioctl_error(struct file *filp, unsigned int fd, | 1619 | static void compat_ioctl_error(struct file *filp, unsigned int fd, |
| @@ -2764,12 +1645,33 @@ static void compat_ioctl_error(struct file *filp, unsigned int fd, | |||
| 2764 | free_page((unsigned long)path); | 1645 | free_page((unsigned long)path); |
| 2765 | } | 1646 | } |
| 2766 | 1647 | ||
| 1648 | static int compat_ioctl_check_table(unsigned int xcmd) | ||
| 1649 | { | ||
| 1650 | int i; | ||
| 1651 | const int max = ARRAY_SIZE(ioctl_pointer) - 1; | ||
| 1652 | |||
| 1653 | BUILD_BUG_ON(max >= (1 << 16)); | ||
| 1654 | |||
| 1655 | /* guess initial offset into table, assuming a | ||
| 1656 | normalized distribution */ | ||
| 1657 | i = ((xcmd >> 16) * max) >> 16; | ||
| 1658 | |||
| 1659 | /* do linear search up first, until greater or equal */ | ||
| 1660 | while (ioctl_pointer[i] < xcmd && i < max) | ||
| 1661 | i++; | ||
| 1662 | |||
| 1663 | /* then do linear search down */ | ||
| 1664 | while (ioctl_pointer[i] > xcmd && i > 0) | ||
| 1665 | i--; | ||
| 1666 | |||
| 1667 | return ioctl_pointer[i] == xcmd; | ||
| 1668 | } | ||
| 1669 | |||
| 2767 | asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | 1670 | asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, |
| 2768 | unsigned long arg) | 1671 | unsigned long arg) |
| 2769 | { | 1672 | { |
| 2770 | struct file *filp; | 1673 | struct file *filp; |
| 2771 | int error = -EBADF; | 1674 | int error = -EBADF; |
| 2772 | struct ioctl_trans *t; | ||
| 2773 | int fput_needed; | 1675 | int fput_needed; |
| 2774 | 1676 | ||
| 2775 | filp = fget_light(fd, &fput_needed); | 1677 | filp = fget_light(fd, &fput_needed); |
| @@ -2797,7 +1699,7 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | |||
| 2797 | #if defined(CONFIG_IA64) || defined(CONFIG_X86_64) | 1699 | #if defined(CONFIG_IA64) || defined(CONFIG_X86_64) |
| 2798 | case FS_IOC_RESVSP_32: | 1700 | case FS_IOC_RESVSP_32: |
| 2799 | case FS_IOC_RESVSP64_32: | 1701 | case FS_IOC_RESVSP64_32: |
| 2800 | error = compat_ioctl_preallocate(filp, arg); | 1702 | error = compat_ioctl_preallocate(filp, compat_ptr(arg)); |
| 2801 | goto out_fput; | 1703 | goto out_fput; |
| 2802 | #else | 1704 | #else |
| 2803 | case FS_IOC_RESVSP: | 1705 | case FS_IOC_RESVSP: |
| @@ -2826,18 +1728,11 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | |||
| 2826 | break; | 1728 | break; |
| 2827 | } | 1729 | } |
| 2828 | 1730 | ||
| 2829 | for (t = ioctl32_hash_table[ioctl32_hash(cmd)]; t; t = t->next) { | 1731 | if (compat_ioctl_check_table(XFORM(cmd))) |
| 2830 | if (t->cmd == cmd) | 1732 | goto found_handler; |
| 2831 | goto found_handler; | ||
| 2832 | } | ||
| 2833 | 1733 | ||
| 2834 | #ifdef CONFIG_NET | 1734 | error = do_ioctl_trans(fd, cmd, arg, filp); |
| 2835 | if (S_ISSOCK(filp->f_path.dentry->d_inode->i_mode) && | 1735 | if (error == -ENOIOCTLCMD) { |
| 2836 | cmd >= SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE + 15)) { | ||
| 2837 | error = siocdevprivate_ioctl(fd, cmd, arg); | ||
| 2838 | } else | ||
| 2839 | #endif | ||
| 2840 | { | ||
| 2841 | static int count; | 1736 | static int count; |
| 2842 | 1737 | ||
| 2843 | if (++count <= 50) | 1738 | if (++count <= 50) |
| @@ -2848,13 +1743,7 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | |||
| 2848 | goto out_fput; | 1743 | goto out_fput; |
| 2849 | 1744 | ||
| 2850 | found_handler: | 1745 | found_handler: |
| 2851 | if (t->handler) { | 1746 | arg = (unsigned long)compat_ptr(arg); |
| 2852 | lock_kernel(); | ||
| 2853 | error = t->handler(fd, cmd, arg, filp); | ||
| 2854 | unlock_kernel(); | ||
| 2855 | goto out_fput; | ||
| 2856 | } | ||
| 2857 | |||
| 2858 | do_ioctl: | 1747 | do_ioctl: |
| 2859 | error = do_vfs_ioctl(filp, fd, cmd, arg); | 1748 | error = do_vfs_ioctl(filp, fd, cmd, arg); |
| 2860 | out_fput: | 1749 | out_fput: |
| @@ -2863,35 +1752,22 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, | |||
| 2863 | return error; | 1752 | return error; |
| 2864 | } | 1753 | } |
| 2865 | 1754 | ||
| 2866 | static void ioctl32_insert_translation(struct ioctl_trans *trans) | 1755 | static int __init init_sys32_ioctl_cmp(const void *p, const void *q) |
| 2867 | { | 1756 | { |
| 2868 | unsigned long hash; | 1757 | unsigned int a, b; |
| 2869 | struct ioctl_trans *t; | 1758 | a = *(unsigned int *)p; |
| 2870 | 1759 | b = *(unsigned int *)q; | |
| 2871 | hash = ioctl32_hash (trans->cmd); | 1760 | if (a > b) |
| 2872 | if (!ioctl32_hash_table[hash]) | 1761 | return 1; |
| 2873 | ioctl32_hash_table[hash] = trans; | 1762 | if (a < b) |
| 2874 | else { | 1763 | return -1; |
| 2875 | t = ioctl32_hash_table[hash]; | 1764 | return 0; |
| 2876 | while (t->next) | ||
| 2877 | t = t->next; | ||
| 2878 | trans->next = NULL; | ||
| 2879 | t->next = trans; | ||
| 2880 | } | ||
| 2881 | } | 1765 | } |
| 2882 | 1766 | ||
| 2883 | static int __init init_sys32_ioctl(void) | 1767 | static int __init init_sys32_ioctl(void) |
| 2884 | { | 1768 | { |
| 2885 | int i; | 1769 | sort(ioctl_pointer, ARRAY_SIZE(ioctl_pointer), sizeof(*ioctl_pointer), |
| 2886 | 1770 | init_sys32_ioctl_cmp, NULL); | |
| 2887 | for (i = 0; i < ARRAY_SIZE(ioctl_start); i++) { | ||
| 2888 | if (ioctl_start[i].next) { | ||
| 2889 | printk("ioctl translation %d bad\n",i); | ||
| 2890 | return -1; | ||
| 2891 | } | ||
| 2892 | |||
| 2893 | ioctl32_insert_translation(&ioctl_start[i]); | ||
| 2894 | } | ||
| 2895 | return 0; | 1771 | return 0; |
| 2896 | } | 1772 | } |
| 2897 | __initcall(init_sys32_ioctl); | 1773 | __initcall(init_sys32_ioctl); |
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index d22438ef7674..b486169f42bf 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
| @@ -32,7 +32,9 @@ static struct vfsmount *debugfs_mount; | |||
| 32 | static int debugfs_mount_count; | 32 | static int debugfs_mount_count; |
| 33 | static bool debugfs_registered; | 33 | static bool debugfs_registered; |
| 34 | 34 | ||
| 35 | static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t dev) | 35 | static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t dev, |
| 36 | void *data, const struct file_operations *fops) | ||
| 37 | |||
| 36 | { | 38 | { |
| 37 | struct inode *inode = new_inode(sb); | 39 | struct inode *inode = new_inode(sb); |
| 38 | 40 | ||
| @@ -44,14 +46,18 @@ static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t d | |||
| 44 | init_special_inode(inode, mode, dev); | 46 | init_special_inode(inode, mode, dev); |
| 45 | break; | 47 | break; |
| 46 | case S_IFREG: | 48 | case S_IFREG: |
| 47 | inode->i_fop = &debugfs_file_operations; | 49 | inode->i_fop = fops ? fops : &debugfs_file_operations; |
| 50 | inode->i_private = data; | ||
| 48 | break; | 51 | break; |
| 49 | case S_IFLNK: | 52 | case S_IFLNK: |
| 50 | inode->i_op = &debugfs_link_operations; | 53 | inode->i_op = &debugfs_link_operations; |
| 54 | inode->i_fop = fops; | ||
| 55 | inode->i_private = data; | ||
| 51 | break; | 56 | break; |
| 52 | case S_IFDIR: | 57 | case S_IFDIR: |
| 53 | inode->i_op = &simple_dir_inode_operations; | 58 | inode->i_op = &simple_dir_inode_operations; |
| 54 | inode->i_fop = &simple_dir_operations; | 59 | inode->i_fop = fops ? fops : &simple_dir_operations; |
| 60 | inode->i_private = data; | ||
| 55 | 61 | ||
| 56 | /* directory inodes start off with i_nlink == 2 | 62 | /* directory inodes start off with i_nlink == 2 |
| 57 | * (for "." entry) */ | 63 | * (for "." entry) */ |
| @@ -64,7 +70,8 @@ static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t d | |||
| 64 | 70 | ||
| 65 | /* SMP-safe */ | 71 | /* SMP-safe */ |
| 66 | static int debugfs_mknod(struct inode *dir, struct dentry *dentry, | 72 | static int debugfs_mknod(struct inode *dir, struct dentry *dentry, |
| 67 | int mode, dev_t dev) | 73 | int mode, dev_t dev, void *data, |
| 74 | const struct file_operations *fops) | ||
| 68 | { | 75 | { |
| 69 | struct inode *inode; | 76 | struct inode *inode; |
| 70 | int error = -EPERM; | 77 | int error = -EPERM; |
| @@ -72,7 +79,7 @@ static int debugfs_mknod(struct inode *dir, struct dentry *dentry, | |||
| 72 | if (dentry->d_inode) | 79 | if (dentry->d_inode) |
| 73 | return -EEXIST; | 80 | return -EEXIST; |
| 74 | 81 | ||
| 75 | inode = debugfs_get_inode(dir->i_sb, mode, dev); | 82 | inode = debugfs_get_inode(dir->i_sb, mode, dev, data, fops); |
| 76 | if (inode) { | 83 | if (inode) { |
| 77 | d_instantiate(dentry, inode); | 84 | d_instantiate(dentry, inode); |
| 78 | dget(dentry); | 85 | dget(dentry); |
| @@ -81,12 +88,13 @@ static int debugfs_mknod(struct inode *dir, struct dentry *dentry, | |||
| 81 | return error; | 88 | return error; |
| 82 | } | 89 | } |
| 83 | 90 | ||
| 84 | static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | 91 | static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, |
| 92 | void *data, const struct file_operations *fops) | ||
| 85 | { | 93 | { |
| 86 | int res; | 94 | int res; |
| 87 | 95 | ||
| 88 | mode = (mode & (S_IRWXUGO | S_ISVTX)) | S_IFDIR; | 96 | mode = (mode & (S_IRWXUGO | S_ISVTX)) | S_IFDIR; |
| 89 | res = debugfs_mknod(dir, dentry, mode, 0); | 97 | res = debugfs_mknod(dir, dentry, mode, 0, data, fops); |
| 90 | if (!res) { | 98 | if (!res) { |
| 91 | inc_nlink(dir); | 99 | inc_nlink(dir); |
| 92 | fsnotify_mkdir(dir, dentry); | 100 | fsnotify_mkdir(dir, dentry); |
| @@ -94,18 +102,20 @@ static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 94 | return res; | 102 | return res; |
| 95 | } | 103 | } |
| 96 | 104 | ||
| 97 | static int debugfs_link(struct inode *dir, struct dentry *dentry, int mode) | 105 | static int debugfs_link(struct inode *dir, struct dentry *dentry, int mode, |
| 106 | void *data, const struct file_operations *fops) | ||
| 98 | { | 107 | { |
| 99 | mode = (mode & S_IALLUGO) | S_IFLNK; | 108 | mode = (mode & S_IALLUGO) | S_IFLNK; |
| 100 | return debugfs_mknod(dir, dentry, mode, 0); | 109 | return debugfs_mknod(dir, dentry, mode, 0, data, fops); |
| 101 | } | 110 | } |
| 102 | 111 | ||
| 103 | static int debugfs_create(struct inode *dir, struct dentry *dentry, int mode) | 112 | static int debugfs_create(struct inode *dir, struct dentry *dentry, int mode, |
| 113 | void *data, const struct file_operations *fops) | ||
| 104 | { | 114 | { |
| 105 | int res; | 115 | int res; |
| 106 | 116 | ||
| 107 | mode = (mode & S_IALLUGO) | S_IFREG; | 117 | mode = (mode & S_IALLUGO) | S_IFREG; |
| 108 | res = debugfs_mknod(dir, dentry, mode, 0); | 118 | res = debugfs_mknod(dir, dentry, mode, 0, data, fops); |
| 109 | if (!res) | 119 | if (!res) |
| 110 | fsnotify_create(dir, dentry); | 120 | fsnotify_create(dir, dentry); |
| 111 | return res; | 121 | return res; |
| @@ -139,7 +149,9 @@ static struct file_system_type debug_fs_type = { | |||
| 139 | 149 | ||
| 140 | static int debugfs_create_by_name(const char *name, mode_t mode, | 150 | static int debugfs_create_by_name(const char *name, mode_t mode, |
| 141 | struct dentry *parent, | 151 | struct dentry *parent, |
| 142 | struct dentry **dentry) | 152 | struct dentry **dentry, |
| 153 | void *data, | ||
| 154 | const struct file_operations *fops) | ||
| 143 | { | 155 | { |
| 144 | int error = 0; | 156 | int error = 0; |
| 145 | 157 | ||
| @@ -164,13 +176,16 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
| 164 | if (!IS_ERR(*dentry)) { | 176 | if (!IS_ERR(*dentry)) { |
| 165 | switch (mode & S_IFMT) { | 177 | switch (mode & S_IFMT) { |
| 166 | case S_IFDIR: | 178 | case S_IFDIR: |
| 167 | error = debugfs_mkdir(parent->d_inode, *dentry, mode); | 179 | error = debugfs_mkdir(parent->d_inode, *dentry, mode, |
| 180 | data, fops); | ||
| 168 | break; | 181 | break; |
| 169 | case S_IFLNK: | 182 | case S_IFLNK: |
| 170 | error = debugfs_link(parent->d_inode, *dentry, mode); | 183 | error = debugfs_link(parent->d_inode, *dentry, mode, |
| 184 | data, fops); | ||
| 171 | break; | 185 | break; |
| 172 | default: | 186 | default: |
| 173 | error = debugfs_create(parent->d_inode, *dentry, mode); | 187 | error = debugfs_create(parent->d_inode, *dentry, mode, |
| 188 | data, fops); | ||
| 174 | break; | 189 | break; |
| 175 | } | 190 | } |
| 176 | dput(*dentry); | 191 | dput(*dentry); |
| @@ -184,7 +199,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
| 184 | /** | 199 | /** |
| 185 | * debugfs_create_file - create a file in the debugfs filesystem | 200 | * debugfs_create_file - create a file in the debugfs filesystem |
| 186 | * @name: a pointer to a string containing the name of the file to create. | 201 | * @name: a pointer to a string containing the name of the file to create. |
| 187 | * @mode: the permission that the file should have | 202 | * @mode: the permission that the file should have. |
| 188 | * @parent: a pointer to the parent dentry for this file. This should be a | 203 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 189 | * directory dentry if set. If this paramater is NULL, then the | 204 | * directory dentry if set. If this paramater is NULL, then the |
| 190 | * file will be created in the root of the debugfs filesystem. | 205 | * file will be created in the root of the debugfs filesystem. |
| @@ -195,8 +210,8 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
| 195 | * this file. | 210 | * this file. |
| 196 | * | 211 | * |
| 197 | * This is the basic "create a file" function for debugfs. It allows for a | 212 | * This is the basic "create a file" function for debugfs. It allows for a |
| 198 | * wide range of flexibility in createing a file, or a directory (if you | 213 | * wide range of flexibility in creating a file, or a directory (if you want |
| 199 | * want to create a directory, the debugfs_create_dir() function is | 214 | * to create a directory, the debugfs_create_dir() function is |
| 200 | * recommended to be used instead.) | 215 | * recommended to be used instead.) |
| 201 | * | 216 | * |
| 202 | * This function will return a pointer to a dentry if it succeeds. This | 217 | * This function will return a pointer to a dentry if it succeeds. This |
| @@ -221,19 +236,13 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode, | |||
| 221 | if (error) | 236 | if (error) |
| 222 | goto exit; | 237 | goto exit; |
| 223 | 238 | ||
| 224 | error = debugfs_create_by_name(name, mode, parent, &dentry); | 239 | error = debugfs_create_by_name(name, mode, parent, &dentry, |
| 240 | data, fops); | ||
| 225 | if (error) { | 241 | if (error) { |
| 226 | dentry = NULL; | 242 | dentry = NULL; |
| 227 | simple_release_fs(&debugfs_mount, &debugfs_mount_count); | 243 | simple_release_fs(&debugfs_mount, &debugfs_mount_count); |
| 228 | goto exit; | 244 | goto exit; |
| 229 | } | 245 | } |
| 230 | |||
| 231 | if (dentry->d_inode) { | ||
| 232 | if (data) | ||
| 233 | dentry->d_inode->i_private = data; | ||
| 234 | if (fops) | ||
| 235 | dentry->d_inode->i_fop = fops; | ||
| 236 | } | ||
| 237 | exit: | 246 | exit: |
| 238 | return dentry; | 247 | return dentry; |
| 239 | } | 248 | } |
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index d5f8c96964be..8882ecc0f1bf 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c | |||
| @@ -517,11 +517,23 @@ int devpts_pty_new(struct inode *ptmx_inode, struct tty_struct *tty) | |||
| 517 | 517 | ||
| 518 | struct tty_struct *devpts_get_tty(struct inode *pts_inode, int number) | 518 | struct tty_struct *devpts_get_tty(struct inode *pts_inode, int number) |
| 519 | { | 519 | { |
| 520 | struct dentry *dentry; | ||
| 521 | struct tty_struct *tty; | ||
| 522 | |||
| 520 | BUG_ON(pts_inode->i_rdev == MKDEV(TTYAUX_MAJOR, PTMX_MINOR)); | 523 | BUG_ON(pts_inode->i_rdev == MKDEV(TTYAUX_MAJOR, PTMX_MINOR)); |
| 521 | 524 | ||
| 525 | /* Ensure dentry has not been deleted by devpts_pty_kill() */ | ||
| 526 | dentry = d_find_alias(pts_inode); | ||
| 527 | if (!dentry) | ||
| 528 | return NULL; | ||
| 529 | |||
| 530 | tty = NULL; | ||
| 522 | if (pts_inode->i_sb->s_magic == DEVPTS_SUPER_MAGIC) | 531 | if (pts_inode->i_sb->s_magic == DEVPTS_SUPER_MAGIC) |
| 523 | return (struct tty_struct *)pts_inode->i_private; | 532 | tty = (struct tty_struct *)pts_inode->i_private; |
| 524 | return NULL; | 533 | |
| 534 | dput(dentry); | ||
| 535 | |||
| 536 | return tty; | ||
| 525 | } | 537 | } |
| 526 | 538 | ||
| 527 | void devpts_pty_kill(struct tty_struct *tty) | 539 | void devpts_pty_kill(struct tty_struct *tty) |
diff --git a/fs/direct-io.c b/fs/direct-io.c index 8b10b87dc01a..b912270942fa 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c | |||
| @@ -1028,9 +1028,6 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, | |||
| 1028 | if (dio->bio) | 1028 | if (dio->bio) |
| 1029 | dio_bio_submit(dio); | 1029 | dio_bio_submit(dio); |
| 1030 | 1030 | ||
| 1031 | /* All IO is now issued, send it on its way */ | ||
| 1032 | blk_run_address_space(inode->i_mapping); | ||
| 1033 | |||
| 1034 | /* | 1031 | /* |
| 1035 | * It is possible that, we return short IO due to end of file. | 1032 | * It is possible that, we return short IO due to end of file. |
| 1036 | * In that case, we need to release all the pages we got hold on. | 1033 | * In that case, we need to release all the pages we got hold on. |
| @@ -1057,8 +1054,11 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, | |||
| 1057 | ((rw & READ) || (dio->result == dio->size))) | 1054 | ((rw & READ) || (dio->result == dio->size))) |
| 1058 | ret = -EIOCBQUEUED; | 1055 | ret = -EIOCBQUEUED; |
| 1059 | 1056 | ||
| 1060 | if (ret != -EIOCBQUEUED) | 1057 | if (ret != -EIOCBQUEUED) { |
| 1058 | /* All IO is now issued, send it on its way */ | ||
| 1059 | blk_run_address_space(inode->i_mapping); | ||
| 1061 | dio_await_completion(dio); | 1060 | dio_await_completion(dio); |
| 1061 | } | ||
| 1062 | 1062 | ||
| 1063 | /* | 1063 | /* |
| 1064 | * Sync will always be dropping the final ref and completing the | 1064 | * Sync will always be dropping the final ref and completing the |
| @@ -1124,7 +1124,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, | |||
| 1124 | int acquire_i_mutex = 0; | 1124 | int acquire_i_mutex = 0; |
| 1125 | 1125 | ||
| 1126 | if (rw & WRITE) | 1126 | if (rw & WRITE) |
| 1127 | rw = WRITE_ODIRECT; | 1127 | rw = WRITE_ODIRECT_PLUG; |
| 1128 | 1128 | ||
| 1129 | if (bdev) | 1129 | if (bdev) |
| 1130 | bdev_blkbits = blksize_bits(bdev_logical_block_size(bdev)); | 1130 | bdev_blkbits = blksize_bits(bdev_logical_block_size(bdev)); |
diff --git a/fs/dlm/config.c b/fs/dlm/config.c index fd9859f92fad..0df243850818 100644 --- a/fs/dlm/config.c +++ b/fs/dlm/config.c | |||
| @@ -410,10 +410,10 @@ static struct config_group *make_cluster(struct config_group *g, | |||
| 410 | struct dlm_comms *cms = NULL; | 410 | struct dlm_comms *cms = NULL; |
| 411 | void *gps = NULL; | 411 | void *gps = NULL; |
| 412 | 412 | ||
| 413 | cl = kzalloc(sizeof(struct dlm_cluster), GFP_KERNEL); | 413 | cl = kzalloc(sizeof(struct dlm_cluster), GFP_NOFS); |
| 414 | gps = kcalloc(3, sizeof(struct config_group *), GFP_KERNEL); | 414 | gps = kcalloc(3, sizeof(struct config_group *), GFP_NOFS); |
| 415 | sps = kzalloc(sizeof(struct dlm_spaces), GFP_KERNEL); | 415 | sps = kzalloc(sizeof(struct dlm_spaces), GFP_NOFS); |
| 416 | cms = kzalloc(sizeof(struct dlm_comms), GFP_KERNEL); | 416 | cms = kzalloc(sizeof(struct dlm_comms), GFP_NOFS); |
| 417 | 417 | ||
| 418 | if (!cl || !gps || !sps || !cms) | 418 | if (!cl || !gps || !sps || !cms) |
| 419 | goto fail; | 419 | goto fail; |
| @@ -482,9 +482,9 @@ static struct config_group *make_space(struct config_group *g, const char *name) | |||
| 482 | struct dlm_nodes *nds = NULL; | 482 | struct dlm_nodes *nds = NULL; |
| 483 | void *gps = NULL; | 483 | void *gps = NULL; |
| 484 | 484 | ||
| 485 | sp = kzalloc(sizeof(struct dlm_space), GFP_KERNEL); | 485 | sp = kzalloc(sizeof(struct dlm_space), GFP_NOFS); |
| 486 | gps = kcalloc(2, sizeof(struct config_group *), GFP_KERNEL); | 486 | gps = kcalloc(2, sizeof(struct config_group *), GFP_NOFS); |
| 487 | nds = kzalloc(sizeof(struct dlm_nodes), GFP_KERNEL); | 487 | nds = kzalloc(sizeof(struct dlm_nodes), GFP_NOFS); |
| 488 | 488 | ||
| 489 | if (!sp || !gps || !nds) | 489 | if (!sp || !gps || !nds) |
| 490 | goto fail; | 490 | goto fail; |
| @@ -536,7 +536,7 @@ static struct config_item *make_comm(struct config_group *g, const char *name) | |||
| 536 | { | 536 | { |
| 537 | struct dlm_comm *cm; | 537 | struct dlm_comm *cm; |
| 538 | 538 | ||
| 539 | cm = kzalloc(sizeof(struct dlm_comm), GFP_KERNEL); | 539 | cm = kzalloc(sizeof(struct dlm_comm), GFP_NOFS); |
| 540 | if (!cm) | 540 | if (!cm) |
| 541 | return ERR_PTR(-ENOMEM); | 541 | return ERR_PTR(-ENOMEM); |
| 542 | 542 | ||
| @@ -569,7 +569,7 @@ static struct config_item *make_node(struct config_group *g, const char *name) | |||
| 569 | struct dlm_space *sp = config_item_to_space(g->cg_item.ci_parent); | 569 | struct dlm_space *sp = config_item_to_space(g->cg_item.ci_parent); |
| 570 | struct dlm_node *nd; | 570 | struct dlm_node *nd; |
| 571 | 571 | ||
| 572 | nd = kzalloc(sizeof(struct dlm_node), GFP_KERNEL); | 572 | nd = kzalloc(sizeof(struct dlm_node), GFP_NOFS); |
| 573 | if (!nd) | 573 | if (!nd) |
| 574 | return ERR_PTR(-ENOMEM); | 574 | return ERR_PTR(-ENOMEM); |
| 575 | 575 | ||
| @@ -705,7 +705,7 @@ static ssize_t comm_addr_write(struct dlm_comm *cm, const char *buf, size_t len) | |||
| 705 | if (cm->addr_count >= DLM_MAX_ADDR_COUNT) | 705 | if (cm->addr_count >= DLM_MAX_ADDR_COUNT) |
| 706 | return -ENOSPC; | 706 | return -ENOSPC; |
| 707 | 707 | ||
| 708 | addr = kzalloc(sizeof(*addr), GFP_KERNEL); | 708 | addr = kzalloc(sizeof(*addr), GFP_NOFS); |
| 709 | if (!addr) | 709 | if (!addr) |
| 710 | return -ENOMEM; | 710 | return -ENOMEM; |
| 711 | 711 | ||
| @@ -868,7 +868,7 @@ int dlm_nodeid_list(char *lsname, int **ids_out, int *ids_count_out, | |||
| 868 | 868 | ||
| 869 | ids_count = sp->members_count; | 869 | ids_count = sp->members_count; |
| 870 | 870 | ||
| 871 | ids = kcalloc(ids_count, sizeof(int), GFP_KERNEL); | 871 | ids = kcalloc(ids_count, sizeof(int), GFP_NOFS); |
| 872 | if (!ids) { | 872 | if (!ids) { |
| 873 | rv = -ENOMEM; | 873 | rv = -ENOMEM; |
| 874 | goto out; | 874 | goto out; |
| @@ -886,7 +886,7 @@ int dlm_nodeid_list(char *lsname, int **ids_out, int *ids_count_out, | |||
| 886 | if (!new_count) | 886 | if (!new_count) |
| 887 | goto out_ids; | 887 | goto out_ids; |
| 888 | 888 | ||
| 889 | new = kcalloc(new_count, sizeof(int), GFP_KERNEL); | 889 | new = kcalloc(new_count, sizeof(int), GFP_NOFS); |
| 890 | if (!new) { | 890 | if (!new) { |
| 891 | kfree(ids); | 891 | kfree(ids); |
| 892 | rv = -ENOMEM; | 892 | rv = -ENOMEM; |
diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index 1c8bb8c3a82e..375a2359b3bf 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c | |||
| @@ -404,7 +404,7 @@ static void *table_seq_start(struct seq_file *seq, loff_t *pos) | |||
| 404 | if (bucket >= ls->ls_rsbtbl_size) | 404 | if (bucket >= ls->ls_rsbtbl_size) |
| 405 | return NULL; | 405 | return NULL; |
| 406 | 406 | ||
| 407 | ri = kzalloc(sizeof(struct rsbtbl_iter), GFP_KERNEL); | 407 | ri = kzalloc(sizeof(struct rsbtbl_iter), GFP_NOFS); |
| 408 | if (!ri) | 408 | if (!ri) |
| 409 | return NULL; | 409 | return NULL; |
| 410 | if (n == 0) | 410 | if (n == 0) |
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c index c4dfa1dcc86f..7b84c1dbc82e 100644 --- a/fs/dlm/dir.c +++ b/fs/dlm/dir.c | |||
| @@ -49,8 +49,7 @@ static struct dlm_direntry *get_free_de(struct dlm_ls *ls, int len) | |||
| 49 | spin_unlock(&ls->ls_recover_list_lock); | 49 | spin_unlock(&ls->ls_recover_list_lock); |
| 50 | 50 | ||
| 51 | if (!found) | 51 | if (!found) |
| 52 | de = kzalloc(sizeof(struct dlm_direntry) + len, | 52 | de = kzalloc(sizeof(struct dlm_direntry) + len, GFP_NOFS); |
| 53 | ls->ls_allocation); | ||
| 54 | return de; | 53 | return de; |
| 55 | } | 54 | } |
| 56 | 55 | ||
| @@ -212,7 +211,7 @@ int dlm_recover_directory(struct dlm_ls *ls) | |||
| 212 | 211 | ||
| 213 | dlm_dir_clear(ls); | 212 | dlm_dir_clear(ls); |
| 214 | 213 | ||
| 215 | last_name = kmalloc(DLM_RESNAME_MAXLEN, ls->ls_allocation); | 214 | last_name = kmalloc(DLM_RESNAME_MAXLEN, GFP_NOFS); |
| 216 | if (!last_name) | 215 | if (!last_name) |
| 217 | goto out; | 216 | goto out; |
| 218 | 217 | ||
| @@ -323,7 +322,7 @@ static int get_entry(struct dlm_ls *ls, int nodeid, char *name, | |||
| 323 | if (namelen > DLM_RESNAME_MAXLEN) | 322 | if (namelen > DLM_RESNAME_MAXLEN) |
| 324 | return -EINVAL; | 323 | return -EINVAL; |
| 325 | 324 | ||
| 326 | de = kzalloc(sizeof(struct dlm_direntry) + namelen, ls->ls_allocation); | 325 | de = kzalloc(sizeof(struct dlm_direntry) + namelen, GFP_NOFS); |
| 327 | if (!de) | 326 | if (!de) |
| 328 | return -ENOMEM; | 327 | return -ENOMEM; |
| 329 | 328 | ||
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h index d01ca0a711db..826d3dc6e0ab 100644 --- a/fs/dlm/dlm_internal.h +++ b/fs/dlm/dlm_internal.h | |||
| @@ -473,7 +473,6 @@ struct dlm_ls { | |||
| 473 | int ls_low_nodeid; | 473 | int ls_low_nodeid; |
| 474 | int ls_total_weight; | 474 | int ls_total_weight; |
| 475 | int *ls_node_array; | 475 | int *ls_node_array; |
| 476 | gfp_t ls_allocation; | ||
| 477 | 476 | ||
| 478 | struct dlm_rsb ls_stub_rsb; /* for returning errors */ | 477 | struct dlm_rsb ls_stub_rsb; /* for returning errors */ |
| 479 | struct dlm_lkb ls_stub_lkb; /* for returning errors */ | 478 | struct dlm_lkb ls_stub_lkb; /* for returning errors */ |
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index eb507c453c5f..9c0c1db1e105 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c | |||
| @@ -2689,7 +2689,7 @@ static int _create_message(struct dlm_ls *ls, int mb_len, | |||
| 2689 | pass into lowcomms_commit and a message buffer (mb) that we | 2689 | pass into lowcomms_commit and a message buffer (mb) that we |
| 2690 | write our data into */ | 2690 | write our data into */ |
| 2691 | 2691 | ||
| 2692 | mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, ls->ls_allocation, &mb); | 2692 | mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, GFP_NOFS, &mb); |
| 2693 | if (!mh) | 2693 | if (!mh) |
| 2694 | return -ENOBUFS; | 2694 | return -ENOBUFS; |
| 2695 | 2695 | ||
| @@ -4512,7 +4512,7 @@ int dlm_user_request(struct dlm_ls *ls, struct dlm_user_args *ua, | |||
| 4512 | } | 4512 | } |
| 4513 | 4513 | ||
| 4514 | if (flags & DLM_LKF_VALBLK) { | 4514 | if (flags & DLM_LKF_VALBLK) { |
| 4515 | ua->lksb.sb_lvbptr = kzalloc(DLM_USER_LVB_LEN, GFP_KERNEL); | 4515 | ua->lksb.sb_lvbptr = kzalloc(DLM_USER_LVB_LEN, GFP_NOFS); |
| 4516 | if (!ua->lksb.sb_lvbptr) { | 4516 | if (!ua->lksb.sb_lvbptr) { |
| 4517 | kfree(ua); | 4517 | kfree(ua); |
| 4518 | __put_lkb(ls, lkb); | 4518 | __put_lkb(ls, lkb); |
| @@ -4582,7 +4582,7 @@ int dlm_user_convert(struct dlm_ls *ls, struct dlm_user_args *ua_tmp, | |||
| 4582 | ua = lkb->lkb_ua; | 4582 | ua = lkb->lkb_ua; |
| 4583 | 4583 | ||
| 4584 | if (flags & DLM_LKF_VALBLK && !ua->lksb.sb_lvbptr) { | 4584 | if (flags & DLM_LKF_VALBLK && !ua->lksb.sb_lvbptr) { |
| 4585 | ua->lksb.sb_lvbptr = kzalloc(DLM_USER_LVB_LEN, GFP_KERNEL); | 4585 | ua->lksb.sb_lvbptr = kzalloc(DLM_USER_LVB_LEN, GFP_NOFS); |
| 4586 | if (!ua->lksb.sb_lvbptr) { | 4586 | if (!ua->lksb.sb_lvbptr) { |
| 4587 | error = -ENOMEM; | 4587 | error = -ENOMEM; |
| 4588 | goto out_put; | 4588 | goto out_put; |
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index d489fcc86713..c010ecfc0d29 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c | |||
| @@ -430,7 +430,7 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 430 | 430 | ||
| 431 | error = -ENOMEM; | 431 | error = -ENOMEM; |
| 432 | 432 | ||
| 433 | ls = kzalloc(sizeof(struct dlm_ls) + namelen, GFP_KERNEL); | 433 | ls = kzalloc(sizeof(struct dlm_ls) + namelen, GFP_NOFS); |
| 434 | if (!ls) | 434 | if (!ls) |
| 435 | goto out; | 435 | goto out; |
| 436 | memcpy(ls->ls_name, name, namelen); | 436 | memcpy(ls->ls_name, name, namelen); |
| @@ -443,11 +443,6 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 443 | if (flags & DLM_LSFL_TIMEWARN) | 443 | if (flags & DLM_LSFL_TIMEWARN) |
| 444 | set_bit(LSFL_TIMEWARN, &ls->ls_flags); | 444 | set_bit(LSFL_TIMEWARN, &ls->ls_flags); |
| 445 | 445 | ||
| 446 | if (flags & DLM_LSFL_FS) | ||
| 447 | ls->ls_allocation = GFP_NOFS; | ||
| 448 | else | ||
| 449 | ls->ls_allocation = GFP_KERNEL; | ||
| 450 | |||
| 451 | /* ls_exflags are forced to match among nodes, and we don't | 446 | /* ls_exflags are forced to match among nodes, and we don't |
| 452 | need to require all nodes to have some flags set */ | 447 | need to require all nodes to have some flags set */ |
| 453 | ls->ls_exflags = (flags & ~(DLM_LSFL_TIMEWARN | DLM_LSFL_FS | | 448 | ls->ls_exflags = (flags & ~(DLM_LSFL_TIMEWARN | DLM_LSFL_FS | |
| @@ -456,7 +451,7 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 456 | size = dlm_config.ci_rsbtbl_size; | 451 | size = dlm_config.ci_rsbtbl_size; |
| 457 | ls->ls_rsbtbl_size = size; | 452 | ls->ls_rsbtbl_size = size; |
| 458 | 453 | ||
| 459 | ls->ls_rsbtbl = kmalloc(sizeof(struct dlm_rsbtable) * size, GFP_KERNEL); | 454 | ls->ls_rsbtbl = kmalloc(sizeof(struct dlm_rsbtable) * size, GFP_NOFS); |
| 460 | if (!ls->ls_rsbtbl) | 455 | if (!ls->ls_rsbtbl) |
| 461 | goto out_lsfree; | 456 | goto out_lsfree; |
| 462 | for (i = 0; i < size; i++) { | 457 | for (i = 0; i < size; i++) { |
| @@ -468,7 +463,7 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 468 | size = dlm_config.ci_lkbtbl_size; | 463 | size = dlm_config.ci_lkbtbl_size; |
| 469 | ls->ls_lkbtbl_size = size; | 464 | ls->ls_lkbtbl_size = size; |
| 470 | 465 | ||
| 471 | ls->ls_lkbtbl = kmalloc(sizeof(struct dlm_lkbtable) * size, GFP_KERNEL); | 466 | ls->ls_lkbtbl = kmalloc(sizeof(struct dlm_lkbtable) * size, GFP_NOFS); |
| 472 | if (!ls->ls_lkbtbl) | 467 | if (!ls->ls_lkbtbl) |
| 473 | goto out_rsbfree; | 468 | goto out_rsbfree; |
| 474 | for (i = 0; i < size; i++) { | 469 | for (i = 0; i < size; i++) { |
| @@ -480,7 +475,7 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 480 | size = dlm_config.ci_dirtbl_size; | 475 | size = dlm_config.ci_dirtbl_size; |
| 481 | ls->ls_dirtbl_size = size; | 476 | ls->ls_dirtbl_size = size; |
| 482 | 477 | ||
| 483 | ls->ls_dirtbl = kmalloc(sizeof(struct dlm_dirtable) * size, GFP_KERNEL); | 478 | ls->ls_dirtbl = kmalloc(sizeof(struct dlm_dirtable) * size, GFP_NOFS); |
| 484 | if (!ls->ls_dirtbl) | 479 | if (!ls->ls_dirtbl) |
| 485 | goto out_lkbfree; | 480 | goto out_lkbfree; |
| 486 | for (i = 0; i < size; i++) { | 481 | for (i = 0; i < size; i++) { |
| @@ -527,7 +522,7 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, | |||
| 527 | mutex_init(&ls->ls_requestqueue_mutex); | 522 | mutex_init(&ls->ls_requestqueue_mutex); |
| 528 | mutex_init(&ls->ls_clear_proc_locks); | 523 | mutex_init(&ls->ls_clear_proc_locks); |
| 529 | 524 | ||
| 530 | ls->ls_recover_buf = kmalloc(dlm_config.ci_buffer_size, GFP_KERNEL); | 525 | ls->ls_recover_buf = kmalloc(dlm_config.ci_buffer_size, GFP_NOFS); |
| 531 | if (!ls->ls_recover_buf) | 526 | if (!ls->ls_recover_buf) |
| 532 | goto out_dirfree; | 527 | goto out_dirfree; |
| 533 | 528 | ||
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 70736eb4b516..52cab160893c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c | |||
| @@ -1060,7 +1060,7 @@ static void init_local(void) | |||
| 1060 | if (dlm_our_addr(&sas, i)) | 1060 | if (dlm_our_addr(&sas, i)) |
| 1061 | break; | 1061 | break; |
| 1062 | 1062 | ||
| 1063 | addr = kmalloc(sizeof(*addr), GFP_KERNEL); | 1063 | addr = kmalloc(sizeof(*addr), GFP_NOFS); |
| 1064 | if (!addr) | 1064 | if (!addr) |
| 1065 | break; | 1065 | break; |
| 1066 | memcpy(addr, &sas, sizeof(*addr)); | 1066 | memcpy(addr, &sas, sizeof(*addr)); |
| @@ -1099,7 +1099,7 @@ static int sctp_listen_for_all(void) | |||
| 1099 | struct sockaddr_storage localaddr; | 1099 | struct sockaddr_storage localaddr; |
| 1100 | struct sctp_event_subscribe subscribe; | 1100 | struct sctp_event_subscribe subscribe; |
| 1101 | int result = -EINVAL, num = 1, i, addr_len; | 1101 | int result = -EINVAL, num = 1, i, addr_len; |
| 1102 | struct connection *con = nodeid2con(0, GFP_KERNEL); | 1102 | struct connection *con = nodeid2con(0, GFP_NOFS); |
| 1103 | int bufsize = NEEDED_RMEM; | 1103 | int bufsize = NEEDED_RMEM; |
| 1104 | 1104 | ||
| 1105 | if (!con) | 1105 | if (!con) |
| @@ -1171,7 +1171,7 @@ out: | |||
| 1171 | static int tcp_listen_for_all(void) | 1171 | static int tcp_listen_for_all(void) |
| 1172 | { | 1172 | { |
| 1173 | struct socket *sock = NULL; | 1173 | struct socket *sock = NULL; |
| 1174 | struct connection *con = nodeid2con(0, GFP_KERNEL); | 1174 | struct connection *con = nodeid2con(0, GFP_NOFS); |
| 1175 | int result = -EINVAL; | 1175 | int result = -EINVAL; |
| 1176 | 1176 | ||
| 1177 | if (!con) | 1177 | if (!con) |
diff --git a/fs/dlm/member.c b/fs/dlm/member.c index b128775913b2..84f70bfb0baf 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c | |||
| @@ -48,7 +48,7 @@ static int dlm_add_member(struct dlm_ls *ls, int nodeid) | |||
| 48 | struct dlm_member *memb; | 48 | struct dlm_member *memb; |
| 49 | int w, error; | 49 | int w, error; |
| 50 | 50 | ||
| 51 | memb = kzalloc(sizeof(struct dlm_member), ls->ls_allocation); | 51 | memb = kzalloc(sizeof(struct dlm_member), GFP_NOFS); |
| 52 | if (!memb) | 52 | if (!memb) |
| 53 | return -ENOMEM; | 53 | return -ENOMEM; |
| 54 | 54 | ||
| @@ -143,7 +143,7 @@ static void make_member_array(struct dlm_ls *ls) | |||
| 143 | 143 | ||
| 144 | ls->ls_total_weight = total; | 144 | ls->ls_total_weight = total; |
| 145 | 145 | ||
| 146 | array = kmalloc(sizeof(int) * total, ls->ls_allocation); | 146 | array = kmalloc(sizeof(int) * total, GFP_NOFS); |
| 147 | if (!array) | 147 | if (!array) |
| 148 | return; | 148 | return; |
| 149 | 149 | ||
| @@ -226,7 +226,7 @@ int dlm_recover_members(struct dlm_ls *ls, struct dlm_recover *rv, int *neg_out) | |||
| 226 | continue; | 226 | continue; |
| 227 | log_debug(ls, "new nodeid %d is a re-added member", rv->new[i]); | 227 | log_debug(ls, "new nodeid %d is a re-added member", rv->new[i]); |
| 228 | 228 | ||
| 229 | memb = kzalloc(sizeof(struct dlm_member), ls->ls_allocation); | 229 | memb = kzalloc(sizeof(struct dlm_member), GFP_NOFS); |
| 230 | if (!memb) | 230 | if (!memb) |
| 231 | return -ENOMEM; | 231 | return -ENOMEM; |
| 232 | memb->nodeid = rv->new[i]; | 232 | memb->nodeid = rv->new[i]; |
| @@ -341,7 +341,7 @@ int dlm_ls_start(struct dlm_ls *ls) | |||
| 341 | int *ids = NULL, *new = NULL; | 341 | int *ids = NULL, *new = NULL; |
| 342 | int error, ids_count = 0, new_count = 0; | 342 | int error, ids_count = 0, new_count = 0; |
| 343 | 343 | ||
| 344 | rv = kzalloc(sizeof(struct dlm_recover), ls->ls_allocation); | 344 | rv = kzalloc(sizeof(struct dlm_recover), GFP_NOFS); |
| 345 | if (!rv) | 345 | if (!rv) |
| 346 | return -ENOMEM; | 346 | return -ENOMEM; |
| 347 | 347 | ||
diff --git a/fs/dlm/memory.c b/fs/dlm/memory.c index c1775b84ebab..8e0d00db004f 100644 --- a/fs/dlm/memory.c +++ b/fs/dlm/memory.c | |||
| @@ -39,7 +39,7 @@ char *dlm_allocate_lvb(struct dlm_ls *ls) | |||
| 39 | { | 39 | { |
| 40 | char *p; | 40 | char *p; |
| 41 | 41 | ||
| 42 | p = kzalloc(ls->ls_lvblen, ls->ls_allocation); | 42 | p = kzalloc(ls->ls_lvblen, GFP_NOFS); |
| 43 | return p; | 43 | return p; |
| 44 | } | 44 | } |
| 45 | 45 | ||
| @@ -57,7 +57,7 @@ struct dlm_rsb *dlm_allocate_rsb(struct dlm_ls *ls, int namelen) | |||
| 57 | 57 | ||
| 58 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN,); | 58 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN,); |
| 59 | 59 | ||
| 60 | r = kzalloc(sizeof(*r) + namelen, ls->ls_allocation); | 60 | r = kzalloc(sizeof(*r) + namelen, GFP_NOFS); |
| 61 | return r; | 61 | return r; |
| 62 | } | 62 | } |
| 63 | 63 | ||
| @@ -72,7 +72,7 @@ struct dlm_lkb *dlm_allocate_lkb(struct dlm_ls *ls) | |||
| 72 | { | 72 | { |
| 73 | struct dlm_lkb *lkb; | 73 | struct dlm_lkb *lkb; |
| 74 | 74 | ||
| 75 | lkb = kmem_cache_zalloc(lkb_cache, ls->ls_allocation); | 75 | lkb = kmem_cache_zalloc(lkb_cache, GFP_NOFS); |
| 76 | return lkb; | 76 | return lkb; |
| 77 | } | 77 | } |
| 78 | 78 | ||
diff --git a/fs/dlm/netlink.c b/fs/dlm/netlink.c index 55ea369f43a9..052095cd592f 100644 --- a/fs/dlm/netlink.c +++ b/fs/dlm/netlink.c | |||
| @@ -26,7 +26,7 @@ static int prepare_data(u8 cmd, struct sk_buff **skbp, size_t size) | |||
| 26 | struct sk_buff *skb; | 26 | struct sk_buff *skb; |
| 27 | void *data; | 27 | void *data; |
| 28 | 28 | ||
| 29 | skb = genlmsg_new(size, GFP_KERNEL); | 29 | skb = genlmsg_new(size, GFP_NOFS); |
| 30 | if (!skb) | 30 | if (!skb) |
| 31 | return -ENOMEM; | 31 | return -ENOMEM; |
| 32 | 32 | ||
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index 16f682e26c07..b5f89aef3b29 100644 --- a/fs/dlm/plock.c +++ b/fs/dlm/plock.c | |||
| @@ -82,7 +82,7 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file, | |||
| 82 | if (!ls) | 82 | if (!ls) |
| 83 | return -EINVAL; | 83 | return -EINVAL; |
| 84 | 84 | ||
| 85 | xop = kzalloc(sizeof(*xop), GFP_KERNEL); | 85 | xop = kzalloc(sizeof(*xop), GFP_NOFS); |
| 86 | if (!xop) { | 86 | if (!xop) { |
| 87 | rv = -ENOMEM; | 87 | rv = -ENOMEM; |
| 88 | goto out; | 88 | goto out; |
| @@ -143,7 +143,7 @@ out: | |||
| 143 | } | 143 | } |
| 144 | EXPORT_SYMBOL_GPL(dlm_posix_lock); | 144 | EXPORT_SYMBOL_GPL(dlm_posix_lock); |
| 145 | 145 | ||
| 146 | /* Returns failure iff a succesful lock operation should be canceled */ | 146 | /* Returns failure iff a successful lock operation should be canceled */ |
| 147 | static int dlm_plock_callback(struct plock_op *op) | 147 | static int dlm_plock_callback(struct plock_op *op) |
| 148 | { | 148 | { |
| 149 | struct file *file; | 149 | struct file *file; |
| @@ -211,7 +211,7 @@ int dlm_posix_unlock(dlm_lockspace_t *lockspace, u64 number, struct file *file, | |||
| 211 | if (!ls) | 211 | if (!ls) |
| 212 | return -EINVAL; | 212 | return -EINVAL; |
| 213 | 213 | ||
| 214 | op = kzalloc(sizeof(*op), GFP_KERNEL); | 214 | op = kzalloc(sizeof(*op), GFP_NOFS); |
| 215 | if (!op) { | 215 | if (!op) { |
| 216 | rv = -ENOMEM; | 216 | rv = -ENOMEM; |
| 217 | goto out; | 217 | goto out; |
| @@ -266,7 +266,7 @@ int dlm_posix_get(dlm_lockspace_t *lockspace, u64 number, struct file *file, | |||
| 266 | if (!ls) | 266 | if (!ls) |
| 267 | return -EINVAL; | 267 | return -EINVAL; |
| 268 | 268 | ||
| 269 | op = kzalloc(sizeof(*op), GFP_KERNEL); | 269 | op = kzalloc(sizeof(*op), GFP_NOFS); |
| 270 | if (!op) { | 270 | if (!op) { |
| 271 | rv = -ENOMEM; | 271 | rv = -ENOMEM; |
| 272 | goto out; | 272 | goto out; |
diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index 67522c268c14..3c83a49a48a3 100644 --- a/fs/dlm/rcom.c +++ b/fs/dlm/rcom.c | |||
| @@ -38,7 +38,7 @@ static int create_rcom(struct dlm_ls *ls, int to_nodeid, int type, int len, | |||
| 38 | char *mb; | 38 | char *mb; |
| 39 | int mb_len = sizeof(struct dlm_rcom) + len; | 39 | int mb_len = sizeof(struct dlm_rcom) + len; |
| 40 | 40 | ||
| 41 | mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, ls->ls_allocation, &mb); | 41 | mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, GFP_NOFS, &mb); |
| 42 | if (!mh) { | 42 | if (!mh) { |
| 43 | log_print("create_rcom to %d type %d len %d ENOBUFS", | 43 | log_print("create_rcom to %d type %d len %d ENOBUFS", |
| 44 | to_nodeid, type, len); | 44 | to_nodeid, type, len); |
diff --git a/fs/dlm/requestqueue.c b/fs/dlm/requestqueue.c index 7a2307c08911..a44fa22890e1 100644 --- a/fs/dlm/requestqueue.c +++ b/fs/dlm/requestqueue.c | |||
| @@ -35,7 +35,7 @@ void dlm_add_requestqueue(struct dlm_ls *ls, int nodeid, struct dlm_message *ms) | |||
| 35 | struct rq_entry *e; | 35 | struct rq_entry *e; |
| 36 | int length = ms->m_header.h_length - sizeof(struct dlm_message); | 36 | int length = ms->m_header.h_length - sizeof(struct dlm_message); |
| 37 | 37 | ||
| 38 | e = kmalloc(sizeof(struct rq_entry) + length, ls->ls_allocation); | 38 | e = kmalloc(sizeof(struct rq_entry) + length, GFP_NOFS); |
| 39 | if (!e) { | 39 | if (!e) { |
| 40 | log_print("dlm_add_requestqueue: out of memory len %d", length); | 40 | log_print("dlm_add_requestqueue: out of memory len %d", length); |
| 41 | return; | 41 | return; |
diff --git a/fs/dlm/user.c b/fs/dlm/user.c index ebce994ab0b7..e73a4bb572aa 100644 --- a/fs/dlm/user.c +++ b/fs/dlm/user.c | |||
| @@ -267,7 +267,7 @@ static int device_user_lock(struct dlm_user_proc *proc, | |||
| 267 | goto out; | 267 | goto out; |
| 268 | } | 268 | } |
| 269 | 269 | ||
| 270 | ua = kzalloc(sizeof(struct dlm_user_args), GFP_KERNEL); | 270 | ua = kzalloc(sizeof(struct dlm_user_args), GFP_NOFS); |
| 271 | if (!ua) | 271 | if (!ua) |
| 272 | goto out; | 272 | goto out; |
| 273 | ua->proc = proc; | 273 | ua->proc = proc; |
| @@ -307,7 +307,7 @@ static int device_user_unlock(struct dlm_user_proc *proc, | |||
| 307 | if (!ls) | 307 | if (!ls) |
| 308 | return -ENOENT; | 308 | return -ENOENT; |
| 309 | 309 | ||
| 310 | ua = kzalloc(sizeof(struct dlm_user_args), GFP_KERNEL); | 310 | ua = kzalloc(sizeof(struct dlm_user_args), GFP_NOFS); |
| 311 | if (!ua) | 311 | if (!ua) |
| 312 | goto out; | 312 | goto out; |
| 313 | ua->proc = proc; | 313 | ua->proc = proc; |
| @@ -352,7 +352,7 @@ static int dlm_device_register(struct dlm_ls *ls, char *name) | |||
| 352 | 352 | ||
| 353 | error = -ENOMEM; | 353 | error = -ENOMEM; |
| 354 | len = strlen(name) + strlen(name_prefix) + 2; | 354 | len = strlen(name) + strlen(name_prefix) + 2; |
| 355 | ls->ls_device.name = kzalloc(len, GFP_KERNEL); | 355 | ls->ls_device.name = kzalloc(len, GFP_NOFS); |
| 356 | if (!ls->ls_device.name) | 356 | if (!ls->ls_device.name) |
| 357 | goto fail; | 357 | goto fail; |
| 358 | 358 | ||
| @@ -520,7 +520,7 @@ static ssize_t device_write(struct file *file, const char __user *buf, | |||
| 520 | #endif | 520 | #endif |
| 521 | return -EINVAL; | 521 | return -EINVAL; |
| 522 | 522 | ||
| 523 | kbuf = kzalloc(count + 1, GFP_KERNEL); | 523 | kbuf = kzalloc(count + 1, GFP_NOFS); |
| 524 | if (!kbuf) | 524 | if (!kbuf) |
| 525 | return -ENOMEM; | 525 | return -ENOMEM; |
| 526 | 526 | ||
| @@ -546,7 +546,7 @@ static ssize_t device_write(struct file *file, const char __user *buf, | |||
| 546 | 546 | ||
| 547 | /* add 1 after namelen so that the name string is terminated */ | 547 | /* add 1 after namelen so that the name string is terminated */ |
| 548 | kbuf = kzalloc(sizeof(struct dlm_write_request) + namelen + 1, | 548 | kbuf = kzalloc(sizeof(struct dlm_write_request) + namelen + 1, |
| 549 | GFP_KERNEL); | 549 | GFP_NOFS); |
| 550 | if (!kbuf) { | 550 | if (!kbuf) { |
| 551 | kfree(k32buf); | 551 | kfree(k32buf); |
| 552 | return -ENOMEM; | 552 | return -ENOMEM; |
| @@ -648,7 +648,7 @@ static int device_open(struct inode *inode, struct file *file) | |||
| 648 | if (!ls) | 648 | if (!ls) |
| 649 | return -ENOENT; | 649 | return -ENOENT; |
| 650 | 650 | ||
| 651 | proc = kzalloc(sizeof(struct dlm_user_proc), GFP_KERNEL); | 651 | proc = kzalloc(sizeof(struct dlm_user_proc), GFP_NOFS); |
| 652 | if (!proc) { | 652 | if (!proc) { |
| 653 | dlm_put_lockspace(ls); | 653 | dlm_put_lockspace(ls); |
| 654 | return -ENOMEM; | 654 | return -ENOMEM; |
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 085c5c063420..366c503f9657 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c | |||
| @@ -251,10 +251,10 @@ ctl_table epoll_table[] = { | |||
| 251 | .data = &max_user_watches, | 251 | .data = &max_user_watches, |
| 252 | .maxlen = sizeof(int), | 252 | .maxlen = sizeof(int), |
| 253 | .mode = 0644, | 253 | .mode = 0644, |
| 254 | .proc_handler = &proc_dointvec_minmax, | 254 | .proc_handler = proc_dointvec_minmax, |
| 255 | .extra1 = &zero, | 255 | .extra1 = &zero, |
| 256 | }, | 256 | }, |
| 257 | { .ctl_name = 0 } | 257 | { } |
| 258 | }; | 258 | }; |
| 259 | #endif /* CONFIG_SYSCTL */ | 259 | #endif /* CONFIG_SYSCTL */ |
| 260 | 260 | ||
| @@ -46,7 +46,6 @@ | |||
| 46 | #include <linux/proc_fs.h> | 46 | #include <linux/proc_fs.h> |
| 47 | #include <linux/mount.h> | 47 | #include <linux/mount.h> |
| 48 | #include <linux/security.h> | 48 | #include <linux/security.h> |
| 49 | #include <linux/ima.h> | ||
| 50 | #include <linux/syscalls.h> | 49 | #include <linux/syscalls.h> |
| 51 | #include <linux/tsacct_kern.h> | 50 | #include <linux/tsacct_kern.h> |
| 52 | #include <linux/cn_proc.h> | 51 | #include <linux/cn_proc.h> |
| @@ -924,6 +923,15 @@ char *get_task_comm(char *buf, struct task_struct *tsk) | |||
| 924 | void set_task_comm(struct task_struct *tsk, char *buf) | 923 | void set_task_comm(struct task_struct *tsk, char *buf) |
| 925 | { | 924 | { |
| 926 | task_lock(tsk); | 925 | task_lock(tsk); |
| 926 | |||
| 927 | /* | ||
| 928 | * Threads may access current->comm without holding | ||
| 929 | * the task lock, so write the string carefully. | ||
| 930 | * Readers without a lock may see incomplete new | ||
| 931 | * names but are safe from non-terminating string reads. | ||
| 932 | */ | ||
| 933 | memset(tsk->comm, 0, TASK_COMM_LEN); | ||
| 934 | wmb(); | ||
| 927 | strlcpy(tsk->comm, buf, sizeof(tsk->comm)); | 935 | strlcpy(tsk->comm, buf, sizeof(tsk->comm)); |
| 928 | task_unlock(tsk); | 936 | task_unlock(tsk); |
| 929 | perf_event_comm(tsk); | 937 | perf_event_comm(tsk); |
| @@ -1209,9 +1217,6 @@ int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs) | |||
| 1209 | retval = security_bprm_check(bprm); | 1217 | retval = security_bprm_check(bprm); |
| 1210 | if (retval) | 1218 | if (retval) |
| 1211 | return retval; | 1219 | return retval; |
| 1212 | retval = ima_bprm_check(bprm); | ||
| 1213 | if (retval) | ||
| 1214 | return retval; | ||
| 1215 | 1220 | ||
| 1216 | /* kernel module loader fixup */ | 1221 | /* kernel module loader fixup */ |
| 1217 | /* so we don't try to load run modprobe in kernel space. */ | 1222 | /* so we don't try to load run modprobe in kernel space. */ |
diff --git a/fs/exofs/Kbuild b/fs/exofs/Kbuild index cc2d22db119c..2d0f757fda3e 100644 --- a/fs/exofs/Kbuild +++ b/fs/exofs/Kbuild | |||
| @@ -12,5 +12,5 @@ | |||
| 12 | # Kbuild - Gets included from the Kernels Makefile and build system | 12 | # Kbuild - Gets included from the Kernels Makefile and build system |
| 13 | # | 13 | # |
| 14 | 14 | ||
| 15 | exofs-y := osd.o inode.o file.o symlink.o namei.o dir.o super.o | 15 | exofs-y := ios.o inode.o file.o symlink.o namei.o dir.o super.o |
| 16 | obj-$(CONFIG_EXOFS_FS) += exofs.o | 16 | obj-$(CONFIG_EXOFS_FS) += exofs.o |
diff --git a/fs/exofs/common.h b/fs/exofs/common.h index c6718e4817fe..b1b178e61718 100644 --- a/fs/exofs/common.h +++ b/fs/exofs/common.h | |||
| @@ -49,6 +49,7 @@ | |||
| 49 | #define EXOFS_MIN_PID 0x10000 /* Smallest partition ID */ | 49 | #define EXOFS_MIN_PID 0x10000 /* Smallest partition ID */ |
| 50 | #define EXOFS_OBJ_OFF 0x10000 /* offset for objects */ | 50 | #define EXOFS_OBJ_OFF 0x10000 /* offset for objects */ |
| 51 | #define EXOFS_SUPER_ID 0x10000 /* object ID for on-disk superblock */ | 51 | #define EXOFS_SUPER_ID 0x10000 /* object ID for on-disk superblock */ |
| 52 | #define EXOFS_DEVTABLE_ID 0x10001 /* object ID for on-disk device table */ | ||
| 52 | #define EXOFS_ROOT_ID 0x10002 /* object ID for root directory */ | 53 | #define EXOFS_ROOT_ID 0x10002 /* object ID for root directory */ |
| 53 | 54 | ||
| 54 | /* exofs Application specific page/attribute */ | 55 | /* exofs Application specific page/attribute */ |
| @@ -78,17 +79,67 @@ enum { | |||
| 78 | #define EXOFS_SUPER_MAGIC 0x5DF5 | 79 | #define EXOFS_SUPER_MAGIC 0x5DF5 |
| 79 | 80 | ||
| 80 | /* | 81 | /* |
| 81 | * The file system control block - stored in an object's data (mainly, the one | 82 | * The file system control block - stored in object EXOFS_SUPER_ID's data. |
| 82 | * with ID EXOFS_SUPER_ID). This is where the in-memory superblock is stored | 83 | * This is where the in-memory superblock is stored on disk. |
| 83 | * on disk. Right now it just has a magic value, which is basically a sanity | ||
| 84 | * check on our ability to communicate with the object store. | ||
| 85 | */ | 84 | */ |
| 85 | enum {EXOFS_FSCB_VER = 1, EXOFS_DT_VER = 1}; | ||
| 86 | struct exofs_fscb { | 86 | struct exofs_fscb { |
| 87 | __le64 s_nextid; /* Highest object ID used */ | 87 | __le64 s_nextid; /* Highest object ID used */ |
| 88 | __le32 s_numfiles; /* Number of files on fs */ | 88 | __le64 s_numfiles; /* Number of files on fs */ |
| 89 | __le32 s_version; /* == EXOFS_FSCB_VER */ | ||
| 89 | __le16 s_magic; /* Magic signature */ | 90 | __le16 s_magic; /* Magic signature */ |
| 90 | __le16 s_newfs; /* Non-zero if this is a new fs */ | 91 | __le16 s_newfs; /* Non-zero if this is a new fs */ |
| 91 | }; | 92 | |
| 93 | /* From here on it's a static part, only written by mkexofs */ | ||
| 94 | __le64 s_dev_table_oid; /* Resurved, not used */ | ||
| 95 | __le64 s_dev_table_count; /* == 0 means no dev_table */ | ||
| 96 | } __packed; | ||
| 97 | |||
| 98 | /* | ||
| 99 | * Describes the raid used in the FS. It is part of the device table. | ||
| 100 | * This here is taken from the pNFS-objects definition. In exofs we | ||
| 101 | * use one raid policy through-out the filesystem. (NOTE: the funny | ||
| 102 | * alignment at begining. We take care of it at exofs_device_table. | ||
| 103 | */ | ||
| 104 | struct exofs_dt_data_map { | ||
| 105 | __le32 cb_num_comps; | ||
| 106 | __le64 cb_stripe_unit; | ||
| 107 | __le32 cb_group_width; | ||
| 108 | __le32 cb_group_depth; | ||
| 109 | __le32 cb_mirror_cnt; | ||
| 110 | __le32 cb_raid_algorithm; | ||
| 111 | } __packed; | ||
| 112 | |||
| 113 | /* | ||
| 114 | * This is an osd device information descriptor. It is a single entry in | ||
| 115 | * the exofs device table. It describes an osd target lun which | ||
| 116 | * contains data belonging to this FS. (Same partition_id on all devices) | ||
| 117 | */ | ||
| 118 | struct exofs_dt_device_info { | ||
| 119 | __le32 systemid_len; | ||
| 120 | u8 systemid[OSD_SYSTEMID_LEN]; | ||
| 121 | __le64 long_name_offset; /* If !0 then offset-in-file */ | ||
| 122 | __le32 osdname_len; /* */ | ||
| 123 | u8 osdname[44]; /* Embbeded, Ususally an asci uuid */ | ||
| 124 | } __packed; | ||
| 125 | |||
| 126 | /* | ||
| 127 | * The EXOFS device table - stored in object EXOFS_DEVTABLE_ID's data. | ||
| 128 | * It contains the raid used for this multy-device FS and an array of | ||
| 129 | * participating devices. | ||
| 130 | */ | ||
| 131 | struct exofs_device_table { | ||
| 132 | __le32 dt_version; /* == EXOFS_DT_VER */ | ||
| 133 | struct exofs_dt_data_map dt_data_map; /* Raid policy to use */ | ||
| 134 | |||
| 135 | /* Resurved space For future use. Total includeing this: | ||
| 136 | * (8 * sizeof(le64)) | ||
| 137 | */ | ||
| 138 | __le64 __Resurved[4]; | ||
| 139 | |||
| 140 | __le64 dt_num_devices; /* Array size */ | ||
| 141 | struct exofs_dt_device_info dt_dev_table[]; /* Array of devices */ | ||
| 142 | } __packed; | ||
| 92 | 143 | ||
| 93 | /**************************************************************************** | 144 | /**************************************************************************** |
| 94 | * inode-related things | 145 | * inode-related things |
| @@ -155,22 +206,4 @@ enum { | |||
| 155 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ | 206 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ |
| 156 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) | 207 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) |
| 157 | 208 | ||
| 158 | /************************* | ||
| 159 | * function declarations * | ||
| 160 | *************************/ | ||
| 161 | /* osd.c */ | ||
| 162 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], | ||
| 163 | const struct osd_obj_id *obj); | ||
| 164 | |||
| 165 | int exofs_check_ok_resid(struct osd_request *or, u64 *in_resid, u64 *out_resid); | ||
| 166 | static inline int exofs_check_ok(struct osd_request *or) | ||
| 167 | { | ||
| 168 | return exofs_check_ok_resid(or, NULL, NULL); | ||
| 169 | } | ||
| 170 | int exofs_sync_op(struct osd_request *or, int timeout, u8 *cred); | ||
| 171 | int exofs_async_op(struct osd_request *or, | ||
| 172 | osd_req_done_fn *async_done, void *caller_context, u8 *cred); | ||
| 173 | |||
| 174 | int extract_attr_from_req(struct osd_request *or, struct osd_attr *attr); | ||
| 175 | |||
| 176 | #endif /*ifndef __EXOFS_COM_H__*/ | 209 | #endif /*ifndef __EXOFS_COM_H__*/ |
diff --git a/fs/exofs/exofs.h b/fs/exofs/exofs.h index 5ec72e020b22..c35fd4623986 100644 --- a/fs/exofs/exofs.h +++ b/fs/exofs/exofs.h | |||
| @@ -30,13 +30,17 @@ | |||
| 30 | * along with exofs; if not, write to the Free Software | 30 | * along with exofs; if not, write to the Free Software |
| 31 | * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | 31 | * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
| 32 | */ | 32 | */ |
| 33 | #ifndef __EXOFS_H__ | ||
| 34 | #define __EXOFS_H__ | ||
| 33 | 35 | ||
| 34 | #include <linux/fs.h> | 36 | #include <linux/fs.h> |
| 35 | #include <linux/time.h> | 37 | #include <linux/time.h> |
| 36 | #include "common.h" | 38 | #include "common.h" |
| 37 | 39 | ||
| 38 | #ifndef __EXOFS_H__ | 40 | /* FIXME: Remove once pnfs hits mainline |
| 39 | #define __EXOFS_H__ | 41 | * #include <linux/exportfs/pnfs_osd_xdr.h> |
| 42 | */ | ||
| 43 | #include "pnfs.h" | ||
| 40 | 44 | ||
| 41 | #define EXOFS_ERR(fmt, a...) printk(KERN_ERR "exofs: " fmt, ##a) | 45 | #define EXOFS_ERR(fmt, a...) printk(KERN_ERR "exofs: " fmt, ##a) |
| 42 | 46 | ||
| @@ -55,7 +59,7 @@ | |||
| 55 | * our extension to the in-memory superblock | 59 | * our extension to the in-memory superblock |
| 56 | */ | 60 | */ |
| 57 | struct exofs_sb_info { | 61 | struct exofs_sb_info { |
| 58 | struct osd_dev *s_dev; /* returned by get_osd_dev */ | 62 | struct exofs_fscb s_fscb; /* Written often, pre-allocate*/ |
| 59 | osd_id s_pid; /* partition ID of file system*/ | 63 | osd_id s_pid; /* partition ID of file system*/ |
| 60 | int s_timeout; /* timeout for OSD operations */ | 64 | int s_timeout; /* timeout for OSD operations */ |
| 61 | uint64_t s_nextid; /* highest object ID used */ | 65 | uint64_t s_nextid; /* highest object ID used */ |
| @@ -63,7 +67,11 @@ struct exofs_sb_info { | |||
| 63 | spinlock_t s_next_gen_lock; /* spinlock for gen # update */ | 67 | spinlock_t s_next_gen_lock; /* spinlock for gen # update */ |
| 64 | u32 s_next_generation; /* next gen # to use */ | 68 | u32 s_next_generation; /* next gen # to use */ |
| 65 | atomic_t s_curr_pending; /* number of pending commands */ | 69 | atomic_t s_curr_pending; /* number of pending commands */ |
| 66 | uint8_t s_cred[OSD_CAP_LEN]; /* all-powerful credential */ | 70 | uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */ |
| 71 | |||
| 72 | struct pnfs_osd_data_map data_map; /* Default raid to use */ | ||
| 73 | unsigned s_numdevs; /* Num of devices in array */ | ||
| 74 | struct osd_dev *s_ods[1]; /* Variable length, minimum 1 */ | ||
| 67 | }; | 75 | }; |
| 68 | 76 | ||
| 69 | /* | 77 | /* |
| @@ -79,6 +87,50 @@ struct exofs_i_info { | |||
| 79 | struct inode vfs_inode; /* normal in-memory inode */ | 87 | struct inode vfs_inode; /* normal in-memory inode */ |
| 80 | }; | 88 | }; |
| 81 | 89 | ||
| 90 | static inline osd_id exofs_oi_objno(struct exofs_i_info *oi) | ||
| 91 | { | ||
| 92 | return oi->vfs_inode.i_ino + EXOFS_OBJ_OFF; | ||
| 93 | } | ||
| 94 | |||
| 95 | struct exofs_io_state; | ||
| 96 | typedef void (*exofs_io_done_fn)(struct exofs_io_state *or, void *private); | ||
| 97 | |||
| 98 | struct exofs_io_state { | ||
| 99 | struct kref kref; | ||
| 100 | |||
| 101 | void *private; | ||
| 102 | exofs_io_done_fn done; | ||
| 103 | |||
| 104 | struct exofs_sb_info *sbi; | ||
| 105 | struct osd_obj_id obj; | ||
| 106 | u8 *cred; | ||
| 107 | |||
| 108 | /* Global read/write IO*/ | ||
| 109 | loff_t offset; | ||
| 110 | unsigned long length; | ||
| 111 | void *kern_buff; | ||
| 112 | struct bio *bio; | ||
| 113 | |||
| 114 | /* Attributes */ | ||
| 115 | unsigned in_attr_len; | ||
| 116 | struct osd_attr *in_attr; | ||
| 117 | unsigned out_attr_len; | ||
| 118 | struct osd_attr *out_attr; | ||
| 119 | |||
| 120 | /* Variable array of size numdevs */ | ||
| 121 | unsigned numdevs; | ||
| 122 | struct exofs_per_dev_state { | ||
| 123 | struct osd_request *or; | ||
| 124 | struct bio *bio; | ||
| 125 | } per_dev[]; | ||
| 126 | }; | ||
| 127 | |||
| 128 | static inline unsigned exofs_io_state_size(unsigned numdevs) | ||
| 129 | { | ||
| 130 | return sizeof(struct exofs_io_state) + | ||
| 131 | sizeof(struct exofs_per_dev_state) * numdevs; | ||
| 132 | } | ||
| 133 | |||
| 82 | /* | 134 | /* |
| 83 | * our inode flags | 135 | * our inode flags |
| 84 | */ | 136 | */ |
| @@ -130,6 +182,42 @@ static inline struct exofs_i_info *exofs_i(struct inode *inode) | |||
| 130 | /************************* | 182 | /************************* |
| 131 | * function declarations * | 183 | * function declarations * |
| 132 | *************************/ | 184 | *************************/ |
| 185 | |||
| 186 | /* ios.c */ | ||
| 187 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], | ||
| 188 | const struct osd_obj_id *obj); | ||
| 189 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, | ||
| 190 | u64 offset, void *p, unsigned length); | ||
| 191 | |||
| 192 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** ios); | ||
| 193 | void exofs_put_io_state(struct exofs_io_state *ios); | ||
| 194 | |||
| 195 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid); | ||
| 196 | |||
| 197 | int exofs_sbi_create(struct exofs_io_state *ios); | ||
| 198 | int exofs_sbi_remove(struct exofs_io_state *ios); | ||
| 199 | int exofs_sbi_write(struct exofs_io_state *ios); | ||
| 200 | int exofs_sbi_read(struct exofs_io_state *ios); | ||
| 201 | |||
| 202 | int extract_attr_from_ios(struct exofs_io_state *ios, struct osd_attr *attr); | ||
| 203 | |||
| 204 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 new_len); | ||
| 205 | static inline int exofs_oi_write(struct exofs_i_info *oi, | ||
| 206 | struct exofs_io_state *ios) | ||
| 207 | { | ||
| 208 | ios->obj.id = exofs_oi_objno(oi); | ||
| 209 | ios->cred = oi->i_cred; | ||
| 210 | return exofs_sbi_write(ios); | ||
| 211 | } | ||
| 212 | |||
| 213 | static inline int exofs_oi_read(struct exofs_i_info *oi, | ||
| 214 | struct exofs_io_state *ios) | ||
| 215 | { | ||
| 216 | ios->obj.id = exofs_oi_objno(oi); | ||
| 217 | ios->cred = oi->i_cred; | ||
| 218 | return exofs_sbi_read(ios); | ||
| 219 | } | ||
| 220 | |||
| 133 | /* inode.c */ | 221 | /* inode.c */ |
| 134 | void exofs_truncate(struct inode *inode); | 222 | void exofs_truncate(struct inode *inode); |
| 135 | int exofs_setattr(struct dentry *, struct iattr *); | 223 | int exofs_setattr(struct dentry *, struct iattr *); |
| @@ -169,6 +257,7 @@ extern const struct file_operations exofs_file_operations; | |||
| 169 | 257 | ||
| 170 | /* inode.c */ | 258 | /* inode.c */ |
| 171 | extern const struct address_space_operations exofs_aops; | 259 | extern const struct address_space_operations exofs_aops; |
| 260 | extern const struct osd_attr g_attr_logical_length; | ||
| 172 | 261 | ||
| 173 | /* namei.c */ | 262 | /* namei.c */ |
| 174 | extern const struct inode_operations exofs_dir_inode_operations; | 263 | extern const struct inode_operations exofs_dir_inode_operations; |
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 6c10f7476699..698a8636d39c 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c | |||
| @@ -37,15 +37,18 @@ | |||
| 37 | 37 | ||
| 38 | #include "exofs.h" | 38 | #include "exofs.h" |
| 39 | 39 | ||
| 40 | #ifdef CONFIG_EXOFS_DEBUG | 40 | #define EXOFS_DBGMSG2(M...) do {} while (0) |
| 41 | # define EXOFS_DEBUG_OBJ_ISIZE 1 | 41 | |
| 42 | #endif | 42 | enum { BIO_MAX_PAGES_KMALLOC = |
| 43 | (PAGE_SIZE - sizeof(struct bio)) / sizeof(struct bio_vec), | ||
| 44 | }; | ||
| 43 | 45 | ||
| 44 | struct page_collect { | 46 | struct page_collect { |
| 45 | struct exofs_sb_info *sbi; | 47 | struct exofs_sb_info *sbi; |
| 46 | struct request_queue *req_q; | 48 | struct request_queue *req_q; |
| 47 | struct inode *inode; | 49 | struct inode *inode; |
| 48 | unsigned expected_pages; | 50 | unsigned expected_pages; |
| 51 | struct exofs_io_state *ios; | ||
| 49 | 52 | ||
| 50 | struct bio *bio; | 53 | struct bio *bio; |
| 51 | unsigned nr_pages; | 54 | unsigned nr_pages; |
| @@ -54,22 +57,23 @@ struct page_collect { | |||
| 54 | }; | 57 | }; |
| 55 | 58 | ||
| 56 | static void _pcol_init(struct page_collect *pcol, unsigned expected_pages, | 59 | static void _pcol_init(struct page_collect *pcol, unsigned expected_pages, |
| 57 | struct inode *inode) | 60 | struct inode *inode) |
| 58 | { | 61 | { |
| 59 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; | 62 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; |
| 60 | 63 | ||
| 61 | pcol->sbi = sbi; | 64 | pcol->sbi = sbi; |
| 62 | pcol->req_q = osd_request_queue(sbi->s_dev); | 65 | /* Create master bios on first Q, later on cloning, each clone will be |
| 66 | * allocated on it's destination Q | ||
| 67 | */ | ||
| 68 | pcol->req_q = osd_request_queue(sbi->s_ods[0]); | ||
| 63 | pcol->inode = inode; | 69 | pcol->inode = inode; |
| 64 | pcol->expected_pages = expected_pages; | 70 | pcol->expected_pages = expected_pages; |
| 65 | 71 | ||
| 72 | pcol->ios = NULL; | ||
| 66 | pcol->bio = NULL; | 73 | pcol->bio = NULL; |
| 67 | pcol->nr_pages = 0; | 74 | pcol->nr_pages = 0; |
| 68 | pcol->length = 0; | 75 | pcol->length = 0; |
| 69 | pcol->pg_first = -1; | 76 | pcol->pg_first = -1; |
| 70 | |||
| 71 | EXOFS_DBGMSG("_pcol_init ino=0x%lx expected_pages=%u\n", inode->i_ino, | ||
| 72 | expected_pages); | ||
| 73 | } | 77 | } |
| 74 | 78 | ||
| 75 | static void _pcol_reset(struct page_collect *pcol) | 79 | static void _pcol_reset(struct page_collect *pcol) |
| @@ -80,35 +84,49 @@ static void _pcol_reset(struct page_collect *pcol) | |||
| 80 | pcol->nr_pages = 0; | 84 | pcol->nr_pages = 0; |
| 81 | pcol->length = 0; | 85 | pcol->length = 0; |
| 82 | pcol->pg_first = -1; | 86 | pcol->pg_first = -1; |
| 83 | EXOFS_DBGMSG("_pcol_reset ino=0x%lx expected_pages=%u\n", | 87 | pcol->ios = NULL; |
| 84 | pcol->inode->i_ino, pcol->expected_pages); | ||
| 85 | 88 | ||
| 86 | /* this is probably the end of the loop but in writes | 89 | /* this is probably the end of the loop but in writes |
| 87 | * it might not end here. don't be left with nothing | 90 | * it might not end here. don't be left with nothing |
| 88 | */ | 91 | */ |
| 89 | if (!pcol->expected_pages) | 92 | if (!pcol->expected_pages) |
| 90 | pcol->expected_pages = 128; | 93 | pcol->expected_pages = BIO_MAX_PAGES_KMALLOC; |
| 91 | } | 94 | } |
| 92 | 95 | ||
| 93 | static int pcol_try_alloc(struct page_collect *pcol) | 96 | static int pcol_try_alloc(struct page_collect *pcol) |
| 94 | { | 97 | { |
| 95 | int pages = min_t(unsigned, pcol->expected_pages, BIO_MAX_PAGES); | 98 | int pages = min_t(unsigned, pcol->expected_pages, |
| 99 | BIO_MAX_PAGES_KMALLOC); | ||
| 100 | |||
| 101 | if (!pcol->ios) { /* First time allocate io_state */ | ||
| 102 | int ret = exofs_get_io_state(pcol->sbi, &pcol->ios); | ||
| 103 | |||
| 104 | if (ret) | ||
| 105 | return ret; | ||
| 106 | } | ||
| 96 | 107 | ||
| 97 | for (; pages; pages >>= 1) { | 108 | for (; pages; pages >>= 1) { |
| 98 | pcol->bio = bio_alloc(GFP_KERNEL, pages); | 109 | pcol->bio = bio_kmalloc(GFP_KERNEL, pages); |
| 99 | if (likely(pcol->bio)) | 110 | if (likely(pcol->bio)) |
| 100 | return 0; | 111 | return 0; |
| 101 | } | 112 | } |
| 102 | 113 | ||
| 103 | EXOFS_ERR("Failed to kcalloc expected_pages=%u\n", | 114 | EXOFS_ERR("Failed to bio_kmalloc expected_pages=%u\n", |
| 104 | pcol->expected_pages); | 115 | pcol->expected_pages); |
| 105 | return -ENOMEM; | 116 | return -ENOMEM; |
| 106 | } | 117 | } |
| 107 | 118 | ||
| 108 | static void pcol_free(struct page_collect *pcol) | 119 | static void pcol_free(struct page_collect *pcol) |
| 109 | { | 120 | { |
| 110 | bio_put(pcol->bio); | 121 | if (pcol->bio) { |
| 111 | pcol->bio = NULL; | 122 | bio_put(pcol->bio); |
| 123 | pcol->bio = NULL; | ||
| 124 | } | ||
| 125 | |||
| 126 | if (pcol->ios) { | ||
| 127 | exofs_put_io_state(pcol->ios); | ||
| 128 | pcol->ios = NULL; | ||
| 129 | } | ||
| 112 | } | 130 | } |
| 113 | 131 | ||
| 114 | static int pcol_add_page(struct page_collect *pcol, struct page *page, | 132 | static int pcol_add_page(struct page_collect *pcol, struct page *page, |
| @@ -161,22 +179,17 @@ static void update_write_page(struct page *page, int ret) | |||
| 161 | /* Called at the end of reads, to optionally unlock pages and update their | 179 | /* Called at the end of reads, to optionally unlock pages and update their |
| 162 | * status. | 180 | * status. |
| 163 | */ | 181 | */ |
| 164 | static int __readpages_done(struct osd_request *or, struct page_collect *pcol, | 182 | static int __readpages_done(struct page_collect *pcol, bool do_unlock) |
| 165 | bool do_unlock) | ||
| 166 | { | 183 | { |
| 167 | struct bio_vec *bvec; | 184 | struct bio_vec *bvec; |
| 168 | int i; | 185 | int i; |
| 169 | u64 resid; | 186 | u64 resid; |
| 170 | u64 good_bytes; | 187 | u64 good_bytes; |
| 171 | u64 length = 0; | 188 | u64 length = 0; |
| 172 | int ret = exofs_check_ok_resid(or, &resid, NULL); | 189 | int ret = exofs_check_io(pcol->ios, &resid); |
| 173 | |||
| 174 | osd_end_request(or); | ||
| 175 | 190 | ||
| 176 | if (likely(!ret)) | 191 | if (likely(!ret)) |
| 177 | good_bytes = pcol->length; | 192 | good_bytes = pcol->length; |
| 178 | else if (!resid) | ||
| 179 | good_bytes = 0; | ||
| 180 | else | 193 | else |
| 181 | good_bytes = pcol->length - resid; | 194 | good_bytes = pcol->length - resid; |
| 182 | 195 | ||
| @@ -198,7 +211,7 @@ static int __readpages_done(struct osd_request *or, struct page_collect *pcol, | |||
| 198 | else | 211 | else |
| 199 | page_stat = ret; | 212 | page_stat = ret; |
| 200 | 213 | ||
| 201 | EXOFS_DBGMSG(" readpages_done(0x%lx, 0x%lx) %s\n", | 214 | EXOFS_DBGMSG2(" readpages_done(0x%lx, 0x%lx) %s\n", |
| 202 | inode->i_ino, page->index, | 215 | inode->i_ino, page->index, |
| 203 | page_stat ? "bad_bytes" : "good_bytes"); | 216 | page_stat ? "bad_bytes" : "good_bytes"); |
| 204 | 217 | ||
| @@ -214,13 +227,13 @@ static int __readpages_done(struct osd_request *or, struct page_collect *pcol, | |||
| 214 | } | 227 | } |
| 215 | 228 | ||
| 216 | /* callback of async reads */ | 229 | /* callback of async reads */ |
| 217 | static void readpages_done(struct osd_request *or, void *p) | 230 | static void readpages_done(struct exofs_io_state *ios, void *p) |
| 218 | { | 231 | { |
| 219 | struct page_collect *pcol = p; | 232 | struct page_collect *pcol = p; |
| 220 | 233 | ||
| 221 | __readpages_done(or, pcol, true); | 234 | __readpages_done(pcol, true); |
| 222 | atomic_dec(&pcol->sbi->s_curr_pending); | 235 | atomic_dec(&pcol->sbi->s_curr_pending); |
| 223 | kfree(p); | 236 | kfree(pcol); |
| 224 | } | 237 | } |
| 225 | 238 | ||
| 226 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) | 239 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) |
| @@ -238,17 +251,13 @@ static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) | |||
| 238 | 251 | ||
| 239 | unlock_page(page); | 252 | unlock_page(page); |
| 240 | } | 253 | } |
| 241 | pcol_free(pcol); | ||
| 242 | } | 254 | } |
| 243 | 255 | ||
| 244 | static int read_exec(struct page_collect *pcol, bool is_sync) | 256 | static int read_exec(struct page_collect *pcol, bool is_sync) |
| 245 | { | 257 | { |
| 246 | struct exofs_i_info *oi = exofs_i(pcol->inode); | 258 | struct exofs_i_info *oi = exofs_i(pcol->inode); |
| 247 | struct osd_obj_id obj = {pcol->sbi->s_pid, | 259 | struct exofs_io_state *ios = pcol->ios; |
| 248 | pcol->inode->i_ino + EXOFS_OBJ_OFF}; | ||
| 249 | struct osd_request *or = NULL; | ||
| 250 | struct page_collect *pcol_copy = NULL; | 260 | struct page_collect *pcol_copy = NULL; |
| 251 | loff_t i_start = pcol->pg_first << PAGE_CACHE_SHIFT; | ||
| 252 | int ret; | 261 | int ret; |
| 253 | 262 | ||
| 254 | if (!pcol->bio) | 263 | if (!pcol->bio) |
| @@ -257,17 +266,13 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
| 257 | /* see comment in _readpage() about sync reads */ | 266 | /* see comment in _readpage() about sync reads */ |
| 258 | WARN_ON(is_sync && (pcol->nr_pages != 1)); | 267 | WARN_ON(is_sync && (pcol->nr_pages != 1)); |
| 259 | 268 | ||
| 260 | or = osd_start_request(pcol->sbi->s_dev, GFP_KERNEL); | 269 | ios->bio = pcol->bio; |
| 261 | if (unlikely(!or)) { | 270 | ios->length = pcol->length; |
| 262 | ret = -ENOMEM; | 271 | ios->offset = pcol->pg_first << PAGE_CACHE_SHIFT; |
| 263 | goto err; | ||
| 264 | } | ||
| 265 | |||
| 266 | osd_req_read(or, &obj, i_start, pcol->bio, pcol->length); | ||
| 267 | 272 | ||
| 268 | if (is_sync) { | 273 | if (is_sync) { |
| 269 | exofs_sync_op(or, pcol->sbi->s_timeout, oi->i_cred); | 274 | exofs_oi_read(oi, pcol->ios); |
| 270 | return __readpages_done(or, pcol, false); | 275 | return __readpages_done(pcol, false); |
| 271 | } | 276 | } |
| 272 | 277 | ||
| 273 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); | 278 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); |
| @@ -277,14 +282,16 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
| 277 | } | 282 | } |
| 278 | 283 | ||
| 279 | *pcol_copy = *pcol; | 284 | *pcol_copy = *pcol; |
| 280 | ret = exofs_async_op(or, readpages_done, pcol_copy, oi->i_cred); | 285 | ios->done = readpages_done; |
| 286 | ios->private = pcol_copy; | ||
| 287 | ret = exofs_oi_read(oi, ios); | ||
| 281 | if (unlikely(ret)) | 288 | if (unlikely(ret)) |
| 282 | goto err; | 289 | goto err; |
| 283 | 290 | ||
| 284 | atomic_inc(&pcol->sbi->s_curr_pending); | 291 | atomic_inc(&pcol->sbi->s_curr_pending); |
| 285 | 292 | ||
| 286 | EXOFS_DBGMSG("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", | 293 | EXOFS_DBGMSG("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", |
| 287 | obj.id, _LLU(i_start), pcol->length); | 294 | ios->obj.id, _LLU(ios->offset), pcol->length); |
| 288 | 295 | ||
| 289 | /* pages ownership was passed to pcol_copy */ | 296 | /* pages ownership was passed to pcol_copy */ |
| 290 | _pcol_reset(pcol); | 297 | _pcol_reset(pcol); |
| @@ -293,12 +300,10 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
| 293 | err: | 300 | err: |
| 294 | if (!is_sync) | 301 | if (!is_sync) |
| 295 | _unlock_pcol_pages(pcol, ret, READ); | 302 | _unlock_pcol_pages(pcol, ret, READ); |
| 296 | else /* Pages unlocked by caller in sync mode only free bio */ | 303 | |
| 297 | pcol_free(pcol); | 304 | pcol_free(pcol); |
| 298 | 305 | ||
| 299 | kfree(pcol_copy); | 306 | kfree(pcol_copy); |
| 300 | if (or) | ||
| 301 | osd_end_request(or); | ||
| 302 | return ret; | 307 | return ret; |
| 303 | } | 308 | } |
| 304 | 309 | ||
| @@ -370,12 +375,12 @@ try_again: | |||
| 370 | if (len != PAGE_CACHE_SIZE) | 375 | if (len != PAGE_CACHE_SIZE) |
| 371 | zero_user(page, len, PAGE_CACHE_SIZE - len); | 376 | zero_user(page, len, PAGE_CACHE_SIZE - len); |
| 372 | 377 | ||
| 373 | EXOFS_DBGMSG(" readpage_strip(0x%lx, 0x%lx) len=0x%zx\n", | 378 | EXOFS_DBGMSG2(" readpage_strip(0x%lx, 0x%lx) len=0x%zx\n", |
| 374 | inode->i_ino, page->index, len); | 379 | inode->i_ino, page->index, len); |
| 375 | 380 | ||
| 376 | ret = pcol_add_page(pcol, page, len); | 381 | ret = pcol_add_page(pcol, page, len); |
| 377 | if (ret) { | 382 | if (ret) { |
| 378 | EXOFS_DBGMSG("Failed pcol_add_page pages[i]=%p " | 383 | EXOFS_DBGMSG2("Failed pcol_add_page pages[i]=%p " |
| 379 | "this_len=0x%zx nr_pages=%u length=0x%lx\n", | 384 | "this_len=0x%zx nr_pages=%u length=0x%lx\n", |
| 380 | page, len, pcol->nr_pages, pcol->length); | 385 | page, len, pcol->nr_pages, pcol->length); |
| 381 | 386 | ||
| @@ -419,9 +424,8 @@ static int _readpage(struct page *page, bool is_sync) | |||
| 419 | 424 | ||
| 420 | _pcol_init(&pcol, 1, page->mapping->host); | 425 | _pcol_init(&pcol, 1, page->mapping->host); |
| 421 | 426 | ||
| 422 | /* readpage_strip might call read_exec(,async) inside at several places | 427 | /* readpage_strip might call read_exec(,is_sync==false) at several |
| 423 | * but this is safe for is_async=0 since read_exec will not do anything | 428 | * places but not if we have a single page. |
| 424 | * when we have a single page. | ||
| 425 | */ | 429 | */ |
| 426 | ret = readpage_strip(&pcol, page); | 430 | ret = readpage_strip(&pcol, page); |
| 427 | if (ret) { | 431 | if (ret) { |
| @@ -440,8 +444,8 @@ static int exofs_readpage(struct file *file, struct page *page) | |||
| 440 | return _readpage(page, false); | 444 | return _readpage(page, false); |
| 441 | } | 445 | } |
| 442 | 446 | ||
| 443 | /* Callback for osd_write. All writes are asynchronouse */ | 447 | /* Callback for osd_write. All writes are asynchronous */ |
| 444 | static void writepages_done(struct osd_request *or, void *p) | 448 | static void writepages_done(struct exofs_io_state *ios, void *p) |
| 445 | { | 449 | { |
| 446 | struct page_collect *pcol = p; | 450 | struct page_collect *pcol = p; |
| 447 | struct bio_vec *bvec; | 451 | struct bio_vec *bvec; |
| @@ -449,16 +453,12 @@ static void writepages_done(struct osd_request *or, void *p) | |||
| 449 | u64 resid; | 453 | u64 resid; |
| 450 | u64 good_bytes; | 454 | u64 good_bytes; |
| 451 | u64 length = 0; | 455 | u64 length = 0; |
| 456 | int ret = exofs_check_io(ios, &resid); | ||
| 452 | 457 | ||
| 453 | int ret = exofs_check_ok_resid(or, NULL, &resid); | ||
| 454 | |||
| 455 | osd_end_request(or); | ||
| 456 | atomic_dec(&pcol->sbi->s_curr_pending); | 458 | atomic_dec(&pcol->sbi->s_curr_pending); |
| 457 | 459 | ||
| 458 | if (likely(!ret)) | 460 | if (likely(!ret)) |
| 459 | good_bytes = pcol->length; | 461 | good_bytes = pcol->length; |
| 460 | else if (!resid) | ||
| 461 | good_bytes = 0; | ||
| 462 | else | 462 | else |
| 463 | good_bytes = pcol->length - resid; | 463 | good_bytes = pcol->length - resid; |
| 464 | 464 | ||
| @@ -482,7 +482,7 @@ static void writepages_done(struct osd_request *or, void *p) | |||
| 482 | 482 | ||
| 483 | update_write_page(page, page_stat); | 483 | update_write_page(page, page_stat); |
| 484 | unlock_page(page); | 484 | unlock_page(page); |
| 485 | EXOFS_DBGMSG(" writepages_done(0x%lx, 0x%lx) status=%d\n", | 485 | EXOFS_DBGMSG2(" writepages_done(0x%lx, 0x%lx) status=%d\n", |
| 486 | inode->i_ino, page->index, page_stat); | 486 | inode->i_ino, page->index, page_stat); |
| 487 | 487 | ||
| 488 | length += bvec->bv_len; | 488 | length += bvec->bv_len; |
| @@ -496,23 +496,13 @@ static void writepages_done(struct osd_request *or, void *p) | |||
| 496 | static int write_exec(struct page_collect *pcol) | 496 | static int write_exec(struct page_collect *pcol) |
| 497 | { | 497 | { |
| 498 | struct exofs_i_info *oi = exofs_i(pcol->inode); | 498 | struct exofs_i_info *oi = exofs_i(pcol->inode); |
| 499 | struct osd_obj_id obj = {pcol->sbi->s_pid, | 499 | struct exofs_io_state *ios = pcol->ios; |
| 500 | pcol->inode->i_ino + EXOFS_OBJ_OFF}; | ||
| 501 | struct osd_request *or = NULL; | ||
| 502 | struct page_collect *pcol_copy = NULL; | 500 | struct page_collect *pcol_copy = NULL; |
| 503 | loff_t i_start = pcol->pg_first << PAGE_CACHE_SHIFT; | ||
| 504 | int ret; | 501 | int ret; |
| 505 | 502 | ||
| 506 | if (!pcol->bio) | 503 | if (!pcol->bio) |
| 507 | return 0; | 504 | return 0; |
| 508 | 505 | ||
| 509 | or = osd_start_request(pcol->sbi->s_dev, GFP_KERNEL); | ||
| 510 | if (unlikely(!or)) { | ||
| 511 | EXOFS_ERR("write_exec: Faild to osd_start_request()\n"); | ||
| 512 | ret = -ENOMEM; | ||
| 513 | goto err; | ||
| 514 | } | ||
| 515 | |||
| 516 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); | 506 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); |
| 517 | if (!pcol_copy) { | 507 | if (!pcol_copy) { |
| 518 | EXOFS_ERR("write_exec: Faild to kmalloc(pcol)\n"); | 508 | EXOFS_ERR("write_exec: Faild to kmalloc(pcol)\n"); |
| @@ -523,16 +513,22 @@ static int write_exec(struct page_collect *pcol) | |||
| 523 | *pcol_copy = *pcol; | 513 | *pcol_copy = *pcol; |
| 524 | 514 | ||
| 525 | pcol_copy->bio->bi_rw |= (1 << BIO_RW); /* FIXME: bio_set_dir() */ | 515 | pcol_copy->bio->bi_rw |= (1 << BIO_RW); /* FIXME: bio_set_dir() */ |
| 526 | osd_req_write(or, &obj, i_start, pcol_copy->bio, pcol_copy->length); | 516 | |
| 527 | ret = exofs_async_op(or, writepages_done, pcol_copy, oi->i_cred); | 517 | ios->bio = pcol_copy->bio; |
| 518 | ios->offset = pcol_copy->pg_first << PAGE_CACHE_SHIFT; | ||
| 519 | ios->length = pcol_copy->length; | ||
| 520 | ios->done = writepages_done; | ||
| 521 | ios->private = pcol_copy; | ||
| 522 | |||
| 523 | ret = exofs_oi_write(oi, ios); | ||
| 528 | if (unlikely(ret)) { | 524 | if (unlikely(ret)) { |
| 529 | EXOFS_ERR("write_exec: exofs_async_op() Faild\n"); | 525 | EXOFS_ERR("write_exec: exofs_oi_write() Faild\n"); |
| 530 | goto err; | 526 | goto err; |
| 531 | } | 527 | } |
| 532 | 528 | ||
| 533 | atomic_inc(&pcol->sbi->s_curr_pending); | 529 | atomic_inc(&pcol->sbi->s_curr_pending); |
| 534 | EXOFS_DBGMSG("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", | 530 | EXOFS_DBGMSG("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", |
| 535 | pcol->inode->i_ino, pcol->pg_first, _LLU(i_start), | 531 | pcol->inode->i_ino, pcol->pg_first, _LLU(ios->offset), |
| 536 | pcol->length); | 532 | pcol->length); |
| 537 | /* pages ownership was passed to pcol_copy */ | 533 | /* pages ownership was passed to pcol_copy */ |
| 538 | _pcol_reset(pcol); | 534 | _pcol_reset(pcol); |
| @@ -540,9 +536,9 @@ static int write_exec(struct page_collect *pcol) | |||
| 540 | 536 | ||
| 541 | err: | 537 | err: |
| 542 | _unlock_pcol_pages(pcol, ret, WRITE); | 538 | _unlock_pcol_pages(pcol, ret, WRITE); |
| 539 | pcol_free(pcol); | ||
| 543 | kfree(pcol_copy); | 540 | kfree(pcol_copy); |
| 544 | if (or) | 541 | |
| 545 | osd_end_request(or); | ||
| 546 | return ret; | 542 | return ret; |
| 547 | } | 543 | } |
| 548 | 544 | ||
| @@ -586,6 +582,9 @@ static int writepage_strip(struct page *page, | |||
| 586 | if (PageError(page)) | 582 | if (PageError(page)) |
| 587 | ClearPageError(page); | 583 | ClearPageError(page); |
| 588 | unlock_page(page); | 584 | unlock_page(page); |
| 585 | EXOFS_DBGMSG("writepage_strip(0x%lx, 0x%lx) " | ||
| 586 | "outside the limits\n", | ||
| 587 | inode->i_ino, page->index); | ||
| 589 | return 0; | 588 | return 0; |
| 590 | } | 589 | } |
| 591 | } | 590 | } |
| @@ -600,6 +599,9 @@ try_again: | |||
| 600 | ret = write_exec(pcol); | 599 | ret = write_exec(pcol); |
| 601 | if (unlikely(ret)) | 600 | if (unlikely(ret)) |
| 602 | goto fail; | 601 | goto fail; |
| 602 | |||
| 603 | EXOFS_DBGMSG("writepage_strip(0x%lx, 0x%lx) Discontinuity\n", | ||
| 604 | inode->i_ino, page->index); | ||
| 603 | goto try_again; | 605 | goto try_again; |
| 604 | } | 606 | } |
| 605 | 607 | ||
| @@ -609,7 +611,7 @@ try_again: | |||
| 609 | goto fail; | 611 | goto fail; |
| 610 | } | 612 | } |
| 611 | 613 | ||
| 612 | EXOFS_DBGMSG(" writepage_strip(0x%lx, 0x%lx) len=0x%zx\n", | 614 | EXOFS_DBGMSG2(" writepage_strip(0x%lx, 0x%lx) len=0x%zx\n", |
| 613 | inode->i_ino, page->index, len); | 615 | inode->i_ino, page->index, len); |
| 614 | 616 | ||
| 615 | ret = pcol_add_page(pcol, page, len); | 617 | ret = pcol_add_page(pcol, page, len); |
| @@ -634,6 +636,8 @@ try_again: | |||
| 634 | return 0; | 636 | return 0; |
| 635 | 637 | ||
| 636 | fail: | 638 | fail: |
| 639 | EXOFS_DBGMSG("Error: writepage_strip(0x%lx, 0x%lx)=>%d\n", | ||
| 640 | inode->i_ino, page->index, ret); | ||
| 637 | set_bit(AS_EIO, &page->mapping->flags); | 641 | set_bit(AS_EIO, &page->mapping->flags); |
| 638 | unlock_page(page); | 642 | unlock_page(page); |
| 639 | return ret; | 643 | return ret; |
| @@ -652,14 +656,17 @@ static int exofs_writepages(struct address_space *mapping, | |||
| 652 | wbc->range_end >> PAGE_CACHE_SHIFT; | 656 | wbc->range_end >> PAGE_CACHE_SHIFT; |
| 653 | 657 | ||
| 654 | if (start || end) | 658 | if (start || end) |
| 655 | expected_pages = min(end - start + 1, 32L); | 659 | expected_pages = end - start + 1; |
| 656 | else | 660 | else |
| 657 | expected_pages = mapping->nrpages; | 661 | expected_pages = mapping->nrpages; |
| 658 | 662 | ||
| 659 | EXOFS_DBGMSG("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx" | 663 | if (expected_pages < 32L) |
| 660 | " m->nrpages=%lu start=0x%lx end=0x%lx\n", | 664 | expected_pages = 32L; |
| 665 | |||
| 666 | EXOFS_DBGMSG("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx " | ||
| 667 | "nrpages=%lu start=0x%lx end=0x%lx expected_pages=%ld\n", | ||
| 661 | mapping->host->i_ino, wbc->range_start, wbc->range_end, | 668 | mapping->host->i_ino, wbc->range_start, wbc->range_end, |
| 662 | mapping->nrpages, start, end); | 669 | mapping->nrpages, start, end, expected_pages); |
| 663 | 670 | ||
| 664 | _pcol_init(&pcol, expected_pages, mapping->host); | 671 | _pcol_init(&pcol, expected_pages, mapping->host); |
| 665 | 672 | ||
| @@ -771,19 +778,28 @@ static int exofs_get_block(struct inode *inode, sector_t iblock, | |||
| 771 | const struct osd_attr g_attr_logical_length = ATTR_DEF( | 778 | const struct osd_attr g_attr_logical_length = ATTR_DEF( |
| 772 | OSD_APAGE_OBJECT_INFORMATION, OSD_ATTR_OI_LOGICAL_LENGTH, 8); | 779 | OSD_APAGE_OBJECT_INFORMATION, OSD_ATTR_OI_LOGICAL_LENGTH, 8); |
| 773 | 780 | ||
| 781 | static int _do_truncate(struct inode *inode) | ||
| 782 | { | ||
| 783 | struct exofs_i_info *oi = exofs_i(inode); | ||
| 784 | loff_t isize = i_size_read(inode); | ||
| 785 | int ret; | ||
| 786 | |||
| 787 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; | ||
| 788 | |||
| 789 | nobh_truncate_page(inode->i_mapping, isize, exofs_get_block); | ||
| 790 | |||
| 791 | ret = exofs_oi_truncate(oi, (u64)isize); | ||
| 792 | EXOFS_DBGMSG("(0x%lx) size=0x%llx\n", inode->i_ino, isize); | ||
| 793 | return ret; | ||
| 794 | } | ||
| 795 | |||
| 774 | /* | 796 | /* |
| 775 | * Truncate a file to the specified size - all we have to do is set the size | 797 | * Truncate a file to the specified size - all we have to do is set the size |
| 776 | * attribute. We make sure the object exists first. | 798 | * attribute. We make sure the object exists first. |
| 777 | */ | 799 | */ |
| 778 | void exofs_truncate(struct inode *inode) | 800 | void exofs_truncate(struct inode *inode) |
| 779 | { | 801 | { |
| 780 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; | ||
| 781 | struct exofs_i_info *oi = exofs_i(inode); | 802 | struct exofs_i_info *oi = exofs_i(inode); |
| 782 | struct osd_obj_id obj = {sbi->s_pid, inode->i_ino + EXOFS_OBJ_OFF}; | ||
| 783 | struct osd_request *or; | ||
| 784 | struct osd_attr attr; | ||
| 785 | loff_t isize = i_size_read(inode); | ||
| 786 | __be64 newsize; | ||
| 787 | int ret; | 803 | int ret; |
| 788 | 804 | ||
| 789 | if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) | 805 | if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) |
| @@ -793,22 +809,6 @@ void exofs_truncate(struct inode *inode) | |||
| 793 | return; | 809 | return; |
| 794 | if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) | 810 | if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) |
| 795 | return; | 811 | return; |
| 796 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; | ||
| 797 | |||
| 798 | nobh_truncate_page(inode->i_mapping, isize, exofs_get_block); | ||
| 799 | |||
| 800 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | ||
| 801 | if (unlikely(!or)) { | ||
| 802 | EXOFS_ERR("ERROR: exofs_truncate: osd_start_request failed\n"); | ||
| 803 | goto fail; | ||
| 804 | } | ||
| 805 | |||
| 806 | osd_req_set_attributes(or, &obj); | ||
| 807 | |||
| 808 | newsize = cpu_to_be64((u64)isize); | ||
| 809 | attr = g_attr_logical_length; | ||
| 810 | attr.val_ptr = &newsize; | ||
| 811 | osd_req_add_set_attr_list(or, &attr, 1); | ||
| 812 | 812 | ||
| 813 | /* if we are about to truncate an object, and it hasn't been | 813 | /* if we are about to truncate an object, and it hasn't been |
| 814 | * created yet, wait | 814 | * created yet, wait |
| @@ -816,8 +816,7 @@ void exofs_truncate(struct inode *inode) | |||
| 816 | if (unlikely(wait_obj_created(oi))) | 816 | if (unlikely(wait_obj_created(oi))) |
| 817 | goto fail; | 817 | goto fail; |
| 818 | 818 | ||
| 819 | ret = exofs_sync_op(or, sbi->s_timeout, oi->i_cred); | 819 | ret = _do_truncate(inode); |
| 820 | osd_end_request(or); | ||
| 821 | if (ret) | 820 | if (ret) |
| 822 | goto fail; | 821 | goto fail; |
| 823 | 822 | ||
| @@ -847,65 +846,62 @@ int exofs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
| 847 | 846 | ||
| 848 | /* | 847 | /* |
| 849 | * Read an inode from the OSD, and return it as is. We also return the size | 848 | * Read an inode from the OSD, and return it as is. We also return the size |
| 850 | * attribute in the 'sanity' argument if we got compiled with debugging turned | 849 | * attribute in the 'obj_size' argument. |
| 851 | * on. | ||
| 852 | */ | 850 | */ |
| 853 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | 851 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, |
| 854 | struct exofs_fcb *inode, uint64_t *sanity) | 852 | struct exofs_fcb *inode, uint64_t *obj_size) |
| 855 | { | 853 | { |
| 856 | struct exofs_sb_info *sbi = sb->s_fs_info; | 854 | struct exofs_sb_info *sbi = sb->s_fs_info; |
| 857 | struct osd_request *or; | 855 | struct osd_attr attrs[2]; |
| 858 | struct osd_attr attr; | 856 | struct exofs_io_state *ios; |
| 859 | struct osd_obj_id obj = {sbi->s_pid, | ||
| 860 | oi->vfs_inode.i_ino + EXOFS_OBJ_OFF}; | ||
| 861 | int ret; | 857 | int ret; |
| 862 | 858 | ||
| 863 | exofs_make_credential(oi->i_cred, &obj); | 859 | *obj_size = ~0; |
| 864 | 860 | ret = exofs_get_io_state(sbi, &ios); | |
| 865 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 861 | if (unlikely(ret)) { |
| 866 | if (unlikely(!or)) { | 862 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
| 867 | EXOFS_ERR("exofs_get_inode: osd_start_request failed.\n"); | 863 | return ret; |
| 868 | return -ENOMEM; | ||
| 869 | } | 864 | } |
| 870 | osd_req_get_attributes(or, &obj); | ||
| 871 | 865 | ||
| 872 | /* we need the inode attribute */ | 866 | ios->obj.id = exofs_oi_objno(oi); |
| 873 | osd_req_add_get_attr_list(or, &g_attr_inode_data, 1); | 867 | exofs_make_credential(oi->i_cred, &ios->obj); |
| 868 | ios->cred = oi->i_cred; | ||
| 874 | 869 | ||
| 875 | #ifdef EXOFS_DEBUG_OBJ_ISIZE | 870 | attrs[0] = g_attr_inode_data; |
| 876 | /* we get the size attributes to do a sanity check */ | 871 | attrs[1] = g_attr_logical_length; |
| 877 | osd_req_add_get_attr_list(or, &g_attr_logical_length, 1); | 872 | ios->in_attr = attrs; |
| 878 | #endif | 873 | ios->in_attr_len = ARRAY_SIZE(attrs); |
| 879 | 874 | ||
| 880 | ret = exofs_sync_op(or, sbi->s_timeout, oi->i_cred); | 875 | ret = exofs_sbi_read(ios); |
| 881 | if (ret) | 876 | if (ret) |
| 882 | goto out; | 877 | goto out; |
| 883 | 878 | ||
| 884 | attr = g_attr_inode_data; | 879 | ret = extract_attr_from_ios(ios, &attrs[0]); |
| 885 | ret = extract_attr_from_req(or, &attr); | ||
| 886 | if (ret) { | 880 | if (ret) { |
| 887 | EXOFS_ERR("exofs_get_inode: extract_attr_from_req failed\n"); | 881 | EXOFS_ERR("%s: extract_attr of inode_data failed\n", __func__); |
| 888 | goto out; | 882 | goto out; |
| 889 | } | 883 | } |
| 884 | WARN_ON(attrs[0].len != EXOFS_INO_ATTR_SIZE); | ||
| 885 | memcpy(inode, attrs[0].val_ptr, EXOFS_INO_ATTR_SIZE); | ||
| 890 | 886 | ||
| 891 | WARN_ON(attr.len != EXOFS_INO_ATTR_SIZE); | 887 | ret = extract_attr_from_ios(ios, &attrs[1]); |
| 892 | memcpy(inode, attr.val_ptr, EXOFS_INO_ATTR_SIZE); | ||
| 893 | |||
| 894 | #ifdef EXOFS_DEBUG_OBJ_ISIZE | ||
| 895 | attr = g_attr_logical_length; | ||
| 896 | ret = extract_attr_from_req(or, &attr); | ||
| 897 | if (ret) { | 888 | if (ret) { |
| 898 | EXOFS_ERR("ERROR: extract attr from or failed\n"); | 889 | EXOFS_ERR("%s: extract_attr of logical_length failed\n", |
| 890 | __func__); | ||
| 899 | goto out; | 891 | goto out; |
| 900 | } | 892 | } |
| 901 | *sanity = get_unaligned_be64(attr.val_ptr); | 893 | *obj_size = get_unaligned_be64(attrs[1].val_ptr); |
| 902 | #endif | ||
| 903 | 894 | ||
| 904 | out: | 895 | out: |
| 905 | osd_end_request(or); | 896 | exofs_put_io_state(ios); |
| 906 | return ret; | 897 | return ret; |
| 907 | } | 898 | } |
| 908 | 899 | ||
| 900 | static void __oi_init(struct exofs_i_info *oi) | ||
| 901 | { | ||
| 902 | init_waitqueue_head(&oi->i_wq); | ||
| 903 | oi->i_flags = 0; | ||
| 904 | } | ||
| 909 | /* | 905 | /* |
| 910 | * Fill in an inode read from the OSD and set it up for use | 906 | * Fill in an inode read from the OSD and set it up for use |
| 911 | */ | 907 | */ |
| @@ -914,7 +910,7 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
| 914 | struct exofs_i_info *oi; | 910 | struct exofs_i_info *oi; |
| 915 | struct exofs_fcb fcb; | 911 | struct exofs_fcb fcb; |
| 916 | struct inode *inode; | 912 | struct inode *inode; |
| 917 | uint64_t uninitialized_var(sanity); | 913 | uint64_t obj_size; |
| 918 | int ret; | 914 | int ret; |
| 919 | 915 | ||
| 920 | inode = iget_locked(sb, ino); | 916 | inode = iget_locked(sb, ino); |
| @@ -923,13 +919,13 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
| 923 | if (!(inode->i_state & I_NEW)) | 919 | if (!(inode->i_state & I_NEW)) |
| 924 | return inode; | 920 | return inode; |
| 925 | oi = exofs_i(inode); | 921 | oi = exofs_i(inode); |
| 922 | __oi_init(oi); | ||
| 926 | 923 | ||
| 927 | /* read the inode from the osd */ | 924 | /* read the inode from the osd */ |
| 928 | ret = exofs_get_inode(sb, oi, &fcb, &sanity); | 925 | ret = exofs_get_inode(sb, oi, &fcb, &obj_size); |
| 929 | if (ret) | 926 | if (ret) |
| 930 | goto bad_inode; | 927 | goto bad_inode; |
| 931 | 928 | ||
| 932 | init_waitqueue_head(&oi->i_wq); | ||
| 933 | set_obj_created(oi); | 929 | set_obj_created(oi); |
| 934 | 930 | ||
| 935 | /* copy stuff from on-disk struct to in-memory struct */ | 931 | /* copy stuff from on-disk struct to in-memory struct */ |
| @@ -947,14 +943,12 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
| 947 | inode->i_blkbits = EXOFS_BLKSHIFT; | 943 | inode->i_blkbits = EXOFS_BLKSHIFT; |
| 948 | inode->i_generation = le32_to_cpu(fcb.i_generation); | 944 | inode->i_generation = le32_to_cpu(fcb.i_generation); |
| 949 | 945 | ||
| 950 | #ifdef EXOFS_DEBUG_OBJ_ISIZE | 946 | if ((inode->i_size != obj_size) && |
| 951 | if ((inode->i_size != sanity) && | ||
| 952 | (!exofs_inode_is_fast_symlink(inode))) { | 947 | (!exofs_inode_is_fast_symlink(inode))) { |
| 953 | EXOFS_ERR("WARNING: Size of object from inode and " | 948 | EXOFS_ERR("WARNING: Size of inode=%llu != object=%llu\n", |
| 954 | "attributes differ (%lld != %llu)\n", | 949 | inode->i_size, _LLU(obj_size)); |
| 955 | inode->i_size, _LLU(sanity)); | 950 | /* FIXME: call exofs_inode_recovery() */ |
| 956 | } | 951 | } |
| 957 | #endif | ||
| 958 | 952 | ||
| 959 | oi->i_dir_start_lookup = 0; | 953 | oi->i_dir_start_lookup = 0; |
| 960 | 954 | ||
| @@ -1020,23 +1014,30 @@ int __exofs_wait_obj_created(struct exofs_i_info *oi) | |||
| 1020 | * set the obj_created flag so that other methods know that the object exists on | 1014 | * set the obj_created flag so that other methods know that the object exists on |
| 1021 | * the OSD. | 1015 | * the OSD. |
| 1022 | */ | 1016 | */ |
| 1023 | static void create_done(struct osd_request *or, void *p) | 1017 | static void create_done(struct exofs_io_state *ios, void *p) |
| 1024 | { | 1018 | { |
| 1025 | struct inode *inode = p; | 1019 | struct inode *inode = p; |
| 1026 | struct exofs_i_info *oi = exofs_i(inode); | 1020 | struct exofs_i_info *oi = exofs_i(inode); |
| 1027 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; | 1021 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; |
| 1028 | int ret; | 1022 | int ret; |
| 1029 | 1023 | ||
| 1030 | ret = exofs_check_ok(or); | 1024 | ret = exofs_check_io(ios, NULL); |
| 1031 | osd_end_request(or); | 1025 | exofs_put_io_state(ios); |
| 1026 | |||
| 1032 | atomic_dec(&sbi->s_curr_pending); | 1027 | atomic_dec(&sbi->s_curr_pending); |
| 1033 | 1028 | ||
| 1034 | if (unlikely(ret)) { | 1029 | if (unlikely(ret)) { |
| 1035 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", | 1030 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", |
| 1036 | _LLU(sbi->s_pid), _LLU(inode->i_ino + EXOFS_OBJ_OFF)); | 1031 | _LLU(exofs_oi_objno(oi)), _LLU(sbi->s_pid)); |
| 1037 | make_bad_inode(inode); | 1032 | /*TODO: When FS is corrupted creation can fail, object already |
| 1038 | } else | 1033 | * exist. Get rid of this asynchronous creation, if exist |
| 1039 | set_obj_created(oi); | 1034 | * increment the obj counter and try the next object. Until we |
| 1035 | * succeed. All these dangling objects will be made into lost | ||
| 1036 | * files by chkfs.exofs | ||
| 1037 | */ | ||
| 1038 | } | ||
| 1039 | |||
| 1040 | set_obj_created(oi); | ||
| 1040 | 1041 | ||
| 1041 | atomic_dec(&inode->i_count); | 1042 | atomic_dec(&inode->i_count); |
| 1042 | wake_up(&oi->i_wq); | 1043 | wake_up(&oi->i_wq); |
| @@ -1051,8 +1052,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) | |||
| 1051 | struct inode *inode; | 1052 | struct inode *inode; |
| 1052 | struct exofs_i_info *oi; | 1053 | struct exofs_i_info *oi; |
| 1053 | struct exofs_sb_info *sbi; | 1054 | struct exofs_sb_info *sbi; |
| 1054 | struct osd_request *or; | 1055 | struct exofs_io_state *ios; |
| 1055 | struct osd_obj_id obj; | ||
| 1056 | int ret; | 1056 | int ret; |
| 1057 | 1057 | ||
| 1058 | sb = dir->i_sb; | 1058 | sb = dir->i_sb; |
| @@ -1061,8 +1061,8 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) | |||
| 1061 | return ERR_PTR(-ENOMEM); | 1061 | return ERR_PTR(-ENOMEM); |
| 1062 | 1062 | ||
| 1063 | oi = exofs_i(inode); | 1063 | oi = exofs_i(inode); |
| 1064 | __oi_init(oi); | ||
| 1064 | 1065 | ||
| 1065 | init_waitqueue_head(&oi->i_wq); | ||
| 1066 | set_obj_2bcreated(oi); | 1066 | set_obj_2bcreated(oi); |
| 1067 | 1067 | ||
| 1068 | sbi = sb->s_fs_info; | 1068 | sbi = sb->s_fs_info; |
| @@ -1089,28 +1089,28 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) | |||
| 1089 | 1089 | ||
| 1090 | mark_inode_dirty(inode); | 1090 | mark_inode_dirty(inode); |
| 1091 | 1091 | ||
| 1092 | obj.partition = sbi->s_pid; | 1092 | ret = exofs_get_io_state(sbi, &ios); |
| 1093 | obj.id = inode->i_ino + EXOFS_OBJ_OFF; | 1093 | if (unlikely(ret)) { |
| 1094 | exofs_make_credential(oi->i_cred, &obj); | 1094 | EXOFS_ERR("exofs_new_inode: exofs_get_io_state failed\n"); |
| 1095 | 1095 | return ERR_PTR(ret); | |
| 1096 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | ||
| 1097 | if (unlikely(!or)) { | ||
| 1098 | EXOFS_ERR("exofs_new_inode: osd_start_request failed\n"); | ||
| 1099 | return ERR_PTR(-ENOMEM); | ||
| 1100 | } | 1096 | } |
| 1101 | 1097 | ||
| 1102 | osd_req_create_object(or, &obj); | 1098 | ios->obj.id = exofs_oi_objno(oi); |
| 1099 | exofs_make_credential(oi->i_cred, &ios->obj); | ||
| 1103 | 1100 | ||
| 1104 | /* increment the refcount so that the inode will still be around when we | 1101 | /* increment the refcount so that the inode will still be around when we |
| 1105 | * reach the callback | 1102 | * reach the callback |
| 1106 | */ | 1103 | */ |
| 1107 | atomic_inc(&inode->i_count); | 1104 | atomic_inc(&inode->i_count); |
| 1108 | 1105 | ||
| 1109 | ret = exofs_async_op(or, create_done, inode, oi->i_cred); | 1106 | ios->done = create_done; |
| 1107 | ios->private = inode; | ||
| 1108 | ios->cred = oi->i_cred; | ||
| 1109 | ret = exofs_sbi_create(ios); | ||
| 1110 | if (ret) { | 1110 | if (ret) { |
| 1111 | atomic_dec(&inode->i_count); | 1111 | atomic_dec(&inode->i_count); |
| 1112 | osd_end_request(or); | 1112 | exofs_put_io_state(ios); |
| 1113 | return ERR_PTR(-EIO); | 1113 | return ERR_PTR(ret); |
| 1114 | } | 1114 | } |
| 1115 | atomic_inc(&sbi->s_curr_pending); | 1115 | atomic_inc(&sbi->s_curr_pending); |
| 1116 | 1116 | ||
| @@ -1128,11 +1128,11 @@ struct updatei_args { | |||
| 1128 | /* | 1128 | /* |
| 1129 | * Callback function from exofs_update_inode(). | 1129 | * Callback function from exofs_update_inode(). |
| 1130 | */ | 1130 | */ |
| 1131 | static void updatei_done(struct osd_request *or, void *p) | 1131 | static void updatei_done(struct exofs_io_state *ios, void *p) |
| 1132 | { | 1132 | { |
| 1133 | struct updatei_args *args = p; | 1133 | struct updatei_args *args = p; |
| 1134 | 1134 | ||
| 1135 | osd_end_request(or); | 1135 | exofs_put_io_state(ios); |
| 1136 | 1136 | ||
| 1137 | atomic_dec(&args->sbi->s_curr_pending); | 1137 | atomic_dec(&args->sbi->s_curr_pending); |
| 1138 | 1138 | ||
| @@ -1148,8 +1148,7 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
| 1148 | struct exofs_i_info *oi = exofs_i(inode); | 1148 | struct exofs_i_info *oi = exofs_i(inode); |
| 1149 | struct super_block *sb = inode->i_sb; | 1149 | struct super_block *sb = inode->i_sb; |
| 1150 | struct exofs_sb_info *sbi = sb->s_fs_info; | 1150 | struct exofs_sb_info *sbi = sb->s_fs_info; |
| 1151 | struct osd_obj_id obj = {sbi->s_pid, inode->i_ino + EXOFS_OBJ_OFF}; | 1151 | struct exofs_io_state *ios; |
| 1152 | struct osd_request *or; | ||
| 1153 | struct osd_attr attr; | 1152 | struct osd_attr attr; |
| 1154 | struct exofs_fcb *fcb; | 1153 | struct exofs_fcb *fcb; |
| 1155 | struct updatei_args *args; | 1154 | struct updatei_args *args; |
| @@ -1186,18 +1185,16 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
| 1186 | } else | 1185 | } else |
| 1187 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); | 1186 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); |
| 1188 | 1187 | ||
| 1189 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 1188 | ret = exofs_get_io_state(sbi, &ios); |
| 1190 | if (unlikely(!or)) { | 1189 | if (unlikely(ret)) { |
| 1191 | EXOFS_ERR("exofs_update_inode: osd_start_request failed.\n"); | 1190 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
| 1192 | ret = -ENOMEM; | ||
| 1193 | goto free_args; | 1191 | goto free_args; |
| 1194 | } | 1192 | } |
| 1195 | 1193 | ||
| 1196 | osd_req_set_attributes(or, &obj); | ||
| 1197 | |||
| 1198 | attr = g_attr_inode_data; | 1194 | attr = g_attr_inode_data; |
| 1199 | attr.val_ptr = fcb; | 1195 | attr.val_ptr = fcb; |
| 1200 | osd_req_add_set_attr_list(or, &attr, 1); | 1196 | ios->out_attr_len = 1; |
| 1197 | ios->out_attr = &attr; | ||
| 1201 | 1198 | ||
| 1202 | if (!obj_created(oi)) { | 1199 | if (!obj_created(oi)) { |
| 1203 | EXOFS_DBGMSG("!obj_created\n"); | 1200 | EXOFS_DBGMSG("!obj_created\n"); |
| @@ -1206,22 +1203,19 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
| 1206 | EXOFS_DBGMSG("wait_event done\n"); | 1203 | EXOFS_DBGMSG("wait_event done\n"); |
| 1207 | } | 1204 | } |
| 1208 | 1205 | ||
| 1209 | if (do_sync) { | 1206 | if (!do_sync) { |
| 1210 | ret = exofs_sync_op(or, sbi->s_timeout, oi->i_cred); | ||
| 1211 | osd_end_request(or); | ||
| 1212 | goto free_args; | ||
| 1213 | } else { | ||
| 1214 | args->sbi = sbi; | 1207 | args->sbi = sbi; |
| 1208 | ios->done = updatei_done; | ||
| 1209 | ios->private = args; | ||
| 1210 | } | ||
| 1215 | 1211 | ||
| 1216 | ret = exofs_async_op(or, updatei_done, args, oi->i_cred); | 1212 | ret = exofs_oi_write(oi, ios); |
| 1217 | if (ret) { | 1213 | if (!do_sync && !ret) { |
| 1218 | osd_end_request(or); | ||
| 1219 | goto free_args; | ||
| 1220 | } | ||
| 1221 | atomic_inc(&sbi->s_curr_pending); | 1214 | atomic_inc(&sbi->s_curr_pending); |
| 1222 | goto out; /* deallocation in updatei_done */ | 1215 | goto out; /* deallocation in updatei_done */ |
| 1223 | } | 1216 | } |
| 1224 | 1217 | ||
| 1218 | exofs_put_io_state(ios); | ||
| 1225 | free_args: | 1219 | free_args: |
| 1226 | kfree(args); | 1220 | kfree(args); |
| 1227 | out: | 1221 | out: |
| @@ -1238,11 +1232,12 @@ int exofs_write_inode(struct inode *inode, int wait) | |||
| 1238 | * Callback function from exofs_delete_inode() - don't have much cleaning up to | 1232 | * Callback function from exofs_delete_inode() - don't have much cleaning up to |
| 1239 | * do. | 1233 | * do. |
| 1240 | */ | 1234 | */ |
| 1241 | static void delete_done(struct osd_request *or, void *p) | 1235 | static void delete_done(struct exofs_io_state *ios, void *p) |
| 1242 | { | 1236 | { |
| 1243 | struct exofs_sb_info *sbi; | 1237 | struct exofs_sb_info *sbi = p; |
| 1244 | osd_end_request(or); | 1238 | |
| 1245 | sbi = p; | 1239 | exofs_put_io_state(ios); |
| 1240 | |||
| 1246 | atomic_dec(&sbi->s_curr_pending); | 1241 | atomic_dec(&sbi->s_curr_pending); |
| 1247 | } | 1242 | } |
| 1248 | 1243 | ||
| @@ -1256,8 +1251,7 @@ void exofs_delete_inode(struct inode *inode) | |||
| 1256 | struct exofs_i_info *oi = exofs_i(inode); | 1251 | struct exofs_i_info *oi = exofs_i(inode); |
| 1257 | struct super_block *sb = inode->i_sb; | 1252 | struct super_block *sb = inode->i_sb; |
| 1258 | struct exofs_sb_info *sbi = sb->s_fs_info; | 1253 | struct exofs_sb_info *sbi = sb->s_fs_info; |
| 1259 | struct osd_obj_id obj = {sbi->s_pid, inode->i_ino + EXOFS_OBJ_OFF}; | 1254 | struct exofs_io_state *ios; |
| 1260 | struct osd_request *or; | ||
| 1261 | int ret; | 1255 | int ret; |
| 1262 | 1256 | ||
| 1263 | truncate_inode_pages(&inode->i_data, 0); | 1257 | truncate_inode_pages(&inode->i_data, 0); |
| @@ -1274,25 +1268,26 @@ void exofs_delete_inode(struct inode *inode) | |||
| 1274 | 1268 | ||
| 1275 | clear_inode(inode); | 1269 | clear_inode(inode); |
| 1276 | 1270 | ||
| 1277 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 1271 | ret = exofs_get_io_state(sbi, &ios); |
| 1278 | if (unlikely(!or)) { | 1272 | if (unlikely(ret)) { |
| 1279 | EXOFS_ERR("exofs_delete_inode: osd_start_request failed\n"); | 1273 | EXOFS_ERR("%s: exofs_get_io_state failed\n", __func__); |
| 1280 | return; | 1274 | return; |
| 1281 | } | 1275 | } |
| 1282 | 1276 | ||
| 1283 | osd_req_remove_object(or, &obj); | ||
| 1284 | |||
| 1285 | /* if we are deleting an obj that hasn't been created yet, wait */ | 1277 | /* if we are deleting an obj that hasn't been created yet, wait */ |
| 1286 | if (!obj_created(oi)) { | 1278 | if (!obj_created(oi)) { |
| 1287 | BUG_ON(!obj_2bcreated(oi)); | 1279 | BUG_ON(!obj_2bcreated(oi)); |
| 1288 | wait_event(oi->i_wq, obj_created(oi)); | 1280 | wait_event(oi->i_wq, obj_created(oi)); |
| 1289 | } | 1281 | } |
| 1290 | 1282 | ||
| 1291 | ret = exofs_async_op(or, delete_done, sbi, oi->i_cred); | 1283 | ios->obj.id = exofs_oi_objno(oi); |
| 1284 | ios->done = delete_done; | ||
| 1285 | ios->private = sbi; | ||
| 1286 | ios->cred = oi->i_cred; | ||
| 1287 | ret = exofs_sbi_remove(ios); | ||
| 1292 | if (ret) { | 1288 | if (ret) { |
| 1293 | EXOFS_ERR( | 1289 | EXOFS_ERR("%s: exofs_sbi_remove failed\n", __func__); |
| 1294 | "ERROR: @exofs_delete_inode exofs_async_op failed\n"); | 1290 | exofs_put_io_state(ios); |
| 1295 | osd_end_request(or); | ||
| 1296 | return; | 1291 | return; |
| 1297 | } | 1292 | } |
| 1298 | atomic_inc(&sbi->s_curr_pending); | 1293 | atomic_inc(&sbi->s_curr_pending); |
diff --git a/fs/exofs/ios.c b/fs/exofs/ios.c new file mode 100644 index 000000000000..5bad01fa1f9f --- /dev/null +++ b/fs/exofs/ios.c | |||
| @@ -0,0 +1,421 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (C) 2005, 2006 | ||
| 3 | * Avishay Traeger (avishay@gmail.com) | ||
| 4 | * Copyright (C) 2008, 2009 | ||
| 5 | * Boaz Harrosh <bharrosh@panasas.com> | ||
| 6 | * | ||
| 7 | * This file is part of exofs. | ||
| 8 | * | ||
| 9 | * exofs is free software; you can redistribute it and/or modify | ||
| 10 | * it under the terms of the GNU General Public License as published by | ||
| 11 | * the Free Software Foundation. Since it is based on ext2, and the only | ||
| 12 | * valid version of GPL for the Linux kernel is version 2, the only valid | ||
| 13 | * version of GPL for exofs is version 2. | ||
| 14 | * | ||
| 15 | * exofs is distributed in the hope that it will be useful, | ||
| 16 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 17 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 18 | * GNU General Public License for more details. | ||
| 19 | * | ||
| 20 | * You should have received a copy of the GNU General Public License | ||
| 21 | * along with exofs; if not, write to the Free Software | ||
| 22 | * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 23 | */ | ||
| 24 | |||
| 25 | #include <scsi/scsi_device.h> | ||
| 26 | |||
| 27 | #include "exofs.h" | ||
| 28 | |||
| 29 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) | ||
| 30 | { | ||
| 31 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); | ||
| 32 | } | ||
| 33 | |||
| 34 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, | ||
| 35 | u64 offset, void *p, unsigned length) | ||
| 36 | { | ||
| 37 | struct osd_request *or = osd_start_request(od, GFP_KERNEL); | ||
| 38 | /* struct osd_sense_info osi = {.key = 0};*/ | ||
| 39 | int ret; | ||
| 40 | |||
| 41 | if (unlikely(!or)) { | ||
| 42 | EXOFS_DBGMSG("%s: osd_start_request failed.\n", __func__); | ||
| 43 | return -ENOMEM; | ||
| 44 | } | ||
| 45 | ret = osd_req_read_kern(or, obj, offset, p, length); | ||
| 46 | if (unlikely(ret)) { | ||
| 47 | EXOFS_DBGMSG("%s: osd_req_read_kern failed.\n", __func__); | ||
| 48 | goto out; | ||
| 49 | } | ||
| 50 | |||
| 51 | ret = osd_finalize_request(or, 0, cred, NULL); | ||
| 52 | if (unlikely(ret)) { | ||
| 53 | EXOFS_DBGMSG("Faild to osd_finalize_request() => %d\n", ret); | ||
| 54 | goto out; | ||
| 55 | } | ||
| 56 | |||
| 57 | ret = osd_execute_request(or); | ||
| 58 | if (unlikely(ret)) | ||
| 59 | EXOFS_DBGMSG("osd_execute_request() => %d\n", ret); | ||
| 60 | /* osd_req_decode_sense(or, ret); */ | ||
| 61 | |||
| 62 | out: | ||
| 63 | osd_end_request(or); | ||
| 64 | return ret; | ||
| 65 | } | ||
| 66 | |||
| 67 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** pios) | ||
| 68 | { | ||
| 69 | struct exofs_io_state *ios; | ||
| 70 | |||
| 71 | /*TODO: Maybe use kmem_cach per sbi of size | ||
| 72 | * exofs_io_state_size(sbi->s_numdevs) | ||
| 73 | */ | ||
| 74 | ios = kzalloc(exofs_io_state_size(sbi->s_numdevs), GFP_KERNEL); | ||
| 75 | if (unlikely(!ios)) { | ||
| 76 | *pios = NULL; | ||
| 77 | return -ENOMEM; | ||
| 78 | } | ||
| 79 | |||
| 80 | ios->sbi = sbi; | ||
| 81 | ios->obj.partition = sbi->s_pid; | ||
| 82 | *pios = ios; | ||
| 83 | return 0; | ||
| 84 | } | ||
| 85 | |||
| 86 | void exofs_put_io_state(struct exofs_io_state *ios) | ||
| 87 | { | ||
| 88 | if (ios) { | ||
| 89 | unsigned i; | ||
| 90 | |||
| 91 | for (i = 0; i < ios->numdevs; i++) { | ||
| 92 | struct exofs_per_dev_state *per_dev = &ios->per_dev[i]; | ||
| 93 | |||
| 94 | if (per_dev->or) | ||
| 95 | osd_end_request(per_dev->or); | ||
| 96 | if (per_dev->bio) | ||
| 97 | bio_put(per_dev->bio); | ||
| 98 | } | ||
| 99 | |||
| 100 | kfree(ios); | ||
| 101 | } | ||
| 102 | } | ||
| 103 | |||
| 104 | static void _sync_done(struct exofs_io_state *ios, void *p) | ||
| 105 | { | ||
| 106 | struct completion *waiting = p; | ||
| 107 | |||
| 108 | complete(waiting); | ||
| 109 | } | ||
| 110 | |||
| 111 | static void _last_io(struct kref *kref) | ||
| 112 | { | ||
| 113 | struct exofs_io_state *ios = container_of( | ||
| 114 | kref, struct exofs_io_state, kref); | ||
| 115 | |||
| 116 | ios->done(ios, ios->private); | ||
| 117 | } | ||
| 118 | |||
| 119 | static void _done_io(struct osd_request *or, void *p) | ||
| 120 | { | ||
| 121 | struct exofs_io_state *ios = p; | ||
| 122 | |||
| 123 | kref_put(&ios->kref, _last_io); | ||
| 124 | } | ||
| 125 | |||
| 126 | static int exofs_io_execute(struct exofs_io_state *ios) | ||
| 127 | { | ||
| 128 | DECLARE_COMPLETION_ONSTACK(wait); | ||
| 129 | bool sync = (ios->done == NULL); | ||
| 130 | int i, ret; | ||
| 131 | |||
| 132 | if (sync) { | ||
| 133 | ios->done = _sync_done; | ||
| 134 | ios->private = &wait; | ||
| 135 | } | ||
| 136 | |||
| 137 | for (i = 0; i < ios->numdevs; i++) { | ||
| 138 | struct osd_request *or = ios->per_dev[i].or; | ||
| 139 | if (unlikely(!or)) | ||
| 140 | continue; | ||
| 141 | |||
| 142 | ret = osd_finalize_request(or, 0, ios->cred, NULL); | ||
| 143 | if (unlikely(ret)) { | ||
| 144 | EXOFS_DBGMSG("Faild to osd_finalize_request() => %d\n", | ||
| 145 | ret); | ||
| 146 | return ret; | ||
| 147 | } | ||
| 148 | } | ||
| 149 | |||
| 150 | kref_init(&ios->kref); | ||
| 151 | |||
| 152 | for (i = 0; i < ios->numdevs; i++) { | ||
| 153 | struct osd_request *or = ios->per_dev[i].or; | ||
| 154 | if (unlikely(!or)) | ||
| 155 | continue; | ||
| 156 | |||
| 157 | kref_get(&ios->kref); | ||
| 158 | osd_execute_request_async(or, _done_io, ios); | ||
| 159 | } | ||
| 160 | |||
| 161 | kref_put(&ios->kref, _last_io); | ||
| 162 | ret = 0; | ||
| 163 | |||
| 164 | if (sync) { | ||
| 165 | wait_for_completion(&wait); | ||
| 166 | ret = exofs_check_io(ios, NULL); | ||
| 167 | } | ||
| 168 | return ret; | ||
| 169 | } | ||
| 170 | |||
| 171 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | ||
| 172 | { | ||
| 173 | enum osd_err_priority acumulated_osd_err = 0; | ||
| 174 | int acumulated_lin_err = 0; | ||
| 175 | int i; | ||
| 176 | |||
| 177 | for (i = 0; i < ios->numdevs; i++) { | ||
| 178 | struct osd_sense_info osi; | ||
| 179 | int ret = osd_req_decode_sense(ios->per_dev[i].or, &osi); | ||
| 180 | |||
| 181 | if (likely(!ret)) | ||
| 182 | continue; | ||
| 183 | |||
| 184 | if (unlikely(ret == -EFAULT)) { | ||
| 185 | EXOFS_DBGMSG("%s: EFAULT Need page clear\n", __func__); | ||
| 186 | /*FIXME: All the pages in this device range should: | ||
| 187 | * clear_highpage(page); | ||
| 188 | */ | ||
| 189 | } | ||
| 190 | |||
| 191 | if (osi.osd_err_pri >= acumulated_osd_err) { | ||
| 192 | acumulated_osd_err = osi.osd_err_pri; | ||
| 193 | acumulated_lin_err = ret; | ||
| 194 | } | ||
| 195 | } | ||
| 196 | |||
| 197 | /* TODO: raid specific residual calculations */ | ||
| 198 | if (resid) { | ||
| 199 | if (likely(!acumulated_lin_err)) | ||
| 200 | *resid = 0; | ||
| 201 | else | ||
| 202 | *resid = ios->length; | ||
| 203 | } | ||
| 204 | |||
| 205 | return acumulated_lin_err; | ||
| 206 | } | ||
| 207 | |||
| 208 | int exofs_sbi_create(struct exofs_io_state *ios) | ||
| 209 | { | ||
| 210 | int i, ret; | ||
| 211 | |||
| 212 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | ||
| 213 | struct osd_request *or; | ||
| 214 | |||
| 215 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | ||
| 216 | if (unlikely(!or)) { | ||
| 217 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
| 218 | ret = -ENOMEM; | ||
| 219 | goto out; | ||
| 220 | } | ||
| 221 | ios->per_dev[i].or = or; | ||
| 222 | ios->numdevs++; | ||
| 223 | |||
| 224 | osd_req_create_object(or, &ios->obj); | ||
| 225 | } | ||
| 226 | ret = exofs_io_execute(ios); | ||
| 227 | |||
| 228 | out: | ||
| 229 | return ret; | ||
| 230 | } | ||
| 231 | |||
| 232 | int exofs_sbi_remove(struct exofs_io_state *ios) | ||
| 233 | { | ||
| 234 | int i, ret; | ||
| 235 | |||
| 236 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | ||
| 237 | struct osd_request *or; | ||
| 238 | |||
| 239 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | ||
| 240 | if (unlikely(!or)) { | ||
| 241 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
| 242 | ret = -ENOMEM; | ||
| 243 | goto out; | ||
| 244 | } | ||
| 245 | ios->per_dev[i].or = or; | ||
| 246 | ios->numdevs++; | ||
| 247 | |||
| 248 | osd_req_remove_object(or, &ios->obj); | ||
| 249 | } | ||
| 250 | ret = exofs_io_execute(ios); | ||
| 251 | |||
| 252 | out: | ||
| 253 | return ret; | ||
| 254 | } | ||
| 255 | |||
| 256 | int exofs_sbi_write(struct exofs_io_state *ios) | ||
| 257 | { | ||
| 258 | int i, ret; | ||
| 259 | |||
| 260 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | ||
| 261 | struct osd_request *or; | ||
| 262 | |||
| 263 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | ||
| 264 | if (unlikely(!or)) { | ||
| 265 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
| 266 | ret = -ENOMEM; | ||
| 267 | goto out; | ||
| 268 | } | ||
| 269 | ios->per_dev[i].or = or; | ||
| 270 | ios->numdevs++; | ||
| 271 | |||
| 272 | if (ios->bio) { | ||
| 273 | struct bio *bio; | ||
| 274 | |||
| 275 | if (i != 0) { | ||
| 276 | bio = bio_kmalloc(GFP_KERNEL, | ||
| 277 | ios->bio->bi_max_vecs); | ||
| 278 | if (unlikely(!bio)) { | ||
| 279 | ret = -ENOMEM; | ||
| 280 | goto out; | ||
| 281 | } | ||
| 282 | |||
| 283 | __bio_clone(bio, ios->bio); | ||
| 284 | bio->bi_bdev = NULL; | ||
| 285 | bio->bi_next = NULL; | ||
| 286 | ios->per_dev[i].bio = bio; | ||
| 287 | } else { | ||
| 288 | bio = ios->bio; | ||
| 289 | } | ||
| 290 | |||
| 291 | osd_req_write(or, &ios->obj, ios->offset, bio, | ||
| 292 | ios->length); | ||
| 293 | /* EXOFS_DBGMSG("write sync=%d\n", sync);*/ | ||
| 294 | } else if (ios->kern_buff) { | ||
| 295 | osd_req_write_kern(or, &ios->obj, ios->offset, | ||
| 296 | ios->kern_buff, ios->length); | ||
| 297 | /* EXOFS_DBGMSG("write_kern sync=%d\n", sync);*/ | ||
| 298 | } else { | ||
| 299 | osd_req_set_attributes(or, &ios->obj); | ||
| 300 | /* EXOFS_DBGMSG("set_attributes sync=%d\n", sync);*/ | ||
| 301 | } | ||
| 302 | |||
| 303 | if (ios->out_attr) | ||
| 304 | osd_req_add_set_attr_list(or, ios->out_attr, | ||
| 305 | ios->out_attr_len); | ||
| 306 | |||
| 307 | if (ios->in_attr) | ||
| 308 | osd_req_add_get_attr_list(or, ios->in_attr, | ||
| 309 | ios->in_attr_len); | ||
| 310 | } | ||
| 311 | ret = exofs_io_execute(ios); | ||
| 312 | |||
| 313 | out: | ||
| 314 | return ret; | ||
| 315 | } | ||
| 316 | |||
| 317 | int exofs_sbi_read(struct exofs_io_state *ios) | ||
| 318 | { | ||
| 319 | int i, ret; | ||
| 320 | |||
| 321 | for (i = 0; i < 1; i++) { | ||
| 322 | struct osd_request *or; | ||
| 323 | unsigned first_dev = (unsigned)ios->obj.id; | ||
| 324 | |||
| 325 | first_dev %= ios->sbi->s_numdevs; | ||
| 326 | or = osd_start_request(ios->sbi->s_ods[first_dev], GFP_KERNEL); | ||
| 327 | if (unlikely(!or)) { | ||
| 328 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
| 329 | ret = -ENOMEM; | ||
| 330 | goto out; | ||
| 331 | } | ||
| 332 | ios->per_dev[i].or = or; | ||
| 333 | ios->numdevs++; | ||
| 334 | |||
| 335 | if (ios->bio) { | ||
| 336 | osd_req_read(or, &ios->obj, ios->offset, ios->bio, | ||
| 337 | ios->length); | ||
| 338 | /* EXOFS_DBGMSG("read sync=%d\n", sync);*/ | ||
| 339 | } else if (ios->kern_buff) { | ||
| 340 | osd_req_read_kern(or, &ios->obj, ios->offset, | ||
| 341 | ios->kern_buff, ios->length); | ||
| 342 | /* EXOFS_DBGMSG("read_kern sync=%d\n", sync);*/ | ||
| 343 | } else { | ||
| 344 | osd_req_get_attributes(or, &ios->obj); | ||
| 345 | /* EXOFS_DBGMSG("get_attributes sync=%d\n", sync);*/ | ||
| 346 | } | ||
| 347 | |||
| 348 | if (ios->out_attr) | ||
| 349 | osd_req_add_set_attr_list(or, ios->out_attr, | ||
| 350 | ios->out_attr_len); | ||
| 351 | |||
| 352 | if (ios->in_attr) | ||
| 353 | osd_req_add_get_attr_list(or, ios->in_attr, | ||
| 354 | ios->in_attr_len); | ||
| 355 | } | ||
| 356 | ret = exofs_io_execute(ios); | ||
| 357 | |||
| 358 | out: | ||
| 359 | return ret; | ||
| 360 | } | ||
| 361 | |||
| 362 | int extract_attr_from_ios(struct exofs_io_state *ios, struct osd_attr *attr) | ||
| 363 | { | ||
| 364 | struct osd_attr cur_attr = {.attr_page = 0}; /* start with zeros */ | ||
| 365 | void *iter = NULL; | ||
| 366 | int nelem; | ||
| 367 | |||
| 368 | do { | ||
| 369 | nelem = 1; | ||
| 370 | osd_req_decode_get_attr_list(ios->per_dev[0].or, | ||
| 371 | &cur_attr, &nelem, &iter); | ||
| 372 | if ((cur_attr.attr_page == attr->attr_page) && | ||
| 373 | (cur_attr.attr_id == attr->attr_id)) { | ||
| 374 | attr->len = cur_attr.len; | ||
| 375 | attr->val_ptr = cur_attr.val_ptr; | ||
| 376 | return 0; | ||
| 377 | } | ||
| 378 | } while (iter); | ||
| 379 | |||
| 380 | return -EIO; | ||
| 381 | } | ||
| 382 | |||
| 383 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 size) | ||
| 384 | { | ||
| 385 | struct exofs_sb_info *sbi = oi->vfs_inode.i_sb->s_fs_info; | ||
| 386 | struct exofs_io_state *ios; | ||
| 387 | struct osd_attr attr; | ||
| 388 | __be64 newsize; | ||
| 389 | int i, ret; | ||
| 390 | |||
| 391 | if (exofs_get_io_state(sbi, &ios)) | ||
| 392 | return -ENOMEM; | ||
| 393 | |||
| 394 | ios->obj.id = exofs_oi_objno(oi); | ||
| 395 | ios->cred = oi->i_cred; | ||
| 396 | |||
| 397 | newsize = cpu_to_be64(size); | ||
| 398 | attr = g_attr_logical_length; | ||
| 399 | attr.val_ptr = &newsize; | ||
| 400 | |||
| 401 | for (i = 0; i < sbi->s_numdevs; i++) { | ||
| 402 | struct osd_request *or; | ||
| 403 | |||
| 404 | or = osd_start_request(sbi->s_ods[i], GFP_KERNEL); | ||
| 405 | if (unlikely(!or)) { | ||
| 406 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
| 407 | ret = -ENOMEM; | ||
| 408 | goto out; | ||
| 409 | } | ||
| 410 | ios->per_dev[i].or = or; | ||
| 411 | ios->numdevs++; | ||
| 412 | |||
| 413 | osd_req_set_attributes(or, &ios->obj); | ||
| 414 | osd_req_add_set_attr_list(or, &attr, 1); | ||
| 415 | } | ||
| 416 | ret = exofs_io_execute(ios); | ||
| 417 | |||
| 418 | out: | ||
| 419 | exofs_put_io_state(ios); | ||
| 420 | return ret; | ||
| 421 | } | ||
diff --git a/fs/exofs/osd.c b/fs/exofs/osd.c deleted file mode 100644 index 4372542df284..000000000000 --- a/fs/exofs/osd.c +++ /dev/null | |||
| @@ -1,125 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (C) 2005, 2006 | ||
| 3 | * Avishay Traeger (avishay@gmail.com) | ||
| 4 | * Copyright (C) 2008, 2009 | ||
| 5 | * Boaz Harrosh <bharrosh@panasas.com> | ||
| 6 | * | ||
| 7 | * This file is part of exofs. | ||
| 8 | * | ||
| 9 | * exofs is free software; you can redistribute it and/or modify | ||
| 10 | * it under the terms of the GNU General Public License as published by | ||
| 11 | * the Free Software Foundation. Since it is based on ext2, and the only | ||
| 12 | * valid version of GPL for the Linux kernel is version 2, the only valid | ||
| 13 | * version of GPL for exofs is version 2. | ||
| 14 | * | ||
| 15 | * exofs is distributed in the hope that it will be useful, | ||
| 16 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 17 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 18 | * GNU General Public License for more details. | ||
| 19 | * | ||
| 20 | * You should have received a copy of the GNU General Public License | ||
| 21 | * along with exofs; if not, write to the Free Software | ||
| 22 | * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 23 | */ | ||
| 24 | |||
| 25 | #include <scsi/scsi_device.h> | ||
| 26 | #include <scsi/osd_sense.h> | ||
| 27 | |||
| 28 | #include "exofs.h" | ||
| 29 | |||
| 30 | int exofs_check_ok_resid(struct osd_request *or, u64 *in_resid, u64 *out_resid) | ||
| 31 | { | ||
| 32 | struct osd_sense_info osi; | ||
| 33 | int ret = osd_req_decode_sense(or, &osi); | ||
| 34 | |||
| 35 | if (ret) { /* translate to Linux codes */ | ||
| 36 | if (osi.additional_code == scsi_invalid_field_in_cdb) { | ||
| 37 | if (osi.cdb_field_offset == OSD_CFO_STARTING_BYTE) | ||
| 38 | ret = -EFAULT; | ||
| 39 | if (osi.cdb_field_offset == OSD_CFO_OBJECT_ID) | ||
| 40 | ret = -ENOENT; | ||
| 41 | else | ||
| 42 | ret = -EINVAL; | ||
| 43 | } else if (osi.additional_code == osd_quota_error) | ||
| 44 | ret = -ENOSPC; | ||
| 45 | else | ||
| 46 | ret = -EIO; | ||
| 47 | } | ||
| 48 | |||
| 49 | /* FIXME: should be include in osd_sense_info */ | ||
| 50 | if (in_resid) | ||
| 51 | *in_resid = or->in.req ? or->in.req->resid_len : 0; | ||
| 52 | |||
| 53 | if (out_resid) | ||
| 54 | *out_resid = or->out.req ? or->out.req->resid_len : 0; | ||
| 55 | |||
| 56 | return ret; | ||
| 57 | } | ||
| 58 | |||
| 59 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) | ||
| 60 | { | ||
| 61 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); | ||
| 62 | } | ||
| 63 | |||
| 64 | /* | ||
| 65 | * Perform a synchronous OSD operation. | ||
| 66 | */ | ||
| 67 | int exofs_sync_op(struct osd_request *or, int timeout, uint8_t *credential) | ||
| 68 | { | ||
| 69 | int ret; | ||
| 70 | |||
| 71 | or->timeout = timeout; | ||
| 72 | ret = osd_finalize_request(or, 0, credential, NULL); | ||
| 73 | if (ret) { | ||
| 74 | EXOFS_DBGMSG("Faild to osd_finalize_request() => %d\n", ret); | ||
| 75 | return ret; | ||
| 76 | } | ||
| 77 | |||
| 78 | ret = osd_execute_request(or); | ||
| 79 | |||
| 80 | if (ret) | ||
| 81 | EXOFS_DBGMSG("osd_execute_request() => %d\n", ret); | ||
| 82 | /* osd_req_decode_sense(or, ret); */ | ||
| 83 | return ret; | ||
| 84 | } | ||
| 85 | |||
| 86 | /* | ||
| 87 | * Perform an asynchronous OSD operation. | ||
| 88 | */ | ||
| 89 | int exofs_async_op(struct osd_request *or, osd_req_done_fn *async_done, | ||
| 90 | void *caller_context, u8 *cred) | ||
| 91 | { | ||
| 92 | int ret; | ||
| 93 | |||
| 94 | ret = osd_finalize_request(or, 0, cred, NULL); | ||
| 95 | if (ret) { | ||
| 96 | EXOFS_DBGMSG("Faild to osd_finalize_request() => %d\n", ret); | ||
| 97 | return ret; | ||
| 98 | } | ||
| 99 | |||
| 100 | ret = osd_execute_request_async(or, async_done, caller_context); | ||
| 101 | |||
| 102 | if (ret) | ||
| 103 | EXOFS_DBGMSG("osd_execute_request_async() => %d\n", ret); | ||
| 104 | return ret; | ||
| 105 | } | ||
| 106 | |||
| 107 | int extract_attr_from_req(struct osd_request *or, struct osd_attr *attr) | ||
| 108 | { | ||
| 109 | struct osd_attr cur_attr = {.attr_page = 0}; /* start with zeros */ | ||
| 110 | void *iter = NULL; | ||
| 111 | int nelem; | ||
| 112 | |||
| 113 | do { | ||
| 114 | nelem = 1; | ||
| 115 | osd_req_decode_get_attr_list(or, &cur_attr, &nelem, &iter); | ||
| 116 | if ((cur_attr.attr_page == attr->attr_page) && | ||
| 117 | (cur_attr.attr_id == attr->attr_id)) { | ||
| 118 | attr->len = cur_attr.len; | ||
| 119 | attr->val_ptr = cur_attr.val_ptr; | ||
| 120 | return 0; | ||
| 121 | } | ||
| 122 | } while (iter); | ||
| 123 | |||
| 124 | return -EIO; | ||
| 125 | } | ||
diff --git a/fs/exofs/pnfs.h b/fs/exofs/pnfs.h new file mode 100644 index 000000000000..423033addd1f --- /dev/null +++ b/fs/exofs/pnfs.h | |||
| @@ -0,0 +1,51 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (C) 2008, 2009 | ||
| 3 | * Boaz Harrosh <bharrosh@panasas.com> | ||
| 4 | * | ||
| 5 | * This file is part of exofs. | ||
| 6 | * | ||
| 7 | * exofs is free software; you can redistribute it and/or modify it under the | ||
| 8 | * terms of the GNU General Public License version 2 as published by the Free | ||
| 9 | * Software Foundation. | ||
| 10 | * | ||
| 11 | */ | ||
| 12 | |||
| 13 | /* FIXME: Remove this file once pnfs hits mainline */ | ||
| 14 | |||
| 15 | #ifndef __EXOFS_PNFS_H__ | ||
| 16 | #define __EXOFS_PNFS_H__ | ||
| 17 | |||
| 18 | #if defined(CONFIG_PNFS) | ||
| 19 | |||
| 20 | |||
| 21 | /* FIXME: move this file to: linux/exportfs/pnfs_osd_xdr.h */ | ||
| 22 | #include "../nfs/objlayout/pnfs_osd_xdr.h" | ||
| 23 | |||
| 24 | #else /* defined(CONFIG_PNFS) */ | ||
| 25 | |||
| 26 | enum pnfs_iomode { | ||
| 27 | IOMODE_READ = 1, | ||
| 28 | IOMODE_RW = 2, | ||
| 29 | IOMODE_ANY = 3, | ||
| 30 | }; | ||
| 31 | |||
| 32 | /* Layout Structure */ | ||
| 33 | enum pnfs_osd_raid_algorithm4 { | ||
| 34 | PNFS_OSD_RAID_0 = 1, | ||
| 35 | PNFS_OSD_RAID_4 = 2, | ||
| 36 | PNFS_OSD_RAID_5 = 3, | ||
| 37 | PNFS_OSD_RAID_PQ = 4 /* Reed-Solomon P+Q */ | ||
| 38 | }; | ||
| 39 | |||
| 40 | struct pnfs_osd_data_map { | ||
| 41 | u32 odm_num_comps; | ||
| 42 | u64 odm_stripe_unit; | ||
| 43 | u32 odm_group_width; | ||
| 44 | u32 odm_group_depth; | ||
| 45 | u32 odm_mirror_cnt; | ||
| 46 | u32 odm_raid_algorithm; | ||
| 47 | }; | ||
| 48 | |||
| 49 | #endif /* else defined(CONFIG_PNFS) */ | ||
| 50 | |||
| 51 | #endif /* __EXOFS_PNFS_H__ */ | ||
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index 9f500dec3b59..a1d1e77b12eb 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c | |||
| @@ -203,49 +203,45 @@ int exofs_sync_fs(struct super_block *sb, int wait) | |||
| 203 | { | 203 | { |
| 204 | struct exofs_sb_info *sbi; | 204 | struct exofs_sb_info *sbi; |
| 205 | struct exofs_fscb *fscb; | 205 | struct exofs_fscb *fscb; |
| 206 | struct osd_request *or; | 206 | struct exofs_io_state *ios; |
| 207 | struct osd_obj_id obj; | ||
| 208 | int ret = -ENOMEM; | 207 | int ret = -ENOMEM; |
| 209 | 208 | ||
| 210 | fscb = kzalloc(sizeof(struct exofs_fscb), GFP_KERNEL); | ||
| 211 | if (!fscb) { | ||
| 212 | EXOFS_ERR("exofs_write_super: memory allocation failed.\n"); | ||
| 213 | return -ENOMEM; | ||
| 214 | } | ||
| 215 | |||
| 216 | lock_super(sb); | 209 | lock_super(sb); |
| 217 | sbi = sb->s_fs_info; | 210 | sbi = sb->s_fs_info; |
| 211 | fscb = &sbi->s_fscb; | ||
| 212 | |||
| 213 | ret = exofs_get_io_state(sbi, &ios); | ||
| 214 | if (ret) | ||
| 215 | goto out; | ||
| 216 | |||
| 217 | /* Note: We only write the changing part of the fscb. .i.e upto the | ||
| 218 | * the fscb->s_dev_table_oid member. There is no read-modify-write | ||
| 219 | * here. | ||
| 220 | */ | ||
| 221 | ios->length = offsetof(struct exofs_fscb, s_dev_table_oid); | ||
| 222 | memset(fscb, 0, ios->length); | ||
| 218 | fscb->s_nextid = cpu_to_le64(sbi->s_nextid); | 223 | fscb->s_nextid = cpu_to_le64(sbi->s_nextid); |
| 219 | fscb->s_numfiles = cpu_to_le32(sbi->s_numfiles); | 224 | fscb->s_numfiles = cpu_to_le32(sbi->s_numfiles); |
| 220 | fscb->s_magic = cpu_to_le16(sb->s_magic); | 225 | fscb->s_magic = cpu_to_le16(sb->s_magic); |
| 221 | fscb->s_newfs = 0; | 226 | fscb->s_newfs = 0; |
| 227 | fscb->s_version = EXOFS_FSCB_VER; | ||
| 222 | 228 | ||
| 223 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 229 | ios->obj.id = EXOFS_SUPER_ID; |
| 224 | if (unlikely(!or)) { | 230 | ios->offset = 0; |
| 225 | EXOFS_ERR("exofs_write_super: osd_start_request failed.\n"); | 231 | ios->kern_buff = fscb; |
| 226 | goto out; | 232 | ios->cred = sbi->s_cred; |
| 227 | } | ||
| 228 | 233 | ||
| 229 | obj.partition = sbi->s_pid; | 234 | ret = exofs_sbi_write(ios); |
| 230 | obj.id = EXOFS_SUPER_ID; | ||
| 231 | ret = osd_req_write_kern(or, &obj, 0, fscb, sizeof(*fscb)); | ||
| 232 | if (unlikely(ret)) { | 235 | if (unlikely(ret)) { |
| 233 | EXOFS_ERR("exofs_write_super: osd_req_write_kern failed.\n"); | 236 | EXOFS_ERR("%s: exofs_sbi_write failed.\n", __func__); |
| 234 | goto out; | ||
| 235 | } | ||
| 236 | |||
| 237 | ret = exofs_sync_op(or, sbi->s_timeout, sbi->s_cred); | ||
| 238 | if (unlikely(ret)) { | ||
| 239 | EXOFS_ERR("exofs_write_super: exofs_sync_op failed.\n"); | ||
| 240 | goto out; | 237 | goto out; |
| 241 | } | 238 | } |
| 242 | sb->s_dirt = 0; | 239 | sb->s_dirt = 0; |
| 243 | 240 | ||
| 244 | out: | 241 | out: |
| 245 | if (or) | 242 | EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret); |
| 246 | osd_end_request(or); | 243 | exofs_put_io_state(ios); |
| 247 | unlock_super(sb); | 244 | unlock_super(sb); |
| 248 | kfree(fscb); | ||
| 249 | return ret; | 245 | return ret; |
| 250 | } | 246 | } |
| 251 | 247 | ||
| @@ -257,6 +253,29 @@ static void exofs_write_super(struct super_block *sb) | |||
| 257 | sb->s_dirt = 0; | 253 | sb->s_dirt = 0; |
| 258 | } | 254 | } |
| 259 | 255 | ||
| 256 | static void _exofs_print_device(const char *msg, const char *dev_path, | ||
| 257 | struct osd_dev *od, u64 pid) | ||
| 258 | { | ||
| 259 | const struct osd_dev_info *odi = osduld_device_info(od); | ||
| 260 | |||
| 261 | printk(KERN_NOTICE "exofs: %s %s osd_name-%s pid-0x%llx\n", | ||
| 262 | msg, dev_path ?: "", odi->osdname, _LLU(pid)); | ||
| 263 | } | ||
| 264 | |||
| 265 | void exofs_free_sbi(struct exofs_sb_info *sbi) | ||
| 266 | { | ||
| 267 | while (sbi->s_numdevs) { | ||
| 268 | int i = --sbi->s_numdevs; | ||
| 269 | struct osd_dev *od = sbi->s_ods[i]; | ||
| 270 | |||
| 271 | if (od) { | ||
| 272 | sbi->s_ods[i] = NULL; | ||
| 273 | osduld_put_device(od); | ||
| 274 | } | ||
| 275 | } | ||
| 276 | kfree(sbi); | ||
| 277 | } | ||
| 278 | |||
| 260 | /* | 279 | /* |
| 261 | * This function is called when the vfs is freeing the superblock. We just | 280 | * This function is called when the vfs is freeing the superblock. We just |
| 262 | * need to free our own part. | 281 | * need to free our own part. |
| @@ -279,11 +298,182 @@ static void exofs_put_super(struct super_block *sb) | |||
| 279 | msecs_to_jiffies(100)); | 298 | msecs_to_jiffies(100)); |
| 280 | } | 299 | } |
| 281 | 300 | ||
| 282 | osduld_put_device(sbi->s_dev); | 301 | _exofs_print_device("Unmounting", NULL, sbi->s_ods[0], sbi->s_pid); |
| 283 | kfree(sb->s_fs_info); | 302 | |
| 303 | exofs_free_sbi(sbi); | ||
| 284 | sb->s_fs_info = NULL; | 304 | sb->s_fs_info = NULL; |
| 285 | } | 305 | } |
| 286 | 306 | ||
| 307 | static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, | ||
| 308 | struct exofs_device_table *dt) | ||
| 309 | { | ||
| 310 | sbi->data_map.odm_num_comps = | ||
| 311 | le32_to_cpu(dt->dt_data_map.cb_num_comps); | ||
| 312 | sbi->data_map.odm_stripe_unit = | ||
| 313 | le64_to_cpu(dt->dt_data_map.cb_stripe_unit); | ||
| 314 | sbi->data_map.odm_group_width = | ||
| 315 | le32_to_cpu(dt->dt_data_map.cb_group_width); | ||
| 316 | sbi->data_map.odm_group_depth = | ||
| 317 | le32_to_cpu(dt->dt_data_map.cb_group_depth); | ||
| 318 | sbi->data_map.odm_mirror_cnt = | ||
| 319 | le32_to_cpu(dt->dt_data_map.cb_mirror_cnt); | ||
| 320 | sbi->data_map.odm_raid_algorithm = | ||
| 321 | le32_to_cpu(dt->dt_data_map.cb_raid_algorithm); | ||
| 322 | |||
| 323 | /* FIXME: Hard coded mirror only for now. if not so do not mount */ | ||
| 324 | if ((sbi->data_map.odm_num_comps != numdevs) || | ||
| 325 | (sbi->data_map.odm_stripe_unit != EXOFS_BLKSIZE) || | ||
| 326 | (sbi->data_map.odm_raid_algorithm != PNFS_OSD_RAID_0) || | ||
| 327 | (sbi->data_map.odm_mirror_cnt != (numdevs - 1))) | ||
| 328 | return -EINVAL; | ||
| 329 | else | ||
| 330 | return 0; | ||
| 331 | } | ||
| 332 | |||
| 333 | /* @odi is valid only as long as @fscb_dev is valid */ | ||
| 334 | static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev, | ||
| 335 | struct osd_dev_info *odi) | ||
| 336 | { | ||
| 337 | odi->systemid_len = le32_to_cpu(dt_dev->systemid_len); | ||
| 338 | memcpy(odi->systemid, dt_dev->systemid, odi->systemid_len); | ||
| 339 | |||
| 340 | odi->osdname_len = le32_to_cpu(dt_dev->osdname_len); | ||
| 341 | odi->osdname = dt_dev->osdname; | ||
| 342 | |||
| 343 | /* FIXME support long names. Will need a _put function */ | ||
| 344 | if (dt_dev->long_name_offset) | ||
| 345 | return -EINVAL; | ||
| 346 | |||
| 347 | /* Make sure osdname is printable! | ||
| 348 | * mkexofs should give us space for a null-terminator else the | ||
| 349 | * device-table is invalid. | ||
| 350 | */ | ||
| 351 | if (unlikely(odi->osdname_len >= sizeof(dt_dev->osdname))) | ||
| 352 | odi->osdname_len = sizeof(dt_dev->osdname) - 1; | ||
| 353 | dt_dev->osdname[odi->osdname_len] = 0; | ||
| 354 | |||
| 355 | /* If it's all zeros something is bad we read past end-of-obj */ | ||
| 356 | return !(odi->systemid_len || odi->osdname_len); | ||
| 357 | } | ||
| 358 | |||
| 359 | static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | ||
| 360 | unsigned table_count) | ||
| 361 | { | ||
| 362 | struct exofs_sb_info *sbi = *psbi; | ||
| 363 | struct osd_dev *fscb_od; | ||
| 364 | struct osd_obj_id obj = {.partition = sbi->s_pid, | ||
| 365 | .id = EXOFS_DEVTABLE_ID}; | ||
| 366 | struct exofs_device_table *dt; | ||
| 367 | unsigned table_bytes = table_count * sizeof(dt->dt_dev_table[0]) + | ||
| 368 | sizeof(*dt); | ||
| 369 | unsigned numdevs, i; | ||
| 370 | int ret; | ||
| 371 | |||
| 372 | dt = kmalloc(table_bytes, GFP_KERNEL); | ||
| 373 | if (unlikely(!dt)) { | ||
| 374 | EXOFS_ERR("ERROR: allocating %x bytes for device table\n", | ||
| 375 | table_bytes); | ||
| 376 | return -ENOMEM; | ||
| 377 | } | ||
| 378 | |||
| 379 | fscb_od = sbi->s_ods[0]; | ||
| 380 | sbi->s_ods[0] = NULL; | ||
| 381 | sbi->s_numdevs = 0; | ||
| 382 | ret = exofs_read_kern(fscb_od, sbi->s_cred, &obj, 0, dt, table_bytes); | ||
| 383 | if (unlikely(ret)) { | ||
| 384 | EXOFS_ERR("ERROR: reading device table\n"); | ||
| 385 | goto out; | ||
| 386 | } | ||
| 387 | |||
| 388 | numdevs = le64_to_cpu(dt->dt_num_devices); | ||
| 389 | if (unlikely(!numdevs)) { | ||
| 390 | ret = -EINVAL; | ||
| 391 | goto out; | ||
| 392 | } | ||
| 393 | WARN_ON(table_count != numdevs); | ||
| 394 | |||
| 395 | ret = _read_and_match_data_map(sbi, numdevs, dt); | ||
| 396 | if (unlikely(ret)) | ||
| 397 | goto out; | ||
| 398 | |||
| 399 | if (likely(numdevs > 1)) { | ||
| 400 | unsigned size = numdevs * sizeof(sbi->s_ods[0]); | ||
| 401 | |||
| 402 | sbi = krealloc(sbi, sizeof(*sbi) + size, GFP_KERNEL); | ||
| 403 | if (unlikely(!sbi)) { | ||
| 404 | ret = -ENOMEM; | ||
| 405 | goto out; | ||
| 406 | } | ||
| 407 | memset(&sbi->s_ods[1], 0, size - sizeof(sbi->s_ods[0])); | ||
| 408 | *psbi = sbi; | ||
| 409 | } | ||
| 410 | |||
| 411 | for (i = 0; i < numdevs; i++) { | ||
| 412 | struct exofs_fscb fscb; | ||
| 413 | struct osd_dev_info odi; | ||
| 414 | struct osd_dev *od; | ||
| 415 | |||
| 416 | if (exofs_devs_2_odi(&dt->dt_dev_table[i], &odi)) { | ||
| 417 | EXOFS_ERR("ERROR: Read all-zeros device entry\n"); | ||
| 418 | ret = -EINVAL; | ||
| 419 | goto out; | ||
| 420 | } | ||
| 421 | |||
| 422 | printk(KERN_NOTICE "Add device[%d]: osd_name-%s\n", | ||
| 423 | i, odi.osdname); | ||
| 424 | |||
| 425 | /* On all devices the device table is identical. The user can | ||
| 426 | * specify any one of the participating devices on the command | ||
| 427 | * line. We always keep them in device-table order. | ||
| 428 | */ | ||
| 429 | if (fscb_od && osduld_device_same(fscb_od, &odi)) { | ||
| 430 | sbi->s_ods[i] = fscb_od; | ||
| 431 | ++sbi->s_numdevs; | ||
| 432 | fscb_od = NULL; | ||
| 433 | continue; | ||
| 434 | } | ||
| 435 | |||
| 436 | od = osduld_info_lookup(&odi); | ||
| 437 | if (unlikely(IS_ERR(od))) { | ||
| 438 | ret = PTR_ERR(od); | ||
| 439 | EXOFS_ERR("ERROR: device requested is not found " | ||
| 440 | "osd_name-%s =>%d\n", odi.osdname, ret); | ||
| 441 | goto out; | ||
| 442 | } | ||
| 443 | |||
| 444 | sbi->s_ods[i] = od; | ||
| 445 | ++sbi->s_numdevs; | ||
| 446 | |||
| 447 | /* Read the fscb of the other devices to make sure the FS | ||
| 448 | * partition is there. | ||
| 449 | */ | ||
| 450 | ret = exofs_read_kern(od, sbi->s_cred, &obj, 0, &fscb, | ||
| 451 | sizeof(fscb)); | ||
| 452 | if (unlikely(ret)) { | ||
| 453 | EXOFS_ERR("ERROR: Malformed participating device " | ||
| 454 | "error reading fscb osd_name-%s\n", | ||
| 455 | odi.osdname); | ||
| 456 | goto out; | ||
| 457 | } | ||
| 458 | |||
| 459 | /* TODO: verify other information is correct and FS-uuid | ||
| 460 | * matches. Benny what did you say about device table | ||
| 461 | * generation and old devices? | ||
| 462 | */ | ||
| 463 | } | ||
| 464 | |||
| 465 | out: | ||
| 466 | kfree(dt); | ||
| 467 | if (unlikely(!ret && fscb_od)) { | ||
| 468 | EXOFS_ERR( | ||
| 469 | "ERROR: Bad device-table container device not present\n"); | ||
| 470 | osduld_put_device(fscb_od); | ||
| 471 | ret = -EINVAL; | ||
| 472 | } | ||
| 473 | |||
| 474 | return ret; | ||
| 475 | } | ||
| 476 | |||
| 287 | /* | 477 | /* |
| 288 | * Read the superblock from the OSD and fill in the fields | 478 | * Read the superblock from the OSD and fill in the fields |
| 289 | */ | 479 | */ |
| @@ -292,24 +482,25 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
| 292 | struct inode *root; | 482 | struct inode *root; |
| 293 | struct exofs_mountopt *opts = data; | 483 | struct exofs_mountopt *opts = data; |
| 294 | struct exofs_sb_info *sbi; /*extended info */ | 484 | struct exofs_sb_info *sbi; /*extended info */ |
| 485 | struct osd_dev *od; /* Master device */ | ||
| 295 | struct exofs_fscb fscb; /*on-disk superblock info */ | 486 | struct exofs_fscb fscb; /*on-disk superblock info */ |
| 296 | struct osd_request *or = NULL; | ||
| 297 | struct osd_obj_id obj; | 487 | struct osd_obj_id obj; |
| 488 | unsigned table_count; | ||
| 298 | int ret; | 489 | int ret; |
| 299 | 490 | ||
| 300 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); | 491 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); |
| 301 | if (!sbi) | 492 | if (!sbi) |
| 302 | return -ENOMEM; | 493 | return -ENOMEM; |
| 303 | sb->s_fs_info = sbi; | ||
| 304 | 494 | ||
| 305 | /* use mount options to fill superblock */ | 495 | /* use mount options to fill superblock */ |
| 306 | sbi->s_dev = osduld_path_lookup(opts->dev_name); | 496 | od = osduld_path_lookup(opts->dev_name); |
| 307 | if (IS_ERR(sbi->s_dev)) { | 497 | if (IS_ERR(od)) { |
| 308 | ret = PTR_ERR(sbi->s_dev); | 498 | ret = PTR_ERR(od); |
| 309 | sbi->s_dev = NULL; | ||
| 310 | goto free_sbi; | 499 | goto free_sbi; |
| 311 | } | 500 | } |
| 312 | 501 | ||
| 502 | sbi->s_ods[0] = od; | ||
| 503 | sbi->s_numdevs = 1; | ||
| 313 | sbi->s_pid = opts->pid; | 504 | sbi->s_pid = opts->pid; |
| 314 | sbi->s_timeout = opts->timeout; | 505 | sbi->s_timeout = opts->timeout; |
| 315 | 506 | ||
| @@ -323,35 +514,13 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
| 323 | sb->s_bdev = NULL; | 514 | sb->s_bdev = NULL; |
| 324 | sb->s_dev = 0; | 515 | sb->s_dev = 0; |
| 325 | 516 | ||
| 326 | /* read data from on-disk superblock object */ | ||
| 327 | obj.partition = sbi->s_pid; | 517 | obj.partition = sbi->s_pid; |
| 328 | obj.id = EXOFS_SUPER_ID; | 518 | obj.id = EXOFS_SUPER_ID; |
| 329 | exofs_make_credential(sbi->s_cred, &obj); | 519 | exofs_make_credential(sbi->s_cred, &obj); |
| 330 | 520 | ||
| 331 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 521 | ret = exofs_read_kern(od, sbi->s_cred, &obj, 0, &fscb, sizeof(fscb)); |
| 332 | if (unlikely(!or)) { | 522 | if (unlikely(ret)) |
| 333 | if (!silent) | ||
| 334 | EXOFS_ERR( | ||
| 335 | "exofs_fill_super: osd_start_request failed.\n"); | ||
| 336 | ret = -ENOMEM; | ||
| 337 | goto free_sbi; | ||
| 338 | } | ||
| 339 | ret = osd_req_read_kern(or, &obj, 0, &fscb, sizeof(fscb)); | ||
| 340 | if (unlikely(ret)) { | ||
| 341 | if (!silent) | ||
| 342 | EXOFS_ERR( | ||
| 343 | "exofs_fill_super: osd_req_read_kern failed.\n"); | ||
| 344 | ret = -ENOMEM; | ||
| 345 | goto free_sbi; | ||
| 346 | } | ||
| 347 | |||
| 348 | ret = exofs_sync_op(or, sbi->s_timeout, sbi->s_cred); | ||
| 349 | if (unlikely(ret)) { | ||
| 350 | if (!silent) | ||
| 351 | EXOFS_ERR("exofs_fill_super: exofs_sync_op failed.\n"); | ||
| 352 | ret = -EIO; | ||
| 353 | goto free_sbi; | 523 | goto free_sbi; |
| 354 | } | ||
| 355 | 524 | ||
| 356 | sb->s_magic = le16_to_cpu(fscb.s_magic); | 525 | sb->s_magic = le16_to_cpu(fscb.s_magic); |
| 357 | sbi->s_nextid = le64_to_cpu(fscb.s_nextid); | 526 | sbi->s_nextid = le64_to_cpu(fscb.s_nextid); |
| @@ -364,12 +533,26 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
| 364 | ret = -EINVAL; | 533 | ret = -EINVAL; |
| 365 | goto free_sbi; | 534 | goto free_sbi; |
| 366 | } | 535 | } |
| 536 | if (le32_to_cpu(fscb.s_version) != EXOFS_FSCB_VER) { | ||
| 537 | EXOFS_ERR("ERROR: Bad FSCB version expected-%d got-%d\n", | ||
| 538 | EXOFS_FSCB_VER, le32_to_cpu(fscb.s_version)); | ||
| 539 | ret = -EINVAL; | ||
| 540 | goto free_sbi; | ||
| 541 | } | ||
| 367 | 542 | ||
| 368 | /* start generation numbers from a random point */ | 543 | /* start generation numbers from a random point */ |
| 369 | get_random_bytes(&sbi->s_next_generation, sizeof(u32)); | 544 | get_random_bytes(&sbi->s_next_generation, sizeof(u32)); |
| 370 | spin_lock_init(&sbi->s_next_gen_lock); | 545 | spin_lock_init(&sbi->s_next_gen_lock); |
| 371 | 546 | ||
| 547 | table_count = le64_to_cpu(fscb.s_dev_table_count); | ||
| 548 | if (table_count) { | ||
| 549 | ret = exofs_read_lookup_dev_table(&sbi, table_count); | ||
| 550 | if (unlikely(ret)) | ||
| 551 | goto free_sbi; | ||
| 552 | } | ||
| 553 | |||
| 372 | /* set up operation vectors */ | 554 | /* set up operation vectors */ |
| 555 | sb->s_fs_info = sbi; | ||
| 373 | sb->s_op = &exofs_sops; | 556 | sb->s_op = &exofs_sops; |
| 374 | sb->s_export_op = &exofs_export_ops; | 557 | sb->s_export_op = &exofs_export_ops; |
| 375 | root = exofs_iget(sb, EXOFS_ROOT_ID - EXOFS_OBJ_OFF); | 558 | root = exofs_iget(sb, EXOFS_ROOT_ID - EXOFS_OBJ_OFF); |
| @@ -395,16 +578,15 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
| 395 | goto free_sbi; | 578 | goto free_sbi; |
| 396 | } | 579 | } |
| 397 | 580 | ||
| 398 | ret = 0; | 581 | _exofs_print_device("Mounting", opts->dev_name, sbi->s_ods[0], |
| 399 | out: | 582 | sbi->s_pid); |
| 400 | if (or) | 583 | return 0; |
| 401 | osd_end_request(or); | ||
| 402 | return ret; | ||
| 403 | 584 | ||
| 404 | free_sbi: | 585 | free_sbi: |
| 405 | osduld_put_device(sbi->s_dev); /* NULL safe */ | 586 | EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n", |
| 406 | kfree(sbi); | 587 | opts->dev_name, sbi->s_pid, ret); |
| 407 | goto out; | 588 | exofs_free_sbi(sbi); |
| 589 | return ret; | ||
| 408 | } | 590 | } |
| 409 | 591 | ||
| 410 | /* | 592 | /* |
| @@ -433,7 +615,7 @@ static int exofs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
| 433 | { | 615 | { |
| 434 | struct super_block *sb = dentry->d_sb; | 616 | struct super_block *sb = dentry->d_sb; |
| 435 | struct exofs_sb_info *sbi = sb->s_fs_info; | 617 | struct exofs_sb_info *sbi = sb->s_fs_info; |
| 436 | struct osd_obj_id obj = {sbi->s_pid, 0}; | 618 | struct exofs_io_state *ios; |
| 437 | struct osd_attr attrs[] = { | 619 | struct osd_attr attrs[] = { |
| 438 | ATTR_DEF(OSD_APAGE_PARTITION_QUOTAS, | 620 | ATTR_DEF(OSD_APAGE_PARTITION_QUOTAS, |
| 439 | OSD_ATTR_PQ_CAPACITY_QUOTA, sizeof(__be64)), | 621 | OSD_ATTR_PQ_CAPACITY_QUOTA, sizeof(__be64)), |
| @@ -442,32 +624,33 @@ static int exofs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
| 442 | }; | 624 | }; |
| 443 | uint64_t capacity = ULLONG_MAX; | 625 | uint64_t capacity = ULLONG_MAX; |
| 444 | uint64_t used = ULLONG_MAX; | 626 | uint64_t used = ULLONG_MAX; |
| 445 | struct osd_request *or; | ||
| 446 | uint8_t cred_a[OSD_CAP_LEN]; | 627 | uint8_t cred_a[OSD_CAP_LEN]; |
| 447 | int ret; | 628 | int ret; |
| 448 | 629 | ||
| 449 | /* get used/capacity attributes */ | 630 | ret = exofs_get_io_state(sbi, &ios); |
| 450 | exofs_make_credential(cred_a, &obj); | 631 | if (ret) { |
| 451 | 632 | EXOFS_DBGMSG("exofs_get_io_state failed.\n"); | |
| 452 | or = osd_start_request(sbi->s_dev, GFP_KERNEL); | 633 | return ret; |
| 453 | if (unlikely(!or)) { | ||
| 454 | EXOFS_DBGMSG("exofs_statfs: osd_start_request failed.\n"); | ||
| 455 | return -ENOMEM; | ||
| 456 | } | 634 | } |
| 457 | 635 | ||
| 458 | osd_req_get_attributes(or, &obj); | 636 | exofs_make_credential(cred_a, &ios->obj); |
| 459 | osd_req_add_get_attr_list(or, attrs, ARRAY_SIZE(attrs)); | 637 | ios->cred = sbi->s_cred; |
| 460 | ret = exofs_sync_op(or, sbi->s_timeout, cred_a); | 638 | ios->in_attr = attrs; |
| 639 | ios->in_attr_len = ARRAY_SIZE(attrs); | ||
| 640 | |||
| 641 | ret = exofs_sbi_read(ios); | ||
| 461 | if (unlikely(ret)) | 642 | if (unlikely(ret)) |
| 462 | goto out; | 643 | goto out; |
| 463 | 644 | ||
| 464 | ret = extract_attr_from_req(or, &attrs[0]); | 645 | ret = extract_attr_from_ios(ios, &attrs[0]); |
| 465 | if (likely(!ret)) | 646 | if (likely(!ret)) { |
| 466 | capacity = get_unaligned_be64(attrs[0].val_ptr); | 647 | capacity = get_unaligned_be64(attrs[0].val_ptr); |
| 467 | else | 648 | if (unlikely(!capacity)) |
| 649 | capacity = ULLONG_MAX; | ||
| 650 | } else | ||
| 468 | EXOFS_DBGMSG("exofs_statfs: get capacity failed.\n"); | 651 | EXOFS_DBGMSG("exofs_statfs: get capacity failed.\n"); |
| 469 | 652 | ||
| 470 | ret = extract_attr_from_req(or, &attrs[1]); | 653 | ret = extract_attr_from_ios(ios, &attrs[1]); |
| 471 | if (likely(!ret)) | 654 | if (likely(!ret)) |
| 472 | used = get_unaligned_be64(attrs[1].val_ptr); | 655 | used = get_unaligned_be64(attrs[1].val_ptr); |
| 473 | else | 656 | else |
| @@ -476,15 +659,15 @@ static int exofs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
| 476 | /* fill in the stats buffer */ | 659 | /* fill in the stats buffer */ |
| 477 | buf->f_type = EXOFS_SUPER_MAGIC; | 660 | buf->f_type = EXOFS_SUPER_MAGIC; |
| 478 | buf->f_bsize = EXOFS_BLKSIZE; | 661 | buf->f_bsize = EXOFS_BLKSIZE; |
| 479 | buf->f_blocks = (capacity >> EXOFS_BLKSHIFT); | 662 | buf->f_blocks = capacity >> 9; |
| 480 | buf->f_bfree = ((capacity - used) >> EXOFS_BLKSHIFT); | 663 | buf->f_bfree = (capacity - used) >> 9; |
| 481 | buf->f_bavail = buf->f_bfree; | 664 | buf->f_bavail = buf->f_bfree; |
| 482 | buf->f_files = sbi->s_numfiles; | 665 | buf->f_files = sbi->s_numfiles; |
| 483 | buf->f_ffree = EXOFS_MAX_ID - sbi->s_numfiles; | 666 | buf->f_ffree = EXOFS_MAX_ID - sbi->s_numfiles; |
| 484 | buf->f_namelen = EXOFS_NAME_LEN; | 667 | buf->f_namelen = EXOFS_NAME_LEN; |
| 485 | 668 | ||
| 486 | out: | 669 | out: |
| 487 | osd_end_request(or); | 670 | exofs_put_io_state(ios); |
| 488 | return ret; | 671 | return ret; |
| 489 | } | 672 | } |
| 490 | 673 | ||
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index 6cde970b0a1a..fc2bd05d3559 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c | |||
| @@ -353,8 +353,8 @@ ext2_readdir (struct file * filp, void * dirent, filldir_t filldir) | |||
| 353 | * ext2_find_entry() | 353 | * ext2_find_entry() |
| 354 | * | 354 | * |
| 355 | * finds an entry in the specified directory with the wanted name. It | 355 | * finds an entry in the specified directory with the wanted name. It |
| 356 | * returns the page in which the entry was found, and the entry itself | 356 | * returns the page in which the entry was found (as a parameter - res_page), |
| 357 | * (as a parameter - res_dir). Page is returned mapped and unlocked. | 357 | * and the entry itself. Page is returned mapped and unlocked. |
| 358 | * Entry is guaranteed to be valid. | 358 | * Entry is guaranteed to be valid. |
| 359 | */ | 359 | */ |
| 360 | struct ext2_dir_entry_2 *ext2_find_entry (struct inode * dir, | 360 | struct ext2_dir_entry_2 *ext2_find_entry (struct inode * dir, |
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h index 9a8a8e27a063..da318b0fa637 100644 --- a/fs/ext2/ext2.h +++ b/fs/ext2/ext2.h | |||
| @@ -142,7 +142,7 @@ struct dentry *ext2_get_parent(struct dentry *child); | |||
| 142 | /* super.c */ | 142 | /* super.c */ |
| 143 | extern void ext2_error (struct super_block *, const char *, const char *, ...) | 143 | extern void ext2_error (struct super_block *, const char *, const char *, ...) |
| 144 | __attribute__ ((format (printf, 3, 4))); | 144 | __attribute__ ((format (printf, 3, 4))); |
| 145 | extern void ext2_warning (struct super_block *, const char *, const char *, ...) | 145 | extern void ext2_msg(struct super_block *, const char *, const char *, ...) |
| 146 | __attribute__ ((format (printf, 3, 4))); | 146 | __attribute__ ((format (printf, 3, 4))); |
| 147 | extern void ext2_update_dynamic_rev (struct super_block *sb); | 147 | extern void ext2_update_dynamic_rev (struct super_block *sb); |
| 148 | extern void ext2_write_super (struct super_block *); | 148 | extern void ext2_write_super (struct super_block *); |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index ade634076d0a..71b032c65a02 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
| @@ -137,7 +137,8 @@ static int ext2_block_to_path(struct inode *inode, | |||
| 137 | int final = 0; | 137 | int final = 0; |
| 138 | 138 | ||
| 139 | if (i_block < 0) { | 139 | if (i_block < 0) { |
| 140 | ext2_warning (inode->i_sb, "ext2_block_to_path", "block < 0"); | 140 | ext2_msg(inode->i_sb, KERN_WARNING, |
| 141 | "warning: %s: block < 0", __func__); | ||
| 141 | } else if (i_block < direct_blocks) { | 142 | } else if (i_block < direct_blocks) { |
| 142 | offsets[n++] = i_block; | 143 | offsets[n++] = i_block; |
| 143 | final = direct_blocks; | 144 | final = direct_blocks; |
| @@ -157,7 +158,8 @@ static int ext2_block_to_path(struct inode *inode, | |||
| 157 | offsets[n++] = i_block & (ptrs - 1); | 158 | offsets[n++] = i_block & (ptrs - 1); |
| 158 | final = ptrs; | 159 | final = ptrs; |
| 159 | } else { | 160 | } else { |
| 160 | ext2_warning (inode->i_sb, "ext2_block_to_path", "block > big"); | 161 | ext2_msg(inode->i_sb, KERN_WARNING, |
| 162 | "warning: %s: block is too big", __func__); | ||
| 161 | } | 163 | } |
| 162 | if (boundary) | 164 | if (boundary) |
| 163 | *boundary = final - 1 - (i_block & (ptrs - 1)); | 165 | *boundary = final - 1 - (i_block & (ptrs - 1)); |
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 1a9ffee47d56..1388802b7803 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
| @@ -58,27 +58,27 @@ void ext2_error (struct super_block * sb, const char * function, | |||
| 58 | } | 58 | } |
| 59 | 59 | ||
| 60 | va_start(args, fmt); | 60 | va_start(args, fmt); |
| 61 | printk(KERN_CRIT "EXT2-fs error (device %s): %s: ",sb->s_id, function); | 61 | printk(KERN_CRIT "EXT2-fs (%s): error: %s: ", sb->s_id, function); |
| 62 | vprintk(fmt, args); | 62 | vprintk(fmt, args); |
| 63 | printk("\n"); | 63 | printk("\n"); |
| 64 | va_end(args); | 64 | va_end(args); |
| 65 | 65 | ||
| 66 | if (test_opt(sb, ERRORS_PANIC)) | 66 | if (test_opt(sb, ERRORS_PANIC)) |
| 67 | panic("EXT2-fs panic from previous error\n"); | 67 | panic("EXT2-fs: panic from previous error\n"); |
| 68 | if (test_opt(sb, ERRORS_RO)) { | 68 | if (test_opt(sb, ERRORS_RO)) { |
| 69 | printk("Remounting filesystem read-only\n"); | 69 | ext2_msg(sb, KERN_CRIT, |
| 70 | "error: remounting filesystem read-only"); | ||
| 70 | sb->s_flags |= MS_RDONLY; | 71 | sb->s_flags |= MS_RDONLY; |
| 71 | } | 72 | } |
| 72 | } | 73 | } |
| 73 | 74 | ||
| 74 | void ext2_warning (struct super_block * sb, const char * function, | 75 | void ext2_msg(struct super_block *sb, const char *prefix, |
| 75 | const char * fmt, ...) | 76 | const char *fmt, ...) |
| 76 | { | 77 | { |
| 77 | va_list args; | 78 | va_list args; |
| 78 | 79 | ||
| 79 | va_start(args, fmt); | 80 | va_start(args, fmt); |
| 80 | printk(KERN_WARNING "EXT2-fs warning (device %s): %s: ", | 81 | printk("%sEXT2-fs (%s): ", prefix, sb->s_id); |
| 81 | sb->s_id, function); | ||
| 82 | vprintk(fmt, args); | 82 | vprintk(fmt, args); |
| 83 | printk("\n"); | 83 | printk("\n"); |
| 84 | va_end(args); | 84 | va_end(args); |
| @@ -91,9 +91,9 @@ void ext2_update_dynamic_rev(struct super_block *sb) | |||
| 91 | if (le32_to_cpu(es->s_rev_level) > EXT2_GOOD_OLD_REV) | 91 | if (le32_to_cpu(es->s_rev_level) > EXT2_GOOD_OLD_REV) |
| 92 | return; | 92 | return; |
| 93 | 93 | ||
| 94 | ext2_warning(sb, __func__, | 94 | ext2_msg(sb, KERN_WARNING, |
| 95 | "updating to rev %d because of new feature flag, " | 95 | "warning: updating to rev %d because of " |
| 96 | "running e2fsck is recommended", | 96 | "new feature flag, running e2fsck is recommended", |
| 97 | EXT2_DYNAMIC_REV); | 97 | EXT2_DYNAMIC_REV); |
| 98 | 98 | ||
| 99 | es->s_first_ino = cpu_to_le32(EXT2_GOOD_OLD_FIRST_INO); | 99 | es->s_first_ino = cpu_to_le32(EXT2_GOOD_OLD_FIRST_INO); |
| @@ -419,10 +419,10 @@ static const match_table_t tokens = { | |||
| 419 | {Opt_err, NULL} | 419 | {Opt_err, NULL} |
| 420 | }; | 420 | }; |
| 421 | 421 | ||
| 422 | static int parse_options (char * options, | 422 | static int parse_options(char *options, struct super_block *sb) |
| 423 | struct ext2_sb_info *sbi) | ||
| 424 | { | 423 | { |
| 425 | char * p; | 424 | char *p; |
| 425 | struct ext2_sb_info *sbi = EXT2_SB(sb); | ||
| 426 | substring_t args[MAX_OPT_ARGS]; | 426 | substring_t args[MAX_OPT_ARGS]; |
| 427 | int option; | 427 | int option; |
| 428 | 428 | ||
| @@ -505,7 +505,8 @@ static int parse_options (char * options, | |||
| 505 | #else | 505 | #else |
| 506 | case Opt_user_xattr: | 506 | case Opt_user_xattr: |
| 507 | case Opt_nouser_xattr: | 507 | case Opt_nouser_xattr: |
| 508 | printk("EXT2 (no)user_xattr options not supported\n"); | 508 | ext2_msg(sb, KERN_INFO, "(no)user_xattr options" |
| 509 | "not supported"); | ||
| 509 | break; | 510 | break; |
| 510 | #endif | 511 | #endif |
| 511 | #ifdef CONFIG_EXT2_FS_POSIX_ACL | 512 | #ifdef CONFIG_EXT2_FS_POSIX_ACL |
| @@ -518,14 +519,15 @@ static int parse_options (char * options, | |||
| 518 | #else | 519 | #else |
| 519 | case Opt_acl: | 520 | case Opt_acl: |
| 520 | case Opt_noacl: | 521 | case Opt_noacl: |
| 521 | printk("EXT2 (no)acl options not supported\n"); | 522 | ext2_msg(sb, KERN_INFO, |
| 523 | "(no)acl options not supported"); | ||
| 522 | break; | 524 | break; |
| 523 | #endif | 525 | #endif |
| 524 | case Opt_xip: | 526 | case Opt_xip: |
| 525 | #ifdef CONFIG_EXT2_FS_XIP | 527 | #ifdef CONFIG_EXT2_FS_XIP |
| 526 | set_opt (sbi->s_mount_opt, XIP); | 528 | set_opt (sbi->s_mount_opt, XIP); |
| 527 | #else | 529 | #else |
| 528 | printk("EXT2 xip option not supported\n"); | 530 | ext2_msg(sb, KERN_INFO, "xip option not supported"); |
| 529 | #endif | 531 | #endif |
| 530 | break; | 532 | break; |
| 531 | 533 | ||
| @@ -542,19 +544,18 @@ static int parse_options (char * options, | |||
| 542 | case Opt_quota: | 544 | case Opt_quota: |
| 543 | case Opt_usrquota: | 545 | case Opt_usrquota: |
| 544 | case Opt_grpquota: | 546 | case Opt_grpquota: |
| 545 | printk(KERN_ERR | 547 | ext2_msg(sb, KERN_INFO, |
| 546 | "EXT2-fs: quota operations not supported.\n"); | 548 | "quota operations not supported"); |
| 547 | |||
| 548 | break; | 549 | break; |
| 549 | #endif | 550 | #endif |
| 550 | 551 | ||
| 551 | case Opt_reservation: | 552 | case Opt_reservation: |
| 552 | set_opt(sbi->s_mount_opt, RESERVATION); | 553 | set_opt(sbi->s_mount_opt, RESERVATION); |
| 553 | printk("reservations ON\n"); | 554 | ext2_msg(sb, KERN_INFO, "reservations ON"); |
| 554 | break; | 555 | break; |
| 555 | case Opt_noreservation: | 556 | case Opt_noreservation: |
| 556 | clear_opt(sbi->s_mount_opt, RESERVATION); | 557 | clear_opt(sbi->s_mount_opt, RESERVATION); |
| 557 | printk("reservations OFF\n"); | 558 | ext2_msg(sb, KERN_INFO, "reservations OFF"); |
| 558 | break; | 559 | break; |
| 559 | case Opt_ignore: | 560 | case Opt_ignore: |
| 560 | break; | 561 | break; |
| @@ -573,34 +574,40 @@ static int ext2_setup_super (struct super_block * sb, | |||
| 573 | struct ext2_sb_info *sbi = EXT2_SB(sb); | 574 | struct ext2_sb_info *sbi = EXT2_SB(sb); |
| 574 | 575 | ||
| 575 | if (le32_to_cpu(es->s_rev_level) > EXT2_MAX_SUPP_REV) { | 576 | if (le32_to_cpu(es->s_rev_level) > EXT2_MAX_SUPP_REV) { |
| 576 | printk ("EXT2-fs warning: revision level too high, " | 577 | ext2_msg(sb, KERN_ERR, |
| 577 | "forcing read-only mode\n"); | 578 | "error: revision level too high, " |
| 579 | "forcing read-only mode"); | ||
| 578 | res = MS_RDONLY; | 580 | res = MS_RDONLY; |
| 579 | } | 581 | } |
| 580 | if (read_only) | 582 | if (read_only) |
| 581 | return res; | 583 | return res; |
| 582 | if (!(sbi->s_mount_state & EXT2_VALID_FS)) | 584 | if (!(sbi->s_mount_state & EXT2_VALID_FS)) |
| 583 | printk ("EXT2-fs warning: mounting unchecked fs, " | 585 | ext2_msg(sb, KERN_WARNING, |
| 584 | "running e2fsck is recommended\n"); | 586 | "warning: mounting unchecked fs, " |
| 587 | "running e2fsck is recommended"); | ||
| 585 | else if ((sbi->s_mount_state & EXT2_ERROR_FS)) | 588 | else if ((sbi->s_mount_state & EXT2_ERROR_FS)) |
| 586 | printk ("EXT2-fs warning: mounting fs with errors, " | 589 | ext2_msg(sb, KERN_WARNING, |
| 587 | "running e2fsck is recommended\n"); | 590 | "warning: mounting fs with errors, " |
| 591 | "running e2fsck is recommended"); | ||
| 588 | else if ((__s16) le16_to_cpu(es->s_max_mnt_count) >= 0 && | 592 | else if ((__s16) le16_to_cpu(es->s_max_mnt_count) >= 0 && |
| 589 | le16_to_cpu(es->s_mnt_count) >= | 593 | le16_to_cpu(es->s_mnt_count) >= |
| 590 | (unsigned short) (__s16) le16_to_cpu(es->s_max_mnt_count)) | 594 | (unsigned short) (__s16) le16_to_cpu(es->s_max_mnt_count)) |
| 591 | printk ("EXT2-fs warning: maximal mount count reached, " | 595 | ext2_msg(sb, KERN_WARNING, |
| 592 | "running e2fsck is recommended\n"); | 596 | "warning: maximal mount count reached, " |
| 597 | "running e2fsck is recommended"); | ||
| 593 | else if (le32_to_cpu(es->s_checkinterval) && | 598 | else if (le32_to_cpu(es->s_checkinterval) && |
| 594 | (le32_to_cpu(es->s_lastcheck) + le32_to_cpu(es->s_checkinterval) <= get_seconds())) | 599 | (le32_to_cpu(es->s_lastcheck) + |
| 595 | printk ("EXT2-fs warning: checktime reached, " | 600 | le32_to_cpu(es->s_checkinterval) <= get_seconds())) |
| 596 | "running e2fsck is recommended\n"); | 601 | ext2_msg(sb, KERN_WARNING, |
| 602 | "warning: checktime reached, " | ||
| 603 | "running e2fsck is recommended"); | ||
| 597 | if (!le16_to_cpu(es->s_max_mnt_count)) | 604 | if (!le16_to_cpu(es->s_max_mnt_count)) |
| 598 | es->s_max_mnt_count = cpu_to_le16(EXT2_DFL_MAX_MNT_COUNT); | 605 | es->s_max_mnt_count = cpu_to_le16(EXT2_DFL_MAX_MNT_COUNT); |
| 599 | le16_add_cpu(&es->s_mnt_count, 1); | 606 | le16_add_cpu(&es->s_mnt_count, 1); |
| 600 | ext2_write_super(sb); | 607 | ext2_write_super(sb); |
| 601 | if (test_opt (sb, DEBUG)) | 608 | if (test_opt (sb, DEBUG)) |
| 602 | printk ("[EXT II FS %s, %s, bs=%lu, fs=%lu, gc=%lu, " | 609 | ext2_msg(sb, KERN_INFO, "%s, %s, bs=%lu, fs=%lu, gc=%lu, " |
| 603 | "bpg=%lu, ipg=%lu, mo=%04lx]\n", | 610 | "bpg=%lu, ipg=%lu, mo=%04lx]", |
| 604 | EXT2FS_VERSION, EXT2FS_DATE, sb->s_blocksize, | 611 | EXT2FS_VERSION, EXT2FS_DATE, sb->s_blocksize, |
| 605 | sbi->s_frag_size, | 612 | sbi->s_frag_size, |
| 606 | sbi->s_groups_count, | 613 | sbi->s_groups_count, |
| @@ -767,7 +774,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 767 | */ | 774 | */ |
| 768 | blocksize = sb_min_blocksize(sb, BLOCK_SIZE); | 775 | blocksize = sb_min_blocksize(sb, BLOCK_SIZE); |
| 769 | if (!blocksize) { | 776 | if (!blocksize) { |
| 770 | printk ("EXT2-fs: unable to set blocksize\n"); | 777 | ext2_msg(sb, KERN_ERR, "error: unable to set blocksize"); |
| 771 | goto failed_sbi; | 778 | goto failed_sbi; |
| 772 | } | 779 | } |
| 773 | 780 | ||
| @@ -783,7 +790,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 783 | } | 790 | } |
| 784 | 791 | ||
| 785 | if (!(bh = sb_bread(sb, logic_sb_block))) { | 792 | if (!(bh = sb_bread(sb, logic_sb_block))) { |
| 786 | printk ("EXT2-fs: unable to read superblock\n"); | 793 | ext2_msg(sb, KERN_ERR, "error: unable to read superblock"); |
| 787 | goto failed_sbi; | 794 | goto failed_sbi; |
| 788 | } | 795 | } |
| 789 | /* | 796 | /* |
| @@ -826,7 +833,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 826 | 833 | ||
| 827 | set_opt(sbi->s_mount_opt, RESERVATION); | 834 | set_opt(sbi->s_mount_opt, RESERVATION); |
| 828 | 835 | ||
| 829 | if (!parse_options ((char *) data, sbi)) | 836 | if (!parse_options((char *) data, sb)) |
| 830 | goto failed_mount; | 837 | goto failed_mount; |
| 831 | 838 | ||
| 832 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 839 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
| @@ -840,8 +847,9 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 840 | (EXT2_HAS_COMPAT_FEATURE(sb, ~0U) || | 847 | (EXT2_HAS_COMPAT_FEATURE(sb, ~0U) || |
| 841 | EXT2_HAS_RO_COMPAT_FEATURE(sb, ~0U) || | 848 | EXT2_HAS_RO_COMPAT_FEATURE(sb, ~0U) || |
| 842 | EXT2_HAS_INCOMPAT_FEATURE(sb, ~0U))) | 849 | EXT2_HAS_INCOMPAT_FEATURE(sb, ~0U))) |
| 843 | printk("EXT2-fs warning: feature flags set on rev 0 fs, " | 850 | ext2_msg(sb, KERN_WARNING, |
| 844 | "running e2fsck is recommended\n"); | 851 | "warning: feature flags set on rev 0 fs, " |
| 852 | "running e2fsck is recommended"); | ||
| 845 | /* | 853 | /* |
| 846 | * Check feature flags regardless of the revision level, since we | 854 | * Check feature flags regardless of the revision level, since we |
| 847 | * previously didn't change the revision level when setting the flags, | 855 | * previously didn't change the revision level when setting the flags, |
| @@ -849,16 +857,16 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 849 | */ | 857 | */ |
| 850 | features = EXT2_HAS_INCOMPAT_FEATURE(sb, ~EXT2_FEATURE_INCOMPAT_SUPP); | 858 | features = EXT2_HAS_INCOMPAT_FEATURE(sb, ~EXT2_FEATURE_INCOMPAT_SUPP); |
| 851 | if (features) { | 859 | if (features) { |
| 852 | printk("EXT2-fs: %s: couldn't mount because of " | 860 | ext2_msg(sb, KERN_ERR, "error: couldn't mount because of " |
| 853 | "unsupported optional features (%x).\n", | 861 | "unsupported optional features (%x)", |
| 854 | sb->s_id, le32_to_cpu(features)); | 862 | le32_to_cpu(features)); |
| 855 | goto failed_mount; | 863 | goto failed_mount; |
| 856 | } | 864 | } |
| 857 | if (!(sb->s_flags & MS_RDONLY) && | 865 | if (!(sb->s_flags & MS_RDONLY) && |
| 858 | (features = EXT2_HAS_RO_COMPAT_FEATURE(sb, ~EXT2_FEATURE_RO_COMPAT_SUPP))){ | 866 | (features = EXT2_HAS_RO_COMPAT_FEATURE(sb, ~EXT2_FEATURE_RO_COMPAT_SUPP))){ |
| 859 | printk("EXT2-fs: %s: couldn't mount RDWR because of " | 867 | ext2_msg(sb, KERN_ERR, "error: couldn't mount RDWR because of " |
| 860 | "unsupported optional features (%x).\n", | 868 | "unsupported optional features (%x)", |
| 861 | sb->s_id, le32_to_cpu(features)); | 869 | le32_to_cpu(features)); |
| 862 | goto failed_mount; | 870 | goto failed_mount; |
| 863 | } | 871 | } |
| 864 | 872 | ||
| @@ -866,7 +874,8 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 866 | 874 | ||
| 867 | if (ext2_use_xip(sb) && blocksize != PAGE_SIZE) { | 875 | if (ext2_use_xip(sb) && blocksize != PAGE_SIZE) { |
| 868 | if (!silent) | 876 | if (!silent) |
| 869 | printk("XIP: Unsupported blocksize\n"); | 877 | ext2_msg(sb, KERN_ERR, |
| 878 | "error: unsupported blocksize for xip"); | ||
| 870 | goto failed_mount; | 879 | goto failed_mount; |
| 871 | } | 880 | } |
| 872 | 881 | ||
| @@ -875,7 +884,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 875 | brelse(bh); | 884 | brelse(bh); |
| 876 | 885 | ||
| 877 | if (!sb_set_blocksize(sb, blocksize)) { | 886 | if (!sb_set_blocksize(sb, blocksize)) { |
| 878 | printk(KERN_ERR "EXT2-fs: blocksize too small for device.\n"); | 887 | ext2_msg(sb, KERN_ERR, "error: blocksize is too small"); |
| 879 | goto failed_sbi; | 888 | goto failed_sbi; |
| 880 | } | 889 | } |
| 881 | 890 | ||
| @@ -883,14 +892,14 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 883 | offset = (sb_block*BLOCK_SIZE) % blocksize; | 892 | offset = (sb_block*BLOCK_SIZE) % blocksize; |
| 884 | bh = sb_bread(sb, logic_sb_block); | 893 | bh = sb_bread(sb, logic_sb_block); |
| 885 | if(!bh) { | 894 | if(!bh) { |
| 886 | printk("EXT2-fs: Couldn't read superblock on " | 895 | ext2_msg(sb, KERN_ERR, "error: couldn't read" |
| 887 | "2nd try.\n"); | 896 | "superblock on 2nd try"); |
| 888 | goto failed_sbi; | 897 | goto failed_sbi; |
| 889 | } | 898 | } |
| 890 | es = (struct ext2_super_block *) (((char *)bh->b_data) + offset); | 899 | es = (struct ext2_super_block *) (((char *)bh->b_data) + offset); |
| 891 | sbi->s_es = es; | 900 | sbi->s_es = es; |
| 892 | if (es->s_magic != cpu_to_le16(EXT2_SUPER_MAGIC)) { | 901 | if (es->s_magic != cpu_to_le16(EXT2_SUPER_MAGIC)) { |
| 893 | printk ("EXT2-fs: Magic mismatch, very weird !\n"); | 902 | ext2_msg(sb, KERN_ERR, "error: magic mismatch"); |
| 894 | goto failed_mount; | 903 | goto failed_mount; |
| 895 | } | 904 | } |
| 896 | } | 905 | } |
| @@ -906,7 +915,8 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 906 | if ((sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE) || | 915 | if ((sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE) || |
| 907 | !is_power_of_2(sbi->s_inode_size) || | 916 | !is_power_of_2(sbi->s_inode_size) || |
| 908 | (sbi->s_inode_size > blocksize)) { | 917 | (sbi->s_inode_size > blocksize)) { |
| 909 | printk ("EXT2-fs: unsupported inode size: %d\n", | 918 | ext2_msg(sb, KERN_ERR, |
| 919 | "error: unsupported inode size: %d", | ||
| 910 | sbi->s_inode_size); | 920 | sbi->s_inode_size); |
| 911 | goto failed_mount; | 921 | goto failed_mount; |
| 912 | } | 922 | } |
| @@ -943,29 +953,33 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 943 | 953 | ||
| 944 | if (sb->s_blocksize != bh->b_size) { | 954 | if (sb->s_blocksize != bh->b_size) { |
| 945 | if (!silent) | 955 | if (!silent) |
| 946 | printk ("VFS: Unsupported blocksize on dev " | 956 | ext2_msg(sb, KERN_ERR, "error: unsupported blocksize"); |
| 947 | "%s.\n", sb->s_id); | ||
| 948 | goto failed_mount; | 957 | goto failed_mount; |
| 949 | } | 958 | } |
| 950 | 959 | ||
| 951 | if (sb->s_blocksize != sbi->s_frag_size) { | 960 | if (sb->s_blocksize != sbi->s_frag_size) { |
| 952 | printk ("EXT2-fs: fragsize %lu != blocksize %lu (not supported yet)\n", | 961 | ext2_msg(sb, KERN_ERR, |
| 962 | "error: fragsize %lu != blocksize %lu" | ||
| 963 | "(not supported yet)", | ||
| 953 | sbi->s_frag_size, sb->s_blocksize); | 964 | sbi->s_frag_size, sb->s_blocksize); |
| 954 | goto failed_mount; | 965 | goto failed_mount; |
| 955 | } | 966 | } |
| 956 | 967 | ||
| 957 | if (sbi->s_blocks_per_group > sb->s_blocksize * 8) { | 968 | if (sbi->s_blocks_per_group > sb->s_blocksize * 8) { |
| 958 | printk ("EXT2-fs: #blocks per group too big: %lu\n", | 969 | ext2_msg(sb, KERN_ERR, |
| 970 | "error: #blocks per group too big: %lu", | ||
| 959 | sbi->s_blocks_per_group); | 971 | sbi->s_blocks_per_group); |
| 960 | goto failed_mount; | 972 | goto failed_mount; |
| 961 | } | 973 | } |
| 962 | if (sbi->s_frags_per_group > sb->s_blocksize * 8) { | 974 | if (sbi->s_frags_per_group > sb->s_blocksize * 8) { |
| 963 | printk ("EXT2-fs: #fragments per group too big: %lu\n", | 975 | ext2_msg(sb, KERN_ERR, |
| 976 | "error: #fragments per group too big: %lu", | ||
| 964 | sbi->s_frags_per_group); | 977 | sbi->s_frags_per_group); |
| 965 | goto failed_mount; | 978 | goto failed_mount; |
| 966 | } | 979 | } |
| 967 | if (sbi->s_inodes_per_group > sb->s_blocksize * 8) { | 980 | if (sbi->s_inodes_per_group > sb->s_blocksize * 8) { |
| 968 | printk ("EXT2-fs: #inodes per group too big: %lu\n", | 981 | ext2_msg(sb, KERN_ERR, |
| 982 | "error: #inodes per group too big: %lu", | ||
| 969 | sbi->s_inodes_per_group); | 983 | sbi->s_inodes_per_group); |
| 970 | goto failed_mount; | 984 | goto failed_mount; |
| 971 | } | 985 | } |
| @@ -979,13 +993,13 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 979 | EXT2_DESC_PER_BLOCK(sb); | 993 | EXT2_DESC_PER_BLOCK(sb); |
| 980 | sbi->s_group_desc = kmalloc (db_count * sizeof (struct buffer_head *), GFP_KERNEL); | 994 | sbi->s_group_desc = kmalloc (db_count * sizeof (struct buffer_head *), GFP_KERNEL); |
| 981 | if (sbi->s_group_desc == NULL) { | 995 | if (sbi->s_group_desc == NULL) { |
| 982 | printk ("EXT2-fs: not enough memory\n"); | 996 | ext2_msg(sb, KERN_ERR, "error: not enough memory"); |
| 983 | goto failed_mount; | 997 | goto failed_mount; |
| 984 | } | 998 | } |
| 985 | bgl_lock_init(sbi->s_blockgroup_lock); | 999 | bgl_lock_init(sbi->s_blockgroup_lock); |
| 986 | sbi->s_debts = kcalloc(sbi->s_groups_count, sizeof(*sbi->s_debts), GFP_KERNEL); | 1000 | sbi->s_debts = kcalloc(sbi->s_groups_count, sizeof(*sbi->s_debts), GFP_KERNEL); |
| 987 | if (!sbi->s_debts) { | 1001 | if (!sbi->s_debts) { |
| 988 | printk ("EXT2-fs: not enough memory\n"); | 1002 | ext2_msg(sb, KERN_ERR, "error: not enough memory"); |
| 989 | goto failed_mount_group_desc; | 1003 | goto failed_mount_group_desc; |
| 990 | } | 1004 | } |
| 991 | for (i = 0; i < db_count; i++) { | 1005 | for (i = 0; i < db_count; i++) { |
| @@ -994,12 +1008,13 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 994 | if (!sbi->s_group_desc[i]) { | 1008 | if (!sbi->s_group_desc[i]) { |
| 995 | for (j = 0; j < i; j++) | 1009 | for (j = 0; j < i; j++) |
| 996 | brelse (sbi->s_group_desc[j]); | 1010 | brelse (sbi->s_group_desc[j]); |
| 997 | printk ("EXT2-fs: unable to read group descriptors\n"); | 1011 | ext2_msg(sb, KERN_ERR, |
| 1012 | "error: unable to read group descriptors"); | ||
| 998 | goto failed_mount_group_desc; | 1013 | goto failed_mount_group_desc; |
| 999 | } | 1014 | } |
| 1000 | } | 1015 | } |
| 1001 | if (!ext2_check_descriptors (sb)) { | 1016 | if (!ext2_check_descriptors (sb)) { |
| 1002 | printk ("EXT2-fs: group descriptors corrupted!\n"); | 1017 | ext2_msg(sb, KERN_ERR, "group descriptors corrupted"); |
| 1003 | goto failed_mount2; | 1018 | goto failed_mount2; |
| 1004 | } | 1019 | } |
| 1005 | sbi->s_gdb_count = db_count; | 1020 | sbi->s_gdb_count = db_count; |
| @@ -1032,7 +1047,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 1032 | ext2_count_dirs(sb)); | 1047 | ext2_count_dirs(sb)); |
| 1033 | } | 1048 | } |
| 1034 | if (err) { | 1049 | if (err) { |
| 1035 | printk(KERN_ERR "EXT2-fs: insufficient memory\n"); | 1050 | ext2_msg(sb, KERN_ERR, "error: insufficient memory"); |
| 1036 | goto failed_mount3; | 1051 | goto failed_mount3; |
| 1037 | } | 1052 | } |
| 1038 | /* | 1053 | /* |
| @@ -1048,27 +1063,28 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 1048 | } | 1063 | } |
| 1049 | if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) { | 1064 | if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) { |
| 1050 | iput(root); | 1065 | iput(root); |
| 1051 | printk(KERN_ERR "EXT2-fs: corrupt root inode, run e2fsck\n"); | 1066 | ext2_msg(sb, KERN_ERR, "error: corrupt root inode, run e2fsck"); |
| 1052 | goto failed_mount3; | 1067 | goto failed_mount3; |
| 1053 | } | 1068 | } |
| 1054 | 1069 | ||
| 1055 | sb->s_root = d_alloc_root(root); | 1070 | sb->s_root = d_alloc_root(root); |
| 1056 | if (!sb->s_root) { | 1071 | if (!sb->s_root) { |
| 1057 | iput(root); | 1072 | iput(root); |
| 1058 | printk(KERN_ERR "EXT2-fs: get root inode failed\n"); | 1073 | ext2_msg(sb, KERN_ERR, "error: get root inode failed"); |
| 1059 | ret = -ENOMEM; | 1074 | ret = -ENOMEM; |
| 1060 | goto failed_mount3; | 1075 | goto failed_mount3; |
| 1061 | } | 1076 | } |
| 1062 | if (EXT2_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) | 1077 | if (EXT2_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) |
| 1063 | ext2_warning(sb, __func__, | 1078 | ext2_msg(sb, KERN_WARNING, |
| 1064 | "mounting ext3 filesystem as ext2"); | 1079 | "warning: mounting ext3 filesystem as ext2"); |
| 1065 | ext2_setup_super (sb, es, sb->s_flags & MS_RDONLY); | 1080 | ext2_setup_super (sb, es, sb->s_flags & MS_RDONLY); |
| 1066 | return 0; | 1081 | return 0; |
| 1067 | 1082 | ||
| 1068 | cantfind_ext2: | 1083 | cantfind_ext2: |
| 1069 | if (!silent) | 1084 | if (!silent) |
| 1070 | printk("VFS: Can't find an ext2 filesystem on dev %s.\n", | 1085 | ext2_msg(sb, KERN_ERR, |
| 1071 | sb->s_id); | 1086 | "error: can't find an ext2 filesystem on dev %s.", |
| 1087 | sb->s_id); | ||
| 1072 | goto failed_mount; | 1088 | goto failed_mount; |
| 1073 | failed_mount3: | 1089 | failed_mount3: |
| 1074 | percpu_counter_destroy(&sbi->s_freeblocks_counter); | 1090 | percpu_counter_destroy(&sbi->s_freeblocks_counter); |
| @@ -1121,8 +1137,24 @@ static void ext2_sync_super(struct super_block *sb, struct ext2_super_block *es) | |||
| 1121 | static int ext2_sync_fs(struct super_block *sb, int wait) | 1137 | static int ext2_sync_fs(struct super_block *sb, int wait) |
| 1122 | { | 1138 | { |
| 1123 | struct ext2_super_block *es = EXT2_SB(sb)->s_es; | 1139 | struct ext2_super_block *es = EXT2_SB(sb)->s_es; |
| 1140 | struct buffer_head *sbh = EXT2_SB(sb)->s_sbh; | ||
| 1124 | 1141 | ||
| 1125 | lock_kernel(); | 1142 | lock_kernel(); |
| 1143 | if (buffer_write_io_error(sbh)) { | ||
| 1144 | /* | ||
| 1145 | * Oh, dear. A previous attempt to write the | ||
| 1146 | * superblock failed. This could happen because the | ||
| 1147 | * USB device was yanked out. Or it could happen to | ||
| 1148 | * be a transient write error and maybe the block will | ||
| 1149 | * be remapped. Nothing we can do but to retry the | ||
| 1150 | * write and hope for the best. | ||
| 1151 | */ | ||
| 1152 | ext2_msg(sb, KERN_ERR, | ||
| 1153 | "previous I/O error to superblock detected\n"); | ||
| 1154 | clear_buffer_write_io_error(sbh); | ||
| 1155 | set_buffer_uptodate(sbh); | ||
| 1156 | } | ||
| 1157 | |||
| 1126 | if (es->s_state & cpu_to_le16(EXT2_VALID_FS)) { | 1158 | if (es->s_state & cpu_to_le16(EXT2_VALID_FS)) { |
| 1127 | ext2_debug("setting valid to 0\n"); | 1159 | ext2_debug("setting valid to 0\n"); |
| 1128 | es->s_state &= cpu_to_le16(~EXT2_VALID_FS); | 1160 | es->s_state &= cpu_to_le16(~EXT2_VALID_FS); |
| @@ -1170,7 +1202,7 @@ static int ext2_remount (struct super_block * sb, int * flags, char * data) | |||
| 1170 | /* | 1202 | /* |
| 1171 | * Allow the "check" option to be passed as a remount option. | 1203 | * Allow the "check" option to be passed as a remount option. |
| 1172 | */ | 1204 | */ |
| 1173 | if (!parse_options (data, sbi)) { | 1205 | if (!parse_options(data, sb)) { |
| 1174 | err = -EINVAL; | 1206 | err = -EINVAL; |
| 1175 | goto restore_opts; | 1207 | goto restore_opts; |
| 1176 | } | 1208 | } |
| @@ -1182,7 +1214,8 @@ static int ext2_remount (struct super_block * sb, int * flags, char * data) | |||
| 1182 | EXT2_MOUNT_XIP if not */ | 1214 | EXT2_MOUNT_XIP if not */ |
| 1183 | 1215 | ||
| 1184 | if ((ext2_use_xip(sb)) && (sb->s_blocksize != PAGE_SIZE)) { | 1216 | if ((ext2_use_xip(sb)) && (sb->s_blocksize != PAGE_SIZE)) { |
| 1185 | printk("XIP: Unsupported blocksize\n"); | 1217 | ext2_msg(sb, KERN_WARNING, |
| 1218 | "warning: unsupported blocksize for xip"); | ||
| 1186 | err = -EINVAL; | 1219 | err = -EINVAL; |
| 1187 | goto restore_opts; | 1220 | goto restore_opts; |
| 1188 | } | 1221 | } |
| @@ -1191,8 +1224,8 @@ static int ext2_remount (struct super_block * sb, int * flags, char * data) | |||
| 1191 | if (((sbi->s_mount_opt & EXT2_MOUNT_XIP) != | 1224 | if (((sbi->s_mount_opt & EXT2_MOUNT_XIP) != |
| 1192 | (old_mount_opt & EXT2_MOUNT_XIP)) && | 1225 | (old_mount_opt & EXT2_MOUNT_XIP)) && |
| 1193 | invalidate_inodes(sb)) { | 1226 | invalidate_inodes(sb)) { |
| 1194 | ext2_warning(sb, __func__, "refusing change of xip flag " | 1227 | ext2_msg(sb, KERN_WARNING, "warning: refusing change of " |
| 1195 | "with busy inodes while remounting"); | 1228 | "xip flag with busy inodes while remounting"); |
| 1196 | sbi->s_mount_opt &= ~EXT2_MOUNT_XIP; | 1229 | sbi->s_mount_opt &= ~EXT2_MOUNT_XIP; |
| 1197 | sbi->s_mount_opt |= old_mount_opt & EXT2_MOUNT_XIP; | 1230 | sbi->s_mount_opt |= old_mount_opt & EXT2_MOUNT_XIP; |
| 1198 | } | 1231 | } |
| @@ -1216,9 +1249,10 @@ static int ext2_remount (struct super_block * sb, int * flags, char * data) | |||
| 1216 | __le32 ret = EXT2_HAS_RO_COMPAT_FEATURE(sb, | 1249 | __le32 ret = EXT2_HAS_RO_COMPAT_FEATURE(sb, |
| 1217 | ~EXT2_FEATURE_RO_COMPAT_SUPP); | 1250 | ~EXT2_FEATURE_RO_COMPAT_SUPP); |
| 1218 | if (ret) { | 1251 | if (ret) { |
| 1219 | printk("EXT2-fs: %s: couldn't remount RDWR because of " | 1252 | ext2_msg(sb, KERN_WARNING, |
| 1220 | "unsupported optional features (%x).\n", | 1253 | "warning: couldn't remount RDWR because of " |
| 1221 | sb->s_id, le32_to_cpu(ret)); | 1254 | "unsupported optional features (%x).", |
| 1255 | le32_to_cpu(ret)); | ||
| 1222 | err = -EROFS; | 1256 | err = -EROFS; |
| 1223 | goto restore_opts; | 1257 | goto restore_opts; |
| 1224 | } | 1258 | } |
diff --git a/fs/ext2/xip.c b/fs/ext2/xip.c index c18fbf3e4068..322a56b2dfb1 100644 --- a/fs/ext2/xip.c +++ b/fs/ext2/xip.c | |||
| @@ -69,8 +69,9 @@ void ext2_xip_verify_sb(struct super_block *sb) | |||
| 69 | if ((sbi->s_mount_opt & EXT2_MOUNT_XIP) && | 69 | if ((sbi->s_mount_opt & EXT2_MOUNT_XIP) && |
| 70 | !sb->s_bdev->bd_disk->fops->direct_access) { | 70 | !sb->s_bdev->bd_disk->fops->direct_access) { |
| 71 | sbi->s_mount_opt &= (~EXT2_MOUNT_XIP); | 71 | sbi->s_mount_opt &= (~EXT2_MOUNT_XIP); |
| 72 | ext2_warning(sb, __func__, | 72 | ext2_msg(sb, KERN_WARNING, |
| 73 | "ignoring xip option - not supported by bdev"); | 73 | "warning: ignoring xip option - " |
| 74 | "not supported by bdev"); | ||
| 74 | } | 75 | } |
| 75 | } | 76 | } |
| 76 | 77 | ||
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 354ed3b47b30..ad14227f509e 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
| @@ -1151,6 +1151,16 @@ static int do_journal_get_write_access(handle_t *handle, | |||
| 1151 | return ext3_journal_get_write_access(handle, bh); | 1151 | return ext3_journal_get_write_access(handle, bh); |
| 1152 | } | 1152 | } |
| 1153 | 1153 | ||
| 1154 | /* | ||
| 1155 | * Truncate blocks that were not used by write. We have to truncate the | ||
| 1156 | * pagecache as well so that corresponding buffers get properly unmapped. | ||
| 1157 | */ | ||
| 1158 | static void ext3_truncate_failed_write(struct inode *inode) | ||
| 1159 | { | ||
| 1160 | truncate_inode_pages(inode->i_mapping, inode->i_size); | ||
| 1161 | ext3_truncate(inode); | ||
| 1162 | } | ||
| 1163 | |||
| 1154 | static int ext3_write_begin(struct file *file, struct address_space *mapping, | 1164 | static int ext3_write_begin(struct file *file, struct address_space *mapping, |
| 1155 | loff_t pos, unsigned len, unsigned flags, | 1165 | loff_t pos, unsigned len, unsigned flags, |
| 1156 | struct page **pagep, void **fsdata) | 1166 | struct page **pagep, void **fsdata) |
| @@ -1209,7 +1219,7 @@ write_begin_failed: | |||
| 1209 | unlock_page(page); | 1219 | unlock_page(page); |
| 1210 | page_cache_release(page); | 1220 | page_cache_release(page); |
| 1211 | if (pos + len > inode->i_size) | 1221 | if (pos + len > inode->i_size) |
| 1212 | ext3_truncate(inode); | 1222 | ext3_truncate_failed_write(inode); |
| 1213 | } | 1223 | } |
| 1214 | if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries)) | 1224 | if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries)) |
| 1215 | goto retry; | 1225 | goto retry; |
| @@ -1304,7 +1314,7 @@ static int ext3_ordered_write_end(struct file *file, | |||
| 1304 | page_cache_release(page); | 1314 | page_cache_release(page); |
| 1305 | 1315 | ||
| 1306 | if (pos + len > inode->i_size) | 1316 | if (pos + len > inode->i_size) |
| 1307 | ext3_truncate(inode); | 1317 | ext3_truncate_failed_write(inode); |
| 1308 | return ret ? ret : copied; | 1318 | return ret ? ret : copied; |
| 1309 | } | 1319 | } |
| 1310 | 1320 | ||
| @@ -1330,7 +1340,7 @@ static int ext3_writeback_write_end(struct file *file, | |||
| 1330 | page_cache_release(page); | 1340 | page_cache_release(page); |
| 1331 | 1341 | ||
| 1332 | if (pos + len > inode->i_size) | 1342 | if (pos + len > inode->i_size) |
| 1333 | ext3_truncate(inode); | 1343 | ext3_truncate_failed_write(inode); |
| 1334 | return ret ? ret : copied; | 1344 | return ret ? ret : copied; |
| 1335 | } | 1345 | } |
| 1336 | 1346 | ||
| @@ -1383,7 +1393,7 @@ static int ext3_journalled_write_end(struct file *file, | |||
| 1383 | page_cache_release(page); | 1393 | page_cache_release(page); |
| 1384 | 1394 | ||
| 1385 | if (pos + len > inode->i_size) | 1395 | if (pos + len > inode->i_size) |
| 1386 | ext3_truncate(inode); | 1396 | ext3_truncate_failed_write(inode); |
| 1387 | return ret ? ret : copied; | 1397 | return ret ? ret : copied; |
| 1388 | } | 1398 | } |
| 1389 | 1399 | ||
| @@ -2033,7 +2043,7 @@ static Indirect *ext3_find_shared(struct inode *inode, int depth, | |||
| 2033 | int k, err; | 2043 | int k, err; |
| 2034 | 2044 | ||
| 2035 | *top = 0; | 2045 | *top = 0; |
| 2036 | /* Make k index the deepest non-null offest + 1 */ | 2046 | /* Make k index the deepest non-null offset + 1 */ |
| 2037 | for (k = depth; k > 1 && !offsets[k-1]; k--) | 2047 | for (k = depth; k > 1 && !offsets[k-1]; k--) |
| 2038 | ; | 2048 | ; |
| 2039 | partial = ext3_get_branch(inode, k, offsets, chain, &err); | 2049 | partial = ext3_get_branch(inode, k, offsets, chain, &err); |
diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 8359e7b3dc89..5f83b6179178 100644 --- a/fs/ext3/resize.c +++ b/fs/ext3/resize.c | |||
| @@ -266,7 +266,7 @@ static int setup_new_group_blocks(struct super_block *sb, | |||
| 266 | goto exit_bh; | 266 | goto exit_bh; |
| 267 | 267 | ||
| 268 | if (IS_ERR(gdb = bclean(handle, sb, block))) { | 268 | if (IS_ERR(gdb = bclean(handle, sb, block))) { |
| 269 | err = PTR_ERR(bh); | 269 | err = PTR_ERR(gdb); |
| 270 | goto exit_bh; | 270 | goto exit_bh; |
| 271 | } | 271 | } |
| 272 | ext3_journal_dirty_metadata(handle, gdb); | 272 | ext3_journal_dirty_metadata(handle, gdb); |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 427496c4767c..7ad1e8c30bd0 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
| @@ -135,12 +135,24 @@ void ext3_journal_abort_handle(const char *caller, const char *err_fn, | |||
| 135 | if (is_handle_aborted(handle)) | 135 | if (is_handle_aborted(handle)) |
| 136 | return; | 136 | return; |
| 137 | 137 | ||
| 138 | printk(KERN_ERR "%s: aborting transaction: %s in %s\n", | 138 | printk(KERN_ERR "EXT3-fs: %s: aborting transaction: %s in %s\n", |
| 139 | caller, errstr, err_fn); | 139 | caller, errstr, err_fn); |
| 140 | 140 | ||
| 141 | journal_abort_handle(handle); | 141 | journal_abort_handle(handle); |
| 142 | } | 142 | } |
| 143 | 143 | ||
| 144 | void ext3_msg(struct super_block *sb, const char *prefix, | ||
| 145 | const char *fmt, ...) | ||
| 146 | { | ||
| 147 | va_list args; | ||
| 148 | |||
| 149 | va_start(args, fmt); | ||
| 150 | printk("%sEXT3-fs (%s): ", prefix, sb->s_id); | ||
| 151 | vprintk(fmt, args); | ||
| 152 | printk("\n"); | ||
| 153 | va_end(args); | ||
| 154 | } | ||
| 155 | |||
| 144 | /* Deal with the reporting of failure conditions on a filesystem such as | 156 | /* Deal with the reporting of failure conditions on a filesystem such as |
| 145 | * inconsistencies detected or read IO failures. | 157 | * inconsistencies detected or read IO failures. |
| 146 | * | 158 | * |
| @@ -174,12 +186,13 @@ static void ext3_handle_error(struct super_block *sb) | |||
| 174 | journal_abort(journal, -EIO); | 186 | journal_abort(journal, -EIO); |
| 175 | } | 187 | } |
| 176 | if (test_opt (sb, ERRORS_RO)) { | 188 | if (test_opt (sb, ERRORS_RO)) { |
| 177 | printk (KERN_CRIT "Remounting filesystem read-only\n"); | 189 | ext3_msg(sb, KERN_CRIT, |
| 190 | "error: remounting filesystem read-only"); | ||
| 178 | sb->s_flags |= MS_RDONLY; | 191 | sb->s_flags |= MS_RDONLY; |
| 179 | } | 192 | } |
| 180 | ext3_commit_super(sb, es, 1); | 193 | ext3_commit_super(sb, es, 1); |
| 181 | if (test_opt(sb, ERRORS_PANIC)) | 194 | if (test_opt(sb, ERRORS_PANIC)) |
| 182 | panic("EXT3-fs (device %s): panic forced after error\n", | 195 | panic("EXT3-fs (%s): panic forced after error\n", |
| 183 | sb->s_id); | 196 | sb->s_id); |
| 184 | } | 197 | } |
| 185 | 198 | ||
| @@ -247,8 +260,7 @@ void __ext3_std_error (struct super_block * sb, const char * function, | |||
| 247 | return; | 260 | return; |
| 248 | 261 | ||
| 249 | errstr = ext3_decode_error(sb, errno, nbuf); | 262 | errstr = ext3_decode_error(sb, errno, nbuf); |
| 250 | printk (KERN_CRIT "EXT3-fs error (device %s) in %s: %s\n", | 263 | ext3_msg(sb, KERN_CRIT, "error in %s: %s", function, errstr); |
| 251 | sb->s_id, function, errstr); | ||
| 252 | 264 | ||
| 253 | ext3_handle_error(sb); | 265 | ext3_handle_error(sb); |
| 254 | } | 266 | } |
| @@ -268,21 +280,20 @@ void ext3_abort (struct super_block * sb, const char * function, | |||
| 268 | { | 280 | { |
| 269 | va_list args; | 281 | va_list args; |
| 270 | 282 | ||
| 271 | printk (KERN_CRIT "ext3_abort called.\n"); | ||
| 272 | |||
| 273 | va_start(args, fmt); | 283 | va_start(args, fmt); |
| 274 | printk(KERN_CRIT "EXT3-fs error (device %s): %s: ",sb->s_id, function); | 284 | printk(KERN_CRIT "EXT3-fs (%s): error: %s: ", sb->s_id, function); |
| 275 | vprintk(fmt, args); | 285 | vprintk(fmt, args); |
| 276 | printk("\n"); | 286 | printk("\n"); |
| 277 | va_end(args); | 287 | va_end(args); |
| 278 | 288 | ||
| 279 | if (test_opt(sb, ERRORS_PANIC)) | 289 | if (test_opt(sb, ERRORS_PANIC)) |
| 280 | panic("EXT3-fs panic from previous error\n"); | 290 | panic("EXT3-fs: panic from previous error\n"); |
| 281 | 291 | ||
| 282 | if (sb->s_flags & MS_RDONLY) | 292 | if (sb->s_flags & MS_RDONLY) |
| 283 | return; | 293 | return; |
| 284 | 294 | ||
| 285 | printk(KERN_CRIT "Remounting filesystem read-only\n"); | 295 | ext3_msg(sb, KERN_CRIT, |
| 296 | "error: remounting filesystem read-only"); | ||
| 286 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; | 297 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; |
| 287 | sb->s_flags |= MS_RDONLY; | 298 | sb->s_flags |= MS_RDONLY; |
| 288 | EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT; | 299 | EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT; |
| @@ -296,7 +307,7 @@ void ext3_warning (struct super_block * sb, const char * function, | |||
| 296 | va_list args; | 307 | va_list args; |
| 297 | 308 | ||
| 298 | va_start(args, fmt); | 309 | va_start(args, fmt); |
| 299 | printk(KERN_WARNING "EXT3-fs warning (device %s): %s: ", | 310 | printk(KERN_WARNING "EXT3-fs (%s): warning: %s: ", |
| 300 | sb->s_id, function); | 311 | sb->s_id, function); |
| 301 | vprintk(fmt, args); | 312 | vprintk(fmt, args); |
| 302 | printk("\n"); | 313 | printk("\n"); |
| @@ -310,10 +321,10 @@ void ext3_update_dynamic_rev(struct super_block *sb) | |||
| 310 | if (le32_to_cpu(es->s_rev_level) > EXT3_GOOD_OLD_REV) | 321 | if (le32_to_cpu(es->s_rev_level) > EXT3_GOOD_OLD_REV) |
| 311 | return; | 322 | return; |
| 312 | 323 | ||
| 313 | ext3_warning(sb, __func__, | 324 | ext3_msg(sb, KERN_WARNING, |
| 314 | "updating to rev %d because of new feature flag, " | 325 | "warning: updating to rev %d because of " |
| 315 | "running e2fsck is recommended", | 326 | "new feature flag, running e2fsck is recommended", |
| 316 | EXT3_DYNAMIC_REV); | 327 | EXT3_DYNAMIC_REV); |
| 317 | 328 | ||
| 318 | es->s_first_ino = cpu_to_le32(EXT3_GOOD_OLD_FIRST_INO); | 329 | es->s_first_ino = cpu_to_le32(EXT3_GOOD_OLD_FIRST_INO); |
| 319 | es->s_inode_size = cpu_to_le16(EXT3_GOOD_OLD_INODE_SIZE); | 330 | es->s_inode_size = cpu_to_le16(EXT3_GOOD_OLD_INODE_SIZE); |
| @@ -331,7 +342,7 @@ void ext3_update_dynamic_rev(struct super_block *sb) | |||
| 331 | /* | 342 | /* |
| 332 | * Open the external journal device | 343 | * Open the external journal device |
| 333 | */ | 344 | */ |
| 334 | static struct block_device *ext3_blkdev_get(dev_t dev) | 345 | static struct block_device *ext3_blkdev_get(dev_t dev, struct super_block *sb) |
| 335 | { | 346 | { |
| 336 | struct block_device *bdev; | 347 | struct block_device *bdev; |
| 337 | char b[BDEVNAME_SIZE]; | 348 | char b[BDEVNAME_SIZE]; |
| @@ -342,8 +353,9 @@ static struct block_device *ext3_blkdev_get(dev_t dev) | |||
| 342 | return bdev; | 353 | return bdev; |
| 343 | 354 | ||
| 344 | fail: | 355 | fail: |
| 345 | printk(KERN_ERR "EXT3: failed to open journal device %s: %ld\n", | 356 | ext3_msg(sb, "error: failed to open journal device %s: %ld", |
| 346 | __bdevname(dev, b), PTR_ERR(bdev)); | 357 | __bdevname(dev, b), PTR_ERR(bdev)); |
| 358 | |||
| 347 | return NULL; | 359 | return NULL; |
| 348 | } | 360 | } |
| 349 | 361 | ||
| @@ -378,13 +390,13 @@ static void dump_orphan_list(struct super_block *sb, struct ext3_sb_info *sbi) | |||
| 378 | { | 390 | { |
| 379 | struct list_head *l; | 391 | struct list_head *l; |
| 380 | 392 | ||
| 381 | printk(KERN_ERR "sb orphan head is %d\n", | 393 | ext3_msg(sb, KERN_ERR, "error: sb orphan head is %d", |
| 382 | le32_to_cpu(sbi->s_es->s_last_orphan)); | 394 | le32_to_cpu(sbi->s_es->s_last_orphan)); |
| 383 | 395 | ||
| 384 | printk(KERN_ERR "sb_info orphan list:\n"); | 396 | ext3_msg(sb, KERN_ERR, "sb_info orphan list:"); |
| 385 | list_for_each(l, &sbi->s_orphan) { | 397 | list_for_each(l, &sbi->s_orphan) { |
| 386 | struct inode *inode = orphan_list_entry(l); | 398 | struct inode *inode = orphan_list_entry(l); |
| 387 | printk(KERN_ERR " " | 399 | ext3_msg(sb, KERN_ERR, " " |
| 388 | "inode %s:%lu at %p: mode %o, nlink %d, next %d\n", | 400 | "inode %s:%lu at %p: mode %o, nlink %d, next %d\n", |
| 389 | inode->i_sb->s_id, inode->i_ino, inode, | 401 | inode->i_sb->s_id, inode->i_ino, inode, |
| 390 | inode->i_mode, inode->i_nlink, | 402 | inode->i_mode, inode->i_nlink, |
| @@ -527,9 +539,22 @@ static inline void ext3_show_quota_options(struct seq_file *seq, struct super_bl | |||
| 527 | #if defined(CONFIG_QUOTA) | 539 | #if defined(CONFIG_QUOTA) |
| 528 | struct ext3_sb_info *sbi = EXT3_SB(sb); | 540 | struct ext3_sb_info *sbi = EXT3_SB(sb); |
| 529 | 541 | ||
| 530 | if (sbi->s_jquota_fmt) | 542 | if (sbi->s_jquota_fmt) { |
| 531 | seq_printf(seq, ",jqfmt=%s", | 543 | char *fmtname = ""; |
| 532 | (sbi->s_jquota_fmt == QFMT_VFS_OLD) ? "vfsold": "vfsv0"); | 544 | |
| 545 | switch (sbi->s_jquota_fmt) { | ||
| 546 | case QFMT_VFS_OLD: | ||
| 547 | fmtname = "vfsold"; | ||
| 548 | break; | ||
| 549 | case QFMT_VFS_V0: | ||
| 550 | fmtname = "vfsv0"; | ||
| 551 | break; | ||
| 552 | case QFMT_VFS_V1: | ||
| 553 | fmtname = "vfsv1"; | ||
| 554 | break; | ||
| 555 | } | ||
| 556 | seq_printf(seq, ",jqfmt=%s", fmtname); | ||
| 557 | } | ||
| 533 | 558 | ||
| 534 | if (sbi->s_qf_names[USRQUOTA]) | 559 | if (sbi->s_qf_names[USRQUOTA]) |
| 535 | seq_printf(seq, ",usrjquota=%s", sbi->s_qf_names[USRQUOTA]); | 560 | seq_printf(seq, ",usrjquota=%s", sbi->s_qf_names[USRQUOTA]); |
| @@ -636,6 +661,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
| 636 | if (test_opt(sb, DATA_ERR_ABORT)) | 661 | if (test_opt(sb, DATA_ERR_ABORT)) |
| 637 | seq_puts(seq, ",data_err=abort"); | 662 | seq_puts(seq, ",data_err=abort"); |
| 638 | 663 | ||
| 664 | if (test_opt(sb, NOLOAD)) | ||
| 665 | seq_puts(seq, ",norecovery"); | ||
| 666 | |||
| 639 | ext3_show_quota_options(seq, sb); | 667 | ext3_show_quota_options(seq, sb); |
| 640 | 668 | ||
| 641 | return 0; | 669 | return 0; |
| @@ -787,9 +815,9 @@ enum { | |||
| 787 | Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback, | 815 | Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback, |
| 788 | Opt_data_err_abort, Opt_data_err_ignore, | 816 | Opt_data_err_abort, Opt_data_err_ignore, |
| 789 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, | 817 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, |
| 790 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota, | 818 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_jqfmt_vfsv1, Opt_quota, |
| 791 | Opt_ignore, Opt_barrier, Opt_err, Opt_resize, Opt_usrquota, | 819 | Opt_noquota, Opt_ignore, Opt_barrier, Opt_err, Opt_resize, |
| 792 | Opt_grpquota | 820 | Opt_usrquota, Opt_grpquota |
| 793 | }; | 821 | }; |
| 794 | 822 | ||
| 795 | static const match_table_t tokens = { | 823 | static const match_table_t tokens = { |
| @@ -818,6 +846,7 @@ static const match_table_t tokens = { | |||
| 818 | {Opt_reservation, "reservation"}, | 846 | {Opt_reservation, "reservation"}, |
| 819 | {Opt_noreservation, "noreservation"}, | 847 | {Opt_noreservation, "noreservation"}, |
| 820 | {Opt_noload, "noload"}, | 848 | {Opt_noload, "noload"}, |
| 849 | {Opt_noload, "norecovery"}, | ||
| 821 | {Opt_nobh, "nobh"}, | 850 | {Opt_nobh, "nobh"}, |
| 822 | {Opt_bh, "bh"}, | 851 | {Opt_bh, "bh"}, |
| 823 | {Opt_commit, "commit=%u"}, | 852 | {Opt_commit, "commit=%u"}, |
| @@ -836,6 +865,7 @@ static const match_table_t tokens = { | |||
| 836 | {Opt_grpjquota, "grpjquota=%s"}, | 865 | {Opt_grpjquota, "grpjquota=%s"}, |
| 837 | {Opt_jqfmt_vfsold, "jqfmt=vfsold"}, | 866 | {Opt_jqfmt_vfsold, "jqfmt=vfsold"}, |
| 838 | {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"}, | 867 | {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"}, |
| 868 | {Opt_jqfmt_vfsv1, "jqfmt=vfsv1"}, | ||
| 839 | {Opt_grpquota, "grpquota"}, | 869 | {Opt_grpquota, "grpquota"}, |
| 840 | {Opt_noquota, "noquota"}, | 870 | {Opt_noquota, "noquota"}, |
| 841 | {Opt_quota, "quota"}, | 871 | {Opt_quota, "quota"}, |
| @@ -845,7 +875,7 @@ static const match_table_t tokens = { | |||
| 845 | {Opt_err, NULL}, | 875 | {Opt_err, NULL}, |
| 846 | }; | 876 | }; |
| 847 | 877 | ||
| 848 | static ext3_fsblk_t get_sb_block(void **data) | 878 | static ext3_fsblk_t get_sb_block(void **data, struct super_block *sb) |
| 849 | { | 879 | { |
| 850 | ext3_fsblk_t sb_block; | 880 | ext3_fsblk_t sb_block; |
| 851 | char *options = (char *) *data; | 881 | char *options = (char *) *data; |
| @@ -856,7 +886,7 @@ static ext3_fsblk_t get_sb_block(void **data) | |||
| 856 | /*todo: use simple_strtoll with >32bit ext3 */ | 886 | /*todo: use simple_strtoll with >32bit ext3 */ |
| 857 | sb_block = simple_strtoul(options, &options, 0); | 887 | sb_block = simple_strtoul(options, &options, 0); |
| 858 | if (*options && *options != ',') { | 888 | if (*options && *options != ',') { |
| 859 | printk("EXT3-fs: Invalid sb specification: %s\n", | 889 | ext3_msg(sb, "error: invalid sb specification: %s", |
| 860 | (char *) *data); | 890 | (char *) *data); |
| 861 | return 1; | 891 | return 1; |
| 862 | } | 892 | } |
| @@ -956,7 +986,8 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 956 | #else | 986 | #else |
| 957 | case Opt_user_xattr: | 987 | case Opt_user_xattr: |
| 958 | case Opt_nouser_xattr: | 988 | case Opt_nouser_xattr: |
| 959 | printk("EXT3 (no)user_xattr options not supported\n"); | 989 | ext3_msg(sb, KERN_INFO, |
| 990 | "(no)user_xattr options not supported"); | ||
| 960 | break; | 991 | break; |
| 961 | #endif | 992 | #endif |
| 962 | #ifdef CONFIG_EXT3_FS_POSIX_ACL | 993 | #ifdef CONFIG_EXT3_FS_POSIX_ACL |
| @@ -969,7 +1000,8 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 969 | #else | 1000 | #else |
| 970 | case Opt_acl: | 1001 | case Opt_acl: |
| 971 | case Opt_noacl: | 1002 | case Opt_noacl: |
| 972 | printk("EXT3 (no)acl options not supported\n"); | 1003 | ext3_msg(sb, KERN_INFO, |
| 1004 | "(no)acl options not supported"); | ||
| 973 | break; | 1005 | break; |
| 974 | #endif | 1006 | #endif |
| 975 | case Opt_reservation: | 1007 | case Opt_reservation: |
| @@ -985,16 +1017,16 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 985 | user to specify an existing inode to be the | 1017 | user to specify an existing inode to be the |
| 986 | journal file. */ | 1018 | journal file. */ |
| 987 | if (is_remount) { | 1019 | if (is_remount) { |
| 988 | printk(KERN_ERR "EXT3-fs: cannot specify " | 1020 | ext3_msg(sb, KERN_ERR, "error: cannot specify " |
| 989 | "journal on remount\n"); | 1021 | "journal on remount"); |
| 990 | return 0; | 1022 | return 0; |
| 991 | } | 1023 | } |
| 992 | set_opt (sbi->s_mount_opt, UPDATE_JOURNAL); | 1024 | set_opt (sbi->s_mount_opt, UPDATE_JOURNAL); |
| 993 | break; | 1025 | break; |
| 994 | case Opt_journal_inum: | 1026 | case Opt_journal_inum: |
| 995 | if (is_remount) { | 1027 | if (is_remount) { |
| 996 | printk(KERN_ERR "EXT3-fs: cannot specify " | 1028 | ext3_msg(sb, KERN_ERR, "error: cannot specify " |
| 997 | "journal on remount\n"); | 1029 | "journal on remount"); |
| 998 | return 0; | 1030 | return 0; |
| 999 | } | 1031 | } |
| 1000 | if (match_int(&args[0], &option)) | 1032 | if (match_int(&args[0], &option)) |
| @@ -1003,8 +1035,8 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 1003 | break; | 1035 | break; |
| 1004 | case Opt_journal_dev: | 1036 | case Opt_journal_dev: |
| 1005 | if (is_remount) { | 1037 | if (is_remount) { |
| 1006 | printk(KERN_ERR "EXT3-fs: cannot specify " | 1038 | ext3_msg(sb, KERN_ERR, "error: cannot specify " |
| 1007 | "journal on remount\n"); | 1039 | "journal on remount"); |
| 1008 | return 0; | 1040 | return 0; |
| 1009 | } | 1041 | } |
| 1010 | if (match_int(&args[0], &option)) | 1042 | if (match_int(&args[0], &option)) |
| @@ -1036,12 +1068,11 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 1036 | if ((sbi->s_mount_opt & EXT3_MOUNT_DATA_FLAGS) | 1068 | if ((sbi->s_mount_opt & EXT3_MOUNT_DATA_FLAGS) |
| 1037 | == data_opt) | 1069 | == data_opt) |
| 1038 | break; | 1070 | break; |
| 1039 | printk(KERN_ERR | 1071 | ext3_msg(sb, KERN_ERR, |
| 1040 | "EXT3-fs (device %s): Cannot change " | 1072 | "error: cannot change " |
| 1041 | "data mode on remount. The filesystem " | 1073 | "data mode on remount. The filesystem " |
| 1042 | "is mounted in data=%s mode and you " | 1074 | "is mounted in data=%s mode and you " |
| 1043 | "try to remount it in data=%s mode.\n", | 1075 | "try to remount it in data=%s mode.", |
| 1044 | sb->s_id, | ||
| 1045 | data_mode_string(sbi->s_mount_opt & | 1076 | data_mode_string(sbi->s_mount_opt & |
| 1046 | EXT3_MOUNT_DATA_FLAGS), | 1077 | EXT3_MOUNT_DATA_FLAGS), |
| 1047 | data_mode_string(data_opt)); | 1078 | data_mode_string(data_opt)); |
| @@ -1066,31 +1097,31 @@ static int parse_options (char *options, struct super_block *sb, | |||
| 1066 | set_qf_name: | 1097 | set_qf_name: |
| 1067 | if (sb_any_quota_loaded(sb) && | 1098 | if (sb_any_quota_loaded(sb) && |
| 1068 | !sbi->s_qf_names[qtype]) { | 1099 | !sbi->s_qf_names[qtype]) { |
| 1069 | printk(KERN_ERR | 1100 | ext3_msg(sb, KERN_ERR, |
| 1070 | "EXT3-fs: Cannot change journaled " | 1101 | "error: cannot change journaled " |
| 1071 | "quota options when quota turned on.\n"); | 1102 | "quota options when quota turned on."); |
| 1072 | return 0; | 1103 | return 0; |
| 1073 | } | 1104 | } |
| 1074 | qname = match_strdup(&args[0]); | 1105 | qname = match_strdup(&args[0]); |
| 1075 | if (!qname) { | 1106 | if (!qname) { |
| 1076 | printk(KERN_ERR | 1107 | ext3_msg(sb, KERN_ERR, |
| 1077 | "EXT3-fs: not enough memory for " | 1108 | "error: not enough memory for " |
| 1078 | "storing quotafile name.\n"); | 1109 | "storing quotafile name."); |
| 1079 | return 0; | 1110 | return 0; |
| 1080 | } | 1111 | } |
| 1081 | if (sbi->s_qf_names[qtype] && | 1112 | if (sbi->s_qf_names[qtype] && |
| 1082 | strcmp(sbi->s_qf_names[qtype], qname)) { | 1113 | strcmp(sbi->s_qf_names[qtype], qname)) { |
| 1083 | printk(KERN_ERR | 1114 | ext3_msg(sb, KERN_ERR, |
| 1084 | "EXT3-fs: %s quota file already " | 1115 | "error: %s quota file already " |
| 1085 | "specified.\n", QTYPE2NAME(qtype)); | 1116 | "specified.", QTYPE2NAME(qtype)); |
| 1086 | kfree(qname); | 1117 | kfree(qname); |
| 1087 | return 0; | 1118 | return 0; |
| 1088 | } | 1119 | } |
| 1089 | sbi->s_qf_names[qtype] = qname; | 1120 | sbi->s_qf_names[qtype] = qname; |
| 1090 | if (strchr(sbi->s_qf_names[qtype], '/')) { | 1121 | if (strchr(sbi->s_qf_names[qtype], '/')) { |
| 1091 | printk(KERN_ERR | 1122 | ext3_msg(sb, KERN_ERR, |
| 1092 | "EXT3-fs: quotafile must be on " | 1123 | "error: quotafile must be on " |
| 1093 | "filesystem root.\n"); | 1124 | "filesystem root."); |
| 1094 | kfree(sbi->s_qf_names[qtype]); | 1125 | kfree(sbi->s_qf_names[qtype]); |
| 1095 | sbi->s_qf_names[qtype] = NULL; | 1126 | sbi->s_qf_names[qtype] = NULL; |
| 1096 | return 0; | 1127 | return 0; |
| @@ -1105,9 +1136,9 @@ set_qf_name: | |||
| 1105 | clear_qf_name: | 1136 | clear_qf_name: |
| 1106 | if (sb_any_quota_loaded(sb) && | 1137 | if (sb_any_quota_loaded(sb) && |
| 1107 | sbi->s_qf_names[qtype]) { | 1138 | sbi->s_qf_names[qtype]) { |
| 1108 | printk(KERN_ERR "EXT3-fs: Cannot change " | 1139 | ext3_msg(sb, KERN_ERR, "error: cannot change " |
| 1109 | "journaled quota options when " | 1140 | "journaled quota options when " |
| 1110 | "quota turned on.\n"); | 1141 | "quota turned on."); |
| 1111 | return 0; | 1142 | return 0; |
| 1112 | } | 1143 | } |
| 1113 | /* | 1144 | /* |
| @@ -1121,12 +1152,15 @@ clear_qf_name: | |||
| 1121 | goto set_qf_format; | 1152 | goto set_qf_format; |
| 1122 | case Opt_jqfmt_vfsv0: | 1153 | case Opt_jqfmt_vfsv0: |
| 1123 | qfmt = QFMT_VFS_V0; | 1154 | qfmt = QFMT_VFS_V0; |
| 1155 | goto set_qf_format; | ||
| 1156 | case Opt_jqfmt_vfsv1: | ||
| 1157 | qfmt = QFMT_VFS_V1; | ||
| 1124 | set_qf_format: | 1158 | set_qf_format: |
| 1125 | if (sb_any_quota_loaded(sb) && | 1159 | if (sb_any_quota_loaded(sb) && |
| 1126 | sbi->s_jquota_fmt != qfmt) { | 1160 | sbi->s_jquota_fmt != qfmt) { |
| 1127 | printk(KERN_ERR "EXT3-fs: Cannot change " | 1161 | ext3_msg(sb, KERN_ERR, "error: cannot change " |
| 1128 | "journaled quota options when " | 1162 | "journaled quota options when " |
| 1129 | "quota turned on.\n"); | 1163 | "quota turned on."); |
| 1130 | return 0; | 1164 | return 0; |
| 1131 | } | 1165 | } |
| 1132 | sbi->s_jquota_fmt = qfmt; | 1166 | sbi->s_jquota_fmt = qfmt; |
| @@ -1142,8 +1176,8 @@ set_qf_format: | |||
| 1142 | break; | 1176 | break; |
| 1143 | case Opt_noquota: | 1177 | case Opt_noquota: |
| 1144 | if (sb_any_quota_loaded(sb)) { | 1178 | if (sb_any_quota_loaded(sb)) { |
| 1145 | printk(KERN_ERR "EXT3-fs: Cannot change quota " | 1179 | ext3_msg(sb, KERN_ERR, "error: cannot change " |
| 1146 | "options when quota turned on.\n"); | 1180 | "quota options when quota turned on."); |
| 1147 | return 0; | 1181 | return 0; |
| 1148 | } | 1182 | } |
| 1149 | clear_opt(sbi->s_mount_opt, QUOTA); | 1183 | clear_opt(sbi->s_mount_opt, QUOTA); |
| @@ -1154,8 +1188,8 @@ set_qf_format: | |||
| 1154 | case Opt_quota: | 1188 | case Opt_quota: |
| 1155 | case Opt_usrquota: | 1189 | case Opt_usrquota: |
| 1156 | case Opt_grpquota: | 1190 | case Opt_grpquota: |
| 1157 | printk(KERN_ERR | 1191 | ext3_msg(sb, KERN_ERR, |
| 1158 | "EXT3-fs: quota options not supported.\n"); | 1192 | "error: quota options not supported."); |
| 1159 | break; | 1193 | break; |
| 1160 | case Opt_usrjquota: | 1194 | case Opt_usrjquota: |
| 1161 | case Opt_grpjquota: | 1195 | case Opt_grpjquota: |
| @@ -1163,9 +1197,10 @@ set_qf_format: | |||
| 1163 | case Opt_offgrpjquota: | 1197 | case Opt_offgrpjquota: |
| 1164 | case Opt_jqfmt_vfsold: | 1198 | case Opt_jqfmt_vfsold: |
| 1165 | case Opt_jqfmt_vfsv0: | 1199 | case Opt_jqfmt_vfsv0: |
| 1166 | printk(KERN_ERR | 1200 | case Opt_jqfmt_vfsv1: |
| 1167 | "EXT3-fs: journaled quota options not " | 1201 | ext3_msg(sb, KERN_ERR, |
| 1168 | "supported.\n"); | 1202 | "error: journaled quota options not " |
| 1203 | "supported."); | ||
| 1169 | break; | 1204 | break; |
| 1170 | case Opt_noquota: | 1205 | case Opt_noquota: |
| 1171 | break; | 1206 | break; |
| @@ -1185,8 +1220,9 @@ set_qf_format: | |||
| 1185 | break; | 1220 | break; |
| 1186 | case Opt_resize: | 1221 | case Opt_resize: |
| 1187 | if (!is_remount) { | 1222 | if (!is_remount) { |
| 1188 | printk("EXT3-fs: resize option only available " | 1223 | ext3_msg(sb, KERN_ERR, |
| 1189 | "for remount\n"); | 1224 | "error: resize option only available " |
| 1225 | "for remount"); | ||
| 1190 | return 0; | 1226 | return 0; |
| 1191 | } | 1227 | } |
| 1192 | if (match_int(&args[0], &option) != 0) | 1228 | if (match_int(&args[0], &option) != 0) |
| @@ -1200,9 +1236,9 @@ set_qf_format: | |||
| 1200 | clear_opt(sbi->s_mount_opt, NOBH); | 1236 | clear_opt(sbi->s_mount_opt, NOBH); |
| 1201 | break; | 1237 | break; |
| 1202 | default: | 1238 | default: |
| 1203 | printk (KERN_ERR | 1239 | ext3_msg(sb, KERN_ERR, |
| 1204 | "EXT3-fs: Unrecognized mount option \"%s\" " | 1240 | "error: unrecognized mount option \"%s\" " |
| 1205 | "or missing value\n", p); | 1241 | "or missing value", p); |
| 1206 | return 0; | 1242 | return 0; |
| 1207 | } | 1243 | } |
| 1208 | } | 1244 | } |
| @@ -1220,21 +1256,21 @@ set_qf_format: | |||
| 1220 | (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA)) || | 1256 | (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA)) || |
| 1221 | (sbi->s_qf_names[GRPQUOTA] && | 1257 | (sbi->s_qf_names[GRPQUOTA] && |
| 1222 | (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA))) { | 1258 | (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA))) { |
| 1223 | printk(KERN_ERR "EXT3-fs: old and new quota " | 1259 | ext3_msg(sb, KERN_ERR, "error: old and new quota " |
| 1224 | "format mixing.\n"); | 1260 | "format mixing."); |
| 1225 | return 0; | 1261 | return 0; |
| 1226 | } | 1262 | } |
| 1227 | 1263 | ||
| 1228 | if (!sbi->s_jquota_fmt) { | 1264 | if (!sbi->s_jquota_fmt) { |
| 1229 | printk(KERN_ERR "EXT3-fs: journaled quota format " | 1265 | ext3_msg(sb, KERN_ERR, "error: journaled quota format " |
| 1230 | "not specified.\n"); | 1266 | "not specified."); |
| 1231 | return 0; | 1267 | return 0; |
| 1232 | } | 1268 | } |
| 1233 | } else { | 1269 | } else { |
| 1234 | if (sbi->s_jquota_fmt) { | 1270 | if (sbi->s_jquota_fmt) { |
| 1235 | printk(KERN_ERR "EXT3-fs: journaled quota format " | 1271 | ext3_msg(sb, KERN_ERR, "error: journaled quota format " |
| 1236 | "specified with no journaling " | 1272 | "specified with no journaling " |
| 1237 | "enabled.\n"); | 1273 | "enabled."); |
| 1238 | return 0; | 1274 | return 0; |
| 1239 | } | 1275 | } |
| 1240 | } | 1276 | } |
| @@ -1249,31 +1285,33 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es, | |||
| 1249 | int res = 0; | 1285 | int res = 0; |
| 1250 | 1286 | ||
| 1251 | if (le32_to_cpu(es->s_rev_level) > EXT3_MAX_SUPP_REV) { | 1287 | if (le32_to_cpu(es->s_rev_level) > EXT3_MAX_SUPP_REV) { |
| 1252 | printk (KERN_ERR "EXT3-fs warning: revision level too high, " | 1288 | ext3_msg(sb, KERN_ERR, |
| 1253 | "forcing read-only mode\n"); | 1289 | "error: revision level too high, " |
| 1290 | "forcing read-only mode"); | ||
| 1254 | res = MS_RDONLY; | 1291 | res = MS_RDONLY; |
| 1255 | } | 1292 | } |
| 1256 | if (read_only) | 1293 | if (read_only) |
| 1257 | return res; | 1294 | return res; |
| 1258 | if (!(sbi->s_mount_state & EXT3_VALID_FS)) | 1295 | if (!(sbi->s_mount_state & EXT3_VALID_FS)) |
| 1259 | printk (KERN_WARNING "EXT3-fs warning: mounting unchecked fs, " | 1296 | ext3_msg(sb, KERN_WARNING, |
| 1260 | "running e2fsck is recommended\n"); | 1297 | "warning: mounting unchecked fs, " |
| 1298 | "running e2fsck is recommended"); | ||
| 1261 | else if ((sbi->s_mount_state & EXT3_ERROR_FS)) | 1299 | else if ((sbi->s_mount_state & EXT3_ERROR_FS)) |
| 1262 | printk (KERN_WARNING | 1300 | ext3_msg(sb, KERN_WARNING, |
| 1263 | "EXT3-fs warning: mounting fs with errors, " | 1301 | "warning: mounting fs with errors, " |
| 1264 | "running e2fsck is recommended\n"); | 1302 | "running e2fsck is recommended"); |
| 1265 | else if ((__s16) le16_to_cpu(es->s_max_mnt_count) >= 0 && | 1303 | else if ((__s16) le16_to_cpu(es->s_max_mnt_count) >= 0 && |
| 1266 | le16_to_cpu(es->s_mnt_count) >= | 1304 | le16_to_cpu(es->s_mnt_count) >= |
| 1267 | (unsigned short) (__s16) le16_to_cpu(es->s_max_mnt_count)) | 1305 | (unsigned short) (__s16) le16_to_cpu(es->s_max_mnt_count)) |
| 1268 | printk (KERN_WARNING | 1306 | ext3_msg(sb, KERN_WARNING, |
| 1269 | "EXT3-fs warning: maximal mount count reached, " | 1307 | "warning: maximal mount count reached, " |
| 1270 | "running e2fsck is recommended\n"); | 1308 | "running e2fsck is recommended"); |
| 1271 | else if (le32_to_cpu(es->s_checkinterval) && | 1309 | else if (le32_to_cpu(es->s_checkinterval) && |
| 1272 | (le32_to_cpu(es->s_lastcheck) + | 1310 | (le32_to_cpu(es->s_lastcheck) + |
| 1273 | le32_to_cpu(es->s_checkinterval) <= get_seconds())) | 1311 | le32_to_cpu(es->s_checkinterval) <= get_seconds())) |
| 1274 | printk (KERN_WARNING | 1312 | ext3_msg(sb, KERN_WARNING, |
| 1275 | "EXT3-fs warning: checktime reached, " | 1313 | "warning: checktime reached, " |
| 1276 | "running e2fsck is recommended\n"); | 1314 | "running e2fsck is recommended"); |
| 1277 | #if 0 | 1315 | #if 0 |
| 1278 | /* @@@ We _will_ want to clear the valid bit if we find | 1316 | /* @@@ We _will_ want to clear the valid bit if we find |
| 1279 | inconsistencies, to force a fsck at reboot. But for | 1317 | inconsistencies, to force a fsck at reboot. But for |
| @@ -1290,22 +1328,20 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es, | |||
| 1290 | 1328 | ||
| 1291 | ext3_commit_super(sb, es, 1); | 1329 | ext3_commit_super(sb, es, 1); |
| 1292 | if (test_opt(sb, DEBUG)) | 1330 | if (test_opt(sb, DEBUG)) |
| 1293 | printk(KERN_INFO "[EXT3 FS bs=%lu, gc=%lu, " | 1331 | ext3_msg(sb, KERN_INFO, "[bs=%lu, gc=%lu, " |
| 1294 | "bpg=%lu, ipg=%lu, mo=%04lx]\n", | 1332 | "bpg=%lu, ipg=%lu, mo=%04lx]", |
| 1295 | sb->s_blocksize, | 1333 | sb->s_blocksize, |
| 1296 | sbi->s_groups_count, | 1334 | sbi->s_groups_count, |
| 1297 | EXT3_BLOCKS_PER_GROUP(sb), | 1335 | EXT3_BLOCKS_PER_GROUP(sb), |
| 1298 | EXT3_INODES_PER_GROUP(sb), | 1336 | EXT3_INODES_PER_GROUP(sb), |
| 1299 | sbi->s_mount_opt); | 1337 | sbi->s_mount_opt); |
| 1300 | 1338 | ||
| 1301 | printk(KERN_INFO "EXT3 FS on %s, ", sb->s_id); | ||
| 1302 | if (EXT3_SB(sb)->s_journal->j_inode == NULL) { | 1339 | if (EXT3_SB(sb)->s_journal->j_inode == NULL) { |
| 1303 | char b[BDEVNAME_SIZE]; | 1340 | char b[BDEVNAME_SIZE]; |
| 1304 | 1341 | ext3_msg(sb, KERN_INFO, "using external journal on %s", | |
| 1305 | printk("external journal on %s\n", | ||
| 1306 | bdevname(EXT3_SB(sb)->s_journal->j_dev, b)); | 1342 | bdevname(EXT3_SB(sb)->s_journal->j_dev, b)); |
| 1307 | } else { | 1343 | } else { |
| 1308 | printk("internal journal\n"); | 1344 | ext3_msg(sb, KERN_INFO, "using internal journal"); |
| 1309 | } | 1345 | } |
| 1310 | return res; | 1346 | return res; |
| 1311 | } | 1347 | } |
| @@ -1399,8 +1435,8 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
| 1399 | } | 1435 | } |
| 1400 | 1436 | ||
| 1401 | if (bdev_read_only(sb->s_bdev)) { | 1437 | if (bdev_read_only(sb->s_bdev)) { |
| 1402 | printk(KERN_ERR "EXT3-fs: write access " | 1438 | ext3_msg(sb, KERN_ERR, "error: write access " |
| 1403 | "unavailable, skipping orphan cleanup.\n"); | 1439 | "unavailable, skipping orphan cleanup."); |
| 1404 | return; | 1440 | return; |
| 1405 | } | 1441 | } |
| 1406 | 1442 | ||
| @@ -1414,8 +1450,7 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
| 1414 | } | 1450 | } |
| 1415 | 1451 | ||
| 1416 | if (s_flags & MS_RDONLY) { | 1452 | if (s_flags & MS_RDONLY) { |
| 1417 | printk(KERN_INFO "EXT3-fs: %s: orphan cleanup on readonly fs\n", | 1453 | ext3_msg(sb, KERN_INFO, "orphan cleanup on readonly fs"); |
| 1418 | sb->s_id); | ||
| 1419 | sb->s_flags &= ~MS_RDONLY; | 1454 | sb->s_flags &= ~MS_RDONLY; |
| 1420 | } | 1455 | } |
| 1421 | #ifdef CONFIG_QUOTA | 1456 | #ifdef CONFIG_QUOTA |
| @@ -1426,9 +1461,9 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
| 1426 | if (EXT3_SB(sb)->s_qf_names[i]) { | 1461 | if (EXT3_SB(sb)->s_qf_names[i]) { |
| 1427 | int ret = ext3_quota_on_mount(sb, i); | 1462 | int ret = ext3_quota_on_mount(sb, i); |
| 1428 | if (ret < 0) | 1463 | if (ret < 0) |
| 1429 | printk(KERN_ERR | 1464 | ext3_msg(sb, KERN_ERR, |
| 1430 | "EXT3-fs: Cannot turn on journaled " | 1465 | "error: cannot turn on journaled " |
| 1431 | "quota: error %d\n", ret); | 1466 | "quota: %d", ret); |
| 1432 | } | 1467 | } |
| 1433 | } | 1468 | } |
| 1434 | #endif | 1469 | #endif |
| @@ -1466,11 +1501,11 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
| 1466 | #define PLURAL(x) (x), ((x)==1) ? "" : "s" | 1501 | #define PLURAL(x) (x), ((x)==1) ? "" : "s" |
| 1467 | 1502 | ||
| 1468 | if (nr_orphans) | 1503 | if (nr_orphans) |
| 1469 | printk(KERN_INFO "EXT3-fs: %s: %d orphan inode%s deleted\n", | 1504 | ext3_msg(sb, KERN_INFO, "%d orphan inode%s deleted", |
| 1470 | sb->s_id, PLURAL(nr_orphans)); | 1505 | PLURAL(nr_orphans)); |
| 1471 | if (nr_truncates) | 1506 | if (nr_truncates) |
| 1472 | printk(KERN_INFO "EXT3-fs: %s: %d truncate%s cleaned up\n", | 1507 | ext3_msg(sb, KERN_INFO, "%d truncate%s cleaned up", |
| 1473 | sb->s_id, PLURAL(nr_truncates)); | 1508 | PLURAL(nr_truncates)); |
| 1474 | #ifdef CONFIG_QUOTA | 1509 | #ifdef CONFIG_QUOTA |
| 1475 | /* Turn quotas off */ | 1510 | /* Turn quotas off */ |
| 1476 | for (i = 0; i < MAXQUOTAS; i++) { | 1511 | for (i = 0; i < MAXQUOTAS; i++) { |
| @@ -1554,7 +1589,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1554 | struct ext3_super_block *es = NULL; | 1589 | struct ext3_super_block *es = NULL; |
| 1555 | struct ext3_sb_info *sbi; | 1590 | struct ext3_sb_info *sbi; |
| 1556 | ext3_fsblk_t block; | 1591 | ext3_fsblk_t block; |
| 1557 | ext3_fsblk_t sb_block = get_sb_block(&data); | 1592 | ext3_fsblk_t sb_block = get_sb_block(&data, sb); |
| 1558 | ext3_fsblk_t logic_sb_block; | 1593 | ext3_fsblk_t logic_sb_block; |
| 1559 | unsigned long offset = 0; | 1594 | unsigned long offset = 0; |
| 1560 | unsigned int journal_inum = 0; | 1595 | unsigned int journal_inum = 0; |
| @@ -1590,7 +1625,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1590 | 1625 | ||
| 1591 | blocksize = sb_min_blocksize(sb, EXT3_MIN_BLOCK_SIZE); | 1626 | blocksize = sb_min_blocksize(sb, EXT3_MIN_BLOCK_SIZE); |
| 1592 | if (!blocksize) { | 1627 | if (!blocksize) { |
| 1593 | printk(KERN_ERR "EXT3-fs: unable to set blocksize\n"); | 1628 | ext3_msg(sb, KERN_ERR, "error: unable to set blocksize"); |
| 1594 | goto out_fail; | 1629 | goto out_fail; |
| 1595 | } | 1630 | } |
| 1596 | 1631 | ||
| @@ -1606,7 +1641,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1606 | } | 1641 | } |
| 1607 | 1642 | ||
| 1608 | if (!(bh = sb_bread(sb, logic_sb_block))) { | 1643 | if (!(bh = sb_bread(sb, logic_sb_block))) { |
| 1609 | printk (KERN_ERR "EXT3-fs: unable to read superblock\n"); | 1644 | ext3_msg(sb, KERN_ERR, "error: unable to read superblock"); |
| 1610 | goto out_fail; | 1645 | goto out_fail; |
| 1611 | } | 1646 | } |
| 1612 | /* | 1647 | /* |
| @@ -1665,9 +1700,9 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1665 | (EXT3_HAS_COMPAT_FEATURE(sb, ~0U) || | 1700 | (EXT3_HAS_COMPAT_FEATURE(sb, ~0U) || |
| 1666 | EXT3_HAS_RO_COMPAT_FEATURE(sb, ~0U) || | 1701 | EXT3_HAS_RO_COMPAT_FEATURE(sb, ~0U) || |
| 1667 | EXT3_HAS_INCOMPAT_FEATURE(sb, ~0U))) | 1702 | EXT3_HAS_INCOMPAT_FEATURE(sb, ~0U))) |
| 1668 | printk(KERN_WARNING | 1703 | ext3_msg(sb, KERN_WARNING, |
| 1669 | "EXT3-fs warning: feature flags set on rev 0 fs, " | 1704 | "warning: feature flags set on rev 0 fs, " |
| 1670 | "running e2fsck is recommended\n"); | 1705 | "running e2fsck is recommended"); |
| 1671 | /* | 1706 | /* |
| 1672 | * Check feature flags regardless of the revision level, since we | 1707 | * Check feature flags regardless of the revision level, since we |
| 1673 | * previously didn't change the revision level when setting the flags, | 1708 | * previously didn't change the revision level when setting the flags, |
| @@ -1675,25 +1710,25 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1675 | */ | 1710 | */ |
| 1676 | features = EXT3_HAS_INCOMPAT_FEATURE(sb, ~EXT3_FEATURE_INCOMPAT_SUPP); | 1711 | features = EXT3_HAS_INCOMPAT_FEATURE(sb, ~EXT3_FEATURE_INCOMPAT_SUPP); |
| 1677 | if (features) { | 1712 | if (features) { |
| 1678 | printk(KERN_ERR "EXT3-fs: %s: couldn't mount because of " | 1713 | ext3_msg(sb, KERN_ERR, |
| 1679 | "unsupported optional features (%x).\n", | 1714 | "error: couldn't mount because of unsupported " |
| 1680 | sb->s_id, le32_to_cpu(features)); | 1715 | "optional features (%x)", le32_to_cpu(features)); |
| 1681 | goto failed_mount; | 1716 | goto failed_mount; |
| 1682 | } | 1717 | } |
| 1683 | features = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP); | 1718 | features = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP); |
| 1684 | if (!(sb->s_flags & MS_RDONLY) && features) { | 1719 | if (!(sb->s_flags & MS_RDONLY) && features) { |
| 1685 | printk(KERN_ERR "EXT3-fs: %s: couldn't mount RDWR because of " | 1720 | ext3_msg(sb, KERN_ERR, |
| 1686 | "unsupported optional features (%x).\n", | 1721 | "error: couldn't mount RDWR because of unsupported " |
| 1687 | sb->s_id, le32_to_cpu(features)); | 1722 | "optional features (%x)", le32_to_cpu(features)); |
| 1688 | goto failed_mount; | 1723 | goto failed_mount; |
| 1689 | } | 1724 | } |
| 1690 | blocksize = BLOCK_SIZE << le32_to_cpu(es->s_log_block_size); | 1725 | blocksize = BLOCK_SIZE << le32_to_cpu(es->s_log_block_size); |
| 1691 | 1726 | ||
| 1692 | if (blocksize < EXT3_MIN_BLOCK_SIZE || | 1727 | if (blocksize < EXT3_MIN_BLOCK_SIZE || |
| 1693 | blocksize > EXT3_MAX_BLOCK_SIZE) { | 1728 | blocksize > EXT3_MAX_BLOCK_SIZE) { |
| 1694 | printk(KERN_ERR | 1729 | ext3_msg(sb, KERN_ERR, |
| 1695 | "EXT3-fs: Unsupported filesystem blocksize %d on %s.\n", | 1730 | "error: couldn't mount because of unsupported " |
| 1696 | blocksize, sb->s_id); | 1731 | "filesystem blocksize %d", blocksize); |
| 1697 | goto failed_mount; | 1732 | goto failed_mount; |
| 1698 | } | 1733 | } |
| 1699 | 1734 | ||
| @@ -1704,30 +1739,31 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1704 | * than the hardware sectorsize for the machine. | 1739 | * than the hardware sectorsize for the machine. |
| 1705 | */ | 1740 | */ |
| 1706 | if (blocksize < hblock) { | 1741 | if (blocksize < hblock) { |
| 1707 | printk(KERN_ERR "EXT3-fs: blocksize %d too small for " | 1742 | ext3_msg(sb, KERN_ERR, |
| 1708 | "device blocksize %d.\n", blocksize, hblock); | 1743 | "error: fsblocksize %d too small for " |
| 1744 | "hardware sectorsize %d", blocksize, hblock); | ||
| 1709 | goto failed_mount; | 1745 | goto failed_mount; |
| 1710 | } | 1746 | } |
| 1711 | 1747 | ||
| 1712 | brelse (bh); | 1748 | brelse (bh); |
| 1713 | if (!sb_set_blocksize(sb, blocksize)) { | 1749 | if (!sb_set_blocksize(sb, blocksize)) { |
| 1714 | printk(KERN_ERR "EXT3-fs: bad blocksize %d.\n", | 1750 | ext3_msg(sb, KERN_ERR, |
| 1715 | blocksize); | 1751 | "error: bad blocksize %d", blocksize); |
| 1716 | goto out_fail; | 1752 | goto out_fail; |
| 1717 | } | 1753 | } |
| 1718 | logic_sb_block = (sb_block * EXT3_MIN_BLOCK_SIZE) / blocksize; | 1754 | logic_sb_block = (sb_block * EXT3_MIN_BLOCK_SIZE) / blocksize; |
| 1719 | offset = (sb_block * EXT3_MIN_BLOCK_SIZE) % blocksize; | 1755 | offset = (sb_block * EXT3_MIN_BLOCK_SIZE) % blocksize; |
| 1720 | bh = sb_bread(sb, logic_sb_block); | 1756 | bh = sb_bread(sb, logic_sb_block); |
| 1721 | if (!bh) { | 1757 | if (!bh) { |
| 1722 | printk(KERN_ERR | 1758 | ext3_msg(sb, KERN_ERR, |
| 1723 | "EXT3-fs: Can't read superblock on 2nd try.\n"); | 1759 | "error: can't read superblock on 2nd try"); |
| 1724 | goto failed_mount; | 1760 | goto failed_mount; |
| 1725 | } | 1761 | } |
| 1726 | es = (struct ext3_super_block *)(((char *)bh->b_data) + offset); | 1762 | es = (struct ext3_super_block *)(((char *)bh->b_data) + offset); |
| 1727 | sbi->s_es = es; | 1763 | sbi->s_es = es; |
| 1728 | if (es->s_magic != cpu_to_le16(EXT3_SUPER_MAGIC)) { | 1764 | if (es->s_magic != cpu_to_le16(EXT3_SUPER_MAGIC)) { |
| 1729 | printk (KERN_ERR | 1765 | ext3_msg(sb, KERN_ERR, |
| 1730 | "EXT3-fs: Magic mismatch, very weird !\n"); | 1766 | "error: magic mismatch"); |
| 1731 | goto failed_mount; | 1767 | goto failed_mount; |
| 1732 | } | 1768 | } |
| 1733 | } | 1769 | } |
| @@ -1743,8 +1779,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1743 | if ((sbi->s_inode_size < EXT3_GOOD_OLD_INODE_SIZE) || | 1779 | if ((sbi->s_inode_size < EXT3_GOOD_OLD_INODE_SIZE) || |
| 1744 | (!is_power_of_2(sbi->s_inode_size)) || | 1780 | (!is_power_of_2(sbi->s_inode_size)) || |
| 1745 | (sbi->s_inode_size > blocksize)) { | 1781 | (sbi->s_inode_size > blocksize)) { |
| 1746 | printk (KERN_ERR | 1782 | ext3_msg(sb, KERN_ERR, |
| 1747 | "EXT3-fs: unsupported inode size: %d\n", | 1783 | "error: unsupported inode size: %d", |
| 1748 | sbi->s_inode_size); | 1784 | sbi->s_inode_size); |
| 1749 | goto failed_mount; | 1785 | goto failed_mount; |
| 1750 | } | 1786 | } |
| @@ -1752,8 +1788,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1752 | sbi->s_frag_size = EXT3_MIN_FRAG_SIZE << | 1788 | sbi->s_frag_size = EXT3_MIN_FRAG_SIZE << |
| 1753 | le32_to_cpu(es->s_log_frag_size); | 1789 | le32_to_cpu(es->s_log_frag_size); |
| 1754 | if (blocksize != sbi->s_frag_size) { | 1790 | if (blocksize != sbi->s_frag_size) { |
| 1755 | printk(KERN_ERR | 1791 | ext3_msg(sb, KERN_ERR, |
| 1756 | "EXT3-fs: fragsize %lu != blocksize %u (unsupported)\n", | 1792 | "error: fragsize %lu != blocksize %u (unsupported)", |
| 1757 | sbi->s_frag_size, blocksize); | 1793 | sbi->s_frag_size, blocksize); |
| 1758 | goto failed_mount; | 1794 | goto failed_mount; |
| 1759 | } | 1795 | } |
| @@ -1789,31 +1825,31 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1789 | } | 1825 | } |
| 1790 | 1826 | ||
| 1791 | if (sbi->s_blocks_per_group > blocksize * 8) { | 1827 | if (sbi->s_blocks_per_group > blocksize * 8) { |
| 1792 | printk (KERN_ERR | 1828 | ext3_msg(sb, KERN_ERR, |
| 1793 | "EXT3-fs: #blocks per group too big: %lu\n", | 1829 | "#blocks per group too big: %lu", |
| 1794 | sbi->s_blocks_per_group); | 1830 | sbi->s_blocks_per_group); |
| 1795 | goto failed_mount; | 1831 | goto failed_mount; |
| 1796 | } | 1832 | } |
| 1797 | if (sbi->s_frags_per_group > blocksize * 8) { | 1833 | if (sbi->s_frags_per_group > blocksize * 8) { |
| 1798 | printk (KERN_ERR | 1834 | ext3_msg(sb, KERN_ERR, |
| 1799 | "EXT3-fs: #fragments per group too big: %lu\n", | 1835 | "error: #fragments per group too big: %lu", |
| 1800 | sbi->s_frags_per_group); | 1836 | sbi->s_frags_per_group); |
| 1801 | goto failed_mount; | 1837 | goto failed_mount; |
| 1802 | } | 1838 | } |
| 1803 | if (sbi->s_inodes_per_group > blocksize * 8) { | 1839 | if (sbi->s_inodes_per_group > blocksize * 8) { |
| 1804 | printk (KERN_ERR | 1840 | ext3_msg(sb, KERN_ERR, |
| 1805 | "EXT3-fs: #inodes per group too big: %lu\n", | 1841 | "error: #inodes per group too big: %lu", |
| 1806 | sbi->s_inodes_per_group); | 1842 | sbi->s_inodes_per_group); |
| 1807 | goto failed_mount; | 1843 | goto failed_mount; |
| 1808 | } | 1844 | } |
| 1809 | 1845 | ||
| 1810 | if (le32_to_cpu(es->s_blocks_count) > | 1846 | if (le32_to_cpu(es->s_blocks_count) > |
| 1811 | (sector_t)(~0ULL) >> (sb->s_blocksize_bits - 9)) { | 1847 | (sector_t)(~0ULL) >> (sb->s_blocksize_bits - 9)) { |
| 1812 | printk(KERN_ERR "EXT3-fs: filesystem on %s:" | 1848 | ext3_msg(sb, KERN_ERR, |
| 1813 | " too large to mount safely\n", sb->s_id); | 1849 | "error: filesystem is too large to mount safely"); |
| 1814 | if (sizeof(sector_t) < 8) | 1850 | if (sizeof(sector_t) < 8) |
| 1815 | printk(KERN_WARNING "EXT3-fs: CONFIG_LBDAF not " | 1851 | ext3_msg(sb, KERN_ERR, |
| 1816 | "enabled\n"); | 1852 | "error: CONFIG_LBDAF not enabled"); |
| 1817 | goto failed_mount; | 1853 | goto failed_mount; |
| 1818 | } | 1854 | } |
| 1819 | 1855 | ||
| @@ -1827,7 +1863,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1827 | sbi->s_group_desc = kmalloc(db_count * sizeof (struct buffer_head *), | 1863 | sbi->s_group_desc = kmalloc(db_count * sizeof (struct buffer_head *), |
| 1828 | GFP_KERNEL); | 1864 | GFP_KERNEL); |
| 1829 | if (sbi->s_group_desc == NULL) { | 1865 | if (sbi->s_group_desc == NULL) { |
| 1830 | printk (KERN_ERR "EXT3-fs: not enough memory\n"); | 1866 | ext3_msg(sb, KERN_ERR, |
| 1867 | "error: not enough memory"); | ||
| 1831 | goto failed_mount; | 1868 | goto failed_mount; |
| 1832 | } | 1869 | } |
| 1833 | 1870 | ||
| @@ -1837,14 +1874,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1837 | block = descriptor_loc(sb, logic_sb_block, i); | 1874 | block = descriptor_loc(sb, logic_sb_block, i); |
| 1838 | sbi->s_group_desc[i] = sb_bread(sb, block); | 1875 | sbi->s_group_desc[i] = sb_bread(sb, block); |
| 1839 | if (!sbi->s_group_desc[i]) { | 1876 | if (!sbi->s_group_desc[i]) { |
| 1840 | printk (KERN_ERR "EXT3-fs: " | 1877 | ext3_msg(sb, KERN_ERR, |
| 1841 | "can't read group descriptor %d\n", i); | 1878 | "error: can't read group descriptor %d", i); |
| 1842 | db_count = i; | 1879 | db_count = i; |
| 1843 | goto failed_mount2; | 1880 | goto failed_mount2; |
| 1844 | } | 1881 | } |
| 1845 | } | 1882 | } |
| 1846 | if (!ext3_check_descriptors (sb)) { | 1883 | if (!ext3_check_descriptors (sb)) { |
| 1847 | printk(KERN_ERR "EXT3-fs: group descriptors corrupted!\n"); | 1884 | ext3_msg(sb, KERN_ERR, |
| 1885 | "error: group descriptors corrupted"); | ||
| 1848 | goto failed_mount2; | 1886 | goto failed_mount2; |
| 1849 | } | 1887 | } |
| 1850 | sbi->s_gdb_count = db_count; | 1888 | sbi->s_gdb_count = db_count; |
| @@ -1862,7 +1900,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1862 | ext3_count_dirs(sb)); | 1900 | ext3_count_dirs(sb)); |
| 1863 | } | 1901 | } |
| 1864 | if (err) { | 1902 | if (err) { |
| 1865 | printk(KERN_ERR "EXT3-fs: insufficient memory\n"); | 1903 | ext3_msg(sb, KERN_ERR, "error: insufficient memory"); |
| 1866 | goto failed_mount3; | 1904 | goto failed_mount3; |
| 1867 | } | 1905 | } |
| 1868 | 1906 | ||
| @@ -1910,9 +1948,9 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1910 | goto failed_mount3; | 1948 | goto failed_mount3; |
| 1911 | } else { | 1949 | } else { |
| 1912 | if (!silent) | 1950 | if (!silent) |
| 1913 | printk (KERN_ERR | 1951 | ext3_msg(sb, KERN_ERR, |
| 1914 | "ext3: No journal on filesystem on %s\n", | 1952 | "error: no journal found. " |
| 1915 | sb->s_id); | 1953 | "mounting ext3 over ext2?"); |
| 1916 | goto failed_mount3; | 1954 | goto failed_mount3; |
| 1917 | } | 1955 | } |
| 1918 | 1956 | ||
| @@ -1934,8 +1972,9 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1934 | case EXT3_MOUNT_WRITEBACK_DATA: | 1972 | case EXT3_MOUNT_WRITEBACK_DATA: |
| 1935 | if (!journal_check_available_features | 1973 | if (!journal_check_available_features |
| 1936 | (sbi->s_journal, 0, 0, JFS_FEATURE_INCOMPAT_REVOKE)) { | 1974 | (sbi->s_journal, 0, 0, JFS_FEATURE_INCOMPAT_REVOKE)) { |
| 1937 | printk(KERN_ERR "EXT3-fs: Journal does not support " | 1975 | ext3_msg(sb, KERN_ERR, |
| 1938 | "requested data journaling mode\n"); | 1976 | "error: journal does not support " |
| 1977 | "requested data journaling mode"); | ||
| 1939 | goto failed_mount4; | 1978 | goto failed_mount4; |
| 1940 | } | 1979 | } |
| 1941 | default: | 1980 | default: |
| @@ -1944,8 +1983,9 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1944 | 1983 | ||
| 1945 | if (test_opt(sb, NOBH)) { | 1984 | if (test_opt(sb, NOBH)) { |
| 1946 | if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { | 1985 | if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { |
| 1947 | printk(KERN_WARNING "EXT3-fs: Ignoring nobh option - " | 1986 | ext3_msg(sb, KERN_WARNING, |
| 1948 | "its supported only with writeback mode\n"); | 1987 | "warning: ignoring nobh option - " |
| 1988 | "it is supported only with writeback mode"); | ||
| 1949 | clear_opt(sbi->s_mount_opt, NOBH); | 1989 | clear_opt(sbi->s_mount_opt, NOBH); |
| 1950 | } | 1990 | } |
| 1951 | } | 1991 | } |
| @@ -1956,18 +1996,18 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1956 | 1996 | ||
| 1957 | root = ext3_iget(sb, EXT3_ROOT_INO); | 1997 | root = ext3_iget(sb, EXT3_ROOT_INO); |
| 1958 | if (IS_ERR(root)) { | 1998 | if (IS_ERR(root)) { |
| 1959 | printk(KERN_ERR "EXT3-fs: get root inode failed\n"); | 1999 | ext3_msg(sb, KERN_ERR, "error: get root inode failed"); |
| 1960 | ret = PTR_ERR(root); | 2000 | ret = PTR_ERR(root); |
| 1961 | goto failed_mount4; | 2001 | goto failed_mount4; |
| 1962 | } | 2002 | } |
| 1963 | if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) { | 2003 | if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) { |
| 1964 | iput(root); | 2004 | iput(root); |
| 1965 | printk(KERN_ERR "EXT3-fs: corrupt root inode, run e2fsck\n"); | 2005 | ext3_msg(sb, KERN_ERR, "error: corrupt root inode, run e2fsck"); |
| 1966 | goto failed_mount4; | 2006 | goto failed_mount4; |
| 1967 | } | 2007 | } |
| 1968 | sb->s_root = d_alloc_root(root); | 2008 | sb->s_root = d_alloc_root(root); |
| 1969 | if (!sb->s_root) { | 2009 | if (!sb->s_root) { |
| 1970 | printk(KERN_ERR "EXT3-fs: get root dentry failed\n"); | 2010 | ext3_msg(sb, KERN_ERR, "error: get root dentry failed"); |
| 1971 | iput(root); | 2011 | iput(root); |
| 1972 | ret = -ENOMEM; | 2012 | ret = -ENOMEM; |
| 1973 | goto failed_mount4; | 2013 | goto failed_mount4; |
| @@ -1986,9 +2026,9 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1986 | ext3_orphan_cleanup(sb, es); | 2026 | ext3_orphan_cleanup(sb, es); |
| 1987 | EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS; | 2027 | EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS; |
| 1988 | if (needs_recovery) | 2028 | if (needs_recovery) |
| 1989 | printk (KERN_INFO "EXT3-fs: recovery complete.\n"); | 2029 | ext3_msg(sb, KERN_INFO, "recovery complete"); |
| 1990 | ext3_mark_recovery_complete(sb, es); | 2030 | ext3_mark_recovery_complete(sb, es); |
| 1991 | printk (KERN_INFO "EXT3-fs: mounted filesystem with %s data mode.\n", | 2031 | ext3_msg(sb, KERN_INFO, "mounted filesystem with %s data mode", |
| 1992 | test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA ? "journal": | 2032 | test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA ? "journal": |
| 1993 | test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_ORDERED_DATA ? "ordered": | 2033 | test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_ORDERED_DATA ? "ordered": |
| 1994 | "writeback"); | 2034 | "writeback"); |
| @@ -1998,7 +2038,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
| 1998 | 2038 | ||
| 1999 | cantfind_ext3: | 2039 | cantfind_ext3: |
| 2000 | if (!silent) | 2040 | if (!silent) |
| 2001 | printk(KERN_ERR "VFS: Can't find ext3 filesystem on dev %s.\n", | 2041 | ext3_msg(sb, KERN_INFO, |
| 2042 | "error: can't find ext3 filesystem on dev %s.", | ||
| 2002 | sb->s_id); | 2043 | sb->s_id); |
| 2003 | goto failed_mount; | 2044 | goto failed_mount; |
| 2004 | 2045 | ||
| @@ -2066,27 +2107,27 @@ static journal_t *ext3_get_journal(struct super_block *sb, | |||
| 2066 | 2107 | ||
| 2067 | journal_inode = ext3_iget(sb, journal_inum); | 2108 | journal_inode = ext3_iget(sb, journal_inum); |
| 2068 | if (IS_ERR(journal_inode)) { | 2109 | if (IS_ERR(journal_inode)) { |
| 2069 | printk(KERN_ERR "EXT3-fs: no journal found.\n"); | 2110 | ext3_msg(sb, KERN_ERR, "error: no journal found"); |
| 2070 | return NULL; | 2111 | return NULL; |
| 2071 | } | 2112 | } |
| 2072 | if (!journal_inode->i_nlink) { | 2113 | if (!journal_inode->i_nlink) { |
| 2073 | make_bad_inode(journal_inode); | 2114 | make_bad_inode(journal_inode); |
| 2074 | iput(journal_inode); | 2115 | iput(journal_inode); |
| 2075 | printk(KERN_ERR "EXT3-fs: journal inode is deleted.\n"); | 2116 | ext3_msg(sb, KERN_ERR, "error: journal inode is deleted"); |
| 2076 | return NULL; | 2117 | return NULL; |
| 2077 | } | 2118 | } |
| 2078 | 2119 | ||
| 2079 | jbd_debug(2, "Journal inode found at %p: %Ld bytes\n", | 2120 | jbd_debug(2, "Journal inode found at %p: %Ld bytes\n", |
| 2080 | journal_inode, journal_inode->i_size); | 2121 | journal_inode, journal_inode->i_size); |
| 2081 | if (!S_ISREG(journal_inode->i_mode)) { | 2122 | if (!S_ISREG(journal_inode->i_mode)) { |
| 2082 | printk(KERN_ERR "EXT3-fs: invalid journal inode.\n"); | 2123 | ext3_msg(sb, KERN_ERR, "error: invalid journal inode"); |
| 2083 | iput(journal_inode); | 2124 | iput(journal_inode); |
| 2084 | return NULL; | 2125 | return NULL; |
| 2085 | } | 2126 | } |
| 2086 | 2127 | ||
| 2087 | journal = journal_init_inode(journal_inode); | 2128 | journal = journal_init_inode(journal_inode); |
| 2088 | if (!journal) { | 2129 | if (!journal) { |
| 2089 | printk(KERN_ERR "EXT3-fs: Could not load journal inode\n"); | 2130 | ext3_msg(sb, KERN_ERR, "error: could not load journal inode"); |
| 2090 | iput(journal_inode); | 2131 | iput(journal_inode); |
| 2091 | return NULL; | 2132 | return NULL; |
| 2092 | } | 2133 | } |
| @@ -2108,13 +2149,13 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, | |||
| 2108 | struct ext3_super_block * es; | 2149 | struct ext3_super_block * es; |
| 2109 | struct block_device *bdev; | 2150 | struct block_device *bdev; |
| 2110 | 2151 | ||
| 2111 | bdev = ext3_blkdev_get(j_dev); | 2152 | bdev = ext3_blkdev_get(j_dev, sb); |
| 2112 | if (bdev == NULL) | 2153 | if (bdev == NULL) |
| 2113 | return NULL; | 2154 | return NULL; |
| 2114 | 2155 | ||
| 2115 | if (bd_claim(bdev, sb)) { | 2156 | if (bd_claim(bdev, sb)) { |
| 2116 | printk(KERN_ERR | 2157 | ext3_msg(sb, KERN_ERR, |
| 2117 | "EXT3: failed to claim external journal device.\n"); | 2158 | "error: failed to claim external journal device"); |
| 2118 | blkdev_put(bdev, FMODE_READ|FMODE_WRITE); | 2159 | blkdev_put(bdev, FMODE_READ|FMODE_WRITE); |
| 2119 | return NULL; | 2160 | return NULL; |
| 2120 | } | 2161 | } |
| @@ -2122,8 +2163,8 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, | |||
| 2122 | blocksize = sb->s_blocksize; | 2163 | blocksize = sb->s_blocksize; |
| 2123 | hblock = bdev_logical_block_size(bdev); | 2164 | hblock = bdev_logical_block_size(bdev); |
| 2124 | if (blocksize < hblock) { | 2165 | if (blocksize < hblock) { |
| 2125 | printk(KERN_ERR | 2166 | ext3_msg(sb, KERN_ERR, |
| 2126 | "EXT3-fs: blocksize too small for journal device.\n"); | 2167 | "error: blocksize too small for journal device"); |
| 2127 | goto out_bdev; | 2168 | goto out_bdev; |
| 2128 | } | 2169 | } |
| 2129 | 2170 | ||
| @@ -2131,8 +2172,8 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, | |||
| 2131 | offset = EXT3_MIN_BLOCK_SIZE % blocksize; | 2172 | offset = EXT3_MIN_BLOCK_SIZE % blocksize; |
| 2132 | set_blocksize(bdev, blocksize); | 2173 | set_blocksize(bdev, blocksize); |
| 2133 | if (!(bh = __bread(bdev, sb_block, blocksize))) { | 2174 | if (!(bh = __bread(bdev, sb_block, blocksize))) { |
| 2134 | printk(KERN_ERR "EXT3-fs: couldn't read superblock of " | 2175 | ext3_msg(sb, KERN_ERR, "error: couldn't read superblock of " |
| 2135 | "external journal\n"); | 2176 | "external journal"); |
| 2136 | goto out_bdev; | 2177 | goto out_bdev; |
| 2137 | } | 2178 | } |
| 2138 | 2179 | ||
| @@ -2140,14 +2181,14 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, | |||
| 2140 | if ((le16_to_cpu(es->s_magic) != EXT3_SUPER_MAGIC) || | 2181 | if ((le16_to_cpu(es->s_magic) != EXT3_SUPER_MAGIC) || |
| 2141 | !(le32_to_cpu(es->s_feature_incompat) & | 2182 | !(le32_to_cpu(es->s_feature_incompat) & |
| 2142 | EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) { | 2183 | EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) { |
| 2143 | printk(KERN_ERR "EXT3-fs: external journal has " | 2184 | ext3_msg(sb, KERN_ERR, "error: external journal has " |
| 2144 | "bad superblock\n"); | 2185 | "bad superblock"); |
| 2145 | brelse(bh); | 2186 | brelse(bh); |
| 2146 | goto out_bdev; | 2187 | goto out_bdev; |
| 2147 | } | 2188 | } |
| 2148 | 2189 | ||
| 2149 | if (memcmp(EXT3_SB(sb)->s_es->s_journal_uuid, es->s_uuid, 16)) { | 2190 | if (memcmp(EXT3_SB(sb)->s_es->s_journal_uuid, es->s_uuid, 16)) { |
| 2150 | printk(KERN_ERR "EXT3-fs: journal UUID does not match\n"); | 2191 | ext3_msg(sb, KERN_ERR, "error: journal UUID does not match"); |
| 2151 | brelse(bh); | 2192 | brelse(bh); |
| 2152 | goto out_bdev; | 2193 | goto out_bdev; |
| 2153 | } | 2194 | } |
| @@ -2159,19 +2200,21 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb, | |||
| 2159 | journal = journal_init_dev(bdev, sb->s_bdev, | 2200 | journal = journal_init_dev(bdev, sb->s_bdev, |
| 2160 | start, len, blocksize); | 2201 | start, len, blocksize); |
| 2161 | if (!journal) { | 2202 | if (!journal) { |
| 2162 | printk(KERN_ERR "EXT3-fs: failed to create device journal\n"); | 2203 | ext3_msg(sb, KERN_ERR, |
| 2204 | "error: failed to create device journal"); | ||
| 2163 | goto out_bdev; | 2205 | goto out_bdev; |
| 2164 | } | 2206 | } |
| 2165 | journal->j_private = sb; | 2207 | journal->j_private = sb; |
| 2166 | ll_rw_block(READ, 1, &journal->j_sb_buffer); | 2208 | ll_rw_block(READ, 1, &journal->j_sb_buffer); |
| 2167 | wait_on_buffer(journal->j_sb_buffer); | 2209 | wait_on_buffer(journal->j_sb_buffer); |
| 2168 | if (!buffer_uptodate(journal->j_sb_buffer)) { | 2210 | if (!buffer_uptodate(journal->j_sb_buffer)) { |
| 2169 | printk(KERN_ERR "EXT3-fs: I/O error on journal device\n"); | 2211 | ext3_msg(sb, KERN_ERR, "I/O error on journal device"); |
| 2170 | goto out_journal; | 2212 | goto out_journal; |
| 2171 | } | 2213 | } |
| 2172 | if (be32_to_cpu(journal->j_superblock->s_nr_users) != 1) { | 2214 | if (be32_to_cpu(journal->j_superblock->s_nr_users) != 1) { |
| 2173 | printk(KERN_ERR "EXT3-fs: External journal has more than one " | 2215 | ext3_msg(sb, KERN_ERR, |
| 2174 | "user (unsupported) - %d\n", | 2216 | "error: external journal has more than one " |
| 2217 | "user (unsupported) - %d", | ||
| 2175 | be32_to_cpu(journal->j_superblock->s_nr_users)); | 2218 | be32_to_cpu(journal->j_superblock->s_nr_users)); |
| 2176 | goto out_journal; | 2219 | goto out_journal; |
| 2177 | } | 2220 | } |
| @@ -2197,8 +2240,8 @@ static int ext3_load_journal(struct super_block *sb, | |||
| 2197 | 2240 | ||
| 2198 | if (journal_devnum && | 2241 | if (journal_devnum && |
| 2199 | journal_devnum != le32_to_cpu(es->s_journal_dev)) { | 2242 | journal_devnum != le32_to_cpu(es->s_journal_dev)) { |
| 2200 | printk(KERN_INFO "EXT3-fs: external journal device major/minor " | 2243 | ext3_msg(sb, KERN_INFO, "external journal device major/minor " |
| 2201 | "numbers have changed\n"); | 2244 | "numbers have changed"); |
| 2202 | journal_dev = new_decode_dev(journal_devnum); | 2245 | journal_dev = new_decode_dev(journal_devnum); |
| 2203 | } else | 2246 | } else |
| 2204 | journal_dev = new_decode_dev(le32_to_cpu(es->s_journal_dev)); | 2247 | journal_dev = new_decode_dev(le32_to_cpu(es->s_journal_dev)); |
| @@ -2213,21 +2256,21 @@ static int ext3_load_journal(struct super_block *sb, | |||
| 2213 | 2256 | ||
| 2214 | if (EXT3_HAS_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER)) { | 2257 | if (EXT3_HAS_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER)) { |
| 2215 | if (sb->s_flags & MS_RDONLY) { | 2258 | if (sb->s_flags & MS_RDONLY) { |
| 2216 | printk(KERN_INFO "EXT3-fs: INFO: recovery " | 2259 | ext3_msg(sb, KERN_INFO, |
| 2217 | "required on readonly filesystem.\n"); | 2260 | "recovery required on readonly filesystem"); |
| 2218 | if (really_read_only) { | 2261 | if (really_read_only) { |
| 2219 | printk(KERN_ERR "EXT3-fs: write access " | 2262 | ext3_msg(sb, KERN_ERR, "error: write access " |
| 2220 | "unavailable, cannot proceed.\n"); | 2263 | "unavailable, cannot proceed"); |
| 2221 | return -EROFS; | 2264 | return -EROFS; |
| 2222 | } | 2265 | } |
| 2223 | printk (KERN_INFO "EXT3-fs: write access will " | 2266 | ext3_msg(sb, KERN_INFO, |
| 2224 | "be enabled during recovery.\n"); | 2267 | "write access will be enabled during recovery"); |
| 2225 | } | 2268 | } |
| 2226 | } | 2269 | } |
| 2227 | 2270 | ||
| 2228 | if (journal_inum && journal_dev) { | 2271 | if (journal_inum && journal_dev) { |
| 2229 | printk(KERN_ERR "EXT3-fs: filesystem has both journal " | 2272 | ext3_msg(sb, KERN_ERR, "error: filesystem has both journal " |
| 2230 | "and inode journals!\n"); | 2273 | "and inode journals"); |
| 2231 | return -EINVAL; | 2274 | return -EINVAL; |
| 2232 | } | 2275 | } |
| 2233 | 2276 | ||
| @@ -2242,7 +2285,7 @@ static int ext3_load_journal(struct super_block *sb, | |||
| 2242 | if (!really_read_only && test_opt(sb, UPDATE_JOURNAL)) { | 2285 | if (!really_read_only && test_opt(sb, UPDATE_JOURNAL)) { |
| 2243 | err = journal_update_format(journal); | 2286 | err = journal_update_format(journal); |
| 2244 | if (err) { | 2287 | if (err) { |
| 2245 | printk(KERN_ERR "EXT3-fs: error updating journal.\n"); | 2288 | ext3_msg(sb, KERN_ERR, "error updating journal"); |
| 2246 | journal_destroy(journal); | 2289 | journal_destroy(journal); |
| 2247 | return err; | 2290 | return err; |
| 2248 | } | 2291 | } |
| @@ -2254,7 +2297,7 @@ static int ext3_load_journal(struct super_block *sb, | |||
| 2254 | err = journal_load(journal); | 2297 | err = journal_load(journal); |
| 2255 | 2298 | ||
| 2256 | if (err) { | 2299 | if (err) { |
| 2257 | printk(KERN_ERR "EXT3-fs: error loading journal.\n"); | 2300 | ext3_msg(sb, KERN_ERR, "error loading journal"); |
| 2258 | journal_destroy(journal); | 2301 | journal_destroy(journal); |
| 2259 | return err; | 2302 | return err; |
| 2260 | } | 2303 | } |
| @@ -2273,16 +2316,17 @@ static int ext3_load_journal(struct super_block *sb, | |||
| 2273 | return 0; | 2316 | return 0; |
| 2274 | } | 2317 | } |
| 2275 | 2318 | ||
| 2276 | static int ext3_create_journal(struct super_block * sb, | 2319 | static int ext3_create_journal(struct super_block *sb, |
| 2277 | struct ext3_super_block * es, | 2320 | struct ext3_super_block *es, |
| 2278 | unsigned int journal_inum) | 2321 | unsigned int journal_inum) |
| 2279 | { | 2322 | { |
| 2280 | journal_t *journal; | 2323 | journal_t *journal; |
| 2281 | int err; | 2324 | int err; |
| 2282 | 2325 | ||
| 2283 | if (sb->s_flags & MS_RDONLY) { | 2326 | if (sb->s_flags & MS_RDONLY) { |
| 2284 | printk(KERN_ERR "EXT3-fs: readonly filesystem when trying to " | 2327 | ext3_msg(sb, KERN_ERR, |
| 2285 | "create journal.\n"); | 2328 | "error: readonly filesystem when trying to " |
| 2329 | "create journal"); | ||
| 2286 | return -EROFS; | 2330 | return -EROFS; |
| 2287 | } | 2331 | } |
| 2288 | 2332 | ||
| @@ -2290,12 +2334,12 @@ static int ext3_create_journal(struct super_block * sb, | |||
| 2290 | if (!journal) | 2334 | if (!journal) |
| 2291 | return -EINVAL; | 2335 | return -EINVAL; |
| 2292 | 2336 | ||
| 2293 | printk(KERN_INFO "EXT3-fs: creating new journal on inode %u\n", | 2337 | ext3_msg(sb, KERN_INFO, "creating new journal on inode %u", |
| 2294 | journal_inum); | 2338 | journal_inum); |
| 2295 | 2339 | ||
| 2296 | err = journal_create(journal); | 2340 | err = journal_create(journal); |
| 2297 | if (err) { | 2341 | if (err) { |
| 2298 | printk(KERN_ERR "EXT3-fs: error creating journal.\n"); | 2342 | ext3_msg(sb, KERN_ERR, "error creating journal"); |
| 2299 | journal_destroy(journal); | 2343 | journal_destroy(journal); |
| 2300 | return -EIO; | 2344 | return -EIO; |
| 2301 | } | 2345 | } |
| @@ -2376,8 +2420,8 @@ out: | |||
| 2376 | * has recorded an error from a previous lifetime, move that error to the | 2420 | * has recorded an error from a previous lifetime, move that error to the |
| 2377 | * main filesystem now. | 2421 | * main filesystem now. |
| 2378 | */ | 2422 | */ |
| 2379 | static void ext3_clear_journal_err(struct super_block * sb, | 2423 | static void ext3_clear_journal_err(struct super_block *sb, |
| 2380 | struct ext3_super_block * es) | 2424 | struct ext3_super_block *es) |
| 2381 | { | 2425 | { |
| 2382 | journal_t *journal; | 2426 | journal_t *journal; |
| 2383 | int j_errno; | 2427 | int j_errno; |
| @@ -2568,10 +2612,10 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
| 2568 | __le32 ret; | 2612 | __le32 ret; |
| 2569 | if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, | 2613 | if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, |
| 2570 | ~EXT3_FEATURE_RO_COMPAT_SUPP))) { | 2614 | ~EXT3_FEATURE_RO_COMPAT_SUPP))) { |
| 2571 | printk(KERN_WARNING "EXT3-fs: %s: couldn't " | 2615 | ext3_msg(sb, KERN_WARNING, |
| 2572 | "remount RDWR because of unsupported " | 2616 | "warning: couldn't remount RDWR " |
| 2573 | "optional features (%x).\n", | 2617 | "because of unsupported optional " |
| 2574 | sb->s_id, le32_to_cpu(ret)); | 2618 | "features (%x)", le32_to_cpu(ret)); |
| 2575 | err = -EROFS; | 2619 | err = -EROFS; |
| 2576 | goto restore_opts; | 2620 | goto restore_opts; |
| 2577 | } | 2621 | } |
| @@ -2582,11 +2626,10 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
| 2582 | * require a full umount/remount for now. | 2626 | * require a full umount/remount for now. |
| 2583 | */ | 2627 | */ |
| 2584 | if (es->s_last_orphan) { | 2628 | if (es->s_last_orphan) { |
| 2585 | printk(KERN_WARNING "EXT3-fs: %s: couldn't " | 2629 | ext3_msg(sb, KERN_WARNING, "warning: couldn't " |
| 2586 | "remount RDWR because of unprocessed " | 2630 | "remount RDWR because of unprocessed " |
| 2587 | "orphan inode list. Please " | 2631 | "orphan inode list. Please " |
| 2588 | "umount/remount instead.\n", | 2632 | "umount/remount instead."); |
| 2589 | sb->s_id); | ||
| 2590 | err = -EINVAL; | 2633 | err = -EINVAL; |
| 2591 | goto restore_opts; | 2634 | goto restore_opts; |
| 2592 | } | 2635 | } |
| @@ -2686,13 +2729,11 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf) | |||
| 2686 | buf->f_bsize = sb->s_blocksize; | 2729 | buf->f_bsize = sb->s_blocksize; |
| 2687 | buf->f_blocks = le32_to_cpu(es->s_blocks_count) - sbi->s_overhead_last; | 2730 | buf->f_blocks = le32_to_cpu(es->s_blocks_count) - sbi->s_overhead_last; |
| 2688 | buf->f_bfree = percpu_counter_sum_positive(&sbi->s_freeblocks_counter); | 2731 | buf->f_bfree = percpu_counter_sum_positive(&sbi->s_freeblocks_counter); |
| 2689 | es->s_free_blocks_count = cpu_to_le32(buf->f_bfree); | ||
| 2690 | buf->f_bavail = buf->f_bfree - le32_to_cpu(es->s_r_blocks_count); | 2732 | buf->f_bavail = buf->f_bfree - le32_to_cpu(es->s_r_blocks_count); |
| 2691 | if (buf->f_bfree < le32_to_cpu(es->s_r_blocks_count)) | 2733 | if (buf->f_bfree < le32_to_cpu(es->s_r_blocks_count)) |
| 2692 | buf->f_bavail = 0; | 2734 | buf->f_bavail = 0; |
| 2693 | buf->f_files = le32_to_cpu(es->s_inodes_count); | 2735 | buf->f_files = le32_to_cpu(es->s_inodes_count); |
| 2694 | buf->f_ffree = percpu_counter_sum_positive(&sbi->s_freeinodes_counter); | 2736 | buf->f_ffree = percpu_counter_sum_positive(&sbi->s_freeinodes_counter); |
| 2695 | es->s_free_inodes_count = cpu_to_le32(buf->f_ffree); | ||
| 2696 | buf->f_namelen = EXT3_NAME_LEN; | 2737 | buf->f_namelen = EXT3_NAME_LEN; |
| 2697 | fsid = le64_to_cpup((void *)es->s_uuid) ^ | 2738 | fsid = le64_to_cpup((void *)es->s_uuid) ^ |
| 2698 | le64_to_cpup((void *)es->s_uuid + sizeof(u64)); | 2739 | le64_to_cpup((void *)es->s_uuid + sizeof(u64)); |
| @@ -2837,9 +2878,9 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id, | |||
| 2837 | if (EXT3_SB(sb)->s_qf_names[type]) { | 2878 | if (EXT3_SB(sb)->s_qf_names[type]) { |
| 2838 | /* Quotafile not of fs root? */ | 2879 | /* Quotafile not of fs root? */ |
| 2839 | if (path.dentry->d_parent != sb->s_root) | 2880 | if (path.dentry->d_parent != sb->s_root) |
| 2840 | printk(KERN_WARNING | 2881 | ext3_msg(sb, KERN_WARNING, |
| 2841 | "EXT3-fs: Quota file not on filesystem root. " | 2882 | "warning: Quota file not on filesystem root. " |
| 2842 | "Journaled quota will not work.\n"); | 2883 | "Journaled quota will not work."); |
| 2843 | } | 2884 | } |
| 2844 | 2885 | ||
| 2845 | /* | 2886 | /* |
| @@ -2921,8 +2962,9 @@ static ssize_t ext3_quota_write(struct super_block *sb, int type, | |||
| 2921 | handle_t *handle = journal_current_handle(); | 2962 | handle_t *handle = journal_current_handle(); |
| 2922 | 2963 | ||
| 2923 | if (!handle) { | 2964 | if (!handle) { |
| 2924 | printk(KERN_WARNING "EXT3-fs: Quota write (off=%Lu, len=%Lu)" | 2965 | ext3_msg(sb, KERN_WARNING, |
| 2925 | " cancelled because transaction is not started.\n", | 2966 | "warning: quota write (off=%llu, len=%llu)" |
| 2967 | " cancelled because transaction is not started.", | ||
| 2926 | (unsigned long long)off, (unsigned long long)len); | 2968 | (unsigned long long)off, (unsigned long long)len); |
| 2927 | return -EIO; | 2969 | return -EIO; |
| 2928 | } | 2970 | } |
diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c index 545e37c4b91e..387d92d00b97 100644 --- a/fs/ext3/xattr.c +++ b/fs/ext3/xattr.c | |||
| @@ -960,6 +960,10 @@ ext3_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
| 960 | if (error) | 960 | if (error) |
| 961 | goto cleanup; | 961 | goto cleanup; |
| 962 | 962 | ||
| 963 | error = ext3_journal_get_write_access(handle, is.iloc.bh); | ||
| 964 | if (error) | ||
| 965 | goto cleanup; | ||
| 966 | |||
| 963 | if (EXT3_I(inode)->i_state & EXT3_STATE_NEW) { | 967 | if (EXT3_I(inode)->i_state & EXT3_STATE_NEW) { |
| 964 | struct ext3_inode *raw_inode = ext3_raw_inode(&is.iloc); | 968 | struct ext3_inode *raw_inode = ext3_raw_inode(&is.iloc); |
| 965 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); | 969 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); |
| @@ -985,9 +989,6 @@ ext3_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
| 985 | if (flags & XATTR_CREATE) | 989 | if (flags & XATTR_CREATE) |
| 986 | goto cleanup; | 990 | goto cleanup; |
| 987 | } | 991 | } |
| 988 | error = ext3_journal_get_write_access(handle, is.iloc.bh); | ||
| 989 | if (error) | ||
| 990 | goto cleanup; | ||
| 991 | if (!value) { | 992 | if (!value) { |
| 992 | if (!is.s.not_found) | 993 | if (!is.s.not_found) |
| 993 | error = ext3_xattr_ibody_set(handle, inode, &i, &is); | 994 | error = ext3_xattr_ibody_set(handle, inode, &i, &is); |
diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig index 9f2d45d75b1a..e5f6774846e4 100644 --- a/fs/ext4/Kconfig +++ b/fs/ext4/Kconfig | |||
| @@ -2,6 +2,7 @@ config EXT4_FS | |||
| 2 | tristate "The Extended 4 (ext4) filesystem" | 2 | tristate "The Extended 4 (ext4) filesystem" |
| 3 | select JBD2 | 3 | select JBD2 |
| 4 | select CRC16 | 4 | select CRC16 |
| 5 | select FS_JOURNAL_INFO | ||
| 5 | help | 6 | help |
| 6 | This is the next generation of the ext3 filesystem. | 7 | This is the next generation of the ext3 filesystem. |
| 7 | 8 | ||
| @@ -26,6 +27,16 @@ config EXT4_FS | |||
| 26 | 27 | ||
| 27 | If unsure, say N. | 28 | If unsure, say N. |
| 28 | 29 | ||
| 30 | config EXT4_USE_FOR_EXT23 | ||
| 31 | bool "Use ext4 for ext2/ext3 file systems" | ||
| 32 | depends on EXT3_FS=n || EXT2_FS=n | ||
| 33 | default y | ||
| 34 | help | ||
| 35 | Allow the ext4 file system driver code to be used for ext2 or | ||
| 36 | ext3 file system mounts. This allows users to reduce their | ||
| 37 | compiled kernel size by using one file system driver for | ||
| 38 | ext2, ext3, and ext4 file systems. | ||
| 39 | |||
| 29 | config EXT4_FS_XATTR | 40 | config EXT4_FS_XATTR |
| 30 | bool "Ext4 extended attributes" | 41 | bool "Ext4 extended attributes" |
| 31 | depends on EXT4_FS | 42 | depends on EXT4_FS |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 1d0418980f8d..22bc7435d913 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
| @@ -499,44 +499,6 @@ error_return: | |||
| 499 | } | 499 | } |
| 500 | 500 | ||
| 501 | /** | 501 | /** |
| 502 | * ext4_free_blocks() -- Free given blocks and update quota | ||
| 503 | * @handle: handle for this transaction | ||
| 504 | * @inode: inode | ||
| 505 | * @block: start physical block to free | ||
| 506 | * @count: number of blocks to count | ||
| 507 | * @metadata: Are these metadata blocks | ||
| 508 | */ | ||
| 509 | void ext4_free_blocks(handle_t *handle, struct inode *inode, | ||
| 510 | ext4_fsblk_t block, unsigned long count, | ||
| 511 | int metadata) | ||
| 512 | { | ||
| 513 | struct super_block *sb; | ||
| 514 | unsigned long dquot_freed_blocks; | ||
| 515 | |||
| 516 | /* this isn't the right place to decide whether block is metadata | ||
| 517 | * inode.c/extents.c knows better, but for safety ... */ | ||
| 518 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) | ||
| 519 | metadata = 1; | ||
| 520 | |||
| 521 | /* We need to make sure we don't reuse | ||
| 522 | * block released untill the transaction commit. | ||
| 523 | * writeback mode have weak data consistency so | ||
| 524 | * don't force data as metadata when freeing block | ||
| 525 | * for writeback mode. | ||
| 526 | */ | ||
| 527 | if (metadata == 0 && !ext4_should_writeback_data(inode)) | ||
| 528 | metadata = 1; | ||
| 529 | |||
| 530 | sb = inode->i_sb; | ||
| 531 | |||
| 532 | ext4_mb_free_blocks(handle, inode, block, count, | ||
| 533 | metadata, &dquot_freed_blocks); | ||
| 534 | if (dquot_freed_blocks) | ||
| 535 | vfs_dq_free_block(inode, dquot_freed_blocks); | ||
| 536 | return; | ||
| 537 | } | ||
| 538 | |||
| 539 | /** | ||
| 540 | * ext4_has_free_blocks() | 502 | * ext4_has_free_blocks() |
| 541 | * @sbi: in-core super block structure. | 503 | * @sbi: in-core super block structure. |
| 542 | * @nblocks: number of needed blocks | 504 | * @nblocks: number of needed blocks |
| @@ -761,7 +723,13 @@ static unsigned long ext4_bg_num_gdb_meta(struct super_block *sb, | |||
| 761 | static unsigned long ext4_bg_num_gdb_nometa(struct super_block *sb, | 723 | static unsigned long ext4_bg_num_gdb_nometa(struct super_block *sb, |
| 762 | ext4_group_t group) | 724 | ext4_group_t group) |
| 763 | { | 725 | { |
| 764 | return ext4_bg_has_super(sb, group) ? EXT4_SB(sb)->s_gdb_count : 0; | 726 | if (!ext4_bg_has_super(sb, group)) |
| 727 | return 0; | ||
| 728 | |||
| 729 | if (EXT4_HAS_INCOMPAT_FEATURE(sb,EXT4_FEATURE_INCOMPAT_META_BG)) | ||
| 730 | return le32_to_cpu(EXT4_SB(sb)->s_es->s_first_meta_bg); | ||
| 731 | else | ||
| 732 | return EXT4_SB(sb)->s_gdb_count; | ||
| 765 | } | 733 | } |
| 766 | 734 | ||
| 767 | /** | 735 | /** |
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 50784ef07563..4df8621ec31c 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c | |||
| @@ -160,7 +160,7 @@ int ext4_setup_system_zone(struct super_block *sb) | |||
| 160 | if (ext4_bg_has_super(sb, i) && | 160 | if (ext4_bg_has_super(sb, i) && |
| 161 | ((i < 5) || ((i % flex_size) == 0))) | 161 | ((i < 5) || ((i % flex_size) == 0))) |
| 162 | add_system_zone(sbi, ext4_group_first_block_no(sb, i), | 162 | add_system_zone(sbi, ext4_group_first_block_no(sb, i), |
| 163 | sbi->s_gdb_count + 1); | 163 | ext4_bg_num_gdb(sb, i) + 1); |
| 164 | gdp = ext4_get_group_desc(sb, i, NULL); | 164 | gdp = ext4_get_group_desc(sb, i, NULL); |
| 165 | ret = add_system_zone(sbi, ext4_block_bitmap(sb, gdp), 1); | 165 | ret = add_system_zone(sbi, ext4_block_bitmap(sb, gdp), 1); |
| 166 | if (ret) | 166 | if (ret) |
| @@ -228,6 +228,7 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk, | |||
| 228 | struct rb_node *n = sbi->system_blks.rb_node; | 228 | struct rb_node *n = sbi->system_blks.rb_node; |
| 229 | 229 | ||
| 230 | if ((start_blk <= le32_to_cpu(sbi->s_es->s_first_data_block)) || | 230 | if ((start_blk <= le32_to_cpu(sbi->s_es->s_first_data_block)) || |
| 231 | (start_blk + count < start_blk) || | ||
| 231 | (start_blk + count > ext4_blocks_count(sbi->s_es))) | 232 | (start_blk + count > ext4_blocks_count(sbi->s_es))) |
| 232 | return 0; | 233 | return 0; |
| 233 | while (n) { | 234 | while (n) { |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 8825515eeddd..ab31e65d46d0 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
| @@ -376,6 +376,12 @@ struct ext4_new_group_data { | |||
| 376 | EXT4_GET_BLOCKS_DIO_CREATE_EXT) | 376 | EXT4_GET_BLOCKS_DIO_CREATE_EXT) |
| 377 | 377 | ||
| 378 | /* | 378 | /* |
| 379 | * Flags used by ext4_free_blocks | ||
| 380 | */ | ||
| 381 | #define EXT4_FREE_BLOCKS_METADATA 0x0001 | ||
| 382 | #define EXT4_FREE_BLOCKS_FORGET 0x0002 | ||
| 383 | |||
| 384 | /* | ||
| 379 | * ioctl commands | 385 | * ioctl commands |
| 380 | */ | 386 | */ |
| 381 | #define EXT4_IOC_GETFLAGS FS_IOC_GETFLAGS | 387 | #define EXT4_IOC_GETFLAGS FS_IOC_GETFLAGS |
| @@ -703,6 +709,13 @@ struct ext4_inode_info { | |||
| 703 | struct list_head i_aio_dio_complete_list; | 709 | struct list_head i_aio_dio_complete_list; |
| 704 | /* current io_end structure for async DIO write*/ | 710 | /* current io_end structure for async DIO write*/ |
| 705 | ext4_io_end_t *cur_aio_dio; | 711 | ext4_io_end_t *cur_aio_dio; |
| 712 | |||
| 713 | /* | ||
| 714 | * Transactions that contain inode's metadata needed to complete | ||
| 715 | * fsync and fdatasync, respectively. | ||
| 716 | */ | ||
| 717 | tid_t i_sync_tid; | ||
| 718 | tid_t i_datasync_tid; | ||
| 706 | }; | 719 | }; |
| 707 | 720 | ||
| 708 | /* | 721 | /* |
| @@ -750,6 +763,7 @@ struct ext4_inode_info { | |||
| 750 | #define EXT4_MOUNT_DELALLOC 0x8000000 /* Delalloc support */ | 763 | #define EXT4_MOUNT_DELALLOC 0x8000000 /* Delalloc support */ |
| 751 | #define EXT4_MOUNT_DATA_ERR_ABORT 0x10000000 /* Abort on file data write */ | 764 | #define EXT4_MOUNT_DATA_ERR_ABORT 0x10000000 /* Abort on file data write */ |
| 752 | #define EXT4_MOUNT_BLOCK_VALIDITY 0x20000000 /* Block validity checking */ | 765 | #define EXT4_MOUNT_BLOCK_VALIDITY 0x20000000 /* Block validity checking */ |
| 766 | #define EXT4_MOUNT_DISCARD 0x40000000 /* Issue DISCARD requests */ | ||
| 753 | 767 | ||
| 754 | #define clear_opt(o, opt) o &= ~EXT4_MOUNT_##opt | 768 | #define clear_opt(o, opt) o &= ~EXT4_MOUNT_##opt |
| 755 | #define set_opt(o, opt) o |= EXT4_MOUNT_##opt | 769 | #define set_opt(o, opt) o |= EXT4_MOUNT_##opt |
| @@ -1324,8 +1338,6 @@ extern ext4_fsblk_t ext4_new_meta_blocks(handle_t *handle, struct inode *inode, | |||
| 1324 | ext4_fsblk_t goal, unsigned long *count, int *errp); | 1338 | ext4_fsblk_t goal, unsigned long *count, int *errp); |
| 1325 | extern int ext4_claim_free_blocks(struct ext4_sb_info *sbi, s64 nblocks); | 1339 | extern int ext4_claim_free_blocks(struct ext4_sb_info *sbi, s64 nblocks); |
| 1326 | extern int ext4_has_free_blocks(struct ext4_sb_info *sbi, s64 nblocks); | 1340 | extern int ext4_has_free_blocks(struct ext4_sb_info *sbi, s64 nblocks); |
| 1327 | extern void ext4_free_blocks(handle_t *handle, struct inode *inode, | ||
| 1328 | ext4_fsblk_t block, unsigned long count, int metadata); | ||
| 1329 | extern void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | 1341 | extern void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, |
| 1330 | ext4_fsblk_t block, unsigned long count); | 1342 | ext4_fsblk_t block, unsigned long count); |
| 1331 | extern ext4_fsblk_t ext4_count_free_blocks(struct super_block *); | 1343 | extern ext4_fsblk_t ext4_count_free_blocks(struct super_block *); |
| @@ -1384,16 +1396,15 @@ extern int ext4_mb_reserve_blocks(struct super_block *, int); | |||
| 1384 | extern void ext4_discard_preallocations(struct inode *); | 1396 | extern void ext4_discard_preallocations(struct inode *); |
| 1385 | extern int __init init_ext4_mballoc(void); | 1397 | extern int __init init_ext4_mballoc(void); |
| 1386 | extern void exit_ext4_mballoc(void); | 1398 | extern void exit_ext4_mballoc(void); |
| 1387 | extern void ext4_mb_free_blocks(handle_t *, struct inode *, | 1399 | extern void ext4_free_blocks(handle_t *handle, struct inode *inode, |
| 1388 | ext4_fsblk_t, unsigned long, int, unsigned long *); | 1400 | struct buffer_head *bh, ext4_fsblk_t block, |
| 1401 | unsigned long count, int flags); | ||
| 1389 | extern int ext4_mb_add_groupinfo(struct super_block *sb, | 1402 | extern int ext4_mb_add_groupinfo(struct super_block *sb, |
| 1390 | ext4_group_t i, struct ext4_group_desc *desc); | 1403 | ext4_group_t i, struct ext4_group_desc *desc); |
| 1391 | extern int ext4_mb_get_buddy_cache_lock(struct super_block *, ext4_group_t); | 1404 | extern int ext4_mb_get_buddy_cache_lock(struct super_block *, ext4_group_t); |
| 1392 | extern void ext4_mb_put_buddy_cache_lock(struct super_block *, | 1405 | extern void ext4_mb_put_buddy_cache_lock(struct super_block *, |
| 1393 | ext4_group_t, int); | 1406 | ext4_group_t, int); |
| 1394 | /* inode.c */ | 1407 | /* inode.c */ |
| 1395 | int ext4_forget(handle_t *handle, int is_metadata, struct inode *inode, | ||
| 1396 | struct buffer_head *bh, ext4_fsblk_t blocknr); | ||
| 1397 | struct buffer_head *ext4_getblk(handle_t *, struct inode *, | 1408 | struct buffer_head *ext4_getblk(handle_t *, struct inode *, |
| 1398 | ext4_lblk_t, int, int *); | 1409 | ext4_lblk_t, int, int *); |
| 1399 | struct buffer_head *ext4_bread(handle_t *, struct inode *, | 1410 | struct buffer_head *ext4_bread(handle_t *, struct inode *, |
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c index 6a9409920dee..b57e5c711b6d 100644 --- a/fs/ext4/ext4_jbd2.c +++ b/fs/ext4/ext4_jbd2.c | |||
| @@ -4,6 +4,8 @@ | |||
| 4 | 4 | ||
| 5 | #include "ext4_jbd2.h" | 5 | #include "ext4_jbd2.h" |
| 6 | 6 | ||
| 7 | #include <trace/events/ext4.h> | ||
| 8 | |||
| 7 | int __ext4_journal_get_undo_access(const char *where, handle_t *handle, | 9 | int __ext4_journal_get_undo_access(const char *where, handle_t *handle, |
| 8 | struct buffer_head *bh) | 10 | struct buffer_head *bh) |
| 9 | { | 11 | { |
| @@ -32,35 +34,69 @@ int __ext4_journal_get_write_access(const char *where, handle_t *handle, | |||
| 32 | return err; | 34 | return err; |
| 33 | } | 35 | } |
| 34 | 36 | ||
| 35 | int __ext4_journal_forget(const char *where, handle_t *handle, | 37 | /* |
| 36 | struct buffer_head *bh) | 38 | * The ext4 forget function must perform a revoke if we are freeing data |
| 39 | * which has been journaled. Metadata (eg. indirect blocks) must be | ||
| 40 | * revoked in all cases. | ||
| 41 | * | ||
| 42 | * "bh" may be NULL: a metadata block may have been freed from memory | ||
| 43 | * but there may still be a record of it in the journal, and that record | ||
| 44 | * still needs to be revoked. | ||
| 45 | * | ||
| 46 | * If the handle isn't valid we're not journaling, but we still need to | ||
| 47 | * call into ext4_journal_revoke() to put the buffer head. | ||
| 48 | */ | ||
| 49 | int __ext4_forget(const char *where, handle_t *handle, int is_metadata, | ||
| 50 | struct inode *inode, struct buffer_head *bh, | ||
| 51 | ext4_fsblk_t blocknr) | ||
| 37 | { | 52 | { |
| 38 | int err = 0; | 53 | int err; |
| 39 | 54 | ||
| 40 | if (ext4_handle_valid(handle)) { | 55 | might_sleep(); |
| 41 | err = jbd2_journal_forget(handle, bh); | 56 | |
| 42 | if (err) | 57 | trace_ext4_forget(inode, is_metadata, blocknr); |
| 43 | ext4_journal_abort_handle(where, __func__, bh, | 58 | BUFFER_TRACE(bh, "enter"); |
| 44 | handle, err); | 59 | |
| 45 | } | 60 | jbd_debug(4, "forgetting bh %p: is_metadata = %d, mode %o, " |
| 46 | else | 61 | "data mode %x\n", |
| 62 | bh, is_metadata, inode->i_mode, | ||
| 63 | test_opt(inode->i_sb, DATA_FLAGS)); | ||
| 64 | |||
| 65 | /* In the no journal case, we can just do a bforget and return */ | ||
| 66 | if (!ext4_handle_valid(handle)) { | ||
| 47 | bforget(bh); | 67 | bforget(bh); |
| 48 | return err; | 68 | return 0; |
| 49 | } | 69 | } |
| 50 | 70 | ||
| 51 | int __ext4_journal_revoke(const char *where, handle_t *handle, | 71 | /* Never use the revoke function if we are doing full data |
| 52 | ext4_fsblk_t blocknr, struct buffer_head *bh) | 72 | * journaling: there is no need to, and a V1 superblock won't |
| 53 | { | 73 | * support it. Otherwise, only skip the revoke on un-journaled |
| 54 | int err = 0; | 74 | * data blocks. */ |
| 55 | 75 | ||
| 56 | if (ext4_handle_valid(handle)) { | 76 | if (test_opt(inode->i_sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA || |
| 57 | err = jbd2_journal_revoke(handle, blocknr, bh); | 77 | (!is_metadata && !ext4_should_journal_data(inode))) { |
| 58 | if (err) | 78 | if (bh) { |
| 59 | ext4_journal_abort_handle(where, __func__, bh, | 79 | BUFFER_TRACE(bh, "call jbd2_journal_forget"); |
| 60 | handle, err); | 80 | err = jbd2_journal_forget(handle, bh); |
| 81 | if (err) | ||
| 82 | ext4_journal_abort_handle(where, __func__, bh, | ||
| 83 | handle, err); | ||
| 84 | return err; | ||
| 85 | } | ||
| 86 | return 0; | ||
| 61 | } | 87 | } |
| 62 | else | 88 | |
| 63 | bforget(bh); | 89 | /* |
| 90 | * data!=journal && (is_metadata || should_journal_data(inode)) | ||
| 91 | */ | ||
| 92 | BUFFER_TRACE(bh, "call jbd2_journal_revoke"); | ||
| 93 | err = jbd2_journal_revoke(handle, blocknr, bh); | ||
| 94 | if (err) { | ||
| 95 | ext4_journal_abort_handle(where, __func__, bh, handle, err); | ||
| 96 | ext4_abort(inode->i_sb, __func__, | ||
| 97 | "error %d when attempting revoke", err); | ||
| 98 | } | ||
| 99 | BUFFER_TRACE(bh, "exit"); | ||
| 64 | return err; | 100 | return err; |
| 65 | } | 101 | } |
| 66 | 102 | ||
diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h index a2865980342f..05eca817d704 100644 --- a/fs/ext4/ext4_jbd2.h +++ b/fs/ext4/ext4_jbd2.h | |||
| @@ -49,7 +49,7 @@ | |||
| 49 | 49 | ||
| 50 | #define EXT4_DATA_TRANS_BLOCKS(sb) (EXT4_SINGLEDATA_TRANS_BLOCKS(sb) + \ | 50 | #define EXT4_DATA_TRANS_BLOCKS(sb) (EXT4_SINGLEDATA_TRANS_BLOCKS(sb) + \ |
| 51 | EXT4_XATTR_TRANS_BLOCKS - 2 + \ | 51 | EXT4_XATTR_TRANS_BLOCKS - 2 + \ |
| 52 | 2*EXT4_QUOTA_TRANS_BLOCKS(sb)) | 52 | EXT4_MAXQUOTAS_TRANS_BLOCKS(sb)) |
| 53 | 53 | ||
| 54 | /* | 54 | /* |
| 55 | * Define the number of metadata blocks we need to account to modify data. | 55 | * Define the number of metadata blocks we need to account to modify data. |
| @@ -57,7 +57,7 @@ | |||
| 57 | * This include super block, inode block, quota blocks and xattr blocks | 57 | * This include super block, inode block, quota blocks and xattr blocks |
| 58 | */ | 58 | */ |
| 59 | #define EXT4_META_TRANS_BLOCKS(sb) (EXT4_XATTR_TRANS_BLOCKS + \ | 59 | #define EXT4_META_TRANS_BLOCKS(sb) (EXT4_XATTR_TRANS_BLOCKS + \ |
| 60 | 2*EXT4_QUOTA_TRANS_BLOCKS(sb)) | 60 | EXT4_MAXQUOTAS_TRANS_BLOCKS(sb)) |
| 61 | 61 | ||
| 62 | /* Delete operations potentially hit one directory's namespace plus an | 62 | /* Delete operations potentially hit one directory's namespace plus an |
| 63 | * entire inode, plus arbitrary amounts of bitmap/indirection data. Be | 63 | * entire inode, plus arbitrary amounts of bitmap/indirection data. Be |
| @@ -92,6 +92,7 @@ | |||
| 92 | * but inode, sb and group updates are done only once */ | 92 | * but inode, sb and group updates are done only once */ |
| 93 | #define EXT4_QUOTA_INIT_BLOCKS(sb) (test_opt(sb, QUOTA) ? (DQUOT_INIT_ALLOC*\ | 93 | #define EXT4_QUOTA_INIT_BLOCKS(sb) (test_opt(sb, QUOTA) ? (DQUOT_INIT_ALLOC*\ |
| 94 | (EXT4_SINGLEDATA_TRANS_BLOCKS(sb)-3)+3+DQUOT_INIT_REWRITE) : 0) | 94 | (EXT4_SINGLEDATA_TRANS_BLOCKS(sb)-3)+3+DQUOT_INIT_REWRITE) : 0) |
| 95 | |||
| 95 | #define EXT4_QUOTA_DEL_BLOCKS(sb) (test_opt(sb, QUOTA) ? (DQUOT_DEL_ALLOC*\ | 96 | #define EXT4_QUOTA_DEL_BLOCKS(sb) (test_opt(sb, QUOTA) ? (DQUOT_DEL_ALLOC*\ |
| 96 | (EXT4_SINGLEDATA_TRANS_BLOCKS(sb)-3)+3+DQUOT_DEL_REWRITE) : 0) | 97 | (EXT4_SINGLEDATA_TRANS_BLOCKS(sb)-3)+3+DQUOT_DEL_REWRITE) : 0) |
| 97 | #else | 98 | #else |
| @@ -99,6 +100,9 @@ | |||
| 99 | #define EXT4_QUOTA_INIT_BLOCKS(sb) 0 | 100 | #define EXT4_QUOTA_INIT_BLOCKS(sb) 0 |
| 100 | #define EXT4_QUOTA_DEL_BLOCKS(sb) 0 | 101 | #define EXT4_QUOTA_DEL_BLOCKS(sb) 0 |
| 101 | #endif | 102 | #endif |
| 103 | #define EXT4_MAXQUOTAS_TRANS_BLOCKS(sb) (MAXQUOTAS*EXT4_QUOTA_TRANS_BLOCKS(sb)) | ||
| 104 | #define EXT4_MAXQUOTAS_INIT_BLOCKS(sb) (MAXQUOTAS*EXT4_QUOTA_INIT_BLOCKS(sb)) | ||
| 105 | #define EXT4_MAXQUOTAS_DEL_BLOCKS(sb) (MAXQUOTAS*EXT4_QUOTA_DEL_BLOCKS(sb)) | ||
| 102 | 106 | ||
| 103 | int | 107 | int |
| 104 | ext4_mark_iloc_dirty(handle_t *handle, | 108 | ext4_mark_iloc_dirty(handle_t *handle, |
| @@ -116,12 +120,8 @@ int ext4_reserve_inode_write(handle_t *handle, struct inode *inode, | |||
| 116 | int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode); | 120 | int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode); |
| 117 | 121 | ||
| 118 | /* | 122 | /* |
| 119 | * Wrapper functions with which ext4 calls into JBD. The intent here is | 123 | * Wrapper functions with which ext4 calls into JBD. |
| 120 | * to allow these to be turned into appropriate stubs so ext4 can control | ||
| 121 | * ext2 filesystems, so ext2+ext4 systems only nee one fs. This work hasn't | ||
| 122 | * been done yet. | ||
| 123 | */ | 124 | */ |
| 124 | |||
| 125 | void ext4_journal_abort_handle(const char *caller, const char *err_fn, | 125 | void ext4_journal_abort_handle(const char *caller, const char *err_fn, |
| 126 | struct buffer_head *bh, handle_t *handle, int err); | 126 | struct buffer_head *bh, handle_t *handle, int err); |
| 127 | 127 | ||
| @@ -131,13 +131,9 @@ int __ext4_journal_get_undo_access(const char *where, handle_t *handle, | |||
| 131 | int __ext4_journal_get_write_access(const char *where, handle_t *handle, | 131 | int __ext4_journal_get_write_access(const char *where, handle_t *handle, |
| 132 | struct buffer_head *bh); | 132 | struct buffer_head *bh); |
| 133 | 133 | ||
| 134 | /* When called with an invalid handle, this will still do a put on the BH */ | 134 | int __ext4_forget(const char *where, handle_t *handle, int is_metadata, |
| 135 | int __ext4_journal_forget(const char *where, handle_t *handle, | 135 | struct inode *inode, struct buffer_head *bh, |
| 136 | struct buffer_head *bh); | 136 | ext4_fsblk_t blocknr); |
| 137 | |||
| 138 | /* When called with an invalid handle, this will still do a put on the BH */ | ||
| 139 | int __ext4_journal_revoke(const char *where, handle_t *handle, | ||
| 140 | ext4_fsblk_t blocknr, struct buffer_head *bh); | ||
| 141 | 137 | ||
| 142 | int __ext4_journal_get_create_access(const char *where, | 138 | int __ext4_journal_get_create_access(const char *where, |
| 143 | handle_t *handle, struct buffer_head *bh); | 139 | handle_t *handle, struct buffer_head *bh); |
| @@ -149,12 +145,11 @@ int __ext4_handle_dirty_metadata(const char *where, handle_t *handle, | |||
| 149 | __ext4_journal_get_undo_access(__func__, (handle), (bh)) | 145 | __ext4_journal_get_undo_access(__func__, (handle), (bh)) |
| 150 | #define ext4_journal_get_write_access(handle, bh) \ | 146 | #define ext4_journal_get_write_access(handle, bh) \ |
| 151 | __ext4_journal_get_write_access(__func__, (handle), (bh)) | 147 | __ext4_journal_get_write_access(__func__, (handle), (bh)) |
| 152 | #define ext4_journal_revoke(handle, blocknr, bh) \ | 148 | #define ext4_forget(handle, is_metadata, inode, bh, block_nr) \ |
| 153 | __ext4_journal_revoke(__func__, (handle), (blocknr), (bh)) | 149 | __ext4_forget(__func__, (handle), (is_metadata), (inode), (bh),\ |
| 150 | (block_nr)) | ||
| 154 | #define ext4_journal_get_create_access(handle, bh) \ | 151 | #define ext4_journal_get_create_access(handle, bh) \ |
| 155 | __ext4_journal_get_create_access(__func__, (handle), (bh)) | 152 | __ext4_journal_get_create_access(__func__, (handle), (bh)) |
| 156 | #define ext4_journal_forget(handle, bh) \ | ||
| 157 | __ext4_journal_forget(__func__, (handle), (bh)) | ||
| 158 | #define ext4_handle_dirty_metadata(handle, inode, bh) \ | 153 | #define ext4_handle_dirty_metadata(handle, inode, bh) \ |
| 159 | __ext4_handle_dirty_metadata(__func__, (handle), (inode), (bh)) | 154 | __ext4_handle_dirty_metadata(__func__, (handle), (inode), (bh)) |
| 160 | 155 | ||
| @@ -254,6 +249,19 @@ static inline int ext4_jbd2_file_inode(handle_t *handle, struct inode *inode) | |||
| 254 | return 0; | 249 | return 0; |
| 255 | } | 250 | } |
| 256 | 251 | ||
| 252 | static inline void ext4_update_inode_fsync_trans(handle_t *handle, | ||
| 253 | struct inode *inode, | ||
| 254 | int datasync) | ||
| 255 | { | ||
| 256 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
| 257 | |||
| 258 | if (ext4_handle_valid(handle)) { | ||
| 259 | ei->i_sync_tid = handle->h_transaction->t_tid; | ||
| 260 | if (datasync) | ||
| 261 | ei->i_datasync_tid = handle->h_transaction->t_tid; | ||
| 262 | } | ||
| 263 | } | ||
| 264 | |||
| 257 | /* super.c */ | 265 | /* super.c */ |
| 258 | int ext4_force_commit(struct super_block *sb); | 266 | int ext4_force_commit(struct super_block *sb); |
| 259 | 267 | ||
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 715264b4bae4..3a7928f825e4 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
| @@ -1007,7 +1007,8 @@ cleanup: | |||
| 1007 | for (i = 0; i < depth; i++) { | 1007 | for (i = 0; i < depth; i++) { |
| 1008 | if (!ablocks[i]) | 1008 | if (!ablocks[i]) |
| 1009 | continue; | 1009 | continue; |
| 1010 | ext4_free_blocks(handle, inode, ablocks[i], 1, 1); | 1010 | ext4_free_blocks(handle, inode, 0, ablocks[i], 1, |
| 1011 | EXT4_FREE_BLOCKS_METADATA); | ||
| 1011 | } | 1012 | } |
| 1012 | } | 1013 | } |
| 1013 | kfree(ablocks); | 1014 | kfree(ablocks); |
| @@ -1761,7 +1762,9 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block, | |||
| 1761 | while (block < last && block != EXT_MAX_BLOCK) { | 1762 | while (block < last && block != EXT_MAX_BLOCK) { |
| 1762 | num = last - block; | 1763 | num = last - block; |
| 1763 | /* find extent for this block */ | 1764 | /* find extent for this block */ |
| 1765 | down_read(&EXT4_I(inode)->i_data_sem); | ||
| 1764 | path = ext4_ext_find_extent(inode, block, path); | 1766 | path = ext4_ext_find_extent(inode, block, path); |
| 1767 | up_read(&EXT4_I(inode)->i_data_sem); | ||
| 1765 | if (IS_ERR(path)) { | 1768 | if (IS_ERR(path)) { |
| 1766 | err = PTR_ERR(path); | 1769 | err = PTR_ERR(path); |
| 1767 | path = NULL; | 1770 | path = NULL; |
| @@ -1957,7 +1960,6 @@ errout: | |||
| 1957 | static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode, | 1960 | static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode, |
| 1958 | struct ext4_ext_path *path) | 1961 | struct ext4_ext_path *path) |
| 1959 | { | 1962 | { |
| 1960 | struct buffer_head *bh; | ||
| 1961 | int err; | 1963 | int err; |
| 1962 | ext4_fsblk_t leaf; | 1964 | ext4_fsblk_t leaf; |
| 1963 | 1965 | ||
| @@ -1973,9 +1975,8 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode, | |||
| 1973 | if (err) | 1975 | if (err) |
| 1974 | return err; | 1976 | return err; |
| 1975 | ext_debug("index is empty, remove it, free block %llu\n", leaf); | 1977 | ext_debug("index is empty, remove it, free block %llu\n", leaf); |
| 1976 | bh = sb_find_get_block(inode->i_sb, leaf); | 1978 | ext4_free_blocks(handle, inode, 0, leaf, 1, |
| 1977 | ext4_forget(handle, 1, inode, bh, leaf); | 1979 | EXT4_FREE_BLOCKS_METADATA | EXT4_FREE_BLOCKS_FORGET); |
| 1978 | ext4_free_blocks(handle, inode, leaf, 1, 1); | ||
| 1979 | return err; | 1980 | return err; |
| 1980 | } | 1981 | } |
| 1981 | 1982 | ||
| @@ -2042,12 +2043,11 @@ static int ext4_remove_blocks(handle_t *handle, struct inode *inode, | |||
| 2042 | struct ext4_extent *ex, | 2043 | struct ext4_extent *ex, |
| 2043 | ext4_lblk_t from, ext4_lblk_t to) | 2044 | ext4_lblk_t from, ext4_lblk_t to) |
| 2044 | { | 2045 | { |
| 2045 | struct buffer_head *bh; | ||
| 2046 | unsigned short ee_len = ext4_ext_get_actual_len(ex); | 2046 | unsigned short ee_len = ext4_ext_get_actual_len(ex); |
| 2047 | int i, metadata = 0; | 2047 | int flags = EXT4_FREE_BLOCKS_FORGET; |
| 2048 | 2048 | ||
| 2049 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) | 2049 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) |
| 2050 | metadata = 1; | 2050 | flags |= EXT4_FREE_BLOCKS_METADATA; |
| 2051 | #ifdef EXTENTS_STATS | 2051 | #ifdef EXTENTS_STATS |
| 2052 | { | 2052 | { |
| 2053 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); | 2053 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); |
| @@ -2072,11 +2072,7 @@ static int ext4_remove_blocks(handle_t *handle, struct inode *inode, | |||
| 2072 | num = le32_to_cpu(ex->ee_block) + ee_len - from; | 2072 | num = le32_to_cpu(ex->ee_block) + ee_len - from; |
| 2073 | start = ext_pblock(ex) + ee_len - num; | 2073 | start = ext_pblock(ex) + ee_len - num; |
| 2074 | ext_debug("free last %u blocks starting %llu\n", num, start); | 2074 | ext_debug("free last %u blocks starting %llu\n", num, start); |
| 2075 | for (i = 0; i < num; i++) { | 2075 | ext4_free_blocks(handle, inode, 0, start, num, flags); |
| 2076 | bh = sb_find_get_block(inode->i_sb, start + i); | ||
| 2077 | ext4_forget(handle, 0, inode, bh, start + i); | ||
| 2078 | } | ||
| 2079 | ext4_free_blocks(handle, inode, start, num, metadata); | ||
| 2080 | } else if (from == le32_to_cpu(ex->ee_block) | 2076 | } else if (from == le32_to_cpu(ex->ee_block) |
| 2081 | && to <= le32_to_cpu(ex->ee_block) + ee_len - 1) { | 2077 | && to <= le32_to_cpu(ex->ee_block) + ee_len - 1) { |
| 2082 | printk(KERN_INFO "strange request: removal %u-%u from %u:%u\n", | 2078 | printk(KERN_INFO "strange request: removal %u-%u from %u:%u\n", |
| @@ -2167,7 +2163,7 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode, | |||
| 2167 | correct_index = 1; | 2163 | correct_index = 1; |
| 2168 | credits += (ext_depth(inode)) + 1; | 2164 | credits += (ext_depth(inode)) + 1; |
| 2169 | } | 2165 | } |
| 2170 | credits += 2 * EXT4_QUOTA_TRANS_BLOCKS(inode->i_sb); | 2166 | credits += EXT4_MAXQUOTAS_TRANS_BLOCKS(inode->i_sb); |
| 2171 | 2167 | ||
| 2172 | err = ext4_ext_truncate_extend_restart(handle, inode, credits); | 2168 | err = ext4_ext_truncate_extend_restart(handle, inode, credits); |
| 2173 | if (err) | 2169 | if (err) |
| @@ -3064,6 +3060,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
| 3064 | if (flags == EXT4_GET_BLOCKS_DIO_CONVERT_EXT) { | 3060 | if (flags == EXT4_GET_BLOCKS_DIO_CONVERT_EXT) { |
| 3065 | ret = ext4_convert_unwritten_extents_dio(handle, inode, | 3061 | ret = ext4_convert_unwritten_extents_dio(handle, inode, |
| 3066 | path); | 3062 | path); |
| 3063 | if (ret >= 0) | ||
| 3064 | ext4_update_inode_fsync_trans(handle, inode, 1); | ||
| 3067 | goto out2; | 3065 | goto out2; |
| 3068 | } | 3066 | } |
| 3069 | /* buffered IO case */ | 3067 | /* buffered IO case */ |
| @@ -3091,6 +3089,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
| 3091 | ret = ext4_ext_convert_to_initialized(handle, inode, | 3089 | ret = ext4_ext_convert_to_initialized(handle, inode, |
| 3092 | path, iblock, | 3090 | path, iblock, |
| 3093 | max_blocks); | 3091 | max_blocks); |
| 3092 | if (ret >= 0) | ||
| 3093 | ext4_update_inode_fsync_trans(handle, inode, 1); | ||
| 3094 | out: | 3094 | out: |
| 3095 | if (ret <= 0) { | 3095 | if (ret <= 0) { |
| 3096 | err = ret; | 3096 | err = ret; |
| @@ -3319,8 +3319,8 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
| 3319 | /* not a good idea to call discard here directly, | 3319 | /* not a good idea to call discard here directly, |
| 3320 | * but otherwise we'd need to call it every free() */ | 3320 | * but otherwise we'd need to call it every free() */ |
| 3321 | ext4_discard_preallocations(inode); | 3321 | ext4_discard_preallocations(inode); |
| 3322 | ext4_free_blocks(handle, inode, ext_pblock(&newex), | 3322 | ext4_free_blocks(handle, inode, 0, ext_pblock(&newex), |
| 3323 | ext4_ext_get_actual_len(&newex), 0); | 3323 | ext4_ext_get_actual_len(&newex), 0); |
| 3324 | goto out2; | 3324 | goto out2; |
| 3325 | } | 3325 | } |
| 3326 | 3326 | ||
| @@ -3329,10 +3329,16 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
| 3329 | allocated = ext4_ext_get_actual_len(&newex); | 3329 | allocated = ext4_ext_get_actual_len(&newex); |
| 3330 | set_buffer_new(bh_result); | 3330 | set_buffer_new(bh_result); |
| 3331 | 3331 | ||
| 3332 | /* Cache only when it is _not_ an uninitialized extent */ | 3332 | /* |
| 3333 | if ((flags & EXT4_GET_BLOCKS_UNINIT_EXT) == 0) | 3333 | * Cache the extent and update transaction to commit on fdatasync only |
| 3334 | * when it is _not_ an uninitialized extent. | ||
| 3335 | */ | ||
| 3336 | if ((flags & EXT4_GET_BLOCKS_UNINIT_EXT) == 0) { | ||
| 3334 | ext4_ext_put_in_cache(inode, iblock, allocated, newblock, | 3337 | ext4_ext_put_in_cache(inode, iblock, allocated, newblock, |
| 3335 | EXT4_EXT_CACHE_EXTENT); | 3338 | EXT4_EXT_CACHE_EXTENT); |
| 3339 | ext4_update_inode_fsync_trans(handle, inode, 1); | ||
| 3340 | } else | ||
| 3341 | ext4_update_inode_fsync_trans(handle, inode, 0); | ||
| 3336 | out: | 3342 | out: |
| 3337 | if (allocated > max_blocks) | 3343 | if (allocated > max_blocks) |
| 3338 | allocated = max_blocks; | 3344 | allocated = max_blocks; |
| @@ -3720,10 +3726,8 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | |||
| 3720 | * Walk the extent tree gathering extent information. | 3726 | * Walk the extent tree gathering extent information. |
| 3721 | * ext4_ext_fiemap_cb will push extents back to user. | 3727 | * ext4_ext_fiemap_cb will push extents back to user. |
| 3722 | */ | 3728 | */ |
| 3723 | down_read(&EXT4_I(inode)->i_data_sem); | ||
| 3724 | error = ext4_ext_walk_space(inode, start_blk, len_blks, | 3729 | error = ext4_ext_walk_space(inode, start_blk, len_blks, |
| 3725 | ext4_ext_fiemap_cb, fieinfo); | 3730 | ext4_ext_fiemap_cb, fieinfo); |
| 3726 | up_read(&EXT4_I(inode)->i_data_sem); | ||
| 3727 | } | 3731 | } |
| 3728 | 3732 | ||
| 3729 | return error; | 3733 | return error; |
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 2b1531266ee2..0b22497d92e1 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c | |||
| @@ -51,25 +51,30 @@ | |||
| 51 | int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) | 51 | int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) |
| 52 | { | 52 | { |
| 53 | struct inode *inode = dentry->d_inode; | 53 | struct inode *inode = dentry->d_inode; |
| 54 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
| 54 | journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; | 55 | journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; |
| 55 | int err, ret = 0; | 56 | int ret; |
| 57 | tid_t commit_tid; | ||
| 56 | 58 | ||
| 57 | J_ASSERT(ext4_journal_current_handle() == NULL); | 59 | J_ASSERT(ext4_journal_current_handle() == NULL); |
| 58 | 60 | ||
| 59 | trace_ext4_sync_file(file, dentry, datasync); | 61 | trace_ext4_sync_file(file, dentry, datasync); |
| 60 | 62 | ||
| 63 | if (inode->i_sb->s_flags & MS_RDONLY) | ||
| 64 | return 0; | ||
| 65 | |||
| 61 | ret = flush_aio_dio_completed_IO(inode); | 66 | ret = flush_aio_dio_completed_IO(inode); |
| 62 | if (ret < 0) | 67 | if (ret < 0) |
| 63 | goto out; | 68 | return ret; |
| 69 | |||
| 70 | if (!journal) | ||
| 71 | return simple_fsync(file, dentry, datasync); | ||
| 72 | |||
| 64 | /* | 73 | /* |
| 65 | * data=writeback: | 74 | * data=writeback,ordered: |
| 66 | * The caller's filemap_fdatawrite()/wait will sync the data. | 75 | * The caller's filemap_fdatawrite()/wait will sync the data. |
| 67 | * sync_inode() will sync the metadata | 76 | * Metadata is in the journal, we wait for proper transaction to |
| 68 | * | 77 | * commit here. |
| 69 | * data=ordered: | ||
| 70 | * The caller's filemap_fdatawrite() will write the data and | ||
| 71 | * sync_inode() will write the inode if it is dirty. Then the caller's | ||
| 72 | * filemap_fdatawait() will wait on the pages. | ||
| 73 | * | 78 | * |
| 74 | * data=journal: | 79 | * data=journal: |
| 75 | * filemap_fdatawrite won't do anything (the buffers are clean). | 80 | * filemap_fdatawrite won't do anything (the buffers are clean). |
| @@ -79,32 +84,13 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) | |||
| 79 | * (they were dirtied by commit). But that's OK - the blocks are | 84 | * (they were dirtied by commit). But that's OK - the blocks are |
| 80 | * safe in-journal, which is all fsync() needs to ensure. | 85 | * safe in-journal, which is all fsync() needs to ensure. |
| 81 | */ | 86 | */ |
| 82 | if (ext4_should_journal_data(inode)) { | 87 | if (ext4_should_journal_data(inode)) |
| 83 | ret = ext4_force_commit(inode->i_sb); | 88 | return ext4_force_commit(inode->i_sb); |
| 84 | goto out; | ||
| 85 | } | ||
| 86 | 89 | ||
| 87 | if (!journal) | 90 | commit_tid = datasync ? ei->i_datasync_tid : ei->i_sync_tid; |
| 88 | ret = sync_mapping_buffers(inode->i_mapping); | 91 | if (jbd2_log_start_commit(journal, commit_tid)) |
| 89 | 92 | jbd2_log_wait_commit(journal, commit_tid); | |
| 90 | if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) | 93 | else if (journal->j_flags & JBD2_BARRIER) |
| 91 | goto out; | ||
| 92 | |||
| 93 | /* | ||
| 94 | * The VFS has written the file data. If the inode is unaltered | ||
| 95 | * then we need not start a commit. | ||
| 96 | */ | ||
| 97 | if (inode->i_state & (I_DIRTY_SYNC|I_DIRTY_DATASYNC)) { | ||
| 98 | struct writeback_control wbc = { | ||
| 99 | .sync_mode = WB_SYNC_ALL, | ||
| 100 | .nr_to_write = 0, /* sys_fsync did this */ | ||
| 101 | }; | ||
| 102 | err = sync_inode(inode, &wbc); | ||
| 103 | if (ret == 0) | ||
| 104 | ret = err; | ||
| 105 | } | ||
| 106 | out: | ||
| 107 | if (journal && (journal->j_flags & JBD2_BARRIER)) | ||
| 108 | blkdev_issue_flush(inode->i_sb->s_bdev, NULL); | 94 | blkdev_issue_flush(inode->i_sb->s_bdev, NULL); |
| 109 | return ret; | 95 | return ret; |
| 110 | } | 96 | } |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 2c8caa51addb..5352db1a3086 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
| @@ -71,58 +71,6 @@ static int ext4_inode_is_fast_symlink(struct inode *inode) | |||
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | /* | 73 | /* |
| 74 | * The ext4 forget function must perform a revoke if we are freeing data | ||
| 75 | * which has been journaled. Metadata (eg. indirect blocks) must be | ||
| 76 | * revoked in all cases. | ||
| 77 | * | ||
| 78 | * "bh" may be NULL: a metadata block may have been freed from memory | ||
| 79 | * but there may still be a record of it in the journal, and that record | ||
| 80 | * still needs to be revoked. | ||
| 81 | * | ||
| 82 | * If the handle isn't valid we're not journaling, but we still need to | ||
| 83 | * call into ext4_journal_revoke() to put the buffer head. | ||
| 84 | */ | ||
| 85 | int ext4_forget(handle_t *handle, int is_metadata, struct inode *inode, | ||
| 86 | struct buffer_head *bh, ext4_fsblk_t blocknr) | ||
| 87 | { | ||
| 88 | int err; | ||
| 89 | |||
| 90 | might_sleep(); | ||
| 91 | |||
| 92 | BUFFER_TRACE(bh, "enter"); | ||
| 93 | |||
| 94 | jbd_debug(4, "forgetting bh %p: is_metadata = %d, mode %o, " | ||
| 95 | "data mode %x\n", | ||
| 96 | bh, is_metadata, inode->i_mode, | ||
| 97 | test_opt(inode->i_sb, DATA_FLAGS)); | ||
| 98 | |||
| 99 | /* Never use the revoke function if we are doing full data | ||
| 100 | * journaling: there is no need to, and a V1 superblock won't | ||
| 101 | * support it. Otherwise, only skip the revoke on un-journaled | ||
| 102 | * data blocks. */ | ||
| 103 | |||
| 104 | if (test_opt(inode->i_sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA || | ||
| 105 | (!is_metadata && !ext4_should_journal_data(inode))) { | ||
| 106 | if (bh) { | ||
| 107 | BUFFER_TRACE(bh, "call jbd2_journal_forget"); | ||
| 108 | return ext4_journal_forget(handle, bh); | ||
| 109 | } | ||
| 110 | return 0; | ||
| 111 | } | ||
| 112 | |||
| 113 | /* | ||
| 114 | * data!=journal && (is_metadata || should_journal_data(inode)) | ||
| 115 | */ | ||
| 116 | BUFFER_TRACE(bh, "call ext4_journal_revoke"); | ||
| 117 | err = ext4_journal_revoke(handle, blocknr, bh); | ||
| 118 | if (err) | ||
| 119 | ext4_abort(inode->i_sb, __func__, | ||
| 120 | "error %d when attempting revoke", err); | ||
| 121 | BUFFER_TRACE(bh, "exit"); | ||
| 122 | return err; | ||
| 123 | } | ||
| 124 | |||
| 125 | /* | ||
| 126 | * Work out how many blocks we need to proceed with the next chunk of a | 74 | * Work out how many blocks we need to proceed with the next chunk of a |
| 127 | * truncate transaction. | 75 | * truncate transaction. |
| 128 | */ | 76 | */ |
| @@ -721,7 +669,7 @@ allocated: | |||
| 721 | return ret; | 669 | return ret; |
| 722 | failed_out: | 670 | failed_out: |
| 723 | for (i = 0; i < index; i++) | 671 | for (i = 0; i < index; i++) |
| 724 | ext4_free_blocks(handle, inode, new_blocks[i], 1, 0); | 672 | ext4_free_blocks(handle, inode, 0, new_blocks[i], 1, 0); |
| 725 | return ret; | 673 | return ret; |
| 726 | } | 674 | } |
| 727 | 675 | ||
| @@ -817,14 +765,20 @@ static int ext4_alloc_branch(handle_t *handle, struct inode *inode, | |||
| 817 | return err; | 765 | return err; |
| 818 | failed: | 766 | failed: |
| 819 | /* Allocation failed, free what we already allocated */ | 767 | /* Allocation failed, free what we already allocated */ |
| 768 | ext4_free_blocks(handle, inode, 0, new_blocks[0], 1, 0); | ||
| 820 | for (i = 1; i <= n ; i++) { | 769 | for (i = 1; i <= n ; i++) { |
| 821 | BUFFER_TRACE(branch[i].bh, "call jbd2_journal_forget"); | 770 | /* |
| 822 | ext4_journal_forget(handle, branch[i].bh); | 771 | * branch[i].bh is newly allocated, so there is no |
| 772 | * need to revoke the block, which is why we don't | ||
| 773 | * need to set EXT4_FREE_BLOCKS_METADATA. | ||
| 774 | */ | ||
| 775 | ext4_free_blocks(handle, inode, 0, new_blocks[i], 1, | ||
| 776 | EXT4_FREE_BLOCKS_FORGET); | ||
| 823 | } | 777 | } |
| 824 | for (i = 0; i < indirect_blks; i++) | 778 | for (i = n+1; i < indirect_blks; i++) |
| 825 | ext4_free_blocks(handle, inode, new_blocks[i], 1, 0); | 779 | ext4_free_blocks(handle, inode, 0, new_blocks[i], 1, 0); |
| 826 | 780 | ||
| 827 | ext4_free_blocks(handle, inode, new_blocks[i], num, 0); | 781 | ext4_free_blocks(handle, inode, 0, new_blocks[i], num, 0); |
| 828 | 782 | ||
| 829 | return err; | 783 | return err; |
| 830 | } | 784 | } |
| @@ -903,12 +857,16 @@ static int ext4_splice_branch(handle_t *handle, struct inode *inode, | |||
| 903 | 857 | ||
| 904 | err_out: | 858 | err_out: |
| 905 | for (i = 1; i <= num; i++) { | 859 | for (i = 1; i <= num; i++) { |
| 906 | BUFFER_TRACE(where[i].bh, "call jbd2_journal_forget"); | 860 | /* |
| 907 | ext4_journal_forget(handle, where[i].bh); | 861 | * branch[i].bh is newly allocated, so there is no |
| 908 | ext4_free_blocks(handle, inode, | 862 | * need to revoke the block, which is why we don't |
| 909 | le32_to_cpu(where[i-1].key), 1, 0); | 863 | * need to set EXT4_FREE_BLOCKS_METADATA. |
| 864 | */ | ||
| 865 | ext4_free_blocks(handle, inode, where[i].bh, 0, 1, | ||
| 866 | EXT4_FREE_BLOCKS_FORGET); | ||
| 910 | } | 867 | } |
| 911 | ext4_free_blocks(handle, inode, le32_to_cpu(where[num].key), blks, 0); | 868 | ext4_free_blocks(handle, inode, 0, le32_to_cpu(where[num].key), |
| 869 | blks, 0); | ||
| 912 | 870 | ||
| 913 | return err; | 871 | return err; |
| 914 | } | 872 | } |
| @@ -1021,10 +979,12 @@ static int ext4_ind_get_blocks(handle_t *handle, struct inode *inode, | |||
| 1021 | if (!err) | 979 | if (!err) |
| 1022 | err = ext4_splice_branch(handle, inode, iblock, | 980 | err = ext4_splice_branch(handle, inode, iblock, |
| 1023 | partial, indirect_blks, count); | 981 | partial, indirect_blks, count); |
| 1024 | else | 982 | if (err) |
| 1025 | goto cleanup; | 983 | goto cleanup; |
| 1026 | 984 | ||
| 1027 | set_buffer_new(bh_result); | 985 | set_buffer_new(bh_result); |
| 986 | |||
| 987 | ext4_update_inode_fsync_trans(handle, inode, 1); | ||
| 1028 | got_it: | 988 | got_it: |
| 1029 | map_bh(bh_result, inode->i_sb, le32_to_cpu(chain[depth-1].key)); | 989 | map_bh(bh_result, inode->i_sb, le32_to_cpu(chain[depth-1].key)); |
| 1030 | if (count > blocks_to_boundary) | 990 | if (count > blocks_to_boundary) |
| @@ -1052,7 +1012,7 @@ qsize_t ext4_get_reserved_space(struct inode *inode) | |||
| 1052 | EXT4_I(inode)->i_reserved_meta_blocks; | 1012 | EXT4_I(inode)->i_reserved_meta_blocks; |
| 1053 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | 1013 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); |
| 1054 | 1014 | ||
| 1055 | return total; | 1015 | return (total << inode->i_blkbits); |
| 1056 | } | 1016 | } |
| 1057 | /* | 1017 | /* |
| 1058 | * Calculate the number of metadata blocks need to reserve | 1018 | * Calculate the number of metadata blocks need to reserve |
| @@ -1534,6 +1494,16 @@ static int do_journal_get_write_access(handle_t *handle, | |||
| 1534 | return ext4_journal_get_write_access(handle, bh); | 1494 | return ext4_journal_get_write_access(handle, bh); |
| 1535 | } | 1495 | } |
| 1536 | 1496 | ||
| 1497 | /* | ||
| 1498 | * Truncate blocks that were not used by write. We have to truncate the | ||
| 1499 | * pagecache as well so that corresponding buffers get properly unmapped. | ||
| 1500 | */ | ||
| 1501 | static void ext4_truncate_failed_write(struct inode *inode) | ||
| 1502 | { | ||
| 1503 | truncate_inode_pages(inode->i_mapping, inode->i_size); | ||
| 1504 | ext4_truncate(inode); | ||
| 1505 | } | ||
| 1506 | |||
| 1537 | static int ext4_write_begin(struct file *file, struct address_space *mapping, | 1507 | static int ext4_write_begin(struct file *file, struct address_space *mapping, |
| 1538 | loff_t pos, unsigned len, unsigned flags, | 1508 | loff_t pos, unsigned len, unsigned flags, |
| 1539 | struct page **pagep, void **fsdata) | 1509 | struct page **pagep, void **fsdata) |
| @@ -1599,7 +1569,7 @@ retry: | |||
| 1599 | 1569 | ||
| 1600 | ext4_journal_stop(handle); | 1570 | ext4_journal_stop(handle); |
| 1601 | if (pos + len > inode->i_size) { | 1571 | if (pos + len > inode->i_size) { |
| 1602 | ext4_truncate(inode); | 1572 | ext4_truncate_failed_write(inode); |
| 1603 | /* | 1573 | /* |
| 1604 | * If truncate failed early the inode might | 1574 | * If truncate failed early the inode might |
| 1605 | * still be on the orphan list; we need to | 1575 | * still be on the orphan list; we need to |
| @@ -1709,7 +1679,7 @@ static int ext4_ordered_write_end(struct file *file, | |||
| 1709 | ret = ret2; | 1679 | ret = ret2; |
| 1710 | 1680 | ||
| 1711 | if (pos + len > inode->i_size) { | 1681 | if (pos + len > inode->i_size) { |
| 1712 | ext4_truncate(inode); | 1682 | ext4_truncate_failed_write(inode); |
| 1713 | /* | 1683 | /* |
| 1714 | * If truncate failed early the inode might still be | 1684 | * If truncate failed early the inode might still be |
| 1715 | * on the orphan list; we need to make sure the inode | 1685 | * on the orphan list; we need to make sure the inode |
| @@ -1751,7 +1721,7 @@ static int ext4_writeback_write_end(struct file *file, | |||
| 1751 | ret = ret2; | 1721 | ret = ret2; |
| 1752 | 1722 | ||
| 1753 | if (pos + len > inode->i_size) { | 1723 | if (pos + len > inode->i_size) { |
| 1754 | ext4_truncate(inode); | 1724 | ext4_truncate_failed_write(inode); |
| 1755 | /* | 1725 | /* |
| 1756 | * If truncate failed early the inode might still be | 1726 | * If truncate failed early the inode might still be |
| 1757 | * on the orphan list; we need to make sure the inode | 1727 | * on the orphan list; we need to make sure the inode |
| @@ -1814,7 +1784,7 @@ static int ext4_journalled_write_end(struct file *file, | |||
| 1814 | if (!ret) | 1784 | if (!ret) |
| 1815 | ret = ret2; | 1785 | ret = ret2; |
| 1816 | if (pos + len > inode->i_size) { | 1786 | if (pos + len > inode->i_size) { |
| 1817 | ext4_truncate(inode); | 1787 | ext4_truncate_failed_write(inode); |
| 1818 | /* | 1788 | /* |
| 1819 | * If truncate failed early the inode might still be | 1789 | * If truncate failed early the inode might still be |
| 1820 | * on the orphan list; we need to make sure the inode | 1790 | * on the orphan list; we need to make sure the inode |
| @@ -2600,7 +2570,6 @@ static int bput_one(handle_t *handle, struct buffer_head *bh) | |||
| 2600 | } | 2570 | } |
| 2601 | 2571 | ||
| 2602 | static int __ext4_journalled_writepage(struct page *page, | 2572 | static int __ext4_journalled_writepage(struct page *page, |
| 2603 | struct writeback_control *wbc, | ||
| 2604 | unsigned int len) | 2573 | unsigned int len) |
| 2605 | { | 2574 | { |
| 2606 | struct address_space *mapping = page->mapping; | 2575 | struct address_space *mapping = page->mapping; |
| @@ -2758,7 +2727,7 @@ static int ext4_writepage(struct page *page, | |||
| 2758 | * doesn't seem much point in redirtying the page here. | 2727 | * doesn't seem much point in redirtying the page here. |
| 2759 | */ | 2728 | */ |
| 2760 | ClearPageChecked(page); | 2729 | ClearPageChecked(page); |
| 2761 | return __ext4_journalled_writepage(page, wbc, len); | 2730 | return __ext4_journalled_writepage(page, len); |
| 2762 | } | 2731 | } |
| 2763 | 2732 | ||
| 2764 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) | 2733 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) |
| @@ -2788,7 +2757,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode) | |||
| 2788 | * number of contiguous block. So we will limit | 2757 | * number of contiguous block. So we will limit |
| 2789 | * number of contiguous block to a sane value | 2758 | * number of contiguous block to a sane value |
| 2790 | */ | 2759 | */ |
| 2791 | if (!(inode->i_flags & EXT4_EXTENTS_FL) && | 2760 | if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) && |
| 2792 | (max_blocks > EXT4_MAX_TRANS_DATA)) | 2761 | (max_blocks > EXT4_MAX_TRANS_DATA)) |
| 2793 | max_blocks = EXT4_MAX_TRANS_DATA; | 2762 | max_blocks = EXT4_MAX_TRANS_DATA; |
| 2794 | 2763 | ||
| @@ -2933,7 +2902,7 @@ retry: | |||
| 2933 | ret = write_cache_pages(mapping, wbc, __mpage_da_writepage, | 2902 | ret = write_cache_pages(mapping, wbc, __mpage_da_writepage, |
| 2934 | &mpd); | 2903 | &mpd); |
| 2935 | /* | 2904 | /* |
| 2936 | * If we have a contigous extent of pages and we | 2905 | * If we have a contiguous extent of pages and we |
| 2937 | * haven't done the I/O yet, map the blocks and submit | 2906 | * haven't done the I/O yet, map the blocks and submit |
| 2938 | * them for I/O. | 2907 | * them for I/O. |
| 2939 | */ | 2908 | */ |
| @@ -3091,7 +3060,7 @@ retry: | |||
| 3091 | * i_size_read because we hold i_mutex. | 3060 | * i_size_read because we hold i_mutex. |
| 3092 | */ | 3061 | */ |
| 3093 | if (pos + len > inode->i_size) | 3062 | if (pos + len > inode->i_size) |
| 3094 | ext4_truncate(inode); | 3063 | ext4_truncate_failed_write(inode); |
| 3095 | } | 3064 | } |
| 3096 | 3065 | ||
| 3097 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) | 3066 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |
| @@ -4064,7 +4033,7 @@ static Indirect *ext4_find_shared(struct inode *inode, int depth, | |||
| 4064 | int k, err; | 4033 | int k, err; |
| 4065 | 4034 | ||
| 4066 | *top = 0; | 4035 | *top = 0; |
| 4067 | /* Make k index the deepest non-null offest + 1 */ | 4036 | /* Make k index the deepest non-null offset + 1 */ |
| 4068 | for (k = depth; k > 1 && !offsets[k-1]; k--) | 4037 | for (k = depth; k > 1 && !offsets[k-1]; k--) |
| 4069 | ; | 4038 | ; |
| 4070 | partial = ext4_get_branch(inode, k, offsets, chain, &err); | 4039 | partial = ext4_get_branch(inode, k, offsets, chain, &err); |
| @@ -4120,6 +4089,11 @@ static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | |||
| 4120 | __le32 *last) | 4089 | __le32 *last) |
| 4121 | { | 4090 | { |
| 4122 | __le32 *p; | 4091 | __le32 *p; |
| 4092 | int flags = EXT4_FREE_BLOCKS_FORGET; | ||
| 4093 | |||
| 4094 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) | ||
| 4095 | flags |= EXT4_FREE_BLOCKS_METADATA; | ||
| 4096 | |||
| 4123 | if (try_to_extend_transaction(handle, inode)) { | 4097 | if (try_to_extend_transaction(handle, inode)) { |
| 4124 | if (bh) { | 4098 | if (bh) { |
| 4125 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); | 4099 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); |
| @@ -4134,27 +4108,10 @@ static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | |||
| 4134 | } | 4108 | } |
| 4135 | } | 4109 | } |
| 4136 | 4110 | ||
| 4137 | /* | 4111 | for (p = first; p < last; p++) |
| 4138 | * Any buffers which are on the journal will be in memory. We | 4112 | *p = 0; |
| 4139 | * find them on the hash table so jbd2_journal_revoke() will | ||
| 4140 | * run jbd2_journal_forget() on them. We've already detached | ||
| 4141 | * each block from the file, so bforget() in | ||
| 4142 | * jbd2_journal_forget() should be safe. | ||
| 4143 | * | ||
| 4144 | * AKPM: turn on bforget in jbd2_journal_forget()!!! | ||
| 4145 | */ | ||
| 4146 | for (p = first; p < last; p++) { | ||
| 4147 | u32 nr = le32_to_cpu(*p); | ||
| 4148 | if (nr) { | ||
| 4149 | struct buffer_head *tbh; | ||
| 4150 | |||
| 4151 | *p = 0; | ||
| 4152 | tbh = sb_find_get_block(inode->i_sb, nr); | ||
| 4153 | ext4_forget(handle, 0, inode, tbh, nr); | ||
| 4154 | } | ||
| 4155 | } | ||
| 4156 | 4113 | ||
| 4157 | ext4_free_blocks(handle, inode, block_to_free, count, 0); | 4114 | ext4_free_blocks(handle, inode, 0, block_to_free, count, flags); |
| 4158 | } | 4115 | } |
| 4159 | 4116 | ||
| 4160 | /** | 4117 | /** |
| @@ -4342,7 +4299,8 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, | |||
| 4342 | blocks_for_truncate(inode)); | 4299 | blocks_for_truncate(inode)); |
| 4343 | } | 4300 | } |
| 4344 | 4301 | ||
| 4345 | ext4_free_blocks(handle, inode, nr, 1, 1); | 4302 | ext4_free_blocks(handle, inode, 0, nr, 1, |
| 4303 | EXT4_FREE_BLOCKS_METADATA); | ||
| 4346 | 4304 | ||
| 4347 | if (parent_bh) { | 4305 | if (parent_bh) { |
| 4348 | /* | 4306 | /* |
| @@ -4781,8 +4739,8 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4781 | struct ext4_iloc iloc; | 4739 | struct ext4_iloc iloc; |
| 4782 | struct ext4_inode *raw_inode; | 4740 | struct ext4_inode *raw_inode; |
| 4783 | struct ext4_inode_info *ei; | 4741 | struct ext4_inode_info *ei; |
| 4784 | struct buffer_head *bh; | ||
| 4785 | struct inode *inode; | 4742 | struct inode *inode; |
| 4743 | journal_t *journal = EXT4_SB(sb)->s_journal; | ||
| 4786 | long ret; | 4744 | long ret; |
| 4787 | int block; | 4745 | int block; |
| 4788 | 4746 | ||
| @@ -4793,11 +4751,11 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4793 | return inode; | 4751 | return inode; |
| 4794 | 4752 | ||
| 4795 | ei = EXT4_I(inode); | 4753 | ei = EXT4_I(inode); |
| 4754 | iloc.bh = 0; | ||
| 4796 | 4755 | ||
| 4797 | ret = __ext4_get_inode_loc(inode, &iloc, 0); | 4756 | ret = __ext4_get_inode_loc(inode, &iloc, 0); |
| 4798 | if (ret < 0) | 4757 | if (ret < 0) |
| 4799 | goto bad_inode; | 4758 | goto bad_inode; |
| 4800 | bh = iloc.bh; | ||
| 4801 | raw_inode = ext4_raw_inode(&iloc); | 4759 | raw_inode = ext4_raw_inode(&iloc); |
| 4802 | inode->i_mode = le16_to_cpu(raw_inode->i_mode); | 4760 | inode->i_mode = le16_to_cpu(raw_inode->i_mode); |
| 4803 | inode->i_uid = (uid_t)le16_to_cpu(raw_inode->i_uid_low); | 4761 | inode->i_uid = (uid_t)le16_to_cpu(raw_inode->i_uid_low); |
| @@ -4820,7 +4778,6 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4820 | if (inode->i_mode == 0 || | 4778 | if (inode->i_mode == 0 || |
| 4821 | !(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_ORPHAN_FS)) { | 4779 | !(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_ORPHAN_FS)) { |
| 4822 | /* this inode is deleted */ | 4780 | /* this inode is deleted */ |
| 4823 | brelse(bh); | ||
| 4824 | ret = -ESTALE; | 4781 | ret = -ESTALE; |
| 4825 | goto bad_inode; | 4782 | goto bad_inode; |
| 4826 | } | 4783 | } |
| @@ -4848,11 +4805,35 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4848 | ei->i_data[block] = raw_inode->i_block[block]; | 4805 | ei->i_data[block] = raw_inode->i_block[block]; |
| 4849 | INIT_LIST_HEAD(&ei->i_orphan); | 4806 | INIT_LIST_HEAD(&ei->i_orphan); |
| 4850 | 4807 | ||
| 4808 | /* | ||
| 4809 | * Set transaction id's of transactions that have to be committed | ||
| 4810 | * to finish f[data]sync. We set them to currently running transaction | ||
| 4811 | * as we cannot be sure that the inode or some of its metadata isn't | ||
| 4812 | * part of the transaction - the inode could have been reclaimed and | ||
| 4813 | * now it is reread from disk. | ||
| 4814 | */ | ||
| 4815 | if (journal) { | ||
| 4816 | transaction_t *transaction; | ||
| 4817 | tid_t tid; | ||
| 4818 | |||
| 4819 | spin_lock(&journal->j_state_lock); | ||
| 4820 | if (journal->j_running_transaction) | ||
| 4821 | transaction = journal->j_running_transaction; | ||
| 4822 | else | ||
| 4823 | transaction = journal->j_committing_transaction; | ||
| 4824 | if (transaction) | ||
| 4825 | tid = transaction->t_tid; | ||
| 4826 | else | ||
| 4827 | tid = journal->j_commit_sequence; | ||
| 4828 | spin_unlock(&journal->j_state_lock); | ||
| 4829 | ei->i_sync_tid = tid; | ||
| 4830 | ei->i_datasync_tid = tid; | ||
| 4831 | } | ||
| 4832 | |||
| 4851 | if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) { | 4833 | if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) { |
| 4852 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); | 4834 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); |
| 4853 | if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > | 4835 | if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > |
| 4854 | EXT4_INODE_SIZE(inode->i_sb)) { | 4836 | EXT4_INODE_SIZE(inode->i_sb)) { |
| 4855 | brelse(bh); | ||
| 4856 | ret = -EIO; | 4837 | ret = -EIO; |
| 4857 | goto bad_inode; | 4838 | goto bad_inode; |
| 4858 | } | 4839 | } |
| @@ -4884,10 +4865,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4884 | 4865 | ||
| 4885 | ret = 0; | 4866 | ret = 0; |
| 4886 | if (ei->i_file_acl && | 4867 | if (ei->i_file_acl && |
| 4887 | ((ei->i_file_acl < | 4868 | !ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) { |
| 4888 | (le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block) + | ||
| 4889 | EXT4_SB(sb)->s_gdb_count)) || | ||
| 4890 | (ei->i_file_acl >= ext4_blocks_count(EXT4_SB(sb)->s_es)))) { | ||
| 4891 | ext4_error(sb, __func__, | 4869 | ext4_error(sb, __func__, |
| 4892 | "bad extended attribute block %llu in inode #%lu", | 4870 | "bad extended attribute block %llu in inode #%lu", |
| 4893 | ei->i_file_acl, inode->i_ino); | 4871 | ei->i_file_acl, inode->i_ino); |
| @@ -4905,10 +4883,8 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4905 | /* Validate block references which are part of inode */ | 4883 | /* Validate block references which are part of inode */ |
| 4906 | ret = ext4_check_inode_blockref(inode); | 4884 | ret = ext4_check_inode_blockref(inode); |
| 4907 | } | 4885 | } |
| 4908 | if (ret) { | 4886 | if (ret) |
| 4909 | brelse(bh); | ||
| 4910 | goto bad_inode; | 4887 | goto bad_inode; |
| 4911 | } | ||
| 4912 | 4888 | ||
| 4913 | if (S_ISREG(inode->i_mode)) { | 4889 | if (S_ISREG(inode->i_mode)) { |
| 4914 | inode->i_op = &ext4_file_inode_operations; | 4890 | inode->i_op = &ext4_file_inode_operations; |
| @@ -4936,7 +4912,6 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4936 | init_special_inode(inode, inode->i_mode, | 4912 | init_special_inode(inode, inode->i_mode, |
| 4937 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); | 4913 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); |
| 4938 | } else { | 4914 | } else { |
| 4939 | brelse(bh); | ||
| 4940 | ret = -EIO; | 4915 | ret = -EIO; |
| 4941 | ext4_error(inode->i_sb, __func__, | 4916 | ext4_error(inode->i_sb, __func__, |
| 4942 | "bogus i_mode (%o) for inode=%lu", | 4917 | "bogus i_mode (%o) for inode=%lu", |
| @@ -4949,6 +4924,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
| 4949 | return inode; | 4924 | return inode; |
| 4950 | 4925 | ||
| 4951 | bad_inode: | 4926 | bad_inode: |
| 4927 | brelse(iloc.bh); | ||
| 4952 | iget_failed(inode); | 4928 | iget_failed(inode); |
| 4953 | return ERR_PTR(ret); | 4929 | return ERR_PTR(ret); |
| 4954 | } | 4930 | } |
| @@ -5108,6 +5084,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
| 5108 | err = rc; | 5084 | err = rc; |
| 5109 | ei->i_state &= ~EXT4_STATE_NEW; | 5085 | ei->i_state &= ~EXT4_STATE_NEW; |
| 5110 | 5086 | ||
| 5087 | ext4_update_inode_fsync_trans(handle, inode, 0); | ||
| 5111 | out_brelse: | 5088 | out_brelse: |
| 5112 | brelse(bh); | 5089 | brelse(bh); |
| 5113 | ext4_std_error(inode->i_sb, err); | 5090 | ext4_std_error(inode->i_sb, err); |
| @@ -5227,8 +5204,8 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 5227 | 5204 | ||
| 5228 | /* (user+group)*(old+new) structure, inode write (sb, | 5205 | /* (user+group)*(old+new) structure, inode write (sb, |
| 5229 | * inode block, ? - but truncate inode update has it) */ | 5206 | * inode block, ? - but truncate inode update has it) */ |
| 5230 | handle = ext4_journal_start(inode, 2*(EXT4_QUOTA_INIT_BLOCKS(inode->i_sb)+ | 5207 | handle = ext4_journal_start(inode, (EXT4_MAXQUOTAS_INIT_BLOCKS(inode->i_sb)+ |
| 5231 | EXT4_QUOTA_DEL_BLOCKS(inode->i_sb))+3); | 5208 | EXT4_MAXQUOTAS_DEL_BLOCKS(inode->i_sb))+3); |
| 5232 | if (IS_ERR(handle)) { | 5209 | if (IS_ERR(handle)) { |
| 5233 | error = PTR_ERR(handle); | 5210 | error = PTR_ERR(handle); |
| 5234 | goto err_out; | 5211 | goto err_out; |
| @@ -5376,7 +5353,7 @@ static int ext4_index_trans_blocks(struct inode *inode, int nrblocks, int chunk) | |||
| 5376 | * worse case, the indexs blocks spread over different block groups | 5353 | * worse case, the indexs blocks spread over different block groups |
| 5377 | * | 5354 | * |
| 5378 | * If datablocks are discontiguous, they are possible to spread over | 5355 | * If datablocks are discontiguous, they are possible to spread over |
| 5379 | * different block groups too. If they are contiugous, with flexbg, | 5356 | * different block groups too. If they are contiuguous, with flexbg, |
| 5380 | * they could still across block group boundary. | 5357 | * they could still across block group boundary. |
| 5381 | * | 5358 | * |
| 5382 | * Also account for superblock, inode, quota and xattr blocks | 5359 | * Also account for superblock, inode, quota and xattr blocks |
| @@ -5452,7 +5429,7 @@ int ext4_writepage_trans_blocks(struct inode *inode) | |||
| 5452 | * Calculate the journal credits for a chunk of data modification. | 5429 | * Calculate the journal credits for a chunk of data modification. |
| 5453 | * | 5430 | * |
| 5454 | * This is called from DIO, fallocate or whoever calling | 5431 | * This is called from DIO, fallocate or whoever calling |
| 5455 | * ext4_get_blocks() to map/allocate a chunk of contigous disk blocks. | 5432 | * ext4_get_blocks() to map/allocate a chunk of contiguous disk blocks. |
| 5456 | * | 5433 | * |
| 5457 | * journal buffers for data blocks are not included here, as DIO | 5434 | * journal buffers for data blocks are not included here, as DIO |
| 5458 | * and fallocate do no need to journal data buffers. | 5435 | * and fallocate do no need to journal data buffers. |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index c1cdf613e725..b63d193126db 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
| @@ -221,31 +221,38 @@ setversion_out: | |||
| 221 | struct file *donor_filp; | 221 | struct file *donor_filp; |
| 222 | int err; | 222 | int err; |
| 223 | 223 | ||
| 224 | if (!(filp->f_mode & FMODE_READ) || | ||
| 225 | !(filp->f_mode & FMODE_WRITE)) | ||
| 226 | return -EBADF; | ||
| 227 | |||
| 224 | if (copy_from_user(&me, | 228 | if (copy_from_user(&me, |
| 225 | (struct move_extent __user *)arg, sizeof(me))) | 229 | (struct move_extent __user *)arg, sizeof(me))) |
| 226 | return -EFAULT; | 230 | return -EFAULT; |
| 231 | me.moved_len = 0; | ||
| 227 | 232 | ||
| 228 | donor_filp = fget(me.donor_fd); | 233 | donor_filp = fget(me.donor_fd); |
| 229 | if (!donor_filp) | 234 | if (!donor_filp) |
| 230 | return -EBADF; | 235 | return -EBADF; |
| 231 | 236 | ||
| 232 | if (!capable(CAP_DAC_OVERRIDE)) { | 237 | if (!(donor_filp->f_mode & FMODE_WRITE)) { |
| 233 | if ((current->real_cred->fsuid != inode->i_uid) || | 238 | err = -EBADF; |
| 234 | !(inode->i_mode & S_IRUSR) || | 239 | goto mext_out; |
| 235 | !(donor_filp->f_dentry->d_inode->i_mode & | ||
| 236 | S_IRUSR)) { | ||
| 237 | fput(donor_filp); | ||
| 238 | return -EACCES; | ||
| 239 | } | ||
| 240 | } | 240 | } |
| 241 | 241 | ||
| 242 | err = mnt_want_write(filp->f_path.mnt); | ||
| 243 | if (err) | ||
| 244 | goto mext_out; | ||
| 245 | |||
| 242 | err = ext4_move_extents(filp, donor_filp, me.orig_start, | 246 | err = ext4_move_extents(filp, donor_filp, me.orig_start, |
| 243 | me.donor_start, me.len, &me.moved_len); | 247 | me.donor_start, me.len, &me.moved_len); |
| 244 | fput(donor_filp); | 248 | mnt_drop_write(filp->f_path.mnt); |
| 249 | if (me.moved_len > 0) | ||
| 250 | file_remove_suid(donor_filp); | ||
| 245 | 251 | ||
| 246 | if (copy_to_user((struct move_extent *)arg, &me, sizeof(me))) | 252 | if (copy_to_user((struct move_extent *)arg, &me, sizeof(me))) |
| 247 | return -EFAULT; | 253 | err = -EFAULT; |
| 248 | 254 | mext_out: | |
| 255 | fput(donor_filp); | ||
| 249 | return err; | 256 | return err; |
| 250 | } | 257 | } |
| 251 | 258 | ||
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index bba12824defa..b1fd3daadc9c 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
| @@ -142,7 +142,7 @@ | |||
| 142 | * 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The | 142 | * 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The |
| 143 | * value of s_mb_order2_reqs can be tuned via | 143 | * value of s_mb_order2_reqs can be tuned via |
| 144 | * /sys/fs/ext4/<partition>/mb_order2_req. If the request len is equal to | 144 | * /sys/fs/ext4/<partition>/mb_order2_req. If the request len is equal to |
| 145 | * stripe size (sbi->s_stripe), we try to search for contigous block in | 145 | * stripe size (sbi->s_stripe), we try to search for contiguous block in |
| 146 | * stripe size. This should result in better allocation on RAID setups. If | 146 | * stripe size. This should result in better allocation on RAID setups. If |
| 147 | * not, we search in the specific group using bitmap for best extents. The | 147 | * not, we search in the specific group using bitmap for best extents. The |
| 148 | * tunable min_to_scan and max_to_scan control the behaviour here. | 148 | * tunable min_to_scan and max_to_scan control the behaviour here. |
| @@ -2529,7 +2529,6 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) | |||
| 2529 | struct ext4_group_info *db; | 2529 | struct ext4_group_info *db; |
| 2530 | int err, count = 0, count2 = 0; | 2530 | int err, count = 0, count2 = 0; |
| 2531 | struct ext4_free_data *entry; | 2531 | struct ext4_free_data *entry; |
| 2532 | ext4_fsblk_t discard_block; | ||
| 2533 | struct list_head *l, *ltmp; | 2532 | struct list_head *l, *ltmp; |
| 2534 | 2533 | ||
| 2535 | list_for_each_safe(l, ltmp, &txn->t_private_list) { | 2534 | list_for_each_safe(l, ltmp, &txn->t_private_list) { |
| @@ -2559,13 +2558,19 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) | |||
| 2559 | page_cache_release(e4b.bd_bitmap_page); | 2558 | page_cache_release(e4b.bd_bitmap_page); |
| 2560 | } | 2559 | } |
| 2561 | ext4_unlock_group(sb, entry->group); | 2560 | ext4_unlock_group(sb, entry->group); |
| 2562 | discard_block = (ext4_fsblk_t) entry->group * EXT4_BLOCKS_PER_GROUP(sb) | 2561 | if (test_opt(sb, DISCARD)) { |
| 2563 | + entry->start_blk | 2562 | ext4_fsblk_t discard_block; |
| 2564 | + le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | 2563 | struct ext4_super_block *es = EXT4_SB(sb)->s_es; |
| 2565 | trace_ext4_discard_blocks(sb, (unsigned long long)discard_block, | 2564 | |
| 2566 | entry->count); | 2565 | discard_block = (ext4_fsblk_t)entry->group * |
| 2567 | sb_issue_discard(sb, discard_block, entry->count); | 2566 | EXT4_BLOCKS_PER_GROUP(sb) |
| 2568 | 2567 | + entry->start_blk | |
| 2568 | + le32_to_cpu(es->s_first_data_block); | ||
| 2569 | trace_ext4_discard_blocks(sb, | ||
| 2570 | (unsigned long long)discard_block, | ||
| 2571 | entry->count); | ||
| 2572 | sb_issue_discard(sb, discard_block, entry->count); | ||
| 2573 | } | ||
| 2569 | kmem_cache_free(ext4_free_ext_cachep, entry); | 2574 | kmem_cache_free(ext4_free_ext_cachep, entry); |
| 2570 | ext4_mb_release_desc(&e4b); | 2575 | ext4_mb_release_desc(&e4b); |
| 2571 | } | 2576 | } |
| @@ -3006,6 +3011,24 @@ static void ext4_mb_collect_stats(struct ext4_allocation_context *ac) | |||
| 3006 | } | 3011 | } |
| 3007 | 3012 | ||
| 3008 | /* | 3013 | /* |
| 3014 | * Called on failure; free up any blocks from the inode PA for this | ||
| 3015 | * context. We don't need this for MB_GROUP_PA because we only change | ||
| 3016 | * pa_free in ext4_mb_release_context(), but on failure, we've already | ||
| 3017 | * zeroed out ac->ac_b_ex.fe_len, so group_pa->pa_free is not changed. | ||
| 3018 | */ | ||
| 3019 | static void ext4_discard_allocated_blocks(struct ext4_allocation_context *ac) | ||
| 3020 | { | ||
| 3021 | struct ext4_prealloc_space *pa = ac->ac_pa; | ||
| 3022 | int len; | ||
| 3023 | |||
| 3024 | if (pa && pa->pa_type == MB_INODE_PA) { | ||
| 3025 | len = ac->ac_b_ex.fe_len; | ||
| 3026 | pa->pa_free += len; | ||
| 3027 | } | ||
| 3028 | |||
| 3029 | } | ||
| 3030 | |||
| 3031 | /* | ||
| 3009 | * use blocks preallocated to inode | 3032 | * use blocks preallocated to inode |
| 3010 | */ | 3033 | */ |
| 3011 | static void ext4_mb_use_inode_pa(struct ext4_allocation_context *ac, | 3034 | static void ext4_mb_use_inode_pa(struct ext4_allocation_context *ac, |
| @@ -3932,7 +3955,7 @@ static void ext4_mb_group_or_file(struct ext4_allocation_context *ac) | |||
| 3932 | * per cpu locality group is to reduce the contention between block | 3955 | * per cpu locality group is to reduce the contention between block |
| 3933 | * request from multiple CPUs. | 3956 | * request from multiple CPUs. |
| 3934 | */ | 3957 | */ |
| 3935 | ac->ac_lg = per_cpu_ptr(sbi->s_locality_groups, raw_smp_processor_id()); | 3958 | ac->ac_lg = __this_cpu_ptr(sbi->s_locality_groups); |
| 3936 | 3959 | ||
| 3937 | /* we're going to use group allocation */ | 3960 | /* we're going to use group allocation */ |
| 3938 | ac->ac_flags |= EXT4_MB_HINT_GROUP_ALLOC; | 3961 | ac->ac_flags |= EXT4_MB_HINT_GROUP_ALLOC; |
| @@ -4290,6 +4313,7 @@ repeat: | |||
| 4290 | ac->ac_status = AC_STATUS_CONTINUE; | 4313 | ac->ac_status = AC_STATUS_CONTINUE; |
| 4291 | goto repeat; | 4314 | goto repeat; |
| 4292 | } else if (*errp) { | 4315 | } else if (*errp) { |
| 4316 | ext4_discard_allocated_blocks(ac); | ||
| 4293 | ac->ac_b_ex.fe_len = 0; | 4317 | ac->ac_b_ex.fe_len = 0; |
| 4294 | ar->len = 0; | 4318 | ar->len = 0; |
| 4295 | ext4_mb_show_ac(ac); | 4319 | ext4_mb_show_ac(ac); |
| @@ -4422,18 +4446,24 @@ ext4_mb_free_metadata(handle_t *handle, struct ext4_buddy *e4b, | |||
| 4422 | return 0; | 4446 | return 0; |
| 4423 | } | 4447 | } |
| 4424 | 4448 | ||
| 4425 | /* | 4449 | /** |
| 4426 | * Main entry point into mballoc to free blocks | 4450 | * ext4_free_blocks() -- Free given blocks and update quota |
| 4451 | * @handle: handle for this transaction | ||
| 4452 | * @inode: inode | ||
| 4453 | * @block: start physical block to free | ||
| 4454 | * @count: number of blocks to count | ||
| 4455 | * @metadata: Are these metadata blocks | ||
| 4427 | */ | 4456 | */ |
| 4428 | void ext4_mb_free_blocks(handle_t *handle, struct inode *inode, | 4457 | void ext4_free_blocks(handle_t *handle, struct inode *inode, |
| 4429 | ext4_fsblk_t block, unsigned long count, | 4458 | struct buffer_head *bh, ext4_fsblk_t block, |
| 4430 | int metadata, unsigned long *freed) | 4459 | unsigned long count, int flags) |
| 4431 | { | 4460 | { |
| 4432 | struct buffer_head *bitmap_bh = NULL; | 4461 | struct buffer_head *bitmap_bh = NULL; |
| 4433 | struct super_block *sb = inode->i_sb; | 4462 | struct super_block *sb = inode->i_sb; |
| 4434 | struct ext4_allocation_context *ac = NULL; | 4463 | struct ext4_allocation_context *ac = NULL; |
| 4435 | struct ext4_group_desc *gdp; | 4464 | struct ext4_group_desc *gdp; |
| 4436 | struct ext4_super_block *es; | 4465 | struct ext4_super_block *es; |
| 4466 | unsigned long freed = 0; | ||
| 4437 | unsigned int overflow; | 4467 | unsigned int overflow; |
| 4438 | ext4_grpblk_t bit; | 4468 | ext4_grpblk_t bit; |
| 4439 | struct buffer_head *gd_bh; | 4469 | struct buffer_head *gd_bh; |
| @@ -4443,13 +4473,16 @@ void ext4_mb_free_blocks(handle_t *handle, struct inode *inode, | |||
| 4443 | int err = 0; | 4473 | int err = 0; |
| 4444 | int ret; | 4474 | int ret; |
| 4445 | 4475 | ||
| 4446 | *freed = 0; | 4476 | if (bh) { |
| 4477 | if (block) | ||
| 4478 | BUG_ON(block != bh->b_blocknr); | ||
| 4479 | else | ||
| 4480 | block = bh->b_blocknr; | ||
| 4481 | } | ||
| 4447 | 4482 | ||
| 4448 | sbi = EXT4_SB(sb); | 4483 | sbi = EXT4_SB(sb); |
| 4449 | es = EXT4_SB(sb)->s_es; | 4484 | es = EXT4_SB(sb)->s_es; |
| 4450 | if (block < le32_to_cpu(es->s_first_data_block) || | 4485 | if (!ext4_data_block_valid(sbi, block, count)) { |
| 4451 | block + count < block || | ||
| 4452 | block + count > ext4_blocks_count(es)) { | ||
| 4453 | ext4_error(sb, __func__, | 4486 | ext4_error(sb, __func__, |
| 4454 | "Freeing blocks not in datazone - " | 4487 | "Freeing blocks not in datazone - " |
| 4455 | "block = %llu, count = %lu", block, count); | 4488 | "block = %llu, count = %lu", block, count); |
| @@ -4457,7 +4490,32 @@ void ext4_mb_free_blocks(handle_t *handle, struct inode *inode, | |||
| 4457 | } | 4490 | } |
| 4458 | 4491 | ||
| 4459 | ext4_debug("freeing block %llu\n", block); | 4492 | ext4_debug("freeing block %llu\n", block); |
| 4460 | trace_ext4_free_blocks(inode, block, count, metadata); | 4493 | trace_ext4_free_blocks(inode, block, count, flags); |
| 4494 | |||
| 4495 | if (flags & EXT4_FREE_BLOCKS_FORGET) { | ||
| 4496 | struct buffer_head *tbh = bh; | ||
| 4497 | int i; | ||
| 4498 | |||
| 4499 | BUG_ON(bh && (count > 1)); | ||
| 4500 | |||
| 4501 | for (i = 0; i < count; i++) { | ||
| 4502 | if (!bh) | ||
| 4503 | tbh = sb_find_get_block(inode->i_sb, | ||
| 4504 | block + i); | ||
| 4505 | ext4_forget(handle, flags & EXT4_FREE_BLOCKS_METADATA, | ||
| 4506 | inode, tbh, block + i); | ||
| 4507 | } | ||
| 4508 | } | ||
| 4509 | |||
| 4510 | /* | ||
| 4511 | * We need to make sure we don't reuse the freed block until | ||
| 4512 | * after the transaction is committed, which we can do by | ||
| 4513 | * treating the block as metadata, below. We make an | ||
| 4514 | * exception if the inode is to be written in writeback mode | ||
| 4515 | * since writeback mode has weak data consistency guarantees. | ||
| 4516 | */ | ||
| 4517 | if (!ext4_should_writeback_data(inode)) | ||
| 4518 | flags |= EXT4_FREE_BLOCKS_METADATA; | ||
| 4461 | 4519 | ||
| 4462 | ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS); | 4520 | ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS); |
| 4463 | if (ac) { | 4521 | if (ac) { |
| @@ -4533,7 +4591,8 @@ do_more: | |||
| 4533 | err = ext4_mb_load_buddy(sb, block_group, &e4b); | 4591 | err = ext4_mb_load_buddy(sb, block_group, &e4b); |
| 4534 | if (err) | 4592 | if (err) |
| 4535 | goto error_return; | 4593 | goto error_return; |
| 4536 | if (metadata && ext4_handle_valid(handle)) { | 4594 | |
| 4595 | if ((flags & EXT4_FREE_BLOCKS_METADATA) && ext4_handle_valid(handle)) { | ||
| 4537 | struct ext4_free_data *new_entry; | 4596 | struct ext4_free_data *new_entry; |
| 4538 | /* | 4597 | /* |
| 4539 | * blocks being freed are metadata. these blocks shouldn't | 4598 | * blocks being freed are metadata. these blocks shouldn't |
| @@ -4572,7 +4631,7 @@ do_more: | |||
| 4572 | 4631 | ||
| 4573 | ext4_mb_release_desc(&e4b); | 4632 | ext4_mb_release_desc(&e4b); |
| 4574 | 4633 | ||
| 4575 | *freed += count; | 4634 | freed += count; |
| 4576 | 4635 | ||
| 4577 | /* We dirtied the bitmap block */ | 4636 | /* We dirtied the bitmap block */ |
| 4578 | BUFFER_TRACE(bitmap_bh, "dirtied bitmap block"); | 4637 | BUFFER_TRACE(bitmap_bh, "dirtied bitmap block"); |
| @@ -4592,6 +4651,8 @@ do_more: | |||
| 4592 | } | 4651 | } |
| 4593 | sb->s_dirt = 1; | 4652 | sb->s_dirt = 1; |
| 4594 | error_return: | 4653 | error_return: |
| 4654 | if (freed) | ||
| 4655 | vfs_dq_free_block(inode, freed); | ||
| 4595 | brelse(bitmap_bh); | 4656 | brelse(bitmap_bh); |
| 4596 | ext4_std_error(sb, err); | 4657 | ext4_std_error(sb, err); |
| 4597 | if (ac) | 4658 | if (ac) |
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c index a93d5b80f3e2..81415814b00b 100644 --- a/fs/ext4/migrate.c +++ b/fs/ext4/migrate.c | |||
| @@ -238,7 +238,7 @@ static int extend_credit_for_blkdel(handle_t *handle, struct inode *inode) | |||
| 238 | * So allocate a credit of 3. We may update | 238 | * So allocate a credit of 3. We may update |
| 239 | * quota (user and group). | 239 | * quota (user and group). |
| 240 | */ | 240 | */ |
| 241 | needed = 3 + 2*EXT4_QUOTA_TRANS_BLOCKS(inode->i_sb); | 241 | needed = 3 + EXT4_MAXQUOTAS_TRANS_BLOCKS(inode->i_sb); |
| 242 | 242 | ||
| 243 | if (ext4_journal_extend(handle, needed) != 0) | 243 | if (ext4_journal_extend(handle, needed) != 0) |
| 244 | retval = ext4_journal_restart(handle, needed); | 244 | retval = ext4_journal_restart(handle, needed); |
| @@ -262,13 +262,17 @@ static int free_dind_blocks(handle_t *handle, | |||
| 262 | for (i = 0; i < max_entries; i++) { | 262 | for (i = 0; i < max_entries; i++) { |
| 263 | if (tmp_idata[i]) { | 263 | if (tmp_idata[i]) { |
| 264 | extend_credit_for_blkdel(handle, inode); | 264 | extend_credit_for_blkdel(handle, inode); |
| 265 | ext4_free_blocks(handle, inode, | 265 | ext4_free_blocks(handle, inode, 0, |
| 266 | le32_to_cpu(tmp_idata[i]), 1, 1); | 266 | le32_to_cpu(tmp_idata[i]), 1, |
| 267 | EXT4_FREE_BLOCKS_METADATA | | ||
| 268 | EXT4_FREE_BLOCKS_FORGET); | ||
| 267 | } | 269 | } |
| 268 | } | 270 | } |
| 269 | put_bh(bh); | 271 | put_bh(bh); |
| 270 | extend_credit_for_blkdel(handle, inode); | 272 | extend_credit_for_blkdel(handle, inode); |
| 271 | ext4_free_blocks(handle, inode, le32_to_cpu(i_data), 1, 1); | 273 | ext4_free_blocks(handle, inode, 0, le32_to_cpu(i_data), 1, |
| 274 | EXT4_FREE_BLOCKS_METADATA | | ||
| 275 | EXT4_FREE_BLOCKS_FORGET); | ||
| 272 | return 0; | 276 | return 0; |
| 273 | } | 277 | } |
| 274 | 278 | ||
| @@ -297,7 +301,9 @@ static int free_tind_blocks(handle_t *handle, | |||
| 297 | } | 301 | } |
| 298 | put_bh(bh); | 302 | put_bh(bh); |
| 299 | extend_credit_for_blkdel(handle, inode); | 303 | extend_credit_for_blkdel(handle, inode); |
| 300 | ext4_free_blocks(handle, inode, le32_to_cpu(i_data), 1, 1); | 304 | ext4_free_blocks(handle, inode, 0, le32_to_cpu(i_data), 1, |
| 305 | EXT4_FREE_BLOCKS_METADATA | | ||
| 306 | EXT4_FREE_BLOCKS_FORGET); | ||
| 301 | return 0; | 307 | return 0; |
| 302 | } | 308 | } |
| 303 | 309 | ||
| @@ -308,8 +314,10 @@ static int free_ind_block(handle_t *handle, struct inode *inode, __le32 *i_data) | |||
| 308 | /* ei->i_data[EXT4_IND_BLOCK] */ | 314 | /* ei->i_data[EXT4_IND_BLOCK] */ |
| 309 | if (i_data[0]) { | 315 | if (i_data[0]) { |
| 310 | extend_credit_for_blkdel(handle, inode); | 316 | extend_credit_for_blkdel(handle, inode); |
| 311 | ext4_free_blocks(handle, inode, | 317 | ext4_free_blocks(handle, inode, 0, |
| 312 | le32_to_cpu(i_data[0]), 1, 1); | 318 | le32_to_cpu(i_data[0]), 1, |
| 319 | EXT4_FREE_BLOCKS_METADATA | | ||
| 320 | EXT4_FREE_BLOCKS_FORGET); | ||
| 313 | } | 321 | } |
| 314 | 322 | ||
| 315 | /* ei->i_data[EXT4_DIND_BLOCK] */ | 323 | /* ei->i_data[EXT4_DIND_BLOCK] */ |
| @@ -419,7 +427,8 @@ static int free_ext_idx(handle_t *handle, struct inode *inode, | |||
| 419 | } | 427 | } |
| 420 | put_bh(bh); | 428 | put_bh(bh); |
| 421 | extend_credit_for_blkdel(handle, inode); | 429 | extend_credit_for_blkdel(handle, inode); |
| 422 | ext4_free_blocks(handle, inode, block, 1, 1); | 430 | ext4_free_blocks(handle, inode, 0, block, 1, |
| 431 | EXT4_FREE_BLOCKS_METADATA | EXT4_FREE_BLOCKS_FORGET); | ||
| 423 | return retval; | 432 | return retval; |
| 424 | } | 433 | } |
| 425 | 434 | ||
| @@ -477,7 +486,7 @@ int ext4_ext_migrate(struct inode *inode) | |||
| 477 | handle = ext4_journal_start(inode, | 486 | handle = ext4_journal_start(inode, |
| 478 | EXT4_DATA_TRANS_BLOCKS(inode->i_sb) + | 487 | EXT4_DATA_TRANS_BLOCKS(inode->i_sb) + |
| 479 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 488 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
| 480 | 2 * EXT4_QUOTA_INIT_BLOCKS(inode->i_sb) | 489 | EXT4_MAXQUOTAS_INIT_BLOCKS(inode->i_sb) |
| 481 | + 1); | 490 | + 1); |
| 482 | if (IS_ERR(handle)) { | 491 | if (IS_ERR(handle)) { |
| 483 | retval = PTR_ERR(handle); | 492 | retval = PTR_ERR(handle); |
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 25b6b1457360..82c415be87a4 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c | |||
| @@ -77,12 +77,14 @@ static int | |||
| 77 | mext_next_extent(struct inode *inode, struct ext4_ext_path *path, | 77 | mext_next_extent(struct inode *inode, struct ext4_ext_path *path, |
| 78 | struct ext4_extent **extent) | 78 | struct ext4_extent **extent) |
| 79 | { | 79 | { |
| 80 | struct ext4_extent_header *eh; | ||
| 80 | int ppos, leaf_ppos = path->p_depth; | 81 | int ppos, leaf_ppos = path->p_depth; |
| 81 | 82 | ||
| 82 | ppos = leaf_ppos; | 83 | ppos = leaf_ppos; |
| 83 | if (EXT_LAST_EXTENT(path[ppos].p_hdr) > path[ppos].p_ext) { | 84 | if (EXT_LAST_EXTENT(path[ppos].p_hdr) > path[ppos].p_ext) { |
| 84 | /* leaf block */ | 85 | /* leaf block */ |
| 85 | *extent = ++path[ppos].p_ext; | 86 | *extent = ++path[ppos].p_ext; |
| 87 | path[ppos].p_block = ext_pblock(path[ppos].p_ext); | ||
| 86 | return 0; | 88 | return 0; |
| 87 | } | 89 | } |
| 88 | 90 | ||
| @@ -119,9 +121,18 @@ mext_next_extent(struct inode *inode, struct ext4_ext_path *path, | |||
| 119 | ext_block_hdr(path[cur_ppos+1].p_bh); | 121 | ext_block_hdr(path[cur_ppos+1].p_bh); |
| 120 | } | 122 | } |
| 121 | 123 | ||
| 124 | path[leaf_ppos].p_ext = *extent = NULL; | ||
| 125 | |||
| 126 | eh = path[leaf_ppos].p_hdr; | ||
| 127 | if (le16_to_cpu(eh->eh_entries) == 0) | ||
| 128 | /* empty leaf is found */ | ||
| 129 | return -ENODATA; | ||
| 130 | |||
| 122 | /* leaf block */ | 131 | /* leaf block */ |
| 123 | path[leaf_ppos].p_ext = *extent = | 132 | path[leaf_ppos].p_ext = *extent = |
| 124 | EXT_FIRST_EXTENT(path[leaf_ppos].p_hdr); | 133 | EXT_FIRST_EXTENT(path[leaf_ppos].p_hdr); |
| 134 | path[leaf_ppos].p_block = | ||
| 135 | ext_pblock(path[leaf_ppos].p_ext); | ||
| 125 | return 0; | 136 | return 0; |
| 126 | } | 137 | } |
| 127 | } | 138 | } |
| @@ -155,40 +166,15 @@ mext_check_null_inode(struct inode *inode1, struct inode *inode2, | |||
| 155 | } | 166 | } |
| 156 | 167 | ||
| 157 | /** | 168 | /** |
| 158 | * mext_double_down_read - Acquire two inodes' read semaphore | 169 | * double_down_write_data_sem - Acquire two inodes' write lock of i_data_sem |
| 159 | * | ||
| 160 | * @orig_inode: original inode structure | ||
| 161 | * @donor_inode: donor inode structure | ||
| 162 | * Acquire read semaphore of the two inodes (orig and donor) by i_ino order. | ||
| 163 | */ | ||
| 164 | static void | ||
| 165 | mext_double_down_read(struct inode *orig_inode, struct inode *donor_inode) | ||
| 166 | { | ||
| 167 | struct inode *first = orig_inode, *second = donor_inode; | ||
| 168 | |||
| 169 | /* | ||
| 170 | * Use the inode number to provide the stable locking order instead | ||
| 171 | * of its address, because the C language doesn't guarantee you can | ||
| 172 | * compare pointers that don't come from the same array. | ||
| 173 | */ | ||
| 174 | if (donor_inode->i_ino < orig_inode->i_ino) { | ||
| 175 | first = donor_inode; | ||
| 176 | second = orig_inode; | ||
| 177 | } | ||
| 178 | |||
| 179 | down_read(&EXT4_I(first)->i_data_sem); | ||
| 180 | down_read(&EXT4_I(second)->i_data_sem); | ||
| 181 | } | ||
| 182 | |||
| 183 | /** | ||
| 184 | * mext_double_down_write - Acquire two inodes' write semaphore | ||
| 185 | * | 170 | * |
| 186 | * @orig_inode: original inode structure | 171 | * @orig_inode: original inode structure |
| 187 | * @donor_inode: donor inode structure | 172 | * @donor_inode: donor inode structure |
| 188 | * Acquire write semaphore of the two inodes (orig and donor) by i_ino order. | 173 | * Acquire write lock of i_data_sem of the two inodes (orig and donor) by |
| 174 | * i_ino order. | ||
| 189 | */ | 175 | */ |
| 190 | static void | 176 | static void |
| 191 | mext_double_down_write(struct inode *orig_inode, struct inode *donor_inode) | 177 | double_down_write_data_sem(struct inode *orig_inode, struct inode *donor_inode) |
| 192 | { | 178 | { |
| 193 | struct inode *first = orig_inode, *second = donor_inode; | 179 | struct inode *first = orig_inode, *second = donor_inode; |
| 194 | 180 | ||
| @@ -203,32 +189,18 @@ mext_double_down_write(struct inode *orig_inode, struct inode *donor_inode) | |||
| 203 | } | 189 | } |
| 204 | 190 | ||
| 205 | down_write(&EXT4_I(first)->i_data_sem); | 191 | down_write(&EXT4_I(first)->i_data_sem); |
| 206 | down_write(&EXT4_I(second)->i_data_sem); | 192 | down_write_nested(&EXT4_I(second)->i_data_sem, SINGLE_DEPTH_NESTING); |
| 207 | } | 193 | } |
| 208 | 194 | ||
| 209 | /** | 195 | /** |
| 210 | * mext_double_up_read - Release two inodes' read semaphore | 196 | * double_up_write_data_sem - Release two inodes' write lock of i_data_sem |
| 211 | * | 197 | * |
| 212 | * @orig_inode: original inode structure to be released its lock first | 198 | * @orig_inode: original inode structure to be released its lock first |
| 213 | * @donor_inode: donor inode structure to be released its lock second | 199 | * @donor_inode: donor inode structure to be released its lock second |
| 214 | * Release read semaphore of two inodes (orig and donor). | 200 | * Release write lock of i_data_sem of two inodes (orig and donor). |
| 215 | */ | 201 | */ |
| 216 | static void | 202 | static void |
| 217 | mext_double_up_read(struct inode *orig_inode, struct inode *donor_inode) | 203 | double_up_write_data_sem(struct inode *orig_inode, struct inode *donor_inode) |
| 218 | { | ||
| 219 | up_read(&EXT4_I(orig_inode)->i_data_sem); | ||
| 220 | up_read(&EXT4_I(donor_inode)->i_data_sem); | ||
| 221 | } | ||
| 222 | |||
| 223 | /** | ||
| 224 | * mext_double_up_write - Release two inodes' write semaphore | ||
| 225 | * | ||
| 226 | * @orig_inode: original inode structure to be released its lock first | ||
| 227 | * @donor_inode: donor inode structure to be released its lock second | ||
| 228 | * Release write semaphore of two inodes (orig and donor). | ||
| 229 | */ | ||
| 230 | static void | ||
| 231 | mext_double_up_write(struct inode *orig_inode, struct inode *donor_inode) | ||
| 232 | { | 204 | { |
| 233 | up_write(&EXT4_I(orig_inode)->i_data_sem); | 205 | up_write(&EXT4_I(orig_inode)->i_data_sem); |
| 234 | up_write(&EXT4_I(donor_inode)->i_data_sem); | 206 | up_write(&EXT4_I(donor_inode)->i_data_sem); |
| @@ -596,7 +568,7 @@ out: | |||
| 596 | * @tmp_oext: the extent that will belong to the donor inode | 568 | * @tmp_oext: the extent that will belong to the donor inode |
| 597 | * @orig_off: block offset of original inode | 569 | * @orig_off: block offset of original inode |
| 598 | * @donor_off: block offset of donor inode | 570 | * @donor_off: block offset of donor inode |
| 599 | * @max_count: the maximun length of extents | 571 | * @max_count: the maximum length of extents |
| 600 | * | 572 | * |
| 601 | * Return 0 on success, or a negative error value on failure. | 573 | * Return 0 on success, or a negative error value on failure. |
| 602 | */ | 574 | */ |
| @@ -661,6 +633,7 @@ mext_calc_swap_extents(struct ext4_extent *tmp_dext, | |||
| 661 | * @donor_inode: donor inode | 633 | * @donor_inode: donor inode |
| 662 | * @from: block offset of orig_inode | 634 | * @from: block offset of orig_inode |
| 663 | * @count: block count to be replaced | 635 | * @count: block count to be replaced |
| 636 | * @err: pointer to save return value | ||
| 664 | * | 637 | * |
| 665 | * Replace original inode extents and donor inode extents page by page. | 638 | * Replace original inode extents and donor inode extents page by page. |
| 666 | * We implement this replacement in the following three steps: | 639 | * We implement this replacement in the following three steps: |
| @@ -671,33 +644,33 @@ mext_calc_swap_extents(struct ext4_extent *tmp_dext, | |||
| 671 | * 3. Change the block information of donor inode to point at the saved | 644 | * 3. Change the block information of donor inode to point at the saved |
| 672 | * original inode blocks in the dummy extents. | 645 | * original inode blocks in the dummy extents. |
| 673 | * | 646 | * |
| 674 | * Return 0 on success, or a negative error value on failure. | 647 | * Return replaced block count. |
| 675 | */ | 648 | */ |
| 676 | static int | 649 | static int |
| 677 | mext_replace_branches(handle_t *handle, struct inode *orig_inode, | 650 | mext_replace_branches(handle_t *handle, struct inode *orig_inode, |
| 678 | struct inode *donor_inode, ext4_lblk_t from, | 651 | struct inode *donor_inode, ext4_lblk_t from, |
| 679 | ext4_lblk_t count) | 652 | ext4_lblk_t count, int *err) |
| 680 | { | 653 | { |
| 681 | struct ext4_ext_path *orig_path = NULL; | 654 | struct ext4_ext_path *orig_path = NULL; |
| 682 | struct ext4_ext_path *donor_path = NULL; | 655 | struct ext4_ext_path *donor_path = NULL; |
| 683 | struct ext4_extent *oext, *dext; | 656 | struct ext4_extent *oext, *dext; |
| 684 | struct ext4_extent tmp_dext, tmp_oext; | 657 | struct ext4_extent tmp_dext, tmp_oext; |
| 685 | ext4_lblk_t orig_off = from, donor_off = from; | 658 | ext4_lblk_t orig_off = from, donor_off = from; |
| 686 | int err = 0; | ||
| 687 | int depth; | 659 | int depth; |
| 688 | int replaced_count = 0; | 660 | int replaced_count = 0; |
| 689 | int dext_alen; | 661 | int dext_alen; |
| 690 | 662 | ||
| 691 | mext_double_down_write(orig_inode, donor_inode); | 663 | /* Protect extent trees against block allocations via delalloc */ |
| 664 | double_down_write_data_sem(orig_inode, donor_inode); | ||
| 692 | 665 | ||
| 693 | /* Get the original extent for the block "orig_off" */ | 666 | /* Get the original extent for the block "orig_off" */ |
| 694 | err = get_ext_path(orig_inode, orig_off, &orig_path); | 667 | *err = get_ext_path(orig_inode, orig_off, &orig_path); |
| 695 | if (err) | 668 | if (*err) |
| 696 | goto out; | 669 | goto out; |
| 697 | 670 | ||
| 698 | /* Get the donor extent for the head */ | 671 | /* Get the donor extent for the head */ |
| 699 | err = get_ext_path(donor_inode, donor_off, &donor_path); | 672 | *err = get_ext_path(donor_inode, donor_off, &donor_path); |
| 700 | if (err) | 673 | if (*err) |
| 701 | goto out; | 674 | goto out; |
| 702 | depth = ext_depth(orig_inode); | 675 | depth = ext_depth(orig_inode); |
| 703 | oext = orig_path[depth].p_ext; | 676 | oext = orig_path[depth].p_ext; |
| @@ -707,9 +680,9 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
| 707 | dext = donor_path[depth].p_ext; | 680 | dext = donor_path[depth].p_ext; |
| 708 | tmp_dext = *dext; | 681 | tmp_dext = *dext; |
| 709 | 682 | ||
| 710 | err = mext_calc_swap_extents(&tmp_dext, &tmp_oext, orig_off, | 683 | *err = mext_calc_swap_extents(&tmp_dext, &tmp_oext, orig_off, |
| 711 | donor_off, count); | 684 | donor_off, count); |
| 712 | if (err) | 685 | if (*err) |
| 713 | goto out; | 686 | goto out; |
| 714 | 687 | ||
| 715 | /* Loop for the donor extents */ | 688 | /* Loop for the donor extents */ |
| @@ -718,7 +691,7 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
| 718 | if (!dext) { | 691 | if (!dext) { |
| 719 | ext4_error(donor_inode->i_sb, __func__, | 692 | ext4_error(donor_inode->i_sb, __func__, |
| 720 | "The extent for donor must be found"); | 693 | "The extent for donor must be found"); |
| 721 | err = -EIO; | 694 | *err = -EIO; |
| 722 | goto out; | 695 | goto out; |
| 723 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { | 696 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { |
| 724 | ext4_error(donor_inode->i_sb, __func__, | 697 | ext4_error(donor_inode->i_sb, __func__, |
| @@ -726,20 +699,20 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
| 726 | "extent(%u) should be equal", | 699 | "extent(%u) should be equal", |
| 727 | donor_off, | 700 | donor_off, |
| 728 | le32_to_cpu(tmp_dext.ee_block)); | 701 | le32_to_cpu(tmp_dext.ee_block)); |
| 729 | err = -EIO; | 702 | *err = -EIO; |
| 730 | goto out; | 703 | goto out; |
| 731 | } | 704 | } |
| 732 | 705 | ||
| 733 | /* Set donor extent to orig extent */ | 706 | /* Set donor extent to orig extent */ |
| 734 | err = mext_leaf_block(handle, orig_inode, | 707 | *err = mext_leaf_block(handle, orig_inode, |
| 735 | orig_path, &tmp_dext, &orig_off); | 708 | orig_path, &tmp_dext, &orig_off); |
| 736 | if (err < 0) | 709 | if (*err) |
| 737 | goto out; | 710 | goto out; |
| 738 | 711 | ||
| 739 | /* Set orig extent to donor extent */ | 712 | /* Set orig extent to donor extent */ |
| 740 | err = mext_leaf_block(handle, donor_inode, | 713 | *err = mext_leaf_block(handle, donor_inode, |
| 741 | donor_path, &tmp_oext, &donor_off); | 714 | donor_path, &tmp_oext, &donor_off); |
| 742 | if (err < 0) | 715 | if (*err) |
| 743 | goto out; | 716 | goto out; |
| 744 | 717 | ||
| 745 | dext_alen = ext4_ext_get_actual_len(&tmp_dext); | 718 | dext_alen = ext4_ext_get_actual_len(&tmp_dext); |
| @@ -753,35 +726,25 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
| 753 | 726 | ||
| 754 | if (orig_path) | 727 | if (orig_path) |
| 755 | ext4_ext_drop_refs(orig_path); | 728 | ext4_ext_drop_refs(orig_path); |
| 756 | err = get_ext_path(orig_inode, orig_off, &orig_path); | 729 | *err = get_ext_path(orig_inode, orig_off, &orig_path); |
| 757 | if (err) | 730 | if (*err) |
| 758 | goto out; | 731 | goto out; |
| 759 | depth = ext_depth(orig_inode); | 732 | depth = ext_depth(orig_inode); |
| 760 | oext = orig_path[depth].p_ext; | 733 | oext = orig_path[depth].p_ext; |
| 761 | if (le32_to_cpu(oext->ee_block) + | ||
| 762 | ext4_ext_get_actual_len(oext) <= orig_off) { | ||
| 763 | err = 0; | ||
| 764 | goto out; | ||
| 765 | } | ||
| 766 | tmp_oext = *oext; | 734 | tmp_oext = *oext; |
| 767 | 735 | ||
| 768 | if (donor_path) | 736 | if (donor_path) |
| 769 | ext4_ext_drop_refs(donor_path); | 737 | ext4_ext_drop_refs(donor_path); |
| 770 | err = get_ext_path(donor_inode, donor_off, &donor_path); | 738 | *err = get_ext_path(donor_inode, donor_off, &donor_path); |
| 771 | if (err) | 739 | if (*err) |
| 772 | goto out; | 740 | goto out; |
| 773 | depth = ext_depth(donor_inode); | 741 | depth = ext_depth(donor_inode); |
| 774 | dext = donor_path[depth].p_ext; | 742 | dext = donor_path[depth].p_ext; |
| 775 | if (le32_to_cpu(dext->ee_block) + | ||
| 776 | ext4_ext_get_actual_len(dext) <= donor_off) { | ||
| 777 | err = 0; | ||
| 778 | goto out; | ||
| 779 | } | ||
| 780 | tmp_dext = *dext; | 743 | tmp_dext = *dext; |
| 781 | 744 | ||
| 782 | err = mext_calc_swap_extents(&tmp_dext, &tmp_oext, orig_off, | 745 | *err = mext_calc_swap_extents(&tmp_dext, &tmp_oext, orig_off, |
| 783 | donor_off, count - replaced_count); | 746 | donor_off, count - replaced_count); |
| 784 | if (err) | 747 | if (*err) |
| 785 | goto out; | 748 | goto out; |
| 786 | } | 749 | } |
| 787 | 750 | ||
| @@ -795,8 +758,12 @@ out: | |||
| 795 | kfree(donor_path); | 758 | kfree(donor_path); |
| 796 | } | 759 | } |
| 797 | 760 | ||
| 798 | mext_double_up_write(orig_inode, donor_inode); | 761 | ext4_ext_invalidate_cache(orig_inode); |
| 799 | return err; | 762 | ext4_ext_invalidate_cache(donor_inode); |
| 763 | |||
| 764 | double_up_write_data_sem(orig_inode, donor_inode); | ||
| 765 | |||
| 766 | return replaced_count; | ||
| 800 | } | 767 | } |
| 801 | 768 | ||
| 802 | /** | 769 | /** |
| @@ -808,16 +775,17 @@ out: | |||
| 808 | * @data_offset_in_page: block index where data swapping starts | 775 | * @data_offset_in_page: block index where data swapping starts |
| 809 | * @block_len_in_page: the number of blocks to be swapped | 776 | * @block_len_in_page: the number of blocks to be swapped |
| 810 | * @uninit: orig extent is uninitialized or not | 777 | * @uninit: orig extent is uninitialized or not |
| 778 | * @err: pointer to save return value | ||
| 811 | * | 779 | * |
| 812 | * Save the data in original inode blocks and replace original inode extents | 780 | * Save the data in original inode blocks and replace original inode extents |
| 813 | * with donor inode extents by calling mext_replace_branches(). | 781 | * with donor inode extents by calling mext_replace_branches(). |
| 814 | * Finally, write out the saved data in new original inode blocks. Return 0 | 782 | * Finally, write out the saved data in new original inode blocks. Return |
| 815 | * on success, or a negative error value on failure. | 783 | * replaced block count. |
| 816 | */ | 784 | */ |
| 817 | static int | 785 | static int |
| 818 | move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | 786 | move_extent_per_page(struct file *o_filp, struct inode *donor_inode, |
| 819 | pgoff_t orig_page_offset, int data_offset_in_page, | 787 | pgoff_t orig_page_offset, int data_offset_in_page, |
| 820 | int block_len_in_page, int uninit) | 788 | int block_len_in_page, int uninit, int *err) |
| 821 | { | 789 | { |
| 822 | struct inode *orig_inode = o_filp->f_dentry->d_inode; | 790 | struct inode *orig_inode = o_filp->f_dentry->d_inode; |
| 823 | struct address_space *mapping = orig_inode->i_mapping; | 791 | struct address_space *mapping = orig_inode->i_mapping; |
| @@ -829,9 +797,11 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | |||
| 829 | long long offs = orig_page_offset << PAGE_CACHE_SHIFT; | 797 | long long offs = orig_page_offset << PAGE_CACHE_SHIFT; |
| 830 | unsigned long blocksize = orig_inode->i_sb->s_blocksize; | 798 | unsigned long blocksize = orig_inode->i_sb->s_blocksize; |
| 831 | unsigned int w_flags = 0; | 799 | unsigned int w_flags = 0; |
| 832 | unsigned int tmp_data_len, data_len; | 800 | unsigned int tmp_data_size, data_size, replaced_size; |
| 833 | void *fsdata; | 801 | void *fsdata; |
| 834 | int ret, i, jblocks; | 802 | int i, jblocks; |
| 803 | int err2 = 0; | ||
| 804 | int replaced_count = 0; | ||
| 835 | int blocks_per_page = PAGE_CACHE_SIZE >> orig_inode->i_blkbits; | 805 | int blocks_per_page = PAGE_CACHE_SIZE >> orig_inode->i_blkbits; |
| 836 | 806 | ||
| 837 | /* | 807 | /* |
| @@ -841,8 +811,8 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | |||
| 841 | jblocks = ext4_writepage_trans_blocks(orig_inode) * 2; | 811 | jblocks = ext4_writepage_trans_blocks(orig_inode) * 2; |
| 842 | handle = ext4_journal_start(orig_inode, jblocks); | 812 | handle = ext4_journal_start(orig_inode, jblocks); |
| 843 | if (IS_ERR(handle)) { | 813 | if (IS_ERR(handle)) { |
| 844 | ret = PTR_ERR(handle); | 814 | *err = PTR_ERR(handle); |
| 845 | return ret; | 815 | return 0; |
| 846 | } | 816 | } |
| 847 | 817 | ||
| 848 | if (segment_eq(get_fs(), KERNEL_DS)) | 818 | if (segment_eq(get_fs(), KERNEL_DS)) |
| @@ -858,39 +828,36 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | |||
| 858 | * Just swap data blocks between orig and donor. | 828 | * Just swap data blocks between orig and donor. |
| 859 | */ | 829 | */ |
| 860 | if (uninit) { | 830 | if (uninit) { |
| 861 | ret = mext_replace_branches(handle, orig_inode, | 831 | replaced_count = mext_replace_branches(handle, orig_inode, |
| 862 | donor_inode, orig_blk_offset, | 832 | donor_inode, orig_blk_offset, |
| 863 | block_len_in_page); | 833 | block_len_in_page, err); |
| 864 | |||
| 865 | /* Clear the inode cache not to refer to the old data */ | ||
| 866 | ext4_ext_invalidate_cache(orig_inode); | ||
| 867 | ext4_ext_invalidate_cache(donor_inode); | ||
| 868 | goto out2; | 834 | goto out2; |
| 869 | } | 835 | } |
| 870 | 836 | ||
| 871 | offs = (long long)orig_blk_offset << orig_inode->i_blkbits; | 837 | offs = (long long)orig_blk_offset << orig_inode->i_blkbits; |
| 872 | 838 | ||
| 873 | /* Calculate data_len */ | 839 | /* Calculate data_size */ |
| 874 | if ((orig_blk_offset + block_len_in_page - 1) == | 840 | if ((orig_blk_offset + block_len_in_page - 1) == |
| 875 | ((orig_inode->i_size - 1) >> orig_inode->i_blkbits)) { | 841 | ((orig_inode->i_size - 1) >> orig_inode->i_blkbits)) { |
| 876 | /* Replace the last block */ | 842 | /* Replace the last block */ |
| 877 | tmp_data_len = orig_inode->i_size & (blocksize - 1); | 843 | tmp_data_size = orig_inode->i_size & (blocksize - 1); |
| 878 | /* | 844 | /* |
| 879 | * If data_len equal zero, it shows data_len is multiples of | 845 | * If data_size equal zero, it shows data_size is multiples of |
| 880 | * blocksize. So we set appropriate value. | 846 | * blocksize. So we set appropriate value. |
| 881 | */ | 847 | */ |
| 882 | if (tmp_data_len == 0) | 848 | if (tmp_data_size == 0) |
| 883 | tmp_data_len = blocksize; | 849 | tmp_data_size = blocksize; |
| 884 | 850 | ||
| 885 | data_len = tmp_data_len + | 851 | data_size = tmp_data_size + |
| 886 | ((block_len_in_page - 1) << orig_inode->i_blkbits); | 852 | ((block_len_in_page - 1) << orig_inode->i_blkbits); |
| 887 | } else { | 853 | } else |
| 888 | data_len = block_len_in_page << orig_inode->i_blkbits; | 854 | data_size = block_len_in_page << orig_inode->i_blkbits; |
| 889 | } | 855 | |
| 856 | replaced_size = data_size; | ||
| 890 | 857 | ||
| 891 | ret = a_ops->write_begin(o_filp, mapping, offs, data_len, w_flags, | 858 | *err = a_ops->write_begin(o_filp, mapping, offs, data_size, w_flags, |
| 892 | &page, &fsdata); | 859 | &page, &fsdata); |
| 893 | if (unlikely(ret < 0)) | 860 | if (unlikely(*err < 0)) |
| 894 | goto out; | 861 | goto out; |
| 895 | 862 | ||
| 896 | if (!PageUptodate(page)) { | 863 | if (!PageUptodate(page)) { |
| @@ -911,14 +878,17 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | |||
| 911 | /* Release old bh and drop refs */ | 878 | /* Release old bh and drop refs */ |
| 912 | try_to_release_page(page, 0); | 879 | try_to_release_page(page, 0); |
| 913 | 880 | ||
| 914 | ret = mext_replace_branches(handle, orig_inode, donor_inode, | 881 | replaced_count = mext_replace_branches(handle, orig_inode, donor_inode, |
| 915 | orig_blk_offset, block_len_in_page); | 882 | orig_blk_offset, block_len_in_page, |
| 916 | if (ret < 0) | 883 | &err2); |
| 917 | goto out; | 884 | if (err2) { |
| 918 | 885 | if (replaced_count) { | |
| 919 | /* Clear the inode cache not to refer to the old data */ | 886 | block_len_in_page = replaced_count; |
| 920 | ext4_ext_invalidate_cache(orig_inode); | 887 | replaced_size = |
| 921 | ext4_ext_invalidate_cache(donor_inode); | 888 | block_len_in_page << orig_inode->i_blkbits; |
| 889 | } else | ||
| 890 | goto out; | ||
| 891 | } | ||
| 922 | 892 | ||
| 923 | if (!page_has_buffers(page)) | 893 | if (!page_has_buffers(page)) |
| 924 | create_empty_buffers(page, 1 << orig_inode->i_blkbits, 0); | 894 | create_empty_buffers(page, 1 << orig_inode->i_blkbits, 0); |
| @@ -928,16 +898,16 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, | |||
| 928 | bh = bh->b_this_page; | 898 | bh = bh->b_this_page; |
| 929 | 899 | ||
| 930 | for (i = 0; i < block_len_in_page; i++) { | 900 | for (i = 0; i < block_len_in_page; i++) { |
| 931 | ret = ext4_get_block(orig_inode, | 901 | *err = ext4_get_block(orig_inode, |
| 932 | (sector_t)(orig_blk_offset + i), bh, 0); | 902 | (sector_t)(orig_blk_offset + i), bh, 0); |
| 933 | if (ret < 0) | 903 | if (*err < 0) |
| 934 | goto out; | 904 | goto out; |
| 935 | 905 | ||
| 936 | if (bh->b_this_page != NULL) | 906 | if (bh->b_this_page != NULL) |
| 937 | bh = bh->b_this_page; | 907 | bh = bh->b_this_page; |
| 938 | } | 908 | } |
| 939 | 909 | ||
| 940 | ret = a_ops->write_end(o_filp, mapping, offs, data_len, data_len, | 910 | *err = a_ops->write_end(o_filp, mapping, offs, data_size, replaced_size, |
| 941 | page, fsdata); | 911 | page, fsdata); |
| 942 | page = NULL; | 912 | page = NULL; |
| 943 | 913 | ||
| @@ -951,7 +921,10 @@ out: | |||
| 951 | out2: | 921 | out2: |
| 952 | ext4_journal_stop(handle); | 922 | ext4_journal_stop(handle); |
| 953 | 923 | ||
| 954 | return ret < 0 ? ret : 0; | 924 | if (err2) |
| 925 | *err = err2; | ||
| 926 | |||
| 927 | return replaced_count; | ||
| 955 | } | 928 | } |
| 956 | 929 | ||
| 957 | /** | 930 | /** |
| @@ -962,7 +935,6 @@ out2: | |||
| 962 | * @orig_start: logical start offset in block for orig | 935 | * @orig_start: logical start offset in block for orig |
| 963 | * @donor_start: logical start offset in block for donor | 936 | * @donor_start: logical start offset in block for donor |
| 964 | * @len: the number of blocks to be moved | 937 | * @len: the number of blocks to be moved |
| 965 | * @moved_len: moved block length | ||
| 966 | * | 938 | * |
| 967 | * Check the arguments of ext4_move_extents() whether the files can be | 939 | * Check the arguments of ext4_move_extents() whether the files can be |
| 968 | * exchanged with each other. | 940 | * exchanged with each other. |
| @@ -970,8 +942,8 @@ out2: | |||
| 970 | */ | 942 | */ |
| 971 | static int | 943 | static int |
| 972 | mext_check_arguments(struct inode *orig_inode, | 944 | mext_check_arguments(struct inode *orig_inode, |
| 973 | struct inode *donor_inode, __u64 orig_start, | 945 | struct inode *donor_inode, __u64 orig_start, |
| 974 | __u64 donor_start, __u64 *len, __u64 moved_len) | 946 | __u64 donor_start, __u64 *len) |
| 975 | { | 947 | { |
| 976 | ext4_lblk_t orig_blocks, donor_blocks; | 948 | ext4_lblk_t orig_blocks, donor_blocks; |
| 977 | unsigned int blkbits = orig_inode->i_blkbits; | 949 | unsigned int blkbits = orig_inode->i_blkbits; |
| @@ -985,6 +957,13 @@ mext_check_arguments(struct inode *orig_inode, | |||
| 985 | return -EINVAL; | 957 | return -EINVAL; |
| 986 | } | 958 | } |
| 987 | 959 | ||
| 960 | if (donor_inode->i_mode & (S_ISUID|S_ISGID)) { | ||
| 961 | ext4_debug("ext4 move extent: suid or sgid is set" | ||
| 962 | " to donor file [ino:orig %lu, donor %lu]\n", | ||
| 963 | orig_inode->i_ino, donor_inode->i_ino); | ||
| 964 | return -EINVAL; | ||
| 965 | } | ||
| 966 | |||
| 988 | /* Ext4 move extent does not support swapfile */ | 967 | /* Ext4 move extent does not support swapfile */ |
| 989 | if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) { | 968 | if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) { |
| 990 | ext4_debug("ext4 move extent: The argument files should " | 969 | ext4_debug("ext4 move extent: The argument files should " |
| @@ -1025,13 +1004,6 @@ mext_check_arguments(struct inode *orig_inode, | |||
| 1025 | return -EINVAL; | 1004 | return -EINVAL; |
| 1026 | } | 1005 | } |
| 1027 | 1006 | ||
| 1028 | if (moved_len) { | ||
| 1029 | ext4_debug("ext4 move extent: moved_len should be 0 " | ||
| 1030 | "[ino:orig %lu, donor %lu]\n", orig_inode->i_ino, | ||
| 1031 | donor_inode->i_ino); | ||
| 1032 | return -EINVAL; | ||
| 1033 | } | ||
| 1034 | |||
| 1035 | if ((orig_start > EXT_MAX_BLOCK) || | 1007 | if ((orig_start > EXT_MAX_BLOCK) || |
| 1036 | (donor_start > EXT_MAX_BLOCK) || | 1008 | (donor_start > EXT_MAX_BLOCK) || |
| 1037 | (*len > EXT_MAX_BLOCK) || | 1009 | (*len > EXT_MAX_BLOCK) || |
| @@ -1088,7 +1060,7 @@ mext_check_arguments(struct inode *orig_inode, | |||
| 1088 | } | 1060 | } |
| 1089 | 1061 | ||
| 1090 | if (!*len) { | 1062 | if (!*len) { |
| 1091 | ext4_debug("ext4 move extent: len shoudld not be 0 " | 1063 | ext4_debug("ext4 move extent: len should not be 0 " |
| 1092 | "[ino:orig %lu, donor %lu]\n", orig_inode->i_ino, | 1064 | "[ino:orig %lu, donor %lu]\n", orig_inode->i_ino, |
| 1093 | donor_inode->i_ino); | 1065 | donor_inode->i_ino); |
| 1094 | return -EINVAL; | 1066 | return -EINVAL; |
| @@ -1232,16 +1204,16 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
| 1232 | return -EINVAL; | 1204 | return -EINVAL; |
| 1233 | } | 1205 | } |
| 1234 | 1206 | ||
| 1235 | /* protect orig and donor against a truncate */ | 1207 | /* Protect orig and donor inodes against a truncate */ |
| 1236 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); | 1208 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); |
| 1237 | if (ret1 < 0) | 1209 | if (ret1 < 0) |
| 1238 | return ret1; | 1210 | return ret1; |
| 1239 | 1211 | ||
| 1240 | mext_double_down_read(orig_inode, donor_inode); | 1212 | /* Protect extent tree against block allocations via delalloc */ |
| 1213 | double_down_write_data_sem(orig_inode, donor_inode); | ||
| 1241 | /* Check the filesystem environment whether move_extent can be done */ | 1214 | /* Check the filesystem environment whether move_extent can be done */ |
| 1242 | ret1 = mext_check_arguments(orig_inode, donor_inode, orig_start, | 1215 | ret1 = mext_check_arguments(orig_inode, donor_inode, orig_start, |
| 1243 | donor_start, &len, *moved_len); | 1216 | donor_start, &len); |
| 1244 | mext_double_up_read(orig_inode, donor_inode); | ||
| 1245 | if (ret1) | 1217 | if (ret1) |
| 1246 | goto out; | 1218 | goto out; |
| 1247 | 1219 | ||
| @@ -1355,36 +1327,39 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
| 1355 | seq_start = le32_to_cpu(ext_cur->ee_block); | 1327 | seq_start = le32_to_cpu(ext_cur->ee_block); |
| 1356 | rest_blocks = seq_blocks; | 1328 | rest_blocks = seq_blocks; |
| 1357 | 1329 | ||
| 1358 | /* Discard preallocations of two inodes */ | 1330 | /* |
| 1359 | down_write(&EXT4_I(orig_inode)->i_data_sem); | 1331 | * Up semaphore to avoid following problems: |
| 1360 | ext4_discard_preallocations(orig_inode); | 1332 | * a. transaction deadlock among ext4_journal_start, |
| 1361 | up_write(&EXT4_I(orig_inode)->i_data_sem); | 1333 | * ->write_begin via pagefault, and jbd2_journal_commit |
| 1362 | 1334 | * b. racing with ->readpage, ->write_begin, and ext4_get_block | |
| 1363 | down_write(&EXT4_I(donor_inode)->i_data_sem); | 1335 | * in move_extent_per_page |
| 1364 | ext4_discard_preallocations(donor_inode); | 1336 | */ |
| 1365 | up_write(&EXT4_I(donor_inode)->i_data_sem); | 1337 | double_up_write_data_sem(orig_inode, donor_inode); |
| 1366 | 1338 | ||
| 1367 | while (orig_page_offset <= seq_end_page) { | 1339 | while (orig_page_offset <= seq_end_page) { |
| 1368 | 1340 | ||
| 1369 | /* Swap original branches with new branches */ | 1341 | /* Swap original branches with new branches */ |
| 1370 | ret1 = move_extent_per_page(o_filp, donor_inode, | 1342 | block_len_in_page = move_extent_per_page( |
| 1343 | o_filp, donor_inode, | ||
| 1371 | orig_page_offset, | 1344 | orig_page_offset, |
| 1372 | data_offset_in_page, | 1345 | data_offset_in_page, |
| 1373 | block_len_in_page, uninit); | 1346 | block_len_in_page, uninit, |
| 1374 | if (ret1 < 0) | 1347 | &ret1); |
| 1375 | goto out; | 1348 | |
| 1376 | orig_page_offset++; | ||
| 1377 | /* Count how many blocks we have exchanged */ | 1349 | /* Count how many blocks we have exchanged */ |
| 1378 | *moved_len += block_len_in_page; | 1350 | *moved_len += block_len_in_page; |
| 1351 | if (ret1 < 0) | ||
| 1352 | break; | ||
| 1379 | if (*moved_len > len) { | 1353 | if (*moved_len > len) { |
| 1380 | ext4_error(orig_inode->i_sb, __func__, | 1354 | ext4_error(orig_inode->i_sb, __func__, |
| 1381 | "We replaced blocks too much! " | 1355 | "We replaced blocks too much! " |
| 1382 | "sum of replaced: %llu requested: %llu", | 1356 | "sum of replaced: %llu requested: %llu", |
| 1383 | *moved_len, len); | 1357 | *moved_len, len); |
| 1384 | ret1 = -EIO; | 1358 | ret1 = -EIO; |
| 1385 | goto out; | 1359 | break; |
| 1386 | } | 1360 | } |
| 1387 | 1361 | ||
| 1362 | orig_page_offset++; | ||
| 1388 | data_offset_in_page = 0; | 1363 | data_offset_in_page = 0; |
| 1389 | rest_blocks -= block_len_in_page; | 1364 | rest_blocks -= block_len_in_page; |
| 1390 | if (rest_blocks > blocks_per_page) | 1365 | if (rest_blocks > blocks_per_page) |
| @@ -1393,6 +1368,10 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
| 1393 | block_len_in_page = rest_blocks; | 1368 | block_len_in_page = rest_blocks; |
| 1394 | } | 1369 | } |
| 1395 | 1370 | ||
| 1371 | double_down_write_data_sem(orig_inode, donor_inode); | ||
| 1372 | if (ret1 < 0) | ||
| 1373 | break; | ||
| 1374 | |||
| 1396 | /* Decrease buffer counter */ | 1375 | /* Decrease buffer counter */ |
| 1397 | if (holecheck_path) | 1376 | if (holecheck_path) |
| 1398 | ext4_ext_drop_refs(holecheck_path); | 1377 | ext4_ext_drop_refs(holecheck_path); |
| @@ -1414,6 +1393,11 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
| 1414 | 1393 | ||
| 1415 | } | 1394 | } |
| 1416 | out: | 1395 | out: |
| 1396 | if (*moved_len) { | ||
| 1397 | ext4_discard_preallocations(orig_inode); | ||
| 1398 | ext4_discard_preallocations(donor_inode); | ||
| 1399 | } | ||
| 1400 | |||
| 1417 | if (orig_path) { | 1401 | if (orig_path) { |
| 1418 | ext4_ext_drop_refs(orig_path); | 1402 | ext4_ext_drop_refs(orig_path); |
| 1419 | kfree(orig_path); | 1403 | kfree(orig_path); |
| @@ -1422,7 +1406,7 @@ out: | |||
| 1422 | ext4_ext_drop_refs(holecheck_path); | 1406 | ext4_ext_drop_refs(holecheck_path); |
| 1423 | kfree(holecheck_path); | 1407 | kfree(holecheck_path); |
| 1424 | } | 1408 | } |
| 1425 | 1409 | double_up_write_data_sem(orig_inode, donor_inode); | |
| 1426 | ret2 = mext_inode_double_unlock(orig_inode, donor_inode); | 1410 | ret2 = mext_inode_double_unlock(orig_inode, donor_inode); |
| 1427 | 1411 | ||
| 1428 | if (ret1) | 1412 | if (ret1) |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 6d2c1b897fc7..17a17e10dd60 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
| @@ -1292,9 +1292,6 @@ errout: | |||
| 1292 | * add_dirent_to_buf will attempt search the directory block for | 1292 | * add_dirent_to_buf will attempt search the directory block for |
| 1293 | * space. It will return -ENOSPC if no space is available, and -EIO | 1293 | * space. It will return -ENOSPC if no space is available, and -EIO |
| 1294 | * and -EEXIST if directory entry already exists. | 1294 | * and -EEXIST if directory entry already exists. |
| 1295 | * | ||
| 1296 | * NOTE! bh is NOT released in the case where ENOSPC is returned. In | ||
| 1297 | * all other cases bh is released. | ||
| 1298 | */ | 1295 | */ |
| 1299 | static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | 1296 | static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, |
| 1300 | struct inode *inode, struct ext4_dir_entry_2 *de, | 1297 | struct inode *inode, struct ext4_dir_entry_2 *de, |
| @@ -1315,14 +1312,10 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
| 1315 | top = bh->b_data + blocksize - reclen; | 1312 | top = bh->b_data + blocksize - reclen; |
| 1316 | while ((char *) de <= top) { | 1313 | while ((char *) de <= top) { |
| 1317 | if (!ext4_check_dir_entry("ext4_add_entry", dir, de, | 1314 | if (!ext4_check_dir_entry("ext4_add_entry", dir, de, |
| 1318 | bh, offset)) { | 1315 | bh, offset)) |
| 1319 | brelse(bh); | ||
| 1320 | return -EIO; | 1316 | return -EIO; |
| 1321 | } | 1317 | if (ext4_match(namelen, name, de)) |
| 1322 | if (ext4_match(namelen, name, de)) { | ||
| 1323 | brelse(bh); | ||
| 1324 | return -EEXIST; | 1318 | return -EEXIST; |
| 1325 | } | ||
| 1326 | nlen = EXT4_DIR_REC_LEN(de->name_len); | 1319 | nlen = EXT4_DIR_REC_LEN(de->name_len); |
| 1327 | rlen = ext4_rec_len_from_disk(de->rec_len, blocksize); | 1320 | rlen = ext4_rec_len_from_disk(de->rec_len, blocksize); |
| 1328 | if ((de->inode? rlen - nlen: rlen) >= reclen) | 1321 | if ((de->inode? rlen - nlen: rlen) >= reclen) |
| @@ -1337,7 +1330,6 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
| 1337 | err = ext4_journal_get_write_access(handle, bh); | 1330 | err = ext4_journal_get_write_access(handle, bh); |
| 1338 | if (err) { | 1331 | if (err) { |
| 1339 | ext4_std_error(dir->i_sb, err); | 1332 | ext4_std_error(dir->i_sb, err); |
| 1340 | brelse(bh); | ||
| 1341 | return err; | 1333 | return err; |
| 1342 | } | 1334 | } |
| 1343 | 1335 | ||
| @@ -1377,7 +1369,6 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
| 1377 | err = ext4_handle_dirty_metadata(handle, dir, bh); | 1369 | err = ext4_handle_dirty_metadata(handle, dir, bh); |
| 1378 | if (err) | 1370 | if (err) |
| 1379 | ext4_std_error(dir->i_sb, err); | 1371 | ext4_std_error(dir->i_sb, err); |
| 1380 | brelse(bh); | ||
| 1381 | return 0; | 1372 | return 0; |
| 1382 | } | 1373 | } |
| 1383 | 1374 | ||
| @@ -1471,7 +1462,9 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, | |||
| 1471 | if (!(de)) | 1462 | if (!(de)) |
| 1472 | return retval; | 1463 | return retval; |
| 1473 | 1464 | ||
| 1474 | return add_dirent_to_buf(handle, dentry, inode, de, bh); | 1465 | retval = add_dirent_to_buf(handle, dentry, inode, de, bh); |
| 1466 | brelse(bh); | ||
| 1467 | return retval; | ||
| 1475 | } | 1468 | } |
| 1476 | 1469 | ||
| 1477 | /* | 1470 | /* |
| @@ -1514,8 +1507,10 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, | |||
| 1514 | if(!bh) | 1507 | if(!bh) |
| 1515 | return retval; | 1508 | return retval; |
| 1516 | retval = add_dirent_to_buf(handle, dentry, inode, NULL, bh); | 1509 | retval = add_dirent_to_buf(handle, dentry, inode, NULL, bh); |
| 1517 | if (retval != -ENOSPC) | 1510 | if (retval != -ENOSPC) { |
| 1511 | brelse(bh); | ||
| 1518 | return retval; | 1512 | return retval; |
| 1513 | } | ||
| 1519 | 1514 | ||
| 1520 | if (blocks == 1 && !dx_fallback && | 1515 | if (blocks == 1 && !dx_fallback && |
| 1521 | EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_DIR_INDEX)) | 1516 | EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_DIR_INDEX)) |
| @@ -1528,7 +1523,9 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, | |||
| 1528 | de = (struct ext4_dir_entry_2 *) bh->b_data; | 1523 | de = (struct ext4_dir_entry_2 *) bh->b_data; |
| 1529 | de->inode = 0; | 1524 | de->inode = 0; |
| 1530 | de->rec_len = ext4_rec_len_to_disk(blocksize, blocksize); | 1525 | de->rec_len = ext4_rec_len_to_disk(blocksize, blocksize); |
| 1531 | return add_dirent_to_buf(handle, dentry, inode, de, bh); | 1526 | retval = add_dirent_to_buf(handle, dentry, inode, de, bh); |
| 1527 | brelse(bh); | ||
| 1528 | return retval; | ||
| 1532 | } | 1529 | } |
| 1533 | 1530 | ||
| 1534 | /* | 1531 | /* |
| @@ -1561,10 +1558,8 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | |||
| 1561 | goto journal_error; | 1558 | goto journal_error; |
| 1562 | 1559 | ||
| 1563 | err = add_dirent_to_buf(handle, dentry, inode, NULL, bh); | 1560 | err = add_dirent_to_buf(handle, dentry, inode, NULL, bh); |
| 1564 | if (err != -ENOSPC) { | 1561 | if (err != -ENOSPC) |
| 1565 | bh = NULL; | ||
| 1566 | goto cleanup; | 1562 | goto cleanup; |
| 1567 | } | ||
| 1568 | 1563 | ||
| 1569 | /* Block full, should compress but for now just split */ | 1564 | /* Block full, should compress but for now just split */ |
| 1570 | dxtrace(printk(KERN_DEBUG "using %u of %u node entries\n", | 1565 | dxtrace(printk(KERN_DEBUG "using %u of %u node entries\n", |
| @@ -1657,7 +1652,6 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | |||
| 1657 | if (!de) | 1652 | if (!de) |
| 1658 | goto cleanup; | 1653 | goto cleanup; |
| 1659 | err = add_dirent_to_buf(handle, dentry, inode, de, bh); | 1654 | err = add_dirent_to_buf(handle, dentry, inode, de, bh); |
| 1660 | bh = NULL; | ||
| 1661 | goto cleanup; | 1655 | goto cleanup; |
| 1662 | 1656 | ||
| 1663 | journal_error: | 1657 | journal_error: |
| @@ -1775,7 +1769,7 @@ static int ext4_create(struct inode *dir, struct dentry *dentry, int mode, | |||
| 1775 | retry: | 1769 | retry: |
| 1776 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1770 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
| 1777 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1771 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
| 1778 | 2*EXT4_QUOTA_INIT_BLOCKS(dir->i_sb)); | 1772 | EXT4_MAXQUOTAS_INIT_BLOCKS(dir->i_sb)); |
| 1779 | if (IS_ERR(handle)) | 1773 | if (IS_ERR(handle)) |
| 1780 | return PTR_ERR(handle); | 1774 | return PTR_ERR(handle); |
| 1781 | 1775 | ||
| @@ -1809,7 +1803,7 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry, | |||
| 1809 | retry: | 1803 | retry: |
| 1810 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1804 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
| 1811 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1805 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
| 1812 | 2*EXT4_QUOTA_INIT_BLOCKS(dir->i_sb)); | 1806 | EXT4_MAXQUOTAS_INIT_BLOCKS(dir->i_sb)); |
| 1813 | if (IS_ERR(handle)) | 1807 | if (IS_ERR(handle)) |
| 1814 | return PTR_ERR(handle); | 1808 | return PTR_ERR(handle); |
| 1815 | 1809 | ||
| @@ -1846,7 +1840,7 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 1846 | retry: | 1840 | retry: |
| 1847 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1841 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
| 1848 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1842 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
| 1849 | 2*EXT4_QUOTA_INIT_BLOCKS(dir->i_sb)); | 1843 | EXT4_MAXQUOTAS_INIT_BLOCKS(dir->i_sb)); |
| 1850 | if (IS_ERR(handle)) | 1844 | if (IS_ERR(handle)) |
| 1851 | return PTR_ERR(handle); | 1845 | return PTR_ERR(handle); |
| 1852 | 1846 | ||
| @@ -2259,7 +2253,7 @@ static int ext4_symlink(struct inode *dir, | |||
| 2259 | retry: | 2253 | retry: |
| 2260 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 2254 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
| 2261 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 5 + | 2255 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 5 + |
| 2262 | 2*EXT4_QUOTA_INIT_BLOCKS(dir->i_sb)); | 2256 | EXT4_MAXQUOTAS_INIT_BLOCKS(dir->i_sb)); |
| 2263 | if (IS_ERR(handle)) | 2257 | if (IS_ERR(handle)) |
| 2264 | return PTR_ERR(handle); | 2258 | return PTR_ERR(handle); |
| 2265 | 2259 | ||
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 3cfc343c41b5..3b2c5541d8a6 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c | |||
| @@ -247,7 +247,7 @@ static int setup_new_group_blocks(struct super_block *sb, | |||
| 247 | goto exit_bh; | 247 | goto exit_bh; |
| 248 | 248 | ||
| 249 | if (IS_ERR(gdb = bclean(handle, sb, block))) { | 249 | if (IS_ERR(gdb = bclean(handle, sb, block))) { |
| 250 | err = PTR_ERR(bh); | 250 | err = PTR_ERR(gdb); |
| 251 | goto exit_bh; | 251 | goto exit_bh; |
| 252 | } | 252 | } |
| 253 | ext4_handle_dirty_metadata(handle, NULL, gdb); | 253 | ext4_handle_dirty_metadata(handle, NULL, gdb); |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index d4ca92aab514..827bde1f2594 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
| @@ -603,10 +603,6 @@ static void ext4_put_super(struct super_block *sb) | |||
| 603 | if (sb->s_dirt) | 603 | if (sb->s_dirt) |
| 604 | ext4_commit_super(sb, 1); | 604 | ext4_commit_super(sb, 1); |
| 605 | 605 | ||
| 606 | ext4_release_system_zone(sb); | ||
| 607 | ext4_mb_release(sb); | ||
| 608 | ext4_ext_release(sb); | ||
| 609 | ext4_xattr_put_super(sb); | ||
| 610 | if (sbi->s_journal) { | 606 | if (sbi->s_journal) { |
| 611 | err = jbd2_journal_destroy(sbi->s_journal); | 607 | err = jbd2_journal_destroy(sbi->s_journal); |
| 612 | sbi->s_journal = NULL; | 608 | sbi->s_journal = NULL; |
| @@ -614,6 +610,12 @@ static void ext4_put_super(struct super_block *sb) | |||
| 614 | ext4_abort(sb, __func__, | 610 | ext4_abort(sb, __func__, |
| 615 | "Couldn't clean up the journal"); | 611 | "Couldn't clean up the journal"); |
| 616 | } | 612 | } |
| 613 | |||
| 614 | ext4_release_system_zone(sb); | ||
| 615 | ext4_mb_release(sb); | ||
| 616 | ext4_ext_release(sb); | ||
| 617 | ext4_xattr_put_super(sb); | ||
| 618 | |||
| 617 | if (!(sb->s_flags & MS_RDONLY)) { | 619 | if (!(sb->s_flags & MS_RDONLY)) { |
| 618 | EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); | 620 | EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); |
| 619 | es->s_state = cpu_to_le16(sbi->s_mount_state); | 621 | es->s_state = cpu_to_le16(sbi->s_mount_state); |
| @@ -704,6 +706,8 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) | |||
| 704 | spin_lock_init(&(ei->i_block_reservation_lock)); | 706 | spin_lock_init(&(ei->i_block_reservation_lock)); |
| 705 | INIT_LIST_HEAD(&ei->i_aio_dio_complete_list); | 707 | INIT_LIST_HEAD(&ei->i_aio_dio_complete_list); |
| 706 | ei->cur_aio_dio = NULL; | 708 | ei->cur_aio_dio = NULL; |
| 709 | ei->i_sync_tid = 0; | ||
| 710 | ei->i_datasync_tid = 0; | ||
| 707 | 711 | ||
| 708 | return &ei->vfs_inode; | 712 | return &ei->vfs_inode; |
| 709 | } | 713 | } |
| @@ -765,9 +769,22 @@ static inline void ext4_show_quota_options(struct seq_file *seq, | |||
| 765 | #if defined(CONFIG_QUOTA) | 769 | #if defined(CONFIG_QUOTA) |
| 766 | struct ext4_sb_info *sbi = EXT4_SB(sb); | 770 | struct ext4_sb_info *sbi = EXT4_SB(sb); |
| 767 | 771 | ||
| 768 | if (sbi->s_jquota_fmt) | 772 | if (sbi->s_jquota_fmt) { |
| 769 | seq_printf(seq, ",jqfmt=%s", | 773 | char *fmtname = ""; |
| 770 | (sbi->s_jquota_fmt == QFMT_VFS_OLD) ? "vfsold" : "vfsv0"); | 774 | |
| 775 | switch (sbi->s_jquota_fmt) { | ||
| 776 | case QFMT_VFS_OLD: | ||
| 777 | fmtname = "vfsold"; | ||
| 778 | break; | ||
| 779 | case QFMT_VFS_V0: | ||
| 780 | fmtname = "vfsv0"; | ||
| 781 | break; | ||
| 782 | case QFMT_VFS_V1: | ||
| 783 | fmtname = "vfsv1"; | ||
| 784 | break; | ||
| 785 | } | ||
| 786 | seq_printf(seq, ",jqfmt=%s", fmtname); | ||
| 787 | } | ||
| 771 | 788 | ||
| 772 | if (sbi->s_qf_names[USRQUOTA]) | 789 | if (sbi->s_qf_names[USRQUOTA]) |
| 773 | seq_printf(seq, ",usrjquota=%s", sbi->s_qf_names[USRQUOTA]); | 790 | seq_printf(seq, ",usrjquota=%s", sbi->s_qf_names[USRQUOTA]); |
| @@ -899,6 +916,12 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
| 899 | if (test_opt(sb, NO_AUTO_DA_ALLOC)) | 916 | if (test_opt(sb, NO_AUTO_DA_ALLOC)) |
| 900 | seq_puts(seq, ",noauto_da_alloc"); | 917 | seq_puts(seq, ",noauto_da_alloc"); |
| 901 | 918 | ||
| 919 | if (test_opt(sb, DISCARD)) | ||
| 920 | seq_puts(seq, ",discard"); | ||
| 921 | |||
| 922 | if (test_opt(sb, NOLOAD)) | ||
| 923 | seq_puts(seq, ",norecovery"); | ||
| 924 | |||
| 902 | ext4_show_quota_options(seq, sb); | 925 | ext4_show_quota_options(seq, sb); |
| 903 | 926 | ||
| 904 | return 0; | 927 | return 0; |
| @@ -1074,12 +1097,13 @@ enum { | |||
| 1074 | Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback, | 1097 | Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback, |
| 1075 | Opt_data_err_abort, Opt_data_err_ignore, | 1098 | Opt_data_err_abort, Opt_data_err_ignore, |
| 1076 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, | 1099 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, |
| 1077 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota, | 1100 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_jqfmt_vfsv1, Opt_quota, |
| 1078 | Opt_ignore, Opt_barrier, Opt_nobarrier, Opt_err, Opt_resize, | 1101 | Opt_noquota, Opt_ignore, Opt_barrier, Opt_nobarrier, Opt_err, |
| 1079 | Opt_usrquota, Opt_grpquota, Opt_i_version, | 1102 | Opt_resize, Opt_usrquota, Opt_grpquota, Opt_i_version, |
| 1080 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, | 1103 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, |
| 1081 | Opt_block_validity, Opt_noblock_validity, | 1104 | Opt_block_validity, Opt_noblock_validity, |
| 1082 | Opt_inode_readahead_blks, Opt_journal_ioprio | 1105 | Opt_inode_readahead_blks, Opt_journal_ioprio, |
| 1106 | Opt_discard, Opt_nodiscard, | ||
| 1083 | }; | 1107 | }; |
| 1084 | 1108 | ||
| 1085 | static const match_table_t tokens = { | 1109 | static const match_table_t tokens = { |
| @@ -1104,6 +1128,7 @@ static const match_table_t tokens = { | |||
| 1104 | {Opt_acl, "acl"}, | 1128 | {Opt_acl, "acl"}, |
| 1105 | {Opt_noacl, "noacl"}, | 1129 | {Opt_noacl, "noacl"}, |
| 1106 | {Opt_noload, "noload"}, | 1130 | {Opt_noload, "noload"}, |
| 1131 | {Opt_noload, "norecovery"}, | ||
| 1107 | {Opt_nobh, "nobh"}, | 1132 | {Opt_nobh, "nobh"}, |
| 1108 | {Opt_bh, "bh"}, | 1133 | {Opt_bh, "bh"}, |
| 1109 | {Opt_commit, "commit=%u"}, | 1134 | {Opt_commit, "commit=%u"}, |
| @@ -1125,6 +1150,7 @@ static const match_table_t tokens = { | |||
| 1125 | {Opt_grpjquota, "grpjquota=%s"}, | 1150 | {Opt_grpjquota, "grpjquota=%s"}, |
| 1126 | {Opt_jqfmt_vfsold, "jqfmt=vfsold"}, | 1151 | {Opt_jqfmt_vfsold, "jqfmt=vfsold"}, |
| 1127 | {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"}, | 1152 | {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"}, |
| 1153 | {Opt_jqfmt_vfsv1, "jqfmt=vfsv1"}, | ||
| 1128 | {Opt_grpquota, "grpquota"}, | 1154 | {Opt_grpquota, "grpquota"}, |
| 1129 | {Opt_noquota, "noquota"}, | 1155 | {Opt_noquota, "noquota"}, |
| 1130 | {Opt_quota, "quota"}, | 1156 | {Opt_quota, "quota"}, |
| @@ -1144,6 +1170,8 @@ static const match_table_t tokens = { | |||
| 1144 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, | 1170 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, |
| 1145 | {Opt_auto_da_alloc, "auto_da_alloc"}, | 1171 | {Opt_auto_da_alloc, "auto_da_alloc"}, |
| 1146 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, | 1172 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, |
| 1173 | {Opt_discard, "discard"}, | ||
| 1174 | {Opt_nodiscard, "nodiscard"}, | ||
| 1147 | {Opt_err, NULL}, | 1175 | {Opt_err, NULL}, |
| 1148 | }; | 1176 | }; |
| 1149 | 1177 | ||
| @@ -1425,6 +1453,9 @@ clear_qf_name: | |||
| 1425 | goto set_qf_format; | 1453 | goto set_qf_format; |
| 1426 | case Opt_jqfmt_vfsv0: | 1454 | case Opt_jqfmt_vfsv0: |
| 1427 | qfmt = QFMT_VFS_V0; | 1455 | qfmt = QFMT_VFS_V0; |
| 1456 | goto set_qf_format; | ||
| 1457 | case Opt_jqfmt_vfsv1: | ||
| 1458 | qfmt = QFMT_VFS_V1; | ||
| 1428 | set_qf_format: | 1459 | set_qf_format: |
| 1429 | if (sb_any_quota_loaded(sb) && | 1460 | if (sb_any_quota_loaded(sb) && |
| 1430 | sbi->s_jquota_fmt != qfmt) { | 1461 | sbi->s_jquota_fmt != qfmt) { |
| @@ -1467,6 +1498,7 @@ set_qf_format: | |||
| 1467 | case Opt_offgrpjquota: | 1498 | case Opt_offgrpjquota: |
| 1468 | case Opt_jqfmt_vfsold: | 1499 | case Opt_jqfmt_vfsold: |
| 1469 | case Opt_jqfmt_vfsv0: | 1500 | case Opt_jqfmt_vfsv0: |
| 1501 | case Opt_jqfmt_vfsv1: | ||
| 1470 | ext4_msg(sb, KERN_ERR, | 1502 | ext4_msg(sb, KERN_ERR, |
| 1471 | "journaled quota options not supported"); | 1503 | "journaled quota options not supported"); |
| 1472 | break; | 1504 | break; |
| @@ -1565,6 +1597,12 @@ set_qf_format: | |||
| 1565 | else | 1597 | else |
| 1566 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); | 1598 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); |
| 1567 | break; | 1599 | break; |
| 1600 | case Opt_discard: | ||
| 1601 | set_opt(sbi->s_mount_opt, DISCARD); | ||
| 1602 | break; | ||
| 1603 | case Opt_nodiscard: | ||
| 1604 | clear_opt(sbi->s_mount_opt, DISCARD); | ||
| 1605 | break; | ||
| 1568 | default: | 1606 | default: |
| 1569 | ext4_msg(sb, KERN_ERR, | 1607 | ext4_msg(sb, KERN_ERR, |
| 1570 | "Unrecognized mount option \"%s\" " | 1608 | "Unrecognized mount option \"%s\" " |
| @@ -1673,14 +1711,14 @@ static int ext4_fill_flex_info(struct super_block *sb) | |||
| 1673 | size_t size; | 1711 | size_t size; |
| 1674 | int i; | 1712 | int i; |
| 1675 | 1713 | ||
| 1676 | if (!sbi->s_es->s_log_groups_per_flex) { | 1714 | sbi->s_log_groups_per_flex = sbi->s_es->s_log_groups_per_flex; |
| 1715 | groups_per_flex = 1 << sbi->s_log_groups_per_flex; | ||
| 1716 | |||
| 1717 | if (groups_per_flex < 2) { | ||
| 1677 | sbi->s_log_groups_per_flex = 0; | 1718 | sbi->s_log_groups_per_flex = 0; |
| 1678 | return 1; | 1719 | return 1; |
| 1679 | } | 1720 | } |
| 1680 | 1721 | ||
| 1681 | sbi->s_log_groups_per_flex = sbi->s_es->s_log_groups_per_flex; | ||
| 1682 | groups_per_flex = 1 << sbi->s_log_groups_per_flex; | ||
| 1683 | |||
| 1684 | /* We allocate both existing and potentially added groups */ | 1722 | /* We allocate both existing and potentially added groups */ |
| 1685 | flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) + | 1723 | flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) + |
| 1686 | ((le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) + 1) << | 1724 | ((le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) + 1) << |
| @@ -2099,11 +2137,8 @@ static int parse_strtoul(const char *buf, | |||
| 2099 | { | 2137 | { |
| 2100 | char *endp; | 2138 | char *endp; |
| 2101 | 2139 | ||
| 2102 | while (*buf && isspace(*buf)) | 2140 | *value = simple_strtoul(skip_spaces(buf), &endp, 0); |
| 2103 | buf++; | 2141 | endp = skip_spaces(endp); |
| 2104 | *value = simple_strtoul(buf, &endp, 0); | ||
| 2105 | while (*endp && isspace(*endp)) | ||
| 2106 | endp++; | ||
| 2107 | if (*endp || *value > max) | 2142 | if (*endp || *value > max) |
| 2108 | return -EINVAL; | 2143 | return -EINVAL; |
| 2109 | 2144 | ||
| @@ -2721,26 +2756,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
| 2721 | EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_HAS_JOURNAL)) { | 2756 | EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_HAS_JOURNAL)) { |
| 2722 | if (ext4_load_journal(sb, es, journal_devnum)) | 2757 | if (ext4_load_journal(sb, es, journal_devnum)) |
| 2723 | goto failed_mount3; | 2758 | goto failed_mount3; |
| 2724 | if (!(sb->s_flags & MS_RDONLY) && | ||
| 2725 | EXT4_SB(sb)->s_journal->j_failed_commit) { | ||
| 2726 | ext4_msg(sb, KERN_CRIT, "error: " | ||
| 2727 | "ext4_fill_super: Journal transaction " | ||
| 2728 | "%u is corrupt", | ||
| 2729 | EXT4_SB(sb)->s_journal->j_failed_commit); | ||
| 2730 | if (test_opt(sb, ERRORS_RO)) { | ||
| 2731 | ext4_msg(sb, KERN_CRIT, | ||
| 2732 | "Mounting filesystem read-only"); | ||
| 2733 | sb->s_flags |= MS_RDONLY; | ||
| 2734 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; | ||
| 2735 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); | ||
| 2736 | } | ||
| 2737 | if (test_opt(sb, ERRORS_PANIC)) { | ||
| 2738 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; | ||
| 2739 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); | ||
| 2740 | ext4_commit_super(sb, 1); | ||
| 2741 | goto failed_mount4; | ||
| 2742 | } | ||
| 2743 | } | ||
| 2744 | } else if (test_opt(sb, NOLOAD) && !(sb->s_flags & MS_RDONLY) && | 2759 | } else if (test_opt(sb, NOLOAD) && !(sb->s_flags & MS_RDONLY) && |
| 2745 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { | 2760 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { |
| 2746 | ext4_msg(sb, KERN_ERR, "required journal recovery " | 2761 | ext4_msg(sb, KERN_ERR, "required journal recovery " |
| @@ -3668,13 +3683,11 @@ static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
| 3668 | buf->f_blocks = ext4_blocks_count(es) - sbi->s_overhead_last; | 3683 | buf->f_blocks = ext4_blocks_count(es) - sbi->s_overhead_last; |
| 3669 | buf->f_bfree = percpu_counter_sum_positive(&sbi->s_freeblocks_counter) - | 3684 | buf->f_bfree = percpu_counter_sum_positive(&sbi->s_freeblocks_counter) - |
| 3670 | percpu_counter_sum_positive(&sbi->s_dirtyblocks_counter); | 3685 | percpu_counter_sum_positive(&sbi->s_dirtyblocks_counter); |
| 3671 | ext4_free_blocks_count_set(es, buf->f_bfree); | ||
| 3672 | buf->f_bavail = buf->f_bfree - ext4_r_blocks_count(es); | 3686 | buf->f_bavail = buf->f_bfree - ext4_r_blocks_count(es); |
| 3673 | if (buf->f_bfree < ext4_r_blocks_count(es)) | 3687 | if (buf->f_bfree < ext4_r_blocks_count(es)) |
| 3674 | buf->f_bavail = 0; | 3688 | buf->f_bavail = 0; |
| 3675 | buf->f_files = le32_to_cpu(es->s_inodes_count); | 3689 | buf->f_files = le32_to_cpu(es->s_inodes_count); |
| 3676 | buf->f_ffree = percpu_counter_sum_positive(&sbi->s_freeinodes_counter); | 3690 | buf->f_ffree = percpu_counter_sum_positive(&sbi->s_freeinodes_counter); |
| 3677 | es->s_free_inodes_count = cpu_to_le32(buf->f_ffree); | ||
| 3678 | buf->f_namelen = EXT4_NAME_LEN; | 3691 | buf->f_namelen = EXT4_NAME_LEN; |
| 3679 | fsid = le64_to_cpup((void *)es->s_uuid) ^ | 3692 | fsid = le64_to_cpup((void *)es->s_uuid) ^ |
| 3680 | le64_to_cpup((void *)es->s_uuid + sizeof(u64)); | 3693 | le64_to_cpup((void *)es->s_uuid + sizeof(u64)); |
| @@ -3966,6 +3979,58 @@ static int ext4_get_sb(struct file_system_type *fs_type, int flags, | |||
| 3966 | return get_sb_bdev(fs_type, flags, dev_name, data, ext4_fill_super,mnt); | 3979 | return get_sb_bdev(fs_type, flags, dev_name, data, ext4_fill_super,mnt); |
| 3967 | } | 3980 | } |
| 3968 | 3981 | ||
| 3982 | #if !defined(CONTIG_EXT2_FS) && !defined(CONFIG_EXT2_FS_MODULE) && defined(CONFIG_EXT4_USE_FOR_EXT23) | ||
| 3983 | static struct file_system_type ext2_fs_type = { | ||
| 3984 | .owner = THIS_MODULE, | ||
| 3985 | .name = "ext2", | ||
| 3986 | .get_sb = ext4_get_sb, | ||
| 3987 | .kill_sb = kill_block_super, | ||
| 3988 | .fs_flags = FS_REQUIRES_DEV, | ||
| 3989 | }; | ||
| 3990 | |||
| 3991 | static inline void register_as_ext2(void) | ||
| 3992 | { | ||
| 3993 | int err = register_filesystem(&ext2_fs_type); | ||
| 3994 | if (err) | ||
| 3995 | printk(KERN_WARNING | ||
| 3996 | "EXT4-fs: Unable to register as ext2 (%d)\n", err); | ||
| 3997 | } | ||
| 3998 | |||
| 3999 | static inline void unregister_as_ext2(void) | ||
| 4000 | { | ||
| 4001 | unregister_filesystem(&ext2_fs_type); | ||
| 4002 | } | ||
| 4003 | #else | ||
| 4004 | static inline void register_as_ext2(void) { } | ||
| 4005 | static inline void unregister_as_ext2(void) { } | ||
| 4006 | #endif | ||
| 4007 | |||
| 4008 | #if !defined(CONTIG_EXT3_FS) && !defined(CONFIG_EXT3_FS_MODULE) && defined(CONFIG_EXT4_USE_FOR_EXT23) | ||
| 4009 | static struct file_system_type ext3_fs_type = { | ||
| 4010 | .owner = THIS_MODULE, | ||
| 4011 | .name = "ext3", | ||
| 4012 | .get_sb = ext4_get_sb, | ||
| 4013 | .kill_sb = kill_block_super, | ||
| 4014 | .fs_flags = FS_REQUIRES_DEV, | ||
| 4015 | }; | ||
| 4016 | |||
| 4017 | static inline void register_as_ext3(void) | ||
| 4018 | { | ||
| 4019 | int err = register_filesystem(&ext3_fs_type); | ||
| 4020 | if (err) | ||
| 4021 | printk(KERN_WARNING | ||
| 4022 | "EXT4-fs: Unable to register as ext3 (%d)\n", err); | ||
| 4023 | } | ||
| 4024 | |||
| 4025 | static inline void unregister_as_ext3(void) | ||
| 4026 | { | ||
| 4027 | unregister_filesystem(&ext3_fs_type); | ||
| 4028 | } | ||
| 4029 | #else | ||
| 4030 | static inline void register_as_ext3(void) { } | ||
| 4031 | static inline void unregister_as_ext3(void) { } | ||
| 4032 | #endif | ||
| 4033 | |||
| 3969 | static struct file_system_type ext4_fs_type = { | 4034 | static struct file_system_type ext4_fs_type = { |
| 3970 | .owner = THIS_MODULE, | 4035 | .owner = THIS_MODULE, |
| 3971 | .name = "ext4", | 4036 | .name = "ext4", |
| @@ -3995,11 +4060,15 @@ static int __init init_ext4_fs(void) | |||
| 3995 | err = init_inodecache(); | 4060 | err = init_inodecache(); |
| 3996 | if (err) | 4061 | if (err) |
| 3997 | goto out1; | 4062 | goto out1; |
| 4063 | register_as_ext2(); | ||
| 4064 | register_as_ext3(); | ||
| 3998 | err = register_filesystem(&ext4_fs_type); | 4065 | err = register_filesystem(&ext4_fs_type); |
| 3999 | if (err) | 4066 | if (err) |
| 4000 | goto out; | 4067 | goto out; |
| 4001 | return 0; | 4068 | return 0; |
| 4002 | out: | 4069 | out: |
| 4070 | unregister_as_ext2(); | ||
| 4071 | unregister_as_ext3(); | ||
| 4003 | destroy_inodecache(); | 4072 | destroy_inodecache(); |
| 4004 | out1: | 4073 | out1: |
| 4005 | exit_ext4_xattr(); | 4074 | exit_ext4_xattr(); |
| @@ -4015,6 +4084,8 @@ out4: | |||
| 4015 | 4084 | ||
| 4016 | static void __exit exit_ext4_fs(void) | 4085 | static void __exit exit_ext4_fs(void) |
| 4017 | { | 4086 | { |
| 4087 | unregister_as_ext2(); | ||
| 4088 | unregister_as_ext3(); | ||
| 4018 | unregister_filesystem(&ext4_fs_type); | 4089 | unregister_filesystem(&ext4_fs_type); |
| 4019 | destroy_inodecache(); | 4090 | destroy_inodecache(); |
| 4020 | exit_ext4_xattr(); | 4091 | exit_ext4_xattr(); |
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index fed5b01d7a8d..910bf9a59cb3 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c | |||
| @@ -482,9 +482,10 @@ ext4_xattr_release_block(handle_t *handle, struct inode *inode, | |||
| 482 | ea_bdebug(bh, "refcount now=0; freeing"); | 482 | ea_bdebug(bh, "refcount now=0; freeing"); |
| 483 | if (ce) | 483 | if (ce) |
| 484 | mb_cache_entry_free(ce); | 484 | mb_cache_entry_free(ce); |
| 485 | ext4_free_blocks(handle, inode, bh->b_blocknr, 1, 1); | ||
| 486 | get_bh(bh); | 485 | get_bh(bh); |
| 487 | ext4_forget(handle, 1, inode, bh, bh->b_blocknr); | 486 | ext4_free_blocks(handle, inode, bh, 0, 1, |
| 487 | EXT4_FREE_BLOCKS_METADATA | | ||
| 488 | EXT4_FREE_BLOCKS_FORGET); | ||
| 488 | } else { | 489 | } else { |
| 489 | le32_add_cpu(&BHDR(bh)->h_refcount, -1); | 490 | le32_add_cpu(&BHDR(bh)->h_refcount, -1); |
| 490 | error = ext4_handle_dirty_metadata(handle, inode, bh); | 491 | error = ext4_handle_dirty_metadata(handle, inode, bh); |
| @@ -832,7 +833,8 @@ inserted: | |||
| 832 | new_bh = sb_getblk(sb, block); | 833 | new_bh = sb_getblk(sb, block); |
| 833 | if (!new_bh) { | 834 | if (!new_bh) { |
| 834 | getblk_failed: | 835 | getblk_failed: |
| 835 | ext4_free_blocks(handle, inode, block, 1, 1); | 836 | ext4_free_blocks(handle, inode, 0, block, 1, |
| 837 | EXT4_FREE_BLOCKS_METADATA); | ||
| 836 | error = -EIO; | 838 | error = -EIO; |
| 837 | goto cleanup; | 839 | goto cleanup; |
| 838 | } | 840 | } |
| @@ -988,6 +990,10 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
| 988 | if (error) | 990 | if (error) |
| 989 | goto cleanup; | 991 | goto cleanup; |
| 990 | 992 | ||
| 993 | error = ext4_journal_get_write_access(handle, is.iloc.bh); | ||
| 994 | if (error) | ||
| 995 | goto cleanup; | ||
| 996 | |||
| 991 | if (EXT4_I(inode)->i_state & EXT4_STATE_NEW) { | 997 | if (EXT4_I(inode)->i_state & EXT4_STATE_NEW) { |
| 992 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); | 998 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); |
| 993 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); | 999 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); |
| @@ -1013,9 +1019,6 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
| 1013 | if (flags & XATTR_CREATE) | 1019 | if (flags & XATTR_CREATE) |
| 1014 | goto cleanup; | 1020 | goto cleanup; |
| 1015 | } | 1021 | } |
| 1016 | error = ext4_journal_get_write_access(handle, is.iloc.bh); | ||
| 1017 | if (error) | ||
| 1018 | goto cleanup; | ||
| 1019 | if (!value) { | 1022 | if (!value) { |
| 1020 | if (!is.s.not_found) | 1023 | if (!is.s.not_found) |
| 1021 | error = ext4_xattr_ibody_set(handle, inode, &i, &is); | 1024 | error = ext4_xattr_ibody_set(handle, inode, &i, &is); |
diff --git a/fs/file_table.c b/fs/file_table.c index 8eb44042e009..4bef4c01ec6f 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
| @@ -13,7 +13,6 @@ | |||
| 13 | #include <linux/module.h> | 13 | #include <linux/module.h> |
| 14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
| 15 | #include <linux/security.h> | 15 | #include <linux/security.h> |
| 16 | #include <linux/ima.h> | ||
| 17 | #include <linux/eventpoll.h> | 16 | #include <linux/eventpoll.h> |
| 18 | #include <linux/rcupdate.h> | 17 | #include <linux/rcupdate.h> |
| 19 | #include <linux/mount.h> | 18 | #include <linux/mount.h> |
| @@ -280,7 +279,6 @@ void __fput(struct file *file) | |||
| 280 | if (file->f_op && file->f_op->release) | 279 | if (file->f_op && file->f_op->release) |
| 281 | file->f_op->release(inode, file); | 280 | file->f_op->release(inode, file); |
| 282 | security_file_free(file); | 281 | security_file_free(file); |
| 283 | ima_file_free(file); | ||
| 284 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL)) | 282 | if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL)) |
| 285 | cdev_put(inode->i_cdev); | 283 | cdev_put(inode->i_cdev); |
| 286 | fops_put(file->f_op); | 284 | fops_put(file->f_op); |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 9d5360c4c2af..49bc1b8e8f19 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
| @@ -614,7 +614,6 @@ static void writeback_inodes_wb(struct bdi_writeback *wb, | |||
| 614 | struct writeback_control *wbc) | 614 | struct writeback_control *wbc) |
| 615 | { | 615 | { |
| 616 | struct super_block *sb = wbc->sb, *pin_sb = NULL; | 616 | struct super_block *sb = wbc->sb, *pin_sb = NULL; |
| 617 | const int is_blkdev_sb = sb_is_blkdev_sb(sb); | ||
| 618 | const unsigned long start = jiffies; /* livelock avoidance */ | 617 | const unsigned long start = jiffies; /* livelock avoidance */ |
| 619 | 618 | ||
| 620 | spin_lock(&inode_lock); | 619 | spin_lock(&inode_lock); |
| @@ -635,36 +634,11 @@ static void writeback_inodes_wb(struct bdi_writeback *wb, | |||
| 635 | continue; | 634 | continue; |
| 636 | } | 635 | } |
| 637 | 636 | ||
| 638 | if (!bdi_cap_writeback_dirty(wb->bdi)) { | ||
| 639 | redirty_tail(inode); | ||
| 640 | if (is_blkdev_sb) { | ||
| 641 | /* | ||
| 642 | * Dirty memory-backed blockdev: the ramdisk | ||
| 643 | * driver does this. Skip just this inode | ||
| 644 | */ | ||
| 645 | continue; | ||
| 646 | } | ||
| 647 | /* | ||
| 648 | * Dirty memory-backed inode against a filesystem other | ||
| 649 | * than the kernel-internal bdev filesystem. Skip the | ||
| 650 | * entire superblock. | ||
| 651 | */ | ||
| 652 | break; | ||
| 653 | } | ||
| 654 | |||
| 655 | if (inode->i_state & (I_NEW | I_WILL_FREE)) { | 637 | if (inode->i_state & (I_NEW | I_WILL_FREE)) { |
| 656 | requeue_io(inode); | 638 | requeue_io(inode); |
| 657 | continue; | 639 | continue; |
| 658 | } | 640 | } |
| 659 | 641 | ||
| 660 | if (wbc->nonblocking && bdi_write_congested(wb->bdi)) { | ||
| 661 | wbc->encountered_congestion = 1; | ||
| 662 | if (!is_blkdev_sb) | ||
| 663 | break; /* Skip a congested fs */ | ||
| 664 | requeue_io(inode); | ||
| 665 | continue; /* Skip a congested blockdev */ | ||
| 666 | } | ||
| 667 | |||
| 668 | /* | 642 | /* |
| 669 | * Was this inode dirtied after sync_sb_inodes was called? | 643 | * Was this inode dirtied after sync_sb_inodes was called? |
| 670 | * This keeps sync from extra jobs and livelock. | 644 | * This keeps sync from extra jobs and livelock. |
| @@ -756,6 +730,7 @@ static long wb_writeback(struct bdi_writeback *wb, | |||
| 756 | .sync_mode = args->sync_mode, | 730 | .sync_mode = args->sync_mode, |
| 757 | .older_than_this = NULL, | 731 | .older_than_this = NULL, |
| 758 | .for_kupdate = args->for_kupdate, | 732 | .for_kupdate = args->for_kupdate, |
| 733 | .for_background = args->for_background, | ||
| 759 | .range_cyclic = args->range_cyclic, | 734 | .range_cyclic = args->range_cyclic, |
| 760 | }; | 735 | }; |
| 761 | unsigned long oldest_jif; | 736 | unsigned long oldest_jif; |
| @@ -787,7 +762,6 @@ static long wb_writeback(struct bdi_writeback *wb, | |||
| 787 | break; | 762 | break; |
| 788 | 763 | ||
| 789 | wbc.more_io = 0; | 764 | wbc.more_io = 0; |
| 790 | wbc.encountered_congestion = 0; | ||
| 791 | wbc.nr_to_write = MAX_WRITEBACK_PAGES; | 765 | wbc.nr_to_write = MAX_WRITEBACK_PAGES; |
| 792 | wbc.pages_skipped = 0; | 766 | wbc.pages_skipped = 0; |
| 793 | writeback_inodes_wb(wb, &wbc); | 767 | writeback_inodes_wb(wb, &wbc); |
diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig index 5971359d2090..b192c661caa6 100644 --- a/fs/gfs2/Kconfig +++ b/fs/gfs2/Kconfig | |||
| @@ -8,6 +8,9 @@ config GFS2_FS | |||
| 8 | select FS_POSIX_ACL | 8 | select FS_POSIX_ACL |
| 9 | select CRC32 | 9 | select CRC32 |
| 10 | select SLOW_WORK | 10 | select SLOW_WORK |
| 11 | select QUOTA | ||
| 12 | select QUOTACTL | ||
| 13 | select FS_JOURNAL_INFO | ||
| 11 | help | 14 | help |
| 12 | A cluster filesystem. | 15 | A cluster filesystem. |
| 13 | 16 | ||
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index 3fc4e3ac7d84..3eb1ea846173 100644 --- a/fs/gfs2/acl.c +++ b/fs/gfs2/acl.c | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | #include <linux/spinlock.h> | 12 | #include <linux/spinlock.h> |
| 13 | #include <linux/completion.h> | 13 | #include <linux/completion.h> |
| 14 | #include <linux/buffer_head.h> | 14 | #include <linux/buffer_head.h> |
| 15 | #include <linux/xattr.h> | ||
| 15 | #include <linux/posix_acl.h> | 16 | #include <linux/posix_acl.h> |
| 16 | #include <linux/posix_acl_xattr.h> | 17 | #include <linux/posix_acl_xattr.h> |
| 17 | #include <linux/gfs2_ondisk.h> | 18 | #include <linux/gfs2_ondisk.h> |
| @@ -26,108 +27,44 @@ | |||
| 26 | #include "trans.h" | 27 | #include "trans.h" |
| 27 | #include "util.h" | 28 | #include "util.h" |
| 28 | 29 | ||
| 29 | #define ACL_ACCESS 1 | 30 | static const char *gfs2_acl_name(int type) |
| 30 | #define ACL_DEFAULT 0 | ||
| 31 | |||
| 32 | int gfs2_acl_validate_set(struct gfs2_inode *ip, int access, | ||
| 33 | struct gfs2_ea_request *er, int *remove, mode_t *mode) | ||
| 34 | { | 31 | { |
| 35 | struct posix_acl *acl; | 32 | switch (type) { |
| 36 | int error; | 33 | case ACL_TYPE_ACCESS: |
| 37 | 34 | return GFS2_POSIX_ACL_ACCESS; | |
| 38 | error = gfs2_acl_validate_remove(ip, access); | 35 | case ACL_TYPE_DEFAULT: |
| 39 | if (error) | 36 | return GFS2_POSIX_ACL_DEFAULT; |
| 40 | return error; | ||
| 41 | |||
| 42 | if (!er->er_data) | ||
| 43 | return -EINVAL; | ||
| 44 | |||
| 45 | acl = posix_acl_from_xattr(er->er_data, er->er_data_len); | ||
| 46 | if (IS_ERR(acl)) | ||
| 47 | return PTR_ERR(acl); | ||
| 48 | if (!acl) { | ||
| 49 | *remove = 1; | ||
| 50 | return 0; | ||
| 51 | } | ||
| 52 | |||
| 53 | error = posix_acl_valid(acl); | ||
| 54 | if (error) | ||
| 55 | goto out; | ||
| 56 | |||
| 57 | if (access) { | ||
| 58 | error = posix_acl_equiv_mode(acl, mode); | ||
| 59 | if (!error) | ||
| 60 | *remove = 1; | ||
| 61 | else if (error > 0) | ||
| 62 | error = 0; | ||
| 63 | } | 37 | } |
| 64 | 38 | return NULL; | |
| 65 | out: | ||
| 66 | posix_acl_release(acl); | ||
| 67 | return error; | ||
| 68 | } | ||
| 69 | |||
| 70 | int gfs2_acl_validate_remove(struct gfs2_inode *ip, int access) | ||
| 71 | { | ||
| 72 | if (!GFS2_SB(&ip->i_inode)->sd_args.ar_posix_acl) | ||
| 73 | return -EOPNOTSUPP; | ||
| 74 | if (!is_owner_or_cap(&ip->i_inode)) | ||
| 75 | return -EPERM; | ||
| 76 | if (S_ISLNK(ip->i_inode.i_mode)) | ||
| 77 | return -EOPNOTSUPP; | ||
| 78 | if (!access && !S_ISDIR(ip->i_inode.i_mode)) | ||
| 79 | return -EACCES; | ||
| 80 | |||
| 81 | return 0; | ||
| 82 | } | 39 | } |
| 83 | 40 | ||
| 84 | static int acl_get(struct gfs2_inode *ip, const char *name, | 41 | static struct posix_acl *gfs2_acl_get(struct gfs2_inode *ip, int type) |
| 85 | struct posix_acl **acl, struct gfs2_ea_location *el, | ||
| 86 | char **datap, unsigned int *lenp) | ||
| 87 | { | 42 | { |
| 43 | struct posix_acl *acl; | ||
| 44 | const char *name; | ||
| 88 | char *data; | 45 | char *data; |
| 89 | unsigned int len; | 46 | int len; |
| 90 | int error; | ||
| 91 | |||
| 92 | el->el_bh = NULL; | ||
| 93 | 47 | ||
| 94 | if (!ip->i_eattr) | 48 | if (!ip->i_eattr) |
| 95 | return 0; | 49 | return NULL; |
| 96 | |||
| 97 | error = gfs2_ea_find(ip, GFS2_EATYPE_SYS, name, el); | ||
| 98 | if (error) | ||
| 99 | return error; | ||
| 100 | if (!el->el_ea) | ||
| 101 | return 0; | ||
| 102 | if (!GFS2_EA_DATA_LEN(el->el_ea)) | ||
| 103 | goto out; | ||
| 104 | 50 | ||
| 105 | len = GFS2_EA_DATA_LEN(el->el_ea); | 51 | acl = get_cached_acl(&ip->i_inode, type); |
| 106 | data = kmalloc(len, GFP_NOFS); | 52 | if (acl != ACL_NOT_CACHED) |
| 107 | error = -ENOMEM; | 53 | return acl; |
| 108 | if (!data) | ||
| 109 | goto out; | ||
| 110 | 54 | ||
| 111 | error = gfs2_ea_get_copy(ip, el, data, len); | 55 | name = gfs2_acl_name(type); |
| 112 | if (error < 0) | 56 | if (name == NULL) |
| 113 | goto out_kfree; | 57 | return ERR_PTR(-EINVAL); |
| 114 | error = 0; | ||
| 115 | 58 | ||
| 116 | if (acl) { | 59 | len = gfs2_xattr_acl_get(ip, name, &data); |
| 117 | *acl = posix_acl_from_xattr(data, len); | 60 | if (len < 0) |
| 118 | if (IS_ERR(*acl)) | 61 | return ERR_PTR(len); |
| 119 | error = PTR_ERR(*acl); | 62 | if (len == 0) |
| 120 | } | 63 | return NULL; |
| 121 | 64 | ||
| 122 | out_kfree: | 65 | acl = posix_acl_from_xattr(data, len); |
| 123 | if (error || !datap) { | 66 | kfree(data); |
| 124 | kfree(data); | 67 | return acl; |
| 125 | } else { | ||
| 126 | *datap = data; | ||
| 127 | *lenp = len; | ||
| 128 | } | ||
| 129 | out: | ||
| 130 | return error; | ||
| 131 | } | 68 | } |
| 132 | 69 | ||
| 133 | /** | 70 | /** |
| @@ -140,14 +77,12 @@ out: | |||
| 140 | 77 | ||
| 141 | int gfs2_check_acl(struct inode *inode, int mask) | 78 | int gfs2_check_acl(struct inode *inode, int mask) |
| 142 | { | 79 | { |
| 143 | struct gfs2_ea_location el; | 80 | struct posix_acl *acl; |
| 144 | struct posix_acl *acl = NULL; | ||
| 145 | int error; | 81 | int error; |
| 146 | 82 | ||
| 147 | error = acl_get(GFS2_I(inode), GFS2_POSIX_ACL_ACCESS, &acl, &el, NULL, NULL); | 83 | acl = gfs2_acl_get(GFS2_I(inode), ACL_TYPE_ACCESS); |
| 148 | brelse(el.el_bh); | 84 | if (IS_ERR(acl)) |
| 149 | if (error) | 85 | return PTR_ERR(acl); |
| 150 | return error; | ||
| 151 | 86 | ||
| 152 | if (acl) { | 87 | if (acl) { |
| 153 | error = posix_acl_permission(inode, acl, mask); | 88 | error = posix_acl_permission(inode, acl, mask); |
| @@ -158,57 +93,75 @@ int gfs2_check_acl(struct inode *inode, int mask) | |||
| 158 | return -EAGAIN; | 93 | return -EAGAIN; |
| 159 | } | 94 | } |
| 160 | 95 | ||
| 161 | static int munge_mode(struct gfs2_inode *ip, mode_t mode) | 96 | static int gfs2_set_mode(struct inode *inode, mode_t mode) |
| 162 | { | 97 | { |
| 163 | struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); | 98 | int error = 0; |
| 164 | struct buffer_head *dibh; | ||
| 165 | int error; | ||
| 166 | 99 | ||
| 167 | error = gfs2_trans_begin(sdp, RES_DINODE, 0); | 100 | if (mode != inode->i_mode) { |
| 168 | if (error) | 101 | struct iattr iattr; |
| 169 | return error; | ||
| 170 | 102 | ||
| 171 | error = gfs2_meta_inode_buffer(ip, &dibh); | 103 | iattr.ia_valid = ATTR_MODE; |
| 172 | if (!error) { | 104 | iattr.ia_mode = mode; |
| 173 | gfs2_assert_withdraw(sdp, | 105 | |
| 174 | (ip->i_inode.i_mode & S_IFMT) == (mode & S_IFMT)); | 106 | error = gfs2_setattr_simple(GFS2_I(inode), &iattr); |
| 175 | ip->i_inode.i_mode = mode; | ||
| 176 | gfs2_trans_add_bh(ip->i_gl, dibh, 1); | ||
| 177 | gfs2_dinode_out(ip, dibh->b_data); | ||
| 178 | brelse(dibh); | ||
| 179 | } | 107 | } |
| 180 | 108 | ||
| 181 | gfs2_trans_end(sdp); | 109 | return error; |
| 110 | } | ||
| 111 | |||
| 112 | static int gfs2_acl_set(struct inode *inode, int type, struct posix_acl *acl) | ||
| 113 | { | ||
| 114 | int error; | ||
| 115 | int len; | ||
| 116 | char *data; | ||
| 117 | const char *name = gfs2_acl_name(type); | ||
| 182 | 118 | ||
| 183 | return 0; | 119 | BUG_ON(name == NULL); |
| 120 | len = posix_acl_to_xattr(acl, NULL, 0); | ||
| 121 | if (len == 0) | ||
| 122 | return 0; | ||
| 123 | data = kmalloc(len, GFP_NOFS); | ||
| 124 | if (data == NULL) | ||
| 125 | return -ENOMEM; | ||
| 126 | error = posix_acl_to_xattr(acl, data, len); | ||
| 127 | if (error < 0) | ||
| 128 | goto out; | ||
| 129 | error = gfs2_xattr_set(inode, GFS2_EATYPE_SYS, name, data, len, 0); | ||
| 130 | if (!error) | ||
| 131 | set_cached_acl(inode, type, acl); | ||
| 132 | out: | ||
| 133 | kfree(data); | ||
| 134 | return error; | ||
| 184 | } | 135 | } |
| 185 | 136 | ||
| 186 | int gfs2_acl_create(struct gfs2_inode *dip, struct gfs2_inode *ip) | 137 | int gfs2_acl_create(struct gfs2_inode *dip, struct inode *inode) |
| 187 | { | 138 | { |
| 188 | struct gfs2_ea_location el; | ||
| 189 | struct gfs2_sbd *sdp = GFS2_SB(&dip->i_inode); | 139 | struct gfs2_sbd *sdp = GFS2_SB(&dip->i_inode); |
| 190 | struct posix_acl *acl = NULL, *clone; | 140 | struct posix_acl *acl, *clone; |
| 191 | mode_t mode = ip->i_inode.i_mode; | 141 | mode_t mode = inode->i_mode; |
| 192 | char *data = NULL; | 142 | int error = 0; |
| 193 | unsigned int len; | ||
| 194 | int error; | ||
| 195 | 143 | ||
| 196 | if (!sdp->sd_args.ar_posix_acl) | 144 | if (!sdp->sd_args.ar_posix_acl) |
| 197 | return 0; | 145 | return 0; |
| 198 | if (S_ISLNK(ip->i_inode.i_mode)) | 146 | if (S_ISLNK(inode->i_mode)) |
| 199 | return 0; | 147 | return 0; |
| 200 | 148 | ||
| 201 | error = acl_get(dip, GFS2_POSIX_ACL_DEFAULT, &acl, &el, &data, &len); | 149 | acl = gfs2_acl_get(dip, ACL_TYPE_DEFAULT); |
| 202 | brelse(el.el_bh); | 150 | if (IS_ERR(acl)) |
| 203 | if (error) | 151 | return PTR_ERR(acl); |
| 204 | return error; | ||
| 205 | if (!acl) { | 152 | if (!acl) { |
| 206 | mode &= ~current_umask(); | 153 | mode &= ~current_umask(); |
| 207 | if (mode != ip->i_inode.i_mode) | 154 | if (mode != inode->i_mode) |
| 208 | error = munge_mode(ip, mode); | 155 | error = gfs2_set_mode(inode, mode); |
| 209 | return error; | 156 | return error; |
| 210 | } | 157 | } |
| 211 | 158 | ||
| 159 | if (S_ISDIR(inode->i_mode)) { | ||
| 160 | error = gfs2_acl_set(inode, ACL_TYPE_DEFAULT, acl); | ||
| 161 | if (error) | ||
| 162 | goto out; | ||
| 163 | } | ||
| 164 | |||
| 212 | clone = posix_acl_clone(acl, GFP_NOFS); | 165 | clone = posix_acl_clone(acl, GFP_NOFS); |
| 213 | error = -ENOMEM; | 166 | error = -ENOMEM; |
| 214 | if (!clone) | 167 | if (!clone) |
| @@ -216,43 +169,32 @@ int gfs2_acl_create(struct gfs2_inode *dip, struct gfs2_inode *ip) | |||
| 216 | posix_acl_release(acl); | 169 | posix_acl_release(acl); |
| 217 | acl = clone; | 170 | acl = clone; |
| 218 | 171 | ||
| 219 | if (S_ISDIR(ip->i_inode.i_mode)) { | ||
| 220 | error = gfs2_xattr_set(&ip->i_inode, GFS2_EATYPE_SYS, | ||
| 221 | GFS2_POSIX_ACL_DEFAULT, data, len, 0); | ||
| 222 | if (error) | ||
| 223 | goto out; | ||
| 224 | } | ||
| 225 | |||
| 226 | error = posix_acl_create_masq(acl, &mode); | 172 | error = posix_acl_create_masq(acl, &mode); |
| 227 | if (error < 0) | 173 | if (error < 0) |
| 228 | goto out; | 174 | goto out; |
| 229 | if (error == 0) | 175 | if (error == 0) |
| 230 | goto munge; | 176 | goto munge; |
| 231 | 177 | ||
| 232 | posix_acl_to_xattr(acl, data, len); | 178 | error = gfs2_acl_set(inode, ACL_TYPE_ACCESS, acl); |
| 233 | error = gfs2_xattr_set(&ip->i_inode, GFS2_EATYPE_SYS, | ||
| 234 | GFS2_POSIX_ACL_ACCESS, data, len, 0); | ||
| 235 | if (error) | 179 | if (error) |
| 236 | goto out; | 180 | goto out; |
| 237 | munge: | 181 | munge: |
| 238 | error = munge_mode(ip, mode); | 182 | error = gfs2_set_mode(inode, mode); |
| 239 | out: | 183 | out: |
| 240 | posix_acl_release(acl); | 184 | posix_acl_release(acl); |
| 241 | kfree(data); | ||
| 242 | return error; | 185 | return error; |
| 243 | } | 186 | } |
| 244 | 187 | ||
| 245 | int gfs2_acl_chmod(struct gfs2_inode *ip, struct iattr *attr) | 188 | int gfs2_acl_chmod(struct gfs2_inode *ip, struct iattr *attr) |
| 246 | { | 189 | { |
| 247 | struct posix_acl *acl = NULL, *clone; | 190 | struct posix_acl *acl, *clone; |
| 248 | struct gfs2_ea_location el; | ||
| 249 | char *data; | 191 | char *data; |
| 250 | unsigned int len; | 192 | unsigned int len; |
| 251 | int error; | 193 | int error; |
| 252 | 194 | ||
| 253 | error = acl_get(ip, GFS2_POSIX_ACL_ACCESS, &acl, &el, &data, &len); | 195 | acl = gfs2_acl_get(ip, ACL_TYPE_ACCESS); |
| 254 | if (error) | 196 | if (IS_ERR(acl)) |
| 255 | goto out_brelse; | 197 | return PTR_ERR(acl); |
| 256 | if (!acl) | 198 | if (!acl) |
| 257 | return gfs2_setattr_simple(ip, attr); | 199 | return gfs2_setattr_simple(ip, attr); |
| 258 | 200 | ||
| @@ -265,15 +207,134 @@ int gfs2_acl_chmod(struct gfs2_inode *ip, struct iattr *attr) | |||
| 265 | 207 | ||
| 266 | error = posix_acl_chmod_masq(acl, attr->ia_mode); | 208 | error = posix_acl_chmod_masq(acl, attr->ia_mode); |
| 267 | if (!error) { | 209 | if (!error) { |
| 210 | len = posix_acl_to_xattr(acl, NULL, 0); | ||
| 211 | data = kmalloc(len, GFP_NOFS); | ||
| 212 | error = -ENOMEM; | ||
| 213 | if (data == NULL) | ||
| 214 | goto out; | ||
| 268 | posix_acl_to_xattr(acl, data, len); | 215 | posix_acl_to_xattr(acl, data, len); |
| 269 | error = gfs2_ea_acl_chmod(ip, &el, attr, data); | 216 | error = gfs2_xattr_acl_chmod(ip, attr, data); |
| 217 | kfree(data); | ||
| 218 | set_cached_acl(&ip->i_inode, ACL_TYPE_ACCESS, acl); | ||
| 270 | } | 219 | } |
| 271 | 220 | ||
| 272 | out: | 221 | out: |
| 273 | posix_acl_release(acl); | 222 | posix_acl_release(acl); |
| 274 | kfree(data); | ||
| 275 | out_brelse: | ||
| 276 | brelse(el.el_bh); | ||
| 277 | return error; | 223 | return error; |
| 278 | } | 224 | } |
| 279 | 225 | ||
| 226 | static int gfs2_acl_type(const char *name) | ||
| 227 | { | ||
| 228 | if (strcmp(name, GFS2_POSIX_ACL_ACCESS) == 0) | ||
| 229 | return ACL_TYPE_ACCESS; | ||
| 230 | if (strcmp(name, GFS2_POSIX_ACL_DEFAULT) == 0) | ||
| 231 | return ACL_TYPE_DEFAULT; | ||
| 232 | return -EINVAL; | ||
| 233 | } | ||
| 234 | |||
| 235 | static int gfs2_xattr_system_get(struct inode *inode, const char *name, | ||
| 236 | void *buffer, size_t size) | ||
| 237 | { | ||
| 238 | struct posix_acl *acl; | ||
| 239 | int type; | ||
| 240 | int error; | ||
| 241 | |||
| 242 | type = gfs2_acl_type(name); | ||
| 243 | if (type < 0) | ||
| 244 | return type; | ||
| 245 | |||
| 246 | acl = gfs2_acl_get(GFS2_I(inode), type); | ||
| 247 | if (IS_ERR(acl)) | ||
| 248 | return PTR_ERR(acl); | ||
| 249 | if (acl == NULL) | ||
| 250 | return -ENODATA; | ||
| 251 | |||
| 252 | error = posix_acl_to_xattr(acl, buffer, size); | ||
| 253 | posix_acl_release(acl); | ||
| 254 | |||
| 255 | return error; | ||
| 256 | } | ||
| 257 | |||
| 258 | static int gfs2_xattr_system_set(struct inode *inode, const char *name, | ||
| 259 | const void *value, size_t size, int flags) | ||
| 260 | { | ||
| 261 | struct gfs2_sbd *sdp = GFS2_SB(inode); | ||
| 262 | struct posix_acl *acl = NULL; | ||
| 263 | int error = 0, type; | ||
| 264 | |||
| 265 | if (!sdp->sd_args.ar_posix_acl) | ||
| 266 | return -EOPNOTSUPP; | ||
| 267 | |||
| 268 | type = gfs2_acl_type(name); | ||
| 269 | if (type < 0) | ||
| 270 | return type; | ||
| 271 | if (flags & XATTR_CREATE) | ||
| 272 | return -EINVAL; | ||
| 273 | if (type == ACL_TYPE_DEFAULT && !S_ISDIR(inode->i_mode)) | ||
| 274 | return value ? -EACCES : 0; | ||
| 275 | if ((current_fsuid() != inode->i_uid) && !capable(CAP_FOWNER)) | ||
| 276 | return -EPERM; | ||
| 277 | if (S_ISLNK(inode->i_mode)) | ||
| 278 | return -EOPNOTSUPP; | ||
| 279 | |||
| 280 | if (!value) | ||
| 281 | goto set_acl; | ||
| 282 | |||
| 283 | acl = posix_acl_from_xattr(value, size); | ||
| 284 | if (!acl) { | ||
| 285 | /* | ||
| 286 | * acl_set_file(3) may request that we set default ACLs with | ||
| 287 | * zero length -- defend (gracefully) against that here. | ||
| 288 | */ | ||
| 289 | goto out; | ||
| 290 | } | ||
| 291 | if (IS_ERR(acl)) { | ||
| 292 | error = PTR_ERR(acl); | ||
| 293 | goto out; | ||
| 294 | } | ||
| 295 | |||
| 296 | error = posix_acl_valid(acl); | ||
| 297 | if (error) | ||
| 298 | goto out_release; | ||
| 299 | |||
| 300 | error = -EINVAL; | ||
| 301 | if (acl->a_count > GFS2_ACL_MAX_ENTRIES) | ||
| 302 | goto out_release; | ||
| 303 | |||
| 304 | if (type == ACL_TYPE_ACCESS) { | ||
| 305 | mode_t mode = inode->i_mode; | ||
| 306 | error = posix_acl_equiv_mode(acl, &mode); | ||
| 307 | |||
| 308 | if (error <= 0) { | ||
| 309 | posix_acl_release(acl); | ||
| 310 | acl = NULL; | ||
| 311 | |||
| 312 | if (error < 0) | ||
| 313 | return error; | ||
| 314 | } | ||
| 315 | |||
| 316 | error = gfs2_set_mode(inode, mode); | ||
| 317 | if (error) | ||
| 318 | goto out_release; | ||
| 319 | } | ||
| 320 | |||
| 321 | set_acl: | ||
| 322 | error = gfs2_xattr_set(inode, GFS2_EATYPE_SYS, name, value, size, 0); | ||
| 323 | if (!error) { | ||
| 324 | if (acl) | ||
| 325 | set_cached_acl(inode, type, acl); | ||
| 326 | else | ||
| 327 | forget_cached_acl(inode, type); | ||
| 328 | } | ||
| 329 | out_release: | ||
| 330 | posix_acl_release(acl); | ||
| 331 | out: | ||
| 332 | return error; | ||
| 333 | } | ||
| 334 | |||
| 335 | struct xattr_handler gfs2_xattr_system_handler = { | ||
| 336 | .prefix = XATTR_SYSTEM_PREFIX, | ||
| 337 | .get = gfs2_xattr_system_get, | ||
| 338 | .set = gfs2_xattr_system_set, | ||
| 339 | }; | ||
| 340 | |||
diff --git a/fs/gfs2/acl.h b/fs/gfs2/acl.h index 6751930bfb64..9306a2e6620c 100644 --- a/fs/gfs2/acl.h +++ b/fs/gfs2/acl.h | |||
| @@ -13,26 +13,12 @@ | |||
| 13 | #include "incore.h" | 13 | #include "incore.h" |
| 14 | 14 | ||
| 15 | #define GFS2_POSIX_ACL_ACCESS "posix_acl_access" | 15 | #define GFS2_POSIX_ACL_ACCESS "posix_acl_access" |
| 16 | #define GFS2_POSIX_ACL_ACCESS_LEN 16 | ||
| 17 | #define GFS2_POSIX_ACL_DEFAULT "posix_acl_default" | 16 | #define GFS2_POSIX_ACL_DEFAULT "posix_acl_default" |
| 18 | #define GFS2_POSIX_ACL_DEFAULT_LEN 17 | 17 | #define GFS2_ACL_MAX_ENTRIES 25 |
| 19 | 18 | ||
| 20 | #define GFS2_ACL_IS_ACCESS(name, len) \ | 19 | extern int gfs2_check_acl(struct inode *inode, int mask); |
| 21 | ((len) == GFS2_POSIX_ACL_ACCESS_LEN && \ | 20 | extern int gfs2_acl_create(struct gfs2_inode *dip, struct inode *inode); |
| 22 | !memcmp(GFS2_POSIX_ACL_ACCESS, (name), (len))) | 21 | extern int gfs2_acl_chmod(struct gfs2_inode *ip, struct iattr *attr); |
| 23 | 22 | extern struct xattr_handler gfs2_xattr_system_handler; | |
| 24 | #define GFS2_ACL_IS_DEFAULT(name, len) \ | ||
| 25 | ((len) == GFS2_POSIX_ACL_DEFAULT_LEN && \ | ||
| 26 | !memcmp(GFS2_POSIX_ACL_DEFAULT, (name), (len))) | ||
| 27 | |||
| 28 | struct gfs2_ea_request; | ||
| 29 | |||
| 30 | int gfs2_acl_validate_set(struct gfs2_inode *ip, int access, | ||
| 31 | struct gfs2_ea_request *er, | ||
| 32 | int *remove, mode_t *mode); | ||
| 33 | int gfs2_acl_validate_remove(struct gfs2_inode *ip, int access); | ||
| 34 | int gfs2_check_acl(struct inode *inode, int mask); | ||
| 35 | int gfs2_acl_create(struct gfs2_inode *dip, struct gfs2_inode *ip); | ||
| 36 | int gfs2_acl_chmod(struct gfs2_inode *ip, struct iattr *attr); | ||
| 37 | 23 | ||
| 38 | #endif /* __ACL_DOT_H__ */ | 24 | #endif /* __ACL_DOT_H__ */ |
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 694b5d48f036..7b8da9415267 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c | |||
| @@ -269,7 +269,6 @@ static int gfs2_write_jdata_pagevec(struct address_space *mapping, | |||
| 269 | pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT; | 269 | pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT; |
| 270 | unsigned offset = i_size & (PAGE_CACHE_SIZE-1); | 270 | unsigned offset = i_size & (PAGE_CACHE_SIZE-1); |
| 271 | unsigned nrblocks = nr_pages * (PAGE_CACHE_SIZE/inode->i_sb->s_blocksize); | 271 | unsigned nrblocks = nr_pages * (PAGE_CACHE_SIZE/inode->i_sb->s_blocksize); |
| 272 | struct backing_dev_info *bdi = mapping->backing_dev_info; | ||
| 273 | int i; | 272 | int i; |
| 274 | int ret; | 273 | int ret; |
| 275 | 274 | ||
| @@ -313,11 +312,6 @@ static int gfs2_write_jdata_pagevec(struct address_space *mapping, | |||
| 313 | 312 | ||
| 314 | if (ret || (--(wbc->nr_to_write) <= 0)) | 313 | if (ret || (--(wbc->nr_to_write) <= 0)) |
| 315 | ret = 1; | 314 | ret = 1; |
| 316 | if (wbc->nonblocking && bdi_write_congested(bdi)) { | ||
| 317 | wbc->encountered_congestion = 1; | ||
| 318 | ret = 1; | ||
| 319 | } | ||
| 320 | |||
| 321 | } | 315 | } |
| 322 | gfs2_trans_end(sdp); | 316 | gfs2_trans_end(sdp); |
| 323 | return ret; | 317 | return ret; |
| @@ -338,7 +332,6 @@ static int gfs2_write_jdata_pagevec(struct address_space *mapping, | |||
| 338 | static int gfs2_write_cache_jdata(struct address_space *mapping, | 332 | static int gfs2_write_cache_jdata(struct address_space *mapping, |
| 339 | struct writeback_control *wbc) | 333 | struct writeback_control *wbc) |
| 340 | { | 334 | { |
| 341 | struct backing_dev_info *bdi = mapping->backing_dev_info; | ||
| 342 | int ret = 0; | 335 | int ret = 0; |
| 343 | int done = 0; | 336 | int done = 0; |
| 344 | struct pagevec pvec; | 337 | struct pagevec pvec; |
| @@ -348,11 +341,6 @@ static int gfs2_write_cache_jdata(struct address_space *mapping, | |||
| 348 | int scanned = 0; | 341 | int scanned = 0; |
| 349 | int range_whole = 0; | 342 | int range_whole = 0; |
| 350 | 343 | ||
| 351 | if (wbc->nonblocking && bdi_write_congested(bdi)) { | ||
| 352 | wbc->encountered_congestion = 1; | ||
| 353 | return 0; | ||
| 354 | } | ||
| 355 | |||
| 356 | pagevec_init(&pvec, 0); | 344 | pagevec_init(&pvec, 0); |
| 357 | if (wbc->range_cyclic) { | 345 | if (wbc->range_cyclic) { |
| 358 | index = mapping->writeback_index; /* Start from prev offset */ | 346 | index = mapping->writeback_index; /* Start from prev offset */ |
| @@ -819,8 +807,10 @@ static int gfs2_stuffed_write_end(struct inode *inode, struct buffer_head *dibh, | |||
| 819 | mark_inode_dirty(inode); | 807 | mark_inode_dirty(inode); |
| 820 | } | 808 | } |
| 821 | 809 | ||
| 822 | if (inode == sdp->sd_rindex) | 810 | if (inode == sdp->sd_rindex) { |
| 823 | adjust_fs_space(inode); | 811 | adjust_fs_space(inode); |
| 812 | ip->i_gh.gh_flags |= GL_NOCACHE; | ||
| 813 | } | ||
| 824 | 814 | ||
| 825 | brelse(dibh); | 815 | brelse(dibh); |
| 826 | gfs2_trans_end(sdp); | 816 | gfs2_trans_end(sdp); |
| @@ -889,8 +879,10 @@ static int gfs2_write_end(struct file *file, struct address_space *mapping, | |||
| 889 | mark_inode_dirty(inode); | 879 | mark_inode_dirty(inode); |
| 890 | } | 880 | } |
| 891 | 881 | ||
| 892 | if (inode == sdp->sd_rindex) | 882 | if (inode == sdp->sd_rindex) { |
| 893 | adjust_fs_space(inode); | 883 | adjust_fs_space(inode); |
| 884 | ip->i_gh.gh_flags |= GL_NOCACHE; | ||
| 885 | } | ||
| 894 | 886 | ||
| 895 | brelse(dibh); | 887 | brelse(dibh); |
| 896 | gfs2_trans_end(sdp); | 888 | gfs2_trans_end(sdp); |
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 297d7e5cebad..25fddc100f18 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c | |||
| @@ -525,38 +525,6 @@ consist_inode: | |||
| 525 | return ERR_PTR(-EIO); | 525 | return ERR_PTR(-EIO); |
| 526 | } | 526 | } |
| 527 | 527 | ||
| 528 | |||
| 529 | /** | ||
| 530 | * dirent_first - Return the first dirent | ||
| 531 | * @dip: the directory | ||
| 532 | * @bh: The buffer | ||
| 533 | * @dent: Pointer to list of dirents | ||
| 534 | * | ||
| 535 | * return first dirent whether bh points to leaf or stuffed dinode | ||
| 536 | * | ||
| 537 | * Returns: IS_LEAF, IS_DINODE, or -errno | ||
| 538 | */ | ||
| 539 | |||
| 540 | static int dirent_first(struct gfs2_inode *dip, struct buffer_head *bh, | ||
| 541 | struct gfs2_dirent **dent) | ||
| 542 | { | ||
| 543 | struct gfs2_meta_header *h = (struct gfs2_meta_header *)bh->b_data; | ||
| 544 | |||
| 545 | if (be32_to_cpu(h->mh_type) == GFS2_METATYPE_LF) { | ||
| 546 | if (gfs2_meta_check(GFS2_SB(&dip->i_inode), bh)) | ||
| 547 | return -EIO; | ||
| 548 | *dent = (struct gfs2_dirent *)(bh->b_data + | ||
| 549 | sizeof(struct gfs2_leaf)); | ||
| 550 | return IS_LEAF; | ||
| 551 | } else { | ||
| 552 | if (gfs2_metatype_check(GFS2_SB(&dip->i_inode), bh, GFS2_METATYPE_DI)) | ||
| 553 | return -EIO; | ||
| 554 | *dent = (struct gfs2_dirent *)(bh->b_data + | ||
| 555 | sizeof(struct gfs2_dinode)); | ||
| 556 | return IS_DINODE; | ||
| 557 | } | ||
| 558 | } | ||
| 559 | |||
| 560 | static int dirent_check_reclen(struct gfs2_inode *dip, | 528 | static int dirent_check_reclen(struct gfs2_inode *dip, |
| 561 | const struct gfs2_dirent *d, const void *end_p) | 529 | const struct gfs2_dirent *d, const void *end_p) |
| 562 | { | 530 | { |
| @@ -1006,7 +974,7 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name) | |||
| 1006 | divider = (start + half_len) << (32 - dip->i_depth); | 974 | divider = (start + half_len) << (32 - dip->i_depth); |
| 1007 | 975 | ||
| 1008 | /* Copy the entries */ | 976 | /* Copy the entries */ |
| 1009 | dirent_first(dip, obh, &dent); | 977 | dent = (struct gfs2_dirent *)(obh->b_data + sizeof(struct gfs2_leaf)); |
| 1010 | 978 | ||
| 1011 | do { | 979 | do { |
| 1012 | next = dent; | 980 | next = dent; |
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 8b674b1f3a55..f455a03a09e2 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
| @@ -241,15 +241,14 @@ int gfs2_glock_put(struct gfs2_glock *gl) | |||
| 241 | int rv = 0; | 241 | int rv = 0; |
| 242 | 242 | ||
| 243 | write_lock(gl_lock_addr(gl->gl_hash)); | 243 | write_lock(gl_lock_addr(gl->gl_hash)); |
| 244 | if (atomic_dec_and_test(&gl->gl_ref)) { | 244 | if (atomic_dec_and_lock(&gl->gl_ref, &lru_lock)) { |
| 245 | hlist_del(&gl->gl_list); | 245 | hlist_del(&gl->gl_list); |
| 246 | write_unlock(gl_lock_addr(gl->gl_hash)); | ||
| 247 | spin_lock(&lru_lock); | ||
| 248 | if (!list_empty(&gl->gl_lru)) { | 246 | if (!list_empty(&gl->gl_lru)) { |
| 249 | list_del_init(&gl->gl_lru); | 247 | list_del_init(&gl->gl_lru); |
| 250 | atomic_dec(&lru_count); | 248 | atomic_dec(&lru_count); |
| 251 | } | 249 | } |
| 252 | spin_unlock(&lru_lock); | 250 | spin_unlock(&lru_lock); |
| 251 | write_unlock(gl_lock_addr(gl->gl_hash)); | ||
| 253 | GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders)); | 252 | GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders)); |
| 254 | glock_free(gl); | 253 | glock_free(gl); |
| 255 | rv = 1; | 254 | rv = 1; |
| @@ -513,7 +512,6 @@ retry: | |||
| 513 | GLOCK_BUG_ON(gl, 1); | 512 | GLOCK_BUG_ON(gl, 1); |
| 514 | } | 513 | } |
| 515 | spin_unlock(&gl->gl_spin); | 514 | spin_unlock(&gl->gl_spin); |
| 516 | gfs2_glock_put(gl); | ||
| 517 | return; | 515 | return; |
| 518 | } | 516 | } |
| 519 | 517 | ||
| @@ -524,8 +522,6 @@ retry: | |||
| 524 | if (glops->go_xmote_bh) { | 522 | if (glops->go_xmote_bh) { |
| 525 | spin_unlock(&gl->gl_spin); | 523 | spin_unlock(&gl->gl_spin); |
| 526 | rv = glops->go_xmote_bh(gl, gh); | 524 | rv = glops->go_xmote_bh(gl, gh); |
| 527 | if (rv == -EAGAIN) | ||
| 528 | return; | ||
| 529 | spin_lock(&gl->gl_spin); | 525 | spin_lock(&gl->gl_spin); |
| 530 | if (rv) { | 526 | if (rv) { |
| 531 | do_error(gl, rv); | 527 | do_error(gl, rv); |
| @@ -540,7 +536,6 @@ out: | |||
| 540 | clear_bit(GLF_LOCK, &gl->gl_flags); | 536 | clear_bit(GLF_LOCK, &gl->gl_flags); |
| 541 | out_locked: | 537 | out_locked: |
| 542 | spin_unlock(&gl->gl_spin); | 538 | spin_unlock(&gl->gl_spin); |
| 543 | gfs2_glock_put(gl); | ||
| 544 | } | 539 | } |
| 545 | 540 | ||
| 546 | static unsigned int gfs2_lm_lock(struct gfs2_sbd *sdp, void *lock, | 541 | static unsigned int gfs2_lm_lock(struct gfs2_sbd *sdp, void *lock, |
| @@ -600,7 +595,6 @@ __acquires(&gl->gl_spin) | |||
| 600 | 595 | ||
| 601 | if (!(ret & LM_OUT_ASYNC)) { | 596 | if (!(ret & LM_OUT_ASYNC)) { |
| 602 | finish_xmote(gl, ret); | 597 | finish_xmote(gl, ret); |
| 603 | gfs2_glock_hold(gl); | ||
| 604 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | 598 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) |
| 605 | gfs2_glock_put(gl); | 599 | gfs2_glock_put(gl); |
| 606 | } else { | 600 | } else { |
| @@ -672,12 +666,17 @@ out: | |||
| 672 | return; | 666 | return; |
| 673 | 667 | ||
| 674 | out_sched: | 668 | out_sched: |
| 669 | clear_bit(GLF_LOCK, &gl->gl_flags); | ||
| 670 | smp_mb__after_clear_bit(); | ||
| 675 | gfs2_glock_hold(gl); | 671 | gfs2_glock_hold(gl); |
| 676 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | 672 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) |
| 677 | gfs2_glock_put_nolock(gl); | 673 | gfs2_glock_put_nolock(gl); |
| 674 | return; | ||
| 675 | |||
| 678 | out_unlock: | 676 | out_unlock: |
| 679 | clear_bit(GLF_LOCK, &gl->gl_flags); | 677 | clear_bit(GLF_LOCK, &gl->gl_flags); |
| 680 | goto out; | 678 | smp_mb__after_clear_bit(); |
| 679 | return; | ||
| 681 | } | 680 | } |
| 682 | 681 | ||
| 683 | static void delete_work_func(struct work_struct *work) | 682 | static void delete_work_func(struct work_struct *work) |
| @@ -707,9 +706,12 @@ static void glock_work_func(struct work_struct *work) | |||
| 707 | { | 706 | { |
| 708 | unsigned long delay = 0; | 707 | unsigned long delay = 0; |
| 709 | struct gfs2_glock *gl = container_of(work, struct gfs2_glock, gl_work.work); | 708 | struct gfs2_glock *gl = container_of(work, struct gfs2_glock, gl_work.work); |
| 709 | int drop_ref = 0; | ||
| 710 | 710 | ||
| 711 | if (test_and_clear_bit(GLF_REPLY_PENDING, &gl->gl_flags)) | 711 | if (test_and_clear_bit(GLF_REPLY_PENDING, &gl->gl_flags)) { |
| 712 | finish_xmote(gl, gl->gl_reply); | 712 | finish_xmote(gl, gl->gl_reply); |
| 713 | drop_ref = 1; | ||
| 714 | } | ||
| 713 | down_read(&gfs2_umount_flush_sem); | 715 | down_read(&gfs2_umount_flush_sem); |
| 714 | spin_lock(&gl->gl_spin); | 716 | spin_lock(&gl->gl_spin); |
| 715 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && | 717 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && |
| @@ -727,6 +729,8 @@ static void glock_work_func(struct work_struct *work) | |||
| 727 | if (!delay || | 729 | if (!delay || |
| 728 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) | 730 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) |
| 729 | gfs2_glock_put(gl); | 731 | gfs2_glock_put(gl); |
| 732 | if (drop_ref) | ||
| 733 | gfs2_glock_put(gl); | ||
| 730 | } | 734 | } |
| 731 | 735 | ||
| 732 | /** | 736 | /** |
| @@ -1361,10 +1365,6 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask) | |||
| 1361 | list_del_init(&gl->gl_lru); | 1365 | list_del_init(&gl->gl_lru); |
| 1362 | atomic_dec(&lru_count); | 1366 | atomic_dec(&lru_count); |
| 1363 | 1367 | ||
| 1364 | /* Check if glock is about to be freed */ | ||
| 1365 | if (atomic_read(&gl->gl_ref) == 0) | ||
| 1366 | continue; | ||
| 1367 | |||
| 1368 | /* Test for being demotable */ | 1368 | /* Test for being demotable */ |
| 1369 | if (!test_and_set_bit(GLF_LOCK, &gl->gl_flags)) { | 1369 | if (!test_and_set_bit(GLF_LOCK, &gl->gl_flags)) { |
| 1370 | gfs2_glock_hold(gl); | 1370 | gfs2_glock_hold(gl); |
| @@ -1375,10 +1375,11 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask) | |||
| 1375 | handle_callback(gl, LM_ST_UNLOCKED, 0); | 1375 | handle_callback(gl, LM_ST_UNLOCKED, 0); |
| 1376 | nr--; | 1376 | nr--; |
| 1377 | } | 1377 | } |
| 1378 | clear_bit(GLF_LOCK, &gl->gl_flags); | ||
| 1379 | smp_mb__after_clear_bit(); | ||
| 1378 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) | 1380 | if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) |
| 1379 | gfs2_glock_put_nolock(gl); | 1381 | gfs2_glock_put_nolock(gl); |
| 1380 | spin_unlock(&gl->gl_spin); | 1382 | spin_unlock(&gl->gl_spin); |
| 1381 | clear_bit(GLF_LOCK, &gl->gl_flags); | ||
| 1382 | spin_lock(&lru_lock); | 1383 | spin_lock(&lru_lock); |
| 1383 | continue; | 1384 | continue; |
| 1384 | } | 1385 | } |
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h index c609894ec0d0..13f0bd228132 100644 --- a/fs/gfs2/glock.h +++ b/fs/gfs2/glock.h | |||
| @@ -180,15 +180,6 @@ static inline int gfs2_glock_is_held_shrd(struct gfs2_glock *gl) | |||
| 180 | return gl->gl_state == LM_ST_SHARED; | 180 | return gl->gl_state == LM_ST_SHARED; |
| 181 | } | 181 | } |
| 182 | 182 | ||
| 183 | static inline int gfs2_glock_is_blocking(struct gfs2_glock *gl) | ||
| 184 | { | ||
| 185 | int ret; | ||
| 186 | spin_lock(&gl->gl_spin); | ||
| 187 | ret = test_bit(GLF_DEMOTE, &gl->gl_flags); | ||
| 188 | spin_unlock(&gl->gl_spin); | ||
| 189 | return ret; | ||
| 190 | } | ||
| 191 | |||
| 192 | int gfs2_glock_get(struct gfs2_sbd *sdp, | 183 | int gfs2_glock_get(struct gfs2_sbd *sdp, |
| 193 | u64 number, const struct gfs2_glock_operations *glops, | 184 | u64 number, const struct gfs2_glock_operations *glops, |
| 194 | int create, struct gfs2_glock **glp); | 185 | int create, struct gfs2_glock **glp); |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 6985eef06c39..78554acc0605 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
| 14 | #include <linux/gfs2_ondisk.h> | 14 | #include <linux/gfs2_ondisk.h> |
| 15 | #include <linux/bio.h> | 15 | #include <linux/bio.h> |
| 16 | #include <linux/posix_acl.h> | ||
| 16 | 17 | ||
| 17 | #include "gfs2.h" | 18 | #include "gfs2.h" |
| 18 | #include "incore.h" | 19 | #include "incore.h" |
| @@ -184,8 +185,10 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags) | |||
| 184 | if (flags & DIO_METADATA) { | 185 | if (flags & DIO_METADATA) { |
| 185 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 186 | struct address_space *mapping = gl->gl_aspace->i_mapping; |
| 186 | truncate_inode_pages(mapping, 0); | 187 | truncate_inode_pages(mapping, 0); |
| 187 | if (ip) | 188 | if (ip) { |
| 188 | set_bit(GIF_INVALID, &ip->i_flags); | 189 | set_bit(GIF_INVALID, &ip->i_flags); |
| 190 | forget_all_cached_acls(&ip->i_inode); | ||
| 191 | } | ||
| 189 | } | 192 | } |
| 190 | 193 | ||
| 191 | if (ip == GFS2_I(gl->gl_sbd->sd_rindex)) | 194 | if (ip == GFS2_I(gl->gl_sbd->sd_rindex)) |
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 6edb423f90b3..4792200978c8 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h | |||
| @@ -429,7 +429,11 @@ struct gfs2_args { | |||
| 429 | unsigned int ar_meta:1; /* mount metafs */ | 429 | unsigned int ar_meta:1; /* mount metafs */ |
| 430 | unsigned int ar_discard:1; /* discard requests */ | 430 | unsigned int ar_discard:1; /* discard requests */ |
| 431 | unsigned int ar_errors:2; /* errors=withdraw | panic */ | 431 | unsigned int ar_errors:2; /* errors=withdraw | panic */ |
| 432 | unsigned int ar_nobarrier:1; /* do not send barriers */ | ||
| 432 | int ar_commit; /* Commit interval */ | 433 | int ar_commit; /* Commit interval */ |
| 434 | int ar_statfs_quantum; /* The fast statfs interval */ | ||
| 435 | int ar_quota_quantum; /* The quota interval */ | ||
| 436 | int ar_statfs_percent; /* The % change to force sync */ | ||
| 433 | }; | 437 | }; |
| 434 | 438 | ||
| 435 | struct gfs2_tune { | 439 | struct gfs2_tune { |
| @@ -558,6 +562,7 @@ struct gfs2_sbd { | |||
| 558 | spinlock_t sd_statfs_spin; | 562 | spinlock_t sd_statfs_spin; |
| 559 | struct gfs2_statfs_change_host sd_statfs_master; | 563 | struct gfs2_statfs_change_host sd_statfs_master; |
| 560 | struct gfs2_statfs_change_host sd_statfs_local; | 564 | struct gfs2_statfs_change_host sd_statfs_local; |
| 565 | int sd_statfs_force_sync; | ||
| 561 | 566 | ||
| 562 | /* Resource group stuff */ | 567 | /* Resource group stuff */ |
| 563 | 568 | ||
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index fb15d3b1f409..26ba2a4c4a2d 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
| @@ -871,7 +871,7 @@ struct inode *gfs2_createi(struct gfs2_holder *ghs, const struct qstr *name, | |||
| 871 | if (error) | 871 | if (error) |
| 872 | goto fail_gunlock2; | 872 | goto fail_gunlock2; |
| 873 | 873 | ||
| 874 | error = gfs2_acl_create(dip, GFS2_I(inode)); | 874 | error = gfs2_acl_create(dip, inode); |
| 875 | if (error) | 875 | if (error) |
| 876 | goto fail_gunlock2; | 876 | goto fail_gunlock2; |
| 877 | 877 | ||
| @@ -947,9 +947,7 @@ void gfs2_dinode_out(const struct gfs2_inode *ip, void *buf) | |||
| 947 | 947 | ||
| 948 | str->di_header.mh_magic = cpu_to_be32(GFS2_MAGIC); | 948 | str->di_header.mh_magic = cpu_to_be32(GFS2_MAGIC); |
| 949 | str->di_header.mh_type = cpu_to_be32(GFS2_METATYPE_DI); | 949 | str->di_header.mh_type = cpu_to_be32(GFS2_METATYPE_DI); |
| 950 | str->di_header.__pad0 = 0; | ||
| 951 | str->di_header.mh_format = cpu_to_be32(GFS2_FORMAT_DI); | 950 | str->di_header.mh_format = cpu_to_be32(GFS2_FORMAT_DI); |
| 952 | str->di_header.__pad1 = 0; | ||
| 953 | str->di_num.no_addr = cpu_to_be64(ip->i_no_addr); | 951 | str->di_num.no_addr = cpu_to_be64(ip->i_no_addr); |
| 954 | str->di_num.no_formal_ino = cpu_to_be64(ip->i_no_formal_ino); | 952 | str->di_num.no_formal_ino = cpu_to_be64(ip->i_no_formal_ino); |
| 955 | str->di_mode = cpu_to_be32(ip->i_inode.i_mode); | 953 | str->di_mode = cpu_to_be32(ip->i_inode.i_mode); |
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 13c6237c5f67..4511b08fc451 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c | |||
| @@ -596,7 +596,9 @@ static void log_write_header(struct gfs2_sbd *sdp, u32 flags, int pull) | |||
| 596 | memset(lh, 0, sizeof(struct gfs2_log_header)); | 596 | memset(lh, 0, sizeof(struct gfs2_log_header)); |
| 597 | lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC); | 597 | lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC); |
| 598 | lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH); | 598 | lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH); |
| 599 | lh->lh_header.__pad0 = cpu_to_be64(0); | ||
| 599 | lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH); | 600 | lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH); |
| 601 | lh->lh_header.mh_jid = cpu_to_be32(sdp->sd_jdesc->jd_jid); | ||
| 600 | lh->lh_sequence = cpu_to_be64(sdp->sd_log_sequence++); | 602 | lh->lh_sequence = cpu_to_be64(sdp->sd_log_sequence++); |
| 601 | lh->lh_flags = cpu_to_be32(flags); | 603 | lh->lh_flags = cpu_to_be32(flags); |
| 602 | lh->lh_tail = cpu_to_be32(tail); | 604 | lh->lh_tail = cpu_to_be32(tail); |
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 9969ff062c5b..de97632ba32f 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c | |||
| @@ -132,6 +132,7 @@ static struct buffer_head *gfs2_get_log_desc(struct gfs2_sbd *sdp, u32 ld_type) | |||
| 132 | static void buf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le) | 132 | static void buf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le) |
| 133 | { | 133 | { |
| 134 | struct gfs2_bufdata *bd = container_of(le, struct gfs2_bufdata, bd_le); | 134 | struct gfs2_bufdata *bd = container_of(le, struct gfs2_bufdata, bd_le); |
| 135 | struct gfs2_meta_header *mh; | ||
| 135 | struct gfs2_trans *tr; | 136 | struct gfs2_trans *tr; |
| 136 | 137 | ||
| 137 | lock_buffer(bd->bd_bh); | 138 | lock_buffer(bd->bd_bh); |
| @@ -148,6 +149,9 @@ static void buf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le) | |||
| 148 | set_bit(GLF_DIRTY, &bd->bd_gl->gl_flags); | 149 | set_bit(GLF_DIRTY, &bd->bd_gl->gl_flags); |
| 149 | gfs2_meta_check(sdp, bd->bd_bh); | 150 | gfs2_meta_check(sdp, bd->bd_bh); |
| 150 | gfs2_pin(sdp, bd->bd_bh); | 151 | gfs2_pin(sdp, bd->bd_bh); |
| 152 | mh = (struct gfs2_meta_header *)bd->bd_bh->b_data; | ||
| 153 | mh->__pad0 = cpu_to_be64(0); | ||
| 154 | mh->mh_jid = cpu_to_be32(sdp->sd_jdesc->jd_jid); | ||
| 151 | sdp->sd_log_num_buf++; | 155 | sdp->sd_log_num_buf++; |
| 152 | list_add(&le->le_list, &sdp->sd_log_le_buf); | 156 | list_add(&le->le_list, &sdp->sd_log_le_buf); |
| 153 | tr->tr_num_buf_new++; | 157 | tr->tr_num_buf_new++; |
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 52fb6c048981..edfee24f3636 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include <linux/mount.h> | 18 | #include <linux/mount.h> |
| 19 | #include <linux/gfs2_ondisk.h> | 19 | #include <linux/gfs2_ondisk.h> |
| 20 | #include <linux/slow-work.h> | 20 | #include <linux/slow-work.h> |
| 21 | #include <linux/quotaops.h> | ||
| 21 | 22 | ||
| 22 | #include "gfs2.h" | 23 | #include "gfs2.h" |
| 23 | #include "incore.h" | 24 | #include "incore.h" |
| @@ -62,13 +63,10 @@ static void gfs2_tune_init(struct gfs2_tune *gt) | |||
| 62 | gt->gt_quota_warn_period = 10; | 63 | gt->gt_quota_warn_period = 10; |
| 63 | gt->gt_quota_scale_num = 1; | 64 | gt->gt_quota_scale_num = 1; |
| 64 | gt->gt_quota_scale_den = 1; | 65 | gt->gt_quota_scale_den = 1; |
| 65 | gt->gt_quota_quantum = 60; | ||
| 66 | gt->gt_new_files_jdata = 0; | 66 | gt->gt_new_files_jdata = 0; |
| 67 | gt->gt_max_readahead = 1 << 18; | 67 | gt->gt_max_readahead = 1 << 18; |
| 68 | gt->gt_stall_secs = 600; | 68 | gt->gt_stall_secs = 600; |
| 69 | gt->gt_complain_secs = 10; | 69 | gt->gt_complain_secs = 10; |
| 70 | gt->gt_statfs_quantum = 30; | ||
| 71 | gt->gt_statfs_slow = 0; | ||
| 72 | } | 70 | } |
| 73 | 71 | ||
| 74 | static struct gfs2_sbd *init_sbd(struct super_block *sb) | 72 | static struct gfs2_sbd *init_sbd(struct super_block *sb) |
| @@ -1114,7 +1112,7 @@ void gfs2_online_uevent(struct gfs2_sbd *sdp) | |||
| 1114 | * Returns: errno | 1112 | * Returns: errno |
| 1115 | */ | 1113 | */ |
| 1116 | 1114 | ||
| 1117 | static int fill_super(struct super_block *sb, void *data, int silent) | 1115 | static int fill_super(struct super_block *sb, struct gfs2_args *args, int silent) |
| 1118 | { | 1116 | { |
| 1119 | struct gfs2_sbd *sdp; | 1117 | struct gfs2_sbd *sdp; |
| 1120 | struct gfs2_holder mount_gh; | 1118 | struct gfs2_holder mount_gh; |
| @@ -1125,17 +1123,7 @@ static int fill_super(struct super_block *sb, void *data, int silent) | |||
| 1125 | printk(KERN_WARNING "GFS2: can't alloc struct gfs2_sbd\n"); | 1123 | printk(KERN_WARNING "GFS2: can't alloc struct gfs2_sbd\n"); |
| 1126 | return -ENOMEM; | 1124 | return -ENOMEM; |
| 1127 | } | 1125 | } |
| 1128 | 1126 | sdp->sd_args = *args; | |
| 1129 | sdp->sd_args.ar_quota = GFS2_QUOTA_DEFAULT; | ||
| 1130 | sdp->sd_args.ar_data = GFS2_DATA_DEFAULT; | ||
| 1131 | sdp->sd_args.ar_commit = 60; | ||
| 1132 | sdp->sd_args.ar_errors = GFS2_ERRORS_DEFAULT; | ||
| 1133 | |||
| 1134 | error = gfs2_mount_args(sdp, &sdp->sd_args, data); | ||
| 1135 | if (error) { | ||
| 1136 | printk(KERN_WARNING "GFS2: can't parse mount arguments\n"); | ||
| 1137 | goto fail; | ||
| 1138 | } | ||
| 1139 | 1127 | ||
| 1140 | if (sdp->sd_args.ar_spectator) { | 1128 | if (sdp->sd_args.ar_spectator) { |
| 1141 | sb->s_flags |= MS_RDONLY; | 1129 | sb->s_flags |= MS_RDONLY; |
| @@ -1143,11 +1131,15 @@ static int fill_super(struct super_block *sb, void *data, int silent) | |||
| 1143 | } | 1131 | } |
| 1144 | if (sdp->sd_args.ar_posix_acl) | 1132 | if (sdp->sd_args.ar_posix_acl) |
| 1145 | sb->s_flags |= MS_POSIXACL; | 1133 | sb->s_flags |= MS_POSIXACL; |
| 1134 | if (sdp->sd_args.ar_nobarrier) | ||
| 1135 | set_bit(SDF_NOBARRIERS, &sdp->sd_flags); | ||
| 1146 | 1136 | ||
| 1147 | sb->s_magic = GFS2_MAGIC; | 1137 | sb->s_magic = GFS2_MAGIC; |
| 1148 | sb->s_op = &gfs2_super_ops; | 1138 | sb->s_op = &gfs2_super_ops; |
| 1149 | sb->s_export_op = &gfs2_export_ops; | 1139 | sb->s_export_op = &gfs2_export_ops; |
| 1150 | sb->s_xattr = gfs2_xattr_handlers; | 1140 | sb->s_xattr = gfs2_xattr_handlers; |
| 1141 | sb->s_qcop = &gfs2_quotactl_ops; | ||
| 1142 | sb_dqopt(sb)->flags |= DQUOT_QUOTA_SYS_FILE; | ||
| 1151 | sb->s_time_gran = 1; | 1143 | sb->s_time_gran = 1; |
| 1152 | sb->s_maxbytes = MAX_LFS_FILESIZE; | 1144 | sb->s_maxbytes = MAX_LFS_FILESIZE; |
| 1153 | 1145 | ||
| @@ -1160,6 +1152,15 @@ static int fill_super(struct super_block *sb, void *data, int silent) | |||
| 1160 | sdp->sd_fsb2bb = 1 << sdp->sd_fsb2bb_shift; | 1152 | sdp->sd_fsb2bb = 1 << sdp->sd_fsb2bb_shift; |
| 1161 | 1153 | ||
| 1162 | sdp->sd_tune.gt_log_flush_secs = sdp->sd_args.ar_commit; | 1154 | sdp->sd_tune.gt_log_flush_secs = sdp->sd_args.ar_commit; |
| 1155 | sdp->sd_tune.gt_quota_quantum = sdp->sd_args.ar_quota_quantum; | ||
| 1156 | if (sdp->sd_args.ar_statfs_quantum) { | ||
| 1157 | sdp->sd_tune.gt_statfs_slow = 0; | ||
| 1158 | sdp->sd_tune.gt_statfs_quantum = sdp->sd_args.ar_statfs_quantum; | ||
| 1159 | } | ||
| 1160 | else { | ||
| 1161 | sdp->sd_tune.gt_statfs_slow = 1; | ||
| 1162 | sdp->sd_tune.gt_statfs_quantum = 30; | ||
| 1163 | } | ||
| 1163 | 1164 | ||
| 1164 | error = init_names(sdp, silent); | 1165 | error = init_names(sdp, silent); |
| 1165 | if (error) | 1166 | if (error) |
| @@ -1243,18 +1244,127 @@ fail: | |||
| 1243 | return error; | 1244 | return error; |
| 1244 | } | 1245 | } |
| 1245 | 1246 | ||
| 1246 | static int gfs2_get_sb(struct file_system_type *fs_type, int flags, | 1247 | static int set_gfs2_super(struct super_block *s, void *data) |
| 1247 | const char *dev_name, void *data, struct vfsmount *mnt) | ||
| 1248 | { | 1248 | { |
| 1249 | return get_sb_bdev(fs_type, flags, dev_name, data, fill_super, mnt); | 1249 | s->s_bdev = data; |
| 1250 | s->s_dev = s->s_bdev->bd_dev; | ||
| 1251 | |||
| 1252 | /* | ||
| 1253 | * We set the bdi here to the queue backing, file systems can | ||
| 1254 | * overwrite this in ->fill_super() | ||
| 1255 | */ | ||
| 1256 | s->s_bdi = &bdev_get_queue(s->s_bdev)->backing_dev_info; | ||
| 1257 | return 0; | ||
| 1250 | } | 1258 | } |
| 1251 | 1259 | ||
| 1252 | static int test_meta_super(struct super_block *s, void *ptr) | 1260 | static int test_gfs2_super(struct super_block *s, void *ptr) |
| 1253 | { | 1261 | { |
| 1254 | struct block_device *bdev = ptr; | 1262 | struct block_device *bdev = ptr; |
| 1255 | return (bdev == s->s_bdev); | 1263 | return (bdev == s->s_bdev); |
| 1256 | } | 1264 | } |
| 1257 | 1265 | ||
| 1266 | /** | ||
| 1267 | * gfs2_get_sb - Get the GFS2 superblock | ||
| 1268 | * @fs_type: The GFS2 filesystem type | ||
| 1269 | * @flags: Mount flags | ||
| 1270 | * @dev_name: The name of the device | ||
| 1271 | * @data: The mount arguments | ||
| 1272 | * @mnt: The vfsmnt for this mount | ||
| 1273 | * | ||
| 1274 | * Q. Why not use get_sb_bdev() ? | ||
| 1275 | * A. We need to select one of two root directories to mount, independent | ||
| 1276 | * of whether this is the initial, or subsequent, mount of this sb | ||
| 1277 | * | ||
| 1278 | * Returns: 0 or -ve on error | ||
| 1279 | */ | ||
| 1280 | |||
| 1281 | static int gfs2_get_sb(struct file_system_type *fs_type, int flags, | ||
| 1282 | const char *dev_name, void *data, struct vfsmount *mnt) | ||
| 1283 | { | ||
| 1284 | struct block_device *bdev; | ||
| 1285 | struct super_block *s; | ||
| 1286 | fmode_t mode = FMODE_READ; | ||
| 1287 | int error; | ||
| 1288 | struct gfs2_args args; | ||
| 1289 | struct gfs2_sbd *sdp; | ||
| 1290 | |||
| 1291 | if (!(flags & MS_RDONLY)) | ||
| 1292 | mode |= FMODE_WRITE; | ||
| 1293 | |||
| 1294 | bdev = open_bdev_exclusive(dev_name, mode, fs_type); | ||
| 1295 | if (IS_ERR(bdev)) | ||
| 1296 | return PTR_ERR(bdev); | ||
| 1297 | |||
| 1298 | /* | ||
| 1299 | * once the super is inserted into the list by sget, s_umount | ||
| 1300 | * will protect the lockfs code from trying to start a snapshot | ||
| 1301 | * while we are mounting | ||
| 1302 | */ | ||
| 1303 | mutex_lock(&bdev->bd_fsfreeze_mutex); | ||
| 1304 | if (bdev->bd_fsfreeze_count > 0) { | ||
| 1305 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
| 1306 | error = -EBUSY; | ||
| 1307 | goto error_bdev; | ||
| 1308 | } | ||
| 1309 | s = sget(fs_type, test_gfs2_super, set_gfs2_super, bdev); | ||
| 1310 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | ||
| 1311 | error = PTR_ERR(s); | ||
| 1312 | if (IS_ERR(s)) | ||
| 1313 | goto error_bdev; | ||
| 1314 | |||
| 1315 | memset(&args, 0, sizeof(args)); | ||
| 1316 | args.ar_quota = GFS2_QUOTA_DEFAULT; | ||
| 1317 | args.ar_data = GFS2_DATA_DEFAULT; | ||
| 1318 | args.ar_commit = 60; | ||
| 1319 | args.ar_statfs_quantum = 30; | ||
| 1320 | args.ar_quota_quantum = 60; | ||
| 1321 | args.ar_errors = GFS2_ERRORS_DEFAULT; | ||
| 1322 | |||
| 1323 | error = gfs2_mount_args(&args, data); | ||
| 1324 | if (error) { | ||
| 1325 | printk(KERN_WARNING "GFS2: can't parse mount arguments\n"); | ||
| 1326 | if (s->s_root) | ||
| 1327 | goto error_super; | ||
| 1328 | deactivate_locked_super(s); | ||
| 1329 | return error; | ||
| 1330 | } | ||
| 1331 | |||
| 1332 | if (s->s_root) { | ||
| 1333 | error = -EBUSY; | ||
| 1334 | if ((flags ^ s->s_flags) & MS_RDONLY) | ||
| 1335 | goto error_super; | ||
| 1336 | close_bdev_exclusive(bdev, mode); | ||
| 1337 | } else { | ||
| 1338 | char b[BDEVNAME_SIZE]; | ||
| 1339 | |||
| 1340 | s->s_flags = flags; | ||
| 1341 | s->s_mode = mode; | ||
| 1342 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); | ||
| 1343 | sb_set_blocksize(s, block_size(bdev)); | ||
| 1344 | error = fill_super(s, &args, flags & MS_SILENT ? 1 : 0); | ||
| 1345 | if (error) { | ||
| 1346 | deactivate_locked_super(s); | ||
| 1347 | return error; | ||
| 1348 | } | ||
| 1349 | s->s_flags |= MS_ACTIVE; | ||
| 1350 | bdev->bd_super = s; | ||
| 1351 | } | ||
| 1352 | |||
| 1353 | sdp = s->s_fs_info; | ||
| 1354 | mnt->mnt_sb = s; | ||
| 1355 | if (args.ar_meta) | ||
| 1356 | mnt->mnt_root = dget(sdp->sd_master_dir); | ||
| 1357 | else | ||
| 1358 | mnt->mnt_root = dget(sdp->sd_root_dir); | ||
| 1359 | return 0; | ||
| 1360 | |||
| 1361 | error_super: | ||
| 1362 | deactivate_locked_super(s); | ||
| 1363 | error_bdev: | ||
| 1364 | close_bdev_exclusive(bdev, mode); | ||
| 1365 | return error; | ||
| 1366 | } | ||
| 1367 | |||
| 1258 | static int set_meta_super(struct super_block *s, void *ptr) | 1368 | static int set_meta_super(struct super_block *s, void *ptr) |
| 1259 | { | 1369 | { |
| 1260 | return -EINVAL; | 1370 | return -EINVAL; |
| @@ -1274,13 +1384,17 @@ static int gfs2_get_sb_meta(struct file_system_type *fs_type, int flags, | |||
| 1274 | dev_name, error); | 1384 | dev_name, error); |
| 1275 | return error; | 1385 | return error; |
| 1276 | } | 1386 | } |
| 1277 | s = sget(&gfs2_fs_type, test_meta_super, set_meta_super, | 1387 | s = sget(&gfs2_fs_type, test_gfs2_super, set_meta_super, |
| 1278 | path.dentry->d_inode->i_sb->s_bdev); | 1388 | path.dentry->d_inode->i_sb->s_bdev); |
| 1279 | path_put(&path); | 1389 | path_put(&path); |
| 1280 | if (IS_ERR(s)) { | 1390 | if (IS_ERR(s)) { |
| 1281 | printk(KERN_WARNING "GFS2: gfs2 mount does not exist\n"); | 1391 | printk(KERN_WARNING "GFS2: gfs2 mount does not exist\n"); |
| 1282 | return PTR_ERR(s); | 1392 | return PTR_ERR(s); |
| 1283 | } | 1393 | } |
| 1394 | if ((flags ^ s->s_flags) & MS_RDONLY) { | ||
| 1395 | deactivate_locked_super(s); | ||
| 1396 | return -EBUSY; | ||
| 1397 | } | ||
| 1284 | sdp = s->s_fs_info; | 1398 | sdp = s->s_fs_info; |
| 1285 | mnt->mnt_sb = s; | 1399 | mnt->mnt_sb = s; |
| 1286 | mnt->mnt_root = dget(sdp->sd_master_dir); | 1400 | mnt->mnt_root = dget(sdp->sd_master_dir); |
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 2e9b9326bfc9..e3bf6eab8750 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c | |||
| @@ -15,7 +15,7 @@ | |||
| 15 | * fuzziness in the current usage value of IDs that are being used on different | 15 | * fuzziness in the current usage value of IDs that are being used on different |
| 16 | * nodes in the cluster simultaneously. So, it is possible for a user on | 16 | * nodes in the cluster simultaneously. So, it is possible for a user on |
| 17 | * multiple nodes to overrun their quota, but that overrun is controlable. | 17 | * multiple nodes to overrun their quota, but that overrun is controlable. |
| 18 | * Since quota tags are part of transactions, there is no need to a quota check | 18 | * Since quota tags are part of transactions, there is no need for a quota check |
| 19 | * program to be run on node crashes or anything like that. | 19 | * program to be run on node crashes or anything like that. |
| 20 | * | 20 | * |
| 21 | * There are couple of knobs that let the administrator manage the quota | 21 | * There are couple of knobs that let the administrator manage the quota |
| @@ -47,6 +47,8 @@ | |||
| 47 | #include <linux/gfs2_ondisk.h> | 47 | #include <linux/gfs2_ondisk.h> |
| 48 | #include <linux/kthread.h> | 48 | #include <linux/kthread.h> |
| 49 | #include <linux/freezer.h> | 49 | #include <linux/freezer.h> |
| 50 | #include <linux/quota.h> | ||
| 51 | #include <linux/dqblk_xfs.h> | ||
| 50 | 52 | ||
| 51 | #include "gfs2.h" | 53 | #include "gfs2.h" |
| 52 | #include "incore.h" | 54 | #include "incore.h" |
| @@ -65,13 +67,6 @@ | |||
| 65 | #define QUOTA_USER 1 | 67 | #define QUOTA_USER 1 |
| 66 | #define QUOTA_GROUP 0 | 68 | #define QUOTA_GROUP 0 |
| 67 | 69 | ||
| 68 | struct gfs2_quota_host { | ||
| 69 | u64 qu_limit; | ||
| 70 | u64 qu_warn; | ||
| 71 | s64 qu_value; | ||
| 72 | u32 qu_ll_next; | ||
| 73 | }; | ||
| 74 | |||
| 75 | struct gfs2_quota_change_host { | 70 | struct gfs2_quota_change_host { |
| 76 | u64 qc_change; | 71 | u64 qc_change; |
| 77 | u32 qc_flags; /* GFS2_QCF_... */ | 72 | u32 qc_flags; /* GFS2_QCF_... */ |
| @@ -164,7 +159,7 @@ fail: | |||
| 164 | return error; | 159 | return error; |
| 165 | } | 160 | } |
| 166 | 161 | ||
| 167 | static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | 162 | static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, |
| 168 | struct gfs2_quota_data **qdp) | 163 | struct gfs2_quota_data **qdp) |
| 169 | { | 164 | { |
| 170 | struct gfs2_quota_data *qd = NULL, *new_qd = NULL; | 165 | struct gfs2_quota_data *qd = NULL, *new_qd = NULL; |
| @@ -202,7 +197,7 @@ static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | |||
| 202 | 197 | ||
| 203 | spin_unlock(&qd_lru_lock); | 198 | spin_unlock(&qd_lru_lock); |
| 204 | 199 | ||
| 205 | if (qd || !create) { | 200 | if (qd) { |
| 206 | if (new_qd) { | 201 | if (new_qd) { |
| 207 | gfs2_glock_put(new_qd->qd_gl); | 202 | gfs2_glock_put(new_qd->qd_gl); |
| 208 | kmem_cache_free(gfs2_quotad_cachep, new_qd); | 203 | kmem_cache_free(gfs2_quotad_cachep, new_qd); |
| @@ -461,12 +456,12 @@ static void qd_unlock(struct gfs2_quota_data *qd) | |||
| 461 | qd_put(qd); | 456 | qd_put(qd); |
| 462 | } | 457 | } |
| 463 | 458 | ||
| 464 | static int qdsb_get(struct gfs2_sbd *sdp, int user, u32 id, int create, | 459 | static int qdsb_get(struct gfs2_sbd *sdp, int user, u32 id, |
| 465 | struct gfs2_quota_data **qdp) | 460 | struct gfs2_quota_data **qdp) |
| 466 | { | 461 | { |
| 467 | int error; | 462 | int error; |
| 468 | 463 | ||
| 469 | error = qd_get(sdp, user, id, create, qdp); | 464 | error = qd_get(sdp, user, id, qdp); |
| 470 | if (error) | 465 | if (error) |
| 471 | return error; | 466 | return error; |
| 472 | 467 | ||
| @@ -508,20 +503,20 @@ int gfs2_quota_hold(struct gfs2_inode *ip, u32 uid, u32 gid) | |||
| 508 | if (sdp->sd_args.ar_quota == GFS2_QUOTA_OFF) | 503 | if (sdp->sd_args.ar_quota == GFS2_QUOTA_OFF) |
| 509 | return 0; | 504 | return 0; |
| 510 | 505 | ||
| 511 | error = qdsb_get(sdp, QUOTA_USER, ip->i_inode.i_uid, CREATE, qd); | 506 | error = qdsb_get(sdp, QUOTA_USER, ip->i_inode.i_uid, qd); |
| 512 | if (error) | 507 | if (error) |
| 513 | goto out; | 508 | goto out; |
| 514 | al->al_qd_num++; | 509 | al->al_qd_num++; |
| 515 | qd++; | 510 | qd++; |
| 516 | 511 | ||
| 517 | error = qdsb_get(sdp, QUOTA_GROUP, ip->i_inode.i_gid, CREATE, qd); | 512 | error = qdsb_get(sdp, QUOTA_GROUP, ip->i_inode.i_gid, qd); |
| 518 | if (error) | 513 | if (error) |
| 519 | goto out; | 514 | goto out; |
| 520 | al->al_qd_num++; | 515 | al->al_qd_num++; |
| 521 | qd++; | 516 | qd++; |
| 522 | 517 | ||
| 523 | if (uid != NO_QUOTA_CHANGE && uid != ip->i_inode.i_uid) { | 518 | if (uid != NO_QUOTA_CHANGE && uid != ip->i_inode.i_uid) { |
| 524 | error = qdsb_get(sdp, QUOTA_USER, uid, CREATE, qd); | 519 | error = qdsb_get(sdp, QUOTA_USER, uid, qd); |
| 525 | if (error) | 520 | if (error) |
| 526 | goto out; | 521 | goto out; |
| 527 | al->al_qd_num++; | 522 | al->al_qd_num++; |
| @@ -529,7 +524,7 @@ int gfs2_quota_hold(struct gfs2_inode *ip, u32 uid, u32 gid) | |||
| 529 | } | 524 | } |
| 530 | 525 | ||
| 531 | if (gid != NO_QUOTA_CHANGE && gid != ip->i_inode.i_gid) { | 526 | if (gid != NO_QUOTA_CHANGE && gid != ip->i_inode.i_gid) { |
| 532 | error = qdsb_get(sdp, QUOTA_GROUP, gid, CREATE, qd); | 527 | error = qdsb_get(sdp, QUOTA_GROUP, gid, qd); |
| 533 | if (error) | 528 | if (error) |
| 534 | goto out; | 529 | goto out; |
| 535 | al->al_qd_num++; | 530 | al->al_qd_num++; |
| @@ -617,48 +612,36 @@ static void do_qc(struct gfs2_quota_data *qd, s64 change) | |||
| 617 | mutex_unlock(&sdp->sd_quota_mutex); | 612 | mutex_unlock(&sdp->sd_quota_mutex); |
| 618 | } | 613 | } |
| 619 | 614 | ||
| 620 | static void gfs2_quota_in(struct gfs2_quota_host *qu, const void *buf) | ||
| 621 | { | ||
| 622 | const struct gfs2_quota *str = buf; | ||
| 623 | |||
| 624 | qu->qu_limit = be64_to_cpu(str->qu_limit); | ||
| 625 | qu->qu_warn = be64_to_cpu(str->qu_warn); | ||
| 626 | qu->qu_value = be64_to_cpu(str->qu_value); | ||
| 627 | qu->qu_ll_next = be32_to_cpu(str->qu_ll_next); | ||
| 628 | } | ||
| 629 | |||
| 630 | static void gfs2_quota_out(const struct gfs2_quota_host *qu, void *buf) | ||
| 631 | { | ||
| 632 | struct gfs2_quota *str = buf; | ||
| 633 | |||
| 634 | str->qu_limit = cpu_to_be64(qu->qu_limit); | ||
| 635 | str->qu_warn = cpu_to_be64(qu->qu_warn); | ||
| 636 | str->qu_value = cpu_to_be64(qu->qu_value); | ||
| 637 | str->qu_ll_next = cpu_to_be32(qu->qu_ll_next); | ||
| 638 | memset(&str->qu_reserved, 0, sizeof(str->qu_reserved)); | ||
| 639 | } | ||
| 640 | |||
| 641 | /** | 615 | /** |
| 642 | * gfs2_adjust_quota | 616 | * gfs2_adjust_quota - adjust record of current block usage |
| 617 | * @ip: The quota inode | ||
| 618 | * @loc: Offset of the entry in the quota file | ||
| 619 | * @change: The amount of usage change to record | ||
| 620 | * @qd: The quota data | ||
| 621 | * @fdq: The updated limits to record | ||
| 643 | * | 622 | * |
| 644 | * This function was mostly borrowed from gfs2_block_truncate_page which was | 623 | * This function was mostly borrowed from gfs2_block_truncate_page which was |
| 645 | * in turn mostly borrowed from ext3 | 624 | * in turn mostly borrowed from ext3 |
| 625 | * | ||
| 626 | * Returns: 0 or -ve on error | ||
| 646 | */ | 627 | */ |
| 628 | |||
| 647 | static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc, | 629 | static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc, |
| 648 | s64 change, struct gfs2_quota_data *qd) | 630 | s64 change, struct gfs2_quota_data *qd, |
| 631 | struct fs_disk_quota *fdq) | ||
| 649 | { | 632 | { |
| 650 | struct inode *inode = &ip->i_inode; | 633 | struct inode *inode = &ip->i_inode; |
| 651 | struct address_space *mapping = inode->i_mapping; | 634 | struct address_space *mapping = inode->i_mapping; |
| 652 | unsigned long index = loc >> PAGE_CACHE_SHIFT; | 635 | unsigned long index = loc >> PAGE_CACHE_SHIFT; |
| 653 | unsigned offset = loc & (PAGE_CACHE_SIZE - 1); | 636 | unsigned offset = loc & (PAGE_CACHE_SIZE - 1); |
| 654 | unsigned blocksize, iblock, pos; | 637 | unsigned blocksize, iblock, pos; |
| 655 | struct buffer_head *bh; | 638 | struct buffer_head *bh, *dibh; |
| 656 | struct page *page; | 639 | struct page *page; |
| 657 | void *kaddr; | 640 | void *kaddr; |
| 658 | char *ptr; | 641 | struct gfs2_quota *qp; |
| 659 | struct gfs2_quota_host qp; | ||
| 660 | s64 value; | 642 | s64 value; |
| 661 | int err = -EIO; | 643 | int err = -EIO; |
| 644 | u64 size; | ||
| 662 | 645 | ||
| 663 | if (gfs2_is_stuffed(ip)) | 646 | if (gfs2_is_stuffed(ip)) |
| 664 | gfs2_unstuff_dinode(ip, NULL); | 647 | gfs2_unstuff_dinode(ip, NULL); |
| @@ -700,18 +683,38 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc, | |||
| 700 | gfs2_trans_add_bh(ip->i_gl, bh, 0); | 683 | gfs2_trans_add_bh(ip->i_gl, bh, 0); |
| 701 | 684 | ||
| 702 | kaddr = kmap_atomic(page, KM_USER0); | 685 | kaddr = kmap_atomic(page, KM_USER0); |
| 703 | ptr = kaddr + offset; | 686 | qp = kaddr + offset; |
| 704 | gfs2_quota_in(&qp, ptr); | 687 | value = (s64)be64_to_cpu(qp->qu_value) + change; |
| 705 | qp.qu_value += change; | 688 | qp->qu_value = cpu_to_be64(value); |
| 706 | value = qp.qu_value; | 689 | qd->qd_qb.qb_value = qp->qu_value; |
| 707 | gfs2_quota_out(&qp, ptr); | 690 | if (fdq) { |
| 691 | if (fdq->d_fieldmask & FS_DQ_BSOFT) { | ||
| 692 | qp->qu_warn = cpu_to_be64(fdq->d_blk_softlimit); | ||
| 693 | qd->qd_qb.qb_warn = qp->qu_warn; | ||
| 694 | } | ||
| 695 | if (fdq->d_fieldmask & FS_DQ_BHARD) { | ||
| 696 | qp->qu_limit = cpu_to_be64(fdq->d_blk_hardlimit); | ||
| 697 | qd->qd_qb.qb_limit = qp->qu_limit; | ||
| 698 | } | ||
| 699 | } | ||
| 708 | flush_dcache_page(page); | 700 | flush_dcache_page(page); |
| 709 | kunmap_atomic(kaddr, KM_USER0); | 701 | kunmap_atomic(kaddr, KM_USER0); |
| 710 | err = 0; | 702 | |
| 711 | qd->qd_qb.qb_magic = cpu_to_be32(GFS2_MAGIC); | 703 | err = gfs2_meta_inode_buffer(ip, &dibh); |
| 712 | qd->qd_qb.qb_value = cpu_to_be64(value); | 704 | if (err) |
| 713 | ((struct gfs2_quota_lvb*)(qd->qd_gl->gl_lvb))->qb_magic = cpu_to_be32(GFS2_MAGIC); | 705 | goto unlock; |
| 714 | ((struct gfs2_quota_lvb*)(qd->qd_gl->gl_lvb))->qb_value = cpu_to_be64(value); | 706 | |
| 707 | size = loc + sizeof(struct gfs2_quota); | ||
| 708 | if (size > inode->i_size) { | ||
| 709 | ip->i_disksize = size; | ||
| 710 | i_size_write(inode, size); | ||
| 711 | } | ||
| 712 | inode->i_mtime = inode->i_atime = CURRENT_TIME; | ||
| 713 | gfs2_trans_add_bh(ip->i_gl, dibh, 1); | ||
| 714 | gfs2_dinode_out(ip, dibh->b_data); | ||
| 715 | brelse(dibh); | ||
| 716 | mark_inode_dirty(inode); | ||
| 717 | |||
| 715 | unlock: | 718 | unlock: |
| 716 | unlock_page(page); | 719 | unlock_page(page); |
| 717 | page_cache_release(page); | 720 | page_cache_release(page); |
| @@ -739,9 +742,9 @@ static int do_sync(unsigned int num_qd, struct gfs2_quota_data **qda) | |||
| 739 | return -ENOMEM; | 742 | return -ENOMEM; |
| 740 | 743 | ||
| 741 | sort(qda, num_qd, sizeof(struct gfs2_quota_data *), sort_qd, NULL); | 744 | sort(qda, num_qd, sizeof(struct gfs2_quota_data *), sort_qd, NULL); |
| 745 | mutex_lock_nested(&ip->i_inode.i_mutex, I_MUTEX_QUOTA); | ||
| 742 | for (qx = 0; qx < num_qd; qx++) { | 746 | for (qx = 0; qx < num_qd; qx++) { |
| 743 | error = gfs2_glock_nq_init(qda[qx]->qd_gl, | 747 | error = gfs2_glock_nq_init(qda[qx]->qd_gl, LM_ST_EXCLUSIVE, |
| 744 | LM_ST_EXCLUSIVE, | ||
| 745 | GL_NOCACHE, &ghs[qx]); | 748 | GL_NOCACHE, &ghs[qx]); |
| 746 | if (error) | 749 | if (error) |
| 747 | goto out; | 750 | goto out; |
| @@ -795,9 +798,7 @@ static int do_sync(unsigned int num_qd, struct gfs2_quota_data **qda) | |||
| 795 | for (x = 0; x < num_qd; x++) { | 798 | for (x = 0; x < num_qd; x++) { |
| 796 | qd = qda[x]; | 799 | qd = qda[x]; |
| 797 | offset = qd2offset(qd); | 800 | offset = qd2offset(qd); |
| 798 | error = gfs2_adjust_quota(ip, offset, qd->qd_change_sync, | 801 | error = gfs2_adjust_quota(ip, offset, qd->qd_change_sync, qd, NULL); |
| 799 | (struct gfs2_quota_data *) | ||
| 800 | qd); | ||
| 801 | if (error) | 802 | if (error) |
| 802 | goto out_end_trans; | 803 | goto out_end_trans; |
| 803 | 804 | ||
| @@ -817,21 +818,44 @@ out_gunlock: | |||
| 817 | out: | 818 | out: |
| 818 | while (qx--) | 819 | while (qx--) |
| 819 | gfs2_glock_dq_uninit(&ghs[qx]); | 820 | gfs2_glock_dq_uninit(&ghs[qx]); |
| 821 | mutex_unlock(&ip->i_inode.i_mutex); | ||
| 820 | kfree(ghs); | 822 | kfree(ghs); |
| 821 | gfs2_log_flush(ip->i_gl->gl_sbd, ip->i_gl); | 823 | gfs2_log_flush(ip->i_gl->gl_sbd, ip->i_gl); |
| 822 | return error; | 824 | return error; |
| 823 | } | 825 | } |
| 824 | 826 | ||
| 827 | static int update_qd(struct gfs2_sbd *sdp, struct gfs2_quota_data *qd) | ||
| 828 | { | ||
| 829 | struct gfs2_inode *ip = GFS2_I(sdp->sd_quota_inode); | ||
| 830 | struct gfs2_quota q; | ||
| 831 | struct gfs2_quota_lvb *qlvb; | ||
| 832 | loff_t pos; | ||
| 833 | int error; | ||
| 834 | |||
| 835 | memset(&q, 0, sizeof(struct gfs2_quota)); | ||
| 836 | pos = qd2offset(qd); | ||
| 837 | error = gfs2_internal_read(ip, NULL, (char *)&q, &pos, sizeof(q)); | ||
| 838 | if (error < 0) | ||
| 839 | return error; | ||
| 840 | |||
| 841 | qlvb = (struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; | ||
| 842 | qlvb->qb_magic = cpu_to_be32(GFS2_MAGIC); | ||
| 843 | qlvb->__pad = 0; | ||
| 844 | qlvb->qb_limit = q.qu_limit; | ||
| 845 | qlvb->qb_warn = q.qu_warn; | ||
| 846 | qlvb->qb_value = q.qu_value; | ||
| 847 | qd->qd_qb = *qlvb; | ||
| 848 | |||
| 849 | return 0; | ||
| 850 | } | ||
| 851 | |||
| 825 | static int do_glock(struct gfs2_quota_data *qd, int force_refresh, | 852 | static int do_glock(struct gfs2_quota_data *qd, int force_refresh, |
| 826 | struct gfs2_holder *q_gh) | 853 | struct gfs2_holder *q_gh) |
| 827 | { | 854 | { |
| 828 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 855 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; |
| 829 | struct gfs2_inode *ip = GFS2_I(sdp->sd_quota_inode); | 856 | struct gfs2_inode *ip = GFS2_I(sdp->sd_quota_inode); |
| 830 | struct gfs2_holder i_gh; | 857 | struct gfs2_holder i_gh; |
| 831 | struct gfs2_quota_host q; | ||
| 832 | char buf[sizeof(struct gfs2_quota)]; | ||
| 833 | int error; | 858 | int error; |
| 834 | struct gfs2_quota_lvb *qlvb; | ||
| 835 | 859 | ||
| 836 | restart: | 860 | restart: |
| 837 | error = gfs2_glock_nq_init(qd->qd_gl, LM_ST_SHARED, 0, q_gh); | 861 | error = gfs2_glock_nq_init(qd->qd_gl, LM_ST_SHARED, 0, q_gh); |
| @@ -841,11 +865,9 @@ restart: | |||
| 841 | qd->qd_qb = *(struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; | 865 | qd->qd_qb = *(struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; |
| 842 | 866 | ||
| 843 | if (force_refresh || qd->qd_qb.qb_magic != cpu_to_be32(GFS2_MAGIC)) { | 867 | if (force_refresh || qd->qd_qb.qb_magic != cpu_to_be32(GFS2_MAGIC)) { |
| 844 | loff_t pos; | ||
| 845 | gfs2_glock_dq_uninit(q_gh); | 868 | gfs2_glock_dq_uninit(q_gh); |
| 846 | error = gfs2_glock_nq_init(qd->qd_gl, | 869 | error = gfs2_glock_nq_init(qd->qd_gl, LM_ST_EXCLUSIVE, |
| 847 | LM_ST_EXCLUSIVE, GL_NOCACHE, | 870 | GL_NOCACHE, q_gh); |
| 848 | q_gh); | ||
| 849 | if (error) | 871 | if (error) |
| 850 | return error; | 872 | return error; |
| 851 | 873 | ||
| @@ -853,29 +875,14 @@ restart: | |||
| 853 | if (error) | 875 | if (error) |
| 854 | goto fail; | 876 | goto fail; |
| 855 | 877 | ||
| 856 | memset(buf, 0, sizeof(struct gfs2_quota)); | 878 | error = update_qd(sdp, qd); |
| 857 | pos = qd2offset(qd); | 879 | if (error) |
| 858 | error = gfs2_internal_read(ip, NULL, buf, &pos, | ||
| 859 | sizeof(struct gfs2_quota)); | ||
| 860 | if (error < 0) | ||
| 861 | goto fail_gunlock; | 880 | goto fail_gunlock; |
| 862 | 881 | ||
| 863 | gfs2_glock_dq_uninit(&i_gh); | 882 | gfs2_glock_dq_uninit(&i_gh); |
| 864 | 883 | gfs2_glock_dq_uninit(q_gh); | |
| 865 | gfs2_quota_in(&q, buf); | 884 | force_refresh = 0; |
| 866 | qlvb = (struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; | 885 | goto restart; |
| 867 | qlvb->qb_magic = cpu_to_be32(GFS2_MAGIC); | ||
| 868 | qlvb->__pad = 0; | ||
| 869 | qlvb->qb_limit = cpu_to_be64(q.qu_limit); | ||
| 870 | qlvb->qb_warn = cpu_to_be64(q.qu_warn); | ||
| 871 | qlvb->qb_value = cpu_to_be64(q.qu_value); | ||
| 872 | qd->qd_qb = *qlvb; | ||
| 873 | |||
| 874 | if (gfs2_glock_is_blocking(qd->qd_gl)) { | ||
| 875 | gfs2_glock_dq_uninit(q_gh); | ||
| 876 | force_refresh = 0; | ||
| 877 | goto restart; | ||
| 878 | } | ||
| 879 | } | 886 | } |
| 880 | 887 | ||
| 881 | return 0; | 888 | return 0; |
| @@ -995,7 +1002,7 @@ static int print_message(struct gfs2_quota_data *qd, char *type) | |||
| 995 | { | 1002 | { |
| 996 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; | 1003 | struct gfs2_sbd *sdp = qd->qd_gl->gl_sbd; |
| 997 | 1004 | ||
| 998 | printk(KERN_INFO "GFS2: fsid=%s: quota %s for %s %u\r\n", | 1005 | printk(KERN_INFO "GFS2: fsid=%s: quota %s for %s %u\n", |
| 999 | sdp->sd_fsname, type, | 1006 | sdp->sd_fsname, type, |
| 1000 | (test_bit(QDF_USER, &qd->qd_flags)) ? "user" : "group", | 1007 | (test_bit(QDF_USER, &qd->qd_flags)) ? "user" : "group", |
| 1001 | qd->qd_id); | 1008 | qd->qd_id); |
| @@ -1032,6 +1039,10 @@ int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid) | |||
| 1032 | 1039 | ||
| 1033 | if (be64_to_cpu(qd->qd_qb.qb_limit) && (s64)be64_to_cpu(qd->qd_qb.qb_limit) < value) { | 1040 | if (be64_to_cpu(qd->qd_qb.qb_limit) && (s64)be64_to_cpu(qd->qd_qb.qb_limit) < value) { |
| 1034 | print_message(qd, "exceeded"); | 1041 | print_message(qd, "exceeded"); |
| 1042 | quota_send_warning(test_bit(QDF_USER, &qd->qd_flags) ? | ||
| 1043 | USRQUOTA : GRPQUOTA, qd->qd_id, | ||
| 1044 | sdp->sd_vfs->s_dev, QUOTA_NL_BHARDWARN); | ||
| 1045 | |||
| 1035 | error = -EDQUOT; | 1046 | error = -EDQUOT; |
| 1036 | break; | 1047 | break; |
| 1037 | } else if (be64_to_cpu(qd->qd_qb.qb_warn) && | 1048 | } else if (be64_to_cpu(qd->qd_qb.qb_warn) && |
| @@ -1039,6 +1050,9 @@ int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid) | |||
| 1039 | time_after_eq(jiffies, qd->qd_last_warn + | 1050 | time_after_eq(jiffies, qd->qd_last_warn + |
| 1040 | gfs2_tune_get(sdp, | 1051 | gfs2_tune_get(sdp, |
| 1041 | gt_quota_warn_period) * HZ)) { | 1052 | gt_quota_warn_period) * HZ)) { |
| 1053 | quota_send_warning(test_bit(QDF_USER, &qd->qd_flags) ? | ||
| 1054 | USRQUOTA : GRPQUOTA, qd->qd_id, | ||
| 1055 | sdp->sd_vfs->s_dev, QUOTA_NL_BSOFTWARN); | ||
| 1042 | error = print_message(qd, "warning"); | 1056 | error = print_message(qd, "warning"); |
| 1043 | qd->qd_last_warn = jiffies; | 1057 | qd->qd_last_warn = jiffies; |
| 1044 | } | 1058 | } |
| @@ -1069,8 +1083,9 @@ void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | |||
| 1069 | } | 1083 | } |
| 1070 | } | 1084 | } |
| 1071 | 1085 | ||
| 1072 | int gfs2_quota_sync(struct gfs2_sbd *sdp) | 1086 | int gfs2_quota_sync(struct super_block *sb, int type) |
| 1073 | { | 1087 | { |
| 1088 | struct gfs2_sbd *sdp = sb->s_fs_info; | ||
| 1074 | struct gfs2_quota_data **qda; | 1089 | struct gfs2_quota_data **qda; |
| 1075 | unsigned int max_qd = gfs2_tune_get(sdp, gt_quota_simul_sync); | 1090 | unsigned int max_qd = gfs2_tune_get(sdp, gt_quota_simul_sync); |
| 1076 | unsigned int num_qd; | 1091 | unsigned int num_qd; |
| @@ -1118,7 +1133,7 @@ int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) | |||
| 1118 | struct gfs2_holder q_gh; | 1133 | struct gfs2_holder q_gh; |
| 1119 | int error; | 1134 | int error; |
| 1120 | 1135 | ||
| 1121 | error = qd_get(sdp, user, id, CREATE, &qd); | 1136 | error = qd_get(sdp, user, id, &qd); |
| 1122 | if (error) | 1137 | if (error) |
| 1123 | return error; | 1138 | return error; |
| 1124 | 1139 | ||
| @@ -1127,7 +1142,6 @@ int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) | |||
| 1127 | gfs2_glock_dq_uninit(&q_gh); | 1142 | gfs2_glock_dq_uninit(&q_gh); |
| 1128 | 1143 | ||
| 1129 | qd_put(qd); | 1144 | qd_put(qd); |
| 1130 | |||
| 1131 | return error; | 1145 | return error; |
| 1132 | } | 1146 | } |
| 1133 | 1147 | ||
| @@ -1298,12 +1312,12 @@ static void quotad_error(struct gfs2_sbd *sdp, const char *msg, int error) | |||
| 1298 | } | 1312 | } |
| 1299 | 1313 | ||
| 1300 | static void quotad_check_timeo(struct gfs2_sbd *sdp, const char *msg, | 1314 | static void quotad_check_timeo(struct gfs2_sbd *sdp, const char *msg, |
| 1301 | int (*fxn)(struct gfs2_sbd *sdp), | 1315 | int (*fxn)(struct super_block *sb, int type), |
| 1302 | unsigned long t, unsigned long *timeo, | 1316 | unsigned long t, unsigned long *timeo, |
| 1303 | unsigned int *new_timeo) | 1317 | unsigned int *new_timeo) |
| 1304 | { | 1318 | { |
| 1305 | if (t >= *timeo) { | 1319 | if (t >= *timeo) { |
| 1306 | int error = fxn(sdp); | 1320 | int error = fxn(sdp->sd_vfs, 0); |
| 1307 | quotad_error(sdp, msg, error); | 1321 | quotad_error(sdp, msg, error); |
| 1308 | *timeo = gfs2_tune_get_i(&sdp->sd_tune, new_timeo) * HZ; | 1322 | *timeo = gfs2_tune_get_i(&sdp->sd_tune, new_timeo) * HZ; |
| 1309 | } else { | 1323 | } else { |
| @@ -1330,6 +1344,14 @@ static void quotad_check_trunc_list(struct gfs2_sbd *sdp) | |||
| 1330 | } | 1344 | } |
| 1331 | } | 1345 | } |
| 1332 | 1346 | ||
| 1347 | void gfs2_wake_up_statfs(struct gfs2_sbd *sdp) { | ||
| 1348 | if (!sdp->sd_statfs_force_sync) { | ||
| 1349 | sdp->sd_statfs_force_sync = 1; | ||
| 1350 | wake_up(&sdp->sd_quota_wait); | ||
| 1351 | } | ||
| 1352 | } | ||
| 1353 | |||
| 1354 | |||
| 1333 | /** | 1355 | /** |
| 1334 | * gfs2_quotad - Write cached quota changes into the quota file | 1356 | * gfs2_quotad - Write cached quota changes into the quota file |
| 1335 | * @sdp: Pointer to GFS2 superblock | 1357 | * @sdp: Pointer to GFS2 superblock |
| @@ -1349,8 +1371,15 @@ int gfs2_quotad(void *data) | |||
| 1349 | while (!kthread_should_stop()) { | 1371 | while (!kthread_should_stop()) { |
| 1350 | 1372 | ||
| 1351 | /* Update the master statfs file */ | 1373 | /* Update the master statfs file */ |
| 1352 | quotad_check_timeo(sdp, "statfs", gfs2_statfs_sync, t, | 1374 | if (sdp->sd_statfs_force_sync) { |
| 1353 | &statfs_timeo, &tune->gt_statfs_quantum); | 1375 | int error = gfs2_statfs_sync(sdp->sd_vfs, 0); |
| 1376 | quotad_error(sdp, "statfs", error); | ||
| 1377 | statfs_timeo = gfs2_tune_get(sdp, gt_statfs_quantum) * HZ; | ||
| 1378 | } | ||
| 1379 | else | ||
| 1380 | quotad_check_timeo(sdp, "statfs", gfs2_statfs_sync, t, | ||
| 1381 | &statfs_timeo, | ||
| 1382 | &tune->gt_statfs_quantum); | ||
| 1354 | 1383 | ||
| 1355 | /* Update quota file */ | 1384 | /* Update quota file */ |
| 1356 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync, t, | 1385 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync, t, |
| @@ -1367,7 +1396,7 @@ int gfs2_quotad(void *data) | |||
| 1367 | spin_lock(&sdp->sd_trunc_lock); | 1396 | spin_lock(&sdp->sd_trunc_lock); |
| 1368 | empty = list_empty(&sdp->sd_trunc_list); | 1397 | empty = list_empty(&sdp->sd_trunc_list); |
| 1369 | spin_unlock(&sdp->sd_trunc_lock); | 1398 | spin_unlock(&sdp->sd_trunc_lock); |
| 1370 | if (empty) | 1399 | if (empty && !sdp->sd_statfs_force_sync) |
| 1371 | t -= schedule_timeout(t); | 1400 | t -= schedule_timeout(t); |
| 1372 | else | 1401 | else |
| 1373 | t = 0; | 1402 | t = 0; |
| @@ -1377,3 +1406,181 @@ int gfs2_quotad(void *data) | |||
| 1377 | return 0; | 1406 | return 0; |
| 1378 | } | 1407 | } |
| 1379 | 1408 | ||
| 1409 | static int gfs2_quota_get_xstate(struct super_block *sb, | ||
| 1410 | struct fs_quota_stat *fqs) | ||
| 1411 | { | ||
| 1412 | struct gfs2_sbd *sdp = sb->s_fs_info; | ||
| 1413 | |||
| 1414 | memset(fqs, 0, sizeof(struct fs_quota_stat)); | ||
| 1415 | fqs->qs_version = FS_QSTAT_VERSION; | ||
| 1416 | if (sdp->sd_args.ar_quota == GFS2_QUOTA_ON) | ||
| 1417 | fqs->qs_flags = (XFS_QUOTA_UDQ_ENFD | XFS_QUOTA_GDQ_ENFD); | ||
| 1418 | else if (sdp->sd_args.ar_quota == GFS2_QUOTA_ACCOUNT) | ||
| 1419 | fqs->qs_flags = (XFS_QUOTA_UDQ_ACCT | XFS_QUOTA_GDQ_ACCT); | ||
| 1420 | if (sdp->sd_quota_inode) { | ||
| 1421 | fqs->qs_uquota.qfs_ino = GFS2_I(sdp->sd_quota_inode)->i_no_addr; | ||
| 1422 | fqs->qs_uquota.qfs_nblks = sdp->sd_quota_inode->i_blocks; | ||
| 1423 | } | ||
| 1424 | fqs->qs_uquota.qfs_nextents = 1; /* unsupported */ | ||
| 1425 | fqs->qs_gquota = fqs->qs_uquota; /* its the same inode in both cases */ | ||
| 1426 | fqs->qs_incoredqs = atomic_read(&qd_lru_count); | ||
| 1427 | return 0; | ||
| 1428 | } | ||
| 1429 | |||
| 1430 | static int gfs2_xquota_get(struct super_block *sb, int type, qid_t id, | ||
| 1431 | struct fs_disk_quota *fdq) | ||
| 1432 | { | ||
| 1433 | struct gfs2_sbd *sdp = sb->s_fs_info; | ||
| 1434 | struct gfs2_quota_lvb *qlvb; | ||
| 1435 | struct gfs2_quota_data *qd; | ||
| 1436 | struct gfs2_holder q_gh; | ||
| 1437 | int error; | ||
| 1438 | |||
| 1439 | memset(fdq, 0, sizeof(struct fs_disk_quota)); | ||
| 1440 | |||
| 1441 | if (sdp->sd_args.ar_quota == GFS2_QUOTA_OFF) | ||
| 1442 | return -ESRCH; /* Crazy XFS error code */ | ||
| 1443 | |||
| 1444 | if (type == USRQUOTA) | ||
| 1445 | type = QUOTA_USER; | ||
| 1446 | else if (type == GRPQUOTA) | ||
| 1447 | type = QUOTA_GROUP; | ||
| 1448 | else | ||
| 1449 | return -EINVAL; | ||
| 1450 | |||
| 1451 | error = qd_get(sdp, type, id, &qd); | ||
| 1452 | if (error) | ||
| 1453 | return error; | ||
| 1454 | error = do_glock(qd, FORCE, &q_gh); | ||
| 1455 | if (error) | ||
| 1456 | goto out; | ||
| 1457 | |||
| 1458 | qlvb = (struct gfs2_quota_lvb *)qd->qd_gl->gl_lvb; | ||
| 1459 | fdq->d_version = FS_DQUOT_VERSION; | ||
| 1460 | fdq->d_flags = (type == QUOTA_USER) ? XFS_USER_QUOTA : XFS_GROUP_QUOTA; | ||
| 1461 | fdq->d_id = id; | ||
| 1462 | fdq->d_blk_hardlimit = be64_to_cpu(qlvb->qb_limit); | ||
| 1463 | fdq->d_blk_softlimit = be64_to_cpu(qlvb->qb_warn); | ||
| 1464 | fdq->d_bcount = be64_to_cpu(qlvb->qb_value); | ||
| 1465 | |||
| 1466 | gfs2_glock_dq_uninit(&q_gh); | ||
| 1467 | out: | ||
| 1468 | qd_put(qd); | ||
| 1469 | return error; | ||
| 1470 | } | ||
| 1471 | |||
| 1472 | /* GFS2 only supports a subset of the XFS fields */ | ||
| 1473 | #define GFS2_FIELDMASK (FS_DQ_BSOFT|FS_DQ_BHARD) | ||
| 1474 | |||
| 1475 | static int gfs2_xquota_set(struct super_block *sb, int type, qid_t id, | ||
| 1476 | struct fs_disk_quota *fdq) | ||
| 1477 | { | ||
| 1478 | struct gfs2_sbd *sdp = sb->s_fs_info; | ||
| 1479 | struct gfs2_inode *ip = GFS2_I(sdp->sd_quota_inode); | ||
| 1480 | struct gfs2_quota_data *qd; | ||
| 1481 | struct gfs2_holder q_gh, i_gh; | ||
| 1482 | unsigned int data_blocks, ind_blocks; | ||
| 1483 | unsigned int blocks = 0; | ||
| 1484 | int alloc_required; | ||
| 1485 | struct gfs2_alloc *al; | ||
| 1486 | loff_t offset; | ||
| 1487 | int error; | ||
| 1488 | |||
| 1489 | if (sdp->sd_args.ar_quota == GFS2_QUOTA_OFF) | ||
| 1490 | return -ESRCH; /* Crazy XFS error code */ | ||
| 1491 | |||
| 1492 | switch(type) { | ||
| 1493 | case USRQUOTA: | ||
| 1494 | type = QUOTA_USER; | ||
| 1495 | if (fdq->d_flags != XFS_USER_QUOTA) | ||
| 1496 | return -EINVAL; | ||
| 1497 | break; | ||
| 1498 | case GRPQUOTA: | ||
| 1499 | type = QUOTA_GROUP; | ||
| 1500 | if (fdq->d_flags != XFS_GROUP_QUOTA) | ||
| 1501 | return -EINVAL; | ||
| 1502 | break; | ||
| 1503 | default: | ||
| 1504 | return -EINVAL; | ||
| 1505 | } | ||
| 1506 | |||
| 1507 | if (fdq->d_fieldmask & ~GFS2_FIELDMASK) | ||
| 1508 | return -EINVAL; | ||
| 1509 | if (fdq->d_id != id) | ||
| 1510 | return -EINVAL; | ||
| 1511 | |||
| 1512 | error = qd_get(sdp, type, id, &qd); | ||
| 1513 | if (error) | ||
| 1514 | return error; | ||
| 1515 | |||
| 1516 | mutex_lock(&ip->i_inode.i_mutex); | ||
| 1517 | error = gfs2_glock_nq_init(qd->qd_gl, LM_ST_EXCLUSIVE, 0, &q_gh); | ||
| 1518 | if (error) | ||
| 1519 | goto out_put; | ||
| 1520 | error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &i_gh); | ||
| 1521 | if (error) | ||
| 1522 | goto out_q; | ||
| 1523 | |||
| 1524 | /* Check for existing entry, if none then alloc new blocks */ | ||
| 1525 | error = update_qd(sdp, qd); | ||
| 1526 | if (error) | ||
| 1527 | goto out_i; | ||
| 1528 | |||
| 1529 | /* If nothing has changed, this is a no-op */ | ||
| 1530 | if ((fdq->d_fieldmask & FS_DQ_BSOFT) && | ||
| 1531 | (fdq->d_blk_softlimit == be64_to_cpu(qd->qd_qb.qb_warn))) | ||
| 1532 | fdq->d_fieldmask ^= FS_DQ_BSOFT; | ||
| 1533 | if ((fdq->d_fieldmask & FS_DQ_BHARD) && | ||
| 1534 | (fdq->d_blk_hardlimit == be64_to_cpu(qd->qd_qb.qb_limit))) | ||
| 1535 | fdq->d_fieldmask ^= FS_DQ_BHARD; | ||
| 1536 | if (fdq->d_fieldmask == 0) | ||
| 1537 | goto out_i; | ||
| 1538 | |||
| 1539 | offset = qd2offset(qd); | ||
| 1540 | error = gfs2_write_alloc_required(ip, offset, sizeof(struct gfs2_quota), | ||
| 1541 | &alloc_required); | ||
| 1542 | if (error) | ||
| 1543 | goto out_i; | ||
| 1544 | if (alloc_required) { | ||
| 1545 | al = gfs2_alloc_get(ip); | ||
| 1546 | if (al == NULL) | ||
| 1547 | goto out_i; | ||
| 1548 | gfs2_write_calc_reserv(ip, sizeof(struct gfs2_quota), | ||
| 1549 | &data_blocks, &ind_blocks); | ||
| 1550 | blocks = al->al_requested = 1 + data_blocks + ind_blocks; | ||
| 1551 | error = gfs2_inplace_reserve(ip); | ||
| 1552 | if (error) | ||
| 1553 | goto out_alloc; | ||
| 1554 | } | ||
| 1555 | |||
| 1556 | error = gfs2_trans_begin(sdp, blocks + RES_DINODE + 1, 0); | ||
| 1557 | if (error) | ||
| 1558 | goto out_release; | ||
| 1559 | |||
| 1560 | /* Apply changes */ | ||
| 1561 | error = gfs2_adjust_quota(ip, offset, 0, qd, fdq); | ||
| 1562 | |||
| 1563 | gfs2_trans_end(sdp); | ||
| 1564 | out_release: | ||
| 1565 | if (alloc_required) { | ||
| 1566 | gfs2_inplace_release(ip); | ||
| 1567 | out_alloc: | ||
| 1568 | gfs2_alloc_put(ip); | ||
| 1569 | } | ||
| 1570 | out_i: | ||
| 1571 | gfs2_glock_dq_uninit(&i_gh); | ||
| 1572 | out_q: | ||
| 1573 | gfs2_glock_dq_uninit(&q_gh); | ||
| 1574 | out_put: | ||
| 1575 | mutex_unlock(&ip->i_inode.i_mutex); | ||
| 1576 | qd_put(qd); | ||
| 1577 | return error; | ||
| 1578 | } | ||
| 1579 | |||
| 1580 | const struct quotactl_ops gfs2_quotactl_ops = { | ||
| 1581 | .quota_sync = gfs2_quota_sync, | ||
| 1582 | .get_xstate = gfs2_quota_get_xstate, | ||
| 1583 | .get_xquota = gfs2_xquota_get, | ||
| 1584 | .set_xquota = gfs2_xquota_set, | ||
| 1585 | }; | ||
| 1586 | |||
diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h index 0fa5fa63d0e8..e271fa07ad02 100644 --- a/fs/gfs2/quota.h +++ b/fs/gfs2/quota.h | |||
| @@ -25,13 +25,15 @@ extern int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid); | |||
| 25 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | 25 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, |
| 26 | u32 uid, u32 gid); | 26 | u32 uid, u32 gid); |
| 27 | 27 | ||
| 28 | extern int gfs2_quota_sync(struct gfs2_sbd *sdp); | 28 | extern int gfs2_quota_sync(struct super_block *sb, int type); |
| 29 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); | 29 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); |
| 30 | 30 | ||
| 31 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); | 31 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); |
| 32 | extern void gfs2_quota_cleanup(struct gfs2_sbd *sdp); | 32 | extern void gfs2_quota_cleanup(struct gfs2_sbd *sdp); |
| 33 | extern int gfs2_quotad(void *data); | 33 | extern int gfs2_quotad(void *data); |
| 34 | 34 | ||
| 35 | extern void gfs2_wake_up_statfs(struct gfs2_sbd *sdp); | ||
| 36 | |||
| 35 | static inline int gfs2_quota_lock_check(struct gfs2_inode *ip) | 37 | static inline int gfs2_quota_lock_check(struct gfs2_inode *ip) |
| 36 | { | 38 | { |
| 37 | struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); | 39 | struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); |
| @@ -50,5 +52,6 @@ static inline int gfs2_quota_lock_check(struct gfs2_inode *ip) | |||
| 50 | } | 52 | } |
| 51 | 53 | ||
| 52 | extern int gfs2_shrink_qd_memory(int nr, gfp_t gfp_mask); | 54 | extern int gfs2_shrink_qd_memory(int nr, gfp_t gfp_mask); |
| 55 | extern const struct quotactl_ops gfs2_quotactl_ops; | ||
| 53 | 56 | ||
| 54 | #endif /* __QUOTA_DOT_H__ */ | 57 | #endif /* __QUOTA_DOT_H__ */ |
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c index 09fa31965576..4b9bece3d437 100644 --- a/fs/gfs2/recovery.c +++ b/fs/gfs2/recovery.c | |||
| @@ -410,7 +410,9 @@ static int clean_journal(struct gfs2_jdesc *jd, struct gfs2_log_header_host *hea | |||
| 410 | memset(lh, 0, sizeof(struct gfs2_log_header)); | 410 | memset(lh, 0, sizeof(struct gfs2_log_header)); |
| 411 | lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC); | 411 | lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC); |
| 412 | lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH); | 412 | lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH); |
| 413 | lh->lh_header.__pad0 = cpu_to_be64(0); | ||
| 413 | lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH); | 414 | lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH); |
| 415 | lh->lh_header.mh_jid = cpu_to_be32(sdp->sd_jdesc->jd_jid); | ||
| 414 | lh->lh_sequence = cpu_to_be64(head->lh_sequence + 1); | 416 | lh->lh_sequence = cpu_to_be64(head->lh_sequence + 1); |
| 415 | lh->lh_flags = cpu_to_be32(GFS2_LOG_HEAD_UNMOUNT); | 417 | lh->lh_flags = cpu_to_be32(GFS2_LOG_HEAD_UNMOUNT); |
| 416 | lh->lh_blkno = cpu_to_be32(lblock); | 418 | lh->lh_blkno = cpu_to_be32(lblock); |
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 8f1cfb02a6cb..0608f490c295 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c | |||
| @@ -1710,11 +1710,16 @@ int gfs2_check_blk_type(struct gfs2_sbd *sdp, u64 no_addr, unsigned int type) | |||
| 1710 | { | 1710 | { |
| 1711 | struct gfs2_rgrpd *rgd; | 1711 | struct gfs2_rgrpd *rgd; |
| 1712 | struct gfs2_holder ri_gh, rgd_gh; | 1712 | struct gfs2_holder ri_gh, rgd_gh; |
| 1713 | struct gfs2_inode *ip = GFS2_I(sdp->sd_rindex); | ||
| 1714 | int ri_locked = 0; | ||
| 1713 | int error; | 1715 | int error; |
| 1714 | 1716 | ||
| 1715 | error = gfs2_rindex_hold(sdp, &ri_gh); | 1717 | if (!gfs2_glock_is_locked_by_me(ip->i_gl)) { |
| 1716 | if (error) | 1718 | error = gfs2_rindex_hold(sdp, &ri_gh); |
| 1717 | goto fail; | 1719 | if (error) |
| 1720 | goto fail; | ||
| 1721 | ri_locked = 1; | ||
| 1722 | } | ||
| 1718 | 1723 | ||
| 1719 | error = -EINVAL; | 1724 | error = -EINVAL; |
| 1720 | rgd = gfs2_blk2rgrpd(sdp, no_addr); | 1725 | rgd = gfs2_blk2rgrpd(sdp, no_addr); |
| @@ -1730,7 +1735,8 @@ int gfs2_check_blk_type(struct gfs2_sbd *sdp, u64 no_addr, unsigned int type) | |||
| 1730 | 1735 | ||
| 1731 | gfs2_glock_dq_uninit(&rgd_gh); | 1736 | gfs2_glock_dq_uninit(&rgd_gh); |
| 1732 | fail_rindex: | 1737 | fail_rindex: |
| 1733 | gfs2_glock_dq_uninit(&ri_gh); | 1738 | if (ri_locked) |
| 1739 | gfs2_glock_dq_uninit(&ri_gh); | ||
| 1734 | fail: | 1740 | fail: |
| 1735 | return error; | 1741 | return error; |
| 1736 | } | 1742 | } |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 0ec3ec672de1..c282ad41f3d1 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
| @@ -70,6 +70,11 @@ enum { | |||
| 70 | Opt_commit, | 70 | Opt_commit, |
| 71 | Opt_err_withdraw, | 71 | Opt_err_withdraw, |
| 72 | Opt_err_panic, | 72 | Opt_err_panic, |
| 73 | Opt_statfs_quantum, | ||
| 74 | Opt_statfs_percent, | ||
| 75 | Opt_quota_quantum, | ||
| 76 | Opt_barrier, | ||
| 77 | Opt_nobarrier, | ||
| 73 | Opt_error, | 78 | Opt_error, |
| 74 | }; | 79 | }; |
| 75 | 80 | ||
| @@ -101,18 +106,23 @@ static const match_table_t tokens = { | |||
| 101 | {Opt_commit, "commit=%d"}, | 106 | {Opt_commit, "commit=%d"}, |
| 102 | {Opt_err_withdraw, "errors=withdraw"}, | 107 | {Opt_err_withdraw, "errors=withdraw"}, |
| 103 | {Opt_err_panic, "errors=panic"}, | 108 | {Opt_err_panic, "errors=panic"}, |
| 109 | {Opt_statfs_quantum, "statfs_quantum=%d"}, | ||
| 110 | {Opt_statfs_percent, "statfs_percent=%d"}, | ||
| 111 | {Opt_quota_quantum, "quota_quantum=%d"}, | ||
| 112 | {Opt_barrier, "barrier"}, | ||
| 113 | {Opt_nobarrier, "nobarrier"}, | ||
| 104 | {Opt_error, NULL} | 114 | {Opt_error, NULL} |
| 105 | }; | 115 | }; |
| 106 | 116 | ||
| 107 | /** | 117 | /** |
| 108 | * gfs2_mount_args - Parse mount options | 118 | * gfs2_mount_args - Parse mount options |
| 109 | * @sdp: | 119 | * @args: The structure into which the parsed options will be written |
| 110 | * @data: | 120 | * @options: The options to parse |
| 111 | * | 121 | * |
| 112 | * Return: errno | 122 | * Return: errno |
| 113 | */ | 123 | */ |
| 114 | 124 | ||
| 115 | int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *options) | 125 | int gfs2_mount_args(struct gfs2_args *args, char *options) |
| 116 | { | 126 | { |
| 117 | char *o; | 127 | char *o; |
| 118 | int token; | 128 | int token; |
| @@ -157,7 +167,7 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *options) | |||
| 157 | break; | 167 | break; |
| 158 | case Opt_debug: | 168 | case Opt_debug: |
| 159 | if (args->ar_errors == GFS2_ERRORS_PANIC) { | 169 | if (args->ar_errors == GFS2_ERRORS_PANIC) { |
| 160 | fs_info(sdp, "-o debug and -o errors=panic " | 170 | printk(KERN_WARNING "GFS2: -o debug and -o errors=panic " |
| 161 | "are mutually exclusive.\n"); | 171 | "are mutually exclusive.\n"); |
| 162 | return -EINVAL; | 172 | return -EINVAL; |
| 163 | } | 173 | } |
| @@ -210,7 +220,29 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *options) | |||
| 210 | case Opt_commit: | 220 | case Opt_commit: |
| 211 | rv = match_int(&tmp[0], &args->ar_commit); | 221 | rv = match_int(&tmp[0], &args->ar_commit); |
| 212 | if (rv || args->ar_commit <= 0) { | 222 | if (rv || args->ar_commit <= 0) { |
| 213 | fs_info(sdp, "commit mount option requires a positive numeric argument\n"); | 223 | printk(KERN_WARNING "GFS2: commit mount option requires a positive numeric argument\n"); |
| 224 | return rv ? rv : -EINVAL; | ||
| 225 | } | ||
| 226 | break; | ||
| 227 | case Opt_statfs_quantum: | ||
| 228 | rv = match_int(&tmp[0], &args->ar_statfs_quantum); | ||
| 229 | if (rv || args->ar_statfs_quantum < 0) { | ||
| 230 | printk(KERN_WARNING "GFS2: statfs_quantum mount option requires a non-negative numeric argument\n"); | ||
| 231 | return rv ? rv : -EINVAL; | ||
| 232 | } | ||
| 233 | break; | ||
| 234 | case Opt_quota_quantum: | ||
| 235 | rv = match_int(&tmp[0], &args->ar_quota_quantum); | ||
| 236 | if (rv || args->ar_quota_quantum <= 0) { | ||
| 237 | printk(KERN_WARNING "GFS2: quota_quantum mount option requires a positive numeric argument\n"); | ||
| 238 | return rv ? rv : -EINVAL; | ||
| 239 | } | ||
| 240 | break; | ||
| 241 | case Opt_statfs_percent: | ||
| 242 | rv = match_int(&tmp[0], &args->ar_statfs_percent); | ||
| 243 | if (rv || args->ar_statfs_percent < 0 || | ||
| 244 | args->ar_statfs_percent > 100) { | ||
| 245 | printk(KERN_WARNING "statfs_percent mount option requires a numeric argument between 0 and 100\n"); | ||
| 214 | return rv ? rv : -EINVAL; | 246 | return rv ? rv : -EINVAL; |
| 215 | } | 247 | } |
| 216 | break; | 248 | break; |
| @@ -219,15 +251,21 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *options) | |||
| 219 | break; | 251 | break; |
| 220 | case Opt_err_panic: | 252 | case Opt_err_panic: |
| 221 | if (args->ar_debug) { | 253 | if (args->ar_debug) { |
| 222 | fs_info(sdp, "-o debug and -o errors=panic " | 254 | printk(KERN_WARNING "GFS2: -o debug and -o errors=panic " |
| 223 | "are mutually exclusive.\n"); | 255 | "are mutually exclusive.\n"); |
| 224 | return -EINVAL; | 256 | return -EINVAL; |
| 225 | } | 257 | } |
| 226 | args->ar_errors = GFS2_ERRORS_PANIC; | 258 | args->ar_errors = GFS2_ERRORS_PANIC; |
| 227 | break; | 259 | break; |
| 260 | case Opt_barrier: | ||
| 261 | args->ar_nobarrier = 0; | ||
| 262 | break; | ||
| 263 | case Opt_nobarrier: | ||
| 264 | args->ar_nobarrier = 1; | ||
| 265 | break; | ||
| 228 | case Opt_error: | 266 | case Opt_error: |
| 229 | default: | 267 | default: |
| 230 | fs_info(sdp, "invalid mount option: %s\n", o); | 268 | printk(KERN_WARNING "GFS2: invalid mount option: %s\n", o); |
| 231 | return -EINVAL; | 269 | return -EINVAL; |
| 232 | } | 270 | } |
| 233 | } | 271 | } |
| @@ -442,7 +480,10 @@ void gfs2_statfs_change(struct gfs2_sbd *sdp, s64 total, s64 free, | |||
| 442 | { | 480 | { |
| 443 | struct gfs2_inode *l_ip = GFS2_I(sdp->sd_sc_inode); | 481 | struct gfs2_inode *l_ip = GFS2_I(sdp->sd_sc_inode); |
| 444 | struct gfs2_statfs_change_host *l_sc = &sdp->sd_statfs_local; | 482 | struct gfs2_statfs_change_host *l_sc = &sdp->sd_statfs_local; |
| 483 | struct gfs2_statfs_change_host *m_sc = &sdp->sd_statfs_master; | ||
| 445 | struct buffer_head *l_bh; | 484 | struct buffer_head *l_bh; |
| 485 | s64 x, y; | ||
| 486 | int need_sync = 0; | ||
| 446 | int error; | 487 | int error; |
| 447 | 488 | ||
| 448 | error = gfs2_meta_inode_buffer(l_ip, &l_bh); | 489 | error = gfs2_meta_inode_buffer(l_ip, &l_bh); |
| @@ -456,9 +497,17 @@ void gfs2_statfs_change(struct gfs2_sbd *sdp, s64 total, s64 free, | |||
| 456 | l_sc->sc_free += free; | 497 | l_sc->sc_free += free; |
| 457 | l_sc->sc_dinodes += dinodes; | 498 | l_sc->sc_dinodes += dinodes; |
| 458 | gfs2_statfs_change_out(l_sc, l_bh->b_data + sizeof(struct gfs2_dinode)); | 499 | gfs2_statfs_change_out(l_sc, l_bh->b_data + sizeof(struct gfs2_dinode)); |
| 500 | if (sdp->sd_args.ar_statfs_percent) { | ||
| 501 | x = 100 * l_sc->sc_free; | ||
| 502 | y = m_sc->sc_free * sdp->sd_args.ar_statfs_percent; | ||
| 503 | if (x >= y || x <= -y) | ||
| 504 | need_sync = 1; | ||
| 505 | } | ||
| 459 | spin_unlock(&sdp->sd_statfs_spin); | 506 | spin_unlock(&sdp->sd_statfs_spin); |
| 460 | 507 | ||
| 461 | brelse(l_bh); | 508 | brelse(l_bh); |
| 509 | if (need_sync) | ||
| 510 | gfs2_wake_up_statfs(sdp); | ||
| 462 | } | 511 | } |
| 463 | 512 | ||
| 464 | void update_statfs(struct gfs2_sbd *sdp, struct buffer_head *m_bh, | 513 | void update_statfs(struct gfs2_sbd *sdp, struct buffer_head *m_bh, |
| @@ -484,8 +533,9 @@ void update_statfs(struct gfs2_sbd *sdp, struct buffer_head *m_bh, | |||
| 484 | gfs2_statfs_change_out(m_sc, m_bh->b_data + sizeof(struct gfs2_dinode)); | 533 | gfs2_statfs_change_out(m_sc, m_bh->b_data + sizeof(struct gfs2_dinode)); |
| 485 | } | 534 | } |
| 486 | 535 | ||
| 487 | int gfs2_statfs_sync(struct gfs2_sbd *sdp) | 536 | int gfs2_statfs_sync(struct super_block *sb, int type) |
| 488 | { | 537 | { |
| 538 | struct gfs2_sbd *sdp = sb->s_fs_info; | ||
| 489 | struct gfs2_inode *m_ip = GFS2_I(sdp->sd_statfs_inode); | 539 | struct gfs2_inode *m_ip = GFS2_I(sdp->sd_statfs_inode); |
| 490 | struct gfs2_inode *l_ip = GFS2_I(sdp->sd_sc_inode); | 540 | struct gfs2_inode *l_ip = GFS2_I(sdp->sd_sc_inode); |
| 491 | struct gfs2_statfs_change_host *m_sc = &sdp->sd_statfs_master; | 541 | struct gfs2_statfs_change_host *m_sc = &sdp->sd_statfs_master; |
| @@ -521,6 +571,7 @@ int gfs2_statfs_sync(struct gfs2_sbd *sdp) | |||
| 521 | goto out_bh2; | 571 | goto out_bh2; |
| 522 | 572 | ||
| 523 | update_statfs(sdp, m_bh, l_bh); | 573 | update_statfs(sdp, m_bh, l_bh); |
| 574 | sdp->sd_statfs_force_sync = 0; | ||
| 524 | 575 | ||
| 525 | gfs2_trans_end(sdp); | 576 | gfs2_trans_end(sdp); |
| 526 | 577 | ||
| @@ -712,8 +763,8 @@ static int gfs2_make_fs_ro(struct gfs2_sbd *sdp) | |||
| 712 | int error; | 763 | int error; |
| 713 | 764 | ||
| 714 | flush_workqueue(gfs2_delete_workqueue); | 765 | flush_workqueue(gfs2_delete_workqueue); |
| 715 | gfs2_quota_sync(sdp); | 766 | gfs2_quota_sync(sdp->sd_vfs, 0); |
| 716 | gfs2_statfs_sync(sdp); | 767 | gfs2_statfs_sync(sdp->sd_vfs, 0); |
| 717 | 768 | ||
| 718 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, | 769 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, |
| 719 | &t_gh); | 770 | &t_gh); |
| @@ -1061,8 +1112,13 @@ static int gfs2_remount_fs(struct super_block *sb, int *flags, char *data) | |||
| 1061 | 1112 | ||
| 1062 | spin_lock(>->gt_spin); | 1113 | spin_lock(>->gt_spin); |
| 1063 | args.ar_commit = gt->gt_log_flush_secs; | 1114 | args.ar_commit = gt->gt_log_flush_secs; |
| 1115 | args.ar_quota_quantum = gt->gt_quota_quantum; | ||
| 1116 | if (gt->gt_statfs_slow) | ||
| 1117 | args.ar_statfs_quantum = 0; | ||
| 1118 | else | ||
| 1119 | args.ar_statfs_quantum = gt->gt_statfs_quantum; | ||
| 1064 | spin_unlock(>->gt_spin); | 1120 | spin_unlock(>->gt_spin); |
| 1065 | error = gfs2_mount_args(sdp, &args, data); | 1121 | error = gfs2_mount_args(&args, data); |
| 1066 | if (error) | 1122 | if (error) |
| 1067 | return error; | 1123 | return error; |
| 1068 | 1124 | ||
| @@ -1097,8 +1153,21 @@ static int gfs2_remount_fs(struct super_block *sb, int *flags, char *data) | |||
| 1097 | sb->s_flags |= MS_POSIXACL; | 1153 | sb->s_flags |= MS_POSIXACL; |
| 1098 | else | 1154 | else |
| 1099 | sb->s_flags &= ~MS_POSIXACL; | 1155 | sb->s_flags &= ~MS_POSIXACL; |
| 1156 | if (sdp->sd_args.ar_nobarrier) | ||
| 1157 | set_bit(SDF_NOBARRIERS, &sdp->sd_flags); | ||
| 1158 | else | ||
| 1159 | clear_bit(SDF_NOBARRIERS, &sdp->sd_flags); | ||
| 1100 | spin_lock(>->gt_spin); | 1160 | spin_lock(>->gt_spin); |
| 1101 | gt->gt_log_flush_secs = args.ar_commit; | 1161 | gt->gt_log_flush_secs = args.ar_commit; |
| 1162 | gt->gt_quota_quantum = args.ar_quota_quantum; | ||
| 1163 | if (args.ar_statfs_quantum) { | ||
| 1164 | gt->gt_statfs_slow = 0; | ||
| 1165 | gt->gt_statfs_quantum = args.ar_statfs_quantum; | ||
| 1166 | } | ||
| 1167 | else { | ||
| 1168 | gt->gt_statfs_slow = 1; | ||
| 1169 | gt->gt_statfs_quantum = 30; | ||
| 1170 | } | ||
| 1102 | spin_unlock(>->gt_spin); | 1171 | spin_unlock(>->gt_spin); |
| 1103 | 1172 | ||
| 1104 | gfs2_online_uevent(sdp); | 1173 | gfs2_online_uevent(sdp); |
| @@ -1179,7 +1248,7 @@ static int gfs2_show_options(struct seq_file *s, struct vfsmount *mnt) | |||
| 1179 | { | 1248 | { |
| 1180 | struct gfs2_sbd *sdp = mnt->mnt_sb->s_fs_info; | 1249 | struct gfs2_sbd *sdp = mnt->mnt_sb->s_fs_info; |
| 1181 | struct gfs2_args *args = &sdp->sd_args; | 1250 | struct gfs2_args *args = &sdp->sd_args; |
| 1182 | int lfsecs; | 1251 | int val; |
| 1183 | 1252 | ||
| 1184 | if (is_ancestor(mnt->mnt_root, sdp->sd_master_dir)) | 1253 | if (is_ancestor(mnt->mnt_root, sdp->sd_master_dir)) |
| 1185 | seq_printf(s, ",meta"); | 1254 | seq_printf(s, ",meta"); |
| @@ -1240,9 +1309,17 @@ static int gfs2_show_options(struct seq_file *s, struct vfsmount *mnt) | |||
| 1240 | } | 1309 | } |
| 1241 | if (args->ar_discard) | 1310 | if (args->ar_discard) |
| 1242 | seq_printf(s, ",discard"); | 1311 | seq_printf(s, ",discard"); |
| 1243 | lfsecs = sdp->sd_tune.gt_log_flush_secs; | 1312 | val = sdp->sd_tune.gt_log_flush_secs; |
| 1244 | if (lfsecs != 60) | 1313 | if (val != 60) |
| 1245 | seq_printf(s, ",commit=%d", lfsecs); | 1314 | seq_printf(s, ",commit=%d", val); |
| 1315 | val = sdp->sd_tune.gt_statfs_quantum; | ||
| 1316 | if (val != 30) | ||
| 1317 | seq_printf(s, ",statfs_quantum=%d", val); | ||
| 1318 | val = sdp->sd_tune.gt_quota_quantum; | ||
| 1319 | if (val != 60) | ||
| 1320 | seq_printf(s, ",quota_quantum=%d", val); | ||
| 1321 | if (args->ar_statfs_percent) | ||
| 1322 | seq_printf(s, ",statfs_percent=%d", args->ar_statfs_percent); | ||
| 1246 | if (args->ar_errors != GFS2_ERRORS_DEFAULT) { | 1323 | if (args->ar_errors != GFS2_ERRORS_DEFAULT) { |
| 1247 | const char *state; | 1324 | const char *state; |
| 1248 | 1325 | ||
| @@ -1259,6 +1336,9 @@ static int gfs2_show_options(struct seq_file *s, struct vfsmount *mnt) | |||
| 1259 | } | 1336 | } |
| 1260 | seq_printf(s, ",errors=%s", state); | 1337 | seq_printf(s, ",errors=%s", state); |
| 1261 | } | 1338 | } |
| 1339 | if (test_bit(SDF_NOBARRIERS, &sdp->sd_flags)) | ||
| 1340 | seq_printf(s, ",nobarrier"); | ||
| 1341 | |||
| 1262 | return 0; | 1342 | return 0; |
| 1263 | } | 1343 | } |
| 1264 | 1344 | ||
diff --git a/fs/gfs2/super.h b/fs/gfs2/super.h index 235db3682885..3df60f2d84e3 100644 --- a/fs/gfs2/super.h +++ b/fs/gfs2/super.h | |||
| @@ -27,7 +27,7 @@ static inline unsigned int gfs2_jindex_size(struct gfs2_sbd *sdp) | |||
| 27 | 27 | ||
| 28 | extern void gfs2_jindex_free(struct gfs2_sbd *sdp); | 28 | extern void gfs2_jindex_free(struct gfs2_sbd *sdp); |
| 29 | 29 | ||
| 30 | extern int gfs2_mount_args(struct gfs2_sbd *sdp, struct gfs2_args *args, char *data); | 30 | extern int gfs2_mount_args(struct gfs2_args *args, char *data); |
| 31 | 31 | ||
| 32 | extern struct gfs2_jdesc *gfs2_jdesc_find(struct gfs2_sbd *sdp, unsigned int jid); | 32 | extern struct gfs2_jdesc *gfs2_jdesc_find(struct gfs2_sbd *sdp, unsigned int jid); |
| 33 | extern int gfs2_jdesc_check(struct gfs2_jdesc *jd); | 33 | extern int gfs2_jdesc_check(struct gfs2_jdesc *jd); |
| @@ -44,7 +44,7 @@ extern void gfs2_statfs_change_in(struct gfs2_statfs_change_host *sc, | |||
| 44 | const void *buf); | 44 | const void *buf); |
| 45 | extern void update_statfs(struct gfs2_sbd *sdp, struct buffer_head *m_bh, | 45 | extern void update_statfs(struct gfs2_sbd *sdp, struct buffer_head *m_bh, |
| 46 | struct buffer_head *l_bh); | 46 | struct buffer_head *l_bh); |
| 47 | extern int gfs2_statfs_sync(struct gfs2_sbd *sdp); | 47 | extern int gfs2_statfs_sync(struct super_block *sb, int type); |
| 48 | 48 | ||
| 49 | extern int gfs2_freeze_fs(struct gfs2_sbd *sdp); | 49 | extern int gfs2_freeze_fs(struct gfs2_sbd *sdp); |
| 50 | extern void gfs2_unfreeze_fs(struct gfs2_sbd *sdp); | 50 | extern void gfs2_unfreeze_fs(struct gfs2_sbd *sdp); |
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 446329728d52..0dc34621f6a6 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c | |||
| @@ -85,11 +85,7 @@ static ssize_t uuid_show(struct gfs2_sbd *sdp, char *buf) | |||
| 85 | buf[0] = '\0'; | 85 | buf[0] = '\0'; |
| 86 | if (!gfs2_uuid_valid(uuid)) | 86 | if (!gfs2_uuid_valid(uuid)) |
| 87 | return 0; | 87 | return 0; |
| 88 | return snprintf(buf, PAGE_SIZE, "%02X%02X%02X%02X-%02X%02X-" | 88 | return snprintf(buf, PAGE_SIZE, "%pUB\n", uuid); |
| 89 | "%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X\n", | ||
| 90 | uuid[0], uuid[1], uuid[2], uuid[3], uuid[4], uuid[5], | ||
| 91 | uuid[6], uuid[7], uuid[8], uuid[9], uuid[10], uuid[11], | ||
| 92 | uuid[12], uuid[13], uuid[14], uuid[15]); | ||
| 93 | } | 89 | } |
| 94 | 90 | ||
| 95 | static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf) | 91 | static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf) |
| @@ -158,7 +154,7 @@ static ssize_t statfs_sync_store(struct gfs2_sbd *sdp, const char *buf, | |||
| 158 | if (simple_strtol(buf, NULL, 0) != 1) | 154 | if (simple_strtol(buf, NULL, 0) != 1) |
| 159 | return -EINVAL; | 155 | return -EINVAL; |
| 160 | 156 | ||
| 161 | gfs2_statfs_sync(sdp); | 157 | gfs2_statfs_sync(sdp->sd_vfs, 0); |
| 162 | return len; | 158 | return len; |
| 163 | } | 159 | } |
| 164 | 160 | ||
| @@ -171,13 +167,14 @@ static ssize_t quota_sync_store(struct gfs2_sbd *sdp, const char *buf, | |||
| 171 | if (simple_strtol(buf, NULL, 0) != 1) | 167 | if (simple_strtol(buf, NULL, 0) != 1) |
| 172 | return -EINVAL; | 168 | return -EINVAL; |
| 173 | 169 | ||
| 174 | gfs2_quota_sync(sdp); | 170 | gfs2_quota_sync(sdp->sd_vfs, 0); |
| 175 | return len; | 171 | return len; |
| 176 | } | 172 | } |
| 177 | 173 | ||
| 178 | static ssize_t quota_refresh_user_store(struct gfs2_sbd *sdp, const char *buf, | 174 | static ssize_t quota_refresh_user_store(struct gfs2_sbd *sdp, const char *buf, |
| 179 | size_t len) | 175 | size_t len) |
| 180 | { | 176 | { |
| 177 | int error; | ||
| 181 | u32 id; | 178 | u32 id; |
| 182 | 179 | ||
| 183 | if (!capable(CAP_SYS_ADMIN)) | 180 | if (!capable(CAP_SYS_ADMIN)) |
| @@ -185,13 +182,14 @@ static ssize_t quota_refresh_user_store(struct gfs2_sbd *sdp, const char *buf, | |||
| 185 | 182 | ||
| 186 | id = simple_strtoul(buf, NULL, 0); | 183 | id = simple_strtoul(buf, NULL, 0); |
| 187 | 184 | ||
| 188 | gfs2_quota_refresh(sdp, 1, id); | 185 | error = gfs2_quota_refresh(sdp, 1, id); |
| 189 | return len; | 186 | return error ? error : len; |
| 190 | } | 187 | } |
| 191 | 188 | ||
| 192 | static ssize_t quota_refresh_group_store(struct gfs2_sbd *sdp, const char *buf, | 189 | static ssize_t quota_refresh_group_store(struct gfs2_sbd *sdp, const char *buf, |
| 193 | size_t len) | 190 | size_t len) |
| 194 | { | 191 | { |
| 192 | int error; | ||
| 195 | u32 id; | 193 | u32 id; |
| 196 | 194 | ||
| 197 | if (!capable(CAP_SYS_ADMIN)) | 195 | if (!capable(CAP_SYS_ADMIN)) |
| @@ -199,8 +197,8 @@ static ssize_t quota_refresh_group_store(struct gfs2_sbd *sdp, const char *buf, | |||
| 199 | 197 | ||
| 200 | id = simple_strtoul(buf, NULL, 0); | 198 | id = simple_strtoul(buf, NULL, 0); |
| 201 | 199 | ||
| 202 | gfs2_quota_refresh(sdp, 0, id); | 200 | error = gfs2_quota_refresh(sdp, 0, id); |
| 203 | return len; | 201 | return error ? error : len; |
| 204 | } | 202 | } |
| 205 | 203 | ||
| 206 | static ssize_t demote_rq_store(struct gfs2_sbd *sdp, const char *buf, size_t len) | 204 | static ssize_t demote_rq_store(struct gfs2_sbd *sdp, const char *buf, size_t len) |
| @@ -573,14 +571,8 @@ static int gfs2_uevent(struct kset *kset, struct kobject *kobj, | |||
| 573 | add_uevent_var(env, "LOCKPROTO=%s", sdp->sd_proto_name); | 571 | add_uevent_var(env, "LOCKPROTO=%s", sdp->sd_proto_name); |
| 574 | if (!sdp->sd_args.ar_spectator) | 572 | if (!sdp->sd_args.ar_spectator) |
| 575 | add_uevent_var(env, "JOURNALID=%u", sdp->sd_lockstruct.ls_jid); | 573 | add_uevent_var(env, "JOURNALID=%u", sdp->sd_lockstruct.ls_jid); |
| 576 | if (gfs2_uuid_valid(uuid)) { | 574 | if (gfs2_uuid_valid(uuid)) |
| 577 | add_uevent_var(env, "UUID=%02X%02X%02X%02X-%02X%02X-%02X%02X-" | 575 | add_uevent_var(env, "UUID=%pUB", uuid); |
| 578 | "%02X%02X-%02X%02X%02X%02X%02X%02X", | ||
| 579 | uuid[0], uuid[1], uuid[2], uuid[3], uuid[4], | ||
| 580 | uuid[5], uuid[6], uuid[7], uuid[8], uuid[9], | ||
| 581 | uuid[10], uuid[11], uuid[12], uuid[13], | ||
| 582 | uuid[14], uuid[15]); | ||
| 583 | } | ||
| 584 | return 0; | 576 | return 0; |
| 585 | } | 577 | } |
| 586 | 578 | ||
diff --git a/fs/gfs2/xattr.c b/fs/gfs2/xattr.c index 8a0f8ef6ee27..912f5cbc4740 100644 --- a/fs/gfs2/xattr.c +++ b/fs/gfs2/xattr.c | |||
| @@ -186,8 +186,8 @@ static int ea_find_i(struct gfs2_inode *ip, struct buffer_head *bh, | |||
| 186 | return 0; | 186 | return 0; |
| 187 | } | 187 | } |
| 188 | 188 | ||
| 189 | int gfs2_ea_find(struct gfs2_inode *ip, int type, const char *name, | 189 | static int gfs2_ea_find(struct gfs2_inode *ip, int type, const char *name, |
| 190 | struct gfs2_ea_location *el) | 190 | struct gfs2_ea_location *el) |
| 191 | { | 191 | { |
| 192 | struct ea_find ef; | 192 | struct ea_find ef; |
| 193 | int error; | 193 | int error; |
| @@ -516,8 +516,8 @@ out: | |||
| 516 | return error; | 516 | return error; |
| 517 | } | 517 | } |
| 518 | 518 | ||
| 519 | int gfs2_ea_get_copy(struct gfs2_inode *ip, struct gfs2_ea_location *el, | 519 | static int gfs2_ea_get_copy(struct gfs2_inode *ip, struct gfs2_ea_location *el, |
| 520 | char *data, size_t size) | 520 | char *data, size_t size) |
| 521 | { | 521 | { |
| 522 | int ret; | 522 | int ret; |
| 523 | size_t len = GFS2_EA_DATA_LEN(el->el_ea); | 523 | size_t len = GFS2_EA_DATA_LEN(el->el_ea); |
| @@ -534,6 +534,36 @@ int gfs2_ea_get_copy(struct gfs2_inode *ip, struct gfs2_ea_location *el, | |||
| 534 | return len; | 534 | return len; |
| 535 | } | 535 | } |
| 536 | 536 | ||
| 537 | int gfs2_xattr_acl_get(struct gfs2_inode *ip, const char *name, char **ppdata) | ||
| 538 | { | ||
| 539 | struct gfs2_ea_location el; | ||
| 540 | int error; | ||
| 541 | int len; | ||
| 542 | char *data; | ||
| 543 | |||
| 544 | error = gfs2_ea_find(ip, GFS2_EATYPE_SYS, name, &el); | ||
| 545 | if (error) | ||
| 546 | return error; | ||
| 547 | if (!el.el_ea) | ||
| 548 | goto out; | ||
| 549 | if (!GFS2_EA_DATA_LEN(el.el_ea)) | ||
| 550 | goto out; | ||
| 551 | |||
| 552 | len = GFS2_EA_DATA_LEN(el.el_ea); | ||
| 553 | data = kmalloc(len, GFP_NOFS); | ||
| 554 | error = -ENOMEM; | ||
| 555 | if (data == NULL) | ||
| 556 | goto out; | ||
| 557 | |||
| 558 | error = gfs2_ea_get_copy(ip, &el, data, len); | ||
| 559 | if (error == 0) | ||
| 560 | error = len; | ||
| 561 | *ppdata = data; | ||
| 562 | out: | ||
| 563 | brelse(el.el_bh); | ||
| 564 | return error; | ||
| 565 | } | ||
| 566 | |||
| 537 | /** | 567 | /** |
| 538 | * gfs2_xattr_get - Get a GFS2 extended attribute | 568 | * gfs2_xattr_get - Get a GFS2 extended attribute |
| 539 | * @inode: The inode | 569 | * @inode: The inode |
| @@ -1259,22 +1289,26 @@ fail: | |||
| 1259 | return error; | 1289 | return error; |
| 1260 | } | 1290 | } |
| 1261 | 1291 | ||
| 1262 | int gfs2_ea_acl_chmod(struct gfs2_inode *ip, struct gfs2_ea_location *el, | 1292 | int gfs2_xattr_acl_chmod(struct gfs2_inode *ip, struct iattr *attr, char *data) |
| 1263 | struct iattr *attr, char *data) | ||
| 1264 | { | 1293 | { |
| 1294 | struct gfs2_ea_location el; | ||
| 1265 | struct buffer_head *dibh; | 1295 | struct buffer_head *dibh; |
| 1266 | int error; | 1296 | int error; |
| 1267 | 1297 | ||
| 1268 | if (GFS2_EA_IS_STUFFED(el->el_ea)) { | 1298 | error = gfs2_ea_find(ip, GFS2_EATYPE_SYS, GFS2_POSIX_ACL_ACCESS, &el); |
| 1299 | if (error) | ||
| 1300 | return error; | ||
| 1301 | |||
| 1302 | if (GFS2_EA_IS_STUFFED(el.el_ea)) { | ||
| 1269 | error = gfs2_trans_begin(GFS2_SB(&ip->i_inode), RES_DINODE + RES_EATTR, 0); | 1303 | error = gfs2_trans_begin(GFS2_SB(&ip->i_inode), RES_DINODE + RES_EATTR, 0); |
| 1270 | if (error) | 1304 | if (error) |
| 1271 | return error; | 1305 | return error; |
| 1272 | 1306 | ||
| 1273 | gfs2_trans_add_bh(ip->i_gl, el->el_bh, 1); | 1307 | gfs2_trans_add_bh(ip->i_gl, el.el_bh, 1); |
| 1274 | memcpy(GFS2_EA2DATA(el->el_ea), data, | 1308 | memcpy(GFS2_EA2DATA(el.el_ea), data, |
| 1275 | GFS2_EA_DATA_LEN(el->el_ea)); | 1309 | GFS2_EA_DATA_LEN(el.el_ea)); |
| 1276 | } else | 1310 | } else |
| 1277 | error = ea_acl_chmod_unstuffed(ip, el->el_ea, data); | 1311 | error = ea_acl_chmod_unstuffed(ip, el.el_ea, data); |
| 1278 | 1312 | ||
| 1279 | if (error) | 1313 | if (error) |
| 1280 | return error; | 1314 | return error; |
| @@ -1507,18 +1541,6 @@ static int gfs2_xattr_user_set(struct inode *inode, const char *name, | |||
| 1507 | return gfs2_xattr_set(inode, GFS2_EATYPE_USR, name, value, size, flags); | 1541 | return gfs2_xattr_set(inode, GFS2_EATYPE_USR, name, value, size, flags); |
| 1508 | } | 1542 | } |
| 1509 | 1543 | ||
| 1510 | static int gfs2_xattr_system_get(struct inode *inode, const char *name, | ||
| 1511 | void *buffer, size_t size) | ||
| 1512 | { | ||
| 1513 | return gfs2_xattr_get(inode, GFS2_EATYPE_SYS, name, buffer, size); | ||
| 1514 | } | ||
| 1515 | |||
| 1516 | static int gfs2_xattr_system_set(struct inode *inode, const char *name, | ||
| 1517 | const void *value, size_t size, int flags) | ||
| 1518 | { | ||
| 1519 | return gfs2_xattr_set(inode, GFS2_EATYPE_SYS, name, value, size, flags); | ||
| 1520 | } | ||
| 1521 | |||
| 1522 | static int gfs2_xattr_security_get(struct inode *inode, const char *name, | 1544 | static int gfs2_xattr_security_get(struct inode *inode, const char *name, |
| 1523 | void *buffer, size_t size) | 1545 | void *buffer, size_t size) |
| 1524 | { | 1546 | { |
| @@ -1543,12 +1565,6 @@ static struct xattr_handler gfs2_xattr_security_handler = { | |||
| 1543 | .set = gfs2_xattr_security_set, | 1565 | .set = gfs2_xattr_security_set, |
| 1544 | }; | 1566 | }; |
| 1545 | 1567 | ||
| 1546 | static struct xattr_handler gfs2_xattr_system_handler = { | ||
| 1547 | .prefix = XATTR_SYSTEM_PREFIX, | ||
| 1548 | .get = gfs2_xattr_system_get, | ||
| 1549 | .set = gfs2_xattr_system_set, | ||
| 1550 | }; | ||
| 1551 | |||
| 1552 | struct xattr_handler *gfs2_xattr_handlers[] = { | 1568 | struct xattr_handler *gfs2_xattr_handlers[] = { |
| 1553 | &gfs2_xattr_user_handler, | 1569 | &gfs2_xattr_user_handler, |
| 1554 | &gfs2_xattr_security_handler, | 1570 | &gfs2_xattr_security_handler, |
diff --git a/fs/gfs2/xattr.h b/fs/gfs2/xattr.h index cbdfd7743733..8d6ae5813c4d 100644 --- a/fs/gfs2/xattr.h +++ b/fs/gfs2/xattr.h | |||
| @@ -62,11 +62,7 @@ extern int gfs2_ea_dealloc(struct gfs2_inode *ip); | |||
| 62 | 62 | ||
| 63 | /* Exported to acl.c */ | 63 | /* Exported to acl.c */ |
| 64 | 64 | ||
| 65 | extern int gfs2_ea_find(struct gfs2_inode *ip, int type, const char *name, | 65 | extern int gfs2_xattr_acl_get(struct gfs2_inode *ip, const char *name, char **data); |
| 66 | struct gfs2_ea_location *el); | 66 | extern int gfs2_xattr_acl_chmod(struct gfs2_inode *ip, struct iattr *attr, char *data); |
| 67 | extern int gfs2_ea_get_copy(struct gfs2_inode *ip, struct gfs2_ea_location *el, | ||
| 68 | char *data, size_t size); | ||
| 69 | extern int gfs2_ea_acl_chmod(struct gfs2_inode *ip, struct gfs2_ea_location *el, | ||
| 70 | struct iattr *attr, char *data); | ||
| 71 | 67 | ||
| 72 | #endif /* __EATTR_DOT_H__ */ | 68 | #endif /* __EATTR_DOT_H__ */ |
diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c index 6d98f116ca03..424b0337f524 100644 --- a/fs/hfs/catalog.c +++ b/fs/hfs/catalog.c | |||
| @@ -289,6 +289,10 @@ int hfs_cat_move(u32 cnid, struct inode *src_dir, struct qstr *src_name, | |||
| 289 | err = hfs_brec_find(&src_fd); | 289 | err = hfs_brec_find(&src_fd); |
| 290 | if (err) | 290 | if (err) |
| 291 | goto out; | 291 | goto out; |
| 292 | if (src_fd.entrylength > sizeof(entry) || src_fd.entrylength < 0) { | ||
| 293 | err = -EIO; | ||
| 294 | goto out; | ||
| 295 | } | ||
| 292 | 296 | ||
| 293 | hfs_bnode_read(src_fd.bnode, &entry, src_fd.entryoffset, | 297 | hfs_bnode_read(src_fd.bnode, &entry, src_fd.entryoffset, |
| 294 | src_fd.entrylength); | 298 | src_fd.entrylength); |
diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c index 7c69b98a2e45..2b3b8611b41b 100644 --- a/fs/hfs/dir.c +++ b/fs/hfs/dir.c | |||
| @@ -79,6 +79,11 @@ static int hfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 79 | filp->f_pos++; | 79 | filp->f_pos++; |
| 80 | /* fall through */ | 80 | /* fall through */ |
| 81 | case 1: | 81 | case 1: |
| 82 | if (fd.entrylength > sizeof(entry) || fd.entrylength < 0) { | ||
| 83 | err = -EIO; | ||
| 84 | goto out; | ||
| 85 | } | ||
| 86 | |||
| 82 | hfs_bnode_read(fd.bnode, &entry, fd.entryoffset, fd.entrylength); | 87 | hfs_bnode_read(fd.bnode, &entry, fd.entryoffset, fd.entrylength); |
| 83 | if (entry.type != HFS_CDR_THD) { | 88 | if (entry.type != HFS_CDR_THD) { |
| 84 | printk(KERN_ERR "hfs: bad catalog folder thread\n"); | 89 | printk(KERN_ERR "hfs: bad catalog folder thread\n"); |
| @@ -109,6 +114,12 @@ static int hfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 109 | err = -EIO; | 114 | err = -EIO; |
| 110 | goto out; | 115 | goto out; |
| 111 | } | 116 | } |
| 117 | |||
| 118 | if (fd.entrylength > sizeof(entry) || fd.entrylength < 0) { | ||
| 119 | err = -EIO; | ||
| 120 | goto out; | ||
| 121 | } | ||
| 122 | |||
| 112 | hfs_bnode_read(fd.bnode, &entry, fd.entryoffset, fd.entrylength); | 123 | hfs_bnode_read(fd.bnode, &entry, fd.entryoffset, fd.entrylength); |
| 113 | type = entry.type; | 124 | type = entry.type; |
| 114 | len = hfs_mac2asc(sb, strbuf, &fd.key->cat.CName); | 125 | len = hfs_mac2asc(sb, strbuf, &fd.key->cat.CName); |
diff --git a/fs/hfs/super.c b/fs/hfs/super.c index f7fcbe49da72..5ed7252b7b23 100644 --- a/fs/hfs/super.c +++ b/fs/hfs/super.c | |||
| @@ -409,8 +409,13 @@ static int hfs_fill_super(struct super_block *sb, void *data, int silent) | |||
| 409 | /* try to get the root inode */ | 409 | /* try to get the root inode */ |
| 410 | hfs_find_init(HFS_SB(sb)->cat_tree, &fd); | 410 | hfs_find_init(HFS_SB(sb)->cat_tree, &fd); |
| 411 | res = hfs_cat_find_brec(sb, HFS_ROOT_CNID, &fd); | 411 | res = hfs_cat_find_brec(sb, HFS_ROOT_CNID, &fd); |
| 412 | if (!res) | 412 | if (!res) { |
| 413 | if (fd.entrylength > sizeof(rec) || fd.entrylength < 0) { | ||
| 414 | res = -EIO; | ||
| 415 | goto bail; | ||
| 416 | } | ||
| 413 | hfs_bnode_read(fd.bnode, &rec, fd.entryoffset, fd.entrylength); | 417 | hfs_bnode_read(fd.bnode, &rec, fd.entryoffset, fd.entrylength); |
| 418 | } | ||
| 414 | if (res) { | 419 | if (res) { |
| 415 | hfs_find_exit(&fd); | 420 | hfs_find_exit(&fd); |
| 416 | goto bail_no_root; | 421 | goto bail_no_root; |
diff --git a/fs/inode.c b/fs/inode.c index 4d8e3be55976..06c1f02de611 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
| @@ -18,7 +18,6 @@ | |||
| 18 | #include <linux/hash.h> | 18 | #include <linux/hash.h> |
| 19 | #include <linux/swap.h> | 19 | #include <linux/swap.h> |
| 20 | #include <linux/security.h> | 20 | #include <linux/security.h> |
| 21 | #include <linux/ima.h> | ||
| 22 | #include <linux/pagemap.h> | 21 | #include <linux/pagemap.h> |
| 23 | #include <linux/cdev.h> | 22 | #include <linux/cdev.h> |
| 24 | #include <linux/bootmem.h> | 23 | #include <linux/bootmem.h> |
| @@ -157,11 +156,6 @@ int inode_init_always(struct super_block *sb, struct inode *inode) | |||
| 157 | 156 | ||
| 158 | if (security_inode_alloc(inode)) | 157 | if (security_inode_alloc(inode)) |
| 159 | goto out; | 158 | goto out; |
| 160 | |||
| 161 | /* allocate and initialize an i_integrity */ | ||
| 162 | if (ima_inode_alloc(inode)) | ||
| 163 | goto out_free_security; | ||
| 164 | |||
| 165 | spin_lock_init(&inode->i_lock); | 159 | spin_lock_init(&inode->i_lock); |
| 166 | lockdep_set_class(&inode->i_lock, &sb->s_type->i_lock_key); | 160 | lockdep_set_class(&inode->i_lock, &sb->s_type->i_lock_key); |
| 167 | 161 | ||
| @@ -201,9 +195,6 @@ int inode_init_always(struct super_block *sb, struct inode *inode) | |||
| 201 | #endif | 195 | #endif |
| 202 | 196 | ||
| 203 | return 0; | 197 | return 0; |
| 204 | |||
| 205 | out_free_security: | ||
| 206 | security_inode_free(inode); | ||
| 207 | out: | 198 | out: |
| 208 | return -ENOMEM; | 199 | return -ENOMEM; |
| 209 | } | 200 | } |
| @@ -235,7 +226,6 @@ static struct inode *alloc_inode(struct super_block *sb) | |||
| 235 | void __destroy_inode(struct inode *inode) | 226 | void __destroy_inode(struct inode *inode) |
| 236 | { | 227 | { |
| 237 | BUG_ON(inode_has_buffers(inode)); | 228 | BUG_ON(inode_has_buffers(inode)); |
| 238 | ima_inode_free(inode); | ||
| 239 | security_inode_free(inode); | 229 | security_inode_free(inode); |
| 240 | fsnotify_inode_delete(inode); | 230 | fsnotify_inode_delete(inode); |
| 241 | #ifdef CONFIG_FS_POSIX_ACL | 231 | #ifdef CONFIG_FS_POSIX_ACL |
diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index defb932eee9a..0b3fa7974fa8 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c | |||
| @@ -36,286 +36,323 @@ static void *zisofs_zlib_workspace; | |||
| 36 | static DEFINE_MUTEX(zisofs_zlib_lock); | 36 | static DEFINE_MUTEX(zisofs_zlib_lock); |
| 37 | 37 | ||
| 38 | /* | 38 | /* |
| 39 | * When decompressing, we typically obtain more than one page | 39 | * Read data of @inode from @block_start to @block_end and uncompress |
| 40 | * per reference. We inject the additional pages into the page | 40 | * to one zisofs block. Store the data in the @pages array with @pcount |
| 41 | * cache as a form of readahead. | 41 | * entries. Start storing at offset @poffset of the first page. |
| 42 | */ | 42 | */ |
| 43 | static int zisofs_readpage(struct file *file, struct page *page) | 43 | static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, |
| 44 | loff_t block_end, int pcount, | ||
| 45 | struct page **pages, unsigned poffset, | ||
| 46 | int *errp) | ||
| 44 | { | 47 | { |
| 45 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 46 | struct address_space *mapping = inode->i_mapping; | ||
| 47 | unsigned int maxpage, xpage, fpage, blockindex; | ||
| 48 | unsigned long offset; | ||
| 49 | unsigned long blockptr, blockendptr, cstart, cend, csize; | ||
| 50 | struct buffer_head *bh, *ptrbh[2]; | ||
| 51 | unsigned long bufsize = ISOFS_BUFFER_SIZE(inode); | ||
| 52 | unsigned int bufshift = ISOFS_BUFFER_BITS(inode); | ||
| 53 | unsigned long bufmask = bufsize - 1; | ||
| 54 | int err = -EIO; | ||
| 55 | int i; | ||
| 56 | unsigned int header_size = ISOFS_I(inode)->i_format_parm[0]; | ||
| 57 | unsigned int zisofs_block_shift = ISOFS_I(inode)->i_format_parm[1]; | 48 | unsigned int zisofs_block_shift = ISOFS_I(inode)->i_format_parm[1]; |
| 58 | /* unsigned long zisofs_block_size = 1UL << zisofs_block_shift; */ | 49 | unsigned int bufsize = ISOFS_BUFFER_SIZE(inode); |
| 59 | unsigned int zisofs_block_page_shift = zisofs_block_shift-PAGE_CACHE_SHIFT; | 50 | unsigned int bufshift = ISOFS_BUFFER_BITS(inode); |
| 60 | unsigned long zisofs_block_pages = 1UL << zisofs_block_page_shift; | 51 | unsigned int bufmask = bufsize - 1; |
| 61 | unsigned long zisofs_block_page_mask = zisofs_block_pages-1; | 52 | int i, block_size = block_end - block_start; |
| 62 | struct page *pages[zisofs_block_pages]; | 53 | z_stream stream = { .total_out = 0, |
| 63 | unsigned long index = page->index; | 54 | .avail_in = 0, |
| 64 | int indexblocks; | 55 | .avail_out = 0, }; |
| 65 | 56 | int zerr; | |
| 66 | /* We have already been given one page, this is the one | 57 | int needblocks = (block_size + (block_start & bufmask) + bufmask) |
| 67 | we must do. */ | 58 | >> bufshift; |
| 68 | xpage = index & zisofs_block_page_mask; | 59 | int haveblocks; |
| 69 | pages[xpage] = page; | 60 | blkcnt_t blocknum; |
| 70 | 61 | struct buffer_head *bhs[needblocks + 1]; | |
| 71 | /* The remaining pages need to be allocated and inserted */ | 62 | int curbh, curpage; |
| 72 | offset = index & ~zisofs_block_page_mask; | 63 | |
| 73 | blockindex = offset >> zisofs_block_page_shift; | 64 | if (block_size > deflateBound(1UL << zisofs_block_shift)) { |
| 74 | maxpage = (inode->i_size + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; | 65 | *errp = -EIO; |
| 75 | |||
| 76 | /* | ||
| 77 | * If this page is wholly outside i_size we just return zero; | ||
| 78 | * do_generic_file_read() will handle this for us | ||
| 79 | */ | ||
| 80 | if (page->index >= maxpage) { | ||
| 81 | SetPageUptodate(page); | ||
| 82 | unlock_page(page); | ||
| 83 | return 0; | 66 | return 0; |
| 84 | } | 67 | } |
| 85 | 68 | /* Empty block? */ | |
| 86 | maxpage = min(zisofs_block_pages, maxpage-offset); | 69 | if (block_size == 0) { |
| 87 | 70 | for ( i = 0 ; i < pcount ; i++ ) { | |
| 88 | for ( i = 0 ; i < maxpage ; i++, offset++ ) { | 71 | if (!pages[i]) |
| 89 | if ( i != xpage ) { | 72 | continue; |
| 90 | pages[i] = grab_cache_page_nowait(mapping, offset); | 73 | memset(page_address(pages[i]), 0, PAGE_CACHE_SIZE); |
| 91 | } | 74 | flush_dcache_page(pages[i]); |
| 92 | page = pages[i]; | 75 | SetPageUptodate(pages[i]); |
| 93 | if ( page ) { | ||
| 94 | ClearPageError(page); | ||
| 95 | kmap(page); | ||
| 96 | } | 76 | } |
| 77 | return ((loff_t)pcount) << PAGE_CACHE_SHIFT; | ||
| 97 | } | 78 | } |
| 98 | 79 | ||
| 99 | /* This is the last page filled, plus one; used in case of abort. */ | 80 | /* Because zlib is not thread-safe, do all the I/O at the top. */ |
| 100 | fpage = 0; | 81 | blocknum = block_start >> bufshift; |
| 82 | memset(bhs, 0, (needblocks + 1) * sizeof(struct buffer_head *)); | ||
| 83 | haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks); | ||
| 84 | ll_rw_block(READ, haveblocks, bhs); | ||
| 101 | 85 | ||
| 102 | /* Find the pointer to this specific chunk */ | 86 | curbh = 0; |
| 103 | /* Note: we're not using isonum_731() here because the data is known aligned */ | 87 | curpage = 0; |
| 104 | /* Note: header_size is in 32-bit words (4 bytes) */ | 88 | /* |
| 105 | blockptr = (header_size + blockindex) << 2; | 89 | * First block is special since it may be fractional. We also wait for |
| 106 | blockendptr = blockptr + 4; | 90 | * it before grabbing the zlib mutex; odds are that the subsequent |
| 91 | * blocks are going to come in in short order so we don't hold the zlib | ||
| 92 | * mutex longer than necessary. | ||
| 93 | */ | ||
| 107 | 94 | ||
| 108 | indexblocks = ((blockptr^blockendptr) >> bufshift) ? 2 : 1; | 95 | if (!bhs[0]) |
| 109 | ptrbh[0] = ptrbh[1] = NULL; | 96 | goto b_eio; |
| 110 | 97 | ||
| 111 | if ( isofs_get_blocks(inode, blockptr >> bufshift, ptrbh, indexblocks) != indexblocks ) { | 98 | wait_on_buffer(bhs[0]); |
| 112 | if ( ptrbh[0] ) brelse(ptrbh[0]); | 99 | if (!buffer_uptodate(bhs[0])) { |
| 113 | printk(KERN_DEBUG "zisofs: Null buffer on reading block table, inode = %lu, block = %lu\n", | 100 | *errp = -EIO; |
| 114 | inode->i_ino, blockptr >> bufshift); | 101 | goto b_eio; |
| 115 | goto eio; | ||
| 116 | } | ||
| 117 | ll_rw_block(READ, indexblocks, ptrbh); | ||
| 118 | |||
| 119 | bh = ptrbh[0]; | ||
| 120 | if ( !bh || (wait_on_buffer(bh), !buffer_uptodate(bh)) ) { | ||
| 121 | printk(KERN_DEBUG "zisofs: Failed to read block table, inode = %lu, block = %lu\n", | ||
| 122 | inode->i_ino, blockptr >> bufshift); | ||
| 123 | if ( ptrbh[1] ) | ||
| 124 | brelse(ptrbh[1]); | ||
| 125 | goto eio; | ||
| 126 | } | ||
| 127 | cstart = le32_to_cpu(*(__le32 *)(bh->b_data + (blockptr & bufmask))); | ||
| 128 | |||
| 129 | if ( indexblocks == 2 ) { | ||
| 130 | /* We just crossed a block boundary. Switch to the next block */ | ||
| 131 | brelse(bh); | ||
| 132 | bh = ptrbh[1]; | ||
| 133 | if ( !bh || (wait_on_buffer(bh), !buffer_uptodate(bh)) ) { | ||
| 134 | printk(KERN_DEBUG "zisofs: Failed to read block table, inode = %lu, block = %lu\n", | ||
| 135 | inode->i_ino, blockendptr >> bufshift); | ||
| 136 | goto eio; | ||
| 137 | } | ||
| 138 | } | 102 | } |
| 139 | cend = le32_to_cpu(*(__le32 *)(bh->b_data + (blockendptr & bufmask))); | ||
| 140 | brelse(bh); | ||
| 141 | 103 | ||
| 142 | if (cstart > cend) | 104 | stream.workspace = zisofs_zlib_workspace; |
| 143 | goto eio; | 105 | mutex_lock(&zisofs_zlib_lock); |
| 144 | 106 | ||
| 145 | csize = cend-cstart; | 107 | zerr = zlib_inflateInit(&stream); |
| 146 | 108 | if (zerr != Z_OK) { | |
| 147 | if (csize > deflateBound(1UL << zisofs_block_shift)) | 109 | if (zerr == Z_MEM_ERROR) |
| 148 | goto eio; | 110 | *errp = -ENOMEM; |
| 149 | 111 | else | |
| 150 | /* Now page[] contains an array of pages, any of which can be NULL, | 112 | *errp = -EIO; |
| 151 | and the locks on which we hold. We should now read the data and | 113 | printk(KERN_DEBUG "zisofs: zisofs_inflateInit returned %d\n", |
| 152 | release the pages. If the pages are NULL the decompressed data | 114 | zerr); |
| 153 | for that particular page should be discarded. */ | 115 | goto z_eio; |
| 154 | 116 | } | |
| 155 | if ( csize == 0 ) { | 117 | |
| 156 | /* This data block is empty. */ | 118 | while (curpage < pcount && curbh < haveblocks && |
| 157 | 119 | zerr != Z_STREAM_END) { | |
| 158 | for ( fpage = 0 ; fpage < maxpage ; fpage++ ) { | 120 | if (!stream.avail_out) { |
| 159 | if ( (page = pages[fpage]) != NULL ) { | 121 | if (pages[curpage]) { |
| 160 | memset(page_address(page), 0, PAGE_CACHE_SIZE); | 122 | stream.next_out = page_address(pages[curpage]) |
| 161 | 123 | + poffset; | |
| 162 | flush_dcache_page(page); | 124 | stream.avail_out = PAGE_CACHE_SIZE - poffset; |
| 163 | SetPageUptodate(page); | 125 | poffset = 0; |
| 164 | kunmap(page); | 126 | } else { |
| 165 | unlock_page(page); | 127 | stream.next_out = (void *)&zisofs_sink_page; |
| 166 | if ( fpage == xpage ) | 128 | stream.avail_out = PAGE_CACHE_SIZE; |
| 167 | err = 0; /* The critical page */ | ||
| 168 | else | ||
| 169 | page_cache_release(page); | ||
| 170 | } | 129 | } |
| 171 | } | 130 | } |
| 172 | } else { | 131 | if (!stream.avail_in) { |
| 173 | /* This data block is compressed. */ | 132 | wait_on_buffer(bhs[curbh]); |
| 174 | z_stream stream; | 133 | if (!buffer_uptodate(bhs[curbh])) { |
| 175 | int bail = 0, left_out = -1; | 134 | *errp = -EIO; |
| 176 | int zerr; | 135 | break; |
| 177 | int needblocks = (csize + (cstart & bufmask) + bufmask) >> bufshift; | 136 | } |
| 178 | int haveblocks; | 137 | stream.next_in = bhs[curbh]->b_data + |
| 179 | struct buffer_head *bhs[needblocks+1]; | 138 | (block_start & bufmask); |
| 180 | struct buffer_head **bhptr; | 139 | stream.avail_in = min_t(unsigned, bufsize - |
| 181 | 140 | (block_start & bufmask), | |
| 182 | /* Because zlib is not thread-safe, do all the I/O at the top. */ | 141 | block_size); |
| 183 | 142 | block_size -= stream.avail_in; | |
| 184 | blockptr = cstart >> bufshift; | 143 | block_start = 0; |
| 185 | memset(bhs, 0, (needblocks+1)*sizeof(struct buffer_head *)); | ||
| 186 | haveblocks = isofs_get_blocks(inode, blockptr, bhs, needblocks); | ||
| 187 | ll_rw_block(READ, haveblocks, bhs); | ||
| 188 | |||
| 189 | bhptr = &bhs[0]; | ||
| 190 | bh = *bhptr++; | ||
| 191 | |||
| 192 | /* First block is special since it may be fractional. | ||
| 193 | We also wait for it before grabbing the zlib | ||
| 194 | mutex; odds are that the subsequent blocks are | ||
| 195 | going to come in in short order so we don't hold | ||
| 196 | the zlib mutex longer than necessary. */ | ||
| 197 | |||
| 198 | if ( !bh || (wait_on_buffer(bh), !buffer_uptodate(bh)) ) { | ||
| 199 | printk(KERN_DEBUG "zisofs: Hit null buffer, fpage = %d, xpage = %d, csize = %ld\n", | ||
| 200 | fpage, xpage, csize); | ||
| 201 | goto b_eio; | ||
| 202 | } | ||
| 203 | stream.next_in = bh->b_data + (cstart & bufmask); | ||
| 204 | stream.avail_in = min(bufsize-(cstart & bufmask), csize); | ||
| 205 | csize -= stream.avail_in; | ||
| 206 | |||
| 207 | stream.workspace = zisofs_zlib_workspace; | ||
| 208 | mutex_lock(&zisofs_zlib_lock); | ||
| 209 | |||
| 210 | zerr = zlib_inflateInit(&stream); | ||
| 211 | if ( zerr != Z_OK ) { | ||
| 212 | if ( err && zerr == Z_MEM_ERROR ) | ||
| 213 | err = -ENOMEM; | ||
| 214 | printk(KERN_DEBUG "zisofs: zisofs_inflateInit returned %d\n", | ||
| 215 | zerr); | ||
| 216 | goto z_eio; | ||
| 217 | } | 144 | } |
| 218 | 145 | ||
| 219 | while ( !bail && fpage < maxpage ) { | 146 | while (stream.avail_out && stream.avail_in) { |
| 220 | page = pages[fpage]; | 147 | zerr = zlib_inflate(&stream, Z_SYNC_FLUSH); |
| 221 | if ( page ) | 148 | if (zerr == Z_BUF_ERROR && stream.avail_in == 0) |
| 222 | stream.next_out = page_address(page); | 149 | break; |
| 223 | else | 150 | if (zerr == Z_STREAM_END) |
| 224 | stream.next_out = (void *)&zisofs_sink_page; | 151 | break; |
| 225 | stream.avail_out = PAGE_CACHE_SIZE; | 152 | if (zerr != Z_OK) { |
| 226 | 153 | /* EOF, error, or trying to read beyond end of input */ | |
| 227 | while ( stream.avail_out ) { | 154 | if (zerr == Z_MEM_ERROR) |
| 228 | int ao, ai; | 155 | *errp = -ENOMEM; |
| 229 | if ( stream.avail_in == 0 && left_out ) { | 156 | else { |
| 230 | if ( !csize ) { | 157 | printk(KERN_DEBUG |
| 231 | printk(KERN_WARNING "zisofs: ZF read beyond end of input\n"); | 158 | "zisofs: zisofs_inflate returned" |
| 232 | bail = 1; | 159 | " %d, inode = %lu," |
| 233 | break; | 160 | " page idx = %d, bh idx = %d," |
| 234 | } else { | 161 | " avail_in = %d," |
| 235 | bh = *bhptr++; | 162 | " avail_out = %d\n", |
| 236 | if ( !bh || | 163 | zerr, inode->i_ino, curpage, |
| 237 | (wait_on_buffer(bh), !buffer_uptodate(bh)) ) { | 164 | curbh, stream.avail_in, |
| 238 | /* Reached an EIO */ | 165 | stream.avail_out); |
| 239 | printk(KERN_DEBUG "zisofs: Hit null buffer, fpage = %d, xpage = %d, csize = %ld\n", | 166 | *errp = -EIO; |
| 240 | fpage, xpage, csize); | ||
| 241 | |||
| 242 | bail = 1; | ||
| 243 | break; | ||
| 244 | } | ||
| 245 | stream.next_in = bh->b_data; | ||
| 246 | stream.avail_in = min(csize,bufsize); | ||
| 247 | csize -= stream.avail_in; | ||
| 248 | } | ||
| 249 | } | ||
| 250 | ao = stream.avail_out; ai = stream.avail_in; | ||
| 251 | zerr = zlib_inflate(&stream, Z_SYNC_FLUSH); | ||
| 252 | left_out = stream.avail_out; | ||
| 253 | if ( zerr == Z_BUF_ERROR && stream.avail_in == 0 ) | ||
| 254 | continue; | ||
| 255 | if ( zerr != Z_OK ) { | ||
| 256 | /* EOF, error, or trying to read beyond end of input */ | ||
| 257 | if ( err && zerr == Z_MEM_ERROR ) | ||
| 258 | err = -ENOMEM; | ||
| 259 | if ( zerr != Z_STREAM_END ) | ||
| 260 | printk(KERN_DEBUG "zisofs: zisofs_inflate returned %d, inode = %lu, index = %lu, fpage = %d, xpage = %d, avail_in = %d, avail_out = %d, ai = %d, ao = %d\n", | ||
| 261 | zerr, inode->i_ino, index, | ||
| 262 | fpage, xpage, | ||
| 263 | stream.avail_in, stream.avail_out, | ||
| 264 | ai, ao); | ||
| 265 | bail = 1; | ||
| 266 | break; | ||
| 267 | } | 167 | } |
| 168 | goto inflate_out; | ||
| 268 | } | 169 | } |
| 170 | } | ||
| 269 | 171 | ||
| 270 | if ( stream.avail_out && zerr == Z_STREAM_END ) { | 172 | if (!stream.avail_out) { |
| 271 | /* Fractional page written before EOF. This may | 173 | /* This page completed */ |
| 272 | be the last page in the file. */ | 174 | if (pages[curpage]) { |
| 273 | memset(stream.next_out, 0, stream.avail_out); | 175 | flush_dcache_page(pages[curpage]); |
| 274 | stream.avail_out = 0; | 176 | SetPageUptodate(pages[curpage]); |
| 275 | } | 177 | } |
| 178 | curpage++; | ||
| 179 | } | ||
| 180 | if (!stream.avail_in) | ||
| 181 | curbh++; | ||
| 182 | } | ||
| 183 | inflate_out: | ||
| 184 | zlib_inflateEnd(&stream); | ||
| 276 | 185 | ||
| 277 | if ( !stream.avail_out ) { | 186 | z_eio: |
| 278 | /* This page completed */ | 187 | mutex_unlock(&zisofs_zlib_lock); |
| 279 | if ( page ) { | 188 | |
| 280 | flush_dcache_page(page); | 189 | b_eio: |
| 281 | SetPageUptodate(page); | 190 | for (i = 0; i < haveblocks; i++) |
| 282 | kunmap(page); | 191 | brelse(bhs[i]); |
| 283 | unlock_page(page); | 192 | return stream.total_out; |
| 284 | if ( fpage == xpage ) | 193 | } |
| 285 | err = 0; /* The critical page */ | 194 | |
| 286 | else | 195 | /* |
| 287 | page_cache_release(page); | 196 | * Uncompress data so that pages[full_page] is fully uptodate and possibly |
| 288 | } | 197 | * fills in other pages if we have data for them. |
| 289 | fpage++; | 198 | */ |
| 290 | } | 199 | static int zisofs_fill_pages(struct inode *inode, int full_page, int pcount, |
| 200 | struct page **pages) | ||
| 201 | { | ||
| 202 | loff_t start_off, end_off; | ||
| 203 | loff_t block_start, block_end; | ||
| 204 | unsigned int header_size = ISOFS_I(inode)->i_format_parm[0]; | ||
| 205 | unsigned int zisofs_block_shift = ISOFS_I(inode)->i_format_parm[1]; | ||
| 206 | unsigned int blockptr; | ||
| 207 | loff_t poffset = 0; | ||
| 208 | blkcnt_t cstart_block, cend_block; | ||
| 209 | struct buffer_head *bh; | ||
| 210 | unsigned int blkbits = ISOFS_BUFFER_BITS(inode); | ||
| 211 | unsigned int blksize = 1 << blkbits; | ||
| 212 | int err; | ||
| 213 | loff_t ret; | ||
| 214 | |||
| 215 | BUG_ON(!pages[full_page]); | ||
| 216 | |||
| 217 | /* | ||
| 218 | * We want to read at least 'full_page' page. Because we have to | ||
| 219 | * uncompress the whole compression block anyway, fill the surrounding | ||
| 220 | * pages with the data we have anyway... | ||
| 221 | */ | ||
| 222 | start_off = page_offset(pages[full_page]); | ||
| 223 | end_off = min_t(loff_t, start_off + PAGE_CACHE_SIZE, inode->i_size); | ||
| 224 | |||
| 225 | cstart_block = start_off >> zisofs_block_shift; | ||
| 226 | cend_block = (end_off + (1 << zisofs_block_shift) - 1) | ||
| 227 | >> zisofs_block_shift; | ||
| 228 | |||
| 229 | WARN_ON(start_off - (full_page << PAGE_CACHE_SHIFT) != | ||
| 230 | ((cstart_block << zisofs_block_shift) & PAGE_CACHE_MASK)); | ||
| 231 | |||
| 232 | /* Find the pointer to this specific chunk */ | ||
| 233 | /* Note: we're not using isonum_731() here because the data is known aligned */ | ||
| 234 | /* Note: header_size is in 32-bit words (4 bytes) */ | ||
| 235 | blockptr = (header_size + cstart_block) << 2; | ||
| 236 | bh = isofs_bread(inode, blockptr >> blkbits); | ||
| 237 | if (!bh) | ||
| 238 | return -EIO; | ||
| 239 | block_start = le32_to_cpu(*(__le32 *) | ||
| 240 | (bh->b_data + (blockptr & (blksize - 1)))); | ||
| 241 | |||
| 242 | while (cstart_block < cend_block && pcount > 0) { | ||
| 243 | /* Load end of the compressed block in the file */ | ||
| 244 | blockptr += 4; | ||
| 245 | /* Traversed to next block? */ | ||
| 246 | if (!(blockptr & (blksize - 1))) { | ||
| 247 | brelse(bh); | ||
| 248 | |||
| 249 | bh = isofs_bread(inode, blockptr >> blkbits); | ||
| 250 | if (!bh) | ||
| 251 | return -EIO; | ||
| 252 | } | ||
| 253 | block_end = le32_to_cpu(*(__le32 *) | ||
| 254 | (bh->b_data + (blockptr & (blksize - 1)))); | ||
| 255 | if (block_start > block_end) { | ||
| 256 | brelse(bh); | ||
| 257 | return -EIO; | ||
| 258 | } | ||
| 259 | err = 0; | ||
| 260 | ret = zisofs_uncompress_block(inode, block_start, block_end, | ||
| 261 | pcount, pages, poffset, &err); | ||
| 262 | poffset += ret; | ||
| 263 | pages += poffset >> PAGE_CACHE_SHIFT; | ||
| 264 | pcount -= poffset >> PAGE_CACHE_SHIFT; | ||
| 265 | full_page -= poffset >> PAGE_CACHE_SHIFT; | ||
| 266 | poffset &= ~PAGE_CACHE_MASK; | ||
| 267 | |||
| 268 | if (err) { | ||
| 269 | brelse(bh); | ||
| 270 | /* | ||
| 271 | * Did we finish reading the page we really wanted | ||
| 272 | * to read? | ||
| 273 | */ | ||
| 274 | if (full_page < 0) | ||
| 275 | return 0; | ||
| 276 | return err; | ||
| 291 | } | 277 | } |
| 292 | zlib_inflateEnd(&stream); | ||
| 293 | 278 | ||
| 294 | z_eio: | 279 | block_start = block_end; |
| 295 | mutex_unlock(&zisofs_zlib_lock); | 280 | cstart_block++; |
| 281 | } | ||
| 282 | |||
| 283 | if (poffset && *pages) { | ||
| 284 | memset(page_address(*pages) + poffset, 0, | ||
| 285 | PAGE_CACHE_SIZE - poffset); | ||
| 286 | flush_dcache_page(*pages); | ||
| 287 | SetPageUptodate(*pages); | ||
| 288 | } | ||
| 289 | return 0; | ||
| 290 | } | ||
| 296 | 291 | ||
| 297 | b_eio: | 292 | /* |
| 298 | for ( i = 0 ; i < haveblocks ; i++ ) { | 293 | * When decompressing, we typically obtain more than one page |
| 299 | if ( bhs[i] ) | 294 | * per reference. We inject the additional pages into the page |
| 300 | brelse(bhs[i]); | 295 | * cache as a form of readahead. |
| 296 | */ | ||
| 297 | static int zisofs_readpage(struct file *file, struct page *page) | ||
| 298 | { | ||
| 299 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 300 | struct address_space *mapping = inode->i_mapping; | ||
| 301 | int err; | ||
| 302 | int i, pcount, full_page; | ||
| 303 | unsigned int zisofs_block_shift = ISOFS_I(inode)->i_format_parm[1]; | ||
| 304 | unsigned int zisofs_pages_per_cblock = | ||
| 305 | PAGE_CACHE_SHIFT <= zisofs_block_shift ? | ||
| 306 | (1 << (zisofs_block_shift - PAGE_CACHE_SHIFT)) : 0; | ||
| 307 | struct page *pages[max_t(unsigned, zisofs_pages_per_cblock, 1)]; | ||
| 308 | pgoff_t index = page->index, end_index; | ||
| 309 | |||
| 310 | end_index = (inode->i_size + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; | ||
| 311 | /* | ||
| 312 | * If this page is wholly outside i_size we just return zero; | ||
| 313 | * do_generic_file_read() will handle this for us | ||
| 314 | */ | ||
| 315 | if (index >= end_index) { | ||
| 316 | SetPageUptodate(page); | ||
| 317 | unlock_page(page); | ||
| 318 | return 0; | ||
| 319 | } | ||
| 320 | |||
| 321 | if (PAGE_CACHE_SHIFT <= zisofs_block_shift) { | ||
| 322 | /* We have already been given one page, this is the one | ||
| 323 | we must do. */ | ||
| 324 | full_page = index & (zisofs_pages_per_cblock - 1); | ||
| 325 | pcount = min_t(int, zisofs_pages_per_cblock, | ||
| 326 | end_index - (index & ~(zisofs_pages_per_cblock - 1))); | ||
| 327 | index -= full_page; | ||
| 328 | } else { | ||
| 329 | full_page = 0; | ||
| 330 | pcount = 1; | ||
| 331 | } | ||
| 332 | pages[full_page] = page; | ||
| 333 | |||
| 334 | for (i = 0; i < pcount; i++, index++) { | ||
| 335 | if (i != full_page) | ||
| 336 | pages[i] = grab_cache_page_nowait(mapping, index); | ||
| 337 | if (pages[i]) { | ||
| 338 | ClearPageError(pages[i]); | ||
| 339 | kmap(pages[i]); | ||
| 301 | } | 340 | } |
| 302 | } | 341 | } |
| 303 | 342 | ||
| 304 | eio: | 343 | err = zisofs_fill_pages(inode, full_page, pcount, pages); |
| 305 | 344 | ||
| 306 | /* Release any residual pages, do not SetPageUptodate */ | 345 | /* Release any residual pages, do not SetPageUptodate */ |
| 307 | while ( fpage < maxpage ) { | 346 | for (i = 0; i < pcount; i++) { |
| 308 | page = pages[fpage]; | 347 | if (pages[i]) { |
| 309 | if ( page ) { | 348 | flush_dcache_page(pages[i]); |
| 310 | flush_dcache_page(page); | 349 | if (i == full_page && err) |
| 311 | if ( fpage == xpage ) | 350 | SetPageError(pages[i]); |
| 312 | SetPageError(page); | 351 | kunmap(pages[i]); |
| 313 | kunmap(page); | 352 | unlock_page(pages[i]); |
| 314 | unlock_page(page); | 353 | if (i != full_page) |
| 315 | if ( fpage != xpage ) | 354 | page_cache_release(pages[i]); |
| 316 | page_cache_release(page); | ||
| 317 | } | 355 | } |
| 318 | fpage++; | ||
| 319 | } | 356 | } |
| 320 | 357 | ||
| 321 | /* At this point, err contains 0 or -EIO depending on the "critical" page */ | 358 | /* At this point, err contains 0 or -EIO depending on the "critical" page */ |
diff --git a/fs/isofs/rock.c b/fs/isofs/rock.c index c2fb2dd0131f..96a685c550fd 100644 --- a/fs/isofs/rock.c +++ b/fs/isofs/rock.c | |||
| @@ -518,8 +518,7 @@ repeat: | |||
| 518 | if (algo == SIG('p', 'z')) { | 518 | if (algo == SIG('p', 'z')) { |
| 519 | int block_shift = | 519 | int block_shift = |
| 520 | isonum_711(&rr->u.ZF.parms[1]); | 520 | isonum_711(&rr->u.ZF.parms[1]); |
| 521 | if (block_shift < PAGE_CACHE_SHIFT | 521 | if (block_shift > 17) { |
| 522 | || block_shift > 17) { | ||
| 523 | printk(KERN_WARNING "isofs: " | 522 | printk(KERN_WARNING "isofs: " |
| 524 | "Can't handle ZF block " | 523 | "Can't handle ZF block " |
| 525 | "size of 2^%d\n", | 524 | "size of 2^%d\n", |
diff --git a/fs/jbd/Kconfig b/fs/jbd/Kconfig index 4e28beeed157..a8408983abd4 100644 --- a/fs/jbd/Kconfig +++ b/fs/jbd/Kconfig | |||
| @@ -1,5 +1,6 @@ | |||
| 1 | config JBD | 1 | config JBD |
| 2 | tristate | 2 | tristate |
| 3 | select FS_JOURNAL_INFO | ||
| 3 | help | 4 | help |
| 4 | This is a generic journalling layer for block devices. It is | 5 | This is a generic journalling layer for block devices. It is |
| 5 | currently used by the ext3 file system, but it could also be | 6 | currently used by the ext3 file system, but it could also be |
diff --git a/fs/jbd2/Kconfig b/fs/jbd2/Kconfig index f32f346f4b0a..0f7d1ceafdfd 100644 --- a/fs/jbd2/Kconfig +++ b/fs/jbd2/Kconfig | |||
| @@ -1,6 +1,7 @@ | |||
| 1 | config JBD2 | 1 | config JBD2 |
| 2 | tristate | 2 | tristate |
| 3 | select CRC32 | 3 | select CRC32 |
| 4 | select FS_JOURNAL_INFO | ||
| 4 | help | 5 | help |
| 5 | This is a generic journaling layer for block devices that support | 6 | This is a generic journaling layer for block devices that support |
| 6 | both 32-bit and 64-bit block numbers. It is currently used by | 7 | both 32-bit and 64-bit block numbers. It is currently used by |
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index d4cfd6d2779e..6a10238d2c63 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c | |||
| @@ -286,7 +286,7 @@ static int journal_finish_inode_data_buffers(journal_t *journal, | |||
| 286 | if (err) { | 286 | if (err) { |
| 287 | /* | 287 | /* |
| 288 | * Because AS_EIO is cleared by | 288 | * Because AS_EIO is cleared by |
| 289 | * wait_on_page_writeback_range(), set it again so | 289 | * filemap_fdatawait_range(), set it again so |
| 290 | * that user process can get -EIO from fsync(). | 290 | * that user process can get -EIO from fsync(). |
| 291 | */ | 291 | */ |
| 292 | set_bit(AS_EIO, | 292 | set_bit(AS_EIO, |
| @@ -636,6 +636,10 @@ void jbd2_journal_commit_transaction(journal_t *journal) | |||
| 636 | JBUFFER_TRACE(jh, "ph3: write metadata"); | 636 | JBUFFER_TRACE(jh, "ph3: write metadata"); |
| 637 | flags = jbd2_journal_write_metadata_buffer(commit_transaction, | 637 | flags = jbd2_journal_write_metadata_buffer(commit_transaction, |
| 638 | jh, &new_jh, blocknr); | 638 | jh, &new_jh, blocknr); |
| 639 | if (flags < 0) { | ||
| 640 | jbd2_journal_abort(journal, flags); | ||
| 641 | continue; | ||
| 642 | } | ||
| 639 | set_bit(BH_JWrite, &jh2bh(new_jh)->b_state); | 643 | set_bit(BH_JWrite, &jh2bh(new_jh)->b_state); |
| 640 | wbuf[bufs++] = jh2bh(new_jh); | 644 | wbuf[bufs++] = jh2bh(new_jh); |
| 641 | 645 | ||
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index fed85388ee86..b7ca3a92a4db 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c | |||
| @@ -78,6 +78,7 @@ EXPORT_SYMBOL(jbd2_journal_errno); | |||
| 78 | EXPORT_SYMBOL(jbd2_journal_ack_err); | 78 | EXPORT_SYMBOL(jbd2_journal_ack_err); |
| 79 | EXPORT_SYMBOL(jbd2_journal_clear_err); | 79 | EXPORT_SYMBOL(jbd2_journal_clear_err); |
| 80 | EXPORT_SYMBOL(jbd2_log_wait_commit); | 80 | EXPORT_SYMBOL(jbd2_log_wait_commit); |
| 81 | EXPORT_SYMBOL(jbd2_log_start_commit); | ||
| 81 | EXPORT_SYMBOL(jbd2_journal_start_commit); | 82 | EXPORT_SYMBOL(jbd2_journal_start_commit); |
| 82 | EXPORT_SYMBOL(jbd2_journal_force_commit_nested); | 83 | EXPORT_SYMBOL(jbd2_journal_force_commit_nested); |
| 83 | EXPORT_SYMBOL(jbd2_journal_wipe); | 84 | EXPORT_SYMBOL(jbd2_journal_wipe); |
| @@ -358,6 +359,10 @@ repeat: | |||
| 358 | 359 | ||
| 359 | jbd_unlock_bh_state(bh_in); | 360 | jbd_unlock_bh_state(bh_in); |
| 360 | tmp = jbd2_alloc(bh_in->b_size, GFP_NOFS); | 361 | tmp = jbd2_alloc(bh_in->b_size, GFP_NOFS); |
| 362 | if (!tmp) { | ||
| 363 | jbd2_journal_put_journal_head(new_jh); | ||
| 364 | return -ENOMEM; | ||
| 365 | } | ||
| 361 | jbd_lock_bh_state(bh_in); | 366 | jbd_lock_bh_state(bh_in); |
| 362 | if (jh_in->b_frozen_data) { | 367 | if (jh_in->b_frozen_data) { |
| 363 | jbd2_free(tmp, bh_in->b_size); | 368 | jbd2_free(tmp, bh_in->b_size); |
| @@ -1248,6 +1253,13 @@ int jbd2_journal_load(journal_t *journal) | |||
| 1248 | if (jbd2_journal_recover(journal)) | 1253 | if (jbd2_journal_recover(journal)) |
| 1249 | goto recovery_error; | 1254 | goto recovery_error; |
| 1250 | 1255 | ||
| 1256 | if (journal->j_failed_commit) { | ||
| 1257 | printk(KERN_ERR "JBD2: journal transaction %u on %s " | ||
| 1258 | "is corrupt.\n", journal->j_failed_commit, | ||
| 1259 | journal->j_devname); | ||
| 1260 | return -EIO; | ||
| 1261 | } | ||
| 1262 | |||
| 1251 | /* OK, we've finished with the dynamic journal bits: | 1263 | /* OK, we've finished with the dynamic journal bits: |
| 1252 | * reinitialise the dynamic contents of the superblock in memory | 1264 | * reinitialise the dynamic contents of the superblock in memory |
| 1253 | * and reset them on disk. */ | 1265 | * and reset them on disk. */ |
diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c index f25e70c1b51c..f0294410868d 100644 --- a/fs/jffs2/compr.c +++ b/fs/jffs2/compr.c | |||
| @@ -177,7 +177,7 @@ uint16_t jffs2_compress(struct jffs2_sb_info *c, struct jffs2_inode_info *f, | |||
| 177 | spin_unlock(&jffs2_compressor_list_lock); | 177 | spin_unlock(&jffs2_compressor_list_lock); |
| 178 | break; | 178 | break; |
| 179 | default: | 179 | default: |
| 180 | printk(KERN_ERR "JFFS2: unknow compression mode.\n"); | 180 | printk(KERN_ERR "JFFS2: unknown compression mode.\n"); |
| 181 | } | 181 | } |
| 182 | out: | 182 | out: |
| 183 | if (ret == JFFS2_COMPR_NONE) { | 183 | if (ret == JFFS2_COMPR_NONE) { |
diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c index 1a80301004b8..378991cfe40f 100644 --- a/fs/jffs2/readinode.c +++ b/fs/jffs2/readinode.c | |||
| @@ -931,7 +931,7 @@ static inline int read_unknown(struct jffs2_sb_info *c, struct jffs2_raw_node_re | |||
| 931 | * Helper function for jffs2_get_inode_nodes(). | 931 | * Helper function for jffs2_get_inode_nodes(). |
| 932 | * The function detects whether more data should be read and reads it if yes. | 932 | * The function detects whether more data should be read and reads it if yes. |
| 933 | * | 933 | * |
| 934 | * Returns: 0 on succes; | 934 | * Returns: 0 on success; |
| 935 | * negative error code on failure. | 935 | * negative error code on failure. |
| 936 | */ | 936 | */ |
| 937 | static int read_more(struct jffs2_sb_info *c, struct jffs2_raw_node_ref *ref, | 937 | static int read_more(struct jffs2_sb_info *c, struct jffs2_raw_node_ref *ref, |
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c index 082e844ab2db..4b107881acd5 100644 --- a/fs/jffs2/xattr.c +++ b/fs/jffs2/xattr.c | |||
| @@ -31,7 +31,7 @@ | |||
| 31 | * is used to release xattr name/value pair and detach from c->xattrindex. | 31 | * is used to release xattr name/value pair and detach from c->xattrindex. |
| 32 | * reclaim_xattr_datum(c) | 32 | * reclaim_xattr_datum(c) |
| 33 | * is used to reclaim xattr name/value pairs on the xattr name/value pair cache when | 33 | * is used to reclaim xattr name/value pairs on the xattr name/value pair cache when |
| 34 | * memory usage by cache is over c->xdatum_mem_threshold. Currentry, this threshold | 34 | * memory usage by cache is over c->xdatum_mem_threshold. Currently, this threshold |
| 35 | * is hard coded as 32KiB. | 35 | * is hard coded as 32KiB. |
| 36 | * do_verify_xattr_datum(c, xd) | 36 | * do_verify_xattr_datum(c, xd) |
| 37 | * is used to load the xdatum informations without name/value pair from the medium. | 37 | * is used to load the xdatum informations without name/value pair from the medium. |
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 2bc7d8aa5740..d9b031cf69f5 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c | |||
| @@ -755,7 +755,7 @@ int dbAlloc(struct inode *ip, s64 hint, s64 nblocks, s64 * results) | |||
| 755 | * allocation group. | 755 | * allocation group. |
| 756 | */ | 756 | */ |
| 757 | if ((blkno & (bmp->db_agsize - 1)) == 0) | 757 | if ((blkno & (bmp->db_agsize - 1)) == 0) |
| 758 | /* check if the AG is currenly being written to. | 758 | /* check if the AG is currently being written to. |
| 759 | * if so, call dbNextAG() to find a non-busy | 759 | * if so, call dbNextAG() to find a non-busy |
| 760 | * AG with sufficient free space. | 760 | * AG with sufficient free space. |
| 761 | */ | 761 | */ |
| @@ -3337,7 +3337,7 @@ int dbExtendFS(struct inode *ipbmap, s64 blkno, s64 nblocks) | |||
| 3337 | for (i = 0, n = 0; i < agno; n++) { | 3337 | for (i = 0, n = 0; i < agno; n++) { |
| 3338 | bmp->db_agfree[n] = 0; /* init collection point */ | 3338 | bmp->db_agfree[n] = 0; /* init collection point */ |
| 3339 | 3339 | ||
| 3340 | /* coalesce cotiguous k AGs; */ | 3340 | /* coalesce contiguous k AGs; */ |
| 3341 | for (j = 0; j < k && i < agno; j++, i++) { | 3341 | for (j = 0; j < k && i < agno; j++, i++) { |
| 3342 | /* merge AGi to AGn */ | 3342 | /* merge AGi to AGn */ |
| 3343 | bmp->db_agfree[n] += bmp->db_agfree[i]; | 3343 | bmp->db_agfree[n] += bmp->db_agfree[i]; |
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index 1a54ae14a192..e50cfa3d9654 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c | |||
| @@ -371,82 +371,74 @@ EXPORT_SYMBOL_GPL(lockd_down); | |||
| 371 | 371 | ||
| 372 | static ctl_table nlm_sysctls[] = { | 372 | static ctl_table nlm_sysctls[] = { |
| 373 | { | 373 | { |
| 374 | .ctl_name = CTL_UNNUMBERED, | ||
| 375 | .procname = "nlm_grace_period", | 374 | .procname = "nlm_grace_period", |
| 376 | .data = &nlm_grace_period, | 375 | .data = &nlm_grace_period, |
| 377 | .maxlen = sizeof(unsigned long), | 376 | .maxlen = sizeof(unsigned long), |
| 378 | .mode = 0644, | 377 | .mode = 0644, |
| 379 | .proc_handler = &proc_doulongvec_minmax, | 378 | .proc_handler = proc_doulongvec_minmax, |
| 380 | .extra1 = (unsigned long *) &nlm_grace_period_min, | 379 | .extra1 = (unsigned long *) &nlm_grace_period_min, |
| 381 | .extra2 = (unsigned long *) &nlm_grace_period_max, | 380 | .extra2 = (unsigned long *) &nlm_grace_period_max, |
| 382 | }, | 381 | }, |
| 383 | { | 382 | { |
| 384 | .ctl_name = CTL_UNNUMBERED, | ||
| 385 | .procname = "nlm_timeout", | 383 | .procname = "nlm_timeout", |
| 386 | .data = &nlm_timeout, | 384 | .data = &nlm_timeout, |
| 387 | .maxlen = sizeof(unsigned long), | 385 | .maxlen = sizeof(unsigned long), |
| 388 | .mode = 0644, | 386 | .mode = 0644, |
| 389 | .proc_handler = &proc_doulongvec_minmax, | 387 | .proc_handler = proc_doulongvec_minmax, |
| 390 | .extra1 = (unsigned long *) &nlm_timeout_min, | 388 | .extra1 = (unsigned long *) &nlm_timeout_min, |
| 391 | .extra2 = (unsigned long *) &nlm_timeout_max, | 389 | .extra2 = (unsigned long *) &nlm_timeout_max, |
| 392 | }, | 390 | }, |
| 393 | { | 391 | { |
| 394 | .ctl_name = CTL_UNNUMBERED, | ||
| 395 | .procname = "nlm_udpport", | 392 | .procname = "nlm_udpport", |
| 396 | .data = &nlm_udpport, | 393 | .data = &nlm_udpport, |
| 397 | .maxlen = sizeof(int), | 394 | .maxlen = sizeof(int), |
| 398 | .mode = 0644, | 395 | .mode = 0644, |
| 399 | .proc_handler = &proc_dointvec_minmax, | 396 | .proc_handler = proc_dointvec_minmax, |
| 400 | .extra1 = (int *) &nlm_port_min, | 397 | .extra1 = (int *) &nlm_port_min, |
| 401 | .extra2 = (int *) &nlm_port_max, | 398 | .extra2 = (int *) &nlm_port_max, |
| 402 | }, | 399 | }, |
| 403 | { | 400 | { |
| 404 | .ctl_name = CTL_UNNUMBERED, | ||
| 405 | .procname = "nlm_tcpport", | 401 | .procname = "nlm_tcpport", |
| 406 | .data = &nlm_tcpport, | 402 | .data = &nlm_tcpport, |
| 407 | .maxlen = sizeof(int), | 403 | .maxlen = sizeof(int), |
| 408 | .mode = 0644, | 404 | .mode = 0644, |
| 409 | .proc_handler = &proc_dointvec_minmax, | 405 | .proc_handler = proc_dointvec_minmax, |
| 410 | .extra1 = (int *) &nlm_port_min, | 406 | .extra1 = (int *) &nlm_port_min, |
| 411 | .extra2 = (int *) &nlm_port_max, | 407 | .extra2 = (int *) &nlm_port_max, |
| 412 | }, | 408 | }, |
| 413 | { | 409 | { |
| 414 | .ctl_name = CTL_UNNUMBERED, | ||
| 415 | .procname = "nsm_use_hostnames", | 410 | .procname = "nsm_use_hostnames", |
| 416 | .data = &nsm_use_hostnames, | 411 | .data = &nsm_use_hostnames, |
| 417 | .maxlen = sizeof(int), | 412 | .maxlen = sizeof(int), |
| 418 | .mode = 0644, | 413 | .mode = 0644, |
| 419 | .proc_handler = &proc_dointvec, | 414 | .proc_handler = proc_dointvec, |
| 420 | }, | 415 | }, |
| 421 | { | 416 | { |
| 422 | .ctl_name = CTL_UNNUMBERED, | ||
| 423 | .procname = "nsm_local_state", | 417 | .procname = "nsm_local_state", |
| 424 | .data = &nsm_local_state, | 418 | .data = &nsm_local_state, |
| 425 | .maxlen = sizeof(int), | 419 | .maxlen = sizeof(int), |
| 426 | .mode = 0644, | 420 | .mode = 0644, |
| 427 | .proc_handler = &proc_dointvec, | 421 | .proc_handler = proc_dointvec, |
| 428 | }, | 422 | }, |
| 429 | { .ctl_name = 0 } | 423 | { } |
| 430 | }; | 424 | }; |
| 431 | 425 | ||
| 432 | static ctl_table nlm_sysctl_dir[] = { | 426 | static ctl_table nlm_sysctl_dir[] = { |
| 433 | { | 427 | { |
| 434 | .ctl_name = CTL_UNNUMBERED, | ||
| 435 | .procname = "nfs", | 428 | .procname = "nfs", |
| 436 | .mode = 0555, | 429 | .mode = 0555, |
| 437 | .child = nlm_sysctls, | 430 | .child = nlm_sysctls, |
| 438 | }, | 431 | }, |
| 439 | { .ctl_name = 0 } | 432 | { } |
| 440 | }; | 433 | }; |
| 441 | 434 | ||
| 442 | static ctl_table nlm_sysctl_root[] = { | 435 | static ctl_table nlm_sysctl_root[] = { |
| 443 | { | 436 | { |
| 444 | .ctl_name = CTL_FS, | ||
| 445 | .procname = "fs", | 437 | .procname = "fs", |
| 446 | .mode = 0555, | 438 | .mode = 0555, |
| 447 | .child = nlm_sysctl_dir, | 439 | .child = nlm_sysctl_dir, |
| 448 | }, | 440 | }, |
| 449 | { .ctl_name = 0 } | 441 | { } |
| 450 | }; | 442 | }; |
| 451 | 443 | ||
| 452 | #endif /* CONFIG_SYSCTL */ | 444 | #endif /* CONFIG_SYSCTL */ |
diff --git a/fs/namei.c b/fs/namei.c index d11f404667e9..87f97ba90ad1 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
| @@ -1279,28 +1279,6 @@ struct dentry *lookup_one_len(const char *name, struct dentry *base, int len) | |||
| 1279 | return __lookup_hash(&this, base, NULL); | 1279 | return __lookup_hash(&this, base, NULL); |
| 1280 | } | 1280 | } |
| 1281 | 1281 | ||
| 1282 | /** | ||
| 1283 | * lookup_one_noperm - bad hack for sysfs | ||
| 1284 | * @name: pathname component to lookup | ||
| 1285 | * @base: base directory to lookup from | ||
| 1286 | * | ||
| 1287 | * This is a variant of lookup_one_len that doesn't perform any permission | ||
| 1288 | * checks. It's a horrible hack to work around the braindead sysfs | ||
| 1289 | * architecture and should not be used anywhere else. | ||
| 1290 | * | ||
| 1291 | * DON'T USE THIS FUNCTION EVER, thanks. | ||
| 1292 | */ | ||
| 1293 | struct dentry *lookup_one_noperm(const char *name, struct dentry *base) | ||
| 1294 | { | ||
| 1295 | int err; | ||
| 1296 | struct qstr this; | ||
| 1297 | |||
| 1298 | err = __lookup_one_len(name, &this, base, strlen(name)); | ||
| 1299 | if (err) | ||
| 1300 | return ERR_PTR(err); | ||
| 1301 | return __lookup_hash(&this, base, NULL); | ||
| 1302 | } | ||
| 1303 | |||
| 1304 | int user_path_at(int dfd, const char __user *name, unsigned flags, | 1282 | int user_path_at(int dfd, const char __user *name, unsigned flags, |
| 1305 | struct path *path) | 1283 | struct path *path) |
| 1306 | { | 1284 | { |
| @@ -1678,6 +1656,15 @@ struct file *do_filp_open(int dfd, const char *pathname, | |||
| 1678 | int will_write; | 1656 | int will_write; |
| 1679 | int flag = open_to_namei_flags(open_flag); | 1657 | int flag = open_to_namei_flags(open_flag); |
| 1680 | 1658 | ||
| 1659 | /* | ||
| 1660 | * O_SYNC is implemented as __O_SYNC|O_DSYNC. As many places only | ||
| 1661 | * check for O_DSYNC if the need any syncing at all we enforce it's | ||
| 1662 | * always set instead of having to deal with possibly weird behaviour | ||
| 1663 | * for malicious applications setting only __O_SYNC. | ||
| 1664 | */ | ||
| 1665 | if (open_flag & __O_SYNC) | ||
| 1666 | open_flag |= O_DSYNC; | ||
| 1667 | |||
| 1681 | if (!acc_mode) | 1668 | if (!acc_mode) |
| 1682 | acc_mode = MAY_OPEN | ACC_MODE(flag); | 1669 | acc_mode = MAY_OPEN | ACC_MODE(flag); |
| 1683 | 1670 | ||
diff --git a/fs/namespace.c b/fs/namespace.c index bdc3cb4fd222..7d70d63ceb29 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
| @@ -1921,6 +1921,16 @@ long do_mount(char *dev_name, char *dir_name, char *type_page, | |||
| 1921 | if (data_page) | 1921 | if (data_page) |
| 1922 | ((char *)data_page)[PAGE_SIZE - 1] = 0; | 1922 | ((char *)data_page)[PAGE_SIZE - 1] = 0; |
| 1923 | 1923 | ||
| 1924 | /* ... and get the mountpoint */ | ||
| 1925 | retval = kern_path(dir_name, LOOKUP_FOLLOW, &path); | ||
| 1926 | if (retval) | ||
| 1927 | return retval; | ||
| 1928 | |||
| 1929 | retval = security_sb_mount(dev_name, &path, | ||
| 1930 | type_page, flags, data_page); | ||
| 1931 | if (retval) | ||
| 1932 | goto dput_out; | ||
| 1933 | |||
| 1924 | /* Default to relatime unless overriden */ | 1934 | /* Default to relatime unless overriden */ |
| 1925 | if (!(flags & MS_NOATIME)) | 1935 | if (!(flags & MS_NOATIME)) |
| 1926 | mnt_flags |= MNT_RELATIME; | 1936 | mnt_flags |= MNT_RELATIME; |
| @@ -1945,16 +1955,6 @@ long do_mount(char *dev_name, char *dir_name, char *type_page, | |||
| 1945 | MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT | | 1955 | MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT | |
| 1946 | MS_STRICTATIME); | 1956 | MS_STRICTATIME); |
| 1947 | 1957 | ||
| 1948 | /* ... and get the mountpoint */ | ||
| 1949 | retval = kern_path(dir_name, LOOKUP_FOLLOW, &path); | ||
| 1950 | if (retval) | ||
| 1951 | return retval; | ||
| 1952 | |||
| 1953 | retval = security_sb_mount(dev_name, &path, | ||
| 1954 | type_page, flags, data_page); | ||
| 1955 | if (retval) | ||
| 1956 | goto dput_out; | ||
| 1957 | |||
| 1958 | if (flags & MS_REMOUNT) | 1958 | if (flags & MS_REMOUNT) |
| 1959 | retval = do_remount(&path, flags & ~MS_REMOUNT, mnt_flags, | 1959 | retval = do_remount(&path, flags & ~MS_REMOUNT, mnt_flags, |
| 1960 | data_page); | 1960 | data_page); |
diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c index 0d58caf4a6e1..ec8f45f12e05 100644 --- a/fs/ncpfs/ioctl.c +++ b/fs/ncpfs/ioctl.c | |||
| @@ -835,7 +835,7 @@ static int ncp_ioctl_need_write(unsigned int cmd) | |||
| 835 | case NCP_IOC_SETROOT: | 835 | case NCP_IOC_SETROOT: |
| 836 | return 0; | 836 | return 0; |
| 837 | default: | 837 | default: |
| 838 | /* unkown IOCTL command, assume write */ | 838 | /* unknown IOCTL command, assume write */ |
| 839 | return 1; | 839 | return 1; |
| 840 | } | 840 | } |
| 841 | } | 841 | } |
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 293fa0528a6e..73ab220354df 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c | |||
| @@ -78,11 +78,6 @@ nfs4_callback_svc(void *vrqstp) | |||
| 78 | 78 | ||
| 79 | set_freezable(); | 79 | set_freezable(); |
| 80 | 80 | ||
| 81 | /* | ||
| 82 | * FIXME: do we really need to run this under the BKL? If so, please | ||
| 83 | * add a comment about what it's intended to protect. | ||
| 84 | */ | ||
| 85 | lock_kernel(); | ||
| 86 | while (!kthread_should_stop()) { | 81 | while (!kthread_should_stop()) { |
| 87 | /* | 82 | /* |
| 88 | * Listen for a request on the socket | 83 | * Listen for a request on the socket |
| @@ -104,7 +99,6 @@ nfs4_callback_svc(void *vrqstp) | |||
| 104 | preverr = err; | 99 | preverr = err; |
| 105 | svc_process(rqstp); | 100 | svc_process(rqstp); |
| 106 | } | 101 | } |
| 107 | unlock_kernel(); | ||
| 108 | return 0; | 102 | return 0; |
| 109 | } | 103 | } |
| 110 | 104 | ||
| @@ -160,11 +154,6 @@ nfs41_callback_svc(void *vrqstp) | |||
| 160 | 154 | ||
| 161 | set_freezable(); | 155 | set_freezable(); |
| 162 | 156 | ||
| 163 | /* | ||
| 164 | * FIXME: do we really need to run this under the BKL? If so, please | ||
| 165 | * add a comment about what it's intended to protect. | ||
| 166 | */ | ||
| 167 | lock_kernel(); | ||
| 168 | while (!kthread_should_stop()) { | 157 | while (!kthread_should_stop()) { |
| 169 | prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE); | 158 | prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE); |
| 170 | spin_lock_bh(&serv->sv_cb_lock); | 159 | spin_lock_bh(&serv->sv_cb_lock); |
| @@ -183,7 +172,6 @@ nfs41_callback_svc(void *vrqstp) | |||
| 183 | } | 172 | } |
| 184 | finish_wait(&serv->sv_cb_waitq, &wq); | 173 | finish_wait(&serv->sv_cb_waitq, &wq); |
| 185 | } | 174 | } |
| 186 | unlock_kernel(); | ||
| 187 | return 0; | 175 | return 0; |
| 188 | } | 176 | } |
| 189 | 177 | ||
| @@ -397,6 +385,7 @@ static int nfs_callback_authenticate(struct svc_rqst *rqstp) | |||
| 397 | */ | 385 | */ |
| 398 | static struct svc_version *nfs4_callback_version[] = { | 386 | static struct svc_version *nfs4_callback_version[] = { |
| 399 | [1] = &nfs4_callback_version1, | 387 | [1] = &nfs4_callback_version1, |
| 388 | [4] = &nfs4_callback_version4, | ||
| 400 | }; | 389 | }; |
| 401 | 390 | ||
| 402 | static struct svc_stat nfs4_callback_stats; | 391 | static struct svc_stat nfs4_callback_stats; |
diff --git a/fs/nfs/callback.h b/fs/nfs/callback.h index 07baa8254ca1..d4036be0b589 100644 --- a/fs/nfs/callback.h +++ b/fs/nfs/callback.h | |||
| @@ -106,6 +106,19 @@ struct cb_sequenceres { | |||
| 106 | extern unsigned nfs4_callback_sequence(struct cb_sequenceargs *args, | 106 | extern unsigned nfs4_callback_sequence(struct cb_sequenceargs *args, |
| 107 | struct cb_sequenceres *res); | 107 | struct cb_sequenceres *res); |
| 108 | 108 | ||
| 109 | extern int nfs41_validate_delegation_stateid(struct nfs_delegation *delegation, | ||
| 110 | const nfs4_stateid *stateid); | ||
| 111 | |||
| 112 | #define RCA4_TYPE_MASK_RDATA_DLG 0 | ||
| 113 | #define RCA4_TYPE_MASK_WDATA_DLG 1 | ||
| 114 | |||
| 115 | struct cb_recallanyargs { | ||
| 116 | struct sockaddr *craa_addr; | ||
| 117 | uint32_t craa_objs_to_keep; | ||
| 118 | uint32_t craa_type_mask; | ||
| 119 | }; | ||
| 120 | |||
| 121 | extern unsigned nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy); | ||
| 109 | #endif /* CONFIG_NFS_V4_1 */ | 122 | #endif /* CONFIG_NFS_V4_1 */ |
| 110 | 123 | ||
| 111 | extern __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *res); | 124 | extern __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *res); |
| @@ -114,8 +127,9 @@ extern __be32 nfs4_callback_recall(struct cb_recallargs *args, void *dummy); | |||
| 114 | #ifdef CONFIG_NFS_V4 | 127 | #ifdef CONFIG_NFS_V4 |
| 115 | extern int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt); | 128 | extern int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt); |
| 116 | extern void nfs_callback_down(int minorversion); | 129 | extern void nfs_callback_down(int minorversion); |
| 130 | extern int nfs4_validate_delegation_stateid(struct nfs_delegation *delegation, | ||
| 131 | const nfs4_stateid *stateid); | ||
| 117 | #endif /* CONFIG_NFS_V4 */ | 132 | #endif /* CONFIG_NFS_V4 */ |
| 118 | |||
| 119 | /* | 133 | /* |
| 120 | * nfs41: Callbacks are expected to not cause substantial latency, | 134 | * nfs41: Callbacks are expected to not cause substantial latency, |
| 121 | * so we limit their concurrency to 1 by setting up the maximum number | 135 | * so we limit their concurrency to 1 by setting up the maximum number |
diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c index b7da1f54da68..defa9b4c470e 100644 --- a/fs/nfs/callback_proc.c +++ b/fs/nfs/callback_proc.c | |||
| @@ -61,6 +61,16 @@ out: | |||
| 61 | return res->status; | 61 | return res->status; |
| 62 | } | 62 | } |
| 63 | 63 | ||
| 64 | static int (*nfs_validate_delegation_stateid(struct nfs_client *clp))(struct nfs_delegation *, const nfs4_stateid *) | ||
| 65 | { | ||
| 66 | #if defined(CONFIG_NFS_V4_1) | ||
| 67 | if (clp->cl_minorversion > 0) | ||
| 68 | return nfs41_validate_delegation_stateid; | ||
| 69 | #endif | ||
| 70 | return nfs4_validate_delegation_stateid; | ||
| 71 | } | ||
| 72 | |||
| 73 | |||
| 64 | __be32 nfs4_callback_recall(struct cb_recallargs *args, void *dummy) | 74 | __be32 nfs4_callback_recall(struct cb_recallargs *args, void *dummy) |
| 65 | { | 75 | { |
| 66 | struct nfs_client *clp; | 76 | struct nfs_client *clp; |
| @@ -81,7 +91,8 @@ __be32 nfs4_callback_recall(struct cb_recallargs *args, void *dummy) | |||
| 81 | inode = nfs_delegation_find_inode(clp, &args->fh); | 91 | inode = nfs_delegation_find_inode(clp, &args->fh); |
| 82 | if (inode != NULL) { | 92 | if (inode != NULL) { |
| 83 | /* Set up a helper thread to actually return the delegation */ | 93 | /* Set up a helper thread to actually return the delegation */ |
| 84 | switch(nfs_async_inode_return_delegation(inode, &args->stateid)) { | 94 | switch (nfs_async_inode_return_delegation(inode, &args->stateid, |
| 95 | nfs_validate_delegation_stateid(clp))) { | ||
| 85 | case 0: | 96 | case 0: |
| 86 | res = 0; | 97 | res = 0; |
| 87 | break; | 98 | break; |
| @@ -102,8 +113,31 @@ out: | |||
| 102 | return res; | 113 | return res; |
| 103 | } | 114 | } |
| 104 | 115 | ||
| 116 | int nfs4_validate_delegation_stateid(struct nfs_delegation *delegation, const nfs4_stateid *stateid) | ||
| 117 | { | ||
| 118 | if (delegation == NULL || memcmp(delegation->stateid.data, stateid->data, | ||
| 119 | sizeof(delegation->stateid.data)) != 0) | ||
| 120 | return 0; | ||
| 121 | return 1; | ||
| 122 | } | ||
| 123 | |||
| 105 | #if defined(CONFIG_NFS_V4_1) | 124 | #if defined(CONFIG_NFS_V4_1) |
| 106 | 125 | ||
| 126 | int nfs41_validate_delegation_stateid(struct nfs_delegation *delegation, const nfs4_stateid *stateid) | ||
| 127 | { | ||
| 128 | if (delegation == NULL) | ||
| 129 | return 0; | ||
| 130 | |||
| 131 | /* seqid is 4-bytes long */ | ||
| 132 | if (((u32 *) &stateid->data)[0] != 0) | ||
| 133 | return 0; | ||
| 134 | if (memcmp(&delegation->stateid.data[4], &stateid->data[4], | ||
| 135 | sizeof(stateid->data)-4)) | ||
| 136 | return 0; | ||
| 137 | |||
| 138 | return 1; | ||
| 139 | } | ||
| 140 | |||
| 107 | /* | 141 | /* |
| 108 | * Validate the sequenceID sent by the server. | 142 | * Validate the sequenceID sent by the server. |
| 109 | * Return success if the sequenceID is one more than what we last saw on | 143 | * Return success if the sequenceID is one more than what we last saw on |
| @@ -227,4 +261,32 @@ out: | |||
| 227 | return res->csr_status; | 261 | return res->csr_status; |
| 228 | } | 262 | } |
| 229 | 263 | ||
| 264 | unsigned nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy) | ||
| 265 | { | ||
| 266 | struct nfs_client *clp; | ||
| 267 | int status; | ||
| 268 | fmode_t flags = 0; | ||
| 269 | |||
| 270 | status = htonl(NFS4ERR_OP_NOT_IN_SESSION); | ||
| 271 | clp = nfs_find_client(args->craa_addr, 4); | ||
| 272 | if (clp == NULL) | ||
| 273 | goto out; | ||
| 274 | |||
| 275 | dprintk("NFS: RECALL_ANY callback request from %s\n", | ||
| 276 | rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_ADDR)); | ||
| 277 | |||
| 278 | if (test_bit(RCA4_TYPE_MASK_RDATA_DLG, (const unsigned long *) | ||
| 279 | &args->craa_type_mask)) | ||
| 280 | flags = FMODE_READ; | ||
| 281 | if (test_bit(RCA4_TYPE_MASK_WDATA_DLG, (const unsigned long *) | ||
| 282 | &args->craa_type_mask)) | ||
| 283 | flags |= FMODE_WRITE; | ||
| 284 | |||
| 285 | if (flags) | ||
| 286 | nfs_expire_all_delegation_types(clp, flags); | ||
| 287 | status = htonl(NFS4_OK); | ||
| 288 | out: | ||
| 289 | dprintk("%s: exit with status = %d\n", __func__, ntohl(status)); | ||
| 290 | return status; | ||
| 291 | } | ||
| 230 | #endif /* CONFIG_NFS_V4_1 */ | 292 | #endif /* CONFIG_NFS_V4_1 */ |
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c index 76b0aa0f73bf..8e1a2511c8be 100644 --- a/fs/nfs/callback_xdr.c +++ b/fs/nfs/callback_xdr.c | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | #if defined(CONFIG_NFS_V4_1) | 23 | #if defined(CONFIG_NFS_V4_1) |
| 24 | #define CB_OP_SEQUENCE_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ + \ | 24 | #define CB_OP_SEQUENCE_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ + \ |
| 25 | 4 + 1 + 3) | 25 | 4 + 1 + 3) |
| 26 | #define CB_OP_RECALLANY_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ) | ||
| 26 | #endif /* CONFIG_NFS_V4_1 */ | 27 | #endif /* CONFIG_NFS_V4_1 */ |
| 27 | 28 | ||
| 28 | #define NFSDBG_FACILITY NFSDBG_CALLBACK | 29 | #define NFSDBG_FACILITY NFSDBG_CALLBACK |
| @@ -326,6 +327,25 @@ out_free: | |||
| 326 | goto out; | 327 | goto out; |
| 327 | } | 328 | } |
| 328 | 329 | ||
| 330 | static unsigned decode_recallany_args(struct svc_rqst *rqstp, | ||
| 331 | struct xdr_stream *xdr, | ||
| 332 | struct cb_recallanyargs *args) | ||
| 333 | { | ||
| 334 | uint32_t *p; | ||
| 335 | |||
| 336 | args->craa_addr = svc_addr(rqstp); | ||
| 337 | p = read_buf(xdr, 4); | ||
| 338 | if (unlikely(p == NULL)) | ||
| 339 | return htonl(NFS4ERR_BADXDR); | ||
| 340 | args->craa_objs_to_keep = ntohl(*p++); | ||
| 341 | p = read_buf(xdr, 4); | ||
| 342 | if (unlikely(p == NULL)) | ||
| 343 | return htonl(NFS4ERR_BADXDR); | ||
| 344 | args->craa_type_mask = ntohl(*p); | ||
| 345 | |||
| 346 | return 0; | ||
| 347 | } | ||
| 348 | |||
| 329 | #endif /* CONFIG_NFS_V4_1 */ | 349 | #endif /* CONFIG_NFS_V4_1 */ |
| 330 | 350 | ||
| 331 | static __be32 encode_string(struct xdr_stream *xdr, unsigned int len, const char *str) | 351 | static __be32 encode_string(struct xdr_stream *xdr, unsigned int len, const char *str) |
| @@ -533,6 +553,7 @@ preprocess_nfs41_op(int nop, unsigned int op_nr, struct callback_op **op) | |||
| 533 | case OP_CB_GETATTR: | 553 | case OP_CB_GETATTR: |
| 534 | case OP_CB_RECALL: | 554 | case OP_CB_RECALL: |
| 535 | case OP_CB_SEQUENCE: | 555 | case OP_CB_SEQUENCE: |
| 556 | case OP_CB_RECALL_ANY: | ||
| 536 | *op = &callback_ops[op_nr]; | 557 | *op = &callback_ops[op_nr]; |
| 537 | break; | 558 | break; |
| 538 | 559 | ||
| @@ -540,7 +561,6 @@ preprocess_nfs41_op(int nop, unsigned int op_nr, struct callback_op **op) | |||
| 540 | case OP_CB_NOTIFY_DEVICEID: | 561 | case OP_CB_NOTIFY_DEVICEID: |
| 541 | case OP_CB_NOTIFY: | 562 | case OP_CB_NOTIFY: |
| 542 | case OP_CB_PUSH_DELEG: | 563 | case OP_CB_PUSH_DELEG: |
| 543 | case OP_CB_RECALL_ANY: | ||
| 544 | case OP_CB_RECALLABLE_OBJ_AVAIL: | 564 | case OP_CB_RECALLABLE_OBJ_AVAIL: |
| 545 | case OP_CB_RECALL_SLOT: | 565 | case OP_CB_RECALL_SLOT: |
| 546 | case OP_CB_WANTS_CANCELLED: | 566 | case OP_CB_WANTS_CANCELLED: |
| @@ -688,6 +708,11 @@ static struct callback_op callback_ops[] = { | |||
| 688 | .encode_res = (callback_encode_res_t)encode_cb_sequence_res, | 708 | .encode_res = (callback_encode_res_t)encode_cb_sequence_res, |
| 689 | .res_maxsize = CB_OP_SEQUENCE_RES_MAXSZ, | 709 | .res_maxsize = CB_OP_SEQUENCE_RES_MAXSZ, |
| 690 | }, | 710 | }, |
| 711 | [OP_CB_RECALL_ANY] = { | ||
| 712 | .process_op = (callback_process_op_t)nfs4_callback_recallany, | ||
| 713 | .decode_args = (callback_decode_arg_t)decode_recallany_args, | ||
| 714 | .res_maxsize = CB_OP_RECALLANY_RES_MAXSZ, | ||
| 715 | }, | ||
| 691 | #endif /* CONFIG_NFS_V4_1 */ | 716 | #endif /* CONFIG_NFS_V4_1 */ |
| 692 | }; | 717 | }; |
| 693 | 718 | ||
| @@ -718,3 +743,10 @@ struct svc_version nfs4_callback_version1 = { | |||
| 718 | .vs_dispatch = NULL, | 743 | .vs_dispatch = NULL, |
| 719 | }; | 744 | }; |
| 720 | 745 | ||
| 746 | struct svc_version nfs4_callback_version4 = { | ||
| 747 | .vs_vers = 4, | ||
| 748 | .vs_nproc = ARRAY_SIZE(nfs4_callback_procedures1), | ||
| 749 | .vs_proc = nfs4_callback_procedures1, | ||
| 750 | .vs_xdrsize = NFS4_CALLBACK_XDRSIZE, | ||
| 751 | .vs_dispatch = NULL, | ||
| 752 | }; | ||
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 99ea196f071f..ee77713ce68b 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c | |||
| @@ -1260,10 +1260,20 @@ error: | |||
| 1260 | static void nfs4_session_set_rwsize(struct nfs_server *server) | 1260 | static void nfs4_session_set_rwsize(struct nfs_server *server) |
| 1261 | { | 1261 | { |
| 1262 | #ifdef CONFIG_NFS_V4_1 | 1262 | #ifdef CONFIG_NFS_V4_1 |
| 1263 | struct nfs4_session *sess; | ||
| 1264 | u32 server_resp_sz; | ||
| 1265 | u32 server_rqst_sz; | ||
| 1266 | |||
| 1263 | if (!nfs4_has_session(server->nfs_client)) | 1267 | if (!nfs4_has_session(server->nfs_client)) |
| 1264 | return; | 1268 | return; |
| 1265 | server->rsize = server->nfs_client->cl_session->fc_attrs.max_resp_sz; | 1269 | sess = server->nfs_client->cl_session; |
| 1266 | server->wsize = server->nfs_client->cl_session->fc_attrs.max_rqst_sz; | 1270 | server_resp_sz = sess->fc_attrs.max_resp_sz - nfs41_maxread_overhead; |
| 1271 | server_rqst_sz = sess->fc_attrs.max_rqst_sz - nfs41_maxwrite_overhead; | ||
| 1272 | |||
| 1273 | if (server->rsize > server_resp_sz) | ||
| 1274 | server->rsize = server_resp_sz; | ||
| 1275 | if (server->wsize > server_rqst_sz) | ||
| 1276 | server->wsize = server_rqst_sz; | ||
| 1267 | #endif /* CONFIG_NFS_V4_1 */ | 1277 | #endif /* CONFIG_NFS_V4_1 */ |
| 1268 | } | 1278 | } |
| 1269 | 1279 | ||
diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index 6dd48a4405b4..2563bebc4c67 100644 --- a/fs/nfs/delegation.c +++ b/fs/nfs/delegation.c | |||
| @@ -92,7 +92,7 @@ out: | |||
| 92 | return status; | 92 | return status; |
| 93 | } | 93 | } |
| 94 | 94 | ||
| 95 | static void nfs_delegation_claim_opens(struct inode *inode, const nfs4_stateid *stateid) | 95 | static int nfs_delegation_claim_opens(struct inode *inode, const nfs4_stateid *stateid) |
| 96 | { | 96 | { |
| 97 | struct nfs_inode *nfsi = NFS_I(inode); | 97 | struct nfs_inode *nfsi = NFS_I(inode); |
| 98 | struct nfs_open_context *ctx; | 98 | struct nfs_open_context *ctx; |
| @@ -116,10 +116,11 @@ again: | |||
| 116 | err = nfs_delegation_claim_locks(ctx, state); | 116 | err = nfs_delegation_claim_locks(ctx, state); |
| 117 | put_nfs_open_context(ctx); | 117 | put_nfs_open_context(ctx); |
| 118 | if (err != 0) | 118 | if (err != 0) |
| 119 | return; | 119 | return err; |
| 120 | goto again; | 120 | goto again; |
| 121 | } | 121 | } |
| 122 | spin_unlock(&inode->i_lock); | 122 | spin_unlock(&inode->i_lock); |
| 123 | return 0; | ||
| 123 | } | 124 | } |
| 124 | 125 | ||
| 125 | /* | 126 | /* |
| @@ -261,30 +262,34 @@ static void nfs_msync_inode(struct inode *inode) | |||
| 261 | /* | 262 | /* |
| 262 | * Basic procedure for returning a delegation to the server | 263 | * Basic procedure for returning a delegation to the server |
| 263 | */ | 264 | */ |
| 264 | static int __nfs_inode_return_delegation(struct inode *inode, struct nfs_delegation *delegation) | 265 | static int __nfs_inode_return_delegation(struct inode *inode, struct nfs_delegation *delegation, int issync) |
| 265 | { | 266 | { |
| 266 | struct nfs_inode *nfsi = NFS_I(inode); | 267 | struct nfs_inode *nfsi = NFS_I(inode); |
| 268 | int err; | ||
| 267 | 269 | ||
| 268 | nfs_msync_inode(inode); | ||
| 269 | /* | 270 | /* |
| 270 | * Guard against new delegated open/lock/unlock calls and against | 271 | * Guard against new delegated open/lock/unlock calls and against |
| 271 | * state recovery | 272 | * state recovery |
| 272 | */ | 273 | */ |
| 273 | down_write(&nfsi->rwsem); | 274 | down_write(&nfsi->rwsem); |
| 274 | nfs_delegation_claim_opens(inode, &delegation->stateid); | 275 | err = nfs_delegation_claim_opens(inode, &delegation->stateid); |
| 275 | up_write(&nfsi->rwsem); | 276 | up_write(&nfsi->rwsem); |
| 276 | nfs_msync_inode(inode); | 277 | if (err) |
| 278 | goto out; | ||
| 277 | 279 | ||
| 278 | return nfs_do_return_delegation(inode, delegation, 1); | 280 | err = nfs_do_return_delegation(inode, delegation, issync); |
| 281 | out: | ||
| 282 | return err; | ||
| 279 | } | 283 | } |
| 280 | 284 | ||
| 281 | /* | 285 | /* |
| 282 | * Return all delegations that have been marked for return | 286 | * Return all delegations that have been marked for return |
| 283 | */ | 287 | */ |
| 284 | void nfs_client_return_marked_delegations(struct nfs_client *clp) | 288 | int nfs_client_return_marked_delegations(struct nfs_client *clp) |
| 285 | { | 289 | { |
| 286 | struct nfs_delegation *delegation; | 290 | struct nfs_delegation *delegation; |
| 287 | struct inode *inode; | 291 | struct inode *inode; |
| 292 | int err = 0; | ||
| 288 | 293 | ||
| 289 | restart: | 294 | restart: |
| 290 | rcu_read_lock(); | 295 | rcu_read_lock(); |
| @@ -298,12 +303,18 @@ restart: | |||
| 298 | delegation = nfs_detach_delegation_locked(NFS_I(inode), NULL); | 303 | delegation = nfs_detach_delegation_locked(NFS_I(inode), NULL); |
| 299 | spin_unlock(&clp->cl_lock); | 304 | spin_unlock(&clp->cl_lock); |
| 300 | rcu_read_unlock(); | 305 | rcu_read_unlock(); |
| 301 | if (delegation != NULL) | 306 | if (delegation != NULL) { |
| 302 | __nfs_inode_return_delegation(inode, delegation); | 307 | filemap_flush(inode->i_mapping); |
| 308 | err = __nfs_inode_return_delegation(inode, delegation, 0); | ||
| 309 | } | ||
| 303 | iput(inode); | 310 | iput(inode); |
| 304 | goto restart; | 311 | if (!err) |
| 312 | goto restart; | ||
| 313 | set_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state); | ||
| 314 | return err; | ||
| 305 | } | 315 | } |
| 306 | rcu_read_unlock(); | 316 | rcu_read_unlock(); |
| 317 | return 0; | ||
| 307 | } | 318 | } |
| 308 | 319 | ||
| 309 | /* | 320 | /* |
| @@ -338,8 +349,10 @@ int nfs_inode_return_delegation(struct inode *inode) | |||
| 338 | spin_lock(&clp->cl_lock); | 349 | spin_lock(&clp->cl_lock); |
| 339 | delegation = nfs_detach_delegation_locked(nfsi, NULL); | 350 | delegation = nfs_detach_delegation_locked(nfsi, NULL); |
| 340 | spin_unlock(&clp->cl_lock); | 351 | spin_unlock(&clp->cl_lock); |
| 341 | if (delegation != NULL) | 352 | if (delegation != NULL) { |
| 342 | err = __nfs_inode_return_delegation(inode, delegation); | 353 | nfs_msync_inode(inode); |
| 354 | err = __nfs_inode_return_delegation(inode, delegation, 1); | ||
| 355 | } | ||
| 343 | } | 356 | } |
| 344 | return err; | 357 | return err; |
| 345 | } | 358 | } |
| @@ -368,33 +381,47 @@ void nfs_super_return_all_delegations(struct super_block *sb) | |||
| 368 | spin_unlock(&delegation->lock); | 381 | spin_unlock(&delegation->lock); |
| 369 | } | 382 | } |
| 370 | rcu_read_unlock(); | 383 | rcu_read_unlock(); |
| 371 | nfs_client_return_marked_delegations(clp); | 384 | if (nfs_client_return_marked_delegations(clp) != 0) |
| 385 | nfs4_schedule_state_manager(clp); | ||
| 372 | } | 386 | } |
| 373 | 387 | ||
| 374 | static void nfs_client_mark_return_all_delegations(struct nfs_client *clp) | 388 | static |
| 389 | void nfs_client_mark_return_all_delegation_types(struct nfs_client *clp, fmode_t flags) | ||
| 375 | { | 390 | { |
| 376 | struct nfs_delegation *delegation; | 391 | struct nfs_delegation *delegation; |
| 377 | 392 | ||
| 378 | rcu_read_lock(); | 393 | rcu_read_lock(); |
| 379 | list_for_each_entry_rcu(delegation, &clp->cl_delegations, super_list) { | 394 | list_for_each_entry_rcu(delegation, &clp->cl_delegations, super_list) { |
| 380 | set_bit(NFS_DELEGATION_RETURN, &delegation->flags); | 395 | if ((delegation->type == (FMODE_READ|FMODE_WRITE)) && !(flags & FMODE_WRITE)) |
| 381 | set_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state); | 396 | continue; |
| 397 | if (delegation->type & flags) | ||
| 398 | nfs_mark_return_delegation(clp, delegation); | ||
| 382 | } | 399 | } |
| 383 | rcu_read_unlock(); | 400 | rcu_read_unlock(); |
| 384 | } | 401 | } |
| 385 | 402 | ||
| 403 | static void nfs_client_mark_return_all_delegations(struct nfs_client *clp) | ||
| 404 | { | ||
| 405 | nfs_client_mark_return_all_delegation_types(clp, FMODE_READ|FMODE_WRITE); | ||
| 406 | } | ||
| 407 | |||
| 386 | static void nfs_delegation_run_state_manager(struct nfs_client *clp) | 408 | static void nfs_delegation_run_state_manager(struct nfs_client *clp) |
| 387 | { | 409 | { |
| 388 | if (test_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state)) | 410 | if (test_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state)) |
| 389 | nfs4_schedule_state_manager(clp); | 411 | nfs4_schedule_state_manager(clp); |
| 390 | } | 412 | } |
| 391 | 413 | ||
| 392 | void nfs_expire_all_delegations(struct nfs_client *clp) | 414 | void nfs_expire_all_delegation_types(struct nfs_client *clp, fmode_t flags) |
| 393 | { | 415 | { |
| 394 | nfs_client_mark_return_all_delegations(clp); | 416 | nfs_client_mark_return_all_delegation_types(clp, flags); |
| 395 | nfs_delegation_run_state_manager(clp); | 417 | nfs_delegation_run_state_manager(clp); |
| 396 | } | 418 | } |
| 397 | 419 | ||
| 420 | void nfs_expire_all_delegations(struct nfs_client *clp) | ||
| 421 | { | ||
| 422 | nfs_expire_all_delegation_types(clp, FMODE_READ|FMODE_WRITE); | ||
| 423 | } | ||
| 424 | |||
| 398 | /* | 425 | /* |
| 399 | * Return all delegations following an NFS4ERR_CB_PATH_DOWN error. | 426 | * Return all delegations following an NFS4ERR_CB_PATH_DOWN error. |
| 400 | */ | 427 | */ |
| @@ -413,8 +440,7 @@ static void nfs_client_mark_return_unreferenced_delegations(struct nfs_client *c | |||
| 413 | list_for_each_entry_rcu(delegation, &clp->cl_delegations, super_list) { | 440 | list_for_each_entry_rcu(delegation, &clp->cl_delegations, super_list) { |
| 414 | if (test_and_clear_bit(NFS_DELEGATION_REFERENCED, &delegation->flags)) | 441 | if (test_and_clear_bit(NFS_DELEGATION_REFERENCED, &delegation->flags)) |
| 415 | continue; | 442 | continue; |
| 416 | set_bit(NFS_DELEGATION_RETURN, &delegation->flags); | 443 | nfs_mark_return_delegation(clp, delegation); |
| 417 | set_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state); | ||
| 418 | } | 444 | } |
| 419 | rcu_read_unlock(); | 445 | rcu_read_unlock(); |
| 420 | } | 446 | } |
| @@ -428,18 +454,21 @@ void nfs_expire_unreferenced_delegations(struct nfs_client *clp) | |||
| 428 | /* | 454 | /* |
| 429 | * Asynchronous delegation recall! | 455 | * Asynchronous delegation recall! |
| 430 | */ | 456 | */ |
| 431 | int nfs_async_inode_return_delegation(struct inode *inode, const nfs4_stateid *stateid) | 457 | int nfs_async_inode_return_delegation(struct inode *inode, const nfs4_stateid *stateid, |
| 458 | int (*validate_stateid)(struct nfs_delegation *delegation, | ||
| 459 | const nfs4_stateid *stateid)) | ||
| 432 | { | 460 | { |
| 433 | struct nfs_client *clp = NFS_SERVER(inode)->nfs_client; | 461 | struct nfs_client *clp = NFS_SERVER(inode)->nfs_client; |
| 434 | struct nfs_delegation *delegation; | 462 | struct nfs_delegation *delegation; |
| 435 | 463 | ||
| 436 | rcu_read_lock(); | 464 | rcu_read_lock(); |
| 437 | delegation = rcu_dereference(NFS_I(inode)->delegation); | 465 | delegation = rcu_dereference(NFS_I(inode)->delegation); |
| 438 | if (delegation == NULL || memcmp(delegation->stateid.data, stateid->data, | 466 | |
| 439 | sizeof(delegation->stateid.data)) != 0) { | 467 | if (!validate_stateid(delegation, stateid)) { |
| 440 | rcu_read_unlock(); | 468 | rcu_read_unlock(); |
| 441 | return -ENOENT; | 469 | return -ENOENT; |
| 442 | } | 470 | } |
| 471 | |||
| 443 | nfs_mark_return_delegation(clp, delegation); | 472 | nfs_mark_return_delegation(clp, delegation); |
| 444 | rcu_read_unlock(); | 473 | rcu_read_unlock(); |
| 445 | nfs_delegation_run_state_manager(clp); | 474 | nfs_delegation_run_state_manager(clp); |
diff --git a/fs/nfs/delegation.h b/fs/nfs/delegation.h index 09f383795174..944b627ec6e1 100644 --- a/fs/nfs/delegation.h +++ b/fs/nfs/delegation.h | |||
| @@ -34,15 +34,18 @@ enum { | |||
| 34 | int nfs_inode_set_delegation(struct inode *inode, struct rpc_cred *cred, struct nfs_openres *res); | 34 | int nfs_inode_set_delegation(struct inode *inode, struct rpc_cred *cred, struct nfs_openres *res); |
| 35 | void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred, struct nfs_openres *res); | 35 | void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred, struct nfs_openres *res); |
| 36 | int nfs_inode_return_delegation(struct inode *inode); | 36 | int nfs_inode_return_delegation(struct inode *inode); |
| 37 | int nfs_async_inode_return_delegation(struct inode *inode, const nfs4_stateid *stateid); | 37 | int nfs_async_inode_return_delegation(struct inode *inode, const nfs4_stateid *stateid, |
| 38 | int (*validate_stateid)(struct nfs_delegation *delegation, | ||
| 39 | const nfs4_stateid *stateid)); | ||
| 38 | void nfs_inode_return_delegation_noreclaim(struct inode *inode); | 40 | void nfs_inode_return_delegation_noreclaim(struct inode *inode); |
| 39 | 41 | ||
| 40 | struct inode *nfs_delegation_find_inode(struct nfs_client *clp, const struct nfs_fh *fhandle); | 42 | struct inode *nfs_delegation_find_inode(struct nfs_client *clp, const struct nfs_fh *fhandle); |
| 41 | void nfs_super_return_all_delegations(struct super_block *sb); | 43 | void nfs_super_return_all_delegations(struct super_block *sb); |
| 42 | void nfs_expire_all_delegations(struct nfs_client *clp); | 44 | void nfs_expire_all_delegations(struct nfs_client *clp); |
| 45 | void nfs_expire_all_delegation_types(struct nfs_client *clp, fmode_t flags); | ||
| 43 | void nfs_expire_unreferenced_delegations(struct nfs_client *clp); | 46 | void nfs_expire_unreferenced_delegations(struct nfs_client *clp); |
| 44 | void nfs_handle_cb_pathdown(struct nfs_client *clp); | 47 | void nfs_handle_cb_pathdown(struct nfs_client *clp); |
| 45 | void nfs_client_return_marked_delegations(struct nfs_client *clp); | 48 | int nfs_client_return_marked_delegations(struct nfs_client *clp); |
| 46 | 49 | ||
| 47 | void nfs_delegation_mark_reclaim(struct nfs_client *clp); | 50 | void nfs_delegation_mark_reclaim(struct nfs_client *clp); |
| 48 | void nfs_delegation_reap_unclaimed(struct nfs_client *clp); | 51 | void nfs_delegation_reap_unclaimed(struct nfs_client *clp); |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 7cb298525eef..2c5ace4f00a7 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
| @@ -1579,55 +1579,46 @@ static int nfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
| 1579 | struct dentry *dentry = NULL, *rehash = NULL; | 1579 | struct dentry *dentry = NULL, *rehash = NULL; |
| 1580 | int error = -EBUSY; | 1580 | int error = -EBUSY; |
| 1581 | 1581 | ||
| 1582 | /* | ||
| 1583 | * To prevent any new references to the target during the rename, | ||
| 1584 | * we unhash the dentry and free the inode in advance. | ||
| 1585 | */ | ||
| 1586 | if (!d_unhashed(new_dentry)) { | ||
| 1587 | d_drop(new_dentry); | ||
| 1588 | rehash = new_dentry; | ||
| 1589 | } | ||
| 1590 | |||
| 1591 | dfprintk(VFS, "NFS: rename(%s/%s -> %s/%s, ct=%d)\n", | 1582 | dfprintk(VFS, "NFS: rename(%s/%s -> %s/%s, ct=%d)\n", |
| 1592 | old_dentry->d_parent->d_name.name, old_dentry->d_name.name, | 1583 | old_dentry->d_parent->d_name.name, old_dentry->d_name.name, |
| 1593 | new_dentry->d_parent->d_name.name, new_dentry->d_name.name, | 1584 | new_dentry->d_parent->d_name.name, new_dentry->d_name.name, |
| 1594 | atomic_read(&new_dentry->d_count)); | 1585 | atomic_read(&new_dentry->d_count)); |
| 1595 | 1586 | ||
| 1596 | /* | 1587 | /* |
| 1597 | * First check whether the target is busy ... we can't | 1588 | * For non-directories, check whether the target is busy and if so, |
| 1598 | * safely do _any_ rename if the target is in use. | 1589 | * make a copy of the dentry and then do a silly-rename. If the |
| 1599 | * | 1590 | * silly-rename succeeds, the copied dentry is hashed and becomes |
| 1600 | * For files, make a copy of the dentry and then do a | 1591 | * the new target. |
| 1601 | * silly-rename. If the silly-rename succeeds, the | ||
| 1602 | * copied dentry is hashed and becomes the new target. | ||
| 1603 | */ | 1592 | */ |
| 1604 | if (!new_inode) | 1593 | if (new_inode && !S_ISDIR(new_inode->i_mode)) { |
| 1605 | goto go_ahead; | 1594 | /* |
| 1606 | if (S_ISDIR(new_inode->i_mode)) { | 1595 | * To prevent any new references to the target during the |
| 1607 | error = -EISDIR; | 1596 | * rename, we unhash the dentry in advance. |
| 1608 | if (!S_ISDIR(old_inode->i_mode)) | 1597 | */ |
| 1609 | goto out; | 1598 | if (!d_unhashed(new_dentry)) { |
| 1610 | } else if (atomic_read(&new_dentry->d_count) > 2) { | 1599 | d_drop(new_dentry); |
| 1611 | int err; | 1600 | rehash = new_dentry; |
| 1612 | /* copy the target dentry's name */ | 1601 | } |
| 1613 | dentry = d_alloc(new_dentry->d_parent, | 1602 | |
| 1614 | &new_dentry->d_name); | 1603 | if (atomic_read(&new_dentry->d_count) > 2) { |
| 1615 | if (!dentry) | 1604 | int err; |
| 1616 | goto out; | 1605 | |
| 1606 | /* copy the target dentry's name */ | ||
| 1607 | dentry = d_alloc(new_dentry->d_parent, | ||
| 1608 | &new_dentry->d_name); | ||
| 1609 | if (!dentry) | ||
| 1610 | goto out; | ||
| 1617 | 1611 | ||
| 1618 | /* silly-rename the existing target ... */ | 1612 | /* silly-rename the existing target ... */ |
| 1619 | err = nfs_sillyrename(new_dir, new_dentry); | 1613 | err = nfs_sillyrename(new_dir, new_dentry); |
| 1620 | if (!err) { | 1614 | if (err) |
| 1621 | new_dentry = rehash = dentry; | 1615 | goto out; |
| 1616 | |||
| 1617 | new_dentry = dentry; | ||
| 1622 | new_inode = NULL; | 1618 | new_inode = NULL; |
| 1623 | /* instantiate the replacement target */ | 1619 | } |
| 1624 | d_instantiate(new_dentry, NULL); | ||
| 1625 | } else if (atomic_read(&new_dentry->d_count) > 1) | ||
| 1626 | /* dentry still busy? */ | ||
| 1627 | goto out; | ||
| 1628 | } | 1620 | } |
| 1629 | 1621 | ||
| 1630 | go_ahead: | ||
| 1631 | /* | 1622 | /* |
| 1632 | * ... prune child dentries and writebacks if needed. | 1623 | * ... prune child dentries and writebacks if needed. |
| 1633 | */ | 1624 | */ |
diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c index f4d54ba97cc6..95e1ca765d47 100644 --- a/fs/nfs/dns_resolve.c +++ b/fs/nfs/dns_resolve.c | |||
| @@ -146,7 +146,7 @@ static int nfs_dns_show(struct seq_file *m, struct cache_detail *cd, | |||
| 146 | return 0; | 146 | return 0; |
| 147 | } | 147 | } |
| 148 | 148 | ||
| 149 | struct nfs_dns_ent *nfs_dns_lookup(struct cache_detail *cd, | 149 | static struct nfs_dns_ent *nfs_dns_lookup(struct cache_detail *cd, |
| 150 | struct nfs_dns_ent *key) | 150 | struct nfs_dns_ent *key) |
| 151 | { | 151 | { |
| 152 | struct cache_head *ch; | 152 | struct cache_head *ch; |
| @@ -159,7 +159,7 @@ struct nfs_dns_ent *nfs_dns_lookup(struct cache_detail *cd, | |||
| 159 | return container_of(ch, struct nfs_dns_ent, h); | 159 | return container_of(ch, struct nfs_dns_ent, h); |
| 160 | } | 160 | } |
| 161 | 161 | ||
| 162 | struct nfs_dns_ent *nfs_dns_update(struct cache_detail *cd, | 162 | static struct nfs_dns_ent *nfs_dns_update(struct cache_detail *cd, |
| 163 | struct nfs_dns_ent *new, | 163 | struct nfs_dns_ent *new, |
| 164 | struct nfs_dns_ent *key) | 164 | struct nfs_dns_ent *key) |
| 165 | { | 165 | { |
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index f5fdd39e037a..6b891328f332 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
| @@ -581,7 +581,7 @@ static int nfs_need_sync_write(struct file *filp, struct inode *inode) | |||
| 581 | { | 581 | { |
| 582 | struct nfs_open_context *ctx; | 582 | struct nfs_open_context *ctx; |
| 583 | 583 | ||
| 584 | if (IS_SYNC(inode) || (filp->f_flags & O_SYNC)) | 584 | if (IS_SYNC(inode) || (filp->f_flags & O_DSYNC)) |
| 585 | return 1; | 585 | return 1; |
| 586 | ctx = nfs_file_open_context(filp); | 586 | ctx = nfs_file_open_context(filp); |
| 587 | if (test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags)) | 587 | if (test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags)) |
| @@ -622,7 +622,7 @@ static ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
| 622 | 622 | ||
| 623 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, count); | 623 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, count); |
| 624 | result = generic_file_aio_write(iocb, iov, nr_segs, pos); | 624 | result = generic_file_aio_write(iocb, iov, nr_segs, pos); |
| 625 | /* Return error values for O_SYNC and IS_SYNC() */ | 625 | /* Return error values for O_DSYNC and IS_SYNC() */ |
| 626 | if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { | 626 | if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { |
| 627 | int err = nfs_do_fsync(nfs_file_open_context(iocb->ki_filp), inode); | 627 | int err = nfs_do_fsync(nfs_file_open_context(iocb->ki_filp), inode); |
| 628 | if (err < 0) | 628 | if (err < 0) |
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index e21b1bb9972f..29e464d23b32 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h | |||
| @@ -30,6 +30,15 @@ static inline int nfs4_has_session(const struct nfs_client *clp) | |||
| 30 | return 0; | 30 | return 0; |
| 31 | } | 31 | } |
| 32 | 32 | ||
| 33 | static inline int nfs4_has_persistent_session(const struct nfs_client *clp) | ||
| 34 | { | ||
| 35 | #ifdef CONFIG_NFS_V4_1 | ||
| 36 | if (nfs4_has_session(clp)) | ||
| 37 | return (clp->cl_session->flags & SESSION4_PERSIST); | ||
| 38 | #endif /* CONFIG_NFS_V4_1 */ | ||
| 39 | return 0; | ||
| 40 | } | ||
| 41 | |||
| 33 | struct nfs_clone_mount { | 42 | struct nfs_clone_mount { |
| 34 | const struct super_block *sb; | 43 | const struct super_block *sb; |
| 35 | const struct dentry *dentry; | 44 | const struct dentry *dentry; |
| @@ -156,6 +165,7 @@ struct vfsmount *nfs_do_refmount(const struct vfsmount *mnt_parent, struct dentr | |||
| 156 | 165 | ||
| 157 | /* callback_xdr.c */ | 166 | /* callback_xdr.c */ |
| 158 | extern struct svc_version nfs4_callback_version1; | 167 | extern struct svc_version nfs4_callback_version1; |
| 168 | extern struct svc_version nfs4_callback_version4; | ||
| 159 | 169 | ||
| 160 | /* pagelist.c */ | 170 | /* pagelist.c */ |
| 161 | extern int __init nfs_init_nfspagecache(void); | 171 | extern int __init nfs_init_nfspagecache(void); |
| @@ -177,24 +187,14 @@ extern __be32 * nfs_decode_dirent(__be32 *, struct nfs_entry *, int); | |||
| 177 | extern struct rpc_procinfo nfs3_procedures[]; | 187 | extern struct rpc_procinfo nfs3_procedures[]; |
| 178 | extern __be32 *nfs3_decode_dirent(__be32 *, struct nfs_entry *, int); | 188 | extern __be32 *nfs3_decode_dirent(__be32 *, struct nfs_entry *, int); |
| 179 | 189 | ||
| 180 | /* nfs4proc.c */ | ||
| 181 | static inline void nfs4_restart_rpc(struct rpc_task *task, | ||
| 182 | const struct nfs_client *clp) | ||
| 183 | { | ||
| 184 | #ifdef CONFIG_NFS_V4_1 | ||
| 185 | if (nfs4_has_session(clp) && | ||
| 186 | test_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state)) { | ||
| 187 | rpc_restart_call_prepare(task); | ||
| 188 | return; | ||
| 189 | } | ||
| 190 | #endif /* CONFIG_NFS_V4_1 */ | ||
| 191 | rpc_restart_call(task); | ||
| 192 | } | ||
| 193 | |||
| 194 | /* nfs4xdr.c */ | 190 | /* nfs4xdr.c */ |
| 195 | #ifdef CONFIG_NFS_V4 | 191 | #ifdef CONFIG_NFS_V4 |
| 196 | extern __be32 *nfs4_decode_dirent(__be32 *p, struct nfs_entry *entry, int plus); | 192 | extern __be32 *nfs4_decode_dirent(__be32 *p, struct nfs_entry *entry, int plus); |
| 197 | #endif | 193 | #endif |
| 194 | #ifdef CONFIG_NFS_V4_1 | ||
| 195 | extern const u32 nfs41_maxread_overhead; | ||
| 196 | extern const u32 nfs41_maxwrite_overhead; | ||
| 197 | #endif | ||
| 198 | 198 | ||
| 199 | /* nfs4proc.c */ | 199 | /* nfs4proc.c */ |
| 200 | #ifdef CONFIG_NFS_V4 | 200 | #ifdef CONFIG_NFS_V4 |
| @@ -273,20 +273,6 @@ extern int _nfs4_call_sync_session(struct nfs_server *server, | |||
| 273 | struct nfs4_sequence_res *res, | 273 | struct nfs4_sequence_res *res, |
| 274 | int cache_reply); | 274 | int cache_reply); |
| 275 | 275 | ||
| 276 | #ifdef CONFIG_NFS_V4_1 | ||
| 277 | extern void nfs41_sequence_free_slot(const struct nfs_client *, | ||
| 278 | struct nfs4_sequence_res *res); | ||
| 279 | #endif /* CONFIG_NFS_V4_1 */ | ||
| 280 | |||
| 281 | static inline void nfs4_sequence_free_slot(const struct nfs_client *clp, | ||
| 282 | struct nfs4_sequence_res *res) | ||
| 283 | { | ||
| 284 | #ifdef CONFIG_NFS_V4_1 | ||
| 285 | if (nfs4_has_session(clp)) | ||
| 286 | nfs41_sequence_free_slot(clp, res); | ||
| 287 | #endif /* CONFIG_NFS_V4_1 */ | ||
| 288 | } | ||
| 289 | |||
| 290 | /* | 276 | /* |
| 291 | * Determine the device name as a string | 277 | * Determine the device name as a string |
| 292 | */ | 278 | */ |
| @@ -380,3 +366,15 @@ unsigned int nfs_page_array_len(unsigned int base, size_t len) | |||
| 380 | return ((unsigned long)len + (unsigned long)base + | 366 | return ((unsigned long)len + (unsigned long)base + |
| 381 | PAGE_SIZE - 1) >> PAGE_SHIFT; | 367 | PAGE_SIZE - 1) >> PAGE_SHIFT; |
| 382 | } | 368 | } |
| 369 | |||
| 370 | /* | ||
| 371 | * Helper for restarting RPC calls in the possible presence of NFSv4.1 | ||
| 372 | * sessions. | ||
| 373 | */ | ||
| 374 | static inline void nfs_restart_rpc(struct rpc_task *task, const struct nfs_client *clp) | ||
| 375 | { | ||
| 376 | if (nfs4_has_session(clp)) | ||
| 377 | rpc_restart_call_prepare(task); | ||
| 378 | else | ||
| 379 | rpc_restart_call(task); | ||
| 380 | } | ||
diff --git a/fs/nfs/iostat.h b/fs/nfs/iostat.h index ceda50aad73c..46d779abafd3 100644 --- a/fs/nfs/iostat.h +++ b/fs/nfs/iostat.h | |||
| @@ -25,13 +25,7 @@ struct nfs_iostats { | |||
| 25 | static inline void nfs_inc_server_stats(const struct nfs_server *server, | 25 | static inline void nfs_inc_server_stats(const struct nfs_server *server, |
| 26 | enum nfs_stat_eventcounters stat) | 26 | enum nfs_stat_eventcounters stat) |
| 27 | { | 27 | { |
| 28 | struct nfs_iostats *iostats; | 28 | this_cpu_inc(server->io_stats->events[stat]); |
| 29 | int cpu; | ||
| 30 | |||
| 31 | cpu = get_cpu(); | ||
| 32 | iostats = per_cpu_ptr(server->io_stats, cpu); | ||
| 33 | iostats->events[stat]++; | ||
| 34 | put_cpu(); | ||
| 35 | } | 29 | } |
| 36 | 30 | ||
| 37 | static inline void nfs_inc_stats(const struct inode *inode, | 31 | static inline void nfs_inc_stats(const struct inode *inode, |
| @@ -44,13 +38,7 @@ static inline void nfs_add_server_stats(const struct nfs_server *server, | |||
| 44 | enum nfs_stat_bytecounters stat, | 38 | enum nfs_stat_bytecounters stat, |
| 45 | unsigned long addend) | 39 | unsigned long addend) |
| 46 | { | 40 | { |
| 47 | struct nfs_iostats *iostats; | 41 | this_cpu_add(server->io_stats->bytes[stat], addend); |
| 48 | int cpu; | ||
| 49 | |||
| 50 | cpu = get_cpu(); | ||
| 51 | iostats = per_cpu_ptr(server->io_stats, cpu); | ||
| 52 | iostats->bytes[stat] += addend; | ||
| 53 | put_cpu(); | ||
| 54 | } | 42 | } |
| 55 | 43 | ||
| 56 | static inline void nfs_add_stats(const struct inode *inode, | 44 | static inline void nfs_add_stats(const struct inode *inode, |
| @@ -65,13 +53,7 @@ static inline void nfs_add_fscache_stats(struct inode *inode, | |||
| 65 | enum nfs_stat_fscachecounters stat, | 53 | enum nfs_stat_fscachecounters stat, |
| 66 | unsigned long addend) | 54 | unsigned long addend) |
| 67 | { | 55 | { |
| 68 | struct nfs_iostats *iostats; | 56 | this_cpu_add(NFS_SERVER(inode)->io_stats->fscache[stat], addend); |
| 69 | int cpu; | ||
| 70 | |||
| 71 | cpu = get_cpu(); | ||
| 72 | iostats = per_cpu_ptr(NFS_SERVER(inode)->io_stats, cpu); | ||
| 73 | iostats->fscache[stat] += addend; | ||
| 74 | put_cpu(); | ||
| 75 | } | 57 | } |
| 76 | #endif | 58 | #endif |
| 77 | 59 | ||
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index 6ea07a3c75d4..7e57b04e4014 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h | |||
| @@ -44,7 +44,8 @@ enum nfs4_client_state { | |||
| 44 | NFS4CLNT_RECLAIM_REBOOT, | 44 | NFS4CLNT_RECLAIM_REBOOT, |
| 45 | NFS4CLNT_RECLAIM_NOGRACE, | 45 | NFS4CLNT_RECLAIM_NOGRACE, |
| 46 | NFS4CLNT_DELEGRETURN, | 46 | NFS4CLNT_DELEGRETURN, |
| 47 | NFS4CLNT_SESSION_SETUP, | 47 | NFS4CLNT_SESSION_RESET, |
| 48 | NFS4CLNT_SESSION_DRAINING, | ||
| 48 | }; | 49 | }; |
| 49 | 50 | ||
| 50 | /* | 51 | /* |
| @@ -180,6 +181,7 @@ struct nfs4_state_recovery_ops { | |||
| 180 | int (*recover_lock)(struct nfs4_state *, struct file_lock *); | 181 | int (*recover_lock)(struct nfs4_state *, struct file_lock *); |
| 181 | int (*establish_clid)(struct nfs_client *, struct rpc_cred *); | 182 | int (*establish_clid)(struct nfs_client *, struct rpc_cred *); |
| 182 | struct rpc_cred * (*get_clid_cred)(struct nfs_client *); | 183 | struct rpc_cred * (*get_clid_cred)(struct nfs_client *); |
| 184 | int (*reclaim_complete)(struct nfs_client *); | ||
| 183 | }; | 185 | }; |
| 184 | 186 | ||
| 185 | struct nfs4_state_maintenance_ops { | 187 | struct nfs4_state_maintenance_ops { |
| @@ -200,9 +202,11 @@ extern ssize_t nfs4_listxattr(struct dentry *, char *, size_t); | |||
| 200 | /* nfs4proc.c */ | 202 | /* nfs4proc.c */ |
| 201 | extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *); | 203 | extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *); |
| 202 | extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct rpc_cred *); | 204 | extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct rpc_cred *); |
| 205 | extern int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred); | ||
| 203 | extern int nfs4_proc_async_renew(struct nfs_client *, struct rpc_cred *); | 206 | extern int nfs4_proc_async_renew(struct nfs_client *, struct rpc_cred *); |
| 204 | extern int nfs4_proc_renew(struct nfs_client *, struct rpc_cred *); | 207 | extern int nfs4_proc_renew(struct nfs_client *, struct rpc_cred *); |
| 205 | extern int nfs4_init_clientid(struct nfs_client *, struct rpc_cred *); | 208 | extern int nfs4_init_clientid(struct nfs_client *, struct rpc_cred *); |
| 209 | extern int nfs41_init_clientid(struct nfs_client *, struct rpc_cred *); | ||
| 206 | extern int nfs4_do_close(struct path *path, struct nfs4_state *state, int wait); | 210 | extern int nfs4_do_close(struct path *path, struct nfs4_state *state, int wait); |
| 207 | extern struct dentry *nfs4_atomic_open(struct inode *, struct dentry *, struct nameidata *); | 211 | extern struct dentry *nfs4_atomic_open(struct inode *, struct dentry *, struct nameidata *); |
| 208 | extern int nfs4_open_revalidate(struct inode *, struct dentry *, int, struct nameidata *); | 212 | extern int nfs4_open_revalidate(struct inode *, struct dentry *, int, struct nameidata *); |
| @@ -218,9 +222,11 @@ extern int nfs4_setup_sequence(struct nfs_client *clp, | |||
| 218 | int cache_reply, struct rpc_task *task); | 222 | int cache_reply, struct rpc_task *task); |
| 219 | extern void nfs4_destroy_session(struct nfs4_session *session); | 223 | extern void nfs4_destroy_session(struct nfs4_session *session); |
| 220 | extern struct nfs4_session *nfs4_alloc_session(struct nfs_client *clp); | 224 | extern struct nfs4_session *nfs4_alloc_session(struct nfs_client *clp); |
| 221 | extern int nfs4_proc_create_session(struct nfs_client *, int reset); | 225 | extern int nfs4_proc_create_session(struct nfs_client *); |
| 222 | extern int nfs4_proc_destroy_session(struct nfs4_session *); | 226 | extern int nfs4_proc_destroy_session(struct nfs4_session *); |
| 223 | extern int nfs4_init_session(struct nfs_server *server); | 227 | extern int nfs4_init_session(struct nfs_server *server); |
| 228 | extern int nfs4_proc_get_lease_time(struct nfs_client *clp, | ||
| 229 | struct nfs_fsinfo *fsinfo); | ||
| 224 | #else /* CONFIG_NFS_v4_1 */ | 230 | #else /* CONFIG_NFS_v4_1 */ |
| 225 | static inline int nfs4_setup_sequence(struct nfs_client *clp, | 231 | static inline int nfs4_setup_sequence(struct nfs_client *clp, |
| 226 | struct nfs4_sequence_args *args, struct nfs4_sequence_res *res, | 232 | struct nfs4_sequence_args *args, struct nfs4_sequence_res *res, |
| @@ -267,6 +273,7 @@ extern void nfs4_state_set_mode_locked(struct nfs4_state *, fmode_t); | |||
| 267 | extern void nfs4_schedule_state_recovery(struct nfs_client *); | 273 | extern void nfs4_schedule_state_recovery(struct nfs_client *); |
| 268 | extern void nfs4_schedule_state_manager(struct nfs_client *); | 274 | extern void nfs4_schedule_state_manager(struct nfs_client *); |
| 269 | extern int nfs4_state_mark_reclaim_nograce(struct nfs_client *clp, struct nfs4_state *state); | 275 | extern int nfs4_state_mark_reclaim_nograce(struct nfs_client *clp, struct nfs4_state *state); |
| 276 | extern void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags); | ||
| 270 | extern void nfs4_put_lock_state(struct nfs4_lock_state *lsp); | 277 | extern void nfs4_put_lock_state(struct nfs4_lock_state *lsp); |
| 271 | extern int nfs4_set_lock_state(struct nfs4_state *state, struct file_lock *fl); | 278 | extern int nfs4_set_lock_state(struct nfs4_state *state, struct file_lock *fl); |
| 272 | extern void nfs4_copy_stateid(nfs4_stateid *, struct nfs4_state *, fl_owner_t); | 279 | extern void nfs4_copy_stateid(nfs4_stateid *, struct nfs4_state *, fl_owner_t); |
| @@ -287,6 +294,7 @@ struct nfs4_mount_data; | |||
| 287 | 294 | ||
| 288 | /* callback_xdr.c */ | 295 | /* callback_xdr.c */ |
| 289 | extern struct svc_version nfs4_callback_version1; | 296 | extern struct svc_version nfs4_callback_version1; |
| 297 | extern struct svc_version nfs4_callback_version4; | ||
| 290 | 298 | ||
| 291 | #else | 299 | #else |
| 292 | 300 | ||
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 741a562177fc..9f5f11ecfd93 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
| @@ -270,11 +270,18 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode, | |||
| 270 | case -NFS4ERR_SEQ_MISORDERED: | 270 | case -NFS4ERR_SEQ_MISORDERED: |
| 271 | dprintk("%s ERROR: %d Reset session\n", __func__, | 271 | dprintk("%s ERROR: %d Reset session\n", __func__, |
| 272 | errorcode); | 272 | errorcode); |
| 273 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | 273 | nfs4_schedule_state_recovery(clp); |
| 274 | exception->retry = 1; | 274 | exception->retry = 1; |
| 275 | /* FALLTHROUGH */ | 275 | break; |
| 276 | #endif /* !defined(CONFIG_NFS_V4_1) */ | 276 | #endif /* !defined(CONFIG_NFS_V4_1) */ |
| 277 | case -NFS4ERR_FILE_OPEN: | 277 | case -NFS4ERR_FILE_OPEN: |
| 278 | if (exception->timeout > HZ) { | ||
| 279 | /* We have retried a decent amount, time to | ||
| 280 | * fail | ||
| 281 | */ | ||
| 282 | ret = -EBUSY; | ||
| 283 | break; | ||
| 284 | } | ||
| 278 | case -NFS4ERR_GRACE: | 285 | case -NFS4ERR_GRACE: |
| 279 | case -NFS4ERR_DELAY: | 286 | case -NFS4ERR_DELAY: |
| 280 | ret = nfs4_delay(server->client, &exception->timeout); | 287 | ret = nfs4_delay(server->client, &exception->timeout); |
| @@ -311,48 +318,54 @@ static void renew_lease(const struct nfs_server *server, unsigned long timestamp | |||
| 311 | * so we need to scan down from highest_used_slotid to 0 looking for the now | 318 | * so we need to scan down from highest_used_slotid to 0 looking for the now |
| 312 | * highest slotid in use. | 319 | * highest slotid in use. |
| 313 | * If none found, highest_used_slotid is set to -1. | 320 | * If none found, highest_used_slotid is set to -1. |
| 321 | * | ||
| 322 | * Must be called while holding tbl->slot_tbl_lock | ||
| 314 | */ | 323 | */ |
| 315 | static void | 324 | static void |
| 316 | nfs4_free_slot(struct nfs4_slot_table *tbl, u8 free_slotid) | 325 | nfs4_free_slot(struct nfs4_slot_table *tbl, u8 free_slotid) |
| 317 | { | 326 | { |
| 318 | int slotid = free_slotid; | 327 | int slotid = free_slotid; |
| 319 | 328 | ||
| 320 | spin_lock(&tbl->slot_tbl_lock); | ||
| 321 | /* clear used bit in bitmap */ | 329 | /* clear used bit in bitmap */ |
| 322 | __clear_bit(slotid, tbl->used_slots); | 330 | __clear_bit(slotid, tbl->used_slots); |
| 323 | 331 | ||
| 324 | /* update highest_used_slotid when it is freed */ | 332 | /* update highest_used_slotid when it is freed */ |
| 325 | if (slotid == tbl->highest_used_slotid) { | 333 | if (slotid == tbl->highest_used_slotid) { |
| 326 | slotid = find_last_bit(tbl->used_slots, tbl->max_slots); | 334 | slotid = find_last_bit(tbl->used_slots, tbl->max_slots); |
| 327 | if (slotid >= 0 && slotid < tbl->max_slots) | 335 | if (slotid < tbl->max_slots) |
| 328 | tbl->highest_used_slotid = slotid; | 336 | tbl->highest_used_slotid = slotid; |
| 329 | else | 337 | else |
| 330 | tbl->highest_used_slotid = -1; | 338 | tbl->highest_used_slotid = -1; |
| 331 | } | 339 | } |
| 332 | rpc_wake_up_next(&tbl->slot_tbl_waitq); | ||
| 333 | spin_unlock(&tbl->slot_tbl_lock); | ||
| 334 | dprintk("%s: free_slotid %u highest_used_slotid %d\n", __func__, | 340 | dprintk("%s: free_slotid %u highest_used_slotid %d\n", __func__, |
| 335 | free_slotid, tbl->highest_used_slotid); | 341 | free_slotid, tbl->highest_used_slotid); |
| 336 | } | 342 | } |
| 337 | 343 | ||
| 338 | void nfs41_sequence_free_slot(const struct nfs_client *clp, | 344 | static void nfs41_sequence_free_slot(const struct nfs_client *clp, |
| 339 | struct nfs4_sequence_res *res) | 345 | struct nfs4_sequence_res *res) |
| 340 | { | 346 | { |
| 341 | struct nfs4_slot_table *tbl; | 347 | struct nfs4_slot_table *tbl; |
| 342 | 348 | ||
| 343 | if (!nfs4_has_session(clp)) { | ||
| 344 | dprintk("%s: No session\n", __func__); | ||
| 345 | return; | ||
| 346 | } | ||
| 347 | tbl = &clp->cl_session->fc_slot_table; | 349 | tbl = &clp->cl_session->fc_slot_table; |
| 348 | if (res->sr_slotid == NFS4_MAX_SLOT_TABLE) { | 350 | if (res->sr_slotid == NFS4_MAX_SLOT_TABLE) { |
| 349 | dprintk("%s: No slot\n", __func__); | ||
| 350 | /* just wake up the next guy waiting since | 351 | /* just wake up the next guy waiting since |
| 351 | * we may have not consumed a slot after all */ | 352 | * we may have not consumed a slot after all */ |
| 352 | rpc_wake_up_next(&tbl->slot_tbl_waitq); | 353 | dprintk("%s: No slot\n", __func__); |
| 353 | return; | 354 | return; |
| 354 | } | 355 | } |
| 356 | |||
| 357 | spin_lock(&tbl->slot_tbl_lock); | ||
| 355 | nfs4_free_slot(tbl, res->sr_slotid); | 358 | nfs4_free_slot(tbl, res->sr_slotid); |
| 359 | |||
| 360 | /* Signal state manager thread if session is drained */ | ||
| 361 | if (test_bit(NFS4CLNT_SESSION_DRAINING, &clp->cl_state)) { | ||
| 362 | if (tbl->highest_used_slotid == -1) { | ||
| 363 | dprintk("%s COMPLETE: Session Drained\n", __func__); | ||
| 364 | complete(&clp->cl_session->complete); | ||
| 365 | } | ||
| 366 | } else | ||
| 367 | rpc_wake_up_next(&tbl->slot_tbl_waitq); | ||
| 368 | spin_unlock(&tbl->slot_tbl_lock); | ||
| 356 | res->sr_slotid = NFS4_MAX_SLOT_TABLE; | 369 | res->sr_slotid = NFS4_MAX_SLOT_TABLE; |
| 357 | } | 370 | } |
| 358 | 371 | ||
| @@ -377,10 +390,10 @@ static void nfs41_sequence_done(struct nfs_client *clp, | |||
| 377 | if (res->sr_slotid == NFS4_MAX_SLOT_TABLE) | 390 | if (res->sr_slotid == NFS4_MAX_SLOT_TABLE) |
| 378 | goto out; | 391 | goto out; |
| 379 | 392 | ||
| 380 | tbl = &clp->cl_session->fc_slot_table; | 393 | /* Check the SEQUENCE operation status */ |
| 381 | slot = tbl->slots + res->sr_slotid; | ||
| 382 | |||
| 383 | if (res->sr_status == 0) { | 394 | if (res->sr_status == 0) { |
| 395 | tbl = &clp->cl_session->fc_slot_table; | ||
| 396 | slot = tbl->slots + res->sr_slotid; | ||
| 384 | /* Update the slot's sequence and clientid lease timer */ | 397 | /* Update the slot's sequence and clientid lease timer */ |
| 385 | ++slot->seq_nr; | 398 | ++slot->seq_nr; |
| 386 | timestamp = res->sr_renewal_time; | 399 | timestamp = res->sr_renewal_time; |
| @@ -388,7 +401,8 @@ static void nfs41_sequence_done(struct nfs_client *clp, | |||
| 388 | if (time_before(clp->cl_last_renewal, timestamp)) | 401 | if (time_before(clp->cl_last_renewal, timestamp)) |
| 389 | clp->cl_last_renewal = timestamp; | 402 | clp->cl_last_renewal = timestamp; |
| 390 | spin_unlock(&clp->cl_lock); | 403 | spin_unlock(&clp->cl_lock); |
| 391 | return; | 404 | /* Check sequence flags */ |
| 405 | nfs41_handle_sequence_flag_errors(clp, res->sr_status_flags); | ||
| 392 | } | 406 | } |
| 393 | out: | 407 | out: |
| 394 | /* The session may be reset by one of the error handlers. */ | 408 | /* The session may be reset by one of the error handlers. */ |
| @@ -429,24 +443,6 @@ out: | |||
| 429 | return ret_id; | 443 | return ret_id; |
| 430 | } | 444 | } |
| 431 | 445 | ||
| 432 | static int nfs4_recover_session(struct nfs4_session *session) | ||
| 433 | { | ||
| 434 | struct nfs_client *clp = session->clp; | ||
| 435 | unsigned int loop; | ||
| 436 | int ret; | ||
| 437 | |||
| 438 | for (loop = NFS4_MAX_LOOP_ON_RECOVER; loop != 0; loop--) { | ||
| 439 | ret = nfs4_wait_clnt_recover(clp); | ||
| 440 | if (ret != 0) | ||
| 441 | break; | ||
| 442 | if (!test_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state)) | ||
| 443 | break; | ||
| 444 | nfs4_schedule_state_manager(clp); | ||
| 445 | ret = -EIO; | ||
| 446 | } | ||
| 447 | return ret; | ||
| 448 | } | ||
| 449 | |||
| 450 | static int nfs41_setup_sequence(struct nfs4_session *session, | 446 | static int nfs41_setup_sequence(struct nfs4_session *session, |
| 451 | struct nfs4_sequence_args *args, | 447 | struct nfs4_sequence_args *args, |
| 452 | struct nfs4_sequence_res *res, | 448 | struct nfs4_sequence_res *res, |
| @@ -455,7 +451,6 @@ static int nfs41_setup_sequence(struct nfs4_session *session, | |||
| 455 | { | 451 | { |
| 456 | struct nfs4_slot *slot; | 452 | struct nfs4_slot *slot; |
| 457 | struct nfs4_slot_table *tbl; | 453 | struct nfs4_slot_table *tbl; |
| 458 | int status = 0; | ||
| 459 | u8 slotid; | 454 | u8 slotid; |
| 460 | 455 | ||
| 461 | dprintk("--> %s\n", __func__); | 456 | dprintk("--> %s\n", __func__); |
| @@ -468,21 +463,15 @@ static int nfs41_setup_sequence(struct nfs4_session *session, | |||
| 468 | tbl = &session->fc_slot_table; | 463 | tbl = &session->fc_slot_table; |
| 469 | 464 | ||
| 470 | spin_lock(&tbl->slot_tbl_lock); | 465 | spin_lock(&tbl->slot_tbl_lock); |
| 471 | if (test_bit(NFS4CLNT_SESSION_SETUP, &session->clp->cl_state)) { | 466 | if (test_bit(NFS4CLNT_SESSION_DRAINING, &session->clp->cl_state)) { |
| 472 | if (tbl->highest_used_slotid != -1) { | 467 | /* |
| 473 | rpc_sleep_on(&tbl->slot_tbl_waitq, task, NULL); | 468 | * The state manager will wait until the slot table is empty. |
| 474 | spin_unlock(&tbl->slot_tbl_lock); | 469 | * Schedule the reset thread |
| 475 | dprintk("<-- %s: Session reset: draining\n", __func__); | 470 | */ |
| 476 | return -EAGAIN; | 471 | rpc_sleep_on(&tbl->slot_tbl_waitq, task, NULL); |
| 477 | } | ||
| 478 | |||
| 479 | /* The slot table is empty; start the reset thread */ | ||
| 480 | dprintk("%s Session Reset\n", __func__); | ||
| 481 | spin_unlock(&tbl->slot_tbl_lock); | 472 | spin_unlock(&tbl->slot_tbl_lock); |
| 482 | status = nfs4_recover_session(session); | 473 | dprintk("%s Schedule Session Reset\n", __func__); |
| 483 | if (status) | 474 | return -EAGAIN; |
| 484 | return status; | ||
| 485 | spin_lock(&tbl->slot_tbl_lock); | ||
| 486 | } | 475 | } |
| 487 | 476 | ||
| 488 | slotid = nfs4_find_slot(tbl, task); | 477 | slotid = nfs4_find_slot(tbl, task); |
| @@ -527,7 +516,7 @@ int nfs4_setup_sequence(struct nfs_client *clp, | |||
| 527 | goto out; | 516 | goto out; |
| 528 | ret = nfs41_setup_sequence(clp->cl_session, args, res, cache_reply, | 517 | ret = nfs41_setup_sequence(clp->cl_session, args, res, cache_reply, |
| 529 | task); | 518 | task); |
| 530 | if (ret != -EAGAIN) { | 519 | if (ret && ret != -EAGAIN) { |
| 531 | /* terminate rpc task */ | 520 | /* terminate rpc task */ |
| 532 | task->tk_status = ret; | 521 | task->tk_status = ret; |
| 533 | task->tk_action = NULL; | 522 | task->tk_action = NULL; |
| @@ -561,7 +550,6 @@ static void nfs41_call_sync_done(struct rpc_task *task, void *calldata) | |||
| 561 | struct nfs41_call_sync_data *data = calldata; | 550 | struct nfs41_call_sync_data *data = calldata; |
| 562 | 551 | ||
| 563 | nfs41_sequence_done(data->clp, data->seq_res, task->tk_status); | 552 | nfs41_sequence_done(data->clp, data->seq_res, task->tk_status); |
| 564 | nfs41_sequence_free_slot(data->clp, data->seq_res); | ||
| 565 | } | 553 | } |
| 566 | 554 | ||
| 567 | struct rpc_call_ops nfs41_call_sync_ops = { | 555 | struct rpc_call_ops nfs41_call_sync_ops = { |
| @@ -637,15 +625,6 @@ static void nfs4_sequence_done(const struct nfs_server *server, | |||
| 637 | #endif /* CONFIG_NFS_V4_1 */ | 625 | #endif /* CONFIG_NFS_V4_1 */ |
| 638 | } | 626 | } |
| 639 | 627 | ||
| 640 | /* no restart, therefore free slot here */ | ||
| 641 | static void nfs4_sequence_done_free_slot(const struct nfs_server *server, | ||
| 642 | struct nfs4_sequence_res *res, | ||
| 643 | int rpc_status) | ||
| 644 | { | ||
| 645 | nfs4_sequence_done(server, res, rpc_status); | ||
| 646 | nfs4_sequence_free_slot(server->nfs_client, res); | ||
| 647 | } | ||
| 648 | |||
| 649 | static void update_changeattr(struct inode *dir, struct nfs4_change_info *cinfo) | 628 | static void update_changeattr(struct inode *dir, struct nfs4_change_info *cinfo) |
| 650 | { | 629 | { |
| 651 | struct nfs_inode *nfsi = NFS_I(dir); | 630 | struct nfs_inode *nfsi = NFS_I(dir); |
| @@ -720,9 +699,15 @@ static struct nfs4_opendata *nfs4_opendata_alloc(struct path *path, | |||
| 720 | p->o_arg.bitmask = server->attr_bitmask; | 699 | p->o_arg.bitmask = server->attr_bitmask; |
| 721 | p->o_arg.claim = NFS4_OPEN_CLAIM_NULL; | 700 | p->o_arg.claim = NFS4_OPEN_CLAIM_NULL; |
| 722 | if (flags & O_EXCL) { | 701 | if (flags & O_EXCL) { |
| 723 | u32 *s = (u32 *) p->o_arg.u.verifier.data; | 702 | if (nfs4_has_persistent_session(server->nfs_client)) { |
| 724 | s[0] = jiffies; | 703 | /* GUARDED */ |
| 725 | s[1] = current->pid; | 704 | p->o_arg.u.attrs = &p->attrs; |
| 705 | memcpy(&p->attrs, attrs, sizeof(p->attrs)); | ||
| 706 | } else { /* EXCLUSIVE4_1 */ | ||
| 707 | u32 *s = (u32 *) p->o_arg.u.verifier.data; | ||
| 708 | s[0] = jiffies; | ||
| 709 | s[1] = current->pid; | ||
| 710 | } | ||
| 726 | } else if (flags & O_CREAT) { | 711 | } else if (flags & O_CREAT) { |
| 727 | p->o_arg.u.attrs = &p->attrs; | 712 | p->o_arg.u.attrs = &p->attrs; |
| 728 | memcpy(&p->attrs, attrs, sizeof(p->attrs)); | 713 | memcpy(&p->attrs, attrs, sizeof(p->attrs)); |
| @@ -776,13 +761,16 @@ static int can_open_cached(struct nfs4_state *state, fmode_t mode, int open_mode | |||
| 776 | goto out; | 761 | goto out; |
| 777 | switch (mode & (FMODE_READ|FMODE_WRITE)) { | 762 | switch (mode & (FMODE_READ|FMODE_WRITE)) { |
| 778 | case FMODE_READ: | 763 | case FMODE_READ: |
| 779 | ret |= test_bit(NFS_O_RDONLY_STATE, &state->flags) != 0; | 764 | ret |= test_bit(NFS_O_RDONLY_STATE, &state->flags) != 0 |
| 765 | && state->n_rdonly != 0; | ||
| 780 | break; | 766 | break; |
| 781 | case FMODE_WRITE: | 767 | case FMODE_WRITE: |
| 782 | ret |= test_bit(NFS_O_WRONLY_STATE, &state->flags) != 0; | 768 | ret |= test_bit(NFS_O_WRONLY_STATE, &state->flags) != 0 |
| 769 | && state->n_wronly != 0; | ||
| 783 | break; | 770 | break; |
| 784 | case FMODE_READ|FMODE_WRITE: | 771 | case FMODE_READ|FMODE_WRITE: |
| 785 | ret |= test_bit(NFS_O_RDWR_STATE, &state->flags) != 0; | 772 | ret |= test_bit(NFS_O_RDWR_STATE, &state->flags) != 0 |
| 773 | && state->n_rdwr != 0; | ||
| 786 | } | 774 | } |
| 787 | out: | 775 | out: |
| 788 | return ret; | 776 | return ret; |
| @@ -1183,6 +1171,14 @@ int nfs4_open_delegation_recall(struct nfs_open_context *ctx, struct nfs4_state | |||
| 1183 | case -ENOENT: | 1171 | case -ENOENT: |
| 1184 | case -ESTALE: | 1172 | case -ESTALE: |
| 1185 | goto out; | 1173 | goto out; |
| 1174 | case -NFS4ERR_BADSESSION: | ||
| 1175 | case -NFS4ERR_BADSLOT: | ||
| 1176 | case -NFS4ERR_BAD_HIGH_SLOT: | ||
| 1177 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: | ||
| 1178 | case -NFS4ERR_DEADSESSION: | ||
| 1179 | nfs4_schedule_state_recovery( | ||
| 1180 | server->nfs_client); | ||
| 1181 | goto out; | ||
| 1186 | case -NFS4ERR_STALE_CLIENTID: | 1182 | case -NFS4ERR_STALE_CLIENTID: |
| 1187 | case -NFS4ERR_STALE_STATEID: | 1183 | case -NFS4ERR_STALE_STATEID: |
| 1188 | case -NFS4ERR_EXPIRED: | 1184 | case -NFS4ERR_EXPIRED: |
| @@ -1336,8 +1332,8 @@ static void nfs4_open_done(struct rpc_task *task, void *calldata) | |||
| 1336 | 1332 | ||
| 1337 | data->rpc_status = task->tk_status; | 1333 | data->rpc_status = task->tk_status; |
| 1338 | 1334 | ||
| 1339 | nfs4_sequence_done_free_slot(data->o_arg.server, &data->o_res.seq_res, | 1335 | nfs4_sequence_done(data->o_arg.server, &data->o_res.seq_res, |
| 1340 | task->tk_status); | 1336 | task->tk_status); |
| 1341 | 1337 | ||
| 1342 | if (RPC_ASSASSINATED(task)) | 1338 | if (RPC_ASSASSINATED(task)) |
| 1343 | return; | 1339 | return; |
| @@ -1488,7 +1484,7 @@ static int _nfs4_open_expired(struct nfs_open_context *ctx, struct nfs4_state *s | |||
| 1488 | return ret; | 1484 | return ret; |
| 1489 | } | 1485 | } |
| 1490 | 1486 | ||
| 1491 | static inline int nfs4_do_open_expired(struct nfs_open_context *ctx, struct nfs4_state *state) | 1487 | static int nfs4_do_open_expired(struct nfs_open_context *ctx, struct nfs4_state *state) |
| 1492 | { | 1488 | { |
| 1493 | struct nfs_server *server = NFS_SERVER(state->inode); | 1489 | struct nfs_server *server = NFS_SERVER(state->inode); |
| 1494 | struct nfs4_exception exception = { }; | 1490 | struct nfs4_exception exception = { }; |
| @@ -1496,10 +1492,16 @@ static inline int nfs4_do_open_expired(struct nfs_open_context *ctx, struct nfs4 | |||
| 1496 | 1492 | ||
| 1497 | do { | 1493 | do { |
| 1498 | err = _nfs4_open_expired(ctx, state); | 1494 | err = _nfs4_open_expired(ctx, state); |
| 1499 | if (err != -NFS4ERR_DELAY) | 1495 | switch (err) { |
| 1500 | break; | 1496 | default: |
| 1501 | nfs4_handle_exception(server, err, &exception); | 1497 | goto out; |
| 1498 | case -NFS4ERR_GRACE: | ||
| 1499 | case -NFS4ERR_DELAY: | ||
| 1500 | nfs4_handle_exception(server, err, &exception); | ||
| 1501 | err = 0; | ||
| 1502 | } | ||
| 1502 | } while (exception.retry); | 1503 | } while (exception.retry); |
| 1504 | out: | ||
| 1503 | return err; | 1505 | return err; |
| 1504 | } | 1506 | } |
| 1505 | 1507 | ||
| @@ -1712,6 +1714,18 @@ static void nfs4_free_closedata(void *data) | |||
| 1712 | kfree(calldata); | 1714 | kfree(calldata); |
| 1713 | } | 1715 | } |
| 1714 | 1716 | ||
| 1717 | static void nfs4_close_clear_stateid_flags(struct nfs4_state *state, | ||
| 1718 | fmode_t fmode) | ||
| 1719 | { | ||
| 1720 | spin_lock(&state->owner->so_lock); | ||
| 1721 | if (!(fmode & FMODE_READ)) | ||
| 1722 | clear_bit(NFS_O_RDONLY_STATE, &state->flags); | ||
| 1723 | if (!(fmode & FMODE_WRITE)) | ||
| 1724 | clear_bit(NFS_O_WRONLY_STATE, &state->flags); | ||
| 1725 | clear_bit(NFS_O_RDWR_STATE, &state->flags); | ||
| 1726 | spin_unlock(&state->owner->so_lock); | ||
| 1727 | } | ||
| 1728 | |||
| 1715 | static void nfs4_close_done(struct rpc_task *task, void *data) | 1729 | static void nfs4_close_done(struct rpc_task *task, void *data) |
| 1716 | { | 1730 | { |
| 1717 | struct nfs4_closedata *calldata = data; | 1731 | struct nfs4_closedata *calldata = data; |
| @@ -1728,6 +1742,8 @@ static void nfs4_close_done(struct rpc_task *task, void *data) | |||
| 1728 | case 0: | 1742 | case 0: |
| 1729 | nfs_set_open_stateid(state, &calldata->res.stateid, 0); | 1743 | nfs_set_open_stateid(state, &calldata->res.stateid, 0); |
| 1730 | renew_lease(server, calldata->timestamp); | 1744 | renew_lease(server, calldata->timestamp); |
| 1745 | nfs4_close_clear_stateid_flags(state, | ||
| 1746 | calldata->arg.fmode); | ||
| 1731 | break; | 1747 | break; |
| 1732 | case -NFS4ERR_STALE_STATEID: | 1748 | case -NFS4ERR_STALE_STATEID: |
| 1733 | case -NFS4ERR_OLD_STATEID: | 1749 | case -NFS4ERR_OLD_STATEID: |
| @@ -1737,11 +1753,10 @@ static void nfs4_close_done(struct rpc_task *task, void *data) | |||
| 1737 | break; | 1753 | break; |
| 1738 | default: | 1754 | default: |
| 1739 | if (nfs4_async_handle_error(task, server, state) == -EAGAIN) { | 1755 | if (nfs4_async_handle_error(task, server, state) == -EAGAIN) { |
| 1740 | nfs4_restart_rpc(task, server->nfs_client); | 1756 | nfs_restart_rpc(task, server->nfs_client); |
| 1741 | return; | 1757 | return; |
| 1742 | } | 1758 | } |
| 1743 | } | 1759 | } |
| 1744 | nfs4_sequence_free_slot(server->nfs_client, &calldata->res.seq_res); | ||
| 1745 | nfs_refresh_inode(calldata->inode, calldata->res.fattr); | 1760 | nfs_refresh_inode(calldata->inode, calldata->res.fattr); |
| 1746 | } | 1761 | } |
| 1747 | 1762 | ||
| @@ -1749,38 +1764,39 @@ static void nfs4_close_prepare(struct rpc_task *task, void *data) | |||
| 1749 | { | 1764 | { |
| 1750 | struct nfs4_closedata *calldata = data; | 1765 | struct nfs4_closedata *calldata = data; |
| 1751 | struct nfs4_state *state = calldata->state; | 1766 | struct nfs4_state *state = calldata->state; |
| 1752 | int clear_rd, clear_wr, clear_rdwr; | 1767 | int call_close = 0; |
| 1753 | 1768 | ||
| 1754 | if (nfs_wait_on_sequence(calldata->arg.seqid, task) != 0) | 1769 | if (nfs_wait_on_sequence(calldata->arg.seqid, task) != 0) |
| 1755 | return; | 1770 | return; |
| 1756 | 1771 | ||
| 1757 | clear_rd = clear_wr = clear_rdwr = 0; | 1772 | task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_OPEN_DOWNGRADE]; |
| 1773 | calldata->arg.fmode = FMODE_READ|FMODE_WRITE; | ||
| 1758 | spin_lock(&state->owner->so_lock); | 1774 | spin_lock(&state->owner->so_lock); |
| 1759 | /* Calculate the change in open mode */ | 1775 | /* Calculate the change in open mode */ |
| 1760 | if (state->n_rdwr == 0) { | 1776 | if (state->n_rdwr == 0) { |
| 1761 | if (state->n_rdonly == 0) { | 1777 | if (state->n_rdonly == 0) { |
| 1762 | clear_rd |= test_and_clear_bit(NFS_O_RDONLY_STATE, &state->flags); | 1778 | call_close |= test_bit(NFS_O_RDONLY_STATE, &state->flags); |
| 1763 | clear_rdwr |= test_and_clear_bit(NFS_O_RDWR_STATE, &state->flags); | 1779 | call_close |= test_bit(NFS_O_RDWR_STATE, &state->flags); |
| 1780 | calldata->arg.fmode &= ~FMODE_READ; | ||
| 1764 | } | 1781 | } |
| 1765 | if (state->n_wronly == 0) { | 1782 | if (state->n_wronly == 0) { |
| 1766 | clear_wr |= test_and_clear_bit(NFS_O_WRONLY_STATE, &state->flags); | 1783 | call_close |= test_bit(NFS_O_WRONLY_STATE, &state->flags); |
| 1767 | clear_rdwr |= test_and_clear_bit(NFS_O_RDWR_STATE, &state->flags); | 1784 | call_close |= test_bit(NFS_O_RDWR_STATE, &state->flags); |
| 1785 | calldata->arg.fmode &= ~FMODE_WRITE; | ||
| 1768 | } | 1786 | } |
| 1769 | } | 1787 | } |
| 1770 | spin_unlock(&state->owner->so_lock); | 1788 | spin_unlock(&state->owner->so_lock); |
| 1771 | if (!clear_rd && !clear_wr && !clear_rdwr) { | 1789 | |
| 1790 | if (!call_close) { | ||
| 1772 | /* Note: exit _without_ calling nfs4_close_done */ | 1791 | /* Note: exit _without_ calling nfs4_close_done */ |
| 1773 | task->tk_action = NULL; | 1792 | task->tk_action = NULL; |
| 1774 | return; | 1793 | return; |
| 1775 | } | 1794 | } |
| 1795 | |||
| 1796 | if (calldata->arg.fmode == 0) | ||
| 1797 | task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_CLOSE]; | ||
| 1798 | |||
| 1776 | nfs_fattr_init(calldata->res.fattr); | 1799 | nfs_fattr_init(calldata->res.fattr); |
| 1777 | if (test_bit(NFS_O_RDONLY_STATE, &state->flags) != 0) { | ||
| 1778 | task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_OPEN_DOWNGRADE]; | ||
| 1779 | calldata->arg.fmode = FMODE_READ; | ||
| 1780 | } else if (test_bit(NFS_O_WRONLY_STATE, &state->flags) != 0) { | ||
| 1781 | task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_OPEN_DOWNGRADE]; | ||
| 1782 | calldata->arg.fmode = FMODE_WRITE; | ||
| 1783 | } | ||
| 1784 | calldata->timestamp = jiffies; | 1800 | calldata->timestamp = jiffies; |
| 1785 | if (nfs4_setup_sequence((NFS_SERVER(calldata->inode))->nfs_client, | 1801 | if (nfs4_setup_sequence((NFS_SERVER(calldata->inode))->nfs_client, |
| 1786 | &calldata->arg.seq_args, &calldata->res.seq_res, | 1802 | &calldata->arg.seq_args, &calldata->res.seq_res, |
| @@ -1981,7 +1997,7 @@ out_drop: | |||
| 1981 | return 0; | 1997 | return 0; |
| 1982 | } | 1998 | } |
| 1983 | 1999 | ||
| 1984 | void nfs4_close_context(struct nfs_open_context *ctx, int is_sync) | 2000 | static void nfs4_close_context(struct nfs_open_context *ctx, int is_sync) |
| 1985 | { | 2001 | { |
| 1986 | if (ctx->state == NULL) | 2002 | if (ctx->state == NULL) |
| 1987 | return; | 2003 | return; |
| @@ -2532,7 +2548,6 @@ static int nfs4_proc_unlink_done(struct rpc_task *task, struct inode *dir) | |||
| 2532 | nfs4_sequence_done(res->server, &res->seq_res, task->tk_status); | 2548 | nfs4_sequence_done(res->server, &res->seq_res, task->tk_status); |
| 2533 | if (nfs4_async_handle_error(task, res->server, NULL) == -EAGAIN) | 2549 | if (nfs4_async_handle_error(task, res->server, NULL) == -EAGAIN) |
| 2534 | return 0; | 2550 | return 0; |
| 2535 | nfs4_sequence_free_slot(res->server->nfs_client, &res->seq_res); | ||
| 2536 | update_changeattr(dir, &res->cinfo); | 2551 | update_changeattr(dir, &res->cinfo); |
| 2537 | nfs_post_op_update_inode(dir, &res->dir_attr); | 2552 | nfs_post_op_update_inode(dir, &res->dir_attr); |
| 2538 | return 1; | 2553 | return 1; |
| @@ -2971,11 +2986,10 @@ static int nfs4_read_done(struct rpc_task *task, struct nfs_read_data *data) | |||
| 2971 | 2986 | ||
| 2972 | dprintk("--> %s\n", __func__); | 2987 | dprintk("--> %s\n", __func__); |
| 2973 | 2988 | ||
| 2974 | /* nfs4_sequence_free_slot called in the read rpc_call_done */ | ||
| 2975 | nfs4_sequence_done(server, &data->res.seq_res, task->tk_status); | 2989 | nfs4_sequence_done(server, &data->res.seq_res, task->tk_status); |
| 2976 | 2990 | ||
| 2977 | if (nfs4_async_handle_error(task, server, data->args.context->state) == -EAGAIN) { | 2991 | if (nfs4_async_handle_error(task, server, data->args.context->state) == -EAGAIN) { |
| 2978 | nfs4_restart_rpc(task, server->nfs_client); | 2992 | nfs_restart_rpc(task, server->nfs_client); |
| 2979 | return -EAGAIN; | 2993 | return -EAGAIN; |
| 2980 | } | 2994 | } |
| 2981 | 2995 | ||
| @@ -2995,12 +3009,11 @@ static int nfs4_write_done(struct rpc_task *task, struct nfs_write_data *data) | |||
| 2995 | { | 3009 | { |
| 2996 | struct inode *inode = data->inode; | 3010 | struct inode *inode = data->inode; |
| 2997 | 3011 | ||
| 2998 | /* slot is freed in nfs_writeback_done */ | ||
| 2999 | nfs4_sequence_done(NFS_SERVER(inode), &data->res.seq_res, | 3012 | nfs4_sequence_done(NFS_SERVER(inode), &data->res.seq_res, |
| 3000 | task->tk_status); | 3013 | task->tk_status); |
| 3001 | 3014 | ||
| 3002 | if (nfs4_async_handle_error(task, NFS_SERVER(inode), data->args.context->state) == -EAGAIN) { | 3015 | if (nfs4_async_handle_error(task, NFS_SERVER(inode), data->args.context->state) == -EAGAIN) { |
| 3003 | nfs4_restart_rpc(task, NFS_SERVER(inode)->nfs_client); | 3016 | nfs_restart_rpc(task, NFS_SERVER(inode)->nfs_client); |
| 3004 | return -EAGAIN; | 3017 | return -EAGAIN; |
| 3005 | } | 3018 | } |
| 3006 | if (task->tk_status >= 0) { | 3019 | if (task->tk_status >= 0) { |
| @@ -3028,11 +3041,9 @@ static int nfs4_commit_done(struct rpc_task *task, struct nfs_write_data *data) | |||
| 3028 | nfs4_sequence_done(NFS_SERVER(inode), &data->res.seq_res, | 3041 | nfs4_sequence_done(NFS_SERVER(inode), &data->res.seq_res, |
| 3029 | task->tk_status); | 3042 | task->tk_status); |
| 3030 | if (nfs4_async_handle_error(task, NFS_SERVER(inode), NULL) == -EAGAIN) { | 3043 | if (nfs4_async_handle_error(task, NFS_SERVER(inode), NULL) == -EAGAIN) { |
| 3031 | nfs4_restart_rpc(task, NFS_SERVER(inode)->nfs_client); | 3044 | nfs_restart_rpc(task, NFS_SERVER(inode)->nfs_client); |
| 3032 | return -EAGAIN; | 3045 | return -EAGAIN; |
| 3033 | } | 3046 | } |
| 3034 | nfs4_sequence_free_slot(NFS_SERVER(inode)->nfs_client, | ||
| 3035 | &data->res.seq_res); | ||
| 3036 | nfs_refresh_inode(inode, data->res.fattr); | 3047 | nfs_refresh_inode(inode, data->res.fattr); |
| 3037 | return 0; | 3048 | return 0; |
| 3038 | } | 3049 | } |
| @@ -3350,7 +3361,7 @@ _nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server, | |||
| 3350 | case -NFS4ERR_SEQ_MISORDERED: | 3361 | case -NFS4ERR_SEQ_MISORDERED: |
| 3351 | dprintk("%s ERROR %d, Reset session\n", __func__, | 3362 | dprintk("%s ERROR %d, Reset session\n", __func__, |
| 3352 | task->tk_status); | 3363 | task->tk_status); |
| 3353 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | 3364 | nfs4_schedule_state_recovery(clp); |
| 3354 | task->tk_status = 0; | 3365 | task->tk_status = 0; |
| 3355 | return -EAGAIN; | 3366 | return -EAGAIN; |
| 3356 | #endif /* CONFIG_NFS_V4_1 */ | 3367 | #endif /* CONFIG_NFS_V4_1 */ |
| @@ -3483,12 +3494,23 @@ static void nfs4_delegreturn_done(struct rpc_task *task, void *calldata) | |||
| 3483 | { | 3494 | { |
| 3484 | struct nfs4_delegreturndata *data = calldata; | 3495 | struct nfs4_delegreturndata *data = calldata; |
| 3485 | 3496 | ||
| 3486 | nfs4_sequence_done_free_slot(data->res.server, &data->res.seq_res, | 3497 | nfs4_sequence_done(data->res.server, &data->res.seq_res, |
| 3487 | task->tk_status); | 3498 | task->tk_status); |
| 3488 | 3499 | ||
| 3489 | data->rpc_status = task->tk_status; | 3500 | switch (task->tk_status) { |
| 3490 | if (data->rpc_status == 0) | 3501 | case -NFS4ERR_STALE_STATEID: |
| 3502 | case -NFS4ERR_EXPIRED: | ||
| 3503 | case 0: | ||
| 3491 | renew_lease(data->res.server, data->timestamp); | 3504 | renew_lease(data->res.server, data->timestamp); |
| 3505 | break; | ||
| 3506 | default: | ||
| 3507 | if (nfs4_async_handle_error(task, data->res.server, NULL) == | ||
| 3508 | -EAGAIN) { | ||
| 3509 | nfs_restart_rpc(task, data->res.server->nfs_client); | ||
| 3510 | return; | ||
| 3511 | } | ||
| 3512 | } | ||
| 3513 | data->rpc_status = task->tk_status; | ||
| 3492 | } | 3514 | } |
| 3493 | 3515 | ||
| 3494 | static void nfs4_delegreturn_release(void *calldata) | 3516 | static void nfs4_delegreturn_release(void *calldata) |
| @@ -3741,11 +3763,9 @@ static void nfs4_locku_done(struct rpc_task *task, void *data) | |||
| 3741 | break; | 3763 | break; |
| 3742 | default: | 3764 | default: |
| 3743 | if (nfs4_async_handle_error(task, calldata->server, NULL) == -EAGAIN) | 3765 | if (nfs4_async_handle_error(task, calldata->server, NULL) == -EAGAIN) |
| 3744 | nfs4_restart_rpc(task, | 3766 | nfs_restart_rpc(task, |
| 3745 | calldata->server->nfs_client); | 3767 | calldata->server->nfs_client); |
| 3746 | } | 3768 | } |
| 3747 | nfs4_sequence_free_slot(calldata->server->nfs_client, | ||
| 3748 | &calldata->res.seq_res); | ||
| 3749 | } | 3769 | } |
| 3750 | 3770 | ||
| 3751 | static void nfs4_locku_prepare(struct rpc_task *task, void *data) | 3771 | static void nfs4_locku_prepare(struct rpc_task *task, void *data) |
| @@ -3927,8 +3947,8 @@ static void nfs4_lock_done(struct rpc_task *task, void *calldata) | |||
| 3927 | 3947 | ||
| 3928 | dprintk("%s: begin!\n", __func__); | 3948 | dprintk("%s: begin!\n", __func__); |
| 3929 | 3949 | ||
| 3930 | nfs4_sequence_done_free_slot(data->server, &data->res.seq_res, | 3950 | nfs4_sequence_done(data->server, &data->res.seq_res, |
| 3931 | task->tk_status); | 3951 | task->tk_status); |
| 3932 | 3952 | ||
| 3933 | data->rpc_status = task->tk_status; | 3953 | data->rpc_status = task->tk_status; |
| 3934 | if (RPC_ASSASSINATED(task)) | 3954 | if (RPC_ASSASSINATED(task)) |
| @@ -4049,10 +4069,16 @@ static int nfs4_lock_expired(struct nfs4_state *state, struct file_lock *request | |||
| 4049 | if (test_bit(NFS_DELEGATED_STATE, &state->flags) != 0) | 4069 | if (test_bit(NFS_DELEGATED_STATE, &state->flags) != 0) |
| 4050 | return 0; | 4070 | return 0; |
| 4051 | err = _nfs4_do_setlk(state, F_SETLK, request, 0); | 4071 | err = _nfs4_do_setlk(state, F_SETLK, request, 0); |
| 4052 | if (err != -NFS4ERR_DELAY) | 4072 | switch (err) { |
| 4053 | break; | 4073 | default: |
| 4054 | nfs4_handle_exception(server, err, &exception); | 4074 | goto out; |
| 4075 | case -NFS4ERR_GRACE: | ||
| 4076 | case -NFS4ERR_DELAY: | ||
| 4077 | nfs4_handle_exception(server, err, &exception); | ||
| 4078 | err = 0; | ||
| 4079 | } | ||
| 4055 | } while (exception.retry); | 4080 | } while (exception.retry); |
| 4081 | out: | ||
| 4056 | return err; | 4082 | return err; |
| 4057 | } | 4083 | } |
| 4058 | 4084 | ||
| @@ -4172,6 +4198,11 @@ int nfs4_lock_delegation_recall(struct nfs4_state *state, struct file_lock *fl) | |||
| 4172 | case -NFS4ERR_EXPIRED: | 4198 | case -NFS4ERR_EXPIRED: |
| 4173 | case -NFS4ERR_STALE_CLIENTID: | 4199 | case -NFS4ERR_STALE_CLIENTID: |
| 4174 | case -NFS4ERR_STALE_STATEID: | 4200 | case -NFS4ERR_STALE_STATEID: |
| 4201 | case -NFS4ERR_BADSESSION: | ||
| 4202 | case -NFS4ERR_BADSLOT: | ||
| 4203 | case -NFS4ERR_BAD_HIGH_SLOT: | ||
| 4204 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: | ||
| 4205 | case -NFS4ERR_DEADSESSION: | ||
| 4175 | nfs4_schedule_state_recovery(server->nfs_client); | 4206 | nfs4_schedule_state_recovery(server->nfs_client); |
| 4176 | goto out; | 4207 | goto out; |
| 4177 | case -ERESTARTSYS: | 4208 | case -ERESTARTSYS: |
| @@ -4296,7 +4327,7 @@ int nfs4_proc_fs_locations(struct inode *dir, const struct qstr *name, | |||
| 4296 | * NFS4ERR_BADSESSION in the sequence operation, and will therefore | 4327 | * NFS4ERR_BADSESSION in the sequence operation, and will therefore |
| 4297 | * be in some phase of session reset. | 4328 | * be in some phase of session reset. |
| 4298 | */ | 4329 | */ |
| 4299 | static int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) | 4330 | int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) |
| 4300 | { | 4331 | { |
| 4301 | nfs4_verifier verifier; | 4332 | nfs4_verifier verifier; |
| 4302 | struct nfs41_exchange_id_args args = { | 4333 | struct nfs41_exchange_id_args args = { |
| @@ -4318,6 +4349,9 @@ static int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) | |||
| 4318 | dprintk("--> %s\n", __func__); | 4349 | dprintk("--> %s\n", __func__); |
| 4319 | BUG_ON(clp == NULL); | 4350 | BUG_ON(clp == NULL); |
| 4320 | 4351 | ||
| 4352 | /* Remove server-only flags */ | ||
| 4353 | args.flags &= ~EXCHGID4_FLAG_CONFIRMED_R; | ||
| 4354 | |||
| 4321 | p = (u32 *)verifier.data; | 4355 | p = (u32 *)verifier.data; |
| 4322 | *p++ = htonl((u32)clp->cl_boot_time.tv_sec); | 4356 | *p++ = htonl((u32)clp->cl_boot_time.tv_sec); |
| 4323 | *p = htonl((u32)clp->cl_boot_time.tv_nsec); | 4357 | *p = htonl((u32)clp->cl_boot_time.tv_nsec); |
| @@ -4389,10 +4423,9 @@ static void nfs4_get_lease_time_done(struct rpc_task *task, void *calldata) | |||
| 4389 | dprintk("%s Retry: tk_status %d\n", __func__, task->tk_status); | 4423 | dprintk("%s Retry: tk_status %d\n", __func__, task->tk_status); |
| 4390 | rpc_delay(task, NFS4_POLL_RETRY_MIN); | 4424 | rpc_delay(task, NFS4_POLL_RETRY_MIN); |
| 4391 | task->tk_status = 0; | 4425 | task->tk_status = 0; |
| 4392 | nfs4_restart_rpc(task, data->clp); | 4426 | nfs_restart_rpc(task, data->clp); |
| 4393 | return; | 4427 | return; |
| 4394 | } | 4428 | } |
| 4395 | nfs41_sequence_free_slot(data->clp, &data->res->lr_seq_res); | ||
| 4396 | dprintk("<-- %s\n", __func__); | 4429 | dprintk("<-- %s\n", __func__); |
| 4397 | } | 4430 | } |
| 4398 | 4431 | ||
| @@ -4465,7 +4498,6 @@ static int nfs4_reset_slot_table(struct nfs4_slot_table *tbl, int max_slots, | |||
| 4465 | spin_lock(&tbl->slot_tbl_lock); | 4498 | spin_lock(&tbl->slot_tbl_lock); |
| 4466 | for (i = 0; i < max_slots; ++i) | 4499 | for (i = 0; i < max_slots; ++i) |
| 4467 | tbl->slots[i].seq_nr = ivalue; | 4500 | tbl->slots[i].seq_nr = ivalue; |
| 4468 | tbl->highest_used_slotid = -1; | ||
| 4469 | spin_unlock(&tbl->slot_tbl_lock); | 4501 | spin_unlock(&tbl->slot_tbl_lock); |
| 4470 | dprintk("%s: tbl=%p slots=%p max_slots=%d\n", __func__, | 4502 | dprintk("%s: tbl=%p slots=%p max_slots=%d\n", __func__, |
| 4471 | tbl, tbl->slots, tbl->max_slots); | 4503 | tbl, tbl->slots, tbl->max_slots); |
| @@ -4515,7 +4547,6 @@ static void nfs4_destroy_slot_tables(struct nfs4_session *session) | |||
| 4515 | static int nfs4_init_slot_table(struct nfs4_slot_table *tbl, | 4547 | static int nfs4_init_slot_table(struct nfs4_slot_table *tbl, |
| 4516 | int max_slots, int ivalue) | 4548 | int max_slots, int ivalue) |
| 4517 | { | 4549 | { |
| 4518 | int i; | ||
| 4519 | struct nfs4_slot *slot; | 4550 | struct nfs4_slot *slot; |
| 4520 | int ret = -ENOMEM; | 4551 | int ret = -ENOMEM; |
| 4521 | 4552 | ||
| @@ -4526,18 +4557,9 @@ static int nfs4_init_slot_table(struct nfs4_slot_table *tbl, | |||
| 4526 | slot = kcalloc(max_slots, sizeof(struct nfs4_slot), GFP_KERNEL); | 4557 | slot = kcalloc(max_slots, sizeof(struct nfs4_slot), GFP_KERNEL); |
| 4527 | if (!slot) | 4558 | if (!slot) |
| 4528 | goto out; | 4559 | goto out; |
| 4529 | for (i = 0; i < max_slots; ++i) | ||
| 4530 | slot[i].seq_nr = ivalue; | ||
| 4531 | ret = 0; | 4560 | ret = 0; |
| 4532 | 4561 | ||
| 4533 | spin_lock(&tbl->slot_tbl_lock); | 4562 | spin_lock(&tbl->slot_tbl_lock); |
| 4534 | if (tbl->slots != NULL) { | ||
| 4535 | spin_unlock(&tbl->slot_tbl_lock); | ||
| 4536 | dprintk("%s: slot table already initialized. tbl=%p slots=%p\n", | ||
| 4537 | __func__, tbl, tbl->slots); | ||
| 4538 | WARN_ON(1); | ||
| 4539 | goto out_free; | ||
| 4540 | } | ||
| 4541 | tbl->max_slots = max_slots; | 4563 | tbl->max_slots = max_slots; |
| 4542 | tbl->slots = slot; | 4564 | tbl->slots = slot; |
| 4543 | tbl->highest_used_slotid = -1; /* no slot is currently used */ | 4565 | tbl->highest_used_slotid = -1; /* no slot is currently used */ |
| @@ -4547,10 +4569,6 @@ static int nfs4_init_slot_table(struct nfs4_slot_table *tbl, | |||
| 4547 | out: | 4569 | out: |
| 4548 | dprintk("<-- %s: return %d\n", __func__, ret); | 4570 | dprintk("<-- %s: return %d\n", __func__, ret); |
| 4549 | return ret; | 4571 | return ret; |
| 4550 | |||
| 4551 | out_free: | ||
| 4552 | kfree(slot); | ||
| 4553 | goto out; | ||
| 4554 | } | 4572 | } |
| 4555 | 4573 | ||
| 4556 | /* | 4574 | /* |
| @@ -4558,17 +4576,24 @@ out_free: | |||
| 4558 | */ | 4576 | */ |
| 4559 | static int nfs4_init_slot_tables(struct nfs4_session *session) | 4577 | static int nfs4_init_slot_tables(struct nfs4_session *session) |
| 4560 | { | 4578 | { |
| 4561 | int status; | 4579 | struct nfs4_slot_table *tbl; |
| 4580 | int status = 0; | ||
| 4562 | 4581 | ||
| 4563 | status = nfs4_init_slot_table(&session->fc_slot_table, | 4582 | tbl = &session->fc_slot_table; |
| 4564 | session->fc_attrs.max_reqs, 1); | 4583 | if (tbl->slots == NULL) { |
| 4565 | if (status) | 4584 | status = nfs4_init_slot_table(tbl, |
| 4566 | return status; | 4585 | session->fc_attrs.max_reqs, 1); |
| 4586 | if (status) | ||
| 4587 | return status; | ||
| 4588 | } | ||
| 4567 | 4589 | ||
| 4568 | status = nfs4_init_slot_table(&session->bc_slot_table, | 4590 | tbl = &session->bc_slot_table; |
| 4569 | session->bc_attrs.max_reqs, 0); | 4591 | if (tbl->slots == NULL) { |
| 4570 | if (status) | 4592 | status = nfs4_init_slot_table(tbl, |
| 4571 | nfs4_destroy_slot_tables(session); | 4593 | session->bc_attrs.max_reqs, 0); |
| 4594 | if (status) | ||
| 4595 | nfs4_destroy_slot_tables(session); | ||
| 4596 | } | ||
| 4572 | 4597 | ||
| 4573 | return status; | 4598 | return status; |
| 4574 | } | 4599 | } |
| @@ -4582,7 +4607,6 @@ struct nfs4_session *nfs4_alloc_session(struct nfs_client *clp) | |||
| 4582 | if (!session) | 4607 | if (!session) |
| 4583 | return NULL; | 4608 | return NULL; |
| 4584 | 4609 | ||
| 4585 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | ||
| 4586 | /* | 4610 | /* |
| 4587 | * The create session reply races with the server back | 4611 | * The create session reply races with the server back |
| 4588 | * channel probe. Mark the client NFS_CS_SESSION_INITING | 4612 | * channel probe. Mark the client NFS_CS_SESSION_INITING |
| @@ -4590,12 +4614,15 @@ struct nfs4_session *nfs4_alloc_session(struct nfs_client *clp) | |||
| 4590 | * nfs_client struct | 4614 | * nfs_client struct |
| 4591 | */ | 4615 | */ |
| 4592 | clp->cl_cons_state = NFS_CS_SESSION_INITING; | 4616 | clp->cl_cons_state = NFS_CS_SESSION_INITING; |
| 4617 | init_completion(&session->complete); | ||
| 4593 | 4618 | ||
| 4594 | tbl = &session->fc_slot_table; | 4619 | tbl = &session->fc_slot_table; |
| 4620 | tbl->highest_used_slotid = -1; | ||
| 4595 | spin_lock_init(&tbl->slot_tbl_lock); | 4621 | spin_lock_init(&tbl->slot_tbl_lock); |
| 4596 | rpc_init_wait_queue(&tbl->slot_tbl_waitq, "ForeChannel Slot table"); | 4622 | rpc_init_wait_queue(&tbl->slot_tbl_waitq, "ForeChannel Slot table"); |
| 4597 | 4623 | ||
| 4598 | tbl = &session->bc_slot_table; | 4624 | tbl = &session->bc_slot_table; |
| 4625 | tbl->highest_used_slotid = -1; | ||
| 4599 | spin_lock_init(&tbl->slot_tbl_lock); | 4626 | spin_lock_init(&tbl->slot_tbl_lock); |
| 4600 | rpc_init_wait_queue(&tbl->slot_tbl_waitq, "BackChannel Slot table"); | 4627 | rpc_init_wait_queue(&tbl->slot_tbl_waitq, "BackChannel Slot table"); |
| 4601 | 4628 | ||
| @@ -4747,11 +4774,10 @@ static int _nfs4_proc_create_session(struct nfs_client *clp) | |||
| 4747 | * It is the responsibility of the caller to verify the session is | 4774 | * It is the responsibility of the caller to verify the session is |
| 4748 | * expired before calling this routine. | 4775 | * expired before calling this routine. |
| 4749 | */ | 4776 | */ |
| 4750 | int nfs4_proc_create_session(struct nfs_client *clp, int reset) | 4777 | int nfs4_proc_create_session(struct nfs_client *clp) |
| 4751 | { | 4778 | { |
| 4752 | int status; | 4779 | int status; |
| 4753 | unsigned *ptr; | 4780 | unsigned *ptr; |
| 4754 | struct nfs_fsinfo fsinfo; | ||
| 4755 | struct nfs4_session *session = clp->cl_session; | 4781 | struct nfs4_session *session = clp->cl_session; |
| 4756 | 4782 | ||
| 4757 | dprintk("--> %s clp=%p session=%p\n", __func__, clp, session); | 4783 | dprintk("--> %s clp=%p session=%p\n", __func__, clp, session); |
| @@ -4760,35 +4786,19 @@ int nfs4_proc_create_session(struct nfs_client *clp, int reset) | |||
| 4760 | if (status) | 4786 | if (status) |
| 4761 | goto out; | 4787 | goto out; |
| 4762 | 4788 | ||
| 4763 | /* Init or reset the fore channel */ | 4789 | /* Init and reset the fore channel */ |
| 4764 | if (reset) | 4790 | status = nfs4_init_slot_tables(session); |
| 4765 | status = nfs4_reset_slot_tables(session); | 4791 | dprintk("slot table initialization returned %d\n", status); |
| 4766 | else | 4792 | if (status) |
| 4767 | status = nfs4_init_slot_tables(session); | 4793 | goto out; |
| 4768 | dprintk("fore channel slot table initialization returned %d\n", status); | 4794 | status = nfs4_reset_slot_tables(session); |
| 4795 | dprintk("slot table reset returned %d\n", status); | ||
| 4769 | if (status) | 4796 | if (status) |
| 4770 | goto out; | 4797 | goto out; |
| 4771 | 4798 | ||
| 4772 | ptr = (unsigned *)&session->sess_id.data[0]; | 4799 | ptr = (unsigned *)&session->sess_id.data[0]; |
| 4773 | dprintk("%s client>seqid %d sessionid %u:%u:%u:%u\n", __func__, | 4800 | dprintk("%s client>seqid %d sessionid %u:%u:%u:%u\n", __func__, |
| 4774 | clp->cl_seqid, ptr[0], ptr[1], ptr[2], ptr[3]); | 4801 | clp->cl_seqid, ptr[0], ptr[1], ptr[2], ptr[3]); |
| 4775 | |||
| 4776 | if (reset) | ||
| 4777 | /* Lease time is aleady set */ | ||
| 4778 | goto out; | ||
| 4779 | |||
| 4780 | /* Get the lease time */ | ||
| 4781 | status = nfs4_proc_get_lease_time(clp, &fsinfo); | ||
| 4782 | if (status == 0) { | ||
| 4783 | /* Update lease time and schedule renewal */ | ||
| 4784 | spin_lock(&clp->cl_lock); | ||
| 4785 | clp->cl_lease_time = fsinfo.lease_time * HZ; | ||
| 4786 | clp->cl_last_renewal = jiffies; | ||
| 4787 | clear_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | ||
| 4788 | spin_unlock(&clp->cl_lock); | ||
| 4789 | |||
| 4790 | nfs4_schedule_state_renewal(clp); | ||
| 4791 | } | ||
| 4792 | out: | 4802 | out: |
| 4793 | dprintk("<-- %s\n", __func__); | 4803 | dprintk("<-- %s\n", __func__); |
| 4794 | return status; | 4804 | return status; |
| @@ -4827,13 +4837,16 @@ int nfs4_proc_destroy_session(struct nfs4_session *session) | |||
| 4827 | int nfs4_init_session(struct nfs_server *server) | 4837 | int nfs4_init_session(struct nfs_server *server) |
| 4828 | { | 4838 | { |
| 4829 | struct nfs_client *clp = server->nfs_client; | 4839 | struct nfs_client *clp = server->nfs_client; |
| 4840 | struct nfs4_session *session; | ||
| 4830 | int ret; | 4841 | int ret; |
| 4831 | 4842 | ||
| 4832 | if (!nfs4_has_session(clp)) | 4843 | if (!nfs4_has_session(clp)) |
| 4833 | return 0; | 4844 | return 0; |
| 4834 | 4845 | ||
| 4835 | clp->cl_session->fc_attrs.max_rqst_sz = server->wsize; | 4846 | session = clp->cl_session; |
| 4836 | clp->cl_session->fc_attrs.max_resp_sz = server->rsize; | 4847 | session->fc_attrs.max_rqst_sz = server->wsize + nfs41_maxwrite_overhead; |
| 4848 | session->fc_attrs.max_resp_sz = server->rsize + nfs41_maxread_overhead; | ||
| 4849 | |||
| 4837 | ret = nfs4_recover_expired_lease(server); | 4850 | ret = nfs4_recover_expired_lease(server); |
| 4838 | if (!ret) | 4851 | if (!ret) |
| 4839 | ret = nfs4_check_client_ready(clp); | 4852 | ret = nfs4_check_client_ready(clp); |
| @@ -4872,11 +4885,10 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data) | |||
| 4872 | 4885 | ||
| 4873 | if (_nfs4_async_handle_error(task, NULL, clp, NULL) | 4886 | if (_nfs4_async_handle_error(task, NULL, clp, NULL) |
| 4874 | == -EAGAIN) { | 4887 | == -EAGAIN) { |
| 4875 | nfs4_restart_rpc(task, clp); | 4888 | nfs_restart_rpc(task, clp); |
| 4876 | return; | 4889 | return; |
| 4877 | } | 4890 | } |
| 4878 | } | 4891 | } |
| 4879 | nfs41_sequence_free_slot(clp, task->tk_msg.rpc_resp); | ||
| 4880 | dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred); | 4892 | dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred); |
| 4881 | 4893 | ||
| 4882 | kfree(task->tk_msg.rpc_argp); | 4894 | kfree(task->tk_msg.rpc_argp); |
| @@ -4931,6 +4943,109 @@ static int nfs41_proc_async_sequence(struct nfs_client *clp, | |||
| 4931 | &nfs41_sequence_ops, (void *)clp); | 4943 | &nfs41_sequence_ops, (void *)clp); |
| 4932 | } | 4944 | } |
| 4933 | 4945 | ||
| 4946 | struct nfs4_reclaim_complete_data { | ||
| 4947 | struct nfs_client *clp; | ||
| 4948 | struct nfs41_reclaim_complete_args arg; | ||
| 4949 | struct nfs41_reclaim_complete_res res; | ||
| 4950 | }; | ||
| 4951 | |||
| 4952 | static void nfs4_reclaim_complete_prepare(struct rpc_task *task, void *data) | ||
| 4953 | { | ||
| 4954 | struct nfs4_reclaim_complete_data *calldata = data; | ||
| 4955 | |||
| 4956 | if (nfs4_setup_sequence(calldata->clp, &calldata->arg.seq_args, | ||
| 4957 | &calldata->res.seq_res, 0, task)) | ||
| 4958 | return; | ||
| 4959 | |||
| 4960 | rpc_call_start(task); | ||
| 4961 | } | ||
| 4962 | |||
| 4963 | static void nfs4_reclaim_complete_done(struct rpc_task *task, void *data) | ||
| 4964 | { | ||
| 4965 | struct nfs4_reclaim_complete_data *calldata = data; | ||
| 4966 | struct nfs_client *clp = calldata->clp; | ||
| 4967 | struct nfs4_sequence_res *res = &calldata->res.seq_res; | ||
| 4968 | |||
| 4969 | dprintk("--> %s\n", __func__); | ||
| 4970 | nfs41_sequence_done(clp, res, task->tk_status); | ||
| 4971 | switch (task->tk_status) { | ||
| 4972 | case 0: | ||
| 4973 | case -NFS4ERR_COMPLETE_ALREADY: | ||
| 4974 | break; | ||
| 4975 | case -NFS4ERR_BADSESSION: | ||
| 4976 | case -NFS4ERR_DEADSESSION: | ||
| 4977 | /* | ||
| 4978 | * Handle the session error, but do not retry the operation, as | ||
| 4979 | * we have no way of telling whether the clientid had to be | ||
| 4980 | * reset before we got our reply. If reset, a new wave of | ||
| 4981 | * reclaim operations will follow, containing their own reclaim | ||
| 4982 | * complete. We don't want our retry to get on the way of | ||
| 4983 | * recovery by incorrectly indicating to the server that we're | ||
| 4984 | * done reclaiming state since the process had to be restarted. | ||
| 4985 | */ | ||
| 4986 | _nfs4_async_handle_error(task, NULL, clp, NULL); | ||
| 4987 | break; | ||
| 4988 | default: | ||
| 4989 | if (_nfs4_async_handle_error( | ||
| 4990 | task, NULL, clp, NULL) == -EAGAIN) { | ||
| 4991 | rpc_restart_call_prepare(task); | ||
| 4992 | return; | ||
| 4993 | } | ||
| 4994 | } | ||
| 4995 | |||
| 4996 | dprintk("<-- %s\n", __func__); | ||
| 4997 | } | ||
| 4998 | |||
| 4999 | static void nfs4_free_reclaim_complete_data(void *data) | ||
| 5000 | { | ||
| 5001 | struct nfs4_reclaim_complete_data *calldata = data; | ||
| 5002 | |||
| 5003 | kfree(calldata); | ||
| 5004 | } | ||
| 5005 | |||
| 5006 | static const struct rpc_call_ops nfs4_reclaim_complete_call_ops = { | ||
| 5007 | .rpc_call_prepare = nfs4_reclaim_complete_prepare, | ||
| 5008 | .rpc_call_done = nfs4_reclaim_complete_done, | ||
| 5009 | .rpc_release = nfs4_free_reclaim_complete_data, | ||
| 5010 | }; | ||
| 5011 | |||
| 5012 | /* | ||
| 5013 | * Issue a global reclaim complete. | ||
| 5014 | */ | ||
| 5015 | static int nfs41_proc_reclaim_complete(struct nfs_client *clp) | ||
| 5016 | { | ||
| 5017 | struct nfs4_reclaim_complete_data *calldata; | ||
| 5018 | struct rpc_task *task; | ||
| 5019 | struct rpc_message msg = { | ||
| 5020 | .rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RECLAIM_COMPLETE], | ||
| 5021 | }; | ||
| 5022 | struct rpc_task_setup task_setup_data = { | ||
| 5023 | .rpc_client = clp->cl_rpcclient, | ||
| 5024 | .rpc_message = &msg, | ||
| 5025 | .callback_ops = &nfs4_reclaim_complete_call_ops, | ||
| 5026 | .flags = RPC_TASK_ASYNC, | ||
| 5027 | }; | ||
| 5028 | int status = -ENOMEM; | ||
| 5029 | |||
| 5030 | dprintk("--> %s\n", __func__); | ||
| 5031 | calldata = kzalloc(sizeof(*calldata), GFP_KERNEL); | ||
| 5032 | if (calldata == NULL) | ||
| 5033 | goto out; | ||
| 5034 | calldata->clp = clp; | ||
| 5035 | calldata->arg.one_fs = 0; | ||
| 5036 | calldata->res.seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; | ||
| 5037 | |||
| 5038 | msg.rpc_argp = &calldata->arg; | ||
| 5039 | msg.rpc_resp = &calldata->res; | ||
| 5040 | task_setup_data.callback_data = calldata; | ||
| 5041 | task = rpc_run_task(&task_setup_data); | ||
| 5042 | if (IS_ERR(task)) | ||
| 5043 | status = PTR_ERR(task); | ||
| 5044 | rpc_put_task(task); | ||
| 5045 | out: | ||
| 5046 | dprintk("<-- %s status=%d\n", __func__, status); | ||
| 5047 | return status; | ||
| 5048 | } | ||
| 4934 | #endif /* CONFIG_NFS_V4_1 */ | 5049 | #endif /* CONFIG_NFS_V4_1 */ |
| 4935 | 5050 | ||
| 4936 | struct nfs4_state_recovery_ops nfs40_reboot_recovery_ops = { | 5051 | struct nfs4_state_recovery_ops nfs40_reboot_recovery_ops = { |
| @@ -4948,8 +5063,9 @@ struct nfs4_state_recovery_ops nfs41_reboot_recovery_ops = { | |||
| 4948 | .state_flag_bit = NFS_STATE_RECLAIM_REBOOT, | 5063 | .state_flag_bit = NFS_STATE_RECLAIM_REBOOT, |
| 4949 | .recover_open = nfs4_open_reclaim, | 5064 | .recover_open = nfs4_open_reclaim, |
| 4950 | .recover_lock = nfs4_lock_reclaim, | 5065 | .recover_lock = nfs4_lock_reclaim, |
| 4951 | .establish_clid = nfs4_proc_exchange_id, | 5066 | .establish_clid = nfs41_init_clientid, |
| 4952 | .get_clid_cred = nfs4_get_exchange_id_cred, | 5067 | .get_clid_cred = nfs4_get_exchange_id_cred, |
| 5068 | .reclaim_complete = nfs41_proc_reclaim_complete, | ||
| 4953 | }; | 5069 | }; |
| 4954 | #endif /* CONFIG_NFS_V4_1 */ | 5070 | #endif /* CONFIG_NFS_V4_1 */ |
| 4955 | 5071 | ||
| @@ -4968,7 +5084,7 @@ struct nfs4_state_recovery_ops nfs41_nograce_recovery_ops = { | |||
| 4968 | .state_flag_bit = NFS_STATE_RECLAIM_NOGRACE, | 5084 | .state_flag_bit = NFS_STATE_RECLAIM_NOGRACE, |
| 4969 | .recover_open = nfs4_open_expired, | 5085 | .recover_open = nfs4_open_expired, |
| 4970 | .recover_lock = nfs4_lock_expired, | 5086 | .recover_lock = nfs4_lock_expired, |
| 4971 | .establish_clid = nfs4_proc_exchange_id, | 5087 | .establish_clid = nfs41_init_clientid, |
| 4972 | .get_clid_cred = nfs4_get_exchange_id_cred, | 5088 | .get_clid_cred = nfs4_get_exchange_id_cred, |
| 4973 | }; | 5089 | }; |
| 4974 | #endif /* CONFIG_NFS_V4_1 */ | 5090 | #endif /* CONFIG_NFS_V4_1 */ |
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 2ef4fecf3984..e76427e6346f 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c | |||
| @@ -116,6 +116,68 @@ struct rpc_cred *nfs4_get_renew_cred_locked(struct nfs_client *clp) | |||
| 116 | 116 | ||
| 117 | #if defined(CONFIG_NFS_V4_1) | 117 | #if defined(CONFIG_NFS_V4_1) |
| 118 | 118 | ||
| 119 | static int nfs41_setup_state_renewal(struct nfs_client *clp) | ||
| 120 | { | ||
| 121 | int status; | ||
| 122 | struct nfs_fsinfo fsinfo; | ||
| 123 | |||
| 124 | status = nfs4_proc_get_lease_time(clp, &fsinfo); | ||
| 125 | if (status == 0) { | ||
| 126 | /* Update lease time and schedule renewal */ | ||
| 127 | spin_lock(&clp->cl_lock); | ||
| 128 | clp->cl_lease_time = fsinfo.lease_time * HZ; | ||
| 129 | clp->cl_last_renewal = jiffies; | ||
| 130 | spin_unlock(&clp->cl_lock); | ||
| 131 | |||
| 132 | nfs4_schedule_state_renewal(clp); | ||
| 133 | } | ||
| 134 | |||
| 135 | return status; | ||
| 136 | } | ||
| 137 | |||
| 138 | static void nfs41_end_drain_session(struct nfs_client *clp, | ||
| 139 | struct nfs4_session *ses) | ||
| 140 | { | ||
| 141 | if (test_and_clear_bit(NFS4CLNT_SESSION_DRAINING, &clp->cl_state)) | ||
| 142 | rpc_wake_up(&ses->fc_slot_table.slot_tbl_waitq); | ||
| 143 | } | ||
| 144 | |||
| 145 | static int nfs41_begin_drain_session(struct nfs_client *clp, | ||
| 146 | struct nfs4_session *ses) | ||
| 147 | { | ||
| 148 | struct nfs4_slot_table *tbl = &ses->fc_slot_table; | ||
| 149 | |||
| 150 | spin_lock(&tbl->slot_tbl_lock); | ||
| 151 | set_bit(NFS4CLNT_SESSION_DRAINING, &clp->cl_state); | ||
| 152 | if (tbl->highest_used_slotid != -1) { | ||
| 153 | INIT_COMPLETION(ses->complete); | ||
| 154 | spin_unlock(&tbl->slot_tbl_lock); | ||
| 155 | return wait_for_completion_interruptible(&ses->complete); | ||
| 156 | } | ||
| 157 | spin_unlock(&tbl->slot_tbl_lock); | ||
| 158 | return 0; | ||
| 159 | } | ||
| 160 | |||
| 161 | int nfs41_init_clientid(struct nfs_client *clp, struct rpc_cred *cred) | ||
| 162 | { | ||
| 163 | int status; | ||
| 164 | |||
| 165 | status = nfs41_begin_drain_session(clp, clp->cl_session); | ||
| 166 | if (status != 0) | ||
| 167 | goto out; | ||
| 168 | status = nfs4_proc_exchange_id(clp, cred); | ||
| 169 | if (status != 0) | ||
| 170 | goto out; | ||
| 171 | status = nfs4_proc_create_session(clp); | ||
| 172 | if (status != 0) | ||
| 173 | goto out; | ||
| 174 | nfs41_end_drain_session(clp, clp->cl_session); | ||
| 175 | nfs41_setup_state_renewal(clp); | ||
| 176 | nfs_mark_client_ready(clp, NFS_CS_READY); | ||
| 177 | out: | ||
| 178 | return status; | ||
| 179 | } | ||
| 180 | |||
| 119 | struct rpc_cred *nfs4_get_exchange_id_cred(struct nfs_client *clp) | 181 | struct rpc_cred *nfs4_get_exchange_id_cred(struct nfs_client *clp) |
| 120 | { | 182 | { |
| 121 | struct rpc_cred *cred; | 183 | struct rpc_cred *cred; |
| @@ -877,6 +939,10 @@ static int nfs4_reclaim_locks(struct nfs4_state *state, const struct nfs4_state_ | |||
| 877 | case -NFS4ERR_EXPIRED: | 939 | case -NFS4ERR_EXPIRED: |
| 878 | case -NFS4ERR_NO_GRACE: | 940 | case -NFS4ERR_NO_GRACE: |
| 879 | case -NFS4ERR_STALE_CLIENTID: | 941 | case -NFS4ERR_STALE_CLIENTID: |
| 942 | case -NFS4ERR_BADSESSION: | ||
| 943 | case -NFS4ERR_BADSLOT: | ||
| 944 | case -NFS4ERR_BAD_HIGH_SLOT: | ||
| 945 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: | ||
| 880 | goto out; | 946 | goto out; |
| 881 | default: | 947 | default: |
| 882 | printk(KERN_ERR "%s: unhandled error %d. Zeroing state\n", | 948 | printk(KERN_ERR "%s: unhandled error %d. Zeroing state\n", |
| @@ -959,6 +1025,10 @@ restart: | |||
| 959 | case -NFS4ERR_NO_GRACE: | 1025 | case -NFS4ERR_NO_GRACE: |
| 960 | nfs4_state_mark_reclaim_nograce(sp->so_client, state); | 1026 | nfs4_state_mark_reclaim_nograce(sp->so_client, state); |
| 961 | case -NFS4ERR_STALE_CLIENTID: | 1027 | case -NFS4ERR_STALE_CLIENTID: |
| 1028 | case -NFS4ERR_BADSESSION: | ||
| 1029 | case -NFS4ERR_BADSLOT: | ||
| 1030 | case -NFS4ERR_BAD_HIGH_SLOT: | ||
| 1031 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: | ||
| 962 | goto out_err; | 1032 | goto out_err; |
| 963 | } | 1033 | } |
| 964 | nfs4_put_open_state(state); | 1034 | nfs4_put_open_state(state); |
| @@ -1011,6 +1081,14 @@ static void nfs4_state_start_reclaim_reboot(struct nfs_client *clp) | |||
| 1011 | nfs4_state_mark_reclaim_helper(clp, nfs4_state_mark_reclaim_reboot); | 1081 | nfs4_state_mark_reclaim_helper(clp, nfs4_state_mark_reclaim_reboot); |
| 1012 | } | 1082 | } |
| 1013 | 1083 | ||
| 1084 | static void nfs4_reclaim_complete(struct nfs_client *clp, | ||
| 1085 | const struct nfs4_state_recovery_ops *ops) | ||
| 1086 | { | ||
| 1087 | /* Notify the server we're done reclaiming our state */ | ||
| 1088 | if (ops->reclaim_complete) | ||
| 1089 | (void)ops->reclaim_complete(clp); | ||
| 1090 | } | ||
| 1091 | |||
| 1014 | static void nfs4_state_end_reclaim_reboot(struct nfs_client *clp) | 1092 | static void nfs4_state_end_reclaim_reboot(struct nfs_client *clp) |
| 1015 | { | 1093 | { |
| 1016 | struct nfs4_state_owner *sp; | 1094 | struct nfs4_state_owner *sp; |
| @@ -1020,6 +1098,9 @@ static void nfs4_state_end_reclaim_reboot(struct nfs_client *clp) | |||
| 1020 | if (!test_and_clear_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) | 1098 | if (!test_and_clear_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) |
| 1021 | return; | 1099 | return; |
| 1022 | 1100 | ||
| 1101 | nfs4_reclaim_complete(clp, | ||
| 1102 | nfs4_reboot_recovery_ops[clp->cl_minorversion]); | ||
| 1103 | |||
| 1023 | for (pos = rb_first(&clp->cl_state_owners); pos != NULL; pos = rb_next(pos)) { | 1104 | for (pos = rb_first(&clp->cl_state_owners); pos != NULL; pos = rb_next(pos)) { |
| 1024 | sp = rb_entry(pos, struct nfs4_state_owner, so_client_node); | 1105 | sp = rb_entry(pos, struct nfs4_state_owner, so_client_node); |
| 1025 | spin_lock(&sp->so_lock); | 1106 | spin_lock(&sp->so_lock); |
| @@ -1046,25 +1127,25 @@ static void nfs4_state_start_reclaim_nograce(struct nfs_client *clp) | |||
| 1046 | nfs4_state_mark_reclaim_helper(clp, nfs4_state_mark_reclaim_nograce); | 1127 | nfs4_state_mark_reclaim_helper(clp, nfs4_state_mark_reclaim_nograce); |
| 1047 | } | 1128 | } |
| 1048 | 1129 | ||
| 1049 | static void nfs4_state_end_reclaim_nograce(struct nfs_client *clp) | 1130 | static int nfs4_recovery_handle_error(struct nfs_client *clp, int error) |
| 1050 | { | ||
| 1051 | clear_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state); | ||
| 1052 | } | ||
| 1053 | |||
| 1054 | static void nfs4_recovery_handle_error(struct nfs_client *clp, int error) | ||
| 1055 | { | 1131 | { |
| 1056 | switch (error) { | 1132 | switch (error) { |
| 1057 | case -NFS4ERR_CB_PATH_DOWN: | 1133 | case -NFS4ERR_CB_PATH_DOWN: |
| 1058 | nfs_handle_cb_pathdown(clp); | 1134 | nfs_handle_cb_pathdown(clp); |
| 1059 | break; | 1135 | return 0; |
| 1136 | case -NFS4ERR_NO_GRACE: | ||
| 1137 | nfs4_state_end_reclaim_reboot(clp); | ||
| 1138 | return 0; | ||
| 1060 | case -NFS4ERR_STALE_CLIENTID: | 1139 | case -NFS4ERR_STALE_CLIENTID: |
| 1061 | case -NFS4ERR_LEASE_MOVED: | 1140 | case -NFS4ERR_LEASE_MOVED: |
| 1062 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1141 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); |
| 1142 | nfs4_state_end_reclaim_reboot(clp); | ||
| 1063 | nfs4_state_start_reclaim_reboot(clp); | 1143 | nfs4_state_start_reclaim_reboot(clp); |
| 1064 | break; | 1144 | break; |
| 1065 | case -NFS4ERR_EXPIRED: | 1145 | case -NFS4ERR_EXPIRED: |
| 1066 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1146 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); |
| 1067 | nfs4_state_start_reclaim_nograce(clp); | 1147 | nfs4_state_start_reclaim_nograce(clp); |
| 1148 | break; | ||
| 1068 | case -NFS4ERR_BADSESSION: | 1149 | case -NFS4ERR_BADSESSION: |
| 1069 | case -NFS4ERR_BADSLOT: | 1150 | case -NFS4ERR_BADSLOT: |
| 1070 | case -NFS4ERR_BAD_HIGH_SLOT: | 1151 | case -NFS4ERR_BAD_HIGH_SLOT: |
| @@ -1072,8 +1153,11 @@ static void nfs4_recovery_handle_error(struct nfs_client *clp, int error) | |||
| 1072 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: | 1153 | case -NFS4ERR_CONN_NOT_BOUND_TO_SESSION: |
| 1073 | case -NFS4ERR_SEQ_FALSE_RETRY: | 1154 | case -NFS4ERR_SEQ_FALSE_RETRY: |
| 1074 | case -NFS4ERR_SEQ_MISORDERED: | 1155 | case -NFS4ERR_SEQ_MISORDERED: |
| 1075 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | 1156 | set_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state); |
| 1157 | /* Zero session reset errors */ | ||
| 1158 | return 0; | ||
| 1076 | } | 1159 | } |
| 1160 | return error; | ||
| 1077 | } | 1161 | } |
| 1078 | 1162 | ||
| 1079 | static int nfs4_do_reclaim(struct nfs_client *clp, const struct nfs4_state_recovery_ops *ops) | 1163 | static int nfs4_do_reclaim(struct nfs_client *clp, const struct nfs4_state_recovery_ops *ops) |
| @@ -1093,8 +1177,7 @@ restart: | |||
| 1093 | if (status < 0) { | 1177 | if (status < 0) { |
| 1094 | set_bit(ops->owner_flag_bit, &sp->so_flags); | 1178 | set_bit(ops->owner_flag_bit, &sp->so_flags); |
| 1095 | nfs4_put_state_owner(sp); | 1179 | nfs4_put_state_owner(sp); |
| 1096 | nfs4_recovery_handle_error(clp, status); | 1180 | return nfs4_recovery_handle_error(clp, status); |
| 1097 | return status; | ||
| 1098 | } | 1181 | } |
| 1099 | nfs4_put_state_owner(sp); | 1182 | nfs4_put_state_owner(sp); |
| 1100 | goto restart; | 1183 | goto restart; |
| @@ -1124,8 +1207,7 @@ static int nfs4_check_lease(struct nfs_client *clp) | |||
| 1124 | status = ops->renew_lease(clp, cred); | 1207 | status = ops->renew_lease(clp, cred); |
| 1125 | put_rpccred(cred); | 1208 | put_rpccred(cred); |
| 1126 | out: | 1209 | out: |
| 1127 | nfs4_recovery_handle_error(clp, status); | 1210 | return nfs4_recovery_handle_error(clp, status); |
| 1128 | return status; | ||
| 1129 | } | 1211 | } |
| 1130 | 1212 | ||
| 1131 | static int nfs4_reclaim_lease(struct nfs_client *clp) | 1213 | static int nfs4_reclaim_lease(struct nfs_client *clp) |
| @@ -1151,55 +1233,65 @@ static int nfs4_reclaim_lease(struct nfs_client *clp) | |||
| 1151 | } | 1233 | } |
| 1152 | 1234 | ||
| 1153 | #ifdef CONFIG_NFS_V4_1 | 1235 | #ifdef CONFIG_NFS_V4_1 |
| 1154 | static void nfs4_session_recovery_handle_error(struct nfs_client *clp, int err) | 1236 | void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags) |
| 1155 | { | 1237 | { |
| 1156 | switch (err) { | 1238 | if (!flags) |
| 1157 | case -NFS4ERR_STALE_CLIENTID: | 1239 | return; |
| 1240 | else if (flags & SEQ4_STATUS_RESTART_RECLAIM_NEEDED) { | ||
| 1158 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1241 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); |
| 1159 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | 1242 | nfs4_state_start_reclaim_reboot(clp); |
| 1160 | } | 1243 | nfs4_schedule_state_recovery(clp); |
| 1244 | } else if (flags & (SEQ4_STATUS_EXPIRED_ALL_STATE_REVOKED | | ||
| 1245 | SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED | | ||
| 1246 | SEQ4_STATUS_ADMIN_STATE_REVOKED | | ||
| 1247 | SEQ4_STATUS_RECALLABLE_STATE_REVOKED | | ||
| 1248 | SEQ4_STATUS_LEASE_MOVED)) { | ||
| 1249 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | ||
| 1250 | nfs4_state_start_reclaim_nograce(clp); | ||
| 1251 | nfs4_schedule_state_recovery(clp); | ||
| 1252 | } else if (flags & (SEQ4_STATUS_CB_PATH_DOWN | | ||
| 1253 | SEQ4_STATUS_BACKCHANNEL_FAULT | | ||
| 1254 | SEQ4_STATUS_CB_PATH_DOWN_SESSION)) | ||
| 1255 | nfs_expire_all_delegations(clp); | ||
| 1161 | } | 1256 | } |
| 1162 | 1257 | ||
| 1163 | static int nfs4_reset_session(struct nfs_client *clp) | 1258 | static int nfs4_reset_session(struct nfs_client *clp) |
| 1164 | { | 1259 | { |
| 1260 | struct nfs4_session *ses = clp->cl_session; | ||
| 1165 | int status; | 1261 | int status; |
| 1166 | 1262 | ||
| 1263 | status = nfs41_begin_drain_session(clp, ses); | ||
| 1264 | if (status != 0) | ||
| 1265 | return status; | ||
| 1266 | |||
| 1167 | status = nfs4_proc_destroy_session(clp->cl_session); | 1267 | status = nfs4_proc_destroy_session(clp->cl_session); |
| 1168 | if (status && status != -NFS4ERR_BADSESSION && | 1268 | if (status && status != -NFS4ERR_BADSESSION && |
| 1169 | status != -NFS4ERR_DEADSESSION) { | 1269 | status != -NFS4ERR_DEADSESSION) { |
| 1170 | nfs4_session_recovery_handle_error(clp, status); | 1270 | status = nfs4_recovery_handle_error(clp, status); |
| 1171 | goto out; | 1271 | goto out; |
| 1172 | } | 1272 | } |
| 1173 | 1273 | ||
| 1174 | memset(clp->cl_session->sess_id.data, 0, NFS4_MAX_SESSIONID_LEN); | 1274 | memset(clp->cl_session->sess_id.data, 0, NFS4_MAX_SESSIONID_LEN); |
| 1175 | status = nfs4_proc_create_session(clp, 1); | 1275 | status = nfs4_proc_create_session(clp); |
| 1176 | if (status) | 1276 | if (status) |
| 1177 | nfs4_session_recovery_handle_error(clp, status); | 1277 | status = nfs4_recovery_handle_error(clp, status); |
| 1178 | /* fall through*/ | ||
| 1179 | out: | ||
| 1180 | /* Wake up the next rpc task even on error */ | ||
| 1181 | rpc_wake_up_next(&clp->cl_session->fc_slot_table.slot_tbl_waitq); | ||
| 1182 | return status; | ||
| 1183 | } | ||
| 1184 | |||
| 1185 | static int nfs4_initialize_session(struct nfs_client *clp) | ||
| 1186 | { | ||
| 1187 | int status; | ||
| 1188 | 1278 | ||
| 1189 | status = nfs4_proc_create_session(clp, 0); | 1279 | out: |
| 1190 | if (!status) { | 1280 | /* |
| 1191 | nfs_mark_client_ready(clp, NFS_CS_READY); | 1281 | * Let the state manager reestablish state |
| 1192 | } else if (status == -NFS4ERR_STALE_CLIENTID) { | 1282 | * without waking other tasks yet. |
| 1193 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1283 | */ |
| 1194 | set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state); | 1284 | if (!test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) { |
| 1195 | } else { | 1285 | /* Wake up the next rpc task */ |
| 1196 | nfs_mark_client_ready(clp, status); | 1286 | nfs41_end_drain_session(clp, ses); |
| 1287 | if (status == 0) | ||
| 1288 | nfs41_setup_state_renewal(clp); | ||
| 1197 | } | 1289 | } |
| 1198 | return status; | 1290 | return status; |
| 1199 | } | 1291 | } |
| 1292 | |||
| 1200 | #else /* CONFIG_NFS_V4_1 */ | 1293 | #else /* CONFIG_NFS_V4_1 */ |
| 1201 | static int nfs4_reset_session(struct nfs_client *clp) { return 0; } | 1294 | static int nfs4_reset_session(struct nfs_client *clp) { return 0; } |
| 1202 | static int nfs4_initialize_session(struct nfs_client *clp) { return 0; } | ||
| 1203 | #endif /* CONFIG_NFS_V4_1 */ | 1295 | #endif /* CONFIG_NFS_V4_1 */ |
| 1204 | 1296 | ||
| 1205 | /* Set NFS4CLNT_LEASE_EXPIRED for all v4.0 errors and for recoverable errors | 1297 | /* Set NFS4CLNT_LEASE_EXPIRED for all v4.0 errors and for recoverable errors |
| @@ -1234,7 +1326,8 @@ static void nfs4_state_manager(struct nfs_client *clp) | |||
| 1234 | status = nfs4_reclaim_lease(clp); | 1326 | status = nfs4_reclaim_lease(clp); |
| 1235 | if (status) { | 1327 | if (status) { |
| 1236 | nfs4_set_lease_expired(clp, status); | 1328 | nfs4_set_lease_expired(clp, status); |
| 1237 | if (status == -EAGAIN) | 1329 | if (test_bit(NFS4CLNT_LEASE_EXPIRED, |
| 1330 | &clp->cl_state)) | ||
| 1238 | continue; | 1331 | continue; |
| 1239 | if (clp->cl_cons_state == | 1332 | if (clp->cl_cons_state == |
| 1240 | NFS_CS_SESSION_INITING) | 1333 | NFS_CS_SESSION_INITING) |
| @@ -1242,55 +1335,51 @@ static void nfs4_state_manager(struct nfs_client *clp) | |||
| 1242 | goto out_error; | 1335 | goto out_error; |
| 1243 | } | 1336 | } |
| 1244 | clear_bit(NFS4CLNT_CHECK_LEASE, &clp->cl_state); | 1337 | clear_bit(NFS4CLNT_CHECK_LEASE, &clp->cl_state); |
| 1338 | set_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state); | ||
| 1245 | } | 1339 | } |
| 1246 | 1340 | ||
| 1247 | if (test_and_clear_bit(NFS4CLNT_CHECK_LEASE, &clp->cl_state)) { | 1341 | if (test_and_clear_bit(NFS4CLNT_CHECK_LEASE, &clp->cl_state)) { |
| 1248 | status = nfs4_check_lease(clp); | 1342 | status = nfs4_check_lease(clp); |
| 1249 | if (status != 0) | 1343 | if (test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) |
| 1250 | continue; | 1344 | continue; |
| 1345 | if (status < 0 && status != -NFS4ERR_CB_PATH_DOWN) | ||
| 1346 | goto out_error; | ||
| 1251 | } | 1347 | } |
| 1348 | |||
| 1252 | /* Initialize or reset the session */ | 1349 | /* Initialize or reset the session */ |
| 1253 | if (test_and_clear_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state) | 1350 | if (test_and_clear_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state) |
| 1254 | && nfs4_has_session(clp)) { | 1351 | && nfs4_has_session(clp)) { |
| 1255 | if (clp->cl_cons_state == NFS_CS_SESSION_INITING) | 1352 | status = nfs4_reset_session(clp); |
| 1256 | status = nfs4_initialize_session(clp); | 1353 | if (test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) |
| 1257 | else | 1354 | continue; |
| 1258 | status = nfs4_reset_session(clp); | 1355 | if (status < 0) |
| 1259 | if (status) { | ||
| 1260 | if (status == -NFS4ERR_STALE_CLIENTID) | ||
| 1261 | continue; | ||
| 1262 | goto out_error; | 1356 | goto out_error; |
| 1263 | } | ||
| 1264 | } | 1357 | } |
| 1358 | |||
| 1265 | /* First recover reboot state... */ | 1359 | /* First recover reboot state... */ |
| 1266 | if (test_and_clear_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) { | 1360 | if (test_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) { |
| 1267 | status = nfs4_do_reclaim(clp, | 1361 | status = nfs4_do_reclaim(clp, |
| 1268 | nfs4_reboot_recovery_ops[clp->cl_minorversion]); | 1362 | nfs4_reboot_recovery_ops[clp->cl_minorversion]); |
| 1269 | if (status == -NFS4ERR_STALE_CLIENTID) | 1363 | if (test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state) || |
| 1270 | continue; | 1364 | test_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state)) |
| 1271 | if (test_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state)) | ||
| 1272 | continue; | 1365 | continue; |
| 1273 | nfs4_state_end_reclaim_reboot(clp); | 1366 | nfs4_state_end_reclaim_reboot(clp); |
| 1274 | continue; | 1367 | if (test_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state)) |
| 1368 | continue; | ||
| 1369 | if (status < 0) | ||
| 1370 | goto out_error; | ||
| 1275 | } | 1371 | } |
| 1276 | 1372 | ||
| 1277 | /* Now recover expired state... */ | 1373 | /* Now recover expired state... */ |
| 1278 | if (test_and_clear_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state)) { | 1374 | if (test_and_clear_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state)) { |
| 1279 | status = nfs4_do_reclaim(clp, | 1375 | status = nfs4_do_reclaim(clp, |
| 1280 | nfs4_nograce_recovery_ops[clp->cl_minorversion]); | 1376 | nfs4_nograce_recovery_ops[clp->cl_minorversion]); |
| 1281 | if (status < 0) { | 1377 | if (test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state) || |
| 1282 | set_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state); | 1378 | test_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state) || |
| 1283 | if (status == -NFS4ERR_STALE_CLIENTID) | 1379 | test_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) |
| 1284 | continue; | 1380 | continue; |
| 1285 | if (status == -NFS4ERR_EXPIRED) | 1381 | if (status < 0) |
| 1286 | continue; | ||
| 1287 | if (test_bit(NFS4CLNT_SESSION_SETUP, | ||
| 1288 | &clp->cl_state)) | ||
| 1289 | continue; | ||
| 1290 | goto out_error; | 1382 | goto out_error; |
| 1291 | } else | ||
| 1292 | nfs4_state_end_reclaim_nograce(clp); | ||
| 1293 | continue; | ||
| 1294 | } | 1383 | } |
| 1295 | 1384 | ||
| 1296 | if (test_and_clear_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state)) { | 1385 | if (test_and_clear_bit(NFS4CLNT_DELEGRETURN, &clp->cl_state)) { |
| @@ -1309,8 +1398,6 @@ static void nfs4_state_manager(struct nfs_client *clp) | |||
| 1309 | out_error: | 1398 | out_error: |
| 1310 | printk(KERN_WARNING "Error: state manager failed on NFSv4 server %s" | 1399 | printk(KERN_WARNING "Error: state manager failed on NFSv4 server %s" |
| 1311 | " with error %d\n", clp->cl_hostname, -status); | 1400 | " with error %d\n", clp->cl_hostname, -status); |
| 1312 | if (test_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) | ||
| 1313 | nfs4_state_end_reclaim_reboot(clp); | ||
| 1314 | nfs4_clear_state_manager_bit(clp); | 1401 | nfs4_clear_state_manager_bit(clp); |
| 1315 | } | 1402 | } |
| 1316 | 1403 | ||
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 20b4e30e6c82..e437fd6a819f 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c | |||
| @@ -46,11 +46,13 @@ | |||
| 46 | #include <linux/proc_fs.h> | 46 | #include <linux/proc_fs.h> |
| 47 | #include <linux/kdev_t.h> | 47 | #include <linux/kdev_t.h> |
| 48 | #include <linux/sunrpc/clnt.h> | 48 | #include <linux/sunrpc/clnt.h> |
| 49 | #include <linux/sunrpc/msg_prot.h> | ||
| 49 | #include <linux/nfs.h> | 50 | #include <linux/nfs.h> |
| 50 | #include <linux/nfs4.h> | 51 | #include <linux/nfs4.h> |
| 51 | #include <linux/nfs_fs.h> | 52 | #include <linux/nfs_fs.h> |
| 52 | #include <linux/nfs_idmap.h> | 53 | #include <linux/nfs_idmap.h> |
| 53 | #include "nfs4_fs.h" | 54 | #include "nfs4_fs.h" |
| 55 | #include "internal.h" | ||
| 54 | 56 | ||
| 55 | #define NFSDBG_FACILITY NFSDBG_XDR | 57 | #define NFSDBG_FACILITY NFSDBG_XDR |
| 56 | 58 | ||
| @@ -134,7 +136,7 @@ static int nfs4_stat_to_errno(int); | |||
| 134 | #define decode_lookup_maxsz (op_decode_hdr_maxsz) | 136 | #define decode_lookup_maxsz (op_decode_hdr_maxsz) |
| 135 | #define encode_share_access_maxsz \ | 137 | #define encode_share_access_maxsz \ |
| 136 | (2) | 138 | (2) |
| 137 | #define encode_createmode_maxsz (1 + encode_attrs_maxsz) | 139 | #define encode_createmode_maxsz (1 + encode_attrs_maxsz + encode_verifier_maxsz) |
| 138 | #define encode_opentype_maxsz (1 + encode_createmode_maxsz) | 140 | #define encode_opentype_maxsz (1 + encode_createmode_maxsz) |
| 139 | #define encode_claim_null_maxsz (1 + nfs4_name_maxsz) | 141 | #define encode_claim_null_maxsz (1 + nfs4_name_maxsz) |
| 140 | #define encode_open_maxsz (op_encode_hdr_maxsz + \ | 142 | #define encode_open_maxsz (op_encode_hdr_maxsz + \ |
| @@ -299,6 +301,8 @@ static int nfs4_stat_to_errno(int); | |||
| 299 | XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 4) | 301 | XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 4) |
| 300 | #define decode_sequence_maxsz (op_decode_hdr_maxsz + \ | 302 | #define decode_sequence_maxsz (op_decode_hdr_maxsz + \ |
| 301 | XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 5) | 303 | XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 5) |
| 304 | #define encode_reclaim_complete_maxsz (op_encode_hdr_maxsz + 4) | ||
| 305 | #define decode_reclaim_complete_maxsz (op_decode_hdr_maxsz + 4) | ||
| 302 | #else /* CONFIG_NFS_V4_1 */ | 306 | #else /* CONFIG_NFS_V4_1 */ |
| 303 | #define encode_sequence_maxsz 0 | 307 | #define encode_sequence_maxsz 0 |
| 304 | #define decode_sequence_maxsz 0 | 308 | #define decode_sequence_maxsz 0 |
| @@ -676,6 +680,25 @@ static int nfs4_stat_to_errno(int); | |||
| 676 | decode_sequence_maxsz + \ | 680 | decode_sequence_maxsz + \ |
| 677 | decode_putrootfh_maxsz + \ | 681 | decode_putrootfh_maxsz + \ |
| 678 | decode_fsinfo_maxsz) | 682 | decode_fsinfo_maxsz) |
| 683 | #define NFS4_enc_reclaim_complete_sz (compound_encode_hdr_maxsz + \ | ||
| 684 | encode_sequence_maxsz + \ | ||
| 685 | encode_reclaim_complete_maxsz) | ||
| 686 | #define NFS4_dec_reclaim_complete_sz (compound_decode_hdr_maxsz + \ | ||
| 687 | decode_sequence_maxsz + \ | ||
| 688 | decode_reclaim_complete_maxsz) | ||
| 689 | |||
| 690 | const u32 nfs41_maxwrite_overhead = ((RPC_MAX_HEADER_WITH_AUTH + | ||
| 691 | compound_encode_hdr_maxsz + | ||
| 692 | encode_sequence_maxsz + | ||
| 693 | encode_putfh_maxsz + | ||
| 694 | encode_getattr_maxsz) * | ||
| 695 | XDR_UNIT); | ||
| 696 | |||
| 697 | const u32 nfs41_maxread_overhead = ((RPC_MAX_HEADER_WITH_AUTH + | ||
| 698 | compound_decode_hdr_maxsz + | ||
| 699 | decode_sequence_maxsz + | ||
| 700 | decode_putfh_maxsz) * | ||
| 701 | XDR_UNIT); | ||
| 679 | #endif /* CONFIG_NFS_V4_1 */ | 702 | #endif /* CONFIG_NFS_V4_1 */ |
| 680 | 703 | ||
| 681 | static const umode_t nfs_type2fmt[] = { | 704 | static const umode_t nfs_type2fmt[] = { |
| @@ -1140,6 +1163,7 @@ static inline void encode_openhdr(struct xdr_stream *xdr, const struct nfs_opena | |||
| 1140 | static inline void encode_createmode(struct xdr_stream *xdr, const struct nfs_openargs *arg) | 1163 | static inline void encode_createmode(struct xdr_stream *xdr, const struct nfs_openargs *arg) |
| 1141 | { | 1164 | { |
| 1142 | __be32 *p; | 1165 | __be32 *p; |
| 1166 | struct nfs_client *clp; | ||
| 1143 | 1167 | ||
| 1144 | p = reserve_space(xdr, 4); | 1168 | p = reserve_space(xdr, 4); |
| 1145 | switch(arg->open_flags & O_EXCL) { | 1169 | switch(arg->open_flags & O_EXCL) { |
| @@ -1148,8 +1172,23 @@ static inline void encode_createmode(struct xdr_stream *xdr, const struct nfs_op | |||
| 1148 | encode_attrs(xdr, arg->u.attrs, arg->server); | 1172 | encode_attrs(xdr, arg->u.attrs, arg->server); |
| 1149 | break; | 1173 | break; |
| 1150 | default: | 1174 | default: |
| 1151 | *p = cpu_to_be32(NFS4_CREATE_EXCLUSIVE); | 1175 | clp = arg->server->nfs_client; |
| 1152 | encode_nfs4_verifier(xdr, &arg->u.verifier); | 1176 | if (clp->cl_minorversion > 0) { |
| 1177 | if (nfs4_has_persistent_session(clp)) { | ||
| 1178 | *p = cpu_to_be32(NFS4_CREATE_GUARDED); | ||
| 1179 | encode_attrs(xdr, arg->u.attrs, arg->server); | ||
| 1180 | } else { | ||
| 1181 | struct iattr dummy; | ||
| 1182 | |||
| 1183 | *p = cpu_to_be32(NFS4_CREATE_EXCLUSIVE4_1); | ||
| 1184 | encode_nfs4_verifier(xdr, &arg->u.verifier); | ||
| 1185 | dummy.ia_valid = 0; | ||
| 1186 | encode_attrs(xdr, &dummy, arg->server); | ||
| 1187 | } | ||
| 1188 | } else { | ||
| 1189 | *p = cpu_to_be32(NFS4_CREATE_EXCLUSIVE); | ||
| 1190 | encode_nfs4_verifier(xdr, &arg->u.verifier); | ||
| 1191 | } | ||
| 1153 | } | 1192 | } |
| 1154 | } | 1193 | } |
| 1155 | 1194 | ||
| @@ -1592,6 +1631,19 @@ static void encode_destroy_session(struct xdr_stream *xdr, | |||
| 1592 | hdr->nops++; | 1631 | hdr->nops++; |
| 1593 | hdr->replen += decode_destroy_session_maxsz; | 1632 | hdr->replen += decode_destroy_session_maxsz; |
| 1594 | } | 1633 | } |
| 1634 | |||
| 1635 | static void encode_reclaim_complete(struct xdr_stream *xdr, | ||
| 1636 | struct nfs41_reclaim_complete_args *args, | ||
| 1637 | struct compound_hdr *hdr) | ||
| 1638 | { | ||
| 1639 | __be32 *p; | ||
| 1640 | |||
| 1641 | p = reserve_space(xdr, 8); | ||
| 1642 | *p++ = cpu_to_be32(OP_RECLAIM_COMPLETE); | ||
| 1643 | *p++ = cpu_to_be32(args->one_fs); | ||
| 1644 | hdr->nops++; | ||
| 1645 | hdr->replen += decode_reclaim_complete_maxsz; | ||
| 1646 | } | ||
| 1595 | #endif /* CONFIG_NFS_V4_1 */ | 1647 | #endif /* CONFIG_NFS_V4_1 */ |
| 1596 | 1648 | ||
| 1597 | static void encode_sequence(struct xdr_stream *xdr, | 1649 | static void encode_sequence(struct xdr_stream *xdr, |
| @@ -2096,7 +2148,7 @@ nfs4_xdr_enc_getacl(struct rpc_rqst *req, __be32 *p, | |||
| 2096 | encode_compound_hdr(&xdr, req, &hdr); | 2148 | encode_compound_hdr(&xdr, req, &hdr); |
| 2097 | encode_sequence(&xdr, &args->seq_args, &hdr); | 2149 | encode_sequence(&xdr, &args->seq_args, &hdr); |
| 2098 | encode_putfh(&xdr, args->fh, &hdr); | 2150 | encode_putfh(&xdr, args->fh, &hdr); |
| 2099 | replen = hdr.replen + nfs4_fattr_bitmap_maxsz + 1; | 2151 | replen = hdr.replen + op_decode_hdr_maxsz + nfs4_fattr_bitmap_maxsz + 1; |
| 2100 | encode_getattr_two(&xdr, FATTR4_WORD0_ACL, 0, &hdr); | 2152 | encode_getattr_two(&xdr, FATTR4_WORD0_ACL, 0, &hdr); |
| 2101 | 2153 | ||
| 2102 | xdr_inline_pages(&req->rq_rcv_buf, replen << 2, | 2154 | xdr_inline_pages(&req->rq_rcv_buf, replen << 2, |
| @@ -2420,6 +2472,26 @@ static int nfs4_xdr_enc_get_lease_time(struct rpc_rqst *req, uint32_t *p, | |||
| 2420 | encode_nops(&hdr); | 2472 | encode_nops(&hdr); |
| 2421 | return 0; | 2473 | return 0; |
| 2422 | } | 2474 | } |
| 2475 | |||
| 2476 | /* | ||
| 2477 | * a RECLAIM_COMPLETE request | ||
| 2478 | */ | ||
| 2479 | static int nfs4_xdr_enc_reclaim_complete(struct rpc_rqst *req, uint32_t *p, | ||
| 2480 | struct nfs41_reclaim_complete_args *args) | ||
| 2481 | { | ||
| 2482 | struct xdr_stream xdr; | ||
| 2483 | struct compound_hdr hdr = { | ||
| 2484 | .minorversion = nfs4_xdr_minorversion(&args->seq_args) | ||
| 2485 | }; | ||
| 2486 | |||
| 2487 | xdr_init_encode(&xdr, &req->rq_snd_buf, p); | ||
| 2488 | encode_compound_hdr(&xdr, req, &hdr); | ||
| 2489 | encode_sequence(&xdr, &args->seq_args, &hdr); | ||
| 2490 | encode_reclaim_complete(&xdr, args, &hdr); | ||
| 2491 | encode_nops(&hdr); | ||
| 2492 | return 0; | ||
| 2493 | } | ||
| 2494 | |||
| 2423 | #endif /* CONFIG_NFS_V4_1 */ | 2495 | #endif /* CONFIG_NFS_V4_1 */ |
| 2424 | 2496 | ||
| 2425 | static void print_overflow_msg(const char *func, const struct xdr_stream *xdr) | 2497 | static void print_overflow_msg(const char *func, const struct xdr_stream *xdr) |
| @@ -4528,6 +4600,11 @@ static int decode_destroy_session(struct xdr_stream *xdr, void *dummy) | |||
| 4528 | { | 4600 | { |
| 4529 | return decode_op_hdr(xdr, OP_DESTROY_SESSION); | 4601 | return decode_op_hdr(xdr, OP_DESTROY_SESSION); |
| 4530 | } | 4602 | } |
| 4603 | |||
| 4604 | static int decode_reclaim_complete(struct xdr_stream *xdr, void *dummy) | ||
| 4605 | { | ||
| 4606 | return decode_op_hdr(xdr, OP_RECLAIM_COMPLETE); | ||
| 4607 | } | ||
| 4531 | #endif /* CONFIG_NFS_V4_1 */ | 4608 | #endif /* CONFIG_NFS_V4_1 */ |
| 4532 | 4609 | ||
| 4533 | static int decode_sequence(struct xdr_stream *xdr, | 4610 | static int decode_sequence(struct xdr_stream *xdr, |
| @@ -4583,8 +4660,8 @@ static int decode_sequence(struct xdr_stream *xdr, | |||
| 4583 | dummy = be32_to_cpup(p++); | 4660 | dummy = be32_to_cpup(p++); |
| 4584 | /* target highest slot id - currently not processed */ | 4661 | /* target highest slot id - currently not processed */ |
| 4585 | dummy = be32_to_cpup(p++); | 4662 | dummy = be32_to_cpup(p++); |
| 4586 | /* result flags - currently not processed */ | 4663 | /* result flags */ |
| 4587 | dummy = be32_to_cpup(p); | 4664 | res->sr_status_flags = be32_to_cpup(p); |
| 4588 | status = 0; | 4665 | status = 0; |
| 4589 | out_err: | 4666 | out_err: |
| 4590 | res->sr_status = status; | 4667 | res->sr_status = status; |
| @@ -5309,7 +5386,7 @@ out: | |||
| 5309 | } | 5386 | } |
| 5310 | 5387 | ||
| 5311 | /* | 5388 | /* |
| 5312 | * FSINFO request | 5389 | * Decode FSINFO response |
| 5313 | */ | 5390 | */ |
| 5314 | static int nfs4_xdr_dec_fsinfo(struct rpc_rqst *req, __be32 *p, | 5391 | static int nfs4_xdr_dec_fsinfo(struct rpc_rqst *req, __be32 *p, |
| 5315 | struct nfs4_fsinfo_res *res) | 5392 | struct nfs4_fsinfo_res *res) |
| @@ -5330,7 +5407,7 @@ static int nfs4_xdr_dec_fsinfo(struct rpc_rqst *req, __be32 *p, | |||
| 5330 | } | 5407 | } |
| 5331 | 5408 | ||
| 5332 | /* | 5409 | /* |
| 5333 | * PATHCONF request | 5410 | * Decode PATHCONF response |
| 5334 | */ | 5411 | */ |
| 5335 | static int nfs4_xdr_dec_pathconf(struct rpc_rqst *req, __be32 *p, | 5412 | static int nfs4_xdr_dec_pathconf(struct rpc_rqst *req, __be32 *p, |
| 5336 | struct nfs4_pathconf_res *res) | 5413 | struct nfs4_pathconf_res *res) |
| @@ -5351,7 +5428,7 @@ static int nfs4_xdr_dec_pathconf(struct rpc_rqst *req, __be32 *p, | |||
| 5351 | } | 5428 | } |
| 5352 | 5429 | ||
| 5353 | /* | 5430 | /* |
| 5354 | * STATFS request | 5431 | * Decode STATFS response |
| 5355 | */ | 5432 | */ |
| 5356 | static int nfs4_xdr_dec_statfs(struct rpc_rqst *req, __be32 *p, | 5433 | static int nfs4_xdr_dec_statfs(struct rpc_rqst *req, __be32 *p, |
| 5357 | struct nfs4_statfs_res *res) | 5434 | struct nfs4_statfs_res *res) |
| @@ -5372,7 +5449,7 @@ static int nfs4_xdr_dec_statfs(struct rpc_rqst *req, __be32 *p, | |||
| 5372 | } | 5449 | } |
| 5373 | 5450 | ||
| 5374 | /* | 5451 | /* |
| 5375 | * GETATTR_BITMAP request | 5452 | * Decode GETATTR_BITMAP response |
| 5376 | */ | 5453 | */ |
| 5377 | static int nfs4_xdr_dec_server_caps(struct rpc_rqst *req, __be32 *p, struct nfs4_server_caps_res *res) | 5454 | static int nfs4_xdr_dec_server_caps(struct rpc_rqst *req, __be32 *p, struct nfs4_server_caps_res *res) |
| 5378 | { | 5455 | { |
| @@ -5411,7 +5488,7 @@ static int nfs4_xdr_dec_renew(struct rpc_rqst *rqstp, __be32 *p, void *dummy) | |||
| 5411 | } | 5488 | } |
| 5412 | 5489 | ||
| 5413 | /* | 5490 | /* |
| 5414 | * a SETCLIENTID request | 5491 | * Decode SETCLIENTID response |
| 5415 | */ | 5492 | */ |
| 5416 | static int nfs4_xdr_dec_setclientid(struct rpc_rqst *req, __be32 *p, | 5493 | static int nfs4_xdr_dec_setclientid(struct rpc_rqst *req, __be32 *p, |
| 5417 | struct nfs_client *clp) | 5494 | struct nfs_client *clp) |
| @@ -5428,7 +5505,7 @@ static int nfs4_xdr_dec_setclientid(struct rpc_rqst *req, __be32 *p, | |||
| 5428 | } | 5505 | } |
| 5429 | 5506 | ||
| 5430 | /* | 5507 | /* |
| 5431 | * a SETCLIENTID_CONFIRM request | 5508 | * Decode SETCLIENTID_CONFIRM response |
| 5432 | */ | 5509 | */ |
| 5433 | static int nfs4_xdr_dec_setclientid_confirm(struct rpc_rqst *req, __be32 *p, struct nfs_fsinfo *fsinfo) | 5510 | static int nfs4_xdr_dec_setclientid_confirm(struct rpc_rqst *req, __be32 *p, struct nfs_fsinfo *fsinfo) |
| 5434 | { | 5511 | { |
| @@ -5448,7 +5525,7 @@ static int nfs4_xdr_dec_setclientid_confirm(struct rpc_rqst *req, __be32 *p, str | |||
| 5448 | } | 5525 | } |
| 5449 | 5526 | ||
| 5450 | /* | 5527 | /* |
| 5451 | * DELEGRETURN request | 5528 | * Decode DELEGRETURN response |
| 5452 | */ | 5529 | */ |
| 5453 | static int nfs4_xdr_dec_delegreturn(struct rpc_rqst *rqstp, __be32 *p, struct nfs4_delegreturnres *res) | 5530 | static int nfs4_xdr_dec_delegreturn(struct rpc_rqst *rqstp, __be32 *p, struct nfs4_delegreturnres *res) |
| 5454 | { | 5531 | { |
| @@ -5474,7 +5551,7 @@ out: | |||
| 5474 | } | 5551 | } |
| 5475 | 5552 | ||
| 5476 | /* | 5553 | /* |
| 5477 | * FS_LOCATIONS request | 5554 | * Decode FS_LOCATIONS response |
| 5478 | */ | 5555 | */ |
| 5479 | static int nfs4_xdr_dec_fs_locations(struct rpc_rqst *req, __be32 *p, | 5556 | static int nfs4_xdr_dec_fs_locations(struct rpc_rqst *req, __be32 *p, |
| 5480 | struct nfs4_fs_locations_res *res) | 5557 | struct nfs4_fs_locations_res *res) |
| @@ -5504,7 +5581,7 @@ out: | |||
| 5504 | 5581 | ||
| 5505 | #if defined(CONFIG_NFS_V4_1) | 5582 | #if defined(CONFIG_NFS_V4_1) |
| 5506 | /* | 5583 | /* |
| 5507 | * EXCHANGE_ID request | 5584 | * Decode EXCHANGE_ID response |
| 5508 | */ | 5585 | */ |
| 5509 | static int nfs4_xdr_dec_exchange_id(struct rpc_rqst *rqstp, uint32_t *p, | 5586 | static int nfs4_xdr_dec_exchange_id(struct rpc_rqst *rqstp, uint32_t *p, |
| 5510 | void *res) | 5587 | void *res) |
| @@ -5521,7 +5598,7 @@ static int nfs4_xdr_dec_exchange_id(struct rpc_rqst *rqstp, uint32_t *p, | |||
| 5521 | } | 5598 | } |
| 5522 | 5599 | ||
| 5523 | /* | 5600 | /* |
| 5524 | * a CREATE_SESSION request | 5601 | * Decode CREATE_SESSION response |
| 5525 | */ | 5602 | */ |
| 5526 | static int nfs4_xdr_dec_create_session(struct rpc_rqst *rqstp, uint32_t *p, | 5603 | static int nfs4_xdr_dec_create_session(struct rpc_rqst *rqstp, uint32_t *p, |
| 5527 | struct nfs41_create_session_res *res) | 5604 | struct nfs41_create_session_res *res) |
| @@ -5538,7 +5615,7 @@ static int nfs4_xdr_dec_create_session(struct rpc_rqst *rqstp, uint32_t *p, | |||
| 5538 | } | 5615 | } |
| 5539 | 5616 | ||
| 5540 | /* | 5617 | /* |
| 5541 | * a DESTROY_SESSION request | 5618 | * Decode DESTROY_SESSION response |
| 5542 | */ | 5619 | */ |
| 5543 | static int nfs4_xdr_dec_destroy_session(struct rpc_rqst *rqstp, uint32_t *p, | 5620 | static int nfs4_xdr_dec_destroy_session(struct rpc_rqst *rqstp, uint32_t *p, |
| 5544 | void *dummy) | 5621 | void *dummy) |
| @@ -5555,7 +5632,7 @@ static int nfs4_xdr_dec_destroy_session(struct rpc_rqst *rqstp, uint32_t *p, | |||
| 5555 | } | 5632 | } |
| 5556 | 5633 | ||
| 5557 | /* | 5634 | /* |
| 5558 | * a SEQUENCE request | 5635 | * Decode SEQUENCE response |
| 5559 | */ | 5636 | */ |
| 5560 | static int nfs4_xdr_dec_sequence(struct rpc_rqst *rqstp, uint32_t *p, | 5637 | static int nfs4_xdr_dec_sequence(struct rpc_rqst *rqstp, uint32_t *p, |
| 5561 | struct nfs4_sequence_res *res) | 5638 | struct nfs4_sequence_res *res) |
| @@ -5572,7 +5649,7 @@ static int nfs4_xdr_dec_sequence(struct rpc_rqst *rqstp, uint32_t *p, | |||
| 5572 | } | 5649 | } |
| 5573 | 5650 | ||
| 5574 | /* | 5651 | /* |
| 5575 | * a GET_LEASE_TIME request | 5652 | * Decode GET_LEASE_TIME response |
| 5576 | */ | 5653 | */ |
| 5577 | static int nfs4_xdr_dec_get_lease_time(struct rpc_rqst *rqstp, uint32_t *p, | 5654 | static int nfs4_xdr_dec_get_lease_time(struct rpc_rqst *rqstp, uint32_t *p, |
| 5578 | struct nfs4_get_lease_time_res *res) | 5655 | struct nfs4_get_lease_time_res *res) |
| @@ -5591,6 +5668,25 @@ static int nfs4_xdr_dec_get_lease_time(struct rpc_rqst *rqstp, uint32_t *p, | |||
| 5591 | status = decode_fsinfo(&xdr, res->lr_fsinfo); | 5668 | status = decode_fsinfo(&xdr, res->lr_fsinfo); |
| 5592 | return status; | 5669 | return status; |
| 5593 | } | 5670 | } |
| 5671 | |||
| 5672 | /* | ||
| 5673 | * Decode RECLAIM_COMPLETE response | ||
| 5674 | */ | ||
| 5675 | static int nfs4_xdr_dec_reclaim_complete(struct rpc_rqst *rqstp, uint32_t *p, | ||
| 5676 | struct nfs41_reclaim_complete_res *res) | ||
| 5677 | { | ||
| 5678 | struct xdr_stream xdr; | ||
| 5679 | struct compound_hdr hdr; | ||
| 5680 | int status; | ||
| 5681 | |||
| 5682 | xdr_init_decode(&xdr, &rqstp->rq_rcv_buf, p); | ||
| 5683 | status = decode_compound_hdr(&xdr, &hdr); | ||
| 5684 | if (!status) | ||
| 5685 | status = decode_sequence(&xdr, &res->seq_res, rqstp); | ||
| 5686 | if (!status) | ||
| 5687 | status = decode_reclaim_complete(&xdr, (void *)NULL); | ||
| 5688 | return status; | ||
| 5689 | } | ||
| 5594 | #endif /* CONFIG_NFS_V4_1 */ | 5690 | #endif /* CONFIG_NFS_V4_1 */ |
| 5595 | 5691 | ||
| 5596 | __be32 *nfs4_decode_dirent(__be32 *p, struct nfs_entry *entry, int plus) | 5692 | __be32 *nfs4_decode_dirent(__be32 *p, struct nfs_entry *entry, int plus) |
| @@ -5767,6 +5863,7 @@ struct rpc_procinfo nfs4_procedures[] = { | |||
| 5767 | PROC(DESTROY_SESSION, enc_destroy_session, dec_destroy_session), | 5863 | PROC(DESTROY_SESSION, enc_destroy_session, dec_destroy_session), |
| 5768 | PROC(SEQUENCE, enc_sequence, dec_sequence), | 5864 | PROC(SEQUENCE, enc_sequence, dec_sequence), |
| 5769 | PROC(GET_LEASE_TIME, enc_get_lease_time, dec_get_lease_time), | 5865 | PROC(GET_LEASE_TIME, enc_get_lease_time, dec_get_lease_time), |
| 5866 | PROC(RECLAIM_COMPLETE, enc_reclaim_complete, dec_reclaim_complete), | ||
| 5770 | #endif /* CONFIG_NFS_V4_1 */ | 5867 | #endif /* CONFIG_NFS_V4_1 */ |
| 5771 | }; | 5868 | }; |
| 5772 | 5869 | ||
diff --git a/fs/nfs/read.c b/fs/nfs/read.c index 12c9e66d3f1d..db9b360ae19d 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c | |||
| @@ -356,25 +356,19 @@ static void nfs_readpage_retry(struct rpc_task *task, struct nfs_read_data *data | |||
| 356 | struct nfs_readres *resp = &data->res; | 356 | struct nfs_readres *resp = &data->res; |
| 357 | 357 | ||
| 358 | if (resp->eof || resp->count == argp->count) | 358 | if (resp->eof || resp->count == argp->count) |
| 359 | goto out; | 359 | return; |
| 360 | 360 | ||
| 361 | /* This is a short read! */ | 361 | /* This is a short read! */ |
| 362 | nfs_inc_stats(data->inode, NFSIOS_SHORTREAD); | 362 | nfs_inc_stats(data->inode, NFSIOS_SHORTREAD); |
| 363 | /* Has the server at least made some progress? */ | 363 | /* Has the server at least made some progress? */ |
| 364 | if (resp->count == 0) | 364 | if (resp->count == 0) |
| 365 | goto out; | 365 | return; |
| 366 | 366 | ||
| 367 | /* Yes, so retry the read at the end of the data */ | 367 | /* Yes, so retry the read at the end of the data */ |
| 368 | argp->offset += resp->count; | 368 | argp->offset += resp->count; |
| 369 | argp->pgbase += resp->count; | 369 | argp->pgbase += resp->count; |
| 370 | argp->count -= resp->count; | 370 | argp->count -= resp->count; |
| 371 | nfs4_restart_rpc(task, NFS_SERVER(data->inode)->nfs_client); | 371 | nfs_restart_rpc(task, NFS_SERVER(data->inode)->nfs_client); |
| 372 | return; | ||
| 373 | out: | ||
| 374 | nfs4_sequence_free_slot(NFS_SERVER(data->inode)->nfs_client, | ||
| 375 | &data->res.seq_res); | ||
| 376 | return; | ||
| 377 | |||
| 378 | } | 372 | } |
| 379 | 373 | ||
| 380 | /* | 374 | /* |
diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 90be551b80c1..ce907efc5508 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c | |||
| @@ -175,14 +175,16 @@ static const match_table_t nfs_mount_option_tokens = { | |||
| 175 | }; | 175 | }; |
| 176 | 176 | ||
| 177 | enum { | 177 | enum { |
| 178 | Opt_xprt_udp, Opt_xprt_tcp, Opt_xprt_rdma, | 178 | Opt_xprt_udp, Opt_xprt_udp6, Opt_xprt_tcp, Opt_xprt_tcp6, Opt_xprt_rdma, |
| 179 | 179 | ||
| 180 | Opt_xprt_err | 180 | Opt_xprt_err |
| 181 | }; | 181 | }; |
| 182 | 182 | ||
| 183 | static const match_table_t nfs_xprt_protocol_tokens = { | 183 | static const match_table_t nfs_xprt_protocol_tokens = { |
| 184 | { Opt_xprt_udp, "udp" }, | 184 | { Opt_xprt_udp, "udp" }, |
| 185 | { Opt_xprt_udp6, "udp6" }, | ||
| 185 | { Opt_xprt_tcp, "tcp" }, | 186 | { Opt_xprt_tcp, "tcp" }, |
| 187 | { Opt_xprt_tcp6, "tcp6" }, | ||
| 186 | { Opt_xprt_rdma, "rdma" }, | 188 | { Opt_xprt_rdma, "rdma" }, |
| 187 | 189 | ||
| 188 | { Opt_xprt_err, NULL } | 190 | { Opt_xprt_err, NULL } |
| @@ -492,6 +494,45 @@ static const char *nfs_pseudoflavour_to_name(rpc_authflavor_t flavour) | |||
| 492 | return sec_flavours[i].str; | 494 | return sec_flavours[i].str; |
| 493 | } | 495 | } |
| 494 | 496 | ||
| 497 | static void nfs_show_mountd_netid(struct seq_file *m, struct nfs_server *nfss, | ||
| 498 | int showdefaults) | ||
| 499 | { | ||
| 500 | struct sockaddr *sap = (struct sockaddr *) &nfss->mountd_address; | ||
| 501 | |||
| 502 | seq_printf(m, ",mountproto="); | ||
| 503 | switch (sap->sa_family) { | ||
| 504 | case AF_INET: | ||
| 505 | switch (nfss->mountd_protocol) { | ||
| 506 | case IPPROTO_UDP: | ||
| 507 | seq_printf(m, RPCBIND_NETID_UDP); | ||
| 508 | break; | ||
| 509 | case IPPROTO_TCP: | ||
| 510 | seq_printf(m, RPCBIND_NETID_TCP); | ||
| 511 | break; | ||
| 512 | default: | ||
| 513 | if (showdefaults) | ||
| 514 | seq_printf(m, "auto"); | ||
| 515 | } | ||
| 516 | break; | ||
| 517 | case AF_INET6: | ||
| 518 | switch (nfss->mountd_protocol) { | ||
| 519 | case IPPROTO_UDP: | ||
| 520 | seq_printf(m, RPCBIND_NETID_UDP6); | ||
| 521 | break; | ||
| 522 | case IPPROTO_TCP: | ||
| 523 | seq_printf(m, RPCBIND_NETID_TCP6); | ||
| 524 | break; | ||
| 525 | default: | ||
| 526 | if (showdefaults) | ||
| 527 | seq_printf(m, "auto"); | ||
| 528 | } | ||
| 529 | break; | ||
| 530 | default: | ||
| 531 | if (showdefaults) | ||
| 532 | seq_printf(m, "auto"); | ||
| 533 | } | ||
| 534 | } | ||
| 535 | |||
| 495 | static void nfs_show_mountd_options(struct seq_file *m, struct nfs_server *nfss, | 536 | static void nfs_show_mountd_options(struct seq_file *m, struct nfs_server *nfss, |
| 496 | int showdefaults) | 537 | int showdefaults) |
| 497 | { | 538 | { |
| @@ -505,7 +546,7 @@ static void nfs_show_mountd_options(struct seq_file *m, struct nfs_server *nfss, | |||
| 505 | } | 546 | } |
| 506 | case AF_INET6: { | 547 | case AF_INET6: { |
| 507 | struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap; | 548 | struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap; |
| 508 | seq_printf(m, ",mountaddr=%pI6", &sin6->sin6_addr); | 549 | seq_printf(m, ",mountaddr=%pI6c", &sin6->sin6_addr); |
| 509 | break; | 550 | break; |
| 510 | } | 551 | } |
| 511 | default: | 552 | default: |
| @@ -518,17 +559,7 @@ static void nfs_show_mountd_options(struct seq_file *m, struct nfs_server *nfss, | |||
| 518 | if (nfss->mountd_port || showdefaults) | 559 | if (nfss->mountd_port || showdefaults) |
| 519 | seq_printf(m, ",mountport=%u", nfss->mountd_port); | 560 | seq_printf(m, ",mountport=%u", nfss->mountd_port); |
| 520 | 561 | ||
| 521 | switch (nfss->mountd_protocol) { | 562 | nfs_show_mountd_netid(m, nfss, showdefaults); |
| 522 | case IPPROTO_UDP: | ||
| 523 | seq_printf(m, ",mountproto=udp"); | ||
| 524 | break; | ||
| 525 | case IPPROTO_TCP: | ||
| 526 | seq_printf(m, ",mountproto=tcp"); | ||
| 527 | break; | ||
| 528 | default: | ||
| 529 | if (showdefaults) | ||
| 530 | seq_printf(m, ",mountproto=auto"); | ||
| 531 | } | ||
| 532 | } | 563 | } |
| 533 | 564 | ||
| 534 | /* | 565 | /* |
| @@ -578,7 +609,7 @@ static void nfs_show_mount_options(struct seq_file *m, struct nfs_server *nfss, | |||
| 578 | seq_puts(m, nfs_infop->nostr); | 609 | seq_puts(m, nfs_infop->nostr); |
| 579 | } | 610 | } |
| 580 | seq_printf(m, ",proto=%s", | 611 | seq_printf(m, ",proto=%s", |
| 581 | rpc_peeraddr2str(nfss->client, RPC_DISPLAY_PROTO)); | 612 | rpc_peeraddr2str(nfss->client, RPC_DISPLAY_NETID)); |
| 582 | if (version == 4) { | 613 | if (version == 4) { |
| 583 | if (nfss->port != NFS_PORT) | 614 | if (nfss->port != NFS_PORT) |
| 584 | seq_printf(m, ",port=%u", nfss->port); | 615 | seq_printf(m, ",port=%u", nfss->port); |
| @@ -714,8 +745,6 @@ static void nfs_umount_begin(struct super_block *sb) | |||
| 714 | struct nfs_server *server; | 745 | struct nfs_server *server; |
| 715 | struct rpc_clnt *rpc; | 746 | struct rpc_clnt *rpc; |
| 716 | 747 | ||
| 717 | lock_kernel(); | ||
| 718 | |||
| 719 | server = NFS_SB(sb); | 748 | server = NFS_SB(sb); |
| 720 | /* -EIO all pending I/O */ | 749 | /* -EIO all pending I/O */ |
| 721 | rpc = server->client_acl; | 750 | rpc = server->client_acl; |
| @@ -724,8 +753,6 @@ static void nfs_umount_begin(struct super_block *sb) | |||
| 724 | rpc = server->client; | 753 | rpc = server->client; |
| 725 | if (!IS_ERR(rpc)) | 754 | if (!IS_ERR(rpc)) |
| 726 | rpc_killall_tasks(rpc); | 755 | rpc_killall_tasks(rpc); |
| 727 | |||
| 728 | unlock_kernel(); | ||
| 729 | } | 756 | } |
| 730 | 757 | ||
| 731 | static struct nfs_parsed_mount_data *nfs_alloc_parsed_mount_data(unsigned int version) | 758 | static struct nfs_parsed_mount_data *nfs_alloc_parsed_mount_data(unsigned int version) |
| @@ -734,8 +761,6 @@ static struct nfs_parsed_mount_data *nfs_alloc_parsed_mount_data(unsigned int ve | |||
| 734 | 761 | ||
| 735 | data = kzalloc(sizeof(*data), GFP_KERNEL); | 762 | data = kzalloc(sizeof(*data), GFP_KERNEL); |
| 736 | if (data) { | 763 | if (data) { |
| 737 | data->rsize = NFS_MAX_FILE_IO_SIZE; | ||
| 738 | data->wsize = NFS_MAX_FILE_IO_SIZE; | ||
| 739 | data->acregmin = NFS_DEF_ACREGMIN; | 764 | data->acregmin = NFS_DEF_ACREGMIN; |
| 740 | data->acregmax = NFS_DEF_ACREGMAX; | 765 | data->acregmax = NFS_DEF_ACREGMAX; |
| 741 | data->acdirmin = NFS_DEF_ACDIRMIN; | 766 | data->acdirmin = NFS_DEF_ACDIRMIN; |
| @@ -887,6 +912,8 @@ static int nfs_parse_mount_options(char *raw, | |||
| 887 | { | 912 | { |
| 888 | char *p, *string, *secdata; | 913 | char *p, *string, *secdata; |
| 889 | int rc, sloppy = 0, invalid_option = 0; | 914 | int rc, sloppy = 0, invalid_option = 0; |
| 915 | unsigned short protofamily = AF_UNSPEC; | ||
| 916 | unsigned short mountfamily = AF_UNSPEC; | ||
| 890 | 917 | ||
| 891 | if (!raw) { | 918 | if (!raw) { |
| 892 | dfprintk(MOUNT, "NFS: mount options string was NULL.\n"); | 919 | dfprintk(MOUNT, "NFS: mount options string was NULL.\n"); |
| @@ -1232,12 +1259,17 @@ static int nfs_parse_mount_options(char *raw, | |||
| 1232 | token = match_token(string, | 1259 | token = match_token(string, |
| 1233 | nfs_xprt_protocol_tokens, args); | 1260 | nfs_xprt_protocol_tokens, args); |
| 1234 | 1261 | ||
| 1262 | protofamily = AF_INET; | ||
| 1235 | switch (token) { | 1263 | switch (token) { |
| 1264 | case Opt_xprt_udp6: | ||
| 1265 | protofamily = AF_INET6; | ||
| 1236 | case Opt_xprt_udp: | 1266 | case Opt_xprt_udp: |
| 1237 | mnt->flags &= ~NFS_MOUNT_TCP; | 1267 | mnt->flags &= ~NFS_MOUNT_TCP; |
| 1238 | mnt->nfs_server.protocol = XPRT_TRANSPORT_UDP; | 1268 | mnt->nfs_server.protocol = XPRT_TRANSPORT_UDP; |
| 1239 | kfree(string); | 1269 | kfree(string); |
| 1240 | break; | 1270 | break; |
| 1271 | case Opt_xprt_tcp6: | ||
| 1272 | protofamily = AF_INET6; | ||
| 1241 | case Opt_xprt_tcp: | 1273 | case Opt_xprt_tcp: |
| 1242 | mnt->flags |= NFS_MOUNT_TCP; | 1274 | mnt->flags |= NFS_MOUNT_TCP; |
| 1243 | mnt->nfs_server.protocol = XPRT_TRANSPORT_TCP; | 1275 | mnt->nfs_server.protocol = XPRT_TRANSPORT_TCP; |
| @@ -1265,10 +1297,15 @@ static int nfs_parse_mount_options(char *raw, | |||
| 1265 | nfs_xprt_protocol_tokens, args); | 1297 | nfs_xprt_protocol_tokens, args); |
| 1266 | kfree(string); | 1298 | kfree(string); |
| 1267 | 1299 | ||
| 1300 | mountfamily = AF_INET; | ||
| 1268 | switch (token) { | 1301 | switch (token) { |
| 1302 | case Opt_xprt_udp6: | ||
| 1303 | mountfamily = AF_INET6; | ||
| 1269 | case Opt_xprt_udp: | 1304 | case Opt_xprt_udp: |
| 1270 | mnt->mount_server.protocol = XPRT_TRANSPORT_UDP; | 1305 | mnt->mount_server.protocol = XPRT_TRANSPORT_UDP; |
| 1271 | break; | 1306 | break; |
| 1307 | case Opt_xprt_tcp6: | ||
| 1308 | mountfamily = AF_INET6; | ||
| 1272 | case Opt_xprt_tcp: | 1309 | case Opt_xprt_tcp: |
| 1273 | mnt->mount_server.protocol = XPRT_TRANSPORT_TCP; | 1310 | mnt->mount_server.protocol = XPRT_TRANSPORT_TCP; |
| 1274 | break; | 1311 | break; |
| @@ -1367,8 +1404,33 @@ static int nfs_parse_mount_options(char *raw, | |||
| 1367 | if (!sloppy && invalid_option) | 1404 | if (!sloppy && invalid_option) |
| 1368 | return 0; | 1405 | return 0; |
| 1369 | 1406 | ||
| 1407 | /* | ||
| 1408 | * verify that any proto=/mountproto= options match the address | ||
| 1409 | * familiies in the addr=/mountaddr= options. | ||
| 1410 | */ | ||
| 1411 | if (protofamily != AF_UNSPEC && | ||
| 1412 | protofamily != mnt->nfs_server.address.ss_family) | ||
| 1413 | goto out_proto_mismatch; | ||
| 1414 | |||
| 1415 | if (mountfamily != AF_UNSPEC) { | ||
| 1416 | if (mnt->mount_server.addrlen) { | ||
| 1417 | if (mountfamily != mnt->mount_server.address.ss_family) | ||
| 1418 | goto out_mountproto_mismatch; | ||
| 1419 | } else { | ||
| 1420 | if (mountfamily != mnt->nfs_server.address.ss_family) | ||
| 1421 | goto out_mountproto_mismatch; | ||
| 1422 | } | ||
| 1423 | } | ||
| 1424 | |||
| 1370 | return 1; | 1425 | return 1; |
| 1371 | 1426 | ||
| 1427 | out_mountproto_mismatch: | ||
| 1428 | printk(KERN_INFO "NFS: mount server address does not match mountproto= " | ||
| 1429 | "option\n"); | ||
| 1430 | return 0; | ||
| 1431 | out_proto_mismatch: | ||
| 1432 | printk(KERN_INFO "NFS: server address does not match proto= option\n"); | ||
| 1433 | return 0; | ||
| 1372 | out_invalid_address: | 1434 | out_invalid_address: |
| 1373 | printk(KERN_INFO "NFS: bad IP address specified: %s\n", p); | 1435 | printk(KERN_INFO "NFS: bad IP address specified: %s\n", p); |
| 1374 | return 0; | 1436 | return 0; |
| @@ -1881,7 +1943,6 @@ nfs_remount(struct super_block *sb, int *flags, char *raw_data) | |||
| 1881 | if (data == NULL) | 1943 | if (data == NULL) |
| 1882 | return -ENOMEM; | 1944 | return -ENOMEM; |
| 1883 | 1945 | ||
| 1884 | lock_kernel(); | ||
| 1885 | /* fill out struct with values from existing mount */ | 1946 | /* fill out struct with values from existing mount */ |
| 1886 | data->flags = nfss->flags; | 1947 | data->flags = nfss->flags; |
| 1887 | data->rsize = nfss->rsize; | 1948 | data->rsize = nfss->rsize; |
| @@ -1907,7 +1968,6 @@ nfs_remount(struct super_block *sb, int *flags, char *raw_data) | |||
| 1907 | error = nfs_compare_remount_data(nfss, data); | 1968 | error = nfs_compare_remount_data(nfss, data); |
| 1908 | out: | 1969 | out: |
| 1909 | kfree(data); | 1970 | kfree(data); |
| 1910 | unlock_kernel(); | ||
| 1911 | return error; | 1971 | return error; |
| 1912 | } | 1972 | } |
| 1913 | 1973 | ||
diff --git a/fs/nfs/sysctl.c b/fs/nfs/sysctl.c index b62481dabae9..70e1fbbaaeab 100644 --- a/fs/nfs/sysctl.c +++ b/fs/nfs/sysctl.c | |||
| @@ -22,63 +22,55 @@ static struct ctl_table_header *nfs_callback_sysctl_table; | |||
| 22 | static ctl_table nfs_cb_sysctls[] = { | 22 | static ctl_table nfs_cb_sysctls[] = { |
| 23 | #ifdef CONFIG_NFS_V4 | 23 | #ifdef CONFIG_NFS_V4 |
| 24 | { | 24 | { |
| 25 | .ctl_name = CTL_UNNUMBERED, | ||
| 26 | .procname = "nfs_callback_tcpport", | 25 | .procname = "nfs_callback_tcpport", |
| 27 | .data = &nfs_callback_set_tcpport, | 26 | .data = &nfs_callback_set_tcpport, |
| 28 | .maxlen = sizeof(int), | 27 | .maxlen = sizeof(int), |
| 29 | .mode = 0644, | 28 | .mode = 0644, |
| 30 | .proc_handler = &proc_dointvec_minmax, | 29 | .proc_handler = proc_dointvec_minmax, |
| 31 | .extra1 = (int *)&nfs_set_port_min, | 30 | .extra1 = (int *)&nfs_set_port_min, |
| 32 | .extra2 = (int *)&nfs_set_port_max, | 31 | .extra2 = (int *)&nfs_set_port_max, |
| 33 | }, | 32 | }, |
| 34 | { | 33 | { |
| 35 | .ctl_name = CTL_UNNUMBERED, | ||
| 36 | .procname = "idmap_cache_timeout", | 34 | .procname = "idmap_cache_timeout", |
| 37 | .data = &nfs_idmap_cache_timeout, | 35 | .data = &nfs_idmap_cache_timeout, |
| 38 | .maxlen = sizeof(int), | 36 | .maxlen = sizeof(int), |
| 39 | .mode = 0644, | 37 | .mode = 0644, |
| 40 | .proc_handler = &proc_dointvec_jiffies, | 38 | .proc_handler = proc_dointvec_jiffies, |
| 41 | .strategy = &sysctl_jiffies, | ||
| 42 | }, | 39 | }, |
| 43 | #endif | 40 | #endif |
| 44 | { | 41 | { |
| 45 | .ctl_name = CTL_UNNUMBERED, | ||
| 46 | .procname = "nfs_mountpoint_timeout", | 42 | .procname = "nfs_mountpoint_timeout", |
| 47 | .data = &nfs_mountpoint_expiry_timeout, | 43 | .data = &nfs_mountpoint_expiry_timeout, |
| 48 | .maxlen = sizeof(nfs_mountpoint_expiry_timeout), | 44 | .maxlen = sizeof(nfs_mountpoint_expiry_timeout), |
| 49 | .mode = 0644, | 45 | .mode = 0644, |
| 50 | .proc_handler = &proc_dointvec_jiffies, | 46 | .proc_handler = proc_dointvec_jiffies, |
| 51 | .strategy = &sysctl_jiffies, | ||
| 52 | }, | 47 | }, |
| 53 | { | 48 | { |
| 54 | .ctl_name = CTL_UNNUMBERED, | ||
| 55 | .procname = "nfs_congestion_kb", | 49 | .procname = "nfs_congestion_kb", |
| 56 | .data = &nfs_congestion_kb, | 50 | .data = &nfs_congestion_kb, |
| 57 | .maxlen = sizeof(nfs_congestion_kb), | 51 | .maxlen = sizeof(nfs_congestion_kb), |
| 58 | .mode = 0644, | 52 | .mode = 0644, |
| 59 | .proc_handler = &proc_dointvec, | 53 | .proc_handler = proc_dointvec, |
| 60 | }, | 54 | }, |
| 61 | { .ctl_name = 0 } | 55 | { } |
| 62 | }; | 56 | }; |
| 63 | 57 | ||
| 64 | static ctl_table nfs_cb_sysctl_dir[] = { | 58 | static ctl_table nfs_cb_sysctl_dir[] = { |
| 65 | { | 59 | { |
| 66 | .ctl_name = CTL_UNNUMBERED, | ||
| 67 | .procname = "nfs", | 60 | .procname = "nfs", |
| 68 | .mode = 0555, | 61 | .mode = 0555, |
| 69 | .child = nfs_cb_sysctls, | 62 | .child = nfs_cb_sysctls, |
| 70 | }, | 63 | }, |
| 71 | { .ctl_name = 0 } | 64 | { } |
| 72 | }; | 65 | }; |
| 73 | 66 | ||
| 74 | static ctl_table nfs_cb_sysctl_root[] = { | 67 | static ctl_table nfs_cb_sysctl_root[] = { |
| 75 | { | 68 | { |
| 76 | .ctl_name = CTL_FS, | ||
| 77 | .procname = "fs", | 69 | .procname = "fs", |
| 78 | .mode = 0555, | 70 | .mode = 0555, |
| 79 | .child = nfs_cb_sysctl_dir, | 71 | .child = nfs_cb_sysctl_dir, |
| 80 | }, | 72 | }, |
| 81 | { .ctl_name = 0 } | 73 | { } |
| 82 | }; | 74 | }; |
| 83 | 75 | ||
| 84 | int nfs_register_sysctl(void) | 76 | int nfs_register_sysctl(void) |
diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c index 1064c91ae810..6da3d3ff6edd 100644 --- a/fs/nfs/unlink.c +++ b/fs/nfs/unlink.c | |||
| @@ -83,7 +83,7 @@ static void nfs_async_unlink_done(struct rpc_task *task, void *calldata) | |||
| 83 | struct inode *dir = data->dir; | 83 | struct inode *dir = data->dir; |
| 84 | 84 | ||
| 85 | if (!NFS_PROTO(dir)->unlink_done(task, dir)) | 85 | if (!NFS_PROTO(dir)->unlink_done(task, dir)) |
| 86 | nfs4_restart_rpc(task, NFS_SERVER(dir)->nfs_client); | 86 | nfs_restart_rpc(task, NFS_SERVER(dir)->nfs_client); |
| 87 | } | 87 | } |
| 88 | 88 | ||
| 89 | /** | 89 | /** |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 53eb26c16b50..d171696017f4 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
| @@ -178,7 +178,7 @@ static int wb_priority(struct writeback_control *wbc) | |||
| 178 | { | 178 | { |
| 179 | if (wbc->for_reclaim) | 179 | if (wbc->for_reclaim) |
| 180 | return FLUSH_HIGHPRI | FLUSH_STABLE; | 180 | return FLUSH_HIGHPRI | FLUSH_STABLE; |
| 181 | if (wbc->for_kupdate) | 181 | if (wbc->for_kupdate || wbc->for_background) |
| 182 | return FLUSH_LOWPRI; | 182 | return FLUSH_LOWPRI; |
| 183 | return 0; | 183 | return 0; |
| 184 | } | 184 | } |
| @@ -774,7 +774,7 @@ int nfs_updatepage(struct file *file, struct page *page, | |||
| 774 | */ | 774 | */ |
| 775 | if (nfs_write_pageuptodate(page, inode) && | 775 | if (nfs_write_pageuptodate(page, inode) && |
| 776 | inode->i_flock == NULL && | 776 | inode->i_flock == NULL && |
| 777 | !(file->f_flags & O_SYNC)) { | 777 | !(file->f_flags & O_DSYNC)) { |
| 778 | count = max(count + offset, nfs_page_length(page)); | 778 | count = max(count + offset, nfs_page_length(page)); |
| 779 | offset = 0; | 779 | offset = 0; |
| 780 | } | 780 | } |
| @@ -1216,7 +1216,7 @@ int nfs_writeback_done(struct rpc_task *task, struct nfs_write_data *data) | |||
| 1216 | */ | 1216 | */ |
| 1217 | argp->stable = NFS_FILE_SYNC; | 1217 | argp->stable = NFS_FILE_SYNC; |
| 1218 | } | 1218 | } |
| 1219 | nfs4_restart_rpc(task, server->nfs_client); | 1219 | nfs_restart_rpc(task, server->nfs_client); |
| 1220 | return -EAGAIN; | 1220 | return -EAGAIN; |
| 1221 | } | 1221 | } |
| 1222 | if (time_before(complain, jiffies)) { | 1222 | if (time_before(complain, jiffies)) { |
| @@ -1228,7 +1228,6 @@ int nfs_writeback_done(struct rpc_task *task, struct nfs_write_data *data) | |||
| 1228 | /* Can't do anything about it except throw an error. */ | 1228 | /* Can't do anything about it except throw an error. */ |
| 1229 | task->tk_status = -EIO; | 1229 | task->tk_status = -EIO; |
| 1230 | } | 1230 | } |
| 1231 | nfs4_sequence_free_slot(server->nfs_client, &data->res.seq_res); | ||
| 1232 | return 0; | 1231 | return 0; |
| 1233 | } | 1232 | } |
| 1234 | 1233 | ||
| @@ -1612,15 +1611,16 @@ int nfs_migrate_page(struct address_space *mapping, struct page *newpage, | |||
| 1612 | if (ret) | 1611 | if (ret) |
| 1613 | goto out_unlock; | 1612 | goto out_unlock; |
| 1614 | page_cache_get(newpage); | 1613 | page_cache_get(newpage); |
| 1614 | spin_lock(&mapping->host->i_lock); | ||
| 1615 | req->wb_page = newpage; | 1615 | req->wb_page = newpage; |
| 1616 | SetPagePrivate(newpage); | 1616 | SetPagePrivate(newpage); |
| 1617 | set_page_private(newpage, page_private(page)); | 1617 | set_page_private(newpage, (unsigned long)req); |
| 1618 | ClearPagePrivate(page); | 1618 | ClearPagePrivate(page); |
| 1619 | set_page_private(page, 0); | 1619 | set_page_private(page, 0); |
| 1620 | spin_unlock(&mapping->host->i_lock); | ||
| 1620 | page_cache_release(page); | 1621 | page_cache_release(page); |
| 1621 | out_unlock: | 1622 | out_unlock: |
| 1622 | nfs_clear_page_tag_locked(req); | 1623 | nfs_clear_page_tag_locked(req); |
| 1623 | nfs_release_request(req); | ||
| 1624 | out: | 1624 | out: |
| 1625 | return ret; | 1625 | return ret; |
| 1626 | } | 1626 | } |
diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig index 251da07b2a1d..1225af7b2166 100644 --- a/fs/nilfs2/Kconfig +++ b/fs/nilfs2/Kconfig | |||
| @@ -2,6 +2,7 @@ config NILFS2_FS | |||
| 2 | tristate "NILFS2 file system support (EXPERIMENTAL)" | 2 | tristate "NILFS2 file system support (EXPERIMENTAL)" |
| 3 | depends on EXPERIMENTAL | 3 | depends on EXPERIMENTAL |
| 4 | select CRC32 | 4 | select CRC32 |
| 5 | select FS_JOURNAL_INFO | ||
| 5 | help | 6 | help |
| 6 | NILFS2 is a log-structured file system (LFS) supporting continuous | 7 | NILFS2 is a log-structured file system (LFS) supporting continuous |
| 7 | snapshotting. In addition to versioning capability of the entire | 8 | snapshotting. In addition to versioning capability of the entire |
diff --git a/fs/nilfs2/alloc.c b/fs/nilfs2/alloc.c index d69e6ae59251..3f959f1879d8 100644 --- a/fs/nilfs2/alloc.c +++ b/fs/nilfs2/alloc.c | |||
| @@ -142,29 +142,75 @@ static void nilfs_palloc_desc_block_init(struct inode *inode, | |||
| 142 | } | 142 | } |
| 143 | } | 143 | } |
| 144 | 144 | ||
| 145 | static int nilfs_palloc_get_block(struct inode *inode, unsigned long blkoff, | ||
| 146 | int create, | ||
| 147 | void (*init_block)(struct inode *, | ||
| 148 | struct buffer_head *, | ||
| 149 | void *), | ||
| 150 | struct buffer_head **bhp, | ||
| 151 | struct nilfs_bh_assoc *prev, | ||
| 152 | spinlock_t *lock) | ||
| 153 | { | ||
| 154 | int ret; | ||
| 155 | |||
| 156 | spin_lock(lock); | ||
| 157 | if (prev->bh && blkoff == prev->blkoff) { | ||
| 158 | get_bh(prev->bh); | ||
| 159 | *bhp = prev->bh; | ||
| 160 | spin_unlock(lock); | ||
| 161 | return 0; | ||
| 162 | } | ||
| 163 | spin_unlock(lock); | ||
| 164 | |||
| 165 | ret = nilfs_mdt_get_block(inode, blkoff, create, init_block, bhp); | ||
| 166 | if (!ret) { | ||
| 167 | spin_lock(lock); | ||
| 168 | /* | ||
| 169 | * The following code must be safe for change of the | ||
| 170 | * cache contents during the get block call. | ||
| 171 | */ | ||
| 172 | brelse(prev->bh); | ||
| 173 | get_bh(*bhp); | ||
| 174 | prev->bh = *bhp; | ||
| 175 | prev->blkoff = blkoff; | ||
| 176 | spin_unlock(lock); | ||
| 177 | } | ||
| 178 | return ret; | ||
| 179 | } | ||
| 180 | |||
| 145 | static int nilfs_palloc_get_desc_block(struct inode *inode, | 181 | static int nilfs_palloc_get_desc_block(struct inode *inode, |
| 146 | unsigned long group, | 182 | unsigned long group, |
| 147 | int create, struct buffer_head **bhp) | 183 | int create, struct buffer_head **bhp) |
| 148 | { | 184 | { |
| 149 | return nilfs_mdt_get_block(inode, | 185 | struct nilfs_palloc_cache *cache = NILFS_MDT(inode)->mi_palloc_cache; |
| 150 | nilfs_palloc_desc_blkoff(inode, group), | 186 | |
| 151 | create, nilfs_palloc_desc_block_init, bhp); | 187 | return nilfs_palloc_get_block(inode, |
| 188 | nilfs_palloc_desc_blkoff(inode, group), | ||
| 189 | create, nilfs_palloc_desc_block_init, | ||
| 190 | bhp, &cache->prev_desc, &cache->lock); | ||
| 152 | } | 191 | } |
| 153 | 192 | ||
| 154 | static int nilfs_palloc_get_bitmap_block(struct inode *inode, | 193 | static int nilfs_palloc_get_bitmap_block(struct inode *inode, |
| 155 | unsigned long group, | 194 | unsigned long group, |
| 156 | int create, struct buffer_head **bhp) | 195 | int create, struct buffer_head **bhp) |
| 157 | { | 196 | { |
| 158 | return nilfs_mdt_get_block(inode, | 197 | struct nilfs_palloc_cache *cache = NILFS_MDT(inode)->mi_palloc_cache; |
| 159 | nilfs_palloc_bitmap_blkoff(inode, group), | 198 | |
| 160 | create, NULL, bhp); | 199 | return nilfs_palloc_get_block(inode, |
| 200 | nilfs_palloc_bitmap_blkoff(inode, group), | ||
| 201 | create, NULL, bhp, | ||
| 202 | &cache->prev_bitmap, &cache->lock); | ||
| 161 | } | 203 | } |
| 162 | 204 | ||
| 163 | int nilfs_palloc_get_entry_block(struct inode *inode, __u64 nr, | 205 | int nilfs_palloc_get_entry_block(struct inode *inode, __u64 nr, |
| 164 | int create, struct buffer_head **bhp) | 206 | int create, struct buffer_head **bhp) |
| 165 | { | 207 | { |
| 166 | return nilfs_mdt_get_block(inode, nilfs_palloc_entry_blkoff(inode, nr), | 208 | struct nilfs_palloc_cache *cache = NILFS_MDT(inode)->mi_palloc_cache; |
| 167 | create, NULL, bhp); | 209 | |
| 210 | return nilfs_palloc_get_block(inode, | ||
| 211 | nilfs_palloc_entry_blkoff(inode, nr), | ||
| 212 | create, NULL, bhp, | ||
| 213 | &cache->prev_entry, &cache->lock); | ||
| 168 | } | 214 | } |
| 169 | 215 | ||
| 170 | static struct nilfs_palloc_group_desc * | 216 | static struct nilfs_palloc_group_desc * |
| @@ -176,13 +222,6 @@ nilfs_palloc_block_get_group_desc(const struct inode *inode, | |||
| 176 | group % nilfs_palloc_groups_per_desc_block(inode); | 222 | group % nilfs_palloc_groups_per_desc_block(inode); |
| 177 | } | 223 | } |
| 178 | 224 | ||
| 179 | static unsigned char * | ||
| 180 | nilfs_palloc_block_get_bitmap(const struct inode *inode, | ||
| 181 | const struct buffer_head *bh, void *kaddr) | ||
| 182 | { | ||
| 183 | return (unsigned char *)(kaddr + bh_offset(bh)); | ||
| 184 | } | ||
| 185 | |||
| 186 | void *nilfs_palloc_block_get_entry(const struct inode *inode, __u64 nr, | 225 | void *nilfs_palloc_block_get_entry(const struct inode *inode, __u64 nr, |
| 187 | const struct buffer_head *bh, void *kaddr) | 226 | const struct buffer_head *bh, void *kaddr) |
| 188 | { | 227 | { |
| @@ -289,8 +328,7 @@ int nilfs_palloc_prepare_alloc_entry(struct inode *inode, | |||
| 289 | if (ret < 0) | 328 | if (ret < 0) |
| 290 | goto out_desc; | 329 | goto out_desc; |
| 291 | bitmap_kaddr = kmap(bitmap_bh->b_page); | 330 | bitmap_kaddr = kmap(bitmap_bh->b_page); |
| 292 | bitmap = nilfs_palloc_block_get_bitmap( | 331 | bitmap = bitmap_kaddr + bh_offset(bitmap_bh); |
| 293 | inode, bitmap_bh, bitmap_kaddr); | ||
| 294 | pos = nilfs_palloc_find_available_slot( | 332 | pos = nilfs_palloc_find_available_slot( |
| 295 | inode, group, group_offset, bitmap, | 333 | inode, group, group_offset, bitmap, |
| 296 | entries_per_group); | 334 | entries_per_group); |
| @@ -351,8 +389,7 @@ void nilfs_palloc_commit_free_entry(struct inode *inode, | |||
| 351 | desc = nilfs_palloc_block_get_group_desc(inode, group, | 389 | desc = nilfs_palloc_block_get_group_desc(inode, group, |
| 352 | req->pr_desc_bh, desc_kaddr); | 390 | req->pr_desc_bh, desc_kaddr); |
| 353 | bitmap_kaddr = kmap(req->pr_bitmap_bh->b_page); | 391 | bitmap_kaddr = kmap(req->pr_bitmap_bh->b_page); |
| 354 | bitmap = nilfs_palloc_block_get_bitmap(inode, req->pr_bitmap_bh, | 392 | bitmap = bitmap_kaddr + bh_offset(req->pr_bitmap_bh); |
| 355 | bitmap_kaddr); | ||
| 356 | 393 | ||
| 357 | if (!nilfs_clear_bit_atomic(nilfs_mdt_bgl_lock(inode, group), | 394 | if (!nilfs_clear_bit_atomic(nilfs_mdt_bgl_lock(inode, group), |
| 358 | group_offset, bitmap)) | 395 | group_offset, bitmap)) |
| @@ -385,8 +422,7 @@ void nilfs_palloc_abort_alloc_entry(struct inode *inode, | |||
| 385 | desc = nilfs_palloc_block_get_group_desc(inode, group, | 422 | desc = nilfs_palloc_block_get_group_desc(inode, group, |
| 386 | req->pr_desc_bh, desc_kaddr); | 423 | req->pr_desc_bh, desc_kaddr); |
| 387 | bitmap_kaddr = kmap(req->pr_bitmap_bh->b_page); | 424 | bitmap_kaddr = kmap(req->pr_bitmap_bh->b_page); |
| 388 | bitmap = nilfs_palloc_block_get_bitmap(inode, req->pr_bitmap_bh, | 425 | bitmap = bitmap_kaddr + bh_offset(req->pr_bitmap_bh); |
| 389 | bitmap_kaddr); | ||
| 390 | if (!nilfs_clear_bit_atomic(nilfs_mdt_bgl_lock(inode, group), | 426 | if (!nilfs_clear_bit_atomic(nilfs_mdt_bgl_lock(inode, group), |
| 391 | group_offset, bitmap)) | 427 | group_offset, bitmap)) |
| 392 | printk(KERN_WARNING "%s: entry numer %llu already freed\n", | 428 | printk(KERN_WARNING "%s: entry numer %llu already freed\n", |
| @@ -472,8 +508,7 @@ int nilfs_palloc_freev(struct inode *inode, __u64 *entry_nrs, size_t nitems) | |||
| 472 | desc = nilfs_palloc_block_get_group_desc( | 508 | desc = nilfs_palloc_block_get_group_desc( |
| 473 | inode, group, desc_bh, desc_kaddr); | 509 | inode, group, desc_bh, desc_kaddr); |
| 474 | bitmap_kaddr = kmap(bitmap_bh->b_page); | 510 | bitmap_kaddr = kmap(bitmap_bh->b_page); |
| 475 | bitmap = nilfs_palloc_block_get_bitmap( | 511 | bitmap = bitmap_kaddr + bh_offset(bitmap_bh); |
| 476 | inode, bitmap_bh, bitmap_kaddr); | ||
| 477 | for (j = i, n = 0; | 512 | for (j = i, n = 0; |
| 478 | (j < nitems) && nilfs_palloc_group_is_in(inode, group, | 513 | (j < nitems) && nilfs_palloc_group_is_in(inode, group, |
| 479 | entry_nrs[j]); | 514 | entry_nrs[j]); |
| @@ -502,3 +537,30 @@ int nilfs_palloc_freev(struct inode *inode, __u64 *entry_nrs, size_t nitems) | |||
| 502 | } | 537 | } |
| 503 | return 0; | 538 | return 0; |
| 504 | } | 539 | } |
| 540 | |||
| 541 | void nilfs_palloc_setup_cache(struct inode *inode, | ||
| 542 | struct nilfs_palloc_cache *cache) | ||
| 543 | { | ||
| 544 | NILFS_MDT(inode)->mi_palloc_cache = cache; | ||
| 545 | spin_lock_init(&cache->lock); | ||
| 546 | } | ||
| 547 | |||
| 548 | void nilfs_palloc_clear_cache(struct inode *inode) | ||
| 549 | { | ||
| 550 | struct nilfs_palloc_cache *cache = NILFS_MDT(inode)->mi_palloc_cache; | ||
| 551 | |||
| 552 | spin_lock(&cache->lock); | ||
| 553 | brelse(cache->prev_desc.bh); | ||
| 554 | brelse(cache->prev_bitmap.bh); | ||
| 555 | brelse(cache->prev_entry.bh); | ||
| 556 | cache->prev_desc.bh = NULL; | ||
| 557 | cache->prev_bitmap.bh = NULL; | ||
| 558 | cache->prev_entry.bh = NULL; | ||
| 559 | spin_unlock(&cache->lock); | ||
| 560 | } | ||
| 561 | |||
| 562 | void nilfs_palloc_destroy_cache(struct inode *inode) | ||
| 563 | { | ||
| 564 | nilfs_palloc_clear_cache(inode); | ||
| 565 | NILFS_MDT(inode)->mi_palloc_cache = NULL; | ||
| 566 | } | ||
diff --git a/fs/nilfs2/alloc.h b/fs/nilfs2/alloc.h index 4ace5475c2c7..f4543ac4f560 100644 --- a/fs/nilfs2/alloc.h +++ b/fs/nilfs2/alloc.h | |||
| @@ -69,4 +69,25 @@ int nilfs_palloc_freev(struct inode *, __u64 *, size_t); | |||
| 69 | #define nilfs_clear_bit_atomic ext2_clear_bit_atomic | 69 | #define nilfs_clear_bit_atomic ext2_clear_bit_atomic |
| 70 | #define nilfs_find_next_zero_bit ext2_find_next_zero_bit | 70 | #define nilfs_find_next_zero_bit ext2_find_next_zero_bit |
| 71 | 71 | ||
| 72 | /* | ||
| 73 | * persistent object allocator cache | ||
| 74 | */ | ||
| 75 | |||
| 76 | struct nilfs_bh_assoc { | ||
| 77 | unsigned long blkoff; | ||
| 78 | struct buffer_head *bh; | ||
| 79 | }; | ||
| 80 | |||
| 81 | struct nilfs_palloc_cache { | ||
| 82 | spinlock_t lock; | ||
| 83 | struct nilfs_bh_assoc prev_desc; | ||
| 84 | struct nilfs_bh_assoc prev_bitmap; | ||
| 85 | struct nilfs_bh_assoc prev_entry; | ||
| 86 | }; | ||
| 87 | |||
| 88 | void nilfs_palloc_setup_cache(struct inode *inode, | ||
| 89 | struct nilfs_palloc_cache *cache); | ||
| 90 | void nilfs_palloc_clear_cache(struct inode *inode); | ||
| 91 | void nilfs_palloc_destroy_cache(struct inode *inode); | ||
| 92 | |||
| 72 | #endif /* _NILFS_ALLOC_H */ | 93 | #endif /* _NILFS_ALLOC_H */ |
diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c index 08834df6ec68..f4a14ea2ed9c 100644 --- a/fs/nilfs2/bmap.c +++ b/fs/nilfs2/bmap.c | |||
| @@ -402,19 +402,11 @@ int nilfs_bmap_test_and_clear_dirty(struct nilfs_bmap *bmap) | |||
| 402 | void nilfs_bmap_add_blocks(const struct nilfs_bmap *bmap, int n) | 402 | void nilfs_bmap_add_blocks(const struct nilfs_bmap *bmap, int n) |
| 403 | { | 403 | { |
| 404 | inode_add_bytes(bmap->b_inode, (1 << bmap->b_inode->i_blkbits) * n); | 404 | inode_add_bytes(bmap->b_inode, (1 << bmap->b_inode->i_blkbits) * n); |
| 405 | if (NILFS_MDT(bmap->b_inode)) | ||
| 406 | nilfs_mdt_mark_dirty(bmap->b_inode); | ||
| 407 | else | ||
| 408 | mark_inode_dirty(bmap->b_inode); | ||
| 409 | } | 405 | } |
| 410 | 406 | ||
| 411 | void nilfs_bmap_sub_blocks(const struct nilfs_bmap *bmap, int n) | 407 | void nilfs_bmap_sub_blocks(const struct nilfs_bmap *bmap, int n) |
| 412 | { | 408 | { |
| 413 | inode_sub_bytes(bmap->b_inode, (1 << bmap->b_inode->i_blkbits) * n); | 409 | inode_sub_bytes(bmap->b_inode, (1 << bmap->b_inode->i_blkbits) * n); |
| 414 | if (NILFS_MDT(bmap->b_inode)) | ||
| 415 | nilfs_mdt_mark_dirty(bmap->b_inode); | ||
| 416 | else | ||
| 417 | mark_inode_dirty(bmap->b_inode); | ||
| 418 | } | 410 | } |
| 419 | 411 | ||
| 420 | __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap, | 412 | __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap, |
diff --git a/fs/nilfs2/btnode.c b/fs/nilfs2/btnode.c index 84c25382f8e3..471e269536ae 100644 --- a/fs/nilfs2/btnode.c +++ b/fs/nilfs2/btnode.c | |||
| @@ -68,9 +68,34 @@ void nilfs_btnode_cache_clear(struct address_space *btnc) | |||
| 68 | truncate_inode_pages(btnc, 0); | 68 | truncate_inode_pages(btnc, 0); |
| 69 | } | 69 | } |
| 70 | 70 | ||
| 71 | struct buffer_head * | ||
| 72 | nilfs_btnode_create_block(struct address_space *btnc, __u64 blocknr) | ||
| 73 | { | ||
| 74 | struct inode *inode = NILFS_BTNC_I(btnc); | ||
| 75 | struct buffer_head *bh; | ||
| 76 | |||
| 77 | bh = nilfs_grab_buffer(inode, btnc, blocknr, 1 << BH_NILFS_Node); | ||
| 78 | if (unlikely(!bh)) | ||
| 79 | return NULL; | ||
| 80 | |||
| 81 | if (unlikely(buffer_mapped(bh) || buffer_uptodate(bh) || | ||
| 82 | buffer_dirty(bh))) { | ||
| 83 | brelse(bh); | ||
| 84 | BUG(); | ||
| 85 | } | ||
| 86 | memset(bh->b_data, 0, 1 << inode->i_blkbits); | ||
| 87 | bh->b_bdev = NILFS_I_NILFS(inode)->ns_bdev; | ||
| 88 | bh->b_blocknr = blocknr; | ||
| 89 | set_buffer_mapped(bh); | ||
| 90 | set_buffer_uptodate(bh); | ||
| 91 | |||
| 92 | unlock_page(bh->b_page); | ||
| 93 | page_cache_release(bh->b_page); | ||
| 94 | return bh; | ||
| 95 | } | ||
| 96 | |||
| 71 | int nilfs_btnode_submit_block(struct address_space *btnc, __u64 blocknr, | 97 | int nilfs_btnode_submit_block(struct address_space *btnc, __u64 blocknr, |
| 72 | sector_t pblocknr, struct buffer_head **pbh, | 98 | sector_t pblocknr, struct buffer_head **pbh) |
| 73 | int newblk) | ||
| 74 | { | 99 | { |
| 75 | struct buffer_head *bh; | 100 | struct buffer_head *bh; |
| 76 | struct inode *inode = NILFS_BTNC_I(btnc); | 101 | struct inode *inode = NILFS_BTNC_I(btnc); |
| @@ -81,19 +106,6 @@ int nilfs_btnode_submit_block(struct address_space *btnc, __u64 blocknr, | |||
| 81 | return -ENOMEM; | 106 | return -ENOMEM; |
| 82 | 107 | ||
| 83 | err = -EEXIST; /* internal code */ | 108 | err = -EEXIST; /* internal code */ |
| 84 | if (newblk) { | ||
| 85 | if (unlikely(buffer_mapped(bh) || buffer_uptodate(bh) || | ||
| 86 | buffer_dirty(bh))) { | ||
| 87 | brelse(bh); | ||
| 88 | BUG(); | ||
| 89 | } | ||
| 90 | memset(bh->b_data, 0, 1 << inode->i_blkbits); | ||
| 91 | bh->b_bdev = NILFS_I_NILFS(inode)->ns_bdev; | ||
| 92 | bh->b_blocknr = blocknr; | ||
| 93 | set_buffer_mapped(bh); | ||
| 94 | set_buffer_uptodate(bh); | ||
| 95 | goto found; | ||
| 96 | } | ||
| 97 | 109 | ||
| 98 | if (buffer_uptodate(bh) || buffer_dirty(bh)) | 110 | if (buffer_uptodate(bh) || buffer_dirty(bh)) |
| 99 | goto found; | 111 | goto found; |
| @@ -135,27 +147,6 @@ out_locked: | |||
| 135 | return err; | 147 | return err; |
| 136 | } | 148 | } |
| 137 | 149 | ||
| 138 | int nilfs_btnode_get(struct address_space *btnc, __u64 blocknr, | ||
| 139 | sector_t pblocknr, struct buffer_head **pbh, int newblk) | ||
| 140 | { | ||
| 141 | struct buffer_head *bh; | ||
| 142 | int err; | ||
| 143 | |||
| 144 | err = nilfs_btnode_submit_block(btnc, blocknr, pblocknr, pbh, newblk); | ||
| 145 | if (err == -EEXIST) /* internal code (cache hit) */ | ||
| 146 | return 0; | ||
| 147 | if (unlikely(err)) | ||
| 148 | return err; | ||
| 149 | |||
| 150 | bh = *pbh; | ||
| 151 | wait_on_buffer(bh); | ||
| 152 | if (!buffer_uptodate(bh)) { | ||
| 153 | brelse(bh); | ||
| 154 | return -EIO; | ||
| 155 | } | ||
| 156 | return 0; | ||
| 157 | } | ||
| 158 | |||
| 159 | /** | 150 | /** |
| 160 | * nilfs_btnode_delete - delete B-tree node buffer | 151 | * nilfs_btnode_delete - delete B-tree node buffer |
| 161 | * @bh: buffer to be deleted | 152 | * @bh: buffer to be deleted |
| @@ -244,12 +235,13 @@ retry: | |||
| 244 | unlock_page(obh->b_page); | 235 | unlock_page(obh->b_page); |
| 245 | } | 236 | } |
| 246 | 237 | ||
| 247 | err = nilfs_btnode_get(btnc, newkey, 0, &nbh, 1); | 238 | nbh = nilfs_btnode_create_block(btnc, newkey); |
| 248 | if (likely(!err)) { | 239 | if (!nbh) |
| 249 | BUG_ON(nbh == obh); | 240 | return -ENOMEM; |
| 250 | ctxt->newbh = nbh; | 241 | |
| 251 | } | 242 | BUG_ON(nbh == obh); |
| 252 | return err; | 243 | ctxt->newbh = nbh; |
| 244 | return 0; | ||
| 253 | 245 | ||
| 254 | failed_unlock: | 246 | failed_unlock: |
| 255 | unlock_page(obh->b_page); | 247 | unlock_page(obh->b_page); |
diff --git a/fs/nilfs2/btnode.h b/fs/nilfs2/btnode.h index 3e2275172ed6..07da83f07712 100644 --- a/fs/nilfs2/btnode.h +++ b/fs/nilfs2/btnode.h | |||
| @@ -40,10 +40,10 @@ struct nilfs_btnode_chkey_ctxt { | |||
| 40 | void nilfs_btnode_cache_init_once(struct address_space *); | 40 | void nilfs_btnode_cache_init_once(struct address_space *); |
| 41 | void nilfs_btnode_cache_init(struct address_space *, struct backing_dev_info *); | 41 | void nilfs_btnode_cache_init(struct address_space *, struct backing_dev_info *); |
| 42 | void nilfs_btnode_cache_clear(struct address_space *); | 42 | void nilfs_btnode_cache_clear(struct address_space *); |
| 43 | struct buffer_head *nilfs_btnode_create_block(struct address_space *btnc, | ||
| 44 | __u64 blocknr); | ||
| 43 | int nilfs_btnode_submit_block(struct address_space *, __u64, sector_t, | 45 | int nilfs_btnode_submit_block(struct address_space *, __u64, sector_t, |
| 44 | struct buffer_head **, int); | 46 | struct buffer_head **); |
| 45 | int nilfs_btnode_get(struct address_space *, __u64, sector_t, | ||
| 46 | struct buffer_head **, int); | ||
| 47 | void nilfs_btnode_delete(struct buffer_head *); | 47 | void nilfs_btnode_delete(struct buffer_head *); |
| 48 | int nilfs_btnode_prepare_change_key(struct address_space *, | 48 | int nilfs_btnode_prepare_change_key(struct address_space *, |
| 49 | struct nilfs_btnode_chkey_ctxt *); | 49 | struct nilfs_btnode_chkey_ctxt *); |
diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c index e25b507a474f..7cdd98b8d514 100644 --- a/fs/nilfs2/btree.c +++ b/fs/nilfs2/btree.c | |||
| @@ -114,7 +114,18 @@ static int nilfs_btree_get_block(const struct nilfs_btree *btree, __u64 ptr, | |||
| 114 | { | 114 | { |
| 115 | struct address_space *btnc = | 115 | struct address_space *btnc = |
| 116 | &NILFS_BMAP_I((struct nilfs_bmap *)btree)->i_btnode_cache; | 116 | &NILFS_BMAP_I((struct nilfs_bmap *)btree)->i_btnode_cache; |
| 117 | return nilfs_btnode_get(btnc, ptr, 0, bhp, 0); | 117 | int err; |
| 118 | |||
| 119 | err = nilfs_btnode_submit_block(btnc, ptr, 0, bhp); | ||
| 120 | if (err) | ||
| 121 | return err == -EEXIST ? 0 : err; | ||
| 122 | |||
| 123 | wait_on_buffer(*bhp); | ||
| 124 | if (!buffer_uptodate(*bhp)) { | ||
| 125 | brelse(*bhp); | ||
| 126 | return -EIO; | ||
| 127 | } | ||
| 128 | return 0; | ||
| 118 | } | 129 | } |
| 119 | 130 | ||
| 120 | static int nilfs_btree_get_new_block(const struct nilfs_btree *btree, | 131 | static int nilfs_btree_get_new_block(const struct nilfs_btree *btree, |
| @@ -122,12 +133,15 @@ static int nilfs_btree_get_new_block(const struct nilfs_btree *btree, | |||
| 122 | { | 133 | { |
| 123 | struct address_space *btnc = | 134 | struct address_space *btnc = |
| 124 | &NILFS_BMAP_I((struct nilfs_bmap *)btree)->i_btnode_cache; | 135 | &NILFS_BMAP_I((struct nilfs_bmap *)btree)->i_btnode_cache; |
| 125 | int ret; | 136 | struct buffer_head *bh; |
| 126 | 137 | ||
| 127 | ret = nilfs_btnode_get(btnc, ptr, 0, bhp, 1); | 138 | bh = nilfs_btnode_create_block(btnc, ptr); |
| 128 | if (!ret) | 139 | if (!bh) |
| 129 | set_buffer_nilfs_volatile(*bhp); | 140 | return -ENOMEM; |
| 130 | return ret; | 141 | |
| 142 | set_buffer_nilfs_volatile(bh); | ||
| 143 | *bhp = bh; | ||
| 144 | return 0; | ||
| 131 | } | 145 | } |
| 132 | 146 | ||
| 133 | static inline int | 147 | static inline int |
| @@ -444,6 +458,18 @@ nilfs_btree_get_node(const struct nilfs_btree *btree, | |||
| 444 | nilfs_btree_get_nonroot_node(path, level); | 458 | nilfs_btree_get_nonroot_node(path, level); |
| 445 | } | 459 | } |
| 446 | 460 | ||
| 461 | static inline int | ||
| 462 | nilfs_btree_bad_node(struct nilfs_btree_node *node, int level) | ||
| 463 | { | ||
| 464 | if (unlikely(nilfs_btree_node_get_level(node) != level)) { | ||
| 465 | dump_stack(); | ||
| 466 | printk(KERN_CRIT "NILFS: btree level mismatch: %d != %d\n", | ||
| 467 | nilfs_btree_node_get_level(node), level); | ||
| 468 | return 1; | ||
| 469 | } | ||
| 470 | return 0; | ||
| 471 | } | ||
| 472 | |||
| 447 | static int nilfs_btree_do_lookup(const struct nilfs_btree *btree, | 473 | static int nilfs_btree_do_lookup(const struct nilfs_btree *btree, |
| 448 | struct nilfs_btree_path *path, | 474 | struct nilfs_btree_path *path, |
| 449 | __u64 key, __u64 *ptrp, int minlevel) | 475 | __u64 key, __u64 *ptrp, int minlevel) |
| @@ -467,7 +493,8 @@ static int nilfs_btree_do_lookup(const struct nilfs_btree *btree, | |||
| 467 | if (ret < 0) | 493 | if (ret < 0) |
| 468 | return ret; | 494 | return ret; |
| 469 | node = nilfs_btree_get_nonroot_node(path, level); | 495 | node = nilfs_btree_get_nonroot_node(path, level); |
| 470 | BUG_ON(level != nilfs_btree_node_get_level(node)); | 496 | if (nilfs_btree_bad_node(node, level)) |
| 497 | return -EINVAL; | ||
| 471 | if (!found) | 498 | if (!found) |
| 472 | found = nilfs_btree_node_lookup(node, key, &index); | 499 | found = nilfs_btree_node_lookup(node, key, &index); |
| 473 | else | 500 | else |
| @@ -512,7 +539,8 @@ static int nilfs_btree_do_lookup_last(const struct nilfs_btree *btree, | |||
| 512 | if (ret < 0) | 539 | if (ret < 0) |
| 513 | return ret; | 540 | return ret; |
| 514 | node = nilfs_btree_get_nonroot_node(path, level); | 541 | node = nilfs_btree_get_nonroot_node(path, level); |
| 515 | BUG_ON(level != nilfs_btree_node_get_level(node)); | 542 | if (nilfs_btree_bad_node(node, level)) |
| 543 | return -EINVAL; | ||
| 516 | index = nilfs_btree_node_get_nchildren(node) - 1; | 544 | index = nilfs_btree_node_get_nchildren(node) - 1; |
| 517 | ptr = nilfs_btree_node_get_ptr(btree, node, index); | 545 | ptr = nilfs_btree_node_get_ptr(btree, node, index); |
| 518 | path[level].bp_index = index; | 546 | path[level].bp_index = index; |
| @@ -638,13 +666,11 @@ static void nilfs_btree_promote_key(struct nilfs_btree *btree, | |||
| 638 | { | 666 | { |
| 639 | if (level < nilfs_btree_height(btree) - 1) { | 667 | if (level < nilfs_btree_height(btree) - 1) { |
| 640 | do { | 668 | do { |
| 641 | lock_buffer(path[level].bp_bh); | ||
| 642 | nilfs_btree_node_set_key( | 669 | nilfs_btree_node_set_key( |
| 643 | nilfs_btree_get_nonroot_node(path, level), | 670 | nilfs_btree_get_nonroot_node(path, level), |
| 644 | path[level].bp_index, key); | 671 | path[level].bp_index, key); |
| 645 | if (!buffer_dirty(path[level].bp_bh)) | 672 | if (!buffer_dirty(path[level].bp_bh)) |
| 646 | nilfs_btnode_mark_dirty(path[level].bp_bh); | 673 | nilfs_btnode_mark_dirty(path[level].bp_bh); |
| 647 | unlock_buffer(path[level].bp_bh); | ||
| 648 | } while ((path[level].bp_index == 0) && | 674 | } while ((path[level].bp_index == 0) && |
| 649 | (++level < nilfs_btree_height(btree) - 1)); | 675 | (++level < nilfs_btree_height(btree) - 1)); |
| 650 | } | 676 | } |
| @@ -663,13 +689,11 @@ static void nilfs_btree_do_insert(struct nilfs_btree *btree, | |||
| 663 | struct nilfs_btree_node *node; | 689 | struct nilfs_btree_node *node; |
| 664 | 690 | ||
| 665 | if (level < nilfs_btree_height(btree) - 1) { | 691 | if (level < nilfs_btree_height(btree) - 1) { |
| 666 | lock_buffer(path[level].bp_bh); | ||
| 667 | node = nilfs_btree_get_nonroot_node(path, level); | 692 | node = nilfs_btree_get_nonroot_node(path, level); |
| 668 | nilfs_btree_node_insert(btree, node, *keyp, *ptrp, | 693 | nilfs_btree_node_insert(btree, node, *keyp, *ptrp, |
| 669 | path[level].bp_index); | 694 | path[level].bp_index); |
| 670 | if (!buffer_dirty(path[level].bp_bh)) | 695 | if (!buffer_dirty(path[level].bp_bh)) |
| 671 | nilfs_btnode_mark_dirty(path[level].bp_bh); | 696 | nilfs_btnode_mark_dirty(path[level].bp_bh); |
| 672 | unlock_buffer(path[level].bp_bh); | ||
| 673 | 697 | ||
| 674 | if (path[level].bp_index == 0) | 698 | if (path[level].bp_index == 0) |
| 675 | nilfs_btree_promote_key(btree, path, level + 1, | 699 | nilfs_btree_promote_key(btree, path, level + 1, |
| @@ -689,9 +713,6 @@ static void nilfs_btree_carry_left(struct nilfs_btree *btree, | |||
| 689 | struct nilfs_btree_node *node, *left; | 713 | struct nilfs_btree_node *node, *left; |
| 690 | int nchildren, lnchildren, n, move; | 714 | int nchildren, lnchildren, n, move; |
| 691 | 715 | ||
| 692 | lock_buffer(path[level].bp_bh); | ||
| 693 | lock_buffer(path[level].bp_sib_bh); | ||
| 694 | |||
| 695 | node = nilfs_btree_get_nonroot_node(path, level); | 716 | node = nilfs_btree_get_nonroot_node(path, level); |
| 696 | left = nilfs_btree_get_sib_node(path, level); | 717 | left = nilfs_btree_get_sib_node(path, level); |
| 697 | nchildren = nilfs_btree_node_get_nchildren(node); | 718 | nchildren = nilfs_btree_node_get_nchildren(node); |
| @@ -712,9 +733,6 @@ static void nilfs_btree_carry_left(struct nilfs_btree *btree, | |||
| 712 | if (!buffer_dirty(path[level].bp_sib_bh)) | 733 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 713 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 734 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 714 | 735 | ||
| 715 | unlock_buffer(path[level].bp_bh); | ||
| 716 | unlock_buffer(path[level].bp_sib_bh); | ||
| 717 | |||
| 718 | nilfs_btree_promote_key(btree, path, level + 1, | 736 | nilfs_btree_promote_key(btree, path, level + 1, |
| 719 | nilfs_btree_node_get_key(node, 0)); | 737 | nilfs_btree_node_get_key(node, 0)); |
| 720 | 738 | ||
| @@ -740,9 +758,6 @@ static void nilfs_btree_carry_right(struct nilfs_btree *btree, | |||
| 740 | struct nilfs_btree_node *node, *right; | 758 | struct nilfs_btree_node *node, *right; |
| 741 | int nchildren, rnchildren, n, move; | 759 | int nchildren, rnchildren, n, move; |
| 742 | 760 | ||
| 743 | lock_buffer(path[level].bp_bh); | ||
| 744 | lock_buffer(path[level].bp_sib_bh); | ||
| 745 | |||
| 746 | node = nilfs_btree_get_nonroot_node(path, level); | 761 | node = nilfs_btree_get_nonroot_node(path, level); |
| 747 | right = nilfs_btree_get_sib_node(path, level); | 762 | right = nilfs_btree_get_sib_node(path, level); |
| 748 | nchildren = nilfs_btree_node_get_nchildren(node); | 763 | nchildren = nilfs_btree_node_get_nchildren(node); |
| @@ -763,9 +778,6 @@ static void nilfs_btree_carry_right(struct nilfs_btree *btree, | |||
| 763 | if (!buffer_dirty(path[level].bp_sib_bh)) | 778 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 764 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 779 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 765 | 780 | ||
| 766 | unlock_buffer(path[level].bp_bh); | ||
| 767 | unlock_buffer(path[level].bp_sib_bh); | ||
| 768 | |||
| 769 | path[level + 1].bp_index++; | 781 | path[level + 1].bp_index++; |
| 770 | nilfs_btree_promote_key(btree, path, level + 1, | 782 | nilfs_btree_promote_key(btree, path, level + 1, |
| 771 | nilfs_btree_node_get_key(right, 0)); | 783 | nilfs_btree_node_get_key(right, 0)); |
| @@ -794,9 +806,6 @@ static void nilfs_btree_split(struct nilfs_btree *btree, | |||
| 794 | __u64 newptr; | 806 | __u64 newptr; |
| 795 | int nchildren, n, move; | 807 | int nchildren, n, move; |
| 796 | 808 | ||
| 797 | lock_buffer(path[level].bp_bh); | ||
| 798 | lock_buffer(path[level].bp_sib_bh); | ||
| 799 | |||
| 800 | node = nilfs_btree_get_nonroot_node(path, level); | 809 | node = nilfs_btree_get_nonroot_node(path, level); |
| 801 | right = nilfs_btree_get_sib_node(path, level); | 810 | right = nilfs_btree_get_sib_node(path, level); |
| 802 | nchildren = nilfs_btree_node_get_nchildren(node); | 811 | nchildren = nilfs_btree_node_get_nchildren(node); |
| @@ -815,9 +824,6 @@ static void nilfs_btree_split(struct nilfs_btree *btree, | |||
| 815 | if (!buffer_dirty(path[level].bp_sib_bh)) | 824 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 816 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 825 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 817 | 826 | ||
| 818 | unlock_buffer(path[level].bp_bh); | ||
| 819 | unlock_buffer(path[level].bp_sib_bh); | ||
| 820 | |||
| 821 | newkey = nilfs_btree_node_get_key(right, 0); | 827 | newkey = nilfs_btree_node_get_key(right, 0); |
| 822 | newptr = path[level].bp_newreq.bpr_ptr; | 828 | newptr = path[level].bp_newreq.bpr_ptr; |
| 823 | 829 | ||
| @@ -852,8 +858,6 @@ static void nilfs_btree_grow(struct nilfs_btree *btree, | |||
| 852 | struct nilfs_btree_node *root, *child; | 858 | struct nilfs_btree_node *root, *child; |
| 853 | int n; | 859 | int n; |
| 854 | 860 | ||
| 855 | lock_buffer(path[level].bp_sib_bh); | ||
| 856 | |||
| 857 | root = nilfs_btree_get_root(btree); | 861 | root = nilfs_btree_get_root(btree); |
| 858 | child = nilfs_btree_get_sib_node(path, level); | 862 | child = nilfs_btree_get_sib_node(path, level); |
| 859 | 863 | ||
| @@ -865,8 +869,6 @@ static void nilfs_btree_grow(struct nilfs_btree *btree, | |||
| 865 | if (!buffer_dirty(path[level].bp_sib_bh)) | 869 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 866 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 870 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 867 | 871 | ||
| 868 | unlock_buffer(path[level].bp_sib_bh); | ||
| 869 | |||
| 870 | path[level].bp_bh = path[level].bp_sib_bh; | 872 | path[level].bp_bh = path[level].bp_sib_bh; |
| 871 | path[level].bp_sib_bh = NULL; | 873 | path[level].bp_sib_bh = NULL; |
| 872 | 874 | ||
| @@ -1023,11 +1025,9 @@ static int nilfs_btree_prepare_insert(struct nilfs_btree *btree, | |||
| 1023 | 1025 | ||
| 1024 | stats->bs_nblocks++; | 1026 | stats->bs_nblocks++; |
| 1025 | 1027 | ||
| 1026 | lock_buffer(bh); | ||
| 1027 | nilfs_btree_node_init(btree, | 1028 | nilfs_btree_node_init(btree, |
| 1028 | (struct nilfs_btree_node *)bh->b_data, | 1029 | (struct nilfs_btree_node *)bh->b_data, |
| 1029 | 0, level, 0, NULL, NULL); | 1030 | 0, level, 0, NULL, NULL); |
| 1030 | unlock_buffer(bh); | ||
| 1031 | path[level].bp_sib_bh = bh; | 1031 | path[level].bp_sib_bh = bh; |
| 1032 | path[level].bp_op = nilfs_btree_split; | 1032 | path[level].bp_op = nilfs_btree_split; |
| 1033 | } | 1033 | } |
| @@ -1052,10 +1052,8 @@ static int nilfs_btree_prepare_insert(struct nilfs_btree *btree, | |||
| 1052 | if (ret < 0) | 1052 | if (ret < 0) |
| 1053 | goto err_out_curr_node; | 1053 | goto err_out_curr_node; |
| 1054 | 1054 | ||
| 1055 | lock_buffer(bh); | ||
| 1056 | nilfs_btree_node_init(btree, (struct nilfs_btree_node *)bh->b_data, | 1055 | nilfs_btree_node_init(btree, (struct nilfs_btree_node *)bh->b_data, |
| 1057 | 0, level, 0, NULL, NULL); | 1056 | 0, level, 0, NULL, NULL); |
| 1058 | unlock_buffer(bh); | ||
| 1059 | path[level].bp_sib_bh = bh; | 1057 | path[level].bp_sib_bh = bh; |
| 1060 | path[level].bp_op = nilfs_btree_grow; | 1058 | path[level].bp_op = nilfs_btree_grow; |
| 1061 | 1059 | ||
| @@ -1154,13 +1152,11 @@ static void nilfs_btree_do_delete(struct nilfs_btree *btree, | |||
| 1154 | struct nilfs_btree_node *node; | 1152 | struct nilfs_btree_node *node; |
| 1155 | 1153 | ||
| 1156 | if (level < nilfs_btree_height(btree) - 1) { | 1154 | if (level < nilfs_btree_height(btree) - 1) { |
| 1157 | lock_buffer(path[level].bp_bh); | ||
| 1158 | node = nilfs_btree_get_nonroot_node(path, level); | 1155 | node = nilfs_btree_get_nonroot_node(path, level); |
| 1159 | nilfs_btree_node_delete(btree, node, keyp, ptrp, | 1156 | nilfs_btree_node_delete(btree, node, keyp, ptrp, |
| 1160 | path[level].bp_index); | 1157 | path[level].bp_index); |
| 1161 | if (!buffer_dirty(path[level].bp_bh)) | 1158 | if (!buffer_dirty(path[level].bp_bh)) |
| 1162 | nilfs_btnode_mark_dirty(path[level].bp_bh); | 1159 | nilfs_btnode_mark_dirty(path[level].bp_bh); |
| 1163 | unlock_buffer(path[level].bp_bh); | ||
| 1164 | if (path[level].bp_index == 0) | 1160 | if (path[level].bp_index == 0) |
| 1165 | nilfs_btree_promote_key(btree, path, level + 1, | 1161 | nilfs_btree_promote_key(btree, path, level + 1, |
| 1166 | nilfs_btree_node_get_key(node, 0)); | 1162 | nilfs_btree_node_get_key(node, 0)); |
| @@ -1180,9 +1176,6 @@ static void nilfs_btree_borrow_left(struct nilfs_btree *btree, | |||
| 1180 | 1176 | ||
| 1181 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); | 1177 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); |
| 1182 | 1178 | ||
| 1183 | lock_buffer(path[level].bp_bh); | ||
| 1184 | lock_buffer(path[level].bp_sib_bh); | ||
| 1185 | |||
| 1186 | node = nilfs_btree_get_nonroot_node(path, level); | 1179 | node = nilfs_btree_get_nonroot_node(path, level); |
| 1187 | left = nilfs_btree_get_sib_node(path, level); | 1180 | left = nilfs_btree_get_sib_node(path, level); |
| 1188 | nchildren = nilfs_btree_node_get_nchildren(node); | 1181 | nchildren = nilfs_btree_node_get_nchildren(node); |
| @@ -1197,9 +1190,6 @@ static void nilfs_btree_borrow_left(struct nilfs_btree *btree, | |||
| 1197 | if (!buffer_dirty(path[level].bp_sib_bh)) | 1190 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 1198 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 1191 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 1199 | 1192 | ||
| 1200 | unlock_buffer(path[level].bp_bh); | ||
| 1201 | unlock_buffer(path[level].bp_sib_bh); | ||
| 1202 | |||
| 1203 | nilfs_btree_promote_key(btree, path, level + 1, | 1193 | nilfs_btree_promote_key(btree, path, level + 1, |
| 1204 | nilfs_btree_node_get_key(node, 0)); | 1194 | nilfs_btree_node_get_key(node, 0)); |
| 1205 | 1195 | ||
| @@ -1217,9 +1207,6 @@ static void nilfs_btree_borrow_right(struct nilfs_btree *btree, | |||
| 1217 | 1207 | ||
| 1218 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); | 1208 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); |
| 1219 | 1209 | ||
| 1220 | lock_buffer(path[level].bp_bh); | ||
| 1221 | lock_buffer(path[level].bp_sib_bh); | ||
| 1222 | |||
| 1223 | node = nilfs_btree_get_nonroot_node(path, level); | 1210 | node = nilfs_btree_get_nonroot_node(path, level); |
| 1224 | right = nilfs_btree_get_sib_node(path, level); | 1211 | right = nilfs_btree_get_sib_node(path, level); |
| 1225 | nchildren = nilfs_btree_node_get_nchildren(node); | 1212 | nchildren = nilfs_btree_node_get_nchildren(node); |
| @@ -1234,9 +1221,6 @@ static void nilfs_btree_borrow_right(struct nilfs_btree *btree, | |||
| 1234 | if (!buffer_dirty(path[level].bp_sib_bh)) | 1221 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 1235 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 1222 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 1236 | 1223 | ||
| 1237 | unlock_buffer(path[level].bp_bh); | ||
| 1238 | unlock_buffer(path[level].bp_sib_bh); | ||
| 1239 | |||
| 1240 | path[level + 1].bp_index++; | 1224 | path[level + 1].bp_index++; |
| 1241 | nilfs_btree_promote_key(btree, path, level + 1, | 1225 | nilfs_btree_promote_key(btree, path, level + 1, |
| 1242 | nilfs_btree_node_get_key(right, 0)); | 1226 | nilfs_btree_node_get_key(right, 0)); |
| @@ -1255,9 +1239,6 @@ static void nilfs_btree_concat_left(struct nilfs_btree *btree, | |||
| 1255 | 1239 | ||
| 1256 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); | 1240 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); |
| 1257 | 1241 | ||
| 1258 | lock_buffer(path[level].bp_bh); | ||
| 1259 | lock_buffer(path[level].bp_sib_bh); | ||
| 1260 | |||
| 1261 | node = nilfs_btree_get_nonroot_node(path, level); | 1242 | node = nilfs_btree_get_nonroot_node(path, level); |
| 1262 | left = nilfs_btree_get_sib_node(path, level); | 1243 | left = nilfs_btree_get_sib_node(path, level); |
| 1263 | 1244 | ||
| @@ -1268,9 +1249,6 @@ static void nilfs_btree_concat_left(struct nilfs_btree *btree, | |||
| 1268 | if (!buffer_dirty(path[level].bp_sib_bh)) | 1249 | if (!buffer_dirty(path[level].bp_sib_bh)) |
| 1269 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); | 1250 | nilfs_btnode_mark_dirty(path[level].bp_sib_bh); |
| 1270 | 1251 | ||
| 1271 | unlock_buffer(path[level].bp_bh); | ||
| 1272 | unlock_buffer(path[level].bp_sib_bh); | ||
| 1273 | |||
| 1274 | nilfs_btnode_delete(path[level].bp_bh); | 1252 | nilfs_btnode_delete(path[level].bp_bh); |
| 1275 | path[level].bp_bh = path[level].bp_sib_bh; | 1253 | path[level].bp_bh = path[level].bp_sib_bh; |
| 1276 | path[level].bp_sib_bh = NULL; | 1254 | path[level].bp_sib_bh = NULL; |
| @@ -1286,9 +1264,6 @@ static void nilfs_btree_concat_right(struct nilfs_btree *btree, | |||
| 1286 | 1264 | ||
| 1287 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); | 1265 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); |
| 1288 | 1266 | ||
| 1289 | lock_buffer(path[level].bp_bh); | ||
| 1290 | lock_buffer(path[level].bp_sib_bh); | ||
| 1291 | |||
| 1292 | node = nilfs_btree_get_nonroot_node(path, level); | 1267 | node = nilfs_btree_get_nonroot_node(path, level); |
| 1293 | right = nilfs_btree_get_sib_node(path, level); | 1268 | right = nilfs_btree_get_sib_node(path, level); |
| 1294 | 1269 | ||
| @@ -1299,9 +1274,6 @@ static void nilfs_btree_concat_right(struct nilfs_btree *btree, | |||
| 1299 | if (!buffer_dirty(path[level].bp_bh)) | 1274 | if (!buffer_dirty(path[level].bp_bh)) |
| 1300 | nilfs_btnode_mark_dirty(path[level].bp_bh); | 1275 | nilfs_btnode_mark_dirty(path[level].bp_bh); |
| 1301 | 1276 | ||
| 1302 | unlock_buffer(path[level].bp_bh); | ||
| 1303 | unlock_buffer(path[level].bp_sib_bh); | ||
| 1304 | |||
| 1305 | nilfs_btnode_delete(path[level].bp_sib_bh); | 1277 | nilfs_btnode_delete(path[level].bp_sib_bh); |
| 1306 | path[level].bp_sib_bh = NULL; | 1278 | path[level].bp_sib_bh = NULL; |
| 1307 | path[level + 1].bp_index++; | 1279 | path[level + 1].bp_index++; |
| @@ -1316,7 +1288,6 @@ static void nilfs_btree_shrink(struct nilfs_btree *btree, | |||
| 1316 | 1288 | ||
| 1317 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); | 1289 | nilfs_btree_do_delete(btree, path, level, keyp, ptrp); |
| 1318 | 1290 | ||
| 1319 | lock_buffer(path[level].bp_bh); | ||
| 1320 | root = nilfs_btree_get_root(btree); | 1291 | root = nilfs_btree_get_root(btree); |
| 1321 | child = nilfs_btree_get_nonroot_node(path, level); | 1292 | child = nilfs_btree_get_nonroot_node(path, level); |
| 1322 | 1293 | ||
| @@ -1324,7 +1295,6 @@ static void nilfs_btree_shrink(struct nilfs_btree *btree, | |||
| 1324 | nilfs_btree_node_set_level(root, level); | 1295 | nilfs_btree_node_set_level(root, level); |
| 1325 | n = nilfs_btree_node_get_nchildren(child); | 1296 | n = nilfs_btree_node_get_nchildren(child); |
| 1326 | nilfs_btree_node_move_left(btree, root, child, n); | 1297 | nilfs_btree_node_move_left(btree, root, child, n); |
| 1327 | unlock_buffer(path[level].bp_bh); | ||
| 1328 | 1298 | ||
| 1329 | nilfs_btnode_delete(path[level].bp_bh); | 1299 | nilfs_btnode_delete(path[level].bp_bh); |
| 1330 | path[level].bp_bh = NULL; | 1300 | path[level].bp_bh = NULL; |
| @@ -1699,7 +1669,6 @@ nilfs_btree_commit_convert_and_insert(struct nilfs_bmap *bmap, | |||
| 1699 | nilfs_bmap_commit_alloc_ptr(bmap, nreq, dat); | 1669 | nilfs_bmap_commit_alloc_ptr(bmap, nreq, dat); |
| 1700 | 1670 | ||
| 1701 | /* create child node at level 1 */ | 1671 | /* create child node at level 1 */ |
| 1702 | lock_buffer(bh); | ||
| 1703 | node = (struct nilfs_btree_node *)bh->b_data; | 1672 | node = (struct nilfs_btree_node *)bh->b_data; |
| 1704 | nilfs_btree_node_init(btree, node, 0, 1, n, keys, ptrs); | 1673 | nilfs_btree_node_init(btree, node, 0, 1, n, keys, ptrs); |
| 1705 | nilfs_btree_node_insert(btree, node, | 1674 | nilfs_btree_node_insert(btree, node, |
| @@ -1709,7 +1678,6 @@ nilfs_btree_commit_convert_and_insert(struct nilfs_bmap *bmap, | |||
| 1709 | if (!nilfs_bmap_dirty(bmap)) | 1678 | if (!nilfs_bmap_dirty(bmap)) |
| 1710 | nilfs_bmap_set_dirty(bmap); | 1679 | nilfs_bmap_set_dirty(bmap); |
| 1711 | 1680 | ||
| 1712 | unlock_buffer(bh); | ||
| 1713 | brelse(bh); | 1681 | brelse(bh); |
| 1714 | 1682 | ||
| 1715 | /* create root node at level 2 */ | 1683 | /* create root node at level 2 */ |
| @@ -2050,7 +2018,7 @@ static void nilfs_btree_lookup_dirty_buffers(struct nilfs_bmap *bmap, | |||
| 2050 | for (level = NILFS_BTREE_LEVEL_NODE_MIN; | 2018 | for (level = NILFS_BTREE_LEVEL_NODE_MIN; |
| 2051 | level < NILFS_BTREE_LEVEL_MAX; | 2019 | level < NILFS_BTREE_LEVEL_MAX; |
| 2052 | level++) | 2020 | level++) |
| 2053 | list_splice(&lists[level], listp->prev); | 2021 | list_splice_tail(&lists[level], listp); |
| 2054 | } | 2022 | } |
| 2055 | 2023 | ||
| 2056 | static int nilfs_btree_assign_p(struct nilfs_btree *btree, | 2024 | static int nilfs_btree_assign_p(struct nilfs_btree *btree, |
diff --git a/fs/nilfs2/btree.h b/fs/nilfs2/btree.h index 0e72bbbc6b64..4b82d84ade75 100644 --- a/fs/nilfs2/btree.h +++ b/fs/nilfs2/btree.h | |||
| @@ -34,28 +34,6 @@ struct nilfs_btree; | |||
| 34 | struct nilfs_btree_path; | 34 | struct nilfs_btree_path; |
| 35 | 35 | ||
| 36 | /** | 36 | /** |
| 37 | * struct nilfs_btree_node - B-tree node | ||
| 38 | * @bn_flags: flags | ||
| 39 | * @bn_level: level | ||
| 40 | * @bn_nchildren: number of children | ||
| 41 | * @bn_pad: padding | ||
| 42 | */ | ||
| 43 | struct nilfs_btree_node { | ||
| 44 | __u8 bn_flags; | ||
| 45 | __u8 bn_level; | ||
| 46 | __le16 bn_nchildren; | ||
| 47 | __le32 bn_pad; | ||
| 48 | }; | ||
| 49 | |||
| 50 | /* flags */ | ||
| 51 | #define NILFS_BTREE_NODE_ROOT 0x01 | ||
| 52 | |||
| 53 | /* level */ | ||
| 54 | #define NILFS_BTREE_LEVEL_DATA 0 | ||
| 55 | #define NILFS_BTREE_LEVEL_NODE_MIN (NILFS_BTREE_LEVEL_DATA + 1) | ||
| 56 | #define NILFS_BTREE_LEVEL_MAX 14 | ||
| 57 | |||
| 58 | /** | ||
| 59 | * struct nilfs_btree - B-tree structure | 37 | * struct nilfs_btree - B-tree structure |
| 60 | * @bt_bmap: bmap base structure | 38 | * @bt_bmap: bmap base structure |
| 61 | */ | 39 | */ |
diff --git a/fs/nilfs2/cpfile.c b/fs/nilfs2/cpfile.c index 3f5d5d06f53c..d5ad54e204a5 100644 --- a/fs/nilfs2/cpfile.c +++ b/fs/nilfs2/cpfile.c | |||
| @@ -926,3 +926,29 @@ int nilfs_cpfile_get_stat(struct inode *cpfile, struct nilfs_cpstat *cpstat) | |||
| 926 | up_read(&NILFS_MDT(cpfile)->mi_sem); | 926 | up_read(&NILFS_MDT(cpfile)->mi_sem); |
| 927 | return ret; | 927 | return ret; |
| 928 | } | 928 | } |
| 929 | |||
| 930 | /** | ||
| 931 | * nilfs_cpfile_read - read cpfile inode | ||
| 932 | * @cpfile: cpfile inode | ||
| 933 | * @raw_inode: on-disk cpfile inode | ||
| 934 | */ | ||
| 935 | int nilfs_cpfile_read(struct inode *cpfile, struct nilfs_inode *raw_inode) | ||
| 936 | { | ||
| 937 | return nilfs_read_inode_common(cpfile, raw_inode); | ||
| 938 | } | ||
| 939 | |||
| 940 | /** | ||
| 941 | * nilfs_cpfile_new - create cpfile | ||
| 942 | * @nilfs: nilfs object | ||
| 943 | * @cpsize: size of a checkpoint entry | ||
| 944 | */ | ||
| 945 | struct inode *nilfs_cpfile_new(struct the_nilfs *nilfs, size_t cpsize) | ||
| 946 | { | ||
| 947 | struct inode *cpfile; | ||
| 948 | |||
| 949 | cpfile = nilfs_mdt_new(nilfs, NULL, NILFS_CPFILE_INO, 0); | ||
| 950 | if (cpfile) | ||
| 951 | nilfs_mdt_set_entry_size(cpfile, cpsize, | ||
| 952 | sizeof(struct nilfs_cpfile_header)); | ||
| 953 | return cpfile; | ||
| 954 | } | ||
diff --git a/fs/nilfs2/cpfile.h b/fs/nilfs2/cpfile.h index debea896e701..bc0809e0ab43 100644 --- a/fs/nilfs2/cpfile.h +++ b/fs/nilfs2/cpfile.h | |||
| @@ -40,4 +40,7 @@ int nilfs_cpfile_get_stat(struct inode *, struct nilfs_cpstat *); | |||
| 40 | ssize_t nilfs_cpfile_get_cpinfo(struct inode *, __u64 *, int, void *, unsigned, | 40 | ssize_t nilfs_cpfile_get_cpinfo(struct inode *, __u64 *, int, void *, unsigned, |
| 41 | size_t); | 41 | size_t); |
| 42 | 42 | ||
| 43 | int nilfs_cpfile_read(struct inode *cpfile, struct nilfs_inode *raw_inode); | ||
| 44 | struct inode *nilfs_cpfile_new(struct the_nilfs *nilfs, size_t cpsize); | ||
| 45 | |||
| 43 | #endif /* _NILFS_CPFILE_H */ | 46 | #endif /* _NILFS_CPFILE_H */ |
diff --git a/fs/nilfs2/dat.c b/fs/nilfs2/dat.c index 1ff8e15bd36b..187dd07ba86c 100644 --- a/fs/nilfs2/dat.c +++ b/fs/nilfs2/dat.c | |||
| @@ -33,6 +33,16 @@ | |||
| 33 | #define NILFS_CNO_MIN ((__u64)1) | 33 | #define NILFS_CNO_MIN ((__u64)1) |
| 34 | #define NILFS_CNO_MAX (~(__u64)0) | 34 | #define NILFS_CNO_MAX (~(__u64)0) |
| 35 | 35 | ||
| 36 | struct nilfs_dat_info { | ||
| 37 | struct nilfs_mdt_info mi; | ||
| 38 | struct nilfs_palloc_cache palloc_cache; | ||
| 39 | }; | ||
| 40 | |||
| 41 | static inline struct nilfs_dat_info *NILFS_DAT_I(struct inode *dat) | ||
| 42 | { | ||
| 43 | return (struct nilfs_dat_info *)NILFS_MDT(dat); | ||
| 44 | } | ||
| 45 | |||
| 36 | static int nilfs_dat_prepare_entry(struct inode *dat, | 46 | static int nilfs_dat_prepare_entry(struct inode *dat, |
| 37 | struct nilfs_palloc_req *req, int create) | 47 | struct nilfs_palloc_req *req, int create) |
| 38 | { | 48 | { |
| @@ -425,3 +435,40 @@ ssize_t nilfs_dat_get_vinfo(struct inode *dat, void *buf, unsigned visz, | |||
| 425 | 435 | ||
| 426 | return nvi; | 436 | return nvi; |
| 427 | } | 437 | } |
| 438 | |||
| 439 | /** | ||
| 440 | * nilfs_dat_read - read dat inode | ||
| 441 | * @dat: dat inode | ||
| 442 | * @raw_inode: on-disk dat inode | ||
| 443 | */ | ||
| 444 | int nilfs_dat_read(struct inode *dat, struct nilfs_inode *raw_inode) | ||
| 445 | { | ||
| 446 | return nilfs_read_inode_common(dat, raw_inode); | ||
| 447 | } | ||
| 448 | |||
| 449 | /** | ||
| 450 | * nilfs_dat_new - create dat file | ||
| 451 | * @nilfs: nilfs object | ||
| 452 | * @entry_size: size of a dat entry | ||
| 453 | */ | ||
| 454 | struct inode *nilfs_dat_new(struct the_nilfs *nilfs, size_t entry_size) | ||
| 455 | { | ||
| 456 | static struct lock_class_key dat_lock_key; | ||
| 457 | struct inode *dat; | ||
| 458 | struct nilfs_dat_info *di; | ||
| 459 | int err; | ||
| 460 | |||
| 461 | dat = nilfs_mdt_new(nilfs, NULL, NILFS_DAT_INO, sizeof(*di)); | ||
| 462 | if (dat) { | ||
| 463 | err = nilfs_palloc_init_blockgroup(dat, entry_size); | ||
| 464 | if (unlikely(err)) { | ||
| 465 | nilfs_mdt_destroy(dat); | ||
| 466 | return NULL; | ||
| 467 | } | ||
| 468 | |||
| 469 | di = NILFS_DAT_I(dat); | ||
| 470 | lockdep_set_class(&di->mi.mi_sem, &dat_lock_key); | ||
| 471 | nilfs_palloc_setup_cache(dat, &di->palloc_cache); | ||
| 472 | } | ||
| 473 | return dat; | ||
| 474 | } | ||
diff --git a/fs/nilfs2/dat.h b/fs/nilfs2/dat.h index 406070d3ff49..d31c3aab0efe 100644 --- a/fs/nilfs2/dat.h +++ b/fs/nilfs2/dat.h | |||
| @@ -53,4 +53,7 @@ int nilfs_dat_freev(struct inode *, __u64 *, size_t); | |||
| 53 | int nilfs_dat_move(struct inode *, __u64, sector_t); | 53 | int nilfs_dat_move(struct inode *, __u64, sector_t); |
| 54 | ssize_t nilfs_dat_get_vinfo(struct inode *, void *, unsigned, size_t); | 54 | ssize_t nilfs_dat_get_vinfo(struct inode *, void *, unsigned, size_t); |
| 55 | 55 | ||
| 56 | int nilfs_dat_read(struct inode *dat, struct nilfs_inode *raw_inode); | ||
| 57 | struct inode *nilfs_dat_new(struct the_nilfs *nilfs, size_t entry_size); | ||
| 58 | |||
| 56 | #endif /* _NILFS_DAT_H */ | 59 | #endif /* _NILFS_DAT_H */ |
diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index e097099bfc8f..76d803e060a9 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c | |||
| @@ -99,9 +99,9 @@ static int nilfs_prepare_chunk(struct page *page, | |||
| 99 | NULL, nilfs_get_block); | 99 | NULL, nilfs_get_block); |
| 100 | } | 100 | } |
| 101 | 101 | ||
| 102 | static int nilfs_commit_chunk(struct page *page, | 102 | static void nilfs_commit_chunk(struct page *page, |
| 103 | struct address_space *mapping, | 103 | struct address_space *mapping, |
| 104 | unsigned from, unsigned to) | 104 | unsigned from, unsigned to) |
| 105 | { | 105 | { |
| 106 | struct inode *dir = mapping->host; | 106 | struct inode *dir = mapping->host; |
| 107 | struct nilfs_sb_info *sbi = NILFS_SB(dir->i_sb); | 107 | struct nilfs_sb_info *sbi = NILFS_SB(dir->i_sb); |
| @@ -112,15 +112,13 @@ static int nilfs_commit_chunk(struct page *page, | |||
| 112 | 112 | ||
| 113 | nr_dirty = nilfs_page_count_clean_buffers(page, from, to); | 113 | nr_dirty = nilfs_page_count_clean_buffers(page, from, to); |
| 114 | copied = block_write_end(NULL, mapping, pos, len, len, page, NULL); | 114 | copied = block_write_end(NULL, mapping, pos, len, len, page, NULL); |
| 115 | if (pos + copied > dir->i_size) { | 115 | if (pos + copied > dir->i_size) |
| 116 | i_size_write(dir, pos + copied); | 116 | i_size_write(dir, pos + copied); |
| 117 | mark_inode_dirty(dir); | ||
| 118 | } | ||
| 119 | if (IS_DIRSYNC(dir)) | 117 | if (IS_DIRSYNC(dir)) |
| 120 | nilfs_set_transaction_flag(NILFS_TI_SYNC); | 118 | nilfs_set_transaction_flag(NILFS_TI_SYNC); |
| 121 | err = nilfs_set_file_dirty(sbi, dir, nr_dirty); | 119 | err = nilfs_set_file_dirty(sbi, dir, nr_dirty); |
| 120 | WARN_ON(err); /* do not happen */ | ||
| 122 | unlock_page(page); | 121 | unlock_page(page); |
| 123 | return err; | ||
| 124 | } | 122 | } |
| 125 | 123 | ||
| 126 | static void nilfs_check_page(struct page *page) | 124 | static void nilfs_check_page(struct page *page) |
| @@ -455,11 +453,10 @@ void nilfs_set_link(struct inode *dir, struct nilfs_dir_entry *de, | |||
| 455 | BUG_ON(err); | 453 | BUG_ON(err); |
| 456 | de->inode = cpu_to_le64(inode->i_ino); | 454 | de->inode = cpu_to_le64(inode->i_ino); |
| 457 | nilfs_set_de_type(de, inode); | 455 | nilfs_set_de_type(de, inode); |
| 458 | err = nilfs_commit_chunk(page, mapping, from, to); | 456 | nilfs_commit_chunk(page, mapping, from, to); |
| 459 | nilfs_put_page(page); | 457 | nilfs_put_page(page); |
| 460 | dir->i_mtime = dir->i_ctime = CURRENT_TIME; | 458 | dir->i_mtime = dir->i_ctime = CURRENT_TIME; |
| 461 | /* NILFS_I(dir)->i_flags &= ~NILFS_BTREE_FL; */ | 459 | /* NILFS_I(dir)->i_flags &= ~NILFS_BTREE_FL; */ |
| 462 | mark_inode_dirty(dir); | ||
| 463 | } | 460 | } |
| 464 | 461 | ||
| 465 | /* | 462 | /* |
| @@ -548,10 +545,10 @@ got_it: | |||
| 548 | memcpy(de->name, name, namelen); | 545 | memcpy(de->name, name, namelen); |
| 549 | de->inode = cpu_to_le64(inode->i_ino); | 546 | de->inode = cpu_to_le64(inode->i_ino); |
| 550 | nilfs_set_de_type(de, inode); | 547 | nilfs_set_de_type(de, inode); |
| 551 | err = nilfs_commit_chunk(page, page->mapping, from, to); | 548 | nilfs_commit_chunk(page, page->mapping, from, to); |
| 552 | dir->i_mtime = dir->i_ctime = CURRENT_TIME; | 549 | dir->i_mtime = dir->i_ctime = CURRENT_TIME; |
| 553 | /* NILFS_I(dir)->i_flags &= ~NILFS_BTREE_FL; */ | 550 | /* NILFS_I(dir)->i_flags &= ~NILFS_BTREE_FL; */ |
| 554 | mark_inode_dirty(dir); | 551 | nilfs_mark_inode_dirty(dir); |
| 555 | /* OFFSET_CACHE */ | 552 | /* OFFSET_CACHE */ |
| 556 | out_put: | 553 | out_put: |
| 557 | nilfs_put_page(page); | 554 | nilfs_put_page(page); |
| @@ -595,10 +592,9 @@ int nilfs_delete_entry(struct nilfs_dir_entry *dir, struct page *page) | |||
| 595 | if (pde) | 592 | if (pde) |
| 596 | pde->rec_len = cpu_to_le16(to - from); | 593 | pde->rec_len = cpu_to_le16(to - from); |
| 597 | dir->inode = 0; | 594 | dir->inode = 0; |
| 598 | err = nilfs_commit_chunk(page, mapping, from, to); | 595 | nilfs_commit_chunk(page, mapping, from, to); |
| 599 | inode->i_ctime = inode->i_mtime = CURRENT_TIME; | 596 | inode->i_ctime = inode->i_mtime = CURRENT_TIME; |
| 600 | /* NILFS_I(inode)->i_flags &= ~NILFS_BTREE_FL; */ | 597 | /* NILFS_I(inode)->i_flags &= ~NILFS_BTREE_FL; */ |
| 601 | mark_inode_dirty(inode); | ||
| 602 | out: | 598 | out: |
| 603 | nilfs_put_page(page); | 599 | nilfs_put_page(page); |
| 604 | return err; | 600 | return err; |
| @@ -640,7 +636,7 @@ int nilfs_make_empty(struct inode *inode, struct inode *parent) | |||
| 640 | memcpy(de->name, "..\0", 4); | 636 | memcpy(de->name, "..\0", 4); |
| 641 | nilfs_set_de_type(de, inode); | 637 | nilfs_set_de_type(de, inode); |
| 642 | kunmap_atomic(kaddr, KM_USER0); | 638 | kunmap_atomic(kaddr, KM_USER0); |
| 643 | err = nilfs_commit_chunk(page, mapping, 0, chunk_size); | 639 | nilfs_commit_chunk(page, mapping, 0, chunk_size); |
| 644 | fail: | 640 | fail: |
| 645 | page_cache_release(page); | 641 | page_cache_release(page); |
| 646 | return err; | 642 | return err; |
diff --git a/fs/nilfs2/gcdat.c b/fs/nilfs2/gcdat.c index 93383c5cee90..dd5f7e0a95f6 100644 --- a/fs/nilfs2/gcdat.c +++ b/fs/nilfs2/gcdat.c | |||
| @@ -61,6 +61,8 @@ void nilfs_commit_gcdat_inode(struct the_nilfs *nilfs) | |||
| 61 | 61 | ||
| 62 | nilfs_bmap_commit_gcdat(gii->i_bmap, dii->i_bmap); | 62 | nilfs_bmap_commit_gcdat(gii->i_bmap, dii->i_bmap); |
| 63 | 63 | ||
| 64 | nilfs_palloc_clear_cache(dat); | ||
| 65 | nilfs_palloc_clear_cache(gcdat); | ||
| 64 | nilfs_clear_dirty_pages(mapping); | 66 | nilfs_clear_dirty_pages(mapping); |
| 65 | nilfs_copy_back_pages(mapping, gmapping); | 67 | nilfs_copy_back_pages(mapping, gmapping); |
| 66 | /* note: mdt dirty flags should be cleared by segctor. */ | 68 | /* note: mdt dirty flags should be cleared by segctor. */ |
| @@ -79,6 +81,7 @@ void nilfs_clear_gcdat_inode(struct the_nilfs *nilfs) | |||
| 79 | gcdat->i_state = I_CLEAR; | 81 | gcdat->i_state = I_CLEAR; |
| 80 | gii->i_flags = 0; | 82 | gii->i_flags = 0; |
| 81 | 83 | ||
| 84 | nilfs_palloc_clear_cache(gcdat); | ||
| 82 | truncate_inode_pages(gcdat->i_mapping, 0); | 85 | truncate_inode_pages(gcdat->i_mapping, 0); |
| 83 | truncate_inode_pages(&gii->i_btnode_cache, 0); | 86 | truncate_inode_pages(&gii->i_btnode_cache, 0); |
| 84 | } | 87 | } |
diff --git a/fs/nilfs2/gcinode.c b/fs/nilfs2/gcinode.c index e6de0a27ab5d..e16a6664dfa2 100644 --- a/fs/nilfs2/gcinode.c +++ b/fs/nilfs2/gcinode.c | |||
| @@ -149,7 +149,7 @@ int nilfs_gccache_submit_read_node(struct inode *inode, sector_t pbn, | |||
| 149 | __u64 vbn, struct buffer_head **out_bh) | 149 | __u64 vbn, struct buffer_head **out_bh) |
| 150 | { | 150 | { |
| 151 | int ret = nilfs_btnode_submit_block(&NILFS_I(inode)->i_btnode_cache, | 151 | int ret = nilfs_btnode_submit_block(&NILFS_I(inode)->i_btnode_cache, |
| 152 | vbn ? : pbn, pbn, out_bh, 0); | 152 | vbn ? : pbn, pbn, out_bh); |
| 153 | if (ret == -EEXIST) /* internal code (cache hit) */ | 153 | if (ret == -EEXIST) /* internal code (cache hit) */ |
| 154 | ret = 0; | 154 | ret = 0; |
| 155 | return ret; | 155 | return ret; |
| @@ -212,9 +212,10 @@ void nilfs_destroy_gccache(struct the_nilfs *nilfs) | |||
| 212 | static struct inode *alloc_gcinode(struct the_nilfs *nilfs, ino_t ino, | 212 | static struct inode *alloc_gcinode(struct the_nilfs *nilfs, ino_t ino, |
| 213 | __u64 cno) | 213 | __u64 cno) |
| 214 | { | 214 | { |
| 215 | struct inode *inode = nilfs_mdt_new_common(nilfs, NULL, ino, GFP_NOFS); | 215 | struct inode *inode; |
| 216 | struct nilfs_inode_info *ii; | 216 | struct nilfs_inode_info *ii; |
| 217 | 217 | ||
| 218 | inode = nilfs_mdt_new_common(nilfs, NULL, ino, GFP_NOFS, 0); | ||
| 218 | if (!inode) | 219 | if (!inode) |
| 219 | return NULL; | 220 | return NULL; |
| 220 | 221 | ||
| @@ -265,7 +266,6 @@ struct inode *nilfs_gc_iget(struct the_nilfs *nilfs, ino_t ino, __u64 cno) | |||
| 265 | */ | 266 | */ |
| 266 | void nilfs_clear_gcinode(struct inode *inode) | 267 | void nilfs_clear_gcinode(struct inode *inode) |
| 267 | { | 268 | { |
| 268 | nilfs_mdt_clear(inode); | ||
| 269 | nilfs_mdt_destroy(inode); | 269 | nilfs_mdt_destroy(inode); |
| 270 | } | 270 | } |
| 271 | 271 | ||
diff --git a/fs/nilfs2/ifile.c b/fs/nilfs2/ifile.c index de86401f209f..922d9dd42c8f 100644 --- a/fs/nilfs2/ifile.c +++ b/fs/nilfs2/ifile.c | |||
| @@ -29,6 +29,17 @@ | |||
| 29 | #include "alloc.h" | 29 | #include "alloc.h" |
| 30 | #include "ifile.h" | 30 | #include "ifile.h" |
| 31 | 31 | ||
| 32 | |||
| 33 | struct nilfs_ifile_info { | ||
| 34 | struct nilfs_mdt_info mi; | ||
| 35 | struct nilfs_palloc_cache palloc_cache; | ||
| 36 | }; | ||
| 37 | |||
| 38 | static inline struct nilfs_ifile_info *NILFS_IFILE_I(struct inode *ifile) | ||
| 39 | { | ||
| 40 | return (struct nilfs_ifile_info *)NILFS_MDT(ifile); | ||
| 41 | } | ||
| 42 | |||
| 32 | /** | 43 | /** |
| 33 | * nilfs_ifile_create_inode - create a new disk inode | 44 | * nilfs_ifile_create_inode - create a new disk inode |
| 34 | * @ifile: ifile inode | 45 | * @ifile: ifile inode |
| @@ -148,3 +159,27 @@ int nilfs_ifile_get_inode_block(struct inode *ifile, ino_t ino, | |||
| 148 | } | 159 | } |
| 149 | return err; | 160 | return err; |
| 150 | } | 161 | } |
| 162 | |||
| 163 | /** | ||
| 164 | * nilfs_ifile_new - create inode file | ||
| 165 | * @sbi: nilfs_sb_info struct | ||
| 166 | * @inode_size: size of an inode | ||
| 167 | */ | ||
| 168 | struct inode *nilfs_ifile_new(struct nilfs_sb_info *sbi, size_t inode_size) | ||
| 169 | { | ||
| 170 | struct inode *ifile; | ||
| 171 | int err; | ||
| 172 | |||
| 173 | ifile = nilfs_mdt_new(sbi->s_nilfs, sbi->s_super, NILFS_IFILE_INO, | ||
| 174 | sizeof(struct nilfs_ifile_info)); | ||
| 175 | if (ifile) { | ||
| 176 | err = nilfs_palloc_init_blockgroup(ifile, inode_size); | ||
| 177 | if (unlikely(err)) { | ||
| 178 | nilfs_mdt_destroy(ifile); | ||
| 179 | return NULL; | ||
| 180 | } | ||
| 181 | nilfs_palloc_setup_cache(ifile, | ||
| 182 | &NILFS_IFILE_I(ifile)->palloc_cache); | ||
| 183 | } | ||
| 184 | return ifile; | ||
| 185 | } | ||
diff --git a/fs/nilfs2/ifile.h b/fs/nilfs2/ifile.h index ecc3ba76db47..cbca32e498f2 100644 --- a/fs/nilfs2/ifile.h +++ b/fs/nilfs2/ifile.h | |||
| @@ -49,4 +49,6 @@ int nilfs_ifile_create_inode(struct inode *, ino_t *, struct buffer_head **); | |||
| 49 | int nilfs_ifile_delete_inode(struct inode *, ino_t); | 49 | int nilfs_ifile_delete_inode(struct inode *, ino_t); |
| 50 | int nilfs_ifile_get_inode_block(struct inode *, ino_t, struct buffer_head **); | 50 | int nilfs_ifile_get_inode_block(struct inode *, ino_t, struct buffer_head **); |
| 51 | 51 | ||
| 52 | struct inode *nilfs_ifile_new(struct nilfs_sb_info *sbi, size_t inode_size); | ||
| 53 | |||
| 52 | #endif /* _NILFS_IFILE_H */ | 54 | #endif /* _NILFS_IFILE_H */ |
diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index 2a0a5a3ac134..7868cc122ac7 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c | |||
| @@ -97,6 +97,7 @@ int nilfs_get_block(struct inode *inode, sector_t blkoff, | |||
| 97 | nilfs_transaction_abort(inode->i_sb); | 97 | nilfs_transaction_abort(inode->i_sb); |
| 98 | goto out; | 98 | goto out; |
| 99 | } | 99 | } |
| 100 | nilfs_mark_inode_dirty(inode); | ||
| 100 | nilfs_transaction_commit(inode->i_sb); /* never fails */ | 101 | nilfs_transaction_commit(inode->i_sb); /* never fails */ |
| 101 | /* Error handling should be detailed */ | 102 | /* Error handling should be detailed */ |
| 102 | set_buffer_new(bh_result); | 103 | set_buffer_new(bh_result); |
| @@ -322,7 +323,6 @@ struct inode *nilfs_new_inode(struct inode *dir, int mode) | |||
| 322 | nilfs_init_acl(), proper cancellation of | 323 | nilfs_init_acl(), proper cancellation of |
| 323 | above jobs should be considered */ | 324 | above jobs should be considered */ |
| 324 | 325 | ||
| 325 | mark_inode_dirty(inode); | ||
| 326 | return inode; | 326 | return inode; |
| 327 | 327 | ||
| 328 | failed_acl: | 328 | failed_acl: |
| @@ -525,7 +525,6 @@ void nilfs_update_inode(struct inode *inode, struct buffer_head *ibh) | |||
| 525 | 525 | ||
| 526 | raw_inode = nilfs_ifile_map_inode(sbi->s_ifile, ino, ibh); | 526 | raw_inode = nilfs_ifile_map_inode(sbi->s_ifile, ino, ibh); |
| 527 | 527 | ||
| 528 | /* The buffer is guarded with lock_buffer() by the caller */ | ||
| 529 | if (test_and_clear_bit(NILFS_I_NEW, &ii->i_state)) | 528 | if (test_and_clear_bit(NILFS_I_NEW, &ii->i_state)) |
| 530 | memset(raw_inode, 0, NILFS_MDT(sbi->s_ifile)->mi_entry_size); | 529 | memset(raw_inode, 0, NILFS_MDT(sbi->s_ifile)->mi_entry_size); |
| 531 | set_bit(NILFS_I_INODE_DIRTY, &ii->i_state); | 530 | set_bit(NILFS_I_INODE_DIRTY, &ii->i_state); |
| @@ -599,6 +598,7 @@ void nilfs_truncate(struct inode *inode) | |||
| 599 | if (IS_SYNC(inode)) | 598 | if (IS_SYNC(inode)) |
| 600 | nilfs_set_transaction_flag(NILFS_TI_SYNC); | 599 | nilfs_set_transaction_flag(NILFS_TI_SYNC); |
| 601 | 600 | ||
| 601 | nilfs_mark_inode_dirty(inode); | ||
| 602 | nilfs_set_file_dirty(NILFS_SB(sb), inode, 0); | 602 | nilfs_set_file_dirty(NILFS_SB(sb), inode, 0); |
| 603 | nilfs_transaction_commit(sb); | 603 | nilfs_transaction_commit(sb); |
| 604 | /* May construct a logical segment and may fail in sync mode. | 604 | /* May construct a logical segment and may fail in sync mode. |
| @@ -623,6 +623,7 @@ void nilfs_delete_inode(struct inode *inode) | |||
| 623 | truncate_inode_pages(&inode->i_data, 0); | 623 | truncate_inode_pages(&inode->i_data, 0); |
| 624 | 624 | ||
| 625 | nilfs_truncate_bmap(ii, 0); | 625 | nilfs_truncate_bmap(ii, 0); |
| 626 | nilfs_mark_inode_dirty(inode); | ||
| 626 | nilfs_free_inode(inode); | 627 | nilfs_free_inode(inode); |
| 627 | /* nilfs_free_inode() marks inode buffer dirty */ | 628 | /* nilfs_free_inode() marks inode buffer dirty */ |
| 628 | if (IS_SYNC(inode)) | 629 | if (IS_SYNC(inode)) |
| @@ -745,9 +746,7 @@ int nilfs_mark_inode_dirty(struct inode *inode) | |||
| 745 | "failed to reget inode block.\n"); | 746 | "failed to reget inode block.\n"); |
| 746 | return err; | 747 | return err; |
| 747 | } | 748 | } |
| 748 | lock_buffer(ibh); | ||
| 749 | nilfs_update_inode(inode, ibh); | 749 | nilfs_update_inode(inode, ibh); |
| 750 | unlock_buffer(ibh); | ||
| 751 | nilfs_mdt_mark_buffer_dirty(ibh); | 750 | nilfs_mdt_mark_buffer_dirty(ibh); |
| 752 | nilfs_mdt_mark_dirty(sbi->s_ifile); | 751 | nilfs_mdt_mark_dirty(sbi->s_ifile); |
| 753 | brelse(ibh); | 752 | brelse(ibh); |
diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c index f6326112d647..06713ffcc7f2 100644 --- a/fs/nilfs2/mdt.c +++ b/fs/nilfs2/mdt.c | |||
| @@ -186,7 +186,7 @@ nilfs_mdt_submit_block(struct inode *inode, unsigned long blkoff, | |||
| 186 | } | 186 | } |
| 187 | 187 | ||
| 188 | static int nilfs_mdt_read_block(struct inode *inode, unsigned long block, | 188 | static int nilfs_mdt_read_block(struct inode *inode, unsigned long block, |
| 189 | struct buffer_head **out_bh) | 189 | int readahead, struct buffer_head **out_bh) |
| 190 | { | 190 | { |
| 191 | struct buffer_head *first_bh, *bh; | 191 | struct buffer_head *first_bh, *bh; |
| 192 | unsigned long blkoff; | 192 | unsigned long blkoff; |
| @@ -200,16 +200,18 @@ static int nilfs_mdt_read_block(struct inode *inode, unsigned long block, | |||
| 200 | if (unlikely(err)) | 200 | if (unlikely(err)) |
| 201 | goto failed; | 201 | goto failed; |
| 202 | 202 | ||
| 203 | blkoff = block + 1; | 203 | if (readahead) { |
| 204 | for (i = 0; i < nr_ra_blocks; i++, blkoff++) { | 204 | blkoff = block + 1; |
| 205 | err = nilfs_mdt_submit_block(inode, blkoff, READA, &bh); | 205 | for (i = 0; i < nr_ra_blocks; i++, blkoff++) { |
| 206 | if (likely(!err || err == -EEXIST)) | 206 | err = nilfs_mdt_submit_block(inode, blkoff, READA, &bh); |
| 207 | brelse(bh); | 207 | if (likely(!err || err == -EEXIST)) |
| 208 | else if (err != -EBUSY) | 208 | brelse(bh); |
| 209 | break; /* abort readahead if bmap lookup failed */ | 209 | else if (err != -EBUSY) |
| 210 | 210 | break; | |
| 211 | if (!buffer_locked(first_bh)) | 211 | /* abort readahead if bmap lookup failed */ |
| 212 | goto out_no_wait; | 212 | if (!buffer_locked(first_bh)) |
| 213 | goto out_no_wait; | ||
| 214 | } | ||
| 213 | } | 215 | } |
| 214 | 216 | ||
| 215 | wait_on_buffer(first_bh); | 217 | wait_on_buffer(first_bh); |
| @@ -263,7 +265,7 @@ int nilfs_mdt_get_block(struct inode *inode, unsigned long blkoff, int create, | |||
| 263 | 265 | ||
| 264 | /* Should be rewritten with merging nilfs_mdt_read_block() */ | 266 | /* Should be rewritten with merging nilfs_mdt_read_block() */ |
| 265 | retry: | 267 | retry: |
| 266 | ret = nilfs_mdt_read_block(inode, blkoff, out_bh); | 268 | ret = nilfs_mdt_read_block(inode, blkoff, !create, out_bh); |
| 267 | if (!create || ret != -ENOENT) | 269 | if (!create || ret != -ENOENT) |
| 268 | return ret; | 270 | return ret; |
| 269 | 271 | ||
| @@ -371,7 +373,7 @@ int nilfs_mdt_mark_block_dirty(struct inode *inode, unsigned long block) | |||
| 371 | struct buffer_head *bh; | 373 | struct buffer_head *bh; |
| 372 | int err; | 374 | int err; |
| 373 | 375 | ||
| 374 | err = nilfs_mdt_read_block(inode, block, &bh); | 376 | err = nilfs_mdt_read_block(inode, block, 0, &bh); |
| 375 | if (unlikely(err)) | 377 | if (unlikely(err)) |
| 376 | return err; | 378 | return err; |
| 377 | nilfs_mark_buffer_dirty(bh); | 379 | nilfs_mark_buffer_dirty(bh); |
| @@ -445,9 +447,17 @@ static const struct file_operations def_mdt_fops; | |||
| 445 | * longer than those of the super block structs; they may continue for | 447 | * longer than those of the super block structs; they may continue for |
| 446 | * several consecutive mounts/umounts. This would need discussions. | 448 | * several consecutive mounts/umounts. This would need discussions. |
| 447 | */ | 449 | */ |
| 450 | /** | ||
| 451 | * nilfs_mdt_new_common - allocate a pseudo inode for metadata file | ||
| 452 | * @nilfs: nilfs object | ||
| 453 | * @sb: super block instance the metadata file belongs to | ||
| 454 | * @ino: inode number | ||
| 455 | * @gfp_mask: gfp mask for data pages | ||
| 456 | * @objsz: size of the private object attached to inode->i_private | ||
| 457 | */ | ||
| 448 | struct inode * | 458 | struct inode * |
| 449 | nilfs_mdt_new_common(struct the_nilfs *nilfs, struct super_block *sb, | 459 | nilfs_mdt_new_common(struct the_nilfs *nilfs, struct super_block *sb, |
| 450 | ino_t ino, gfp_t gfp_mask) | 460 | ino_t ino, gfp_t gfp_mask, size_t objsz) |
| 451 | { | 461 | { |
| 452 | struct inode *inode = nilfs_alloc_inode_common(nilfs); | 462 | struct inode *inode = nilfs_alloc_inode_common(nilfs); |
| 453 | 463 | ||
| @@ -455,8 +465,9 @@ nilfs_mdt_new_common(struct the_nilfs *nilfs, struct super_block *sb, | |||
| 455 | return NULL; | 465 | return NULL; |
| 456 | else { | 466 | else { |
| 457 | struct address_space * const mapping = &inode->i_data; | 467 | struct address_space * const mapping = &inode->i_data; |
| 458 | struct nilfs_mdt_info *mi = kzalloc(sizeof(*mi), GFP_NOFS); | 468 | struct nilfs_mdt_info *mi; |
| 459 | 469 | ||
| 470 | mi = kzalloc(max(sizeof(*mi), objsz), GFP_NOFS); | ||
| 460 | if (!mi) { | 471 | if (!mi) { |
| 461 | nilfs_destroy_inode(inode); | 472 | nilfs_destroy_inode(inode); |
| 462 | return NULL; | 473 | return NULL; |
| @@ -513,11 +524,11 @@ nilfs_mdt_new_common(struct the_nilfs *nilfs, struct super_block *sb, | |||
| 513 | } | 524 | } |
| 514 | 525 | ||
| 515 | struct inode *nilfs_mdt_new(struct the_nilfs *nilfs, struct super_block *sb, | 526 | struct inode *nilfs_mdt_new(struct the_nilfs *nilfs, struct super_block *sb, |
| 516 | ino_t ino) | 527 | ino_t ino, size_t objsz) |
| 517 | { | 528 | { |
| 518 | struct inode *inode = nilfs_mdt_new_common(nilfs, sb, ino, | 529 | struct inode *inode; |
| 519 | NILFS_MDT_GFP); | ||
| 520 | 530 | ||
| 531 | inode = nilfs_mdt_new_common(nilfs, sb, ino, NILFS_MDT_GFP, objsz); | ||
| 521 | if (!inode) | 532 | if (!inode) |
| 522 | return NULL; | 533 | return NULL; |
| 523 | 534 | ||
| @@ -544,14 +555,15 @@ void nilfs_mdt_set_shadow(struct inode *orig, struct inode *shadow) | |||
| 544 | &NILFS_I(orig)->i_btnode_cache; | 555 | &NILFS_I(orig)->i_btnode_cache; |
| 545 | } | 556 | } |
| 546 | 557 | ||
| 547 | void nilfs_mdt_clear(struct inode *inode) | 558 | static void nilfs_mdt_clear(struct inode *inode) |
| 548 | { | 559 | { |
| 549 | struct nilfs_inode_info *ii = NILFS_I(inode); | 560 | struct nilfs_inode_info *ii = NILFS_I(inode); |
| 550 | 561 | ||
| 551 | invalidate_mapping_pages(inode->i_mapping, 0, -1); | 562 | invalidate_mapping_pages(inode->i_mapping, 0, -1); |
| 552 | truncate_inode_pages(inode->i_mapping, 0); | 563 | truncate_inode_pages(inode->i_mapping, 0); |
| 553 | 564 | ||
| 554 | nilfs_bmap_clear(ii->i_bmap); | 565 | if (test_bit(NILFS_I_BMAP, &ii->i_state)) |
| 566 | nilfs_bmap_clear(ii->i_bmap); | ||
| 555 | nilfs_btnode_cache_clear(&ii->i_btnode_cache); | 567 | nilfs_btnode_cache_clear(&ii->i_btnode_cache); |
| 556 | } | 568 | } |
| 557 | 569 | ||
| @@ -559,6 +571,10 @@ void nilfs_mdt_destroy(struct inode *inode) | |||
| 559 | { | 571 | { |
| 560 | struct nilfs_mdt_info *mdi = NILFS_MDT(inode); | 572 | struct nilfs_mdt_info *mdi = NILFS_MDT(inode); |
| 561 | 573 | ||
| 574 | if (mdi->mi_palloc_cache) | ||
| 575 | nilfs_palloc_destroy_cache(inode); | ||
| 576 | nilfs_mdt_clear(inode); | ||
| 577 | |||
| 562 | kfree(mdi->mi_bgl); /* kfree(NULL) is safe */ | 578 | kfree(mdi->mi_bgl); /* kfree(NULL) is safe */ |
| 563 | kfree(mdi); | 579 | kfree(mdi); |
| 564 | nilfs_destroy_inode(inode); | 580 | nilfs_destroy_inode(inode); |
diff --git a/fs/nilfs2/mdt.h b/fs/nilfs2/mdt.h index 431599733c9b..6c4bbb0470fc 100644 --- a/fs/nilfs2/mdt.h +++ b/fs/nilfs2/mdt.h | |||
| @@ -36,6 +36,7 @@ | |||
| 36 | * @mi_entry_size: size of an entry | 36 | * @mi_entry_size: size of an entry |
| 37 | * @mi_first_entry_offset: offset to the first entry | 37 | * @mi_first_entry_offset: offset to the first entry |
| 38 | * @mi_entries_per_block: number of entries in a block | 38 | * @mi_entries_per_block: number of entries in a block |
| 39 | * @mi_palloc_cache: persistent object allocator cache | ||
| 39 | * @mi_blocks_per_group: number of blocks in a group | 40 | * @mi_blocks_per_group: number of blocks in a group |
| 40 | * @mi_blocks_per_desc_block: number of blocks per descriptor block | 41 | * @mi_blocks_per_desc_block: number of blocks per descriptor block |
| 41 | */ | 42 | */ |
| @@ -46,6 +47,7 @@ struct nilfs_mdt_info { | |||
| 46 | unsigned mi_entry_size; | 47 | unsigned mi_entry_size; |
| 47 | unsigned mi_first_entry_offset; | 48 | unsigned mi_first_entry_offset; |
| 48 | unsigned long mi_entries_per_block; | 49 | unsigned long mi_entries_per_block; |
| 50 | struct nilfs_palloc_cache *mi_palloc_cache; | ||
| 49 | unsigned long mi_blocks_per_group; | 51 | unsigned long mi_blocks_per_group; |
| 50 | unsigned long mi_blocks_per_desc_block; | 52 | unsigned long mi_blocks_per_desc_block; |
| 51 | }; | 53 | }; |
| @@ -74,11 +76,11 @@ int nilfs_mdt_forget_block(struct inode *, unsigned long); | |||
| 74 | int nilfs_mdt_mark_block_dirty(struct inode *, unsigned long); | 76 | int nilfs_mdt_mark_block_dirty(struct inode *, unsigned long); |
| 75 | int nilfs_mdt_fetch_dirty(struct inode *); | 77 | int nilfs_mdt_fetch_dirty(struct inode *); |
| 76 | 78 | ||
| 77 | struct inode *nilfs_mdt_new(struct the_nilfs *, struct super_block *, ino_t); | 79 | struct inode *nilfs_mdt_new(struct the_nilfs *, struct super_block *, ino_t, |
| 80 | size_t); | ||
| 78 | struct inode *nilfs_mdt_new_common(struct the_nilfs *, struct super_block *, | 81 | struct inode *nilfs_mdt_new_common(struct the_nilfs *, struct super_block *, |
| 79 | ino_t, gfp_t); | 82 | ino_t, gfp_t, size_t); |
| 80 | void nilfs_mdt_destroy(struct inode *); | 83 | void nilfs_mdt_destroy(struct inode *); |
| 81 | void nilfs_mdt_clear(struct inode *); | ||
| 82 | void nilfs_mdt_set_entry_size(struct inode *, unsigned, unsigned); | 84 | void nilfs_mdt_set_entry_size(struct inode *, unsigned, unsigned); |
| 83 | void nilfs_mdt_set_shadow(struct inode *, struct inode *); | 85 | void nilfs_mdt_set_shadow(struct inode *, struct inode *); |
| 84 | 86 | ||
| @@ -104,21 +106,4 @@ static inline __u64 nilfs_mdt_cno(struct inode *inode) | |||
| 104 | #define nilfs_mdt_bgl_lock(inode, bg) \ | 106 | #define nilfs_mdt_bgl_lock(inode, bg) \ |
| 105 | (&NILFS_MDT(inode)->mi_bgl->locks[(bg) & (NR_BG_LOCKS-1)].lock) | 107 | (&NILFS_MDT(inode)->mi_bgl->locks[(bg) & (NR_BG_LOCKS-1)].lock) |
| 106 | 108 | ||
| 107 | |||
| 108 | static inline int | ||
| 109 | nilfs_mdt_read_inode_direct(struct inode *inode, struct buffer_head *bh, | ||
| 110 | unsigned n) | ||
| 111 | { | ||
| 112 | return nilfs_read_inode_common( | ||
| 113 | inode, (struct nilfs_inode *)(bh->b_data + n)); | ||
| 114 | } | ||
| 115 | |||
| 116 | static inline void | ||
| 117 | nilfs_mdt_write_inode_direct(struct inode *inode, struct buffer_head *bh, | ||
| 118 | unsigned n) | ||
| 119 | { | ||
| 120 | nilfs_write_inode_common( | ||
| 121 | inode, (struct nilfs_inode *)(bh->b_data + n), 1); | ||
| 122 | } | ||
| 123 | |||
| 124 | #endif /* _NILFS_MDT_H */ | 109 | #endif /* _NILFS_MDT_H */ |
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index ed02e886fa79..07ba838ef089 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c | |||
| @@ -120,7 +120,7 @@ static int nilfs_create(struct inode *dir, struct dentry *dentry, int mode, | |||
| 120 | inode->i_op = &nilfs_file_inode_operations; | 120 | inode->i_op = &nilfs_file_inode_operations; |
| 121 | inode->i_fop = &nilfs_file_operations; | 121 | inode->i_fop = &nilfs_file_operations; |
| 122 | inode->i_mapping->a_ops = &nilfs_aops; | 122 | inode->i_mapping->a_ops = &nilfs_aops; |
| 123 | mark_inode_dirty(inode); | 123 | nilfs_mark_inode_dirty(inode); |
| 124 | err = nilfs_add_nondir(dentry, inode); | 124 | err = nilfs_add_nondir(dentry, inode); |
| 125 | } | 125 | } |
| 126 | if (!err) | 126 | if (!err) |
| @@ -148,7 +148,7 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev) | |||
| 148 | err = PTR_ERR(inode); | 148 | err = PTR_ERR(inode); |
| 149 | if (!IS_ERR(inode)) { | 149 | if (!IS_ERR(inode)) { |
| 150 | init_special_inode(inode, inode->i_mode, rdev); | 150 | init_special_inode(inode, inode->i_mode, rdev); |
| 151 | mark_inode_dirty(inode); | 151 | nilfs_mark_inode_dirty(inode); |
| 152 | err = nilfs_add_nondir(dentry, inode); | 152 | err = nilfs_add_nondir(dentry, inode); |
| 153 | } | 153 | } |
| 154 | if (!err) | 154 | if (!err) |
| @@ -188,7 +188,7 @@ static int nilfs_symlink(struct inode *dir, struct dentry *dentry, | |||
| 188 | goto out_fail; | 188 | goto out_fail; |
| 189 | 189 | ||
| 190 | /* mark_inode_dirty(inode); */ | 190 | /* mark_inode_dirty(inode); */ |
| 191 | /* nilfs_new_inode() and page_symlink() do this */ | 191 | /* page_symlink() do this */ |
| 192 | 192 | ||
| 193 | err = nilfs_add_nondir(dentry, inode); | 193 | err = nilfs_add_nondir(dentry, inode); |
| 194 | out: | 194 | out: |
| @@ -200,7 +200,8 @@ out: | |||
| 200 | return err; | 200 | return err; |
| 201 | 201 | ||
| 202 | out_fail: | 202 | out_fail: |
| 203 | inode_dec_link_count(inode); | 203 | drop_nlink(inode); |
| 204 | nilfs_mark_inode_dirty(inode); | ||
| 204 | iput(inode); | 205 | iput(inode); |
| 205 | goto out; | 206 | goto out; |
| 206 | } | 207 | } |
| @@ -245,7 +246,7 @@ static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 245 | if (err) | 246 | if (err) |
| 246 | return err; | 247 | return err; |
| 247 | 248 | ||
| 248 | inode_inc_link_count(dir); | 249 | inc_nlink(dir); |
| 249 | 250 | ||
| 250 | inode = nilfs_new_inode(dir, S_IFDIR | mode); | 251 | inode = nilfs_new_inode(dir, S_IFDIR | mode); |
| 251 | err = PTR_ERR(inode); | 252 | err = PTR_ERR(inode); |
| @@ -256,7 +257,7 @@ static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 256 | inode->i_fop = &nilfs_dir_operations; | 257 | inode->i_fop = &nilfs_dir_operations; |
| 257 | inode->i_mapping->a_ops = &nilfs_aops; | 258 | inode->i_mapping->a_ops = &nilfs_aops; |
| 258 | 259 | ||
| 259 | inode_inc_link_count(inode); | 260 | inc_nlink(inode); |
| 260 | 261 | ||
| 261 | err = nilfs_make_empty(inode, dir); | 262 | err = nilfs_make_empty(inode, dir); |
| 262 | if (err) | 263 | if (err) |
| @@ -266,6 +267,7 @@ static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 266 | if (err) | 267 | if (err) |
| 267 | goto out_fail; | 268 | goto out_fail; |
| 268 | 269 | ||
| 270 | nilfs_mark_inode_dirty(inode); | ||
| 269 | d_instantiate(dentry, inode); | 271 | d_instantiate(dentry, inode); |
| 270 | out: | 272 | out: |
| 271 | if (!err) | 273 | if (!err) |
| @@ -276,26 +278,23 @@ out: | |||
| 276 | return err; | 278 | return err; |
| 277 | 279 | ||
| 278 | out_fail: | 280 | out_fail: |
| 279 | inode_dec_link_count(inode); | 281 | drop_nlink(inode); |
| 280 | inode_dec_link_count(inode); | 282 | drop_nlink(inode); |
| 283 | nilfs_mark_inode_dirty(inode); | ||
| 281 | iput(inode); | 284 | iput(inode); |
| 282 | out_dir: | 285 | out_dir: |
| 283 | inode_dec_link_count(dir); | 286 | drop_nlink(dir); |
| 287 | nilfs_mark_inode_dirty(dir); | ||
| 284 | goto out; | 288 | goto out; |
| 285 | } | 289 | } |
| 286 | 290 | ||
| 287 | static int nilfs_unlink(struct inode *dir, struct dentry *dentry) | 291 | static int nilfs_do_unlink(struct inode *dir, struct dentry *dentry) |
| 288 | { | 292 | { |
| 289 | struct inode *inode; | 293 | struct inode *inode; |
| 290 | struct nilfs_dir_entry *de; | 294 | struct nilfs_dir_entry *de; |
| 291 | struct page *page; | 295 | struct page *page; |
| 292 | struct nilfs_transaction_info ti; | ||
| 293 | int err; | 296 | int err; |
| 294 | 297 | ||
| 295 | err = nilfs_transaction_begin(dir->i_sb, &ti, 0); | ||
| 296 | if (err) | ||
| 297 | return err; | ||
| 298 | |||
| 299 | err = -ENOENT; | 298 | err = -ENOENT; |
| 300 | de = nilfs_find_entry(dir, dentry, &page); | 299 | de = nilfs_find_entry(dir, dentry, &page); |
| 301 | if (!de) | 300 | if (!de) |
| @@ -317,12 +316,28 @@ static int nilfs_unlink(struct inode *dir, struct dentry *dentry) | |||
| 317 | goto out; | 316 | goto out; |
| 318 | 317 | ||
| 319 | inode->i_ctime = dir->i_ctime; | 318 | inode->i_ctime = dir->i_ctime; |
| 320 | inode_dec_link_count(inode); | 319 | drop_nlink(inode); |
| 321 | err = 0; | 320 | err = 0; |
| 322 | out: | 321 | out: |
| 323 | if (!err) | 322 | return err; |
| 323 | } | ||
| 324 | |||
| 325 | static int nilfs_unlink(struct inode *dir, struct dentry *dentry) | ||
| 326 | { | ||
| 327 | struct nilfs_transaction_info ti; | ||
| 328 | int err; | ||
| 329 | |||
| 330 | err = nilfs_transaction_begin(dir->i_sb, &ti, 0); | ||
| 331 | if (err) | ||
| 332 | return err; | ||
| 333 | |||
| 334 | err = nilfs_do_unlink(dir, dentry); | ||
| 335 | |||
| 336 | if (!err) { | ||
| 337 | nilfs_mark_inode_dirty(dir); | ||
| 338 | nilfs_mark_inode_dirty(dentry->d_inode); | ||
| 324 | err = nilfs_transaction_commit(dir->i_sb); | 339 | err = nilfs_transaction_commit(dir->i_sb); |
| 325 | else | 340 | } else |
| 326 | nilfs_transaction_abort(dir->i_sb); | 341 | nilfs_transaction_abort(dir->i_sb); |
| 327 | 342 | ||
| 328 | return err; | 343 | return err; |
| @@ -340,11 +355,13 @@ static int nilfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
| 340 | 355 | ||
| 341 | err = -ENOTEMPTY; | 356 | err = -ENOTEMPTY; |
| 342 | if (nilfs_empty_dir(inode)) { | 357 | if (nilfs_empty_dir(inode)) { |
| 343 | err = nilfs_unlink(dir, dentry); | 358 | err = nilfs_do_unlink(dir, dentry); |
| 344 | if (!err) { | 359 | if (!err) { |
| 345 | inode->i_size = 0; | 360 | inode->i_size = 0; |
| 346 | inode_dec_link_count(inode); | 361 | drop_nlink(inode); |
| 347 | inode_dec_link_count(dir); | 362 | nilfs_mark_inode_dirty(inode); |
| 363 | drop_nlink(dir); | ||
| 364 | nilfs_mark_inode_dirty(dir); | ||
| 348 | } | 365 | } |
| 349 | } | 366 | } |
| 350 | if (!err) | 367 | if (!err) |
| @@ -395,42 +412,48 @@ static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
| 395 | new_de = nilfs_find_entry(new_dir, new_dentry, &new_page); | 412 | new_de = nilfs_find_entry(new_dir, new_dentry, &new_page); |
| 396 | if (!new_de) | 413 | if (!new_de) |
| 397 | goto out_dir; | 414 | goto out_dir; |
| 398 | inode_inc_link_count(old_inode); | 415 | inc_nlink(old_inode); |
| 399 | nilfs_set_link(new_dir, new_de, new_page, old_inode); | 416 | nilfs_set_link(new_dir, new_de, new_page, old_inode); |
| 417 | nilfs_mark_inode_dirty(new_dir); | ||
| 400 | new_inode->i_ctime = CURRENT_TIME; | 418 | new_inode->i_ctime = CURRENT_TIME; |
| 401 | if (dir_de) | 419 | if (dir_de) |
| 402 | drop_nlink(new_inode); | 420 | drop_nlink(new_inode); |
| 403 | inode_dec_link_count(new_inode); | 421 | drop_nlink(new_inode); |
| 422 | nilfs_mark_inode_dirty(new_inode); | ||
| 404 | } else { | 423 | } else { |
| 405 | if (dir_de) { | 424 | if (dir_de) { |
| 406 | err = -EMLINK; | 425 | err = -EMLINK; |
| 407 | if (new_dir->i_nlink >= NILFS_LINK_MAX) | 426 | if (new_dir->i_nlink >= NILFS_LINK_MAX) |
| 408 | goto out_dir; | 427 | goto out_dir; |
| 409 | } | 428 | } |
| 410 | inode_inc_link_count(old_inode); | 429 | inc_nlink(old_inode); |
| 411 | err = nilfs_add_link(new_dentry, old_inode); | 430 | err = nilfs_add_link(new_dentry, old_inode); |
| 412 | if (err) { | 431 | if (err) { |
| 413 | inode_dec_link_count(old_inode); | 432 | drop_nlink(old_inode); |
| 433 | nilfs_mark_inode_dirty(old_inode); | ||
| 414 | goto out_dir; | 434 | goto out_dir; |
| 415 | } | 435 | } |
| 416 | if (dir_de) | 436 | if (dir_de) { |
| 417 | inode_inc_link_count(new_dir); | 437 | inc_nlink(new_dir); |
| 438 | nilfs_mark_inode_dirty(new_dir); | ||
| 439 | } | ||
| 418 | } | 440 | } |
| 419 | 441 | ||
| 420 | /* | 442 | /* |
| 421 | * Like most other Unix systems, set the ctime for inodes on a | 443 | * Like most other Unix systems, set the ctime for inodes on a |
| 422 | * rename. | 444 | * rename. |
| 423 | * inode_dec_link_count() will mark the inode dirty. | ||
| 424 | */ | 445 | */ |
| 425 | old_inode->i_ctime = CURRENT_TIME; | 446 | old_inode->i_ctime = CURRENT_TIME; |
| 426 | 447 | ||
| 427 | nilfs_delete_entry(old_de, old_page); | 448 | nilfs_delete_entry(old_de, old_page); |
| 428 | inode_dec_link_count(old_inode); | 449 | drop_nlink(old_inode); |
| 429 | 450 | ||
| 430 | if (dir_de) { | 451 | if (dir_de) { |
| 431 | nilfs_set_link(old_inode, dir_de, dir_page, new_dir); | 452 | nilfs_set_link(old_inode, dir_de, dir_page, new_dir); |
| 432 | inode_dec_link_count(old_dir); | 453 | drop_nlink(old_dir); |
| 433 | } | 454 | } |
| 455 | nilfs_mark_inode_dirty(old_dir); | ||
| 456 | nilfs_mark_inode_dirty(old_inode); | ||
| 434 | 457 | ||
| 435 | err = nilfs_transaction_commit(old_dir->i_sb); | 458 | err = nilfs_transaction_commit(old_dir->i_sb); |
| 436 | return err; | 459 | return err; |
diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c index 6dc83591d118..c9c96c7825dc 100644 --- a/fs/nilfs2/recovery.c +++ b/fs/nilfs2/recovery.c | |||
| @@ -770,14 +770,8 @@ int nilfs_recover_logical_segments(struct the_nilfs *nilfs, | |||
| 770 | nilfs_finish_roll_forward(nilfs, sbi, ri); | 770 | nilfs_finish_roll_forward(nilfs, sbi, ri); |
| 771 | } | 771 | } |
| 772 | 772 | ||
| 773 | nilfs_detach_checkpoint(sbi); | ||
| 774 | return 0; | ||
| 775 | |||
| 776 | failed: | 773 | failed: |
| 777 | nilfs_detach_checkpoint(sbi); | 774 | nilfs_detach_checkpoint(sbi); |
| 778 | nilfs_mdt_clear(nilfs->ns_cpfile); | ||
| 779 | nilfs_mdt_clear(nilfs->ns_sufile); | ||
| 780 | nilfs_mdt_clear(nilfs->ns_dat); | ||
| 781 | return err; | 775 | return err; |
| 782 | } | 776 | } |
| 783 | 777 | ||
| @@ -804,6 +798,7 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
| 804 | struct nilfs_segsum_info ssi; | 798 | struct nilfs_segsum_info ssi; |
| 805 | sector_t pseg_start, pseg_end, sr_pseg_start = 0; | 799 | sector_t pseg_start, pseg_end, sr_pseg_start = 0; |
| 806 | sector_t seg_start, seg_end; /* range of full segment (block number) */ | 800 | sector_t seg_start, seg_end; /* range of full segment (block number) */ |
| 801 | sector_t b, end; | ||
| 807 | u64 seg_seq; | 802 | u64 seg_seq; |
| 808 | __u64 segnum, nextnum = 0; | 803 | __u64 segnum, nextnum = 0; |
| 809 | __u64 cno; | 804 | __u64 cno; |
| @@ -819,6 +814,11 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
| 819 | /* Calculate range of segment */ | 814 | /* Calculate range of segment */ |
| 820 | nilfs_get_segment_range(nilfs, segnum, &seg_start, &seg_end); | 815 | nilfs_get_segment_range(nilfs, segnum, &seg_start, &seg_end); |
| 821 | 816 | ||
| 817 | /* Read ahead segment */ | ||
| 818 | b = seg_start; | ||
| 819 | while (b <= seg_end) | ||
| 820 | sb_breadahead(sbi->s_super, b++); | ||
| 821 | |||
| 822 | for (;;) { | 822 | for (;;) { |
| 823 | /* Load segment summary */ | 823 | /* Load segment summary */ |
| 824 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); | 824 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); |
| @@ -841,14 +841,20 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
| 841 | ri->ri_nextnum = nextnum; | 841 | ri->ri_nextnum = nextnum; |
| 842 | empty_seg = 0; | 842 | empty_seg = 0; |
| 843 | 843 | ||
| 844 | if (!NILFS_SEG_HAS_SR(&ssi) && !scan_newer) { | ||
| 845 | /* This will never happen because a superblock | ||
| 846 | (last_segment) always points to a pseg | ||
| 847 | having a super root. */ | ||
| 848 | ret = NILFS_SEG_FAIL_CONSISTENCY; | ||
| 849 | goto failed; | ||
| 850 | } | ||
| 851 | |||
| 852 | if (pseg_start == seg_start) { | ||
| 853 | nilfs_get_segment_range(nilfs, nextnum, &b, &end); | ||
| 854 | while (b <= end) | ||
| 855 | sb_breadahead(sbi->s_super, b++); | ||
| 856 | } | ||
| 844 | if (!NILFS_SEG_HAS_SR(&ssi)) { | 857 | if (!NILFS_SEG_HAS_SR(&ssi)) { |
| 845 | if (!scan_newer) { | ||
| 846 | /* This will never happen because a superblock | ||
| 847 | (last_segment) always points to a pseg | ||
| 848 | having a super root. */ | ||
| 849 | ret = NILFS_SEG_FAIL_CONSISTENCY; | ||
| 850 | goto failed; | ||
| 851 | } | ||
| 852 | if (!ri->ri_lsegs_start && NILFS_SEG_LOGBGN(&ssi)) { | 858 | if (!ri->ri_lsegs_start && NILFS_SEG_LOGBGN(&ssi)) { |
| 853 | ri->ri_lsegs_start = pseg_start; | 859 | ri->ri_lsegs_start = pseg_start; |
| 854 | ri->ri_lsegs_start_seq = seg_seq; | 860 | ri->ri_lsegs_start_seq = seg_seq; |
| @@ -919,7 +925,7 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
| 919 | 925 | ||
| 920 | super_root_found: | 926 | super_root_found: |
| 921 | /* Updating pointers relating to the latest checkpoint */ | 927 | /* Updating pointers relating to the latest checkpoint */ |
| 922 | list_splice(&segments, ri->ri_used_segments.prev); | 928 | list_splice_tail(&segments, &ri->ri_used_segments); |
| 923 | nilfs->ns_last_pseg = sr_pseg_start; | 929 | nilfs->ns_last_pseg = sr_pseg_start; |
| 924 | nilfs->ns_last_seq = nilfs->ns_seg_seq; | 930 | nilfs->ns_last_seq = nilfs->ns_seg_seq; |
| 925 | nilfs->ns_last_cno = ri->ri_cno; | 931 | nilfs->ns_last_cno = ri->ri_cno; |
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index e6d9e37fa241..645c78656aa0 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c | |||
| @@ -24,10 +24,22 @@ | |||
| 24 | #include <linux/buffer_head.h> | 24 | #include <linux/buffer_head.h> |
| 25 | #include <linux/writeback.h> | 25 | #include <linux/writeback.h> |
| 26 | #include <linux/crc32.h> | 26 | #include <linux/crc32.h> |
| 27 | #include <linux/backing-dev.h> | ||
| 27 | #include "page.h" | 28 | #include "page.h" |
| 28 | #include "segbuf.h" | 29 | #include "segbuf.h" |
| 29 | 30 | ||
| 30 | 31 | ||
| 32 | struct nilfs_write_info { | ||
| 33 | struct the_nilfs *nilfs; | ||
| 34 | struct bio *bio; | ||
| 35 | int start, end; /* The region to be submitted */ | ||
| 36 | int rest_blocks; | ||
| 37 | int max_pages; | ||
| 38 | int nr_vecs; | ||
| 39 | sector_t blocknr; | ||
| 40 | }; | ||
| 41 | |||
| 42 | |||
| 31 | static struct kmem_cache *nilfs_segbuf_cachep; | 43 | static struct kmem_cache *nilfs_segbuf_cachep; |
| 32 | 44 | ||
| 33 | static void nilfs_segbuf_init_once(void *obj) | 45 | static void nilfs_segbuf_init_once(void *obj) |
| @@ -63,6 +75,11 @@ struct nilfs_segment_buffer *nilfs_segbuf_new(struct super_block *sb) | |||
| 63 | INIT_LIST_HEAD(&segbuf->sb_list); | 75 | INIT_LIST_HEAD(&segbuf->sb_list); |
| 64 | INIT_LIST_HEAD(&segbuf->sb_segsum_buffers); | 76 | INIT_LIST_HEAD(&segbuf->sb_segsum_buffers); |
| 65 | INIT_LIST_HEAD(&segbuf->sb_payload_buffers); | 77 | INIT_LIST_HEAD(&segbuf->sb_payload_buffers); |
| 78 | |||
| 79 | init_completion(&segbuf->sb_bio_event); | ||
| 80 | atomic_set(&segbuf->sb_err, 0); | ||
| 81 | segbuf->sb_nbio = 0; | ||
| 82 | |||
| 66 | return segbuf; | 83 | return segbuf; |
| 67 | } | 84 | } |
| 68 | 85 | ||
| @@ -83,6 +100,22 @@ void nilfs_segbuf_map(struct nilfs_segment_buffer *segbuf, __u64 segnum, | |||
| 83 | segbuf->sb_fseg_end - segbuf->sb_pseg_start + 1; | 100 | segbuf->sb_fseg_end - segbuf->sb_pseg_start + 1; |
| 84 | } | 101 | } |
| 85 | 102 | ||
| 103 | /** | ||
| 104 | * nilfs_segbuf_map_cont - map a new log behind a given log | ||
| 105 | * @segbuf: new segment buffer | ||
| 106 | * @prev: segment buffer containing a log to be continued | ||
| 107 | */ | ||
| 108 | void nilfs_segbuf_map_cont(struct nilfs_segment_buffer *segbuf, | ||
| 109 | struct nilfs_segment_buffer *prev) | ||
| 110 | { | ||
| 111 | segbuf->sb_segnum = prev->sb_segnum; | ||
| 112 | segbuf->sb_fseg_start = prev->sb_fseg_start; | ||
| 113 | segbuf->sb_fseg_end = prev->sb_fseg_end; | ||
| 114 | segbuf->sb_pseg_start = prev->sb_pseg_start + prev->sb_sum.nblocks; | ||
| 115 | segbuf->sb_rest_blocks = | ||
| 116 | segbuf->sb_fseg_end - segbuf->sb_pseg_start + 1; | ||
| 117 | } | ||
| 118 | |||
| 86 | void nilfs_segbuf_set_next_segnum(struct nilfs_segment_buffer *segbuf, | 119 | void nilfs_segbuf_set_next_segnum(struct nilfs_segment_buffer *segbuf, |
| 87 | __u64 nextnum, struct the_nilfs *nilfs) | 120 | __u64 nextnum, struct the_nilfs *nilfs) |
| 88 | { | 121 | { |
| @@ -132,8 +165,6 @@ int nilfs_segbuf_reset(struct nilfs_segment_buffer *segbuf, unsigned flags, | |||
| 132 | segbuf->sb_sum.sumbytes = sizeof(struct nilfs_segment_summary); | 165 | segbuf->sb_sum.sumbytes = sizeof(struct nilfs_segment_summary); |
| 133 | segbuf->sb_sum.nfinfo = segbuf->sb_sum.nfileblk = 0; | 166 | segbuf->sb_sum.nfinfo = segbuf->sb_sum.nfileblk = 0; |
| 134 | segbuf->sb_sum.ctime = ctime; | 167 | segbuf->sb_sum.ctime = ctime; |
| 135 | |||
| 136 | segbuf->sb_io_error = 0; | ||
| 137 | return 0; | 168 | return 0; |
| 138 | } | 169 | } |
| 139 | 170 | ||
| @@ -219,7 +250,7 @@ void nilfs_segbuf_fill_in_data_crc(struct nilfs_segment_buffer *segbuf, | |||
| 219 | raw_sum->ss_datasum = cpu_to_le32(crc); | 250 | raw_sum->ss_datasum = cpu_to_le32(crc); |
| 220 | } | 251 | } |
| 221 | 252 | ||
| 222 | void nilfs_release_buffers(struct list_head *list) | 253 | static void nilfs_release_buffers(struct list_head *list) |
| 223 | { | 254 | { |
| 224 | struct buffer_head *bh, *n; | 255 | struct buffer_head *bh, *n; |
| 225 | 256 | ||
| @@ -241,13 +272,56 @@ void nilfs_release_buffers(struct list_head *list) | |||
| 241 | } | 272 | } |
| 242 | } | 273 | } |
| 243 | 274 | ||
| 275 | static void nilfs_segbuf_clear(struct nilfs_segment_buffer *segbuf) | ||
| 276 | { | ||
| 277 | nilfs_release_buffers(&segbuf->sb_segsum_buffers); | ||
| 278 | nilfs_release_buffers(&segbuf->sb_payload_buffers); | ||
| 279 | } | ||
| 280 | |||
| 281 | /* | ||
| 282 | * Iterators for segment buffers | ||
| 283 | */ | ||
| 284 | void nilfs_clear_logs(struct list_head *logs) | ||
| 285 | { | ||
| 286 | struct nilfs_segment_buffer *segbuf; | ||
| 287 | |||
| 288 | list_for_each_entry(segbuf, logs, sb_list) | ||
| 289 | nilfs_segbuf_clear(segbuf); | ||
| 290 | } | ||
| 291 | |||
| 292 | void nilfs_truncate_logs(struct list_head *logs, | ||
| 293 | struct nilfs_segment_buffer *last) | ||
| 294 | { | ||
| 295 | struct nilfs_segment_buffer *n, *segbuf; | ||
| 296 | |||
| 297 | segbuf = list_prepare_entry(last, logs, sb_list); | ||
| 298 | list_for_each_entry_safe_continue(segbuf, n, logs, sb_list) { | ||
| 299 | list_del_init(&segbuf->sb_list); | ||
| 300 | nilfs_segbuf_clear(segbuf); | ||
| 301 | nilfs_segbuf_free(segbuf); | ||
| 302 | } | ||
| 303 | } | ||
| 304 | |||
| 305 | int nilfs_wait_on_logs(struct list_head *logs) | ||
| 306 | { | ||
| 307 | struct nilfs_segment_buffer *segbuf; | ||
| 308 | int err; | ||
| 309 | |||
| 310 | list_for_each_entry(segbuf, logs, sb_list) { | ||
| 311 | err = nilfs_segbuf_wait(segbuf); | ||
| 312 | if (err) | ||
| 313 | return err; | ||
| 314 | } | ||
| 315 | return 0; | ||
| 316 | } | ||
| 317 | |||
| 244 | /* | 318 | /* |
| 245 | * BIO operations | 319 | * BIO operations |
| 246 | */ | 320 | */ |
| 247 | static void nilfs_end_bio_write(struct bio *bio, int err) | 321 | static void nilfs_end_bio_write(struct bio *bio, int err) |
| 248 | { | 322 | { |
| 249 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 323 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
| 250 | struct nilfs_write_info *wi = bio->bi_private; | 324 | struct nilfs_segment_buffer *segbuf = bio->bi_private; |
| 251 | 325 | ||
| 252 | if (err == -EOPNOTSUPP) { | 326 | if (err == -EOPNOTSUPP) { |
| 253 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); | 327 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); |
| @@ -256,21 +330,22 @@ static void nilfs_end_bio_write(struct bio *bio, int err) | |||
| 256 | } | 330 | } |
| 257 | 331 | ||
| 258 | if (!uptodate) | 332 | if (!uptodate) |
| 259 | atomic_inc(&wi->err); | 333 | atomic_inc(&segbuf->sb_err); |
| 260 | 334 | ||
| 261 | bio_put(bio); | 335 | bio_put(bio); |
| 262 | complete(&wi->bio_event); | 336 | complete(&segbuf->sb_bio_event); |
| 263 | } | 337 | } |
| 264 | 338 | ||
| 265 | static int nilfs_submit_seg_bio(struct nilfs_write_info *wi, int mode) | 339 | static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf, |
| 340 | struct nilfs_write_info *wi, int mode) | ||
| 266 | { | 341 | { |
| 267 | struct bio *bio = wi->bio; | 342 | struct bio *bio = wi->bio; |
| 268 | int err; | 343 | int err; |
| 269 | 344 | ||
| 270 | if (wi->nbio > 0 && bdi_write_congested(wi->bdi)) { | 345 | if (segbuf->sb_nbio > 0 && bdi_write_congested(wi->nilfs->ns_bdi)) { |
| 271 | wait_for_completion(&wi->bio_event); | 346 | wait_for_completion(&segbuf->sb_bio_event); |
| 272 | wi->nbio--; | 347 | segbuf->sb_nbio--; |
| 273 | if (unlikely(atomic_read(&wi->err))) { | 348 | if (unlikely(atomic_read(&segbuf->sb_err))) { |
| 274 | bio_put(bio); | 349 | bio_put(bio); |
| 275 | err = -EIO; | 350 | err = -EIO; |
| 276 | goto failed; | 351 | goto failed; |
| @@ -278,7 +353,7 @@ static int nilfs_submit_seg_bio(struct nilfs_write_info *wi, int mode) | |||
| 278 | } | 353 | } |
| 279 | 354 | ||
| 280 | bio->bi_end_io = nilfs_end_bio_write; | 355 | bio->bi_end_io = nilfs_end_bio_write; |
| 281 | bio->bi_private = wi; | 356 | bio->bi_private = segbuf; |
| 282 | bio_get(bio); | 357 | bio_get(bio); |
| 283 | submit_bio(mode, bio); | 358 | submit_bio(mode, bio); |
| 284 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { | 359 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { |
| @@ -286,7 +361,7 @@ static int nilfs_submit_seg_bio(struct nilfs_write_info *wi, int mode) | |||
| 286 | err = -EOPNOTSUPP; | 361 | err = -EOPNOTSUPP; |
| 287 | goto failed; | 362 | goto failed; |
| 288 | } | 363 | } |
| 289 | wi->nbio++; | 364 | segbuf->sb_nbio++; |
| 290 | bio_put(bio); | 365 | bio_put(bio); |
| 291 | 366 | ||
| 292 | wi->bio = NULL; | 367 | wi->bio = NULL; |
| @@ -301,17 +376,15 @@ static int nilfs_submit_seg_bio(struct nilfs_write_info *wi, int mode) | |||
| 301 | } | 376 | } |
| 302 | 377 | ||
| 303 | /** | 378 | /** |
| 304 | * nilfs_alloc_seg_bio - allocate a bio for writing segment. | 379 | * nilfs_alloc_seg_bio - allocate a new bio for writing log |
| 305 | * @sb: super block | 380 | * @nilfs: nilfs object |
| 306 | * @start: beginning disk block number of this BIO. | 381 | * @start: start block number of the bio |
| 307 | * @nr_vecs: request size of page vector. | 382 | * @nr_vecs: request size of page vector. |
| 308 | * | 383 | * |
| 309 | * alloc_seg_bio() allocates a new BIO structure and initialize it. | ||
| 310 | * | ||
| 311 | * Return Value: On success, pointer to the struct bio is returned. | 384 | * Return Value: On success, pointer to the struct bio is returned. |
| 312 | * On error, NULL is returned. | 385 | * On error, NULL is returned. |
| 313 | */ | 386 | */ |
| 314 | static struct bio *nilfs_alloc_seg_bio(struct super_block *sb, sector_t start, | 387 | static struct bio *nilfs_alloc_seg_bio(struct the_nilfs *nilfs, sector_t start, |
| 315 | int nr_vecs) | 388 | int nr_vecs) |
| 316 | { | 389 | { |
| 317 | struct bio *bio; | 390 | struct bio *bio; |
| @@ -322,36 +395,33 @@ static struct bio *nilfs_alloc_seg_bio(struct super_block *sb, sector_t start, | |||
| 322 | bio = bio_alloc(GFP_NOIO, nr_vecs); | 395 | bio = bio_alloc(GFP_NOIO, nr_vecs); |
| 323 | } | 396 | } |
| 324 | if (likely(bio)) { | 397 | if (likely(bio)) { |
| 325 | bio->bi_bdev = sb->s_bdev; | 398 | bio->bi_bdev = nilfs->ns_bdev; |
| 326 | bio->bi_sector = (sector_t)start << (sb->s_blocksize_bits - 9); | 399 | bio->bi_sector = start << (nilfs->ns_blocksize_bits - 9); |
| 327 | } | 400 | } |
| 328 | return bio; | 401 | return bio; |
| 329 | } | 402 | } |
| 330 | 403 | ||
| 331 | void nilfs_segbuf_prepare_write(struct nilfs_segment_buffer *segbuf, | 404 | static void nilfs_segbuf_prepare_write(struct nilfs_segment_buffer *segbuf, |
| 332 | struct nilfs_write_info *wi) | 405 | struct nilfs_write_info *wi) |
| 333 | { | 406 | { |
| 334 | wi->bio = NULL; | 407 | wi->bio = NULL; |
| 335 | wi->rest_blocks = segbuf->sb_sum.nblocks; | 408 | wi->rest_blocks = segbuf->sb_sum.nblocks; |
| 336 | wi->max_pages = bio_get_nr_vecs(wi->sb->s_bdev); | 409 | wi->max_pages = bio_get_nr_vecs(wi->nilfs->ns_bdev); |
| 337 | wi->nr_vecs = min(wi->max_pages, wi->rest_blocks); | 410 | wi->nr_vecs = min(wi->max_pages, wi->rest_blocks); |
| 338 | wi->start = wi->end = 0; | 411 | wi->start = wi->end = 0; |
| 339 | wi->nbio = 0; | ||
| 340 | wi->blocknr = segbuf->sb_pseg_start; | 412 | wi->blocknr = segbuf->sb_pseg_start; |
| 341 | |||
| 342 | atomic_set(&wi->err, 0); | ||
| 343 | init_completion(&wi->bio_event); | ||
| 344 | } | 413 | } |
| 345 | 414 | ||
| 346 | static int nilfs_submit_bh(struct nilfs_write_info *wi, struct buffer_head *bh, | 415 | static int nilfs_segbuf_submit_bh(struct nilfs_segment_buffer *segbuf, |
| 347 | int mode) | 416 | struct nilfs_write_info *wi, |
| 417 | struct buffer_head *bh, int mode) | ||
| 348 | { | 418 | { |
| 349 | int len, err; | 419 | int len, err; |
| 350 | 420 | ||
| 351 | BUG_ON(wi->nr_vecs <= 0); | 421 | BUG_ON(wi->nr_vecs <= 0); |
| 352 | repeat: | 422 | repeat: |
| 353 | if (!wi->bio) { | 423 | if (!wi->bio) { |
| 354 | wi->bio = nilfs_alloc_seg_bio(wi->sb, wi->blocknr + wi->end, | 424 | wi->bio = nilfs_alloc_seg_bio(wi->nilfs, wi->blocknr + wi->end, |
| 355 | wi->nr_vecs); | 425 | wi->nr_vecs); |
| 356 | if (unlikely(!wi->bio)) | 426 | if (unlikely(!wi->bio)) |
| 357 | return -ENOMEM; | 427 | return -ENOMEM; |
| @@ -363,76 +433,83 @@ static int nilfs_submit_bh(struct nilfs_write_info *wi, struct buffer_head *bh, | |||
| 363 | return 0; | 433 | return 0; |
| 364 | } | 434 | } |
| 365 | /* bio is FULL */ | 435 | /* bio is FULL */ |
| 366 | err = nilfs_submit_seg_bio(wi, mode); | 436 | err = nilfs_segbuf_submit_bio(segbuf, wi, mode); |
| 367 | /* never submit current bh */ | 437 | /* never submit current bh */ |
| 368 | if (likely(!err)) | 438 | if (likely(!err)) |
| 369 | goto repeat; | 439 | goto repeat; |
| 370 | return err; | 440 | return err; |
| 371 | } | 441 | } |
| 372 | 442 | ||
| 443 | /** | ||
| 444 | * nilfs_segbuf_write - submit write requests of a log | ||
| 445 | * @segbuf: buffer storing a log to be written | ||
| 446 | * @nilfs: nilfs object | ||
| 447 | * | ||
| 448 | * Return Value: On Success, 0 is returned. On Error, one of the following | ||
| 449 | * negative error code is returned. | ||
| 450 | * | ||
| 451 | * %-EIO - I/O error | ||
| 452 | * | ||
| 453 | * %-ENOMEM - Insufficient memory available. | ||
| 454 | */ | ||
| 373 | int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, | 455 | int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, |
| 374 | struct nilfs_write_info *wi) | 456 | struct the_nilfs *nilfs) |
| 375 | { | 457 | { |
| 458 | struct nilfs_write_info wi; | ||
| 376 | struct buffer_head *bh; | 459 | struct buffer_head *bh; |
| 377 | int res, rw = WRITE; | 460 | int res = 0, rw = WRITE; |
| 461 | |||
| 462 | wi.nilfs = nilfs; | ||
| 463 | nilfs_segbuf_prepare_write(segbuf, &wi); | ||
| 378 | 464 | ||
| 379 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, b_assoc_buffers) { | 465 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, b_assoc_buffers) { |
| 380 | res = nilfs_submit_bh(wi, bh, rw); | 466 | res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, rw); |
| 381 | if (unlikely(res)) | 467 | if (unlikely(res)) |
| 382 | goto failed_bio; | 468 | goto failed_bio; |
| 383 | } | 469 | } |
| 384 | 470 | ||
| 385 | list_for_each_entry(bh, &segbuf->sb_payload_buffers, b_assoc_buffers) { | 471 | list_for_each_entry(bh, &segbuf->sb_payload_buffers, b_assoc_buffers) { |
| 386 | res = nilfs_submit_bh(wi, bh, rw); | 472 | res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, rw); |
| 387 | if (unlikely(res)) | 473 | if (unlikely(res)) |
| 388 | goto failed_bio; | 474 | goto failed_bio; |
| 389 | } | 475 | } |
| 390 | 476 | ||
| 391 | if (wi->bio) { | 477 | if (wi.bio) { |
| 392 | /* | 478 | /* |
| 393 | * Last BIO is always sent through the following | 479 | * Last BIO is always sent through the following |
| 394 | * submission. | 480 | * submission. |
| 395 | */ | 481 | */ |
| 396 | rw |= (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_UNPLUG); | 482 | rw |= (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_UNPLUG); |
| 397 | res = nilfs_submit_seg_bio(wi, rw); | 483 | res = nilfs_segbuf_submit_bio(segbuf, &wi, rw); |
| 398 | if (unlikely(res)) | ||
| 399 | goto failed_bio; | ||
| 400 | } | 484 | } |
| 401 | 485 | ||
| 402 | res = 0; | ||
| 403 | out: | ||
| 404 | return res; | ||
| 405 | |||
| 406 | failed_bio: | 486 | failed_bio: |
| 407 | atomic_inc(&wi->err); | 487 | return res; |
| 408 | goto out; | ||
| 409 | } | 488 | } |
| 410 | 489 | ||
| 411 | /** | 490 | /** |
| 412 | * nilfs_segbuf_wait - wait for completion of requested BIOs | 491 | * nilfs_segbuf_wait - wait for completion of requested BIOs |
| 413 | * @wi: nilfs_write_info | 492 | * @segbuf: segment buffer |
| 414 | * | 493 | * |
| 415 | * Return Value: On Success, 0 is returned. On Error, one of the following | 494 | * Return Value: On Success, 0 is returned. On Error, one of the following |
| 416 | * negative error code is returned. | 495 | * negative error code is returned. |
| 417 | * | 496 | * |
| 418 | * %-EIO - I/O error | 497 | * %-EIO - I/O error |
| 419 | */ | 498 | */ |
| 420 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf, | 499 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf) |
| 421 | struct nilfs_write_info *wi) | ||
| 422 | { | 500 | { |
| 423 | int err = 0; | 501 | int err = 0; |
| 424 | 502 | ||
| 425 | if (!wi->nbio) | 503 | if (!segbuf->sb_nbio) |
| 426 | return 0; | 504 | return 0; |
| 427 | 505 | ||
| 428 | do { | 506 | do { |
| 429 | wait_for_completion(&wi->bio_event); | 507 | wait_for_completion(&segbuf->sb_bio_event); |
| 430 | } while (--wi->nbio > 0); | 508 | } while (--segbuf->sb_nbio > 0); |
| 431 | 509 | ||
| 432 | if (unlikely(atomic_read(&wi->err) > 0)) { | 510 | if (unlikely(atomic_read(&segbuf->sb_err) > 0)) { |
| 433 | printk(KERN_ERR "NILFS: IO error writing segment\n"); | 511 | printk(KERN_ERR "NILFS: IO error writing segment\n"); |
| 434 | err = -EIO; | 512 | err = -EIO; |
| 435 | segbuf->sb_io_error = 1; | ||
| 436 | } | 513 | } |
| 437 | return err; | 514 | return err; |
| 438 | } | 515 | } |
diff --git a/fs/nilfs2/segbuf.h b/fs/nilfs2/segbuf.h index 0c3076f4e592..6af1630fb401 100644 --- a/fs/nilfs2/segbuf.h +++ b/fs/nilfs2/segbuf.h | |||
| @@ -27,7 +27,6 @@ | |||
| 27 | #include <linux/buffer_head.h> | 27 | #include <linux/buffer_head.h> |
| 28 | #include <linux/bio.h> | 28 | #include <linux/bio.h> |
| 29 | #include <linux/completion.h> | 29 | #include <linux/completion.h> |
| 30 | #include <linux/backing-dev.h> | ||
| 31 | 30 | ||
| 32 | /** | 31 | /** |
| 33 | * struct nilfs_segsum_info - On-memory segment summary | 32 | * struct nilfs_segsum_info - On-memory segment summary |
| @@ -77,7 +76,9 @@ struct nilfs_segsum_info { | |||
| 77 | * @sb_rest_blocks: Number of residual blocks in the current segment | 76 | * @sb_rest_blocks: Number of residual blocks in the current segment |
| 78 | * @sb_segsum_buffers: List of buffers for segment summaries | 77 | * @sb_segsum_buffers: List of buffers for segment summaries |
| 79 | * @sb_payload_buffers: List of buffers for segment payload | 78 | * @sb_payload_buffers: List of buffers for segment payload |
| 80 | * @sb_io_error: I/O error status | 79 | * @sb_nbio: Number of flying bio requests |
| 80 | * @sb_err: I/O error status | ||
| 81 | * @sb_bio_event: Completion event of log writing | ||
| 81 | */ | 82 | */ |
| 82 | struct nilfs_segment_buffer { | 83 | struct nilfs_segment_buffer { |
| 83 | struct super_block *sb_super; | 84 | struct super_block *sb_super; |
| @@ -96,7 +97,9 @@ struct nilfs_segment_buffer { | |||
| 96 | struct list_head sb_payload_buffers; /* including super root */ | 97 | struct list_head sb_payload_buffers; /* including super root */ |
| 97 | 98 | ||
| 98 | /* io status */ | 99 | /* io status */ |
| 99 | int sb_io_error; | 100 | int sb_nbio; |
| 101 | atomic_t sb_err; | ||
| 102 | struct completion sb_bio_event; | ||
| 100 | }; | 103 | }; |
| 101 | 104 | ||
| 102 | #define NILFS_LIST_SEGBUF(head) \ | 105 | #define NILFS_LIST_SEGBUF(head) \ |
| @@ -125,6 +128,8 @@ struct nilfs_segment_buffer *nilfs_segbuf_new(struct super_block *); | |||
| 125 | void nilfs_segbuf_free(struct nilfs_segment_buffer *); | 128 | void nilfs_segbuf_free(struct nilfs_segment_buffer *); |
| 126 | void nilfs_segbuf_map(struct nilfs_segment_buffer *, __u64, unsigned long, | 129 | void nilfs_segbuf_map(struct nilfs_segment_buffer *, __u64, unsigned long, |
| 127 | struct the_nilfs *); | 130 | struct the_nilfs *); |
| 131 | void nilfs_segbuf_map_cont(struct nilfs_segment_buffer *segbuf, | ||
| 132 | struct nilfs_segment_buffer *prev); | ||
| 128 | void nilfs_segbuf_set_next_segnum(struct nilfs_segment_buffer *, __u64, | 133 | void nilfs_segbuf_set_next_segnum(struct nilfs_segment_buffer *, __u64, |
| 129 | struct the_nilfs *); | 134 | struct the_nilfs *); |
| 130 | int nilfs_segbuf_reset(struct nilfs_segment_buffer *, unsigned, time_t); | 135 | int nilfs_segbuf_reset(struct nilfs_segment_buffer *, unsigned, time_t); |
| @@ -161,41 +166,18 @@ nilfs_segbuf_add_file_buffer(struct nilfs_segment_buffer *segbuf, | |||
| 161 | segbuf->sb_sum.nfileblk++; | 166 | segbuf->sb_sum.nfileblk++; |
| 162 | } | 167 | } |
| 163 | 168 | ||
| 164 | void nilfs_release_buffers(struct list_head *); | 169 | int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, |
| 170 | struct the_nilfs *nilfs); | ||
| 171 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf); | ||
| 165 | 172 | ||
| 166 | static inline void nilfs_segbuf_clear(struct nilfs_segment_buffer *segbuf) | 173 | void nilfs_clear_logs(struct list_head *logs); |
| 174 | void nilfs_truncate_logs(struct list_head *logs, | ||
| 175 | struct nilfs_segment_buffer *last); | ||
| 176 | int nilfs_wait_on_logs(struct list_head *logs); | ||
| 177 | |||
| 178 | static inline void nilfs_destroy_logs(struct list_head *logs) | ||
| 167 | { | 179 | { |
| 168 | nilfs_release_buffers(&segbuf->sb_segsum_buffers); | 180 | nilfs_truncate_logs(logs, NULL); |
| 169 | nilfs_release_buffers(&segbuf->sb_payload_buffers); | ||
| 170 | } | 181 | } |
| 171 | 182 | ||
| 172 | struct nilfs_write_info { | ||
| 173 | struct bio *bio; | ||
| 174 | int start, end; /* The region to be submitted */ | ||
| 175 | int rest_blocks; | ||
| 176 | int max_pages; | ||
| 177 | int nr_vecs; | ||
| 178 | sector_t blocknr; | ||
| 179 | |||
| 180 | int nbio; | ||
| 181 | atomic_t err; | ||
| 182 | struct completion bio_event; | ||
| 183 | /* completion event of segment write */ | ||
| 184 | |||
| 185 | /* | ||
| 186 | * The following fields must be set explicitly | ||
| 187 | */ | ||
| 188 | struct super_block *sb; | ||
| 189 | struct backing_dev_info *bdi; /* backing dev info */ | ||
| 190 | struct buffer_head *bh_sr; | ||
| 191 | }; | ||
| 192 | |||
| 193 | |||
| 194 | void nilfs_segbuf_prepare_write(struct nilfs_segment_buffer *, | ||
| 195 | struct nilfs_write_info *); | ||
| 196 | int nilfs_segbuf_write(struct nilfs_segment_buffer *, | ||
| 197 | struct nilfs_write_info *); | ||
| 198 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *, | ||
| 199 | struct nilfs_write_info *); | ||
| 200 | |||
| 201 | #endif /* _NILFS_SEGBUF_H */ | 183 | #endif /* _NILFS_SEGBUF_H */ |
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 6eff66a070d5..17584c524486 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c | |||
| @@ -974,12 +974,12 @@ static void nilfs_segctor_fill_in_super_root(struct nilfs_sc_info *sci, | |||
| 974 | nilfs->ns_nongc_ctime : sci->sc_seg_ctime); | 974 | nilfs->ns_nongc_ctime : sci->sc_seg_ctime); |
| 975 | raw_sr->sr_flags = 0; | 975 | raw_sr->sr_flags = 0; |
| 976 | 976 | ||
| 977 | nilfs_mdt_write_inode_direct( | 977 | nilfs_write_inode_common(nilfs_dat_inode(nilfs), (void *)raw_sr + |
| 978 | nilfs_dat_inode(nilfs), bh_sr, NILFS_SR_DAT_OFFSET(isz)); | 978 | NILFS_SR_DAT_OFFSET(isz), 1); |
| 979 | nilfs_mdt_write_inode_direct( | 979 | nilfs_write_inode_common(nilfs->ns_cpfile, (void *)raw_sr + |
| 980 | nilfs->ns_cpfile, bh_sr, NILFS_SR_CPFILE_OFFSET(isz)); | 980 | NILFS_SR_CPFILE_OFFSET(isz), 1); |
| 981 | nilfs_mdt_write_inode_direct( | 981 | nilfs_write_inode_common(nilfs->ns_sufile, (void *)raw_sr + |
| 982 | nilfs->ns_sufile, bh_sr, NILFS_SR_SUFILE_OFFSET(isz)); | 982 | NILFS_SR_SUFILE_OFFSET(isz), 1); |
| 983 | } | 983 | } |
| 984 | 984 | ||
| 985 | static void nilfs_redirty_inodes(struct list_head *head) | 985 | static void nilfs_redirty_inodes(struct list_head *head) |
| @@ -1273,73 +1273,75 @@ static int nilfs_segctor_collect_blocks(struct nilfs_sc_info *sci, int mode) | |||
| 1273 | return err; | 1273 | return err; |
| 1274 | } | 1274 | } |
| 1275 | 1275 | ||
| 1276 | static int nilfs_touch_segusage(struct inode *sufile, __u64 segnum) | 1276 | /** |
| 1277 | { | 1277 | * nilfs_segctor_begin_construction - setup segment buffer to make a new log |
| 1278 | struct buffer_head *bh_su; | 1278 | * @sci: nilfs_sc_info |
| 1279 | struct nilfs_segment_usage *raw_su; | 1279 | * @nilfs: nilfs object |
| 1280 | int err; | 1280 | */ |
| 1281 | |||
| 1282 | err = nilfs_sufile_get_segment_usage(sufile, segnum, &raw_su, &bh_su); | ||
| 1283 | if (unlikely(err)) | ||
| 1284 | return err; | ||
| 1285 | nilfs_mdt_mark_buffer_dirty(bh_su); | ||
| 1286 | nilfs_mdt_mark_dirty(sufile); | ||
| 1287 | nilfs_sufile_put_segment_usage(sufile, segnum, bh_su); | ||
| 1288 | return 0; | ||
| 1289 | } | ||
| 1290 | |||
| 1291 | static int nilfs_segctor_begin_construction(struct nilfs_sc_info *sci, | 1281 | static int nilfs_segctor_begin_construction(struct nilfs_sc_info *sci, |
| 1292 | struct the_nilfs *nilfs) | 1282 | struct the_nilfs *nilfs) |
| 1293 | { | 1283 | { |
| 1294 | struct nilfs_segment_buffer *segbuf, *n; | 1284 | struct nilfs_segment_buffer *segbuf, *prev; |
| 1295 | __u64 nextnum; | 1285 | __u64 nextnum; |
| 1296 | int err; | 1286 | int err, alloc = 0; |
| 1297 | 1287 | ||
| 1298 | if (list_empty(&sci->sc_segbufs)) { | 1288 | segbuf = nilfs_segbuf_new(sci->sc_super); |
| 1299 | segbuf = nilfs_segbuf_new(sci->sc_super); | 1289 | if (unlikely(!segbuf)) |
| 1300 | if (unlikely(!segbuf)) | 1290 | return -ENOMEM; |
| 1301 | return -ENOMEM; | 1291 | |
| 1302 | list_add(&segbuf->sb_list, &sci->sc_segbufs); | 1292 | if (list_empty(&sci->sc_write_logs)) { |
| 1303 | } else | 1293 | nilfs_segbuf_map(segbuf, nilfs->ns_segnum, |
| 1304 | segbuf = NILFS_FIRST_SEGBUF(&sci->sc_segbufs); | 1294 | nilfs->ns_pseg_offset, nilfs); |
| 1295 | if (segbuf->sb_rest_blocks < NILFS_PSEG_MIN_BLOCKS) { | ||
| 1296 | nilfs_shift_to_next_segment(nilfs); | ||
| 1297 | nilfs_segbuf_map(segbuf, nilfs->ns_segnum, 0, nilfs); | ||
| 1298 | } | ||
| 1305 | 1299 | ||
| 1306 | nilfs_segbuf_map(segbuf, nilfs->ns_segnum, nilfs->ns_pseg_offset, | 1300 | segbuf->sb_sum.seg_seq = nilfs->ns_seg_seq; |
| 1307 | nilfs); | 1301 | nextnum = nilfs->ns_nextnum; |
| 1308 | 1302 | ||
| 1309 | if (segbuf->sb_rest_blocks < NILFS_PSEG_MIN_BLOCKS) { | 1303 | if (nilfs->ns_segnum == nilfs->ns_nextnum) |
| 1310 | nilfs_shift_to_next_segment(nilfs); | 1304 | /* Start from the head of a new full segment */ |
| 1311 | nilfs_segbuf_map(segbuf, nilfs->ns_segnum, 0, nilfs); | 1305 | alloc++; |
| 1306 | } else { | ||
| 1307 | /* Continue logs */ | ||
| 1308 | prev = NILFS_LAST_SEGBUF(&sci->sc_write_logs); | ||
| 1309 | nilfs_segbuf_map_cont(segbuf, prev); | ||
| 1310 | segbuf->sb_sum.seg_seq = prev->sb_sum.seg_seq; | ||
| 1311 | nextnum = prev->sb_nextnum; | ||
| 1312 | |||
| 1313 | if (segbuf->sb_rest_blocks < NILFS_PSEG_MIN_BLOCKS) { | ||
| 1314 | nilfs_segbuf_map(segbuf, prev->sb_nextnum, 0, nilfs); | ||
| 1315 | segbuf->sb_sum.seg_seq++; | ||
| 1316 | alloc++; | ||
| 1317 | } | ||
| 1312 | } | 1318 | } |
| 1313 | sci->sc_segbuf_nblocks = segbuf->sb_rest_blocks; | ||
| 1314 | 1319 | ||
| 1315 | err = nilfs_touch_segusage(nilfs->ns_sufile, segbuf->sb_segnum); | 1320 | err = nilfs_sufile_mark_dirty(nilfs->ns_sufile, segbuf->sb_segnum); |
| 1316 | if (unlikely(err)) | 1321 | if (err) |
| 1317 | return err; | 1322 | goto failed; |
| 1318 | 1323 | ||
| 1319 | if (nilfs->ns_segnum == nilfs->ns_nextnum) { | 1324 | if (alloc) { |
| 1320 | /* Start from the head of a new full segment */ | ||
| 1321 | err = nilfs_sufile_alloc(nilfs->ns_sufile, &nextnum); | 1325 | err = nilfs_sufile_alloc(nilfs->ns_sufile, &nextnum); |
| 1322 | if (unlikely(err)) | 1326 | if (err) |
| 1323 | return err; | 1327 | goto failed; |
| 1324 | } else | 1328 | } |
| 1325 | nextnum = nilfs->ns_nextnum; | ||
| 1326 | |||
| 1327 | segbuf->sb_sum.seg_seq = nilfs->ns_seg_seq; | ||
| 1328 | nilfs_segbuf_set_next_segnum(segbuf, nextnum, nilfs); | 1329 | nilfs_segbuf_set_next_segnum(segbuf, nextnum, nilfs); |
| 1329 | 1330 | ||
| 1330 | /* truncating segment buffers */ | 1331 | BUG_ON(!list_empty(&sci->sc_segbufs)); |
| 1331 | list_for_each_entry_safe_continue(segbuf, n, &sci->sc_segbufs, | 1332 | list_add_tail(&segbuf->sb_list, &sci->sc_segbufs); |
| 1332 | sb_list) { | 1333 | sci->sc_segbuf_nblocks = segbuf->sb_rest_blocks; |
| 1333 | list_del_init(&segbuf->sb_list); | ||
| 1334 | nilfs_segbuf_free(segbuf); | ||
| 1335 | } | ||
| 1336 | return 0; | 1334 | return 0; |
| 1335 | |||
| 1336 | failed: | ||
| 1337 | nilfs_segbuf_free(segbuf); | ||
| 1338 | return err; | ||
| 1337 | } | 1339 | } |
| 1338 | 1340 | ||
| 1339 | static int nilfs_segctor_extend_segments(struct nilfs_sc_info *sci, | 1341 | static int nilfs_segctor_extend_segments(struct nilfs_sc_info *sci, |
| 1340 | struct the_nilfs *nilfs, int nadd) | 1342 | struct the_nilfs *nilfs, int nadd) |
| 1341 | { | 1343 | { |
| 1342 | struct nilfs_segment_buffer *segbuf, *prev, *n; | 1344 | struct nilfs_segment_buffer *segbuf, *prev; |
| 1343 | struct inode *sufile = nilfs->ns_sufile; | 1345 | struct inode *sufile = nilfs->ns_sufile; |
| 1344 | __u64 nextnextnum; | 1346 | __u64 nextnextnum; |
| 1345 | LIST_HEAD(list); | 1347 | LIST_HEAD(list); |
| @@ -1352,7 +1354,7 @@ static int nilfs_segctor_extend_segments(struct nilfs_sc_info *sci, | |||
| 1352 | * not be dirty. The following call ensures that the buffer is dirty | 1354 | * not be dirty. The following call ensures that the buffer is dirty |
| 1353 | * and will pin the buffer on memory until the sufile is written. | 1355 | * and will pin the buffer on memory until the sufile is written. |
| 1354 | */ | 1356 | */ |
| 1355 | err = nilfs_touch_segusage(sufile, prev->sb_nextnum); | 1357 | err = nilfs_sufile_mark_dirty(sufile, prev->sb_nextnum); |
| 1356 | if (unlikely(err)) | 1358 | if (unlikely(err)) |
| 1357 | return err; | 1359 | return err; |
| 1358 | 1360 | ||
| @@ -1378,33 +1380,33 @@ static int nilfs_segctor_extend_segments(struct nilfs_sc_info *sci, | |||
| 1378 | list_add_tail(&segbuf->sb_list, &list); | 1380 | list_add_tail(&segbuf->sb_list, &list); |
| 1379 | prev = segbuf; | 1381 | prev = segbuf; |
| 1380 | } | 1382 | } |
| 1381 | list_splice(&list, sci->sc_segbufs.prev); | 1383 | list_splice_tail(&list, &sci->sc_segbufs); |
| 1382 | return 0; | 1384 | return 0; |
| 1383 | 1385 | ||
| 1384 | failed_segbuf: | 1386 | failed_segbuf: |
| 1385 | nilfs_segbuf_free(segbuf); | 1387 | nilfs_segbuf_free(segbuf); |
| 1386 | failed: | 1388 | failed: |
| 1387 | list_for_each_entry_safe(segbuf, n, &list, sb_list) { | 1389 | list_for_each_entry(segbuf, &list, sb_list) { |
| 1388 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); | 1390 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); |
| 1389 | WARN_ON(ret); /* never fails */ | 1391 | WARN_ON(ret); /* never fails */ |
| 1390 | list_del_init(&segbuf->sb_list); | ||
| 1391 | nilfs_segbuf_free(segbuf); | ||
| 1392 | } | 1392 | } |
| 1393 | nilfs_destroy_logs(&list); | ||
| 1393 | return err; | 1394 | return err; |
| 1394 | } | 1395 | } |
| 1395 | 1396 | ||
| 1396 | static void nilfs_segctor_free_incomplete_segments(struct nilfs_sc_info *sci, | 1397 | static void nilfs_free_incomplete_logs(struct list_head *logs, |
| 1397 | struct the_nilfs *nilfs) | 1398 | struct the_nilfs *nilfs) |
| 1398 | { | 1399 | { |
| 1399 | struct nilfs_segment_buffer *segbuf; | 1400 | struct nilfs_segment_buffer *segbuf, *prev; |
| 1400 | int ret, done = 0; | 1401 | struct inode *sufile = nilfs->ns_sufile; |
| 1402 | int ret; | ||
| 1401 | 1403 | ||
| 1402 | segbuf = NILFS_FIRST_SEGBUF(&sci->sc_segbufs); | 1404 | segbuf = NILFS_FIRST_SEGBUF(logs); |
| 1403 | if (nilfs->ns_nextnum != segbuf->sb_nextnum) { | 1405 | if (nilfs->ns_nextnum != segbuf->sb_nextnum) { |
| 1404 | ret = nilfs_sufile_free(nilfs->ns_sufile, segbuf->sb_nextnum); | 1406 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); |
| 1405 | WARN_ON(ret); /* never fails */ | 1407 | WARN_ON(ret); /* never fails */ |
| 1406 | } | 1408 | } |
| 1407 | if (segbuf->sb_io_error) { | 1409 | if (atomic_read(&segbuf->sb_err)) { |
| 1408 | /* Case 1: The first segment failed */ | 1410 | /* Case 1: The first segment failed */ |
| 1409 | if (segbuf->sb_pseg_start != segbuf->sb_fseg_start) | 1411 | if (segbuf->sb_pseg_start != segbuf->sb_fseg_start) |
| 1410 | /* Case 1a: Partial segment appended into an existing | 1412 | /* Case 1a: Partial segment appended into an existing |
| @@ -1413,106 +1415,54 @@ static void nilfs_segctor_free_incomplete_segments(struct nilfs_sc_info *sci, | |||
| 1413 | segbuf->sb_fseg_end); | 1415 | segbuf->sb_fseg_end); |
| 1414 | else /* Case 1b: New full segment */ | 1416 | else /* Case 1b: New full segment */ |
| 1415 | set_nilfs_discontinued(nilfs); | 1417 | set_nilfs_discontinued(nilfs); |
| 1416 | done++; | ||
| 1417 | } | 1418 | } |
| 1418 | 1419 | ||
| 1419 | list_for_each_entry_continue(segbuf, &sci->sc_segbufs, sb_list) { | 1420 | prev = segbuf; |
| 1420 | ret = nilfs_sufile_free(nilfs->ns_sufile, segbuf->sb_nextnum); | 1421 | list_for_each_entry_continue(segbuf, logs, sb_list) { |
| 1421 | WARN_ON(ret); /* never fails */ | 1422 | if (prev->sb_nextnum != segbuf->sb_nextnum) { |
| 1422 | if (!done && segbuf->sb_io_error) { | 1423 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); |
| 1423 | if (segbuf->sb_segnum != nilfs->ns_nextnum) | 1424 | WARN_ON(ret); /* never fails */ |
| 1424 | /* Case 2: extended segment (!= next) failed */ | ||
| 1425 | nilfs_sufile_set_error(nilfs->ns_sufile, | ||
| 1426 | segbuf->sb_segnum); | ||
| 1427 | done++; | ||
| 1428 | } | ||
| 1429 | } | ||
| 1430 | } | ||
| 1431 | |||
| 1432 | static void nilfs_segctor_clear_segment_buffers(struct nilfs_sc_info *sci) | ||
| 1433 | { | ||
| 1434 | struct nilfs_segment_buffer *segbuf; | ||
| 1435 | |||
| 1436 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) | ||
| 1437 | nilfs_segbuf_clear(segbuf); | ||
| 1438 | sci->sc_super_root = NULL; | ||
| 1439 | } | ||
| 1440 | |||
| 1441 | static void nilfs_segctor_destroy_segment_buffers(struct nilfs_sc_info *sci) | ||
| 1442 | { | ||
| 1443 | struct nilfs_segment_buffer *segbuf; | ||
| 1444 | |||
| 1445 | while (!list_empty(&sci->sc_segbufs)) { | ||
| 1446 | segbuf = NILFS_FIRST_SEGBUF(&sci->sc_segbufs); | ||
| 1447 | list_del_init(&segbuf->sb_list); | ||
| 1448 | nilfs_segbuf_free(segbuf); | ||
| 1449 | } | ||
| 1450 | /* sci->sc_curseg = NULL; */ | ||
| 1451 | } | ||
| 1452 | |||
| 1453 | static void nilfs_segctor_end_construction(struct nilfs_sc_info *sci, | ||
| 1454 | struct the_nilfs *nilfs, int err) | ||
| 1455 | { | ||
| 1456 | if (unlikely(err)) { | ||
| 1457 | nilfs_segctor_free_incomplete_segments(sci, nilfs); | ||
| 1458 | if (sci->sc_stage.flags & NILFS_CF_SUFREED) { | ||
| 1459 | int ret; | ||
| 1460 | |||
| 1461 | ret = nilfs_sufile_cancel_freev(nilfs->ns_sufile, | ||
| 1462 | sci->sc_freesegs, | ||
| 1463 | sci->sc_nfreesegs, | ||
| 1464 | NULL); | ||
| 1465 | WARN_ON(ret); /* do not happen */ | ||
| 1466 | } | 1425 | } |
| 1426 | if (atomic_read(&segbuf->sb_err) && | ||
| 1427 | segbuf->sb_segnum != nilfs->ns_nextnum) | ||
| 1428 | /* Case 2: extended segment (!= next) failed */ | ||
| 1429 | nilfs_sufile_set_error(sufile, segbuf->sb_segnum); | ||
| 1430 | prev = segbuf; | ||
| 1467 | } | 1431 | } |
| 1468 | nilfs_segctor_clear_segment_buffers(sci); | ||
| 1469 | } | 1432 | } |
| 1470 | 1433 | ||
| 1471 | static void nilfs_segctor_update_segusage(struct nilfs_sc_info *sci, | 1434 | static void nilfs_segctor_update_segusage(struct nilfs_sc_info *sci, |
| 1472 | struct inode *sufile) | 1435 | struct inode *sufile) |
| 1473 | { | 1436 | { |
| 1474 | struct nilfs_segment_buffer *segbuf; | 1437 | struct nilfs_segment_buffer *segbuf; |
| 1475 | struct buffer_head *bh_su; | ||
| 1476 | struct nilfs_segment_usage *raw_su; | ||
| 1477 | unsigned long live_blocks; | 1438 | unsigned long live_blocks; |
| 1478 | int ret; | 1439 | int ret; |
| 1479 | 1440 | ||
| 1480 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1441 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { |
| 1481 | ret = nilfs_sufile_get_segment_usage(sufile, segbuf->sb_segnum, | ||
| 1482 | &raw_su, &bh_su); | ||
| 1483 | WARN_ON(ret); /* always succeed because bh_su is dirty */ | ||
| 1484 | live_blocks = segbuf->sb_sum.nblocks + | 1442 | live_blocks = segbuf->sb_sum.nblocks + |
| 1485 | (segbuf->sb_pseg_start - segbuf->sb_fseg_start); | 1443 | (segbuf->sb_pseg_start - segbuf->sb_fseg_start); |
| 1486 | raw_su->su_lastmod = cpu_to_le64(sci->sc_seg_ctime); | 1444 | ret = nilfs_sufile_set_segment_usage(sufile, segbuf->sb_segnum, |
| 1487 | raw_su->su_nblocks = cpu_to_le32(live_blocks); | 1445 | live_blocks, |
| 1488 | nilfs_sufile_put_segment_usage(sufile, segbuf->sb_segnum, | 1446 | sci->sc_seg_ctime); |
| 1489 | bh_su); | 1447 | WARN_ON(ret); /* always succeed because the segusage is dirty */ |
| 1490 | } | 1448 | } |
| 1491 | } | 1449 | } |
| 1492 | 1450 | ||
| 1493 | static void nilfs_segctor_cancel_segusage(struct nilfs_sc_info *sci, | 1451 | static void nilfs_cancel_segusage(struct list_head *logs, struct inode *sufile) |
| 1494 | struct inode *sufile) | ||
| 1495 | { | 1452 | { |
| 1496 | struct nilfs_segment_buffer *segbuf; | 1453 | struct nilfs_segment_buffer *segbuf; |
| 1497 | struct buffer_head *bh_su; | ||
| 1498 | struct nilfs_segment_usage *raw_su; | ||
| 1499 | int ret; | 1454 | int ret; |
| 1500 | 1455 | ||
| 1501 | segbuf = NILFS_FIRST_SEGBUF(&sci->sc_segbufs); | 1456 | segbuf = NILFS_FIRST_SEGBUF(logs); |
| 1502 | ret = nilfs_sufile_get_segment_usage(sufile, segbuf->sb_segnum, | 1457 | ret = nilfs_sufile_set_segment_usage(sufile, segbuf->sb_segnum, |
| 1503 | &raw_su, &bh_su); | 1458 | segbuf->sb_pseg_start - |
| 1504 | WARN_ON(ret); /* always succeed because bh_su is dirty */ | 1459 | segbuf->sb_fseg_start, 0); |
| 1505 | raw_su->su_nblocks = cpu_to_le32(segbuf->sb_pseg_start - | 1460 | WARN_ON(ret); /* always succeed because the segusage is dirty */ |
| 1506 | segbuf->sb_fseg_start); | ||
| 1507 | nilfs_sufile_put_segment_usage(sufile, segbuf->sb_segnum, bh_su); | ||
| 1508 | 1461 | ||
| 1509 | list_for_each_entry_continue(segbuf, &sci->sc_segbufs, sb_list) { | 1462 | list_for_each_entry_continue(segbuf, logs, sb_list) { |
| 1510 | ret = nilfs_sufile_get_segment_usage(sufile, segbuf->sb_segnum, | 1463 | ret = nilfs_sufile_set_segment_usage(sufile, segbuf->sb_segnum, |
| 1511 | &raw_su, &bh_su); | 1464 | 0, 0); |
| 1512 | WARN_ON(ret); /* always succeed */ | 1465 | WARN_ON(ret); /* always succeed */ |
| 1513 | raw_su->su_nblocks = 0; | ||
| 1514 | nilfs_sufile_put_segment_usage(sufile, segbuf->sb_segnum, | ||
| 1515 | bh_su); | ||
| 1516 | } | 1466 | } |
| 1517 | } | 1467 | } |
| 1518 | 1468 | ||
| @@ -1520,17 +1470,15 @@ static void nilfs_segctor_truncate_segments(struct nilfs_sc_info *sci, | |||
| 1520 | struct nilfs_segment_buffer *last, | 1470 | struct nilfs_segment_buffer *last, |
| 1521 | struct inode *sufile) | 1471 | struct inode *sufile) |
| 1522 | { | 1472 | { |
| 1523 | struct nilfs_segment_buffer *segbuf = last, *n; | 1473 | struct nilfs_segment_buffer *segbuf = last; |
| 1524 | int ret; | 1474 | int ret; |
| 1525 | 1475 | ||
| 1526 | list_for_each_entry_safe_continue(segbuf, n, &sci->sc_segbufs, | 1476 | list_for_each_entry_continue(segbuf, &sci->sc_segbufs, sb_list) { |
| 1527 | sb_list) { | ||
| 1528 | list_del_init(&segbuf->sb_list); | ||
| 1529 | sci->sc_segbuf_nblocks -= segbuf->sb_rest_blocks; | 1477 | sci->sc_segbuf_nblocks -= segbuf->sb_rest_blocks; |
| 1530 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); | 1478 | ret = nilfs_sufile_free(sufile, segbuf->sb_nextnum); |
| 1531 | WARN_ON(ret); | 1479 | WARN_ON(ret); |
| 1532 | nilfs_segbuf_free(segbuf); | ||
| 1533 | } | 1480 | } |
| 1481 | nilfs_truncate_logs(&sci->sc_segbufs, last); | ||
| 1534 | } | 1482 | } |
| 1535 | 1483 | ||
| 1536 | 1484 | ||
| @@ -1569,7 +1517,7 @@ static int nilfs_segctor_collect(struct nilfs_sc_info *sci, | |||
| 1569 | NULL); | 1517 | NULL); |
| 1570 | WARN_ON(err); /* do not happen */ | 1518 | WARN_ON(err); /* do not happen */ |
| 1571 | } | 1519 | } |
| 1572 | nilfs_segctor_clear_segment_buffers(sci); | 1520 | nilfs_clear_logs(&sci->sc_segbufs); |
| 1573 | 1521 | ||
| 1574 | err = nilfs_segctor_extend_segments(sci, nilfs, nadd); | 1522 | err = nilfs_segctor_extend_segments(sci, nilfs, nadd); |
| 1575 | if (unlikely(err)) | 1523 | if (unlikely(err)) |
| @@ -1814,26 +1762,18 @@ static int nilfs_segctor_prepare_write(struct nilfs_sc_info *sci, | |||
| 1814 | } | 1762 | } |
| 1815 | 1763 | ||
| 1816 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, | 1764 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, |
| 1817 | struct backing_dev_info *bdi) | 1765 | struct the_nilfs *nilfs) |
| 1818 | { | 1766 | { |
| 1819 | struct nilfs_segment_buffer *segbuf; | 1767 | struct nilfs_segment_buffer *segbuf; |
| 1820 | struct nilfs_write_info wi; | 1768 | int ret = 0; |
| 1821 | int err, res; | ||
| 1822 | |||
| 1823 | wi.sb = sci->sc_super; | ||
| 1824 | wi.bh_sr = sci->sc_super_root; | ||
| 1825 | wi.bdi = bdi; | ||
| 1826 | 1769 | ||
| 1827 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1770 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { |
| 1828 | nilfs_segbuf_prepare_write(segbuf, &wi); | 1771 | ret = nilfs_segbuf_write(segbuf, nilfs); |
| 1829 | err = nilfs_segbuf_write(segbuf, &wi); | 1772 | if (ret) |
| 1830 | 1773 | break; | |
| 1831 | res = nilfs_segbuf_wait(segbuf, &wi); | ||
| 1832 | err = err ? : res; | ||
| 1833 | if (err) | ||
| 1834 | return err; | ||
| 1835 | } | 1774 | } |
| 1836 | return 0; | 1775 | list_splice_tail_init(&sci->sc_segbufs, &sci->sc_write_logs); |
| 1776 | return ret; | ||
| 1837 | } | 1777 | } |
| 1838 | 1778 | ||
| 1839 | static void __nilfs_end_page_io(struct page *page, int err) | 1779 | static void __nilfs_end_page_io(struct page *page, int err) |
| @@ -1911,15 +1851,17 @@ static void nilfs_clear_copied_buffers(struct list_head *list, int err) | |||
| 1911 | } | 1851 | } |
| 1912 | } | 1852 | } |
| 1913 | 1853 | ||
| 1914 | static void nilfs_segctor_abort_write(struct nilfs_sc_info *sci, | 1854 | static void nilfs_abort_logs(struct list_head *logs, struct page *failed_page, |
| 1915 | struct page *failed_page, int err) | 1855 | struct buffer_head *bh_sr, int err) |
| 1916 | { | 1856 | { |
| 1917 | struct nilfs_segment_buffer *segbuf; | 1857 | struct nilfs_segment_buffer *segbuf; |
| 1918 | struct page *bd_page = NULL, *fs_page = NULL; | 1858 | struct page *bd_page = NULL, *fs_page = NULL; |
| 1859 | struct buffer_head *bh; | ||
| 1919 | 1860 | ||
| 1920 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1861 | if (list_empty(logs)) |
| 1921 | struct buffer_head *bh; | 1862 | return; |
| 1922 | 1863 | ||
| 1864 | list_for_each_entry(segbuf, logs, sb_list) { | ||
| 1923 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, | 1865 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, |
| 1924 | b_assoc_buffers) { | 1866 | b_assoc_buffers) { |
| 1925 | if (bh->b_page != bd_page) { | 1867 | if (bh->b_page != bd_page) { |
| @@ -1931,7 +1873,7 @@ static void nilfs_segctor_abort_write(struct nilfs_sc_info *sci, | |||
| 1931 | 1873 | ||
| 1932 | list_for_each_entry(bh, &segbuf->sb_payload_buffers, | 1874 | list_for_each_entry(bh, &segbuf->sb_payload_buffers, |
| 1933 | b_assoc_buffers) { | 1875 | b_assoc_buffers) { |
| 1934 | if (bh == sci->sc_super_root) { | 1876 | if (bh == bh_sr) { |
| 1935 | if (bh->b_page != bd_page) { | 1877 | if (bh->b_page != bd_page) { |
| 1936 | end_page_writeback(bd_page); | 1878 | end_page_writeback(bd_page); |
| 1937 | bd_page = bh->b_page; | 1879 | bd_page = bh->b_page; |
| @@ -1941,7 +1883,7 @@ static void nilfs_segctor_abort_write(struct nilfs_sc_info *sci, | |||
| 1941 | if (bh->b_page != fs_page) { | 1883 | if (bh->b_page != fs_page) { |
| 1942 | nilfs_end_page_io(fs_page, err); | 1884 | nilfs_end_page_io(fs_page, err); |
| 1943 | if (fs_page && fs_page == failed_page) | 1885 | if (fs_page && fs_page == failed_page) |
| 1944 | goto done; | 1886 | return; |
| 1945 | fs_page = bh->b_page; | 1887 | fs_page = bh->b_page; |
| 1946 | } | 1888 | } |
| 1947 | } | 1889 | } |
| @@ -1950,8 +1892,34 @@ static void nilfs_segctor_abort_write(struct nilfs_sc_info *sci, | |||
| 1950 | end_page_writeback(bd_page); | 1892 | end_page_writeback(bd_page); |
| 1951 | 1893 | ||
| 1952 | nilfs_end_page_io(fs_page, err); | 1894 | nilfs_end_page_io(fs_page, err); |
| 1953 | done: | 1895 | } |
| 1896 | |||
| 1897 | static void nilfs_segctor_abort_construction(struct nilfs_sc_info *sci, | ||
| 1898 | struct the_nilfs *nilfs, int err) | ||
| 1899 | { | ||
| 1900 | LIST_HEAD(logs); | ||
| 1901 | int ret; | ||
| 1902 | |||
| 1903 | list_splice_tail_init(&sci->sc_write_logs, &logs); | ||
| 1904 | ret = nilfs_wait_on_logs(&logs); | ||
| 1905 | if (ret) | ||
| 1906 | nilfs_abort_logs(&logs, NULL, sci->sc_super_root, ret); | ||
| 1907 | |||
| 1908 | list_splice_tail_init(&sci->sc_segbufs, &logs); | ||
| 1909 | nilfs_cancel_segusage(&logs, nilfs->ns_sufile); | ||
| 1910 | nilfs_free_incomplete_logs(&logs, nilfs); | ||
| 1954 | nilfs_clear_copied_buffers(&sci->sc_copied_buffers, err); | 1911 | nilfs_clear_copied_buffers(&sci->sc_copied_buffers, err); |
| 1912 | |||
| 1913 | if (sci->sc_stage.flags & NILFS_CF_SUFREED) { | ||
| 1914 | ret = nilfs_sufile_cancel_freev(nilfs->ns_sufile, | ||
| 1915 | sci->sc_freesegs, | ||
| 1916 | sci->sc_nfreesegs, | ||
| 1917 | NULL); | ||
| 1918 | WARN_ON(ret); /* do not happen */ | ||
| 1919 | } | ||
| 1920 | |||
| 1921 | nilfs_destroy_logs(&logs); | ||
| 1922 | sci->sc_super_root = NULL; | ||
| 1955 | } | 1923 | } |
| 1956 | 1924 | ||
| 1957 | static void nilfs_set_next_segment(struct the_nilfs *nilfs, | 1925 | static void nilfs_set_next_segment(struct the_nilfs *nilfs, |
| @@ -1973,7 +1941,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
| 1973 | struct the_nilfs *nilfs = sbi->s_nilfs; | 1941 | struct the_nilfs *nilfs = sbi->s_nilfs; |
| 1974 | int update_sr = (sci->sc_super_root != NULL); | 1942 | int update_sr = (sci->sc_super_root != NULL); |
| 1975 | 1943 | ||
| 1976 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1944 | list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) { |
| 1977 | struct buffer_head *bh; | 1945 | struct buffer_head *bh; |
| 1978 | 1946 | ||
| 1979 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, | 1947 | list_for_each_entry(bh, &segbuf->sb_segsum_buffers, |
| @@ -2046,7 +2014,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
| 2046 | 2014 | ||
| 2047 | sci->sc_nblk_inc += sci->sc_nblk_this_inc; | 2015 | sci->sc_nblk_inc += sci->sc_nblk_this_inc; |
| 2048 | 2016 | ||
| 2049 | segbuf = NILFS_LAST_SEGBUF(&sci->sc_segbufs); | 2017 | segbuf = NILFS_LAST_SEGBUF(&sci->sc_write_logs); |
| 2050 | nilfs_set_next_segment(nilfs, segbuf); | 2018 | nilfs_set_next_segment(nilfs, segbuf); |
| 2051 | 2019 | ||
| 2052 | if (update_sr) { | 2020 | if (update_sr) { |
| @@ -2057,10 +2025,23 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
| 2057 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); | 2025 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); |
| 2058 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); | 2026 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); |
| 2059 | set_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags); | 2027 | set_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags); |
| 2028 | nilfs_segctor_clear_metadata_dirty(sci); | ||
| 2060 | } else | 2029 | } else |
| 2061 | clear_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags); | 2030 | clear_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags); |
| 2062 | } | 2031 | } |
| 2063 | 2032 | ||
| 2033 | static int nilfs_segctor_wait(struct nilfs_sc_info *sci) | ||
| 2034 | { | ||
| 2035 | int ret; | ||
| 2036 | |||
| 2037 | ret = nilfs_wait_on_logs(&sci->sc_write_logs); | ||
| 2038 | if (!ret) { | ||
| 2039 | nilfs_segctor_complete_write(sci); | ||
| 2040 | nilfs_destroy_logs(&sci->sc_write_logs); | ||
| 2041 | } | ||
| 2042 | return ret; | ||
| 2043 | } | ||
| 2044 | |||
| 2064 | static int nilfs_segctor_check_in_files(struct nilfs_sc_info *sci, | 2045 | static int nilfs_segctor_check_in_files(struct nilfs_sc_info *sci, |
| 2065 | struct nilfs_sb_info *sbi) | 2046 | struct nilfs_sb_info *sbi) |
| 2066 | { | 2047 | { |
| @@ -2173,7 +2154,7 @@ static int nilfs_segctor_do_construct(struct nilfs_sc_info *sci, int mode) | |||
| 2173 | /* Avoid empty segment */ | 2154 | /* Avoid empty segment */ |
| 2174 | if (sci->sc_stage.scnt == NILFS_ST_DONE && | 2155 | if (sci->sc_stage.scnt == NILFS_ST_DONE && |
| 2175 | NILFS_SEG_EMPTY(&sci->sc_curseg->sb_sum)) { | 2156 | NILFS_SEG_EMPTY(&sci->sc_curseg->sb_sum)) { |
| 2176 | nilfs_segctor_end_construction(sci, nilfs, 1); | 2157 | nilfs_segctor_abort_construction(sci, nilfs, 1); |
| 2177 | goto out; | 2158 | goto out; |
| 2178 | } | 2159 | } |
| 2179 | 2160 | ||
| @@ -2187,7 +2168,7 @@ static int nilfs_segctor_do_construct(struct nilfs_sc_info *sci, int mode) | |||
| 2187 | if (has_sr) { | 2168 | if (has_sr) { |
| 2188 | err = nilfs_segctor_fill_in_checkpoint(sci); | 2169 | err = nilfs_segctor_fill_in_checkpoint(sci); |
| 2189 | if (unlikely(err)) | 2170 | if (unlikely(err)) |
| 2190 | goto failed_to_make_up; | 2171 | goto failed_to_write; |
| 2191 | 2172 | ||
| 2192 | nilfs_segctor_fill_in_super_root(sci, nilfs); | 2173 | nilfs_segctor_fill_in_super_root(sci, nilfs); |
| 2193 | } | 2174 | } |
| @@ -2195,42 +2176,46 @@ static int nilfs_segctor_do_construct(struct nilfs_sc_info *sci, int mode) | |||
| 2195 | 2176 | ||
| 2196 | /* Write partial segments */ | 2177 | /* Write partial segments */ |
| 2197 | err = nilfs_segctor_prepare_write(sci, &failed_page); | 2178 | err = nilfs_segctor_prepare_write(sci, &failed_page); |
| 2198 | if (unlikely(err)) | 2179 | if (err) { |
| 2180 | nilfs_abort_logs(&sci->sc_segbufs, failed_page, | ||
| 2181 | sci->sc_super_root, err); | ||
| 2199 | goto failed_to_write; | 2182 | goto failed_to_write; |
| 2200 | 2183 | } | |
| 2201 | nilfs_segctor_fill_in_checksums(sci, nilfs->ns_crc_seed); | 2184 | nilfs_segctor_fill_in_checksums(sci, nilfs->ns_crc_seed); |
| 2202 | 2185 | ||
| 2203 | err = nilfs_segctor_write(sci, nilfs->ns_bdi); | 2186 | err = nilfs_segctor_write(sci, nilfs); |
| 2204 | if (unlikely(err)) | 2187 | if (unlikely(err)) |
| 2205 | goto failed_to_write; | 2188 | goto failed_to_write; |
| 2206 | 2189 | ||
| 2207 | nilfs_segctor_complete_write(sci); | 2190 | if (sci->sc_stage.scnt == NILFS_ST_DONE || |
| 2208 | 2191 | nilfs->ns_blocksize_bits != PAGE_CACHE_SHIFT) { | |
| 2209 | /* Commit segments */ | 2192 | /* |
| 2210 | if (has_sr) | 2193 | * At this point, we avoid double buffering |
| 2211 | nilfs_segctor_clear_metadata_dirty(sci); | 2194 | * for blocksize < pagesize because page dirty |
| 2212 | 2195 | * flag is turned off during write and dirty | |
| 2213 | nilfs_segctor_end_construction(sci, nilfs, 0); | 2196 | * buffers are not properly collected for |
| 2214 | 2197 | * pages crossing over segments. | |
| 2198 | */ | ||
| 2199 | err = nilfs_segctor_wait(sci); | ||
| 2200 | if (err) | ||
| 2201 | goto failed_to_write; | ||
| 2202 | } | ||
| 2215 | } while (sci->sc_stage.scnt != NILFS_ST_DONE); | 2203 | } while (sci->sc_stage.scnt != NILFS_ST_DONE); |
| 2216 | 2204 | ||
| 2205 | sci->sc_super_root = NULL; | ||
| 2206 | |||
| 2217 | out: | 2207 | out: |
| 2218 | nilfs_segctor_destroy_segment_buffers(sci); | ||
| 2219 | nilfs_segctor_check_out_files(sci, sbi); | 2208 | nilfs_segctor_check_out_files(sci, sbi); |
| 2220 | return err; | 2209 | return err; |
| 2221 | 2210 | ||
| 2222 | failed_to_write: | 2211 | failed_to_write: |
| 2223 | nilfs_segctor_abort_write(sci, failed_page, err); | ||
| 2224 | nilfs_segctor_cancel_segusage(sci, nilfs->ns_sufile); | ||
| 2225 | |||
| 2226 | failed_to_make_up: | ||
| 2227 | if (sci->sc_stage.flags & NILFS_CF_IFILE_STARTED) | 2212 | if (sci->sc_stage.flags & NILFS_CF_IFILE_STARTED) |
| 2228 | nilfs_redirty_inodes(&sci->sc_dirty_files); | 2213 | nilfs_redirty_inodes(&sci->sc_dirty_files); |
| 2229 | 2214 | ||
| 2230 | failed: | 2215 | failed: |
| 2231 | if (nilfs_doing_gc()) | 2216 | if (nilfs_doing_gc()) |
| 2232 | nilfs_redirty_inodes(&sci->sc_gc_inodes); | 2217 | nilfs_redirty_inodes(&sci->sc_gc_inodes); |
| 2233 | nilfs_segctor_end_construction(sci, nilfs, err); | 2218 | nilfs_segctor_abort_construction(sci, nilfs, err); |
| 2234 | goto out; | 2219 | goto out; |
| 2235 | } | 2220 | } |
| 2236 | 2221 | ||
| @@ -2559,7 +2544,7 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
| 2559 | 2544 | ||
| 2560 | sci->sc_freesegs = kbufs[4]; | 2545 | sci->sc_freesegs = kbufs[4]; |
| 2561 | sci->sc_nfreesegs = argv[4].v_nmembs; | 2546 | sci->sc_nfreesegs = argv[4].v_nmembs; |
| 2562 | list_splice_init(&nilfs->ns_gc_inodes, sci->sc_gc_inodes.prev); | 2547 | list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes); |
| 2563 | 2548 | ||
| 2564 | for (;;) { | 2549 | for (;;) { |
| 2565 | nilfs_segctor_accept(sci, &req); | 2550 | nilfs_segctor_accept(sci, &req); |
| @@ -2788,6 +2773,7 @@ static struct nilfs_sc_info *nilfs_segctor_new(struct nilfs_sb_info *sbi) | |||
| 2788 | spin_lock_init(&sci->sc_state_lock); | 2773 | spin_lock_init(&sci->sc_state_lock); |
| 2789 | INIT_LIST_HEAD(&sci->sc_dirty_files); | 2774 | INIT_LIST_HEAD(&sci->sc_dirty_files); |
| 2790 | INIT_LIST_HEAD(&sci->sc_segbufs); | 2775 | INIT_LIST_HEAD(&sci->sc_segbufs); |
| 2776 | INIT_LIST_HEAD(&sci->sc_write_logs); | ||
| 2791 | INIT_LIST_HEAD(&sci->sc_gc_inodes); | 2777 | INIT_LIST_HEAD(&sci->sc_gc_inodes); |
| 2792 | INIT_LIST_HEAD(&sci->sc_copied_buffers); | 2778 | INIT_LIST_HEAD(&sci->sc_copied_buffers); |
| 2793 | 2779 | ||
| @@ -2855,6 +2841,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci) | |||
| 2855 | } | 2841 | } |
| 2856 | 2842 | ||
| 2857 | WARN_ON(!list_empty(&sci->sc_segbufs)); | 2843 | WARN_ON(!list_empty(&sci->sc_segbufs)); |
| 2844 | WARN_ON(!list_empty(&sci->sc_write_logs)); | ||
| 2858 | 2845 | ||
| 2859 | down_write(&sbi->s_nilfs->ns_segctor_sem); | 2846 | down_write(&sbi->s_nilfs->ns_segctor_sem); |
| 2860 | 2847 | ||
diff --git a/fs/nilfs2/segment.h b/fs/nilfs2/segment.h index 0d2a475a741b..3d3ab2f9864c 100644 --- a/fs/nilfs2/segment.h +++ b/fs/nilfs2/segment.h | |||
| @@ -97,6 +97,7 @@ struct nilfs_segsum_pointer { | |||
| 97 | * @sc_dsync_start: start byte offset of data pages | 97 | * @sc_dsync_start: start byte offset of data pages |
| 98 | * @sc_dsync_end: end byte offset of data pages (inclusive) | 98 | * @sc_dsync_end: end byte offset of data pages (inclusive) |
| 99 | * @sc_segbufs: List of segment buffers | 99 | * @sc_segbufs: List of segment buffers |
| 100 | * @sc_write_logs: List of segment buffers to hold logs under writing | ||
| 100 | * @sc_segbuf_nblocks: Number of available blocks in segment buffers. | 101 | * @sc_segbuf_nblocks: Number of available blocks in segment buffers. |
| 101 | * @sc_curseg: Current segment buffer | 102 | * @sc_curseg: Current segment buffer |
| 102 | * @sc_super_root: Pointer to the super root buffer | 103 | * @sc_super_root: Pointer to the super root buffer |
| @@ -143,6 +144,7 @@ struct nilfs_sc_info { | |||
| 143 | 144 | ||
| 144 | /* Segment buffers */ | 145 | /* Segment buffers */ |
| 145 | struct list_head sc_segbufs; | 146 | struct list_head sc_segbufs; |
| 147 | struct list_head sc_write_logs; | ||
| 146 | unsigned long sc_segbuf_nblocks; | 148 | unsigned long sc_segbuf_nblocks; |
| 147 | struct nilfs_segment_buffer *sc_curseg; | 149 | struct nilfs_segment_buffer *sc_curseg; |
| 148 | struct buffer_head *sc_super_root; | 150 | struct buffer_head *sc_super_root; |
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c index 37994d4a59cc..b6c36d0cc331 100644 --- a/fs/nilfs2/sufile.c +++ b/fs/nilfs2/sufile.c | |||
| @@ -31,6 +31,16 @@ | |||
| 31 | #include "sufile.h" | 31 | #include "sufile.h" |
| 32 | 32 | ||
| 33 | 33 | ||
| 34 | struct nilfs_sufile_info { | ||
| 35 | struct nilfs_mdt_info mi; | ||
| 36 | unsigned long ncleansegs; | ||
| 37 | }; | ||
| 38 | |||
| 39 | static inline struct nilfs_sufile_info *NILFS_SUI(struct inode *sufile) | ||
| 40 | { | ||
| 41 | return (struct nilfs_sufile_info *)NILFS_MDT(sufile); | ||
| 42 | } | ||
| 43 | |||
| 34 | static inline unsigned long | 44 | static inline unsigned long |
| 35 | nilfs_sufile_segment_usages_per_block(const struct inode *sufile) | 45 | nilfs_sufile_segment_usages_per_block(const struct inode *sufile) |
| 36 | { | 46 | { |
| @@ -62,14 +72,6 @@ nilfs_sufile_segment_usages_in_block(const struct inode *sufile, __u64 curr, | |||
| 62 | max - curr + 1); | 72 | max - curr + 1); |
| 63 | } | 73 | } |
| 64 | 74 | ||
| 65 | static inline struct nilfs_sufile_header * | ||
| 66 | nilfs_sufile_block_get_header(const struct inode *sufile, | ||
| 67 | struct buffer_head *bh, | ||
| 68 | void *kaddr) | ||
| 69 | { | ||
| 70 | return kaddr + bh_offset(bh); | ||
| 71 | } | ||
| 72 | |||
| 73 | static struct nilfs_segment_usage * | 75 | static struct nilfs_segment_usage * |
| 74 | nilfs_sufile_block_get_segment_usage(const struct inode *sufile, __u64 segnum, | 76 | nilfs_sufile_block_get_segment_usage(const struct inode *sufile, __u64 segnum, |
| 75 | struct buffer_head *bh, void *kaddr) | 77 | struct buffer_head *bh, void *kaddr) |
| @@ -110,6 +112,15 @@ static void nilfs_sufile_mod_counter(struct buffer_head *header_bh, | |||
| 110 | } | 112 | } |
| 111 | 113 | ||
| 112 | /** | 114 | /** |
| 115 | * nilfs_sufile_get_ncleansegs - return the number of clean segments | ||
| 116 | * @sufile: inode of segment usage file | ||
| 117 | */ | ||
| 118 | unsigned long nilfs_sufile_get_ncleansegs(struct inode *sufile) | ||
| 119 | { | ||
| 120 | return NILFS_SUI(sufile)->ncleansegs; | ||
| 121 | } | ||
| 122 | |||
| 123 | /** | ||
| 113 | * nilfs_sufile_updatev - modify multiple segment usages at a time | 124 | * nilfs_sufile_updatev - modify multiple segment usages at a time |
| 114 | * @sufile: inode of segment usage file | 125 | * @sufile: inode of segment usage file |
| 115 | * @segnumv: array of segment numbers | 126 | * @segnumv: array of segment numbers |
| @@ -270,7 +281,7 @@ int nilfs_sufile_alloc(struct inode *sufile, __u64 *segnump) | |||
| 270 | if (ret < 0) | 281 | if (ret < 0) |
| 271 | goto out_sem; | 282 | goto out_sem; |
| 272 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); | 283 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); |
| 273 | header = nilfs_sufile_block_get_header(sufile, header_bh, kaddr); | 284 | header = kaddr + bh_offset(header_bh); |
| 274 | ncleansegs = le64_to_cpu(header->sh_ncleansegs); | 285 | ncleansegs = le64_to_cpu(header->sh_ncleansegs); |
| 275 | last_alloc = le64_to_cpu(header->sh_last_alloc); | 286 | last_alloc = le64_to_cpu(header->sh_last_alloc); |
| 276 | kunmap_atomic(kaddr, KM_USER0); | 287 | kunmap_atomic(kaddr, KM_USER0); |
| @@ -302,13 +313,13 @@ int nilfs_sufile_alloc(struct inode *sufile, __u64 *segnump) | |||
| 302 | kunmap_atomic(kaddr, KM_USER0); | 313 | kunmap_atomic(kaddr, KM_USER0); |
| 303 | 314 | ||
| 304 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); | 315 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); |
| 305 | header = nilfs_sufile_block_get_header( | 316 | header = kaddr + bh_offset(header_bh); |
| 306 | sufile, header_bh, kaddr); | ||
| 307 | le64_add_cpu(&header->sh_ncleansegs, -1); | 317 | le64_add_cpu(&header->sh_ncleansegs, -1); |
| 308 | le64_add_cpu(&header->sh_ndirtysegs, 1); | 318 | le64_add_cpu(&header->sh_ndirtysegs, 1); |
| 309 | header->sh_last_alloc = cpu_to_le64(segnum); | 319 | header->sh_last_alloc = cpu_to_le64(segnum); |
| 310 | kunmap_atomic(kaddr, KM_USER0); | 320 | kunmap_atomic(kaddr, KM_USER0); |
| 311 | 321 | ||
| 322 | NILFS_SUI(sufile)->ncleansegs--; | ||
| 312 | nilfs_mdt_mark_buffer_dirty(header_bh); | 323 | nilfs_mdt_mark_buffer_dirty(header_bh); |
| 313 | nilfs_mdt_mark_buffer_dirty(su_bh); | 324 | nilfs_mdt_mark_buffer_dirty(su_bh); |
| 314 | nilfs_mdt_mark_dirty(sufile); | 325 | nilfs_mdt_mark_dirty(sufile); |
| @@ -351,6 +362,8 @@ void nilfs_sufile_do_cancel_free(struct inode *sufile, __u64 segnum, | |||
| 351 | kunmap_atomic(kaddr, KM_USER0); | 362 | kunmap_atomic(kaddr, KM_USER0); |
| 352 | 363 | ||
| 353 | nilfs_sufile_mod_counter(header_bh, -1, 1); | 364 | nilfs_sufile_mod_counter(header_bh, -1, 1); |
| 365 | NILFS_SUI(sufile)->ncleansegs--; | ||
| 366 | |||
| 354 | nilfs_mdt_mark_buffer_dirty(su_bh); | 367 | nilfs_mdt_mark_buffer_dirty(su_bh); |
| 355 | nilfs_mdt_mark_dirty(sufile); | 368 | nilfs_mdt_mark_dirty(sufile); |
| 356 | } | 369 | } |
| @@ -380,6 +393,8 @@ void nilfs_sufile_do_scrap(struct inode *sufile, __u64 segnum, | |||
| 380 | kunmap_atomic(kaddr, KM_USER0); | 393 | kunmap_atomic(kaddr, KM_USER0); |
| 381 | 394 | ||
| 382 | nilfs_sufile_mod_counter(header_bh, clean ? (u64)-1 : 0, dirty ? 0 : 1); | 395 | nilfs_sufile_mod_counter(header_bh, clean ? (u64)-1 : 0, dirty ? 0 : 1); |
| 396 | NILFS_SUI(sufile)->ncleansegs -= clean; | ||
| 397 | |||
| 383 | nilfs_mdt_mark_buffer_dirty(su_bh); | 398 | nilfs_mdt_mark_buffer_dirty(su_bh); |
| 384 | nilfs_mdt_mark_dirty(sufile); | 399 | nilfs_mdt_mark_dirty(sufile); |
| 385 | } | 400 | } |
| @@ -409,79 +424,65 @@ void nilfs_sufile_do_free(struct inode *sufile, __u64 segnum, | |||
| 409 | nilfs_mdt_mark_buffer_dirty(su_bh); | 424 | nilfs_mdt_mark_buffer_dirty(su_bh); |
| 410 | 425 | ||
| 411 | nilfs_sufile_mod_counter(header_bh, 1, sudirty ? (u64)-1 : 0); | 426 | nilfs_sufile_mod_counter(header_bh, 1, sudirty ? (u64)-1 : 0); |
| 427 | NILFS_SUI(sufile)->ncleansegs++; | ||
| 428 | |||
| 412 | nilfs_mdt_mark_dirty(sufile); | 429 | nilfs_mdt_mark_dirty(sufile); |
| 413 | } | 430 | } |
| 414 | 431 | ||
| 415 | /** | 432 | /** |
| 416 | * nilfs_sufile_get_segment_usage - get a segment usage | 433 | * nilfs_sufile_mark_dirty - mark the buffer having a segment usage dirty |
| 417 | * @sufile: inode of segment usage file | 434 | * @sufile: inode of segment usage file |
| 418 | * @segnum: segment number | 435 | * @segnum: segment number |
| 419 | * @sup: pointer to segment usage | ||
| 420 | * @bhp: pointer to buffer head | ||
| 421 | * | ||
| 422 | * Description: nilfs_sufile_get_segment_usage() acquires the segment usage | ||
| 423 | * specified by @segnum. | ||
| 424 | * | ||
| 425 | * Return Value: On success, 0 is returned, and the segment usage and the | ||
| 426 | * buffer head of the buffer on which the segment usage is located are stored | ||
| 427 | * in the place pointed by @sup and @bhp, respectively. On error, one of the | ||
| 428 | * following negative error codes is returned. | ||
| 429 | * | ||
| 430 | * %-EIO - I/O error. | ||
| 431 | * | ||
| 432 | * %-ENOMEM - Insufficient amount of memory available. | ||
| 433 | * | ||
| 434 | * %-EINVAL - Invalid segment usage number. | ||
| 435 | */ | 436 | */ |
| 436 | int nilfs_sufile_get_segment_usage(struct inode *sufile, __u64 segnum, | 437 | int nilfs_sufile_mark_dirty(struct inode *sufile, __u64 segnum) |
| 437 | struct nilfs_segment_usage **sup, | ||
| 438 | struct buffer_head **bhp) | ||
| 439 | { | 438 | { |
| 440 | struct buffer_head *bh; | 439 | struct buffer_head *bh; |
| 441 | struct nilfs_segment_usage *su; | ||
| 442 | void *kaddr; | ||
| 443 | int ret; | 440 | int ret; |
| 444 | 441 | ||
| 445 | /* segnum is 0 origin */ | 442 | ret = nilfs_sufile_get_segment_usage_block(sufile, segnum, 0, &bh); |
| 446 | if (segnum >= nilfs_sufile_get_nsegments(sufile)) | 443 | if (!ret) { |
| 447 | return -EINVAL; | 444 | nilfs_mdt_mark_buffer_dirty(bh); |
| 448 | down_write(&NILFS_MDT(sufile)->mi_sem); | 445 | nilfs_mdt_mark_dirty(sufile); |
| 449 | ret = nilfs_sufile_get_segment_usage_block(sufile, segnum, 1, &bh); | ||
| 450 | if (ret < 0) | ||
| 451 | goto out_sem; | ||
| 452 | kaddr = kmap(bh->b_page); | ||
| 453 | su = nilfs_sufile_block_get_segment_usage(sufile, segnum, bh, kaddr); | ||
| 454 | if (nilfs_segment_usage_error(su)) { | ||
| 455 | kunmap(bh->b_page); | ||
| 456 | brelse(bh); | 446 | brelse(bh); |
| 457 | ret = -EINVAL; | ||
| 458 | goto out_sem; | ||
| 459 | } | 447 | } |
| 460 | |||
| 461 | if (sup != NULL) | ||
| 462 | *sup = su; | ||
| 463 | *bhp = bh; | ||
| 464 | |||
| 465 | out_sem: | ||
| 466 | up_write(&NILFS_MDT(sufile)->mi_sem); | ||
| 467 | return ret; | 448 | return ret; |
| 468 | } | 449 | } |
| 469 | 450 | ||
| 470 | /** | 451 | /** |
| 471 | * nilfs_sufile_put_segment_usage - put a segment usage | 452 | * nilfs_sufile_set_segment_usage - set usage of a segment |
| 472 | * @sufile: inode of segment usage file | 453 | * @sufile: inode of segment usage file |
| 473 | * @segnum: segment number | 454 | * @segnum: segment number |
| 474 | * @bh: buffer head | 455 | * @nblocks: number of live blocks in the segment |
| 475 | * | 456 | * @modtime: modification time (option) |
| 476 | * Description: nilfs_sufile_put_segment_usage() releases the segment usage | ||
| 477 | * specified by @segnum. @bh must be the buffer head which have been returned | ||
| 478 | * by a previous call to nilfs_sufile_get_segment_usage() with @segnum. | ||
| 479 | */ | 457 | */ |
| 480 | void nilfs_sufile_put_segment_usage(struct inode *sufile, __u64 segnum, | 458 | int nilfs_sufile_set_segment_usage(struct inode *sufile, __u64 segnum, |
| 481 | struct buffer_head *bh) | 459 | unsigned long nblocks, time_t modtime) |
| 482 | { | 460 | { |
| 483 | kunmap(bh->b_page); | 461 | struct buffer_head *bh; |
| 462 | struct nilfs_segment_usage *su; | ||
| 463 | void *kaddr; | ||
| 464 | int ret; | ||
| 465 | |||
| 466 | down_write(&NILFS_MDT(sufile)->mi_sem); | ||
| 467 | ret = nilfs_sufile_get_segment_usage_block(sufile, segnum, 0, &bh); | ||
| 468 | if (ret < 0) | ||
| 469 | goto out_sem; | ||
| 470 | |||
| 471 | kaddr = kmap_atomic(bh->b_page, KM_USER0); | ||
| 472 | su = nilfs_sufile_block_get_segment_usage(sufile, segnum, bh, kaddr); | ||
| 473 | WARN_ON(nilfs_segment_usage_error(su)); | ||
| 474 | if (modtime) | ||
| 475 | su->su_lastmod = cpu_to_le64(modtime); | ||
| 476 | su->su_nblocks = cpu_to_le32(nblocks); | ||
| 477 | kunmap_atomic(kaddr, KM_USER0); | ||
| 478 | |||
| 479 | nilfs_mdt_mark_buffer_dirty(bh); | ||
| 480 | nilfs_mdt_mark_dirty(sufile); | ||
| 484 | brelse(bh); | 481 | brelse(bh); |
| 482 | |||
| 483 | out_sem: | ||
| 484 | up_write(&NILFS_MDT(sufile)->mi_sem); | ||
| 485 | return ret; | ||
| 485 | } | 486 | } |
| 486 | 487 | ||
| 487 | /** | 488 | /** |
| @@ -515,7 +516,7 @@ int nilfs_sufile_get_stat(struct inode *sufile, struct nilfs_sustat *sustat) | |||
| 515 | goto out_sem; | 516 | goto out_sem; |
| 516 | 517 | ||
| 517 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); | 518 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); |
| 518 | header = nilfs_sufile_block_get_header(sufile, header_bh, kaddr); | 519 | header = kaddr + bh_offset(header_bh); |
| 519 | sustat->ss_nsegs = nilfs_sufile_get_nsegments(sufile); | 520 | sustat->ss_nsegs = nilfs_sufile_get_nsegments(sufile); |
| 520 | sustat->ss_ncleansegs = le64_to_cpu(header->sh_ncleansegs); | 521 | sustat->ss_ncleansegs = le64_to_cpu(header->sh_ncleansegs); |
| 521 | sustat->ss_ndirtysegs = le64_to_cpu(header->sh_ndirtysegs); | 522 | sustat->ss_ndirtysegs = le64_to_cpu(header->sh_ndirtysegs); |
| @@ -532,33 +533,6 @@ int nilfs_sufile_get_stat(struct inode *sufile, struct nilfs_sustat *sustat) | |||
| 532 | return ret; | 533 | return ret; |
| 533 | } | 534 | } |
| 534 | 535 | ||
| 535 | /** | ||
| 536 | * nilfs_sufile_get_ncleansegs - get the number of clean segments | ||
| 537 | * @sufile: inode of segment usage file | ||
| 538 | * @nsegsp: pointer to the number of clean segments | ||
| 539 | * | ||
| 540 | * Description: nilfs_sufile_get_ncleansegs() acquires the number of clean | ||
| 541 | * segments. | ||
| 542 | * | ||
| 543 | * Return Value: On success, 0 is returned and the number of clean segments is | ||
| 544 | * stored in the place pointed by @nsegsp. On error, one of the following | ||
| 545 | * negative error codes is returned. | ||
| 546 | * | ||
| 547 | * %-EIO - I/O error. | ||
| 548 | * | ||
| 549 | * %-ENOMEM - Insufficient amount of memory available. | ||
| 550 | */ | ||
| 551 | int nilfs_sufile_get_ncleansegs(struct inode *sufile, unsigned long *nsegsp) | ||
| 552 | { | ||
| 553 | struct nilfs_sustat sustat; | ||
| 554 | int ret; | ||
| 555 | |||
| 556 | ret = nilfs_sufile_get_stat(sufile, &sustat); | ||
| 557 | if (ret == 0) | ||
| 558 | *nsegsp = sustat.ss_ncleansegs; | ||
| 559 | return ret; | ||
| 560 | } | ||
| 561 | |||
| 562 | void nilfs_sufile_do_set_error(struct inode *sufile, __u64 segnum, | 536 | void nilfs_sufile_do_set_error(struct inode *sufile, __u64 segnum, |
| 563 | struct buffer_head *header_bh, | 537 | struct buffer_head *header_bh, |
| 564 | struct buffer_head *su_bh) | 538 | struct buffer_head *su_bh) |
| @@ -577,8 +551,10 @@ void nilfs_sufile_do_set_error(struct inode *sufile, __u64 segnum, | |||
| 577 | nilfs_segment_usage_set_error(su); | 551 | nilfs_segment_usage_set_error(su); |
| 578 | kunmap_atomic(kaddr, KM_USER0); | 552 | kunmap_atomic(kaddr, KM_USER0); |
| 579 | 553 | ||
| 580 | if (suclean) | 554 | if (suclean) { |
| 581 | nilfs_sufile_mod_counter(header_bh, -1, 0); | 555 | nilfs_sufile_mod_counter(header_bh, -1, 0); |
| 556 | NILFS_SUI(sufile)->ncleansegs--; | ||
| 557 | } | ||
| 582 | nilfs_mdt_mark_buffer_dirty(su_bh); | 558 | nilfs_mdt_mark_buffer_dirty(su_bh); |
| 583 | nilfs_mdt_mark_dirty(sufile); | 559 | nilfs_mdt_mark_dirty(sufile); |
| 584 | } | 560 | } |
| @@ -657,3 +633,48 @@ ssize_t nilfs_sufile_get_suinfo(struct inode *sufile, __u64 segnum, void *buf, | |||
| 657 | up_read(&NILFS_MDT(sufile)->mi_sem); | 633 | up_read(&NILFS_MDT(sufile)->mi_sem); |
| 658 | return ret; | 634 | return ret; |
| 659 | } | 635 | } |
| 636 | |||
| 637 | /** | ||
| 638 | * nilfs_sufile_read - read sufile inode | ||
| 639 | * @sufile: sufile inode | ||
| 640 | * @raw_inode: on-disk sufile inode | ||
| 641 | */ | ||
| 642 | int nilfs_sufile_read(struct inode *sufile, struct nilfs_inode *raw_inode) | ||
| 643 | { | ||
| 644 | struct nilfs_sufile_info *sui = NILFS_SUI(sufile); | ||
| 645 | struct buffer_head *header_bh; | ||
| 646 | struct nilfs_sufile_header *header; | ||
| 647 | void *kaddr; | ||
| 648 | int ret; | ||
| 649 | |||
| 650 | ret = nilfs_read_inode_common(sufile, raw_inode); | ||
| 651 | if (ret < 0) | ||
| 652 | return ret; | ||
| 653 | |||
| 654 | ret = nilfs_sufile_get_header_block(sufile, &header_bh); | ||
| 655 | if (!ret) { | ||
| 656 | kaddr = kmap_atomic(header_bh->b_page, KM_USER0); | ||
| 657 | header = kaddr + bh_offset(header_bh); | ||
| 658 | sui->ncleansegs = le64_to_cpu(header->sh_ncleansegs); | ||
| 659 | kunmap_atomic(kaddr, KM_USER0); | ||
| 660 | brelse(header_bh); | ||
| 661 | } | ||
| 662 | return ret; | ||
| 663 | } | ||
| 664 | |||
| 665 | /** | ||
| 666 | * nilfs_sufile_new - create sufile | ||
| 667 | * @nilfs: nilfs object | ||
| 668 | * @susize: size of a segment usage entry | ||
| 669 | */ | ||
| 670 | struct inode *nilfs_sufile_new(struct the_nilfs *nilfs, size_t susize) | ||
| 671 | { | ||
| 672 | struct inode *sufile; | ||
| 673 | |||
| 674 | sufile = nilfs_mdt_new(nilfs, NULL, NILFS_SUFILE_INO, | ||
| 675 | sizeof(struct nilfs_sufile_info)); | ||
| 676 | if (sufile) | ||
| 677 | nilfs_mdt_set_entry_size(sufile, susize, | ||
| 678 | sizeof(struct nilfs_sufile_header)); | ||
| 679 | return sufile; | ||
| 680 | } | ||
diff --git a/fs/nilfs2/sufile.h b/fs/nilfs2/sufile.h index 0e99e5c0bd0f..15163b8aff7d 100644 --- a/fs/nilfs2/sufile.h +++ b/fs/nilfs2/sufile.h | |||
| @@ -34,14 +34,13 @@ static inline unsigned long nilfs_sufile_get_nsegments(struct inode *sufile) | |||
| 34 | return NILFS_MDT(sufile)->mi_nilfs->ns_nsegments; | 34 | return NILFS_MDT(sufile)->mi_nilfs->ns_nsegments; |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | unsigned long nilfs_sufile_get_ncleansegs(struct inode *sufile); | ||
| 38 | |||
| 37 | int nilfs_sufile_alloc(struct inode *, __u64 *); | 39 | int nilfs_sufile_alloc(struct inode *, __u64 *); |
| 38 | int nilfs_sufile_get_segment_usage(struct inode *, __u64, | 40 | int nilfs_sufile_mark_dirty(struct inode *sufile, __u64 segnum); |
| 39 | struct nilfs_segment_usage **, | 41 | int nilfs_sufile_set_segment_usage(struct inode *sufile, __u64 segnum, |
| 40 | struct buffer_head **); | 42 | unsigned long nblocks, time_t modtime); |
| 41 | void nilfs_sufile_put_segment_usage(struct inode *, __u64, | ||
| 42 | struct buffer_head *); | ||
| 43 | int nilfs_sufile_get_stat(struct inode *, struct nilfs_sustat *); | 43 | int nilfs_sufile_get_stat(struct inode *, struct nilfs_sustat *); |
| 44 | int nilfs_sufile_get_ncleansegs(struct inode *, unsigned long *); | ||
| 45 | ssize_t nilfs_sufile_get_suinfo(struct inode *, __u64, void *, unsigned, | 44 | ssize_t nilfs_sufile_get_suinfo(struct inode *, __u64, void *, unsigned, |
| 46 | size_t); | 45 | size_t); |
| 47 | 46 | ||
| @@ -62,6 +61,9 @@ void nilfs_sufile_do_cancel_free(struct inode *, __u64, struct buffer_head *, | |||
| 62 | void nilfs_sufile_do_set_error(struct inode *, __u64, struct buffer_head *, | 61 | void nilfs_sufile_do_set_error(struct inode *, __u64, struct buffer_head *, |
| 63 | struct buffer_head *); | 62 | struct buffer_head *); |
| 64 | 63 | ||
| 64 | int nilfs_sufile_read(struct inode *sufile, struct nilfs_inode *raw_inode); | ||
| 65 | struct inode *nilfs_sufile_new(struct the_nilfs *nilfs, size_t susize); | ||
| 66 | |||
| 65 | /** | 67 | /** |
| 66 | * nilfs_sufile_scrap - make a segment garbage | 68 | * nilfs_sufile_scrap - make a segment garbage |
| 67 | * @sufile: inode of segment usage file | 69 | * @sufile: inode of segment usage file |
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 644e66727dd0..5403b3ef3a42 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
| @@ -363,14 +363,10 @@ int nilfs_attach_checkpoint(struct nilfs_sb_info *sbi, __u64 cno) | |||
| 363 | list_add(&sbi->s_list, &nilfs->ns_supers); | 363 | list_add(&sbi->s_list, &nilfs->ns_supers); |
| 364 | up_write(&nilfs->ns_super_sem); | 364 | up_write(&nilfs->ns_super_sem); |
| 365 | 365 | ||
| 366 | sbi->s_ifile = nilfs_mdt_new(nilfs, sbi->s_super, NILFS_IFILE_INO); | 366 | sbi->s_ifile = nilfs_ifile_new(sbi, nilfs->ns_inode_size); |
| 367 | if (!sbi->s_ifile) | 367 | if (!sbi->s_ifile) |
| 368 | return -ENOMEM; | 368 | return -ENOMEM; |
| 369 | 369 | ||
| 370 | err = nilfs_palloc_init_blockgroup(sbi->s_ifile, nilfs->ns_inode_size); | ||
| 371 | if (unlikely(err)) | ||
| 372 | goto failed; | ||
| 373 | |||
| 374 | down_read(&nilfs->ns_segctor_sem); | 370 | down_read(&nilfs->ns_segctor_sem); |
| 375 | err = nilfs_cpfile_get_checkpoint(nilfs->ns_cpfile, cno, 0, &raw_cp, | 371 | err = nilfs_cpfile_get_checkpoint(nilfs->ns_cpfile, cno, 0, &raw_cp, |
| 376 | &bh_cp); | 372 | &bh_cp); |
| @@ -411,7 +407,6 @@ void nilfs_detach_checkpoint(struct nilfs_sb_info *sbi) | |||
| 411 | { | 407 | { |
| 412 | struct the_nilfs *nilfs = sbi->s_nilfs; | 408 | struct the_nilfs *nilfs = sbi->s_nilfs; |
| 413 | 409 | ||
| 414 | nilfs_mdt_clear(sbi->s_ifile); | ||
| 415 | nilfs_mdt_destroy(sbi->s_ifile); | 410 | nilfs_mdt_destroy(sbi->s_ifile); |
| 416 | sbi->s_ifile = NULL; | 411 | sbi->s_ifile = NULL; |
| 417 | down_write(&nilfs->ns_super_sem); | 412 | down_write(&nilfs->ns_super_sem); |
| @@ -419,22 +414,6 @@ void nilfs_detach_checkpoint(struct nilfs_sb_info *sbi) | |||
| 419 | up_write(&nilfs->ns_super_sem); | 414 | up_write(&nilfs->ns_super_sem); |
| 420 | } | 415 | } |
| 421 | 416 | ||
| 422 | static int nilfs_mark_recovery_complete(struct nilfs_sb_info *sbi) | ||
| 423 | { | ||
| 424 | struct the_nilfs *nilfs = sbi->s_nilfs; | ||
| 425 | int err = 0; | ||
| 426 | |||
| 427 | down_write(&nilfs->ns_sem); | ||
| 428 | if (!(nilfs->ns_mount_state & NILFS_VALID_FS)) { | ||
| 429 | nilfs->ns_mount_state |= NILFS_VALID_FS; | ||
| 430 | err = nilfs_commit_super(sbi, 1); | ||
| 431 | if (likely(!err)) | ||
| 432 | printk(KERN_INFO "NILFS: recovery complete.\n"); | ||
| 433 | } | ||
| 434 | up_write(&nilfs->ns_sem); | ||
| 435 | return err; | ||
| 436 | } | ||
| 437 | |||
| 438 | static int nilfs_statfs(struct dentry *dentry, struct kstatfs *buf) | 417 | static int nilfs_statfs(struct dentry *dentry, struct kstatfs *buf) |
| 439 | { | 418 | { |
| 440 | struct super_block *sb = dentry->d_sb; | 419 | struct super_block *sb = dentry->d_sb; |
| @@ -490,7 +469,7 @@ static int nilfs_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
| 490 | struct nilfs_sb_info *sbi = NILFS_SB(sb); | 469 | struct nilfs_sb_info *sbi = NILFS_SB(sb); |
| 491 | 470 | ||
| 492 | if (!nilfs_test_opt(sbi, BARRIER)) | 471 | if (!nilfs_test_opt(sbi, BARRIER)) |
| 493 | seq_printf(seq, ",barrier=off"); | 472 | seq_printf(seq, ",nobarrier"); |
| 494 | if (nilfs_test_opt(sbi, SNAPSHOT)) | 473 | if (nilfs_test_opt(sbi, SNAPSHOT)) |
| 495 | seq_printf(seq, ",cp=%llu", | 474 | seq_printf(seq, ",cp=%llu", |
| 496 | (unsigned long long int)sbi->s_snapshot_cno); | 475 | (unsigned long long int)sbi->s_snapshot_cno); |
| @@ -500,6 +479,8 @@ static int nilfs_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
| 500 | seq_printf(seq, ",errors=panic"); | 479 | seq_printf(seq, ",errors=panic"); |
| 501 | if (nilfs_test_opt(sbi, STRICT_ORDER)) | 480 | if (nilfs_test_opt(sbi, STRICT_ORDER)) |
| 502 | seq_printf(seq, ",order=strict"); | 481 | seq_printf(seq, ",order=strict"); |
| 482 | if (nilfs_test_opt(sbi, NORECOVERY)) | ||
| 483 | seq_printf(seq, ",norecovery"); | ||
| 503 | 484 | ||
| 504 | return 0; | 485 | return 0; |
| 505 | } | 486 | } |
| @@ -568,7 +549,7 @@ static const struct export_operations nilfs_export_ops = { | |||
| 568 | 549 | ||
| 569 | enum { | 550 | enum { |
| 570 | Opt_err_cont, Opt_err_panic, Opt_err_ro, | 551 | Opt_err_cont, Opt_err_panic, Opt_err_ro, |
| 571 | Opt_barrier, Opt_snapshot, Opt_order, | 552 | Opt_nobarrier, Opt_snapshot, Opt_order, Opt_norecovery, |
| 572 | Opt_err, | 553 | Opt_err, |
| 573 | }; | 554 | }; |
| 574 | 555 | ||
| @@ -576,25 +557,13 @@ static match_table_t tokens = { | |||
| 576 | {Opt_err_cont, "errors=continue"}, | 557 | {Opt_err_cont, "errors=continue"}, |
| 577 | {Opt_err_panic, "errors=panic"}, | 558 | {Opt_err_panic, "errors=panic"}, |
| 578 | {Opt_err_ro, "errors=remount-ro"}, | 559 | {Opt_err_ro, "errors=remount-ro"}, |
| 579 | {Opt_barrier, "barrier=%s"}, | 560 | {Opt_nobarrier, "nobarrier"}, |
| 580 | {Opt_snapshot, "cp=%u"}, | 561 | {Opt_snapshot, "cp=%u"}, |
| 581 | {Opt_order, "order=%s"}, | 562 | {Opt_order, "order=%s"}, |
| 563 | {Opt_norecovery, "norecovery"}, | ||
| 582 | {Opt_err, NULL} | 564 | {Opt_err, NULL} |
| 583 | }; | 565 | }; |
| 584 | 566 | ||
| 585 | static int match_bool(substring_t *s, int *result) | ||
| 586 | { | ||
| 587 | int len = s->to - s->from; | ||
| 588 | |||
| 589 | if (strncmp(s->from, "on", len) == 0) | ||
| 590 | *result = 1; | ||
| 591 | else if (strncmp(s->from, "off", len) == 0) | ||
| 592 | *result = 0; | ||
| 593 | else | ||
| 594 | return 1; | ||
| 595 | return 0; | ||
| 596 | } | ||
| 597 | |||
| 598 | static int parse_options(char *options, struct super_block *sb) | 567 | static int parse_options(char *options, struct super_block *sb) |
| 599 | { | 568 | { |
| 600 | struct nilfs_sb_info *sbi = NILFS_SB(sb); | 569 | struct nilfs_sb_info *sbi = NILFS_SB(sb); |
| @@ -612,13 +581,8 @@ static int parse_options(char *options, struct super_block *sb) | |||
| 612 | 581 | ||
| 613 | token = match_token(p, tokens, args); | 582 | token = match_token(p, tokens, args); |
| 614 | switch (token) { | 583 | switch (token) { |
| 615 | case Opt_barrier: | 584 | case Opt_nobarrier: |
| 616 | if (match_bool(&args[0], &option)) | 585 | nilfs_clear_opt(sbi, BARRIER); |
| 617 | return 0; | ||
| 618 | if (option) | ||
| 619 | nilfs_set_opt(sbi, BARRIER); | ||
| 620 | else | ||
| 621 | nilfs_clear_opt(sbi, BARRIER); | ||
| 622 | break; | 586 | break; |
| 623 | case Opt_order: | 587 | case Opt_order: |
| 624 | if (strcmp(args[0].from, "relaxed") == 0) | 588 | if (strcmp(args[0].from, "relaxed") == 0) |
| @@ -647,6 +611,9 @@ static int parse_options(char *options, struct super_block *sb) | |||
| 647 | sbi->s_snapshot_cno = option; | 611 | sbi->s_snapshot_cno = option; |
| 648 | nilfs_set_opt(sbi, SNAPSHOT); | 612 | nilfs_set_opt(sbi, SNAPSHOT); |
| 649 | break; | 613 | break; |
| 614 | case Opt_norecovery: | ||
| 615 | nilfs_set_opt(sbi, NORECOVERY); | ||
| 616 | break; | ||
| 650 | default: | 617 | default: |
| 651 | printk(KERN_ERR | 618 | printk(KERN_ERR |
| 652 | "NILFS: Unrecognized mount option \"%s\"\n", p); | 619 | "NILFS: Unrecognized mount option \"%s\"\n", p); |
| @@ -672,9 +639,7 @@ static int nilfs_setup_super(struct nilfs_sb_info *sbi) | |||
| 672 | int mnt_count = le16_to_cpu(sbp->s_mnt_count); | 639 | int mnt_count = le16_to_cpu(sbp->s_mnt_count); |
| 673 | 640 | ||
| 674 | /* nilfs->sem must be locked by the caller. */ | 641 | /* nilfs->sem must be locked by the caller. */ |
| 675 | if (!(nilfs->ns_mount_state & NILFS_VALID_FS)) { | 642 | if (nilfs->ns_mount_state & NILFS_ERROR_FS) { |
| 676 | printk(KERN_WARNING "NILFS warning: mounting unchecked fs\n"); | ||
| 677 | } else if (nilfs->ns_mount_state & NILFS_ERROR_FS) { | ||
| 678 | printk(KERN_WARNING | 643 | printk(KERN_WARNING |
| 679 | "NILFS warning: mounting fs with errors\n"); | 644 | "NILFS warning: mounting fs with errors\n"); |
| 680 | #if 0 | 645 | #if 0 |
| @@ -782,11 +747,10 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent, | |||
| 782 | sb->s_root = NULL; | 747 | sb->s_root = NULL; |
| 783 | sb->s_time_gran = 1; | 748 | sb->s_time_gran = 1; |
| 784 | 749 | ||
| 785 | if (!nilfs_loaded(nilfs)) { | 750 | err = load_nilfs(nilfs, sbi); |
| 786 | err = load_nilfs(nilfs, sbi); | 751 | if (err) |
| 787 | if (err) | 752 | goto failed_sbi; |
| 788 | goto failed_sbi; | 753 | |
| 789 | } | ||
| 790 | cno = nilfs_last_cno(nilfs); | 754 | cno = nilfs_last_cno(nilfs); |
| 791 | 755 | ||
| 792 | if (sb->s_flags & MS_RDONLY) { | 756 | if (sb->s_flags & MS_RDONLY) { |
| @@ -854,12 +818,6 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent, | |||
| 854 | up_write(&nilfs->ns_sem); | 818 | up_write(&nilfs->ns_sem); |
| 855 | } | 819 | } |
| 856 | 820 | ||
| 857 | err = nilfs_mark_recovery_complete(sbi); | ||
| 858 | if (unlikely(err)) { | ||
| 859 | printk(KERN_ERR "NILFS: recovery failed.\n"); | ||
| 860 | goto failed_root; | ||
| 861 | } | ||
| 862 | |||
| 863 | down_write(&nilfs->ns_super_sem); | 821 | down_write(&nilfs->ns_super_sem); |
| 864 | if (!nilfs_test_opt(sbi, SNAPSHOT)) | 822 | if (!nilfs_test_opt(sbi, SNAPSHOT)) |
| 865 | nilfs->ns_current = sbi; | 823 | nilfs->ns_current = sbi; |
| @@ -867,10 +825,6 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent, | |||
| 867 | 825 | ||
| 868 | return 0; | 826 | return 0; |
| 869 | 827 | ||
| 870 | failed_root: | ||
| 871 | dput(sb->s_root); | ||
| 872 | sb->s_root = NULL; | ||
| 873 | |||
| 874 | failed_segctor: | 828 | failed_segctor: |
| 875 | nilfs_detach_segment_constructor(sbi); | 829 | nilfs_detach_segment_constructor(sbi); |
| 876 | 830 | ||
| @@ -915,6 +869,14 @@ static int nilfs_remount(struct super_block *sb, int *flags, char *data) | |||
| 915 | goto restore_opts; | 869 | goto restore_opts; |
| 916 | } | 870 | } |
| 917 | 871 | ||
| 872 | if (!nilfs_valid_fs(nilfs)) { | ||
| 873 | printk(KERN_WARNING "NILFS (device %s): couldn't " | ||
| 874 | "remount because the filesystem is in an " | ||
| 875 | "incomplete recovery state.\n", sb->s_id); | ||
| 876 | err = -EINVAL; | ||
| 877 | goto restore_opts; | ||
| 878 | } | ||
| 879 | |||
| 918 | if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) | 880 | if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) |
| 919 | goto out; | 881 | goto out; |
| 920 | if (*flags & MS_RDONLY) { | 882 | if (*flags & MS_RDONLY) { |
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index ad391a8c3e7e..6241e1722efc 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c | |||
| @@ -146,13 +146,9 @@ void put_nilfs(struct the_nilfs *nilfs) | |||
| 146 | 146 | ||
| 147 | might_sleep(); | 147 | might_sleep(); |
| 148 | if (nilfs_loaded(nilfs)) { | 148 | if (nilfs_loaded(nilfs)) { |
| 149 | nilfs_mdt_clear(nilfs->ns_sufile); | ||
| 150 | nilfs_mdt_destroy(nilfs->ns_sufile); | 149 | nilfs_mdt_destroy(nilfs->ns_sufile); |
| 151 | nilfs_mdt_clear(nilfs->ns_cpfile); | ||
| 152 | nilfs_mdt_destroy(nilfs->ns_cpfile); | 150 | nilfs_mdt_destroy(nilfs->ns_cpfile); |
| 153 | nilfs_mdt_clear(nilfs->ns_dat); | ||
| 154 | nilfs_mdt_destroy(nilfs->ns_dat); | 151 | nilfs_mdt_destroy(nilfs->ns_dat); |
| 155 | /* XXX: how and when to clear nilfs->ns_gc_dat? */ | ||
| 156 | nilfs_mdt_destroy(nilfs->ns_gc_dat); | 152 | nilfs_mdt_destroy(nilfs->ns_gc_dat); |
| 157 | } | 153 | } |
| 158 | if (nilfs_init(nilfs)) { | 154 | if (nilfs_init(nilfs)) { |
| @@ -166,7 +162,6 @@ void put_nilfs(struct the_nilfs *nilfs) | |||
| 166 | static int nilfs_load_super_root(struct the_nilfs *nilfs, | 162 | static int nilfs_load_super_root(struct the_nilfs *nilfs, |
| 167 | struct nilfs_sb_info *sbi, sector_t sr_block) | 163 | struct nilfs_sb_info *sbi, sector_t sr_block) |
| 168 | { | 164 | { |
| 169 | static struct lock_class_key dat_lock_key; | ||
| 170 | struct buffer_head *bh_sr; | 165 | struct buffer_head *bh_sr; |
| 171 | struct nilfs_super_root *raw_sr; | 166 | struct nilfs_super_root *raw_sr; |
| 172 | struct nilfs_super_block **sbp = nilfs->ns_sbp; | 167 | struct nilfs_super_block **sbp = nilfs->ns_sbp; |
| @@ -187,51 +182,36 @@ static int nilfs_load_super_root(struct the_nilfs *nilfs, | |||
| 187 | inode_size = nilfs->ns_inode_size; | 182 | inode_size = nilfs->ns_inode_size; |
| 188 | 183 | ||
| 189 | err = -ENOMEM; | 184 | err = -ENOMEM; |
| 190 | nilfs->ns_dat = nilfs_mdt_new(nilfs, NULL, NILFS_DAT_INO); | 185 | nilfs->ns_dat = nilfs_dat_new(nilfs, dat_entry_size); |
| 191 | if (unlikely(!nilfs->ns_dat)) | 186 | if (unlikely(!nilfs->ns_dat)) |
| 192 | goto failed; | 187 | goto failed; |
| 193 | 188 | ||
| 194 | nilfs->ns_gc_dat = nilfs_mdt_new(nilfs, NULL, NILFS_DAT_INO); | 189 | nilfs->ns_gc_dat = nilfs_dat_new(nilfs, dat_entry_size); |
| 195 | if (unlikely(!nilfs->ns_gc_dat)) | 190 | if (unlikely(!nilfs->ns_gc_dat)) |
| 196 | goto failed_dat; | 191 | goto failed_dat; |
| 197 | 192 | ||
| 198 | nilfs->ns_cpfile = nilfs_mdt_new(nilfs, NULL, NILFS_CPFILE_INO); | 193 | nilfs->ns_cpfile = nilfs_cpfile_new(nilfs, checkpoint_size); |
| 199 | if (unlikely(!nilfs->ns_cpfile)) | 194 | if (unlikely(!nilfs->ns_cpfile)) |
| 200 | goto failed_gc_dat; | 195 | goto failed_gc_dat; |
| 201 | 196 | ||
| 202 | nilfs->ns_sufile = nilfs_mdt_new(nilfs, NULL, NILFS_SUFILE_INO); | 197 | nilfs->ns_sufile = nilfs_sufile_new(nilfs, segment_usage_size); |
| 203 | if (unlikely(!nilfs->ns_sufile)) | 198 | if (unlikely(!nilfs->ns_sufile)) |
| 204 | goto failed_cpfile; | 199 | goto failed_cpfile; |
| 205 | 200 | ||
| 206 | err = nilfs_palloc_init_blockgroup(nilfs->ns_dat, dat_entry_size); | ||
| 207 | if (unlikely(err)) | ||
| 208 | goto failed_sufile; | ||
| 209 | |||
| 210 | err = nilfs_palloc_init_blockgroup(nilfs->ns_gc_dat, dat_entry_size); | ||
| 211 | if (unlikely(err)) | ||
| 212 | goto failed_sufile; | ||
| 213 | |||
| 214 | lockdep_set_class(&NILFS_MDT(nilfs->ns_dat)->mi_sem, &dat_lock_key); | ||
| 215 | lockdep_set_class(&NILFS_MDT(nilfs->ns_gc_dat)->mi_sem, &dat_lock_key); | ||
| 216 | |||
| 217 | nilfs_mdt_set_shadow(nilfs->ns_dat, nilfs->ns_gc_dat); | 201 | nilfs_mdt_set_shadow(nilfs->ns_dat, nilfs->ns_gc_dat); |
| 218 | nilfs_mdt_set_entry_size(nilfs->ns_cpfile, checkpoint_size, | ||
| 219 | sizeof(struct nilfs_cpfile_header)); | ||
| 220 | nilfs_mdt_set_entry_size(nilfs->ns_sufile, segment_usage_size, | ||
| 221 | sizeof(struct nilfs_sufile_header)); | ||
| 222 | 202 | ||
| 223 | err = nilfs_mdt_read_inode_direct( | 203 | err = nilfs_dat_read(nilfs->ns_dat, (void *)bh_sr->b_data + |
| 224 | nilfs->ns_dat, bh_sr, NILFS_SR_DAT_OFFSET(inode_size)); | 204 | NILFS_SR_DAT_OFFSET(inode_size)); |
| 225 | if (unlikely(err)) | 205 | if (unlikely(err)) |
| 226 | goto failed_sufile; | 206 | goto failed_sufile; |
| 227 | 207 | ||
| 228 | err = nilfs_mdt_read_inode_direct( | 208 | err = nilfs_cpfile_read(nilfs->ns_cpfile, (void *)bh_sr->b_data + |
| 229 | nilfs->ns_cpfile, bh_sr, NILFS_SR_CPFILE_OFFSET(inode_size)); | 209 | NILFS_SR_CPFILE_OFFSET(inode_size)); |
| 230 | if (unlikely(err)) | 210 | if (unlikely(err)) |
| 231 | goto failed_sufile; | 211 | goto failed_sufile; |
| 232 | 212 | ||
| 233 | err = nilfs_mdt_read_inode_direct( | 213 | err = nilfs_sufile_read(nilfs->ns_sufile, (void *)bh_sr->b_data + |
| 234 | nilfs->ns_sufile, bh_sr, NILFS_SR_SUFILE_OFFSET(inode_size)); | 214 | NILFS_SR_SUFILE_OFFSET(inode_size)); |
| 235 | if (unlikely(err)) | 215 | if (unlikely(err)) |
| 236 | goto failed_sufile; | 216 | goto failed_sufile; |
| 237 | 217 | ||
| @@ -281,29 +261,30 @@ int load_nilfs(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi) | |||
| 281 | struct nilfs_recovery_info ri; | 261 | struct nilfs_recovery_info ri; |
| 282 | unsigned int s_flags = sbi->s_super->s_flags; | 262 | unsigned int s_flags = sbi->s_super->s_flags; |
| 283 | int really_read_only = bdev_read_only(nilfs->ns_bdev); | 263 | int really_read_only = bdev_read_only(nilfs->ns_bdev); |
| 284 | unsigned valid_fs; | 264 | int valid_fs = nilfs_valid_fs(nilfs); |
| 285 | int err = 0; | 265 | int err; |
| 286 | |||
| 287 | nilfs_init_recovery_info(&ri); | ||
| 288 | 266 | ||
| 289 | down_write(&nilfs->ns_sem); | 267 | if (nilfs_loaded(nilfs)) { |
| 290 | valid_fs = (nilfs->ns_mount_state & NILFS_VALID_FS); | 268 | if (valid_fs || |
| 291 | up_write(&nilfs->ns_sem); | 269 | ((s_flags & MS_RDONLY) && nilfs_test_opt(sbi, NORECOVERY))) |
| 270 | return 0; | ||
| 271 | printk(KERN_ERR "NILFS: the filesystem is in an incomplete " | ||
| 272 | "recovery state.\n"); | ||
| 273 | return -EINVAL; | ||
| 274 | } | ||
| 292 | 275 | ||
| 293 | if (!valid_fs && (s_flags & MS_RDONLY)) { | 276 | if (!valid_fs) { |
| 294 | printk(KERN_INFO "NILFS: INFO: recovery " | 277 | printk(KERN_WARNING "NILFS warning: mounting unchecked fs\n"); |
| 295 | "required for readonly filesystem.\n"); | 278 | if (s_flags & MS_RDONLY) { |
| 296 | if (really_read_only) { | 279 | printk(KERN_INFO "NILFS: INFO: recovery " |
| 297 | printk(KERN_ERR "NILFS: write access " | 280 | "required for readonly filesystem.\n"); |
| 298 | "unavailable, cannot proceed.\n"); | 281 | printk(KERN_INFO "NILFS: write access will " |
| 299 | err = -EROFS; | 282 | "be enabled during recovery.\n"); |
| 300 | goto failed; | ||
| 301 | } | 283 | } |
| 302 | printk(KERN_INFO "NILFS: write access will " | ||
| 303 | "be enabled during recovery.\n"); | ||
| 304 | sbi->s_super->s_flags &= ~MS_RDONLY; | ||
| 305 | } | 284 | } |
| 306 | 285 | ||
| 286 | nilfs_init_recovery_info(&ri); | ||
| 287 | |||
| 307 | err = nilfs_search_super_root(nilfs, sbi, &ri); | 288 | err = nilfs_search_super_root(nilfs, sbi, &ri); |
| 308 | if (unlikely(err)) { | 289 | if (unlikely(err)) { |
| 309 | printk(KERN_ERR "NILFS: error searching super root.\n"); | 290 | printk(KERN_ERR "NILFS: error searching super root.\n"); |
| @@ -316,19 +297,56 @@ int load_nilfs(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi) | |||
| 316 | goto failed; | 297 | goto failed; |
| 317 | } | 298 | } |
| 318 | 299 | ||
| 319 | if (!valid_fs) { | 300 | if (valid_fs) |
| 320 | err = nilfs_recover_logical_segments(nilfs, sbi, &ri); | 301 | goto skip_recovery; |
| 321 | if (unlikely(err)) { | 302 | |
| 322 | nilfs_mdt_destroy(nilfs->ns_cpfile); | 303 | if (s_flags & MS_RDONLY) { |
| 323 | nilfs_mdt_destroy(nilfs->ns_sufile); | 304 | if (nilfs_test_opt(sbi, NORECOVERY)) { |
| 324 | nilfs_mdt_destroy(nilfs->ns_dat); | 305 | printk(KERN_INFO "NILFS: norecovery option specified. " |
| 325 | goto failed; | 306 | "skipping roll-forward recovery\n"); |
| 307 | goto skip_recovery; | ||
| 326 | } | 308 | } |
| 327 | if (ri.ri_need_recovery == NILFS_RECOVERY_SR_UPDATED) | 309 | if (really_read_only) { |
| 328 | sbi->s_super->s_dirt = 1; | 310 | printk(KERN_ERR "NILFS: write access " |
| 311 | "unavailable, cannot proceed.\n"); | ||
| 312 | err = -EROFS; | ||
| 313 | goto failed_unload; | ||
| 314 | } | ||
| 315 | sbi->s_super->s_flags &= ~MS_RDONLY; | ||
| 316 | } else if (nilfs_test_opt(sbi, NORECOVERY)) { | ||
| 317 | printk(KERN_ERR "NILFS: recovery cancelled because norecovery " | ||
| 318 | "option was specified for a read/write mount\n"); | ||
| 319 | err = -EINVAL; | ||
| 320 | goto failed_unload; | ||
| 329 | } | 321 | } |
| 330 | 322 | ||
| 323 | err = nilfs_recover_logical_segments(nilfs, sbi, &ri); | ||
| 324 | if (err) | ||
| 325 | goto failed_unload; | ||
| 326 | |||
| 327 | down_write(&nilfs->ns_sem); | ||
| 328 | nilfs->ns_mount_state |= NILFS_VALID_FS; | ||
| 329 | nilfs->ns_sbp[0]->s_state = cpu_to_le16(nilfs->ns_mount_state); | ||
| 330 | err = nilfs_commit_super(sbi, 1); | ||
| 331 | up_write(&nilfs->ns_sem); | ||
| 332 | |||
| 333 | if (err) { | ||
| 334 | printk(KERN_ERR "NILFS: failed to update super block. " | ||
| 335 | "recovery unfinished.\n"); | ||
| 336 | goto failed_unload; | ||
| 337 | } | ||
| 338 | printk(KERN_INFO "NILFS: recovery complete.\n"); | ||
| 339 | |||
| 340 | skip_recovery: | ||
| 331 | set_nilfs_loaded(nilfs); | 341 | set_nilfs_loaded(nilfs); |
| 342 | nilfs_clear_recovery_info(&ri); | ||
| 343 | sbi->s_super->s_flags = s_flags; | ||
| 344 | return 0; | ||
| 345 | |||
| 346 | failed_unload: | ||
| 347 | nilfs_mdt_destroy(nilfs->ns_cpfile); | ||
| 348 | nilfs_mdt_destroy(nilfs->ns_sufile); | ||
| 349 | nilfs_mdt_destroy(nilfs->ns_dat); | ||
| 332 | 350 | ||
| 333 | failed: | 351 | failed: |
| 334 | nilfs_clear_recovery_info(&ri); | 352 | nilfs_clear_recovery_info(&ri); |
| @@ -632,30 +650,23 @@ int nilfs_count_free_blocks(struct the_nilfs *nilfs, sector_t *nblocks) | |||
| 632 | { | 650 | { |
| 633 | struct inode *dat = nilfs_dat_inode(nilfs); | 651 | struct inode *dat = nilfs_dat_inode(nilfs); |
| 634 | unsigned long ncleansegs; | 652 | unsigned long ncleansegs; |
| 635 | int err; | ||
| 636 | 653 | ||
| 637 | down_read(&NILFS_MDT(dat)->mi_sem); /* XXX */ | 654 | down_read(&NILFS_MDT(dat)->mi_sem); /* XXX */ |
| 638 | err = nilfs_sufile_get_ncleansegs(nilfs->ns_sufile, &ncleansegs); | 655 | ncleansegs = nilfs_sufile_get_ncleansegs(nilfs->ns_sufile); |
| 639 | up_read(&NILFS_MDT(dat)->mi_sem); /* XXX */ | 656 | up_read(&NILFS_MDT(dat)->mi_sem); /* XXX */ |
| 640 | if (likely(!err)) | 657 | *nblocks = (sector_t)ncleansegs * nilfs->ns_blocks_per_segment; |
| 641 | *nblocks = (sector_t)ncleansegs * nilfs->ns_blocks_per_segment; | 658 | return 0; |
| 642 | return err; | ||
| 643 | } | 659 | } |
| 644 | 660 | ||
| 645 | int nilfs_near_disk_full(struct the_nilfs *nilfs) | 661 | int nilfs_near_disk_full(struct the_nilfs *nilfs) |
| 646 | { | 662 | { |
| 647 | struct inode *sufile = nilfs->ns_sufile; | ||
| 648 | unsigned long ncleansegs, nincsegs; | 663 | unsigned long ncleansegs, nincsegs; |
| 649 | int ret; | ||
| 650 | 664 | ||
| 651 | ret = nilfs_sufile_get_ncleansegs(sufile, &ncleansegs); | 665 | ncleansegs = nilfs_sufile_get_ncleansegs(nilfs->ns_sufile); |
| 652 | if (likely(!ret)) { | 666 | nincsegs = atomic_read(&nilfs->ns_ndirtyblks) / |
| 653 | nincsegs = atomic_read(&nilfs->ns_ndirtyblks) / | 667 | nilfs->ns_blocks_per_segment + 1; |
| 654 | nilfs->ns_blocks_per_segment + 1; | 668 | |
| 655 | if (ncleansegs <= nilfs->ns_nrsvsegs + nincsegs) | 669 | return ncleansegs <= nilfs->ns_nrsvsegs + nincsegs; |
| 656 | ret++; | ||
| 657 | } | ||
| 658 | return ret; | ||
| 659 | } | 670 | } |
| 660 | 671 | ||
| 661 | /** | 672 | /** |
diff --git a/fs/nilfs2/the_nilfs.h b/fs/nilfs2/the_nilfs.h index 20abd55881e0..589786e33464 100644 --- a/fs/nilfs2/the_nilfs.h +++ b/fs/nilfs2/the_nilfs.h | |||
| @@ -258,6 +258,16 @@ static inline void nilfs_put_sbinfo(struct nilfs_sb_info *sbi) | |||
| 258 | kfree(sbi); | 258 | kfree(sbi); |
| 259 | } | 259 | } |
| 260 | 260 | ||
| 261 | static inline int nilfs_valid_fs(struct the_nilfs *nilfs) | ||
| 262 | { | ||
| 263 | unsigned valid_fs; | ||
| 264 | |||
| 265 | down_read(&nilfs->ns_sem); | ||
| 266 | valid_fs = (nilfs->ns_mount_state & NILFS_VALID_FS); | ||
| 267 | up_read(&nilfs->ns_sem); | ||
| 268 | return valid_fs; | ||
| 269 | } | ||
| 270 | |||
| 261 | static inline void | 271 | static inline void |
| 262 | nilfs_get_segment_range(struct the_nilfs *nilfs, __u64 segnum, | 272 | nilfs_get_segment_range(struct the_nilfs *nilfs, __u64 segnum, |
| 263 | sector_t *seg_start, sector_t *seg_end) | 273 | sector_t *seg_start, sector_t *seg_end) |
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index dcd2040d330c..5ef5f365a5c8 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c | |||
| @@ -69,36 +69,30 @@ static int zero; | |||
| 69 | 69 | ||
| 70 | ctl_table inotify_table[] = { | 70 | ctl_table inotify_table[] = { |
| 71 | { | 71 | { |
| 72 | .ctl_name = INOTIFY_MAX_USER_INSTANCES, | ||
| 73 | .procname = "max_user_instances", | 72 | .procname = "max_user_instances", |
| 74 | .data = &inotify_max_user_instances, | 73 | .data = &inotify_max_user_instances, |
| 75 | .maxlen = sizeof(int), | 74 | .maxlen = sizeof(int), |
| 76 | .mode = 0644, | 75 | .mode = 0644, |
| 77 | .proc_handler = &proc_dointvec_minmax, | 76 | .proc_handler = proc_dointvec_minmax, |
| 78 | .strategy = &sysctl_intvec, | ||
| 79 | .extra1 = &zero, | 77 | .extra1 = &zero, |
| 80 | }, | 78 | }, |
| 81 | { | 79 | { |
| 82 | .ctl_name = INOTIFY_MAX_USER_WATCHES, | ||
| 83 | .procname = "max_user_watches", | 80 | .procname = "max_user_watches", |
| 84 | .data = &inotify_max_user_watches, | 81 | .data = &inotify_max_user_watches, |
| 85 | .maxlen = sizeof(int), | 82 | .maxlen = sizeof(int), |
| 86 | .mode = 0644, | 83 | .mode = 0644, |
| 87 | .proc_handler = &proc_dointvec_minmax, | 84 | .proc_handler = proc_dointvec_minmax, |
| 88 | .strategy = &sysctl_intvec, | ||
| 89 | .extra1 = &zero, | 85 | .extra1 = &zero, |
| 90 | }, | 86 | }, |
| 91 | { | 87 | { |
| 92 | .ctl_name = INOTIFY_MAX_QUEUED_EVENTS, | ||
| 93 | .procname = "max_queued_events", | 88 | .procname = "max_queued_events", |
| 94 | .data = &inotify_max_queued_events, | 89 | .data = &inotify_max_queued_events, |
| 95 | .maxlen = sizeof(int), | 90 | .maxlen = sizeof(int), |
| 96 | .mode = 0644, | 91 | .mode = 0644, |
| 97 | .proc_handler = &proc_dointvec_minmax, | 92 | .proc_handler = proc_dointvec_minmax, |
| 98 | .strategy = &sysctl_intvec, | ||
| 99 | .extra1 = &zero | 93 | .extra1 = &zero |
| 100 | }, | 94 | }, |
| 101 | { .ctl_name = 0 } | 95 | { } |
| 102 | }; | 96 | }; |
| 103 | #endif /* CONFIG_SYSCTL */ | 97 | #endif /* CONFIG_SYSCTL */ |
| 104 | 98 | ||
| @@ -747,10 +741,6 @@ SYSCALL_DEFINE3(inotify_add_watch, int, fd, const char __user *, pathname, | |||
| 747 | 741 | ||
| 748 | /* create/update an inode mark */ | 742 | /* create/update an inode mark */ |
| 749 | ret = inotify_update_watch(group, inode, mask); | 743 | ret = inotify_update_watch(group, inode, mask); |
| 750 | if (unlikely(ret)) | ||
| 751 | goto path_put_and_out; | ||
| 752 | |||
| 753 | path_put_and_out: | ||
| 754 | path_put(&path); | 744 | path_put(&path); |
| 755 | fput_and_out: | 745 | fput_and_out: |
| 756 | fput_light(filp, fput_needed); | 746 | fput_light(filp, fput_needed); |
diff --git a/fs/ntfs/compress.c b/fs/ntfs/compress.c index 9669541d0119..08f7530e9341 100644 --- a/fs/ntfs/compress.c +++ b/fs/ntfs/compress.c | |||
| @@ -927,7 +927,7 @@ lock_retry_remap: | |||
| 927 | return 0; | 927 | return 0; |
| 928 | 928 | ||
| 929 | ntfs_debug("Failed. Returning error code %s.", err == -EOVERFLOW ? | 929 | ntfs_debug("Failed. Returning error code %s.", err == -EOVERFLOW ? |
| 930 | "EOVERFLOW" : (!err ? "EIO" : "unkown error")); | 930 | "EOVERFLOW" : (!err ? "EIO" : "unknown error")); |
| 931 | return err < 0 ? err : -EIO; | 931 | return err < 0 ? err : -EIO; |
| 932 | 932 | ||
| 933 | read_err: | 933 | read_err: |
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 663c0e341f8b..43179ddd336f 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c | |||
| @@ -399,7 +399,7 @@ static inline void ntfs_fault_in_pages_readable_iovec(const struct iovec *iov, | |||
| 399 | * @cached_page: allocated but as yet unused page | 399 | * @cached_page: allocated but as yet unused page |
| 400 | * @lru_pvec: lru-buffering pagevec of caller | 400 | * @lru_pvec: lru-buffering pagevec of caller |
| 401 | * | 401 | * |
| 402 | * Obtain @nr_pages locked page cache pages from the mapping @maping and | 402 | * Obtain @nr_pages locked page cache pages from the mapping @mapping and |
| 403 | * starting at index @index. | 403 | * starting at index @index. |
| 404 | * | 404 | * |
| 405 | * If a page is newly created, increment its refcount and add it to the | 405 | * If a page is newly created, increment its refcount and add it to the |
| @@ -1281,7 +1281,7 @@ rl_not_mapped_enoent: | |||
| 1281 | 1281 | ||
| 1282 | /* | 1282 | /* |
| 1283 | * Copy as much as we can into the pages and return the number of bytes which | 1283 | * Copy as much as we can into the pages and return the number of bytes which |
| 1284 | * were sucessfully copied. If a fault is encountered then clear the pages | 1284 | * were successfully copied. If a fault is encountered then clear the pages |
| 1285 | * out to (ofs + bytes) and return the number of bytes which were copied. | 1285 | * out to (ofs + bytes) and return the number of bytes which were copied. |
| 1286 | */ | 1286 | */ |
| 1287 | static inline size_t ntfs_copy_from_user(struct page **pages, | 1287 | static inline size_t ntfs_copy_from_user(struct page **pages, |
diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c index 89b02985c054..4dadcdf3d451 100644 --- a/fs/ntfs/logfile.c +++ b/fs/ntfs/logfile.c | |||
| @@ -338,7 +338,7 @@ err_out: | |||
| 338 | * copy of the complete multi sector transfer deprotected page. On failure, | 338 | * copy of the complete multi sector transfer deprotected page. On failure, |
| 339 | * *@wrp is undefined. | 339 | * *@wrp is undefined. |
| 340 | * | 340 | * |
| 341 | * Simillarly, if @lsn is not NULL, on succes *@lsn will be set to the current | 341 | * Simillarly, if @lsn is not NULL, on success *@lsn will be set to the current |
| 342 | * logfile lsn according to this restart page. On failure, *@lsn is undefined. | 342 | * logfile lsn according to this restart page. On failure, *@lsn is undefined. |
| 343 | * | 343 | * |
| 344 | * The following error codes are defined: | 344 | * The following error codes are defined: |
diff --git a/fs/ntfs/sysctl.c b/fs/ntfs/sysctl.c index 9ef85e628fe1..79a89184cb5e 100644 --- a/fs/ntfs/sysctl.c +++ b/fs/ntfs/sysctl.c | |||
| @@ -36,12 +36,11 @@ | |||
| 36 | /* Definition of the ntfs sysctl. */ | 36 | /* Definition of the ntfs sysctl. */ |
| 37 | static ctl_table ntfs_sysctls[] = { | 37 | static ctl_table ntfs_sysctls[] = { |
| 38 | { | 38 | { |
| 39 | .ctl_name = CTL_UNNUMBERED, /* Binary and text IDs. */ | ||
| 40 | .procname = "ntfs-debug", | 39 | .procname = "ntfs-debug", |
| 41 | .data = &debug_msgs, /* Data pointer and size. */ | 40 | .data = &debug_msgs, /* Data pointer and size. */ |
| 42 | .maxlen = sizeof(debug_msgs), | 41 | .maxlen = sizeof(debug_msgs), |
| 43 | .mode = 0644, /* Mode, proc handler. */ | 42 | .mode = 0644, /* Mode, proc handler. */ |
| 44 | .proc_handler = &proc_dointvec | 43 | .proc_handler = proc_dointvec |
| 45 | }, | 44 | }, |
| 46 | {} | 45 | {} |
| 47 | }; | 46 | }; |
| @@ -49,7 +48,6 @@ static ctl_table ntfs_sysctls[] = { | |||
| 49 | /* Define the parent directory /proc/sys/fs. */ | 48 | /* Define the parent directory /proc/sys/fs. */ |
| 50 | static ctl_table sysctls_root[] = { | 49 | static ctl_table sysctls_root[] = { |
| 51 | { | 50 | { |
| 52 | .ctl_name = CTL_FS, | ||
| 53 | .procname = "fs", | 51 | .procname = "fs", |
| 54 | .mode = 0555, | 52 | .mode = 0555, |
| 55 | .child = ntfs_sysctls | 53 | .child = ntfs_sysctls |
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 38a42f5d59ff..7c7198a5bc90 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c | |||
| @@ -2398,7 +2398,7 @@ static int ocfs2_leftmost_rec_contains(struct ocfs2_extent_list *el, u32 cpos) | |||
| 2398 | * | 2398 | * |
| 2399 | * The array is assumed to be large enough to hold an entire path (tree depth). | 2399 | * The array is assumed to be large enough to hold an entire path (tree depth). |
| 2400 | * | 2400 | * |
| 2401 | * Upon succesful return from this function: | 2401 | * Upon successful return from this function: |
| 2402 | * | 2402 | * |
| 2403 | * - The 'right_path' array will contain a path to the leaf block | 2403 | * - The 'right_path' array will contain a path to the leaf block |
| 2404 | * whose range contains e_cpos. | 2404 | * whose range contains e_cpos. |
diff --git a/fs/ocfs2/blockcheck.c b/fs/ocfs2/blockcheck.c index a1163b8b417c..b7428c5d0d3b 100644 --- a/fs/ocfs2/blockcheck.c +++ b/fs/ocfs2/blockcheck.c | |||
| @@ -47,7 +47,7 @@ | |||
| 47 | * Calculate the bit offset in the hamming code buffer based on the bit's | 47 | * Calculate the bit offset in the hamming code buffer based on the bit's |
| 48 | * offset in the data buffer. Since the hamming code reserves all | 48 | * offset in the data buffer. Since the hamming code reserves all |
| 49 | * power-of-two bits for parity, the data bit number and the code bit | 49 | * power-of-two bits for parity, the data bit number and the code bit |
| 50 | * number are offest by all the parity bits beforehand. | 50 | * number are offset by all the parity bits beforehand. |
| 51 | * | 51 | * |
| 52 | * Recall that bit numbers in hamming code are 1-based. This function | 52 | * Recall that bit numbers in hamming code are 1-based. This function |
| 53 | * takes the 0-based data bit from the caller. | 53 | * takes the 0-based data bit from the caller. |
diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index da794bc07a6c..a3f150e52b02 100644 --- a/fs/ocfs2/cluster/netdebug.c +++ b/fs/ocfs2/cluster/netdebug.c | |||
| @@ -294,10 +294,10 @@ static int sc_seq_show(struct seq_file *seq, void *v) | |||
| 294 | if (sc->sc_sock) { | 294 | if (sc->sc_sock) { |
| 295 | inet = inet_sk(sc->sc_sock->sk); | 295 | inet = inet_sk(sc->sc_sock->sk); |
| 296 | /* the stack's structs aren't sparse endian clean */ | 296 | /* the stack's structs aren't sparse endian clean */ |
| 297 | saddr = (__force __be32)inet->saddr; | 297 | saddr = (__force __be32)inet->inet_saddr; |
| 298 | daddr = (__force __be32)inet->daddr; | 298 | daddr = (__force __be32)inet->inet_daddr; |
| 299 | sport = (__force __be16)inet->sport; | 299 | sport = (__force __be16)inet->inet_sport; |
| 300 | dport = (__force __be16)inet->dport; | 300 | dport = (__force __be16)inet->inet_dport; |
| 301 | } | 301 | } |
| 302 | 302 | ||
| 303 | /* XXX sigh, inet-> doesn't have sparse annotation so any | 303 | /* XXX sigh, inet-> doesn't have sparse annotation so any |
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c index 83bcaf266b35..03ccf9a7b1f4 100644 --- a/fs/ocfs2/dlm/dlmmaster.c +++ b/fs/ocfs2/dlm/dlmmaster.c | |||
| @@ -2586,7 +2586,7 @@ fail: | |||
| 2586 | * is complete everywhere. if the target dies while this is | 2586 | * is complete everywhere. if the target dies while this is |
| 2587 | * going on, some nodes could potentially see the target as the | 2587 | * going on, some nodes could potentially see the target as the |
| 2588 | * master, so it is important that my recovery finds the migration | 2588 | * master, so it is important that my recovery finds the migration |
| 2589 | * mle and sets the master to UNKNONWN. */ | 2589 | * mle and sets the master to UNKNOWN. */ |
| 2590 | 2590 | ||
| 2591 | 2591 | ||
| 2592 | /* wait for new node to assert master */ | 2592 | /* wait for new node to assert master */ |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 0d38d67194cb..c5e4a49e3a12 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
| @@ -1855,7 +1855,7 @@ int ocfs2_file_lock(struct file *file, int ex, int trylock) | |||
| 1855 | * outstanding lock request, so a cancel convert is | 1855 | * outstanding lock request, so a cancel convert is |
| 1856 | * required. We intentionally overwrite 'ret' - if the | 1856 | * required. We intentionally overwrite 'ret' - if the |
| 1857 | * cancel fails and the lock was granted, it's easier | 1857 | * cancel fails and the lock was granted, it's easier |
| 1858 | * to just bubble sucess back up to the user. | 1858 | * to just bubble success back up to the user. |
| 1859 | */ | 1859 | */ |
| 1860 | ret = ocfs2_flock_handle_signal(lockres, level); | 1860 | ret = ocfs2_flock_handle_signal(lockres, level); |
| 1861 | } else if (!ret && (level > lockres->l_level)) { | 1861 | } else if (!ret && (level > lockres->l_level)) { |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index de059f490586..3d30a1c974a8 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
| @@ -2006,7 +2006,7 @@ out_dio: | |||
| 2006 | /* buffered aio wouldn't have proper lock coverage today */ | 2006 | /* buffered aio wouldn't have proper lock coverage today */ |
| 2007 | BUG_ON(ret == -EIOCBQUEUED && !(file->f_flags & O_DIRECT)); | 2007 | BUG_ON(ret == -EIOCBQUEUED && !(file->f_flags & O_DIRECT)); |
| 2008 | 2008 | ||
| 2009 | if ((file->f_flags & O_SYNC && !direct_io) || IS_SYNC(inode)) { | 2009 | if ((file->f_flags & O_DSYNC && !direct_io) || IS_SYNC(inode)) { |
| 2010 | ret = filemap_fdatawrite_range(file->f_mapping, pos, | 2010 | ret = filemap_fdatawrite_range(file->f_mapping, pos, |
| 2011 | pos + count - 1); | 2011 | pos + count - 1); |
| 2012 | if (ret < 0) | 2012 | if (ret < 0) |
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index 54c16b66327e..bf34c491ae96 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c | |||
| @@ -659,7 +659,7 @@ static int __ocfs2_journal_access(handle_t *handle, | |||
| 659 | 659 | ||
| 660 | default: | 660 | default: |
| 661 | status = -EINVAL; | 661 | status = -EINVAL; |
| 662 | mlog(ML_ERROR, "Uknown access type!\n"); | 662 | mlog(ML_ERROR, "Unknown access type!\n"); |
| 663 | } | 663 | } |
| 664 | if (!status && ocfs2_meta_ecc(osb) && triggers) | 664 | if (!status && ocfs2_meta_ecc(osb) && triggers) |
| 665 | jbd2_journal_set_triggers(bh, &triggers->ot_triggers); | 665 | jbd2_journal_set_triggers(bh, &triggers->ot_triggers); |
diff --git a/fs/ocfs2/quota.h b/fs/ocfs2/quota.h index e5df9d170b0c..123bc520a2c0 100644 --- a/fs/ocfs2/quota.h +++ b/fs/ocfs2/quota.h | |||
| @@ -17,10 +17,6 @@ | |||
| 17 | 17 | ||
| 18 | #include "ocfs2.h" | 18 | #include "ocfs2.h" |
| 19 | 19 | ||
| 20 | /* Common stuff */ | ||
| 21 | /* id number of quota format */ | ||
| 22 | #define QFMT_OCFS2 3 | ||
| 23 | |||
| 24 | /* | 20 | /* |
| 25 | * In-memory structures | 21 | * In-memory structures |
| 26 | */ | 22 | */ |
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c index 1a2c50a759fa..21f9e71223ca 100644 --- a/fs/ocfs2/quota_local.c +++ b/fs/ocfs2/quota_local.c | |||
| @@ -1325,7 +1325,7 @@ out: | |||
| 1325 | return status; | 1325 | return status; |
| 1326 | } | 1326 | } |
| 1327 | 1327 | ||
| 1328 | static struct quota_format_ops ocfs2_format_ops = { | 1328 | static const struct quota_format_ops ocfs2_format_ops = { |
| 1329 | .check_quota_file = ocfs2_local_check_quota_file, | 1329 | .check_quota_file = ocfs2_local_check_quota_file, |
| 1330 | .read_file_info = ocfs2_local_read_info, | 1330 | .read_file_info = ocfs2_local_read_info, |
| 1331 | .write_file_info = ocfs2_global_write_info, | 1331 | .write_file_info = ocfs2_global_write_info, |
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index 3a0df7a1b810..30967e3f5e43 100644 --- a/fs/ocfs2/refcounttree.c +++ b/fs/ocfs2/refcounttree.c | |||
| @@ -2431,7 +2431,7 @@ out: | |||
| 2431 | * we gonna touch and whether we need to create new blocks. | 2431 | * we gonna touch and whether we need to create new blocks. |
| 2432 | * | 2432 | * |
| 2433 | * Normally the refcount blocks store these refcount should be | 2433 | * Normally the refcount blocks store these refcount should be |
| 2434 | * continguous also, so that we can get the number easily. | 2434 | * contiguous also, so that we can get the number easily. |
| 2435 | * As for meta_ac, we will at most add split 2 refcount record and | 2435 | * As for meta_ac, we will at most add split 2 refcount record and |
| 2436 | * 2 more refcount block, so just check it in a rough way. | 2436 | * 2 more refcount block, so just check it in a rough way. |
| 2437 | * | 2437 | * |
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 3f2f1c45b7b6..f3df0baa9a48 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c | |||
| @@ -620,51 +620,46 @@ error: | |||
| 620 | 620 | ||
| 621 | static ctl_table ocfs2_nm_table[] = { | 621 | static ctl_table ocfs2_nm_table[] = { |
| 622 | { | 622 | { |
| 623 | .ctl_name = 1, | ||
| 624 | .procname = "hb_ctl_path", | 623 | .procname = "hb_ctl_path", |
| 625 | .data = ocfs2_hb_ctl_path, | 624 | .data = ocfs2_hb_ctl_path, |
| 626 | .maxlen = OCFS2_MAX_HB_CTL_PATH, | 625 | .maxlen = OCFS2_MAX_HB_CTL_PATH, |
| 627 | .mode = 0644, | 626 | .mode = 0644, |
| 628 | .proc_handler = &proc_dostring, | 627 | .proc_handler = proc_dostring, |
| 629 | .strategy = &sysctl_string, | ||
| 630 | }, | 628 | }, |
| 631 | { .ctl_name = 0 } | 629 | { } |
| 632 | }; | 630 | }; |
| 633 | 631 | ||
| 634 | static ctl_table ocfs2_mod_table[] = { | 632 | static ctl_table ocfs2_mod_table[] = { |
| 635 | { | 633 | { |
| 636 | .ctl_name = FS_OCFS2_NM, | ||
| 637 | .procname = "nm", | 634 | .procname = "nm", |
| 638 | .data = NULL, | 635 | .data = NULL, |
| 639 | .maxlen = 0, | 636 | .maxlen = 0, |
| 640 | .mode = 0555, | 637 | .mode = 0555, |
| 641 | .child = ocfs2_nm_table | 638 | .child = ocfs2_nm_table |
| 642 | }, | 639 | }, |
| 643 | { .ctl_name = 0} | 640 | { } |
| 644 | }; | 641 | }; |
| 645 | 642 | ||
| 646 | static ctl_table ocfs2_kern_table[] = { | 643 | static ctl_table ocfs2_kern_table[] = { |
| 647 | { | 644 | { |
| 648 | .ctl_name = FS_OCFS2, | ||
| 649 | .procname = "ocfs2", | 645 | .procname = "ocfs2", |
| 650 | .data = NULL, | 646 | .data = NULL, |
| 651 | .maxlen = 0, | 647 | .maxlen = 0, |
| 652 | .mode = 0555, | 648 | .mode = 0555, |
| 653 | .child = ocfs2_mod_table | 649 | .child = ocfs2_mod_table |
| 654 | }, | 650 | }, |
| 655 | { .ctl_name = 0} | 651 | { } |
| 656 | }; | 652 | }; |
| 657 | 653 | ||
| 658 | static ctl_table ocfs2_root_table[] = { | 654 | static ctl_table ocfs2_root_table[] = { |
| 659 | { | 655 | { |
| 660 | .ctl_name = CTL_FS, | ||
| 661 | .procname = "fs", | 656 | .procname = "fs", |
| 662 | .data = NULL, | 657 | .data = NULL, |
| 663 | .maxlen = 0, | 658 | .maxlen = 0, |
| 664 | .mode = 0555, | 659 | .mode = 0555, |
| 665 | .child = ocfs2_kern_table | 660 | .child = ocfs2_kern_table |
| 666 | }, | 661 | }, |
| 667 | { .ctl_name = 0 } | 662 | { } |
| 668 | }; | 663 | }; |
| 669 | 664 | ||
| 670 | static struct ctl_table_header *ocfs2_table_header = NULL; | 665 | static struct ctl_table_header *ocfs2_table_header = NULL; |
diff --git a/fs/omfs/bitmap.c b/fs/omfs/bitmap.c index e1c0ec0ae989..082234581d05 100644 --- a/fs/omfs/bitmap.c +++ b/fs/omfs/bitmap.c | |||
| @@ -85,7 +85,7 @@ out: | |||
| 85 | } | 85 | } |
| 86 | 86 | ||
| 87 | /* | 87 | /* |
| 88 | * Tries to allocate exactly one block. Returns true if sucessful. | 88 | * Tries to allocate exactly one block. Returns true if successful. |
| 89 | */ | 89 | */ |
| 90 | int omfs_allocate_block(struct super_block *sb, u64 block) | 90 | int omfs_allocate_block(struct super_block *sb, u64 block) |
| 91 | { | 91 | { |
| @@ -587,6 +587,9 @@ SYSCALL_DEFINE1(chroot, const char __user *, filename) | |||
| 587 | error = -EPERM; | 587 | error = -EPERM; |
| 588 | if (!capable(CAP_SYS_CHROOT)) | 588 | if (!capable(CAP_SYS_CHROOT)) |
| 589 | goto dput_and_out; | 589 | goto dput_and_out; |
| 590 | error = security_path_chroot(&path); | ||
| 591 | if (error) | ||
| 592 | goto dput_and_out; | ||
| 590 | 593 | ||
| 591 | set_fs_root(current->fs, &path); | 594 | set_fs_root(current->fs, &path); |
| 592 | error = 0; | 595 | error = 0; |
| @@ -617,11 +620,15 @@ SYSCALL_DEFINE2(fchmod, unsigned int, fd, mode_t, mode) | |||
| 617 | if (err) | 620 | if (err) |
| 618 | goto out_putf; | 621 | goto out_putf; |
| 619 | mutex_lock(&inode->i_mutex); | 622 | mutex_lock(&inode->i_mutex); |
| 623 | err = security_path_chmod(dentry, file->f_vfsmnt, mode); | ||
| 624 | if (err) | ||
| 625 | goto out_unlock; | ||
| 620 | if (mode == (mode_t) -1) | 626 | if (mode == (mode_t) -1) |
| 621 | mode = inode->i_mode; | 627 | mode = inode->i_mode; |
| 622 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); | 628 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); |
| 623 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 629 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; |
| 624 | err = notify_change(dentry, &newattrs); | 630 | err = notify_change(dentry, &newattrs); |
| 631 | out_unlock: | ||
| 625 | mutex_unlock(&inode->i_mutex); | 632 | mutex_unlock(&inode->i_mutex); |
| 626 | mnt_drop_write(file->f_path.mnt); | 633 | mnt_drop_write(file->f_path.mnt); |
| 627 | out_putf: | 634 | out_putf: |
| @@ -646,11 +653,15 @@ SYSCALL_DEFINE3(fchmodat, int, dfd, const char __user *, filename, mode_t, mode) | |||
| 646 | if (error) | 653 | if (error) |
| 647 | goto dput_and_out; | 654 | goto dput_and_out; |
| 648 | mutex_lock(&inode->i_mutex); | 655 | mutex_lock(&inode->i_mutex); |
| 656 | error = security_path_chmod(path.dentry, path.mnt, mode); | ||
| 657 | if (error) | ||
| 658 | goto out_unlock; | ||
| 649 | if (mode == (mode_t) -1) | 659 | if (mode == (mode_t) -1) |
| 650 | mode = inode->i_mode; | 660 | mode = inode->i_mode; |
| 651 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); | 661 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); |
| 652 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 662 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; |
| 653 | error = notify_change(path.dentry, &newattrs); | 663 | error = notify_change(path.dentry, &newattrs); |
| 664 | out_unlock: | ||
| 654 | mutex_unlock(&inode->i_mutex); | 665 | mutex_unlock(&inode->i_mutex); |
| 655 | mnt_drop_write(path.mnt); | 666 | mnt_drop_write(path.mnt); |
| 656 | dput_and_out: | 667 | dput_and_out: |
| @@ -664,9 +675,9 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, mode_t, mode) | |||
| 664 | return sys_fchmodat(AT_FDCWD, filename, mode); | 675 | return sys_fchmodat(AT_FDCWD, filename, mode); |
| 665 | } | 676 | } |
| 666 | 677 | ||
| 667 | static int chown_common(struct dentry * dentry, uid_t user, gid_t group) | 678 | static int chown_common(struct path *path, uid_t user, gid_t group) |
| 668 | { | 679 | { |
| 669 | struct inode *inode = dentry->d_inode; | 680 | struct inode *inode = path->dentry->d_inode; |
| 670 | int error; | 681 | int error; |
| 671 | struct iattr newattrs; | 682 | struct iattr newattrs; |
| 672 | 683 | ||
| @@ -683,7 +694,9 @@ static int chown_common(struct dentry * dentry, uid_t user, gid_t group) | |||
| 683 | newattrs.ia_valid |= | 694 | newattrs.ia_valid |= |
| 684 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; | 695 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; |
| 685 | mutex_lock(&inode->i_mutex); | 696 | mutex_lock(&inode->i_mutex); |
| 686 | error = notify_change(dentry, &newattrs); | 697 | error = security_path_chown(path, user, group); |
| 698 | if (!error) | ||
| 699 | error = notify_change(path->dentry, &newattrs); | ||
| 687 | mutex_unlock(&inode->i_mutex); | 700 | mutex_unlock(&inode->i_mutex); |
| 688 | 701 | ||
| 689 | return error; | 702 | return error; |
| @@ -700,7 +713,7 @@ SYSCALL_DEFINE3(chown, const char __user *, filename, uid_t, user, gid_t, group) | |||
| 700 | error = mnt_want_write(path.mnt); | 713 | error = mnt_want_write(path.mnt); |
| 701 | if (error) | 714 | if (error) |
| 702 | goto out_release; | 715 | goto out_release; |
| 703 | error = chown_common(path.dentry, user, group); | 716 | error = chown_common(&path, user, group); |
| 704 | mnt_drop_write(path.mnt); | 717 | mnt_drop_write(path.mnt); |
| 705 | out_release: | 718 | out_release: |
| 706 | path_put(&path); | 719 | path_put(&path); |
| @@ -725,7 +738,7 @@ SYSCALL_DEFINE5(fchownat, int, dfd, const char __user *, filename, uid_t, user, | |||
| 725 | error = mnt_want_write(path.mnt); | 738 | error = mnt_want_write(path.mnt); |
| 726 | if (error) | 739 | if (error) |
| 727 | goto out_release; | 740 | goto out_release; |
| 728 | error = chown_common(path.dentry, user, group); | 741 | error = chown_common(&path, user, group); |
| 729 | mnt_drop_write(path.mnt); | 742 | mnt_drop_write(path.mnt); |
| 730 | out_release: | 743 | out_release: |
| 731 | path_put(&path); | 744 | path_put(&path); |
| @@ -744,7 +757,7 @@ SYSCALL_DEFINE3(lchown, const char __user *, filename, uid_t, user, gid_t, group | |||
| 744 | error = mnt_want_write(path.mnt); | 757 | error = mnt_want_write(path.mnt); |
| 745 | if (error) | 758 | if (error) |
| 746 | goto out_release; | 759 | goto out_release; |
| 747 | error = chown_common(path.dentry, user, group); | 760 | error = chown_common(&path, user, group); |
| 748 | mnt_drop_write(path.mnt); | 761 | mnt_drop_write(path.mnt); |
| 749 | out_release: | 762 | out_release: |
| 750 | path_put(&path); | 763 | path_put(&path); |
| @@ -767,7 +780,7 @@ SYSCALL_DEFINE3(fchown, unsigned int, fd, uid_t, user, gid_t, group) | |||
| 767 | goto out_fput; | 780 | goto out_fput; |
| 768 | dentry = file->f_path.dentry; | 781 | dentry = file->f_path.dentry; |
| 769 | audit_inode(NULL, dentry); | 782 | audit_inode(NULL, dentry); |
| 770 | error = chown_common(dentry, user, group); | 783 | error = chown_common(&file->f_path, user, group); |
| 771 | mnt_drop_write(file->f_path.mnt); | 784 | mnt_drop_write(file->f_path.mnt); |
| 772 | out_fput: | 785 | out_fput: |
| 773 | fput(file); | 786 | fput(file); |
diff --git a/fs/partitions/check.c b/fs/partitions/check.c index 7b685e10cbad..64bc8998ac9a 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c | |||
| @@ -226,6 +226,13 @@ ssize_t part_alignment_offset_show(struct device *dev, | |||
| 226 | return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset); | 226 | return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset); |
| 227 | } | 227 | } |
| 228 | 228 | ||
| 229 | ssize_t part_discard_alignment_show(struct device *dev, | ||
| 230 | struct device_attribute *attr, char *buf) | ||
| 231 | { | ||
| 232 | struct hd_struct *p = dev_to_part(dev); | ||
| 233 | return sprintf(buf, "%u\n", p->discard_alignment); | ||
| 234 | } | ||
| 235 | |||
| 229 | ssize_t part_stat_show(struct device *dev, | 236 | ssize_t part_stat_show(struct device *dev, |
| 230 | struct device_attribute *attr, char *buf) | 237 | struct device_attribute *attr, char *buf) |
| 231 | { | 238 | { |
| @@ -288,6 +295,8 @@ static DEVICE_ATTR(partition, S_IRUGO, part_partition_show, NULL); | |||
| 288 | static DEVICE_ATTR(start, S_IRUGO, part_start_show, NULL); | 295 | static DEVICE_ATTR(start, S_IRUGO, part_start_show, NULL); |
| 289 | static DEVICE_ATTR(size, S_IRUGO, part_size_show, NULL); | 296 | static DEVICE_ATTR(size, S_IRUGO, part_size_show, NULL); |
| 290 | static DEVICE_ATTR(alignment_offset, S_IRUGO, part_alignment_offset_show, NULL); | 297 | static DEVICE_ATTR(alignment_offset, S_IRUGO, part_alignment_offset_show, NULL); |
| 298 | static DEVICE_ATTR(discard_alignment, S_IRUGO, part_discard_alignment_show, | ||
| 299 | NULL); | ||
| 291 | static DEVICE_ATTR(stat, S_IRUGO, part_stat_show, NULL); | 300 | static DEVICE_ATTR(stat, S_IRUGO, part_stat_show, NULL); |
| 292 | static DEVICE_ATTR(inflight, S_IRUGO, part_inflight_show, NULL); | 301 | static DEVICE_ATTR(inflight, S_IRUGO, part_inflight_show, NULL); |
| 293 | #ifdef CONFIG_FAIL_MAKE_REQUEST | 302 | #ifdef CONFIG_FAIL_MAKE_REQUEST |
| @@ -300,6 +309,7 @@ static struct attribute *part_attrs[] = { | |||
| 300 | &dev_attr_start.attr, | 309 | &dev_attr_start.attr, |
| 301 | &dev_attr_size.attr, | 310 | &dev_attr_size.attr, |
| 302 | &dev_attr_alignment_offset.attr, | 311 | &dev_attr_alignment_offset.attr, |
| 312 | &dev_attr_discard_alignment.attr, | ||
| 303 | &dev_attr_stat.attr, | 313 | &dev_attr_stat.attr, |
| 304 | &dev_attr_inflight.attr, | 314 | &dev_attr_inflight.attr, |
| 305 | #ifdef CONFIG_FAIL_MAKE_REQUEST | 315 | #ifdef CONFIG_FAIL_MAKE_REQUEST |
| @@ -403,6 +413,8 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, | |||
| 403 | 413 | ||
| 404 | p->start_sect = start; | 414 | p->start_sect = start; |
| 405 | p->alignment_offset = queue_sector_alignment_offset(disk->queue, start); | 415 | p->alignment_offset = queue_sector_alignment_offset(disk->queue, start); |
| 416 | p->discard_alignment = queue_sector_discard_alignment(disk->queue, | ||
| 417 | start); | ||
| 406 | p->nr_sects = len; | 418 | p->nr_sects = len; |
| 407 | p->partno = partno; | 419 | p->partno = partno; |
| 408 | p->policy = get_disk_ro(disk); | 420 | p->policy = get_disk_ro(disk); |
diff --git a/fs/partitions/efi.c b/fs/partitions/efi.c index 038a6022152f..49cfd5f54238 100644 --- a/fs/partitions/efi.c +++ b/fs/partitions/efi.c | |||
| @@ -1,7 +1,9 @@ | |||
| 1 | /************************************************************ | 1 | /************************************************************ |
| 2 | * EFI GUID Partition Table handling | 2 | * EFI GUID Partition Table handling |
| 3 | * Per Intel EFI Specification v1.02 | 3 | * |
| 4 | * http://developer.intel.com/technology/efi/efi.htm | 4 | * http://www.uefi.org/specs/ |
| 5 | * http://www.intel.com/technology/efi/ | ||
| 6 | * | ||
| 5 | * efi.[ch] by Matt Domsch <Matt_Domsch@dell.com> | 7 | * efi.[ch] by Matt Domsch <Matt_Domsch@dell.com> |
| 6 | * Copyright 2000,2001,2002,2004 Dell Inc. | 8 | * Copyright 2000,2001,2002,2004 Dell Inc. |
| 7 | * | 9 | * |
| @@ -92,6 +94,7 @@ | |||
| 92 | * | 94 | * |
| 93 | ************************************************************/ | 95 | ************************************************************/ |
| 94 | #include <linux/crc32.h> | 96 | #include <linux/crc32.h> |
| 97 | #include <linux/math64.h> | ||
| 95 | #include "check.h" | 98 | #include "check.h" |
| 96 | #include "efi.h" | 99 | #include "efi.h" |
| 97 | 100 | ||
| @@ -141,7 +144,8 @@ last_lba(struct block_device *bdev) | |||
| 141 | { | 144 | { |
| 142 | if (!bdev || !bdev->bd_inode) | 145 | if (!bdev || !bdev->bd_inode) |
| 143 | return 0; | 146 | return 0; |
| 144 | return (bdev->bd_inode->i_size >> 9) - 1ULL; | 147 | return div_u64(bdev->bd_inode->i_size, |
| 148 | bdev_logical_block_size(bdev)) - 1ULL; | ||
| 145 | } | 149 | } |
| 146 | 150 | ||
| 147 | static inline int | 151 | static inline int |
| @@ -188,6 +192,7 @@ static size_t | |||
| 188 | read_lba(struct block_device *bdev, u64 lba, u8 * buffer, size_t count) | 192 | read_lba(struct block_device *bdev, u64 lba, u8 * buffer, size_t count) |
| 189 | { | 193 | { |
| 190 | size_t totalreadcount = 0; | 194 | size_t totalreadcount = 0; |
| 195 | sector_t n = lba * (bdev_logical_block_size(bdev) / 512); | ||
| 191 | 196 | ||
| 192 | if (!bdev || !buffer || lba > last_lba(bdev)) | 197 | if (!bdev || !buffer || lba > last_lba(bdev)) |
| 193 | return 0; | 198 | return 0; |
| @@ -195,7 +200,7 @@ read_lba(struct block_device *bdev, u64 lba, u8 * buffer, size_t count) | |||
| 195 | while (count) { | 200 | while (count) { |
| 196 | int copied = 512; | 201 | int copied = 512; |
| 197 | Sector sect; | 202 | Sector sect; |
| 198 | unsigned char *data = read_dev_sector(bdev, lba++, §); | 203 | unsigned char *data = read_dev_sector(bdev, n++, §); |
| 199 | if (!data) | 204 | if (!data) |
| 200 | break; | 205 | break; |
| 201 | if (copied > count) | 206 | if (copied > count) |
| @@ -257,15 +262,16 @@ static gpt_header * | |||
| 257 | alloc_read_gpt_header(struct block_device *bdev, u64 lba) | 262 | alloc_read_gpt_header(struct block_device *bdev, u64 lba) |
| 258 | { | 263 | { |
| 259 | gpt_header *gpt; | 264 | gpt_header *gpt; |
| 265 | unsigned ssz = bdev_logical_block_size(bdev); | ||
| 266 | |||
| 260 | if (!bdev) | 267 | if (!bdev) |
| 261 | return NULL; | 268 | return NULL; |
| 262 | 269 | ||
| 263 | gpt = kzalloc(sizeof (gpt_header), GFP_KERNEL); | 270 | gpt = kzalloc(ssz, GFP_KERNEL); |
| 264 | if (!gpt) | 271 | if (!gpt) |
| 265 | return NULL; | 272 | return NULL; |
| 266 | 273 | ||
| 267 | if (read_lba(bdev, lba, (u8 *) gpt, | 274 | if (read_lba(bdev, lba, (u8 *) gpt, ssz) < ssz) { |
| 268 | sizeof (gpt_header)) < sizeof (gpt_header)) { | ||
| 269 | kfree(gpt); | 275 | kfree(gpt); |
| 270 | gpt=NULL; | 276 | gpt=NULL; |
| 271 | return NULL; | 277 | return NULL; |
| @@ -601,6 +607,7 @@ efi_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
| 601 | gpt_header *gpt = NULL; | 607 | gpt_header *gpt = NULL; |
| 602 | gpt_entry *ptes = NULL; | 608 | gpt_entry *ptes = NULL; |
| 603 | u32 i; | 609 | u32 i; |
| 610 | unsigned ssz = bdev_logical_block_size(bdev) / 512; | ||
| 604 | 611 | ||
| 605 | if (!find_valid_gpt(bdev, &gpt, &ptes) || !gpt || !ptes) { | 612 | if (!find_valid_gpt(bdev, &gpt, &ptes) || !gpt || !ptes) { |
| 606 | kfree(gpt); | 613 | kfree(gpt); |
| @@ -611,13 +618,14 @@ efi_partition(struct parsed_partitions *state, struct block_device *bdev) | |||
| 611 | pr_debug("GUID Partition Table is valid! Yea!\n"); | 618 | pr_debug("GUID Partition Table is valid! Yea!\n"); |
| 612 | 619 | ||
| 613 | for (i = 0; i < le32_to_cpu(gpt->num_partition_entries) && i < state->limit-1; i++) { | 620 | for (i = 0; i < le32_to_cpu(gpt->num_partition_entries) && i < state->limit-1; i++) { |
| 621 | u64 start = le64_to_cpu(ptes[i].starting_lba); | ||
| 622 | u64 size = le64_to_cpu(ptes[i].ending_lba) - | ||
| 623 | le64_to_cpu(ptes[i].starting_lba) + 1ULL; | ||
| 624 | |||
| 614 | if (!is_pte_valid(&ptes[i], last_lba(bdev))) | 625 | if (!is_pte_valid(&ptes[i], last_lba(bdev))) |
| 615 | continue; | 626 | continue; |
| 616 | 627 | ||
| 617 | put_partition(state, i+1, le64_to_cpu(ptes[i].starting_lba), | 628 | put_partition(state, i+1, start * ssz, size * ssz); |
| 618 | (le64_to_cpu(ptes[i].ending_lba) - | ||
| 619 | le64_to_cpu(ptes[i].starting_lba) + | ||
| 620 | 1ULL)); | ||
| 621 | 629 | ||
| 622 | /* If this is a RAID volume, tell md */ | 630 | /* If this is a RAID volume, tell md */ |
| 623 | if (!efi_guidcmp(ptes[i].partition_type_guid, | 631 | if (!efi_guidcmp(ptes[i].partition_type_guid, |
diff --git a/fs/partitions/efi.h b/fs/partitions/efi.h index 2cc89d0475bf..6998b589abf9 100644 --- a/fs/partitions/efi.h +++ b/fs/partitions/efi.h | |||
| @@ -37,7 +37,6 @@ | |||
| 37 | #define EFI_PMBR_OSTYPE_EFI 0xEF | 37 | #define EFI_PMBR_OSTYPE_EFI 0xEF |
| 38 | #define EFI_PMBR_OSTYPE_EFI_GPT 0xEE | 38 | #define EFI_PMBR_OSTYPE_EFI_GPT 0xEE |
| 39 | 39 | ||
| 40 | #define GPT_BLOCK_SIZE 512 | ||
| 41 | #define GPT_HEADER_SIGNATURE 0x5452415020494645ULL | 40 | #define GPT_HEADER_SIGNATURE 0x5452415020494645ULL |
| 42 | #define GPT_HEADER_REVISION_V1 0x00010000 | 41 | #define GPT_HEADER_REVISION_V1 0x00010000 |
| 43 | #define GPT_PRIMARY_PARTITION_TABLE_LBA 1 | 42 | #define GPT_PRIMARY_PARTITION_TABLE_LBA 1 |
| @@ -79,7 +78,12 @@ typedef struct _gpt_header { | |||
| 79 | __le32 num_partition_entries; | 78 | __le32 num_partition_entries; |
| 80 | __le32 sizeof_partition_entry; | 79 | __le32 sizeof_partition_entry; |
| 81 | __le32 partition_entry_array_crc32; | 80 | __le32 partition_entry_array_crc32; |
| 82 | u8 reserved2[GPT_BLOCK_SIZE - 92]; | 81 | |
| 82 | /* The rest of the logical block is reserved by UEFI and must be zero. | ||
| 83 | * EFI standard handles this by: | ||
| 84 | * | ||
| 85 | * uint8_t reserved2[ BlockSize - 92 ]; | ||
| 86 | */ | ||
| 83 | } __attribute__ ((packed)) gpt_header; | 87 | } __attribute__ ((packed)) gpt_header; |
| 84 | 88 | ||
| 85 | typedef struct _gpt_entry_attributes { | 89 | typedef struct _gpt_entry_attributes { |
diff --git a/fs/proc/array.c b/fs/proc/array.c index 822c2d506518..4badde179b18 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c | |||
| @@ -410,6 +410,16 @@ static void task_show_stack_usage(struct seq_file *m, struct task_struct *task) | |||
| 410 | } | 410 | } |
| 411 | #endif /* CONFIG_MMU */ | 411 | #endif /* CONFIG_MMU */ |
| 412 | 412 | ||
| 413 | static void task_cpus_allowed(struct seq_file *m, struct task_struct *task) | ||
| 414 | { | ||
| 415 | seq_printf(m, "Cpus_allowed:\t"); | ||
| 416 | seq_cpumask(m, &task->cpus_allowed); | ||
| 417 | seq_printf(m, "\n"); | ||
| 418 | seq_printf(m, "Cpus_allowed_list:\t"); | ||
| 419 | seq_cpumask_list(m, &task->cpus_allowed); | ||
| 420 | seq_printf(m, "\n"); | ||
| 421 | } | ||
| 422 | |||
| 413 | int proc_pid_status(struct seq_file *m, struct pid_namespace *ns, | 423 | int proc_pid_status(struct seq_file *m, struct pid_namespace *ns, |
| 414 | struct pid *pid, struct task_struct *task) | 424 | struct pid *pid, struct task_struct *task) |
| 415 | { | 425 | { |
| @@ -424,6 +434,7 @@ int proc_pid_status(struct seq_file *m, struct pid_namespace *ns, | |||
| 424 | } | 434 | } |
| 425 | task_sig(m, task); | 435 | task_sig(m, task); |
| 426 | task_cap(m, task); | 436 | task_cap(m, task); |
| 437 | task_cpus_allowed(m, task); | ||
| 427 | cpuset_task_status_allowed(m, task); | 438 | cpuset_task_status_allowed(m, task); |
| 428 | #if defined(CONFIG_S390) | 439 | #if defined(CONFIG_S390) |
| 429 | task_show_regs(m, task); | 440 | task_show_regs(m, task); |
| @@ -495,20 +506,17 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns, | |||
| 495 | 506 | ||
| 496 | /* add up live thread stats at the group level */ | 507 | /* add up live thread stats at the group level */ |
| 497 | if (whole) { | 508 | if (whole) { |
| 498 | struct task_cputime cputime; | ||
| 499 | struct task_struct *t = task; | 509 | struct task_struct *t = task; |
| 500 | do { | 510 | do { |
| 501 | min_flt += t->min_flt; | 511 | min_flt += t->min_flt; |
| 502 | maj_flt += t->maj_flt; | 512 | maj_flt += t->maj_flt; |
| 503 | gtime = cputime_add(gtime, task_gtime(t)); | 513 | gtime = cputime_add(gtime, t->gtime); |
| 504 | t = next_thread(t); | 514 | t = next_thread(t); |
| 505 | } while (t != task); | 515 | } while (t != task); |
| 506 | 516 | ||
| 507 | min_flt += sig->min_flt; | 517 | min_flt += sig->min_flt; |
| 508 | maj_flt += sig->maj_flt; | 518 | maj_flt += sig->maj_flt; |
| 509 | thread_group_cputime(task, &cputime); | 519 | thread_group_times(task, &utime, &stime); |
| 510 | utime = cputime.utime; | ||
| 511 | stime = cputime.stime; | ||
| 512 | gtime = cputime_add(gtime, sig->gtime); | 520 | gtime = cputime_add(gtime, sig->gtime); |
| 513 | } | 521 | } |
| 514 | 522 | ||
| @@ -524,9 +532,8 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns, | |||
| 524 | if (!whole) { | 532 | if (!whole) { |
| 525 | min_flt = task->min_flt; | 533 | min_flt = task->min_flt; |
| 526 | maj_flt = task->maj_flt; | 534 | maj_flt = task->maj_flt; |
| 527 | utime = task_utime(task); | 535 | task_times(task, &utime, &stime); |
| 528 | stime = task_stime(task); | 536 | gtime = task->gtime; |
| 529 | gtime = task_gtime(task); | ||
| 530 | } | 537 | } |
| 531 | 538 | ||
| 532 | /* scale priority and nice values from timeslices to -20..20 */ | 539 | /* scale priority and nice values from timeslices to -20..20 */ |
diff --git a/fs/proc/base.c b/fs/proc/base.c index af643b5aefe8..4df4a464a919 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c | |||
| @@ -1265,6 +1265,72 @@ static const struct file_operations proc_pid_sched_operations = { | |||
| 1265 | 1265 | ||
| 1266 | #endif | 1266 | #endif |
| 1267 | 1267 | ||
| 1268 | static ssize_t comm_write(struct file *file, const char __user *buf, | ||
| 1269 | size_t count, loff_t *offset) | ||
| 1270 | { | ||
| 1271 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 1272 | struct task_struct *p; | ||
| 1273 | char buffer[TASK_COMM_LEN]; | ||
| 1274 | |||
| 1275 | memset(buffer, 0, sizeof(buffer)); | ||
| 1276 | if (count > sizeof(buffer) - 1) | ||
| 1277 | count = sizeof(buffer) - 1; | ||
| 1278 | if (copy_from_user(buffer, buf, count)) | ||
| 1279 | return -EFAULT; | ||
| 1280 | |||
| 1281 | p = get_proc_task(inode); | ||
| 1282 | if (!p) | ||
| 1283 | return -ESRCH; | ||
| 1284 | |||
| 1285 | if (same_thread_group(current, p)) | ||
| 1286 | set_task_comm(p, buffer); | ||
| 1287 | else | ||
| 1288 | count = -EINVAL; | ||
| 1289 | |||
| 1290 | put_task_struct(p); | ||
| 1291 | |||
| 1292 | return count; | ||
| 1293 | } | ||
| 1294 | |||
| 1295 | static int comm_show(struct seq_file *m, void *v) | ||
| 1296 | { | ||
| 1297 | struct inode *inode = m->private; | ||
| 1298 | struct task_struct *p; | ||
| 1299 | |||
| 1300 | p = get_proc_task(inode); | ||
| 1301 | if (!p) | ||
| 1302 | return -ESRCH; | ||
| 1303 | |||
| 1304 | task_lock(p); | ||
| 1305 | seq_printf(m, "%s\n", p->comm); | ||
| 1306 | task_unlock(p); | ||
| 1307 | |||
| 1308 | put_task_struct(p); | ||
| 1309 | |||
| 1310 | return 0; | ||
| 1311 | } | ||
| 1312 | |||
| 1313 | static int comm_open(struct inode *inode, struct file *filp) | ||
| 1314 | { | ||
| 1315 | int ret; | ||
| 1316 | |||
| 1317 | ret = single_open(filp, comm_show, NULL); | ||
| 1318 | if (!ret) { | ||
| 1319 | struct seq_file *m = filp->private_data; | ||
| 1320 | |||
| 1321 | m->private = inode; | ||
| 1322 | } | ||
| 1323 | return ret; | ||
| 1324 | } | ||
| 1325 | |||
| 1326 | static const struct file_operations proc_pid_set_comm_operations = { | ||
| 1327 | .open = comm_open, | ||
| 1328 | .read = seq_read, | ||
| 1329 | .write = comm_write, | ||
| 1330 | .llseek = seq_lseek, | ||
| 1331 | .release = single_release, | ||
| 1332 | }; | ||
| 1333 | |||
| 1268 | /* | 1334 | /* |
| 1269 | * We added or removed a vma mapping the executable. The vmas are only mapped | 1335 | * We added or removed a vma mapping the executable. The vmas are only mapped |
| 1270 | * during exec and are not mapped with the mmap system call. | 1336 | * during exec and are not mapped with the mmap system call. |
| @@ -2504,6 +2570,7 @@ static const struct pid_entry tgid_base_stuff[] = { | |||
| 2504 | #ifdef CONFIG_SCHED_DEBUG | 2570 | #ifdef CONFIG_SCHED_DEBUG |
| 2505 | REG("sched", S_IRUGO|S_IWUSR, proc_pid_sched_operations), | 2571 | REG("sched", S_IRUGO|S_IWUSR, proc_pid_sched_operations), |
| 2506 | #endif | 2572 | #endif |
| 2573 | REG("comm", S_IRUGO|S_IWUSR, proc_pid_set_comm_operations), | ||
| 2507 | #ifdef CONFIG_HAVE_ARCH_TRACEHOOK | 2574 | #ifdef CONFIG_HAVE_ARCH_TRACEHOOK |
| 2508 | INF("syscall", S_IRUSR, proc_pid_syscall), | 2575 | INF("syscall", S_IRUSR, proc_pid_syscall), |
| 2509 | #endif | 2576 | #endif |
| @@ -2838,6 +2905,7 @@ static const struct pid_entry tid_base_stuff[] = { | |||
| 2838 | #ifdef CONFIG_SCHED_DEBUG | 2905 | #ifdef CONFIG_SCHED_DEBUG |
| 2839 | REG("sched", S_IRUGO|S_IWUSR, proc_pid_sched_operations), | 2906 | REG("sched", S_IRUGO|S_IWUSR, proc_pid_sched_operations), |
| 2840 | #endif | 2907 | #endif |
| 2908 | REG("comm", S_IRUGO|S_IWUSR, proc_pid_set_comm_operations), | ||
| 2841 | #ifdef CONFIG_HAVE_ARCH_TRACEHOOK | 2909 | #ifdef CONFIG_HAVE_ARCH_TRACEHOOK |
| 2842 | INF("syscall", S_IRUSR, proc_pid_syscall), | 2910 | INF("syscall", S_IRUSR, proc_pid_syscall), |
| 2843 | #endif | 2911 | #endif |
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index 7ba79a54948c..123257bb356b 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include <linux/init.h> | 7 | #include <linux/init.h> |
| 8 | #include <linux/time.h> | 8 | #include <linux/time.h> |
| 9 | #include <linux/proc_fs.h> | 9 | #include <linux/proc_fs.h> |
| 10 | #include <linux/seq_file.h> | ||
| 10 | #include <linux/stat.h> | 11 | #include <linux/stat.h> |
| 11 | #include <linux/string.h> | 12 | #include <linux/string.h> |
| 12 | #include <asm/prom.h> | 13 | #include <asm/prom.h> |
| @@ -25,26 +26,27 @@ static struct proc_dir_entry *proc_device_tree; | |||
| 25 | /* | 26 | /* |
| 26 | * Supply data on a read from /proc/device-tree/node/property. | 27 | * Supply data on a read from /proc/device-tree/node/property. |
| 27 | */ | 28 | */ |
| 28 | static int property_read_proc(char *page, char **start, off_t off, | 29 | static int property_proc_show(struct seq_file *m, void *v) |
| 29 | int count, int *eof, void *data) | ||
| 30 | { | 30 | { |
| 31 | struct property *pp = data; | 31 | struct property *pp = m->private; |
| 32 | int n; | ||
| 33 | 32 | ||
| 34 | if (off >= pp->length) { | 33 | seq_write(m, pp->value, pp->length); |
| 35 | *eof = 1; | 34 | return 0; |
| 36 | return 0; | 35 | } |
| 37 | } | 36 | |
| 38 | n = pp->length - off; | 37 | static int property_proc_open(struct inode *inode, struct file *file) |
| 39 | if (n > count) | 38 | { |
| 40 | n = count; | 39 | return single_open(file, property_proc_show, PDE(inode)->data); |
| 41 | else | ||
| 42 | *eof = 1; | ||
| 43 | memcpy(page, (char *)pp->value + off, n); | ||
| 44 | *start = page; | ||
| 45 | return n; | ||
| 46 | } | 40 | } |
| 47 | 41 | ||
| 42 | static const struct file_operations property_proc_fops = { | ||
| 43 | .owner = THIS_MODULE, | ||
| 44 | .open = property_proc_open, | ||
| 45 | .read = seq_read, | ||
| 46 | .llseek = seq_lseek, | ||
| 47 | .release = single_release, | ||
| 48 | }; | ||
| 49 | |||
| 48 | /* | 50 | /* |
| 49 | * For a node with a name like "gc@10", we make symlinks called "gc" | 51 | * For a node with a name like "gc@10", we make symlinks called "gc" |
| 50 | * and "@10" to it. | 52 | * and "@10" to it. |
| @@ -63,10 +65,9 @@ __proc_device_tree_add_prop(struct proc_dir_entry *de, struct property *pp, | |||
| 63 | * Unfortunately proc_register puts each new entry | 65 | * Unfortunately proc_register puts each new entry |
| 64 | * at the beginning of the list. So we rearrange them. | 66 | * at the beginning of the list. So we rearrange them. |
| 65 | */ | 67 | */ |
| 66 | ent = create_proc_read_entry(name, | 68 | ent = proc_create_data(name, |
| 67 | strncmp(name, "security-", 9) | 69 | strncmp(name, "security-", 9) ? S_IRUGO : S_IRUSR, |
| 68 | ? S_IRUGO : S_IRUSR, de, | 70 | de, &property_proc_fops, pp); |
| 69 | property_read_proc, pp); | ||
| 70 | if (ent == NULL) | 71 | if (ent == NULL) |
| 71 | return NULL; | 72 | return NULL; |
| 72 | 73 | ||
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index f667e8aeabdf..6ff9981f0a18 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c | |||
| @@ -48,7 +48,7 @@ out: | |||
| 48 | static struct ctl_table *find_in_table(struct ctl_table *p, struct qstr *name) | 48 | static struct ctl_table *find_in_table(struct ctl_table *p, struct qstr *name) |
| 49 | { | 49 | { |
| 50 | int len; | 50 | int len; |
| 51 | for ( ; p->ctl_name || p->procname; p++) { | 51 | for ( ; p->procname; p++) { |
| 52 | 52 | ||
| 53 | if (!p->procname) | 53 | if (!p->procname) |
| 54 | continue; | 54 | continue; |
| @@ -218,7 +218,7 @@ static int scan(struct ctl_table_header *head, ctl_table *table, | |||
| 218 | void *dirent, filldir_t filldir) | 218 | void *dirent, filldir_t filldir) |
| 219 | { | 219 | { |
| 220 | 220 | ||
| 221 | for (; table->ctl_name || table->procname; table++, (*pos)++) { | 221 | for (; table->procname; table++, (*pos)++) { |
| 222 | int res; | 222 | int res; |
| 223 | 223 | ||
| 224 | /* Can't do anything without a proc name */ | 224 | /* Can't do anything without a proc name */ |
diff --git a/fs/proc/stat.c b/fs/proc/stat.c index 7cc726c6d70a..b9b7aad2003d 100644 --- a/fs/proc/stat.c +++ b/fs/proc/stat.c | |||
| @@ -27,7 +27,7 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 27 | int i, j; | 27 | int i, j; |
| 28 | unsigned long jif; | 28 | unsigned long jif; |
| 29 | cputime64_t user, nice, system, idle, iowait, irq, softirq, steal; | 29 | cputime64_t user, nice, system, idle, iowait, irq, softirq, steal; |
| 30 | cputime64_t guest; | 30 | cputime64_t guest, guest_nice; |
| 31 | u64 sum = 0; | 31 | u64 sum = 0; |
| 32 | u64 sum_softirq = 0; | 32 | u64 sum_softirq = 0; |
| 33 | unsigned int per_softirq_sums[NR_SOFTIRQS] = {0}; | 33 | unsigned int per_softirq_sums[NR_SOFTIRQS] = {0}; |
| @@ -36,7 +36,7 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 36 | 36 | ||
| 37 | user = nice = system = idle = iowait = | 37 | user = nice = system = idle = iowait = |
| 38 | irq = softirq = steal = cputime64_zero; | 38 | irq = softirq = steal = cputime64_zero; |
| 39 | guest = cputime64_zero; | 39 | guest = guest_nice = cputime64_zero; |
| 40 | getboottime(&boottime); | 40 | getboottime(&boottime); |
| 41 | jif = boottime.tv_sec; | 41 | jif = boottime.tv_sec; |
| 42 | 42 | ||
| @@ -51,6 +51,8 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 51 | softirq = cputime64_add(softirq, kstat_cpu(i).cpustat.softirq); | 51 | softirq = cputime64_add(softirq, kstat_cpu(i).cpustat.softirq); |
| 52 | steal = cputime64_add(steal, kstat_cpu(i).cpustat.steal); | 52 | steal = cputime64_add(steal, kstat_cpu(i).cpustat.steal); |
| 53 | guest = cputime64_add(guest, kstat_cpu(i).cpustat.guest); | 53 | guest = cputime64_add(guest, kstat_cpu(i).cpustat.guest); |
| 54 | guest_nice = cputime64_add(guest_nice, | ||
| 55 | kstat_cpu(i).cpustat.guest_nice); | ||
| 54 | for_each_irq_nr(j) { | 56 | for_each_irq_nr(j) { |
| 55 | sum += kstat_irqs_cpu(j, i); | 57 | sum += kstat_irqs_cpu(j, i); |
| 56 | } | 58 | } |
| @@ -65,7 +67,8 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 65 | } | 67 | } |
| 66 | sum += arch_irq_stat(); | 68 | sum += arch_irq_stat(); |
| 67 | 69 | ||
| 68 | seq_printf(p, "cpu %llu %llu %llu %llu %llu %llu %llu %llu %llu\n", | 70 | seq_printf(p, "cpu %llu %llu %llu %llu %llu %llu %llu %llu %llu " |
| 71 | "%llu\n", | ||
| 69 | (unsigned long long)cputime64_to_clock_t(user), | 72 | (unsigned long long)cputime64_to_clock_t(user), |
| 70 | (unsigned long long)cputime64_to_clock_t(nice), | 73 | (unsigned long long)cputime64_to_clock_t(nice), |
| 71 | (unsigned long long)cputime64_to_clock_t(system), | 74 | (unsigned long long)cputime64_to_clock_t(system), |
| @@ -74,7 +77,8 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 74 | (unsigned long long)cputime64_to_clock_t(irq), | 77 | (unsigned long long)cputime64_to_clock_t(irq), |
| 75 | (unsigned long long)cputime64_to_clock_t(softirq), | 78 | (unsigned long long)cputime64_to_clock_t(softirq), |
| 76 | (unsigned long long)cputime64_to_clock_t(steal), | 79 | (unsigned long long)cputime64_to_clock_t(steal), |
| 77 | (unsigned long long)cputime64_to_clock_t(guest)); | 80 | (unsigned long long)cputime64_to_clock_t(guest), |
| 81 | (unsigned long long)cputime64_to_clock_t(guest_nice)); | ||
| 78 | for_each_online_cpu(i) { | 82 | for_each_online_cpu(i) { |
| 79 | 83 | ||
| 80 | /* Copy values here to work around gcc-2.95.3, gcc-2.96 */ | 84 | /* Copy values here to work around gcc-2.95.3, gcc-2.96 */ |
| @@ -88,8 +92,10 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 88 | softirq = kstat_cpu(i).cpustat.softirq; | 92 | softirq = kstat_cpu(i).cpustat.softirq; |
| 89 | steal = kstat_cpu(i).cpustat.steal; | 93 | steal = kstat_cpu(i).cpustat.steal; |
| 90 | guest = kstat_cpu(i).cpustat.guest; | 94 | guest = kstat_cpu(i).cpustat.guest; |
| 95 | guest_nice = kstat_cpu(i).cpustat.guest_nice; | ||
| 91 | seq_printf(p, | 96 | seq_printf(p, |
| 92 | "cpu%d %llu %llu %llu %llu %llu %llu %llu %llu %llu\n", | 97 | "cpu%d %llu %llu %llu %llu %llu %llu %llu %llu %llu " |
| 98 | "%llu\n", | ||
| 93 | i, | 99 | i, |
| 94 | (unsigned long long)cputime64_to_clock_t(user), | 100 | (unsigned long long)cputime64_to_clock_t(user), |
| 95 | (unsigned long long)cputime64_to_clock_t(nice), | 101 | (unsigned long long)cputime64_to_clock_t(nice), |
| @@ -99,7 +105,8 @@ static int show_stat(struct seq_file *p, void *v) | |||
| 99 | (unsigned long long)cputime64_to_clock_t(irq), | 105 | (unsigned long long)cputime64_to_clock_t(irq), |
| 100 | (unsigned long long)cputime64_to_clock_t(softirq), | 106 | (unsigned long long)cputime64_to_clock_t(softirq), |
| 101 | (unsigned long long)cputime64_to_clock_t(steal), | 107 | (unsigned long long)cputime64_to_clock_t(steal), |
| 102 | (unsigned long long)cputime64_to_clock_t(guest)); | 108 | (unsigned long long)cputime64_to_clock_t(guest), |
| 109 | (unsigned long long)cputime64_to_clock_t(guest_nice)); | ||
| 103 | } | 110 | } |
| 104 | seq_printf(p, "intr %llu", (unsigned long long)sum); | 111 | seq_printf(p, "intr %llu", (unsigned long long)sum); |
| 105 | 112 | ||
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 2a1bef9203c6..47c03f4336b8 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c | |||
| @@ -650,6 +650,50 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, | |||
| 650 | return err; | 650 | return err; |
| 651 | } | 651 | } |
| 652 | 652 | ||
| 653 | static u64 huge_pte_to_pagemap_entry(pte_t pte, int offset) | ||
| 654 | { | ||
| 655 | u64 pme = 0; | ||
| 656 | if (pte_present(pte)) | ||
| 657 | pme = PM_PFRAME(pte_pfn(pte) + offset) | ||
| 658 | | PM_PSHIFT(PAGE_SHIFT) | PM_PRESENT; | ||
| 659 | return pme; | ||
| 660 | } | ||
| 661 | |||
| 662 | static int pagemap_hugetlb_range(pte_t *pte, unsigned long addr, | ||
| 663 | unsigned long end, struct mm_walk *walk) | ||
| 664 | { | ||
| 665 | struct vm_area_struct *vma; | ||
| 666 | struct pagemapread *pm = walk->private; | ||
| 667 | struct hstate *hs = NULL; | ||
| 668 | int err = 0; | ||
| 669 | |||
| 670 | vma = find_vma(walk->mm, addr); | ||
| 671 | if (vma) | ||
| 672 | hs = hstate_vma(vma); | ||
| 673 | for (; addr != end; addr += PAGE_SIZE) { | ||
| 674 | u64 pfn = PM_NOT_PRESENT; | ||
| 675 | |||
| 676 | if (vma && (addr >= vma->vm_end)) { | ||
| 677 | vma = find_vma(walk->mm, addr); | ||
| 678 | if (vma) | ||
| 679 | hs = hstate_vma(vma); | ||
| 680 | } | ||
| 681 | |||
| 682 | if (vma && (vma->vm_start <= addr) && is_vm_hugetlb_page(vma)) { | ||
| 683 | /* calculate pfn of the "raw" page in the hugepage. */ | ||
| 684 | int offset = (addr & ~huge_page_mask(hs)) >> PAGE_SHIFT; | ||
| 685 | pfn = huge_pte_to_pagemap_entry(*pte, offset); | ||
| 686 | } | ||
| 687 | err = add_to_pagemap(addr, pfn, pm); | ||
| 688 | if (err) | ||
| 689 | return err; | ||
| 690 | } | ||
| 691 | |||
| 692 | cond_resched(); | ||
| 693 | |||
| 694 | return err; | ||
| 695 | } | ||
| 696 | |||
| 653 | /* | 697 | /* |
| 654 | * /proc/pid/pagemap - an array mapping virtual pages to pfns | 698 | * /proc/pid/pagemap - an array mapping virtual pages to pfns |
| 655 | * | 699 | * |
| @@ -742,6 +786,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, | |||
| 742 | 786 | ||
| 743 | pagemap_walk.pmd_entry = pagemap_pte_range; | 787 | pagemap_walk.pmd_entry = pagemap_pte_range; |
| 744 | pagemap_walk.pte_hole = pagemap_pte_hole; | 788 | pagemap_walk.pte_hole = pagemap_pte_hole; |
| 789 | pagemap_walk.hugetlb_entry = pagemap_hugetlb_range; | ||
| 745 | pagemap_walk.mm = mm; | 790 | pagemap_walk.mm = mm; |
| 746 | pagemap_walk.private = ± | 791 | pagemap_walk.private = ± |
| 747 | 792 | ||
diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c index 8f5c05d3dbd3..5d9fd64ef81a 100644 --- a/fs/proc/task_nommu.c +++ b/fs/proc/task_nommu.c | |||
| @@ -110,9 +110,13 @@ int task_statm(struct mm_struct *mm, int *shared, int *text, | |||
| 110 | } | 110 | } |
| 111 | } | 111 | } |
| 112 | 112 | ||
| 113 | size += (*text = mm->end_code - mm->start_code); | 113 | *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) |
| 114 | size += (*data = mm->start_stack - mm->start_data); | 114 | >> PAGE_SHIFT; |
| 115 | *data = (PAGE_ALIGN(mm->start_stack) - (mm->start_data & PAGE_MASK)) | ||
| 116 | >> PAGE_SHIFT; | ||
| 115 | up_read(&mm->mmap_sem); | 117 | up_read(&mm->mmap_sem); |
| 118 | size >>= PAGE_SHIFT; | ||
| 119 | size += *text + *data; | ||
| 116 | *resident = size; | 120 | *resident = size; |
| 117 | return size; | 121 | return size; |
| 118 | } | 122 | } |
diff --git a/fs/qnx4/bitmap.c b/fs/qnx4/bitmap.c index 0afba069d567..32f5d131a644 100644 --- a/fs/qnx4/bitmap.c +++ b/fs/qnx4/bitmap.c | |||
| @@ -67,7 +67,7 @@ unsigned long qnx4_count_free_blocks(struct super_block *sb) | |||
| 67 | 67 | ||
| 68 | while (total < size) { | 68 | while (total < size) { |
| 69 | if ((bh = sb_bread(sb, start + offset)) == NULL) { | 69 | if ((bh = sb_bread(sb, start + offset)) == NULL) { |
| 70 | printk("qnx4: I/O error in counting free blocks\n"); | 70 | printk(KERN_ERR "qnx4: I/O error in counting free blocks\n"); |
| 71 | break; | 71 | break; |
| 72 | } | 72 | } |
| 73 | count_bits(bh->b_data, size - total, &total_free); | 73 | count_bits(bh->b_data, size - total, &total_free); |
diff --git a/fs/qnx4/dir.c b/fs/qnx4/dir.c index 86cc39cb1398..6f30c3d5bcbf 100644 --- a/fs/qnx4/dir.c +++ b/fs/qnx4/dir.c | |||
| @@ -26,8 +26,8 @@ static int qnx4_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 26 | int ix, ino; | 26 | int ix, ino; |
| 27 | int size; | 27 | int size; |
| 28 | 28 | ||
| 29 | QNX4DEBUG(("qnx4_readdir:i_size = %ld\n", (long) inode->i_size)); | 29 | QNX4DEBUG((KERN_INFO "qnx4_readdir:i_size = %ld\n", (long) inode->i_size)); |
| 30 | QNX4DEBUG(("filp->f_pos = %ld\n", (long) filp->f_pos)); | 30 | QNX4DEBUG((KERN_INFO "filp->f_pos = %ld\n", (long) filp->f_pos)); |
| 31 | 31 | ||
| 32 | lock_kernel(); | 32 | lock_kernel(); |
| 33 | 33 | ||
| @@ -50,7 +50,7 @@ static int qnx4_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 50 | size = QNX4_NAME_MAX; | 50 | size = QNX4_NAME_MAX; |
| 51 | 51 | ||
| 52 | if ( ( de->di_status & (QNX4_FILE_USED|QNX4_FILE_LINK) ) != 0 ) { | 52 | if ( ( de->di_status & (QNX4_FILE_USED|QNX4_FILE_LINK) ) != 0 ) { |
| 53 | QNX4DEBUG(("qnx4_readdir:%.*s\n", size, de->di_fname)); | 53 | QNX4DEBUG((KERN_INFO "qnx4_readdir:%.*s\n", size, de->di_fname)); |
| 54 | if ( ( de->di_status & QNX4_FILE_LINK ) == 0 ) | 54 | if ( ( de->di_status & QNX4_FILE_LINK ) == 0 ) |
| 55 | ino = blknum * QNX4_INODES_PER_BLOCK + ix - 1; | 55 | ino = blknum * QNX4_INODES_PER_BLOCK + ix - 1; |
| 56 | else { | 56 | else { |
diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c index d2cd1798d8c4..449f5a66dd34 100644 --- a/fs/qnx4/inode.c +++ b/fs/qnx4/inode.c | |||
| @@ -107,7 +107,7 @@ static int qnx4_get_block( struct inode *inode, sector_t iblock, struct buffer_h | |||
| 107 | { | 107 | { |
| 108 | unsigned long phys; | 108 | unsigned long phys; |
| 109 | 109 | ||
| 110 | QNX4DEBUG(("qnx4: qnx4_get_block inode=[%ld] iblock=[%ld]\n",inode->i_ino,iblock)); | 110 | QNX4DEBUG((KERN_INFO "qnx4: qnx4_get_block inode=[%ld] iblock=[%ld]\n",inode->i_ino,iblock)); |
| 111 | 111 | ||
| 112 | phys = qnx4_block_map( inode, iblock ); | 112 | phys = qnx4_block_map( inode, iblock ); |
| 113 | if ( phys ) { | 113 | if ( phys ) { |
| @@ -142,12 +142,12 @@ unsigned long qnx4_block_map( struct inode *inode, long iblock ) | |||
| 142 | // read next xtnt block. | 142 | // read next xtnt block. |
| 143 | bh = sb_bread(inode->i_sb, i_xblk - 1); | 143 | bh = sb_bread(inode->i_sb, i_xblk - 1); |
| 144 | if ( !bh ) { | 144 | if ( !bh ) { |
| 145 | QNX4DEBUG(("qnx4: I/O error reading xtnt block [%ld])\n", i_xblk - 1)); | 145 | QNX4DEBUG((KERN_ERR "qnx4: I/O error reading xtnt block [%ld])\n", i_xblk - 1)); |
| 146 | return -EIO; | 146 | return -EIO; |
| 147 | } | 147 | } |
| 148 | xblk = (struct qnx4_xblk*)bh->b_data; | 148 | xblk = (struct qnx4_xblk*)bh->b_data; |
| 149 | if ( memcmp( xblk->xblk_signature, "IamXblk", 7 ) ) { | 149 | if ( memcmp( xblk->xblk_signature, "IamXblk", 7 ) ) { |
| 150 | QNX4DEBUG(("qnx4: block at %ld is not a valid xtnt\n", qnx4_inode->i_xblk)); | 150 | QNX4DEBUG((KERN_ERR "qnx4: block at %ld is not a valid xtnt\n", qnx4_inode->i_xblk)); |
| 151 | return -EIO; | 151 | return -EIO; |
| 152 | } | 152 | } |
| 153 | } | 153 | } |
| @@ -168,7 +168,7 @@ unsigned long qnx4_block_map( struct inode *inode, long iblock ) | |||
| 168 | brelse( bh ); | 168 | brelse( bh ); |
| 169 | } | 169 | } |
| 170 | 170 | ||
| 171 | QNX4DEBUG(("qnx4: mapping block %ld of inode %ld = %ld\n",iblock,inode->i_ino,block)); | 171 | QNX4DEBUG((KERN_INFO "qnx4: mapping block %ld of inode %ld = %ld\n",iblock,inode->i_ino,block)); |
| 172 | return block; | 172 | return block; |
| 173 | } | 173 | } |
| 174 | 174 | ||
| @@ -209,7 +209,7 @@ static const char *qnx4_checkroot(struct super_block *sb) | |||
| 209 | if (*(qnx4_sb(sb)->sb->RootDir.di_fname) != '/') { | 209 | if (*(qnx4_sb(sb)->sb->RootDir.di_fname) != '/') { |
| 210 | return "no qnx4 filesystem (no root dir)."; | 210 | return "no qnx4 filesystem (no root dir)."; |
| 211 | } else { | 211 | } else { |
| 212 | QNX4DEBUG(("QNX4 filesystem found on dev %s.\n", sb->s_id)); | 212 | QNX4DEBUG((KERN_NOTICE "QNX4 filesystem found on dev %s.\n", sb->s_id)); |
| 213 | rd = le32_to_cpu(qnx4_sb(sb)->sb->RootDir.di_first_xtnt.xtnt_blk) - 1; | 213 | rd = le32_to_cpu(qnx4_sb(sb)->sb->RootDir.di_first_xtnt.xtnt_blk) - 1; |
| 214 | rl = le32_to_cpu(qnx4_sb(sb)->sb->RootDir.di_first_xtnt.xtnt_size); | 214 | rl = le32_to_cpu(qnx4_sb(sb)->sb->RootDir.di_first_xtnt.xtnt_size); |
| 215 | for (j = 0; j < rl; j++) { | 215 | for (j = 0; j < rl; j++) { |
| @@ -220,7 +220,7 @@ static const char *qnx4_checkroot(struct super_block *sb) | |||
| 220 | for (i = 0; i < QNX4_INODES_PER_BLOCK; i++) { | 220 | for (i = 0; i < QNX4_INODES_PER_BLOCK; i++) { |
| 221 | rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE); | 221 | rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE); |
| 222 | if (rootdir->di_fname != NULL) { | 222 | if (rootdir->di_fname != NULL) { |
| 223 | QNX4DEBUG(("Rootdir entry found : [%s]\n", rootdir->di_fname)); | 223 | QNX4DEBUG((KERN_INFO "rootdir entry found : [%s]\n", rootdir->di_fname)); |
| 224 | if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) { | 224 | if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) { |
| 225 | found = 1; | 225 | found = 1; |
| 226 | qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); | 226 | qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); |
| @@ -265,12 +265,12 @@ static int qnx4_fill_super(struct super_block *s, void *data, int silent) | |||
| 265 | if we don't belong here... */ | 265 | if we don't belong here... */ |
| 266 | bh = sb_bread(s, 1); | 266 | bh = sb_bread(s, 1); |
| 267 | if (!bh) { | 267 | if (!bh) { |
| 268 | printk("qnx4: unable to read the superblock\n"); | 268 | printk(KERN_ERR "qnx4: unable to read the superblock\n"); |
| 269 | goto outnobh; | 269 | goto outnobh; |
| 270 | } | 270 | } |
| 271 | if ( le32_to_cpup((__le32*) bh->b_data) != QNX4_SUPER_MAGIC ) { | 271 | if ( le32_to_cpup((__le32*) bh->b_data) != QNX4_SUPER_MAGIC ) { |
| 272 | if (!silent) | 272 | if (!silent) |
| 273 | printk("qnx4: wrong fsid in superblock.\n"); | 273 | printk(KERN_ERR "qnx4: wrong fsid in superblock.\n"); |
| 274 | goto out; | 274 | goto out; |
| 275 | } | 275 | } |
| 276 | s->s_op = &qnx4_sops; | 276 | s->s_op = &qnx4_sops; |
| @@ -284,14 +284,14 @@ static int qnx4_fill_super(struct super_block *s, void *data, int silent) | |||
| 284 | errmsg = qnx4_checkroot(s); | 284 | errmsg = qnx4_checkroot(s); |
| 285 | if (errmsg != NULL) { | 285 | if (errmsg != NULL) { |
| 286 | if (!silent) | 286 | if (!silent) |
| 287 | printk("qnx4: %s\n", errmsg); | 287 | printk(KERN_ERR "qnx4: %s\n", errmsg); |
| 288 | goto out; | 288 | goto out; |
| 289 | } | 289 | } |
| 290 | 290 | ||
| 291 | /* does root not have inode number QNX4_ROOT_INO ?? */ | 291 | /* does root not have inode number QNX4_ROOT_INO ?? */ |
| 292 | root = qnx4_iget(s, QNX4_ROOT_INO * QNX4_INODES_PER_BLOCK); | 292 | root = qnx4_iget(s, QNX4_ROOT_INO * QNX4_INODES_PER_BLOCK); |
| 293 | if (IS_ERR(root)) { | 293 | if (IS_ERR(root)) { |
| 294 | printk("qnx4: get inode failed\n"); | 294 | printk(KERN_ERR "qnx4: get inode failed\n"); |
| 295 | ret = PTR_ERR(root); | 295 | ret = PTR_ERR(root); |
| 296 | goto out; | 296 | goto out; |
| 297 | } | 297 | } |
| @@ -374,7 +374,7 @@ struct inode *qnx4_iget(struct super_block *sb, unsigned long ino) | |||
| 374 | qnx4_inode = qnx4_raw_inode(inode); | 374 | qnx4_inode = qnx4_raw_inode(inode); |
| 375 | inode->i_mode = 0; | 375 | inode->i_mode = 0; |
| 376 | 376 | ||
| 377 | QNX4DEBUG(("Reading inode : [%d]\n", ino)); | 377 | QNX4DEBUG((KERN_INFO "reading inode : [%d]\n", ino)); |
| 378 | if (!ino) { | 378 | if (!ino) { |
| 379 | printk(KERN_ERR "qnx4: bad inode number on dev %s: %lu is " | 379 | printk(KERN_ERR "qnx4: bad inode number on dev %s: %lu is " |
| 380 | "out of range\n", | 380 | "out of range\n", |
| @@ -385,7 +385,7 @@ struct inode *qnx4_iget(struct super_block *sb, unsigned long ino) | |||
| 385 | block = ino / QNX4_INODES_PER_BLOCK; | 385 | block = ino / QNX4_INODES_PER_BLOCK; |
| 386 | 386 | ||
| 387 | if (!(bh = sb_bread(sb, block))) { | 387 | if (!(bh = sb_bread(sb, block))) { |
| 388 | printk("qnx4: major problem: unable to read inode from dev " | 388 | printk(KERN_ERR "qnx4: major problem: unable to read inode from dev " |
| 389 | "%s\n", sb->s_id); | 389 | "%s\n", sb->s_id); |
| 390 | iget_failed(inode); | 390 | iget_failed(inode); |
| 391 | return ERR_PTR(-EIO); | 391 | return ERR_PTR(-EIO); |
| @@ -499,7 +499,7 @@ static int __init init_qnx4_fs(void) | |||
| 499 | return err; | 499 | return err; |
| 500 | } | 500 | } |
| 501 | 501 | ||
| 502 | printk("QNX4 filesystem 0.2.3 registered.\n"); | 502 | printk(KERN_INFO "QNX4 filesystem 0.2.3 registered.\n"); |
| 503 | return 0; | 503 | return 0; |
| 504 | } | 504 | } |
| 505 | 505 | ||
diff --git a/fs/qnx4/namei.c b/fs/qnx4/namei.c index ae1e7edbacd6..58703ebba879 100644 --- a/fs/qnx4/namei.c +++ b/fs/qnx4/namei.c | |||
| @@ -30,7 +30,7 @@ static int qnx4_match(int len, const char *name, | |||
| 30 | int namelen, thislen; | 30 | int namelen, thislen; |
| 31 | 31 | ||
| 32 | if (bh == NULL) { | 32 | if (bh == NULL) { |
| 33 | printk("qnx4: matching unassigned buffer !\n"); | 33 | printk(KERN_WARNING "qnx4: matching unassigned buffer !\n"); |
| 34 | return 0; | 34 | return 0; |
| 35 | } | 35 | } |
| 36 | de = (struct qnx4_inode_entry *) (bh->b_data + *offset); | 36 | de = (struct qnx4_inode_entry *) (bh->b_data + *offset); |
| @@ -66,7 +66,7 @@ static struct buffer_head *qnx4_find_entry(int len, struct inode *dir, | |||
| 66 | 66 | ||
| 67 | *res_dir = NULL; | 67 | *res_dir = NULL; |
| 68 | if (!dir->i_sb) { | 68 | if (!dir->i_sb) { |
| 69 | printk("qnx4: no superblock on dir.\n"); | 69 | printk(KERN_WARNING "qnx4: no superblock on dir.\n"); |
| 70 | return NULL; | 70 | return NULL; |
| 71 | } | 71 | } |
| 72 | bh = NULL; | 72 | bh = NULL; |
| @@ -124,7 +124,7 @@ struct dentry * qnx4_lookup(struct inode *dir, struct dentry *dentry, struct nam | |||
| 124 | foundinode = qnx4_iget(dir->i_sb, ino); | 124 | foundinode = qnx4_iget(dir->i_sb, ino); |
| 125 | if (IS_ERR(foundinode)) { | 125 | if (IS_ERR(foundinode)) { |
| 126 | unlock_kernel(); | 126 | unlock_kernel(); |
| 127 | QNX4DEBUG(("qnx4: lookup->iget -> error %ld\n", | 127 | QNX4DEBUG((KERN_ERR "qnx4: lookup->iget -> error %ld\n", |
| 128 | PTR_ERR(foundinode))); | 128 | PTR_ERR(foundinode))); |
| 129 | return ERR_CAST(foundinode); | 129 | return ERR_CAST(foundinode); |
| 130 | } | 130 | } |
diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig index 8047e01ef46b..efc02ebb8c70 100644 --- a/fs/quota/Kconfig +++ b/fs/quota/Kconfig | |||
| @@ -17,7 +17,7 @@ config QUOTA | |||
| 17 | 17 | ||
| 18 | config QUOTA_NETLINK_INTERFACE | 18 | config QUOTA_NETLINK_INTERFACE |
| 19 | bool "Report quota messages through netlink interface" | 19 | bool "Report quota messages through netlink interface" |
| 20 | depends on QUOTA && NET | 20 | depends on QUOTACTL && NET |
| 21 | help | 21 | help |
| 22 | If you say Y here, quota warnings (about exceeding softlimit, reaching | 22 | If you say Y here, quota warnings (about exceeding softlimit, reaching |
| 23 | hardlimit, etc.) will be reported through netlink interface. If unsure, | 23 | hardlimit, etc.) will be reported through netlink interface. If unsure, |
| @@ -46,12 +46,14 @@ config QFMT_V1 | |||
| 46 | format say Y here. | 46 | format say Y here. |
| 47 | 47 | ||
| 48 | config QFMT_V2 | 48 | config QFMT_V2 |
| 49 | tristate "Quota format v2 support" | 49 | tristate "Quota format vfsv0 and vfsv1 support" |
| 50 | depends on QUOTA | 50 | depends on QUOTA |
| 51 | select QUOTA_TREE | 51 | select QUOTA_TREE |
| 52 | help | 52 | help |
| 53 | This quota format allows using quotas with 32-bit UIDs/GIDs. If you | 53 | This config option enables kernel support for vfsv0 and vfsv1 quota |
| 54 | need this functionality say Y here. | 54 | formats. Both these formats support 32-bit UIDs/GIDs and vfsv1 format |
| 55 | also supports 64-bit inode and block quota limits. If you need this | ||
| 56 | functionality say Y here. | ||
| 55 | 57 | ||
| 56 | config QUOTACTL | 58 | config QUOTACTL |
| 57 | bool | 59 | bool |
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 39b49c42a7ed..cd6bb9a33c13 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c | |||
| @@ -77,10 +77,6 @@ | |||
| 77 | #include <linux/capability.h> | 77 | #include <linux/capability.h> |
| 78 | #include <linux/quotaops.h> | 78 | #include <linux/quotaops.h> |
| 79 | #include <linux/writeback.h> /* for inode_lock, oddly enough.. */ | 79 | #include <linux/writeback.h> /* for inode_lock, oddly enough.. */ |
| 80 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
| 81 | #include <net/netlink.h> | ||
| 82 | #include <net/genetlink.h> | ||
| 83 | #endif | ||
| 84 | 80 | ||
| 85 | #include <asm/uaccess.h> | 81 | #include <asm/uaccess.h> |
| 86 | 82 | ||
| @@ -1071,73 +1067,6 @@ static void print_warning(struct dquot *dquot, const int warntype) | |||
| 1071 | } | 1067 | } |
| 1072 | #endif | 1068 | #endif |
| 1073 | 1069 | ||
| 1074 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
| 1075 | |||
| 1076 | /* Netlink family structure for quota */ | ||
| 1077 | static struct genl_family quota_genl_family = { | ||
| 1078 | .id = GENL_ID_GENERATE, | ||
| 1079 | .hdrsize = 0, | ||
| 1080 | .name = "VFS_DQUOT", | ||
| 1081 | .version = 1, | ||
| 1082 | .maxattr = QUOTA_NL_A_MAX, | ||
| 1083 | }; | ||
| 1084 | |||
| 1085 | /* Send warning to userspace about user which exceeded quota */ | ||
| 1086 | static void send_warning(const struct dquot *dquot, const char warntype) | ||
| 1087 | { | ||
| 1088 | static atomic_t seq; | ||
| 1089 | struct sk_buff *skb; | ||
| 1090 | void *msg_head; | ||
| 1091 | int ret; | ||
| 1092 | int msg_size = 4 * nla_total_size(sizeof(u32)) + | ||
| 1093 | 2 * nla_total_size(sizeof(u64)); | ||
| 1094 | |||
| 1095 | /* We have to allocate using GFP_NOFS as we are called from a | ||
| 1096 | * filesystem performing write and thus further recursion into | ||
| 1097 | * the fs to free some data could cause deadlocks. */ | ||
| 1098 | skb = genlmsg_new(msg_size, GFP_NOFS); | ||
| 1099 | if (!skb) { | ||
| 1100 | printk(KERN_ERR | ||
| 1101 | "VFS: Not enough memory to send quota warning.\n"); | ||
| 1102 | return; | ||
| 1103 | } | ||
| 1104 | msg_head = genlmsg_put(skb, 0, atomic_add_return(1, &seq), | ||
| 1105 | "a_genl_family, 0, QUOTA_NL_C_WARNING); | ||
| 1106 | if (!msg_head) { | ||
| 1107 | printk(KERN_ERR | ||
| 1108 | "VFS: Cannot store netlink header in quota warning.\n"); | ||
| 1109 | goto err_out; | ||
| 1110 | } | ||
| 1111 | ret = nla_put_u32(skb, QUOTA_NL_A_QTYPE, dquot->dq_type); | ||
| 1112 | if (ret) | ||
| 1113 | goto attr_err_out; | ||
| 1114 | ret = nla_put_u64(skb, QUOTA_NL_A_EXCESS_ID, dquot->dq_id); | ||
| 1115 | if (ret) | ||
| 1116 | goto attr_err_out; | ||
| 1117 | ret = nla_put_u32(skb, QUOTA_NL_A_WARNING, warntype); | ||
| 1118 | if (ret) | ||
| 1119 | goto attr_err_out; | ||
| 1120 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MAJOR, | ||
| 1121 | MAJOR(dquot->dq_sb->s_dev)); | ||
| 1122 | if (ret) | ||
| 1123 | goto attr_err_out; | ||
| 1124 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MINOR, | ||
| 1125 | MINOR(dquot->dq_sb->s_dev)); | ||
| 1126 | if (ret) | ||
| 1127 | goto attr_err_out; | ||
| 1128 | ret = nla_put_u64(skb, QUOTA_NL_A_CAUSED_ID, current_uid()); | ||
| 1129 | if (ret) | ||
| 1130 | goto attr_err_out; | ||
| 1131 | genlmsg_end(skb, msg_head); | ||
| 1132 | |||
| 1133 | genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); | ||
| 1134 | return; | ||
| 1135 | attr_err_out: | ||
| 1136 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); | ||
| 1137 | err_out: | ||
| 1138 | kfree_skb(skb); | ||
| 1139 | } | ||
| 1140 | #endif | ||
| 1141 | /* | 1070 | /* |
| 1142 | * Write warnings to the console and send warning messages over netlink. | 1071 | * Write warnings to the console and send warning messages over netlink. |
| 1143 | * | 1072 | * |
| @@ -1145,18 +1074,20 @@ err_out: | |||
| 1145 | */ | 1074 | */ |
| 1146 | static void flush_warnings(struct dquot *const *dquots, char *warntype) | 1075 | static void flush_warnings(struct dquot *const *dquots, char *warntype) |
| 1147 | { | 1076 | { |
| 1077 | struct dquot *dq; | ||
| 1148 | int i; | 1078 | int i; |
| 1149 | 1079 | ||
| 1150 | for (i = 0; i < MAXQUOTAS; i++) | 1080 | for (i = 0; i < MAXQUOTAS; i++) { |
| 1151 | if (dquots[i] && warntype[i] != QUOTA_NL_NOWARN && | 1081 | dq = dquots[i]; |
| 1152 | !warning_issued(dquots[i], warntype[i])) { | 1082 | if (dq && warntype[i] != QUOTA_NL_NOWARN && |
| 1083 | !warning_issued(dq, warntype[i])) { | ||
| 1153 | #ifdef CONFIG_PRINT_QUOTA_WARNING | 1084 | #ifdef CONFIG_PRINT_QUOTA_WARNING |
| 1154 | print_warning(dquots[i], warntype[i]); | 1085 | print_warning(dq, warntype[i]); |
| 1155 | #endif | ||
| 1156 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
| 1157 | send_warning(dquots[i], warntype[i]); | ||
| 1158 | #endif | 1086 | #endif |
| 1087 | quota_send_warning(dq->dq_type, dq->dq_id, | ||
| 1088 | dq->dq_sb->s_dev, warntype[i]); | ||
| 1159 | } | 1089 | } |
| 1090 | } | ||
| 1160 | } | 1091 | } |
| 1161 | 1092 | ||
| 1162 | static int ignore_hardlimit(struct dquot *dquot) | 1093 | static int ignore_hardlimit(struct dquot *dquot) |
| @@ -2233,7 +2164,9 @@ int vfs_quota_on_mount(struct super_block *sb, char *qf_name, | |||
| 2233 | struct dentry *dentry; | 2164 | struct dentry *dentry; |
| 2234 | int error; | 2165 | int error; |
| 2235 | 2166 | ||
| 2167 | mutex_lock(&sb->s_root->d_inode->i_mutex); | ||
| 2236 | dentry = lookup_one_len(qf_name, sb->s_root, strlen(qf_name)); | 2168 | dentry = lookup_one_len(qf_name, sb->s_root, strlen(qf_name)); |
| 2169 | mutex_unlock(&sb->s_root->d_inode->i_mutex); | ||
| 2237 | if (IS_ERR(dentry)) | 2170 | if (IS_ERR(dentry)) |
| 2238 | return PTR_ERR(dentry); | 2171 | return PTR_ERR(dentry); |
| 2239 | 2172 | ||
| @@ -2473,100 +2406,89 @@ const struct quotactl_ops vfs_quotactl_ops = { | |||
| 2473 | 2406 | ||
| 2474 | static ctl_table fs_dqstats_table[] = { | 2407 | static ctl_table fs_dqstats_table[] = { |
| 2475 | { | 2408 | { |
| 2476 | .ctl_name = FS_DQ_LOOKUPS, | ||
| 2477 | .procname = "lookups", | 2409 | .procname = "lookups", |
| 2478 | .data = &dqstats.lookups, | 2410 | .data = &dqstats.lookups, |
| 2479 | .maxlen = sizeof(int), | 2411 | .maxlen = sizeof(int), |
| 2480 | .mode = 0444, | 2412 | .mode = 0444, |
| 2481 | .proc_handler = &proc_dointvec, | 2413 | .proc_handler = proc_dointvec, |
| 2482 | }, | 2414 | }, |
| 2483 | { | 2415 | { |
| 2484 | .ctl_name = FS_DQ_DROPS, | ||
| 2485 | .procname = "drops", | 2416 | .procname = "drops", |
| 2486 | .data = &dqstats.drops, | 2417 | .data = &dqstats.drops, |
| 2487 | .maxlen = sizeof(int), | 2418 | .maxlen = sizeof(int), |
| 2488 | .mode = 0444, | 2419 | .mode = 0444, |
| 2489 | .proc_handler = &proc_dointvec, | 2420 | .proc_handler = proc_dointvec, |
| 2490 | }, | 2421 | }, |
| 2491 | { | 2422 | { |
| 2492 | .ctl_name = FS_DQ_READS, | ||
| 2493 | .procname = "reads", | 2423 | .procname = "reads", |
| 2494 | .data = &dqstats.reads, | 2424 | .data = &dqstats.reads, |
| 2495 | .maxlen = sizeof(int), | 2425 | .maxlen = sizeof(int), |
| 2496 | .mode = 0444, | 2426 | .mode = 0444, |
| 2497 | .proc_handler = &proc_dointvec, | 2427 | .proc_handler = proc_dointvec, |
| 2498 | }, | 2428 | }, |
| 2499 | { | 2429 | { |
| 2500 | .ctl_name = FS_DQ_WRITES, | ||
| 2501 | .procname = "writes", | 2430 | .procname = "writes", |
| 2502 | .data = &dqstats.writes, | 2431 | .data = &dqstats.writes, |
| 2503 | .maxlen = sizeof(int), | 2432 | .maxlen = sizeof(int), |
| 2504 | .mode = 0444, | 2433 | .mode = 0444, |
| 2505 | .proc_handler = &proc_dointvec, | 2434 | .proc_handler = proc_dointvec, |
| 2506 | }, | 2435 | }, |
| 2507 | { | 2436 | { |
| 2508 | .ctl_name = FS_DQ_CACHE_HITS, | ||
| 2509 | .procname = "cache_hits", | 2437 | .procname = "cache_hits", |
| 2510 | .data = &dqstats.cache_hits, | 2438 | .data = &dqstats.cache_hits, |
| 2511 | .maxlen = sizeof(int), | 2439 | .maxlen = sizeof(int), |
| 2512 | .mode = 0444, | 2440 | .mode = 0444, |
| 2513 | .proc_handler = &proc_dointvec, | 2441 | .proc_handler = proc_dointvec, |
| 2514 | }, | 2442 | }, |
| 2515 | { | 2443 | { |
| 2516 | .ctl_name = FS_DQ_ALLOCATED, | ||
| 2517 | .procname = "allocated_dquots", | 2444 | .procname = "allocated_dquots", |
| 2518 | .data = &dqstats.allocated_dquots, | 2445 | .data = &dqstats.allocated_dquots, |
| 2519 | .maxlen = sizeof(int), | 2446 | .maxlen = sizeof(int), |
| 2520 | .mode = 0444, | 2447 | .mode = 0444, |
| 2521 | .proc_handler = &proc_dointvec, | 2448 | .proc_handler = proc_dointvec, |
| 2522 | }, | 2449 | }, |
| 2523 | { | 2450 | { |
| 2524 | .ctl_name = FS_DQ_FREE, | ||
| 2525 | .procname = "free_dquots", | 2451 | .procname = "free_dquots", |
| 2526 | .data = &dqstats.free_dquots, | 2452 | .data = &dqstats.free_dquots, |
| 2527 | .maxlen = sizeof(int), | 2453 | .maxlen = sizeof(int), |
| 2528 | .mode = 0444, | 2454 | .mode = 0444, |
| 2529 | .proc_handler = &proc_dointvec, | 2455 | .proc_handler = proc_dointvec, |
| 2530 | }, | 2456 | }, |
| 2531 | { | 2457 | { |
| 2532 | .ctl_name = FS_DQ_SYNCS, | ||
| 2533 | .procname = "syncs", | 2458 | .procname = "syncs", |
| 2534 | .data = &dqstats.syncs, | 2459 | .data = &dqstats.syncs, |
| 2535 | .maxlen = sizeof(int), | 2460 | .maxlen = sizeof(int), |
| 2536 | .mode = 0444, | 2461 | .mode = 0444, |
| 2537 | .proc_handler = &proc_dointvec, | 2462 | .proc_handler = proc_dointvec, |
| 2538 | }, | 2463 | }, |
| 2539 | #ifdef CONFIG_PRINT_QUOTA_WARNING | 2464 | #ifdef CONFIG_PRINT_QUOTA_WARNING |
| 2540 | { | 2465 | { |
| 2541 | .ctl_name = FS_DQ_WARNINGS, | ||
| 2542 | .procname = "warnings", | 2466 | .procname = "warnings", |
| 2543 | .data = &flag_print_warnings, | 2467 | .data = &flag_print_warnings, |
| 2544 | .maxlen = sizeof(int), | 2468 | .maxlen = sizeof(int), |
| 2545 | .mode = 0644, | 2469 | .mode = 0644, |
| 2546 | .proc_handler = &proc_dointvec, | 2470 | .proc_handler = proc_dointvec, |
| 2547 | }, | 2471 | }, |
| 2548 | #endif | 2472 | #endif |
| 2549 | { .ctl_name = 0 }, | 2473 | { }, |
| 2550 | }; | 2474 | }; |
| 2551 | 2475 | ||
| 2552 | static ctl_table fs_table[] = { | 2476 | static ctl_table fs_table[] = { |
| 2553 | { | 2477 | { |
| 2554 | .ctl_name = FS_DQSTATS, | ||
| 2555 | .procname = "quota", | 2478 | .procname = "quota", |
| 2556 | .mode = 0555, | 2479 | .mode = 0555, |
| 2557 | .child = fs_dqstats_table, | 2480 | .child = fs_dqstats_table, |
| 2558 | }, | 2481 | }, |
| 2559 | { .ctl_name = 0 }, | 2482 | { }, |
| 2560 | }; | 2483 | }; |
| 2561 | 2484 | ||
| 2562 | static ctl_table sys_table[] = { | 2485 | static ctl_table sys_table[] = { |
| 2563 | { | 2486 | { |
| 2564 | .ctl_name = CTL_FS, | ||
| 2565 | .procname = "fs", | 2487 | .procname = "fs", |
| 2566 | .mode = 0555, | 2488 | .mode = 0555, |
| 2567 | .child = fs_table, | 2489 | .child = fs_table, |
| 2568 | }, | 2490 | }, |
| 2569 | { .ctl_name = 0 }, | 2491 | { }, |
| 2570 | }; | 2492 | }; |
| 2571 | 2493 | ||
| 2572 | static int __init dquot_init(void) | 2494 | static int __init dquot_init(void) |
| @@ -2607,12 +2529,6 @@ static int __init dquot_init(void) | |||
| 2607 | 2529 | ||
| 2608 | register_shrinker(&dqcache_shrinker); | 2530 | register_shrinker(&dqcache_shrinker); |
| 2609 | 2531 | ||
| 2610 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
| 2611 | if (genl_register_family("a_genl_family) != 0) | ||
| 2612 | printk(KERN_ERR | ||
| 2613 | "VFS: Failed to create quota netlink interface.\n"); | ||
| 2614 | #endif | ||
| 2615 | |||
| 2616 | return 0; | 2532 | return 0; |
| 2617 | } | 2533 | } |
| 2618 | module_init(dquot_init); | 2534 | module_init(dquot_init); |
diff --git a/fs/quota/quota.c b/fs/quota/quota.c index 95c5b42384b2..ee91e2756950 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c | |||
| @@ -18,6 +18,8 @@ | |||
| 18 | #include <linux/capability.h> | 18 | #include <linux/capability.h> |
| 19 | #include <linux/quotaops.h> | 19 | #include <linux/quotaops.h> |
| 20 | #include <linux/types.h> | 20 | #include <linux/types.h> |
| 21 | #include <net/netlink.h> | ||
| 22 | #include <net/genetlink.h> | ||
| 21 | 23 | ||
| 22 | /* Check validity of generic quotactl commands */ | 24 | /* Check validity of generic quotactl commands */ |
| 23 | static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, | 25 | static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, |
| @@ -525,3 +527,94 @@ asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special, | |||
| 525 | return ret; | 527 | return ret; |
| 526 | } | 528 | } |
| 527 | #endif | 529 | #endif |
| 530 | |||
| 531 | |||
| 532 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
| 533 | |||
| 534 | /* Netlink family structure for quota */ | ||
| 535 | static struct genl_family quota_genl_family = { | ||
| 536 | .id = GENL_ID_GENERATE, | ||
| 537 | .hdrsize = 0, | ||
| 538 | .name = "VFS_DQUOT", | ||
| 539 | .version = 1, | ||
| 540 | .maxattr = QUOTA_NL_A_MAX, | ||
| 541 | }; | ||
| 542 | |||
| 543 | /** | ||
| 544 | * quota_send_warning - Send warning to userspace about exceeded quota | ||
| 545 | * @type: The quota type: USRQQUOTA, GRPQUOTA,... | ||
| 546 | * @id: The user or group id of the quota that was exceeded | ||
| 547 | * @dev: The device on which the fs is mounted (sb->s_dev) | ||
| 548 | * @warntype: The type of the warning: QUOTA_NL_... | ||
| 549 | * | ||
| 550 | * This can be used by filesystems (including those which don't use | ||
| 551 | * dquot) to send a message to userspace relating to quota limits. | ||
| 552 | * | ||
| 553 | */ | ||
| 554 | |||
| 555 | void quota_send_warning(short type, unsigned int id, dev_t dev, | ||
| 556 | const char warntype) | ||
| 557 | { | ||
| 558 | static atomic_t seq; | ||
| 559 | struct sk_buff *skb; | ||
| 560 | void *msg_head; | ||
| 561 | int ret; | ||
| 562 | int msg_size = 4 * nla_total_size(sizeof(u32)) + | ||
| 563 | 2 * nla_total_size(sizeof(u64)); | ||
| 564 | |||
| 565 | /* We have to allocate using GFP_NOFS as we are called from a | ||
| 566 | * filesystem performing write and thus further recursion into | ||
| 567 | * the fs to free some data could cause deadlocks. */ | ||
| 568 | skb = genlmsg_new(msg_size, GFP_NOFS); | ||
| 569 | if (!skb) { | ||
| 570 | printk(KERN_ERR | ||
| 571 | "VFS: Not enough memory to send quota warning.\n"); | ||
| 572 | return; | ||
| 573 | } | ||
| 574 | msg_head = genlmsg_put(skb, 0, atomic_add_return(1, &seq), | ||
| 575 | "a_genl_family, 0, QUOTA_NL_C_WARNING); | ||
| 576 | if (!msg_head) { | ||
| 577 | printk(KERN_ERR | ||
| 578 | "VFS: Cannot store netlink header in quota warning.\n"); | ||
| 579 | goto err_out; | ||
| 580 | } | ||
| 581 | ret = nla_put_u32(skb, QUOTA_NL_A_QTYPE, type); | ||
| 582 | if (ret) | ||
| 583 | goto attr_err_out; | ||
| 584 | ret = nla_put_u64(skb, QUOTA_NL_A_EXCESS_ID, id); | ||
| 585 | if (ret) | ||
| 586 | goto attr_err_out; | ||
| 587 | ret = nla_put_u32(skb, QUOTA_NL_A_WARNING, warntype); | ||
| 588 | if (ret) | ||
| 589 | goto attr_err_out; | ||
| 590 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MAJOR, MAJOR(dev)); | ||
| 591 | if (ret) | ||
| 592 | goto attr_err_out; | ||
| 593 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MINOR, MINOR(dev)); | ||
| 594 | if (ret) | ||
| 595 | goto attr_err_out; | ||
| 596 | ret = nla_put_u64(skb, QUOTA_NL_A_CAUSED_ID, current_uid()); | ||
| 597 | if (ret) | ||
| 598 | goto attr_err_out; | ||
| 599 | genlmsg_end(skb, msg_head); | ||
| 600 | |||
| 601 | genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); | ||
| 602 | return; | ||
| 603 | attr_err_out: | ||
| 604 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); | ||
| 605 | err_out: | ||
| 606 | kfree_skb(skb); | ||
| 607 | } | ||
| 608 | EXPORT_SYMBOL(quota_send_warning); | ||
| 609 | |||
| 610 | static int __init quota_init(void) | ||
| 611 | { | ||
| 612 | if (genl_register_family("a_genl_family) != 0) | ||
| 613 | printk(KERN_ERR | ||
| 614 | "VFS: Failed to create quota netlink interface.\n"); | ||
| 615 | return 0; | ||
| 616 | }; | ||
| 617 | |||
| 618 | module_init(quota_init); | ||
| 619 | #endif | ||
| 620 | |||
diff --git a/fs/quota/quota_v1.c b/fs/quota/quota_v1.c index 0edcf42b1778..2ae757e9c008 100644 --- a/fs/quota/quota_v1.c +++ b/fs/quota/quota_v1.c | |||
| @@ -204,7 +204,7 @@ out: | |||
| 204 | return ret; | 204 | return ret; |
| 205 | } | 205 | } |
| 206 | 206 | ||
| 207 | static struct quota_format_ops v1_format_ops = { | 207 | static const struct quota_format_ops v1_format_ops = { |
| 208 | .check_quota_file = v1_check_quota_file, | 208 | .check_quota_file = v1_check_quota_file, |
| 209 | .read_file_info = v1_read_file_info, | 209 | .read_file_info = v1_read_file_info, |
| 210 | .write_file_info = v1_write_file_info, | 210 | .write_file_info = v1_write_file_info, |
diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c index a5475fb1ae44..3dfc23e02135 100644 --- a/fs/quota/quota_v2.c +++ b/fs/quota/quota_v2.c | |||
| @@ -23,14 +23,23 @@ MODULE_LICENSE("GPL"); | |||
| 23 | 23 | ||
| 24 | #define __QUOTA_V2_PARANOIA | 24 | #define __QUOTA_V2_PARANOIA |
| 25 | 25 | ||
| 26 | static void v2_mem2diskdqb(void *dp, struct dquot *dquot); | 26 | static void v2r0_mem2diskdqb(void *dp, struct dquot *dquot); |
| 27 | static void v2_disk2memdqb(struct dquot *dquot, void *dp); | 27 | static void v2r0_disk2memdqb(struct dquot *dquot, void *dp); |
| 28 | static int v2_is_id(void *dp, struct dquot *dquot); | 28 | static int v2r0_is_id(void *dp, struct dquot *dquot); |
| 29 | 29 | static void v2r1_mem2diskdqb(void *dp, struct dquot *dquot); | |
| 30 | static struct qtree_fmt_operations v2_qtree_ops = { | 30 | static void v2r1_disk2memdqb(struct dquot *dquot, void *dp); |
| 31 | .mem2disk_dqblk = v2_mem2diskdqb, | 31 | static int v2r1_is_id(void *dp, struct dquot *dquot); |
| 32 | .disk2mem_dqblk = v2_disk2memdqb, | 32 | |
| 33 | .is_id = v2_is_id, | 33 | static struct qtree_fmt_operations v2r0_qtree_ops = { |
| 34 | .mem2disk_dqblk = v2r0_mem2diskdqb, | ||
| 35 | .disk2mem_dqblk = v2r0_disk2memdqb, | ||
| 36 | .is_id = v2r0_is_id, | ||
| 37 | }; | ||
| 38 | |||
| 39 | static struct qtree_fmt_operations v2r1_qtree_ops = { | ||
| 40 | .mem2disk_dqblk = v2r1_mem2diskdqb, | ||
| 41 | .disk2mem_dqblk = v2r1_disk2memdqb, | ||
| 42 | .is_id = v2r1_is_id, | ||
| 34 | }; | 43 | }; |
| 35 | 44 | ||
| 36 | #define QUOTABLOCK_BITS 10 | 45 | #define QUOTABLOCK_BITS 10 |
| @@ -46,23 +55,33 @@ static inline qsize_t v2_qbtos(qsize_t blocks) | |||
| 46 | return blocks << QUOTABLOCK_BITS; | 55 | return blocks << QUOTABLOCK_BITS; |
| 47 | } | 56 | } |
| 48 | 57 | ||
| 58 | static int v2_read_header(struct super_block *sb, int type, | ||
| 59 | struct v2_disk_dqheader *dqhead) | ||
| 60 | { | ||
| 61 | ssize_t size; | ||
| 62 | |||
| 63 | size = sb->s_op->quota_read(sb, type, (char *)dqhead, | ||
| 64 | sizeof(struct v2_disk_dqheader), 0); | ||
| 65 | if (size != sizeof(struct v2_disk_dqheader)) { | ||
| 66 | printk(KERN_WARNING "quota_v2: Failed header read:" | ||
| 67 | " expected=%zd got=%zd\n", | ||
| 68 | sizeof(struct v2_disk_dqheader), size); | ||
| 69 | return 0; | ||
| 70 | } | ||
| 71 | return 1; | ||
| 72 | } | ||
| 73 | |||
| 49 | /* Check whether given file is really vfsv0 quotafile */ | 74 | /* Check whether given file is really vfsv0 quotafile */ |
| 50 | static int v2_check_quota_file(struct super_block *sb, int type) | 75 | static int v2_check_quota_file(struct super_block *sb, int type) |
| 51 | { | 76 | { |
| 52 | struct v2_disk_dqheader dqhead; | 77 | struct v2_disk_dqheader dqhead; |
| 53 | ssize_t size; | ||
| 54 | static const uint quota_magics[] = V2_INITQMAGICS; | 78 | static const uint quota_magics[] = V2_INITQMAGICS; |
| 55 | static const uint quota_versions[] = V2_INITQVERSIONS; | 79 | static const uint quota_versions[] = V2_INITQVERSIONS; |
| 56 | 80 | ||
| 57 | size = sb->s_op->quota_read(sb, type, (char *)&dqhead, | 81 | if (!v2_read_header(sb, type, &dqhead)) |
| 58 | sizeof(struct v2_disk_dqheader), 0); | ||
| 59 | if (size != sizeof(struct v2_disk_dqheader)) { | ||
| 60 | printk("quota_v2: failed read expected=%zd got=%zd\n", | ||
| 61 | sizeof(struct v2_disk_dqheader), size); | ||
| 62 | return 0; | 82 | return 0; |
| 63 | } | ||
| 64 | if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type] || | 83 | if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type] || |
| 65 | le32_to_cpu(dqhead.dqh_version) != quota_versions[type]) | 84 | le32_to_cpu(dqhead.dqh_version) > quota_versions[type]) |
| 66 | return 0; | 85 | return 0; |
| 67 | return 1; | 86 | return 1; |
| 68 | } | 87 | } |
| @@ -71,14 +90,20 @@ static int v2_check_quota_file(struct super_block *sb, int type) | |||
| 71 | static int v2_read_file_info(struct super_block *sb, int type) | 90 | static int v2_read_file_info(struct super_block *sb, int type) |
| 72 | { | 91 | { |
| 73 | struct v2_disk_dqinfo dinfo; | 92 | struct v2_disk_dqinfo dinfo; |
| 93 | struct v2_disk_dqheader dqhead; | ||
| 74 | struct mem_dqinfo *info = sb_dqinfo(sb, type); | 94 | struct mem_dqinfo *info = sb_dqinfo(sb, type); |
| 75 | struct qtree_mem_dqinfo *qinfo; | 95 | struct qtree_mem_dqinfo *qinfo; |
| 76 | ssize_t size; | 96 | ssize_t size; |
| 97 | unsigned int version; | ||
| 98 | |||
| 99 | if (!v2_read_header(sb, type, &dqhead)) | ||
| 100 | return 0; | ||
| 101 | version = le32_to_cpu(dqhead.dqh_version); | ||
| 77 | 102 | ||
| 78 | size = sb->s_op->quota_read(sb, type, (char *)&dinfo, | 103 | size = sb->s_op->quota_read(sb, type, (char *)&dinfo, |
| 79 | sizeof(struct v2_disk_dqinfo), V2_DQINFOOFF); | 104 | sizeof(struct v2_disk_dqinfo), V2_DQINFOOFF); |
| 80 | if (size != sizeof(struct v2_disk_dqinfo)) { | 105 | if (size != sizeof(struct v2_disk_dqinfo)) { |
| 81 | printk(KERN_WARNING "Can't read info structure on device %s.\n", | 106 | printk(KERN_WARNING "quota_v2: Can't read info structure on device %s.\n", |
| 82 | sb->s_id); | 107 | sb->s_id); |
| 83 | return -1; | 108 | return -1; |
| 84 | } | 109 | } |
| @@ -89,9 +114,15 @@ static int v2_read_file_info(struct super_block *sb, int type) | |||
| 89 | return -1; | 114 | return -1; |
| 90 | } | 115 | } |
| 91 | qinfo = info->dqi_priv; | 116 | qinfo = info->dqi_priv; |
| 92 | /* limits are stored as unsigned 32-bit data */ | 117 | if (version == 0) { |
| 93 | info->dqi_maxblimit = 0xffffffff; | 118 | /* limits are stored as unsigned 32-bit data */ |
| 94 | info->dqi_maxilimit = 0xffffffff; | 119 | info->dqi_maxblimit = 0xffffffff; |
| 120 | info->dqi_maxilimit = 0xffffffff; | ||
| 121 | } else { | ||
| 122 | /* used space is stored as unsigned 64-bit value */ | ||
| 123 | info->dqi_maxblimit = 0xffffffffffffffff; /* 2^64-1 */ | ||
| 124 | info->dqi_maxilimit = 0xffffffffffffffff; | ||
| 125 | } | ||
| 95 | info->dqi_bgrace = le32_to_cpu(dinfo.dqi_bgrace); | 126 | info->dqi_bgrace = le32_to_cpu(dinfo.dqi_bgrace); |
| 96 | info->dqi_igrace = le32_to_cpu(dinfo.dqi_igrace); | 127 | info->dqi_igrace = le32_to_cpu(dinfo.dqi_igrace); |
| 97 | info->dqi_flags = le32_to_cpu(dinfo.dqi_flags); | 128 | info->dqi_flags = le32_to_cpu(dinfo.dqi_flags); |
| @@ -103,8 +134,13 @@ static int v2_read_file_info(struct super_block *sb, int type) | |||
| 103 | qinfo->dqi_blocksize_bits = V2_DQBLKSIZE_BITS; | 134 | qinfo->dqi_blocksize_bits = V2_DQBLKSIZE_BITS; |
| 104 | qinfo->dqi_usable_bs = 1 << V2_DQBLKSIZE_BITS; | 135 | qinfo->dqi_usable_bs = 1 << V2_DQBLKSIZE_BITS; |
| 105 | qinfo->dqi_qtree_depth = qtree_depth(qinfo); | 136 | qinfo->dqi_qtree_depth = qtree_depth(qinfo); |
| 106 | qinfo->dqi_entry_size = sizeof(struct v2_disk_dqblk); | 137 | if (version == 0) { |
| 107 | qinfo->dqi_ops = &v2_qtree_ops; | 138 | qinfo->dqi_entry_size = sizeof(struct v2r0_disk_dqblk); |
| 139 | qinfo->dqi_ops = &v2r0_qtree_ops; | ||
| 140 | } else { | ||
| 141 | qinfo->dqi_entry_size = sizeof(struct v2r1_disk_dqblk); | ||
| 142 | qinfo->dqi_ops = &v2r1_qtree_ops; | ||
| 143 | } | ||
| 108 | return 0; | 144 | return 0; |
| 109 | } | 145 | } |
| 110 | 146 | ||
| @@ -135,9 +171,9 @@ static int v2_write_file_info(struct super_block *sb, int type) | |||
| 135 | return 0; | 171 | return 0; |
| 136 | } | 172 | } |
| 137 | 173 | ||
| 138 | static void v2_disk2memdqb(struct dquot *dquot, void *dp) | 174 | static void v2r0_disk2memdqb(struct dquot *dquot, void *dp) |
| 139 | { | 175 | { |
| 140 | struct v2_disk_dqblk *d = dp, empty; | 176 | struct v2r0_disk_dqblk *d = dp, empty; |
| 141 | struct mem_dqblk *m = &dquot->dq_dqb; | 177 | struct mem_dqblk *m = &dquot->dq_dqb; |
| 142 | 178 | ||
| 143 | m->dqb_ihardlimit = le32_to_cpu(d->dqb_ihardlimit); | 179 | m->dqb_ihardlimit = le32_to_cpu(d->dqb_ihardlimit); |
| @@ -149,15 +185,15 @@ static void v2_disk2memdqb(struct dquot *dquot, void *dp) | |||
| 149 | m->dqb_curspace = le64_to_cpu(d->dqb_curspace); | 185 | m->dqb_curspace = le64_to_cpu(d->dqb_curspace); |
| 150 | m->dqb_btime = le64_to_cpu(d->dqb_btime); | 186 | m->dqb_btime = le64_to_cpu(d->dqb_btime); |
| 151 | /* We need to escape back all-zero structure */ | 187 | /* We need to escape back all-zero structure */ |
| 152 | memset(&empty, 0, sizeof(struct v2_disk_dqblk)); | 188 | memset(&empty, 0, sizeof(struct v2r0_disk_dqblk)); |
| 153 | empty.dqb_itime = cpu_to_le64(1); | 189 | empty.dqb_itime = cpu_to_le64(1); |
| 154 | if (!memcmp(&empty, dp, sizeof(struct v2_disk_dqblk))) | 190 | if (!memcmp(&empty, dp, sizeof(struct v2r0_disk_dqblk))) |
| 155 | m->dqb_itime = 0; | 191 | m->dqb_itime = 0; |
| 156 | } | 192 | } |
| 157 | 193 | ||
| 158 | static void v2_mem2diskdqb(void *dp, struct dquot *dquot) | 194 | static void v2r0_mem2diskdqb(void *dp, struct dquot *dquot) |
| 159 | { | 195 | { |
| 160 | struct v2_disk_dqblk *d = dp; | 196 | struct v2r0_disk_dqblk *d = dp; |
| 161 | struct mem_dqblk *m = &dquot->dq_dqb; | 197 | struct mem_dqblk *m = &dquot->dq_dqb; |
| 162 | struct qtree_mem_dqinfo *info = | 198 | struct qtree_mem_dqinfo *info = |
| 163 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; | 199 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; |
| @@ -175,9 +211,60 @@ static void v2_mem2diskdqb(void *dp, struct dquot *dquot) | |||
| 175 | d->dqb_itime = cpu_to_le64(1); | 211 | d->dqb_itime = cpu_to_le64(1); |
| 176 | } | 212 | } |
| 177 | 213 | ||
| 178 | static int v2_is_id(void *dp, struct dquot *dquot) | 214 | static int v2r0_is_id(void *dp, struct dquot *dquot) |
| 215 | { | ||
| 216 | struct v2r0_disk_dqblk *d = dp; | ||
| 217 | struct qtree_mem_dqinfo *info = | ||
| 218 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; | ||
| 219 | |||
| 220 | if (qtree_entry_unused(info, dp)) | ||
| 221 | return 0; | ||
| 222 | return le32_to_cpu(d->dqb_id) == dquot->dq_id; | ||
| 223 | } | ||
| 224 | |||
| 225 | static void v2r1_disk2memdqb(struct dquot *dquot, void *dp) | ||
| 226 | { | ||
| 227 | struct v2r1_disk_dqblk *d = dp, empty; | ||
| 228 | struct mem_dqblk *m = &dquot->dq_dqb; | ||
| 229 | |||
| 230 | m->dqb_ihardlimit = le64_to_cpu(d->dqb_ihardlimit); | ||
| 231 | m->dqb_isoftlimit = le64_to_cpu(d->dqb_isoftlimit); | ||
| 232 | m->dqb_curinodes = le64_to_cpu(d->dqb_curinodes); | ||
| 233 | m->dqb_itime = le64_to_cpu(d->dqb_itime); | ||
| 234 | m->dqb_bhardlimit = v2_qbtos(le64_to_cpu(d->dqb_bhardlimit)); | ||
| 235 | m->dqb_bsoftlimit = v2_qbtos(le64_to_cpu(d->dqb_bsoftlimit)); | ||
| 236 | m->dqb_curspace = le64_to_cpu(d->dqb_curspace); | ||
| 237 | m->dqb_btime = le64_to_cpu(d->dqb_btime); | ||
| 238 | /* We need to escape back all-zero structure */ | ||
| 239 | memset(&empty, 0, sizeof(struct v2r1_disk_dqblk)); | ||
| 240 | empty.dqb_itime = cpu_to_le64(1); | ||
| 241 | if (!memcmp(&empty, dp, sizeof(struct v2r1_disk_dqblk))) | ||
| 242 | m->dqb_itime = 0; | ||
| 243 | } | ||
| 244 | |||
| 245 | static void v2r1_mem2diskdqb(void *dp, struct dquot *dquot) | ||
| 246 | { | ||
| 247 | struct v2r1_disk_dqblk *d = dp; | ||
| 248 | struct mem_dqblk *m = &dquot->dq_dqb; | ||
| 249 | struct qtree_mem_dqinfo *info = | ||
| 250 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; | ||
| 251 | |||
| 252 | d->dqb_ihardlimit = cpu_to_le64(m->dqb_ihardlimit); | ||
| 253 | d->dqb_isoftlimit = cpu_to_le64(m->dqb_isoftlimit); | ||
| 254 | d->dqb_curinodes = cpu_to_le64(m->dqb_curinodes); | ||
| 255 | d->dqb_itime = cpu_to_le64(m->dqb_itime); | ||
| 256 | d->dqb_bhardlimit = cpu_to_le64(v2_stoqb(m->dqb_bhardlimit)); | ||
| 257 | d->dqb_bsoftlimit = cpu_to_le64(v2_stoqb(m->dqb_bsoftlimit)); | ||
| 258 | d->dqb_curspace = cpu_to_le64(m->dqb_curspace); | ||
| 259 | d->dqb_btime = cpu_to_le64(m->dqb_btime); | ||
| 260 | d->dqb_id = cpu_to_le32(dquot->dq_id); | ||
| 261 | if (qtree_entry_unused(info, dp)) | ||
| 262 | d->dqb_itime = cpu_to_le64(1); | ||
| 263 | } | ||
| 264 | |||
| 265 | static int v2r1_is_id(void *dp, struct dquot *dquot) | ||
| 179 | { | 266 | { |
| 180 | struct v2_disk_dqblk *d = dp; | 267 | struct v2r1_disk_dqblk *d = dp; |
| 181 | struct qtree_mem_dqinfo *info = | 268 | struct qtree_mem_dqinfo *info = |
| 182 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; | 269 | sb_dqinfo(dquot->dq_sb, dquot->dq_type)->dqi_priv; |
| 183 | 270 | ||
| @@ -207,7 +294,7 @@ static int v2_free_file_info(struct super_block *sb, int type) | |||
| 207 | return 0; | 294 | return 0; |
| 208 | } | 295 | } |
| 209 | 296 | ||
| 210 | static struct quota_format_ops v2_format_ops = { | 297 | static const struct quota_format_ops v2_format_ops = { |
| 211 | .check_quota_file = v2_check_quota_file, | 298 | .check_quota_file = v2_check_quota_file, |
| 212 | .read_file_info = v2_read_file_info, | 299 | .read_file_info = v2_read_file_info, |
| 213 | .write_file_info = v2_write_file_info, | 300 | .write_file_info = v2_write_file_info, |
| @@ -217,20 +304,32 @@ static struct quota_format_ops v2_format_ops = { | |||
| 217 | .release_dqblk = v2_release_dquot, | 304 | .release_dqblk = v2_release_dquot, |
| 218 | }; | 305 | }; |
| 219 | 306 | ||
| 220 | static struct quota_format_type v2_quota_format = { | 307 | static struct quota_format_type v2r0_quota_format = { |
| 221 | .qf_fmt_id = QFMT_VFS_V0, | 308 | .qf_fmt_id = QFMT_VFS_V0, |
| 222 | .qf_ops = &v2_format_ops, | 309 | .qf_ops = &v2_format_ops, |
| 223 | .qf_owner = THIS_MODULE | 310 | .qf_owner = THIS_MODULE |
| 224 | }; | 311 | }; |
| 225 | 312 | ||
| 313 | static struct quota_format_type v2r1_quota_format = { | ||
| 314 | .qf_fmt_id = QFMT_VFS_V1, | ||
| 315 | .qf_ops = &v2_format_ops, | ||
| 316 | .qf_owner = THIS_MODULE | ||
| 317 | }; | ||
| 318 | |||
| 226 | static int __init init_v2_quota_format(void) | 319 | static int __init init_v2_quota_format(void) |
| 227 | { | 320 | { |
| 228 | return register_quota_format(&v2_quota_format); | 321 | int ret; |
| 322 | |||
| 323 | ret = register_quota_format(&v2r0_quota_format); | ||
| 324 | if (ret) | ||
| 325 | return ret; | ||
| 326 | return register_quota_format(&v2r1_quota_format); | ||
| 229 | } | 327 | } |
| 230 | 328 | ||
| 231 | static void __exit exit_v2_quota_format(void) | 329 | static void __exit exit_v2_quota_format(void) |
| 232 | { | 330 | { |
| 233 | unregister_quota_format(&v2_quota_format); | 331 | unregister_quota_format(&v2r0_quota_format); |
| 332 | unregister_quota_format(&v2r1_quota_format); | ||
| 234 | } | 333 | } |
| 235 | 334 | ||
| 236 | module_init(init_v2_quota_format); | 335 | module_init(init_v2_quota_format); |
diff --git a/fs/quota/quotaio_v2.h b/fs/quota/quotaio_v2.h index 530fe580685c..f1966b42c2fd 100644 --- a/fs/quota/quotaio_v2.h +++ b/fs/quota/quotaio_v2.h | |||
| @@ -17,8 +17,8 @@ | |||
| 17 | } | 17 | } |
| 18 | 18 | ||
| 19 | #define V2_INITQVERSIONS {\ | 19 | #define V2_INITQVERSIONS {\ |
| 20 | 0, /* USRQUOTA */\ | 20 | 1, /* USRQUOTA */\ |
| 21 | 0 /* GRPQUOTA */\ | 21 | 1 /* GRPQUOTA */\ |
| 22 | } | 22 | } |
| 23 | 23 | ||
| 24 | /* First generic header */ | 24 | /* First generic header */ |
| @@ -32,7 +32,7 @@ struct v2_disk_dqheader { | |||
| 32 | * (as it appears on disk) - the file is a radix tree whose leaves point | 32 | * (as it appears on disk) - the file is a radix tree whose leaves point |
| 33 | * to blocks of these structures. | 33 | * to blocks of these structures. |
| 34 | */ | 34 | */ |
| 35 | struct v2_disk_dqblk { | 35 | struct v2r0_disk_dqblk { |
| 36 | __le32 dqb_id; /* id this quota applies to */ | 36 | __le32 dqb_id; /* id this quota applies to */ |
| 37 | __le32 dqb_ihardlimit; /* absolute limit on allocated inodes */ | 37 | __le32 dqb_ihardlimit; /* absolute limit on allocated inodes */ |
| 38 | __le32 dqb_isoftlimit; /* preferred inode limit */ | 38 | __le32 dqb_isoftlimit; /* preferred inode limit */ |
| @@ -44,6 +44,19 @@ struct v2_disk_dqblk { | |||
| 44 | __le64 dqb_itime; /* time limit for excessive inode use */ | 44 | __le64 dqb_itime; /* time limit for excessive inode use */ |
| 45 | }; | 45 | }; |
| 46 | 46 | ||
| 47 | struct v2r1_disk_dqblk { | ||
| 48 | __le32 dqb_id; /* id this quota applies to */ | ||
| 49 | __le32 dqb_pad; | ||
| 50 | __le64 dqb_ihardlimit; /* absolute limit on allocated inodes */ | ||
| 51 | __le64 dqb_isoftlimit; /* preferred inode limit */ | ||
| 52 | __le64 dqb_curinodes; /* current # allocated inodes */ | ||
| 53 | __le64 dqb_bhardlimit; /* absolute limit on disk space (in QUOTABLOCK_SIZE) */ | ||
| 54 | __le64 dqb_bsoftlimit; /* preferred limit on disk space (in QUOTABLOCK_SIZE) */ | ||
| 55 | __le64 dqb_curspace; /* current space occupied (in bytes) */ | ||
| 56 | __le64 dqb_btime; /* time limit for excessive disk use */ | ||
| 57 | __le64 dqb_itime; /* time limit for excessive inode use */ | ||
| 58 | }; | ||
| 59 | |||
| 47 | /* Header with type and version specific information */ | 60 | /* Header with type and version specific information */ |
| 48 | struct v2_disk_dqinfo { | 61 | struct v2_disk_dqinfo { |
| 49 | __le32 dqi_bgrace; /* Time before block soft limit becomes hard limit */ | 62 | __le32 dqi_bgrace; /* Time before block soft limit becomes hard limit */ |
diff --git a/fs/read_write.c b/fs/read_write.c index 3ac28987f22a..b7f4a1f94d48 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
| @@ -826,8 +826,6 @@ static ssize_t do_sendfile(int out_fd, int in_fd, loff_t *ppos, | |||
| 826 | if (!(out_file->f_mode & FMODE_WRITE)) | 826 | if (!(out_file->f_mode & FMODE_WRITE)) |
| 827 | goto fput_out; | 827 | goto fput_out; |
| 828 | retval = -EINVAL; | 828 | retval = -EINVAL; |
| 829 | if (!out_file->f_op || !out_file->f_op->sendpage) | ||
| 830 | goto fput_out; | ||
| 831 | in_inode = in_file->f_path.dentry->d_inode; | 829 | in_inode = in_file->f_path.dentry->d_inode; |
| 832 | out_inode = out_file->f_path.dentry->d_inode; | 830 | out_inode = out_file->f_path.dentry->d_inode; |
| 833 | retval = rw_verify_area(WRITE, out_file, &out_file->f_pos, count); | 831 | retval = rw_verify_area(WRITE, out_file, &out_file->f_pos, count); |
diff --git a/fs/reiserfs/Kconfig b/fs/reiserfs/Kconfig index 513f431038f9..ac7cd75c86f8 100644 --- a/fs/reiserfs/Kconfig +++ b/fs/reiserfs/Kconfig | |||
| @@ -1,6 +1,7 @@ | |||
| 1 | config REISERFS_FS | 1 | config REISERFS_FS |
| 2 | tristate "Reiserfs support" | 2 | tristate "Reiserfs support" |
| 3 | select CRC32 | 3 | select CRC32 |
| 4 | select FS_JOURNAL_INFO | ||
| 4 | help | 5 | help |
| 5 | Stores not just filenames but the files themselves in a balanced | 6 | Stores not just filenames but the files themselves in a balanced |
| 6 | tree. Uses journalling. | 7 | tree. Uses journalling. |
diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile index 7c5ab6330dd6..6a9e30c041dd 100644 --- a/fs/reiserfs/Makefile +++ b/fs/reiserfs/Makefile | |||
| @@ -7,7 +7,7 @@ obj-$(CONFIG_REISERFS_FS) += reiserfs.o | |||
| 7 | reiserfs-objs := bitmap.o do_balan.o namei.o inode.o file.o dir.o fix_node.o \ | 7 | reiserfs-objs := bitmap.o do_balan.o namei.o inode.o file.o dir.o fix_node.o \ |
| 8 | super.o prints.o objectid.o lbalance.o ibalance.o stree.o \ | 8 | super.o prints.o objectid.o lbalance.o ibalance.o stree.o \ |
| 9 | hashes.o tail_conversion.o journal.o resize.o \ | 9 | hashes.o tail_conversion.o journal.o resize.o \ |
| 10 | item_ops.o ioctl.o procfs.o xattr.o | 10 | item_ops.o ioctl.o procfs.o xattr.o lock.o |
| 11 | 11 | ||
| 12 | ifeq ($(CONFIG_REISERFS_FS_XATTR),y) | 12 | ifeq ($(CONFIG_REISERFS_FS_XATTR),y) |
| 13 | reiserfs-objs += xattr_user.o xattr_trusted.o | 13 | reiserfs-objs += xattr_user.o xattr_trusted.o |
diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c index e716161ab325..685495707181 100644 --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c | |||
| @@ -1249,14 +1249,18 @@ struct buffer_head *reiserfs_read_bitmap_block(struct super_block *sb, | |||
| 1249 | else if (bitmap == 0) | 1249 | else if (bitmap == 0) |
| 1250 | block = (REISERFS_DISK_OFFSET_IN_BYTES >> sb->s_blocksize_bits) + 1; | 1250 | block = (REISERFS_DISK_OFFSET_IN_BYTES >> sb->s_blocksize_bits) + 1; |
| 1251 | 1251 | ||
| 1252 | reiserfs_write_unlock(sb); | ||
| 1252 | bh = sb_bread(sb, block); | 1253 | bh = sb_bread(sb, block); |
| 1254 | reiserfs_write_lock(sb); | ||
| 1253 | if (bh == NULL) | 1255 | if (bh == NULL) |
| 1254 | reiserfs_warning(sb, "sh-2029: %s: bitmap block (#%u) " | 1256 | reiserfs_warning(sb, "sh-2029: %s: bitmap block (#%u) " |
| 1255 | "reading failed", __func__, block); | 1257 | "reading failed", __func__, block); |
| 1256 | else { | 1258 | else { |
| 1257 | if (buffer_locked(bh)) { | 1259 | if (buffer_locked(bh)) { |
| 1258 | PROC_INFO_INC(sb, scan_bitmap.wait); | 1260 | PROC_INFO_INC(sb, scan_bitmap.wait); |
| 1261 | reiserfs_write_unlock(sb); | ||
| 1259 | __wait_on_buffer(bh); | 1262 | __wait_on_buffer(bh); |
| 1263 | reiserfs_write_lock(sb); | ||
| 1260 | } | 1264 | } |
| 1261 | BUG_ON(!buffer_uptodate(bh)); | 1265 | BUG_ON(!buffer_uptodate(bh)); |
| 1262 | BUG_ON(atomic_read(&bh->b_count) == 0); | 1266 | BUG_ON(atomic_read(&bh->b_count) == 0); |
diff --git a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c index 6d2668fdc384..c094f58c7448 100644 --- a/fs/reiserfs/dir.c +++ b/fs/reiserfs/dir.c | |||
| @@ -20,7 +20,7 @@ const struct file_operations reiserfs_dir_operations = { | |||
| 20 | .read = generic_read_dir, | 20 | .read = generic_read_dir, |
| 21 | .readdir = reiserfs_readdir, | 21 | .readdir = reiserfs_readdir, |
| 22 | .fsync = reiserfs_dir_fsync, | 22 | .fsync = reiserfs_dir_fsync, |
| 23 | .ioctl = reiserfs_ioctl, | 23 | .unlocked_ioctl = reiserfs_ioctl, |
| 24 | #ifdef CONFIG_COMPAT | 24 | #ifdef CONFIG_COMPAT |
| 25 | .compat_ioctl = reiserfs_compat_ioctl, | 25 | .compat_ioctl = reiserfs_compat_ioctl, |
| 26 | #endif | 26 | #endif |
| @@ -174,14 +174,22 @@ int reiserfs_readdir_dentry(struct dentry *dentry, void *dirent, | |||
| 174 | // user space buffer is swapped out. At that time | 174 | // user space buffer is swapped out. At that time |
| 175 | // entry can move to somewhere else | 175 | // entry can move to somewhere else |
| 176 | memcpy(local_buf, d_name, d_reclen); | 176 | memcpy(local_buf, d_name, d_reclen); |
| 177 | |||
| 178 | /* | ||
| 179 | * Since filldir might sleep, we can release | ||
| 180 | * the write lock here for other waiters | ||
| 181 | */ | ||
| 182 | reiserfs_write_unlock(inode->i_sb); | ||
| 177 | if (filldir | 183 | if (filldir |
| 178 | (dirent, local_buf, d_reclen, d_off, d_ino, | 184 | (dirent, local_buf, d_reclen, d_off, d_ino, |
| 179 | DT_UNKNOWN) < 0) { | 185 | DT_UNKNOWN) < 0) { |
| 186 | reiserfs_write_lock(inode->i_sb); | ||
| 180 | if (local_buf != small_buf) { | 187 | if (local_buf != small_buf) { |
| 181 | kfree(local_buf); | 188 | kfree(local_buf); |
| 182 | } | 189 | } |
| 183 | goto end; | 190 | goto end; |
| 184 | } | 191 | } |
| 192 | reiserfs_write_lock(inode->i_sb); | ||
| 185 | if (local_buf != small_buf) { | 193 | if (local_buf != small_buf) { |
| 186 | kfree(local_buf); | 194 | kfree(local_buf); |
| 187 | } | 195 | } |
diff --git a/fs/reiserfs/do_balan.c b/fs/reiserfs/do_balan.c index 128d3f7c8aa5..60c080440661 100644 --- a/fs/reiserfs/do_balan.c +++ b/fs/reiserfs/do_balan.c | |||
| @@ -21,14 +21,6 @@ | |||
| 21 | #include <linux/buffer_head.h> | 21 | #include <linux/buffer_head.h> |
| 22 | #include <linux/kernel.h> | 22 | #include <linux/kernel.h> |
| 23 | 23 | ||
| 24 | #ifdef CONFIG_REISERFS_CHECK | ||
| 25 | |||
| 26 | struct tree_balance *cur_tb = NULL; /* detects whether more than one | ||
| 27 | copy of tb exists as a means | ||
| 28 | of checking whether schedule | ||
| 29 | is interrupting do_balance */ | ||
| 30 | #endif | ||
| 31 | |||
| 32 | static inline void buffer_info_init_left(struct tree_balance *tb, | 24 | static inline void buffer_info_init_left(struct tree_balance *tb, |
| 33 | struct buffer_info *bi) | 25 | struct buffer_info *bi) |
| 34 | { | 26 | { |
| @@ -1840,11 +1832,12 @@ static int check_before_balancing(struct tree_balance *tb) | |||
| 1840 | { | 1832 | { |
| 1841 | int retval = 0; | 1833 | int retval = 0; |
| 1842 | 1834 | ||
| 1843 | if (cur_tb) { | 1835 | if (REISERFS_SB(tb->tb_sb)->cur_tb) { |
| 1844 | reiserfs_panic(tb->tb_sb, "vs-12335", "suspect that schedule " | 1836 | reiserfs_panic(tb->tb_sb, "vs-12335", "suspect that schedule " |
| 1845 | "occurred based on cur_tb not being null at " | 1837 | "occurred based on cur_tb not being null at " |
| 1846 | "this point in code. do_balance cannot properly " | 1838 | "this point in code. do_balance cannot properly " |
| 1847 | "handle schedule occurring while it runs."); | 1839 | "handle concurrent tree accesses on a same " |
| 1840 | "mount point."); | ||
| 1848 | } | 1841 | } |
| 1849 | 1842 | ||
| 1850 | /* double check that buffers that we will modify are unlocked. (fix_nodes should already have | 1843 | /* double check that buffers that we will modify are unlocked. (fix_nodes should already have |
| @@ -1986,7 +1979,7 @@ static inline void do_balance_starts(struct tree_balance *tb) | |||
| 1986 | "check");*/ | 1979 | "check");*/ |
| 1987 | RFALSE(check_before_balancing(tb), "PAP-12340: locked buffers in TB"); | 1980 | RFALSE(check_before_balancing(tb), "PAP-12340: locked buffers in TB"); |
| 1988 | #ifdef CONFIG_REISERFS_CHECK | 1981 | #ifdef CONFIG_REISERFS_CHECK |
| 1989 | cur_tb = tb; | 1982 | REISERFS_SB(tb->tb_sb)->cur_tb = tb; |
| 1990 | #endif | 1983 | #endif |
| 1991 | } | 1984 | } |
| 1992 | 1985 | ||
| @@ -1996,7 +1989,7 @@ static inline void do_balance_completed(struct tree_balance *tb) | |||
| 1996 | #ifdef CONFIG_REISERFS_CHECK | 1989 | #ifdef CONFIG_REISERFS_CHECK |
| 1997 | check_leaf_level(tb); | 1990 | check_leaf_level(tb); |
| 1998 | check_internal_levels(tb); | 1991 | check_internal_levels(tb); |
| 1999 | cur_tb = NULL; | 1992 | REISERFS_SB(tb->tb_sb)->cur_tb = NULL; |
| 2000 | #endif | 1993 | #endif |
| 2001 | 1994 | ||
| 2002 | /* reiserfs_free_block is no longer schedule safe. So, we need to | 1995 | /* reiserfs_free_block is no longer schedule safe. So, we need to |
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c index 9f436668b7f8..da2dba082e2d 100644 --- a/fs/reiserfs/file.c +++ b/fs/reiserfs/file.c | |||
| @@ -284,7 +284,7 @@ static ssize_t reiserfs_file_write(struct file *file, /* the file we are going t | |||
| 284 | const struct file_operations reiserfs_file_operations = { | 284 | const struct file_operations reiserfs_file_operations = { |
| 285 | .read = do_sync_read, | 285 | .read = do_sync_read, |
| 286 | .write = reiserfs_file_write, | 286 | .write = reiserfs_file_write, |
| 287 | .ioctl = reiserfs_ioctl, | 287 | .unlocked_ioctl = reiserfs_ioctl, |
| 288 | #ifdef CONFIG_COMPAT | 288 | #ifdef CONFIG_COMPAT |
| 289 | .compat_ioctl = reiserfs_compat_ioctl, | 289 | .compat_ioctl = reiserfs_compat_ioctl, |
| 290 | #endif | 290 | #endif |
diff --git a/fs/reiserfs/fix_node.c b/fs/reiserfs/fix_node.c index 5e5a4e6fbaf8..6591cb21edf6 100644 --- a/fs/reiserfs/fix_node.c +++ b/fs/reiserfs/fix_node.c | |||
| @@ -563,9 +563,6 @@ static int get_num_ver(int mode, struct tree_balance *tb, int h, | |||
| 563 | return needed_nodes; | 563 | return needed_nodes; |
| 564 | } | 564 | } |
| 565 | 565 | ||
| 566 | #ifdef CONFIG_REISERFS_CHECK | ||
| 567 | extern struct tree_balance *cur_tb; | ||
| 568 | #endif | ||
| 569 | 566 | ||
| 570 | /* Set parameters for balancing. | 567 | /* Set parameters for balancing. |
| 571 | * Performs write of results of analysis of balancing into structure tb, | 568 | * Performs write of results of analysis of balancing into structure tb, |
| @@ -834,7 +831,7 @@ static int get_empty_nodes(struct tree_balance *tb, int h) | |||
| 834 | RFALSE(buffer_dirty(new_bh) || | 831 | RFALSE(buffer_dirty(new_bh) || |
| 835 | buffer_journaled(new_bh) || | 832 | buffer_journaled(new_bh) || |
| 836 | buffer_journal_dirty(new_bh), | 833 | buffer_journal_dirty(new_bh), |
| 837 | "PAP-8140: journlaled or dirty buffer %b for the new block", | 834 | "PAP-8140: journaled or dirty buffer %b for the new block", |
| 838 | new_bh); | 835 | new_bh); |
| 839 | 836 | ||
| 840 | /* Put empty buffers into the array. */ | 837 | /* Put empty buffers into the array. */ |
| @@ -1022,7 +1019,11 @@ static int get_far_parent(struct tree_balance *tb, | |||
| 1022 | /* Check whether the common parent is locked. */ | 1019 | /* Check whether the common parent is locked. */ |
| 1023 | 1020 | ||
| 1024 | if (buffer_locked(*pcom_father)) { | 1021 | if (buffer_locked(*pcom_father)) { |
| 1022 | |||
| 1023 | /* Release the write lock while the buffer is busy */ | ||
| 1024 | reiserfs_write_unlock(tb->tb_sb); | ||
| 1025 | __wait_on_buffer(*pcom_father); | 1025 | __wait_on_buffer(*pcom_father); |
| 1026 | reiserfs_write_lock(tb->tb_sb); | ||
| 1026 | if (FILESYSTEM_CHANGED_TB(tb)) { | 1027 | if (FILESYSTEM_CHANGED_TB(tb)) { |
| 1027 | brelse(*pcom_father); | 1028 | brelse(*pcom_father); |
| 1028 | return REPEAT_SEARCH; | 1029 | return REPEAT_SEARCH; |
| @@ -1927,7 +1928,9 @@ static int get_direct_parent(struct tree_balance *tb, int h) | |||
| 1927 | return REPEAT_SEARCH; | 1928 | return REPEAT_SEARCH; |
| 1928 | 1929 | ||
| 1929 | if (buffer_locked(bh)) { | 1930 | if (buffer_locked(bh)) { |
| 1931 | reiserfs_write_unlock(tb->tb_sb); | ||
| 1930 | __wait_on_buffer(bh); | 1932 | __wait_on_buffer(bh); |
| 1933 | reiserfs_write_lock(tb->tb_sb); | ||
| 1931 | if (FILESYSTEM_CHANGED_TB(tb)) | 1934 | if (FILESYSTEM_CHANGED_TB(tb)) |
| 1932 | return REPEAT_SEARCH; | 1935 | return REPEAT_SEARCH; |
| 1933 | } | 1936 | } |
| @@ -1965,7 +1968,9 @@ static int get_neighbors(struct tree_balance *tb, int h) | |||
| 1965 | tb->FL[h]) ? tb->lkey[h] : B_NR_ITEMS(tb-> | 1968 | tb->FL[h]) ? tb->lkey[h] : B_NR_ITEMS(tb-> |
| 1966 | FL[h]); | 1969 | FL[h]); |
| 1967 | son_number = B_N_CHILD_NUM(tb->FL[h], child_position); | 1970 | son_number = B_N_CHILD_NUM(tb->FL[h], child_position); |
| 1971 | reiserfs_write_unlock(sb); | ||
| 1968 | bh = sb_bread(sb, son_number); | 1972 | bh = sb_bread(sb, son_number); |
| 1973 | reiserfs_write_lock(sb); | ||
| 1969 | if (!bh) | 1974 | if (!bh) |
| 1970 | return IO_ERROR; | 1975 | return IO_ERROR; |
| 1971 | if (FILESYSTEM_CHANGED_TB(tb)) { | 1976 | if (FILESYSTEM_CHANGED_TB(tb)) { |
| @@ -2003,7 +2008,9 @@ static int get_neighbors(struct tree_balance *tb, int h) | |||
| 2003 | child_position = | 2008 | child_position = |
| 2004 | (bh == tb->FR[h]) ? tb->rkey[h] + 1 : 0; | 2009 | (bh == tb->FR[h]) ? tb->rkey[h] + 1 : 0; |
| 2005 | son_number = B_N_CHILD_NUM(tb->FR[h], child_position); | 2010 | son_number = B_N_CHILD_NUM(tb->FR[h], child_position); |
| 2011 | reiserfs_write_unlock(sb); | ||
| 2006 | bh = sb_bread(sb, son_number); | 2012 | bh = sb_bread(sb, son_number); |
| 2013 | reiserfs_write_lock(sb); | ||
| 2007 | if (!bh) | 2014 | if (!bh) |
| 2008 | return IO_ERROR; | 2015 | return IO_ERROR; |
| 2009 | if (FILESYSTEM_CHANGED_TB(tb)) { | 2016 | if (FILESYSTEM_CHANGED_TB(tb)) { |
| @@ -2278,7 +2285,9 @@ static int wait_tb_buffers_until_unlocked(struct tree_balance *tb) | |||
| 2278 | REPEAT_SEARCH : CARRY_ON; | 2285 | REPEAT_SEARCH : CARRY_ON; |
| 2279 | } | 2286 | } |
| 2280 | #endif | 2287 | #endif |
| 2288 | reiserfs_write_unlock(tb->tb_sb); | ||
| 2281 | __wait_on_buffer(locked); | 2289 | __wait_on_buffer(locked); |
| 2290 | reiserfs_write_lock(tb->tb_sb); | ||
| 2282 | if (FILESYSTEM_CHANGED_TB(tb)) | 2291 | if (FILESYSTEM_CHANGED_TB(tb)) |
| 2283 | return REPEAT_SEARCH; | 2292 | return REPEAT_SEARCH; |
| 2284 | } | 2293 | } |
| @@ -2349,12 +2358,14 @@ int fix_nodes(int op_mode, struct tree_balance *tb, | |||
| 2349 | 2358 | ||
| 2350 | /* if it possible in indirect_to_direct conversion */ | 2359 | /* if it possible in indirect_to_direct conversion */ |
| 2351 | if (buffer_locked(tbS0)) { | 2360 | if (buffer_locked(tbS0)) { |
| 2361 | reiserfs_write_unlock(tb->tb_sb); | ||
| 2352 | __wait_on_buffer(tbS0); | 2362 | __wait_on_buffer(tbS0); |
| 2363 | reiserfs_write_lock(tb->tb_sb); | ||
| 2353 | if (FILESYSTEM_CHANGED_TB(tb)) | 2364 | if (FILESYSTEM_CHANGED_TB(tb)) |
| 2354 | return REPEAT_SEARCH; | 2365 | return REPEAT_SEARCH; |
| 2355 | } | 2366 | } |
| 2356 | #ifdef CONFIG_REISERFS_CHECK | 2367 | #ifdef CONFIG_REISERFS_CHECK |
| 2357 | if (cur_tb) { | 2368 | if (REISERFS_SB(tb->tb_sb)->cur_tb) { |
| 2358 | print_cur_tb("fix_nodes"); | 2369 | print_cur_tb("fix_nodes"); |
| 2359 | reiserfs_panic(tb->tb_sb, "PAP-8305", | 2370 | reiserfs_panic(tb->tb_sb, "PAP-8305", |
| 2360 | "there is pending do_balance"); | 2371 | "there is pending do_balance"); |
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index a14d6cd9eeda..3a28e7751b3c 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
| @@ -251,7 +251,6 @@ static int _get_block_create_0(struct inode *inode, sector_t block, | |||
| 251 | struct cpu_key key; | 251 | struct cpu_key key; |
| 252 | struct buffer_head *bh; | 252 | struct buffer_head *bh; |
| 253 | struct item_head *ih, tmp_ih; | 253 | struct item_head *ih, tmp_ih; |
| 254 | int fs_gen; | ||
| 255 | b_blocknr_t blocknr; | 254 | b_blocknr_t blocknr; |
| 256 | char *p = NULL; | 255 | char *p = NULL; |
| 257 | int chars; | 256 | int chars; |
| @@ -265,7 +264,6 @@ static int _get_block_create_0(struct inode *inode, sector_t block, | |||
| 265 | (loff_t) block * inode->i_sb->s_blocksize + 1, TYPE_ANY, | 264 | (loff_t) block * inode->i_sb->s_blocksize + 1, TYPE_ANY, |
| 266 | 3); | 265 | 3); |
| 267 | 266 | ||
| 268 | research: | ||
| 269 | result = search_for_position_by_key(inode->i_sb, &key, &path); | 267 | result = search_for_position_by_key(inode->i_sb, &key, &path); |
| 270 | if (result != POSITION_FOUND) { | 268 | if (result != POSITION_FOUND) { |
| 271 | pathrelse(&path); | 269 | pathrelse(&path); |
| @@ -340,7 +338,6 @@ static int _get_block_create_0(struct inode *inode, sector_t block, | |||
| 340 | } | 338 | } |
| 341 | // read file tail into part of page | 339 | // read file tail into part of page |
| 342 | offset = (cpu_key_k_offset(&key) - 1) & (PAGE_CACHE_SIZE - 1); | 340 | offset = (cpu_key_k_offset(&key) - 1) & (PAGE_CACHE_SIZE - 1); |
| 343 | fs_gen = get_generation(inode->i_sb); | ||
| 344 | copy_item_head(&tmp_ih, ih); | 341 | copy_item_head(&tmp_ih, ih); |
| 345 | 342 | ||
| 346 | /* we only want to kmap if we are reading the tail into the page. | 343 | /* we only want to kmap if we are reading the tail into the page. |
| @@ -348,13 +345,9 @@ static int _get_block_create_0(struct inode *inode, sector_t block, | |||
| 348 | ** sure we need to. But, this means the item might move if | 345 | ** sure we need to. But, this means the item might move if |
| 349 | ** kmap schedules | 346 | ** kmap schedules |
| 350 | */ | 347 | */ |
| 351 | if (!p) { | 348 | if (!p) |
| 352 | p = (char *)kmap(bh_result->b_page); | 349 | p = (char *)kmap(bh_result->b_page); |
| 353 | if (fs_changed(fs_gen, inode->i_sb) | 350 | |
| 354 | && item_moved(&tmp_ih, &path)) { | ||
| 355 | goto research; | ||
| 356 | } | ||
| 357 | } | ||
| 358 | p += offset; | 351 | p += offset; |
| 359 | memset(p, 0, inode->i_sb->s_blocksize); | 352 | memset(p, 0, inode->i_sb->s_blocksize); |
| 360 | do { | 353 | do { |
| @@ -489,10 +482,14 @@ static int reiserfs_get_blocks_direct_io(struct inode *inode, | |||
| 489 | disappeared */ | 482 | disappeared */ |
| 490 | if (REISERFS_I(inode)->i_flags & i_pack_on_close_mask) { | 483 | if (REISERFS_I(inode)->i_flags & i_pack_on_close_mask) { |
| 491 | int err; | 484 | int err; |
| 492 | lock_kernel(); | 485 | |
| 486 | reiserfs_write_lock(inode->i_sb); | ||
| 487 | |||
| 493 | err = reiserfs_commit_for_inode(inode); | 488 | err = reiserfs_commit_for_inode(inode); |
| 494 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; | 489 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; |
| 495 | unlock_kernel(); | 490 | |
| 491 | reiserfs_write_unlock(inode->i_sb); | ||
| 492 | |||
| 496 | if (err < 0) | 493 | if (err < 0) |
| 497 | ret = err; | 494 | ret = err; |
| 498 | } | 495 | } |
| @@ -601,6 +598,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 601 | __le32 *item; | 598 | __le32 *item; |
| 602 | int done; | 599 | int done; |
| 603 | int fs_gen; | 600 | int fs_gen; |
| 601 | int lock_depth; | ||
| 604 | struct reiserfs_transaction_handle *th = NULL; | 602 | struct reiserfs_transaction_handle *th = NULL; |
| 605 | /* space reserved in transaction batch: | 603 | /* space reserved in transaction batch: |
| 606 | . 3 balancings in direct->indirect conversion | 604 | . 3 balancings in direct->indirect conversion |
| @@ -616,12 +614,11 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 616 | loff_t new_offset = | 614 | loff_t new_offset = |
| 617 | (((loff_t) block) << inode->i_sb->s_blocksize_bits) + 1; | 615 | (((loff_t) block) << inode->i_sb->s_blocksize_bits) + 1; |
| 618 | 616 | ||
| 619 | /* bad.... */ | 617 | lock_depth = reiserfs_write_lock_once(inode->i_sb); |
| 620 | reiserfs_write_lock(inode->i_sb); | ||
| 621 | version = get_inode_item_key_version(inode); | 618 | version = get_inode_item_key_version(inode); |
| 622 | 619 | ||
| 623 | if (!file_capable(inode, block)) { | 620 | if (!file_capable(inode, block)) { |
| 624 | reiserfs_write_unlock(inode->i_sb); | 621 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
| 625 | return -EFBIG; | 622 | return -EFBIG; |
| 626 | } | 623 | } |
| 627 | 624 | ||
| @@ -633,7 +630,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 633 | /* find number of block-th logical block of the file */ | 630 | /* find number of block-th logical block of the file */ |
| 634 | ret = _get_block_create_0(inode, block, bh_result, | 631 | ret = _get_block_create_0(inode, block, bh_result, |
| 635 | create | GET_BLOCK_READ_DIRECT); | 632 | create | GET_BLOCK_READ_DIRECT); |
| 636 | reiserfs_write_unlock(inode->i_sb); | 633 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
| 637 | return ret; | 634 | return ret; |
| 638 | } | 635 | } |
| 639 | /* | 636 | /* |
| @@ -751,7 +748,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 751 | if (!dangle && th) | 748 | if (!dangle && th) |
| 752 | retval = reiserfs_end_persistent_transaction(th); | 749 | retval = reiserfs_end_persistent_transaction(th); |
| 753 | 750 | ||
| 754 | reiserfs_write_unlock(inode->i_sb); | 751 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
| 755 | 752 | ||
| 756 | /* the item was found, so new blocks were not added to the file | 753 | /* the item was found, so new blocks were not added to the file |
| 757 | ** there is no need to make sure the inode is updated with this | 754 | ** there is no need to make sure the inode is updated with this |
| @@ -935,7 +932,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 935 | if (blocks_needed == 1) { | 932 | if (blocks_needed == 1) { |
| 936 | un = &unf_single; | 933 | un = &unf_single; |
| 937 | } else { | 934 | } else { |
| 938 | un = kzalloc(min(blocks_needed, max_to_insert) * UNFM_P_SIZE, GFP_ATOMIC); // We need to avoid scheduling. | 935 | un = kzalloc(min(blocks_needed, max_to_insert) * UNFM_P_SIZE, GFP_NOFS); |
| 939 | if (!un) { | 936 | if (!un) { |
| 940 | un = &unf_single; | 937 | un = &unf_single; |
| 941 | blocks_needed = 1; | 938 | blocks_needed = 1; |
| @@ -997,10 +994,16 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 997 | if (retval) | 994 | if (retval) |
| 998 | goto failure; | 995 | goto failure; |
| 999 | } | 996 | } |
| 1000 | /* inserting indirect pointers for a hole can take a | 997 | /* |
| 1001 | ** long time. reschedule if needed | 998 | * inserting indirect pointers for a hole can take a |
| 999 | * long time. reschedule if needed and also release the write | ||
| 1000 | * lock for others. | ||
| 1002 | */ | 1001 | */ |
| 1003 | cond_resched(); | 1002 | if (need_resched()) { |
| 1003 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | ||
| 1004 | schedule(); | ||
| 1005 | lock_depth = reiserfs_write_lock_once(inode->i_sb); | ||
| 1006 | } | ||
| 1004 | 1007 | ||
| 1005 | retval = search_for_position_by_key(inode->i_sb, &key, &path); | 1008 | retval = search_for_position_by_key(inode->i_sb, &key, &path); |
| 1006 | if (retval == IO_ERROR) { | 1009 | if (retval == IO_ERROR) { |
| @@ -1035,7 +1038,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, | |||
| 1035 | retval = err; | 1038 | retval = err; |
| 1036 | } | 1039 | } |
| 1037 | 1040 | ||
| 1038 | reiserfs_write_unlock(inode->i_sb); | 1041 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
| 1039 | reiserfs_check_path(&path); | 1042 | reiserfs_check_path(&path); |
| 1040 | return retval; | 1043 | return retval; |
| 1041 | } | 1044 | } |
| @@ -2072,8 +2075,9 @@ int reiserfs_truncate_file(struct inode *inode, int update_timestamps) | |||
| 2072 | int error; | 2075 | int error; |
| 2073 | struct buffer_head *bh = NULL; | 2076 | struct buffer_head *bh = NULL; |
| 2074 | int err2; | 2077 | int err2; |
| 2078 | int lock_depth; | ||
| 2075 | 2079 | ||
| 2076 | reiserfs_write_lock(inode->i_sb); | 2080 | lock_depth = reiserfs_write_lock_once(inode->i_sb); |
| 2077 | 2081 | ||
| 2078 | if (inode->i_size > 0) { | 2082 | if (inode->i_size > 0) { |
| 2079 | error = grab_tail_page(inode, &page, &bh); | 2083 | error = grab_tail_page(inode, &page, &bh); |
| @@ -2142,14 +2146,17 @@ int reiserfs_truncate_file(struct inode *inode, int update_timestamps) | |||
| 2142 | page_cache_release(page); | 2146 | page_cache_release(page); |
| 2143 | } | 2147 | } |
| 2144 | 2148 | ||
| 2145 | reiserfs_write_unlock(inode->i_sb); | 2149 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
| 2150 | |||
| 2146 | return 0; | 2151 | return 0; |
| 2147 | out: | 2152 | out: |
| 2148 | if (page) { | 2153 | if (page) { |
| 2149 | unlock_page(page); | 2154 | unlock_page(page); |
| 2150 | page_cache_release(page); | 2155 | page_cache_release(page); |
| 2151 | } | 2156 | } |
| 2152 | reiserfs_write_unlock(inode->i_sb); | 2157 | |
| 2158 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | ||
| 2159 | |||
| 2153 | return error; | 2160 | return error; |
| 2154 | } | 2161 | } |
| 2155 | 2162 | ||
| @@ -2608,7 +2615,10 @@ int reiserfs_prepare_write(struct file *f, struct page *page, | |||
| 2608 | int ret; | 2615 | int ret; |
| 2609 | int old_ref = 0; | 2616 | int old_ref = 0; |
| 2610 | 2617 | ||
| 2618 | reiserfs_write_unlock(inode->i_sb); | ||
| 2611 | reiserfs_wait_on_write_block(inode->i_sb); | 2619 | reiserfs_wait_on_write_block(inode->i_sb); |
| 2620 | reiserfs_write_lock(inode->i_sb); | ||
| 2621 | |||
| 2612 | fix_tail_page_for_writing(page); | 2622 | fix_tail_page_for_writing(page); |
| 2613 | if (reiserfs_transaction_running(inode->i_sb)) { | 2623 | if (reiserfs_transaction_running(inode->i_sb)) { |
| 2614 | struct reiserfs_transaction_handle *th; | 2624 | struct reiserfs_transaction_handle *th; |
| @@ -2664,6 +2674,8 @@ static int reiserfs_write_end(struct file *file, struct address_space *mapping, | |||
| 2664 | int update_sd = 0; | 2674 | int update_sd = 0; |
| 2665 | struct reiserfs_transaction_handle *th; | 2675 | struct reiserfs_transaction_handle *th; |
| 2666 | unsigned start; | 2676 | unsigned start; |
| 2677 | int lock_depth = 0; | ||
| 2678 | bool locked = false; | ||
| 2667 | 2679 | ||
| 2668 | if ((unsigned long)fsdata & AOP_FLAG_CONT_EXPAND) | 2680 | if ((unsigned long)fsdata & AOP_FLAG_CONT_EXPAND) |
| 2669 | pos ++; | 2681 | pos ++; |
| @@ -2690,9 +2702,11 @@ static int reiserfs_write_end(struct file *file, struct address_space *mapping, | |||
| 2690 | ** to do the i_size updates here. | 2702 | ** to do the i_size updates here. |
| 2691 | */ | 2703 | */ |
| 2692 | pos += copied; | 2704 | pos += copied; |
| 2705 | |||
| 2693 | if (pos > inode->i_size) { | 2706 | if (pos > inode->i_size) { |
| 2694 | struct reiserfs_transaction_handle myth; | 2707 | struct reiserfs_transaction_handle myth; |
| 2695 | reiserfs_write_lock(inode->i_sb); | 2708 | lock_depth = reiserfs_write_lock_once(inode->i_sb); |
| 2709 | locked = true; | ||
| 2696 | /* If the file have grown beyond the border where it | 2710 | /* If the file have grown beyond the border where it |
| 2697 | can have a tail, unmark it as needing a tail | 2711 | can have a tail, unmark it as needing a tail |
| 2698 | packing */ | 2712 | packing */ |
| @@ -2703,10 +2717,9 @@ static int reiserfs_write_end(struct file *file, struct address_space *mapping, | |||
| 2703 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; | 2717 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; |
| 2704 | 2718 | ||
| 2705 | ret = journal_begin(&myth, inode->i_sb, 1); | 2719 | ret = journal_begin(&myth, inode->i_sb, 1); |
| 2706 | if (ret) { | 2720 | if (ret) |
| 2707 | reiserfs_write_unlock(inode->i_sb); | ||
| 2708 | goto journal_error; | 2721 | goto journal_error; |
| 2709 | } | 2722 | |
| 2710 | reiserfs_update_inode_transaction(inode); | 2723 | reiserfs_update_inode_transaction(inode); |
| 2711 | inode->i_size = pos; | 2724 | inode->i_size = pos; |
| 2712 | /* | 2725 | /* |
| @@ -2718,34 +2731,36 @@ static int reiserfs_write_end(struct file *file, struct address_space *mapping, | |||
| 2718 | reiserfs_update_sd(&myth, inode); | 2731 | reiserfs_update_sd(&myth, inode); |
| 2719 | update_sd = 1; | 2732 | update_sd = 1; |
| 2720 | ret = journal_end(&myth, inode->i_sb, 1); | 2733 | ret = journal_end(&myth, inode->i_sb, 1); |
| 2721 | reiserfs_write_unlock(inode->i_sb); | ||
| 2722 | if (ret) | 2734 | if (ret) |
| 2723 | goto journal_error; | 2735 | goto journal_error; |
| 2724 | } | 2736 | } |
| 2725 | if (th) { | 2737 | if (th) { |
| 2726 | reiserfs_write_lock(inode->i_sb); | 2738 | if (!locked) { |
| 2739 | lock_depth = reiserfs_write_lock_once(inode->i_sb); | ||
| 2740 | locked = true; | ||
| 2741 | } | ||
| 2727 | if (!update_sd) | 2742 | if (!update_sd) |
| 2728 | mark_inode_dirty(inode); | 2743 | mark_inode_dirty(inode); |
| 2729 | ret = reiserfs_end_persistent_transaction(th); | 2744 | ret = reiserfs_end_persistent_transaction(th); |
| 2730 | reiserfs_write_unlock(inode->i_sb); | ||
| 2731 | if (ret) | 2745 | if (ret) |
| 2732 | goto out; | 2746 | goto out; |
| 2733 | } | 2747 | } |
| 2734 | 2748 | ||
| 2735 | out: | 2749 | out: |
| 2750 | if (locked) | ||
| 2751 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | ||
| 2736 | unlock_page(page); | 2752 | unlock_page(page); |
| 2737 | page_cache_release(page); | 2753 | page_cache_release(page); |
| 2738 | return ret == 0 ? copied : ret; | 2754 | return ret == 0 ? copied : ret; |
| 2739 | 2755 | ||
| 2740 | journal_error: | 2756 | journal_error: |
| 2757 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | ||
| 2758 | locked = false; | ||
| 2741 | if (th) { | 2759 | if (th) { |
| 2742 | reiserfs_write_lock(inode->i_sb); | ||
| 2743 | if (!update_sd) | 2760 | if (!update_sd) |
| 2744 | reiserfs_update_sd(th, inode); | 2761 | reiserfs_update_sd(th, inode); |
| 2745 | ret = reiserfs_end_persistent_transaction(th); | 2762 | ret = reiserfs_end_persistent_transaction(th); |
| 2746 | reiserfs_write_unlock(inode->i_sb); | ||
| 2747 | } | 2763 | } |
| 2748 | |||
| 2749 | goto out; | 2764 | goto out; |
| 2750 | } | 2765 | } |
| 2751 | 2766 | ||
| @@ -2758,7 +2773,10 @@ int reiserfs_commit_write(struct file *f, struct page *page, | |||
| 2758 | int update_sd = 0; | 2773 | int update_sd = 0; |
| 2759 | struct reiserfs_transaction_handle *th = NULL; | 2774 | struct reiserfs_transaction_handle *th = NULL; |
| 2760 | 2775 | ||
| 2776 | reiserfs_write_unlock(inode->i_sb); | ||
| 2761 | reiserfs_wait_on_write_block(inode->i_sb); | 2777 | reiserfs_wait_on_write_block(inode->i_sb); |
| 2778 | reiserfs_write_lock(inode->i_sb); | ||
| 2779 | |||
| 2762 | if (reiserfs_transaction_running(inode->i_sb)) { | 2780 | if (reiserfs_transaction_running(inode->i_sb)) { |
| 2763 | th = current->journal_info; | 2781 | th = current->journal_info; |
| 2764 | } | 2782 | } |
| @@ -2770,7 +2788,6 @@ int reiserfs_commit_write(struct file *f, struct page *page, | |||
| 2770 | */ | 2788 | */ |
| 2771 | if (pos > inode->i_size) { | 2789 | if (pos > inode->i_size) { |
| 2772 | struct reiserfs_transaction_handle myth; | 2790 | struct reiserfs_transaction_handle myth; |
| 2773 | reiserfs_write_lock(inode->i_sb); | ||
| 2774 | /* If the file have grown beyond the border where it | 2791 | /* If the file have grown beyond the border where it |
| 2775 | can have a tail, unmark it as needing a tail | 2792 | can have a tail, unmark it as needing a tail |
| 2776 | packing */ | 2793 | packing */ |
| @@ -2781,10 +2798,9 @@ int reiserfs_commit_write(struct file *f, struct page *page, | |||
| 2781 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; | 2798 | REISERFS_I(inode)->i_flags &= ~i_pack_on_close_mask; |
| 2782 | 2799 | ||
| 2783 | ret = journal_begin(&myth, inode->i_sb, 1); | 2800 | ret = journal_begin(&myth, inode->i_sb, 1); |
| 2784 | if (ret) { | 2801 | if (ret) |
| 2785 | reiserfs_write_unlock(inode->i_sb); | ||
| 2786 | goto journal_error; | 2802 | goto journal_error; |
| 2787 | } | 2803 | |
| 2788 | reiserfs_update_inode_transaction(inode); | 2804 | reiserfs_update_inode_transaction(inode); |
| 2789 | inode->i_size = pos; | 2805 | inode->i_size = pos; |
| 2790 | /* | 2806 | /* |
| @@ -2796,16 +2812,13 @@ int reiserfs_commit_write(struct file *f, struct page *page, | |||
| 2796 | reiserfs_update_sd(&myth, inode); | 2812 | reiserfs_update_sd(&myth, inode); |
| 2797 | update_sd = 1; | 2813 | update_sd = 1; |
| 2798 | ret = journal_end(&myth, inode->i_sb, 1); | 2814 | ret = journal_end(&myth, inode->i_sb, 1); |
| 2799 | reiserfs_write_unlock(inode->i_sb); | ||
| 2800 | if (ret) | 2815 | if (ret) |
| 2801 | goto journal_error; | 2816 | goto journal_error; |
| 2802 | } | 2817 | } |
| 2803 | if (th) { | 2818 | if (th) { |
| 2804 | reiserfs_write_lock(inode->i_sb); | ||
| 2805 | if (!update_sd) | 2819 | if (!update_sd) |
| 2806 | mark_inode_dirty(inode); | 2820 | mark_inode_dirty(inode); |
| 2807 | ret = reiserfs_end_persistent_transaction(th); | 2821 | ret = reiserfs_end_persistent_transaction(th); |
| 2808 | reiserfs_write_unlock(inode->i_sb); | ||
| 2809 | if (ret) | 2822 | if (ret) |
| 2810 | goto out; | 2823 | goto out; |
| 2811 | } | 2824 | } |
| @@ -2815,11 +2828,9 @@ int reiserfs_commit_write(struct file *f, struct page *page, | |||
| 2815 | 2828 | ||
| 2816 | journal_error: | 2829 | journal_error: |
| 2817 | if (th) { | 2830 | if (th) { |
| 2818 | reiserfs_write_lock(inode->i_sb); | ||
| 2819 | if (!update_sd) | 2831 | if (!update_sd) |
| 2820 | reiserfs_update_sd(th, inode); | 2832 | reiserfs_update_sd(th, inode); |
| 2821 | ret = reiserfs_end_persistent_transaction(th); | 2833 | ret = reiserfs_end_persistent_transaction(th); |
| 2822 | reiserfs_write_unlock(inode->i_sb); | ||
| 2823 | } | 2834 | } |
| 2824 | 2835 | ||
| 2825 | return ret; | 2836 | return ret; |
diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c index 0ccc3fdda7bf..ace77451ceb1 100644 --- a/fs/reiserfs/ioctl.c +++ b/fs/reiserfs/ioctl.c | |||
| @@ -13,44 +13,52 @@ | |||
| 13 | #include <linux/compat.h> | 13 | #include <linux/compat.h> |
| 14 | 14 | ||
| 15 | /* | 15 | /* |
| 16 | ** reiserfs_ioctl - handler for ioctl for inode | 16 | * reiserfs_ioctl - handler for ioctl for inode |
| 17 | ** supported commands: | 17 | * supported commands: |
| 18 | ** 1) REISERFS_IOC_UNPACK - try to unpack tail from direct item into indirect | 18 | * 1) REISERFS_IOC_UNPACK - try to unpack tail from direct item into indirect |
| 19 | ** and prevent packing file (argument arg has to be non-zero) | 19 | * and prevent packing file (argument arg has to be non-zero) |
| 20 | ** 2) REISERFS_IOC_[GS]ETFLAGS, REISERFS_IOC_[GS]ETVERSION | 20 | * 2) REISERFS_IOC_[GS]ETFLAGS, REISERFS_IOC_[GS]ETVERSION |
| 21 | ** 3) That's all for a while ... | 21 | * 3) That's all for a while ... |
| 22 | */ | 22 | */ |
| 23 | int reiserfs_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, | 23 | long reiserfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) |
| 24 | unsigned long arg) | ||
| 25 | { | 24 | { |
| 25 | struct inode *inode = filp->f_path.dentry->d_inode; | ||
| 26 | unsigned int flags; | 26 | unsigned int flags; |
| 27 | int err = 0; | 27 | int err = 0; |
| 28 | 28 | ||
| 29 | reiserfs_write_lock(inode->i_sb); | ||
| 30 | |||
| 29 | switch (cmd) { | 31 | switch (cmd) { |
| 30 | case REISERFS_IOC_UNPACK: | 32 | case REISERFS_IOC_UNPACK: |
| 31 | if (S_ISREG(inode->i_mode)) { | 33 | if (S_ISREG(inode->i_mode)) { |
| 32 | if (arg) | 34 | if (arg) |
| 33 | return reiserfs_unpack(inode, filp); | 35 | err = reiserfs_unpack(inode, filp); |
| 34 | else | ||
| 35 | return 0; | ||
| 36 | } else | 36 | } else |
| 37 | return -ENOTTY; | 37 | err = -ENOTTY; |
| 38 | /* following two cases are taken from fs/ext2/ioctl.c by Remy | 38 | break; |
| 39 | Card (card@masi.ibp.fr) */ | 39 | /* |
| 40 | * following two cases are taken from fs/ext2/ioctl.c by Remy | ||
| 41 | * Card (card@masi.ibp.fr) | ||
| 42 | */ | ||
| 40 | case REISERFS_IOC_GETFLAGS: | 43 | case REISERFS_IOC_GETFLAGS: |
| 41 | if (!reiserfs_attrs(inode->i_sb)) | 44 | if (!reiserfs_attrs(inode->i_sb)) { |
| 42 | return -ENOTTY; | 45 | err = -ENOTTY; |
| 46 | break; | ||
| 47 | } | ||
| 43 | 48 | ||
| 44 | flags = REISERFS_I(inode)->i_attrs; | 49 | flags = REISERFS_I(inode)->i_attrs; |
| 45 | i_attrs_to_sd_attrs(inode, (__u16 *) & flags); | 50 | i_attrs_to_sd_attrs(inode, (__u16 *) & flags); |
| 46 | return put_user(flags, (int __user *)arg); | 51 | err = put_user(flags, (int __user *)arg); |
| 52 | break; | ||
| 47 | case REISERFS_IOC_SETFLAGS:{ | 53 | case REISERFS_IOC_SETFLAGS:{ |
| 48 | if (!reiserfs_attrs(inode->i_sb)) | 54 | if (!reiserfs_attrs(inode->i_sb)) { |
| 49 | return -ENOTTY; | 55 | err = -ENOTTY; |
| 56 | break; | ||
| 57 | } | ||
| 50 | 58 | ||
| 51 | err = mnt_want_write(filp->f_path.mnt); | 59 | err = mnt_want_write(filp->f_path.mnt); |
| 52 | if (err) | 60 | if (err) |
| 53 | return err; | 61 | break; |
| 54 | 62 | ||
| 55 | if (!is_owner_or_cap(inode)) { | 63 | if (!is_owner_or_cap(inode)) { |
| 56 | err = -EPERM; | 64 | err = -EPERM; |
| @@ -90,16 +98,18 @@ int reiserfs_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, | |||
| 90 | mark_inode_dirty(inode); | 98 | mark_inode_dirty(inode); |
| 91 | setflags_out: | 99 | setflags_out: |
| 92 | mnt_drop_write(filp->f_path.mnt); | 100 | mnt_drop_write(filp->f_path.mnt); |
| 93 | return err; | 101 | break; |
| 94 | } | 102 | } |
| 95 | case REISERFS_IOC_GETVERSION: | 103 | case REISERFS_IOC_GETVERSION: |
| 96 | return put_user(inode->i_generation, (int __user *)arg); | 104 | err = put_user(inode->i_generation, (int __user *)arg); |
| 105 | break; | ||
| 97 | case REISERFS_IOC_SETVERSION: | 106 | case REISERFS_IOC_SETVERSION: |
| 98 | if (!is_owner_or_cap(inode)) | 107 | if (!is_owner_or_cap(inode)) |
| 99 | return -EPERM; | 108 | err = -EPERM; |
| 109 | break; | ||
| 100 | err = mnt_want_write(filp->f_path.mnt); | 110 | err = mnt_want_write(filp->f_path.mnt); |
| 101 | if (err) | 111 | if (err) |
| 102 | return err; | 112 | break; |
| 103 | if (get_user(inode->i_generation, (int __user *)arg)) { | 113 | if (get_user(inode->i_generation, (int __user *)arg)) { |
| 104 | err = -EFAULT; | 114 | err = -EFAULT; |
| 105 | goto setversion_out; | 115 | goto setversion_out; |
| @@ -108,19 +118,20 @@ setflags_out: | |||
| 108 | mark_inode_dirty(inode); | 118 | mark_inode_dirty(inode); |
| 109 | setversion_out: | 119 | setversion_out: |
| 110 | mnt_drop_write(filp->f_path.mnt); | 120 | mnt_drop_write(filp->f_path.mnt); |
| 111 | return err; | 121 | break; |
| 112 | default: | 122 | default: |
| 113 | return -ENOTTY; | 123 | err = -ENOTTY; |
| 114 | } | 124 | } |
| 125 | |||
| 126 | reiserfs_write_unlock(inode->i_sb); | ||
| 127 | |||
| 128 | return err; | ||
| 115 | } | 129 | } |
| 116 | 130 | ||
| 117 | #ifdef CONFIG_COMPAT | 131 | #ifdef CONFIG_COMPAT |
| 118 | long reiserfs_compat_ioctl(struct file *file, unsigned int cmd, | 132 | long reiserfs_compat_ioctl(struct file *file, unsigned int cmd, |
| 119 | unsigned long arg) | 133 | unsigned long arg) |
| 120 | { | 134 | { |
| 121 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 122 | int ret; | ||
| 123 | |||
| 124 | /* These are just misnamed, they actually get/put from/to user an int */ | 135 | /* These are just misnamed, they actually get/put from/to user an int */ |
| 125 | switch (cmd) { | 136 | switch (cmd) { |
| 126 | case REISERFS_IOC32_UNPACK: | 137 | case REISERFS_IOC32_UNPACK: |
| @@ -141,10 +152,8 @@ long reiserfs_compat_ioctl(struct file *file, unsigned int cmd, | |||
| 141 | default: | 152 | default: |
| 142 | return -ENOIOCTLCMD; | 153 | return -ENOIOCTLCMD; |
| 143 | } | 154 | } |
| 144 | lock_kernel(); | 155 | |
| 145 | ret = reiserfs_ioctl(inode, file, cmd, (unsigned long) compat_ptr(arg)); | 156 | return reiserfs_ioctl(file, cmd, (unsigned long) compat_ptr(arg)); |
| 146 | unlock_kernel(); | ||
| 147 | return ret; | ||
| 148 | } | 157 | } |
| 149 | #endif | 158 | #endif |
| 150 | 159 | ||
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 90622200b39c..2f8a7e7b8dab 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c | |||
| @@ -429,21 +429,6 @@ static void clear_prepared_bits(struct buffer_head *bh) | |||
| 429 | clear_buffer_journal_restore_dirty(bh); | 429 | clear_buffer_journal_restore_dirty(bh); |
| 430 | } | 430 | } |
| 431 | 431 | ||
| 432 | /* utility function to force a BUG if it is called without the big | ||
| 433 | ** kernel lock held. caller is the string printed just before calling BUG() | ||
| 434 | */ | ||
| 435 | void reiserfs_check_lock_depth(struct super_block *sb, char *caller) | ||
| 436 | { | ||
| 437 | #ifdef CONFIG_SMP | ||
| 438 | if (current->lock_depth < 0) { | ||
| 439 | reiserfs_panic(sb, "journal-1", "%s called without kernel " | ||
| 440 | "lock held", caller); | ||
| 441 | } | ||
| 442 | #else | ||
| 443 | ; | ||
| 444 | #endif | ||
| 445 | } | ||
| 446 | |||
| 447 | /* return a cnode with same dev, block number and size in table, or null if not found */ | 432 | /* return a cnode with same dev, block number and size in table, or null if not found */ |
| 448 | static inline struct reiserfs_journal_cnode *get_journal_hash_dev(struct | 433 | static inline struct reiserfs_journal_cnode *get_journal_hash_dev(struct |
| 449 | super_block | 434 | super_block |
| @@ -556,7 +541,8 @@ static inline void insert_journal_hash(struct reiserfs_journal_cnode **table, | |||
| 556 | static inline void lock_journal(struct super_block *sb) | 541 | static inline void lock_journal(struct super_block *sb) |
| 557 | { | 542 | { |
| 558 | PROC_INFO_INC(sb, journal.lock_journal); | 543 | PROC_INFO_INC(sb, journal.lock_journal); |
| 559 | mutex_lock(&SB_JOURNAL(sb)->j_mutex); | 544 | |
| 545 | reiserfs_mutex_lock_safe(&SB_JOURNAL(sb)->j_mutex, sb); | ||
| 560 | } | 546 | } |
| 561 | 547 | ||
| 562 | /* unlock the current transaction */ | 548 | /* unlock the current transaction */ |
| @@ -708,7 +694,9 @@ static void check_barrier_completion(struct super_block *s, | |||
| 708 | disable_barrier(s); | 694 | disable_barrier(s); |
| 709 | set_buffer_uptodate(bh); | 695 | set_buffer_uptodate(bh); |
| 710 | set_buffer_dirty(bh); | 696 | set_buffer_dirty(bh); |
| 697 | reiserfs_write_unlock(s); | ||
| 711 | sync_dirty_buffer(bh); | 698 | sync_dirty_buffer(bh); |
| 699 | reiserfs_write_lock(s); | ||
| 712 | } | 700 | } |
| 713 | } | 701 | } |
| 714 | 702 | ||
| @@ -996,8 +984,13 @@ static int reiserfs_async_progress_wait(struct super_block *s) | |||
| 996 | { | 984 | { |
| 997 | DEFINE_WAIT(wait); | 985 | DEFINE_WAIT(wait); |
| 998 | struct reiserfs_journal *j = SB_JOURNAL(s); | 986 | struct reiserfs_journal *j = SB_JOURNAL(s); |
| 999 | if (atomic_read(&j->j_async_throttle)) | 987 | |
| 988 | if (atomic_read(&j->j_async_throttle)) { | ||
| 989 | reiserfs_write_unlock(s); | ||
| 1000 | congestion_wait(BLK_RW_ASYNC, HZ / 10); | 990 | congestion_wait(BLK_RW_ASYNC, HZ / 10); |
| 991 | reiserfs_write_lock(s); | ||
| 992 | } | ||
| 993 | |||
| 1001 | return 0; | 994 | return 0; |
| 1002 | } | 995 | } |
| 1003 | 996 | ||
| @@ -1043,7 +1036,8 @@ static int flush_commit_list(struct super_block *s, | |||
| 1043 | } | 1036 | } |
| 1044 | 1037 | ||
| 1045 | /* make sure nobody is trying to flush this one at the same time */ | 1038 | /* make sure nobody is trying to flush this one at the same time */ |
| 1046 | mutex_lock(&jl->j_commit_mutex); | 1039 | reiserfs_mutex_lock_safe(&jl->j_commit_mutex, s); |
| 1040 | |||
| 1047 | if (!journal_list_still_alive(s, trans_id)) { | 1041 | if (!journal_list_still_alive(s, trans_id)) { |
| 1048 | mutex_unlock(&jl->j_commit_mutex); | 1042 | mutex_unlock(&jl->j_commit_mutex); |
| 1049 | goto put_jl; | 1043 | goto put_jl; |
| @@ -1061,12 +1055,17 @@ static int flush_commit_list(struct super_block *s, | |||
| 1061 | 1055 | ||
| 1062 | if (!list_empty(&jl->j_bh_list)) { | 1056 | if (!list_empty(&jl->j_bh_list)) { |
| 1063 | int ret; | 1057 | int ret; |
| 1064 | unlock_kernel(); | 1058 | |
| 1059 | /* | ||
| 1060 | * We might sleep in numerous places inside | ||
| 1061 | * write_ordered_buffers. Relax the write lock. | ||
| 1062 | */ | ||
| 1063 | reiserfs_write_unlock(s); | ||
| 1065 | ret = write_ordered_buffers(&journal->j_dirty_buffers_lock, | 1064 | ret = write_ordered_buffers(&journal->j_dirty_buffers_lock, |
| 1066 | journal, jl, &jl->j_bh_list); | 1065 | journal, jl, &jl->j_bh_list); |
| 1067 | if (ret < 0 && retval == 0) | 1066 | if (ret < 0 && retval == 0) |
| 1068 | retval = ret; | 1067 | retval = ret; |
| 1069 | lock_kernel(); | 1068 | reiserfs_write_lock(s); |
| 1070 | } | 1069 | } |
| 1071 | BUG_ON(!list_empty(&jl->j_bh_list)); | 1070 | BUG_ON(!list_empty(&jl->j_bh_list)); |
| 1072 | /* | 1071 | /* |
| @@ -1085,8 +1084,11 @@ static int flush_commit_list(struct super_block *s, | |||
| 1085 | SB_ONDISK_JOURNAL_SIZE(s); | 1084 | SB_ONDISK_JOURNAL_SIZE(s); |
| 1086 | tbh = journal_find_get_block(s, bn); | 1085 | tbh = journal_find_get_block(s, bn); |
| 1087 | if (tbh) { | 1086 | if (tbh) { |
| 1088 | if (buffer_dirty(tbh)) | 1087 | if (buffer_dirty(tbh)) { |
| 1089 | ll_rw_block(WRITE, 1, &tbh) ; | 1088 | reiserfs_write_unlock(s); |
| 1089 | ll_rw_block(WRITE, 1, &tbh); | ||
| 1090 | reiserfs_write_lock(s); | ||
| 1091 | } | ||
| 1090 | put_bh(tbh) ; | 1092 | put_bh(tbh) ; |
| 1091 | } | 1093 | } |
| 1092 | } | 1094 | } |
| @@ -1114,12 +1116,19 @@ static int flush_commit_list(struct super_block *s, | |||
| 1114 | bn = SB_ONDISK_JOURNAL_1st_BLOCK(s) + | 1116 | bn = SB_ONDISK_JOURNAL_1st_BLOCK(s) + |
| 1115 | (jl->j_start + i) % SB_ONDISK_JOURNAL_SIZE(s); | 1117 | (jl->j_start + i) % SB_ONDISK_JOURNAL_SIZE(s); |
| 1116 | tbh = journal_find_get_block(s, bn); | 1118 | tbh = journal_find_get_block(s, bn); |
| 1119 | |||
| 1120 | reiserfs_write_unlock(s); | ||
| 1117 | wait_on_buffer(tbh); | 1121 | wait_on_buffer(tbh); |
| 1122 | reiserfs_write_lock(s); | ||
| 1118 | // since we're using ll_rw_blk above, it might have skipped over | 1123 | // since we're using ll_rw_blk above, it might have skipped over |
| 1119 | // a locked buffer. Double check here | 1124 | // a locked buffer. Double check here |
| 1120 | // | 1125 | // |
| 1121 | if (buffer_dirty(tbh)) /* redundant, sync_dirty_buffer() checks */ | 1126 | /* redundant, sync_dirty_buffer() checks */ |
| 1127 | if (buffer_dirty(tbh)) { | ||
| 1128 | reiserfs_write_unlock(s); | ||
| 1122 | sync_dirty_buffer(tbh); | 1129 | sync_dirty_buffer(tbh); |
| 1130 | reiserfs_write_lock(s); | ||
| 1131 | } | ||
| 1123 | if (unlikely(!buffer_uptodate(tbh))) { | 1132 | if (unlikely(!buffer_uptodate(tbh))) { |
| 1124 | #ifdef CONFIG_REISERFS_CHECK | 1133 | #ifdef CONFIG_REISERFS_CHECK |
| 1125 | reiserfs_warning(s, "journal-601", | 1134 | reiserfs_warning(s, "journal-601", |
| @@ -1143,10 +1152,15 @@ static int flush_commit_list(struct super_block *s, | |||
| 1143 | if (buffer_dirty(jl->j_commit_bh)) | 1152 | if (buffer_dirty(jl->j_commit_bh)) |
| 1144 | BUG(); | 1153 | BUG(); |
| 1145 | mark_buffer_dirty(jl->j_commit_bh) ; | 1154 | mark_buffer_dirty(jl->j_commit_bh) ; |
| 1155 | reiserfs_write_unlock(s); | ||
| 1146 | sync_dirty_buffer(jl->j_commit_bh) ; | 1156 | sync_dirty_buffer(jl->j_commit_bh) ; |
| 1157 | reiserfs_write_lock(s); | ||
| 1147 | } | 1158 | } |
| 1148 | } else | 1159 | } else { |
| 1160 | reiserfs_write_unlock(s); | ||
| 1149 | wait_on_buffer(jl->j_commit_bh); | 1161 | wait_on_buffer(jl->j_commit_bh); |
| 1162 | reiserfs_write_lock(s); | ||
| 1163 | } | ||
| 1150 | 1164 | ||
| 1151 | check_barrier_completion(s, jl->j_commit_bh); | 1165 | check_barrier_completion(s, jl->j_commit_bh); |
| 1152 | 1166 | ||
| @@ -1286,7 +1300,9 @@ static int _update_journal_header_block(struct super_block *sb, | |||
| 1286 | 1300 | ||
| 1287 | if (trans_id >= journal->j_last_flush_trans_id) { | 1301 | if (trans_id >= journal->j_last_flush_trans_id) { |
| 1288 | if (buffer_locked((journal->j_header_bh))) { | 1302 | if (buffer_locked((journal->j_header_bh))) { |
| 1303 | reiserfs_write_unlock(sb); | ||
| 1289 | wait_on_buffer((journal->j_header_bh)); | 1304 | wait_on_buffer((journal->j_header_bh)); |
| 1305 | reiserfs_write_lock(sb); | ||
| 1290 | if (unlikely(!buffer_uptodate(journal->j_header_bh))) { | 1306 | if (unlikely(!buffer_uptodate(journal->j_header_bh))) { |
| 1291 | #ifdef CONFIG_REISERFS_CHECK | 1307 | #ifdef CONFIG_REISERFS_CHECK |
| 1292 | reiserfs_warning(sb, "journal-699", | 1308 | reiserfs_warning(sb, "journal-699", |
| @@ -1312,12 +1328,16 @@ static int _update_journal_header_block(struct super_block *sb, | |||
| 1312 | disable_barrier(sb); | 1328 | disable_barrier(sb); |
| 1313 | goto sync; | 1329 | goto sync; |
| 1314 | } | 1330 | } |
| 1331 | reiserfs_write_unlock(sb); | ||
| 1315 | wait_on_buffer(journal->j_header_bh); | 1332 | wait_on_buffer(journal->j_header_bh); |
| 1333 | reiserfs_write_lock(sb); | ||
| 1316 | check_barrier_completion(sb, journal->j_header_bh); | 1334 | check_barrier_completion(sb, journal->j_header_bh); |
| 1317 | } else { | 1335 | } else { |
| 1318 | sync: | 1336 | sync: |
| 1319 | set_buffer_dirty(journal->j_header_bh); | 1337 | set_buffer_dirty(journal->j_header_bh); |
| 1338 | reiserfs_write_unlock(sb); | ||
| 1320 | sync_dirty_buffer(journal->j_header_bh); | 1339 | sync_dirty_buffer(journal->j_header_bh); |
| 1340 | reiserfs_write_lock(sb); | ||
| 1321 | } | 1341 | } |
| 1322 | if (!buffer_uptodate(journal->j_header_bh)) { | 1342 | if (!buffer_uptodate(journal->j_header_bh)) { |
| 1323 | reiserfs_warning(sb, "journal-837", | 1343 | reiserfs_warning(sb, "journal-837", |
| @@ -1409,7 +1429,7 @@ static int flush_journal_list(struct super_block *s, | |||
| 1409 | 1429 | ||
| 1410 | /* if flushall == 0, the lock is already held */ | 1430 | /* if flushall == 0, the lock is already held */ |
| 1411 | if (flushall) { | 1431 | if (flushall) { |
| 1412 | mutex_lock(&journal->j_flush_mutex); | 1432 | reiserfs_mutex_lock_safe(&journal->j_flush_mutex, s); |
| 1413 | } else if (mutex_trylock(&journal->j_flush_mutex)) { | 1433 | } else if (mutex_trylock(&journal->j_flush_mutex)) { |
| 1414 | BUG(); | 1434 | BUG(); |
| 1415 | } | 1435 | } |
| @@ -1553,7 +1573,11 @@ static int flush_journal_list(struct super_block *s, | |||
| 1553 | reiserfs_panic(s, "journal-1011", | 1573 | reiserfs_panic(s, "journal-1011", |
| 1554 | "cn->bh is NULL"); | 1574 | "cn->bh is NULL"); |
| 1555 | } | 1575 | } |
| 1576 | |||
| 1577 | reiserfs_write_unlock(s); | ||
| 1556 | wait_on_buffer(cn->bh); | 1578 | wait_on_buffer(cn->bh); |
| 1579 | reiserfs_write_lock(s); | ||
| 1580 | |||
| 1557 | if (!cn->bh) { | 1581 | if (!cn->bh) { |
| 1558 | reiserfs_panic(s, "journal-1012", | 1582 | reiserfs_panic(s, "journal-1012", |
| 1559 | "cn->bh is NULL"); | 1583 | "cn->bh is NULL"); |
| @@ -1769,7 +1793,7 @@ static int kupdate_transactions(struct super_block *s, | |||
| 1769 | struct reiserfs_journal *journal = SB_JOURNAL(s); | 1793 | struct reiserfs_journal *journal = SB_JOURNAL(s); |
| 1770 | chunk.nr = 0; | 1794 | chunk.nr = 0; |
| 1771 | 1795 | ||
| 1772 | mutex_lock(&journal->j_flush_mutex); | 1796 | reiserfs_mutex_lock_safe(&journal->j_flush_mutex, s); |
| 1773 | if (!journal_list_still_alive(s, orig_trans_id)) { | 1797 | if (!journal_list_still_alive(s, orig_trans_id)) { |
| 1774 | goto done; | 1798 | goto done; |
| 1775 | } | 1799 | } |
| @@ -1973,11 +1997,19 @@ static int do_journal_release(struct reiserfs_transaction_handle *th, | |||
| 1973 | reiserfs_mounted_fs_count--; | 1997 | reiserfs_mounted_fs_count--; |
| 1974 | /* wait for all commits to finish */ | 1998 | /* wait for all commits to finish */ |
| 1975 | cancel_delayed_work(&SB_JOURNAL(sb)->j_work); | 1999 | cancel_delayed_work(&SB_JOURNAL(sb)->j_work); |
| 2000 | |||
| 2001 | /* | ||
| 2002 | * We must release the write lock here because | ||
| 2003 | * the workqueue job (flush_async_commit) needs this lock | ||
| 2004 | */ | ||
| 2005 | reiserfs_write_unlock(sb); | ||
| 1976 | flush_workqueue(commit_wq); | 2006 | flush_workqueue(commit_wq); |
| 2007 | |||
| 1977 | if (!reiserfs_mounted_fs_count) { | 2008 | if (!reiserfs_mounted_fs_count) { |
| 1978 | destroy_workqueue(commit_wq); | 2009 | destroy_workqueue(commit_wq); |
| 1979 | commit_wq = NULL; | 2010 | commit_wq = NULL; |
| 1980 | } | 2011 | } |
| 2012 | reiserfs_write_lock(sb); | ||
| 1981 | 2013 | ||
| 1982 | free_journal_ram(sb); | 2014 | free_journal_ram(sb); |
| 1983 | 2015 | ||
| @@ -2243,7 +2275,11 @@ static int journal_read_transaction(struct super_block *sb, | |||
| 2243 | /* read in the log blocks, memcpy to the corresponding real block */ | 2275 | /* read in the log blocks, memcpy to the corresponding real block */ |
| 2244 | ll_rw_block(READ, get_desc_trans_len(desc), log_blocks); | 2276 | ll_rw_block(READ, get_desc_trans_len(desc), log_blocks); |
| 2245 | for (i = 0; i < get_desc_trans_len(desc); i++) { | 2277 | for (i = 0; i < get_desc_trans_len(desc); i++) { |
| 2278 | |||
| 2279 | reiserfs_write_unlock(sb); | ||
| 2246 | wait_on_buffer(log_blocks[i]); | 2280 | wait_on_buffer(log_blocks[i]); |
| 2281 | reiserfs_write_lock(sb); | ||
| 2282 | |||
| 2247 | if (!buffer_uptodate(log_blocks[i])) { | 2283 | if (!buffer_uptodate(log_blocks[i])) { |
| 2248 | reiserfs_warning(sb, "journal-1212", | 2284 | reiserfs_warning(sb, "journal-1212", |
| 2249 | "REPLAY FAILURE fsck required! " | 2285 | "REPLAY FAILURE fsck required! " |
| @@ -2765,11 +2801,27 @@ int journal_init(struct super_block *sb, const char *j_dev_name, | |||
| 2765 | goto free_and_return; | 2801 | goto free_and_return; |
| 2766 | } | 2802 | } |
| 2767 | 2803 | ||
| 2804 | /* | ||
| 2805 | * We need to unlock here to avoid creating the following | ||
| 2806 | * dependency: | ||
| 2807 | * reiserfs_lock -> sysfs_mutex | ||
| 2808 | * Because the reiserfs mmap path creates the following dependency: | ||
| 2809 | * mm->mmap -> reiserfs_lock, hence we have | ||
| 2810 | * mm->mmap -> reiserfs_lock ->sysfs_mutex | ||
| 2811 | * This would ends up in a circular dependency with sysfs readdir path | ||
| 2812 | * which does sysfs_mutex -> mm->mmap_sem | ||
| 2813 | * This is fine because the reiserfs lock is useless in mount path, | ||
| 2814 | * at least until we call journal_begin. We keep it for paranoid | ||
| 2815 | * reasons. | ||
| 2816 | */ | ||
| 2817 | reiserfs_write_unlock(sb); | ||
| 2768 | if (journal_init_dev(sb, journal, j_dev_name) != 0) { | 2818 | if (journal_init_dev(sb, journal, j_dev_name) != 0) { |
| 2819 | reiserfs_write_lock(sb); | ||
| 2769 | reiserfs_warning(sb, "sh-462", | 2820 | reiserfs_warning(sb, "sh-462", |
| 2770 | "unable to initialize jornal device"); | 2821 | "unable to initialize jornal device"); |
| 2771 | goto free_and_return; | 2822 | goto free_and_return; |
| 2772 | } | 2823 | } |
| 2824 | reiserfs_write_lock(sb); | ||
| 2773 | 2825 | ||
| 2774 | rs = SB_DISK_SUPER_BLOCK(sb); | 2826 | rs = SB_DISK_SUPER_BLOCK(sb); |
| 2775 | 2827 | ||
| @@ -2881,8 +2933,11 @@ int journal_init(struct super_block *sb, const char *j_dev_name, | |||
| 2881 | } | 2933 | } |
| 2882 | 2934 | ||
| 2883 | reiserfs_mounted_fs_count++; | 2935 | reiserfs_mounted_fs_count++; |
| 2884 | if (reiserfs_mounted_fs_count <= 1) | 2936 | if (reiserfs_mounted_fs_count <= 1) { |
| 2937 | reiserfs_write_unlock(sb); | ||
| 2885 | commit_wq = create_workqueue("reiserfs"); | 2938 | commit_wq = create_workqueue("reiserfs"); |
| 2939 | reiserfs_write_lock(sb); | ||
| 2940 | } | ||
| 2886 | 2941 | ||
| 2887 | INIT_DELAYED_WORK(&journal->j_work, flush_async_commits); | 2942 | INIT_DELAYED_WORK(&journal->j_work, flush_async_commits); |
| 2888 | journal->j_work_sb = sb; | 2943 | journal->j_work_sb = sb; |
| @@ -2964,8 +3019,11 @@ static void queue_log_writer(struct super_block *s) | |||
| 2964 | init_waitqueue_entry(&wait, current); | 3019 | init_waitqueue_entry(&wait, current); |
| 2965 | add_wait_queue(&journal->j_join_wait, &wait); | 3020 | add_wait_queue(&journal->j_join_wait, &wait); |
| 2966 | set_current_state(TASK_UNINTERRUPTIBLE); | 3021 | set_current_state(TASK_UNINTERRUPTIBLE); |
| 2967 | if (test_bit(J_WRITERS_QUEUED, &journal->j_state)) | 3022 | if (test_bit(J_WRITERS_QUEUED, &journal->j_state)) { |
| 3023 | reiserfs_write_unlock(s); | ||
| 2968 | schedule(); | 3024 | schedule(); |
| 3025 | reiserfs_write_lock(s); | ||
| 3026 | } | ||
| 2969 | __set_current_state(TASK_RUNNING); | 3027 | __set_current_state(TASK_RUNNING); |
| 2970 | remove_wait_queue(&journal->j_join_wait, &wait); | 3028 | remove_wait_queue(&journal->j_join_wait, &wait); |
| 2971 | } | 3029 | } |
| @@ -2982,7 +3040,9 @@ static void let_transaction_grow(struct super_block *sb, unsigned int trans_id) | |||
| 2982 | struct reiserfs_journal *journal = SB_JOURNAL(sb); | 3040 | struct reiserfs_journal *journal = SB_JOURNAL(sb); |
| 2983 | unsigned long bcount = journal->j_bcount; | 3041 | unsigned long bcount = journal->j_bcount; |
| 2984 | while (1) { | 3042 | while (1) { |
| 3043 | reiserfs_write_unlock(sb); | ||
| 2985 | schedule_timeout_uninterruptible(1); | 3044 | schedule_timeout_uninterruptible(1); |
| 3045 | reiserfs_write_lock(sb); | ||
| 2986 | journal->j_current_jl->j_state |= LIST_COMMIT_PENDING; | 3046 | journal->j_current_jl->j_state |= LIST_COMMIT_PENDING; |
| 2987 | while ((atomic_read(&journal->j_wcount) > 0 || | 3047 | while ((atomic_read(&journal->j_wcount) > 0 || |
| 2988 | atomic_read(&journal->j_jlock)) && | 3048 | atomic_read(&journal->j_jlock)) && |
| @@ -3033,7 +3093,9 @@ static int do_journal_begin_r(struct reiserfs_transaction_handle *th, | |||
| 3033 | 3093 | ||
| 3034 | if (test_bit(J_WRITERS_BLOCKED, &journal->j_state)) { | 3094 | if (test_bit(J_WRITERS_BLOCKED, &journal->j_state)) { |
| 3035 | unlock_journal(sb); | 3095 | unlock_journal(sb); |
| 3096 | reiserfs_write_unlock(sb); | ||
| 3036 | reiserfs_wait_on_write_block(sb); | 3097 | reiserfs_wait_on_write_block(sb); |
| 3098 | reiserfs_write_lock(sb); | ||
| 3037 | PROC_INFO_INC(sb, journal.journal_relock_writers); | 3099 | PROC_INFO_INC(sb, journal.journal_relock_writers); |
| 3038 | goto relock; | 3100 | goto relock; |
| 3039 | } | 3101 | } |
| @@ -3506,14 +3568,14 @@ static void flush_async_commits(struct work_struct *work) | |||
| 3506 | struct reiserfs_journal_list *jl; | 3568 | struct reiserfs_journal_list *jl; |
| 3507 | struct list_head *entry; | 3569 | struct list_head *entry; |
| 3508 | 3570 | ||
| 3509 | lock_kernel(); | 3571 | reiserfs_write_lock(sb); |
| 3510 | if (!list_empty(&journal->j_journal_list)) { | 3572 | if (!list_empty(&journal->j_journal_list)) { |
| 3511 | /* last entry is the youngest, commit it and you get everything */ | 3573 | /* last entry is the youngest, commit it and you get everything */ |
| 3512 | entry = journal->j_journal_list.prev; | 3574 | entry = journal->j_journal_list.prev; |
| 3513 | jl = JOURNAL_LIST_ENTRY(entry); | 3575 | jl = JOURNAL_LIST_ENTRY(entry); |
| 3514 | flush_commit_list(sb, jl, 1); | 3576 | flush_commit_list(sb, jl, 1); |
| 3515 | } | 3577 | } |
| 3516 | unlock_kernel(); | 3578 | reiserfs_write_unlock(sb); |
| 3517 | } | 3579 | } |
| 3518 | 3580 | ||
| 3519 | /* | 3581 | /* |
| @@ -4041,7 +4103,7 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, | |||
| 4041 | * the new transaction is fully setup, and we've already flushed the | 4103 | * the new transaction is fully setup, and we've already flushed the |
| 4042 | * ordered bh list | 4104 | * ordered bh list |
| 4043 | */ | 4105 | */ |
| 4044 | mutex_lock(&jl->j_commit_mutex); | 4106 | reiserfs_mutex_lock_safe(&jl->j_commit_mutex, sb); |
| 4045 | 4107 | ||
| 4046 | /* save the transaction id in case we need to commit it later */ | 4108 | /* save the transaction id in case we need to commit it later */ |
| 4047 | commit_trans_id = jl->j_trans_id; | 4109 | commit_trans_id = jl->j_trans_id; |
| @@ -4156,7 +4218,9 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, | |||
| 4156 | next = cn->next; | 4218 | next = cn->next; |
| 4157 | free_cnode(sb, cn); | 4219 | free_cnode(sb, cn); |
| 4158 | cn = next; | 4220 | cn = next; |
| 4221 | reiserfs_write_unlock(sb); | ||
| 4159 | cond_resched(); | 4222 | cond_resched(); |
| 4223 | reiserfs_write_lock(sb); | ||
| 4160 | } | 4224 | } |
| 4161 | 4225 | ||
| 4162 | /* we are done with both the c_bh and d_bh, but | 4226 | /* we are done with both the c_bh and d_bh, but |
| @@ -4203,10 +4267,10 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, | |||
| 4203 | * is lost. | 4267 | * is lost. |
| 4204 | */ | 4268 | */ |
| 4205 | if (!list_empty(&jl->j_tail_bh_list)) { | 4269 | if (!list_empty(&jl->j_tail_bh_list)) { |
| 4206 | unlock_kernel(); | 4270 | reiserfs_write_unlock(sb); |
| 4207 | write_ordered_buffers(&journal->j_dirty_buffers_lock, | 4271 | write_ordered_buffers(&journal->j_dirty_buffers_lock, |
| 4208 | journal, jl, &jl->j_tail_bh_list); | 4272 | journal, jl, &jl->j_tail_bh_list); |
| 4209 | lock_kernel(); | 4273 | reiserfs_write_lock(sb); |
| 4210 | } | 4274 | } |
| 4211 | BUG_ON(!list_empty(&jl->j_tail_bh_list)); | 4275 | BUG_ON(!list_empty(&jl->j_tail_bh_list)); |
| 4212 | mutex_unlock(&jl->j_commit_mutex); | 4276 | mutex_unlock(&jl->j_commit_mutex); |
diff --git a/fs/reiserfs/lock.c b/fs/reiserfs/lock.c new file mode 100644 index 000000000000..ee2cfc0fd8a7 --- /dev/null +++ b/fs/reiserfs/lock.c | |||
| @@ -0,0 +1,88 @@ | |||
| 1 | #include <linux/reiserfs_fs.h> | ||
| 2 | #include <linux/mutex.h> | ||
| 3 | |||
| 4 | /* | ||
| 5 | * The previous reiserfs locking scheme was heavily based on | ||
| 6 | * the tricky properties of the Bkl: | ||
| 7 | * | ||
| 8 | * - it was acquired recursively by a same task | ||
| 9 | * - the performances relied on the release-while-schedule() property | ||
| 10 | * | ||
| 11 | * Now that we replace it by a mutex, we still want to keep the same | ||
| 12 | * recursive property to avoid big changes in the code structure. | ||
| 13 | * We use our own lock_owner here because the owner field on a mutex | ||
| 14 | * is only available in SMP or mutex debugging, also we only need this field | ||
| 15 | * for this mutex, no need for a system wide mutex facility. | ||
| 16 | * | ||
| 17 | * Also this lock is often released before a call that could block because | ||
| 18 | * reiserfs performances were partialy based on the release while schedule() | ||
| 19 | * property of the Bkl. | ||
| 20 | */ | ||
| 21 | void reiserfs_write_lock(struct super_block *s) | ||
| 22 | { | ||
| 23 | struct reiserfs_sb_info *sb_i = REISERFS_SB(s); | ||
| 24 | |||
| 25 | if (sb_i->lock_owner != current) { | ||
| 26 | mutex_lock(&sb_i->lock); | ||
| 27 | sb_i->lock_owner = current; | ||
| 28 | } | ||
| 29 | |||
| 30 | /* No need to protect it, only the current task touches it */ | ||
| 31 | sb_i->lock_depth++; | ||
| 32 | } | ||
| 33 | |||
| 34 | void reiserfs_write_unlock(struct super_block *s) | ||
| 35 | { | ||
| 36 | struct reiserfs_sb_info *sb_i = REISERFS_SB(s); | ||
| 37 | |||
| 38 | /* | ||
| 39 | * Are we unlocking without even holding the lock? | ||
| 40 | * Such a situation must raise a BUG() if we don't want | ||
| 41 | * to corrupt the data. | ||
| 42 | */ | ||
| 43 | BUG_ON(sb_i->lock_owner != current); | ||
| 44 | |||
| 45 | if (--sb_i->lock_depth == -1) { | ||
| 46 | sb_i->lock_owner = NULL; | ||
| 47 | mutex_unlock(&sb_i->lock); | ||
| 48 | } | ||
| 49 | } | ||
| 50 | |||
| 51 | /* | ||
| 52 | * If we already own the lock, just exit and don't increase the depth. | ||
| 53 | * Useful when we don't want to lock more than once. | ||
| 54 | * | ||
| 55 | * We always return the lock_depth we had before calling | ||
| 56 | * this function. | ||
| 57 | */ | ||
| 58 | int reiserfs_write_lock_once(struct super_block *s) | ||
| 59 | { | ||
| 60 | struct reiserfs_sb_info *sb_i = REISERFS_SB(s); | ||
| 61 | |||
| 62 | if (sb_i->lock_owner != current) { | ||
| 63 | mutex_lock(&sb_i->lock); | ||
| 64 | sb_i->lock_owner = current; | ||
| 65 | return sb_i->lock_depth++; | ||
| 66 | } | ||
| 67 | |||
| 68 | return sb_i->lock_depth; | ||
| 69 | } | ||
| 70 | |||
| 71 | void reiserfs_write_unlock_once(struct super_block *s, int lock_depth) | ||
| 72 | { | ||
| 73 | if (lock_depth == -1) | ||
| 74 | reiserfs_write_unlock(s); | ||
| 75 | } | ||
| 76 | |||
| 77 | /* | ||
| 78 | * Utility function to force a BUG if it is called without the superblock | ||
| 79 | * write lock held. caller is the string printed just before calling BUG() | ||
| 80 | */ | ||
| 81 | void reiserfs_check_lock_depth(struct super_block *sb, char *caller) | ||
| 82 | { | ||
| 83 | struct reiserfs_sb_info *sb_i = REISERFS_SB(sb); | ||
| 84 | |||
| 85 | if (sb_i->lock_depth < 0) | ||
| 86 | reiserfs_panic(sb, "%s called without kernel lock held %d", | ||
| 87 | caller); | ||
| 88 | } | ||
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c index 271579128634..e296ff72a6cc 100644 --- a/fs/reiserfs/namei.c +++ b/fs/reiserfs/namei.c | |||
| @@ -324,6 +324,7 @@ static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 324 | struct nameidata *nd) | 324 | struct nameidata *nd) |
| 325 | { | 325 | { |
| 326 | int retval; | 326 | int retval; |
| 327 | int lock_depth; | ||
| 327 | struct inode *inode = NULL; | 328 | struct inode *inode = NULL; |
| 328 | struct reiserfs_dir_entry de; | 329 | struct reiserfs_dir_entry de; |
| 329 | INITIALIZE_PATH(path_to_entry); | 330 | INITIALIZE_PATH(path_to_entry); |
| @@ -331,7 +332,13 @@ static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 331 | if (REISERFS_MAX_NAME(dir->i_sb->s_blocksize) < dentry->d_name.len) | 332 | if (REISERFS_MAX_NAME(dir->i_sb->s_blocksize) < dentry->d_name.len) |
| 332 | return ERR_PTR(-ENAMETOOLONG); | 333 | return ERR_PTR(-ENAMETOOLONG); |
| 333 | 334 | ||
| 334 | reiserfs_write_lock(dir->i_sb); | 335 | /* |
| 336 | * Might be called with or without the write lock, must be careful | ||
| 337 | * to not recursively hold it in case we want to release the lock | ||
| 338 | * before rescheduling. | ||
| 339 | */ | ||
| 340 | lock_depth = reiserfs_write_lock_once(dir->i_sb); | ||
| 341 | |||
| 335 | de.de_gen_number_bit_string = NULL; | 342 | de.de_gen_number_bit_string = NULL; |
| 336 | retval = | 343 | retval = |
| 337 | reiserfs_find_entry(dir, dentry->d_name.name, dentry->d_name.len, | 344 | reiserfs_find_entry(dir, dentry->d_name.name, dentry->d_name.len, |
| @@ -341,7 +348,7 @@ static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 341 | inode = reiserfs_iget(dir->i_sb, | 348 | inode = reiserfs_iget(dir->i_sb, |
| 342 | (struct cpu_key *)&(de.de_dir_id)); | 349 | (struct cpu_key *)&(de.de_dir_id)); |
| 343 | if (!inode || IS_ERR(inode)) { | 350 | if (!inode || IS_ERR(inode)) { |
| 344 | reiserfs_write_unlock(dir->i_sb); | 351 | reiserfs_write_unlock_once(dir->i_sb, lock_depth); |
| 345 | return ERR_PTR(-EACCES); | 352 | return ERR_PTR(-EACCES); |
| 346 | } | 353 | } |
| 347 | 354 | ||
| @@ -350,7 +357,7 @@ static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 350 | if (IS_PRIVATE(dir)) | 357 | if (IS_PRIVATE(dir)) |
| 351 | inode->i_flags |= S_PRIVATE; | 358 | inode->i_flags |= S_PRIVATE; |
| 352 | } | 359 | } |
| 353 | reiserfs_write_unlock(dir->i_sb); | 360 | reiserfs_write_unlock_once(dir->i_sb, lock_depth); |
| 354 | if (retval == IO_ERROR) { | 361 | if (retval == IO_ERROR) { |
| 355 | return ERR_PTR(-EIO); | 362 | return ERR_PTR(-EIO); |
| 356 | } | 363 | } |
| @@ -725,6 +732,7 @@ static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 725 | struct inode *inode; | 732 | struct inode *inode; |
| 726 | struct reiserfs_transaction_handle th; | 733 | struct reiserfs_transaction_handle th; |
| 727 | struct reiserfs_security_handle security; | 734 | struct reiserfs_security_handle security; |
| 735 | int lock_depth; | ||
| 728 | /* We need blocks for transaction + (user+group)*(quotas for new inode + update of quota for directory owner) */ | 736 | /* We need blocks for transaction + (user+group)*(quotas for new inode + update of quota for directory owner) */ |
| 729 | int jbegin_count = | 737 | int jbegin_count = |
| 730 | JOURNAL_PER_BALANCE_CNT * 3 + | 738 | JOURNAL_PER_BALANCE_CNT * 3 + |
| @@ -748,7 +756,7 @@ static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 748 | return retval; | 756 | return retval; |
| 749 | } | 757 | } |
| 750 | jbegin_count += retval; | 758 | jbegin_count += retval; |
| 751 | reiserfs_write_lock(dir->i_sb); | 759 | lock_depth = reiserfs_write_lock_once(dir->i_sb); |
| 752 | 760 | ||
| 753 | retval = journal_begin(&th, dir->i_sb, jbegin_count); | 761 | retval = journal_begin(&th, dir->i_sb, jbegin_count); |
| 754 | if (retval) { | 762 | if (retval) { |
| @@ -798,8 +806,8 @@ static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
| 798 | d_instantiate(dentry, inode); | 806 | d_instantiate(dentry, inode); |
| 799 | unlock_new_inode(inode); | 807 | unlock_new_inode(inode); |
| 800 | retval = journal_end(&th, dir->i_sb, jbegin_count); | 808 | retval = journal_end(&th, dir->i_sb, jbegin_count); |
| 801 | out_failed: | 809 | out_failed: |
| 802 | reiserfs_write_unlock(dir->i_sb); | 810 | reiserfs_write_unlock_once(dir->i_sb, lock_depth); |
| 803 | return retval; | 811 | return retval; |
| 804 | } | 812 | } |
| 805 | 813 | ||
diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c index 536eacaeb710..adbc6f538515 100644 --- a/fs/reiserfs/prints.c +++ b/fs/reiserfs/prints.c | |||
| @@ -349,10 +349,6 @@ void reiserfs_debug(struct super_block *s, int level, const char *fmt, ...) | |||
| 349 | 349 | ||
| 350 | . */ | 350 | . */ |
| 351 | 351 | ||
| 352 | #ifdef CONFIG_REISERFS_CHECK | ||
| 353 | extern struct tree_balance *cur_tb; | ||
| 354 | #endif | ||
| 355 | |||
| 356 | void __reiserfs_panic(struct super_block *sb, const char *id, | 352 | void __reiserfs_panic(struct super_block *sb, const char *id, |
| 357 | const char *function, const char *fmt, ...) | 353 | const char *function, const char *fmt, ...) |
| 358 | { | 354 | { |
diff --git a/fs/reiserfs/resize.c b/fs/reiserfs/resize.c index 18b315d3d104..b3a94d20f0fc 100644 --- a/fs/reiserfs/resize.c +++ b/fs/reiserfs/resize.c | |||
| @@ -141,7 +141,9 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new) | |||
| 141 | 141 | ||
| 142 | set_buffer_uptodate(bh); | 142 | set_buffer_uptodate(bh); |
| 143 | mark_buffer_dirty(bh); | 143 | mark_buffer_dirty(bh); |
| 144 | reiserfs_write_unlock(s); | ||
| 144 | sync_dirty_buffer(bh); | 145 | sync_dirty_buffer(bh); |
| 146 | reiserfs_write_lock(s); | ||
| 145 | // update bitmap_info stuff | 147 | // update bitmap_info stuff |
| 146 | bitmap[i].free_count = sb_blocksize(sb) * 8 - 1; | 148 | bitmap[i].free_count = sb_blocksize(sb) * 8 - 1; |
| 147 | brelse(bh); | 149 | brelse(bh); |
diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index d036ee5b1c81..5fa7118f04e1 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c | |||
| @@ -222,9 +222,6 @@ static inline int bin_search(const void *key, /* Key to search for. */ | |||
| 222 | return ITEM_NOT_FOUND; | 222 | return ITEM_NOT_FOUND; |
| 223 | } | 223 | } |
| 224 | 224 | ||
| 225 | #ifdef CONFIG_REISERFS_CHECK | ||
| 226 | extern struct tree_balance *cur_tb; | ||
| 227 | #endif | ||
| 228 | 225 | ||
| 229 | /* Minimal possible key. It is never in the tree. */ | 226 | /* Minimal possible key. It is never in the tree. */ |
| 230 | const struct reiserfs_key MIN_KEY = { 0, 0, {{0, 0},} }; | 227 | const struct reiserfs_key MIN_KEY = { 0, 0, {{0, 0},} }; |
| @@ -519,25 +516,48 @@ static int is_tree_node(struct buffer_head *bh, int level) | |||
| 519 | 516 | ||
| 520 | #define SEARCH_BY_KEY_READA 16 | 517 | #define SEARCH_BY_KEY_READA 16 |
| 521 | 518 | ||
| 522 | /* The function is NOT SCHEDULE-SAFE! */ | 519 | /* |
| 523 | static void search_by_key_reada(struct super_block *s, | 520 | * The function is NOT SCHEDULE-SAFE! |
| 521 | * It might unlock the write lock if we needed to wait for a block | ||
| 522 | * to be read. Note that in this case it won't recover the lock to avoid | ||
| 523 | * high contention resulting from too much lock requests, especially | ||
| 524 | * the caller (search_by_key) will perform other schedule-unsafe | ||
| 525 | * operations just after calling this function. | ||
| 526 | * | ||
| 527 | * @return true if we have unlocked | ||
| 528 | */ | ||
| 529 | static bool search_by_key_reada(struct super_block *s, | ||
| 524 | struct buffer_head **bh, | 530 | struct buffer_head **bh, |
| 525 | b_blocknr_t *b, int num) | 531 | b_blocknr_t *b, int num) |
| 526 | { | 532 | { |
| 527 | int i, j; | 533 | int i, j; |
| 534 | bool unlocked = false; | ||
| 528 | 535 | ||
| 529 | for (i = 0; i < num; i++) { | 536 | for (i = 0; i < num; i++) { |
| 530 | bh[i] = sb_getblk(s, b[i]); | 537 | bh[i] = sb_getblk(s, b[i]); |
| 531 | } | 538 | } |
| 539 | /* | ||
| 540 | * We are going to read some blocks on which we | ||
| 541 | * have a reference. It's safe, though we might be | ||
| 542 | * reading blocks concurrently changed if we release | ||
| 543 | * the lock. But it's still fine because we check later | ||
| 544 | * if the tree changed | ||
| 545 | */ | ||
| 532 | for (j = 0; j < i; j++) { | 546 | for (j = 0; j < i; j++) { |
| 533 | /* | 547 | /* |
| 534 | * note, this needs attention if we are getting rid of the BKL | 548 | * note, this needs attention if we are getting rid of the BKL |
| 535 | * you have to make sure the prepared bit isn't set on this buffer | 549 | * you have to make sure the prepared bit isn't set on this buffer |
| 536 | */ | 550 | */ |
| 537 | if (!buffer_uptodate(bh[j])) | 551 | if (!buffer_uptodate(bh[j])) { |
| 552 | if (!unlocked) { | ||
| 553 | reiserfs_write_unlock(s); | ||
| 554 | unlocked = true; | ||
| 555 | } | ||
| 538 | ll_rw_block(READA, 1, bh + j); | 556 | ll_rw_block(READA, 1, bh + j); |
| 557 | } | ||
| 539 | brelse(bh[j]); | 558 | brelse(bh[j]); |
| 540 | } | 559 | } |
| 560 | return unlocked; | ||
| 541 | } | 561 | } |
| 542 | 562 | ||
| 543 | /************************************************************************** | 563 | /************************************************************************** |
| @@ -625,11 +645,26 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s | |||
| 625 | have a pointer to it. */ | 645 | have a pointer to it. */ |
| 626 | if ((bh = last_element->pe_buffer = | 646 | if ((bh = last_element->pe_buffer = |
| 627 | sb_getblk(sb, block_number))) { | 647 | sb_getblk(sb, block_number))) { |
| 648 | bool unlocked = false; | ||
| 649 | |||
| 628 | if (!buffer_uptodate(bh) && reada_count > 1) | 650 | if (!buffer_uptodate(bh) && reada_count > 1) |
| 629 | search_by_key_reada(sb, reada_bh, | 651 | /* may unlock the write lock */ |
| 652 | unlocked = search_by_key_reada(sb, reada_bh, | ||
| 630 | reada_blocks, reada_count); | 653 | reada_blocks, reada_count); |
| 654 | /* | ||
| 655 | * If we haven't already unlocked the write lock, | ||
| 656 | * then we need to do that here before reading | ||
| 657 | * the current block | ||
| 658 | */ | ||
| 659 | if (!buffer_uptodate(bh) && !unlocked) { | ||
| 660 | reiserfs_write_unlock(sb); | ||
| 661 | unlocked = true; | ||
| 662 | } | ||
| 631 | ll_rw_block(READ, 1, &bh); | 663 | ll_rw_block(READ, 1, &bh); |
| 632 | wait_on_buffer(bh); | 664 | wait_on_buffer(bh); |
| 665 | |||
| 666 | if (unlocked) | ||
| 667 | reiserfs_write_lock(sb); | ||
| 633 | if (!buffer_uptodate(bh)) | 668 | if (!buffer_uptodate(bh)) |
| 634 | goto io_error; | 669 | goto io_error; |
| 635 | } else { | 670 | } else { |
| @@ -673,7 +708,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s | |||
| 673 | !key_in_buffer(search_path, key, sb), | 708 | !key_in_buffer(search_path, key, sb), |
| 674 | "PAP-5130: key is not in the buffer"); | 709 | "PAP-5130: key is not in the buffer"); |
| 675 | #ifdef CONFIG_REISERFS_CHECK | 710 | #ifdef CONFIG_REISERFS_CHECK |
| 676 | if (cur_tb) { | 711 | if (REISERFS_SB(sb)->cur_tb) { |
| 677 | print_cur_tb("5140"); | 712 | print_cur_tb("5140"); |
| 678 | reiserfs_panic(sb, "PAP-5140", | 713 | reiserfs_panic(sb, "PAP-5140", |
| 679 | "schedule occurred in do_balance!"); | 714 | "schedule occurred in do_balance!"); |
| @@ -1024,7 +1059,9 @@ static char prepare_for_delete_or_cut(struct reiserfs_transaction_handle *th, st | |||
| 1024 | reiserfs_free_block(th, inode, block, 1); | 1059 | reiserfs_free_block(th, inode, block, 1); |
| 1025 | } | 1060 | } |
| 1026 | 1061 | ||
| 1062 | reiserfs_write_unlock(sb); | ||
| 1027 | cond_resched(); | 1063 | cond_resched(); |
| 1064 | reiserfs_write_lock(sb); | ||
| 1028 | 1065 | ||
| 1029 | if (item_moved (&s_ih, path)) { | 1066 | if (item_moved (&s_ih, path)) { |
| 1030 | need_re_search = 1; | 1067 | need_re_search = 1; |
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index f0ad05f38022..339b0baf2af6 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c | |||
| @@ -465,7 +465,7 @@ static void reiserfs_put_super(struct super_block *s) | |||
| 465 | struct reiserfs_transaction_handle th; | 465 | struct reiserfs_transaction_handle th; |
| 466 | th.t_trans_id = 0; | 466 | th.t_trans_id = 0; |
| 467 | 467 | ||
| 468 | lock_kernel(); | 468 | reiserfs_write_lock(s); |
| 469 | 469 | ||
| 470 | if (s->s_dirt) | 470 | if (s->s_dirt) |
| 471 | reiserfs_write_super(s); | 471 | reiserfs_write_super(s); |
| @@ -499,10 +499,10 @@ static void reiserfs_put_super(struct super_block *s) | |||
| 499 | 499 | ||
| 500 | reiserfs_proc_info_done(s); | 500 | reiserfs_proc_info_done(s); |
| 501 | 501 | ||
| 502 | reiserfs_write_unlock(s); | ||
| 503 | mutex_destroy(&REISERFS_SB(s)->lock); | ||
| 502 | kfree(s->s_fs_info); | 504 | kfree(s->s_fs_info); |
| 503 | s->s_fs_info = NULL; | 505 | s->s_fs_info = NULL; |
| 504 | |||
| 505 | unlock_kernel(); | ||
| 506 | } | 506 | } |
| 507 | 507 | ||
| 508 | static struct kmem_cache *reiserfs_inode_cachep; | 508 | static struct kmem_cache *reiserfs_inode_cachep; |
| @@ -554,25 +554,28 @@ static void reiserfs_dirty_inode(struct inode *inode) | |||
| 554 | struct reiserfs_transaction_handle th; | 554 | struct reiserfs_transaction_handle th; |
| 555 | 555 | ||
| 556 | int err = 0; | 556 | int err = 0; |
| 557 | int lock_depth; | ||
| 558 | |||
| 557 | if (inode->i_sb->s_flags & MS_RDONLY) { | 559 | if (inode->i_sb->s_flags & MS_RDONLY) { |
| 558 | reiserfs_warning(inode->i_sb, "clm-6006", | 560 | reiserfs_warning(inode->i_sb, "clm-6006", |
| 559 | "writing inode %lu on readonly FS", | 561 | "writing inode %lu on readonly FS", |
| 560 | inode->i_ino); | 562 | inode->i_ino); |
| 561 | return; | 563 | return; |
| 562 | } | 564 | } |
| 563 | reiserfs_write_lock(inode->i_sb); | 565 | lock_depth = reiserfs_write_lock_once(inode->i_sb); |
| 564 | 566 | ||
| 565 | /* this is really only used for atime updates, so they don't have | 567 | /* this is really only used for atime updates, so they don't have |
| 566 | ** to be included in O_SYNC or fsync | 568 | ** to be included in O_SYNC or fsync |
| 567 | */ | 569 | */ |
| 568 | err = journal_begin(&th, inode->i_sb, 1); | 570 | err = journal_begin(&th, inode->i_sb, 1); |
| 569 | if (err) { | 571 | if (err) |
| 570 | reiserfs_write_unlock(inode->i_sb); | 572 | goto out; |
| 571 | return; | 573 | |
| 572 | } | ||
| 573 | reiserfs_update_sd(&th, inode); | 574 | reiserfs_update_sd(&th, inode); |
| 574 | journal_end(&th, inode->i_sb, 1); | 575 | journal_end(&th, inode->i_sb, 1); |
| 575 | reiserfs_write_unlock(inode->i_sb); | 576 | |
| 577 | out: | ||
| 578 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | ||
| 576 | } | 579 | } |
| 577 | 580 | ||
| 578 | #ifdef CONFIG_QUOTA | 581 | #ifdef CONFIG_QUOTA |
| @@ -1168,11 +1171,14 @@ static int reiserfs_remount(struct super_block *s, int *mount_flags, char *arg) | |||
| 1168 | unsigned int qfmt = 0; | 1171 | unsigned int qfmt = 0; |
| 1169 | #ifdef CONFIG_QUOTA | 1172 | #ifdef CONFIG_QUOTA |
| 1170 | int i; | 1173 | int i; |
| 1174 | #endif | ||
| 1175 | |||
| 1176 | reiserfs_write_lock(s); | ||
| 1171 | 1177 | ||
| 1178 | #ifdef CONFIG_QUOTA | ||
| 1172 | memcpy(qf_names, REISERFS_SB(s)->s_qf_names, sizeof(qf_names)); | 1179 | memcpy(qf_names, REISERFS_SB(s)->s_qf_names, sizeof(qf_names)); |
| 1173 | #endif | 1180 | #endif |
| 1174 | 1181 | ||
| 1175 | lock_kernel(); | ||
| 1176 | rs = SB_DISK_SUPER_BLOCK(s); | 1182 | rs = SB_DISK_SUPER_BLOCK(s); |
| 1177 | 1183 | ||
| 1178 | if (!reiserfs_parse_options | 1184 | if (!reiserfs_parse_options |
| @@ -1295,12 +1301,12 @@ static int reiserfs_remount(struct super_block *s, int *mount_flags, char *arg) | |||
| 1295 | 1301 | ||
| 1296 | out_ok: | 1302 | out_ok: |
| 1297 | replace_mount_options(s, new_opts); | 1303 | replace_mount_options(s, new_opts); |
| 1298 | unlock_kernel(); | 1304 | reiserfs_write_unlock(s); |
| 1299 | return 0; | 1305 | return 0; |
| 1300 | 1306 | ||
| 1301 | out_err: | 1307 | out_err: |
| 1302 | kfree(new_opts); | 1308 | kfree(new_opts); |
| 1303 | unlock_kernel(); | 1309 | reiserfs_write_unlock(s); |
| 1304 | return err; | 1310 | return err; |
| 1305 | } | 1311 | } |
| 1306 | 1312 | ||
| @@ -1404,7 +1410,9 @@ static int read_super_block(struct super_block *s, int offset) | |||
| 1404 | static int reread_meta_blocks(struct super_block *s) | 1410 | static int reread_meta_blocks(struct super_block *s) |
| 1405 | { | 1411 | { |
| 1406 | ll_rw_block(READ, 1, &(SB_BUFFER_WITH_SB(s))); | 1412 | ll_rw_block(READ, 1, &(SB_BUFFER_WITH_SB(s))); |
| 1413 | reiserfs_write_unlock(s); | ||
| 1407 | wait_on_buffer(SB_BUFFER_WITH_SB(s)); | 1414 | wait_on_buffer(SB_BUFFER_WITH_SB(s)); |
| 1415 | reiserfs_write_lock(s); | ||
| 1408 | if (!buffer_uptodate(SB_BUFFER_WITH_SB(s))) { | 1416 | if (!buffer_uptodate(SB_BUFFER_WITH_SB(s))) { |
| 1409 | reiserfs_warning(s, "reiserfs-2504", "error reading the super"); | 1417 | reiserfs_warning(s, "reiserfs-2504", "error reading the super"); |
| 1410 | return 1; | 1418 | return 1; |
| @@ -1613,7 +1621,7 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent) | |||
| 1613 | sbi = kzalloc(sizeof(struct reiserfs_sb_info), GFP_KERNEL); | 1621 | sbi = kzalloc(sizeof(struct reiserfs_sb_info), GFP_KERNEL); |
| 1614 | if (!sbi) { | 1622 | if (!sbi) { |
| 1615 | errval = -ENOMEM; | 1623 | errval = -ENOMEM; |
| 1616 | goto error; | 1624 | goto error_alloc; |
| 1617 | } | 1625 | } |
| 1618 | s->s_fs_info = sbi; | 1626 | s->s_fs_info = sbi; |
| 1619 | /* Set default values for options: non-aggressive tails, RO on errors */ | 1627 | /* Set default values for options: non-aggressive tails, RO on errors */ |
| @@ -1627,6 +1635,20 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent) | |||
| 1627 | /* setup default block allocator options */ | 1635 | /* setup default block allocator options */ |
| 1628 | reiserfs_init_alloc_options(s); | 1636 | reiserfs_init_alloc_options(s); |
| 1629 | 1637 | ||
| 1638 | mutex_init(&REISERFS_SB(s)->lock); | ||
| 1639 | REISERFS_SB(s)->lock_depth = -1; | ||
| 1640 | |||
| 1641 | /* | ||
| 1642 | * This function is called with the bkl, which also was the old | ||
| 1643 | * locking used here. | ||
| 1644 | * do_journal_begin() will soon check if we hold the lock (ie: was the | ||
| 1645 | * bkl). This is likely because do_journal_begin() has several another | ||
| 1646 | * callers because at this time, it doesn't seem to be necessary to | ||
| 1647 | * protect against anything. | ||
| 1648 | * Anyway, let's be conservative and lock for now. | ||
| 1649 | */ | ||
| 1650 | reiserfs_write_lock(s); | ||
| 1651 | |||
| 1630 | jdev_name = NULL; | 1652 | jdev_name = NULL; |
| 1631 | if (reiserfs_parse_options | 1653 | if (reiserfs_parse_options |
| 1632 | (s, (char *)data, &(sbi->s_mount_opt), &blocks, &jdev_name, | 1654 | (s, (char *)data, &(sbi->s_mount_opt), &blocks, &jdev_name, |
| @@ -1852,9 +1874,13 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent) | |||
| 1852 | init_waitqueue_head(&(sbi->s_wait)); | 1874 | init_waitqueue_head(&(sbi->s_wait)); |
| 1853 | spin_lock_init(&sbi->bitmap_lock); | 1875 | spin_lock_init(&sbi->bitmap_lock); |
| 1854 | 1876 | ||
| 1877 | reiserfs_write_unlock(s); | ||
| 1878 | |||
| 1855 | return (0); | 1879 | return (0); |
| 1856 | 1880 | ||
| 1857 | error: | 1881 | error: |
| 1882 | reiserfs_write_unlock(s); | ||
| 1883 | error_alloc: | ||
| 1858 | if (jinit_done) { /* kill the commit thread, free journal ram */ | 1884 | if (jinit_done) { /* kill the commit thread, free journal ram */ |
| 1859 | journal_release_error(NULL, s); | 1885 | journal_release_error(NULL, s); |
| 1860 | } | 1886 | } |
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 6925b835a43b..58aa8e75f7f5 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c | |||
| @@ -975,7 +975,7 @@ int reiserfs_lookup_privroot(struct super_block *s) | |||
| 975 | int err = 0; | 975 | int err = 0; |
| 976 | 976 | ||
| 977 | /* If we don't have the privroot located yet - go find it */ | 977 | /* If we don't have the privroot located yet - go find it */ |
| 978 | mutex_lock(&s->s_root->d_inode->i_mutex); | 978 | reiserfs_mutex_lock_safe(&s->s_root->d_inode->i_mutex, s); |
| 979 | dentry = lookup_one_len(PRIVROOT_NAME, s->s_root, | 979 | dentry = lookup_one_len(PRIVROOT_NAME, s->s_root, |
| 980 | strlen(PRIVROOT_NAME)); | 980 | strlen(PRIVROOT_NAME)); |
| 981 | if (!IS_ERR(dentry)) { | 981 | if (!IS_ERR(dentry)) { |
| @@ -1004,14 +1004,14 @@ int reiserfs_xattr_init(struct super_block *s, int mount_flags) | |||
| 1004 | goto error; | 1004 | goto error; |
| 1005 | 1005 | ||
| 1006 | if (!privroot->d_inode && !(mount_flags & MS_RDONLY)) { | 1006 | if (!privroot->d_inode && !(mount_flags & MS_RDONLY)) { |
| 1007 | mutex_lock(&s->s_root->d_inode->i_mutex); | 1007 | reiserfs_mutex_lock_safe(&s->s_root->d_inode->i_mutex, s); |
| 1008 | err = create_privroot(REISERFS_SB(s)->priv_root); | 1008 | err = create_privroot(REISERFS_SB(s)->priv_root); |
| 1009 | mutex_unlock(&s->s_root->d_inode->i_mutex); | 1009 | mutex_unlock(&s->s_root->d_inode->i_mutex); |
| 1010 | } | 1010 | } |
| 1011 | 1011 | ||
| 1012 | if (privroot->d_inode) { | 1012 | if (privroot->d_inode) { |
| 1013 | s->s_xattr = reiserfs_xattr_handlers; | 1013 | s->s_xattr = reiserfs_xattr_handlers; |
| 1014 | mutex_lock(&privroot->d_inode->i_mutex); | 1014 | reiserfs_mutex_lock_safe(&privroot->d_inode->i_mutex, s); |
| 1015 | if (!REISERFS_SB(s)->xattr_root) { | 1015 | if (!REISERFS_SB(s)->xattr_root) { |
| 1016 | struct dentry *dentry; | 1016 | struct dentry *dentry; |
| 1017 | dentry = lookup_one_len(XAROOT_NAME, privroot, | 1017 | dentry = lookup_one_len(XAROOT_NAME, privroot, |
diff --git a/fs/splice.c b/fs/splice.c index 7394e9e17534..39208663aaf1 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
| @@ -648,9 +648,11 @@ static int pipe_to_sendpage(struct pipe_inode_info *pipe, | |||
| 648 | ret = buf->ops->confirm(pipe, buf); | 648 | ret = buf->ops->confirm(pipe, buf); |
| 649 | if (!ret) { | 649 | if (!ret) { |
| 650 | more = (sd->flags & SPLICE_F_MORE) || sd->len < sd->total_len; | 650 | more = (sd->flags & SPLICE_F_MORE) || sd->len < sd->total_len; |
| 651 | 651 | if (file->f_op && file->f_op->sendpage) | |
| 652 | ret = file->f_op->sendpage(file, buf->page, buf->offset, | 652 | ret = file->f_op->sendpage(file, buf->page, buf->offset, |
| 653 | sd->len, &pos, more); | 653 | sd->len, &pos, more); |
| 654 | else | ||
| 655 | ret = -EINVAL; | ||
| 654 | } | 656 | } |
| 655 | 657 | ||
| 656 | return ret; | 658 | return ret; |
| @@ -1068,8 +1070,9 @@ static long do_splice_from(struct pipe_inode_info *pipe, struct file *out, | |||
| 1068 | if (unlikely(ret < 0)) | 1070 | if (unlikely(ret < 0)) |
| 1069 | return ret; | 1071 | return ret; |
| 1070 | 1072 | ||
| 1071 | splice_write = out->f_op->splice_write; | 1073 | if (out->f_op && out->f_op->splice_write) |
| 1072 | if (!splice_write) | 1074 | splice_write = out->f_op->splice_write; |
| 1075 | else | ||
| 1073 | splice_write = default_file_splice_write; | 1076 | splice_write = default_file_splice_write; |
| 1074 | 1077 | ||
| 1075 | return splice_write(pipe, out, ppos, len, flags); | 1078 | return splice_write(pipe, out, ppos, len, flags); |
| @@ -1093,8 +1096,9 @@ static long do_splice_to(struct file *in, loff_t *ppos, | |||
| 1093 | if (unlikely(ret < 0)) | 1096 | if (unlikely(ret < 0)) |
| 1094 | return ret; | 1097 | return ret; |
| 1095 | 1098 | ||
| 1096 | splice_read = in->f_op->splice_read; | 1099 | if (in->f_op && in->f_op->splice_read) |
| 1097 | if (!splice_read) | 1100 | splice_read = in->f_op->splice_read; |
| 1101 | else | ||
| 1098 | splice_read = default_file_splice_read; | 1102 | splice_read = default_file_splice_read; |
| 1099 | 1103 | ||
| 1100 | return splice_read(in, ppos, pipe, len, flags); | 1104 | return splice_read(in, ppos, pipe, len, flags); |
| @@ -1316,7 +1320,8 @@ static long do_splice(struct file *in, loff_t __user *off_in, | |||
| 1316 | if (off_in) | 1320 | if (off_in) |
| 1317 | return -ESPIPE; | 1321 | return -ESPIPE; |
| 1318 | if (off_out) { | 1322 | if (off_out) { |
| 1319 | if (out->f_op->llseek == no_llseek) | 1323 | if (!out->f_op || !out->f_op->llseek || |
| 1324 | out->f_op->llseek == no_llseek) | ||
| 1320 | return -EINVAL; | 1325 | return -EINVAL; |
| 1321 | if (copy_from_user(&offset, off_out, sizeof(loff_t))) | 1326 | if (copy_from_user(&offset, off_out, sizeof(loff_t))) |
| 1322 | return -EFAULT; | 1327 | return -EFAULT; |
| @@ -1336,7 +1341,8 @@ static long do_splice(struct file *in, loff_t __user *off_in, | |||
| 1336 | if (off_out) | 1341 | if (off_out) |
| 1337 | return -ESPIPE; | 1342 | return -ESPIPE; |
| 1338 | if (off_in) { | 1343 | if (off_in) { |
| 1339 | if (in->f_op->llseek == no_llseek) | 1344 | if (!in->f_op || !in->f_op->llseek || |
| 1345 | in->f_op->llseek == no_llseek) | ||
| 1340 | return -EINVAL; | 1346 | return -EINVAL; |
| 1341 | if (copy_from_user(&offset, off_in, sizeof(loff_t))) | 1347 | if (copy_from_user(&offset, off_in, sizeof(loff_t))) |
| 1342 | return -EFAULT; | 1348 | return -EFAULT; |
| @@ -295,10 +295,11 @@ SYSCALL_DEFINE1(fdatasync, unsigned int, fd) | |||
| 295 | */ | 295 | */ |
| 296 | int generic_write_sync(struct file *file, loff_t pos, loff_t count) | 296 | int generic_write_sync(struct file *file, loff_t pos, loff_t count) |
| 297 | { | 297 | { |
| 298 | if (!(file->f_flags & O_SYNC) && !IS_SYNC(file->f_mapping->host)) | 298 | if (!(file->f_flags & O_DSYNC) && !IS_SYNC(file->f_mapping->host)) |
| 299 | return 0; | 299 | return 0; |
| 300 | return vfs_fsync_range(file, file->f_path.dentry, pos, | 300 | return vfs_fsync_range(file, file->f_path.dentry, pos, |
| 301 | pos + count - 1, 1); | 301 | pos + count - 1, |
| 302 | (file->f_flags & __O_SYNC) ? 0 : 1); | ||
| 302 | } | 303 | } |
| 303 | EXPORT_SYMBOL(generic_write_sync); | 304 | EXPORT_SYMBOL(generic_write_sync); |
| 304 | 305 | ||
| @@ -452,9 +453,7 @@ int do_sync_mapping_range(struct address_space *mapping, loff_t offset, | |||
| 452 | 453 | ||
| 453 | ret = 0; | 454 | ret = 0; |
| 454 | if (flags & SYNC_FILE_RANGE_WAIT_BEFORE) { | 455 | if (flags & SYNC_FILE_RANGE_WAIT_BEFORE) { |
| 455 | ret = wait_on_page_writeback_range(mapping, | 456 | ret = filemap_fdatawait_range(mapping, offset, endbyte); |
| 456 | offset >> PAGE_CACHE_SHIFT, | ||
| 457 | endbyte >> PAGE_CACHE_SHIFT); | ||
| 458 | if (ret < 0) | 457 | if (ret < 0) |
| 459 | goto out; | 458 | goto out; |
| 460 | } | 459 | } |
| @@ -467,9 +466,7 @@ int do_sync_mapping_range(struct address_space *mapping, loff_t offset, | |||
| 467 | } | 466 | } |
| 468 | 467 | ||
| 469 | if (flags & SYNC_FILE_RANGE_WAIT_AFTER) { | 468 | if (flags & SYNC_FILE_RANGE_WAIT_AFTER) { |
| 470 | ret = wait_on_page_writeback_range(mapping, | 469 | ret = filemap_fdatawait_range(mapping, offset, endbyte); |
| 471 | offset >> PAGE_CACHE_SHIFT, | ||
| 472 | endbyte >> PAGE_CACHE_SHIFT); | ||
| 473 | } | 470 | } |
| 474 | out: | 471 | out: |
| 475 | return ret; | 472 | return ret; |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index e0201837d244..f05f2303a8b8 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
| @@ -25,7 +25,6 @@ | |||
| 25 | #include "sysfs.h" | 25 | #include "sysfs.h" |
| 26 | 26 | ||
| 27 | DEFINE_MUTEX(sysfs_mutex); | 27 | DEFINE_MUTEX(sysfs_mutex); |
| 28 | DEFINE_MUTEX(sysfs_rename_mutex); | ||
| 29 | DEFINE_SPINLOCK(sysfs_assoc_lock); | 28 | DEFINE_SPINLOCK(sysfs_assoc_lock); |
| 30 | 29 | ||
| 31 | static DEFINE_SPINLOCK(sysfs_ino_lock); | 30 | static DEFINE_SPINLOCK(sysfs_ino_lock); |
| @@ -85,46 +84,6 @@ static void sysfs_unlink_sibling(struct sysfs_dirent *sd) | |||
| 85 | } | 84 | } |
| 86 | 85 | ||
| 87 | /** | 86 | /** |
| 88 | * sysfs_get_dentry - get dentry for the given sysfs_dirent | ||
| 89 | * @sd: sysfs_dirent of interest | ||
| 90 | * | ||
| 91 | * Get dentry for @sd. Dentry is looked up if currently not | ||
| 92 | * present. This function descends from the root looking up | ||
| 93 | * dentry for each step. | ||
| 94 | * | ||
| 95 | * LOCKING: | ||
| 96 | * mutex_lock(sysfs_rename_mutex) | ||
| 97 | * | ||
| 98 | * RETURNS: | ||
| 99 | * Pointer to found dentry on success, ERR_PTR() value on error. | ||
| 100 | */ | ||
| 101 | struct dentry *sysfs_get_dentry(struct sysfs_dirent *sd) | ||
| 102 | { | ||
| 103 | struct dentry *dentry = dget(sysfs_sb->s_root); | ||
| 104 | |||
| 105 | while (dentry->d_fsdata != sd) { | ||
| 106 | struct sysfs_dirent *cur; | ||
| 107 | struct dentry *parent; | ||
| 108 | |||
| 109 | /* find the first ancestor which hasn't been looked up */ | ||
| 110 | cur = sd; | ||
| 111 | while (cur->s_parent != dentry->d_fsdata) | ||
| 112 | cur = cur->s_parent; | ||
| 113 | |||
| 114 | /* look it up */ | ||
| 115 | parent = dentry; | ||
| 116 | mutex_lock(&parent->d_inode->i_mutex); | ||
| 117 | dentry = lookup_one_noperm(cur->s_name, parent); | ||
| 118 | mutex_unlock(&parent->d_inode->i_mutex); | ||
| 119 | dput(parent); | ||
| 120 | |||
| 121 | if (IS_ERR(dentry)) | ||
| 122 | break; | ||
| 123 | } | ||
| 124 | return dentry; | ||
| 125 | } | ||
| 126 | |||
| 127 | /** | ||
| 128 | * sysfs_get_active - get an active reference to sysfs_dirent | 87 | * sysfs_get_active - get an active reference to sysfs_dirent |
| 129 | * @sd: sysfs_dirent to get an active reference to | 88 | * @sd: sysfs_dirent to get an active reference to |
| 130 | * | 89 | * |
| @@ -298,7 +257,61 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) | |||
| 298 | goto repeat; | 257 | goto repeat; |
| 299 | } | 258 | } |
| 300 | 259 | ||
| 301 | static void sysfs_d_iput(struct dentry * dentry, struct inode * inode) | 260 | static int sysfs_dentry_delete(struct dentry *dentry) |
| 261 | { | ||
| 262 | struct sysfs_dirent *sd = dentry->d_fsdata; | ||
| 263 | return !!(sd->s_flags & SYSFS_FLAG_REMOVED); | ||
| 264 | } | ||
| 265 | |||
| 266 | static int sysfs_dentry_revalidate(struct dentry *dentry, struct nameidata *nd) | ||
| 267 | { | ||
| 268 | struct sysfs_dirent *sd = dentry->d_fsdata; | ||
| 269 | int is_dir; | ||
| 270 | |||
| 271 | mutex_lock(&sysfs_mutex); | ||
| 272 | |||
| 273 | /* The sysfs dirent has been deleted */ | ||
| 274 | if (sd->s_flags & SYSFS_FLAG_REMOVED) | ||
| 275 | goto out_bad; | ||
| 276 | |||
| 277 | /* The sysfs dirent has been moved? */ | ||
| 278 | if (dentry->d_parent->d_fsdata != sd->s_parent) | ||
| 279 | goto out_bad; | ||
| 280 | |||
| 281 | /* The sysfs dirent has been renamed */ | ||
| 282 | if (strcmp(dentry->d_name.name, sd->s_name) != 0) | ||
| 283 | goto out_bad; | ||
| 284 | |||
| 285 | mutex_unlock(&sysfs_mutex); | ||
| 286 | out_valid: | ||
| 287 | return 1; | ||
| 288 | out_bad: | ||
| 289 | /* Remove the dentry from the dcache hashes. | ||
| 290 | * If this is a deleted dentry we use d_drop instead of d_delete | ||
| 291 | * so sysfs doesn't need to cope with negative dentries. | ||
| 292 | * | ||
| 293 | * If this is a dentry that has simply been renamed we | ||
| 294 | * use d_drop to remove it from the dcache lookup on its | ||
| 295 | * old parent. If this dentry persists later when a lookup | ||
| 296 | * is performed at its new name the dentry will be readded | ||
| 297 | * to the dcache hashes. | ||
| 298 | */ | ||
| 299 | is_dir = (sysfs_type(sd) == SYSFS_DIR); | ||
| 300 | mutex_unlock(&sysfs_mutex); | ||
| 301 | if (is_dir) { | ||
| 302 | /* If we have submounts we must allow the vfs caches | ||
| 303 | * to lie about the state of the filesystem to prevent | ||
| 304 | * leaks and other nasty things. | ||
| 305 | */ | ||
| 306 | if (have_submounts(dentry)) | ||
| 307 | goto out_valid; | ||
| 308 | shrink_dcache_parent(dentry); | ||
| 309 | } | ||
| 310 | d_drop(dentry); | ||
| 311 | return 0; | ||
| 312 | } | ||
| 313 | |||
| 314 | static void sysfs_dentry_iput(struct dentry *dentry, struct inode *inode) | ||
| 302 | { | 315 | { |
| 303 | struct sysfs_dirent * sd = dentry->d_fsdata; | 316 | struct sysfs_dirent * sd = dentry->d_fsdata; |
| 304 | 317 | ||
| @@ -307,7 +320,9 @@ static void sysfs_d_iput(struct dentry * dentry, struct inode * inode) | |||
| 307 | } | 320 | } |
| 308 | 321 | ||
| 309 | static const struct dentry_operations sysfs_dentry_ops = { | 322 | static const struct dentry_operations sysfs_dentry_ops = { |
| 310 | .d_iput = sysfs_d_iput, | 323 | .d_revalidate = sysfs_dentry_revalidate, |
| 324 | .d_delete = sysfs_dentry_delete, | ||
| 325 | .d_iput = sysfs_dentry_iput, | ||
| 311 | }; | 326 | }; |
| 312 | 327 | ||
| 313 | struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) | 328 | struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) |
| @@ -344,12 +359,6 @@ struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) | |||
| 344 | return NULL; | 359 | return NULL; |
| 345 | } | 360 | } |
| 346 | 361 | ||
| 347 | static int sysfs_ilookup_test(struct inode *inode, void *arg) | ||
| 348 | { | ||
| 349 | struct sysfs_dirent *sd = arg; | ||
| 350 | return inode->i_ino == sd->s_ino; | ||
| 351 | } | ||
| 352 | |||
| 353 | /** | 362 | /** |
| 354 | * sysfs_addrm_start - prepare for sysfs_dirent add/remove | 363 | * sysfs_addrm_start - prepare for sysfs_dirent add/remove |
| 355 | * @acxt: pointer to sysfs_addrm_cxt to be used | 364 | * @acxt: pointer to sysfs_addrm_cxt to be used |
| @@ -357,47 +366,20 @@ static int sysfs_ilookup_test(struct inode *inode, void *arg) | |||
| 357 | * | 366 | * |
| 358 | * This function is called when the caller is about to add or | 367 | * This function is called when the caller is about to add or |
| 359 | * remove sysfs_dirent under @parent_sd. This function acquires | 368 | * remove sysfs_dirent under @parent_sd. This function acquires |
| 360 | * sysfs_mutex, grabs inode for @parent_sd if available and lock | 369 | * sysfs_mutex. @acxt is used to keep and pass context to |
| 361 | * i_mutex of it. @acxt is used to keep and pass context to | ||
| 362 | * other addrm functions. | 370 | * other addrm functions. |
| 363 | * | 371 | * |
| 364 | * LOCKING: | 372 | * LOCKING: |
| 365 | * Kernel thread context (may sleep). sysfs_mutex is locked on | 373 | * Kernel thread context (may sleep). sysfs_mutex is locked on |
| 366 | * return. i_mutex of parent inode is locked on return if | 374 | * return. |
| 367 | * available. | ||
| 368 | */ | 375 | */ |
| 369 | void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt, | 376 | void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt, |
| 370 | struct sysfs_dirent *parent_sd) | 377 | struct sysfs_dirent *parent_sd) |
| 371 | { | 378 | { |
| 372 | struct inode *inode; | ||
| 373 | |||
| 374 | memset(acxt, 0, sizeof(*acxt)); | 379 | memset(acxt, 0, sizeof(*acxt)); |
| 375 | acxt->parent_sd = parent_sd; | 380 | acxt->parent_sd = parent_sd; |
| 376 | 381 | ||
| 377 | /* Lookup parent inode. inode initialization is protected by | ||
| 378 | * sysfs_mutex, so inode existence can be determined by | ||
| 379 | * looking up inode while holding sysfs_mutex. | ||
| 380 | */ | ||
| 381 | mutex_lock(&sysfs_mutex); | 382 | mutex_lock(&sysfs_mutex); |
| 382 | |||
| 383 | inode = ilookup5(sysfs_sb, parent_sd->s_ino, sysfs_ilookup_test, | ||
| 384 | parent_sd); | ||
| 385 | if (inode) { | ||
| 386 | WARN_ON(inode->i_state & I_NEW); | ||
| 387 | |||
| 388 | /* parent inode available */ | ||
| 389 | acxt->parent_inode = inode; | ||
| 390 | |||
| 391 | /* sysfs_mutex is below i_mutex in lock hierarchy. | ||
| 392 | * First, trylock i_mutex. If fails, unlock | ||
| 393 | * sysfs_mutex and lock them in order. | ||
| 394 | */ | ||
| 395 | if (!mutex_trylock(&inode->i_mutex)) { | ||
| 396 | mutex_unlock(&sysfs_mutex); | ||
| 397 | mutex_lock(&inode->i_mutex); | ||
| 398 | mutex_lock(&sysfs_mutex); | ||
| 399 | } | ||
| 400 | } | ||
| 401 | } | 383 | } |
| 402 | 384 | ||
| 403 | /** | 385 | /** |
| @@ -422,18 +404,22 @@ void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt, | |||
| 422 | */ | 404 | */ |
| 423 | int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) | 405 | int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) |
| 424 | { | 406 | { |
| 407 | struct sysfs_inode_attrs *ps_iattr; | ||
| 408 | |||
| 425 | if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) | 409 | if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) |
| 426 | return -EEXIST; | 410 | return -EEXIST; |
| 427 | 411 | ||
| 428 | sd->s_parent = sysfs_get(acxt->parent_sd); | 412 | sd->s_parent = sysfs_get(acxt->parent_sd); |
| 429 | 413 | ||
| 430 | if (sysfs_type(sd) == SYSFS_DIR && acxt->parent_inode) | ||
| 431 | inc_nlink(acxt->parent_inode); | ||
| 432 | |||
| 433 | acxt->cnt++; | ||
| 434 | |||
| 435 | sysfs_link_sibling(sd); | 414 | sysfs_link_sibling(sd); |
| 436 | 415 | ||
| 416 | /* Update timestamps on the parent */ | ||
| 417 | ps_iattr = acxt->parent_sd->s_iattr; | ||
| 418 | if (ps_iattr) { | ||
| 419 | struct iattr *ps_iattrs = &ps_iattr->ia_iattr; | ||
| 420 | ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME; | ||
| 421 | } | ||
| 422 | |||
| 437 | return 0; | 423 | return 0; |
| 438 | } | 424 | } |
| 439 | 425 | ||
| @@ -512,70 +498,22 @@ int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) | |||
| 512 | */ | 498 | */ |
| 513 | void sysfs_remove_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) | 499 | void sysfs_remove_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) |
| 514 | { | 500 | { |
| 501 | struct sysfs_inode_attrs *ps_iattr; | ||
| 502 | |||
| 515 | BUG_ON(sd->s_flags & SYSFS_FLAG_REMOVED); | 503 | BUG_ON(sd->s_flags & SYSFS_FLAG_REMOVED); |
| 516 | 504 | ||
| 517 | sysfs_unlink_sibling(sd); | 505 | sysfs_unlink_sibling(sd); |
| 518 | 506 | ||
| 507 | /* Update timestamps on the parent */ | ||
| 508 | ps_iattr = acxt->parent_sd->s_iattr; | ||
| 509 | if (ps_iattr) { | ||
| 510 | struct iattr *ps_iattrs = &ps_iattr->ia_iattr; | ||
| 511 | ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME; | ||
| 512 | } | ||
| 513 | |||
| 519 | sd->s_flags |= SYSFS_FLAG_REMOVED; | 514 | sd->s_flags |= SYSFS_FLAG_REMOVED; |
| 520 | sd->s_sibling = acxt->removed; | 515 | sd->s_sibling = acxt->removed; |
| 521 | acxt->removed = sd; | 516 | acxt->removed = sd; |
| 522 | |||
| 523 | if (sysfs_type(sd) == SYSFS_DIR && acxt->parent_inode) | ||
| 524 | drop_nlink(acxt->parent_inode); | ||
| 525 | |||
| 526 | acxt->cnt++; | ||
| 527 | } | ||
| 528 | |||
| 529 | /** | ||
| 530 | * sysfs_drop_dentry - drop dentry for the specified sysfs_dirent | ||
| 531 | * @sd: target sysfs_dirent | ||
| 532 | * | ||
| 533 | * Drop dentry for @sd. @sd must have been unlinked from its | ||
| 534 | * parent on entry to this function such that it can't be looked | ||
| 535 | * up anymore. | ||
| 536 | */ | ||
| 537 | static void sysfs_drop_dentry(struct sysfs_dirent *sd) | ||
| 538 | { | ||
| 539 | struct inode *inode; | ||
| 540 | struct dentry *dentry; | ||
| 541 | |||
| 542 | inode = ilookup(sysfs_sb, sd->s_ino); | ||
| 543 | if (!inode) | ||
| 544 | return; | ||
| 545 | |||
| 546 | /* Drop any existing dentries associated with sd. | ||
| 547 | * | ||
| 548 | * For the dentry to be properly freed we need to grab a | ||
| 549 | * reference to the dentry under the dcache lock, unhash it, | ||
| 550 | * and then put it. The playing with the dentry count allows | ||
| 551 | * dput to immediately free the dentry if it is not in use. | ||
| 552 | */ | ||
| 553 | repeat: | ||
| 554 | spin_lock(&dcache_lock); | ||
| 555 | list_for_each_entry(dentry, &inode->i_dentry, d_alias) { | ||
| 556 | if (d_unhashed(dentry)) | ||
| 557 | continue; | ||
| 558 | dget_locked(dentry); | ||
| 559 | spin_lock(&dentry->d_lock); | ||
| 560 | __d_drop(dentry); | ||
| 561 | spin_unlock(&dentry->d_lock); | ||
| 562 | spin_unlock(&dcache_lock); | ||
| 563 | dput(dentry); | ||
| 564 | goto repeat; | ||
| 565 | } | ||
| 566 | spin_unlock(&dcache_lock); | ||
| 567 | |||
| 568 | /* adjust nlink and update timestamp */ | ||
| 569 | mutex_lock(&inode->i_mutex); | ||
| 570 | |||
| 571 | inode->i_ctime = CURRENT_TIME; | ||
| 572 | drop_nlink(inode); | ||
| 573 | if (sysfs_type(sd) == SYSFS_DIR) | ||
| 574 | drop_nlink(inode); | ||
| 575 | |||
| 576 | mutex_unlock(&inode->i_mutex); | ||
| 577 | |||
| 578 | iput(inode); | ||
| 579 | } | 517 | } |
| 580 | 518 | ||
| 581 | /** | 519 | /** |
| @@ -584,25 +522,15 @@ repeat: | |||
| 584 | * | 522 | * |
| 585 | * Finish up sysfs_dirent add/remove. Resources acquired by | 523 | * Finish up sysfs_dirent add/remove. Resources acquired by |
| 586 | * sysfs_addrm_start() are released and removed sysfs_dirents are | 524 | * sysfs_addrm_start() are released and removed sysfs_dirents are |
| 587 | * cleaned up. Timestamps on the parent inode are updated. | 525 | * cleaned up. |
| 588 | * | 526 | * |
| 589 | * LOCKING: | 527 | * LOCKING: |
| 590 | * All mutexes acquired by sysfs_addrm_start() are released. | 528 | * sysfs_mutex is released. |
| 591 | */ | 529 | */ |
| 592 | void sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt) | 530 | void sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt) |
| 593 | { | 531 | { |
| 594 | /* release resources acquired by sysfs_addrm_start() */ | 532 | /* release resources acquired by sysfs_addrm_start() */ |
| 595 | mutex_unlock(&sysfs_mutex); | 533 | mutex_unlock(&sysfs_mutex); |
| 596 | if (acxt->parent_inode) { | ||
| 597 | struct inode *inode = acxt->parent_inode; | ||
| 598 | |||
| 599 | /* if added/removed, update timestamps on the parent */ | ||
| 600 | if (acxt->cnt) | ||
| 601 | inode->i_ctime = inode->i_mtime = CURRENT_TIME; | ||
| 602 | |||
| 603 | mutex_unlock(&inode->i_mutex); | ||
| 604 | iput(inode); | ||
| 605 | } | ||
| 606 | 534 | ||
| 607 | /* kill removed sysfs_dirents */ | 535 | /* kill removed sysfs_dirents */ |
| 608 | while (acxt->removed) { | 536 | while (acxt->removed) { |
| @@ -611,7 +539,6 @@ void sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt) | |||
| 611 | acxt->removed = sd->s_sibling; | 539 | acxt->removed = sd->s_sibling; |
| 612 | sd->s_sibling = NULL; | 540 | sd->s_sibling = NULL; |
| 613 | 541 | ||
| 614 | sysfs_drop_dentry(sd); | ||
| 615 | sysfs_deactivate(sd); | 542 | sysfs_deactivate(sd); |
| 616 | unmap_bin_file(sd); | 543 | unmap_bin_file(sd); |
| 617 | sysfs_put(sd); | 544 | sysfs_put(sd); |
| @@ -751,10 +678,15 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 751 | } | 678 | } |
| 752 | 679 | ||
| 753 | /* instantiate and hash dentry */ | 680 | /* instantiate and hash dentry */ |
| 754 | dentry->d_op = &sysfs_dentry_ops; | 681 | ret = d_find_alias(inode); |
| 755 | dentry->d_fsdata = sysfs_get(sd); | 682 | if (!ret) { |
| 756 | d_instantiate(dentry, inode); | 683 | dentry->d_op = &sysfs_dentry_ops; |
| 757 | d_rehash(dentry); | 684 | dentry->d_fsdata = sysfs_get(sd); |
| 685 | d_add(dentry, inode); | ||
| 686 | } else { | ||
| 687 | d_move(ret, dentry); | ||
| 688 | iput(inode); | ||
| 689 | } | ||
| 758 | 690 | ||
| 759 | out_unlock: | 691 | out_unlock: |
| 760 | mutex_unlock(&sysfs_mutex); | 692 | mutex_unlock(&sysfs_mutex); |
| @@ -763,7 +695,9 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
| 763 | 695 | ||
| 764 | const struct inode_operations sysfs_dir_inode_operations = { | 696 | const struct inode_operations sysfs_dir_inode_operations = { |
| 765 | .lookup = sysfs_lookup, | 697 | .lookup = sysfs_lookup, |
| 698 | .permission = sysfs_permission, | ||
| 766 | .setattr = sysfs_setattr, | 699 | .setattr = sysfs_setattr, |
| 700 | .getattr = sysfs_getattr, | ||
| 767 | .setxattr = sysfs_setxattr, | 701 | .setxattr = sysfs_setxattr, |
| 768 | }; | 702 | }; |
| 769 | 703 | ||
| @@ -826,141 +760,65 @@ void sysfs_remove_dir(struct kobject * kobj) | |||
| 826 | __sysfs_remove_dir(sd); | 760 | __sysfs_remove_dir(sd); |
| 827 | } | 761 | } |
| 828 | 762 | ||
| 829 | int sysfs_rename_dir(struct kobject * kobj, const char *new_name) | 763 | int sysfs_rename(struct sysfs_dirent *sd, |
| 764 | struct sysfs_dirent *new_parent_sd, const char *new_name) | ||
| 830 | { | 765 | { |
| 831 | struct sysfs_dirent *sd = kobj->sd; | ||
| 832 | struct dentry *parent = NULL; | ||
| 833 | struct dentry *old_dentry = NULL, *new_dentry = NULL; | ||
| 834 | const char *dup_name = NULL; | 766 | const char *dup_name = NULL; |
| 835 | int error; | 767 | int error; |
| 836 | 768 | ||
| 837 | mutex_lock(&sysfs_rename_mutex); | 769 | mutex_lock(&sysfs_mutex); |
| 838 | 770 | ||
| 839 | error = 0; | 771 | error = 0; |
| 840 | if (strcmp(sd->s_name, new_name) == 0) | 772 | if ((sd->s_parent == new_parent_sd) && |
| 773 | (strcmp(sd->s_name, new_name) == 0)) | ||
| 841 | goto out; /* nothing to rename */ | 774 | goto out; /* nothing to rename */ |
| 842 | 775 | ||
| 843 | /* get the original dentry */ | ||
| 844 | old_dentry = sysfs_get_dentry(sd); | ||
| 845 | if (IS_ERR(old_dentry)) { | ||
| 846 | error = PTR_ERR(old_dentry); | ||
| 847 | old_dentry = NULL; | ||
| 848 | goto out; | ||
| 849 | } | ||
| 850 | |||
| 851 | parent = old_dentry->d_parent; | ||
| 852 | |||
| 853 | /* lock parent and get dentry for new name */ | ||
| 854 | mutex_lock(&parent->d_inode->i_mutex); | ||
| 855 | mutex_lock(&sysfs_mutex); | ||
| 856 | |||
| 857 | error = -EEXIST; | 776 | error = -EEXIST; |
| 858 | if (sysfs_find_dirent(sd->s_parent, new_name)) | 777 | if (sysfs_find_dirent(new_parent_sd, new_name)) |
| 859 | goto out_unlock; | 778 | goto out; |
| 860 | |||
| 861 | error = -ENOMEM; | ||
| 862 | new_dentry = d_alloc_name(parent, new_name); | ||
| 863 | if (!new_dentry) | ||
| 864 | goto out_unlock; | ||
| 865 | 779 | ||
| 866 | /* rename sysfs_dirent */ | 780 | /* rename sysfs_dirent */ |
| 867 | error = -ENOMEM; | 781 | if (strcmp(sd->s_name, new_name) != 0) { |
| 868 | new_name = dup_name = kstrdup(new_name, GFP_KERNEL); | 782 | error = -ENOMEM; |
| 869 | if (!new_name) | 783 | new_name = dup_name = kstrdup(new_name, GFP_KERNEL); |
| 870 | goto out_unlock; | 784 | if (!new_name) |
| 871 | 785 | goto out; | |
| 872 | dup_name = sd->s_name; | 786 | |
| 873 | sd->s_name = new_name; | 787 | dup_name = sd->s_name; |
| 788 | sd->s_name = new_name; | ||
| 789 | } | ||
| 874 | 790 | ||
| 875 | /* rename */ | 791 | /* Remove from old parent's list and insert into new parent's list. */ |
| 876 | d_add(new_dentry, NULL); | 792 | if (sd->s_parent != new_parent_sd) { |
| 877 | d_move(old_dentry, new_dentry); | 793 | sysfs_unlink_sibling(sd); |
| 794 | sysfs_get(new_parent_sd); | ||
| 795 | sysfs_put(sd->s_parent); | ||
| 796 | sd->s_parent = new_parent_sd; | ||
| 797 | sysfs_link_sibling(sd); | ||
| 798 | } | ||
| 878 | 799 | ||
| 879 | error = 0; | 800 | error = 0; |
| 880 | out_unlock: | 801 | out: |
| 881 | mutex_unlock(&sysfs_mutex); | 802 | mutex_unlock(&sysfs_mutex); |
| 882 | mutex_unlock(&parent->d_inode->i_mutex); | ||
| 883 | kfree(dup_name); | 803 | kfree(dup_name); |
| 884 | dput(old_dentry); | ||
| 885 | dput(new_dentry); | ||
| 886 | out: | ||
| 887 | mutex_unlock(&sysfs_rename_mutex); | ||
| 888 | return error; | 804 | return error; |
| 889 | } | 805 | } |
| 890 | 806 | ||
| 807 | int sysfs_rename_dir(struct kobject *kobj, const char *new_name) | ||
| 808 | { | ||
| 809 | return sysfs_rename(kobj->sd, kobj->sd->s_parent, new_name); | ||
| 810 | } | ||
| 811 | |||
| 891 | int sysfs_move_dir(struct kobject *kobj, struct kobject *new_parent_kobj) | 812 | int sysfs_move_dir(struct kobject *kobj, struct kobject *new_parent_kobj) |
| 892 | { | 813 | { |
| 893 | struct sysfs_dirent *sd = kobj->sd; | 814 | struct sysfs_dirent *sd = kobj->sd; |
| 894 | struct sysfs_dirent *new_parent_sd; | 815 | struct sysfs_dirent *new_parent_sd; |
| 895 | struct dentry *old_parent, *new_parent = NULL; | ||
| 896 | struct dentry *old_dentry = NULL, *new_dentry = NULL; | ||
| 897 | int error; | ||
| 898 | 816 | ||
| 899 | mutex_lock(&sysfs_rename_mutex); | ||
| 900 | BUG_ON(!sd->s_parent); | 817 | BUG_ON(!sd->s_parent); |
| 901 | new_parent_sd = (new_parent_kobj && new_parent_kobj->sd) ? | 818 | new_parent_sd = new_parent_kobj && new_parent_kobj->sd ? |
| 902 | new_parent_kobj->sd : &sysfs_root; | 819 | new_parent_kobj->sd : &sysfs_root; |
| 903 | 820 | ||
| 904 | error = 0; | 821 | return sysfs_rename(sd, new_parent_sd, sd->s_name); |
| 905 | if (sd->s_parent == new_parent_sd) | ||
| 906 | goto out; /* nothing to move */ | ||
| 907 | |||
| 908 | /* get dentries */ | ||
| 909 | old_dentry = sysfs_get_dentry(sd); | ||
| 910 | if (IS_ERR(old_dentry)) { | ||
| 911 | error = PTR_ERR(old_dentry); | ||
| 912 | old_dentry = NULL; | ||
| 913 | goto out; | ||
| 914 | } | ||
| 915 | old_parent = old_dentry->d_parent; | ||
| 916 | |||
| 917 | new_parent = sysfs_get_dentry(new_parent_sd); | ||
| 918 | if (IS_ERR(new_parent)) { | ||
| 919 | error = PTR_ERR(new_parent); | ||
| 920 | new_parent = NULL; | ||
| 921 | goto out; | ||
| 922 | } | ||
| 923 | |||
| 924 | again: | ||
| 925 | mutex_lock(&old_parent->d_inode->i_mutex); | ||
| 926 | if (!mutex_trylock(&new_parent->d_inode->i_mutex)) { | ||
| 927 | mutex_unlock(&old_parent->d_inode->i_mutex); | ||
| 928 | goto again; | ||
| 929 | } | ||
| 930 | mutex_lock(&sysfs_mutex); | ||
| 931 | |||
| 932 | error = -EEXIST; | ||
| 933 | if (sysfs_find_dirent(new_parent_sd, sd->s_name)) | ||
| 934 | goto out_unlock; | ||
| 935 | |||
| 936 | error = -ENOMEM; | ||
| 937 | new_dentry = d_alloc_name(new_parent, sd->s_name); | ||
| 938 | if (!new_dentry) | ||
| 939 | goto out_unlock; | ||
| 940 | |||
| 941 | error = 0; | ||
| 942 | d_add(new_dentry, NULL); | ||
| 943 | d_move(old_dentry, new_dentry); | ||
| 944 | |||
| 945 | /* Remove from old parent's list and insert into new parent's list. */ | ||
| 946 | sysfs_unlink_sibling(sd); | ||
| 947 | sysfs_get(new_parent_sd); | ||
| 948 | drop_nlink(old_parent->d_inode); | ||
| 949 | sysfs_put(sd->s_parent); | ||
| 950 | sd->s_parent = new_parent_sd; | ||
| 951 | inc_nlink(new_parent->d_inode); | ||
| 952 | sysfs_link_sibling(sd); | ||
| 953 | |||
| 954 | out_unlock: | ||
| 955 | mutex_unlock(&sysfs_mutex); | ||
| 956 | mutex_unlock(&new_parent->d_inode->i_mutex); | ||
| 957 | mutex_unlock(&old_parent->d_inode->i_mutex); | ||
| 958 | out: | ||
| 959 | dput(new_parent); | ||
| 960 | dput(old_dentry); | ||
| 961 | dput(new_dentry); | ||
| 962 | mutex_unlock(&sysfs_rename_mutex); | ||
| 963 | return error; | ||
| 964 | } | 822 | } |
| 965 | 823 | ||
| 966 | /* Relationship between s_mode and the DT_xxx types */ | 824 | /* Relationship between s_mode and the DT_xxx types */ |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index f5ea4680f15f..dc30d9e31683 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
| @@ -579,46 +579,23 @@ EXPORT_SYMBOL_GPL(sysfs_add_file_to_group); | |||
| 579 | */ | 579 | */ |
| 580 | int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode) | 580 | int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode) |
| 581 | { | 581 | { |
| 582 | struct sysfs_dirent *victim_sd = NULL; | 582 | struct sysfs_dirent *sd; |
| 583 | struct dentry *victim = NULL; | ||
| 584 | struct inode * inode; | ||
| 585 | struct iattr newattrs; | 583 | struct iattr newattrs; |
| 586 | int rc; | 584 | int rc; |
| 587 | 585 | ||
| 588 | rc = -ENOENT; | 586 | mutex_lock(&sysfs_mutex); |
| 589 | victim_sd = sysfs_get_dirent(kobj->sd, attr->name); | ||
| 590 | if (!victim_sd) | ||
| 591 | goto out; | ||
| 592 | 587 | ||
| 593 | mutex_lock(&sysfs_rename_mutex); | 588 | rc = -ENOENT; |
| 594 | victim = sysfs_get_dentry(victim_sd); | 589 | sd = sysfs_find_dirent(kobj->sd, attr->name); |
| 595 | mutex_unlock(&sysfs_rename_mutex); | 590 | if (!sd) |
| 596 | if (IS_ERR(victim)) { | ||
| 597 | rc = PTR_ERR(victim); | ||
| 598 | victim = NULL; | ||
| 599 | goto out; | 591 | goto out; |
| 600 | } | ||
| 601 | |||
| 602 | inode = victim->d_inode; | ||
| 603 | |||
| 604 | mutex_lock(&inode->i_mutex); | ||
| 605 | 592 | ||
| 606 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); | 593 | newattrs.ia_mode = (mode & S_IALLUGO) | (sd->s_mode & ~S_IALLUGO); |
| 607 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 594 | newattrs.ia_valid = ATTR_MODE; |
| 608 | newattrs.ia_ctime = current_fs_time(inode->i_sb); | 595 | rc = sysfs_sd_setattr(sd, &newattrs); |
| 609 | rc = sysfs_setattr(victim, &newattrs); | ||
| 610 | 596 | ||
| 611 | if (rc == 0) { | ||
| 612 | fsnotify_change(victim, newattrs.ia_valid); | ||
| 613 | mutex_lock(&sysfs_mutex); | ||
| 614 | victim_sd->s_mode = newattrs.ia_mode; | ||
| 615 | mutex_unlock(&sysfs_mutex); | ||
| 616 | } | ||
| 617 | |||
| 618 | mutex_unlock(&inode->i_mutex); | ||
| 619 | out: | 597 | out: |
| 620 | dput(victim); | 598 | mutex_unlock(&sysfs_mutex); |
| 621 | sysfs_put(victim_sd); | ||
| 622 | return rc; | 599 | return rc; |
| 623 | } | 600 | } |
| 624 | EXPORT_SYMBOL_GPL(sysfs_chmod_file); | 601 | EXPORT_SYMBOL_GPL(sysfs_chmod_file); |
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index e28cecf179f5..220b758523ae 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c | |||
| @@ -37,7 +37,9 @@ static struct backing_dev_info sysfs_backing_dev_info = { | |||
| 37 | }; | 37 | }; |
| 38 | 38 | ||
| 39 | static const struct inode_operations sysfs_inode_operations ={ | 39 | static const struct inode_operations sysfs_inode_operations ={ |
| 40 | .permission = sysfs_permission, | ||
| 40 | .setattr = sysfs_setattr, | 41 | .setattr = sysfs_setattr, |
| 42 | .getattr = sysfs_getattr, | ||
| 41 | .setxattr = sysfs_setxattr, | 43 | .setxattr = sysfs_setxattr, |
| 42 | }; | 44 | }; |
| 43 | 45 | ||
| @@ -46,7 +48,7 @@ int __init sysfs_inode_init(void) | |||
| 46 | return bdi_init(&sysfs_backing_dev_info); | 48 | return bdi_init(&sysfs_backing_dev_info); |
| 47 | } | 49 | } |
| 48 | 50 | ||
| 49 | struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) | 51 | static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) |
| 50 | { | 52 | { |
| 51 | struct sysfs_inode_attrs *attrs; | 53 | struct sysfs_inode_attrs *attrs; |
| 52 | struct iattr *iattrs; | 54 | struct iattr *iattrs; |
| @@ -64,30 +66,15 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) | |||
| 64 | 66 | ||
| 65 | return attrs; | 67 | return attrs; |
| 66 | } | 68 | } |
| 67 | int sysfs_setattr(struct dentry * dentry, struct iattr * iattr) | 69 | |
| 70 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr * iattr) | ||
| 68 | { | 71 | { |
| 69 | struct inode * inode = dentry->d_inode; | ||
| 70 | struct sysfs_dirent * sd = dentry->d_fsdata; | ||
| 71 | struct sysfs_inode_attrs *sd_attrs; | 72 | struct sysfs_inode_attrs *sd_attrs; |
| 72 | struct iattr *iattrs; | 73 | struct iattr *iattrs; |
| 73 | unsigned int ia_valid = iattr->ia_valid; | 74 | unsigned int ia_valid = iattr->ia_valid; |
| 74 | int error; | ||
| 75 | |||
| 76 | if (!sd) | ||
| 77 | return -EINVAL; | ||
| 78 | 75 | ||
| 79 | sd_attrs = sd->s_iattr; | 76 | sd_attrs = sd->s_iattr; |
| 80 | 77 | ||
| 81 | error = inode_change_ok(inode, iattr); | ||
| 82 | if (error) | ||
| 83 | return error; | ||
| 84 | |||
| 85 | iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ | ||
| 86 | |||
| 87 | error = inode_setattr(inode, iattr); | ||
| 88 | if (error) | ||
| 89 | return error; | ||
| 90 | |||
| 91 | if (!sd_attrs) { | 78 | if (!sd_attrs) { |
| 92 | /* setting attributes for the first time, allocate now */ | 79 | /* setting attributes for the first time, allocate now */ |
| 93 | sd_attrs = sysfs_init_inode_attrs(sd); | 80 | sd_attrs = sysfs_init_inode_attrs(sd); |
| @@ -103,42 +90,78 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr) | |||
| 103 | if (ia_valid & ATTR_GID) | 90 | if (ia_valid & ATTR_GID) |
| 104 | iattrs->ia_gid = iattr->ia_gid; | 91 | iattrs->ia_gid = iattr->ia_gid; |
| 105 | if (ia_valid & ATTR_ATIME) | 92 | if (ia_valid & ATTR_ATIME) |
| 106 | iattrs->ia_atime = timespec_trunc(iattr->ia_atime, | 93 | iattrs->ia_atime = iattr->ia_atime; |
| 107 | inode->i_sb->s_time_gran); | ||
| 108 | if (ia_valid & ATTR_MTIME) | 94 | if (ia_valid & ATTR_MTIME) |
| 109 | iattrs->ia_mtime = timespec_trunc(iattr->ia_mtime, | 95 | iattrs->ia_mtime = iattr->ia_mtime; |
| 110 | inode->i_sb->s_time_gran); | ||
| 111 | if (ia_valid & ATTR_CTIME) | 96 | if (ia_valid & ATTR_CTIME) |
| 112 | iattrs->ia_ctime = timespec_trunc(iattr->ia_ctime, | 97 | iattrs->ia_ctime = iattr->ia_ctime; |
| 113 | inode->i_sb->s_time_gran); | ||
| 114 | if (ia_valid & ATTR_MODE) { | 98 | if (ia_valid & ATTR_MODE) { |
| 115 | umode_t mode = iattr->ia_mode; | 99 | umode_t mode = iattr->ia_mode; |
| 116 | |||
| 117 | if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID)) | ||
| 118 | mode &= ~S_ISGID; | ||
| 119 | iattrs->ia_mode = sd->s_mode = mode; | 100 | iattrs->ia_mode = sd->s_mode = mode; |
| 120 | } | 101 | } |
| 121 | } | 102 | } |
| 103 | return 0; | ||
| 104 | } | ||
| 105 | |||
| 106 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr) | ||
| 107 | { | ||
| 108 | struct inode *inode = dentry->d_inode; | ||
| 109 | struct sysfs_dirent *sd = dentry->d_fsdata; | ||
| 110 | int error; | ||
| 111 | |||
| 112 | if (!sd) | ||
| 113 | return -EINVAL; | ||
| 114 | |||
| 115 | error = inode_change_ok(inode, iattr); | ||
| 116 | if (error) | ||
| 117 | return error; | ||
| 118 | |||
| 119 | iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ | ||
| 120 | |||
| 121 | error = inode_setattr(inode, iattr); | ||
| 122 | if (error) | ||
| 123 | return error; | ||
| 124 | |||
| 125 | mutex_lock(&sysfs_mutex); | ||
| 126 | error = sysfs_sd_setattr(sd, iattr); | ||
| 127 | mutex_unlock(&sysfs_mutex); | ||
| 128 | |||
| 122 | return error; | 129 | return error; |
| 123 | } | 130 | } |
| 124 | 131 | ||
| 132 | static int sysfs_sd_setsecdata(struct sysfs_dirent *sd, void **secdata, u32 *secdata_len) | ||
| 133 | { | ||
| 134 | struct sysfs_inode_attrs *iattrs; | ||
| 135 | void *old_secdata; | ||
| 136 | size_t old_secdata_len; | ||
| 137 | |||
| 138 | iattrs = sd->s_iattr; | ||
| 139 | if (!iattrs) | ||
| 140 | iattrs = sysfs_init_inode_attrs(sd); | ||
| 141 | if (!iattrs) | ||
| 142 | return -ENOMEM; | ||
| 143 | |||
| 144 | old_secdata = iattrs->ia_secdata; | ||
| 145 | old_secdata_len = iattrs->ia_secdata_len; | ||
| 146 | |||
| 147 | iattrs->ia_secdata = *secdata; | ||
| 148 | iattrs->ia_secdata_len = *secdata_len; | ||
| 149 | |||
| 150 | *secdata = old_secdata; | ||
| 151 | *secdata_len = old_secdata_len; | ||
| 152 | return 0; | ||
| 153 | } | ||
| 154 | |||
| 125 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, | 155 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, |
| 126 | size_t size, int flags) | 156 | size_t size, int flags) |
| 127 | { | 157 | { |
| 128 | struct sysfs_dirent *sd = dentry->d_fsdata; | 158 | struct sysfs_dirent *sd = dentry->d_fsdata; |
| 129 | struct sysfs_inode_attrs *iattrs; | ||
| 130 | void *secdata; | 159 | void *secdata; |
| 131 | int error; | 160 | int error; |
| 132 | u32 secdata_len = 0; | 161 | u32 secdata_len = 0; |
| 133 | 162 | ||
| 134 | if (!sd) | 163 | if (!sd) |
| 135 | return -EINVAL; | 164 | return -EINVAL; |
| 136 | if (!sd->s_iattr) | ||
| 137 | sd->s_iattr = sysfs_init_inode_attrs(sd); | ||
| 138 | if (!sd->s_iattr) | ||
| 139 | return -ENOMEM; | ||
| 140 | |||
| 141 | iattrs = sd->s_iattr; | ||
| 142 | 165 | ||
| 143 | if (!strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN)) { | 166 | if (!strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN)) { |
| 144 | const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; | 167 | const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; |
| @@ -150,12 +173,13 @@ int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, | |||
| 150 | &secdata, &secdata_len); | 173 | &secdata, &secdata_len); |
| 151 | if (error) | 174 | if (error) |
| 152 | goto out; | 175 | goto out; |
| 153 | if (iattrs->ia_secdata) | ||
| 154 | security_release_secctx(iattrs->ia_secdata, | ||
| 155 | iattrs->ia_secdata_len); | ||
| 156 | iattrs->ia_secdata = secdata; | ||
| 157 | iattrs->ia_secdata_len = secdata_len; | ||
| 158 | 176 | ||
| 177 | mutex_lock(&sysfs_mutex); | ||
| 178 | error = sysfs_sd_setsecdata(sd, &secdata, &secdata_len); | ||
| 179 | mutex_unlock(&sysfs_mutex); | ||
| 180 | |||
| 181 | if (secdata) | ||
| 182 | security_release_secctx(secdata, secdata_len); | ||
| 159 | } else | 183 | } else |
| 160 | return -EINVAL; | 184 | return -EINVAL; |
| 161 | out: | 185 | out: |
| @@ -170,7 +194,6 @@ static inline void set_default_inode_attr(struct inode * inode, mode_t mode) | |||
| 170 | 194 | ||
| 171 | static inline void set_inode_attr(struct inode * inode, struct iattr * iattr) | 195 | static inline void set_inode_attr(struct inode * inode, struct iattr * iattr) |
| 172 | { | 196 | { |
| 173 | inode->i_mode = iattr->ia_mode; | ||
| 174 | inode->i_uid = iattr->ia_uid; | 197 | inode->i_uid = iattr->ia_uid; |
| 175 | inode->i_gid = iattr->ia_gid; | 198 | inode->i_gid = iattr->ia_gid; |
| 176 | inode->i_atime = iattr->ia_atime; | 199 | inode->i_atime = iattr->ia_atime; |
| @@ -178,17 +201,6 @@ static inline void set_inode_attr(struct inode * inode, struct iattr * iattr) | |||
| 178 | inode->i_ctime = iattr->ia_ctime; | 201 | inode->i_ctime = iattr->ia_ctime; |
| 179 | } | 202 | } |
| 180 | 203 | ||
| 181 | |||
| 182 | /* | ||
| 183 | * sysfs has a different i_mutex lock order behavior for i_mutex than other | ||
| 184 | * filesystems; sysfs i_mutex is called in many places with subsystem locks | ||
| 185 | * held. At the same time, many of the VFS locking rules do not apply to | ||
| 186 | * sysfs at all (cross directory rename for example). To untangle this mess | ||
| 187 | * (which gives false positives in lockdep), we're giving sysfs inodes their | ||
| 188 | * own class for i_mutex. | ||
| 189 | */ | ||
| 190 | static struct lock_class_key sysfs_inode_imutex_key; | ||
| 191 | |||
| 192 | static int sysfs_count_nlink(struct sysfs_dirent *sd) | 204 | static int sysfs_count_nlink(struct sysfs_dirent *sd) |
| 193 | { | 205 | { |
| 194 | struct sysfs_dirent *child; | 206 | struct sysfs_dirent *child; |
| @@ -201,38 +213,55 @@ static int sysfs_count_nlink(struct sysfs_dirent *sd) | |||
| 201 | return nr + 2; | 213 | return nr + 2; |
| 202 | } | 214 | } |
| 203 | 215 | ||
| 216 | static void sysfs_refresh_inode(struct sysfs_dirent *sd, struct inode *inode) | ||
| 217 | { | ||
| 218 | struct sysfs_inode_attrs *iattrs = sd->s_iattr; | ||
| 219 | |||
| 220 | inode->i_mode = sd->s_mode; | ||
| 221 | if (iattrs) { | ||
| 222 | /* sysfs_dirent has non-default attributes | ||
| 223 | * get them from persistent copy in sysfs_dirent | ||
| 224 | */ | ||
| 225 | set_inode_attr(inode, &iattrs->ia_iattr); | ||
| 226 | security_inode_notifysecctx(inode, | ||
| 227 | iattrs->ia_secdata, | ||
| 228 | iattrs->ia_secdata_len); | ||
| 229 | } | ||
| 230 | |||
| 231 | if (sysfs_type(sd) == SYSFS_DIR) | ||
| 232 | inode->i_nlink = sysfs_count_nlink(sd); | ||
| 233 | } | ||
| 234 | |||
| 235 | int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) | ||
| 236 | { | ||
| 237 | struct sysfs_dirent *sd = dentry->d_fsdata; | ||
| 238 | struct inode *inode = dentry->d_inode; | ||
| 239 | |||
| 240 | mutex_lock(&sysfs_mutex); | ||
| 241 | sysfs_refresh_inode(sd, inode); | ||
| 242 | mutex_unlock(&sysfs_mutex); | ||
| 243 | |||
| 244 | generic_fillattr(inode, stat); | ||
| 245 | return 0; | ||
| 246 | } | ||
| 247 | |||
| 204 | static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode) | 248 | static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode) |
| 205 | { | 249 | { |
| 206 | struct bin_attribute *bin_attr; | 250 | struct bin_attribute *bin_attr; |
| 207 | struct sysfs_inode_attrs *iattrs; | ||
| 208 | 251 | ||
| 209 | inode->i_private = sysfs_get(sd); | 252 | inode->i_private = sysfs_get(sd); |
| 210 | inode->i_mapping->a_ops = &sysfs_aops; | 253 | inode->i_mapping->a_ops = &sysfs_aops; |
| 211 | inode->i_mapping->backing_dev_info = &sysfs_backing_dev_info; | 254 | inode->i_mapping->backing_dev_info = &sysfs_backing_dev_info; |
| 212 | inode->i_op = &sysfs_inode_operations; | 255 | inode->i_op = &sysfs_inode_operations; |
| 213 | inode->i_ino = sd->s_ino; | ||
| 214 | lockdep_set_class(&inode->i_mutex, &sysfs_inode_imutex_key); | ||
| 215 | 256 | ||
| 216 | iattrs = sd->s_iattr; | 257 | set_default_inode_attr(inode, sd->s_mode); |
| 217 | if (iattrs) { | 258 | sysfs_refresh_inode(sd, inode); |
| 218 | /* sysfs_dirent has non-default attributes | ||
| 219 | * get them for the new inode from persistent copy | ||
| 220 | * in sysfs_dirent | ||
| 221 | */ | ||
| 222 | set_inode_attr(inode, &iattrs->ia_iattr); | ||
| 223 | if (iattrs->ia_secdata) | ||
| 224 | security_inode_notifysecctx(inode, | ||
| 225 | iattrs->ia_secdata, | ||
| 226 | iattrs->ia_secdata_len); | ||
| 227 | } else | ||
| 228 | set_default_inode_attr(inode, sd->s_mode); | ||
| 229 | 259 | ||
| 230 | /* initialize inode according to type */ | 260 | /* initialize inode according to type */ |
| 231 | switch (sysfs_type(sd)) { | 261 | switch (sysfs_type(sd)) { |
| 232 | case SYSFS_DIR: | 262 | case SYSFS_DIR: |
| 233 | inode->i_op = &sysfs_dir_inode_operations; | 263 | inode->i_op = &sysfs_dir_inode_operations; |
| 234 | inode->i_fop = &sysfs_dir_operations; | 264 | inode->i_fop = &sysfs_dir_operations; |
| 235 | inode->i_nlink = sysfs_count_nlink(sd); | ||
| 236 | break; | 265 | break; |
| 237 | case SYSFS_KOBJ_ATTR: | 266 | case SYSFS_KOBJ_ATTR: |
| 238 | inode->i_size = PAGE_SIZE; | 267 | inode->i_size = PAGE_SIZE; |
| @@ -315,3 +344,14 @@ int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name) | |||
| 315 | else | 344 | else |
| 316 | return -ENOENT; | 345 | return -ENOENT; |
| 317 | } | 346 | } |
| 347 | |||
| 348 | int sysfs_permission(struct inode *inode, int mask) | ||
| 349 | { | ||
| 350 | struct sysfs_dirent *sd = inode->i_private; | ||
| 351 | |||
| 352 | mutex_lock(&sysfs_mutex); | ||
| 353 | sysfs_refresh_inode(sd, inode); | ||
| 354 | mutex_unlock(&sysfs_mutex); | ||
| 355 | |||
| 356 | return generic_permission(inode, mask, NULL); | ||
| 357 | } | ||
diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index c5081ad77026..c5eff49fa41b 100644 --- a/fs/sysfs/symlink.c +++ b/fs/sysfs/symlink.c | |||
| @@ -210,10 +210,13 @@ static void sysfs_put_link(struct dentry *dentry, struct nameidata *nd, void *co | |||
| 210 | } | 210 | } |
| 211 | 211 | ||
| 212 | const struct inode_operations sysfs_symlink_inode_operations = { | 212 | const struct inode_operations sysfs_symlink_inode_operations = { |
| 213 | .setxattr = sysfs_setxattr, | 213 | .setxattr = sysfs_setxattr, |
| 214 | .readlink = generic_readlink, | 214 | .readlink = generic_readlink, |
| 215 | .follow_link = sysfs_follow_link, | 215 | .follow_link = sysfs_follow_link, |
| 216 | .put_link = sysfs_put_link, | 216 | .put_link = sysfs_put_link, |
| 217 | .setattr = sysfs_setattr, | ||
| 218 | .getattr = sysfs_getattr, | ||
| 219 | .permission = sysfs_permission, | ||
| 217 | }; | 220 | }; |
| 218 | 221 | ||
| 219 | 222 | ||
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index af4c4e7482ac..ca52e7b9d8f8 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
| @@ -89,9 +89,7 @@ static inline unsigned int sysfs_type(struct sysfs_dirent *sd) | |||
| 89 | */ | 89 | */ |
| 90 | struct sysfs_addrm_cxt { | 90 | struct sysfs_addrm_cxt { |
| 91 | struct sysfs_dirent *parent_sd; | 91 | struct sysfs_dirent *parent_sd; |
| 92 | struct inode *parent_inode; | ||
| 93 | struct sysfs_dirent *removed; | 92 | struct sysfs_dirent *removed; |
| 94 | int cnt; | ||
| 95 | }; | 93 | }; |
| 96 | 94 | ||
| 97 | /* | 95 | /* |
| @@ -105,7 +103,6 @@ extern struct kmem_cache *sysfs_dir_cachep; | |||
| 105 | * dir.c | 103 | * dir.c |
| 106 | */ | 104 | */ |
| 107 | extern struct mutex sysfs_mutex; | 105 | extern struct mutex sysfs_mutex; |
| 108 | extern struct mutex sysfs_rename_mutex; | ||
| 109 | extern spinlock_t sysfs_assoc_lock; | 106 | extern spinlock_t sysfs_assoc_lock; |
| 110 | 107 | ||
| 111 | extern const struct file_operations sysfs_dir_operations; | 108 | extern const struct file_operations sysfs_dir_operations; |
| @@ -133,6 +130,9 @@ int sysfs_create_subdir(struct kobject *kobj, const char *name, | |||
| 133 | struct sysfs_dirent **p_sd); | 130 | struct sysfs_dirent **p_sd); |
| 134 | void sysfs_remove_subdir(struct sysfs_dirent *sd); | 131 | void sysfs_remove_subdir(struct sysfs_dirent *sd); |
| 135 | 132 | ||
| 133 | int sysfs_rename(struct sysfs_dirent *sd, | ||
| 134 | struct sysfs_dirent *new_parent_sd, const char *new_name); | ||
| 135 | |||
| 136 | static inline struct sysfs_dirent *__sysfs_get(struct sysfs_dirent *sd) | 136 | static inline struct sysfs_dirent *__sysfs_get(struct sysfs_dirent *sd) |
| 137 | { | 137 | { |
| 138 | if (sd) { | 138 | if (sd) { |
| @@ -155,7 +155,10 @@ static inline void __sysfs_put(struct sysfs_dirent *sd) | |||
| 155 | */ | 155 | */ |
| 156 | struct inode *sysfs_get_inode(struct sysfs_dirent *sd); | 156 | struct inode *sysfs_get_inode(struct sysfs_dirent *sd); |
| 157 | void sysfs_delete_inode(struct inode *inode); | 157 | void sysfs_delete_inode(struct inode *inode); |
| 158 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr); | ||
| 159 | int sysfs_permission(struct inode *inode, int mask); | ||
| 158 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); | 160 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); |
| 161 | int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat); | ||
| 159 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, | 162 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, |
| 160 | size_t size, int flags); | 163 | size_t size, int flags); |
| 161 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name); | 164 | int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const char *name); |
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index dbc093afd946..90492327b383 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c | |||
| @@ -350,13 +350,8 @@ void dbg_dump_node(const struct ubifs_info *c, const void *node) | |||
| 350 | le32_to_cpu(sup->fmt_version)); | 350 | le32_to_cpu(sup->fmt_version)); |
| 351 | printk(KERN_DEBUG "\ttime_gran %u\n", | 351 | printk(KERN_DEBUG "\ttime_gran %u\n", |
| 352 | le32_to_cpu(sup->time_gran)); | 352 | le32_to_cpu(sup->time_gran)); |
| 353 | printk(KERN_DEBUG "\tUUID %02X%02X%02X%02X-%02X%02X" | 353 | printk(KERN_DEBUG "\tUUID %pUB\n", |
| 354 | "-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X\n", | 354 | sup->uuid); |
| 355 | sup->uuid[0], sup->uuid[1], sup->uuid[2], sup->uuid[3], | ||
| 356 | sup->uuid[4], sup->uuid[5], sup->uuid[6], sup->uuid[7], | ||
| 357 | sup->uuid[8], sup->uuid[9], sup->uuid[10], sup->uuid[11], | ||
| 358 | sup->uuid[12], sup->uuid[13], sup->uuid[14], | ||
| 359 | sup->uuid[15]); | ||
| 360 | break; | 355 | break; |
| 361 | } | 356 | } |
| 362 | case UBIFS_MST_NODE: | 357 | case UBIFS_MST_NODE: |
| @@ -2014,7 +2009,7 @@ static int check_leaf(struct ubifs_info *c, struct ubifs_zbranch *zbr, | |||
| 2014 | inum = key_inum_flash(c, &dent->key); | 2009 | inum = key_inum_flash(c, &dent->key); |
| 2015 | fscki1 = read_add_inode(c, priv, inum); | 2010 | fscki1 = read_add_inode(c, priv, inum); |
| 2016 | if (IS_ERR(fscki1)) { | 2011 | if (IS_ERR(fscki1)) { |
| 2017 | err = PTR_ERR(fscki); | 2012 | err = PTR_ERR(fscki1); |
| 2018 | ubifs_err("error %d while processing entry node and " | 2013 | ubifs_err("error %d while processing entry node and " |
| 2019 | "trying to find parent inode node %lu", | 2014 | "trying to find parent inode node %lu", |
| 2020 | err, (unsigned long)inum); | 2015 | err, (unsigned long)inum); |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 1009adc8d602..39849f887e72 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c | |||
| @@ -1389,7 +1389,6 @@ static ssize_t ubifs_aio_write(struct kiocb *iocb, const struct iovec *iov, | |||
| 1389 | unsigned long nr_segs, loff_t pos) | 1389 | unsigned long nr_segs, loff_t pos) |
| 1390 | { | 1390 | { |
| 1391 | int err; | 1391 | int err; |
| 1392 | ssize_t ret; | ||
| 1393 | struct inode *inode = iocb->ki_filp->f_mapping->host; | 1392 | struct inode *inode = iocb->ki_filp->f_mapping->host; |
| 1394 | struct ubifs_info *c = inode->i_sb->s_fs_info; | 1393 | struct ubifs_info *c = inode->i_sb->s_fs_info; |
| 1395 | 1394 | ||
| @@ -1397,17 +1396,7 @@ static ssize_t ubifs_aio_write(struct kiocb *iocb, const struct iovec *iov, | |||
| 1397 | if (err) | 1396 | if (err) |
| 1398 | return err; | 1397 | return err; |
| 1399 | 1398 | ||
| 1400 | ret = generic_file_aio_write(iocb, iov, nr_segs, pos); | 1399 | return generic_file_aio_write(iocb, iov, nr_segs, pos); |
| 1401 | if (ret < 0) | ||
| 1402 | return ret; | ||
| 1403 | |||
| 1404 | if (ret > 0 && (IS_SYNC(inode) || iocb->ki_filp->f_flags & O_SYNC)) { | ||
| 1405 | err = ubifs_sync_wbufs_by_inode(c, inode); | ||
| 1406 | if (err) | ||
| 1407 | return err; | ||
| 1408 | } | ||
| 1409 | |||
| 1410 | return ret; | ||
| 1411 | } | 1400 | } |
| 1412 | 1401 | ||
| 1413 | static int ubifs_set_page_dirty(struct page *page) | 1402 | static int ubifs_set_page_dirty(struct page *page) |
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c index f94ddf7efba0..868a55ee080f 100644 --- a/fs/ubifs/recovery.c +++ b/fs/ubifs/recovery.c | |||
| @@ -23,7 +23,7 @@ | |||
| 23 | /* | 23 | /* |
| 24 | * This file implements functions needed to recover from unclean un-mounts. | 24 | * This file implements functions needed to recover from unclean un-mounts. |
| 25 | * When UBIFS is mounted, it checks a flag on the master node to determine if | 25 | * When UBIFS is mounted, it checks a flag on the master node to determine if |
| 26 | * an un-mount was completed sucessfully. If not, the process of mounting | 26 | * an un-mount was completed successfully. If not, the process of mounting |
| 27 | * incorparates additional checking and fixing of on-flash data structures. | 27 | * incorparates additional checking and fixing of on-flash data structures. |
| 28 | * UBIFS always cleans away all remnants of an unclean un-mount, so that | 28 | * UBIFS always cleans away all remnants of an unclean un-mount, so that |
| 29 | * errors do not accumulate. However UBIFS defers recovery if it is mounted | 29 | * errors do not accumulate. However UBIFS defers recovery if it is mounted |
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 333e181ee987..43f9d19a6f33 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
| @@ -1393,12 +1393,7 @@ static int mount_ubifs(struct ubifs_info *c) | |||
| 1393 | c->leb_size, c->leb_size >> 10); | 1393 | c->leb_size, c->leb_size >> 10); |
| 1394 | dbg_msg("data journal heads: %d", | 1394 | dbg_msg("data journal heads: %d", |
| 1395 | c->jhead_cnt - NONDATA_JHEADS_CNT); | 1395 | c->jhead_cnt - NONDATA_JHEADS_CNT); |
| 1396 | dbg_msg("UUID: %02X%02X%02X%02X-%02X%02X" | 1396 | dbg_msg("UUID: %pUB", c->uuid); |
| 1397 | "-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X", | ||
| 1398 | c->uuid[0], c->uuid[1], c->uuid[2], c->uuid[3], | ||
| 1399 | c->uuid[4], c->uuid[5], c->uuid[6], c->uuid[7], | ||
| 1400 | c->uuid[8], c->uuid[9], c->uuid[10], c->uuid[11], | ||
| 1401 | c->uuid[12], c->uuid[13], c->uuid[14], c->uuid[15]); | ||
| 1402 | dbg_msg("big_lpt %d", c->big_lpt); | 1397 | dbg_msg("big_lpt %d", c->big_lpt); |
| 1403 | dbg_msg("log LEBs: %d (%d - %d)", | 1398 | dbg_msg("log LEBs: %d (%d - %d)", |
| 1404 | c->log_lebs, UBIFS_LOG_LNUM, c->log_last); | 1399 | c->log_lebs, UBIFS_LOG_LNUM, c->log_last); |
| @@ -1842,22 +1837,32 @@ const struct super_operations ubifs_super_operations = { | |||
| 1842 | * @name: UBI volume name | 1837 | * @name: UBI volume name |
| 1843 | * @mode: UBI volume open mode | 1838 | * @mode: UBI volume open mode |
| 1844 | * | 1839 | * |
| 1845 | * There are several ways to specify UBI volumes when mounting UBIFS: | 1840 | * The primary method of mounting UBIFS is by specifying the UBI volume |
| 1846 | * o ubiX_Y - UBI device number X, volume Y; | 1841 | * character device node path. However, UBIFS may also be mounted withoug any |
| 1847 | * o ubiY - UBI device number 0, volume Y; | 1842 | * character device node using one of the following methods: |
| 1843 | * | ||
| 1844 | * o ubiX_Y - mount UBI device number X, volume Y; | ||
| 1845 | * o ubiY - mount UBI device number 0, volume Y; | ||
| 1848 | * o ubiX:NAME - mount UBI device X, volume with name NAME; | 1846 | * o ubiX:NAME - mount UBI device X, volume with name NAME; |
| 1849 | * o ubi:NAME - mount UBI device 0, volume with name NAME. | 1847 | * o ubi:NAME - mount UBI device 0, volume with name NAME. |
| 1850 | * | 1848 | * |
| 1851 | * Alternative '!' separator may be used instead of ':' (because some shells | 1849 | * Alternative '!' separator may be used instead of ':' (because some shells |
| 1852 | * like busybox may interpret ':' as an NFS host name separator). This function | 1850 | * like busybox may interpret ':' as an NFS host name separator). This function |
| 1853 | * returns ubi volume object in case of success and a negative error code in | 1851 | * returns UBI volume description object in case of success and a negative |
| 1854 | * case of failure. | 1852 | * error code in case of failure. |
| 1855 | */ | 1853 | */ |
| 1856 | static struct ubi_volume_desc *open_ubi(const char *name, int mode) | 1854 | static struct ubi_volume_desc *open_ubi(const char *name, int mode) |
| 1857 | { | 1855 | { |
| 1856 | struct ubi_volume_desc *ubi; | ||
| 1858 | int dev, vol; | 1857 | int dev, vol; |
| 1859 | char *endptr; | 1858 | char *endptr; |
| 1860 | 1859 | ||
| 1860 | /* First, try to open using the device node path method */ | ||
| 1861 | ubi = ubi_open_volume_path(name, mode); | ||
| 1862 | if (!IS_ERR(ubi)) | ||
| 1863 | return ubi; | ||
| 1864 | |||
| 1865 | /* Try the "nodev" method */ | ||
| 1861 | if (name[0] != 'u' || name[1] != 'b' || name[2] != 'i') | 1866 | if (name[0] != 'u' || name[1] != 'b' || name[2] != 'i') |
| 1862 | return ERR_PTR(-EINVAL); | 1867 | return ERR_PTR(-EINVAL); |
| 1863 | 1868 | ||
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index 1e068535b58b..82372e332f08 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c | |||
| @@ -440,7 +440,7 @@ static void udf_table_free_blocks(struct super_block *sb, | |||
| 440 | (bloc->logicalBlockNum + count) > | 440 | (bloc->logicalBlockNum + count) > |
| 441 | partmap->s_partition_len) { | 441 | partmap->s_partition_len) { |
| 442 | udf_debug("%d < %d || %d + %d > %d\n", | 442 | udf_debug("%d < %d || %d + %d > %d\n", |
| 443 | bloc.logicalBlockNum, 0, bloc.logicalBlockNum, count, | 443 | bloc->logicalBlockNum, 0, bloc->logicalBlockNum, count, |
| 444 | partmap->s_partition_len); | 444 | partmap->s_partition_len); |
| 445 | goto error_return; | 445 | goto error_return; |
| 446 | } | 446 | } |
diff --git a/fs/udf/file.c b/fs/udf/file.c index b80cbd78833c..f311d509b6a3 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c | |||
| @@ -196,6 +196,7 @@ static int udf_release_file(struct inode *inode, struct file *filp) | |||
| 196 | mutex_lock(&inode->i_mutex); | 196 | mutex_lock(&inode->i_mutex); |
| 197 | lock_kernel(); | 197 | lock_kernel(); |
| 198 | udf_discard_prealloc(inode); | 198 | udf_discard_prealloc(inode); |
| 199 | udf_truncate_tail_extent(inode); | ||
| 199 | unlock_kernel(); | 200 | unlock_kernel(); |
| 200 | mutex_unlock(&inode->i_mutex); | 201 | mutex_unlock(&inode->i_mutex); |
| 201 | } | 202 | } |
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 6d24c2c63f93..f90231eb2916 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
| @@ -97,15 +97,17 @@ no_delete: | |||
| 97 | */ | 97 | */ |
| 98 | void udf_clear_inode(struct inode *inode) | 98 | void udf_clear_inode(struct inode *inode) |
| 99 | { | 99 | { |
| 100 | struct udf_inode_info *iinfo; | 100 | struct udf_inode_info *iinfo = UDF_I(inode); |
| 101 | if (!(inode->i_sb->s_flags & MS_RDONLY)) { | 101 | |
| 102 | lock_kernel(); | 102 | if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB && |
| 103 | udf_truncate_tail_extent(inode); | 103 | inode->i_size != iinfo->i_lenExtents) { |
| 104 | unlock_kernel(); | 104 | printk(KERN_WARNING "UDF-fs (%s): Inode %lu (mode %o) has " |
| 105 | write_inode_now(inode, 0); | 105 | "inode size %llu different from extent lenght %llu. " |
| 106 | invalidate_inode_buffers(inode); | 106 | "Filesystem need not be standards compliant.\n", |
| 107 | inode->i_sb->s_id, inode->i_ino, inode->i_mode, | ||
| 108 | (unsigned long long)inode->i_size, | ||
| 109 | (unsigned long long)iinfo->i_lenExtents); | ||
| 107 | } | 110 | } |
| 108 | iinfo = UDF_I(inode); | ||
| 109 | kfree(iinfo->i_ext.i_data); | 111 | kfree(iinfo->i_ext.i_data); |
| 110 | iinfo->i_ext.i_data = NULL; | 112 | iinfo->i_ext.i_data = NULL; |
| 111 | } | 113 | } |
| @@ -198,7 +200,6 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block, | |||
| 198 | int newblock; | 200 | int newblock; |
| 199 | struct buffer_head *dbh = NULL; | 201 | struct buffer_head *dbh = NULL; |
| 200 | struct kernel_lb_addr eloc; | 202 | struct kernel_lb_addr eloc; |
| 201 | uint32_t elen; | ||
| 202 | uint8_t alloctype; | 203 | uint8_t alloctype; |
| 203 | struct extent_position epos; | 204 | struct extent_position epos; |
| 204 | 205 | ||
| @@ -273,12 +274,11 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block, | |||
| 273 | eloc.logicalBlockNum = *block; | 274 | eloc.logicalBlockNum = *block; |
| 274 | eloc.partitionReferenceNum = | 275 | eloc.partitionReferenceNum = |
| 275 | iinfo->i_location.partitionReferenceNum; | 276 | iinfo->i_location.partitionReferenceNum; |
| 276 | elen = inode->i_sb->s_blocksize; | 277 | iinfo->i_lenExtents = inode->i_size; |
| 277 | iinfo->i_lenExtents = elen; | ||
| 278 | epos.bh = NULL; | 278 | epos.bh = NULL; |
| 279 | epos.block = iinfo->i_location; | 279 | epos.block = iinfo->i_location; |
| 280 | epos.offset = udf_file_entry_alloc_offset(inode); | 280 | epos.offset = udf_file_entry_alloc_offset(inode); |
| 281 | udf_add_aext(inode, &epos, &eloc, elen, 0); | 281 | udf_add_aext(inode, &epos, &eloc, inode->i_size, 0); |
| 282 | /* UniqueID stuff */ | 282 | /* UniqueID stuff */ |
| 283 | 283 | ||
| 284 | brelse(epos.bh); | 284 | brelse(epos.bh); |
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 21dad8c608f9..cd2115060fdc 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c | |||
| @@ -408,15 +408,6 @@ static struct fileIdentDesc *udf_add_entry(struct inode *dir, | |||
| 408 | } | 408 | } |
| 409 | 409 | ||
| 410 | add: | 410 | add: |
| 411 | /* Is there any extent whose size we need to round up? */ | ||
| 412 | if (dinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB && elen) { | ||
| 413 | elen = (elen + sb->s_blocksize - 1) & ~(sb->s_blocksize - 1); | ||
| 414 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT) | ||
| 415 | epos.offset -= sizeof(struct short_ad); | ||
| 416 | else if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG) | ||
| 417 | epos.offset -= sizeof(struct long_ad); | ||
| 418 | udf_write_aext(dir, &epos, &eloc, elen, 1); | ||
| 419 | } | ||
| 420 | f_pos += nfidlen; | 411 | f_pos += nfidlen; |
| 421 | 412 | ||
| 422 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB && | 413 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB && |
| @@ -439,6 +430,7 @@ add: | |||
| 439 | udf_current_aext(dir, &epos, &eloc, &elen, 1); | 430 | udf_current_aext(dir, &epos, &eloc, &elen, 1); |
| 440 | } | 431 | } |
| 441 | 432 | ||
| 433 | /* Entry fits into current block? */ | ||
| 442 | if (sb->s_blocksize - fibh->eoffset >= nfidlen) { | 434 | if (sb->s_blocksize - fibh->eoffset >= nfidlen) { |
| 443 | fibh->soffset = fibh->eoffset; | 435 | fibh->soffset = fibh->eoffset; |
| 444 | fibh->eoffset += nfidlen; | 436 | fibh->eoffset += nfidlen; |
| @@ -462,6 +454,16 @@ add: | |||
| 462 | (fibh->sbh->b_data + fibh->soffset); | 454 | (fibh->sbh->b_data + fibh->soffset); |
| 463 | } | 455 | } |
| 464 | } else { | 456 | } else { |
| 457 | /* Round up last extent in the file */ | ||
| 458 | elen = (elen + sb->s_blocksize - 1) & ~(sb->s_blocksize - 1); | ||
| 459 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT) | ||
| 460 | epos.offset -= sizeof(struct short_ad); | ||
| 461 | else if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG) | ||
| 462 | epos.offset -= sizeof(struct long_ad); | ||
| 463 | udf_write_aext(dir, &epos, &eloc, elen, 1); | ||
| 464 | dinfo->i_lenExtents = (dinfo->i_lenExtents + sb->s_blocksize | ||
| 465 | - 1) & ~(sb->s_blocksize - 1); | ||
| 466 | |||
| 465 | fibh->soffset = fibh->eoffset - sb->s_blocksize; | 467 | fibh->soffset = fibh->eoffset - sb->s_blocksize; |
| 466 | fibh->eoffset += nfidlen - sb->s_blocksize; | 468 | fibh->eoffset += nfidlen - sb->s_blocksize; |
| 467 | if (fibh->sbh != fibh->ebh) { | 469 | if (fibh->sbh != fibh->ebh) { |
| @@ -508,6 +510,20 @@ add: | |||
| 508 | dir->i_size += nfidlen; | 510 | dir->i_size += nfidlen; |
| 509 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) | 511 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) |
| 510 | dinfo->i_lenAlloc += nfidlen; | 512 | dinfo->i_lenAlloc += nfidlen; |
| 513 | else { | ||
| 514 | /* Find the last extent and truncate it to proper size */ | ||
| 515 | while (udf_next_aext(dir, &epos, &eloc, &elen, 1) == | ||
| 516 | (EXT_RECORDED_ALLOCATED >> 30)) | ||
| 517 | ; | ||
| 518 | elen -= dinfo->i_lenExtents - dir->i_size; | ||
| 519 | if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT) | ||
| 520 | epos.offset -= sizeof(struct short_ad); | ||
| 521 | else if (dinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG) | ||
| 522 | epos.offset -= sizeof(struct long_ad); | ||
| 523 | udf_write_aext(dir, &epos, &eloc, elen, 1); | ||
| 524 | dinfo->i_lenExtents = dir->i_size; | ||
| 525 | } | ||
| 526 | |||
| 511 | mark_inode_dirty(dir); | 527 | mark_inode_dirty(dir); |
| 512 | goto out_ok; | 528 | goto out_ok; |
| 513 | } else { | 529 | } else { |
| @@ -922,7 +938,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
| 922 | block = udf_get_pblock(inode->i_sb, block, | 938 | block = udf_get_pblock(inode->i_sb, block, |
| 923 | iinfo->i_location.partitionReferenceNum, | 939 | iinfo->i_location.partitionReferenceNum, |
| 924 | 0); | 940 | 0); |
| 925 | epos.bh = udf_tread(inode->i_sb, block); | 941 | epos.bh = udf_tgetblk(inode->i_sb, block); |
| 926 | lock_buffer(epos.bh); | 942 | lock_buffer(epos.bh); |
| 927 | memset(epos.bh->b_data, 0x00, inode->i_sb->s_blocksize); | 943 | memset(epos.bh->b_data, 0x00, inode->i_sb->s_blocksize); |
| 928 | set_buffer_uptodate(epos.bh); | 944 | set_buffer_uptodate(epos.bh); |
| @@ -999,6 +1015,8 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
| 999 | inode->i_size = elen; | 1015 | inode->i_size = elen; |
| 1000 | if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) | 1016 | if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) |
| 1001 | iinfo->i_lenAlloc = inode->i_size; | 1017 | iinfo->i_lenAlloc = inode->i_size; |
| 1018 | else | ||
| 1019 | udf_truncate_tail_extent(inode); | ||
| 1002 | mark_inode_dirty(inode); | 1020 | mark_inode_dirty(inode); |
| 1003 | 1021 | ||
| 1004 | fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err); | 1022 | fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err); |
diff --git a/fs/udf/super.c b/fs/udf/super.c index 9d1b8c2e6c45..1e4543cbcd27 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c | |||
| @@ -1078,21 +1078,39 @@ static int udf_fill_partdesc_info(struct super_block *sb, | |||
| 1078 | return 0; | 1078 | return 0; |
| 1079 | } | 1079 | } |
| 1080 | 1080 | ||
| 1081 | static int udf_load_vat(struct super_block *sb, int p_index, int type1_index) | 1081 | static void udf_find_vat_block(struct super_block *sb, int p_index, |
| 1082 | int type1_index, sector_t start_block) | ||
| 1082 | { | 1083 | { |
| 1083 | struct udf_sb_info *sbi = UDF_SB(sb); | 1084 | struct udf_sb_info *sbi = UDF_SB(sb); |
| 1084 | struct udf_part_map *map = &sbi->s_partmaps[p_index]; | 1085 | struct udf_part_map *map = &sbi->s_partmaps[p_index]; |
| 1086 | sector_t vat_block; | ||
| 1085 | struct kernel_lb_addr ino; | 1087 | struct kernel_lb_addr ino; |
| 1088 | |||
| 1089 | /* | ||
| 1090 | * VAT file entry is in the last recorded block. Some broken disks have | ||
| 1091 | * it a few blocks before so try a bit harder... | ||
| 1092 | */ | ||
| 1093 | ino.partitionReferenceNum = type1_index; | ||
| 1094 | for (vat_block = start_block; | ||
| 1095 | vat_block >= map->s_partition_root && | ||
| 1096 | vat_block >= start_block - 3 && | ||
| 1097 | !sbi->s_vat_inode; vat_block--) { | ||
| 1098 | ino.logicalBlockNum = vat_block - map->s_partition_root; | ||
| 1099 | sbi->s_vat_inode = udf_iget(sb, &ino); | ||
| 1100 | } | ||
| 1101 | } | ||
| 1102 | |||
| 1103 | static int udf_load_vat(struct super_block *sb, int p_index, int type1_index) | ||
| 1104 | { | ||
| 1105 | struct udf_sb_info *sbi = UDF_SB(sb); | ||
| 1106 | struct udf_part_map *map = &sbi->s_partmaps[p_index]; | ||
| 1086 | struct buffer_head *bh = NULL; | 1107 | struct buffer_head *bh = NULL; |
| 1087 | struct udf_inode_info *vati; | 1108 | struct udf_inode_info *vati; |
| 1088 | uint32_t pos; | 1109 | uint32_t pos; |
| 1089 | struct virtualAllocationTable20 *vat20; | 1110 | struct virtualAllocationTable20 *vat20; |
| 1090 | sector_t blocks = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits; | 1111 | sector_t blocks = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits; |
| 1091 | 1112 | ||
| 1092 | /* VAT file entry is in the last recorded block */ | 1113 | udf_find_vat_block(sb, p_index, type1_index, sbi->s_last_block); |
| 1093 | ino.partitionReferenceNum = type1_index; | ||
| 1094 | ino.logicalBlockNum = sbi->s_last_block - map->s_partition_root; | ||
| 1095 | sbi->s_vat_inode = udf_iget(sb, &ino); | ||
| 1096 | if (!sbi->s_vat_inode && | 1114 | if (!sbi->s_vat_inode && |
| 1097 | sbi->s_last_block != blocks - 1) { | 1115 | sbi->s_last_block != blocks - 1) { |
| 1098 | printk(KERN_NOTICE "UDF-fs: Failed to read VAT inode from the" | 1116 | printk(KERN_NOTICE "UDF-fs: Failed to read VAT inode from the" |
| @@ -1100,9 +1118,7 @@ static int udf_load_vat(struct super_block *sb, int p_index, int type1_index) | |||
| 1100 | "block of the device (%lu).\n", | 1118 | "block of the device (%lu).\n", |
| 1101 | (unsigned long)sbi->s_last_block, | 1119 | (unsigned long)sbi->s_last_block, |
| 1102 | (unsigned long)blocks - 1); | 1120 | (unsigned long)blocks - 1); |
| 1103 | ino.partitionReferenceNum = type1_index; | 1121 | udf_find_vat_block(sb, p_index, type1_index, blocks - 1); |
| 1104 | ino.logicalBlockNum = blocks - 1 - map->s_partition_root; | ||
| 1105 | sbi->s_vat_inode = udf_iget(sb, &ino); | ||
| 1106 | } | 1122 | } |
| 1107 | if (!sbi->s_vat_inode) | 1123 | if (!sbi->s_vat_inode) |
| 1108 | return 1; | 1124 | return 1; |
diff --git a/fs/xattr_acl.c b/fs/xattr_acl.c index c6ad7c7e3ee9..05ac0fe9c4d3 100644 --- a/fs/xattr_acl.c +++ b/fs/xattr_acl.c | |||
| @@ -36,7 +36,7 @@ posix_acl_from_xattr(const void *value, size_t size) | |||
| 36 | if (count == 0) | 36 | if (count == 0) |
| 37 | return NULL; | 37 | return NULL; |
| 38 | 38 | ||
| 39 | acl = posix_acl_alloc(count, GFP_KERNEL); | 39 | acl = posix_acl_alloc(count, GFP_NOFS); |
| 40 | if (!acl) | 40 | if (!acl) |
| 41 | return ERR_PTR(-ENOMEM); | 41 | return ERR_PTR(-ENOMEM); |
| 42 | acl_e = acl->a_entries; | 42 | acl_e = acl->a_entries; |
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile index 7a59daed1782..56641fe52a23 100644 --- a/fs/xfs/Makefile +++ b/fs/xfs/Makefile | |||
| @@ -26,6 +26,8 @@ endif | |||
| 26 | 26 | ||
| 27 | obj-$(CONFIG_XFS_FS) += xfs.o | 27 | obj-$(CONFIG_XFS_FS) += xfs.o |
| 28 | 28 | ||
| 29 | xfs-y += linux-2.6/xfs_trace.o | ||
| 30 | |||
| 29 | xfs-$(CONFIG_XFS_QUOTA) += $(addprefix quota/, \ | 31 | xfs-$(CONFIG_XFS_QUOTA) += $(addprefix quota/, \ |
| 30 | xfs_dquot.o \ | 32 | xfs_dquot.o \ |
| 31 | xfs_dquot_item.o \ | 33 | xfs_dquot_item.o \ |
| @@ -90,8 +92,7 @@ xfs-y += xfs_alloc.o \ | |||
| 90 | xfs_rw.o \ | 92 | xfs_rw.o \ |
| 91 | xfs_dmops.o | 93 | xfs_dmops.o |
| 92 | 94 | ||
| 93 | xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o \ | 95 | xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o |
| 94 | xfs_dir2_trace.o | ||
| 95 | 96 | ||
| 96 | # Objects in linux/ | 97 | # Objects in linux/ |
| 97 | xfs-y += $(addprefix $(XFS_LINUX)/, \ | 98 | xfs-y += $(addprefix $(XFS_LINUX)/, \ |
| @@ -113,6 +114,3 @@ xfs-y += $(addprefix $(XFS_LINUX)/, \ | |||
| 113 | xfs-y += $(addprefix support/, \ | 114 | xfs-y += $(addprefix support/, \ |
| 114 | debug.o \ | 115 | debug.o \ |
| 115 | uuid.o) | 116 | uuid.o) |
| 116 | |||
| 117 | xfs-$(CONFIG_XFS_TRACE) += support/ktrace.o | ||
| 118 | |||
diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c index b23a54506446..69e598b6986f 100644 --- a/fs/xfs/linux-2.6/xfs_acl.c +++ b/fs/xfs/linux-2.6/xfs_acl.c | |||
| @@ -21,6 +21,7 @@ | |||
| 21 | #include "xfs_bmap_btree.h" | 21 | #include "xfs_bmap_btree.h" |
| 22 | #include "xfs_inode.h" | 22 | #include "xfs_inode.h" |
| 23 | #include "xfs_vnodeops.h" | 23 | #include "xfs_vnodeops.h" |
| 24 | #include "xfs_trace.h" | ||
| 24 | #include <linux/xattr.h> | 25 | #include <linux/xattr.h> |
| 25 | #include <linux/posix_acl_xattr.h> | 26 | #include <linux/posix_acl_xattr.h> |
| 26 | 27 | ||
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index c2e30eea74dc..d798c54296eb 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
| @@ -38,6 +38,7 @@ | |||
| 38 | #include "xfs_rw.h" | 38 | #include "xfs_rw.h" |
| 39 | #include "xfs_iomap.h" | 39 | #include "xfs_iomap.h" |
| 40 | #include "xfs_vnodeops.h" | 40 | #include "xfs_vnodeops.h" |
| 41 | #include "xfs_trace.h" | ||
| 41 | #include <linux/mpage.h> | 42 | #include <linux/mpage.h> |
| 42 | #include <linux/pagevec.h> | 43 | #include <linux/pagevec.h> |
| 43 | #include <linux/writeback.h> | 44 | #include <linux/writeback.h> |
| @@ -76,7 +77,7 @@ xfs_ioend_wake( | |||
| 76 | wake_up(to_ioend_wq(ip)); | 77 | wake_up(to_ioend_wq(ip)); |
| 77 | } | 78 | } |
| 78 | 79 | ||
| 79 | STATIC void | 80 | void |
| 80 | xfs_count_page_state( | 81 | xfs_count_page_state( |
| 81 | struct page *page, | 82 | struct page *page, |
| 82 | int *delalloc, | 83 | int *delalloc, |
| @@ -98,48 +99,6 @@ xfs_count_page_state( | |||
| 98 | } while ((bh = bh->b_this_page) != head); | 99 | } while ((bh = bh->b_this_page) != head); |
| 99 | } | 100 | } |
| 100 | 101 | ||
| 101 | #if defined(XFS_RW_TRACE) | ||
| 102 | void | ||
| 103 | xfs_page_trace( | ||
| 104 | int tag, | ||
| 105 | struct inode *inode, | ||
| 106 | struct page *page, | ||
| 107 | unsigned long pgoff) | ||
| 108 | { | ||
| 109 | xfs_inode_t *ip; | ||
| 110 | loff_t isize = i_size_read(inode); | ||
| 111 | loff_t offset = page_offset(page); | ||
| 112 | int delalloc = -1, unmapped = -1, unwritten = -1; | ||
| 113 | |||
| 114 | if (page_has_buffers(page)) | ||
| 115 | xfs_count_page_state(page, &delalloc, &unmapped, &unwritten); | ||
| 116 | |||
| 117 | ip = XFS_I(inode); | ||
| 118 | if (!ip->i_rwtrace) | ||
| 119 | return; | ||
| 120 | |||
| 121 | ktrace_enter(ip->i_rwtrace, | ||
| 122 | (void *)((unsigned long)tag), | ||
| 123 | (void *)ip, | ||
| 124 | (void *)inode, | ||
| 125 | (void *)page, | ||
| 126 | (void *)pgoff, | ||
| 127 | (void *)((unsigned long)((ip->i_d.di_size >> 32) & 0xffffffff)), | ||
| 128 | (void *)((unsigned long)(ip->i_d.di_size & 0xffffffff)), | ||
| 129 | (void *)((unsigned long)((isize >> 32) & 0xffffffff)), | ||
| 130 | (void *)((unsigned long)(isize & 0xffffffff)), | ||
| 131 | (void *)((unsigned long)((offset >> 32) & 0xffffffff)), | ||
| 132 | (void *)((unsigned long)(offset & 0xffffffff)), | ||
| 133 | (void *)((unsigned long)delalloc), | ||
| 134 | (void *)((unsigned long)unmapped), | ||
| 135 | (void *)((unsigned long)unwritten), | ||
| 136 | (void *)((unsigned long)current_pid()), | ||
| 137 | (void *)NULL); | ||
| 138 | } | ||
| 139 | #else | ||
| 140 | #define xfs_page_trace(tag, inode, page, pgoff) | ||
| 141 | #endif | ||
| 142 | |||
| 143 | STATIC struct block_device * | 102 | STATIC struct block_device * |
| 144 | xfs_find_bdev_for_inode( | 103 | xfs_find_bdev_for_inode( |
| 145 | struct xfs_inode *ip) | 104 | struct xfs_inode *ip) |
| @@ -235,71 +194,36 @@ xfs_setfilesize( | |||
| 235 | } | 194 | } |
| 236 | 195 | ||
| 237 | /* | 196 | /* |
| 238 | * Buffered IO write completion for delayed allocate extents. | 197 | * IO write completion. |
| 239 | */ | ||
| 240 | STATIC void | ||
| 241 | xfs_end_bio_delalloc( | ||
| 242 | struct work_struct *work) | ||
| 243 | { | ||
| 244 | xfs_ioend_t *ioend = | ||
| 245 | container_of(work, xfs_ioend_t, io_work); | ||
| 246 | |||
| 247 | xfs_setfilesize(ioend); | ||
| 248 | xfs_destroy_ioend(ioend); | ||
| 249 | } | ||
| 250 | |||
| 251 | /* | ||
| 252 | * Buffered IO write completion for regular, written extents. | ||
| 253 | */ | 198 | */ |
| 254 | STATIC void | 199 | STATIC void |
| 255 | xfs_end_bio_written( | 200 | xfs_end_io( |
| 256 | struct work_struct *work) | ||
| 257 | { | ||
| 258 | xfs_ioend_t *ioend = | ||
| 259 | container_of(work, xfs_ioend_t, io_work); | ||
| 260 | |||
| 261 | xfs_setfilesize(ioend); | ||
| 262 | xfs_destroy_ioend(ioend); | ||
| 263 | } | ||
| 264 | |||
| 265 | /* | ||
| 266 | * IO write completion for unwritten extents. | ||
| 267 | * | ||
| 268 | * Issue transactions to convert a buffer range from unwritten | ||
| 269 | * to written extents. | ||
| 270 | */ | ||
| 271 | STATIC void | ||
| 272 | xfs_end_bio_unwritten( | ||
| 273 | struct work_struct *work) | 201 | struct work_struct *work) |
| 274 | { | 202 | { |
| 275 | xfs_ioend_t *ioend = | 203 | xfs_ioend_t *ioend = |
| 276 | container_of(work, xfs_ioend_t, io_work); | 204 | container_of(work, xfs_ioend_t, io_work); |
| 277 | struct xfs_inode *ip = XFS_I(ioend->io_inode); | 205 | struct xfs_inode *ip = XFS_I(ioend->io_inode); |
| 278 | xfs_off_t offset = ioend->io_offset; | ||
| 279 | size_t size = ioend->io_size; | ||
| 280 | |||
| 281 | if (likely(!ioend->io_error)) { | ||
| 282 | if (!XFS_FORCED_SHUTDOWN(ip->i_mount)) { | ||
| 283 | int error; | ||
| 284 | error = xfs_iomap_write_unwritten(ip, offset, size); | ||
| 285 | if (error) | ||
| 286 | ioend->io_error = error; | ||
| 287 | } | ||
| 288 | xfs_setfilesize(ioend); | ||
| 289 | } | ||
| 290 | xfs_destroy_ioend(ioend); | ||
| 291 | } | ||
| 292 | 206 | ||
| 293 | /* | 207 | /* |
| 294 | * IO read completion for regular, written extents. | 208 | * For unwritten extents we need to issue transactions to convert a |
| 295 | */ | 209 | * range to normal written extens after the data I/O has finished. |
| 296 | STATIC void | 210 | */ |
| 297 | xfs_end_bio_read( | 211 | if (ioend->io_type == IOMAP_UNWRITTEN && |
| 298 | struct work_struct *work) | 212 | likely(!ioend->io_error && !XFS_FORCED_SHUTDOWN(ip->i_mount))) { |
| 299 | { | 213 | int error; |
| 300 | xfs_ioend_t *ioend = | 214 | |
| 301 | container_of(work, xfs_ioend_t, io_work); | 215 | error = xfs_iomap_write_unwritten(ip, ioend->io_offset, |
| 216 | ioend->io_size); | ||
| 217 | if (error) | ||
| 218 | ioend->io_error = error; | ||
| 219 | } | ||
| 302 | 220 | ||
| 221 | /* | ||
| 222 | * We might have to update the on-disk file size after extending | ||
| 223 | * writes. | ||
| 224 | */ | ||
| 225 | if (ioend->io_type != IOMAP_READ) | ||
| 226 | xfs_setfilesize(ioend); | ||
| 303 | xfs_destroy_ioend(ioend); | 227 | xfs_destroy_ioend(ioend); |
| 304 | } | 228 | } |
| 305 | 229 | ||
| @@ -314,10 +238,10 @@ xfs_finish_ioend( | |||
| 314 | int wait) | 238 | int wait) |
| 315 | { | 239 | { |
| 316 | if (atomic_dec_and_test(&ioend->io_remaining)) { | 240 | if (atomic_dec_and_test(&ioend->io_remaining)) { |
| 317 | struct workqueue_struct *wq = xfsdatad_workqueue; | 241 | struct workqueue_struct *wq; |
| 318 | if (ioend->io_work.func == xfs_end_bio_unwritten) | ||
| 319 | wq = xfsconvertd_workqueue; | ||
| 320 | 242 | ||
| 243 | wq = (ioend->io_type == IOMAP_UNWRITTEN) ? | ||
| 244 | xfsconvertd_workqueue : xfsdatad_workqueue; | ||
| 321 | queue_work(wq, &ioend->io_work); | 245 | queue_work(wq, &ioend->io_work); |
| 322 | if (wait) | 246 | if (wait) |
| 323 | flush_workqueue(wq); | 247 | flush_workqueue(wq); |
| @@ -355,15 +279,7 @@ xfs_alloc_ioend( | |||
| 355 | ioend->io_offset = 0; | 279 | ioend->io_offset = 0; |
| 356 | ioend->io_size = 0; | 280 | ioend->io_size = 0; |
| 357 | 281 | ||
| 358 | if (type == IOMAP_UNWRITTEN) | 282 | INIT_WORK(&ioend->io_work, xfs_end_io); |
| 359 | INIT_WORK(&ioend->io_work, xfs_end_bio_unwritten); | ||
| 360 | else if (type == IOMAP_DELAY) | ||
| 361 | INIT_WORK(&ioend->io_work, xfs_end_bio_delalloc); | ||
| 362 | else if (type == IOMAP_READ) | ||
| 363 | INIT_WORK(&ioend->io_work, xfs_end_bio_read); | ||
| 364 | else | ||
| 365 | INIT_WORK(&ioend->io_work, xfs_end_bio_written); | ||
| 366 | |||
| 367 | return ioend; | 283 | return ioend; |
| 368 | } | 284 | } |
| 369 | 285 | ||
| @@ -380,7 +296,7 @@ xfs_map_blocks( | |||
| 380 | return -xfs_iomap(XFS_I(inode), offset, count, flags, mapp, &nmaps); | 296 | return -xfs_iomap(XFS_I(inode), offset, count, flags, mapp, &nmaps); |
| 381 | } | 297 | } |
| 382 | 298 | ||
| 383 | STATIC_INLINE int | 299 | STATIC int |
| 384 | xfs_iomap_valid( | 300 | xfs_iomap_valid( |
| 385 | xfs_iomap_t *iomapp, | 301 | xfs_iomap_t *iomapp, |
| 386 | loff_t offset) | 302 | loff_t offset) |
| @@ -412,8 +328,9 @@ xfs_end_bio( | |||
| 412 | 328 | ||
| 413 | STATIC void | 329 | STATIC void |
| 414 | xfs_submit_ioend_bio( | 330 | xfs_submit_ioend_bio( |
| 415 | xfs_ioend_t *ioend, | 331 | struct writeback_control *wbc, |
| 416 | struct bio *bio) | 332 | xfs_ioend_t *ioend, |
| 333 | struct bio *bio) | ||
| 417 | { | 334 | { |
| 418 | atomic_inc(&ioend->io_remaining); | 335 | atomic_inc(&ioend->io_remaining); |
| 419 | bio->bi_private = ioend; | 336 | bio->bi_private = ioend; |
| @@ -426,7 +343,8 @@ xfs_submit_ioend_bio( | |||
| 426 | if (xfs_ioend_new_eof(ioend)) | 343 | if (xfs_ioend_new_eof(ioend)) |
| 427 | xfs_mark_inode_dirty_sync(XFS_I(ioend->io_inode)); | 344 | xfs_mark_inode_dirty_sync(XFS_I(ioend->io_inode)); |
| 428 | 345 | ||
| 429 | submit_bio(WRITE, bio); | 346 | submit_bio(wbc->sync_mode == WB_SYNC_ALL ? |
| 347 | WRITE_SYNC_PLUG : WRITE, bio); | ||
| 430 | ASSERT(!bio_flagged(bio, BIO_EOPNOTSUPP)); | 348 | ASSERT(!bio_flagged(bio, BIO_EOPNOTSUPP)); |
| 431 | bio_put(bio); | 349 | bio_put(bio); |
| 432 | } | 350 | } |
| @@ -505,6 +423,7 @@ static inline int bio_add_buffer(struct bio *bio, struct buffer_head *bh) | |||
| 505 | */ | 423 | */ |
| 506 | STATIC void | 424 | STATIC void |
| 507 | xfs_submit_ioend( | 425 | xfs_submit_ioend( |
| 426 | struct writeback_control *wbc, | ||
| 508 | xfs_ioend_t *ioend) | 427 | xfs_ioend_t *ioend) |
| 509 | { | 428 | { |
| 510 | xfs_ioend_t *head = ioend; | 429 | xfs_ioend_t *head = ioend; |
| @@ -533,19 +452,19 @@ xfs_submit_ioend( | |||
| 533 | retry: | 452 | retry: |
| 534 | bio = xfs_alloc_ioend_bio(bh); | 453 | bio = xfs_alloc_ioend_bio(bh); |
| 535 | } else if (bh->b_blocknr != lastblock + 1) { | 454 | } else if (bh->b_blocknr != lastblock + 1) { |
| 536 | xfs_submit_ioend_bio(ioend, bio); | 455 | xfs_submit_ioend_bio(wbc, ioend, bio); |
| 537 | goto retry; | 456 | goto retry; |
| 538 | } | 457 | } |
| 539 | 458 | ||
| 540 | if (bio_add_buffer(bio, bh) != bh->b_size) { | 459 | if (bio_add_buffer(bio, bh) != bh->b_size) { |
| 541 | xfs_submit_ioend_bio(ioend, bio); | 460 | xfs_submit_ioend_bio(wbc, ioend, bio); |
| 542 | goto retry; | 461 | goto retry; |
| 543 | } | 462 | } |
| 544 | 463 | ||
| 545 | lastblock = bh->b_blocknr; | 464 | lastblock = bh->b_blocknr; |
| 546 | } | 465 | } |
| 547 | if (bio) | 466 | if (bio) |
| 548 | xfs_submit_ioend_bio(ioend, bio); | 467 | xfs_submit_ioend_bio(wbc, ioend, bio); |
| 549 | xfs_finish_ioend(ioend, 0); | 468 | xfs_finish_ioend(ioend, 0); |
| 550 | } while ((ioend = next) != NULL); | 469 | } while ((ioend = next) != NULL); |
| 551 | } | 470 | } |
| @@ -904,16 +823,9 @@ xfs_convert_page( | |||
| 904 | 823 | ||
| 905 | if (startio) { | 824 | if (startio) { |
| 906 | if (count) { | 825 | if (count) { |
| 907 | struct backing_dev_info *bdi; | ||
| 908 | |||
| 909 | bdi = inode->i_mapping->backing_dev_info; | ||
| 910 | wbc->nr_to_write--; | 826 | wbc->nr_to_write--; |
| 911 | if (bdi_write_congested(bdi)) { | 827 | if (wbc->nr_to_write <= 0) |
| 912 | wbc->encountered_congestion = 1; | ||
| 913 | done = 1; | ||
| 914 | } else if (wbc->nr_to_write <= 0) { | ||
| 915 | done = 1; | 828 | done = 1; |
| 916 | } | ||
| 917 | } | 829 | } |
| 918 | xfs_start_page_writeback(page, !page_dirty, count); | 830 | xfs_start_page_writeback(page, !page_dirty, count); |
| 919 | } | 831 | } |
| @@ -1198,7 +1110,7 @@ xfs_page_state_convert( | |||
| 1198 | } | 1110 | } |
| 1199 | 1111 | ||
| 1200 | if (iohead) | 1112 | if (iohead) |
| 1201 | xfs_submit_ioend(iohead); | 1113 | xfs_submit_ioend(wbc, iohead); |
| 1202 | 1114 | ||
| 1203 | return page_dirty; | 1115 | return page_dirty; |
| 1204 | 1116 | ||
| @@ -1249,7 +1161,7 @@ xfs_vm_writepage( | |||
| 1249 | int delalloc, unmapped, unwritten; | 1161 | int delalloc, unmapped, unwritten; |
| 1250 | struct inode *inode = page->mapping->host; | 1162 | struct inode *inode = page->mapping->host; |
| 1251 | 1163 | ||
| 1252 | xfs_page_trace(XFS_WRITEPAGE_ENTER, inode, page, 0); | 1164 | trace_xfs_writepage(inode, page, 0); |
| 1253 | 1165 | ||
| 1254 | /* | 1166 | /* |
| 1255 | * We need a transaction if: | 1167 | * We need a transaction if: |
| @@ -1354,7 +1266,7 @@ xfs_vm_releasepage( | |||
| 1354 | .nr_to_write = 1, | 1266 | .nr_to_write = 1, |
| 1355 | }; | 1267 | }; |
| 1356 | 1268 | ||
| 1357 | xfs_page_trace(XFS_RELEASEPAGE_ENTER, inode, page, 0); | 1269 | trace_xfs_releasepage(inode, page, 0); |
| 1358 | 1270 | ||
| 1359 | if (!page_has_buffers(page)) | 1271 | if (!page_has_buffers(page)) |
| 1360 | return 0; | 1272 | return 0; |
| @@ -1535,7 +1447,7 @@ xfs_end_io_direct( | |||
| 1535 | * didn't map an unwritten extent so switch it's completion | 1447 | * didn't map an unwritten extent so switch it's completion |
| 1536 | * handler. | 1448 | * handler. |
| 1537 | */ | 1449 | */ |
| 1538 | INIT_WORK(&ioend->io_work, xfs_end_bio_written); | 1450 | ioend->io_type = IOMAP_NEW; |
| 1539 | xfs_finish_ioend(ioend, 0); | 1451 | xfs_finish_ioend(ioend, 0); |
| 1540 | } | 1452 | } |
| 1541 | 1453 | ||
| @@ -1634,8 +1546,7 @@ xfs_vm_invalidatepage( | |||
| 1634 | struct page *page, | 1546 | struct page *page, |
| 1635 | unsigned long offset) | 1547 | unsigned long offset) |
| 1636 | { | 1548 | { |
| 1637 | xfs_page_trace(XFS_INVALIDPAGE_ENTER, | 1549 | trace_xfs_invalidatepage(page->mapping->host, page, offset); |
| 1638 | page->mapping->host, page, offset); | ||
| 1639 | block_invalidatepage(page, offset); | 1550 | block_invalidatepage(page, offset); |
| 1640 | } | 1551 | } |
| 1641 | 1552 | ||
diff --git a/fs/xfs/linux-2.6/xfs_aops.h b/fs/xfs/linux-2.6/xfs_aops.h index 221b3e66ceef..4cfc6ea87df8 100644 --- a/fs/xfs/linux-2.6/xfs_aops.h +++ b/fs/xfs/linux-2.6/xfs_aops.h | |||
| @@ -45,4 +45,6 @@ extern int xfs_get_blocks(struct inode *, sector_t, struct buffer_head *, int); | |||
| 45 | extern void xfs_ioend_init(void); | 45 | extern void xfs_ioend_init(void); |
| 46 | extern void xfs_ioend_wait(struct xfs_inode *); | 46 | extern void xfs_ioend_wait(struct xfs_inode *); |
| 47 | 47 | ||
| 48 | extern void xfs_count_page_state(struct page *, int *, int *, int *); | ||
| 49 | |||
| 48 | #endif /* __XFS_AOPS_H__ */ | 50 | #endif /* __XFS_AOPS_H__ */ |
diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index 965df1227d64..b4c7d4248aac 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c | |||
| @@ -39,6 +39,7 @@ | |||
| 39 | #include "xfs_ag.h" | 39 | #include "xfs_ag.h" |
| 40 | #include "xfs_dmapi.h" | 40 | #include "xfs_dmapi.h" |
| 41 | #include "xfs_mount.h" | 41 | #include "xfs_mount.h" |
| 42 | #include "xfs_trace.h" | ||
| 42 | 43 | ||
| 43 | static kmem_zone_t *xfs_buf_zone; | 44 | static kmem_zone_t *xfs_buf_zone; |
| 44 | STATIC int xfsbufd(void *); | 45 | STATIC int xfsbufd(void *); |
| @@ -53,34 +54,6 @@ static struct workqueue_struct *xfslogd_workqueue; | |||
| 53 | struct workqueue_struct *xfsdatad_workqueue; | 54 | struct workqueue_struct *xfsdatad_workqueue; |
| 54 | struct workqueue_struct *xfsconvertd_workqueue; | 55 | struct workqueue_struct *xfsconvertd_workqueue; |
| 55 | 56 | ||
| 56 | #ifdef XFS_BUF_TRACE | ||
| 57 | void | ||
| 58 | xfs_buf_trace( | ||
| 59 | xfs_buf_t *bp, | ||
| 60 | char *id, | ||
| 61 | void *data, | ||
| 62 | void *ra) | ||
| 63 | { | ||
| 64 | ktrace_enter(xfs_buf_trace_buf, | ||
| 65 | bp, id, | ||
| 66 | (void *)(unsigned long)bp->b_flags, | ||
| 67 | (void *)(unsigned long)bp->b_hold.counter, | ||
| 68 | (void *)(unsigned long)bp->b_sema.count, | ||
| 69 | (void *)current, | ||
| 70 | data, ra, | ||
| 71 | (void *)(unsigned long)((bp->b_file_offset>>32) & 0xffffffff), | ||
| 72 | (void *)(unsigned long)(bp->b_file_offset & 0xffffffff), | ||
| 73 | (void *)(unsigned long)bp->b_buffer_length, | ||
| 74 | NULL, NULL, NULL, NULL, NULL); | ||
| 75 | } | ||
| 76 | ktrace_t *xfs_buf_trace_buf; | ||
| 77 | #define XFS_BUF_TRACE_SIZE 4096 | ||
| 78 | #define XB_TRACE(bp, id, data) \ | ||
| 79 | xfs_buf_trace(bp, id, (void *)data, (void *)__builtin_return_address(0)) | ||
| 80 | #else | ||
| 81 | #define XB_TRACE(bp, id, data) do { } while (0) | ||
| 82 | #endif | ||
| 83 | |||
| 84 | #ifdef XFS_BUF_LOCK_TRACKING | 57 | #ifdef XFS_BUF_LOCK_TRACKING |
| 85 | # define XB_SET_OWNER(bp) ((bp)->b_last_holder = current->pid) | 58 | # define XB_SET_OWNER(bp) ((bp)->b_last_holder = current->pid) |
| 86 | # define XB_CLEAR_OWNER(bp) ((bp)->b_last_holder = -1) | 59 | # define XB_CLEAR_OWNER(bp) ((bp)->b_last_holder = -1) |
| @@ -149,7 +122,7 @@ page_region_mask( | |||
| 149 | return mask; | 122 | return mask; |
| 150 | } | 123 | } |
| 151 | 124 | ||
| 152 | STATIC_INLINE void | 125 | STATIC void |
| 153 | set_page_region( | 126 | set_page_region( |
| 154 | struct page *page, | 127 | struct page *page, |
| 155 | size_t offset, | 128 | size_t offset, |
| @@ -161,7 +134,7 @@ set_page_region( | |||
| 161 | SetPageUptodate(page); | 134 | SetPageUptodate(page); |
| 162 | } | 135 | } |
| 163 | 136 | ||
| 164 | STATIC_INLINE int | 137 | STATIC int |
| 165 | test_page_region( | 138 | test_page_region( |
| 166 | struct page *page, | 139 | struct page *page, |
| 167 | size_t offset, | 140 | size_t offset, |
| @@ -279,7 +252,8 @@ _xfs_buf_initialize( | |||
| 279 | init_waitqueue_head(&bp->b_waiters); | 252 | init_waitqueue_head(&bp->b_waiters); |
| 280 | 253 | ||
| 281 | XFS_STATS_INC(xb_create); | 254 | XFS_STATS_INC(xb_create); |
| 282 | XB_TRACE(bp, "initialize", target); | 255 | |
| 256 | trace_xfs_buf_init(bp, _RET_IP_); | ||
| 283 | } | 257 | } |
| 284 | 258 | ||
| 285 | /* | 259 | /* |
| @@ -332,7 +306,7 @@ void | |||
| 332 | xfs_buf_free( | 306 | xfs_buf_free( |
| 333 | xfs_buf_t *bp) | 307 | xfs_buf_t *bp) |
| 334 | { | 308 | { |
| 335 | XB_TRACE(bp, "free", 0); | 309 | trace_xfs_buf_free(bp, _RET_IP_); |
| 336 | 310 | ||
| 337 | ASSERT(list_empty(&bp->b_hash_list)); | 311 | ASSERT(list_empty(&bp->b_hash_list)); |
| 338 | 312 | ||
| @@ -445,7 +419,6 @@ _xfs_buf_lookup_pages( | |||
| 445 | if (page_count == bp->b_page_count) | 419 | if (page_count == bp->b_page_count) |
| 446 | bp->b_flags |= XBF_DONE; | 420 | bp->b_flags |= XBF_DONE; |
| 447 | 421 | ||
| 448 | XB_TRACE(bp, "lookup_pages", (long)page_count); | ||
| 449 | return error; | 422 | return error; |
| 450 | } | 423 | } |
| 451 | 424 | ||
| @@ -548,7 +521,6 @@ found: | |||
| 548 | if (down_trylock(&bp->b_sema)) { | 521 | if (down_trylock(&bp->b_sema)) { |
| 549 | if (!(flags & XBF_TRYLOCK)) { | 522 | if (!(flags & XBF_TRYLOCK)) { |
| 550 | /* wait for buffer ownership */ | 523 | /* wait for buffer ownership */ |
| 551 | XB_TRACE(bp, "get_lock", 0); | ||
| 552 | xfs_buf_lock(bp); | 524 | xfs_buf_lock(bp); |
| 553 | XFS_STATS_INC(xb_get_locked_waited); | 525 | XFS_STATS_INC(xb_get_locked_waited); |
| 554 | } else { | 526 | } else { |
| @@ -571,7 +543,8 @@ found: | |||
| 571 | ASSERT((bp->b_flags & _XBF_DELWRI_Q) == 0); | 543 | ASSERT((bp->b_flags & _XBF_DELWRI_Q) == 0); |
| 572 | bp->b_flags &= XBF_MAPPED; | 544 | bp->b_flags &= XBF_MAPPED; |
| 573 | } | 545 | } |
| 574 | XB_TRACE(bp, "got_lock", 0); | 546 | |
| 547 | trace_xfs_buf_find(bp, flags, _RET_IP_); | ||
| 575 | XFS_STATS_INC(xb_get_locked); | 548 | XFS_STATS_INC(xb_get_locked); |
| 576 | return bp; | 549 | return bp; |
| 577 | } | 550 | } |
| @@ -582,7 +555,7 @@ found: | |||
| 582 | * although backing storage may not be. | 555 | * although backing storage may not be. |
| 583 | */ | 556 | */ |
| 584 | xfs_buf_t * | 557 | xfs_buf_t * |
| 585 | xfs_buf_get_flags( | 558 | xfs_buf_get( |
| 586 | xfs_buftarg_t *target,/* target for buffer */ | 559 | xfs_buftarg_t *target,/* target for buffer */ |
| 587 | xfs_off_t ioff, /* starting offset of range */ | 560 | xfs_off_t ioff, /* starting offset of range */ |
| 588 | size_t isize, /* length of range */ | 561 | size_t isize, /* length of range */ |
| @@ -627,7 +600,7 @@ xfs_buf_get_flags( | |||
| 627 | bp->b_bn = ioff; | 600 | bp->b_bn = ioff; |
| 628 | bp->b_count_desired = bp->b_buffer_length; | 601 | bp->b_count_desired = bp->b_buffer_length; |
| 629 | 602 | ||
| 630 | XB_TRACE(bp, "get", (unsigned long)flags); | 603 | trace_xfs_buf_get(bp, flags, _RET_IP_); |
| 631 | return bp; | 604 | return bp; |
| 632 | 605 | ||
| 633 | no_buffer: | 606 | no_buffer: |
| @@ -644,8 +617,6 @@ _xfs_buf_read( | |||
| 644 | { | 617 | { |
| 645 | int status; | 618 | int status; |
| 646 | 619 | ||
| 647 | XB_TRACE(bp, "_xfs_buf_read", (unsigned long)flags); | ||
| 648 | |||
| 649 | ASSERT(!(flags & (XBF_DELWRI|XBF_WRITE))); | 620 | ASSERT(!(flags & (XBF_DELWRI|XBF_WRITE))); |
| 650 | ASSERT(bp->b_bn != XFS_BUF_DADDR_NULL); | 621 | ASSERT(bp->b_bn != XFS_BUF_DADDR_NULL); |
| 651 | 622 | ||
| @@ -661,7 +632,7 @@ _xfs_buf_read( | |||
| 661 | } | 632 | } |
| 662 | 633 | ||
| 663 | xfs_buf_t * | 634 | xfs_buf_t * |
| 664 | xfs_buf_read_flags( | 635 | xfs_buf_read( |
| 665 | xfs_buftarg_t *target, | 636 | xfs_buftarg_t *target, |
| 666 | xfs_off_t ioff, | 637 | xfs_off_t ioff, |
| 667 | size_t isize, | 638 | size_t isize, |
| @@ -671,21 +642,20 @@ xfs_buf_read_flags( | |||
| 671 | 642 | ||
| 672 | flags |= XBF_READ; | 643 | flags |= XBF_READ; |
| 673 | 644 | ||
| 674 | bp = xfs_buf_get_flags(target, ioff, isize, flags); | 645 | bp = xfs_buf_get(target, ioff, isize, flags); |
| 675 | if (bp) { | 646 | if (bp) { |
| 647 | trace_xfs_buf_read(bp, flags, _RET_IP_); | ||
| 648 | |||
| 676 | if (!XFS_BUF_ISDONE(bp)) { | 649 | if (!XFS_BUF_ISDONE(bp)) { |
| 677 | XB_TRACE(bp, "read", (unsigned long)flags); | ||
| 678 | XFS_STATS_INC(xb_get_read); | 650 | XFS_STATS_INC(xb_get_read); |
| 679 | _xfs_buf_read(bp, flags); | 651 | _xfs_buf_read(bp, flags); |
| 680 | } else if (flags & XBF_ASYNC) { | 652 | } else if (flags & XBF_ASYNC) { |
| 681 | XB_TRACE(bp, "read_async", (unsigned long)flags); | ||
| 682 | /* | 653 | /* |
| 683 | * Read ahead call which is already satisfied, | 654 | * Read ahead call which is already satisfied, |
| 684 | * drop the buffer | 655 | * drop the buffer |
| 685 | */ | 656 | */ |
| 686 | goto no_buffer; | 657 | goto no_buffer; |
| 687 | } else { | 658 | } else { |
| 688 | XB_TRACE(bp, "read_done", (unsigned long)flags); | ||
| 689 | /* We do not want read in the flags */ | 659 | /* We do not want read in the flags */ |
| 690 | bp->b_flags &= ~XBF_READ; | 660 | bp->b_flags &= ~XBF_READ; |
| 691 | } | 661 | } |
| @@ -718,7 +688,7 @@ xfs_buf_readahead( | |||
| 718 | return; | 688 | return; |
| 719 | 689 | ||
| 720 | flags |= (XBF_TRYLOCK|XBF_ASYNC|XBF_READ_AHEAD); | 690 | flags |= (XBF_TRYLOCK|XBF_ASYNC|XBF_READ_AHEAD); |
| 721 | xfs_buf_read_flags(target, ioff, isize, flags); | 691 | xfs_buf_read(target, ioff, isize, flags); |
| 722 | } | 692 | } |
| 723 | 693 | ||
| 724 | xfs_buf_t * | 694 | xfs_buf_t * |
| @@ -823,7 +793,7 @@ xfs_buf_get_noaddr( | |||
| 823 | 793 | ||
| 824 | xfs_buf_unlock(bp); | 794 | xfs_buf_unlock(bp); |
| 825 | 795 | ||
| 826 | XB_TRACE(bp, "no_daddr", len); | 796 | trace_xfs_buf_get_noaddr(bp, _RET_IP_); |
| 827 | return bp; | 797 | return bp; |
| 828 | 798 | ||
| 829 | fail_free_mem: | 799 | fail_free_mem: |
| @@ -845,8 +815,8 @@ void | |||
| 845 | xfs_buf_hold( | 815 | xfs_buf_hold( |
| 846 | xfs_buf_t *bp) | 816 | xfs_buf_t *bp) |
| 847 | { | 817 | { |
| 818 | trace_xfs_buf_hold(bp, _RET_IP_); | ||
| 848 | atomic_inc(&bp->b_hold); | 819 | atomic_inc(&bp->b_hold); |
| 849 | XB_TRACE(bp, "hold", 0); | ||
| 850 | } | 820 | } |
| 851 | 821 | ||
| 852 | /* | 822 | /* |
| @@ -859,7 +829,7 @@ xfs_buf_rele( | |||
| 859 | { | 829 | { |
| 860 | xfs_bufhash_t *hash = bp->b_hash; | 830 | xfs_bufhash_t *hash = bp->b_hash; |
| 861 | 831 | ||
| 862 | XB_TRACE(bp, "rele", bp->b_relse); | 832 | trace_xfs_buf_rele(bp, _RET_IP_); |
| 863 | 833 | ||
| 864 | if (unlikely(!hash)) { | 834 | if (unlikely(!hash)) { |
| 865 | ASSERT(!bp->b_relse); | 835 | ASSERT(!bp->b_relse); |
| @@ -909,21 +879,19 @@ xfs_buf_cond_lock( | |||
| 909 | int locked; | 879 | int locked; |
| 910 | 880 | ||
| 911 | locked = down_trylock(&bp->b_sema) == 0; | 881 | locked = down_trylock(&bp->b_sema) == 0; |
| 912 | if (locked) { | 882 | if (locked) |
| 913 | XB_SET_OWNER(bp); | 883 | XB_SET_OWNER(bp); |
| 914 | } | 884 | |
| 915 | XB_TRACE(bp, "cond_lock", (long)locked); | 885 | trace_xfs_buf_cond_lock(bp, _RET_IP_); |
| 916 | return locked ? 0 : -EBUSY; | 886 | return locked ? 0 : -EBUSY; |
| 917 | } | 887 | } |
| 918 | 888 | ||
| 919 | #if defined(DEBUG) || defined(XFS_BLI_TRACE) | ||
| 920 | int | 889 | int |
| 921 | xfs_buf_lock_value( | 890 | xfs_buf_lock_value( |
| 922 | xfs_buf_t *bp) | 891 | xfs_buf_t *bp) |
| 923 | { | 892 | { |
| 924 | return bp->b_sema.count; | 893 | return bp->b_sema.count; |
| 925 | } | 894 | } |
| 926 | #endif | ||
| 927 | 895 | ||
| 928 | /* | 896 | /* |
| 929 | * Locks a buffer object. | 897 | * Locks a buffer object. |
| @@ -935,12 +903,14 @@ void | |||
| 935 | xfs_buf_lock( | 903 | xfs_buf_lock( |
| 936 | xfs_buf_t *bp) | 904 | xfs_buf_t *bp) |
| 937 | { | 905 | { |
| 938 | XB_TRACE(bp, "lock", 0); | 906 | trace_xfs_buf_lock(bp, _RET_IP_); |
| 907 | |||
| 939 | if (atomic_read(&bp->b_io_remaining)) | 908 | if (atomic_read(&bp->b_io_remaining)) |
| 940 | blk_run_address_space(bp->b_target->bt_mapping); | 909 | blk_run_address_space(bp->b_target->bt_mapping); |
| 941 | down(&bp->b_sema); | 910 | down(&bp->b_sema); |
| 942 | XB_SET_OWNER(bp); | 911 | XB_SET_OWNER(bp); |
| 943 | XB_TRACE(bp, "locked", 0); | 912 | |
| 913 | trace_xfs_buf_lock_done(bp, _RET_IP_); | ||
| 944 | } | 914 | } |
| 945 | 915 | ||
| 946 | /* | 916 | /* |
| @@ -962,7 +932,8 @@ xfs_buf_unlock( | |||
| 962 | 932 | ||
| 963 | XB_CLEAR_OWNER(bp); | 933 | XB_CLEAR_OWNER(bp); |
| 964 | up(&bp->b_sema); | 934 | up(&bp->b_sema); |
| 965 | XB_TRACE(bp, "unlock", 0); | 935 | |
| 936 | trace_xfs_buf_unlock(bp, _RET_IP_); | ||
| 966 | } | 937 | } |
| 967 | 938 | ||
| 968 | 939 | ||
| @@ -974,17 +945,18 @@ void | |||
| 974 | xfs_buf_pin( | 945 | xfs_buf_pin( |
| 975 | xfs_buf_t *bp) | 946 | xfs_buf_t *bp) |
| 976 | { | 947 | { |
| 948 | trace_xfs_buf_pin(bp, _RET_IP_); | ||
| 977 | atomic_inc(&bp->b_pin_count); | 949 | atomic_inc(&bp->b_pin_count); |
| 978 | XB_TRACE(bp, "pin", (long)bp->b_pin_count.counter); | ||
| 979 | } | 950 | } |
| 980 | 951 | ||
| 981 | void | 952 | void |
| 982 | xfs_buf_unpin( | 953 | xfs_buf_unpin( |
| 983 | xfs_buf_t *bp) | 954 | xfs_buf_t *bp) |
| 984 | { | 955 | { |
| 956 | trace_xfs_buf_unpin(bp, _RET_IP_); | ||
| 957 | |||
| 985 | if (atomic_dec_and_test(&bp->b_pin_count)) | 958 | if (atomic_dec_and_test(&bp->b_pin_count)) |
| 986 | wake_up_all(&bp->b_waiters); | 959 | wake_up_all(&bp->b_waiters); |
| 987 | XB_TRACE(bp, "unpin", (long)bp->b_pin_count.counter); | ||
| 988 | } | 960 | } |
| 989 | 961 | ||
| 990 | int | 962 | int |
| @@ -1035,7 +1007,7 @@ xfs_buf_iodone_work( | |||
| 1035 | */ | 1007 | */ |
| 1036 | if ((bp->b_error == EOPNOTSUPP) && | 1008 | if ((bp->b_error == EOPNOTSUPP) && |
| 1037 | (bp->b_flags & (XBF_ORDERED|XBF_ASYNC)) == (XBF_ORDERED|XBF_ASYNC)) { | 1009 | (bp->b_flags & (XBF_ORDERED|XBF_ASYNC)) == (XBF_ORDERED|XBF_ASYNC)) { |
| 1038 | XB_TRACE(bp, "ordered_retry", bp->b_iodone); | 1010 | trace_xfs_buf_ordered_retry(bp, _RET_IP_); |
| 1039 | bp->b_flags &= ~XBF_ORDERED; | 1011 | bp->b_flags &= ~XBF_ORDERED; |
| 1040 | bp->b_flags |= _XFS_BARRIER_FAILED; | 1012 | bp->b_flags |= _XFS_BARRIER_FAILED; |
| 1041 | xfs_buf_iorequest(bp); | 1013 | xfs_buf_iorequest(bp); |
| @@ -1050,12 +1022,12 @@ xfs_buf_ioend( | |||
| 1050 | xfs_buf_t *bp, | 1022 | xfs_buf_t *bp, |
| 1051 | int schedule) | 1023 | int schedule) |
| 1052 | { | 1024 | { |
| 1025 | trace_xfs_buf_iodone(bp, _RET_IP_); | ||
| 1026 | |||
| 1053 | bp->b_flags &= ~(XBF_READ | XBF_WRITE | XBF_READ_AHEAD); | 1027 | bp->b_flags &= ~(XBF_READ | XBF_WRITE | XBF_READ_AHEAD); |
| 1054 | if (bp->b_error == 0) | 1028 | if (bp->b_error == 0) |
| 1055 | bp->b_flags |= XBF_DONE; | 1029 | bp->b_flags |= XBF_DONE; |
| 1056 | 1030 | ||
| 1057 | XB_TRACE(bp, "iodone", bp->b_iodone); | ||
| 1058 | |||
| 1059 | if ((bp->b_iodone) || (bp->b_flags & XBF_ASYNC)) { | 1031 | if ((bp->b_iodone) || (bp->b_flags & XBF_ASYNC)) { |
| 1060 | if (schedule) { | 1032 | if (schedule) { |
| 1061 | INIT_WORK(&bp->b_iodone_work, xfs_buf_iodone_work); | 1033 | INIT_WORK(&bp->b_iodone_work, xfs_buf_iodone_work); |
| @@ -1075,7 +1047,7 @@ xfs_buf_ioerror( | |||
| 1075 | { | 1047 | { |
| 1076 | ASSERT(error >= 0 && error <= 0xffff); | 1048 | ASSERT(error >= 0 && error <= 0xffff); |
| 1077 | bp->b_error = (unsigned short)error; | 1049 | bp->b_error = (unsigned short)error; |
| 1078 | XB_TRACE(bp, "ioerror", (unsigned long)error); | 1050 | trace_xfs_buf_ioerror(bp, error, _RET_IP_); |
| 1079 | } | 1051 | } |
| 1080 | 1052 | ||
| 1081 | int | 1053 | int |
| @@ -1083,7 +1055,7 @@ xfs_bawrite( | |||
| 1083 | void *mp, | 1055 | void *mp, |
| 1084 | struct xfs_buf *bp) | 1056 | struct xfs_buf *bp) |
| 1085 | { | 1057 | { |
| 1086 | XB_TRACE(bp, "bawrite", 0); | 1058 | trace_xfs_buf_bawrite(bp, _RET_IP_); |
| 1087 | 1059 | ||
| 1088 | ASSERT(bp->b_bn != XFS_BUF_DADDR_NULL); | 1060 | ASSERT(bp->b_bn != XFS_BUF_DADDR_NULL); |
| 1089 | 1061 | ||
| @@ -1102,7 +1074,7 @@ xfs_bdwrite( | |||
| 1102 | void *mp, | 1074 | void *mp, |
| 1103 | struct xfs_buf *bp) | 1075 | struct xfs_buf *bp) |
| 1104 | { | 1076 | { |
| 1105 | XB_TRACE(bp, "bdwrite", 0); | 1077 | trace_xfs_buf_bdwrite(bp, _RET_IP_); |
| 1106 | 1078 | ||
| 1107 | bp->b_strat = xfs_bdstrat_cb; | 1079 | bp->b_strat = xfs_bdstrat_cb; |
| 1108 | bp->b_mount = mp; | 1080 | bp->b_mount = mp; |
| @@ -1113,7 +1085,7 @@ xfs_bdwrite( | |||
| 1113 | xfs_buf_delwri_queue(bp, 1); | 1085 | xfs_buf_delwri_queue(bp, 1); |
| 1114 | } | 1086 | } |
| 1115 | 1087 | ||
| 1116 | STATIC_INLINE void | 1088 | STATIC void |
| 1117 | _xfs_buf_ioend( | 1089 | _xfs_buf_ioend( |
| 1118 | xfs_buf_t *bp, | 1090 | xfs_buf_t *bp, |
| 1119 | int schedule) | 1091 | int schedule) |
| @@ -1253,7 +1225,7 @@ int | |||
| 1253 | xfs_buf_iorequest( | 1225 | xfs_buf_iorequest( |
| 1254 | xfs_buf_t *bp) | 1226 | xfs_buf_t *bp) |
| 1255 | { | 1227 | { |
| 1256 | XB_TRACE(bp, "iorequest", 0); | 1228 | trace_xfs_buf_iorequest(bp, _RET_IP_); |
| 1257 | 1229 | ||
| 1258 | if (bp->b_flags & XBF_DELWRI) { | 1230 | if (bp->b_flags & XBF_DELWRI) { |
| 1259 | xfs_buf_delwri_queue(bp, 1); | 1231 | xfs_buf_delwri_queue(bp, 1); |
| @@ -1287,11 +1259,13 @@ int | |||
| 1287 | xfs_buf_iowait( | 1259 | xfs_buf_iowait( |
| 1288 | xfs_buf_t *bp) | 1260 | xfs_buf_t *bp) |
| 1289 | { | 1261 | { |
| 1290 | XB_TRACE(bp, "iowait", 0); | 1262 | trace_xfs_buf_iowait(bp, _RET_IP_); |
| 1263 | |||
| 1291 | if (atomic_read(&bp->b_io_remaining)) | 1264 | if (atomic_read(&bp->b_io_remaining)) |
| 1292 | blk_run_address_space(bp->b_target->bt_mapping); | 1265 | blk_run_address_space(bp->b_target->bt_mapping); |
| 1293 | wait_for_completion(&bp->b_iowait); | 1266 | wait_for_completion(&bp->b_iowait); |
| 1294 | XB_TRACE(bp, "iowaited", (long)bp->b_error); | 1267 | |
| 1268 | trace_xfs_buf_iowait_done(bp, _RET_IP_); | ||
| 1295 | return bp->b_error; | 1269 | return bp->b_error; |
| 1296 | } | 1270 | } |
| 1297 | 1271 | ||
| @@ -1604,7 +1578,8 @@ xfs_buf_delwri_queue( | |||
| 1604 | struct list_head *dwq = &bp->b_target->bt_delwrite_queue; | 1578 | struct list_head *dwq = &bp->b_target->bt_delwrite_queue; |
| 1605 | spinlock_t *dwlk = &bp->b_target->bt_delwrite_lock; | 1579 | spinlock_t *dwlk = &bp->b_target->bt_delwrite_lock; |
| 1606 | 1580 | ||
| 1607 | XB_TRACE(bp, "delwri_q", (long)unlock); | 1581 | trace_xfs_buf_delwri_queue(bp, _RET_IP_); |
| 1582 | |||
| 1608 | ASSERT((bp->b_flags&(XBF_DELWRI|XBF_ASYNC)) == (XBF_DELWRI|XBF_ASYNC)); | 1583 | ASSERT((bp->b_flags&(XBF_DELWRI|XBF_ASYNC)) == (XBF_DELWRI|XBF_ASYNC)); |
| 1609 | 1584 | ||
| 1610 | spin_lock(dwlk); | 1585 | spin_lock(dwlk); |
| @@ -1644,7 +1619,7 @@ xfs_buf_delwri_dequeue( | |||
| 1644 | if (dequeued) | 1619 | if (dequeued) |
| 1645 | xfs_buf_rele(bp); | 1620 | xfs_buf_rele(bp); |
| 1646 | 1621 | ||
| 1647 | XB_TRACE(bp, "delwri_dq", (long)dequeued); | 1622 | trace_xfs_buf_delwri_dequeue(bp, _RET_IP_); |
| 1648 | } | 1623 | } |
| 1649 | 1624 | ||
| 1650 | STATIC void | 1625 | STATIC void |
| @@ -1692,7 +1667,7 @@ xfs_buf_delwri_split( | |||
| 1692 | INIT_LIST_HEAD(list); | 1667 | INIT_LIST_HEAD(list); |
| 1693 | spin_lock(dwlk); | 1668 | spin_lock(dwlk); |
| 1694 | list_for_each_entry_safe(bp, n, dwq, b_list) { | 1669 | list_for_each_entry_safe(bp, n, dwq, b_list) { |
| 1695 | XB_TRACE(bp, "walkq1", (long)xfs_buf_ispin(bp)); | 1670 | trace_xfs_buf_delwri_split(bp, _RET_IP_); |
| 1696 | ASSERT(bp->b_flags & XBF_DELWRI); | 1671 | ASSERT(bp->b_flags & XBF_DELWRI); |
| 1697 | 1672 | ||
| 1698 | if (!xfs_buf_ispin(bp) && !xfs_buf_cond_lock(bp)) { | 1673 | if (!xfs_buf_ispin(bp) && !xfs_buf_cond_lock(bp)) { |
| @@ -1816,14 +1791,10 @@ xfs_flush_buftarg( | |||
| 1816 | int __init | 1791 | int __init |
| 1817 | xfs_buf_init(void) | 1792 | xfs_buf_init(void) |
| 1818 | { | 1793 | { |
| 1819 | #ifdef XFS_BUF_TRACE | ||
| 1820 | xfs_buf_trace_buf = ktrace_alloc(XFS_BUF_TRACE_SIZE, KM_NOFS); | ||
| 1821 | #endif | ||
| 1822 | |||
| 1823 | xfs_buf_zone = kmem_zone_init_flags(sizeof(xfs_buf_t), "xfs_buf", | 1794 | xfs_buf_zone = kmem_zone_init_flags(sizeof(xfs_buf_t), "xfs_buf", |
| 1824 | KM_ZONE_HWALIGN, NULL); | 1795 | KM_ZONE_HWALIGN, NULL); |
| 1825 | if (!xfs_buf_zone) | 1796 | if (!xfs_buf_zone) |
| 1826 | goto out_free_trace_buf; | 1797 | goto out; |
| 1827 | 1798 | ||
| 1828 | xfslogd_workqueue = create_workqueue("xfslogd"); | 1799 | xfslogd_workqueue = create_workqueue("xfslogd"); |
| 1829 | if (!xfslogd_workqueue) | 1800 | if (!xfslogd_workqueue) |
| @@ -1846,10 +1817,7 @@ xfs_buf_init(void) | |||
| 1846 | destroy_workqueue(xfslogd_workqueue); | 1817 | destroy_workqueue(xfslogd_workqueue); |
| 1847 | out_free_buf_zone: | 1818 | out_free_buf_zone: |
| 1848 | kmem_zone_destroy(xfs_buf_zone); | 1819 | kmem_zone_destroy(xfs_buf_zone); |
| 1849 | out_free_trace_buf: | 1820 | out: |
| 1850 | #ifdef XFS_BUF_TRACE | ||
| 1851 | ktrace_free(xfs_buf_trace_buf); | ||
| 1852 | #endif | ||
| 1853 | return -ENOMEM; | 1821 | return -ENOMEM; |
| 1854 | } | 1822 | } |
| 1855 | 1823 | ||
| @@ -1861,9 +1829,6 @@ xfs_buf_terminate(void) | |||
| 1861 | destroy_workqueue(xfsdatad_workqueue); | 1829 | destroy_workqueue(xfsdatad_workqueue); |
| 1862 | destroy_workqueue(xfslogd_workqueue); | 1830 | destroy_workqueue(xfslogd_workqueue); |
| 1863 | kmem_zone_destroy(xfs_buf_zone); | 1831 | kmem_zone_destroy(xfs_buf_zone); |
| 1864 | #ifdef XFS_BUF_TRACE | ||
| 1865 | ktrace_free(xfs_buf_trace_buf); | ||
| 1866 | #endif | ||
| 1867 | } | 1832 | } |
| 1868 | 1833 | ||
| 1869 | #ifdef CONFIG_KDB_MODULES | 1834 | #ifdef CONFIG_KDB_MODULES |
diff --git a/fs/xfs/linux-2.6/xfs_buf.h b/fs/xfs/linux-2.6/xfs_buf.h index 9b4d666ad31f..a509f4addc2a 100644 --- a/fs/xfs/linux-2.6/xfs_buf.h +++ b/fs/xfs/linux-2.6/xfs_buf.h | |||
| @@ -95,6 +95,28 @@ typedef enum { | |||
| 95 | _XFS_BARRIER_FAILED = (1 << 23), | 95 | _XFS_BARRIER_FAILED = (1 << 23), |
| 96 | } xfs_buf_flags_t; | 96 | } xfs_buf_flags_t; |
| 97 | 97 | ||
| 98 | #define XFS_BUF_FLAGS \ | ||
| 99 | { XBF_READ, "READ" }, \ | ||
| 100 | { XBF_WRITE, "WRITE" }, \ | ||
| 101 | { XBF_MAPPED, "MAPPED" }, \ | ||
| 102 | { XBF_ASYNC, "ASYNC" }, \ | ||
| 103 | { XBF_DONE, "DONE" }, \ | ||
| 104 | { XBF_DELWRI, "DELWRI" }, \ | ||
| 105 | { XBF_STALE, "STALE" }, \ | ||
| 106 | { XBF_FS_MANAGED, "FS_MANAGED" }, \ | ||
| 107 | { XBF_ORDERED, "ORDERED" }, \ | ||
| 108 | { XBF_READ_AHEAD, "READ_AHEAD" }, \ | ||
| 109 | { XBF_LOCK, "LOCK" }, /* should never be set */\ | ||
| 110 | { XBF_TRYLOCK, "TRYLOCK" }, /* ditto */\ | ||
| 111 | { XBF_DONT_BLOCK, "DONT_BLOCK" }, /* ditto */\ | ||
| 112 | { _XBF_PAGE_CACHE, "PAGE_CACHE" }, \ | ||
| 113 | { _XBF_PAGES, "PAGES" }, \ | ||
| 114 | { _XBF_RUN_QUEUES, "RUN_QUEUES" }, \ | ||
| 115 | { _XBF_DELWRI_Q, "DELWRI_Q" }, \ | ||
| 116 | { _XBF_PAGE_LOCKED, "PAGE_LOCKED" }, \ | ||
| 117 | { _XFS_BARRIER_FAILED, "BARRIER_FAILED" } | ||
| 118 | |||
| 119 | |||
| 98 | typedef enum { | 120 | typedef enum { |
| 99 | XBT_FORCE_SLEEP = 0, | 121 | XBT_FORCE_SLEEP = 0, |
| 100 | XBT_FORCE_FLUSH = 1, | 122 | XBT_FORCE_FLUSH = 1, |
| @@ -186,15 +208,10 @@ extern xfs_buf_t *_xfs_buf_find(xfs_buftarg_t *, xfs_off_t, size_t, | |||
| 186 | #define xfs_incore(buftarg,blkno,len,lockit) \ | 208 | #define xfs_incore(buftarg,blkno,len,lockit) \ |
| 187 | _xfs_buf_find(buftarg, blkno ,len, lockit, NULL) | 209 | _xfs_buf_find(buftarg, blkno ,len, lockit, NULL) |
| 188 | 210 | ||
| 189 | extern xfs_buf_t *xfs_buf_get_flags(xfs_buftarg_t *, xfs_off_t, size_t, | 211 | extern xfs_buf_t *xfs_buf_get(xfs_buftarg_t *, xfs_off_t, size_t, |
| 190 | xfs_buf_flags_t); | 212 | xfs_buf_flags_t); |
| 191 | #define xfs_buf_get(target, blkno, len, flags) \ | 213 | extern xfs_buf_t *xfs_buf_read(xfs_buftarg_t *, xfs_off_t, size_t, |
| 192 | xfs_buf_get_flags((target), (blkno), (len), XBF_LOCK | XBF_MAPPED) | ||
| 193 | |||
| 194 | extern xfs_buf_t *xfs_buf_read_flags(xfs_buftarg_t *, xfs_off_t, size_t, | ||
| 195 | xfs_buf_flags_t); | 214 | xfs_buf_flags_t); |
| 196 | #define xfs_buf_read(target, blkno, len, flags) \ | ||
| 197 | xfs_buf_read_flags((target), (blkno), (len), XBF_LOCK | XBF_MAPPED) | ||
| 198 | 215 | ||
| 199 | extern xfs_buf_t *xfs_buf_get_empty(size_t, xfs_buftarg_t *); | 216 | extern xfs_buf_t *xfs_buf_get_empty(size_t, xfs_buftarg_t *); |
| 200 | extern xfs_buf_t *xfs_buf_get_noaddr(size_t, xfs_buftarg_t *); | 217 | extern xfs_buf_t *xfs_buf_get_noaddr(size_t, xfs_buftarg_t *); |
| @@ -248,13 +265,6 @@ extern void xfs_buf_delwri_dequeue(xfs_buf_t *); | |||
| 248 | extern int xfs_buf_init(void); | 265 | extern int xfs_buf_init(void); |
| 249 | extern void xfs_buf_terminate(void); | 266 | extern void xfs_buf_terminate(void); |
| 250 | 267 | ||
| 251 | #ifdef XFS_BUF_TRACE | ||
| 252 | extern ktrace_t *xfs_buf_trace_buf; | ||
| 253 | extern void xfs_buf_trace(xfs_buf_t *, char *, void *, void *); | ||
| 254 | #else | ||
| 255 | #define xfs_buf_trace(bp,id,ptr,ra) do { } while (0) | ||
| 256 | #endif | ||
| 257 | |||
| 258 | #define xfs_buf_target_name(target) \ | 268 | #define xfs_buf_target_name(target) \ |
| 259 | ({ char __b[BDEVNAME_SIZE]; bdevname((target)->bt_bdev, __b); __b; }) | 269 | ({ char __b[BDEVNAME_SIZE]; bdevname((target)->bt_bdev, __b); __b; }) |
| 260 | 270 | ||
| @@ -370,10 +380,6 @@ static inline void xfs_buf_relse(xfs_buf_t *bp) | |||
| 370 | 380 | ||
| 371 | #define xfs_bpin(bp) xfs_buf_pin(bp) | 381 | #define xfs_bpin(bp) xfs_buf_pin(bp) |
| 372 | #define xfs_bunpin(bp) xfs_buf_unpin(bp) | 382 | #define xfs_bunpin(bp) xfs_buf_unpin(bp) |
| 373 | |||
| 374 | #define xfs_buftrace(id, bp) \ | ||
| 375 | xfs_buf_trace(bp, id, NULL, (void *)__builtin_return_address(0)) | ||
| 376 | |||
| 377 | #define xfs_biodone(bp) xfs_buf_ioend(bp, 0) | 383 | #define xfs_biodone(bp) xfs_buf_ioend(bp, 0) |
| 378 | 384 | ||
| 379 | #define xfs_biomove(bp, off, len, data, rw) \ | 385 | #define xfs_biomove(bp, off, len, data, rw) \ |
diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c index eff61e2732af..e4caeb28ce2e 100644 --- a/fs/xfs/linux-2.6/xfs_file.c +++ b/fs/xfs/linux-2.6/xfs_file.c | |||
| @@ -52,7 +52,7 @@ xfs_file_aio_read( | |||
| 52 | loff_t pos) | 52 | loff_t pos) |
| 53 | { | 53 | { |
| 54 | struct file *file = iocb->ki_filp; | 54 | struct file *file = iocb->ki_filp; |
| 55 | int ioflags = IO_ISAIO; | 55 | int ioflags = 0; |
| 56 | 56 | ||
| 57 | BUG_ON(iocb->ki_pos != pos); | 57 | BUG_ON(iocb->ki_pos != pos); |
| 58 | if (unlikely(file->f_flags & O_DIRECT)) | 58 | if (unlikely(file->f_flags & O_DIRECT)) |
| @@ -71,7 +71,7 @@ xfs_file_aio_write( | |||
| 71 | loff_t pos) | 71 | loff_t pos) |
| 72 | { | 72 | { |
| 73 | struct file *file = iocb->ki_filp; | 73 | struct file *file = iocb->ki_filp; |
| 74 | int ioflags = IO_ISAIO; | 74 | int ioflags = 0; |
| 75 | 75 | ||
| 76 | BUG_ON(iocb->ki_pos != pos); | 76 | BUG_ON(iocb->ki_pos != pos); |
| 77 | if (unlikely(file->f_flags & O_DIRECT)) | 77 | if (unlikely(file->f_flags & O_DIRECT)) |
diff --git a/fs/xfs/linux-2.6/xfs_fs_subr.c b/fs/xfs/linux-2.6/xfs_fs_subr.c index 08be36d7326c..7501b85fd860 100644 --- a/fs/xfs/linux-2.6/xfs_fs_subr.c +++ b/fs/xfs/linux-2.6/xfs_fs_subr.c | |||
| @@ -19,6 +19,7 @@ | |||
| 19 | #include "xfs_vnodeops.h" | 19 | #include "xfs_vnodeops.h" |
| 20 | #include "xfs_bmap_btree.h" | 20 | #include "xfs_bmap_btree.h" |
| 21 | #include "xfs_inode.h" | 21 | #include "xfs_inode.h" |
| 22 | #include "xfs_trace.h" | ||
| 22 | 23 | ||
| 23 | int fs_noerr(void) { return 0; } | 24 | int fs_noerr(void) { return 0; } |
| 24 | int fs_nosys(void) { return ENOSYS; } | 25 | int fs_nosys(void) { return ENOSYS; } |
| @@ -51,6 +52,8 @@ xfs_flushinval_pages( | |||
| 51 | struct address_space *mapping = VFS_I(ip)->i_mapping; | 52 | struct address_space *mapping = VFS_I(ip)->i_mapping; |
| 52 | int ret = 0; | 53 | int ret = 0; |
| 53 | 54 | ||
| 55 | trace_xfs_pagecache_inval(ip, first, last); | ||
| 56 | |||
| 54 | if (mapping->nrpages) { | 57 | if (mapping->nrpages) { |
| 55 | xfs_iflags_clear(ip, XFS_ITRUNCATED); | 58 | xfs_iflags_clear(ip, XFS_ITRUNCATED); |
| 56 | ret = filemap_write_and_wait(mapping); | 59 | ret = filemap_write_and_wait(mapping); |
diff --git a/fs/xfs/linux-2.6/xfs_ioctl.c b/fs/xfs/linux-2.6/xfs_ioctl.c index 5bb523d7f37e..a034cf624437 100644 --- a/fs/xfs/linux-2.6/xfs_ioctl.c +++ b/fs/xfs/linux-2.6/xfs_ioctl.c | |||
| @@ -51,6 +51,7 @@ | |||
| 51 | #include "xfs_quota.h" | 51 | #include "xfs_quota.h" |
| 52 | #include "xfs_inode_item.h" | 52 | #include "xfs_inode_item.h" |
| 53 | #include "xfs_export.h" | 53 | #include "xfs_export.h" |
| 54 | #include "xfs_trace.h" | ||
| 54 | 55 | ||
| 55 | #include <linux/capability.h> | 56 | #include <linux/capability.h> |
| 56 | #include <linux/dcache.h> | 57 | #include <linux/dcache.h> |
diff --git a/fs/xfs/linux-2.6/xfs_ioctl32.c b/fs/xfs/linux-2.6/xfs_ioctl32.c index eafcc7c18706..be1527b1670c 100644 --- a/fs/xfs/linux-2.6/xfs_ioctl32.c +++ b/fs/xfs/linux-2.6/xfs_ioctl32.c | |||
| @@ -46,6 +46,7 @@ | |||
| 46 | #include "xfs_attr.h" | 46 | #include "xfs_attr.h" |
| 47 | #include "xfs_ioctl.h" | 47 | #include "xfs_ioctl.h" |
| 48 | #include "xfs_ioctl32.h" | 48 | #include "xfs_ioctl32.h" |
| 49 | #include "xfs_trace.h" | ||
| 49 | 50 | ||
| 50 | #define _NATIVE_IOC(cmd, type) \ | 51 | #define _NATIVE_IOC(cmd, type) \ |
| 51 | _IOC(_IOC_DIR(cmd), _IOC_TYPE(cmd), _IOC_NR(cmd), sizeof(type)) | 52 | _IOC(_IOC_DIR(cmd), _IOC_TYPE(cmd), _IOC_NR(cmd), sizeof(type)) |
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index cd42ef78f6b5..1d5b298ba8b2 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c | |||
| @@ -47,6 +47,7 @@ | |||
| 47 | #include "xfs_buf_item.h" | 47 | #include "xfs_buf_item.h" |
| 48 | #include "xfs_utils.h" | 48 | #include "xfs_utils.h" |
| 49 | #include "xfs_vnodeops.h" | 49 | #include "xfs_vnodeops.h" |
| 50 | #include "xfs_trace.h" | ||
| 50 | 51 | ||
| 51 | #include <linux/capability.h> | 52 | #include <linux/capability.h> |
| 52 | #include <linux/xattr.h> | 53 | #include <linux/xattr.h> |
| @@ -573,8 +574,8 @@ xfs_vn_fallocate( | |||
| 573 | bf.l_len = len; | 574 | bf.l_len = len; |
| 574 | 575 | ||
| 575 | xfs_ilock(ip, XFS_IOLOCK_EXCL); | 576 | xfs_ilock(ip, XFS_IOLOCK_EXCL); |
| 576 | error = xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf, | 577 | error = -xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf, |
| 577 | 0, XFS_ATTR_NOLOCK); | 578 | 0, XFS_ATTR_NOLOCK); |
| 578 | if (!error && !(mode & FALLOC_FL_KEEP_SIZE) && | 579 | if (!error && !(mode & FALLOC_FL_KEEP_SIZE) && |
| 579 | offset + len > i_size_read(inode)) | 580 | offset + len > i_size_read(inode)) |
| 580 | new_size = offset + len; | 581 | new_size = offset + len; |
| @@ -585,7 +586,7 @@ xfs_vn_fallocate( | |||
| 585 | 586 | ||
| 586 | iattr.ia_valid = ATTR_SIZE; | 587 | iattr.ia_valid = ATTR_SIZE; |
| 587 | iattr.ia_size = new_size; | 588 | iattr.ia_size = new_size; |
| 588 | error = xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK); | 589 | error = -xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK); |
| 589 | } | 590 | } |
| 590 | 591 | ||
| 591 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | 592 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); |
diff --git a/fs/xfs/linux-2.6/xfs_linux.h b/fs/xfs/linux-2.6/xfs_linux.h index 6127e24062d0..5af0c81ca1ae 100644 --- a/fs/xfs/linux-2.6/xfs_linux.h +++ b/fs/xfs/linux-2.6/xfs_linux.h | |||
| @@ -40,7 +40,6 @@ | |||
| 40 | #include <sv.h> | 40 | #include <sv.h> |
| 41 | #include <time.h> | 41 | #include <time.h> |
| 42 | 42 | ||
| 43 | #include <support/ktrace.h> | ||
| 44 | #include <support/debug.h> | 43 | #include <support/debug.h> |
| 45 | #include <support/uuid.h> | 44 | #include <support/uuid.h> |
| 46 | 45 | ||
diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c index 072050f8d346..0d32457abef1 100644 --- a/fs/xfs/linux-2.6/xfs_lrw.c +++ b/fs/xfs/linux-2.6/xfs_lrw.c | |||
| @@ -48,73 +48,12 @@ | |||
| 48 | #include "xfs_utils.h" | 48 | #include "xfs_utils.h" |
| 49 | #include "xfs_iomap.h" | 49 | #include "xfs_iomap.h" |
| 50 | #include "xfs_vnodeops.h" | 50 | #include "xfs_vnodeops.h" |
| 51 | #include "xfs_trace.h" | ||
| 51 | 52 | ||
| 52 | #include <linux/capability.h> | 53 | #include <linux/capability.h> |
| 53 | #include <linux/writeback.h> | 54 | #include <linux/writeback.h> |
| 54 | 55 | ||
| 55 | 56 | ||
| 56 | #if defined(XFS_RW_TRACE) | ||
| 57 | void | ||
| 58 | xfs_rw_enter_trace( | ||
| 59 | int tag, | ||
| 60 | xfs_inode_t *ip, | ||
| 61 | void *data, | ||
| 62 | size_t segs, | ||
| 63 | loff_t offset, | ||
| 64 | int ioflags) | ||
| 65 | { | ||
| 66 | if (ip->i_rwtrace == NULL) | ||
| 67 | return; | ||
| 68 | ktrace_enter(ip->i_rwtrace, | ||
| 69 | (void *)(unsigned long)tag, | ||
| 70 | (void *)ip, | ||
| 71 | (void *)((unsigned long)((ip->i_d.di_size >> 32) & 0xffffffff)), | ||
| 72 | (void *)((unsigned long)(ip->i_d.di_size & 0xffffffff)), | ||
| 73 | (void *)data, | ||
| 74 | (void *)((unsigned long)segs), | ||
| 75 | (void *)((unsigned long)((offset >> 32) & 0xffffffff)), | ||
| 76 | (void *)((unsigned long)(offset & 0xffffffff)), | ||
| 77 | (void *)((unsigned long)ioflags), | ||
| 78 | (void *)((unsigned long)((ip->i_new_size >> 32) & 0xffffffff)), | ||
| 79 | (void *)((unsigned long)(ip->i_new_size & 0xffffffff)), | ||
| 80 | (void *)((unsigned long)current_pid()), | ||
| 81 | (void *)NULL, | ||
| 82 | (void *)NULL, | ||
| 83 | (void *)NULL, | ||
| 84 | (void *)NULL); | ||
| 85 | } | ||
| 86 | |||
| 87 | void | ||
| 88 | xfs_inval_cached_trace( | ||
| 89 | xfs_inode_t *ip, | ||
| 90 | xfs_off_t offset, | ||
| 91 | xfs_off_t len, | ||
| 92 | xfs_off_t first, | ||
| 93 | xfs_off_t last) | ||
| 94 | { | ||
| 95 | |||
| 96 | if (ip->i_rwtrace == NULL) | ||
| 97 | return; | ||
| 98 | ktrace_enter(ip->i_rwtrace, | ||
| 99 | (void *)(__psint_t)XFS_INVAL_CACHED, | ||
| 100 | (void *)ip, | ||
| 101 | (void *)((unsigned long)((offset >> 32) & 0xffffffff)), | ||
| 102 | (void *)((unsigned long)(offset & 0xffffffff)), | ||
| 103 | (void *)((unsigned long)((len >> 32) & 0xffffffff)), | ||
| 104 | (void *)((unsigned long)(len & 0xffffffff)), | ||
| 105 | (void *)((unsigned long)((first >> 32) & 0xffffffff)), | ||
| 106 | (void *)((unsigned long)(first & 0xffffffff)), | ||
| 107 | (void *)((unsigned long)((last >> 32) & 0xffffffff)), | ||
| 108 | (void *)((unsigned long)(last & 0xffffffff)), | ||
| 109 | (void *)((unsigned long)current_pid()), | ||
| 110 | (void *)NULL, | ||
| 111 | (void *)NULL, | ||
| 112 | (void *)NULL, | ||
| 113 | (void *)NULL, | ||
| 114 | (void *)NULL); | ||
| 115 | } | ||
| 116 | #endif | ||
| 117 | |||
| 118 | /* | 57 | /* |
| 119 | * xfs_iozero | 58 | * xfs_iozero |
| 120 | * | 59 | * |
| @@ -250,13 +189,10 @@ xfs_read( | |||
| 250 | } | 189 | } |
| 251 | } | 190 | } |
| 252 | 191 | ||
| 253 | xfs_rw_enter_trace(XFS_READ_ENTER, ip, | 192 | trace_xfs_file_read(ip, size, *offset, ioflags); |
| 254 | (void *)iovp, segs, *offset, ioflags); | ||
| 255 | 193 | ||
| 256 | iocb->ki_pos = *offset; | 194 | iocb->ki_pos = *offset; |
| 257 | ret = generic_file_aio_read(iocb, iovp, segs, *offset); | 195 | ret = generic_file_aio_read(iocb, iovp, segs, *offset); |
| 258 | if (ret == -EIOCBQUEUED && !(ioflags & IO_ISAIO)) | ||
| 259 | ret = wait_on_sync_kiocb(iocb); | ||
| 260 | if (ret > 0) | 196 | if (ret > 0) |
| 261 | XFS_STATS_ADD(xs_read_bytes, ret); | 197 | XFS_STATS_ADD(xs_read_bytes, ret); |
| 262 | 198 | ||
| @@ -294,8 +230,9 @@ xfs_splice_read( | |||
| 294 | return -error; | 230 | return -error; |
| 295 | } | 231 | } |
| 296 | } | 232 | } |
| 297 | xfs_rw_enter_trace(XFS_SPLICE_READ_ENTER, ip, | 233 | |
| 298 | pipe, count, *ppos, ioflags); | 234 | trace_xfs_file_splice_read(ip, count, *ppos, ioflags); |
| 235 | |||
| 299 | ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); | 236 | ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); |
| 300 | if (ret > 0) | 237 | if (ret > 0) |
| 301 | XFS_STATS_ADD(xs_read_bytes, ret); | 238 | XFS_STATS_ADD(xs_read_bytes, ret); |
| @@ -344,8 +281,8 @@ xfs_splice_write( | |||
| 344 | ip->i_new_size = new_size; | 281 | ip->i_new_size = new_size; |
| 345 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | 282 | xfs_iunlock(ip, XFS_ILOCK_EXCL); |
| 346 | 283 | ||
| 347 | xfs_rw_enter_trace(XFS_SPLICE_WRITE_ENTER, ip, | 284 | trace_xfs_file_splice_write(ip, count, *ppos, ioflags); |
| 348 | pipe, count, *ppos, ioflags); | 285 | |
| 349 | ret = generic_file_splice_write(pipe, outfilp, ppos, count, flags); | 286 | ret = generic_file_splice_write(pipe, outfilp, ppos, count, flags); |
| 350 | if (ret > 0) | 287 | if (ret > 0) |
| 351 | XFS_STATS_ADD(xs_write_bytes, ret); | 288 | XFS_STATS_ADD(xs_write_bytes, ret); |
| @@ -712,8 +649,6 @@ start: | |||
| 712 | if ((ioflags & IO_ISDIRECT)) { | 649 | if ((ioflags & IO_ISDIRECT)) { |
| 713 | if (mapping->nrpages) { | 650 | if (mapping->nrpages) { |
| 714 | WARN_ON(need_i_mutex == 0); | 651 | WARN_ON(need_i_mutex == 0); |
| 715 | xfs_inval_cached_trace(xip, pos, -1, | ||
| 716 | (pos & PAGE_CACHE_MASK), -1); | ||
| 717 | error = xfs_flushinval_pages(xip, | 652 | error = xfs_flushinval_pages(xip, |
| 718 | (pos & PAGE_CACHE_MASK), | 653 | (pos & PAGE_CACHE_MASK), |
| 719 | -1, FI_REMAPF_LOCKED); | 654 | -1, FI_REMAPF_LOCKED); |
| @@ -730,8 +665,7 @@ start: | |||
| 730 | need_i_mutex = 0; | 665 | need_i_mutex = 0; |
| 731 | } | 666 | } |
| 732 | 667 | ||
| 733 | xfs_rw_enter_trace(XFS_DIOWR_ENTER, xip, (void *)iovp, segs, | 668 | trace_xfs_file_direct_write(xip, count, *offset, ioflags); |
| 734 | *offset, ioflags); | ||
| 735 | ret = generic_file_direct_write(iocb, iovp, | 669 | ret = generic_file_direct_write(iocb, iovp, |
| 736 | &segs, pos, offset, count, ocount); | 670 | &segs, pos, offset, count, ocount); |
| 737 | 671 | ||
| @@ -754,8 +688,7 @@ start: | |||
| 754 | ssize_t ret2 = 0; | 688 | ssize_t ret2 = 0; |
| 755 | 689 | ||
| 756 | write_retry: | 690 | write_retry: |
| 757 | xfs_rw_enter_trace(XFS_WRITE_ENTER, xip, (void *)iovp, segs, | 691 | trace_xfs_file_buffered_write(xip, count, *offset, ioflags); |
| 758 | *offset, ioflags); | ||
| 759 | ret2 = generic_file_buffered_write(iocb, iovp, segs, | 692 | ret2 = generic_file_buffered_write(iocb, iovp, segs, |
| 760 | pos, offset, count, ret); | 693 | pos, offset, count, ret); |
| 761 | /* | 694 | /* |
| @@ -774,9 +707,6 @@ write_retry: | |||
| 774 | 707 | ||
| 775 | current->backing_dev_info = NULL; | 708 | current->backing_dev_info = NULL; |
| 776 | 709 | ||
| 777 | if (ret == -EIOCBQUEUED && !(ioflags & IO_ISAIO)) | ||
| 778 | ret = wait_on_sync_kiocb(iocb); | ||
| 779 | |||
| 780 | isize = i_size_read(inode); | 710 | isize = i_size_read(inode); |
| 781 | if (unlikely(ret < 0 && ret != -EFAULT && *offset > isize)) | 711 | if (unlikely(ret < 0 && ret != -EFAULT && *offset > isize)) |
| 782 | *offset = isize; | 712 | *offset = isize; |
| @@ -811,7 +741,7 @@ write_retry: | |||
| 811 | XFS_STATS_ADD(xs_write_bytes, ret); | 741 | XFS_STATS_ADD(xs_write_bytes, ret); |
| 812 | 742 | ||
| 813 | /* Handle various SYNC-type writes */ | 743 | /* Handle various SYNC-type writes */ |
| 814 | if ((file->f_flags & O_SYNC) || IS_SYNC(inode)) { | 744 | if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) { |
| 815 | loff_t end = pos + ret - 1; | 745 | loff_t end = pos + ret - 1; |
| 816 | int error2; | 746 | int error2; |
| 817 | 747 | ||
| @@ -863,7 +793,7 @@ int | |||
| 863 | xfs_bdstrat_cb(struct xfs_buf *bp) | 793 | xfs_bdstrat_cb(struct xfs_buf *bp) |
| 864 | { | 794 | { |
| 865 | if (XFS_FORCED_SHUTDOWN(bp->b_mount)) { | 795 | if (XFS_FORCED_SHUTDOWN(bp->b_mount)) { |
| 866 | xfs_buftrace("XFS__BDSTRAT IOERROR", bp); | 796 | trace_xfs_bdstrat_shut(bp, _RET_IP_); |
| 867 | /* | 797 | /* |
| 868 | * Metadata write that didn't get logged but | 798 | * Metadata write that didn't get logged but |
| 869 | * written delayed anyway. These aren't associated | 799 | * written delayed anyway. These aren't associated |
| @@ -896,7 +826,7 @@ xfsbdstrat( | |||
| 896 | return; | 826 | return; |
| 897 | } | 827 | } |
| 898 | 828 | ||
| 899 | xfs_buftrace("XFSBDSTRAT IOERROR", bp); | 829 | trace_xfs_bdstrat_shut(bp, _RET_IP_); |
| 900 | xfs_bioerror_relse(bp); | 830 | xfs_bioerror_relse(bp); |
| 901 | } | 831 | } |
| 902 | 832 | ||
diff --git a/fs/xfs/linux-2.6/xfs_lrw.h b/fs/xfs/linux-2.6/xfs_lrw.h index e6be37dbd0e9..d1f7789c7ffb 100644 --- a/fs/xfs/linux-2.6/xfs_lrw.h +++ b/fs/xfs/linux-2.6/xfs_lrw.h | |||
| @@ -20,52 +20,7 @@ | |||
| 20 | 20 | ||
| 21 | struct xfs_mount; | 21 | struct xfs_mount; |
| 22 | struct xfs_inode; | 22 | struct xfs_inode; |
| 23 | struct xfs_bmbt_irec; | ||
| 24 | struct xfs_buf; | 23 | struct xfs_buf; |
| 25 | struct xfs_iomap; | ||
| 26 | |||
| 27 | #if defined(XFS_RW_TRACE) | ||
| 28 | /* | ||
| 29 | * Defines for the trace mechanisms in xfs_lrw.c. | ||
| 30 | */ | ||
| 31 | #define XFS_RW_KTRACE_SIZE 128 | ||
| 32 | |||
| 33 | #define XFS_READ_ENTER 1 | ||
| 34 | #define XFS_WRITE_ENTER 2 | ||
| 35 | #define XFS_IOMAP_READ_ENTER 3 | ||
| 36 | #define XFS_IOMAP_WRITE_ENTER 4 | ||
| 37 | #define XFS_IOMAP_READ_MAP 5 | ||
| 38 | #define XFS_IOMAP_WRITE_MAP 6 | ||
| 39 | #define XFS_IOMAP_WRITE_NOSPACE 7 | ||
| 40 | #define XFS_ITRUNC_START 8 | ||
| 41 | #define XFS_ITRUNC_FINISH1 9 | ||
| 42 | #define XFS_ITRUNC_FINISH2 10 | ||
| 43 | #define XFS_CTRUNC1 11 | ||
| 44 | #define XFS_CTRUNC2 12 | ||
| 45 | #define XFS_CTRUNC3 13 | ||
| 46 | #define XFS_CTRUNC4 14 | ||
| 47 | #define XFS_CTRUNC5 15 | ||
| 48 | #define XFS_CTRUNC6 16 | ||
| 49 | #define XFS_BUNMAP 17 | ||
| 50 | #define XFS_INVAL_CACHED 18 | ||
| 51 | #define XFS_DIORD_ENTER 19 | ||
| 52 | #define XFS_DIOWR_ENTER 20 | ||
| 53 | #define XFS_WRITEPAGE_ENTER 22 | ||
| 54 | #define XFS_RELEASEPAGE_ENTER 23 | ||
| 55 | #define XFS_INVALIDPAGE_ENTER 24 | ||
| 56 | #define XFS_IOMAP_ALLOC_ENTER 25 | ||
| 57 | #define XFS_IOMAP_ALLOC_MAP 26 | ||
| 58 | #define XFS_IOMAP_UNWRITTEN 27 | ||
| 59 | #define XFS_SPLICE_READ_ENTER 28 | ||
| 60 | #define XFS_SPLICE_WRITE_ENTER 29 | ||
| 61 | extern void xfs_rw_enter_trace(int, struct xfs_inode *, | ||
| 62 | void *, size_t, loff_t, int); | ||
| 63 | extern void xfs_inval_cached_trace(struct xfs_inode *, | ||
| 64 | xfs_off_t, xfs_off_t, xfs_off_t, xfs_off_t); | ||
| 65 | #else | ||
| 66 | #define xfs_rw_enter_trace(tag, ip, data, size, offset, ioflags) | ||
| 67 | #define xfs_inval_cached_trace(ip, offset, len, first, last) | ||
| 68 | #endif | ||
| 69 | 24 | ||
| 70 | /* errors from xfsbdstrat() must be extracted from the buffer */ | 25 | /* errors from xfsbdstrat() must be extracted from the buffer */ |
| 71 | extern void xfsbdstrat(struct xfs_mount *, struct xfs_buf *); | 26 | extern void xfsbdstrat(struct xfs_mount *, struct xfs_buf *); |
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index 18a4b8e11df2..09783cc444ac 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | * along with this program; if not, write the Free Software Foundation, | 15 | * along with this program; if not, write the Free Software Foundation, |
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
| 17 | */ | 17 | */ |
| 18 | |||
| 18 | #include "xfs.h" | 19 | #include "xfs.h" |
| 19 | #include "xfs_bit.h" | 20 | #include "xfs_bit.h" |
| 20 | #include "xfs_log.h" | 21 | #include "xfs_log.h" |
| @@ -52,11 +53,11 @@ | |||
| 52 | #include "xfs_trans_priv.h" | 53 | #include "xfs_trans_priv.h" |
| 53 | #include "xfs_filestream.h" | 54 | #include "xfs_filestream.h" |
| 54 | #include "xfs_da_btree.h" | 55 | #include "xfs_da_btree.h" |
| 55 | #include "xfs_dir2_trace.h" | ||
| 56 | #include "xfs_extfree_item.h" | 56 | #include "xfs_extfree_item.h" |
| 57 | #include "xfs_mru_cache.h" | 57 | #include "xfs_mru_cache.h" |
| 58 | #include "xfs_inode_item.h" | 58 | #include "xfs_inode_item.h" |
| 59 | #include "xfs_sync.h" | 59 | #include "xfs_sync.h" |
| 60 | #include "xfs_trace.h" | ||
| 60 | 61 | ||
| 61 | #include <linux/namei.h> | 62 | #include <linux/namei.h> |
| 62 | #include <linux/init.h> | 63 | #include <linux/init.h> |
| @@ -930,13 +931,39 @@ xfs_fs_alloc_inode( | |||
| 930 | */ | 931 | */ |
| 931 | STATIC void | 932 | STATIC void |
| 932 | xfs_fs_destroy_inode( | 933 | xfs_fs_destroy_inode( |
| 933 | struct inode *inode) | 934 | struct inode *inode) |
| 934 | { | 935 | { |
| 935 | xfs_inode_t *ip = XFS_I(inode); | 936 | struct xfs_inode *ip = XFS_I(inode); |
| 937 | |||
| 938 | xfs_itrace_entry(ip); | ||
| 936 | 939 | ||
| 937 | XFS_STATS_INC(vn_reclaim); | 940 | XFS_STATS_INC(vn_reclaim); |
| 938 | if (xfs_reclaim(ip)) | 941 | |
| 939 | panic("%s: cannot reclaim 0x%p\n", __func__, inode); | 942 | /* bad inode, get out here ASAP */ |
| 943 | if (is_bad_inode(inode)) | ||
| 944 | goto out_reclaim; | ||
| 945 | |||
| 946 | xfs_ioend_wait(ip); | ||
| 947 | |||
| 948 | ASSERT(XFS_FORCED_SHUTDOWN(ip->i_mount) || ip->i_delayed_blks == 0); | ||
| 949 | |||
| 950 | /* | ||
| 951 | * We should never get here with one of the reclaim flags already set. | ||
| 952 | */ | ||
| 953 | ASSERT_ALWAYS(!xfs_iflags_test(ip, XFS_IRECLAIMABLE)); | ||
| 954 | ASSERT_ALWAYS(!xfs_iflags_test(ip, XFS_IRECLAIM)); | ||
| 955 | |||
| 956 | /* | ||
| 957 | * If we have nothing to flush with this inode then complete the | ||
| 958 | * teardown now, otherwise delay the flush operation. | ||
| 959 | */ | ||
| 960 | if (!xfs_inode_clean(ip)) { | ||
| 961 | xfs_inode_set_reclaim_tag(ip); | ||
| 962 | return; | ||
| 963 | } | ||
| 964 | |||
| 965 | out_reclaim: | ||
| 966 | xfs_ireclaim(ip); | ||
| 940 | } | 967 | } |
| 941 | 968 | ||
| 942 | /* | 969 | /* |
| @@ -973,7 +1000,6 @@ xfs_fs_inode_init_once( | |||
| 973 | 1000 | ||
| 974 | mrlock_init(&ip->i_lock, MRLOCK_ALLOW_EQUAL_PRI|MRLOCK_BARRIER, | 1001 | mrlock_init(&ip->i_lock, MRLOCK_ALLOW_EQUAL_PRI|MRLOCK_BARRIER, |
| 975 | "xfsino", ip->i_ino); | 1002 | "xfsino", ip->i_ino); |
| 976 | mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino); | ||
| 977 | } | 1003 | } |
| 978 | 1004 | ||
| 979 | /* | 1005 | /* |
| @@ -1075,6 +1101,20 @@ xfs_fs_clear_inode( | |||
| 1075 | XFS_STATS_INC(vn_remove); | 1101 | XFS_STATS_INC(vn_remove); |
| 1076 | XFS_STATS_DEC(vn_active); | 1102 | XFS_STATS_DEC(vn_active); |
| 1077 | 1103 | ||
| 1104 | /* | ||
| 1105 | * The iolock is used by the file system to coordinate reads, | ||
| 1106 | * writes, and block truncates. Up to this point the lock | ||
| 1107 | * protected concurrent accesses by users of the inode. But | ||
| 1108 | * from here forward we're doing some final processing of the | ||
| 1109 | * inode because we're done with it, and although we reuse the | ||
| 1110 | * iolock for protection it is really a distinct lock class | ||
| 1111 | * (in the lockdep sense) from before. To keep lockdep happy | ||
| 1112 | * (and basically indicate what we are doing), we explicitly | ||
| 1113 | * re-init the iolock here. | ||
| 1114 | */ | ||
| 1115 | ASSERT(!rwsem_is_locked(&ip->i_iolock.mr_lock)); | ||
| 1116 | mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino); | ||
| 1117 | |||
| 1078 | xfs_inactive(ip); | 1118 | xfs_inactive(ip); |
| 1079 | } | 1119 | } |
| 1080 | 1120 | ||
| @@ -1092,8 +1132,6 @@ xfs_fs_put_super( | |||
| 1092 | struct super_block *sb) | 1132 | struct super_block *sb) |
| 1093 | { | 1133 | { |
| 1094 | struct xfs_mount *mp = XFS_M(sb); | 1134 | struct xfs_mount *mp = XFS_M(sb); |
| 1095 | struct xfs_inode *rip = mp->m_rootip; | ||
| 1096 | int unmount_event_flags = 0; | ||
| 1097 | 1135 | ||
| 1098 | xfs_syncd_stop(mp); | 1136 | xfs_syncd_stop(mp); |
| 1099 | 1137 | ||
| @@ -1109,20 +1147,7 @@ xfs_fs_put_super( | |||
| 1109 | xfs_sync_attr(mp, 0); | 1147 | xfs_sync_attr(mp, 0); |
| 1110 | } | 1148 | } |
| 1111 | 1149 | ||
| 1112 | #ifdef HAVE_DMAPI | 1150 | XFS_SEND_PREUNMOUNT(mp); |
| 1113 | if (mp->m_flags & XFS_MOUNT_DMAPI) { | ||
| 1114 | unmount_event_flags = | ||
| 1115 | (mp->m_dmevmask & (1 << DM_EVENT_UNMOUNT)) ? | ||
| 1116 | 0 : DM_FLAGS_UNWANTED; | ||
| 1117 | /* | ||
| 1118 | * Ignore error from dmapi here, first unmount is not allowed | ||
| 1119 | * to fail anyway, and second we wouldn't want to fail a | ||
| 1120 | * unmount because of dmapi. | ||
| 1121 | */ | ||
| 1122 | XFS_SEND_PREUNMOUNT(mp, rip, DM_RIGHT_NULL, rip, DM_RIGHT_NULL, | ||
| 1123 | NULL, NULL, 0, 0, unmount_event_flags); | ||
| 1124 | } | ||
| 1125 | #endif | ||
| 1126 | 1151 | ||
| 1127 | /* | 1152 | /* |
| 1128 | * Blow away any referenced inode in the filestreams cache. | 1153 | * Blow away any referenced inode in the filestreams cache. |
| @@ -1133,10 +1158,7 @@ xfs_fs_put_super( | |||
| 1133 | 1158 | ||
| 1134 | XFS_bflush(mp->m_ddev_targp); | 1159 | XFS_bflush(mp->m_ddev_targp); |
| 1135 | 1160 | ||
| 1136 | if (mp->m_flags & XFS_MOUNT_DMAPI) { | 1161 | XFS_SEND_UNMOUNT(mp); |
| 1137 | XFS_SEND_UNMOUNT(mp, rip, DM_RIGHT_NULL, 0, 0, | ||
| 1138 | unmount_event_flags); | ||
| 1139 | } | ||
| 1140 | 1162 | ||
| 1141 | xfs_unmountfs(mp); | 1163 | xfs_unmountfs(mp); |
| 1142 | xfs_freesb(mp); | 1164 | xfs_freesb(mp); |
| @@ -1504,8 +1526,6 @@ xfs_fs_fill_super( | |||
| 1504 | goto fail_vnrele; | 1526 | goto fail_vnrele; |
| 1505 | 1527 | ||
| 1506 | kfree(mtpt); | 1528 | kfree(mtpt); |
| 1507 | |||
| 1508 | xfs_itrace_exit(XFS_I(sb->s_root->d_inode)); | ||
| 1509 | return 0; | 1529 | return 0; |
| 1510 | 1530 | ||
| 1511 | out_filestream_unmount: | 1531 | out_filestream_unmount: |
| @@ -1581,94 +1601,6 @@ static struct file_system_type xfs_fs_type = { | |||
| 1581 | }; | 1601 | }; |
| 1582 | 1602 | ||
| 1583 | STATIC int __init | 1603 | STATIC int __init |
| 1584 | xfs_alloc_trace_bufs(void) | ||
| 1585 | { | ||
| 1586 | #ifdef XFS_ALLOC_TRACE | ||
| 1587 | xfs_alloc_trace_buf = ktrace_alloc(XFS_ALLOC_TRACE_SIZE, KM_MAYFAIL); | ||
| 1588 | if (!xfs_alloc_trace_buf) | ||
| 1589 | goto out; | ||
| 1590 | #endif | ||
| 1591 | #ifdef XFS_BMAP_TRACE | ||
| 1592 | xfs_bmap_trace_buf = ktrace_alloc(XFS_BMAP_TRACE_SIZE, KM_MAYFAIL); | ||
| 1593 | if (!xfs_bmap_trace_buf) | ||
| 1594 | goto out_free_alloc_trace; | ||
| 1595 | #endif | ||
| 1596 | #ifdef XFS_BTREE_TRACE | ||
| 1597 | xfs_allocbt_trace_buf = ktrace_alloc(XFS_ALLOCBT_TRACE_SIZE, | ||
| 1598 | KM_MAYFAIL); | ||
| 1599 | if (!xfs_allocbt_trace_buf) | ||
| 1600 | goto out_free_bmap_trace; | ||
| 1601 | |||
| 1602 | xfs_inobt_trace_buf = ktrace_alloc(XFS_INOBT_TRACE_SIZE, KM_MAYFAIL); | ||
| 1603 | if (!xfs_inobt_trace_buf) | ||
| 1604 | goto out_free_allocbt_trace; | ||
| 1605 | |||
| 1606 | xfs_bmbt_trace_buf = ktrace_alloc(XFS_BMBT_TRACE_SIZE, KM_MAYFAIL); | ||
| 1607 | if (!xfs_bmbt_trace_buf) | ||
| 1608 | goto out_free_inobt_trace; | ||
| 1609 | #endif | ||
| 1610 | #ifdef XFS_ATTR_TRACE | ||
| 1611 | xfs_attr_trace_buf = ktrace_alloc(XFS_ATTR_TRACE_SIZE, KM_MAYFAIL); | ||
| 1612 | if (!xfs_attr_trace_buf) | ||
| 1613 | goto out_free_bmbt_trace; | ||
| 1614 | #endif | ||
| 1615 | #ifdef XFS_DIR2_TRACE | ||
| 1616 | xfs_dir2_trace_buf = ktrace_alloc(XFS_DIR2_GTRACE_SIZE, KM_MAYFAIL); | ||
| 1617 | if (!xfs_dir2_trace_buf) | ||
| 1618 | goto out_free_attr_trace; | ||
| 1619 | #endif | ||
| 1620 | |||
| 1621 | return 0; | ||
| 1622 | |||
| 1623 | #ifdef XFS_DIR2_TRACE | ||
| 1624 | out_free_attr_trace: | ||
| 1625 | #endif | ||
| 1626 | #ifdef XFS_ATTR_TRACE | ||
| 1627 | ktrace_free(xfs_attr_trace_buf); | ||
| 1628 | out_free_bmbt_trace: | ||
| 1629 | #endif | ||
| 1630 | #ifdef XFS_BTREE_TRACE | ||
| 1631 | ktrace_free(xfs_bmbt_trace_buf); | ||
| 1632 | out_free_inobt_trace: | ||
| 1633 | ktrace_free(xfs_inobt_trace_buf); | ||
| 1634 | out_free_allocbt_trace: | ||
| 1635 | ktrace_free(xfs_allocbt_trace_buf); | ||
| 1636 | out_free_bmap_trace: | ||
| 1637 | #endif | ||
| 1638 | #ifdef XFS_BMAP_TRACE | ||
| 1639 | ktrace_free(xfs_bmap_trace_buf); | ||
| 1640 | out_free_alloc_trace: | ||
| 1641 | #endif | ||
| 1642 | #ifdef XFS_ALLOC_TRACE | ||
| 1643 | ktrace_free(xfs_alloc_trace_buf); | ||
| 1644 | out: | ||
| 1645 | #endif | ||
| 1646 | return -ENOMEM; | ||
| 1647 | } | ||
| 1648 | |||
| 1649 | STATIC void | ||
| 1650 | xfs_free_trace_bufs(void) | ||
| 1651 | { | ||
| 1652 | #ifdef XFS_DIR2_TRACE | ||
| 1653 | ktrace_free(xfs_dir2_trace_buf); | ||
| 1654 | #endif | ||
| 1655 | #ifdef XFS_ATTR_TRACE | ||
| 1656 | ktrace_free(xfs_attr_trace_buf); | ||
| 1657 | #endif | ||
| 1658 | #ifdef XFS_BTREE_TRACE | ||
| 1659 | ktrace_free(xfs_bmbt_trace_buf); | ||
| 1660 | ktrace_free(xfs_inobt_trace_buf); | ||
| 1661 | ktrace_free(xfs_allocbt_trace_buf); | ||
| 1662 | #endif | ||
| 1663 | #ifdef XFS_BMAP_TRACE | ||
| 1664 | ktrace_free(xfs_bmap_trace_buf); | ||
| 1665 | #endif | ||
| 1666 | #ifdef XFS_ALLOC_TRACE | ||
| 1667 | ktrace_free(xfs_alloc_trace_buf); | ||
| 1668 | #endif | ||
| 1669 | } | ||
| 1670 | |||
| 1671 | STATIC int __init | ||
| 1672 | xfs_init_zones(void) | 1604 | xfs_init_zones(void) |
| 1673 | { | 1605 | { |
| 1674 | 1606 | ||
| @@ -1809,7 +1741,6 @@ init_xfs_fs(void) | |||
| 1809 | printk(KERN_INFO XFS_VERSION_STRING " with " | 1741 | printk(KERN_INFO XFS_VERSION_STRING " with " |
| 1810 | XFS_BUILD_OPTIONS " enabled\n"); | 1742 | XFS_BUILD_OPTIONS " enabled\n"); |
| 1811 | 1743 | ||
| 1812 | ktrace_init(64); | ||
| 1813 | xfs_ioend_init(); | 1744 | xfs_ioend_init(); |
| 1814 | xfs_dir_startup(); | 1745 | xfs_dir_startup(); |
| 1815 | 1746 | ||
| @@ -1817,13 +1748,9 @@ init_xfs_fs(void) | |||
| 1817 | if (error) | 1748 | if (error) |
| 1818 | goto out; | 1749 | goto out; |
| 1819 | 1750 | ||
| 1820 | error = xfs_alloc_trace_bufs(); | ||
| 1821 | if (error) | ||
| 1822 | goto out_destroy_zones; | ||
| 1823 | |||
| 1824 | error = xfs_mru_cache_init(); | 1751 | error = xfs_mru_cache_init(); |
| 1825 | if (error) | 1752 | if (error) |
| 1826 | goto out_free_trace_buffers; | 1753 | goto out_destroy_zones; |
| 1827 | 1754 | ||
| 1828 | error = xfs_filestream_init(); | 1755 | error = xfs_filestream_init(); |
| 1829 | if (error) | 1756 | if (error) |
| @@ -1858,8 +1785,6 @@ init_xfs_fs(void) | |||
| 1858 | xfs_filestream_uninit(); | 1785 | xfs_filestream_uninit(); |
| 1859 | out_mru_cache_uninit: | 1786 | out_mru_cache_uninit: |
| 1860 | xfs_mru_cache_uninit(); | 1787 | xfs_mru_cache_uninit(); |
| 1861 | out_free_trace_buffers: | ||
| 1862 | xfs_free_trace_bufs(); | ||
| 1863 | out_destroy_zones: | 1788 | out_destroy_zones: |
| 1864 | xfs_destroy_zones(); | 1789 | xfs_destroy_zones(); |
| 1865 | out: | 1790 | out: |
| @@ -1876,9 +1801,7 @@ exit_xfs_fs(void) | |||
| 1876 | xfs_buf_terminate(); | 1801 | xfs_buf_terminate(); |
| 1877 | xfs_filestream_uninit(); | 1802 | xfs_filestream_uninit(); |
| 1878 | xfs_mru_cache_uninit(); | 1803 | xfs_mru_cache_uninit(); |
| 1879 | xfs_free_trace_bufs(); | ||
| 1880 | xfs_destroy_zones(); | 1804 | xfs_destroy_zones(); |
| 1881 | ktrace_uninit(); | ||
| 1882 | } | 1805 | } |
| 1883 | 1806 | ||
| 1884 | module_init(init_xfs_fs); | 1807 | module_init(init_xfs_fs); |
diff --git a/fs/xfs/linux-2.6/xfs_super.h b/fs/xfs/linux-2.6/xfs_super.h index 18175ebd58ed..233d4b9881b1 100644 --- a/fs/xfs/linux-2.6/xfs_super.h +++ b/fs/xfs/linux-2.6/xfs_super.h | |||
| @@ -56,12 +56,6 @@ extern void xfs_qm_exit(void); | |||
| 56 | # define XFS_BIGFS_STRING | 56 | # define XFS_BIGFS_STRING |
| 57 | #endif | 57 | #endif |
| 58 | 58 | ||
| 59 | #ifdef CONFIG_XFS_TRACE | ||
| 60 | # define XFS_TRACE_STRING "tracing, " | ||
| 61 | #else | ||
| 62 | # define XFS_TRACE_STRING | ||
| 63 | #endif | ||
| 64 | |||
| 65 | #ifdef CONFIG_XFS_DMAPI | 59 | #ifdef CONFIG_XFS_DMAPI |
| 66 | # define XFS_DMAPI_STRING "dmapi support, " | 60 | # define XFS_DMAPI_STRING "dmapi support, " |
| 67 | #else | 61 | #else |
| @@ -78,7 +72,6 @@ extern void xfs_qm_exit(void); | |||
| 78 | XFS_SECURITY_STRING \ | 72 | XFS_SECURITY_STRING \ |
| 79 | XFS_REALTIME_STRING \ | 73 | XFS_REALTIME_STRING \ |
| 80 | XFS_BIGFS_STRING \ | 74 | XFS_BIGFS_STRING \ |
| 81 | XFS_TRACE_STRING \ | ||
| 82 | XFS_DMAPI_STRING \ | 75 | XFS_DMAPI_STRING \ |
| 83 | XFS_DBG_STRING /* DBG must be last */ | 76 | XFS_DBG_STRING /* DBG must be last */ |
| 84 | 77 | ||
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c index 961df0a22c78..6fed97a8cd3e 100644 --- a/fs/xfs/linux-2.6/xfs_sync.c +++ b/fs/xfs/linux-2.6/xfs_sync.c | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | #include "xfs_inode_item.h" | 44 | #include "xfs_inode_item.h" |
| 45 | #include "xfs_rw.h" | 45 | #include "xfs_rw.h" |
| 46 | #include "xfs_quota.h" | 46 | #include "xfs_quota.h" |
| 47 | #include "xfs_trace.h" | ||
| 47 | 48 | ||
| 48 | #include <linux/kthread.h> | 49 | #include <linux/kthread.h> |
| 49 | #include <linux/freezer.h> | 50 | #include <linux/freezer.h> |
| @@ -663,10 +664,9 @@ xfs_syncd_stop( | |||
| 663 | kthread_stop(mp->m_sync_task); | 664 | kthread_stop(mp->m_sync_task); |
| 664 | } | 665 | } |
| 665 | 666 | ||
| 666 | int | 667 | STATIC int |
| 667 | xfs_reclaim_inode( | 668 | xfs_reclaim_inode( |
| 668 | xfs_inode_t *ip, | 669 | xfs_inode_t *ip, |
| 669 | int locked, | ||
| 670 | int sync_mode) | 670 | int sync_mode) |
| 671 | { | 671 | { |
| 672 | xfs_perag_t *pag = xfs_get_perag(ip->i_mount, ip->i_ino); | 672 | xfs_perag_t *pag = xfs_get_perag(ip->i_mount, ip->i_ino); |
| @@ -682,10 +682,6 @@ xfs_reclaim_inode( | |||
| 682 | !__xfs_iflags_test(ip, XFS_IRECLAIMABLE)) { | 682 | !__xfs_iflags_test(ip, XFS_IRECLAIMABLE)) { |
| 683 | spin_unlock(&ip->i_flags_lock); | 683 | spin_unlock(&ip->i_flags_lock); |
| 684 | write_unlock(&pag->pag_ici_lock); | 684 | write_unlock(&pag->pag_ici_lock); |
| 685 | if (locked) { | ||
| 686 | xfs_ifunlock(ip); | ||
| 687 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
| 688 | } | ||
| 689 | return -EAGAIN; | 685 | return -EAGAIN; |
| 690 | } | 686 | } |
| 691 | __xfs_iflags_set(ip, XFS_IRECLAIM); | 687 | __xfs_iflags_set(ip, XFS_IRECLAIM); |
| @@ -704,10 +700,8 @@ xfs_reclaim_inode( | |||
| 704 | * We get the flush lock regardless, though, just to make sure | 700 | * We get the flush lock regardless, though, just to make sure |
| 705 | * we don't free it while it is being flushed. | 701 | * we don't free it while it is being flushed. |
| 706 | */ | 702 | */ |
| 707 | if (!locked) { | 703 | xfs_ilock(ip, XFS_ILOCK_EXCL); |
| 708 | xfs_ilock(ip, XFS_ILOCK_EXCL); | 704 | xfs_iflock(ip); |
| 709 | xfs_iflock(ip); | ||
| 710 | } | ||
| 711 | 705 | ||
| 712 | /* | 706 | /* |
| 713 | * In the case of a forced shutdown we rely on xfs_iflush() to | 707 | * In the case of a forced shutdown we rely on xfs_iflush() to |
| @@ -778,7 +772,7 @@ xfs_reclaim_inode_now( | |||
| 778 | } | 772 | } |
| 779 | read_unlock(&pag->pag_ici_lock); | 773 | read_unlock(&pag->pag_ici_lock); |
| 780 | 774 | ||
| 781 | return xfs_reclaim_inode(ip, 0, flags); | 775 | return xfs_reclaim_inode(ip, flags); |
| 782 | } | 776 | } |
| 783 | 777 | ||
| 784 | int | 778 | int |
diff --git a/fs/xfs/linux-2.6/xfs_sync.h b/fs/xfs/linux-2.6/xfs_sync.h index 27920eb7a820..a500b4d91835 100644 --- a/fs/xfs/linux-2.6/xfs_sync.h +++ b/fs/xfs/linux-2.6/xfs_sync.h | |||
| @@ -44,7 +44,6 @@ void xfs_quiesce_attr(struct xfs_mount *mp); | |||
| 44 | 44 | ||
| 45 | void xfs_flush_inodes(struct xfs_inode *ip); | 45 | void xfs_flush_inodes(struct xfs_inode *ip); |
| 46 | 46 | ||
| 47 | int xfs_reclaim_inode(struct xfs_inode *ip, int locked, int sync_mode); | ||
| 48 | int xfs_reclaim_inodes(struct xfs_mount *mp, int mode); | 47 | int xfs_reclaim_inodes(struct xfs_mount *mp, int mode); |
| 49 | 48 | ||
| 50 | void xfs_inode_set_reclaim_tag(struct xfs_inode *ip); | 49 | void xfs_inode_set_reclaim_tag(struct xfs_inode *ip); |
diff --git a/fs/xfs/linux-2.6/xfs_sysctl.c b/fs/xfs/linux-2.6/xfs_sysctl.c index c5bc67c4e3bb..7bb5092d6ae4 100644 --- a/fs/xfs/linux-2.6/xfs_sysctl.c +++ b/fs/xfs/linux-2.6/xfs_sysctl.c | |||
| @@ -55,170 +55,140 @@ xfs_stats_clear_proc_handler( | |||
| 55 | 55 | ||
| 56 | static ctl_table xfs_table[] = { | 56 | static ctl_table xfs_table[] = { |
| 57 | { | 57 | { |
| 58 | .ctl_name = XFS_SGID_INHERIT, | ||
| 59 | .procname = "irix_sgid_inherit", | 58 | .procname = "irix_sgid_inherit", |
| 60 | .data = &xfs_params.sgid_inherit.val, | 59 | .data = &xfs_params.sgid_inherit.val, |
| 61 | .maxlen = sizeof(int), | 60 | .maxlen = sizeof(int), |
| 62 | .mode = 0644, | 61 | .mode = 0644, |
| 63 | .proc_handler = &proc_dointvec_minmax, | 62 | .proc_handler = proc_dointvec_minmax, |
| 64 | .strategy = &sysctl_intvec, | ||
| 65 | .extra1 = &xfs_params.sgid_inherit.min, | 63 | .extra1 = &xfs_params.sgid_inherit.min, |
| 66 | .extra2 = &xfs_params.sgid_inherit.max | 64 | .extra2 = &xfs_params.sgid_inherit.max |
| 67 | }, | 65 | }, |
| 68 | { | 66 | { |
| 69 | .ctl_name = XFS_SYMLINK_MODE, | ||
| 70 | .procname = "irix_symlink_mode", | 67 | .procname = "irix_symlink_mode", |
| 71 | .data = &xfs_params.symlink_mode.val, | 68 | .data = &xfs_params.symlink_mode.val, |
| 72 | .maxlen = sizeof(int), | 69 | .maxlen = sizeof(int), |
| 73 | .mode = 0644, | 70 | .mode = 0644, |
| 74 | .proc_handler = &proc_dointvec_minmax, | 71 | .proc_handler = proc_dointvec_minmax, |
| 75 | .strategy = &sysctl_intvec, | ||
| 76 | .extra1 = &xfs_params.symlink_mode.min, | 72 | .extra1 = &xfs_params.symlink_mode.min, |
| 77 | .extra2 = &xfs_params.symlink_mode.max | 73 | .extra2 = &xfs_params.symlink_mode.max |
| 78 | }, | 74 | }, |
| 79 | { | 75 | { |
| 80 | .ctl_name = XFS_PANIC_MASK, | ||
| 81 | .procname = "panic_mask", | 76 | .procname = "panic_mask", |
| 82 | .data = &xfs_params.panic_mask.val, | 77 | .data = &xfs_params.panic_mask.val, |
| 83 | .maxlen = sizeof(int), | 78 | .maxlen = sizeof(int), |
| 84 | .mode = 0644, | 79 | .mode = 0644, |
| 85 | .proc_handler = &proc_dointvec_minmax, | 80 | .proc_handler = proc_dointvec_minmax, |
| 86 | .strategy = &sysctl_intvec, | ||
| 87 | .extra1 = &xfs_params.panic_mask.min, | 81 | .extra1 = &xfs_params.panic_mask.min, |
| 88 | .extra2 = &xfs_params.panic_mask.max | 82 | .extra2 = &xfs_params.panic_mask.max |
| 89 | }, | 83 | }, |
| 90 | 84 | ||
| 91 | { | 85 | { |
| 92 | .ctl_name = XFS_ERRLEVEL, | ||
| 93 | .procname = "error_level", | 86 | .procname = "error_level", |
| 94 | .data = &xfs_params.error_level.val, | 87 | .data = &xfs_params.error_level.val, |
| 95 | .maxlen = sizeof(int), | 88 | .maxlen = sizeof(int), |
| 96 | .mode = 0644, | 89 | .mode = 0644, |
| 97 | .proc_handler = &proc_dointvec_minmax, | 90 | .proc_handler = proc_dointvec_minmax, |
| 98 | .strategy = &sysctl_intvec, | ||
| 99 | .extra1 = &xfs_params.error_level.min, | 91 | .extra1 = &xfs_params.error_level.min, |
| 100 | .extra2 = &xfs_params.error_level.max | 92 | .extra2 = &xfs_params.error_level.max |
| 101 | }, | 93 | }, |
| 102 | { | 94 | { |
| 103 | .ctl_name = XFS_SYNCD_TIMER, | ||
| 104 | .procname = "xfssyncd_centisecs", | 95 | .procname = "xfssyncd_centisecs", |
| 105 | .data = &xfs_params.syncd_timer.val, | 96 | .data = &xfs_params.syncd_timer.val, |
| 106 | .maxlen = sizeof(int), | 97 | .maxlen = sizeof(int), |
| 107 | .mode = 0644, | 98 | .mode = 0644, |
| 108 | .proc_handler = &proc_dointvec_minmax, | 99 | .proc_handler = proc_dointvec_minmax, |
| 109 | .strategy = &sysctl_intvec, | ||
| 110 | .extra1 = &xfs_params.syncd_timer.min, | 100 | .extra1 = &xfs_params.syncd_timer.min, |
| 111 | .extra2 = &xfs_params.syncd_timer.max | 101 | .extra2 = &xfs_params.syncd_timer.max |
| 112 | }, | 102 | }, |
| 113 | { | 103 | { |
| 114 | .ctl_name = XFS_INHERIT_SYNC, | ||
| 115 | .procname = "inherit_sync", | 104 | .procname = "inherit_sync", |
| 116 | .data = &xfs_params.inherit_sync.val, | 105 | .data = &xfs_params.inherit_sync.val, |
| 117 | .maxlen = sizeof(int), | 106 | .maxlen = sizeof(int), |
| 118 | .mode = 0644, | 107 | .mode = 0644, |
| 119 | .proc_handler = &proc_dointvec_minmax, | 108 | .proc_handler = proc_dointvec_minmax, |
| 120 | .strategy = &sysctl_intvec, | ||
| 121 | .extra1 = &xfs_params.inherit_sync.min, | 109 | .extra1 = &xfs_params.inherit_sync.min, |
| 122 | .extra2 = &xfs_params.inherit_sync.max | 110 | .extra2 = &xfs_params.inherit_sync.max |
| 123 | }, | 111 | }, |
| 124 | { | 112 | { |
| 125 | .ctl_name = XFS_INHERIT_NODUMP, | ||
| 126 | .procname = "inherit_nodump", | 113 | .procname = "inherit_nodump", |
| 127 | .data = &xfs_params.inherit_nodump.val, | 114 | .data = &xfs_params.inherit_nodump.val, |
| 128 | .maxlen = sizeof(int), | 115 | .maxlen = sizeof(int), |
| 129 | .mode = 0644, | 116 | .mode = 0644, |
| 130 | .proc_handler = &proc_dointvec_minmax, | 117 | .proc_handler = proc_dointvec_minmax, |
| 131 | .strategy = &sysctl_intvec, | ||
| 132 | .extra1 = &xfs_params.inherit_nodump.min, | 118 | .extra1 = &xfs_params.inherit_nodump.min, |
| 133 | .extra2 = &xfs_params.inherit_nodump.max | 119 | .extra2 = &xfs_params.inherit_nodump.max |
| 134 | }, | 120 | }, |
| 135 | { | 121 | { |
| 136 | .ctl_name = XFS_INHERIT_NOATIME, | ||
| 137 | .procname = "inherit_noatime", | 122 | .procname = "inherit_noatime", |
| 138 | .data = &xfs_params.inherit_noatim.val, | 123 | .data = &xfs_params.inherit_noatim.val, |
| 139 | .maxlen = sizeof(int), | 124 | .maxlen = sizeof(int), |
| 140 | .mode = 0644, | 125 | .mode = 0644, |
| 141 | .proc_handler = &proc_dointvec_minmax, | 126 | .proc_handler = proc_dointvec_minmax, |
| 142 | .strategy = &sysctl_intvec, | ||
| 143 | .extra1 = &xfs_params.inherit_noatim.min, | 127 | .extra1 = &xfs_params.inherit_noatim.min, |
| 144 | .extra2 = &xfs_params.inherit_noatim.max | 128 | .extra2 = &xfs_params.inherit_noatim.max |
| 145 | }, | 129 | }, |
| 146 | { | 130 | { |
| 147 | .ctl_name = XFS_BUF_TIMER, | ||
| 148 | .procname = "xfsbufd_centisecs", | 131 | .procname = "xfsbufd_centisecs", |
| 149 | .data = &xfs_params.xfs_buf_timer.val, | 132 | .data = &xfs_params.xfs_buf_timer.val, |
| 150 | .maxlen = sizeof(int), | 133 | .maxlen = sizeof(int), |
| 151 | .mode = 0644, | 134 | .mode = 0644, |
| 152 | .proc_handler = &proc_dointvec_minmax, | 135 | .proc_handler = proc_dointvec_minmax, |
| 153 | .strategy = &sysctl_intvec, | ||
| 154 | .extra1 = &xfs_params.xfs_buf_timer.min, | 136 | .extra1 = &xfs_params.xfs_buf_timer.min, |
| 155 | .extra2 = &xfs_params.xfs_buf_timer.max | 137 | .extra2 = &xfs_params.xfs_buf_timer.max |
| 156 | }, | 138 | }, |
| 157 | { | 139 | { |
| 158 | .ctl_name = XFS_BUF_AGE, | ||
| 159 | .procname = "age_buffer_centisecs", | 140 | .procname = "age_buffer_centisecs", |
| 160 | .data = &xfs_params.xfs_buf_age.val, | 141 | .data = &xfs_params.xfs_buf_age.val, |
| 161 | .maxlen = sizeof(int), | 142 | .maxlen = sizeof(int), |
| 162 | .mode = 0644, | 143 | .mode = 0644, |
| 163 | .proc_handler = &proc_dointvec_minmax, | 144 | .proc_handler = proc_dointvec_minmax, |
| 164 | .strategy = &sysctl_intvec, | ||
| 165 | .extra1 = &xfs_params.xfs_buf_age.min, | 145 | .extra1 = &xfs_params.xfs_buf_age.min, |
| 166 | .extra2 = &xfs_params.xfs_buf_age.max | 146 | .extra2 = &xfs_params.xfs_buf_age.max |
| 167 | }, | 147 | }, |
| 168 | { | 148 | { |
| 169 | .ctl_name = XFS_INHERIT_NOSYM, | ||
| 170 | .procname = "inherit_nosymlinks", | 149 | .procname = "inherit_nosymlinks", |
| 171 | .data = &xfs_params.inherit_nosym.val, | 150 | .data = &xfs_params.inherit_nosym.val, |
| 172 | .maxlen = sizeof(int), | 151 | .maxlen = sizeof(int), |
| 173 | .mode = 0644, | 152 | .mode = 0644, |
| 174 | .proc_handler = &proc_dointvec_minmax, | 153 | .proc_handler = proc_dointvec_minmax, |
| 175 | .strategy = &sysctl_intvec, | ||
| 176 | .extra1 = &xfs_params.inherit_nosym.min, | 154 | .extra1 = &xfs_params.inherit_nosym.min, |
| 177 | .extra2 = &xfs_params.inherit_nosym.max | 155 | .extra2 = &xfs_params.inherit_nosym.max |
| 178 | }, | 156 | }, |
| 179 | { | 157 | { |
| 180 | .ctl_name = XFS_ROTORSTEP, | ||
| 181 | .procname = "rotorstep", | 158 | .procname = "rotorstep", |
| 182 | .data = &xfs_params.rotorstep.val, | 159 | .data = &xfs_params.rotorstep.val, |
| 183 | .maxlen = sizeof(int), | 160 | .maxlen = sizeof(int), |
| 184 | .mode = 0644, | 161 | .mode = 0644, |
| 185 | .proc_handler = &proc_dointvec_minmax, | 162 | .proc_handler = proc_dointvec_minmax, |
| 186 | .strategy = &sysctl_intvec, | ||
| 187 | .extra1 = &xfs_params.rotorstep.min, | 163 | .extra1 = &xfs_params.rotorstep.min, |
| 188 | .extra2 = &xfs_params.rotorstep.max | 164 | .extra2 = &xfs_params.rotorstep.max |
| 189 | }, | 165 | }, |
| 190 | { | 166 | { |
| 191 | .ctl_name = XFS_INHERIT_NODFRG, | ||
| 192 | .procname = "inherit_nodefrag", | 167 | .procname = "inherit_nodefrag", |
| 193 | .data = &xfs_params.inherit_nodfrg.val, | 168 | .data = &xfs_params.inherit_nodfrg.val, |
| 194 | .maxlen = sizeof(int), | 169 | .maxlen = sizeof(int), |
| 195 | .mode = 0644, | 170 | .mode = 0644, |
| 196 | .proc_handler = &proc_dointvec_minmax, | 171 | .proc_handler = proc_dointvec_minmax, |
| 197 | .strategy = &sysctl_intvec, | ||
| 198 | .extra1 = &xfs_params.inherit_nodfrg.min, | 172 | .extra1 = &xfs_params.inherit_nodfrg.min, |
| 199 | .extra2 = &xfs_params.inherit_nodfrg.max | 173 | .extra2 = &xfs_params.inherit_nodfrg.max |
| 200 | }, | 174 | }, |
| 201 | { | 175 | { |
| 202 | .ctl_name = XFS_FILESTREAM_TIMER, | ||
| 203 | .procname = "filestream_centisecs", | 176 | .procname = "filestream_centisecs", |
| 204 | .data = &xfs_params.fstrm_timer.val, | 177 | .data = &xfs_params.fstrm_timer.val, |
| 205 | .maxlen = sizeof(int), | 178 | .maxlen = sizeof(int), |
| 206 | .mode = 0644, | 179 | .mode = 0644, |
| 207 | .proc_handler = &proc_dointvec_minmax, | 180 | .proc_handler = proc_dointvec_minmax, |
| 208 | .strategy = &sysctl_intvec, | ||
| 209 | .extra1 = &xfs_params.fstrm_timer.min, | 181 | .extra1 = &xfs_params.fstrm_timer.min, |
| 210 | .extra2 = &xfs_params.fstrm_timer.max, | 182 | .extra2 = &xfs_params.fstrm_timer.max, |
| 211 | }, | 183 | }, |
| 212 | /* please keep this the last entry */ | 184 | /* please keep this the last entry */ |
| 213 | #ifdef CONFIG_PROC_FS | 185 | #ifdef CONFIG_PROC_FS |
| 214 | { | 186 | { |
| 215 | .ctl_name = XFS_STATS_CLEAR, | ||
| 216 | .procname = "stats_clear", | 187 | .procname = "stats_clear", |
| 217 | .data = &xfs_params.stats_clear.val, | 188 | .data = &xfs_params.stats_clear.val, |
| 218 | .maxlen = sizeof(int), | 189 | .maxlen = sizeof(int), |
| 219 | .mode = 0644, | 190 | .mode = 0644, |
| 220 | .proc_handler = &xfs_stats_clear_proc_handler, | 191 | .proc_handler = xfs_stats_clear_proc_handler, |
| 221 | .strategy = &sysctl_intvec, | ||
| 222 | .extra1 = &xfs_params.stats_clear.min, | 192 | .extra1 = &xfs_params.stats_clear.min, |
| 223 | .extra2 = &xfs_params.stats_clear.max | 193 | .extra2 = &xfs_params.stats_clear.max |
| 224 | }, | 194 | }, |
| @@ -229,7 +199,6 @@ static ctl_table xfs_table[] = { | |||
| 229 | 199 | ||
| 230 | static ctl_table xfs_dir_table[] = { | 200 | static ctl_table xfs_dir_table[] = { |
| 231 | { | 201 | { |
| 232 | .ctl_name = FS_XFS, | ||
| 233 | .procname = "xfs", | 202 | .procname = "xfs", |
| 234 | .mode = 0555, | 203 | .mode = 0555, |
| 235 | .child = xfs_table | 204 | .child = xfs_table |
| @@ -239,7 +208,6 @@ static ctl_table xfs_dir_table[] = { | |||
| 239 | 208 | ||
| 240 | static ctl_table xfs_root_table[] = { | 209 | static ctl_table xfs_root_table[] = { |
| 241 | { | 210 | { |
| 242 | .ctl_name = CTL_FS, | ||
| 243 | .procname = "fs", | 211 | .procname = "fs", |
| 244 | .mode = 0555, | 212 | .mode = 0555, |
| 245 | .child = xfs_dir_table | 213 | .child = xfs_dir_table |
diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c new file mode 100644 index 000000000000..856eb3c8d605 --- /dev/null +++ b/fs/xfs/linux-2.6/xfs_trace.c | |||
| @@ -0,0 +1,75 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2009, Christoph Hellwig | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #include "xfs.h" | ||
| 19 | #include "xfs_fs.h" | ||
| 20 | #include "xfs_types.h" | ||
| 21 | #include "xfs_bit.h" | ||
| 22 | #include "xfs_log.h" | ||
| 23 | #include "xfs_inum.h" | ||
| 24 | #include "xfs_trans.h" | ||
| 25 | #include "xfs_sb.h" | ||
| 26 | #include "xfs_ag.h" | ||
| 27 | #include "xfs_dir2.h" | ||
| 28 | #include "xfs_da_btree.h" | ||
| 29 | #include "xfs_bmap_btree.h" | ||
| 30 | #include "xfs_alloc_btree.h" | ||
| 31 | #include "xfs_ialloc_btree.h" | ||
| 32 | #include "xfs_dir2_sf.h" | ||
| 33 | #include "xfs_attr_sf.h" | ||
| 34 | #include "xfs_dinode.h" | ||
| 35 | #include "xfs_inode.h" | ||
| 36 | #include "xfs_btree.h" | ||
| 37 | #include "xfs_dmapi.h" | ||
| 38 | #include "xfs_mount.h" | ||
| 39 | #include "xfs_ialloc.h" | ||
| 40 | #include "xfs_itable.h" | ||
| 41 | #include "xfs_alloc.h" | ||
| 42 | #include "xfs_bmap.h" | ||
| 43 | #include "xfs_attr.h" | ||
| 44 | #include "xfs_attr_sf.h" | ||
| 45 | #include "xfs_attr_leaf.h" | ||
| 46 | #include "xfs_log_priv.h" | ||
| 47 | #include "xfs_buf_item.h" | ||
| 48 | #include "xfs_quota.h" | ||
| 49 | #include "xfs_iomap.h" | ||
| 50 | #include "xfs_aops.h" | ||
| 51 | #include "quota/xfs_dquot_item.h" | ||
| 52 | #include "quota/xfs_dquot.h" | ||
| 53 | |||
| 54 | /* | ||
| 55 | * Format fsblock number into a static buffer & return it. | ||
| 56 | */ | ||
| 57 | STATIC char *xfs_fmtfsblock(xfs_fsblock_t bno) | ||
| 58 | { | ||
| 59 | static char rval[50]; | ||
| 60 | |||
| 61 | if (bno == NULLFSBLOCK) | ||
| 62 | sprintf(rval, "NULLFSBLOCK"); | ||
| 63 | else if (isnullstartblock(bno)) | ||
| 64 | sprintf(rval, "NULLSTARTBLOCK(%lld)", startblockval(bno)); | ||
| 65 | else | ||
| 66 | sprintf(rval, "%lld", (xfs_dfsbno_t)bno); | ||
| 67 | return rval; | ||
| 68 | } | ||
| 69 | |||
| 70 | /* | ||
| 71 | * We include this last to have the helpers above available for the trace | ||
| 72 | * event implementations. | ||
| 73 | */ | ||
| 74 | #define CREATE_TRACE_POINTS | ||
| 75 | #include "xfs_trace.h" | ||
diff --git a/fs/xfs/linux-2.6/xfs_trace.h b/fs/xfs/linux-2.6/xfs_trace.h new file mode 100644 index 000000000000..c40834bdee58 --- /dev/null +++ b/fs/xfs/linux-2.6/xfs_trace.h | |||
| @@ -0,0 +1,1369 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2009, Christoph Hellwig | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #undef TRACE_SYSTEM | ||
| 19 | #define TRACE_SYSTEM xfs | ||
| 20 | |||
| 21 | #if !defined(_TRACE_XFS_H) || defined(TRACE_HEADER_MULTI_READ) | ||
| 22 | #define _TRACE_XFS_H | ||
| 23 | |||
| 24 | #include <linux/tracepoint.h> | ||
| 25 | |||
| 26 | struct xfs_agf; | ||
| 27 | struct xfs_alloc_arg; | ||
| 28 | struct xfs_attr_list_context; | ||
| 29 | struct xfs_buf_log_item; | ||
| 30 | struct xfs_da_args; | ||
| 31 | struct xfs_da_node_entry; | ||
| 32 | struct xfs_dquot; | ||
| 33 | struct xlog_ticket; | ||
| 34 | struct log; | ||
| 35 | |||
| 36 | #define DEFINE_ATTR_LIST_EVENT(name) \ | ||
| 37 | TRACE_EVENT(name, \ | ||
| 38 | TP_PROTO(struct xfs_attr_list_context *ctx), \ | ||
| 39 | TP_ARGS(ctx), \ | ||
| 40 | TP_STRUCT__entry( \ | ||
| 41 | __field(dev_t, dev) \ | ||
| 42 | __field(xfs_ino_t, ino) \ | ||
| 43 | __field(u32, hashval) \ | ||
| 44 | __field(u32, blkno) \ | ||
| 45 | __field(u32, offset) \ | ||
| 46 | __field(void *, alist) \ | ||
| 47 | __field(int, bufsize) \ | ||
| 48 | __field(int, count) \ | ||
| 49 | __field(int, firstu) \ | ||
| 50 | __field(int, dupcnt) \ | ||
| 51 | __field(int, flags) \ | ||
| 52 | ), \ | ||
| 53 | TP_fast_assign( \ | ||
| 54 | __entry->dev = VFS_I(ctx->dp)->i_sb->s_dev; \ | ||
| 55 | __entry->ino = ctx->dp->i_ino; \ | ||
| 56 | __entry->hashval = ctx->cursor->hashval; \ | ||
| 57 | __entry->blkno = ctx->cursor->blkno; \ | ||
| 58 | __entry->offset = ctx->cursor->offset; \ | ||
| 59 | __entry->alist = ctx->alist; \ | ||
| 60 | __entry->bufsize = ctx->bufsize; \ | ||
| 61 | __entry->count = ctx->count; \ | ||
| 62 | __entry->firstu = ctx->firstu; \ | ||
| 63 | __entry->flags = ctx->flags; \ | ||
| 64 | ), \ | ||
| 65 | TP_printk("dev %d:%d ino 0x%llx cursor h/b/o 0x%x/0x%x/%u dupcnt %u " \ | ||
| 66 | "alist 0x%p size %u count %u firstu %u flags %d %s", \ | ||
| 67 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 68 | __entry->ino, \ | ||
| 69 | __entry->hashval, \ | ||
| 70 | __entry->blkno, \ | ||
| 71 | __entry->offset, \ | ||
| 72 | __entry->dupcnt, \ | ||
| 73 | __entry->alist, \ | ||
| 74 | __entry->bufsize, \ | ||
| 75 | __entry->count, \ | ||
| 76 | __entry->firstu, \ | ||
| 77 | __entry->flags, \ | ||
| 78 | __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS) \ | ||
| 79 | ) \ | ||
| 80 | ) | ||
| 81 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_sf); | ||
| 82 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_sf_all); | ||
| 83 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_leaf); | ||
| 84 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_leaf_end); | ||
| 85 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_full); | ||
| 86 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_add); | ||
| 87 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_wrong_blk); | ||
| 88 | DEFINE_ATTR_LIST_EVENT(xfs_attr_list_notfound); | ||
| 89 | |||
| 90 | TRACE_EVENT(xfs_attr_list_node_descend, | ||
| 91 | TP_PROTO(struct xfs_attr_list_context *ctx, | ||
| 92 | struct xfs_da_node_entry *btree), | ||
| 93 | TP_ARGS(ctx, btree), | ||
| 94 | TP_STRUCT__entry( | ||
| 95 | __field(dev_t, dev) | ||
| 96 | __field(xfs_ino_t, ino) | ||
| 97 | __field(u32, hashval) | ||
| 98 | __field(u32, blkno) | ||
| 99 | __field(u32, offset) | ||
| 100 | __field(void *, alist) | ||
| 101 | __field(int, bufsize) | ||
| 102 | __field(int, count) | ||
| 103 | __field(int, firstu) | ||
| 104 | __field(int, dupcnt) | ||
| 105 | __field(int, flags) | ||
| 106 | __field(u32, bt_hashval) | ||
| 107 | __field(u32, bt_before) | ||
| 108 | ), | ||
| 109 | TP_fast_assign( | ||
| 110 | __entry->dev = VFS_I(ctx->dp)->i_sb->s_dev; | ||
| 111 | __entry->ino = ctx->dp->i_ino; | ||
| 112 | __entry->hashval = ctx->cursor->hashval; | ||
| 113 | __entry->blkno = ctx->cursor->blkno; | ||
| 114 | __entry->offset = ctx->cursor->offset; | ||
| 115 | __entry->alist = ctx->alist; | ||
| 116 | __entry->bufsize = ctx->bufsize; | ||
| 117 | __entry->count = ctx->count; | ||
| 118 | __entry->firstu = ctx->firstu; | ||
| 119 | __entry->flags = ctx->flags; | ||
| 120 | __entry->bt_hashval = be32_to_cpu(btree->hashval); | ||
| 121 | __entry->bt_before = be32_to_cpu(btree->before); | ||
| 122 | ), | ||
| 123 | TP_printk("dev %d:%d ino 0x%llx cursor h/b/o 0x%x/0x%x/%u dupcnt %u " | ||
| 124 | "alist 0x%p size %u count %u firstu %u flags %d %s " | ||
| 125 | "node hashval %u, node before %u", | ||
| 126 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 127 | __entry->ino, | ||
| 128 | __entry->hashval, | ||
| 129 | __entry->blkno, | ||
| 130 | __entry->offset, | ||
| 131 | __entry->dupcnt, | ||
| 132 | __entry->alist, | ||
| 133 | __entry->bufsize, | ||
| 134 | __entry->count, | ||
| 135 | __entry->firstu, | ||
| 136 | __entry->flags, | ||
| 137 | __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS), | ||
| 138 | __entry->bt_hashval, | ||
| 139 | __entry->bt_before) | ||
| 140 | ); | ||
| 141 | |||
| 142 | TRACE_EVENT(xfs_iext_insert, | ||
| 143 | TP_PROTO(struct xfs_inode *ip, xfs_extnum_t idx, | ||
| 144 | struct xfs_bmbt_irec *r, int state, unsigned long caller_ip), | ||
| 145 | TP_ARGS(ip, idx, r, state, caller_ip), | ||
| 146 | TP_STRUCT__entry( | ||
| 147 | __field(dev_t, dev) | ||
| 148 | __field(xfs_ino_t, ino) | ||
| 149 | __field(xfs_extnum_t, idx) | ||
| 150 | __field(xfs_fileoff_t, startoff) | ||
| 151 | __field(xfs_fsblock_t, startblock) | ||
| 152 | __field(xfs_filblks_t, blockcount) | ||
| 153 | __field(xfs_exntst_t, state) | ||
| 154 | __field(int, bmap_state) | ||
| 155 | __field(unsigned long, caller_ip) | ||
| 156 | ), | ||
| 157 | TP_fast_assign( | ||
| 158 | __entry->dev = VFS_I(ip)->i_sb->s_dev; | ||
| 159 | __entry->ino = ip->i_ino; | ||
| 160 | __entry->idx = idx; | ||
| 161 | __entry->startoff = r->br_startoff; | ||
| 162 | __entry->startblock = r->br_startblock; | ||
| 163 | __entry->blockcount = r->br_blockcount; | ||
| 164 | __entry->state = r->br_state; | ||
| 165 | __entry->bmap_state = state; | ||
| 166 | __entry->caller_ip = caller_ip; | ||
| 167 | ), | ||
| 168 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " | ||
| 169 | "offset %lld block %s count %lld flag %d caller %pf", | ||
| 170 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 171 | __entry->ino, | ||
| 172 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), | ||
| 173 | (long)__entry->idx, | ||
| 174 | __entry->startoff, | ||
| 175 | xfs_fmtfsblock(__entry->startblock), | ||
| 176 | __entry->blockcount, | ||
| 177 | __entry->state, | ||
| 178 | (char *)__entry->caller_ip) | ||
| 179 | ); | ||
| 180 | |||
| 181 | #define DEFINE_BMAP_EVENT(name) \ | ||
| 182 | TRACE_EVENT(name, \ | ||
| 183 | TP_PROTO(struct xfs_inode *ip, xfs_extnum_t idx, int state, \ | ||
| 184 | unsigned long caller_ip), \ | ||
| 185 | TP_ARGS(ip, idx, state, caller_ip), \ | ||
| 186 | TP_STRUCT__entry( \ | ||
| 187 | __field(dev_t, dev) \ | ||
| 188 | __field(xfs_ino_t, ino) \ | ||
| 189 | __field(xfs_extnum_t, idx) \ | ||
| 190 | __field(xfs_fileoff_t, startoff) \ | ||
| 191 | __field(xfs_fsblock_t, startblock) \ | ||
| 192 | __field(xfs_filblks_t, blockcount) \ | ||
| 193 | __field(xfs_exntst_t, state) \ | ||
| 194 | __field(int, bmap_state) \ | ||
| 195 | __field(unsigned long, caller_ip) \ | ||
| 196 | ), \ | ||
| 197 | TP_fast_assign( \ | ||
| 198 | struct xfs_ifork *ifp = (state & BMAP_ATTRFORK) ? \ | ||
| 199 | ip->i_afp : &ip->i_df; \ | ||
| 200 | struct xfs_bmbt_irec r; \ | ||
| 201 | \ | ||
| 202 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx), &r); \ | ||
| 203 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 204 | __entry->ino = ip->i_ino; \ | ||
| 205 | __entry->idx = idx; \ | ||
| 206 | __entry->startoff = r.br_startoff; \ | ||
| 207 | __entry->startblock = r.br_startblock; \ | ||
| 208 | __entry->blockcount = r.br_blockcount; \ | ||
| 209 | __entry->state = r.br_state; \ | ||
| 210 | __entry->bmap_state = state; \ | ||
| 211 | __entry->caller_ip = caller_ip; \ | ||
| 212 | ), \ | ||
| 213 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " \ | ||
| 214 | "offset %lld block %s count %lld flag %d caller %pf", \ | ||
| 215 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 216 | __entry->ino, \ | ||
| 217 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), \ | ||
| 218 | (long)__entry->idx, \ | ||
| 219 | __entry->startoff, \ | ||
| 220 | xfs_fmtfsblock(__entry->startblock), \ | ||
| 221 | __entry->blockcount, \ | ||
| 222 | __entry->state, \ | ||
| 223 | (char *)__entry->caller_ip) \ | ||
| 224 | ) | ||
| 225 | |||
| 226 | DEFINE_BMAP_EVENT(xfs_iext_remove); | ||
| 227 | DEFINE_BMAP_EVENT(xfs_bmap_pre_update); | ||
| 228 | DEFINE_BMAP_EVENT(xfs_bmap_post_update); | ||
| 229 | DEFINE_BMAP_EVENT(xfs_extlist); | ||
| 230 | |||
| 231 | #define DEFINE_BUF_EVENT(tname) \ | ||
| 232 | TRACE_EVENT(tname, \ | ||
| 233 | TP_PROTO(struct xfs_buf *bp, unsigned long caller_ip), \ | ||
| 234 | TP_ARGS(bp, caller_ip), \ | ||
| 235 | TP_STRUCT__entry( \ | ||
| 236 | __field(dev_t, dev) \ | ||
| 237 | __field(xfs_daddr_t, bno) \ | ||
| 238 | __field(size_t, buffer_length) \ | ||
| 239 | __field(int, hold) \ | ||
| 240 | __field(int, pincount) \ | ||
| 241 | __field(unsigned, lockval) \ | ||
| 242 | __field(unsigned, flags) \ | ||
| 243 | __field(unsigned long, caller_ip) \ | ||
| 244 | ), \ | ||
| 245 | TP_fast_assign( \ | ||
| 246 | __entry->dev = bp->b_target->bt_dev; \ | ||
| 247 | __entry->bno = bp->b_bn; \ | ||
| 248 | __entry->buffer_length = bp->b_buffer_length; \ | ||
| 249 | __entry->hold = atomic_read(&bp->b_hold); \ | ||
| 250 | __entry->pincount = atomic_read(&bp->b_pin_count); \ | ||
| 251 | __entry->lockval = xfs_buf_lock_value(bp); \ | ||
| 252 | __entry->flags = bp->b_flags; \ | ||
| 253 | __entry->caller_ip = caller_ip; \ | ||
| 254 | ), \ | ||
| 255 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " \ | ||
| 256 | "lock %d flags %s caller %pf", \ | ||
| 257 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 258 | (unsigned long long)__entry->bno, \ | ||
| 259 | __entry->buffer_length, \ | ||
| 260 | __entry->hold, \ | ||
| 261 | __entry->pincount, \ | ||
| 262 | __entry->lockval, \ | ||
| 263 | __print_flags(__entry->flags, "|", XFS_BUF_FLAGS), \ | ||
| 264 | (void *)__entry->caller_ip) \ | ||
| 265 | ) | ||
| 266 | DEFINE_BUF_EVENT(xfs_buf_init); | ||
| 267 | DEFINE_BUF_EVENT(xfs_buf_free); | ||
| 268 | DEFINE_BUF_EVENT(xfs_buf_hold); | ||
| 269 | DEFINE_BUF_EVENT(xfs_buf_rele); | ||
| 270 | DEFINE_BUF_EVENT(xfs_buf_pin); | ||
| 271 | DEFINE_BUF_EVENT(xfs_buf_unpin); | ||
| 272 | DEFINE_BUF_EVENT(xfs_buf_iodone); | ||
| 273 | DEFINE_BUF_EVENT(xfs_buf_iorequest); | ||
| 274 | DEFINE_BUF_EVENT(xfs_buf_bawrite); | ||
| 275 | DEFINE_BUF_EVENT(xfs_buf_bdwrite); | ||
| 276 | DEFINE_BUF_EVENT(xfs_buf_lock); | ||
| 277 | DEFINE_BUF_EVENT(xfs_buf_lock_done); | ||
| 278 | DEFINE_BUF_EVENT(xfs_buf_cond_lock); | ||
| 279 | DEFINE_BUF_EVENT(xfs_buf_unlock); | ||
| 280 | DEFINE_BUF_EVENT(xfs_buf_ordered_retry); | ||
| 281 | DEFINE_BUF_EVENT(xfs_buf_iowait); | ||
| 282 | DEFINE_BUF_EVENT(xfs_buf_iowait_done); | ||
| 283 | DEFINE_BUF_EVENT(xfs_buf_delwri_queue); | ||
| 284 | DEFINE_BUF_EVENT(xfs_buf_delwri_dequeue); | ||
| 285 | DEFINE_BUF_EVENT(xfs_buf_delwri_split); | ||
| 286 | DEFINE_BUF_EVENT(xfs_buf_get_noaddr); | ||
| 287 | DEFINE_BUF_EVENT(xfs_bdstrat_shut); | ||
| 288 | DEFINE_BUF_EVENT(xfs_buf_item_relse); | ||
| 289 | DEFINE_BUF_EVENT(xfs_buf_item_iodone); | ||
| 290 | DEFINE_BUF_EVENT(xfs_buf_item_iodone_async); | ||
| 291 | DEFINE_BUF_EVENT(xfs_buf_error_relse); | ||
| 292 | DEFINE_BUF_EVENT(xfs_trans_read_buf_io); | ||
| 293 | DEFINE_BUF_EVENT(xfs_trans_read_buf_shut); | ||
| 294 | |||
| 295 | /* not really buffer traces, but the buf provides useful information */ | ||
| 296 | DEFINE_BUF_EVENT(xfs_btree_corrupt); | ||
| 297 | DEFINE_BUF_EVENT(xfs_da_btree_corrupt); | ||
| 298 | DEFINE_BUF_EVENT(xfs_reset_dqcounts); | ||
| 299 | DEFINE_BUF_EVENT(xfs_inode_item_push); | ||
| 300 | |||
| 301 | /* pass flags explicitly */ | ||
| 302 | #define DEFINE_BUF_FLAGS_EVENT(tname) \ | ||
| 303 | TRACE_EVENT(tname, \ | ||
| 304 | TP_PROTO(struct xfs_buf *bp, unsigned flags, unsigned long caller_ip), \ | ||
| 305 | TP_ARGS(bp, flags, caller_ip), \ | ||
| 306 | TP_STRUCT__entry( \ | ||
| 307 | __field(dev_t, dev) \ | ||
| 308 | __field(xfs_daddr_t, bno) \ | ||
| 309 | __field(size_t, buffer_length) \ | ||
| 310 | __field(int, hold) \ | ||
| 311 | __field(int, pincount) \ | ||
| 312 | __field(unsigned, lockval) \ | ||
| 313 | __field(unsigned, flags) \ | ||
| 314 | __field(unsigned long, caller_ip) \ | ||
| 315 | ), \ | ||
| 316 | TP_fast_assign( \ | ||
| 317 | __entry->dev = bp->b_target->bt_dev; \ | ||
| 318 | __entry->bno = bp->b_bn; \ | ||
| 319 | __entry->buffer_length = bp->b_buffer_length; \ | ||
| 320 | __entry->flags = flags; \ | ||
| 321 | __entry->hold = atomic_read(&bp->b_hold); \ | ||
| 322 | __entry->pincount = atomic_read(&bp->b_pin_count); \ | ||
| 323 | __entry->lockval = xfs_buf_lock_value(bp); \ | ||
| 324 | __entry->caller_ip = caller_ip; \ | ||
| 325 | ), \ | ||
| 326 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " \ | ||
| 327 | "lock %d flags %s caller %pf", \ | ||
| 328 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 329 | (unsigned long long)__entry->bno, \ | ||
| 330 | __entry->buffer_length, \ | ||
| 331 | __entry->hold, \ | ||
| 332 | __entry->pincount, \ | ||
| 333 | __entry->lockval, \ | ||
| 334 | __print_flags(__entry->flags, "|", XFS_BUF_FLAGS), \ | ||
| 335 | (void *)__entry->caller_ip) \ | ||
| 336 | ) | ||
| 337 | DEFINE_BUF_FLAGS_EVENT(xfs_buf_find); | ||
| 338 | DEFINE_BUF_FLAGS_EVENT(xfs_buf_get); | ||
| 339 | DEFINE_BUF_FLAGS_EVENT(xfs_buf_read); | ||
| 340 | |||
| 341 | TRACE_EVENT(xfs_buf_ioerror, | ||
| 342 | TP_PROTO(struct xfs_buf *bp, int error, unsigned long caller_ip), | ||
| 343 | TP_ARGS(bp, error, caller_ip), | ||
| 344 | TP_STRUCT__entry( | ||
| 345 | __field(dev_t, dev) | ||
| 346 | __field(xfs_daddr_t, bno) | ||
| 347 | __field(size_t, buffer_length) | ||
| 348 | __field(unsigned, flags) | ||
| 349 | __field(int, hold) | ||
| 350 | __field(int, pincount) | ||
| 351 | __field(unsigned, lockval) | ||
| 352 | __field(int, error) | ||
| 353 | __field(unsigned long, caller_ip) | ||
| 354 | ), | ||
| 355 | TP_fast_assign( | ||
| 356 | __entry->dev = bp->b_target->bt_dev; | ||
| 357 | __entry->bno = bp->b_bn; | ||
| 358 | __entry->buffer_length = bp->b_buffer_length; | ||
| 359 | __entry->hold = atomic_read(&bp->b_hold); | ||
| 360 | __entry->pincount = atomic_read(&bp->b_pin_count); | ||
| 361 | __entry->lockval = xfs_buf_lock_value(bp); | ||
| 362 | __entry->error = error; | ||
| 363 | __entry->flags = bp->b_flags; | ||
| 364 | __entry->caller_ip = caller_ip; | ||
| 365 | ), | ||
| 366 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " | ||
| 367 | "lock %d error %d flags %s caller %pf", | ||
| 368 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 369 | (unsigned long long)__entry->bno, | ||
| 370 | __entry->buffer_length, | ||
| 371 | __entry->hold, | ||
| 372 | __entry->pincount, | ||
| 373 | __entry->lockval, | ||
| 374 | __entry->error, | ||
| 375 | __print_flags(__entry->flags, "|", XFS_BUF_FLAGS), | ||
| 376 | (void *)__entry->caller_ip) | ||
| 377 | ); | ||
| 378 | |||
| 379 | #define DEFINE_BUF_ITEM_EVENT(tname) \ | ||
| 380 | TRACE_EVENT(tname, \ | ||
| 381 | TP_PROTO(struct xfs_buf_log_item *bip), \ | ||
| 382 | TP_ARGS(bip), \ | ||
| 383 | TP_STRUCT__entry( \ | ||
| 384 | __field(dev_t, dev) \ | ||
| 385 | __field(xfs_daddr_t, buf_bno) \ | ||
| 386 | __field(size_t, buf_len) \ | ||
| 387 | __field(int, buf_hold) \ | ||
| 388 | __field(int, buf_pincount) \ | ||
| 389 | __field(int, buf_lockval) \ | ||
| 390 | __field(unsigned, buf_flags) \ | ||
| 391 | __field(unsigned, bli_recur) \ | ||
| 392 | __field(int, bli_refcount) \ | ||
| 393 | __field(unsigned, bli_flags) \ | ||
| 394 | __field(void *, li_desc) \ | ||
| 395 | __field(unsigned, li_flags) \ | ||
| 396 | ), \ | ||
| 397 | TP_fast_assign( \ | ||
| 398 | __entry->dev = bip->bli_buf->b_target->bt_dev; \ | ||
| 399 | __entry->bli_flags = bip->bli_flags; \ | ||
| 400 | __entry->bli_recur = bip->bli_recur; \ | ||
| 401 | __entry->bli_refcount = atomic_read(&bip->bli_refcount); \ | ||
| 402 | __entry->buf_bno = bip->bli_buf->b_bn; \ | ||
| 403 | __entry->buf_len = bip->bli_buf->b_buffer_length; \ | ||
| 404 | __entry->buf_flags = bip->bli_buf->b_flags; \ | ||
| 405 | __entry->buf_hold = atomic_read(&bip->bli_buf->b_hold); \ | ||
| 406 | __entry->buf_pincount = \ | ||
| 407 | atomic_read(&bip->bli_buf->b_pin_count); \ | ||
| 408 | __entry->buf_lockval = xfs_buf_lock_value(bip->bli_buf); \ | ||
| 409 | __entry->li_desc = bip->bli_item.li_desc; \ | ||
| 410 | __entry->li_flags = bip->bli_item.li_flags; \ | ||
| 411 | ), \ | ||
| 412 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " \ | ||
| 413 | "lock %d flags %s recur %d refcount %d bliflags %s " \ | ||
| 414 | "lidesc 0x%p liflags %s", \ | ||
| 415 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 416 | (unsigned long long)__entry->buf_bno, \ | ||
| 417 | __entry->buf_len, \ | ||
| 418 | __entry->buf_hold, \ | ||
| 419 | __entry->buf_pincount, \ | ||
| 420 | __entry->buf_lockval, \ | ||
| 421 | __print_flags(__entry->buf_flags, "|", XFS_BUF_FLAGS), \ | ||
| 422 | __entry->bli_recur, \ | ||
| 423 | __entry->bli_refcount, \ | ||
| 424 | __print_flags(__entry->bli_flags, "|", XFS_BLI_FLAGS), \ | ||
| 425 | __entry->li_desc, \ | ||
| 426 | __print_flags(__entry->li_flags, "|", XFS_LI_FLAGS)) \ | ||
| 427 | ) | ||
| 428 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_size); | ||
| 429 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_size_stale); | ||
| 430 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_format); | ||
| 431 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_format_stale); | ||
| 432 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_pin); | ||
| 433 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin); | ||
| 434 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unpin_stale); | ||
| 435 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_trylock); | ||
| 436 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unlock); | ||
| 437 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_unlock_stale); | ||
| 438 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_committed); | ||
| 439 | DEFINE_BUF_ITEM_EVENT(xfs_buf_item_push); | ||
| 440 | DEFINE_BUF_ITEM_EVENT(xfs_trans_get_buf); | ||
| 441 | DEFINE_BUF_ITEM_EVENT(xfs_trans_get_buf_recur); | ||
| 442 | DEFINE_BUF_ITEM_EVENT(xfs_trans_getsb); | ||
| 443 | DEFINE_BUF_ITEM_EVENT(xfs_trans_getsb_recur); | ||
| 444 | DEFINE_BUF_ITEM_EVENT(xfs_trans_read_buf); | ||
| 445 | DEFINE_BUF_ITEM_EVENT(xfs_trans_read_buf_recur); | ||
| 446 | DEFINE_BUF_ITEM_EVENT(xfs_trans_log_buf); | ||
| 447 | DEFINE_BUF_ITEM_EVENT(xfs_trans_brelse); | ||
| 448 | DEFINE_BUF_ITEM_EVENT(xfs_trans_bjoin); | ||
| 449 | DEFINE_BUF_ITEM_EVENT(xfs_trans_bhold); | ||
| 450 | DEFINE_BUF_ITEM_EVENT(xfs_trans_bhold_release); | ||
| 451 | DEFINE_BUF_ITEM_EVENT(xfs_trans_binval); | ||
| 452 | |||
| 453 | #define DEFINE_LOCK_EVENT(name) \ | ||
| 454 | TRACE_EVENT(name, \ | ||
| 455 | TP_PROTO(struct xfs_inode *ip, unsigned lock_flags, \ | ||
| 456 | unsigned long caller_ip), \ | ||
| 457 | TP_ARGS(ip, lock_flags, caller_ip), \ | ||
| 458 | TP_STRUCT__entry( \ | ||
| 459 | __field(dev_t, dev) \ | ||
| 460 | __field(xfs_ino_t, ino) \ | ||
| 461 | __field(int, lock_flags) \ | ||
| 462 | __field(unsigned long, caller_ip) \ | ||
| 463 | ), \ | ||
| 464 | TP_fast_assign( \ | ||
| 465 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 466 | __entry->ino = ip->i_ino; \ | ||
| 467 | __entry->lock_flags = lock_flags; \ | ||
| 468 | __entry->caller_ip = caller_ip; \ | ||
| 469 | ), \ | ||
| 470 | TP_printk("dev %d:%d ino 0x%llx flags %s caller %pf", \ | ||
| 471 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 472 | __entry->ino, \ | ||
| 473 | __print_flags(__entry->lock_flags, "|", XFS_LOCK_FLAGS), \ | ||
| 474 | (void *)__entry->caller_ip) \ | ||
| 475 | ) | ||
| 476 | |||
| 477 | DEFINE_LOCK_EVENT(xfs_ilock); | ||
| 478 | DEFINE_LOCK_EVENT(xfs_ilock_nowait); | ||
| 479 | DEFINE_LOCK_EVENT(xfs_ilock_demote); | ||
| 480 | DEFINE_LOCK_EVENT(xfs_iunlock); | ||
| 481 | |||
| 482 | #define DEFINE_IGET_EVENT(name) \ | ||
| 483 | TRACE_EVENT(name, \ | ||
| 484 | TP_PROTO(struct xfs_inode *ip), \ | ||
| 485 | TP_ARGS(ip), \ | ||
| 486 | TP_STRUCT__entry( \ | ||
| 487 | __field(dev_t, dev) \ | ||
| 488 | __field(xfs_ino_t, ino) \ | ||
| 489 | ), \ | ||
| 490 | TP_fast_assign( \ | ||
| 491 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 492 | __entry->ino = ip->i_ino; \ | ||
| 493 | ), \ | ||
| 494 | TP_printk("dev %d:%d ino 0x%llx", \ | ||
| 495 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 496 | __entry->ino) \ | ||
| 497 | ) | ||
| 498 | DEFINE_IGET_EVENT(xfs_iget_skip); | ||
| 499 | DEFINE_IGET_EVENT(xfs_iget_reclaim); | ||
| 500 | DEFINE_IGET_EVENT(xfs_iget_found); | ||
| 501 | DEFINE_IGET_EVENT(xfs_iget_alloc); | ||
| 502 | |||
| 503 | #define DEFINE_INODE_EVENT(name) \ | ||
| 504 | TRACE_EVENT(name, \ | ||
| 505 | TP_PROTO(struct xfs_inode *ip, unsigned long caller_ip), \ | ||
| 506 | TP_ARGS(ip, caller_ip), \ | ||
| 507 | TP_STRUCT__entry( \ | ||
| 508 | __field(dev_t, dev) \ | ||
| 509 | __field(xfs_ino_t, ino) \ | ||
| 510 | __field(int, count) \ | ||
| 511 | __field(unsigned long, caller_ip) \ | ||
| 512 | ), \ | ||
| 513 | TP_fast_assign( \ | ||
| 514 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 515 | __entry->ino = ip->i_ino; \ | ||
| 516 | __entry->count = atomic_read(&VFS_I(ip)->i_count); \ | ||
| 517 | __entry->caller_ip = caller_ip; \ | ||
| 518 | ), \ | ||
| 519 | TP_printk("dev %d:%d ino 0x%llx count %d caller %pf", \ | ||
| 520 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 521 | __entry->ino, \ | ||
| 522 | __entry->count, \ | ||
| 523 | (char *)__entry->caller_ip) \ | ||
| 524 | ) | ||
| 525 | DEFINE_INODE_EVENT(xfs_ihold); | ||
| 526 | DEFINE_INODE_EVENT(xfs_irele); | ||
| 527 | /* the old xfs_itrace_entry tracer - to be replaced by s.th. in the VFS */ | ||
| 528 | DEFINE_INODE_EVENT(xfs_inode); | ||
| 529 | #define xfs_itrace_entry(ip) \ | ||
| 530 | trace_xfs_inode(ip, _THIS_IP_) | ||
| 531 | |||
| 532 | #define DEFINE_DQUOT_EVENT(tname) \ | ||
| 533 | TRACE_EVENT(tname, \ | ||
| 534 | TP_PROTO(struct xfs_dquot *dqp), \ | ||
| 535 | TP_ARGS(dqp), \ | ||
| 536 | TP_STRUCT__entry( \ | ||
| 537 | __field(dev_t, dev) \ | ||
| 538 | __field(__be32, id) \ | ||
| 539 | __field(unsigned, flags) \ | ||
| 540 | __field(unsigned, nrefs) \ | ||
| 541 | __field(unsigned long long, res_bcount) \ | ||
| 542 | __field(unsigned long long, bcount) \ | ||
| 543 | __field(unsigned long long, icount) \ | ||
| 544 | __field(unsigned long long, blk_hardlimit) \ | ||
| 545 | __field(unsigned long long, blk_softlimit) \ | ||
| 546 | __field(unsigned long long, ino_hardlimit) \ | ||
| 547 | __field(unsigned long long, ino_softlimit) \ | ||
| 548 | ), \ | ||
| 549 | TP_fast_assign( \ | ||
| 550 | __entry->dev = dqp->q_mount->m_super->s_dev; \ | ||
| 551 | __entry->id = dqp->q_core.d_id; \ | ||
| 552 | __entry->flags = dqp->dq_flags; \ | ||
| 553 | __entry->nrefs = dqp->q_nrefs; \ | ||
| 554 | __entry->res_bcount = dqp->q_res_bcount; \ | ||
| 555 | __entry->bcount = be64_to_cpu(dqp->q_core.d_bcount); \ | ||
| 556 | __entry->icount = be64_to_cpu(dqp->q_core.d_icount); \ | ||
| 557 | __entry->blk_hardlimit = \ | ||
| 558 | be64_to_cpu(dqp->q_core.d_blk_hardlimit); \ | ||
| 559 | __entry->blk_softlimit = \ | ||
| 560 | be64_to_cpu(dqp->q_core.d_blk_softlimit); \ | ||
| 561 | __entry->ino_hardlimit = \ | ||
| 562 | be64_to_cpu(dqp->q_core.d_ino_hardlimit); \ | ||
| 563 | __entry->ino_softlimit = \ | ||
| 564 | be64_to_cpu(dqp->q_core.d_ino_softlimit); \ | ||
| 565 | ), \ | ||
| 566 | TP_printk("dev %d:%d id 0x%x flags %s nrefs %u res_bc 0x%llx " \ | ||
| 567 | "bcnt 0x%llx [hard 0x%llx | soft 0x%llx] " \ | ||
| 568 | "icnt 0x%llx [hard 0x%llx | soft 0x%llx]", \ | ||
| 569 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 570 | be32_to_cpu(__entry->id), \ | ||
| 571 | __print_flags(__entry->flags, "|", XFS_DQ_FLAGS), \ | ||
| 572 | __entry->nrefs, \ | ||
| 573 | __entry->res_bcount, \ | ||
| 574 | __entry->bcount, \ | ||
| 575 | __entry->blk_hardlimit, \ | ||
| 576 | __entry->blk_softlimit, \ | ||
| 577 | __entry->icount, \ | ||
| 578 | __entry->ino_hardlimit, \ | ||
| 579 | __entry->ino_softlimit) \ | ||
| 580 | ) | ||
| 581 | DEFINE_DQUOT_EVENT(xfs_dqadjust); | ||
| 582 | DEFINE_DQUOT_EVENT(xfs_dqshake_dirty); | ||
| 583 | DEFINE_DQUOT_EVENT(xfs_dqshake_unlink); | ||
| 584 | DEFINE_DQUOT_EVENT(xfs_dqreclaim_want); | ||
| 585 | DEFINE_DQUOT_EVENT(xfs_dqreclaim_dirty); | ||
| 586 | DEFINE_DQUOT_EVENT(xfs_dqreclaim_unlink); | ||
| 587 | DEFINE_DQUOT_EVENT(xfs_dqattach_found); | ||
| 588 | DEFINE_DQUOT_EVENT(xfs_dqattach_get); | ||
| 589 | DEFINE_DQUOT_EVENT(xfs_dqinit); | ||
| 590 | DEFINE_DQUOT_EVENT(xfs_dqreuse); | ||
| 591 | DEFINE_DQUOT_EVENT(xfs_dqalloc); | ||
| 592 | DEFINE_DQUOT_EVENT(xfs_dqtobp_read); | ||
| 593 | DEFINE_DQUOT_EVENT(xfs_dqread); | ||
| 594 | DEFINE_DQUOT_EVENT(xfs_dqread_fail); | ||
| 595 | DEFINE_DQUOT_EVENT(xfs_dqlookup_found); | ||
| 596 | DEFINE_DQUOT_EVENT(xfs_dqlookup_want); | ||
| 597 | DEFINE_DQUOT_EVENT(xfs_dqlookup_freelist); | ||
| 598 | DEFINE_DQUOT_EVENT(xfs_dqlookup_move); | ||
| 599 | DEFINE_DQUOT_EVENT(xfs_dqlookup_done); | ||
| 600 | DEFINE_DQUOT_EVENT(xfs_dqget_hit); | ||
| 601 | DEFINE_DQUOT_EVENT(xfs_dqget_miss); | ||
| 602 | DEFINE_DQUOT_EVENT(xfs_dqput); | ||
| 603 | DEFINE_DQUOT_EVENT(xfs_dqput_wait); | ||
| 604 | DEFINE_DQUOT_EVENT(xfs_dqput_free); | ||
| 605 | DEFINE_DQUOT_EVENT(xfs_dqrele); | ||
| 606 | DEFINE_DQUOT_EVENT(xfs_dqflush); | ||
| 607 | DEFINE_DQUOT_EVENT(xfs_dqflush_force); | ||
| 608 | DEFINE_DQUOT_EVENT(xfs_dqflush_done); | ||
| 609 | /* not really iget events, but we re-use the format */ | ||
| 610 | DEFINE_IGET_EVENT(xfs_dquot_dqalloc); | ||
| 611 | DEFINE_IGET_EVENT(xfs_dquot_dqdetach); | ||
| 612 | |||
| 613 | |||
| 614 | #define DEFINE_LOGGRANT_EVENT(tname) \ | ||
| 615 | TRACE_EVENT(tname, \ | ||
| 616 | TP_PROTO(struct log *log, struct xlog_ticket *tic), \ | ||
| 617 | TP_ARGS(log, tic), \ | ||
| 618 | TP_STRUCT__entry( \ | ||
| 619 | __field(dev_t, dev) \ | ||
| 620 | __field(unsigned, trans_type) \ | ||
| 621 | __field(char, ocnt) \ | ||
| 622 | __field(char, cnt) \ | ||
| 623 | __field(int, curr_res) \ | ||
| 624 | __field(int, unit_res) \ | ||
| 625 | __field(unsigned int, flags) \ | ||
| 626 | __field(void *, reserve_headq) \ | ||
| 627 | __field(void *, write_headq) \ | ||
| 628 | __field(int, grant_reserve_cycle) \ | ||
| 629 | __field(int, grant_reserve_bytes) \ | ||
| 630 | __field(int, grant_write_cycle) \ | ||
| 631 | __field(int, grant_write_bytes) \ | ||
| 632 | __field(int, curr_cycle) \ | ||
| 633 | __field(int, curr_block) \ | ||
| 634 | __field(xfs_lsn_t, tail_lsn) \ | ||
| 635 | ), \ | ||
| 636 | TP_fast_assign( \ | ||
| 637 | __entry->dev = log->l_mp->m_super->s_dev; \ | ||
| 638 | __entry->trans_type = tic->t_trans_type; \ | ||
| 639 | __entry->ocnt = tic->t_ocnt; \ | ||
| 640 | __entry->cnt = tic->t_cnt; \ | ||
| 641 | __entry->curr_res = tic->t_curr_res; \ | ||
| 642 | __entry->unit_res = tic->t_unit_res; \ | ||
| 643 | __entry->flags = tic->t_flags; \ | ||
| 644 | __entry->reserve_headq = log->l_reserve_headq; \ | ||
| 645 | __entry->write_headq = log->l_write_headq; \ | ||
| 646 | __entry->grant_reserve_cycle = log->l_grant_reserve_cycle; \ | ||
| 647 | __entry->grant_reserve_bytes = log->l_grant_reserve_bytes; \ | ||
| 648 | __entry->grant_write_cycle = log->l_grant_write_cycle; \ | ||
| 649 | __entry->grant_write_bytes = log->l_grant_write_bytes; \ | ||
| 650 | __entry->curr_cycle = log->l_curr_cycle; \ | ||
| 651 | __entry->curr_block = log->l_curr_block; \ | ||
| 652 | __entry->tail_lsn = log->l_tail_lsn; \ | ||
| 653 | ), \ | ||
| 654 | TP_printk("dev %d:%d type %s t_ocnt %u t_cnt %u t_curr_res %u " \ | ||
| 655 | "t_unit_res %u t_flags %s reserve_headq 0x%p " \ | ||
| 656 | "write_headq 0x%p grant_reserve_cycle %d " \ | ||
| 657 | "grant_reserve_bytes %d grant_write_cycle %d " \ | ||
| 658 | "grant_write_bytes %d curr_cycle %d curr_block %d " \ | ||
| 659 | "tail_cycle %d tail_block %d", \ | ||
| 660 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 661 | __print_symbolic(__entry->trans_type, XFS_TRANS_TYPES), \ | ||
| 662 | __entry->ocnt, \ | ||
| 663 | __entry->cnt, \ | ||
| 664 | __entry->curr_res, \ | ||
| 665 | __entry->unit_res, \ | ||
| 666 | __print_flags(__entry->flags, "|", XLOG_TIC_FLAGS), \ | ||
| 667 | __entry->reserve_headq, \ | ||
| 668 | __entry->write_headq, \ | ||
| 669 | __entry->grant_reserve_cycle, \ | ||
| 670 | __entry->grant_reserve_bytes, \ | ||
| 671 | __entry->grant_write_cycle, \ | ||
| 672 | __entry->grant_write_bytes, \ | ||
| 673 | __entry->curr_cycle, \ | ||
| 674 | __entry->curr_block, \ | ||
| 675 | CYCLE_LSN(__entry->tail_lsn), \ | ||
| 676 | BLOCK_LSN(__entry->tail_lsn) \ | ||
| 677 | ) \ | ||
| 678 | ) | ||
| 679 | DEFINE_LOGGRANT_EVENT(xfs_log_done_nonperm); | ||
| 680 | DEFINE_LOGGRANT_EVENT(xfs_log_done_perm); | ||
| 681 | DEFINE_LOGGRANT_EVENT(xfs_log_reserve); | ||
| 682 | DEFINE_LOGGRANT_EVENT(xfs_log_umount_write); | ||
| 683 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_enter); | ||
| 684 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_exit); | ||
| 685 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_error); | ||
| 686 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_sleep1); | ||
| 687 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake1); | ||
| 688 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_sleep2); | ||
| 689 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake2); | ||
| 690 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_enter); | ||
| 691 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_exit); | ||
| 692 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_error); | ||
| 693 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_sleep1); | ||
| 694 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake1); | ||
| 695 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_sleep2); | ||
| 696 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake2); | ||
| 697 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_enter); | ||
| 698 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_exit); | ||
| 699 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_sub); | ||
| 700 | DEFINE_LOGGRANT_EVENT(xfs_log_ungrant_enter); | ||
| 701 | DEFINE_LOGGRANT_EVENT(xfs_log_ungrant_exit); | ||
| 702 | DEFINE_LOGGRANT_EVENT(xfs_log_ungrant_sub); | ||
| 703 | |||
| 704 | #define DEFINE_RW_EVENT(name) \ | ||
| 705 | TRACE_EVENT(name, \ | ||
| 706 | TP_PROTO(struct xfs_inode *ip, size_t count, loff_t offset, int flags), \ | ||
| 707 | TP_ARGS(ip, count, offset, flags), \ | ||
| 708 | TP_STRUCT__entry( \ | ||
| 709 | __field(dev_t, dev) \ | ||
| 710 | __field(xfs_ino_t, ino) \ | ||
| 711 | __field(xfs_fsize_t, size) \ | ||
| 712 | __field(xfs_fsize_t, new_size) \ | ||
| 713 | __field(loff_t, offset) \ | ||
| 714 | __field(size_t, count) \ | ||
| 715 | __field(int, flags) \ | ||
| 716 | ), \ | ||
| 717 | TP_fast_assign( \ | ||
| 718 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 719 | __entry->ino = ip->i_ino; \ | ||
| 720 | __entry->size = ip->i_d.di_size; \ | ||
| 721 | __entry->new_size = ip->i_new_size; \ | ||
| 722 | __entry->offset = offset; \ | ||
| 723 | __entry->count = count; \ | ||
| 724 | __entry->flags = flags; \ | ||
| 725 | ), \ | ||
| 726 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx " \ | ||
| 727 | "offset 0x%llx count 0x%zx ioflags %s", \ | ||
| 728 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 729 | __entry->ino, \ | ||
| 730 | __entry->size, \ | ||
| 731 | __entry->new_size, \ | ||
| 732 | __entry->offset, \ | ||
| 733 | __entry->count, \ | ||
| 734 | __print_flags(__entry->flags, "|", XFS_IO_FLAGS)) \ | ||
| 735 | ) | ||
| 736 | DEFINE_RW_EVENT(xfs_file_read); | ||
| 737 | DEFINE_RW_EVENT(xfs_file_buffered_write); | ||
| 738 | DEFINE_RW_EVENT(xfs_file_direct_write); | ||
| 739 | DEFINE_RW_EVENT(xfs_file_splice_read); | ||
| 740 | DEFINE_RW_EVENT(xfs_file_splice_write); | ||
| 741 | |||
| 742 | |||
| 743 | #define DEFINE_PAGE_EVENT(name) \ | ||
| 744 | TRACE_EVENT(name, \ | ||
| 745 | TP_PROTO(struct inode *inode, struct page *page, unsigned long off), \ | ||
| 746 | TP_ARGS(inode, page, off), \ | ||
| 747 | TP_STRUCT__entry( \ | ||
| 748 | __field(dev_t, dev) \ | ||
| 749 | __field(xfs_ino_t, ino) \ | ||
| 750 | __field(pgoff_t, pgoff) \ | ||
| 751 | __field(loff_t, size) \ | ||
| 752 | __field(unsigned long, offset) \ | ||
| 753 | __field(int, delalloc) \ | ||
| 754 | __field(int, unmapped) \ | ||
| 755 | __field(int, unwritten) \ | ||
| 756 | ), \ | ||
| 757 | TP_fast_assign( \ | ||
| 758 | int delalloc = -1, unmapped = -1, unwritten = -1; \ | ||
| 759 | \ | ||
| 760 | if (page_has_buffers(page)) \ | ||
| 761 | xfs_count_page_state(page, &delalloc, \ | ||
| 762 | &unmapped, &unwritten); \ | ||
| 763 | __entry->dev = inode->i_sb->s_dev; \ | ||
| 764 | __entry->ino = XFS_I(inode)->i_ino; \ | ||
| 765 | __entry->pgoff = page_offset(page); \ | ||
| 766 | __entry->size = i_size_read(inode); \ | ||
| 767 | __entry->offset = off; \ | ||
| 768 | __entry->delalloc = delalloc; \ | ||
| 769 | __entry->unmapped = unmapped; \ | ||
| 770 | __entry->unwritten = unwritten; \ | ||
| 771 | ), \ | ||
| 772 | TP_printk("dev %d:%d ino 0x%llx pgoff 0x%lx size 0x%llx offset %lx " \ | ||
| 773 | "delalloc %d unmapped %d unwritten %d", \ | ||
| 774 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 775 | __entry->ino, \ | ||
| 776 | __entry->pgoff, \ | ||
| 777 | __entry->size, \ | ||
| 778 | __entry->offset, \ | ||
| 779 | __entry->delalloc, \ | ||
| 780 | __entry->unmapped, \ | ||
| 781 | __entry->unwritten) \ | ||
| 782 | ) | ||
| 783 | DEFINE_PAGE_EVENT(xfs_writepage); | ||
| 784 | DEFINE_PAGE_EVENT(xfs_releasepage); | ||
| 785 | DEFINE_PAGE_EVENT(xfs_invalidatepage); | ||
| 786 | |||
| 787 | #define DEFINE_IOMAP_EVENT(name) \ | ||
| 788 | TRACE_EVENT(name, \ | ||
| 789 | TP_PROTO(struct xfs_inode *ip, xfs_off_t offset, ssize_t count, \ | ||
| 790 | int flags, struct xfs_bmbt_irec *irec), \ | ||
| 791 | TP_ARGS(ip, offset, count, flags, irec), \ | ||
| 792 | TP_STRUCT__entry( \ | ||
| 793 | __field(dev_t, dev) \ | ||
| 794 | __field(xfs_ino_t, ino) \ | ||
| 795 | __field(loff_t, size) \ | ||
| 796 | __field(loff_t, new_size) \ | ||
| 797 | __field(loff_t, offset) \ | ||
| 798 | __field(size_t, count) \ | ||
| 799 | __field(int, flags) \ | ||
| 800 | __field(xfs_fileoff_t, startoff) \ | ||
| 801 | __field(xfs_fsblock_t, startblock) \ | ||
| 802 | __field(xfs_filblks_t, blockcount) \ | ||
| 803 | ), \ | ||
| 804 | TP_fast_assign( \ | ||
| 805 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 806 | __entry->ino = ip->i_ino; \ | ||
| 807 | __entry->size = ip->i_d.di_size; \ | ||
| 808 | __entry->new_size = ip->i_new_size; \ | ||
| 809 | __entry->offset = offset; \ | ||
| 810 | __entry->count = count; \ | ||
| 811 | __entry->flags = flags; \ | ||
| 812 | __entry->startoff = irec ? irec->br_startoff : 0; \ | ||
| 813 | __entry->startblock = irec ? irec->br_startblock : 0; \ | ||
| 814 | __entry->blockcount = irec ? irec->br_blockcount : 0; \ | ||
| 815 | ), \ | ||
| 816 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx " \ | ||
| 817 | "offset 0x%llx count %zd flags %s " \ | ||
| 818 | "startoff 0x%llx startblock 0x%llx blockcount 0x%llx", \ | ||
| 819 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 820 | __entry->ino, \ | ||
| 821 | __entry->size, \ | ||
| 822 | __entry->new_size, \ | ||
| 823 | __entry->offset, \ | ||
| 824 | __entry->count, \ | ||
| 825 | __print_flags(__entry->flags, "|", BMAPI_FLAGS), \ | ||
| 826 | __entry->startoff, \ | ||
| 827 | __entry->startblock, \ | ||
| 828 | __entry->blockcount) \ | ||
| 829 | ) | ||
| 830 | DEFINE_IOMAP_EVENT(xfs_iomap_enter); | ||
| 831 | DEFINE_IOMAP_EVENT(xfs_iomap_found); | ||
| 832 | DEFINE_IOMAP_EVENT(xfs_iomap_alloc); | ||
| 833 | |||
| 834 | #define DEFINE_SIMPLE_IO_EVENT(name) \ | ||
| 835 | TRACE_EVENT(name, \ | ||
| 836 | TP_PROTO(struct xfs_inode *ip, xfs_off_t offset, ssize_t count), \ | ||
| 837 | TP_ARGS(ip, offset, count), \ | ||
| 838 | TP_STRUCT__entry( \ | ||
| 839 | __field(dev_t, dev) \ | ||
| 840 | __field(xfs_ino_t, ino) \ | ||
| 841 | __field(loff_t, size) \ | ||
| 842 | __field(loff_t, new_size) \ | ||
| 843 | __field(loff_t, offset) \ | ||
| 844 | __field(size_t, count) \ | ||
| 845 | ), \ | ||
| 846 | TP_fast_assign( \ | ||
| 847 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 848 | __entry->ino = ip->i_ino; \ | ||
| 849 | __entry->size = ip->i_d.di_size; \ | ||
| 850 | __entry->new_size = ip->i_new_size; \ | ||
| 851 | __entry->offset = offset; \ | ||
| 852 | __entry->count = count; \ | ||
| 853 | ), \ | ||
| 854 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx " \ | ||
| 855 | "offset 0x%llx count %zd", \ | ||
| 856 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 857 | __entry->ino, \ | ||
| 858 | __entry->size, \ | ||
| 859 | __entry->new_size, \ | ||
| 860 | __entry->offset, \ | ||
| 861 | __entry->count) \ | ||
| 862 | ); | ||
| 863 | DEFINE_SIMPLE_IO_EVENT(xfs_delalloc_enospc); | ||
| 864 | DEFINE_SIMPLE_IO_EVENT(xfs_unwritten_convert); | ||
| 865 | |||
| 866 | |||
| 867 | TRACE_EVENT(xfs_itruncate_start, | ||
| 868 | TP_PROTO(struct xfs_inode *ip, xfs_fsize_t new_size, int flag, | ||
| 869 | xfs_off_t toss_start, xfs_off_t toss_finish), | ||
| 870 | TP_ARGS(ip, new_size, flag, toss_start, toss_finish), | ||
| 871 | TP_STRUCT__entry( | ||
| 872 | __field(dev_t, dev) | ||
| 873 | __field(xfs_ino_t, ino) | ||
| 874 | __field(xfs_fsize_t, size) | ||
| 875 | __field(xfs_fsize_t, new_size) | ||
| 876 | __field(xfs_off_t, toss_start) | ||
| 877 | __field(xfs_off_t, toss_finish) | ||
| 878 | __field(int, flag) | ||
| 879 | ), | ||
| 880 | TP_fast_assign( | ||
| 881 | __entry->dev = VFS_I(ip)->i_sb->s_dev; | ||
| 882 | __entry->ino = ip->i_ino; | ||
| 883 | __entry->size = ip->i_d.di_size; | ||
| 884 | __entry->new_size = new_size; | ||
| 885 | __entry->toss_start = toss_start; | ||
| 886 | __entry->toss_finish = toss_finish; | ||
| 887 | __entry->flag = flag; | ||
| 888 | ), | ||
| 889 | TP_printk("dev %d:%d ino 0x%llx %s size 0x%llx new_size 0x%llx " | ||
| 890 | "toss start 0x%llx toss finish 0x%llx", | ||
| 891 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 892 | __entry->ino, | ||
| 893 | __print_flags(__entry->flag, "|", XFS_ITRUNC_FLAGS), | ||
| 894 | __entry->size, | ||
| 895 | __entry->new_size, | ||
| 896 | __entry->toss_start, | ||
| 897 | __entry->toss_finish) | ||
| 898 | ); | ||
| 899 | |||
| 900 | #define DEFINE_ITRUNC_EVENT(name) \ | ||
| 901 | TRACE_EVENT(name, \ | ||
| 902 | TP_PROTO(struct xfs_inode *ip, xfs_fsize_t new_size), \ | ||
| 903 | TP_ARGS(ip, new_size), \ | ||
| 904 | TP_STRUCT__entry( \ | ||
| 905 | __field(dev_t, dev) \ | ||
| 906 | __field(xfs_ino_t, ino) \ | ||
| 907 | __field(xfs_fsize_t, size) \ | ||
| 908 | __field(xfs_fsize_t, new_size) \ | ||
| 909 | ), \ | ||
| 910 | TP_fast_assign( \ | ||
| 911 | __entry->dev = VFS_I(ip)->i_sb->s_dev; \ | ||
| 912 | __entry->ino = ip->i_ino; \ | ||
| 913 | __entry->size = ip->i_d.di_size; \ | ||
| 914 | __entry->new_size = new_size; \ | ||
| 915 | ), \ | ||
| 916 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx", \ | ||
| 917 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 918 | __entry->ino, \ | ||
| 919 | __entry->size, \ | ||
| 920 | __entry->new_size) \ | ||
| 921 | ) | ||
| 922 | DEFINE_ITRUNC_EVENT(xfs_itruncate_finish_start); | ||
| 923 | DEFINE_ITRUNC_EVENT(xfs_itruncate_finish_end); | ||
| 924 | |||
| 925 | TRACE_EVENT(xfs_pagecache_inval, | ||
| 926 | TP_PROTO(struct xfs_inode *ip, xfs_off_t start, xfs_off_t finish), | ||
| 927 | TP_ARGS(ip, start, finish), | ||
| 928 | TP_STRUCT__entry( | ||
| 929 | __field(dev_t, dev) | ||
| 930 | __field(xfs_ino_t, ino) | ||
| 931 | __field(xfs_fsize_t, size) | ||
| 932 | __field(xfs_off_t, start) | ||
| 933 | __field(xfs_off_t, finish) | ||
| 934 | ), | ||
| 935 | TP_fast_assign( | ||
| 936 | __entry->dev = VFS_I(ip)->i_sb->s_dev; | ||
| 937 | __entry->ino = ip->i_ino; | ||
| 938 | __entry->size = ip->i_d.di_size; | ||
| 939 | __entry->start = start; | ||
| 940 | __entry->finish = finish; | ||
| 941 | ), | ||
| 942 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx start 0x%llx finish 0x%llx", | ||
| 943 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 944 | __entry->ino, | ||
| 945 | __entry->size, | ||
| 946 | __entry->start, | ||
| 947 | __entry->finish) | ||
| 948 | ); | ||
| 949 | |||
| 950 | TRACE_EVENT(xfs_bunmap, | ||
| 951 | TP_PROTO(struct xfs_inode *ip, xfs_fileoff_t bno, xfs_filblks_t len, | ||
| 952 | int flags, unsigned long caller_ip), | ||
| 953 | TP_ARGS(ip, bno, len, flags, caller_ip), | ||
| 954 | TP_STRUCT__entry( | ||
| 955 | __field(dev_t, dev) | ||
| 956 | __field(xfs_ino_t, ino) | ||
| 957 | __field(xfs_fsize_t, size) | ||
| 958 | __field(xfs_fileoff_t, bno) | ||
| 959 | __field(xfs_filblks_t, len) | ||
| 960 | __field(unsigned long, caller_ip) | ||
| 961 | __field(int, flags) | ||
| 962 | ), | ||
| 963 | TP_fast_assign( | ||
| 964 | __entry->dev = VFS_I(ip)->i_sb->s_dev; | ||
| 965 | __entry->ino = ip->i_ino; | ||
| 966 | __entry->size = ip->i_d.di_size; | ||
| 967 | __entry->bno = bno; | ||
| 968 | __entry->len = len; | ||
| 969 | __entry->caller_ip = caller_ip; | ||
| 970 | __entry->flags = flags; | ||
| 971 | ), | ||
| 972 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx bno 0x%llx len 0x%llx" | ||
| 973 | "flags %s caller %pf", | ||
| 974 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 975 | __entry->ino, | ||
| 976 | __entry->size, | ||
| 977 | __entry->bno, | ||
| 978 | __entry->len, | ||
| 979 | __print_flags(__entry->flags, "|", XFS_BMAPI_FLAGS), | ||
| 980 | (void *)__entry->caller_ip) | ||
| 981 | |||
| 982 | ); | ||
| 983 | |||
| 984 | TRACE_EVENT(xfs_alloc_busy, | ||
| 985 | TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno, | ||
| 986 | xfs_extlen_t len, int slot), | ||
| 987 | TP_ARGS(mp, agno, agbno, len, slot), | ||
| 988 | TP_STRUCT__entry( | ||
| 989 | __field(dev_t, dev) | ||
| 990 | __field(xfs_agnumber_t, agno) | ||
| 991 | __field(xfs_agblock_t, agbno) | ||
| 992 | __field(xfs_extlen_t, len) | ||
| 993 | __field(int, slot) | ||
| 994 | ), | ||
| 995 | TP_fast_assign( | ||
| 996 | __entry->dev = mp->m_super->s_dev; | ||
| 997 | __entry->agno = agno; | ||
| 998 | __entry->agbno = agbno; | ||
| 999 | __entry->len = len; | ||
| 1000 | __entry->slot = slot; | ||
| 1001 | ), | ||
| 1002 | TP_printk("dev %d:%d agno %u agbno %u len %u slot %d", | ||
| 1003 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1004 | __entry->agno, | ||
| 1005 | __entry->agbno, | ||
| 1006 | __entry->len, | ||
| 1007 | __entry->slot) | ||
| 1008 | |||
| 1009 | ); | ||
| 1010 | |||
| 1011 | #define XFS_BUSY_STATES \ | ||
| 1012 | { 0, "found" }, \ | ||
| 1013 | { 1, "missing" } | ||
| 1014 | |||
| 1015 | TRACE_EVENT(xfs_alloc_unbusy, | ||
| 1016 | TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, | ||
| 1017 | int slot, int found), | ||
| 1018 | TP_ARGS(mp, agno, slot, found), | ||
| 1019 | TP_STRUCT__entry( | ||
| 1020 | __field(dev_t, dev) | ||
| 1021 | __field(xfs_agnumber_t, agno) | ||
| 1022 | __field(int, slot) | ||
| 1023 | __field(int, found) | ||
| 1024 | ), | ||
| 1025 | TP_fast_assign( | ||
| 1026 | __entry->dev = mp->m_super->s_dev; | ||
| 1027 | __entry->agno = agno; | ||
| 1028 | __entry->slot = slot; | ||
| 1029 | __entry->found = found; | ||
| 1030 | ), | ||
| 1031 | TP_printk("dev %d:%d agno %u slot %d %s", | ||
| 1032 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1033 | __entry->agno, | ||
| 1034 | __entry->slot, | ||
| 1035 | __print_symbolic(__entry->found, XFS_BUSY_STATES)) | ||
| 1036 | ); | ||
| 1037 | |||
| 1038 | TRACE_EVENT(xfs_alloc_busysearch, | ||
| 1039 | TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno, | ||
| 1040 | xfs_extlen_t len, int found), | ||
| 1041 | TP_ARGS(mp, agno, agbno, len, found), | ||
| 1042 | TP_STRUCT__entry( | ||
| 1043 | __field(dev_t, dev) | ||
| 1044 | __field(xfs_agnumber_t, agno) | ||
| 1045 | __field(xfs_agblock_t, agbno) | ||
| 1046 | __field(xfs_extlen_t, len) | ||
| 1047 | __field(int, found) | ||
| 1048 | ), | ||
| 1049 | TP_fast_assign( | ||
| 1050 | __entry->dev = mp->m_super->s_dev; | ||
| 1051 | __entry->agno = agno; | ||
| 1052 | __entry->agbno = agbno; | ||
| 1053 | __entry->len = len; | ||
| 1054 | __entry->found = found; | ||
| 1055 | ), | ||
| 1056 | TP_printk("dev %d:%d agno %u agbno %u len %u %s", | ||
| 1057 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1058 | __entry->agno, | ||
| 1059 | __entry->agbno, | ||
| 1060 | __entry->len, | ||
| 1061 | __print_symbolic(__entry->found, XFS_BUSY_STATES)) | ||
| 1062 | ); | ||
| 1063 | |||
| 1064 | TRACE_EVENT(xfs_agf, | ||
| 1065 | TP_PROTO(struct xfs_mount *mp, struct xfs_agf *agf, int flags, | ||
| 1066 | unsigned long caller_ip), | ||
| 1067 | TP_ARGS(mp, agf, flags, caller_ip), | ||
| 1068 | TP_STRUCT__entry( | ||
| 1069 | __field(dev_t, dev) | ||
| 1070 | __field(xfs_agnumber_t, agno) | ||
| 1071 | __field(int, flags) | ||
| 1072 | __field(__u32, length) | ||
| 1073 | __field(__u32, bno_root) | ||
| 1074 | __field(__u32, cnt_root) | ||
| 1075 | __field(__u32, bno_level) | ||
| 1076 | __field(__u32, cnt_level) | ||
| 1077 | __field(__u32, flfirst) | ||
| 1078 | __field(__u32, fllast) | ||
| 1079 | __field(__u32, flcount) | ||
| 1080 | __field(__u32, freeblks) | ||
| 1081 | __field(__u32, longest) | ||
| 1082 | __field(unsigned long, caller_ip) | ||
| 1083 | ), | ||
| 1084 | TP_fast_assign( | ||
| 1085 | __entry->dev = mp->m_super->s_dev; | ||
| 1086 | __entry->agno = be32_to_cpu(agf->agf_seqno), | ||
| 1087 | __entry->flags = flags; | ||
| 1088 | __entry->length = be32_to_cpu(agf->agf_length), | ||
| 1089 | __entry->bno_root = be32_to_cpu(agf->agf_roots[XFS_BTNUM_BNO]), | ||
| 1090 | __entry->cnt_root = be32_to_cpu(agf->agf_roots[XFS_BTNUM_CNT]), | ||
| 1091 | __entry->bno_level = | ||
| 1092 | be32_to_cpu(agf->agf_levels[XFS_BTNUM_BNO]), | ||
| 1093 | __entry->cnt_level = | ||
| 1094 | be32_to_cpu(agf->agf_levels[XFS_BTNUM_CNT]), | ||
| 1095 | __entry->flfirst = be32_to_cpu(agf->agf_flfirst), | ||
| 1096 | __entry->fllast = be32_to_cpu(agf->agf_fllast), | ||
| 1097 | __entry->flcount = be32_to_cpu(agf->agf_flcount), | ||
| 1098 | __entry->freeblks = be32_to_cpu(agf->agf_freeblks), | ||
| 1099 | __entry->longest = be32_to_cpu(agf->agf_longest); | ||
| 1100 | __entry->caller_ip = caller_ip; | ||
| 1101 | ), | ||
| 1102 | TP_printk("dev %d:%d agno %u flags %s length %u roots b %u c %u " | ||
| 1103 | "levels b %u c %u flfirst %u fllast %u flcount %u " | ||
| 1104 | "freeblks %u longest %u caller %pf", | ||
| 1105 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1106 | __entry->agno, | ||
| 1107 | __print_flags(__entry->flags, "|", XFS_AGF_FLAGS), | ||
| 1108 | __entry->length, | ||
| 1109 | __entry->bno_root, | ||
| 1110 | __entry->cnt_root, | ||
| 1111 | __entry->bno_level, | ||
| 1112 | __entry->cnt_level, | ||
| 1113 | __entry->flfirst, | ||
| 1114 | __entry->fllast, | ||
| 1115 | __entry->flcount, | ||
| 1116 | __entry->freeblks, | ||
| 1117 | __entry->longest, | ||
| 1118 | (void *)__entry->caller_ip) | ||
| 1119 | ); | ||
| 1120 | |||
| 1121 | TRACE_EVENT(xfs_free_extent, | ||
| 1122 | TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno, | ||
| 1123 | xfs_extlen_t len, bool isfl, int haveleft, int haveright), | ||
| 1124 | TP_ARGS(mp, agno, agbno, len, isfl, haveleft, haveright), | ||
| 1125 | TP_STRUCT__entry( | ||
| 1126 | __field(dev_t, dev) | ||
| 1127 | __field(xfs_agnumber_t, agno) | ||
| 1128 | __field(xfs_agblock_t, agbno) | ||
| 1129 | __field(xfs_extlen_t, len) | ||
| 1130 | __field(int, isfl) | ||
| 1131 | __field(int, haveleft) | ||
| 1132 | __field(int, haveright) | ||
| 1133 | ), | ||
| 1134 | TP_fast_assign( | ||
| 1135 | __entry->dev = mp->m_super->s_dev; | ||
| 1136 | __entry->agno = agno; | ||
| 1137 | __entry->agbno = agbno; | ||
| 1138 | __entry->len = len; | ||
| 1139 | __entry->isfl = isfl; | ||
| 1140 | __entry->haveleft = haveleft; | ||
| 1141 | __entry->haveright = haveright; | ||
| 1142 | ), | ||
| 1143 | TP_printk("dev %d:%d agno %u agbno %u len %u isfl %d %s", | ||
| 1144 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1145 | __entry->agno, | ||
| 1146 | __entry->agbno, | ||
| 1147 | __entry->len, | ||
| 1148 | __entry->isfl, | ||
| 1149 | __entry->haveleft ? | ||
| 1150 | (__entry->haveright ? "both" : "left") : | ||
| 1151 | (__entry->haveright ? "right" : "none")) | ||
| 1152 | |||
| 1153 | ); | ||
| 1154 | |||
| 1155 | #define DEFINE_ALLOC_EVENT(name) \ | ||
| 1156 | TRACE_EVENT(name, \ | ||
| 1157 | TP_PROTO(struct xfs_alloc_arg *args), \ | ||
| 1158 | TP_ARGS(args), \ | ||
| 1159 | TP_STRUCT__entry( \ | ||
| 1160 | __field(dev_t, dev) \ | ||
| 1161 | __field(xfs_agnumber_t, agno) \ | ||
| 1162 | __field(xfs_agblock_t, agbno) \ | ||
| 1163 | __field(xfs_extlen_t, minlen) \ | ||
| 1164 | __field(xfs_extlen_t, maxlen) \ | ||
| 1165 | __field(xfs_extlen_t, mod) \ | ||
| 1166 | __field(xfs_extlen_t, prod) \ | ||
| 1167 | __field(xfs_extlen_t, minleft) \ | ||
| 1168 | __field(xfs_extlen_t, total) \ | ||
| 1169 | __field(xfs_extlen_t, alignment) \ | ||
| 1170 | __field(xfs_extlen_t, minalignslop) \ | ||
| 1171 | __field(xfs_extlen_t, len) \ | ||
| 1172 | __field(short, type) \ | ||
| 1173 | __field(short, otype) \ | ||
| 1174 | __field(char, wasdel) \ | ||
| 1175 | __field(char, wasfromfl) \ | ||
| 1176 | __field(char, isfl) \ | ||
| 1177 | __field(char, userdata) \ | ||
| 1178 | __field(xfs_fsblock_t, firstblock) \ | ||
| 1179 | ), \ | ||
| 1180 | TP_fast_assign( \ | ||
| 1181 | __entry->dev = args->mp->m_super->s_dev; \ | ||
| 1182 | __entry->agno = args->agno; \ | ||
| 1183 | __entry->agbno = args->agbno; \ | ||
| 1184 | __entry->minlen = args->minlen; \ | ||
| 1185 | __entry->maxlen = args->maxlen; \ | ||
| 1186 | __entry->mod = args->mod; \ | ||
| 1187 | __entry->prod = args->prod; \ | ||
| 1188 | __entry->minleft = args->minleft; \ | ||
| 1189 | __entry->total = args->total; \ | ||
| 1190 | __entry->alignment = args->alignment; \ | ||
| 1191 | __entry->minalignslop = args->minalignslop; \ | ||
| 1192 | __entry->len = args->len; \ | ||
| 1193 | __entry->type = args->type; \ | ||
| 1194 | __entry->otype = args->otype; \ | ||
| 1195 | __entry->wasdel = args->wasdel; \ | ||
| 1196 | __entry->wasfromfl = args->wasfromfl; \ | ||
| 1197 | __entry->isfl = args->isfl; \ | ||
| 1198 | __entry->userdata = args->userdata; \ | ||
| 1199 | __entry->firstblock = args->firstblock; \ | ||
| 1200 | ), \ | ||
| 1201 | TP_printk("dev %d:%d agno %u agbno %u minlen %u maxlen %u mod %u " \ | ||
| 1202 | "prod %u minleft %u total %u alignment %u minalignslop %u " \ | ||
| 1203 | "len %u type %s otype %s wasdel %d wasfromfl %d isfl %d " \ | ||
| 1204 | "userdata %d firstblock 0x%llx", \ | ||
| 1205 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 1206 | __entry->agno, \ | ||
| 1207 | __entry->agbno, \ | ||
| 1208 | __entry->minlen, \ | ||
| 1209 | __entry->maxlen, \ | ||
| 1210 | __entry->mod, \ | ||
| 1211 | __entry->prod, \ | ||
| 1212 | __entry->minleft, \ | ||
| 1213 | __entry->total, \ | ||
| 1214 | __entry->alignment, \ | ||
| 1215 | __entry->minalignslop, \ | ||
| 1216 | __entry->len, \ | ||
| 1217 | __print_symbolic(__entry->type, XFS_ALLOC_TYPES), \ | ||
| 1218 | __print_symbolic(__entry->otype, XFS_ALLOC_TYPES), \ | ||
| 1219 | __entry->wasdel, \ | ||
| 1220 | __entry->wasfromfl, \ | ||
| 1221 | __entry->isfl, \ | ||
| 1222 | __entry->userdata, \ | ||
| 1223 | __entry->firstblock) \ | ||
| 1224 | ) | ||
| 1225 | |||
| 1226 | DEFINE_ALLOC_EVENT(xfs_alloc_exact_done); | ||
| 1227 | DEFINE_ALLOC_EVENT(xfs_alloc_exact_error); | ||
| 1228 | DEFINE_ALLOC_EVENT(xfs_alloc_near_nominleft); | ||
| 1229 | DEFINE_ALLOC_EVENT(xfs_alloc_near_first); | ||
| 1230 | DEFINE_ALLOC_EVENT(xfs_alloc_near_greater); | ||
| 1231 | DEFINE_ALLOC_EVENT(xfs_alloc_near_lesser); | ||
| 1232 | DEFINE_ALLOC_EVENT(xfs_alloc_near_error); | ||
| 1233 | DEFINE_ALLOC_EVENT(xfs_alloc_size_neither); | ||
| 1234 | DEFINE_ALLOC_EVENT(xfs_alloc_size_noentry); | ||
| 1235 | DEFINE_ALLOC_EVENT(xfs_alloc_size_nominleft); | ||
| 1236 | DEFINE_ALLOC_EVENT(xfs_alloc_size_done); | ||
| 1237 | DEFINE_ALLOC_EVENT(xfs_alloc_size_error); | ||
| 1238 | DEFINE_ALLOC_EVENT(xfs_alloc_small_freelist); | ||
| 1239 | DEFINE_ALLOC_EVENT(xfs_alloc_small_notenough); | ||
| 1240 | DEFINE_ALLOC_EVENT(xfs_alloc_small_done); | ||
| 1241 | DEFINE_ALLOC_EVENT(xfs_alloc_small_error); | ||
| 1242 | DEFINE_ALLOC_EVENT(xfs_alloc_vextent_badargs); | ||
| 1243 | DEFINE_ALLOC_EVENT(xfs_alloc_vextent_nofix); | ||
| 1244 | DEFINE_ALLOC_EVENT(xfs_alloc_vextent_noagbp); | ||
| 1245 | DEFINE_ALLOC_EVENT(xfs_alloc_vextent_loopfailed); | ||
| 1246 | DEFINE_ALLOC_EVENT(xfs_alloc_vextent_allfailed); | ||
| 1247 | |||
| 1248 | #define DEFINE_DIR2_TRACE(tname) \ | ||
| 1249 | TRACE_EVENT(tname, \ | ||
| 1250 | TP_PROTO(struct xfs_da_args *args), \ | ||
| 1251 | TP_ARGS(args), \ | ||
| 1252 | TP_STRUCT__entry( \ | ||
| 1253 | __field(dev_t, dev) \ | ||
| 1254 | __field(xfs_ino_t, ino) \ | ||
| 1255 | __dynamic_array(char, name, args->namelen) \ | ||
| 1256 | __field(int, namelen) \ | ||
| 1257 | __field(xfs_dahash_t, hashval) \ | ||
| 1258 | __field(xfs_ino_t, inumber) \ | ||
| 1259 | __field(int, op_flags) \ | ||
| 1260 | ), \ | ||
| 1261 | TP_fast_assign( \ | ||
| 1262 | __entry->dev = VFS_I(args->dp)->i_sb->s_dev; \ | ||
| 1263 | __entry->ino = args->dp->i_ino; \ | ||
| 1264 | if (args->namelen) \ | ||
| 1265 | memcpy(__get_str(name), args->name, args->namelen); \ | ||
| 1266 | __entry->namelen = args->namelen; \ | ||
| 1267 | __entry->hashval = args->hashval; \ | ||
| 1268 | __entry->inumber = args->inumber; \ | ||
| 1269 | __entry->op_flags = args->op_flags; \ | ||
| 1270 | ), \ | ||
| 1271 | TP_printk("dev %d:%d ino 0x%llx name %.*s namelen %d hashval 0x%x " \ | ||
| 1272 | "inumber 0x%llx op_flags %s", \ | ||
| 1273 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 1274 | __entry->ino, \ | ||
| 1275 | __entry->namelen, \ | ||
| 1276 | __entry->namelen ? __get_str(name) : NULL, \ | ||
| 1277 | __entry->namelen, \ | ||
| 1278 | __entry->hashval, \ | ||
| 1279 | __entry->inumber, \ | ||
| 1280 | __print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS)) \ | ||
| 1281 | ) | ||
| 1282 | DEFINE_DIR2_TRACE(xfs_dir2_sf_addname); | ||
| 1283 | DEFINE_DIR2_TRACE(xfs_dir2_sf_create); | ||
| 1284 | DEFINE_DIR2_TRACE(xfs_dir2_sf_lookup); | ||
| 1285 | DEFINE_DIR2_TRACE(xfs_dir2_sf_replace); | ||
| 1286 | DEFINE_DIR2_TRACE(xfs_dir2_sf_removename); | ||
| 1287 | DEFINE_DIR2_TRACE(xfs_dir2_sf_toino4); | ||
| 1288 | DEFINE_DIR2_TRACE(xfs_dir2_sf_toino8); | ||
| 1289 | DEFINE_DIR2_TRACE(xfs_dir2_sf_to_block); | ||
| 1290 | DEFINE_DIR2_TRACE(xfs_dir2_block_addname); | ||
| 1291 | DEFINE_DIR2_TRACE(xfs_dir2_block_lookup); | ||
| 1292 | DEFINE_DIR2_TRACE(xfs_dir2_block_replace); | ||
| 1293 | DEFINE_DIR2_TRACE(xfs_dir2_block_removename); | ||
| 1294 | DEFINE_DIR2_TRACE(xfs_dir2_block_to_sf); | ||
| 1295 | DEFINE_DIR2_TRACE(xfs_dir2_block_to_leaf); | ||
| 1296 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_addname); | ||
| 1297 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_lookup); | ||
| 1298 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_replace); | ||
| 1299 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_removename); | ||
| 1300 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_to_block); | ||
| 1301 | DEFINE_DIR2_TRACE(xfs_dir2_leaf_to_node); | ||
| 1302 | DEFINE_DIR2_TRACE(xfs_dir2_node_addname); | ||
| 1303 | DEFINE_DIR2_TRACE(xfs_dir2_node_lookup); | ||
| 1304 | DEFINE_DIR2_TRACE(xfs_dir2_node_replace); | ||
| 1305 | DEFINE_DIR2_TRACE(xfs_dir2_node_removename); | ||
| 1306 | DEFINE_DIR2_TRACE(xfs_dir2_node_to_leaf); | ||
| 1307 | |||
| 1308 | #define DEFINE_DIR2_SPACE_TRACE(tname) \ | ||
| 1309 | TRACE_EVENT(tname, \ | ||
| 1310 | TP_PROTO(struct xfs_da_args *args, int idx), \ | ||
| 1311 | TP_ARGS(args, idx), \ | ||
| 1312 | TP_STRUCT__entry( \ | ||
| 1313 | __field(dev_t, dev) \ | ||
| 1314 | __field(xfs_ino_t, ino) \ | ||
| 1315 | __field(int, op_flags) \ | ||
| 1316 | __field(int, idx) \ | ||
| 1317 | ), \ | ||
| 1318 | TP_fast_assign( \ | ||
| 1319 | __entry->dev = VFS_I(args->dp)->i_sb->s_dev; \ | ||
| 1320 | __entry->ino = args->dp->i_ino; \ | ||
| 1321 | __entry->op_flags = args->op_flags; \ | ||
| 1322 | __entry->idx = idx; \ | ||
| 1323 | ), \ | ||
| 1324 | TP_printk("dev %d:%d ino 0x%llx op_flags %s index %d", \ | ||
| 1325 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | ||
| 1326 | __entry->ino, \ | ||
| 1327 | __print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS), \ | ||
| 1328 | __entry->idx) \ | ||
| 1329 | ) | ||
| 1330 | DEFINE_DIR2_SPACE_TRACE(xfs_dir2_leafn_add); | ||
| 1331 | DEFINE_DIR2_SPACE_TRACE(xfs_dir2_leafn_remove); | ||
| 1332 | DEFINE_DIR2_SPACE_TRACE(xfs_dir2_grow_inode); | ||
| 1333 | DEFINE_DIR2_SPACE_TRACE(xfs_dir2_shrink_inode); | ||
| 1334 | |||
| 1335 | TRACE_EVENT(xfs_dir2_leafn_moveents, | ||
| 1336 | TP_PROTO(struct xfs_da_args *args, int src_idx, int dst_idx, int count), | ||
| 1337 | TP_ARGS(args, src_idx, dst_idx, count), | ||
| 1338 | TP_STRUCT__entry( | ||
| 1339 | __field(dev_t, dev) | ||
| 1340 | __field(xfs_ino_t, ino) | ||
| 1341 | __field(int, op_flags) | ||
| 1342 | __field(int, src_idx) | ||
| 1343 | __field(int, dst_idx) | ||
| 1344 | __field(int, count) | ||
| 1345 | ), | ||
| 1346 | TP_fast_assign( | ||
| 1347 | __entry->dev = VFS_I(args->dp)->i_sb->s_dev; | ||
| 1348 | __entry->ino = args->dp->i_ino; | ||
| 1349 | __entry->op_flags = args->op_flags; | ||
| 1350 | __entry->src_idx = src_idx; | ||
| 1351 | __entry->dst_idx = dst_idx; | ||
| 1352 | __entry->count = count; | ||
| 1353 | ), | ||
| 1354 | TP_printk("dev %d:%d ino 0x%llx op_flags %s " | ||
| 1355 | "src_idx %d dst_idx %d count %d", | ||
| 1356 | MAJOR(__entry->dev), MINOR(__entry->dev), | ||
| 1357 | __entry->ino, | ||
| 1358 | __print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS), | ||
| 1359 | __entry->src_idx, | ||
| 1360 | __entry->dst_idx, | ||
| 1361 | __entry->count) | ||
| 1362 | ); | ||
| 1363 | |||
| 1364 | #endif /* _TRACE_XFS_H */ | ||
| 1365 | |||
| 1366 | #undef TRACE_INCLUDE_PATH | ||
| 1367 | #define TRACE_INCLUDE_PATH . | ||
| 1368 | #define TRACE_INCLUDE_FILE xfs_trace | ||
| 1369 | #include <trace/define_trace.h> | ||
diff --git a/fs/xfs/linux-2.6/xfs_vnode.h b/fs/xfs/linux-2.6/xfs_vnode.h index ad7fbead4c97..7c220b4227bc 100644 --- a/fs/xfs/linux-2.6/xfs_vnode.h +++ b/fs/xfs/linux-2.6/xfs_vnode.h | |||
| @@ -36,10 +36,13 @@ struct attrlist_cursor_kern; | |||
| 36 | /* | 36 | /* |
| 37 | * Flags for read/write calls - same values as IRIX | 37 | * Flags for read/write calls - same values as IRIX |
| 38 | */ | 38 | */ |
| 39 | #define IO_ISAIO 0x00001 /* don't wait for completion */ | ||
| 40 | #define IO_ISDIRECT 0x00004 /* bypass page cache */ | 39 | #define IO_ISDIRECT 0x00004 /* bypass page cache */ |
| 41 | #define IO_INVIS 0x00020 /* don't update inode timestamps */ | 40 | #define IO_INVIS 0x00020 /* don't update inode timestamps */ |
| 42 | 41 | ||
| 42 | #define XFS_IO_FLAGS \ | ||
| 43 | { IO_ISDIRECT, "DIRECT" }, \ | ||
| 44 | { IO_INVIS, "INVIS"} | ||
| 45 | |||
| 43 | /* | 46 | /* |
| 44 | * Flush/Invalidate options for vop_toss/flush/flushinval_pages. | 47 | * Flush/Invalidate options for vop_toss/flush/flushinval_pages. |
| 45 | */ | 48 | */ |
diff --git a/fs/xfs/quota/xfs_dquot.c b/fs/xfs/quota/xfs_dquot.c index 2f3f2229eaaf..d7c7eea09fc2 100644 --- a/fs/xfs/quota/xfs_dquot.c +++ b/fs/xfs/quota/xfs_dquot.c | |||
| @@ -47,6 +47,7 @@ | |||
| 47 | #include "xfs_trans_space.h" | 47 | #include "xfs_trans_space.h" |
| 48 | #include "xfs_trans_priv.h" | 48 | #include "xfs_trans_priv.h" |
| 49 | #include "xfs_qm.h" | 49 | #include "xfs_qm.h" |
| 50 | #include "xfs_trace.h" | ||
| 50 | 51 | ||
| 51 | 52 | ||
| 52 | /* | 53 | /* |
| @@ -112,10 +113,7 @@ xfs_qm_dqinit( | |||
| 112 | init_completion(&dqp->q_flush); | 113 | init_completion(&dqp->q_flush); |
| 113 | complete(&dqp->q_flush); | 114 | complete(&dqp->q_flush); |
| 114 | 115 | ||
| 115 | #ifdef XFS_DQUOT_TRACE | 116 | trace_xfs_dqinit(dqp); |
| 116 | dqp->q_trace = ktrace_alloc(DQUOT_TRACE_SIZE, KM_NOFS); | ||
| 117 | xfs_dqtrace_entry(dqp, "DQINIT"); | ||
| 118 | #endif | ||
| 119 | } else { | 117 | } else { |
| 120 | /* | 118 | /* |
| 121 | * Only the q_core portion was zeroed in dqreclaim_one(). | 119 | * Only the q_core portion was zeroed in dqreclaim_one(). |
| @@ -136,10 +134,7 @@ xfs_qm_dqinit( | |||
| 136 | dqp->q_hash = NULL; | 134 | dqp->q_hash = NULL; |
| 137 | ASSERT(dqp->dq_flnext == dqp->dq_flprev); | 135 | ASSERT(dqp->dq_flnext == dqp->dq_flprev); |
| 138 | 136 | ||
| 139 | #ifdef XFS_DQUOT_TRACE | 137 | trace_xfs_dqreuse(dqp); |
| 140 | ASSERT(dqp->q_trace); | ||
| 141 | xfs_dqtrace_entry(dqp, "DQRECLAIMED_INIT"); | ||
| 142 | #endif | ||
| 143 | } | 138 | } |
| 144 | 139 | ||
| 145 | /* | 140 | /* |
| @@ -167,13 +162,8 @@ xfs_qm_dqdestroy( | |||
| 167 | 162 | ||
| 168 | mutex_destroy(&dqp->q_qlock); | 163 | mutex_destroy(&dqp->q_qlock); |
| 169 | sv_destroy(&dqp->q_pinwait); | 164 | sv_destroy(&dqp->q_pinwait); |
| 170 | |||
| 171 | #ifdef XFS_DQUOT_TRACE | ||
| 172 | if (dqp->q_trace) | ||
| 173 | ktrace_free(dqp->q_trace); | ||
| 174 | dqp->q_trace = NULL; | ||
| 175 | #endif | ||
| 176 | kmem_zone_free(xfs_Gqm->qm_dqzone, dqp); | 165 | kmem_zone_free(xfs_Gqm->qm_dqzone, dqp); |
| 166 | |||
| 177 | atomic_dec(&xfs_Gqm->qm_totaldquots); | 167 | atomic_dec(&xfs_Gqm->qm_totaldquots); |
| 178 | } | 168 | } |
| 179 | 169 | ||
| @@ -195,49 +185,6 @@ xfs_qm_dqinit_core( | |||
| 195 | d->dd_diskdq.d_flags = type; | 185 | d->dd_diskdq.d_flags = type; |
| 196 | } | 186 | } |
| 197 | 187 | ||
| 198 | |||
| 199 | #ifdef XFS_DQUOT_TRACE | ||
| 200 | /* | ||
| 201 | * Dquot tracing for debugging. | ||
| 202 | */ | ||
| 203 | /* ARGSUSED */ | ||
| 204 | void | ||
| 205 | __xfs_dqtrace_entry( | ||
| 206 | xfs_dquot_t *dqp, | ||
| 207 | char *func, | ||
| 208 | void *retaddr, | ||
| 209 | xfs_inode_t *ip) | ||
| 210 | { | ||
| 211 | xfs_dquot_t *udqp = NULL; | ||
| 212 | xfs_ino_t ino = 0; | ||
| 213 | |||
| 214 | ASSERT(dqp->q_trace); | ||
| 215 | if (ip) { | ||
| 216 | ino = ip->i_ino; | ||
| 217 | udqp = ip->i_udquot; | ||
| 218 | } | ||
| 219 | ktrace_enter(dqp->q_trace, | ||
| 220 | (void *)(__psint_t)DQUOT_KTRACE_ENTRY, | ||
| 221 | (void *)func, | ||
| 222 | (void *)(__psint_t)dqp->q_nrefs, | ||
| 223 | (void *)(__psint_t)dqp->dq_flags, | ||
| 224 | (void *)(__psint_t)dqp->q_res_bcount, | ||
| 225 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_bcount), | ||
| 226 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_icount), | ||
| 227 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_blk_hardlimit), | ||
| 228 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_blk_softlimit), | ||
| 229 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_ino_hardlimit), | ||
| 230 | (void *)(__psint_t)be64_to_cpu(dqp->q_core.d_ino_softlimit), | ||
| 231 | (void *)(__psint_t)be32_to_cpu(dqp->q_core.d_id), | ||
| 232 | (void *)(__psint_t)current_pid(), | ||
| 233 | (void *)(__psint_t)ino, | ||
| 234 | (void *)(__psint_t)retaddr, | ||
| 235 | (void *)(__psint_t)udqp); | ||
| 236 | return; | ||
| 237 | } | ||
| 238 | #endif | ||
| 239 | |||
| 240 | |||
| 241 | /* | 188 | /* |
| 242 | * If default limits are in force, push them into the dquot now. | 189 | * If default limits are in force, push them into the dquot now. |
| 243 | * We overwrite the dquot limits only if they are zero and this | 190 | * We overwrite the dquot limits only if they are zero and this |
| @@ -425,7 +372,8 @@ xfs_qm_dqalloc( | |||
| 425 | xfs_trans_t *tp = *tpp; | 372 | xfs_trans_t *tp = *tpp; |
| 426 | 373 | ||
| 427 | ASSERT(tp != NULL); | 374 | ASSERT(tp != NULL); |
| 428 | xfs_dqtrace_entry(dqp, "DQALLOC"); | 375 | |
| 376 | trace_xfs_dqalloc(dqp); | ||
| 429 | 377 | ||
| 430 | /* | 378 | /* |
| 431 | * Initialize the bmap freelist prior to calling bmapi code. | 379 | * Initialize the bmap freelist prior to calling bmapi code. |
| @@ -612,7 +560,8 @@ xfs_qm_dqtobp( | |||
| 612 | * (in which case we already have the buf). | 560 | * (in which case we already have the buf). |
| 613 | */ | 561 | */ |
| 614 | if (! newdquot) { | 562 | if (! newdquot) { |
| 615 | xfs_dqtrace_entry(dqp, "DQTOBP READBUF"); | 563 | trace_xfs_dqtobp_read(dqp); |
| 564 | |||
| 616 | if ((error = xfs_trans_read_buf(mp, tp, mp->m_ddev_targp, | 565 | if ((error = xfs_trans_read_buf(mp, tp, mp->m_ddev_targp, |
| 617 | dqp->q_blkno, | 566 | dqp->q_blkno, |
| 618 | XFS_QI_DQCHUNKLEN(mp), | 567 | XFS_QI_DQCHUNKLEN(mp), |
| @@ -670,11 +619,12 @@ xfs_qm_dqread( | |||
| 670 | 619 | ||
| 671 | ASSERT(tpp); | 620 | ASSERT(tpp); |
| 672 | 621 | ||
| 622 | trace_xfs_dqread(dqp); | ||
| 623 | |||
| 673 | /* | 624 | /* |
| 674 | * get a pointer to the on-disk dquot and the buffer containing it | 625 | * get a pointer to the on-disk dquot and the buffer containing it |
| 675 | * dqp already knows its own type (GROUP/USER). | 626 | * dqp already knows its own type (GROUP/USER). |
| 676 | */ | 627 | */ |
| 677 | xfs_dqtrace_entry(dqp, "DQREAD"); | ||
| 678 | if ((error = xfs_qm_dqtobp(tpp, dqp, &ddqp, &bp, flags))) { | 628 | if ((error = xfs_qm_dqtobp(tpp, dqp, &ddqp, &bp, flags))) { |
| 679 | return (error); | 629 | return (error); |
| 680 | } | 630 | } |
| @@ -763,7 +713,7 @@ xfs_qm_idtodq( | |||
| 763 | * or if the dquot didn't exist on disk and we ask to | 713 | * or if the dquot didn't exist on disk and we ask to |
| 764 | * allocate (ENOENT). | 714 | * allocate (ENOENT). |
| 765 | */ | 715 | */ |
| 766 | xfs_dqtrace_entry(dqp, "DQREAD FAIL"); | 716 | trace_xfs_dqread_fail(dqp); |
| 767 | cancelflags |= XFS_TRANS_ABORT; | 717 | cancelflags |= XFS_TRANS_ABORT; |
| 768 | goto error0; | 718 | goto error0; |
| 769 | } | 719 | } |
| @@ -817,7 +767,8 @@ xfs_qm_dqlookup( | |||
| 817 | * id can't be modified without the hashlock anyway. | 767 | * id can't be modified without the hashlock anyway. |
| 818 | */ | 768 | */ |
| 819 | if (be32_to_cpu(dqp->q_core.d_id) == id && dqp->q_mount == mp) { | 769 | if (be32_to_cpu(dqp->q_core.d_id) == id && dqp->q_mount == mp) { |
| 820 | xfs_dqtrace_entry(dqp, "DQFOUND BY LOOKUP"); | 770 | trace_xfs_dqlookup_found(dqp); |
| 771 | |||
| 821 | /* | 772 | /* |
| 822 | * All in core dquots must be on the dqlist of mp | 773 | * All in core dquots must be on the dqlist of mp |
| 823 | */ | 774 | */ |
| @@ -827,7 +778,7 @@ xfs_qm_dqlookup( | |||
| 827 | if (dqp->q_nrefs == 0) { | 778 | if (dqp->q_nrefs == 0) { |
| 828 | ASSERT (XFS_DQ_IS_ON_FREELIST(dqp)); | 779 | ASSERT (XFS_DQ_IS_ON_FREELIST(dqp)); |
| 829 | if (! xfs_qm_freelist_lock_nowait(xfs_Gqm)) { | 780 | if (! xfs_qm_freelist_lock_nowait(xfs_Gqm)) { |
| 830 | xfs_dqtrace_entry(dqp, "DQLOOKUP: WANT"); | 781 | trace_xfs_dqlookup_want(dqp); |
| 831 | 782 | ||
| 832 | /* | 783 | /* |
| 833 | * We may have raced with dqreclaim_one() | 784 | * We may have raced with dqreclaim_one() |
| @@ -857,8 +808,7 @@ xfs_qm_dqlookup( | |||
| 857 | /* | 808 | /* |
| 858 | * take it off the freelist | 809 | * take it off the freelist |
| 859 | */ | 810 | */ |
| 860 | xfs_dqtrace_entry(dqp, | 811 | trace_xfs_dqlookup_freelist(dqp); |
| 861 | "DQLOOKUP: TAKEOFF FL"); | ||
| 862 | XQM_FREELIST_REMOVE(dqp); | 812 | XQM_FREELIST_REMOVE(dqp); |
| 863 | /* xfs_qm_freelist_print(&(xfs_Gqm-> | 813 | /* xfs_qm_freelist_print(&(xfs_Gqm-> |
| 864 | qm_dqfreelist), | 814 | qm_dqfreelist), |
| @@ -878,8 +828,7 @@ xfs_qm_dqlookup( | |||
| 878 | */ | 828 | */ |
| 879 | ASSERT(mutex_is_locked(&qh->qh_lock)); | 829 | ASSERT(mutex_is_locked(&qh->qh_lock)); |
| 880 | if (dqp->HL_PREVP != &qh->qh_next) { | 830 | if (dqp->HL_PREVP != &qh->qh_next) { |
| 881 | xfs_dqtrace_entry(dqp, | 831 | trace_xfs_dqlookup_move(dqp); |
| 882 | "DQLOOKUP: HASH MOVETOFRONT"); | ||
| 883 | if ((d = dqp->HL_NEXT)) | 832 | if ((d = dqp->HL_NEXT)) |
| 884 | d->HL_PREVP = dqp->HL_PREVP; | 833 | d->HL_PREVP = dqp->HL_PREVP; |
| 885 | *(dqp->HL_PREVP) = d; | 834 | *(dqp->HL_PREVP) = d; |
| @@ -889,7 +838,7 @@ xfs_qm_dqlookup( | |||
| 889 | dqp->HL_PREVP = &qh->qh_next; | 838 | dqp->HL_PREVP = &qh->qh_next; |
| 890 | qh->qh_next = dqp; | 839 | qh->qh_next = dqp; |
| 891 | } | 840 | } |
| 892 | xfs_dqtrace_entry(dqp, "LOOKUP END"); | 841 | trace_xfs_dqlookup_done(dqp); |
| 893 | *O_dqpp = dqp; | 842 | *O_dqpp = dqp; |
| 894 | ASSERT(mutex_is_locked(&qh->qh_lock)); | 843 | ASSERT(mutex_is_locked(&qh->qh_lock)); |
| 895 | return (0); | 844 | return (0); |
| @@ -971,7 +920,7 @@ xfs_qm_dqget( | |||
| 971 | ASSERT(*O_dqpp); | 920 | ASSERT(*O_dqpp); |
| 972 | ASSERT(XFS_DQ_IS_LOCKED(*O_dqpp)); | 921 | ASSERT(XFS_DQ_IS_LOCKED(*O_dqpp)); |
| 973 | mutex_unlock(&h->qh_lock); | 922 | mutex_unlock(&h->qh_lock); |
| 974 | xfs_dqtrace_entry(*O_dqpp, "DQGET DONE (FROM CACHE)"); | 923 | trace_xfs_dqget_hit(*O_dqpp); |
| 975 | return (0); /* success */ | 924 | return (0); /* success */ |
| 976 | } | 925 | } |
| 977 | XQM_STATS_INC(xqmstats.xs_qm_dqcachemisses); | 926 | XQM_STATS_INC(xqmstats.xs_qm_dqcachemisses); |
| @@ -1104,7 +1053,7 @@ xfs_qm_dqget( | |||
| 1104 | mutex_unlock(&h->qh_lock); | 1053 | mutex_unlock(&h->qh_lock); |
| 1105 | dqret: | 1054 | dqret: |
| 1106 | ASSERT((ip == NULL) || xfs_isilocked(ip, XFS_ILOCK_EXCL)); | 1055 | ASSERT((ip == NULL) || xfs_isilocked(ip, XFS_ILOCK_EXCL)); |
| 1107 | xfs_dqtrace_entry(dqp, "DQGET DONE"); | 1056 | trace_xfs_dqget_miss(dqp); |
| 1108 | *O_dqpp = dqp; | 1057 | *O_dqpp = dqp; |
| 1109 | return (0); | 1058 | return (0); |
| 1110 | } | 1059 | } |
| @@ -1124,7 +1073,8 @@ xfs_qm_dqput( | |||
| 1124 | 1073 | ||
| 1125 | ASSERT(dqp->q_nrefs > 0); | 1074 | ASSERT(dqp->q_nrefs > 0); |
| 1126 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 1075 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
| 1127 | xfs_dqtrace_entry(dqp, "DQPUT"); | 1076 | |
| 1077 | trace_xfs_dqput(dqp); | ||
| 1128 | 1078 | ||
| 1129 | if (dqp->q_nrefs != 1) { | 1079 | if (dqp->q_nrefs != 1) { |
| 1130 | dqp->q_nrefs--; | 1080 | dqp->q_nrefs--; |
| @@ -1137,7 +1087,7 @@ xfs_qm_dqput( | |||
| 1137 | * in the right order; but try to get it out-of-order first | 1087 | * in the right order; but try to get it out-of-order first |
| 1138 | */ | 1088 | */ |
| 1139 | if (! xfs_qm_freelist_lock_nowait(xfs_Gqm)) { | 1089 | if (! xfs_qm_freelist_lock_nowait(xfs_Gqm)) { |
| 1140 | xfs_dqtrace_entry(dqp, "DQPUT: FLLOCK-WAIT"); | 1090 | trace_xfs_dqput_wait(dqp); |
| 1141 | xfs_dqunlock(dqp); | 1091 | xfs_dqunlock(dqp); |
| 1142 | xfs_qm_freelist_lock(xfs_Gqm); | 1092 | xfs_qm_freelist_lock(xfs_Gqm); |
| 1143 | xfs_dqlock(dqp); | 1093 | xfs_dqlock(dqp); |
| @@ -1148,7 +1098,8 @@ xfs_qm_dqput( | |||
| 1148 | 1098 | ||
| 1149 | /* We can't depend on nrefs being == 1 here */ | 1099 | /* We can't depend on nrefs being == 1 here */ |
| 1150 | if (--dqp->q_nrefs == 0) { | 1100 | if (--dqp->q_nrefs == 0) { |
| 1151 | xfs_dqtrace_entry(dqp, "DQPUT: ON FREELIST"); | 1101 | trace_xfs_dqput_free(dqp); |
| 1102 | |||
| 1152 | /* | 1103 | /* |
| 1153 | * insert at end of the freelist. | 1104 | * insert at end of the freelist. |
| 1154 | */ | 1105 | */ |
| @@ -1196,7 +1147,7 @@ xfs_qm_dqrele( | |||
| 1196 | if (!dqp) | 1147 | if (!dqp) |
| 1197 | return; | 1148 | return; |
| 1198 | 1149 | ||
| 1199 | xfs_dqtrace_entry(dqp, "DQRELE"); | 1150 | trace_xfs_dqrele(dqp); |
| 1200 | 1151 | ||
| 1201 | xfs_dqlock(dqp); | 1152 | xfs_dqlock(dqp); |
| 1202 | /* | 1153 | /* |
| @@ -1229,7 +1180,7 @@ xfs_qm_dqflush( | |||
| 1229 | 1180 | ||
| 1230 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 1181 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
| 1231 | ASSERT(!completion_done(&dqp->q_flush)); | 1182 | ASSERT(!completion_done(&dqp->q_flush)); |
| 1232 | xfs_dqtrace_entry(dqp, "DQFLUSH"); | 1183 | trace_xfs_dqflush(dqp); |
| 1233 | 1184 | ||
| 1234 | /* | 1185 | /* |
| 1235 | * If not dirty, or it's pinned and we are not supposed to | 1186 | * If not dirty, or it's pinned and we are not supposed to |
| @@ -1259,7 +1210,6 @@ xfs_qm_dqflush( | |||
| 1259 | * the ondisk-dquot has already been allocated for. | 1210 | * the ondisk-dquot has already been allocated for. |
| 1260 | */ | 1211 | */ |
| 1261 | if ((error = xfs_qm_dqtobp(NULL, dqp, &ddqp, &bp, XFS_QMOPT_DOWARN))) { | 1212 | if ((error = xfs_qm_dqtobp(NULL, dqp, &ddqp, &bp, XFS_QMOPT_DOWARN))) { |
| 1262 | xfs_dqtrace_entry(dqp, "DQTOBP FAIL"); | ||
| 1263 | ASSERT(error != ENOENT); | 1213 | ASSERT(error != ENOENT); |
| 1264 | /* | 1214 | /* |
| 1265 | * Quotas could have gotten turned off (ESRCH) | 1215 | * Quotas could have gotten turned off (ESRCH) |
| @@ -1297,7 +1247,7 @@ xfs_qm_dqflush( | |||
| 1297 | * get stuck waiting in the write for too long. | 1247 | * get stuck waiting in the write for too long. |
| 1298 | */ | 1248 | */ |
| 1299 | if (XFS_BUF_ISPINNED(bp)) { | 1249 | if (XFS_BUF_ISPINNED(bp)) { |
| 1300 | xfs_dqtrace_entry(dqp, "DQFLUSH LOG FORCE"); | 1250 | trace_xfs_dqflush_force(dqp); |
| 1301 | xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE); | 1251 | xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE); |
| 1302 | } | 1252 | } |
| 1303 | 1253 | ||
| @@ -1308,7 +1258,9 @@ xfs_qm_dqflush( | |||
| 1308 | } else { | 1258 | } else { |
| 1309 | error = xfs_bwrite(mp, bp); | 1259 | error = xfs_bwrite(mp, bp); |
| 1310 | } | 1260 | } |
| 1311 | xfs_dqtrace_entry(dqp, "DQFLUSH END"); | 1261 | |
| 1262 | trace_xfs_dqflush_done(dqp); | ||
| 1263 | |||
| 1312 | /* | 1264 | /* |
| 1313 | * dqp is still locked, but caller is free to unlock it now. | 1265 | * dqp is still locked, but caller is free to unlock it now. |
| 1314 | */ | 1266 | */ |
| @@ -1483,7 +1435,7 @@ xfs_qm_dqpurge( | |||
| 1483 | */ | 1435 | */ |
| 1484 | if (XFS_DQ_IS_DIRTY(dqp)) { | 1436 | if (XFS_DQ_IS_DIRTY(dqp)) { |
| 1485 | int error; | 1437 | int error; |
| 1486 | xfs_dqtrace_entry(dqp, "DQPURGE ->DQFLUSH: DQDIRTY"); | 1438 | |
| 1487 | /* dqflush unlocks dqflock */ | 1439 | /* dqflush unlocks dqflock */ |
| 1488 | /* | 1440 | /* |
| 1489 | * Given that dqpurge is a very rare occurrence, it is OK | 1441 | * Given that dqpurge is a very rare occurrence, it is OK |
diff --git a/fs/xfs/quota/xfs_dquot.h b/fs/xfs/quota/xfs_dquot.h index 6533ead9b889..a0f7da586d1b 100644 --- a/fs/xfs/quota/xfs_dquot.h +++ b/fs/xfs/quota/xfs_dquot.h | |||
| @@ -85,9 +85,6 @@ typedef struct xfs_dquot { | |||
| 85 | struct completion q_flush; /* flush completion queue */ | 85 | struct completion q_flush; /* flush completion queue */ |
| 86 | atomic_t q_pincount; /* dquot pin count */ | 86 | atomic_t q_pincount; /* dquot pin count */ |
| 87 | wait_queue_head_t q_pinwait; /* dquot pinning wait queue */ | 87 | wait_queue_head_t q_pinwait; /* dquot pinning wait queue */ |
| 88 | #ifdef XFS_DQUOT_TRACE | ||
| 89 | struct ktrace *q_trace; /* trace header structure */ | ||
| 90 | #endif | ||
| 91 | } xfs_dquot_t; | 88 | } xfs_dquot_t; |
| 92 | 89 | ||
| 93 | 90 | ||
| @@ -98,7 +95,7 @@ typedef struct xfs_dquot { | |||
| 98 | #define dq_flags q_lists.dqm_flags | 95 | #define dq_flags q_lists.dqm_flags |
| 99 | 96 | ||
| 100 | /* | 97 | /* |
| 101 | * Lock hierachy for q_qlock: | 98 | * Lock hierarchy for q_qlock: |
| 102 | * XFS_QLOCK_NORMAL is the implicit default, | 99 | * XFS_QLOCK_NORMAL is the implicit default, |
| 103 | * XFS_QLOCK_NESTED is the dquot with the higher id in xfs_dqlock2 | 100 | * XFS_QLOCK_NESTED is the dquot with the higher id in xfs_dqlock2 |
| 104 | */ | 101 | */ |
| @@ -144,24 +141,6 @@ static inline void xfs_dqfunlock(xfs_dquot_t *dqp) | |||
| 144 | (XFS_IS_UQUOTA_ON((d)->q_mount)) : \ | 141 | (XFS_IS_UQUOTA_ON((d)->q_mount)) : \ |
| 145 | (XFS_IS_OQUOTA_ON((d)->q_mount)))) | 142 | (XFS_IS_OQUOTA_ON((d)->q_mount)))) |
| 146 | 143 | ||
| 147 | #ifdef XFS_DQUOT_TRACE | ||
| 148 | /* | ||
| 149 | * Dquot Tracing stuff. | ||
| 150 | */ | ||
| 151 | #define DQUOT_TRACE_SIZE 64 | ||
| 152 | #define DQUOT_KTRACE_ENTRY 1 | ||
| 153 | |||
| 154 | extern void __xfs_dqtrace_entry(xfs_dquot_t *dqp, char *func, | ||
| 155 | void *, xfs_inode_t *); | ||
| 156 | #define xfs_dqtrace_entry_ino(a,b,ip) \ | ||
| 157 | __xfs_dqtrace_entry((a), (b), (void*)__return_address, (ip)) | ||
| 158 | #define xfs_dqtrace_entry(a,b) \ | ||
| 159 | __xfs_dqtrace_entry((a), (b), (void*)__return_address, NULL) | ||
| 160 | #else | ||
| 161 | #define xfs_dqtrace_entry(a,b) | ||
| 162 | #define xfs_dqtrace_entry_ino(a,b,ip) | ||
| 163 | #endif | ||
| 164 | |||
| 165 | #ifdef QUOTADEBUG | 144 | #ifdef QUOTADEBUG |
| 166 | extern void xfs_qm_dqprint(xfs_dquot_t *); | 145 | extern void xfs_qm_dqprint(xfs_dquot_t *); |
| 167 | #else | 146 | #else |
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c index 45b1bfef7388..9e627a8b5b0e 100644 --- a/fs/xfs/quota/xfs_qm.c +++ b/fs/xfs/quota/xfs_qm.c | |||
| @@ -47,6 +47,7 @@ | |||
| 47 | #include "xfs_trans_space.h" | 47 | #include "xfs_trans_space.h" |
| 48 | #include "xfs_utils.h" | 48 | #include "xfs_utils.h" |
| 49 | #include "xfs_qm.h" | 49 | #include "xfs_qm.h" |
| 50 | #include "xfs_trace.h" | ||
| 50 | 51 | ||
| 51 | /* | 52 | /* |
| 52 | * The global quota manager. There is only one of these for the entire | 53 | * The global quota manager. There is only one of these for the entire |
| @@ -453,7 +454,7 @@ again: | |||
| 453 | xfs_dqunlock(dqp); | 454 | xfs_dqunlock(dqp); |
| 454 | continue; | 455 | continue; |
| 455 | } | 456 | } |
| 456 | xfs_dqtrace_entry(dqp, "FLUSHALL: DQDIRTY"); | 457 | |
| 457 | /* XXX a sentinel would be better */ | 458 | /* XXX a sentinel would be better */ |
| 458 | recl = XFS_QI_MPLRECLAIMS(mp); | 459 | recl = XFS_QI_MPLRECLAIMS(mp); |
| 459 | if (!xfs_dqflock_nowait(dqp)) { | 460 | if (!xfs_dqflock_nowait(dqp)) { |
| @@ -651,7 +652,7 @@ xfs_qm_dqattach_one( | |||
| 651 | */ | 652 | */ |
| 652 | dqp = *IO_idqpp; | 653 | dqp = *IO_idqpp; |
| 653 | if (dqp) { | 654 | if (dqp) { |
| 654 | xfs_dqtrace_entry(dqp, "DQATTACH: found in ip"); | 655 | trace_xfs_dqattach_found(dqp); |
| 655 | return 0; | 656 | return 0; |
| 656 | } | 657 | } |
| 657 | 658 | ||
| @@ -704,7 +705,7 @@ xfs_qm_dqattach_one( | |||
| 704 | if (error) | 705 | if (error) |
| 705 | return error; | 706 | return error; |
| 706 | 707 | ||
| 707 | xfs_dqtrace_entry(dqp, "DQATTACH: found by dqget"); | 708 | trace_xfs_dqattach_get(dqp); |
| 708 | 709 | ||
| 709 | /* | 710 | /* |
| 710 | * dqget may have dropped and re-acquired the ilock, but it guarantees | 711 | * dqget may have dropped and re-acquired the ilock, but it guarantees |
| @@ -890,15 +891,15 @@ xfs_qm_dqdetach( | |||
| 890 | if (!(ip->i_udquot || ip->i_gdquot)) | 891 | if (!(ip->i_udquot || ip->i_gdquot)) |
| 891 | return; | 892 | return; |
| 892 | 893 | ||
| 894 | trace_xfs_dquot_dqdetach(ip); | ||
| 895 | |||
| 893 | ASSERT(ip->i_ino != ip->i_mount->m_sb.sb_uquotino); | 896 | ASSERT(ip->i_ino != ip->i_mount->m_sb.sb_uquotino); |
| 894 | ASSERT(ip->i_ino != ip->i_mount->m_sb.sb_gquotino); | 897 | ASSERT(ip->i_ino != ip->i_mount->m_sb.sb_gquotino); |
| 895 | if (ip->i_udquot) { | 898 | if (ip->i_udquot) { |
| 896 | xfs_dqtrace_entry_ino(ip->i_udquot, "DQDETTACH", ip); | ||
| 897 | xfs_qm_dqrele(ip->i_udquot); | 899 | xfs_qm_dqrele(ip->i_udquot); |
| 898 | ip->i_udquot = NULL; | 900 | ip->i_udquot = NULL; |
| 899 | } | 901 | } |
| 900 | if (ip->i_gdquot) { | 902 | if (ip->i_gdquot) { |
| 901 | xfs_dqtrace_entry_ino(ip->i_gdquot, "DQDETTACH", ip); | ||
| 902 | xfs_qm_dqrele(ip->i_gdquot); | 903 | xfs_qm_dqrele(ip->i_gdquot); |
| 903 | ip->i_gdquot = NULL; | 904 | ip->i_gdquot = NULL; |
| 904 | } | 905 | } |
| @@ -977,7 +978,6 @@ xfs_qm_sync( | |||
| 977 | * across a disk write | 978 | * across a disk write |
| 978 | */ | 979 | */ |
| 979 | xfs_qm_mplist_unlock(mp); | 980 | xfs_qm_mplist_unlock(mp); |
| 980 | xfs_dqtrace_entry(dqp, "XQM_SYNC: DQFLUSH"); | ||
| 981 | error = xfs_qm_dqflush(dqp, flush_flags); | 981 | error = xfs_qm_dqflush(dqp, flush_flags); |
| 982 | xfs_dqunlock(dqp); | 982 | xfs_dqunlock(dqp); |
| 983 | if (error && XFS_FORCED_SHUTDOWN(mp)) | 983 | if (error && XFS_FORCED_SHUTDOWN(mp)) |
| @@ -1350,7 +1350,8 @@ xfs_qm_reset_dqcounts( | |||
| 1350 | xfs_disk_dquot_t *ddq; | 1350 | xfs_disk_dquot_t *ddq; |
| 1351 | int j; | 1351 | int j; |
| 1352 | 1352 | ||
| 1353 | xfs_buftrace("RESET DQUOTS", bp); | 1353 | trace_xfs_reset_dqcounts(bp, _RET_IP_); |
| 1354 | |||
| 1354 | /* | 1355 | /* |
| 1355 | * Reset all counters and timers. They'll be | 1356 | * Reset all counters and timers. They'll be |
| 1356 | * started afresh by xfs_qm_quotacheck. | 1357 | * started afresh by xfs_qm_quotacheck. |
| @@ -1543,7 +1544,9 @@ xfs_qm_quotacheck_dqadjust( | |||
| 1543 | xfs_qcnt_t rtblks) | 1544 | xfs_qcnt_t rtblks) |
| 1544 | { | 1545 | { |
| 1545 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 1546 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
| 1546 | xfs_dqtrace_entry(dqp, "QCHECK DQADJUST"); | 1547 | |
| 1548 | trace_xfs_dqadjust(dqp); | ||
| 1549 | |||
| 1547 | /* | 1550 | /* |
| 1548 | * Adjust the inode count and the block count to reflect this inode's | 1551 | * Adjust the inode count and the block count to reflect this inode's |
| 1549 | * resource usage. | 1552 | * resource usage. |
| @@ -1994,7 +1997,9 @@ xfs_qm_shake_freelist( | |||
| 1994 | */ | 1997 | */ |
| 1995 | if (XFS_DQ_IS_DIRTY(dqp)) { | 1998 | if (XFS_DQ_IS_DIRTY(dqp)) { |
| 1996 | int error; | 1999 | int error; |
| 1997 | xfs_dqtrace_entry(dqp, "DQSHAKE: DQDIRTY"); | 2000 | |
| 2001 | trace_xfs_dqshake_dirty(dqp); | ||
| 2002 | |||
| 1998 | /* | 2003 | /* |
| 1999 | * We flush it delayed write, so don't bother | 2004 | * We flush it delayed write, so don't bother |
| 2000 | * releasing the mplock. | 2005 | * releasing the mplock. |
| @@ -2038,7 +2043,9 @@ xfs_qm_shake_freelist( | |||
| 2038 | return nreclaimed; | 2043 | return nreclaimed; |
| 2039 | goto tryagain; | 2044 | goto tryagain; |
| 2040 | } | 2045 | } |
| 2041 | xfs_dqtrace_entry(dqp, "DQSHAKE: UNLINKING"); | 2046 | |
| 2047 | trace_xfs_dqshake_unlink(dqp); | ||
| 2048 | |||
| 2042 | #ifdef QUOTADEBUG | 2049 | #ifdef QUOTADEBUG |
| 2043 | cmn_err(CE_DEBUG, "Shake 0x%p, ID 0x%x\n", | 2050 | cmn_err(CE_DEBUG, "Shake 0x%p, ID 0x%x\n", |
| 2044 | dqp, be32_to_cpu(dqp->q_core.d_id)); | 2051 | dqp, be32_to_cpu(dqp->q_core.d_id)); |
| @@ -2125,7 +2132,9 @@ xfs_qm_dqreclaim_one(void) | |||
| 2125 | */ | 2132 | */ |
| 2126 | if (dqp->dq_flags & XFS_DQ_WANT) { | 2133 | if (dqp->dq_flags & XFS_DQ_WANT) { |
| 2127 | ASSERT(! (dqp->dq_flags & XFS_DQ_INACTIVE)); | 2134 | ASSERT(! (dqp->dq_flags & XFS_DQ_INACTIVE)); |
| 2128 | xfs_dqtrace_entry(dqp, "DQRECLAIM: DQWANT"); | 2135 | |
| 2136 | trace_xfs_dqreclaim_want(dqp); | ||
| 2137 | |||
| 2129 | xfs_dqunlock(dqp); | 2138 | xfs_dqunlock(dqp); |
| 2130 | xfs_qm_freelist_unlock(xfs_Gqm); | 2139 | xfs_qm_freelist_unlock(xfs_Gqm); |
| 2131 | if (++restarts >= XFS_QM_RECLAIM_MAX_RESTARTS) | 2140 | if (++restarts >= XFS_QM_RECLAIM_MAX_RESTARTS) |
| @@ -2171,7 +2180,9 @@ xfs_qm_dqreclaim_one(void) | |||
| 2171 | */ | 2180 | */ |
| 2172 | if (XFS_DQ_IS_DIRTY(dqp)) { | 2181 | if (XFS_DQ_IS_DIRTY(dqp)) { |
| 2173 | int error; | 2182 | int error; |
| 2174 | xfs_dqtrace_entry(dqp, "DQRECLAIM: DQDIRTY"); | 2183 | |
| 2184 | trace_xfs_dqreclaim_dirty(dqp); | ||
| 2185 | |||
| 2175 | /* | 2186 | /* |
| 2176 | * We flush it delayed write, so don't bother | 2187 | * We flush it delayed write, so don't bother |
| 2177 | * releasing the freelist lock. | 2188 | * releasing the freelist lock. |
| @@ -2194,8 +2205,9 @@ xfs_qm_dqreclaim_one(void) | |||
| 2194 | if (!mutex_trylock(&dqp->q_hash->qh_lock)) | 2205 | if (!mutex_trylock(&dqp->q_hash->qh_lock)) |
| 2195 | goto mplistunlock; | 2206 | goto mplistunlock; |
| 2196 | 2207 | ||
| 2208 | trace_xfs_dqreclaim_unlink(dqp); | ||
| 2209 | |||
| 2197 | ASSERT(dqp->q_nrefs == 0); | 2210 | ASSERT(dqp->q_nrefs == 0); |
| 2198 | xfs_dqtrace_entry(dqp, "DQRECLAIM: UNLINKING"); | ||
| 2199 | XQM_MPLIST_REMOVE(&(XFS_QI_MPL_LIST(dqp->q_mount)), dqp); | 2211 | XQM_MPLIST_REMOVE(&(XFS_QI_MPL_LIST(dqp->q_mount)), dqp); |
| 2200 | XQM_HASHLIST_REMOVE(dqp->q_hash, dqp); | 2212 | XQM_HASHLIST_REMOVE(dqp->q_hash, dqp); |
| 2201 | XQM_FREELIST_REMOVE(dqp); | 2213 | XQM_FREELIST_REMOVE(dqp); |
| @@ -2430,7 +2442,7 @@ xfs_qm_vop_dqalloc( | |||
| 2430 | } | 2442 | } |
| 2431 | } | 2443 | } |
| 2432 | if (uq) | 2444 | if (uq) |
| 2433 | xfs_dqtrace_entry_ino(uq, "DQALLOC", ip); | 2445 | trace_xfs_dquot_dqalloc(ip); |
| 2434 | 2446 | ||
| 2435 | xfs_iunlock(ip, lockflags); | 2447 | xfs_iunlock(ip, lockflags); |
| 2436 | if (O_udqpp) | 2448 | if (O_udqpp) |
diff --git a/fs/xfs/quota/xfs_qm_syscalls.c b/fs/xfs/quota/xfs_qm_syscalls.c index 5d1a3b98a6e6..71af76fe8a23 100644 --- a/fs/xfs/quota/xfs_qm_syscalls.c +++ b/fs/xfs/quota/xfs_qm_syscalls.c | |||
| @@ -49,6 +49,7 @@ | |||
| 49 | #include "xfs_buf_item.h" | 49 | #include "xfs_buf_item.h" |
| 50 | #include "xfs_utils.h" | 50 | #include "xfs_utils.h" |
| 51 | #include "xfs_qm.h" | 51 | #include "xfs_qm.h" |
| 52 | #include "xfs_trace.h" | ||
| 52 | 53 | ||
| 53 | #ifdef DEBUG | 54 | #ifdef DEBUG |
| 54 | # define qdprintk(s, args...) cmn_err(CE_DEBUG, s, ## args) | 55 | # define qdprintk(s, args...) cmn_err(CE_DEBUG, s, ## args) |
| @@ -496,7 +497,6 @@ xfs_qm_scall_setqlim( | |||
| 496 | ASSERT(error != ENOENT); | 497 | ASSERT(error != ENOENT); |
| 497 | return (error); | 498 | return (error); |
| 498 | } | 499 | } |
| 499 | xfs_dqtrace_entry(dqp, "Q_SETQLIM: AFT DQGET"); | ||
| 500 | xfs_trans_dqjoin(tp, dqp); | 500 | xfs_trans_dqjoin(tp, dqp); |
| 501 | ddq = &dqp->q_core; | 501 | ddq = &dqp->q_core; |
| 502 | 502 | ||
| @@ -602,7 +602,6 @@ xfs_qm_scall_setqlim( | |||
| 602 | dqp->dq_flags |= XFS_DQ_DIRTY; | 602 | dqp->dq_flags |= XFS_DQ_DIRTY; |
| 603 | xfs_trans_log_dquot(tp, dqp); | 603 | xfs_trans_log_dquot(tp, dqp); |
| 604 | 604 | ||
| 605 | xfs_dqtrace_entry(dqp, "Q_SETQLIM: COMMIT"); | ||
| 606 | error = xfs_trans_commit(tp, 0); | 605 | error = xfs_trans_commit(tp, 0); |
| 607 | xfs_qm_dqprint(dqp); | 606 | xfs_qm_dqprint(dqp); |
| 608 | xfs_qm_dqrele(dqp); | 607 | xfs_qm_dqrele(dqp); |
| @@ -630,7 +629,6 @@ xfs_qm_scall_getquota( | |||
| 630 | return (error); | 629 | return (error); |
| 631 | } | 630 | } |
| 632 | 631 | ||
| 633 | xfs_dqtrace_entry(dqp, "Q_GETQUOTA SUCCESS"); | ||
| 634 | /* | 632 | /* |
| 635 | * If everything's NULL, this dquot doesn't quite exist as far as | 633 | * If everything's NULL, this dquot doesn't quite exist as far as |
| 636 | * our utility programs are concerned. | 634 | * our utility programs are concerned. |
diff --git a/fs/xfs/support/debug.h b/fs/xfs/support/debug.h index 6f4fd37c67af..d2d20462fd4f 100644 --- a/fs/xfs/support/debug.h +++ b/fs/xfs/support/debug.h | |||
| @@ -41,10 +41,6 @@ extern void assfail(char *expr, char *f, int l); | |||
| 41 | # define STATIC static noinline | 41 | # define STATIC static noinline |
| 42 | #endif | 42 | #endif |
| 43 | 43 | ||
| 44 | #ifndef STATIC_INLINE | ||
| 45 | # define STATIC_INLINE static inline | ||
| 46 | #endif | ||
| 47 | |||
| 48 | #else /* DEBUG */ | 44 | #else /* DEBUG */ |
| 49 | 45 | ||
| 50 | #define ASSERT(expr) \ | 46 | #define ASSERT(expr) \ |
| @@ -54,19 +50,5 @@ extern void assfail(char *expr, char *f, int l); | |||
| 54 | # define STATIC noinline | 50 | # define STATIC noinline |
| 55 | #endif | 51 | #endif |
| 56 | 52 | ||
| 57 | /* | ||
| 58 | * We stop inlining of inline functions in debug mode. | ||
| 59 | * Unfortunately, this means static inline in header files | ||
| 60 | * get multiple definitions, so they need to remain static. | ||
| 61 | * This then gives tonnes of warnings about unused but defined | ||
| 62 | * functions, so we need to add the unused attribute to prevent | ||
| 63 | * these spurious warnings. | ||
| 64 | */ | ||
| 65 | #ifndef STATIC_INLINE | ||
| 66 | # define STATIC_INLINE static __attribute__ ((unused)) noinline | ||
| 67 | #endif | ||
| 68 | |||
| 69 | #endif /* DEBUG */ | 53 | #endif /* DEBUG */ |
| 70 | |||
| 71 | |||
| 72 | #endif /* __XFS_SUPPORT_DEBUG_H__ */ | 54 | #endif /* __XFS_SUPPORT_DEBUG_H__ */ |
diff --git a/fs/xfs/support/ktrace.c b/fs/xfs/support/ktrace.c deleted file mode 100644 index 2d494c26717f..000000000000 --- a/fs/xfs/support/ktrace.c +++ /dev/null | |||
| @@ -1,323 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2000-2003,2005 Silicon Graphics, Inc. | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #include <xfs.h> | ||
| 19 | |||
| 20 | static kmem_zone_t *ktrace_hdr_zone; | ||
| 21 | static kmem_zone_t *ktrace_ent_zone; | ||
| 22 | static int ktrace_zentries; | ||
| 23 | |||
| 24 | void __init | ||
| 25 | ktrace_init(int zentries) | ||
| 26 | { | ||
| 27 | ktrace_zentries = roundup_pow_of_two(zentries); | ||
| 28 | |||
| 29 | ktrace_hdr_zone = kmem_zone_init(sizeof(ktrace_t), | ||
| 30 | "ktrace_hdr"); | ||
| 31 | ASSERT(ktrace_hdr_zone); | ||
| 32 | |||
| 33 | ktrace_ent_zone = kmem_zone_init(ktrace_zentries | ||
| 34 | * sizeof(ktrace_entry_t), | ||
| 35 | "ktrace_ent"); | ||
| 36 | ASSERT(ktrace_ent_zone); | ||
| 37 | } | ||
| 38 | |||
| 39 | void __exit | ||
| 40 | ktrace_uninit(void) | ||
| 41 | { | ||
| 42 | kmem_zone_destroy(ktrace_hdr_zone); | ||
| 43 | kmem_zone_destroy(ktrace_ent_zone); | ||
| 44 | } | ||
| 45 | |||
| 46 | /* | ||
| 47 | * ktrace_alloc() | ||
| 48 | * | ||
| 49 | * Allocate a ktrace header and enough buffering for the given | ||
| 50 | * number of entries. Round the number of entries up to a | ||
| 51 | * power of 2 so we can do fast masking to get the index from | ||
| 52 | * the atomic index counter. | ||
| 53 | */ | ||
| 54 | ktrace_t * | ||
| 55 | ktrace_alloc(int nentries, unsigned int __nocast sleep) | ||
| 56 | { | ||
| 57 | ktrace_t *ktp; | ||
| 58 | ktrace_entry_t *ktep; | ||
| 59 | int entries; | ||
| 60 | |||
| 61 | ktp = (ktrace_t*)kmem_zone_alloc(ktrace_hdr_zone, sleep); | ||
| 62 | |||
| 63 | if (ktp == (ktrace_t*)NULL) { | ||
| 64 | /* | ||
| 65 | * KM_SLEEP callers don't expect failure. | ||
| 66 | */ | ||
| 67 | if (sleep & KM_SLEEP) | ||
| 68 | panic("ktrace_alloc: NULL memory on KM_SLEEP request!"); | ||
| 69 | |||
| 70 | return NULL; | ||
| 71 | } | ||
| 72 | |||
| 73 | /* | ||
| 74 | * Special treatment for buffers with the ktrace_zentries entries | ||
| 75 | */ | ||
| 76 | entries = roundup_pow_of_two(nentries); | ||
| 77 | if (entries == ktrace_zentries) { | ||
| 78 | ktep = (ktrace_entry_t*)kmem_zone_zalloc(ktrace_ent_zone, | ||
| 79 | sleep); | ||
| 80 | } else { | ||
| 81 | ktep = (ktrace_entry_t*)kmem_zalloc((entries * sizeof(*ktep)), | ||
| 82 | sleep | KM_LARGE); | ||
| 83 | } | ||
| 84 | |||
| 85 | if (ktep == NULL) { | ||
| 86 | /* | ||
| 87 | * KM_SLEEP callers don't expect failure. | ||
| 88 | */ | ||
| 89 | if (sleep & KM_SLEEP) | ||
| 90 | panic("ktrace_alloc: NULL memory on KM_SLEEP request!"); | ||
| 91 | |||
| 92 | kmem_free(ktp); | ||
| 93 | |||
| 94 | return NULL; | ||
| 95 | } | ||
| 96 | |||
| 97 | ktp->kt_entries = ktep; | ||
| 98 | ktp->kt_nentries = entries; | ||
| 99 | ASSERT(is_power_of_2(entries)); | ||
| 100 | ktp->kt_index_mask = entries - 1; | ||
| 101 | atomic_set(&ktp->kt_index, 0); | ||
| 102 | ktp->kt_rollover = 0; | ||
| 103 | return ktp; | ||
| 104 | } | ||
| 105 | |||
| 106 | |||
| 107 | /* | ||
| 108 | * ktrace_free() | ||
| 109 | * | ||
| 110 | * Free up the ktrace header and buffer. It is up to the caller | ||
| 111 | * to ensure that no-one is referencing it. | ||
| 112 | */ | ||
| 113 | void | ||
| 114 | ktrace_free(ktrace_t *ktp) | ||
| 115 | { | ||
| 116 | if (ktp == (ktrace_t *)NULL) | ||
| 117 | return; | ||
| 118 | |||
| 119 | /* | ||
| 120 | * Special treatment for the Vnode trace buffer. | ||
| 121 | */ | ||
| 122 | if (ktp->kt_nentries == ktrace_zentries) | ||
| 123 | kmem_zone_free(ktrace_ent_zone, ktp->kt_entries); | ||
| 124 | else | ||
| 125 | kmem_free(ktp->kt_entries); | ||
| 126 | |||
| 127 | kmem_zone_free(ktrace_hdr_zone, ktp); | ||
| 128 | } | ||
| 129 | |||
| 130 | |||
| 131 | /* | ||
| 132 | * Enter the given values into the "next" entry in the trace buffer. | ||
| 133 | * kt_index is always the index of the next entry to be filled. | ||
| 134 | */ | ||
| 135 | void | ||
| 136 | ktrace_enter( | ||
| 137 | ktrace_t *ktp, | ||
| 138 | void *val0, | ||
| 139 | void *val1, | ||
| 140 | void *val2, | ||
| 141 | void *val3, | ||
| 142 | void *val4, | ||
| 143 | void *val5, | ||
| 144 | void *val6, | ||
| 145 | void *val7, | ||
| 146 | void *val8, | ||
| 147 | void *val9, | ||
| 148 | void *val10, | ||
| 149 | void *val11, | ||
| 150 | void *val12, | ||
| 151 | void *val13, | ||
| 152 | void *val14, | ||
| 153 | void *val15) | ||
| 154 | { | ||
| 155 | int index; | ||
| 156 | ktrace_entry_t *ktep; | ||
| 157 | |||
| 158 | ASSERT(ktp != NULL); | ||
| 159 | |||
| 160 | /* | ||
| 161 | * Grab an entry by pushing the index up to the next one. | ||
| 162 | */ | ||
| 163 | index = atomic_add_return(1, &ktp->kt_index); | ||
| 164 | index = (index - 1) & ktp->kt_index_mask; | ||
| 165 | if (!ktp->kt_rollover && index == ktp->kt_nentries - 1) | ||
| 166 | ktp->kt_rollover = 1; | ||
| 167 | |||
| 168 | ASSERT((index >= 0) && (index < ktp->kt_nentries)); | ||
| 169 | |||
| 170 | ktep = &(ktp->kt_entries[index]); | ||
| 171 | |||
| 172 | ktep->val[0] = val0; | ||
| 173 | ktep->val[1] = val1; | ||
| 174 | ktep->val[2] = val2; | ||
| 175 | ktep->val[3] = val3; | ||
| 176 | ktep->val[4] = val4; | ||
| 177 | ktep->val[5] = val5; | ||
| 178 | ktep->val[6] = val6; | ||
| 179 | ktep->val[7] = val7; | ||
| 180 | ktep->val[8] = val8; | ||
| 181 | ktep->val[9] = val9; | ||
| 182 | ktep->val[10] = val10; | ||
| 183 | ktep->val[11] = val11; | ||
| 184 | ktep->val[12] = val12; | ||
| 185 | ktep->val[13] = val13; | ||
| 186 | ktep->val[14] = val14; | ||
| 187 | ktep->val[15] = val15; | ||
| 188 | } | ||
| 189 | |||
| 190 | /* | ||
| 191 | * Return the number of entries in the trace buffer. | ||
| 192 | */ | ||
| 193 | int | ||
| 194 | ktrace_nentries( | ||
| 195 | ktrace_t *ktp) | ||
| 196 | { | ||
| 197 | int index; | ||
| 198 | if (ktp == NULL) | ||
| 199 | return 0; | ||
| 200 | |||
| 201 | index = atomic_read(&ktp->kt_index) & ktp->kt_index_mask; | ||
| 202 | return (ktp->kt_rollover ? ktp->kt_nentries : index); | ||
| 203 | } | ||
| 204 | |||
| 205 | /* | ||
| 206 | * ktrace_first() | ||
| 207 | * | ||
| 208 | * This is used to find the start of the trace buffer. | ||
| 209 | * In conjunction with ktrace_next() it can be used to | ||
| 210 | * iterate through the entire trace buffer. This code does | ||
| 211 | * not do any locking because it is assumed that it is called | ||
| 212 | * from the debugger. | ||
| 213 | * | ||
| 214 | * The caller must pass in a pointer to a ktrace_snap | ||
| 215 | * structure in which we will keep some state used to | ||
| 216 | * iterate through the buffer. This state must not touched | ||
| 217 | * by any code outside of this module. | ||
| 218 | */ | ||
| 219 | ktrace_entry_t * | ||
| 220 | ktrace_first(ktrace_t *ktp, ktrace_snap_t *ktsp) | ||
| 221 | { | ||
| 222 | ktrace_entry_t *ktep; | ||
| 223 | int index; | ||
| 224 | int nentries; | ||
| 225 | |||
| 226 | if (ktp->kt_rollover) | ||
| 227 | index = atomic_read(&ktp->kt_index) & ktp->kt_index_mask; | ||
| 228 | else | ||
| 229 | index = 0; | ||
| 230 | |||
| 231 | ktsp->ks_start = index; | ||
| 232 | ktep = &(ktp->kt_entries[index]); | ||
| 233 | |||
| 234 | nentries = ktrace_nentries(ktp); | ||
| 235 | index++; | ||
| 236 | if (index < nentries) { | ||
| 237 | ktsp->ks_index = index; | ||
| 238 | } else { | ||
| 239 | ktsp->ks_index = 0; | ||
| 240 | if (index > nentries) | ||
| 241 | ktep = NULL; | ||
| 242 | } | ||
| 243 | return ktep; | ||
| 244 | } | ||
| 245 | |||
| 246 | /* | ||
| 247 | * ktrace_next() | ||
| 248 | * | ||
| 249 | * This is used to iterate through the entries of the given | ||
| 250 | * trace buffer. The caller must pass in the ktrace_snap_t | ||
| 251 | * structure initialized by ktrace_first(). The return value | ||
| 252 | * will be either a pointer to the next ktrace_entry or NULL | ||
| 253 | * if all of the entries have been traversed. | ||
| 254 | */ | ||
| 255 | ktrace_entry_t * | ||
| 256 | ktrace_next( | ||
| 257 | ktrace_t *ktp, | ||
| 258 | ktrace_snap_t *ktsp) | ||
| 259 | { | ||
| 260 | int index; | ||
| 261 | ktrace_entry_t *ktep; | ||
| 262 | |||
| 263 | index = ktsp->ks_index; | ||
| 264 | if (index == ktsp->ks_start) { | ||
| 265 | ktep = NULL; | ||
| 266 | } else { | ||
| 267 | ktep = &ktp->kt_entries[index]; | ||
| 268 | } | ||
| 269 | |||
| 270 | index++; | ||
| 271 | if (index == ktrace_nentries(ktp)) { | ||
| 272 | ktsp->ks_index = 0; | ||
| 273 | } else { | ||
| 274 | ktsp->ks_index = index; | ||
| 275 | } | ||
| 276 | |||
| 277 | return ktep; | ||
| 278 | } | ||
| 279 | |||
| 280 | /* | ||
| 281 | * ktrace_skip() | ||
| 282 | * | ||
| 283 | * Skip the next "count" entries and return the entry after that. | ||
| 284 | * Return NULL if this causes us to iterate past the beginning again. | ||
| 285 | */ | ||
| 286 | ktrace_entry_t * | ||
| 287 | ktrace_skip( | ||
| 288 | ktrace_t *ktp, | ||
| 289 | int count, | ||
| 290 | ktrace_snap_t *ktsp) | ||
| 291 | { | ||
| 292 | int index; | ||
| 293 | int new_index; | ||
| 294 | ktrace_entry_t *ktep; | ||
| 295 | int nentries = ktrace_nentries(ktp); | ||
| 296 | |||
| 297 | index = ktsp->ks_index; | ||
| 298 | new_index = index + count; | ||
| 299 | while (new_index >= nentries) { | ||
| 300 | new_index -= nentries; | ||
| 301 | } | ||
| 302 | if (index == ktsp->ks_start) { | ||
| 303 | /* | ||
| 304 | * We've iterated around to the start, so we're done. | ||
| 305 | */ | ||
| 306 | ktep = NULL; | ||
| 307 | } else if ((new_index < index) && (index < ktsp->ks_index)) { | ||
| 308 | /* | ||
| 309 | * We've skipped past the start again, so we're done. | ||
| 310 | */ | ||
| 311 | ktep = NULL; | ||
| 312 | ktsp->ks_index = ktsp->ks_start; | ||
| 313 | } else { | ||
| 314 | ktep = &(ktp->kt_entries[new_index]); | ||
| 315 | new_index++; | ||
| 316 | if (new_index == nentries) { | ||
| 317 | ktsp->ks_index = 0; | ||
| 318 | } else { | ||
| 319 | ktsp->ks_index = new_index; | ||
| 320 | } | ||
| 321 | } | ||
| 322 | return ktep; | ||
| 323 | } | ||
diff --git a/fs/xfs/support/ktrace.h b/fs/xfs/support/ktrace.h deleted file mode 100644 index 741d6947ca60..000000000000 --- a/fs/xfs/support/ktrace.h +++ /dev/null | |||
| @@ -1,85 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2000-2003,2005 Silicon Graphics, Inc. | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #ifndef __XFS_SUPPORT_KTRACE_H__ | ||
| 19 | #define __XFS_SUPPORT_KTRACE_H__ | ||
| 20 | |||
| 21 | /* | ||
| 22 | * Trace buffer entry structure. | ||
| 23 | */ | ||
| 24 | typedef struct ktrace_entry { | ||
| 25 | void *val[16]; | ||
| 26 | } ktrace_entry_t; | ||
| 27 | |||
| 28 | /* | ||
| 29 | * Trace buffer header structure. | ||
| 30 | */ | ||
| 31 | typedef struct ktrace { | ||
| 32 | int kt_nentries; /* number of entries in trace buf */ | ||
| 33 | atomic_t kt_index; /* current index in entries */ | ||
| 34 | unsigned int kt_index_mask; | ||
| 35 | int kt_rollover; | ||
| 36 | ktrace_entry_t *kt_entries; /* buffer of entries */ | ||
| 37 | } ktrace_t; | ||
| 38 | |||
| 39 | /* | ||
| 40 | * Trace buffer snapshot structure. | ||
| 41 | */ | ||
| 42 | typedef struct ktrace_snap { | ||
| 43 | int ks_start; /* kt_index at time of snap */ | ||
| 44 | int ks_index; /* current index */ | ||
| 45 | } ktrace_snap_t; | ||
| 46 | |||
| 47 | |||
| 48 | #ifdef CONFIG_XFS_TRACE | ||
| 49 | |||
| 50 | extern void ktrace_init(int zentries); | ||
| 51 | extern void ktrace_uninit(void); | ||
| 52 | |||
| 53 | extern ktrace_t *ktrace_alloc(int, unsigned int __nocast); | ||
| 54 | extern void ktrace_free(ktrace_t *); | ||
| 55 | |||
| 56 | extern void ktrace_enter( | ||
| 57 | ktrace_t *, | ||
| 58 | void *, | ||
| 59 | void *, | ||
| 60 | void *, | ||
| 61 | void *, | ||
| 62 | void *, | ||
| 63 | void *, | ||
| 64 | void *, | ||
| 65 | void *, | ||
| 66 | void *, | ||
| 67 | void *, | ||
| 68 | void *, | ||
| 69 | void *, | ||
| 70 | void *, | ||
| 71 | void *, | ||
| 72 | void *, | ||
| 73 | void *); | ||
| 74 | |||
| 75 | extern ktrace_entry_t *ktrace_first(ktrace_t *, ktrace_snap_t *); | ||
| 76 | extern int ktrace_nentries(ktrace_t *); | ||
| 77 | extern ktrace_entry_t *ktrace_next(ktrace_t *, ktrace_snap_t *); | ||
| 78 | extern ktrace_entry_t *ktrace_skip(ktrace_t *, int, ktrace_snap_t *); | ||
| 79 | |||
| 80 | #else | ||
| 81 | #define ktrace_init(x) do { } while (0) | ||
| 82 | #define ktrace_uninit() do { } while (0) | ||
| 83 | #endif /* CONFIG_XFS_TRACE */ | ||
| 84 | |||
| 85 | #endif /* __XFS_SUPPORT_KTRACE_H__ */ | ||
diff --git a/fs/xfs/xfs.h b/fs/xfs/xfs.h index 17254b529c54..5ad8ad3a1dcd 100644 --- a/fs/xfs/xfs.h +++ b/fs/xfs/xfs.h | |||
| @@ -25,21 +25,5 @@ | |||
| 25 | /* #define QUOTADEBUG 1 */ | 25 | /* #define QUOTADEBUG 1 */ |
| 26 | #endif | 26 | #endif |
| 27 | 27 | ||
| 28 | #ifdef CONFIG_XFS_TRACE | ||
| 29 | #define XFS_ALLOC_TRACE 1 | ||
| 30 | #define XFS_ATTR_TRACE 1 | ||
| 31 | #define XFS_BLI_TRACE 1 | ||
| 32 | #define XFS_BMAP_TRACE 1 | ||
| 33 | #define XFS_BTREE_TRACE 1 | ||
| 34 | #define XFS_DIR2_TRACE 1 | ||
| 35 | #define XFS_DQUOT_TRACE 1 | ||
| 36 | #define XFS_ILOCK_TRACE 1 | ||
| 37 | #define XFS_LOG_TRACE 1 | ||
| 38 | #define XFS_RW_TRACE 1 | ||
| 39 | #define XFS_BUF_TRACE 1 | ||
| 40 | #define XFS_INODE_TRACE 1 | ||
| 41 | #define XFS_FILESTREAMS_TRACE 1 | ||
| 42 | #endif | ||
| 43 | |||
| 44 | #include <linux-2.6/xfs_linux.h> | 28 | #include <linux-2.6/xfs_linux.h> |
| 45 | #endif /* __XFS_H__ */ | 29 | #endif /* __XFS_H__ */ |
diff --git a/fs/xfs/xfs_ag.h b/fs/xfs/xfs_ag.h index a5d54bf4931b..6702bd865811 100644 --- a/fs/xfs/xfs_ag.h +++ b/fs/xfs/xfs_ag.h | |||
| @@ -86,6 +86,20 @@ typedef struct xfs_agf { | |||
| 86 | #define XFS_AGF_NUM_BITS 12 | 86 | #define XFS_AGF_NUM_BITS 12 |
| 87 | #define XFS_AGF_ALL_BITS ((1 << XFS_AGF_NUM_BITS) - 1) | 87 | #define XFS_AGF_ALL_BITS ((1 << XFS_AGF_NUM_BITS) - 1) |
| 88 | 88 | ||
| 89 | #define XFS_AGF_FLAGS \ | ||
| 90 | { XFS_AGF_MAGICNUM, "MAGICNUM" }, \ | ||
| 91 | { XFS_AGF_VERSIONNUM, "VERSIONNUM" }, \ | ||
| 92 | { XFS_AGF_SEQNO, "SEQNO" }, \ | ||
| 93 | { XFS_AGF_LENGTH, "LENGTH" }, \ | ||
| 94 | { XFS_AGF_ROOTS, "ROOTS" }, \ | ||
| 95 | { XFS_AGF_LEVELS, "LEVELS" }, \ | ||
| 96 | { XFS_AGF_FLFIRST, "FLFIRST" }, \ | ||
| 97 | { XFS_AGF_FLLAST, "FLLAST" }, \ | ||
| 98 | { XFS_AGF_FLCOUNT, "FLCOUNT" }, \ | ||
| 99 | { XFS_AGF_FREEBLKS, "FREEBLKS" }, \ | ||
| 100 | { XFS_AGF_LONGEST, "LONGEST" }, \ | ||
| 101 | { XFS_AGF_BTREEBLKS, "BTREEBLKS" } | ||
| 102 | |||
| 89 | /* disk block (xfs_daddr_t) in the AG */ | 103 | /* disk block (xfs_daddr_t) in the AG */ |
| 90 | #define XFS_AGF_DADDR(mp) ((xfs_daddr_t)(1 << (mp)->m_sectbb_log)) | 104 | #define XFS_AGF_DADDR(mp) ((xfs_daddr_t)(1 << (mp)->m_sectbb_log)) |
| 91 | #define XFS_AGF_BLOCK(mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp)) | 105 | #define XFS_AGF_BLOCK(mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp)) |
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c index 2cf944eb796d..a1c65fc6d9c4 100644 --- a/fs/xfs/xfs_alloc.c +++ b/fs/xfs/xfs_alloc.c | |||
| @@ -38,6 +38,7 @@ | |||
| 38 | #include "xfs_ialloc.h" | 38 | #include "xfs_ialloc.h" |
| 39 | #include "xfs_alloc.h" | 39 | #include "xfs_alloc.h" |
| 40 | #include "xfs_error.h" | 40 | #include "xfs_error.h" |
| 41 | #include "xfs_trace.h" | ||
| 41 | 42 | ||
| 42 | 43 | ||
| 43 | #define XFS_ABSDIFF(a,b) (((a) <= (b)) ? ((b) - (a)) : ((a) - (b))) | 44 | #define XFS_ABSDIFF(a,b) (((a) <= (b)) ? ((b) - (a)) : ((a) - (b))) |
| @@ -51,30 +52,6 @@ xfs_alloc_search_busy(xfs_trans_t *tp, | |||
| 51 | xfs_agblock_t bno, | 52 | xfs_agblock_t bno, |
| 52 | xfs_extlen_t len); | 53 | xfs_extlen_t len); |
| 53 | 54 | ||
| 54 | #if defined(XFS_ALLOC_TRACE) | ||
| 55 | ktrace_t *xfs_alloc_trace_buf; | ||
| 56 | |||
| 57 | #define TRACE_ALLOC(s,a) \ | ||
| 58 | xfs_alloc_trace_alloc(__func__, s, a, __LINE__) | ||
| 59 | #define TRACE_FREE(s,a,b,x,f) \ | ||
| 60 | xfs_alloc_trace_free(__func__, s, mp, a, b, x, f, __LINE__) | ||
| 61 | #define TRACE_MODAGF(s,a,f) \ | ||
| 62 | xfs_alloc_trace_modagf(__func__, s, mp, a, f, __LINE__) | ||
| 63 | #define TRACE_BUSY(__func__,s,ag,agb,l,sl,tp) \ | ||
| 64 | xfs_alloc_trace_busy(__func__, s, mp, ag, agb, l, sl, tp, XFS_ALLOC_KTRACE_BUSY, __LINE__) | ||
| 65 | #define TRACE_UNBUSY(__func__,s,ag,sl,tp) \ | ||
| 66 | xfs_alloc_trace_busy(__func__, s, mp, ag, -1, -1, sl, tp, XFS_ALLOC_KTRACE_UNBUSY, __LINE__) | ||
| 67 | #define TRACE_BUSYSEARCH(__func__,s,ag,agb,l,tp) \ | ||
| 68 | xfs_alloc_trace_busy(__func__, s, mp, ag, agb, l, 0, tp, XFS_ALLOC_KTRACE_BUSYSEARCH, __LINE__) | ||
| 69 | #else | ||
| 70 | #define TRACE_ALLOC(s,a) | ||
| 71 | #define TRACE_FREE(s,a,b,x,f) | ||
| 72 | #define TRACE_MODAGF(s,a,f) | ||
| 73 | #define TRACE_BUSY(s,a,ag,agb,l,sl,tp) | ||
| 74 | #define TRACE_UNBUSY(fname,s,ag,sl,tp) | ||
| 75 | #define TRACE_BUSYSEARCH(fname,s,ag,agb,l,tp) | ||
| 76 | #endif /* XFS_ALLOC_TRACE */ | ||
| 77 | |||
| 78 | /* | 55 | /* |
| 79 | * Prototypes for per-ag allocation routines | 56 | * Prototypes for per-ag allocation routines |
| 80 | */ | 57 | */ |
| @@ -498,124 +475,6 @@ xfs_alloc_read_agfl( | |||
| 498 | return 0; | 475 | return 0; |
| 499 | } | 476 | } |
| 500 | 477 | ||
| 501 | #if defined(XFS_ALLOC_TRACE) | ||
| 502 | /* | ||
| 503 | * Add an allocation trace entry for an alloc call. | ||
| 504 | */ | ||
| 505 | STATIC void | ||
| 506 | xfs_alloc_trace_alloc( | ||
| 507 | const char *name, /* function tag string */ | ||
| 508 | char *str, /* additional string */ | ||
| 509 | xfs_alloc_arg_t *args, /* allocation argument structure */ | ||
| 510 | int line) /* source line number */ | ||
| 511 | { | ||
| 512 | ktrace_enter(xfs_alloc_trace_buf, | ||
| 513 | (void *)(__psint_t)(XFS_ALLOC_KTRACE_ALLOC | (line << 16)), | ||
| 514 | (void *)name, | ||
| 515 | (void *)str, | ||
| 516 | (void *)args->mp, | ||
| 517 | (void *)(__psunsigned_t)args->agno, | ||
| 518 | (void *)(__psunsigned_t)args->agbno, | ||
| 519 | (void *)(__psunsigned_t)args->minlen, | ||
| 520 | (void *)(__psunsigned_t)args->maxlen, | ||
| 521 | (void *)(__psunsigned_t)args->mod, | ||
| 522 | (void *)(__psunsigned_t)args->prod, | ||
| 523 | (void *)(__psunsigned_t)args->minleft, | ||
| 524 | (void *)(__psunsigned_t)args->total, | ||
| 525 | (void *)(__psunsigned_t)args->alignment, | ||
| 526 | (void *)(__psunsigned_t)args->len, | ||
| 527 | (void *)((((__psint_t)args->type) << 16) | | ||
| 528 | (__psint_t)args->otype), | ||
| 529 | (void *)(__psint_t)((args->wasdel << 3) | | ||
| 530 | (args->wasfromfl << 2) | | ||
| 531 | (args->isfl << 1) | | ||
| 532 | (args->userdata << 0))); | ||
| 533 | } | ||
| 534 | |||
| 535 | /* | ||
| 536 | * Add an allocation trace entry for a free call. | ||
| 537 | */ | ||
| 538 | STATIC void | ||
| 539 | xfs_alloc_trace_free( | ||
| 540 | const char *name, /* function tag string */ | ||
| 541 | char *str, /* additional string */ | ||
| 542 | xfs_mount_t *mp, /* file system mount point */ | ||
| 543 | xfs_agnumber_t agno, /* allocation group number */ | ||
| 544 | xfs_agblock_t agbno, /* a.g. relative block number */ | ||
| 545 | xfs_extlen_t len, /* length of extent */ | ||
| 546 | int isfl, /* set if is freelist allocation/free */ | ||
| 547 | int line) /* source line number */ | ||
| 548 | { | ||
| 549 | ktrace_enter(xfs_alloc_trace_buf, | ||
| 550 | (void *)(__psint_t)(XFS_ALLOC_KTRACE_FREE | (line << 16)), | ||
| 551 | (void *)name, | ||
| 552 | (void *)str, | ||
| 553 | (void *)mp, | ||
| 554 | (void *)(__psunsigned_t)agno, | ||
| 555 | (void *)(__psunsigned_t)agbno, | ||
| 556 | (void *)(__psunsigned_t)len, | ||
| 557 | (void *)(__psint_t)isfl, | ||
| 558 | NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); | ||
| 559 | } | ||
| 560 | |||
| 561 | /* | ||
| 562 | * Add an allocation trace entry for modifying an agf. | ||
| 563 | */ | ||
| 564 | STATIC void | ||
| 565 | xfs_alloc_trace_modagf( | ||
| 566 | const char *name, /* function tag string */ | ||
| 567 | char *str, /* additional string */ | ||
| 568 | xfs_mount_t *mp, /* file system mount point */ | ||
| 569 | xfs_agf_t *agf, /* new agf value */ | ||
| 570 | int flags, /* logging flags for agf */ | ||
| 571 | int line) /* source line number */ | ||
| 572 | { | ||
| 573 | ktrace_enter(xfs_alloc_trace_buf, | ||
| 574 | (void *)(__psint_t)(XFS_ALLOC_KTRACE_MODAGF | (line << 16)), | ||
| 575 | (void *)name, | ||
| 576 | (void *)str, | ||
| 577 | (void *)mp, | ||
| 578 | (void *)(__psint_t)flags, | ||
| 579 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_seqno), | ||
| 580 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_length), | ||
| 581 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_roots[XFS_BTNUM_BNO]), | ||
| 582 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_roots[XFS_BTNUM_CNT]), | ||
| 583 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_levels[XFS_BTNUM_BNO]), | ||
| 584 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_levels[XFS_BTNUM_CNT]), | ||
| 585 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_flfirst), | ||
| 586 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_fllast), | ||
| 587 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_flcount), | ||
| 588 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_freeblks), | ||
| 589 | (void *)(__psunsigned_t)be32_to_cpu(agf->agf_longest)); | ||
| 590 | } | ||
| 591 | |||
| 592 | STATIC void | ||
| 593 | xfs_alloc_trace_busy( | ||
| 594 | const char *name, /* function tag string */ | ||
| 595 | char *str, /* additional string */ | ||
| 596 | xfs_mount_t *mp, /* file system mount point */ | ||
| 597 | xfs_agnumber_t agno, /* allocation group number */ | ||
| 598 | xfs_agblock_t agbno, /* a.g. relative block number */ | ||
| 599 | xfs_extlen_t len, /* length of extent */ | ||
| 600 | int slot, /* perag Busy slot */ | ||
| 601 | xfs_trans_t *tp, | ||
| 602 | int trtype, /* type: add, delete, search */ | ||
| 603 | int line) /* source line number */ | ||
| 604 | { | ||
| 605 | ktrace_enter(xfs_alloc_trace_buf, | ||
| 606 | (void *)(__psint_t)(trtype | (line << 16)), | ||
| 607 | (void *)name, | ||
| 608 | (void *)str, | ||
| 609 | (void *)mp, | ||
| 610 | (void *)(__psunsigned_t)agno, | ||
| 611 | (void *)(__psunsigned_t)agbno, | ||
| 612 | (void *)(__psunsigned_t)len, | ||
| 613 | (void *)(__psint_t)slot, | ||
| 614 | (void *)tp, | ||
| 615 | NULL, NULL, NULL, NULL, NULL, NULL, NULL); | ||
| 616 | } | ||
| 617 | #endif /* XFS_ALLOC_TRACE */ | ||
| 618 | |||
| 619 | /* | 478 | /* |
| 620 | * Allocation group level functions. | 479 | * Allocation group level functions. |
| 621 | */ | 480 | */ |
| @@ -665,9 +524,6 @@ xfs_alloc_ag_vextent( | |||
| 665 | */ | 524 | */ |
| 666 | if (args->agbno != NULLAGBLOCK) { | 525 | if (args->agbno != NULLAGBLOCK) { |
| 667 | xfs_agf_t *agf; /* allocation group freelist header */ | 526 | xfs_agf_t *agf; /* allocation group freelist header */ |
| 668 | #ifdef XFS_ALLOC_TRACE | ||
| 669 | xfs_mount_t *mp = args->mp; | ||
| 670 | #endif | ||
| 671 | long slen = (long)args->len; | 527 | long slen = (long)args->len; |
| 672 | 528 | ||
| 673 | ASSERT(args->len >= args->minlen && args->len <= args->maxlen); | 529 | ASSERT(args->len >= args->minlen && args->len <= args->maxlen); |
| @@ -682,7 +538,6 @@ xfs_alloc_ag_vextent( | |||
| 682 | args->pag->pagf_freeblks -= args->len; | 538 | args->pag->pagf_freeblks -= args->len; |
| 683 | ASSERT(be32_to_cpu(agf->agf_freeblks) <= | 539 | ASSERT(be32_to_cpu(agf->agf_freeblks) <= |
| 684 | be32_to_cpu(agf->agf_length)); | 540 | be32_to_cpu(agf->agf_length)); |
| 685 | TRACE_MODAGF(NULL, agf, XFS_AGF_FREEBLKS); | ||
| 686 | xfs_alloc_log_agf(args->tp, args->agbp, | 541 | xfs_alloc_log_agf(args->tp, args->agbp, |
| 687 | XFS_AGF_FREEBLKS); | 542 | XFS_AGF_FREEBLKS); |
| 688 | /* search the busylist for these blocks */ | 543 | /* search the busylist for these blocks */ |
| @@ -792,13 +647,14 @@ xfs_alloc_ag_vextent_exact( | |||
| 792 | } | 647 | } |
| 793 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_NOERROR); | 648 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_NOERROR); |
| 794 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 649 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 795 | TRACE_ALLOC("normal", args); | 650 | |
| 651 | trace_xfs_alloc_exact_done(args); | ||
| 796 | args->wasfromfl = 0; | 652 | args->wasfromfl = 0; |
| 797 | return 0; | 653 | return 0; |
| 798 | 654 | ||
| 799 | error0: | 655 | error0: |
| 800 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_ERROR); | 656 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_ERROR); |
| 801 | TRACE_ALLOC("error", args); | 657 | trace_xfs_alloc_exact_error(args); |
| 802 | return error; | 658 | return error; |
| 803 | } | 659 | } |
| 804 | 660 | ||
| @@ -958,7 +814,7 @@ xfs_alloc_ag_vextent_near( | |||
| 958 | args->len = blen; | 814 | args->len = blen; |
| 959 | if (!xfs_alloc_fix_minleft(args)) { | 815 | if (!xfs_alloc_fix_minleft(args)) { |
| 960 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 816 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 961 | TRACE_ALLOC("nominleft", args); | 817 | trace_xfs_alloc_near_nominleft(args); |
| 962 | return 0; | 818 | return 0; |
| 963 | } | 819 | } |
| 964 | blen = args->len; | 820 | blen = args->len; |
| @@ -981,7 +837,8 @@ xfs_alloc_ag_vextent_near( | |||
| 981 | goto error0; | 837 | goto error0; |
| 982 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 838 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 983 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); | 839 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); |
| 984 | TRACE_ALLOC("first", args); | 840 | |
| 841 | trace_xfs_alloc_near_first(args); | ||
| 985 | return 0; | 842 | return 0; |
| 986 | } | 843 | } |
| 987 | /* | 844 | /* |
| @@ -1272,7 +1129,7 @@ xfs_alloc_ag_vextent_near( | |||
| 1272 | * If we couldn't get anything, give up. | 1129 | * If we couldn't get anything, give up. |
| 1273 | */ | 1130 | */ |
| 1274 | if (bno_cur_lt == NULL && bno_cur_gt == NULL) { | 1131 | if (bno_cur_lt == NULL && bno_cur_gt == NULL) { |
| 1275 | TRACE_ALLOC("neither", args); | 1132 | trace_xfs_alloc_size_neither(args); |
| 1276 | args->agbno = NULLAGBLOCK; | 1133 | args->agbno = NULLAGBLOCK; |
| 1277 | return 0; | 1134 | return 0; |
| 1278 | } | 1135 | } |
| @@ -1299,7 +1156,7 @@ xfs_alloc_ag_vextent_near( | |||
| 1299 | args->len = XFS_EXTLEN_MIN(ltlena, args->maxlen); | 1156 | args->len = XFS_EXTLEN_MIN(ltlena, args->maxlen); |
| 1300 | xfs_alloc_fix_len(args); | 1157 | xfs_alloc_fix_len(args); |
| 1301 | if (!xfs_alloc_fix_minleft(args)) { | 1158 | if (!xfs_alloc_fix_minleft(args)) { |
| 1302 | TRACE_ALLOC("nominleft", args); | 1159 | trace_xfs_alloc_near_nominleft(args); |
| 1303 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); | 1160 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); |
| 1304 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 1161 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 1305 | return 0; | 1162 | return 0; |
| @@ -1314,13 +1171,18 @@ xfs_alloc_ag_vextent_near( | |||
| 1314 | if ((error = xfs_alloc_fixup_trees(cnt_cur, bno_cur_lt, ltbno, ltlen, | 1171 | if ((error = xfs_alloc_fixup_trees(cnt_cur, bno_cur_lt, ltbno, ltlen, |
| 1315 | ltnew, rlen, XFSA_FIXUP_BNO_OK))) | 1172 | ltnew, rlen, XFSA_FIXUP_BNO_OK))) |
| 1316 | goto error0; | 1173 | goto error0; |
| 1317 | TRACE_ALLOC(j ? "gt" : "lt", args); | 1174 | |
| 1175 | if (j) | ||
| 1176 | trace_xfs_alloc_near_greater(args); | ||
| 1177 | else | ||
| 1178 | trace_xfs_alloc_near_lesser(args); | ||
| 1179 | |||
| 1318 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 1180 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 1319 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); | 1181 | xfs_btree_del_cursor(bno_cur_lt, XFS_BTREE_NOERROR); |
| 1320 | return 0; | 1182 | return 0; |
| 1321 | 1183 | ||
| 1322 | error0: | 1184 | error0: |
| 1323 | TRACE_ALLOC("error", args); | 1185 | trace_xfs_alloc_near_error(args); |
| 1324 | if (cnt_cur != NULL) | 1186 | if (cnt_cur != NULL) |
| 1325 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_ERROR); | 1187 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_ERROR); |
| 1326 | if (bno_cur_lt != NULL) | 1188 | if (bno_cur_lt != NULL) |
| @@ -1371,7 +1233,7 @@ xfs_alloc_ag_vextent_size( | |||
| 1371 | goto error0; | 1233 | goto error0; |
| 1372 | if (i == 0 || flen == 0) { | 1234 | if (i == 0 || flen == 0) { |
| 1373 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 1235 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 1374 | TRACE_ALLOC("noentry", args); | 1236 | trace_xfs_alloc_size_noentry(args); |
| 1375 | return 0; | 1237 | return 0; |
| 1376 | } | 1238 | } |
| 1377 | ASSERT(i == 1); | 1239 | ASSERT(i == 1); |
| @@ -1448,7 +1310,7 @@ xfs_alloc_ag_vextent_size( | |||
| 1448 | xfs_alloc_fix_len(args); | 1310 | xfs_alloc_fix_len(args); |
| 1449 | if (rlen < args->minlen || !xfs_alloc_fix_minleft(args)) { | 1311 | if (rlen < args->minlen || !xfs_alloc_fix_minleft(args)) { |
| 1450 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | 1312 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); |
| 1451 | TRACE_ALLOC("nominleft", args); | 1313 | trace_xfs_alloc_size_nominleft(args); |
| 1452 | args->agbno = NULLAGBLOCK; | 1314 | args->agbno = NULLAGBLOCK; |
| 1453 | return 0; | 1315 | return 0; |
| 1454 | } | 1316 | } |
| @@ -1471,11 +1333,11 @@ xfs_alloc_ag_vextent_size( | |||
| 1471 | args->agbno + args->len <= | 1333 | args->agbno + args->len <= |
| 1472 | be32_to_cpu(XFS_BUF_TO_AGF(args->agbp)->agf_length), | 1334 | be32_to_cpu(XFS_BUF_TO_AGF(args->agbp)->agf_length), |
| 1473 | error0); | 1335 | error0); |
| 1474 | TRACE_ALLOC("normal", args); | 1336 | trace_xfs_alloc_size_done(args); |
| 1475 | return 0; | 1337 | return 0; |
| 1476 | 1338 | ||
| 1477 | error0: | 1339 | error0: |
| 1478 | TRACE_ALLOC("error", args); | 1340 | trace_xfs_alloc_size_error(args); |
| 1479 | if (cnt_cur) | 1341 | if (cnt_cur) |
| 1480 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_ERROR); | 1342 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_ERROR); |
| 1481 | if (bno_cur) | 1343 | if (bno_cur) |
| @@ -1534,7 +1396,7 @@ xfs_alloc_ag_vextent_small( | |||
| 1534 | be32_to_cpu(XFS_BUF_TO_AGF(args->agbp)->agf_length), | 1396 | be32_to_cpu(XFS_BUF_TO_AGF(args->agbp)->agf_length), |
| 1535 | error0); | 1397 | error0); |
| 1536 | args->wasfromfl = 1; | 1398 | args->wasfromfl = 1; |
| 1537 | TRACE_ALLOC("freelist", args); | 1399 | trace_xfs_alloc_small_freelist(args); |
| 1538 | *stat = 0; | 1400 | *stat = 0; |
| 1539 | return 0; | 1401 | return 0; |
| 1540 | } | 1402 | } |
| @@ -1556,17 +1418,17 @@ xfs_alloc_ag_vextent_small( | |||
| 1556 | */ | 1418 | */ |
| 1557 | if (flen < args->minlen) { | 1419 | if (flen < args->minlen) { |
| 1558 | args->agbno = NULLAGBLOCK; | 1420 | args->agbno = NULLAGBLOCK; |
| 1559 | TRACE_ALLOC("notenough", args); | 1421 | trace_xfs_alloc_small_notenough(args); |
| 1560 | flen = 0; | 1422 | flen = 0; |
| 1561 | } | 1423 | } |
| 1562 | *fbnop = fbno; | 1424 | *fbnop = fbno; |
| 1563 | *flenp = flen; | 1425 | *flenp = flen; |
| 1564 | *stat = 1; | 1426 | *stat = 1; |
| 1565 | TRACE_ALLOC("normal", args); | 1427 | trace_xfs_alloc_small_done(args); |
| 1566 | return 0; | 1428 | return 0; |
| 1567 | 1429 | ||
| 1568 | error0: | 1430 | error0: |
| 1569 | TRACE_ALLOC("error", args); | 1431 | trace_xfs_alloc_small_error(args); |
| 1570 | return error; | 1432 | return error; |
| 1571 | } | 1433 | } |
| 1572 | 1434 | ||
| @@ -1809,17 +1671,14 @@ xfs_free_ag_extent( | |||
| 1809 | be32_to_cpu(agf->agf_freeblks) <= | 1671 | be32_to_cpu(agf->agf_freeblks) <= |
| 1810 | be32_to_cpu(agf->agf_length), | 1672 | be32_to_cpu(agf->agf_length), |
| 1811 | error0); | 1673 | error0); |
| 1812 | TRACE_MODAGF(NULL, agf, XFS_AGF_FREEBLKS); | ||
| 1813 | xfs_alloc_log_agf(tp, agbp, XFS_AGF_FREEBLKS); | 1674 | xfs_alloc_log_agf(tp, agbp, XFS_AGF_FREEBLKS); |
| 1814 | if (!isfl) | 1675 | if (!isfl) |
| 1815 | xfs_trans_mod_sb(tp, XFS_TRANS_SB_FDBLOCKS, (long)len); | 1676 | xfs_trans_mod_sb(tp, XFS_TRANS_SB_FDBLOCKS, (long)len); |
| 1816 | XFS_STATS_INC(xs_freex); | 1677 | XFS_STATS_INC(xs_freex); |
| 1817 | XFS_STATS_ADD(xs_freeb, len); | 1678 | XFS_STATS_ADD(xs_freeb, len); |
| 1818 | } | 1679 | } |
| 1819 | TRACE_FREE(haveleft ? | 1680 | |
| 1820 | (haveright ? "both" : "left") : | 1681 | trace_xfs_free_extent(mp, agno, bno, len, isfl, haveleft, haveright); |
| 1821 | (haveright ? "right" : "none"), | ||
| 1822 | agno, bno, len, isfl); | ||
| 1823 | 1682 | ||
| 1824 | /* | 1683 | /* |
| 1825 | * Since blocks move to the free list without the coordination | 1684 | * Since blocks move to the free list without the coordination |
| @@ -1836,7 +1695,7 @@ xfs_free_ag_extent( | |||
| 1836 | return 0; | 1695 | return 0; |
| 1837 | 1696 | ||
| 1838 | error0: | 1697 | error0: |
| 1839 | TRACE_FREE("error", agno, bno, len, isfl); | 1698 | trace_xfs_free_extent(mp, agno, bno, len, isfl, -1, -1); |
| 1840 | if (bno_cur) | 1699 | if (bno_cur) |
| 1841 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_ERROR); | 1700 | xfs_btree_del_cursor(bno_cur, XFS_BTREE_ERROR); |
| 1842 | if (cnt_cur) | 1701 | if (cnt_cur) |
| @@ -2122,7 +1981,6 @@ xfs_alloc_get_freelist( | |||
| 2122 | logflags |= XFS_AGF_BTREEBLKS; | 1981 | logflags |= XFS_AGF_BTREEBLKS; |
| 2123 | } | 1982 | } |
| 2124 | 1983 | ||
| 2125 | TRACE_MODAGF(NULL, agf, logflags); | ||
| 2126 | xfs_alloc_log_agf(tp, agbp, logflags); | 1984 | xfs_alloc_log_agf(tp, agbp, logflags); |
| 2127 | *bnop = bno; | 1985 | *bnop = bno; |
| 2128 | 1986 | ||
| @@ -2165,6 +2023,8 @@ xfs_alloc_log_agf( | |||
| 2165 | sizeof(xfs_agf_t) | 2023 | sizeof(xfs_agf_t) |
| 2166 | }; | 2024 | }; |
| 2167 | 2025 | ||
| 2026 | trace_xfs_agf(tp->t_mountp, XFS_BUF_TO_AGF(bp), fields, _RET_IP_); | ||
| 2027 | |||
| 2168 | xfs_btree_offsets(fields, offsets, XFS_AGF_NUM_BITS, &first, &last); | 2028 | xfs_btree_offsets(fields, offsets, XFS_AGF_NUM_BITS, &first, &last); |
| 2169 | xfs_trans_log_buf(tp, bp, (uint)first, (uint)last); | 2029 | xfs_trans_log_buf(tp, bp, (uint)first, (uint)last); |
| 2170 | } | 2030 | } |
| @@ -2230,13 +2090,11 @@ xfs_alloc_put_freelist( | |||
| 2230 | logflags |= XFS_AGF_BTREEBLKS; | 2090 | logflags |= XFS_AGF_BTREEBLKS; |
| 2231 | } | 2091 | } |
| 2232 | 2092 | ||
| 2233 | TRACE_MODAGF(NULL, agf, logflags); | ||
| 2234 | xfs_alloc_log_agf(tp, agbp, logflags); | 2093 | xfs_alloc_log_agf(tp, agbp, logflags); |
| 2235 | 2094 | ||
| 2236 | ASSERT(be32_to_cpu(agf->agf_flcount) <= XFS_AGFL_SIZE(mp)); | 2095 | ASSERT(be32_to_cpu(agf->agf_flcount) <= XFS_AGFL_SIZE(mp)); |
| 2237 | blockp = &agfl->agfl_bno[be32_to_cpu(agf->agf_fllast)]; | 2096 | blockp = &agfl->agfl_bno[be32_to_cpu(agf->agf_fllast)]; |
| 2238 | *blockp = cpu_to_be32(bno); | 2097 | *blockp = cpu_to_be32(bno); |
| 2239 | TRACE_MODAGF(NULL, agf, logflags); | ||
| 2240 | xfs_alloc_log_agf(tp, agbp, logflags); | 2098 | xfs_alloc_log_agf(tp, agbp, logflags); |
| 2241 | xfs_trans_log_buf(tp, agflbp, | 2099 | xfs_trans_log_buf(tp, agflbp, |
| 2242 | (int)((xfs_caddr_t)blockp - (xfs_caddr_t)agfl), | 2100 | (int)((xfs_caddr_t)blockp - (xfs_caddr_t)agfl), |
| @@ -2399,7 +2257,7 @@ xfs_alloc_vextent( | |||
| 2399 | args->minlen > args->maxlen || args->minlen > agsize || | 2257 | args->minlen > args->maxlen || args->minlen > agsize || |
| 2400 | args->mod >= args->prod) { | 2258 | args->mod >= args->prod) { |
| 2401 | args->fsbno = NULLFSBLOCK; | 2259 | args->fsbno = NULLFSBLOCK; |
| 2402 | TRACE_ALLOC("badargs", args); | 2260 | trace_xfs_alloc_vextent_badargs(args); |
| 2403 | return 0; | 2261 | return 0; |
| 2404 | } | 2262 | } |
| 2405 | minleft = args->minleft; | 2263 | minleft = args->minleft; |
| @@ -2418,12 +2276,12 @@ xfs_alloc_vextent( | |||
| 2418 | error = xfs_alloc_fix_freelist(args, 0); | 2276 | error = xfs_alloc_fix_freelist(args, 0); |
| 2419 | args->minleft = minleft; | 2277 | args->minleft = minleft; |
| 2420 | if (error) { | 2278 | if (error) { |
| 2421 | TRACE_ALLOC("nofix", args); | 2279 | trace_xfs_alloc_vextent_nofix(args); |
| 2422 | goto error0; | 2280 | goto error0; |
| 2423 | } | 2281 | } |
| 2424 | if (!args->agbp) { | 2282 | if (!args->agbp) { |
| 2425 | up_read(&mp->m_peraglock); | 2283 | up_read(&mp->m_peraglock); |
| 2426 | TRACE_ALLOC("noagbp", args); | 2284 | trace_xfs_alloc_vextent_noagbp(args); |
| 2427 | break; | 2285 | break; |
| 2428 | } | 2286 | } |
| 2429 | args->agbno = XFS_FSB_TO_AGBNO(mp, args->fsbno); | 2287 | args->agbno = XFS_FSB_TO_AGBNO(mp, args->fsbno); |
| @@ -2488,7 +2346,7 @@ xfs_alloc_vextent( | |||
| 2488 | error = xfs_alloc_fix_freelist(args, flags); | 2346 | error = xfs_alloc_fix_freelist(args, flags); |
| 2489 | args->minleft = minleft; | 2347 | args->minleft = minleft; |
| 2490 | if (error) { | 2348 | if (error) { |
| 2491 | TRACE_ALLOC("nofix", args); | 2349 | trace_xfs_alloc_vextent_nofix(args); |
| 2492 | goto error0; | 2350 | goto error0; |
| 2493 | } | 2351 | } |
| 2494 | /* | 2352 | /* |
| @@ -2499,7 +2357,9 @@ xfs_alloc_vextent( | |||
| 2499 | goto error0; | 2357 | goto error0; |
| 2500 | break; | 2358 | break; |
| 2501 | } | 2359 | } |
| 2502 | TRACE_ALLOC("loopfailed", args); | 2360 | |
| 2361 | trace_xfs_alloc_vextent_loopfailed(args); | ||
| 2362 | |||
| 2503 | /* | 2363 | /* |
| 2504 | * Didn't work, figure out the next iteration. | 2364 | * Didn't work, figure out the next iteration. |
| 2505 | */ | 2365 | */ |
| @@ -2526,7 +2386,7 @@ xfs_alloc_vextent( | |||
| 2526 | if (args->agno == sagno) { | 2386 | if (args->agno == sagno) { |
| 2527 | if (no_min == 1) { | 2387 | if (no_min == 1) { |
| 2528 | args->agbno = NULLAGBLOCK; | 2388 | args->agbno = NULLAGBLOCK; |
| 2529 | TRACE_ALLOC("allfailed", args); | 2389 | trace_xfs_alloc_vextent_allfailed(args); |
| 2530 | break; | 2390 | break; |
| 2531 | } | 2391 | } |
| 2532 | if (flags == 0) { | 2392 | if (flags == 0) { |
| @@ -2642,16 +2502,16 @@ xfs_alloc_mark_busy(xfs_trans_t *tp, | |||
| 2642 | } | 2502 | } |
| 2643 | } | 2503 | } |
| 2644 | 2504 | ||
| 2505 | trace_xfs_alloc_busy(mp, agno, bno, len, n); | ||
| 2506 | |||
| 2645 | if (n < XFS_PAGB_NUM_SLOTS) { | 2507 | if (n < XFS_PAGB_NUM_SLOTS) { |
| 2646 | bsy = &mp->m_perag[agno].pagb_list[n]; | 2508 | bsy = &mp->m_perag[agno].pagb_list[n]; |
| 2647 | mp->m_perag[agno].pagb_count++; | 2509 | mp->m_perag[agno].pagb_count++; |
| 2648 | TRACE_BUSY("xfs_alloc_mark_busy", "got", agno, bno, len, n, tp); | ||
| 2649 | bsy->busy_start = bno; | 2510 | bsy->busy_start = bno; |
| 2650 | bsy->busy_length = len; | 2511 | bsy->busy_length = len; |
| 2651 | bsy->busy_tp = tp; | 2512 | bsy->busy_tp = tp; |
| 2652 | xfs_trans_add_busy(tp, agno, n); | 2513 | xfs_trans_add_busy(tp, agno, n); |
| 2653 | } else { | 2514 | } else { |
| 2654 | TRACE_BUSY("xfs_alloc_mark_busy", "FULL", agno, bno, len, -1, tp); | ||
| 2655 | /* | 2515 | /* |
| 2656 | * The busy list is full! Since it is now not possible to | 2516 | * The busy list is full! Since it is now not possible to |
| 2657 | * track the free block, make this a synchronous transaction | 2517 | * track the free block, make this a synchronous transaction |
| @@ -2678,12 +2538,12 @@ xfs_alloc_clear_busy(xfs_trans_t *tp, | |||
| 2678 | list = mp->m_perag[agno].pagb_list; | 2538 | list = mp->m_perag[agno].pagb_list; |
| 2679 | 2539 | ||
| 2680 | ASSERT(idx < XFS_PAGB_NUM_SLOTS); | 2540 | ASSERT(idx < XFS_PAGB_NUM_SLOTS); |
| 2541 | |||
| 2542 | trace_xfs_alloc_unbusy(mp, agno, idx, list[idx].busy_tp == tp); | ||
| 2543 | |||
| 2681 | if (list[idx].busy_tp == tp) { | 2544 | if (list[idx].busy_tp == tp) { |
| 2682 | TRACE_UNBUSY("xfs_alloc_clear_busy", "found", agno, idx, tp); | ||
| 2683 | list[idx].busy_tp = NULL; | 2545 | list[idx].busy_tp = NULL; |
| 2684 | mp->m_perag[agno].pagb_count--; | 2546 | mp->m_perag[agno].pagb_count--; |
| 2685 | } else { | ||
| 2686 | TRACE_UNBUSY("xfs_alloc_clear_busy", "missing", agno, idx, tp); | ||
| 2687 | } | 2547 | } |
| 2688 | 2548 | ||
| 2689 | spin_unlock(&mp->m_perag[agno].pagb_lock); | 2549 | spin_unlock(&mp->m_perag[agno].pagb_lock); |
| @@ -2724,24 +2584,22 @@ xfs_alloc_search_busy(xfs_trans_t *tp, | |||
| 2724 | if ((bno > bend) || (uend < bsy->busy_start)) { | 2584 | if ((bno > bend) || (uend < bsy->busy_start)) { |
| 2725 | cnt--; | 2585 | cnt--; |
| 2726 | } else { | 2586 | } else { |
| 2727 | TRACE_BUSYSEARCH("xfs_alloc_search_busy", | ||
| 2728 | "found1", agno, bno, len, tp); | ||
| 2729 | break; | 2587 | break; |
| 2730 | } | 2588 | } |
| 2731 | } | 2589 | } |
| 2732 | } | 2590 | } |
| 2733 | 2591 | ||
| 2592 | trace_xfs_alloc_busysearch(mp, agno, bno, len, !!cnt); | ||
| 2593 | |||
| 2734 | /* | 2594 | /* |
| 2735 | * If a block was found, force the log through the LSN of the | 2595 | * If a block was found, force the log through the LSN of the |
| 2736 | * transaction that freed the block | 2596 | * transaction that freed the block |
| 2737 | */ | 2597 | */ |
| 2738 | if (cnt) { | 2598 | if (cnt) { |
| 2739 | TRACE_BUSYSEARCH("xfs_alloc_search_busy", "found", agno, bno, len, tp); | ||
| 2740 | lsn = bsy->busy_tp->t_commit_lsn; | 2599 | lsn = bsy->busy_tp->t_commit_lsn; |
| 2741 | spin_unlock(&mp->m_perag[agno].pagb_lock); | 2600 | spin_unlock(&mp->m_perag[agno].pagb_lock); |
| 2742 | xfs_log_force(mp, lsn, XFS_LOG_FORCE|XFS_LOG_SYNC); | 2601 | xfs_log_force(mp, lsn, XFS_LOG_FORCE|XFS_LOG_SYNC); |
| 2743 | } else { | 2602 | } else { |
| 2744 | TRACE_BUSYSEARCH("xfs_alloc_search_busy", "not-found", agno, bno, len, tp); | ||
| 2745 | spin_unlock(&mp->m_perag[agno].pagb_lock); | 2603 | spin_unlock(&mp->m_perag[agno].pagb_lock); |
| 2746 | } | 2604 | } |
| 2747 | } | 2605 | } |
diff --git a/fs/xfs/xfs_alloc.h b/fs/xfs/xfs_alloc.h index e704caee10df..599bffa39784 100644 --- a/fs/xfs/xfs_alloc.h +++ b/fs/xfs/xfs_alloc.h | |||
| @@ -37,6 +37,15 @@ typedef enum xfs_alloctype | |||
| 37 | XFS_ALLOCTYPE_THIS_BNO /* at exactly this block */ | 37 | XFS_ALLOCTYPE_THIS_BNO /* at exactly this block */ |
| 38 | } xfs_alloctype_t; | 38 | } xfs_alloctype_t; |
| 39 | 39 | ||
| 40 | #define XFS_ALLOC_TYPES \ | ||
| 41 | { XFS_ALLOCTYPE_ANY_AG, "ANY_AG" }, \ | ||
| 42 | { XFS_ALLOCTYPE_FIRST_AG, "FIRST_AG" }, \ | ||
| 43 | { XFS_ALLOCTYPE_START_AG, "START_AG" }, \ | ||
| 44 | { XFS_ALLOCTYPE_THIS_AG, "THIS_AG" }, \ | ||
| 45 | { XFS_ALLOCTYPE_START_BNO, "START_BNO" }, \ | ||
| 46 | { XFS_ALLOCTYPE_NEAR_BNO, "NEAR_BNO" }, \ | ||
| 47 | { XFS_ALLOCTYPE_THIS_BNO, "THIS_BNO" } | ||
| 48 | |||
| 40 | /* | 49 | /* |
| 41 | * Flags for xfs_alloc_fix_freelist. | 50 | * Flags for xfs_alloc_fix_freelist. |
| 42 | */ | 51 | */ |
| @@ -109,24 +118,6 @@ xfs_alloc_longest_free_extent(struct xfs_mount *mp, | |||
| 109 | 118 | ||
| 110 | #ifdef __KERNEL__ | 119 | #ifdef __KERNEL__ |
| 111 | 120 | ||
| 112 | #if defined(XFS_ALLOC_TRACE) | ||
| 113 | /* | ||
| 114 | * Allocation tracing buffer size. | ||
| 115 | */ | ||
| 116 | #define XFS_ALLOC_TRACE_SIZE 4096 | ||
| 117 | extern ktrace_t *xfs_alloc_trace_buf; | ||
| 118 | |||
| 119 | /* | ||
| 120 | * Types for alloc tracing. | ||
| 121 | */ | ||
| 122 | #define XFS_ALLOC_KTRACE_ALLOC 1 | ||
| 123 | #define XFS_ALLOC_KTRACE_FREE 2 | ||
| 124 | #define XFS_ALLOC_KTRACE_MODAGF 3 | ||
| 125 | #define XFS_ALLOC_KTRACE_BUSY 4 | ||
| 126 | #define XFS_ALLOC_KTRACE_UNBUSY 5 | ||
| 127 | #define XFS_ALLOC_KTRACE_BUSYSEARCH 6 | ||
| 128 | #endif | ||
| 129 | |||
| 130 | void | 121 | void |
| 131 | xfs_alloc_mark_busy(xfs_trans_t *tp, | 122 | xfs_alloc_mark_busy(xfs_trans_t *tp, |
| 132 | xfs_agnumber_t agno, | 123 | xfs_agnumber_t agno, |
diff --git a/fs/xfs/xfs_alloc_btree.c b/fs/xfs/xfs_alloc_btree.c index c10c3a292d30..adbd9141aea1 100644 --- a/fs/xfs/xfs_alloc_btree.c +++ b/fs/xfs/xfs_alloc_btree.c | |||
| @@ -39,6 +39,7 @@ | |||
| 39 | #include "xfs_ialloc.h" | 39 | #include "xfs_ialloc.h" |
| 40 | #include "xfs_alloc.h" | 40 | #include "xfs_alloc.h" |
| 41 | #include "xfs_error.h" | 41 | #include "xfs_error.h" |
| 42 | #include "xfs_trace.h" | ||
| 42 | 43 | ||
| 43 | 44 | ||
| 44 | STATIC struct xfs_btree_cur * | 45 | STATIC struct xfs_btree_cur * |
diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c index 4ece1906bd41..e953b6cfb2a8 100644 --- a/fs/xfs/xfs_attr.c +++ b/fs/xfs/xfs_attr.c | |||
| @@ -47,6 +47,7 @@ | |||
| 47 | #include "xfs_trans_space.h" | 47 | #include "xfs_trans_space.h" |
| 48 | #include "xfs_rw.h" | 48 | #include "xfs_rw.h" |
| 49 | #include "xfs_vnodeops.h" | 49 | #include "xfs_vnodeops.h" |
| 50 | #include "xfs_trace.h" | ||
| 50 | 51 | ||
| 51 | /* | 52 | /* |
| 52 | * xfs_attr.c | 53 | * xfs_attr.c |
| @@ -89,10 +90,6 @@ STATIC int xfs_attr_rmtval_remove(xfs_da_args_t *args); | |||
| 89 | 90 | ||
| 90 | #define ATTR_RMTVALUE_MAPSIZE 1 /* # of map entries at once */ | 91 | #define ATTR_RMTVALUE_MAPSIZE 1 /* # of map entries at once */ |
| 91 | 92 | ||
| 92 | #if defined(XFS_ATTR_TRACE) | ||
| 93 | ktrace_t *xfs_attr_trace_buf; | ||
| 94 | #endif | ||
| 95 | |||
| 96 | STATIC int | 93 | STATIC int |
| 97 | xfs_attr_name_to_xname( | 94 | xfs_attr_name_to_xname( |
| 98 | struct xfs_name *xname, | 95 | struct xfs_name *xname, |
| @@ -123,9 +120,13 @@ xfs_inode_hasattr( | |||
| 123 | * Overall external interface routines. | 120 | * Overall external interface routines. |
| 124 | *========================================================================*/ | 121 | *========================================================================*/ |
| 125 | 122 | ||
| 126 | int | 123 | STATIC int |
| 127 | xfs_attr_fetch(xfs_inode_t *ip, struct xfs_name *name, | 124 | xfs_attr_get_int( |
| 128 | char *value, int *valuelenp, int flags) | 125 | struct xfs_inode *ip, |
| 126 | struct xfs_name *name, | ||
| 127 | char *value, | ||
| 128 | int *valuelenp, | ||
| 129 | int flags) | ||
| 129 | { | 130 | { |
| 130 | xfs_da_args_t args; | 131 | xfs_da_args_t args; |
| 131 | int error; | 132 | int error; |
| @@ -188,7 +189,7 @@ xfs_attr_get( | |||
| 188 | return error; | 189 | return error; |
| 189 | 190 | ||
| 190 | xfs_ilock(ip, XFS_ILOCK_SHARED); | 191 | xfs_ilock(ip, XFS_ILOCK_SHARED); |
| 191 | error = xfs_attr_fetch(ip, &xname, value, valuelenp, flags); | 192 | error = xfs_attr_get_int(ip, &xname, value, valuelenp, flags); |
| 192 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | 193 | xfs_iunlock(ip, XFS_ILOCK_SHARED); |
| 193 | return(error); | 194 | return(error); |
| 194 | } | 195 | } |
| @@ -636,7 +637,6 @@ xfs_attr_list_int(xfs_attr_list_context_t *context) | |||
| 636 | return EIO; | 637 | return EIO; |
| 637 | 638 | ||
| 638 | xfs_ilock(dp, XFS_ILOCK_SHARED); | 639 | xfs_ilock(dp, XFS_ILOCK_SHARED); |
| 639 | xfs_attr_trace_l_c("syscall start", context); | ||
| 640 | 640 | ||
| 641 | /* | 641 | /* |
| 642 | * Decide on what work routines to call based on the inode size. | 642 | * Decide on what work routines to call based on the inode size. |
| @@ -652,7 +652,6 @@ xfs_attr_list_int(xfs_attr_list_context_t *context) | |||
| 652 | } | 652 | } |
| 653 | 653 | ||
| 654 | xfs_iunlock(dp, XFS_ILOCK_SHARED); | 654 | xfs_iunlock(dp, XFS_ILOCK_SHARED); |
| 655 | xfs_attr_trace_l_c("syscall end", context); | ||
| 656 | 655 | ||
| 657 | return error; | 656 | return error; |
| 658 | } | 657 | } |
| @@ -698,7 +697,7 @@ xfs_attr_put_listent(xfs_attr_list_context_t *context, int flags, | |||
| 698 | context->count * sizeof(alist->al_offset[0]); | 697 | context->count * sizeof(alist->al_offset[0]); |
| 699 | context->firstu -= ATTR_ENTSIZE(namelen); | 698 | context->firstu -= ATTR_ENTSIZE(namelen); |
| 700 | if (context->firstu < arraytop) { | 699 | if (context->firstu < arraytop) { |
| 701 | xfs_attr_trace_l_c("buffer full", context); | 700 | trace_xfs_attr_list_full(context); |
| 702 | alist->al_more = 1; | 701 | alist->al_more = 1; |
| 703 | context->seen_enough = 1; | 702 | context->seen_enough = 1; |
| 704 | return 1; | 703 | return 1; |
| @@ -710,7 +709,7 @@ xfs_attr_put_listent(xfs_attr_list_context_t *context, int flags, | |||
| 710 | aep->a_name[namelen] = 0; | 709 | aep->a_name[namelen] = 0; |
| 711 | alist->al_offset[context->count++] = context->firstu; | 710 | alist->al_offset[context->count++] = context->firstu; |
| 712 | alist->al_count = context->count; | 711 | alist->al_count = context->count; |
| 713 | xfs_attr_trace_l_c("add", context); | 712 | trace_xfs_attr_list_add(context); |
| 714 | return 0; | 713 | return 0; |
| 715 | } | 714 | } |
| 716 | 715 | ||
| @@ -1849,7 +1848,7 @@ xfs_attr_node_list(xfs_attr_list_context_t *context) | |||
| 1849 | node = bp->data; | 1848 | node = bp->data; |
| 1850 | switch (be16_to_cpu(node->hdr.info.magic)) { | 1849 | switch (be16_to_cpu(node->hdr.info.magic)) { |
| 1851 | case XFS_DA_NODE_MAGIC: | 1850 | case XFS_DA_NODE_MAGIC: |
| 1852 | xfs_attr_trace_l_cn("wrong blk", context, node); | 1851 | trace_xfs_attr_list_wrong_blk(context); |
| 1853 | xfs_da_brelse(NULL, bp); | 1852 | xfs_da_brelse(NULL, bp); |
| 1854 | bp = NULL; | 1853 | bp = NULL; |
| 1855 | break; | 1854 | break; |
| @@ -1857,20 +1856,18 @@ xfs_attr_node_list(xfs_attr_list_context_t *context) | |||
| 1857 | leaf = bp->data; | 1856 | leaf = bp->data; |
| 1858 | if (cursor->hashval > be32_to_cpu(leaf->entries[ | 1857 | if (cursor->hashval > be32_to_cpu(leaf->entries[ |
| 1859 | be16_to_cpu(leaf->hdr.count)-1].hashval)) { | 1858 | be16_to_cpu(leaf->hdr.count)-1].hashval)) { |
| 1860 | xfs_attr_trace_l_cl("wrong blk", | 1859 | trace_xfs_attr_list_wrong_blk(context); |
| 1861 | context, leaf); | ||
| 1862 | xfs_da_brelse(NULL, bp); | 1860 | xfs_da_brelse(NULL, bp); |
| 1863 | bp = NULL; | 1861 | bp = NULL; |
| 1864 | } else if (cursor->hashval <= | 1862 | } else if (cursor->hashval <= |
| 1865 | be32_to_cpu(leaf->entries[0].hashval)) { | 1863 | be32_to_cpu(leaf->entries[0].hashval)) { |
| 1866 | xfs_attr_trace_l_cl("maybe wrong blk", | 1864 | trace_xfs_attr_list_wrong_blk(context); |
| 1867 | context, leaf); | ||
| 1868 | xfs_da_brelse(NULL, bp); | 1865 | xfs_da_brelse(NULL, bp); |
| 1869 | bp = NULL; | 1866 | bp = NULL; |
| 1870 | } | 1867 | } |
| 1871 | break; | 1868 | break; |
| 1872 | default: | 1869 | default: |
| 1873 | xfs_attr_trace_l_c("wrong blk - ??", context); | 1870 | trace_xfs_attr_list_wrong_blk(context); |
| 1874 | xfs_da_brelse(NULL, bp); | 1871 | xfs_da_brelse(NULL, bp); |
| 1875 | bp = NULL; | 1872 | bp = NULL; |
| 1876 | } | 1873 | } |
| @@ -1915,8 +1912,8 @@ xfs_attr_node_list(xfs_attr_list_context_t *context) | |||
| 1915 | if (cursor->hashval | 1912 | if (cursor->hashval |
| 1916 | <= be32_to_cpu(btree->hashval)) { | 1913 | <= be32_to_cpu(btree->hashval)) { |
| 1917 | cursor->blkno = be32_to_cpu(btree->before); | 1914 | cursor->blkno = be32_to_cpu(btree->before); |
| 1918 | xfs_attr_trace_l_cb("descending", | 1915 | trace_xfs_attr_list_node_descend(context, |
| 1919 | context, btree); | 1916 | btree); |
| 1920 | break; | 1917 | break; |
| 1921 | } | 1918 | } |
| 1922 | } | 1919 | } |
| @@ -2143,8 +2140,8 @@ xfs_attr_rmtval_set(xfs_da_args_t *args) | |||
| 2143 | dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock), | 2140 | dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock), |
| 2144 | blkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount); | 2141 | blkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount); |
| 2145 | 2142 | ||
| 2146 | bp = xfs_buf_get_flags(mp->m_ddev_targp, dblkno, blkcnt, | 2143 | bp = xfs_buf_get(mp->m_ddev_targp, dblkno, blkcnt, |
| 2147 | XFS_BUF_LOCK | XBF_DONT_BLOCK); | 2144 | XFS_BUF_LOCK | XBF_DONT_BLOCK); |
| 2148 | ASSERT(bp); | 2145 | ASSERT(bp); |
| 2149 | ASSERT(!XFS_BUF_GETERROR(bp)); | 2146 | ASSERT(!XFS_BUF_GETERROR(bp)); |
| 2150 | 2147 | ||
| @@ -2266,85 +2263,3 @@ xfs_attr_rmtval_remove(xfs_da_args_t *args) | |||
| 2266 | } | 2263 | } |
| 2267 | return(0); | 2264 | return(0); |
| 2268 | } | 2265 | } |
| 2269 | |||
| 2270 | #if defined(XFS_ATTR_TRACE) | ||
| 2271 | /* | ||
| 2272 | * Add a trace buffer entry for an attr_list context structure. | ||
| 2273 | */ | ||
| 2274 | void | ||
| 2275 | xfs_attr_trace_l_c(char *where, struct xfs_attr_list_context *context) | ||
| 2276 | { | ||
| 2277 | xfs_attr_trace_enter(XFS_ATTR_KTRACE_L_C, where, context, | ||
| 2278 | (__psunsigned_t)NULL, | ||
| 2279 | (__psunsigned_t)NULL, | ||
| 2280 | (__psunsigned_t)NULL); | ||
| 2281 | } | ||
| 2282 | |||
| 2283 | /* | ||
| 2284 | * Add a trace buffer entry for a context structure and a Btree node. | ||
| 2285 | */ | ||
| 2286 | void | ||
| 2287 | xfs_attr_trace_l_cn(char *where, struct xfs_attr_list_context *context, | ||
| 2288 | struct xfs_da_intnode *node) | ||
| 2289 | { | ||
| 2290 | xfs_attr_trace_enter(XFS_ATTR_KTRACE_L_CN, where, context, | ||
| 2291 | (__psunsigned_t)be16_to_cpu(node->hdr.count), | ||
| 2292 | (__psunsigned_t)be32_to_cpu(node->btree[0].hashval), | ||
| 2293 | (__psunsigned_t)be32_to_cpu(node->btree[ | ||
| 2294 | be16_to_cpu(node->hdr.count)-1].hashval)); | ||
| 2295 | } | ||
| 2296 | |||
| 2297 | /* | ||
| 2298 | * Add a trace buffer entry for a context structure and a Btree element. | ||
| 2299 | */ | ||
| 2300 | void | ||
| 2301 | xfs_attr_trace_l_cb(char *where, struct xfs_attr_list_context *context, | ||
| 2302 | struct xfs_da_node_entry *btree) | ||
| 2303 | { | ||
| 2304 | xfs_attr_trace_enter(XFS_ATTR_KTRACE_L_CB, where, context, | ||
| 2305 | (__psunsigned_t)be32_to_cpu(btree->hashval), | ||
| 2306 | (__psunsigned_t)be32_to_cpu(btree->before), | ||
| 2307 | (__psunsigned_t)NULL); | ||
| 2308 | } | ||
| 2309 | |||
| 2310 | /* | ||
| 2311 | * Add a trace buffer entry for a context structure and a leaf block. | ||
| 2312 | */ | ||
| 2313 | void | ||
| 2314 | xfs_attr_trace_l_cl(char *where, struct xfs_attr_list_context *context, | ||
| 2315 | struct xfs_attr_leafblock *leaf) | ||
| 2316 | { | ||
| 2317 | xfs_attr_trace_enter(XFS_ATTR_KTRACE_L_CL, where, context, | ||
| 2318 | (__psunsigned_t)be16_to_cpu(leaf->hdr.count), | ||
| 2319 | (__psunsigned_t)be32_to_cpu(leaf->entries[0].hashval), | ||
| 2320 | (__psunsigned_t)be32_to_cpu(leaf->entries[ | ||
| 2321 | be16_to_cpu(leaf->hdr.count)-1].hashval)); | ||
| 2322 | } | ||
| 2323 | |||
| 2324 | /* | ||
| 2325 | * Add a trace buffer entry for the arguments given to the routine, | ||
| 2326 | * generic form. | ||
| 2327 | */ | ||
| 2328 | void | ||
| 2329 | xfs_attr_trace_enter(int type, char *where, | ||
| 2330 | struct xfs_attr_list_context *context, | ||
| 2331 | __psunsigned_t a13, __psunsigned_t a14, | ||
| 2332 | __psunsigned_t a15) | ||
| 2333 | { | ||
| 2334 | ASSERT(xfs_attr_trace_buf); | ||
| 2335 | ktrace_enter(xfs_attr_trace_buf, (void *)((__psunsigned_t)type), | ||
| 2336 | (void *)((__psunsigned_t)where), | ||
| 2337 | (void *)((__psunsigned_t)context->dp), | ||
| 2338 | (void *)((__psunsigned_t)context->cursor->hashval), | ||
| 2339 | (void *)((__psunsigned_t)context->cursor->blkno), | ||
| 2340 | (void *)((__psunsigned_t)context->cursor->offset), | ||
| 2341 | (void *)((__psunsigned_t)context->alist), | ||
| 2342 | (void *)((__psunsigned_t)context->bufsize), | ||
| 2343 | (void *)((__psunsigned_t)context->count), | ||
| 2344 | (void *)((__psunsigned_t)context->firstu), | ||
| 2345 | NULL, | ||
| 2346 | (void *)((__psunsigned_t)context->dupcnt), | ||
| 2347 | (void *)((__psunsigned_t)context->flags), | ||
| 2348 | (void *)a13, (void *)a14, (void *)a15); | ||
| 2349 | } | ||
| 2350 | #endif /* XFS_ATTR_TRACE */ | ||
diff --git a/fs/xfs/xfs_attr.h b/fs/xfs/xfs_attr.h index fb3b2a68b9b9..59b410ce69a1 100644 --- a/fs/xfs/xfs_attr.h +++ b/fs/xfs/xfs_attr.h | |||
| @@ -48,6 +48,16 @@ struct xfs_attr_list_context; | |||
| 48 | #define ATTR_KERNOTIME 0x1000 /* [kernel] don't update inode timestamps */ | 48 | #define ATTR_KERNOTIME 0x1000 /* [kernel] don't update inode timestamps */ |
| 49 | #define ATTR_KERNOVAL 0x2000 /* [kernel] get attr size only, not value */ | 49 | #define ATTR_KERNOVAL 0x2000 /* [kernel] get attr size only, not value */ |
| 50 | 50 | ||
| 51 | #define XFS_ATTR_FLAGS \ | ||
| 52 | { ATTR_DONTFOLLOW, "DONTFOLLOW" }, \ | ||
| 53 | { ATTR_ROOT, "ROOT" }, \ | ||
| 54 | { ATTR_TRUST, "TRUST" }, \ | ||
| 55 | { ATTR_SECURE, "SECURE" }, \ | ||
| 56 | { ATTR_CREATE, "CREATE" }, \ | ||
| 57 | { ATTR_REPLACE, "REPLACE" }, \ | ||
| 58 | { ATTR_KERNOTIME, "KERNOTIME" }, \ | ||
| 59 | { ATTR_KERNOVAL, "KERNOVAL" } | ||
| 60 | |||
| 51 | /* | 61 | /* |
| 52 | * The maximum size (into the kernel or returned from the kernel) of an | 62 | * The maximum size (into the kernel or returned from the kernel) of an |
| 53 | * attribute value or the buffer used for an attr_list() call. Larger | 63 | * attribute value or the buffer used for an attr_list() call. Larger |
| @@ -131,7 +141,6 @@ typedef struct xfs_attr_list_context { | |||
| 131 | */ | 141 | */ |
| 132 | int xfs_attr_calc_size(struct xfs_inode *, int, int, int *); | 142 | int xfs_attr_calc_size(struct xfs_inode *, int, int, int *); |
| 133 | int xfs_attr_inactive(struct xfs_inode *dp); | 143 | int xfs_attr_inactive(struct xfs_inode *dp); |
| 134 | int xfs_attr_fetch(struct xfs_inode *, struct xfs_name *, char *, int *, int); | ||
| 135 | int xfs_attr_rmtval_get(struct xfs_da_args *args); | 144 | int xfs_attr_rmtval_get(struct xfs_da_args *args); |
| 136 | int xfs_attr_list_int(struct xfs_attr_list_context *); | 145 | int xfs_attr_list_int(struct xfs_attr_list_context *); |
| 137 | 146 | ||
diff --git a/fs/xfs/xfs_attr_leaf.c b/fs/xfs/xfs_attr_leaf.c index afdc8911637d..baf41b5af756 100644 --- a/fs/xfs/xfs_attr_leaf.c +++ b/fs/xfs/xfs_attr_leaf.c | |||
| @@ -42,6 +42,7 @@ | |||
| 42 | #include "xfs_attr.h" | 42 | #include "xfs_attr.h" |
| 43 | #include "xfs_attr_leaf.h" | 43 | #include "xfs_attr_leaf.h" |
| 44 | #include "xfs_error.h" | 44 | #include "xfs_error.h" |
| 45 | #include "xfs_trace.h" | ||
| 45 | 46 | ||
| 46 | /* | 47 | /* |
| 47 | * xfs_attr_leaf.c | 48 | * xfs_attr_leaf.c |
| @@ -98,7 +99,7 @@ STATIC int xfs_attr_leaf_entsize(xfs_attr_leafblock_t *leaf, int index); | |||
| 98 | * If namespace bits don't match return 0. | 99 | * If namespace bits don't match return 0. |
| 99 | * If all match then return 1. | 100 | * If all match then return 1. |
| 100 | */ | 101 | */ |
| 101 | STATIC_INLINE int | 102 | STATIC int |
| 102 | xfs_attr_namesp_match(int arg_flags, int ondisk_flags) | 103 | xfs_attr_namesp_match(int arg_flags, int ondisk_flags) |
| 103 | { | 104 | { |
| 104 | return XFS_ATTR_NSP_ONDISK(ondisk_flags) == XFS_ATTR_NSP_ARGS_TO_ONDISK(arg_flags); | 105 | return XFS_ATTR_NSP_ONDISK(ondisk_flags) == XFS_ATTR_NSP_ARGS_TO_ONDISK(arg_flags); |
| @@ -594,7 +595,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) | |||
| 594 | cursor = context->cursor; | 595 | cursor = context->cursor; |
| 595 | ASSERT(cursor != NULL); | 596 | ASSERT(cursor != NULL); |
| 596 | 597 | ||
| 597 | xfs_attr_trace_l_c("sf start", context); | 598 | trace_xfs_attr_list_sf(context); |
| 598 | 599 | ||
| 599 | /* | 600 | /* |
| 600 | * If the buffer is large enough and the cursor is at the start, | 601 | * If the buffer is large enough and the cursor is at the start, |
| @@ -627,7 +628,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) | |||
| 627 | return error; | 628 | return error; |
| 628 | sfe = XFS_ATTR_SF_NEXTENTRY(sfe); | 629 | sfe = XFS_ATTR_SF_NEXTENTRY(sfe); |
| 629 | } | 630 | } |
| 630 | xfs_attr_trace_l_c("sf big-gulp", context); | 631 | trace_xfs_attr_list_sf_all(context); |
| 631 | return(0); | 632 | return(0); |
| 632 | } | 633 | } |
| 633 | 634 | ||
| @@ -653,7 +654,6 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) | |||
| 653 | XFS_CORRUPTION_ERROR("xfs_attr_shortform_list", | 654 | XFS_CORRUPTION_ERROR("xfs_attr_shortform_list", |
| 654 | XFS_ERRLEVEL_LOW, | 655 | XFS_ERRLEVEL_LOW, |
| 655 | context->dp->i_mount, sfe); | 656 | context->dp->i_mount, sfe); |
| 656 | xfs_attr_trace_l_c("sf corrupted", context); | ||
| 657 | kmem_free(sbuf); | 657 | kmem_free(sbuf); |
| 658 | return XFS_ERROR(EFSCORRUPTED); | 658 | return XFS_ERROR(EFSCORRUPTED); |
| 659 | } | 659 | } |
| @@ -693,7 +693,6 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) | |||
| 693 | } | 693 | } |
| 694 | if (i == nsbuf) { | 694 | if (i == nsbuf) { |
| 695 | kmem_free(sbuf); | 695 | kmem_free(sbuf); |
| 696 | xfs_attr_trace_l_c("blk end", context); | ||
| 697 | return(0); | 696 | return(0); |
| 698 | } | 697 | } |
| 699 | 698 | ||
| @@ -719,7 +718,6 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) | |||
| 719 | } | 718 | } |
| 720 | 719 | ||
| 721 | kmem_free(sbuf); | 720 | kmem_free(sbuf); |
| 722 | xfs_attr_trace_l_c("sf E-O-F", context); | ||
| 723 | return(0); | 721 | return(0); |
| 724 | } | 722 | } |
| 725 | 723 | ||
| @@ -2323,7 +2321,7 @@ xfs_attr_leaf_list_int(xfs_dabuf_t *bp, xfs_attr_list_context_t *context) | |||
| 2323 | cursor = context->cursor; | 2321 | cursor = context->cursor; |
| 2324 | cursor->initted = 1; | 2322 | cursor->initted = 1; |
| 2325 | 2323 | ||
| 2326 | xfs_attr_trace_l_cl("blk start", context, leaf); | 2324 | trace_xfs_attr_list_leaf(context); |
| 2327 | 2325 | ||
| 2328 | /* | 2326 | /* |
| 2329 | * Re-find our place in the leaf block if this is a new syscall. | 2327 | * Re-find our place in the leaf block if this is a new syscall. |
| @@ -2344,7 +2342,7 @@ xfs_attr_leaf_list_int(xfs_dabuf_t *bp, xfs_attr_list_context_t *context) | |||
| 2344 | } | 2342 | } |
| 2345 | } | 2343 | } |
| 2346 | if (i == be16_to_cpu(leaf->hdr.count)) { | 2344 | if (i == be16_to_cpu(leaf->hdr.count)) { |
| 2347 | xfs_attr_trace_l_c("not found", context); | 2345 | trace_xfs_attr_list_notfound(context); |
| 2348 | return(0); | 2346 | return(0); |
| 2349 | } | 2347 | } |
| 2350 | } else { | 2348 | } else { |
| @@ -2419,7 +2417,7 @@ xfs_attr_leaf_list_int(xfs_dabuf_t *bp, xfs_attr_list_context_t *context) | |||
| 2419 | break; | 2417 | break; |
| 2420 | cursor->offset++; | 2418 | cursor->offset++; |
| 2421 | } | 2419 | } |
| 2422 | xfs_attr_trace_l_cl("blk end", context, leaf); | 2420 | trace_xfs_attr_list_leaf_end(context); |
| 2423 | return(retval); | 2421 | return(retval); |
| 2424 | } | 2422 | } |
| 2425 | 2423 | ||
diff --git a/fs/xfs/xfs_attr_sf.h b/fs/xfs/xfs_attr_sf.h index ea22839caed2..76ab7b0cbb3a 100644 --- a/fs/xfs/xfs_attr_sf.h +++ b/fs/xfs/xfs_attr_sf.h | |||
| @@ -25,8 +25,6 @@ | |||
| 25 | * to fit into the literal area of the inode. | 25 | * to fit into the literal area of the inode. |
| 26 | */ | 26 | */ |
| 27 | 27 | ||
| 28 | struct xfs_inode; | ||
| 29 | |||
| 30 | /* | 28 | /* |
| 31 | * Entries are packed toward the top as tight as possible. | 29 | * Entries are packed toward the top as tight as possible. |
| 32 | */ | 30 | */ |
| @@ -69,42 +67,4 @@ typedef struct xfs_attr_sf_sort { | |||
| 69 | (be16_to_cpu(((xfs_attr_shortform_t *) \ | 67 | (be16_to_cpu(((xfs_attr_shortform_t *) \ |
| 70 | ((dp)->i_afp->if_u1.if_data))->hdr.totsize)) | 68 | ((dp)->i_afp->if_u1.if_data))->hdr.totsize)) |
| 71 | 69 | ||
| 72 | #if defined(XFS_ATTR_TRACE) | ||
| 73 | /* | ||
| 74 | * Kernel tracing support for attribute lists | ||
| 75 | */ | ||
| 76 | struct xfs_attr_list_context; | ||
| 77 | struct xfs_da_intnode; | ||
| 78 | struct xfs_da_node_entry; | ||
| 79 | struct xfs_attr_leafblock; | ||
| 80 | |||
| 81 | #define XFS_ATTR_TRACE_SIZE 4096 /* size of global trace buffer */ | ||
| 82 | extern ktrace_t *xfs_attr_trace_buf; | ||
| 83 | |||
| 84 | /* | ||
| 85 | * Trace record types. | ||
| 86 | */ | ||
| 87 | #define XFS_ATTR_KTRACE_L_C 1 /* context */ | ||
| 88 | #define XFS_ATTR_KTRACE_L_CN 2 /* context, node */ | ||
| 89 | #define XFS_ATTR_KTRACE_L_CB 3 /* context, btree */ | ||
| 90 | #define XFS_ATTR_KTRACE_L_CL 4 /* context, leaf */ | ||
| 91 | |||
| 92 | void xfs_attr_trace_l_c(char *where, struct xfs_attr_list_context *context); | ||
| 93 | void xfs_attr_trace_l_cn(char *where, struct xfs_attr_list_context *context, | ||
| 94 | struct xfs_da_intnode *node); | ||
| 95 | void xfs_attr_trace_l_cb(char *where, struct xfs_attr_list_context *context, | ||
| 96 | struct xfs_da_node_entry *btree); | ||
| 97 | void xfs_attr_trace_l_cl(char *where, struct xfs_attr_list_context *context, | ||
| 98 | struct xfs_attr_leafblock *leaf); | ||
| 99 | void xfs_attr_trace_enter(int type, char *where, | ||
| 100 | struct xfs_attr_list_context *context, | ||
| 101 | __psunsigned_t a13, __psunsigned_t a14, | ||
| 102 | __psunsigned_t a15); | ||
| 103 | #else | ||
| 104 | #define xfs_attr_trace_l_c(w,c) | ||
| 105 | #define xfs_attr_trace_l_cn(w,c,n) | ||
| 106 | #define xfs_attr_trace_l_cb(w,c,b) | ||
| 107 | #define xfs_attr_trace_l_cl(w,c,l) | ||
| 108 | #endif /* XFS_ATTR_TRACE */ | ||
| 109 | |||
| 110 | #endif /* __XFS_ATTR_SF_H__ */ | 70 | #endif /* __XFS_ATTR_SF_H__ */ |
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index 8971fb09d387..98251cdc52aa 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c | |||
| @@ -54,6 +54,7 @@ | |||
| 54 | #include "xfs_buf_item.h" | 54 | #include "xfs_buf_item.h" |
| 55 | #include "xfs_filestream.h" | 55 | #include "xfs_filestream.h" |
| 56 | #include "xfs_vnodeops.h" | 56 | #include "xfs_vnodeops.h" |
| 57 | #include "xfs_trace.h" | ||
| 57 | 58 | ||
| 58 | 59 | ||
| 59 | #ifdef DEBUG | 60 | #ifdef DEBUG |
| @@ -272,71 +273,6 @@ xfs_bmap_isaeof( | |||
| 272 | int whichfork, /* data or attribute fork */ | 273 | int whichfork, /* data or attribute fork */ |
| 273 | char *aeof); /* return value */ | 274 | char *aeof); /* return value */ |
| 274 | 275 | ||
| 275 | #ifdef XFS_BMAP_TRACE | ||
| 276 | /* | ||
| 277 | * Add bmap trace entry prior to a call to xfs_iext_remove. | ||
| 278 | */ | ||
| 279 | STATIC void | ||
| 280 | xfs_bmap_trace_delete( | ||
| 281 | const char *fname, /* function name */ | ||
| 282 | char *desc, /* operation description */ | ||
| 283 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 284 | xfs_extnum_t idx, /* index of entry(entries) deleted */ | ||
| 285 | xfs_extnum_t cnt, /* count of entries deleted, 1 or 2 */ | ||
| 286 | int whichfork); /* data or attr fork */ | ||
| 287 | |||
| 288 | /* | ||
| 289 | * Add bmap trace entry prior to a call to xfs_iext_insert, or | ||
| 290 | * reading in the extents list from the disk (in the btree). | ||
| 291 | */ | ||
| 292 | STATIC void | ||
| 293 | xfs_bmap_trace_insert( | ||
| 294 | const char *fname, /* function name */ | ||
| 295 | char *desc, /* operation description */ | ||
| 296 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 297 | xfs_extnum_t idx, /* index of entry(entries) inserted */ | ||
| 298 | xfs_extnum_t cnt, /* count of entries inserted, 1 or 2 */ | ||
| 299 | xfs_bmbt_irec_t *r1, /* inserted record 1 */ | ||
| 300 | xfs_bmbt_irec_t *r2, /* inserted record 2 or null */ | ||
| 301 | int whichfork); /* data or attr fork */ | ||
| 302 | |||
| 303 | /* | ||
| 304 | * Add bmap trace entry after updating an extent record in place. | ||
| 305 | */ | ||
| 306 | STATIC void | ||
| 307 | xfs_bmap_trace_post_update( | ||
| 308 | const char *fname, /* function name */ | ||
| 309 | char *desc, /* operation description */ | ||
| 310 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 311 | xfs_extnum_t idx, /* index of entry updated */ | ||
| 312 | int whichfork); /* data or attr fork */ | ||
| 313 | |||
| 314 | /* | ||
| 315 | * Add bmap trace entry prior to updating an extent record in place. | ||
| 316 | */ | ||
| 317 | STATIC void | ||
| 318 | xfs_bmap_trace_pre_update( | ||
| 319 | const char *fname, /* function name */ | ||
| 320 | char *desc, /* operation description */ | ||
| 321 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 322 | xfs_extnum_t idx, /* index of entry to be updated */ | ||
| 323 | int whichfork); /* data or attr fork */ | ||
| 324 | |||
| 325 | #define XFS_BMAP_TRACE_DELETE(d,ip,i,c,w) \ | ||
| 326 | xfs_bmap_trace_delete(__func__,d,ip,i,c,w) | ||
| 327 | #define XFS_BMAP_TRACE_INSERT(d,ip,i,c,r1,r2,w) \ | ||
| 328 | xfs_bmap_trace_insert(__func__,d,ip,i,c,r1,r2,w) | ||
| 329 | #define XFS_BMAP_TRACE_POST_UPDATE(d,ip,i,w) \ | ||
| 330 | xfs_bmap_trace_post_update(__func__,d,ip,i,w) | ||
| 331 | #define XFS_BMAP_TRACE_PRE_UPDATE(d,ip,i,w) \ | ||
| 332 | xfs_bmap_trace_pre_update(__func__,d,ip,i,w) | ||
| 333 | #else | ||
| 334 | #define XFS_BMAP_TRACE_DELETE(d,ip,i,c,w) | ||
| 335 | #define XFS_BMAP_TRACE_INSERT(d,ip,i,c,r1,r2,w) | ||
| 336 | #define XFS_BMAP_TRACE_POST_UPDATE(d,ip,i,w) | ||
| 337 | #define XFS_BMAP_TRACE_PRE_UPDATE(d,ip,i,w) | ||
| 338 | #endif /* XFS_BMAP_TRACE */ | ||
| 339 | |||
| 340 | /* | 276 | /* |
| 341 | * Compute the worst-case number of indirect blocks that will be used | 277 | * Compute the worst-case number of indirect blocks that will be used |
| 342 | * for ip's delayed extent of length "len". | 278 | * for ip's delayed extent of length "len". |
| @@ -363,18 +299,6 @@ xfs_bmap_validate_ret( | |||
| 363 | #define xfs_bmap_validate_ret(bno,len,flags,mval,onmap,nmap) | 299 | #define xfs_bmap_validate_ret(bno,len,flags,mval,onmap,nmap) |
| 364 | #endif /* DEBUG */ | 300 | #endif /* DEBUG */ |
| 365 | 301 | ||
| 366 | #if defined(XFS_RW_TRACE) | ||
| 367 | STATIC void | ||
| 368 | xfs_bunmap_trace( | ||
| 369 | xfs_inode_t *ip, | ||
| 370 | xfs_fileoff_t bno, | ||
| 371 | xfs_filblks_t len, | ||
| 372 | int flags, | ||
| 373 | inst_t *ra); | ||
| 374 | #else | ||
| 375 | #define xfs_bunmap_trace(ip, bno, len, flags, ra) | ||
| 376 | #endif /* XFS_RW_TRACE */ | ||
| 377 | |||
| 378 | STATIC int | 302 | STATIC int |
| 379 | xfs_bmap_count_tree( | 303 | xfs_bmap_count_tree( |
| 380 | xfs_mount_t *mp, | 304 | xfs_mount_t *mp, |
| @@ -590,9 +514,9 @@ xfs_bmap_add_extent( | |||
| 590 | * already extents in the list. | 514 | * already extents in the list. |
| 591 | */ | 515 | */ |
| 592 | if (nextents == 0) { | 516 | if (nextents == 0) { |
| 593 | XFS_BMAP_TRACE_INSERT("insert empty", ip, 0, 1, new, NULL, | 517 | xfs_iext_insert(ip, 0, 1, new, |
| 594 | whichfork); | 518 | whichfork == XFS_ATTR_FORK ? BMAP_ATTRFORK : 0); |
| 595 | xfs_iext_insert(ifp, 0, 1, new); | 519 | |
| 596 | ASSERT(cur == NULL); | 520 | ASSERT(cur == NULL); |
| 597 | ifp->if_lastex = 0; | 521 | ifp->if_lastex = 0; |
| 598 | if (!isnullstartblock(new->br_startblock)) { | 522 | if (!isnullstartblock(new->br_startblock)) { |
| @@ -759,26 +683,10 @@ xfs_bmap_add_extent_delay_real( | |||
| 759 | xfs_filblks_t temp=0; /* value for dnew calculations */ | 683 | xfs_filblks_t temp=0; /* value for dnew calculations */ |
| 760 | xfs_filblks_t temp2=0;/* value for dnew calculations */ | 684 | xfs_filblks_t temp2=0;/* value for dnew calculations */ |
| 761 | int tmp_rval; /* partial logging flags */ | 685 | int tmp_rval; /* partial logging flags */ |
| 762 | enum { /* bit number definitions for state */ | ||
| 763 | LEFT_CONTIG, RIGHT_CONTIG, | ||
| 764 | LEFT_FILLING, RIGHT_FILLING, | ||
| 765 | LEFT_DELAY, RIGHT_DELAY, | ||
| 766 | LEFT_VALID, RIGHT_VALID | ||
| 767 | }; | ||
| 768 | 686 | ||
| 769 | #define LEFT r[0] | 687 | #define LEFT r[0] |
| 770 | #define RIGHT r[1] | 688 | #define RIGHT r[1] |
| 771 | #define PREV r[2] | 689 | #define PREV r[2] |
| 772 | #define MASK(b) (1 << (b)) | ||
| 773 | #define MASK2(a,b) (MASK(a) | MASK(b)) | ||
| 774 | #define MASK3(a,b,c) (MASK2(a,b) | MASK(c)) | ||
| 775 | #define MASK4(a,b,c,d) (MASK3(a,b,c) | MASK(d)) | ||
| 776 | #define STATE_SET(b,v) ((v) ? (state |= MASK(b)) : (state &= ~MASK(b))) | ||
| 777 | #define STATE_TEST(b) (state & MASK(b)) | ||
| 778 | #define STATE_SET_TEST(b,v) ((v) ? ((state |= MASK(b)), 1) : \ | ||
| 779 | ((state &= ~MASK(b)), 0)) | ||
| 780 | #define SWITCH_STATE \ | ||
| 781 | (state & MASK4(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG)) | ||
| 782 | 690 | ||
| 783 | /* | 691 | /* |
| 784 | * Set up a bunch of variables to make the tests simpler. | 692 | * Set up a bunch of variables to make the tests simpler. |
| @@ -790,69 +698,80 @@ xfs_bmap_add_extent_delay_real( | |||
| 790 | new_endoff = new->br_startoff + new->br_blockcount; | 698 | new_endoff = new->br_startoff + new->br_blockcount; |
| 791 | ASSERT(PREV.br_startoff <= new->br_startoff); | 699 | ASSERT(PREV.br_startoff <= new->br_startoff); |
| 792 | ASSERT(PREV.br_startoff + PREV.br_blockcount >= new_endoff); | 700 | ASSERT(PREV.br_startoff + PREV.br_blockcount >= new_endoff); |
| 701 | |||
| 793 | /* | 702 | /* |
| 794 | * Set flags determining what part of the previous delayed allocation | 703 | * Set flags determining what part of the previous delayed allocation |
| 795 | * extent is being replaced by a real allocation. | 704 | * extent is being replaced by a real allocation. |
| 796 | */ | 705 | */ |
| 797 | STATE_SET(LEFT_FILLING, PREV.br_startoff == new->br_startoff); | 706 | if (PREV.br_startoff == new->br_startoff) |
| 798 | STATE_SET(RIGHT_FILLING, | 707 | state |= BMAP_LEFT_FILLING; |
| 799 | PREV.br_startoff + PREV.br_blockcount == new_endoff); | 708 | if (PREV.br_startoff + PREV.br_blockcount == new_endoff) |
| 709 | state |= BMAP_RIGHT_FILLING; | ||
| 710 | |||
| 800 | /* | 711 | /* |
| 801 | * Check and set flags if this segment has a left neighbor. | 712 | * Check and set flags if this segment has a left neighbor. |
| 802 | * Don't set contiguous if the combined extent would be too large. | 713 | * Don't set contiguous if the combined extent would be too large. |
| 803 | */ | 714 | */ |
| 804 | if (STATE_SET_TEST(LEFT_VALID, idx > 0)) { | 715 | if (idx > 0) { |
| 716 | state |= BMAP_LEFT_VALID; | ||
| 805 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &LEFT); | 717 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &LEFT); |
| 806 | STATE_SET(LEFT_DELAY, isnullstartblock(LEFT.br_startblock)); | 718 | |
| 719 | if (isnullstartblock(LEFT.br_startblock)) | ||
| 720 | state |= BMAP_LEFT_DELAY; | ||
| 807 | } | 721 | } |
| 808 | STATE_SET(LEFT_CONTIG, | 722 | |
| 809 | STATE_TEST(LEFT_VALID) && !STATE_TEST(LEFT_DELAY) && | 723 | if ((state & BMAP_LEFT_VALID) && !(state & BMAP_LEFT_DELAY) && |
| 810 | LEFT.br_startoff + LEFT.br_blockcount == new->br_startoff && | 724 | LEFT.br_startoff + LEFT.br_blockcount == new->br_startoff && |
| 811 | LEFT.br_startblock + LEFT.br_blockcount == new->br_startblock && | 725 | LEFT.br_startblock + LEFT.br_blockcount == new->br_startblock && |
| 812 | LEFT.br_state == new->br_state && | 726 | LEFT.br_state == new->br_state && |
| 813 | LEFT.br_blockcount + new->br_blockcount <= MAXEXTLEN); | 727 | LEFT.br_blockcount + new->br_blockcount <= MAXEXTLEN) |
| 728 | state |= BMAP_LEFT_CONTIG; | ||
| 729 | |||
| 814 | /* | 730 | /* |
| 815 | * Check and set flags if this segment has a right neighbor. | 731 | * Check and set flags if this segment has a right neighbor. |
| 816 | * Don't set contiguous if the combined extent would be too large. | 732 | * Don't set contiguous if the combined extent would be too large. |
| 817 | * Also check for all-three-contiguous being too large. | 733 | * Also check for all-three-contiguous being too large. |
| 818 | */ | 734 | */ |
| 819 | if (STATE_SET_TEST(RIGHT_VALID, | 735 | if (idx < ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t) - 1) { |
| 820 | idx < | 736 | state |= BMAP_RIGHT_VALID; |
| 821 | ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t) - 1)) { | ||
| 822 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx + 1), &RIGHT); | 737 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx + 1), &RIGHT); |
| 823 | STATE_SET(RIGHT_DELAY, isnullstartblock(RIGHT.br_startblock)); | 738 | |
| 739 | if (isnullstartblock(RIGHT.br_startblock)) | ||
| 740 | state |= BMAP_RIGHT_DELAY; | ||
| 824 | } | 741 | } |
| 825 | STATE_SET(RIGHT_CONTIG, | 742 | |
| 826 | STATE_TEST(RIGHT_VALID) && !STATE_TEST(RIGHT_DELAY) && | 743 | if ((state & BMAP_RIGHT_VALID) && !(state & BMAP_RIGHT_DELAY) && |
| 827 | new_endoff == RIGHT.br_startoff && | 744 | new_endoff == RIGHT.br_startoff && |
| 828 | new->br_startblock + new->br_blockcount == | 745 | new->br_startblock + new->br_blockcount == RIGHT.br_startblock && |
| 829 | RIGHT.br_startblock && | 746 | new->br_state == RIGHT.br_state && |
| 830 | new->br_state == RIGHT.br_state && | 747 | new->br_blockcount + RIGHT.br_blockcount <= MAXEXTLEN && |
| 831 | new->br_blockcount + RIGHT.br_blockcount <= MAXEXTLEN && | 748 | ((state & (BMAP_LEFT_CONTIG | BMAP_LEFT_FILLING | |
| 832 | ((state & MASK3(LEFT_CONTIG, LEFT_FILLING, RIGHT_FILLING)) != | 749 | BMAP_RIGHT_FILLING)) != |
| 833 | MASK3(LEFT_CONTIG, LEFT_FILLING, RIGHT_FILLING) || | 750 | (BMAP_LEFT_CONTIG | BMAP_LEFT_FILLING | |
| 834 | LEFT.br_blockcount + new->br_blockcount + RIGHT.br_blockcount | 751 | BMAP_RIGHT_FILLING) || |
| 835 | <= MAXEXTLEN)); | 752 | LEFT.br_blockcount + new->br_blockcount + RIGHT.br_blockcount |
| 753 | <= MAXEXTLEN)) | ||
| 754 | state |= BMAP_RIGHT_CONTIG; | ||
| 755 | |||
| 836 | error = 0; | 756 | error = 0; |
| 837 | /* | 757 | /* |
| 838 | * Switch out based on the FILLING and CONTIG state bits. | 758 | * Switch out based on the FILLING and CONTIG state bits. |
| 839 | */ | 759 | */ |
| 840 | switch (SWITCH_STATE) { | 760 | switch (state & (BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | |
| 841 | 761 | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG)) { | |
| 842 | case MASK4(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 762 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | |
| 763 | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: | ||
| 843 | /* | 764 | /* |
| 844 | * Filling in all of a previously delayed allocation extent. | 765 | * Filling in all of a previously delayed allocation extent. |
| 845 | * The left and right neighbors are both contiguous with new. | 766 | * The left and right neighbors are both contiguous with new. |
| 846 | */ | 767 | */ |
| 847 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|LC|RC", ip, idx - 1, | 768 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 848 | XFS_DATA_FORK); | ||
| 849 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 769 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 850 | LEFT.br_blockcount + PREV.br_blockcount + | 770 | LEFT.br_blockcount + PREV.br_blockcount + |
| 851 | RIGHT.br_blockcount); | 771 | RIGHT.br_blockcount); |
| 852 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|LC|RC", ip, idx - 1, | 772 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 853 | XFS_DATA_FORK); | 773 | |
| 854 | XFS_BMAP_TRACE_DELETE("LF|RF|LC|RC", ip, idx, 2, XFS_DATA_FORK); | 774 | xfs_iext_remove(ip, idx, 2, state); |
| 855 | xfs_iext_remove(ifp, idx, 2); | ||
| 856 | ip->i_df.if_lastex = idx - 1; | 775 | ip->i_df.if_lastex = idx - 1; |
| 857 | ip->i_d.di_nextents--; | 776 | ip->i_d.di_nextents--; |
| 858 | if (cur == NULL) | 777 | if (cur == NULL) |
| @@ -885,20 +804,18 @@ xfs_bmap_add_extent_delay_real( | |||
| 885 | RIGHT.br_blockcount; | 804 | RIGHT.br_blockcount; |
| 886 | break; | 805 | break; |
| 887 | 806 | ||
| 888 | case MASK3(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG): | 807 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG: |
| 889 | /* | 808 | /* |
| 890 | * Filling in all of a previously delayed allocation extent. | 809 | * Filling in all of a previously delayed allocation extent. |
| 891 | * The left neighbor is contiguous, the right is not. | 810 | * The left neighbor is contiguous, the right is not. |
| 892 | */ | 811 | */ |
| 893 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|LC", ip, idx - 1, | 812 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 894 | XFS_DATA_FORK); | ||
| 895 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 813 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 896 | LEFT.br_blockcount + PREV.br_blockcount); | 814 | LEFT.br_blockcount + PREV.br_blockcount); |
| 897 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|LC", ip, idx - 1, | 815 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 898 | XFS_DATA_FORK); | 816 | |
| 899 | ip->i_df.if_lastex = idx - 1; | 817 | ip->i_df.if_lastex = idx - 1; |
| 900 | XFS_BMAP_TRACE_DELETE("LF|RF|LC", ip, idx, 1, XFS_DATA_FORK); | 818 | xfs_iext_remove(ip, idx, 1, state); |
| 901 | xfs_iext_remove(ifp, idx, 1); | ||
| 902 | if (cur == NULL) | 819 | if (cur == NULL) |
| 903 | rval = XFS_ILOG_DEXT; | 820 | rval = XFS_ILOG_DEXT; |
| 904 | else { | 821 | else { |
| @@ -921,19 +838,19 @@ xfs_bmap_add_extent_delay_real( | |||
| 921 | PREV.br_blockcount; | 838 | PREV.br_blockcount; |
| 922 | break; | 839 | break; |
| 923 | 840 | ||
| 924 | case MASK3(LEFT_FILLING, RIGHT_FILLING, RIGHT_CONTIG): | 841 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: |
| 925 | /* | 842 | /* |
| 926 | * Filling in all of a previously delayed allocation extent. | 843 | * Filling in all of a previously delayed allocation extent. |
| 927 | * The right neighbor is contiguous, the left is not. | 844 | * The right neighbor is contiguous, the left is not. |
| 928 | */ | 845 | */ |
| 929 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|RC", ip, idx, XFS_DATA_FORK); | 846 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 930 | xfs_bmbt_set_startblock(ep, new->br_startblock); | 847 | xfs_bmbt_set_startblock(ep, new->br_startblock); |
| 931 | xfs_bmbt_set_blockcount(ep, | 848 | xfs_bmbt_set_blockcount(ep, |
| 932 | PREV.br_blockcount + RIGHT.br_blockcount); | 849 | PREV.br_blockcount + RIGHT.br_blockcount); |
| 933 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|RC", ip, idx, XFS_DATA_FORK); | 850 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 851 | |||
| 934 | ip->i_df.if_lastex = idx; | 852 | ip->i_df.if_lastex = idx; |
| 935 | XFS_BMAP_TRACE_DELETE("LF|RF|RC", ip, idx + 1, 1, XFS_DATA_FORK); | 853 | xfs_iext_remove(ip, idx + 1, 1, state); |
| 936 | xfs_iext_remove(ifp, idx + 1, 1); | ||
| 937 | if (cur == NULL) | 854 | if (cur == NULL) |
| 938 | rval = XFS_ILOG_DEXT; | 855 | rval = XFS_ILOG_DEXT; |
| 939 | else { | 856 | else { |
| @@ -956,15 +873,16 @@ xfs_bmap_add_extent_delay_real( | |||
| 956 | RIGHT.br_blockcount; | 873 | RIGHT.br_blockcount; |
| 957 | break; | 874 | break; |
| 958 | 875 | ||
| 959 | case MASK2(LEFT_FILLING, RIGHT_FILLING): | 876 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING: |
| 960 | /* | 877 | /* |
| 961 | * Filling in all of a previously delayed allocation extent. | 878 | * Filling in all of a previously delayed allocation extent. |
| 962 | * Neither the left nor right neighbors are contiguous with | 879 | * Neither the left nor right neighbors are contiguous with |
| 963 | * the new one. | 880 | * the new one. |
| 964 | */ | 881 | */ |
| 965 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF", ip, idx, XFS_DATA_FORK); | 882 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 966 | xfs_bmbt_set_startblock(ep, new->br_startblock); | 883 | xfs_bmbt_set_startblock(ep, new->br_startblock); |
| 967 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF", ip, idx, XFS_DATA_FORK); | 884 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 885 | |||
| 968 | ip->i_df.if_lastex = idx; | 886 | ip->i_df.if_lastex = idx; |
| 969 | ip->i_d.di_nextents++; | 887 | ip->i_d.di_nextents++; |
| 970 | if (cur == NULL) | 888 | if (cur == NULL) |
| @@ -987,19 +905,20 @@ xfs_bmap_add_extent_delay_real( | |||
| 987 | temp2 = new->br_blockcount; | 905 | temp2 = new->br_blockcount; |
| 988 | break; | 906 | break; |
| 989 | 907 | ||
| 990 | case MASK2(LEFT_FILLING, LEFT_CONTIG): | 908 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG: |
| 991 | /* | 909 | /* |
| 992 | * Filling in the first part of a previous delayed allocation. | 910 | * Filling in the first part of a previous delayed allocation. |
| 993 | * The left neighbor is contiguous. | 911 | * The left neighbor is contiguous. |
| 994 | */ | 912 | */ |
| 995 | XFS_BMAP_TRACE_PRE_UPDATE("LF|LC", ip, idx - 1, XFS_DATA_FORK); | 913 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 996 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 914 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 997 | LEFT.br_blockcount + new->br_blockcount); | 915 | LEFT.br_blockcount + new->br_blockcount); |
| 998 | xfs_bmbt_set_startoff(ep, | 916 | xfs_bmbt_set_startoff(ep, |
| 999 | PREV.br_startoff + new->br_blockcount); | 917 | PREV.br_startoff + new->br_blockcount); |
| 1000 | XFS_BMAP_TRACE_POST_UPDATE("LF|LC", ip, idx - 1, XFS_DATA_FORK); | 918 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 919 | |||
| 1001 | temp = PREV.br_blockcount - new->br_blockcount; | 920 | temp = PREV.br_blockcount - new->br_blockcount; |
| 1002 | XFS_BMAP_TRACE_PRE_UPDATE("LF|LC", ip, idx, XFS_DATA_FORK); | 921 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1003 | xfs_bmbt_set_blockcount(ep, temp); | 922 | xfs_bmbt_set_blockcount(ep, temp); |
| 1004 | ip->i_df.if_lastex = idx - 1; | 923 | ip->i_df.if_lastex = idx - 1; |
| 1005 | if (cur == NULL) | 924 | if (cur == NULL) |
| @@ -1021,7 +940,7 @@ xfs_bmap_add_extent_delay_real( | |||
| 1021 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), | 940 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), |
| 1022 | startblockval(PREV.br_startblock)); | 941 | startblockval(PREV.br_startblock)); |
| 1023 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 942 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 1024 | XFS_BMAP_TRACE_POST_UPDATE("LF|LC", ip, idx, XFS_DATA_FORK); | 943 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1025 | *dnew = temp; | 944 | *dnew = temp; |
| 1026 | /* DELTA: The boundary between two in-core extents moved. */ | 945 | /* DELTA: The boundary between two in-core extents moved. */ |
| 1027 | temp = LEFT.br_startoff; | 946 | temp = LEFT.br_startoff; |
| @@ -1029,18 +948,16 @@ xfs_bmap_add_extent_delay_real( | |||
| 1029 | PREV.br_blockcount; | 948 | PREV.br_blockcount; |
| 1030 | break; | 949 | break; |
| 1031 | 950 | ||
| 1032 | case MASK(LEFT_FILLING): | 951 | case BMAP_LEFT_FILLING: |
| 1033 | /* | 952 | /* |
| 1034 | * Filling in the first part of a previous delayed allocation. | 953 | * Filling in the first part of a previous delayed allocation. |
| 1035 | * The left neighbor is not contiguous. | 954 | * The left neighbor is not contiguous. |
| 1036 | */ | 955 | */ |
| 1037 | XFS_BMAP_TRACE_PRE_UPDATE("LF", ip, idx, XFS_DATA_FORK); | 956 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1038 | xfs_bmbt_set_startoff(ep, new_endoff); | 957 | xfs_bmbt_set_startoff(ep, new_endoff); |
| 1039 | temp = PREV.br_blockcount - new->br_blockcount; | 958 | temp = PREV.br_blockcount - new->br_blockcount; |
| 1040 | xfs_bmbt_set_blockcount(ep, temp); | 959 | xfs_bmbt_set_blockcount(ep, temp); |
| 1041 | XFS_BMAP_TRACE_INSERT("LF", ip, idx, 1, new, NULL, | 960 | xfs_iext_insert(ip, idx, 1, new, state); |
| 1042 | XFS_DATA_FORK); | ||
| 1043 | xfs_iext_insert(ifp, idx, 1, new); | ||
| 1044 | ip->i_df.if_lastex = idx; | 961 | ip->i_df.if_lastex = idx; |
| 1045 | ip->i_d.di_nextents++; | 962 | ip->i_d.di_nextents++; |
| 1046 | if (cur == NULL) | 963 | if (cur == NULL) |
| @@ -1071,27 +988,27 @@ xfs_bmap_add_extent_delay_real( | |||
| 1071 | (cur ? cur->bc_private.b.allocated : 0)); | 988 | (cur ? cur->bc_private.b.allocated : 0)); |
| 1072 | ep = xfs_iext_get_ext(ifp, idx + 1); | 989 | ep = xfs_iext_get_ext(ifp, idx + 1); |
| 1073 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 990 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 1074 | XFS_BMAP_TRACE_POST_UPDATE("LF", ip, idx + 1, XFS_DATA_FORK); | 991 | trace_xfs_bmap_post_update(ip, idx + 1, state, _THIS_IP_); |
| 1075 | *dnew = temp; | 992 | *dnew = temp; |
| 1076 | /* DELTA: One in-core extent is split in two. */ | 993 | /* DELTA: One in-core extent is split in two. */ |
| 1077 | temp = PREV.br_startoff; | 994 | temp = PREV.br_startoff; |
| 1078 | temp2 = PREV.br_blockcount; | 995 | temp2 = PREV.br_blockcount; |
| 1079 | break; | 996 | break; |
| 1080 | 997 | ||
| 1081 | case MASK2(RIGHT_FILLING, RIGHT_CONTIG): | 998 | case BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: |
| 1082 | /* | 999 | /* |
| 1083 | * Filling in the last part of a previous delayed allocation. | 1000 | * Filling in the last part of a previous delayed allocation. |
| 1084 | * The right neighbor is contiguous with the new allocation. | 1001 | * The right neighbor is contiguous with the new allocation. |
| 1085 | */ | 1002 | */ |
| 1086 | temp = PREV.br_blockcount - new->br_blockcount; | 1003 | temp = PREV.br_blockcount - new->br_blockcount; |
| 1087 | XFS_BMAP_TRACE_PRE_UPDATE("RF|RC", ip, idx, XFS_DATA_FORK); | 1004 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1088 | XFS_BMAP_TRACE_PRE_UPDATE("RF|RC", ip, idx + 1, XFS_DATA_FORK); | 1005 | trace_xfs_bmap_pre_update(ip, idx + 1, state, _THIS_IP_); |
| 1089 | xfs_bmbt_set_blockcount(ep, temp); | 1006 | xfs_bmbt_set_blockcount(ep, temp); |
| 1090 | xfs_bmbt_set_allf(xfs_iext_get_ext(ifp, idx + 1), | 1007 | xfs_bmbt_set_allf(xfs_iext_get_ext(ifp, idx + 1), |
| 1091 | new->br_startoff, new->br_startblock, | 1008 | new->br_startoff, new->br_startblock, |
| 1092 | new->br_blockcount + RIGHT.br_blockcount, | 1009 | new->br_blockcount + RIGHT.br_blockcount, |
| 1093 | RIGHT.br_state); | 1010 | RIGHT.br_state); |
| 1094 | XFS_BMAP_TRACE_POST_UPDATE("RF|RC", ip, idx + 1, XFS_DATA_FORK); | 1011 | trace_xfs_bmap_post_update(ip, idx + 1, state, _THIS_IP_); |
| 1095 | ip->i_df.if_lastex = idx + 1; | 1012 | ip->i_df.if_lastex = idx + 1; |
| 1096 | if (cur == NULL) | 1013 | if (cur == NULL) |
| 1097 | rval = XFS_ILOG_DEXT; | 1014 | rval = XFS_ILOG_DEXT; |
| @@ -1112,7 +1029,7 @@ xfs_bmap_add_extent_delay_real( | |||
| 1112 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), | 1029 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), |
| 1113 | startblockval(PREV.br_startblock)); | 1030 | startblockval(PREV.br_startblock)); |
| 1114 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 1031 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 1115 | XFS_BMAP_TRACE_POST_UPDATE("RF|RC", ip, idx, XFS_DATA_FORK); | 1032 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1116 | *dnew = temp; | 1033 | *dnew = temp; |
| 1117 | /* DELTA: The boundary between two in-core extents moved. */ | 1034 | /* DELTA: The boundary between two in-core extents moved. */ |
| 1118 | temp = PREV.br_startoff; | 1035 | temp = PREV.br_startoff; |
| @@ -1120,17 +1037,15 @@ xfs_bmap_add_extent_delay_real( | |||
| 1120 | RIGHT.br_blockcount; | 1037 | RIGHT.br_blockcount; |
| 1121 | break; | 1038 | break; |
| 1122 | 1039 | ||
| 1123 | case MASK(RIGHT_FILLING): | 1040 | case BMAP_RIGHT_FILLING: |
| 1124 | /* | 1041 | /* |
| 1125 | * Filling in the last part of a previous delayed allocation. | 1042 | * Filling in the last part of a previous delayed allocation. |
| 1126 | * The right neighbor is not contiguous. | 1043 | * The right neighbor is not contiguous. |
| 1127 | */ | 1044 | */ |
| 1128 | temp = PREV.br_blockcount - new->br_blockcount; | 1045 | temp = PREV.br_blockcount - new->br_blockcount; |
| 1129 | XFS_BMAP_TRACE_PRE_UPDATE("RF", ip, idx, XFS_DATA_FORK); | 1046 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1130 | xfs_bmbt_set_blockcount(ep, temp); | 1047 | xfs_bmbt_set_blockcount(ep, temp); |
| 1131 | XFS_BMAP_TRACE_INSERT("RF", ip, idx + 1, 1, new, NULL, | 1048 | xfs_iext_insert(ip, idx + 1, 1, new, state); |
| 1132 | XFS_DATA_FORK); | ||
| 1133 | xfs_iext_insert(ifp, idx + 1, 1, new); | ||
| 1134 | ip->i_df.if_lastex = idx + 1; | 1049 | ip->i_df.if_lastex = idx + 1; |
| 1135 | ip->i_d.di_nextents++; | 1050 | ip->i_d.di_nextents++; |
| 1136 | if (cur == NULL) | 1051 | if (cur == NULL) |
| @@ -1161,7 +1076,7 @@ xfs_bmap_add_extent_delay_real( | |||
| 1161 | (cur ? cur->bc_private.b.allocated : 0)); | 1076 | (cur ? cur->bc_private.b.allocated : 0)); |
| 1162 | ep = xfs_iext_get_ext(ifp, idx); | 1077 | ep = xfs_iext_get_ext(ifp, idx); |
| 1163 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 1078 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 1164 | XFS_BMAP_TRACE_POST_UPDATE("RF", ip, idx, XFS_DATA_FORK); | 1079 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1165 | *dnew = temp; | 1080 | *dnew = temp; |
| 1166 | /* DELTA: One in-core extent is split in two. */ | 1081 | /* DELTA: One in-core extent is split in two. */ |
| 1167 | temp = PREV.br_startoff; | 1082 | temp = PREV.br_startoff; |
| @@ -1175,7 +1090,7 @@ xfs_bmap_add_extent_delay_real( | |||
| 1175 | * This case is avoided almost all the time. | 1090 | * This case is avoided almost all the time. |
| 1176 | */ | 1091 | */ |
| 1177 | temp = new->br_startoff - PREV.br_startoff; | 1092 | temp = new->br_startoff - PREV.br_startoff; |
| 1178 | XFS_BMAP_TRACE_PRE_UPDATE("0", ip, idx, XFS_DATA_FORK); | 1093 | trace_xfs_bmap_pre_update(ip, idx, 0, _THIS_IP_); |
| 1179 | xfs_bmbt_set_blockcount(ep, temp); | 1094 | xfs_bmbt_set_blockcount(ep, temp); |
| 1180 | r[0] = *new; | 1095 | r[0] = *new; |
| 1181 | r[1].br_state = PREV.br_state; | 1096 | r[1].br_state = PREV.br_state; |
| @@ -1183,9 +1098,7 @@ xfs_bmap_add_extent_delay_real( | |||
| 1183 | r[1].br_startoff = new_endoff; | 1098 | r[1].br_startoff = new_endoff; |
| 1184 | temp2 = PREV.br_startoff + PREV.br_blockcount - new_endoff; | 1099 | temp2 = PREV.br_startoff + PREV.br_blockcount - new_endoff; |
| 1185 | r[1].br_blockcount = temp2; | 1100 | r[1].br_blockcount = temp2; |
| 1186 | XFS_BMAP_TRACE_INSERT("0", ip, idx + 1, 2, &r[0], &r[1], | 1101 | xfs_iext_insert(ip, idx + 1, 2, &r[0], state); |
| 1187 | XFS_DATA_FORK); | ||
| 1188 | xfs_iext_insert(ifp, idx + 1, 2, &r[0]); | ||
| 1189 | ip->i_df.if_lastex = idx + 1; | 1102 | ip->i_df.if_lastex = idx + 1; |
| 1190 | ip->i_d.di_nextents++; | 1103 | ip->i_d.di_nextents++; |
| 1191 | if (cur == NULL) | 1104 | if (cur == NULL) |
| @@ -1242,24 +1155,24 @@ xfs_bmap_add_extent_delay_real( | |||
| 1242 | } | 1155 | } |
| 1243 | ep = xfs_iext_get_ext(ifp, idx); | 1156 | ep = xfs_iext_get_ext(ifp, idx); |
| 1244 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 1157 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 1245 | XFS_BMAP_TRACE_POST_UPDATE("0", ip, idx, XFS_DATA_FORK); | 1158 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1246 | XFS_BMAP_TRACE_PRE_UPDATE("0", ip, idx + 2, XFS_DATA_FORK); | 1159 | trace_xfs_bmap_pre_update(ip, idx + 2, state, _THIS_IP_); |
| 1247 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx + 2), | 1160 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx + 2), |
| 1248 | nullstartblock((int)temp2)); | 1161 | nullstartblock((int)temp2)); |
| 1249 | XFS_BMAP_TRACE_POST_UPDATE("0", ip, idx + 2, XFS_DATA_FORK); | 1162 | trace_xfs_bmap_post_update(ip, idx + 2, state, _THIS_IP_); |
| 1250 | *dnew = temp + temp2; | 1163 | *dnew = temp + temp2; |
| 1251 | /* DELTA: One in-core extent is split in three. */ | 1164 | /* DELTA: One in-core extent is split in three. */ |
| 1252 | temp = PREV.br_startoff; | 1165 | temp = PREV.br_startoff; |
| 1253 | temp2 = PREV.br_blockcount; | 1166 | temp2 = PREV.br_blockcount; |
| 1254 | break; | 1167 | break; |
| 1255 | 1168 | ||
| 1256 | case MASK3(LEFT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 1169 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1257 | case MASK3(RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 1170 | case BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1258 | case MASK2(LEFT_FILLING, RIGHT_CONTIG): | 1171 | case BMAP_LEFT_FILLING | BMAP_RIGHT_CONTIG: |
| 1259 | case MASK2(RIGHT_FILLING, LEFT_CONTIG): | 1172 | case BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG: |
| 1260 | case MASK2(LEFT_CONTIG, RIGHT_CONTIG): | 1173 | case BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1261 | case MASK(LEFT_CONTIG): | 1174 | case BMAP_LEFT_CONTIG: |
| 1262 | case MASK(RIGHT_CONTIG): | 1175 | case BMAP_RIGHT_CONTIG: |
| 1263 | /* | 1176 | /* |
| 1264 | * These cases are all impossible. | 1177 | * These cases are all impossible. |
| 1265 | */ | 1178 | */ |
| @@ -1279,14 +1192,6 @@ done: | |||
| 1279 | #undef LEFT | 1192 | #undef LEFT |
| 1280 | #undef RIGHT | 1193 | #undef RIGHT |
| 1281 | #undef PREV | 1194 | #undef PREV |
| 1282 | #undef MASK | ||
| 1283 | #undef MASK2 | ||
| 1284 | #undef MASK3 | ||
| 1285 | #undef MASK4 | ||
| 1286 | #undef STATE_SET | ||
| 1287 | #undef STATE_TEST | ||
| 1288 | #undef STATE_SET_TEST | ||
| 1289 | #undef SWITCH_STATE | ||
| 1290 | } | 1195 | } |
| 1291 | 1196 | ||
| 1292 | /* | 1197 | /* |
| @@ -1316,27 +1221,10 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1316 | int state = 0;/* state bits, accessed thru macros */ | 1221 | int state = 0;/* state bits, accessed thru macros */ |
| 1317 | xfs_filblks_t temp=0; | 1222 | xfs_filblks_t temp=0; |
| 1318 | xfs_filblks_t temp2=0; | 1223 | xfs_filblks_t temp2=0; |
| 1319 | enum { /* bit number definitions for state */ | ||
| 1320 | LEFT_CONTIG, RIGHT_CONTIG, | ||
| 1321 | LEFT_FILLING, RIGHT_FILLING, | ||
| 1322 | LEFT_DELAY, RIGHT_DELAY, | ||
| 1323 | LEFT_VALID, RIGHT_VALID | ||
| 1324 | }; | ||
| 1325 | 1224 | ||
| 1326 | #define LEFT r[0] | 1225 | #define LEFT r[0] |
| 1327 | #define RIGHT r[1] | 1226 | #define RIGHT r[1] |
| 1328 | #define PREV r[2] | 1227 | #define PREV r[2] |
| 1329 | #define MASK(b) (1 << (b)) | ||
| 1330 | #define MASK2(a,b) (MASK(a) | MASK(b)) | ||
| 1331 | #define MASK3(a,b,c) (MASK2(a,b) | MASK(c)) | ||
| 1332 | #define MASK4(a,b,c,d) (MASK3(a,b,c) | MASK(d)) | ||
| 1333 | #define STATE_SET(b,v) ((v) ? (state |= MASK(b)) : (state &= ~MASK(b))) | ||
| 1334 | #define STATE_TEST(b) (state & MASK(b)) | ||
| 1335 | #define STATE_SET_TEST(b,v) ((v) ? ((state |= MASK(b)), 1) : \ | ||
| 1336 | ((state &= ~MASK(b)), 0)) | ||
| 1337 | #define SWITCH_STATE \ | ||
| 1338 | (state & MASK4(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG)) | ||
| 1339 | |||
| 1340 | /* | 1228 | /* |
| 1341 | * Set up a bunch of variables to make the tests simpler. | 1229 | * Set up a bunch of variables to make the tests simpler. |
| 1342 | */ | 1230 | */ |
| @@ -1352,68 +1240,78 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1352 | new_endoff = new->br_startoff + new->br_blockcount; | 1240 | new_endoff = new->br_startoff + new->br_blockcount; |
| 1353 | ASSERT(PREV.br_startoff <= new->br_startoff); | 1241 | ASSERT(PREV.br_startoff <= new->br_startoff); |
| 1354 | ASSERT(PREV.br_startoff + PREV.br_blockcount >= new_endoff); | 1242 | ASSERT(PREV.br_startoff + PREV.br_blockcount >= new_endoff); |
| 1243 | |||
| 1355 | /* | 1244 | /* |
| 1356 | * Set flags determining what part of the previous oldext allocation | 1245 | * Set flags determining what part of the previous oldext allocation |
| 1357 | * extent is being replaced by a newext allocation. | 1246 | * extent is being replaced by a newext allocation. |
| 1358 | */ | 1247 | */ |
| 1359 | STATE_SET(LEFT_FILLING, PREV.br_startoff == new->br_startoff); | 1248 | if (PREV.br_startoff == new->br_startoff) |
| 1360 | STATE_SET(RIGHT_FILLING, | 1249 | state |= BMAP_LEFT_FILLING; |
| 1361 | PREV.br_startoff + PREV.br_blockcount == new_endoff); | 1250 | if (PREV.br_startoff + PREV.br_blockcount == new_endoff) |
| 1251 | state |= BMAP_RIGHT_FILLING; | ||
| 1252 | |||
| 1362 | /* | 1253 | /* |
| 1363 | * Check and set flags if this segment has a left neighbor. | 1254 | * Check and set flags if this segment has a left neighbor. |
| 1364 | * Don't set contiguous if the combined extent would be too large. | 1255 | * Don't set contiguous if the combined extent would be too large. |
| 1365 | */ | 1256 | */ |
| 1366 | if (STATE_SET_TEST(LEFT_VALID, idx > 0)) { | 1257 | if (idx > 0) { |
| 1258 | state |= BMAP_LEFT_VALID; | ||
| 1367 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &LEFT); | 1259 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &LEFT); |
| 1368 | STATE_SET(LEFT_DELAY, isnullstartblock(LEFT.br_startblock)); | 1260 | |
| 1261 | if (isnullstartblock(LEFT.br_startblock)) | ||
| 1262 | state |= BMAP_LEFT_DELAY; | ||
| 1369 | } | 1263 | } |
| 1370 | STATE_SET(LEFT_CONTIG, | 1264 | |
| 1371 | STATE_TEST(LEFT_VALID) && !STATE_TEST(LEFT_DELAY) && | 1265 | if ((state & BMAP_LEFT_VALID) && !(state & BMAP_LEFT_DELAY) && |
| 1372 | LEFT.br_startoff + LEFT.br_blockcount == new->br_startoff && | 1266 | LEFT.br_startoff + LEFT.br_blockcount == new->br_startoff && |
| 1373 | LEFT.br_startblock + LEFT.br_blockcount == new->br_startblock && | 1267 | LEFT.br_startblock + LEFT.br_blockcount == new->br_startblock && |
| 1374 | LEFT.br_state == newext && | 1268 | LEFT.br_state == newext && |
| 1375 | LEFT.br_blockcount + new->br_blockcount <= MAXEXTLEN); | 1269 | LEFT.br_blockcount + new->br_blockcount <= MAXEXTLEN) |
| 1270 | state |= BMAP_LEFT_CONTIG; | ||
| 1271 | |||
| 1376 | /* | 1272 | /* |
| 1377 | * Check and set flags if this segment has a right neighbor. | 1273 | * Check and set flags if this segment has a right neighbor. |
| 1378 | * Don't set contiguous if the combined extent would be too large. | 1274 | * Don't set contiguous if the combined extent would be too large. |
| 1379 | * Also check for all-three-contiguous being too large. | 1275 | * Also check for all-three-contiguous being too large. |
| 1380 | */ | 1276 | */ |
| 1381 | if (STATE_SET_TEST(RIGHT_VALID, | 1277 | if (idx < ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t) - 1) { |
| 1382 | idx < | 1278 | state |= BMAP_RIGHT_VALID; |
| 1383 | ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t) - 1)) { | ||
| 1384 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx + 1), &RIGHT); | 1279 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx + 1), &RIGHT); |
| 1385 | STATE_SET(RIGHT_DELAY, isnullstartblock(RIGHT.br_startblock)); | 1280 | if (isnullstartblock(RIGHT.br_startblock)) |
| 1281 | state |= BMAP_RIGHT_DELAY; | ||
| 1386 | } | 1282 | } |
| 1387 | STATE_SET(RIGHT_CONTIG, | 1283 | |
| 1388 | STATE_TEST(RIGHT_VALID) && !STATE_TEST(RIGHT_DELAY) && | 1284 | if ((state & BMAP_RIGHT_VALID) && !(state & BMAP_RIGHT_DELAY) && |
| 1389 | new_endoff == RIGHT.br_startoff && | 1285 | new_endoff == RIGHT.br_startoff && |
| 1390 | new->br_startblock + new->br_blockcount == | 1286 | new->br_startblock + new->br_blockcount == RIGHT.br_startblock && |
| 1391 | RIGHT.br_startblock && | 1287 | newext == RIGHT.br_state && |
| 1392 | newext == RIGHT.br_state && | 1288 | new->br_blockcount + RIGHT.br_blockcount <= MAXEXTLEN && |
| 1393 | new->br_blockcount + RIGHT.br_blockcount <= MAXEXTLEN && | 1289 | ((state & (BMAP_LEFT_CONTIG | BMAP_LEFT_FILLING | |
| 1394 | ((state & MASK3(LEFT_CONTIG, LEFT_FILLING, RIGHT_FILLING)) != | 1290 | BMAP_RIGHT_FILLING)) != |
| 1395 | MASK3(LEFT_CONTIG, LEFT_FILLING, RIGHT_FILLING) || | 1291 | (BMAP_LEFT_CONTIG | BMAP_LEFT_FILLING | |
| 1396 | LEFT.br_blockcount + new->br_blockcount + RIGHT.br_blockcount | 1292 | BMAP_RIGHT_FILLING) || |
| 1397 | <= MAXEXTLEN)); | 1293 | LEFT.br_blockcount + new->br_blockcount + RIGHT.br_blockcount |
| 1294 | <= MAXEXTLEN)) | ||
| 1295 | state |= BMAP_RIGHT_CONTIG; | ||
| 1296 | |||
| 1398 | /* | 1297 | /* |
| 1399 | * Switch out based on the FILLING and CONTIG state bits. | 1298 | * Switch out based on the FILLING and CONTIG state bits. |
| 1400 | */ | 1299 | */ |
| 1401 | switch (SWITCH_STATE) { | 1300 | switch (state & (BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | |
| 1402 | 1301 | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG)) { | |
| 1403 | case MASK4(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 1302 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | |
| 1303 | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: | ||
| 1404 | /* | 1304 | /* |
| 1405 | * Setting all of a previous oldext extent to newext. | 1305 | * Setting all of a previous oldext extent to newext. |
| 1406 | * The left and right neighbors are both contiguous with new. | 1306 | * The left and right neighbors are both contiguous with new. |
| 1407 | */ | 1307 | */ |
| 1408 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|LC|RC", ip, idx - 1, | 1308 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 1409 | XFS_DATA_FORK); | ||
| 1410 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 1309 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 1411 | LEFT.br_blockcount + PREV.br_blockcount + | 1310 | LEFT.br_blockcount + PREV.br_blockcount + |
| 1412 | RIGHT.br_blockcount); | 1311 | RIGHT.br_blockcount); |
| 1413 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|LC|RC", ip, idx - 1, | 1312 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 1414 | XFS_DATA_FORK); | 1313 | |
| 1415 | XFS_BMAP_TRACE_DELETE("LF|RF|LC|RC", ip, idx, 2, XFS_DATA_FORK); | 1314 | xfs_iext_remove(ip, idx, 2, state); |
| 1416 | xfs_iext_remove(ifp, idx, 2); | ||
| 1417 | ip->i_df.if_lastex = idx - 1; | 1315 | ip->i_df.if_lastex = idx - 1; |
| 1418 | ip->i_d.di_nextents -= 2; | 1316 | ip->i_d.di_nextents -= 2; |
| 1419 | if (cur == NULL) | 1317 | if (cur == NULL) |
| @@ -1450,20 +1348,18 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1450 | RIGHT.br_blockcount; | 1348 | RIGHT.br_blockcount; |
| 1451 | break; | 1349 | break; |
| 1452 | 1350 | ||
| 1453 | case MASK3(LEFT_FILLING, RIGHT_FILLING, LEFT_CONTIG): | 1351 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG: |
| 1454 | /* | 1352 | /* |
| 1455 | * Setting all of a previous oldext extent to newext. | 1353 | * Setting all of a previous oldext extent to newext. |
| 1456 | * The left neighbor is contiguous, the right is not. | 1354 | * The left neighbor is contiguous, the right is not. |
| 1457 | */ | 1355 | */ |
| 1458 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|LC", ip, idx - 1, | 1356 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 1459 | XFS_DATA_FORK); | ||
| 1460 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 1357 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 1461 | LEFT.br_blockcount + PREV.br_blockcount); | 1358 | LEFT.br_blockcount + PREV.br_blockcount); |
| 1462 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|LC", ip, idx - 1, | 1359 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 1463 | XFS_DATA_FORK); | 1360 | |
| 1464 | ip->i_df.if_lastex = idx - 1; | 1361 | ip->i_df.if_lastex = idx - 1; |
| 1465 | XFS_BMAP_TRACE_DELETE("LF|RF|LC", ip, idx, 1, XFS_DATA_FORK); | 1362 | xfs_iext_remove(ip, idx, 1, state); |
| 1466 | xfs_iext_remove(ifp, idx, 1); | ||
| 1467 | ip->i_d.di_nextents--; | 1363 | ip->i_d.di_nextents--; |
| 1468 | if (cur == NULL) | 1364 | if (cur == NULL) |
| 1469 | rval = XFS_ILOG_CORE | XFS_ILOG_DEXT; | 1365 | rval = XFS_ILOG_CORE | XFS_ILOG_DEXT; |
| @@ -1492,21 +1388,18 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1492 | PREV.br_blockcount; | 1388 | PREV.br_blockcount; |
| 1493 | break; | 1389 | break; |
| 1494 | 1390 | ||
| 1495 | case MASK3(LEFT_FILLING, RIGHT_FILLING, RIGHT_CONTIG): | 1391 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: |
| 1496 | /* | 1392 | /* |
| 1497 | * Setting all of a previous oldext extent to newext. | 1393 | * Setting all of a previous oldext extent to newext. |
| 1498 | * The right neighbor is contiguous, the left is not. | 1394 | * The right neighbor is contiguous, the left is not. |
| 1499 | */ | 1395 | */ |
| 1500 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF|RC", ip, idx, | 1396 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1501 | XFS_DATA_FORK); | ||
| 1502 | xfs_bmbt_set_blockcount(ep, | 1397 | xfs_bmbt_set_blockcount(ep, |
| 1503 | PREV.br_blockcount + RIGHT.br_blockcount); | 1398 | PREV.br_blockcount + RIGHT.br_blockcount); |
| 1504 | xfs_bmbt_set_state(ep, newext); | 1399 | xfs_bmbt_set_state(ep, newext); |
| 1505 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF|RC", ip, idx, | 1400 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1506 | XFS_DATA_FORK); | ||
| 1507 | ip->i_df.if_lastex = idx; | 1401 | ip->i_df.if_lastex = idx; |
| 1508 | XFS_BMAP_TRACE_DELETE("LF|RF|RC", ip, idx + 1, 1, XFS_DATA_FORK); | 1402 | xfs_iext_remove(ip, idx + 1, 1, state); |
| 1509 | xfs_iext_remove(ifp, idx + 1, 1); | ||
| 1510 | ip->i_d.di_nextents--; | 1403 | ip->i_d.di_nextents--; |
| 1511 | if (cur == NULL) | 1404 | if (cur == NULL) |
| 1512 | rval = XFS_ILOG_CORE | XFS_ILOG_DEXT; | 1405 | rval = XFS_ILOG_CORE | XFS_ILOG_DEXT; |
| @@ -1535,17 +1428,16 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1535 | RIGHT.br_blockcount; | 1428 | RIGHT.br_blockcount; |
| 1536 | break; | 1429 | break; |
| 1537 | 1430 | ||
| 1538 | case MASK2(LEFT_FILLING, RIGHT_FILLING): | 1431 | case BMAP_LEFT_FILLING | BMAP_RIGHT_FILLING: |
| 1539 | /* | 1432 | /* |
| 1540 | * Setting all of a previous oldext extent to newext. | 1433 | * Setting all of a previous oldext extent to newext. |
| 1541 | * Neither the left nor right neighbors are contiguous with | 1434 | * Neither the left nor right neighbors are contiguous with |
| 1542 | * the new one. | 1435 | * the new one. |
| 1543 | */ | 1436 | */ |
| 1544 | XFS_BMAP_TRACE_PRE_UPDATE("LF|RF", ip, idx, | 1437 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1545 | XFS_DATA_FORK); | ||
| 1546 | xfs_bmbt_set_state(ep, newext); | 1438 | xfs_bmbt_set_state(ep, newext); |
| 1547 | XFS_BMAP_TRACE_POST_UPDATE("LF|RF", ip, idx, | 1439 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1548 | XFS_DATA_FORK); | 1440 | |
| 1549 | ip->i_df.if_lastex = idx; | 1441 | ip->i_df.if_lastex = idx; |
| 1550 | if (cur == NULL) | 1442 | if (cur == NULL) |
| 1551 | rval = XFS_ILOG_DEXT; | 1443 | rval = XFS_ILOG_DEXT; |
| @@ -1566,27 +1458,25 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1566 | temp2 = new->br_blockcount; | 1458 | temp2 = new->br_blockcount; |
| 1567 | break; | 1459 | break; |
| 1568 | 1460 | ||
| 1569 | case MASK2(LEFT_FILLING, LEFT_CONTIG): | 1461 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG: |
| 1570 | /* | 1462 | /* |
| 1571 | * Setting the first part of a previous oldext extent to newext. | 1463 | * Setting the first part of a previous oldext extent to newext. |
| 1572 | * The left neighbor is contiguous. | 1464 | * The left neighbor is contiguous. |
| 1573 | */ | 1465 | */ |
| 1574 | XFS_BMAP_TRACE_PRE_UPDATE("LF|LC", ip, idx - 1, | 1466 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 1575 | XFS_DATA_FORK); | ||
| 1576 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 1467 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 1577 | LEFT.br_blockcount + new->br_blockcount); | 1468 | LEFT.br_blockcount + new->br_blockcount); |
| 1578 | xfs_bmbt_set_startoff(ep, | 1469 | xfs_bmbt_set_startoff(ep, |
| 1579 | PREV.br_startoff + new->br_blockcount); | 1470 | PREV.br_startoff + new->br_blockcount); |
| 1580 | XFS_BMAP_TRACE_POST_UPDATE("LF|LC", ip, idx - 1, | 1471 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 1581 | XFS_DATA_FORK); | 1472 | |
| 1582 | XFS_BMAP_TRACE_PRE_UPDATE("LF|LC", ip, idx, | 1473 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1583 | XFS_DATA_FORK); | ||
| 1584 | xfs_bmbt_set_startblock(ep, | 1474 | xfs_bmbt_set_startblock(ep, |
| 1585 | new->br_startblock + new->br_blockcount); | 1475 | new->br_startblock + new->br_blockcount); |
| 1586 | xfs_bmbt_set_blockcount(ep, | 1476 | xfs_bmbt_set_blockcount(ep, |
| 1587 | PREV.br_blockcount - new->br_blockcount); | 1477 | PREV.br_blockcount - new->br_blockcount); |
| 1588 | XFS_BMAP_TRACE_POST_UPDATE("LF|LC", ip, idx, | 1478 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1589 | XFS_DATA_FORK); | 1479 | |
| 1590 | ip->i_df.if_lastex = idx - 1; | 1480 | ip->i_df.if_lastex = idx - 1; |
| 1591 | if (cur == NULL) | 1481 | if (cur == NULL) |
| 1592 | rval = XFS_ILOG_DEXT; | 1482 | rval = XFS_ILOG_DEXT; |
| @@ -1617,22 +1507,21 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1617 | PREV.br_blockcount; | 1507 | PREV.br_blockcount; |
| 1618 | break; | 1508 | break; |
| 1619 | 1509 | ||
| 1620 | case MASK(LEFT_FILLING): | 1510 | case BMAP_LEFT_FILLING: |
| 1621 | /* | 1511 | /* |
| 1622 | * Setting the first part of a previous oldext extent to newext. | 1512 | * Setting the first part of a previous oldext extent to newext. |
| 1623 | * The left neighbor is not contiguous. | 1513 | * The left neighbor is not contiguous. |
| 1624 | */ | 1514 | */ |
| 1625 | XFS_BMAP_TRACE_PRE_UPDATE("LF", ip, idx, XFS_DATA_FORK); | 1515 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1626 | ASSERT(ep && xfs_bmbt_get_state(ep) == oldext); | 1516 | ASSERT(ep && xfs_bmbt_get_state(ep) == oldext); |
| 1627 | xfs_bmbt_set_startoff(ep, new_endoff); | 1517 | xfs_bmbt_set_startoff(ep, new_endoff); |
| 1628 | xfs_bmbt_set_blockcount(ep, | 1518 | xfs_bmbt_set_blockcount(ep, |
| 1629 | PREV.br_blockcount - new->br_blockcount); | 1519 | PREV.br_blockcount - new->br_blockcount); |
| 1630 | xfs_bmbt_set_startblock(ep, | 1520 | xfs_bmbt_set_startblock(ep, |
| 1631 | new->br_startblock + new->br_blockcount); | 1521 | new->br_startblock + new->br_blockcount); |
| 1632 | XFS_BMAP_TRACE_POST_UPDATE("LF", ip, idx, XFS_DATA_FORK); | 1522 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1633 | XFS_BMAP_TRACE_INSERT("LF", ip, idx, 1, new, NULL, | 1523 | |
| 1634 | XFS_DATA_FORK); | 1524 | xfs_iext_insert(ip, idx, 1, new, state); |
| 1635 | xfs_iext_insert(ifp, idx, 1, new); | ||
| 1636 | ip->i_df.if_lastex = idx; | 1525 | ip->i_df.if_lastex = idx; |
| 1637 | ip->i_d.di_nextents++; | 1526 | ip->i_d.di_nextents++; |
| 1638 | if (cur == NULL) | 1527 | if (cur == NULL) |
| @@ -1660,24 +1549,21 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1660 | temp2 = PREV.br_blockcount; | 1549 | temp2 = PREV.br_blockcount; |
| 1661 | break; | 1550 | break; |
| 1662 | 1551 | ||
| 1663 | case MASK2(RIGHT_FILLING, RIGHT_CONTIG): | 1552 | case BMAP_RIGHT_FILLING | BMAP_RIGHT_CONTIG: |
| 1664 | /* | 1553 | /* |
| 1665 | * Setting the last part of a previous oldext extent to newext. | 1554 | * Setting the last part of a previous oldext extent to newext. |
| 1666 | * The right neighbor is contiguous with the new allocation. | 1555 | * The right neighbor is contiguous with the new allocation. |
| 1667 | */ | 1556 | */ |
| 1668 | XFS_BMAP_TRACE_PRE_UPDATE("RF|RC", ip, idx, | 1557 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1669 | XFS_DATA_FORK); | 1558 | trace_xfs_bmap_pre_update(ip, idx + 1, state, _THIS_IP_); |
| 1670 | XFS_BMAP_TRACE_PRE_UPDATE("RF|RC", ip, idx + 1, | ||
| 1671 | XFS_DATA_FORK); | ||
| 1672 | xfs_bmbt_set_blockcount(ep, | 1559 | xfs_bmbt_set_blockcount(ep, |
| 1673 | PREV.br_blockcount - new->br_blockcount); | 1560 | PREV.br_blockcount - new->br_blockcount); |
| 1674 | XFS_BMAP_TRACE_POST_UPDATE("RF|RC", ip, idx, | 1561 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1675 | XFS_DATA_FORK); | ||
| 1676 | xfs_bmbt_set_allf(xfs_iext_get_ext(ifp, idx + 1), | 1562 | xfs_bmbt_set_allf(xfs_iext_get_ext(ifp, idx + 1), |
| 1677 | new->br_startoff, new->br_startblock, | 1563 | new->br_startoff, new->br_startblock, |
| 1678 | new->br_blockcount + RIGHT.br_blockcount, newext); | 1564 | new->br_blockcount + RIGHT.br_blockcount, newext); |
| 1679 | XFS_BMAP_TRACE_POST_UPDATE("RF|RC", ip, idx + 1, | 1565 | trace_xfs_bmap_post_update(ip, idx + 1, state, _THIS_IP_); |
| 1680 | XFS_DATA_FORK); | 1566 | |
| 1681 | ip->i_df.if_lastex = idx + 1; | 1567 | ip->i_df.if_lastex = idx + 1; |
| 1682 | if (cur == NULL) | 1568 | if (cur == NULL) |
| 1683 | rval = XFS_ILOG_DEXT; | 1569 | rval = XFS_ILOG_DEXT; |
| @@ -1707,18 +1593,17 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1707 | RIGHT.br_blockcount; | 1593 | RIGHT.br_blockcount; |
| 1708 | break; | 1594 | break; |
| 1709 | 1595 | ||
| 1710 | case MASK(RIGHT_FILLING): | 1596 | case BMAP_RIGHT_FILLING: |
| 1711 | /* | 1597 | /* |
| 1712 | * Setting the last part of a previous oldext extent to newext. | 1598 | * Setting the last part of a previous oldext extent to newext. |
| 1713 | * The right neighbor is not contiguous. | 1599 | * The right neighbor is not contiguous. |
| 1714 | */ | 1600 | */ |
| 1715 | XFS_BMAP_TRACE_PRE_UPDATE("RF", ip, idx, XFS_DATA_FORK); | 1601 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1716 | xfs_bmbt_set_blockcount(ep, | 1602 | xfs_bmbt_set_blockcount(ep, |
| 1717 | PREV.br_blockcount - new->br_blockcount); | 1603 | PREV.br_blockcount - new->br_blockcount); |
| 1718 | XFS_BMAP_TRACE_POST_UPDATE("RF", ip, idx, XFS_DATA_FORK); | 1604 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1719 | XFS_BMAP_TRACE_INSERT("RF", ip, idx + 1, 1, new, NULL, | 1605 | |
| 1720 | XFS_DATA_FORK); | 1606 | xfs_iext_insert(ip, idx + 1, 1, new, state); |
| 1721 | xfs_iext_insert(ifp, idx + 1, 1, new); | ||
| 1722 | ip->i_df.if_lastex = idx + 1; | 1607 | ip->i_df.if_lastex = idx + 1; |
| 1723 | ip->i_d.di_nextents++; | 1608 | ip->i_d.di_nextents++; |
| 1724 | if (cur == NULL) | 1609 | if (cur == NULL) |
| @@ -1756,19 +1641,18 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1756 | * newext. Contiguity is impossible here. | 1641 | * newext. Contiguity is impossible here. |
| 1757 | * One extent becomes three extents. | 1642 | * One extent becomes three extents. |
| 1758 | */ | 1643 | */ |
| 1759 | XFS_BMAP_TRACE_PRE_UPDATE("0", ip, idx, XFS_DATA_FORK); | 1644 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1760 | xfs_bmbt_set_blockcount(ep, | 1645 | xfs_bmbt_set_blockcount(ep, |
| 1761 | new->br_startoff - PREV.br_startoff); | 1646 | new->br_startoff - PREV.br_startoff); |
| 1762 | XFS_BMAP_TRACE_POST_UPDATE("0", ip, idx, XFS_DATA_FORK); | 1647 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1648 | |||
| 1763 | r[0] = *new; | 1649 | r[0] = *new; |
| 1764 | r[1].br_startoff = new_endoff; | 1650 | r[1].br_startoff = new_endoff; |
| 1765 | r[1].br_blockcount = | 1651 | r[1].br_blockcount = |
| 1766 | PREV.br_startoff + PREV.br_blockcount - new_endoff; | 1652 | PREV.br_startoff + PREV.br_blockcount - new_endoff; |
| 1767 | r[1].br_startblock = new->br_startblock + new->br_blockcount; | 1653 | r[1].br_startblock = new->br_startblock + new->br_blockcount; |
| 1768 | r[1].br_state = oldext; | 1654 | r[1].br_state = oldext; |
| 1769 | XFS_BMAP_TRACE_INSERT("0", ip, idx + 1, 2, &r[0], &r[1], | 1655 | xfs_iext_insert(ip, idx + 1, 2, &r[0], state); |
| 1770 | XFS_DATA_FORK); | ||
| 1771 | xfs_iext_insert(ifp, idx + 1, 2, &r[0]); | ||
| 1772 | ip->i_df.if_lastex = idx + 1; | 1656 | ip->i_df.if_lastex = idx + 1; |
| 1773 | ip->i_d.di_nextents += 2; | 1657 | ip->i_d.di_nextents += 2; |
| 1774 | if (cur == NULL) | 1658 | if (cur == NULL) |
| @@ -1813,13 +1697,13 @@ xfs_bmap_add_extent_unwritten_real( | |||
| 1813 | temp2 = PREV.br_blockcount; | 1697 | temp2 = PREV.br_blockcount; |
| 1814 | break; | 1698 | break; |
| 1815 | 1699 | ||
| 1816 | case MASK3(LEFT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 1700 | case BMAP_LEFT_FILLING | BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1817 | case MASK3(RIGHT_FILLING, LEFT_CONTIG, RIGHT_CONTIG): | 1701 | case BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1818 | case MASK2(LEFT_FILLING, RIGHT_CONTIG): | 1702 | case BMAP_LEFT_FILLING | BMAP_RIGHT_CONTIG: |
| 1819 | case MASK2(RIGHT_FILLING, LEFT_CONTIG): | 1703 | case BMAP_RIGHT_FILLING | BMAP_LEFT_CONTIG: |
| 1820 | case MASK2(LEFT_CONTIG, RIGHT_CONTIG): | 1704 | case BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: |
| 1821 | case MASK(LEFT_CONTIG): | 1705 | case BMAP_LEFT_CONTIG: |
| 1822 | case MASK(RIGHT_CONTIG): | 1706 | case BMAP_RIGHT_CONTIG: |
| 1823 | /* | 1707 | /* |
| 1824 | * These cases are all impossible. | 1708 | * These cases are all impossible. |
| 1825 | */ | 1709 | */ |
| @@ -1839,14 +1723,6 @@ done: | |||
| 1839 | #undef LEFT | 1723 | #undef LEFT |
| 1840 | #undef RIGHT | 1724 | #undef RIGHT |
| 1841 | #undef PREV | 1725 | #undef PREV |
| 1842 | #undef MASK | ||
| 1843 | #undef MASK2 | ||
| 1844 | #undef MASK3 | ||
| 1845 | #undef MASK4 | ||
| 1846 | #undef STATE_SET | ||
| 1847 | #undef STATE_TEST | ||
| 1848 | #undef STATE_SET_TEST | ||
| 1849 | #undef SWITCH_STATE | ||
| 1850 | } | 1726 | } |
| 1851 | 1727 | ||
| 1852 | /* | 1728 | /* |
| @@ -1872,62 +1748,57 @@ xfs_bmap_add_extent_hole_delay( | |||
| 1872 | int state; /* state bits, accessed thru macros */ | 1748 | int state; /* state bits, accessed thru macros */ |
| 1873 | xfs_filblks_t temp=0; /* temp for indirect calculations */ | 1749 | xfs_filblks_t temp=0; /* temp for indirect calculations */ |
| 1874 | xfs_filblks_t temp2=0; | 1750 | xfs_filblks_t temp2=0; |
| 1875 | enum { /* bit number definitions for state */ | ||
| 1876 | LEFT_CONTIG, RIGHT_CONTIG, | ||
| 1877 | LEFT_DELAY, RIGHT_DELAY, | ||
| 1878 | LEFT_VALID, RIGHT_VALID | ||
| 1879 | }; | ||
| 1880 | |||
| 1881 | #define MASK(b) (1 << (b)) | ||
| 1882 | #define MASK2(a,b) (MASK(a) | MASK(b)) | ||
| 1883 | #define STATE_SET(b,v) ((v) ? (state |= MASK(b)) : (state &= ~MASK(b))) | ||
| 1884 | #define STATE_TEST(b) (state & MASK(b)) | ||
| 1885 | #define STATE_SET_TEST(b,v) ((v) ? ((state |= MASK(b)), 1) : \ | ||
| 1886 | ((state &= ~MASK(b)), 0)) | ||
| 1887 | #define SWITCH_STATE (state & MASK2(LEFT_CONTIG, RIGHT_CONTIG)) | ||
| 1888 | 1751 | ||
| 1889 | ifp = XFS_IFORK_PTR(ip, XFS_DATA_FORK); | 1752 | ifp = XFS_IFORK_PTR(ip, XFS_DATA_FORK); |
| 1890 | ep = xfs_iext_get_ext(ifp, idx); | 1753 | ep = xfs_iext_get_ext(ifp, idx); |
| 1891 | state = 0; | 1754 | state = 0; |
| 1892 | ASSERT(isnullstartblock(new->br_startblock)); | 1755 | ASSERT(isnullstartblock(new->br_startblock)); |
| 1756 | |||
| 1893 | /* | 1757 | /* |
| 1894 | * Check and set flags if this segment has a left neighbor | 1758 | * Check and set flags if this segment has a left neighbor |
| 1895 | */ | 1759 | */ |
| 1896 | if (STATE_SET_TEST(LEFT_VALID, idx > 0)) { | 1760 | if (idx > 0) { |
| 1761 | state |= BMAP_LEFT_VALID; | ||
| 1897 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &left); | 1762 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &left); |
| 1898 | STATE_SET(LEFT_DELAY, isnullstartblock(left.br_startblock)); | 1763 | |
| 1764 | if (isnullstartblock(left.br_startblock)) | ||
| 1765 | state |= BMAP_LEFT_DELAY; | ||
| 1899 | } | 1766 | } |
| 1767 | |||
| 1900 | /* | 1768 | /* |
| 1901 | * Check and set flags if the current (right) segment exists. | 1769 | * Check and set flags if the current (right) segment exists. |
| 1902 | * If it doesn't exist, we're converting the hole at end-of-file. | 1770 | * If it doesn't exist, we're converting the hole at end-of-file. |
| 1903 | */ | 1771 | */ |
| 1904 | if (STATE_SET_TEST(RIGHT_VALID, | 1772 | if (idx < ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t)) { |
| 1905 | idx < | 1773 | state |= BMAP_RIGHT_VALID; |
| 1906 | ip->i_df.if_bytes / (uint)sizeof(xfs_bmbt_rec_t))) { | ||
| 1907 | xfs_bmbt_get_all(ep, &right); | 1774 | xfs_bmbt_get_all(ep, &right); |
| 1908 | STATE_SET(RIGHT_DELAY, isnullstartblock(right.br_startblock)); | 1775 | |
| 1776 | if (isnullstartblock(right.br_startblock)) | ||
| 1777 | state |= BMAP_RIGHT_DELAY; | ||
| 1909 | } | 1778 | } |
| 1779 | |||
| 1910 | /* | 1780 | /* |
| 1911 | * Set contiguity flags on the left and right neighbors. | 1781 | * Set contiguity flags on the left and right neighbors. |
| 1912 | * Don't let extents get too large, even if the pieces are contiguous. | 1782 | * Don't let extents get too large, even if the pieces are contiguous. |
| 1913 | */ | 1783 | */ |
| 1914 | STATE_SET(LEFT_CONTIG, | 1784 | if ((state & BMAP_LEFT_VALID) && (state & BMAP_LEFT_DELAY) && |
| 1915 | STATE_TEST(LEFT_VALID) && STATE_TEST(LEFT_DELAY) && | 1785 | left.br_startoff + left.br_blockcount == new->br_startoff && |
| 1916 | left.br_startoff + left.br_blockcount == new->br_startoff && | 1786 | left.br_blockcount + new->br_blockcount <= MAXEXTLEN) |
| 1917 | left.br_blockcount + new->br_blockcount <= MAXEXTLEN); | 1787 | state |= BMAP_LEFT_CONTIG; |
| 1918 | STATE_SET(RIGHT_CONTIG, | 1788 | |
| 1919 | STATE_TEST(RIGHT_VALID) && STATE_TEST(RIGHT_DELAY) && | 1789 | if ((state & BMAP_RIGHT_VALID) && (state & BMAP_RIGHT_DELAY) && |
| 1920 | new->br_startoff + new->br_blockcount == right.br_startoff && | 1790 | new->br_startoff + new->br_blockcount == right.br_startoff && |
| 1921 | new->br_blockcount + right.br_blockcount <= MAXEXTLEN && | 1791 | new->br_blockcount + right.br_blockcount <= MAXEXTLEN && |
| 1922 | (!STATE_TEST(LEFT_CONTIG) || | 1792 | (!(state & BMAP_LEFT_CONTIG) || |
| 1923 | (left.br_blockcount + new->br_blockcount + | 1793 | (left.br_blockcount + new->br_blockcount + |
| 1924 | right.br_blockcount <= MAXEXTLEN))); | 1794 | right.br_blockcount <= MAXEXTLEN))) |
| 1795 | state |= BMAP_RIGHT_CONTIG; | ||
| 1796 | |||
| 1925 | /* | 1797 | /* |
| 1926 | * Switch out based on the contiguity flags. | 1798 | * Switch out based on the contiguity flags. |
| 1927 | */ | 1799 | */ |
| 1928 | switch (SWITCH_STATE) { | 1800 | switch (state & (BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG)) { |
| 1929 | 1801 | case BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: | |
| 1930 | case MASK2(LEFT_CONTIG, RIGHT_CONTIG): | ||
| 1931 | /* | 1802 | /* |
| 1932 | * New allocation is contiguous with delayed allocations | 1803 | * New allocation is contiguous with delayed allocations |
| 1933 | * on the left and on the right. | 1804 | * on the left and on the right. |
| @@ -1935,8 +1806,8 @@ xfs_bmap_add_extent_hole_delay( | |||
| 1935 | */ | 1806 | */ |
| 1936 | temp = left.br_blockcount + new->br_blockcount + | 1807 | temp = left.br_blockcount + new->br_blockcount + |
| 1937 | right.br_blockcount; | 1808 | right.br_blockcount; |
| 1938 | XFS_BMAP_TRACE_PRE_UPDATE("LC|RC", ip, idx - 1, | 1809 | |
| 1939 | XFS_DATA_FORK); | 1810 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 1940 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), temp); | 1811 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), temp); |
| 1941 | oldlen = startblockval(left.br_startblock) + | 1812 | oldlen = startblockval(left.br_startblock) + |
| 1942 | startblockval(new->br_startblock) + | 1813 | startblockval(new->br_startblock) + |
| @@ -1944,53 +1815,52 @@ xfs_bmap_add_extent_hole_delay( | |||
| 1944 | newlen = xfs_bmap_worst_indlen(ip, temp); | 1815 | newlen = xfs_bmap_worst_indlen(ip, temp); |
| 1945 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx - 1), | 1816 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx - 1), |
| 1946 | nullstartblock((int)newlen)); | 1817 | nullstartblock((int)newlen)); |
| 1947 | XFS_BMAP_TRACE_POST_UPDATE("LC|RC", ip, idx - 1, | 1818 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 1948 | XFS_DATA_FORK); | 1819 | |
| 1949 | XFS_BMAP_TRACE_DELETE("LC|RC", ip, idx, 1, XFS_DATA_FORK); | 1820 | xfs_iext_remove(ip, idx, 1, state); |
| 1950 | xfs_iext_remove(ifp, idx, 1); | ||
| 1951 | ip->i_df.if_lastex = idx - 1; | 1821 | ip->i_df.if_lastex = idx - 1; |
| 1952 | /* DELTA: Two in-core extents were replaced by one. */ | 1822 | /* DELTA: Two in-core extents were replaced by one. */ |
| 1953 | temp2 = temp; | 1823 | temp2 = temp; |
| 1954 | temp = left.br_startoff; | 1824 | temp = left.br_startoff; |
| 1955 | break; | 1825 | break; |
| 1956 | 1826 | ||
| 1957 | case MASK(LEFT_CONTIG): | 1827 | case BMAP_LEFT_CONTIG: |
| 1958 | /* | 1828 | /* |
| 1959 | * New allocation is contiguous with a delayed allocation | 1829 | * New allocation is contiguous with a delayed allocation |
| 1960 | * on the left. | 1830 | * on the left. |
| 1961 | * Merge the new allocation with the left neighbor. | 1831 | * Merge the new allocation with the left neighbor. |
| 1962 | */ | 1832 | */ |
| 1963 | temp = left.br_blockcount + new->br_blockcount; | 1833 | temp = left.br_blockcount + new->br_blockcount; |
| 1964 | XFS_BMAP_TRACE_PRE_UPDATE("LC", ip, idx - 1, | 1834 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 1965 | XFS_DATA_FORK); | ||
| 1966 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), temp); | 1835 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), temp); |
| 1967 | oldlen = startblockval(left.br_startblock) + | 1836 | oldlen = startblockval(left.br_startblock) + |
| 1968 | startblockval(new->br_startblock); | 1837 | startblockval(new->br_startblock); |
| 1969 | newlen = xfs_bmap_worst_indlen(ip, temp); | 1838 | newlen = xfs_bmap_worst_indlen(ip, temp); |
| 1970 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx - 1), | 1839 | xfs_bmbt_set_startblock(xfs_iext_get_ext(ifp, idx - 1), |
| 1971 | nullstartblock((int)newlen)); | 1840 | nullstartblock((int)newlen)); |
| 1972 | XFS_BMAP_TRACE_POST_UPDATE("LC", ip, idx - 1, | 1841 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 1973 | XFS_DATA_FORK); | 1842 | |
| 1974 | ip->i_df.if_lastex = idx - 1; | 1843 | ip->i_df.if_lastex = idx - 1; |
| 1975 | /* DELTA: One in-core extent grew into a hole. */ | 1844 | /* DELTA: One in-core extent grew into a hole. */ |
| 1976 | temp2 = temp; | 1845 | temp2 = temp; |
| 1977 | temp = left.br_startoff; | 1846 | temp = left.br_startoff; |
| 1978 | break; | 1847 | break; |
| 1979 | 1848 | ||
| 1980 | case MASK(RIGHT_CONTIG): | 1849 | case BMAP_RIGHT_CONTIG: |
| 1981 | /* | 1850 | /* |
| 1982 | * New allocation is contiguous with a delayed allocation | 1851 | * New allocation is contiguous with a delayed allocation |
| 1983 | * on the right. | 1852 | * on the right. |
| 1984 | * Merge the new allocation with the right neighbor. | 1853 | * Merge the new allocation with the right neighbor. |
| 1985 | */ | 1854 | */ |
| 1986 | XFS_BMAP_TRACE_PRE_UPDATE("RC", ip, idx, XFS_DATA_FORK); | 1855 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 1987 | temp = new->br_blockcount + right.br_blockcount; | 1856 | temp = new->br_blockcount + right.br_blockcount; |
| 1988 | oldlen = startblockval(new->br_startblock) + | 1857 | oldlen = startblockval(new->br_startblock) + |
| 1989 | startblockval(right.br_startblock); | 1858 | startblockval(right.br_startblock); |
| 1990 | newlen = xfs_bmap_worst_indlen(ip, temp); | 1859 | newlen = xfs_bmap_worst_indlen(ip, temp); |
| 1991 | xfs_bmbt_set_allf(ep, new->br_startoff, | 1860 | xfs_bmbt_set_allf(ep, new->br_startoff, |
| 1992 | nullstartblock((int)newlen), temp, right.br_state); | 1861 | nullstartblock((int)newlen), temp, right.br_state); |
| 1993 | XFS_BMAP_TRACE_POST_UPDATE("RC", ip, idx, XFS_DATA_FORK); | 1862 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 1863 | |||
| 1994 | ip->i_df.if_lastex = idx; | 1864 | ip->i_df.if_lastex = idx; |
| 1995 | /* DELTA: One in-core extent grew into a hole. */ | 1865 | /* DELTA: One in-core extent grew into a hole. */ |
| 1996 | temp2 = temp; | 1866 | temp2 = temp; |
| @@ -2004,9 +1874,7 @@ xfs_bmap_add_extent_hole_delay( | |||
| 2004 | * Insert a new entry. | 1874 | * Insert a new entry. |
| 2005 | */ | 1875 | */ |
| 2006 | oldlen = newlen = 0; | 1876 | oldlen = newlen = 0; |
| 2007 | XFS_BMAP_TRACE_INSERT("0", ip, idx, 1, new, NULL, | 1877 | xfs_iext_insert(ip, idx, 1, new, state); |
| 2008 | XFS_DATA_FORK); | ||
| 2009 | xfs_iext_insert(ifp, idx, 1, new); | ||
| 2010 | ip->i_df.if_lastex = idx; | 1878 | ip->i_df.if_lastex = idx; |
| 2011 | /* DELTA: A new in-core extent was added in a hole. */ | 1879 | /* DELTA: A new in-core extent was added in a hole. */ |
| 2012 | temp2 = new->br_blockcount; | 1880 | temp2 = new->br_blockcount; |
| @@ -2030,12 +1898,6 @@ xfs_bmap_add_extent_hole_delay( | |||
| 2030 | } | 1898 | } |
| 2031 | *logflagsp = 0; | 1899 | *logflagsp = 0; |
| 2032 | return 0; | 1900 | return 0; |
| 2033 | #undef MASK | ||
| 2034 | #undef MASK2 | ||
| 2035 | #undef STATE_SET | ||
| 2036 | #undef STATE_TEST | ||
| 2037 | #undef STATE_SET_TEST | ||
| 2038 | #undef SWITCH_STATE | ||
| 2039 | } | 1901 | } |
| 2040 | 1902 | ||
| 2041 | /* | 1903 | /* |
| @@ -2062,83 +1924,75 @@ xfs_bmap_add_extent_hole_real( | |||
| 2062 | int state; /* state bits, accessed thru macros */ | 1924 | int state; /* state bits, accessed thru macros */ |
| 2063 | xfs_filblks_t temp=0; | 1925 | xfs_filblks_t temp=0; |
| 2064 | xfs_filblks_t temp2=0; | 1926 | xfs_filblks_t temp2=0; |
| 2065 | enum { /* bit number definitions for state */ | ||
| 2066 | LEFT_CONTIG, RIGHT_CONTIG, | ||
| 2067 | LEFT_DELAY, RIGHT_DELAY, | ||
| 2068 | LEFT_VALID, RIGHT_VALID | ||
| 2069 | }; | ||
| 2070 | |||
| 2071 | #define MASK(b) (1 << (b)) | ||
| 2072 | #define MASK2(a,b) (MASK(a) | MASK(b)) | ||
| 2073 | #define STATE_SET(b,v) ((v) ? (state |= MASK(b)) : (state &= ~MASK(b))) | ||
| 2074 | #define STATE_TEST(b) (state & MASK(b)) | ||
| 2075 | #define STATE_SET_TEST(b,v) ((v) ? ((state |= MASK(b)), 1) : \ | ||
| 2076 | ((state &= ~MASK(b)), 0)) | ||
| 2077 | #define SWITCH_STATE (state & MASK2(LEFT_CONTIG, RIGHT_CONTIG)) | ||
| 2078 | 1927 | ||
| 2079 | ifp = XFS_IFORK_PTR(ip, whichfork); | 1928 | ifp = XFS_IFORK_PTR(ip, whichfork); |
| 2080 | ASSERT(idx <= ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t)); | 1929 | ASSERT(idx <= ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t)); |
| 2081 | ep = xfs_iext_get_ext(ifp, idx); | 1930 | ep = xfs_iext_get_ext(ifp, idx); |
| 2082 | state = 0; | 1931 | state = 0; |
| 1932 | |||
| 1933 | if (whichfork == XFS_ATTR_FORK) | ||
| 1934 | state |= BMAP_ATTRFORK; | ||
| 1935 | |||
| 2083 | /* | 1936 | /* |
| 2084 | * Check and set flags if this segment has a left neighbor. | 1937 | * Check and set flags if this segment has a left neighbor. |
| 2085 | */ | 1938 | */ |
| 2086 | if (STATE_SET_TEST(LEFT_VALID, idx > 0)) { | 1939 | if (idx > 0) { |
| 1940 | state |= BMAP_LEFT_VALID; | ||
| 2087 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &left); | 1941 | xfs_bmbt_get_all(xfs_iext_get_ext(ifp, idx - 1), &left); |
| 2088 | STATE_SET(LEFT_DELAY, isnullstartblock(left.br_startblock)); | 1942 | if (isnullstartblock(left.br_startblock)) |
| 1943 | state |= BMAP_LEFT_DELAY; | ||
| 2089 | } | 1944 | } |
| 1945 | |||
| 2090 | /* | 1946 | /* |
| 2091 | * Check and set flags if this segment has a current value. | 1947 | * Check and set flags if this segment has a current value. |
| 2092 | * Not true if we're inserting into the "hole" at eof. | 1948 | * Not true if we're inserting into the "hole" at eof. |
| 2093 | */ | 1949 | */ |
| 2094 | if (STATE_SET_TEST(RIGHT_VALID, | 1950 | if (idx < ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t)) { |
| 2095 | idx < | 1951 | state |= BMAP_RIGHT_VALID; |
| 2096 | ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t))) { | ||
| 2097 | xfs_bmbt_get_all(ep, &right); | 1952 | xfs_bmbt_get_all(ep, &right); |
| 2098 | STATE_SET(RIGHT_DELAY, isnullstartblock(right.br_startblock)); | 1953 | if (isnullstartblock(right.br_startblock)) |
| 1954 | state |= BMAP_RIGHT_DELAY; | ||
| 2099 | } | 1955 | } |
| 1956 | |||
| 2100 | /* | 1957 | /* |
| 2101 | * We're inserting a real allocation between "left" and "right". | 1958 | * We're inserting a real allocation between "left" and "right". |
| 2102 | * Set the contiguity flags. Don't let extents get too large. | 1959 | * Set the contiguity flags. Don't let extents get too large. |
| 2103 | */ | 1960 | */ |
| 2104 | STATE_SET(LEFT_CONTIG, | 1961 | if ((state & BMAP_LEFT_VALID) && !(state & BMAP_LEFT_DELAY) && |
| 2105 | STATE_TEST(LEFT_VALID) && !STATE_TEST(LEFT_DELAY) && | 1962 | left.br_startoff + left.br_blockcount == new->br_startoff && |
| 2106 | left.br_startoff + left.br_blockcount == new->br_startoff && | 1963 | left.br_startblock + left.br_blockcount == new->br_startblock && |
| 2107 | left.br_startblock + left.br_blockcount == new->br_startblock && | 1964 | left.br_state == new->br_state && |
| 2108 | left.br_state == new->br_state && | 1965 | left.br_blockcount + new->br_blockcount <= MAXEXTLEN) |
| 2109 | left.br_blockcount + new->br_blockcount <= MAXEXTLEN); | 1966 | state |= BMAP_LEFT_CONTIG; |
| 2110 | STATE_SET(RIGHT_CONTIG, | 1967 | |
| 2111 | STATE_TEST(RIGHT_VALID) && !STATE_TEST(RIGHT_DELAY) && | 1968 | if ((state & BMAP_RIGHT_VALID) && !(state & BMAP_RIGHT_DELAY) && |
| 2112 | new->br_startoff + new->br_blockcount == right.br_startoff && | 1969 | new->br_startoff + new->br_blockcount == right.br_startoff && |
| 2113 | new->br_startblock + new->br_blockcount == | 1970 | new->br_startblock + new->br_blockcount == right.br_startblock && |
| 2114 | right.br_startblock && | 1971 | new->br_state == right.br_state && |
| 2115 | new->br_state == right.br_state && | 1972 | new->br_blockcount + right.br_blockcount <= MAXEXTLEN && |
| 2116 | new->br_blockcount + right.br_blockcount <= MAXEXTLEN && | 1973 | (!(state & BMAP_LEFT_CONTIG) || |
| 2117 | (!STATE_TEST(LEFT_CONTIG) || | 1974 | left.br_blockcount + new->br_blockcount + |
| 2118 | left.br_blockcount + new->br_blockcount + | 1975 | right.br_blockcount <= MAXEXTLEN)) |
| 2119 | right.br_blockcount <= MAXEXTLEN)); | 1976 | state |= BMAP_RIGHT_CONTIG; |
| 2120 | 1977 | ||
| 2121 | error = 0; | 1978 | error = 0; |
| 2122 | /* | 1979 | /* |
| 2123 | * Select which case we're in here, and implement it. | 1980 | * Select which case we're in here, and implement it. |
| 2124 | */ | 1981 | */ |
| 2125 | switch (SWITCH_STATE) { | 1982 | switch (state & (BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG)) { |
| 2126 | 1983 | case BMAP_LEFT_CONTIG | BMAP_RIGHT_CONTIG: | |
| 2127 | case MASK2(LEFT_CONTIG, RIGHT_CONTIG): | ||
| 2128 | /* | 1984 | /* |
| 2129 | * New allocation is contiguous with real allocations on the | 1985 | * New allocation is contiguous with real allocations on the |
| 2130 | * left and on the right. | 1986 | * left and on the right. |
| 2131 | * Merge all three into a single extent record. | 1987 | * Merge all three into a single extent record. |
| 2132 | */ | 1988 | */ |
| 2133 | XFS_BMAP_TRACE_PRE_UPDATE("LC|RC", ip, idx - 1, | 1989 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 2134 | whichfork); | ||
| 2135 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 1990 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 2136 | left.br_blockcount + new->br_blockcount + | 1991 | left.br_blockcount + new->br_blockcount + |
| 2137 | right.br_blockcount); | 1992 | right.br_blockcount); |
| 2138 | XFS_BMAP_TRACE_POST_UPDATE("LC|RC", ip, idx - 1, | 1993 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 2139 | whichfork); | 1994 | |
| 2140 | XFS_BMAP_TRACE_DELETE("LC|RC", ip, idx, 1, whichfork); | 1995 | xfs_iext_remove(ip, idx, 1, state); |
| 2141 | xfs_iext_remove(ifp, idx, 1); | ||
| 2142 | ifp->if_lastex = idx - 1; | 1996 | ifp->if_lastex = idx - 1; |
| 2143 | XFS_IFORK_NEXT_SET(ip, whichfork, | 1997 | XFS_IFORK_NEXT_SET(ip, whichfork, |
| 2144 | XFS_IFORK_NEXTENTS(ip, whichfork) - 1); | 1998 | XFS_IFORK_NEXTENTS(ip, whichfork) - 1); |
| @@ -2173,16 +2027,17 @@ xfs_bmap_add_extent_hole_real( | |||
| 2173 | right.br_blockcount; | 2027 | right.br_blockcount; |
| 2174 | break; | 2028 | break; |
| 2175 | 2029 | ||
| 2176 | case MASK(LEFT_CONTIG): | 2030 | case BMAP_LEFT_CONTIG: |
| 2177 | /* | 2031 | /* |
| 2178 | * New allocation is contiguous with a real allocation | 2032 | * New allocation is contiguous with a real allocation |
| 2179 | * on the left. | 2033 | * on the left. |
| 2180 | * Merge the new allocation with the left neighbor. | 2034 | * Merge the new allocation with the left neighbor. |
| 2181 | */ | 2035 | */ |
| 2182 | XFS_BMAP_TRACE_PRE_UPDATE("LC", ip, idx - 1, whichfork); | 2036 | trace_xfs_bmap_pre_update(ip, idx - 1, state, _THIS_IP_); |
| 2183 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), | 2037 | xfs_bmbt_set_blockcount(xfs_iext_get_ext(ifp, idx - 1), |
| 2184 | left.br_blockcount + new->br_blockcount); | 2038 | left.br_blockcount + new->br_blockcount); |
| 2185 | XFS_BMAP_TRACE_POST_UPDATE("LC", ip, idx - 1, whichfork); | 2039 | trace_xfs_bmap_post_update(ip, idx - 1, state, _THIS_IP_); |
| 2040 | |||
| 2186 | ifp->if_lastex = idx - 1; | 2041 | ifp->if_lastex = idx - 1; |
| 2187 | if (cur == NULL) { | 2042 | if (cur == NULL) { |
| 2188 | rval = xfs_ilog_fext(whichfork); | 2043 | rval = xfs_ilog_fext(whichfork); |
| @@ -2207,17 +2062,18 @@ xfs_bmap_add_extent_hole_real( | |||
| 2207 | new->br_blockcount; | 2062 | new->br_blockcount; |
| 2208 | break; | 2063 | break; |
| 2209 | 2064 | ||
| 2210 | case MASK(RIGHT_CONTIG): | 2065 | case BMAP_RIGHT_CONTIG: |
| 2211 | /* | 2066 | /* |
| 2212 | * New allocation is contiguous with a real allocation | 2067 | * New allocation is contiguous with a real allocation |
| 2213 | * on the right. | 2068 | * on the right. |
| 2214 | * Merge the new allocation with the right neighbor. | 2069 | * Merge the new allocation with the right neighbor. |
| 2215 | */ | 2070 | */ |
| 2216 | XFS_BMAP_TRACE_PRE_UPDATE("RC", ip, idx, whichfork); | 2071 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 2217 | xfs_bmbt_set_allf(ep, new->br_startoff, new->br_startblock, | 2072 | xfs_bmbt_set_allf(ep, new->br_startoff, new->br_startblock, |
| 2218 | new->br_blockcount + right.br_blockcount, | 2073 | new->br_blockcount + right.br_blockcount, |
| 2219 | right.br_state); | 2074 | right.br_state); |
| 2220 | XFS_BMAP_TRACE_POST_UPDATE("RC", ip, idx, whichfork); | 2075 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 2076 | |||
| 2221 | ifp->if_lastex = idx; | 2077 | ifp->if_lastex = idx; |
| 2222 | if (cur == NULL) { | 2078 | if (cur == NULL) { |
| 2223 | rval = xfs_ilog_fext(whichfork); | 2079 | rval = xfs_ilog_fext(whichfork); |
| @@ -2248,8 +2104,7 @@ xfs_bmap_add_extent_hole_real( | |||
| 2248 | * real allocation. | 2104 | * real allocation. |
| 2249 | * Insert a new entry. | 2105 | * Insert a new entry. |
| 2250 | */ | 2106 | */ |
| 2251 | XFS_BMAP_TRACE_INSERT("0", ip, idx, 1, new, NULL, whichfork); | 2107 | xfs_iext_insert(ip, idx, 1, new, state); |
| 2252 | xfs_iext_insert(ifp, idx, 1, new); | ||
| 2253 | ifp->if_lastex = idx; | 2108 | ifp->if_lastex = idx; |
| 2254 | XFS_IFORK_NEXT_SET(ip, whichfork, | 2109 | XFS_IFORK_NEXT_SET(ip, whichfork, |
| 2255 | XFS_IFORK_NEXTENTS(ip, whichfork) + 1); | 2110 | XFS_IFORK_NEXTENTS(ip, whichfork) + 1); |
| @@ -2283,12 +2138,6 @@ xfs_bmap_add_extent_hole_real( | |||
| 2283 | done: | 2138 | done: |
| 2284 | *logflagsp = rval; | 2139 | *logflagsp = rval; |
| 2285 | return error; | 2140 | return error; |
| 2286 | #undef MASK | ||
| 2287 | #undef MASK2 | ||
| 2288 | #undef STATE_SET | ||
| 2289 | #undef STATE_TEST | ||
| 2290 | #undef STATE_SET_TEST | ||
| 2291 | #undef SWITCH_STATE | ||
| 2292 | } | 2141 | } |
| 2293 | 2142 | ||
| 2294 | /* | 2143 | /* |
| @@ -3115,8 +2964,13 @@ xfs_bmap_del_extent( | |||
| 3115 | uint qfield; /* quota field to update */ | 2964 | uint qfield; /* quota field to update */ |
| 3116 | xfs_filblks_t temp; /* for indirect length calculations */ | 2965 | xfs_filblks_t temp; /* for indirect length calculations */ |
| 3117 | xfs_filblks_t temp2; /* for indirect length calculations */ | 2966 | xfs_filblks_t temp2; /* for indirect length calculations */ |
| 2967 | int state = 0; | ||
| 3118 | 2968 | ||
| 3119 | XFS_STATS_INC(xs_del_exlist); | 2969 | XFS_STATS_INC(xs_del_exlist); |
| 2970 | |||
| 2971 | if (whichfork == XFS_ATTR_FORK) | ||
| 2972 | state |= BMAP_ATTRFORK; | ||
| 2973 | |||
| 3120 | mp = ip->i_mount; | 2974 | mp = ip->i_mount; |
| 3121 | ifp = XFS_IFORK_PTR(ip, whichfork); | 2975 | ifp = XFS_IFORK_PTR(ip, whichfork); |
| 3122 | ASSERT((idx >= 0) && (idx < ifp->if_bytes / | 2976 | ASSERT((idx >= 0) && (idx < ifp->if_bytes / |
| @@ -3196,8 +3050,8 @@ xfs_bmap_del_extent( | |||
| 3196 | /* | 3050 | /* |
| 3197 | * Matches the whole extent. Delete the entry. | 3051 | * Matches the whole extent. Delete the entry. |
| 3198 | */ | 3052 | */ |
| 3199 | XFS_BMAP_TRACE_DELETE("3", ip, idx, 1, whichfork); | 3053 | xfs_iext_remove(ip, idx, 1, |
| 3200 | xfs_iext_remove(ifp, idx, 1); | 3054 | whichfork == XFS_ATTR_FORK ? BMAP_ATTRFORK : 0); |
| 3201 | ifp->if_lastex = idx; | 3055 | ifp->if_lastex = idx; |
| 3202 | if (delay) | 3056 | if (delay) |
| 3203 | break; | 3057 | break; |
| @@ -3217,7 +3071,7 @@ xfs_bmap_del_extent( | |||
| 3217 | /* | 3071 | /* |
| 3218 | * Deleting the first part of the extent. | 3072 | * Deleting the first part of the extent. |
| 3219 | */ | 3073 | */ |
| 3220 | XFS_BMAP_TRACE_PRE_UPDATE("2", ip, idx, whichfork); | 3074 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 3221 | xfs_bmbt_set_startoff(ep, del_endoff); | 3075 | xfs_bmbt_set_startoff(ep, del_endoff); |
| 3222 | temp = got.br_blockcount - del->br_blockcount; | 3076 | temp = got.br_blockcount - del->br_blockcount; |
| 3223 | xfs_bmbt_set_blockcount(ep, temp); | 3077 | xfs_bmbt_set_blockcount(ep, temp); |
| @@ -3226,13 +3080,12 @@ xfs_bmap_del_extent( | |||
| 3226 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), | 3080 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), |
| 3227 | da_old); | 3081 | da_old); |
| 3228 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 3082 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 3229 | XFS_BMAP_TRACE_POST_UPDATE("2", ip, idx, | 3083 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 3230 | whichfork); | ||
| 3231 | da_new = temp; | 3084 | da_new = temp; |
| 3232 | break; | 3085 | break; |
| 3233 | } | 3086 | } |
| 3234 | xfs_bmbt_set_startblock(ep, del_endblock); | 3087 | xfs_bmbt_set_startblock(ep, del_endblock); |
| 3235 | XFS_BMAP_TRACE_POST_UPDATE("2", ip, idx, whichfork); | 3088 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 3236 | if (!cur) { | 3089 | if (!cur) { |
| 3237 | flags |= xfs_ilog_fext(whichfork); | 3090 | flags |= xfs_ilog_fext(whichfork); |
| 3238 | break; | 3091 | break; |
| @@ -3248,19 +3101,18 @@ xfs_bmap_del_extent( | |||
| 3248 | * Deleting the last part of the extent. | 3101 | * Deleting the last part of the extent. |
| 3249 | */ | 3102 | */ |
| 3250 | temp = got.br_blockcount - del->br_blockcount; | 3103 | temp = got.br_blockcount - del->br_blockcount; |
| 3251 | XFS_BMAP_TRACE_PRE_UPDATE("1", ip, idx, whichfork); | 3104 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 3252 | xfs_bmbt_set_blockcount(ep, temp); | 3105 | xfs_bmbt_set_blockcount(ep, temp); |
| 3253 | ifp->if_lastex = idx; | 3106 | ifp->if_lastex = idx; |
| 3254 | if (delay) { | 3107 | if (delay) { |
| 3255 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), | 3108 | temp = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(ip, temp), |
| 3256 | da_old); | 3109 | da_old); |
| 3257 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); | 3110 | xfs_bmbt_set_startblock(ep, nullstartblock((int)temp)); |
| 3258 | XFS_BMAP_TRACE_POST_UPDATE("1", ip, idx, | 3111 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 3259 | whichfork); | ||
| 3260 | da_new = temp; | 3112 | da_new = temp; |
| 3261 | break; | 3113 | break; |
| 3262 | } | 3114 | } |
| 3263 | XFS_BMAP_TRACE_POST_UPDATE("1", ip, idx, whichfork); | 3115 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 3264 | if (!cur) { | 3116 | if (!cur) { |
| 3265 | flags |= xfs_ilog_fext(whichfork); | 3117 | flags |= xfs_ilog_fext(whichfork); |
| 3266 | break; | 3118 | break; |
| @@ -3277,7 +3129,7 @@ xfs_bmap_del_extent( | |||
| 3277 | * Deleting the middle of the extent. | 3129 | * Deleting the middle of the extent. |
| 3278 | */ | 3130 | */ |
| 3279 | temp = del->br_startoff - got.br_startoff; | 3131 | temp = del->br_startoff - got.br_startoff; |
| 3280 | XFS_BMAP_TRACE_PRE_UPDATE("0", ip, idx, whichfork); | 3132 | trace_xfs_bmap_pre_update(ip, idx, state, _THIS_IP_); |
| 3281 | xfs_bmbt_set_blockcount(ep, temp); | 3133 | xfs_bmbt_set_blockcount(ep, temp); |
| 3282 | new.br_startoff = del_endoff; | 3134 | new.br_startoff = del_endoff; |
| 3283 | temp2 = got_endoff - del_endoff; | 3135 | temp2 = got_endoff - del_endoff; |
| @@ -3364,10 +3216,8 @@ xfs_bmap_del_extent( | |||
| 3364 | } | 3216 | } |
| 3365 | } | 3217 | } |
| 3366 | } | 3218 | } |
| 3367 | XFS_BMAP_TRACE_POST_UPDATE("0", ip, idx, whichfork); | 3219 | trace_xfs_bmap_post_update(ip, idx, state, _THIS_IP_); |
| 3368 | XFS_BMAP_TRACE_INSERT("0", ip, idx + 1, 1, &new, NULL, | 3220 | xfs_iext_insert(ip, idx + 1, 1, &new, state); |
| 3369 | whichfork); | ||
| 3370 | xfs_iext_insert(ifp, idx + 1, 1, &new); | ||
| 3371 | ifp->if_lastex = idx + 1; | 3221 | ifp->if_lastex = idx + 1; |
| 3372 | break; | 3222 | break; |
| 3373 | } | 3223 | } |
| @@ -3687,7 +3537,9 @@ xfs_bmap_local_to_extents( | |||
| 3687 | xfs_iext_add(ifp, 0, 1); | 3537 | xfs_iext_add(ifp, 0, 1); |
| 3688 | ep = xfs_iext_get_ext(ifp, 0); | 3538 | ep = xfs_iext_get_ext(ifp, 0); |
| 3689 | xfs_bmbt_set_allf(ep, 0, args.fsbno, 1, XFS_EXT_NORM); | 3539 | xfs_bmbt_set_allf(ep, 0, args.fsbno, 1, XFS_EXT_NORM); |
| 3690 | XFS_BMAP_TRACE_POST_UPDATE("new", ip, 0, whichfork); | 3540 | trace_xfs_bmap_post_update(ip, 0, |
| 3541 | whichfork == XFS_ATTR_FORK ? BMAP_ATTRFORK : 0, | ||
| 3542 | _THIS_IP_); | ||
| 3691 | XFS_IFORK_NEXT_SET(ip, whichfork, 1); | 3543 | XFS_IFORK_NEXT_SET(ip, whichfork, 1); |
| 3692 | ip->i_d.di_nblocks = 1; | 3544 | ip->i_d.di_nblocks = 1; |
| 3693 | xfs_trans_mod_dquot_byino(tp, ip, | 3545 | xfs_trans_mod_dquot_byino(tp, ip, |
| @@ -3800,158 +3652,6 @@ xfs_bmap_search_extents( | |||
| 3800 | return ep; | 3652 | return ep; |
| 3801 | } | 3653 | } |
| 3802 | 3654 | ||
| 3803 | |||
| 3804 | #ifdef XFS_BMAP_TRACE | ||
| 3805 | ktrace_t *xfs_bmap_trace_buf; | ||
| 3806 | |||
| 3807 | /* | ||
| 3808 | * Add a bmap trace buffer entry. Base routine for the others. | ||
| 3809 | */ | ||
| 3810 | STATIC void | ||
| 3811 | xfs_bmap_trace_addentry( | ||
| 3812 | int opcode, /* operation */ | ||
| 3813 | const char *fname, /* function name */ | ||
| 3814 | char *desc, /* operation description */ | ||
| 3815 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 3816 | xfs_extnum_t idx, /* index of entry(ies) */ | ||
| 3817 | xfs_extnum_t cnt, /* count of entries, 1 or 2 */ | ||
| 3818 | xfs_bmbt_rec_host_t *r1, /* first record */ | ||
| 3819 | xfs_bmbt_rec_host_t *r2, /* second record or null */ | ||
| 3820 | int whichfork) /* data or attr fork */ | ||
| 3821 | { | ||
| 3822 | xfs_bmbt_rec_host_t tr2; | ||
| 3823 | |||
| 3824 | ASSERT(cnt == 1 || cnt == 2); | ||
| 3825 | ASSERT(r1 != NULL); | ||
| 3826 | if (cnt == 1) { | ||
| 3827 | ASSERT(r2 == NULL); | ||
| 3828 | r2 = &tr2; | ||
| 3829 | memset(&tr2, 0, sizeof(tr2)); | ||
| 3830 | } else | ||
| 3831 | ASSERT(r2 != NULL); | ||
| 3832 | ktrace_enter(xfs_bmap_trace_buf, | ||
| 3833 | (void *)(__psint_t)(opcode | (whichfork << 16)), | ||
| 3834 | (void *)fname, (void *)desc, (void *)ip, | ||
| 3835 | (void *)(__psint_t)idx, | ||
| 3836 | (void *)(__psint_t)cnt, | ||
| 3837 | (void *)(__psunsigned_t)(ip->i_ino >> 32), | ||
| 3838 | (void *)(__psunsigned_t)(unsigned)ip->i_ino, | ||
| 3839 | (void *)(__psunsigned_t)(r1->l0 >> 32), | ||
| 3840 | (void *)(__psunsigned_t)(unsigned)(r1->l0), | ||
| 3841 | (void *)(__psunsigned_t)(r1->l1 >> 32), | ||
| 3842 | (void *)(__psunsigned_t)(unsigned)(r1->l1), | ||
| 3843 | (void *)(__psunsigned_t)(r2->l0 >> 32), | ||
| 3844 | (void *)(__psunsigned_t)(unsigned)(r2->l0), | ||
| 3845 | (void *)(__psunsigned_t)(r2->l1 >> 32), | ||
| 3846 | (void *)(__psunsigned_t)(unsigned)(r2->l1) | ||
| 3847 | ); | ||
| 3848 | ASSERT(ip->i_xtrace); | ||
| 3849 | ktrace_enter(ip->i_xtrace, | ||
| 3850 | (void *)(__psint_t)(opcode | (whichfork << 16)), | ||
| 3851 | (void *)fname, (void *)desc, (void *)ip, | ||
| 3852 | (void *)(__psint_t)idx, | ||
| 3853 | (void *)(__psint_t)cnt, | ||
| 3854 | (void *)(__psunsigned_t)(ip->i_ino >> 32), | ||
| 3855 | (void *)(__psunsigned_t)(unsigned)ip->i_ino, | ||
| 3856 | (void *)(__psunsigned_t)(r1->l0 >> 32), | ||
| 3857 | (void *)(__psunsigned_t)(unsigned)(r1->l0), | ||
| 3858 | (void *)(__psunsigned_t)(r1->l1 >> 32), | ||
| 3859 | (void *)(__psunsigned_t)(unsigned)(r1->l1), | ||
| 3860 | (void *)(__psunsigned_t)(r2->l0 >> 32), | ||
| 3861 | (void *)(__psunsigned_t)(unsigned)(r2->l0), | ||
| 3862 | (void *)(__psunsigned_t)(r2->l1 >> 32), | ||
| 3863 | (void *)(__psunsigned_t)(unsigned)(r2->l1) | ||
| 3864 | ); | ||
| 3865 | } | ||
| 3866 | |||
| 3867 | /* | ||
| 3868 | * Add bmap trace entry prior to a call to xfs_iext_remove. | ||
| 3869 | */ | ||
| 3870 | STATIC void | ||
| 3871 | xfs_bmap_trace_delete( | ||
| 3872 | const char *fname, /* function name */ | ||
| 3873 | char *desc, /* operation description */ | ||
| 3874 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 3875 | xfs_extnum_t idx, /* index of entry(entries) deleted */ | ||
| 3876 | xfs_extnum_t cnt, /* count of entries deleted, 1 or 2 */ | ||
| 3877 | int whichfork) /* data or attr fork */ | ||
| 3878 | { | ||
| 3879 | xfs_ifork_t *ifp; /* inode fork pointer */ | ||
| 3880 | |||
| 3881 | ifp = XFS_IFORK_PTR(ip, whichfork); | ||
| 3882 | xfs_bmap_trace_addentry(XFS_BMAP_KTRACE_DELETE, fname, desc, ip, idx, | ||
| 3883 | cnt, xfs_iext_get_ext(ifp, idx), | ||
| 3884 | cnt == 2 ? xfs_iext_get_ext(ifp, idx + 1) : NULL, | ||
| 3885 | whichfork); | ||
| 3886 | } | ||
| 3887 | |||
| 3888 | /* | ||
| 3889 | * Add bmap trace entry prior to a call to xfs_iext_insert, or | ||
| 3890 | * reading in the extents list from the disk (in the btree). | ||
| 3891 | */ | ||
| 3892 | STATIC void | ||
| 3893 | xfs_bmap_trace_insert( | ||
| 3894 | const char *fname, /* function name */ | ||
| 3895 | char *desc, /* operation description */ | ||
| 3896 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 3897 | xfs_extnum_t idx, /* index of entry(entries) inserted */ | ||
| 3898 | xfs_extnum_t cnt, /* count of entries inserted, 1 or 2 */ | ||
| 3899 | xfs_bmbt_irec_t *r1, /* inserted record 1 */ | ||
| 3900 | xfs_bmbt_irec_t *r2, /* inserted record 2 or null */ | ||
| 3901 | int whichfork) /* data or attr fork */ | ||
| 3902 | { | ||
| 3903 | xfs_bmbt_rec_host_t tr1; /* compressed record 1 */ | ||
| 3904 | xfs_bmbt_rec_host_t tr2; /* compressed record 2 if needed */ | ||
| 3905 | |||
| 3906 | xfs_bmbt_set_all(&tr1, r1); | ||
| 3907 | if (cnt == 2) { | ||
| 3908 | ASSERT(r2 != NULL); | ||
| 3909 | xfs_bmbt_set_all(&tr2, r2); | ||
| 3910 | } else { | ||
| 3911 | ASSERT(cnt == 1); | ||
| 3912 | ASSERT(r2 == NULL); | ||
| 3913 | } | ||
| 3914 | xfs_bmap_trace_addentry(XFS_BMAP_KTRACE_INSERT, fname, desc, ip, idx, | ||
| 3915 | cnt, &tr1, cnt == 2 ? &tr2 : NULL, whichfork); | ||
| 3916 | } | ||
| 3917 | |||
| 3918 | /* | ||
| 3919 | * Add bmap trace entry after updating an extent record in place. | ||
| 3920 | */ | ||
| 3921 | STATIC void | ||
| 3922 | xfs_bmap_trace_post_update( | ||
| 3923 | const char *fname, /* function name */ | ||
| 3924 | char *desc, /* operation description */ | ||
| 3925 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 3926 | xfs_extnum_t idx, /* index of entry updated */ | ||
| 3927 | int whichfork) /* data or attr fork */ | ||
| 3928 | { | ||
| 3929 | xfs_ifork_t *ifp; /* inode fork pointer */ | ||
| 3930 | |||
| 3931 | ifp = XFS_IFORK_PTR(ip, whichfork); | ||
| 3932 | xfs_bmap_trace_addentry(XFS_BMAP_KTRACE_POST_UP, fname, desc, ip, idx, | ||
| 3933 | 1, xfs_iext_get_ext(ifp, idx), NULL, whichfork); | ||
| 3934 | } | ||
| 3935 | |||
| 3936 | /* | ||
| 3937 | * Add bmap trace entry prior to updating an extent record in place. | ||
| 3938 | */ | ||
| 3939 | STATIC void | ||
| 3940 | xfs_bmap_trace_pre_update( | ||
| 3941 | const char *fname, /* function name */ | ||
| 3942 | char *desc, /* operation description */ | ||
| 3943 | xfs_inode_t *ip, /* incore inode pointer */ | ||
| 3944 | xfs_extnum_t idx, /* index of entry to be updated */ | ||
| 3945 | int whichfork) /* data or attr fork */ | ||
| 3946 | { | ||
| 3947 | xfs_ifork_t *ifp; /* inode fork pointer */ | ||
| 3948 | |||
| 3949 | ifp = XFS_IFORK_PTR(ip, whichfork); | ||
| 3950 | xfs_bmap_trace_addentry(XFS_BMAP_KTRACE_PRE_UP, fname, desc, ip, idx, 1, | ||
| 3951 | xfs_iext_get_ext(ifp, idx), NULL, whichfork); | ||
| 3952 | } | ||
| 3953 | #endif /* XFS_BMAP_TRACE */ | ||
| 3954 | |||
| 3955 | /* | 3655 | /* |
| 3956 | * Compute the worst-case number of indirect blocks that will be used | 3656 | * Compute the worst-case number of indirect blocks that will be used |
| 3957 | * for ip's delayed extent of length "len". | 3657 | * for ip's delayed extent of length "len". |
| @@ -3983,37 +3683,6 @@ xfs_bmap_worst_indlen( | |||
| 3983 | return rval; | 3683 | return rval; |
| 3984 | } | 3684 | } |
| 3985 | 3685 | ||
| 3986 | #if defined(XFS_RW_TRACE) | ||
| 3987 | STATIC void | ||
| 3988 | xfs_bunmap_trace( | ||
| 3989 | xfs_inode_t *ip, | ||
| 3990 | xfs_fileoff_t bno, | ||
| 3991 | xfs_filblks_t len, | ||
| 3992 | int flags, | ||
| 3993 | inst_t *ra) | ||
| 3994 | { | ||
| 3995 | if (ip->i_rwtrace == NULL) | ||
| 3996 | return; | ||
| 3997 | ktrace_enter(ip->i_rwtrace, | ||
| 3998 | (void *)(__psint_t)XFS_BUNMAP, | ||
| 3999 | (void *)ip, | ||
| 4000 | (void *)(__psint_t)((ip->i_d.di_size >> 32) & 0xffffffff), | ||
| 4001 | (void *)(__psint_t)(ip->i_d.di_size & 0xffffffff), | ||
| 4002 | (void *)(__psint_t)(((xfs_dfiloff_t)bno >> 32) & 0xffffffff), | ||
| 4003 | (void *)(__psint_t)((xfs_dfiloff_t)bno & 0xffffffff), | ||
| 4004 | (void *)(__psint_t)len, | ||
| 4005 | (void *)(__psint_t)flags, | ||
| 4006 | (void *)(unsigned long)current_cpu(), | ||
| 4007 | (void *)ra, | ||
| 4008 | (void *)0, | ||
| 4009 | (void *)0, | ||
| 4010 | (void *)0, | ||
| 4011 | (void *)0, | ||
| 4012 | (void *)0, | ||
| 4013 | (void *)0); | ||
| 4014 | } | ||
| 4015 | #endif | ||
| 4016 | |||
| 4017 | /* | 3686 | /* |
| 4018 | * Convert inode from non-attributed to attributed. | 3687 | * Convert inode from non-attributed to attributed. |
| 4019 | * Must not be in a transaction, ip must not be locked. | 3688 | * Must not be in a transaction, ip must not be locked. |
| @@ -4702,34 +4371,30 @@ error0: | |||
| 4702 | return XFS_ERROR(EFSCORRUPTED); | 4371 | return XFS_ERROR(EFSCORRUPTED); |
| 4703 | } | 4372 | } |
| 4704 | 4373 | ||
| 4705 | #ifdef XFS_BMAP_TRACE | 4374 | #ifdef DEBUG |
| 4706 | /* | 4375 | /* |
| 4707 | * Add bmap trace insert entries for all the contents of the extent records. | 4376 | * Add bmap trace insert entries for all the contents of the extent records. |
| 4708 | */ | 4377 | */ |
| 4709 | void | 4378 | void |
| 4710 | xfs_bmap_trace_exlist( | 4379 | xfs_bmap_trace_exlist( |
| 4711 | const char *fname, /* function name */ | ||
| 4712 | xfs_inode_t *ip, /* incore inode pointer */ | 4380 | xfs_inode_t *ip, /* incore inode pointer */ |
| 4713 | xfs_extnum_t cnt, /* count of entries in the list */ | 4381 | xfs_extnum_t cnt, /* count of entries in the list */ |
| 4714 | int whichfork) /* data or attr fork */ | 4382 | int whichfork, /* data or attr fork */ |
| 4383 | unsigned long caller_ip) | ||
| 4715 | { | 4384 | { |
| 4716 | xfs_bmbt_rec_host_t *ep; /* current extent record */ | ||
| 4717 | xfs_extnum_t idx; /* extent record index */ | 4385 | xfs_extnum_t idx; /* extent record index */ |
| 4718 | xfs_ifork_t *ifp; /* inode fork pointer */ | 4386 | xfs_ifork_t *ifp; /* inode fork pointer */ |
| 4719 | xfs_bmbt_irec_t s; /* file extent record */ | 4387 | int state = 0; |
| 4388 | |||
| 4389 | if (whichfork == XFS_ATTR_FORK) | ||
| 4390 | state |= BMAP_ATTRFORK; | ||
| 4720 | 4391 | ||
| 4721 | ifp = XFS_IFORK_PTR(ip, whichfork); | 4392 | ifp = XFS_IFORK_PTR(ip, whichfork); |
| 4722 | ASSERT(cnt == (ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t))); | 4393 | ASSERT(cnt == (ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t))); |
| 4723 | for (idx = 0; idx < cnt; idx++) { | 4394 | for (idx = 0; idx < cnt; idx++) |
| 4724 | ep = xfs_iext_get_ext(ifp, idx); | 4395 | trace_xfs_extlist(ip, idx, whichfork, caller_ip); |
| 4725 | xfs_bmbt_get_all(ep, &s); | ||
| 4726 | XFS_BMAP_TRACE_INSERT("exlist", ip, idx, 1, &s, NULL, | ||
| 4727 | whichfork); | ||
| 4728 | } | ||
| 4729 | } | 4396 | } |
| 4730 | #endif | ||
| 4731 | 4397 | ||
| 4732 | #ifdef DEBUG | ||
| 4733 | /* | 4398 | /* |
| 4734 | * Validate that the bmbt_irecs being returned from bmapi are valid | 4399 | * Validate that the bmbt_irecs being returned from bmapi are valid |
| 4735 | * given the callers original parameters. Specifically check the | 4400 | * given the callers original parameters. Specifically check the |
| @@ -5478,7 +5143,8 @@ xfs_bunmapi( | |||
| 5478 | int rsvd; /* OK to allocate reserved blocks */ | 5143 | int rsvd; /* OK to allocate reserved blocks */ |
| 5479 | xfs_fsblock_t sum; | 5144 | xfs_fsblock_t sum; |
| 5480 | 5145 | ||
| 5481 | xfs_bunmap_trace(ip, bno, len, flags, (inst_t *)__return_address); | 5146 | trace_xfs_bunmap(ip, bno, len, flags, _RET_IP_); |
| 5147 | |||
| 5482 | whichfork = (flags & XFS_BMAPI_ATTRFORK) ? | 5148 | whichfork = (flags & XFS_BMAPI_ATTRFORK) ? |
| 5483 | XFS_ATTR_FORK : XFS_DATA_FORK; | 5149 | XFS_ATTR_FORK : XFS_DATA_FORK; |
| 5484 | ifp = XFS_IFORK_PTR(ip, whichfork); | 5150 | ifp = XFS_IFORK_PTR(ip, whichfork); |
diff --git a/fs/xfs/xfs_bmap.h b/fs/xfs/xfs_bmap.h index 56f62d2edc35..419dafb9d87d 100644 --- a/fs/xfs/xfs_bmap.h +++ b/fs/xfs/xfs_bmap.h | |||
| @@ -95,6 +95,21 @@ typedef struct xfs_bmap_free | |||
| 95 | /* need write cache flushing and no */ | 95 | /* need write cache flushing and no */ |
| 96 | /* additional allocation alignments */ | 96 | /* additional allocation alignments */ |
| 97 | 97 | ||
| 98 | #define XFS_BMAPI_FLAGS \ | ||
| 99 | { XFS_BMAPI_WRITE, "WRITE" }, \ | ||
| 100 | { XFS_BMAPI_DELAY, "DELAY" }, \ | ||
| 101 | { XFS_BMAPI_ENTIRE, "ENTIRE" }, \ | ||
| 102 | { XFS_BMAPI_METADATA, "METADATA" }, \ | ||
| 103 | { XFS_BMAPI_EXACT, "EXACT" }, \ | ||
| 104 | { XFS_BMAPI_ATTRFORK, "ATTRFORK" }, \ | ||
| 105 | { XFS_BMAPI_ASYNC, "ASYNC" }, \ | ||
| 106 | { XFS_BMAPI_RSVBLOCKS, "RSVBLOCKS" }, \ | ||
| 107 | { XFS_BMAPI_PREALLOC, "PREALLOC" }, \ | ||
| 108 | { XFS_BMAPI_IGSTATE, "IGSTATE" }, \ | ||
| 109 | { XFS_BMAPI_CONTIG, "CONTIG" }, \ | ||
| 110 | { XFS_BMAPI_CONVERT, "CONVERT" } | ||
| 111 | |||
| 112 | |||
| 98 | static inline int xfs_bmapi_aflag(int w) | 113 | static inline int xfs_bmapi_aflag(int w) |
| 99 | { | 114 | { |
| 100 | return (w == XFS_ATTR_FORK ? XFS_BMAPI_ATTRFORK : 0); | 115 | return (w == XFS_ATTR_FORK ? XFS_BMAPI_ATTRFORK : 0); |
| @@ -135,36 +150,43 @@ typedef struct xfs_bmalloca { | |||
| 135 | char conv; /* overwriting unwritten extents */ | 150 | char conv; /* overwriting unwritten extents */ |
| 136 | } xfs_bmalloca_t; | 151 | } xfs_bmalloca_t; |
| 137 | 152 | ||
| 138 | #if defined(__KERNEL__) && defined(XFS_BMAP_TRACE) | ||
| 139 | /* | 153 | /* |
| 140 | * Trace operations for bmap extent tracing | 154 | * Flags for xfs_bmap_add_extent*. |
| 141 | */ | 155 | */ |
| 142 | #define XFS_BMAP_KTRACE_DELETE 1 | 156 | #define BMAP_LEFT_CONTIG (1 << 0) |
| 143 | #define XFS_BMAP_KTRACE_INSERT 2 | 157 | #define BMAP_RIGHT_CONTIG (1 << 1) |
| 144 | #define XFS_BMAP_KTRACE_PRE_UP 3 | 158 | #define BMAP_LEFT_FILLING (1 << 2) |
| 145 | #define XFS_BMAP_KTRACE_POST_UP 4 | 159 | #define BMAP_RIGHT_FILLING (1 << 3) |
| 146 | 160 | #define BMAP_LEFT_DELAY (1 << 4) | |
| 147 | #define XFS_BMAP_TRACE_SIZE 4096 /* size of global trace buffer */ | 161 | #define BMAP_RIGHT_DELAY (1 << 5) |
| 148 | #define XFS_BMAP_KTRACE_SIZE 32 /* size of per-inode trace buffer */ | 162 | #define BMAP_LEFT_VALID (1 << 6) |
| 149 | extern ktrace_t *xfs_bmap_trace_buf; | 163 | #define BMAP_RIGHT_VALID (1 << 7) |
| 164 | #define BMAP_ATTRFORK (1 << 8) | ||
| 165 | |||
| 166 | #define XFS_BMAP_EXT_FLAGS \ | ||
| 167 | { BMAP_LEFT_CONTIG, "LC" }, \ | ||
| 168 | { BMAP_RIGHT_CONTIG, "RC" }, \ | ||
| 169 | { BMAP_LEFT_FILLING, "LF" }, \ | ||
| 170 | { BMAP_RIGHT_FILLING, "RF" }, \ | ||
| 171 | { BMAP_ATTRFORK, "ATTR" } | ||
| 150 | 172 | ||
| 151 | /* | 173 | /* |
| 152 | * Add bmap trace insert entries for all the contents of the extent list. | 174 | * Add bmap trace insert entries for all the contents of the extent list. |
| 175 | * | ||
| 176 | * Quite excessive tracing. Only do this for debug builds. | ||
| 153 | */ | 177 | */ |
| 178 | #if defined(__KERNEL) && defined(DEBUG) | ||
| 154 | void | 179 | void |
| 155 | xfs_bmap_trace_exlist( | 180 | xfs_bmap_trace_exlist( |
| 156 | const char *fname, /* function name */ | ||
| 157 | struct xfs_inode *ip, /* incore inode pointer */ | 181 | struct xfs_inode *ip, /* incore inode pointer */ |
| 158 | xfs_extnum_t cnt, /* count of entries in list */ | 182 | xfs_extnum_t cnt, /* count of entries in list */ |
| 159 | int whichfork); /* data or attr fork */ | 183 | int whichfork, |
| 184 | unsigned long caller_ip); /* data or attr fork */ | ||
| 160 | #define XFS_BMAP_TRACE_EXLIST(ip,c,w) \ | 185 | #define XFS_BMAP_TRACE_EXLIST(ip,c,w) \ |
| 161 | xfs_bmap_trace_exlist(__func__,ip,c,w) | 186 | xfs_bmap_trace_exlist(ip,c,w, _THIS_IP_) |
| 162 | 187 | #else | |
| 163 | #else /* __KERNEL__ && XFS_BMAP_TRACE */ | ||
| 164 | |||
| 165 | #define XFS_BMAP_TRACE_EXLIST(ip,c,w) | 188 | #define XFS_BMAP_TRACE_EXLIST(ip,c,w) |
| 166 | 189 | #endif | |
| 167 | #endif /* __KERNEL__ && XFS_BMAP_TRACE */ | ||
| 168 | 190 | ||
| 169 | /* | 191 | /* |
| 170 | * Convert inode from non-attributed to attributed. | 192 | * Convert inode from non-attributed to attributed. |
diff --git a/fs/xfs/xfs_bmap_btree.c b/fs/xfs/xfs_bmap_btree.c index eb7b702d0690..38751d5fac6f 100644 --- a/fs/xfs/xfs_bmap_btree.c +++ b/fs/xfs/xfs_bmap_btree.c | |||
| @@ -98,8 +98,7 @@ xfs_bmdr_to_bmbt( | |||
| 98 | * This code must be in sync with the routines xfs_bmbt_get_startoff, | 98 | * This code must be in sync with the routines xfs_bmbt_get_startoff, |
| 99 | * xfs_bmbt_get_startblock, xfs_bmbt_get_blockcount and xfs_bmbt_get_state. | 99 | * xfs_bmbt_get_startblock, xfs_bmbt_get_blockcount and xfs_bmbt_get_state. |
| 100 | */ | 100 | */ |
| 101 | 101 | STATIC void | |
| 102 | STATIC_INLINE void | ||
| 103 | __xfs_bmbt_get_all( | 102 | __xfs_bmbt_get_all( |
| 104 | __uint64_t l0, | 103 | __uint64_t l0, |
| 105 | __uint64_t l1, | 104 | __uint64_t l1, |
| @@ -769,12 +768,6 @@ xfs_bmbt_trace_enter( | |||
| 769 | (void *)a0, (void *)a1, (void *)a2, (void *)a3, | 768 | (void *)a0, (void *)a1, (void *)a2, (void *)a3, |
| 770 | (void *)a4, (void *)a5, (void *)a6, (void *)a7, | 769 | (void *)a4, (void *)a5, (void *)a6, (void *)a7, |
| 771 | (void *)a8, (void *)a9, (void *)a10); | 770 | (void *)a8, (void *)a9, (void *)a10); |
| 772 | ktrace_enter(ip->i_btrace, | ||
| 773 | (void *)((__psint_t)type | (whichfork << 8) | (line << 16)), | ||
| 774 | (void *)func, (void *)s, (void *)ip, (void *)cur, | ||
| 775 | (void *)a0, (void *)a1, (void *)a2, (void *)a3, | ||
| 776 | (void *)a4, (void *)a5, (void *)a6, (void *)a7, | ||
| 777 | (void *)a8, (void *)a9, (void *)a10); | ||
| 778 | } | 771 | } |
| 779 | 772 | ||
| 780 | STATIC void | 773 | STATIC void |
diff --git a/fs/xfs/xfs_btree.c b/fs/xfs/xfs_btree.c index 52b5f14d0c32..36a0992dd669 100644 --- a/fs/xfs/xfs_btree.c +++ b/fs/xfs/xfs_btree.c | |||
| @@ -39,6 +39,7 @@ | |||
| 39 | #include "xfs_btree_trace.h" | 39 | #include "xfs_btree_trace.h" |
| 40 | #include "xfs_ialloc.h" | 40 | #include "xfs_ialloc.h" |
| 41 | #include "xfs_error.h" | 41 | #include "xfs_error.h" |
| 42 | #include "xfs_trace.h" | ||
| 42 | 43 | ||
| 43 | /* | 44 | /* |
| 44 | * Cursor allocation zone. | 45 | * Cursor allocation zone. |
| @@ -81,7 +82,7 @@ xfs_btree_check_lblock( | |||
| 81 | XFS_ERRTAG_BTREE_CHECK_LBLOCK, | 82 | XFS_ERRTAG_BTREE_CHECK_LBLOCK, |
| 82 | XFS_RANDOM_BTREE_CHECK_LBLOCK))) { | 83 | XFS_RANDOM_BTREE_CHECK_LBLOCK))) { |
| 83 | if (bp) | 84 | if (bp) |
| 84 | xfs_buftrace("LBTREE ERROR", bp); | 85 | trace_xfs_btree_corrupt(bp, _RET_IP_); |
| 85 | XFS_ERROR_REPORT("xfs_btree_check_lblock", XFS_ERRLEVEL_LOW, | 86 | XFS_ERROR_REPORT("xfs_btree_check_lblock", XFS_ERRLEVEL_LOW, |
| 86 | mp); | 87 | mp); |
| 87 | return XFS_ERROR(EFSCORRUPTED); | 88 | return XFS_ERROR(EFSCORRUPTED); |
| @@ -119,7 +120,7 @@ xfs_btree_check_sblock( | |||
| 119 | XFS_ERRTAG_BTREE_CHECK_SBLOCK, | 120 | XFS_ERRTAG_BTREE_CHECK_SBLOCK, |
| 120 | XFS_RANDOM_BTREE_CHECK_SBLOCK))) { | 121 | XFS_RANDOM_BTREE_CHECK_SBLOCK))) { |
| 121 | if (bp) | 122 | if (bp) |
| 122 | xfs_buftrace("SBTREE ERROR", bp); | 123 | trace_xfs_btree_corrupt(bp, _RET_IP_); |
| 123 | XFS_CORRUPTION_ERROR("xfs_btree_check_sblock", | 124 | XFS_CORRUPTION_ERROR("xfs_btree_check_sblock", |
| 124 | XFS_ERRLEVEL_LOW, cur->bc_mp, block); | 125 | XFS_ERRLEVEL_LOW, cur->bc_mp, block); |
| 125 | return XFS_ERROR(EFSCORRUPTED); | 126 | return XFS_ERROR(EFSCORRUPTED); |
diff --git a/fs/xfs/xfs_btree_trace.h b/fs/xfs/xfs_btree_trace.h index b3f5eb3c3c6c..2d8a309873ea 100644 --- a/fs/xfs/xfs_btree_trace.h +++ b/fs/xfs/xfs_btree_trace.h | |||
| @@ -58,8 +58,6 @@ void xfs_btree_trace_argbi(const char *, struct xfs_btree_cur *, | |||
| 58 | struct xfs_buf *, int, int); | 58 | struct xfs_buf *, int, int); |
| 59 | void xfs_btree_trace_argbii(const char *, struct xfs_btree_cur *, | 59 | void xfs_btree_trace_argbii(const char *, struct xfs_btree_cur *, |
| 60 | struct xfs_buf *, int, int, int); | 60 | struct xfs_buf *, int, int, int); |
| 61 | void xfs_btree_trace_argfffi(const char *, struct xfs_btree_cur *, | ||
| 62 | xfs_dfiloff_t, xfs_dfsbno_t, xfs_dfilblks_t, int, int); | ||
| 63 | void xfs_btree_trace_argi(const char *, struct xfs_btree_cur *, int, int); | 61 | void xfs_btree_trace_argi(const char *, struct xfs_btree_cur *, int, int); |
| 64 | void xfs_btree_trace_argipk(const char *, struct xfs_btree_cur *, int, | 62 | void xfs_btree_trace_argipk(const char *, struct xfs_btree_cur *, int, |
| 65 | union xfs_btree_ptr, union xfs_btree_key *, int); | 63 | union xfs_btree_ptr, union xfs_btree_key *, int); |
| @@ -71,24 +69,10 @@ void xfs_btree_trace_argr(const char *, struct xfs_btree_cur *, | |||
| 71 | union xfs_btree_rec *, int); | 69 | union xfs_btree_rec *, int); |
| 72 | void xfs_btree_trace_cursor(const char *, struct xfs_btree_cur *, int, int); | 70 | void xfs_btree_trace_cursor(const char *, struct xfs_btree_cur *, int, int); |
| 73 | 71 | ||
| 74 | |||
| 75 | #define XFS_ALLOCBT_TRACE_SIZE 4096 /* size of global trace buffer */ | ||
| 76 | extern ktrace_t *xfs_allocbt_trace_buf; | ||
| 77 | |||
| 78 | #define XFS_INOBT_TRACE_SIZE 4096 /* size of global trace buffer */ | ||
| 79 | extern ktrace_t *xfs_inobt_trace_buf; | ||
| 80 | |||
| 81 | #define XFS_BMBT_TRACE_SIZE 4096 /* size of global trace buffer */ | ||
| 82 | #define XFS_BMBT_KTRACE_SIZE 32 /* size of per-inode trace buffer */ | ||
| 83 | extern ktrace_t *xfs_bmbt_trace_buf; | ||
| 84 | |||
| 85 | |||
| 86 | #define XFS_BTREE_TRACE_ARGBI(c, b, i) \ | 72 | #define XFS_BTREE_TRACE_ARGBI(c, b, i) \ |
| 87 | xfs_btree_trace_argbi(__func__, c, b, i, __LINE__) | 73 | xfs_btree_trace_argbi(__func__, c, b, i, __LINE__) |
| 88 | #define XFS_BTREE_TRACE_ARGBII(c, b, i, j) \ | 74 | #define XFS_BTREE_TRACE_ARGBII(c, b, i, j) \ |
| 89 | xfs_btree_trace_argbii(__func__, c, b, i, j, __LINE__) | 75 | xfs_btree_trace_argbii(__func__, c, b, i, j, __LINE__) |
| 90 | #define XFS_BTREE_TRACE_ARGFFFI(c, o, b, i, j) \ | ||
| 91 | xfs_btree_trace_argfffi(__func__, c, o, b, i, j, __LINE__) | ||
| 92 | #define XFS_BTREE_TRACE_ARGI(c, i) \ | 76 | #define XFS_BTREE_TRACE_ARGI(c, i) \ |
| 93 | xfs_btree_trace_argi(__func__, c, i, __LINE__) | 77 | xfs_btree_trace_argi(__func__, c, i, __LINE__) |
| 94 | #define XFS_BTREE_TRACE_ARGIPK(c, i, p, k) \ | 78 | #define XFS_BTREE_TRACE_ARGIPK(c, i, p, k) \ |
| @@ -104,7 +88,6 @@ extern ktrace_t *xfs_bmbt_trace_buf; | |||
| 104 | #else | 88 | #else |
| 105 | #define XFS_BTREE_TRACE_ARGBI(c, b, i) | 89 | #define XFS_BTREE_TRACE_ARGBI(c, b, i) |
| 106 | #define XFS_BTREE_TRACE_ARGBII(c, b, i, j) | 90 | #define XFS_BTREE_TRACE_ARGBII(c, b, i, j) |
| 107 | #define XFS_BTREE_TRACE_ARGFFFI(c, o, b, i, j) | ||
| 108 | #define XFS_BTREE_TRACE_ARGI(c, i) | 91 | #define XFS_BTREE_TRACE_ARGI(c, i) |
| 109 | #define XFS_BTREE_TRACE_ARGIPK(c, i, p, s) | 92 | #define XFS_BTREE_TRACE_ARGIPK(c, i, p, s) |
| 110 | #define XFS_BTREE_TRACE_ARGIPR(c, i, p, r) | 93 | #define XFS_BTREE_TRACE_ARGIPR(c, i, p, r) |
diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c index 92af4098c7e8..a30f7e9eb2b9 100644 --- a/fs/xfs/xfs_buf_item.c +++ b/fs/xfs/xfs_buf_item.c | |||
| @@ -29,6 +29,7 @@ | |||
| 29 | #include "xfs_buf_item.h" | 29 | #include "xfs_buf_item.h" |
| 30 | #include "xfs_trans_priv.h" | 30 | #include "xfs_trans_priv.h" |
| 31 | #include "xfs_error.h" | 31 | #include "xfs_error.h" |
| 32 | #include "xfs_trace.h" | ||
| 32 | 33 | ||
| 33 | 34 | ||
| 34 | kmem_zone_t *xfs_buf_item_zone; | 35 | kmem_zone_t *xfs_buf_item_zone; |
| @@ -164,7 +165,7 @@ xfs_buf_item_size( | |||
| 164 | * is the buf log format structure with the | 165 | * is the buf log format structure with the |
| 165 | * cancel flag in it. | 166 | * cancel flag in it. |
| 166 | */ | 167 | */ |
| 167 | xfs_buf_item_trace("SIZE STALE", bip); | 168 | trace_xfs_buf_item_size_stale(bip); |
| 168 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); | 169 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); |
| 169 | return 1; | 170 | return 1; |
| 170 | } | 171 | } |
| @@ -206,7 +207,7 @@ xfs_buf_item_size( | |||
| 206 | } | 207 | } |
| 207 | } | 208 | } |
| 208 | 209 | ||
| 209 | xfs_buf_item_trace("SIZE NORM", bip); | 210 | trace_xfs_buf_item_size(bip); |
| 210 | return nvecs; | 211 | return nvecs; |
| 211 | } | 212 | } |
| 212 | 213 | ||
| @@ -259,7 +260,7 @@ xfs_buf_item_format( | |||
| 259 | * is the buf log format structure with the | 260 | * is the buf log format structure with the |
| 260 | * cancel flag in it. | 261 | * cancel flag in it. |
| 261 | */ | 262 | */ |
| 262 | xfs_buf_item_trace("FORMAT STALE", bip); | 263 | trace_xfs_buf_item_format_stale(bip); |
| 263 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); | 264 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); |
| 264 | bip->bli_format.blf_size = nvecs; | 265 | bip->bli_format.blf_size = nvecs; |
| 265 | return; | 266 | return; |
| @@ -335,7 +336,7 @@ xfs_buf_item_format( | |||
| 335 | /* | 336 | /* |
| 336 | * Check to make sure everything is consistent. | 337 | * Check to make sure everything is consistent. |
| 337 | */ | 338 | */ |
| 338 | xfs_buf_item_trace("FORMAT NORM", bip); | 339 | trace_xfs_buf_item_format(bip); |
| 339 | xfs_buf_item_log_check(bip); | 340 | xfs_buf_item_log_check(bip); |
| 340 | } | 341 | } |
| 341 | 342 | ||
| @@ -355,8 +356,7 @@ xfs_buf_item_pin( | |||
| 355 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 356 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 356 | ASSERT((bip->bli_flags & XFS_BLI_LOGGED) || | 357 | ASSERT((bip->bli_flags & XFS_BLI_LOGGED) || |
| 357 | (bip->bli_flags & XFS_BLI_STALE)); | 358 | (bip->bli_flags & XFS_BLI_STALE)); |
| 358 | xfs_buf_item_trace("PIN", bip); | 359 | trace_xfs_buf_item_pin(bip); |
| 359 | xfs_buftrace("XFS_PIN", bp); | ||
| 360 | xfs_bpin(bp); | 360 | xfs_bpin(bp); |
| 361 | } | 361 | } |
| 362 | 362 | ||
| @@ -383,8 +383,7 @@ xfs_buf_item_unpin( | |||
| 383 | ASSERT(bp != NULL); | 383 | ASSERT(bp != NULL); |
| 384 | ASSERT(XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *) == bip); | 384 | ASSERT(XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *) == bip); |
| 385 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 385 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 386 | xfs_buf_item_trace("UNPIN", bip); | 386 | trace_xfs_buf_item_unpin(bip); |
| 387 | xfs_buftrace("XFS_UNPIN", bp); | ||
| 388 | 387 | ||
| 389 | freed = atomic_dec_and_test(&bip->bli_refcount); | 388 | freed = atomic_dec_and_test(&bip->bli_refcount); |
| 390 | ailp = bip->bli_item.li_ailp; | 389 | ailp = bip->bli_item.li_ailp; |
| @@ -395,8 +394,8 @@ xfs_buf_item_unpin( | |||
| 395 | ASSERT(!(XFS_BUF_ISDELAYWRITE(bp))); | 394 | ASSERT(!(XFS_BUF_ISDELAYWRITE(bp))); |
| 396 | ASSERT(XFS_BUF_ISSTALE(bp)); | 395 | ASSERT(XFS_BUF_ISSTALE(bp)); |
| 397 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); | 396 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); |
| 398 | xfs_buf_item_trace("UNPIN STALE", bip); | 397 | trace_xfs_buf_item_unpin_stale(bip); |
| 399 | xfs_buftrace("XFS_UNPIN STALE", bp); | 398 | |
| 400 | /* | 399 | /* |
| 401 | * If we get called here because of an IO error, we may | 400 | * If we get called here because of an IO error, we may |
| 402 | * or may not have the item on the AIL. xfs_trans_ail_delete() | 401 | * or may not have the item on the AIL. xfs_trans_ail_delete() |
| @@ -440,8 +439,8 @@ xfs_buf_item_unpin_remove( | |||
| 440 | if ((atomic_read(&bip->bli_refcount) == 1) && | 439 | if ((atomic_read(&bip->bli_refcount) == 1) && |
| 441 | (bip->bli_flags & XFS_BLI_STALE)) { | 440 | (bip->bli_flags & XFS_BLI_STALE)) { |
| 442 | ASSERT(XFS_BUF_VALUSEMA(bip->bli_buf) <= 0); | 441 | ASSERT(XFS_BUF_VALUSEMA(bip->bli_buf) <= 0); |
| 443 | xfs_buf_item_trace("UNPIN REMOVE", bip); | 442 | trace_xfs_buf_item_unpin_stale(bip); |
| 444 | xfs_buftrace("XFS_UNPIN_REMOVE", bp); | 443 | |
| 445 | /* | 444 | /* |
| 446 | * yes -- clear the xaction descriptor in-use flag | 445 | * yes -- clear the xaction descriptor in-use flag |
| 447 | * and free the chunk if required. We can safely | 446 | * and free the chunk if required. We can safely |
| @@ -495,7 +494,7 @@ xfs_buf_item_trylock( | |||
| 495 | XFS_BUF_HOLD(bp); | 494 | XFS_BUF_HOLD(bp); |
| 496 | 495 | ||
| 497 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | 496 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); |
| 498 | xfs_buf_item_trace("TRYLOCK SUCCESS", bip); | 497 | trace_xfs_buf_item_trylock(bip); |
| 499 | return XFS_ITEM_SUCCESS; | 498 | return XFS_ITEM_SUCCESS; |
| 500 | } | 499 | } |
| 501 | 500 | ||
| @@ -524,7 +523,6 @@ xfs_buf_item_unlock( | |||
| 524 | uint hold; | 523 | uint hold; |
| 525 | 524 | ||
| 526 | bp = bip->bli_buf; | 525 | bp = bip->bli_buf; |
| 527 | xfs_buftrace("XFS_UNLOCK", bp); | ||
| 528 | 526 | ||
| 529 | /* | 527 | /* |
| 530 | * Clear the buffer's association with this transaction. | 528 | * Clear the buffer's association with this transaction. |
| @@ -547,7 +545,7 @@ xfs_buf_item_unlock( | |||
| 547 | */ | 545 | */ |
| 548 | if (bip->bli_flags & XFS_BLI_STALE) { | 546 | if (bip->bli_flags & XFS_BLI_STALE) { |
| 549 | bip->bli_flags &= ~XFS_BLI_LOGGED; | 547 | bip->bli_flags &= ~XFS_BLI_LOGGED; |
| 550 | xfs_buf_item_trace("UNLOCK STALE", bip); | 548 | trace_xfs_buf_item_unlock_stale(bip); |
| 551 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); | 549 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); |
| 552 | if (!aborted) | 550 | if (!aborted) |
| 553 | return; | 551 | return; |
| @@ -574,7 +572,7 @@ xfs_buf_item_unlock( | |||
| 574 | * release the buffer at the end of this routine. | 572 | * release the buffer at the end of this routine. |
| 575 | */ | 573 | */ |
| 576 | hold = bip->bli_flags & XFS_BLI_HOLD; | 574 | hold = bip->bli_flags & XFS_BLI_HOLD; |
| 577 | xfs_buf_item_trace("UNLOCK", bip); | 575 | trace_xfs_buf_item_unlock(bip); |
| 578 | 576 | ||
| 579 | /* | 577 | /* |
| 580 | * If the buf item isn't tracking any data, free it. | 578 | * If the buf item isn't tracking any data, free it. |
| @@ -618,7 +616,8 @@ xfs_buf_item_committed( | |||
| 618 | xfs_buf_log_item_t *bip, | 616 | xfs_buf_log_item_t *bip, |
| 619 | xfs_lsn_t lsn) | 617 | xfs_lsn_t lsn) |
| 620 | { | 618 | { |
| 621 | xfs_buf_item_trace("COMMITTED", bip); | 619 | trace_xfs_buf_item_committed(bip); |
| 620 | |||
| 622 | if ((bip->bli_flags & XFS_BLI_INODE_ALLOC_BUF) && | 621 | if ((bip->bli_flags & XFS_BLI_INODE_ALLOC_BUF) && |
| 623 | (bip->bli_item.li_lsn != 0)) { | 622 | (bip->bli_item.li_lsn != 0)) { |
| 624 | return bip->bli_item.li_lsn; | 623 | return bip->bli_item.li_lsn; |
| @@ -640,7 +639,7 @@ xfs_buf_item_push( | |||
| 640 | xfs_buf_t *bp; | 639 | xfs_buf_t *bp; |
| 641 | 640 | ||
| 642 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | 641 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); |
| 643 | xfs_buf_item_trace("PUSH", bip); | 642 | trace_xfs_buf_item_push(bip); |
| 644 | 643 | ||
| 645 | bp = bip->bli_buf; | 644 | bp = bip->bli_buf; |
| 646 | 645 | ||
| @@ -738,9 +737,6 @@ xfs_buf_item_init( | |||
| 738 | bip->bli_format.blf_blkno = (__int64_t)XFS_BUF_ADDR(bp); | 737 | bip->bli_format.blf_blkno = (__int64_t)XFS_BUF_ADDR(bp); |
| 739 | bip->bli_format.blf_len = (ushort)BTOBB(XFS_BUF_COUNT(bp)); | 738 | bip->bli_format.blf_len = (ushort)BTOBB(XFS_BUF_COUNT(bp)); |
| 740 | bip->bli_format.blf_map_size = map_size; | 739 | bip->bli_format.blf_map_size = map_size; |
| 741 | #ifdef XFS_BLI_TRACE | ||
| 742 | bip->bli_trace = ktrace_alloc(XFS_BLI_TRACE_SIZE, KM_NOFS); | ||
| 743 | #endif | ||
| 744 | 740 | ||
| 745 | #ifdef XFS_TRANS_DEBUG | 741 | #ifdef XFS_TRANS_DEBUG |
| 746 | /* | 742 | /* |
| @@ -878,9 +874,6 @@ xfs_buf_item_free( | |||
| 878 | kmem_free(bip->bli_logged); | 874 | kmem_free(bip->bli_logged); |
| 879 | #endif /* XFS_TRANS_DEBUG */ | 875 | #endif /* XFS_TRANS_DEBUG */ |
| 880 | 876 | ||
| 881 | #ifdef XFS_BLI_TRACE | ||
| 882 | ktrace_free(bip->bli_trace); | ||
| 883 | #endif | ||
| 884 | kmem_zone_free(xfs_buf_item_zone, bip); | 877 | kmem_zone_free(xfs_buf_item_zone, bip); |
| 885 | } | 878 | } |
| 886 | 879 | ||
| @@ -897,7 +890,8 @@ xfs_buf_item_relse( | |||
| 897 | { | 890 | { |
| 898 | xfs_buf_log_item_t *bip; | 891 | xfs_buf_log_item_t *bip; |
| 899 | 892 | ||
| 900 | xfs_buftrace("XFS_RELSE", bp); | 893 | trace_xfs_buf_item_relse(bp, _RET_IP_); |
| 894 | |||
| 901 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t*); | 895 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t*); |
| 902 | XFS_BUF_SET_FSPRIVATE(bp, bip->bli_item.li_bio_list); | 896 | XFS_BUF_SET_FSPRIVATE(bp, bip->bli_item.li_bio_list); |
| 903 | if ((XFS_BUF_FSPRIVATE(bp, void *) == NULL) && | 897 | if ((XFS_BUF_FSPRIVATE(bp, void *) == NULL) && |
| @@ -994,7 +988,7 @@ xfs_buf_iodone_callbacks( | |||
| 994 | if (XFS_FORCED_SHUTDOWN(mp)) { | 988 | if (XFS_FORCED_SHUTDOWN(mp)) { |
| 995 | ASSERT(XFS_BUF_TARGET(bp) == mp->m_ddev_targp); | 989 | ASSERT(XFS_BUF_TARGET(bp) == mp->m_ddev_targp); |
| 996 | XFS_BUF_SUPER_STALE(bp); | 990 | XFS_BUF_SUPER_STALE(bp); |
| 997 | xfs_buftrace("BUF_IODONE_CB", bp); | 991 | trace_xfs_buf_item_iodone(bp, _RET_IP_); |
| 998 | xfs_buf_do_callbacks(bp, lip); | 992 | xfs_buf_do_callbacks(bp, lip); |
| 999 | XFS_BUF_SET_FSPRIVATE(bp, NULL); | 993 | XFS_BUF_SET_FSPRIVATE(bp, NULL); |
| 1000 | XFS_BUF_CLR_IODONE_FUNC(bp); | 994 | XFS_BUF_CLR_IODONE_FUNC(bp); |
| @@ -1030,7 +1024,7 @@ xfs_buf_iodone_callbacks( | |||
| 1030 | XFS_BUF_SET_START(bp); | 1024 | XFS_BUF_SET_START(bp); |
| 1031 | } | 1025 | } |
| 1032 | ASSERT(XFS_BUF_IODONE_FUNC(bp)); | 1026 | ASSERT(XFS_BUF_IODONE_FUNC(bp)); |
| 1033 | xfs_buftrace("BUF_IODONE ASYNC", bp); | 1027 | trace_xfs_buf_item_iodone_async(bp, _RET_IP_); |
| 1034 | xfs_buf_relse(bp); | 1028 | xfs_buf_relse(bp); |
| 1035 | } else { | 1029 | } else { |
| 1036 | /* | 1030 | /* |
| @@ -1053,9 +1047,7 @@ xfs_buf_iodone_callbacks( | |||
| 1053 | } | 1047 | } |
| 1054 | return; | 1048 | return; |
| 1055 | } | 1049 | } |
| 1056 | #ifdef XFSERRORDEBUG | 1050 | |
| 1057 | xfs_buftrace("XFS BUFCB NOERR", bp); | ||
| 1058 | #endif | ||
| 1059 | xfs_buf_do_callbacks(bp, lip); | 1051 | xfs_buf_do_callbacks(bp, lip); |
| 1060 | XFS_BUF_SET_FSPRIVATE(bp, NULL); | 1052 | XFS_BUF_SET_FSPRIVATE(bp, NULL); |
| 1061 | XFS_BUF_CLR_IODONE_FUNC(bp); | 1053 | XFS_BUF_CLR_IODONE_FUNC(bp); |
| @@ -1081,7 +1073,9 @@ xfs_buf_error_relse( | |||
| 1081 | XFS_BUF_DONE(bp); | 1073 | XFS_BUF_DONE(bp); |
| 1082 | XFS_BUF_UNDELAYWRITE(bp); | 1074 | XFS_BUF_UNDELAYWRITE(bp); |
| 1083 | XFS_BUF_ERROR(bp,0); | 1075 | XFS_BUF_ERROR(bp,0); |
| 1084 | xfs_buftrace("BUF_ERROR_RELSE", bp); | 1076 | |
| 1077 | trace_xfs_buf_error_relse(bp, _RET_IP_); | ||
| 1078 | |||
| 1085 | if (! XFS_FORCED_SHUTDOWN(mp)) | 1079 | if (! XFS_FORCED_SHUTDOWN(mp)) |
| 1086 | xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR); | 1080 | xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR); |
| 1087 | /* | 1081 | /* |
| @@ -1128,34 +1122,3 @@ xfs_buf_iodone( | |||
| 1128 | xfs_trans_ail_delete(ailp, (xfs_log_item_t *)bip); | 1122 | xfs_trans_ail_delete(ailp, (xfs_log_item_t *)bip); |
| 1129 | xfs_buf_item_free(bip); | 1123 | xfs_buf_item_free(bip); |
| 1130 | } | 1124 | } |
| 1131 | |||
| 1132 | #if defined(XFS_BLI_TRACE) | ||
| 1133 | void | ||
| 1134 | xfs_buf_item_trace( | ||
| 1135 | char *id, | ||
| 1136 | xfs_buf_log_item_t *bip) | ||
| 1137 | { | ||
| 1138 | xfs_buf_t *bp; | ||
| 1139 | ASSERT(bip->bli_trace != NULL); | ||
| 1140 | |||
| 1141 | bp = bip->bli_buf; | ||
| 1142 | ktrace_enter(bip->bli_trace, | ||
| 1143 | (void *)id, | ||
| 1144 | (void *)bip->bli_buf, | ||
| 1145 | (void *)((unsigned long)bip->bli_flags), | ||
| 1146 | (void *)((unsigned long)bip->bli_recur), | ||
| 1147 | (void *)((unsigned long)atomic_read(&bip->bli_refcount)), | ||
| 1148 | (void *)((unsigned long) | ||
| 1149 | (0xFFFFFFFF & XFS_BUF_ADDR(bp) >> 32)), | ||
| 1150 | (void *)((unsigned long)(0xFFFFFFFF & XFS_BUF_ADDR(bp))), | ||
| 1151 | (void *)((unsigned long)XFS_BUF_COUNT(bp)), | ||
| 1152 | (void *)((unsigned long)XFS_BUF_BFLAGS(bp)), | ||
| 1153 | XFS_BUF_FSPRIVATE(bp, void *), | ||
| 1154 | XFS_BUF_FSPRIVATE2(bp, void *), | ||
| 1155 | (void *)(unsigned long)XFS_BUF_ISPINNED(bp), | ||
| 1156 | (void *)XFS_BUF_IODONE_FUNC(bp), | ||
| 1157 | (void *)((unsigned long)(XFS_BUF_VALUSEMA(bp))), | ||
| 1158 | (void *)bip->bli_item.li_desc, | ||
| 1159 | (void *)((unsigned long)bip->bli_item.li_flags)); | ||
| 1160 | } | ||
| 1161 | #endif /* XFS_BLI_TRACE */ | ||
diff --git a/fs/xfs/xfs_buf_item.h b/fs/xfs/xfs_buf_item.h index 5a41c348bb1c..217f34af00cb 100644 --- a/fs/xfs/xfs_buf_item.h +++ b/fs/xfs/xfs_buf_item.h | |||
| @@ -70,22 +70,21 @@ typedef struct xfs_buf_log_format_t { | |||
| 70 | #define XFS_BLI_INODE_ALLOC_BUF 0x10 | 70 | #define XFS_BLI_INODE_ALLOC_BUF 0x10 |
| 71 | #define XFS_BLI_STALE_INODE 0x20 | 71 | #define XFS_BLI_STALE_INODE 0x20 |
| 72 | 72 | ||
| 73 | #define XFS_BLI_FLAGS \ | ||
| 74 | { XFS_BLI_HOLD, "HOLD" }, \ | ||
| 75 | { XFS_BLI_DIRTY, "DIRTY" }, \ | ||
| 76 | { XFS_BLI_STALE, "STALE" }, \ | ||
| 77 | { XFS_BLI_LOGGED, "LOGGED" }, \ | ||
| 78 | { XFS_BLI_INODE_ALLOC_BUF, "INODE_ALLOC" }, \ | ||
| 79 | { XFS_BLI_STALE_INODE, "STALE_INODE" } | ||
| 80 | |||
| 73 | 81 | ||
| 74 | #ifdef __KERNEL__ | 82 | #ifdef __KERNEL__ |
| 75 | 83 | ||
| 76 | struct xfs_buf; | 84 | struct xfs_buf; |
| 77 | struct ktrace; | ||
| 78 | struct xfs_mount; | 85 | struct xfs_mount; |
| 79 | struct xfs_buf_log_item; | 86 | struct xfs_buf_log_item; |
| 80 | 87 | ||
| 81 | #if defined(XFS_BLI_TRACE) | ||
| 82 | #define XFS_BLI_TRACE_SIZE 32 | ||
| 83 | |||
| 84 | void xfs_buf_item_trace(char *, struct xfs_buf_log_item *); | ||
| 85 | #else | ||
| 86 | #define xfs_buf_item_trace(id, bip) | ||
| 87 | #endif | ||
| 88 | |||
| 89 | /* | 88 | /* |
| 90 | * This is the in core log item structure used to track information | 89 | * This is the in core log item structure used to track information |
| 91 | * needed to log buffers. It tracks how many times the lock has been | 90 | * needed to log buffers. It tracks how many times the lock has been |
| @@ -97,9 +96,6 @@ typedef struct xfs_buf_log_item { | |||
| 97 | unsigned int bli_flags; /* misc flags */ | 96 | unsigned int bli_flags; /* misc flags */ |
| 98 | unsigned int bli_recur; /* lock recursion count */ | 97 | unsigned int bli_recur; /* lock recursion count */ |
| 99 | atomic_t bli_refcount; /* cnt of tp refs */ | 98 | atomic_t bli_refcount; /* cnt of tp refs */ |
| 100 | #ifdef XFS_BLI_TRACE | ||
| 101 | struct ktrace *bli_trace; /* event trace buf */ | ||
| 102 | #endif | ||
| 103 | #ifdef XFS_TRANS_DEBUG | 99 | #ifdef XFS_TRANS_DEBUG |
| 104 | char *bli_orig; /* original buffer copy */ | 100 | char *bli_orig; /* original buffer copy */ |
| 105 | char *bli_logged; /* bytes logged (bitmap) */ | 101 | char *bli_logged; /* bytes logged (bitmap) */ |
diff --git a/fs/xfs/xfs_da_btree.c b/fs/xfs/xfs_da_btree.c index 2847bbc1c534..c0c8869115b1 100644 --- a/fs/xfs/xfs_da_btree.c +++ b/fs/xfs/xfs_da_btree.c | |||
| @@ -46,6 +46,7 @@ | |||
| 46 | #include "xfs_dir2_block.h" | 46 | #include "xfs_dir2_block.h" |
| 47 | #include "xfs_dir2_node.h" | 47 | #include "xfs_dir2_node.h" |
| 48 | #include "xfs_error.h" | 48 | #include "xfs_error.h" |
| 49 | #include "xfs_trace.h" | ||
| 49 | 50 | ||
| 50 | /* | 51 | /* |
| 51 | * xfs_da_btree.c | 52 | * xfs_da_btree.c |
| @@ -2107,7 +2108,7 @@ xfs_da_do_buf( | |||
| 2107 | (be32_to_cpu(free->hdr.magic) != XFS_DIR2_FREE_MAGIC), | 2108 | (be32_to_cpu(free->hdr.magic) != XFS_DIR2_FREE_MAGIC), |
| 2108 | mp, XFS_ERRTAG_DA_READ_BUF, | 2109 | mp, XFS_ERRTAG_DA_READ_BUF, |
| 2109 | XFS_RANDOM_DA_READ_BUF))) { | 2110 | XFS_RANDOM_DA_READ_BUF))) { |
| 2110 | xfs_buftrace("DA READ ERROR", rbp->bps[0]); | 2111 | trace_xfs_da_btree_corrupt(rbp->bps[0], _RET_IP_); |
| 2111 | XFS_CORRUPTION_ERROR("xfs_da_do_buf(2)", | 2112 | XFS_CORRUPTION_ERROR("xfs_da_do_buf(2)", |
| 2112 | XFS_ERRLEVEL_LOW, mp, info); | 2113 | XFS_ERRLEVEL_LOW, mp, info); |
| 2113 | error = XFS_ERROR(EFSCORRUPTED); | 2114 | error = XFS_ERROR(EFSCORRUPTED); |
diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h index 8c536167bf75..30cd08f56a3a 100644 --- a/fs/xfs/xfs_da_btree.h +++ b/fs/xfs/xfs_da_btree.h | |||
| @@ -125,6 +125,13 @@ typedef struct xfs_da_args { | |||
| 125 | #define XFS_DA_OP_OKNOENT 0x0008 /* lookup/add op, ENOENT ok, else die */ | 125 | #define XFS_DA_OP_OKNOENT 0x0008 /* lookup/add op, ENOENT ok, else die */ |
| 126 | #define XFS_DA_OP_CILOOKUP 0x0010 /* lookup to return CI name if found */ | 126 | #define XFS_DA_OP_CILOOKUP 0x0010 /* lookup to return CI name if found */ |
| 127 | 127 | ||
| 128 | #define XFS_DA_OP_FLAGS \ | ||
| 129 | { XFS_DA_OP_JUSTCHECK, "JUSTCHECK" }, \ | ||
| 130 | { XFS_DA_OP_RENAME, "RENAME" }, \ | ||
| 131 | { XFS_DA_OP_ADDNAME, "ADDNAME" }, \ | ||
| 132 | { XFS_DA_OP_OKNOENT, "OKNOENT" }, \ | ||
| 133 | { XFS_DA_OP_CILOOKUP, "CILOOKUP" } | ||
| 134 | |||
| 128 | /* | 135 | /* |
| 129 | * Structure to describe buffer(s) for a block. | 136 | * Structure to describe buffer(s) for a block. |
| 130 | * This is needed in the directory version 2 format case, when | 137 | * This is needed in the directory version 2 format case, when |
diff --git a/fs/xfs/xfs_dfrag.c b/fs/xfs/xfs_dfrag.c index ab89a7e94a0f..d1483a4f71b8 100644 --- a/fs/xfs/xfs_dfrag.c +++ b/fs/xfs/xfs_dfrag.c | |||
| @@ -43,6 +43,7 @@ | |||
| 43 | #include "xfs_error.h" | 43 | #include "xfs_error.h" |
| 44 | #include "xfs_rw.h" | 44 | #include "xfs_rw.h" |
| 45 | #include "xfs_vnodeops.h" | 45 | #include "xfs_vnodeops.h" |
| 46 | #include "xfs_trace.h" | ||
| 46 | 47 | ||
| 47 | /* | 48 | /* |
| 48 | * Syssgi interface for swapext | 49 | * Syssgi interface for swapext |
| @@ -168,7 +169,6 @@ xfs_swap_extents( | |||
| 168 | } | 169 | } |
| 169 | 170 | ||
| 170 | if (VN_CACHED(VFS_I(tip)) != 0) { | 171 | if (VN_CACHED(VFS_I(tip)) != 0) { |
| 171 | xfs_inval_cached_trace(tip, 0, -1, 0, -1); | ||
| 172 | error = xfs_flushinval_pages(tip, 0, -1, | 172 | error = xfs_flushinval_pages(tip, 0, -1, |
| 173 | FI_REMAPF_LOCKED); | 173 | FI_REMAPF_LOCKED); |
| 174 | if (error) | 174 | if (error) |
diff --git a/fs/xfs/xfs_dir2.c b/fs/xfs/xfs_dir2.c index bb1d58eb3982..93634a7e90e9 100644 --- a/fs/xfs/xfs_dir2.c +++ b/fs/xfs/xfs_dir2.c | |||
| @@ -40,9 +40,9 @@ | |||
| 40 | #include "xfs_dir2_leaf.h" | 40 | #include "xfs_dir2_leaf.h" |
| 41 | #include "xfs_dir2_block.h" | 41 | #include "xfs_dir2_block.h" |
| 42 | #include "xfs_dir2_node.h" | 42 | #include "xfs_dir2_node.h" |
| 43 | #include "xfs_dir2_trace.h" | ||
| 44 | #include "xfs_error.h" | 43 | #include "xfs_error.h" |
| 45 | #include "xfs_vnodeops.h" | 44 | #include "xfs_vnodeops.h" |
| 45 | #include "xfs_trace.h" | ||
| 46 | 46 | ||
| 47 | struct xfs_name xfs_name_dotdot = {"..", 2}; | 47 | struct xfs_name xfs_name_dotdot = {"..", 2}; |
| 48 | 48 | ||
| @@ -525,7 +525,8 @@ xfs_dir2_grow_inode( | |||
| 525 | xfs_trans_t *tp; | 525 | xfs_trans_t *tp; |
| 526 | xfs_drfsbno_t nblks; | 526 | xfs_drfsbno_t nblks; |
| 527 | 527 | ||
| 528 | xfs_dir2_trace_args_s("grow_inode", args, space); | 528 | trace_xfs_dir2_grow_inode(args, space); |
| 529 | |||
| 529 | dp = args->dp; | 530 | dp = args->dp; |
| 530 | tp = args->trans; | 531 | tp = args->trans; |
| 531 | mp = dp->i_mount; | 532 | mp = dp->i_mount; |
| @@ -703,7 +704,8 @@ xfs_dir2_shrink_inode( | |||
| 703 | xfs_mount_t *mp; | 704 | xfs_mount_t *mp; |
| 704 | xfs_trans_t *tp; | 705 | xfs_trans_t *tp; |
| 705 | 706 | ||
| 706 | xfs_dir2_trace_args_db("shrink_inode", args, db, bp); | 707 | trace_xfs_dir2_shrink_inode(args, db); |
| 708 | |||
| 707 | dp = args->dp; | 709 | dp = args->dp; |
| 708 | mp = dp->i_mount; | 710 | mp = dp->i_mount; |
| 709 | tp = args->trans; | 711 | tp = args->trans; |
diff --git a/fs/xfs/xfs_dir2_block.c b/fs/xfs/xfs_dir2_block.c index ab52e9e1c1ee..ddc4ecc7807f 100644 --- a/fs/xfs/xfs_dir2_block.c +++ b/fs/xfs/xfs_dir2_block.c | |||
| @@ -36,8 +36,8 @@ | |||
| 36 | #include "xfs_dir2_data.h" | 36 | #include "xfs_dir2_data.h" |
| 37 | #include "xfs_dir2_leaf.h" | 37 | #include "xfs_dir2_leaf.h" |
| 38 | #include "xfs_dir2_block.h" | 38 | #include "xfs_dir2_block.h" |
| 39 | #include "xfs_dir2_trace.h" | ||
| 40 | #include "xfs_error.h" | 39 | #include "xfs_error.h" |
| 40 | #include "xfs_trace.h" | ||
| 41 | 41 | ||
| 42 | /* | 42 | /* |
| 43 | * Local function prototypes. | 43 | * Local function prototypes. |
| @@ -94,7 +94,8 @@ xfs_dir2_block_addname( | |||
| 94 | __be16 *tagp; /* pointer to tag value */ | 94 | __be16 *tagp; /* pointer to tag value */ |
| 95 | xfs_trans_t *tp; /* transaction structure */ | 95 | xfs_trans_t *tp; /* transaction structure */ |
| 96 | 96 | ||
| 97 | xfs_dir2_trace_args("block_addname", args); | 97 | trace_xfs_dir2_block_addname(args); |
| 98 | |||
| 98 | dp = args->dp; | 99 | dp = args->dp; |
| 99 | tp = args->trans; | 100 | tp = args->trans; |
| 100 | mp = dp->i_mount; | 101 | mp = dp->i_mount; |
| @@ -590,7 +591,8 @@ xfs_dir2_block_lookup( | |||
| 590 | int error; /* error return value */ | 591 | int error; /* error return value */ |
| 591 | xfs_mount_t *mp; /* filesystem mount point */ | 592 | xfs_mount_t *mp; /* filesystem mount point */ |
| 592 | 593 | ||
| 593 | xfs_dir2_trace_args("block_lookup", args); | 594 | trace_xfs_dir2_block_lookup(args); |
| 595 | |||
| 594 | /* | 596 | /* |
| 595 | * Get the buffer, look up the entry. | 597 | * Get the buffer, look up the entry. |
| 596 | * If not found (ENOENT) then return, have no buffer. | 598 | * If not found (ENOENT) then return, have no buffer. |
| @@ -747,7 +749,8 @@ xfs_dir2_block_removename( | |||
| 747 | int size; /* shortform size */ | 749 | int size; /* shortform size */ |
| 748 | xfs_trans_t *tp; /* transaction pointer */ | 750 | xfs_trans_t *tp; /* transaction pointer */ |
| 749 | 751 | ||
| 750 | xfs_dir2_trace_args("block_removename", args); | 752 | trace_xfs_dir2_block_removename(args); |
| 753 | |||
| 751 | /* | 754 | /* |
| 752 | * Look up the entry in the block. Gets the buffer and entry index. | 755 | * Look up the entry in the block. Gets the buffer and entry index. |
| 753 | * It will always be there, the vnodeops level does a lookup first. | 756 | * It will always be there, the vnodeops level does a lookup first. |
| @@ -823,7 +826,8 @@ xfs_dir2_block_replace( | |||
| 823 | int error; /* error return value */ | 826 | int error; /* error return value */ |
| 824 | xfs_mount_t *mp; /* filesystem mount point */ | 827 | xfs_mount_t *mp; /* filesystem mount point */ |
| 825 | 828 | ||
| 826 | xfs_dir2_trace_args("block_replace", args); | 829 | trace_xfs_dir2_block_replace(args); |
| 830 | |||
| 827 | /* | 831 | /* |
| 828 | * Lookup the entry in the directory. Get buffer and entry index. | 832 | * Lookup the entry in the directory. Get buffer and entry index. |
| 829 | * This will always succeed since the caller has already done a lookup. | 833 | * This will always succeed since the caller has already done a lookup. |
| @@ -897,7 +901,8 @@ xfs_dir2_leaf_to_block( | |||
| 897 | int to; /* block/leaf to index */ | 901 | int to; /* block/leaf to index */ |
| 898 | xfs_trans_t *tp; /* transaction pointer */ | 902 | xfs_trans_t *tp; /* transaction pointer */ |
| 899 | 903 | ||
| 900 | xfs_dir2_trace_args_bb("leaf_to_block", args, lbp, dbp); | 904 | trace_xfs_dir2_leaf_to_block(args); |
| 905 | |||
| 901 | dp = args->dp; | 906 | dp = args->dp; |
| 902 | tp = args->trans; | 907 | tp = args->trans; |
| 903 | mp = dp->i_mount; | 908 | mp = dp->i_mount; |
| @@ -1044,7 +1049,8 @@ xfs_dir2_sf_to_block( | |||
| 1044 | xfs_trans_t *tp; /* transaction pointer */ | 1049 | xfs_trans_t *tp; /* transaction pointer */ |
| 1045 | struct xfs_name name; | 1050 | struct xfs_name name; |
| 1046 | 1051 | ||
| 1047 | xfs_dir2_trace_args("sf_to_block", args); | 1052 | trace_xfs_dir2_sf_to_block(args); |
| 1053 | |||
| 1048 | dp = args->dp; | 1054 | dp = args->dp; |
| 1049 | tp = args->trans; | 1055 | tp = args->trans; |
| 1050 | mp = dp->i_mount; | 1056 | mp = dp->i_mount; |
diff --git a/fs/xfs/xfs_dir2_leaf.c b/fs/xfs/xfs_dir2_leaf.c index 41ad537c49e9..29f484c11b3a 100644 --- a/fs/xfs/xfs_dir2_leaf.c +++ b/fs/xfs/xfs_dir2_leaf.c | |||
| @@ -38,8 +38,8 @@ | |||
| 38 | #include "xfs_dir2_leaf.h" | 38 | #include "xfs_dir2_leaf.h" |
| 39 | #include "xfs_dir2_block.h" | 39 | #include "xfs_dir2_block.h" |
| 40 | #include "xfs_dir2_node.h" | 40 | #include "xfs_dir2_node.h" |
| 41 | #include "xfs_dir2_trace.h" | ||
| 42 | #include "xfs_error.h" | 41 | #include "xfs_error.h" |
| 42 | #include "xfs_trace.h" | ||
| 43 | 43 | ||
| 44 | /* | 44 | /* |
| 45 | * Local function declarations. | 45 | * Local function declarations. |
| @@ -80,7 +80,8 @@ xfs_dir2_block_to_leaf( | |||
| 80 | int needscan; /* need to rescan bestfree */ | 80 | int needscan; /* need to rescan bestfree */ |
| 81 | xfs_trans_t *tp; /* transaction pointer */ | 81 | xfs_trans_t *tp; /* transaction pointer */ |
| 82 | 82 | ||
| 83 | xfs_dir2_trace_args_b("block_to_leaf", args, dbp); | 83 | trace_xfs_dir2_block_to_leaf(args); |
| 84 | |||
| 84 | dp = args->dp; | 85 | dp = args->dp; |
| 85 | mp = dp->i_mount; | 86 | mp = dp->i_mount; |
| 86 | tp = args->trans; | 87 | tp = args->trans; |
| @@ -188,7 +189,8 @@ xfs_dir2_leaf_addname( | |||
| 188 | xfs_trans_t *tp; /* transaction pointer */ | 189 | xfs_trans_t *tp; /* transaction pointer */ |
| 189 | xfs_dir2_db_t use_block; /* data block number */ | 190 | xfs_dir2_db_t use_block; /* data block number */ |
| 190 | 191 | ||
| 191 | xfs_dir2_trace_args("leaf_addname", args); | 192 | trace_xfs_dir2_leaf_addname(args); |
| 193 | |||
| 192 | dp = args->dp; | 194 | dp = args->dp; |
| 193 | tp = args->trans; | 195 | tp = args->trans; |
| 194 | mp = dp->i_mount; | 196 | mp = dp->i_mount; |
| @@ -1266,7 +1268,8 @@ xfs_dir2_leaf_lookup( | |||
| 1266 | xfs_dir2_leaf_entry_t *lep; /* leaf entry */ | 1268 | xfs_dir2_leaf_entry_t *lep; /* leaf entry */ |
| 1267 | xfs_trans_t *tp; /* transaction pointer */ | 1269 | xfs_trans_t *tp; /* transaction pointer */ |
| 1268 | 1270 | ||
| 1269 | xfs_dir2_trace_args("leaf_lookup", args); | 1271 | trace_xfs_dir2_leaf_lookup(args); |
| 1272 | |||
| 1270 | /* | 1273 | /* |
| 1271 | * Look up name in the leaf block, returning both buffers and index. | 1274 | * Look up name in the leaf block, returning both buffers and index. |
| 1272 | */ | 1275 | */ |
| @@ -1454,7 +1457,8 @@ xfs_dir2_leaf_removename( | |||
| 1454 | xfs_dir2_data_off_t oldbest; /* old value of best free */ | 1457 | xfs_dir2_data_off_t oldbest; /* old value of best free */ |
| 1455 | xfs_trans_t *tp; /* transaction pointer */ | 1458 | xfs_trans_t *tp; /* transaction pointer */ |
| 1456 | 1459 | ||
| 1457 | xfs_dir2_trace_args("leaf_removename", args); | 1460 | trace_xfs_dir2_leaf_removename(args); |
| 1461 | |||
| 1458 | /* | 1462 | /* |
| 1459 | * Lookup the leaf entry, get the leaf and data blocks read in. | 1463 | * Lookup the leaf entry, get the leaf and data blocks read in. |
| 1460 | */ | 1464 | */ |
| @@ -1586,7 +1590,8 @@ xfs_dir2_leaf_replace( | |||
| 1586 | xfs_dir2_leaf_entry_t *lep; /* leaf entry */ | 1590 | xfs_dir2_leaf_entry_t *lep; /* leaf entry */ |
| 1587 | xfs_trans_t *tp; /* transaction pointer */ | 1591 | xfs_trans_t *tp; /* transaction pointer */ |
| 1588 | 1592 | ||
| 1589 | xfs_dir2_trace_args("leaf_replace", args); | 1593 | trace_xfs_dir2_leaf_replace(args); |
| 1594 | |||
| 1590 | /* | 1595 | /* |
| 1591 | * Look up the entry. | 1596 | * Look up the entry. |
| 1592 | */ | 1597 | */ |
| @@ -1766,7 +1771,9 @@ xfs_dir2_node_to_leaf( | |||
| 1766 | if (state->path.active > 1) | 1771 | if (state->path.active > 1) |
| 1767 | return 0; | 1772 | return 0; |
| 1768 | args = state->args; | 1773 | args = state->args; |
| 1769 | xfs_dir2_trace_args("node_to_leaf", args); | 1774 | |
| 1775 | trace_xfs_dir2_node_to_leaf(args); | ||
| 1776 | |||
| 1770 | mp = state->mp; | 1777 | mp = state->mp; |
| 1771 | dp = args->dp; | 1778 | dp = args->dp; |
| 1772 | tp = args->trans; | 1779 | tp = args->trans; |
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c index 5a81ccd1045b..ce6e355199b5 100644 --- a/fs/xfs/xfs_dir2_node.c +++ b/fs/xfs/xfs_dir2_node.c | |||
| @@ -37,8 +37,8 @@ | |||
| 37 | #include "xfs_dir2_leaf.h" | 37 | #include "xfs_dir2_leaf.h" |
| 38 | #include "xfs_dir2_block.h" | 38 | #include "xfs_dir2_block.h" |
| 39 | #include "xfs_dir2_node.h" | 39 | #include "xfs_dir2_node.h" |
| 40 | #include "xfs_dir2_trace.h" | ||
| 41 | #include "xfs_error.h" | 40 | #include "xfs_error.h" |
| 41 | #include "xfs_trace.h" | ||
| 42 | 42 | ||
| 43 | /* | 43 | /* |
| 44 | * Function declarations. | 44 | * Function declarations. |
| @@ -123,7 +123,8 @@ xfs_dir2_leaf_to_node( | |||
| 123 | __be16 *to; /* pointer to freespace entry */ | 123 | __be16 *to; /* pointer to freespace entry */ |
| 124 | xfs_trans_t *tp; /* transaction pointer */ | 124 | xfs_trans_t *tp; /* transaction pointer */ |
| 125 | 125 | ||
| 126 | xfs_dir2_trace_args_b("leaf_to_node", args, lbp); | 126 | trace_xfs_dir2_leaf_to_node(args); |
| 127 | |||
| 127 | dp = args->dp; | 128 | dp = args->dp; |
| 128 | mp = dp->i_mount; | 129 | mp = dp->i_mount; |
| 129 | tp = args->trans; | 130 | tp = args->trans; |
| @@ -196,7 +197,8 @@ xfs_dir2_leafn_add( | |||
| 196 | xfs_mount_t *mp; /* filesystem mount point */ | 197 | xfs_mount_t *mp; /* filesystem mount point */ |
| 197 | xfs_trans_t *tp; /* transaction pointer */ | 198 | xfs_trans_t *tp; /* transaction pointer */ |
| 198 | 199 | ||
| 199 | xfs_dir2_trace_args_sb("leafn_add", args, index, bp); | 200 | trace_xfs_dir2_leafn_add(args, index); |
| 201 | |||
| 200 | dp = args->dp; | 202 | dp = args->dp; |
| 201 | mp = dp->i_mount; | 203 | mp = dp->i_mount; |
| 202 | tp = args->trans; | 204 | tp = args->trans; |
| @@ -711,8 +713,8 @@ xfs_dir2_leafn_moveents( | |||
| 711 | int stale; /* count stale leaves copied */ | 713 | int stale; /* count stale leaves copied */ |
| 712 | xfs_trans_t *tp; /* transaction pointer */ | 714 | xfs_trans_t *tp; /* transaction pointer */ |
| 713 | 715 | ||
| 714 | xfs_dir2_trace_args_bibii("leafn_moveents", args, bp_s, start_s, bp_d, | 716 | trace_xfs_dir2_leafn_moveents(args, start_s, start_d, count); |
| 715 | start_d, count); | 717 | |
| 716 | /* | 718 | /* |
| 717 | * Silently return if nothing to do. | 719 | * Silently return if nothing to do. |
| 718 | */ | 720 | */ |
| @@ -933,7 +935,8 @@ xfs_dir2_leafn_remove( | |||
| 933 | int needscan; /* need to rescan data frees */ | 935 | int needscan; /* need to rescan data frees */ |
| 934 | xfs_trans_t *tp; /* transaction pointer */ | 936 | xfs_trans_t *tp; /* transaction pointer */ |
| 935 | 937 | ||
| 936 | xfs_dir2_trace_args_sb("leafn_remove", args, index, bp); | 938 | trace_xfs_dir2_leafn_remove(args, index); |
| 939 | |||
| 937 | dp = args->dp; | 940 | dp = args->dp; |
| 938 | tp = args->trans; | 941 | tp = args->trans; |
| 939 | mp = dp->i_mount; | 942 | mp = dp->i_mount; |
| @@ -1363,7 +1366,8 @@ xfs_dir2_node_addname( | |||
| 1363 | int rval; /* sub-return value */ | 1366 | int rval; /* sub-return value */ |
| 1364 | xfs_da_state_t *state; /* btree cursor */ | 1367 | xfs_da_state_t *state; /* btree cursor */ |
| 1365 | 1368 | ||
| 1366 | xfs_dir2_trace_args("node_addname", args); | 1369 | trace_xfs_dir2_node_addname(args); |
| 1370 | |||
| 1367 | /* | 1371 | /* |
| 1368 | * Allocate and initialize the state (btree cursor). | 1372 | * Allocate and initialize the state (btree cursor). |
| 1369 | */ | 1373 | */ |
| @@ -1822,7 +1826,8 @@ xfs_dir2_node_lookup( | |||
| 1822 | int rval; /* operation return value */ | 1826 | int rval; /* operation return value */ |
| 1823 | xfs_da_state_t *state; /* btree cursor */ | 1827 | xfs_da_state_t *state; /* btree cursor */ |
| 1824 | 1828 | ||
| 1825 | xfs_dir2_trace_args("node_lookup", args); | 1829 | trace_xfs_dir2_node_lookup(args); |
| 1830 | |||
| 1826 | /* | 1831 | /* |
| 1827 | * Allocate and initialize the btree cursor. | 1832 | * Allocate and initialize the btree cursor. |
| 1828 | */ | 1833 | */ |
| @@ -1875,7 +1880,8 @@ xfs_dir2_node_removename( | |||
| 1875 | int rval; /* operation return value */ | 1880 | int rval; /* operation return value */ |
| 1876 | xfs_da_state_t *state; /* btree cursor */ | 1881 | xfs_da_state_t *state; /* btree cursor */ |
| 1877 | 1882 | ||
| 1878 | xfs_dir2_trace_args("node_removename", args); | 1883 | trace_xfs_dir2_node_removename(args); |
| 1884 | |||
| 1879 | /* | 1885 | /* |
| 1880 | * Allocate and initialize the btree cursor. | 1886 | * Allocate and initialize the btree cursor. |
| 1881 | */ | 1887 | */ |
| @@ -1944,7 +1950,8 @@ xfs_dir2_node_replace( | |||
| 1944 | int rval; /* internal return value */ | 1950 | int rval; /* internal return value */ |
| 1945 | xfs_da_state_t *state; /* btree cursor */ | 1951 | xfs_da_state_t *state; /* btree cursor */ |
| 1946 | 1952 | ||
| 1947 | xfs_dir2_trace_args("node_replace", args); | 1953 | trace_xfs_dir2_node_replace(args); |
| 1954 | |||
| 1948 | /* | 1955 | /* |
| 1949 | * Allocate and initialize the btree cursor. | 1956 | * Allocate and initialize the btree cursor. |
| 1950 | */ | 1957 | */ |
diff --git a/fs/xfs/xfs_dir2_sf.c b/fs/xfs/xfs_dir2_sf.c index e89734e84646..9d4f17a69676 100644 --- a/fs/xfs/xfs_dir2_sf.c +++ b/fs/xfs/xfs_dir2_sf.c | |||
| @@ -37,7 +37,7 @@ | |||
| 37 | #include "xfs_dir2_data.h" | 37 | #include "xfs_dir2_data.h" |
| 38 | #include "xfs_dir2_leaf.h" | 38 | #include "xfs_dir2_leaf.h" |
| 39 | #include "xfs_dir2_block.h" | 39 | #include "xfs_dir2_block.h" |
| 40 | #include "xfs_dir2_trace.h" | 40 | #include "xfs_trace.h" |
| 41 | 41 | ||
| 42 | /* | 42 | /* |
| 43 | * Prototypes for internal functions. | 43 | * Prototypes for internal functions. |
| @@ -169,7 +169,8 @@ xfs_dir2_block_to_sf( | |||
| 169 | xfs_dir2_sf_t *sfp; /* shortform structure */ | 169 | xfs_dir2_sf_t *sfp; /* shortform structure */ |
| 170 | xfs_ino_t temp; | 170 | xfs_ino_t temp; |
| 171 | 171 | ||
| 172 | xfs_dir2_trace_args_sb("block_to_sf", args, size, bp); | 172 | trace_xfs_dir2_block_to_sf(args); |
| 173 | |||
| 173 | dp = args->dp; | 174 | dp = args->dp; |
| 174 | mp = dp->i_mount; | 175 | mp = dp->i_mount; |
| 175 | 176 | ||
| @@ -281,7 +282,8 @@ xfs_dir2_sf_addname( | |||
| 281 | xfs_dir2_sf_t *sfp; /* shortform structure */ | 282 | xfs_dir2_sf_t *sfp; /* shortform structure */ |
| 282 | xfs_dir2_sf_entry_t *sfep = NULL; /* shortform entry */ | 283 | xfs_dir2_sf_entry_t *sfep = NULL; /* shortform entry */ |
| 283 | 284 | ||
| 284 | xfs_dir2_trace_args("sf_addname", args); | 285 | trace_xfs_dir2_sf_addname(args); |
| 286 | |||
| 285 | ASSERT(xfs_dir2_sf_lookup(args) == ENOENT); | 287 | ASSERT(xfs_dir2_sf_lookup(args) == ENOENT); |
| 286 | dp = args->dp; | 288 | dp = args->dp; |
| 287 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); | 289 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); |
| @@ -654,7 +656,8 @@ xfs_dir2_sf_create( | |||
| 654 | xfs_dir2_sf_t *sfp; /* shortform structure */ | 656 | xfs_dir2_sf_t *sfp; /* shortform structure */ |
| 655 | int size; /* directory size */ | 657 | int size; /* directory size */ |
| 656 | 658 | ||
| 657 | xfs_dir2_trace_args_i("sf_create", args, pino); | 659 | trace_xfs_dir2_sf_create(args); |
| 660 | |||
| 658 | dp = args->dp; | 661 | dp = args->dp; |
| 659 | 662 | ||
| 660 | ASSERT(dp != NULL); | 663 | ASSERT(dp != NULL); |
| @@ -808,7 +811,8 @@ xfs_dir2_sf_lookup( | |||
| 808 | enum xfs_dacmp cmp; /* comparison result */ | 811 | enum xfs_dacmp cmp; /* comparison result */ |
| 809 | xfs_dir2_sf_entry_t *ci_sfep; /* case-insens. entry */ | 812 | xfs_dir2_sf_entry_t *ci_sfep; /* case-insens. entry */ |
| 810 | 813 | ||
| 811 | xfs_dir2_trace_args("sf_lookup", args); | 814 | trace_xfs_dir2_sf_lookup(args); |
| 815 | |||
| 812 | xfs_dir2_sf_check(args); | 816 | xfs_dir2_sf_check(args); |
| 813 | dp = args->dp; | 817 | dp = args->dp; |
| 814 | 818 | ||
| @@ -891,7 +895,8 @@ xfs_dir2_sf_removename( | |||
| 891 | xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ | 895 | xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ |
| 892 | xfs_dir2_sf_t *sfp; /* shortform structure */ | 896 | xfs_dir2_sf_t *sfp; /* shortform structure */ |
| 893 | 897 | ||
| 894 | xfs_dir2_trace_args("sf_removename", args); | 898 | trace_xfs_dir2_sf_removename(args); |
| 899 | |||
| 895 | dp = args->dp; | 900 | dp = args->dp; |
| 896 | 901 | ||
| 897 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); | 902 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); |
| @@ -982,7 +987,8 @@ xfs_dir2_sf_replace( | |||
| 982 | xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ | 987 | xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ |
| 983 | xfs_dir2_sf_t *sfp; /* shortform structure */ | 988 | xfs_dir2_sf_t *sfp; /* shortform structure */ |
| 984 | 989 | ||
| 985 | xfs_dir2_trace_args("sf_replace", args); | 990 | trace_xfs_dir2_sf_replace(args); |
| 991 | |||
| 986 | dp = args->dp; | 992 | dp = args->dp; |
| 987 | 993 | ||
| 988 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); | 994 | ASSERT(dp->i_df.if_flags & XFS_IFINLINE); |
| @@ -1125,7 +1131,8 @@ xfs_dir2_sf_toino4( | |||
| 1125 | xfs_dir2_sf_entry_t *sfep; /* new sf entry */ | 1131 | xfs_dir2_sf_entry_t *sfep; /* new sf entry */ |
| 1126 | xfs_dir2_sf_t *sfp; /* new sf directory */ | 1132 | xfs_dir2_sf_t *sfp; /* new sf directory */ |
| 1127 | 1133 | ||
| 1128 | xfs_dir2_trace_args("sf_toino4", args); | 1134 | trace_xfs_dir2_sf_toino4(args); |
| 1135 | |||
| 1129 | dp = args->dp; | 1136 | dp = args->dp; |
| 1130 | 1137 | ||
| 1131 | /* | 1138 | /* |
| @@ -1202,7 +1209,8 @@ xfs_dir2_sf_toino8( | |||
| 1202 | xfs_dir2_sf_entry_t *sfep; /* new sf entry */ | 1209 | xfs_dir2_sf_entry_t *sfep; /* new sf entry */ |
| 1203 | xfs_dir2_sf_t *sfp; /* new sf directory */ | 1210 | xfs_dir2_sf_t *sfp; /* new sf directory */ |
| 1204 | 1211 | ||
| 1205 | xfs_dir2_trace_args("sf_toino8", args); | 1212 | trace_xfs_dir2_sf_toino8(args); |
| 1213 | |||
| 1206 | dp = args->dp; | 1214 | dp = args->dp; |
| 1207 | 1215 | ||
| 1208 | /* | 1216 | /* |
diff --git a/fs/xfs/xfs_dir2_trace.c b/fs/xfs/xfs_dir2_trace.c deleted file mode 100644 index 6cc7c0c681ac..000000000000 --- a/fs/xfs/xfs_dir2_trace.c +++ /dev/null | |||
| @@ -1,216 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2000-2003,2005 Silicon Graphics, Inc. | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #include "xfs.h" | ||
| 19 | #include "xfs_fs.h" | ||
| 20 | #include "xfs_types.h" | ||
| 21 | #include "xfs_inum.h" | ||
| 22 | #include "xfs_dir2.h" | ||
| 23 | #include "xfs_da_btree.h" | ||
| 24 | #include "xfs_bmap_btree.h" | ||
| 25 | #include "xfs_dir2_sf.h" | ||
| 26 | #include "xfs_attr_sf.h" | ||
| 27 | #include "xfs_dinode.h" | ||
| 28 | #include "xfs_inode.h" | ||
| 29 | #include "xfs_dir2_trace.h" | ||
| 30 | |||
| 31 | #ifdef XFS_DIR2_TRACE | ||
| 32 | ktrace_t *xfs_dir2_trace_buf; | ||
| 33 | |||
| 34 | /* | ||
| 35 | * Enter something in the trace buffers. | ||
| 36 | */ | ||
| 37 | static void | ||
| 38 | xfs_dir2_trace_enter( | ||
| 39 | xfs_inode_t *dp, | ||
| 40 | int type, | ||
| 41 | char *where, | ||
| 42 | char *name, | ||
| 43 | int namelen, | ||
| 44 | void *a0, | ||
| 45 | void *a1, | ||
| 46 | void *a2, | ||
| 47 | void *a3, | ||
| 48 | void *a4, | ||
| 49 | void *a5, | ||
| 50 | void *a6, | ||
| 51 | void *a7) | ||
| 52 | { | ||
| 53 | void *n[5]; | ||
| 54 | |||
| 55 | ASSERT(xfs_dir2_trace_buf); | ||
| 56 | ASSERT(dp->i_dir_trace); | ||
| 57 | if (name) | ||
| 58 | memcpy(n, name, min((int)sizeof(n), namelen)); | ||
| 59 | else | ||
| 60 | memset((char *)n, 0, sizeof(n)); | ||
| 61 | ktrace_enter(xfs_dir2_trace_buf, | ||
| 62 | (void *)(long)type, (void *)where, | ||
| 63 | (void *)a0, (void *)a1, (void *)a2, (void *)a3, | ||
| 64 | (void *)a4, (void *)a5, (void *)a6, (void *)a7, | ||
| 65 | (void *)(long)namelen, | ||
| 66 | (void *)n[0], (void *)n[1], (void *)n[2], | ||
| 67 | (void *)n[3], (void *)n[4]); | ||
| 68 | ktrace_enter(dp->i_dir_trace, | ||
| 69 | (void *)(long)type, (void *)where, | ||
| 70 | (void *)a0, (void *)a1, (void *)a2, (void *)a3, | ||
| 71 | (void *)a4, (void *)a5, (void *)a6, (void *)a7, | ||
| 72 | (void *)(long)namelen, | ||
| 73 | (void *)n[0], (void *)n[1], (void *)n[2], | ||
| 74 | (void *)n[3], (void *)n[4]); | ||
| 75 | } | ||
| 76 | |||
| 77 | void | ||
| 78 | xfs_dir2_trace_args( | ||
| 79 | char *where, | ||
| 80 | xfs_da_args_t *args) | ||
| 81 | { | ||
| 82 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS, where, | ||
| 83 | (char *)args->name, (int)args->namelen, | ||
| 84 | (void *)(unsigned long)args->hashval, | ||
| 85 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 86 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 87 | (void *)args->dp, (void *)args->trans, | ||
| 88 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 89 | NULL, NULL); | ||
| 90 | } | ||
| 91 | |||
| 92 | void | ||
| 93 | xfs_dir2_trace_args_b( | ||
| 94 | char *where, | ||
| 95 | xfs_da_args_t *args, | ||
| 96 | xfs_dabuf_t *bp) | ||
| 97 | { | ||
| 98 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_B, where, | ||
| 99 | (char *)args->name, (int)args->namelen, | ||
| 100 | (void *)(unsigned long)args->hashval, | ||
| 101 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 102 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 103 | (void *)args->dp, (void *)args->trans, | ||
| 104 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 105 | (void *)(bp ? bp->bps[0] : NULL), NULL); | ||
| 106 | } | ||
| 107 | |||
| 108 | void | ||
| 109 | xfs_dir2_trace_args_bb( | ||
| 110 | char *where, | ||
| 111 | xfs_da_args_t *args, | ||
| 112 | xfs_dabuf_t *lbp, | ||
| 113 | xfs_dabuf_t *dbp) | ||
| 114 | { | ||
| 115 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_BB, where, | ||
| 116 | (char *)args->name, (int)args->namelen, | ||
| 117 | (void *)(unsigned long)args->hashval, | ||
| 118 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 119 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 120 | (void *)args->dp, (void *)args->trans, | ||
| 121 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 122 | (void *)(lbp ? lbp->bps[0] : NULL), | ||
| 123 | (void *)(dbp ? dbp->bps[0] : NULL)); | ||
| 124 | } | ||
| 125 | |||
| 126 | void | ||
| 127 | xfs_dir2_trace_args_bibii( | ||
| 128 | char *where, | ||
| 129 | xfs_da_args_t *args, | ||
| 130 | xfs_dabuf_t *bs, | ||
| 131 | int ss, | ||
| 132 | xfs_dabuf_t *bd, | ||
| 133 | int sd, | ||
| 134 | int c) | ||
| 135 | { | ||
| 136 | xfs_buf_t *bpbs = bs ? bs->bps[0] : NULL; | ||
| 137 | xfs_buf_t *bpbd = bd ? bd->bps[0] : NULL; | ||
| 138 | |||
| 139 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_BIBII, where, | ||
| 140 | (char *)args->name, (int)args->namelen, | ||
| 141 | (void *)args->dp, (void *)args->trans, | ||
| 142 | (void *)bpbs, (void *)(long)ss, (void *)bpbd, (void *)(long)sd, | ||
| 143 | (void *)(long)c, NULL); | ||
| 144 | } | ||
| 145 | |||
| 146 | void | ||
| 147 | xfs_dir2_trace_args_db( | ||
| 148 | char *where, | ||
| 149 | xfs_da_args_t *args, | ||
| 150 | xfs_dir2_db_t db, | ||
| 151 | xfs_dabuf_t *bp) | ||
| 152 | { | ||
| 153 | xfs_buf_t *dbp = bp ? bp->bps[0] : NULL; | ||
| 154 | |||
| 155 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_DB, where, | ||
| 156 | (char *)args->name, (int)args->namelen, | ||
| 157 | (void *)(unsigned long)args->hashval, | ||
| 158 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 159 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 160 | (void *)args->dp, (void *)args->trans, | ||
| 161 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 162 | (void *)(long)db, (void *)dbp); | ||
| 163 | } | ||
| 164 | |||
| 165 | void | ||
| 166 | xfs_dir2_trace_args_i( | ||
| 167 | char *where, | ||
| 168 | xfs_da_args_t *args, | ||
| 169 | xfs_ino_t i) | ||
| 170 | { | ||
| 171 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_I, where, | ||
| 172 | (char *)args->name, (int)args->namelen, | ||
| 173 | (void *)(unsigned long)args->hashval, | ||
| 174 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 175 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 176 | (void *)args->dp, (void *)args->trans, | ||
| 177 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 178 | (void *)((unsigned long)(i >> 32)), | ||
| 179 | (void *)((unsigned long)(i & 0xFFFFFFFF))); | ||
| 180 | } | ||
| 181 | |||
| 182 | void | ||
| 183 | xfs_dir2_trace_args_s( | ||
| 184 | char *where, | ||
| 185 | xfs_da_args_t *args, | ||
| 186 | int s) | ||
| 187 | { | ||
| 188 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_S, where, | ||
| 189 | (char *)args->name, (int)args->namelen, | ||
| 190 | (void *)(unsigned long)args->hashval, | ||
| 191 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 192 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 193 | (void *)args->dp, (void *)args->trans, | ||
| 194 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 195 | (void *)(long)s, NULL); | ||
| 196 | } | ||
| 197 | |||
| 198 | void | ||
| 199 | xfs_dir2_trace_args_sb( | ||
| 200 | char *where, | ||
| 201 | xfs_da_args_t *args, | ||
| 202 | int s, | ||
| 203 | xfs_dabuf_t *bp) | ||
| 204 | { | ||
| 205 | xfs_buf_t *dbp = bp ? bp->bps[0] : NULL; | ||
| 206 | |||
| 207 | xfs_dir2_trace_enter(args->dp, XFS_DIR2_KTRACE_ARGS_SB, where, | ||
| 208 | (char *)args->name, (int)args->namelen, | ||
| 209 | (void *)(unsigned long)args->hashval, | ||
| 210 | (void *)((unsigned long)(args->inumber >> 32)), | ||
| 211 | (void *)((unsigned long)(args->inumber & 0xFFFFFFFF)), | ||
| 212 | (void *)args->dp, (void *)args->trans, | ||
| 213 | (void *)(unsigned long)(args->op_flags & XFS_DA_OP_JUSTCHECK), | ||
| 214 | (void *)(long)s, (void *)dbp); | ||
| 215 | } | ||
| 216 | #endif /* XFS_DIR2_TRACE */ | ||
diff --git a/fs/xfs/xfs_dir2_trace.h b/fs/xfs/xfs_dir2_trace.h deleted file mode 100644 index ca3c754f4822..000000000000 --- a/fs/xfs/xfs_dir2_trace.h +++ /dev/null | |||
| @@ -1,72 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * Copyright (c) 2000,2005 Silicon Graphics, Inc. | ||
| 3 | * All Rights Reserved. | ||
| 4 | * | ||
| 5 | * This program is free software; you can redistribute it and/or | ||
| 6 | * modify it under the terms of the GNU General Public License as | ||
| 7 | * published by the Free Software Foundation. | ||
| 8 | * | ||
| 9 | * This program is distributed in the hope that it would be useful, | ||
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 12 | * GNU General Public License for more details. | ||
| 13 | * | ||
| 14 | * You should have received a copy of the GNU General Public License | ||
| 15 | * along with this program; if not, write the Free Software Foundation, | ||
| 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| 17 | */ | ||
| 18 | #ifndef __XFS_DIR2_TRACE_H__ | ||
| 19 | #define __XFS_DIR2_TRACE_H__ | ||
| 20 | |||
| 21 | /* | ||
| 22 | * Tracing for xfs v2 directories. | ||
| 23 | */ | ||
| 24 | |||
| 25 | #if defined(XFS_DIR2_TRACE) | ||
| 26 | |||
| 27 | struct ktrace; | ||
| 28 | struct xfs_dabuf; | ||
| 29 | struct xfs_da_args; | ||
| 30 | |||
| 31 | #define XFS_DIR2_GTRACE_SIZE 4096 /* global buffer */ | ||
| 32 | #define XFS_DIR2_KTRACE_SIZE 32 /* per-inode buffer */ | ||
| 33 | extern struct ktrace *xfs_dir2_trace_buf; | ||
| 34 | |||
| 35 | #define XFS_DIR2_KTRACE_ARGS 1 /* args only */ | ||
| 36 | #define XFS_DIR2_KTRACE_ARGS_B 2 /* args + buffer */ | ||
| 37 | #define XFS_DIR2_KTRACE_ARGS_BB 3 /* args + 2 buffers */ | ||
| 38 | #define XFS_DIR2_KTRACE_ARGS_DB 4 /* args, db, buffer */ | ||
| 39 | #define XFS_DIR2_KTRACE_ARGS_I 5 /* args, inum */ | ||
| 40 | #define XFS_DIR2_KTRACE_ARGS_S 6 /* args, int */ | ||
| 41 | #define XFS_DIR2_KTRACE_ARGS_SB 7 /* args, int, buffer */ | ||
| 42 | #define XFS_DIR2_KTRACE_ARGS_BIBII 8 /* args, buf/int/buf/int/int */ | ||
| 43 | |||
| 44 | void xfs_dir2_trace_args(char *where, struct xfs_da_args *args); | ||
| 45 | void xfs_dir2_trace_args_b(char *where, struct xfs_da_args *args, | ||
| 46 | struct xfs_dabuf *bp); | ||
| 47 | void xfs_dir2_trace_args_bb(char *where, struct xfs_da_args *args, | ||
| 48 | struct xfs_dabuf *lbp, struct xfs_dabuf *dbp); | ||
| 49 | void xfs_dir2_trace_args_bibii(char *where, struct xfs_da_args *args, | ||
| 50 | struct xfs_dabuf *bs, int ss, | ||
| 51 | struct xfs_dabuf *bd, int sd, int c); | ||
| 52 | void xfs_dir2_trace_args_db(char *where, struct xfs_da_args *args, | ||
| 53 | xfs_dir2_db_t db, struct xfs_dabuf *bp); | ||
| 54 | void xfs_dir2_trace_args_i(char *where, struct xfs_da_args *args, xfs_ino_t i); | ||
| 55 | void xfs_dir2_trace_args_s(char *where, struct xfs_da_args *args, int s); | ||
| 56 | void xfs_dir2_trace_args_sb(char *where, struct xfs_da_args *args, int s, | ||
| 57 | struct xfs_dabuf *bp); | ||
| 58 | |||
| 59 | #else /* XFS_DIR2_TRACE */ | ||
| 60 | |||
| 61 | #define xfs_dir2_trace_args(where, args) | ||
| 62 | #define xfs_dir2_trace_args_b(where, args, bp) | ||
| 63 | #define xfs_dir2_trace_args_bb(where, args, lbp, dbp) | ||
| 64 | #define xfs_dir2_trace_args_bibii(where, args, bs, ss, bd, sd, c) | ||
| 65 | #define xfs_dir2_trace_args_db(where, args, db, bp) | ||
| 66 | #define xfs_dir2_trace_args_i(where, args, i) | ||
| 67 | #define xfs_dir2_trace_args_s(where, args, s) | ||
| 68 | #define xfs_dir2_trace_args_sb(where, args, s, bp) | ||
| 69 | |||
| 70 | #endif /* XFS_DIR2_TRACE */ | ||
| 71 | |||
| 72 | #endif /* __XFS_DIR2_TRACE_H__ */ | ||
diff --git a/fs/xfs/xfs_filestream.c b/fs/xfs/xfs_filestream.c index edf8bdf4141f..a631e1451abb 100644 --- a/fs/xfs/xfs_filestream.c +++ b/fs/xfs/xfs_filestream.c | |||
| @@ -34,6 +34,7 @@ | |||
| 34 | #include "xfs_utils.h" | 34 | #include "xfs_utils.h" |
| 35 | #include "xfs_mru_cache.h" | 35 | #include "xfs_mru_cache.h" |
| 36 | #include "xfs_filestream.h" | 36 | #include "xfs_filestream.h" |
| 37 | #include "xfs_trace.h" | ||
| 37 | 38 | ||
| 38 | #ifdef XFS_FILESTREAMS_TRACE | 39 | #ifdef XFS_FILESTREAMS_TRACE |
| 39 | 40 | ||
| @@ -394,9 +395,7 @@ xfs_filestream_init(void) | |||
| 394 | item_zone = kmem_zone_init(sizeof(fstrm_item_t), "fstrm_item"); | 395 | item_zone = kmem_zone_init(sizeof(fstrm_item_t), "fstrm_item"); |
| 395 | if (!item_zone) | 396 | if (!item_zone) |
| 396 | return -ENOMEM; | 397 | return -ENOMEM; |
| 397 | #ifdef XFS_FILESTREAMS_TRACE | 398 | |
| 398 | xfs_filestreams_trace_buf = ktrace_alloc(XFS_FSTRM_KTRACE_SIZE, KM_NOFS); | ||
| 399 | #endif | ||
| 400 | return 0; | 399 | return 0; |
| 401 | } | 400 | } |
| 402 | 401 | ||
| @@ -407,9 +406,6 @@ xfs_filestream_init(void) | |||
| 407 | void | 406 | void |
| 408 | xfs_filestream_uninit(void) | 407 | xfs_filestream_uninit(void) |
| 409 | { | 408 | { |
| 410 | #ifdef XFS_FILESTREAMS_TRACE | ||
| 411 | ktrace_free(xfs_filestreams_trace_buf); | ||
| 412 | #endif | ||
| 413 | kmem_zone_destroy(item_zone); | 409 | kmem_zone_destroy(item_zone); |
| 414 | } | 410 | } |
| 415 | 411 | ||
diff --git a/fs/xfs/xfs_filestream.h b/fs/xfs/xfs_filestream.h index f655f7dc334c..4aba67c5f64f 100644 --- a/fs/xfs/xfs_filestream.h +++ b/fs/xfs/xfs_filestream.h | |||
| @@ -79,7 +79,7 @@ extern ktrace_t *xfs_filestreams_trace_buf; | |||
| 79 | * the cache that reference per-ag array elements that have since been | 79 | * the cache that reference per-ag array elements that have since been |
| 80 | * reallocated. | 80 | * reallocated. |
| 81 | */ | 81 | */ |
| 82 | STATIC_INLINE int | 82 | static inline int |
| 83 | xfs_filestream_peek_ag( | 83 | xfs_filestream_peek_ag( |
| 84 | xfs_mount_t *mp, | 84 | xfs_mount_t *mp, |
| 85 | xfs_agnumber_t agno) | 85 | xfs_agnumber_t agno) |
| @@ -87,7 +87,7 @@ xfs_filestream_peek_ag( | |||
| 87 | return atomic_read(&mp->m_perag[agno].pagf_fstrms); | 87 | return atomic_read(&mp->m_perag[agno].pagf_fstrms); |
| 88 | } | 88 | } |
| 89 | 89 | ||
| 90 | STATIC_INLINE int | 90 | static inline int |
| 91 | xfs_filestream_get_ag( | 91 | xfs_filestream_get_ag( |
| 92 | xfs_mount_t *mp, | 92 | xfs_mount_t *mp, |
| 93 | xfs_agnumber_t agno) | 93 | xfs_agnumber_t agno) |
| @@ -95,7 +95,7 @@ xfs_filestream_get_ag( | |||
| 95 | return atomic_inc_return(&mp->m_perag[agno].pagf_fstrms); | 95 | return atomic_inc_return(&mp->m_perag[agno].pagf_fstrms); |
| 96 | } | 96 | } |
| 97 | 97 | ||
| 98 | STATIC_INLINE int | 98 | static inline int |
| 99 | xfs_filestream_put_ag( | 99 | xfs_filestream_put_ag( |
| 100 | xfs_mount_t *mp, | 100 | xfs_mount_t *mp, |
| 101 | xfs_agnumber_t agno) | 101 | xfs_agnumber_t agno) |
| @@ -122,7 +122,7 @@ int xfs_filestream_new_ag(struct xfs_bmalloca *ap, xfs_agnumber_t *agp); | |||
| 122 | 122 | ||
| 123 | 123 | ||
| 124 | /* filestreams for the inode? */ | 124 | /* filestreams for the inode? */ |
| 125 | STATIC_INLINE int | 125 | static inline int |
| 126 | xfs_inode_is_filestream( | 126 | xfs_inode_is_filestream( |
| 127 | struct xfs_inode *ip) | 127 | struct xfs_inode *ip) |
| 128 | { | 128 | { |
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c index 2d0b3e1da9e6..a13919a6a364 100644 --- a/fs/xfs/xfs_fsops.c +++ b/fs/xfs/xfs_fsops.c | |||
| @@ -45,6 +45,7 @@ | |||
| 45 | #include "xfs_rtalloc.h" | 45 | #include "xfs_rtalloc.h" |
| 46 | #include "xfs_rw.h" | 46 | #include "xfs_rw.h" |
| 47 | #include "xfs_filestream.h" | 47 | #include "xfs_filestream.h" |
| 48 | #include "xfs_trace.h" | ||
| 48 | 49 | ||
| 49 | /* | 50 | /* |
| 50 | * File system operations | 51 | * File system operations |
| @@ -201,8 +202,8 @@ xfs_growfs_data_private( | |||
| 201 | * AG freelist header block | 202 | * AG freelist header block |
| 202 | */ | 203 | */ |
| 203 | bp = xfs_buf_get(mp->m_ddev_targp, | 204 | bp = xfs_buf_get(mp->m_ddev_targp, |
| 204 | XFS_AG_DADDR(mp, agno, XFS_AGF_DADDR(mp)), | 205 | XFS_AG_DADDR(mp, agno, XFS_AGF_DADDR(mp)), |
| 205 | XFS_FSS_TO_BB(mp, 1), 0); | 206 | XFS_FSS_TO_BB(mp, 1), XBF_LOCK | XBF_MAPPED); |
| 206 | agf = XFS_BUF_TO_AGF(bp); | 207 | agf = XFS_BUF_TO_AGF(bp); |
| 207 | memset(agf, 0, mp->m_sb.sb_sectsize); | 208 | memset(agf, 0, mp->m_sb.sb_sectsize); |
| 208 | agf->agf_magicnum = cpu_to_be32(XFS_AGF_MAGIC); | 209 | agf->agf_magicnum = cpu_to_be32(XFS_AGF_MAGIC); |
| @@ -233,8 +234,8 @@ xfs_growfs_data_private( | |||
| 233 | * AG inode header block | 234 | * AG inode header block |
| 234 | */ | 235 | */ |
| 235 | bp = xfs_buf_get(mp->m_ddev_targp, | 236 | bp = xfs_buf_get(mp->m_ddev_targp, |
| 236 | XFS_AG_DADDR(mp, agno, XFS_AGI_DADDR(mp)), | 237 | XFS_AG_DADDR(mp, agno, XFS_AGI_DADDR(mp)), |
| 237 | XFS_FSS_TO_BB(mp, 1), 0); | 238 | XFS_FSS_TO_BB(mp, 1), XBF_LOCK | XBF_MAPPED); |
| 238 | agi = XFS_BUF_TO_AGI(bp); | 239 | agi = XFS_BUF_TO_AGI(bp); |
| 239 | memset(agi, 0, mp->m_sb.sb_sectsize); | 240 | memset(agi, 0, mp->m_sb.sb_sectsize); |
| 240 | agi->agi_magicnum = cpu_to_be32(XFS_AGI_MAGIC); | 241 | agi->agi_magicnum = cpu_to_be32(XFS_AGI_MAGIC); |
| @@ -257,8 +258,9 @@ xfs_growfs_data_private( | |||
| 257 | * BNO btree root block | 258 | * BNO btree root block |
| 258 | */ | 259 | */ |
| 259 | bp = xfs_buf_get(mp->m_ddev_targp, | 260 | bp = xfs_buf_get(mp->m_ddev_targp, |
| 260 | XFS_AGB_TO_DADDR(mp, agno, XFS_BNO_BLOCK(mp)), | 261 | XFS_AGB_TO_DADDR(mp, agno, XFS_BNO_BLOCK(mp)), |
| 261 | BTOBB(mp->m_sb.sb_blocksize), 0); | 262 | BTOBB(mp->m_sb.sb_blocksize), |
| 263 | XBF_LOCK | XBF_MAPPED); | ||
| 262 | block = XFS_BUF_TO_BLOCK(bp); | 264 | block = XFS_BUF_TO_BLOCK(bp); |
| 263 | memset(block, 0, mp->m_sb.sb_blocksize); | 265 | memset(block, 0, mp->m_sb.sb_blocksize); |
| 264 | block->bb_magic = cpu_to_be32(XFS_ABTB_MAGIC); | 266 | block->bb_magic = cpu_to_be32(XFS_ABTB_MAGIC); |
| @@ -278,8 +280,9 @@ xfs_growfs_data_private( | |||
| 278 | * CNT btree root block | 280 | * CNT btree root block |
| 279 | */ | 281 | */ |
| 280 | bp = xfs_buf_get(mp->m_ddev_targp, | 282 | bp = xfs_buf_get(mp->m_ddev_targp, |
| 281 | XFS_AGB_TO_DADDR(mp, agno, XFS_CNT_BLOCK(mp)), | 283 | XFS_AGB_TO_DADDR(mp, agno, XFS_CNT_BLOCK(mp)), |
| 282 | BTOBB(mp->m_sb.sb_blocksize), 0); | 284 | BTOBB(mp->m_sb.sb_blocksize), |
| 285 | XBF_LOCK | XBF_MAPPED); | ||
| 283 | block = XFS_BUF_TO_BLOCK(bp); | 286 | block = XFS_BUF_TO_BLOCK(bp); |
| 284 | memset(block, 0, mp->m_sb.sb_blocksize); | 287 | memset(block, 0, mp->m_sb.sb_blocksize); |
| 285 | block->bb_magic = cpu_to_be32(XFS_ABTC_MAGIC); | 288 | block->bb_magic = cpu_to_be32(XFS_ABTC_MAGIC); |
| @@ -300,8 +303,9 @@ xfs_growfs_data_private( | |||
| 300 | * INO btree root block | 303 | * INO btree root block |
| 301 | */ | 304 | */ |
| 302 | bp = xfs_buf_get(mp->m_ddev_targp, | 305 | bp = xfs_buf_get(mp->m_ddev_targp, |
| 303 | XFS_AGB_TO_DADDR(mp, agno, XFS_IBT_BLOCK(mp)), | 306 | XFS_AGB_TO_DADDR(mp, agno, XFS_IBT_BLOCK(mp)), |
| 304 | BTOBB(mp->m_sb.sb_blocksize), 0); | 307 | BTOBB(mp->m_sb.sb_blocksize), |
| 308 | XBF_LOCK | XBF_MAPPED); | ||
| 305 | block = XFS_BUF_TO_BLOCK(bp); | 309 | block = XFS_BUF_TO_BLOCK(bp); |
| 306 | memset(block, 0, mp->m_sb.sb_blocksize); | 310 | memset(block, 0, mp->m_sb.sb_blocksize); |
| 307 | block->bb_magic = cpu_to_be32(XFS_IBT_MAGIC); | 311 | block->bb_magic = cpu_to_be32(XFS_IBT_MAGIC); |
| @@ -344,6 +348,7 @@ xfs_growfs_data_private( | |||
| 344 | be32_add_cpu(&agf->agf_length, new); | 348 | be32_add_cpu(&agf->agf_length, new); |
| 345 | ASSERT(be32_to_cpu(agf->agf_length) == | 349 | ASSERT(be32_to_cpu(agf->agf_length) == |
| 346 | be32_to_cpu(agi->agi_length)); | 350 | be32_to_cpu(agi->agi_length)); |
| 351 | |||
| 347 | xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH); | 352 | xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH); |
| 348 | /* | 353 | /* |
| 349 | * Free the new space. | 354 | * Free the new space. |
| @@ -611,7 +616,7 @@ xfs_fs_log_dummy( | |||
| 611 | xfs_inode_t *ip; | 616 | xfs_inode_t *ip; |
| 612 | int error; | 617 | int error; |
| 613 | 618 | ||
| 614 | tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1); | 619 | tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1, KM_SLEEP); |
| 615 | error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); | 620 | error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); |
| 616 | if (error) { | 621 | if (error) { |
| 617 | xfs_trans_cancel(tp, 0); | 622 | xfs_trans_cancel(tp, 0); |
diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c index 0785797db828..cb907ba69c4c 100644 --- a/fs/xfs/xfs_ialloc.c +++ b/fs/xfs/xfs_ialloc.c | |||
| @@ -425,7 +425,7 @@ xfs_ialloc_ag_alloc( | |||
| 425 | return 0; | 425 | return 0; |
| 426 | } | 426 | } |
| 427 | 427 | ||
| 428 | STATIC_INLINE xfs_agnumber_t | 428 | STATIC xfs_agnumber_t |
| 429 | xfs_ialloc_next_ag( | 429 | xfs_ialloc_next_ag( |
| 430 | xfs_mount_t *mp) | 430 | xfs_mount_t *mp) |
| 431 | { | 431 | { |
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c index 80e526489be5..f5c904a10c11 100644 --- a/fs/xfs/xfs_iget.c +++ b/fs/xfs/xfs_iget.c | |||
| @@ -43,7 +43,7 @@ | |||
| 43 | #include "xfs_inode_item.h" | 43 | #include "xfs_inode_item.h" |
| 44 | #include "xfs_bmap.h" | 44 | #include "xfs_bmap.h" |
| 45 | #include "xfs_btree_trace.h" | 45 | #include "xfs_btree_trace.h" |
| 46 | #include "xfs_dir2_trace.h" | 46 | #include "xfs_trace.h" |
| 47 | 47 | ||
| 48 | 48 | ||
| 49 | /* | 49 | /* |
| @@ -73,6 +73,9 @@ xfs_inode_alloc( | |||
| 73 | ASSERT(atomic_read(&ip->i_pincount) == 0); | 73 | ASSERT(atomic_read(&ip->i_pincount) == 0); |
| 74 | ASSERT(!spin_is_locked(&ip->i_flags_lock)); | 74 | ASSERT(!spin_is_locked(&ip->i_flags_lock)); |
| 75 | ASSERT(completion_done(&ip->i_flush)); | 75 | ASSERT(completion_done(&ip->i_flush)); |
| 76 | ASSERT(!rwsem_is_locked(&ip->i_iolock.mr_lock)); | ||
| 77 | |||
| 78 | mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino); | ||
| 76 | 79 | ||
| 77 | /* initialise the xfs inode */ | 80 | /* initialise the xfs inode */ |
| 78 | ip->i_ino = ino; | 81 | ip->i_ino = ino; |
| @@ -87,28 +90,6 @@ xfs_inode_alloc( | |||
| 87 | ip->i_size = 0; | 90 | ip->i_size = 0; |
| 88 | ip->i_new_size = 0; | 91 | ip->i_new_size = 0; |
| 89 | 92 | ||
| 90 | /* | ||
| 91 | * Initialize inode's trace buffers. | ||
| 92 | */ | ||
| 93 | #ifdef XFS_INODE_TRACE | ||
| 94 | ip->i_trace = ktrace_alloc(INODE_TRACE_SIZE, KM_NOFS); | ||
| 95 | #endif | ||
| 96 | #ifdef XFS_BMAP_TRACE | ||
| 97 | ip->i_xtrace = ktrace_alloc(XFS_BMAP_KTRACE_SIZE, KM_NOFS); | ||
| 98 | #endif | ||
| 99 | #ifdef XFS_BTREE_TRACE | ||
| 100 | ip->i_btrace = ktrace_alloc(XFS_BMBT_KTRACE_SIZE, KM_NOFS); | ||
| 101 | #endif | ||
| 102 | #ifdef XFS_RW_TRACE | ||
| 103 | ip->i_rwtrace = ktrace_alloc(XFS_RW_KTRACE_SIZE, KM_NOFS); | ||
| 104 | #endif | ||
| 105 | #ifdef XFS_ILOCK_TRACE | ||
| 106 | ip->i_lock_trace = ktrace_alloc(XFS_ILOCK_KTRACE_SIZE, KM_NOFS); | ||
| 107 | #endif | ||
| 108 | #ifdef XFS_DIR2_TRACE | ||
| 109 | ip->i_dir_trace = ktrace_alloc(XFS_DIR2_KTRACE_SIZE, KM_NOFS); | ||
| 110 | #endif | ||
| 111 | |||
| 112 | /* prevent anyone from using this yet */ | 93 | /* prevent anyone from using this yet */ |
| 113 | VFS_I(ip)->i_state = I_NEW|I_LOCK; | 94 | VFS_I(ip)->i_state = I_NEW|I_LOCK; |
| 114 | 95 | ||
| @@ -130,25 +111,6 @@ xfs_inode_free( | |||
| 130 | if (ip->i_afp) | 111 | if (ip->i_afp) |
| 131 | xfs_idestroy_fork(ip, XFS_ATTR_FORK); | 112 | xfs_idestroy_fork(ip, XFS_ATTR_FORK); |
| 132 | 113 | ||
| 133 | #ifdef XFS_INODE_TRACE | ||
| 134 | ktrace_free(ip->i_trace); | ||
| 135 | #endif | ||
| 136 | #ifdef XFS_BMAP_TRACE | ||
| 137 | ktrace_free(ip->i_xtrace); | ||
| 138 | #endif | ||
| 139 | #ifdef XFS_BTREE_TRACE | ||
| 140 | ktrace_free(ip->i_btrace); | ||
| 141 | #endif | ||
| 142 | #ifdef XFS_RW_TRACE | ||
| 143 | ktrace_free(ip->i_rwtrace); | ||
| 144 | #endif | ||
| 145 | #ifdef XFS_ILOCK_TRACE | ||
| 146 | ktrace_free(ip->i_lock_trace); | ||
| 147 | #endif | ||
| 148 | #ifdef XFS_DIR2_TRACE | ||
| 149 | ktrace_free(ip->i_dir_trace); | ||
| 150 | #endif | ||
| 151 | |||
| 152 | if (ip->i_itemp) { | 114 | if (ip->i_itemp) { |
| 153 | /* | 115 | /* |
| 154 | * Only if we are shutting down the fs will we see an | 116 | * Only if we are shutting down the fs will we see an |
| @@ -207,6 +169,7 @@ xfs_iget_cache_hit( | |||
| 207 | * instead of polling for it. | 169 | * instead of polling for it. |
| 208 | */ | 170 | */ |
| 209 | if (ip->i_flags & (XFS_INEW|XFS_IRECLAIM)) { | 171 | if (ip->i_flags & (XFS_INEW|XFS_IRECLAIM)) { |
| 172 | trace_xfs_iget_skip(ip); | ||
| 210 | XFS_STATS_INC(xs_ig_frecycle); | 173 | XFS_STATS_INC(xs_ig_frecycle); |
| 211 | error = EAGAIN; | 174 | error = EAGAIN; |
| 212 | goto out_error; | 175 | goto out_error; |
| @@ -225,7 +188,7 @@ xfs_iget_cache_hit( | |||
| 225 | * Need to carefully get it back into useable state. | 188 | * Need to carefully get it back into useable state. |
| 226 | */ | 189 | */ |
| 227 | if (ip->i_flags & XFS_IRECLAIMABLE) { | 190 | if (ip->i_flags & XFS_IRECLAIMABLE) { |
| 228 | xfs_itrace_exit_tag(ip, "xfs_iget.alloc"); | 191 | trace_xfs_iget_reclaim(ip); |
| 229 | 192 | ||
| 230 | /* | 193 | /* |
| 231 | * We need to set XFS_INEW atomically with clearing the | 194 | * We need to set XFS_INEW atomically with clearing the |
| @@ -251,6 +214,7 @@ xfs_iget_cache_hit( | |||
| 251 | ip->i_flags &= ~XFS_INEW; | 214 | ip->i_flags &= ~XFS_INEW; |
| 252 | ip->i_flags |= XFS_IRECLAIMABLE; | 215 | ip->i_flags |= XFS_IRECLAIMABLE; |
| 253 | __xfs_inode_set_reclaim_tag(pag, ip); | 216 | __xfs_inode_set_reclaim_tag(pag, ip); |
| 217 | trace_xfs_iget_reclaim(ip); | ||
| 254 | goto out_error; | 218 | goto out_error; |
| 255 | } | 219 | } |
| 256 | inode->i_state = I_LOCK|I_NEW; | 220 | inode->i_state = I_LOCK|I_NEW; |
| @@ -270,8 +234,9 @@ xfs_iget_cache_hit( | |||
| 270 | xfs_ilock(ip, lock_flags); | 234 | xfs_ilock(ip, lock_flags); |
| 271 | 235 | ||
| 272 | xfs_iflags_clear(ip, XFS_ISTALE); | 236 | xfs_iflags_clear(ip, XFS_ISTALE); |
| 273 | xfs_itrace_exit_tag(ip, "xfs_iget.found"); | ||
| 274 | XFS_STATS_INC(xs_ig_found); | 237 | XFS_STATS_INC(xs_ig_found); |
| 238 | |||
| 239 | trace_xfs_iget_found(ip); | ||
| 275 | return 0; | 240 | return 0; |
| 276 | 241 | ||
| 277 | out_error: | 242 | out_error: |
| @@ -290,7 +255,7 @@ xfs_iget_cache_miss( | |||
| 290 | struct xfs_inode **ipp, | 255 | struct xfs_inode **ipp, |
| 291 | xfs_daddr_t bno, | 256 | xfs_daddr_t bno, |
| 292 | int flags, | 257 | int flags, |
| 293 | int lock_flags) __releases(pag->pag_ici_lock) | 258 | int lock_flags) |
| 294 | { | 259 | { |
| 295 | struct xfs_inode *ip; | 260 | struct xfs_inode *ip; |
| 296 | int error; | 261 | int error; |
| @@ -305,7 +270,7 @@ xfs_iget_cache_miss( | |||
| 305 | if (error) | 270 | if (error) |
| 306 | goto out_destroy; | 271 | goto out_destroy; |
| 307 | 272 | ||
| 308 | xfs_itrace_exit_tag(ip, "xfs_iget.alloc"); | 273 | xfs_itrace_entry(ip); |
| 309 | 274 | ||
| 310 | if ((ip->i_d.di_mode == 0) && !(flags & XFS_IGET_CREATE)) { | 275 | if ((ip->i_d.di_mode == 0) && !(flags & XFS_IGET_CREATE)) { |
| 311 | error = ENOENT; | 276 | error = ENOENT; |
| @@ -350,6 +315,8 @@ xfs_iget_cache_miss( | |||
| 350 | 315 | ||
| 351 | write_unlock(&pag->pag_ici_lock); | 316 | write_unlock(&pag->pag_ici_lock); |
| 352 | radix_tree_preload_end(); | 317 | radix_tree_preload_end(); |
| 318 | |||
| 319 | trace_xfs_iget_alloc(ip); | ||
| 353 | *ipp = ip; | 320 | *ipp = ip; |
| 354 | return 0; | 321 | return 0; |
| 355 | 322 | ||
| @@ -636,7 +603,7 @@ xfs_ilock( | |||
| 636 | else if (lock_flags & XFS_ILOCK_SHARED) | 603 | else if (lock_flags & XFS_ILOCK_SHARED) |
| 637 | mraccess_nested(&ip->i_lock, XFS_ILOCK_DEP(lock_flags)); | 604 | mraccess_nested(&ip->i_lock, XFS_ILOCK_DEP(lock_flags)); |
| 638 | 605 | ||
| 639 | xfs_ilock_trace(ip, 1, lock_flags, (inst_t *)__return_address); | 606 | trace_xfs_ilock(ip, lock_flags, _RET_IP_); |
| 640 | } | 607 | } |
| 641 | 608 | ||
| 642 | /* | 609 | /* |
| @@ -681,7 +648,7 @@ xfs_ilock_nowait( | |||
| 681 | if (!mrtryaccess(&ip->i_lock)) | 648 | if (!mrtryaccess(&ip->i_lock)) |
| 682 | goto out_undo_iolock; | 649 | goto out_undo_iolock; |
| 683 | } | 650 | } |
| 684 | xfs_ilock_trace(ip, 2, lock_flags, (inst_t *)__return_address); | 651 | trace_xfs_ilock_nowait(ip, lock_flags, _RET_IP_); |
| 685 | return 1; | 652 | return 1; |
| 686 | 653 | ||
| 687 | out_undo_iolock: | 654 | out_undo_iolock: |
| @@ -743,7 +710,7 @@ xfs_iunlock( | |||
| 743 | xfs_trans_unlocked_item(ip->i_itemp->ili_item.li_ailp, | 710 | xfs_trans_unlocked_item(ip->i_itemp->ili_item.li_ailp, |
| 744 | (xfs_log_item_t*)(ip->i_itemp)); | 711 | (xfs_log_item_t*)(ip->i_itemp)); |
| 745 | } | 712 | } |
| 746 | xfs_ilock_trace(ip, 3, lock_flags, (inst_t *)__return_address); | 713 | trace_xfs_iunlock(ip, lock_flags, _RET_IP_); |
| 747 | } | 714 | } |
| 748 | 715 | ||
| 749 | /* | 716 | /* |
| @@ -762,6 +729,8 @@ xfs_ilock_demote( | |||
| 762 | mrdemote(&ip->i_lock); | 729 | mrdemote(&ip->i_lock); |
| 763 | if (lock_flags & XFS_IOLOCK_EXCL) | 730 | if (lock_flags & XFS_IOLOCK_EXCL) |
| 764 | mrdemote(&ip->i_iolock); | 731 | mrdemote(&ip->i_iolock); |
| 732 | |||
| 733 | trace_xfs_ilock_demote(ip, lock_flags, _RET_IP_); | ||
| 765 | } | 734 | } |
| 766 | 735 | ||
| 767 | #ifdef DEBUG | 736 | #ifdef DEBUG |
| @@ -792,52 +761,3 @@ xfs_isilocked( | |||
| 792 | return 1; | 761 | return 1; |
| 793 | } | 762 | } |
| 794 | #endif | 763 | #endif |
| 795 | |||
| 796 | #ifdef XFS_INODE_TRACE | ||
| 797 | |||
| 798 | #define KTRACE_ENTER(ip, vk, s, line, ra) \ | ||
| 799 | ktrace_enter((ip)->i_trace, \ | ||
| 800 | /* 0 */ (void *)(__psint_t)(vk), \ | ||
| 801 | /* 1 */ (void *)(s), \ | ||
| 802 | /* 2 */ (void *)(__psint_t) line, \ | ||
| 803 | /* 3 */ (void *)(__psint_t)atomic_read(&VFS_I(ip)->i_count), \ | ||
| 804 | /* 4 */ (void *)(ra), \ | ||
| 805 | /* 5 */ NULL, \ | ||
| 806 | /* 6 */ (void *)(__psint_t)current_cpu(), \ | ||
| 807 | /* 7 */ (void *)(__psint_t)current_pid(), \ | ||
| 808 | /* 8 */ (void *)__return_address, \ | ||
| 809 | /* 9 */ NULL, NULL, NULL, NULL, NULL, NULL, NULL) | ||
| 810 | |||
| 811 | /* | ||
| 812 | * Vnode tracing code. | ||
| 813 | */ | ||
| 814 | void | ||
| 815 | _xfs_itrace_entry(xfs_inode_t *ip, const char *func, inst_t *ra) | ||
| 816 | { | ||
| 817 | KTRACE_ENTER(ip, INODE_KTRACE_ENTRY, func, 0, ra); | ||
| 818 | } | ||
| 819 | |||
| 820 | void | ||
| 821 | _xfs_itrace_exit(xfs_inode_t *ip, const char *func, inst_t *ra) | ||
| 822 | { | ||
| 823 | KTRACE_ENTER(ip, INODE_KTRACE_EXIT, func, 0, ra); | ||
| 824 | } | ||
| 825 | |||
| 826 | void | ||
| 827 | xfs_itrace_hold(xfs_inode_t *ip, char *file, int line, inst_t *ra) | ||
| 828 | { | ||
| 829 | KTRACE_ENTER(ip, INODE_KTRACE_HOLD, file, line, ra); | ||
| 830 | } | ||
| 831 | |||
| 832 | void | ||
| 833 | _xfs_itrace_ref(xfs_inode_t *ip, char *file, int line, inst_t *ra) | ||
| 834 | { | ||
| 835 | KTRACE_ENTER(ip, INODE_KTRACE_REF, file, line, ra); | ||
| 836 | } | ||
| 837 | |||
| 838 | void | ||
| 839 | xfs_itrace_rele(xfs_inode_t *ip, char *file, int line, inst_t *ra) | ||
| 840 | { | ||
| 841 | KTRACE_ENTER(ip, INODE_KTRACE_RELE, file, line, ra); | ||
| 842 | } | ||
| 843 | #endif /* XFS_INODE_TRACE */ | ||
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index b92a4fa2a0a1..ce278b3ae7fc 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c | |||
| @@ -47,10 +47,10 @@ | |||
| 47 | #include "xfs_rw.h" | 47 | #include "xfs_rw.h" |
| 48 | #include "xfs_error.h" | 48 | #include "xfs_error.h" |
| 49 | #include "xfs_utils.h" | 49 | #include "xfs_utils.h" |
| 50 | #include "xfs_dir2_trace.h" | ||
| 51 | #include "xfs_quota.h" | 50 | #include "xfs_quota.h" |
| 52 | #include "xfs_filestream.h" | 51 | #include "xfs_filestream.h" |
| 53 | #include "xfs_vnodeops.h" | 52 | #include "xfs_vnodeops.h" |
| 53 | #include "xfs_trace.h" | ||
| 54 | 54 | ||
| 55 | kmem_zone_t *xfs_ifork_zone; | 55 | kmem_zone_t *xfs_ifork_zone; |
| 56 | kmem_zone_t *xfs_inode_zone; | 56 | kmem_zone_t *xfs_inode_zone; |
| @@ -1291,42 +1291,6 @@ xfs_file_last_byte( | |||
| 1291 | return last_byte; | 1291 | return last_byte; |
| 1292 | } | 1292 | } |
| 1293 | 1293 | ||
| 1294 | #if defined(XFS_RW_TRACE) | ||
| 1295 | STATIC void | ||
| 1296 | xfs_itrunc_trace( | ||
| 1297 | int tag, | ||
| 1298 | xfs_inode_t *ip, | ||
| 1299 | int flag, | ||
| 1300 | xfs_fsize_t new_size, | ||
| 1301 | xfs_off_t toss_start, | ||
| 1302 | xfs_off_t toss_finish) | ||
| 1303 | { | ||
| 1304 | if (ip->i_rwtrace == NULL) { | ||
| 1305 | return; | ||
| 1306 | } | ||
| 1307 | |||
| 1308 | ktrace_enter(ip->i_rwtrace, | ||
| 1309 | (void*)((long)tag), | ||
| 1310 | (void*)ip, | ||
| 1311 | (void*)(unsigned long)((ip->i_d.di_size >> 32) & 0xffffffff), | ||
| 1312 | (void*)(unsigned long)(ip->i_d.di_size & 0xffffffff), | ||
| 1313 | (void*)((long)flag), | ||
| 1314 | (void*)(unsigned long)((new_size >> 32) & 0xffffffff), | ||
| 1315 | (void*)(unsigned long)(new_size & 0xffffffff), | ||
| 1316 | (void*)(unsigned long)((toss_start >> 32) & 0xffffffff), | ||
| 1317 | (void*)(unsigned long)(toss_start & 0xffffffff), | ||
| 1318 | (void*)(unsigned long)((toss_finish >> 32) & 0xffffffff), | ||
| 1319 | (void*)(unsigned long)(toss_finish & 0xffffffff), | ||
| 1320 | (void*)(unsigned long)current_cpu(), | ||
| 1321 | (void*)(unsigned long)current_pid(), | ||
| 1322 | (void*)NULL, | ||
| 1323 | (void*)NULL, | ||
| 1324 | (void*)NULL); | ||
| 1325 | } | ||
| 1326 | #else | ||
| 1327 | #define xfs_itrunc_trace(tag, ip, flag, new_size, toss_start, toss_finish) | ||
| 1328 | #endif | ||
| 1329 | |||
| 1330 | /* | 1294 | /* |
| 1331 | * Start the truncation of the file to new_size. The new size | 1295 | * Start the truncation of the file to new_size. The new size |
| 1332 | * must be smaller than the current size. This routine will | 1296 | * must be smaller than the current size. This routine will |
| @@ -1409,8 +1373,7 @@ xfs_itruncate_start( | |||
| 1409 | return 0; | 1373 | return 0; |
| 1410 | } | 1374 | } |
| 1411 | last_byte = xfs_file_last_byte(ip); | 1375 | last_byte = xfs_file_last_byte(ip); |
| 1412 | xfs_itrunc_trace(XFS_ITRUNC_START, ip, flags, new_size, toss_start, | 1376 | trace_xfs_itruncate_start(ip, flags, new_size, toss_start, last_byte); |
| 1413 | last_byte); | ||
| 1414 | if (last_byte > toss_start) { | 1377 | if (last_byte > toss_start) { |
| 1415 | if (flags & XFS_ITRUNC_DEFINITE) { | 1378 | if (flags & XFS_ITRUNC_DEFINITE) { |
| 1416 | xfs_tosspages(ip, toss_start, | 1379 | xfs_tosspages(ip, toss_start, |
| @@ -1514,7 +1477,8 @@ xfs_itruncate_finish( | |||
| 1514 | new_size = 0LL; | 1477 | new_size = 0LL; |
| 1515 | } | 1478 | } |
| 1516 | first_unmap_block = XFS_B_TO_FSB(mp, (xfs_ufsize_t)new_size); | 1479 | first_unmap_block = XFS_B_TO_FSB(mp, (xfs_ufsize_t)new_size); |
| 1517 | xfs_itrunc_trace(XFS_ITRUNC_FINISH1, ip, 0, new_size, 0, 0); | 1480 | trace_xfs_itruncate_finish_start(ip, new_size); |
| 1481 | |||
| 1518 | /* | 1482 | /* |
| 1519 | * The first thing we do is set the size to new_size permanently | 1483 | * The first thing we do is set the size to new_size permanently |
| 1520 | * on disk. This way we don't have to worry about anyone ever | 1484 | * on disk. This way we don't have to worry about anyone ever |
| @@ -1731,7 +1695,7 @@ xfs_itruncate_finish( | |||
| 1731 | ASSERT((new_size != 0) || | 1695 | ASSERT((new_size != 0) || |
| 1732 | (fork == XFS_ATTR_FORK) || | 1696 | (fork == XFS_ATTR_FORK) || |
| 1733 | (ip->i_d.di_nextents == 0)); | 1697 | (ip->i_d.di_nextents == 0)); |
| 1734 | xfs_itrunc_trace(XFS_ITRUNC_FINISH2, ip, 0, new_size, 0, 0); | 1698 | trace_xfs_itruncate_finish_end(ip, new_size); |
| 1735 | return 0; | 1699 | return 0; |
| 1736 | } | 1700 | } |
| 1737 | 1701 | ||
| @@ -3252,23 +3216,6 @@ corrupt_out: | |||
| 3252 | return XFS_ERROR(EFSCORRUPTED); | 3216 | return XFS_ERROR(EFSCORRUPTED); |
| 3253 | } | 3217 | } |
| 3254 | 3218 | ||
| 3255 | |||
| 3256 | |||
| 3257 | #ifdef XFS_ILOCK_TRACE | ||
| 3258 | void | ||
| 3259 | xfs_ilock_trace(xfs_inode_t *ip, int lock, unsigned int lockflags, inst_t *ra) | ||
| 3260 | { | ||
| 3261 | ktrace_enter(ip->i_lock_trace, | ||
| 3262 | (void *)ip, | ||
| 3263 | (void *)(unsigned long)lock, /* 1 = LOCK, 3=UNLOCK, etc */ | ||
| 3264 | (void *)(unsigned long)lockflags, /* XFS_ILOCK_EXCL etc */ | ||
| 3265 | (void *)ra, /* caller of ilock */ | ||
| 3266 | (void *)(unsigned long)current_cpu(), | ||
| 3267 | (void *)(unsigned long)current_pid(), | ||
| 3268 | NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL); | ||
| 3269 | } | ||
| 3270 | #endif | ||
| 3271 | |||
| 3272 | /* | 3219 | /* |
| 3273 | * Return a pointer to the extent record at file index idx. | 3220 | * Return a pointer to the extent record at file index idx. |
| 3274 | */ | 3221 | */ |
| @@ -3300,13 +3247,17 @@ xfs_iext_get_ext( | |||
| 3300 | */ | 3247 | */ |
| 3301 | void | 3248 | void |
| 3302 | xfs_iext_insert( | 3249 | xfs_iext_insert( |
| 3303 | xfs_ifork_t *ifp, /* inode fork pointer */ | 3250 | xfs_inode_t *ip, /* incore inode pointer */ |
| 3304 | xfs_extnum_t idx, /* starting index of new items */ | 3251 | xfs_extnum_t idx, /* starting index of new items */ |
| 3305 | xfs_extnum_t count, /* number of inserted items */ | 3252 | xfs_extnum_t count, /* number of inserted items */ |
| 3306 | xfs_bmbt_irec_t *new) /* items to insert */ | 3253 | xfs_bmbt_irec_t *new, /* items to insert */ |
| 3254 | int state) /* type of extent conversion */ | ||
| 3307 | { | 3255 | { |
| 3256 | xfs_ifork_t *ifp = (state & BMAP_ATTRFORK) ? ip->i_afp : &ip->i_df; | ||
| 3308 | xfs_extnum_t i; /* extent record index */ | 3257 | xfs_extnum_t i; /* extent record index */ |
| 3309 | 3258 | ||
| 3259 | trace_xfs_iext_insert(ip, idx, new, state, _RET_IP_); | ||
| 3260 | |||
| 3310 | ASSERT(ifp->if_flags & XFS_IFEXTENTS); | 3261 | ASSERT(ifp->if_flags & XFS_IFEXTENTS); |
| 3311 | xfs_iext_add(ifp, idx, count); | 3262 | xfs_iext_add(ifp, idx, count); |
| 3312 | for (i = idx; i < idx + count; i++, new++) | 3263 | for (i = idx; i < idx + count; i++, new++) |
| @@ -3549,13 +3500,17 @@ xfs_iext_add_indirect_multi( | |||
| 3549 | */ | 3500 | */ |
| 3550 | void | 3501 | void |
| 3551 | xfs_iext_remove( | 3502 | xfs_iext_remove( |
| 3552 | xfs_ifork_t *ifp, /* inode fork pointer */ | 3503 | xfs_inode_t *ip, /* incore inode pointer */ |
| 3553 | xfs_extnum_t idx, /* index to begin removing exts */ | 3504 | xfs_extnum_t idx, /* index to begin removing exts */ |
| 3554 | int ext_diff) /* number of extents to remove */ | 3505 | int ext_diff, /* number of extents to remove */ |
| 3506 | int state) /* type of extent conversion */ | ||
| 3555 | { | 3507 | { |
| 3508 | xfs_ifork_t *ifp = (state & BMAP_ATTRFORK) ? ip->i_afp : &ip->i_df; | ||
| 3556 | xfs_extnum_t nextents; /* number of extents in file */ | 3509 | xfs_extnum_t nextents; /* number of extents in file */ |
| 3557 | int new_size; /* size of extents after removal */ | 3510 | int new_size; /* size of extents after removal */ |
| 3558 | 3511 | ||
| 3512 | trace_xfs_iext_remove(ip, idx, state, _RET_IP_); | ||
| 3513 | |||
| 3559 | ASSERT(ext_diff > 0); | 3514 | ASSERT(ext_diff > 0); |
| 3560 | nextents = ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t); | 3515 | nextents = ifp->if_bytes / (uint)sizeof(xfs_bmbt_rec_t); |
| 3561 | new_size = (nextents - ext_diff) * sizeof(xfs_bmbt_rec_t); | 3516 | new_size = (nextents - ext_diff) * sizeof(xfs_bmbt_rec_t); |
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index 41555de1d1db..ec1f28c4fc4f 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h | |||
| @@ -213,7 +213,6 @@ typedef struct xfs_icdinode { | |||
| 213 | 213 | ||
| 214 | struct bhv_desc; | 214 | struct bhv_desc; |
| 215 | struct cred; | 215 | struct cred; |
| 216 | struct ktrace; | ||
| 217 | struct xfs_buf; | 216 | struct xfs_buf; |
| 218 | struct xfs_bmap_free; | 217 | struct xfs_bmap_free; |
| 219 | struct xfs_bmbt_irec; | 218 | struct xfs_bmbt_irec; |
| @@ -222,13 +221,6 @@ struct xfs_mount; | |||
| 222 | struct xfs_trans; | 221 | struct xfs_trans; |
| 223 | struct xfs_dquot; | 222 | struct xfs_dquot; |
| 224 | 223 | ||
| 225 | #if defined(XFS_ILOCK_TRACE) | ||
| 226 | #define XFS_ILOCK_KTRACE_SIZE 32 | ||
| 227 | extern void xfs_ilock_trace(struct xfs_inode *, int, unsigned int, inst_t *); | ||
| 228 | #else | ||
| 229 | #define xfs_ilock_trace(i,n,f,ra) | ||
| 230 | #endif | ||
| 231 | |||
| 232 | typedef struct dm_attrs_s { | 224 | typedef struct dm_attrs_s { |
| 233 | __uint32_t da_dmevmask; /* DMIG event mask */ | 225 | __uint32_t da_dmevmask; /* DMIG event mask */ |
| 234 | __uint16_t da_dmstate; /* DMIG state info */ | 226 | __uint16_t da_dmstate; /* DMIG state info */ |
| @@ -271,26 +263,6 @@ typedef struct xfs_inode { | |||
| 271 | 263 | ||
| 272 | /* VFS inode */ | 264 | /* VFS inode */ |
| 273 | struct inode i_vnode; /* embedded VFS inode */ | 265 | struct inode i_vnode; /* embedded VFS inode */ |
| 274 | |||
| 275 | /* Trace buffers per inode. */ | ||
| 276 | #ifdef XFS_INODE_TRACE | ||
| 277 | struct ktrace *i_trace; /* general inode trace */ | ||
| 278 | #endif | ||
| 279 | #ifdef XFS_BMAP_TRACE | ||
| 280 | struct ktrace *i_xtrace; /* inode extent list trace */ | ||
| 281 | #endif | ||
| 282 | #ifdef XFS_BTREE_TRACE | ||
| 283 | struct ktrace *i_btrace; /* inode bmap btree trace */ | ||
| 284 | #endif | ||
| 285 | #ifdef XFS_RW_TRACE | ||
| 286 | struct ktrace *i_rwtrace; /* inode read/write trace */ | ||
| 287 | #endif | ||
| 288 | #ifdef XFS_ILOCK_TRACE | ||
| 289 | struct ktrace *i_lock_trace; /* inode lock/unlock trace */ | ||
| 290 | #endif | ||
| 291 | #ifdef XFS_DIR2_TRACE | ||
| 292 | struct ktrace *i_dir_trace; /* inode directory trace */ | ||
| 293 | #endif | ||
| 294 | } xfs_inode_t; | 266 | } xfs_inode_t; |
| 295 | 267 | ||
| 296 | #define XFS_ISIZE(ip) (((ip)->i_d.di_mode & S_IFMT) == S_IFREG) ? \ | 268 | #define XFS_ISIZE(ip) (((ip)->i_d.di_mode & S_IFMT) == S_IFREG) ? \ |
| @@ -406,6 +378,14 @@ static inline void xfs_ifunlock(xfs_inode_t *ip) | |||
| 406 | #define XFS_LOCK_MASK (XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED \ | 378 | #define XFS_LOCK_MASK (XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED \ |
| 407 | | XFS_ILOCK_EXCL | XFS_ILOCK_SHARED) | 379 | | XFS_ILOCK_EXCL | XFS_ILOCK_SHARED) |
| 408 | 380 | ||
| 381 | #define XFS_LOCK_FLAGS \ | ||
| 382 | { XFS_IOLOCK_EXCL, "IOLOCK_EXCL" }, \ | ||
| 383 | { XFS_IOLOCK_SHARED, "IOLOCK_SHARED" }, \ | ||
| 384 | { XFS_ILOCK_EXCL, "ILOCK_EXCL" }, \ | ||
| 385 | { XFS_ILOCK_SHARED, "ILOCK_SHARED" }, \ | ||
| 386 | { XFS_IUNLOCK_NONOTIFY, "IUNLOCK_NONOTIFY" } | ||
| 387 | |||
| 388 | |||
| 409 | /* | 389 | /* |
| 410 | * Flags for lockdep annotations. | 390 | * Flags for lockdep annotations. |
| 411 | * | 391 | * |
| @@ -455,6 +435,10 @@ static inline void xfs_ifunlock(xfs_inode_t *ip) | |||
| 455 | #define XFS_ITRUNC_DEFINITE 0x1 | 435 | #define XFS_ITRUNC_DEFINITE 0x1 |
| 456 | #define XFS_ITRUNC_MAYBE 0x2 | 436 | #define XFS_ITRUNC_MAYBE 0x2 |
| 457 | 437 | ||
| 438 | #define XFS_ITRUNC_FLAGS \ | ||
| 439 | { XFS_ITRUNC_DEFINITE, "DEFINITE" }, \ | ||
| 440 | { XFS_ITRUNC_MAYBE, "MAYBE" } | ||
| 441 | |||
| 458 | /* | 442 | /* |
| 459 | * For multiple groups support: if S_ISGID bit is set in the parent | 443 | * For multiple groups support: if S_ISGID bit is set in the parent |
| 460 | * directory, group of new file is set to that of the parent, and | 444 | * directory, group of new file is set to that of the parent, and |
| @@ -507,48 +491,16 @@ void xfs_lock_two_inodes(xfs_inode_t *, xfs_inode_t *, uint); | |||
| 507 | void xfs_synchronize_times(xfs_inode_t *); | 491 | void xfs_synchronize_times(xfs_inode_t *); |
| 508 | void xfs_mark_inode_dirty_sync(xfs_inode_t *); | 492 | void xfs_mark_inode_dirty_sync(xfs_inode_t *); |
| 509 | 493 | ||
| 510 | #if defined(XFS_INODE_TRACE) | ||
| 511 | |||
| 512 | #define INODE_TRACE_SIZE 16 /* number of trace entries */ | ||
| 513 | #define INODE_KTRACE_ENTRY 1 | ||
| 514 | #define INODE_KTRACE_EXIT 2 | ||
| 515 | #define INODE_KTRACE_HOLD 3 | ||
| 516 | #define INODE_KTRACE_REF 4 | ||
| 517 | #define INODE_KTRACE_RELE 5 | ||
| 518 | |||
| 519 | extern void _xfs_itrace_entry(struct xfs_inode *, const char *, inst_t *); | ||
| 520 | extern void _xfs_itrace_exit(struct xfs_inode *, const char *, inst_t *); | ||
| 521 | extern void xfs_itrace_hold(struct xfs_inode *, char *, int, inst_t *); | ||
| 522 | extern void _xfs_itrace_ref(struct xfs_inode *, char *, int, inst_t *); | ||
| 523 | extern void xfs_itrace_rele(struct xfs_inode *, char *, int, inst_t *); | ||
| 524 | #define xfs_itrace_entry(ip) \ | ||
| 525 | _xfs_itrace_entry(ip, __func__, (inst_t *)__return_address) | ||
| 526 | #define xfs_itrace_exit(ip) \ | ||
| 527 | _xfs_itrace_exit(ip, __func__, (inst_t *)__return_address) | ||
| 528 | #define xfs_itrace_exit_tag(ip, tag) \ | ||
| 529 | _xfs_itrace_exit(ip, tag, (inst_t *)__return_address) | ||
| 530 | #define xfs_itrace_ref(ip) \ | ||
| 531 | _xfs_itrace_ref(ip, __FILE__, __LINE__, (inst_t *)__return_address) | ||
| 532 | |||
| 533 | #else | ||
| 534 | #define xfs_itrace_entry(a) | ||
| 535 | #define xfs_itrace_exit(a) | ||
| 536 | #define xfs_itrace_exit_tag(a, b) | ||
| 537 | #define xfs_itrace_hold(a, b, c, d) | ||
| 538 | #define xfs_itrace_ref(a) | ||
| 539 | #define xfs_itrace_rele(a, b, c, d) | ||
| 540 | #endif | ||
| 541 | |||
| 542 | #define IHOLD(ip) \ | 494 | #define IHOLD(ip) \ |
| 543 | do { \ | 495 | do { \ |
| 544 | ASSERT(atomic_read(&VFS_I(ip)->i_count) > 0) ; \ | 496 | ASSERT(atomic_read(&VFS_I(ip)->i_count) > 0) ; \ |
| 545 | atomic_inc(&(VFS_I(ip)->i_count)); \ | 497 | atomic_inc(&(VFS_I(ip)->i_count)); \ |
| 546 | xfs_itrace_hold((ip), __FILE__, __LINE__, (inst_t *)__return_address); \ | 498 | trace_xfs_ihold(ip, _THIS_IP_); \ |
| 547 | } while (0) | 499 | } while (0) |
| 548 | 500 | ||
| 549 | #define IRELE(ip) \ | 501 | #define IRELE(ip) \ |
| 550 | do { \ | 502 | do { \ |
| 551 | xfs_itrace_rele((ip), __FILE__, __LINE__, (inst_t *)__return_address); \ | 503 | trace_xfs_irele(ip, _THIS_IP_); \ |
| 552 | iput(VFS_I(ip)); \ | 504 | iput(VFS_I(ip)); \ |
| 553 | } while (0) | 505 | } while (0) |
| 554 | 506 | ||
| @@ -577,11 +529,11 @@ int xfs_iread_extents(struct xfs_trans *, struct xfs_inode *, int); | |||
| 577 | int xfs_iextents_copy(struct xfs_inode *, xfs_bmbt_rec_t *, int); | 529 | int xfs_iextents_copy(struct xfs_inode *, xfs_bmbt_rec_t *, int); |
| 578 | 530 | ||
| 579 | xfs_bmbt_rec_host_t *xfs_iext_get_ext(xfs_ifork_t *, xfs_extnum_t); | 531 | xfs_bmbt_rec_host_t *xfs_iext_get_ext(xfs_ifork_t *, xfs_extnum_t); |
| 580 | void xfs_iext_insert(xfs_ifork_t *, xfs_extnum_t, xfs_extnum_t, | 532 | void xfs_iext_insert(xfs_inode_t *, xfs_extnum_t, xfs_extnum_t, |
| 581 | xfs_bmbt_irec_t *); | 533 | xfs_bmbt_irec_t *, int); |
| 582 | void xfs_iext_add(xfs_ifork_t *, xfs_extnum_t, int); | 534 | void xfs_iext_add(xfs_ifork_t *, xfs_extnum_t, int); |
| 583 | void xfs_iext_add_indirect_multi(xfs_ifork_t *, int, xfs_extnum_t, int); | 535 | void xfs_iext_add_indirect_multi(xfs_ifork_t *, int, xfs_extnum_t, int); |
| 584 | void xfs_iext_remove(xfs_ifork_t *, xfs_extnum_t, int); | 536 | void xfs_iext_remove(xfs_inode_t *, xfs_extnum_t, int, int); |
| 585 | void xfs_iext_remove_inline(xfs_ifork_t *, xfs_extnum_t, int); | 537 | void xfs_iext_remove_inline(xfs_ifork_t *, xfs_extnum_t, int); |
| 586 | void xfs_iext_remove_direct(xfs_ifork_t *, xfs_extnum_t, int); | 538 | void xfs_iext_remove_direct(xfs_ifork_t *, xfs_extnum_t, int); |
| 587 | void xfs_iext_remove_indirect(xfs_ifork_t *, xfs_extnum_t, int); | 539 | void xfs_iext_remove_indirect(xfs_ifork_t *, xfs_extnum_t, int); |
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index 9794b876d6ff..f38855d21ea5 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c | |||
| @@ -41,6 +41,7 @@ | |||
| 41 | #include "xfs_ialloc.h" | 41 | #include "xfs_ialloc.h" |
| 42 | #include "xfs_rw.h" | 42 | #include "xfs_rw.h" |
| 43 | #include "xfs_error.h" | 43 | #include "xfs_error.h" |
| 44 | #include "xfs_trace.h" | ||
| 44 | 45 | ||
| 45 | 46 | ||
| 46 | kmem_zone_t *xfs_ili_zone; /* inode log item zone */ | 47 | kmem_zone_t *xfs_ili_zone; /* inode log item zone */ |
| @@ -800,7 +801,9 @@ xfs_inode_item_pushbuf( | |||
| 800 | !completion_done(&ip->i_flush)); | 801 | !completion_done(&ip->i_flush)); |
| 801 | iip->ili_pushbuf_flag = 0; | 802 | iip->ili_pushbuf_flag = 0; |
| 802 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | 803 | xfs_iunlock(ip, XFS_ILOCK_SHARED); |
| 803 | xfs_buftrace("INODE ITEM PUSH", bp); | 804 | |
| 805 | trace_xfs_inode_item_push(bp, _RET_IP_); | ||
| 806 | |||
| 804 | if (XFS_BUF_ISPINNED(bp)) { | 807 | if (XFS_BUF_ISPINNED(bp)) { |
| 805 | xfs_log_force(mp, (xfs_lsn_t)0, | 808 | xfs_log_force(mp, (xfs_lsn_t)0, |
| 806 | XFS_LOG_FORCE); | 809 | XFS_LOG_FORCE); |
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index 67ae5555a30a..0b65039951a0 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c | |||
| @@ -47,72 +47,8 @@ | |||
| 47 | #include "xfs_trans_space.h" | 47 | #include "xfs_trans_space.h" |
| 48 | #include "xfs_utils.h" | 48 | #include "xfs_utils.h" |
| 49 | #include "xfs_iomap.h" | 49 | #include "xfs_iomap.h" |
| 50 | #include "xfs_trace.h" | ||
| 50 | 51 | ||
| 51 | #if defined(XFS_RW_TRACE) | ||
| 52 | void | ||
| 53 | xfs_iomap_enter_trace( | ||
| 54 | int tag, | ||
| 55 | xfs_inode_t *ip, | ||
| 56 | xfs_off_t offset, | ||
| 57 | ssize_t count) | ||
| 58 | { | ||
| 59 | if (!ip->i_rwtrace) | ||
| 60 | return; | ||
| 61 | |||
| 62 | ktrace_enter(ip->i_rwtrace, | ||
| 63 | (void *)((unsigned long)tag), | ||
| 64 | (void *)ip, | ||
| 65 | (void *)((unsigned long)((ip->i_d.di_size >> 32) & 0xffffffff)), | ||
| 66 | (void *)((unsigned long)(ip->i_d.di_size & 0xffffffff)), | ||
| 67 | (void *)((unsigned long)((offset >> 32) & 0xffffffff)), | ||
| 68 | (void *)((unsigned long)(offset & 0xffffffff)), | ||
| 69 | (void *)((unsigned long)count), | ||
| 70 | (void *)((unsigned long)((ip->i_new_size >> 32) & 0xffffffff)), | ||
| 71 | (void *)((unsigned long)(ip->i_new_size & 0xffffffff)), | ||
| 72 | (void *)((unsigned long)current_pid()), | ||
| 73 | (void *)NULL, | ||
| 74 | (void *)NULL, | ||
| 75 | (void *)NULL, | ||
| 76 | (void *)NULL, | ||
| 77 | (void *)NULL, | ||
| 78 | (void *)NULL); | ||
| 79 | } | ||
| 80 | |||
| 81 | void | ||
| 82 | xfs_iomap_map_trace( | ||
| 83 | int tag, | ||
| 84 | xfs_inode_t *ip, | ||
| 85 | xfs_off_t offset, | ||
| 86 | ssize_t count, | ||
| 87 | xfs_iomap_t *iomapp, | ||
| 88 | xfs_bmbt_irec_t *imapp, | ||
| 89 | int flags) | ||
| 90 | { | ||
| 91 | if (!ip->i_rwtrace) | ||
| 92 | return; | ||
| 93 | |||
| 94 | ktrace_enter(ip->i_rwtrace, | ||
| 95 | (void *)((unsigned long)tag), | ||
| 96 | (void *)ip, | ||
| 97 | (void *)((unsigned long)((ip->i_d.di_size >> 32) & 0xffffffff)), | ||
| 98 | (void *)((unsigned long)(ip->i_d.di_size & 0xffffffff)), | ||
| 99 | (void *)((unsigned long)((offset >> 32) & 0xffffffff)), | ||
| 100 | (void *)((unsigned long)(offset & 0xffffffff)), | ||
| 101 | (void *)((unsigned long)count), | ||
| 102 | (void *)((unsigned long)flags), | ||
| 103 | (void *)((unsigned long)((iomapp->iomap_offset >> 32) & 0xffffffff)), | ||
| 104 | (void *)((unsigned long)(iomapp->iomap_offset & 0xffffffff)), | ||
| 105 | (void *)((unsigned long)(iomapp->iomap_delta)), | ||
| 106 | (void *)((unsigned long)(iomapp->iomap_bsize)), | ||
| 107 | (void *)((unsigned long)(iomapp->iomap_bn)), | ||
| 108 | (void *)(__psint_t)(imapp->br_startoff), | ||
| 109 | (void *)((unsigned long)(imapp->br_blockcount)), | ||
| 110 | (void *)(__psint_t)(imapp->br_startblock)); | ||
| 111 | } | ||
| 112 | #else | ||
| 113 | #define xfs_iomap_enter_trace(tag, io, offset, count) | ||
| 114 | #define xfs_iomap_map_trace(tag, io, offset, count, iomapp, imapp, flags) | ||
| 115 | #endif | ||
| 116 | 52 | ||
| 117 | #define XFS_WRITEIO_ALIGN(mp,off) (((off) >> mp->m_writeio_log) \ | 53 | #define XFS_WRITEIO_ALIGN(mp,off) (((off) >> mp->m_writeio_log) \ |
| 118 | << mp->m_writeio_log) | 54 | << mp->m_writeio_log) |
| @@ -187,21 +123,20 @@ xfs_iomap( | |||
| 187 | if (XFS_FORCED_SHUTDOWN(mp)) | 123 | if (XFS_FORCED_SHUTDOWN(mp)) |
| 188 | return XFS_ERROR(EIO); | 124 | return XFS_ERROR(EIO); |
| 189 | 125 | ||
| 126 | trace_xfs_iomap_enter(ip, offset, count, flags, NULL); | ||
| 127 | |||
| 190 | switch (flags & (BMAPI_READ | BMAPI_WRITE | BMAPI_ALLOCATE)) { | 128 | switch (flags & (BMAPI_READ | BMAPI_WRITE | BMAPI_ALLOCATE)) { |
| 191 | case BMAPI_READ: | 129 | case BMAPI_READ: |
| 192 | xfs_iomap_enter_trace(XFS_IOMAP_READ_ENTER, ip, offset, count); | ||
| 193 | lockmode = xfs_ilock_map_shared(ip); | 130 | lockmode = xfs_ilock_map_shared(ip); |
| 194 | bmapi_flags = XFS_BMAPI_ENTIRE; | 131 | bmapi_flags = XFS_BMAPI_ENTIRE; |
| 195 | break; | 132 | break; |
| 196 | case BMAPI_WRITE: | 133 | case BMAPI_WRITE: |
| 197 | xfs_iomap_enter_trace(XFS_IOMAP_WRITE_ENTER, ip, offset, count); | ||
| 198 | lockmode = XFS_ILOCK_EXCL; | 134 | lockmode = XFS_ILOCK_EXCL; |
| 199 | if (flags & BMAPI_IGNSTATE) | 135 | if (flags & BMAPI_IGNSTATE) |
| 200 | bmapi_flags |= XFS_BMAPI_IGSTATE|XFS_BMAPI_ENTIRE; | 136 | bmapi_flags |= XFS_BMAPI_IGSTATE|XFS_BMAPI_ENTIRE; |
| 201 | xfs_ilock(ip, lockmode); | 137 | xfs_ilock(ip, lockmode); |
| 202 | break; | 138 | break; |
| 203 | case BMAPI_ALLOCATE: | 139 | case BMAPI_ALLOCATE: |
| 204 | xfs_iomap_enter_trace(XFS_IOMAP_ALLOC_ENTER, ip, offset, count); | ||
| 205 | lockmode = XFS_ILOCK_SHARED; | 140 | lockmode = XFS_ILOCK_SHARED; |
| 206 | bmapi_flags = XFS_BMAPI_ENTIRE; | 141 | bmapi_flags = XFS_BMAPI_ENTIRE; |
| 207 | 142 | ||
| @@ -237,8 +172,7 @@ xfs_iomap( | |||
| 237 | if (nimaps && | 172 | if (nimaps && |
| 238 | (imap.br_startblock != HOLESTARTBLOCK) && | 173 | (imap.br_startblock != HOLESTARTBLOCK) && |
| 239 | (imap.br_startblock != DELAYSTARTBLOCK)) { | 174 | (imap.br_startblock != DELAYSTARTBLOCK)) { |
| 240 | xfs_iomap_map_trace(XFS_IOMAP_WRITE_MAP, ip, | 175 | trace_xfs_iomap_found(ip, offset, count, flags, &imap); |
| 241 | offset, count, iomapp, &imap, flags); | ||
| 242 | break; | 176 | break; |
| 243 | } | 177 | } |
| 244 | 178 | ||
| @@ -250,8 +184,7 @@ xfs_iomap( | |||
| 250 | &imap, &nimaps); | 184 | &imap, &nimaps); |
| 251 | } | 185 | } |
| 252 | if (!error) { | 186 | if (!error) { |
| 253 | xfs_iomap_map_trace(XFS_IOMAP_ALLOC_MAP, ip, | 187 | trace_xfs_iomap_alloc(ip, offset, count, flags, &imap); |
| 254 | offset, count, iomapp, &imap, flags); | ||
| 255 | } | 188 | } |
| 256 | iomap_flags = IOMAP_NEW; | 189 | iomap_flags = IOMAP_NEW; |
| 257 | break; | 190 | break; |
| @@ -261,8 +194,7 @@ xfs_iomap( | |||
| 261 | lockmode = 0; | 194 | lockmode = 0; |
| 262 | 195 | ||
| 263 | if (nimaps && !isnullstartblock(imap.br_startblock)) { | 196 | if (nimaps && !isnullstartblock(imap.br_startblock)) { |
| 264 | xfs_iomap_map_trace(XFS_IOMAP_WRITE_MAP, ip, | 197 | trace_xfs_iomap_found(ip, offset, count, flags, &imap); |
| 265 | offset, count, iomapp, &imap, flags); | ||
| 266 | break; | 198 | break; |
| 267 | } | 199 | } |
| 268 | 200 | ||
| @@ -623,8 +555,7 @@ retry: | |||
| 623 | * delalloc blocks and retry without EOF preallocation. | 555 | * delalloc blocks and retry without EOF preallocation. |
| 624 | */ | 556 | */ |
| 625 | if (nimaps == 0) { | 557 | if (nimaps == 0) { |
| 626 | xfs_iomap_enter_trace(XFS_IOMAP_WRITE_NOSPACE, | 558 | trace_xfs_delalloc_enospc(ip, offset, count); |
| 627 | ip, offset, count); | ||
| 628 | if (flushed) | 559 | if (flushed) |
| 629 | return XFS_ERROR(ENOSPC); | 560 | return XFS_ERROR(ENOSPC); |
| 630 | 561 | ||
| @@ -837,7 +768,7 @@ xfs_iomap_write_unwritten( | |||
| 837 | int committed; | 768 | int committed; |
| 838 | int error; | 769 | int error; |
| 839 | 770 | ||
| 840 | xfs_iomap_enter_trace(XFS_IOMAP_UNWRITTEN, ip, offset, count); | 771 | trace_xfs_unwritten_convert(ip, offset, count); |
| 841 | 772 | ||
| 842 | offset_fsb = XFS_B_TO_FSBT(mp, offset); | 773 | offset_fsb = XFS_B_TO_FSBT(mp, offset); |
| 843 | count_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)offset + count); | 774 | count_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)offset + count); |
| @@ -860,8 +791,15 @@ xfs_iomap_write_unwritten( | |||
| 860 | * set up a transaction to convert the range of extents | 791 | * set up a transaction to convert the range of extents |
| 861 | * from unwritten to real. Do allocations in a loop until | 792 | * from unwritten to real. Do allocations in a loop until |
| 862 | * we have covered the range passed in. | 793 | * we have covered the range passed in. |
| 794 | * | ||
| 795 | * Note that we open code the transaction allocation here | ||
| 796 | * to pass KM_NOFS--we can't risk to recursing back into | ||
| 797 | * the filesystem here as we might be asked to write out | ||
| 798 | * the same inode that we complete here and might deadlock | ||
| 799 | * on the iolock. | ||
| 863 | */ | 800 | */ |
| 864 | tp = xfs_trans_alloc(mp, XFS_TRANS_STRAT_WRITE); | 801 | xfs_wait_for_freeze(mp, SB_FREEZE_TRANS); |
| 802 | tp = _xfs_trans_alloc(mp, XFS_TRANS_STRAT_WRITE, KM_NOFS); | ||
| 865 | tp->t_flags |= XFS_TRANS_RESERVE; | 803 | tp->t_flags |= XFS_TRANS_RESERVE; |
| 866 | error = xfs_trans_reserve(tp, resblks, | 804 | error = xfs_trans_reserve(tp, resblks, |
| 867 | XFS_WRITE_LOG_RES(mp), 0, | 805 | XFS_WRITE_LOG_RES(mp), 0, |
diff --git a/fs/xfs/xfs_iomap.h b/fs/xfs/xfs_iomap.h index fdcf7b82747f..174f29990991 100644 --- a/fs/xfs/xfs_iomap.h +++ b/fs/xfs/xfs_iomap.h | |||
| @@ -43,6 +43,14 @@ typedef enum { | |||
| 43 | BMAPI_TRYLOCK = (1 << 7), /* non-blocking request */ | 43 | BMAPI_TRYLOCK = (1 << 7), /* non-blocking request */ |
| 44 | } bmapi_flags_t; | 44 | } bmapi_flags_t; |
| 45 | 45 | ||
| 46 | #define BMAPI_FLAGS \ | ||
| 47 | { BMAPI_READ, "READ" }, \ | ||
| 48 | { BMAPI_WRITE, "WRITE" }, \ | ||
| 49 | { BMAPI_ALLOCATE, "ALLOCATE" }, \ | ||
| 50 | { BMAPI_IGNSTATE, "IGNSTATE" }, \ | ||
| 51 | { BMAPI_DIRECT, "DIRECT" }, \ | ||
| 52 | { BMAPI_MMAP, "MMAP" }, \ | ||
| 53 | { BMAPI_TRYLOCK, "TRYLOCK" } | ||
| 46 | 54 | ||
| 47 | /* | 55 | /* |
| 48 | * xfs_iomap_t: File system I/O map | 56 | * xfs_iomap_t: File system I/O map |
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 9dbdff3ea484..4cb1792040e3 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
| @@ -40,6 +40,7 @@ | |||
| 40 | #include "xfs_dinode.h" | 40 | #include "xfs_dinode.h" |
| 41 | #include "xfs_inode.h" | 41 | #include "xfs_inode.h" |
| 42 | #include "xfs_rw.h" | 42 | #include "xfs_rw.h" |
| 43 | #include "xfs_trace.h" | ||
| 43 | 44 | ||
| 44 | kmem_zone_t *xfs_log_ticket_zone; | 45 | kmem_zone_t *xfs_log_ticket_zone; |
| 45 | 46 | ||
| @@ -122,85 +123,6 @@ STATIC void xlog_verify_tail_lsn(xlog_t *log, xlog_in_core_t *iclog, | |||
| 122 | 123 | ||
| 123 | STATIC int xlog_iclogs_empty(xlog_t *log); | 124 | STATIC int xlog_iclogs_empty(xlog_t *log); |
| 124 | 125 | ||
| 125 | #if defined(XFS_LOG_TRACE) | ||
| 126 | |||
| 127 | #define XLOG_TRACE_LOGGRANT_SIZE 2048 | ||
| 128 | #define XLOG_TRACE_ICLOG_SIZE 256 | ||
| 129 | |||
| 130 | void | ||
| 131 | xlog_trace_loggrant_alloc(xlog_t *log) | ||
| 132 | { | ||
| 133 | log->l_grant_trace = ktrace_alloc(XLOG_TRACE_LOGGRANT_SIZE, KM_NOFS); | ||
| 134 | } | ||
| 135 | |||
| 136 | void | ||
| 137 | xlog_trace_loggrant_dealloc(xlog_t *log) | ||
| 138 | { | ||
| 139 | ktrace_free(log->l_grant_trace); | ||
| 140 | } | ||
| 141 | |||
| 142 | void | ||
| 143 | xlog_trace_loggrant(xlog_t *log, xlog_ticket_t *tic, xfs_caddr_t string) | ||
| 144 | { | ||
| 145 | unsigned long cnts; | ||
| 146 | |||
| 147 | /* ticket counts are 1 byte each */ | ||
| 148 | cnts = ((unsigned long)tic->t_ocnt) | ((unsigned long)tic->t_cnt) << 8; | ||
| 149 | |||
| 150 | ktrace_enter(log->l_grant_trace, | ||
| 151 | (void *)tic, | ||
| 152 | (void *)log->l_reserve_headq, | ||
| 153 | (void *)log->l_write_headq, | ||
| 154 | (void *)((unsigned long)log->l_grant_reserve_cycle), | ||
| 155 | (void *)((unsigned long)log->l_grant_reserve_bytes), | ||
| 156 | (void *)((unsigned long)log->l_grant_write_cycle), | ||
| 157 | (void *)((unsigned long)log->l_grant_write_bytes), | ||
| 158 | (void *)((unsigned long)log->l_curr_cycle), | ||
| 159 | (void *)((unsigned long)log->l_curr_block), | ||
| 160 | (void *)((unsigned long)CYCLE_LSN(log->l_tail_lsn)), | ||
| 161 | (void *)((unsigned long)BLOCK_LSN(log->l_tail_lsn)), | ||
| 162 | (void *)string, | ||
| 163 | (void *)((unsigned long)tic->t_trans_type), | ||
| 164 | (void *)cnts, | ||
| 165 | (void *)((unsigned long)tic->t_curr_res), | ||
| 166 | (void *)((unsigned long)tic->t_unit_res)); | ||
| 167 | } | ||
| 168 | |||
| 169 | void | ||
| 170 | xlog_trace_iclog_alloc(xlog_in_core_t *iclog) | ||
| 171 | { | ||
| 172 | iclog->ic_trace = ktrace_alloc(XLOG_TRACE_ICLOG_SIZE, KM_NOFS); | ||
| 173 | } | ||
| 174 | |||
| 175 | void | ||
| 176 | xlog_trace_iclog_dealloc(xlog_in_core_t *iclog) | ||
| 177 | { | ||
| 178 | ktrace_free(iclog->ic_trace); | ||
| 179 | } | ||
| 180 | |||
| 181 | void | ||
| 182 | xlog_trace_iclog(xlog_in_core_t *iclog, uint state) | ||
| 183 | { | ||
| 184 | ktrace_enter(iclog->ic_trace, | ||
| 185 | (void *)((unsigned long)state), | ||
| 186 | (void *)((unsigned long)current_pid()), | ||
| 187 | (void *)NULL, (void *)NULL, (void *)NULL, (void *)NULL, | ||
| 188 | (void *)NULL, (void *)NULL, (void *)NULL, (void *)NULL, | ||
| 189 | (void *)NULL, (void *)NULL, (void *)NULL, (void *)NULL, | ||
| 190 | (void *)NULL, (void *)NULL); | ||
| 191 | } | ||
| 192 | #else | ||
| 193 | |||
| 194 | #define xlog_trace_loggrant_alloc(log) | ||
| 195 | #define xlog_trace_loggrant_dealloc(log) | ||
| 196 | #define xlog_trace_loggrant(log,tic,string) | ||
| 197 | |||
| 198 | #define xlog_trace_iclog_alloc(iclog) | ||
| 199 | #define xlog_trace_iclog_dealloc(iclog) | ||
| 200 | #define xlog_trace_iclog(iclog,state) | ||
| 201 | |||
| 202 | #endif /* XFS_LOG_TRACE */ | ||
| 203 | |||
| 204 | 126 | ||
| 205 | static void | 127 | static void |
| 206 | xlog_ins_ticketq(struct xlog_ticket **qp, struct xlog_ticket *tic) | 128 | xlog_ins_ticketq(struct xlog_ticket **qp, struct xlog_ticket *tic) |
| @@ -353,15 +275,17 @@ xfs_log_done(xfs_mount_t *mp, | |||
| 353 | 275 | ||
| 354 | if ((ticket->t_flags & XLOG_TIC_PERM_RESERV) == 0 || | 276 | if ((ticket->t_flags & XLOG_TIC_PERM_RESERV) == 0 || |
| 355 | (flags & XFS_LOG_REL_PERM_RESERV)) { | 277 | (flags & XFS_LOG_REL_PERM_RESERV)) { |
| 278 | trace_xfs_log_done_nonperm(log, ticket); | ||
| 279 | |||
| 356 | /* | 280 | /* |
| 357 | * Release ticket if not permanent reservation or a specific | 281 | * Release ticket if not permanent reservation or a specific |
| 358 | * request has been made to release a permanent reservation. | 282 | * request has been made to release a permanent reservation. |
| 359 | */ | 283 | */ |
| 360 | xlog_trace_loggrant(log, ticket, "xfs_log_done: (non-permanent)"); | ||
| 361 | xlog_ungrant_log_space(log, ticket); | 284 | xlog_ungrant_log_space(log, ticket); |
| 362 | xfs_log_ticket_put(ticket); | 285 | xfs_log_ticket_put(ticket); |
| 363 | } else { | 286 | } else { |
| 364 | xlog_trace_loggrant(log, ticket, "xfs_log_done: (permanent)"); | 287 | trace_xfs_log_done_perm(log, ticket); |
| 288 | |||
| 365 | xlog_regrant_reserve_log_space(log, ticket); | 289 | xlog_regrant_reserve_log_space(log, ticket); |
| 366 | /* If this ticket was a permanent reservation and we aren't | 290 | /* If this ticket was a permanent reservation and we aren't |
| 367 | * trying to release it, reset the inited flags; so next time | 291 | * trying to release it, reset the inited flags; so next time |
| @@ -505,10 +429,13 @@ xfs_log_reserve(xfs_mount_t *mp, | |||
| 505 | 429 | ||
| 506 | XFS_STATS_INC(xs_try_logspace); | 430 | XFS_STATS_INC(xs_try_logspace); |
| 507 | 431 | ||
| 432 | |||
| 508 | if (*ticket != NULL) { | 433 | if (*ticket != NULL) { |
| 509 | ASSERT(flags & XFS_LOG_PERM_RESERV); | 434 | ASSERT(flags & XFS_LOG_PERM_RESERV); |
| 510 | internal_ticket = (xlog_ticket_t *)*ticket; | 435 | internal_ticket = (xlog_ticket_t *)*ticket; |
| 511 | xlog_trace_loggrant(log, internal_ticket, "xfs_log_reserve: existing ticket (permanent trans)"); | 436 | |
| 437 | trace_xfs_log_reserve(log, internal_ticket); | ||
| 438 | |||
| 512 | xlog_grant_push_ail(mp, internal_ticket->t_unit_res); | 439 | xlog_grant_push_ail(mp, internal_ticket->t_unit_res); |
| 513 | retval = xlog_regrant_write_log_space(log, internal_ticket); | 440 | retval = xlog_regrant_write_log_space(log, internal_ticket); |
| 514 | } else { | 441 | } else { |
| @@ -519,10 +446,9 @@ xfs_log_reserve(xfs_mount_t *mp, | |||
| 519 | return XFS_ERROR(ENOMEM); | 446 | return XFS_ERROR(ENOMEM); |
| 520 | internal_ticket->t_trans_type = t_type; | 447 | internal_ticket->t_trans_type = t_type; |
| 521 | *ticket = internal_ticket; | 448 | *ticket = internal_ticket; |
| 522 | xlog_trace_loggrant(log, internal_ticket, | 449 | |
| 523 | (internal_ticket->t_flags & XLOG_TIC_PERM_RESERV) ? | 450 | trace_xfs_log_reserve(log, internal_ticket); |
| 524 | "xfs_log_reserve: create new ticket (permanent trans)" : | 451 | |
| 525 | "xfs_log_reserve: create new ticket"); | ||
| 526 | xlog_grant_push_ail(mp, | 452 | xlog_grant_push_ail(mp, |
| 527 | (internal_ticket->t_unit_res * | 453 | (internal_ticket->t_unit_res * |
| 528 | internal_ticket->t_cnt)); | 454 | internal_ticket->t_cnt)); |
| @@ -734,7 +660,7 @@ xfs_log_unmount_write(xfs_mount_t *mp) | |||
| 734 | spin_unlock(&log->l_icloglock); | 660 | spin_unlock(&log->l_icloglock); |
| 735 | } | 661 | } |
| 736 | if (tic) { | 662 | if (tic) { |
| 737 | xlog_trace_loggrant(log, tic, "unmount rec"); | 663 | trace_xfs_log_umount_write(log, tic); |
| 738 | xlog_ungrant_log_space(log, tic); | 664 | xlog_ungrant_log_space(log, tic); |
| 739 | xfs_log_ticket_put(tic); | 665 | xfs_log_ticket_put(tic); |
| 740 | } | 666 | } |
| @@ -1030,7 +956,6 @@ xlog_iodone(xfs_buf_t *bp) | |||
| 1030 | xfs_fs_cmn_err(CE_WARN, l->l_mp, | 956 | xfs_fs_cmn_err(CE_WARN, l->l_mp, |
| 1031 | "xlog_iodone: Barriers are no longer supported" | 957 | "xlog_iodone: Barriers are no longer supported" |
| 1032 | " by device. Disabling barriers\n"); | 958 | " by device. Disabling barriers\n"); |
| 1033 | xfs_buftrace("XLOG_IODONE BARRIERS OFF", bp); | ||
| 1034 | } | 959 | } |
| 1035 | 960 | ||
| 1036 | /* | 961 | /* |
| @@ -1085,13 +1010,10 @@ xlog_bdstrat_cb(struct xfs_buf *bp) | |||
| 1085 | return 0; | 1010 | return 0; |
| 1086 | } | 1011 | } |
| 1087 | 1012 | ||
| 1088 | xfs_buftrace("XLOG__BDSTRAT IOERROR", bp); | ||
| 1089 | XFS_BUF_ERROR(bp, EIO); | 1013 | XFS_BUF_ERROR(bp, EIO); |
| 1090 | XFS_BUF_STALE(bp); | 1014 | XFS_BUF_STALE(bp); |
| 1091 | xfs_biodone(bp); | 1015 | xfs_biodone(bp); |
| 1092 | return XFS_ERROR(EIO); | 1016 | return XFS_ERROR(EIO); |
| 1093 | |||
| 1094 | |||
| 1095 | } | 1017 | } |
| 1096 | 1018 | ||
| 1097 | /* | 1019 | /* |
| @@ -1246,7 +1168,6 @@ xlog_alloc_log(xfs_mount_t *mp, | |||
| 1246 | spin_lock_init(&log->l_grant_lock); | 1168 | spin_lock_init(&log->l_grant_lock); |
| 1247 | sv_init(&log->l_flush_wait, 0, "flush_wait"); | 1169 | sv_init(&log->l_flush_wait, 0, "flush_wait"); |
| 1248 | 1170 | ||
| 1249 | xlog_trace_loggrant_alloc(log); | ||
| 1250 | /* log record size must be multiple of BBSIZE; see xlog_rec_header_t */ | 1171 | /* log record size must be multiple of BBSIZE; see xlog_rec_header_t */ |
| 1251 | ASSERT((XFS_BUF_SIZE(bp) & BBMASK) == 0); | 1172 | ASSERT((XFS_BUF_SIZE(bp) & BBMASK) == 0); |
| 1252 | 1173 | ||
| @@ -1305,8 +1226,6 @@ xlog_alloc_log(xfs_mount_t *mp, | |||
| 1305 | sv_init(&iclog->ic_force_wait, SV_DEFAULT, "iclog-force"); | 1226 | sv_init(&iclog->ic_force_wait, SV_DEFAULT, "iclog-force"); |
| 1306 | sv_init(&iclog->ic_write_wait, SV_DEFAULT, "iclog-write"); | 1227 | sv_init(&iclog->ic_write_wait, SV_DEFAULT, "iclog-write"); |
| 1307 | 1228 | ||
| 1308 | xlog_trace_iclog_alloc(iclog); | ||
| 1309 | |||
| 1310 | iclogp = &iclog->ic_next; | 1229 | iclogp = &iclog->ic_next; |
| 1311 | } | 1230 | } |
| 1312 | *iclogp = log->l_iclog; /* complete ring */ | 1231 | *iclogp = log->l_iclog; /* complete ring */ |
| @@ -1321,13 +1240,11 @@ out_free_iclog: | |||
| 1321 | sv_destroy(&iclog->ic_force_wait); | 1240 | sv_destroy(&iclog->ic_force_wait); |
| 1322 | sv_destroy(&iclog->ic_write_wait); | 1241 | sv_destroy(&iclog->ic_write_wait); |
| 1323 | xfs_buf_free(iclog->ic_bp); | 1242 | xfs_buf_free(iclog->ic_bp); |
| 1324 | xlog_trace_iclog_dealloc(iclog); | ||
| 1325 | } | 1243 | } |
| 1326 | kmem_free(iclog); | 1244 | kmem_free(iclog); |
| 1327 | } | 1245 | } |
| 1328 | spinlock_destroy(&log->l_icloglock); | 1246 | spinlock_destroy(&log->l_icloglock); |
| 1329 | spinlock_destroy(&log->l_grant_lock); | 1247 | spinlock_destroy(&log->l_grant_lock); |
| 1330 | xlog_trace_loggrant_dealloc(log); | ||
| 1331 | xfs_buf_free(log->l_xbuf); | 1248 | xfs_buf_free(log->l_xbuf); |
| 1332 | out_free_log: | 1249 | out_free_log: |
| 1333 | kmem_free(log); | 1250 | kmem_free(log); |
| @@ -1607,7 +1524,6 @@ xlog_dealloc_log(xlog_t *log) | |||
| 1607 | sv_destroy(&iclog->ic_force_wait); | 1524 | sv_destroy(&iclog->ic_force_wait); |
| 1608 | sv_destroy(&iclog->ic_write_wait); | 1525 | sv_destroy(&iclog->ic_write_wait); |
| 1609 | xfs_buf_free(iclog->ic_bp); | 1526 | xfs_buf_free(iclog->ic_bp); |
| 1610 | xlog_trace_iclog_dealloc(iclog); | ||
| 1611 | next_iclog = iclog->ic_next; | 1527 | next_iclog = iclog->ic_next; |
| 1612 | kmem_free(iclog); | 1528 | kmem_free(iclog); |
| 1613 | iclog = next_iclog; | 1529 | iclog = next_iclog; |
| @@ -1616,7 +1532,6 @@ xlog_dealloc_log(xlog_t *log) | |||
| 1616 | spinlock_destroy(&log->l_grant_lock); | 1532 | spinlock_destroy(&log->l_grant_lock); |
| 1617 | 1533 | ||
| 1618 | xfs_buf_free(log->l_xbuf); | 1534 | xfs_buf_free(log->l_xbuf); |
| 1619 | xlog_trace_loggrant_dealloc(log); | ||
| 1620 | log->l_mp->m_log = NULL; | 1535 | log->l_mp->m_log = NULL; |
| 1621 | kmem_free(log); | 1536 | kmem_free(log); |
| 1622 | } /* xlog_dealloc_log */ | 1537 | } /* xlog_dealloc_log */ |
| @@ -2414,7 +2329,6 @@ restart: | |||
| 2414 | 2329 | ||
| 2415 | iclog = log->l_iclog; | 2330 | iclog = log->l_iclog; |
| 2416 | if (iclog->ic_state != XLOG_STATE_ACTIVE) { | 2331 | if (iclog->ic_state != XLOG_STATE_ACTIVE) { |
| 2417 | xlog_trace_iclog(iclog, XLOG_TRACE_SLEEP_FLUSH); | ||
| 2418 | XFS_STATS_INC(xs_log_noiclogs); | 2332 | XFS_STATS_INC(xs_log_noiclogs); |
| 2419 | 2333 | ||
| 2420 | /* Wait for log writes to have flushed */ | 2334 | /* Wait for log writes to have flushed */ |
| @@ -2520,13 +2434,15 @@ xlog_grant_log_space(xlog_t *log, | |||
| 2520 | 2434 | ||
| 2521 | /* Is there space or do we need to sleep? */ | 2435 | /* Is there space or do we need to sleep? */ |
| 2522 | spin_lock(&log->l_grant_lock); | 2436 | spin_lock(&log->l_grant_lock); |
| 2523 | xlog_trace_loggrant(log, tic, "xlog_grant_log_space: enter"); | 2437 | |
| 2438 | trace_xfs_log_grant_enter(log, tic); | ||
| 2524 | 2439 | ||
| 2525 | /* something is already sleeping; insert new transaction at end */ | 2440 | /* something is already sleeping; insert new transaction at end */ |
| 2526 | if (log->l_reserve_headq) { | 2441 | if (log->l_reserve_headq) { |
| 2527 | xlog_ins_ticketq(&log->l_reserve_headq, tic); | 2442 | xlog_ins_ticketq(&log->l_reserve_headq, tic); |
| 2528 | xlog_trace_loggrant(log, tic, | 2443 | |
| 2529 | "xlog_grant_log_space: sleep 1"); | 2444 | trace_xfs_log_grant_sleep1(log, tic); |
| 2445 | |||
| 2530 | /* | 2446 | /* |
| 2531 | * Gotta check this before going to sleep, while we're | 2447 | * Gotta check this before going to sleep, while we're |
| 2532 | * holding the grant lock. | 2448 | * holding the grant lock. |
| @@ -2540,8 +2456,7 @@ xlog_grant_log_space(xlog_t *log, | |||
| 2540 | * If we got an error, and the filesystem is shutting down, | 2456 | * If we got an error, and the filesystem is shutting down, |
| 2541 | * we'll catch it down below. So just continue... | 2457 | * we'll catch it down below. So just continue... |
| 2542 | */ | 2458 | */ |
| 2543 | xlog_trace_loggrant(log, tic, | 2459 | trace_xfs_log_grant_wake1(log, tic); |
| 2544 | "xlog_grant_log_space: wake 1"); | ||
| 2545 | spin_lock(&log->l_grant_lock); | 2460 | spin_lock(&log->l_grant_lock); |
| 2546 | } | 2461 | } |
| 2547 | if (tic->t_flags & XFS_LOG_PERM_RESERV) | 2462 | if (tic->t_flags & XFS_LOG_PERM_RESERV) |
| @@ -2558,8 +2473,9 @@ redo: | |||
| 2558 | if (free_bytes < need_bytes) { | 2473 | if (free_bytes < need_bytes) { |
| 2559 | if ((tic->t_flags & XLOG_TIC_IN_Q) == 0) | 2474 | if ((tic->t_flags & XLOG_TIC_IN_Q) == 0) |
| 2560 | xlog_ins_ticketq(&log->l_reserve_headq, tic); | 2475 | xlog_ins_ticketq(&log->l_reserve_headq, tic); |
| 2561 | xlog_trace_loggrant(log, tic, | 2476 | |
| 2562 | "xlog_grant_log_space: sleep 2"); | 2477 | trace_xfs_log_grant_sleep2(log, tic); |
| 2478 | |||
| 2563 | spin_unlock(&log->l_grant_lock); | 2479 | spin_unlock(&log->l_grant_lock); |
| 2564 | xlog_grant_push_ail(log->l_mp, need_bytes); | 2480 | xlog_grant_push_ail(log->l_mp, need_bytes); |
| 2565 | spin_lock(&log->l_grant_lock); | 2481 | spin_lock(&log->l_grant_lock); |
| @@ -2571,8 +2487,8 @@ redo: | |||
| 2571 | if (XLOG_FORCED_SHUTDOWN(log)) | 2487 | if (XLOG_FORCED_SHUTDOWN(log)) |
| 2572 | goto error_return; | 2488 | goto error_return; |
| 2573 | 2489 | ||
| 2574 | xlog_trace_loggrant(log, tic, | 2490 | trace_xfs_log_grant_wake2(log, tic); |
| 2575 | "xlog_grant_log_space: wake 2"); | 2491 | |
| 2576 | goto redo; | 2492 | goto redo; |
| 2577 | } else if (tic->t_flags & XLOG_TIC_IN_Q) | 2493 | } else if (tic->t_flags & XLOG_TIC_IN_Q) |
| 2578 | xlog_del_ticketq(&log->l_reserve_headq, tic); | 2494 | xlog_del_ticketq(&log->l_reserve_headq, tic); |
| @@ -2592,7 +2508,7 @@ redo: | |||
| 2592 | ASSERT(log->l_grant_write_bytes <= BBTOB(BLOCK_LSN(tail_lsn))); | 2508 | ASSERT(log->l_grant_write_bytes <= BBTOB(BLOCK_LSN(tail_lsn))); |
| 2593 | } | 2509 | } |
| 2594 | #endif | 2510 | #endif |
| 2595 | xlog_trace_loggrant(log, tic, "xlog_grant_log_space: exit"); | 2511 | trace_xfs_log_grant_exit(log, tic); |
| 2596 | xlog_verify_grant_head(log, 1); | 2512 | xlog_verify_grant_head(log, 1); |
| 2597 | spin_unlock(&log->l_grant_lock); | 2513 | spin_unlock(&log->l_grant_lock); |
| 2598 | return 0; | 2514 | return 0; |
| @@ -2600,7 +2516,9 @@ redo: | |||
| 2600 | error_return: | 2516 | error_return: |
| 2601 | if (tic->t_flags & XLOG_TIC_IN_Q) | 2517 | if (tic->t_flags & XLOG_TIC_IN_Q) |
| 2602 | xlog_del_ticketq(&log->l_reserve_headq, tic); | 2518 | xlog_del_ticketq(&log->l_reserve_headq, tic); |
| 2603 | xlog_trace_loggrant(log, tic, "xlog_grant_log_space: err_ret"); | 2519 | |
| 2520 | trace_xfs_log_grant_error(log, tic); | ||
| 2521 | |||
| 2604 | /* | 2522 | /* |
| 2605 | * If we are failing, make sure the ticket doesn't have any | 2523 | * If we are failing, make sure the ticket doesn't have any |
| 2606 | * current reservations. We don't want to add this back when | 2524 | * current reservations. We don't want to add this back when |
| @@ -2640,7 +2558,8 @@ xlog_regrant_write_log_space(xlog_t *log, | |||
| 2640 | #endif | 2558 | #endif |
| 2641 | 2559 | ||
| 2642 | spin_lock(&log->l_grant_lock); | 2560 | spin_lock(&log->l_grant_lock); |
| 2643 | xlog_trace_loggrant(log, tic, "xlog_regrant_write_log_space: enter"); | 2561 | |
| 2562 | trace_xfs_log_regrant_write_enter(log, tic); | ||
| 2644 | 2563 | ||
| 2645 | if (XLOG_FORCED_SHUTDOWN(log)) | 2564 | if (XLOG_FORCED_SHUTDOWN(log)) |
| 2646 | goto error_return; | 2565 | goto error_return; |
| @@ -2669,8 +2588,8 @@ xlog_regrant_write_log_space(xlog_t *log, | |||
| 2669 | if ((tic->t_flags & XLOG_TIC_IN_Q) == 0) | 2588 | if ((tic->t_flags & XLOG_TIC_IN_Q) == 0) |
| 2670 | xlog_ins_ticketq(&log->l_write_headq, tic); | 2589 | xlog_ins_ticketq(&log->l_write_headq, tic); |
| 2671 | 2590 | ||
| 2672 | xlog_trace_loggrant(log, tic, | 2591 | trace_xfs_log_regrant_write_sleep1(log, tic); |
| 2673 | "xlog_regrant_write_log_space: sleep 1"); | 2592 | |
| 2674 | spin_unlock(&log->l_grant_lock); | 2593 | spin_unlock(&log->l_grant_lock); |
| 2675 | xlog_grant_push_ail(log->l_mp, need_bytes); | 2594 | xlog_grant_push_ail(log->l_mp, need_bytes); |
| 2676 | spin_lock(&log->l_grant_lock); | 2595 | spin_lock(&log->l_grant_lock); |
| @@ -2685,8 +2604,7 @@ xlog_regrant_write_log_space(xlog_t *log, | |||
| 2685 | if (XLOG_FORCED_SHUTDOWN(log)) | 2604 | if (XLOG_FORCED_SHUTDOWN(log)) |
| 2686 | goto error_return; | 2605 | goto error_return; |
| 2687 | 2606 | ||
| 2688 | xlog_trace_loggrant(log, tic, | 2607 | trace_xfs_log_regrant_write_wake1(log, tic); |
| 2689 | "xlog_regrant_write_log_space: wake 1"); | ||
| 2690 | } | 2608 | } |
| 2691 | } | 2609 | } |
| 2692 | 2610 | ||
| @@ -2704,6 +2622,8 @@ redo: | |||
| 2704 | spin_lock(&log->l_grant_lock); | 2622 | spin_lock(&log->l_grant_lock); |
| 2705 | 2623 | ||
| 2706 | XFS_STATS_INC(xs_sleep_logspace); | 2624 | XFS_STATS_INC(xs_sleep_logspace); |
| 2625 | trace_xfs_log_regrant_write_sleep2(log, tic); | ||
| 2626 | |||
| 2707 | sv_wait(&tic->t_wait, PINOD|PLTWAIT, &log->l_grant_lock, s); | 2627 | sv_wait(&tic->t_wait, PINOD|PLTWAIT, &log->l_grant_lock, s); |
| 2708 | 2628 | ||
| 2709 | /* If we're shutting down, this tic is already off the queue */ | 2629 | /* If we're shutting down, this tic is already off the queue */ |
| @@ -2711,8 +2631,7 @@ redo: | |||
| 2711 | if (XLOG_FORCED_SHUTDOWN(log)) | 2631 | if (XLOG_FORCED_SHUTDOWN(log)) |
| 2712 | goto error_return; | 2632 | goto error_return; |
| 2713 | 2633 | ||
| 2714 | xlog_trace_loggrant(log, tic, | 2634 | trace_xfs_log_regrant_write_wake2(log, tic); |
| 2715 | "xlog_regrant_write_log_space: wake 2"); | ||
| 2716 | goto redo; | 2635 | goto redo; |
| 2717 | } else if (tic->t_flags & XLOG_TIC_IN_Q) | 2636 | } else if (tic->t_flags & XLOG_TIC_IN_Q) |
| 2718 | xlog_del_ticketq(&log->l_write_headq, tic); | 2637 | xlog_del_ticketq(&log->l_write_headq, tic); |
| @@ -2727,7 +2646,8 @@ redo: | |||
| 2727 | } | 2646 | } |
| 2728 | #endif | 2647 | #endif |
| 2729 | 2648 | ||
| 2730 | xlog_trace_loggrant(log, tic, "xlog_regrant_write_log_space: exit"); | 2649 | trace_xfs_log_regrant_write_exit(log, tic); |
| 2650 | |||
| 2731 | xlog_verify_grant_head(log, 1); | 2651 | xlog_verify_grant_head(log, 1); |
| 2732 | spin_unlock(&log->l_grant_lock); | 2652 | spin_unlock(&log->l_grant_lock); |
| 2733 | return 0; | 2653 | return 0; |
| @@ -2736,7 +2656,9 @@ redo: | |||
| 2736 | error_return: | 2656 | error_return: |
| 2737 | if (tic->t_flags & XLOG_TIC_IN_Q) | 2657 | if (tic->t_flags & XLOG_TIC_IN_Q) |
| 2738 | xlog_del_ticketq(&log->l_reserve_headq, tic); | 2658 | xlog_del_ticketq(&log->l_reserve_headq, tic); |
| 2739 | xlog_trace_loggrant(log, tic, "xlog_regrant_write_log_space: err_ret"); | 2659 | |
| 2660 | trace_xfs_log_regrant_write_error(log, tic); | ||
| 2661 | |||
| 2740 | /* | 2662 | /* |
| 2741 | * If we are failing, make sure the ticket doesn't have any | 2663 | * If we are failing, make sure the ticket doesn't have any |
| 2742 | * current reservations. We don't want to add this back when | 2664 | * current reservations. We don't want to add this back when |
| @@ -2760,8 +2682,8 @@ STATIC void | |||
| 2760 | xlog_regrant_reserve_log_space(xlog_t *log, | 2682 | xlog_regrant_reserve_log_space(xlog_t *log, |
| 2761 | xlog_ticket_t *ticket) | 2683 | xlog_ticket_t *ticket) |
| 2762 | { | 2684 | { |
| 2763 | xlog_trace_loggrant(log, ticket, | 2685 | trace_xfs_log_regrant_reserve_enter(log, ticket); |
| 2764 | "xlog_regrant_reserve_log_space: enter"); | 2686 | |
| 2765 | if (ticket->t_cnt > 0) | 2687 | if (ticket->t_cnt > 0) |
| 2766 | ticket->t_cnt--; | 2688 | ticket->t_cnt--; |
| 2767 | 2689 | ||
| @@ -2769,8 +2691,9 @@ xlog_regrant_reserve_log_space(xlog_t *log, | |||
| 2769 | xlog_grant_sub_space(log, ticket->t_curr_res); | 2691 | xlog_grant_sub_space(log, ticket->t_curr_res); |
| 2770 | ticket->t_curr_res = ticket->t_unit_res; | 2692 | ticket->t_curr_res = ticket->t_unit_res; |
| 2771 | xlog_tic_reset_res(ticket); | 2693 | xlog_tic_reset_res(ticket); |
| 2772 | xlog_trace_loggrant(log, ticket, | 2694 | |
| 2773 | "xlog_regrant_reserve_log_space: sub current res"); | 2695 | trace_xfs_log_regrant_reserve_sub(log, ticket); |
| 2696 | |||
| 2774 | xlog_verify_grant_head(log, 1); | 2697 | xlog_verify_grant_head(log, 1); |
| 2775 | 2698 | ||
| 2776 | /* just return if we still have some of the pre-reserved space */ | 2699 | /* just return if we still have some of the pre-reserved space */ |
| @@ -2780,8 +2703,9 @@ xlog_regrant_reserve_log_space(xlog_t *log, | |||
| 2780 | } | 2703 | } |
| 2781 | 2704 | ||
| 2782 | xlog_grant_add_space_reserve(log, ticket->t_unit_res); | 2705 | xlog_grant_add_space_reserve(log, ticket->t_unit_res); |
| 2783 | xlog_trace_loggrant(log, ticket, | 2706 | |
| 2784 | "xlog_regrant_reserve_log_space: exit"); | 2707 | trace_xfs_log_regrant_reserve_exit(log, ticket); |
| 2708 | |||
| 2785 | xlog_verify_grant_head(log, 0); | 2709 | xlog_verify_grant_head(log, 0); |
| 2786 | spin_unlock(&log->l_grant_lock); | 2710 | spin_unlock(&log->l_grant_lock); |
| 2787 | ticket->t_curr_res = ticket->t_unit_res; | 2711 | ticket->t_curr_res = ticket->t_unit_res; |
| @@ -2811,11 +2735,11 @@ xlog_ungrant_log_space(xlog_t *log, | |||
| 2811 | ticket->t_cnt--; | 2735 | ticket->t_cnt--; |
| 2812 | 2736 | ||
| 2813 | spin_lock(&log->l_grant_lock); | 2737 | spin_lock(&log->l_grant_lock); |
| 2814 | xlog_trace_loggrant(log, ticket, "xlog_ungrant_log_space: enter"); | 2738 | trace_xfs_log_ungrant_enter(log, ticket); |
| 2815 | 2739 | ||
| 2816 | xlog_grant_sub_space(log, ticket->t_curr_res); | 2740 | xlog_grant_sub_space(log, ticket->t_curr_res); |
| 2817 | 2741 | ||
| 2818 | xlog_trace_loggrant(log, ticket, "xlog_ungrant_log_space: sub current"); | 2742 | trace_xfs_log_ungrant_sub(log, ticket); |
| 2819 | 2743 | ||
| 2820 | /* If this is a permanent reservation ticket, we may be able to free | 2744 | /* If this is a permanent reservation ticket, we may be able to free |
| 2821 | * up more space based on the remaining count. | 2745 | * up more space based on the remaining count. |
| @@ -2825,7 +2749,8 @@ xlog_ungrant_log_space(xlog_t *log, | |||
| 2825 | xlog_grant_sub_space(log, ticket->t_unit_res*ticket->t_cnt); | 2749 | xlog_grant_sub_space(log, ticket->t_unit_res*ticket->t_cnt); |
| 2826 | } | 2750 | } |
| 2827 | 2751 | ||
| 2828 | xlog_trace_loggrant(log, ticket, "xlog_ungrant_log_space: exit"); | 2752 | trace_xfs_log_ungrant_exit(log, ticket); |
| 2753 | |||
| 2829 | xlog_verify_grant_head(log, 1); | 2754 | xlog_verify_grant_head(log, 1); |
| 2830 | spin_unlock(&log->l_grant_lock); | 2755 | spin_unlock(&log->l_grant_lock); |
| 2831 | xfs_log_move_tail(log->l_mp, 1); | 2756 | xfs_log_move_tail(log->l_mp, 1); |
diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h index 679c7c4926a2..d55662db7077 100644 --- a/fs/xfs/xfs_log_priv.h +++ b/fs/xfs/xfs_log_priv.h | |||
| @@ -19,7 +19,6 @@ | |||
| 19 | #define __XFS_LOG_PRIV_H__ | 19 | #define __XFS_LOG_PRIV_H__ |
| 20 | 20 | ||
| 21 | struct xfs_buf; | 21 | struct xfs_buf; |
| 22 | struct ktrace; | ||
| 23 | struct log; | 22 | struct log; |
| 24 | struct xlog_ticket; | 23 | struct xlog_ticket; |
| 25 | struct xfs_buf_cancel; | 24 | struct xfs_buf_cancel; |
| @@ -135,6 +134,12 @@ static inline uint xlog_get_client_id(__be32 i) | |||
| 135 | #define XLOG_TIC_INITED 0x1 /* has been initialized */ | 134 | #define XLOG_TIC_INITED 0x1 /* has been initialized */ |
| 136 | #define XLOG_TIC_PERM_RESERV 0x2 /* permanent reservation */ | 135 | #define XLOG_TIC_PERM_RESERV 0x2 /* permanent reservation */ |
| 137 | #define XLOG_TIC_IN_Q 0x4 | 136 | #define XLOG_TIC_IN_Q 0x4 |
| 137 | |||
| 138 | #define XLOG_TIC_FLAGS \ | ||
| 139 | { XLOG_TIC_INITED, "XLOG_TIC_INITED" }, \ | ||
| 140 | { XLOG_TIC_PERM_RESERV, "XLOG_TIC_PERM_RESERV" }, \ | ||
| 141 | { XLOG_TIC_IN_Q, "XLOG_TIC_IN_Q" } | ||
| 142 | |||
| 138 | #endif /* __KERNEL__ */ | 143 | #endif /* __KERNEL__ */ |
| 139 | 144 | ||
| 140 | #define XLOG_UNMOUNT_TYPE 0x556e /* Un for Unmount */ | 145 | #define XLOG_UNMOUNT_TYPE 0x556e /* Un for Unmount */ |
| @@ -361,9 +366,6 @@ typedef struct xlog_in_core { | |||
| 361 | int ic_bwritecnt; | 366 | int ic_bwritecnt; |
| 362 | unsigned short ic_state; | 367 | unsigned short ic_state; |
| 363 | char *ic_datap; /* pointer to iclog data */ | 368 | char *ic_datap; /* pointer to iclog data */ |
| 364 | #ifdef XFS_LOG_TRACE | ||
| 365 | struct ktrace *ic_trace; | ||
| 366 | #endif | ||
| 367 | 369 | ||
| 368 | /* Callback structures need their own cacheline */ | 370 | /* Callback structures need their own cacheline */ |
| 369 | spinlock_t ic_callback_lock ____cacheline_aligned_in_smp; | 371 | spinlock_t ic_callback_lock ____cacheline_aligned_in_smp; |
| @@ -429,10 +431,6 @@ typedef struct log { | |||
| 429 | int l_grant_write_cycle; | 431 | int l_grant_write_cycle; |
| 430 | int l_grant_write_bytes; | 432 | int l_grant_write_bytes; |
| 431 | 433 | ||
| 432 | #ifdef XFS_LOG_TRACE | ||
| 433 | struct ktrace *l_grant_trace; | ||
| 434 | #endif | ||
| 435 | |||
| 436 | /* The following field are used for debugging; need to hold icloglock */ | 434 | /* The following field are used for debugging; need to hold icloglock */ |
| 437 | #ifdef DEBUG | 435 | #ifdef DEBUG |
| 438 | char *l_iclog_bak[XLOG_MAX_ICLOGS]; | 436 | char *l_iclog_bak[XLOG_MAX_ICLOGS]; |
| @@ -456,12 +454,6 @@ extern void xlog_put_bp(struct xfs_buf *); | |||
| 456 | 454 | ||
| 457 | extern kmem_zone_t *xfs_log_ticket_zone; | 455 | extern kmem_zone_t *xfs_log_ticket_zone; |
| 458 | 456 | ||
| 459 | /* iclog tracing */ | ||
| 460 | #define XLOG_TRACE_GRAB_FLUSH 1 | ||
| 461 | #define XLOG_TRACE_REL_FLUSH 2 | ||
| 462 | #define XLOG_TRACE_SLEEP_FLUSH 3 | ||
| 463 | #define XLOG_TRACE_WAKE_FLUSH 4 | ||
| 464 | |||
| 465 | /* | 457 | /* |
| 466 | * Unmount record type is used as a pseudo transaction type for the ticket. | 458 | * Unmount record type is used as a pseudo transaction type for the ticket. |
| 467 | * It's value must be outside the range of XFS_TRANS_* values. | 459 | * It's value must be outside the range of XFS_TRANS_* values. |
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index fb17f8226b09..69ac2e5ef20c 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c | |||
| @@ -46,6 +46,7 @@ | |||
| 46 | #include "xfs_quota.h" | 46 | #include "xfs_quota.h" |
| 47 | #include "xfs_rw.h" | 47 | #include "xfs_rw.h" |
| 48 | #include "xfs_utils.h" | 48 | #include "xfs_utils.h" |
| 49 | #include "xfs_trace.h" | ||
| 49 | 50 | ||
| 50 | STATIC int xlog_find_zeroed(xlog_t *, xfs_daddr_t *); | 51 | STATIC int xlog_find_zeroed(xlog_t *, xfs_daddr_t *); |
| 51 | STATIC int xlog_clear_stale_blocks(xlog_t *, xfs_lsn_t); | 52 | STATIC int xlog_clear_stale_blocks(xlog_t *, xfs_lsn_t); |
| @@ -225,16 +226,10 @@ xlog_header_check_dump( | |||
| 225 | xfs_mount_t *mp, | 226 | xfs_mount_t *mp, |
| 226 | xlog_rec_header_t *head) | 227 | xlog_rec_header_t *head) |
| 227 | { | 228 | { |
| 228 | int b; | 229 | cmn_err(CE_DEBUG, "%s: SB : uuid = %pU, fmt = %d\n", |
| 229 | 230 | __func__, &mp->m_sb.sb_uuid, XLOG_FMT); | |
| 230 | cmn_err(CE_DEBUG, "%s: SB : uuid = ", __func__); | 231 | cmn_err(CE_DEBUG, " log : uuid = %pU, fmt = %d\n", |
| 231 | for (b = 0; b < 16; b++) | 232 | &head->h_fs_uuid, be32_to_cpu(head->h_fmt)); |
| 232 | cmn_err(CE_DEBUG, "%02x", ((__uint8_t *)&mp->m_sb.sb_uuid)[b]); | ||
| 233 | cmn_err(CE_DEBUG, ", fmt = %d\n", XLOG_FMT); | ||
| 234 | cmn_err(CE_DEBUG, " log : uuid = "); | ||
| 235 | for (b = 0; b < 16; b++) | ||
| 236 | cmn_err(CE_DEBUG, "%02x", ((__uint8_t *)&head->h_fs_uuid)[b]); | ||
| 237 | cmn_err(CE_DEBUG, ", fmt = %d\n", be32_to_cpu(head->h_fmt)); | ||
| 238 | } | 233 | } |
| 239 | #else | 234 | #else |
| 240 | #define xlog_header_check_dump(mp, head) | 235 | #define xlog_header_check_dump(mp, head) |
| @@ -2206,6 +2201,7 @@ xlog_recover_do_buffer_trans( | |||
| 2206 | xfs_daddr_t blkno; | 2201 | xfs_daddr_t blkno; |
| 2207 | int len; | 2202 | int len; |
| 2208 | ushort flags; | 2203 | ushort flags; |
| 2204 | uint buf_flags; | ||
| 2209 | 2205 | ||
| 2210 | buf_f = (xfs_buf_log_format_t *)item->ri_buf[0].i_addr; | 2206 | buf_f = (xfs_buf_log_format_t *)item->ri_buf[0].i_addr; |
| 2211 | 2207 | ||
| @@ -2246,12 +2242,11 @@ xlog_recover_do_buffer_trans( | |||
| 2246 | } | 2242 | } |
| 2247 | 2243 | ||
| 2248 | mp = log->l_mp; | 2244 | mp = log->l_mp; |
| 2249 | if (flags & XFS_BLI_INODE_BUF) { | 2245 | buf_flags = XFS_BUF_LOCK; |
| 2250 | bp = xfs_buf_read_flags(mp->m_ddev_targp, blkno, len, | 2246 | if (!(flags & XFS_BLI_INODE_BUF)) |
| 2251 | XFS_BUF_LOCK); | 2247 | buf_flags |= XFS_BUF_MAPPED; |
| 2252 | } else { | 2248 | |
| 2253 | bp = xfs_buf_read(mp->m_ddev_targp, blkno, len, 0); | 2249 | bp = xfs_buf_read(mp->m_ddev_targp, blkno, len, buf_flags); |
| 2254 | } | ||
| 2255 | if (XFS_BUF_ISERROR(bp)) { | 2250 | if (XFS_BUF_ISERROR(bp)) { |
| 2256 | xfs_ioerror_alert("xlog_recover_do..(read#1)", log->l_mp, | 2251 | xfs_ioerror_alert("xlog_recover_do..(read#1)", log->l_mp, |
| 2257 | bp, blkno); | 2252 | bp, blkno); |
| @@ -2350,8 +2345,8 @@ xlog_recover_do_inode_trans( | |||
| 2350 | goto error; | 2345 | goto error; |
| 2351 | } | 2346 | } |
| 2352 | 2347 | ||
| 2353 | bp = xfs_buf_read_flags(mp->m_ddev_targp, in_f->ilf_blkno, | 2348 | bp = xfs_buf_read(mp->m_ddev_targp, in_f->ilf_blkno, in_f->ilf_len, |
| 2354 | in_f->ilf_len, XFS_BUF_LOCK); | 2349 | XFS_BUF_LOCK); |
| 2355 | if (XFS_BUF_ISERROR(bp)) { | 2350 | if (XFS_BUF_ISERROR(bp)) { |
| 2356 | xfs_ioerror_alert("xlog_recover_do..(read#2)", mp, | 2351 | xfs_ioerror_alert("xlog_recover_do..(read#2)", mp, |
| 2357 | bp, in_f->ilf_blkno); | 2352 | bp, in_f->ilf_blkno); |
| @@ -3517,7 +3512,7 @@ xlog_do_recovery_pass( | |||
| 3517 | { | 3512 | { |
| 3518 | xlog_rec_header_t *rhead; | 3513 | xlog_rec_header_t *rhead; |
| 3519 | xfs_daddr_t blk_no; | 3514 | xfs_daddr_t blk_no; |
| 3520 | xfs_caddr_t bufaddr, offset; | 3515 | xfs_caddr_t offset; |
| 3521 | xfs_buf_t *hbp, *dbp; | 3516 | xfs_buf_t *hbp, *dbp; |
| 3522 | int error = 0, h_size; | 3517 | int error = 0, h_size; |
| 3523 | int bblks, split_bblks; | 3518 | int bblks, split_bblks; |
| @@ -3610,7 +3605,7 @@ xlog_do_recovery_pass( | |||
| 3610 | /* | 3605 | /* |
| 3611 | * Check for header wrapping around physical end-of-log | 3606 | * Check for header wrapping around physical end-of-log |
| 3612 | */ | 3607 | */ |
| 3613 | offset = NULL; | 3608 | offset = XFS_BUF_PTR(hbp); |
| 3614 | split_hblks = 0; | 3609 | split_hblks = 0; |
| 3615 | wrapped_hblks = 0; | 3610 | wrapped_hblks = 0; |
| 3616 | if (blk_no + hblks <= log->l_logBBsize) { | 3611 | if (blk_no + hblks <= log->l_logBBsize) { |
| @@ -3646,9 +3641,8 @@ xlog_do_recovery_pass( | |||
| 3646 | * - order is important. | 3641 | * - order is important. |
| 3647 | */ | 3642 | */ |
| 3648 | wrapped_hblks = hblks - split_hblks; | 3643 | wrapped_hblks = hblks - split_hblks; |
| 3649 | bufaddr = XFS_BUF_PTR(hbp); | ||
| 3650 | error = XFS_BUF_SET_PTR(hbp, | 3644 | error = XFS_BUF_SET_PTR(hbp, |
| 3651 | bufaddr + BBTOB(split_hblks), | 3645 | offset + BBTOB(split_hblks), |
| 3652 | BBTOB(hblks - split_hblks)); | 3646 | BBTOB(hblks - split_hblks)); |
| 3653 | if (error) | 3647 | if (error) |
| 3654 | goto bread_err2; | 3648 | goto bread_err2; |
| @@ -3658,14 +3652,10 @@ xlog_do_recovery_pass( | |||
| 3658 | if (error) | 3652 | if (error) |
| 3659 | goto bread_err2; | 3653 | goto bread_err2; |
| 3660 | 3654 | ||
| 3661 | error = XFS_BUF_SET_PTR(hbp, bufaddr, | 3655 | error = XFS_BUF_SET_PTR(hbp, offset, |
| 3662 | BBTOB(hblks)); | 3656 | BBTOB(hblks)); |
| 3663 | if (error) | 3657 | if (error) |
| 3664 | goto bread_err2; | 3658 | goto bread_err2; |
| 3665 | |||
| 3666 | if (!offset) | ||
| 3667 | offset = xlog_align(log, 0, | ||
| 3668 | wrapped_hblks, hbp); | ||
| 3669 | } | 3659 | } |
| 3670 | rhead = (xlog_rec_header_t *)offset; | 3660 | rhead = (xlog_rec_header_t *)offset; |
| 3671 | error = xlog_valid_rec_header(log, rhead, | 3661 | error = xlog_valid_rec_header(log, rhead, |
| @@ -3685,7 +3675,7 @@ xlog_do_recovery_pass( | |||
| 3685 | } else { | 3675 | } else { |
| 3686 | /* This log record is split across the | 3676 | /* This log record is split across the |
| 3687 | * physical end of log */ | 3677 | * physical end of log */ |
| 3688 | offset = NULL; | 3678 | offset = XFS_BUF_PTR(dbp); |
| 3689 | split_bblks = 0; | 3679 | split_bblks = 0; |
| 3690 | if (blk_no != log->l_logBBsize) { | 3680 | if (blk_no != log->l_logBBsize) { |
| 3691 | /* some data is before the physical | 3681 | /* some data is before the physical |
| @@ -3714,9 +3704,8 @@ xlog_do_recovery_pass( | |||
| 3714 | * _first_, then the log start (LR header end) | 3704 | * _first_, then the log start (LR header end) |
| 3715 | * - order is important. | 3705 | * - order is important. |
| 3716 | */ | 3706 | */ |
| 3717 | bufaddr = XFS_BUF_PTR(dbp); | ||
| 3718 | error = XFS_BUF_SET_PTR(dbp, | 3707 | error = XFS_BUF_SET_PTR(dbp, |
| 3719 | bufaddr + BBTOB(split_bblks), | 3708 | offset + BBTOB(split_bblks), |
| 3720 | BBTOB(bblks - split_bblks)); | 3709 | BBTOB(bblks - split_bblks)); |
| 3721 | if (error) | 3710 | if (error) |
| 3722 | goto bread_err2; | 3711 | goto bread_err2; |
| @@ -3727,13 +3716,9 @@ xlog_do_recovery_pass( | |||
| 3727 | if (error) | 3716 | if (error) |
| 3728 | goto bread_err2; | 3717 | goto bread_err2; |
| 3729 | 3718 | ||
| 3730 | error = XFS_BUF_SET_PTR(dbp, bufaddr, h_size); | 3719 | error = XFS_BUF_SET_PTR(dbp, offset, h_size); |
| 3731 | if (error) | 3720 | if (error) |
| 3732 | goto bread_err2; | 3721 | goto bread_err2; |
| 3733 | |||
| 3734 | if (!offset) | ||
| 3735 | offset = xlog_align(log, wrapped_hblks, | ||
| 3736 | bblks - split_bblks, dbp); | ||
| 3737 | } | 3722 | } |
| 3738 | xlog_unpack_data(rhead, offset, log); | 3723 | xlog_unpack_data(rhead, offset, log); |
| 3739 | if ((error = xlog_recover_process_data(log, rhash, | 3724 | if ((error = xlog_recover_process_data(log, rhash, |
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 8b6c9e807efb..eb403b40e120 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
| @@ -44,6 +44,8 @@ | |||
| 44 | #include "xfs_quota.h" | 44 | #include "xfs_quota.h" |
| 45 | #include "xfs_fsops.h" | 45 | #include "xfs_fsops.h" |
| 46 | #include "xfs_utils.h" | 46 | #include "xfs_utils.h" |
| 47 | #include "xfs_trace.h" | ||
| 48 | |||
| 47 | 49 | ||
| 48 | STATIC void xfs_unmountfs_wait(xfs_mount_t *); | 50 | STATIC void xfs_unmountfs_wait(xfs_mount_t *); |
| 49 | 51 | ||
| @@ -583,8 +585,8 @@ xfs_readsb(xfs_mount_t *mp, int flags) | |||
| 583 | sector_size = xfs_getsize_buftarg(mp->m_ddev_targp); | 585 | sector_size = xfs_getsize_buftarg(mp->m_ddev_targp); |
| 584 | extra_flags = XFS_BUF_LOCK | XFS_BUF_MANAGE | XFS_BUF_MAPPED; | 586 | extra_flags = XFS_BUF_LOCK | XFS_BUF_MANAGE | XFS_BUF_MAPPED; |
| 585 | 587 | ||
| 586 | bp = xfs_buf_read_flags(mp->m_ddev_targp, XFS_SB_DADDR, | 588 | bp = xfs_buf_read(mp->m_ddev_targp, XFS_SB_DADDR, BTOBB(sector_size), |
| 587 | BTOBB(sector_size), extra_flags); | 589 | extra_flags); |
| 588 | if (!bp || XFS_BUF_ISERROR(bp)) { | 590 | if (!bp || XFS_BUF_ISERROR(bp)) { |
| 589 | xfs_fs_mount_cmn_err(flags, "SB read failed"); | 591 | xfs_fs_mount_cmn_err(flags, "SB read failed"); |
| 590 | error = bp ? XFS_BUF_GETERROR(bp) : ENOMEM; | 592 | error = bp ? XFS_BUF_GETERROR(bp) : ENOMEM; |
| @@ -624,8 +626,8 @@ xfs_readsb(xfs_mount_t *mp, int flags) | |||
| 624 | XFS_BUF_UNMANAGE(bp); | 626 | XFS_BUF_UNMANAGE(bp); |
| 625 | xfs_buf_relse(bp); | 627 | xfs_buf_relse(bp); |
| 626 | sector_size = mp->m_sb.sb_sectsize; | 628 | sector_size = mp->m_sb.sb_sectsize; |
| 627 | bp = xfs_buf_read_flags(mp->m_ddev_targp, XFS_SB_DADDR, | 629 | bp = xfs_buf_read(mp->m_ddev_targp, XFS_SB_DADDR, |
| 628 | BTOBB(sector_size), extra_flags); | 630 | BTOBB(sector_size), extra_flags); |
| 629 | if (!bp || XFS_BUF_ISERROR(bp)) { | 631 | if (!bp || XFS_BUF_ISERROR(bp)) { |
| 630 | xfs_fs_mount_cmn_err(flags, "SB re-read failed"); | 632 | xfs_fs_mount_cmn_err(flags, "SB re-read failed"); |
| 631 | error = bp ? XFS_BUF_GETERROR(bp) : ENOMEM; | 633 | error = bp ? XFS_BUF_GETERROR(bp) : ENOMEM; |
| @@ -1471,7 +1473,7 @@ xfs_log_sbcount( | |||
| 1471 | if (!xfs_sb_version_haslazysbcount(&mp->m_sb)) | 1473 | if (!xfs_sb_version_haslazysbcount(&mp->m_sb)) |
| 1472 | return 0; | 1474 | return 0; |
| 1473 | 1475 | ||
| 1474 | tp = _xfs_trans_alloc(mp, XFS_TRANS_SB_COUNT); | 1476 | tp = _xfs_trans_alloc(mp, XFS_TRANS_SB_COUNT, KM_SLEEP); |
| 1475 | error = xfs_trans_reserve(tp, 0, mp->m_sb.sb_sectsize + 128, 0, 0, | 1477 | error = xfs_trans_reserve(tp, 0, mp->m_sb.sb_sectsize + 128, 0, 0, |
| 1476 | XFS_DEFAULT_LOG_COUNT); | 1478 | XFS_DEFAULT_LOG_COUNT); |
| 1477 | if (error) { | 1479 | if (error) { |
| @@ -2123,7 +2125,7 @@ xfs_icsb_destroy_counters( | |||
| 2123 | mutex_destroy(&mp->m_icsb_mutex); | 2125 | mutex_destroy(&mp->m_icsb_mutex); |
| 2124 | } | 2126 | } |
| 2125 | 2127 | ||
| 2126 | STATIC_INLINE void | 2128 | STATIC void |
| 2127 | xfs_icsb_lock_cntr( | 2129 | xfs_icsb_lock_cntr( |
| 2128 | xfs_icsb_cnts_t *icsbp) | 2130 | xfs_icsb_cnts_t *icsbp) |
| 2129 | { | 2131 | { |
| @@ -2132,7 +2134,7 @@ xfs_icsb_lock_cntr( | |||
| 2132 | } | 2134 | } |
| 2133 | } | 2135 | } |
| 2134 | 2136 | ||
| 2135 | STATIC_INLINE void | 2137 | STATIC void |
| 2136 | xfs_icsb_unlock_cntr( | 2138 | xfs_icsb_unlock_cntr( |
| 2137 | xfs_icsb_cnts_t *icsbp) | 2139 | xfs_icsb_cnts_t *icsbp) |
| 2138 | { | 2140 | { |
| @@ -2140,7 +2142,7 @@ xfs_icsb_unlock_cntr( | |||
| 2140 | } | 2142 | } |
| 2141 | 2143 | ||
| 2142 | 2144 | ||
| 2143 | STATIC_INLINE void | 2145 | STATIC void |
| 2144 | xfs_icsb_lock_all_counters( | 2146 | xfs_icsb_lock_all_counters( |
| 2145 | xfs_mount_t *mp) | 2147 | xfs_mount_t *mp) |
| 2146 | { | 2148 | { |
| @@ -2153,7 +2155,7 @@ xfs_icsb_lock_all_counters( | |||
| 2153 | } | 2155 | } |
| 2154 | } | 2156 | } |
| 2155 | 2157 | ||
| 2156 | STATIC_INLINE void | 2158 | STATIC void |
| 2157 | xfs_icsb_unlock_all_counters( | 2159 | xfs_icsb_unlock_all_counters( |
| 2158 | xfs_mount_t *mp) | 2160 | xfs_mount_t *mp) |
| 2159 | { | 2161 | { |
| @@ -2389,12 +2391,12 @@ xfs_icsb_modify_counters( | |||
| 2389 | { | 2391 | { |
| 2390 | xfs_icsb_cnts_t *icsbp; | 2392 | xfs_icsb_cnts_t *icsbp; |
| 2391 | long long lcounter; /* long counter for 64 bit fields */ | 2393 | long long lcounter; /* long counter for 64 bit fields */ |
| 2392 | int cpu, ret = 0; | 2394 | int ret = 0; |
| 2393 | 2395 | ||
| 2394 | might_sleep(); | 2396 | might_sleep(); |
| 2395 | again: | 2397 | again: |
| 2396 | cpu = get_cpu(); | 2398 | preempt_disable(); |
| 2397 | icsbp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, cpu); | 2399 | icsbp = this_cpu_ptr(mp->m_sb_cnts); |
| 2398 | 2400 | ||
| 2399 | /* | 2401 | /* |
| 2400 | * if the counter is disabled, go to slow path | 2402 | * if the counter is disabled, go to slow path |
| @@ -2438,11 +2440,11 @@ again: | |||
| 2438 | break; | 2440 | break; |
| 2439 | } | 2441 | } |
| 2440 | xfs_icsb_unlock_cntr(icsbp); | 2442 | xfs_icsb_unlock_cntr(icsbp); |
| 2441 | put_cpu(); | 2443 | preempt_enable(); |
| 2442 | return 0; | 2444 | return 0; |
| 2443 | 2445 | ||
| 2444 | slow_path: | 2446 | slow_path: |
| 2445 | put_cpu(); | 2447 | preempt_enable(); |
| 2446 | 2448 | ||
| 2447 | /* | 2449 | /* |
| 2448 | * serialise with a mutex so we don't burn lots of cpu on | 2450 | * serialise with a mutex so we don't burn lots of cpu on |
| @@ -2490,7 +2492,7 @@ slow_path: | |||
| 2490 | 2492 | ||
| 2491 | balance_counter: | 2493 | balance_counter: |
| 2492 | xfs_icsb_unlock_cntr(icsbp); | 2494 | xfs_icsb_unlock_cntr(icsbp); |
| 2493 | put_cpu(); | 2495 | preempt_enable(); |
| 2494 | 2496 | ||
| 2495 | /* | 2497 | /* |
| 2496 | * We may have multiple threads here if multiple per-cpu | 2498 | * We may have multiple threads here if multiple per-cpu |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index a6c023bc0fb2..1df7e4502967 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
| @@ -93,6 +93,9 @@ typedef struct xfs_dmops { | |||
| 93 | xfs_send_unmount_t xfs_send_unmount; | 93 | xfs_send_unmount_t xfs_send_unmount; |
| 94 | } xfs_dmops_t; | 94 | } xfs_dmops_t; |
| 95 | 95 | ||
| 96 | #define XFS_DMAPI_UNMOUNT_FLAGS(mp) \ | ||
| 97 | (((mp)->m_dmevmask & (1 << DM_EVENT_UNMOUNT)) ? 0 : DM_FLAGS_UNWANTED) | ||
| 98 | |||
| 96 | #define XFS_SEND_DATA(mp, ev,ip,off,len,fl,lock) \ | 99 | #define XFS_SEND_DATA(mp, ev,ip,off,len,fl,lock) \ |
| 97 | (*(mp)->m_dm_ops->xfs_send_data)(ev,ip,off,len,fl,lock) | 100 | (*(mp)->m_dm_ops->xfs_send_data)(ev,ip,off,len,fl,lock) |
| 98 | #define XFS_SEND_MMAP(mp, vma,fl) \ | 101 | #define XFS_SEND_MMAP(mp, vma,fl) \ |
| @@ -101,12 +104,24 @@ typedef struct xfs_dmops { | |||
| 101 | (*(mp)->m_dm_ops->xfs_send_destroy)(ip,right) | 104 | (*(mp)->m_dm_ops->xfs_send_destroy)(ip,right) |
| 102 | #define XFS_SEND_NAMESP(mp, ev,b1,r1,b2,r2,n1,n2,mode,rval,fl) \ | 105 | #define XFS_SEND_NAMESP(mp, ev,b1,r1,b2,r2,n1,n2,mode,rval,fl) \ |
| 103 | (*(mp)->m_dm_ops->xfs_send_namesp)(ev,NULL,b1,r1,b2,r2,n1,n2,mode,rval,fl) | 106 | (*(mp)->m_dm_ops->xfs_send_namesp)(ev,NULL,b1,r1,b2,r2,n1,n2,mode,rval,fl) |
| 104 | #define XFS_SEND_PREUNMOUNT(mp,b1,r1,b2,r2,n1,n2,mode,rval,fl) \ | ||
| 105 | (*(mp)->m_dm_ops->xfs_send_namesp)(DM_EVENT_PREUNMOUNT,mp,b1,r1,b2,r2,n1,n2,mode,rval,fl) | ||
| 106 | #define XFS_SEND_MOUNT(mp,right,path,name) \ | 107 | #define XFS_SEND_MOUNT(mp,right,path,name) \ |
| 107 | (*(mp)->m_dm_ops->xfs_send_mount)(mp,right,path,name) | 108 | (*(mp)->m_dm_ops->xfs_send_mount)(mp,right,path,name) |
| 108 | #define XFS_SEND_UNMOUNT(mp, ip,right,mode,rval,fl) \ | 109 | #define XFS_SEND_PREUNMOUNT(mp) \ |
| 109 | (*(mp)->m_dm_ops->xfs_send_unmount)(mp,ip,right,mode,rval,fl) | 110 | do { \ |
| 111 | if (mp->m_flags & XFS_MOUNT_DMAPI) { \ | ||
| 112 | (*(mp)->m_dm_ops->xfs_send_namesp)(DM_EVENT_PREUNMOUNT, mp, \ | ||
| 113 | (mp)->m_rootip, DM_RIGHT_NULL, \ | ||
| 114 | (mp)->m_rootip, DM_RIGHT_NULL, \ | ||
| 115 | NULL, NULL, 0, 0, XFS_DMAPI_UNMOUNT_FLAGS(mp)); \ | ||
| 116 | } \ | ||
| 117 | } while (0) | ||
| 118 | #define XFS_SEND_UNMOUNT(mp) \ | ||
| 119 | do { \ | ||
| 120 | if (mp->m_flags & XFS_MOUNT_DMAPI) { \ | ||
| 121 | (*(mp)->m_dm_ops->xfs_send_unmount)(mp, (mp)->m_rootip, \ | ||
| 122 | DM_RIGHT_NULL, 0, 0, XFS_DMAPI_UNMOUNT_FLAGS(mp)); \ | ||
| 123 | } \ | ||
| 124 | } while (0) | ||
| 110 | 125 | ||
| 111 | 126 | ||
| 112 | #ifdef HAVE_PERCPU_SB | 127 | #ifdef HAVE_PERCPU_SB |
| @@ -387,13 +402,13 @@ xfs_put_perag(struct xfs_mount *mp, xfs_perag_t *pag) | |||
| 387 | * Per-cpu superblock locking functions | 402 | * Per-cpu superblock locking functions |
| 388 | */ | 403 | */ |
| 389 | #ifdef HAVE_PERCPU_SB | 404 | #ifdef HAVE_PERCPU_SB |
| 390 | STATIC_INLINE void | 405 | static inline void |
| 391 | xfs_icsb_lock(xfs_mount_t *mp) | 406 | xfs_icsb_lock(xfs_mount_t *mp) |
| 392 | { | 407 | { |
| 393 | mutex_lock(&mp->m_icsb_mutex); | 408 | mutex_lock(&mp->m_icsb_mutex); |
| 394 | } | 409 | } |
| 395 | 410 | ||
| 396 | STATIC_INLINE void | 411 | static inline void |
| 397 | xfs_icsb_unlock(xfs_mount_t *mp) | 412 | xfs_icsb_unlock(xfs_mount_t *mp) |
| 398 | { | 413 | { |
| 399 | mutex_unlock(&mp->m_icsb_mutex); | 414 | mutex_unlock(&mp->m_icsb_mutex); |
diff --git a/fs/xfs/xfs_quota.h b/fs/xfs/xfs_quota.h index 3ec91ac74c2a..91bfd60f4c74 100644 --- a/fs/xfs/xfs_quota.h +++ b/fs/xfs/xfs_quota.h | |||
| @@ -92,6 +92,14 @@ typedef struct xfs_dqblk { | |||
| 92 | 92 | ||
| 93 | #define XFS_DQ_ALLTYPES (XFS_DQ_USER|XFS_DQ_PROJ|XFS_DQ_GROUP) | 93 | #define XFS_DQ_ALLTYPES (XFS_DQ_USER|XFS_DQ_PROJ|XFS_DQ_GROUP) |
| 94 | 94 | ||
| 95 | #define XFS_DQ_FLAGS \ | ||
| 96 | { XFS_DQ_USER, "USER" }, \ | ||
| 97 | { XFS_DQ_PROJ, "PROJ" }, \ | ||
| 98 | { XFS_DQ_GROUP, "GROUP" }, \ | ||
| 99 | { XFS_DQ_DIRTY, "DIRTY" }, \ | ||
| 100 | { XFS_DQ_WANT, "WANT" }, \ | ||
| 101 | { XFS_DQ_INACTIVE, "INACTIVE" } | ||
| 102 | |||
| 95 | /* | 103 | /* |
| 96 | * In the worst case, when both user and group quotas are on, | 104 | * In the worst case, when both user and group quotas are on, |
| 97 | * we can have a max of three dquots changing in a single transaction. | 105 | * we can have a max of three dquots changing in a single transaction. |
diff --git a/fs/xfs/xfs_rename.c b/fs/xfs/xfs_rename.c index b81deea0ce19..fc1cda23b817 100644 --- a/fs/xfs/xfs_rename.c +++ b/fs/xfs/xfs_rename.c | |||
| @@ -39,6 +39,7 @@ | |||
| 39 | #include "xfs_utils.h" | 39 | #include "xfs_utils.h" |
| 40 | #include "xfs_trans_space.h" | 40 | #include "xfs_trans_space.h" |
| 41 | #include "xfs_vnodeops.h" | 41 | #include "xfs_vnodeops.h" |
| 42 | #include "xfs_trace.h" | ||
| 42 | 43 | ||
| 43 | 44 | ||
| 44 | /* | 45 | /* |
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c index 385f6dceba5d..9e15a1185362 100644 --- a/fs/xfs/xfs_rtalloc.c +++ b/fs/xfs/xfs_rtalloc.c | |||
| @@ -45,6 +45,7 @@ | |||
| 45 | #include "xfs_inode_item.h" | 45 | #include "xfs_inode_item.h" |
| 46 | #include "xfs_trans_space.h" | 46 | #include "xfs_trans_space.h" |
| 47 | #include "xfs_utils.h" | 47 | #include "xfs_utils.h" |
| 48 | #include "xfs_trace.h" | ||
| 48 | 49 | ||
| 49 | 50 | ||
| 50 | /* | 51 | /* |
diff --git a/fs/xfs/xfs_rw.c b/fs/xfs/xfs_rw.c index 3f816ad7ff19..5aa07caea5f1 100644 --- a/fs/xfs/xfs_rw.c +++ b/fs/xfs/xfs_rw.c | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | #include "xfs_error.h" | 44 | #include "xfs_error.h" |
| 45 | #include "xfs_buf_item.h" | 45 | #include "xfs_buf_item.h" |
| 46 | #include "xfs_rw.h" | 46 | #include "xfs_rw.h" |
| 47 | #include "xfs_trace.h" | ||
| 47 | 48 | ||
| 48 | /* | 49 | /* |
| 49 | * This is a subroutine for xfs_write() and other writers (xfs_ioctl) | 50 | * This is a subroutine for xfs_write() and other writers (xfs_ioctl) |
| @@ -171,7 +172,6 @@ xfs_bioerror( | |||
| 171 | * No need to wait until the buffer is unpinned. | 172 | * No need to wait until the buffer is unpinned. |
| 172 | * We aren't flushing it. | 173 | * We aren't flushing it. |
| 173 | */ | 174 | */ |
| 174 | xfs_buftrace("XFS IOERROR", bp); | ||
| 175 | XFS_BUF_ERROR(bp, EIO); | 175 | XFS_BUF_ERROR(bp, EIO); |
| 176 | /* | 176 | /* |
| 177 | * We're calling biodone, so delete B_DONE flag. Either way | 177 | * We're calling biodone, so delete B_DONE flag. Either way |
| @@ -205,7 +205,6 @@ xfs_bioerror_relse( | |||
| 205 | ASSERT(XFS_BUF_IODONE_FUNC(bp) != xfs_buf_iodone_callbacks); | 205 | ASSERT(XFS_BUF_IODONE_FUNC(bp) != xfs_buf_iodone_callbacks); |
| 206 | ASSERT(XFS_BUF_IODONE_FUNC(bp) != xlog_iodone); | 206 | ASSERT(XFS_BUF_IODONE_FUNC(bp) != xlog_iodone); |
| 207 | 207 | ||
| 208 | xfs_buftrace("XFS IOERRELSE", bp); | ||
| 209 | fl = XFS_BUF_BFLAGS(bp); | 208 | fl = XFS_BUF_BFLAGS(bp); |
| 210 | /* | 209 | /* |
| 211 | * No need to wait until the buffer is unpinned. | 210 | * No need to wait until the buffer is unpinned. |
| @@ -277,10 +276,10 @@ xfs_read_buf( | |||
| 277 | xfs_buf_t *bp; | 276 | xfs_buf_t *bp; |
| 278 | int error; | 277 | int error; |
| 279 | 278 | ||
| 280 | if (flags) | 279 | if (!flags) |
| 281 | bp = xfs_buf_read_flags(target, blkno, len, flags); | 280 | flags = XBF_LOCK | XBF_MAPPED; |
| 282 | else | 281 | |
| 283 | bp = xfs_buf_read(target, blkno, len, flags); | 282 | bp = xfs_buf_read(target, blkno, len, flags); |
| 284 | if (!bp) | 283 | if (!bp) |
| 285 | return XFS_ERROR(EIO); | 284 | return XFS_ERROR(EIO); |
| 286 | error = XFS_BUF_GETERROR(bp); | 285 | error = XFS_BUF_GETERROR(bp); |
| @@ -336,3 +335,25 @@ xfs_bwrite( | |||
| 336 | } | 335 | } |
| 337 | return (error); | 336 | return (error); |
| 338 | } | 337 | } |
| 338 | |||
| 339 | /* | ||
| 340 | * helper function to extract extent size hint from inode | ||
| 341 | */ | ||
| 342 | xfs_extlen_t | ||
| 343 | xfs_get_extsz_hint( | ||
| 344 | struct xfs_inode *ip) | ||
| 345 | { | ||
| 346 | xfs_extlen_t extsz; | ||
| 347 | |||
| 348 | if (unlikely(XFS_IS_REALTIME_INODE(ip))) { | ||
| 349 | extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) | ||
| 350 | ? ip->i_d.di_extsize | ||
| 351 | : ip->i_mount->m_sb.sb_rextsize; | ||
| 352 | ASSERT(extsz); | ||
| 353 | } else { | ||
| 354 | extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) | ||
| 355 | ? ip->i_d.di_extsize : 0; | ||
| 356 | } | ||
| 357 | |||
| 358 | return extsz; | ||
| 359 | } | ||
diff --git a/fs/xfs/xfs_rw.h b/fs/xfs/xfs_rw.h index f5e4874c37d8..571f2174435c 100644 --- a/fs/xfs/xfs_rw.h +++ b/fs/xfs/xfs_rw.h | |||
| @@ -37,34 +37,6 @@ xfs_fsb_to_db(struct xfs_inode *ip, xfs_fsblock_t fsb) | |||
| 37 | } | 37 | } |
| 38 | 38 | ||
| 39 | /* | 39 | /* |
| 40 | * Flags for xfs_free_eofblocks | ||
| 41 | */ | ||
| 42 | #define XFS_FREE_EOF_LOCK (1<<0) | ||
| 43 | #define XFS_FREE_EOF_NOLOCK (1<<1) | ||
| 44 | |||
| 45 | |||
| 46 | /* | ||
| 47 | * helper function to extract extent size hint from inode | ||
| 48 | */ | ||
| 49 | STATIC_INLINE xfs_extlen_t | ||
| 50 | xfs_get_extsz_hint( | ||
| 51 | xfs_inode_t *ip) | ||
| 52 | { | ||
| 53 | xfs_extlen_t extsz; | ||
| 54 | |||
| 55 | if (unlikely(XFS_IS_REALTIME_INODE(ip))) { | ||
| 56 | extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) | ||
| 57 | ? ip->i_d.di_extsize | ||
| 58 | : ip->i_mount->m_sb.sb_rextsize; | ||
| 59 | ASSERT(extsz); | ||
| 60 | } else { | ||
| 61 | extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) | ||
| 62 | ? ip->i_d.di_extsize : 0; | ||
| 63 | } | ||
| 64 | return extsz; | ||
| 65 | } | ||
| 66 | |||
| 67 | /* | ||
| 68 | * Prototypes for functions in xfs_rw.c. | 40 | * Prototypes for functions in xfs_rw.c. |
| 69 | */ | 41 | */ |
| 70 | extern int xfs_write_clear_setuid(struct xfs_inode *ip); | 42 | extern int xfs_write_clear_setuid(struct xfs_inode *ip); |
| @@ -76,5 +48,6 @@ extern int xfs_read_buf(struct xfs_mount *mp, xfs_buftarg_t *btp, | |||
| 76 | struct xfs_buf **bpp); | 48 | struct xfs_buf **bpp); |
| 77 | extern void xfs_ioerror_alert(char *func, struct xfs_mount *mp, | 49 | extern void xfs_ioerror_alert(char *func, struct xfs_mount *mp, |
| 78 | xfs_buf_t *bp, xfs_daddr_t blkno); | 50 | xfs_buf_t *bp, xfs_daddr_t blkno); |
| 51 | extern xfs_extlen_t xfs_get_extsz_hint(struct xfs_inode *ip); | ||
| 79 | 52 | ||
| 80 | #endif /* __XFS_RW_H__ */ | 53 | #endif /* __XFS_RW_H__ */ |
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 66b849358e62..237badcbac3b 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c | |||
| @@ -236,19 +236,20 @@ xfs_trans_alloc( | |||
| 236 | uint type) | 236 | uint type) |
| 237 | { | 237 | { |
| 238 | xfs_wait_for_freeze(mp, SB_FREEZE_TRANS); | 238 | xfs_wait_for_freeze(mp, SB_FREEZE_TRANS); |
| 239 | return _xfs_trans_alloc(mp, type); | 239 | return _xfs_trans_alloc(mp, type, KM_SLEEP); |
| 240 | } | 240 | } |
| 241 | 241 | ||
| 242 | xfs_trans_t * | 242 | xfs_trans_t * |
| 243 | _xfs_trans_alloc( | 243 | _xfs_trans_alloc( |
| 244 | xfs_mount_t *mp, | 244 | xfs_mount_t *mp, |
| 245 | uint type) | 245 | uint type, |
| 246 | uint memflags) | ||
| 246 | { | 247 | { |
| 247 | xfs_trans_t *tp; | 248 | xfs_trans_t *tp; |
| 248 | 249 | ||
| 249 | atomic_inc(&mp->m_active_trans); | 250 | atomic_inc(&mp->m_active_trans); |
| 250 | 251 | ||
| 251 | tp = kmem_zone_zalloc(xfs_trans_zone, KM_SLEEP); | 252 | tp = kmem_zone_zalloc(xfs_trans_zone, memflags); |
| 252 | tp->t_magic = XFS_TRANS_MAGIC; | 253 | tp->t_magic = XFS_TRANS_MAGIC; |
| 253 | tp->t_type = type; | 254 | tp->t_type = type; |
| 254 | tp->t_mountp = mp; | 255 | tp->t_mountp = mp; |
diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h index ed47fc77759c..ca64f33c63a3 100644 --- a/fs/xfs/xfs_trans.h +++ b/fs/xfs/xfs_trans.h | |||
| @@ -100,6 +100,49 @@ typedef struct xfs_trans_header { | |||
| 100 | #define XFS_TRANS_TYPE_MAX 41 | 100 | #define XFS_TRANS_TYPE_MAX 41 |
| 101 | /* new transaction types need to be reflected in xfs_logprint(8) */ | 101 | /* new transaction types need to be reflected in xfs_logprint(8) */ |
| 102 | 102 | ||
| 103 | #define XFS_TRANS_TYPES \ | ||
| 104 | { XFS_TRANS_SETATTR_NOT_SIZE, "SETATTR_NOT_SIZE" }, \ | ||
| 105 | { XFS_TRANS_SETATTR_SIZE, "SETATTR_SIZE" }, \ | ||
| 106 | { XFS_TRANS_INACTIVE, "INACTIVE" }, \ | ||
| 107 | { XFS_TRANS_CREATE, "CREATE" }, \ | ||
| 108 | { XFS_TRANS_CREATE_TRUNC, "CREATE_TRUNC" }, \ | ||
| 109 | { XFS_TRANS_TRUNCATE_FILE, "TRUNCATE_FILE" }, \ | ||
| 110 | { XFS_TRANS_REMOVE, "REMOVE" }, \ | ||
| 111 | { XFS_TRANS_LINK, "LINK" }, \ | ||
| 112 | { XFS_TRANS_RENAME, "RENAME" }, \ | ||
| 113 | { XFS_TRANS_MKDIR, "MKDIR" }, \ | ||
| 114 | { XFS_TRANS_RMDIR, "RMDIR" }, \ | ||
| 115 | { XFS_TRANS_SYMLINK, "SYMLINK" }, \ | ||
| 116 | { XFS_TRANS_SET_DMATTRS, "SET_DMATTRS" }, \ | ||
| 117 | { XFS_TRANS_GROWFS, "GROWFS" }, \ | ||
| 118 | { XFS_TRANS_STRAT_WRITE, "STRAT_WRITE" }, \ | ||
| 119 | { XFS_TRANS_DIOSTRAT, "DIOSTRAT" }, \ | ||
| 120 | { XFS_TRANS_WRITEID, "WRITEID" }, \ | ||
| 121 | { XFS_TRANS_ADDAFORK, "ADDAFORK" }, \ | ||
| 122 | { XFS_TRANS_ATTRINVAL, "ATTRINVAL" }, \ | ||
| 123 | { XFS_TRANS_ATRUNCATE, "ATRUNCATE" }, \ | ||
| 124 | { XFS_TRANS_ATTR_SET, "ATTR_SET" }, \ | ||
| 125 | { XFS_TRANS_ATTR_RM, "ATTR_RM" }, \ | ||
| 126 | { XFS_TRANS_ATTR_FLAG, "ATTR_FLAG" }, \ | ||
| 127 | { XFS_TRANS_CLEAR_AGI_BUCKET, "CLEAR_AGI_BUCKET" }, \ | ||
| 128 | { XFS_TRANS_QM_SBCHANGE, "QM_SBCHANGE" }, \ | ||
| 129 | { XFS_TRANS_QM_QUOTAOFF, "QM_QUOTAOFF" }, \ | ||
| 130 | { XFS_TRANS_QM_DQALLOC, "QM_DQALLOC" }, \ | ||
| 131 | { XFS_TRANS_QM_SETQLIM, "QM_SETQLIM" }, \ | ||
| 132 | { XFS_TRANS_QM_DQCLUSTER, "QM_DQCLUSTER" }, \ | ||
| 133 | { XFS_TRANS_QM_QINOCREATE, "QM_QINOCREATE" }, \ | ||
| 134 | { XFS_TRANS_QM_QUOTAOFF_END, "QM_QOFF_END" }, \ | ||
| 135 | { XFS_TRANS_SB_UNIT, "SB_UNIT" }, \ | ||
| 136 | { XFS_TRANS_FSYNC_TS, "FSYNC_TS" }, \ | ||
| 137 | { XFS_TRANS_GROWFSRT_ALLOC, "GROWFSRT_ALLOC" }, \ | ||
| 138 | { XFS_TRANS_GROWFSRT_ZERO, "GROWFSRT_ZERO" }, \ | ||
| 139 | { XFS_TRANS_GROWFSRT_FREE, "GROWFSRT_FREE" }, \ | ||
| 140 | { XFS_TRANS_SWAPEXT, "SWAPEXT" }, \ | ||
| 141 | { XFS_TRANS_SB_COUNT, "SB_COUNT" }, \ | ||
| 142 | { XFS_TRANS_DUMMY1, "DUMMY1" }, \ | ||
| 143 | { XFS_TRANS_DUMMY2, "DUMMY2" }, \ | ||
| 144 | { XLOG_UNMOUNT_REC_TYPE, "UNMOUNT" } | ||
| 145 | |||
| 103 | /* | 146 | /* |
| 104 | * This structure is used to track log items associated with | 147 | * This structure is used to track log items associated with |
| 105 | * a transaction. It points to the log item and keeps some | 148 | * a transaction. It points to the log item and keeps some |
| @@ -782,6 +825,10 @@ typedef struct xfs_log_item { | |||
| 782 | #define XFS_LI_IN_AIL 0x1 | 825 | #define XFS_LI_IN_AIL 0x1 |
| 783 | #define XFS_LI_ABORTED 0x2 | 826 | #define XFS_LI_ABORTED 0x2 |
| 784 | 827 | ||
| 828 | #define XFS_LI_FLAGS \ | ||
| 829 | { XFS_LI_IN_AIL, "IN_AIL" }, \ | ||
| 830 | { XFS_LI_ABORTED, "ABORTED" } | ||
| 831 | |||
| 785 | typedef struct xfs_item_ops { | 832 | typedef struct xfs_item_ops { |
| 786 | uint (*iop_size)(xfs_log_item_t *); | 833 | uint (*iop_size)(xfs_log_item_t *); |
| 787 | void (*iop_format)(xfs_log_item_t *, struct xfs_log_iovec *); | 834 | void (*iop_format)(xfs_log_item_t *, struct xfs_log_iovec *); |
| @@ -924,7 +971,7 @@ typedef struct xfs_trans { | |||
| 924 | * XFS transaction mechanism exported interfaces. | 971 | * XFS transaction mechanism exported interfaces. |
| 925 | */ | 972 | */ |
| 926 | xfs_trans_t *xfs_trans_alloc(struct xfs_mount *, uint); | 973 | xfs_trans_t *xfs_trans_alloc(struct xfs_mount *, uint); |
| 927 | xfs_trans_t *_xfs_trans_alloc(struct xfs_mount *, uint); | 974 | xfs_trans_t *_xfs_trans_alloc(struct xfs_mount *, uint, uint); |
| 928 | xfs_trans_t *xfs_trans_dup(xfs_trans_t *); | 975 | xfs_trans_t *xfs_trans_dup(xfs_trans_t *); |
| 929 | int xfs_trans_reserve(xfs_trans_t *, uint, uint, uint, | 976 | int xfs_trans_reserve(xfs_trans_t *, uint, uint, uint, |
| 930 | uint, uint); | 977 | uint, uint); |
diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c index 218829e6a152..49130628d5ef 100644 --- a/fs/xfs/xfs_trans_buf.c +++ b/fs/xfs/xfs_trans_buf.c | |||
| @@ -38,6 +38,7 @@ | |||
| 38 | #include "xfs_trans_priv.h" | 38 | #include "xfs_trans_priv.h" |
| 39 | #include "xfs_error.h" | 39 | #include "xfs_error.h" |
| 40 | #include "xfs_rw.h" | 40 | #include "xfs_rw.h" |
| 41 | #include "xfs_trace.h" | ||
| 41 | 42 | ||
| 42 | 43 | ||
| 43 | STATIC xfs_buf_t *xfs_trans_buf_item_match(xfs_trans_t *, xfs_buftarg_t *, | 44 | STATIC xfs_buf_t *xfs_trans_buf_item_match(xfs_trans_t *, xfs_buftarg_t *, |
| @@ -79,11 +80,8 @@ xfs_trans_get_buf(xfs_trans_t *tp, | |||
| 79 | /* | 80 | /* |
| 80 | * Default to a normal get_buf() call if the tp is NULL. | 81 | * Default to a normal get_buf() call if the tp is NULL. |
| 81 | */ | 82 | */ |
| 82 | if (tp == NULL) { | 83 | if (tp == NULL) |
| 83 | bp = xfs_buf_get_flags(target_dev, blkno, len, | 84 | return xfs_buf_get(target_dev, blkno, len, flags | BUF_BUSY); |
| 84 | flags | BUF_BUSY); | ||
| 85 | return(bp); | ||
| 86 | } | ||
| 87 | 85 | ||
| 88 | /* | 86 | /* |
| 89 | * If we find the buffer in the cache with this transaction | 87 | * If we find the buffer in the cache with this transaction |
| @@ -98,26 +96,23 @@ xfs_trans_get_buf(xfs_trans_t *tp, | |||
| 98 | } | 96 | } |
| 99 | if (bp != NULL) { | 97 | if (bp != NULL) { |
| 100 | ASSERT(XFS_BUF_VALUSEMA(bp) <= 0); | 98 | ASSERT(XFS_BUF_VALUSEMA(bp) <= 0); |
| 101 | if (XFS_FORCED_SHUTDOWN(tp->t_mountp)) { | 99 | if (XFS_FORCED_SHUTDOWN(tp->t_mountp)) |
| 102 | xfs_buftrace("TRANS GET RECUR SHUT", bp); | ||
| 103 | XFS_BUF_SUPER_STALE(bp); | 100 | XFS_BUF_SUPER_STALE(bp); |
| 104 | } | 101 | |
| 105 | /* | 102 | /* |
| 106 | * If the buffer is stale then it was binval'ed | 103 | * If the buffer is stale then it was binval'ed |
| 107 | * since last read. This doesn't matter since the | 104 | * since last read. This doesn't matter since the |
| 108 | * caller isn't allowed to use the data anyway. | 105 | * caller isn't allowed to use the data anyway. |
| 109 | */ | 106 | */ |
| 110 | else if (XFS_BUF_ISSTALE(bp)) { | 107 | else if (XFS_BUF_ISSTALE(bp)) |
| 111 | xfs_buftrace("TRANS GET RECUR STALE", bp); | ||
| 112 | ASSERT(!XFS_BUF_ISDELAYWRITE(bp)); | 108 | ASSERT(!XFS_BUF_ISDELAYWRITE(bp)); |
| 113 | } | 109 | |
| 114 | ASSERT(XFS_BUF_FSPRIVATE2(bp, xfs_trans_t *) == tp); | 110 | ASSERT(XFS_BUF_FSPRIVATE2(bp, xfs_trans_t *) == tp); |
| 115 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *); | 111 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *); |
| 116 | ASSERT(bip != NULL); | 112 | ASSERT(bip != NULL); |
| 117 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 113 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 118 | bip->bli_recur++; | 114 | bip->bli_recur++; |
| 119 | xfs_buftrace("TRANS GET RECUR", bp); | 115 | trace_xfs_trans_get_buf_recur(bip); |
| 120 | xfs_buf_item_trace("GET RECUR", bip); | ||
| 121 | return (bp); | 116 | return (bp); |
| 122 | } | 117 | } |
| 123 | 118 | ||
| @@ -129,7 +124,7 @@ xfs_trans_get_buf(xfs_trans_t *tp, | |||
| 129 | * easily deadlock with our current transaction as well as cause | 124 | * easily deadlock with our current transaction as well as cause |
| 130 | * us to run out of stack space. | 125 | * us to run out of stack space. |
| 131 | */ | 126 | */ |
| 132 | bp = xfs_buf_get_flags(target_dev, blkno, len, flags | BUF_BUSY); | 127 | bp = xfs_buf_get(target_dev, blkno, len, flags | BUF_BUSY); |
| 133 | if (bp == NULL) { | 128 | if (bp == NULL) { |
| 134 | return NULL; | 129 | return NULL; |
| 135 | } | 130 | } |
| @@ -169,8 +164,7 @@ xfs_trans_get_buf(xfs_trans_t *tp, | |||
| 169 | */ | 164 | */ |
| 170 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | 165 | XFS_BUF_SET_FSPRIVATE2(bp, tp); |
| 171 | 166 | ||
| 172 | xfs_buftrace("TRANS GET", bp); | 167 | trace_xfs_trans_get_buf(bip); |
| 173 | xfs_buf_item_trace("GET", bip); | ||
| 174 | return (bp); | 168 | return (bp); |
| 175 | } | 169 | } |
| 176 | 170 | ||
| @@ -210,7 +204,7 @@ xfs_trans_getsb(xfs_trans_t *tp, | |||
| 210 | ASSERT(bip != NULL); | 204 | ASSERT(bip != NULL); |
| 211 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 205 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 212 | bip->bli_recur++; | 206 | bip->bli_recur++; |
| 213 | xfs_buf_item_trace("GETSB RECUR", bip); | 207 | trace_xfs_trans_getsb_recur(bip); |
| 214 | return (bp); | 208 | return (bp); |
| 215 | } | 209 | } |
| 216 | 210 | ||
| @@ -252,7 +246,7 @@ xfs_trans_getsb(xfs_trans_t *tp, | |||
| 252 | */ | 246 | */ |
| 253 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | 247 | XFS_BUF_SET_FSPRIVATE2(bp, tp); |
| 254 | 248 | ||
| 255 | xfs_buf_item_trace("GETSB", bip); | 249 | trace_xfs_trans_getsb(bip); |
| 256 | return (bp); | 250 | return (bp); |
| 257 | } | 251 | } |
| 258 | 252 | ||
| @@ -302,7 +296,7 @@ xfs_trans_read_buf( | |||
| 302 | * Default to a normal get_buf() call if the tp is NULL. | 296 | * Default to a normal get_buf() call if the tp is NULL. |
| 303 | */ | 297 | */ |
| 304 | if (tp == NULL) { | 298 | if (tp == NULL) { |
| 305 | bp = xfs_buf_read_flags(target, blkno, len, flags | BUF_BUSY); | 299 | bp = xfs_buf_read(target, blkno, len, flags | BUF_BUSY); |
| 306 | if (!bp) | 300 | if (!bp) |
| 307 | return (flags & XFS_BUF_TRYLOCK) ? | 301 | return (flags & XFS_BUF_TRYLOCK) ? |
| 308 | EAGAIN : XFS_ERROR(ENOMEM); | 302 | EAGAIN : XFS_ERROR(ENOMEM); |
| @@ -350,7 +344,7 @@ xfs_trans_read_buf( | |||
| 350 | ASSERT(XFS_BUF_FSPRIVATE(bp, void *) != NULL); | 344 | ASSERT(XFS_BUF_FSPRIVATE(bp, void *) != NULL); |
| 351 | ASSERT((XFS_BUF_ISERROR(bp)) == 0); | 345 | ASSERT((XFS_BUF_ISERROR(bp)) == 0); |
| 352 | if (!(XFS_BUF_ISDONE(bp))) { | 346 | if (!(XFS_BUF_ISDONE(bp))) { |
| 353 | xfs_buftrace("READ_BUF_INCORE !DONE", bp); | 347 | trace_xfs_trans_read_buf_io(bp, _RET_IP_); |
| 354 | ASSERT(!XFS_BUF_ISASYNC(bp)); | 348 | ASSERT(!XFS_BUF_ISASYNC(bp)); |
| 355 | XFS_BUF_READ(bp); | 349 | XFS_BUF_READ(bp); |
| 356 | xfsbdstrat(tp->t_mountp, bp); | 350 | xfsbdstrat(tp->t_mountp, bp); |
| @@ -375,7 +369,7 @@ xfs_trans_read_buf( | |||
| 375 | * brelse it either. Just get out. | 369 | * brelse it either. Just get out. |
| 376 | */ | 370 | */ |
| 377 | if (XFS_FORCED_SHUTDOWN(mp)) { | 371 | if (XFS_FORCED_SHUTDOWN(mp)) { |
| 378 | xfs_buftrace("READ_BUF_INCORE XFSSHUTDN", bp); | 372 | trace_xfs_trans_read_buf_shut(bp, _RET_IP_); |
| 379 | *bpp = NULL; | 373 | *bpp = NULL; |
| 380 | return XFS_ERROR(EIO); | 374 | return XFS_ERROR(EIO); |
| 381 | } | 375 | } |
| @@ -385,7 +379,7 @@ xfs_trans_read_buf( | |||
| 385 | bip->bli_recur++; | 379 | bip->bli_recur++; |
| 386 | 380 | ||
| 387 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 381 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 388 | xfs_buf_item_trace("READ RECUR", bip); | 382 | trace_xfs_trans_read_buf_recur(bip); |
| 389 | *bpp = bp; | 383 | *bpp = bp; |
| 390 | return 0; | 384 | return 0; |
| 391 | } | 385 | } |
| @@ -398,14 +392,13 @@ xfs_trans_read_buf( | |||
| 398 | * easily deadlock with our current transaction as well as cause | 392 | * easily deadlock with our current transaction as well as cause |
| 399 | * us to run out of stack space. | 393 | * us to run out of stack space. |
| 400 | */ | 394 | */ |
| 401 | bp = xfs_buf_read_flags(target, blkno, len, flags | BUF_BUSY); | 395 | bp = xfs_buf_read(target, blkno, len, flags | BUF_BUSY); |
| 402 | if (bp == NULL) { | 396 | if (bp == NULL) { |
| 403 | *bpp = NULL; | 397 | *bpp = NULL; |
| 404 | return 0; | 398 | return 0; |
| 405 | } | 399 | } |
| 406 | if (XFS_BUF_GETERROR(bp) != 0) { | 400 | if (XFS_BUF_GETERROR(bp) != 0) { |
| 407 | XFS_BUF_SUPER_STALE(bp); | 401 | XFS_BUF_SUPER_STALE(bp); |
| 408 | xfs_buftrace("READ ERROR", bp); | ||
| 409 | error = XFS_BUF_GETERROR(bp); | 402 | error = XFS_BUF_GETERROR(bp); |
| 410 | 403 | ||
| 411 | xfs_ioerror_alert("xfs_trans_read_buf", mp, | 404 | xfs_ioerror_alert("xfs_trans_read_buf", mp, |
| @@ -464,8 +457,7 @@ xfs_trans_read_buf( | |||
| 464 | */ | 457 | */ |
| 465 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | 458 | XFS_BUF_SET_FSPRIVATE2(bp, tp); |
| 466 | 459 | ||
| 467 | xfs_buftrace("TRANS READ", bp); | 460 | trace_xfs_trans_read_buf(bip); |
| 468 | xfs_buf_item_trace("READ", bip); | ||
| 469 | *bpp = bp; | 461 | *bpp = bp; |
| 470 | return 0; | 462 | return 0; |
| 471 | 463 | ||
| @@ -483,7 +475,7 @@ shutdown_abort: | |||
| 483 | ASSERT((XFS_BUF_BFLAGS(bp) & (XFS_B_STALE|XFS_B_DELWRI)) != | 475 | ASSERT((XFS_BUF_BFLAGS(bp) & (XFS_B_STALE|XFS_B_DELWRI)) != |
| 484 | (XFS_B_STALE|XFS_B_DELWRI)); | 476 | (XFS_B_STALE|XFS_B_DELWRI)); |
| 485 | 477 | ||
| 486 | xfs_buftrace("READ_BUF XFSSHUTDN", bp); | 478 | trace_xfs_trans_read_buf_shut(bp, _RET_IP_); |
| 487 | xfs_buf_relse(bp); | 479 | xfs_buf_relse(bp); |
| 488 | *bpp = NULL; | 480 | *bpp = NULL; |
| 489 | return XFS_ERROR(EIO); | 481 | return XFS_ERROR(EIO); |
| @@ -549,13 +541,14 @@ xfs_trans_brelse(xfs_trans_t *tp, | |||
| 549 | lidp = xfs_trans_find_item(tp, (xfs_log_item_t*)bip); | 541 | lidp = xfs_trans_find_item(tp, (xfs_log_item_t*)bip); |
| 550 | ASSERT(lidp != NULL); | 542 | ASSERT(lidp != NULL); |
| 551 | 543 | ||
| 544 | trace_xfs_trans_brelse(bip); | ||
| 545 | |||
| 552 | /* | 546 | /* |
| 553 | * If the release is just for a recursive lock, | 547 | * If the release is just for a recursive lock, |
| 554 | * then decrement the count and return. | 548 | * then decrement the count and return. |
| 555 | */ | 549 | */ |
| 556 | if (bip->bli_recur > 0) { | 550 | if (bip->bli_recur > 0) { |
| 557 | bip->bli_recur--; | 551 | bip->bli_recur--; |
| 558 | xfs_buf_item_trace("RELSE RECUR", bip); | ||
| 559 | return; | 552 | return; |
| 560 | } | 553 | } |
| 561 | 554 | ||
| @@ -563,10 +556,8 @@ xfs_trans_brelse(xfs_trans_t *tp, | |||
| 563 | * If the buffer is dirty within this transaction, we can't | 556 | * If the buffer is dirty within this transaction, we can't |
| 564 | * release it until we commit. | 557 | * release it until we commit. |
| 565 | */ | 558 | */ |
| 566 | if (lidp->lid_flags & XFS_LID_DIRTY) { | 559 | if (lidp->lid_flags & XFS_LID_DIRTY) |
| 567 | xfs_buf_item_trace("RELSE DIRTY", bip); | ||
| 568 | return; | 560 | return; |
| 569 | } | ||
| 570 | 561 | ||
| 571 | /* | 562 | /* |
| 572 | * If the buffer has been invalidated, then we can't release | 563 | * If the buffer has been invalidated, then we can't release |
| @@ -574,13 +565,10 @@ xfs_trans_brelse(xfs_trans_t *tp, | |||
| 574 | * as part of this transaction. This prevents us from pulling | 565 | * as part of this transaction. This prevents us from pulling |
| 575 | * the item from the AIL before we should. | 566 | * the item from the AIL before we should. |
| 576 | */ | 567 | */ |
| 577 | if (bip->bli_flags & XFS_BLI_STALE) { | 568 | if (bip->bli_flags & XFS_BLI_STALE) |
| 578 | xfs_buf_item_trace("RELSE STALE", bip); | ||
| 579 | return; | 569 | return; |
| 580 | } | ||
| 581 | 570 | ||
| 582 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | 571 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); |
| 583 | xfs_buf_item_trace("RELSE", bip); | ||
| 584 | 572 | ||
| 585 | /* | 573 | /* |
| 586 | * Free up the log item descriptor tracking the released item. | 574 | * Free up the log item descriptor tracking the released item. |
| @@ -677,7 +665,7 @@ xfs_trans_bjoin(xfs_trans_t *tp, | |||
| 677 | */ | 665 | */ |
| 678 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | 666 | XFS_BUF_SET_FSPRIVATE2(bp, tp); |
| 679 | 667 | ||
| 680 | xfs_buf_item_trace("BJOIN", bip); | 668 | trace_xfs_trans_bjoin(bip); |
| 681 | } | 669 | } |
| 682 | 670 | ||
| 683 | /* | 671 | /* |
| @@ -701,7 +689,7 @@ xfs_trans_bhold(xfs_trans_t *tp, | |||
| 701 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | 689 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); |
| 702 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 690 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 703 | bip->bli_flags |= XFS_BLI_HOLD; | 691 | bip->bli_flags |= XFS_BLI_HOLD; |
| 704 | xfs_buf_item_trace("BHOLD", bip); | 692 | trace_xfs_trans_bhold(bip); |
| 705 | } | 693 | } |
| 706 | 694 | ||
| 707 | /* | 695 | /* |
| @@ -724,7 +712,8 @@ xfs_trans_bhold_release(xfs_trans_t *tp, | |||
| 724 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 712 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 725 | ASSERT(bip->bli_flags & XFS_BLI_HOLD); | 713 | ASSERT(bip->bli_flags & XFS_BLI_HOLD); |
| 726 | bip->bli_flags &= ~XFS_BLI_HOLD; | 714 | bip->bli_flags &= ~XFS_BLI_HOLD; |
| 727 | xfs_buf_item_trace("BHOLD RELEASE", bip); | 715 | |
| 716 | trace_xfs_trans_bhold_release(bip); | ||
| 728 | } | 717 | } |
| 729 | 718 | ||
| 730 | /* | 719 | /* |
| @@ -770,6 +759,8 @@ xfs_trans_log_buf(xfs_trans_t *tp, | |||
| 770 | XFS_BUF_SET_IODONE_FUNC(bp, xfs_buf_iodone_callbacks); | 759 | XFS_BUF_SET_IODONE_FUNC(bp, xfs_buf_iodone_callbacks); |
| 771 | bip->bli_item.li_cb = (void(*)(xfs_buf_t*,xfs_log_item_t*))xfs_buf_iodone; | 760 | bip->bli_item.li_cb = (void(*)(xfs_buf_t*,xfs_log_item_t*))xfs_buf_iodone; |
| 772 | 761 | ||
| 762 | trace_xfs_trans_log_buf(bip); | ||
| 763 | |||
| 773 | /* | 764 | /* |
| 774 | * If we invalidated the buffer within this transaction, then | 765 | * If we invalidated the buffer within this transaction, then |
| 775 | * cancel the invalidation now that we're dirtying the buffer | 766 | * cancel the invalidation now that we're dirtying the buffer |
| @@ -777,7 +768,6 @@ xfs_trans_log_buf(xfs_trans_t *tp, | |||
| 777 | * because we have a reference to the buffer this entire time. | 768 | * because we have a reference to the buffer this entire time. |
| 778 | */ | 769 | */ |
| 779 | if (bip->bli_flags & XFS_BLI_STALE) { | 770 | if (bip->bli_flags & XFS_BLI_STALE) { |
| 780 | xfs_buf_item_trace("BLOG UNSTALE", bip); | ||
| 781 | bip->bli_flags &= ~XFS_BLI_STALE; | 771 | bip->bli_flags &= ~XFS_BLI_STALE; |
| 782 | ASSERT(XFS_BUF_ISSTALE(bp)); | 772 | ASSERT(XFS_BUF_ISSTALE(bp)); |
| 783 | XFS_BUF_UNSTALE(bp); | 773 | XFS_BUF_UNSTALE(bp); |
| @@ -792,7 +782,6 @@ xfs_trans_log_buf(xfs_trans_t *tp, | |||
| 792 | lidp->lid_flags &= ~XFS_LID_BUF_STALE; | 782 | lidp->lid_flags &= ~XFS_LID_BUF_STALE; |
| 793 | bip->bli_flags |= XFS_BLI_LOGGED; | 783 | bip->bli_flags |= XFS_BLI_LOGGED; |
| 794 | xfs_buf_item_log(bip, first, last); | 784 | xfs_buf_item_log(bip, first, last); |
| 795 | xfs_buf_item_trace("BLOG", bip); | ||
| 796 | } | 785 | } |
| 797 | 786 | ||
| 798 | 787 | ||
| @@ -831,6 +820,8 @@ xfs_trans_binval( | |||
| 831 | ASSERT(lidp != NULL); | 820 | ASSERT(lidp != NULL); |
| 832 | ASSERT(atomic_read(&bip->bli_refcount) > 0); | 821 | ASSERT(atomic_read(&bip->bli_refcount) > 0); |
| 833 | 822 | ||
| 823 | trace_xfs_trans_binval(bip); | ||
| 824 | |||
| 834 | if (bip->bli_flags & XFS_BLI_STALE) { | 825 | if (bip->bli_flags & XFS_BLI_STALE) { |
| 835 | /* | 826 | /* |
| 836 | * If the buffer is already invalidated, then | 827 | * If the buffer is already invalidated, then |
| @@ -843,8 +834,6 @@ xfs_trans_binval( | |||
| 843 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); | 834 | ASSERT(bip->bli_format.blf_flags & XFS_BLI_CANCEL); |
| 844 | ASSERT(lidp->lid_flags & XFS_LID_DIRTY); | 835 | ASSERT(lidp->lid_flags & XFS_LID_DIRTY); |
| 845 | ASSERT(tp->t_flags & XFS_TRANS_DIRTY); | 836 | ASSERT(tp->t_flags & XFS_TRANS_DIRTY); |
| 846 | xfs_buftrace("XFS_BINVAL RECUR", bp); | ||
| 847 | xfs_buf_item_trace("BINVAL RECUR", bip); | ||
| 848 | return; | 837 | return; |
| 849 | } | 838 | } |
| 850 | 839 | ||
| @@ -878,8 +867,6 @@ xfs_trans_binval( | |||
| 878 | (bip->bli_format.blf_map_size * sizeof(uint))); | 867 | (bip->bli_format.blf_map_size * sizeof(uint))); |
| 879 | lidp->lid_flags |= XFS_LID_DIRTY|XFS_LID_BUF_STALE; | 868 | lidp->lid_flags |= XFS_LID_DIRTY|XFS_LID_BUF_STALE; |
| 880 | tp->t_flags |= XFS_TRANS_DIRTY; | 869 | tp->t_flags |= XFS_TRANS_DIRTY; |
| 881 | xfs_buftrace("XFS_BINVAL", bp); | ||
| 882 | xfs_buf_item_trace("BINVAL", bip); | ||
| 883 | } | 870 | } |
| 884 | 871 | ||
| 885 | /* | 872 | /* |
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index b572f7e840e0..6558ffd8d140 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c | |||
| @@ -53,6 +53,7 @@ | |||
| 53 | #include "xfs_log_priv.h" | 53 | #include "xfs_log_priv.h" |
| 54 | #include "xfs_filestream.h" | 54 | #include "xfs_filestream.h" |
| 55 | #include "xfs_vnodeops.h" | 55 | #include "xfs_vnodeops.h" |
| 56 | #include "xfs_trace.h" | ||
| 56 | 57 | ||
| 57 | int | 58 | int |
| 58 | xfs_setattr( | 59 | xfs_setattr( |
| @@ -538,9 +539,8 @@ xfs_readlink_bmap( | |||
| 538 | d = XFS_FSB_TO_DADDR(mp, mval[n].br_startblock); | 539 | d = XFS_FSB_TO_DADDR(mp, mval[n].br_startblock); |
| 539 | byte_cnt = XFS_FSB_TO_B(mp, mval[n].br_blockcount); | 540 | byte_cnt = XFS_FSB_TO_B(mp, mval[n].br_blockcount); |
| 540 | 541 | ||
| 541 | bp = xfs_buf_read_flags(mp->m_ddev_targp, d, BTOBB(byte_cnt), | 542 | bp = xfs_buf_read(mp->m_ddev_targp, d, BTOBB(byte_cnt), |
| 542 | XBF_LOCK | XBF_MAPPED | | 543 | XBF_LOCK | XBF_MAPPED | XBF_DONT_BLOCK); |
| 543 | XBF_DONT_BLOCK); | ||
| 544 | error = XFS_BUF_GETERROR(bp); | 544 | error = XFS_BUF_GETERROR(bp); |
| 545 | if (error) { | 545 | if (error) { |
| 546 | xfs_ioerror_alert("xfs_readlink", | 546 | xfs_ioerror_alert("xfs_readlink", |
| @@ -709,6 +709,11 @@ xfs_fsync( | |||
| 709 | } | 709 | } |
| 710 | 710 | ||
| 711 | /* | 711 | /* |
| 712 | * Flags for xfs_free_eofblocks | ||
| 713 | */ | ||
| 714 | #define XFS_FREE_EOF_TRYLOCK (1<<0) | ||
| 715 | |||
| 716 | /* | ||
| 712 | * This is called by xfs_inactive to free any blocks beyond eof | 717 | * This is called by xfs_inactive to free any blocks beyond eof |
| 713 | * when the link count isn't zero and by xfs_dm_punch_hole() when | 718 | * when the link count isn't zero and by xfs_dm_punch_hole() when |
| 714 | * punching a hole to EOF. | 719 | * punching a hole to EOF. |
| @@ -726,7 +731,6 @@ xfs_free_eofblocks( | |||
| 726 | xfs_filblks_t map_len; | 731 | xfs_filblks_t map_len; |
| 727 | int nimaps; | 732 | int nimaps; |
| 728 | xfs_bmbt_irec_t imap; | 733 | xfs_bmbt_irec_t imap; |
| 729 | int use_iolock = (flags & XFS_FREE_EOF_LOCK); | ||
| 730 | 734 | ||
| 731 | /* | 735 | /* |
| 732 | * Figure out if there are any blocks beyond the end | 736 | * Figure out if there are any blocks beyond the end |
| @@ -768,14 +772,19 @@ xfs_free_eofblocks( | |||
| 768 | * cache and we can't | 772 | * cache and we can't |
| 769 | * do that within a transaction. | 773 | * do that within a transaction. |
| 770 | */ | 774 | */ |
| 771 | if (use_iolock) | 775 | if (flags & XFS_FREE_EOF_TRYLOCK) { |
| 776 | if (!xfs_ilock_nowait(ip, XFS_IOLOCK_EXCL)) { | ||
| 777 | xfs_trans_cancel(tp, 0); | ||
| 778 | return 0; | ||
| 779 | } | ||
| 780 | } else { | ||
| 772 | xfs_ilock(ip, XFS_IOLOCK_EXCL); | 781 | xfs_ilock(ip, XFS_IOLOCK_EXCL); |
| 782 | } | ||
| 773 | error = xfs_itruncate_start(ip, XFS_ITRUNC_DEFINITE, | 783 | error = xfs_itruncate_start(ip, XFS_ITRUNC_DEFINITE, |
| 774 | ip->i_size); | 784 | ip->i_size); |
| 775 | if (error) { | 785 | if (error) { |
| 776 | xfs_trans_cancel(tp, 0); | 786 | xfs_trans_cancel(tp, 0); |
| 777 | if (use_iolock) | 787 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); |
| 778 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | ||
| 779 | return error; | 788 | return error; |
| 780 | } | 789 | } |
| 781 | 790 | ||
| @@ -812,8 +821,7 @@ xfs_free_eofblocks( | |||
| 812 | error = xfs_trans_commit(tp, | 821 | error = xfs_trans_commit(tp, |
| 813 | XFS_TRANS_RELEASE_LOG_RES); | 822 | XFS_TRANS_RELEASE_LOG_RES); |
| 814 | } | 823 | } |
| 815 | xfs_iunlock(ip, (use_iolock ? (XFS_IOLOCK_EXCL|XFS_ILOCK_EXCL) | 824 | xfs_iunlock(ip, XFS_IOLOCK_EXCL|XFS_ILOCK_EXCL); |
| 816 | : XFS_ILOCK_EXCL)); | ||
| 817 | } | 825 | } |
| 818 | return error; | 826 | return error; |
| 819 | } | 827 | } |
| @@ -1113,7 +1121,17 @@ xfs_release( | |||
| 1113 | (ip->i_df.if_flags & XFS_IFEXTENTS)) && | 1121 | (ip->i_df.if_flags & XFS_IFEXTENTS)) && |
| 1114 | (!(ip->i_d.di_flags & | 1122 | (!(ip->i_d.di_flags & |
| 1115 | (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)))) { | 1123 | (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)))) { |
| 1116 | error = xfs_free_eofblocks(mp, ip, XFS_FREE_EOF_LOCK); | 1124 | |
| 1125 | /* | ||
| 1126 | * If we can't get the iolock just skip truncating | ||
| 1127 | * the blocks past EOF because we could deadlock | ||
| 1128 | * with the mmap_sem otherwise. We'll get another | ||
| 1129 | * chance to drop them once the last reference to | ||
| 1130 | * the inode is dropped, so we'll never leak blocks | ||
| 1131 | * permanently. | ||
| 1132 | */ | ||
| 1133 | error = xfs_free_eofblocks(mp, ip, | ||
| 1134 | XFS_FREE_EOF_TRYLOCK); | ||
| 1117 | if (error) | 1135 | if (error) |
| 1118 | return error; | 1136 | return error; |
| 1119 | } | 1137 | } |
| @@ -1184,7 +1202,7 @@ xfs_inactive( | |||
| 1184 | (!(ip->i_d.di_flags & | 1202 | (!(ip->i_d.di_flags & |
| 1185 | (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)) || | 1203 | (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)) || |
| 1186 | (ip->i_delayed_blks != 0)))) { | 1204 | (ip->i_delayed_blks != 0)))) { |
| 1187 | error = xfs_free_eofblocks(mp, ip, XFS_FREE_EOF_LOCK); | 1205 | error = xfs_free_eofblocks(mp, ip, 0); |
| 1188 | if (error) | 1206 | if (error) |
| 1189 | return VN_INACTIVE_CACHE; | 1207 | return VN_INACTIVE_CACHE; |
| 1190 | } | 1208 | } |
| @@ -1380,7 +1398,6 @@ xfs_lookup( | |||
| 1380 | if (error) | 1398 | if (error) |
| 1381 | goto out_free_name; | 1399 | goto out_free_name; |
| 1382 | 1400 | ||
| 1383 | xfs_itrace_ref(*ipp); | ||
| 1384 | return 0; | 1401 | return 0; |
| 1385 | 1402 | ||
| 1386 | out_free_name: | 1403 | out_free_name: |
| @@ -1526,7 +1543,6 @@ xfs_create( | |||
| 1526 | * At this point, we've gotten a newly allocated inode. | 1543 | * At this point, we've gotten a newly allocated inode. |
| 1527 | * It is locked (and joined to the transaction). | 1544 | * It is locked (and joined to the transaction). |
| 1528 | */ | 1545 | */ |
| 1529 | xfs_itrace_ref(ip); | ||
| 1530 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); | 1546 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); |
| 1531 | 1547 | ||
| 1532 | /* | 1548 | /* |
| @@ -1986,9 +2002,6 @@ xfs_remove( | |||
| 1986 | if (!is_dir && link_zero && xfs_inode_is_filestream(ip)) | 2002 | if (!is_dir && link_zero && xfs_inode_is_filestream(ip)) |
| 1987 | xfs_filestream_deassociate(ip); | 2003 | xfs_filestream_deassociate(ip); |
| 1988 | 2004 | ||
| 1989 | xfs_itrace_exit(ip); | ||
| 1990 | xfs_itrace_exit(dp); | ||
| 1991 | |||
| 1992 | std_return: | 2005 | std_return: |
| 1993 | if (DM_EVENT_ENABLED(dp, DM_EVENT_POSTREMOVE)) { | 2006 | if (DM_EVENT_ENABLED(dp, DM_EVENT_POSTREMOVE)) { |
| 1994 | XFS_SEND_NAMESP(mp, DM_EVENT_POSTREMOVE, dp, DM_RIGHT_NULL, | 2007 | XFS_SEND_NAMESP(mp, DM_EVENT_POSTREMOVE, dp, DM_RIGHT_NULL, |
| @@ -2285,7 +2298,6 @@ xfs_symlink( | |||
| 2285 | goto error_return; | 2298 | goto error_return; |
| 2286 | goto error1; | 2299 | goto error1; |
| 2287 | } | 2300 | } |
| 2288 | xfs_itrace_ref(ip); | ||
| 2289 | 2301 | ||
| 2290 | /* | 2302 | /* |
| 2291 | * An error after we've joined dp to the transaction will result in the | 2303 | * An error after we've joined dp to the transaction will result in the |
| @@ -2456,46 +2468,6 @@ xfs_set_dmattrs( | |||
| 2456 | return error; | 2468 | return error; |
| 2457 | } | 2469 | } |
| 2458 | 2470 | ||
| 2459 | int | ||
| 2460 | xfs_reclaim( | ||
| 2461 | xfs_inode_t *ip) | ||
| 2462 | { | ||
| 2463 | |||
| 2464 | xfs_itrace_entry(ip); | ||
| 2465 | |||
| 2466 | ASSERT(!VN_MAPPED(VFS_I(ip))); | ||
| 2467 | |||
| 2468 | /* bad inode, get out here ASAP */ | ||
| 2469 | if (is_bad_inode(VFS_I(ip))) { | ||
| 2470 | xfs_ireclaim(ip); | ||
| 2471 | return 0; | ||
| 2472 | } | ||
| 2473 | |||
| 2474 | xfs_ioend_wait(ip); | ||
| 2475 | |||
| 2476 | ASSERT(XFS_FORCED_SHUTDOWN(ip->i_mount) || ip->i_delayed_blks == 0); | ||
| 2477 | |||
| 2478 | /* | ||
| 2479 | * If we have nothing to flush with this inode then complete the | ||
| 2480 | * teardown now, otherwise break the link between the xfs inode and the | ||
| 2481 | * linux inode and clean up the xfs inode later. This avoids flushing | ||
| 2482 | * the inode to disk during the delete operation itself. | ||
| 2483 | * | ||
| 2484 | * When breaking the link, we need to set the XFS_IRECLAIMABLE flag | ||
| 2485 | * first to ensure that xfs_iunpin() will never see an xfs inode | ||
| 2486 | * that has a linux inode being reclaimed. Synchronisation is provided | ||
| 2487 | * by the i_flags_lock. | ||
| 2488 | */ | ||
| 2489 | if (!ip->i_update_core && (ip->i_itemp == NULL)) { | ||
| 2490 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
| 2491 | xfs_iflock(ip); | ||
| 2492 | xfs_iflags_set(ip, XFS_IRECLAIMABLE); | ||
| 2493 | return xfs_reclaim_inode(ip, 1, XFS_IFLUSH_DELWRI_ELSE_SYNC); | ||
| 2494 | } | ||
| 2495 | xfs_inode_set_reclaim_tag(ip); | ||
| 2496 | return 0; | ||
| 2497 | } | ||
| 2498 | |||
| 2499 | /* | 2471 | /* |
| 2500 | * xfs_alloc_file_space() | 2472 | * xfs_alloc_file_space() |
| 2501 | * This routine allocates disk space for the given file. | 2473 | * This routine allocates disk space for the given file. |
| @@ -2868,7 +2840,6 @@ xfs_free_file_space( | |||
| 2868 | ioffset = offset & ~(rounding - 1); | 2840 | ioffset = offset & ~(rounding - 1); |
| 2869 | 2841 | ||
| 2870 | if (VN_CACHED(VFS_I(ip)) != 0) { | 2842 | if (VN_CACHED(VFS_I(ip)) != 0) { |
| 2871 | xfs_inval_cached_trace(ip, ioffset, -1, ioffset, -1); | ||
| 2872 | error = xfs_flushinval_pages(ip, ioffset, -1, FI_REMAPF_LOCKED); | 2843 | error = xfs_flushinval_pages(ip, ioffset, -1, FI_REMAPF_LOCKED); |
| 2873 | if (error) | 2844 | if (error) |
| 2874 | goto out_unlock_iolock; | 2845 | goto out_unlock_iolock; |
diff --git a/fs/xfs/xfs_vnodeops.h b/fs/xfs/xfs_vnodeops.h index a9e102de71a1..167a467403a5 100644 --- a/fs/xfs/xfs_vnodeops.h +++ b/fs/xfs/xfs_vnodeops.h | |||
| @@ -38,7 +38,6 @@ int xfs_symlink(struct xfs_inode *dp, struct xfs_name *link_name, | |||
| 38 | const char *target_path, mode_t mode, struct xfs_inode **ipp, | 38 | const char *target_path, mode_t mode, struct xfs_inode **ipp, |
| 39 | cred_t *credp); | 39 | cred_t *credp); |
| 40 | int xfs_set_dmattrs(struct xfs_inode *ip, u_int evmask, u_int16_t state); | 40 | int xfs_set_dmattrs(struct xfs_inode *ip, u_int evmask, u_int16_t state); |
| 41 | int xfs_reclaim(struct xfs_inode *ip); | ||
| 42 | int xfs_change_file_space(struct xfs_inode *ip, int cmd, | 41 | int xfs_change_file_space(struct xfs_inode *ip, int cmd, |
| 43 | xfs_flock64_t *bf, xfs_off_t offset, int attr_flags); | 42 | xfs_flock64_t *bf, xfs_off_t offset, int attr_flags); |
| 44 | int xfs_rename(struct xfs_inode *src_dp, struct xfs_name *src_name, | 43 | int xfs_rename(struct xfs_inode *src_dp, struct xfs_name *src_name, |
