diff options
Diffstat (limited to 'fs/xfs/xfs_mount.c')
-rw-r--r-- | fs/xfs/xfs_mount.c | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 10dbf203c62f..4be5c0b2d296 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
@@ -1721,15 +1721,14 @@ xfs_mount_log_sbunit( | |||
1721 | * is present to prevent thrashing). | 1721 | * is present to prevent thrashing). |
1722 | */ | 1722 | */ |
1723 | 1723 | ||
1724 | #ifdef CONFIG_HOTPLUG_CPU | ||
1724 | /* | 1725 | /* |
1725 | * hot-plug CPU notifier support. | 1726 | * hot-plug CPU notifier support. |
1726 | * | 1727 | * |
1727 | * We cannot use the hotcpu_register() function because it does | 1728 | * We need a notifier per filesystem as we need to be able to identify |
1728 | * not allow notifier instances. We need a notifier per filesystem | 1729 | * the filesystem to balance the counters out. This is achieved by |
1729 | * as we need to be able to identify the filesystem to balance | 1730 | * having a notifier block embedded in the xfs_mount_t and doing pointer |
1730 | * the counters out. This is achieved by having a notifier block | 1731 | * magic to get the mount pointer from the notifier block address. |
1731 | * embedded in the xfs_mount_t and doing pointer magic to get the | ||
1732 | * mount pointer from the notifier block address. | ||
1733 | */ | 1732 | */ |
1734 | STATIC int | 1733 | STATIC int |
1735 | xfs_icsb_cpu_notify( | 1734 | xfs_icsb_cpu_notify( |
@@ -1779,6 +1778,7 @@ xfs_icsb_cpu_notify( | |||
1779 | 1778 | ||
1780 | return NOTIFY_OK; | 1779 | return NOTIFY_OK; |
1781 | } | 1780 | } |
1781 | #endif /* CONFIG_HOTPLUG_CPU */ | ||
1782 | 1782 | ||
1783 | int | 1783 | int |
1784 | xfs_icsb_init_counters( | 1784 | xfs_icsb_init_counters( |
@@ -1791,9 +1791,11 @@ xfs_icsb_init_counters( | |||
1791 | if (mp->m_sb_cnts == NULL) | 1791 | if (mp->m_sb_cnts == NULL) |
1792 | return -ENOMEM; | 1792 | return -ENOMEM; |
1793 | 1793 | ||
1794 | #ifdef CONFIG_HOTPLUG_CPU | ||
1794 | mp->m_icsb_notifier.notifier_call = xfs_icsb_cpu_notify; | 1795 | mp->m_icsb_notifier.notifier_call = xfs_icsb_cpu_notify; |
1795 | mp->m_icsb_notifier.priority = 0; | 1796 | mp->m_icsb_notifier.priority = 0; |
1796 | register_cpu_notifier(&mp->m_icsb_notifier); | 1797 | register_hotcpu_notifier(&mp->m_icsb_notifier); |
1798 | #endif /* CONFIG_HOTPLUG_CPU */ | ||
1797 | 1799 | ||
1798 | for_each_online_cpu(i) { | 1800 | for_each_online_cpu(i) { |
1799 | cntp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, i); | 1801 | cntp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, i); |
@@ -1812,7 +1814,7 @@ xfs_icsb_destroy_counters( | |||
1812 | xfs_mount_t *mp) | 1814 | xfs_mount_t *mp) |
1813 | { | 1815 | { |
1814 | if (mp->m_sb_cnts) { | 1816 | if (mp->m_sb_cnts) { |
1815 | unregister_cpu_notifier(&mp->m_icsb_notifier); | 1817 | unregister_hotcpu_notifier(&mp->m_icsb_notifier); |
1816 | free_percpu(mp->m_sb_cnts); | 1818 | free_percpu(mp->m_sb_cnts); |
1817 | } | 1819 | } |
1818 | } | 1820 | } |
@@ -2026,7 +2028,7 @@ xfs_icsb_balance_counter( | |||
2026 | xfs_sb_field_t field, | 2028 | xfs_sb_field_t field, |
2027 | int flags) | 2029 | int flags) |
2028 | { | 2030 | { |
2029 | uint64_t count, resid = 0; | 2031 | uint64_t count, resid; |
2030 | int weight = num_online_cpus(); | 2032 | int weight = num_online_cpus(); |
2031 | int s; | 2033 | int s; |
2032 | 2034 | ||
@@ -2058,6 +2060,7 @@ xfs_icsb_balance_counter( | |||
2058 | break; | 2060 | break; |
2059 | default: | 2061 | default: |
2060 | BUG(); | 2062 | BUG(); |
2063 | count = resid = 0; /* quiet, gcc */ | ||
2061 | break; | 2064 | break; |
2062 | } | 2065 | } |
2063 | 2066 | ||