aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_iget.c
diff options
context:
space:
mode:
Diffstat (limited to 'fs/xfs/xfs_iget.c')
-rw-r--r--fs/xfs/xfs_iget.c29
1 files changed, 18 insertions, 11 deletions
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index 155e798f30a1..6845db90818f 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -190,13 +190,12 @@ xfs_iget_cache_hit(
190 trace_xfs_iget_reclaim(ip); 190 trace_xfs_iget_reclaim(ip);
191 191
192 /* 192 /*
193 * We need to set XFS_INEW atomically with clearing the 193 * We need to set XFS_IRECLAIM to prevent xfs_reclaim_inode
194 * reclaimable tag so that we do have an indicator of the 194 * from stomping over us while we recycle the inode. We can't
195 * inode still being initialized. 195 * clear the radix tree reclaimable tag yet as it requires
196 * pag_ici_lock to be held exclusive.
196 */ 197 */
197 ip->i_flags |= XFS_INEW; 198 ip->i_flags |= XFS_IRECLAIM;
198 ip->i_flags &= ~XFS_IRECLAIMABLE;
199 __xfs_inode_clear_reclaim_tag(mp, pag, ip);
200 199
201 spin_unlock(&ip->i_flags_lock); 200 spin_unlock(&ip->i_flags_lock);
202 read_unlock(&pag->pag_ici_lock); 201 read_unlock(&pag->pag_ici_lock);
@@ -216,7 +215,15 @@ xfs_iget_cache_hit(
216 trace_xfs_iget_reclaim(ip); 215 trace_xfs_iget_reclaim(ip);
217 goto out_error; 216 goto out_error;
218 } 217 }
218
219 write_lock(&pag->pag_ici_lock);
220 spin_lock(&ip->i_flags_lock);
221 ip->i_flags &= ~(XFS_IRECLAIMABLE | XFS_IRECLAIM);
222 ip->i_flags |= XFS_INEW;
223 __xfs_inode_clear_reclaim_tag(mp, pag, ip);
219 inode->i_state = I_NEW; 224 inode->i_state = I_NEW;
225 spin_unlock(&ip->i_flags_lock);
226 write_unlock(&pag->pag_ici_lock);
220 } else { 227 } else {
221 /* If the VFS inode is being torn down, pause and try again. */ 228 /* If the VFS inode is being torn down, pause and try again. */
222 if (!igrab(inode)) { 229 if (!igrab(inode)) {
@@ -374,7 +381,7 @@ xfs_iget(
374 return EINVAL; 381 return EINVAL;
375 382
376 /* get the perag structure and ensure that it's inode capable */ 383 /* get the perag structure and ensure that it's inode capable */
377 pag = xfs_get_perag(mp, ino); 384 pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino));
378 if (!pag->pagi_inodeok) 385 if (!pag->pagi_inodeok)
379 return EINVAL; 386 return EINVAL;
380 ASSERT(pag->pag_ici_init); 387 ASSERT(pag->pag_ici_init);
@@ -398,7 +405,7 @@ again:
398 if (error) 405 if (error)
399 goto out_error_or_again; 406 goto out_error_or_again;
400 } 407 }
401 xfs_put_perag(mp, pag); 408 xfs_perag_put(pag);
402 409
403 *ipp = ip; 410 *ipp = ip;
404 411
@@ -417,7 +424,7 @@ out_error_or_again:
417 delay(1); 424 delay(1);
418 goto again; 425 goto again;
419 } 426 }
420 xfs_put_perag(mp, pag); 427 xfs_perag_put(pag);
421 return error; 428 return error;
422} 429}
423 430
@@ -488,12 +495,12 @@ xfs_ireclaim(
488 * added to the tree assert that it's been there before to catch 495 * added to the tree assert that it's been there before to catch
489 * problems with the inode life time early on. 496 * problems with the inode life time early on.
490 */ 497 */
491 pag = xfs_get_perag(mp, ip->i_ino); 498 pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino));
492 write_lock(&pag->pag_ici_lock); 499 write_lock(&pag->pag_ici_lock);
493 if (!radix_tree_delete(&pag->pag_ici_root, agino)) 500 if (!radix_tree_delete(&pag->pag_ici_root, agino))
494 ASSERT(0); 501 ASSERT(0);
495 write_unlock(&pag->pag_ici_lock); 502 write_unlock(&pag->pag_ici_lock);
496 xfs_put_perag(mp, pag); 503 xfs_perag_put(pag);
497 504
498 /* 505 /*
499 * Here we do an (almost) spurious inode lock in order to coordinate 506 * Here we do an (almost) spurious inode lock in order to coordinate