1 files changed, 31 insertions, 30 deletions

diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c
index ce9f673f2b4c..c2939b8f8d24 100644
--- a/fs/xfs/xfs_attr.c
+++ b/fs/xfs/xfs_attr.c
@@ -200,7 +200,7 @@ xfs_attr_get(bhv_desc_t *bdp, char *name, char *value, int *valuelenp,
         return(error);
 }
 
-int
+STATIC int
 xfs_attr_set_int(xfs_inode_t *dp, char *name, int namelen,
                  char *value, int valuelen, int flags)
 {
@@ -220,12 +220,18 @@ xfs_attr_set_int(xfs_inode_t *dp, char *name, int namelen,
                 return (error);
 
         /*
+         * Determine space new attribute will use, and if it would be
+         * "local" or "remote" (note: local != inline).
+         */
+        size = xfs_attr_leaf_newentsize(namelen, valuelen,
+                                        mp->m_sb.sb_blocksize, &local);
+
+        /*
          * If the inode doesn't have an attribute fork, add one.
          * (inode must not be locked when we call this routine)
          */
         if (XFS_IFORK_Q(dp) == 0) {
-                error = xfs_bmap_add_attrfork(dp, rsvd);
-                if (error)
+                if ((error = xfs_bmap_add_attrfork(dp, size, rsvd)))
                         return(error);
         }
 
@@ -243,14 +249,9 @@ xfs_attr_set_int(xfs_inode_t *dp, char *name, int namelen,
         args.firstblock = &firstblock;
         args.flist = &flist;
         args.whichfork = XFS_ATTR_FORK;
+        args.addname = 1;
         args.oknoent = 1;
 
-        /* Determine space new attribute will use, and if it will be inline
-         * or out of line.
-         */
-        size = xfs_attr_leaf_newentsize(namelen, valuelen,
-                                        mp->m_sb.sb_blocksize, &local);
-
         nblks = XFS_DAENTER_SPACE_RES(mp, XFS_ATTR_FORK);
         if (local) {
                 if (size > (mp->m_sb.sb_blocksize >> 1)) {
@@ -322,7 +323,7 @@ xfs_attr_set_int(xfs_inode_t *dp, char *name, int namelen,
                  * Build initial attribute list (if required).
                  */
                 if (dp->i_d.di_aformat == XFS_DINODE_FMT_EXTENTS)
-                        (void)xfs_attr_shortform_create(&args);
+                        xfs_attr_shortform_create(&args);
 
                 /*
                  * Try to add the attr to the attribute list in
@@ -467,7 +468,7 @@ xfs_attr_set(bhv_desc_t *bdp, char *name, char *value, int valuelen, int flags,
  * Generic handler routine to remove a name from an attribute list.
  * Transitions attribute list from Btree to shortform as necessary.
  */
-int
+STATIC int
 xfs_attr_remove_int(xfs_inode_t *dp, char *name, int namelen, int flags)
 {
         xfs_da_args_t   args;
@@ -523,7 +524,6 @@ xfs_attr_remove_int(xfs_inode_t *dp, char *name, int namelen, int flags)
                                       XFS_ATTRRM_LOG_COUNT))) {
                 xfs_trans_cancel(args.trans, 0);
                 return(error);
-
         }
 
         xfs_ilock(dp, XFS_ILOCK_EXCL);
@@ -822,7 +822,7 @@ out:
 STATIC int
 xfs_attr_shortform_addname(xfs_da_args_t *args)
 {
-        int newsize, retval;
+        int newsize, forkoff, retval;
 
         retval = xfs_attr_shortform_lookup(args);
         if ((args->flags & ATTR_REPLACE) && (retval == ENOATTR)) {
@@ -834,16 +834,18 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
                 ASSERT(retval == 0);
         }
 
+        if (args->namelen >= XFS_ATTR_SF_ENTSIZE_MAX ||
+            args->valuelen >= XFS_ATTR_SF_ENTSIZE_MAX)
+                return(XFS_ERROR(ENOSPC));
+
         newsize = XFS_ATTR_SF_TOTSIZE(args->dp);
         newsize += XFS_ATTR_SF_ENTSIZE_BYNAME(args->namelen, args->valuelen);
-        if ((newsize <= XFS_IFORK_ASIZE(args->dp)) &&
-            (args->namelen < XFS_ATTR_SF_ENTSIZE_MAX) &&
-            (args->valuelen < XFS_ATTR_SF_ENTSIZE_MAX)) {
-                retval = xfs_attr_shortform_add(args);
-                ASSERT(retval == 0);
-        } else {
+
+        forkoff = xfs_attr_shortform_bytesfit(args->dp, newsize);
+        if (!forkoff)
                 return(XFS_ERROR(ENOSPC));
-        }
+
+        xfs_attr_shortform_add(args, forkoff);
         return(0);
 }
 
@@ -863,7 +865,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
 {
         xfs_inode_t *dp;
         xfs_dabuf_t *bp;
-        int retval, error, committed;
+        int retval, error, committed, forkoff;
 
         /*
          * Read the (only) block in the attribute list in.
@@ -1006,9 +1008,9 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                 /*
                  * If the result is small enough, shrink it all into the inode.
                  */
-                if (xfs_attr_shortform_allfit(bp, dp)) {
+                if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
                         XFS_BMAP_INIT(args->flist, args->firstblock);
-                        error = xfs_attr_leaf_to_shortform(bp, args);
+                        error = xfs_attr_leaf_to_shortform(bp, args, forkoff);
                         /* bp is gone due to xfs_da_shrink_inode */
                         if (!error) {
                                 error = xfs_bmap_finish(&args->trans,
@@ -1060,8 +1062,7 @@ xfs_attr_leaf_removename(xfs_da_args_t *args)
 {
         xfs_inode_t *dp;
         xfs_dabuf_t *bp;
-        int committed;
-        int error;
+        int error, committed, forkoff;
 
         /*
          * Remove the attribute.
@@ -1086,9 +1087,9 @@ xfs_attr_leaf_removename(xfs_da_args_t *args)
         /*
          * If the result is small enough, shrink it all into the inode.
          */
-        if (xfs_attr_shortform_allfit(bp, dp)) {
+        if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
                 XFS_BMAP_INIT(args->flist, args->firstblock);
-                error = xfs_attr_leaf_to_shortform(bp, args);
+                error = xfs_attr_leaf_to_shortform(bp, args, forkoff);
                 /* bp is gone due to xfs_da_shrink_inode */
                 if (!error) {
                         error = xfs_bmap_finish(&args->trans, args->flist,
@@ -1459,7 +1460,7 @@ xfs_attr_node_removename(xfs_da_args_t *args)
         xfs_da_state_blk_t *blk;
         xfs_inode_t *dp;
         xfs_dabuf_t *bp;
-        int retval, error, committed;
+        int retval, error, committed, forkoff;
 
         /*
          * Tie a string around our finger to remind us where we are.
@@ -1580,9 +1581,9 @@ xfs_attr_node_removename(xfs_da_args_t *args)
                                       bp->data)->hdr.info.magic, ARCH_CONVERT)
                                                        == XFS_ATTR_LEAF_MAGIC);
 
-                if (xfs_attr_shortform_allfit(bp, dp)) {
+                if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
                         XFS_BMAP_INIT(args->flist, args->firstblock);
-                        error = xfs_attr_leaf_to_shortform(bp, args);
+                        error = xfs_attr_leaf_to_shortform(bp, args, forkoff);
                         /* bp is gone due to xfs_da_shrink_inode */
                         if (!error) {
                                 error = xfs_bmap_finish(&args->trans,