3 files changed, 54 insertions, 60 deletions

diff --git a/fs/xfs/support/debug.c b/fs/xfs/support/debug.c
index bb6dc91ea261..b08b3d9345b7 100644
--- a/fs/xfs/support/debug.c
+++ b/fs/xfs/support/debug.c
@@ -27,45 +27,12 @@ static DEFINE_SPINLOCK(xfs_err_lock);
 /* Translate from CE_FOO to KERN_FOO, err_level(CE_FOO) == KERN_FOO */
 #define XFS_MAX_ERR_LEVEL       7
 #define XFS_ERR_MASK            ((1 << 3) - 1)
-static char             *err_level[XFS_MAX_ERR_LEVEL+1] =
+static const char * const       err_level[XFS_MAX_ERR_LEVEL+1] =
                                         {KERN_EMERG, KERN_ALERT, KERN_CRIT,
                                          KERN_ERR, KERN_WARNING, KERN_NOTICE,
                                          KERN_INFO, KERN_DEBUG};
 
 void
-assfail(char *a, char *f, int l)
-{
-    printk("XFS assertion failed: %s, file: %s, line: %d\n", a, f, l);
-    BUG();
-}
-
-#if ((defined(DEBUG) || defined(INDUCE_IO_ERRROR)) && !defined(NO_WANT_RANDOM))
-
-unsigned long
-random(void)
-{
-        static unsigned long    RandomValue = 1;
-        /* cycles pseudo-randomly through all values between 1 and 2^31 - 2 */
-        register long   rv = RandomValue;
-        register long   lo;
-        register long   hi;
-
-        hi = rv / 127773;
-        lo = rv % 127773;
-        rv = 16807 * lo - 2836 * hi;
-        if( rv <= 0 ) rv += 2147483647;
-        return( RandomValue = rv );
-}
-
-int
-get_thread_id(void)
-{
-        return current->pid;
-}
-
-#endif /* DEBUG || INDUCE_IO_ERRROR || !NO_WANT_RANDOM */
-
-void
 cmn_err(register int level, char *fmt, ...)
 {
         char    *fp = fmt;
@@ -90,7 +57,6 @@ cmn_err(register int level, char *fmt, ...)
                 BUG();
 }
 
-
 void
 icmn_err(register int level, char *fmt, va_list ap)
 {
@@ -109,3 +75,27 @@ icmn_err(register int level, char *fmt, va_list ap)
         if (level == CE_PANIC)
                 BUG();
 }
+
+void
+assfail(char *expr, char *file, int line)
+{
+        printk("Assertion failed: %s, file: %s, line: %d\n", expr, file, line);
+        BUG();
+}
+
+#if ((defined(DEBUG) || defined(INDUCE_IO_ERRROR)) && !defined(NO_WANT_RANDOM))
+unsigned long random(void)
+{
+        static unsigned long    RandomValue = 1;
+        /* cycles pseudo-randomly through all values between 1 and 2^31 - 2 */
+        register long   rv = RandomValue;
+        register long   lo;
+        register long   hi;
+
+        hi = rv / 127773;
+        lo = rv % 127773;
+        rv = 16807 * lo - 2836 * hi;
+        if (rv <= 0) rv += 2147483647;
+        return RandomValue = rv;
+}
+#endif /* DEBUG || INDUCE_IO_ERRROR || !NO_WANT_RANDOM */
diff --git a/fs/xfs/support/debug.h b/fs/xfs/support/debug.h
index aff558664c32..e3bf58112e7e 100644
--- a/fs/xfs/support/debug.h
+++ b/fs/xfs/support/debug.h
@@ -31,24 +31,23 @@ extern void icmn_err(int, char *, va_list)
         __attribute__ ((format (printf, 2, 0)));
 extern void cmn_err(int, char *, ...)
         __attribute__ ((format (printf, 2, 3)));
+extern void assfail(char *expr, char *f, int l);
 
-#ifndef STATIC
-# define STATIC static
-#endif
+#define prdev(fmt,targ,args...) \
+        printk("Device %s - " fmt "\n", XFS_BUFTARG_NAME(targ), ## args)
 
-#ifdef DEBUG
-# define ASSERT(EX)     ((EX) ? ((void)0) : assfail(#EX, __FILE__, __LINE__))
-#else
-# define ASSERT(x)      ((void)0)
-#endif
+#define ASSERT_ALWAYS(expr)     \
+        (unlikely((expr) != 0) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
 
-extern void assfail(char *, char *, int);
-#ifdef DEBUG
+#ifndef DEBUG
+# define ASSERT(expr)   ((void)0)
+#else
+# define ASSERT(expr)   ASSERT_ALWAYS(expr)
 extern unsigned long random(void);
-extern int get_thread_id(void);
 #endif
 
-#define ASSERT_ALWAYS(EX)  ((EX)?((void)0):assfail(#EX, __FILE__, __LINE__))
-#define debug_stop_all_cpus(param)      /* param is "cpumask_t *" */
+#ifndef STATIC
+# define STATIC static
+#endif
 
 #endif  /* __XFS_SUPPORT_DEBUG_H__ */
diff --git a/fs/xfs/support/uuid.c b/fs/xfs/support/uuid.c
index 70ce40914c8a..a3d565a67734 100644
--- a/fs/xfs/support/uuid.c
+++ b/fs/xfs/support/uuid.c
@@ -24,9 +24,19 @@ static uuid_t	*uuid_table;
 void
 uuid_init(void)
 {
-        mutex_init(&uuid_monitor, MUTEX_DEFAULT, "uuid_monitor");
+        mutex_init(&uuid_monitor);
 }
 
+
+/* IRIX interpretation of an uuid_t */
+typedef struct {
+        __be32  uu_timelow;
+        __be16  uu_timemid;
+        __be16  uu_timehi;
+        __be16  uu_clockseq;
+        __be16  uu_node[3];
+} xfs_uu_t;
+
 /*
  * uuid_getnodeuniq - obtain the node unique fields of a UUID.
  *
@@ -36,16 +46,11 @@ uuid_init(void)
 void
 uuid_getnodeuniq(uuid_t *uuid, int fsid [2])
 {
-        char    *uu = (char *)uuid;
-
-        /* on IRIX, this function assumes big-endian fields within
-         * the uuid, so we use INT_GET to get the same result on
-         * little-endian systems
-         */
+        xfs_uu_t *uup = (xfs_uu_t *)uuid;
 
-        fsid[0] = (INT_GET(*(u_int16_t*)(uu+8), ARCH_CONVERT) << 16) +
-                   INT_GET(*(u_int16_t*)(uu+4), ARCH_CONVERT);
-        fsid[1] =  INT_GET(*(u_int32_t*)(uu  ), ARCH_CONVERT);
+        fsid[0] = (be16_to_cpu(uup->uu_clockseq) << 16) |
+                   be16_to_cpu(uup->uu_timemid);
+        fsid[1] = be16_to_cpu(uup->uu_timelow);
 }
 
 void
@@ -94,7 +99,7 @@ uuid_table_insert(uuid_t *uuid)
 {
         int     i, hole;
 
-        mutex_lock(&uuid_monitor, PVFS);
+        mutex_lock(&uuid_monitor);
         for (i = 0, hole = -1; i < uuid_table_size; i++) {
                 if (uuid_is_nil(&uuid_table[i])) {
                         hole = i;
@@ -122,7 +127,7 @@ uuid_table_remove(uuid_t *uuid)
 {
         int     i;
 
-        mutex_lock(&uuid_monitor, PVFS);
+        mutex_lock(&uuid_monitor);
         for (i = 0; i < uuid_table_size; i++) {
                 if (uuid_is_nil(&uuid_table[i]))
                         continue;