7 files changed, 38 insertions, 44 deletions

diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
index 201049ac8a96..ea521f846d97 100644
--- a/fs/udf/balloc.c
+++ b/fs/udf/balloc.c
@@ -152,7 +152,7 @@ static void udf_bitmap_free_blocks(struct super_block * sb,
         int bitmap_nr;
         unsigned long overflow;
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         if (bloc.logicalBlockNum < 0 ||
                 (bloc.logicalBlockNum + count) > UDF_SB_PARTLEN(sb, bloc.partitionReferenceNum))
         {
@@ -211,7 +211,7 @@ error_return:
         sb->s_dirt = 1;
         if (UDF_SB_LVIDBH(sb))
                 mark_buffer_dirty(UDF_SB_LVIDBH(sb));
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         return;
 }
 
@@ -226,7 +226,7 @@ static int udf_bitmap_prealloc_blocks(struct super_block * sb,
         int nr_groups, bitmap_nr;
         struct buffer_head *bh;
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         if (first_block < 0 || first_block >= UDF_SB_PARTLEN(sb, partition))
                 goto out;
 
@@ -275,7 +275,7 @@ out:
                 mark_buffer_dirty(UDF_SB_LVIDBH(sb));
         }
         sb->s_dirt = 1;
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         return alloc_count;
 }
 
@@ -291,7 +291,7 @@ static int udf_bitmap_new_block(struct super_block * sb,
         int newblock = 0;
 
         *err = -ENOSPC;
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
 
 repeat:
         if (goal < 0 || goal >= UDF_SB_PARTLEN(sb, partition))
@@ -364,7 +364,7 @@ repeat:
         }
         if (i >= (nr_groups*2))
         {
-                up(&sbi->s_alloc_sem);
+                mutex_unlock(&sbi->s_alloc_mutex);
                 return newblock;
         }
         if (bit < sb->s_blocksize << 3)
@@ -373,7 +373,7 @@ repeat:
                 bit = udf_find_next_one_bit(bh->b_data, sb->s_blocksize << 3, group_start << 3);
         if (bit >= sb->s_blocksize << 3)
         {
-                up(&sbi->s_alloc_sem);
+                mutex_unlock(&sbi->s_alloc_mutex);
                 return 0;
         }
 
@@ -387,7 +387,7 @@ got_block:
          */
         if (inode && DQUOT_ALLOC_BLOCK(inode, 1))
         {
-                up(&sbi->s_alloc_sem);
+                mutex_unlock(&sbi->s_alloc_mutex);
                 *err = -EDQUOT;
                 return 0;
         }
@@ -410,13 +410,13 @@ got_block:
                 mark_buffer_dirty(UDF_SB_LVIDBH(sb));
         }
         sb->s_dirt = 1;
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         *err = 0;
         return newblock;
 
 error_return:
         *err = -EIO;
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         return 0;
 }
 
@@ -433,7 +433,7 @@ static void udf_table_free_blocks(struct super_block * sb,
         int8_t etype;
         int i;
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         if (bloc.logicalBlockNum < 0 ||
                 (bloc.logicalBlockNum + count) > UDF_SB_PARTLEN(sb, bloc.partitionReferenceNum))
         {
@@ -666,7 +666,7 @@ static void udf_table_free_blocks(struct super_block * sb,
 
 error_return:
         sb->s_dirt = 1;
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         return;
 }
 
@@ -692,7 +692,7 @@ static int udf_table_prealloc_blocks(struct super_block * sb,
         else
                 return 0;
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         extoffset = sizeof(struct unallocSpaceEntry);
         bloc = UDF_I_LOCATION(table);
 
@@ -736,7 +736,7 @@ static int udf_table_prealloc_blocks(struct super_block * sb,
                 mark_buffer_dirty(UDF_SB_LVIDBH(sb));
                 sb->s_dirt = 1;
         }
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         return alloc_count;
 }
 
@@ -761,7 +761,7 @@ static int udf_table_new_block(struct super_block * sb,
         else
                 return newblock;
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         if (goal < 0 || goal >= UDF_SB_PARTLEN(sb, partition))
                 goal = 0;
 
@@ -811,7 +811,7 @@ static int udf_table_new_block(struct super_block * sb,
         if (spread == 0xFFFFFFFF)
         {
                 udf_release_data(goal_bh);
-                up(&sbi->s_alloc_sem);
+                mutex_unlock(&sbi->s_alloc_mutex);
                 return 0;
         }
 
@@ -827,7 +827,7 @@ static int udf_table_new_block(struct super_block * sb,
         if (inode && DQUOT_ALLOC_BLOCK(inode, 1))
         {
                 udf_release_data(goal_bh);
-                up(&sbi->s_alloc_sem);
+                mutex_unlock(&sbi->s_alloc_mutex);
                 *err = -EDQUOT;
                 return 0;
         }
@@ -846,7 +846,7 @@ static int udf_table_new_block(struct super_block * sb,
         }
 
         sb->s_dirt = 1;
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
         *err = 0;
         return newblock;
 }
diff --git a/fs/udf/dir.c b/fs/udf/dir.c
index f5222527fe39..8c28efa3b8ff 100644
--- a/fs/udf/dir.c
+++ b/fs/udf/dir.c
@@ -42,7 +42,7 @@ static int do_udf_readdir(struct inode *, struct file *, filldir_t, void *);
 
 /* readdir and lookup functions */
 
-struct file_operations udf_dir_operations = {
+const struct file_operations udf_dir_operations = {
         .read                   = generic_read_dir,
         .readdir                = udf_readdir,
         .ioctl                  = udf_ioctl,
diff --git a/fs/udf/file.c b/fs/udf/file.c
index a6f2acc1f15c..e34b00e303f1 100644
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -248,7 +248,7 @@ static int udf_release_file(struct inode * inode, struct file * filp)
         return 0;
 }
 
-struct file_operations udf_file_operations = {
+const struct file_operations udf_file_operations = {
         .read                   = generic_file_read,
         .ioctl                  = udf_ioctl,
         .open                   = generic_file_open,
diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c
index c9b707b470ca..3873c672cb4c 100644
--- a/fs/udf/ialloc.c
+++ b/fs/udf/ialloc.c
@@ -42,7 +42,7 @@ void udf_free_inode(struct inode * inode)
 
         clear_inode(inode);
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         if (sbi->s_lvidbh) {
                 if (S_ISDIR(inode->i_mode))
                         UDF_SB_LVIDIU(sb)->numDirs =
@@ -53,7 +53,7 @@ void udf_free_inode(struct inode * inode)
                 
                 mark_buffer_dirty(sbi->s_lvidbh);
         }
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
 
         udf_free_blocks(sb, NULL, UDF_I_LOCATION(inode), 0, 1);
 }
@@ -83,7 +83,7 @@ struct inode * udf_new_inode (struct inode *dir, int mode, int * err)
                 return NULL;
         }
 
-        down(&sbi->s_alloc_sem);
+        mutex_lock(&sbi->s_alloc_mutex);
         UDF_I_UNIQUE(inode) = 0;
         UDF_I_LENEXTENTS(inode) = 0;
         UDF_I_NEXT_ALLOC_BLOCK(inode) = 0;
@@ -148,7 +148,7 @@ struct inode * udf_new_inode (struct inode *dir, int mode, int * err)
                 UDF_I_CRTIME(inode) = current_fs_time(inode->i_sb);
         insert_inode_hash(inode);
         mark_inode_dirty(inode);
-        up(&sbi->s_alloc_sem);
+        mutex_unlock(&sbi->s_alloc_mutex);
 
         if (DQUOT_ALLOC_INODE(inode))
         {
diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index d04cff2273b6..81e0e8459af1 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -1341,13 +1341,11 @@ udf_update_inode(struct inode *inode, int do_sync)
 
         if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_UID_FORGET))
                 fe->uid = cpu_to_le32(-1);
-        else if (inode->i_uid != UDF_SB(inode->i_sb)->s_uid)
-                fe->uid = cpu_to_le32(inode->i_uid);
+        else fe->uid = cpu_to_le32(inode->i_uid);
 
         if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_GID_FORGET))
                 fe->gid = cpu_to_le32(-1);
-        else if (inode->i_gid != UDF_SB(inode->i_sb)->s_gid)
-                fe->gid = cpu_to_le32(inode->i_gid);
+        else fe->gid = cpu_to_le32(inode->i_gid);
 
         udfperms =      ((inode->i_mode & S_IRWXO)     ) |
                         ((inode->i_mode & S_IRWXG) << 2) |
diff --git a/fs/udf/super.c b/fs/udf/super.c
index 368d8f81fe54..e45789fe38e8 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -140,7 +140,8 @@ static int init_inodecache(void)
 {
         udf_inode_cachep = kmem_cache_create("udf_inode_cache",
                                              sizeof(struct udf_inode_info),
-                                             0, SLAB_RECLAIM_ACCOUNT,
+                                             0, (SLAB_RECLAIM_ACCOUNT|
+                                                SLAB_MEM_SPREAD),
                                              init_once, NULL);
         if (udf_inode_cachep == NULL)
                 return -ENOMEM;
@@ -660,8 +661,7 @@ udf_find_anchor(struct super_block *sb)
                  *     lastblock
                  *  however, if the disc isn't closed, it could be 512 */
 
-                for (i=0; (!lastblock && i<sizeof(last)/sizeof(int)); i++)
-                {
+                for (i = 0; !lastblock && i < ARRAY_SIZE(last); i++) {
                         if (last[i] < 0 || !(bh = sb_bread(sb, last[i])))
                         {
                                 ident = location = 0;
@@ -672,7 +672,7 @@ udf_find_anchor(struct super_block *sb)
                                 location = le32_to_cpu(((tag *)bh->b_data)->tagLocation);
                                 udf_release_data(bh);
                         }
-        
+
                         if (ident == TAG_IDENT_AVDP)
                         {
                                 if (location == last[i] - UDF_SB_SESSION(sb))
@@ -753,8 +753,7 @@ udf_find_anchor(struct super_block *sb)
                 }
         }
 
-        for (i=0; i<sizeof(UDF_SB_ANCHOR(sb))/sizeof(int); i++)
-        {
+        for (i = 0; i < ARRAY_SIZE(UDF_SB_ANCHOR(sb)); i++) {
                 if (UDF_SB_ANCHOR(sb)[i])
                 {
                         if (!(bh = udf_read_tagged(sb,
@@ -1313,8 +1312,7 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
         if (!sb)
                 return 1;
 
-        for (i=0; i<sizeof(UDF_SB_ANCHOR(sb))/sizeof(int); i++)
-        {
+        for (i = 0; i < ARRAY_SIZE(UDF_SB_ANCHOR(sb)); i++) {
                 if (UDF_SB_ANCHOR(sb)[i] && (bh = udf_read_tagged(sb,
                         UDF_SB_ANCHOR(sb)[i], UDF_SB_ANCHOR(sb)[i], &ident)))
                 {
@@ -1325,7 +1323,7 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
                         main_e = le32_to_cpu( anchor->mainVolDescSeqExt.extLength );
                         main_e = main_e >> sb->s_blocksize_bits;
                         main_e += main_s;
-        
+
                         /* Locate the reserve sequence */
                         reserve_s = le32_to_cpu(anchor->reserveVolDescSeqExt.extLocation);
                         reserve_e = le32_to_cpu(anchor->reserveVolDescSeqExt.extLength);
@@ -1344,12 +1342,10 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
                 }
         }
 
-        if (i == sizeof(UDF_SB_ANCHOR(sb))/sizeof(int))
-        {
+        if (i == ARRAY_SIZE(UDF_SB_ANCHOR(sb))) {
                 udf_debug("No Anchor block found\n");
                 return 1;
-        }
-        else
+        } else
                 udf_debug("Using anchor in block %d\n", UDF_SB_ANCHOR(sb)[i]);
 
         for (i=0; i<UDF_SB_NUMPARTS(sb); i++)
@@ -1515,7 +1511,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
         sb->s_fs_info = sbi;
         memset(UDF_SB(sb), 0x00, sizeof(struct udf_sb_info));
 
-        init_MUTEX(&sbi->s_alloc_sem);
+        mutex_init(&sbi->s_alloc_mutex);
 
         if (!udf_parse_options((char *)options, &uopt))
                 goto error_out;
diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
index 1d5800e0cbe7..023e19ba5a2e 100644
--- a/fs/udf/udfdecl.h
+++ b/fs/udf/udfdecl.h
@@ -44,9 +44,9 @@ struct buffer_head;
 struct super_block;
 
 extern struct inode_operations udf_dir_inode_operations;
-extern struct file_operations udf_dir_operations;
+extern const struct file_operations udf_dir_operations;
 extern struct inode_operations udf_file_inode_operations;
-extern struct file_operations udf_file_operations;
+extern const struct file_operations udf_file_operations;
 extern struct address_space_operations udf_aops;
 extern struct address_space_operations udf_adinicb_aops;
 extern struct address_space_operations udf_symlink_aops;