diff options
Diffstat (limited to 'fs/sysfs')
| -rw-r--r-- | fs/sysfs/dir.c | 31 | ||||
| -rw-r--r-- | fs/sysfs/file.c | 17 | ||||
| -rw-r--r-- | fs/sysfs/inode.c | 8 | ||||
| -rw-r--r-- | fs/sysfs/symlink.c | 5 |
4 files changed, 28 insertions, 33 deletions
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index d36780382176..49bd219275db 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
| @@ -99,7 +99,7 @@ static int create_dir(struct kobject * k, struct dentry * p, | |||
| 99 | int error; | 99 | int error; |
| 100 | umode_t mode = S_IFDIR| S_IRWXU | S_IRUGO | S_IXUGO; | 100 | umode_t mode = S_IFDIR| S_IRWXU | S_IRUGO | S_IXUGO; |
| 101 | 101 | ||
| 102 | down(&p->d_inode->i_sem); | 102 | mutex_lock(&p->d_inode->i_mutex); |
| 103 | *d = lookup_one_len(n, p, strlen(n)); | 103 | *d = lookup_one_len(n, p, strlen(n)); |
| 104 | if (!IS_ERR(*d)) { | 104 | if (!IS_ERR(*d)) { |
| 105 | error = sysfs_make_dirent(p->d_fsdata, *d, k, mode, SYSFS_DIR); | 105 | error = sysfs_make_dirent(p->d_fsdata, *d, k, mode, SYSFS_DIR); |
| @@ -122,7 +122,7 @@ static int create_dir(struct kobject * k, struct dentry * p, | |||
| 122 | dput(*d); | 122 | dput(*d); |
| 123 | } else | 123 | } else |
| 124 | error = PTR_ERR(*d); | 124 | error = PTR_ERR(*d); |
| 125 | up(&p->d_inode->i_sem); | 125 | mutex_unlock(&p->d_inode->i_mutex); |
| 126 | return error; | 126 | return error; |
| 127 | } | 127 | } |
| 128 | 128 | ||
| @@ -246,7 +246,7 @@ static void remove_dir(struct dentry * d) | |||
| 246 | struct dentry * parent = dget(d->d_parent); | 246 | struct dentry * parent = dget(d->d_parent); |
| 247 | struct sysfs_dirent * sd; | 247 | struct sysfs_dirent * sd; |
| 248 | 248 | ||
| 249 | down(&parent->d_inode->i_sem); | 249 | mutex_lock(&parent->d_inode->i_mutex); |
| 250 | d_delete(d); | 250 | d_delete(d); |
| 251 | sd = d->d_fsdata; | 251 | sd = d->d_fsdata; |
| 252 | list_del_init(&sd->s_sibling); | 252 | list_del_init(&sd->s_sibling); |
| @@ -257,7 +257,7 @@ static void remove_dir(struct dentry * d) | |||
| 257 | pr_debug(" o %s removing done (%d)\n",d->d_name.name, | 257 | pr_debug(" o %s removing done (%d)\n",d->d_name.name, |
| 258 | atomic_read(&d->d_count)); | 258 | atomic_read(&d->d_count)); |
| 259 | 259 | ||
| 260 | up(&parent->d_inode->i_sem); | 260 | mutex_unlock(&parent->d_inode->i_mutex); |
| 261 | dput(parent); | 261 | dput(parent); |
| 262 | } | 262 | } |
| 263 | 263 | ||
| @@ -286,7 +286,7 @@ void sysfs_remove_dir(struct kobject * kobj) | |||
| 286 | return; | 286 | return; |
| 287 | 287 | ||
| 288 | pr_debug("sysfs %s: removing dir\n",dentry->d_name.name); | 288 | pr_debug("sysfs %s: removing dir\n",dentry->d_name.name); |
| 289 | down(&dentry->d_inode->i_sem); | 289 | mutex_lock(&dentry->d_inode->i_mutex); |
| 290 | parent_sd = dentry->d_fsdata; | 290 | parent_sd = dentry->d_fsdata; |
| 291 | list_for_each_entry_safe(sd, tmp, &parent_sd->s_children, s_sibling) { | 291 | list_for_each_entry_safe(sd, tmp, &parent_sd->s_children, s_sibling) { |
| 292 | if (!sd->s_element || !(sd->s_type & SYSFS_NOT_PINNED)) | 292 | if (!sd->s_element || !(sd->s_type & SYSFS_NOT_PINNED)) |
| @@ -295,7 +295,7 @@ void sysfs_remove_dir(struct kobject * kobj) | |||
| 295 | sysfs_drop_dentry(sd, dentry); | 295 | sysfs_drop_dentry(sd, dentry); |
| 296 | sysfs_put(sd); | 296 | sysfs_put(sd); |
| 297 | } | 297 | } |
| 298 | up(&dentry->d_inode->i_sem); | 298 | mutex_unlock(&dentry->d_inode->i_mutex); |
| 299 | 299 | ||
| 300 | remove_dir(dentry); | 300 | remove_dir(dentry); |
| 301 | /** | 301 | /** |
| @@ -318,7 +318,7 @@ int sysfs_rename_dir(struct kobject * kobj, const char *new_name) | |||
| 318 | down_write(&sysfs_rename_sem); | 318 | down_write(&sysfs_rename_sem); |
| 319 | parent = kobj->parent->dentry; | 319 | parent = kobj->parent->dentry; |
| 320 | 320 | ||
| 321 | down(&parent->d_inode->i_sem); | 321 | mutex_lock(&parent->d_inode->i_mutex); |
| 322 | 322 | ||
| 323 | new_dentry = lookup_one_len(new_name, parent, strlen(new_name)); | 323 | new_dentry = lookup_one_len(new_name, parent, strlen(new_name)); |
| 324 | if (!IS_ERR(new_dentry)) { | 324 | if (!IS_ERR(new_dentry)) { |
| @@ -334,7 +334,7 @@ int sysfs_rename_dir(struct kobject * kobj, const char *new_name) | |||
| 334 | error = -EEXIST; | 334 | error = -EEXIST; |
| 335 | dput(new_dentry); | 335 | dput(new_dentry); |
| 336 | } | 336 | } |
| 337 | up(&parent->d_inode->i_sem); | 337 | mutex_unlock(&parent->d_inode->i_mutex); |
| 338 | up_write(&sysfs_rename_sem); | 338 | up_write(&sysfs_rename_sem); |
| 339 | 339 | ||
| 340 | return error; | 340 | return error; |
| @@ -345,9 +345,9 @@ static int sysfs_dir_open(struct inode *inode, struct file *file) | |||
| 345 | struct dentry * dentry = file->f_dentry; | 345 | struct dentry * dentry = file->f_dentry; |
| 346 | struct sysfs_dirent * parent_sd = dentry->d_fsdata; | 346 | struct sysfs_dirent * parent_sd = dentry->d_fsdata; |
| 347 | 347 | ||
| 348 | down(&dentry->d_inode->i_sem); | 348 | mutex_lock(&dentry->d_inode->i_mutex); |
| 349 | file->private_data = sysfs_new_dirent(parent_sd, NULL); | 349 | file->private_data = sysfs_new_dirent(parent_sd, NULL); |
| 350 | up(&dentry->d_inode->i_sem); | 350 | mutex_unlock(&dentry->d_inode->i_mutex); |
| 351 | 351 | ||
| 352 | return file->private_data ? 0 : -ENOMEM; | 352 | return file->private_data ? 0 : -ENOMEM; |
| 353 | 353 | ||
| @@ -358,9 +358,9 @@ static int sysfs_dir_close(struct inode *inode, struct file *file) | |||
| 358 | struct dentry * dentry = file->f_dentry; | 358 | struct dentry * dentry = file->f_dentry; |
| 359 | struct sysfs_dirent * cursor = file->private_data; | 359 | struct sysfs_dirent * cursor = file->private_data; |
| 360 | 360 | ||
| 361 | down(&dentry->d_inode->i_sem); | 361 | mutex_lock(&dentry->d_inode->i_mutex); |
| 362 | list_del_init(&cursor->s_sibling); | 362 | list_del_init(&cursor->s_sibling); |
| 363 | up(&dentry->d_inode->i_sem); | 363 | mutex_unlock(&dentry->d_inode->i_mutex); |
| 364 | 364 | ||
| 365 | release_sysfs_dirent(cursor); | 365 | release_sysfs_dirent(cursor); |
| 366 | 366 | ||
| @@ -436,7 +436,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin) | |||
| 436 | { | 436 | { |
| 437 | struct dentry * dentry = file->f_dentry; | 437 | struct dentry * dentry = file->f_dentry; |
| 438 | 438 | ||
| 439 | down(&dentry->d_inode->i_sem); | 439 | mutex_lock(&dentry->d_inode->i_mutex); |
| 440 | switch (origin) { | 440 | switch (origin) { |
| 441 | case 1: | 441 | case 1: |
| 442 | offset += file->f_pos; | 442 | offset += file->f_pos; |
| @@ -444,7 +444,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin) | |||
| 444 | if (offset >= 0) | 444 | if (offset >= 0) |
| 445 | break; | 445 | break; |
| 446 | default: | 446 | default: |
| 447 | up(&file->f_dentry->d_inode->i_sem); | 447 | mutex_unlock(&file->f_dentry->d_inode->i_mutex); |
| 448 | return -EINVAL; | 448 | return -EINVAL; |
| 449 | } | 449 | } |
| 450 | if (offset != file->f_pos) { | 450 | if (offset != file->f_pos) { |
| @@ -468,7 +468,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin) | |||
| 468 | list_add_tail(&cursor->s_sibling, p); | 468 | list_add_tail(&cursor->s_sibling, p); |
| 469 | } | 469 | } |
| 470 | } | 470 | } |
| 471 | up(&dentry->d_inode->i_sem); | 471 | mutex_unlock(&dentry->d_inode->i_mutex); |
| 472 | return offset; | 472 | return offset; |
| 473 | } | 473 | } |
| 474 | 474 | ||
| @@ -483,4 +483,3 @@ struct file_operations sysfs_dir_operations = { | |||
| 483 | EXPORT_SYMBOL_GPL(sysfs_create_dir); | 483 | EXPORT_SYMBOL_GPL(sysfs_create_dir); |
| 484 | EXPORT_SYMBOL_GPL(sysfs_remove_dir); | 484 | EXPORT_SYMBOL_GPL(sysfs_remove_dir); |
| 485 | EXPORT_SYMBOL_GPL(sysfs_rename_dir); | 485 | EXPORT_SYMBOL_GPL(sysfs_rename_dir); |
| 486 | |||
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 4013d7905e84..d0e3d8495165 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
| @@ -364,9 +364,9 @@ int sysfs_add_file(struct dentry * dir, const struct attribute * attr, int type) | |||
| 364 | umode_t mode = (attr->mode & S_IALLUGO) | S_IFREG; | 364 | umode_t mode = (attr->mode & S_IALLUGO) | S_IFREG; |
| 365 | int error = 0; | 365 | int error = 0; |
| 366 | 366 | ||
| 367 | down(&dir->d_inode->i_sem); | 367 | mutex_lock(&dir->d_inode->i_mutex); |
| 368 | error = sysfs_make_dirent(parent_sd, NULL, (void *) attr, mode, type); | 368 | error = sysfs_make_dirent(parent_sd, NULL, (void *) attr, mode, type); |
| 369 | up(&dir->d_inode->i_sem); | 369 | mutex_unlock(&dir->d_inode->i_mutex); |
| 370 | 370 | ||
| 371 | return error; | 371 | return error; |
| 372 | } | 372 | } |
| @@ -398,7 +398,7 @@ int sysfs_update_file(struct kobject * kobj, const struct attribute * attr) | |||
| 398 | struct dentry * victim; | 398 | struct dentry * victim; |
| 399 | int res = -ENOENT; | 399 | int res = -ENOENT; |
| 400 | 400 | ||
| 401 | down(&dir->d_inode->i_sem); | 401 | mutex_lock(&dir->d_inode->i_mutex); |
| 402 | victim = lookup_one_len(attr->name, dir, strlen(attr->name)); | 402 | victim = lookup_one_len(attr->name, dir, strlen(attr->name)); |
| 403 | if (!IS_ERR(victim)) { | 403 | if (!IS_ERR(victim)) { |
| 404 | /* make sure dentry is really there */ | 404 | /* make sure dentry is really there */ |
| @@ -420,7 +420,7 @@ int sysfs_update_file(struct kobject * kobj, const struct attribute * attr) | |||
| 420 | */ | 420 | */ |
| 421 | dput(victim); | 421 | dput(victim); |
| 422 | } | 422 | } |
| 423 | up(&dir->d_inode->i_sem); | 423 | mutex_unlock(&dir->d_inode->i_mutex); |
| 424 | 424 | ||
| 425 | return res; | 425 | return res; |
| 426 | } | 426 | } |
| @@ -441,22 +441,22 @@ int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode) | |||
| 441 | struct iattr newattrs; | 441 | struct iattr newattrs; |
| 442 | int res = -ENOENT; | 442 | int res = -ENOENT; |
| 443 | 443 | ||
| 444 | down(&dir->d_inode->i_sem); | 444 | mutex_lock(&dir->d_inode->i_mutex); |
| 445 | victim = lookup_one_len(attr->name, dir, strlen(attr->name)); | 445 | victim = lookup_one_len(attr->name, dir, strlen(attr->name)); |
| 446 | if (!IS_ERR(victim)) { | 446 | if (!IS_ERR(victim)) { |
| 447 | if (victim->d_inode && | 447 | if (victim->d_inode && |
| 448 | (victim->d_parent->d_inode == dir->d_inode)) { | 448 | (victim->d_parent->d_inode == dir->d_inode)) { |
| 449 | inode = victim->d_inode; | 449 | inode = victim->d_inode; |
| 450 | down(&inode->i_sem); | 450 | mutex_lock(&inode->i_mutex); |
| 451 | newattrs.ia_mode = (mode & S_IALLUGO) | | 451 | newattrs.ia_mode = (mode & S_IALLUGO) | |
| 452 | (inode->i_mode & ~S_IALLUGO); | 452 | (inode->i_mode & ~S_IALLUGO); |
| 453 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 453 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; |
| 454 | res = notify_change(victim, &newattrs); | 454 | res = notify_change(victim, &newattrs); |
| 455 | up(&inode->i_sem); | 455 | mutex_unlock(&inode->i_mutex); |
| 456 | } | 456 | } |
| 457 | dput(victim); | 457 | dput(victim); |
| 458 | } | 458 | } |
| 459 | up(&dir->d_inode->i_sem); | 459 | mutex_unlock(&dir->d_inode->i_mutex); |
| 460 | 460 | ||
| 461 | return res; | 461 | return res; |
| 462 | } | 462 | } |
| @@ -480,4 +480,3 @@ void sysfs_remove_file(struct kobject * kobj, const struct attribute * attr) | |||
| 480 | EXPORT_SYMBOL_GPL(sysfs_create_file); | 480 | EXPORT_SYMBOL_GPL(sysfs_create_file); |
| 481 | EXPORT_SYMBOL_GPL(sysfs_remove_file); | 481 | EXPORT_SYMBOL_GPL(sysfs_remove_file); |
| 482 | EXPORT_SYMBOL_GPL(sysfs_update_file); | 482 | EXPORT_SYMBOL_GPL(sysfs_update_file); |
| 483 | |||
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 970a33f03299..c3133219941c 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c | |||
| @@ -201,7 +201,7 @@ const unsigned char * sysfs_get_name(struct sysfs_dirent *sd) | |||
| 201 | 201 | ||
| 202 | /* | 202 | /* |
| 203 | * Unhashes the dentry corresponding to given sysfs_dirent | 203 | * Unhashes the dentry corresponding to given sysfs_dirent |
| 204 | * Called with parent inode's i_sem held. | 204 | * Called with parent inode's i_mutex held. |
| 205 | */ | 205 | */ |
| 206 | void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) | 206 | void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) |
| 207 | { | 207 | { |
| @@ -232,7 +232,7 @@ void sysfs_hash_and_remove(struct dentry * dir, const char * name) | |||
| 232 | /* no inode means this hasn't been made visible yet */ | 232 | /* no inode means this hasn't been made visible yet */ |
| 233 | return; | 233 | return; |
| 234 | 234 | ||
| 235 | down(&dir->d_inode->i_sem); | 235 | mutex_lock(&dir->d_inode->i_mutex); |
| 236 | list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { | 236 | list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { |
| 237 | if (!sd->s_element) | 237 | if (!sd->s_element) |
| 238 | continue; | 238 | continue; |
| @@ -243,7 +243,5 @@ void sysfs_hash_and_remove(struct dentry * dir, const char * name) | |||
| 243 | break; | 243 | break; |
| 244 | } | 244 | } |
| 245 | } | 245 | } |
| 246 | up(&dir->d_inode->i_sem); | 246 | mutex_unlock(&dir->d_inode->i_mutex); |
| 247 | } | 247 | } |
| 248 | |||
| 249 | |||
diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index de402fa915f2..e38d6338a20d 100644 --- a/fs/sysfs/symlink.c +++ b/fs/sysfs/symlink.c | |||
| @@ -86,9 +86,9 @@ int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char | |||
| 86 | 86 | ||
| 87 | BUG_ON(!kobj || !kobj->dentry || !name); | 87 | BUG_ON(!kobj || !kobj->dentry || !name); |
| 88 | 88 | ||
| 89 | down(&dentry->d_inode->i_sem); | 89 | mutex_lock(&dentry->d_inode->i_mutex); |
| 90 | error = sysfs_add_link(dentry, name, target); | 90 | error = sysfs_add_link(dentry, name, target); |
| 91 | up(&dentry->d_inode->i_sem); | 91 | mutex_unlock(&dentry->d_inode->i_mutex); |
| 92 | return error; | 92 | return error; |
| 93 | } | 93 | } |
| 94 | 94 | ||
| @@ -177,4 +177,3 @@ struct inode_operations sysfs_symlink_inode_operations = { | |||
| 177 | 177 | ||
| 178 | EXPORT_SYMBOL_GPL(sysfs_create_link); | 178 | EXPORT_SYMBOL_GPL(sysfs_create_link); |
| 179 | EXPORT_SYMBOL_GPL(sysfs_remove_link); | 179 | EXPORT_SYMBOL_GPL(sysfs_remove_link); |
| 180 | |||
