diff options
Diffstat (limited to 'fs/sysfs/file.c')
-rw-r--r-- | fs/sysfs/file.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index e7735f643cd1..c9e4e5091da1 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/kobject.h> | 14 | #include <linux/kobject.h> |
15 | #include <linux/kallsyms.h> | 15 | #include <linux/kallsyms.h> |
16 | #include <linux/slab.h> | 16 | #include <linux/slab.h> |
17 | #include <linux/fsnotify.h> | ||
17 | #include <linux/namei.h> | 18 | #include <linux/namei.h> |
18 | #include <linux/poll.h> | 19 | #include <linux/poll.h> |
19 | #include <linux/list.h> | 20 | #include <linux/list.h> |
@@ -336,9 +337,8 @@ static int sysfs_open_file(struct inode *inode, struct file *file) | |||
336 | if (kobj->ktype && kobj->ktype->sysfs_ops) | 337 | if (kobj->ktype && kobj->ktype->sysfs_ops) |
337 | ops = kobj->ktype->sysfs_ops; | 338 | ops = kobj->ktype->sysfs_ops; |
338 | else { | 339 | else { |
339 | printk(KERN_ERR "missing sysfs attribute operations for " | 340 | WARN(1, KERN_ERR "missing sysfs attribute operations for " |
340 | "kobject: %s\n", kobject_name(kobj)); | 341 | "kobject: %s\n", kobject_name(kobj)); |
341 | WARN_ON(1); | ||
342 | goto err_out; | 342 | goto err_out; |
343 | } | 343 | } |
344 | 344 | ||
@@ -585,9 +585,11 @@ int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode) | |||
585 | 585 | ||
586 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); | 586 | newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO); |
587 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; | 587 | newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; |
588 | rc = notify_change(victim, &newattrs); | 588 | newattrs.ia_ctime = current_fs_time(inode->i_sb); |
589 | rc = sysfs_setattr(victim, &newattrs); | ||
589 | 590 | ||
590 | if (rc == 0) { | 591 | if (rc == 0) { |
592 | fsnotify_change(victim, newattrs.ia_valid); | ||
591 | mutex_lock(&sysfs_mutex); | 593 | mutex_lock(&sysfs_mutex); |
592 | victim_sd->s_mode = newattrs.ia_mode; | 594 | victim_sd->s_mode = newattrs.ia_mode; |
593 | mutex_unlock(&sysfs_mutex); | 595 | mutex_unlock(&sysfs_mutex); |