4 files changed, 38 insertions, 33 deletions

diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/cluster/nodemanager.c
index e1fceb8aa32d..d11753c50bc1 100644
--- a/fs/ocfs2/cluster/nodemanager.c
+++ b/fs/ocfs2/cluster/nodemanager.c
@@ -152,14 +152,16 @@ static struct o2nm_node *o2nm_node_ip_tree_lookup(struct o2nm_cluster *cluster,
         struct o2nm_node *node, *ret = NULL;
 
         while (*p) {
+                int cmp;
+
                 parent = *p;
                 node = rb_entry(parent, struct o2nm_node, nd_ip_node);
 
-                if (memcmp(&ip_needle, &node->nd_ipv4_address,
-                           sizeof(ip_needle)) < 0)
+                cmp = memcmp(&ip_needle, &node->nd_ipv4_address,
+                                sizeof(ip_needle));
+                if (cmp < 0)
                         p = &(*p)->rb_left;
-                else if (memcmp(&ip_needle, &node->nd_ipv4_address,
-                                sizeof(ip_needle)) > 0)
+                else if (cmp > 0)
                         p = &(*p)->rb_right;
                 else {
                         ret = node;
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index d9ba0a931a03..1be74c4e7814 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -30,6 +30,7 @@
 #include <linux/highmem.h>
 #include <linux/pagemap.h>
 #include <linux/uio.h>
+#include <linux/sched.h>
 
 #define MLOG_MASK_PREFIX ML_INODE
 #include <cluster/masklog.h>
@@ -691,6 +692,12 @@ static int ocfs2_zero_extend(struct inode *inode,
                 }
 
                 start_off += sb->s_blocksize;
+
+                /*
+                 * Very large extends have the potential to lock up
+                 * the cpu for extended periods of time.
+                 */
+                cond_resched();
         }
 
 out:
@@ -728,31 +735,36 @@ static int ocfs2_extend_file(struct inode *inode,
         clusters_to_add = ocfs2_clusters_for_bytes(inode->i_sb, new_i_size) - 
                 OCFS2_I(inode)->ip_clusters;
 
-        if (clusters_to_add) {
-                /* 
-                 * protect the pages that ocfs2_zero_extend is going to
-                 * be pulling into the page cache.. we do this before the
-                 * metadata extend so that we don't get into the situation
-                 * where we've extended the metadata but can't get the data
-                 * lock to zero.
-                 */
-                ret = ocfs2_data_lock(inode, 1);
-                if (ret < 0) {
-                        mlog_errno(ret);
-                        goto out;
-                }
+        /* 
+         * protect the pages that ocfs2_zero_extend is going to be
+         * pulling into the page cache.. we do this before the
+         * metadata extend so that we don't get into the situation
+         * where we've extended the metadata but can't get the data
+         * lock to zero.
+         */
+        ret = ocfs2_data_lock(inode, 1);
+        if (ret < 0) {
+                mlog_errno(ret);
+                goto out;
+        }
 
+        if (clusters_to_add) {
                 ret = ocfs2_extend_allocation(inode, clusters_to_add);
                 if (ret < 0) {
                         mlog_errno(ret);
                         goto out_unlock;
                 }
+        }
 
-                ret = ocfs2_zero_extend(inode, (u64)new_i_size - tail_to_skip);
-                if (ret < 0) {
-                        mlog_errno(ret);
-                        goto out_unlock;
-                }
+        /*
+         * Call this even if we don't add any clusters to the tree. We
+         * still need to zero the area between the old i_size and the
+         * new i_size.
+         */
+        ret = ocfs2_zero_extend(inode, (u64)new_i_size - tail_to_skip);
+        if (ret < 0) {
+                mlog_errno(ret);
+                goto out_unlock;
         }
 
         if (!tail_to_skip) {
@@ -764,8 +776,7 @@ static int ocfs2_extend_file(struct inode *inode,
         }
 
 out_unlock:
-        if (clusters_to_add) /* this is the only case in which we lock */
-                ocfs2_data_unlock(inode, 1);
+        ocfs2_data_unlock(inode, 1);
 
 out:
         return ret;
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 259155f0eb2e..a57b751d4f40 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -1085,14 +1085,6 @@ static int ocfs2_rename(struct inode *old_dir,
                         BUG();
         }
 
-        if (atomic_read(&old_dentry->d_count) > 2) {
-                shrink_dcache_parent(old_dentry);
-                if (atomic_read(&old_dentry->d_count) > 2) {
-                        status = -EBUSY;
-                        goto bail;
-                }
-        }
-
         /* Assume a directory heirarchy thusly:
          * a/b/c
          * a/d
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 4c29cd7cc8e6..76b46ebbb10c 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -339,7 +339,7 @@ static unsigned long long ocfs2_max_file_offset(unsigned int blockshift)
 
 #if BITS_PER_LONG == 32
 # if defined(CONFIG_LBD)
-        BUG_ON(sizeof(sector_t) != 8);
+        BUILD_BUG_ON(sizeof(sector_t) != 8);
         pagefactor = PAGE_CACHE_SIZE;
         bitshift = BITS_PER_LONG;
 # else