diff options
Diffstat (limited to 'fs/ocfs2/dlmglue.c')
-rw-r--r-- | fs/ocfs2/dlmglue.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 6e6cc0a2e5f7..9f2a7f75d1b3 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -2024,7 +2024,7 @@ static int ocfs2_inode_lock_update(struct inode *inode, | |||
2024 | } else { | 2024 | } else { |
2025 | /* Boo, we have to go to disk. */ | 2025 | /* Boo, we have to go to disk. */ |
2026 | /* read bh, cast, ocfs2_refresh_inode */ | 2026 | /* read bh, cast, ocfs2_refresh_inode */ |
2027 | status = ocfs2_read_block(inode, oi->ip_blkno, bh); | 2027 | status = ocfs2_read_inode_block(inode, bh); |
2028 | if (status < 0) { | 2028 | if (status < 0) { |
2029 | mlog_errno(status); | 2029 | mlog_errno(status); |
2030 | goto bail_refresh; | 2030 | goto bail_refresh; |
@@ -2032,18 +2032,14 @@ static int ocfs2_inode_lock_update(struct inode *inode, | |||
2032 | fe = (struct ocfs2_dinode *) (*bh)->b_data; | 2032 | fe = (struct ocfs2_dinode *) (*bh)->b_data; |
2033 | 2033 | ||
2034 | /* This is a good chance to make sure we're not | 2034 | /* This is a good chance to make sure we're not |
2035 | * locking an invalid object. | 2035 | * locking an invalid object. ocfs2_read_inode_block() |
2036 | * already checked that the inode block is sane. | ||
2036 | * | 2037 | * |
2037 | * We bug on a stale inode here because we checked | 2038 | * We bug on a stale inode here because we checked |
2038 | * above whether it was wiped from disk. The wiping | 2039 | * above whether it was wiped from disk. The wiping |
2039 | * node provides a guarantee that we receive that | 2040 | * node provides a guarantee that we receive that |
2040 | * message and can mark the inode before dropping any | 2041 | * message and can mark the inode before dropping any |
2041 | * locks associated with it. */ | 2042 | * locks associated with it. */ |
2042 | if (!OCFS2_IS_VALID_DINODE(fe)) { | ||
2043 | OCFS2_RO_ON_INVALID_DINODE(inode->i_sb, fe); | ||
2044 | status = -EIO; | ||
2045 | goto bail_refresh; | ||
2046 | } | ||
2047 | mlog_bug_on_msg(inode->i_generation != | 2043 | mlog_bug_on_msg(inode->i_generation != |
2048 | le32_to_cpu(fe->i_generation), | 2044 | le32_to_cpu(fe->i_generation), |
2049 | "Invalid dinode %llu disk generation: %u " | 2045 | "Invalid dinode %llu disk generation: %u " |
@@ -2085,7 +2081,7 @@ static int ocfs2_assign_bh(struct inode *inode, | |||
2085 | return 0; | 2081 | return 0; |
2086 | } | 2082 | } |
2087 | 2083 | ||
2088 | status = ocfs2_read_block(inode, OCFS2_I(inode)->ip_blkno, ret_bh); | 2084 | status = ocfs2_read_inode_block(inode, ret_bh); |
2089 | if (status < 0) | 2085 | if (status < 0) |
2090 | mlog_errno(status); | 2086 | mlog_errno(status); |
2091 | 2087 | ||