diff options
Diffstat (limited to 'fs/notify/mark.c')
-rw-r--r-- | fs/notify/mark.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/fs/notify/mark.c b/fs/notify/mark.c index 8f3b0e7a543d..69c5a166930c 100644 --- a/fs/notify/mark.c +++ b/fs/notify/mark.c | |||
@@ -121,12 +121,14 @@ void fsnotify_destroy_mark(struct fsnotify_mark *mark) | |||
121 | 121 | ||
122 | group = mark->group; | 122 | group = mark->group; |
123 | 123 | ||
124 | /* if !group something else already marked this to die */ | 124 | /* something else already called this function on this mark */ |
125 | if (!group) { | 125 | if (!(mark->flags & FSNOTIFY_MARK_FLAG_ALIVE)) { |
126 | spin_unlock(&mark->lock); | 126 | spin_unlock(&mark->lock); |
127 | return; | 127 | return; |
128 | } | 128 | } |
129 | 129 | ||
130 | mark->flags &= ~FSNOTIFY_MARK_FLAG_ALIVE; | ||
131 | |||
130 | /* 1 from caller and 1 for being on i_list/g_list */ | 132 | /* 1 from caller and 1 for being on i_list/g_list */ |
131 | BUG_ON(atomic_read(&mark->refcnt) < 2); | 133 | BUG_ON(atomic_read(&mark->refcnt) < 2); |
132 | 134 | ||
@@ -141,7 +143,6 @@ void fsnotify_destroy_mark(struct fsnotify_mark *mark) | |||
141 | BUG(); | 143 | BUG(); |
142 | 144 | ||
143 | list_del_init(&mark->g_list); | 145 | list_del_init(&mark->g_list); |
144 | mark->group = NULL; | ||
145 | 146 | ||
146 | fsnotify_put_mark(mark); /* for i_list and g_list */ | 147 | fsnotify_put_mark(mark); /* for i_list and g_list */ |
147 | 148 | ||
@@ -229,6 +230,8 @@ int fsnotify_add_mark(struct fsnotify_mark *mark, | |||
229 | spin_lock(&mark->lock); | 230 | spin_lock(&mark->lock); |
230 | spin_lock(&group->mark_lock); | 231 | spin_lock(&group->mark_lock); |
231 | 232 | ||
233 | mark->flags |= FSNOTIFY_MARK_FLAG_ALIVE; | ||
234 | |||
232 | mark->group = group; | 235 | mark->group = group; |
233 | list_add(&mark->g_list, &group->marks_list); | 236 | list_add(&mark->g_list, &group->marks_list); |
234 | atomic_inc(&group->num_marks); | 237 | atomic_inc(&group->num_marks); |
@@ -258,7 +261,7 @@ int fsnotify_add_mark(struct fsnotify_mark *mark, | |||
258 | 261 | ||
259 | return ret; | 262 | return ret; |
260 | err: | 263 | err: |
261 | mark->group = NULL; | 264 | mark->flags &= ~FSNOTIFY_MARK_FLAG_ALIVE; |
262 | list_del_init(&mark->g_list); | 265 | list_del_init(&mark->g_list); |
263 | atomic_dec(&group->num_marks); | 266 | atomic_dec(&group->num_marks); |
264 | fsnotify_put_mark(mark); | 267 | fsnotify_put_mark(mark); |