aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nilfs2/direct.c
diff options
context:
space:
mode:
Diffstat (limited to 'fs/nilfs2/direct.c')
-rw-r--r--fs/nilfs2/direct.c13
1 files changed, 10 insertions, 3 deletions
diff --git a/fs/nilfs2/direct.c b/fs/nilfs2/direct.c
index e3ec24850089..c6379e482781 100644
--- a/fs/nilfs2/direct.c
+++ b/fs/nilfs2/direct.c
@@ -210,7 +210,6 @@ static int nilfs_direct_last_key(const struct nilfs_bmap *bmap, __u64 *keyp)
210 if (lastkey == NILFS_DIRECT_KEY_MAX + 1) 210 if (lastkey == NILFS_DIRECT_KEY_MAX + 1)
211 return -ENOENT; 211 return -ENOENT;
212 212
213 BUG_ON(keyp == NULL);
214 *keyp = lastkey; 213 *keyp = lastkey;
215 214
216 return 0; 215 return 0;
@@ -366,9 +365,17 @@ static int nilfs_direct_assign(struct nilfs_bmap *bmap,
366 365
367 direct = (struct nilfs_direct *)bmap; 366 direct = (struct nilfs_direct *)bmap;
368 key = nilfs_bmap_data_get_key(bmap, *bh); 367 key = nilfs_bmap_data_get_key(bmap, *bh);
369 BUG_ON(key > NILFS_DIRECT_KEY_MAX); 368 if (unlikely(key > NILFS_DIRECT_KEY_MAX)) {
369 printk(KERN_CRIT "%s: invalid key: %llu\n", __func__,
370 (unsigned long long)key);
371 return -EINVAL;
372 }
370 ptr = nilfs_direct_get_ptr(direct, key); 373 ptr = nilfs_direct_get_ptr(direct, key);
371 BUG_ON(ptr == NILFS_BMAP_INVALID_PTR); 374 if (unlikely(ptr == NILFS_BMAP_INVALID_PTR)) {
375 printk(KERN_CRIT "%s: invalid pointer: %llu\n", __func__,
376 (unsigned long long)ptr);
377 return -EINVAL;
378 }
372 379
373 return direct->d_ops->dop_assign(direct, key, ptr, bh, 380 return direct->d_ops->dop_assign(direct, key, ptr, bh,
374 blocknr, binfo); 381 blocknr, binfo);