aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfsd
diff options
context:
space:
mode:
Diffstat (limited to 'fs/nfsd')
-rw-r--r--fs/nfsd/nfs4recover.c12
-rw-r--r--fs/nfsd/vfs.c8
2 files changed, 18 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 1ff90625860f..4e77a1a3bd73 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -46,6 +46,7 @@
46#include <linux/scatterlist.h> 46#include <linux/scatterlist.h>
47#include <linux/crypto.h> 47#include <linux/crypto.h>
48#include <linux/sched.h> 48#include <linux/sched.h>
49#include <linux/mount.h>
49 50
50#define NFSDDBG_FACILITY NFSDDBG_PROC 51#define NFSDDBG_FACILITY NFSDDBG_PROC
51 52
@@ -313,12 +314,17 @@ nfsd4_remove_clid_dir(struct nfs4_client *clp)
313 if (!rec_dir_init || !clp->cl_firststate) 314 if (!rec_dir_init || !clp->cl_firststate)
314 return; 315 return;
315 316
317 status = mnt_want_write(rec_dir.path.mnt);
318 if (status)
319 goto out;
316 clp->cl_firststate = 0; 320 clp->cl_firststate = 0;
317 nfs4_save_user(&uid, &gid); 321 nfs4_save_user(&uid, &gid);
318 status = nfsd4_unlink_clid_dir(clp->cl_recdir, HEXDIR_LEN-1); 322 status = nfsd4_unlink_clid_dir(clp->cl_recdir, HEXDIR_LEN-1);
319 nfs4_reset_user(uid, gid); 323 nfs4_reset_user(uid, gid);
320 if (status == 0) 324 if (status == 0)
321 nfsd4_sync_rec_dir(); 325 nfsd4_sync_rec_dir();
326 mnt_drop_write(rec_dir.path.mnt);
327out:
322 if (status) 328 if (status)
323 printk("NFSD: Failed to remove expired client state directory" 329 printk("NFSD: Failed to remove expired client state directory"
324 " %.*s\n", HEXDIR_LEN, clp->cl_recdir); 330 " %.*s\n", HEXDIR_LEN, clp->cl_recdir);
@@ -347,13 +353,17 @@ nfsd4_recdir_purge_old(void) {
347 353
348 if (!rec_dir_init) 354 if (!rec_dir_init)
349 return; 355 return;
356 status = mnt_want_write(rec_dir.path.mnt);
357 if (status)
358 goto out;
350 status = nfsd4_list_rec_dir(rec_dir.path.dentry, purge_old); 359 status = nfsd4_list_rec_dir(rec_dir.path.dentry, purge_old);
351 if (status == 0) 360 if (status == 0)
352 nfsd4_sync_rec_dir(); 361 nfsd4_sync_rec_dir();
362 mnt_drop_write(rec_dir.path.mnt);
363out:
353 if (status) 364 if (status)
354 printk("nfsd4: failed to purge old clients from recovery" 365 printk("nfsd4: failed to purge old clients from recovery"
355 " directory %s\n", rec_dir.path.dentry->d_name.name); 366 " directory %s\n", rec_dir.path.dentry->d_name.name);
356 return;
357} 367}
358 368
359static int 369static int
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 46f59d5365a0..efff58a5818c 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1750,6 +1750,10 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type,
1750 if (!type) 1750 if (!type)
1751 type = rdentry->d_inode->i_mode & S_IFMT; 1751 type = rdentry->d_inode->i_mode & S_IFMT;
1752 1752
1753 host_err = mnt_want_write(fhp->fh_export->ex_path.mnt);
1754 if (host_err)
1755 goto out_nfserr;
1756
1753 if (type != S_IFDIR) { /* It's UNLINK */ 1757 if (type != S_IFDIR) { /* It's UNLINK */
1754#ifdef MSNFS 1758#ifdef MSNFS
1755 if ((fhp->fh_export->ex_flags & NFSEXP_MSNFS) && 1759 if ((fhp->fh_export->ex_flags & NFSEXP_MSNFS) &&
@@ -1765,10 +1769,12 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type,
1765 dput(rdentry); 1769 dput(rdentry);
1766 1770
1767 if (host_err) 1771 if (host_err)
1768 goto out_nfserr; 1772 goto out_drop;
1769 if (EX_ISSYNC(fhp->fh_export)) 1773 if (EX_ISSYNC(fhp->fh_export))
1770 host_err = nfsd_sync_dir(dentry); 1774 host_err = nfsd_sync_dir(dentry);
1771 1775
1776out_drop:
1777 mnt_drop_write(fhp->fh_export->ex_path.mnt);
1772out_nfserr: 1778out_nfserr:
1773 err = nfserrno(host_err); 1779 err = nfserrno(host_err);
1774out: 1780out: