diff options
Diffstat (limited to 'fs/nfsd/nfs4callback.c')
| -rw-r--r-- | fs/nfsd/nfs4callback.c | 18 |
1 files changed, 3 insertions, 15 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 864090edc28b..5443c52b57aa 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c | |||
| @@ -394,7 +394,6 @@ nfsd4_probe_callback(struct nfs4_client *clp) | |||
| 394 | .rpc_proc = &nfs4_cb_procedures[NFSPROC4_CLNT_CB_NULL], | 394 | .rpc_proc = &nfs4_cb_procedures[NFSPROC4_CLNT_CB_NULL], |
| 395 | .rpc_argp = clp, | 395 | .rpc_argp = clp, |
| 396 | }; | 396 | }; |
| 397 | char clientname[16]; | ||
| 398 | int status; | 397 | int status; |
| 399 | 398 | ||
| 400 | if (atomic_read(&cb->cb_set)) | 399 | if (atomic_read(&cb->cb_set)) |
| @@ -417,11 +416,6 @@ nfsd4_probe_callback(struct nfs4_client *clp) | |||
| 417 | memset(program->stats, 0, sizeof(cb->cb_stat)); | 416 | memset(program->stats, 0, sizeof(cb->cb_stat)); |
| 418 | program->stats->program = program; | 417 | program->stats->program = program; |
| 419 | 418 | ||
| 420 | /* Just here to make some printk's more useful: */ | ||
| 421 | snprintf(clientname, sizeof(clientname), | ||
| 422 | "%u.%u.%u.%u", NIPQUAD(addr.sin_addr)); | ||
| 423 | args.servername = clientname; | ||
| 424 | |||
| 425 | /* Create RPC client */ | 419 | /* Create RPC client */ |
| 426 | cb->cb_client = rpc_create(&args); | 420 | cb->cb_client = rpc_create(&args); |
| 427 | if (IS_ERR(cb->cb_client)) { | 421 | if (IS_ERR(cb->cb_client)) { |
| @@ -429,29 +423,23 @@ nfsd4_probe_callback(struct nfs4_client *clp) | |||
| 429 | goto out_err; | 423 | goto out_err; |
| 430 | } | 424 | } |
| 431 | 425 | ||
| 432 | /* Kick rpciod, put the call on the wire. */ | ||
| 433 | if (rpciod_up() != 0) | ||
| 434 | goto out_clnt; | ||
| 435 | |||
| 436 | /* the task holds a reference to the nfs4_client struct */ | 426 | /* the task holds a reference to the nfs4_client struct */ |
| 437 | atomic_inc(&clp->cl_count); | 427 | atomic_inc(&clp->cl_count); |
| 438 | 428 | ||
| 439 | msg.rpc_cred = nfsd4_lookupcred(clp,0); | 429 | msg.rpc_cred = nfsd4_lookupcred(clp,0); |
| 440 | if (IS_ERR(msg.rpc_cred)) | 430 | if (IS_ERR(msg.rpc_cred)) |
| 441 | goto out_rpciod; | 431 | goto out_release_clp; |
| 442 | status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_ASYNC, &nfs4_cb_null_ops, NULL); | 432 | status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_ASYNC, &nfs4_cb_null_ops, NULL); |
| 443 | put_rpccred(msg.rpc_cred); | 433 | put_rpccred(msg.rpc_cred); |
| 444 | 434 | ||
| 445 | if (status != 0) { | 435 | if (status != 0) { |
| 446 | dprintk("NFSD: asynchronous NFSPROC4_CB_NULL failed!\n"); | 436 | dprintk("NFSD: asynchronous NFSPROC4_CB_NULL failed!\n"); |
| 447 | goto out_rpciod; | 437 | goto out_release_clp; |
| 448 | } | 438 | } |
| 449 | return; | 439 | return; |
| 450 | 440 | ||
| 451 | out_rpciod: | 441 | out_release_clp: |
| 452 | atomic_dec(&clp->cl_count); | 442 | atomic_dec(&clp->cl_count); |
| 453 | rpciod_down(); | ||
| 454 | out_clnt: | ||
| 455 | rpc_shutdown_client(cb->cb_client); | 443 | rpc_shutdown_client(cb->cb_client); |
| 456 | out_err: | 444 | out_err: |
| 457 | cb->cb_client = NULL; | 445 | cb->cb_client = NULL; |
