1 files changed, 7 insertions, 94 deletions

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 8118036cc449..b3fd29baadc3 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -636,7 +636,7 @@ static int _nfs4_proc_open_confirm(struct nfs4_opendata *data)
                 smp_wmb();
         } else
                 status = data->rpc_status;
-        rpc_release_task(task);
+        rpc_put_task(task);
         return status;
 }
 
@@ -742,7 +742,7 @@ static int _nfs4_proc_open(struct nfs4_opendata *data)
                 smp_wmb();
         } else
                 status = data->rpc_status;
-        rpc_release_task(task);
+        rpc_put_task(task);
         if (status != 0)
                 return status;
 
@@ -1775,89 +1775,6 @@ static int nfs4_proc_read(struct nfs_read_data *rdata)
         return err;
 }
 
-static int _nfs4_proc_write(struct nfs_write_data *wdata)
-{
-        int rpcflags = wdata->flags;
-        struct inode *inode = wdata->inode;
-        struct nfs_fattr *fattr = wdata->res.fattr;
-        struct nfs_server *server = NFS_SERVER(inode);
-        struct rpc_message msg = {
-                .rpc_proc       = &nfs4_procedures[NFSPROC4_CLNT_WRITE],
-                .rpc_argp       = &wdata->args,
-                .rpc_resp       = &wdata->res,
-                .rpc_cred       = wdata->cred,
-        };
-        int status;
-
-        dprintk("NFS call  write %d @ %Ld\n", wdata->args.count,
-                        (long long) wdata->args.offset);
-
-        wdata->args.bitmask = server->attr_bitmask;
-        wdata->res.server = server;
-        wdata->timestamp = jiffies;
-        nfs_fattr_init(fattr);
-        status = rpc_call_sync(server->client, &msg, rpcflags);
-        dprintk("NFS reply write: %d\n", status);
-        if (status < 0)
-                return status;
-        renew_lease(server, wdata->timestamp);
-        nfs_post_op_update_inode(inode, fattr);
-        return wdata->res.count;
-}
-
-static int nfs4_proc_write(struct nfs_write_data *wdata)
-{
-        struct nfs4_exception exception = { };
-        int err;
-        do {
-                err = nfs4_handle_exception(NFS_SERVER(wdata->inode),
-                                _nfs4_proc_write(wdata),
-                                &exception);
-        } while (exception.retry);
-        return err;
-}
-
-static int _nfs4_proc_commit(struct nfs_write_data *cdata)
-{
-        struct inode *inode = cdata->inode;
-        struct nfs_fattr *fattr = cdata->res.fattr;
-        struct nfs_server *server = NFS_SERVER(inode);
-        struct rpc_message msg = {
-                .rpc_proc       = &nfs4_procedures[NFSPROC4_CLNT_COMMIT],
-                .rpc_argp       = &cdata->args,
-                .rpc_resp       = &cdata->res,
-                .rpc_cred       = cdata->cred,
-        };
-        int status;
-
-        dprintk("NFS call  commit %d @ %Ld\n", cdata->args.count,
-                        (long long) cdata->args.offset);
-
-        cdata->args.bitmask = server->attr_bitmask;
-        cdata->res.server = server;
-        cdata->timestamp = jiffies;
-        nfs_fattr_init(fattr);
-        status = rpc_call_sync(server->client, &msg, 0);
-        if (status >= 0)
-                renew_lease(server, cdata->timestamp);
-        dprintk("NFS reply commit: %d\n", status);
-        if (status >= 0)
-                nfs_post_op_update_inode(inode, fattr);
-        return status;
-}
-
-static int nfs4_proc_commit(struct nfs_write_data *cdata)
-{
-        struct nfs4_exception exception = { };
-        int err;
-        do {
-                err = nfs4_handle_exception(NFS_SERVER(cdata->inode),
-                                _nfs4_proc_commit(cdata),
-                                &exception);
-        } while (exception.retry);
-        return err;
-}
-
 /*
  * Got race?
  * We will need to arrange for the VFS layer to provide an atomic open.
@@ -1960,7 +1877,7 @@ static int nfs4_proc_unlink_setup(struct rpc_message *msg, struct dentry *dir,
         struct nfs_server *server = NFS_SERVER(dir->d_inode);
         struct unlink_desc *up;
 
-        up = (struct unlink_desc *) kmalloc(sizeof(*up), GFP_KERNEL);
+        up = kmalloc(sizeof(*up), GFP_KERNEL);
         if (!up)
                 return -ENOMEM;
         
@@ -2223,13 +2140,11 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred,
                         dentry->d_parent->d_name.name,
                         dentry->d_name.name,
                         (unsigned long long)cookie);
-        lock_kernel();
         nfs4_setup_readdir(cookie, NFS_COOKIEVERF(dir), dentry, &args);
         res.pgbase = args.pgbase;
         status = rpc_call_sync(NFS_CLIENT(dir), &msg, 0);
         if (status == 0)
                 memcpy(NFS_COOKIEVERF(dir), res.verifier.data, NFS4_VERIFIER_SIZE);
-        unlock_kernel();
         dprintk("%s: returns %d\n", __FUNCTION__, status);
         return status;
 }
@@ -3067,7 +2982,7 @@ static int _nfs4_proc_delegreturn(struct inode *inode, struct rpc_cred *cred, co
                 if (status == 0)
                         nfs_post_op_update_inode(inode, &data->fattr);
         }
-        rpc_release_task(task);
+        rpc_put_task(task);
         return status;
 }
 
@@ -3314,7 +3229,7 @@ static int nfs4_proc_unlck(struct nfs4_state *state, int cmd, struct file_lock *
         if (IS_ERR(task))
                 goto out;
         status = nfs4_wait_for_completion_rpc_task(task);
-        rpc_release_task(task);
+        rpc_put_task(task);
 out:
         return status;
 }
@@ -3430,7 +3345,7 @@ static void nfs4_lock_release(void *calldata)
                 task = nfs4_do_unlck(&data->fl, data->ctx, data->lsp,
                                 data->arg.lock_seqid);
                 if (!IS_ERR(task))
-                        rpc_release_task(task);
+                        rpc_put_task(task);
                 dprintk("%s: cancelling lock!\n", __FUNCTION__);
         } else
                 nfs_free_seqid(data->arg.lock_seqid);
@@ -3472,7 +3387,7 @@ static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *f
                         ret = -EAGAIN;
         } else
                 data->cancelled = 1;
-        rpc_release_task(task);
+        rpc_put_task(task);
         dprintk("%s: done, ret = %d!\n", __FUNCTION__, ret);
         return ret;
 }
@@ -3732,8 +3647,6 @@ const struct nfs_rpc_ops nfs_v4_clientops = {
         .access         = nfs4_proc_access,
         .readlink       = nfs4_proc_readlink,
         .read           = nfs4_proc_read,
-        .write          = nfs4_proc_write,
-        .commit         = nfs4_proc_commit,
         .create         = nfs4_proc_create,
         .remove         = nfs4_proc_remove,
         .unlink_setup   = nfs4_proc_unlink_setup,