aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs/callback.c
diff options
context:
space:
mode:
Diffstat (limited to 'fs/nfs/callback.c')
-rw-r--r--fs/nfs/callback.c15
1 files changed, 1 insertions, 14 deletions
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index 293fa0528a6e..36dfdae95123 100644
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -78,11 +78,6 @@ nfs4_callback_svc(void *vrqstp)
78 78
79 set_freezable(); 79 set_freezable();
80 80
81 /*
82 * FIXME: do we really need to run this under the BKL? If so, please
83 * add a comment about what it's intended to protect.
84 */
85 lock_kernel();
86 while (!kthread_should_stop()) { 81 while (!kthread_should_stop()) {
87 /* 82 /*
88 * Listen for a request on the socket 83 * Listen for a request on the socket
@@ -104,7 +99,6 @@ nfs4_callback_svc(void *vrqstp)
104 preverr = err; 99 preverr = err;
105 svc_process(rqstp); 100 svc_process(rqstp);
106 } 101 }
107 unlock_kernel();
108 return 0; 102 return 0;
109} 103}
110 104
@@ -124,7 +118,6 @@ nfs4_callback_up(struct svc_serv *serv)
124 dprintk("NFS: Callback listener port = %u (af %u)\n", 118 dprintk("NFS: Callback listener port = %u (af %u)\n",
125 nfs_callback_tcpport, PF_INET); 119 nfs_callback_tcpport, PF_INET);
126 120
127#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
128 ret = svc_create_xprt(serv, "tcp", PF_INET6, 121 ret = svc_create_xprt(serv, "tcp", PF_INET6,
129 nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); 122 nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS);
130 if (ret > 0) { 123 if (ret > 0) {
@@ -135,7 +128,6 @@ nfs4_callback_up(struct svc_serv *serv)
135 ret = 0; 128 ret = 0;
136 else 129 else
137 goto out_err; 130 goto out_err;
138#endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
139 131
140 return svc_prepare_thread(serv, &serv->sv_pools[0]); 132 return svc_prepare_thread(serv, &serv->sv_pools[0]);
141 133
@@ -160,11 +152,6 @@ nfs41_callback_svc(void *vrqstp)
160 152
161 set_freezable(); 153 set_freezable();
162 154
163 /*
164 * FIXME: do we really need to run this under the BKL? If so, please
165 * add a comment about what it's intended to protect.
166 */
167 lock_kernel();
168 while (!kthread_should_stop()) { 155 while (!kthread_should_stop()) {
169 prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE); 156 prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE);
170 spin_lock_bh(&serv->sv_cb_lock); 157 spin_lock_bh(&serv->sv_cb_lock);
@@ -183,7 +170,6 @@ nfs41_callback_svc(void *vrqstp)
183 } 170 }
184 finish_wait(&serv->sv_cb_waitq, &wq); 171 finish_wait(&serv->sv_cb_waitq, &wq);
185 } 172 }
186 unlock_kernel();
187 return 0; 173 return 0;
188} 174}
189 175
@@ -397,6 +383,7 @@ static int nfs_callback_authenticate(struct svc_rqst *rqstp)
397 */ 383 */
398static struct svc_version *nfs4_callback_version[] = { 384static struct svc_version *nfs4_callback_version[] = {
399 [1] = &nfs4_callback_version1, 385 [1] = &nfs4_callback_version1,
386 [4] = &nfs4_callback_version4,
400}; 387};
401 388
402static struct svc_stat nfs4_callback_stats; 389static struct svc_stat nfs4_callback_stats;