1 files changed, 257 insertions, 93 deletions

diff --git a/fs/lockd/host.c b/fs/lockd/host.c
index a17664c7eacc..9fd8889097b7 100644
--- a/fs/lockd/host.c
+++ b/fs/lockd/host.c
@@ -11,16 +11,17 @@
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/in.h>
+#include <linux/in6.h>
 #include <linux/sunrpc/clnt.h>
 #include <linux/sunrpc/svc.h>
 #include <linux/lockd/lockd.h>
 #include <linux/lockd/sm_inter.h>
 #include <linux/mutex.h>
 
+#include <net/ipv6.h>
 
 #define NLMDBG_FACILITY         NLMDBG_HOSTCACHE
 #define NLM_HOST_NRHASH         32
-#define NLM_ADDRHASH(addr)      (ntohl(addr) & (NLM_HOST_NRHASH-1))
 #define NLM_HOST_REBIND         (60 * HZ)
 #define NLM_HOST_EXPIRE         (300 * HZ)
 #define NLM_HOST_COLLECT        (120 * HZ)
@@ -30,42 +31,115 @@ static unsigned long		next_gc;
 static int                      nrhosts;
 static DEFINE_MUTEX(nlm_host_mutex);
 
-
 static void                     nlm_gc_hosts(void);
-static struct nsm_handle *      __nsm_find(const struct sockaddr_in *,
-                                        const char *, unsigned int, int);
-static struct nsm_handle *      nsm_find(const struct sockaddr_in *sin,
-                                         const char *hostname,
-                                         unsigned int hostname_len);
+static struct nsm_handle        *nsm_find(const struct sockaddr *sap,
+                                                const size_t salen,
+                                                const char *hostname,
+                                                const size_t hostname_len,
+                                                const int create);
+
+struct nlm_lookup_host_info {
+        const int               server;         /* search for server|client */
+        const struct sockaddr   *sap;           /* address to search for */
+        const size_t            salen;          /* it's length */
+        const unsigned short    protocol;       /* transport to search for*/
+        const u32               version;        /* NLM version to search for */
+        const char              *hostname;      /* remote's hostname */
+        const size_t            hostname_len;   /* it's length */
+        const struct sockaddr   *src_sap;       /* our address (optional) */
+        const size_t            src_len;        /* it's length */
+};
+
+/*
+ * Hash function must work well on big- and little-endian platforms
+ */
+static unsigned int __nlm_hash32(const __be32 n)
+{
+        unsigned int hash = (__force u32)n ^ ((__force u32)n >> 16);
+        return hash ^ (hash >> 8);
+}
+
+static unsigned int __nlm_hash_addr4(const struct sockaddr *sap)
+{
+        const struct sockaddr_in *sin = (struct sockaddr_in *)sap;
+        return __nlm_hash32(sin->sin_addr.s_addr);
+}
+
+static unsigned int __nlm_hash_addr6(const struct sockaddr *sap)
+{
+        const struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap;
+        const struct in6_addr addr = sin6->sin6_addr;
+        return __nlm_hash32(addr.s6_addr32[0]) ^
+               __nlm_hash32(addr.s6_addr32[1]) ^
+               __nlm_hash32(addr.s6_addr32[2]) ^
+               __nlm_hash32(addr.s6_addr32[3]);
+}
+
+static unsigned int nlm_hash_address(const struct sockaddr *sap)
+{
+        unsigned int hash;
+
+        switch (sap->sa_family) {
+        case AF_INET:
+                hash = __nlm_hash_addr4(sap);
+                break;
+        case AF_INET6:
+                hash = __nlm_hash_addr6(sap);
+                break;
+        default:
+                hash = 0;
+        }
+        return hash & (NLM_HOST_NRHASH - 1);
+}
+
+static void nlm_clear_port(struct sockaddr *sap)
+{
+        switch (sap->sa_family) {
+        case AF_INET:
+                ((struct sockaddr_in *)sap)->sin_port = 0;
+                break;
+        case AF_INET6:
+                ((struct sockaddr_in6 *)sap)->sin6_port = 0;
+                break;
+        }
+}
+
+static void nlm_display_address(const struct sockaddr *sap,
+                                char *buf, const size_t len)
+{
+        const struct sockaddr_in *sin = (struct sockaddr_in *)sap;
+        const struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap;
+
+        switch (sap->sa_family) {
+        case AF_UNSPEC:
+                snprintf(buf, len, "unspecified");
+                break;
+        case AF_INET:
+                snprintf(buf, len, NIPQUAD_FMT, NIPQUAD(sin->sin_addr.s_addr));
+                break;
+        case AF_INET6:
+                if (ipv6_addr_v4mapped(&sin6->sin6_addr))
+                        snprintf(buf, len, NIPQUAD_FMT,
+                                 NIPQUAD(sin6->sin6_addr.s6_addr32[3]));
+                else
+                        snprintf(buf, len, NIP6_FMT, NIP6(sin6->sin6_addr));
+                break;
+        default:
+                snprintf(buf, len, "unsupported address family");
+                break;
+        }
+}
 
 /*
  * Common host lookup routine for server & client
  */
-static struct nlm_host *nlm_lookup_host(int server,
-                                        const struct sockaddr_in *sin,
-                                        int proto, u32 version,
-                                        const char *hostname,
-                                        unsigned int hostname_len,
-                                        const struct sockaddr_in *ssin)
+static struct nlm_host *nlm_lookup_host(struct nlm_lookup_host_info *ni)
 {
         struct hlist_head *chain;
         struct hlist_node *pos;
         struct nlm_host *host;
         struct nsm_handle *nsm = NULL;
-        int             hash;
-
-        dprintk("lockd: nlm_lookup_host("NIPQUAD_FMT"->"NIPQUAD_FMT
-                        ", p=%d, v=%u, my role=%s, name=%.*s)\n",
-                        NIPQUAD(ssin->sin_addr.s_addr),
-                        NIPQUAD(sin->sin_addr.s_addr), proto, version,
-                        server? "server" : "client",
-                        hostname_len,
-                        hostname? hostname : "<none>");
 
-
-        hash = NLM_ADDRHASH(sin->sin_addr.s_addr);
-
-        /* Lock hash table */
         mutex_lock(&nlm_host_mutex);
 
         if (time_after_eq(jiffies, next_gc))
@@ -78,22 +152,22 @@ static struct nlm_host *nlm_lookup_host(int server,
          * different NLM rpc_clients into one single nlm_host object.
          * This would allow us to have one nlm_host per address.
          */
-        chain = &nlm_hosts[hash];
+        chain = &nlm_hosts[nlm_hash_address(ni->sap)];
         hlist_for_each_entry(host, pos, chain, h_hash) {
-                if (!nlm_cmp_addr(&host->h_addr, sin))
+                if (!nlm_cmp_addr(nlm_addr(host), ni->sap))
                         continue;
 
                 /* See if we have an NSM handle for this client */
                 if (!nsm)
                         nsm = host->h_nsmhandle;
 
-                if (host->h_proto != proto)
+                if (host->h_proto != ni->protocol)
                         continue;
-                if (host->h_version != version)
+                if (host->h_version != ni->version)
                         continue;
-                if (host->h_server != server)
+                if (host->h_server != ni->server)
                         continue;
-                if (!nlm_cmp_addr(&host->h_saddr, ssin))
+                if (!nlm_cmp_addr(nlm_srcaddr(host), ni->src_sap))
                         continue;
 
                 /* Move to head of hash chain. */
@@ -101,30 +175,41 @@ static struct nlm_host *nlm_lookup_host(int server,
                 hlist_add_head(&host->h_hash, chain);
 
                 nlm_get_host(host);
+                dprintk("lockd: nlm_lookup_host found host %s (%s)\n",
+                                host->h_name, host->h_addrbuf);
                 goto out;
         }
-        if (nsm)
-                atomic_inc(&nsm->sm_count);
-
-        host = NULL;
 
-        /* Sadly, the host isn't in our hash table yet. See if
-         * we have an NSM handle for it. If not, create one.
+        /*
+         * The host wasn't in our hash table.  If we don't
+         * have an NSM handle for it yet, create one.
          */
-        if (!nsm && !(nsm = nsm_find(sin, hostname, hostname_len)))
-                goto out;
+        if (nsm)
+                atomic_inc(&nsm->sm_count);
+        else {
+                host = NULL;
+                nsm = nsm_find(ni->sap, ni->salen,
+                                ni->hostname, ni->hostname_len, 1);
+                if (!nsm) {
+                        dprintk("lockd: nlm_lookup_host failed; "
+                                "no nsm handle\n");
+                        goto out;
+                }
+        }
 
         host = kzalloc(sizeof(*host), GFP_KERNEL);
         if (!host) {
                 nsm_release(nsm);
+                dprintk("lockd: nlm_lookup_host failed; no memory\n");
                 goto out;
         }
         host->h_name       = nsm->sm_name;
-        host->h_addr       = *sin;
-        host->h_addr.sin_port = 0;      /* ouch! */
-        host->h_saddr      = *ssin;
-        host->h_version    = version;
-        host->h_proto      = proto;
+        memcpy(nlm_addr(host), ni->sap, ni->salen);
+        host->h_addrlen = ni->salen;
+        nlm_clear_port(nlm_addr(host));
+        memcpy(nlm_srcaddr(host), ni->src_sap, ni->src_len);
+        host->h_version    = ni->version;
+        host->h_proto      = ni->protocol;
         host->h_rpcclnt    = NULL;
         mutex_init(&host->h_mutex);
         host->h_nextrebind = jiffies + NLM_HOST_REBIND;
@@ -135,7 +220,7 @@ static struct nlm_host *nlm_lookup_host(int server,
         host->h_state      = 0;                 /* pseudo NSM state */
         host->h_nsmstate   = 0;                 /* real NSM state */
         host->h_nsmhandle  = nsm;
-        host->h_server     = server;
+        host->h_server     = ni->server;
         hlist_add_head(&host->h_hash, chain);
         INIT_LIST_HEAD(&host->h_lockowners);
         spin_lock_init(&host->h_lock);
@@ -143,6 +228,15 @@ static struct nlm_host *nlm_lookup_host(int server,
         INIT_LIST_HEAD(&host->h_reclaim);
 
         nrhosts++;
+
+        nlm_display_address((struct sockaddr *)&host->h_addr,
+                                host->h_addrbuf, sizeof(host->h_addrbuf));
+        nlm_display_address((struct sockaddr *)&host->h_srcaddr,
+                                host->h_srcaddrbuf, sizeof(host->h_srcaddrbuf));
+
+        dprintk("lockd: nlm_lookup_host created host %s\n",
+                        host->h_name);
+
 out:
         mutex_unlock(&nlm_host_mutex);
         return host;
@@ -170,33 +264,103 @@ nlm_destroy_host(struct nlm_host *host)
         kfree(host);
 }
 
-/*
- * Find an NLM server handle in the cache. If there is none, create it.
+/**
+ * nlmclnt_lookup_host - Find an NLM host handle matching a remote server
+ * @sap: network address of server
+ * @salen: length of server address
+ * @protocol: transport protocol to use
+ * @version: NLM protocol version
+ * @hostname: '\0'-terminated hostname of server
+ *
+ * Returns an nlm_host structure that matches the passed-in
+ * [server address, transport protocol, NLM version, server hostname].
+ * If one doesn't already exist in the host cache, a new handle is
+ * created and returned.
  */
-struct nlm_host *nlmclnt_lookup_host(const struct sockaddr_in *sin,
-                                     int proto, u32 version,
-                                     const char *hostname,
-                                     unsigned int hostname_len)
+struct nlm_host *nlmclnt_lookup_host(const struct sockaddr *sap,
+                                     const size_t salen,
+                                     const unsigned short protocol,
+                                     const u32 version, const char *hostname)
 {
-        struct sockaddr_in ssin = {0};
-
-        return nlm_lookup_host(0, sin, proto, version,
-                               hostname, hostname_len, &ssin);
+        const struct sockaddr source = {
+                .sa_family      = AF_UNSPEC,
+        };
+        struct nlm_lookup_host_info ni = {
+                .server         = 0,
+                .sap            = sap,
+                .salen          = salen,
+                .protocol       = protocol,
+                .version        = version,
+                .hostname       = hostname,
+                .hostname_len   = strlen(hostname),
+                .src_sap        = &source,
+                .src_len        = sizeof(source),
+        };
+
+        dprintk("lockd: %s(host='%s', vers=%u, proto=%s)\n", __func__,
+                        (hostname ? hostname : "<none>"), version,
+                        (protocol == IPPROTO_UDP ? "udp" : "tcp"));
+
+        return nlm_lookup_host(&ni);
 }
 
-/*
- * Find an NLM client handle in the cache. If there is none, create it.
+/**
+ * nlmsvc_lookup_host - Find an NLM host handle matching a remote client
+ * @rqstp: incoming NLM request
+ * @hostname: name of client host
+ * @hostname_len: length of client hostname
+ *
+ * Returns an nlm_host structure that matches the [client address,
+ * transport protocol, NLM version, client hostname] of the passed-in
+ * NLM request.  If one doesn't already exist in the host cache, a
+ * new handle is created and returned.
+ *
+ * Before possibly creating a new nlm_host, construct a sockaddr
+ * for a specific source address in case the local system has
+ * multiple network addresses.  The family of the address in
+ * rq_daddr is guaranteed to be the same as the family of the
+ * address in rq_addr, so it's safe to use the same family for
+ * the source address.
  */
-struct nlm_host *
-nlmsvc_lookup_host(struct svc_rqst *rqstp,
-                        const char *hostname, unsigned int hostname_len)
+struct nlm_host *nlmsvc_lookup_host(const struct svc_rqst *rqstp,
+                                    const char *hostname,
+                                    const size_t hostname_len)
 {
-        struct sockaddr_in ssin = {0};
+        struct sockaddr_in sin = {
+                .sin_family     = AF_INET,
+        };
+        struct sockaddr_in6 sin6 = {
+                .sin6_family    = AF_INET6,
+        };
+        struct nlm_lookup_host_info ni = {
+                .server         = 1,
+                .sap            = svc_addr(rqstp),
+                .salen          = rqstp->rq_addrlen,
+                .protocol       = rqstp->rq_prot,
+                .version        = rqstp->rq_vers,
+                .hostname       = hostname,
+                .hostname_len   = hostname_len,
+                .src_len        = rqstp->rq_addrlen,
+        };
+
+        dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__,
+                        (int)hostname_len, hostname, rqstp->rq_vers,
+                        (rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));
+
+        switch (ni.sap->sa_family) {
+        case AF_INET:
+                sin.sin_addr.s_addr = rqstp->rq_daddr.addr.s_addr;
+                ni.src_sap = (struct sockaddr *)&sin;
+                break;
+        case AF_INET6:
+                ipv6_addr_copy(&sin6.sin6_addr, &rqstp->rq_daddr.addr6);
+                ni.src_sap = (struct sockaddr *)&sin6;
+                break;
+        default:
+                return NULL;
+        }
 
-        ssin.sin_addr = rqstp->rq_daddr.addr;
-        return nlm_lookup_host(1, svc_addr_in(rqstp),
-                               rqstp->rq_prot, rqstp->rq_vers,
-                               hostname, hostname_len, &ssin);
+        return nlm_lookup_host(&ni);
 }
 
 /*
@@ -207,9 +371,8 @@ nlm_bind_host(struct nlm_host *host)
 {
         struct rpc_clnt *clnt;
 
-        dprintk("lockd: nlm_bind_host("NIPQUAD_FMT"->"NIPQUAD_FMT")\n",
-                        NIPQUAD(host->h_saddr.sin_addr),
-                        NIPQUAD(host->h_addr.sin_addr));
+        dprintk("lockd: nlm_bind_host %s (%s), my addr=%s\n",
+                        host->h_name, host->h_addrbuf, host->h_srcaddrbuf);
 
         /* Lock host handle */
         mutex_lock(&host->h_mutex);
@@ -221,7 +384,7 @@ nlm_bind_host(struct nlm_host *host)
                 if (time_after_eq(jiffies, host->h_nextrebind)) {
                         rpc_force_rebind(clnt);
                         host->h_nextrebind = jiffies + NLM_HOST_REBIND;
-                        dprintk("lockd: next rebind in %ld jiffies\n",
+                        dprintk("lockd: next rebind in %lu jiffies\n",
                                         host->h_nextrebind - jiffies);
                 }
         } else {
@@ -234,9 +397,9 @@ nlm_bind_host(struct nlm_host *host)
                 };
                 struct rpc_create_args args = {
                         .protocol       = host->h_proto,
-                        .address        = (struct sockaddr *)&host->h_addr,
-                        .addrsize       = sizeof(host->h_addr),
-                        .saddress       = (struct sockaddr *)&host->h_saddr,
+                        .address        = nlm_addr(host),
+                        .addrsize       = host->h_addrlen,
+                        .saddress       = nlm_srcaddr(host),
                         .timeout        = &timeparms,
                         .servername     = host->h_name,
                         .program        = &nlm_program,
@@ -324,12 +487,16 @@ void nlm_host_rebooted(const struct sockaddr_in *sin,
         struct nsm_handle *nsm;
         struct nlm_host *host;
 
-        dprintk("lockd: nlm_host_rebooted(%s, %u.%u.%u.%u)\n",
-                        hostname, NIPQUAD(sin->sin_addr));
-
-        /* Find the NSM handle for this peer */
-        if (!(nsm = __nsm_find(sin, hostname, hostname_len, 0)))
+        nsm = nsm_find((struct sockaddr *)sin, sizeof(*sin),
+                        hostname, hostname_len, 0);
+        if (nsm == NULL) {
+                dprintk("lockd: never saw rebooted peer '%.*s' before\n",
+                                hostname_len, hostname);
                 return;
+        }
+
+        dprintk("lockd: nlm_host_rebooted(%.*s, %s)\n",
+                        hostname_len, hostname, nsm->sm_addrbuf);
 
         /* When reclaiming locks on this peer, make sure that
          * we set up a new notification */
@@ -461,22 +628,23 @@ nlm_gc_hosts(void)
 static LIST_HEAD(nsm_handles);
 static DEFINE_SPINLOCK(nsm_lock);
 
-static struct nsm_handle *
-__nsm_find(const struct sockaddr_in *sin,
-                const char *hostname, unsigned int hostname_len,
-                int create)
+static struct nsm_handle *nsm_find(const struct sockaddr *sap,
+                                   const size_t salen,
+                                   const char *hostname,
+                                   const size_t hostname_len,
+                                   const int create)
 {
         struct nsm_handle *nsm = NULL;
         struct nsm_handle *pos;
 
-        if (!sin)
+        if (!sap)
                 return NULL;
 
         if (hostname && memchr(hostname, '/', hostname_len) != NULL) {
                 if (printk_ratelimit()) {
                         printk(KERN_WARNING "Invalid hostname \"%.*s\" "
                                             "in NFS lock request\n",
-                                hostname_len, hostname);
+                                (int)hostname_len, hostname);
                 }
                 return NULL;
         }
@@ -489,7 +657,7 @@ retry:
                         if (strlen(pos->sm_name) != hostname_len
                          || memcmp(pos->sm_name, hostname, hostname_len))
                                 continue;
-                } else if (!nlm_cmp_addr(&pos->sm_addr, sin))
+                } else if (!nlm_cmp_addr(nsm_addr(pos), sap))
                         continue;
                 atomic_inc(&pos->sm_count);
                 kfree(nsm);
@@ -509,10 +677,13 @@ retry:
         if (nsm == NULL)
                 return NULL;
 
-        nsm->sm_addr = *sin;
+        memcpy(nsm_addr(nsm), sap, salen);
+        nsm->sm_addrlen = salen;
         nsm->sm_name = (char *) (nsm + 1);
         memcpy(nsm->sm_name, hostname, hostname_len);
         nsm->sm_name[hostname_len] = '\0';
+        nlm_display_address((struct sockaddr *)&nsm->sm_addr,
+                                nsm->sm_addrbuf, sizeof(nsm->sm_addrbuf));
         atomic_set(&nsm->sm_count, 1);
         goto retry;
 
@@ -521,13 +692,6 @@ found:
         return nsm;
 }
 
-static struct nsm_handle *
-nsm_find(const struct sockaddr_in *sin, const char *hostname,
-         unsigned int hostname_len)
-{
-        return __nsm_find(sin, hostname, hostname_len, 1);
-}
-
 /*
  * Release an NSM handle
  */