diff options
Diffstat (limited to 'fs/lockd/clntproc.c')
-rw-r--r-- | fs/lockd/clntproc.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/fs/lockd/clntproc.c b/fs/lockd/clntproc.c index cb469431bd1d..3e90356b4882 100644 --- a/fs/lockd/clntproc.c +++ b/fs/lockd/clntproc.c | |||
@@ -446,12 +446,14 @@ nlmclnt_test(struct nlm_rqst *req, struct file_lock *fl) | |||
446 | 446 | ||
447 | static void nlmclnt_locks_copy_lock(struct file_lock *new, struct file_lock *fl) | 447 | static void nlmclnt_locks_copy_lock(struct file_lock *new, struct file_lock *fl) |
448 | { | 448 | { |
449 | memcpy(&new->fl_u.nfs_fl, &fl->fl_u.nfs_fl, sizeof(new->fl_u.nfs_fl)); | 449 | new->fl_u.nfs_fl.state = fl->fl_u.nfs_fl.state; |
450 | nlm_get_lockowner(new->fl_u.nfs_fl.owner); | 450 | new->fl_u.nfs_fl.owner = nlm_get_lockowner(fl->fl_u.nfs_fl.owner); |
451 | list_add_tail(&new->fl_u.nfs_fl.list, &fl->fl_u.nfs_fl.owner->host->h_granted); | ||
451 | } | 452 | } |
452 | 453 | ||
453 | static void nlmclnt_locks_release_private(struct file_lock *fl) | 454 | static void nlmclnt_locks_release_private(struct file_lock *fl) |
454 | { | 455 | { |
456 | list_del(&fl->fl_u.nfs_fl.list); | ||
455 | nlm_put_lockowner(fl->fl_u.nfs_fl.owner); | 457 | nlm_put_lockowner(fl->fl_u.nfs_fl.owner); |
456 | fl->fl_ops = NULL; | 458 | fl->fl_ops = NULL; |
457 | } | 459 | } |
@@ -466,6 +468,7 @@ static void nlmclnt_locks_init_private(struct file_lock *fl, struct nlm_host *ho | |||
466 | BUG_ON(fl->fl_ops != NULL); | 468 | BUG_ON(fl->fl_ops != NULL); |
467 | fl->fl_u.nfs_fl.state = 0; | 469 | fl->fl_u.nfs_fl.state = 0; |
468 | fl->fl_u.nfs_fl.owner = nlm_find_lockowner(host, fl->fl_owner); | 470 | fl->fl_u.nfs_fl.owner = nlm_find_lockowner(host, fl->fl_owner); |
471 | INIT_LIST_HEAD(&fl->fl_u.nfs_fl.list); | ||
469 | fl->fl_ops = &nlmclnt_lock_ops; | 472 | fl->fl_ops = &nlmclnt_lock_ops; |
470 | } | 473 | } |
471 | 474 | ||
@@ -552,7 +555,7 @@ nlmclnt_lock(struct nlm_rqst *req, struct file_lock *fl) | |||
552 | if (resp->status == NLM_LCK_GRANTED) { | 555 | if (resp->status == NLM_LCK_GRANTED) { |
553 | fl->fl_u.nfs_fl.state = host->h_state; | 556 | fl->fl_u.nfs_fl.state = host->h_state; |
554 | fl->fl_flags |= FL_SLEEP; | 557 | fl->fl_flags |= FL_SLEEP; |
555 | list_add_tail(&fl->fl_u.nfs_fl.list, &host->h_granted); | 558 | /* Ensure the resulting lock will get added to granted list */ |
556 | do_vfs_lock(fl); | 559 | do_vfs_lock(fl); |
557 | } | 560 | } |
558 | status = nlm_stat_to_errno(resp->status); | 561 | status = nlm_stat_to_errno(resp->status); |
@@ -619,12 +622,6 @@ nlmclnt_unlock(struct nlm_rqst *req, struct file_lock *fl) | |||
619 | int status; | 622 | int status; |
620 | 623 | ||
621 | /* | 624 | /* |
622 | * Remove from the granted list now so the lock doesn't get | ||
623 | * reclaimed while we're stuck in the unlock call. | ||
624 | */ | ||
625 | list_del(&fl->fl_u.nfs_fl.list); | ||
626 | |||
627 | /* | ||
628 | * Note: the server is supposed to either grant us the unlock | 625 | * Note: the server is supposed to either grant us the unlock |
629 | * request, or to deny it with NLM_LCK_DENIED_GRACE_PERIOD. In either | 626 | * request, or to deny it with NLM_LCK_DENIED_GRACE_PERIOD. In either |
630 | * case, we want to unlock. | 627 | * case, we want to unlock. |