diff options
Diffstat (limited to 'fs/jbd')
| -rw-r--r-- | fs/jbd/checkpoint.c | 4 | ||||
| -rw-r--r-- | fs/jbd/commit.c | 49 | ||||
| -rw-r--r-- | fs/jbd/journal.c | 2 | ||||
| -rw-r--r-- | fs/jbd/revoke.c | 2 |
4 files changed, 30 insertions, 27 deletions
diff --git a/fs/jbd/checkpoint.c b/fs/jbd/checkpoint.c index b0435dd0654d..05a38b9c4c0e 100644 --- a/fs/jbd/checkpoint.c +++ b/fs/jbd/checkpoint.c | |||
| @@ -254,7 +254,9 @@ __flush_batch(journal_t *journal, struct buffer_head **bhs, int *batch_count) | |||
| 254 | { | 254 | { |
| 255 | int i; | 255 | int i; |
| 256 | 256 | ||
| 257 | ll_rw_block(SWRITE, *batch_count, bhs); | 257 | for (i = 0; i < *batch_count; i++) |
| 258 | write_dirty_buffer(bhs[i], WRITE); | ||
| 259 | |||
| 258 | for (i = 0; i < *batch_count; i++) { | 260 | for (i = 0; i < *batch_count; i++) { |
| 259 | struct buffer_head *bh = bhs[i]; | 261 | struct buffer_head *bh = bhs[i]; |
| 260 | clear_buffer_jwrite(bh); | 262 | clear_buffer_jwrite(bh); |
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c index 28a9ddaa0c49..95d8c11c929e 100644 --- a/fs/jbd/commit.c +++ b/fs/jbd/commit.c | |||
| @@ -119,7 +119,6 @@ static int journal_write_commit_record(journal_t *journal, | |||
| 119 | struct buffer_head *bh; | 119 | struct buffer_head *bh; |
| 120 | journal_header_t *header; | 120 | journal_header_t *header; |
| 121 | int ret; | 121 | int ret; |
| 122 | int barrier_done = 0; | ||
| 123 | 122 | ||
| 124 | if (is_journal_aborted(journal)) | 123 | if (is_journal_aborted(journal)) |
| 125 | return 0; | 124 | return 0; |
| @@ -137,34 +136,36 @@ static int journal_write_commit_record(journal_t *journal, | |||
| 137 | 136 | ||
| 138 | JBUFFER_TRACE(descriptor, "write commit block"); | 137 | JBUFFER_TRACE(descriptor, "write commit block"); |
| 139 | set_buffer_dirty(bh); | 138 | set_buffer_dirty(bh); |
| 139 | |||
| 140 | if (journal->j_flags & JFS_BARRIER) { | 140 | if (journal->j_flags & JFS_BARRIER) { |
| 141 | set_buffer_ordered(bh); | 141 | ret = __sync_dirty_buffer(bh, WRITE_SYNC | WRITE_BARRIER); |
| 142 | barrier_done = 1; | ||
| 143 | } | ||
| 144 | ret = sync_dirty_buffer(bh); | ||
| 145 | if (barrier_done) | ||
| 146 | clear_buffer_ordered(bh); | ||
| 147 | /* is it possible for another commit to fail at roughly | ||
| 148 | * the same time as this one? If so, we don't want to | ||
| 149 | * trust the barrier flag in the super, but instead want | ||
| 150 | * to remember if we sent a barrier request | ||
| 151 | */ | ||
| 152 | if (ret == -EOPNOTSUPP && barrier_done) { | ||
| 153 | char b[BDEVNAME_SIZE]; | ||
| 154 | 142 | ||
| 155 | printk(KERN_WARNING | 143 | /* |
| 156 | "JBD: barrier-based sync failed on %s - " | 144 | * Is it possible for another commit to fail at roughly |
| 157 | "disabling barriers\n", | 145 | * the same time as this one? If so, we don't want to |
| 158 | bdevname(journal->j_dev, b)); | 146 | * trust the barrier flag in the super, but instead want |
| 159 | spin_lock(&journal->j_state_lock); | 147 | * to remember if we sent a barrier request |
| 160 | journal->j_flags &= ~JFS_BARRIER; | 148 | */ |
| 161 | spin_unlock(&journal->j_state_lock); | 149 | if (ret == -EOPNOTSUPP) { |
| 150 | char b[BDEVNAME_SIZE]; | ||
| 162 | 151 | ||
| 163 | /* And try again, without the barrier */ | 152 | printk(KERN_WARNING |
| 164 | set_buffer_uptodate(bh); | 153 | "JBD: barrier-based sync failed on %s - " |
| 165 | set_buffer_dirty(bh); | 154 | "disabling barriers\n", |
| 155 | bdevname(journal->j_dev, b)); | ||
| 156 | spin_lock(&journal->j_state_lock); | ||
| 157 | journal->j_flags &= ~JFS_BARRIER; | ||
| 158 | spin_unlock(&journal->j_state_lock); | ||
| 159 | |||
| 160 | /* And try again, without the barrier */ | ||
| 161 | set_buffer_uptodate(bh); | ||
| 162 | set_buffer_dirty(bh); | ||
| 163 | ret = sync_dirty_buffer(bh); | ||
| 164 | } | ||
| 165 | } else { | ||
| 166 | ret = sync_dirty_buffer(bh); | 166 | ret = sync_dirty_buffer(bh); |
| 167 | } | 167 | } |
| 168 | |||
| 168 | put_bh(bh); /* One for getblk() */ | 169 | put_bh(bh); /* One for getblk() */ |
| 169 | journal_put_journal_head(descriptor); | 170 | journal_put_journal_head(descriptor); |
| 170 | 171 | ||
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index f19ce94693d8..2c4b1f109da9 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c | |||
| @@ -1024,7 +1024,7 @@ void journal_update_superblock(journal_t *journal, int wait) | |||
| 1024 | if (wait) | 1024 | if (wait) |
| 1025 | sync_dirty_buffer(bh); | 1025 | sync_dirty_buffer(bh); |
| 1026 | else | 1026 | else |
| 1027 | ll_rw_block(SWRITE, 1, &bh); | 1027 | write_dirty_buffer(bh, WRITE); |
| 1028 | 1028 | ||
| 1029 | out: | 1029 | out: |
| 1030 | /* If we have just flushed the log (by marking s_start==0), then | 1030 | /* If we have just flushed the log (by marking s_start==0), then |
diff --git a/fs/jbd/revoke.c b/fs/jbd/revoke.c index ad717328343a..d29018307e2e 100644 --- a/fs/jbd/revoke.c +++ b/fs/jbd/revoke.c | |||
| @@ -617,7 +617,7 @@ static void flush_descriptor(journal_t *journal, | |||
| 617 | set_buffer_jwrite(bh); | 617 | set_buffer_jwrite(bh); |
| 618 | BUFFER_TRACE(bh, "write"); | 618 | BUFFER_TRACE(bh, "write"); |
| 619 | set_buffer_dirty(bh); | 619 | set_buffer_dirty(bh); |
| 620 | ll_rw_block((write_op == WRITE) ? SWRITE : SWRITE_SYNC_PLUG, 1, &bh); | 620 | write_dirty_buffer(bh, write_op); |
| 621 | } | 621 | } |
| 622 | #endif | 622 | #endif |
| 623 | 623 | ||
