diff options
Diffstat (limited to 'fs/ioctl.c')
-rw-r--r-- | fs/ioctl.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/ioctl.c b/fs/ioctl.c index 240ec63984cb..421aab465dab 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c | |||
@@ -404,10 +404,12 @@ static int ioctl_fionbio(struct file *filp, int __user *argp) | |||
404 | if (O_NONBLOCK != O_NDELAY) | 404 | if (O_NONBLOCK != O_NDELAY) |
405 | flag |= O_NDELAY; | 405 | flag |= O_NDELAY; |
406 | #endif | 406 | #endif |
407 | spin_lock(&filp->f_lock); | ||
407 | if (on) | 408 | if (on) |
408 | filp->f_flags |= flag; | 409 | filp->f_flags |= flag; |
409 | else | 410 | else |
410 | filp->f_flags &= ~flag; | 411 | filp->f_flags &= ~flag; |
412 | spin_unlock(&filp->f_lock); | ||
411 | return error; | 413 | return error; |
412 | } | 414 | } |
413 | 415 | ||
@@ -432,10 +434,12 @@ static int ioctl_fioasync(unsigned int fd, struct file *filp, | |||
432 | if (error) | 434 | if (error) |
433 | return error; | 435 | return error; |
434 | 436 | ||
437 | spin_lock(&filp->f_lock); | ||
435 | if (on) | 438 | if (on) |
436 | filp->f_flags |= FASYNC; | 439 | filp->f_flags |= FASYNC; |
437 | else | 440 | else |
438 | filp->f_flags &= ~FASYNC; | 441 | filp->f_flags &= ~FASYNC; |
442 | spin_unlock(&filp->f_lock); | ||
439 | return error; | 443 | return error; |
440 | } | 444 | } |
441 | 445 | ||
@@ -499,10 +503,7 @@ int do_vfs_ioctl(struct file *filp, unsigned int fd, unsigned int cmd, | |||
499 | break; | 503 | break; |
500 | 504 | ||
501 | case FIONBIO: | 505 | case FIONBIO: |
502 | /* BKL needed to avoid races tweaking f_flags */ | ||
503 | lock_kernel(); | ||
504 | error = ioctl_fionbio(filp, argp); | 506 | error = ioctl_fionbio(filp, argp); |
505 | unlock_kernel(); | ||
506 | break; | 507 | break; |
507 | 508 | ||
508 | case FIOASYNC: | 509 | case FIOASYNC: |