diff options
Diffstat (limited to 'fs/ext4/xattr.c')
-rw-r--r-- | fs/ext4/xattr.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 2251769a3c53..3a91ebc2b66f 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c | |||
@@ -628,9 +628,14 @@ ext4_xattr_set_entry(struct ext4_xattr_info *i, struct ext4_xattr_search *s) | |||
628 | size. Just replace. */ | 628 | size. Just replace. */ |
629 | s->here->e_value_size = | 629 | s->here->e_value_size = |
630 | cpu_to_le32(i->value_len); | 630 | cpu_to_le32(i->value_len); |
631 | memset(val + size - EXT4_XATTR_PAD, 0, | 631 | if (i->value == EXT4_ZERO_XATTR_VALUE) { |
632 | EXT4_XATTR_PAD); /* Clear pad bytes. */ | 632 | memset(val, 0, size); |
633 | memcpy(val, i->value, i->value_len); | 633 | } else { |
634 | /* Clear pad bytes first. */ | ||
635 | memset(val + size - EXT4_XATTR_PAD, 0, | ||
636 | EXT4_XATTR_PAD); | ||
637 | memcpy(val, i->value, i->value_len); | ||
638 | } | ||
634 | return 0; | 639 | return 0; |
635 | } | 640 | } |
636 | 641 | ||
@@ -669,9 +674,14 @@ ext4_xattr_set_entry(struct ext4_xattr_info *i, struct ext4_xattr_search *s) | |||
669 | size_t size = EXT4_XATTR_SIZE(i->value_len); | 674 | size_t size = EXT4_XATTR_SIZE(i->value_len); |
670 | void *val = s->base + min_offs - size; | 675 | void *val = s->base + min_offs - size; |
671 | s->here->e_value_offs = cpu_to_le16(min_offs - size); | 676 | s->here->e_value_offs = cpu_to_le16(min_offs - size); |
672 | memset(val + size - EXT4_XATTR_PAD, 0, | 677 | if (i->value == EXT4_ZERO_XATTR_VALUE) { |
673 | EXT4_XATTR_PAD); /* Clear the pad bytes. */ | 678 | memset(val, 0, size); |
674 | memcpy(val, i->value, i->value_len); | 679 | } else { |
680 | /* Clear the pad bytes first. */ | ||
681 | memset(val + size - EXT4_XATTR_PAD, 0, | ||
682 | EXT4_XATTR_PAD); | ||
683 | memcpy(val, i->value, i->value_len); | ||
684 | } | ||
675 | } | 685 | } |
676 | } | 686 | } |
677 | return 0; | 687 | return 0; |