1 files changed, 17 insertions, 14 deletions

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 5d45582f9517..c4dd1103ccf1 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -165,7 +165,7 @@ restart:
 
         printk("Block Allocation Reservation Windows Map (%s):\n", fn);
         while (n) {
-                rsv = list_entry(n, struct ext4_reserve_window_node, rsv_node);
+                rsv = rb_entry(n, struct ext4_reserve_window_node, rsv_node);
                 if (verbose)
                         printk("reservation window 0x%p "
                                "start:  %llu, end:  %llu\n",
@@ -747,7 +747,7 @@ find_next_usable_block(ext4_grpblk_t start, struct buffer_head *bh,
                 here = 0;
 
         p = ((char *)bh->b_data) + (here >> 3);
-        r = memscan(p, 0, (maxblocks - here + 7) >> 3);
+        r = memscan(p, 0, ((maxblocks + 7) >> 3) - (here >> 3));
         next = (r - ((char *)bh->b_data)) << 3;
 
         if (next < maxblocks && next >= start && ext4_test_allocatable(next, bh))
@@ -966,7 +966,7 @@ static int find_next_reservable_window(
 
                 prev = rsv;
                 next = rb_next(&rsv->rsv_node);
-                rsv = list_entry(next,struct ext4_reserve_window_node,rsv_node);
+                rsv = rb_entry(next,struct ext4_reserve_window_node,rsv_node);
 
                 /*
                  * Reached the last reservation, we can just append to the
@@ -1165,7 +1165,7 @@ retry:
          * check if the first free block is within the
          * free space we just reserved
          */
-        if (start_block >= my_rsv->rsv_start && start_block < my_rsv->rsv_end)
+        if (start_block >= my_rsv->rsv_start && start_block <= my_rsv->rsv_end)
                 return 0;               /* success */
         /*
          * if the first free bit we found is out of the reservable space
@@ -1210,7 +1210,7 @@ static void try_to_extend_reservation(struct ext4_reserve_window_node *my_rsv,
         if (!next)
                 my_rsv->rsv_end += size;
         else {
-                next_rsv = list_entry(next, struct ext4_reserve_window_node, rsv_node);
+                next_rsv = rb_entry(next, struct ext4_reserve_window_node, rsv_node);
 
                 if ((next_rsv->rsv_start - my_rsv->rsv_end - 1) >= size)
                         my_rsv->rsv_end += size;
@@ -1288,7 +1288,7 @@ ext4_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle,
         }
         /*
          * grp_goal is a group relative block number (if there is a goal)
-         * 0 < grp_goal < EXT4_BLOCKS_PER_GROUP(sb)
+         * 0 <= grp_goal < EXT4_BLOCKS_PER_GROUP(sb)
          * first block is a filesystem wide block number
          * first block is the block number of the first block in this group
          */
@@ -1324,10 +1324,14 @@ ext4_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle,
                         if (!goal_in_my_reservation(&my_rsv->rsv_window,
                                                         grp_goal, group, sb))
                                 grp_goal = -1;
-                } else if (grp_goal > 0 &&
-                          (my_rsv->rsv_end-grp_goal+1) < *count)
-                        try_to_extend_reservation(my_rsv, sb,
-                                        *count-my_rsv->rsv_end + grp_goal - 1);
+                } else if (grp_goal >= 0) {
+                        int curr = my_rsv->rsv_end -
+                                        (grp_goal + group_first_block) + 1;
+
+                        if (curr < *count)
+                                try_to_extend_reservation(my_rsv, sb,
+                                                        *count - curr);
+                }
 
                 if ((my_rsv->rsv_start > group_last_block) ||
                                 (my_rsv->rsv_end < group_first_block)) {
@@ -1525,10 +1529,8 @@ retry_alloc:
                 if (group_no >= ngroups)
                         group_no = 0;
                 gdp = ext4_get_group_desc(sb, group_no, &gdp_bh);
-                if (!gdp) {
-                        *errp = -EIO;
-                        goto out;
-                }
+                if (!gdp)
+                        goto io_error;
                 free_blocks = le16_to_cpu(gdp->bg_free_blocks_count);
                 /*
                  * skip this group if the number of
@@ -1562,6 +1564,7 @@ retry_alloc:
          */
         if (my_rsv) {
                 my_rsv = NULL;
+                windowsz = 0;
                 group_no = goal_group;
                 goto retry_alloc;
         }