1 files changed, 31 insertions, 22 deletions

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index ad5360664082..fe3119a71ada 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -84,7 +84,7 @@ handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks)
          * take the FS itself readonly cleanly. */
         journal = EXT3_SB(sb)->s_journal;
         if (is_journal_aborted(journal)) {
-                ext3_abort(sb, __FUNCTION__,
+                ext3_abort(sb, __func__,
                            "Detected aborted journal");
                 return ERR_PTR(-EROFS);
         }
@@ -304,7 +304,7 @@ void ext3_update_dynamic_rev(struct super_block *sb)
         if (le32_to_cpu(es->s_rev_level) > EXT3_GOOD_OLD_REV)
                 return;
 
-        ext3_warning(sb, __FUNCTION__,
+        ext3_warning(sb, __func__,
                      "updating to rev %d because of new feature flag, "
                      "running e2fsck is recommended",
                      EXT3_DYNAMIC_REV);
@@ -685,7 +685,8 @@ static int ext3_acquire_dquot(struct dquot *dquot);
 static int ext3_release_dquot(struct dquot *dquot);
 static int ext3_mark_dquot_dirty(struct dquot *dquot);
 static int ext3_write_info(struct super_block *sb, int type);
-static int ext3_quota_on(struct super_block *sb, int type, int format_id, char *path);
+static int ext3_quota_on(struct super_block *sb, int type, int format_id,
+                                char *path, int remount);
 static int ext3_quota_on_mount(struct super_block *sb, int type);
 static ssize_t ext3_quota_read(struct super_block *sb, int type, char *data,
                                size_t len, loff_t off);
@@ -1096,6 +1097,9 @@ clear_qf_name:
                 case Opt_quota:
                 case Opt_usrquota:
                 case Opt_grpquota:
+                        printk(KERN_ERR
+                                "EXT3-fs: quota options not supported.\n");
+                        break;
                 case Opt_usrjquota:
                 case Opt_grpjquota:
                 case Opt_offusrjquota:
@@ -1103,7 +1107,7 @@ clear_qf_name:
                 case Opt_jqfmt_vfsold:
                 case Opt_jqfmt_vfsv0:
                         printk(KERN_ERR
-                                "EXT3-fs: journalled quota options not "
+                                "EXT3-fs: journaled quota options not "
                                 "supported.\n");
                         break;
                 case Opt_noquota:
@@ -1218,7 +1222,7 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es,
                    inconsistencies, to force a fsck at reboot.  But for
                    a plain journaled filesystem we can keep it set as
                    valid forever! :) */
-        es->s_state = cpu_to_le16(le16_to_cpu(es->s_state) & ~EXT3_VALID_FS);
+        es->s_state &= cpu_to_le16(~EXT3_VALID_FS);
 #endif
         if (!(__s16) le16_to_cpu(es->s_max_mnt_count))
                 es->s_max_mnt_count = cpu_to_le16(EXT3_DFL_MAX_MNT_COUNT);
@@ -1253,14 +1257,14 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es,
 static int ext3_check_descriptors(struct super_block *sb)
 {
         struct ext3_sb_info *sbi = EXT3_SB(sb);
-        ext3_fsblk_t first_block = le32_to_cpu(sbi->s_es->s_first_data_block);
-        ext3_fsblk_t last_block;
         int i;
 
         ext3_debug ("Checking group descriptors");
 
         for (i = 0; i < sbi->s_groups_count; i++) {
                 struct ext3_group_desc *gdp = ext3_get_group_desc(sb, i, NULL);
+                ext3_fsblk_t first_block = ext3_group_first_block_no(sb, i);
+                ext3_fsblk_t last_block;
 
                 if (i == sbi->s_groups_count - 1)
                         last_block = le32_to_cpu(sbi->s_es->s_blocks_count) - 1;
@@ -1299,7 +1303,6 @@ static int ext3_check_descriptors(struct super_block *sb)
                                         le32_to_cpu(gdp->bg_inode_table));
                         return 0;
                 }
-                first_block += EXT3_BLOCKS_PER_GROUP(sb);
         }
 
         sbi->s_es->s_free_blocks_count=cpu_to_le32(ext3_count_free_blocks(sb));
@@ -1387,7 +1390,7 @@ static void ext3_orphan_cleanup (struct super_block * sb,
                 if (inode->i_nlink) {
                         printk(KERN_DEBUG
                                 "%s: truncating inode %lu to %Ld bytes\n",
-                                __FUNCTION__, inode->i_ino, inode->i_size);
+                                __func__, inode->i_ino, inode->i_size);
                         jbd_debug(2, "truncating inode %lu to %Ld bytes\n",
                                   inode->i_ino, inode->i_size);
                         ext3_truncate(inode);
@@ -1395,7 +1398,7 @@ static void ext3_orphan_cleanup (struct super_block * sb,
                 } else {
                         printk(KERN_DEBUG
                                 "%s: deleting unreferenced inode %lu\n",
-                                __FUNCTION__, inode->i_ino);
+                                __func__, inode->i_ino);
                         jbd_debug(2, "deleting unreferenced inode %lu\n",
                                   inode->i_ino);
                         nr_orphans++;
@@ -1415,7 +1418,7 @@ static void ext3_orphan_cleanup (struct super_block * sb,
         /* Turn quotas off */
         for (i = 0; i < MAXQUOTAS; i++) {
                 if (sb_dqopt(sb)->files[i])
-                        vfs_quota_off(sb, i);
+                        vfs_quota_off(sb, i, 0);
         }
 #endif
         sb->s_flags = s_flags; /* Restore MS_RDONLY status */
@@ -2298,9 +2301,9 @@ static void ext3_clear_journal_err(struct super_block * sb,
                 char nbuf[16];
 
                 errstr = ext3_decode_error(sb, j_errno, nbuf);
-                ext3_warning(sb, __FUNCTION__, "Filesystem error recorded "
+                ext3_warning(sb, __func__, "Filesystem error recorded "
                              "from previous mount: %s", errstr);
-                ext3_warning(sb, __FUNCTION__, "Marking fs in need of "
+                ext3_warning(sb, __func__, "Marking fs in need of "
                              "filesystem check.");
 
                 EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS;
@@ -2427,7 +2430,7 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
         }
 
         if (sbi->s_mount_opt & EXT3_MOUNT_ABORT)
-                ext3_abort(sb, __FUNCTION__, "Abort forced by user");
+                ext3_abort(sb, __func__, "Abort forced by user");
 
         sb->s_flags = (sb->s_flags & ~MS_POSIXACL) |
                 ((sbi->s_mount_opt & EXT3_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0);
@@ -2639,8 +2642,14 @@ static int ext3_dquot_drop(struct inode *inode)
 
         /* We may delete quota structure so we need to reserve enough blocks */
         handle = ext3_journal_start(inode, 2*EXT3_QUOTA_DEL_BLOCKS(inode->i_sb));
-        if (IS_ERR(handle))
+        if (IS_ERR(handle)) {
+                /*
+                 * We call dquot_drop() anyway to at least release references
+                 * to quota structures so that umount does not hang.
+                 */
+                dquot_drop(inode);
                 return PTR_ERR(handle);
+        }
         ret = dquot_drop(inode);
         err = ext3_journal_stop(handle);
         if (!ret)
@@ -2743,17 +2752,17 @@ static int ext3_quota_on_mount(struct super_block *sb, int type)
  * Standard function to be called on quota_on
  */
 static int ext3_quota_on(struct super_block *sb, int type, int format_id,
-                         char *path)
+                         char *path, int remount)
 {
         int err;
         struct nameidata nd;
 
         if (!test_opt(sb, QUOTA))
                 return -EINVAL;
-        /* Not journalling quota? */
-        if (!EXT3_SB(sb)->s_qf_names[USRQUOTA] &&
-            !EXT3_SB(sb)->s_qf_names[GRPQUOTA])
-                return vfs_quota_on(sb, type, format_id, path);
+        /* Not journalling quota or remount? */
+        if ((!EXT3_SB(sb)->s_qf_names[USRQUOTA] &&
+            !EXT3_SB(sb)->s_qf_names[GRPQUOTA]) || remount)
+                return vfs_quota_on(sb, type, format_id, path, remount);
         err = path_lookup(path, LOOKUP_FOLLOW, &nd);
         if (err)
                 return err;
@@ -2762,13 +2771,13 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id,
                 path_put(&nd.path);
                 return -EXDEV;
         }
-        /* Quotafile not of fs root? */
+        /* Quotafile not in fs root? */
         if (nd.path.dentry->d_parent->d_inode != sb->s_root->d_inode)
                 printk(KERN_WARNING
                         "EXT3-fs: Quota file not on filesystem root. "
                         "Journalled quota will not work.\n");
         path_put(&nd.path);
-        return vfs_quota_on(sb, type, format_id, path);
+        return vfs_quota_on(sb, type, format_id, path, remount);
 }
 
 /* Read data from quotafile - avoid pagecache and such because we cannot afford