1 files changed, 11 insertions, 14 deletions

diff --git a/fs/exec.c b/fs/exec.c
index 7bdea7937ee8..c21a8cc06277 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -780,18 +780,11 @@ static int de_thread(struct task_struct *tsk)
         int count;
 
         /*
-         * Tell all the sighand listeners that this sighand has
-         * been detached. The signalfd_detach() function grabs the
-         * sighand lock, if signal listeners are present on the sighand.
-         */
-        signalfd_detach(tsk);
-
-        /*
          * If we don't share sighandlers, then we aren't sharing anything
          * and we can just re-use it all.
          */
         if (atomic_read(&oldsighand->count) <= 1) {
-                BUG_ON(atomic_read(&sig->count) != 1);
+                signalfd_detach(tsk);
                 exit_itimers(sig);
                 return 0;
         }
@@ -930,12 +923,11 @@ static int de_thread(struct task_struct *tsk)
         sig->flags = 0;
 
 no_thread_group:
+        signalfd_detach(tsk);
         exit_itimers(sig);
         if (leader)
                 release_task(leader);
 
-        BUG_ON(atomic_read(&sig->count) != 1);
-
         if (atomic_read(&oldsighand->count) == 1) {
                 /*
                  * Now that we nuked the rest of the thread group,
@@ -1084,9 +1076,12 @@ int flush_old_exec(struct linux_binprm * bprm)
          */
         current->mm->task_size = TASK_SIZE;
 
-        if (bprm->e_uid != current->euid || bprm->e_gid != current->egid || 
-            file_permission(bprm->file, MAY_READ) ||
-            (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP)) {
+        if (bprm->e_uid != current->euid || bprm->e_gid != current->egid) {
+                suid_keys(current);
+                set_dumpable(current->mm, suid_dumpable);
+                current->pdeath_signal = 0;
+        } else if (file_permission(bprm->file, MAY_READ) ||
+                        (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP)) {
                 suid_keys(current);
                 set_dumpable(current->mm, suid_dumpable);
         }
@@ -1177,8 +1172,10 @@ void compute_creds(struct linux_binprm *bprm)
 {
         int unsafe;
 
-        if (bprm->e_uid != current->uid)
+        if (bprm->e_uid != current->uid) {
                 suid_keys(current);
+                current->pdeath_signal = 0;
+        }
         exec_keys(current);
 
         task_lock(current);