4 files changed, 13 insertions, 39 deletions

diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
index cd62d75b2cc0..e2832bc7869a 100644
--- a/fs/ecryptfs/crypto.c
+++ b/fs/ecryptfs/crypto.c
@@ -1906,9 +1906,9 @@ int ecryptfs_get_tfm_and_mutex_for_cipher_name(struct crypto_blkcipher **tfm,
                         goto out;
                 }
         }
-        mutex_unlock(&key_tfm_list_mutex);
         (*tfm) = key_tfm->key_tfm;
         (*tfm_mutex) = &key_tfm->key_tfm_mutex;
 out:
+        mutex_unlock(&key_tfm_list_mutex);
         return rc;
 }
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h
index 951ee33a022d..c15c25745e05 100644
--- a/fs/ecryptfs/ecryptfs_kernel.h
+++ b/fs/ecryptfs/ecryptfs_kernel.h
@@ -660,8 +660,6 @@ int ecryptfs_get_tfm_and_mutex_for_cipher_name(struct crypto_blkcipher **tfm,
 int ecryptfs_keyring_auth_tok_for_sig(struct key **auth_tok_key,
                                       struct ecryptfs_auth_tok **auth_tok,
                                       char *sig);
-int ecryptfs_write_zeros(struct file *file, pgoff_t index, int start,
-                         int num_zeros);
 int ecryptfs_write_lower(struct inode *ecryptfs_inode, char *data,
                          loff_t offset, size_t size);
 int ecryptfs_write_lower_page_segment(struct inode *ecryptfs_inode,
diff --git a/fs/ecryptfs/miscdev.c b/fs/ecryptfs/miscdev.c
index 6560da1a58ce..50c994a249a5 100644
--- a/fs/ecryptfs/miscdev.c
+++ b/fs/ecryptfs/miscdev.c
@@ -243,7 +243,6 @@ ecryptfs_miscdev_read(struct file *file, char __user *buf, size_t count,
         struct ecryptfs_daemon *daemon;
         struct ecryptfs_msg_ctx *msg_ctx;
         size_t packet_length_size;
-        u32 counter_nbo;
         char packet_length[3];
         size_t i;
         size_t total_length;
@@ -328,20 +327,18 @@ check_list:
                        "pending message\n", __func__, count, total_length);
                 goto out_unlock_msg_ctx;
         }
-        i = 0;
-        buf[i++] = msg_ctx->type;
-        counter_nbo = cpu_to_be32(msg_ctx->counter);
-        memcpy(&buf[i], (char *)&counter_nbo, 4);
-        i += 4;
+        rc = -EFAULT;
+        if (put_user(msg_ctx->type, buf))
+                goto out_unlock_msg_ctx;
+        if (put_user(cpu_to_be32(msg_ctx->counter), (__be32 __user *)(buf + 1)))
+                goto out_unlock_msg_ctx;
+        i = 5;
         if (msg_ctx->msg) {
-                memcpy(&buf[i], packet_length, packet_length_size);
+                if (copy_to_user(&buf[i], packet_length, packet_length_size))
+                        goto out_unlock_msg_ctx;
                 i += packet_length_size;
-                rc = copy_to_user(&buf[i], msg_ctx->msg, msg_ctx->msg_size);
-                if (rc) {
-                        printk(KERN_ERR "%s: copy_to_user returned error "
-                               "[%d]\n", __func__, rc);
+                if (copy_to_user(&buf[i], msg_ctx->msg, msg_ctx->msg_size))
                         goto out_unlock_msg_ctx;
-                }
                 i += msg_ctx->msg_size;
         }
         rc = i;
@@ -452,7 +449,8 @@ static ssize_t
 ecryptfs_miscdev_write(struct file *file, const char __user *buf,
                        size_t count, loff_t *ppos)
 {
-        u32 counter_nbo, seq;
+        __be32 counter_nbo;
+        u32 seq;
         size_t packet_size, packet_size_length, i;
         ssize_t sz = 0;
         char *data;
@@ -485,7 +483,7 @@ ecryptfs_miscdev_write(struct file *file, const char __user *buf,
                                count);
                         goto out_free;
                 }
-                memcpy((char *)&counter_nbo, &data[i], 4);
+                memcpy(&counter_nbo, &data[i], 4);
                 seq = be32_to_cpu(counter_nbo);
                 i += 4;
                 rc = ecryptfs_parse_packet_length(&data[i], &packet_size,
diff --git a/fs/ecryptfs/read_write.c b/fs/ecryptfs/read_write.c
index ebf55150be56..75c2ea9fee35 100644
--- a/fs/ecryptfs/read_write.c
+++ b/fs/ecryptfs/read_write.c
@@ -157,20 +157,6 @@ int ecryptfs_write(struct file *ecryptfs_file, char *data, loff_t offset,
                                ecryptfs_page_idx, rc);
                         goto out;
                 }
-                if (start_offset_in_page) {
-                        /* Read in the page from the lower
-                         * into the eCryptfs inode page cache,
-                         * decrypting */
-                        rc = ecryptfs_decrypt_page(ecryptfs_page);
-                        if (rc) {
-                                printk(KERN_ERR "%s: Error decrypting "
-                                       "page; rc = [%d]\n",
-                                       __func__, rc);
-                                ClearPageUptodate(ecryptfs_page);
-                                page_cache_release(ecryptfs_page);
-                                goto out;
-                        }
-                }
                 ecryptfs_page_virt = kmap_atomic(ecryptfs_page, KM_USER0);
 
                 /*
@@ -349,14 +335,6 @@ int ecryptfs_read(char *data, loff_t offset, size_t size,
                                ecryptfs_page_idx, rc);
                         goto out;
                 }
-                rc = ecryptfs_decrypt_page(ecryptfs_page);
-                if (rc) {
-                        printk(KERN_ERR "%s: Error decrypting "
-                               "page; rc = [%d]\n", __func__, rc);
-                        ClearPageUptodate(ecryptfs_page);
-                        page_cache_release(ecryptfs_page);
-                        goto out;
-                }
                 ecryptfs_page_virt = kmap_atomic(ecryptfs_page, KM_USER0);
                 memcpy((data + data_offset),
                        ((char *)ecryptfs_page_virt + start_offset_in_page),