diff options
Diffstat (limited to 'fs/dlm/config.c')
| -rw-r--r-- | fs/dlm/config.c | 50 |
1 files changed, 40 insertions, 10 deletions
diff --git a/fs/dlm/config.c b/fs/dlm/config.c index c3ad1dff3b25..eac23bd288b2 100644 --- a/fs/dlm/config.c +++ b/fs/dlm/config.c | |||
| @@ -114,7 +114,7 @@ struct cluster_attribute { | |||
| 114 | }; | 114 | }; |
| 115 | 115 | ||
| 116 | static ssize_t cluster_set(struct cluster *cl, unsigned int *cl_field, | 116 | static ssize_t cluster_set(struct cluster *cl, unsigned int *cl_field, |
| 117 | unsigned int *info_field, int check_zero, | 117 | int *info_field, int check_zero, |
| 118 | const char *buf, size_t len) | 118 | const char *buf, size_t len) |
| 119 | { | 119 | { |
| 120 | unsigned int x; | 120 | unsigned int x; |
| @@ -284,6 +284,7 @@ struct node { | |||
| 284 | struct list_head list; /* space->members */ | 284 | struct list_head list; /* space->members */ |
| 285 | int nodeid; | 285 | int nodeid; |
| 286 | int weight; | 286 | int weight; |
| 287 | int new; | ||
| 287 | }; | 288 | }; |
| 288 | 289 | ||
| 289 | static struct configfs_group_operations clusters_ops = { | 290 | static struct configfs_group_operations clusters_ops = { |
| @@ -565,6 +566,7 @@ static struct config_item *make_node(struct config_group *g, const char *name) | |||
| 565 | config_item_init_type_name(&nd->item, name, &node_type); | 566 | config_item_init_type_name(&nd->item, name, &node_type); |
| 566 | nd->nodeid = -1; | 567 | nd->nodeid = -1; |
| 567 | nd->weight = 1; /* default weight of 1 if none is set */ | 568 | nd->weight = 1; /* default weight of 1 if none is set */ |
| 569 | nd->new = 1; /* set to 0 once it's been read by dlm_nodeid_list() */ | ||
| 568 | 570 | ||
| 569 | mutex_lock(&sp->members_lock); | 571 | mutex_lock(&sp->members_lock); |
| 570 | list_add(&nd->list, &sp->members); | 572 | list_add(&nd->list, &sp->members); |
| @@ -805,12 +807,13 @@ static void put_comm(struct comm *cm) | |||
| 805 | } | 807 | } |
| 806 | 808 | ||
| 807 | /* caller must free mem */ | 809 | /* caller must free mem */ |
| 808 | int dlm_nodeid_list(char *lsname, int **ids_out) | 810 | int dlm_nodeid_list(char *lsname, int **ids_out, int *ids_count_out, |
| 811 | int **new_out, int *new_count_out) | ||
| 809 | { | 812 | { |
| 810 | struct space *sp; | 813 | struct space *sp; |
| 811 | struct node *nd; | 814 | struct node *nd; |
| 812 | int i = 0, rv = 0; | 815 | int i = 0, rv = 0, ids_count = 0, new_count = 0; |
| 813 | int *ids; | 816 | int *ids, *new; |
| 814 | 817 | ||
| 815 | sp = get_space(lsname); | 818 | sp = get_space(lsname); |
| 816 | if (!sp) | 819 | if (!sp) |
| @@ -818,23 +821,50 @@ int dlm_nodeid_list(char *lsname, int **ids_out) | |||
| 818 | 821 | ||
| 819 | mutex_lock(&sp->members_lock); | 822 | mutex_lock(&sp->members_lock); |
| 820 | if (!sp->members_count) { | 823 | if (!sp->members_count) { |
| 821 | rv = 0; | 824 | rv = -EINVAL; |
| 825 | printk(KERN_ERR "dlm: zero members_count\n"); | ||
| 822 | goto out; | 826 | goto out; |
| 823 | } | 827 | } |
| 824 | 828 | ||
| 825 | ids = kcalloc(sp->members_count, sizeof(int), GFP_KERNEL); | 829 | ids_count = sp->members_count; |
| 830 | |||
| 831 | ids = kcalloc(ids_count, sizeof(int), GFP_KERNEL); | ||
| 826 | if (!ids) { | 832 | if (!ids) { |
| 827 | rv = -ENOMEM; | 833 | rv = -ENOMEM; |
| 828 | goto out; | 834 | goto out; |
| 829 | } | 835 | } |
| 830 | 836 | ||
| 831 | rv = sp->members_count; | 837 | list_for_each_entry(nd, &sp->members, list) { |
| 832 | list_for_each_entry(nd, &sp->members, list) | ||
| 833 | ids[i++] = nd->nodeid; | 838 | ids[i++] = nd->nodeid; |
| 839 | if (nd->new) | ||
| 840 | new_count++; | ||
| 841 | } | ||
| 842 | |||
| 843 | if (ids_count != i) | ||
| 844 | printk(KERN_ERR "dlm: bad nodeid count %d %d\n", ids_count, i); | ||
| 845 | |||
| 846 | if (!new_count) | ||
| 847 | goto out_ids; | ||
| 848 | |||
| 849 | new = kcalloc(new_count, sizeof(int), GFP_KERNEL); | ||
| 850 | if (!new) { | ||
| 851 | kfree(ids); | ||
| 852 | rv = -ENOMEM; | ||
| 853 | goto out; | ||
| 854 | } | ||
| 834 | 855 | ||
| 835 | if (rv != i) | 856 | i = 0; |
| 836 | printk("bad nodeid count %d %d\n", rv, i); | 857 | list_for_each_entry(nd, &sp->members, list) { |
| 858 | if (nd->new) { | ||
| 859 | new[i++] = nd->nodeid; | ||
| 860 | nd->new = 0; | ||
| 861 | } | ||
| 862 | } | ||
| 863 | *new_count_out = new_count; | ||
| 864 | *new_out = new; | ||
| 837 | 865 | ||
| 866 | out_ids: | ||
| 867 | *ids_count_out = ids_count; | ||
| 838 | *ids_out = ids; | 868 | *ids_out = ids; |
| 839 | out: | 869 | out: |
| 840 | mutex_unlock(&sp->members_lock); | 870 | mutex_unlock(&sp->members_lock); |
