diff options
Diffstat (limited to 'fs/cachefiles')
| -rw-r--r-- | fs/cachefiles/bind.c | 2 | ||||
| -rw-r--r-- | fs/cachefiles/daemon.c | 38 | ||||
| -rw-r--r-- | fs/cachefiles/internal.h | 13 | ||||
| -rw-r--r-- | fs/cachefiles/namei.c | 13 | ||||
| -rw-r--r-- | fs/cachefiles/rdwr.c | 4 |
5 files changed, 29 insertions, 41 deletions
diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c index 2906077ac798..a2603e7c0bb5 100644 --- a/fs/cachefiles/bind.c +++ b/fs/cachefiles/bind.c | |||
| @@ -146,7 +146,7 @@ static int cachefiles_daemon_add_cache(struct cachefiles_cache *cache) | |||
| 146 | goto error_unsupported; | 146 | goto error_unsupported; |
| 147 | 147 | ||
| 148 | /* get the cache size and blocksize */ | 148 | /* get the cache size and blocksize */ |
| 149 | ret = vfs_statfs(root, &stats); | 149 | ret = vfs_statfs(&path, &stats); |
| 150 | if (ret < 0) | 150 | if (ret < 0) |
| 151 | goto error_unsupported; | 151 | goto error_unsupported; |
| 152 | 152 | ||
diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c index c2413561ea75..727caedcdd92 100644 --- a/fs/cachefiles/daemon.c +++ b/fs/cachefiles/daemon.c | |||
| @@ -552,8 +552,7 @@ static int cachefiles_daemon_tag(struct cachefiles_cache *cache, char *args) | |||
| 552 | */ | 552 | */ |
| 553 | static int cachefiles_daemon_cull(struct cachefiles_cache *cache, char *args) | 553 | static int cachefiles_daemon_cull(struct cachefiles_cache *cache, char *args) |
| 554 | { | 554 | { |
| 555 | struct fs_struct *fs; | 555 | struct path path; |
| 556 | struct dentry *dir; | ||
| 557 | const struct cred *saved_cred; | 556 | const struct cred *saved_cred; |
| 558 | int ret; | 557 | int ret; |
| 559 | 558 | ||
| @@ -573,24 +572,21 @@ static int cachefiles_daemon_cull(struct cachefiles_cache *cache, char *args) | |||
| 573 | } | 572 | } |
| 574 | 573 | ||
| 575 | /* extract the directory dentry from the cwd */ | 574 | /* extract the directory dentry from the cwd */ |
| 576 | fs = current->fs; | 575 | get_fs_pwd(current->fs, &path); |
| 577 | read_lock(&fs->lock); | ||
| 578 | dir = dget(fs->pwd.dentry); | ||
| 579 | read_unlock(&fs->lock); | ||
| 580 | 576 | ||
| 581 | if (!S_ISDIR(dir->d_inode->i_mode)) | 577 | if (!S_ISDIR(path.dentry->d_inode->i_mode)) |
| 582 | goto notdir; | 578 | goto notdir; |
| 583 | 579 | ||
| 584 | cachefiles_begin_secure(cache, &saved_cred); | 580 | cachefiles_begin_secure(cache, &saved_cred); |
| 585 | ret = cachefiles_cull(cache, dir, args); | 581 | ret = cachefiles_cull(cache, path.dentry, args); |
| 586 | cachefiles_end_secure(cache, saved_cred); | 582 | cachefiles_end_secure(cache, saved_cred); |
| 587 | 583 | ||
| 588 | dput(dir); | 584 | path_put(&path); |
| 589 | _leave(" = %d", ret); | 585 | _leave(" = %d", ret); |
| 590 | return ret; | 586 | return ret; |
| 591 | 587 | ||
| 592 | notdir: | 588 | notdir: |
| 593 | dput(dir); | 589 | path_put(&path); |
| 594 | kerror("cull command requires dirfd to be a directory"); | 590 | kerror("cull command requires dirfd to be a directory"); |
| 595 | return -ENOTDIR; | 591 | return -ENOTDIR; |
| 596 | 592 | ||
| @@ -628,8 +624,7 @@ inval: | |||
| 628 | */ | 624 | */ |
| 629 | static int cachefiles_daemon_inuse(struct cachefiles_cache *cache, char *args) | 625 | static int cachefiles_daemon_inuse(struct cachefiles_cache *cache, char *args) |
| 630 | { | 626 | { |
| 631 | struct fs_struct *fs; | 627 | struct path path; |
| 632 | struct dentry *dir; | ||
| 633 | const struct cred *saved_cred; | 628 | const struct cred *saved_cred; |
| 634 | int ret; | 629 | int ret; |
| 635 | 630 | ||
| @@ -649,24 +644,21 @@ static int cachefiles_daemon_inuse(struct cachefiles_cache *cache, char *args) | |||
| 649 | } | 644 | } |
| 650 | 645 | ||
| 651 | /* extract the directory dentry from the cwd */ | 646 | /* extract the directory dentry from the cwd */ |
| 652 | fs = current->fs; | 647 | get_fs_pwd(current->fs, &path); |
| 653 | read_lock(&fs->lock); | ||
| 654 | dir = dget(fs->pwd.dentry); | ||
| 655 | read_unlock(&fs->lock); | ||
| 656 | 648 | ||
| 657 | if (!S_ISDIR(dir->d_inode->i_mode)) | 649 | if (!S_ISDIR(path.dentry->d_inode->i_mode)) |
| 658 | goto notdir; | 650 | goto notdir; |
| 659 | 651 | ||
| 660 | cachefiles_begin_secure(cache, &saved_cred); | 652 | cachefiles_begin_secure(cache, &saved_cred); |
| 661 | ret = cachefiles_check_in_use(cache, dir, args); | 653 | ret = cachefiles_check_in_use(cache, path.dentry, args); |
| 662 | cachefiles_end_secure(cache, saved_cred); | 654 | cachefiles_end_secure(cache, saved_cred); |
| 663 | 655 | ||
| 664 | dput(dir); | 656 | path_put(&path); |
| 665 | //_leave(" = %d", ret); | 657 | //_leave(" = %d", ret); |
| 666 | return ret; | 658 | return ret; |
| 667 | 659 | ||
| 668 | notdir: | 660 | notdir: |
| 669 | dput(dir); | 661 | path_put(&path); |
| 670 | kerror("inuse command requires dirfd to be a directory"); | 662 | kerror("inuse command requires dirfd to be a directory"); |
| 671 | return -ENOTDIR; | 663 | return -ENOTDIR; |
| 672 | 664 | ||
| @@ -683,6 +675,10 @@ int cachefiles_has_space(struct cachefiles_cache *cache, | |||
| 683 | unsigned fnr, unsigned bnr) | 675 | unsigned fnr, unsigned bnr) |
| 684 | { | 676 | { |
| 685 | struct kstatfs stats; | 677 | struct kstatfs stats; |
| 678 | struct path path = { | ||
| 679 | .mnt = cache->mnt, | ||
| 680 | .dentry = cache->mnt->mnt_root, | ||
| 681 | }; | ||
| 686 | int ret; | 682 | int ret; |
| 687 | 683 | ||
| 688 | //_enter("{%llu,%llu,%llu,%llu,%llu,%llu},%u,%u", | 684 | //_enter("{%llu,%llu,%llu,%llu,%llu,%llu},%u,%u", |
| @@ -697,7 +693,7 @@ int cachefiles_has_space(struct cachefiles_cache *cache, | |||
| 697 | /* find out how many pages of blockdev are available */ | 693 | /* find out how many pages of blockdev are available */ |
| 698 | memset(&stats, 0, sizeof(stats)); | 694 | memset(&stats, 0, sizeof(stats)); |
| 699 | 695 | ||
| 700 | ret = vfs_statfs(cache->mnt->mnt_root, &stats); | 696 | ret = vfs_statfs(&path, &stats); |
| 701 | if (ret < 0) { | 697 | if (ret < 0) { |
| 702 | if (ret == -EIO) | 698 | if (ret == -EIO) |
| 703 | cachefiles_io_error(cache, "statfs failed"); | 699 | cachefiles_io_error(cache, "statfs failed"); |
diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h index a8cd821226da..bd6bc1bde2d7 100644 --- a/fs/cachefiles/internal.h +++ b/fs/cachefiles/internal.h | |||
| @@ -267,13 +267,6 @@ do { \ | |||
| 267 | #define dbgprintk(FMT, ...) \ | 267 | #define dbgprintk(FMT, ...) \ |
| 268 | printk(KERN_DEBUG "[%-6.6s] "FMT"\n", current->comm, ##__VA_ARGS__) | 268 | printk(KERN_DEBUG "[%-6.6s] "FMT"\n", current->comm, ##__VA_ARGS__) |
| 269 | 269 | ||
| 270 | /* make sure we maintain the format strings, even when debugging is disabled */ | ||
| 271 | static inline void _dbprintk(const char *fmt, ...) | ||
| 272 | __attribute__((format(printf, 1, 2))); | ||
| 273 | static inline void _dbprintk(const char *fmt, ...) | ||
| 274 | { | ||
| 275 | } | ||
| 276 | |||
| 277 | #define kenter(FMT, ...) dbgprintk("==> %s("FMT")", __func__, ##__VA_ARGS__) | 270 | #define kenter(FMT, ...) dbgprintk("==> %s("FMT")", __func__, ##__VA_ARGS__) |
| 278 | #define kleave(FMT, ...) dbgprintk("<== %s()"FMT"", __func__, ##__VA_ARGS__) | 271 | #define kleave(FMT, ...) dbgprintk("<== %s()"FMT"", __func__, ##__VA_ARGS__) |
| 279 | #define kdebug(FMT, ...) dbgprintk(FMT, ##__VA_ARGS__) | 272 | #define kdebug(FMT, ...) dbgprintk(FMT, ##__VA_ARGS__) |
| @@ -304,9 +297,9 @@ do { \ | |||
| 304 | } while (0) | 297 | } while (0) |
| 305 | 298 | ||
| 306 | #else | 299 | #else |
| 307 | #define _enter(FMT, ...) _dbprintk("==> %s("FMT")", __func__, ##__VA_ARGS__) | 300 | #define _enter(FMT, ...) no_printk("==> %s("FMT")", __func__, ##__VA_ARGS__) |
| 308 | #define _leave(FMT, ...) _dbprintk("<== %s()"FMT"", __func__, ##__VA_ARGS__) | 301 | #define _leave(FMT, ...) no_printk("<== %s()"FMT"", __func__, ##__VA_ARGS__) |
| 309 | #define _debug(FMT, ...) _dbprintk(FMT, ##__VA_ARGS__) | 302 | #define _debug(FMT, ...) no_printk(FMT, ##__VA_ARGS__) |
| 310 | #endif | 303 | #endif |
| 311 | 304 | ||
| 312 | #if 1 /* defined(__KDEBUGALL) */ | 305 | #if 1 /* defined(__KDEBUGALL) */ |
diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index f4a7840bf42c..42c7fafc8bfe 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c | |||
| @@ -37,9 +37,9 @@ void __cachefiles_printk_object(struct cachefiles_object *object, | |||
| 37 | 37 | ||
| 38 | printk(KERN_ERR "%sobject: OBJ%x\n", | 38 | printk(KERN_ERR "%sobject: OBJ%x\n", |
| 39 | prefix, object->fscache.debug_id); | 39 | prefix, object->fscache.debug_id); |
| 40 | printk(KERN_ERR "%sobjstate=%s fl=%lx swfl=%lx ev=%lx[%lx]\n", | 40 | printk(KERN_ERR "%sobjstate=%s fl=%lx wbusy=%x ev=%lx[%lx]\n", |
| 41 | prefix, fscache_object_states[object->fscache.state], | 41 | prefix, fscache_object_states[object->fscache.state], |
| 42 | object->fscache.flags, object->fscache.work.flags, | 42 | object->fscache.flags, work_busy(&object->fscache.work), |
| 43 | object->fscache.events, | 43 | object->fscache.events, |
| 44 | object->fscache.event_mask & FSCACHE_OBJECT_EVENTS_MASK); | 44 | object->fscache.event_mask & FSCACHE_OBJECT_EVENTS_MASK); |
| 45 | printk(KERN_ERR "%sops=%u inp=%u exc=%u\n", | 45 | printk(KERN_ERR "%sops=%u inp=%u exc=%u\n", |
| @@ -212,7 +212,7 @@ wait_for_old_object: | |||
| 212 | 212 | ||
| 213 | /* if the object we're waiting for is queued for processing, | 213 | /* if the object we're waiting for is queued for processing, |
| 214 | * then just put ourselves on the queue behind it */ | 214 | * then just put ourselves on the queue behind it */ |
| 215 | if (slow_work_is_queued(&xobject->fscache.work)) { | 215 | if (work_pending(&xobject->fscache.work)) { |
| 216 | _debug("queue OBJ%x behind OBJ%x immediately", | 216 | _debug("queue OBJ%x behind OBJ%x immediately", |
| 217 | object->fscache.debug_id, | 217 | object->fscache.debug_id, |
| 218 | xobject->fscache.debug_id); | 218 | xobject->fscache.debug_id); |
| @@ -220,8 +220,7 @@ wait_for_old_object: | |||
| 220 | } | 220 | } |
| 221 | 221 | ||
| 222 | /* otherwise we sleep until either the object we're waiting for | 222 | /* otherwise we sleep until either the object we're waiting for |
| 223 | * is done, or the slow-work facility wants the thread back to | 223 | * is done, or the fscache_object is congested */ |
| 224 | * do other work */ | ||
| 225 | wq = bit_waitqueue(&xobject->flags, CACHEFILES_OBJECT_ACTIVE); | 224 | wq = bit_waitqueue(&xobject->flags, CACHEFILES_OBJECT_ACTIVE); |
| 226 | init_wait(&wait); | 225 | init_wait(&wait); |
| 227 | requeue = false; | 226 | requeue = false; |
| @@ -229,8 +228,8 @@ wait_for_old_object: | |||
| 229 | prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE); | 228 | prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE); |
| 230 | if (!test_bit(CACHEFILES_OBJECT_ACTIVE, &xobject->flags)) | 229 | if (!test_bit(CACHEFILES_OBJECT_ACTIVE, &xobject->flags)) |
| 231 | break; | 230 | break; |
| 232 | requeue = slow_work_sleep_till_thread_needed( | 231 | |
| 233 | &object->fscache.work, &timeout); | 232 | requeue = fscache_object_sleep_till_congested(&timeout); |
| 234 | } while (timeout > 0 && !requeue); | 233 | } while (timeout > 0 && !requeue); |
| 235 | finish_wait(wq, &wait); | 234 | finish_wait(wq, &wait); |
| 236 | 235 | ||
diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 0f0d41fbb03f..0e3c0924cc3a 100644 --- a/fs/cachefiles/rdwr.c +++ b/fs/cachefiles/rdwr.c | |||
| @@ -422,7 +422,7 @@ int cachefiles_read_or_alloc_page(struct fscache_retrieval *op, | |||
| 422 | shift = PAGE_SHIFT - inode->i_sb->s_blocksize_bits; | 422 | shift = PAGE_SHIFT - inode->i_sb->s_blocksize_bits; |
| 423 | 423 | ||
| 424 | op->op.flags &= FSCACHE_OP_KEEP_FLAGS; | 424 | op->op.flags &= FSCACHE_OP_KEEP_FLAGS; |
| 425 | op->op.flags |= FSCACHE_OP_FAST; | 425 | op->op.flags |= FSCACHE_OP_ASYNC; |
| 426 | op->op.processor = cachefiles_read_copier; | 426 | op->op.processor = cachefiles_read_copier; |
| 427 | 427 | ||
| 428 | pagevec_init(&pagevec, 0); | 428 | pagevec_init(&pagevec, 0); |
| @@ -729,7 +729,7 @@ int cachefiles_read_or_alloc_pages(struct fscache_retrieval *op, | |||
| 729 | pagevec_init(&pagevec, 0); | 729 | pagevec_init(&pagevec, 0); |
| 730 | 730 | ||
| 731 | op->op.flags &= FSCACHE_OP_KEEP_FLAGS; | 731 | op->op.flags &= FSCACHE_OP_KEEP_FLAGS; |
| 732 | op->op.flags |= FSCACHE_OP_FAST; | 732 | op->op.flags |= FSCACHE_OP_ASYNC; |
| 733 | op->op.processor = cachefiles_read_copier; | 733 | op->op.processor = cachefiles_read_copier; |
| 734 | 734 | ||
| 735 | INIT_LIST_HEAD(&backpages); | 735 | INIT_LIST_HEAD(&backpages); |
