1 files changed, 42 insertions, 18 deletions

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 1f87c4d0e7a0..49f3c9dc09f4 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -935,8 +935,10 @@ again:
         node = tree_search(tree, start);
         if (!node) {
                 prealloc = alloc_extent_state_atomic(prealloc);
-                if (!prealloc)
-                        return -ENOMEM;
+                if (!prealloc) {
+                        err = -ENOMEM;
+                        goto out;
+                }
                 err = insert_state(tree, prealloc, start, end, &bits);
                 prealloc = NULL;
                 BUG_ON(err == -EEXIST);
@@ -992,8 +994,10 @@ hit_next:
          */
         if (state->start < start) {
                 prealloc = alloc_extent_state_atomic(prealloc);
-                if (!prealloc)
-                        return -ENOMEM;
+                if (!prealloc) {
+                        err = -ENOMEM;
+                        goto out;
+                }
                 err = split_state(tree, state, prealloc, start);
                 BUG_ON(err == -EEXIST);
                 prealloc = NULL;
@@ -1024,8 +1028,10 @@ hit_next:
                         this_end = last_start - 1;
 
                 prealloc = alloc_extent_state_atomic(prealloc);
-                if (!prealloc)
-                        return -ENOMEM;
+                if (!prealloc) {
+                        err = -ENOMEM;
+                        goto out;
+                }
 
                 /*
                  * Avoid to free 'prealloc' if it can be merged with
@@ -1051,8 +1057,10 @@ hit_next:
          */
         if (state->start <= end && state->end > end) {
                 prealloc = alloc_extent_state_atomic(prealloc);
-                if (!prealloc)
-                        return -ENOMEM;
+                if (!prealloc) {
+                        err = -ENOMEM;
+                        goto out;
+                }
 
                 err = split_state(tree, state, prealloc, end + 1);
                 BUG_ON(err == -EEXIST);
@@ -2285,16 +2293,22 @@ static void end_bio_extent_readpage(struct bio *bio, int err)
                                 clean_io_failure(start, page);
                 }
                 if (!uptodate) {
-                        u64 failed_mirror;
-                        failed_mirror = (u64)bio->bi_bdev;
-                        if (tree->ops && tree->ops->readpage_io_failed_hook)
-                                ret = tree->ops->readpage_io_failed_hook(
-                                                bio, page, start, end,
-                                                failed_mirror, state);
-                        else
-                                ret = bio_readpage_error(bio, page, start, end,
-                                                         failed_mirror, NULL);
+                        int failed_mirror;
+                        failed_mirror = (int)(unsigned long)bio->bi_bdev;
+                        /*
+                         * The generic bio_readpage_error handles errors the
+                         * following way: If possible, new read requests are
+                         * created and submitted and will end up in
+                         * end_bio_extent_readpage as well (if we're lucky, not
+                         * in the !uptodate case). In that case it returns 0 and
+                         * we just go on with the next page in our bio. If it
+                         * can't handle the error it will return -EIO and we
+                         * remain responsible for that page.
+                         */
+                        ret = bio_readpage_error(bio, page, start, end,
+                                                        failed_mirror, NULL);
                         if (ret == 0) {
+error_handled:
                                 uptodate =
                                         test_bit(BIO_UPTODATE, &bio->bi_flags);
                                 if (err)
@@ -2302,6 +2316,13 @@ static void end_bio_extent_readpage(struct bio *bio, int err)
                                 uncache_state(&cached);
                                 continue;
                         }
+                        if (tree->ops && tree->ops->readpage_io_failed_hook) {
+                                ret = tree->ops->readpage_io_failed_hook(
+                                                        bio, page, start, end,
+                                                        failed_mirror, state);
+                                if (ret == 0)
+                                        goto error_handled;
+                        }
                 }
 
                 if (uptodate) {
@@ -3366,6 +3387,9 @@ int extent_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
                 return -ENOMEM;
         path->leave_spinning = 1;
 
+        start = ALIGN(start, BTRFS_I(inode)->root->sectorsize);
+        len = ALIGN(len, BTRFS_I(inode)->root->sectorsize);
+
         /*
          * lookup the last file extent.  We're not using i_size here
          * because there might be preallocation past i_size
@@ -3413,7 +3437,7 @@ int extent_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
         lock_extent_bits(&BTRFS_I(inode)->io_tree, start, start + len, 0,
                          &cached_state, GFP_NOFS);
 
-        em = get_extent_skip_holes(inode, off, last_for_get_extent,
+        em = get_extent_skip_holes(inode, start, last_for_get_extent,
                                    get_extent);
         if (!em)
                 goto out;