diff options
Diffstat (limited to 'drivers')
147 files changed, 1604 insertions, 1055 deletions
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c index 53e7ac9403a7..e854582f29a6 100644 --- a/drivers/acpi/processor_perflib.c +++ b/drivers/acpi/processor_perflib.c | |||
| @@ -465,7 +465,7 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr) | |||
| 465 | return result; | 465 | return result; |
| 466 | } | 466 | } |
| 467 | 467 | ||
| 468 | static int acpi_processor_get_performance_info(struct acpi_processor *pr) | 468 | int acpi_processor_get_performance_info(struct acpi_processor *pr) |
| 469 | { | 469 | { |
| 470 | int result = 0; | 470 | int result = 0; |
| 471 | acpi_status status = AE_OK; | 471 | acpi_status status = AE_OK; |
| @@ -509,7 +509,7 @@ static int acpi_processor_get_performance_info(struct acpi_processor *pr) | |||
| 509 | #endif | 509 | #endif |
| 510 | return result; | 510 | return result; |
| 511 | } | 511 | } |
| 512 | 512 | EXPORT_SYMBOL_GPL(acpi_processor_get_performance_info); | |
| 513 | int acpi_processor_notify_smm(struct module *calling_module) | 513 | int acpi_processor_notify_smm(struct module *calling_module) |
| 514 | { | 514 | { |
| 515 | acpi_status status; | 515 | acpi_status status; |
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c index 10fd71ccf587..6bf4d47324eb 100644 --- a/drivers/char/hw_random/virtio-rng.c +++ b/drivers/char/hw_random/virtio-rng.c | |||
| @@ -92,14 +92,22 @@ static int probe_common(struct virtio_device *vdev) | |||
| 92 | { | 92 | { |
| 93 | int err; | 93 | int err; |
| 94 | 94 | ||
| 95 | if (vq) { | ||
| 96 | /* We only support one device for now */ | ||
| 97 | return -EBUSY; | ||
| 98 | } | ||
| 95 | /* We expect a single virtqueue. */ | 99 | /* We expect a single virtqueue. */ |
| 96 | vq = virtio_find_single_vq(vdev, random_recv_done, "input"); | 100 | vq = virtio_find_single_vq(vdev, random_recv_done, "input"); |
| 97 | if (IS_ERR(vq)) | 101 | if (IS_ERR(vq)) { |
| 98 | return PTR_ERR(vq); | 102 | err = PTR_ERR(vq); |
| 103 | vq = NULL; | ||
| 104 | return err; | ||
| 105 | } | ||
| 99 | 106 | ||
| 100 | err = hwrng_register(&virtio_hwrng); | 107 | err = hwrng_register(&virtio_hwrng); |
| 101 | if (err) { | 108 | if (err) { |
| 102 | vdev->config->del_vqs(vdev); | 109 | vdev->config->del_vqs(vdev); |
| 110 | vq = NULL; | ||
| 103 | return err; | 111 | return err; |
| 104 | } | 112 | } |
| 105 | 113 | ||
| @@ -112,6 +120,7 @@ static void remove_common(struct virtio_device *vdev) | |||
| 112 | busy = false; | 120 | busy = false; |
| 113 | hwrng_unregister(&virtio_hwrng); | 121 | hwrng_unregister(&virtio_hwrng); |
| 114 | vdev->config->del_vqs(vdev); | 122 | vdev->config->del_vqs(vdev); |
| 123 | vq = NULL; | ||
| 115 | } | 124 | } |
| 116 | 125 | ||
| 117 | static int virtrng_probe(struct virtio_device *vdev) | 126 | static int virtrng_probe(struct virtio_device *vdev) |
diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 143ce1f899ad..1e2de7305362 100644 --- a/drivers/clk/tegra/clk-tegra20.c +++ b/drivers/clk/tegra/clk-tegra20.c | |||
| @@ -1292,7 +1292,6 @@ static struct tegra_clk_duplicate tegra_clk_duplicates[] = { | |||
| 1292 | TEGRA_CLK_DUPLICATE(usbd, "tegra-ehci.0", NULL), | 1292 | TEGRA_CLK_DUPLICATE(usbd, "tegra-ehci.0", NULL), |
| 1293 | TEGRA_CLK_DUPLICATE(usbd, "tegra-otg", NULL), | 1293 | TEGRA_CLK_DUPLICATE(usbd, "tegra-otg", NULL), |
| 1294 | TEGRA_CLK_DUPLICATE(cclk, NULL, "cpu"), | 1294 | TEGRA_CLK_DUPLICATE(cclk, NULL, "cpu"), |
| 1295 | TEGRA_CLK_DUPLICATE(twd, "smp_twd", NULL), | ||
| 1296 | TEGRA_CLK_DUPLICATE(clk_max, NULL, NULL), /* Must be the last entry */ | 1295 | TEGRA_CLK_DUPLICATE(clk_max, NULL, NULL), /* Must be the last entry */ |
| 1297 | }; | 1296 | }; |
| 1298 | 1297 | ||
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c index 32c61cb6d0bb..ba6f51bc9f3b 100644 --- a/drivers/clk/tegra/clk-tegra30.c +++ b/drivers/clk/tegra/clk-tegra30.c | |||
| @@ -1931,7 +1931,6 @@ static struct tegra_clk_duplicate tegra_clk_duplicates[] = { | |||
| 1931 | TEGRA_CLK_DUPLICATE(cml1, "tegra_sata_cml", NULL), | 1931 | TEGRA_CLK_DUPLICATE(cml1, "tegra_sata_cml", NULL), |
| 1932 | TEGRA_CLK_DUPLICATE(cml0, "tegra_pcie", "cml"), | 1932 | TEGRA_CLK_DUPLICATE(cml0, "tegra_pcie", "cml"), |
| 1933 | TEGRA_CLK_DUPLICATE(pciex, "tegra_pcie", "pciex"), | 1933 | TEGRA_CLK_DUPLICATE(pciex, "tegra_pcie", "pciex"), |
| 1934 | TEGRA_CLK_DUPLICATE(twd, "smp_twd", NULL), | ||
| 1935 | TEGRA_CLK_DUPLICATE(vcp, "nvavp", "vcp"), | 1934 | TEGRA_CLK_DUPLICATE(vcp, "nvavp", "vcp"), |
| 1936 | TEGRA_CLK_DUPLICATE(clk_max, NULL, NULL), /* MUST be the last entry */ | 1935 | TEGRA_CLK_DUPLICATE(clk_max, NULL, NULL), /* MUST be the last entry */ |
| 1937 | }; | 1936 | }; |
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 7472182967ce..61a6fde6c089 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c | |||
| @@ -42,6 +42,7 @@ | |||
| 42 | #include <linux/io.h> | 42 | #include <linux/io.h> |
| 43 | #include <linux/of_irq.h> | 43 | #include <linux/of_irq.h> |
| 44 | #include <linux/of_device.h> | 44 | #include <linux/of_device.h> |
| 45 | #include <linux/clk.h> | ||
| 45 | #include <linux/pinctrl/consumer.h> | 46 | #include <linux/pinctrl/consumer.h> |
| 46 | 47 | ||
| 47 | /* | 48 | /* |
| @@ -496,6 +497,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) | |||
| 496 | struct resource *res; | 497 | struct resource *res; |
| 497 | struct irq_chip_generic *gc; | 498 | struct irq_chip_generic *gc; |
| 498 | struct irq_chip_type *ct; | 499 | struct irq_chip_type *ct; |
| 500 | struct clk *clk; | ||
| 499 | unsigned int ngpios; | 501 | unsigned int ngpios; |
| 500 | int soc_variant; | 502 | int soc_variant; |
| 501 | int i, cpu, id; | 503 | int i, cpu, id; |
| @@ -529,6 +531,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev) | |||
| 529 | return id; | 531 | return id; |
| 530 | } | 532 | } |
| 531 | 533 | ||
| 534 | clk = devm_clk_get(&pdev->dev, NULL); | ||
| 535 | /* Not all SoCs require a clock.*/ | ||
| 536 | if (!IS_ERR(clk)) | ||
| 537 | clk_prepare_enable(clk); | ||
| 538 | |||
| 532 | mvchip->soc_variant = soc_variant; | 539 | mvchip->soc_variant = soc_variant; |
| 533 | mvchip->chip.label = dev_name(&pdev->dev); | 540 | mvchip->chip.label = dev_name(&pdev->dev); |
| 534 | mvchip->chip.dev = &pdev->dev; | 541 | mvchip->chip.dev = &pdev->dev; |
diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c index 5fa13267bd9f..02e369f80449 100644 --- a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c | |||
| @@ -544,13 +544,13 @@ nv50_disp_curs_ofuncs = { | |||
| 544 | static void | 544 | static void |
| 545 | nv50_disp_base_vblank_enable(struct nouveau_event *event, int head) | 545 | nv50_disp_base_vblank_enable(struct nouveau_event *event, int head) |
| 546 | { | 546 | { |
| 547 | nv_mask(event->priv, 0x61002c, (1 << head), (1 << head)); | 547 | nv_mask(event->priv, 0x61002c, (4 << head), (4 << head)); |
| 548 | } | 548 | } |
| 549 | 549 | ||
| 550 | static void | 550 | static void |
| 551 | nv50_disp_base_vblank_disable(struct nouveau_event *event, int head) | 551 | nv50_disp_base_vblank_disable(struct nouveau_event *event, int head) |
| 552 | { | 552 | { |
| 553 | nv_mask(event->priv, 0x61002c, (1 << head), (0 << head)); | 553 | nv_mask(event->priv, 0x61002c, (4 << head), 0); |
| 554 | } | 554 | } |
| 555 | 555 | ||
| 556 | static int | 556 | static int |
diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index 41241922263f..3b6dc883e150 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c | |||
| @@ -116,6 +116,11 @@ nouveau_abi16_chan_fini(struct nouveau_abi16 *abi16, | |||
| 116 | { | 116 | { |
| 117 | struct nouveau_abi16_ntfy *ntfy, *temp; | 117 | struct nouveau_abi16_ntfy *ntfy, *temp; |
| 118 | 118 | ||
| 119 | /* wait for all activity to stop before releasing notify object, which | ||
| 120 | * may be still in use */ | ||
| 121 | if (chan->chan && chan->ntfy) | ||
| 122 | nouveau_channel_idle(chan->chan); | ||
| 123 | |||
| 119 | /* cleanup notifier state */ | 124 | /* cleanup notifier state */ |
| 120 | list_for_each_entry_safe(ntfy, temp, &chan->notifiers, head) { | 125 | list_for_each_entry_safe(ntfy, temp, &chan->notifiers, head) { |
| 121 | nouveau_abi16_ntfy_fini(chan, ntfy); | 126 | nouveau_abi16_ntfy_fini(chan, ntfy); |
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 11ca82148edc..7ff10711a4d0 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c | |||
| @@ -801,7 +801,7 @@ nv50_bo_move_m2mf(struct nouveau_channel *chan, struct ttm_buffer_object *bo, | |||
| 801 | stride = 16 * 4; | 801 | stride = 16 * 4; |
| 802 | height = amount / stride; | 802 | height = amount / stride; |
| 803 | 803 | ||
| 804 | if (new_mem->mem_type == TTM_PL_VRAM && | 804 | if (old_mem->mem_type == TTM_PL_VRAM && |
| 805 | nouveau_bo_tile_layout(nvbo)) { | 805 | nouveau_bo_tile_layout(nvbo)) { |
| 806 | ret = RING_SPACE(chan, 8); | 806 | ret = RING_SPACE(chan, 8); |
| 807 | if (ret) | 807 | if (ret) |
| @@ -823,7 +823,7 @@ nv50_bo_move_m2mf(struct nouveau_channel *chan, struct ttm_buffer_object *bo, | |||
| 823 | BEGIN_NV04(chan, NvSubCopy, 0x0200, 1); | 823 | BEGIN_NV04(chan, NvSubCopy, 0x0200, 1); |
| 824 | OUT_RING (chan, 1); | 824 | OUT_RING (chan, 1); |
| 825 | } | 825 | } |
| 826 | if (old_mem->mem_type == TTM_PL_VRAM && | 826 | if (new_mem->mem_type == TTM_PL_VRAM && |
| 827 | nouveau_bo_tile_layout(nvbo)) { | 827 | nouveau_bo_tile_layout(nvbo)) { |
| 828 | ret = RING_SPACE(chan, 8); | 828 | ret = RING_SPACE(chan, 8); |
| 829 | if (ret) | 829 | if (ret) |
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 87a5a56ed358..2db57990f65c 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c | |||
| @@ -2276,6 +2276,7 @@ nv50_display_create(struct drm_device *dev) | |||
| 2276 | NV_WARN(drm, "failed to create encoder %d/%d/%d: %d\n", | 2276 | NV_WARN(drm, "failed to create encoder %d/%d/%d: %d\n", |
| 2277 | dcbe->location, dcbe->type, | 2277 | dcbe->location, dcbe->type, |
| 2278 | ffs(dcbe->or) - 1, ret); | 2278 | ffs(dcbe->or) - 1, ret); |
| 2279 | ret = 0; | ||
| 2279 | } | 2280 | } |
| 2280 | } | 2281 | } |
| 2281 | 2282 | ||
diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c index 41df29f59b0e..ebbb9f4f27a3 100644 --- a/drivers/hwmon/lineage-pem.c +++ b/drivers/hwmon/lineage-pem.c | |||
| @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = { | |||
| 422 | &sensor_dev_attr_in2_input.dev_attr.attr, | 422 | &sensor_dev_attr_in2_input.dev_attr.attr, |
| 423 | &sensor_dev_attr_curr1_input.dev_attr.attr, | 423 | &sensor_dev_attr_curr1_input.dev_attr.attr, |
| 424 | &sensor_dev_attr_power1_input.dev_attr.attr, | 424 | &sensor_dev_attr_power1_input.dev_attr.attr, |
| 425 | NULL | ||
| 425 | }; | 426 | }; |
| 426 | 427 | ||
| 427 | static const struct attribute_group pem_input_group = { | 428 | static const struct attribute_group pem_input_group = { |
| @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = { | |||
| 432 | &sensor_dev_attr_fan1_input.dev_attr.attr, | 433 | &sensor_dev_attr_fan1_input.dev_attr.attr, |
| 433 | &sensor_dev_attr_fan2_input.dev_attr.attr, | 434 | &sensor_dev_attr_fan2_input.dev_attr.attr, |
| 434 | &sensor_dev_attr_fan3_input.dev_attr.attr, | 435 | &sensor_dev_attr_fan3_input.dev_attr.attr, |
| 436 | NULL | ||
| 435 | }; | 437 | }; |
| 436 | 438 | ||
| 437 | static const struct attribute_group pem_fan_group = { | 439 | static const struct attribute_group pem_fan_group = { |
diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c index a58de38e23d8..6d6130752f94 100644 --- a/drivers/hwmon/pmbus/ltc2978.c +++ b/drivers/hwmon/pmbus/ltc2978.c | |||
| @@ -59,7 +59,7 @@ enum chips { ltc2978, ltc3880 }; | |||
| 59 | struct ltc2978_data { | 59 | struct ltc2978_data { |
| 60 | enum chips id; | 60 | enum chips id; |
| 61 | int vin_min, vin_max; | 61 | int vin_min, vin_max; |
| 62 | int temp_min, temp_max; | 62 | int temp_min, temp_max[2]; |
| 63 | int vout_min[8], vout_max[8]; | 63 | int vout_min[8], vout_max[8]; |
| 64 | int iout_max[2]; | 64 | int iout_max[2]; |
| 65 | int temp2_max; | 65 | int temp2_max; |
| @@ -113,9 +113,10 @@ static int ltc2978_read_word_data_common(struct i2c_client *client, int page, | |||
| 113 | ret = pmbus_read_word_data(client, page, | 113 | ret = pmbus_read_word_data(client, page, |
| 114 | LTC2978_MFR_TEMPERATURE_PEAK); | 114 | LTC2978_MFR_TEMPERATURE_PEAK); |
| 115 | if (ret >= 0) { | 115 | if (ret >= 0) { |
| 116 | if (lin11_to_val(ret) > lin11_to_val(data->temp_max)) | 116 | if (lin11_to_val(ret) |
| 117 | data->temp_max = ret; | 117 | > lin11_to_val(data->temp_max[page])) |
| 118 | ret = data->temp_max; | 118 | data->temp_max[page] = ret; |
| 119 | ret = data->temp_max[page]; | ||
| 119 | } | 120 | } |
| 120 | break; | 121 | break; |
| 121 | case PMBUS_VIRT_RESET_VOUT_HISTORY: | 122 | case PMBUS_VIRT_RESET_VOUT_HISTORY: |
| @@ -266,7 +267,7 @@ static int ltc2978_write_word_data(struct i2c_client *client, int page, | |||
| 266 | break; | 267 | break; |
| 267 | case PMBUS_VIRT_RESET_TEMP_HISTORY: | 268 | case PMBUS_VIRT_RESET_TEMP_HISTORY: |
| 268 | data->temp_min = 0x7bff; | 269 | data->temp_min = 0x7bff; |
| 269 | data->temp_max = 0x7c00; | 270 | data->temp_max[page] = 0x7c00; |
| 270 | ret = ltc2978_clear_peaks(client, page, data->id); | 271 | ret = ltc2978_clear_peaks(client, page, data->id); |
| 271 | break; | 272 | break; |
| 272 | default: | 273 | default: |
| @@ -323,7 +324,8 @@ static int ltc2978_probe(struct i2c_client *client, | |||
| 323 | data->vin_min = 0x7bff; | 324 | data->vin_min = 0x7bff; |
| 324 | data->vin_max = 0x7c00; | 325 | data->vin_max = 0x7c00; |
| 325 | data->temp_min = 0x7bff; | 326 | data->temp_min = 0x7bff; |
| 326 | data->temp_max = 0x7c00; | 327 | for (i = 0; i < ARRAY_SIZE(data->temp_max); i++) |
| 328 | data->temp_max[i] = 0x7c00; | ||
| 327 | data->temp2_max = 0x7c00; | 329 | data->temp2_max = 0x7c00; |
| 328 | 330 | ||
| 329 | switch (data->id) { | 331 | switch (data->id) { |
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 80eef50c50fd..9add60920ac0 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c | |||
| @@ -766,12 +766,14 @@ static ssize_t pmbus_show_label(struct device *dev, | |||
| 766 | static int pmbus_add_attribute(struct pmbus_data *data, struct attribute *attr) | 766 | static int pmbus_add_attribute(struct pmbus_data *data, struct attribute *attr) |
| 767 | { | 767 | { |
| 768 | if (data->num_attributes >= data->max_attributes - 1) { | 768 | if (data->num_attributes >= data->max_attributes - 1) { |
| 769 | data->max_attributes += PMBUS_ATTR_ALLOC_SIZE; | 769 | int new_max_attrs = data->max_attributes + PMBUS_ATTR_ALLOC_SIZE; |
| 770 | data->group.attrs = krealloc(data->group.attrs, | 770 | void *new_attrs = krealloc(data->group.attrs, |
| 771 | sizeof(struct attribute *) * | 771 | new_max_attrs * sizeof(void *), |
| 772 | data->max_attributes, GFP_KERNEL); | 772 | GFP_KERNEL); |
| 773 | if (data->group.attrs == NULL) | 773 | if (!new_attrs) |
| 774 | return -ENOMEM; | 774 | return -ENOMEM; |
| 775 | data->group.attrs = new_attrs; | ||
| 776 | data->max_attributes = new_max_attrs; | ||
| 775 | } | 777 | } |
| 776 | 778 | ||
| 777 | data->group.attrs[data->num_attributes++] = attr; | 779 | data->group.attrs[data->num_attributes++] = attr; |
diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c index 0198324a8b0c..bd33473f8e38 100644 --- a/drivers/iio/common/st_sensors/st_sensors_core.c +++ b/drivers/iio/common/st_sensors/st_sensors_core.c | |||
| @@ -62,7 +62,7 @@ st_sensors_match_odr_error: | |||
| 62 | int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr) | 62 | int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr) |
| 63 | { | 63 | { |
| 64 | int err; | 64 | int err; |
| 65 | struct st_sensor_odr_avl odr_out; | 65 | struct st_sensor_odr_avl odr_out = {0, 0}; |
| 66 | struct st_sensor_data *sdata = iio_priv(indio_dev); | 66 | struct st_sensor_data *sdata = iio_priv(indio_dev); |
| 67 | 67 | ||
| 68 | err = st_sensors_match_odr(sdata->sensor, odr, &odr_out); | 68 | err = st_sensors_match_odr(sdata->sensor, odr, &odr_out); |
| @@ -114,7 +114,7 @@ st_sensors_match_odr_error: | |||
| 114 | 114 | ||
| 115 | static int st_sensors_set_fullscale(struct iio_dev *indio_dev, unsigned int fs) | 115 | static int st_sensors_set_fullscale(struct iio_dev *indio_dev, unsigned int fs) |
| 116 | { | 116 | { |
| 117 | int err, i; | 117 | int err, i = 0; |
| 118 | struct st_sensor_data *sdata = iio_priv(indio_dev); | 118 | struct st_sensor_data *sdata = iio_priv(indio_dev); |
| 119 | 119 | ||
| 120 | err = st_sensors_match_fs(sdata->sensor, fs, &i); | 120 | err = st_sensors_match_fs(sdata->sensor, fs, &i); |
| @@ -139,14 +139,13 @@ st_accel_set_fullscale_error: | |||
| 139 | 139 | ||
| 140 | int st_sensors_set_enable(struct iio_dev *indio_dev, bool enable) | 140 | int st_sensors_set_enable(struct iio_dev *indio_dev, bool enable) |
| 141 | { | 141 | { |
| 142 | bool found; | ||
| 143 | u8 tmp_value; | 142 | u8 tmp_value; |
| 144 | int err = -EINVAL; | 143 | int err = -EINVAL; |
| 145 | struct st_sensor_odr_avl odr_out; | 144 | bool found = false; |
| 145 | struct st_sensor_odr_avl odr_out = {0, 0}; | ||
| 146 | struct st_sensor_data *sdata = iio_priv(indio_dev); | 146 | struct st_sensor_data *sdata = iio_priv(indio_dev); |
| 147 | 147 | ||
| 148 | if (enable) { | 148 | if (enable) { |
| 149 | found = false; | ||
| 150 | tmp_value = sdata->sensor->pw.value_on; | 149 | tmp_value = sdata->sensor->pw.value_on; |
| 151 | if ((sdata->sensor->odr.addr == sdata->sensor->pw.addr) && | 150 | if ((sdata->sensor->odr.addr == sdata->sensor->pw.addr) && |
| 152 | (sdata->sensor->odr.mask == sdata->sensor->pw.mask)) { | 151 | (sdata->sensor->odr.mask == sdata->sensor->pw.mask)) { |
diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c index 2fe1d4edcb2f..74f2d52795f6 100644 --- a/drivers/iio/dac/ad5064.c +++ b/drivers/iio/dac/ad5064.c | |||
| @@ -27,7 +27,6 @@ | |||
| 27 | #define AD5064_ADDR(x) ((x) << 20) | 27 | #define AD5064_ADDR(x) ((x) << 20) |
| 28 | #define AD5064_CMD(x) ((x) << 24) | 28 | #define AD5064_CMD(x) ((x) << 24) |
| 29 | 29 | ||
| 30 | #define AD5064_ADDR_DAC(chan) (chan) | ||
| 31 | #define AD5064_ADDR_ALL_DAC 0xF | 30 | #define AD5064_ADDR_ALL_DAC 0xF |
| 32 | 31 | ||
| 33 | #define AD5064_CMD_WRITE_INPUT_N 0x0 | 32 | #define AD5064_CMD_WRITE_INPUT_N 0x0 |
| @@ -131,15 +130,15 @@ static int ad5064_write(struct ad5064_state *st, unsigned int cmd, | |||
| 131 | } | 130 | } |
| 132 | 131 | ||
| 133 | static int ad5064_sync_powerdown_mode(struct ad5064_state *st, | 132 | static int ad5064_sync_powerdown_mode(struct ad5064_state *st, |
| 134 | unsigned int channel) | 133 | const struct iio_chan_spec *chan) |
| 135 | { | 134 | { |
| 136 | unsigned int val; | 135 | unsigned int val; |
| 137 | int ret; | 136 | int ret; |
| 138 | 137 | ||
| 139 | val = (0x1 << channel); | 138 | val = (0x1 << chan->address); |
| 140 | 139 | ||
| 141 | if (st->pwr_down[channel]) | 140 | if (st->pwr_down[chan->channel]) |
| 142 | val |= st->pwr_down_mode[channel] << 8; | 141 | val |= st->pwr_down_mode[chan->channel] << 8; |
| 143 | 142 | ||
| 144 | ret = ad5064_write(st, AD5064_CMD_POWERDOWN_DAC, 0, val, 0); | 143 | ret = ad5064_write(st, AD5064_CMD_POWERDOWN_DAC, 0, val, 0); |
| 145 | 144 | ||
| @@ -169,7 +168,7 @@ static int ad5064_set_powerdown_mode(struct iio_dev *indio_dev, | |||
| 169 | mutex_lock(&indio_dev->mlock); | 168 | mutex_lock(&indio_dev->mlock); |
| 170 | st->pwr_down_mode[chan->channel] = mode + 1; | 169 | st->pwr_down_mode[chan->channel] = mode + 1; |
| 171 | 170 | ||
| 172 | ret = ad5064_sync_powerdown_mode(st, chan->channel); | 171 | ret = ad5064_sync_powerdown_mode(st, chan); |
| 173 | mutex_unlock(&indio_dev->mlock); | 172 | mutex_unlock(&indio_dev->mlock); |
| 174 | 173 | ||
| 175 | return ret; | 174 | return ret; |
| @@ -205,7 +204,7 @@ static ssize_t ad5064_write_dac_powerdown(struct iio_dev *indio_dev, | |||
| 205 | mutex_lock(&indio_dev->mlock); | 204 | mutex_lock(&indio_dev->mlock); |
| 206 | st->pwr_down[chan->channel] = pwr_down; | 205 | st->pwr_down[chan->channel] = pwr_down; |
| 207 | 206 | ||
| 208 | ret = ad5064_sync_powerdown_mode(st, chan->channel); | 207 | ret = ad5064_sync_powerdown_mode(st, chan); |
| 209 | mutex_unlock(&indio_dev->mlock); | 208 | mutex_unlock(&indio_dev->mlock); |
| 210 | return ret ? ret : len; | 209 | return ret ? ret : len; |
| 211 | } | 210 | } |
| @@ -258,7 +257,7 @@ static int ad5064_write_raw(struct iio_dev *indio_dev, | |||
| 258 | 257 | ||
| 259 | switch (mask) { | 258 | switch (mask) { |
| 260 | case IIO_CHAN_INFO_RAW: | 259 | case IIO_CHAN_INFO_RAW: |
| 261 | if (val > (1 << chan->scan_type.realbits) || val < 0) | 260 | if (val >= (1 << chan->scan_type.realbits) || val < 0) |
| 262 | return -EINVAL; | 261 | return -EINVAL; |
| 263 | 262 | ||
| 264 | mutex_lock(&indio_dev->mlock); | 263 | mutex_lock(&indio_dev->mlock); |
| @@ -292,34 +291,44 @@ static const struct iio_chan_spec_ext_info ad5064_ext_info[] = { | |||
| 292 | { }, | 291 | { }, |
| 293 | }; | 292 | }; |
| 294 | 293 | ||
| 295 | #define AD5064_CHANNEL(chan, bits) { \ | 294 | #define AD5064_CHANNEL(chan, addr, bits) { \ |
| 296 | .type = IIO_VOLTAGE, \ | 295 | .type = IIO_VOLTAGE, \ |
| 297 | .indexed = 1, \ | 296 | .indexed = 1, \ |
| 298 | .output = 1, \ | 297 | .output = 1, \ |
| 299 | .channel = (chan), \ | 298 | .channel = (chan), \ |
| 300 | .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \ | 299 | .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \ |
| 301 | IIO_CHAN_INFO_SCALE_SEPARATE_BIT, \ | 300 | IIO_CHAN_INFO_SCALE_SEPARATE_BIT, \ |
| 302 | .address = AD5064_ADDR_DAC(chan), \ | 301 | .address = addr, \ |
| 303 | .scan_type = IIO_ST('u', (bits), 16, 20 - (bits)), \ | 302 | .scan_type = IIO_ST('u', (bits), 16, 20 - (bits)), \ |
| 304 | .ext_info = ad5064_ext_info, \ | 303 | .ext_info = ad5064_ext_info, \ |
| 305 | } | 304 | } |
| 306 | 305 | ||
| 307 | #define DECLARE_AD5064_CHANNELS(name, bits) \ | 306 | #define DECLARE_AD5064_CHANNELS(name, bits) \ |
| 308 | const struct iio_chan_spec name[] = { \ | 307 | const struct iio_chan_spec name[] = { \ |
| 309 | AD5064_CHANNEL(0, bits), \ | 308 | AD5064_CHANNEL(0, 0, bits), \ |
| 310 | AD5064_CHANNEL(1, bits), \ | 309 | AD5064_CHANNEL(1, 1, bits), \ |
| 311 | AD5064_CHANNEL(2, bits), \ | 310 | AD5064_CHANNEL(2, 2, bits), \ |
| 312 | AD5064_CHANNEL(3, bits), \ | 311 | AD5064_CHANNEL(3, 3, bits), \ |
| 313 | AD5064_CHANNEL(4, bits), \ | 312 | AD5064_CHANNEL(4, 4, bits), \ |
| 314 | AD5064_CHANNEL(5, bits), \ | 313 | AD5064_CHANNEL(5, 5, bits), \ |
| 315 | AD5064_CHANNEL(6, bits), \ | 314 | AD5064_CHANNEL(6, 6, bits), \ |
| 316 | AD5064_CHANNEL(7, bits), \ | 315 | AD5064_CHANNEL(7, 7, bits), \ |
| 316 | } | ||
| 317 | |||
| 318 | #define DECLARE_AD5065_CHANNELS(name, bits) \ | ||
| 319 | const struct iio_chan_spec name[] = { \ | ||
| 320 | AD5064_CHANNEL(0, 0, bits), \ | ||
| 321 | AD5064_CHANNEL(1, 3, bits), \ | ||
| 317 | } | 322 | } |
| 318 | 323 | ||
| 319 | static DECLARE_AD5064_CHANNELS(ad5024_channels, 12); | 324 | static DECLARE_AD5064_CHANNELS(ad5024_channels, 12); |
| 320 | static DECLARE_AD5064_CHANNELS(ad5044_channels, 14); | 325 | static DECLARE_AD5064_CHANNELS(ad5044_channels, 14); |
| 321 | static DECLARE_AD5064_CHANNELS(ad5064_channels, 16); | 326 | static DECLARE_AD5064_CHANNELS(ad5064_channels, 16); |
| 322 | 327 | ||
| 328 | static DECLARE_AD5065_CHANNELS(ad5025_channels, 12); | ||
| 329 | static DECLARE_AD5065_CHANNELS(ad5045_channels, 14); | ||
| 330 | static DECLARE_AD5065_CHANNELS(ad5065_channels, 16); | ||
| 331 | |||
| 323 | static const struct ad5064_chip_info ad5064_chip_info_tbl[] = { | 332 | static const struct ad5064_chip_info ad5064_chip_info_tbl[] = { |
| 324 | [ID_AD5024] = { | 333 | [ID_AD5024] = { |
| 325 | .shared_vref = false, | 334 | .shared_vref = false, |
| @@ -328,7 +337,7 @@ static const struct ad5064_chip_info ad5064_chip_info_tbl[] = { | |||
| 328 | }, | 337 | }, |
| 329 | [ID_AD5025] = { | 338 | [ID_AD5025] = { |
| 330 | .shared_vref = false, | 339 | .shared_vref = false, |
| 331 | .channels = ad5024_channels, | 340 | .channels = ad5025_channels, |
| 332 | .num_channels = 2, | 341 | .num_channels = 2, |
| 333 | }, | 342 | }, |
| 334 | [ID_AD5044] = { | 343 | [ID_AD5044] = { |
| @@ -338,7 +347,7 @@ static const struct ad5064_chip_info ad5064_chip_info_tbl[] = { | |||
| 338 | }, | 347 | }, |
| 339 | [ID_AD5045] = { | 348 | [ID_AD5045] = { |
| 340 | .shared_vref = false, | 349 | .shared_vref = false, |
| 341 | .channels = ad5044_channels, | 350 | .channels = ad5045_channels, |
| 342 | .num_channels = 2, | 351 | .num_channels = 2, |
| 343 | }, | 352 | }, |
| 344 | [ID_AD5064] = { | 353 | [ID_AD5064] = { |
| @@ -353,7 +362,7 @@ static const struct ad5064_chip_info ad5064_chip_info_tbl[] = { | |||
| 353 | }, | 362 | }, |
| 354 | [ID_AD5065] = { | 363 | [ID_AD5065] = { |
| 355 | .shared_vref = false, | 364 | .shared_vref = false, |
| 356 | .channels = ad5064_channels, | 365 | .channels = ad5065_channels, |
| 357 | .num_channels = 2, | 366 | .num_channels = 2, |
| 358 | }, | 367 | }, |
| 359 | [ID_AD5628_1] = { | 368 | [ID_AD5628_1] = { |
| @@ -429,6 +438,7 @@ static int ad5064_probe(struct device *dev, enum ad5064_type type, | |||
| 429 | { | 438 | { |
| 430 | struct iio_dev *indio_dev; | 439 | struct iio_dev *indio_dev; |
| 431 | struct ad5064_state *st; | 440 | struct ad5064_state *st; |
| 441 | unsigned int midscale; | ||
| 432 | unsigned int i; | 442 | unsigned int i; |
| 433 | int ret; | 443 | int ret; |
| 434 | 444 | ||
| @@ -465,11 +475,6 @@ static int ad5064_probe(struct device *dev, enum ad5064_type type, | |||
| 465 | goto error_free_reg; | 475 | goto error_free_reg; |
| 466 | } | 476 | } |
| 467 | 477 | ||
| 468 | for (i = 0; i < st->chip_info->num_channels; ++i) { | ||
| 469 | st->pwr_down_mode[i] = AD5064_LDAC_PWRDN_1K; | ||
| 470 | st->dac_cache[i] = 0x8000; | ||
| 471 | } | ||
| 472 | |||
| 473 | indio_dev->dev.parent = dev; | 478 | indio_dev->dev.parent = dev; |
| 474 | indio_dev->name = name; | 479 | indio_dev->name = name; |
| 475 | indio_dev->info = &ad5064_info; | 480 | indio_dev->info = &ad5064_info; |
| @@ -477,6 +482,13 @@ static int ad5064_probe(struct device *dev, enum ad5064_type type, | |||
| 477 | indio_dev->channels = st->chip_info->channels; | 482 | indio_dev->channels = st->chip_info->channels; |
| 478 | indio_dev->num_channels = st->chip_info->num_channels; | 483 | indio_dev->num_channels = st->chip_info->num_channels; |
| 479 | 484 | ||
| 485 | midscale = (1 << indio_dev->channels[0].scan_type.realbits) / 2; | ||
| 486 | |||
| 487 | for (i = 0; i < st->chip_info->num_channels; ++i) { | ||
| 488 | st->pwr_down_mode[i] = AD5064_LDAC_PWRDN_1K; | ||
| 489 | st->dac_cache[i] = midscale; | ||
| 490 | } | ||
| 491 | |||
| 480 | ret = iio_device_register(indio_dev); | 492 | ret = iio_device_register(indio_dev); |
| 481 | if (ret) | 493 | if (ret) |
| 482 | goto error_disable_reg; | 494 | goto error_disable_reg; |
diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig index b5cfa3a354cf..361b2328453d 100644 --- a/drivers/iio/imu/inv_mpu6050/Kconfig +++ b/drivers/iio/imu/inv_mpu6050/Kconfig | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | config INV_MPU6050_IIO | 5 | config INV_MPU6050_IIO |
| 6 | tristate "Invensense MPU6050 devices" | 6 | tristate "Invensense MPU6050 devices" |
| 7 | depends on I2C && SYSFS | 7 | depends on I2C && SYSFS |
| 8 | select IIO_BUFFER | ||
| 8 | select IIO_TRIGGERED_BUFFER | 9 | select IIO_TRIGGERED_BUFFER |
| 9 | help | 10 | help |
| 10 | This driver supports the Invensense MPU6050 devices. | 11 | This driver supports the Invensense MPU6050 devices. |
diff --git a/drivers/infiniband/hw/mlx4/cm.c b/drivers/infiniband/hw/mlx4/cm.c index e0d79b2395e4..add98d01476c 100644 --- a/drivers/infiniband/hw/mlx4/cm.c +++ b/drivers/infiniband/hw/mlx4/cm.c | |||
| @@ -362,7 +362,6 @@ void mlx4_ib_cm_paravirt_init(struct mlx4_ib_dev *dev) | |||
| 362 | INIT_LIST_HEAD(&dev->sriov.cm_list); | 362 | INIT_LIST_HEAD(&dev->sriov.cm_list); |
| 363 | dev->sriov.sl_id_map = RB_ROOT; | 363 | dev->sriov.sl_id_map = RB_ROOT; |
| 364 | idr_init(&dev->sriov.pv_id_table); | 364 | idr_init(&dev->sriov.pv_id_table); |
| 365 | idr_pre_get(&dev->sriov.pv_id_table, GFP_KERNEL); | ||
| 366 | } | 365 | } |
| 367 | 366 | ||
| 368 | /* slave = -1 ==> all slaves */ | 367 | /* slave = -1 ==> all slaves */ |
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c index 2fb0d76a04c4..208de7cbb7fa 100644 --- a/drivers/input/keyboard/tc3589x-keypad.c +++ b/drivers/input/keyboard/tc3589x-keypad.c | |||
| @@ -70,8 +70,6 @@ | |||
| 70 | #define TC3589x_EVT_INT_CLR 0x2 | 70 | #define TC3589x_EVT_INT_CLR 0x2 |
| 71 | #define TC3589x_KBD_INT_CLR 0x1 | 71 | #define TC3589x_KBD_INT_CLR 0x1 |
| 72 | 72 | ||
| 73 | #define TC3589x_KBD_KEYMAP_SIZE 64 | ||
| 74 | |||
| 75 | /** | 73 | /** |
| 76 | * struct tc_keypad - data structure used by keypad driver | 74 | * struct tc_keypad - data structure used by keypad driver |
| 77 | * @tc3589x: pointer to tc35893 | 75 | * @tc3589x: pointer to tc35893 |
| @@ -88,7 +86,7 @@ struct tc_keypad { | |||
| 88 | const struct tc3589x_keypad_platform_data *board; | 86 | const struct tc3589x_keypad_platform_data *board; |
| 89 | unsigned int krow; | 87 | unsigned int krow; |
| 90 | unsigned int kcol; | 88 | unsigned int kcol; |
| 91 | unsigned short keymap[TC3589x_KBD_KEYMAP_SIZE]; | 89 | unsigned short *keymap; |
| 92 | bool keypad_stopped; | 90 | bool keypad_stopped; |
| 93 | }; | 91 | }; |
| 94 | 92 | ||
| @@ -338,12 +336,14 @@ static int tc3589x_keypad_probe(struct platform_device *pdev) | |||
| 338 | 336 | ||
| 339 | error = matrix_keypad_build_keymap(plat->keymap_data, NULL, | 337 | error = matrix_keypad_build_keymap(plat->keymap_data, NULL, |
| 340 | TC3589x_MAX_KPROW, TC3589x_MAX_KPCOL, | 338 | TC3589x_MAX_KPROW, TC3589x_MAX_KPCOL, |
| 341 | keypad->keymap, input); | 339 | NULL, input); |
| 342 | if (error) { | 340 | if (error) { |
| 343 | dev_err(&pdev->dev, "Failed to build keymap\n"); | 341 | dev_err(&pdev->dev, "Failed to build keymap\n"); |
| 344 | goto err_free_mem; | 342 | goto err_free_mem; |
| 345 | } | 343 | } |
| 346 | 344 | ||
| 345 | keypad->keymap = input->keycode; | ||
| 346 | |||
| 347 | input_set_capability(input, EV_MSC, MSC_SCAN); | 347 | input_set_capability(input, EV_MSC, MSC_SCAN); |
| 348 | if (!plat->no_autorepeat) | 348 | if (!plat->no_autorepeat) |
| 349 | __set_bit(EV_REP, input->evbit); | 349 | __set_bit(EV_REP, input->evbit); |
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 7b99fc7c9438..0238e0e14335 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c | |||
| @@ -490,6 +490,29 @@ static void alps_decode_rushmore(struct alps_fields *f, unsigned char *p) | |||
| 490 | f->y_map |= (p[5] & 0x20) << 6; | 490 | f->y_map |= (p[5] & 0x20) << 6; |
| 491 | } | 491 | } |
| 492 | 492 | ||
| 493 | static void alps_decode_dolphin(struct alps_fields *f, unsigned char *p) | ||
| 494 | { | ||
| 495 | f->first_mp = !!(p[0] & 0x02); | ||
| 496 | f->is_mp = !!(p[0] & 0x20); | ||
| 497 | |||
| 498 | f->fingers = ((p[0] & 0x6) >> 1 | | ||
| 499 | (p[0] & 0x10) >> 2); | ||
| 500 | f->x_map = ((p[2] & 0x60) >> 5) | | ||
| 501 | ((p[4] & 0x7f) << 2) | | ||
| 502 | ((p[5] & 0x7f) << 9) | | ||
| 503 | ((p[3] & 0x07) << 16) | | ||
| 504 | ((p[3] & 0x70) << 15) | | ||
| 505 | ((p[0] & 0x01) << 22); | ||
| 506 | f->y_map = (p[1] & 0x7f) | | ||
| 507 | ((p[2] & 0x1f) << 7); | ||
| 508 | |||
| 509 | f->x = ((p[1] & 0x7f) | ((p[4] & 0x0f) << 7)); | ||
| 510 | f->y = ((p[2] & 0x7f) | ((p[4] & 0xf0) << 3)); | ||
| 511 | f->z = (p[0] & 4) ? 0 : p[5] & 0x7f; | ||
| 512 | |||
| 513 | alps_decode_buttons_v3(f, p); | ||
| 514 | } | ||
| 515 | |||
| 493 | static void alps_process_touchpad_packet_v3(struct psmouse *psmouse) | 516 | static void alps_process_touchpad_packet_v3(struct psmouse *psmouse) |
| 494 | { | 517 | { |
| 495 | struct alps_data *priv = psmouse->private; | 518 | struct alps_data *priv = psmouse->private; |
| @@ -874,7 +897,8 @@ static psmouse_ret_t alps_process_byte(struct psmouse *psmouse) | |||
| 874 | } | 897 | } |
| 875 | 898 | ||
| 876 | /* Bytes 2 - pktsize should have 0 in the highest bit */ | 899 | /* Bytes 2 - pktsize should have 0 in the highest bit */ |
| 877 | if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= psmouse->pktsize && | 900 | if (priv->proto_version != ALPS_PROTO_V5 && |
| 901 | psmouse->pktcnt >= 2 && psmouse->pktcnt <= psmouse->pktsize && | ||
| 878 | (psmouse->packet[psmouse->pktcnt - 1] & 0x80)) { | 902 | (psmouse->packet[psmouse->pktcnt - 1] & 0x80)) { |
| 879 | psmouse_dbg(psmouse, "refusing packet[%i] = %x\n", | 903 | psmouse_dbg(psmouse, "refusing packet[%i] = %x\n", |
| 880 | psmouse->pktcnt - 1, | 904 | psmouse->pktcnt - 1, |
| @@ -994,8 +1018,7 @@ static int alps_rpt_cmd(struct psmouse *psmouse, int init_command, | |||
| 994 | return 0; | 1018 | return 0; |
| 995 | } | 1019 | } |
| 996 | 1020 | ||
| 997 | static int alps_enter_command_mode(struct psmouse *psmouse, | 1021 | static int alps_enter_command_mode(struct psmouse *psmouse) |
| 998 | unsigned char *resp) | ||
| 999 | { | 1022 | { |
| 1000 | unsigned char param[4]; | 1023 | unsigned char param[4]; |
| 1001 | 1024 | ||
| @@ -1004,14 +1027,12 @@ static int alps_enter_command_mode(struct psmouse *psmouse, | |||
| 1004 | return -1; | 1027 | return -1; |
| 1005 | } | 1028 | } |
| 1006 | 1029 | ||
| 1007 | if (param[0] != 0x88 || (param[1] != 0x07 && param[1] != 0x08)) { | 1030 | if ((param[0] != 0x88 || (param[1] != 0x07 && param[1] != 0x08)) && |
| 1031 | param[0] != 0x73) { | ||
| 1008 | psmouse_dbg(psmouse, | 1032 | psmouse_dbg(psmouse, |
| 1009 | "unknown response while entering command mode\n"); | 1033 | "unknown response while entering command mode\n"); |
| 1010 | return -1; | 1034 | return -1; |
| 1011 | } | 1035 | } |
| 1012 | |||
| 1013 | if (resp) | ||
| 1014 | *resp = param[2]; | ||
| 1015 | return 0; | 1036 | return 0; |
| 1016 | } | 1037 | } |
| 1017 | 1038 | ||
| @@ -1176,7 +1197,7 @@ static int alps_passthrough_mode_v3(struct psmouse *psmouse, | |||
| 1176 | { | 1197 | { |
| 1177 | int reg_val, ret = -1; | 1198 | int reg_val, ret = -1; |
| 1178 | 1199 | ||
| 1179 | if (alps_enter_command_mode(psmouse, NULL)) | 1200 | if (alps_enter_command_mode(psmouse)) |
| 1180 | return -1; | 1201 | return -1; |
| 1181 | 1202 | ||
| 1182 | reg_val = alps_command_mode_read_reg(psmouse, reg_base + 0x0008); | 1203 | reg_val = alps_command_mode_read_reg(psmouse, reg_base + 0x0008); |
| @@ -1216,7 +1237,7 @@ static int alps_probe_trackstick_v3(struct psmouse *psmouse, int reg_base) | |||
| 1216 | { | 1237 | { |
| 1217 | int ret = -EIO, reg_val; | 1238 | int ret = -EIO, reg_val; |
| 1218 | 1239 | ||
| 1219 | if (alps_enter_command_mode(psmouse, NULL)) | 1240 | if (alps_enter_command_mode(psmouse)) |
| 1220 | goto error; | 1241 | goto error; |
| 1221 | 1242 | ||
| 1222 | reg_val = alps_command_mode_read_reg(psmouse, reg_base + 0x08); | 1243 | reg_val = alps_command_mode_read_reg(psmouse, reg_base + 0x08); |
| @@ -1279,7 +1300,7 @@ static int alps_setup_trackstick_v3(struct psmouse *psmouse, int reg_base) | |||
| 1279 | * supported by this driver. If bit 1 isn't set the packet | 1300 | * supported by this driver. If bit 1 isn't set the packet |
| 1280 | * format is different. | 1301 | * format is different. |
| 1281 | */ | 1302 | */ |
| 1282 | if (alps_enter_command_mode(psmouse, NULL) || | 1303 | if (alps_enter_command_mode(psmouse) || |
| 1283 | alps_command_mode_write_reg(psmouse, | 1304 | alps_command_mode_write_reg(psmouse, |
| 1284 | reg_base + 0x08, 0x82) || | 1305 | reg_base + 0x08, 0x82) || |
| 1285 | alps_exit_command_mode(psmouse)) | 1306 | alps_exit_command_mode(psmouse)) |
| @@ -1306,7 +1327,7 @@ static int alps_hw_init_v3(struct psmouse *psmouse) | |||
| 1306 | alps_setup_trackstick_v3(psmouse, ALPS_REG_BASE_PINNACLE) == -EIO) | 1327 | alps_setup_trackstick_v3(psmouse, ALPS_REG_BASE_PINNACLE) == -EIO) |
| 1307 | goto error; | 1328 | goto error; |
| 1308 | 1329 | ||
| 1309 | if (alps_enter_command_mode(psmouse, NULL) || | 1330 | if (alps_enter_command_mode(psmouse) || |
| 1310 | alps_absolute_mode_v3(psmouse)) { | 1331 | alps_absolute_mode_v3(psmouse)) { |
| 1311 | psmouse_err(psmouse, "Failed to enter absolute mode\n"); | 1332 | psmouse_err(psmouse, "Failed to enter absolute mode\n"); |
| 1312 | goto error; | 1333 | goto error; |
| @@ -1381,7 +1402,7 @@ static int alps_hw_init_rushmore_v3(struct psmouse *psmouse) | |||
| 1381 | priv->flags &= ~ALPS_DUALPOINT; | 1402 | priv->flags &= ~ALPS_DUALPOINT; |
| 1382 | } | 1403 | } |
| 1383 | 1404 | ||
| 1384 | if (alps_enter_command_mode(psmouse, NULL) || | 1405 | if (alps_enter_command_mode(psmouse) || |
| 1385 | alps_command_mode_read_reg(psmouse, 0xc2d9) == -1 || | 1406 | alps_command_mode_read_reg(psmouse, 0xc2d9) == -1 || |
| 1386 | alps_command_mode_write_reg(psmouse, 0xc2cb, 0x00)) | 1407 | alps_command_mode_write_reg(psmouse, 0xc2cb, 0x00)) |
| 1387 | goto error; | 1408 | goto error; |
| @@ -1431,7 +1452,7 @@ static int alps_hw_init_v4(struct psmouse *psmouse) | |||
| 1431 | struct ps2dev *ps2dev = &psmouse->ps2dev; | 1452 | struct ps2dev *ps2dev = &psmouse->ps2dev; |
| 1432 | unsigned char param[4]; | 1453 | unsigned char param[4]; |
| 1433 | 1454 | ||
| 1434 | if (alps_enter_command_mode(psmouse, NULL)) | 1455 | if (alps_enter_command_mode(psmouse)) |
| 1435 | goto error; | 1456 | goto error; |
| 1436 | 1457 | ||
| 1437 | if (alps_absolute_mode_v4(psmouse)) { | 1458 | if (alps_absolute_mode_v4(psmouse)) { |
| @@ -1499,6 +1520,23 @@ error: | |||
| 1499 | return -1; | 1520 | return -1; |
| 1500 | } | 1521 | } |
| 1501 | 1522 | ||
| 1523 | static int alps_hw_init_dolphin_v1(struct psmouse *psmouse) | ||
| 1524 | { | ||
| 1525 | struct ps2dev *ps2dev = &psmouse->ps2dev; | ||
| 1526 | unsigned char param[2]; | ||
| 1527 | |||
| 1528 | /* This is dolphin "v1" as empirically defined by florin9doi */ | ||
| 1529 | param[0] = 0x64; | ||
| 1530 | param[1] = 0x28; | ||
| 1531 | |||
| 1532 | if (ps2_command(ps2dev, NULL, PSMOUSE_CMD_SETSTREAM) || | ||
| 1533 | ps2_command(ps2dev, ¶m[0], PSMOUSE_CMD_SETRATE) || | ||
| 1534 | ps2_command(ps2dev, ¶m[1], PSMOUSE_CMD_SETRATE)) | ||
| 1535 | return -1; | ||
| 1536 | |||
| 1537 | return 0; | ||
| 1538 | } | ||
| 1539 | |||
| 1502 | static void alps_set_defaults(struct alps_data *priv) | 1540 | static void alps_set_defaults(struct alps_data *priv) |
| 1503 | { | 1541 | { |
| 1504 | priv->byte0 = 0x8f; | 1542 | priv->byte0 = 0x8f; |
| @@ -1532,6 +1570,21 @@ static void alps_set_defaults(struct alps_data *priv) | |||
| 1532 | priv->nibble_commands = alps_v4_nibble_commands; | 1570 | priv->nibble_commands = alps_v4_nibble_commands; |
| 1533 | priv->addr_command = PSMOUSE_CMD_DISABLE; | 1571 | priv->addr_command = PSMOUSE_CMD_DISABLE; |
| 1534 | break; | 1572 | break; |
| 1573 | case ALPS_PROTO_V5: | ||
| 1574 | priv->hw_init = alps_hw_init_dolphin_v1; | ||
| 1575 | priv->process_packet = alps_process_packet_v3; | ||
| 1576 | priv->decode_fields = alps_decode_dolphin; | ||
| 1577 | priv->set_abs_params = alps_set_abs_params_mt; | ||
| 1578 | priv->nibble_commands = alps_v3_nibble_commands; | ||
| 1579 | priv->addr_command = PSMOUSE_CMD_RESET_WRAP; | ||
| 1580 | priv->byte0 = 0xc8; | ||
| 1581 | priv->mask0 = 0xc8; | ||
| 1582 | priv->flags = 0; | ||
| 1583 | priv->x_max = 1360; | ||
| 1584 | priv->y_max = 660; | ||
| 1585 | priv->x_bits = 23; | ||
| 1586 | priv->y_bits = 12; | ||
| 1587 | break; | ||
| 1535 | } | 1588 | } |
| 1536 | } | 1589 | } |
| 1537 | 1590 | ||
| @@ -1592,6 +1645,12 @@ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv) | |||
| 1592 | 1645 | ||
| 1593 | if (alps_match_table(psmouse, priv, e7, ec) == 0) { | 1646 | if (alps_match_table(psmouse, priv, e7, ec) == 0) { |
| 1594 | return 0; | 1647 | return 0; |
| 1648 | } else if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 && | ||
| 1649 | ec[0] == 0x73 && ec[1] == 0x01) { | ||
| 1650 | priv->proto_version = ALPS_PROTO_V5; | ||
| 1651 | alps_set_defaults(priv); | ||
| 1652 | |||
| 1653 | return 0; | ||
| 1595 | } else if (ec[0] == 0x88 && ec[1] == 0x08) { | 1654 | } else if (ec[0] == 0x88 && ec[1] == 0x08) { |
| 1596 | priv->proto_version = ALPS_PROTO_V3; | 1655 | priv->proto_version = ALPS_PROTO_V3; |
| 1597 | alps_set_defaults(priv); | 1656 | alps_set_defaults(priv); |
diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h index 970480551b6e..eee59853b9ce 100644 --- a/drivers/input/mouse/alps.h +++ b/drivers/input/mouse/alps.h | |||
| @@ -16,6 +16,7 @@ | |||
| 16 | #define ALPS_PROTO_V2 2 | 16 | #define ALPS_PROTO_V2 2 |
| 17 | #define ALPS_PROTO_V3 3 | 17 | #define ALPS_PROTO_V3 3 |
| 18 | #define ALPS_PROTO_V4 4 | 18 | #define ALPS_PROTO_V4 4 |
| 19 | #define ALPS_PROTO_V5 5 | ||
| 19 | 20 | ||
| 20 | /** | 21 | /** |
| 21 | * struct alps_model_info - touchpad ID table | 22 | * struct alps_model_info - touchpad ID table |
diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c index 1673dc6c8092..f51765fff054 100644 --- a/drivers/input/mouse/cypress_ps2.c +++ b/drivers/input/mouse/cypress_ps2.c | |||
| @@ -236,6 +236,13 @@ static int cypress_read_fw_version(struct psmouse *psmouse) | |||
| 236 | cytp->fw_version = param[2] & FW_VERSION_MASX; | 236 | cytp->fw_version = param[2] & FW_VERSION_MASX; |
| 237 | cytp->tp_metrics_supported = (param[2] & TP_METRICS_MASK) ? 1 : 0; | 237 | cytp->tp_metrics_supported = (param[2] & TP_METRICS_MASK) ? 1 : 0; |
| 238 | 238 | ||
| 239 | /* | ||
| 240 | * Trackpad fw_version 11 (in Dell XPS12) yields a bogus response to | ||
| 241 | * CYTP_CMD_READ_TP_METRICS so do not try to use it. LP: #1103594. | ||
| 242 | */ | ||
| 243 | if (cytp->fw_version >= 11) | ||
| 244 | cytp->tp_metrics_supported = 0; | ||
| 245 | |||
| 239 | psmouse_dbg(psmouse, "cytp->fw_version = %d\n", cytp->fw_version); | 246 | psmouse_dbg(psmouse, "cytp->fw_version = %d\n", cytp->fw_version); |
| 240 | psmouse_dbg(psmouse, "cytp->tp_metrics_supported = %d\n", | 247 | psmouse_dbg(psmouse, "cytp->tp_metrics_supported = %d\n", |
| 241 | cytp->tp_metrics_supported); | 248 | cytp->tp_metrics_supported); |
| @@ -258,6 +265,9 @@ static int cypress_read_tp_metrics(struct psmouse *psmouse) | |||
| 258 | cytp->tp_res_x = cytp->tp_max_abs_x / cytp->tp_width; | 265 | cytp->tp_res_x = cytp->tp_max_abs_x / cytp->tp_width; |
| 259 | cytp->tp_res_y = cytp->tp_max_abs_y / cytp->tp_high; | 266 | cytp->tp_res_y = cytp->tp_max_abs_y / cytp->tp_high; |
| 260 | 267 | ||
| 268 | if (!cytp->tp_metrics_supported) | ||
| 269 | return 0; | ||
| 270 | |||
| 261 | memset(param, 0, sizeof(param)); | 271 | memset(param, 0, sizeof(param)); |
| 262 | if (cypress_send_ext_cmd(psmouse, CYTP_CMD_READ_TP_METRICS, param) == 0) { | 272 | if (cypress_send_ext_cmd(psmouse, CYTP_CMD_READ_TP_METRICS, param) == 0) { |
| 263 | /* Update trackpad parameters. */ | 273 | /* Update trackpad parameters. */ |
| @@ -315,18 +325,15 @@ static int cypress_read_tp_metrics(struct psmouse *psmouse) | |||
| 315 | 325 | ||
| 316 | static int cypress_query_hardware(struct psmouse *psmouse) | 326 | static int cypress_query_hardware(struct psmouse *psmouse) |
| 317 | { | 327 | { |
| 318 | struct cytp_data *cytp = psmouse->private; | ||
| 319 | int ret; | 328 | int ret; |
| 320 | 329 | ||
| 321 | ret = cypress_read_fw_version(psmouse); | 330 | ret = cypress_read_fw_version(psmouse); |
| 322 | if (ret) | 331 | if (ret) |
| 323 | return ret; | 332 | return ret; |
| 324 | 333 | ||
| 325 | if (cytp->tp_metrics_supported) { | 334 | ret = cypress_read_tp_metrics(psmouse); |
| 326 | ret = cypress_read_tp_metrics(psmouse); | 335 | if (ret) |
| 327 | if (ret) | 336 | return ret; |
| 328 | return ret; | ||
| 329 | } | ||
| 330 | 337 | ||
| 331 | return 0; | 338 | return 0; |
| 332 | } | 339 | } |
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 41b6fbf60112..1daa97913b7d 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c | |||
| @@ -2017,6 +2017,9 @@ static const struct wacom_features wacom_features_0x100 = | |||
| 2017 | static const struct wacom_features wacom_features_0x101 = | 2017 | static const struct wacom_features wacom_features_0x101 = |
| 2018 | { "Wacom ISDv4 101", WACOM_PKGLEN_MTTPC, 26202, 16325, 255, | 2018 | { "Wacom ISDv4 101", WACOM_PKGLEN_MTTPC, 26202, 16325, 255, |
| 2019 | 0, MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | 2019 | 0, MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; |
| 2020 | static const struct wacom_features wacom_features_0x10D = | ||
| 2021 | { "Wacom ISDv4 10D", WACOM_PKGLEN_MTTPC, 26202, 16325, 255, | ||
| 2022 | 0, MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | ||
| 2020 | static const struct wacom_features wacom_features_0x4001 = | 2023 | static const struct wacom_features wacom_features_0x4001 = |
| 2021 | { "Wacom ISDv4 4001", WACOM_PKGLEN_MTTPC, 26202, 16325, 255, | 2024 | { "Wacom ISDv4 4001", WACOM_PKGLEN_MTTPC, 26202, 16325, 255, |
| 2022 | 0, MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | 2025 | 0, MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; |
| @@ -2201,6 +2204,7 @@ const struct usb_device_id wacom_ids[] = { | |||
| 2201 | { USB_DEVICE_WACOM(0xEF) }, | 2204 | { USB_DEVICE_WACOM(0xEF) }, |
| 2202 | { USB_DEVICE_WACOM(0x100) }, | 2205 | { USB_DEVICE_WACOM(0x100) }, |
| 2203 | { USB_DEVICE_WACOM(0x101) }, | 2206 | { USB_DEVICE_WACOM(0x101) }, |
| 2207 | { USB_DEVICE_WACOM(0x10D) }, | ||
| 2204 | { USB_DEVICE_WACOM(0x4001) }, | 2208 | { USB_DEVICE_WACOM(0x4001) }, |
| 2205 | { USB_DEVICE_WACOM(0x47) }, | 2209 | { USB_DEVICE_WACOM(0x47) }, |
| 2206 | { USB_DEVICE_WACOM(0xF4) }, | 2210 | { USB_DEVICE_WACOM(0xF4) }, |
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 4f702b3ec1a3..434c3df250ca 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c | |||
| @@ -236,7 +236,12 @@ static void __ads7846_disable(struct ads7846 *ts) | |||
| 236 | /* Must be called with ts->lock held */ | 236 | /* Must be called with ts->lock held */ |
| 237 | static void __ads7846_enable(struct ads7846 *ts) | 237 | static void __ads7846_enable(struct ads7846 *ts) |
| 238 | { | 238 | { |
| 239 | regulator_enable(ts->reg); | 239 | int error; |
| 240 | |||
| 241 | error = regulator_enable(ts->reg); | ||
| 242 | if (error != 0) | ||
| 243 | dev_err(&ts->spi->dev, "Failed to enable supply: %d\n", error); | ||
| 244 | |||
| 240 | ads7846_restart(ts); | 245 | ads7846_restart(ts); |
| 241 | } | 246 | } |
| 242 | 247 | ||
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 4a29ddf6bf1e..1443532fe6c4 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c | |||
| @@ -314,15 +314,27 @@ static int mms114_start(struct mms114_data *data) | |||
| 314 | struct i2c_client *client = data->client; | 314 | struct i2c_client *client = data->client; |
| 315 | int error; | 315 | int error; |
| 316 | 316 | ||
| 317 | if (data->core_reg) | 317 | error = regulator_enable(data->core_reg); |
| 318 | regulator_enable(data->core_reg); | 318 | if (error) { |
| 319 | if (data->io_reg) | 319 | dev_err(&client->dev, "Failed to enable avdd: %d\n", error); |
| 320 | regulator_enable(data->io_reg); | 320 | return error; |
| 321 | } | ||
| 322 | |||
| 323 | error = regulator_enable(data->io_reg); | ||
| 324 | if (error) { | ||
| 325 | dev_err(&client->dev, "Failed to enable vdd: %d\n", error); | ||
| 326 | regulator_disable(data->core_reg); | ||
| 327 | return error; | ||
| 328 | } | ||
| 329 | |||
| 321 | mdelay(MMS114_POWERON_DELAY); | 330 | mdelay(MMS114_POWERON_DELAY); |
| 322 | 331 | ||
| 323 | error = mms114_setup_regs(data); | 332 | error = mms114_setup_regs(data); |
| 324 | if (error < 0) | 333 | if (error < 0) { |
| 334 | regulator_disable(data->io_reg); | ||
| 335 | regulator_disable(data->core_reg); | ||
| 325 | return error; | 336 | return error; |
| 337 | } | ||
| 326 | 338 | ||
| 327 | if (data->pdata->cfg_pin) | 339 | if (data->pdata->cfg_pin) |
| 328 | data->pdata->cfg_pin(true); | 340 | data->pdata->cfg_pin(true); |
| @@ -335,16 +347,20 @@ static int mms114_start(struct mms114_data *data) | |||
| 335 | static void mms114_stop(struct mms114_data *data) | 347 | static void mms114_stop(struct mms114_data *data) |
| 336 | { | 348 | { |
| 337 | struct i2c_client *client = data->client; | 349 | struct i2c_client *client = data->client; |
| 350 | int error; | ||
| 338 | 351 | ||
| 339 | disable_irq(client->irq); | 352 | disable_irq(client->irq); |
| 340 | 353 | ||
| 341 | if (data->pdata->cfg_pin) | 354 | if (data->pdata->cfg_pin) |
| 342 | data->pdata->cfg_pin(false); | 355 | data->pdata->cfg_pin(false); |
| 343 | 356 | ||
| 344 | if (data->io_reg) | 357 | error = regulator_disable(data->io_reg); |
| 345 | regulator_disable(data->io_reg); | 358 | if (error) |
| 346 | if (data->core_reg) | 359 | dev_warn(&client->dev, "Failed to disable vdd: %d\n", error); |
| 347 | regulator_disable(data->core_reg); | 360 | |
| 361 | error = regulator_disable(data->core_reg); | ||
| 362 | if (error) | ||
| 363 | dev_warn(&client->dev, "Failed to disable avdd: %d\n", error); | ||
| 348 | } | 364 | } |
| 349 | 365 | ||
| 350 | static int mms114_input_open(struct input_dev *dev) | 366 | static int mms114_input_open(struct input_dev *dev) |
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 644d72468423..a32e0d5aa45f 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c | |||
| @@ -648,7 +648,7 @@ void gic_raise_softirq(const struct cpumask *mask, unsigned int irq) | |||
| 648 | 648 | ||
| 649 | /* Convert our logical CPU mask into a physical one. */ | 649 | /* Convert our logical CPU mask into a physical one. */ |
| 650 | for_each_cpu(cpu, mask) | 650 | for_each_cpu(cpu, mask) |
| 651 | map |= 1 << cpu_logical_map(cpu); | 651 | map |= gic_cpu_map[cpu]; |
| 652 | 652 | ||
| 653 | /* | 653 | /* |
| 654 | * Ensure that stores to Normal memory are visible to the | 654 | * Ensure that stores to Normal memory are visible to the |
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c index d8a7d8323414..ebaebdf30f98 100644 --- a/drivers/isdn/i4l/isdn_tty.c +++ b/drivers/isdn/i4l/isdn_tty.c | |||
| @@ -902,7 +902,9 @@ isdn_tty_send_msg(modem_info *info, atemu *m, char *msg) | |||
| 902 | int j; | 902 | int j; |
| 903 | int l; | 903 | int l; |
| 904 | 904 | ||
| 905 | l = strlen(msg); | 905 | l = min(strlen(msg), sizeof(cmd.parm) - sizeof(cmd.parm.cmsg) |
| 906 | + sizeof(cmd.parm.cmsg.para) - 2); | ||
| 907 | |||
| 906 | if (!l) { | 908 | if (!l) { |
| 907 | isdn_tty_modem_result(RESULT_ERROR, info); | 909 | isdn_tty_modem_result(RESULT_ERROR, info); |
| 908 | return; | 910 | return; |
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 671f5b171c73..c346941a2515 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig | |||
| @@ -858,6 +858,7 @@ config EZX_PCAP | |||
| 858 | config AB8500_CORE | 858 | config AB8500_CORE |
| 859 | bool "ST-Ericsson AB8500 Mixed Signal Power Management chip" | 859 | bool "ST-Ericsson AB8500 Mixed Signal Power Management chip" |
| 860 | depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU | 860 | depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU |
| 861 | select POWER_SUPPLY | ||
| 861 | select MFD_CORE | 862 | select MFD_CORE |
| 862 | select IRQ_DOMAIN | 863 | select IRQ_DOMAIN |
| 863 | help | 864 | help |
diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c index b1f3561b023f..5f341a50ee5a 100644 --- a/drivers/mfd/ab8500-gpadc.c +++ b/drivers/mfd/ab8500-gpadc.c | |||
| @@ -594,9 +594,12 @@ static int ab8500_gpadc_runtime_suspend(struct device *dev) | |||
| 594 | static int ab8500_gpadc_runtime_resume(struct device *dev) | 594 | static int ab8500_gpadc_runtime_resume(struct device *dev) |
| 595 | { | 595 | { |
| 596 | struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); | 596 | struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); |
| 597 | int ret; | ||
| 597 | 598 | ||
| 598 | regulator_enable(gpadc->regu); | 599 | ret = regulator_enable(gpadc->regu); |
| 599 | return 0; | 600 | if (ret) |
| 601 | dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret); | ||
| 602 | return ret; | ||
| 600 | } | 603 | } |
| 601 | 604 | ||
| 602 | static int ab8500_gpadc_runtime_idle(struct device *dev) | 605 | static int ab8500_gpadc_runtime_idle(struct device *dev) |
| @@ -643,7 +646,7 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) | |||
| 643 | } | 646 | } |
| 644 | 647 | ||
| 645 | /* VTVout LDO used to power up ab8500-GPADC */ | 648 | /* VTVout LDO used to power up ab8500-GPADC */ |
| 646 | gpadc->regu = regulator_get(&pdev->dev, "vddadc"); | 649 | gpadc->regu = devm_regulator_get(&pdev->dev, "vddadc"); |
| 647 | if (IS_ERR(gpadc->regu)) { | 650 | if (IS_ERR(gpadc->regu)) { |
| 648 | ret = PTR_ERR(gpadc->regu); | 651 | ret = PTR_ERR(gpadc->regu); |
| 649 | dev_err(gpadc->dev, "failed to get vtvout LDO\n"); | 652 | dev_err(gpadc->dev, "failed to get vtvout LDO\n"); |
| @@ -652,7 +655,11 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) | |||
| 652 | 655 | ||
| 653 | platform_set_drvdata(pdev, gpadc); | 656 | platform_set_drvdata(pdev, gpadc); |
| 654 | 657 | ||
| 655 | regulator_enable(gpadc->regu); | 658 | ret = regulator_enable(gpadc->regu); |
| 659 | if (ret) { | ||
| 660 | dev_err(gpadc->dev, "Failed to enable vtvout LDO: %d\n", ret); | ||
| 661 | goto fail_enable; | ||
| 662 | } | ||
| 656 | 663 | ||
| 657 | pm_runtime_set_autosuspend_delay(gpadc->dev, GPADC_AUDOSUSPEND_DELAY); | 664 | pm_runtime_set_autosuspend_delay(gpadc->dev, GPADC_AUDOSUSPEND_DELAY); |
| 658 | pm_runtime_use_autosuspend(gpadc->dev); | 665 | pm_runtime_use_autosuspend(gpadc->dev); |
| @@ -663,6 +670,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) | |||
| 663 | list_add_tail(&gpadc->node, &ab8500_gpadc_list); | 670 | list_add_tail(&gpadc->node, &ab8500_gpadc_list); |
| 664 | dev_dbg(gpadc->dev, "probe success\n"); | 671 | dev_dbg(gpadc->dev, "probe success\n"); |
| 665 | return 0; | 672 | return 0; |
| 673 | |||
| 674 | fail_enable: | ||
| 666 | fail_irq: | 675 | fail_irq: |
| 667 | free_irq(gpadc->irq, gpadc); | 676 | free_irq(gpadc->irq, gpadc); |
| 668 | fail: | 677 | fail: |
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 6b5edf64de2b..4febc5c7fdee 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c | |||
| @@ -460,15 +460,15 @@ static void omap_usbhs_init(struct device *dev) | |||
| 460 | 460 | ||
| 461 | switch (omap->usbhs_rev) { | 461 | switch (omap->usbhs_rev) { |
| 462 | case OMAP_USBHS_REV1: | 462 | case OMAP_USBHS_REV1: |
| 463 | omap_usbhs_rev1_hostconfig(omap, reg); | 463 | reg = omap_usbhs_rev1_hostconfig(omap, reg); |
| 464 | break; | 464 | break; |
| 465 | 465 | ||
| 466 | case OMAP_USBHS_REV2: | 466 | case OMAP_USBHS_REV2: |
| 467 | omap_usbhs_rev2_hostconfig(omap, reg); | 467 | reg = omap_usbhs_rev2_hostconfig(omap, reg); |
| 468 | break; | 468 | break; |
| 469 | 469 | ||
| 470 | default: /* newer revisions */ | 470 | default: /* newer revisions */ |
| 471 | omap_usbhs_rev2_hostconfig(omap, reg); | 471 | reg = omap_usbhs_rev2_hostconfig(omap, reg); |
| 472 | break; | 472 | break; |
| 473 | } | 473 | } |
| 474 | 474 | ||
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c index bbdbc50a3cca..73bf76df1044 100644 --- a/drivers/mfd/palmas.c +++ b/drivers/mfd/palmas.c | |||
| @@ -257,9 +257,24 @@ static struct regmap_irq_chip palmas_irq_chip = { | |||
| 257 | PALMAS_INT1_MASK), | 257 | PALMAS_INT1_MASK), |
| 258 | }; | 258 | }; |
| 259 | 259 | ||
| 260 | static void palmas_dt_to_pdata(struct device_node *node, | 260 | static int palmas_set_pdata_irq_flag(struct i2c_client *i2c, |
| 261 | struct palmas_platform_data *pdata) | 261 | struct palmas_platform_data *pdata) |
| 262 | { | 262 | { |
| 263 | struct irq_data *irq_data = irq_get_irq_data(i2c->irq); | ||
| 264 | if (!irq_data) { | ||
| 265 | dev_err(&i2c->dev, "Invalid IRQ: %d\n", i2c->irq); | ||
| 266 | return -EINVAL; | ||
| 267 | } | ||
| 268 | |||
| 269 | pdata->irq_flags = irqd_get_trigger_type(irq_data); | ||
| 270 | dev_info(&i2c->dev, "Irq flag is 0x%08x\n", pdata->irq_flags); | ||
| 271 | return 0; | ||
| 272 | } | ||
| 273 | |||
| 274 | static void palmas_dt_to_pdata(struct i2c_client *i2c, | ||
| 275 | struct palmas_platform_data *pdata) | ||
| 276 | { | ||
| 277 | struct device_node *node = i2c->dev.of_node; | ||
| 263 | int ret; | 278 | int ret; |
| 264 | u32 prop; | 279 | u32 prop; |
| 265 | 280 | ||
| @@ -283,6 +298,8 @@ static void palmas_dt_to_pdata(struct device_node *node, | |||
| 283 | pdata->power_ctrl = PALMAS_POWER_CTRL_NSLEEP_MASK | | 298 | pdata->power_ctrl = PALMAS_POWER_CTRL_NSLEEP_MASK | |
| 284 | PALMAS_POWER_CTRL_ENABLE1_MASK | | 299 | PALMAS_POWER_CTRL_ENABLE1_MASK | |
| 285 | PALMAS_POWER_CTRL_ENABLE2_MASK; | 300 | PALMAS_POWER_CTRL_ENABLE2_MASK; |
| 301 | if (i2c->irq) | ||
| 302 | palmas_set_pdata_irq_flag(i2c, pdata); | ||
| 286 | } | 303 | } |
| 287 | 304 | ||
| 288 | static int palmas_i2c_probe(struct i2c_client *i2c, | 305 | static int palmas_i2c_probe(struct i2c_client *i2c, |
| @@ -304,7 +321,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c, | |||
| 304 | if (!pdata) | 321 | if (!pdata) |
| 305 | return -ENOMEM; | 322 | return -ENOMEM; |
| 306 | 323 | ||
| 307 | palmas_dt_to_pdata(node, pdata); | 324 | palmas_dt_to_pdata(i2c, pdata); |
| 308 | } | 325 | } |
| 309 | 326 | ||
| 310 | if (!pdata) | 327 | if (!pdata) |
| @@ -344,6 +361,19 @@ static int palmas_i2c_probe(struct i2c_client *i2c, | |||
| 344 | } | 361 | } |
| 345 | } | 362 | } |
| 346 | 363 | ||
| 364 | /* Change interrupt line output polarity */ | ||
| 365 | if (pdata->irq_flags & IRQ_TYPE_LEVEL_HIGH) | ||
| 366 | reg = PALMAS_POLARITY_CTRL_INT_POLARITY; | ||
| 367 | else | ||
| 368 | reg = 0; | ||
| 369 | ret = palmas_update_bits(palmas, PALMAS_PU_PD_OD_BASE, | ||
| 370 | PALMAS_POLARITY_CTRL, PALMAS_POLARITY_CTRL_INT_POLARITY, | ||
| 371 | reg); | ||
| 372 | if (ret < 0) { | ||
| 373 | dev_err(palmas->dev, "POLARITY_CTRL updat failed: %d\n", ret); | ||
| 374 | goto err; | ||
| 375 | } | ||
| 376 | |||
| 347 | /* Change IRQ into clear on read mode for efficiency */ | 377 | /* Change IRQ into clear on read mode for efficiency */ |
| 348 | slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE); | 378 | slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE); |
| 349 | addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL); | 379 | addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL); |
| @@ -352,7 +382,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c, | |||
| 352 | regmap_write(palmas->regmap[slave], addr, reg); | 382 | regmap_write(palmas->regmap[slave], addr, reg); |
| 353 | 383 | ||
| 354 | ret = regmap_add_irq_chip(palmas->regmap[slave], palmas->irq, | 384 | ret = regmap_add_irq_chip(palmas->regmap[slave], palmas->irq, |
| 355 | IRQF_ONESHOT | IRQF_TRIGGER_LOW, 0, &palmas_irq_chip, | 385 | IRQF_ONESHOT | pdata->irq_flags, 0, &palmas_irq_chip, |
| 356 | &palmas->irq_data); | 386 | &palmas->irq_data); |
| 357 | if (ret < 0) | 387 | if (ret < 0) |
| 358 | goto err; | 388 | goto err; |
diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c index 4658b5bdcd84..aeb8e40ab424 100644 --- a/drivers/mfd/tps65912-core.c +++ b/drivers/mfd/tps65912-core.c | |||
| @@ -169,6 +169,7 @@ err: | |||
| 169 | void tps65912_device_exit(struct tps65912 *tps65912) | 169 | void tps65912_device_exit(struct tps65912 *tps65912) |
| 170 | { | 170 | { |
| 171 | mfd_remove_devices(tps65912->dev); | 171 | mfd_remove_devices(tps65912->dev); |
| 172 | tps65912_irq_exit(tps65912); | ||
| 172 | kfree(tps65912); | 173 | kfree(tps65912); |
| 173 | } | 174 | } |
| 174 | 175 | ||
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c index e16edca92670..d2ab222138c2 100644 --- a/drivers/mfd/twl4030-audio.c +++ b/drivers/mfd/twl4030-audio.c | |||
| @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(twl4030_audio_enable_resource); | |||
| 118 | * Disable the resource. | 118 | * Disable the resource. |
| 119 | * The function returns with error or the content of the register | 119 | * The function returns with error or the content of the register |
| 120 | */ | 120 | */ |
| 121 | int twl4030_audio_disable_resource(unsigned id) | 121 | int twl4030_audio_disable_resource(enum twl4030_audio_res id) |
| 122 | { | 122 | { |
| 123 | struct twl4030_audio *audio = platform_get_drvdata(twl4030_audio_dev); | 123 | struct twl4030_audio *audio = platform_get_drvdata(twl4030_audio_dev); |
| 124 | int val; | 124 | int val; |
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c index 88ff9dc83305..942b666a2a07 100644 --- a/drivers/mfd/twl4030-madc.c +++ b/drivers/mfd/twl4030-madc.c | |||
| @@ -800,7 +800,7 @@ static int twl4030_madc_remove(struct platform_device *pdev) | |||
| 800 | 800 | ||
| 801 | static struct platform_driver twl4030_madc_driver = { | 801 | static struct platform_driver twl4030_madc_driver = { |
| 802 | .probe = twl4030_madc_probe, | 802 | .probe = twl4030_madc_probe, |
| 803 | .remove = __exit_p(twl4030_madc_remove), | 803 | .remove = twl4030_madc_remove, |
| 804 | .driver = { | 804 | .driver = { |
| 805 | .name = "twl4030_madc", | 805 | .name = "twl4030_madc", |
| 806 | .owner = THIS_MODULE, | 806 | .owner = THIS_MODULE, |
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 7bd068a6056a..8b4e96e01d6c 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
| @@ -1964,7 +1964,6 @@ static int __bond_release_one(struct net_device *bond_dev, | |||
| 1964 | } | 1964 | } |
| 1965 | 1965 | ||
| 1966 | block_netpoll_tx(); | 1966 | block_netpoll_tx(); |
| 1967 | call_netdevice_notifiers(NETDEV_RELEASE, bond_dev); | ||
| 1968 | write_lock_bh(&bond->lock); | 1967 | write_lock_bh(&bond->lock); |
| 1969 | 1968 | ||
| 1970 | slave = bond_get_slave_by_dev(bond, slave_dev); | 1969 | slave = bond_get_slave_by_dev(bond, slave_dev); |
| @@ -2066,8 +2065,10 @@ static int __bond_release_one(struct net_device *bond_dev, | |||
| 2066 | write_unlock_bh(&bond->lock); | 2065 | write_unlock_bh(&bond->lock); |
| 2067 | unblock_netpoll_tx(); | 2066 | unblock_netpoll_tx(); |
| 2068 | 2067 | ||
| 2069 | if (bond->slave_cnt == 0) | 2068 | if (bond->slave_cnt == 0) { |
| 2070 | call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev); | 2069 | call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev); |
| 2070 | call_netdevice_notifiers(NETDEV_RELEASE, bond->dev); | ||
| 2071 | } | ||
| 2071 | 2072 | ||
| 2072 | bond_compute_features(bond); | 2073 | bond_compute_features(bond); |
| 2073 | if (!(bond_dev->features & NETIF_F_VLAN_CHALLENGED) && | 2074 | if (!(bond_dev->features & NETIF_F_VLAN_CHALLENGED) && |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c index 31c5787970db..77ebae0ac64a 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | |||
| @@ -8647,7 +8647,9 @@ void bnx2x_handle_module_detect_int(struct link_params *params) | |||
| 8647 | MDIO_WC_DEVAD, | 8647 | MDIO_WC_DEVAD, |
| 8648 | MDIO_WC_REG_DIGITAL5_MISC6, | 8648 | MDIO_WC_REG_DIGITAL5_MISC6, |
| 8649 | &rx_tx_in_reset); | 8649 | &rx_tx_in_reset); |
| 8650 | if (!rx_tx_in_reset) { | 8650 | if ((!rx_tx_in_reset) && |
| 8651 | (params->link_flags & | ||
| 8652 | PHY_INITIALIZED)) { | ||
| 8651 | bnx2x_warpcore_reset_lane(bp, phy, 1); | 8653 | bnx2x_warpcore_reset_lane(bp, phy, 1); |
| 8652 | bnx2x_warpcore_config_sfi(phy, params); | 8654 | bnx2x_warpcore_config_sfi(phy, params); |
| 8653 | bnx2x_warpcore_reset_lane(bp, phy, 0); | 8655 | bnx2x_warpcore_reset_lane(bp, phy, 0); |
| @@ -12527,6 +12529,8 @@ int bnx2x_phy_init(struct link_params *params, struct link_vars *vars) | |||
| 12527 | vars->flow_ctrl = BNX2X_FLOW_CTRL_NONE; | 12529 | vars->flow_ctrl = BNX2X_FLOW_CTRL_NONE; |
| 12528 | vars->mac_type = MAC_TYPE_NONE; | 12530 | vars->mac_type = MAC_TYPE_NONE; |
| 12529 | vars->phy_flags = 0; | 12531 | vars->phy_flags = 0; |
| 12532 | vars->check_kr2_recovery_cnt = 0; | ||
| 12533 | params->link_flags = PHY_INITIALIZED; | ||
| 12530 | /* Driver opens NIG-BRB filters */ | 12534 | /* Driver opens NIG-BRB filters */ |
| 12531 | bnx2x_set_rx_filter(params, 1); | 12535 | bnx2x_set_rx_filter(params, 1); |
| 12532 | /* Check if link flap can be avoided */ | 12536 | /* Check if link flap can be avoided */ |
| @@ -12691,6 +12695,7 @@ int bnx2x_lfa_reset(struct link_params *params, | |||
| 12691 | struct bnx2x *bp = params->bp; | 12695 | struct bnx2x *bp = params->bp; |
| 12692 | vars->link_up = 0; | 12696 | vars->link_up = 0; |
| 12693 | vars->phy_flags = 0; | 12697 | vars->phy_flags = 0; |
| 12698 | params->link_flags &= ~PHY_INITIALIZED; | ||
| 12694 | if (!params->lfa_base) | 12699 | if (!params->lfa_base) |
| 12695 | return bnx2x_link_reset(params, vars, 1); | 12700 | return bnx2x_link_reset(params, vars, 1); |
| 12696 | /* | 12701 | /* |
| @@ -13411,6 +13416,7 @@ static void bnx2x_disable_kr2(struct link_params *params, | |||
| 13411 | vars->link_attr_sync &= ~LINK_ATTR_SYNC_KR2_ENABLE; | 13416 | vars->link_attr_sync &= ~LINK_ATTR_SYNC_KR2_ENABLE; |
| 13412 | bnx2x_update_link_attr(params, vars->link_attr_sync); | 13417 | bnx2x_update_link_attr(params, vars->link_attr_sync); |
| 13413 | 13418 | ||
| 13419 | vars->check_kr2_recovery_cnt = CHECK_KR2_RECOVERY_CNT; | ||
| 13414 | /* Restart AN on leading lane */ | 13420 | /* Restart AN on leading lane */ |
| 13415 | bnx2x_warpcore_restart_AN_KR(phy, params); | 13421 | bnx2x_warpcore_restart_AN_KR(phy, params); |
| 13416 | } | 13422 | } |
| @@ -13439,6 +13445,15 @@ static void bnx2x_check_kr2_wa(struct link_params *params, | |||
| 13439 | return; | 13445 | return; |
| 13440 | } | 13446 | } |
| 13441 | 13447 | ||
| 13448 | /* Once KR2 was disabled, wait 5 seconds before checking KR2 recovery | ||
| 13449 | * since some switches tend to reinit the AN process and clear the | ||
| 13450 | * advertised BP/NP after ~2 seconds causing the KR2 to be disabled | ||
| 13451 | * and recovered many times | ||
| 13452 | */ | ||
| 13453 | if (vars->check_kr2_recovery_cnt > 0) { | ||
| 13454 | vars->check_kr2_recovery_cnt--; | ||
| 13455 | return; | ||
| 13456 | } | ||
| 13442 | lane = bnx2x_get_warpcore_lane(phy, params); | 13457 | lane = bnx2x_get_warpcore_lane(phy, params); |
| 13443 | CL22_WR_OVER_CL45(bp, phy, MDIO_REG_BANK_AER_BLOCK, | 13458 | CL22_WR_OVER_CL45(bp, phy, MDIO_REG_BANK_AER_BLOCK, |
| 13444 | MDIO_AER_BLOCK_AER_REG, lane); | 13459 | MDIO_AER_BLOCK_AER_REG, lane); |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.h index be5c195d03dd..56c2aae4e2c8 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.h | |||
| @@ -309,6 +309,7 @@ struct link_params { | |||
| 309 | req_flow_ctrl is set to AUTO */ | 309 | req_flow_ctrl is set to AUTO */ |
| 310 | u16 link_flags; | 310 | u16 link_flags; |
| 311 | #define LINK_FLAGS_INT_DISABLED (1<<0) | 311 | #define LINK_FLAGS_INT_DISABLED (1<<0) |
| 312 | #define PHY_INITIALIZED (1<<1) | ||
| 312 | u32 lfa_base; | 313 | u32 lfa_base; |
| 313 | }; | 314 | }; |
| 314 | 315 | ||
| @@ -342,7 +343,8 @@ struct link_vars { | |||
| 342 | u32 link_status; | 343 | u32 link_status; |
| 343 | u32 eee_status; | 344 | u32 eee_status; |
| 344 | u8 fault_detected; | 345 | u8 fault_detected; |
| 345 | u8 rsrv1; | 346 | u8 check_kr2_recovery_cnt; |
| 347 | #define CHECK_KR2_RECOVERY_CNT 5 | ||
| 346 | u16 periodic_flags; | 348 | u16 periodic_flags; |
| 347 | #define PERIODIC_FLAGS_LINK_EVENT 0x0001 | 349 | #define PERIODIC_FLAGS_LINK_EVENT 0x0001 |
| 348 | 350 | ||
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index fdb9b5655414..93729f942358 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c | |||
| @@ -1869,6 +1869,8 @@ static void tg3_link_report(struct tg3 *tp) | |||
| 1869 | 1869 | ||
| 1870 | tg3_ump_link_report(tp); | 1870 | tg3_ump_link_report(tp); |
| 1871 | } | 1871 | } |
| 1872 | |||
| 1873 | tp->link_up = netif_carrier_ok(tp->dev); | ||
| 1872 | } | 1874 | } |
| 1873 | 1875 | ||
| 1874 | static u16 tg3_advert_flowctrl_1000X(u8 flow_ctrl) | 1876 | static u16 tg3_advert_flowctrl_1000X(u8 flow_ctrl) |
| @@ -2522,12 +2524,6 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp) | |||
| 2522 | return err; | 2524 | return err; |
| 2523 | } | 2525 | } |
| 2524 | 2526 | ||
| 2525 | static void tg3_carrier_on(struct tg3 *tp) | ||
| 2526 | { | ||
| 2527 | netif_carrier_on(tp->dev); | ||
| 2528 | tp->link_up = true; | ||
| 2529 | } | ||
| 2530 | |||
| 2531 | static void tg3_carrier_off(struct tg3 *tp) | 2527 | static void tg3_carrier_off(struct tg3 *tp) |
| 2532 | { | 2528 | { |
| 2533 | netif_carrier_off(tp->dev); | 2529 | netif_carrier_off(tp->dev); |
| @@ -2553,7 +2549,7 @@ static int tg3_phy_reset(struct tg3 *tp) | |||
| 2553 | return -EBUSY; | 2549 | return -EBUSY; |
| 2554 | 2550 | ||
| 2555 | if (netif_running(tp->dev) && tp->link_up) { | 2551 | if (netif_running(tp->dev) && tp->link_up) { |
| 2556 | tg3_carrier_off(tp); | 2552 | netif_carrier_off(tp->dev); |
| 2557 | tg3_link_report(tp); | 2553 | tg3_link_report(tp); |
| 2558 | } | 2554 | } |
| 2559 | 2555 | ||
| @@ -4262,9 +4258,9 @@ static bool tg3_test_and_report_link_chg(struct tg3 *tp, int curr_link_up) | |||
| 4262 | { | 4258 | { |
| 4263 | if (curr_link_up != tp->link_up) { | 4259 | if (curr_link_up != tp->link_up) { |
| 4264 | if (curr_link_up) { | 4260 | if (curr_link_up) { |
| 4265 | tg3_carrier_on(tp); | 4261 | netif_carrier_on(tp->dev); |
| 4266 | } else { | 4262 | } else { |
| 4267 | tg3_carrier_off(tp); | 4263 | netif_carrier_off(tp->dev); |
| 4268 | if (tp->phy_flags & TG3_PHYFLG_MII_SERDES) | 4264 | if (tp->phy_flags & TG3_PHYFLG_MII_SERDES) |
| 4269 | tp->phy_flags &= ~TG3_PHYFLG_PARALLEL_DETECT; | 4265 | tp->phy_flags &= ~TG3_PHYFLG_PARALLEL_DETECT; |
| 4270 | } | 4266 | } |
diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 28ceb8414185..29aff55f2eea 100644 --- a/drivers/net/ethernet/emulex/benet/be.h +++ b/drivers/net/ethernet/emulex/benet/be.h | |||
| @@ -349,6 +349,7 @@ struct be_adapter { | |||
| 349 | struct pci_dev *pdev; | 349 | struct pci_dev *pdev; |
| 350 | struct net_device *netdev; | 350 | struct net_device *netdev; |
| 351 | 351 | ||
| 352 | u8 __iomem *csr; /* CSR BAR used only for BE2/3 */ | ||
| 352 | u8 __iomem *db; /* Door Bell */ | 353 | u8 __iomem *db; /* Door Bell */ |
| 353 | 354 | ||
| 354 | struct mutex mbox_lock; /* For serializing mbox cmds to BE card */ | 355 | struct mutex mbox_lock; /* For serializing mbox cmds to BE card */ |
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index 071aea79d218..3c9b4f12e3e5 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.c +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c | |||
| @@ -473,19 +473,17 @@ static int be_mbox_notify_wait(struct be_adapter *adapter) | |||
| 473 | return 0; | 473 | return 0; |
| 474 | } | 474 | } |
| 475 | 475 | ||
| 476 | static int be_POST_stage_get(struct be_adapter *adapter, u16 *stage) | 476 | static u16 be_POST_stage_get(struct be_adapter *adapter) |
| 477 | { | 477 | { |
| 478 | u32 sem; | 478 | u32 sem; |
| 479 | u32 reg = skyhawk_chip(adapter) ? SLIPORT_SEMAPHORE_OFFSET_SH : | ||
| 480 | SLIPORT_SEMAPHORE_OFFSET_BE; | ||
| 481 | 479 | ||
| 482 | pci_read_config_dword(adapter->pdev, reg, &sem); | 480 | if (BEx_chip(adapter)) |
| 483 | *stage = sem & POST_STAGE_MASK; | 481 | sem = ioread32(adapter->csr + SLIPORT_SEMAPHORE_OFFSET_BEx); |
| 484 | |||
| 485 | if ((sem >> POST_ERR_SHIFT) & POST_ERR_MASK) | ||
| 486 | return -1; | ||
| 487 | else | 482 | else |
| 488 | return 0; | 483 | pci_read_config_dword(adapter->pdev, |
| 484 | SLIPORT_SEMAPHORE_OFFSET_SH, &sem); | ||
| 485 | |||
| 486 | return sem & POST_STAGE_MASK; | ||
| 489 | } | 487 | } |
| 490 | 488 | ||
| 491 | int lancer_wait_ready(struct be_adapter *adapter) | 489 | int lancer_wait_ready(struct be_adapter *adapter) |
| @@ -579,19 +577,17 @@ int be_fw_wait_ready(struct be_adapter *adapter) | |||
| 579 | } | 577 | } |
| 580 | 578 | ||
| 581 | do { | 579 | do { |
| 582 | status = be_POST_stage_get(adapter, &stage); | 580 | stage = be_POST_stage_get(adapter); |
| 583 | if (status) { | 581 | if (stage == POST_STAGE_ARMFW_RDY) |
| 584 | dev_err(dev, "POST error; stage=0x%x\n", stage); | ||
| 585 | return -1; | ||
| 586 | } else if (stage != POST_STAGE_ARMFW_RDY) { | ||
| 587 | if (msleep_interruptible(2000)) { | ||
| 588 | dev_err(dev, "Waiting for POST aborted\n"); | ||
| 589 | return -EINTR; | ||
| 590 | } | ||
| 591 | timeout += 2; | ||
| 592 | } else { | ||
| 593 | return 0; | 582 | return 0; |
| 583 | |||
| 584 | dev_info(dev, "Waiting for POST, %ds elapsed\n", | ||
| 585 | timeout); | ||
| 586 | if (msleep_interruptible(2000)) { | ||
| 587 | dev_err(dev, "Waiting for POST aborted\n"); | ||
| 588 | return -EINTR; | ||
| 594 | } | 589 | } |
| 590 | timeout += 2; | ||
| 595 | } while (timeout < 60); | 591 | } while (timeout < 60); |
| 596 | 592 | ||
| 597 | dev_err(dev, "POST timeout; stage=0x%x\n", stage); | 593 | dev_err(dev, "POST timeout; stage=0x%x\n", stage); |
diff --git a/drivers/net/ethernet/emulex/benet/be_hw.h b/drivers/net/ethernet/emulex/benet/be_hw.h index 541d4530d5bf..62dc220695f7 100644 --- a/drivers/net/ethernet/emulex/benet/be_hw.h +++ b/drivers/net/ethernet/emulex/benet/be_hw.h | |||
| @@ -32,8 +32,8 @@ | |||
| 32 | #define MPU_EP_CONTROL 0 | 32 | #define MPU_EP_CONTROL 0 |
| 33 | 33 | ||
| 34 | /********** MPU semphore: used for SH & BE *************/ | 34 | /********** MPU semphore: used for SH & BE *************/ |
| 35 | #define SLIPORT_SEMAPHORE_OFFSET_BE 0x7c | 35 | #define SLIPORT_SEMAPHORE_OFFSET_BEx 0xac /* CSR BAR offset */ |
| 36 | #define SLIPORT_SEMAPHORE_OFFSET_SH 0x94 | 36 | #define SLIPORT_SEMAPHORE_OFFSET_SH 0x94 /* PCI-CFG offset */ |
| 37 | #define POST_STAGE_MASK 0x0000FFFF | 37 | #define POST_STAGE_MASK 0x0000FFFF |
| 38 | #define POST_ERR_MASK 0x1 | 38 | #define POST_ERR_MASK 0x1 |
| 39 | #define POST_ERR_SHIFT 31 | 39 | #define POST_ERR_SHIFT 31 |
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 3860888ac711..08e54f3d288b 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
| @@ -3688,6 +3688,8 @@ static void be_netdev_init(struct net_device *netdev) | |||
| 3688 | 3688 | ||
| 3689 | static void be_unmap_pci_bars(struct be_adapter *adapter) | 3689 | static void be_unmap_pci_bars(struct be_adapter *adapter) |
| 3690 | { | 3690 | { |
| 3691 | if (adapter->csr) | ||
| 3692 | pci_iounmap(adapter->pdev, adapter->csr); | ||
| 3691 | if (adapter->db) | 3693 | if (adapter->db) |
| 3692 | pci_iounmap(adapter->pdev, adapter->db); | 3694 | pci_iounmap(adapter->pdev, adapter->db); |
| 3693 | } | 3695 | } |
| @@ -3721,6 +3723,12 @@ static int be_map_pci_bars(struct be_adapter *adapter) | |||
| 3721 | adapter->if_type = (sli_intf & SLI_INTF_IF_TYPE_MASK) >> | 3723 | adapter->if_type = (sli_intf & SLI_INTF_IF_TYPE_MASK) >> |
| 3722 | SLI_INTF_IF_TYPE_SHIFT; | 3724 | SLI_INTF_IF_TYPE_SHIFT; |
| 3723 | 3725 | ||
| 3726 | if (BEx_chip(adapter) && be_physfn(adapter)) { | ||
| 3727 | adapter->csr = pci_iomap(adapter->pdev, 2, 0); | ||
| 3728 | if (adapter->csr == NULL) | ||
| 3729 | return -ENOMEM; | ||
| 3730 | } | ||
| 3731 | |||
| 3724 | addr = pci_iomap(adapter->pdev, db_bar(adapter), 0); | 3732 | addr = pci_iomap(adapter->pdev, db_bar(adapter), 0); |
| 3725 | if (addr == NULL) | 3733 | if (addr == NULL) |
| 3726 | goto pci_map_err; | 3734 | goto pci_map_err; |
| @@ -4329,6 +4337,8 @@ static pci_ers_result_t be_eeh_reset(struct pci_dev *pdev) | |||
| 4329 | pci_restore_state(pdev); | 4337 | pci_restore_state(pdev); |
| 4330 | 4338 | ||
| 4331 | /* Check if card is ok and fw is ready */ | 4339 | /* Check if card is ok and fw is ready */ |
| 4340 | dev_info(&adapter->pdev->dev, | ||
| 4341 | "Waiting for FW to be ready after EEH reset\n"); | ||
| 4332 | status = be_fw_wait_ready(adapter); | 4342 | status = be_fw_wait_ready(adapter); |
| 4333 | if (status) | 4343 | if (status) |
| 4334 | return PCI_ERS_RESULT_DISCONNECT; | 4344 | return PCI_ERS_RESULT_DISCONNECT; |
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 2c1813737f6d..f91a8f3f9d48 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
| @@ -36,6 +36,7 @@ | |||
| 36 | #include <linux/delay.h> | 36 | #include <linux/delay.h> |
| 37 | #include <linux/vmalloc.h> | 37 | #include <linux/vmalloc.h> |
| 38 | #include <linux/mdio.h> | 38 | #include <linux/mdio.h> |
| 39 | #include <linux/pm_runtime.h> | ||
| 39 | 40 | ||
| 40 | #include "e1000.h" | 41 | #include "e1000.h" |
| 41 | 42 | ||
| @@ -2229,7 +2230,19 @@ static int e1000e_get_ts_info(struct net_device *netdev, | |||
| 2229 | return 0; | 2230 | return 0; |
| 2230 | } | 2231 | } |
| 2231 | 2232 | ||
| 2233 | static int e1000e_ethtool_begin(struct net_device *netdev) | ||
| 2234 | { | ||
| 2235 | return pm_runtime_get_sync(netdev->dev.parent); | ||
| 2236 | } | ||
| 2237 | |||
| 2238 | static void e1000e_ethtool_complete(struct net_device *netdev) | ||
| 2239 | { | ||
| 2240 | pm_runtime_put_sync(netdev->dev.parent); | ||
| 2241 | } | ||
| 2242 | |||
| 2232 | static const struct ethtool_ops e1000_ethtool_ops = { | 2243 | static const struct ethtool_ops e1000_ethtool_ops = { |
| 2244 | .begin = e1000e_ethtool_begin, | ||
| 2245 | .complete = e1000e_ethtool_complete, | ||
| 2233 | .get_settings = e1000_get_settings, | 2246 | .get_settings = e1000_get_settings, |
| 2234 | .set_settings = e1000_set_settings, | 2247 | .set_settings = e1000_set_settings, |
| 2235 | .get_drvinfo = e1000_get_drvinfo, | 2248 | .get_drvinfo = e1000_get_drvinfo, |
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index dff7bff8b8e0..121a865c7fbd 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c | |||
| @@ -782,6 +782,59 @@ release: | |||
| 782 | } | 782 | } |
| 783 | 783 | ||
| 784 | /** | 784 | /** |
| 785 | * e1000_k1_workaround_lpt_lp - K1 workaround on Lynxpoint-LP | ||
| 786 | * @hw: pointer to the HW structure | ||
| 787 | * @link: link up bool flag | ||
| 788 | * | ||
| 789 | * When K1 is enabled for 1Gbps, the MAC can miss 2 DMA completion indications | ||
| 790 | * preventing further DMA write requests. Workaround the issue by disabling | ||
| 791 | * the de-assertion of the clock request when in 1Gpbs mode. | ||
| 792 | **/ | ||
| 793 | static s32 e1000_k1_workaround_lpt_lp(struct e1000_hw *hw, bool link) | ||
| 794 | { | ||
| 795 | u32 fextnvm6 = er32(FEXTNVM6); | ||
| 796 | s32 ret_val = 0; | ||
| 797 | |||
| 798 | if (link && (er32(STATUS) & E1000_STATUS_SPEED_1000)) { | ||
| 799 | u16 kmrn_reg; | ||
| 800 | |||
| 801 | ret_val = hw->phy.ops.acquire(hw); | ||
| 802 | if (ret_val) | ||
| 803 | return ret_val; | ||
| 804 | |||
| 805 | ret_val = | ||
| 806 | e1000e_read_kmrn_reg_locked(hw, E1000_KMRNCTRLSTA_K1_CONFIG, | ||
| 807 | &kmrn_reg); | ||
| 808 | if (ret_val) | ||
| 809 | goto release; | ||
| 810 | |||
| 811 | ret_val = | ||
| 812 | e1000e_write_kmrn_reg_locked(hw, | ||
| 813 | E1000_KMRNCTRLSTA_K1_CONFIG, | ||
| 814 | kmrn_reg & | ||
| 815 | ~E1000_KMRNCTRLSTA_K1_ENABLE); | ||
| 816 | if (ret_val) | ||
| 817 | goto release; | ||
| 818 | |||
| 819 | usleep_range(10, 20); | ||
| 820 | |||
| 821 | ew32(FEXTNVM6, fextnvm6 | E1000_FEXTNVM6_REQ_PLL_CLK); | ||
| 822 | |||
| 823 | ret_val = | ||
| 824 | e1000e_write_kmrn_reg_locked(hw, | ||
| 825 | E1000_KMRNCTRLSTA_K1_CONFIG, | ||
| 826 | kmrn_reg); | ||
| 827 | release: | ||
| 828 | hw->phy.ops.release(hw); | ||
| 829 | } else { | ||
| 830 | /* clear FEXTNVM6 bit 8 on link down or 10/100 */ | ||
| 831 | ew32(FEXTNVM6, fextnvm6 & ~E1000_FEXTNVM6_REQ_PLL_CLK); | ||
| 832 | } | ||
| 833 | |||
| 834 | return ret_val; | ||
| 835 | } | ||
| 836 | |||
| 837 | /** | ||
| 785 | * e1000_check_for_copper_link_ich8lan - Check for link (Copper) | 838 | * e1000_check_for_copper_link_ich8lan - Check for link (Copper) |
| 786 | * @hw: pointer to the HW structure | 839 | * @hw: pointer to the HW structure |
| 787 | * | 840 | * |
| @@ -818,6 +871,14 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw) | |||
| 818 | return ret_val; | 871 | return ret_val; |
| 819 | } | 872 | } |
| 820 | 873 | ||
| 874 | /* Work-around I218 hang issue */ | ||
| 875 | if ((hw->adapter->pdev->device == E1000_DEV_ID_PCH_LPTLP_I218_LM) || | ||
| 876 | (hw->adapter->pdev->device == E1000_DEV_ID_PCH_LPTLP_I218_V)) { | ||
| 877 | ret_val = e1000_k1_workaround_lpt_lp(hw, link); | ||
| 878 | if (ret_val) | ||
| 879 | return ret_val; | ||
| 880 | } | ||
| 881 | |||
| 821 | /* Clear link partner's EEE ability */ | 882 | /* Clear link partner's EEE ability */ |
| 822 | hw->dev_spec.ich8lan.eee_lp_ability = 0; | 883 | hw->dev_spec.ich8lan.eee_lp_ability = 0; |
| 823 | 884 | ||
| @@ -3954,8 +4015,16 @@ void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw) | |||
| 3954 | 4015 | ||
| 3955 | phy_ctrl = er32(PHY_CTRL); | 4016 | phy_ctrl = er32(PHY_CTRL); |
| 3956 | phy_ctrl |= E1000_PHY_CTRL_GBE_DISABLE; | 4017 | phy_ctrl |= E1000_PHY_CTRL_GBE_DISABLE; |
| 4018 | |||
| 3957 | if (hw->phy.type == e1000_phy_i217) { | 4019 | if (hw->phy.type == e1000_phy_i217) { |
| 3958 | u16 phy_reg; | 4020 | u16 phy_reg, device_id = hw->adapter->pdev->device; |
| 4021 | |||
| 4022 | if ((device_id == E1000_DEV_ID_PCH_LPTLP_I218_LM) || | ||
| 4023 | (device_id == E1000_DEV_ID_PCH_LPTLP_I218_V)) { | ||
| 4024 | u32 fextnvm6 = er32(FEXTNVM6); | ||
| 4025 | |||
| 4026 | ew32(FEXTNVM6, fextnvm6 & ~E1000_FEXTNVM6_REQ_PLL_CLK); | ||
| 4027 | } | ||
| 3959 | 4028 | ||
| 3960 | ret_val = hw->phy.ops.acquire(hw); | 4029 | ret_val = hw->phy.ops.acquire(hw); |
| 3961 | if (ret_val) | 4030 | if (ret_val) |
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.h b/drivers/net/ethernet/intel/e1000e/ich8lan.h index b6d3174d7d2d..8bf4655c2e17 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.h +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.h | |||
| @@ -92,6 +92,8 @@ | |||
| 92 | #define E1000_FEXTNVM4_BEACON_DURATION_8USEC 0x7 | 92 | #define E1000_FEXTNVM4_BEACON_DURATION_8USEC 0x7 |
| 93 | #define E1000_FEXTNVM4_BEACON_DURATION_16USEC 0x3 | 93 | #define E1000_FEXTNVM4_BEACON_DURATION_16USEC 0x3 |
| 94 | 94 | ||
| 95 | #define E1000_FEXTNVM6_REQ_PLL_CLK 0x00000100 | ||
| 96 | |||
| 95 | #define PCIE_ICH8_SNOOP_ALL PCIE_NO_SNOOP_ALL | 97 | #define PCIE_ICH8_SNOOP_ALL PCIE_NO_SNOOP_ALL |
| 96 | 98 | ||
| 97 | #define E1000_ICH_RAR_ENTRIES 7 | 99 | #define E1000_ICH_RAR_ENTRIES 7 |
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index a177b8b65c44..948b86ffa4f0 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c | |||
| @@ -4303,6 +4303,7 @@ static int e1000_open(struct net_device *netdev) | |||
| 4303 | netif_start_queue(netdev); | 4303 | netif_start_queue(netdev); |
| 4304 | 4304 | ||
| 4305 | adapter->idle_check = true; | 4305 | adapter->idle_check = true; |
| 4306 | hw->mac.get_link_status = true; | ||
| 4306 | pm_runtime_put(&pdev->dev); | 4307 | pm_runtime_put(&pdev->dev); |
| 4307 | 4308 | ||
| 4308 | /* fire a link status change interrupt to start the watchdog */ | 4309 | /* fire a link status change interrupt to start the watchdog */ |
| @@ -4662,6 +4663,7 @@ static void e1000_phy_read_status(struct e1000_adapter *adapter) | |||
| 4662 | (adapter->hw.phy.media_type == e1000_media_type_copper)) { | 4663 | (adapter->hw.phy.media_type == e1000_media_type_copper)) { |
| 4663 | int ret_val; | 4664 | int ret_val; |
| 4664 | 4665 | ||
| 4666 | pm_runtime_get_sync(&adapter->pdev->dev); | ||
| 4665 | ret_val = e1e_rphy(hw, MII_BMCR, &phy->bmcr); | 4667 | ret_val = e1e_rphy(hw, MII_BMCR, &phy->bmcr); |
| 4666 | ret_val |= e1e_rphy(hw, MII_BMSR, &phy->bmsr); | 4668 | ret_val |= e1e_rphy(hw, MII_BMSR, &phy->bmsr); |
| 4667 | ret_val |= e1e_rphy(hw, MII_ADVERTISE, &phy->advertise); | 4669 | ret_val |= e1e_rphy(hw, MII_ADVERTISE, &phy->advertise); |
| @@ -4672,6 +4674,7 @@ static void e1000_phy_read_status(struct e1000_adapter *adapter) | |||
| 4672 | ret_val |= e1e_rphy(hw, MII_ESTATUS, &phy->estatus); | 4674 | ret_val |= e1e_rphy(hw, MII_ESTATUS, &phy->estatus); |
| 4673 | if (ret_val) | 4675 | if (ret_val) |
| 4674 | e_warn("Error reading PHY register\n"); | 4676 | e_warn("Error reading PHY register\n"); |
| 4677 | pm_runtime_put_sync(&adapter->pdev->dev); | ||
| 4675 | } else { | 4678 | } else { |
| 4676 | /* Do not read PHY registers if link is not up | 4679 | /* Do not read PHY registers if link is not up |
| 4677 | * Set values to typical power-on defaults | 4680 | * Set values to typical power-on defaults |
| @@ -5887,8 +5890,7 @@ release: | |||
| 5887 | return retval; | 5890 | return retval; |
| 5888 | } | 5891 | } |
| 5889 | 5892 | ||
| 5890 | static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake, | 5893 | static int __e1000_shutdown(struct pci_dev *pdev, bool runtime) |
| 5891 | bool runtime) | ||
| 5892 | { | 5894 | { |
| 5893 | struct net_device *netdev = pci_get_drvdata(pdev); | 5895 | struct net_device *netdev = pci_get_drvdata(pdev); |
| 5894 | struct e1000_adapter *adapter = netdev_priv(netdev); | 5896 | struct e1000_adapter *adapter = netdev_priv(netdev); |
| @@ -5912,10 +5914,6 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake, | |||
| 5912 | } | 5914 | } |
| 5913 | e1000e_reset_interrupt_capability(adapter); | 5915 | e1000e_reset_interrupt_capability(adapter); |
| 5914 | 5916 | ||
| 5915 | retval = pci_save_state(pdev); | ||
| 5916 | if (retval) | ||
| 5917 | return retval; | ||
| 5918 | |||
| 5919 | status = er32(STATUS); | 5917 | status = er32(STATUS); |
| 5920 | if (status & E1000_STATUS_LU) | 5918 | if (status & E1000_STATUS_LU) |
| 5921 | wufc &= ~E1000_WUFC_LNKC; | 5919 | wufc &= ~E1000_WUFC_LNKC; |
| @@ -5971,13 +5969,6 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake, | |||
| 5971 | ew32(WUFC, 0); | 5969 | ew32(WUFC, 0); |
| 5972 | } | 5970 | } |
| 5973 | 5971 | ||
| 5974 | *enable_wake = !!wufc; | ||
| 5975 | |||
| 5976 | /* make sure adapter isn't asleep if manageability is enabled */ | ||
| 5977 | if ((adapter->flags & FLAG_MNG_PT_ENABLED) || | ||
| 5978 | (hw->mac.ops.check_mng_mode(hw))) | ||
| 5979 | *enable_wake = true; | ||
| 5980 | |||
| 5981 | if (adapter->hw.phy.type == e1000_phy_igp_3) | 5972 | if (adapter->hw.phy.type == e1000_phy_igp_3) |
| 5982 | e1000e_igp3_phy_powerdown_workaround_ich8lan(&adapter->hw); | 5973 | e1000e_igp3_phy_powerdown_workaround_ich8lan(&adapter->hw); |
| 5983 | 5974 | ||
| @@ -5986,27 +5977,7 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake, | |||
| 5986 | */ | 5977 | */ |
| 5987 | e1000e_release_hw_control(adapter); | 5978 | e1000e_release_hw_control(adapter); |
| 5988 | 5979 | ||
| 5989 | pci_disable_device(pdev); | 5980 | pci_clear_master(pdev); |
| 5990 | |||
| 5991 | return 0; | ||
| 5992 | } | ||
| 5993 | |||
| 5994 | static void e1000_power_off(struct pci_dev *pdev, bool sleep, bool wake) | ||
| 5995 | { | ||
| 5996 | if (sleep && wake) { | ||
| 5997 | pci_prepare_to_sleep(pdev); | ||
| 5998 | return; | ||
| 5999 | } | ||
| 6000 | |||
| 6001 | pci_wake_from_d3(pdev, wake); | ||
| 6002 | pci_set_power_state(pdev, PCI_D3hot); | ||
| 6003 | } | ||
| 6004 | |||
| 6005 | static void e1000_complete_shutdown(struct pci_dev *pdev, bool sleep, | ||
| 6006 | bool wake) | ||
| 6007 | { | ||
| 6008 | struct net_device *netdev = pci_get_drvdata(pdev); | ||
| 6009 | struct e1000_adapter *adapter = netdev_priv(netdev); | ||
| 6010 | 5981 | ||
| 6011 | /* The pci-e switch on some quad port adapters will report a | 5982 | /* The pci-e switch on some quad port adapters will report a |
| 6012 | * correctable error when the MAC transitions from D0 to D3. To | 5983 | * correctable error when the MAC transitions from D0 to D3. To |
| @@ -6021,12 +5992,13 @@ static void e1000_complete_shutdown(struct pci_dev *pdev, bool sleep, | |||
| 6021 | pcie_capability_write_word(us_dev, PCI_EXP_DEVCTL, | 5992 | pcie_capability_write_word(us_dev, PCI_EXP_DEVCTL, |
| 6022 | (devctl & ~PCI_EXP_DEVCTL_CERE)); | 5993 | (devctl & ~PCI_EXP_DEVCTL_CERE)); |
| 6023 | 5994 | ||
| 6024 | e1000_power_off(pdev, sleep, wake); | 5995 | pci_save_state(pdev); |
| 5996 | pci_prepare_to_sleep(pdev); | ||
| 6025 | 5997 | ||
| 6026 | pcie_capability_write_word(us_dev, PCI_EXP_DEVCTL, devctl); | 5998 | pcie_capability_write_word(us_dev, PCI_EXP_DEVCTL, devctl); |
| 6027 | } else { | ||
| 6028 | e1000_power_off(pdev, sleep, wake); | ||
| 6029 | } | 5999 | } |
| 6000 | |||
| 6001 | return 0; | ||
| 6030 | } | 6002 | } |
| 6031 | 6003 | ||
| 6032 | #ifdef CONFIG_PCIEASPM | 6004 | #ifdef CONFIG_PCIEASPM |
| @@ -6084,9 +6056,7 @@ static int __e1000_resume(struct pci_dev *pdev) | |||
| 6084 | if (aspm_disable_flag) | 6056 | if (aspm_disable_flag) |
| 6085 | e1000e_disable_aspm(pdev, aspm_disable_flag); | 6057 | e1000e_disable_aspm(pdev, aspm_disable_flag); |
| 6086 | 6058 | ||
| 6087 | pci_set_power_state(pdev, PCI_D0); | 6059 | pci_set_master(pdev); |
| 6088 | pci_restore_state(pdev); | ||
| 6089 | pci_save_state(pdev); | ||
| 6090 | 6060 | ||
| 6091 | e1000e_set_interrupt_capability(adapter); | 6061 | e1000e_set_interrupt_capability(adapter); |
| 6092 | if (netif_running(netdev)) { | 6062 | if (netif_running(netdev)) { |
| @@ -6152,14 +6122,8 @@ static int __e1000_resume(struct pci_dev *pdev) | |||
| 6152 | static int e1000_suspend(struct device *dev) | 6122 | static int e1000_suspend(struct device *dev) |
| 6153 | { | 6123 | { |
| 6154 | struct pci_dev *pdev = to_pci_dev(dev); | 6124 | struct pci_dev *pdev = to_pci_dev(dev); |
| 6155 | int retval; | ||
| 6156 | bool wake; | ||
| 6157 | |||
| 6158 | retval = __e1000_shutdown(pdev, &wake, false); | ||
| 6159 | if (!retval) | ||
| 6160 | e1000_complete_shutdown(pdev, true, wake); | ||
| 6161 | 6125 | ||
| 6162 | return retval; | 6126 | return __e1000_shutdown(pdev, false); |
| 6163 | } | 6127 | } |
| 6164 | 6128 | ||
| 6165 | static int e1000_resume(struct device *dev) | 6129 | static int e1000_resume(struct device *dev) |
| @@ -6182,13 +6146,10 @@ static int e1000_runtime_suspend(struct device *dev) | |||
| 6182 | struct net_device *netdev = pci_get_drvdata(pdev); | 6146 | struct net_device *netdev = pci_get_drvdata(pdev); |
| 6183 | struct e1000_adapter *adapter = netdev_priv(netdev); | 6147 | struct e1000_adapter *adapter = netdev_priv(netdev); |
| 6184 | 6148 | ||
| 6185 | if (e1000e_pm_ready(adapter)) { | 6149 | if (!e1000e_pm_ready(adapter)) |
| 6186 | bool wake; | 6150 | return 0; |
| 6187 | |||
| 6188 | __e1000_shutdown(pdev, &wake, true); | ||
| 6189 | } | ||
| 6190 | 6151 | ||
| 6191 | return 0; | 6152 | return __e1000_shutdown(pdev, true); |
| 6192 | } | 6153 | } |
| 6193 | 6154 | ||
| 6194 | static int e1000_idle(struct device *dev) | 6155 | static int e1000_idle(struct device *dev) |
| @@ -6226,12 +6187,7 @@ static int e1000_runtime_resume(struct device *dev) | |||
| 6226 | 6187 | ||
| 6227 | static void e1000_shutdown(struct pci_dev *pdev) | 6188 | static void e1000_shutdown(struct pci_dev *pdev) |
| 6228 | { | 6189 | { |
| 6229 | bool wake = false; | 6190 | __e1000_shutdown(pdev, false); |
| 6230 | |||
| 6231 | __e1000_shutdown(pdev, &wake, false); | ||
| 6232 | |||
| 6233 | if (system_state == SYSTEM_POWER_OFF) | ||
| 6234 | e1000_complete_shutdown(pdev, false, wake); | ||
| 6235 | } | 6191 | } |
| 6236 | 6192 | ||
| 6237 | #ifdef CONFIG_NET_POLL_CONTROLLER | 6193 | #ifdef CONFIG_NET_POLL_CONTROLLER |
| @@ -6352,9 +6308,9 @@ static pci_ers_result_t e1000_io_slot_reset(struct pci_dev *pdev) | |||
| 6352 | "Cannot re-enable PCI device after reset.\n"); | 6308 | "Cannot re-enable PCI device after reset.\n"); |
| 6353 | result = PCI_ERS_RESULT_DISCONNECT; | 6309 | result = PCI_ERS_RESULT_DISCONNECT; |
| 6354 | } else { | 6310 | } else { |
| 6355 | pci_set_master(pdev); | ||
| 6356 | pdev->state_saved = true; | 6311 | pdev->state_saved = true; |
| 6357 | pci_restore_state(pdev); | 6312 | pci_restore_state(pdev); |
| 6313 | pci_set_master(pdev); | ||
| 6358 | 6314 | ||
| 6359 | pci_enable_wake(pdev, PCI_D3hot, 0); | 6315 | pci_enable_wake(pdev, PCI_D3hot, 0); |
| 6360 | pci_enable_wake(pdev, PCI_D3cold, 0); | 6316 | pci_enable_wake(pdev, PCI_D3cold, 0); |
| @@ -6783,7 +6739,11 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 6783 | 6739 | ||
| 6784 | /* initialize the wol settings based on the eeprom settings */ | 6740 | /* initialize the wol settings based on the eeprom settings */ |
| 6785 | adapter->wol = adapter->eeprom_wol; | 6741 | adapter->wol = adapter->eeprom_wol; |
| 6786 | device_set_wakeup_enable(&adapter->pdev->dev, adapter->wol); | 6742 | |
| 6743 | /* make sure adapter isn't asleep if manageability is enabled */ | ||
| 6744 | if (adapter->wol || (adapter->flags & FLAG_MNG_PT_ENABLED) || | ||
| 6745 | (hw->mac.ops.check_mng_mode(hw))) | ||
| 6746 | device_wakeup_enable(&pdev->dev); | ||
| 6787 | 6747 | ||
| 6788 | /* save off EEPROM version number */ | 6748 | /* save off EEPROM version number */ |
| 6789 | e1000_read_nvm(&adapter->hw, 5, 1, &adapter->eeprom_vers); | 6749 | e1000_read_nvm(&adapter->hw, 5, 1, &adapter->eeprom_vers); |
diff --git a/drivers/net/ethernet/intel/e1000e/regs.h b/drivers/net/ethernet/intel/e1000e/regs.h index 794fe1497666..a7e6a3e37257 100644 --- a/drivers/net/ethernet/intel/e1000e/regs.h +++ b/drivers/net/ethernet/intel/e1000e/regs.h | |||
| @@ -42,6 +42,7 @@ | |||
| 42 | #define E1000_FEXTNVM 0x00028 /* Future Extended NVM - RW */ | 42 | #define E1000_FEXTNVM 0x00028 /* Future Extended NVM - RW */ |
| 43 | #define E1000_FEXTNVM3 0x0003C /* Future Extended NVM 3 - RW */ | 43 | #define E1000_FEXTNVM3 0x0003C /* Future Extended NVM 3 - RW */ |
| 44 | #define E1000_FEXTNVM4 0x00024 /* Future Extended NVM 4 - RW */ | 44 | #define E1000_FEXTNVM4 0x00024 /* Future Extended NVM 4 - RW */ |
| 45 | #define E1000_FEXTNVM6 0x00010 /* Future Extended NVM 6 - RW */ | ||
| 45 | #define E1000_FEXTNVM7 0x000E4 /* Future Extended NVM 7 - RW */ | 46 | #define E1000_FEXTNVM7 0x000E4 /* Future Extended NVM 7 - RW */ |
| 46 | #define E1000_FCT 0x00030 /* Flow Control Type - RW */ | 47 | #define E1000_FCT 0x00030 /* Flow Control Type - RW */ |
| 47 | #define E1000_VET 0x00038 /* VLAN Ether Type - RW */ | 48 | #define E1000_VET 0x00038 /* VLAN Ether Type - RW */ |
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index 84e7e0909def..b64542acfa34 100644 --- a/drivers/net/ethernet/intel/igb/e1000_82575.c +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c | |||
| @@ -1361,11 +1361,16 @@ static s32 igb_setup_copper_link_82575(struct e1000_hw *hw) | |||
| 1361 | switch (hw->phy.type) { | 1361 | switch (hw->phy.type) { |
| 1362 | case e1000_phy_i210: | 1362 | case e1000_phy_i210: |
| 1363 | case e1000_phy_m88: | 1363 | case e1000_phy_m88: |
| 1364 | if (hw->phy.id == I347AT4_E_PHY_ID || | 1364 | switch (hw->phy.id) { |
| 1365 | hw->phy.id == M88E1112_E_PHY_ID) | 1365 | case I347AT4_E_PHY_ID: |
| 1366 | case M88E1112_E_PHY_ID: | ||
| 1367 | case I210_I_PHY_ID: | ||
| 1366 | ret_val = igb_copper_link_setup_m88_gen2(hw); | 1368 | ret_val = igb_copper_link_setup_m88_gen2(hw); |
| 1367 | else | 1369 | break; |
| 1370 | default: | ||
| 1368 | ret_val = igb_copper_link_setup_m88(hw); | 1371 | ret_val = igb_copper_link_setup_m88(hw); |
| 1372 | break; | ||
| 1373 | } | ||
| 1369 | break; | 1374 | break; |
| 1370 | case e1000_phy_igp_3: | 1375 | case e1000_phy_igp_3: |
| 1371 | ret_val = igb_copper_link_setup_igp(hw); | 1376 | ret_val = igb_copper_link_setup_igp(hw); |
diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h index d27edbc63923..25151401c2ab 100644 --- a/drivers/net/ethernet/intel/igb/igb.h +++ b/drivers/net/ethernet/intel/igb/igb.h | |||
| @@ -447,7 +447,7 @@ struct igb_adapter { | |||
| 447 | #endif | 447 | #endif |
| 448 | struct i2c_algo_bit_data i2c_algo; | 448 | struct i2c_algo_bit_data i2c_algo; |
| 449 | struct i2c_adapter i2c_adap; | 449 | struct i2c_adapter i2c_adap; |
| 450 | struct igb_i2c_client_list *i2c_clients; | 450 | struct i2c_client *i2c_client; |
| 451 | }; | 451 | }; |
| 452 | 452 | ||
| 453 | #define IGB_FLAG_HAS_MSI (1 << 0) | 453 | #define IGB_FLAG_HAS_MSI (1 << 0) |
diff --git a/drivers/net/ethernet/intel/igb/igb_hwmon.c b/drivers/net/ethernet/intel/igb/igb_hwmon.c index 0a9b073d0b03..4623502054d5 100644 --- a/drivers/net/ethernet/intel/igb/igb_hwmon.c +++ b/drivers/net/ethernet/intel/igb/igb_hwmon.c | |||
| @@ -39,6 +39,10 @@ | |||
| 39 | #include <linux/pci.h> | 39 | #include <linux/pci.h> |
| 40 | 40 | ||
| 41 | #ifdef CONFIG_IGB_HWMON | 41 | #ifdef CONFIG_IGB_HWMON |
| 42 | struct i2c_board_info i350_sensor_info = { | ||
| 43 | I2C_BOARD_INFO("i350bb", (0Xf8 >> 1)), | ||
| 44 | }; | ||
| 45 | |||
| 42 | /* hwmon callback functions */ | 46 | /* hwmon callback functions */ |
| 43 | static ssize_t igb_hwmon_show_location(struct device *dev, | 47 | static ssize_t igb_hwmon_show_location(struct device *dev, |
| 44 | struct device_attribute *attr, | 48 | struct device_attribute *attr, |
| @@ -188,6 +192,7 @@ int igb_sysfs_init(struct igb_adapter *adapter) | |||
| 188 | unsigned int i; | 192 | unsigned int i; |
| 189 | int n_attrs; | 193 | int n_attrs; |
| 190 | int rc = 0; | 194 | int rc = 0; |
| 195 | struct i2c_client *client = NULL; | ||
| 191 | 196 | ||
| 192 | /* If this method isn't defined we don't support thermals */ | 197 | /* If this method isn't defined we don't support thermals */ |
| 193 | if (adapter->hw.mac.ops.init_thermal_sensor_thresh == NULL) | 198 | if (adapter->hw.mac.ops.init_thermal_sensor_thresh == NULL) |
| @@ -198,6 +203,15 @@ int igb_sysfs_init(struct igb_adapter *adapter) | |||
| 198 | if (rc) | 203 | if (rc) |
| 199 | goto exit; | 204 | goto exit; |
| 200 | 205 | ||
| 206 | /* init i2c_client */ | ||
| 207 | client = i2c_new_device(&adapter->i2c_adap, &i350_sensor_info); | ||
| 208 | if (client == NULL) { | ||
| 209 | dev_info(&adapter->pdev->dev, | ||
| 210 | "Failed to create new i2c device..\n"); | ||
| 211 | goto exit; | ||
| 212 | } | ||
| 213 | adapter->i2c_client = client; | ||
| 214 | |||
| 201 | /* Allocation space for max attributes | 215 | /* Allocation space for max attributes |
| 202 | * max num sensors * values (loc, temp, max, caution) | 216 | * max num sensors * values (loc, temp, max, caution) |
| 203 | */ | 217 | */ |
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index ed79a1c53b59..4dbd62968c7a 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c | |||
| @@ -1923,10 +1923,6 @@ void igb_set_fw_version(struct igb_adapter *adapter) | |||
| 1923 | return; | 1923 | return; |
| 1924 | } | 1924 | } |
| 1925 | 1925 | ||
| 1926 | static const struct i2c_board_info i350_sensor_info = { | ||
| 1927 | I2C_BOARD_INFO("i350bb", 0Xf8), | ||
| 1928 | }; | ||
| 1929 | |||
| 1930 | /* igb_init_i2c - Init I2C interface | 1926 | /* igb_init_i2c - Init I2C interface |
| 1931 | * @adapter: pointer to adapter structure | 1927 | * @adapter: pointer to adapter structure |
| 1932 | * | 1928 | * |
| @@ -6227,13 +6223,6 @@ static struct sk_buff *igb_build_rx_buffer(struct igb_ring *rx_ring, | |||
| 6227 | /* If we spanned a buffer we have a huge mess so test for it */ | 6223 | /* If we spanned a buffer we have a huge mess so test for it */ |
| 6228 | BUG_ON(unlikely(!igb_test_staterr(rx_desc, E1000_RXD_STAT_EOP))); | 6224 | BUG_ON(unlikely(!igb_test_staterr(rx_desc, E1000_RXD_STAT_EOP))); |
| 6229 | 6225 | ||
| 6230 | /* Guarantee this function can be used by verifying buffer sizes */ | ||
| 6231 | BUILD_BUG_ON(SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + | ||
| 6232 | NET_IP_ALIGN + | ||
| 6233 | IGB_TS_HDR_LEN + | ||
| 6234 | ETH_FRAME_LEN + | ||
| 6235 | ETH_FCS_LEN)); | ||
| 6236 | |||
| 6237 | rx_buffer = &rx_ring->rx_buffer_info[rx_ring->next_to_clean]; | 6226 | rx_buffer = &rx_ring->rx_buffer_info[rx_ring->next_to_clean]; |
| 6238 | page = rx_buffer->page; | 6227 | page = rx_buffer->page; |
| 6239 | prefetchw(page); | 6228 | prefetchw(page); |
| @@ -7724,67 +7713,6 @@ static void igb_init_dmac(struct igb_adapter *adapter, u32 pba) | |||
| 7724 | } | 7713 | } |
| 7725 | } | 7714 | } |
| 7726 | 7715 | ||
| 7727 | static DEFINE_SPINLOCK(i2c_clients_lock); | ||
| 7728 | |||
| 7729 | /* igb_get_i2c_client - returns matching client | ||
| 7730 | * in adapters's client list. | ||
| 7731 | * @adapter: adapter struct | ||
| 7732 | * @dev_addr: device address of i2c needed. | ||
| 7733 | */ | ||
| 7734 | static struct i2c_client * | ||
| 7735 | igb_get_i2c_client(struct igb_adapter *adapter, u8 dev_addr) | ||
| 7736 | { | ||
| 7737 | ulong flags; | ||
| 7738 | struct igb_i2c_client_list *client_list; | ||
| 7739 | struct i2c_client *client = NULL; | ||
| 7740 | struct i2c_board_info client_info = { | ||
| 7741 | I2C_BOARD_INFO("igb", 0x00), | ||
| 7742 | }; | ||
| 7743 | |||
| 7744 | spin_lock_irqsave(&i2c_clients_lock, flags); | ||
| 7745 | client_list = adapter->i2c_clients; | ||
| 7746 | |||
| 7747 | /* See if we already have an i2c_client */ | ||
| 7748 | while (client_list) { | ||
| 7749 | if (client_list->client->addr == (dev_addr >> 1)) { | ||
| 7750 | client = client_list->client; | ||
| 7751 | goto exit; | ||
| 7752 | } else { | ||
| 7753 | client_list = client_list->next; | ||
| 7754 | } | ||
| 7755 | } | ||
| 7756 | |||
| 7757 | /* no client_list found, create a new one */ | ||
| 7758 | client_list = kzalloc(sizeof(*client_list), GFP_ATOMIC); | ||
| 7759 | if (client_list == NULL) | ||
| 7760 | goto exit; | ||
| 7761 | |||
| 7762 | /* dev_addr passed to us is left-shifted by 1 bit | ||
| 7763 | * i2c_new_device call expects it to be flush to the right. | ||
| 7764 | */ | ||
| 7765 | client_info.addr = dev_addr >> 1; | ||
| 7766 | client_info.platform_data = adapter; | ||
| 7767 | client_list->client = i2c_new_device(&adapter->i2c_adap, &client_info); | ||
| 7768 | if (client_list->client == NULL) { | ||
| 7769 | dev_info(&adapter->pdev->dev, | ||
| 7770 | "Failed to create new i2c device..\n"); | ||
| 7771 | goto err_no_client; | ||
| 7772 | } | ||
| 7773 | |||
| 7774 | /* insert new client at head of list */ | ||
| 7775 | client_list->next = adapter->i2c_clients; | ||
| 7776 | adapter->i2c_clients = client_list; | ||
| 7777 | |||
| 7778 | client = client_list->client; | ||
| 7779 | goto exit; | ||
| 7780 | |||
| 7781 | err_no_client: | ||
| 7782 | kfree(client_list); | ||
| 7783 | exit: | ||
| 7784 | spin_unlock_irqrestore(&i2c_clients_lock, flags); | ||
| 7785 | return client; | ||
| 7786 | } | ||
| 7787 | |||
| 7788 | /* igb_read_i2c_byte - Reads 8 bit word over I2C | 7716 | /* igb_read_i2c_byte - Reads 8 bit word over I2C |
| 7789 | * @hw: pointer to hardware structure | 7717 | * @hw: pointer to hardware structure |
| 7790 | * @byte_offset: byte offset to read | 7718 | * @byte_offset: byte offset to read |
| @@ -7798,7 +7726,7 @@ s32 igb_read_i2c_byte(struct e1000_hw *hw, u8 byte_offset, | |||
| 7798 | u8 dev_addr, u8 *data) | 7726 | u8 dev_addr, u8 *data) |
| 7799 | { | 7727 | { |
| 7800 | struct igb_adapter *adapter = container_of(hw, struct igb_adapter, hw); | 7728 | struct igb_adapter *adapter = container_of(hw, struct igb_adapter, hw); |
| 7801 | struct i2c_client *this_client = igb_get_i2c_client(adapter, dev_addr); | 7729 | struct i2c_client *this_client = adapter->i2c_client; |
| 7802 | s32 status; | 7730 | s32 status; |
| 7803 | u16 swfw_mask = 0; | 7731 | u16 swfw_mask = 0; |
| 7804 | 7732 | ||
| @@ -7835,7 +7763,7 @@ s32 igb_write_i2c_byte(struct e1000_hw *hw, u8 byte_offset, | |||
| 7835 | u8 dev_addr, u8 data) | 7763 | u8 dev_addr, u8 data) |
| 7836 | { | 7764 | { |
| 7837 | struct igb_adapter *adapter = container_of(hw, struct igb_adapter, hw); | 7765 | struct igb_adapter *adapter = container_of(hw, struct igb_adapter, hw); |
| 7838 | struct i2c_client *this_client = igb_get_i2c_client(adapter, dev_addr); | 7766 | struct i2c_client *this_client = adapter->i2c_client; |
| 7839 | s32 status; | 7767 | s32 status; |
| 7840 | u16 swfw_mask = E1000_SWFW_PHY0_SM; | 7768 | u16 swfw_mask = E1000_SWFW_PHY0_SM; |
| 7841 | 7769 | ||
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 29140502b71a..6562c736a1d8 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
| @@ -1081,6 +1081,45 @@ static void txq_set_fixed_prio_mode(struct tx_queue *txq) | |||
| 1081 | 1081 | ||
| 1082 | 1082 | ||
| 1083 | /* mii management interface *************************************************/ | 1083 | /* mii management interface *************************************************/ |
| 1084 | static void mv643xx_adjust_pscr(struct mv643xx_eth_private *mp) | ||
| 1085 | { | ||
| 1086 | u32 pscr = rdlp(mp, PORT_SERIAL_CONTROL); | ||
| 1087 | u32 autoneg_disable = FORCE_LINK_PASS | | ||
| 1088 | DISABLE_AUTO_NEG_SPEED_GMII | | ||
| 1089 | DISABLE_AUTO_NEG_FOR_FLOW_CTRL | | ||
| 1090 | DISABLE_AUTO_NEG_FOR_DUPLEX; | ||
| 1091 | |||
| 1092 | if (mp->phy->autoneg == AUTONEG_ENABLE) { | ||
| 1093 | /* enable auto negotiation */ | ||
| 1094 | pscr &= ~autoneg_disable; | ||
| 1095 | goto out_write; | ||
| 1096 | } | ||
| 1097 | |||
| 1098 | pscr |= autoneg_disable; | ||
| 1099 | |||
| 1100 | if (mp->phy->speed == SPEED_1000) { | ||
| 1101 | /* force gigabit, half duplex not supported */ | ||
| 1102 | pscr |= SET_GMII_SPEED_TO_1000; | ||
| 1103 | pscr |= SET_FULL_DUPLEX_MODE; | ||
| 1104 | goto out_write; | ||
| 1105 | } | ||
| 1106 | |||
| 1107 | pscr &= ~SET_GMII_SPEED_TO_1000; | ||
| 1108 | |||
| 1109 | if (mp->phy->speed == SPEED_100) | ||
| 1110 | pscr |= SET_MII_SPEED_TO_100; | ||
| 1111 | else | ||
| 1112 | pscr &= ~SET_MII_SPEED_TO_100; | ||
| 1113 | |||
| 1114 | if (mp->phy->duplex == DUPLEX_FULL) | ||
| 1115 | pscr |= SET_FULL_DUPLEX_MODE; | ||
| 1116 | else | ||
| 1117 | pscr &= ~SET_FULL_DUPLEX_MODE; | ||
| 1118 | |||
| 1119 | out_write: | ||
| 1120 | wrlp(mp, PORT_SERIAL_CONTROL, pscr); | ||
| 1121 | } | ||
| 1122 | |||
| 1084 | static irqreturn_t mv643xx_eth_err_irq(int irq, void *dev_id) | 1123 | static irqreturn_t mv643xx_eth_err_irq(int irq, void *dev_id) |
| 1085 | { | 1124 | { |
| 1086 | struct mv643xx_eth_shared_private *msp = dev_id; | 1125 | struct mv643xx_eth_shared_private *msp = dev_id; |
| @@ -1499,6 +1538,7 @@ static int | |||
| 1499 | mv643xx_eth_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 1538 | mv643xx_eth_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
| 1500 | { | 1539 | { |
| 1501 | struct mv643xx_eth_private *mp = netdev_priv(dev); | 1540 | struct mv643xx_eth_private *mp = netdev_priv(dev); |
| 1541 | int ret; | ||
| 1502 | 1542 | ||
| 1503 | if (mp->phy == NULL) | 1543 | if (mp->phy == NULL) |
| 1504 | return -EINVAL; | 1544 | return -EINVAL; |
| @@ -1508,7 +1548,10 @@ mv643xx_eth_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) | |||
| 1508 | */ | 1548 | */ |
| 1509 | cmd->advertising &= ~ADVERTISED_1000baseT_Half; | 1549 | cmd->advertising &= ~ADVERTISED_1000baseT_Half; |
| 1510 | 1550 | ||
| 1511 | return phy_ethtool_sset(mp->phy, cmd); | 1551 | ret = phy_ethtool_sset(mp->phy, cmd); |
| 1552 | if (!ret) | ||
| 1553 | mv643xx_adjust_pscr(mp); | ||
| 1554 | return ret; | ||
| 1512 | } | 1555 | } |
| 1513 | 1556 | ||
| 1514 | static void mv643xx_eth_get_drvinfo(struct net_device *dev, | 1557 | static void mv643xx_eth_get_drvinfo(struct net_device *dev, |
| @@ -2442,11 +2485,15 @@ static int mv643xx_eth_stop(struct net_device *dev) | |||
| 2442 | static int mv643xx_eth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | 2485 | static int mv643xx_eth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) |
| 2443 | { | 2486 | { |
| 2444 | struct mv643xx_eth_private *mp = netdev_priv(dev); | 2487 | struct mv643xx_eth_private *mp = netdev_priv(dev); |
| 2488 | int ret; | ||
| 2445 | 2489 | ||
| 2446 | if (mp->phy != NULL) | 2490 | if (mp->phy == NULL) |
| 2447 | return phy_mii_ioctl(mp->phy, ifr, cmd); | 2491 | return -ENOTSUPP; |
| 2448 | 2492 | ||
| 2449 | return -EOPNOTSUPP; | 2493 | ret = phy_mii_ioctl(mp->phy, ifr, cmd); |
| 2494 | if (!ret) | ||
| 2495 | mv643xx_adjust_pscr(mp); | ||
| 2496 | return ret; | ||
| 2450 | } | 2497 | } |
| 2451 | 2498 | ||
| 2452 | static int mv643xx_eth_change_mtu(struct net_device *dev, int new_mtu) | 2499 | static int mv643xx_eth_change_mtu(struct net_device *dev, int new_mtu) |
diff --git a/drivers/net/ethernet/mellanox/mlx4/cq.c b/drivers/net/ethernet/mellanox/mlx4/cq.c index 7e64033d7de3..0706623cfb96 100644 --- a/drivers/net/ethernet/mellanox/mlx4/cq.c +++ b/drivers/net/ethernet/mellanox/mlx4/cq.c | |||
| @@ -226,7 +226,7 @@ void __mlx4_cq_free_icm(struct mlx4_dev *dev, int cqn) | |||
| 226 | 226 | ||
| 227 | static void mlx4_cq_free_icm(struct mlx4_dev *dev, int cqn) | 227 | static void mlx4_cq_free_icm(struct mlx4_dev *dev, int cqn) |
| 228 | { | 228 | { |
| 229 | u64 in_param; | 229 | u64 in_param = 0; |
| 230 | int err; | 230 | int err; |
| 231 | 231 | ||
| 232 | if (mlx4_is_mfunc(dev)) { | 232 | if (mlx4_is_mfunc(dev)) { |
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index bb4d8d99f36d..995d4b6d5c1e 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c | |||
| @@ -565,34 +565,38 @@ static void mlx4_en_put_qp(struct mlx4_en_priv *priv) | |||
| 565 | struct mlx4_en_dev *mdev = priv->mdev; | 565 | struct mlx4_en_dev *mdev = priv->mdev; |
| 566 | struct mlx4_dev *dev = mdev->dev; | 566 | struct mlx4_dev *dev = mdev->dev; |
| 567 | int qpn = priv->base_qpn; | 567 | int qpn = priv->base_qpn; |
| 568 | u64 mac = mlx4_en_mac_to_u64(priv->dev->dev_addr); | 568 | u64 mac; |
| 569 | |||
| 570 | en_dbg(DRV, priv, "Registering MAC: %pM for deleting\n", | ||
| 571 | priv->dev->dev_addr); | ||
| 572 | mlx4_unregister_mac(dev, priv->port, mac); | ||
| 573 | 569 | ||
| 574 | if (dev->caps.steering_mode != MLX4_STEERING_MODE_A0) { | 570 | if (dev->caps.steering_mode == MLX4_STEERING_MODE_A0) { |
| 571 | mac = mlx4_en_mac_to_u64(priv->dev->dev_addr); | ||
| 572 | en_dbg(DRV, priv, "Registering MAC: %pM for deleting\n", | ||
| 573 | priv->dev->dev_addr); | ||
| 574 | mlx4_unregister_mac(dev, priv->port, mac); | ||
| 575 | } else { | ||
| 575 | struct mlx4_mac_entry *entry; | 576 | struct mlx4_mac_entry *entry; |
| 576 | struct hlist_node *tmp; | 577 | struct hlist_node *tmp; |
| 577 | struct hlist_head *bucket; | 578 | struct hlist_head *bucket; |
| 578 | unsigned int mac_hash; | 579 | unsigned int i; |
| 579 | 580 | ||
| 580 | mac_hash = priv->dev->dev_addr[MLX4_EN_MAC_HASH_IDX]; | 581 | for (i = 0; i < MLX4_EN_MAC_HASH_SIZE; ++i) { |
| 581 | bucket = &priv->mac_hash[mac_hash]; | 582 | bucket = &priv->mac_hash[i]; |
| 582 | hlist_for_each_entry_safe(entry, tmp, bucket, hlist) { | 583 | hlist_for_each_entry_safe(entry, tmp, bucket, hlist) { |
| 583 | if (ether_addr_equal_64bits(entry->mac, | 584 | mac = mlx4_en_mac_to_u64(entry->mac); |
| 584 | priv->dev->dev_addr)) { | 585 | en_dbg(DRV, priv, "Registering MAC: %pM for deleting\n", |
| 585 | en_dbg(DRV, priv, "Releasing qp: port %d, MAC %pM, qpn %d\n", | 586 | entry->mac); |
| 586 | priv->port, priv->dev->dev_addr, qpn); | ||
| 587 | mlx4_en_uc_steer_release(priv, entry->mac, | 587 | mlx4_en_uc_steer_release(priv, entry->mac, |
| 588 | qpn, entry->reg_id); | 588 | qpn, entry->reg_id); |
| 589 | mlx4_qp_release_range(dev, qpn, 1); | ||
| 590 | 589 | ||
| 590 | mlx4_unregister_mac(dev, priv->port, mac); | ||
| 591 | hlist_del_rcu(&entry->hlist); | 591 | hlist_del_rcu(&entry->hlist); |
| 592 | kfree_rcu(entry, rcu); | 592 | kfree_rcu(entry, rcu); |
| 593 | break; | ||
| 594 | } | 593 | } |
| 595 | } | 594 | } |
| 595 | |||
| 596 | en_dbg(DRV, priv, "Releasing qp: port %d, qpn %d\n", | ||
| 597 | priv->port, qpn); | ||
| 598 | mlx4_qp_release_range(dev, qpn, 1); | ||
| 599 | priv->flags &= ~MLX4_EN_FLAG_FORCE_PROMISC; | ||
| 596 | } | 600 | } |
| 597 | } | 601 | } |
| 598 | 602 | ||
| @@ -650,28 +654,10 @@ u64 mlx4_en_mac_to_u64(u8 *addr) | |||
| 650 | return mac; | 654 | return mac; |
| 651 | } | 655 | } |
| 652 | 656 | ||
| 653 | static int mlx4_en_set_mac(struct net_device *dev, void *addr) | 657 | static int mlx4_en_do_set_mac(struct mlx4_en_priv *priv) |
| 654 | { | ||
| 655 | struct mlx4_en_priv *priv = netdev_priv(dev); | ||
| 656 | struct mlx4_en_dev *mdev = priv->mdev; | ||
| 657 | struct sockaddr *saddr = addr; | ||
| 658 | |||
| 659 | if (!is_valid_ether_addr(saddr->sa_data)) | ||
| 660 | return -EADDRNOTAVAIL; | ||
| 661 | |||
| 662 | memcpy(dev->dev_addr, saddr->sa_data, ETH_ALEN); | ||
| 663 | queue_work(mdev->workqueue, &priv->mac_task); | ||
| 664 | return 0; | ||
| 665 | } | ||
| 666 | |||
| 667 | static void mlx4_en_do_set_mac(struct work_struct *work) | ||
| 668 | { | 658 | { |
| 669 | struct mlx4_en_priv *priv = container_of(work, struct mlx4_en_priv, | ||
| 670 | mac_task); | ||
| 671 | struct mlx4_en_dev *mdev = priv->mdev; | ||
| 672 | int err = 0; | 659 | int err = 0; |
| 673 | 660 | ||
| 674 | mutex_lock(&mdev->state_lock); | ||
| 675 | if (priv->port_up) { | 661 | if (priv->port_up) { |
| 676 | /* Remove old MAC and insert the new one */ | 662 | /* Remove old MAC and insert the new one */ |
| 677 | err = mlx4_en_replace_mac(priv, priv->base_qpn, | 663 | err = mlx4_en_replace_mac(priv, priv->base_qpn, |
| @@ -683,7 +669,26 @@ static void mlx4_en_do_set_mac(struct work_struct *work) | |||
| 683 | } else | 669 | } else |
| 684 | en_dbg(HW, priv, "Port is down while registering mac, exiting...\n"); | 670 | en_dbg(HW, priv, "Port is down while registering mac, exiting...\n"); |
| 685 | 671 | ||
| 672 | return err; | ||
| 673 | } | ||
| 674 | |||
| 675 | static int mlx4_en_set_mac(struct net_device *dev, void *addr) | ||
| 676 | { | ||
| 677 | struct mlx4_en_priv *priv = netdev_priv(dev); | ||
| 678 | struct mlx4_en_dev *mdev = priv->mdev; | ||
| 679 | struct sockaddr *saddr = addr; | ||
| 680 | int err; | ||
| 681 | |||
| 682 | if (!is_valid_ether_addr(saddr->sa_data)) | ||
| 683 | return -EADDRNOTAVAIL; | ||
| 684 | |||
| 685 | memcpy(dev->dev_addr, saddr->sa_data, ETH_ALEN); | ||
| 686 | |||
| 687 | mutex_lock(&mdev->state_lock); | ||
| 688 | err = mlx4_en_do_set_mac(priv); | ||
| 686 | mutex_unlock(&mdev->state_lock); | 689 | mutex_unlock(&mdev->state_lock); |
| 690 | |||
| 691 | return err; | ||
| 687 | } | 692 | } |
| 688 | 693 | ||
| 689 | static void mlx4_en_clear_list(struct net_device *dev) | 694 | static void mlx4_en_clear_list(struct net_device *dev) |
| @@ -1348,7 +1353,7 @@ static void mlx4_en_do_get_stats(struct work_struct *work) | |||
| 1348 | queue_delayed_work(mdev->workqueue, &priv->stats_task, STATS_DELAY); | 1353 | queue_delayed_work(mdev->workqueue, &priv->stats_task, STATS_DELAY); |
| 1349 | } | 1354 | } |
| 1350 | if (mdev->mac_removed[MLX4_MAX_PORTS + 1 - priv->port]) { | 1355 | if (mdev->mac_removed[MLX4_MAX_PORTS + 1 - priv->port]) { |
| 1351 | queue_work(mdev->workqueue, &priv->mac_task); | 1356 | mlx4_en_do_set_mac(priv); |
| 1352 | mdev->mac_removed[MLX4_MAX_PORTS + 1 - priv->port] = 0; | 1357 | mdev->mac_removed[MLX4_MAX_PORTS + 1 - priv->port] = 0; |
| 1353 | } | 1358 | } |
| 1354 | mutex_unlock(&mdev->state_lock); | 1359 | mutex_unlock(&mdev->state_lock); |
| @@ -1828,9 +1833,11 @@ int mlx4_en_alloc_resources(struct mlx4_en_priv *priv) | |||
| 1828 | } | 1833 | } |
| 1829 | 1834 | ||
| 1830 | #ifdef CONFIG_RFS_ACCEL | 1835 | #ifdef CONFIG_RFS_ACCEL |
| 1831 | priv->dev->rx_cpu_rmap = alloc_irq_cpu_rmap(priv->mdev->dev->caps.comp_pool); | 1836 | if (priv->mdev->dev->caps.comp_pool) { |
| 1832 | if (!priv->dev->rx_cpu_rmap) | 1837 | priv->dev->rx_cpu_rmap = alloc_irq_cpu_rmap(priv->mdev->dev->caps.comp_pool); |
| 1833 | goto err; | 1838 | if (!priv->dev->rx_cpu_rmap) |
| 1839 | goto err; | ||
| 1840 | } | ||
| 1834 | #endif | 1841 | #endif |
| 1835 | 1842 | ||
| 1836 | return 0; | 1843 | return 0; |
| @@ -2078,7 +2085,6 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, | |||
| 2078 | priv->msg_enable = MLX4_EN_MSG_LEVEL; | 2085 | priv->msg_enable = MLX4_EN_MSG_LEVEL; |
| 2079 | spin_lock_init(&priv->stats_lock); | 2086 | spin_lock_init(&priv->stats_lock); |
| 2080 | INIT_WORK(&priv->rx_mode_task, mlx4_en_do_set_rx_mode); | 2087 | INIT_WORK(&priv->rx_mode_task, mlx4_en_do_set_rx_mode); |
| 2081 | INIT_WORK(&priv->mac_task, mlx4_en_do_set_mac); | ||
| 2082 | INIT_WORK(&priv->watchdog_task, mlx4_en_restart); | 2088 | INIT_WORK(&priv->watchdog_task, mlx4_en_restart); |
| 2083 | INIT_WORK(&priv->linkstate_task, mlx4_en_linkstate); | 2089 | INIT_WORK(&priv->linkstate_task, mlx4_en_linkstate); |
| 2084 | INIT_DELAYED_WORK(&priv->stats_task, mlx4_en_do_get_stats); | 2090 | INIT_DELAYED_WORK(&priv->stats_task, mlx4_en_do_get_stats); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 50917eb3013e..f6245579962d 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c | |||
| @@ -787,6 +787,14 @@ int mlx4_QUERY_DEV_CAP_wrapper(struct mlx4_dev *dev, int slave, | |||
| 787 | bmme_flags &= ~MLX4_BMME_FLAG_TYPE_2_WIN; | 787 | bmme_flags &= ~MLX4_BMME_FLAG_TYPE_2_WIN; |
| 788 | MLX4_PUT(outbox->buf, bmme_flags, QUERY_DEV_CAP_BMME_FLAGS_OFFSET); | 788 | MLX4_PUT(outbox->buf, bmme_flags, QUERY_DEV_CAP_BMME_FLAGS_OFFSET); |
| 789 | 789 | ||
| 790 | /* turn off device-managed steering capability if not enabled */ | ||
| 791 | if (dev->caps.steering_mode != MLX4_STEERING_MODE_DEVICE_MANAGED) { | ||
| 792 | MLX4_GET(field, outbox->buf, | ||
| 793 | QUERY_DEV_CAP_FLOW_STEERING_RANGE_EN_OFFSET); | ||
| 794 | field &= 0x7f; | ||
| 795 | MLX4_PUT(outbox->buf, field, | ||
| 796 | QUERY_DEV_CAP_FLOW_STEERING_RANGE_EN_OFFSET); | ||
| 797 | } | ||
| 790 | return 0; | 798 | return 0; |
| 791 | } | 799 | } |
| 792 | 800 | ||
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index d180bc46826a..16abde20e1fc 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c | |||
| @@ -1555,7 +1555,7 @@ void __mlx4_counter_free(struct mlx4_dev *dev, u32 idx) | |||
| 1555 | 1555 | ||
| 1556 | void mlx4_counter_free(struct mlx4_dev *dev, u32 idx) | 1556 | void mlx4_counter_free(struct mlx4_dev *dev, u32 idx) |
| 1557 | { | 1557 | { |
| 1558 | u64 in_param; | 1558 | u64 in_param = 0; |
| 1559 | 1559 | ||
| 1560 | if (mlx4_is_mfunc(dev)) { | 1560 | if (mlx4_is_mfunc(dev)) { |
| 1561 | set_param_l(&in_param, idx); | 1561 | set_param_l(&in_param, idx); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4.h b/drivers/net/ethernet/mellanox/mlx4/mlx4.h index cf883345af88..d738454116a0 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mlx4.h +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4.h | |||
| @@ -1235,7 +1235,7 @@ int mlx4_get_qp_per_mgm(struct mlx4_dev *dev); | |||
| 1235 | 1235 | ||
| 1236 | static inline void set_param_l(u64 *arg, u32 val) | 1236 | static inline void set_param_l(u64 *arg, u32 val) |
| 1237 | { | 1237 | { |
| 1238 | *((u32 *)arg) = val; | 1238 | *arg = (*arg & 0xffffffff00000000ULL) | (u64) val; |
| 1239 | } | 1239 | } |
| 1240 | 1240 | ||
| 1241 | static inline void set_param_h(u64 *arg, u32 val) | 1241 | static inline void set_param_h(u64 *arg, u32 val) |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index c313d7e943a9..f710b7ce0dcb 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | |||
| @@ -509,7 +509,6 @@ struct mlx4_en_priv { | |||
| 509 | struct mlx4_en_cq rx_cq[MAX_RX_RINGS]; | 509 | struct mlx4_en_cq rx_cq[MAX_RX_RINGS]; |
| 510 | struct mlx4_qp drop_qp; | 510 | struct mlx4_qp drop_qp; |
| 511 | struct work_struct rx_mode_task; | 511 | struct work_struct rx_mode_task; |
| 512 | struct work_struct mac_task; | ||
| 513 | struct work_struct watchdog_task; | 512 | struct work_struct watchdog_task; |
| 514 | struct work_struct linkstate_task; | 513 | struct work_struct linkstate_task; |
| 515 | struct delayed_work stats_task; | 514 | struct delayed_work stats_task; |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mr.c b/drivers/net/ethernet/mellanox/mlx4/mr.c index 602ca9bf78e4..f91719a08cba 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mr.c +++ b/drivers/net/ethernet/mellanox/mlx4/mr.c | |||
| @@ -183,7 +183,7 @@ u32 __mlx4_alloc_mtt_range(struct mlx4_dev *dev, int order) | |||
| 183 | 183 | ||
| 184 | static u32 mlx4_alloc_mtt_range(struct mlx4_dev *dev, int order) | 184 | static u32 mlx4_alloc_mtt_range(struct mlx4_dev *dev, int order) |
| 185 | { | 185 | { |
| 186 | u64 in_param; | 186 | u64 in_param = 0; |
| 187 | u64 out_param; | 187 | u64 out_param; |
| 188 | int err; | 188 | int err; |
| 189 | 189 | ||
| @@ -240,7 +240,7 @@ void __mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order) | |||
| 240 | 240 | ||
| 241 | static void mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order) | 241 | static void mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order) |
| 242 | { | 242 | { |
| 243 | u64 in_param; | 243 | u64 in_param = 0; |
| 244 | int err; | 244 | int err; |
| 245 | 245 | ||
| 246 | if (mlx4_is_mfunc(dev)) { | 246 | if (mlx4_is_mfunc(dev)) { |
| @@ -351,7 +351,7 @@ void __mlx4_mpt_release(struct mlx4_dev *dev, u32 index) | |||
| 351 | 351 | ||
| 352 | static void mlx4_mpt_release(struct mlx4_dev *dev, u32 index) | 352 | static void mlx4_mpt_release(struct mlx4_dev *dev, u32 index) |
| 353 | { | 353 | { |
| 354 | u64 in_param; | 354 | u64 in_param = 0; |
| 355 | 355 | ||
| 356 | if (mlx4_is_mfunc(dev)) { | 356 | if (mlx4_is_mfunc(dev)) { |
| 357 | set_param_l(&in_param, index); | 357 | set_param_l(&in_param, index); |
| @@ -374,7 +374,7 @@ int __mlx4_mpt_alloc_icm(struct mlx4_dev *dev, u32 index) | |||
| 374 | 374 | ||
| 375 | static int mlx4_mpt_alloc_icm(struct mlx4_dev *dev, u32 index) | 375 | static int mlx4_mpt_alloc_icm(struct mlx4_dev *dev, u32 index) |
| 376 | { | 376 | { |
| 377 | u64 param; | 377 | u64 param = 0; |
| 378 | 378 | ||
| 379 | if (mlx4_is_mfunc(dev)) { | 379 | if (mlx4_is_mfunc(dev)) { |
| 380 | set_param_l(¶m, index); | 380 | set_param_l(¶m, index); |
| @@ -395,7 +395,7 @@ void __mlx4_mpt_free_icm(struct mlx4_dev *dev, u32 index) | |||
| 395 | 395 | ||
| 396 | static void mlx4_mpt_free_icm(struct mlx4_dev *dev, u32 index) | 396 | static void mlx4_mpt_free_icm(struct mlx4_dev *dev, u32 index) |
| 397 | { | 397 | { |
| 398 | u64 in_param; | 398 | u64 in_param = 0; |
| 399 | 399 | ||
| 400 | if (mlx4_is_mfunc(dev)) { | 400 | if (mlx4_is_mfunc(dev)) { |
| 401 | set_param_l(&in_param, index); | 401 | set_param_l(&in_param, index); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/pd.c b/drivers/net/ethernet/mellanox/mlx4/pd.c index 1ac88637ad9d..00f223acada7 100644 --- a/drivers/net/ethernet/mellanox/mlx4/pd.c +++ b/drivers/net/ethernet/mellanox/mlx4/pd.c | |||
| @@ -101,7 +101,7 @@ void __mlx4_xrcd_free(struct mlx4_dev *dev, u32 xrcdn) | |||
| 101 | 101 | ||
| 102 | void mlx4_xrcd_free(struct mlx4_dev *dev, u32 xrcdn) | 102 | void mlx4_xrcd_free(struct mlx4_dev *dev, u32 xrcdn) |
| 103 | { | 103 | { |
| 104 | u64 in_param; | 104 | u64 in_param = 0; |
| 105 | int err; | 105 | int err; |
| 106 | 106 | ||
| 107 | if (mlx4_is_mfunc(dev)) { | 107 | if (mlx4_is_mfunc(dev)) { |
diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 719ead15e491..10c57c86388b 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c | |||
| @@ -175,7 +175,7 @@ EXPORT_SYMBOL_GPL(__mlx4_register_mac); | |||
| 175 | 175 | ||
| 176 | int mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) | 176 | int mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) |
| 177 | { | 177 | { |
| 178 | u64 out_param; | 178 | u64 out_param = 0; |
| 179 | int err; | 179 | int err; |
| 180 | 180 | ||
| 181 | if (mlx4_is_mfunc(dev)) { | 181 | if (mlx4_is_mfunc(dev)) { |
| @@ -222,7 +222,7 @@ EXPORT_SYMBOL_GPL(__mlx4_unregister_mac); | |||
| 222 | 222 | ||
| 223 | void mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac) | 223 | void mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac) |
| 224 | { | 224 | { |
| 225 | u64 out_param; | 225 | u64 out_param = 0; |
| 226 | 226 | ||
| 227 | if (mlx4_is_mfunc(dev)) { | 227 | if (mlx4_is_mfunc(dev)) { |
| 228 | set_param_l(&out_param, port); | 228 | set_param_l(&out_param, port); |
| @@ -361,7 +361,7 @@ out: | |||
| 361 | 361 | ||
| 362 | int mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan, int *index) | 362 | int mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan, int *index) |
| 363 | { | 363 | { |
| 364 | u64 out_param; | 364 | u64 out_param = 0; |
| 365 | int err; | 365 | int err; |
| 366 | 366 | ||
| 367 | if (mlx4_is_mfunc(dev)) { | 367 | if (mlx4_is_mfunc(dev)) { |
| @@ -406,7 +406,7 @@ out: | |||
| 406 | 406 | ||
| 407 | void mlx4_unregister_vlan(struct mlx4_dev *dev, u8 port, int index) | 407 | void mlx4_unregister_vlan(struct mlx4_dev *dev, u8 port, int index) |
| 408 | { | 408 | { |
| 409 | u64 in_param; | 409 | u64 in_param = 0; |
| 410 | int err; | 410 | int err; |
| 411 | 411 | ||
| 412 | if (mlx4_is_mfunc(dev)) { | 412 | if (mlx4_is_mfunc(dev)) { |
diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c index 81e2abe07bbb..e891b058c1be 100644 --- a/drivers/net/ethernet/mellanox/mlx4/qp.c +++ b/drivers/net/ethernet/mellanox/mlx4/qp.c | |||
| @@ -222,7 +222,7 @@ int __mlx4_qp_reserve_range(struct mlx4_dev *dev, int cnt, int align, | |||
| 222 | 222 | ||
| 223 | int mlx4_qp_reserve_range(struct mlx4_dev *dev, int cnt, int align, int *base) | 223 | int mlx4_qp_reserve_range(struct mlx4_dev *dev, int cnt, int align, int *base) |
| 224 | { | 224 | { |
| 225 | u64 in_param; | 225 | u64 in_param = 0; |
| 226 | u64 out_param; | 226 | u64 out_param; |
| 227 | int err; | 227 | int err; |
| 228 | 228 | ||
| @@ -255,7 +255,7 @@ void __mlx4_qp_release_range(struct mlx4_dev *dev, int base_qpn, int cnt) | |||
| 255 | 255 | ||
| 256 | void mlx4_qp_release_range(struct mlx4_dev *dev, int base_qpn, int cnt) | 256 | void mlx4_qp_release_range(struct mlx4_dev *dev, int base_qpn, int cnt) |
| 257 | { | 257 | { |
| 258 | u64 in_param; | 258 | u64 in_param = 0; |
| 259 | int err; | 259 | int err; |
| 260 | 260 | ||
| 261 | if (mlx4_is_mfunc(dev)) { | 261 | if (mlx4_is_mfunc(dev)) { |
| @@ -319,7 +319,7 @@ err_out: | |||
| 319 | 319 | ||
| 320 | static int mlx4_qp_alloc_icm(struct mlx4_dev *dev, int qpn) | 320 | static int mlx4_qp_alloc_icm(struct mlx4_dev *dev, int qpn) |
| 321 | { | 321 | { |
| 322 | u64 param; | 322 | u64 param = 0; |
| 323 | 323 | ||
| 324 | if (mlx4_is_mfunc(dev)) { | 324 | if (mlx4_is_mfunc(dev)) { |
| 325 | set_param_l(¶m, qpn); | 325 | set_param_l(¶m, qpn); |
| @@ -344,7 +344,7 @@ void __mlx4_qp_free_icm(struct mlx4_dev *dev, int qpn) | |||
| 344 | 344 | ||
| 345 | static void mlx4_qp_free_icm(struct mlx4_dev *dev, int qpn) | 345 | static void mlx4_qp_free_icm(struct mlx4_dev *dev, int qpn) |
| 346 | { | 346 | { |
| 347 | u64 in_param; | 347 | u64 in_param = 0; |
| 348 | 348 | ||
| 349 | if (mlx4_is_mfunc(dev)) { | 349 | if (mlx4_is_mfunc(dev)) { |
| 350 | set_param_l(&in_param, qpn); | 350 | set_param_l(&in_param, qpn); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index 083fb48dc3d7..2995687f1aee 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | |||
| @@ -2990,6 +2990,9 @@ int mlx4_QP_ATTACH_wrapper(struct mlx4_dev *dev, int slave, | |||
| 2990 | u8 steer_type_mask = 2; | 2990 | u8 steer_type_mask = 2; |
| 2991 | enum mlx4_steer_type type = (gid[7] & steer_type_mask) >> 1; | 2991 | enum mlx4_steer_type type = (gid[7] & steer_type_mask) >> 1; |
| 2992 | 2992 | ||
| 2993 | if (dev->caps.steering_mode != MLX4_STEERING_MODE_B0) | ||
| 2994 | return -EINVAL; | ||
| 2995 | |||
| 2993 | qpn = vhcr->in_modifier & 0xffffff; | 2996 | qpn = vhcr->in_modifier & 0xffffff; |
| 2994 | err = get_res(dev, slave, qpn, RES_QP, &rqp); | 2997 | err = get_res(dev, slave, qpn, RES_QP, &rqp); |
| 2995 | if (err) | 2998 | if (err) |
diff --git a/drivers/net/ethernet/mellanox/mlx4/srq.c b/drivers/net/ethernet/mellanox/mlx4/srq.c index feda6c00829f..e329fe1f11b7 100644 --- a/drivers/net/ethernet/mellanox/mlx4/srq.c +++ b/drivers/net/ethernet/mellanox/mlx4/srq.c | |||
| @@ -149,7 +149,7 @@ void __mlx4_srq_free_icm(struct mlx4_dev *dev, int srqn) | |||
| 149 | 149 | ||
| 150 | static void mlx4_srq_free_icm(struct mlx4_dev *dev, int srqn) | 150 | static void mlx4_srq_free_icm(struct mlx4_dev *dev, int srqn) |
| 151 | { | 151 | { |
| 152 | u64 in_param; | 152 | u64 in_param = 0; |
| 153 | 153 | ||
| 154 | if (mlx4_is_mfunc(dev)) { | 154 | if (mlx4_is_mfunc(dev)) { |
| 155 | set_param_l(&in_param, srqn); | 155 | set_param_l(&in_param, srqn); |
diff --git a/drivers/net/ethernet/sfc/efx.h b/drivers/net/ethernet/sfc/efx.h index 50247dfe8f57..d2f790df6dcb 100644 --- a/drivers/net/ethernet/sfc/efx.h +++ b/drivers/net/ethernet/sfc/efx.h | |||
| @@ -171,9 +171,9 @@ static inline void efx_device_detach_sync(struct efx_nic *efx) | |||
| 171 | * TX scheduler is stopped when we're done and before | 171 | * TX scheduler is stopped when we're done and before |
| 172 | * netif_device_present() becomes false. | 172 | * netif_device_present() becomes false. |
| 173 | */ | 173 | */ |
| 174 | netif_tx_lock(dev); | 174 | netif_tx_lock_bh(dev); |
| 175 | netif_device_detach(dev); | 175 | netif_device_detach(dev); |
| 176 | netif_tx_unlock(dev); | 176 | netif_tx_unlock_bh(dev); |
| 177 | } | 177 | } |
| 178 | 178 | ||
| 179 | #endif /* EFX_EFX_H */ | 179 | #endif /* EFX_EFX_H */ |
diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c index 879ff5849bbd..bb579a6128c8 100644 --- a/drivers/net/ethernet/sfc/rx.c +++ b/drivers/net/ethernet/sfc/rx.c | |||
| @@ -215,7 +215,7 @@ static int efx_init_rx_buffers_page(struct efx_rx_queue *rx_queue) | |||
| 215 | rx_buf = efx_rx_buffer(rx_queue, index); | 215 | rx_buf = efx_rx_buffer(rx_queue, index); |
| 216 | rx_buf->dma_addr = dma_addr + EFX_PAGE_IP_ALIGN; | 216 | rx_buf->dma_addr = dma_addr + EFX_PAGE_IP_ALIGN; |
| 217 | rx_buf->u.page = page; | 217 | rx_buf->u.page = page; |
| 218 | rx_buf->page_offset = page_offset; | 218 | rx_buf->page_offset = page_offset + EFX_PAGE_IP_ALIGN; |
| 219 | rx_buf->len = efx->rx_buffer_len - EFX_PAGE_IP_ALIGN; | 219 | rx_buf->len = efx->rx_buffer_len - EFX_PAGE_IP_ALIGN; |
| 220 | rx_buf->flags = EFX_RX_BUF_PAGE; | 220 | rx_buf->flags = EFX_RX_BUF_PAGE; |
| 221 | ++rx_queue->added_count; | 221 | ++rx_queue->added_count; |
diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c index e5b19b056909..3c4d6274bb9b 100644 --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c | |||
| @@ -202,6 +202,9 @@ static int rr_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 202 | return 0; | 202 | return 0; |
| 203 | 203 | ||
| 204 | out: | 204 | out: |
| 205 | if (rrpriv->evt_ring) | ||
| 206 | pci_free_consistent(pdev, EVT_RING_SIZE, rrpriv->evt_ring, | ||
| 207 | rrpriv->evt_ring_dma); | ||
| 205 | if (rrpriv->rx_ring) | 208 | if (rrpriv->rx_ring) |
| 206 | pci_free_consistent(pdev, RX_TOTAL_SIZE, rrpriv->rx_ring, | 209 | pci_free_consistent(pdev, RX_TOTAL_SIZE, rrpriv->rx_ring, |
| 207 | rrpriv->rx_ring_dma); | 210 | rrpriv->rx_ring_dma); |
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 417b2af1aa80..73abbc1655d5 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c | |||
| @@ -660,6 +660,7 @@ void macvlan_common_setup(struct net_device *dev) | |||
| 660 | ether_setup(dev); | 660 | ether_setup(dev); |
| 661 | 661 | ||
| 662 | dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING); | 662 | dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING); |
| 663 | dev->priv_flags |= IFF_UNICAST_FLT; | ||
| 663 | dev->netdev_ops = &macvlan_netdev_ops; | 664 | dev->netdev_ops = &macvlan_netdev_ops; |
| 664 | dev->destructor = free_netdev; | 665 | dev->destructor = free_netdev; |
| 665 | dev->header_ops = &macvlan_hard_header_ops, | 666 | dev->header_ops = &macvlan_hard_header_ops, |
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 05c5efe84591..bf3419297875 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c | |||
| @@ -1138,6 +1138,8 @@ static int team_port_del(struct team *team, struct net_device *port_dev) | |||
| 1138 | netdev_upper_dev_unlink(port_dev, dev); | 1138 | netdev_upper_dev_unlink(port_dev, dev); |
| 1139 | team_port_disable_netpoll(port); | 1139 | team_port_disable_netpoll(port); |
| 1140 | vlan_vids_del_by_dev(port_dev, dev); | 1140 | vlan_vids_del_by_dev(port_dev, dev); |
| 1141 | dev_uc_unsync(port_dev, dev); | ||
| 1142 | dev_mc_unsync(port_dev, dev); | ||
| 1141 | dev_close(port_dev); | 1143 | dev_close(port_dev); |
| 1142 | team_port_leave(team, port); | 1144 | team_port_leave(team, port); |
| 1143 | 1145 | ||
diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 2c6a22e278ea..b7c457adc0dc 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c | |||
| @@ -747,6 +747,8 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 747 | goto drop; | 747 | goto drop; |
| 748 | skb_orphan(skb); | 748 | skb_orphan(skb); |
| 749 | 749 | ||
| 750 | nf_reset(skb); | ||
| 751 | |||
| 750 | /* Enqueue packet */ | 752 | /* Enqueue packet */ |
| 751 | skb_queue_tail(&tfile->socket.sk->sk_receive_queue, skb); | 753 | skb_queue_tail(&tfile->socket.sk->sk_receive_queue, skb); |
| 752 | 754 | ||
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 4aad350e4dae..eae7a03d4f9b 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c | |||
| @@ -2958,6 +2958,7 @@ vmxnet3_probe_device(struct pci_dev *pdev, | |||
| 2958 | 2958 | ||
| 2959 | adapter->num_rx_queues = num_rx_queues; | 2959 | adapter->num_rx_queues = num_rx_queues; |
| 2960 | adapter->num_tx_queues = num_tx_queues; | 2960 | adapter->num_tx_queues = num_tx_queues; |
| 2961 | adapter->rx_buf_per_pkt = 1; | ||
| 2961 | 2962 | ||
| 2962 | size = sizeof(struct Vmxnet3_TxQueueDesc) * adapter->num_tx_queues; | 2963 | size = sizeof(struct Vmxnet3_TxQueueDesc) * adapter->num_tx_queues; |
| 2963 | size += sizeof(struct Vmxnet3_RxQueueDesc) * adapter->num_rx_queues; | 2964 | size += sizeof(struct Vmxnet3_RxQueueDesc) * adapter->num_rx_queues; |
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c index a0feb17a0238..63a124340cbe 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c | |||
| @@ -472,6 +472,12 @@ vmxnet3_set_ringparam(struct net_device *netdev, | |||
| 472 | VMXNET3_RX_RING_MAX_SIZE) | 472 | VMXNET3_RX_RING_MAX_SIZE) |
| 473 | return -EINVAL; | 473 | return -EINVAL; |
| 474 | 474 | ||
| 475 | /* if adapter not yet initialized, do nothing */ | ||
| 476 | if (adapter->rx_buf_per_pkt == 0) { | ||
| 477 | netdev_err(netdev, "adapter not completely initialized, " | ||
| 478 | "ring size cannot be changed yet\n"); | ||
| 479 | return -EOPNOTSUPP; | ||
| 480 | } | ||
| 475 | 481 | ||
| 476 | /* round it up to a multiple of VMXNET3_RING_SIZE_ALIGN */ | 482 | /* round it up to a multiple of VMXNET3_RING_SIZE_ALIGN */ |
| 477 | new_tx_ring_size = (param->tx_pending + VMXNET3_RING_SIZE_MASK) & | 483 | new_tx_ring_size = (param->tx_pending + VMXNET3_RING_SIZE_MASK) & |
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index 3198384689d9..35418146fa17 100644 --- a/drivers/net/vmxnet3/vmxnet3_int.h +++ b/drivers/net/vmxnet3/vmxnet3_int.h | |||
| @@ -70,10 +70,10 @@ | |||
| 70 | /* | 70 | /* |
| 71 | * Version numbers | 71 | * Version numbers |
| 72 | */ | 72 | */ |
| 73 | #define VMXNET3_DRIVER_VERSION_STRING "1.1.29.0-k" | 73 | #define VMXNET3_DRIVER_VERSION_STRING "1.1.30.0-k" |
| 74 | 74 | ||
| 75 | /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */ | 75 | /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */ |
| 76 | #define VMXNET3_DRIVER_VERSION_NUM 0x01011D00 | 76 | #define VMXNET3_DRIVER_VERSION_NUM 0x01011E00 |
| 77 | 77 | ||
| 78 | #if defined(CONFIG_PCI_MSI) | 78 | #if defined(CONFIG_PCI_MSI) |
| 79 | /* RSS only makes sense if MSI-X is supported. */ | 79 | /* RSS only makes sense if MSI-X is supported. */ |
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f10e58ac9c1b..7cee7a3068ec 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c | |||
| @@ -961,6 +961,8 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 961 | iph->ttl = ttl ? : ip4_dst_hoplimit(&rt->dst); | 961 | iph->ttl = ttl ? : ip4_dst_hoplimit(&rt->dst); |
| 962 | tunnel_ip_select_ident(skb, old_iph, &rt->dst); | 962 | tunnel_ip_select_ident(skb, old_iph, &rt->dst); |
| 963 | 963 | ||
| 964 | nf_reset(skb); | ||
| 965 | |||
| 964 | vxlan_set_owner(dev, skb); | 966 | vxlan_set_owner(dev, skb); |
| 965 | 967 | ||
| 966 | /* See iptunnel_xmit() */ | 968 | /* See iptunnel_xmit() */ |
| @@ -1504,6 +1506,14 @@ static __net_init int vxlan_init_net(struct net *net) | |||
| 1504 | static __net_exit void vxlan_exit_net(struct net *net) | 1506 | static __net_exit void vxlan_exit_net(struct net *net) |
| 1505 | { | 1507 | { |
| 1506 | struct vxlan_net *vn = net_generic(net, vxlan_net_id); | 1508 | struct vxlan_net *vn = net_generic(net, vxlan_net_id); |
| 1509 | struct vxlan_dev *vxlan; | ||
| 1510 | unsigned h; | ||
| 1511 | |||
| 1512 | rtnl_lock(); | ||
| 1513 | for (h = 0; h < VNI_HASH_SIZE; ++h) | ||
| 1514 | hlist_for_each_entry(vxlan, &vn->vni_list[h], hlist) | ||
| 1515 | dev_close(vxlan->dev); | ||
| 1516 | rtnl_unlock(); | ||
| 1507 | 1517 | ||
| 1508 | if (vn->sock) { | 1518 | if (vn->sock) { |
| 1509 | sk_release_kernel(vn->sock->sk); | 1519 | sk_release_kernel(vn->sock->sk); |
diff --git a/drivers/net/wireless/iwlwifi/dvm/sta.c b/drivers/net/wireless/iwlwifi/dvm/sta.c index 94ef33838bc6..b775769f8322 100644 --- a/drivers/net/wireless/iwlwifi/dvm/sta.c +++ b/drivers/net/wireless/iwlwifi/dvm/sta.c | |||
| @@ -151,7 +151,7 @@ int iwl_send_add_sta(struct iwl_priv *priv, | |||
| 151 | sta_id, sta->sta.addr, flags & CMD_ASYNC ? "a" : ""); | 151 | sta_id, sta->sta.addr, flags & CMD_ASYNC ? "a" : ""); |
| 152 | 152 | ||
| 153 | if (!(flags & CMD_ASYNC)) { | 153 | if (!(flags & CMD_ASYNC)) { |
| 154 | cmd.flags |= CMD_WANT_SKB | CMD_WANT_HCMD; | 154 | cmd.flags |= CMD_WANT_SKB; |
| 155 | might_sleep(); | 155 | might_sleep(); |
| 156 | } | 156 | } |
| 157 | 157 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.h b/drivers/net/wireless/iwlwifi/iwl-devtrace.h index 10f01793d7a6..81aa91fab5aa 100644 --- a/drivers/net/wireless/iwlwifi/iwl-devtrace.h +++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.h | |||
| @@ -363,7 +363,7 @@ TRACE_EVENT(iwlwifi_dev_hcmd, | |||
| 363 | __entry->flags = cmd->flags; | 363 | __entry->flags = cmd->flags; |
| 364 | memcpy(__get_dynamic_array(hcmd), hdr, sizeof(*hdr)); | 364 | memcpy(__get_dynamic_array(hcmd), hdr, sizeof(*hdr)); |
| 365 | 365 | ||
| 366 | for (i = 0; i < IWL_MAX_CMD_TFDS; i++) { | 366 | for (i = 0; i < IWL_MAX_CMD_TBS_PER_TFD; i++) { |
| 367 | if (!cmd->len[i]) | 367 | if (!cmd->len[i]) |
| 368 | continue; | 368 | continue; |
| 369 | memcpy((u8 *)__get_dynamic_array(hcmd) + offset, | 369 | memcpy((u8 *)__get_dynamic_array(hcmd) + offset, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c index 6f228bb2b844..fbfd2d137117 100644 --- a/drivers/net/wireless/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/iwlwifi/iwl-drv.c | |||
| @@ -1102,7 +1102,6 @@ void iwl_drv_stop(struct iwl_drv *drv) | |||
| 1102 | 1102 | ||
| 1103 | /* shared module parameters */ | 1103 | /* shared module parameters */ |
| 1104 | struct iwl_mod_params iwlwifi_mod_params = { | 1104 | struct iwl_mod_params iwlwifi_mod_params = { |
| 1105 | .amsdu_size_8K = 1, | ||
| 1106 | .restart_fw = 1, | 1105 | .restart_fw = 1, |
| 1107 | .plcp_check = true, | 1106 | .plcp_check = true, |
| 1108 | .bt_coex_active = true, | 1107 | .bt_coex_active = true, |
| @@ -1207,7 +1206,7 @@ MODULE_PARM_DESC(11n_disable, | |||
| 1207 | "disable 11n functionality, bitmap: 1: full, 2: agg TX, 4: agg RX"); | 1206 | "disable 11n functionality, bitmap: 1: full, 2: agg TX, 4: agg RX"); |
| 1208 | module_param_named(amsdu_size_8K, iwlwifi_mod_params.amsdu_size_8K, | 1207 | module_param_named(amsdu_size_8K, iwlwifi_mod_params.amsdu_size_8K, |
| 1209 | int, S_IRUGO); | 1208 | int, S_IRUGO); |
| 1210 | MODULE_PARM_DESC(amsdu_size_8K, "enable 8K amsdu size"); | 1209 | MODULE_PARM_DESC(amsdu_size_8K, "enable 8K amsdu size (default 0)"); |
| 1211 | module_param_named(fw_restart, iwlwifi_mod_params.restart_fw, int, S_IRUGO); | 1210 | module_param_named(fw_restart, iwlwifi_mod_params.restart_fw, int, S_IRUGO); |
| 1212 | MODULE_PARM_DESC(fw_restart, "restart firmware in case of error"); | 1211 | MODULE_PARM_DESC(fw_restart, "restart firmware in case of error"); |
| 1213 | 1212 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-modparams.h b/drivers/net/wireless/iwlwifi/iwl-modparams.h index e5e3a79eae2f..2c2a729092f5 100644 --- a/drivers/net/wireless/iwlwifi/iwl-modparams.h +++ b/drivers/net/wireless/iwlwifi/iwl-modparams.h | |||
| @@ -91,7 +91,7 @@ enum iwl_power_level { | |||
| 91 | * @sw_crypto: using hardware encryption, default = 0 | 91 | * @sw_crypto: using hardware encryption, default = 0 |
| 92 | * @disable_11n: disable 11n capabilities, default = 0, | 92 | * @disable_11n: disable 11n capabilities, default = 0, |
| 93 | * use IWL_DISABLE_HT_* constants | 93 | * use IWL_DISABLE_HT_* constants |
| 94 | * @amsdu_size_8K: enable 8K amsdu size, default = 1 | 94 | * @amsdu_size_8K: enable 8K amsdu size, default = 0 |
| 95 | * @restart_fw: restart firmware, default = 1 | 95 | * @restart_fw: restart firmware, default = 1 |
| 96 | * @plcp_check: enable plcp health check, default = true | 96 | * @plcp_check: enable plcp health check, default = true |
| 97 | * @wd_disable: enable stuck queue check, default = 0 | 97 | * @wd_disable: enable stuck queue check, default = 0 |
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.h b/drivers/net/wireless/iwlwifi/iwl-trans.h index 8c7bec6b9a0b..0cac2b7af78b 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans.h +++ b/drivers/net/wireless/iwlwifi/iwl-trans.h | |||
| @@ -186,19 +186,13 @@ struct iwl_rx_packet { | |||
| 186 | * @CMD_ASYNC: Return right away and don't want for the response | 186 | * @CMD_ASYNC: Return right away and don't want for the response |
| 187 | * @CMD_WANT_SKB: valid only with CMD_SYNC. The caller needs the buffer of the | 187 | * @CMD_WANT_SKB: valid only with CMD_SYNC. The caller needs the buffer of the |
| 188 | * response. The caller needs to call iwl_free_resp when done. | 188 | * response. The caller needs to call iwl_free_resp when done. |
| 189 | * @CMD_WANT_HCMD: The caller needs to get the HCMD that was sent in the | ||
| 190 | * response handler. Chunks flagged by %IWL_HCMD_DFL_NOCOPY won't be | ||
| 191 | * copied. The pointer passed to the response handler is in the transport | ||
| 192 | * ownership and don't need to be freed by the op_mode. This also means | ||
| 193 | * that the pointer is invalidated after the op_mode's handler returns. | ||
| 194 | * @CMD_ON_DEMAND: This command is sent by the test mode pipe. | 189 | * @CMD_ON_DEMAND: This command is sent by the test mode pipe. |
| 195 | */ | 190 | */ |
| 196 | enum CMD_MODE { | 191 | enum CMD_MODE { |
| 197 | CMD_SYNC = 0, | 192 | CMD_SYNC = 0, |
| 198 | CMD_ASYNC = BIT(0), | 193 | CMD_ASYNC = BIT(0), |
| 199 | CMD_WANT_SKB = BIT(1), | 194 | CMD_WANT_SKB = BIT(1), |
| 200 | CMD_WANT_HCMD = BIT(2), | 195 | CMD_ON_DEMAND = BIT(2), |
| 201 | CMD_ON_DEMAND = BIT(3), | ||
| 202 | }; | 196 | }; |
| 203 | 197 | ||
| 204 | #define DEF_CMD_PAYLOAD_SIZE 320 | 198 | #define DEF_CMD_PAYLOAD_SIZE 320 |
| @@ -217,7 +211,11 @@ struct iwl_device_cmd { | |||
| 217 | 211 | ||
| 218 | #define TFD_MAX_PAYLOAD_SIZE (sizeof(struct iwl_device_cmd)) | 212 | #define TFD_MAX_PAYLOAD_SIZE (sizeof(struct iwl_device_cmd)) |
| 219 | 213 | ||
| 220 | #define IWL_MAX_CMD_TFDS 2 | 214 | /* |
| 215 | * number of transfer buffers (fragments) per transmit frame descriptor; | ||
| 216 | * this is just the driver's idea, the hardware supports 20 | ||
| 217 | */ | ||
| 218 | #define IWL_MAX_CMD_TBS_PER_TFD 2 | ||
| 221 | 219 | ||
| 222 | /** | 220 | /** |
| 223 | * struct iwl_hcmd_dataflag - flag for each one of the chunks of the command | 221 | * struct iwl_hcmd_dataflag - flag for each one of the chunks of the command |
| @@ -254,15 +252,15 @@ enum iwl_hcmd_dataflag { | |||
| 254 | * @id: id of the host command | 252 | * @id: id of the host command |
| 255 | */ | 253 | */ |
| 256 | struct iwl_host_cmd { | 254 | struct iwl_host_cmd { |
| 257 | const void *data[IWL_MAX_CMD_TFDS]; | 255 | const void *data[IWL_MAX_CMD_TBS_PER_TFD]; |
| 258 | struct iwl_rx_packet *resp_pkt; | 256 | struct iwl_rx_packet *resp_pkt; |
| 259 | unsigned long _rx_page_addr; | 257 | unsigned long _rx_page_addr; |
| 260 | u32 _rx_page_order; | 258 | u32 _rx_page_order; |
| 261 | int handler_status; | 259 | int handler_status; |
| 262 | 260 | ||
| 263 | u32 flags; | 261 | u32 flags; |
| 264 | u16 len[IWL_MAX_CMD_TFDS]; | 262 | u16 len[IWL_MAX_CMD_TBS_PER_TFD]; |
| 265 | u8 dataflags[IWL_MAX_CMD_TFDS]; | 263 | u8 dataflags[IWL_MAX_CMD_TBS_PER_TFD]; |
| 266 | u8 id; | 264 | u8 id; |
| 267 | }; | 265 | }; |
| 268 | 266 | ||
diff --git a/drivers/net/wireless/iwlwifi/mvm/fw-api.h b/drivers/net/wireless/iwlwifi/mvm/fw-api.h index 23eebda848b0..2adb61f103f4 100644 --- a/drivers/net/wireless/iwlwifi/mvm/fw-api.h +++ b/drivers/net/wireless/iwlwifi/mvm/fw-api.h | |||
| @@ -762,18 +762,20 @@ struct iwl_phy_context_cmd { | |||
| 762 | #define IWL_RX_INFO_PHY_CNT 8 | 762 | #define IWL_RX_INFO_PHY_CNT 8 |
| 763 | #define IWL_RX_INFO_AGC_IDX 1 | 763 | #define IWL_RX_INFO_AGC_IDX 1 |
| 764 | #define IWL_RX_INFO_RSSI_AB_IDX 2 | 764 | #define IWL_RX_INFO_RSSI_AB_IDX 2 |
| 765 | #define IWL_RX_INFO_RSSI_C_IDX 3 | 765 | #define IWL_OFDM_AGC_A_MSK 0x0000007f |
| 766 | #define IWL_OFDM_AGC_DB_MSK 0xfe00 | 766 | #define IWL_OFDM_AGC_A_POS 0 |
| 767 | #define IWL_OFDM_AGC_DB_POS 9 | 767 | #define IWL_OFDM_AGC_B_MSK 0x00003f80 |
| 768 | #define IWL_OFDM_AGC_B_POS 7 | ||
| 769 | #define IWL_OFDM_AGC_CODE_MSK 0x3fe00000 | ||
| 770 | #define IWL_OFDM_AGC_CODE_POS 20 | ||
| 768 | #define IWL_OFDM_RSSI_INBAND_A_MSK 0x00ff | 771 | #define IWL_OFDM_RSSI_INBAND_A_MSK 0x00ff |
| 769 | #define IWL_OFDM_RSSI_ALLBAND_A_MSK 0xff00 | ||
| 770 | #define IWL_OFDM_RSSI_A_POS 0 | 772 | #define IWL_OFDM_RSSI_A_POS 0 |
| 773 | #define IWL_OFDM_RSSI_ALLBAND_A_MSK 0xff00 | ||
| 774 | #define IWL_OFDM_RSSI_ALLBAND_A_POS 8 | ||
| 771 | #define IWL_OFDM_RSSI_INBAND_B_MSK 0xff0000 | 775 | #define IWL_OFDM_RSSI_INBAND_B_MSK 0xff0000 |
| 772 | #define IWL_OFDM_RSSI_ALLBAND_B_MSK 0xff000000 | ||
| 773 | #define IWL_OFDM_RSSI_B_POS 16 | 776 | #define IWL_OFDM_RSSI_B_POS 16 |
| 774 | #define IWL_OFDM_RSSI_INBAND_C_MSK 0x00ff | 777 | #define IWL_OFDM_RSSI_ALLBAND_B_MSK 0xff000000 |
| 775 | #define IWL_OFDM_RSSI_ALLBAND_C_MSK 0xff00 | 778 | #define IWL_OFDM_RSSI_ALLBAND_B_POS 24 |
| 776 | #define IWL_OFDM_RSSI_C_POS 0 | ||
| 777 | 779 | ||
| 778 | /** | 780 | /** |
| 779 | * struct iwl_rx_phy_info - phy info | 781 | * struct iwl_rx_phy_info - phy info |
diff --git a/drivers/net/wireless/iwlwifi/mvm/fw.c b/drivers/net/wireless/iwlwifi/mvm/fw.c index d3d959db03a9..500f818dba04 100644 --- a/drivers/net/wireless/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/iwlwifi/mvm/fw.c | |||
| @@ -79,17 +79,8 @@ | |||
| 79 | #define UCODE_VALID_OK cpu_to_le32(0x1) | 79 | #define UCODE_VALID_OK cpu_to_le32(0x1) |
| 80 | 80 | ||
| 81 | /* Default calibration values for WkP - set to INIT image w/o running */ | 81 | /* Default calibration values for WkP - set to INIT image w/o running */ |
| 82 | static const u8 wkp_calib_values_bb_filter[] = { 0xbf, 0x00, 0x5f, 0x00, 0x2f, | ||
| 83 | 0x00, 0x18, 0x00 }; | ||
| 84 | static const u8 wkp_calib_values_rx_dc[] = { 0x7f, 0x7f, 0x7f, 0x7f, 0x7f, | ||
| 85 | 0x7f, 0x7f, 0x7f }; | ||
| 86 | static const u8 wkp_calib_values_tx_lo[] = { 0x00, 0x00, 0x00, 0x00 }; | ||
| 87 | static const u8 wkp_calib_values_tx_iq[] = { 0xff, 0x00, 0xff, 0x00, 0x00, | ||
| 88 | 0x00 }; | ||
| 89 | static const u8 wkp_calib_values_rx_iq[] = { 0xff, 0x00, 0x00, 0x00 }; | ||
| 90 | static const u8 wkp_calib_values_rx_iq_skew[] = { 0x00, 0x00, 0x01, 0x00 }; | 82 | static const u8 wkp_calib_values_rx_iq_skew[] = { 0x00, 0x00, 0x01, 0x00 }; |
| 91 | static const u8 wkp_calib_values_tx_iq_skew[] = { 0x01, 0x00, 0x00, 0x00 }; | 83 | static const u8 wkp_calib_values_tx_iq_skew[] = { 0x01, 0x00, 0x00, 0x00 }; |
| 92 | static const u8 wkp_calib_values_xtal[] = { 0xd2, 0xd2 }; | ||
| 93 | 84 | ||
| 94 | struct iwl_calib_default_data { | 85 | struct iwl_calib_default_data { |
| 95 | u16 size; | 86 | u16 size; |
| @@ -99,12 +90,7 @@ struct iwl_calib_default_data { | |||
| 99 | #define CALIB_SIZE_N_DATA(_buf) {.size = sizeof(_buf), .data = &_buf} | 90 | #define CALIB_SIZE_N_DATA(_buf) {.size = sizeof(_buf), .data = &_buf} |
| 100 | 91 | ||
| 101 | static const struct iwl_calib_default_data wkp_calib_default_data[12] = { | 92 | static const struct iwl_calib_default_data wkp_calib_default_data[12] = { |
| 102 | [5] = CALIB_SIZE_N_DATA(wkp_calib_values_rx_dc), | ||
| 103 | [6] = CALIB_SIZE_N_DATA(wkp_calib_values_bb_filter), | ||
| 104 | [7] = CALIB_SIZE_N_DATA(wkp_calib_values_tx_lo), | ||
| 105 | [8] = CALIB_SIZE_N_DATA(wkp_calib_values_tx_iq), | ||
| 106 | [9] = CALIB_SIZE_N_DATA(wkp_calib_values_tx_iq_skew), | 93 | [9] = CALIB_SIZE_N_DATA(wkp_calib_values_tx_iq_skew), |
| 107 | [10] = CALIB_SIZE_N_DATA(wkp_calib_values_rx_iq), | ||
| 108 | [11] = CALIB_SIZE_N_DATA(wkp_calib_values_rx_iq_skew), | 94 | [11] = CALIB_SIZE_N_DATA(wkp_calib_values_rx_iq_skew), |
| 109 | }; | 95 | }; |
| 110 | 96 | ||
| @@ -241,20 +227,6 @@ static int iwl_mvm_load_ucode_wait_alive(struct iwl_mvm *mvm, | |||
| 241 | 227 | ||
| 242 | return 0; | 228 | return 0; |
| 243 | } | 229 | } |
| 244 | #define IWL_HW_REV_ID_RAINBOW 0x2 | ||
| 245 | #define IWL_PROJ_TYPE_LHP 0x5 | ||
| 246 | |||
| 247 | static u32 iwl_mvm_build_phy_cfg(struct iwl_mvm *mvm) | ||
| 248 | { | ||
| 249 | struct iwl_nvm_data *data = mvm->nvm_data; | ||
| 250 | /* Temp calls to static definitions, will be changed to CSR calls */ | ||
| 251 | u8 hw_rev_id = IWL_HW_REV_ID_RAINBOW; | ||
| 252 | u8 project_type = IWL_PROJ_TYPE_LHP; | ||
| 253 | |||
| 254 | return data->radio_cfg_dash | (data->radio_cfg_step << 2) | | ||
| 255 | (hw_rev_id << 4) | ((project_type & 0x7f) << 6) | | ||
| 256 | (data->valid_tx_ant << 16) | (data->valid_rx_ant << 20); | ||
| 257 | } | ||
| 258 | 230 | ||
| 259 | static int iwl_send_phy_cfg_cmd(struct iwl_mvm *mvm) | 231 | static int iwl_send_phy_cfg_cmd(struct iwl_mvm *mvm) |
| 260 | { | 232 | { |
| @@ -262,7 +234,7 @@ static int iwl_send_phy_cfg_cmd(struct iwl_mvm *mvm) | |||
| 262 | enum iwl_ucode_type ucode_type = mvm->cur_ucode; | 234 | enum iwl_ucode_type ucode_type = mvm->cur_ucode; |
| 263 | 235 | ||
| 264 | /* Set parameters */ | 236 | /* Set parameters */ |
| 265 | phy_cfg_cmd.phy_cfg = cpu_to_le32(iwl_mvm_build_phy_cfg(mvm)); | 237 | phy_cfg_cmd.phy_cfg = cpu_to_le32(mvm->fw->phy_config); |
| 266 | phy_cfg_cmd.calib_control.event_trigger = | 238 | phy_cfg_cmd.calib_control.event_trigger = |
| 267 | mvm->fw->default_calib[ucode_type].event_trigger; | 239 | mvm->fw->default_calib[ucode_type].event_trigger; |
| 268 | phy_cfg_cmd.calib_control.flow_trigger = | 240 | phy_cfg_cmd.calib_control.flow_trigger = |
| @@ -275,103 +247,6 @@ static int iwl_send_phy_cfg_cmd(struct iwl_mvm *mvm) | |||
| 275 | sizeof(phy_cfg_cmd), &phy_cfg_cmd); | 247 | sizeof(phy_cfg_cmd), &phy_cfg_cmd); |
| 276 | } | 248 | } |
| 277 | 249 | ||
| 278 | /* Starting with the new PHY DB implementation - New calibs are enabled */ | ||
| 279 | /* Value - 0x405e7 */ | ||
| 280 | #define IWL_CALIB_DEFAULT_FLOW_INIT (IWL_CALIB_CFG_XTAL_IDX |\ | ||
| 281 | IWL_CALIB_CFG_TEMPERATURE_IDX |\ | ||
| 282 | IWL_CALIB_CFG_VOLTAGE_READ_IDX |\ | ||
| 283 | IWL_CALIB_CFG_DC_IDX |\ | ||
| 284 | IWL_CALIB_CFG_BB_FILTER_IDX |\ | ||
| 285 | IWL_CALIB_CFG_LO_LEAKAGE_IDX |\ | ||
| 286 | IWL_CALIB_CFG_TX_IQ_IDX |\ | ||
| 287 | IWL_CALIB_CFG_RX_IQ_IDX |\ | ||
| 288 | IWL_CALIB_CFG_AGC_IDX) | ||
| 289 | |||
| 290 | #define IWL_CALIB_DEFAULT_EVENT_INIT 0x0 | ||
| 291 | |||
| 292 | /* Value 0x41567 */ | ||
| 293 | #define IWL_CALIB_DEFAULT_FLOW_RUN (IWL_CALIB_CFG_XTAL_IDX |\ | ||
| 294 | IWL_CALIB_CFG_TEMPERATURE_IDX |\ | ||
| 295 | IWL_CALIB_CFG_VOLTAGE_READ_IDX |\ | ||
| 296 | IWL_CALIB_CFG_BB_FILTER_IDX |\ | ||
| 297 | IWL_CALIB_CFG_DC_IDX |\ | ||
| 298 | IWL_CALIB_CFG_TX_IQ_IDX |\ | ||
| 299 | IWL_CALIB_CFG_RX_IQ_IDX |\ | ||
| 300 | IWL_CALIB_CFG_SENSITIVITY_IDX |\ | ||
| 301 | IWL_CALIB_CFG_AGC_IDX) | ||
| 302 | |||
| 303 | #define IWL_CALIB_DEFAULT_EVENT_RUN (IWL_CALIB_CFG_XTAL_IDX |\ | ||
| 304 | IWL_CALIB_CFG_TEMPERATURE_IDX |\ | ||
| 305 | IWL_CALIB_CFG_VOLTAGE_READ_IDX |\ | ||
| 306 | IWL_CALIB_CFG_TX_PWR_IDX |\ | ||
| 307 | IWL_CALIB_CFG_DC_IDX |\ | ||
| 308 | IWL_CALIB_CFG_TX_IQ_IDX |\ | ||
| 309 | IWL_CALIB_CFG_SENSITIVITY_IDX) | ||
| 310 | |||
| 311 | /* | ||
| 312 | * Sets the calibrations trigger values that will be sent to the FW for runtime | ||
| 313 | * and init calibrations. | ||
| 314 | * The ones given in the FW TLV are not correct. | ||
| 315 | */ | ||
| 316 | static void iwl_set_default_calib_trigger(struct iwl_mvm *mvm) | ||
| 317 | { | ||
| 318 | struct iwl_tlv_calib_ctrl default_calib; | ||
| 319 | |||
| 320 | /* | ||
| 321 | * WkP FW TLV calib bits are wrong, overwrite them. | ||
| 322 | * This defines the dynamic calibrations which are implemented in the | ||
| 323 | * uCode both for init(flow) calculation and event driven calibs. | ||
| 324 | */ | ||
| 325 | |||
| 326 | /* Init Image */ | ||
| 327 | default_calib.event_trigger = cpu_to_le32(IWL_CALIB_DEFAULT_EVENT_INIT); | ||
| 328 | default_calib.flow_trigger = cpu_to_le32(IWL_CALIB_DEFAULT_FLOW_INIT); | ||
| 329 | |||
| 330 | if (default_calib.event_trigger != | ||
| 331 | mvm->fw->default_calib[IWL_UCODE_INIT].event_trigger) | ||
| 332 | IWL_ERR(mvm, | ||
| 333 | "Updating the event calib for INIT image: 0x%x -> 0x%x\n", | ||
| 334 | mvm->fw->default_calib[IWL_UCODE_INIT].event_trigger, | ||
| 335 | default_calib.event_trigger); | ||
| 336 | if (default_calib.flow_trigger != | ||
| 337 | mvm->fw->default_calib[IWL_UCODE_INIT].flow_trigger) | ||
| 338 | IWL_ERR(mvm, | ||
| 339 | "Updating the flow calib for INIT image: 0x%x -> 0x%x\n", | ||
| 340 | mvm->fw->default_calib[IWL_UCODE_INIT].flow_trigger, | ||
| 341 | default_calib.flow_trigger); | ||
| 342 | |||
| 343 | memcpy((void *)&mvm->fw->default_calib[IWL_UCODE_INIT], | ||
| 344 | &default_calib, sizeof(struct iwl_tlv_calib_ctrl)); | ||
| 345 | IWL_ERR(mvm, | ||
| 346 | "Setting uCode init calibrations event 0x%x, trigger 0x%x\n", | ||
| 347 | default_calib.event_trigger, | ||
| 348 | default_calib.flow_trigger); | ||
| 349 | |||
| 350 | /* Run time image */ | ||
| 351 | default_calib.event_trigger = cpu_to_le32(IWL_CALIB_DEFAULT_EVENT_RUN); | ||
| 352 | default_calib.flow_trigger = cpu_to_le32(IWL_CALIB_DEFAULT_FLOW_RUN); | ||
| 353 | |||
| 354 | if (default_calib.event_trigger != | ||
| 355 | mvm->fw->default_calib[IWL_UCODE_REGULAR].event_trigger) | ||
| 356 | IWL_ERR(mvm, | ||
| 357 | "Updating the event calib for RT image: 0x%x -> 0x%x\n", | ||
| 358 | mvm->fw->default_calib[IWL_UCODE_REGULAR].event_trigger, | ||
| 359 | default_calib.event_trigger); | ||
| 360 | if (default_calib.flow_trigger != | ||
| 361 | mvm->fw->default_calib[IWL_UCODE_REGULAR].flow_trigger) | ||
| 362 | IWL_ERR(mvm, | ||
| 363 | "Updating the flow calib for RT image: 0x%x -> 0x%x\n", | ||
| 364 | mvm->fw->default_calib[IWL_UCODE_REGULAR].flow_trigger, | ||
| 365 | default_calib.flow_trigger); | ||
| 366 | |||
| 367 | memcpy((void *)&mvm->fw->default_calib[IWL_UCODE_REGULAR], | ||
| 368 | &default_calib, sizeof(struct iwl_tlv_calib_ctrl)); | ||
| 369 | IWL_ERR(mvm, | ||
| 370 | "Setting uCode runtime calibs event 0x%x, trigger 0x%x\n", | ||
| 371 | default_calib.event_trigger, | ||
| 372 | default_calib.flow_trigger); | ||
| 373 | } | ||
| 374 | |||
| 375 | static int iwl_set_default_calibrations(struct iwl_mvm *mvm) | 250 | static int iwl_set_default_calibrations(struct iwl_mvm *mvm) |
| 376 | { | 251 | { |
| 377 | u8 cmd_raw[16]; /* holds the variable size commands */ | 252 | u8 cmd_raw[16]; /* holds the variable size commands */ |
| @@ -446,8 +321,10 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) | |||
| 446 | ret = iwl_nvm_check_version(mvm->nvm_data, mvm->trans); | 321 | ret = iwl_nvm_check_version(mvm->nvm_data, mvm->trans); |
| 447 | WARN_ON(ret); | 322 | WARN_ON(ret); |
| 448 | 323 | ||
| 449 | /* Override the calibrations from TLV and the const of fw */ | 324 | /* Send TX valid antennas before triggering calibrations */ |
| 450 | iwl_set_default_calib_trigger(mvm); | 325 | ret = iwl_send_tx_ant_cfg(mvm, mvm->nvm_data->valid_tx_ant); |
| 326 | if (ret) | ||
| 327 | goto error; | ||
| 451 | 328 | ||
| 452 | /* WkP doesn't have all calibrations, need to set default values */ | 329 | /* WkP doesn't have all calibrations, need to set default values */ |
| 453 | if (mvm->cfg->device_family == IWL_DEVICE_FAMILY_7000) { | 330 | if (mvm->cfg->device_family == IWL_DEVICE_FAMILY_7000) { |
diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h index 537711b10478..bdae700c769e 100644 --- a/drivers/net/wireless/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h | |||
| @@ -80,7 +80,8 @@ | |||
| 80 | 80 | ||
| 81 | #define IWL_INVALID_MAC80211_QUEUE 0xff | 81 | #define IWL_INVALID_MAC80211_QUEUE 0xff |
| 82 | #define IWL_MVM_MAX_ADDRESSES 2 | 82 | #define IWL_MVM_MAX_ADDRESSES 2 |
| 83 | #define IWL_RSSI_OFFSET 44 | 83 | /* RSSI offset for WkP */ |
| 84 | #define IWL_RSSI_OFFSET 50 | ||
| 84 | 85 | ||
| 85 | enum iwl_mvm_tx_fifo { | 86 | enum iwl_mvm_tx_fifo { |
| 86 | IWL_MVM_TX_FIFO_BK = 0, | 87 | IWL_MVM_TX_FIFO_BK = 0, |
diff --git a/drivers/net/wireless/iwlwifi/mvm/ops.c b/drivers/net/wireless/iwlwifi/mvm/ops.c index aa59adf87db3..d0f9c1e0475e 100644 --- a/drivers/net/wireless/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/iwlwifi/mvm/ops.c | |||
| @@ -624,12 +624,8 @@ static void iwl_mvm_free_skb(struct iwl_op_mode *op_mode, struct sk_buff *skb) | |||
| 624 | ieee80211_free_txskb(mvm->hw, skb); | 624 | ieee80211_free_txskb(mvm->hw, skb); |
| 625 | } | 625 | } |
| 626 | 626 | ||
| 627 | static void iwl_mvm_nic_error(struct iwl_op_mode *op_mode) | 627 | static void iwl_mvm_nic_restart(struct iwl_mvm *mvm) |
| 628 | { | 628 | { |
| 629 | struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode); | ||
| 630 | |||
| 631 | iwl_mvm_dump_nic_error_log(mvm); | ||
| 632 | |||
| 633 | iwl_abort_notification_waits(&mvm->notif_wait); | 629 | iwl_abort_notification_waits(&mvm->notif_wait); |
| 634 | 630 | ||
| 635 | /* | 631 | /* |
| @@ -663,9 +659,21 @@ static void iwl_mvm_nic_error(struct iwl_op_mode *op_mode) | |||
| 663 | } | 659 | } |
| 664 | } | 660 | } |
| 665 | 661 | ||
| 662 | static void iwl_mvm_nic_error(struct iwl_op_mode *op_mode) | ||
| 663 | { | ||
| 664 | struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode); | ||
| 665 | |||
| 666 | iwl_mvm_dump_nic_error_log(mvm); | ||
| 667 | |||
| 668 | iwl_mvm_nic_restart(mvm); | ||
| 669 | } | ||
| 670 | |||
| 666 | static void iwl_mvm_cmd_queue_full(struct iwl_op_mode *op_mode) | 671 | static void iwl_mvm_cmd_queue_full(struct iwl_op_mode *op_mode) |
| 667 | { | 672 | { |
| 673 | struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode); | ||
| 674 | |||
| 668 | WARN_ON(1); | 675 | WARN_ON(1); |
| 676 | iwl_mvm_nic_restart(mvm); | ||
| 669 | } | 677 | } |
| 670 | 678 | ||
| 671 | static const struct iwl_op_mode_ops iwl_mvm_ops = { | 679 | static const struct iwl_op_mode_ops iwl_mvm_ops = { |
diff --git a/drivers/net/wireless/iwlwifi/mvm/rx.c b/drivers/net/wireless/iwlwifi/mvm/rx.c index 3f40ab05bbd8..b0b190d0ec23 100644 --- a/drivers/net/wireless/iwlwifi/mvm/rx.c +++ b/drivers/net/wireless/iwlwifi/mvm/rx.c | |||
| @@ -131,33 +131,42 @@ static void iwl_mvm_pass_packet_to_mac80211(struct iwl_mvm *mvm, | |||
| 131 | static int iwl_mvm_calc_rssi(struct iwl_mvm *mvm, | 131 | static int iwl_mvm_calc_rssi(struct iwl_mvm *mvm, |
| 132 | struct iwl_rx_phy_info *phy_info) | 132 | struct iwl_rx_phy_info *phy_info) |
| 133 | { | 133 | { |
| 134 | u32 rssi_a, rssi_b, rssi_c, max_rssi, agc_db; | 134 | int rssi_a, rssi_b, rssi_a_dbm, rssi_b_dbm, max_rssi_dbm; |
| 135 | int rssi_all_band_a, rssi_all_band_b; | ||
| 136 | u32 agc_a, agc_b, max_agc; | ||
| 135 | u32 val; | 137 | u32 val; |
| 136 | 138 | ||
| 137 | /* Find max rssi among 3 possible receivers. | 139 | /* Find max rssi among 2 possible receivers. |
| 138 | * These values are measured by the Digital Signal Processor (DSP). | 140 | * These values are measured by the Digital Signal Processor (DSP). |
| 139 | * They should stay fairly constant even as the signal strength varies, | 141 | * They should stay fairly constant even as the signal strength varies, |
| 140 | * if the radio's Automatic Gain Control (AGC) is working right. | 142 | * if the radio's Automatic Gain Control (AGC) is working right. |
| 141 | * AGC value (see below) will provide the "interesting" info. | 143 | * AGC value (see below) will provide the "interesting" info. |
| 142 | */ | 144 | */ |
| 145 | val = le32_to_cpu(phy_info->non_cfg_phy[IWL_RX_INFO_AGC_IDX]); | ||
| 146 | agc_a = (val & IWL_OFDM_AGC_A_MSK) >> IWL_OFDM_AGC_A_POS; | ||
| 147 | agc_b = (val & IWL_OFDM_AGC_B_MSK) >> IWL_OFDM_AGC_B_POS; | ||
| 148 | max_agc = max_t(u32, agc_a, agc_b); | ||
| 149 | |||
| 143 | val = le32_to_cpu(phy_info->non_cfg_phy[IWL_RX_INFO_RSSI_AB_IDX]); | 150 | val = le32_to_cpu(phy_info->non_cfg_phy[IWL_RX_INFO_RSSI_AB_IDX]); |
| 144 | rssi_a = (val & IWL_OFDM_RSSI_INBAND_A_MSK) >> IWL_OFDM_RSSI_A_POS; | 151 | rssi_a = (val & IWL_OFDM_RSSI_INBAND_A_MSK) >> IWL_OFDM_RSSI_A_POS; |
| 145 | rssi_b = (val & IWL_OFDM_RSSI_INBAND_B_MSK) >> IWL_OFDM_RSSI_B_POS; | 152 | rssi_b = (val & IWL_OFDM_RSSI_INBAND_B_MSK) >> IWL_OFDM_RSSI_B_POS; |
| 146 | val = le32_to_cpu(phy_info->non_cfg_phy[IWL_RX_INFO_RSSI_C_IDX]); | 153 | rssi_all_band_a = (val & IWL_OFDM_RSSI_ALLBAND_A_MSK) >> |
| 147 | rssi_c = (val & IWL_OFDM_RSSI_INBAND_C_MSK) >> IWL_OFDM_RSSI_C_POS; | 154 | IWL_OFDM_RSSI_ALLBAND_A_POS; |
| 148 | 155 | rssi_all_band_b = (val & IWL_OFDM_RSSI_ALLBAND_B_MSK) >> | |
| 149 | val = le32_to_cpu(phy_info->non_cfg_phy[IWL_RX_INFO_AGC_IDX]); | 156 | IWL_OFDM_RSSI_ALLBAND_B_POS; |
| 150 | agc_db = (val & IWL_OFDM_AGC_DB_MSK) >> IWL_OFDM_AGC_DB_POS; | ||
| 151 | 157 | ||
| 152 | max_rssi = max_t(u32, rssi_a, rssi_b); | 158 | /* |
| 153 | max_rssi = max_t(u32, max_rssi, rssi_c); | 159 | * dBm = rssi dB - agc dB - constant. |
| 160 | * Higher AGC (higher radio gain) means lower signal. | ||
| 161 | */ | ||
| 162 | rssi_a_dbm = rssi_a - IWL_RSSI_OFFSET - agc_a; | ||
| 163 | rssi_b_dbm = rssi_b - IWL_RSSI_OFFSET - agc_b; | ||
| 164 | max_rssi_dbm = max_t(int, rssi_a_dbm, rssi_b_dbm); | ||
| 154 | 165 | ||
| 155 | IWL_DEBUG_STATS(mvm, "Rssi In A %d B %d C %d Max %d AGC dB %d\n", | 166 | IWL_DEBUG_STATS(mvm, "Rssi In A %d B %d Max %d AGCA %d AGCB %d\n", |
| 156 | rssi_a, rssi_b, rssi_c, max_rssi, agc_db); | 167 | rssi_a_dbm, rssi_b_dbm, max_rssi_dbm, agc_a, agc_b); |
| 157 | 168 | ||
| 158 | /* dBm = max_rssi dB - agc dB - constant. | 169 | return max_rssi_dbm; |
| 159 | * Higher AGC (higher radio gain) means lower signal. */ | ||
| 160 | return max_rssi - agc_db - IWL_RSSI_OFFSET; | ||
| 161 | } | 170 | } |
| 162 | 171 | ||
| 163 | /* | 172 | /* |
diff --git a/drivers/net/wireless/iwlwifi/mvm/sta.c b/drivers/net/wireless/iwlwifi/mvm/sta.c index 861a7f9f8e7f..274f44e2ef60 100644 --- a/drivers/net/wireless/iwlwifi/mvm/sta.c +++ b/drivers/net/wireless/iwlwifi/mvm/sta.c | |||
| @@ -770,6 +770,16 @@ int iwl_mvm_sta_tx_agg_stop(struct iwl_mvm *mvm, struct ieee80211_vif *vif, | |||
| 770 | u16 txq_id; | 770 | u16 txq_id; |
| 771 | int err; | 771 | int err; |
| 772 | 772 | ||
| 773 | |||
| 774 | /* | ||
| 775 | * If mac80211 is cleaning its state, then say that we finished since | ||
| 776 | * our state has been cleared anyway. | ||
| 777 | */ | ||
| 778 | if (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status)) { | ||
| 779 | ieee80211_stop_tx_ba_cb_irqsafe(vif, sta->addr, tid); | ||
| 780 | return 0; | ||
| 781 | } | ||
| 782 | |||
| 773 | spin_lock_bh(&mvmsta->lock); | 783 | spin_lock_bh(&mvmsta->lock); |
| 774 | 784 | ||
| 775 | txq_id = tid_data->txq_id; | 785 | txq_id = tid_data->txq_id; |
diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c b/drivers/net/wireless/iwlwifi/mvm/tx.c index 6b67ce3f679c..6645efe5c03e 100644 --- a/drivers/net/wireless/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/iwlwifi/mvm/tx.c | |||
| @@ -607,12 +607,8 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm, | |||
| 607 | 607 | ||
| 608 | /* Single frame failure in an AMPDU queue => send BAR */ | 608 | /* Single frame failure in an AMPDU queue => send BAR */ |
| 609 | if (txq_id >= IWL_FIRST_AMPDU_QUEUE && | 609 | if (txq_id >= IWL_FIRST_AMPDU_QUEUE && |
| 610 | !(info->flags & IEEE80211_TX_STAT_ACK)) { | 610 | !(info->flags & IEEE80211_TX_STAT_ACK)) |
| 611 | /* there must be only one skb in the skb_list */ | ||
| 612 | WARN_ON_ONCE(skb_freed > 1 || | ||
| 613 | !skb_queue_empty(&skbs)); | ||
| 614 | info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK; | 611 | info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK; |
| 615 | } | ||
| 616 | 612 | ||
| 617 | /* W/A FW bug: seq_ctl is wrong when the queue is flushed */ | 613 | /* W/A FW bug: seq_ctl is wrong when the queue is flushed */ |
| 618 | if (status == TX_STATUS_FAIL_FIFO_FLUSHED) { | 614 | if (status == TX_STATUS_FAIL_FIFO_FLUSHED) { |
diff --git a/drivers/net/wireless/iwlwifi/pcie/internal.h b/drivers/net/wireless/iwlwifi/pcie/internal.h index 3d62e8055352..148843e7f34f 100644 --- a/drivers/net/wireless/iwlwifi/pcie/internal.h +++ b/drivers/net/wireless/iwlwifi/pcie/internal.h | |||
| @@ -137,10 +137,6 @@ static inline int iwl_queue_dec_wrap(int index, int n_bd) | |||
| 137 | struct iwl_cmd_meta { | 137 | struct iwl_cmd_meta { |
| 138 | /* only for SYNC commands, iff the reply skb is wanted */ | 138 | /* only for SYNC commands, iff the reply skb is wanted */ |
| 139 | struct iwl_host_cmd *source; | 139 | struct iwl_host_cmd *source; |
| 140 | |||
| 141 | DEFINE_DMA_UNMAP_ADDR(mapping); | ||
| 142 | DEFINE_DMA_UNMAP_LEN(len); | ||
| 143 | |||
| 144 | u32 flags; | 140 | u32 flags; |
| 145 | }; | 141 | }; |
| 146 | 142 | ||
| @@ -185,25 +181,36 @@ struct iwl_queue { | |||
| 185 | /* | 181 | /* |
| 186 | * The FH will write back to the first TB only, so we need | 182 | * The FH will write back to the first TB only, so we need |
| 187 | * to copy some data into the buffer regardless of whether | 183 | * to copy some data into the buffer regardless of whether |
| 188 | * it should be mapped or not. This indicates how much to | 184 | * it should be mapped or not. This indicates how big the |
| 189 | * copy, even for HCMDs it must be big enough to fit the | 185 | * first TB must be to include the scratch buffer. Since |
| 190 | * DRAM scratch from the TX cmd, at least 16 bytes. | 186 | * the scratch is 4 bytes at offset 12, it's 16 now. If we |
| 187 | * make it bigger then allocations will be bigger and copy | ||
| 188 | * slower, so that's probably not useful. | ||
| 191 | */ | 189 | */ |
| 192 | #define IWL_HCMD_MIN_COPY_SIZE 16 | 190 | #define IWL_HCMD_SCRATCHBUF_SIZE 16 |
| 193 | 191 | ||
| 194 | struct iwl_pcie_txq_entry { | 192 | struct iwl_pcie_txq_entry { |
| 195 | struct iwl_device_cmd *cmd; | 193 | struct iwl_device_cmd *cmd; |
| 196 | struct iwl_device_cmd *copy_cmd; | ||
| 197 | struct sk_buff *skb; | 194 | struct sk_buff *skb; |
| 198 | /* buffer to free after command completes */ | 195 | /* buffer to free after command completes */ |
| 199 | const void *free_buf; | 196 | const void *free_buf; |
| 200 | struct iwl_cmd_meta meta; | 197 | struct iwl_cmd_meta meta; |
| 201 | }; | 198 | }; |
| 202 | 199 | ||
| 200 | struct iwl_pcie_txq_scratch_buf { | ||
| 201 | struct iwl_cmd_header hdr; | ||
| 202 | u8 buf[8]; | ||
| 203 | __le32 scratch; | ||
| 204 | }; | ||
| 205 | |||
| 203 | /** | 206 | /** |
| 204 | * struct iwl_txq - Tx Queue for DMA | 207 | * struct iwl_txq - Tx Queue for DMA |
| 205 | * @q: generic Rx/Tx queue descriptor | 208 | * @q: generic Rx/Tx queue descriptor |
| 206 | * @tfds: transmit frame descriptors (DMA memory) | 209 | * @tfds: transmit frame descriptors (DMA memory) |
| 210 | * @scratchbufs: start of command headers, including scratch buffers, for | ||
| 211 | * the writeback -- this is DMA memory and an array holding one buffer | ||
| 212 | * for each command on the queue | ||
| 213 | * @scratchbufs_dma: DMA address for the scratchbufs start | ||
| 207 | * @entries: transmit entries (driver state) | 214 | * @entries: transmit entries (driver state) |
| 208 | * @lock: queue lock | 215 | * @lock: queue lock |
| 209 | * @stuck_timer: timer that fires if queue gets stuck | 216 | * @stuck_timer: timer that fires if queue gets stuck |
| @@ -217,6 +224,8 @@ struct iwl_pcie_txq_entry { | |||
| 217 | struct iwl_txq { | 224 | struct iwl_txq { |
| 218 | struct iwl_queue q; | 225 | struct iwl_queue q; |
| 219 | struct iwl_tfd *tfds; | 226 | struct iwl_tfd *tfds; |
| 227 | struct iwl_pcie_txq_scratch_buf *scratchbufs; | ||
| 228 | dma_addr_t scratchbufs_dma; | ||
| 220 | struct iwl_pcie_txq_entry *entries; | 229 | struct iwl_pcie_txq_entry *entries; |
| 221 | spinlock_t lock; | 230 | spinlock_t lock; |
| 222 | struct timer_list stuck_timer; | 231 | struct timer_list stuck_timer; |
| @@ -225,6 +234,13 @@ struct iwl_txq { | |||
| 225 | u8 active; | 234 | u8 active; |
| 226 | }; | 235 | }; |
| 227 | 236 | ||
| 237 | static inline dma_addr_t | ||
| 238 | iwl_pcie_get_scratchbuf_dma(struct iwl_txq *txq, int idx) | ||
| 239 | { | ||
| 240 | return txq->scratchbufs_dma + | ||
| 241 | sizeof(struct iwl_pcie_txq_scratch_buf) * idx; | ||
| 242 | } | ||
| 243 | |||
| 228 | /** | 244 | /** |
| 229 | * struct iwl_trans_pcie - PCIe transport specific data | 245 | * struct iwl_trans_pcie - PCIe transport specific data |
| 230 | * @rxq: all the RX queue data | 246 | * @rxq: all the RX queue data |
diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c b/drivers/net/wireless/iwlwifi/pcie/rx.c index b0ae06d2456f..567e67ad1f61 100644 --- a/drivers/net/wireless/iwlwifi/pcie/rx.c +++ b/drivers/net/wireless/iwlwifi/pcie/rx.c | |||
| @@ -637,22 +637,14 @@ static void iwl_pcie_rx_handle_rb(struct iwl_trans *trans, | |||
| 637 | index = SEQ_TO_INDEX(sequence); | 637 | index = SEQ_TO_INDEX(sequence); |
| 638 | cmd_index = get_cmd_index(&txq->q, index); | 638 | cmd_index = get_cmd_index(&txq->q, index); |
| 639 | 639 | ||
| 640 | if (reclaim) { | 640 | if (reclaim) |
| 641 | struct iwl_pcie_txq_entry *ent; | 641 | cmd = txq->entries[cmd_index].cmd; |
| 642 | ent = &txq->entries[cmd_index]; | 642 | else |
| 643 | cmd = ent->copy_cmd; | ||
| 644 | WARN_ON_ONCE(!cmd && ent->meta.flags & CMD_WANT_HCMD); | ||
| 645 | } else { | ||
| 646 | cmd = NULL; | 643 | cmd = NULL; |
| 647 | } | ||
| 648 | 644 | ||
| 649 | err = iwl_op_mode_rx(trans->op_mode, &rxcb, cmd); | 645 | err = iwl_op_mode_rx(trans->op_mode, &rxcb, cmd); |
| 650 | 646 | ||
| 651 | if (reclaim) { | 647 | if (reclaim) { |
| 652 | /* The original command isn't needed any more */ | ||
| 653 | kfree(txq->entries[cmd_index].copy_cmd); | ||
| 654 | txq->entries[cmd_index].copy_cmd = NULL; | ||
| 655 | /* nor is the duplicated part of the command */ | ||
| 656 | kfree(txq->entries[cmd_index].free_buf); | 648 | kfree(txq->entries[cmd_index].free_buf); |
| 657 | txq->entries[cmd_index].free_buf = NULL; | 649 | txq->entries[cmd_index].free_buf = NULL; |
| 658 | } | 650 | } |
diff --git a/drivers/net/wireless/iwlwifi/pcie/tx.c b/drivers/net/wireless/iwlwifi/pcie/tx.c index 8b625a7f5685..8595c16f74de 100644 --- a/drivers/net/wireless/iwlwifi/pcie/tx.c +++ b/drivers/net/wireless/iwlwifi/pcie/tx.c | |||
| @@ -191,12 +191,9 @@ static void iwl_pcie_txq_stuck_timer(unsigned long data) | |||
| 191 | } | 191 | } |
| 192 | 192 | ||
| 193 | for (i = q->read_ptr; i != q->write_ptr; | 193 | for (i = q->read_ptr; i != q->write_ptr; |
| 194 | i = iwl_queue_inc_wrap(i, q->n_bd)) { | 194 | i = iwl_queue_inc_wrap(i, q->n_bd)) |
| 195 | struct iwl_tx_cmd *tx_cmd = | ||
| 196 | (struct iwl_tx_cmd *)txq->entries[i].cmd->payload; | ||
| 197 | IWL_ERR(trans, "scratch %d = 0x%08x\n", i, | 195 | IWL_ERR(trans, "scratch %d = 0x%08x\n", i, |
| 198 | get_unaligned_le32(&tx_cmd->scratch)); | 196 | le32_to_cpu(txq->scratchbufs[i].scratch)); |
| 199 | } | ||
| 200 | 197 | ||
| 201 | iwl_op_mode_nic_error(trans->op_mode); | 198 | iwl_op_mode_nic_error(trans->op_mode); |
| 202 | } | 199 | } |
| @@ -367,8 +364,8 @@ static inline u8 iwl_pcie_tfd_get_num_tbs(struct iwl_tfd *tfd) | |||
| 367 | } | 364 | } |
| 368 | 365 | ||
| 369 | static void iwl_pcie_tfd_unmap(struct iwl_trans *trans, | 366 | static void iwl_pcie_tfd_unmap(struct iwl_trans *trans, |
| 370 | struct iwl_cmd_meta *meta, struct iwl_tfd *tfd, | 367 | struct iwl_cmd_meta *meta, |
| 371 | enum dma_data_direction dma_dir) | 368 | struct iwl_tfd *tfd) |
| 372 | { | 369 | { |
| 373 | int i; | 370 | int i; |
| 374 | int num_tbs; | 371 | int num_tbs; |
| @@ -382,17 +379,12 @@ static void iwl_pcie_tfd_unmap(struct iwl_trans *trans, | |||
| 382 | return; | 379 | return; |
| 383 | } | 380 | } |
| 384 | 381 | ||
| 385 | /* Unmap tx_cmd */ | 382 | /* first TB is never freed - it's the scratchbuf data */ |
| 386 | if (num_tbs) | ||
| 387 | dma_unmap_single(trans->dev, | ||
| 388 | dma_unmap_addr(meta, mapping), | ||
| 389 | dma_unmap_len(meta, len), | ||
| 390 | DMA_BIDIRECTIONAL); | ||
| 391 | 383 | ||
| 392 | /* Unmap chunks, if any. */ | ||
| 393 | for (i = 1; i < num_tbs; i++) | 384 | for (i = 1; i < num_tbs; i++) |
| 394 | dma_unmap_single(trans->dev, iwl_pcie_tfd_tb_get_addr(tfd, i), | 385 | dma_unmap_single(trans->dev, iwl_pcie_tfd_tb_get_addr(tfd, i), |
| 395 | iwl_pcie_tfd_tb_get_len(tfd, i), dma_dir); | 386 | iwl_pcie_tfd_tb_get_len(tfd, i), |
| 387 | DMA_TO_DEVICE); | ||
| 396 | 388 | ||
| 397 | tfd->num_tbs = 0; | 389 | tfd->num_tbs = 0; |
| 398 | } | 390 | } |
| @@ -406,8 +398,7 @@ static void iwl_pcie_tfd_unmap(struct iwl_trans *trans, | |||
| 406 | * Does NOT advance any TFD circular buffer read/write indexes | 398 | * Does NOT advance any TFD circular buffer read/write indexes |
| 407 | * Does NOT free the TFD itself (which is within circular buffer) | 399 | * Does NOT free the TFD itself (which is within circular buffer) |
| 408 | */ | 400 | */ |
| 409 | static void iwl_pcie_txq_free_tfd(struct iwl_trans *trans, struct iwl_txq *txq, | 401 | static void iwl_pcie_txq_free_tfd(struct iwl_trans *trans, struct iwl_txq *txq) |
| 410 | enum dma_data_direction dma_dir) | ||
| 411 | { | 402 | { |
| 412 | struct iwl_tfd *tfd_tmp = txq->tfds; | 403 | struct iwl_tfd *tfd_tmp = txq->tfds; |
| 413 | 404 | ||
| @@ -418,8 +409,7 @@ static void iwl_pcie_txq_free_tfd(struct iwl_trans *trans, struct iwl_txq *txq, | |||
| 418 | lockdep_assert_held(&txq->lock); | 409 | lockdep_assert_held(&txq->lock); |
| 419 | 410 | ||
| 420 | /* We have only q->n_window txq->entries, but we use q->n_bd tfds */ | 411 | /* We have only q->n_window txq->entries, but we use q->n_bd tfds */ |
| 421 | iwl_pcie_tfd_unmap(trans, &txq->entries[idx].meta, &tfd_tmp[rd_ptr], | 412 | iwl_pcie_tfd_unmap(trans, &txq->entries[idx].meta, &tfd_tmp[rd_ptr]); |
| 422 | dma_dir); | ||
| 423 | 413 | ||
| 424 | /* free SKB */ | 414 | /* free SKB */ |
| 425 | if (txq->entries) { | 415 | if (txq->entries) { |
| @@ -479,6 +469,7 @@ static int iwl_pcie_txq_alloc(struct iwl_trans *trans, | |||
| 479 | { | 469 | { |
| 480 | struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); | 470 | struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); |
| 481 | size_t tfd_sz = sizeof(struct iwl_tfd) * TFD_QUEUE_SIZE_MAX; | 471 | size_t tfd_sz = sizeof(struct iwl_tfd) * TFD_QUEUE_SIZE_MAX; |
| 472 | size_t scratchbuf_sz; | ||
| 482 | int i; | 473 | int i; |
| 483 | 474 | ||
| 484 | if (WARN_ON(txq->entries || txq->tfds)) | 475 | if (WARN_ON(txq->entries || txq->tfds)) |
| @@ -514,9 +505,25 @@ static int iwl_pcie_txq_alloc(struct iwl_trans *trans, | |||
| 514 | IWL_ERR(trans, "dma_alloc_coherent(%zd) failed\n", tfd_sz); | 505 | IWL_ERR(trans, "dma_alloc_coherent(%zd) failed\n", tfd_sz); |
| 515 | goto error; | 506 | goto error; |
| 516 | } | 507 | } |
| 508 | |||
| 509 | BUILD_BUG_ON(IWL_HCMD_SCRATCHBUF_SIZE != sizeof(*txq->scratchbufs)); | ||
| 510 | BUILD_BUG_ON(offsetof(struct iwl_pcie_txq_scratch_buf, scratch) != | ||
| 511 | sizeof(struct iwl_cmd_header) + | ||
| 512 | offsetof(struct iwl_tx_cmd, scratch)); | ||
| 513 | |||
| 514 | scratchbuf_sz = sizeof(*txq->scratchbufs) * slots_num; | ||
| 515 | |||
| 516 | txq->scratchbufs = dma_alloc_coherent(trans->dev, scratchbuf_sz, | ||
| 517 | &txq->scratchbufs_dma, | ||
| 518 | GFP_KERNEL); | ||
| 519 | if (!txq->scratchbufs) | ||
| 520 | goto err_free_tfds; | ||
| 521 | |||
| 517 | txq->q.id = txq_id; | 522 | txq->q.id = txq_id; |
| 518 | 523 | ||
| 519 | return 0; | 524 | return 0; |
| 525 | err_free_tfds: | ||
| 526 | dma_free_coherent(trans->dev, tfd_sz, txq->tfds, txq->q.dma_addr); | ||
| 520 | error: | 527 | error: |
| 521 | if (txq->entries && txq_id == trans_pcie->cmd_queue) | 528 | if (txq->entries && txq_id == trans_pcie->cmd_queue) |
| 522 | for (i = 0; i < slots_num; i++) | 529 | for (i = 0; i < slots_num; i++) |
| @@ -565,22 +572,13 @@ static void iwl_pcie_txq_unmap(struct iwl_trans *trans, int txq_id) | |||
| 565 | struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); | 572 | struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); |
| 566 | struct iwl_txq *txq = &trans_pcie->txq[txq_id]; | 573 | struct iwl_txq *txq = &trans_pcie->txq[txq_id]; |
| 567 | struct iwl_queue *q = &txq->q; | 574 | struct iwl_queue *q = &txq->q; |
| 568 | enum dma_data_direction dma_dir; | ||
| 569 | 575 | ||
| 570 | if (!q->n_bd) | 576 | if (!q->n_bd) |
| 571 | return; | 577 | return; |
| 572 | 578 | ||
| 573 | /* In the command queue, all the TBs are mapped as BIDI | ||
| 574 | * so unmap them as such. | ||
| 575 | */ | ||
| 576 | if (txq_id == trans_pcie->cmd_queue) | ||
| 577 | dma_dir = DMA_BIDIRECTIONAL; | ||
| 578 | else | ||
| 579 | dma_dir = DMA_TO_DEVICE; | ||
| 580 | |||
| 581 | spin_lock_bh(&txq->lock); | 579 | spin_lock_bh(&txq->lock); |
| 582 | while (q->write_ptr != q->read_ptr) { | 580 | while (q->write_ptr != q->read_ptr) { |
| 583 | iwl_pcie_txq_free_tfd(trans, txq, dma_dir); | 581 | iwl_pcie_txq_free_tfd(trans, txq); |
| 584 | q->read_ptr = iwl_queue_inc_wrap(q->read_ptr, q->n_bd); | 582 | q->read_ptr = iwl_queue_inc_wrap(q->read_ptr, q->n_bd); |
| 585 | } | 583 | } |
| 586 | spin_unlock_bh(&txq->lock); | 584 | spin_unlock_bh(&txq->lock); |
| @@ -610,7 +608,6 @@ static void iwl_pcie_txq_free(struct iwl_trans *trans, int txq_id) | |||
| 610 | if (txq_id == trans_pcie->cmd_queue) | 608 | if (txq_id == trans_pcie->cmd_queue) |
| 611 | for (i = 0; i < txq->q.n_window; i++) { | 609 | for (i = 0; i < txq->q.n_window; i++) { |
| 612 | kfree(txq->entries[i].cmd); | 610 | kfree(txq->entries[i].cmd); |
| 613 | kfree(txq->entries[i].copy_cmd); | ||
| 614 | kfree(txq->entries[i].free_buf); | 611 | kfree(txq->entries[i].free_buf); |
| 615 | } | 612 | } |
| 616 | 613 | ||
| @@ -619,6 +616,10 @@ static void iwl_pcie_txq_free(struct iwl_trans *trans, int txq_id) | |||
| 619 | dma_free_coherent(dev, sizeof(struct iwl_tfd) * | 616 | dma_free_coherent(dev, sizeof(struct iwl_tfd) * |
| 620 | txq->q.n_bd, txq->tfds, txq->q.dma_addr); | 617 | txq->q.n_bd, txq->tfds, txq->q.dma_addr); |
| 621 | txq->q.dma_addr = 0; | 618 | txq->q.dma_addr = 0; |
| 619 | |||
| 620 | dma_free_coherent(dev, | ||
| 621 | sizeof(*txq->scratchbufs) * txq->q.n_window, | ||
| 622 | txq->scratchbufs, txq->scratchbufs_dma); | ||
| 622 | } | 623 | } |
| 623 | 624 | ||
| 624 | kfree(txq->entries); | 625 | kfree(txq->entries); |
| @@ -962,7 +963,7 @@ void iwl_trans_pcie_reclaim(struct iwl_trans *trans, int txq_id, int ssn, | |||
| 962 | 963 | ||
| 963 | iwl_pcie_txq_inval_byte_cnt_tbl(trans, txq); | 964 | iwl_pcie_txq_inval_byte_cnt_tbl(trans, txq); |
| 964 | 965 | ||
| 965 | iwl_pcie_txq_free_tfd(trans, txq, DMA_TO_DEVICE); | 966 | iwl_pcie_txq_free_tfd(trans, txq); |
| 966 | } | 967 | } |
| 967 | 968 | ||
| 968 | iwl_pcie_txq_progress(trans_pcie, txq); | 969 | iwl_pcie_txq_progress(trans_pcie, txq); |
| @@ -1152,29 +1153,29 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *trans, | |||
| 1152 | void *dup_buf = NULL; | 1153 | void *dup_buf = NULL; |
| 1153 | dma_addr_t phys_addr; | 1154 | dma_addr_t phys_addr; |
| 1154 | int idx; | 1155 | int idx; |
| 1155 | u16 copy_size, cmd_size, dma_size; | 1156 | u16 copy_size, cmd_size, scratch_size; |
| 1156 | bool had_nocopy = false; | 1157 | bool had_nocopy = false; |
| 1157 | int i; | 1158 | int i; |
| 1158 | u32 cmd_pos; | 1159 | u32 cmd_pos; |
| 1159 | const u8 *cmddata[IWL_MAX_CMD_TFDS]; | 1160 | const u8 *cmddata[IWL_MAX_CMD_TBS_PER_TFD]; |
| 1160 | u16 cmdlen[IWL_MAX_CMD_TFDS]; | 1161 | u16 cmdlen[IWL_MAX_CMD_TBS_PER_TFD]; |
| 1161 | 1162 | ||
| 1162 | copy_size = sizeof(out_cmd->hdr); | 1163 | copy_size = sizeof(out_cmd->hdr); |
| 1163 | cmd_size = sizeof(out_cmd->hdr); | 1164 | cmd_size = sizeof(out_cmd->hdr); |
| 1164 | 1165 | ||
| 1165 | /* need one for the header if the first is NOCOPY */ | 1166 | /* need one for the header if the first is NOCOPY */ |
| 1166 | BUILD_BUG_ON(IWL_MAX_CMD_TFDS > IWL_NUM_OF_TBS - 1); | 1167 | BUILD_BUG_ON(IWL_MAX_CMD_TBS_PER_TFD > IWL_NUM_OF_TBS - 1); |
| 1167 | 1168 | ||
| 1168 | for (i = 0; i < IWL_MAX_CMD_TFDS; i++) { | 1169 | for (i = 0; i < IWL_MAX_CMD_TBS_PER_TFD; i++) { |
| 1169 | cmddata[i] = cmd->data[i]; | 1170 | cmddata[i] = cmd->data[i]; |
| 1170 | cmdlen[i] = cmd->len[i]; | 1171 | cmdlen[i] = cmd->len[i]; |
| 1171 | 1172 | ||
| 1172 | if (!cmd->len[i]) | 1173 | if (!cmd->len[i]) |
| 1173 | continue; | 1174 | continue; |
| 1174 | 1175 | ||
| 1175 | /* need at least IWL_HCMD_MIN_COPY_SIZE copied */ | 1176 | /* need at least IWL_HCMD_SCRATCHBUF_SIZE copied */ |
| 1176 | if (copy_size < IWL_HCMD_MIN_COPY_SIZE) { | 1177 | if (copy_size < IWL_HCMD_SCRATCHBUF_SIZE) { |
| 1177 | int copy = IWL_HCMD_MIN_COPY_SIZE - copy_size; | 1178 | int copy = IWL_HCMD_SCRATCHBUF_SIZE - copy_size; |
| 1178 | 1179 | ||
| 1179 | if (copy > cmdlen[i]) | 1180 | if (copy > cmdlen[i]) |
| 1180 | copy = cmdlen[i]; | 1181 | copy = cmdlen[i]; |
| @@ -1260,15 +1261,15 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *trans, | |||
| 1260 | /* and copy the data that needs to be copied */ | 1261 | /* and copy the data that needs to be copied */ |
| 1261 | cmd_pos = offsetof(struct iwl_device_cmd, payload); | 1262 | cmd_pos = offsetof(struct iwl_device_cmd, payload); |
| 1262 | copy_size = sizeof(out_cmd->hdr); | 1263 | copy_size = sizeof(out_cmd->hdr); |
| 1263 | for (i = 0; i < IWL_MAX_CMD_TFDS; i++) { | 1264 | for (i = 0; i < IWL_MAX_CMD_TBS_PER_TFD; i++) { |
| 1264 | int copy = 0; | 1265 | int copy = 0; |
| 1265 | 1266 | ||
| 1266 | if (!cmd->len) | 1267 | if (!cmd->len) |
| 1267 | continue; | 1268 | continue; |
| 1268 | 1269 | ||
| 1269 | /* need at least IWL_HCMD_MIN_COPY_SIZE copied */ | 1270 | /* need at least IWL_HCMD_SCRATCHBUF_SIZE copied */ |
| 1270 | if (copy_size < IWL_HCMD_MIN_COPY_SIZE) { | 1271 | if (copy_size < IWL_HCMD_SCRATCHBUF_SIZE) { |
| 1271 | copy = IWL_HCMD_MIN_COPY_SIZE - copy_size; | 1272 | copy = IWL_HCMD_SCRATCHBUF_SIZE - copy_size; |
| 1272 | 1273 | ||
| 1273 | if (copy > cmd->len[i]) | 1274 | if (copy > cmd->len[i]) |
| 1274 | copy = cmd->len[i]; | 1275 | copy = cmd->len[i]; |
| @@ -1286,50 +1287,38 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *trans, | |||
| 1286 | } | 1287 | } |
| 1287 | } | 1288 | } |
| 1288 | 1289 | ||
| 1289 | WARN_ON_ONCE(txq->entries[idx].copy_cmd); | ||
| 1290 | |||
| 1291 | /* | ||
| 1292 | * since out_cmd will be the source address of the FH, it will write | ||
| 1293 | * the retry count there. So when the user needs to receivce the HCMD | ||
| 1294 | * that corresponds to the response in the response handler, it needs | ||
| 1295 | * to set CMD_WANT_HCMD. | ||
| 1296 | */ | ||
| 1297 | if (cmd->flags & CMD_WANT_HCMD) { | ||
| 1298 | txq->entries[idx].copy_cmd = | ||
| 1299 | kmemdup(out_cmd, cmd_pos, GFP_ATOMIC); | ||
| 1300 | if (unlikely(!txq->entries[idx].copy_cmd)) { | ||
| 1301 | idx = -ENOMEM; | ||
| 1302 | goto out; | ||
| 1303 | } | ||
| 1304 | } | ||
| 1305 | |||
| 1306 | IWL_DEBUG_HC(trans, | 1290 | IWL_DEBUG_HC(trans, |
| 1307 | "Sending command %s (#%x), seq: 0x%04X, %d bytes at %d[%d]:%d\n", | 1291 | "Sending command %s (#%x), seq: 0x%04X, %d bytes at %d[%d]:%d\n", |
| 1308 | get_cmd_string(trans_pcie, out_cmd->hdr.cmd), | 1292 | get_cmd_string(trans_pcie, out_cmd->hdr.cmd), |
| 1309 | out_cmd->hdr.cmd, le16_to_cpu(out_cmd->hdr.sequence), | 1293 | out_cmd->hdr.cmd, le16_to_cpu(out_cmd->hdr.sequence), |
| 1310 | cmd_size, q->write_ptr, idx, trans_pcie->cmd_queue); | 1294 | cmd_size, q->write_ptr, idx, trans_pcie->cmd_queue); |
| 1311 | 1295 | ||
| 1312 | /* | 1296 | /* start the TFD with the scratchbuf */ |
| 1313 | * If the entire command is smaller than IWL_HCMD_MIN_COPY_SIZE, we must | 1297 | scratch_size = min_t(int, copy_size, IWL_HCMD_SCRATCHBUF_SIZE); |
| 1314 | * still map at least that many bytes for the hardware to write back to. | 1298 | memcpy(&txq->scratchbufs[q->write_ptr], &out_cmd->hdr, scratch_size); |
| 1315 | * We have enough space, so that's not a problem. | 1299 | iwl_pcie_txq_build_tfd(trans, txq, |
| 1316 | */ | 1300 | iwl_pcie_get_scratchbuf_dma(txq, q->write_ptr), |
| 1317 | dma_size = max_t(u16, copy_size, IWL_HCMD_MIN_COPY_SIZE); | 1301 | scratch_size, 1); |
| 1302 | |||
| 1303 | /* map first command fragment, if any remains */ | ||
| 1304 | if (copy_size > scratch_size) { | ||
| 1305 | phys_addr = dma_map_single(trans->dev, | ||
| 1306 | ((u8 *)&out_cmd->hdr) + scratch_size, | ||
| 1307 | copy_size - scratch_size, | ||
| 1308 | DMA_TO_DEVICE); | ||
| 1309 | if (dma_mapping_error(trans->dev, phys_addr)) { | ||
| 1310 | iwl_pcie_tfd_unmap(trans, out_meta, | ||
| 1311 | &txq->tfds[q->write_ptr]); | ||
| 1312 | idx = -ENOMEM; | ||
| 1313 | goto out; | ||
| 1314 | } | ||
| 1318 | 1315 | ||
| 1319 | phys_addr = dma_map_single(trans->dev, &out_cmd->hdr, dma_size, | 1316 | iwl_pcie_txq_build_tfd(trans, txq, phys_addr, |
| 1320 | DMA_BIDIRECTIONAL); | 1317 | copy_size - scratch_size, 0); |
| 1321 | if (unlikely(dma_mapping_error(trans->dev, phys_addr))) { | ||
| 1322 | idx = -ENOMEM; | ||
| 1323 | goto out; | ||
| 1324 | } | 1318 | } |
| 1325 | 1319 | ||
| 1326 | dma_unmap_addr_set(out_meta, mapping, phys_addr); | ||
| 1327 | dma_unmap_len_set(out_meta, len, dma_size); | ||
| 1328 | |||
| 1329 | iwl_pcie_txq_build_tfd(trans, txq, phys_addr, copy_size, 1); | ||
| 1330 | |||
| 1331 | /* map the remaining (adjusted) nocopy/dup fragments */ | 1320 | /* map the remaining (adjusted) nocopy/dup fragments */ |
| 1332 | for (i = 0; i < IWL_MAX_CMD_TFDS; i++) { | 1321 | for (i = 0; i < IWL_MAX_CMD_TBS_PER_TFD; i++) { |
| 1333 | const void *data = cmddata[i]; | 1322 | const void *data = cmddata[i]; |
| 1334 | 1323 | ||
| 1335 | if (!cmdlen[i]) | 1324 | if (!cmdlen[i]) |
| @@ -1340,11 +1329,10 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *trans, | |||
| 1340 | if (cmd->dataflags[i] & IWL_HCMD_DFL_DUP) | 1329 | if (cmd->dataflags[i] & IWL_HCMD_DFL_DUP) |
| 1341 | data = dup_buf; | 1330 | data = dup_buf; |
| 1342 | phys_addr = dma_map_single(trans->dev, (void *)data, | 1331 | phys_addr = dma_map_single(trans->dev, (void *)data, |
| 1343 | cmdlen[i], DMA_BIDIRECTIONAL); | 1332 | cmdlen[i], DMA_TO_DEVICE); |
| 1344 | if (dma_mapping_error(trans->dev, phys_addr)) { | 1333 | if (dma_mapping_error(trans->dev, phys_addr)) { |
| 1345 | iwl_pcie_tfd_unmap(trans, out_meta, | 1334 | iwl_pcie_tfd_unmap(trans, out_meta, |
| 1346 | &txq->tfds[q->write_ptr], | 1335 | &txq->tfds[q->write_ptr]); |
| 1347 | DMA_BIDIRECTIONAL); | ||
| 1348 | idx = -ENOMEM; | 1336 | idx = -ENOMEM; |
| 1349 | goto out; | 1337 | goto out; |
| 1350 | } | 1338 | } |
| @@ -1418,7 +1406,7 @@ void iwl_pcie_hcmd_complete(struct iwl_trans *trans, | |||
| 1418 | cmd = txq->entries[cmd_index].cmd; | 1406 | cmd = txq->entries[cmd_index].cmd; |
| 1419 | meta = &txq->entries[cmd_index].meta; | 1407 | meta = &txq->entries[cmd_index].meta; |
| 1420 | 1408 | ||
| 1421 | iwl_pcie_tfd_unmap(trans, meta, &txq->tfds[index], DMA_BIDIRECTIONAL); | 1409 | iwl_pcie_tfd_unmap(trans, meta, &txq->tfds[index]); |
| 1422 | 1410 | ||
| 1423 | /* Input error checking is done when commands are added to queue. */ | 1411 | /* Input error checking is done when commands are added to queue. */ |
| 1424 | if (meta->flags & CMD_WANT_SKB) { | 1412 | if (meta->flags & CMD_WANT_SKB) { |
| @@ -1597,10 +1585,9 @@ int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, | |||
| 1597 | struct iwl_cmd_meta *out_meta; | 1585 | struct iwl_cmd_meta *out_meta; |
| 1598 | struct iwl_txq *txq; | 1586 | struct iwl_txq *txq; |
| 1599 | struct iwl_queue *q; | 1587 | struct iwl_queue *q; |
| 1600 | dma_addr_t phys_addr = 0; | 1588 | dma_addr_t tb0_phys, tb1_phys, scratch_phys; |
| 1601 | dma_addr_t txcmd_phys; | 1589 | void *tb1_addr; |
| 1602 | dma_addr_t scratch_phys; | 1590 | u16 len, tb1_len, tb2_len; |
| 1603 | u16 len, firstlen, secondlen; | ||
| 1604 | u8 wait_write_ptr = 0; | 1591 | u8 wait_write_ptr = 0; |
| 1605 | __le16 fc = hdr->frame_control; | 1592 | __le16 fc = hdr->frame_control; |
| 1606 | u8 hdr_len = ieee80211_hdrlen(fc); | 1593 | u8 hdr_len = ieee80211_hdrlen(fc); |
| @@ -1638,85 +1625,80 @@ int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, | |||
| 1638 | cpu_to_le16((u16)(QUEUE_TO_SEQ(txq_id) | | 1625 | cpu_to_le16((u16)(QUEUE_TO_SEQ(txq_id) | |
| 1639 | INDEX_TO_SEQ(q->write_ptr))); | 1626 | INDEX_TO_SEQ(q->write_ptr))); |
| 1640 | 1627 | ||
| 1628 | tb0_phys = iwl_pcie_get_scratchbuf_dma(txq, q->write_ptr); | ||
| 1629 | scratch_phys = tb0_phys + sizeof(struct iwl_cmd_header) + | ||
| 1630 | offsetof(struct iwl_tx_cmd, scratch); | ||
| 1631 | |||
| 1632 | tx_cmd->dram_lsb_ptr = cpu_to_le32(scratch_phys); | ||
| 1633 | tx_cmd->dram_msb_ptr = iwl_get_dma_hi_addr(scratch_phys); | ||
| 1634 | |||
| 1641 | /* Set up first empty entry in queue's array of Tx/cmd buffers */ | 1635 | /* Set up first empty entry in queue's array of Tx/cmd buffers */ |
| 1642 | out_meta = &txq->entries[q->write_ptr].meta; | 1636 | out_meta = &txq->entries[q->write_ptr].meta; |
| 1643 | 1637 | ||
| 1644 | /* | 1638 | /* |
| 1645 | * Use the first empty entry in this queue's command buffer array | 1639 | * The second TB (tb1) points to the remainder of the TX command |
| 1646 | * to contain the Tx command and MAC header concatenated together | 1640 | * and the 802.11 header - dword aligned size |
| 1647 | * (payload data will be in another buffer). | 1641 | * (This calculation modifies the TX command, so do it before the |
| 1648 | * Size of this varies, due to varying MAC header length. | 1642 | * setup of the first TB) |
| 1649 | * If end is not dword aligned, we'll have 2 extra bytes at the end | ||
| 1650 | * of the MAC header (device reads on dword boundaries). | ||
| 1651 | * We'll tell device about this padding later. | ||
| 1652 | */ | 1643 | */ |
| 1653 | len = sizeof(struct iwl_tx_cmd) + | 1644 | len = sizeof(struct iwl_tx_cmd) + sizeof(struct iwl_cmd_header) + |
| 1654 | sizeof(struct iwl_cmd_header) + hdr_len; | 1645 | hdr_len - IWL_HCMD_SCRATCHBUF_SIZE; |
| 1655 | firstlen = (len + 3) & ~3; | 1646 | tb1_len = (len + 3) & ~3; |
| 1656 | 1647 | ||
| 1657 | /* Tell NIC about any 2-byte padding after MAC header */ | 1648 | /* Tell NIC about any 2-byte padding after MAC header */ |
| 1658 | if (firstlen != len) | 1649 | if (tb1_len != len) |
| 1659 | tx_cmd->tx_flags |= TX_CMD_FLG_MH_PAD_MSK; | 1650 | tx_cmd->tx_flags |= TX_CMD_FLG_MH_PAD_MSK; |
| 1660 | 1651 | ||
| 1661 | /* Physical address of this Tx command's header (not MAC header!), | 1652 | /* The first TB points to the scratchbuf data - min_copy bytes */ |
| 1662 | * within command buffer array. */ | 1653 | memcpy(&txq->scratchbufs[q->write_ptr], &dev_cmd->hdr, |
| 1663 | txcmd_phys = dma_map_single(trans->dev, | 1654 | IWL_HCMD_SCRATCHBUF_SIZE); |
| 1664 | &dev_cmd->hdr, firstlen, | 1655 | iwl_pcie_txq_build_tfd(trans, txq, tb0_phys, |
| 1665 | DMA_BIDIRECTIONAL); | 1656 | IWL_HCMD_SCRATCHBUF_SIZE, 1); |
| 1666 | if (unlikely(dma_mapping_error(trans->dev, txcmd_phys))) | ||
| 1667 | goto out_err; | ||
| 1668 | dma_unmap_addr_set(out_meta, mapping, txcmd_phys); | ||
| 1669 | dma_unmap_len_set(out_meta, len, firstlen); | ||
| 1670 | 1657 | ||
| 1671 | if (!ieee80211_has_morefrags(fc)) { | 1658 | /* there must be data left over for TB1 or this code must be changed */ |
| 1672 | txq->need_update = 1; | 1659 | BUILD_BUG_ON(sizeof(struct iwl_tx_cmd) < IWL_HCMD_SCRATCHBUF_SIZE); |
| 1673 | } else { | ||
| 1674 | wait_write_ptr = 1; | ||
| 1675 | txq->need_update = 0; | ||
| 1676 | } | ||
| 1677 | 1660 | ||
| 1678 | /* Set up TFD's 2nd entry to point directly to remainder of skb, | 1661 | /* map the data for TB1 */ |
| 1679 | * if any (802.11 null frames have no payload). */ | 1662 | tb1_addr = ((u8 *)&dev_cmd->hdr) + IWL_HCMD_SCRATCHBUF_SIZE; |
| 1680 | secondlen = skb->len - hdr_len; | 1663 | tb1_phys = dma_map_single(trans->dev, tb1_addr, tb1_len, DMA_TO_DEVICE); |
| 1681 | if (secondlen > 0) { | 1664 | if (unlikely(dma_mapping_error(trans->dev, tb1_phys))) |
| 1682 | phys_addr = dma_map_single(trans->dev, skb->data + hdr_len, | 1665 | goto out_err; |
| 1683 | secondlen, DMA_TO_DEVICE); | 1666 | iwl_pcie_txq_build_tfd(trans, txq, tb1_phys, tb1_len, 0); |
| 1684 | if (unlikely(dma_mapping_error(trans->dev, phys_addr))) { | 1667 | |
| 1685 | dma_unmap_single(trans->dev, | 1668 | /* |
| 1686 | dma_unmap_addr(out_meta, mapping), | 1669 | * Set up TFD's third entry to point directly to remainder |
| 1687 | dma_unmap_len(out_meta, len), | 1670 | * of skb, if any (802.11 null frames have no payload). |
| 1688 | DMA_BIDIRECTIONAL); | 1671 | */ |
| 1672 | tb2_len = skb->len - hdr_len; | ||
| 1673 | if (tb2_len > 0) { | ||
| 1674 | dma_addr_t tb2_phys = dma_map_single(trans->dev, | ||
| 1675 | skb->data + hdr_len, | ||
| 1676 | tb2_len, DMA_TO_DEVICE); | ||
| 1677 | if (unlikely(dma_mapping_error(trans->dev, tb2_phys))) { | ||
| 1678 | iwl_pcie_tfd_unmap(trans, out_meta, | ||
| 1679 | &txq->tfds[q->write_ptr]); | ||
| 1689 | goto out_err; | 1680 | goto out_err; |
| 1690 | } | 1681 | } |
| 1682 | iwl_pcie_txq_build_tfd(trans, txq, tb2_phys, tb2_len, 0); | ||
| 1691 | } | 1683 | } |
| 1692 | 1684 | ||
| 1693 | /* Attach buffers to TFD */ | ||
| 1694 | iwl_pcie_txq_build_tfd(trans, txq, txcmd_phys, firstlen, 1); | ||
| 1695 | if (secondlen > 0) | ||
| 1696 | iwl_pcie_txq_build_tfd(trans, txq, phys_addr, secondlen, 0); | ||
| 1697 | |||
| 1698 | scratch_phys = txcmd_phys + sizeof(struct iwl_cmd_header) + | ||
| 1699 | offsetof(struct iwl_tx_cmd, scratch); | ||
| 1700 | |||
| 1701 | /* take back ownership of DMA buffer to enable update */ | ||
| 1702 | dma_sync_single_for_cpu(trans->dev, txcmd_phys, firstlen, | ||
| 1703 | DMA_BIDIRECTIONAL); | ||
| 1704 | tx_cmd->dram_lsb_ptr = cpu_to_le32(scratch_phys); | ||
| 1705 | tx_cmd->dram_msb_ptr = iwl_get_dma_hi_addr(scratch_phys); | ||
| 1706 | |||
| 1707 | /* Set up entry for this TFD in Tx byte-count array */ | 1685 | /* Set up entry for this TFD in Tx byte-count array */ |
| 1708 | iwl_pcie_txq_update_byte_cnt_tbl(trans, txq, le16_to_cpu(tx_cmd->len)); | 1686 | iwl_pcie_txq_update_byte_cnt_tbl(trans, txq, le16_to_cpu(tx_cmd->len)); |
| 1709 | 1687 | ||
| 1710 | dma_sync_single_for_device(trans->dev, txcmd_phys, firstlen, | ||
| 1711 | DMA_BIDIRECTIONAL); | ||
| 1712 | |||
| 1713 | trace_iwlwifi_dev_tx(trans->dev, skb, | 1688 | trace_iwlwifi_dev_tx(trans->dev, skb, |
| 1714 | &txq->tfds[txq->q.write_ptr], | 1689 | &txq->tfds[txq->q.write_ptr], |
| 1715 | sizeof(struct iwl_tfd), | 1690 | sizeof(struct iwl_tfd), |
| 1716 | &dev_cmd->hdr, firstlen, | 1691 | &dev_cmd->hdr, IWL_HCMD_SCRATCHBUF_SIZE + tb1_len, |
| 1717 | skb->data + hdr_len, secondlen); | 1692 | skb->data + hdr_len, tb2_len); |
| 1718 | trace_iwlwifi_dev_tx_data(trans->dev, skb, | 1693 | trace_iwlwifi_dev_tx_data(trans->dev, skb, |
| 1719 | skb->data + hdr_len, secondlen); | 1694 | skb->data + hdr_len, tb2_len); |
| 1695 | |||
| 1696 | if (!ieee80211_has_morefrags(fc)) { | ||
| 1697 | txq->need_update = 1; | ||
| 1698 | } else { | ||
| 1699 | wait_write_ptr = 1; | ||
| 1700 | txq->need_update = 0; | ||
| 1701 | } | ||
| 1720 | 1702 | ||
| 1721 | /* start timer if queue currently empty */ | 1703 | /* start timer if queue currently empty */ |
| 1722 | if (txq->need_update && q->read_ptr == q->write_ptr && | 1704 | if (txq->need_update && q->read_ptr == q->write_ptr && |
diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c index 57233c885998..8f87fec27ce7 100644 --- a/drivers/rtc/rtc-mv.c +++ b/drivers/rtc/rtc-mv.c | |||
| @@ -14,6 +14,7 @@ | |||
| 14 | #include <linux/platform_device.h> | 14 | #include <linux/platform_device.h> |
| 15 | #include <linux/of.h> | 15 | #include <linux/of.h> |
| 16 | #include <linux/delay.h> | 16 | #include <linux/delay.h> |
| 17 | #include <linux/clk.h> | ||
| 17 | #include <linux/gfp.h> | 18 | #include <linux/gfp.h> |
| 18 | #include <linux/module.h> | 19 | #include <linux/module.h> |
| 19 | 20 | ||
| @@ -41,6 +42,7 @@ struct rtc_plat_data { | |||
| 41 | struct rtc_device *rtc; | 42 | struct rtc_device *rtc; |
| 42 | void __iomem *ioaddr; | 43 | void __iomem *ioaddr; |
| 43 | int irq; | 44 | int irq; |
| 45 | struct clk *clk; | ||
| 44 | }; | 46 | }; |
| 45 | 47 | ||
| 46 | static int mv_rtc_set_time(struct device *dev, struct rtc_time *tm) | 48 | static int mv_rtc_set_time(struct device *dev, struct rtc_time *tm) |
| @@ -221,6 +223,7 @@ static int mv_rtc_probe(struct platform_device *pdev) | |||
| 221 | struct rtc_plat_data *pdata; | 223 | struct rtc_plat_data *pdata; |
| 222 | resource_size_t size; | 224 | resource_size_t size; |
| 223 | u32 rtc_time; | 225 | u32 rtc_time; |
| 226 | int ret = 0; | ||
| 224 | 227 | ||
| 225 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 228 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| 226 | if (!res) | 229 | if (!res) |
| @@ -239,11 +242,17 @@ static int mv_rtc_probe(struct platform_device *pdev) | |||
| 239 | if (!pdata->ioaddr) | 242 | if (!pdata->ioaddr) |
| 240 | return -ENOMEM; | 243 | return -ENOMEM; |
| 241 | 244 | ||
| 245 | pdata->clk = devm_clk_get(&pdev->dev, NULL); | ||
| 246 | /* Not all SoCs require a clock.*/ | ||
| 247 | if (!IS_ERR(pdata->clk)) | ||
| 248 | clk_prepare_enable(pdata->clk); | ||
| 249 | |||
| 242 | /* make sure the 24 hours mode is enabled */ | 250 | /* make sure the 24 hours mode is enabled */ |
| 243 | rtc_time = readl(pdata->ioaddr + RTC_TIME_REG_OFFS); | 251 | rtc_time = readl(pdata->ioaddr + RTC_TIME_REG_OFFS); |
| 244 | if (rtc_time & RTC_HOURS_12H_MODE) { | 252 | if (rtc_time & RTC_HOURS_12H_MODE) { |
| 245 | dev_err(&pdev->dev, "24 Hours mode not supported.\n"); | 253 | dev_err(&pdev->dev, "24 Hours mode not supported.\n"); |
| 246 | return -EINVAL; | 254 | ret = -EINVAL; |
| 255 | goto out; | ||
| 247 | } | 256 | } |
| 248 | 257 | ||
| 249 | /* make sure it is actually functional */ | 258 | /* make sure it is actually functional */ |
| @@ -252,7 +261,8 @@ static int mv_rtc_probe(struct platform_device *pdev) | |||
| 252 | rtc_time = readl(pdata->ioaddr + RTC_TIME_REG_OFFS); | 261 | rtc_time = readl(pdata->ioaddr + RTC_TIME_REG_OFFS); |
| 253 | if (rtc_time == 0x01000000) { | 262 | if (rtc_time == 0x01000000) { |
| 254 | dev_err(&pdev->dev, "internal RTC not ticking\n"); | 263 | dev_err(&pdev->dev, "internal RTC not ticking\n"); |
| 255 | return -ENODEV; | 264 | ret = -ENODEV; |
| 265 | goto out; | ||
| 256 | } | 266 | } |
| 257 | } | 267 | } |
| 258 | 268 | ||
| @@ -268,8 +278,10 @@ static int mv_rtc_probe(struct platform_device *pdev) | |||
| 268 | } else | 278 | } else |
| 269 | pdata->rtc = rtc_device_register(pdev->name, &pdev->dev, | 279 | pdata->rtc = rtc_device_register(pdev->name, &pdev->dev, |
| 270 | &mv_rtc_ops, THIS_MODULE); | 280 | &mv_rtc_ops, THIS_MODULE); |
| 271 | if (IS_ERR(pdata->rtc)) | 281 | if (IS_ERR(pdata->rtc)) { |
| 272 | return PTR_ERR(pdata->rtc); | 282 | ret = PTR_ERR(pdata->rtc); |
| 283 | goto out; | ||
| 284 | } | ||
| 273 | 285 | ||
| 274 | if (pdata->irq >= 0) { | 286 | if (pdata->irq >= 0) { |
| 275 | writel(0, pdata->ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); | 287 | writel(0, pdata->ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); |
| @@ -282,6 +294,11 @@ static int mv_rtc_probe(struct platform_device *pdev) | |||
| 282 | } | 294 | } |
| 283 | 295 | ||
| 284 | return 0; | 296 | return 0; |
| 297 | out: | ||
| 298 | if (!IS_ERR(pdata->clk)) | ||
| 299 | clk_disable_unprepare(pdata->clk); | ||
| 300 | |||
| 301 | return ret; | ||
| 285 | } | 302 | } |
| 286 | 303 | ||
| 287 | static int __exit mv_rtc_remove(struct platform_device *pdev) | 304 | static int __exit mv_rtc_remove(struct platform_device *pdev) |
| @@ -292,6 +309,9 @@ static int __exit mv_rtc_remove(struct platform_device *pdev) | |||
| 292 | device_init_wakeup(&pdev->dev, 0); | 309 | device_init_wakeup(&pdev->dev, 0); |
| 293 | 310 | ||
| 294 | rtc_device_unregister(pdata->rtc); | 311 | rtc_device_unregister(pdata->rtc); |
| 312 | if (!IS_ERR(pdata->clk)) | ||
| 313 | clk_disable_unprepare(pdata->clk); | ||
| 314 | |||
| 295 | return 0; | 315 | return 0; |
| 296 | } | 316 | } |
| 297 | 317 | ||
diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 192cf088f834..57b451904791 100644 --- a/drivers/staging/comedi/drivers/dt9812.c +++ b/drivers/staging/comedi/drivers/dt9812.c | |||
| @@ -947,12 +947,13 @@ static int dt9812_di_rinsn(struct comedi_device *dev, | |||
| 947 | unsigned int *data) | 947 | unsigned int *data) |
| 948 | { | 948 | { |
| 949 | struct comedi_dt9812 *devpriv = dev->private; | 949 | struct comedi_dt9812 *devpriv = dev->private; |
| 950 | unsigned int channel = CR_CHAN(insn->chanspec); | ||
| 950 | int n; | 951 | int n; |
| 951 | u8 bits = 0; | 952 | u8 bits = 0; |
| 952 | 953 | ||
| 953 | dt9812_digital_in(devpriv->slot, &bits); | 954 | dt9812_digital_in(devpriv->slot, &bits); |
| 954 | for (n = 0; n < insn->n; n++) | 955 | for (n = 0; n < insn->n; n++) |
| 955 | data[n] = ((1 << insn->chanspec) & bits) != 0; | 956 | data[n] = ((1 << channel) & bits) != 0; |
| 956 | return n; | 957 | return n; |
| 957 | } | 958 | } |
| 958 | 959 | ||
| @@ -961,12 +962,13 @@ static int dt9812_do_winsn(struct comedi_device *dev, | |||
| 961 | unsigned int *data) | 962 | unsigned int *data) |
| 962 | { | 963 | { |
| 963 | struct comedi_dt9812 *devpriv = dev->private; | 964 | struct comedi_dt9812 *devpriv = dev->private; |
| 965 | unsigned int channel = CR_CHAN(insn->chanspec); | ||
| 964 | int n; | 966 | int n; |
| 965 | u8 bits = 0; | 967 | u8 bits = 0; |
| 966 | 968 | ||
| 967 | dt9812_digital_out_shadow(devpriv->slot, &bits); | 969 | dt9812_digital_out_shadow(devpriv->slot, &bits); |
| 968 | for (n = 0; n < insn->n; n++) { | 970 | for (n = 0; n < insn->n; n++) { |
| 969 | u8 mask = 1 << insn->chanspec; | 971 | u8 mask = 1 << channel; |
| 970 | 972 | ||
| 971 | bits &= ~mask; | 973 | bits &= ~mask; |
| 972 | if (data[n]) | 974 | if (data[n]) |
| @@ -981,13 +983,13 @@ static int dt9812_ai_rinsn(struct comedi_device *dev, | |||
| 981 | unsigned int *data) | 983 | unsigned int *data) |
| 982 | { | 984 | { |
| 983 | struct comedi_dt9812 *devpriv = dev->private; | 985 | struct comedi_dt9812 *devpriv = dev->private; |
| 986 | unsigned int channel = CR_CHAN(insn->chanspec); | ||
| 984 | int n; | 987 | int n; |
| 985 | 988 | ||
| 986 | for (n = 0; n < insn->n; n++) { | 989 | for (n = 0; n < insn->n; n++) { |
| 987 | u16 value = 0; | 990 | u16 value = 0; |
| 988 | 991 | ||
| 989 | dt9812_analog_in(devpriv->slot, insn->chanspec, &value, | 992 | dt9812_analog_in(devpriv->slot, channel, &value, DT9812_GAIN_1); |
| 990 | DT9812_GAIN_1); | ||
| 991 | data[n] = value; | 993 | data[n] = value; |
| 992 | } | 994 | } |
| 993 | return n; | 995 | return n; |
| @@ -998,12 +1000,13 @@ static int dt9812_ao_rinsn(struct comedi_device *dev, | |||
| 998 | unsigned int *data) | 1000 | unsigned int *data) |
| 999 | { | 1001 | { |
| 1000 | struct comedi_dt9812 *devpriv = dev->private; | 1002 | struct comedi_dt9812 *devpriv = dev->private; |
| 1003 | unsigned int channel = CR_CHAN(insn->chanspec); | ||
| 1001 | int n; | 1004 | int n; |
| 1002 | u16 value; | 1005 | u16 value; |
| 1003 | 1006 | ||
| 1004 | for (n = 0; n < insn->n; n++) { | 1007 | for (n = 0; n < insn->n; n++) { |
| 1005 | value = 0; | 1008 | value = 0; |
| 1006 | dt9812_analog_out_shadow(devpriv->slot, insn->chanspec, &value); | 1009 | dt9812_analog_out_shadow(devpriv->slot, channel, &value); |
| 1007 | data[n] = value; | 1010 | data[n] = value; |
| 1008 | } | 1011 | } |
| 1009 | return n; | 1012 | return n; |
| @@ -1014,10 +1017,11 @@ static int dt9812_ao_winsn(struct comedi_device *dev, | |||
| 1014 | unsigned int *data) | 1017 | unsigned int *data) |
| 1015 | { | 1018 | { |
| 1016 | struct comedi_dt9812 *devpriv = dev->private; | 1019 | struct comedi_dt9812 *devpriv = dev->private; |
| 1020 | unsigned int channel = CR_CHAN(insn->chanspec); | ||
| 1017 | int n; | 1021 | int n; |
| 1018 | 1022 | ||
| 1019 | for (n = 0; n < insn->n; n++) | 1023 | for (n = 0; n < insn->n; n++) |
| 1020 | dt9812_analog_out(devpriv->slot, insn->chanspec, data[n]); | 1024 | dt9812_analog_out(devpriv->slot, channel, data[n]); |
| 1021 | return n; | 1025 | return n; |
| 1022 | } | 1026 | } |
| 1023 | 1027 | ||
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c index 1a0062a04456..6aac1f60bc42 100644 --- a/drivers/staging/comedi/drivers/usbdux.c +++ b/drivers/staging/comedi/drivers/usbdux.c | |||
| @@ -730,10 +730,14 @@ static void usbduxsub_ao_IsocIrq(struct urb *urb) | |||
| 730 | static int usbduxsub_start(struct usbduxsub *usbduxsub) | 730 | static int usbduxsub_start(struct usbduxsub *usbduxsub) |
| 731 | { | 731 | { |
| 732 | int errcode = 0; | 732 | int errcode = 0; |
| 733 | uint8_t local_transfer_buffer[16]; | 733 | uint8_t *local_transfer_buffer; |
| 734 | |||
| 735 | local_transfer_buffer = kmalloc(1, GFP_KERNEL); | ||
| 736 | if (!local_transfer_buffer) | ||
| 737 | return -ENOMEM; | ||
| 734 | 738 | ||
| 735 | /* 7f92 to zero */ | 739 | /* 7f92 to zero */ |
| 736 | local_transfer_buffer[0] = 0; | 740 | *local_transfer_buffer = 0; |
| 737 | errcode = usb_control_msg(usbduxsub->usbdev, | 741 | errcode = usb_control_msg(usbduxsub->usbdev, |
| 738 | /* create a pipe for a control transfer */ | 742 | /* create a pipe for a control transfer */ |
| 739 | usb_sndctrlpipe(usbduxsub->usbdev, 0), | 743 | usb_sndctrlpipe(usbduxsub->usbdev, 0), |
| @@ -751,22 +755,25 @@ static int usbduxsub_start(struct usbduxsub *usbduxsub) | |||
| 751 | 1, | 755 | 1, |
| 752 | /* Timeout */ | 756 | /* Timeout */ |
| 753 | BULK_TIMEOUT); | 757 | BULK_TIMEOUT); |
| 754 | if (errcode < 0) { | 758 | if (errcode < 0) |
| 755 | dev_err(&usbduxsub->interface->dev, | 759 | dev_err(&usbduxsub->interface->dev, |
| 756 | "comedi_: control msg failed (start)\n"); | 760 | "comedi_: control msg failed (start)\n"); |
| 757 | return errcode; | 761 | |
| 758 | } | 762 | kfree(local_transfer_buffer); |
| 759 | return 0; | 763 | return errcode; |
| 760 | } | 764 | } |
| 761 | 765 | ||
| 762 | static int usbduxsub_stop(struct usbduxsub *usbduxsub) | 766 | static int usbduxsub_stop(struct usbduxsub *usbduxsub) |
| 763 | { | 767 | { |
| 764 | int errcode = 0; | 768 | int errcode = 0; |
| 769 | uint8_t *local_transfer_buffer; | ||
| 765 | 770 | ||
| 766 | uint8_t local_transfer_buffer[16]; | 771 | local_transfer_buffer = kmalloc(1, GFP_KERNEL); |
| 772 | if (!local_transfer_buffer) | ||
| 773 | return -ENOMEM; | ||
| 767 | 774 | ||
| 768 | /* 7f92 to one */ | 775 | /* 7f92 to one */ |
| 769 | local_transfer_buffer[0] = 1; | 776 | *local_transfer_buffer = 1; |
| 770 | errcode = usb_control_msg(usbduxsub->usbdev, | 777 | errcode = usb_control_msg(usbduxsub->usbdev, |
| 771 | usb_sndctrlpipe(usbduxsub->usbdev, 0), | 778 | usb_sndctrlpipe(usbduxsub->usbdev, 0), |
| 772 | /* bRequest, "Firmware" */ | 779 | /* bRequest, "Firmware" */ |
| @@ -781,12 +788,12 @@ static int usbduxsub_stop(struct usbduxsub *usbduxsub) | |||
| 781 | 1, | 788 | 1, |
| 782 | /* Timeout */ | 789 | /* Timeout */ |
| 783 | BULK_TIMEOUT); | 790 | BULK_TIMEOUT); |
| 784 | if (errcode < 0) { | 791 | if (errcode < 0) |
| 785 | dev_err(&usbduxsub->interface->dev, | 792 | dev_err(&usbduxsub->interface->dev, |
| 786 | "comedi_: control msg failed (stop)\n"); | 793 | "comedi_: control msg failed (stop)\n"); |
| 787 | return errcode; | 794 | |
| 788 | } | 795 | kfree(local_transfer_buffer); |
| 789 | return 0; | 796 | return errcode; |
| 790 | } | 797 | } |
| 791 | 798 | ||
| 792 | static int usbduxsub_upload(struct usbduxsub *usbduxsub, | 799 | static int usbduxsub_upload(struct usbduxsub *usbduxsub, |
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c index 4bf5dd094dc9..1ba0e3df492d 100644 --- a/drivers/staging/comedi/drivers/usbduxfast.c +++ b/drivers/staging/comedi/drivers/usbduxfast.c | |||
| @@ -436,10 +436,14 @@ static void usbduxfastsub_ai_Irq(struct urb *urb) | |||
| 436 | static int usbduxfastsub_start(struct usbduxfastsub_s *udfs) | 436 | static int usbduxfastsub_start(struct usbduxfastsub_s *udfs) |
| 437 | { | 437 | { |
| 438 | int ret; | 438 | int ret; |
| 439 | unsigned char local_transfer_buffer[16]; | 439 | unsigned char *local_transfer_buffer; |
| 440 | |||
| 441 | local_transfer_buffer = kmalloc(1, GFP_KERNEL); | ||
| 442 | if (!local_transfer_buffer) | ||
| 443 | return -ENOMEM; | ||
| 440 | 444 | ||
| 441 | /* 7f92 to zero */ | 445 | /* 7f92 to zero */ |
| 442 | local_transfer_buffer[0] = 0; | 446 | *local_transfer_buffer = 0; |
| 443 | /* bRequest, "Firmware" */ | 447 | /* bRequest, "Firmware" */ |
| 444 | ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), | 448 | ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), |
| 445 | USBDUXFASTSUB_FIRMWARE, | 449 | USBDUXFASTSUB_FIRMWARE, |
| @@ -450,22 +454,25 @@ static int usbduxfastsub_start(struct usbduxfastsub_s *udfs) | |||
| 450 | local_transfer_buffer, | 454 | local_transfer_buffer, |
| 451 | 1, /* Length */ | 455 | 1, /* Length */ |
| 452 | EZTIMEOUT); /* Timeout */ | 456 | EZTIMEOUT); /* Timeout */ |
| 453 | if (ret < 0) { | 457 | if (ret < 0) |
| 454 | dev_err(&udfs->interface->dev, | 458 | dev_err(&udfs->interface->dev, |
| 455 | "control msg failed (start)\n"); | 459 | "control msg failed (start)\n"); |
| 456 | return ret; | ||
| 457 | } | ||
| 458 | 460 | ||
| 459 | return 0; | 461 | kfree(local_transfer_buffer); |
| 462 | return ret; | ||
| 460 | } | 463 | } |
| 461 | 464 | ||
| 462 | static int usbduxfastsub_stop(struct usbduxfastsub_s *udfs) | 465 | static int usbduxfastsub_stop(struct usbduxfastsub_s *udfs) |
| 463 | { | 466 | { |
| 464 | int ret; | 467 | int ret; |
| 465 | unsigned char local_transfer_buffer[16]; | 468 | unsigned char *local_transfer_buffer; |
| 469 | |||
| 470 | local_transfer_buffer = kmalloc(1, GFP_KERNEL); | ||
| 471 | if (!local_transfer_buffer) | ||
| 472 | return -ENOMEM; | ||
| 466 | 473 | ||
| 467 | /* 7f92 to one */ | 474 | /* 7f92 to one */ |
| 468 | local_transfer_buffer[0] = 1; | 475 | *local_transfer_buffer = 1; |
| 469 | /* bRequest, "Firmware" */ | 476 | /* bRequest, "Firmware" */ |
| 470 | ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), | 477 | ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), |
| 471 | USBDUXFASTSUB_FIRMWARE, | 478 | USBDUXFASTSUB_FIRMWARE, |
| @@ -474,13 +481,12 @@ static int usbduxfastsub_stop(struct usbduxfastsub_s *udfs) | |||
| 474 | 0x0000, /* Index */ | 481 | 0x0000, /* Index */ |
| 475 | local_transfer_buffer, 1, /* Length */ | 482 | local_transfer_buffer, 1, /* Length */ |
| 476 | EZTIMEOUT); /* Timeout */ | 483 | EZTIMEOUT); /* Timeout */ |
| 477 | if (ret < 0) { | 484 | if (ret < 0) |
| 478 | dev_err(&udfs->interface->dev, | 485 | dev_err(&udfs->interface->dev, |
| 479 | "control msg failed (stop)\n"); | 486 | "control msg failed (stop)\n"); |
| 480 | return ret; | ||
| 481 | } | ||
| 482 | 487 | ||
| 483 | return 0; | 488 | kfree(local_transfer_buffer); |
| 489 | return ret; | ||
| 484 | } | 490 | } |
| 485 | 491 | ||
| 486 | static int usbduxfastsub_upload(struct usbduxfastsub_s *udfs, | 492 | static int usbduxfastsub_upload(struct usbduxfastsub_s *udfs, |
diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index d066351a71b2..a728c8fc32a2 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c | |||
| @@ -681,7 +681,11 @@ static void usbduxsub_ao_IsocIrq(struct urb *urb) | |||
| 681 | static int usbduxsub_start(struct usbduxsub *usbduxsub) | 681 | static int usbduxsub_start(struct usbduxsub *usbduxsub) |
| 682 | { | 682 | { |
| 683 | int errcode = 0; | 683 | int errcode = 0; |
| 684 | uint8_t local_transfer_buffer[16]; | 684 | uint8_t *local_transfer_buffer; |
| 685 | |||
| 686 | local_transfer_buffer = kmalloc(16, GFP_KERNEL); | ||
| 687 | if (!local_transfer_buffer) | ||
| 688 | return -ENOMEM; | ||
| 685 | 689 | ||
| 686 | /* 7f92 to zero */ | 690 | /* 7f92 to zero */ |
| 687 | local_transfer_buffer[0] = 0; | 691 | local_transfer_buffer[0] = 0; |
| @@ -702,19 +706,22 @@ static int usbduxsub_start(struct usbduxsub *usbduxsub) | |||
| 702 | 1, | 706 | 1, |
| 703 | /* Timeout */ | 707 | /* Timeout */ |
| 704 | BULK_TIMEOUT); | 708 | BULK_TIMEOUT); |
| 705 | if (errcode < 0) { | 709 | if (errcode < 0) |
| 706 | dev_err(&usbduxsub->interface->dev, | 710 | dev_err(&usbduxsub->interface->dev, |
| 707 | "comedi_: control msg failed (start)\n"); | 711 | "comedi_: control msg failed (start)\n"); |
| 708 | return errcode; | 712 | |
| 709 | } | 713 | kfree(local_transfer_buffer); |
| 710 | return 0; | 714 | return errcode; |
| 711 | } | 715 | } |
| 712 | 716 | ||
| 713 | static int usbduxsub_stop(struct usbduxsub *usbduxsub) | 717 | static int usbduxsub_stop(struct usbduxsub *usbduxsub) |
| 714 | { | 718 | { |
| 715 | int errcode = 0; | 719 | int errcode = 0; |
| 720 | uint8_t *local_transfer_buffer; | ||
| 716 | 721 | ||
| 717 | uint8_t local_transfer_buffer[16]; | 722 | local_transfer_buffer = kmalloc(16, GFP_KERNEL); |
| 723 | if (!local_transfer_buffer) | ||
| 724 | return -ENOMEM; | ||
| 718 | 725 | ||
| 719 | /* 7f92 to one */ | 726 | /* 7f92 to one */ |
| 720 | local_transfer_buffer[0] = 1; | 727 | local_transfer_buffer[0] = 1; |
| @@ -732,12 +739,12 @@ static int usbduxsub_stop(struct usbduxsub *usbduxsub) | |||
| 732 | 1, | 739 | 1, |
| 733 | /* Timeout */ | 740 | /* Timeout */ |
| 734 | BULK_TIMEOUT); | 741 | BULK_TIMEOUT); |
| 735 | if (errcode < 0) { | 742 | if (errcode < 0) |
| 736 | dev_err(&usbduxsub->interface->dev, | 743 | dev_err(&usbduxsub->interface->dev, |
| 737 | "comedi_: control msg failed (stop)\n"); | 744 | "comedi_: control msg failed (stop)\n"); |
| 738 | return errcode; | 745 | |
| 739 | } | 746 | kfree(local_transfer_buffer); |
| 740 | return 0; | 747 | return errcode; |
| 741 | } | 748 | } |
| 742 | 749 | ||
| 743 | static int usbduxsub_upload(struct usbduxsub *usbduxsub, | 750 | static int usbduxsub_upload(struct usbduxsub *usbduxsub, |
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index 4b3a019409b5..b028b0d1317b 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c +++ b/drivers/staging/imx-drm/ipuv3-crtc.c | |||
| @@ -483,17 +483,6 @@ static int ipu_get_resources(struct ipu_crtc *ipu_crtc, | |||
| 483 | goto err_out; | 483 | goto err_out; |
| 484 | } | 484 | } |
| 485 | 485 | ||
| 486 | ipu_crtc->irq = ipu_idmac_channel_irq(ipu, ipu_crtc->ipu_ch, | ||
| 487 | IPU_IRQ_EOF); | ||
| 488 | ret = devm_request_irq(ipu_crtc->dev, ipu_crtc->irq, ipu_irq_handler, 0, | ||
| 489 | "imx_drm", ipu_crtc); | ||
| 490 | if (ret < 0) { | ||
| 491 | dev_err(ipu_crtc->dev, "irq request failed with %d.\n", ret); | ||
| 492 | goto err_out; | ||
| 493 | } | ||
| 494 | |||
| 495 | disable_irq(ipu_crtc->irq); | ||
| 496 | |||
| 497 | return 0; | 486 | return 0; |
| 498 | err_out: | 487 | err_out: |
| 499 | ipu_put_resources(ipu_crtc); | 488 | ipu_put_resources(ipu_crtc); |
| @@ -504,6 +493,7 @@ err_out: | |||
| 504 | static int ipu_crtc_init(struct ipu_crtc *ipu_crtc, | 493 | static int ipu_crtc_init(struct ipu_crtc *ipu_crtc, |
| 505 | struct ipu_client_platformdata *pdata) | 494 | struct ipu_client_platformdata *pdata) |
| 506 | { | 495 | { |
| 496 | struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent); | ||
| 507 | int ret; | 497 | int ret; |
| 508 | 498 | ||
| 509 | ret = ipu_get_resources(ipu_crtc, pdata); | 499 | ret = ipu_get_resources(ipu_crtc, pdata); |
| @@ -522,6 +512,17 @@ static int ipu_crtc_init(struct ipu_crtc *ipu_crtc, | |||
| 522 | goto err_put_resources; | 512 | goto err_put_resources; |
| 523 | } | 513 | } |
| 524 | 514 | ||
| 515 | ipu_crtc->irq = ipu_idmac_channel_irq(ipu, ipu_crtc->ipu_ch, | ||
| 516 | IPU_IRQ_EOF); | ||
| 517 | ret = devm_request_irq(ipu_crtc->dev, ipu_crtc->irq, ipu_irq_handler, 0, | ||
| 518 | "imx_drm", ipu_crtc); | ||
| 519 | if (ret < 0) { | ||
| 520 | dev_err(ipu_crtc->dev, "irq request failed with %d.\n", ret); | ||
| 521 | goto err_put_resources; | ||
| 522 | } | ||
| 523 | |||
| 524 | disable_irq(ipu_crtc->irq); | ||
| 525 | |||
| 525 | return 0; | 526 | return 0; |
| 526 | 527 | ||
| 527 | err_put_resources: | 528 | err_put_resources: |
diff --git a/drivers/staging/tidspbridge/rmgr/drv.c b/drivers/staging/tidspbridge/rmgr/drv.c index db1da28cecba..be26917a6896 100644 --- a/drivers/staging/tidspbridge/rmgr/drv.c +++ b/drivers/staging/tidspbridge/rmgr/drv.c | |||
| @@ -76,37 +76,28 @@ int drv_insert_node_res_element(void *hnode, void *node_resource, | |||
| 76 | struct node_res_object **node_res_obj = | 76 | struct node_res_object **node_res_obj = |
| 77 | (struct node_res_object **)node_resource; | 77 | (struct node_res_object **)node_resource; |
| 78 | struct process_context *ctxt = (struct process_context *)process_ctxt; | 78 | struct process_context *ctxt = (struct process_context *)process_ctxt; |
| 79 | int status = 0; | ||
| 80 | int retval; | 79 | int retval; |
| 81 | 80 | ||
| 82 | *node_res_obj = kzalloc(sizeof(struct node_res_object), GFP_KERNEL); | 81 | *node_res_obj = kzalloc(sizeof(struct node_res_object), GFP_KERNEL); |
| 83 | if (!*node_res_obj) { | 82 | if (!*node_res_obj) |
| 84 | status = -ENOMEM; | 83 | return -ENOMEM; |
| 85 | goto func_end; | ||
| 86 | } | ||
| 87 | 84 | ||
| 88 | (*node_res_obj)->node = hnode; | 85 | (*node_res_obj)->node = hnode; |
| 89 | retval = idr_get_new(ctxt->node_id, *node_res_obj, | 86 | retval = idr_alloc(ctxt->node_id, *node_res_obj, 0, 0, GFP_KERNEL); |
| 90 | &(*node_res_obj)->id); | 87 | if (retval >= 0) { |
| 91 | if (retval == -EAGAIN) { | 88 | (*node_res_obj)->id = retval; |
| 92 | if (!idr_pre_get(ctxt->node_id, GFP_KERNEL)) { | 89 | return 0; |
| 93 | pr_err("%s: OUT OF MEMORY\n", __func__); | ||
| 94 | status = -ENOMEM; | ||
| 95 | goto func_end; | ||
| 96 | } | ||
| 97 | |||
| 98 | retval = idr_get_new(ctxt->node_id, *node_res_obj, | ||
| 99 | &(*node_res_obj)->id); | ||
| 100 | } | 90 | } |
| 101 | if (retval) { | 91 | |
| 92 | kfree(*node_res_obj); | ||
| 93 | |||
| 94 | if (retval == -ENOSPC) { | ||
| 102 | pr_err("%s: FAILED, IDR is FULL\n", __func__); | 95 | pr_err("%s: FAILED, IDR is FULL\n", __func__); |
| 103 | status = -EFAULT; | 96 | return -EFAULT; |
| 97 | } else { | ||
| 98 | pr_err("%s: OUT OF MEMORY\n", __func__); | ||
| 99 | return -ENOMEM; | ||
| 104 | } | 100 | } |
| 105 | func_end: | ||
| 106 | if (status) | ||
| 107 | kfree(*node_res_obj); | ||
| 108 | |||
| 109 | return status; | ||
| 110 | } | 101 | } |
| 111 | 102 | ||
| 112 | /* Release all Node resources and its context | 103 | /* Release all Node resources and its context |
| @@ -201,35 +192,26 @@ int drv_proc_insert_strm_res_element(void *stream_obj, | |||
| 201 | struct strm_res_object **pstrm_res = | 192 | struct strm_res_object **pstrm_res = |
| 202 | (struct strm_res_object **)strm_res; | 193 | (struct strm_res_object **)strm_res; |
| 203 | struct process_context *ctxt = (struct process_context *)process_ctxt; | 194 | struct process_context *ctxt = (struct process_context *)process_ctxt; |
| 204 | int status = 0; | ||
| 205 | int retval; | 195 | int retval; |
| 206 | 196 | ||
| 207 | *pstrm_res = kzalloc(sizeof(struct strm_res_object), GFP_KERNEL); | 197 | *pstrm_res = kzalloc(sizeof(struct strm_res_object), GFP_KERNEL); |
| 208 | if (*pstrm_res == NULL) { | 198 | if (*pstrm_res == NULL) |
| 209 | status = -EFAULT; | 199 | return -EFAULT; |
| 210 | goto func_end; | ||
| 211 | } | ||
| 212 | 200 | ||
| 213 | (*pstrm_res)->stream = stream_obj; | 201 | (*pstrm_res)->stream = stream_obj; |
| 214 | retval = idr_get_new(ctxt->stream_id, *pstrm_res, | 202 | retval = idr_alloc(ctxt->stream_id, *pstrm_res, 0, 0, GFP_KERNEL); |
| 215 | &(*pstrm_res)->id); | 203 | if (retval >= 0) { |
| 216 | if (retval == -EAGAIN) { | 204 | (*pstrm_res)->id = retval; |
| 217 | if (!idr_pre_get(ctxt->stream_id, GFP_KERNEL)) { | 205 | return 0; |
| 218 | pr_err("%s: OUT OF MEMORY\n", __func__); | ||
| 219 | status = -ENOMEM; | ||
| 220 | goto func_end; | ||
| 221 | } | ||
| 222 | |||
| 223 | retval = idr_get_new(ctxt->stream_id, *pstrm_res, | ||
| 224 | &(*pstrm_res)->id); | ||
| 225 | } | 206 | } |
| 226 | if (retval) { | 207 | |
| 208 | if (retval == -ENOSPC) { | ||
| 227 | pr_err("%s: FAILED, IDR is FULL\n", __func__); | 209 | pr_err("%s: FAILED, IDR is FULL\n", __func__); |
| 228 | status = -EPERM; | 210 | return -EPERM; |
| 211 | } else { | ||
| 212 | pr_err("%s: OUT OF MEMORY\n", __func__); | ||
| 213 | return -ENOMEM; | ||
| 229 | } | 214 | } |
| 230 | |||
| 231 | func_end: | ||
| 232 | return status; | ||
| 233 | } | 215 | } |
| 234 | 216 | ||
| 235 | static int drv_proc_free_strm_res(int id, void *p, void *process_ctxt) | 217 | static int drv_proc_free_strm_res(int id, void *p, void *process_ctxt) |
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 22918a106d73..d2479b766450 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c | |||
| @@ -790,7 +790,7 @@ u64 CARDqGetNextTBTT(u64 qwTSF, WORD wBeaconInterval) | |||
| 790 | if ((~uLowNextTBTT) < uLowRemain) | 790 | if ((~uLowNextTBTT) < uLowRemain) |
| 791 | qwTSF = ((qwTSF >> 32) + 1) << 32; | 791 | qwTSF = ((qwTSF >> 32) + 1) << 32; |
| 792 | 792 | ||
| 793 | qwTSF = (qwTSF & 0xffffffff00000000UL) | | 793 | qwTSF = (qwTSF & 0xffffffff00000000ULL) | |
| 794 | (u64)(uLowNextTBTT + uLowRemain); | 794 | (u64)(uLowNextTBTT + uLowRemain); |
| 795 | 795 | ||
| 796 | return (qwTSF); | 796 | return (qwTSF); |
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index d5f53e1a74a2..a5063a6f64d9 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c | |||
| @@ -669,8 +669,6 @@ static int vt6656_suspend(struct usb_interface *intf, pm_message_t message) | |||
| 669 | if (device->flags & DEVICE_FLAGS_OPENED) | 669 | if (device->flags & DEVICE_FLAGS_OPENED) |
| 670 | device_close(device->dev); | 670 | device_close(device->dev); |
| 671 | 671 | ||
| 672 | usb_put_dev(interface_to_usbdev(intf)); | ||
| 673 | |||
| 674 | return 0; | 672 | return 0; |
| 675 | } | 673 | } |
| 676 | 674 | ||
| @@ -681,8 +679,6 @@ static int vt6656_resume(struct usb_interface *intf) | |||
| 681 | if (!device || !device->dev) | 679 | if (!device || !device->dev) |
| 682 | return -ENODEV; | 680 | return -ENODEV; |
| 683 | 681 | ||
| 684 | usb_get_dev(interface_to_usbdev(intf)); | ||
| 685 | |||
| 686 | if (!(device->flags & DEVICE_FLAGS_OPENED)) | 682 | if (!(device->flags & DEVICE_FLAGS_OPENED)) |
| 687 | device_open(device->dev); | 683 | device_open(device->dev); |
| 688 | 684 | ||
diff --git a/drivers/staging/zcache/ramster/tcp.c b/drivers/staging/zcache/ramster/tcp.c index aa2a1a763aa4..f6e1e5209d88 100644 --- a/drivers/staging/zcache/ramster/tcp.c +++ b/drivers/staging/zcache/ramster/tcp.c | |||
| @@ -300,27 +300,22 @@ static u8 r2net_num_from_nn(struct r2net_node *nn) | |||
| 300 | 300 | ||
| 301 | static int r2net_prep_nsw(struct r2net_node *nn, struct r2net_status_wait *nsw) | 301 | static int r2net_prep_nsw(struct r2net_node *nn, struct r2net_status_wait *nsw) |
| 302 | { | 302 | { |
| 303 | int ret = 0; | 303 | int ret; |
| 304 | 304 | ||
| 305 | do { | 305 | spin_lock(&nn->nn_lock); |
| 306 | if (!idr_pre_get(&nn->nn_status_idr, GFP_ATOMIC)) { | 306 | ret = idr_alloc(&nn->nn_status_idr, nsw, 0, 0, GFP_ATOMIC); |
| 307 | ret = -EAGAIN; | 307 | if (ret >= 0) { |
| 308 | break; | 308 | nsw->ns_id = ret; |
| 309 | } | 309 | list_add_tail(&nsw->ns_node_item, &nn->nn_status_list); |
| 310 | spin_lock(&nn->nn_lock); | 310 | } |
| 311 | ret = idr_get_new(&nn->nn_status_idr, nsw, &nsw->ns_id); | 311 | spin_unlock(&nn->nn_lock); |
| 312 | if (ret == 0) | ||
| 313 | list_add_tail(&nsw->ns_node_item, | ||
| 314 | &nn->nn_status_list); | ||
| 315 | spin_unlock(&nn->nn_lock); | ||
| 316 | } while (ret == -EAGAIN); | ||
| 317 | 312 | ||
| 318 | if (ret == 0) { | 313 | if (ret >= 0) { |
| 319 | init_waitqueue_head(&nsw->ns_wq); | 314 | init_waitqueue_head(&nsw->ns_wq); |
| 320 | nsw->ns_sys_status = R2NET_ERR_NONE; | 315 | nsw->ns_sys_status = R2NET_ERR_NONE; |
| 321 | nsw->ns_status = 0; | 316 | nsw->ns_status = 0; |
| 317 | return 0; | ||
| 322 | } | 318 | } |
| 323 | |||
| 324 | return ret; | 319 | return ret; |
| 325 | } | 320 | } |
| 326 | 321 | ||
diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c index 0efc815a4968..cf6a5383748a 100644 --- a/drivers/tty/serial/8250/8250.c +++ b/drivers/tty/serial/8250/8250.c | |||
| @@ -301,7 +301,28 @@ static const struct serial8250_config uart_config[] = { | |||
| 301 | }, | 301 | }, |
| 302 | [PORT_8250_CIR] = { | 302 | [PORT_8250_CIR] = { |
| 303 | .name = "CIR port" | 303 | .name = "CIR port" |
| 304 | } | 304 | }, |
| 305 | [PORT_ALTR_16550_F32] = { | ||
| 306 | .name = "Altera 16550 FIFO32", | ||
| 307 | .fifo_size = 32, | ||
| 308 | .tx_loadsz = 32, | ||
| 309 | .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, | ||
| 310 | .flags = UART_CAP_FIFO | UART_CAP_AFE, | ||
| 311 | }, | ||
| 312 | [PORT_ALTR_16550_F64] = { | ||
| 313 | .name = "Altera 16550 FIFO64", | ||
| 314 | .fifo_size = 64, | ||
| 315 | .tx_loadsz = 64, | ||
| 316 | .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, | ||
| 317 | .flags = UART_CAP_FIFO | UART_CAP_AFE, | ||
| 318 | }, | ||
| 319 | [PORT_ALTR_16550_F128] = { | ||
| 320 | .name = "Altera 16550 FIFO128", | ||
| 321 | .fifo_size = 128, | ||
| 322 | .tx_loadsz = 128, | ||
| 323 | .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, | ||
| 324 | .flags = UART_CAP_FIFO | UART_CAP_AFE, | ||
| 325 | }, | ||
| 305 | }; | 326 | }; |
| 306 | 327 | ||
| 307 | /* Uart divisor latch read */ | 328 | /* Uart divisor latch read */ |
| @@ -3396,3 +3417,32 @@ module_param_array(probe_rsa, ulong, &probe_rsa_count, 0444); | |||
| 3396 | MODULE_PARM_DESC(probe_rsa, "Probe I/O ports for RSA"); | 3417 | MODULE_PARM_DESC(probe_rsa, "Probe I/O ports for RSA"); |
| 3397 | #endif | 3418 | #endif |
| 3398 | MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR); | 3419 | MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR); |
| 3420 | |||
| 3421 | #ifndef MODULE | ||
| 3422 | /* This module was renamed to 8250_core in 3.7. Keep the old "8250" name | ||
| 3423 | * working as well for the module options so we don't break people. We | ||
| 3424 | * need to keep the names identical and the convenient macros will happily | ||
| 3425 | * refuse to let us do that by failing the build with redefinition errors | ||
| 3426 | * of global variables. So we stick them inside a dummy function to avoid | ||
| 3427 | * those conflicts. The options still get parsed, and the redefined | ||
| 3428 | * MODULE_PARAM_PREFIX lets us keep the "8250." syntax alive. | ||
| 3429 | * | ||
| 3430 | * This is hacky. I'm sorry. | ||
| 3431 | */ | ||
| 3432 | static void __used s8250_options(void) | ||
| 3433 | { | ||
| 3434 | #undef MODULE_PARAM_PREFIX | ||
| 3435 | #define MODULE_PARAM_PREFIX "8250." | ||
| 3436 | |||
| 3437 | module_param_cb(share_irqs, ¶m_ops_uint, &share_irqs, 0644); | ||
| 3438 | module_param_cb(nr_uarts, ¶m_ops_uint, &nr_uarts, 0644); | ||
| 3439 | module_param_cb(skip_txen_test, ¶m_ops_uint, &skip_txen_test, 0644); | ||
| 3440 | #ifdef CONFIG_SERIAL_8250_RSA | ||
| 3441 | __module_param_call(MODULE_PARAM_PREFIX, probe_rsa, | ||
| 3442 | ¶m_array_ops, .arr = &__param_arr_probe_rsa, | ||
| 3443 | 0444, -1); | ||
| 3444 | #endif | ||
| 3445 | } | ||
| 3446 | #else | ||
| 3447 | MODULE_ALIAS("8250"); | ||
| 3448 | #endif | ||
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 791c5a77ec61..aa76825229dc 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c | |||
| @@ -1571,6 +1571,7 @@ pci_wch_ch353_setup(struct serial_private *priv, | |||
| 1571 | 1571 | ||
| 1572 | /* Unknown vendors/cards - this should not be in linux/pci_ids.h */ | 1572 | /* Unknown vendors/cards - this should not be in linux/pci_ids.h */ |
| 1573 | #define PCI_SUBDEVICE_ID_UNKNOWN_0x1584 0x1584 | 1573 | #define PCI_SUBDEVICE_ID_UNKNOWN_0x1584 0x1584 |
| 1574 | #define PCI_SUBDEVICE_ID_UNKNOWN_0x1588 0x1588 | ||
| 1574 | 1575 | ||
| 1575 | /* | 1576 | /* |
| 1576 | * Master list of serial port init/setup/exit quirks. | 1577 | * Master list of serial port init/setup/exit quirks. |
| @@ -1852,15 +1853,6 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = { | |||
| 1852 | }, | 1853 | }, |
| 1853 | { | 1854 | { |
| 1854 | .vendor = PCI_VENDOR_ID_PLX, | 1855 | .vendor = PCI_VENDOR_ID_PLX, |
| 1855 | .device = PCI_DEVICE_ID_PLX_9050, | ||
| 1856 | .subvendor = PCI_VENDOR_ID_PLX, | ||
| 1857 | .subdevice = PCI_SUBDEVICE_ID_UNKNOWN_0x1584, | ||
| 1858 | .init = pci_plx9050_init, | ||
| 1859 | .setup = pci_default_setup, | ||
| 1860 | .exit = pci_plx9050_exit, | ||
| 1861 | }, | ||
| 1862 | { | ||
| 1863 | .vendor = PCI_VENDOR_ID_PLX, | ||
| 1864 | .device = PCI_DEVICE_ID_PLX_ROMULUS, | 1856 | .device = PCI_DEVICE_ID_PLX_ROMULUS, |
| 1865 | .subvendor = PCI_VENDOR_ID_PLX, | 1857 | .subvendor = PCI_VENDOR_ID_PLX, |
| 1866 | .subdevice = PCI_DEVICE_ID_PLX_ROMULUS, | 1858 | .subdevice = PCI_DEVICE_ID_PLX_ROMULUS, |
| @@ -3733,7 +3725,12 @@ static struct pci_device_id serial_pci_tbl[] = { | |||
| 3733 | { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, | 3725 | { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, |
| 3734 | PCI_VENDOR_ID_PLX, | 3726 | PCI_VENDOR_ID_PLX, |
| 3735 | PCI_SUBDEVICE_ID_UNKNOWN_0x1584, 0, 0, | 3727 | PCI_SUBDEVICE_ID_UNKNOWN_0x1584, 0, 0, |
| 3736 | pbn_b0_4_115200 }, | 3728 | pbn_b2_4_115200 }, |
| 3729 | /* Unknown card - subdevice 0x1588 */ | ||
| 3730 | { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, | ||
| 3731 | PCI_VENDOR_ID_PLX, | ||
| 3732 | PCI_SUBDEVICE_ID_UNKNOWN_0x1588, 0, 0, | ||
| 3733 | pbn_b2_8_115200 }, | ||
| 3737 | { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, | 3734 | { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, |
| 3738 | PCI_SUBVENDOR_ID_KEYSPAN, | 3735 | PCI_SUBVENDOR_ID_KEYSPAN, |
| 3739 | PCI_SUBDEVICE_ID_KEYSPAN_SX2, 0, 0, | 3736 | PCI_SUBDEVICE_ID_KEYSPAN_SX2, 0, 0, |
| @@ -4791,6 +4788,10 @@ static struct pci_device_id serial_pci_tbl[] = { | |||
| 4791 | PCI_VENDOR_ID_IBM, 0x0299, | 4788 | PCI_VENDOR_ID_IBM, 0x0299, |
| 4792 | 0, 0, pbn_b0_bt_2_115200 }, | 4789 | 0, 0, pbn_b0_bt_2_115200 }, |
| 4793 | 4790 | ||
| 4791 | { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9835, | ||
| 4792 | 0x1000, 0x0012, | ||
| 4793 | 0, 0, pbn_b0_bt_2_115200 }, | ||
| 4794 | |||
| 4794 | { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9901, | 4795 | { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9901, |
| 4795 | 0xA000, 0x1000, | 4796 | 0xA000, 0x1000, |
| 4796 | 0, 0, pbn_b0_1_115200 }, | 4797 | 0, 0, pbn_b0_1_115200 }, |
diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c index 35d9ab95c5cb..b3455a970a1d 100644 --- a/drivers/tty/serial/8250/8250_pnp.c +++ b/drivers/tty/serial/8250/8250_pnp.c | |||
| @@ -429,6 +429,7 @@ serial_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id) | |||
| 429 | { | 429 | { |
| 430 | struct uart_8250_port uart; | 430 | struct uart_8250_port uart; |
| 431 | int ret, line, flags = dev_id->driver_data; | 431 | int ret, line, flags = dev_id->driver_data; |
| 432 | struct resource *res = NULL; | ||
| 432 | 433 | ||
| 433 | if (flags & UNKNOWN_DEV) { | 434 | if (flags & UNKNOWN_DEV) { |
| 434 | ret = serial_pnp_guess_board(dev); | 435 | ret = serial_pnp_guess_board(dev); |
| @@ -439,11 +440,12 @@ serial_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id) | |||
| 439 | memset(&uart, 0, sizeof(uart)); | 440 | memset(&uart, 0, sizeof(uart)); |
| 440 | if (pnp_irq_valid(dev, 0)) | 441 | if (pnp_irq_valid(dev, 0)) |
| 441 | uart.port.irq = pnp_irq(dev, 0); | 442 | uart.port.irq = pnp_irq(dev, 0); |
| 442 | if ((flags & CIR_PORT) && pnp_port_valid(dev, 2)) { | 443 | if ((flags & CIR_PORT) && pnp_port_valid(dev, 2)) |
| 443 | uart.port.iobase = pnp_port_start(dev, 2); | 444 | res = pnp_get_resource(dev, IORESOURCE_IO, 2); |
| 444 | uart.port.iotype = UPIO_PORT; | 445 | else if (pnp_port_valid(dev, 0)) |
| 445 | } else if (pnp_port_valid(dev, 0)) { | 446 | res = pnp_get_resource(dev, IORESOURCE_IO, 0); |
| 446 | uart.port.iobase = pnp_port_start(dev, 0); | 447 | if (pnp_resource_enabled(res)) { |
| 448 | uart.port.iobase = res->start; | ||
| 447 | uart.port.iotype = UPIO_PORT; | 449 | uart.port.iotype = UPIO_PORT; |
| 448 | } else if (pnp_mem_valid(dev, 0)) { | 450 | } else if (pnp_mem_valid(dev, 0)) { |
| 449 | uart.port.mapbase = pnp_mem_start(dev, 0); | 451 | uart.port.mapbase = pnp_mem_start(dev, 0); |
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index cf9210db9fa9..7e7006fd404e 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig | |||
| @@ -211,14 +211,14 @@ config SERIAL_SAMSUNG | |||
| 211 | config SERIAL_SAMSUNG_UARTS_4 | 211 | config SERIAL_SAMSUNG_UARTS_4 |
| 212 | bool | 212 | bool |
| 213 | depends on PLAT_SAMSUNG | 213 | depends on PLAT_SAMSUNG |
| 214 | default y if !(CPU_S3C2410 || SERIAL_S3C2412 || CPU_S3C2440 || CPU_S3C2442) | 214 | default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442) |
| 215 | help | 215 | help |
| 216 | Internal node for the common case of 4 Samsung compatible UARTs | 216 | Internal node for the common case of 4 Samsung compatible UARTs |
| 217 | 217 | ||
| 218 | config SERIAL_SAMSUNG_UARTS | 218 | config SERIAL_SAMSUNG_UARTS |
| 219 | int | 219 | int |
| 220 | depends on PLAT_SAMSUNG | 220 | depends on PLAT_SAMSUNG |
| 221 | default 6 if ARCH_S5P6450 | 221 | default 6 if CPU_S5P6450 |
| 222 | default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 | 222 | default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 |
| 223 | default 3 | 223 | default 3 |
| 224 | help | 224 | help |
diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c index 719594e5fc21..52a3ecd40421 100644 --- a/drivers/tty/serial/bcm63xx_uart.c +++ b/drivers/tty/serial/bcm63xx_uart.c | |||
| @@ -235,7 +235,7 @@ static const char *bcm_uart_type(struct uart_port *port) | |||
| 235 | */ | 235 | */ |
| 236 | static void bcm_uart_do_rx(struct uart_port *port) | 236 | static void bcm_uart_do_rx(struct uart_port *port) |
| 237 | { | 237 | { |
| 238 | struct tty_port *port = &port->state->port; | 238 | struct tty_port *tty_port = &port->state->port; |
| 239 | unsigned int max_count; | 239 | unsigned int max_count; |
| 240 | 240 | ||
| 241 | /* limit number of char read in interrupt, should not be | 241 | /* limit number of char read in interrupt, should not be |
| @@ -260,7 +260,7 @@ static void bcm_uart_do_rx(struct uart_port *port) | |||
| 260 | bcm_uart_writel(port, val, UART_CTL_REG); | 260 | bcm_uart_writel(port, val, UART_CTL_REG); |
| 261 | 261 | ||
| 262 | port->icount.overrun++; | 262 | port->icount.overrun++; |
| 263 | tty_insert_flip_char(port, 0, TTY_OVERRUN); | 263 | tty_insert_flip_char(tty_port, 0, TTY_OVERRUN); |
| 264 | } | 264 | } |
| 265 | 265 | ||
| 266 | if (!(iestat & UART_IR_STAT(UART_IR_RXNOTEMPTY))) | 266 | if (!(iestat & UART_IR_STAT(UART_IR_RXNOTEMPTY))) |
| @@ -299,11 +299,11 @@ static void bcm_uart_do_rx(struct uart_port *port) | |||
| 299 | 299 | ||
| 300 | 300 | ||
| 301 | if ((cstat & port->ignore_status_mask) == 0) | 301 | if ((cstat & port->ignore_status_mask) == 0) |
| 302 | tty_insert_flip_char(port, c, flag); | 302 | tty_insert_flip_char(tty_port, c, flag); |
| 303 | 303 | ||
| 304 | } while (--max_count); | 304 | } while (--max_count); |
| 305 | 305 | ||
| 306 | tty_flip_buffer_push(port); | 306 | tty_flip_buffer_push(tty_port); |
| 307 | } | 307 | } |
| 308 | 308 | ||
| 309 | /* | 309 | /* |
diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c index c0e1fad51be7..018bad922554 100644 --- a/drivers/tty/serial/mpc52xx_uart.c +++ b/drivers/tty/serial/mpc52xx_uart.c | |||
| @@ -550,7 +550,7 @@ static int mpc512x_psc_clock(struct uart_port *port, int enable) | |||
| 550 | return 0; | 550 | return 0; |
| 551 | 551 | ||
| 552 | psc_num = (port->mapbase & 0xf00) >> 8; | 552 | psc_num = (port->mapbase & 0xf00) >> 8; |
| 553 | snprintf(clk_name, sizeof(clk_name), "psc%d_clk", psc_num); | 553 | snprintf(clk_name, sizeof(clk_name), "psc%d_mclk", psc_num); |
| 554 | psc_clk = clk_get(port->dev, clk_name); | 554 | psc_clk = clk_get(port->dev, clk_name); |
| 555 | if (IS_ERR(psc_clk)) { | 555 | if (IS_ERR(psc_clk)) { |
| 556 | dev_err(port->dev, "Failed to get PSC clock entry!\n"); | 556 | dev_err(port->dev, "Failed to get PSC clock entry!\n"); |
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c index d5874605682b..b025d5438275 100644 --- a/drivers/tty/serial/of_serial.c +++ b/drivers/tty/serial/of_serial.c | |||
| @@ -241,6 +241,12 @@ static struct of_device_id of_platform_serial_table[] = { | |||
| 241 | { .compatible = "ns16850", .data = (void *)PORT_16850, }, | 241 | { .compatible = "ns16850", .data = (void *)PORT_16850, }, |
| 242 | { .compatible = "nvidia,tegra20-uart", .data = (void *)PORT_TEGRA, }, | 242 | { .compatible = "nvidia,tegra20-uart", .data = (void *)PORT_TEGRA, }, |
| 243 | { .compatible = "nxp,lpc3220-uart", .data = (void *)PORT_LPC3220, }, | 243 | { .compatible = "nxp,lpc3220-uart", .data = (void *)PORT_LPC3220, }, |
| 244 | { .compatible = "altr,16550-FIFO32", | ||
| 245 | .data = (void *)PORT_ALTR_16550_F32, }, | ||
| 246 | { .compatible = "altr,16550-FIFO64", | ||
| 247 | .data = (void *)PORT_ALTR_16550_F64, }, | ||
| 248 | { .compatible = "altr,16550-FIFO128", | ||
| 249 | .data = (void *)PORT_ALTR_16550_F128, }, | ||
| 244 | #ifdef CONFIG_SERIAL_OF_PLATFORM_NWPSERIAL | 250 | #ifdef CONFIG_SERIAL_OF_PLATFORM_NWPSERIAL |
| 245 | { .compatible = "ibm,qpace-nwp-serial", | 251 | { .compatible = "ibm,qpace-nwp-serial", |
| 246 | .data = (void *)PORT_NWPSERIAL, }, | 252 | .data = (void *)PORT_NWPSERIAL, }, |
diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index a3f9dd5c9dff..705240e6c4ec 100644 --- a/drivers/tty/serial/vt8500_serial.c +++ b/drivers/tty/serial/vt8500_serial.c | |||
| @@ -611,14 +611,7 @@ static int vt8500_serial_probe(struct platform_device *pdev) | |||
| 611 | vt8500_port->uart.dev = &pdev->dev; | 611 | vt8500_port->uart.dev = &pdev->dev; |
| 612 | vt8500_port->uart.flags = UPF_IOREMAP | UPF_BOOT_AUTOCONF; | 612 | vt8500_port->uart.flags = UPF_IOREMAP | UPF_BOOT_AUTOCONF; |
| 613 | 613 | ||
| 614 | vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0); | 614 | vt8500_port->uart.uartclk = clk_get_rate(vt8500_port->clk); |
| 615 | if (!IS_ERR(vt8500_port->clk)) { | ||
| 616 | vt8500_port->uart.uartclk = clk_get_rate(vt8500_port->clk); | ||
| 617 | } else { | ||
| 618 | /* use the default of 24Mhz if not specified and warn */ | ||
| 619 | pr_warn("%s: serial clock source not specified\n", __func__); | ||
| 620 | vt8500_port->uart.uartclk = 24000000; | ||
| 621 | } | ||
| 622 | 615 | ||
| 623 | snprintf(vt8500_port->name, sizeof(vt8500_port->name), | 616 | snprintf(vt8500_port->name, sizeof(vt8500_port->name), |
| 624 | "VT8500 UART%d", pdev->id); | 617 | "VT8500 UART%d", pdev->id); |
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index bb119934e76c..578aa7594b11 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c | |||
| @@ -425,7 +425,7 @@ static void flush_to_ldisc(struct work_struct *work) | |||
| 425 | struct tty_ldisc *disc; | 425 | struct tty_ldisc *disc; |
| 426 | 426 | ||
| 427 | tty = port->itty; | 427 | tty = port->itty; |
| 428 | if (WARN_RATELIMIT(tty == NULL, "tty is NULL\n")) | 428 | if (tty == NULL) |
| 429 | return; | 429 | return; |
| 430 | 430 | ||
| 431 | disc = tty_ldisc_ref(tty); | 431 | disc = tty_ldisc_ref(tty); |
diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile index f5ed3d75fa5a..8f5ebced5df0 100644 --- a/drivers/usb/Makefile +++ b/drivers/usb/Makefile | |||
| @@ -46,7 +46,7 @@ obj-$(CONFIG_USB_MICROTEK) += image/ | |||
| 46 | obj-$(CONFIG_USB_SERIAL) += serial/ | 46 | obj-$(CONFIG_USB_SERIAL) += serial/ |
| 47 | 47 | ||
| 48 | obj-$(CONFIG_USB) += misc/ | 48 | obj-$(CONFIG_USB) += misc/ |
| 49 | obj-$(CONFIG_USB_COMMON) += phy/ | 49 | obj-$(CONFIG_USB_OTG_UTILS) += phy/ |
| 50 | obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/ | 50 | obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/ |
| 51 | 51 | ||
| 52 | obj-$(CONFIG_USB_ATM) += atm/ | 52 | obj-$(CONFIG_USB_ATM) += atm/ |
diff --git a/drivers/usb/c67x00/c67x00-sched.c b/drivers/usb/c67x00/c67x00-sched.c index a03fbc15fa9c..aa491627a45b 100644 --- a/drivers/usb/c67x00/c67x00-sched.c +++ b/drivers/usb/c67x00/c67x00-sched.c | |||
| @@ -100,7 +100,7 @@ struct c67x00_urb_priv { | |||
| 100 | #define TD_PIDEP_OFFSET 0x04 | 100 | #define TD_PIDEP_OFFSET 0x04 |
| 101 | #define TD_PIDEPMASK_PID 0xF0 | 101 | #define TD_PIDEPMASK_PID 0xF0 |
| 102 | #define TD_PIDEPMASK_EP 0x0F | 102 | #define TD_PIDEPMASK_EP 0x0F |
| 103 | #define TD_PORTLENMASK_DL 0x02FF | 103 | #define TD_PORTLENMASK_DL 0x03FF |
| 104 | #define TD_PORTLENMASK_PN 0xC000 | 104 | #define TD_PORTLENMASK_PN 0xC000 |
| 105 | 105 | ||
| 106 | #define TD_STATUS_OFFSET 0x07 | 106 | #define TD_STATUS_OFFSET 0x07 |
| @@ -590,7 +590,7 @@ static int c67x00_create_td(struct c67x00_hcd *c67x00, struct urb *urb, | |||
| 590 | { | 590 | { |
| 591 | struct c67x00_td *td; | 591 | struct c67x00_td *td; |
| 592 | struct c67x00_urb_priv *urbp = urb->hcpriv; | 592 | struct c67x00_urb_priv *urbp = urb->hcpriv; |
| 593 | const __u8 active_flag = 1, retry_cnt = 1; | 593 | const __u8 active_flag = 1, retry_cnt = 3; |
| 594 | __u8 cmd = 0; | 594 | __u8 cmd = 0; |
| 595 | int tt = 0; | 595 | int tt = 0; |
| 596 | 596 | ||
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 2f45bba8561d..f64fbea1cf20 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c | |||
| @@ -1767,7 +1767,7 @@ static int udc_start(struct ci13xxx *ci) | |||
| 1767 | goto put_transceiver; | 1767 | goto put_transceiver; |
| 1768 | } | 1768 | } |
| 1769 | 1769 | ||
| 1770 | retval = dbg_create_files(&ci->gadget.dev); | 1770 | retval = dbg_create_files(ci->dev); |
| 1771 | if (retval) | 1771 | if (retval) |
| 1772 | goto unreg_device; | 1772 | goto unreg_device; |
| 1773 | 1773 | ||
| @@ -1796,7 +1796,7 @@ remove_trans: | |||
| 1796 | 1796 | ||
| 1797 | dev_err(dev, "error = %i\n", retval); | 1797 | dev_err(dev, "error = %i\n", retval); |
| 1798 | remove_dbg: | 1798 | remove_dbg: |
| 1799 | dbg_remove_files(&ci->gadget.dev); | 1799 | dbg_remove_files(ci->dev); |
| 1800 | unreg_device: | 1800 | unreg_device: |
| 1801 | device_unregister(&ci->gadget.dev); | 1801 | device_unregister(&ci->gadget.dev); |
| 1802 | put_transceiver: | 1802 | put_transceiver: |
| @@ -1836,7 +1836,7 @@ static void udc_stop(struct ci13xxx *ci) | |||
| 1836 | if (ci->global_phy) | 1836 | if (ci->global_phy) |
| 1837 | usb_put_phy(ci->transceiver); | 1837 | usb_put_phy(ci->transceiver); |
| 1838 | } | 1838 | } |
| 1839 | dbg_remove_files(&ci->gadget.dev); | 1839 | dbg_remove_files(ci->dev); |
| 1840 | device_unregister(&ci->gadget.dev); | 1840 | device_unregister(&ci->gadget.dev); |
| 1841 | /* my kobject is dynamic, I swear! */ | 1841 | /* my kobject is dynamic, I swear! */ |
| 1842 | memset(&ci->gadget, 0, sizeof(ci->gadget)); | 1842 | memset(&ci->gadget, 0, sizeof(ci->gadget)); |
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 5f0cb417b736..122d056d96d5 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c | |||
| @@ -56,6 +56,7 @@ MODULE_DEVICE_TABLE (usb, wdm_ids); | |||
| 56 | #define WDM_RESPONDING 7 | 56 | #define WDM_RESPONDING 7 |
| 57 | #define WDM_SUSPENDING 8 | 57 | #define WDM_SUSPENDING 8 |
| 58 | #define WDM_RESETTING 9 | 58 | #define WDM_RESETTING 9 |
| 59 | #define WDM_OVERFLOW 10 | ||
| 59 | 60 | ||
| 60 | #define WDM_MAX 16 | 61 | #define WDM_MAX 16 |
| 61 | 62 | ||
| @@ -155,6 +156,7 @@ static void wdm_in_callback(struct urb *urb) | |||
| 155 | { | 156 | { |
| 156 | struct wdm_device *desc = urb->context; | 157 | struct wdm_device *desc = urb->context; |
| 157 | int status = urb->status; | 158 | int status = urb->status; |
| 159 | int length = urb->actual_length; | ||
| 158 | 160 | ||
| 159 | spin_lock(&desc->iuspin); | 161 | spin_lock(&desc->iuspin); |
| 160 | clear_bit(WDM_RESPONDING, &desc->flags); | 162 | clear_bit(WDM_RESPONDING, &desc->flags); |
| @@ -185,9 +187,17 @@ static void wdm_in_callback(struct urb *urb) | |||
| 185 | } | 187 | } |
| 186 | 188 | ||
| 187 | desc->rerr = status; | 189 | desc->rerr = status; |
| 188 | desc->reslength = urb->actual_length; | 190 | if (length + desc->length > desc->wMaxCommand) { |
| 189 | memmove(desc->ubuf + desc->length, desc->inbuf, desc->reslength); | 191 | /* The buffer would overflow */ |
| 190 | desc->length += desc->reslength; | 192 | set_bit(WDM_OVERFLOW, &desc->flags); |
| 193 | } else { | ||
| 194 | /* we may already be in overflow */ | ||
| 195 | if (!test_bit(WDM_OVERFLOW, &desc->flags)) { | ||
| 196 | memmove(desc->ubuf + desc->length, desc->inbuf, length); | ||
| 197 | desc->length += length; | ||
| 198 | desc->reslength = length; | ||
| 199 | } | ||
| 200 | } | ||
| 191 | skip_error: | 201 | skip_error: |
| 192 | wake_up(&desc->wait); | 202 | wake_up(&desc->wait); |
| 193 | 203 | ||
| @@ -435,6 +445,11 @@ retry: | |||
| 435 | rv = -ENODEV; | 445 | rv = -ENODEV; |
| 436 | goto err; | 446 | goto err; |
| 437 | } | 447 | } |
| 448 | if (test_bit(WDM_OVERFLOW, &desc->flags)) { | ||
| 449 | clear_bit(WDM_OVERFLOW, &desc->flags); | ||
| 450 | rv = -ENOBUFS; | ||
| 451 | goto err; | ||
| 452 | } | ||
| 438 | i++; | 453 | i++; |
| 439 | if (file->f_flags & O_NONBLOCK) { | 454 | if (file->f_flags & O_NONBLOCK) { |
| 440 | if (!test_bit(WDM_READ, &desc->flags)) { | 455 | if (!test_bit(WDM_READ, &desc->flags)) { |
| @@ -478,6 +493,7 @@ retry: | |||
| 478 | spin_unlock_irq(&desc->iuspin); | 493 | spin_unlock_irq(&desc->iuspin); |
| 479 | goto retry; | 494 | goto retry; |
| 480 | } | 495 | } |
| 496 | |||
| 481 | if (!desc->reslength) { /* zero length read */ | 497 | if (!desc->reslength) { /* zero length read */ |
| 482 | dev_dbg(&desc->intf->dev, "%s: zero length - clearing WDM_READ\n", __func__); | 498 | dev_dbg(&desc->intf->dev, "%s: zero length - clearing WDM_READ\n", __func__); |
| 483 | clear_bit(WDM_READ, &desc->flags); | 499 | clear_bit(WDM_READ, &desc->flags); |
| @@ -1004,6 +1020,7 @@ static int wdm_post_reset(struct usb_interface *intf) | |||
| 1004 | struct wdm_device *desc = wdm_find_device(intf); | 1020 | struct wdm_device *desc = wdm_find_device(intf); |
| 1005 | int rv; | 1021 | int rv; |
| 1006 | 1022 | ||
| 1023 | clear_bit(WDM_OVERFLOW, &desc->flags); | ||
| 1007 | clear_bit(WDM_RESETTING, &desc->flags); | 1024 | clear_bit(WDM_RESETTING, &desc->flags); |
| 1008 | rv = recover_from_urb_loss(desc); | 1025 | rv = recover_from_urb_loss(desc); |
| 1009 | mutex_unlock(&desc->wlock); | 1026 | mutex_unlock(&desc->wlock); |
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 999909451e37..ffa6b004a84b 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c | |||
| @@ -583,6 +583,7 @@ static int dwc3_remove(struct platform_device *pdev) | |||
| 583 | break; | 583 | break; |
| 584 | } | 584 | } |
| 585 | 585 | ||
| 586 | dwc3_free_event_buffers(dwc); | ||
| 586 | dwc3_core_exit(dwc); | 587 | dwc3_core_exit(dwc); |
| 587 | 588 | ||
| 588 | return 0; | 589 | return 0; |
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index b50da53e9a52..b082bec7343e 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c | |||
| @@ -23,8 +23,6 @@ | |||
| 23 | #include <linux/usb/nop-usb-xceiv.h> | 23 | #include <linux/usb/nop-usb-xceiv.h> |
| 24 | #include <linux/of.h> | 24 | #include <linux/of.h> |
| 25 | 25 | ||
| 26 | #include "core.h" | ||
| 27 | |||
| 28 | struct dwc3_exynos { | 26 | struct dwc3_exynos { |
| 29 | struct platform_device *dwc3; | 27 | struct platform_device *dwc3; |
| 30 | struct platform_device *usb2_phy; | 28 | struct platform_device *usb2_phy; |
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 22f337f57219..afa05e3c9cf4 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c | |||
| @@ -54,8 +54,6 @@ | |||
| 54 | #include <linux/usb/otg.h> | 54 | #include <linux/usb/otg.h> |
| 55 | #include <linux/usb/nop-usb-xceiv.h> | 55 | #include <linux/usb/nop-usb-xceiv.h> |
| 56 | 56 | ||
| 57 | #include "core.h" | ||
| 58 | |||
| 59 | /* | 57 | /* |
| 60 | * All these registers belong to OMAP's Wrapper around the | 58 | * All these registers belong to OMAP's Wrapper around the |
| 61 | * DesignWare USB3 Core. | 59 | * DesignWare USB3 Core. |
| @@ -465,20 +463,20 @@ static int dwc3_omap_remove(struct platform_device *pdev) | |||
| 465 | return 0; | 463 | return 0; |
| 466 | } | 464 | } |
| 467 | 465 | ||
| 468 | static const struct of_device_id of_dwc3_matach[] = { | 466 | static const struct of_device_id of_dwc3_match[] = { |
| 469 | { | 467 | { |
| 470 | "ti,dwc3", | 468 | "ti,dwc3", |
| 471 | }, | 469 | }, |
| 472 | { }, | 470 | { }, |
| 473 | }; | 471 | }; |
| 474 | MODULE_DEVICE_TABLE(of, of_dwc3_matach); | 472 | MODULE_DEVICE_TABLE(of, of_dwc3_match); |
| 475 | 473 | ||
| 476 | static struct platform_driver dwc3_omap_driver = { | 474 | static struct platform_driver dwc3_omap_driver = { |
| 477 | .probe = dwc3_omap_probe, | 475 | .probe = dwc3_omap_probe, |
| 478 | .remove = dwc3_omap_remove, | 476 | .remove = dwc3_omap_remove, |
| 479 | .driver = { | 477 | .driver = { |
| 480 | .name = "omap-dwc3", | 478 | .name = "omap-dwc3", |
| 481 | .of_match_table = of_dwc3_matach, | 479 | .of_match_table = of_dwc3_match, |
| 482 | }, | 480 | }, |
| 483 | }; | 481 | }; |
| 484 | 482 | ||
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 7d70f44567d2..e8d77689a322 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c | |||
| @@ -45,8 +45,6 @@ | |||
| 45 | #include <linux/usb/otg.h> | 45 | #include <linux/usb/otg.h> |
| 46 | #include <linux/usb/nop-usb-xceiv.h> | 46 | #include <linux/usb/nop-usb-xceiv.h> |
| 47 | 47 | ||
| 48 | #include "core.h" | ||
| 49 | |||
| 50 | /* FIXME define these in <linux/pci_ids.h> */ | 48 | /* FIXME define these in <linux/pci_ids.h> */ |
| 51 | #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 | 49 | #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 |
| 52 | #define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd | 50 | #define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd |
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index d7da073a23fe..1d139ca05ef1 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c | |||
| @@ -891,7 +891,8 @@ static void __dwc3_ep0_do_control_data(struct dwc3 *dwc, | |||
| 891 | DWC3_TRBCTL_CONTROL_DATA); | 891 | DWC3_TRBCTL_CONTROL_DATA); |
| 892 | } else if (!IS_ALIGNED(req->request.length, dep->endpoint.maxpacket) | 892 | } else if (!IS_ALIGNED(req->request.length, dep->endpoint.maxpacket) |
| 893 | && (dep->number == 0)) { | 893 | && (dep->number == 0)) { |
| 894 | u32 transfer_size; | 894 | u32 transfer_size; |
| 895 | u32 maxpacket; | ||
| 895 | 896 | ||
| 896 | ret = usb_gadget_map_request(&dwc->gadget, &req->request, | 897 | ret = usb_gadget_map_request(&dwc->gadget, &req->request, |
| 897 | dep->number); | 898 | dep->number); |
| @@ -902,8 +903,8 @@ static void __dwc3_ep0_do_control_data(struct dwc3 *dwc, | |||
| 902 | 903 | ||
| 903 | WARN_ON(req->request.length > DWC3_EP0_BOUNCE_SIZE); | 904 | WARN_ON(req->request.length > DWC3_EP0_BOUNCE_SIZE); |
| 904 | 905 | ||
| 905 | transfer_size = roundup(req->request.length, | 906 | maxpacket = dep->endpoint.maxpacket; |
| 906 | (u32) dep->endpoint.maxpacket); | 907 | transfer_size = roundup(req->request.length, maxpacket); |
| 907 | 908 | ||
| 908 | dwc->ep0_bounced = true; | 909 | dwc->ep0_bounced = true; |
| 909 | 910 | ||
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index a04342f6cbfa..82e160e96fca 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c | |||
| @@ -2159,7 +2159,6 @@ static void dwc3_gadget_phy_suspend(struct dwc3 *dwc, u8 speed) | |||
| 2159 | 2159 | ||
| 2160 | static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc) | 2160 | static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc) |
| 2161 | { | 2161 | { |
| 2162 | struct dwc3_gadget_ep_cmd_params params; | ||
| 2163 | struct dwc3_ep *dep; | 2162 | struct dwc3_ep *dep; |
| 2164 | int ret; | 2163 | int ret; |
| 2165 | u32 reg; | 2164 | u32 reg; |
| @@ -2167,8 +2166,6 @@ static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc) | |||
| 2167 | 2166 | ||
| 2168 | dev_vdbg(dwc->dev, "%s\n", __func__); | 2167 | dev_vdbg(dwc->dev, "%s\n", __func__); |
| 2169 | 2168 | ||
| 2170 | memset(¶ms, 0x00, sizeof(params)); | ||
| 2171 | |||
| 2172 | reg = dwc3_readl(dwc->regs, DWC3_DSTS); | 2169 | reg = dwc3_readl(dwc->regs, DWC3_DSTS); |
| 2173 | speed = reg & DWC3_DSTS_CONNECTSPD; | 2170 | speed = reg & DWC3_DSTS_CONNECTSPD; |
| 2174 | dwc->speed = speed; | 2171 | dwc->speed = speed; |
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile index 97a13c349cc5..82fb22511356 100644 --- a/drivers/usb/gadget/Makefile +++ b/drivers/usb/gadget/Makefile | |||
| @@ -35,6 +35,12 @@ mv_udc-y := mv_udc_core.o | |||
| 35 | obj-$(CONFIG_USB_FUSB300) += fusb300_udc.o | 35 | obj-$(CONFIG_USB_FUSB300) += fusb300_udc.o |
| 36 | obj-$(CONFIG_USB_MV_U3D) += mv_u3d_core.o | 36 | obj-$(CONFIG_USB_MV_U3D) += mv_u3d_core.o |
| 37 | 37 | ||
| 38 | # USB Functions | ||
| 39 | obj-$(CONFIG_USB_F_ACM) += f_acm.o | ||
| 40 | f_ss_lb-y := f_loopback.o f_sourcesink.o | ||
| 41 | obj-$(CONFIG_USB_F_SS_LB) += f_ss_lb.o | ||
| 42 | obj-$(CONFIG_USB_U_SERIAL) += u_serial.o | ||
| 43 | |||
| 38 | # | 44 | # |
| 39 | # USB gadget drivers | 45 | # USB gadget drivers |
| 40 | # | 46 | # |
| @@ -74,9 +80,3 @@ obj-$(CONFIG_USB_G_WEBCAM) += g_webcam.o | |||
| 74 | obj-$(CONFIG_USB_G_NCM) += g_ncm.o | 80 | obj-$(CONFIG_USB_G_NCM) += g_ncm.o |
| 75 | obj-$(CONFIG_USB_G_ACM_MS) += g_acm_ms.o | 81 | obj-$(CONFIG_USB_G_ACM_MS) += g_acm_ms.o |
| 76 | obj-$(CONFIG_USB_GADGET_TARGET) += tcm_usb_gadget.o | 82 | obj-$(CONFIG_USB_GADGET_TARGET) += tcm_usb_gadget.o |
| 77 | |||
| 78 | # USB Functions | ||
| 79 | obj-$(CONFIG_USB_F_ACM) += f_acm.o | ||
| 80 | f_ss_lb-y := f_loopback.o f_sourcesink.o | ||
| 81 | obj-$(CONFIG_USB_F_SS_LB) += f_ss_lb.o | ||
| 82 | obj-$(CONFIG_USB_U_SERIAL) += u_serial.o | ||
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 7c821de8ce3d..c0d62b278610 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c | |||
| @@ -1757,10 +1757,7 @@ static const struct usb_gadget_driver composite_driver_template = { | |||
| 1757 | /** | 1757 | /** |
| 1758 | * usb_composite_probe() - register a composite driver | 1758 | * usb_composite_probe() - register a composite driver |
| 1759 | * @driver: the driver to register | 1759 | * @driver: the driver to register |
| 1760 | * @bind: the callback used to allocate resources that are shared across the | 1760 | * |
| 1761 | * whole device, such as string IDs, and add its configurations using | ||
| 1762 | * @usb_add_config(). This may fail by returning a negative errno | ||
| 1763 | * value; it should return zero on successful initialization. | ||
| 1764 | * Context: single threaded during gadget setup | 1761 | * Context: single threaded during gadget setup |
| 1765 | * | 1762 | * |
| 1766 | * This function is used to register drivers using the composite driver | 1763 | * This function is used to register drivers using the composite driver |
diff --git a/drivers/usb/gadget/f_uac1.c b/drivers/usb/gadget/f_uac1.c index f570e667a640..fa8ea4ea00c1 100644 --- a/drivers/usb/gadget/f_uac1.c +++ b/drivers/usb/gadget/f_uac1.c | |||
| @@ -418,6 +418,7 @@ static int audio_get_intf_req(struct usb_function *f, | |||
| 418 | 418 | ||
| 419 | req->context = audio; | 419 | req->context = audio; |
| 420 | req->complete = f_audio_complete; | 420 | req->complete = f_audio_complete; |
| 421 | len = min_t(size_t, sizeof(value), len); | ||
| 421 | memcpy(req->buf, &value, len); | 422 | memcpy(req->buf, &value, len); |
| 422 | 423 | ||
| 423 | return len; | 424 | return len; |
diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c index 8efd7555fa21..5bd930d779b9 100644 --- a/drivers/usb/gadget/imx_udc.c +++ b/drivers/usb/gadget/imx_udc.c | |||
| @@ -1334,27 +1334,18 @@ static int imx_udc_start(struct usb_gadget *gadget, | |||
| 1334 | struct usb_gadget_driver *driver) | 1334 | struct usb_gadget_driver *driver) |
| 1335 | { | 1335 | { |
| 1336 | struct imx_udc_struct *imx_usb; | 1336 | struct imx_udc_struct *imx_usb; |
| 1337 | int retval; | ||
| 1338 | 1337 | ||
| 1339 | imx_usb = container_of(gadget, struct imx_udc_struct, gadget); | 1338 | imx_usb = container_of(gadget, struct imx_udc_struct, gadget); |
| 1340 | /* first hook up the driver ... */ | 1339 | /* first hook up the driver ... */ |
| 1341 | imx_usb->driver = driver; | 1340 | imx_usb->driver = driver; |
| 1342 | imx_usb->gadget.dev.driver = &driver->driver; | 1341 | imx_usb->gadget.dev.driver = &driver->driver; |
| 1343 | 1342 | ||
| 1344 | retval = device_add(&imx_usb->gadget.dev); | ||
| 1345 | if (retval) | ||
| 1346 | goto fail; | ||
| 1347 | |||
| 1348 | D_INI(imx_usb->dev, "<%s> registered gadget driver '%s'\n", | 1343 | D_INI(imx_usb->dev, "<%s> registered gadget driver '%s'\n", |
| 1349 | __func__, driver->driver.name); | 1344 | __func__, driver->driver.name); |
| 1350 | 1345 | ||
| 1351 | imx_udc_enable(imx_usb); | 1346 | imx_udc_enable(imx_usb); |
| 1352 | 1347 | ||
| 1353 | return 0; | 1348 | return 0; |
| 1354 | fail: | ||
| 1355 | imx_usb->driver = NULL; | ||
| 1356 | imx_usb->gadget.dev.driver = NULL; | ||
| 1357 | return retval; | ||
| 1358 | } | 1349 | } |
| 1359 | 1350 | ||
| 1360 | static int imx_udc_stop(struct usb_gadget *gadget, | 1351 | static int imx_udc_stop(struct usb_gadget *gadget, |
| @@ -1370,8 +1361,6 @@ static int imx_udc_stop(struct usb_gadget *gadget, | |||
| 1370 | imx_usb->gadget.dev.driver = NULL; | 1361 | imx_usb->gadget.dev.driver = NULL; |
| 1371 | imx_usb->driver = NULL; | 1362 | imx_usb->driver = NULL; |
| 1372 | 1363 | ||
| 1373 | device_del(&imx_usb->gadget.dev); | ||
| 1374 | |||
| 1375 | D_INI(imx_usb->dev, "<%s> unregistered gadget driver '%s'\n", | 1364 | D_INI(imx_usb->dev, "<%s> unregistered gadget driver '%s'\n", |
| 1376 | __func__, driver->driver.name); | 1365 | __func__, driver->driver.name); |
| 1377 | 1366 | ||
| @@ -1477,6 +1466,10 @@ static int __init imx_udc_probe(struct platform_device *pdev) | |||
| 1477 | imx_usb->gadget.dev.parent = &pdev->dev; | 1466 | imx_usb->gadget.dev.parent = &pdev->dev; |
| 1478 | imx_usb->gadget.dev.dma_mask = pdev->dev.dma_mask; | 1467 | imx_usb->gadget.dev.dma_mask = pdev->dev.dma_mask; |
| 1479 | 1468 | ||
| 1469 | ret = device_add(&imx_usb->gadget.dev); | ||
| 1470 | if (retval) | ||
| 1471 | goto fail4; | ||
| 1472 | |||
| 1480 | platform_set_drvdata(pdev, imx_usb); | 1473 | platform_set_drvdata(pdev, imx_usb); |
| 1481 | 1474 | ||
| 1482 | usb_init_data(imx_usb); | 1475 | usb_init_data(imx_usb); |
| @@ -1488,9 +1481,11 @@ static int __init imx_udc_probe(struct platform_device *pdev) | |||
| 1488 | 1481 | ||
| 1489 | ret = usb_add_gadget_udc(&pdev->dev, &imx_usb->gadget); | 1482 | ret = usb_add_gadget_udc(&pdev->dev, &imx_usb->gadget); |
| 1490 | if (ret) | 1483 | if (ret) |
| 1491 | goto fail4; | 1484 | goto fail5; |
| 1492 | 1485 | ||
| 1493 | return 0; | 1486 | return 0; |
| 1487 | fail5: | ||
| 1488 | device_unregister(&imx_usb->gadget.dev); | ||
| 1494 | fail4: | 1489 | fail4: |
| 1495 | for (i = 0; i < IMX_USB_NB_EP + 1; i++) | 1490 | for (i = 0; i < IMX_USB_NB_EP + 1; i++) |
| 1496 | free_irq(imx_usb->usbd_int[i], imx_usb); | 1491 | free_irq(imx_usb->usbd_int[i], imx_usb); |
| @@ -1514,6 +1509,7 @@ static int __exit imx_udc_remove(struct platform_device *pdev) | |||
| 1514 | int i; | 1509 | int i; |
| 1515 | 1510 | ||
| 1516 | usb_del_gadget_udc(&imx_usb->gadget); | 1511 | usb_del_gadget_udc(&imx_usb->gadget); |
| 1512 | device_unregister(&imx_usb->gadget.dev); | ||
| 1517 | imx_udc_disable(imx_usb); | 1513 | imx_udc_disable(imx_usb); |
| 1518 | del_timer(&imx_usb->timer); | 1514 | del_timer(&imx_usb->timer); |
| 1519 | 1515 | ||
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index 06be85c2b233..f8445653577f 100644 --- a/drivers/usb/gadget/omap_udc.c +++ b/drivers/usb/gadget/omap_udc.c | |||
| @@ -62,6 +62,7 @@ | |||
| 62 | #define DRIVER_VERSION "4 October 2004" | 62 | #define DRIVER_VERSION "4 October 2004" |
| 63 | 63 | ||
| 64 | #define OMAP_DMA_USB_W2FC_TX0 29 | 64 | #define OMAP_DMA_USB_W2FC_TX0 29 |
| 65 | #define OMAP_DMA_USB_W2FC_RX0 26 | ||
| 65 | 66 | ||
| 66 | /* | 67 | /* |
| 67 | * The OMAP UDC needs _very_ early endpoint setup: before enabling the | 68 | * The OMAP UDC needs _very_ early endpoint setup: before enabling the |
| @@ -1310,7 +1311,7 @@ static int omap_pullup(struct usb_gadget *gadget, int is_on) | |||
| 1310 | } | 1311 | } |
| 1311 | 1312 | ||
| 1312 | static int omap_udc_start(struct usb_gadget *g, | 1313 | static int omap_udc_start(struct usb_gadget *g, |
| 1313 | struct usb_gadget_driver *driver) | 1314 | struct usb_gadget_driver *driver); |
| 1314 | static int omap_udc_stop(struct usb_gadget *g, | 1315 | static int omap_udc_stop(struct usb_gadget *g, |
| 1315 | struct usb_gadget_driver *driver); | 1316 | struct usb_gadget_driver *driver); |
| 1316 | 1317 | ||
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c index 2bbcdce942dc..d0f37484b6b0 100644 --- a/drivers/usb/gadget/pxa25x_udc.c +++ b/drivers/usb/gadget/pxa25x_udc.c | |||
| @@ -1266,13 +1266,6 @@ static int pxa25x_udc_start(struct usb_gadget *g, | |||
| 1266 | dev->gadget.dev.driver = &driver->driver; | 1266 | dev->gadget.dev.driver = &driver->driver; |
| 1267 | dev->pullup = 1; | 1267 | dev->pullup = 1; |
| 1268 | 1268 | ||
| 1269 | retval = device_add (&dev->gadget.dev); | ||
| 1270 | if (retval) { | ||
| 1271 | dev->driver = NULL; | ||
| 1272 | dev->gadget.dev.driver = NULL; | ||
| 1273 | return retval; | ||
| 1274 | } | ||
| 1275 | |||
| 1276 | /* ... then enable host detection and ep0; and we're ready | 1269 | /* ... then enable host detection and ep0; and we're ready |
| 1277 | * for set_configuration as well as eventual disconnect. | 1270 | * for set_configuration as well as eventual disconnect. |
| 1278 | */ | 1271 | */ |
| @@ -1310,6 +1303,10 @@ stop_activity(struct pxa25x_udc *dev, struct usb_gadget_driver *driver) | |||
| 1310 | } | 1303 | } |
| 1311 | del_timer_sync(&dev->timer); | 1304 | del_timer_sync(&dev->timer); |
| 1312 | 1305 | ||
| 1306 | /* report disconnect; the driver is already quiesced */ | ||
| 1307 | if (driver) | ||
| 1308 | driver->disconnect(&dev->gadget); | ||
| 1309 | |||
| 1313 | /* re-init driver-visible data structures */ | 1310 | /* re-init driver-visible data structures */ |
| 1314 | udc_reinit(dev); | 1311 | udc_reinit(dev); |
| 1315 | } | 1312 | } |
| @@ -1331,7 +1328,6 @@ static int pxa25x_udc_stop(struct usb_gadget*g, | |||
| 1331 | dev->gadget.dev.driver = NULL; | 1328 | dev->gadget.dev.driver = NULL; |
| 1332 | dev->driver = NULL; | 1329 | dev->driver = NULL; |
| 1333 | 1330 | ||
| 1334 | device_del (&dev->gadget.dev); | ||
| 1335 | dump_state(dev); | 1331 | dump_state(dev); |
| 1336 | 1332 | ||
| 1337 | return 0; | 1333 | return 0; |
| @@ -2146,6 +2142,13 @@ static int __init pxa25x_udc_probe(struct platform_device *pdev) | |||
| 2146 | dev->gadget.dev.parent = &pdev->dev; | 2142 | dev->gadget.dev.parent = &pdev->dev; |
| 2147 | dev->gadget.dev.dma_mask = pdev->dev.dma_mask; | 2143 | dev->gadget.dev.dma_mask = pdev->dev.dma_mask; |
| 2148 | 2144 | ||
| 2145 | retval = device_add(&dev->gadget.dev); | ||
| 2146 | if (retval) { | ||
| 2147 | dev->driver = NULL; | ||
| 2148 | dev->gadget.dev.driver = NULL; | ||
| 2149 | goto err_device_add; | ||
| 2150 | } | ||
| 2151 | |||
| 2149 | the_controller = dev; | 2152 | the_controller = dev; |
| 2150 | platform_set_drvdata(pdev, dev); | 2153 | platform_set_drvdata(pdev, dev); |
| 2151 | 2154 | ||
| @@ -2196,6 +2199,8 @@ lubbock_fail0: | |||
| 2196 | free_irq(irq, dev); | 2199 | free_irq(irq, dev); |
| 2197 | #endif | 2200 | #endif |
| 2198 | err_irq1: | 2201 | err_irq1: |
| 2202 | device_unregister(&dev->gadget.dev); | ||
| 2203 | err_device_add: | ||
| 2199 | if (gpio_is_valid(dev->mach->gpio_pullup)) | 2204 | if (gpio_is_valid(dev->mach->gpio_pullup)) |
| 2200 | gpio_free(dev->mach->gpio_pullup); | 2205 | gpio_free(dev->mach->gpio_pullup); |
| 2201 | err_gpio_pullup: | 2206 | err_gpio_pullup: |
| @@ -2217,10 +2222,11 @@ static int __exit pxa25x_udc_remove(struct platform_device *pdev) | |||
| 2217 | { | 2222 | { |
| 2218 | struct pxa25x_udc *dev = platform_get_drvdata(pdev); | 2223 | struct pxa25x_udc *dev = platform_get_drvdata(pdev); |
| 2219 | 2224 | ||
| 2220 | usb_del_gadget_udc(&dev->gadget); | ||
| 2221 | if (dev->driver) | 2225 | if (dev->driver) |
| 2222 | return -EBUSY; | 2226 | return -EBUSY; |
| 2223 | 2227 | ||
| 2228 | usb_del_gadget_udc(&dev->gadget); | ||
| 2229 | device_unregister(&dev->gadget.dev); | ||
| 2224 | dev->pullup = 0; | 2230 | dev->pullup = 0; |
| 2225 | pullup(dev); | 2231 | pullup(dev); |
| 2226 | 2232 | ||
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c index f7d25795821a..2fc867652ef5 100644 --- a/drivers/usb/gadget/pxa27x_udc.c +++ b/drivers/usb/gadget/pxa27x_udc.c | |||
| @@ -1814,11 +1814,6 @@ static int pxa27x_udc_start(struct usb_gadget *g, | |||
| 1814 | udc->gadget.dev.driver = &driver->driver; | 1814 | udc->gadget.dev.driver = &driver->driver; |
| 1815 | dplus_pullup(udc, 1); | 1815 | dplus_pullup(udc, 1); |
| 1816 | 1816 | ||
| 1817 | retval = device_add(&udc->gadget.dev); | ||
| 1818 | if (retval) { | ||
| 1819 | dev_err(udc->dev, "device_add error %d\n", retval); | ||
| 1820 | goto fail; | ||
| 1821 | } | ||
| 1822 | if (!IS_ERR_OR_NULL(udc->transceiver)) { | 1817 | if (!IS_ERR_OR_NULL(udc->transceiver)) { |
| 1823 | retval = otg_set_peripheral(udc->transceiver->otg, | 1818 | retval = otg_set_peripheral(udc->transceiver->otg, |
| 1824 | &udc->gadget); | 1819 | &udc->gadget); |
| @@ -1876,7 +1871,6 @@ static int pxa27x_udc_stop(struct usb_gadget *g, | |||
| 1876 | 1871 | ||
| 1877 | udc->driver = NULL; | 1872 | udc->driver = NULL; |
| 1878 | 1873 | ||
| 1879 | device_del(&udc->gadget.dev); | ||
| 1880 | 1874 | ||
| 1881 | if (!IS_ERR_OR_NULL(udc->transceiver)) | 1875 | if (!IS_ERR_OR_NULL(udc->transceiver)) |
| 1882 | return otg_set_peripheral(udc->transceiver->otg, NULL); | 1876 | return otg_set_peripheral(udc->transceiver->otg, NULL); |
| @@ -2480,13 +2474,24 @@ static int __init pxa_udc_probe(struct platform_device *pdev) | |||
| 2480 | driver_name, udc->irq, retval); | 2474 | driver_name, udc->irq, retval); |
| 2481 | goto err_irq; | 2475 | goto err_irq; |
| 2482 | } | 2476 | } |
| 2477 | |||
| 2478 | retval = device_add(&udc->gadget.dev); | ||
| 2479 | if (retval) { | ||
| 2480 | dev_err(udc->dev, "device_add error %d\n", retval); | ||
| 2481 | goto err_dev_add; | ||
| 2482 | } | ||
| 2483 | |||
| 2483 | retval = usb_add_gadget_udc(&pdev->dev, &udc->gadget); | 2484 | retval = usb_add_gadget_udc(&pdev->dev, &udc->gadget); |
| 2484 | if (retval) | 2485 | if (retval) |
| 2485 | goto err_add_udc; | 2486 | goto err_add_udc; |
| 2486 | 2487 | ||
| 2487 | pxa_init_debugfs(udc); | 2488 | pxa_init_debugfs(udc); |
| 2489 | |||
| 2488 | return 0; | 2490 | return 0; |
| 2491 | |||
| 2489 | err_add_udc: | 2492 | err_add_udc: |
| 2493 | device_unregister(&udc->gadget.dev); | ||
| 2494 | err_dev_add: | ||
| 2490 | free_irq(udc->irq, udc); | 2495 | free_irq(udc->irq, udc); |
| 2491 | err_irq: | 2496 | err_irq: |
| 2492 | iounmap(udc->regs); | 2497 | iounmap(udc->regs); |
| @@ -2507,6 +2512,7 @@ static int __exit pxa_udc_remove(struct platform_device *_dev) | |||
| 2507 | int gpio = udc->mach->gpio_pullup; | 2512 | int gpio = udc->mach->gpio_pullup; |
| 2508 | 2513 | ||
| 2509 | usb_del_gadget_udc(&udc->gadget); | 2514 | usb_del_gadget_udc(&udc->gadget); |
| 2515 | device_del(&udc->gadget.dev); | ||
| 2510 | usb_gadget_unregister_driver(udc->driver); | 2516 | usb_gadget_unregister_driver(udc->driver); |
| 2511 | free_irq(udc->irq, udc); | 2517 | free_irq(udc->irq, udc); |
| 2512 | pxa_cleanup_debugfs(udc); | 2518 | pxa_cleanup_debugfs(udc); |
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index fc07b4381286..08f89652533b 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c | |||
| @@ -1668,8 +1668,7 @@ static void s3c2410_udc_enable(struct s3c2410_udc *dev) | |||
| 1668 | static int s3c2410_udc_start(struct usb_gadget *g, | 1668 | static int s3c2410_udc_start(struct usb_gadget *g, |
| 1669 | struct usb_gadget_driver *driver) | 1669 | struct usb_gadget_driver *driver) |
| 1670 | { | 1670 | { |
| 1671 | struct s3c2410_udc *udc = to_s3c2410(g) | 1671 | struct s3c2410_udc *udc = to_s3c2410(g); |
| 1672 | int retval; | ||
| 1673 | 1672 | ||
| 1674 | dprintk(DEBUG_NORMAL, "%s() '%s'\n", __func__, driver->driver.name); | 1673 | dprintk(DEBUG_NORMAL, "%s() '%s'\n", __func__, driver->driver.name); |
| 1675 | 1674 | ||
| @@ -1677,22 +1676,10 @@ static int s3c2410_udc_start(struct usb_gadget *g, | |||
| 1677 | udc->driver = driver; | 1676 | udc->driver = driver; |
| 1678 | udc->gadget.dev.driver = &driver->driver; | 1677 | udc->gadget.dev.driver = &driver->driver; |
| 1679 | 1678 | ||
| 1680 | /* Bind the driver */ | ||
| 1681 | retval = device_add(&udc->gadget.dev); | ||
| 1682 | if (retval) { | ||
| 1683 | dev_err(&udc->gadget.dev, "Error in device_add() : %d\n", retval); | ||
| 1684 | goto register_error; | ||
| 1685 | } | ||
| 1686 | |||
| 1687 | /* Enable udc */ | 1679 | /* Enable udc */ |
| 1688 | s3c2410_udc_enable(udc); | 1680 | s3c2410_udc_enable(udc); |
| 1689 | 1681 | ||
| 1690 | return 0; | 1682 | return 0; |
| 1691 | |||
| 1692 | register_error: | ||
| 1693 | udc->driver = NULL; | ||
| 1694 | udc->gadget.dev.driver = NULL; | ||
| 1695 | return retval; | ||
| 1696 | } | 1683 | } |
| 1697 | 1684 | ||
| 1698 | static int s3c2410_udc_stop(struct usb_gadget *g, | 1685 | static int s3c2410_udc_stop(struct usb_gadget *g, |
| @@ -1700,7 +1687,6 @@ static int s3c2410_udc_stop(struct usb_gadget *g, | |||
| 1700 | { | 1687 | { |
| 1701 | struct s3c2410_udc *udc = to_s3c2410(g); | 1688 | struct s3c2410_udc *udc = to_s3c2410(g); |
| 1702 | 1689 | ||
| 1703 | device_del(&udc->gadget.dev); | ||
| 1704 | udc->driver = NULL; | 1690 | udc->driver = NULL; |
| 1705 | 1691 | ||
| 1706 | /* Disable udc */ | 1692 | /* Disable udc */ |
| @@ -1842,6 +1828,13 @@ static int s3c2410_udc_probe(struct platform_device *pdev) | |||
| 1842 | udc->gadget.dev.parent = &pdev->dev; | 1828 | udc->gadget.dev.parent = &pdev->dev; |
| 1843 | udc->gadget.dev.dma_mask = pdev->dev.dma_mask; | 1829 | udc->gadget.dev.dma_mask = pdev->dev.dma_mask; |
| 1844 | 1830 | ||
| 1831 | /* Bind the driver */ | ||
| 1832 | retval = device_add(&udc->gadget.dev); | ||
| 1833 | if (retval) { | ||
| 1834 | dev_err(&udc->gadget.dev, "Error in device_add() : %d\n", retval); | ||
| 1835 | goto err_device_add; | ||
| 1836 | } | ||
| 1837 | |||
| 1845 | the_controller = udc; | 1838 | the_controller = udc; |
| 1846 | platform_set_drvdata(pdev, udc); | 1839 | platform_set_drvdata(pdev, udc); |
| 1847 | 1840 | ||
| @@ -1930,6 +1923,8 @@ err_gpio_claim: | |||
| 1930 | err_int: | 1923 | err_int: |
| 1931 | free_irq(IRQ_USBD, udc); | 1924 | free_irq(IRQ_USBD, udc); |
| 1932 | err_map: | 1925 | err_map: |
| 1926 | device_unregister(&udc->gadget.dev); | ||
| 1927 | err_device_add: | ||
| 1933 | iounmap(base_addr); | 1928 | iounmap(base_addr); |
| 1934 | err_mem: | 1929 | err_mem: |
| 1935 | release_mem_region(rsrc_start, rsrc_len); | 1930 | release_mem_region(rsrc_start, rsrc_len); |
| @@ -1947,10 +1942,11 @@ static int s3c2410_udc_remove(struct platform_device *pdev) | |||
| 1947 | 1942 | ||
| 1948 | dev_dbg(&pdev->dev, "%s()\n", __func__); | 1943 | dev_dbg(&pdev->dev, "%s()\n", __func__); |
| 1949 | 1944 | ||
| 1950 | usb_del_gadget_udc(&udc->gadget); | ||
| 1951 | if (udc->driver) | 1945 | if (udc->driver) |
| 1952 | return -EBUSY; | 1946 | return -EBUSY; |
| 1953 | 1947 | ||
| 1948 | usb_del_gadget_udc(&udc->gadget); | ||
| 1949 | device_unregister(&udc->gadget.dev); | ||
| 1954 | debugfs_remove(udc->regs_info); | 1950 | debugfs_remove(udc->regs_info); |
| 1955 | 1951 | ||
| 1956 | if (udc_info && !udc_info->udc_command && | 1952 | if (udc_info && !udc_info->udc_command && |
diff --git a/drivers/usb/gadget/u_uac1.c b/drivers/usb/gadget/u_uac1.c index e0c5e88e03ed..c7d460f43390 100644 --- a/drivers/usb/gadget/u_uac1.c +++ b/drivers/usb/gadget/u_uac1.c | |||
| @@ -240,8 +240,11 @@ static int gaudio_open_snd_dev(struct gaudio *card) | |||
| 240 | snd = &card->playback; | 240 | snd = &card->playback; |
| 241 | snd->filp = filp_open(fn_play, O_WRONLY, 0); | 241 | snd->filp = filp_open(fn_play, O_WRONLY, 0); |
| 242 | if (IS_ERR(snd->filp)) { | 242 | if (IS_ERR(snd->filp)) { |
| 243 | int ret = PTR_ERR(snd->filp); | ||
| 244 | |||
| 243 | ERROR(card, "No such PCM playback device: %s\n", fn_play); | 245 | ERROR(card, "No such PCM playback device: %s\n", fn_play); |
| 244 | snd->filp = NULL; | 246 | snd->filp = NULL; |
| 247 | return ret; | ||
| 245 | } | 248 | } |
| 246 | pcm_file = snd->filp->private_data; | 249 | pcm_file = snd->filp->private_data; |
| 247 | snd->substream = pcm_file->substream; | 250 | snd->substream = pcm_file->substream; |
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index b416a3fc9959..5726cb144abf 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c | |||
| @@ -748,11 +748,9 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd) | |||
| 748 | /* guard against (alleged) silicon errata */ | 748 | /* guard against (alleged) silicon errata */ |
| 749 | if (cmd & CMD_IAAD) | 749 | if (cmd & CMD_IAAD) |
| 750 | ehci_dbg(ehci, "IAA with IAAD still set?\n"); | 750 | ehci_dbg(ehci, "IAA with IAAD still set?\n"); |
| 751 | if (ehci->async_iaa) { | 751 | if (ehci->async_iaa) |
| 752 | COUNT(ehci->stats.iaa); | 752 | COUNT(ehci->stats.iaa); |
| 753 | end_unlink_async(ehci); | 753 | end_unlink_async(ehci); |
| 754 | } else | ||
| 755 | ehci_dbg(ehci, "IAA with nothing unlinked?\n"); | ||
| 756 | } | 754 | } |
| 757 | 755 | ||
| 758 | /* remote wakeup [4.3.1] */ | 756 | /* remote wakeup [4.3.1] */ |
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index fd252f0cfb3a..5464665f0b6a 100644 --- a/drivers/usb/host/ehci-q.c +++ b/drivers/usb/host/ehci-q.c | |||
| @@ -135,7 +135,7 @@ qh_refresh (struct ehci_hcd *ehci, struct ehci_qh *qh) | |||
| 135 | * qtd is updated in qh_completions(). Update the QH | 135 | * qtd is updated in qh_completions(). Update the QH |
| 136 | * overlay here. | 136 | * overlay here. |
| 137 | */ | 137 | */ |
| 138 | if (cpu_to_hc32(ehci, qtd->qtd_dma) == qh->hw->hw_current) { | 138 | if (qh->hw->hw_token & ACTIVE_BIT(ehci)) { |
| 139 | qh->hw->hw_qtd_next = qtd->hw_next; | 139 | qh->hw->hw_qtd_next = qtd->hw_next; |
| 140 | qtd = NULL; | 140 | qtd = NULL; |
| 141 | } | 141 | } |
| @@ -449,11 +449,19 @@ qh_completions (struct ehci_hcd *ehci, struct ehci_qh *qh) | |||
| 449 | else if (last_status == -EINPROGRESS && !urb->unlinked) | 449 | else if (last_status == -EINPROGRESS && !urb->unlinked) |
| 450 | continue; | 450 | continue; |
| 451 | 451 | ||
| 452 | /* qh unlinked; token in overlay may be most current */ | 452 | /* |
| 453 | if (state == QH_STATE_IDLE | 453 | * If this was the active qtd when the qh was unlinked |
| 454 | && cpu_to_hc32(ehci, qtd->qtd_dma) | 454 | * and the overlay's token is active, then the overlay |
| 455 | == hw->hw_current) { | 455 | * hasn't been written back to the qtd yet so use its |
| 456 | * token instead of the qtd's. After the qtd is | ||
| 457 | * processed and removed, the overlay won't be valid | ||
| 458 | * any more. | ||
| 459 | */ | ||
| 460 | if (state == QH_STATE_IDLE && | ||
| 461 | qh->qtd_list.next == &qtd->qtd_list && | ||
| 462 | (hw->hw_token & ACTIVE_BIT(ehci))) { | ||
| 456 | token = hc32_to_cpu(ehci, hw->hw_token); | 463 | token = hc32_to_cpu(ehci, hw->hw_token); |
| 464 | hw->hw_token &= ~ACTIVE_BIT(ehci); | ||
| 457 | 465 | ||
| 458 | /* An unlink may leave an incomplete | 466 | /* An unlink may leave an incomplete |
| 459 | * async transaction in the TT buffer. | 467 | * async transaction in the TT buffer. |
| @@ -1170,7 +1178,7 @@ static void single_unlink_async(struct ehci_hcd *ehci, struct ehci_qh *qh) | |||
| 1170 | struct ehci_qh *prev; | 1178 | struct ehci_qh *prev; |
| 1171 | 1179 | ||
| 1172 | /* Add to the end of the list of QHs waiting for the next IAAD */ | 1180 | /* Add to the end of the list of QHs waiting for the next IAAD */ |
| 1173 | qh->qh_state = QH_STATE_UNLINK; | 1181 | qh->qh_state = QH_STATE_UNLINK_WAIT; |
| 1174 | if (ehci->async_unlink) | 1182 | if (ehci->async_unlink) |
| 1175 | ehci->async_unlink_last->unlink_next = qh; | 1183 | ehci->async_unlink_last->unlink_next = qh; |
| 1176 | else | 1184 | else |
| @@ -1213,9 +1221,19 @@ static void start_iaa_cycle(struct ehci_hcd *ehci, bool nested) | |||
| 1213 | 1221 | ||
| 1214 | /* Do only the first waiting QH (nVidia bug?) */ | 1222 | /* Do only the first waiting QH (nVidia bug?) */ |
| 1215 | qh = ehci->async_unlink; | 1223 | qh = ehci->async_unlink; |
| 1216 | ehci->async_iaa = qh; | 1224 | |
| 1217 | ehci->async_unlink = qh->unlink_next; | 1225 | /* |
| 1218 | qh->unlink_next = NULL; | 1226 | * Intel (?) bug: The HC can write back the overlay region |
| 1227 | * even after the IAA interrupt occurs. In self-defense, | ||
| 1228 | * always go through two IAA cycles for each QH. | ||
| 1229 | */ | ||
| 1230 | if (qh->qh_state == QH_STATE_UNLINK_WAIT) { | ||
| 1231 | qh->qh_state = QH_STATE_UNLINK; | ||
| 1232 | } else { | ||
| 1233 | ehci->async_iaa = qh; | ||
| 1234 | ehci->async_unlink = qh->unlink_next; | ||
| 1235 | qh->unlink_next = NULL; | ||
| 1236 | } | ||
| 1219 | 1237 | ||
| 1220 | /* Make sure the unlinks are all visible to the hardware */ | 1238 | /* Make sure the unlinks are all visible to the hardware */ |
| 1221 | wmb(); | 1239 | wmb(); |
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 45b19e2c60ba..05e51432dd2f 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig | |||
| @@ -7,11 +7,6 @@ | |||
| 7 | config USB_MUSB_HDRC | 7 | config USB_MUSB_HDRC |
| 8 | tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' | 8 | tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' |
| 9 | depends on USB && USB_GADGET | 9 | depends on USB && USB_GADGET |
| 10 | select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN) | ||
| 11 | select NOP_USB_XCEIV if (SOC_TI81XX || SOC_AM33XX) | ||
| 12 | select TWL4030_USB if MACH_OMAP_3430SDP | ||
| 13 | select TWL6030_USB if MACH_OMAP_4430SDP || MACH_OMAP4_PANDA | ||
| 14 | select OMAP_CONTROL_USB if MACH_OMAP_4430SDP || MACH_OMAP4_PANDA | ||
| 15 | select USB_OTG_UTILS | 10 | select USB_OTG_UTILS |
| 16 | help | 11 | help |
| 17 | Say Y here if your system has a dual role high speed USB | 12 | Say Y here if your system has a dual role high speed USB |
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 60b41cc28da4..daec6e0f7e38 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c | |||
| @@ -1624,8 +1624,6 @@ EXPORT_SYMBOL_GPL(musb_dma_completion); | |||
| 1624 | 1624 | ||
| 1625 | /*-------------------------------------------------------------------------*/ | 1625 | /*-------------------------------------------------------------------------*/ |
| 1626 | 1626 | ||
| 1627 | #ifdef CONFIG_SYSFS | ||
| 1628 | |||
| 1629 | static ssize_t | 1627 | static ssize_t |
| 1630 | musb_mode_show(struct device *dev, struct device_attribute *attr, char *buf) | 1628 | musb_mode_show(struct device *dev, struct device_attribute *attr, char *buf) |
| 1631 | { | 1629 | { |
| @@ -1742,8 +1740,6 @@ static const struct attribute_group musb_attr_group = { | |||
| 1742 | .attrs = musb_attributes, | 1740 | .attrs = musb_attributes, |
| 1743 | }; | 1741 | }; |
| 1744 | 1742 | ||
| 1745 | #endif /* sysfs */ | ||
| 1746 | |||
| 1747 | /* Only used to provide driver mode change events */ | 1743 | /* Only used to provide driver mode change events */ |
| 1748 | static void musb_irq_work(struct work_struct *data) | 1744 | static void musb_irq_work(struct work_struct *data) |
| 1749 | { | 1745 | { |
| @@ -1968,11 +1964,9 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl) | |||
| 1968 | if (status < 0) | 1964 | if (status < 0) |
| 1969 | goto fail4; | 1965 | goto fail4; |
| 1970 | 1966 | ||
| 1971 | #ifdef CONFIG_SYSFS | ||
| 1972 | status = sysfs_create_group(&musb->controller->kobj, &musb_attr_group); | 1967 | status = sysfs_create_group(&musb->controller->kobj, &musb_attr_group); |
| 1973 | if (status) | 1968 | if (status) |
| 1974 | goto fail5; | 1969 | goto fail5; |
| 1975 | #endif | ||
| 1976 | 1970 | ||
| 1977 | pm_runtime_put(musb->controller); | 1971 | pm_runtime_put(musb->controller); |
| 1978 | 1972 | ||
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 1762354fe793..1a42a458f2c4 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c | |||
| @@ -51,7 +51,7 @@ struct omap2430_glue { | |||
| 51 | }; | 51 | }; |
| 52 | #define glue_to_musb(g) platform_get_drvdata(g->musb) | 52 | #define glue_to_musb(g) platform_get_drvdata(g->musb) |
| 53 | 53 | ||
| 54 | struct omap2430_glue *_glue; | 54 | static struct omap2430_glue *_glue; |
| 55 | 55 | ||
| 56 | static struct timer_list musb_idle_timer; | 56 | static struct timer_list musb_idle_timer; |
| 57 | 57 | ||
| @@ -237,9 +237,13 @@ void omap_musb_mailbox(enum omap_musb_vbus_id_status status) | |||
| 237 | { | 237 | { |
| 238 | struct omap2430_glue *glue = _glue; | 238 | struct omap2430_glue *glue = _glue; |
| 239 | 239 | ||
| 240 | if (glue && glue_to_musb(glue)) { | 240 | if (!glue) { |
| 241 | glue->status = status; | 241 | pr_err("%s: musb core is not yet initialized\n", __func__); |
| 242 | } else { | 242 | return; |
| 243 | } | ||
| 244 | glue->status = status; | ||
| 245 | |||
| 246 | if (!glue_to_musb(glue)) { | ||
| 243 | pr_err("%s: musb core is not yet ready\n", __func__); | 247 | pr_err("%s: musb core is not yet ready\n", __func__); |
| 244 | return; | 248 | return; |
| 245 | } | 249 | } |
diff --git a/drivers/usb/otg/otg.c b/drivers/usb/otg/otg.c index e1814397ca3a..2bd03d261a50 100644 --- a/drivers/usb/otg/otg.c +++ b/drivers/usb/otg/otg.c | |||
| @@ -130,7 +130,7 @@ struct usb_phy *usb_get_phy(enum usb_phy_type type) | |||
| 130 | spin_lock_irqsave(&phy_lock, flags); | 130 | spin_lock_irqsave(&phy_lock, flags); |
| 131 | 131 | ||
| 132 | phy = __usb_find_phy(&phy_list, type); | 132 | phy = __usb_find_phy(&phy_list, type); |
| 133 | if (IS_ERR(phy)) { | 133 | if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { |
| 134 | pr_err("unable to find transceiver of type %s\n", | 134 | pr_err("unable to find transceiver of type %s\n", |
| 135 | usb_phy_type_string(type)); | 135 | usb_phy_type_string(type)); |
| 136 | goto err0; | 136 | goto err0; |
| @@ -228,7 +228,7 @@ struct usb_phy *usb_get_phy_dev(struct device *dev, u8 index) | |||
| 228 | spin_lock_irqsave(&phy_lock, flags); | 228 | spin_lock_irqsave(&phy_lock, flags); |
| 229 | 229 | ||
| 230 | phy = __usb_find_phy_dev(dev, &phy_bind_list, index); | 230 | phy = __usb_find_phy_dev(dev, &phy_bind_list, index); |
| 231 | if (IS_ERR(phy)) { | 231 | if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { |
| 232 | pr_err("unable to find transceiver\n"); | 232 | pr_err("unable to find transceiver\n"); |
| 233 | goto err0; | 233 | goto err0; |
| 234 | } | 234 | } |
| @@ -301,8 +301,12 @@ EXPORT_SYMBOL(devm_usb_put_phy); | |||
| 301 | */ | 301 | */ |
| 302 | void usb_put_phy(struct usb_phy *x) | 302 | void usb_put_phy(struct usb_phy *x) |
| 303 | { | 303 | { |
| 304 | if (x) | 304 | if (x) { |
| 305 | struct module *owner = x->dev->driver->owner; | ||
| 306 | |||
| 305 | put_device(x->dev); | 307 | put_device(x->dev); |
| 308 | module_put(owner); | ||
| 309 | } | ||
| 306 | } | 310 | } |
| 307 | EXPORT_SYMBOL(usb_put_phy); | 311 | EXPORT_SYMBOL(usb_put_phy); |
| 308 | 312 | ||
diff --git a/drivers/usb/phy/omap-control-usb.c b/drivers/usb/phy/omap-control-usb.c index 5323b71c3521..1419ceda9759 100644 --- a/drivers/usb/phy/omap-control-usb.c +++ b/drivers/usb/phy/omap-control-usb.c | |||
| @@ -219,32 +219,26 @@ static int omap_control_usb_probe(struct platform_device *pdev) | |||
| 219 | 219 | ||
| 220 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, | 220 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, |
| 221 | "control_dev_conf"); | 221 | "control_dev_conf"); |
| 222 | control_usb->dev_conf = devm_request_and_ioremap(&pdev->dev, res); | 222 | control_usb->dev_conf = devm_ioremap_resource(&pdev->dev, res); |
| 223 | if (!control_usb->dev_conf) { | 223 | if (IS_ERR(control_usb->dev_conf)) |
| 224 | dev_err(&pdev->dev, "Failed to obtain io memory\n"); | 224 | return PTR_ERR(control_usb->dev_conf); |
| 225 | return -EADDRNOTAVAIL; | ||
| 226 | } | ||
| 227 | 225 | ||
| 228 | if (control_usb->type == OMAP_CTRL_DEV_TYPE1) { | 226 | if (control_usb->type == OMAP_CTRL_DEV_TYPE1) { |
| 229 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, | 227 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, |
| 230 | "otghs_control"); | 228 | "otghs_control"); |
| 231 | control_usb->otghs_control = devm_request_and_ioremap( | 229 | control_usb->otghs_control = devm_ioremap_resource( |
| 232 | &pdev->dev, res); | 230 | &pdev->dev, res); |
| 233 | if (!control_usb->otghs_control) { | 231 | if (IS_ERR(control_usb->otghs_control)) |
| 234 | dev_err(&pdev->dev, "Failed to obtain io memory\n"); | 232 | return PTR_ERR(control_usb->otghs_control); |
| 235 | return -EADDRNOTAVAIL; | ||
| 236 | } | ||
| 237 | } | 233 | } |
| 238 | 234 | ||
| 239 | if (control_usb->type == OMAP_CTRL_DEV_TYPE2) { | 235 | if (control_usb->type == OMAP_CTRL_DEV_TYPE2) { |
| 240 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, | 236 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, |
| 241 | "phy_power_usb"); | 237 | "phy_power_usb"); |
| 242 | control_usb->phy_power = devm_request_and_ioremap( | 238 | control_usb->phy_power = devm_ioremap_resource( |
| 243 | &pdev->dev, res); | 239 | &pdev->dev, res); |
| 244 | if (!control_usb->phy_power) { | 240 | if (IS_ERR(control_usb->phy_power)) |
| 245 | dev_dbg(&pdev->dev, "Failed to obtain io memory\n"); | 241 | return PTR_ERR(control_usb->phy_power); |
| 246 | return -EADDRNOTAVAIL; | ||
| 247 | } | ||
| 248 | 242 | ||
| 249 | control_usb->sys_clk = devm_clk_get(control_usb->dev, | 243 | control_usb->sys_clk = devm_clk_get(control_usb->dev, |
| 250 | "sys_clkin"); | 244 | "sys_clkin"); |
diff --git a/drivers/usb/phy/omap-usb3.c b/drivers/usb/phy/omap-usb3.c index fadc0c2b65bb..a6e60b1e102e 100644 --- a/drivers/usb/phy/omap-usb3.c +++ b/drivers/usb/phy/omap-usb3.c | |||
| @@ -212,11 +212,9 @@ static int omap_usb3_probe(struct platform_device *pdev) | |||
| 212 | } | 212 | } |
| 213 | 213 | ||
| 214 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pll_ctrl"); | 214 | res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pll_ctrl"); |
| 215 | phy->pll_ctrl_base = devm_request_and_ioremap(&pdev->dev, res); | 215 | phy->pll_ctrl_base = devm_ioremap_resource(&pdev->dev, res); |
| 216 | if (!phy->pll_ctrl_base) { | 216 | if (IS_ERR(phy->pll_ctrl_base)) |
| 217 | dev_err(&pdev->dev, "ioremap of pll_ctrl failed\n"); | 217 | return PTR_ERR(phy->pll_ctrl_base); |
| 218 | return -ENOMEM; | ||
| 219 | } | ||
| 220 | 218 | ||
| 221 | phy->dev = &pdev->dev; | 219 | phy->dev = &pdev->dev; |
| 222 | 220 | ||
diff --git a/drivers/usb/phy/samsung-usbphy.c b/drivers/usb/phy/samsung-usbphy.c index 6ea553733832..967101ec15fd 100644 --- a/drivers/usb/phy/samsung-usbphy.c +++ b/drivers/usb/phy/samsung-usbphy.c | |||
| @@ -787,11 +787,9 @@ static int samsung_usbphy_probe(struct platform_device *pdev) | |||
| 787 | return -ENODEV; | 787 | return -ENODEV; |
| 788 | } | 788 | } |
| 789 | 789 | ||
| 790 | phy_base = devm_request_and_ioremap(dev, phy_mem); | 790 | phy_base = devm_ioremap_resource(dev, phy_mem); |
| 791 | if (!phy_base) { | 791 | if (IS_ERR(phy_base)) |
| 792 | dev_err(dev, "%s: register mapping failed\n", __func__); | 792 | return PTR_ERR(phy_base); |
| 793 | return -ENXIO; | ||
| 794 | } | ||
| 795 | 793 | ||
| 796 | sphy = devm_kzalloc(dev, sizeof(*sphy), GFP_KERNEL); | 794 | sphy = devm_kzalloc(dev, sizeof(*sphy), GFP_KERNEL); |
| 797 | if (!sphy) | 795 | if (!sphy) |
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index edc0f0dcad83..4747d1c328ff 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c | |||
| @@ -85,6 +85,7 @@ static const struct usb_device_id id_table[] = { | |||
| 85 | { USB_DEVICE(0x10C4, 0x813F) }, /* Tams Master Easy Control */ | 85 | { USB_DEVICE(0x10C4, 0x813F) }, /* Tams Master Easy Control */ |
| 86 | { USB_DEVICE(0x10C4, 0x814A) }, /* West Mountain Radio RIGblaster P&P */ | 86 | { USB_DEVICE(0x10C4, 0x814A) }, /* West Mountain Radio RIGblaster P&P */ |
| 87 | { USB_DEVICE(0x10C4, 0x814B) }, /* West Mountain Radio RIGtalk */ | 87 | { USB_DEVICE(0x10C4, 0x814B) }, /* West Mountain Radio RIGtalk */ |
| 88 | { USB_DEVICE(0x2405, 0x0003) }, /* West Mountain Radio RIGblaster Advantage */ | ||
| 88 | { USB_DEVICE(0x10C4, 0x8156) }, /* B&G H3000 link cable */ | 89 | { USB_DEVICE(0x10C4, 0x8156) }, /* B&G H3000 link cable */ |
| 89 | { USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */ | 90 | { USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */ |
| 90 | { USB_DEVICE(0x10C4, 0x815F) }, /* Timewave HamLinkUSB */ | 91 | { USB_DEVICE(0x10C4, 0x815F) }, /* Timewave HamLinkUSB */ |
| @@ -150,6 +151,25 @@ static const struct usb_device_id id_table[] = { | |||
| 150 | { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */ | 151 | { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */ |
| 151 | { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */ | 152 | { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */ |
| 152 | { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */ | 153 | { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */ |
| 154 | { USB_DEVICE(0x1FB9, 0x0100) }, /* Lake Shore Model 121 Current Source */ | ||
| 155 | { USB_DEVICE(0x1FB9, 0x0200) }, /* Lake Shore Model 218A Temperature Monitor */ | ||
| 156 | { USB_DEVICE(0x1FB9, 0x0201) }, /* Lake Shore Model 219 Temperature Monitor */ | ||
| 157 | { USB_DEVICE(0x1FB9, 0x0202) }, /* Lake Shore Model 233 Temperature Transmitter */ | ||
| 158 | { USB_DEVICE(0x1FB9, 0x0203) }, /* Lake Shore Model 235 Temperature Transmitter */ | ||
| 159 | { USB_DEVICE(0x1FB9, 0x0300) }, /* Lake Shore Model 335 Temperature Controller */ | ||
| 160 | { USB_DEVICE(0x1FB9, 0x0301) }, /* Lake Shore Model 336 Temperature Controller */ | ||
| 161 | { USB_DEVICE(0x1FB9, 0x0302) }, /* Lake Shore Model 350 Temperature Controller */ | ||
| 162 | { USB_DEVICE(0x1FB9, 0x0303) }, /* Lake Shore Model 371 AC Bridge */ | ||
| 163 | { USB_DEVICE(0x1FB9, 0x0400) }, /* Lake Shore Model 411 Handheld Gaussmeter */ | ||
| 164 | { USB_DEVICE(0x1FB9, 0x0401) }, /* Lake Shore Model 425 Gaussmeter */ | ||
| 165 | { USB_DEVICE(0x1FB9, 0x0402) }, /* Lake Shore Model 455A Gaussmeter */ | ||
| 166 | { USB_DEVICE(0x1FB9, 0x0403) }, /* Lake Shore Model 475A Gaussmeter */ | ||
| 167 | { USB_DEVICE(0x1FB9, 0x0404) }, /* Lake Shore Model 465 Three Axis Gaussmeter */ | ||
| 168 | { USB_DEVICE(0x1FB9, 0x0600) }, /* Lake Shore Model 625A Superconducting MPS */ | ||
| 169 | { USB_DEVICE(0x1FB9, 0x0601) }, /* Lake Shore Model 642A Magnet Power Supply */ | ||
| 170 | { USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power Supply */ | ||
| 171 | { USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM Controller */ | ||
| 172 | { USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix */ | ||
| 153 | { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */ | 173 | { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */ |
| 154 | { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */ | 174 | { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */ |
| 155 | { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */ | 175 | { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */ |
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index f7d339d8187b..558adfc05007 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c | |||
| @@ -341,6 +341,8 @@ static void option_instat_callback(struct urb *urb); | |||
| 341 | #define CINTERION_PRODUCT_EU3_E 0x0051 | 341 | #define CINTERION_PRODUCT_EU3_E 0x0051 |
| 342 | #define CINTERION_PRODUCT_EU3_P 0x0052 | 342 | #define CINTERION_PRODUCT_EU3_P 0x0052 |
| 343 | #define CINTERION_PRODUCT_PH8 0x0053 | 343 | #define CINTERION_PRODUCT_PH8 0x0053 |
| 344 | #define CINTERION_PRODUCT_AH6 0x0055 | ||
| 345 | #define CINTERION_PRODUCT_PLS8 0x0060 | ||
| 344 | 346 | ||
| 345 | /* Olivetti products */ | 347 | /* Olivetti products */ |
| 346 | #define OLIVETTI_VENDOR_ID 0x0b3c | 348 | #define OLIVETTI_VENDOR_ID 0x0b3c |
| @@ -579,6 +581,7 @@ static const struct usb_device_id option_ids[] = { | |||
| 579 | { USB_DEVICE(QUANTA_VENDOR_ID, 0xea42), | 581 | { USB_DEVICE(QUANTA_VENDOR_ID, 0xea42), |
| 580 | .driver_info = (kernel_ulong_t)&net_intf4_blacklist }, | 582 | .driver_info = (kernel_ulong_t)&net_intf4_blacklist }, |
| 581 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c05, USB_CLASS_COMM, 0x02, 0xff) }, | 583 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c05, USB_CLASS_COMM, 0x02, 0xff) }, |
| 584 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c1f, USB_CLASS_COMM, 0x02, 0xff) }, | ||
| 582 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c23, USB_CLASS_COMM, 0x02, 0xff) }, | 585 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c23, USB_CLASS_COMM, 0x02, 0xff) }, |
| 583 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E173, 0xff, 0xff, 0xff), | 586 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E173, 0xff, 0xff, 0xff), |
| 584 | .driver_info = (kernel_ulong_t) &net_intf1_blacklist }, | 587 | .driver_info = (kernel_ulong_t) &net_intf1_blacklist }, |
| @@ -1260,6 +1263,8 @@ static const struct usb_device_id option_ids[] = { | |||
| 1260 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_E) }, | 1263 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_E) }, |
| 1261 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_P) }, | 1264 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_P) }, |
| 1262 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_PH8) }, | 1265 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_PH8) }, |
| 1266 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_AH6) }, | ||
| 1267 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_PLS8) }, | ||
| 1263 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDM) }, | 1268 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDM) }, |
| 1264 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDMNET) }, | 1269 | { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDMNET) }, |
| 1265 | { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC25_MDM) }, | 1270 | { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC25_MDM) }, |
diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c index 9b1b96f2d095..31f81c3c15eb 100644 --- a/drivers/usb/serial/qcaux.c +++ b/drivers/usb/serial/qcaux.c | |||
| @@ -69,6 +69,7 @@ static struct usb_device_id id_table[] = { | |||
| 69 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfd, 0xff) }, /* NMEA */ | 69 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfd, 0xff) }, /* NMEA */ |
| 70 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfe, 0xff) }, /* WMC */ | 70 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfe, 0xff) }, /* WMC */ |
| 71 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xff, 0xff) }, /* DIAG */ | 71 | { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xff, 0xff) }, /* DIAG */ |
| 72 | { USB_DEVICE_AND_INTERFACE_INFO(0x1fac, 0x0151, 0xff, 0xff, 0xff) }, | ||
| 72 | { }, | 73 | { }, |
| 73 | }; | 74 | }; |
| 74 | MODULE_DEVICE_TABLE(usb, id_table); | 75 | MODULE_DEVICE_TABLE(usb, id_table); |
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 24662547dc5b..59b32b782126 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c | |||
| @@ -197,12 +197,15 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) | |||
| 197 | 197 | ||
| 198 | if (is_gobi1k) { | 198 | if (is_gobi1k) { |
| 199 | /* Gobi 1K USB layout: | 199 | /* Gobi 1K USB layout: |
| 200 | * 0: serial port (doesn't respond) | 200 | * 0: DM/DIAG (use libqcdm from ModemManager for communication) |
| 201 | * 1: serial port (doesn't respond) | 201 | * 1: serial port (doesn't respond) |
| 202 | * 2: AT-capable modem port | 202 | * 2: AT-capable modem port |
| 203 | * 3: QMI/net | 203 | * 3: QMI/net |
| 204 | */ | 204 | */ |
| 205 | if (ifnum == 2) | 205 | if (ifnum == 0) { |
| 206 | dev_dbg(dev, "Gobi 1K DM/DIAG interface found\n"); | ||
| 207 | altsetting = 1; | ||
| 208 | } else if (ifnum == 2) | ||
| 206 | dev_dbg(dev, "Modem port found\n"); | 209 | dev_dbg(dev, "Modem port found\n"); |
| 207 | else | 210 | else |
| 208 | altsetting = -1; | 211 | altsetting = -1; |
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index 00e6c9bac8a3..d643a4d4d770 100644 --- a/drivers/usb/serial/quatech2.c +++ b/drivers/usb/serial/quatech2.c | |||
| @@ -661,7 +661,9 @@ void qt2_process_read_urb(struct urb *urb) | |||
| 661 | __func__); | 661 | __func__); |
| 662 | break; | 662 | break; |
| 663 | } | 663 | } |
| 664 | tty_flip_buffer_push(&port->port); | 664 | |
| 665 | if (port_priv->is_open) | ||
| 666 | tty_flip_buffer_push(&port->port); | ||
| 665 | 667 | ||
| 666 | newport = *(ch + 3); | 668 | newport = *(ch + 3); |
| 667 | 669 | ||
| @@ -704,7 +706,8 @@ void qt2_process_read_urb(struct urb *urb) | |||
| 704 | tty_insert_flip_string(&port->port, ch, 1); | 706 | tty_insert_flip_string(&port->port, ch, 1); |
| 705 | } | 707 | } |
| 706 | 708 | ||
| 707 | tty_flip_buffer_push(&port->port); | 709 | if (port_priv->is_open) |
| 710 | tty_flip_buffer_push(&port->port); | ||
| 708 | } | 711 | } |
| 709 | 712 | ||
| 710 | static void qt2_write_bulk_callback(struct urb *urb) | 713 | static void qt2_write_bulk_callback(struct urb *urb) |
diff --git a/drivers/usb/storage/initializers.c b/drivers/usb/storage/initializers.c index 7ab9046ae0ec..105d900150c1 100644 --- a/drivers/usb/storage/initializers.c +++ b/drivers/usb/storage/initializers.c | |||
| @@ -92,8 +92,8 @@ int usb_stor_ucr61s2b_init(struct us_data *us) | |||
| 92 | return 0; | 92 | return 0; |
| 93 | } | 93 | } |
| 94 | 94 | ||
| 95 | /* This places the HUAWEI usb dongles in multi-port mode */ | 95 | /* This places the HUAWEI E220 devices in multi-port mode */ |
| 96 | static int usb_stor_huawei_feature_init(struct us_data *us) | 96 | int usb_stor_huawei_e220_init(struct us_data *us) |
| 97 | { | 97 | { |
| 98 | int result; | 98 | int result; |
| 99 | 99 | ||
| @@ -104,75 +104,3 @@ static int usb_stor_huawei_feature_init(struct us_data *us) | |||
| 104 | US_DEBUGP("Huawei mode set result is %d\n", result); | 104 | US_DEBUGP("Huawei mode set result is %d\n", result); |
| 105 | return 0; | 105 | return 0; |
| 106 | } | 106 | } |
| 107 | |||
| 108 | /* | ||
| 109 | * It will send a scsi switch command called rewind' to huawei dongle. | ||
| 110 | * When the dongle receives this command at the first time, | ||
| 111 | * it will reboot immediately. After rebooted, it will ignore this command. | ||
| 112 | * So it is unnecessary to read its response. | ||
| 113 | */ | ||
| 114 | static int usb_stor_huawei_scsi_init(struct us_data *us) | ||
| 115 | { | ||
| 116 | int result = 0; | ||
| 117 | int act_len = 0; | ||
| 118 | struct bulk_cb_wrap *bcbw = (struct bulk_cb_wrap *) us->iobuf; | ||
| 119 | char rewind_cmd[] = {0x11, 0x06, 0x20, 0x00, 0x00, 0x01, 0x01, 0x00, | ||
| 120 | 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; | ||
| 121 | |||
| 122 | bcbw->Signature = cpu_to_le32(US_BULK_CB_SIGN); | ||
| 123 | bcbw->Tag = 0; | ||
| 124 | bcbw->DataTransferLength = 0; | ||
| 125 | bcbw->Flags = bcbw->Lun = 0; | ||
| 126 | bcbw->Length = sizeof(rewind_cmd); | ||
| 127 | memset(bcbw->CDB, 0, sizeof(bcbw->CDB)); | ||
| 128 | memcpy(bcbw->CDB, rewind_cmd, sizeof(rewind_cmd)); | ||
| 129 | |||
| 130 | result = usb_stor_bulk_transfer_buf(us, us->send_bulk_pipe, bcbw, | ||
| 131 | US_BULK_CB_WRAP_LEN, &act_len); | ||
| 132 | US_DEBUGP("transfer actual length=%d, result=%d\n", act_len, result); | ||
| 133 | return result; | ||
| 134 | } | ||
| 135 | |||
| 136 | /* | ||
| 137 | * It tries to find the supported Huawei USB dongles. | ||
| 138 | * In Huawei, they assign the following product IDs | ||
| 139 | * for all of their mobile broadband dongles, | ||
| 140 | * including the new dongles in the future. | ||
| 141 | * So if the product ID is not included in this list, | ||
| 142 | * it means it is not Huawei's mobile broadband dongles. | ||
| 143 | */ | ||
| 144 | static int usb_stor_huawei_dongles_pid(struct us_data *us) | ||
| 145 | { | ||
| 146 | struct usb_interface_descriptor *idesc; | ||
| 147 | int idProduct; | ||
| 148 | |||
| 149 | idesc = &us->pusb_intf->cur_altsetting->desc; | ||
| 150 | idProduct = le16_to_cpu(us->pusb_dev->descriptor.idProduct); | ||
| 151 | /* The first port is CDROM, | ||
| 152 | * means the dongle in the single port mode, | ||
| 153 | * and a switch command is required to be sent. */ | ||
| 154 | if (idesc && idesc->bInterfaceNumber == 0) { | ||
| 155 | if ((idProduct == 0x1001) | ||
| 156 | || (idProduct == 0x1003) | ||
| 157 | || (idProduct == 0x1004) | ||
| 158 | || (idProduct >= 0x1401 && idProduct <= 0x1500) | ||
| 159 | || (idProduct >= 0x1505 && idProduct <= 0x1600) | ||
| 160 | || (idProduct >= 0x1c02 && idProduct <= 0x2202)) { | ||
| 161 | return 1; | ||
| 162 | } | ||
| 163 | } | ||
| 164 | return 0; | ||
| 165 | } | ||
| 166 | |||
| 167 | int usb_stor_huawei_init(struct us_data *us) | ||
| 168 | { | ||
| 169 | int result = 0; | ||
| 170 | |||
| 171 | if (usb_stor_huawei_dongles_pid(us)) { | ||
| 172 | if (le16_to_cpu(us->pusb_dev->descriptor.idProduct) >= 0x1446) | ||
| 173 | result = usb_stor_huawei_scsi_init(us); | ||
| 174 | else | ||
| 175 | result = usb_stor_huawei_feature_init(us); | ||
| 176 | } | ||
| 177 | return result; | ||
| 178 | } | ||
diff --git a/drivers/usb/storage/initializers.h b/drivers/usb/storage/initializers.h index 5376d4fc76f0..529327fbb06b 100644 --- a/drivers/usb/storage/initializers.h +++ b/drivers/usb/storage/initializers.h | |||
| @@ -46,5 +46,5 @@ int usb_stor_euscsi_init(struct us_data *us); | |||
| 46 | * flash reader */ | 46 | * flash reader */ |
| 47 | int usb_stor_ucr61s2b_init(struct us_data *us); | 47 | int usb_stor_ucr61s2b_init(struct us_data *us); |
| 48 | 48 | ||
| 49 | /* This places the HUAWEI usb dongles in multi-port mode */ | 49 | /* This places the HUAWEI E220 devices in multi-port mode */ |
| 50 | int usb_stor_huawei_init(struct us_data *us); | 50 | int usb_stor_huawei_e220_init(struct us_data *us); |
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 72923b56bbf6..da04a074e790 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h | |||
| @@ -53,6 +53,14 @@ | |||
| 53 | * as opposed to devices that do something strangely or wrongly. | 53 | * as opposed to devices that do something strangely or wrongly. |
| 54 | */ | 54 | */ |
| 55 | 55 | ||
| 56 | /* In-kernel mode switching is deprecated. Do not add new devices to | ||
| 57 | * this list for the sole purpose of switching them to a different | ||
| 58 | * mode. Existing userspace solutions are superior. | ||
| 59 | * | ||
| 60 | * New mode switching devices should instead be added to the database | ||
| 61 | * maintained at http://www.draisberghof.de/usb_modeswitch/ | ||
| 62 | */ | ||
| 63 | |||
| 56 | #if !defined(CONFIG_USB_STORAGE_SDDR09) && \ | 64 | #if !defined(CONFIG_USB_STORAGE_SDDR09) && \ |
| 57 | !defined(CONFIG_USB_STORAGE_SDDR09_MODULE) | 65 | !defined(CONFIG_USB_STORAGE_SDDR09_MODULE) |
| 58 | #define NO_SDDR09 | 66 | #define NO_SDDR09 |
| @@ -1527,10 +1535,335 @@ UNUSUAL_DEV( 0x1210, 0x0003, 0x0100, 0x0100, | |||
| 1527 | /* Reported by fangxiaozhi <huananhu@huawei.com> | 1535 | /* Reported by fangxiaozhi <huananhu@huawei.com> |
| 1528 | * This brings the HUAWEI data card devices into multi-port mode | 1536 | * This brings the HUAWEI data card devices into multi-port mode |
| 1529 | */ | 1537 | */ |
| 1530 | UNUSUAL_VENDOR_INTF(0x12d1, 0x08, 0x06, 0x50, | 1538 | UNUSUAL_DEV( 0x12d1, 0x1001, 0x0000, 0x0000, |
| 1539 | "HUAWEI MOBILE", | ||
| 1540 | "Mass Storage", | ||
| 1541 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1542 | 0), | ||
| 1543 | UNUSUAL_DEV( 0x12d1, 0x1003, 0x0000, 0x0000, | ||
| 1544 | "HUAWEI MOBILE", | ||
| 1545 | "Mass Storage", | ||
| 1546 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1547 | 0), | ||
| 1548 | UNUSUAL_DEV( 0x12d1, 0x1004, 0x0000, 0x0000, | ||
| 1549 | "HUAWEI MOBILE", | ||
| 1550 | "Mass Storage", | ||
| 1551 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1552 | 0), | ||
| 1553 | UNUSUAL_DEV( 0x12d1, 0x1401, 0x0000, 0x0000, | ||
| 1554 | "HUAWEI MOBILE", | ||
| 1555 | "Mass Storage", | ||
| 1556 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1557 | 0), | ||
| 1558 | UNUSUAL_DEV( 0x12d1, 0x1402, 0x0000, 0x0000, | ||
| 1559 | "HUAWEI MOBILE", | ||
| 1560 | "Mass Storage", | ||
| 1561 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1562 | 0), | ||
| 1563 | UNUSUAL_DEV( 0x12d1, 0x1403, 0x0000, 0x0000, | ||
| 1564 | "HUAWEI MOBILE", | ||
| 1565 | "Mass Storage", | ||
| 1566 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1567 | 0), | ||
| 1568 | UNUSUAL_DEV( 0x12d1, 0x1404, 0x0000, 0x0000, | ||
| 1569 | "HUAWEI MOBILE", | ||
| 1570 | "Mass Storage", | ||
| 1571 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1572 | 0), | ||
| 1573 | UNUSUAL_DEV( 0x12d1, 0x1405, 0x0000, 0x0000, | ||
| 1574 | "HUAWEI MOBILE", | ||
| 1575 | "Mass Storage", | ||
| 1576 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1577 | 0), | ||
| 1578 | UNUSUAL_DEV( 0x12d1, 0x1406, 0x0000, 0x0000, | ||
| 1579 | "HUAWEI MOBILE", | ||
| 1580 | "Mass Storage", | ||
| 1581 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1582 | 0), | ||
| 1583 | UNUSUAL_DEV( 0x12d1, 0x1407, 0x0000, 0x0000, | ||
| 1584 | "HUAWEI MOBILE", | ||
| 1585 | "Mass Storage", | ||
| 1586 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1587 | 0), | ||
| 1588 | UNUSUAL_DEV( 0x12d1, 0x1408, 0x0000, 0x0000, | ||
| 1589 | "HUAWEI MOBILE", | ||
| 1590 | "Mass Storage", | ||
| 1591 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1592 | 0), | ||
| 1593 | UNUSUAL_DEV( 0x12d1, 0x1409, 0x0000, 0x0000, | ||
| 1594 | "HUAWEI MOBILE", | ||
| 1595 | "Mass Storage", | ||
| 1596 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1597 | 0), | ||
| 1598 | UNUSUAL_DEV( 0x12d1, 0x140A, 0x0000, 0x0000, | ||
| 1599 | "HUAWEI MOBILE", | ||
| 1600 | "Mass Storage", | ||
| 1601 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1602 | 0), | ||
| 1603 | UNUSUAL_DEV( 0x12d1, 0x140B, 0x0000, 0x0000, | ||
| 1604 | "HUAWEI MOBILE", | ||
| 1605 | "Mass Storage", | ||
| 1606 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1607 | 0), | ||
| 1608 | UNUSUAL_DEV( 0x12d1, 0x140C, 0x0000, 0x0000, | ||
| 1609 | "HUAWEI MOBILE", | ||
| 1610 | "Mass Storage", | ||
| 1611 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1612 | 0), | ||
| 1613 | UNUSUAL_DEV( 0x12d1, 0x140D, 0x0000, 0x0000, | ||
| 1614 | "HUAWEI MOBILE", | ||
| 1615 | "Mass Storage", | ||
| 1616 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1617 | 0), | ||
| 1618 | UNUSUAL_DEV( 0x12d1, 0x140E, 0x0000, 0x0000, | ||
| 1619 | "HUAWEI MOBILE", | ||
| 1620 | "Mass Storage", | ||
| 1621 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1622 | 0), | ||
| 1623 | UNUSUAL_DEV( 0x12d1, 0x140F, 0x0000, 0x0000, | ||
| 1624 | "HUAWEI MOBILE", | ||
| 1625 | "Mass Storage", | ||
| 1626 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1627 | 0), | ||
| 1628 | UNUSUAL_DEV( 0x12d1, 0x1410, 0x0000, 0x0000, | ||
| 1629 | "HUAWEI MOBILE", | ||
| 1630 | "Mass Storage", | ||
| 1631 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1632 | 0), | ||
| 1633 | UNUSUAL_DEV( 0x12d1, 0x1411, 0x0000, 0x0000, | ||
| 1634 | "HUAWEI MOBILE", | ||
| 1635 | "Mass Storage", | ||
| 1636 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1637 | 0), | ||
| 1638 | UNUSUAL_DEV( 0x12d1, 0x1412, 0x0000, 0x0000, | ||
| 1639 | "HUAWEI MOBILE", | ||
| 1640 | "Mass Storage", | ||
| 1641 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1642 | 0), | ||
| 1643 | UNUSUAL_DEV( 0x12d1, 0x1413, 0x0000, 0x0000, | ||
| 1644 | "HUAWEI MOBILE", | ||
| 1645 | "Mass Storage", | ||
| 1646 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1647 | 0), | ||
| 1648 | UNUSUAL_DEV( 0x12d1, 0x1414, 0x0000, 0x0000, | ||
| 1649 | "HUAWEI MOBILE", | ||
| 1650 | "Mass Storage", | ||
| 1651 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1652 | 0), | ||
| 1653 | UNUSUAL_DEV( 0x12d1, 0x1415, 0x0000, 0x0000, | ||
| 1654 | "HUAWEI MOBILE", | ||
| 1655 | "Mass Storage", | ||
| 1656 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1657 | 0), | ||
| 1658 | UNUSUAL_DEV( 0x12d1, 0x1416, 0x0000, 0x0000, | ||
| 1659 | "HUAWEI MOBILE", | ||
| 1660 | "Mass Storage", | ||
| 1661 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1662 | 0), | ||
| 1663 | UNUSUAL_DEV( 0x12d1, 0x1417, 0x0000, 0x0000, | ||
| 1664 | "HUAWEI MOBILE", | ||
| 1665 | "Mass Storage", | ||
| 1666 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1667 | 0), | ||
| 1668 | UNUSUAL_DEV( 0x12d1, 0x1418, 0x0000, 0x0000, | ||
| 1669 | "HUAWEI MOBILE", | ||
| 1670 | "Mass Storage", | ||
| 1671 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1672 | 0), | ||
| 1673 | UNUSUAL_DEV( 0x12d1, 0x1419, 0x0000, 0x0000, | ||
| 1674 | "HUAWEI MOBILE", | ||
| 1675 | "Mass Storage", | ||
| 1676 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1677 | 0), | ||
| 1678 | UNUSUAL_DEV( 0x12d1, 0x141A, 0x0000, 0x0000, | ||
| 1679 | "HUAWEI MOBILE", | ||
| 1680 | "Mass Storage", | ||
| 1681 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1682 | 0), | ||
| 1683 | UNUSUAL_DEV( 0x12d1, 0x141B, 0x0000, 0x0000, | ||
| 1684 | "HUAWEI MOBILE", | ||
| 1685 | "Mass Storage", | ||
| 1686 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1687 | 0), | ||
| 1688 | UNUSUAL_DEV( 0x12d1, 0x141C, 0x0000, 0x0000, | ||
| 1689 | "HUAWEI MOBILE", | ||
| 1690 | "Mass Storage", | ||
| 1691 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1692 | 0), | ||
| 1693 | UNUSUAL_DEV( 0x12d1, 0x141D, 0x0000, 0x0000, | ||
| 1694 | "HUAWEI MOBILE", | ||
| 1695 | "Mass Storage", | ||
| 1696 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1697 | 0), | ||
| 1698 | UNUSUAL_DEV( 0x12d1, 0x141E, 0x0000, 0x0000, | ||
| 1699 | "HUAWEI MOBILE", | ||
| 1700 | "Mass Storage", | ||
| 1701 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1702 | 0), | ||
| 1703 | UNUSUAL_DEV( 0x12d1, 0x141F, 0x0000, 0x0000, | ||
| 1704 | "HUAWEI MOBILE", | ||
| 1705 | "Mass Storage", | ||
| 1706 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1707 | 0), | ||
| 1708 | UNUSUAL_DEV( 0x12d1, 0x1420, 0x0000, 0x0000, | ||
| 1709 | "HUAWEI MOBILE", | ||
| 1710 | "Mass Storage", | ||
| 1711 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1712 | 0), | ||
| 1713 | UNUSUAL_DEV( 0x12d1, 0x1421, 0x0000, 0x0000, | ||
| 1714 | "HUAWEI MOBILE", | ||
| 1715 | "Mass Storage", | ||
| 1716 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1717 | 0), | ||
| 1718 | UNUSUAL_DEV( 0x12d1, 0x1422, 0x0000, 0x0000, | ||
| 1719 | "HUAWEI MOBILE", | ||
| 1720 | "Mass Storage", | ||
| 1721 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1722 | 0), | ||
| 1723 | UNUSUAL_DEV( 0x12d1, 0x1423, 0x0000, 0x0000, | ||
| 1724 | "HUAWEI MOBILE", | ||
| 1725 | "Mass Storage", | ||
| 1726 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1727 | 0), | ||
| 1728 | UNUSUAL_DEV( 0x12d1, 0x1424, 0x0000, 0x0000, | ||
| 1729 | "HUAWEI MOBILE", | ||
| 1730 | "Mass Storage", | ||
| 1731 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1732 | 0), | ||
| 1733 | UNUSUAL_DEV( 0x12d1, 0x1425, 0x0000, 0x0000, | ||
| 1734 | "HUAWEI MOBILE", | ||
| 1735 | "Mass Storage", | ||
| 1736 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1737 | 0), | ||
| 1738 | UNUSUAL_DEV( 0x12d1, 0x1426, 0x0000, 0x0000, | ||
| 1739 | "HUAWEI MOBILE", | ||
| 1740 | "Mass Storage", | ||
| 1741 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1742 | 0), | ||
| 1743 | UNUSUAL_DEV( 0x12d1, 0x1427, 0x0000, 0x0000, | ||
| 1744 | "HUAWEI MOBILE", | ||
| 1745 | "Mass Storage", | ||
| 1746 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1747 | 0), | ||
| 1748 | UNUSUAL_DEV( 0x12d1, 0x1428, 0x0000, 0x0000, | ||
| 1749 | "HUAWEI MOBILE", | ||
| 1750 | "Mass Storage", | ||
| 1751 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1752 | 0), | ||
| 1753 | UNUSUAL_DEV( 0x12d1, 0x1429, 0x0000, 0x0000, | ||
| 1754 | "HUAWEI MOBILE", | ||
| 1755 | "Mass Storage", | ||
| 1756 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1757 | 0), | ||
| 1758 | UNUSUAL_DEV( 0x12d1, 0x142A, 0x0000, 0x0000, | ||
| 1759 | "HUAWEI MOBILE", | ||
| 1760 | "Mass Storage", | ||
| 1761 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1762 | 0), | ||
| 1763 | UNUSUAL_DEV( 0x12d1, 0x142B, 0x0000, 0x0000, | ||
| 1764 | "HUAWEI MOBILE", | ||
| 1765 | "Mass Storage", | ||
| 1766 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1767 | 0), | ||
| 1768 | UNUSUAL_DEV( 0x12d1, 0x142C, 0x0000, 0x0000, | ||
| 1769 | "HUAWEI MOBILE", | ||
| 1770 | "Mass Storage", | ||
| 1771 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1772 | 0), | ||
| 1773 | UNUSUAL_DEV( 0x12d1, 0x142D, 0x0000, 0x0000, | ||
| 1774 | "HUAWEI MOBILE", | ||
| 1775 | "Mass Storage", | ||
| 1776 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1777 | 0), | ||
| 1778 | UNUSUAL_DEV( 0x12d1, 0x142E, 0x0000, 0x0000, | ||
| 1779 | "HUAWEI MOBILE", | ||
| 1780 | "Mass Storage", | ||
| 1781 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1782 | 0), | ||
| 1783 | UNUSUAL_DEV( 0x12d1, 0x142F, 0x0000, 0x0000, | ||
| 1784 | "HUAWEI MOBILE", | ||
| 1785 | "Mass Storage", | ||
| 1786 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1787 | 0), | ||
| 1788 | UNUSUAL_DEV( 0x12d1, 0x1430, 0x0000, 0x0000, | ||
| 1789 | "HUAWEI MOBILE", | ||
| 1790 | "Mass Storage", | ||
| 1791 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1792 | 0), | ||
| 1793 | UNUSUAL_DEV( 0x12d1, 0x1431, 0x0000, 0x0000, | ||
| 1794 | "HUAWEI MOBILE", | ||
| 1795 | "Mass Storage", | ||
| 1796 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1797 | 0), | ||
| 1798 | UNUSUAL_DEV( 0x12d1, 0x1432, 0x0000, 0x0000, | ||
| 1799 | "HUAWEI MOBILE", | ||
| 1800 | "Mass Storage", | ||
| 1801 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1802 | 0), | ||
| 1803 | UNUSUAL_DEV( 0x12d1, 0x1433, 0x0000, 0x0000, | ||
| 1804 | "HUAWEI MOBILE", | ||
| 1805 | "Mass Storage", | ||
| 1806 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1807 | 0), | ||
| 1808 | UNUSUAL_DEV( 0x12d1, 0x1434, 0x0000, 0x0000, | ||
| 1809 | "HUAWEI MOBILE", | ||
| 1810 | "Mass Storage", | ||
| 1811 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1812 | 0), | ||
| 1813 | UNUSUAL_DEV( 0x12d1, 0x1435, 0x0000, 0x0000, | ||
| 1814 | "HUAWEI MOBILE", | ||
| 1815 | "Mass Storage", | ||
| 1816 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1817 | 0), | ||
| 1818 | UNUSUAL_DEV( 0x12d1, 0x1436, 0x0000, 0x0000, | ||
| 1819 | "HUAWEI MOBILE", | ||
| 1820 | "Mass Storage", | ||
| 1821 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1822 | 0), | ||
| 1823 | UNUSUAL_DEV( 0x12d1, 0x1437, 0x0000, 0x0000, | ||
| 1824 | "HUAWEI MOBILE", | ||
| 1825 | "Mass Storage", | ||
| 1826 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1827 | 0), | ||
| 1828 | UNUSUAL_DEV( 0x12d1, 0x1438, 0x0000, 0x0000, | ||
| 1829 | "HUAWEI MOBILE", | ||
| 1830 | "Mass Storage", | ||
| 1831 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1832 | 0), | ||
| 1833 | UNUSUAL_DEV( 0x12d1, 0x1439, 0x0000, 0x0000, | ||
| 1834 | "HUAWEI MOBILE", | ||
| 1835 | "Mass Storage", | ||
| 1836 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1837 | 0), | ||
| 1838 | UNUSUAL_DEV( 0x12d1, 0x143A, 0x0000, 0x0000, | ||
| 1839 | "HUAWEI MOBILE", | ||
| 1840 | "Mass Storage", | ||
| 1841 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1842 | 0), | ||
| 1843 | UNUSUAL_DEV( 0x12d1, 0x143B, 0x0000, 0x0000, | ||
| 1844 | "HUAWEI MOBILE", | ||
| 1845 | "Mass Storage", | ||
| 1846 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1847 | 0), | ||
| 1848 | UNUSUAL_DEV( 0x12d1, 0x143C, 0x0000, 0x0000, | ||
| 1849 | "HUAWEI MOBILE", | ||
| 1850 | "Mass Storage", | ||
| 1851 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1852 | 0), | ||
| 1853 | UNUSUAL_DEV( 0x12d1, 0x143D, 0x0000, 0x0000, | ||
| 1854 | "HUAWEI MOBILE", | ||
| 1855 | "Mass Storage", | ||
| 1856 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1857 | 0), | ||
| 1858 | UNUSUAL_DEV( 0x12d1, 0x143E, 0x0000, 0x0000, | ||
| 1859 | "HUAWEI MOBILE", | ||
| 1860 | "Mass Storage", | ||
| 1861 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, | ||
| 1862 | 0), | ||
| 1863 | UNUSUAL_DEV( 0x12d1, 0x143F, 0x0000, 0x0000, | ||
| 1531 | "HUAWEI MOBILE", | 1864 | "HUAWEI MOBILE", |
| 1532 | "Mass Storage", | 1865 | "Mass Storage", |
| 1533 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_init, | 1866 | USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_huawei_e220_init, |
| 1534 | 0), | 1867 | 0), |
| 1535 | 1868 | ||
| 1536 | /* Reported by Vilius Bilinkevicius <vilisas AT xxx DOT lt) */ | 1869 | /* Reported by Vilius Bilinkevicius <vilisas AT xxx DOT lt) */ |
diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c index ed4cad87fbcd..4a5f2cd3d3bf 100644 --- a/drivers/video/omap/lcd_ams_delta.c +++ b/drivers/video/omap/lcd_ams_delta.c | |||
| @@ -27,6 +27,7 @@ | |||
| 27 | #include <linux/lcd.h> | 27 | #include <linux/lcd.h> |
| 28 | #include <linux/gpio.h> | 28 | #include <linux/gpio.h> |
| 29 | 29 | ||
| 30 | #include <mach/hardware.h> | ||
| 30 | #include <mach/board-ams-delta.h> | 31 | #include <mach/board-ams-delta.h> |
| 31 | 32 | ||
| 32 | #include "omapfb.h" | 33 | #include "omapfb.h" |
diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c index 3aa62da89195..7fbe04bce0ed 100644 --- a/drivers/video/omap/lcd_osk.c +++ b/drivers/video/omap/lcd_osk.c | |||
| @@ -24,7 +24,10 @@ | |||
| 24 | #include <linux/platform_device.h> | 24 | #include <linux/platform_device.h> |
| 25 | 25 | ||
| 26 | #include <asm/gpio.h> | 26 | #include <asm/gpio.h> |
| 27 | |||
| 28 | #include <mach/hardware.h> | ||
| 27 | #include <mach/mux.h> | 29 | #include <mach/mux.h> |
| 30 | |||
| 28 | #include "omapfb.h" | 31 | #include "omapfb.h" |
| 29 | 32 | ||
| 30 | static int osk_panel_init(struct lcd_panel *panel, struct omapfb_device *fbdev) | 33 | static int osk_panel_init(struct lcd_panel *panel, struct omapfb_device *fbdev) |
diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c index 316df65163cf..f3278a6603ca 100644 --- a/drivers/xen/xen-acpi-processor.c +++ b/drivers/xen/xen-acpi-processor.c | |||
| @@ -500,16 +500,16 @@ static int __init xen_acpi_processor_init(void) | |||
| 500 | (void)acpi_processor_preregister_performance(acpi_perf_data); | 500 | (void)acpi_processor_preregister_performance(acpi_perf_data); |
| 501 | 501 | ||
| 502 | for_each_possible_cpu(i) { | 502 | for_each_possible_cpu(i) { |
| 503 | struct acpi_processor *pr; | ||
| 503 | struct acpi_processor_performance *perf; | 504 | struct acpi_processor_performance *perf; |
| 504 | 505 | ||
| 506 | pr = per_cpu(processors, i); | ||
| 505 | perf = per_cpu_ptr(acpi_perf_data, i); | 507 | perf = per_cpu_ptr(acpi_perf_data, i); |
| 506 | rc = acpi_processor_register_performance(perf, i); | 508 | pr->performance = perf; |
| 509 | rc = acpi_processor_get_performance_info(pr); | ||
| 507 | if (rc) | 510 | if (rc) |
| 508 | goto err_out; | 511 | goto err_out; |
| 509 | } | 512 | } |
| 510 | rc = acpi_processor_notify_smm(THIS_MODULE); | ||
| 511 | if (rc) | ||
| 512 | goto err_unregister; | ||
| 513 | 513 | ||
| 514 | for_each_possible_cpu(i) { | 514 | for_each_possible_cpu(i) { |
| 515 | struct acpi_processor *_pr; | 515 | struct acpi_processor *_pr; |
diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c index 37c1f825f513..b98cf0c35725 100644 --- a/drivers/xen/xen-pciback/pciback_ops.c +++ b/drivers/xen/xen-pciback/pciback_ops.c | |||
| @@ -113,7 +113,8 @@ void xen_pcibk_reset_device(struct pci_dev *dev) | |||
| 113 | if (dev->msi_enabled) | 113 | if (dev->msi_enabled) |
| 114 | pci_disable_msi(dev); | 114 | pci_disable_msi(dev); |
| 115 | #endif | 115 | #endif |
| 116 | pci_disable_device(dev); | 116 | if (pci_is_enabled(dev)) |
| 117 | pci_disable_device(dev); | ||
| 117 | 118 | ||
| 118 | pci_write_config_word(dev, PCI_COMMAND, 0); | 119 | pci_write_config_word(dev, PCI_COMMAND, 0); |
| 119 | 120 | ||
diff --git a/drivers/xen/xen-stub.c b/drivers/xen/xen-stub.c index d85e411cbf89..bbef194c5b01 100644 --- a/drivers/xen/xen-stub.c +++ b/drivers/xen/xen-stub.c | |||
| @@ -25,7 +25,6 @@ | |||
| 25 | #include <linux/export.h> | 25 | #include <linux/export.h> |
| 26 | #include <linux/types.h> | 26 | #include <linux/types.h> |
| 27 | #include <linux/acpi.h> | 27 | #include <linux/acpi.h> |
| 28 | #include <acpi/acpi_drivers.h> | ||
| 29 | #include <xen/acpi.h> | 28 | #include <xen/acpi.h> |
| 30 | 29 | ||
| 31 | #ifdef CONFIG_ACPI | 30 | #ifdef CONFIG_ACPI |
