352 files changed, 19142 insertions, 8853 deletions

diff --git a/drivers/acorn/block/mfmhd.c b/drivers/acorn/block/mfmhd.c
index 4b65f74d66b1..ce074f6f3369 100644
--- a/drivers/acorn/block/mfmhd.c
+++ b/drivers/acorn/block/mfmhd.c
@@ -129,19 +129,6 @@ static DEFINE_SPINLOCK(mfm_lock);
 #define MAJOR_NR        MFM_ACORN_MAJOR
 #define QUEUE (mfm_queue)
 #define CURRENT elv_next_request(mfm_queue)
-/*
- * This sort of stuff should be in a header file shared with ide.c, hd.c, xd.c etc
- */
-#ifndef HDIO_GETGEO
-#define HDIO_GETGEO 0x301
-struct hd_geometry {
-        unsigned char heads;
-        unsigned char sectors;
-        unsigned short cylinders;
-        unsigned long start;
-};
-#endif
-
 
 /*
  * Configuration section
@@ -1153,22 +1140,13 @@ static int mfm_initdrives(void)
  * The 'front' end of the mfm driver follows...
  */
 
-static int mfm_ioctl(struct inode *inode, struct file *file, u_int cmd, u_long arg)
+static int mfm_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct mfm_info *p = inode->i_bdev->bd_disk->private_data;
-        struct hd_geometry *geo = (struct hd_geometry *) arg;
-        if (cmd != HDIO_GETGEO)
-                return -EINVAL;
-        if (!arg)
-                return -EINVAL;
-        if (put_user (p->heads, &geo->heads))
-                return -EFAULT;
-        if (put_user (p->sectors, &geo->sectors))
-                return -EFAULT;
-        if (put_user (p->cylinders, &geo->cylinders))
-                return -EFAULT;
-        if (put_user (get_start_sect(inode->i_bdev), &geo->start))
-                return -EFAULT;
+        struct mfm_info *p = bdev->bd_disk->private_data;
+
+        geo->heads = p->heads;
+        geo->sectors = p->sectors;
+        geo->cylinders = p->cylinders;
         return 0;
 }
 
@@ -1219,7 +1197,7 @@ void xd_set_geometry(struct block_device *bdev, unsigned char secsptrack,
 static struct block_device_operations mfm_fops =
 {
         .owner          = THIS_MODULE,
-        .ioctl          = mfm_ioctl,
+        .getgeo         = mfm_getgeo,
 };
 
 /*
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index e3cd0b16031a..20c9a37643c7 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -204,11 +204,13 @@ acpi_os_map_memory(acpi_physical_address phys, acpi_size size,
 
         return AE_OK;
 }
+EXPORT_SYMBOL_GPL(acpi_os_map_memory);
 
 void acpi_os_unmap_memory(void __iomem * virt, acpi_size size)
 {
         iounmap(virt);
 }
+EXPORT_SYMBOL_GPL(acpi_os_unmap_memory);
 
 #ifdef ACPI_FUTURE_USAGE
 acpi_status
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index c57e20dcb0f8..074abc81ec3d 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -2126,8 +2126,7 @@ static void process_rsq(ns_dev *card)
 
    if (!ns_rsqe_valid(card->rsq.next))
       return;
-   while (ns_rsqe_valid(card->rsq.next))
-   {
+   do {
       dequeue_rx(card, card->rsq.next);
       ns_rsqe_init(card->rsq.next);
       previous = card->rsq.next;
@@ -2135,7 +2134,7 @@ static void process_rsq(ns_dev *card)
          card->rsq.next = card->rsq.base;
       else
          card->rsq.next++;
-   }
+   } while (ns_rsqe_valid(card->rsq.next));
    writel((((u32) previous) - ((u32) card->rsq.base)),
           card->membase + RSQH);
 }
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 21097a39a057..4a7bb7dfce85 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -92,34 +92,28 @@ static int DAC960_open(struct inode *inode, struct file *file)
         return 0;
 }
 
-static int DAC960_ioctl(struct inode *inode, struct file *file,
-                        unsigned int cmd, unsigned long arg)
+static int DAC960_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct gendisk *disk = inode->i_bdev->bd_disk;
+        struct gendisk *disk = bdev->bd_disk;
         DAC960_Controller_T *p = disk->queue->queuedata;
         int drive_nr = (long)disk->private_data;
-        struct hd_geometry g;
-        struct hd_geometry __user *loc = (struct hd_geometry __user *)arg;
-
-        if (cmd != HDIO_GETGEO || !loc)
-                return -EINVAL;
 
         if (p->FirmwareType == DAC960_V1_Controller) {
-                g.heads = p->V1.GeometryTranslationHeads;
-                g.sectors = p->V1.GeometryTranslationSectors;
-                g.cylinders = p->V1.LogicalDriveInformation[drive_nr].
-                        LogicalDriveSize / (g.heads * g.sectors);
+                geo->heads = p->V1.GeometryTranslationHeads;
+                geo->sectors = p->V1.GeometryTranslationSectors;
+                geo->cylinders = p->V1.LogicalDriveInformation[drive_nr].
+                        LogicalDriveSize / (geo->heads * geo->sectors);
         } else {
                 DAC960_V2_LogicalDeviceInfo_T *i =
                         p->V2.LogicalDeviceInformation[drive_nr];
                 switch (i->DriveGeometry) {
                 case DAC960_V2_Geometry_128_32:
-                        g.heads = 128;
-                        g.sectors = 32;
+                        geo->heads = 128;
+                        geo->sectors = 32;
                         break;
                 case DAC960_V2_Geometry_255_63:
-                        g.heads = 255;
-                        g.sectors = 63;
+                        geo->heads = 255;
+                        geo->sectors = 63;
                         break;
                 default:
                         DAC960_Error("Illegal Logical Device Geometry %d\n",
@@ -127,12 +121,11 @@ static int DAC960_ioctl(struct inode *inode, struct file *file,
                         return -EINVAL;
                 }
 
-                g.cylinders = i->ConfigurableDeviceSize / (g.heads * g.sectors);
+                geo->cylinders = i->ConfigurableDeviceSize /
+                        (geo->heads * geo->sectors);
         }
         
-        g.start = get_start_sect(inode->i_bdev);
-
-        return copy_to_user(loc, &g, sizeof g) ? -EFAULT : 0; 
+        return 0;
 }
 
 static int DAC960_media_changed(struct gendisk *disk)
@@ -157,7 +150,7 @@ static int DAC960_revalidate_disk(struct gendisk *disk)
 static struct block_device_operations DAC960_BlockDeviceOperations = {
         .owner                  = THIS_MODULE,
         .open                   = DAC960_open,
-        .ioctl                  = DAC960_ioctl,
+        .getgeo                 = DAC960_getgeo,
         .media_changed          = DAC960_media_changed,
         .revalidate_disk        = DAC960_revalidate_disk,
 };
@@ -3767,7 +3760,7 @@ static void DAC960_V1_ProcessCompletedCommand(DAC960_Command_T *Command)
               if (SenseKey == DAC960_SenseKey_VendorSpecific &&
                   AdditionalSenseCode == 0x80 &&
                   AdditionalSenseCodeQualifier <
-                  sizeof(DAC960_EventMessages) / sizeof(char *))
+                  ARRAY_SIZE(DAC960_EventMessages))
                 DAC960_Critical("Physical Device %d:%d %s\n", Controller,
                                 EventLogEntry->Channel,
                                 EventLogEntry->TargetID,
diff --git a/drivers/block/acsi.c b/drivers/block/acsi.c
index 5d2d649f7e8d..196c0ec9cd54 100644
--- a/drivers/block/acsi.c
+++ b/drivers/block/acsi.c
@@ -1079,6 +1079,19 @@ static void redo_acsi_request( void )
  *
  ***********************************************************************/
 
+static int acsi_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct acsi_info_struct *aip = bdev->bd_disk->private_data;
+
+        /*
+         * Just fake some geometry here, it's nonsense anyway
+         * To make it easy, use Adaptec's usual 64/32 mapping
+         */
+        geo->heads = 64;
+        geo->sectors = 32;
+        geo->cylinders = aip->size >> 11;
+        return 0;
+}
 
 static int acsi_ioctl( struct inode *inode, struct file *file,
                                            unsigned int cmd, unsigned long arg )
@@ -1086,18 +1099,6 @@ static int acsi_ioctl( struct inode *inode, struct file *file,
         struct gendisk *disk = inode->i_bdev->bd_disk;
         struct acsi_info_struct *aip = disk->private_data;
         switch (cmd) {
-          case HDIO_GETGEO:
-                /* HDIO_GETGEO is supported more for getting the partition's
-                 * start sector... */
-          { struct hd_geometry *geo = (struct hd_geometry *)arg;
-            /* just fake some geometry here, it's nonsense anyway; to make it
-                 * easy, use Adaptec's usual 64/32 mapping */
-            put_user( 64, &geo->heads );
-            put_user( 32, &geo->sectors );
-            put_user( aip->size >> 11, &geo->cylinders );
-                put_user(get_start_sect(inode->i_bdev), &geo->start);
-                return 0;
-          }
           case SCSI_IOCTL_GET_IDLUN:
                 /* SCSI compatible GET_IDLUN call to get target's ID and LUN number */
                 put_user( aip->target | (aip->lun << 8),
@@ -1592,6 +1593,7 @@ static struct block_device_operations acsi_fops = {
         .open           = acsi_open,
         .release        = acsi_release,
         .ioctl          = acsi_ioctl,
+        .getgeo         = acsi_getgeo,
         .media_changed  = acsi_media_change,
         .revalidate_disk= acsi_revalidate,
 };
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 0acbfff8ad28..3c679d30b698 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -131,7 +131,7 @@ static struct fd_drive_type drive_types[] = {
 { FD_DD_5,      "DD 5.25", 40, 2, 14716, 13630, 1, 40, 81, 6, 30, 2},
 { FD_NODRIVE, "No Drive", 0, 0,     0,     0, 0,  0,  0,  0,  0, 0}
 };
-static int num_dr_types = sizeof(drive_types) / sizeof(drive_types[0]);
+static int num_dr_types = ARRAY_SIZE(drive_types);
 
 static int amiga_read(int), dos_read(int);
 static void amiga_write(int), dos_write(int);
@@ -1424,6 +1424,16 @@ static void do_fd_request(request_queue_t * q)
         redo_fd_request();
 }
 
+static int fd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        int drive = MINOR(bdev->bd_dev) & 3;
+
+        geo->heads = unit[drive].type->heads;
+        geo->sectors = unit[drive].dtype->sects * unit[drive].type->sect_mult;
+        geo->cylinders = unit[drive].type->tracks;
+        return 0;
+}
+
 static int fd_ioctl(struct inode *inode, struct file *filp,
                     unsigned int cmd, unsigned long param)
 {
@@ -1431,18 +1441,6 @@ static int fd_ioctl(struct inode *inode, struct file *filp,
         static struct floppy_struct getprm;
 
         switch(cmd){
-        case HDIO_GETGEO:
-        {
-                struct hd_geometry loc;
-                loc.heads = unit[drive].type->heads;
-                loc.sectors = unit[drive].dtype->sects * unit[drive].type->sect_mult;
-                loc.cylinders = unit[drive].type->tracks;
-                loc.start = 0;
-                if (copy_to_user((void *)param, (void *)&loc,
-                                 sizeof(struct hd_geometry)))
-                        return -EFAULT;
-                break;
-        }
         case FDFMTBEG:
                 get_fdc(drive);
                 if (fd_ref[drive] > 1) {
@@ -1652,6 +1650,7 @@ static struct block_device_operations floppy_fops = {
         .open           = floppy_open,
         .release        = floppy_release,
         .ioctl          = fd_ioctl,
+        .getgeo         = fd_getgeo,
         .media_changed  = amiga_floppy_change,
 };
 
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
index 0e97fcb9f3a1..c05ee8bffd97 100644
--- a/drivers/block/aoe/aoeblk.c
+++ b/drivers/block/aoe/aoeblk.c
@@ -169,38 +169,26 @@ aoeblk_make_request(request_queue_t *q, struct bio *bio)
         return 0;
 }
 
-/* This ioctl implementation expects userland to have the device node
- * permissions set so that only priviledged users can open an aoe
- * block device directly.
- */
 static int
-aoeblk_ioctl(struct inode *inode, struct file *filp, uint cmd, ulong arg)
+aoeblk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct aoedev *d;
-
-        if (!arg)
-                return -EINVAL;
+        struct aoedev *d = bdev->bd_disk->private_data;
 
-        d = inode->i_bdev->bd_disk->private_data;
         if ((d->flags & DEVFL_UP) == 0) {
                 printk(KERN_ERR "aoe: aoeblk_ioctl: disk not up\n");
                 return -ENODEV;
         }
 
-        if (cmd == HDIO_GETGEO) {
-                d->geo.start = get_start_sect(inode->i_bdev);
-                if (!copy_to_user((void __user *) arg, &d->geo, sizeof d->geo))
-                        return 0;
-                return -EFAULT;
-        }
-        printk(KERN_INFO "aoe: aoeblk_ioctl: unknown ioctl %d\n", cmd);
-        return -EINVAL;
+        geo->cylinders = d->geo.cylinders;
+        geo->heads = d->geo.heads;
+        geo->sectors = d->geo.sectors;
+        return 0;
 }
 
 static struct block_device_operations aoe_bdops = {
         .open = aoeblk_open,
         .release = aoeblk_release,
-        .ioctl = aoeblk_ioctl,
+        .getgeo = aoeblk_getgeo,
         .owner = THIS_MODULE,
 };
 
diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index 22bda05fc693..3aa68a5447d6 100644
--- a/drivers/block/ataflop.c
+++ b/drivers/block/ataflop.c
@@ -181,7 +181,7 @@ static struct {
         {  6, TYPE_HD },        /* 31: H1640    <- was H1600 == h1600 for PC */
 };
 
-#define NUM_DISK_MINORS (sizeof(minor2disktype)/sizeof(*minor2disktype))
+#define NUM_DISK_MINORS ARRAY_SIZE(minor2disktype)
 
 /*
  * Maximum disk size (in kilobytes). This default is used whenever the
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index d2815b7a9150..e4e9f255bd1f 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1,6 +1,6 @@
 /*
  *    Disk Array driver for HP SA 5xxx and 6xxx Controllers
- *    Copyright 2000, 2005 Hewlett-Packard Development Company, L.P.
+ *    Copyright 2000, 2006 Hewlett-Packard Development Company, L.P.
  *
  *    This program is free software; you can redistribute it and/or modify
  *    it under the terms of the GNU General Public License as published by
@@ -47,12 +47,12 @@
 #include <linux/completion.h>
 
 #define CCISS_DRIVER_VERSION(maj,min,submin) ((maj<<16)|(min<<8)|(submin))
-#define DRIVER_NAME "HP CISS Driver (v 2.6.8)"
-#define DRIVER_VERSION CCISS_DRIVER_VERSION(2,6,8)
+#define DRIVER_NAME "HP CISS Driver (v 2.6.10)"
+#define DRIVER_VERSION CCISS_DRIVER_VERSION(2,6,10)
 
 /* Embedded module documentation macros - see modules.h */
 MODULE_AUTHOR("Hewlett-Packard Company");
-MODULE_DESCRIPTION("Driver for HP Controller SA5xxx SA6xxx version 2.6.8");
+MODULE_DESCRIPTION("Driver for HP Controller SA5xxx SA6xxx version 2.6.10");
 MODULE_SUPPORTED_DEVICE("HP SA5i SA5i+ SA532 SA5300 SA5312 SA641 SA642 SA6400"
                         " SA6i P600 P800 P400 P400i E200 E200i");
 MODULE_LICENSE("GPL");
@@ -103,7 +103,7 @@ static const struct pci_device_id cciss_pci_device_id[] = {
 };
 MODULE_DEVICE_TABLE(pci, cciss_pci_device_id);
 
-#define NR_PRODUCTS (sizeof(products)/sizeof(struct board_type))
+#define NR_PRODUCTS ARRAY_SIZE(products)
 
 /*  board_id = Subsystem Device ID & Vendor ID
  *  product = Marketing Name for the board
@@ -153,6 +153,7 @@ static int cciss_open(struct inode *inode, struct file *filep);
 static int cciss_release(struct inode *inode, struct file *filep);
 static int cciss_ioctl(struct inode *inode, struct file *filep, 
                 unsigned int cmd, unsigned long arg);
+static int cciss_getgeo(struct block_device *bdev, struct hd_geometry *geo);
 
 static int revalidate_allvol(ctlr_info_t *host);
 static int cciss_revalidate(struct gendisk *disk);
@@ -166,7 +167,7 @@ static void cciss_geometry_inquiry(int ctlr, int logvol,
                         unsigned int block_size, InquiryData_struct *inq_buff,
                         drive_info_struct *drv);
 static void cciss_getgeometry(int cntl_num);
-
+static void __devinit cciss_interrupt_mode(ctlr_info_t *, struct pci_dev *, __u32);
 static void start_io( ctlr_info_t *h);
 static int sendcmd( __u8 cmd, int ctlr, void *buff, size_t size,
         unsigned int use_unit_num, unsigned int log_unit, __u8 page_code,
@@ -194,6 +195,7 @@ static struct block_device_operations cciss_fops  = {
         .open           = cciss_open, 
         .release        = cciss_release,
         .ioctl          = cciss_ioctl,
+        .getgeo         = cciss_getgeo,
 #ifdef CONFIG_COMPAT
         .compat_ioctl   = cciss_compat_ioctl,
 #endif
@@ -282,7 +284,7 @@ static int cciss_proc_get_info(char *buffer, char **start, off_t offset,
                 h->product_name,
                 (unsigned long)h->board_id,
                 h->firm_ver[0], h->firm_ver[1], h->firm_ver[2], h->firm_ver[3],
-                (unsigned int)h->intr,
+                (unsigned int)h->intr[SIMPLE_MODE_INT],
                 h->num_luns, 
                 h->Qdepth, h->commands_outstanding,
                 h->maxQsinceinit, h->max_outstanding, h->maxSG);
@@ -633,6 +635,20 @@ static int cciss_ioctl32_big_passthru(struct file *file, unsigned cmd, unsigned
         return err;
 }
 #endif
+
+static int cciss_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        drive_info_struct *drv = get_drv(bdev->bd_disk);
+
+        if (!drv->cylinders)
+                return -ENXIO;
+
+        geo->heads = drv->heads;
+        geo->sectors = drv->sectors;
+        geo->cylinders = drv->cylinders;
+        return 0;
+}
+
 /*
  * ioctl 
  */
@@ -651,21 +667,6 @@ static int cciss_ioctl(struct inode *inode, struct file *filep,
 #endif /* CCISS_DEBUG */ 
         
         switch(cmd) {
-        case HDIO_GETGEO:
-        {
-                struct hd_geometry driver_geo;
-                if (drv->cylinders) {
-                        driver_geo.heads = drv->heads;
-                        driver_geo.sectors = drv->sectors;
-                        driver_geo.cylinders = drv->cylinders;
-                } else
-                        return -ENXIO;
-                driver_geo.start= get_start_sect(inode->i_bdev);
-                if (copy_to_user(argp, &driver_geo, sizeof(struct hd_geometry)))
-                        return  -EFAULT;
-                return(0);
-        }
-
         case CCISS_GETPCIINFO:
         {
                 cciss_pci_info_struct pciinfo;
@@ -2177,16 +2178,48 @@ static inline void resend_cciss_cmd( ctlr_info_t *h, CommandList_struct *c)
 
         start_io(h);
 }
+
+static void cciss_softirq_done(struct request *rq)
+{
+        CommandList_struct *cmd = rq->completion_data;
+        ctlr_info_t *h = hba[cmd->ctlr];
+        u64bit temp64;
+        int i, ddir;
+
+        if (cmd->Request.Type.Direction == XFER_READ)
+                ddir = PCI_DMA_FROMDEVICE;
+        else
+                ddir = PCI_DMA_TODEVICE;
+
+        /* command did not need to be retried */
+        /* unmap the DMA mapping for all the scatter gather elements */
+        for(i=0; i<cmd->Header.SGList; i++) {
+                temp64.val32.lower = cmd->SG[i].Addr.lower;
+                temp64.val32.upper = cmd->SG[i].Addr.upper;
+                pci_unmap_page(h->pdev, temp64.val, cmd->SG[i].Len, ddir);
+        }
+
+        complete_buffers(rq->bio, rq->errors);
+
+#ifdef CCISS_DEBUG
+        printk("Done with %p\n", rq);
+#endif /* CCISS_DEBUG */ 
+
+        spin_lock_irq(&h->lock);
+        end_that_request_last(rq, rq->errors);
+        cmd_free(h, cmd,1);
+        spin_unlock_irq(&h->lock);
+}
+
 /* checks the status of the job and calls complete buffers to mark all 
- * buffers for the completed job. 
+ * buffers for the completed job. Note that this function does not need
+ * to hold the hba/queue lock.
  */ 
 static inline void complete_command( ctlr_info_t *h, CommandList_struct *cmd,
                 int timeout)
 {
         int status = 1;
-        int i;
         int retry_cmd = 0;
-        u64bit temp64;
                 
         if (timeout)
                 status = 0; 
@@ -2294,24 +2327,10 @@ static inline void complete_command( ctlr_info_t *h, CommandList_struct *cmd,
                 resend_cciss_cmd(h,cmd);
                 return;
         }       
-        /* command did not need to be retried */
-        /* unmap the DMA mapping for all the scatter gather elements */
-        for(i=0; i<cmd->Header.SGList; i++) {
-                temp64.val32.lower = cmd->SG[i].Addr.lower;
-                temp64.val32.upper = cmd->SG[i].Addr.upper;
-                pci_unmap_page(hba[cmd->ctlr]->pdev,
-                        temp64.val, cmd->SG[i].Len,
-                        (cmd->Request.Type.Direction == XFER_READ) ?
-                                PCI_DMA_FROMDEVICE : PCI_DMA_TODEVICE);
-        }
-        complete_buffers(cmd->rq->bio, status);
 
-#ifdef CCISS_DEBUG
-        printk("Done with %p\n", cmd->rq);
-#endif /* CCISS_DEBUG */ 
-
-        end_that_request_last(cmd->rq, status ? 1 : -EIO);
-        cmd_free(h,cmd,1);
+        cmd->rq->completion_data = cmd;
+        cmd->rq->errors = status;
+        blk_complete_request(cmd->rq);
 }
 
 /* 
@@ -2661,6 +2680,60 @@ static int find_PCI_BAR_index(struct pci_dev *pdev,
         return -1;
 }
 
+/* If MSI/MSI-X is supported by the kernel we will try to enable it on
+ * controllers that are capable. If not, we use IO-APIC mode.
+ */
+
+static void __devinit cciss_interrupt_mode(ctlr_info_t *c, struct pci_dev *pdev, __u32 board_id)
+{
+#ifdef CONFIG_PCI_MSI
+        int err;
+        struct msix_entry cciss_msix_entries[4] = {{0,0}, {0,1},
+                                                   {0,2}, {0,3}};
+
+        /* Some boards advertise MSI but don't really support it */
+        if ((board_id == 0x40700E11) ||
+                (board_id == 0x40800E11) ||
+                (board_id == 0x40820E11) ||
+                (board_id == 0x40830E11))
+                goto default_int_mode;
+
+        if (pci_find_capability(pdev, PCI_CAP_ID_MSIX)) {
+                err = pci_enable_msix(pdev, cciss_msix_entries, 4);
+                if (!err) {
+                        c->intr[0] = cciss_msix_entries[0].vector;
+                        c->intr[1] = cciss_msix_entries[1].vector;
+                        c->intr[2] = cciss_msix_entries[2].vector;
+                        c->intr[3] = cciss_msix_entries[3].vector;
+                        c->msix_vector = 1;
+                        return;
+                }
+                if (err > 0) {
+                        printk(KERN_WARNING "cciss: only %d MSI-X vectors "
+                                        "available\n", err);
+                } else {
+                        printk(KERN_WARNING "cciss: MSI-X init failed %d\n",
+                                                err);
+                }
+        }
+        if (pci_find_capability(pdev, PCI_CAP_ID_MSI)) {
+                if (!pci_enable_msi(pdev)) {
+                        c->intr[SIMPLE_MODE_INT] = pdev->irq;
+                        c->msi_vector = 1;
+                        return;
+                } else {
+                        printk(KERN_WARNING "cciss: MSI init failed\n");
+                        c->intr[SIMPLE_MODE_INT] = pdev->irq;
+                        return;
+                }
+        }
+#endif /* CONFIG_PCI_MSI */
+        /* if we get here we're going to use the default interrupt mode */
+default_int_mode:
+        c->intr[SIMPLE_MODE_INT] = pdev->irq;
+        return;
+}
+
 static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
 {
         ushort subsystem_vendor_id, subsystem_device_id, command;
@@ -2721,7 +2794,10 @@ static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
         printk("board_id = %x\n", board_id);
 #endif /* CCISS_DEBUG */ 
 
-        c->intr = pdev->irq;
+/* If the kernel supports MSI/MSI-X we will try to enable that functionality,
+ * else we use the IO-APIC interrupt assigned to us by system ROM.
+ */
+        cciss_interrupt_mode(c, pdev, board_id);
 
         /*
          * Memory base addr is first addr , the second points to the config
@@ -2775,7 +2851,7 @@ static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
         c->board_id = board_id;
 
 #ifdef CCISS_DEBUG
-        print_cfg_table(c->cfgtable); 
+        print_cfg_table(c->cfgtable);
 #endif /* CCISS_DEBUG */
 
         for(i=0; i<NR_PRODUCTS; i++) {
@@ -3060,7 +3136,7 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
          * 8 controller support.
          */
         if (i < MAX_CTLR_ORIG)
-                hba[i]->major = MAJOR_NR + i;
+                hba[i]->major = COMPAQ_CISS_MAJOR + i;
         rc = register_blkdev(hba[i]->major, hba[i]->devname);
         if(rc == -EBUSY || rc == -EINVAL) {
                 printk(KERN_ERR
@@ -3075,11 +3151,11 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
 
         /* make sure the board interrupts are off */
         hba[i]->access.set_intr_mask(hba[i], CCISS_INTR_OFF);
-        if( request_irq(hba[i]->intr, do_cciss_intr, 
+        if( request_irq(hba[i]->intr[SIMPLE_MODE_INT], do_cciss_intr,
                 SA_INTERRUPT | SA_SHIRQ | SA_SAMPLE_RANDOM, 
                         hba[i]->devname, hba[i])) {
                 printk(KERN_ERR "cciss: Unable to get irq %d for %s\n",
-                        hba[i]->intr, hba[i]->devname);
+                        hba[i]->intr[SIMPLE_MODE_INT], hba[i]->devname);
                 goto clean2;
         }
         hba[i]->cmd_pool_bits = kmalloc(((NR_CMDS+BITS_PER_LONG-1)/BITS_PER_LONG)*sizeof(unsigned long), GFP_KERNEL);
@@ -3141,15 +3217,17 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
                 drv->queue = q;
 
                 q->backing_dev_info.ra_pages = READ_AHEAD;
-        blk_queue_bounce_limit(q, hba[i]->pdev->dma_mask);
+                blk_queue_bounce_limit(q, hba[i]->pdev->dma_mask);
 
-        /* This is a hardware imposed limit. */
-        blk_queue_max_hw_segments(q, MAXSGENTRIES);
+                /* This is a hardware imposed limit. */
+                blk_queue_max_hw_segments(q, MAXSGENTRIES);
 
-        /* This is a limit in the driver and could be eliminated. */
-        blk_queue_max_phys_segments(q, MAXSGENTRIES);
+                /* This is a limit in the driver and could be eliminated. */
+                blk_queue_max_phys_segments(q, MAXSGENTRIES);
 
-        blk_queue_max_sectors(q, 512);
+                blk_queue_max_sectors(q, 512);
+
+                blk_queue_softirq_done(q, cciss_softirq_done);
 
                 q->queuedata = hba[i];
                 sprintf(disk->disk_name, "cciss/c%dd%d", i, j);
@@ -3185,7 +3263,7 @@ clean4:
                         NR_CMDS * sizeof( ErrorInfo_struct),
                         hba[i]->errinfo_pool,
                         hba[i]->errinfo_pool_dhandle);
-        free_irq(hba[i]->intr, hba[i]);
+        free_irq(hba[i]->intr[SIMPLE_MODE_INT], hba[i]);
 clean2:
         unregister_blkdev(hba[i]->major, hba[i]->devname);
 clean1:
@@ -3226,7 +3304,15 @@ static void __devexit cciss_remove_one (struct pci_dev *pdev)
                 printk(KERN_WARNING "Error Flushing cache on controller %d\n", 
                         i);
         }
-        free_irq(hba[i]->intr, hba[i]);
+        free_irq(hba[i]->intr[2], hba[i]);
+
+#ifdef CONFIG_PCI_MSI
+        if (hba[i]->msix_vector)
+                pci_disable_msix(hba[i]->pdev);
+        else if (hba[i]->msi_vector)
+                pci_disable_msi(hba[i]->pdev);
+#endif /* CONFIG_PCI_MSI */
+
         pci_set_drvdata(pdev, NULL);
         iounmap(hba[i]->vaddr);
         cciss_unregister_scsi(i);  /* unhook from SCSI subsystem */
diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
index 3b0858c83897..b24fc0553ccf 100644
--- a/drivers/block/cciss.h
+++ b/drivers/block/cciss.h
@@ -13,8 +13,6 @@
 #define IO_OK           0
 #define IO_ERROR        1
 
-#define MAJOR_NR COMPAQ_CISS_MAJOR
-
 struct ctlr_info;
 typedef struct ctlr_info ctlr_info_t;
 
@@ -65,7 +63,6 @@ struct ctlr_info
         unsigned long io_mem_addr;
         unsigned long io_mem_length;
         CfgTable_struct __iomem *cfgtable;
-        unsigned int intr;
         int     interrupts_enabled;
         int     major;
         int     max_commands;
@@ -74,6 +71,13 @@ struct ctlr_info
         int     num_luns;
         int     highest_lun;
         int     usage_count;  /* number of opens all all minor devices */
+#       define DOORBELL_INT     0
+#       define PERF_MODE_INT    1
+#       define SIMPLE_MODE_INT  2
+#       define MEMQ_MODE_INT    3
+        unsigned int intr[4];
+        unsigned int msix_vector;
+        unsigned int msi_vector;
 
         // information about each logical volume
         drive_info_struct drv[CISS_MAX_LUN];
diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c
index 2942d32280a5..9e35de05d5c5 100644
--- a/drivers/block/cciss_scsi.c
+++ b/drivers/block/cciss_scsi.c
@@ -714,7 +714,7 @@ cciss_scsi_detect(int ctlr)
         ((struct cciss_scsi_adapter_data_t *) 
                 hba[ctlr]->scsi_ctlr)->scsi_host = (void *) sh;
         sh->hostdata[0] = (unsigned long) hba[ctlr];
-        sh->irq = hba[ctlr]->intr;
+        sh->irq = hba[ctlr]->intr[SIMPLE_MODE_INT];
         sh->unique_id = sh->irq;
         error = scsi_add_host(sh, &hba[ctlr]->pdev->dev);
         if (error)
diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 9bddb6874873..862b9abac0ae 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -72,11 +72,11 @@ static ctlr_info_t *hba[MAX_CTLR];
 
 static int eisa[8];
 
-#define NR_PRODUCTS (sizeof(products)/sizeof(struct board_type))
+#define NR_PRODUCTS ARRAY_SIZE(products)
 
 /*  board_id = Subsystem Device ID & Vendor ID
  *  product = Marketing Name for the board
- *  access = Address of the struct of function pointers 
+ *  access = Address of the struct of function pointers
  */
 static struct board_type products[] = {
         { 0x0040110E, "IDA",                    &smart1_access },
@@ -160,6 +160,7 @@ static int sendcmd(
 static int ida_open(struct inode *inode, struct file *filep);
 static int ida_release(struct inode *inode, struct file *filep);
 static int ida_ioctl(struct inode *inode, struct file *filep, unsigned int cmd, unsigned long arg);
+static int ida_getgeo(struct block_device *bdev, struct hd_geometry *geo);
 static int ida_ctlr_ioctl(ctlr_info_t *h, int dsk, ida_ioctl_t *io);
 
 static void do_ida_request(request_queue_t *q);
@@ -199,6 +200,7 @@ static struct block_device_operations ida_fops  = {
         .open           = ida_open,
         .release        = ida_release,
         .ioctl          = ida_ioctl,
+        .getgeo         = ida_getgeo,
         .revalidate_disk= ida_revalidate,
 };
 
@@ -1124,6 +1126,23 @@ static void ida_timer(unsigned long tdata)
         h->misc_tflags = 0;
 }
 
+static int ida_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        drv_info_t *drv = get_drv(bdev->bd_disk);
+
+        if (drv->cylinders) {
+                geo->heads = drv->heads;
+                geo->sectors = drv->sectors;
+                geo->cylinders = drv->cylinders;
+        } else {
+                geo->heads = 0xff;
+                geo->sectors = 0x3f;
+                geo->cylinders = drv->nr_blks / (0xff*0x3f);
+        }
+
+        return 0;
+}
+
 /*
  *  ida_ioctl does some miscellaneous stuff like reporting drive geometry,
  *  setting readahead and submitting commands from userspace to the controller.
@@ -1133,27 +1152,10 @@ static int ida_ioctl(struct inode *inode, struct file *filep, unsigned int cmd,
         drv_info_t *drv = get_drv(inode->i_bdev->bd_disk);
         ctlr_info_t *host = get_host(inode->i_bdev->bd_disk);
         int error;
-        int diskinfo[4];
-        struct hd_geometry __user *geo = (struct hd_geometry __user *)arg;
         ida_ioctl_t __user *io = (ida_ioctl_t __user *)arg;
         ida_ioctl_t *my_io;
 
         switch(cmd) {
-        case HDIO_GETGEO:
-                if (drv->cylinders) {
-                        diskinfo[0] = drv->heads;
-                        diskinfo[1] = drv->sectors;
-                        diskinfo[2] = drv->cylinders;
-                } else {
-                        diskinfo[0] = 0xff;
-                        diskinfo[1] = 0x3f;
-                        diskinfo[2] = drv->nr_blks / (0xff*0x3f);
-                }
-                put_user(diskinfo[0], &geo->heads);
-                put_user(diskinfo[1], &geo->sectors);
-                put_user(diskinfo[2], &geo->cylinders);
-                put_user(get_start_sect(inode->i_bdev), &geo->start);
-                return 0;
         case IDAGETDRVINFO:
                 if (copy_to_user(&io->c.drv, drv, sizeof(drv_info_t)))
                         return -EFAULT;
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index a5b857c5c4b8..374621a512e0 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -479,7 +479,6 @@ static struct floppy_struct floppy_type[32] = {
         { 3200,20,2,80,0,0x1C,0x00,0xCF,0x2C,"H1600" }, /* 31 1.6MB 3.5"    */
 };
 
-#define NUMBER(x)       (sizeof(x) / sizeof(*(x)))
 #define SECTSIZE (_FD_SECTSIZE(*floppy))
 
 /* Auto-detection: Disk type used until the next media change occurs. */
@@ -3445,6 +3444,23 @@ static int get_floppy_geometry(int drive, int type, struct floppy_struct **g)
         return 0;
 }
 
+static int fd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        int drive = (long)bdev->bd_disk->private_data;
+        int type = ITYPE(drive_state[drive].fd_device);
+        struct floppy_struct *g;
+        int ret;
+
+        ret = get_floppy_geometry(drive, type, &g);
+        if (ret)
+                return ret;
+
+        geo->heads = g->head;
+        geo->sectors = g->sect;
+        geo->cylinders = g->track;
+        return 0;
+}
+
 static int fd_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
                     unsigned long param)
 {
@@ -3474,23 +3490,6 @@ static int fd_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
                 cmd = FDEJECT;
         }
 
-        /* generic block device ioctls */
-        switch (cmd) {
-                /* the following have been inspired by the corresponding
-                 * code for other block devices. */
-                struct floppy_struct *g;
-        case HDIO_GETGEO:
-                {
-                        struct hd_geometry loc;
-                        ECALL(get_floppy_geometry(drive, type, &g));
-                        loc.heads = g->head;
-                        loc.sectors = g->sect;
-                        loc.cylinders = g->track;
-                        loc.start = 0;
-                        return _COPYOUT(loc);
-                }
-        }
-
         /* convert the old style command into a new style command */
         if ((cmd & 0xff00) == 0x0200) {
                 ECALL(normalize_ioctl(&cmd, &size));
@@ -3645,7 +3644,7 @@ static void __init config_types(void)
                 const char *name = NULL;
                 static char temparea[32];
 
-                if (type < NUMBER(default_drive_params)) {
+                if (type < ARRAY_SIZE(default_drive_params)) {
                         params = &default_drive_params[type].params;
                         if (type) {
                                 name = default_drive_params[type].name;
@@ -3938,6 +3937,7 @@ static struct block_device_operations floppy_fops = {
         .open           = floppy_open,
         .release        = floppy_release,
         .ioctl          = fd_ioctl,
+        .getgeo         = fd_getgeo,
         .media_changed  = check_floppy_change,
         .revalidate_disk = floppy_revalidate,
 };
@@ -3960,7 +3960,7 @@ static void __init register_devfs_entries(int drive)
 {
         int base_minor = (drive < 4) ? drive : (124 + drive);
 
-        if (UDP->cmos < NUMBER(default_drive_params)) {
+        if (UDP->cmos < ARRAY_SIZE(default_drive_params)) {
                 int i = 0;
                 do {
                         int minor = base_minor + (table_sup[UDP->cmos][i] << 2);
@@ -4218,7 +4218,7 @@ static struct kobject *floppy_find(dev_t dev, int *part, void *data)
             !(allowed_drive_mask & (1 << drive)) ||
             fdc_state[FDC(drive)].version == FDC_NONE)
                 return NULL;
-        if (((*part >> 2) & 0x1f) >= NUMBER(floppy_type))
+        if (((*part >> 2) & 0x1f) >= ARRAY_SIZE(floppy_type))
                 return NULL;
         *part = 0;
         return get_disk(disks[drive]);
@@ -4570,7 +4570,7 @@ static void unregister_devfs_entries(int drive)
 {
         int i;
 
-        if (UDP->cmos < NUMBER(default_drive_params)) {
+        if (UDP->cmos < ARRAY_SIZE(default_drive_params)) {
                 i = 0;
                 do {
                         devfs_remove("floppy/%d%s", drive,
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 33d6f237b2ed..6997d8e6bfb5 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -174,7 +174,6 @@ static int sock_xmit(struct socket *sock, int send, void *buf, int size,
                 msg.msg_namelen = 0;
                 msg.msg_control = NULL;
                 msg.msg_controllen = 0;
-                msg.msg_namelen = 0;
                 msg.msg_flags = msg_flags | MSG_NOSIGNAL;
 
                 if (send)
diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
index fa49d62626ba..62d2464c12f2 100644
--- a/drivers/block/paride/pd.c
+++ b/drivers/block/paride/pd.c
@@ -747,32 +747,33 @@ static int pd_open(struct inode *inode, struct file *file)
         return 0;
 }
 
+static int pd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct pd_unit *disk = bdev->bd_disk->private_data;
+
+        if (disk->alt_geom) {
+                geo->heads = PD_LOG_HEADS;
+                geo->sectors = PD_LOG_SECTS;
+                geo->cylinders = disk->capacity / (geo->heads * geo->sectors);
+        } else {
+                geo->heads = disk->heads;
+                geo->sectors = disk->sectors;
+                geo->cylinders = disk->cylinders;
+        }
+
+        return 0;
+}
+
 static int pd_ioctl(struct inode *inode, struct file *file,
          unsigned int cmd, unsigned long arg)
 {
         struct pd_unit *disk = inode->i_bdev->bd_disk->private_data;
-        struct hd_geometry __user *geo = (struct hd_geometry __user *) arg;
-        struct hd_geometry g;
 
         switch (cmd) {
         case CDROMEJECT:
                 if (disk->access == 1)
                         pd_special_command(disk, pd_eject);
                 return 0;
-        case HDIO_GETGEO:
-                if (disk->alt_geom) {
-                        g.heads = PD_LOG_HEADS;
-                        g.sectors = PD_LOG_SECTS;
-                        g.cylinders = disk->capacity / (g.heads * g.sectors);
-                } else {
-                        g.heads = disk->heads;
-                        g.sectors = disk->sectors;
-                        g.cylinders = disk->cylinders;
-                }
-                g.start = get_start_sect(inode->i_bdev);
-                if (copy_to_user(geo, &g, sizeof(struct hd_geometry)))
-                        return -EFAULT;
-                return 0;
         default:
                 return -EINVAL;
         }
@@ -815,6 +816,7 @@ static struct block_device_operations pd_fops = {
         .open           = pd_open,
         .release        = pd_release,
         .ioctl          = pd_ioctl,
+        .getgeo         = pd_getgeo,
         .media_changed  = pd_check_media,
         .revalidate_disk= pd_revalidate
 };
diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c
index e9746af29b9f..852b564e903a 100644
--- a/drivers/block/paride/pf.c
+++ b/drivers/block/paride/pf.c
@@ -205,6 +205,7 @@ static int pf_open(struct inode *inode, struct file *file);
 static void do_pf_request(request_queue_t * q);
 static int pf_ioctl(struct inode *inode, struct file *file,
                     unsigned int cmd, unsigned long arg);
+static int pf_getgeo(struct block_device *bdev, struct hd_geometry *geo);
 
 static int pf_release(struct inode *inode, struct file *file);
 
@@ -266,6 +267,7 @@ static struct block_device_operations pf_fops = {
         .open           = pf_open,
         .release        = pf_release,
         .ioctl          = pf_ioctl,
+        .getgeo         = pf_getgeo,
         .media_changed  = pf_check_media,
 };
 
@@ -313,34 +315,34 @@ static int pf_open(struct inode *inode, struct file *file)
         return 0;
 }
 
-static int pf_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
+static int pf_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct pf_unit *pf = inode->i_bdev->bd_disk->private_data;
-        struct hd_geometry __user *geo = (struct hd_geometry __user *) arg;
-        struct hd_geometry g;
-        sector_t capacity;
-
-        if (cmd == CDROMEJECT) {
-                if (pf->access == 1) {
-                        pf_eject(pf);
-                        return 0;
-                }
-                return -EBUSY;
-        }
-        if (cmd != HDIO_GETGEO)
-                return -EINVAL;
-        capacity = get_capacity(pf->disk);
+        struct pf_unit *pf = bdev->bd_disk->private_data;
+        sector_t capacity = get_capacity(pf->disk);
+
         if (capacity < PF_FD_MAX) {
-                g.cylinders = sector_div(capacity, PF_FD_HDS * PF_FD_SPT);
-                g.heads = PF_FD_HDS;
-                g.sectors = PF_FD_SPT;
+                geo->cylinders = sector_div(capacity, PF_FD_HDS * PF_FD_SPT);
+                geo->heads = PF_FD_HDS;
+                geo->sectors = PF_FD_SPT;
         } else {
-                g.cylinders = sector_div(capacity, PF_HD_HDS * PF_HD_SPT);
-                g.heads = PF_HD_HDS;
-                g.sectors = PF_HD_SPT;
+                geo->cylinders = sector_div(capacity, PF_HD_HDS * PF_HD_SPT);
+                geo->heads = PF_HD_HDS;
+                geo->sectors = PF_HD_SPT;
         }
-        if (copy_to_user(geo, &g, sizeof(g)))
-                return -EFAULT;
+
+        return 0;
+}
+
+static int pf_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
+{
+        struct pf_unit *pf = inode->i_bdev->bd_disk->private_data;
+
+        if (cmd != CDROMEJECT)
+                return -EINVAL;
+
+        if (pf->access != 1)
+                return -EBUSY;
+        pf_eject(pf);
         return 0;
 }
 
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index c0233efabeba..51b7a5c5b77a 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1955,9 +1955,12 @@ static int pkt_open_dev(struct pktcdvd_device *pd, int write)
         if ((ret = blkdev_get(pd->bdev, FMODE_READ, O_RDONLY)))
                 goto out;
 
+        if ((ret = bd_claim(pd->bdev, pd)))
+                goto out_putdev;
+
         if ((ret = pkt_get_last_written(pd, &lba))) {
                 printk("pktcdvd: pkt_get_last_written failed\n");
-                goto out_putdev;
+                goto out_unclaim;
         }
 
         set_capacity(pd->disk, lba << 2);
@@ -1967,7 +1970,7 @@ static int pkt_open_dev(struct pktcdvd_device *pd, int write)
         q = bdev_get_queue(pd->bdev);
         if (write) {
                 if ((ret = pkt_open_write(pd)))
-                        goto out_putdev;
+                        goto out_unclaim;
                 /*
                  * Some CDRW drives can not handle writes larger than one packet,
                  * even if the size is a multiple of the packet size.
@@ -1982,13 +1985,15 @@ static int pkt_open_dev(struct pktcdvd_device *pd, int write)
         }
 
         if ((ret = pkt_set_segment_merging(pd, q)))
-                goto out_putdev;
+                goto out_unclaim;
 
         if (write)
                 printk("pktcdvd: %lukB available on disc\n", lba << 1);
 
         return 0;
 
+out_unclaim:
+        bd_release(pd->bdev);
 out_putdev:
         blkdev_put(pd->bdev);
 out:
@@ -2007,6 +2012,7 @@ static void pkt_release_dev(struct pktcdvd_device *pd, int flush)
         pkt_lock_door(pd, 0);
 
         pkt_set_speed(pd, MAX_SPEED, MAX_SPEED);
+        bd_release(pd->bdev);
         blkdev_put(pd->bdev);
 }
 
diff --git a/drivers/block/ps2esdi.c b/drivers/block/ps2esdi.c
index 29d1518be72a..43415f69839f 100644
--- a/drivers/block/ps2esdi.c
+++ b/drivers/block/ps2esdi.c
@@ -81,8 +81,7 @@ static void (*current_int_handler) (u_int) = NULL;
 static void ps2esdi_normal_interrupt_handler(u_int);
 static void ps2esdi_initial_reset_int_handler(u_int);
 static void ps2esdi_geometry_int_handler(u_int);
-static int ps2esdi_ioctl(struct inode *inode, struct file *file,
-                         u_int cmd, u_long arg);
+static int ps2esdi_getgeo(struct block_device *bdev, struct hd_geometry *geo);
 
 static int ps2esdi_read_status_words(int num_words, int max_words, u_short * buffer);
 
@@ -132,7 +131,7 @@ static struct ps2esdi_i_struct ps2esdi_info[MAX_HD] =
 static struct block_device_operations ps2esdi_fops =
 {
         .owner          = THIS_MODULE,
-        .ioctl          = ps2esdi_ioctl,
+        .getgeo         = ps2esdi_getgeo,
 };
 
 static struct gendisk *ps2esdi_gendisk[2];
@@ -1058,21 +1057,13 @@ static void dump_cmd_complete_status(u_int int_ret_code)
 
 }
 
-static int ps2esdi_ioctl(struct inode *inode,
-                         struct file *file, u_int cmd, u_long arg)
+static int ps2esdi_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct ps2esdi_i_struct *p = inode->i_bdev->bd_disk->private_data;
-        struct ps2esdi_geometry geom;
-
-        if (cmd != HDIO_GETGEO)
-                return -EINVAL;
-        memset(&geom, 0, sizeof(geom));
-        geom.heads = p->head;
-        geom.sectors = p->sect;
-        geom.cylinders = p->cyl;
-        geom.start = get_start_sect(inode->i_bdev);
-        if (copy_to_user((void __user *)arg, &geom, sizeof(geom)))
-                return -EFAULT;
+        struct ps2esdi_i_struct *p = bdev->bd_disk->private_data;
+
+        geo->heads = p->head;
+        geo->sectors = p->sect;
+        geo->cylinders = p->cyl;
         return 0;
 }
 
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index af7cb2bfd670..01f042f6f1c4 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1083,23 +1083,33 @@ static int swim3_add_device(struct device_node *swim)
 {
         struct device_node *mediabay;
         struct floppy_state *fs = &floppy_states[floppy_count];
+        struct resource res_reg, res_dma;
 
-        if (swim->n_addrs < 2)
-        {
-                printk(KERN_INFO "swim3: expecting 2 addrs (n_addrs:%d, n_intrs:%d)\n",
-                       swim->n_addrs, swim->n_intrs);
+        if (of_address_to_resource(swim, 0, &res_reg) ||
+            of_address_to_resource(swim, 1, &res_dma)) {
+                printk(KERN_ERR "swim3: Can't get addresses\n");
                 return -EINVAL;
         }
-
-        if (swim->n_intrs < 2)
-        {
-                printk(KERN_INFO "swim3: expecting 2 intrs (n_addrs:%d, n_intrs:%d)\n",
-                       swim->n_addrs, swim->n_intrs);
+        if (request_mem_region(res_reg.start, res_reg.end - res_reg.start + 1,
+                               " (reg)") == NULL) {
+                printk(KERN_ERR "swim3: Can't request register space\n");
+                return -EINVAL;
+        }
+        if (request_mem_region(res_dma.start, res_dma.end - res_dma.start + 1,
+                               " (dma)") == NULL) {
+                release_mem_region(res_reg.start,
+                                   res_reg.end - res_reg.start + 1);
+                printk(KERN_ERR "swim3: Can't request DMA space\n");
                 return -EINVAL;
         }
 
-        if (!request_OF_resource(swim, 0, NULL)) {
-                printk(KERN_INFO "swim3: can't request IO resource !\n");
+        if (swim->n_intrs < 2) {
+                printk(KERN_INFO "swim3: expecting 2 intrs (n_intrs:%d)\n",
+                       swim->n_intrs);
+                release_mem_region(res_reg.start,
+                                   res_reg.end - res_reg.start + 1);
+                release_mem_region(res_dma.start,
+                                   res_dma.end - res_dma.start + 1);
                 return -EINVAL;
         }
 
@@ -1110,10 +1120,8 @@ static int swim3_add_device(struct device_node *swim)
         memset(fs, 0, sizeof(*fs));
         spin_lock_init(&fs->lock);
         fs->state = idle;
-        fs->swim3 = (struct swim3 __iomem *)
-                ioremap(swim->addrs[0].address, 0x200);
-        fs->dma = (struct dbdma_regs __iomem *)
-                ioremap(swim->addrs[1].address, 0x200);
+        fs->swim3 = (struct swim3 __iomem *)ioremap(res_reg.start, 0x200);
+        fs->dma = (struct dbdma_regs __iomem *)ioremap(res_dma.start, 0x200);
         fs->swim3_intr = swim->intrs[0].line;
         fs->dma_intr = swim->intrs[1].line;
         fs->cur_cyl = -1;
diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index 9251f4131b53..c0cdc182a8b0 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -407,8 +407,7 @@ struct carm_array_info {
 
 static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent);
 static void carm_remove_one (struct pci_dev *pdev);
-static int carm_bdev_ioctl(struct inode *ino, struct file *fil,
-                           unsigned int cmd, unsigned long arg);
+static int carm_bdev_getgeo(struct block_device *bdev, struct hd_geometry *geo);
 
 static struct pci_device_id carm_pci_tbl[] = {
         { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
@@ -426,7 +425,7 @@ static struct pci_driver carm_driver = {
 
 static struct block_device_operations carm_bd_ops = {
         .owner          = THIS_MODULE,
-        .ioctl          = carm_bdev_ioctl,
+        .getgeo         = carm_bdev_getgeo,
 };
 
 static unsigned int carm_host_id;
@@ -434,32 +433,14 @@ static unsigned long carm_major_alloc;
 
 
 
-static int carm_bdev_ioctl(struct inode *ino, struct file *fil,
-                           unsigned int cmd, unsigned long arg)
+static int carm_bdev_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        void __user *usermem = (void __user *) arg;
-        struct carm_port *port = ino->i_bdev->bd_disk->private_data;
-        struct hd_geometry geom;
+        struct carm_port *port = bdev->bd_disk->private_data;
 
-        switch (cmd) {
-        case HDIO_GETGEO:
-                if (!usermem)
-                        return -EINVAL;
-
-                geom.heads = (u8) port->dev_geom_head;
-                geom.sectors = (u8) port->dev_geom_sect;
-                geom.cylinders = port->dev_geom_cyl;
-                geom.start = get_start_sect(ino->i_bdev);
-
-                if (copy_to_user(usermem, &geom, sizeof(geom)))
-                        return -EFAULT;
-                return 0;
-
-        default:
-                break;
-        }
-
-        return -EOPNOTSUPP;
+        geo->heads = (u8) port->dev_geom_head;
+        geo->sectors = (u8) port->dev_geom_sect;
+        geo->cylinders = port->dev_geom_cyl;
+        return 0;
 }
 
 static const u32 msg_sizes[] = { 32, 64, 128, CARM_MSG_SIZE };
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
index 0f48301342da..15299e7a1ade 100644
--- a/drivers/block/umem.c
+++ b/drivers/block/umem.c
@@ -809,34 +809,23 @@ static int mm_revalidate(struct gendisk *disk)
         set_capacity(disk, card->mm_size << 1);
         return 0;
 }
-/*
------------------------------------------------------------------------------------
---                            mm_ioctl
------------------------------------------------------------------------------------
-*/
-static int mm_ioctl(struct inode *i, struct file *f, unsigned int cmd, unsigned long arg)
+
+static int mm_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        if (cmd == HDIO_GETGEO) {
-                struct cardinfo *card = i->i_bdev->bd_disk->private_data;
-                int size = card->mm_size * (1024 / MM_HARDSECT);
-                struct hd_geometry geo;
-                /*
-                 * get geometry: we have to fake one...  trim the size to a
-                 * multiple of 2048 (1M): tell we have 32 sectors, 64 heads,
-                 * whatever cylinders.
-                 */
-                geo.heads     = 64;
-                geo.sectors   = 32;
-                geo.start     = get_start_sect(i->i_bdev);
-                geo.cylinders = size / (geo.heads * geo.sectors);
-
-                if (copy_to_user((void __user *) arg, &geo, sizeof(geo)))
-                        return -EFAULT;
-                return 0;
-        }
+        struct cardinfo *card = bdev->bd_disk->private_data;
+        int size = card->mm_size * (1024 / MM_HARDSECT);
 
-        return -EINVAL;
+        /*
+         * get geometry: we have to fake one...  trim the size to a
+         * multiple of 2048 (1M): tell we have 32 sectors, 64 heads,
+         * whatever cylinders.
+         */
+        geo->heads     = 64;
+        geo->sectors   = 32;
+        geo->cylinders = size / (geo->heads * geo->sectors);
+        return 0;
 }
+
 /*
 -----------------------------------------------------------------------------------
 --                                mm_check_change
@@ -855,7 +844,7 @@ static int mm_check_change(struct gendisk *disk)
 */
 static struct block_device_operations mm_fops = {
         .owner          = THIS_MODULE,
-        .ioctl          = mm_ioctl,
+        .getgeo         = mm_getgeo,
         .revalidate_disk= mm_revalidate,
         .media_changed  = mm_check_change,
 };
diff --git a/drivers/block/viodasd.c b/drivers/block/viodasd.c
index 063f0304a163..d1aaf31bd97e 100644
--- a/drivers/block/viodasd.c
+++ b/drivers/block/viodasd.c
@@ -247,43 +247,17 @@ static int viodasd_release(struct inode *ino, struct file *fil)
 
 /* External ioctl entry point.
  */
-static int viodasd_ioctl(struct inode *ino, struct file *fil,
-                         unsigned int cmd, unsigned long arg)
+static int viodasd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        unsigned char sectors;
-        unsigned char heads;
-        unsigned short cylinders;
-        struct hd_geometry *geo;
-        struct gendisk *gendisk;
-        struct viodasd_device *d;
+        struct gendisk *disk = bdev->bd_disk;
+        struct viodasd_device *d = disk->private_data;
 
-        switch (cmd) {
-        case HDIO_GETGEO:
-                geo = (struct hd_geometry *)arg;
-                if (geo == NULL)
-                        return -EINVAL;
-                if (!access_ok(VERIFY_WRITE, geo, sizeof(*geo)))
-                        return -EFAULT;
-                gendisk = ino->i_bdev->bd_disk;
-                d = gendisk->private_data;
-                sectors = d->sectors;
-                if (sectors == 0)
-                        sectors = 32;
-                heads = d->tracks;
-                if (heads == 0)
-                        heads = 64;
-                cylinders = d->cylinders;
-                if (cylinders == 0)
-                        cylinders = get_capacity(gendisk) / (sectors * heads);
-                if (__put_user(sectors, &geo->sectors) ||
-                    __put_user(heads, &geo->heads) ||
-                    __put_user(cylinders, &geo->cylinders) ||
-                    __put_user(get_start_sect(ino->i_bdev), &geo->start))
-                        return -EFAULT;
-                return 0;
-        }
+        geo->sectors = d->sectors ? d->sectors : 0;
+        geo->heads = d->tracks ? d->tracks  : 64;
+        geo->cylinders = d->cylinders ? d->cylinders :
+                get_capacity(disk) / (geo->cylinders * geo->heads);
 
-        return -EINVAL;
+        return 0;
 }
 
 /*
@@ -293,7 +267,7 @@ static struct block_device_operations viodasd_fops = {
         .owner = THIS_MODULE,
         .open = viodasd_open,
         .release = viodasd_release,
-        .ioctl = viodasd_ioctl,
+        .getgeo = viodasd_getgeo,
 };
 
 /*
diff --git a/drivers/block/xd.c b/drivers/block/xd.c
index 68b6d7b154cf..cbce7c5e9445 100644
--- a/drivers/block/xd.c
+++ b/drivers/block/xd.c
@@ -128,9 +128,12 @@ static DEFINE_SPINLOCK(xd_lock);
 
 static struct gendisk *xd_gendisk[2];
 
+static int xd_getgeo(struct block_device *bdev, struct hd_geometry *geo);
+
 static struct block_device_operations xd_fops = {
         .owner  = THIS_MODULE,
         .ioctl  = xd_ioctl,
+        .getgeo = xd_getgeo,
 };
 static DECLARE_WAIT_QUEUE_HEAD(xd_wait_int);
 static u_char xd_drives, xd_irq = 5, xd_dma = 3, xd_maxsectors;
@@ -276,11 +279,11 @@ static u_char __init xd_detect (u_char *controller, unsigned int *address)
                 return(1);
         }
 
-        for (i = 0; i < (sizeof(xd_bases) / sizeof(xd_bases[0])); i++) {
+        for (i = 0; i < ARRAY_SIZE(xd_bases); i++) {
                 void __iomem *p = ioremap(xd_bases[i], 0x2000);
                 if (!p)
                         continue;
-                for (j = 1; j < (sizeof(xd_sigs) / sizeof(xd_sigs[0])); j++) {
+                for (j = 1; j < ARRAY_SIZE(xd_sigs); j++) {
                         const char *s = xd_sigs[j].string;
                         if (check_signature(p + xd_sigs[j].offset, s, strlen(s))) {
                                 *controller = j;
@@ -330,22 +333,20 @@ static void do_xd_request (request_queue_t * q)
         }
 }
 
+static int xd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        XD_INFO *p = bdev->bd_disk->private_data;
+
+        geo->heads = p->heads;
+        geo->sectors = p->sectors;
+        geo->cylinders = p->cylinders;
+        return 0;
+}
+
 /* xd_ioctl: handle device ioctl's */
 static int xd_ioctl (struct inode *inode,struct file *file,u_int cmd,u_long arg)
 {
-        XD_INFO *p = inode->i_bdev->bd_disk->private_data;
-
         switch (cmd) {
-                case HDIO_GETGEO:
-                {
-                        struct hd_geometry g;
-                        struct hd_geometry __user *geom= (void __user *)arg;
-                        g.heads = p->heads;
-                        g.sectors = p->sectors;
-                        g.cylinders = p->cylinders;
-                        g.start = get_start_sect(inode->i_bdev);
-                        return copy_to_user(geom, &g, sizeof(g)) ? -EFAULT : 0;
-                }
                 case HDIO_SET_DMA:
                         if (!capable(CAP_SYS_ADMIN)) return -EACCES;
                         if (xdc_busy) return -EBUSY;
@@ -1017,7 +1018,7 @@ static void __init do_xd_setup (int *integers)
                 case 2: if ((integers[2] > 0) && (integers[2] < 16))
                                 xd_irq = integers[2];
                 case 1: xd_override = 1;
-                        if ((integers[1] >= 0) && (integers[1] < (sizeof(xd_sigs) / sizeof(xd_sigs[0]))))
+                        if ((integers[1] >= 0) && (integers[1] < ARRAY_SIZE(xd_sigs)))
                                 xd_type = integers[1];
                 case 0: break;
                 default:printk("xd: too many parameters for xd\n");
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 5ebd06b1b4ca..dd7e6901c575 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -220,6 +220,14 @@ config SYNCLINKMP
           The module will be called synclinkmp.  If you want to do that, say M
           here.
 
+config SYNCLINK_GT
+        tristate "SyncLink GT/AC support"
+        depends on SERIAL_NONSTANDARD
+        help
+          Support for SyncLink GT and SyncLink AC families of
+          synchronous and asynchronous serial adapters
+          manufactured by Microgate Systems, Ltd. (www.microgate.com)
+
 config N_HDLC
         tristate "HDLC line discipline support"
         depends on SERIAL_NONSTANDARD
@@ -687,7 +695,7 @@ config NVRAM
 
 config RTC
         tristate "Enhanced Real Time Clock Support"
-        depends on !PPC32 && !PARISC && !IA64 && !M68K && (!SPARC || PCI)
+        depends on !PPC32 && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV
         ---help---
           If you say Y here and create a character special file /dev/rtc with
           major number 10 and minor number 135 using mknod ("man mknod"), you
@@ -735,7 +743,7 @@ config SGI_IP27_RTC
 
 config GEN_RTC
         tristate "Generic /dev/rtc emulation"
-        depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC
+        depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV
         ---help---
           If you say Y here and create a character special file /dev/rtc with
           major number 10 and minor number 135 using mknod ("man mknod"), you
diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index 4aeae687e88a..d973d14d8f7f 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -36,6 +36,7 @@ obj-$(CONFIG_RISCOM8)		+= riscom8.o
 obj-$(CONFIG_ISI)               += isicom.o
 obj-$(CONFIG_SYNCLINK)          += synclink.o
 obj-$(CONFIG_SYNCLINKMP)        += synclinkmp.o
+obj-$(CONFIG_SYNCLINK_GT)       += synclink_gt.o
 obj-$(CONFIG_N_HDLC)            += n_hdlc.o
 obj-$(CONFIG_AMIGA_BUILTIN_SERIAL) += amiserial.o
 obj-$(CONFIG_SX)                += sx.o generic_serial.o
diff --git a/drivers/char/agp/sworks-agp.c b/drivers/char/agp/sworks-agp.c
index 3f8f7fa6b0ff..268f78d926d3 100644
--- a/drivers/char/agp/sworks-agp.c
+++ b/drivers/char/agp/sworks-agp.c
@@ -7,6 +7,7 @@
 #include <linux/init.h>
 #include <linux/string.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 #include <linux/agp_backend.h>
 #include "agp.h"
 
diff --git a/drivers/char/hw_random.c b/drivers/char/hw_random.c
index 49769f59ea1b..b3bc2e37e616 100644
--- a/drivers/char/hw_random.c
+++ b/drivers/char/hw_random.c
@@ -169,6 +169,7 @@ static struct pci_device_id rng_pci_tbl[] = {
 
         { 0x8086, 0x2418, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
         { 0x8086, 0x2428, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
+        { 0x8086, 0x2430, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
         { 0x8086, 0x2448, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
         { 0x8086, 0x244e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
         { 0x8086, 0x245e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index 91dd669273e0..5b2d18035073 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -101,6 +101,11 @@ static inline int valid_phys_addr_range(unsigned long addr, size_t *count)
 
         return 1;
 }
+
+static inline int valid_mmap_phys_addr_range(unsigned long addr, size_t *size)
+{
+        return 1;
+}
 #endif
 
 /*
@@ -228,26 +233,36 @@ static ssize_t write_mem(struct file * file, const char __user * buf,
         return written;
 }
 
+#ifndef __HAVE_PHYS_MEM_ACCESS_PROT
+static pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
+                                     unsigned long size, pgprot_t vma_prot)
+{
+#ifdef pgprot_noncached
+        unsigned long offset = pfn << PAGE_SHIFT;
+
+        if (uncached_access(file, offset))
+                return pgprot_noncached(vma_prot);
+#endif
+        return vma_prot;
+}
+#endif
+
 static int mmap_mem(struct file * file, struct vm_area_struct * vma)
 {
-#if defined(__HAVE_PHYS_MEM_ACCESS_PROT)
+        size_t size = vma->vm_end - vma->vm_start;
+
+        if (!valid_mmap_phys_addr_range(vma->vm_pgoff << PAGE_SHIFT, &size))
+                return -EINVAL;
+
         vma->vm_page_prot = phys_mem_access_prot(file, vma->vm_pgoff,
-                                                 vma->vm_end - vma->vm_start,
+                                                 size,
                                                  vma->vm_page_prot);
-#elif defined(pgprot_noncached)
-        unsigned long offset = vma->vm_pgoff << PAGE_SHIFT;
-        int uncached;
-
-        uncached = uncached_access(file, offset);
-        if (uncached)
-                vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
-#endif
 
         /* Remap-pfn-range will mark the range VM_IO and VM_RESERVED */
         if (remap_pfn_range(vma,
                             vma->vm_start,
                             vma->vm_pgoff,
-                            vma->vm_end-vma->vm_start,
+                            size,
                             vma->vm_page_prot))
                 return -EAGAIN;
         return 0;
@@ -817,7 +832,7 @@ static ssize_t kmsg_write(struct file * file, const char __user * buf,
                           size_t count, loff_t *ppos)
 {
         char *tmp;
-        int ret;
+        ssize_t ret;
 
         tmp = kmalloc(count + 1, GFP_KERNEL);
         if (tmp == NULL)
@@ -826,6 +841,9 @@ static ssize_t kmsg_write(struct file * file, const char __user * buf,
         if (!copy_from_user(tmp, buf, count)) {
                 tmp[count] = 0;
                 ret = printk("%s", tmp);
+                if (ret > count)
+                        /* printk can add a prefix */
+                        ret = count;
         }
         kfree(tmp);
         return ret;
diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
index 51a07370e636..f8dd8527c6aa 100644
--- a/drivers/char/sonypi.c
+++ b/drivers/char/sonypi.c
@@ -471,7 +471,6 @@ struct sonypi_keypress {
 
 static struct sonypi_device {
         struct pci_dev *dev;
-        struct platform_device *pdev;
         u16 irq;
         u16 bits;
         u16 ioport1;
@@ -511,6 +510,11 @@ static struct sonypi_device {
 #define SONYPI_ACPI_ACTIVE 0
 #endif                          /* CONFIG_ACPI */
 
+#ifdef CONFIG_ACPI
+static struct acpi_device *sonypi_acpi_device;
+static int acpi_enabled;
+#endif
+
 static int sonypi_ec_write(u8 addr, u8 value)
 {
 #ifdef CONFIG_ACPI_EC
@@ -864,6 +868,11 @@ found:
         if (useinput)
                 sonypi_report_input_event(event);
 
+#ifdef CONFIG_ACPI
+        if (acpi_enabled)
+                acpi_bus_generate_event(sonypi_acpi_device, 1, event);
+#endif
+
         kfifo_put(sonypi_device.fifo, (unsigned char *)&event, sizeof(event));
         kill_fasync(&sonypi_device.fifo_async, SIGIO, POLL_IN);
         wake_up_interruptible(&sonypi_device.fifo_proc_list);
@@ -1165,45 +1174,38 @@ static int sonypi_disable(void)
         return 0;
 }
 
-#ifdef CONFIG_PM
-static int old_camera_power;
-
-static int sonypi_suspend(struct platform_device *dev, pm_message_t state)
+#ifdef CONFIG_ACPI
+static int sonypi_acpi_add(struct acpi_device *device)
 {
-        old_camera_power = sonypi_device.camera_power;
-        sonypi_disable();
-
+        sonypi_acpi_device = device;
+        strcpy(acpi_device_name(device), "Sony laptop hotkeys");
+        strcpy(acpi_device_class(device), "sony/hotkey");
         return 0;
 }
 
-static int sonypi_resume(struct platform_device *dev)
+static int sonypi_acpi_remove(struct acpi_device *device, int type)
 {
-        sonypi_enable(old_camera_power);
+        sonypi_acpi_device = NULL;
         return 0;
 }
-#endif
-
-static void sonypi_shutdown(struct platform_device *dev)
-{
-        sonypi_disable();
-}
 
-static struct platform_driver sonypi_driver = {
-#ifdef CONFIG_PM
-        .suspend        = sonypi_suspend,
-        .resume         = sonypi_resume,
-#endif
-        .shutdown       = sonypi_shutdown,
-        .driver         = {
-                .name   = "sonypi",
+static struct acpi_driver sonypi_acpi_driver = {
+        .name           = "sonypi",
+        .class          = "hkey",
+        .ids            = "SNY6001",
+        .ops            = {
+                           .add = sonypi_acpi_add,
+                           .remove = sonypi_acpi_remove,
         },
 };
+#endif
 
 static int __devinit sonypi_create_input_devices(void)
 {
         struct input_dev *jog_dev;
         struct input_dev *key_dev;
         int i;
+        int error;
 
         sonypi_device.input_jog_dev = jog_dev = input_allocate_device();
         if (!jog_dev)
@@ -1219,9 +1221,8 @@ static int __devinit sonypi_create_input_devices(void)
 
         sonypi_device.input_key_dev = key_dev = input_allocate_device();
         if (!key_dev) {
-                input_free_device(jog_dev);
-                sonypi_device.input_jog_dev = NULL;
-                return -ENOMEM;
+                error = -ENOMEM;
+                goto err_free_jogdev;
         }
 
         key_dev->name = "Sony Vaio Keys";
@@ -1234,56 +1235,122 @@ static int __devinit sonypi_create_input_devices(void)
                 if (sonypi_inputkeys[i].inputev)
                         set_bit(sonypi_inputkeys[i].inputev, key_dev->keybit);
 
-        input_register_device(jog_dev);
-        input_register_device(key_dev);
+        error = input_register_device(jog_dev);
+        if (error)
+                goto err_free_keydev;
+
+        error = input_register_device(key_dev);
+        if (error)
+                goto err_unregister_jogdev;
 
         return 0;
+
+ err_unregister_jogdev:
+        input_unregister_device(jog_dev);
+        /* Set to NULL so we don't free it again below */
+        jog_dev = NULL;
+ err_free_keydev:
+        input_free_device(key_dev);
+        sonypi_device.input_key_dev = NULL;
+ err_free_jogdev:
+        input_free_device(jog_dev);
+        sonypi_device.input_jog_dev = NULL;
+
+        return error;
 }
 
-static int __devinit sonypi_probe(void)
+static int __devinit sonypi_setup_ioports(struct sonypi_device *dev,
+                                const struct sonypi_ioport_list *ioport_list)
 {
-        int i, ret;
-        struct sonypi_ioport_list *ioport_list;
-        struct sonypi_irq_list *irq_list;
-        struct pci_dev *pcidev;
+        while (ioport_list->port1) {
 
-        if ((pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
-                                     PCI_DEVICE_ID_INTEL_82371AB_3, NULL)))
-                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE1;
-        else if ((pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
-                                          PCI_DEVICE_ID_INTEL_ICH6_1, NULL)))
-                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE3;
-        else
-                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE2;
+                if (request_region(ioport_list->port1,
+                                   sonypi_device.region_size,
+                                   "Sony Programable I/O Device")) {
+                        dev->ioport1 = ioport_list->port1;
+                        dev->ioport2 = ioport_list->port2;
+                        return 0;
+                }
+                ioport_list++;
+        }
 
-        sonypi_device.dev = pcidev;
+        return -EBUSY;
+}
+
+static int __devinit sonypi_setup_irq(struct sonypi_device *dev,
+                                      const struct sonypi_irq_list *irq_list)
+{
+        while (irq_list->irq) {
+
+                if (!request_irq(irq_list->irq, sonypi_irq,
+                                 SA_SHIRQ, "sonypi", sonypi_irq)) {
+                        dev->irq = irq_list->irq;
+                        dev->bits = irq_list->bits;
+                        return 0;
+                }
+                irq_list++;
+        }
+
+        return -EBUSY;
+}
+
+static void __devinit sonypi_display_info(void)
+{
+        printk(KERN_INFO "sonypi: detected type%d model, "
+               "verbose = %d, fnkeyinit = %s, camera = %s, "
+               "compat = %s, mask = 0x%08lx, useinput = %s, acpi = %s\n",
+               sonypi_device.model,
+               verbose,
+               fnkeyinit ? "on" : "off",
+               camera ? "on" : "off",
+               compat ? "on" : "off",
+               mask,
+               useinput ? "on" : "off",
+               SONYPI_ACPI_ACTIVE ? "on" : "off");
+        printk(KERN_INFO "sonypi: enabled at irq=%d, port1=0x%x, port2=0x%x\n",
+               sonypi_device.irq,
+               sonypi_device.ioport1, sonypi_device.ioport2);
+
+        if (minor == -1)
+                printk(KERN_INFO "sonypi: device allocated minor is %d\n",
+                       sonypi_misc_device.minor);
+}
+
+static int __devinit sonypi_probe(struct platform_device *dev)
+{
+        const struct sonypi_ioport_list *ioport_list;
+        const struct sonypi_irq_list *irq_list;
+        struct pci_dev *pcidev;
+        int error;
 
         spin_lock_init(&sonypi_device.fifo_lock);
         sonypi_device.fifo = kfifo_alloc(SONYPI_BUF_SIZE, GFP_KERNEL,
                                          &sonypi_device.fifo_lock);
         if (IS_ERR(sonypi_device.fifo)) {
                 printk(KERN_ERR "sonypi: kfifo_alloc failed\n");
-                ret = PTR_ERR(sonypi_device.fifo);
-                goto out_fifo;
+                return PTR_ERR(sonypi_device.fifo);
         }
 
         init_waitqueue_head(&sonypi_device.fifo_proc_list);
         init_MUTEX(&sonypi_device.lock);
         sonypi_device.bluetooth_power = -1;
 
+        if ((pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
+                                     PCI_DEVICE_ID_INTEL_82371AB_3, NULL)))
+                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE1;
+        else if ((pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
+                                          PCI_DEVICE_ID_INTEL_ICH6_1, NULL)))
+                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE3;
+        else
+                sonypi_device.model = SONYPI_DEVICE_MODEL_TYPE2;
+
         if (pcidev && pci_enable_device(pcidev)) {
                 printk(KERN_ERR "sonypi: pci_enable_device failed\n");
-                ret = -EIO;
-                goto out_pcienable;
-        }
-
-        if (minor != -1)
-                sonypi_misc_device.minor = minor;
-        if ((ret = misc_register(&sonypi_misc_device))) {
-                printk(KERN_ERR "sonypi: misc_register failed\n");
-                goto out_miscreg;
+                error = -EIO;
+                goto err_put_pcidev;
         }
 
+        sonypi_device.dev = pcidev;
 
         if (sonypi_device.model == SONYPI_DEVICE_MODEL_TYPE1) {
                 ioport_list = sonypi_type1_ioport_list;
@@ -1302,43 +1369,36 @@ static int __devinit sonypi_probe(void)
                 irq_list = sonypi_type3_irq_list;
         }
 
-        for (i = 0; ioport_list[i].port1; i++) {
-                if (request_region(ioport_list[i].port1,
-                                   sonypi_device.region_size,
-                                   "Sony Programable I/O Device")) {
-                        /* get the ioport */
-                        sonypi_device.ioport1 = ioport_list[i].port1;
-                        sonypi_device.ioport2 = ioport_list[i].port2;
-                        break;
-                }
-        }
-        if (!sonypi_device.ioport1) {
-                printk(KERN_ERR "sonypi: request_region failed\n");
-                ret = -ENODEV;
-                goto out_reqreg;
+        error = sonypi_setup_ioports(&sonypi_device, ioport_list);
+        if (error) {
+                printk(KERN_ERR "sonypi: failed to request ioports\n");
+                goto err_disable_pcidev;
         }
 
-        for (i = 0; irq_list[i].irq; i++) {
-
-                sonypi_device.irq = irq_list[i].irq;
-                sonypi_device.bits = irq_list[i].bits;
-
-                if (!request_irq(sonypi_device.irq, sonypi_irq,
-                                 SA_SHIRQ, "sonypi", sonypi_irq))
-                        break;
+        error = sonypi_setup_irq(&sonypi_device, irq_list);
+        if (error) {
+                printk(KERN_ERR "sonypi: request_irq failed\n");
+                goto err_free_ioports;
         }
 
-        if (!irq_list[i].irq) {
-                printk(KERN_ERR "sonypi: request_irq failed\n");
-                ret = -ENODEV;
-                goto out_reqirq;
+        if (minor != -1)
+                sonypi_misc_device.minor = minor;
+        error = misc_register(&sonypi_misc_device);
+        if (error) {
+                printk(KERN_ERR "sonypi: misc_register failed\n");
+                goto err_free_irq;
         }
 
+        sonypi_display_info();
+
         if (useinput) {
 
-                ret = sonypi_create_input_devices();
-                if (ret)
-                        goto out_inputdevices;
+                error = sonypi_create_input_devices();
+                if (error) {
+                        printk(KERN_ERR
+                                "sonypi: failed to create input devices\n");
+                        goto err_miscdev_unregister;
+                }
 
                 spin_lock_init(&sonypi_device.input_fifo_lock);
                 sonypi_device.input_fifo =
@@ -1346,91 +1406,104 @@ static int __devinit sonypi_probe(void)
                                     &sonypi_device.input_fifo_lock);
                 if (IS_ERR(sonypi_device.input_fifo)) {
                         printk(KERN_ERR "sonypi: kfifo_alloc failed\n");
-                        ret = PTR_ERR(sonypi_device.input_fifo);
-                        goto out_infifo;
+                        error = PTR_ERR(sonypi_device.input_fifo);
+                        goto err_inpdev_unregister;
                 }
 
                 INIT_WORK(&sonypi_device.input_work, input_keyrelease, NULL);
         }
 
-        sonypi_device.pdev = platform_device_register_simple("sonypi", -1,
-                                                             NULL, 0);
-        if (IS_ERR(sonypi_device.pdev)) {
-                ret = PTR_ERR(sonypi_device.pdev);
-                goto out_platformdev;
-        }
-
         sonypi_enable(0);
 
-        printk(KERN_INFO "sonypi: Sony Programmable I/O Controller Driver"
-               "v%s.\n", SONYPI_DRIVER_VERSION);
-        printk(KERN_INFO "sonypi: detected type%d model, "
-               "verbose = %d, fnkeyinit = %s, camera = %s, "
-               "compat = %s, mask = 0x%08lx, useinput = %s, acpi = %s\n",
-               sonypi_device.model,
-               verbose,
-               fnkeyinit ? "on" : "off",
-               camera ? "on" : "off",
-               compat ? "on" : "off",
-               mask,
-               useinput ? "on" : "off",
-               SONYPI_ACPI_ACTIVE ? "on" : "off");
-        printk(KERN_INFO "sonypi: enabled at irq=%d, port1=0x%x, port2=0x%x\n",
-               sonypi_device.irq,
-               sonypi_device.ioport1, sonypi_device.ioport2);
-
-        if (minor == -1)
-                printk(KERN_INFO "sonypi: device allocated minor is %d\n",
-                       sonypi_misc_device.minor);
-
         return 0;
 
-out_platformdev:
-        kfifo_free(sonypi_device.input_fifo);
-out_infifo:
+ err_inpdev_unregister:
         input_unregister_device(sonypi_device.input_key_dev);
         input_unregister_device(sonypi_device.input_jog_dev);
-out_inputdevices:
+ err_miscdev_unregister:
+        misc_deregister(&sonypi_misc_device);
+ err_free_irq:
         free_irq(sonypi_device.irq, sonypi_irq);
-out_reqirq:
+ err_free_ioports:
         release_region(sonypi_device.ioport1, sonypi_device.region_size);
-out_reqreg:
-        misc_deregister(&sonypi_misc_device);
-out_miscreg:
+ err_disable_pcidev:
         if (pcidev)
                 pci_disable_device(pcidev);
-out_pcienable:
+ err_put_pcidev:
+        pci_dev_put(pcidev);
         kfifo_free(sonypi_device.fifo);
-out_fifo:
-        pci_dev_put(sonypi_device.dev);
-        return ret;
+
+        return error;
 }
 
-static void __devexit sonypi_remove(void)
+static int __devexit sonypi_remove(struct platform_device *dev)
 {
         sonypi_disable();
 
         synchronize_sched();  /* Allow sonypi interrupt to complete. */
         flush_scheduled_work();
 
-        platform_device_unregister(sonypi_device.pdev);
-
         if (useinput) {
                 input_unregister_device(sonypi_device.input_key_dev);
                 input_unregister_device(sonypi_device.input_jog_dev);
                 kfifo_free(sonypi_device.input_fifo);
         }
 
+        misc_deregister(&sonypi_misc_device);
+
         free_irq(sonypi_device.irq, sonypi_irq);
         release_region(sonypi_device.ioport1, sonypi_device.region_size);
-        misc_deregister(&sonypi_misc_device);
-        if (sonypi_device.dev)
+
+        if (sonypi_device.dev) {
                 pci_disable_device(sonypi_device.dev);
+                pci_dev_put(sonypi_device.dev);
+        }
+
         kfifo_free(sonypi_device.fifo);
-        pci_dev_put(sonypi_device.dev);
-        printk(KERN_INFO "sonypi: removed.\n");
+
+        return 0;
 }
 
+#ifdef CONFIG_PM
+static int old_camera_power;
+
+static int sonypi_suspend(struct platform_device *dev, pm_message_t state)
+{
+        old_camera_power = sonypi_device.camera_power;
+        sonypi_disable();
+
+        return 0;
+}
+
+static int sonypi_resume(struct platform_device *dev)
+{
+        sonypi_enable(old_camera_power);
+        return 0;
+}
+#else
+#define sonypi_suspend  NULL
+#define sonypi_resume   NULL
+#endif
+
+static void sonypi_shutdown(struct platform_device *dev)
+{
+        sonypi_disable();
+}
+
+static struct platform_driver sonypi_driver = {
+        .driver         = {
+                .name   = "sonypi",
+                .owner  = THIS_MODULE,
+        },
+        .probe          = sonypi_probe,
+        .remove         = __devexit_p(sonypi_remove),
+        .shutdown       = sonypi_shutdown,
+        .suspend        = sonypi_suspend,
+        .resume         = sonypi_resume,
+};
+
+static struct platform_device *sonypi_platform_device;
+
 static struct dmi_system_id __initdata sonypi_dmi_table[] = {
         {
                 .ident = "Sony Vaio",
@@ -1451,26 +1524,52 @@ static struct dmi_system_id __initdata sonypi_dmi_table[] = {
 
 static int __init sonypi_init(void)
 {
-        int ret;
+        int error;
+
+        printk(KERN_INFO
+                "sonypi: Sony Programmable I/O Controller Driver v%s.\n",
+                SONYPI_DRIVER_VERSION);
 
         if (!dmi_check_system(sonypi_dmi_table))
                 return -ENODEV;
 
-        ret = platform_driver_register(&sonypi_driver);
-        if (ret)
-                return ret;
+        error = platform_driver_register(&sonypi_driver);
+        if (error)
+                return error;
 
-        ret = sonypi_probe();
-        if (ret)
-                platform_driver_unregister(&sonypi_driver);
+        sonypi_platform_device = platform_device_alloc("sonypi", -1);
+        if (!sonypi_platform_device) {
+                error = -ENOMEM;
+                goto err_driver_unregister;
+        }
 
-        return ret;
+        error = platform_device_add(sonypi_platform_device);
+        if (error)
+                goto err_free_device;
+
+#ifdef CONFIG_ACPI
+        if (acpi_bus_register_driver(&sonypi_acpi_driver) > 0)
+                acpi_enabled = 1;
+#endif
+
+        return 0;
+
+ err_free_device:
+        platform_device_put(sonypi_platform_device);
+ err_driver_unregister:
+        platform_driver_unregister(&sonypi_driver);
+        return error;
 }
 
 static void __exit sonypi_exit(void)
 {
+#ifdef CONFIG_ACPI
+        if (acpi_enabled)
+                acpi_bus_unregister_driver(&sonypi_acpi_driver);
+#endif
+        platform_device_unregister(sonypi_platform_device);
         platform_driver_unregister(&sonypi_driver);
-        sonypi_remove();
+        printk(KERN_INFO "sonypi: removed.\n");
 }
 
 module_init(sonypi_init);
diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
new file mode 100644
index 000000000000..2b9cde94e2f7
--- /dev/null
+++ b/drivers/char/synclink_gt.c
@@ -0,0 +1,4501 @@
+/*
+ * $Id: synclink_gt.c,v 4.20 2005/11/08 19:51:55 paulkf Exp $
+ *
+ * Device driver for Microgate SyncLink GT serial adapters.
+ *
+ * written by Paul Fulghum for Microgate Corporation
+ * paulkf@microgate.com
+ *
+ * Microgate and SyncLink are trademarks of Microgate Corporation
+ *
+ * This code is released under the GNU General Public License (GPL)
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT,
+ * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/*
+ * DEBUG OUTPUT DEFINITIONS
+ *
+ * uncomment lines below to enable specific types of debug output
+ *
+ * DBGINFO   information - most verbose output
+ * DBGERR    serious errors
+ * DBGBH     bottom half service routine debugging
+ * DBGISR    interrupt service routine debugging
+ * DBGDATA   output receive and transmit data
+ * DBGTBUF   output transmit DMA buffers and registers
+ * DBGRBUF   output receive DMA buffers and registers
+ */
+
+#define DBGINFO(fmt) if (debug_level >= DEBUG_LEVEL_INFO) printk fmt
+#define DBGERR(fmt) if (debug_level >= DEBUG_LEVEL_ERROR) printk fmt
+#define DBGBH(fmt) if (debug_level >= DEBUG_LEVEL_BH) printk fmt
+#define DBGISR(fmt) if (debug_level >= DEBUG_LEVEL_ISR) printk fmt
+#define DBGDATA(info, buf, size, label) if (debug_level >= DEBUG_LEVEL_DATA) trace_block((info), (buf), (size), (label))
+//#define DBGTBUF(info) dump_tbufs(info)
+//#define DBGRBUF(info) dump_rbufs(info)
+
+
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/version.h>
+#include <linux/errno.h>
+#include <linux/signal.h>
+#include <linux/sched.h>
+#include <linux/timer.h>
+#include <linux/interrupt.h>
+#include <linux/pci.h>
+#include <linux/tty.h>
+#include <linux/tty_flip.h>
+#include <linux/serial.h>
+#include <linux/major.h>
+#include <linux/string.h>
+#include <linux/fcntl.h>
+#include <linux/ptrace.h>
+#include <linux/ioport.h>
+#include <linux/mm.h>
+#include <linux/slab.h>
+#include <linux/netdevice.h>
+#include <linux/vmalloc.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/ioctl.h>
+#include <linux/termios.h>
+#include <linux/bitops.h>
+#include <linux/workqueue.h>
+#include <linux/hdlc.h>
+
+#include <asm/serial.h>
+#include <asm/system.h>
+#include <asm/io.h>
+#include <asm/irq.h>
+#include <asm/dma.h>
+#include <asm/types.h>
+#include <asm/uaccess.h>
+
+#include "linux/synclink.h"
+
+#ifdef CONFIG_HDLC_MODULE
+#define CONFIG_HDLC 1
+#endif
+
+/*
+ * module identification
+ */
+static char *driver_name     = "SyncLink GT";
+static char *driver_version  = "$Revision: 4.20 $";
+static char *tty_driver_name = "synclink_gt";
+static char *tty_dev_prefix  = "ttySLG";
+MODULE_LICENSE("GPL");
+#define MGSL_MAGIC 0x5401
+#define MAX_DEVICES 12
+
+static struct pci_device_id pci_table[] = {
+        {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
+        {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT4_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
+        {PCI_VENDOR_ID_MICROGATE, SYNCLINK_AC_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
+        {0,}, /* terminate list */
+};
+MODULE_DEVICE_TABLE(pci, pci_table);
+
+static int  init_one(struct pci_dev *dev,const struct pci_device_id *ent);
+static void remove_one(struct pci_dev *dev);
+static struct pci_driver pci_driver = {
+        .name           = "synclink_gt",
+        .id_table       = pci_table,
+        .probe          = init_one,
+        .remove         = __devexit_p(remove_one),
+};
+
+static int pci_registered;
+
+/*
+ * module configuration and status
+ */
+static struct slgt_info *slgt_device_list;
+static int slgt_device_count;
+
+static int ttymajor;
+static int debug_level;
+static int maxframe[MAX_DEVICES];
+static int dosyncppp[MAX_DEVICES];
+
+module_param(ttymajor, int, 0);
+module_param(debug_level, int, 0);
+module_param_array(maxframe, int, NULL, 0);
+module_param_array(dosyncppp, int, NULL, 0);
+
+MODULE_PARM_DESC(ttymajor, "TTY major device number override: 0=auto assigned");
+MODULE_PARM_DESC(debug_level, "Debug syslog output: 0=disabled, 1 to 5=increasing detail");
+MODULE_PARM_DESC(maxframe, "Maximum frame size used by device (4096 to 65535)");
+MODULE_PARM_DESC(dosyncppp, "Enable synchronous net device, 0=disable 1=enable");
+
+/*
+ * tty support and callbacks
+ */
+#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
+
+static struct tty_driver *serial_driver;
+
+static int  open(struct tty_struct *tty, struct file * filp);
+static void close(struct tty_struct *tty, struct file * filp);
+static void hangup(struct tty_struct *tty);
+static void set_termios(struct tty_struct *tty, struct termios *old_termios);
+
+static int  write(struct tty_struct *tty, const unsigned char *buf, int count);
+static void put_char(struct tty_struct *tty, unsigned char ch);
+static void send_xchar(struct tty_struct *tty, char ch);
+static void wait_until_sent(struct tty_struct *tty, int timeout);
+static int  write_room(struct tty_struct *tty);
+static void flush_chars(struct tty_struct *tty);
+static void flush_buffer(struct tty_struct *tty);
+static void tx_hold(struct tty_struct *tty);
+static void tx_release(struct tty_struct *tty);
+
+static int  ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg);
+static int  read_proc(char *page, char **start, off_t off, int count,int *eof, void *data);
+static int  chars_in_buffer(struct tty_struct *tty);
+static void throttle(struct tty_struct * tty);
+static void unthrottle(struct tty_struct * tty);
+static void set_break(struct tty_struct *tty, int break_state);
+
+/*
+ * generic HDLC support and callbacks
+ */
+#ifdef CONFIG_HDLC
+#define dev_to_port(D) (dev_to_hdlc(D)->priv)
+static void hdlcdev_tx_done(struct slgt_info *info);
+static void hdlcdev_rx(struct slgt_info *info, char *buf, int size);
+static int  hdlcdev_init(struct slgt_info *info);
+static void hdlcdev_exit(struct slgt_info *info);
+#endif
+
+
+/*
+ * device specific structures, macros and functions
+ */
+
+#define SLGT_MAX_PORTS 4
+#define SLGT_REG_SIZE  256
+
+/*
+ * DMA buffer descriptor and access macros
+ */
+struct slgt_desc
+{
+        unsigned short count;
+        unsigned short status;
+        unsigned int pbuf;  /* physical address of data buffer */
+        unsigned int next;  /* physical address of next descriptor */
+
+        /* driver book keeping */
+        char *buf;          /* virtual  address of data buffer */
+        unsigned int pdesc; /* physical address of this descriptor */
+        dma_addr_t buf_dma_addr;
+};
+
+#define set_desc_buffer(a,b) (a).pbuf = cpu_to_le32((unsigned int)(b))
+#define set_desc_next(a,b) (a).next   = cpu_to_le32((unsigned int)(b))
+#define set_desc_count(a,b)(a).count  = cpu_to_le16((unsigned short)(b))
+#define set_desc_eof(a,b)  (a).status = cpu_to_le16((b) ? (le16_to_cpu((a).status) | BIT0) : (le16_to_cpu((a).status) & ~BIT0))
+#define desc_count(a)      (le16_to_cpu((a).count))
+#define desc_status(a)     (le16_to_cpu((a).status))
+#define desc_complete(a)   (le16_to_cpu((a).status) & BIT15)
+#define desc_eof(a)        (le16_to_cpu((a).status) & BIT2)
+#define desc_crc_error(a)  (le16_to_cpu((a).status) & BIT1)
+#define desc_abort(a)      (le16_to_cpu((a).status) & BIT0)
+#define desc_residue(a)    ((le16_to_cpu((a).status) & 0x38) >> 3)
+
+struct _input_signal_events {
+        int ri_up;
+        int ri_down;
+        int dsr_up;
+        int dsr_down;
+        int dcd_up;
+        int dcd_down;
+        int cts_up;
+        int cts_down;
+};
+
+/*
+ * device instance data structure
+ */
+struct slgt_info {
+        void *if_ptr;           /* General purpose pointer (used by SPPP) */
+
+        struct slgt_info *next_device;  /* device list link */
+
+        int magic;
+        int flags;
+
+        char device_name[25];
+        struct pci_dev *pdev;
+
+        int port_count;  /* count of ports on adapter */
+        int adapter_num; /* adapter instance number */
+        int port_num;    /* port instance number */
+
+        /* array of pointers to port contexts on this adapter */
+        struct slgt_info *port_array[SLGT_MAX_PORTS];
+
+        int                     count;          /* count of opens */
+        int                     line;           /* tty line instance number */
+        unsigned short          close_delay;
+        unsigned short          closing_wait;   /* time to wait before closing */
+
+        struct mgsl_icount      icount;
+
+        struct tty_struct       *tty;
+        int                     timeout;
+        int                     x_char;         /* xon/xoff character */
+        int                     blocked_open;   /* # of blocked opens */
+        unsigned int            read_status_mask;
+        unsigned int            ignore_status_mask;
+
+        wait_queue_head_t       open_wait;
+        wait_queue_head_t       close_wait;
+
+        wait_queue_head_t       status_event_wait_q;
+        wait_queue_head_t       event_wait_q;
+        struct timer_list       tx_timer;
+        struct timer_list       rx_timer;
+
+        spinlock_t lock;        /* spinlock for synchronizing with ISR */
+
+        struct work_struct task;
+        u32 pending_bh;
+        int bh_requested;
+        int bh_running;
+
+        int isr_overflow;
+        int irq_requested;      /* nonzero if IRQ requested */
+        int irq_occurred;       /* for diagnostics use */
+
+        /* device configuration */
+
+        unsigned int bus_type;
+        unsigned int irq_level;
+        unsigned long irq_flags;
+
+        unsigned char __iomem * reg_addr;  /* memory mapped registers address */
+        u32 phys_reg_addr;
+        u32 reg_offset;
+        int reg_addr_requested;
+
+        MGSL_PARAMS params;       /* communications parameters */
+        u32 idle_mode;
+        u32 max_frame_size;       /* as set by device config */
+
+        unsigned int raw_rx_size;
+        unsigned int if_mode;
+
+        /* device status */
+
+        int rx_enabled;
+        int rx_restart;
+
+        int tx_enabled;
+        int tx_active;
+
+        unsigned char signals;    /* serial signal states */
+        unsigned int init_error;  /* initialization error */
+
+        unsigned char *tx_buf;
+        int tx_count;
+
+        char flag_buf[MAX_ASYNC_BUFFER_SIZE];
+        char char_buf[MAX_ASYNC_BUFFER_SIZE];
+        BOOLEAN drop_rts_on_tx_done;
+        struct  _input_signal_events    input_signal_events;
+
+        int dcd_chkcount;       /* check counts to prevent */
+        int cts_chkcount;       /* too many IRQs if a signal */
+        int dsr_chkcount;       /* is floating */
+        int ri_chkcount;
+
+        char *bufs;             /* virtual address of DMA buffer lists */
+        dma_addr_t bufs_dma_addr; /* physical address of buffer descriptors */
+
+        unsigned int rbuf_count;
+        struct slgt_desc *rbufs;
+        unsigned int rbuf_current;
+        unsigned int rbuf_index;
+
+        unsigned int tbuf_count;
+        struct slgt_desc *tbufs;
+        unsigned int tbuf_current;
+        unsigned int tbuf_start;
+
+        unsigned char *tmp_rbuf;
+        unsigned int tmp_rbuf_count;
+
+        /* SPPP/Cisco HDLC device parts */
+
+        int netcount;
+        int dosyncppp;
+        spinlock_t netlock;
+#ifdef CONFIG_HDLC
+        struct net_device *netdev;
+#endif
+
+};
+
+static MGSL_PARAMS default_params = {
+        .mode            = MGSL_MODE_HDLC,
+        .loopback        = 0,
+        .flags           = HDLC_FLAG_UNDERRUN_ABORT15,
+        .encoding        = HDLC_ENCODING_NRZI_SPACE,
+        .clock_speed     = 0,
+        .addr_filter     = 0xff,
+        .crc_type        = HDLC_CRC_16_CCITT,
+        .preamble_length = HDLC_PREAMBLE_LENGTH_8BITS,
+        .preamble        = HDLC_PREAMBLE_PATTERN_NONE,
+        .data_rate       = 9600,
+        .data_bits       = 8,
+        .stop_bits       = 1,
+        .parity          = ASYNC_PARITY_NONE
+};
+
+
+#define BH_RECEIVE  1
+#define BH_TRANSMIT 2
+#define BH_STATUS   4
+#define IO_PIN_SHUTDOWN_LIMIT 100
+
+#define DMABUFSIZE 256
+#define DESC_LIST_SIZE 4096
+
+#define MASK_PARITY  BIT1
+#define MASK_FRAMING BIT2
+#define MASK_BREAK   BIT3
+#define MASK_OVERRUN BIT4
+
+#define GSR   0x00 /* global status */
+#define TDR   0x80 /* tx data */
+#define RDR   0x80 /* rx data */
+#define TCR   0x82 /* tx control */
+#define TIR   0x84 /* tx idle */
+#define TPR   0x85 /* tx preamble */
+#define RCR   0x86 /* rx control */
+#define VCR   0x88 /* V.24 control */
+#define CCR   0x89 /* clock control */
+#define BDR   0x8a /* baud divisor */
+#define SCR   0x8c /* serial control */
+#define SSR   0x8e /* serial status */
+#define RDCSR 0x90 /* rx DMA control/status */
+#define TDCSR 0x94 /* tx DMA control/status */
+#define RDDAR 0x98 /* rx DMA descriptor address */
+#define TDDAR 0x9c /* tx DMA descriptor address */
+
+#define RXIDLE      BIT14
+#define RXBREAK     BIT14
+#define IRQ_TXDATA  BIT13
+#define IRQ_TXIDLE  BIT12
+#define IRQ_TXUNDER BIT11 /* HDLC */
+#define IRQ_RXDATA  BIT10
+#define IRQ_RXIDLE  BIT9  /* HDLC */
+#define IRQ_RXBREAK BIT9  /* async */
+#define IRQ_RXOVER  BIT8
+#define IRQ_DSR     BIT7
+#define IRQ_CTS     BIT6
+#define IRQ_DCD     BIT5
+#define IRQ_RI      BIT4
+#define IRQ_ALL     0x3ff0
+#define IRQ_MASTER  BIT0
+
+#define slgt_irq_on(info, mask) \
+        wr_reg16((info), SCR, (unsigned short)(rd_reg16((info), SCR) | (mask)))
+#define slgt_irq_off(info, mask) \
+        wr_reg16((info), SCR, (unsigned short)(rd_reg16((info), SCR) & ~(mask)))
+
+static __u8  rd_reg8(struct slgt_info *info, unsigned int addr);
+static void  wr_reg8(struct slgt_info *info, unsigned int addr, __u8 value);
+static __u16 rd_reg16(struct slgt_info *info, unsigned int addr);
+static void  wr_reg16(struct slgt_info *info, unsigned int addr, __u16 value);
+static __u32 rd_reg32(struct slgt_info *info, unsigned int addr);
+static void  wr_reg32(struct slgt_info *info, unsigned int addr, __u32 value);
+
+static void  msc_set_vcr(struct slgt_info *info);
+
+static int  startup(struct slgt_info *info);
+static int  block_til_ready(struct tty_struct *tty, struct file * filp,struct slgt_info *info);
+static void shutdown(struct slgt_info *info);
+static void program_hw(struct slgt_info *info);
+static void change_params(struct slgt_info *info);
+
+static int  register_test(struct slgt_info *info);
+static int  irq_test(struct slgt_info *info);
+static int  loopback_test(struct slgt_info *info);
+static int  adapter_test(struct slgt_info *info);
+
+static void reset_adapter(struct slgt_info *info);
+static void reset_port(struct slgt_info *info);
+static void async_mode(struct slgt_info *info);
+static void hdlc_mode(struct slgt_info *info);
+
+static void rx_stop(struct slgt_info *info);
+static void rx_start(struct slgt_info *info);
+static void reset_rbufs(struct slgt_info *info);
+static void free_rbufs(struct slgt_info *info, unsigned int first, unsigned int last);
+static void rdma_reset(struct slgt_info *info);
+static int  rx_get_frame(struct slgt_info *info);
+static int  rx_get_buf(struct slgt_info *info);
+
+static void tx_start(struct slgt_info *info);
+static void tx_stop(struct slgt_info *info);
+static void tx_set_idle(struct slgt_info *info);
+static unsigned int free_tbuf_count(struct slgt_info *info);
+static void reset_tbufs(struct slgt_info *info);
+static void tdma_reset(struct slgt_info *info);
+static void tx_load(struct slgt_info *info, const char *buf, unsigned int count);
+
+static void get_signals(struct slgt_info *info);
+static void set_signals(struct slgt_info *info);
+static void enable_loopback(struct slgt_info *info);
+static void set_rate(struct slgt_info *info, u32 data_rate);
+
+static int  bh_action(struct slgt_info *info);
+static void bh_handler(void* context);
+static void bh_transmit(struct slgt_info *info);
+static void isr_serial(struct slgt_info *info);
+static void isr_rdma(struct slgt_info *info);
+static void isr_txeom(struct slgt_info *info, unsigned short status);
+static void isr_tdma(struct slgt_info *info);
+static irqreturn_t slgt_interrupt(int irq, void *dev_id, struct pt_regs * regs);
+
+static int  alloc_dma_bufs(struct slgt_info *info);
+static void free_dma_bufs(struct slgt_info *info);
+static int  alloc_desc(struct slgt_info *info);
+static void free_desc(struct slgt_info *info);
+static int  alloc_bufs(struct slgt_info *info, struct slgt_desc *bufs, int count);
+static void free_bufs(struct slgt_info *info, struct slgt_desc *bufs, int count);
+
+static int  alloc_tmp_rbuf(struct slgt_info *info);
+static void free_tmp_rbuf(struct slgt_info *info);
+
+static void tx_timeout(unsigned long context);
+static void rx_timeout(unsigned long context);
+
+/*
+ * ioctl handlers
+ */
+static int  get_stats(struct slgt_info *info, struct mgsl_icount __user *user_icount);
+static int  get_params(struct slgt_info *info, MGSL_PARAMS __user *params);
+static int  set_params(struct slgt_info *info, MGSL_PARAMS __user *params);
+static int  get_txidle(struct slgt_info *info, int __user *idle_mode);
+static int  set_txidle(struct slgt_info *info, int idle_mode);
+static int  tx_enable(struct slgt_info *info, int enable);
+static int  tx_abort(struct slgt_info *info);
+static int  rx_enable(struct slgt_info *info, int enable);
+static int  modem_input_wait(struct slgt_info *info,int arg);
+static int  wait_mgsl_event(struct slgt_info *info, int __user *mask_ptr);
+static int  tiocmget(struct tty_struct *tty, struct file *file);
+static int  tiocmset(struct tty_struct *tty, struct file *file,
+                     unsigned int set, unsigned int clear);
+static void set_break(struct tty_struct *tty, int break_state);
+static int  get_interface(struct slgt_info *info, int __user *if_mode);
+static int  set_interface(struct slgt_info *info, int if_mode);
+
+/*
+ * driver functions
+ */
+static void add_device(struct slgt_info *info);
+static void device_init(int adapter_num, struct pci_dev *pdev);
+static int  claim_resources(struct slgt_info *info);
+static void release_resources(struct slgt_info *info);
+
+/*
+ * DEBUG OUTPUT CODE
+ */
+#ifndef DBGINFO
+#define DBGINFO(fmt)
+#endif
+#ifndef DBGERR
+#define DBGERR(fmt)
+#endif
+#ifndef DBGBH
+#define DBGBH(fmt)
+#endif
+#ifndef DBGISR
+#define DBGISR(fmt)
+#endif
+
+#ifdef DBGDATA
+static void trace_block(struct slgt_info *info, const char *data, int count, const char *label)
+{
+        int i;
+        int linecount;
+        printk("%s %s data:\n",info->device_name, label);
+        while(count) {
+                linecount = (count > 16) ? 16 : count;
+                for(i=0; i < linecount; i++)
+                        printk("%02X ",(unsigned char)data[i]);
+                for(;i<17;i++)
+                        printk("   ");
+                for(i=0;i<linecount;i++) {
+                        if (data[i]>=040 && data[i]<=0176)
+                                printk("%c",data[i]);
+                        else
+                                printk(".");
+                }
+                printk("\n");
+                data  += linecount;
+                count -= linecount;
+        }
+}
+#else
+#define DBGDATA(info, buf, size, label)
+#endif
+
+#ifdef DBGTBUF
+static void dump_tbufs(struct slgt_info *info)
+{
+        int i;
+        printk("tbuf_current=%d\n", info->tbuf_current);
+        for (i=0 ; i < info->tbuf_count ; i++) {
+                printk("%d: count=%04X status=%04X\n",
+                        i, le16_to_cpu(info->tbufs[i].count), le16_to_cpu(info->tbufs[i].status));
+        }
+}
+#else
+#define DBGTBUF(info)
+#endif
+
+#ifdef DBGRBUF
+static void dump_rbufs(struct slgt_info *info)
+{
+        int i;
+        printk("rbuf_current=%d\n", info->rbuf_current);
+        for (i=0 ; i < info->rbuf_count ; i++) {
+                printk("%d: count=%04X status=%04X\n",
+                        i, le16_to_cpu(info->rbufs[i].count), le16_to_cpu(info->rbufs[i].status));
+        }
+}
+#else
+#define DBGRBUF(info)
+#endif
+
+static inline int sanity_check(struct slgt_info *info, char *devname, const char *name)
+{
+#ifdef SANITY_CHECK
+        if (!info) {
+                printk("null struct slgt_info for (%s) in %s\n", devname, name);
+                return 1;
+        }
+        if (info->magic != MGSL_MAGIC) {
+                printk("bad magic number struct slgt_info (%s) in %s\n", devname, name);
+                return 1;
+        }
+#else
+        if (!info)
+                return 1;
+#endif
+        return 0;
+}
+
+/**
+ * line discipline callback wrappers
+ *
+ * The wrappers maintain line discipline references
+ * while calling into the line discipline.
+ *
+ * ldisc_receive_buf  - pass receive data to line discipline
+ */
+static void ldisc_receive_buf(struct tty_struct *tty,
+                              const __u8 *data, char *flags, int count)
+{
+        struct tty_ldisc *ld;
+        if (!tty)
+                return;
+        ld = tty_ldisc_ref(tty);
+        if (ld) {
+                if (ld->receive_buf)
+                        ld->receive_buf(tty, data, flags, count);
+                tty_ldisc_deref(ld);
+        }
+}
+
+/* tty callbacks */
+
+static int open(struct tty_struct *tty, struct file *filp)
+{
+        struct slgt_info *info;
+        int retval, line;
+        unsigned long flags;
+
+        line = tty->index;
+        if ((line < 0) || (line >= slgt_device_count)) {
+                DBGERR(("%s: open with invalid line #%d.\n", driver_name, line));
+                return -ENODEV;
+        }
+
+        info = slgt_device_list;
+        while(info && info->line != line)
+                info = info->next_device;
+        if (sanity_check(info, tty->name, "open"))
+                return -ENODEV;
+        if (info->init_error) {
+                DBGERR(("%s init error=%d\n", info->device_name, info->init_error));
+                return -ENODEV;
+        }
+
+        tty->driver_data = info;
+        info->tty = tty;
+
+        DBGINFO(("%s open, old ref count = %d\n", info->device_name, info->count));
+
+        /* If port is closing, signal caller to try again */
+        if (tty_hung_up_p(filp) || info->flags & ASYNC_CLOSING){
+                if (info->flags & ASYNC_CLOSING)
+                        interruptible_sleep_on(&info->close_wait);
+                retval = ((info->flags & ASYNC_HUP_NOTIFY) ?
+                        -EAGAIN : -ERESTARTSYS);
+                goto cleanup;
+        }
+
+        info->tty->low_latency = (info->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
+
+        spin_lock_irqsave(&info->netlock, flags);
+        if (info->netcount) {
+                retval = -EBUSY;
+                spin_unlock_irqrestore(&info->netlock, flags);
+                goto cleanup;
+        }
+        info->count++;
+        spin_unlock_irqrestore(&info->netlock, flags);
+
+        if (info->count == 1) {
+                /* 1st open on this device, init hardware */
+                retval = startup(info);
+                if (retval < 0)
+                        goto cleanup;
+        }
+
+        retval = block_til_ready(tty, filp, info);
+        if (retval) {
+                DBGINFO(("%s block_til_ready rc=%d\n", info->device_name, retval));
+                goto cleanup;
+        }
+
+        retval = 0;
+
+cleanup:
+        if (retval) {
+                if (tty->count == 1)
+                        info->tty = NULL; /* tty layer will release tty struct */
+                if(info->count)
+                        info->count--;
+        }
+
+        DBGINFO(("%s open rc=%d\n", info->device_name, retval));
+        return retval;
+}
+
+static void close(struct tty_struct *tty, struct file *filp)
+{
+        struct slgt_info *info = tty->driver_data;
+
+        if (sanity_check(info, tty->name, "close"))
+                return;
+        DBGINFO(("%s close entry, count=%d\n", info->device_name, info->count));
+
+        if (!info->count)
+                return;
+
+        if (tty_hung_up_p(filp))
+                goto cleanup;
+
+        if ((tty->count == 1) && (info->count != 1)) {
+                /*
+                 * tty->count is 1 and the tty structure will be freed.
+                 * info->count should be one in this case.
+                 * if it's not, correct it so that the port is shutdown.
+                 */
+                DBGERR(("%s close: bad refcount; tty->count=1, "
+                       "info->count=%d\n", info->device_name, info->count));
+                info->count = 1;
+        }
+
+        info->count--;
+
+        /* if at least one open remaining, leave hardware active */
+        if (info->count)
+                goto cleanup;
+
+        info->flags |= ASYNC_CLOSING;
+
+        /* set tty->closing to notify line discipline to
+         * only process XON/XOFF characters. Only the N_TTY
+         * discipline appears to use this (ppp does not).
+         */
+        tty->closing = 1;
+
+        /* wait for transmit data to clear all layers */
+
+        if (info->closing_wait != ASYNC_CLOSING_WAIT_NONE) {
+                DBGINFO(("%s call tty_wait_until_sent\n", info->device_name));
+                tty_wait_until_sent(tty, info->closing_wait);
+        }
+
+        if (info->flags & ASYNC_INITIALIZED)
+                wait_until_sent(tty, info->timeout);
+        if (tty->driver->flush_buffer)
+                tty->driver->flush_buffer(tty);
+        tty_ldisc_flush(tty);
+
+        shutdown(info);
+
+        tty->closing = 0;
+        info->tty = NULL;
+
+        if (info->blocked_open) {
+                if (info->close_delay) {
+                        msleep_interruptible(jiffies_to_msecs(info->close_delay));
+                }
+                wake_up_interruptible(&info->open_wait);
+        }
+
+        info->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CLOSING);
+
+        wake_up_interruptible(&info->close_wait);
+
+cleanup:
+        DBGINFO(("%s close exit, count=%d\n", tty->driver->name, info->count));
+}
+
+static void hangup(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+
+        if (sanity_check(info, tty->name, "hangup"))
+                return;
+        DBGINFO(("%s hangup\n", info->device_name));
+
+        flush_buffer(tty);
+        shutdown(info);
+
+        info->count = 0;
+        info->flags &= ~ASYNC_NORMAL_ACTIVE;
+        info->tty = NULL;
+
+        wake_up_interruptible(&info->open_wait);
+}
+
+static void set_termios(struct tty_struct *tty, struct termios *old_termios)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        DBGINFO(("%s set_termios\n", tty->driver->name));
+
+        /* just return if nothing has changed */
+        if ((tty->termios->c_cflag == old_termios->c_cflag)
+            && (RELEVANT_IFLAG(tty->termios->c_iflag)
+                == RELEVANT_IFLAG(old_termios->c_iflag)))
+                return;
+
+        change_params(info);
+
+        /* Handle transition to B0 status */
+        if (old_termios->c_cflag & CBAUD &&
+            !(tty->termios->c_cflag & CBAUD)) {
+                info->signals &= ~(SerialSignal_RTS + SerialSignal_DTR);
+                spin_lock_irqsave(&info->lock,flags);
+                set_signals(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+
+        /* Handle transition away from B0 status */
+        if (!(old_termios->c_cflag & CBAUD) &&
+            tty->termios->c_cflag & CBAUD) {
+                info->signals |= SerialSignal_DTR;
+                if (!(tty->termios->c_cflag & CRTSCTS) ||
+                    !test_bit(TTY_THROTTLED, &tty->flags)) {
+                        info->signals |= SerialSignal_RTS;
+                }
+                spin_lock_irqsave(&info->lock,flags);
+                set_signals(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+
+        /* Handle turning off CRTSCTS */
+        if (old_termios->c_cflag & CRTSCTS &&
+            !(tty->termios->c_cflag & CRTSCTS)) {
+                tty->hw_stopped = 0;
+                tx_release(tty);
+        }
+}
+
+static int write(struct tty_struct *tty,
+                 const unsigned char *buf, int count)
+{
+        int ret = 0;
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "write"))
+                goto cleanup;
+        DBGINFO(("%s write count=%d\n", info->device_name, count));
+
+        if (!tty || !info->tx_buf)
+                goto cleanup;
+
+        if (count > info->max_frame_size) {
+                ret = -EIO;
+                goto cleanup;
+        }
+
+        if (!count)
+                goto cleanup;
+
+        if (info->params.mode == MGSL_MODE_RAW) {
+                unsigned int bufs_needed = (count/DMABUFSIZE);
+                unsigned int bufs_free = free_tbuf_count(info);
+                if (count % DMABUFSIZE)
+                        ++bufs_needed;
+                if (bufs_needed > bufs_free)
+                        goto cleanup;
+        } else {
+                if (info->tx_active)
+                        goto cleanup;
+                if (info->tx_count) {
+                        /* send accumulated data from send_char() calls */
+                        /* as frame and wait before accepting more data. */
+                        tx_load(info, info->tx_buf, info->tx_count);
+                        goto start;
+                }
+        }
+
+        ret = info->tx_count = count;
+        tx_load(info, buf, count);
+        goto start;
+
+start:
+        if (info->tx_count && !tty->stopped && !tty->hw_stopped) {
+                spin_lock_irqsave(&info->lock,flags);
+                if (!info->tx_active)
+                        tx_start(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+
+cleanup:
+        DBGINFO(("%s write rc=%d\n", info->device_name, ret));
+        return ret;
+}
+
+static void put_char(struct tty_struct *tty, unsigned char ch)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "put_char"))
+                return;
+        DBGINFO(("%s put_char(%d)\n", info->device_name, ch));
+        if (!tty || !info->tx_buf)
+                return;
+        spin_lock_irqsave(&info->lock,flags);
+        if (!info->tx_active && (info->tx_count < info->max_frame_size))
+                info->tx_buf[info->tx_count++] = ch;
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+static void send_xchar(struct tty_struct *tty, char ch)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "send_xchar"))
+                return;
+        DBGINFO(("%s send_xchar(%d)\n", info->device_name, ch));
+        info->x_char = ch;
+        if (ch) {
+                spin_lock_irqsave(&info->lock,flags);
+                if (!info->tx_enabled)
+                        tx_start(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+}
+
+static void wait_until_sent(struct tty_struct *tty, int timeout)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long orig_jiffies, char_time;
+
+        if (!info )
+                return;
+        if (sanity_check(info, tty->name, "wait_until_sent"))
+                return;
+        DBGINFO(("%s wait_until_sent entry\n", info->device_name));
+        if (!(info->flags & ASYNC_INITIALIZED))
+                goto exit;
+
+        orig_jiffies = jiffies;
+
+        /* Set check interval to 1/5 of estimated time to
+         * send a character, and make it at least 1. The check
+         * interval should also be less than the timeout.
+         * Note: use tight timings here to satisfy the NIST-PCTS.
+         */
+
+        if (info->params.data_rate) {
+                char_time = info->timeout/(32 * 5);
+                if (!char_time)
+                        char_time++;
+        } else
+                char_time = 1;
+
+        if (timeout)
+                char_time = min_t(unsigned long, char_time, timeout);
+
+        while (info->tx_active) {
+                msleep_interruptible(jiffies_to_msecs(char_time));
+                if (signal_pending(current))
+                        break;
+                if (timeout && time_after(jiffies, orig_jiffies + timeout))
+                        break;
+        }
+
+exit:
+        DBGINFO(("%s wait_until_sent exit\n", info->device_name));
+}
+
+static int write_room(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        int ret;
+
+        if (sanity_check(info, tty->name, "write_room"))
+                return 0;
+        ret = (info->tx_active) ? 0 : HDLC_MAX_FRAME_SIZE;
+        DBGINFO(("%s write_room=%d\n", info->device_name, ret));
+        return ret;
+}
+
+static void flush_chars(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "flush_chars"))
+                return;
+        DBGINFO(("%s flush_chars entry tx_count=%d\n", info->device_name, info->tx_count));
+
+        if (info->tx_count <= 0 || tty->stopped ||
+            tty->hw_stopped || !info->tx_buf)
+                return;
+
+        DBGINFO(("%s flush_chars start transmit\n", info->device_name));
+
+        spin_lock_irqsave(&info->lock,flags);
+        if (!info->tx_active && info->tx_count) {
+                tx_load(info, info->tx_buf,info->tx_count);
+                tx_start(info);
+        }
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+static void flush_buffer(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "flush_buffer"))
+                return;
+        DBGINFO(("%s flush_buffer\n", info->device_name));
+
+        spin_lock_irqsave(&info->lock,flags);
+        if (!info->tx_active)
+                info->tx_count = 0;
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        wake_up_interruptible(&tty->write_wait);
+        tty_wakeup(tty);
+}
+
+/*
+ * throttle (stop) transmitter
+ */
+static void tx_hold(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "tx_hold"))
+                return;
+        DBGINFO(("%s tx_hold\n", info->device_name));
+        spin_lock_irqsave(&info->lock,flags);
+        if (info->tx_enabled && info->params.mode == MGSL_MODE_ASYNC)
+                tx_stop(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+/*
+ * release (start) transmitter
+ */
+static void tx_release(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "tx_release"))
+                return;
+        DBGINFO(("%s tx_release\n", info->device_name));
+        spin_lock_irqsave(&info->lock,flags);
+        if (!info->tx_active && info->tx_count) {
+                tx_load(info, info->tx_buf, info->tx_count);
+                tx_start(info);
+        }
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+/*
+ * Service an IOCTL request
+ *
+ * Arguments
+ *
+ *      tty     pointer to tty instance data
+ *      file    pointer to associated file object for device
+ *      cmd     IOCTL command code
+ *      arg     command argument/context
+ *
+ * Return 0 if success, otherwise error code
+ */
+static int ioctl(struct tty_struct *tty, struct file *file,
+                 unsigned int cmd, unsigned long arg)
+{
+        struct slgt_info *info = tty->driver_data;
+        struct mgsl_icount cnow;        /* kernel counter temps */
+        struct serial_icounter_struct __user *p_cuser;  /* user space */
+        unsigned long flags;
+        void __user *argp = (void __user *)arg;
+
+        if (sanity_check(info, tty->name, "ioctl"))
+                return -ENODEV;
+        DBGINFO(("%s ioctl() cmd=%08X\n", info->device_name, cmd));
+
+        if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) &&
+            (cmd != TIOCMIWAIT) && (cmd != TIOCGICOUNT)) {
+                if (tty->flags & (1 << TTY_IO_ERROR))
+                    return -EIO;
+        }
+
+        switch (cmd) {
+        case MGSL_IOCGPARAMS:
+                return get_params(info, argp);
+        case MGSL_IOCSPARAMS:
+                return set_params(info, argp);
+        case MGSL_IOCGTXIDLE:
+                return get_txidle(info, argp);
+        case MGSL_IOCSTXIDLE:
+                return set_txidle(info, (int)arg);
+        case MGSL_IOCTXENABLE:
+                return tx_enable(info, (int)arg);
+        case MGSL_IOCRXENABLE:
+                return rx_enable(info, (int)arg);
+        case MGSL_IOCTXABORT:
+                return tx_abort(info);
+        case MGSL_IOCGSTATS:
+                return get_stats(info, argp);
+        case MGSL_IOCWAITEVENT:
+                return wait_mgsl_event(info, argp);
+        case TIOCMIWAIT:
+                return modem_input_wait(info,(int)arg);
+        case MGSL_IOCGIF:
+                return get_interface(info, argp);
+        case MGSL_IOCSIF:
+                return set_interface(info,(int)arg);
+        case TIOCGICOUNT:
+                spin_lock_irqsave(&info->lock,flags);
+                cnow = info->icount;
+                spin_unlock_irqrestore(&info->lock,flags);
+                p_cuser = argp;
+                if (put_user(cnow.cts, &p_cuser->cts) ||
+                    put_user(cnow.dsr, &p_cuser->dsr) ||
+                    put_user(cnow.rng, &p_cuser->rng) ||
+                    put_user(cnow.dcd, &p_cuser->dcd) ||
+                    put_user(cnow.rx, &p_cuser->rx) ||
+                    put_user(cnow.tx, &p_cuser->tx) ||
+                    put_user(cnow.frame, &p_cuser->frame) ||
+                    put_user(cnow.overrun, &p_cuser->overrun) ||
+                    put_user(cnow.parity, &p_cuser->parity) ||
+                    put_user(cnow.brk, &p_cuser->brk) ||
+                    put_user(cnow.buf_overrun, &p_cuser->buf_overrun))
+                        return -EFAULT;
+                return 0;
+        default:
+                return -ENOIOCTLCMD;
+        }
+        return 0;
+}
+
+/*
+ * proc fs support
+ */
+static inline int line_info(char *buf, struct slgt_info *info)
+{
+        char stat_buf[30];
+        int ret;
+        unsigned long flags;
+
+        ret = sprintf(buf, "%s: IO=%08X IRQ=%d MaxFrameSize=%u\n",
+                      info->device_name, info->phys_reg_addr,
+                      info->irq_level, info->max_frame_size);
+
+        /* output current serial signal states */
+        spin_lock_irqsave(&info->lock,flags);
+        get_signals(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        stat_buf[0] = 0;
+        stat_buf[1] = 0;
+        if (info->signals & SerialSignal_RTS)
+                strcat(stat_buf, "|RTS");
+        if (info->signals & SerialSignal_CTS)
+                strcat(stat_buf, "|CTS");
+        if (info->signals & SerialSignal_DTR)
+                strcat(stat_buf, "|DTR");
+        if (info->signals & SerialSignal_DSR)
+                strcat(stat_buf, "|DSR");
+        if (info->signals & SerialSignal_DCD)
+                strcat(stat_buf, "|CD");
+        if (info->signals & SerialSignal_RI)
+                strcat(stat_buf, "|RI");
+
+        if (info->params.mode != MGSL_MODE_ASYNC) {
+                ret += sprintf(buf+ret, "\tHDLC txok:%d rxok:%d",
+                               info->icount.txok, info->icount.rxok);
+                if (info->icount.txunder)
+                        ret += sprintf(buf+ret, " txunder:%d", info->icount.txunder);
+                if (info->icount.txabort)
+                        ret += sprintf(buf+ret, " txabort:%d", info->icount.txabort);
+                if (info->icount.rxshort)
+                        ret += sprintf(buf+ret, " rxshort:%d", info->icount.rxshort);
+                if (info->icount.rxlong)
+                        ret += sprintf(buf+ret, " rxlong:%d", info->icount.rxlong);
+                if (info->icount.rxover)
+                        ret += sprintf(buf+ret, " rxover:%d", info->icount.rxover);
+                if (info->icount.rxcrc)
+                        ret += sprintf(buf+ret, " rxcrc:%d", info->icount.rxcrc);
+        } else {
+                ret += sprintf(buf+ret, "\tASYNC tx:%d rx:%d",
+                               info->icount.tx, info->icount.rx);
+                if (info->icount.frame)
+                        ret += sprintf(buf+ret, " fe:%d", info->icount.frame);
+                if (info->icount.parity)
+                        ret += sprintf(buf+ret, " pe:%d", info->icount.parity);
+                if (info->icount.brk)
+                        ret += sprintf(buf+ret, " brk:%d", info->icount.brk);
+                if (info->icount.overrun)
+                        ret += sprintf(buf+ret, " oe:%d", info->icount.overrun);
+        }
+
+        /* Append serial signal status to end */
+        ret += sprintf(buf+ret, " %s\n", stat_buf+1);
+
+        ret += sprintf(buf+ret, "\ttxactive=%d bh_req=%d bh_run=%d pending_bh=%x\n",
+                       info->tx_active,info->bh_requested,info->bh_running,
+                       info->pending_bh);
+
+        return ret;
+}
+
+/* Called to print information about devices
+ */
+static int read_proc(char *page, char **start, off_t off, int count,
+                     int *eof, void *data)
+{
+        int len = 0, l;
+        off_t   begin = 0;
+        struct slgt_info *info;
+
+        len += sprintf(page, "synclink_gt driver:%s\n", driver_version);
+
+        info = slgt_device_list;
+        while( info ) {
+                l = line_info(page + len, info);
+                len += l;
+                if (len+begin > off+count)
+                        goto done;
+                if (len+begin < off) {
+                        begin += len;
+                        len = 0;
+                }
+                info = info->next_device;
+        }
+
+        *eof = 1;
+done:
+        if (off >= len+begin)
+                return 0;
+        *start = page + (off-begin);
+        return ((count < begin+len-off) ? count : begin+len-off);
+}
+
+/*
+ * return count of bytes in transmit buffer
+ */
+static int chars_in_buffer(struct tty_struct *tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        if (sanity_check(info, tty->name, "chars_in_buffer"))
+                return 0;
+        DBGINFO(("%s chars_in_buffer()=%d\n", info->device_name, info->tx_count));
+        return info->tx_count;
+}
+
+/*
+ * signal remote device to throttle send data (our receive data)
+ */
+static void throttle(struct tty_struct * tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "throttle"))
+                return;
+        DBGINFO(("%s throttle\n", info->device_name));
+        if (I_IXOFF(tty))
+                send_xchar(tty, STOP_CHAR(tty));
+        if (tty->termios->c_cflag & CRTSCTS) {
+                spin_lock_irqsave(&info->lock,flags);
+                info->signals &= ~SerialSignal_RTS;
+                set_signals(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+}
+
+/*
+ * signal remote device to stop throttling send data (our receive data)
+ */
+static void unthrottle(struct tty_struct * tty)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "unthrottle"))
+                return;
+        DBGINFO(("%s unthrottle\n", info->device_name));
+        if (I_IXOFF(tty)) {
+                if (info->x_char)
+                        info->x_char = 0;
+                else
+                        send_xchar(tty, START_CHAR(tty));
+        }
+        if (tty->termios->c_cflag & CRTSCTS) {
+                spin_lock_irqsave(&info->lock,flags);
+                info->signals |= SerialSignal_RTS;
+                set_signals(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+}
+
+/*
+ * set or clear transmit break condition
+ * break_state  -1=set break condition, 0=clear
+ */
+static void set_break(struct tty_struct *tty, int break_state)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned short value;
+        unsigned long flags;
+
+        if (sanity_check(info, tty->name, "set_break"))
+                return;
+        DBGINFO(("%s set_break(%d)\n", info->device_name, break_state));
+
+        spin_lock_irqsave(&info->lock,flags);
+        value = rd_reg16(info, TCR);
+        if (break_state == -1)
+                value |= BIT6;
+        else
+                value &= ~BIT6;
+        wr_reg16(info, TCR, value);
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+#ifdef CONFIG_HDLC
+
+/**
+ * called by generic HDLC layer when protocol selected (PPP, frame relay, etc.)
+ * set encoding and frame check sequence (FCS) options
+ *
+ * dev       pointer to network device structure
+ * encoding  serial encoding setting
+ * parity    FCS setting
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_attach(struct net_device *dev, unsigned short encoding,
+                          unsigned short parity)
+{
+        struct slgt_info *info = dev_to_port(dev);
+        unsigned char  new_encoding;
+        unsigned short new_crctype;
+
+        /* return error if TTY interface open */
+        if (info->count)
+                return -EBUSY;
+
+        DBGINFO(("%s hdlcdev_attach\n", info->device_name));
+
+        switch (encoding)
+        {
+        case ENCODING_NRZ:        new_encoding = HDLC_ENCODING_NRZ; break;
+        case ENCODING_NRZI:       new_encoding = HDLC_ENCODING_NRZI_SPACE; break;
+        case ENCODING_FM_MARK:    new_encoding = HDLC_ENCODING_BIPHASE_MARK; break;
+        case ENCODING_FM_SPACE:   new_encoding = HDLC_ENCODING_BIPHASE_SPACE; break;
+        case ENCODING_MANCHESTER: new_encoding = HDLC_ENCODING_BIPHASE_LEVEL; break;
+        default: return -EINVAL;
+        }
+
+        switch (parity)
+        {
+        case PARITY_NONE:            new_crctype = HDLC_CRC_NONE; break;
+        case PARITY_CRC16_PR1_CCITT: new_crctype = HDLC_CRC_16_CCITT; break;
+        case PARITY_CRC32_PR1_CCITT: new_crctype = HDLC_CRC_32_CCITT; break;
+        default: return -EINVAL;
+        }
+
+        info->params.encoding = new_encoding;
+        info->params.crc_type = new_crctype;;
+
+        /* if network interface up, reprogram hardware */
+        if (info->netcount)
+                program_hw(info);
+
+        return 0;
+}
+
+/**
+ * called by generic HDLC layer to send frame
+ *
+ * skb  socket buffer containing HDLC frame
+ * dev  pointer to network device structure
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_xmit(struct sk_buff *skb, struct net_device *dev)
+{
+        struct slgt_info *info = dev_to_port(dev);
+        struct net_device_stats *stats = hdlc_stats(dev);
+        unsigned long flags;
+
+        DBGINFO(("%s hdlc_xmit\n", dev->name));
+
+        /* stop sending until this frame completes */
+        netif_stop_queue(dev);
+
+        /* copy data to device buffers */
+        info->tx_count = skb->len;
+        tx_load(info, skb->data, skb->len);
+
+        /* update network statistics */
+        stats->tx_packets++;
+        stats->tx_bytes += skb->len;
+
+        /* done with socket buffer, so free it */
+        dev_kfree_skb(skb);
+
+        /* save start time for transmit timeout detection */
+        dev->trans_start = jiffies;
+
+        /* start hardware transmitter if necessary */
+        spin_lock_irqsave(&info->lock,flags);
+        if (!info->tx_active)
+                tx_start(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        return 0;
+}
+
+/**
+ * called by network layer when interface enabled
+ * claim resources and initialize hardware
+ *
+ * dev  pointer to network device structure
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_open(struct net_device *dev)
+{
+        struct slgt_info *info = dev_to_port(dev);
+        int rc;
+        unsigned long flags;
+
+        DBGINFO(("%s hdlcdev_open\n", dev->name));
+
+        /* generic HDLC layer open processing */
+        if ((rc = hdlc_open(dev)))
+                return rc;
+
+        /* arbitrate between network and tty opens */
+        spin_lock_irqsave(&info->netlock, flags);
+        if (info->count != 0 || info->netcount != 0) {
+                DBGINFO(("%s hdlc_open busy\n", dev->name));
+                spin_unlock_irqrestore(&info->netlock, flags);
+                return -EBUSY;
+        }
+        info->netcount=1;
+        spin_unlock_irqrestore(&info->netlock, flags);
+
+        /* claim resources and init adapter */
+        if ((rc = startup(info)) != 0) {
+                spin_lock_irqsave(&info->netlock, flags);
+                info->netcount=0;
+                spin_unlock_irqrestore(&info->netlock, flags);
+                return rc;
+        }
+
+        /* assert DTR and RTS, apply hardware settings */
+        info->signals |= SerialSignal_RTS + SerialSignal_DTR;
+        program_hw(info);
+
+        /* enable network layer transmit */
+        dev->trans_start = jiffies;
+        netif_start_queue(dev);
+
+        /* inform generic HDLC layer of current DCD status */
+        spin_lock_irqsave(&info->lock, flags);
+        get_signals(info);
+        spin_unlock_irqrestore(&info->lock, flags);
+        hdlc_set_carrier(info->signals & SerialSignal_DCD, dev);
+
+        return 0;
+}
+
+/**
+ * called by network layer when interface is disabled
+ * shutdown hardware and release resources
+ *
+ * dev  pointer to network device structure
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_close(struct net_device *dev)
+{
+        struct slgt_info *info = dev_to_port(dev);
+        unsigned long flags;
+
+        DBGINFO(("%s hdlcdev_close\n", dev->name));
+
+        netif_stop_queue(dev);
+
+        /* shutdown adapter and release resources */
+        shutdown(info);
+
+        hdlc_close(dev);
+
+        spin_lock_irqsave(&info->netlock, flags);
+        info->netcount=0;
+        spin_unlock_irqrestore(&info->netlock, flags);
+
+        return 0;
+}
+
+/**
+ * called by network layer to process IOCTL call to network device
+ *
+ * dev  pointer to network device structure
+ * ifr  pointer to network interface request structure
+ * cmd  IOCTL command code
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
+{
+        const size_t size = sizeof(sync_serial_settings);
+        sync_serial_settings new_line;
+        sync_serial_settings __user *line = ifr->ifr_settings.ifs_ifsu.sync;
+        struct slgt_info *info = dev_to_port(dev);
+        unsigned int flags;
+
+        DBGINFO(("%s hdlcdev_ioctl\n", dev->name));
+
+        /* return error if TTY interface open */
+        if (info->count)
+                return -EBUSY;
+
+        if (cmd != SIOCWANDEV)
+                return hdlc_ioctl(dev, ifr, cmd);
+
+        switch(ifr->ifr_settings.type) {
+        case IF_GET_IFACE: /* return current sync_serial_settings */
+
+                ifr->ifr_settings.type = IF_IFACE_SYNC_SERIAL;
+                if (ifr->ifr_settings.size < size) {
+                        ifr->ifr_settings.size = size; /* data size wanted */
+                        return -ENOBUFS;
+                }
+
+                flags = info->params.flags & (HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_RXC_DPLL |
+                                              HDLC_FLAG_RXC_BRG    | HDLC_FLAG_RXC_TXCPIN |
+                                              HDLC_FLAG_TXC_TXCPIN | HDLC_FLAG_TXC_DPLL |
+                                              HDLC_FLAG_TXC_BRG    | HDLC_FLAG_TXC_RXCPIN);
+
+                switch (flags){
+                case (HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_TXCPIN): new_line.clock_type = CLOCK_EXT; break;
+                case (HDLC_FLAG_RXC_BRG    | HDLC_FLAG_TXC_BRG):    new_line.clock_type = CLOCK_INT; break;
+                case (HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_BRG):    new_line.clock_type = CLOCK_TXINT; break;
+                case (HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_RXCPIN): new_line.clock_type = CLOCK_TXFROMRX; break;
+                default: new_line.clock_type = CLOCK_DEFAULT;
+                }
+
+                new_line.clock_rate = info->params.clock_speed;
+                new_line.loopback   = info->params.loopback ? 1:0;
+
+                if (copy_to_user(line, &new_line, size))
+                        return -EFAULT;
+                return 0;
+
+        case IF_IFACE_SYNC_SERIAL: /* set sync_serial_settings */
+
+                if(!capable(CAP_NET_ADMIN))
+                        return -EPERM;
+                if (copy_from_user(&new_line, line, size))
+                        return -EFAULT;
+
+                switch (new_line.clock_type)
+                {
+                case CLOCK_EXT:      flags = HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_TXCPIN; break;
+                case CLOCK_TXFROMRX: flags = HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_RXCPIN; break;
+                case CLOCK_INT:      flags = HDLC_FLAG_RXC_BRG    | HDLC_FLAG_TXC_BRG;    break;
+                case CLOCK_TXINT:    flags = HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_TXC_BRG;    break;
+                case CLOCK_DEFAULT:  flags = info->params.flags &
+                                             (HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_RXC_DPLL |
+                                              HDLC_FLAG_RXC_BRG    | HDLC_FLAG_RXC_TXCPIN |
+                                              HDLC_FLAG_TXC_TXCPIN | HDLC_FLAG_TXC_DPLL |
+                                              HDLC_FLAG_TXC_BRG    | HDLC_FLAG_TXC_RXCPIN); break;
+                default: return -EINVAL;
+                }
+
+                if (new_line.loopback != 0 && new_line.loopback != 1)
+                        return -EINVAL;
+
+                info->params.flags &= ~(HDLC_FLAG_RXC_RXCPIN | HDLC_FLAG_RXC_DPLL |
+                                        HDLC_FLAG_RXC_BRG    | HDLC_FLAG_RXC_TXCPIN |
+                                        HDLC_FLAG_TXC_TXCPIN | HDLC_FLAG_TXC_DPLL |
+                                        HDLC_FLAG_TXC_BRG    | HDLC_FLAG_TXC_RXCPIN);
+                info->params.flags |= flags;
+
+                info->params.loopback = new_line.loopback;
+
+                if (flags & (HDLC_FLAG_RXC_BRG | HDLC_FLAG_TXC_BRG))
+                        info->params.clock_speed = new_line.clock_rate;
+                else
+                        info->params.clock_speed = 0;
+
+                /* if network interface up, reprogram hardware */
+                if (info->netcount)
+                        program_hw(info);
+                return 0;
+
+        default:
+                return hdlc_ioctl(dev, ifr, cmd);
+        }
+}
+
+/**
+ * called by network layer when transmit timeout is detected
+ *
+ * dev  pointer to network device structure
+ */
+static void hdlcdev_tx_timeout(struct net_device *dev)
+{
+        struct slgt_info *info = dev_to_port(dev);
+        struct net_device_stats *stats = hdlc_stats(dev);
+        unsigned long flags;
+
+        DBGINFO(("%s hdlcdev_tx_timeout\n", dev->name));
+
+        stats->tx_errors++;
+        stats->tx_aborted_errors++;
+
+        spin_lock_irqsave(&info->lock,flags);
+        tx_stop(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        netif_wake_queue(dev);
+}
+
+/**
+ * called by device driver when transmit completes
+ * reenable network layer transmit if stopped
+ *
+ * info  pointer to device instance information
+ */
+static void hdlcdev_tx_done(struct slgt_info *info)
+{
+        if (netif_queue_stopped(info->netdev))
+                netif_wake_queue(info->netdev);
+}
+
+/**
+ * called by device driver when frame received
+ * pass frame to network layer
+ *
+ * info  pointer to device instance information
+ * buf   pointer to buffer contianing frame data
+ * size  count of data bytes in buf
+ */
+static void hdlcdev_rx(struct slgt_info *info, char *buf, int size)
+{
+        struct sk_buff *skb = dev_alloc_skb(size);
+        struct net_device *dev = info->netdev;
+        struct net_device_stats *stats = hdlc_stats(dev);
+
+        DBGINFO(("%s hdlcdev_rx\n", dev->name));
+
+        if (skb == NULL) {
+                DBGERR(("%s: can't alloc skb, drop packet\n", dev->name));
+                stats->rx_dropped++;
+                return;
+        }
+
+        memcpy(skb_put(skb, size),buf,size);
+
+        skb->protocol = hdlc_type_trans(skb, info->netdev);
+
+        stats->rx_packets++;
+        stats->rx_bytes += size;
+
+        netif_rx(skb);
+
+        info->netdev->last_rx = jiffies;
+}
+
+/**
+ * called by device driver when adding device instance
+ * do generic HDLC initialization
+ *
+ * info  pointer to device instance information
+ *
+ * returns 0 if success, otherwise error code
+ */
+static int hdlcdev_init(struct slgt_info *info)
+{
+        int rc;
+        struct net_device *dev;
+        hdlc_device *hdlc;
+
+        /* allocate and initialize network and HDLC layer objects */
+
+        if (!(dev = alloc_hdlcdev(info))) {
+                printk(KERN_ERR "%s hdlc device alloc failure\n", info->device_name);
+                return -ENOMEM;
+        }
+
+        /* for network layer reporting purposes only */
+        dev->mem_start = info->phys_reg_addr;
+        dev->mem_end   = info->phys_reg_addr + SLGT_REG_SIZE - 1;
+        dev->irq       = info->irq_level;
+
+        /* network layer callbacks and settings */
+        dev->do_ioctl       = hdlcdev_ioctl;
+        dev->open           = hdlcdev_open;
+        dev->stop           = hdlcdev_close;
+        dev->tx_timeout     = hdlcdev_tx_timeout;
+        dev->watchdog_timeo = 10*HZ;
+        dev->tx_queue_len   = 50;
+
+        /* generic HDLC layer callbacks and settings */
+        hdlc         = dev_to_hdlc(dev);
+        hdlc->attach = hdlcdev_attach;
+        hdlc->xmit   = hdlcdev_xmit;
+
+        /* register objects with HDLC layer */
+        if ((rc = register_hdlc_device(dev))) {
+                printk(KERN_WARNING "%s:unable to register hdlc device\n",__FILE__);
+                free_netdev(dev);
+                return rc;
+        }
+
+        info->netdev = dev;
+        return 0;
+}
+
+/**
+ * called by device driver when removing device instance
+ * do generic HDLC cleanup
+ *
+ * info  pointer to device instance information
+ */
+static void hdlcdev_exit(struct slgt_info *info)
+{
+        unregister_hdlc_device(info->netdev);
+        free_netdev(info->netdev);
+        info->netdev = NULL;
+}
+
+#endif /* ifdef CONFIG_HDLC */
+
+/*
+ * get async data from rx DMA buffers
+ */
+static void rx_async(struct slgt_info *info)
+{
+        struct tty_struct *tty = info->tty;
+        struct mgsl_icount *icount = &info->icount;
+        unsigned int start, end;
+        unsigned char *p;
+        unsigned char status;
+        struct slgt_desc *bufs = info->rbufs;
+        int i, count;
+
+        start = end = info->rbuf_current;
+
+        while(desc_complete(bufs[end])) {
+                count = desc_count(bufs[end]) - info->rbuf_index;
+                p     = bufs[end].buf + info->rbuf_index;
+
+                DBGISR(("%s rx_async count=%d\n", info->device_name, count));
+                DBGDATA(info, p, count, "rx");
+
+                for(i=0 ; i < count; i+=2, p+=2) {
+                        if (tty) {
+                                if (tty->flip.count >= TTY_FLIPBUF_SIZE)
+                                        tty_flip_buffer_push(tty);
+                                if (tty->flip.count >= TTY_FLIPBUF_SIZE)
+                                        break;
+                                *tty->flip.char_buf_ptr = *p;
+                                *tty->flip.flag_buf_ptr = 0;
+                        }
+                        icount->rx++;
+
+                        if ((status = *(p+1) & (BIT9 + BIT8))) {
+                                if (status & BIT9)
+                                        icount->parity++;
+                                else if (status & BIT8)
+                                        icount->frame++;
+                                /* discard char if tty control flags say so */
+                                if (status & info->ignore_status_mask)
+                                        continue;
+                                if (tty) {
+                                        if (status & BIT9)
+                                                *tty->flip.flag_buf_ptr = TTY_PARITY;
+                                        else if (status & BIT8)
+                                                *tty->flip.flag_buf_ptr = TTY_FRAME;
+                                }
+                        }
+                        if (tty) {
+                                tty->flip.flag_buf_ptr++;
+                                tty->flip.char_buf_ptr++;
+                                tty->flip.count++;
+                        }
+                }
+
+                if (i < count) {
+                        /* receive buffer not completed */
+                        info->rbuf_index += i;
+                        info->rx_timer.expires = jiffies + 1;
+                        add_timer(&info->rx_timer);
+                        break;
+                }
+
+                info->rbuf_index = 0;
+                free_rbufs(info, end, end);
+
+                if (++end == info->rbuf_count)
+                        end = 0;
+
+                /* if entire list searched then no frame available */
+                if (end == start)
+                        break;
+        }
+
+        if (tty && tty->flip.count)
+                tty_flip_buffer_push(tty);
+}
+
+/*
+ * return next bottom half action to perform
+ */
+static int bh_action(struct slgt_info *info)
+{
+        unsigned long flags;
+        int rc;
+
+        spin_lock_irqsave(&info->lock,flags);
+
+        if (info->pending_bh & BH_RECEIVE) {
+                info->pending_bh &= ~BH_RECEIVE;
+                rc = BH_RECEIVE;
+        } else if (info->pending_bh & BH_TRANSMIT) {
+                info->pending_bh &= ~BH_TRANSMIT;
+                rc = BH_TRANSMIT;
+        } else if (info->pending_bh & BH_STATUS) {
+                info->pending_bh &= ~BH_STATUS;
+                rc = BH_STATUS;
+        } else {
+                /* Mark BH routine as complete */
+                info->bh_running   = 0;
+                info->bh_requested = 0;
+                rc = 0;
+        }
+
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        return rc;
+}
+
+/*
+ * perform bottom half processing
+ */
+static void bh_handler(void* context)
+{
+        struct slgt_info *info = context;
+        int action;
+
+        if (!info)
+                return;
+        info->bh_running = 1;
+
+        while((action = bh_action(info))) {
+                switch (action) {
+                case BH_RECEIVE:
+                        DBGBH(("%s bh receive\n", info->device_name));
+                        switch(info->params.mode) {
+                        case MGSL_MODE_ASYNC:
+                                rx_async(info);
+                                break;
+                        case MGSL_MODE_HDLC:
+                                while(rx_get_frame(info));
+                                break;
+                        case MGSL_MODE_RAW:
+                                while(rx_get_buf(info));
+                                break;
+                        }
+                        /* restart receiver if rx DMA buffers exhausted */
+                        if (info->rx_restart)
+                                rx_start(info);
+                        break;
+                case BH_TRANSMIT:
+                        bh_transmit(info);
+                        break;
+                case BH_STATUS:
+                        DBGBH(("%s bh status\n", info->device_name));
+                        info->ri_chkcount = 0;
+                        info->dsr_chkcount = 0;
+                        info->dcd_chkcount = 0;
+                        info->cts_chkcount = 0;
+                        break;
+                default:
+                        DBGBH(("%s unknown action\n", info->device_name));
+                        break;
+                }
+        }
+        DBGBH(("%s bh_handler exit\n", info->device_name));
+}
+
+static void bh_transmit(struct slgt_info *info)
+{
+        struct tty_struct *tty = info->tty;
+
+        DBGBH(("%s bh_transmit\n", info->device_name));
+        if (tty) {
+                tty_wakeup(tty);
+                wake_up_interruptible(&tty->write_wait);
+        }
+}
+
+static void dsr_change(struct slgt_info *info)
+{
+        get_signals(info);
+        DBGISR(("dsr_change %s signals=%04X\n", info->device_name, info->signals));
+        if ((info->dsr_chkcount)++ == IO_PIN_SHUTDOWN_LIMIT) {
+                slgt_irq_off(info, IRQ_DSR);
+                return;
+        }
+        info->icount.dsr++;
+        if (info->signals & SerialSignal_DSR)
+                info->input_signal_events.dsr_up++;
+        else
+                info->input_signal_events.dsr_down++;
+        wake_up_interruptible(&info->status_event_wait_q);
+        wake_up_interruptible(&info->event_wait_q);
+        info->pending_bh |= BH_STATUS;
+}
+
+static void cts_change(struct slgt_info *info)
+{
+        get_signals(info);
+        DBGISR(("cts_change %s signals=%04X\n", info->device_name, info->signals));
+        if ((info->cts_chkcount)++ == IO_PIN_SHUTDOWN_LIMIT) {
+                slgt_irq_off(info, IRQ_CTS);
+                return;
+        }
+        info->icount.cts++;
+        if (info->signals & SerialSignal_CTS)
+                info->input_signal_events.cts_up++;
+        else
+                info->input_signal_events.cts_down++;
+        wake_up_interruptible(&info->status_event_wait_q);
+        wake_up_interruptible(&info->event_wait_q);
+        info->pending_bh |= BH_STATUS;
+
+        if (info->flags & ASYNC_CTS_FLOW) {
+                if (info->tty) {
+                        if (info->tty->hw_stopped) {
+                                if (info->signals & SerialSignal_CTS) {
+                                        info->tty->hw_stopped = 0;
+                                        info->pending_bh |= BH_TRANSMIT;
+                                        return;
+                                }
+                        } else {
+                                if (!(info->signals & SerialSignal_CTS))
+                                        info->tty->hw_stopped = 1;
+                        }
+                }
+        }
+}
+
+static void dcd_change(struct slgt_info *info)
+{
+        get_signals(info);
+        DBGISR(("dcd_change %s signals=%04X\n", info->device_name, info->signals));
+        if ((info->dcd_chkcount)++ == IO_PIN_SHUTDOWN_LIMIT) {
+                slgt_irq_off(info, IRQ_DCD);
+                return;
+        }
+        info->icount.dcd++;
+        if (info->signals & SerialSignal_DCD) {
+                info->input_signal_events.dcd_up++;
+        } else {
+                info->input_signal_events.dcd_down++;
+        }
+#ifdef CONFIG_HDLC
+        if (info->netcount)
+                hdlc_set_carrier(info->signals & SerialSignal_DCD, info->netdev);
+#endif
+        wake_up_interruptible(&info->status_event_wait_q);
+        wake_up_interruptible(&info->event_wait_q);
+        info->pending_bh |= BH_STATUS;
+
+        if (info->flags & ASYNC_CHECK_CD) {
+                if (info->signals & SerialSignal_DCD)
+                        wake_up_interruptible(&info->open_wait);
+                else {
+                        if (info->tty)
+                                tty_hangup(info->tty);
+                }
+        }
+}
+
+static void ri_change(struct slgt_info *info)
+{
+        get_signals(info);
+        DBGISR(("ri_change %s signals=%04X\n", info->device_name, info->signals));
+        if ((info->ri_chkcount)++ == IO_PIN_SHUTDOWN_LIMIT) {
+                slgt_irq_off(info, IRQ_RI);
+                return;
+        }
+        info->icount.dcd++;
+        if (info->signals & SerialSignal_RI) {
+                info->input_signal_events.ri_up++;
+        } else {
+                info->input_signal_events.ri_down++;
+        }
+        wake_up_interruptible(&info->status_event_wait_q);
+        wake_up_interruptible(&info->event_wait_q);
+        info->pending_bh |= BH_STATUS;
+}
+
+static void isr_serial(struct slgt_info *info)
+{
+        unsigned short status = rd_reg16(info, SSR);
+
+        DBGISR(("%s isr_serial status=%04X\n", info->device_name, status));
+
+        wr_reg16(info, SSR, status); /* clear pending */
+
+        info->irq_occurred = 1;
+
+        if (info->params.mode == MGSL_MODE_ASYNC) {
+                if (status & IRQ_TXIDLE) {
+                        if (info->tx_count)
+                                isr_txeom(info, status);
+                }
+                if ((status & IRQ_RXBREAK) && (status & RXBREAK)) {
+                        info->icount.brk++;
+                        /* process break detection if tty control allows */
+                        if (info->tty) {
+                                if (!(status & info->ignore_status_mask)) {
+                                        if (info->read_status_mask & MASK_BREAK) {
+                                                *info->tty->flip.flag_buf_ptr = TTY_BREAK;
+                                                if (info->flags & ASYNC_SAK)
+                                                        do_SAK(info->tty);
+                                        }
+                                }
+                        }
+                }
+        } else {
+                if (status & (IRQ_TXIDLE + IRQ_TXUNDER))
+                        isr_txeom(info, status);
+
+                if (status & IRQ_RXIDLE) {
+                        if (status & RXIDLE)
+                                info->icount.rxidle++;
+                        else
+                                info->icount.exithunt++;
+                        wake_up_interruptible(&info->event_wait_q);
+                }
+
+                if (status & IRQ_RXOVER)
+                        rx_start(info);
+        }
+
+        if (status & IRQ_DSR)
+                dsr_change(info);
+        if (status & IRQ_CTS)
+                cts_change(info);
+        if (status & IRQ_DCD)
+                dcd_change(info);
+        if (status & IRQ_RI)
+                ri_change(info);
+}
+
+static void isr_rdma(struct slgt_info *info)
+{
+        unsigned int status = rd_reg32(info, RDCSR);
+
+        DBGISR(("%s isr_rdma status=%08x\n", info->device_name, status));
+
+        /* RDCSR (rx DMA control/status)
+         *
+         * 31..07  reserved
+         * 06      save status byte to DMA buffer
+         * 05      error
+         * 04      eol (end of list)
+         * 03      eob (end of buffer)
+         * 02      IRQ enable
+         * 01      reset
+         * 00      enable
+         */
+        wr_reg32(info, RDCSR, status);  /* clear pending */
+
+        if (status & (BIT5 + BIT4)) {
+                DBGISR(("%s isr_rdma rx_restart=1\n", info->device_name));
+                info->rx_restart = 1;
+        }
+        info->pending_bh |= BH_RECEIVE;
+}
+
+static void isr_tdma(struct slgt_info *info)
+{
+        unsigned int status = rd_reg32(info, TDCSR);
+
+        DBGISR(("%s isr_tdma status=%08x\n", info->device_name, status));
+
+        /* TDCSR (tx DMA control/status)
+         *
+         * 31..06  reserved
+         * 05      error
+         * 04      eol (end of list)
+         * 03      eob (end of buffer)
+         * 02      IRQ enable
+         * 01      reset
+         * 00      enable
+         */
+        wr_reg32(info, TDCSR, status);  /* clear pending */
+
+        if (status & (BIT5 + BIT4 + BIT3)) {
+                // another transmit buffer has completed
+                // run bottom half to get more send data from user
+                info->pending_bh |= BH_TRANSMIT;
+        }
+}
+
+static void isr_txeom(struct slgt_info *info, unsigned short status)
+{
+        DBGISR(("%s txeom status=%04x\n", info->device_name, status));
+
+        slgt_irq_off(info, IRQ_TXDATA + IRQ_TXIDLE + IRQ_TXUNDER);
+        tdma_reset(info);
+        reset_tbufs(info);
+        if (status & IRQ_TXUNDER) {
+                unsigned short val = rd_reg16(info, TCR);
+                wr_reg16(info, TCR, (unsigned short)(val | BIT2)); /* set reset bit */
+                wr_reg16(info, TCR, val); /* clear reset bit */
+        }
+
+        if (info->tx_active) {
+                if (info->params.mode != MGSL_MODE_ASYNC) {
+                        if (status & IRQ_TXUNDER)
+                                info->icount.txunder++;
+                        else if (status & IRQ_TXIDLE)
+                                info->icount.txok++;
+                }
+
+                info->tx_active = 0;
+                info->tx_count = 0;
+
+                del_timer(&info->tx_timer);
+
+                if (info->params.mode != MGSL_MODE_ASYNC && info->drop_rts_on_tx_done) {
+                        info->signals &= ~SerialSignal_RTS;
+                        info->drop_rts_on_tx_done = 0;
+                        set_signals(info);
+                }
+
+#ifdef CONFIG_HDLC
+                if (info->netcount)
+                        hdlcdev_tx_done(info);
+                else
+#endif
+                {
+                        if (info->tty && (info->tty->stopped || info->tty->hw_stopped)) {
+                                tx_stop(info);
+                                return;
+                        }
+                        info->pending_bh |= BH_TRANSMIT;
+                }
+        }
+}
+
+/* interrupt service routine
+ *
+ *      irq     interrupt number
+ *      dev_id  device ID supplied during interrupt registration
+ *      regs    interrupted processor context
+ */
+static irqreturn_t slgt_interrupt(int irq, void *dev_id, struct pt_regs * regs)
+{
+        struct slgt_info *info;
+        unsigned int gsr;
+        unsigned int i;
+
+        DBGISR(("slgt_interrupt irq=%d entry\n", irq));
+
+        info = dev_id;
+        if (!info)
+                return IRQ_NONE;
+
+        spin_lock(&info->lock);
+
+        while((gsr = rd_reg32(info, GSR) & 0xffffff00)) {
+                DBGISR(("%s gsr=%08x\n", info->device_name, gsr));
+                info->irq_occurred = 1;
+                for(i=0; i < info->port_count ; i++) {
+                        if (info->port_array[i] == NULL)
+                                continue;
+                        if (gsr & (BIT8 << i))
+                                isr_serial(info->port_array[i]);
+                        if (gsr & (BIT16 << (i*2)))
+                                isr_rdma(info->port_array[i]);
+                        if (gsr & (BIT17 << (i*2)))
+                                isr_tdma(info->port_array[i]);
+                }
+        }
+
+        for(i=0; i < info->port_count ; i++) {
+                struct slgt_info *port = info->port_array[i];
+
+                if (port && (port->count || port->netcount) &&
+                    port->pending_bh && !port->bh_running &&
+                    !port->bh_requested) {
+                        DBGISR(("%s bh queued\n", port->device_name));
+                        schedule_work(&port->task);
+                        port->bh_requested = 1;
+                }
+        }
+
+        spin_unlock(&info->lock);
+
+        DBGISR(("slgt_interrupt irq=%d exit\n", irq));
+        return IRQ_HANDLED;
+}
+
+static int startup(struct slgt_info *info)
+{
+        DBGINFO(("%s startup\n", info->device_name));
+
+        if (info->flags & ASYNC_INITIALIZED)
+                return 0;
+
+        if (!info->tx_buf) {
+                info->tx_buf = kmalloc(info->max_frame_size, GFP_KERNEL);
+                if (!info->tx_buf) {
+                        DBGERR(("%s can't allocate tx buffer\n", info->device_name));
+                        return -ENOMEM;
+                }
+        }
+
+        info->pending_bh = 0;
+
+        memset(&info->icount, 0, sizeof(info->icount));
+
+        /* program hardware for current parameters */
+        change_params(info);
+
+        if (info->tty)
+                clear_bit(TTY_IO_ERROR, &info->tty->flags);
+
+        info->flags |= ASYNC_INITIALIZED;
+
+        return 0;
+}
+
+/*
+ *  called by close() and hangup() to shutdown hardware
+ */
+static void shutdown(struct slgt_info *info)
+{
+        unsigned long flags;
+
+        if (!(info->flags & ASYNC_INITIALIZED))
+                return;
+
+        DBGINFO(("%s shutdown\n", info->device_name));
+
+        /* clear status wait queue because status changes */
+        /* can't happen after shutting down the hardware */
+        wake_up_interruptible(&info->status_event_wait_q);
+        wake_up_interruptible(&info->event_wait_q);
+
+        del_timer_sync(&info->tx_timer);
+        del_timer_sync(&info->rx_timer);
+
+        kfree(info->tx_buf);
+        info->tx_buf = NULL;
+
+        spin_lock_irqsave(&info->lock,flags);
+
+        tx_stop(info);
+        rx_stop(info);
+
+        slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
+
+        if (!info->tty || info->tty->termios->c_cflag & HUPCL) {
+                info->signals &= ~(SerialSignal_DTR + SerialSignal_RTS);
+                set_signals(info);
+        }
+
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        if (info->tty)
+                set_bit(TTY_IO_ERROR, &info->tty->flags);
+
+        info->flags &= ~ASYNC_INITIALIZED;
+}
+
+static void program_hw(struct slgt_info *info)
+{
+        unsigned long flags;
+
+        spin_lock_irqsave(&info->lock,flags);
+
+        rx_stop(info);
+        tx_stop(info);
+
+        if (info->params.mode == MGSL_MODE_HDLC ||
+            info->params.mode == MGSL_MODE_RAW ||
+            info->netcount)
+                hdlc_mode(info);
+        else
+                async_mode(info);
+
+        set_signals(info);
+
+        info->dcd_chkcount = 0;
+        info->cts_chkcount = 0;
+        info->ri_chkcount = 0;
+        info->dsr_chkcount = 0;
+
+        slgt_irq_on(info, IRQ_DCD | IRQ_CTS | IRQ_DSR);
+        get_signals(info);
+
+        if (info->netcount ||
+            (info->tty && info->tty->termios->c_cflag & CREAD))
+                rx_start(info);
+
+        spin_unlock_irqrestore(&info->lock,flags);
+}
+
+/*
+ * reconfigure adapter based on new parameters
+ */
+static void change_params(struct slgt_info *info)
+{
+        unsigned cflag;
+        int bits_per_char;
+
+        if (!info->tty || !info->tty->termios)
+                return;
+        DBGINFO(("%s change_params\n", info->device_name));
+
+        cflag = info->tty->termios->c_cflag;
+
+        /* if B0 rate (hangup) specified then negate DTR and RTS */
+        /* otherwise assert DTR and RTS */
+        if (cflag & CBAUD)
+                info->signals |= SerialSignal_RTS + SerialSignal_DTR;
+        else
+                info->signals &= ~(SerialSignal_RTS + SerialSignal_DTR);
+
+        /* byte size and parity */
+
+        switch (cflag & CSIZE) {
+        case CS5: info->params.data_bits = 5; break;
+        case CS6: info->params.data_bits = 6; break;
+        case CS7: info->params.data_bits = 7; break;
+        case CS8: info->params.data_bits = 8; break;
+        default:  info->params.data_bits = 7; break;
+        }
+
+        info->params.stop_bits = (cflag & CSTOPB) ? 2 : 1;
+
+        if (cflag & PARENB)
+                info->params.parity = (cflag & PARODD) ? ASYNC_PARITY_ODD : ASYNC_PARITY_EVEN;
+        else
+                info->params.parity = ASYNC_PARITY_NONE;
+
+        /* calculate number of jiffies to transmit a full
+         * FIFO (32 bytes) at specified data rate
+         */
+        bits_per_char = info->params.data_bits +
+                        info->params.stop_bits + 1;
+
+        info->params.data_rate = tty_get_baud_rate(info->tty);
+
+        if (info->params.data_rate) {
+                info->timeout = (32*HZ*bits_per_char) /
+                                info->params.data_rate;
+        }
+        info->timeout += HZ/50;         /* Add .02 seconds of slop */
+
+        if (cflag & CRTSCTS)
+                info->flags |= ASYNC_CTS_FLOW;
+        else
+                info->flags &= ~ASYNC_CTS_FLOW;
+
+        if (cflag & CLOCAL)
+                info->flags &= ~ASYNC_CHECK_CD;
+        else
+                info->flags |= ASYNC_CHECK_CD;
+
+        /* process tty input control flags */
+
+        info->read_status_mask = IRQ_RXOVER;
+        if (I_INPCK(info->tty))
+                info->read_status_mask |= MASK_PARITY | MASK_FRAMING;
+        if (I_BRKINT(info->tty) || I_PARMRK(info->tty))
+                info->read_status_mask |= MASK_BREAK;
+        if (I_IGNPAR(info->tty))
+                info->ignore_status_mask |= MASK_PARITY | MASK_FRAMING;
+        if (I_IGNBRK(info->tty)) {
+                info->ignore_status_mask |= MASK_BREAK;
+                /* If ignoring parity and break indicators, ignore
+                 * overruns too.  (For real raw support).
+                 */
+                if (I_IGNPAR(info->tty))
+                        info->ignore_status_mask |= MASK_OVERRUN;
+        }
+
+        program_hw(info);
+}
+
+static int get_stats(struct slgt_info *info, struct mgsl_icount __user *user_icount)
+{
+        DBGINFO(("%s get_stats\n",  info->device_name));
+        if (!user_icount) {
+                memset(&info->icount, 0, sizeof(info->icount));
+        } else {
+                if (copy_to_user(user_icount, &info->icount, sizeof(struct mgsl_icount)))
+                        return -EFAULT;
+        }
+        return 0;
+}
+
+static int get_params(struct slgt_info *info, MGSL_PARAMS __user *user_params)
+{
+        DBGINFO(("%s get_params\n", info->device_name));
+        if (copy_to_user(user_params, &info->params, sizeof(MGSL_PARAMS)))
+                return -EFAULT;
+        return 0;
+}
+
+static int set_params(struct slgt_info *info, MGSL_PARAMS __user *new_params)
+{
+        unsigned long flags;
+        MGSL_PARAMS tmp_params;
+
+        DBGINFO(("%s set_params\n", info->device_name));
+        if (copy_from_user(&tmp_params, new_params, sizeof(MGSL_PARAMS)))
+                return -EFAULT;
+
+        spin_lock_irqsave(&info->lock, flags);
+        memcpy(&info->params, &tmp_params, sizeof(MGSL_PARAMS));
+        spin_unlock_irqrestore(&info->lock, flags);
+
+        change_params(info);
+
+        return 0;
+}
+
+static int get_txidle(struct slgt_info *info, int __user *idle_mode)
+{
+        DBGINFO(("%s get_txidle=%d\n", info->device_name, info->idle_mode));
+        if (put_user(info->idle_mode, idle_mode))
+                return -EFAULT;
+        return 0;
+}
+
+static int set_txidle(struct slgt_info *info, int idle_mode)
+{
+        unsigned long flags;
+        DBGINFO(("%s set_txidle(%d)\n", info->device_name, idle_mode));
+        spin_lock_irqsave(&info->lock,flags);
+        info->idle_mode = idle_mode;
+        tx_set_idle(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+static int tx_enable(struct slgt_info *info, int enable)
+{
+        unsigned long flags;
+        DBGINFO(("%s tx_enable(%d)\n", info->device_name, enable));
+        spin_lock_irqsave(&info->lock,flags);
+        if (enable) {
+                if (!info->tx_enabled)
+                        tx_start(info);
+        } else {
+                if (info->tx_enabled)
+                        tx_stop(info);
+        }
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+/*
+ * abort transmit HDLC frame
+ */
+static int tx_abort(struct slgt_info *info)
+{
+        unsigned long flags;
+        DBGINFO(("%s tx_abort\n", info->device_name));
+        spin_lock_irqsave(&info->lock,flags);
+        tdma_reset(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+static int rx_enable(struct slgt_info *info, int enable)
+{
+        unsigned long flags;
+        DBGINFO(("%s rx_enable(%d)\n", info->device_name, enable));
+        spin_lock_irqsave(&info->lock,flags);
+        if (enable) {
+                if (!info->rx_enabled)
+                        rx_start(info);
+        } else {
+                if (info->rx_enabled)
+                        rx_stop(info);
+        }
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+/*
+ *  wait for specified event to occur
+ */
+static int wait_mgsl_event(struct slgt_info *info, int __user *mask_ptr)
+{
+        unsigned long flags;
+        int s;
+        int rc=0;
+        struct mgsl_icount cprev, cnow;
+        int events;
+        int mask;
+        struct  _input_signal_events oldsigs, newsigs;
+        DECLARE_WAITQUEUE(wait, current);
+
+        if (get_user(mask, mask_ptr))
+                return -EFAULT;
+
+        DBGINFO(("%s wait_mgsl_event(%d)\n", info->device_name, mask));
+
+        spin_lock_irqsave(&info->lock,flags);
+
+        /* return immediately if state matches requested events */
+        get_signals(info);
+        s = info->signals;
+
+        events = mask &
+                ( ((s & SerialSignal_DSR) ? MgslEvent_DsrActive:MgslEvent_DsrInactive) +
+                  ((s & SerialSignal_DCD) ? MgslEvent_DcdActive:MgslEvent_DcdInactive) +
+                  ((s & SerialSignal_CTS) ? MgslEvent_CtsActive:MgslEvent_CtsInactive) +
+                  ((s & SerialSignal_RI)  ? MgslEvent_RiActive :MgslEvent_RiInactive) );
+        if (events) {
+                spin_unlock_irqrestore(&info->lock,flags);
+                goto exit;
+        }
+
+        /* save current irq counts */
+        cprev = info->icount;
+        oldsigs = info->input_signal_events;
+
+        /* enable hunt and idle irqs if needed */
+        if (mask & (MgslEvent_ExitHuntMode+MgslEvent_IdleReceived)) {
+                unsigned short val = rd_reg16(info, SCR);
+                if (!(val & IRQ_RXIDLE))
+                        wr_reg16(info, SCR, (unsigned short)(val | IRQ_RXIDLE));
+        }
+
+        set_current_state(TASK_INTERRUPTIBLE);
+        add_wait_queue(&info->event_wait_q, &wait);
+
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        for(;;) {
+                schedule();
+                if (signal_pending(current)) {
+                        rc = -ERESTARTSYS;
+                        break;
+                }
+
+                /* get current irq counts */
+                spin_lock_irqsave(&info->lock,flags);
+                cnow = info->icount;
+                newsigs = info->input_signal_events;
+                set_current_state(TASK_INTERRUPTIBLE);
+                spin_unlock_irqrestore(&info->lock,flags);
+
+                /* if no change, wait aborted for some reason */
+                if (newsigs.dsr_up   == oldsigs.dsr_up   &&
+                    newsigs.dsr_down == oldsigs.dsr_down &&
+                    newsigs.dcd_up   == oldsigs.dcd_up   &&
+                    newsigs.dcd_down == oldsigs.dcd_down &&
+                    newsigs.cts_up   == oldsigs.cts_up   &&
+                    newsigs.cts_down == oldsigs.cts_down &&
+                    newsigs.ri_up    == oldsigs.ri_up    &&
+                    newsigs.ri_down  == oldsigs.ri_down  &&
+                    cnow.exithunt    == cprev.exithunt   &&
+                    cnow.rxidle      == cprev.rxidle) {
+                        rc = -EIO;
+                        break;
+                }
+
+                events = mask &
+                        ( (newsigs.dsr_up   != oldsigs.dsr_up   ? MgslEvent_DsrActive:0)   +
+                          (newsigs.dsr_down != oldsigs.dsr_down ? MgslEvent_DsrInactive:0) +
+                          (newsigs.dcd_up   != oldsigs.dcd_up   ? MgslEvent_DcdActive:0)   +
+                          (newsigs.dcd_down != oldsigs.dcd_down ? MgslEvent_DcdInactive:0) +
+                          (newsigs.cts_up   != oldsigs.cts_up   ? MgslEvent_CtsActive:0)   +
+                          (newsigs.cts_down != oldsigs.cts_down ? MgslEvent_CtsInactive:0) +
+                          (newsigs.ri_up    != oldsigs.ri_up    ? MgslEvent_RiActive:0)    +
+                          (newsigs.ri_down  != oldsigs.ri_down  ? MgslEvent_RiInactive:0)  +
+                          (cnow.exithunt    != cprev.exithunt   ? MgslEvent_ExitHuntMode:0) +
+                          (cnow.rxidle      != cprev.rxidle     ? MgslEvent_IdleReceived:0) );
+                if (events)
+                        break;
+
+                cprev = cnow;
+                oldsigs = newsigs;
+        }
+
+        remove_wait_queue(&info->event_wait_q, &wait);
+        set_current_state(TASK_RUNNING);
+
+
+        if (mask & (MgslEvent_ExitHuntMode + MgslEvent_IdleReceived)) {
+                spin_lock_irqsave(&info->lock,flags);
+                if (!waitqueue_active(&info->event_wait_q)) {
+                        /* disable enable exit hunt mode/idle rcvd IRQs */
+                        wr_reg16(info, SCR,
+                                (unsigned short)(rd_reg16(info, SCR) & ~IRQ_RXIDLE));
+                }
+                spin_unlock_irqrestore(&info->lock,flags);
+        }
+exit:
+        if (rc == 0)
+                rc = put_user(events, mask_ptr);
+        return rc;
+}
+
+static int get_interface(struct slgt_info *info, int __user *if_mode)
+{
+        DBGINFO(("%s get_interface=%x\n", info->device_name, info->if_mode));
+        if (put_user(info->if_mode, if_mode))
+                return -EFAULT;
+        return 0;
+}
+
+static int set_interface(struct slgt_info *info, int if_mode)
+{
+        unsigned long flags;
+        unsigned char val;
+
+        DBGINFO(("%s set_interface=%x)\n", info->device_name, if_mode));
+        spin_lock_irqsave(&info->lock,flags);
+        info->if_mode = if_mode;
+
+        msc_set_vcr(info);
+
+        /* TCR (tx control) 07  1=RTS driver control */
+        val = rd_reg16(info, TCR);
+        if (info->if_mode & MGSL_INTERFACE_RTS_EN)
+                val |= BIT7;
+        else
+                val &= ~BIT7;
+        wr_reg16(info, TCR, val);
+
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+static int modem_input_wait(struct slgt_info *info,int arg)
+{
+        unsigned long flags;
+        int rc;
+        struct mgsl_icount cprev, cnow;
+        DECLARE_WAITQUEUE(wait, current);
+
+        /* save current irq counts */
+        spin_lock_irqsave(&info->lock,flags);
+        cprev = info->icount;
+        add_wait_queue(&info->status_event_wait_q, &wait);
+        set_current_state(TASK_INTERRUPTIBLE);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        for(;;) {
+                schedule();
+                if (signal_pending(current)) {
+                        rc = -ERESTARTSYS;
+                        break;
+                }
+
+                /* get new irq counts */
+                spin_lock_irqsave(&info->lock,flags);
+                cnow = info->icount;
+                set_current_state(TASK_INTERRUPTIBLE);
+                spin_unlock_irqrestore(&info->lock,flags);
+
+                /* if no change, wait aborted for some reason */
+                if (cnow.rng == cprev.rng && cnow.dsr == cprev.dsr &&
+                    cnow.dcd == cprev.dcd && cnow.cts == cprev.cts) {
+                        rc = -EIO;
+                        break;
+                }
+
+                /* check for change in caller specified modem input */
+                if ((arg & TIOCM_RNG && cnow.rng != cprev.rng) ||
+                    (arg & TIOCM_DSR && cnow.dsr != cprev.dsr) ||
+                    (arg & TIOCM_CD  && cnow.dcd != cprev.dcd) ||
+                    (arg & TIOCM_CTS && cnow.cts != cprev.cts)) {
+                        rc = 0;
+                        break;
+                }
+
+                cprev = cnow;
+        }
+        remove_wait_queue(&info->status_event_wait_q, &wait);
+        set_current_state(TASK_RUNNING);
+        return rc;
+}
+
+/*
+ *  return state of serial control and status signals
+ */
+static int tiocmget(struct tty_struct *tty, struct file *file)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned int result;
+        unsigned long flags;
+
+        spin_lock_irqsave(&info->lock,flags);
+        get_signals(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        result = ((info->signals & SerialSignal_RTS) ? TIOCM_RTS:0) +
+                ((info->signals & SerialSignal_DTR) ? TIOCM_DTR:0) +
+                ((info->signals & SerialSignal_DCD) ? TIOCM_CAR:0) +
+                ((info->signals & SerialSignal_RI)  ? TIOCM_RNG:0) +
+                ((info->signals & SerialSignal_DSR) ? TIOCM_DSR:0) +
+                ((info->signals & SerialSignal_CTS) ? TIOCM_CTS:0);
+
+        DBGINFO(("%s tiocmget value=%08X\n", info->device_name, result));
+        return result;
+}
+
+/*
+ * set modem control signals (DTR/RTS)
+ *
+ *      cmd     signal command: TIOCMBIS = set bit TIOCMBIC = clear bit
+ *              TIOCMSET = set/clear signal values
+ *      value   bit mask for command
+ */
+static int tiocmset(struct tty_struct *tty, struct file *file,
+                    unsigned int set, unsigned int clear)
+{
+        struct slgt_info *info = tty->driver_data;
+        unsigned long flags;
+
+        DBGINFO(("%s tiocmset(%x,%x)\n", info->device_name, set, clear));
+
+        if (set & TIOCM_RTS)
+                info->signals |= SerialSignal_RTS;
+        if (set & TIOCM_DTR)
+                info->signals |= SerialSignal_DTR;
+        if (clear & TIOCM_RTS)
+                info->signals &= ~SerialSignal_RTS;
+        if (clear & TIOCM_DTR)
+                info->signals &= ~SerialSignal_DTR;
+
+        spin_lock_irqsave(&info->lock,flags);
+        set_signals(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+        return 0;
+}
+
+/*
+ *  block current process until the device is ready to open
+ */
+static int block_til_ready(struct tty_struct *tty, struct file *filp,
+                           struct slgt_info *info)
+{
+        DECLARE_WAITQUEUE(wait, current);
+        int             retval;
+        int             do_clocal = 0, extra_count = 0;
+        unsigned long   flags;
+
+        DBGINFO(("%s block_til_ready\n", tty->driver->name));
+
+        if (filp->f_flags & O_NONBLOCK || tty->flags & (1 << TTY_IO_ERROR)){
+                /* nonblock mode is set or port is not enabled */
+                info->flags |= ASYNC_NORMAL_ACTIVE;
+                return 0;
+        }
+
+        if (tty->termios->c_cflag & CLOCAL)
+                do_clocal = 1;
+
+        /* Wait for carrier detect and the line to become
+         * free (i.e., not in use by the callout).  While we are in
+         * this loop, info->count is dropped by one, so that
+         * close() knows when to free things.  We restore it upon
+         * exit, either normal or abnormal.
+         */
+
+        retval = 0;
+        add_wait_queue(&info->open_wait, &wait);
+
+        spin_lock_irqsave(&info->lock, flags);
+        if (!tty_hung_up_p(filp)) {
+                extra_count = 1;
+                info->count--;
+        }
+        spin_unlock_irqrestore(&info->lock, flags);
+        info->blocked_open++;
+
+        while (1) {
+                if ((tty->termios->c_cflag & CBAUD)) {
+                        spin_lock_irqsave(&info->lock,flags);
+                        info->signals |= SerialSignal_RTS + SerialSignal_DTR;
+                        set_signals(info);
+                        spin_unlock_irqrestore(&info->lock,flags);
+                }
+
+                set_current_state(TASK_INTERRUPTIBLE);
+
+                if (tty_hung_up_p(filp) || !(info->flags & ASYNC_INITIALIZED)){
+                        retval = (info->flags & ASYNC_HUP_NOTIFY) ?
+                                        -EAGAIN : -ERESTARTSYS;
+                        break;
+                }
+
+                spin_lock_irqsave(&info->lock,flags);
+                get_signals(info);
+                spin_unlock_irqrestore(&info->lock,flags);
+
+                if (!(info->flags & ASYNC_CLOSING) &&
+                    (do_clocal || (info->signals & SerialSignal_DCD)) ) {
+                        break;
+                }
+
+                if (signal_pending(current)) {
+                        retval = -ERESTARTSYS;
+                        break;
+                }
+
+                DBGINFO(("%s block_til_ready wait\n", tty->driver->name));
+                schedule();
+        }
+
+        set_current_state(TASK_RUNNING);
+        remove_wait_queue(&info->open_wait, &wait);
+
+        if (extra_count)
+                info->count++;
+        info->blocked_open--;
+
+        if (!retval)
+                info->flags |= ASYNC_NORMAL_ACTIVE;
+
+        DBGINFO(("%s block_til_ready ready, rc=%d\n", tty->driver->name, retval));
+        return retval;
+}
+
+static int alloc_tmp_rbuf(struct slgt_info *info)
+{
+        info->tmp_rbuf = kmalloc(info->max_frame_size, GFP_KERNEL);
+        if (info->tmp_rbuf == NULL)
+                return -ENOMEM;
+        return 0;
+}
+
+static void free_tmp_rbuf(struct slgt_info *info)
+{
+        kfree(info->tmp_rbuf);
+        info->tmp_rbuf = NULL;
+}
+
+/*
+ * allocate DMA descriptor lists.
+ */
+static int alloc_desc(struct slgt_info *info)
+{
+        unsigned int i;
+        unsigned int pbufs;
+
+        /* allocate memory to hold descriptor lists */
+        info->bufs = pci_alloc_consistent(info->pdev, DESC_LIST_SIZE, &info->bufs_dma_addr);
+        if (info->bufs == NULL)
+                return -ENOMEM;
+
+        memset(info->bufs, 0, DESC_LIST_SIZE);
+
+        info->rbufs = (struct slgt_desc*)info->bufs;
+        info->tbufs = ((struct slgt_desc*)info->bufs) + info->rbuf_count;
+
+        pbufs = (unsigned int)info->bufs_dma_addr;
+
+        /*
+         * Build circular lists of descriptors
+         */
+
+        for (i=0; i < info->rbuf_count; i++) {
+                /* physical address of this descriptor */
+                info->rbufs[i].pdesc = pbufs + (i * sizeof(struct slgt_desc));
+
+                /* physical address of next descriptor */
+                if (i == info->rbuf_count - 1)
+                        info->rbufs[i].next = cpu_to_le32(pbufs);
+                else
+                        info->rbufs[i].next = cpu_to_le32(pbufs + ((i+1) * sizeof(struct slgt_desc)));
+                set_desc_count(info->rbufs[i], DMABUFSIZE);
+        }
+
+        for (i=0; i < info->tbuf_count; i++) {
+                /* physical address of this descriptor */
+                info->tbufs[i].pdesc = pbufs + ((info->rbuf_count + i) * sizeof(struct slgt_desc));
+
+                /* physical address of next descriptor */
+                if (i == info->tbuf_count - 1)
+                        info->tbufs[i].next = cpu_to_le32(pbufs + info->rbuf_count * sizeof(struct slgt_desc));
+                else
+                        info->tbufs[i].next = cpu_to_le32(pbufs + ((info->rbuf_count + i + 1) * sizeof(struct slgt_desc)));
+        }
+
+        return 0;
+}
+
+static void free_desc(struct slgt_info *info)
+{
+        if (info->bufs != NULL) {
+                pci_free_consistent(info->pdev, DESC_LIST_SIZE, info->bufs, info->bufs_dma_addr);
+                info->bufs  = NULL;
+                info->rbufs = NULL;
+                info->tbufs = NULL;
+        }
+}
+
+static int alloc_bufs(struct slgt_info *info, struct slgt_desc *bufs, int count)
+{
+        int i;
+        for (i=0; i < count; i++) {
+                if ((bufs[i].buf = pci_alloc_consistent(info->pdev, DMABUFSIZE, &bufs[i].buf_dma_addr)) == NULL)
+                        return -ENOMEM;
+                bufs[i].pbuf  = cpu_to_le32((unsigned int)bufs[i].buf_dma_addr);
+        }
+        return 0;
+}
+
+static void free_bufs(struct slgt_info *info, struct slgt_desc *bufs, int count)
+{
+        int i;
+        for (i=0; i < count; i++) {
+                if (bufs[i].buf == NULL)
+                        continue;
+                pci_free_consistent(info->pdev, DMABUFSIZE, bufs[i].buf, bufs[i].buf_dma_addr);
+                bufs[i].buf = NULL;
+        }
+}
+
+static int alloc_dma_bufs(struct slgt_info *info)
+{
+        info->rbuf_count = 32;
+        info->tbuf_count = 32;
+
+        if (alloc_desc(info) < 0 ||
+            alloc_bufs(info, info->rbufs, info->rbuf_count) < 0 ||
+            alloc_bufs(info, info->tbufs, info->tbuf_count) < 0 ||
+            alloc_tmp_rbuf(info) < 0) {
+                DBGERR(("%s DMA buffer alloc fail\n", info->device_name));
+                return -ENOMEM;
+        }
+        reset_rbufs(info);
+        return 0;
+}
+
+static void free_dma_bufs(struct slgt_info *info)
+{
+        if (info->bufs) {
+                free_bufs(info, info->rbufs, info->rbuf_count);
+                free_bufs(info, info->tbufs, info->tbuf_count);
+                free_desc(info);
+        }
+        free_tmp_rbuf(info);
+}
+
+static int claim_resources(struct slgt_info *info)
+{
+        if (request_mem_region(info->phys_reg_addr, SLGT_REG_SIZE, "synclink_gt") == NULL) {
+                DBGERR(("%s reg addr conflict, addr=%08X\n",
+                        info->device_name, info->phys_reg_addr));
+                info->init_error = DiagStatus_AddressConflict;
+                goto errout;
+        }
+        else
+                info->reg_addr_requested = 1;
+
+        info->reg_addr = ioremap(info->phys_reg_addr, PAGE_SIZE);
+        if (!info->reg_addr) {
+                DBGERR(("%s cant map device registers, addr=%08X\n",
+                        info->device_name, info->phys_reg_addr));
+                info->init_error = DiagStatus_CantAssignPciResources;
+                goto errout;
+        }
+        info->reg_addr += info->reg_offset;
+        return 0;
+
+errout:
+        release_resources(info);
+        return -ENODEV;
+}
+
+static void release_resources(struct slgt_info *info)
+{
+        if (info->irq_requested) {
+                free_irq(info->irq_level, info);
+                info->irq_requested = 0;
+        }
+
+        if (info->reg_addr_requested) {
+                release_mem_region(info->phys_reg_addr, SLGT_REG_SIZE);
+                info->reg_addr_requested = 0;
+        }
+
+        if (info->reg_addr) {
+                iounmap(info->reg_addr - info->reg_offset);
+                info->reg_addr = NULL;
+        }
+}
+
+/* Add the specified device instance data structure to the
+ * global linked list of devices and increment the device count.
+ */
+static void add_device(struct slgt_info *info)
+{
+        char *devstr;
+
+        info->next_device = NULL;
+        info->line = slgt_device_count;
+        sprintf(info->device_name, "%s%d", tty_dev_prefix, info->line);
+
+        if (info->line < MAX_DEVICES) {
+                if (maxframe[info->line])
+                        info->max_frame_size = maxframe[info->line];
+                info->dosyncppp = dosyncppp[info->line];
+        }
+
+        slgt_device_count++;
+
+        if (!slgt_device_list)
+                slgt_device_list = info;
+        else {
+                struct slgt_info *current_dev = slgt_device_list;
+                while(current_dev->next_device)
+                        current_dev = current_dev->next_device;
+                current_dev->next_device = info;
+        }
+
+        if (info->max_frame_size < 4096)
+                info->max_frame_size = 4096;
+        else if (info->max_frame_size > 65535)
+                info->max_frame_size = 65535;
+
+        switch(info->pdev->device) {
+        case SYNCLINK_GT_DEVICE_ID:
+                devstr = "GT";
+                break;
+        case SYNCLINK_GT4_DEVICE_ID:
+                devstr = "GT4";
+                break;
+        case SYNCLINK_AC_DEVICE_ID:
+                devstr = "AC";
+                info->params.mode = MGSL_MODE_ASYNC;
+                break;
+        default:
+                devstr = "(unknown model)";
+        }
+        printk("SyncLink %s %s IO=%08x IRQ=%d MaxFrameSize=%u\n",
+                devstr, info->device_name, info->phys_reg_addr,
+                info->irq_level, info->max_frame_size);
+
+#ifdef CONFIG_HDLC
+        hdlcdev_init(info);
+#endif
+}
+
+/*
+ *  allocate device instance structure, return NULL on failure
+ */
+static struct slgt_info *alloc_dev(int adapter_num, int port_num, struct pci_dev *pdev)
+{
+        struct slgt_info *info;
+
+        info = kmalloc(sizeof(struct slgt_info), GFP_KERNEL);
+
+        if (!info) {
+                DBGERR(("%s device alloc failed adapter=%d port=%d\n",
+                        driver_name, adapter_num, port_num));
+        } else {
+                memset(info, 0, sizeof(struct slgt_info));
+                info->magic = MGSL_MAGIC;
+                INIT_WORK(&info->task, bh_handler, info);
+                info->max_frame_size = 4096;
+                info->raw_rx_size = DMABUFSIZE;
+                info->close_delay = 5*HZ/10;
+                info->closing_wait = 30*HZ;
+                init_waitqueue_head(&info->open_wait);
+                init_waitqueue_head(&info->close_wait);
+                init_waitqueue_head(&info->status_event_wait_q);
+                init_waitqueue_head(&info->event_wait_q);
+                spin_lock_init(&info->netlock);
+                memcpy(&info->params,&default_params,sizeof(MGSL_PARAMS));
+                info->idle_mode = HDLC_TXIDLE_FLAGS;
+                info->adapter_num = adapter_num;
+                info->port_num = port_num;
+
+                init_timer(&info->tx_timer);
+                info->tx_timer.data = (unsigned long)info;
+                info->tx_timer.function = tx_timeout;
+
+                init_timer(&info->rx_timer);
+                info->rx_timer.data = (unsigned long)info;
+                info->rx_timer.function = rx_timeout;
+
+                /* Copy configuration info to device instance data */
+                info->pdev = pdev;
+                info->irq_level = pdev->irq;
+                info->phys_reg_addr = pci_resource_start(pdev,0);
+
+                /* veremap works on page boundaries
+                 * map full page starting at the page boundary
+                 */
+                info->reg_offset    = info->phys_reg_addr & (PAGE_SIZE-1);
+                info->phys_reg_addr &= ~(PAGE_SIZE-1);
+
+                info->bus_type = MGSL_BUS_TYPE_PCI;
+                info->irq_flags = SA_SHIRQ;
+
+                info->init_error = -1; /* assume error, set to 0 on successful init */
+        }
+
+        return info;
+}
+
+static void device_init(int adapter_num, struct pci_dev *pdev)
+{
+        struct slgt_info *port_array[SLGT_MAX_PORTS];
+        int i;
+        int port_count = 1;
+
+        if (pdev->device == SYNCLINK_GT4_DEVICE_ID)
+                port_count = 4;
+
+        /* allocate device instances for all ports */
+        for (i=0; i < port_count; ++i) {
+                port_array[i] = alloc_dev(adapter_num, i, pdev);
+                if (port_array[i] == NULL) {
+                        for (--i; i >= 0; --i)
+                                kfree(port_array[i]);
+                        return;
+                }
+        }
+
+        /* give copy of port_array to all ports and add to device list  */
+        for (i=0; i < port_count; ++i) {
+                memcpy(port_array[i]->port_array, port_array, sizeof(port_array));
+                add_device(port_array[i]);
+                port_array[i]->port_count = port_count;
+                spin_lock_init(&port_array[i]->lock);
+        }
+
+        /* Allocate and claim adapter resources */
+        if (!claim_resources(port_array[0])) {
+
+                alloc_dma_bufs(port_array[0]);
+
+                /* copy resource information from first port to others */
+                for (i = 1; i < port_count; ++i) {
+                        port_array[i]->lock      = port_array[0]->lock;
+                        port_array[i]->irq_level = port_array[0]->irq_level;
+                        port_array[i]->reg_addr  = port_array[0]->reg_addr;
+                        alloc_dma_bufs(port_array[i]);
+                }
+
+                if (request_irq(port_array[0]->irq_level,
+                                        slgt_interrupt,
+                                        port_array[0]->irq_flags,
+                                        port_array[0]->device_name,
+                                        port_array[0]) < 0) {
+                        DBGERR(("%s request_irq failed IRQ=%d\n",
+                                port_array[0]->device_name,
+                                port_array[0]->irq_level));
+                } else {
+                        port_array[0]->irq_requested = 1;
+                        adapter_test(port_array[0]);
+                        for (i=1 ; i < port_count ; i++)
+                                port_array[i]->init_error = port_array[0]->init_error;
+                }
+        }
+}
+
+static int __devinit init_one(struct pci_dev *dev,
+                              const struct pci_device_id *ent)
+{
+        if (pci_enable_device(dev)) {
+                printk("error enabling pci device %p\n", dev);
+                return -EIO;
+        }
+        pci_set_master(dev);
+        device_init(slgt_device_count, dev);
+        return 0;
+}
+
+static void __devexit remove_one(struct pci_dev *dev)
+{
+}
+
+static struct tty_operations ops = {
+        .open = open,
+        .close = close,
+        .write = write,
+        .put_char = put_char,
+        .flush_chars = flush_chars,
+        .write_room = write_room,
+        .chars_in_buffer = chars_in_buffer,
+        .flush_buffer = flush_buffer,
+        .ioctl = ioctl,
+        .throttle = throttle,
+        .unthrottle = unthrottle,
+        .send_xchar = send_xchar,
+        .break_ctl = set_break,
+        .wait_until_sent = wait_until_sent,
+        .read_proc = read_proc,
+        .set_termios = set_termios,
+        .stop = tx_hold,
+        .start = tx_release,
+        .hangup = hangup,
+        .tiocmget = tiocmget,
+        .tiocmset = tiocmset,
+};
+
+static void slgt_cleanup(void)
+{
+        int rc;
+        struct slgt_info *info;
+        struct slgt_info *tmp;
+
+        printk("unload %s %s\n", driver_name, driver_version);
+
+        if (serial_driver) {
+                if ((rc = tty_unregister_driver(serial_driver)))
+                        DBGERR(("tty_unregister_driver error=%d\n", rc));
+                put_tty_driver(serial_driver);
+        }
+
+        /* reset devices */
+        info = slgt_device_list;
+        while(info) {
+                reset_port(info);
+                info = info->next_device;
+        }
+
+        /* release devices */
+        info = slgt_device_list;
+        while(info) {
+#ifdef CONFIG_HDLC
+                hdlcdev_exit(info);
+#endif
+                free_dma_bufs(info);
+                free_tmp_rbuf(info);
+                if (info->port_num == 0)
+                        release_resources(info);
+                tmp = info;
+                info = info->next_device;
+                kfree(tmp);
+        }
+
+        if (pci_registered)
+                pci_unregister_driver(&pci_driver);
+}
+
+/*
+ *  Driver initialization entry point.
+ */
+static int __init slgt_init(void)
+{
+        int rc;
+
+        printk("%s %s\n", driver_name, driver_version);
+
+        slgt_device_count = 0;
+        if ((rc = pci_register_driver(&pci_driver)) < 0) {
+                printk("%s pci_register_driver error=%d\n", driver_name, rc);
+                return rc;
+        }
+        pci_registered = 1;
+
+        if (!slgt_device_list) {
+                printk("%s no devices found\n",driver_name);
+                return -ENODEV;
+        }
+
+        serial_driver = alloc_tty_driver(MAX_DEVICES);
+        if (!serial_driver) {
+                rc = -ENOMEM;
+                goto error;
+        }
+
+        /* Initialize the tty_driver structure */
+
+        serial_driver->owner = THIS_MODULE;
+        serial_driver->driver_name = tty_driver_name;
+        serial_driver->name = tty_dev_prefix;
+        serial_driver->major = ttymajor;
+        serial_driver->minor_start = 64;
+        serial_driver->type = TTY_DRIVER_TYPE_SERIAL;
+        serial_driver->subtype = SERIAL_TYPE_NORMAL;
+        serial_driver->init_termios = tty_std_termios;
+        serial_driver->init_termios.c_cflag =
+                B9600 | CS8 | CREAD | HUPCL | CLOCAL;
+        serial_driver->flags = TTY_DRIVER_REAL_RAW;
+        tty_set_operations(serial_driver, &ops);
+        if ((rc = tty_register_driver(serial_driver)) < 0) {
+                DBGERR(("%s can't register serial driver\n", driver_name));
+                put_tty_driver(serial_driver);
+                serial_driver = NULL;
+                goto error;
+        }
+
+        printk("%s %s, tty major#%d\n",
+                driver_name, driver_version,
+                serial_driver->major);
+
+        return 0;
+
+error:
+        slgt_cleanup();
+        return rc;
+}
+
+static void __exit slgt_exit(void)
+{
+        slgt_cleanup();
+}
+
+module_init(slgt_init);
+module_exit(slgt_exit);
+
+/*
+ * register access routines
+ */
+
+#define CALC_REGADDR() \
+        unsigned long reg_addr = ((unsigned long)info->reg_addr) + addr; \
+        if (addr >= 0x80) \
+                reg_addr += (info->port_num) * 32;
+
+static __u8 rd_reg8(struct slgt_info *info, unsigned int addr)
+{
+        CALC_REGADDR();
+        return readb((void __iomem *)reg_addr);
+}
+
+static void wr_reg8(struct slgt_info *info, unsigned int addr, __u8 value)
+{
+        CALC_REGADDR();
+        writeb(value, (void __iomem *)reg_addr);
+}
+
+static __u16 rd_reg16(struct slgt_info *info, unsigned int addr)
+{
+        CALC_REGADDR();
+        return readw((void __iomem *)reg_addr);
+}
+
+static void wr_reg16(struct slgt_info *info, unsigned int addr, __u16 value)
+{
+        CALC_REGADDR();
+        writew(value, (void __iomem *)reg_addr);
+}
+
+static __u32 rd_reg32(struct slgt_info *info, unsigned int addr)
+{
+        CALC_REGADDR();
+        return readl((void __iomem *)reg_addr);
+}
+
+static void wr_reg32(struct slgt_info *info, unsigned int addr, __u32 value)
+{
+        CALC_REGADDR();
+        writel(value, (void __iomem *)reg_addr);
+}
+
+static void rdma_reset(struct slgt_info *info)
+{
+        unsigned int i;
+
+        /* set reset bit */
+        wr_reg32(info, RDCSR, BIT1);
+
+        /* wait for enable bit cleared */
+        for(i=0 ; i < 1000 ; i++)
+                if (!(rd_reg32(info, RDCSR) & BIT0))
+                        break;
+}
+
+static void tdma_reset(struct slgt_info *info)
+{
+        unsigned int i;
+
+        /* set reset bit */
+        wr_reg32(info, TDCSR, BIT1);
+
+        /* wait for enable bit cleared */
+        for(i=0 ; i < 1000 ; i++)
+                if (!(rd_reg32(info, TDCSR) & BIT0))
+                        break;
+}
+
+/*
+ * enable internal loopback
+ * TxCLK and RxCLK are generated from BRG
+ * and TxD is looped back to RxD internally.
+ */
+static void enable_loopback(struct slgt_info *info)
+{
+        /* SCR (serial control) BIT2=looopback enable */
+        wr_reg16(info, SCR, (unsigned short)(rd_reg16(info, SCR) | BIT2));
+
+        if (info->params.mode != MGSL_MODE_ASYNC) {
+                /* CCR (clock control)
+                 * 07..05  tx clock source (010 = BRG)
+                 * 04..02  rx clock source (010 = BRG)
+                 * 01      auxclk enable   (0 = disable)
+                 * 00      BRG enable      (1 = enable)
+                 *
+                 * 0100 1001
+                 */
+                wr_reg8(info, CCR, 0x49);
+
+                /* set speed if available, otherwise use default */
+                if (info->params.clock_speed)
+                        set_rate(info, info->params.clock_speed);
+                else
+                        set_rate(info, 3686400);
+        }
+}
+
+/*
+ *  set baud rate generator to specified rate
+ */
+static void set_rate(struct slgt_info *info, u32 rate)
+{
+        unsigned int div;
+        static unsigned int osc = 14745600;
+
+        /* div = osc/rate - 1
+         *
+         * Round div up if osc/rate is not integer to
+         * force to next slowest rate.
+         */
+
+        if (rate) {
+                div = osc/rate;
+                if (!(osc % rate) && div)
+                        div--;
+                wr_reg16(info, BDR, (unsigned short)div);
+        }
+}
+
+static void rx_stop(struct slgt_info *info)
+{
+        unsigned short val;
+
+        /* disable and reset receiver */
+        val = rd_reg16(info, RCR) & ~BIT1;          /* clear enable bit */
+        wr_reg16(info, RCR, (unsigned short)(val | BIT2)); /* set reset bit */
+        wr_reg16(info, RCR, val);                  /* clear reset bit */
+
+        slgt_irq_off(info, IRQ_RXOVER + IRQ_RXDATA + IRQ_RXIDLE);
+
+        /* clear pending rx interrupts */
+        wr_reg16(info, SSR, IRQ_RXIDLE + IRQ_RXOVER);
+
+        rdma_reset(info);
+
+        info->rx_enabled = 0;
+        info->rx_restart = 0;
+}
+
+static void rx_start(struct slgt_info *info)
+{
+        unsigned short val;
+
+        slgt_irq_off(info, IRQ_RXOVER + IRQ_RXDATA);
+
+        /* clear pending rx overrun IRQ */
+        wr_reg16(info, SSR, IRQ_RXOVER);
+
+        /* reset and disable receiver */
+        val = rd_reg16(info, RCR) & ~BIT1; /* clear enable bit */
+        wr_reg16(info, RCR, (unsigned short)(val | BIT2)); /* set reset bit */
+        wr_reg16(info, RCR, val);                  /* clear reset bit */
+
+        rdma_reset(info);
+        reset_rbufs(info);
+
+        /* set 1st descriptor address */
+        wr_reg32(info, RDDAR, info->rbufs[0].pdesc);
+
+        if (info->params.mode != MGSL_MODE_ASYNC) {
+                /* enable rx DMA and DMA interrupt */
+                wr_reg32(info, RDCSR, (BIT2 + BIT0));
+        } else {
+                /* enable saving of rx status, rx DMA and DMA interrupt */
+                wr_reg32(info, RDCSR, (BIT6 + BIT2 + BIT0));
+        }
+
+        slgt_irq_on(info, IRQ_RXOVER);
+
+        /* enable receiver */
+        wr_reg16(info, RCR, (unsigned short)(rd_reg16(info, RCR) | BIT1));
+
+        info->rx_restart = 0;
+        info->rx_enabled = 1;
+}
+
+static void tx_start(struct slgt_info *info)
+{
+        if (!info->tx_enabled) {
+                wr_reg16(info, TCR,
+                        (unsigned short)(rd_reg16(info, TCR) | BIT1));
+                info->tx_enabled = TRUE;
+        }
+
+        if (info->tx_count) {
+                info->drop_rts_on_tx_done = 0;
+
+                if (info->params.mode != MGSL_MODE_ASYNC) {
+                        if (info->params.flags & HDLC_FLAG_AUTO_RTS) {
+                                get_signals(info);
+                                if (!(info->signals & SerialSignal_RTS)) {
+                                        info->signals |= SerialSignal_RTS;
+                                        set_signals(info);
+                                        info->drop_rts_on_tx_done = 1;
+                                }
+                        }
+
+                        slgt_irq_off(info, IRQ_TXDATA);
+                        slgt_irq_on(info, IRQ_TXUNDER + IRQ_TXIDLE);
+                        /* clear tx idle and underrun status bits */
+                        wr_reg16(info, SSR, (unsigned short)(IRQ_TXIDLE + IRQ_TXUNDER));
+
+                        if (!(rd_reg32(info, TDCSR) & BIT0)) {
+                                /* tx DMA stopped, restart tx DMA */
+                                tdma_reset(info);
+                                /* set 1st descriptor address */
+                                wr_reg32(info, TDDAR, info->tbufs[info->tbuf_start].pdesc);
+                                if (info->params.mode == MGSL_MODE_RAW)
+                                        wr_reg32(info, TDCSR, BIT2 + BIT0); /* IRQ + DMA enable */
+                                else
+                                        wr_reg32(info, TDCSR, BIT0); /* DMA enable */
+                        }
+
+                        if (info->params.mode != MGSL_MODE_RAW) {
+                                info->tx_timer.expires = jiffies + msecs_to_jiffies(5000);
+                                add_timer(&info->tx_timer);
+                        }
+                } else {
+                        tdma_reset(info);
+                        /* set 1st descriptor address */
+                        wr_reg32(info, TDDAR, info->tbufs[info->tbuf_start].pdesc);
+
+                        slgt_irq_off(info, IRQ_TXDATA);
+                        slgt_irq_on(info, IRQ_TXIDLE);
+                        /* clear tx idle status bit */
+                        wr_reg16(info, SSR, IRQ_TXIDLE);
+
+                        /* enable tx DMA */
+                        wr_reg32(info, TDCSR, BIT0);
+                }
+
+                info->tx_active = 1;
+        }
+}
+
+static void tx_stop(struct slgt_info *info)
+{
+        unsigned short val;
+
+        del_timer(&info->tx_timer);
+
+        tdma_reset(info);
+
+        /* reset and disable transmitter */
+        val = rd_reg16(info, TCR) & ~BIT1;          /* clear enable bit */
+        wr_reg16(info, TCR, (unsigned short)(val | BIT2)); /* set reset bit */
+        wr_reg16(info, TCR, val);                  /* clear reset */
+
+        slgt_irq_off(info, IRQ_TXDATA + IRQ_TXIDLE + IRQ_TXUNDER);
+
+        /* clear tx idle and underrun status bit */
+        wr_reg16(info, SSR, (unsigned short)(IRQ_TXIDLE + IRQ_TXUNDER));
+
+        reset_tbufs(info);
+
+        info->tx_enabled = 0;
+        info->tx_active  = 0;
+}
+
+static void reset_port(struct slgt_info *info)
+{
+        if (!info->reg_addr)
+                return;
+
+        tx_stop(info);
+        rx_stop(info);
+
+        info->signals &= ~(SerialSignal_DTR + SerialSignal_RTS);
+        set_signals(info);
+
+        slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
+}
+
+static void reset_adapter(struct slgt_info *info)
+{
+        int i;
+        for (i=0; i < info->port_count; ++i) {
+                if (info->port_array[i])
+                        reset_port(info->port_array[i]);
+        }
+}
+
+static void async_mode(struct slgt_info *info)
+{
+        unsigned short val;
+
+        slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
+        tx_stop(info);
+        rx_stop(info);
+
+        /* TCR (tx control)
+         *
+         * 15..13  mode, 010=async
+         * 12..10  encoding, 000=NRZ
+         * 09      parity enable
+         * 08      1=odd parity, 0=even parity
+         * 07      1=RTS driver control
+         * 06      1=break enable
+         * 05..04  character length
+         *         00=5 bits
+         *         01=6 bits
+         *         10=7 bits
+         *         11=8 bits
+         * 03      0=1 stop bit, 1=2 stop bits
+         * 02      reset
+         * 01      enable
+         * 00      auto-CTS enable
+         */
+        val = 0x4000;
+
+        if (info->if_mode & MGSL_INTERFACE_RTS_EN)
+                val |= BIT7;
+
+        if (info->params.parity != ASYNC_PARITY_NONE) {
+                val |= BIT9;
+                if (info->params.parity == ASYNC_PARITY_ODD)
+                        val |= BIT8;
+        }
+
+        switch (info->params.data_bits)
+        {
+        case 6: val |= BIT4; break;
+        case 7: val |= BIT5; break;
+        case 8: val |= BIT5 + BIT4; break;
+        }
+
+        if (info->params.stop_bits != 1)
+                val |= BIT3;
+
+        if (info->params.flags & HDLC_FLAG_AUTO_CTS)
+                val |= BIT0;
+
+        wr_reg16(info, TCR, val);
+
+        /* RCR (rx control)
+         *
+         * 15..13  mode, 010=async
+         * 12..10  encoding, 000=NRZ
+         * 09      parity enable
+         * 08      1=odd parity, 0=even parity
+         * 07..06  reserved, must be 0
+         * 05..04  character length
+         *         00=5 bits
+         *         01=6 bits
+         *         10=7 bits
+         *         11=8 bits
+         * 03      reserved, must be zero
+         * 02      reset
+         * 01      enable
+         * 00      auto-DCD enable
+         */
+        val = 0x4000;
+
+        if (info->params.parity != ASYNC_PARITY_NONE) {
+                val |= BIT9;
+                if (info->params.parity == ASYNC_PARITY_ODD)
+                        val |= BIT8;
+        }
+
+        switch (info->params.data_bits)
+        {
+        case 6: val |= BIT4; break;
+        case 7: val |= BIT5; break;
+        case 8: val |= BIT5 + BIT4; break;
+        }
+
+        if (info->params.flags & HDLC_FLAG_AUTO_DCD)
+                val |= BIT0;
+
+        wr_reg16(info, RCR, val);
+
+        /* CCR (clock control)
+         *
+         * 07..05  011 = tx clock source is BRG/16
+         * 04..02  010 = rx clock source is BRG
+         * 01      0 = auxclk disabled
+         * 00      1 = BRG enabled
+         *
+         * 0110 1001
+         */
+        wr_reg8(info, CCR, 0x69);
+
+        msc_set_vcr(info);
+
+        tx_set_idle(info);
+
+        /* SCR (serial control)
+         *
+         * 15  1=tx req on FIFO half empty
+         * 14  1=rx req on FIFO half full
+         * 13  tx data  IRQ enable
+         * 12  tx idle  IRQ enable
+         * 11  rx break on IRQ enable
+         * 10  rx data  IRQ enable
+         * 09  rx break off IRQ enable
+         * 08  overrun  IRQ enable
+         * 07  DSR      IRQ enable
+         * 06  CTS      IRQ enable
+         * 05  DCD      IRQ enable
+         * 04  RI       IRQ enable
+         * 03  reserved, must be zero
+         * 02  1=txd->rxd internal loopback enable
+         * 01  reserved, must be zero
+         * 00  1=master IRQ enable
+         */
+        val = BIT15 + BIT14 + BIT0;
+        wr_reg16(info, SCR, val);
+
+        slgt_irq_on(info, IRQ_RXBREAK | IRQ_RXOVER);
+
+        set_rate(info, info->params.data_rate * 16);
+
+        if (info->params.loopback)
+                enable_loopback(info);
+}
+
+static void hdlc_mode(struct slgt_info *info)
+{
+        unsigned short val;
+
+        slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
+        tx_stop(info);
+        rx_stop(info);
+
+        /* TCR (tx control)
+         *
+         * 15..13  mode, 000=HDLC 001=raw sync
+         * 12..10  encoding
+         * 09      CRC enable
+         * 08      CRC32
+         * 07      1=RTS driver control
+         * 06      preamble enable
+         * 05..04  preamble length
+         * 03      share open/close flag
+         * 02      reset
+         * 01      enable
+         * 00      auto-CTS enable
+         */
+        val = 0;
+
+        if (info->params.mode == MGSL_MODE_RAW)
+                val |= BIT13;
+        if (info->if_mode & MGSL_INTERFACE_RTS_EN)
+                val |= BIT7;
+
+        switch(info->params.encoding)
+        {
+        case HDLC_ENCODING_NRZB:          val |= BIT10; break;
+        case HDLC_ENCODING_NRZI_MARK:     val |= BIT11; break;
+        case HDLC_ENCODING_NRZI:          val |= BIT11 + BIT10; break;
+        case HDLC_ENCODING_BIPHASE_MARK:  val |= BIT12; break;
+        case HDLC_ENCODING_BIPHASE_SPACE: val |= BIT12 + BIT10; break;
+        case HDLC_ENCODING_BIPHASE_LEVEL: val |= BIT12 + BIT11; break;
+        case HDLC_ENCODING_DIFF_BIPHASE_LEVEL: val |= BIT12 + BIT11 + BIT10; break;
+        }
+
+        switch (info->params.crc_type)
+        {
+        case HDLC_CRC_16_CCITT: val |= BIT9; break;
+        case HDLC_CRC_32_CCITT: val |= BIT9 + BIT8; break;
+        }
+
+        if (info->params.preamble != HDLC_PREAMBLE_PATTERN_NONE)
+                val |= BIT6;
+
+        switch (info->params.preamble_length)
+        {
+        case HDLC_PREAMBLE_LENGTH_16BITS: val |= BIT5; break;
+        case HDLC_PREAMBLE_LENGTH_32BITS: val |= BIT4; break;
+        case HDLC_PREAMBLE_LENGTH_64BITS: val |= BIT5 + BIT4; break;
+        }
+
+        if (info->params.flags & HDLC_FLAG_AUTO_CTS)
+                val |= BIT0;
+
+        wr_reg16(info, TCR, val);
+
+        /* TPR (transmit preamble) */
+
+        switch (info->params.preamble)
+        {
+        case HDLC_PREAMBLE_PATTERN_FLAGS: val = 0x7e; break;
+        case HDLC_PREAMBLE_PATTERN_ONES:  val = 0xff; break;
+        case HDLC_PREAMBLE_PATTERN_ZEROS: val = 0x00; break;
+        case HDLC_PREAMBLE_PATTERN_10:    val = 0x55; break;
+        case HDLC_PREAMBLE_PATTERN_01:    val = 0xaa; break;
+        default:                          val = 0x7e; break;
+        }
+        wr_reg8(info, TPR, (unsigned char)val);
+
+        /* RCR (rx control)
+         *
+         * 15..13  mode, 000=HDLC 001=raw sync
+         * 12..10  encoding
+         * 09      CRC enable
+         * 08      CRC32
+         * 07..03  reserved, must be 0
+         * 02      reset
+         * 01      enable
+         * 00      auto-DCD enable
+         */
+        val = 0;
+
+        if (info->params.mode == MGSL_MODE_RAW)
+                val |= BIT13;
+
+        switch(info->params.encoding)
+        {
+        case HDLC_ENCODING_NRZB:          val |= BIT10; break;
+        case HDLC_ENCODING_NRZI_MARK:     val |= BIT11; break;
+        case HDLC_ENCODING_NRZI:          val |= BIT11 + BIT10; break;
+        case HDLC_ENCODING_BIPHASE_MARK:  val |= BIT12; break;
+        case HDLC_ENCODING_BIPHASE_SPACE: val |= BIT12 + BIT10; break;
+        case HDLC_ENCODING_BIPHASE_LEVEL: val |= BIT12 + BIT11; break;
+        case HDLC_ENCODING_DIFF_BIPHASE_LEVEL: val |= BIT12 + BIT11 + BIT10; break;
+        }
+
+        switch (info->params.crc_type)
+        {
+        case HDLC_CRC_16_CCITT: val |= BIT9; break;
+        case HDLC_CRC_32_CCITT: val |= BIT9 + BIT8; break;
+        }
+
+        if (info->params.flags & HDLC_FLAG_AUTO_DCD)
+                val |= BIT0;
+
+        wr_reg16(info, RCR, val);
+
+        /* CCR (clock control)
+         *
+         * 07..05  tx clock source
+         * 04..02  rx clock source
+         * 01      auxclk enable
+         * 00      BRG enable
+         */
+        val = 0;
+
+        if (info->params.flags & HDLC_FLAG_TXC_BRG)
+        {
+                // when RxC source is DPLL, BRG generates 16X DPLL
+                // reference clock, so take TxC from BRG/16 to get
+                // transmit clock at actual data rate
+                if (info->params.flags & HDLC_FLAG_RXC_DPLL)
+                        val |= BIT6 + BIT5;     /* 011, txclk = BRG/16 */
+                else
+                        val |= BIT6;    /* 010, txclk = BRG */
+        }
+        else if (info->params.flags & HDLC_FLAG_TXC_DPLL)
+                val |= BIT7;    /* 100, txclk = DPLL Input */
+        else if (info->params.flags & HDLC_FLAG_TXC_RXCPIN)
+                val |= BIT5;    /* 001, txclk = RXC Input */
+
+        if (info->params.flags & HDLC_FLAG_RXC_BRG)
+                val |= BIT3;    /* 010, rxclk = BRG */
+        else if (info->params.flags & HDLC_FLAG_RXC_DPLL)
+                val |= BIT4;    /* 100, rxclk = DPLL */
+        else if (info->params.flags & HDLC_FLAG_RXC_TXCPIN)
+                val |= BIT2;    /* 001, rxclk = TXC Input */
+
+        if (info->params.clock_speed)
+                val |= BIT1 + BIT0;
+
+        wr_reg8(info, CCR, (unsigned char)val);
+
+        if (info->params.flags & (HDLC_FLAG_TXC_DPLL + HDLC_FLAG_RXC_DPLL))
+        {
+                // program DPLL mode
+                switch(info->params.encoding)
+                {
+                case HDLC_ENCODING_BIPHASE_MARK:
+                case HDLC_ENCODING_BIPHASE_SPACE:
+                        val = BIT7; break;
+                case HDLC_ENCODING_BIPHASE_LEVEL:
+                case HDLC_ENCODING_DIFF_BIPHASE_LEVEL:
+                        val = BIT7 + BIT6; break;
+                default: val = BIT6;    // NRZ encodings
+                }
+                wr_reg16(info, RCR, (unsigned short)(rd_reg16(info, RCR) | val));
+
+                // DPLL requires a 16X reference clock from BRG
+                set_rate(info, info->params.clock_speed * 16);
+        }
+        else
+                set_rate(info, info->params.clock_speed);
+
+        tx_set_idle(info);
+
+        msc_set_vcr(info);
+
+        /* SCR (serial control)
+         *
+         * 15  1=tx req on FIFO half empty
+         * 14  1=rx req on FIFO half full
+         * 13  tx data  IRQ enable
+         * 12  tx idle  IRQ enable
+         * 11  underrun IRQ enable
+         * 10  rx data  IRQ enable
+         * 09  rx idle  IRQ enable
+         * 08  overrun  IRQ enable
+         * 07  DSR      IRQ enable
+         * 06  CTS      IRQ enable
+         * 05  DCD      IRQ enable
+         * 04  RI       IRQ enable
+         * 03  reserved, must be zero
+         * 02  1=txd->rxd internal loopback enable
+         * 01  reserved, must be zero
+         * 00  1=master IRQ enable
+         */
+        wr_reg16(info, SCR, BIT15 + BIT14 + BIT0);
+
+        if (info->params.loopback)
+                enable_loopback(info);
+}
+
+/*
+ *  set transmit idle mode
+ */
+static void tx_set_idle(struct slgt_info *info)
+{
+        unsigned char val = 0xff;
+
+        switch(info->idle_mode)
+        {
+        case HDLC_TXIDLE_FLAGS:          val = 0x7e; break;
+        case HDLC_TXIDLE_ALT_ZEROS_ONES: val = 0xaa; break;
+        case HDLC_TXIDLE_ZEROS:          val = 0x00; break;
+        case HDLC_TXIDLE_ONES:           val = 0xff; break;
+        case HDLC_TXIDLE_ALT_MARK_SPACE: val = 0xaa; break;
+        case HDLC_TXIDLE_SPACE:          val = 0x00; break;
+        case HDLC_TXIDLE_MARK:           val = 0xff; break;
+        }
+
+        wr_reg8(info, TIR, val);
+}
+
+/*
+ * get state of V24 status (input) signals
+ */
+static void get_signals(struct slgt_info *info)
+{
+        unsigned short status = rd_reg16(info, SSR);
+
+        /* clear all serial signals except DTR and RTS */
+        info->signals &= SerialSignal_DTR + SerialSignal_RTS;
+
+        if (status & BIT3)
+                info->signals |= SerialSignal_DSR;
+        if (status & BIT2)
+                info->signals |= SerialSignal_CTS;
+        if (status & BIT1)
+                info->signals |= SerialSignal_DCD;
+        if (status & BIT0)
+                info->signals |= SerialSignal_RI;
+}
+
+/*
+ * set V.24 Control Register based on current configuration
+ */
+static void msc_set_vcr(struct slgt_info *info)
+{
+        unsigned char val = 0;
+
+        /* VCR (V.24 control)
+         *
+         * 07..04  serial IF select
+         * 03      DTR
+         * 02      RTS
+         * 01      LL
+         * 00      RL
+         */
+
+        switch(info->if_mode & MGSL_INTERFACE_MASK)
+        {
+        case MGSL_INTERFACE_RS232:
+                val |= BIT5; /* 0010 */
+                break;
+        case MGSL_INTERFACE_V35:
+                val |= BIT7 + BIT6 + BIT5; /* 1110 */
+                break;
+        case MGSL_INTERFACE_RS422:
+                val |= BIT6; /* 0100 */
+                break;
+        }
+
+        if (info->signals & SerialSignal_DTR)
+                val |= BIT3;
+        if (info->signals & SerialSignal_RTS)
+                val |= BIT2;
+        if (info->if_mode & MGSL_INTERFACE_LL)
+                val |= BIT1;
+        if (info->if_mode & MGSL_INTERFACE_RL)
+                val |= BIT0;
+        wr_reg8(info, VCR, val);
+}
+
+/*
+ * set state of V24 control (output) signals
+ */
+static void set_signals(struct slgt_info *info)
+{
+        unsigned char val = rd_reg8(info, VCR);
+        if (info->signals & SerialSignal_DTR)
+                val |= BIT3;
+        else
+                val &= ~BIT3;
+        if (info->signals & SerialSignal_RTS)
+                val |= BIT2;
+        else
+                val &= ~BIT2;
+        wr_reg8(info, VCR, val);
+}
+
+/*
+ * free range of receive DMA buffers (i to last)
+ */
+static void free_rbufs(struct slgt_info *info, unsigned int i, unsigned int last)
+{
+        int done = 0;
+
+        while(!done) {
+                /* reset current buffer for reuse */
+                info->rbufs[i].status = 0;
+                if (info->params.mode == MGSL_MODE_RAW)
+                        set_desc_count(info->rbufs[i], info->raw_rx_size);
+                else
+                        set_desc_count(info->rbufs[i], DMABUFSIZE);
+
+                if (i == last)
+                        done = 1;
+                if (++i == info->rbuf_count)
+                        i = 0;
+        }
+        info->rbuf_current = i;
+}
+
+/*
+ * mark all receive DMA buffers as free
+ */
+static void reset_rbufs(struct slgt_info *info)
+{
+        free_rbufs(info, 0, info->rbuf_count - 1);
+}
+
+/*
+ * pass receive HDLC frame to upper layer
+ *
+ * return 1 if frame available, otherwise 0
+ */
+static int rx_get_frame(struct slgt_info *info)
+{
+        unsigned int start, end;
+        unsigned short status;
+        unsigned int framesize = 0;
+        int rc = 0;
+        unsigned long flags;
+        struct tty_struct *tty = info->tty;
+        unsigned char addr_field = 0xff;
+
+check_again:
+
+        framesize = 0;
+        addr_field = 0xff;
+        start = end = info->rbuf_current;
+
+        for (;;) {
+                if (!desc_complete(info->rbufs[end]))
+                        goto cleanup;
+
+                if (framesize == 0 && info->params.addr_filter != 0xff)
+                        addr_field = info->rbufs[end].buf[0];
+
+                framesize += desc_count(info->rbufs[end]);
+
+                if (desc_eof(info->rbufs[end]))
+                        break;
+
+                if (++end == info->rbuf_count)
+                        end = 0;
+
+                if (end == info->rbuf_current) {
+                        if (info->rx_enabled){
+                                spin_lock_irqsave(&info->lock,flags);
+                                rx_start(info);
+                                spin_unlock_irqrestore(&info->lock,flags);
+                        }
+                        goto cleanup;
+                }
+        }
+
+        /* status
+         *
+         * 15      buffer complete
+         * 14..06  reserved
+         * 05..04  residue
+         * 02      eof (end of frame)
+         * 01      CRC error
+         * 00      abort
+         */
+        status = desc_status(info->rbufs[end]);
+
+        /* ignore CRC bit if not using CRC (bit is undefined) */
+        if (info->params.crc_type == HDLC_CRC_NONE)
+                status &= ~BIT1;
+
+        if (framesize == 0 ||
+                 (addr_field != 0xff && addr_field != info->params.addr_filter)) {
+                free_rbufs(info, start, end);
+                goto check_again;
+        }
+
+        if (framesize < 2 || status & (BIT1+BIT0)) {
+                if (framesize < 2 || (status & BIT0))
+                        info->icount.rxshort++;
+                else
+                        info->icount.rxcrc++;
+                framesize = 0;
+
+#ifdef CONFIG_HDLC
+                {
+                        struct net_device_stats *stats = hdlc_stats(info->netdev);
+                        stats->rx_errors++;
+                        stats->rx_frame_errors++;
+                }
+#endif
+        } else {
+                /* adjust frame size for CRC, if any */
+                if (info->params.crc_type == HDLC_CRC_16_CCITT)
+                        framesize -= 2;
+                else if (info->params.crc_type == HDLC_CRC_32_CCITT)
+                        framesize -= 4;
+        }
+
+        DBGBH(("%s rx frame status=%04X size=%d\n",
+                info->device_name, status, framesize));
+        DBGDATA(info, info->rbufs[start].buf, min_t(int, framesize, DMABUFSIZE), "rx");
+
+        if (framesize) {
+                if (framesize > info->max_frame_size)
+                        info->icount.rxlong++;
+                else {
+                        /* copy dma buffer(s) to contiguous temp buffer */
+                        int copy_count = framesize;
+                        int i = start;
+                        unsigned char *p = info->tmp_rbuf;
+                        info->tmp_rbuf_count = framesize;
+
+                        info->icount.rxok++;
+
+                        while(copy_count) {
+                                int partial_count = min(copy_count, DMABUFSIZE);
+                                memcpy(p, info->rbufs[i].buf, partial_count);
+                                p += partial_count;
+                                copy_count -= partial_count;
+                                if (++i == info->rbuf_count)
+                                        i = 0;
+                        }
+
+#ifdef CONFIG_HDLC
+                        if (info->netcount)
+                                hdlcdev_rx(info,info->tmp_rbuf, framesize);
+                        else
+#endif
+                                ldisc_receive_buf(tty, info->tmp_rbuf, info->flag_buf, framesize);
+                }
+        }
+        free_rbufs(info, start, end);
+        rc = 1;
+
+cleanup:
+        return rc;
+}
+
+/*
+ * pass receive buffer (RAW synchronous mode) to tty layer
+ * return 1 if buffer available, otherwise 0
+ */
+static int rx_get_buf(struct slgt_info *info)
+{
+        unsigned int i = info->rbuf_current;
+
+        if (!desc_complete(info->rbufs[i]))
+                return 0;
+        DBGDATA(info, info->rbufs[i].buf, desc_count(info->rbufs[i]), "rx");
+        DBGINFO(("rx_get_buf size=%d\n", desc_count(info->rbufs[i])));
+        ldisc_receive_buf(info->tty, info->rbufs[i].buf,
+                          info->flag_buf, desc_count(info->rbufs[i]));
+        free_rbufs(info, i, i);
+        return 1;
+}
+
+static void reset_tbufs(struct slgt_info *info)
+{
+        unsigned int i;
+        info->tbuf_current = 0;
+        for (i=0 ; i < info->tbuf_count ; i++) {
+                info->tbufs[i].status = 0;
+                info->tbufs[i].count  = 0;
+        }
+}
+
+/*
+ * return number of free transmit DMA buffers
+ */
+static unsigned int free_tbuf_count(struct slgt_info *info)
+{
+        unsigned int count = 0;
+        unsigned int i = info->tbuf_current;
+
+        do
+        {
+                if (desc_count(info->tbufs[i]))
+                        break; /* buffer in use */
+                ++count;
+                if (++i == info->tbuf_count)
+                        i=0;
+        } while (i != info->tbuf_current);
+
+        /* last buffer with zero count may be in use, assume it is */
+        if (count)
+                --count;
+
+        return count;
+}
+
+/*
+ * load transmit DMA buffer(s) with data
+ */
+static void tx_load(struct slgt_info *info, const char *buf, unsigned int size)
+{
+        unsigned short count;
+        unsigned int i;
+        struct slgt_desc *d;
+
+        if (size == 0)
+                return;
+
+        DBGDATA(info, buf, size, "tx");
+
+        info->tbuf_start = i = info->tbuf_current;
+
+        while (size) {
+                d = &info->tbufs[i];
+                if (++i == info->tbuf_count)
+                        i = 0;
+
+                count = (unsigned short)((size > DMABUFSIZE) ? DMABUFSIZE : size);
+                memcpy(d->buf, buf, count);
+
+                size -= count;
+                buf  += count;
+
+                if (!size && info->params.mode != MGSL_MODE_RAW)
+                        set_desc_eof(*d, 1); /* HDLC: set EOF of last desc */
+                else
+                        set_desc_eof(*d, 0);
+
+                set_desc_count(*d, count);
+        }
+
+        info->tbuf_current = i;
+}
+
+static int register_test(struct slgt_info *info)
+{
+        static unsigned short patterns[] =
+                {0x0000, 0xffff, 0xaaaa, 0x5555, 0x6969, 0x9696};
+        static unsigned int count = sizeof(patterns)/sizeof(patterns[0]);
+        unsigned int i;
+        int rc = 0;
+
+        for (i=0 ; i < count ; i++) {
+                wr_reg16(info, TIR, patterns[i]);
+                wr_reg16(info, BDR, patterns[(i+1)%count]);
+                if ((rd_reg16(info, TIR) != patterns[i]) ||
+                    (rd_reg16(info, BDR) != patterns[(i+1)%count])) {
+                        rc = -ENODEV;
+                        break;
+                }
+        }
+
+        info->init_error = rc ? 0 : DiagStatus_AddressFailure;
+        return rc;
+}
+
+static int irq_test(struct slgt_info *info)
+{
+        unsigned long timeout;
+        unsigned long flags;
+        struct tty_struct *oldtty = info->tty;
+        u32 speed = info->params.data_rate;
+
+        info->params.data_rate = 921600;
+        info->tty = NULL;
+
+        spin_lock_irqsave(&info->lock, flags);
+        async_mode(info);
+        slgt_irq_on(info, IRQ_TXIDLE);
+
+        /* enable transmitter */
+        wr_reg16(info, TCR,
+                (unsigned short)(rd_reg16(info, TCR) | BIT1));
+
+        /* write one byte and wait for tx idle */
+        wr_reg16(info, TDR, 0);
+
+        /* assume failure */
+        info->init_error = DiagStatus_IrqFailure;
+        info->irq_occurred = FALSE;
+
+        spin_unlock_irqrestore(&info->lock, flags);
+
+        timeout=100;
+        while(timeout-- && !info->irq_occurred)
+                msleep_interruptible(10);
+
+        spin_lock_irqsave(&info->lock,flags);
+        reset_port(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        info->params.data_rate = speed;
+        info->tty = oldtty;
+
+        info->init_error = info->irq_occurred ? 0 : DiagStatus_IrqFailure;
+        return info->irq_occurred ? 0 : -ENODEV;
+}
+
+static int loopback_test_rx(struct slgt_info *info)
+{
+        unsigned char *src, *dest;
+        int count;
+
+        if (desc_complete(info->rbufs[0])) {
+                count = desc_count(info->rbufs[0]);
+                src   = info->rbufs[0].buf;
+                dest  = info->tmp_rbuf;
+
+                for( ; count ; count-=2, src+=2) {
+                        /* src=data byte (src+1)=status byte */
+                        if (!(*(src+1) & (BIT9 + BIT8))) {
+                                *dest = *src;
+                                dest++;
+                                info->tmp_rbuf_count++;
+                        }
+                }
+                DBGDATA(info, info->tmp_rbuf, info->tmp_rbuf_count, "rx");
+                return 1;
+        }
+        return 0;
+}
+
+static int loopback_test(struct slgt_info *info)
+{
+#define TESTFRAMESIZE 20
+
+        unsigned long timeout;
+        u16 count = TESTFRAMESIZE;
+        unsigned char buf[TESTFRAMESIZE];
+        int rc = -ENODEV;
+        unsigned long flags;
+
+        struct tty_struct *oldtty = info->tty;
+        MGSL_PARAMS params;
+
+        memcpy(&params, &info->params, sizeof(params));
+
+        info->params.mode = MGSL_MODE_ASYNC;
+        info->params.data_rate = 921600;
+        info->params.loopback = 1;
+        info->tty = NULL;
+
+        /* build and send transmit frame */
+        for (count = 0; count < TESTFRAMESIZE; ++count)
+                buf[count] = (unsigned char)count;
+
+        info->tmp_rbuf_count = 0;
+        memset(info->tmp_rbuf, 0, TESTFRAMESIZE);
+
+        /* program hardware for HDLC and enabled receiver */
+        spin_lock_irqsave(&info->lock,flags);
+        async_mode(info);
+        rx_start(info);
+        info->tx_count = count;
+        tx_load(info, buf, count);
+        tx_start(info);
+        spin_unlock_irqrestore(&info->lock, flags);
+
+        /* wait for receive complete */
+        for (timeout = 100; timeout; --timeout) {
+                msleep_interruptible(10);
+                if (loopback_test_rx(info)) {
+                        rc = 0;
+                        break;
+                }
+        }
+
+        /* verify received frame length and contents */
+        if (!rc && (info->tmp_rbuf_count != count ||
+                  memcmp(buf, info->tmp_rbuf, count))) {
+                rc = -ENODEV;
+        }
+
+        spin_lock_irqsave(&info->lock,flags);
+        reset_adapter(info);
+        spin_unlock_irqrestore(&info->lock,flags);
+
+        memcpy(&info->params, &params, sizeof(info->params));
+        info->tty = oldtty;
+
+        info->init_error = rc ? DiagStatus_DmaFailure : 0;
+        return rc;
+}
+
+static int adapter_test(struct slgt_info *info)
+{
+        DBGINFO(("testing %s\n", info->device_name));
+        if ((info->init_error = register_test(info)) < 0) {
+                printk("register test failure %s addr=%08X\n",
+                        info->device_name, info->phys_reg_addr);
+        } else if ((info->init_error = irq_test(info)) < 0) {
+                printk("IRQ test failure %s IRQ=%d\n",
+                        info->device_name, info->irq_level);
+        } else if ((info->init_error = loopback_test(info)) < 0) {
+                printk("loopback test failure %s\n", info->device_name);
+        }
+        return info->init_error;
+}
+
+/*
+ * transmit timeout handler
+ */
+static void tx_timeout(unsigned long context)
+{
+        struct slgt_info *info = (struct slgt_info*)context;
+        unsigned long flags;
+
+        DBGINFO(("%s tx_timeout\n", info->device_name));
+        if(info->tx_active && info->params.mode == MGSL_MODE_HDLC) {
+                info->icount.txtimeout++;
+        }
+        spin_lock_irqsave(&info->lock,flags);
+        info->tx_active = 0;
+        info->tx_count = 0;
+        spin_unlock_irqrestore(&info->lock,flags);
+
+#ifdef CONFIG_HDLC
+        if (info->netcount)
+                hdlcdev_tx_done(info);
+        else
+#endif
+                bh_transmit(info);
+}
+
+/*
+ * receive buffer polling timer
+ */
+static void rx_timeout(unsigned long context)
+{
+        struct slgt_info *info = (struct slgt_info*)context;
+        unsigned long flags;
+
+        DBGINFO(("%s rx_timeout\n", info->device_name));
+        spin_lock_irqsave(&info->lock, flags);
+        info->pending_bh |= BH_RECEIVE;
+        spin_unlock_irqrestore(&info->lock, flags);
+        bh_handler(info);
+}
+
diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
index 2392e404e8d1..ba4582d160fd 100644
--- a/drivers/char/tpm/Makefile
+++ b/drivers/char/tpm/Makefile
@@ -2,6 +2,9 @@
 # Makefile for the kernel tpm device drivers.
 #
 obj-$(CONFIG_TCG_TPM) += tpm.o
+ifdef CONFIG_ACPI
+        obj-$(CONFIG_TCG_TPM) += tpm_bios.o
+endif
 obj-$(CONFIG_TCG_NSC) += tpm_nsc.o
 obj-$(CONFIG_TCG_ATMEL) += tpm_atmel.o
 obj-$(CONFIG_TCG_INFINEON) += tpm_infineon.o
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index a9be0e8eaea5..5a3870477ef1 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -466,6 +466,7 @@ void tpm_remove_hardware(struct device *dev)
         kfree(chip->vendor->miscdev.name);
 
         sysfs_remove_group(&dev->kobj, chip->vendor->attr_group);
+        tpm_bios_log_teardown(chip->bios_dir);
 
         dev_mask[chip->dev_num / TPM_NUM_MASK_ENTRIES ] &=
                 ~(1 << (chip->dev_num % TPM_NUM_MASK_ENTRIES));
@@ -593,6 +594,8 @@ dev_num_search_complete:
 
         sysfs_create_group(&dev->kobj, chip->vendor->attr_group);
 
+        chip->bios_dir = tpm_bios_log_setup(devname);
+
         return 0;
 }
 EXPORT_SYMBOL_GPL(tpm_register_hardware);
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 159882ca69dd..fd3a4beaa53d 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -82,6 +82,8 @@ struct tpm_chip {
 
         struct tpm_vendor_specific *vendor;
 
+        struct dentry **bios_dir;
+
         struct list_head list;
 };
 
@@ -107,3 +109,16 @@ extern ssize_t tpm_read(struct file *, char __user *, size_t, loff_t *);
 extern void tpm_remove_hardware(struct device *);
 extern int tpm_pm_suspend(struct device *, pm_message_t);
 extern int tpm_pm_resume(struct device *);
+
+#ifdef CONFIG_ACPI
+extern struct dentry ** tpm_bios_log_setup(char *);
+extern void tpm_bios_log_teardown(struct dentry **);
+#else
+static inline struct dentry* tpm_bios_log_setup(char *name)
+{
+        return NULL;
+}
+static inline void tpm_bios_log_teardown(struct dentry **dir)
+{
+}
+#endif
diff --git a/drivers/char/tpm/tpm_bios.c b/drivers/char/tpm/tpm_bios.c
new file mode 100644
index 000000000000..aedf7a8e6da7
--- /dev/null
+++ b/drivers/char/tpm/tpm_bios.c
@@ -0,0 +1,540 @@
+/*
+ * Copyright (C) 2005 IBM Corporation
+ *
+ * Authors:
+ *      Seiji Munetoh <munetoh@jp.ibm.com>
+ *      Stefan Berger <stefanb@us.ibm.com>
+ *      Reiner Sailer <sailer@watson.ibm.com>
+ *      Kylene Hall <kjhall@us.ibm.com>
+ *
+ * Access to the eventlog extended by the TCG BIOS of PC platform
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ *
+ */
+
+#include <linux/seq_file.h>
+#include <linux/fs.h>
+#include <linux/security.h>
+#include <linux/module.h>
+#include <acpi/acpi.h>
+#include <acpi/actypes.h>
+#include <acpi/actbl.h>
+#include "tpm.h"
+
+#define TCG_EVENT_NAME_LEN_MAX  255
+#define MAX_TEXT_EVENT          1000    /* Max event string length */
+#define ACPI_TCPA_SIG           "TCPA"  /* 0x41504354 /'TCPA' */
+
+struct tpm_bios_log {
+        void *bios_event_log;
+        void *bios_event_log_end;
+};
+
+struct acpi_tcpa {
+        struct acpi_table_header hdr;
+        u16 reserved;
+        u32 log_max_len __attribute__ ((packed));
+        u32 log_start_addr __attribute__ ((packed));
+};
+
+struct tcpa_event {
+        u32 pcr_index;
+        u32 event_type;
+        u8 pcr_value[20];       /* SHA1 */
+        u32 event_size;
+        u8 event_data[0];
+};
+
+enum tcpa_event_types {
+        PREBOOT = 0,
+        POST_CODE,
+        UNUSED,
+        NO_ACTION,
+        SEPARATOR,
+        ACTION,
+        EVENT_TAG,
+        SCRTM_CONTENTS,
+        SCRTM_VERSION,
+        CPU_MICROCODE,
+        PLATFORM_CONFIG_FLAGS,
+        TABLE_OF_DEVICES,
+        COMPACT_HASH,
+        IPL,
+        IPL_PARTITION_DATA,
+        NONHOST_CODE,
+        NONHOST_CONFIG,
+        NONHOST_INFO,
+};
+
+static const char* tcpa_event_type_strings[] = {
+        "PREBOOT",
+        "POST CODE",
+        "",
+        "NO ACTION",
+        "SEPARATOR",
+        "ACTION",
+        "EVENT TAG",
+        "S-CRTM Contents",
+        "S-CRTM Version",
+        "CPU Microcode",
+        "Platform Config Flags",
+        "Table of Devices",
+        "Compact Hash",
+        "IPL",
+        "IPL Partition Data",
+        "Non-Host Code",
+        "Non-Host Config",
+        "Non-Host Info"
+};
+
+enum tcpa_pc_event_ids {
+        SMBIOS = 1,
+        BIS_CERT,
+        POST_BIOS_ROM,
+        ESCD,
+        CMOS,
+        NVRAM,
+        OPTION_ROM_EXEC,
+        OPTION_ROM_CONFIG,
+        OPTION_ROM_MICROCODE,
+        S_CRTM_VERSION,
+        S_CRTM_CONTENTS,
+        POST_CONTENTS,
+};
+
+static const char* tcpa_pc_event_id_strings[] = {
+        ""
+        "SMBIOS",
+        "BIS Certificate",
+        "POST BIOS ",
+        "ESCD ",
+        "CMOS",
+        "NVRAM",
+        "Option ROM",
+        "Option ROM config",
+        "Option ROM microcode",
+        "S-CRTM Version",
+        "S-CRTM Contents",
+        "S-CRTM POST Contents",
+};
+
+/* returns pointer to start of pos. entry of tcg log */
+static void *tpm_bios_measurements_start(struct seq_file *m, loff_t *pos)
+{
+        loff_t i;
+        struct tpm_bios_log *log = m->private;
+        void *addr = log->bios_event_log;
+        void *limit = log->bios_event_log_end;
+        struct tcpa_event *event;
+
+        /* read over *pos measurements */
+        for (i = 0; i < *pos; i++) {
+                event = addr;
+
+                if ((addr + sizeof(struct tcpa_event)) < limit) {
+                        if (event->event_type == 0 && event->event_size == 0)
+                                return NULL;
+                        addr += sizeof(struct tcpa_event) + event->event_size;
+                }
+        }
+
+        /* now check if current entry is valid */
+        if ((addr + sizeof(struct tcpa_event)) >= limit)
+                return NULL;
+
+        event = addr;
+
+        if ((event->event_type == 0 && event->event_size == 0) ||
+            ((addr + sizeof(struct tcpa_event) + event->event_size) >= limit))
+                return NULL;
+
+        return addr;
+}
+
+static void *tpm_bios_measurements_next(struct seq_file *m, void *v,
+                                        loff_t *pos)
+{
+        struct tcpa_event *event = v;
+        struct tpm_bios_log *log = m->private;
+        void *limit = log->bios_event_log_end;
+
+        v += sizeof(struct tcpa_event) + event->event_size;
+
+        /* now check if current entry is valid */
+        if ((v + sizeof(struct tcpa_event)) >= limit)
+                return NULL;
+
+        event = v;
+
+        if (event->event_type == 0 && event->event_size == 0)
+                return NULL;
+
+        if ((event->event_type == 0 && event->event_size == 0) ||
+            ((v + sizeof(struct tcpa_event) + event->event_size) >= limit))
+                return NULL;
+
+        (*pos)++;
+        return v;
+}
+
+static void tpm_bios_measurements_stop(struct seq_file *m, void *v)
+{
+}
+
+static int get_event_name(char *dest, struct tcpa_event *event,
+                        unsigned char * event_entry)
+{
+        const char *name = "";
+        char data[40] = "";
+        int i, n_len = 0, d_len = 0;
+        u32 event_id, event_data_size;
+
+        switch(event->event_type) {
+        case PREBOOT:
+        case POST_CODE:
+        case UNUSED:
+        case NO_ACTION:
+        case SCRTM_CONTENTS:
+        case SCRTM_VERSION:
+        case CPU_MICROCODE:
+        case PLATFORM_CONFIG_FLAGS:
+        case TABLE_OF_DEVICES:
+        case COMPACT_HASH:
+        case IPL:
+        case IPL_PARTITION_DATA:
+        case NONHOST_CODE:
+        case NONHOST_CONFIG:
+        case NONHOST_INFO:
+                name = tcpa_event_type_strings[event->event_type];
+                n_len = strlen(name);
+                break;
+        case SEPARATOR:
+        case ACTION:
+                if (MAX_TEXT_EVENT > event->event_size) {
+                        name = event_entry;
+                        n_len = event->event_size;
+                }
+                break;
+        case EVENT_TAG:
+                event_id = be32_to_cpu(event_entry);
+                event_data_size = be32_to_cpu(&event_entry[4]);
+
+                /* ToDo Row data -> Base64 */
+
+                switch (event_id) {
+                case SMBIOS:
+                case BIS_CERT:
+                case CMOS:
+                case NVRAM:
+                case OPTION_ROM_EXEC:
+                case OPTION_ROM_CONFIG:
+                case OPTION_ROM_MICROCODE:
+                case S_CRTM_VERSION:
+                case S_CRTM_CONTENTS:
+                case POST_CONTENTS:
+                        name = tcpa_pc_event_id_strings[event_id];
+                        n_len = strlen(name);
+                        break;
+                case POST_BIOS_ROM:
+                case ESCD:
+                        name = tcpa_pc_event_id_strings[event_id];
+                        n_len = strlen(name);
+                        for (i = 0; i < 20; i++)
+                                d_len += sprintf(data, "%02x",
+                                                event_entry[8 + i]);
+                        break;
+                default:
+                        break;
+                }
+        default:
+                break;
+        }
+
+        return snprintf(dest, MAX_TEXT_EVENT, "[%.*s%.*s]",
+                        n_len, name, d_len, data);
+
+}
+
+static int tpm_binary_bios_measurements_show(struct seq_file *m, void *v)
+{
+
+        char *eventname;
+        char data[4];
+        u32 help;
+        int i, len;
+        struct tcpa_event *event = (struct tcpa_event *) v;
+        unsigned char *event_entry =
+            (unsigned char *) (v + sizeof(struct tcpa_event));
+
+        eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
+        if (!eventname) {
+                printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
+                       __func__);
+                return -ENOMEM;
+        }
+
+        /* 1st: PCR used is in little-endian format (4 bytes) */
+        help = le32_to_cpu(event->pcr_index);
+        memcpy(data, &help, 4);
+        for (i = 0; i < 4; i++)
+                seq_putc(m, data[i]);
+
+        /* 2nd: SHA1 (20 bytes) */
+        for (i = 0; i < 20; i++)
+                seq_putc(m, event->pcr_value[i]);
+
+        /* 3rd: event type identifier (4 bytes) */
+        help = le32_to_cpu(event->event_type);
+        memcpy(data, &help, 4);
+        for (i = 0; i < 4; i++)
+                seq_putc(m, data[i]);
+
+        len = 0;
+
+        len += get_event_name(eventname, event, event_entry);
+
+        /* 4th:  filename <= 255 + \'0' delimiter */
+        if (len > TCG_EVENT_NAME_LEN_MAX)
+                len = TCG_EVENT_NAME_LEN_MAX;
+
+        for (i = 0; i < len; i++)
+                seq_putc(m, eventname[i]);
+
+        /* 5th: delimiter */
+        seq_putc(m, '\0');
+
+        return 0;
+}
+
+static int tpm_bios_measurements_release(struct inode *inode,
+                                         struct file *file)
+{
+        struct seq_file *seq = file->private_data;
+        struct tpm_bios_log *log = seq->private;
+
+        if (log) {
+                kfree(log->bios_event_log);
+                kfree(log);
+        }
+
+        return seq_release(inode, file);
+}
+
+static int tpm_ascii_bios_measurements_show(struct seq_file *m, void *v)
+{
+        int len = 0;
+        int i;
+        char *eventname;
+        struct tcpa_event *event = v;
+        unsigned char *event_entry =
+            (unsigned char *) (v + sizeof(struct tcpa_event));
+
+        eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
+        if (!eventname) {
+                printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
+                       __func__);
+                return -EFAULT;
+        }
+
+        seq_printf(m, "%2d ", event->pcr_index);
+
+        /* 2nd: SHA1 */
+        for (i = 0; i < 20; i++)
+                seq_printf(m, "%02x", event->pcr_value[i]);
+
+        /* 3rd: event type identifier */
+        seq_printf(m, " %02x", event->event_type);
+
+        len += get_event_name(eventname, event, event_entry);
+
+        /* 4th: eventname <= max + \'0' delimiter */
+        seq_printf(m, " %s\n", eventname);
+
+        return 0;
+}
+
+static struct seq_operations tpm_ascii_b_measurments_seqops = {
+        .start = tpm_bios_measurements_start,
+        .next = tpm_bios_measurements_next,
+        .stop = tpm_bios_measurements_stop,
+        .show = tpm_ascii_bios_measurements_show,
+};
+
+static struct seq_operations tpm_binary_b_measurments_seqops = {
+        .start = tpm_bios_measurements_start,
+        .next = tpm_bios_measurements_next,
+        .stop = tpm_bios_measurements_stop,
+        .show = tpm_binary_bios_measurements_show,
+};
+
+/* read binary bios log */
+static int read_log(struct tpm_bios_log *log)
+{
+        struct acpi_tcpa *buff;
+        acpi_status status;
+        void *virt;
+
+        if (log->bios_event_log != NULL) {
+                printk(KERN_ERR
+                       "%s: ERROR - Eventlog already initialized\n",
+                       __func__);
+                return -EFAULT;
+        }
+
+        /* Find TCPA entry in RSDT (ACPI_LOGICAL_ADDRESSING) */
+        status = acpi_get_firmware_table(ACPI_TCPA_SIG, 1,
+                                         ACPI_LOGICAL_ADDRESSING,
+                                         (struct acpi_table_header **)
+                                         &buff);
+
+        if (ACPI_FAILURE(status)) {
+                printk(KERN_ERR "%s: ERROR - Could not get TCPA table\n",
+                       __func__);
+                return -EIO;
+        }
+
+        if (buff->log_max_len == 0) {
+                printk(KERN_ERR "%s: ERROR - TCPA log area empty\n", __func__);
+                return -EIO;
+        }
+
+        /* malloc EventLog space */
+        log->bios_event_log = kmalloc(buff->log_max_len, GFP_KERNEL);
+        if (!log->bios_event_log) {
+                printk
+                    ("%s: ERROR - Not enough  Memory for BIOS measurements\n",
+                     __func__);
+                return -ENOMEM;
+        }
+
+        log->bios_event_log_end = log->bios_event_log + buff->log_max_len;
+
+        acpi_os_map_memory(buff->log_start_addr, buff->log_max_len, &virt);
+
+        memcpy(log->bios_event_log, virt, buff->log_max_len);
+
+        acpi_os_unmap_memory(virt, buff->log_max_len);
+        return 0;
+}
+
+static int tpm_ascii_bios_measurements_open(struct inode *inode,
+                                            struct file *file)
+{
+        int err;
+        struct tpm_bios_log *log;
+        struct seq_file *seq;
+
+        log = kzalloc(sizeof(struct tpm_bios_log), GFP_KERNEL);
+        if (!log)
+                return -ENOMEM;
+
+        if ((err = read_log(log)))
+                return err;
+
+        /* now register seq file */
+        err = seq_open(file, &tpm_ascii_b_measurments_seqops);
+        if (!err) {
+                seq = file->private_data;
+                seq->private = log;
+        } else {
+                kfree(log->bios_event_log);
+                kfree(log);
+        }
+        return err;
+}
+
+struct file_operations tpm_ascii_bios_measurements_ops = {
+        .open = tpm_ascii_bios_measurements_open,
+        .read = seq_read,
+        .llseek = seq_lseek,
+        .release = tpm_bios_measurements_release,
+};
+
+static int tpm_binary_bios_measurements_open(struct inode *inode,
+                                             struct file *file)
+{
+        int err;
+        struct tpm_bios_log *log;
+        struct seq_file *seq;
+
+        log = kzalloc(sizeof(struct tpm_bios_log), GFP_KERNEL);
+        if (!log)
+                return -ENOMEM;
+
+        if ((err = read_log(log)))
+                return err;
+
+        /* now register seq file */
+        err = seq_open(file, &tpm_binary_b_measurments_seqops);
+        if (!err) {
+                seq = file->private_data;
+                seq->private = log;
+        } else {
+                kfree(log->bios_event_log);
+                kfree(log);
+        }
+        return err;
+}
+
+struct file_operations tpm_binary_bios_measurements_ops = {
+        .open = tpm_binary_bios_measurements_open,
+        .read = seq_read,
+        .llseek = seq_lseek,
+        .release = tpm_bios_measurements_release,
+};
+
+struct dentry **tpm_bios_log_setup(char *name)
+{
+        struct dentry **ret = NULL, *tpm_dir, *bin_file, *ascii_file;
+
+        tpm_dir = securityfs_create_dir(name, NULL);
+        if (!tpm_dir)
+                goto out;
+
+        bin_file =
+            securityfs_create_file("binary_bios_measurements",
+                                   S_IRUSR | S_IRGRP, tpm_dir, NULL,
+                                   &tpm_binary_bios_measurements_ops);
+        if (!bin_file)
+                goto out_tpm;
+
+        ascii_file =
+            securityfs_create_file("ascii_bios_measurements",
+                                   S_IRUSR | S_IRGRP, tpm_dir, NULL,
+                                   &tpm_ascii_bios_measurements_ops);
+        if (!ascii_file)
+                goto out_bin;
+
+        ret = kmalloc(3 * sizeof(struct dentry *), GFP_KERNEL);
+        if (!ret)
+                goto out_ascii;
+
+        ret[0] = ascii_file;
+        ret[1] = bin_file;
+        ret[2] = tpm_dir;
+
+        return ret;
+
+out_ascii:
+        securityfs_remove(ascii_file);
+out_bin:
+        securityfs_remove(bin_file);
+out_tpm:
+        securityfs_remove(tpm_dir);
+out:
+        return NULL;
+}
+EXPORT_SYMBOL_GPL(tpm_bios_log_setup);
+
+void tpm_bios_log_teardown(struct dentry **lst)
+{
+        int i;
+
+        for (i = 0; i < 3; i++)
+                securityfs_remove(lst[i]);
+}
+EXPORT_SYMBOL_GPL(tpm_bios_log_teardown);
diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
index 9ac6d43437b3..a5b18e086a94 100644
--- a/drivers/char/vr41xx_giu.c
+++ b/drivers/char/vr41xx_giu.c
@@ -718,7 +718,7 @@ static struct platform_driver giu_device_driver = {
         },
 };
 
-static int __devinit vr41xx_giu_init(void)
+static int __init vr41xx_giu_init(void)
 {
         int retval;
 
@@ -733,7 +733,7 @@ static int __devinit vr41xx_giu_init(void)
         return retval;
 }
 
-static void __devexit vr41xx_giu_exit(void)
+static void __exit vr41xx_giu_exit(void)
 {
         platform_driver_unregister(&giu_device_driver);
 
diff --git a/drivers/char/watchdog/mpc8xx_wdt.c b/drivers/char/watchdog/mpc8xx_wdt.c
index 56d62ba7c6ce..b2fc71e20850 100644
--- a/drivers/char/watchdog/mpc8xx_wdt.c
+++ b/drivers/char/watchdog/mpc8xx_wdt.c
@@ -18,6 +18,7 @@
 #include <linux/watchdog.h>
 #include <asm/8xx_immap.h>
 #include <asm/uaccess.h>
+#include <asm/io.h>
 #include <syslib/m8xx_wdt.h>
 
 static unsigned long wdt_opened;
@@ -25,18 +26,26 @@ static int wdt_status;
 
 static void mpc8xx_wdt_handler_disable(void)
 {
-        volatile immap_t *imap = (volatile immap_t *)IMAP_ADDR;
+        volatile uint __iomem *piscr;
+        piscr = (uint *)&((immap_t*)IMAP_ADDR)->im_sit.sit_piscr;
 
-        imap->im_sit.sit_piscr &= ~(PISCR_PIE | PISCR_PTE);
+        if (!m8xx_has_internal_rtc)
+                m8xx_wdt_stop_timer();
+        else
+                out_be32(piscr, in_be32(piscr) & ~(PISCR_PIE | PISCR_PTE));
 
         printk(KERN_NOTICE "mpc8xx_wdt: keep-alive handler deactivated\n");
 }
 
 static void mpc8xx_wdt_handler_enable(void)
 {
-        volatile immap_t *imap = (volatile immap_t *)IMAP_ADDR;
+        volatile uint __iomem *piscr;
+        piscr = (uint *)&((immap_t*)IMAP_ADDR)->im_sit.sit_piscr;
 
-        imap->im_sit.sit_piscr |= PISCR_PIE | PISCR_PTE;
+        if (!m8xx_has_internal_rtc)
+                m8xx_wdt_install_timer();
+        else
+                out_be32(piscr, in_be32(piscr) | PISCR_PIE | PISCR_PTE);
 
         printk(KERN_NOTICE "mpc8xx_wdt: keep-alive handler activated\n");
 }
@@ -68,9 +77,6 @@ static int mpc8xx_wdt_release(struct inode *inode, struct file *file)
 static ssize_t mpc8xx_wdt_write(struct file *file, const char *data, size_t len,
                                 loff_t * ppos)
 {
-        if (ppos != &file->f_pos)
-                return -ESPIPE;
-
         if (len)
                 m8xx_wdt_reset();
 
diff --git a/drivers/char/watchdog/wdt977.c b/drivers/char/watchdog/wdt977.c
index 44d49dfacbb3..3843900e94c4 100644
--- a/drivers/char/watchdog/wdt977.c
+++ b/drivers/char/watchdog/wdt977.c
@@ -1,5 +1,5 @@
 /*
- *      Wdt977  0.03:   A Watchdog Device for Netwinder W83977AF chip
+ *      Wdt977  0.04:   A Watchdog Device for Netwinder W83977AF chip
  *
  *      (c) Copyright 1998 Rebel.com (Woody Suwalski <woody@netwinder.org>)
  *
@@ -18,6 +18,8 @@
  *                                  from minutes to seconds.
  *      07-Jul-2003 Daniele Bellucci: Audit return code of misc_register in
  *                                    nwwatchdog_init.
+ *      25-Oct-2005 Woody Suwalski: Convert addresses to #defs, add spinlocks
+ *                                  remove limitiation to be used on Netwinders only
  */
 
 #include <linux/module.h>
@@ -28,6 +30,7 @@
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <linux/init.h>
+#include <linux/ioport.h>
 #include <linux/watchdog.h>
 #include <linux/notifier.h>
 #include <linux/reboot.h>
@@ -37,8 +40,18 @@
 #include <asm/mach-types.h>
 #include <asm/uaccess.h>
 
-#define PFX "Wdt977: "
-#define WATCHDOG_MINOR  130
+#define WATCHDOG_VERSION  "0.04"
+#define WATCHDOG_NAME     "Wdt977"
+#define PFX WATCHDOG_NAME ": "
+#define DRIVER_VERSION    WATCHDOG_NAME " driver, v" WATCHDOG_VERSION "\n"
+
+#define IO_INDEX_PORT   0x370           /* on some systems it can be 0x3F0 */
+#define IO_DATA_PORT    (IO_INDEX_PORT+1)
+
+#define UNLOCK_DATA     0x87
+#define LOCK_DATA       0xAA
+#define DEVICE_REGISTER 0x07
+
 
 #define DEFAULT_TIMEOUT 60                      /* default timeout in seconds */
 
@@ -47,6 +60,7 @@ static	int timeoutM;				/* timeout in minutes */
 static  unsigned long timer_alive;
 static  int testmode;
 static  char expect_close;
+static  spinlock_t spinlock;
 
 module_param(timeout, int, 0);
 MODULE_PARM_DESC(timeout,"Watchdog timeout in seconds (60..15300), default=" __MODULE_STRING(DEFAULT_TIMEOUT) ")");
@@ -63,9 +77,13 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CON
 
 static int wdt977_start(void)
 {
+        unsigned long flags;
+
+        spin_lock_irqsave(&spinlock, flags);
+
         /* unlock the SuperIO chip */
-        outb(0x87,0x370);
-        outb(0x87,0x370);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
 
         /* select device Aux2 (device=8) and set watchdog regs F2, F3 and F4
          * F2 has the timeout in minutes
@@ -73,28 +91,29 @@ static int wdt977_start(void)
          *   at timeout, and to reset timer on kbd/mouse activity (not impl.)
          * F4 is used to just clear the TIMEOUT'ed state (bit 0)
          */
-        outb(0x07,0x370);
-        outb(0x08,0x371);
-        outb(0xF2,0x370);
-        outb(timeoutM,0x371);
-        outb(0xF3,0x370);
-        outb(0x00,0x371);       /* another setting is 0E for kbd/mouse/LED */
-        outb(0xF4,0x370);
-        outb(0x00,0x371);
+        outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+        outb_p(0x08, IO_DATA_PORT);
+        outb_p(0xF2, IO_INDEX_PORT);
+        outb_p(timeoutM, IO_DATA_PORT);
+        outb_p(0xF3, IO_INDEX_PORT);
+        outb_p(0x00, IO_DATA_PORT);     /* another setting is 0E for kbd/mouse/LED */
+        outb_p(0xF4, IO_INDEX_PORT);
+        outb_p(0x00, IO_DATA_PORT);
 
         /* at last select device Aux1 (dev=7) and set GP16 as a watchdog output */
         /* in test mode watch the bit 1 on F4 to indicate "triggered" */
         if (!testmode)
         {
-                outb(0x07,0x370);
-                outb(0x07,0x371);
-                outb(0xE6,0x370);
-                outb(0x08,0x371);
+                outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+                outb_p(0x07, IO_DATA_PORT);
+                outb_p(0xE6, IO_INDEX_PORT);
+                outb_p(0x08, IO_DATA_PORT);
         }
 
         /* lock the SuperIO chip */
-        outb(0xAA,0x370);
+        outb_p(LOCK_DATA, IO_INDEX_PORT);
 
+        spin_unlock_irqrestore(&spinlock, flags);
         printk(KERN_INFO PFX "activated.\n");
 
         return 0;
@@ -106,35 +125,39 @@ static int wdt977_start(void)
 
 static int wdt977_stop(void)
 {
+        unsigned long flags;
+        spin_lock_irqsave(&spinlock, flags);
+
         /* unlock the SuperIO chip */
-        outb(0x87,0x370);
-        outb(0x87,0x370);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
 
         /* select device Aux2 (device=8) and set watchdog regs F2,F3 and F4
         * F3 is reset to its default state
         * F4 can clear the TIMEOUT'ed state (bit 0) - back to default
         * We can not use GP17 as a PowerLed, as we use its usage as a RedLed
         */
-        outb(0x07,0x370);
-        outb(0x08,0x371);
-        outb(0xF2,0x370);
-        outb(0xFF,0x371);
-        outb(0xF3,0x370);
-        outb(0x00,0x371);
-        outb(0xF4,0x370);
-        outb(0x00,0x371);
-        outb(0xF2,0x370);
-        outb(0x00,0x371);
+        outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+        outb_p(0x08, IO_DATA_PORT);
+        outb_p(0xF2, IO_INDEX_PORT);
+        outb_p(0xFF, IO_DATA_PORT);
+        outb_p(0xF3, IO_INDEX_PORT);
+        outb_p(0x00, IO_DATA_PORT);
+        outb_p(0xF4, IO_INDEX_PORT);
+        outb_p(0x00, IO_DATA_PORT);
+        outb_p(0xF2, IO_INDEX_PORT);
+        outb_p(0x00, IO_DATA_PORT);
 
         /* at last select device Aux1 (dev=7) and set GP16 as a watchdog output */
-        outb(0x07,0x370);
-        outb(0x07,0x371);
-        outb(0xE6,0x370);
-        outb(0x08,0x371);
+        outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+        outb_p(0x07, IO_DATA_PORT);
+        outb_p(0xE6, IO_INDEX_PORT);
+        outb_p(0x08, IO_DATA_PORT);
 
         /* lock the SuperIO chip */
-        outb(0xAA,0x370);
+        outb_p(LOCK_DATA, IO_INDEX_PORT);
 
+        spin_unlock_irqrestore(&spinlock, flags);
         printk(KERN_INFO PFX "shutdown.\n");
 
         return 0;
@@ -147,19 +170,23 @@ static int wdt977_stop(void)
 
 static int wdt977_keepalive(void)
 {
+        unsigned long flags;
+        spin_lock_irqsave(&spinlock, flags);
+
         /* unlock the SuperIO chip */
-        outb(0x87,0x370);
-        outb(0x87,0x370);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
 
         /* select device Aux2 (device=8) and kicks watchdog reg F2 */
         /* F2 has the timeout in minutes */
-        outb(0x07,0x370);
-        outb(0x08,0x371);
-        outb(0xF2,0x370);
-        outb(timeoutM,0x371);
+        outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+        outb_p(0x08, IO_DATA_PORT);
+        outb_p(0xF2, IO_INDEX_PORT);
+        outb_p(timeoutM, IO_DATA_PORT);
 
         /* lock the SuperIO chip */
-        outb(0xAA,0x370);
+        outb_p(LOCK_DATA, IO_INDEX_PORT);
+        spin_unlock_irqrestore(&spinlock, flags);
 
         return 0;
 }
@@ -198,22 +225,26 @@ static int wdt977_set_timeout(int t)
 static int wdt977_get_status(int *status)
 {
         int new_status;
+        unsigned long flags;
 
-        *status=0;
+        spin_lock_irqsave(&spinlock, flags);
 
         /* unlock the SuperIO chip */
-        outb(0x87,0x370);
-        outb(0x87,0x370);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
+        outb_p(UNLOCK_DATA, IO_INDEX_PORT);
 
         /* select device Aux2 (device=8) and read watchdog reg F4 */
-        outb(0x07,0x370);
-        outb(0x08,0x371);
-        outb(0xF4,0x370);
-        new_status = inb(0x371);
+        outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
+        outb_p(0x08, IO_DATA_PORT);
+        outb_p(0xF4, IO_INDEX_PORT);
+        new_status = inb_p(IO_DATA_PORT);
 
         /* lock the SuperIO chip */
-        outb(0xAA,0x370);
+        outb_p(LOCK_DATA, IO_INDEX_PORT);
 
+        spin_unlock_irqrestore(&spinlock, flags);
+
+        *status=0;
         if (new_status & 1)
                 *status |= WDIOF_CARDRESET;
 
@@ -249,8 +280,8 @@ static int wdt977_release(struct inode *inode, struct file *file)
                 wdt977_stop();
                 clear_bit(0,&timer_alive);
         } else {
-                printk(KERN_CRIT PFX "Unexpected close, not stopping watchdog!\n");
                 wdt977_keepalive();
+                printk(KERN_CRIT PFX "Unexpected close, not stopping watchdog!\n");
         }
         expect_close = 0;
         return 0;
@@ -271,14 +302,17 @@ static int wdt977_release(struct inode *inode, struct file *file)
 static ssize_t wdt977_write(struct file *file, const char __user *buf,
                             size_t count, loff_t *ppos)
 {
-        if (count) {
-                if (!nowayout) {
+        if (count)
+        {
+                if (!nowayout)
+                {
                         size_t i;
 
                         /* In case it was set long ago */
                         expect_close = 0;
 
-                        for (i = 0; i != count; i++) {
+                        for (i = 0; i != count; i++)
+                        {
                                 char c;
                                 if (get_user(c, buf + i))
                                         return -EFAULT;
@@ -287,6 +321,7 @@ static ssize_t wdt977_write(struct file *file, const char __user *buf,
                         }
                 }
 
+                /* someone wrote to us, we should restart timer */
                 wdt977_keepalive();
         }
         return count;
@@ -308,7 +343,7 @@ static struct watchdog_info ident = {
                                 WDIOF_MAGICCLOSE |
                                 WDIOF_KEEPALIVEPING,
         .firmware_version =     1,
-        .identity =             "Winbond 83977",
+        .identity =             WATCHDOG_NAME,
 };
 
 static int wdt977_ioctl(struct inode *inode, struct file *file,
@@ -405,50 +440,81 @@ static struct notifier_block wdt977_notifier = {
         .notifier_call = wdt977_notify_sys,
 };
 
-static int __init nwwatchdog_init(void)
+static int __init wd977_init(void)
 {
-        int retval;
-        if (!machine_is_netwinder())
-                return -ENODEV;
+        int rc;
+
+        //if (!machine_is_netwinder())
+        //      return -ENODEV;
+
+        printk(KERN_INFO PFX DRIVER_VERSION);
+
+        spin_lock_init(&spinlock);
 
         /* Check that the timeout value is within it's range ; if not reset to the default */
-        if (wdt977_set_timeout(timeout)) {
+        if (wdt977_set_timeout(timeout))
+        {
                 wdt977_set_timeout(DEFAULT_TIMEOUT);
                 printk(KERN_INFO PFX "timeout value must be 60<timeout<15300, using %d\n",
                         DEFAULT_TIMEOUT);
         }
 
-        retval = register_reboot_notifier(&wdt977_notifier);
-        if (retval) {
-                printk(KERN_ERR PFX "cannot register reboot notifier (err=%d)\n",
-                        retval);
-                return retval;
+        /* on Netwinder the IOports are already reserved by
+         * arch/arm/mach-footbridge/netwinder-hw.c
+         */
+        if (!machine_is_netwinder())
+        {
+                if (!request_region(IO_INDEX_PORT, 2, WATCHDOG_NAME))
+                {
+                        printk(KERN_ERR PFX "I/O address 0x%04x already in use\n",
+                                IO_INDEX_PORT);
+                        rc = -EIO;
+                        goto err_out;
+                }
         }
 
-        retval = misc_register(&wdt977_miscdev);
-        if (retval) {
+        rc = misc_register(&wdt977_miscdev);
+        if (rc)
+        {
                 printk(KERN_ERR PFX "cannot register miscdev on minor=%d (err=%d)\n",
-                        WATCHDOG_MINOR, retval);
-                unregister_reboot_notifier(&wdt977_notifier);
-                return retval;
+                        wdt977_miscdev.minor, rc);
+                goto err_out_region;
+        }
+
+        rc = register_reboot_notifier(&wdt977_notifier);
+        if (rc)
+        {
+                printk(KERN_ERR PFX "cannot register reboot notifier (err=%d)\n",
+                        rc);
+                goto err_out_miscdev;
         }
 
-        printk(KERN_INFO PFX "initialized. timeout=%d sec (nowayout=%d, testmode = %i)\n",
+        printk(KERN_INFO PFX "initialized. timeout=%d sec (nowayout=%d, testmode=%i)\n",
                 timeout, nowayout, testmode);
 
         return 0;
+
+err_out_miscdev:
+        misc_deregister(&wdt977_miscdev);
+err_out_region:
+        if (!machine_is_netwinder())
+                release_region(IO_INDEX_PORT,2);
+err_out:
+        return rc;
 }
 
-static void __exit nwwatchdog_exit(void)
+static void __exit wd977_exit(void)
 {
+        wdt977_stop();
         misc_deregister(&wdt977_miscdev);
         unregister_reboot_notifier(&wdt977_notifier);
+        release_region(IO_INDEX_PORT,2);
 }
 
-module_init(nwwatchdog_init);
-module_exit(nwwatchdog_exit);
+module_init(wd977_init);
+module_exit(wd977_exit);
 
-MODULE_AUTHOR("Woody Suwalski <woody@netwinder.org>");
+MODULE_AUTHOR("Woody Suwalski <woodys@xandros.com>");
 MODULE_DESCRIPTION("W83977AF Watchdog driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
index 969d2b4aaec0..385e52930c02 100644
--- a/drivers/connector/cn_proc.c
+++ b/drivers/connector/cn_proc.c
@@ -34,14 +34,14 @@
 static atomic_t proc_event_num_listeners = ATOMIC_INIT(0);
 static struct cb_id cn_proc_event_id = { CN_IDX_PROC, CN_VAL_PROC };
 
-/* proc_counts is used as the sequence number of the netlink message */
+/* proc_event_counts is used as the sequence number of the netlink message */
 static DEFINE_PER_CPU(__u32, proc_event_counts) = { 0 };
 
 static inline void get_seq(__u32 *ts, int *cpu)
 {
         *ts = get_cpu_var(proc_event_counts)++;
         *cpu = smp_processor_id();
-        put_cpu_var(proc_counts);
+        put_cpu_var(proc_event_counts);
 }
 
 void proc_fork_connector(struct task_struct *task)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 4010fe92e72b..08d5b8fed2dc 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -236,27 +236,17 @@ config I2C_IXP2000
           This support is also available as a module. If so, the module
           will be called i2c-ixp2000.
 
-config I2C_KEYWEST
-        tristate "Powermac Keywest I2C interface"
+config I2C_POWERMAC
+        tristate "Powermac I2C interface"
         depends on I2C && PPC_PMAC
+        default y
         help
-          This supports the use of the I2C interface in the combo-I/O
-          chip on recent Apple machines.  Say Y if you have such a machine.
-
-          This support is also available as a module.  If so, the module 
-          will be called i2c-keywest.
-
-config I2C_PMAC_SMU
-        tristate "Powermac SMU I2C interface"
-        depends on I2C && PMAC_SMU
-        help
-          This supports the use of the I2C interface in the SMU
-          chip on recent Apple machines like the iMac G5.  It is used
-          among others by the thermal control driver for those machines.
-          Say Y if you have such a machine.
+          This exposes the various PowerMac i2c interfaces to the linux i2c
+          layer and to userland. It is used by various drivers on the powemac
+          platform, thus should generally be enabled.
 
           This support is also available as a module.  If so, the module
-          will be called i2c-pmac-smu.
+          will be called i2c-powermac.
 
 config I2C_MPC
         tristate "MPC107/824x/85xx/52xx"
diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile
index f1df00f66c6c..b44831dff683 100644
--- a/drivers/i2c/busses/Makefile
+++ b/drivers/i2c/busses/Makefile
@@ -19,8 +19,7 @@ obj-$(CONFIG_I2C_ISA)		+= i2c-isa.o
 obj-$(CONFIG_I2C_ITE)           += i2c-ite.o
 obj-$(CONFIG_I2C_IXP2000)       += i2c-ixp2000.o
 obj-$(CONFIG_I2C_IXP4XX)        += i2c-ixp4xx.o
-obj-$(CONFIG_I2C_KEYWEST)       += i2c-keywest.o
-obj-$(CONFIG_I2C_PMAC_SMU)      += i2c-pmac-smu.o
+obj-$(CONFIG_I2C_POWERMAC)      += i2c-powermac.o
 obj-$(CONFIG_I2C_MPC)           += i2c-mpc.o
 obj-$(CONFIG_I2C_MV64XXX)       += i2c-mv64xxx.o
 obj-$(CONFIG_I2C_NFORCE2)       += i2c-nforce2.o
diff --git a/drivers/i2c/busses/i2c-keywest.c b/drivers/i2c/busses/i2c-keywest.c
deleted file mode 100644
index d61f748278fc..000000000000
--- a/drivers/i2c/busses/i2c-keywest.c
+++ /dev/null
@@ -1,751 +0,0 @@
-/*
-    i2c Support for Apple Keywest I2C Bus Controller
-
-    Copyright (c) 2001 Benjamin Herrenschmidt <benh@kernel.crashing.org>
-
-    Original work by
-    
-    Copyright (c) 2000 Philip Edelbrock <phil@stimpy.netroedge.com>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    Changes:
-
-    2001/12/13 BenH     New implementation
-    2001/12/15 BenH     Add support for "byte" and "quick"
-                        transfers. Add i2c_xfer routine.
-    2003/09/21 BenH     Rework state machine with Paulus help
-    2004/01/21 BenH     Merge in Greg KH changes, polled mode is back
-    2004/02/05 BenH     Merge 64 bits fixes from the g5 ppc64 tree
-
-    My understanding of the various modes supported by keywest are:
-
-     - Dumb mode : not implemented, probably direct tweaking of lines
-     - Standard mode : simple i2c transaction of type
-         S Addr R/W A Data A Data ... T
-     - Standard sub mode : combined 8 bit subaddr write with data read
-         S Addr R/W A SubAddr A Data A Data ... T
-     - Combined mode : Subaddress and Data sequences appended with no stop
-         S Addr R/W A SubAddr S Addr R/W A Data A Data ... T
-
-    Currently, this driver uses only Standard mode for i2c xfer, and
-    smbus byte & quick transfers ; and uses StandardSub mode for
-    other smbus transfers instead of combined as we need that for the
-    sound driver to be happy
-*/
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/ioport.h>
-#include <linux/pci.h>
-#include <linux/types.h>
-#include <linux/delay.h>
-#include <linux/i2c.h>
-#include <linux/init.h>
-#include <linux/mm.h>
-#include <linux/timer.h>
-#include <linux/spinlock.h>
-#include <linux/completion.h>
-#include <linux/interrupt.h>
-
-#include <asm/io.h>
-#include <asm/prom.h>
-#include <asm/machdep.h>
-#include <asm/pmac_feature.h>
-#include <asm/pmac_low_i2c.h>
-
-#include "i2c-keywest.h"
-
-#undef POLLED_MODE
-
-/* Some debug macros */
-#define WRONG_STATE(name) do {\
-                pr_debug("KW: wrong state. Got %s, state: %s (isr: %02x)\n", \
-                         name, __kw_state_names[iface->state], isr);    \
-        } while(0)
-
-#ifdef DEBUG
-static const char *__kw_state_names[] = {
-        "state_idle",
-        "state_addr",
-        "state_read",
-        "state_write",
-        "state_stop",
-        "state_dead"
-};
-#endif /* DEBUG */
-
-MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");
-MODULE_DESCRIPTION("I2C driver for Apple's Keywest");
-MODULE_LICENSE("GPL");
-
-#ifdef POLLED_MODE
-/* Don't schedule, the g5 fan controller is too
- * timing sensitive
- */
-static u8
-wait_interrupt(struct keywest_iface* iface)
-{
-        int i;
-        u8 isr;
-        
-        for (i = 0; i < 200000; i++) {
-                isr = read_reg(reg_isr) & KW_I2C_IRQ_MASK;
-                if (isr != 0)
-                        return isr;
-                udelay(10);
-        }
-        return isr;
-}
-#endif /* POLLED_MODE */
-
-static void
-do_stop(struct keywest_iface* iface, int result)
-{
-        write_reg(reg_control, KW_I2C_CTL_STOP);
-        iface->state = state_stop;
-        iface->result = result;
-}
-
-/* Main state machine for standard & standard sub mode */
-static void
-handle_interrupt(struct keywest_iface *iface, u8 isr)
-{
-        int ack;
-        
-        if (isr == 0) {
-                if (iface->state != state_stop) {
-                        pr_debug("KW: Timeout !\n");
-                        do_stop(iface, -EIO);
-                }
-                if (iface->state == state_stop) {
-                        ack = read_reg(reg_status);
-                        if (!(ack & KW_I2C_STAT_BUSY)) {
-                                iface->state = state_idle;
-                                write_reg(reg_ier, 0x00);
-#ifndef POLLED_MODE
-                                complete(&iface->complete);
-#endif /* POLLED_MODE */
-                        }
-                }
-                return;
-        }
-
-        if (isr & KW_I2C_IRQ_ADDR) {
-                ack = read_reg(reg_status);
-                if (iface->state != state_addr) {
-                        write_reg(reg_isr, KW_I2C_IRQ_ADDR);
-                        WRONG_STATE("KW_I2C_IRQ_ADDR"); 
-                        do_stop(iface, -EIO);
-                        return;
-                }
-                if ((ack & KW_I2C_STAT_LAST_AAK) == 0) {
-                        iface->state = state_stop;                   
-                        iface->result = -ENODEV;
-                        pr_debug("KW: NAK on address\n");
-                } else {
-                        /* Handle rw "quick" mode */
-                        if (iface->datalen == 0) {
-                                do_stop(iface, 0);
-                        } else if (iface->read_write == I2C_SMBUS_READ) {
-                                iface->state = state_read;
-                                if (iface->datalen > 1)
-                                        write_reg(reg_control, KW_I2C_CTL_AAK);
-                        } else {
-                                iface->state = state_write;
-                                write_reg(reg_data, *(iface->data++));
-                                iface->datalen--;
-                        }
-                }
-                write_reg(reg_isr, KW_I2C_IRQ_ADDR);
-        }
-
-        if (isr & KW_I2C_IRQ_DATA) {
-                if (iface->state == state_read) {
-                        *(iface->data++) = read_reg(reg_data);
-                        write_reg(reg_isr, KW_I2C_IRQ_DATA);
-                        iface->datalen--;
-                        if (iface->datalen == 0)
-                                iface->state = state_stop;
-                        else if (iface->datalen == 1)
-                                write_reg(reg_control, 0);
-                } else if (iface->state == state_write) {
-                        /* Check ack status */
-                        ack = read_reg(reg_status);
-                        if ((ack & KW_I2C_STAT_LAST_AAK) == 0) {
-                                pr_debug("KW: nack on data write (%x): %x\n",
-                                    iface->data[-1], ack);
-                                do_stop(iface, -EIO);
-                        } else if (iface->datalen) {
-                                write_reg(reg_data, *(iface->data++));
-                                iface->datalen--;
-                        } else {
-                                write_reg(reg_control, KW_I2C_CTL_STOP);
-                                iface->state = state_stop;
-                                iface->result = 0;
-                        }
-                        write_reg(reg_isr, KW_I2C_IRQ_DATA);
-                } else {
-                        write_reg(reg_isr, KW_I2C_IRQ_DATA);
-                        WRONG_STATE("KW_I2C_IRQ_DATA"); 
-                        if (iface->state != state_stop)
-                                do_stop(iface, -EIO);
-                }
-        }
-
-        if (isr & KW_I2C_IRQ_STOP) {
-                write_reg(reg_isr, KW_I2C_IRQ_STOP);
-                if (iface->state != state_stop) {
-                        WRONG_STATE("KW_I2C_IRQ_STOP");
-                        iface->result = -EIO;
-                }
-                iface->state = state_idle;
-                write_reg(reg_ier, 0x00);
-#ifndef POLLED_MODE
-                complete(&iface->complete);
-#endif /* POLLED_MODE */                        
-        }
-
-        if (isr & KW_I2C_IRQ_START)
-                write_reg(reg_isr, KW_I2C_IRQ_START);
-}
-
-#ifndef POLLED_MODE
-
-/* Interrupt handler */
-static irqreturn_t
-keywest_irq(int irq, void *dev_id, struct pt_regs *regs)
-{
-        struct keywest_iface *iface = (struct keywest_iface *)dev_id;
-        unsigned long flags;
-
-        spin_lock_irqsave(&iface->lock, flags);
-        del_timer(&iface->timeout_timer);
-        handle_interrupt(iface, read_reg(reg_isr));
-        if (iface->state != state_idle) {
-                iface->timeout_timer.expires = jiffies + POLL_TIMEOUT;
-                add_timer(&iface->timeout_timer);
-        }
-        spin_unlock_irqrestore(&iface->lock, flags);
-        return IRQ_HANDLED;
-}
-
-static void
-keywest_timeout(unsigned long data)
-{
-        struct keywest_iface *iface = (struct keywest_iface *)data;
-        unsigned long flags;
-
-        pr_debug("timeout !\n");
-        spin_lock_irqsave(&iface->lock, flags);
-        handle_interrupt(iface, read_reg(reg_isr));
-        if (iface->state != state_idle) {
-                iface->timeout_timer.expires = jiffies + POLL_TIMEOUT;
-                add_timer(&iface->timeout_timer);
-        }
-        spin_unlock_irqrestore(&iface->lock, flags);
-}
-
-#endif /* POLLED_MODE */
-
-/*
- * SMBUS-type transfer entrypoint
- */
-static s32
-keywest_smbus_xfer(     struct i2c_adapter*     adap,
-                        u16                     addr,
-                        unsigned short          flags,
-                        char                    read_write,
-                        u8                      command,
-                        int                     size,
-                        union i2c_smbus_data*   data)
-{
-        struct keywest_chan* chan = i2c_get_adapdata(adap);
-        struct keywest_iface* iface = chan->iface;
-        int len;
-        u8* buffer;
-        u16 cur_word;
-        int rc = 0;
-
-        if (iface->state == state_dead)
-                return -ENXIO;
-                
-        /* Prepare datas & select mode */
-        iface->cur_mode &= ~KW_I2C_MODE_MODE_MASK;
-        switch (size) {
-        case I2C_SMBUS_QUICK:
-                len = 0;
-                buffer = NULL;
-                iface->cur_mode |= KW_I2C_MODE_STANDARD;
-                break;
-        case I2C_SMBUS_BYTE:
-                len = 1;
-                buffer = &data->byte;
-                iface->cur_mode |= KW_I2C_MODE_STANDARD;
-                break;
-        case I2C_SMBUS_BYTE_DATA:
-                len = 1;
-                buffer = &data->byte;
-                iface->cur_mode |= KW_I2C_MODE_STANDARDSUB;
-                break;
-        case I2C_SMBUS_WORD_DATA:
-                len = 2;
-                cur_word = cpu_to_le16(data->word);
-                buffer = (u8 *)&cur_word;
-                iface->cur_mode |= KW_I2C_MODE_STANDARDSUB;
-                break;
-        case I2C_SMBUS_BLOCK_DATA:
-                len = data->block[0];
-                buffer = &data->block[1];
-                iface->cur_mode |= KW_I2C_MODE_STANDARDSUB;
-                break;
-        default:
-                return -1;
-        }
-
-        /* Turn a standardsub read into a combined mode access */
-        if (read_write == I2C_SMBUS_READ
-            && (iface->cur_mode & KW_I2C_MODE_MODE_MASK) == KW_I2C_MODE_STANDARDSUB) {
-                iface->cur_mode &= ~KW_I2C_MODE_MODE_MASK;
-                iface->cur_mode |= KW_I2C_MODE_COMBINED;
-        }
-
-        /* Original driver had this limitation */
-        if (len > 32)
-                len = 32;
-
-        if (pmac_low_i2c_lock(iface->node))
-                return -ENXIO;
-
-        pr_debug("chan: %d, addr: 0x%x, transfer len: %d, read: %d\n",
-                chan->chan_no, addr, len, read_write == I2C_SMBUS_READ);
-
-        iface->data = buffer;
-        iface->datalen = len;
-        iface->state = state_addr;
-        iface->result = 0;
-        iface->read_write = read_write;
-        
-        /* Setup channel & clear pending irqs */
-        write_reg(reg_isr, read_reg(reg_isr));
-        write_reg(reg_mode, iface->cur_mode | (chan->chan_no << 4));
-        write_reg(reg_status, 0);
-
-        /* Set up address and r/w bit */
-        write_reg(reg_addr,
-                (addr << 1) | ((read_write == I2C_SMBUS_READ) ? 0x01 : 0x00));
-
-        /* Set up the sub address */
-        if ((iface->cur_mode & KW_I2C_MODE_MODE_MASK) == KW_I2C_MODE_STANDARDSUB
-            || (iface->cur_mode & KW_I2C_MODE_MODE_MASK) == KW_I2C_MODE_COMBINED)
-                write_reg(reg_subaddr, command);
-
-#ifndef POLLED_MODE
-        /* Arm timeout */
-        iface->timeout_timer.expires = jiffies + POLL_TIMEOUT;
-        add_timer(&iface->timeout_timer);
-#endif
-
-        /* Start sending address & enable interrupt*/
-        write_reg(reg_control, KW_I2C_CTL_XADDR);
-        write_reg(reg_ier, KW_I2C_IRQ_MASK);
-
-#ifdef POLLED_MODE
-        pr_debug("using polled mode...\n");
-        /* State machine, to turn into an interrupt handler */
-        while(iface->state != state_idle) {
-                unsigned long flags;
-
-                u8 isr = wait_interrupt(iface);
-                spin_lock_irqsave(&iface->lock, flags);
-                handle_interrupt(iface, isr);
-                spin_unlock_irqrestore(&iface->lock, flags);
-        }
-#else /* POLLED_MODE */
-        pr_debug("using interrupt mode...\n");
-        wait_for_completion(&iface->complete);  
-#endif /* POLLED_MODE */        
-
-        rc = iface->result;     
-        pr_debug("transfer done, result: %d\n", rc);
-
-        if (rc == 0 && size == I2C_SMBUS_WORD_DATA && read_write == I2C_SMBUS_READ)
-                data->word = le16_to_cpu(cur_word);
-        
-        /* Release sem */
-        pmac_low_i2c_unlock(iface->node);
-        
-        return rc;
-}
-
-/*
- * Generic i2c master transfer entrypoint
- */
-static int
-keywest_xfer(   struct i2c_adapter *adap,
-                struct i2c_msg *msgs, 
-                int num)
-{
-        struct keywest_chan* chan = i2c_get_adapdata(adap);
-        struct keywest_iface* iface = chan->iface;
-        struct i2c_msg *pmsg;
-        int i, completed;
-        int rc = 0;
-
-        if (iface->state == state_dead)
-                return -ENXIO;
-
-        if (pmac_low_i2c_lock(iface->node))
-                return -ENXIO;
-
-        /* Set adapter to standard mode */
-        iface->cur_mode &= ~KW_I2C_MODE_MODE_MASK;
-        iface->cur_mode |= KW_I2C_MODE_STANDARD;
-
-        completed = 0;
-        for (i = 0; rc >= 0 && i < num;) {
-                u8 addr;
-                
-                pmsg = &msgs[i++];
-                addr = pmsg->addr;
-                if (pmsg->flags & I2C_M_TEN) {
-                        printk(KERN_ERR "i2c-keywest: 10 bits addr not supported !\n");
-                        rc = -EINVAL;
-                        break;
-                }
-                pr_debug("xfer: chan: %d, doing %s %d bytes to 0x%02x - %d of %d messages\n",
-                     chan->chan_no,
-                     pmsg->flags & I2C_M_RD ? "read" : "write",
-                     pmsg->len, addr, i, num);
-    
-                /* Setup channel & clear pending irqs */
-                write_reg(reg_mode, iface->cur_mode | (chan->chan_no << 4));
-                write_reg(reg_isr, read_reg(reg_isr));
-                write_reg(reg_status, 0);
-                
-                iface->data = pmsg->buf;
-                iface->datalen = pmsg->len;
-                iface->state = state_addr;
-                iface->result = 0;
-                if (pmsg->flags & I2C_M_RD)
-                        iface->read_write = I2C_SMBUS_READ;
-                else
-                        iface->read_write = I2C_SMBUS_WRITE;
-
-                /* Set up address and r/w bit */
-                if (pmsg->flags & I2C_M_REV_DIR_ADDR)
-                        addr ^= 1;              
-                write_reg(reg_addr,
-                        (addr << 1) |
-                        ((iface->read_write == I2C_SMBUS_READ) ? 0x01 : 0x00));
-
-#ifndef POLLED_MODE
-                /* Arm timeout */
-                iface->timeout_timer.expires = jiffies + POLL_TIMEOUT;
-                add_timer(&iface->timeout_timer);
-#endif
-
-                /* Start sending address & enable interrupt*/
-                write_reg(reg_ier, KW_I2C_IRQ_MASK);
-                write_reg(reg_control, KW_I2C_CTL_XADDR);
-
-#ifdef POLLED_MODE
-                pr_debug("using polled mode...\n");
-                /* State machine, to turn into an interrupt handler */
-                while(iface->state != state_idle) {
-                        u8 isr = wait_interrupt(iface);
-                        handle_interrupt(iface, isr);
-                }
-#else /* POLLED_MODE */
-                pr_debug("using interrupt mode...\n");
-                wait_for_completion(&iface->complete);  
-#endif /* POLLED_MODE */        
-
-                rc = iface->result;
-                if (rc == 0)
-                        completed++;
-                pr_debug("transfer done, result: %d\n", rc);
-        }
-
-        /* Release sem */
-        pmac_low_i2c_unlock(iface->node);
-
-        return completed;
-}
-
-static u32
-keywest_func(struct i2c_adapter * adapter)
-{
-        return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
-               I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
-               I2C_FUNC_SMBUS_BLOCK_DATA;
-}
-
-/* For now, we only handle combined mode (smbus) */
-static struct i2c_algorithm keywest_algorithm = {
-        .smbus_xfer     = keywest_smbus_xfer,
-        .master_xfer    = keywest_xfer,
-        .functionality  = keywest_func,
-};
-
-
-static int
-create_iface(struct device_node *np, struct device *dev)
-{
-        unsigned long steps;
-        unsigned bsteps, tsize, i, nchan, addroffset;
-        struct keywest_iface* iface;
-        u32 *psteps, *prate;
-        int rc;
-
-        if (np->n_intrs < 1 || np->n_addrs < 1) {
-                printk(KERN_ERR "%s: Missing interrupt or address !\n",
-                       np->full_name);
-                return -ENODEV;
-        }
-        if (pmac_low_i2c_lock(np))
-                return -ENODEV;
-
-        psteps = (u32 *)get_property(np, "AAPL,address-step", NULL);
-        steps = psteps ? (*psteps) : 0x10;
-
-        /* Hrm... maybe we can be smarter here */
-        for (bsteps = 0; (steps & 0x01) == 0; bsteps++)
-                steps >>= 1;
-
-        if (np->parent->name[0] == 'u') {
-                nchan = 2;
-                addroffset = 3;
-        } else {
-                addroffset = 0;
-                nchan = 1;
-        }
-
-        tsize = sizeof(struct keywest_iface) +
-                (sizeof(struct keywest_chan) + 4) * nchan;
-        iface = kzalloc(tsize, GFP_KERNEL);
-        if (iface == NULL) {
-                printk(KERN_ERR "i2c-keywest: can't allocate inteface !\n");
-                pmac_low_i2c_unlock(np);
-                return -ENOMEM;
-        }
-        spin_lock_init(&iface->lock);
-        init_completion(&iface->complete);
-        iface->node = of_node_get(np);
-        iface->bsteps = bsteps;
-        iface->chan_count = nchan;
-        iface->state = state_idle;
-        iface->irq = np->intrs[0].line;
-        iface->channels = (struct keywest_chan *)
-                (((unsigned long)(iface + 1) + 3UL) & ~3UL);
-        iface->base = ioremap(np->addrs[0].address + addroffset,
-                                                np->addrs[0].size);
-        if (!iface->base) {
-                printk(KERN_ERR "i2c-keywest: can't map inteface !\n");
-                kfree(iface);
-                pmac_low_i2c_unlock(np);
-                return -ENOMEM;
-        }
-
-#ifndef POLLED_MODE
-        init_timer(&iface->timeout_timer);
-        iface->timeout_timer.function = keywest_timeout;
-        iface->timeout_timer.data = (unsigned long)iface;
-#endif
-
-        /* Select interface rate */
-        iface->cur_mode = KW_I2C_MODE_100KHZ;
-        prate = (u32 *)get_property(np, "AAPL,i2c-rate", NULL);
-        if (prate) switch(*prate) {
-        case 100:
-                iface->cur_mode = KW_I2C_MODE_100KHZ;
-                break;
-        case 50:
-                iface->cur_mode = KW_I2C_MODE_50KHZ;
-                break;
-        case 25:
-                iface->cur_mode = KW_I2C_MODE_25KHZ;
-                break;
-        default:
-                printk(KERN_WARNING "i2c-keywest: unknown rate %ldKhz, using 100KHz\n",
-                       (long)*prate);
-        }
-        
-        /* Select standard mode by default */
-        iface->cur_mode |= KW_I2C_MODE_STANDARD;
-        
-        /* Write mode */
-        write_reg(reg_mode, iface->cur_mode);
-        
-        /* Switch interrupts off & clear them*/
-        write_reg(reg_ier, 0x00);
-        write_reg(reg_isr, KW_I2C_IRQ_MASK);
-
-#ifndef POLLED_MODE
-        /* Request chip interrupt */    
-        rc = request_irq(iface->irq, keywest_irq, SA_INTERRUPT, "keywest i2c", iface);
-        if (rc) {
-                printk(KERN_ERR "i2c-keywest: can't get IRQ %d !\n", iface->irq);
-                iounmap(iface->base);
-                kfree(iface);
-                pmac_low_i2c_unlock(np);
-                return -ENODEV;
-        }
-#endif /* POLLED_MODE */
-
-        pmac_low_i2c_unlock(np);
-        dev_set_drvdata(dev, iface);
-        
-        for (i=0; i<nchan; i++) {
-                struct keywest_chan* chan = &iface->channels[i];
-                
-                sprintf(chan->adapter.name, "%s %d", np->parent->name, i);
-                chan->iface = iface;
-                chan->chan_no = i;
-                chan->adapter.algo = &keywest_algorithm;
-                chan->adapter.algo_data = NULL;
-                chan->adapter.client_register = NULL;
-                chan->adapter.client_unregister = NULL;
-                i2c_set_adapdata(&chan->adapter, chan);
-                chan->adapter.dev.parent = dev;
-
-                rc = i2c_add_adapter(&chan->adapter);
-                if (rc) {
-                        printk("i2c-keywest.c: Adapter %s registration failed\n",
-                                chan->adapter.name);
-                        i2c_set_adapdata(&chan->adapter, NULL);
-                }
-        }
-
-        printk(KERN_INFO "Found KeyWest i2c on \"%s\", %d channel%s, stepping: %d bits\n",
-                np->parent->name, nchan, nchan > 1 ? "s" : "", bsteps);
-                
-        return 0;
-}
-
-static int
-dispose_iface(struct device *dev)
-{
-        struct keywest_iface *iface = dev_get_drvdata(dev);
-        int i, rc;
-        
-        /* Make sure we stop all activity */
-        if (pmac_low_i2c_lock(iface->node))
-                return -ENODEV;
-
-#ifndef POLLED_MODE
-        spin_lock_irq(&iface->lock);
-        while (iface->state != state_idle) {
-                spin_unlock_irq(&iface->lock);
-                msleep(100);
-                spin_lock_irq(&iface->lock);
-        }
-#endif /* POLLED_MODE */
-        iface->state = state_dead;
-#ifndef POLLED_MODE
-        spin_unlock_irq(&iface->lock);
-        free_irq(iface->irq, iface);
-#endif /* POLLED_MODE */
-
-        pmac_low_i2c_unlock(iface->node);
-
-        /* Release all channels */
-        for (i=0; i<iface->chan_count; i++) {
-                struct keywest_chan* chan = &iface->channels[i];
-                if (i2c_get_adapdata(&chan->adapter) == NULL)
-                        continue;
-                rc = i2c_del_adapter(&chan->adapter);
-                i2c_set_adapdata(&chan->adapter, NULL);
-                /* We aren't that prepared to deal with this... */
-                if (rc)
-                        printk("i2c-keywest.c: i2c_del_adapter failed, that's bad !\n");
-        }
-        iounmap(iface->base);
-        dev_set_drvdata(dev, NULL);
-        of_node_put(iface->node);
-        kfree(iface);
-
-        return 0;
-}
-
-static int
-create_iface_macio(struct macio_dev* dev, const struct of_device_id *match)
-{
-        return create_iface(dev->ofdev.node, &dev->ofdev.dev);
-}
-
-static int
-dispose_iface_macio(struct macio_dev* dev)
-{
-        return dispose_iface(&dev->ofdev.dev);
-}
-
-static int
-create_iface_of_platform(struct of_device* dev, const struct of_device_id *match)
-{
-        return create_iface(dev->node, &dev->dev);
-}
-
-static int
-dispose_iface_of_platform(struct of_device* dev)
-{
-        return dispose_iface(&dev->dev);
-}
-
-static struct of_device_id i2c_keywest_match[] = 
-{
-        {
-        .type           = "i2c",
-        .compatible     = "keywest"
-        },
-        {},
-};
-
-static struct macio_driver i2c_keywest_macio_driver = 
-{
-        .owner          = THIS_MODULE,
-        .name           = "i2c-keywest",
-        .match_table    = i2c_keywest_match,
-        .probe          = create_iface_macio,
-        .remove         = dispose_iface_macio
-};
-
-static struct of_platform_driver i2c_keywest_of_platform_driver = 
-{
-        .owner          = THIS_MODULE,
-        .name           = "i2c-keywest",
-        .match_table    = i2c_keywest_match,
-        .probe          = create_iface_of_platform,
-        .remove         = dispose_iface_of_platform
-};
-
-static int __init
-i2c_keywest_init(void)
-{
-        of_register_driver(&i2c_keywest_of_platform_driver);
-        macio_register_driver(&i2c_keywest_macio_driver);
-
-        return 0;
-}
-
-static void __exit
-i2c_keywest_cleanup(void)
-{
-        of_unregister_driver(&i2c_keywest_of_platform_driver);
-        macio_unregister_driver(&i2c_keywest_macio_driver);
-}
-
-module_init(i2c_keywest_init);
-module_exit(i2c_keywest_cleanup);
diff --git a/drivers/i2c/busses/i2c-keywest.h b/drivers/i2c/busses/i2c-keywest.h
deleted file mode 100644
index c5022e1ca6ff..000000000000
--- a/drivers/i2c/busses/i2c-keywest.h
+++ /dev/null
@@ -1,108 +0,0 @@
-#ifndef __I2C_KEYWEST_H__
-#define __I2C_KEYWEST_H__
-
-/* The Tumbler audio equalizer can be really slow sometimes */
-#define POLL_TIMEOUT            (2*HZ)
-
-/* Register indices */
-typedef enum {
-        reg_mode = 0,
-        reg_control,
-        reg_status,
-        reg_isr,
-        reg_ier,
-        reg_addr,
-        reg_subaddr,
-        reg_data
-} reg_t;
-
-
-/* Mode register */
-#define KW_I2C_MODE_100KHZ      0x00
-#define KW_I2C_MODE_50KHZ       0x01
-#define KW_I2C_MODE_25KHZ       0x02
-#define KW_I2C_MODE_DUMB        0x00
-#define KW_I2C_MODE_STANDARD    0x04
-#define KW_I2C_MODE_STANDARDSUB 0x08
-#define KW_I2C_MODE_COMBINED    0x0C
-#define KW_I2C_MODE_MODE_MASK   0x0C
-#define KW_I2C_MODE_CHAN_MASK   0xF0
-
-/* Control register */
-#define KW_I2C_CTL_AAK          0x01
-#define KW_I2C_CTL_XADDR        0x02
-#define KW_I2C_CTL_STOP         0x04
-#define KW_I2C_CTL_START        0x08
-
-/* Status register */
-#define KW_I2C_STAT_BUSY        0x01
-#define KW_I2C_STAT_LAST_AAK    0x02
-#define KW_I2C_STAT_LAST_RW     0x04
-#define KW_I2C_STAT_SDA         0x08
-#define KW_I2C_STAT_SCL         0x10
-
-/* IER & ISR registers */
-#define KW_I2C_IRQ_DATA         0x01
-#define KW_I2C_IRQ_ADDR         0x02
-#define KW_I2C_IRQ_STOP         0x04
-#define KW_I2C_IRQ_START        0x08
-#define KW_I2C_IRQ_MASK         0x0F
-
-/* Physical interface */
-struct keywest_iface
-{
-        struct device_node      *node;
-        void __iomem *          base;
-        unsigned                bsteps;
-        int                     irq;
-        spinlock_t              lock;
-        struct keywest_chan     *channels;
-        unsigned                chan_count;
-        u8                      cur_mode;
-        char                    read_write;
-        u8                      *data;
-        unsigned                datalen;
-        int                     state;
-        int                     result;
-        struct timer_list       timeout_timer;
-        struct completion       complete;
-};
-
-enum {
-        state_idle,
-        state_addr,
-        state_read,
-        state_write,
-        state_stop,
-        state_dead
-};
-
-/* Channel on an interface */
-struct keywest_chan
-{
-        struct i2c_adapter      adapter;
-        struct keywest_iface*   iface;
-        unsigned                chan_no;
-};
-
-/* Register access */
-
-static inline u8 __read_reg(struct keywest_iface *iface, reg_t reg)
-{
-        return in_8(iface->base
-                + (((unsigned)reg) << iface->bsteps));
-}
-
-static inline void __write_reg(struct keywest_iface *iface, reg_t reg, u8 val)
-{
-        out_8(iface->base
-                + (((unsigned)reg) << iface->bsteps), val);
-        (void)__read_reg(iface, reg_subaddr);
-}
-
-#define write_reg(reg, val)     __write_reg(iface, reg, val) 
-#define read_reg(reg)           __read_reg(iface, reg) 
-
-
-
-#endif /* __I2C_KEYWEST_H__ */
diff --git a/drivers/i2c/busses/i2c-pmac-smu.c b/drivers/i2c/busses/i2c-pmac-smu.c
deleted file mode 100644
index bfefe7f7a53d..000000000000
--- a/drivers/i2c/busses/i2c-pmac-smu.c
+++ /dev/null
@@ -1,315 +0,0 @@
-/*
-    i2c Support for Apple SMU Controller
-
-    Copyright (c) 2005 Benjamin Herrenschmidt, IBM Corp.
-                       <benh@kernel.crashing.org>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-*/
-
-#include <linux/config.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/types.h>
-#include <linux/i2c.h>
-#include <linux/init.h>
-#include <linux/completion.h>
-#include <linux/device.h>
-#include <asm/prom.h>
-#include <asm/of_device.h>
-#include <asm/smu.h>
-
-static int probe;
-
-MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");
-MODULE_DESCRIPTION("I2C driver for Apple's SMU");
-MODULE_LICENSE("GPL");
-module_param(probe, bool, 0);
-
-
-/* Physical interface */
-struct smu_iface
-{
-        struct i2c_adapter      adapter;
-        struct completion       complete;
-        u32                     busid;
-};
-
-static void smu_i2c_done(struct smu_i2c_cmd *cmd, void *misc)
-{
-        struct smu_iface        *iface = misc;
-        complete(&iface->complete);
-}
-
-/*
- * SMBUS-type transfer entrypoint
- */
-static s32 smu_smbus_xfer(      struct i2c_adapter*     adap,
-                                u16                     addr,
-                                unsigned short          flags,
-                                char                    read_write,
-                                u8                      command,
-                                int                     size,
-                                union i2c_smbus_data*   data)
-{
-        struct smu_iface        *iface = i2c_get_adapdata(adap);
-        struct smu_i2c_cmd      cmd;
-        int                     rc = 0;
-        int                     read = (read_write == I2C_SMBUS_READ);
-
-        cmd.info.bus = iface->busid;
-        cmd.info.devaddr = (addr << 1) | (read ? 0x01 : 0x00);
-
-        /* Prepare datas & select mode */
-        switch (size) {
-        case I2C_SMBUS_QUICK:
-                cmd.info.type = SMU_I2C_TRANSFER_SIMPLE;
-                cmd.info.datalen = 0;
-                break;
-        case I2C_SMBUS_BYTE:
-                cmd.info.type = SMU_I2C_TRANSFER_SIMPLE;
-                cmd.info.datalen = 1;
-                if (!read)
-                        cmd.info.data[0] = data->byte;
-                break;
-        case I2C_SMBUS_BYTE_DATA:
-                cmd.info.type = SMU_I2C_TRANSFER_STDSUB;
-                cmd.info.datalen = 1;
-                cmd.info.sublen = 1;
-                cmd.info.subaddr[0] = command;
-                cmd.info.subaddr[1] = 0;
-                cmd.info.subaddr[2] = 0;
-                if (!read)
-                        cmd.info.data[0] = data->byte;
-                break;
-        case I2C_SMBUS_WORD_DATA:
-                cmd.info.type = SMU_I2C_TRANSFER_STDSUB;
-                cmd.info.datalen = 2;
-                cmd.info.sublen = 1;
-                cmd.info.subaddr[0] = command;
-                cmd.info.subaddr[1] = 0;
-                cmd.info.subaddr[2] = 0;
-                if (!read) {
-                        cmd.info.data[0] = data->byte & 0xff;
-                        cmd.info.data[1] = (data->byte >> 8) & 0xff;
-                }
-                break;
-        /* Note that these are broken vs. the expected smbus API where
-         * on reads, the lenght is actually returned from the function,
-         * but I think the current API makes no sense and I don't want
-         * any driver that I haven't verified for correctness to go
-         * anywhere near a pmac i2c bus anyway ...
-         */
-        case I2C_SMBUS_BLOCK_DATA:
-                cmd.info.type = SMU_I2C_TRANSFER_STDSUB;
-                cmd.info.datalen = data->block[0] + 1;
-                if (cmd.info.datalen > 6)
-                        return -EINVAL;
-                if (!read)
-                        memcpy(cmd.info.data, data->block, cmd.info.datalen);
-                cmd.info.sublen = 1;
-                cmd.info.subaddr[0] = command;
-                cmd.info.subaddr[1] = 0;
-                cmd.info.subaddr[2] = 0;
-                break;
-        case I2C_SMBUS_I2C_BLOCK_DATA:
-                cmd.info.type = SMU_I2C_TRANSFER_STDSUB;
-                cmd.info.datalen = data->block[0];
-                if (cmd.info.datalen > 7)
-                        return -EINVAL;
-                if (!read)
-                        memcpy(cmd.info.data, &data->block[1],
-                               cmd.info.datalen);
-                cmd.info.sublen = 1;
-                cmd.info.subaddr[0] = command;
-                cmd.info.subaddr[1] = 0;
-                cmd.info.subaddr[2] = 0;
-                break;
-
-        default:
-                return -EINVAL;
-        }
-
-        /* Turn a standardsub read into a combined mode access */
-        if (read_write == I2C_SMBUS_READ &&
-            cmd.info.type == SMU_I2C_TRANSFER_STDSUB)
-                cmd.info.type = SMU_I2C_TRANSFER_COMBINED;
-
-        /* Finish filling command and submit it */
-        cmd.done = smu_i2c_done;
-        cmd.misc = iface;
-        rc = smu_queue_i2c(&cmd);
-        if (rc < 0)
-                return rc;
-        wait_for_completion(&iface->complete);
-        rc = cmd.status;
-
-        if (!read || rc < 0)
-                return rc;
-
-        switch (size) {
-        case I2C_SMBUS_BYTE:
-        case I2C_SMBUS_BYTE_DATA:
-                data->byte = cmd.info.data[0];
-                break;
-        case I2C_SMBUS_WORD_DATA:
-                data->word = ((u16)cmd.info.data[1]) << 8;
-                data->word |= cmd.info.data[0];
-                break;
-        /* Note that these are broken vs. the expected smbus API where
-         * on reads, the lenght is actually returned from the function,
-         * but I think the current API makes no sense and I don't want
-         * any driver that I haven't verified for correctness to go
-         * anywhere near a pmac i2c bus anyway ...
-         */
-        case I2C_SMBUS_BLOCK_DATA:
-        case I2C_SMBUS_I2C_BLOCK_DATA:
-                memcpy(&data->block[0], cmd.info.data, cmd.info.datalen);
-                break;
-        }
-
-        return rc;
-}
-
-static u32
-smu_smbus_func(struct i2c_adapter * adapter)
-{
-        return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
-               I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
-               I2C_FUNC_SMBUS_BLOCK_DATA;
-}
-
-/* For now, we only handle combined mode (smbus) */
-static struct i2c_algorithm smu_algorithm = {
-        .smbus_xfer     = smu_smbus_xfer,
-        .functionality  = smu_smbus_func,
-};
-
-static int create_iface(struct device_node *np, struct device *dev)
-{
-        struct smu_iface* iface;
-        u32 *reg, busid;
-        int rc;
-
-        reg = (u32 *)get_property(np, "reg", NULL);
-        if (reg == NULL) {
-                printk(KERN_ERR "i2c-pmac-smu: can't find bus number !\n");
-                return -ENXIO;
-        }
-        busid = *reg;
-
-        iface = kzalloc(sizeof(struct smu_iface), GFP_KERNEL);
-        if (iface == NULL) {
-                printk(KERN_ERR "i2c-pmac-smu: can't allocate inteface !\n");
-                return -ENOMEM;
-        }
-        init_completion(&iface->complete);
-        iface->busid = busid;
-
-        dev_set_drvdata(dev, iface);
-
-        sprintf(iface->adapter.name, "smu-i2c-%02x", busid);
-        iface->adapter.algo = &smu_algorithm;
-        iface->adapter.algo_data = NULL;
-        iface->adapter.client_register = NULL;
-        iface->adapter.client_unregister = NULL;
-        i2c_set_adapdata(&iface->adapter, iface);
-        iface->adapter.dev.parent = dev;
-
-        rc = i2c_add_adapter(&iface->adapter);
-        if (rc) {
-                printk(KERN_ERR "i2c-pamc-smu.c: Adapter %s registration "
-                       "failed\n", iface->adapter.name);
-                i2c_set_adapdata(&iface->adapter, NULL);
-        }
-
-        if (probe) {
-                unsigned char addr;
-                printk("Probe: ");
-                for (addr = 0x00; addr <= 0x7f; addr++) {
-                        if (i2c_smbus_xfer(&iface->adapter,addr,
-                                           0,0,0,I2C_SMBUS_QUICK,NULL) >= 0)
-                                printk("%02x ", addr);
-                }
-                printk("\n");
-        }
-
-        printk(KERN_INFO "SMU i2c bus %x registered\n", busid);
-
-        return 0;
-}
-
-static int dispose_iface(struct device *dev)
-{
-        struct smu_iface *iface = dev_get_drvdata(dev);
-        int rc;
-
-        rc = i2c_del_adapter(&iface->adapter);
-        i2c_set_adapdata(&iface->adapter, NULL);
-        /* We aren't that prepared to deal with this... */
-        if (rc)
-                printk("i2c-pmac-smu.c: Failed to remove bus %s !\n",
-                       iface->adapter.name);
-        dev_set_drvdata(dev, NULL);
-        kfree(iface);
-
-        return 0;
-}
-
-
-static int create_iface_of_platform(struct of_device* dev,
-                                    const struct of_device_id *match)
-{
-        return create_iface(dev->node, &dev->dev);
-}
-
-
-static int dispose_iface_of_platform(struct of_device* dev)
-{
-        return dispose_iface(&dev->dev);
-}
-
-
-static struct of_device_id i2c_smu_match[] =
-{
-        {
-                .compatible     = "smu-i2c",
-        },
-        {},
-};
-static struct of_platform_driver i2c_smu_of_platform_driver =
-{
-        .name           = "i2c-smu",
-        .match_table    = i2c_smu_match,
-        .probe          = create_iface_of_platform,
-        .remove         = dispose_iface_of_platform
-};
-
-
-static int __init i2c_pmac_smu_init(void)
-{
-        of_register_driver(&i2c_smu_of_platform_driver);
-        return 0;
-}
-
-
-static void __exit i2c_pmac_smu_cleanup(void)
-{
-        of_unregister_driver(&i2c_smu_of_platform_driver);
-}
-
-module_init(i2c_pmac_smu_init);
-module_exit(i2c_pmac_smu_cleanup);
diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c
new file mode 100644
index 000000000000..df786eb55295
--- /dev/null
+++ b/drivers/i2c/busses/i2c-powermac.c
@@ -0,0 +1,290 @@
+/*
+    i2c Support for Apple SMU Controller
+
+    Copyright (c) 2005 Benjamin Herrenschmidt, IBM Corp.
+                       <benh@kernel.crashing.org>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/completion.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <asm/prom.h>
+#include <asm/pmac_low_i2c.h>
+
+MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");
+MODULE_DESCRIPTION("I2C driver for Apple PowerMac");
+MODULE_LICENSE("GPL");
+
+/*
+ * SMBUS-type transfer entrypoint
+ */
+static s32 i2c_powermac_smbus_xfer(     struct i2c_adapter*     adap,
+                                        u16                     addr,
+                                        unsigned short          flags,
+                                        char                    read_write,
+                                        u8                      command,
+                                        int                     size,
+                                        union i2c_smbus_data*   data)
+{
+        struct pmac_i2c_bus     *bus = i2c_get_adapdata(adap);
+        int                     rc = 0;
+        int                     read = (read_write == I2C_SMBUS_READ);
+        int                     addrdir = (addr << 1) | read;
+        u8                      local[2];
+
+        rc = pmac_i2c_open(bus, 0);
+        if (rc)
+                return rc;
+
+        switch (size) {
+        case I2C_SMBUS_QUICK:
+                rc = pmac_i2c_setmode(bus, pmac_i2c_mode_std);
+                if (rc)
+                        goto bail;
+                rc = pmac_i2c_xfer(bus, addrdir, 0, 0, NULL, 0);
+                break;
+        case I2C_SMBUS_BYTE:
+                rc = pmac_i2c_setmode(bus, pmac_i2c_mode_std);
+                if (rc)
+                        goto bail;
+                rc = pmac_i2c_xfer(bus, addrdir, 0, 0, &data->byte, 1);
+                break;
+        case I2C_SMBUS_BYTE_DATA:
+                rc = pmac_i2c_setmode(bus, read ?
+                                      pmac_i2c_mode_combined :
+                                      pmac_i2c_mode_stdsub);
+                if (rc)
+                        goto bail;
+                rc = pmac_i2c_xfer(bus, addrdir, 1, command, &data->byte, 1);
+                break;
+        case I2C_SMBUS_WORD_DATA:
+                rc = pmac_i2c_setmode(bus, read ?
+                                      pmac_i2c_mode_combined :
+                                      pmac_i2c_mode_stdsub);
+                if (rc)
+                        goto bail;
+                if (!read) {
+                        local[0] = data->word & 0xff;
+                        local[1] = (data->word >> 8) & 0xff;
+                }
+                rc = pmac_i2c_xfer(bus, addrdir, 1, command, local, 2);
+                if (rc == 0 && read) {
+                        data->word = ((u16)local[1]) << 8;
+                        data->word |= local[0];
+                }
+                break;
+
+        /* Note that these are broken vs. the expected smbus API where
+         * on reads, the lenght is actually returned from the function,
+         * but I think the current API makes no sense and I don't want
+         * any driver that I haven't verified for correctness to go
+         * anywhere near a pmac i2c bus anyway ...
+         *
+         * I'm also not completely sure what kind of phases to do between
+         * the actual command and the data (what I am _supposed_ to do that
+         * is). For now, I assume writes are a single stream and reads have
+         * a repeat start/addr phase (but not stop in between)
+         */
+        case I2C_SMBUS_BLOCK_DATA:
+                rc = pmac_i2c_setmode(bus, read ?
+                                      pmac_i2c_mode_combined :
+                                      pmac_i2c_mode_stdsub);
+                if (rc)
+                        goto bail;
+                rc = pmac_i2c_xfer(bus, addrdir, 1, command, data->block,
+                                   data->block[0] + 1);
+
+                break;
+        case I2C_SMBUS_I2C_BLOCK_DATA:
+                rc = pmac_i2c_setmode(bus, read ?
+                                      pmac_i2c_mode_combined :
+                                      pmac_i2c_mode_stdsub);
+                if (rc)
+                        goto bail;
+                rc = pmac_i2c_xfer(bus, addrdir, 1, command,
+                                   read ? data->block : &data->block[1],
+                                   data->block[0]);
+                break;
+
+        default:
+                rc = -EINVAL;
+        }
+ bail:
+        pmac_i2c_close(bus);
+        return rc;
+}
+
+/*
+ * Generic i2c master transfer entrypoint. This driver only support single
+ * messages (for "lame i2c" transfers). Anything else should use the smbus
+ * entry point
+ */
+static int i2c_powermac_master_xfer(    struct i2c_adapter *adap,
+                                        struct i2c_msg *msgs,
+                                        int num)
+{
+        struct pmac_i2c_bus     *bus = i2c_get_adapdata(adap);
+        int                     rc = 0;
+        int                     read;
+        int                     addrdir;
+
+        if (num != 1)
+                return -EINVAL;
+        if (msgs->flags & I2C_M_TEN)
+                return -EINVAL;
+        read = (msgs->flags & I2C_M_RD) != 0;
+        addrdir = (msgs->addr << 1) | read;
+        if (msgs->flags & I2C_M_REV_DIR_ADDR)
+                addrdir ^= 1;
+
+        rc = pmac_i2c_open(bus, 0);
+        if (rc)
+                return rc;
+        rc = pmac_i2c_setmode(bus, pmac_i2c_mode_std);
+        if (rc)
+                goto bail;
+        rc = pmac_i2c_xfer(bus, addrdir, 0, 0, msgs->buf, msgs->len);
+ bail:
+        pmac_i2c_close(bus);
+        return rc < 0 ? rc : msgs->len;
+}
+
+static u32 i2c_powermac_func(struct i2c_adapter * adapter)
+{
+        return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
+                I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
+                I2C_FUNC_SMBUS_BLOCK_DATA | I2C_FUNC_I2C;
+}
+
+/* For now, we only handle smbus */
+static struct i2c_algorithm i2c_powermac_algorithm = {
+        .smbus_xfer     = i2c_powermac_smbus_xfer,
+        .master_xfer    = i2c_powermac_master_xfer,
+        .functionality  = i2c_powermac_func,
+};
+
+
+static int i2c_powermac_remove(struct device *dev)
+{
+        struct i2c_adapter      *adapter = dev_get_drvdata(dev);
+        struct pmac_i2c_bus     *bus = i2c_get_adapdata(adapter);
+        int                     rc;
+
+        rc = i2c_del_adapter(adapter);
+        pmac_i2c_detach_adapter(bus, adapter);
+        i2c_set_adapdata(adapter, NULL);
+        /* We aren't that prepared to deal with this... */
+        if (rc)
+                printk("i2c-powermac.c: Failed to remove bus %s !\n",
+                       adapter->name);
+        dev_set_drvdata(dev, NULL);
+        kfree(adapter);
+
+        return 0;
+}
+
+
+static int i2c_powermac_probe(struct device *dev)
+{
+        struct pmac_i2c_bus *bus = dev->platform_data;
+        struct device_node *parent = NULL;
+        struct i2c_adapter *adapter;
+        char name[32], *basename;
+        int rc;
+
+        if (bus == NULL)
+                return -EINVAL;
+
+        /* Ok, now we need to make up a name for the interface that will
+         * match what we used to do in the past, that is basically the
+         * controller's parent device node for keywest. PMU didn't have a
+         * naming convention and SMU has a different one
+         */
+        switch(pmac_i2c_get_type(bus)) {
+        case pmac_i2c_bus_keywest:
+                parent = of_get_parent(pmac_i2c_get_controller(bus));
+                if (parent == NULL)
+                        return -EINVAL;
+                basename = parent->name;
+                break;
+        case pmac_i2c_bus_pmu:
+                basename = "pmu";
+                break;
+        case pmac_i2c_bus_smu:
+                /* This is not what we used to do but I'm fixing drivers at
+                 * the same time as this change
+                 */
+                basename = "smu";
+                break;
+        default:
+                return -EINVAL;
+        }
+        snprintf(name, 32, "%s %d", basename, pmac_i2c_get_channel(bus));
+        of_node_put(parent);
+
+        adapter = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
+        if (adapter == NULL) {
+                printk(KERN_ERR "i2c-powermac: can't allocate inteface !\n");
+                return -ENOMEM;
+        }
+        dev_set_drvdata(dev, adapter);
+        strcpy(adapter->name, name);
+        adapter->algo = &i2c_powermac_algorithm;
+        i2c_set_adapdata(adapter, bus);
+        adapter->dev.parent = dev;
+        pmac_i2c_attach_adapter(bus, adapter);
+        rc = i2c_add_adapter(adapter);
+        if (rc) {
+                printk(KERN_ERR "i2c-powermac: Adapter %s registration "
+                       "failed\n", name);
+                i2c_set_adapdata(adapter, NULL);
+                pmac_i2c_detach_adapter(bus, adapter);
+        }
+
+        printk(KERN_INFO "PowerMac i2c bus %s registered\n", name);
+        return rc;
+}
+
+
+static struct device_driver i2c_powermac_driver = {
+        .name = "i2c-powermac",
+        .bus = &platform_bus_type,
+        .probe = i2c_powermac_probe,
+        .remove = i2c_powermac_remove,
+};
+
+static int __init i2c_powermac_init(void)
+{
+        driver_register(&i2c_powermac_driver);
+        return 0;
+}
+
+
+static void __exit i2c_powermac_cleanup(void)
+{
+        driver_unregister(&i2c_powermac_driver);
+}
+
+module_init(i2c_powermac_init);
+module_exit(i2c_powermac_cleanup);
diff --git a/drivers/i2c/chips/tps65010.c b/drivers/i2c/chips/tps65010.c
index e70b3db69edd..1af3dfbb8086 100644
--- a/drivers/i2c/chips/tps65010.c
+++ b/drivers/i2c/chips/tps65010.c
@@ -494,6 +494,7 @@ tps65010_probe(struct i2c_adapter *bus, int address, int kind)
 {
         struct tps65010         *tps;
         int                     status;
+        unsigned long           irqflags;
 
         if (the_tps) {
                 dev_dbg(&bus->dev, "only one %s for now\n", DRIVER_NAME);
@@ -520,13 +521,14 @@ tps65010_probe(struct i2c_adapter *bus, int address, int kind)
         }
 
 #ifdef  CONFIG_ARM
+        irqflags = SA_SAMPLE_RANDOM | SA_TRIGGER_LOW;
         if (machine_is_omap_h2()) {
                 tps->model = TPS65010;
                 omap_cfg_reg(W4_GPIO58);
                 tps->irq = OMAP_GPIO_IRQ(58);
                 omap_request_gpio(58);
                 omap_set_gpio_direction(58, 1);
-                set_irq_type(tps->irq, IRQT_FALLING);
+                irqflags |= SA_TRIGGER_FALLING;
         }
         if (machine_is_omap_osk()) {
                 tps->model = TPS65010;
@@ -534,7 +536,7 @@ tps65010_probe(struct i2c_adapter *bus, int address, int kind)
                 tps->irq = OMAP_GPIO_IRQ(OMAP_MPUIO(1));
                 omap_request_gpio(OMAP_MPUIO(1));
                 omap_set_gpio_direction(OMAP_MPUIO(1), 1);
-                set_irq_type(tps->irq, IRQT_FALLING);
+                irqflags |= SA_TRIGGER_FALLING;
         }
         if (machine_is_omap_h3()) {
                 tps->model = TPS65013;
@@ -542,13 +544,12 @@ tps65010_probe(struct i2c_adapter *bus, int address, int kind)
                 // FIXME set up this board's IRQ ...
         }
 #else
-#define set_irq_type(num,trigger)       do{}while(0)
+        irqflags = SA_SAMPLE_RANDOM;
 #endif
 
         if (tps->irq > 0) {
-                set_irq_type(tps->irq, IRQT_LOW);
                 status = request_irq(tps->irq, tps65010_irq,
-                        SA_SAMPLE_RANDOM, DRIVER_NAME, tps);
+                        irqflags, DRIVER_NAME, tps);
                 if (status < 0) {
                         dev_dbg(&tps->client.dev, "can't get IRQ %d, err %d\n",
                                         tps->irq, status);
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index d31117eb95aa..e4d55ad32d2f 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1332,8 +1332,6 @@ static ide_startstop_t cdrom_start_read (ide_drive_t *drive, unsigned int block)
         if (cdrom_read_from_buffer(drive))
                 return ide_stopped;
 
-        blk_attempt_remerge(drive->queue, rq);
-
         /* Clear the local sector buffer. */
         info->nsectors_buffered = 0;
 
@@ -1874,14 +1872,6 @@ static ide_startstop_t cdrom_start_write(ide_drive_t *drive, struct request *rq)
                 return ide_stopped;
         }
 
-        /*
-         * for dvd-ram and such media, it's a really big deal to get
-         * big writes all the time. so scour the queue and attempt to
-         * remerge requests, often the plugging will not have had time
-         * to do this properly
-         */
-        blk_attempt_remerge(drive->queue, rq);
-
         info->nsectors_buffered = 0;
 
         /* use dma, if possible. we don't need to check more, since we
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 4b441720b6ba..cab362ea0336 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -1130,6 +1130,17 @@ static int idedisk_release(struct inode *inode, struct file *filp)
         return 0;
 }
 
+static int idedisk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct ide_disk_obj *idkp = ide_disk_g(bdev->bd_disk);
+        ide_drive_t *drive = idkp->drive;
+
+        geo->heads = drive->bios_head;
+        geo->sectors = drive->bios_sect;
+        geo->cylinders = (u16)drive->bios_cyl; /* truncate */
+        return 0;
+}
+
 static int idedisk_ioctl(struct inode *inode, struct file *file,
                         unsigned int cmd, unsigned long arg)
 {
@@ -1164,6 +1175,7 @@ static struct block_device_operations idedisk_ops = {
         .open           = idedisk_open,
         .release        = idedisk_release,
         .ioctl          = idedisk_ioctl,
+        .getgeo         = idedisk_getgeo,
         .media_changed  = idedisk_media_changed,
         .revalidate_disk= idedisk_revalidate_disk
 };
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index fba3fffc2d66..5945f551aaaa 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -2031,6 +2031,17 @@ static int idefloppy_release(struct inode *inode, struct file *filp)
         return 0;
 }
 
+static int idefloppy_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct ide_floppy_obj *floppy = ide_floppy_g(bdev->bd_disk);
+        ide_drive_t *drive = floppy->drive;
+
+        geo->heads = drive->bios_head;
+        geo->sectors = drive->bios_sect;
+        geo->cylinders = (u16)drive->bios_cyl; /* truncate */
+        return 0;
+}
+
 static int idefloppy_ioctl(struct inode *inode, struct file *file,
                         unsigned int cmd, unsigned long arg)
 {
@@ -2120,6 +2131,7 @@ static struct block_device_operations idefloppy_ops = {
         .open           = idefloppy_open,
         .release        = idefloppy_release,
         .ioctl          = idefloppy_ioctl,
+        .getgeo         = idefloppy_getgeo,
         .media_changed  = idefloppy_media_changed,
         .revalidate_disk= idefloppy_revalidate_disk
 };
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index b5dc6df8e67d..dea2d4dcc698 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -55,9 +55,22 @@
 #include <asm/io.h>
 #include <asm/bitops.h>
 
+void ide_softirq_done(struct request *rq)
+{
+        request_queue_t *q = rq->q;
+
+        add_disk_randomness(rq->rq_disk);
+        end_that_request_chunk(rq, rq->errors, rq->data_len);
+
+        spin_lock_irq(q->queue_lock);
+        end_that_request_last(rq, rq->errors);
+        spin_unlock_irq(q->queue_lock);
+}
+
 int __ide_end_request(ide_drive_t *drive, struct request *rq, int uptodate,
                       int nr_sectors)
 {
+        unsigned int nbytes;
         int ret = 1;
 
         BUG_ON(!(rq->flags & REQ_STARTED));
@@ -81,17 +94,28 @@ int __ide_end_request(ide_drive_t *drive, struct request *rq, int uptodate,
                 HWGROUP(drive)->hwif->ide_dma_on(drive);
         }
 
-        if (!end_that_request_first(rq, uptodate, nr_sectors)) {
-                add_disk_randomness(rq->rq_disk);
-
-                if (blk_rq_tagged(rq))
-                        blk_queue_end_tag(drive->queue, rq);
-
+        /*
+         * For partial completions (or non fs/pc requests), use the regular
+         * direct completion path.
+         */
+        nbytes = nr_sectors << 9;
+        if (rq_all_done(rq, nbytes)) {
+                rq->errors = uptodate;
+                rq->data_len = nbytes;
                 blkdev_dequeue_request(rq);
                 HWGROUP(drive)->rq = NULL;
-                end_that_request_last(rq, uptodate);
+                blk_complete_request(rq);
                 ret = 0;
+        } else {
+                if (!end_that_request_first(rq, uptodate, nr_sectors)) {
+                        add_disk_randomness(rq->rq_disk);
+                        blkdev_dequeue_request(rq);
+                        HWGROUP(drive)->rq = NULL;
+                        end_that_request_last(rq, uptodate);
+                        ret = 0;
+                }
         }
+
         return ret;
 }
 EXPORT_SYMBOL(__ide_end_request);
@@ -113,6 +137,10 @@ int ide_end_request (ide_drive_t *drive, int uptodate, int nr_sectors)
         unsigned long flags;
         int ret = 1;
 
+        /*
+         * room for locking improvements here, the calls below don't
+         * need the queue lock held at all
+         */
         spin_lock_irqsave(&ide_lock, flags);
         rq = HWGROUP(drive)->rq;
 
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 02167a5b751d..1ddaa71a8f45 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1011,6 +1011,8 @@ static int ide_init_queue(ide_drive_t *drive)
         blk_queue_max_hw_segments(q, max_sg_entries);
         blk_queue_max_phys_segments(q, max_sg_entries);
 
+        blk_queue_softirq_done(q, ide_softirq_done);
+
         /* assign drive queue */
         drive->queue = q;
 
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 4b524f6b3ecd..b069b13b75a7 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1278,19 +1278,6 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device
         up(&ide_setting_sem);
 
         switch (cmd) {
-                case HDIO_GETGEO:
-                {
-                        struct hd_geometry geom;
-                        if (!p || (drive->media != ide_disk && drive->media != ide_floppy)) return -EINVAL;
-                        geom.heads = drive->bios_head;
-                        geom.sectors = drive->bios_sect;
-                        geom.cylinders = (u16)drive->bios_cyl; /* truncate */
-                        geom.start = get_start_sect(bdev);
-                        if (copy_to_user(p, &geom, sizeof(struct hd_geometry)))
-                                return -EFAULT;
-                        return 0;
-                }
-
                 case HDIO_OBSOLETE_IDENTITY:
                 case HDIO_GET_IDENTITY:
                         if (bdev != bdev->bd_contains)
diff --git a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
index 242029c9c0ca..6439dec66881 100644
--- a/drivers/ide/legacy/hd.c
+++ b/drivers/ide/legacy/hd.c
@@ -658,22 +658,14 @@ static void do_hd_request (request_queue_t * q)
         enable_irq(HD_IRQ);
 }
 
-static int hd_ioctl(struct inode * inode, struct file * file,
-        unsigned int cmd, unsigned long arg)
+static int hd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct hd_i_struct *disk = inode->i_bdev->bd_disk->private_data;
-        struct hd_geometry __user *loc = (struct hd_geometry __user *) arg;
-        struct hd_geometry g; 
-
-        if (cmd != HDIO_GETGEO)
-                return -EINVAL;
-        if (!loc)
-                return -EINVAL;
-        g.heads = disk->head;
-        g.sectors = disk->sect;
-        g.cylinders = disk->cyl;
-        g.start = get_start_sect(inode->i_bdev);
-        return copy_to_user(loc, &g, sizeof g) ? -EFAULT : 0; 
+        struct hd_i_struct *disk = bdev->bd_disk->private_data;
+
+        geo->heads = disk->head;
+        geo->sectors = disk->sect;
+        geo->cylinders = disk->cyl;
+        return 0;
 }
 
 /*
@@ -695,7 +687,7 @@ static irqreturn_t hd_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 }
 
 static struct block_device_operations hd_fops = {
-        .ioctl =        hd_ioctl,
+        .getgeo =       hd_getgeo,
 };
 
 /*
diff --git a/drivers/ide/pci/serverworks.c b/drivers/ide/pci/serverworks.c
index ff2e217a8c84..0d3073f4eab4 100644
--- a/drivers/ide/pci/serverworks.c
+++ b/drivers/ide/pci/serverworks.c
@@ -69,7 +69,7 @@ static int check_in_drive_lists (ide_drive_t *drive, const char **list)
 static u8 svwks_ratemask (ide_drive_t *drive)
 {
         struct pci_dev *dev     = HWIF(drive)->pci_dev;
-        u8 mode;
+        u8 mode = 0;
 
         if (!svwks_revision)
                 pci_read_config_byte(dev, PCI_REVISION_ID, &svwks_revision);
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 16b28357885b..5013b1285e22 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1271,7 +1271,7 @@ static int
 pmac_ide_setup_device(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif)
 {
         struct device_node *np = pmif->node;
-        int *bidp, i;
+        int *bidp;
 
         pmif->cable_80 = 0;
         pmif->broken_dma = pmif->broken_dma_warn = 0;
@@ -1430,7 +1430,7 @@ pmac_ide_macio_attach(struct macio_dev *mdev, const struct of_device_id *match)
         pmif = &pmac_ide[i];
         hwif = &ide_hwifs[i];
 
-        if (mdev->ofdev.node->n_addrs == 0) {
+        if (macio_resource_count(mdev) == 0) {
                 printk(KERN_WARNING "ide%d: no address for %s\n",
                        i, mdev->ofdev.node->full_name);
                 return -ENXIO;
@@ -1686,7 +1686,7 @@ pmac_ide_probe(void)
 #else
         macio_register_driver(&pmac_ide_macio_driver);
         pci_register_driver(&pmac_ide_pci_driver);
-#endif  
+#endif
 }
 
 #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index 02110e00d145..3a611fe5497e 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -308,10 +308,11 @@ static int cm_alloc_id(struct cm_id_private *cm_id_priv)
 {
         unsigned long flags;
         int ret;
+        static int next_id;
 
         do {
                 spin_lock_irqsave(&cm.lock, flags);
-                ret = idr_get_new_above(&cm.local_id_table, cm_id_priv, 1,
+                ret = idr_get_new_above(&cm.local_id_table, cm_id_priv, next_id++,
                                         (__force int *) &cm_id_priv->id.local_id);
                 spin_unlock_irqrestore(&cm.lock, flags);
         } while( (ret == -EAGAIN) && idr_pre_get(&cm.local_id_table, GFP_KERNEL) );
@@ -684,6 +685,13 @@ retest:
                 cm_reject_sidr_req(cm_id_priv, IB_SIDR_REJECT);
                 break;
         case IB_CM_REQ_SENT:
+                ib_cancel_mad(cm_id_priv->av.port->mad_agent, cm_id_priv->msg);
+                spin_unlock_irqrestore(&cm_id_priv->lock, flags);
+                ib_send_cm_rej(cm_id, IB_CM_REJ_TIMEOUT,
+                               &cm_id_priv->av.port->cm_dev->ca_guid,
+                               sizeof cm_id_priv->av.port->cm_dev->ca_guid,
+                               NULL, 0);
+                break;
         case IB_CM_MRA_REQ_RCVD:
         case IB_CM_REP_SENT:
         case IB_CM_MRA_REP_RCVD:
@@ -694,10 +702,8 @@ retest:
         case IB_CM_REP_RCVD:
         case IB_CM_MRA_REP_SENT:
                 spin_unlock_irqrestore(&cm_id_priv->lock, flags);
-                ib_send_cm_rej(cm_id, IB_CM_REJ_TIMEOUT,
-                               &cm_id_priv->av.port->cm_dev->ca_guid,
-                               sizeof cm_id_priv->av.port->cm_dev->ca_guid,
-                               NULL, 0);
+                ib_send_cm_rej(cm_id, IB_CM_REJ_CONSUMER_DEFINED,
+                               NULL, 0, NULL, 0);
                 break;
         case IB_CM_ESTABLISHED:
                 spin_unlock_irqrestore(&cm_id_priv->lock, flags);
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
index eb7f52537ccc..c908de8db5a9 100644
--- a/drivers/infiniband/core/user_mad.c
+++ b/drivers/infiniband/core/user_mad.c
@@ -197,8 +197,8 @@ static void send_handler(struct ib_mad_agent *agent,
                 memcpy(timeout->mad.data, packet->mad.data,
                        sizeof (struct ib_mad_hdr));
 
-                if (!queue_packet(file, agent, timeout))
-                                return;
+                if (queue_packet(file, agent, timeout))
+                        kfree(timeout);
         }
 out:
         kfree(packet);
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index a57d021d435a..a02c5a05c984 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -489,6 +489,7 @@ err_idr:
 
 err_unreg:
         ib_dereg_mr(mr);
+        atomic_dec(&pd->usecnt);
 
 err_up:
         up(&ib_uverbs_idr_mutex);
@@ -593,13 +594,18 @@ ssize_t ib_uverbs_create_cq(struct ib_uverbs_file *file,
         if (cmd.comp_vector >= file->device->num_comp_vectors)
                 return -EINVAL;
 
-        if (cmd.comp_channel >= 0)
-                ev_file = ib_uverbs_lookup_comp_file(cmd.comp_channel);
-
         uobj = kmalloc(sizeof *uobj, GFP_KERNEL);
         if (!uobj)
                 return -ENOMEM;
 
+        if (cmd.comp_channel >= 0) {
+                ev_file = ib_uverbs_lookup_comp_file(cmd.comp_channel);
+                if (!ev_file) {
+                        ret = -EINVAL;
+                        goto err;
+                }
+        }
+
         uobj->uobject.user_handle   = cmd.user_handle;
         uobj->uobject.context       = file->ucontext;
         uobj->uverbs_file           = file;
@@ -663,6 +669,8 @@ err_up:
         ib_destroy_cq(cq);
 
 err:
+        if (ev_file)
+                ib_uverbs_release_ucq(file, ev_file, uobj);
         kfree(uobj);
         return ret;
 }
@@ -935,6 +943,11 @@ err_idr:
 
 err_destroy:
         ib_destroy_qp(qp);
+        atomic_dec(&pd->usecnt);
+        atomic_dec(&attr.send_cq->usecnt);
+        atomic_dec(&attr.recv_cq->usecnt);
+        if (attr.srq)
+                atomic_dec(&attr.srq->usecnt);
 
 err_up:
         up(&ib_uverbs_idr_mutex);
@@ -1448,6 +1461,7 @@ ssize_t ib_uverbs_create_ah(struct ib_uverbs_file *file,
         attr.sl                = cmd.attr.sl;
         attr.src_path_bits     = cmd.attr.src_path_bits;
         attr.static_rate       = cmd.attr.static_rate;
+        attr.ah_flags          = cmd.attr.is_global ? IB_AH_GRH : 0;
         attr.port_num          = cmd.attr.port_num;
         attr.grh.flow_label    = cmd.attr.grh.flow_label;
         attr.grh.sgid_index    = cmd.attr.grh.sgid_index;
@@ -1729,6 +1743,7 @@ err_idr:
 
 err_destroy:
         ib_destroy_srq(srq);
+        atomic_dec(&pd->usecnt);
 
 err_up:
         up(&ib_uverbs_idr_mutex);
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 4c15e112736c..c857361be449 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -107,9 +107,9 @@ struct ib_ah *ib_create_ah_from_wc(struct ib_pd *pd, struct ib_wc *wc,
 
         if (wc->wc_flags & IB_WC_GRH) {
                 ah_attr.ah_flags = IB_AH_GRH;
-                ah_attr.grh.dgid = grh->dgid;
+                ah_attr.grh.dgid = grh->sgid;
 
-                ret = ib_find_cached_gid(pd->device, &grh->sgid, &port_num,
+                ret = ib_find_cached_gid(pd->device, &grh->dgid, &port_num,
                                          &gid_index);
                 if (ret)
                         return ERR_PTR(ret);
diff --git a/drivers/infiniband/hw/mthca/mthca_cmd.c b/drivers/infiniband/hw/mthca/mthca_cmd.c
index 9ed34587fc5c..22ac72bc20c3 100644
--- a/drivers/infiniband/hw/mthca/mthca_cmd.c
+++ b/drivers/infiniband/hw/mthca/mthca_cmd.c
@@ -937,10 +937,6 @@ int mthca_QUERY_DEV_LIM(struct mthca_dev *dev,
         if (err)
                 goto out;
 
-        MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_SRQ_SZ_OFFSET);
-        dev_lim->max_srq_sz = (1 << field) - 1;
-        MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_QP_SZ_OFFSET);
-        dev_lim->max_qp_sz = (1 << field) - 1;
         MTHCA_GET(field, outbox, QUERY_DEV_LIM_RSVD_QP_OFFSET);
         dev_lim->reserved_qps = 1 << (field & 0xf);
         MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_QP_OFFSET);
@@ -1056,6 +1052,10 @@ int mthca_QUERY_DEV_LIM(struct mthca_dev *dev,
         mthca_dbg(dev, "Flags: %08x\n", dev_lim->flags);
 
         if (mthca_is_memfree(dev)) {
+                MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_SRQ_SZ_OFFSET);
+                dev_lim->max_srq_sz = 1 << field;
+                MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_QP_SZ_OFFSET);
+                dev_lim->max_qp_sz = 1 << field;
                 MTHCA_GET(field, outbox, QUERY_DEV_LIM_RSZ_SRQ_OFFSET);
                 dev_lim->hca.arbel.resize_srq = field & 1;
                 MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_SG_RQ_OFFSET);
@@ -1087,6 +1087,10 @@ int mthca_QUERY_DEV_LIM(struct mthca_dev *dev,
                 mthca_dbg(dev, "Max ICM size %lld MB\n",
                           (unsigned long long) dev_lim->hca.arbel.max_icm_sz >> 20);
         } else {
+                MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_SRQ_SZ_OFFSET);
+                dev_lim->max_srq_sz = (1 << field) - 1;
+                MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_QP_SZ_OFFSET);
+                dev_lim->max_qp_sz = (1 << field) - 1;
                 MTHCA_GET(field, outbox, QUERY_DEV_LIM_MAX_AV_OFFSET);
                 dev_lim->hca.tavor.max_avs = 1 << (field & 0x3f);
                 dev_lim->mpt_entry_sz = MTHCA_MPT_ENTRY_SIZE;
diff --git a/drivers/infiniband/hw/mthca/mthca_cq.c b/drivers/infiniband/hw/mthca/mthca_cq.c
index 4a8adcef2079..96f1a86bf049 100644
--- a/drivers/infiniband/hw/mthca/mthca_cq.c
+++ b/drivers/infiniband/hw/mthca/mthca_cq.c
@@ -128,12 +128,12 @@ struct mthca_err_cqe {
         __be32 my_qpn;
         u32    reserved1[3];
         u8     syndrome;
-        u8     reserved2;
+        u8     vendor_err;
         __be16 db_cnt;
-        u32    reserved3;
+        u32    reserved2;
         __be32 wqe;
         u8     opcode;
-        u8     reserved4[2];
+        u8     reserved3[2];
         u8     owner;
 };
 
@@ -253,6 +253,15 @@ void mthca_cq_event(struct mthca_dev *dev, u32 cqn,
                 wake_up(&cq->wait);
 }
 
+static inline int is_recv_cqe(struct mthca_cqe *cqe)
+{
+        if ((cqe->opcode & MTHCA_ERROR_CQE_OPCODE_MASK) ==
+            MTHCA_ERROR_CQE_OPCODE_MASK)
+                return !(cqe->opcode & 0x01);
+        else
+                return !(cqe->is_send & 0x80);
+}
+
 void mthca_cq_clean(struct mthca_dev *dev, u32 cqn, u32 qpn,
                     struct mthca_srq *srq)
 {
@@ -296,7 +305,7 @@ void mthca_cq_clean(struct mthca_dev *dev, u32 cqn, u32 qpn,
         while ((int) --prod_index - (int) cq->cons_index >= 0) {
                 cqe = get_cqe(cq, prod_index & cq->ibcq.cqe);
                 if (cqe->my_qpn == cpu_to_be32(qpn)) {
-                        if (srq)
+                        if (srq && is_recv_cqe(cqe))
                                 mthca_free_srq_wqe(srq, be32_to_cpu(cqe->wqe));
                         ++nfreed;
                 } else if (nfreed)
@@ -333,8 +342,8 @@ static int handle_error_cqe(struct mthca_dev *dev, struct mthca_cq *cq,
         }
 
         /*
-         * For completions in error, only work request ID, status (and
-         * freed resource count for RD) have to be set.
+         * For completions in error, only work request ID, status, vendor error
+         * (and freed resource count for RD) have to be set.
          */
         switch (cqe->syndrome) {
         case SYNDROME_LOCAL_LENGTH_ERR:
@@ -396,6 +405,8 @@ static int handle_error_cqe(struct mthca_dev *dev, struct mthca_cq *cq,
                 break;
         }
 
+        entry->vendor_err = cqe->vendor_err;
+
         /*
          * Mem-free HCAs always generate one CQE per WQE, even in the
          * error case, so we don't have to check the doorbell count, etc.
diff --git a/drivers/infiniband/hw/mthca/mthca_dev.h b/drivers/infiniband/hw/mthca/mthca_dev.h
index 497ff794ef6a..795b379260bf 100644
--- a/drivers/infiniband/hw/mthca/mthca_dev.h
+++ b/drivers/infiniband/hw/mthca/mthca_dev.h
@@ -43,6 +43,7 @@
 #include <linux/kernel.h>
 #include <linux/pci.h>
 #include <linux/dma-mapping.h>
+#include <linux/timer.h>
 #include <asm/semaphore.h>
 
 #include "mthca_provider.h"
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c
index 34d68e5a72d8..e8a948f087c0 100644
--- a/drivers/infiniband/hw/mthca/mthca_eq.c
+++ b/drivers/infiniband/hw/mthca/mthca_eq.c
@@ -484,8 +484,7 @@ static int __devinit mthca_create_eq(struct mthca_dev *dev,
                                      u8 intr,
                                      struct mthca_eq *eq)
 {
-        int npages = (nent * MTHCA_EQ_ENTRY_SIZE + PAGE_SIZE - 1) /
-                PAGE_SIZE;
+        int npages;
         u64 *dma_list = NULL;
         dma_addr_t t;
         struct mthca_mailbox *mailbox;
@@ -496,6 +495,7 @@ static int __devinit mthca_create_eq(struct mthca_dev *dev,
 
         eq->dev  = dev;
         eq->nent = roundup_pow_of_two(max(nent, 2));
+        npages = ALIGN(eq->nent * MTHCA_EQ_ENTRY_SIZE, PAGE_SIZE) / PAGE_SIZE;
 
         eq->page_list = kmalloc(npages * sizeof *eq->page_list,
                                 GFP_KERNEL);
diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c
index 6f94b25f3acd..8b00d9a0f6f4 100644
--- a/drivers/infiniband/hw/mthca/mthca_main.c
+++ b/drivers/infiniband/hw/mthca/mthca_main.c
@@ -261,6 +261,10 @@ static int __devinit mthca_init_tavor(struct mthca_dev *mdev)
         }
 
         err = mthca_dev_lim(mdev, &dev_lim);
+        if (err) {
+                mthca_err(mdev, "QUERY_DEV_LIM command failed, aborting.\n");
+                goto err_disable;
+        }
 
         profile = default_profile;
         profile.num_uar   = dev_lim.uar_size / PAGE_SIZE;
diff --git a/drivers/infiniband/hw/mthca/mthca_mcg.c b/drivers/infiniband/hw/mthca/mthca_mcg.c
index 2fc449da418d..77bc6c746f43 100644
--- a/drivers/infiniband/hw/mthca/mthca_mcg.c
+++ b/drivers/infiniband/hw/mthca/mthca_mcg.c
@@ -111,7 +111,8 @@ static int find_mgm(struct mthca_dev *dev,
                         goto out;
                 if (status) {
                         mthca_err(dev, "READ_MGM returned status %02x\n", status);
-                        return -EINVAL;
+                        err = -EINVAL;
+                        goto out;
                 }
 
                 if (!memcmp(mgm->gid, zero_gid, 16)) {
@@ -126,7 +127,7 @@ static int find_mgm(struct mthca_dev *dev,
                         goto out;
 
                 *prev = *index;
-                *index = be32_to_cpu(mgm->next_gid_index) >> 5;
+                *index = be32_to_cpu(mgm->next_gid_index) >> 6;
         } while (*index);
 
         *index = -1;
@@ -153,8 +154,10 @@ int mthca_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                 return PTR_ERR(mailbox);
         mgm = mailbox->buf;
 
-        if (down_interruptible(&dev->mcg_table.sem))
-                return -EINTR;
+        if (down_interruptible(&dev->mcg_table.sem)) {
+                err = -EINTR;
+                goto err_sem;
+        }
 
         err = find_mgm(dev, gid->raw, mailbox, &hash, &prev, &index);
         if (err)
@@ -181,9 +184,8 @@ int mthca_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                         err = -EINVAL;
                         goto out;
                 }
-
+                memset(mgm, 0, sizeof *mgm);
                 memcpy(mgm->gid, gid->raw, 16);
-                mgm->next_gid_index = 0;
         }
 
         for (i = 0; i < MTHCA_QP_PER_MGM; ++i)
@@ -209,6 +211,7 @@ int mthca_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
         if (status) {
                 mthca_err(dev, "WRITE_MGM returned status %02x\n", status);
                 err = -EINVAL;
+                goto out;
         }
 
         if (!link)
@@ -223,7 +226,7 @@ int mthca_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                 goto out;
         }
 
-        mgm->next_gid_index = cpu_to_be32(index << 5);
+        mgm->next_gid_index = cpu_to_be32(index << 6);
 
         err = mthca_WRITE_MGM(dev, prev, mailbox, &status);
         if (err)
@@ -234,7 +237,12 @@ int mthca_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
         }
 
  out:
+        if (err && link && index != -1) {
+                BUG_ON(index < dev->limits.num_mgms);
+                mthca_free(&dev->mcg_table.alloc, index);
+        }
         up(&dev->mcg_table.sem);
+ err_sem:
         mthca_free_mailbox(dev, mailbox);
         return err;
 }
@@ -255,8 +263,10 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                 return PTR_ERR(mailbox);
         mgm = mailbox->buf;
 
-        if (down_interruptible(&dev->mcg_table.sem))
-                return -EINTR;
+        if (down_interruptible(&dev->mcg_table.sem)) {
+                err = -EINTR;
+                goto err_sem;
+        }
 
         err = find_mgm(dev, gid->raw, mailbox, &hash, &prev, &index);
         if (err)
@@ -305,13 +315,11 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
         if (i != 1)
                 goto out;
 
-        goto out;
-
         if (prev == -1) {
                 /* Remove entry from MGM */
-                if (be32_to_cpu(mgm->next_gid_index) >> 5) {
-                        err = mthca_READ_MGM(dev,
-                                             be32_to_cpu(mgm->next_gid_index) >> 5,
+                int amgm_index_to_free = be32_to_cpu(mgm->next_gid_index) >> 6;
+                if (amgm_index_to_free) {
+                        err = mthca_READ_MGM(dev, amgm_index_to_free,
                                              mailbox, &status);
                         if (err)
                                 goto out;
@@ -332,9 +340,13 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                         err = -EINVAL;
                         goto out;
                 }
+                if (amgm_index_to_free) {
+                        BUG_ON(amgm_index_to_free < dev->limits.num_mgms);
+                        mthca_free(&dev->mcg_table.alloc, amgm_index_to_free);
+                }
         } else {
                 /* Remove entry from AMGM */
-                index = be32_to_cpu(mgm->next_gid_index) >> 5;
+                int curr_next_index = be32_to_cpu(mgm->next_gid_index) >> 6;
                 err = mthca_READ_MGM(dev, prev, mailbox, &status);
                 if (err)
                         goto out;
@@ -344,7 +356,7 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                         goto out;
                 }
 
-                mgm->next_gid_index = cpu_to_be32(index << 5);
+                mgm->next_gid_index = cpu_to_be32(curr_next_index << 6);
 
                 err = mthca_WRITE_MGM(dev, prev, mailbox, &status);
                 if (err)
@@ -354,10 +366,13 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
                         err = -EINVAL;
                         goto out;
                 }
+                BUG_ON(index < dev->limits.num_mgms);
+                mthca_free(&dev->mcg_table.alloc, index);
         }
 
  out:
         up(&dev->mcg_table.sem);
+ err_sem:
         mthca_free_mailbox(dev, mailbox);
         return err;
 }
@@ -365,11 +380,12 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
 int __devinit mthca_init_mcg_table(struct mthca_dev *dev)
 {
         int err;
+        int table_size = dev->limits.num_mgms + dev->limits.num_amgms;
 
         err = mthca_alloc_init(&dev->mcg_table.alloc,
-                               dev->limits.num_amgms,
-                               dev->limits.num_amgms - 1,
-                               0);
+                               table_size,
+                               table_size - 1,
+                               dev->limits.num_mgms);
         if (err)
                 return err;
 
diff --git a/drivers/infiniband/hw/mthca/mthca_memfree.c b/drivers/infiniband/hw/mthca/mthca_memfree.c
index d72fe95cba08..9fb985a016e9 100644
--- a/drivers/infiniband/hw/mthca/mthca_memfree.c
+++ b/drivers/infiniband/hw/mthca/mthca_memfree.c
@@ -233,7 +233,7 @@ void *mthca_table_find(struct mthca_icm_table *table, int obj)
                 for (i = 0; i < chunk->npages; ++i) {
                         if (chunk->mem[i].length >= offset) {
                                 page = chunk->mem[i].page;
-                                break;
+                                goto out;
                         }
                         offset -= chunk->mem[i].length;
                 }
@@ -485,6 +485,8 @@ void mthca_cleanup_user_db_tab(struct mthca_dev *dev, struct mthca_uar *uar,
                         put_page(db_tab->page[i].mem.page);
                 }
         }
+
+        kfree(db_tab);
 }
 
 int mthca_alloc_db(struct mthca_dev *dev, enum mthca_db_type type,
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 7450550db736..564b6d51c394 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -383,12 +383,10 @@ static const struct {
                                 [UC]  = (IB_QP_CUR_STATE             |
                                          IB_QP_ALT_PATH              |
                                          IB_QP_ACCESS_FLAGS          |
-                                         IB_QP_PKEY_INDEX            |
                                          IB_QP_PATH_MIG_STATE),
                                 [RC]  = (IB_QP_CUR_STATE             |
                                          IB_QP_ALT_PATH              |
                                          IB_QP_ACCESS_FLAGS          |
-                                         IB_QP_PKEY_INDEX            |
                                          IB_QP_MIN_RNR_TIMER         |
                                          IB_QP_PATH_MIG_STATE),
                                 [MLX] = (IB_QP_CUR_STATE             |
@@ -476,9 +474,8 @@ static const struct {
                         .opt_param = {
                                 [UD]  = (IB_QP_CUR_STATE             |
                                          IB_QP_QKEY),
-                                [UC]  = IB_QP_CUR_STATE,
-                                [RC]  = (IB_QP_CUR_STATE             |
-                                         IB_QP_MIN_RNR_TIMER),
+                                [UC]  = (IB_QP_CUR_STATE             |
+                                         IB_QP_ACCESS_FLAGS),
                                 [MLX] = (IB_QP_CUR_STATE             |
                                          IB_QP_QKEY),
                         }
@@ -522,6 +519,55 @@ static void init_port(struct mthca_dev *dev, int port)
                 mthca_warn(dev, "INIT_IB returned status %02x.\n", status);
 }
 
+static __be32 get_hw_access_flags(struct mthca_qp *qp, struct ib_qp_attr *attr,
+                                  int attr_mask)
+{
+        u8 dest_rd_atomic;
+        u32 access_flags;
+        u32 hw_access_flags = 0;
+
+        if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC)
+                dest_rd_atomic = attr->max_dest_rd_atomic;
+        else
+                dest_rd_atomic = qp->resp_depth;
+
+        if (attr_mask & IB_QP_ACCESS_FLAGS)
+                access_flags = attr->qp_access_flags;
+        else
+                access_flags = qp->atomic_rd_en;
+
+        if (!dest_rd_atomic)
+                access_flags &= IB_ACCESS_REMOTE_WRITE;
+
+        if (access_flags & IB_ACCESS_REMOTE_READ)
+                hw_access_flags |= MTHCA_QP_BIT_RRE;
+        if (access_flags & IB_ACCESS_REMOTE_ATOMIC)
+                hw_access_flags |= MTHCA_QP_BIT_RAE;
+        if (access_flags & IB_ACCESS_REMOTE_WRITE)
+                hw_access_flags |= MTHCA_QP_BIT_RWE;
+
+        return cpu_to_be32(hw_access_flags);
+}
+
+static void mthca_path_set(struct ib_ah_attr *ah, struct mthca_qp_path *path)
+{
+        path->g_mylmc     = ah->src_path_bits & 0x7f;
+        path->rlid        = cpu_to_be16(ah->dlid);
+        path->static_rate = !!ah->static_rate;
+
+        if (ah->ah_flags & IB_AH_GRH) {
+                path->g_mylmc   |= 1 << 7;
+                path->mgid_index = ah->grh.sgid_index;
+                path->hop_limit  = ah->grh.hop_limit;
+                path->sl_tclass_flowlabel = 
+                        cpu_to_be32((ah->sl << 28)                |
+                                    (ah->grh.traffic_class << 20) | 
+                                    (ah->grh.flow_label));
+                memcpy(path->rgid, ah->grh.dgid.raw, 16);
+        } else
+                path->sl_tclass_flowlabel = cpu_to_be32(ah->sl << 28);
+}
+
 int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
 {
         struct mthca_dev *dev = to_mdev(ibqp->device);
@@ -591,6 +637,26 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
                 return -EINVAL;
         }
 
+        if ((attr_mask & IB_QP_PORT) &&
+            (attr->port_num == 0 || attr->port_num > dev->limits.num_ports)) {
+                mthca_dbg(dev, "Port number (%u) is invalid\n", attr->port_num);
+                return -EINVAL;
+        }
+
+        if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&
+            attr->max_rd_atomic > dev->limits.max_qp_init_rdma) {
+                mthca_dbg(dev, "Max rdma_atomic as initiator %u too large (max is %d)\n",
+                          attr->max_rd_atomic, dev->limits.max_qp_init_rdma);
+                return -EINVAL;
+        }
+
+        if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC &&
+            attr->max_dest_rd_atomic > 1 << dev->qp_table.rdb_shift) {
+                mthca_dbg(dev, "Max rdma_atomic as responder %u too large (max %d)\n",
+                          attr->max_dest_rd_atomic, 1 << dev->qp_table.rdb_shift);
+                return -EINVAL;
+        }
+
         mailbox = mthca_alloc_mailbox(dev, GFP_KERNEL);
         if (IS_ERR(mailbox))
                 return PTR_ERR(mailbox);
@@ -665,28 +731,14 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
         }
 
         if (attr_mask & IB_QP_RNR_RETRY) {
-                qp_context->pri_path.rnr_retry = attr->rnr_retry << 5;
-                qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RNR_RETRY);
+                qp_context->alt_path.rnr_retry = qp_context->pri_path.rnr_retry =
+                        attr->rnr_retry << 5;
+                qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RNR_RETRY | 
+                                                        MTHCA_QP_OPTPAR_ALT_RNR_RETRY);
         }
 
         if (attr_mask & IB_QP_AV) {
-                qp_context->pri_path.g_mylmc     = attr->ah_attr.src_path_bits & 0x7f;
-                qp_context->pri_path.rlid        = cpu_to_be16(attr->ah_attr.dlid);
-                qp_context->pri_path.static_rate = !!attr->ah_attr.static_rate;
-                if (attr->ah_attr.ah_flags & IB_AH_GRH) {
-                        qp_context->pri_path.g_mylmc |= 1 << 7;
-                        qp_context->pri_path.mgid_index = attr->ah_attr.grh.sgid_index;
-                        qp_context->pri_path.hop_limit = attr->ah_attr.grh.hop_limit;
-                        qp_context->pri_path.sl_tclass_flowlabel =
-                                cpu_to_be32((attr->ah_attr.sl << 28)                |
-                                            (attr->ah_attr.grh.traffic_class << 20) |
-                                            (attr->ah_attr.grh.flow_label));
-                        memcpy(qp_context->pri_path.rgid,
-                               attr->ah_attr.grh.dgid.raw, 16);
-                } else {
-                        qp_context->pri_path.sl_tclass_flowlabel =
-                                cpu_to_be32(attr->ah_attr.sl << 28);
-                }
+                mthca_path_set(&attr->ah_attr, &qp_context->pri_path);
                 qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_PRIMARY_ADDR_PATH);
         }
 
@@ -695,7 +747,19 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
                 qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_ACK_TIMEOUT);
         }
 
-        /* XXX alt_path */
+        if (attr_mask & IB_QP_ALT_PATH) {
+                if (attr->alt_port_num == 0 || attr->alt_port_num > dev->limits.num_ports) {
+                        mthca_dbg(dev, "Alternate port number (%u) is invalid\n", 
+                                attr->alt_port_num);
+                        return -EINVAL;
+                }
+
+                mthca_path_set(&attr->alt_ah_attr, &qp_context->alt_path);
+                qp_context->alt_path.port_pkey |= cpu_to_be32(attr->alt_pkey_index | 
+                                                              attr->alt_port_num << 24);
+                qp_context->alt_path.ackto = attr->alt_timeout << 3;
+                qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_ALT_ADDR_PATH);
+        }
 
         /* leave rdd as 0 */
         qp_context->pd         = cpu_to_be32(to_mpd(ibqp->pd)->pd_num);
@@ -703,9 +767,7 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
         qp_context->wqe_lkey   = cpu_to_be32(qp->mr.ibmr.lkey);
         qp_context->params1    = cpu_to_be32((MTHCA_ACK_REQ_FREQ << 28) |
                                              (MTHCA_FLIGHT_LIMIT << 24) |
-                                             MTHCA_QP_BIT_SRE           |
-                                             MTHCA_QP_BIT_SWE           |
-                                             MTHCA_QP_BIT_SAE);
+                                             MTHCA_QP_BIT_SWE);
         if (qp->sq_policy == IB_SIGNAL_ALL_WR)
                 qp_context->params1 |= cpu_to_be32(MTHCA_QP_BIT_SSC);
         if (attr_mask & IB_QP_RETRY_CNT) {
@@ -714,9 +776,13 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
         }
 
         if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC) {
-                qp_context->params1 |= cpu_to_be32(min(attr->max_rd_atomic ?
-                                                       ffs(attr->max_rd_atomic) - 1 : 0,
-                                                       7) << 21);
+                if (attr->max_rd_atomic) {
+                        qp_context->params1 |=
+                                cpu_to_be32(MTHCA_QP_BIT_SRE |
+                                            MTHCA_QP_BIT_SAE);
+                        qp_context->params1 |=
+                                cpu_to_be32(fls(attr->max_rd_atomic - 1) << 21);
+                }
                 qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_SRA_MAX);
         }
 
@@ -729,71 +795,19 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
                 qp_context->snd_db_index   = cpu_to_be32(qp->sq.db_index);
         }
 
-        if (attr_mask & IB_QP_ACCESS_FLAGS) {
-                qp_context->params2 |=
-                        cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_WRITE ?
-                                    MTHCA_QP_BIT_RWE : 0);
-
-                /*
-                 * Only enable RDMA reads and atomics if we have
-                 * responder resources set to a non-zero value.
-                 */
-                if (qp->resp_depth) {
-                        qp_context->params2 |=
-                                cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_READ ?
-                                            MTHCA_QP_BIT_RRE : 0);
-                        qp_context->params2 |=
-                                cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_ATOMIC ?
-                                            MTHCA_QP_BIT_RAE : 0);
-                }
-
-                qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RWE |
-                                                        MTHCA_QP_OPTPAR_RRE |
-                                                        MTHCA_QP_OPTPAR_RAE);
-
-                qp->atomic_rd_en = attr->qp_access_flags;
-        }
-
         if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC) {
-                u8 rra_max;
-
-                if (qp->resp_depth && !attr->max_dest_rd_atomic) {
-                        /*
-                         * Lowering our responder resources to zero.
-                         * Turn off reads RDMA and atomics as responder.
-                         * (RRE/RAE in params2 already zero)
-                         */
-                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RRE |
-                                                                MTHCA_QP_OPTPAR_RAE);
-                }
-
-                if (!qp->resp_depth && attr->max_dest_rd_atomic) {
-                        /*
-                         * Increasing our responder resources from
-                         * zero.  Turn on RDMA reads and atomics as
-                         * appropriate.
-                         */
+                if (attr->max_dest_rd_atomic)
                         qp_context->params2 |=
-                                cpu_to_be32(qp->atomic_rd_en & IB_ACCESS_REMOTE_READ ?
-                                            MTHCA_QP_BIT_RRE : 0);
-                        qp_context->params2 |=
-                                cpu_to_be32(qp->atomic_rd_en & IB_ACCESS_REMOTE_ATOMIC ?
-                                            MTHCA_QP_BIT_RAE : 0);
-
-                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RRE |
-                                                                MTHCA_QP_OPTPAR_RAE);
-                }
+                                cpu_to_be32(fls(attr->max_dest_rd_atomic - 1) << 21);
 
-                for (rra_max = 0;
-                     1 << rra_max < attr->max_dest_rd_atomic &&
-                             rra_max < dev->qp_table.rdb_shift;
-                     ++rra_max)
-                        ; /* nothing */
-
-                qp_context->params2      |= cpu_to_be32(rra_max << 21);
                 qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RRA_MAX);
+        }
 
-                qp->resp_depth = attr->max_dest_rd_atomic;
+        if (attr_mask & (IB_QP_ACCESS_FLAGS | IB_QP_MAX_DEST_RD_ATOMIC)) {
+                qp_context->params2      |= get_hw_access_flags(qp, attr, attr_mask);
+                qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RWE |
+                                                        MTHCA_QP_OPTPAR_RRE |
+                                                        MTHCA_QP_OPTPAR_RAE);
         }
 
         qp_context->params2 |= cpu_to_be32(MTHCA_QP_BIT_RSC);
@@ -835,8 +849,13 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
                 err = -EINVAL;
         }
 
-        if (!err)
+        if (!err) {
                 qp->state = new_state;
+                if (attr_mask & IB_QP_ACCESS_FLAGS)
+                        qp->atomic_rd_en = attr->qp_access_flags;
+                if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC)
+                        qp->resp_depth = attr->max_dest_rd_atomic;
+        }
 
         mthca_free_mailbox(dev, mailbox);
 
@@ -885,18 +904,13 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
         return err;
 }
 
-static void mthca_adjust_qp_caps(struct mthca_dev *dev,
-                                 struct mthca_pd *pd,
-                                 struct mthca_qp *qp)
+static int mthca_max_data_size(struct mthca_dev *dev, struct mthca_qp *qp, int desc_sz)
 {
-        int max_data_size;
-
         /*
          * Calculate the maximum size of WQE s/g segments, excluding
          * the next segment and other non-data segments.
          */
-        max_data_size = min(dev->limits.max_desc_sz, 1 << qp->sq.wqe_shift) -
-                sizeof (struct mthca_next_seg);
+        int max_data_size = desc_sz - sizeof (struct mthca_next_seg);
 
         switch (qp->transport) {
         case MLX:
@@ -915,11 +929,24 @@ static void mthca_adjust_qp_caps(struct mthca_dev *dev,
                 break;
         }
 
+        return max_data_size;
+}
+
+static inline int mthca_max_inline_data(struct mthca_pd *pd, int max_data_size)
+{
         /* We don't support inline data for kernel QPs (yet). */
-        if (!pd->ibpd.uobject)
-                qp->max_inline_data = 0;
-        else
-                qp->max_inline_data = max_data_size - MTHCA_INLINE_HEADER_SIZE;
+        return pd->ibpd.uobject ? max_data_size - MTHCA_INLINE_HEADER_SIZE : 0;
+}
+
+static void mthca_adjust_qp_caps(struct mthca_dev *dev,
+                                 struct mthca_pd *pd,
+                                 struct mthca_qp *qp)
+{
+        int max_data_size = mthca_max_data_size(dev, qp,
+                                                min(dev->limits.max_desc_sz,
+                                                    1 << qp->sq.wqe_shift));
+
+        qp->max_inline_data = mthca_max_inline_data(pd, max_data_size);
 
         qp->sq.max_gs = min_t(int, dev->limits.max_sg,
                               max_data_size / sizeof (struct mthca_data_seg));
@@ -1186,13 +1213,23 @@ static int mthca_alloc_qp_common(struct mthca_dev *dev,
 }
 
 static int mthca_set_qp_size(struct mthca_dev *dev, struct ib_qp_cap *cap,
-                             struct mthca_qp *qp)
+                             struct mthca_pd *pd, struct mthca_qp *qp)
 {
+        int max_data_size = mthca_max_data_size(dev, qp, dev->limits.max_desc_sz);
+
         /* Sanity check QP size before proceeding */
-        if (cap->max_send_wr  > dev->limits.max_wqes ||
-            cap->max_recv_wr  > dev->limits.max_wqes ||
-            cap->max_send_sge > dev->limits.max_sg   ||
-            cap->max_recv_sge > dev->limits.max_sg)
+        if (cap->max_send_wr     > dev->limits.max_wqes ||
+            cap->max_recv_wr     > dev->limits.max_wqes ||
+            cap->max_send_sge    > dev->limits.max_sg   ||
+            cap->max_recv_sge    > dev->limits.max_sg   ||
+            cap->max_inline_data > mthca_max_inline_data(pd, max_data_size))
+                return -EINVAL;
+
+        /*
+         * For MLX transport we need 2 extra S/G entries:
+         * one for the header and one for the checksum at the end
+         */
+        if (qp->transport == MLX && cap->max_recv_sge + 2 > dev->limits.max_sg)
                 return -EINVAL;
 
         if (mthca_is_memfree(dev)) {
@@ -1211,14 +1248,6 @@ static int mthca_set_qp_size(struct mthca_dev *dev, struct ib_qp_cap *cap,
                                     MTHCA_INLINE_CHUNK_SIZE) /
                               sizeof (struct mthca_data_seg));
 
-        /*
-         * For MLX transport we need 2 extra S/G entries:
-         * one for the header and one for the checksum at the end
-         */
-        if ((qp->transport == MLX && qp->sq.max_gs + 2 > dev->limits.max_sg) ||
-            qp->sq.max_gs > dev->limits.max_sg || qp->rq.max_gs > dev->limits.max_sg)
-                return -EINVAL;
-
         return 0;
 }
 
@@ -1233,7 +1262,7 @@ int mthca_alloc_qp(struct mthca_dev *dev,
 {
         int err;
 
-        err = mthca_set_qp_size(dev, cap, qp);
+        err = mthca_set_qp_size(dev, cap, pd, qp);
         if (err)
                 return err;
 
@@ -1276,7 +1305,7 @@ int mthca_alloc_sqp(struct mthca_dev *dev,
         u32 mqpn = qpn * 2 + dev->qp_table.sqp_start + port - 1;
         int err;
 
-        err = mthca_set_qp_size(dev, cap, &sqp->qp);
+        err = mthca_set_qp_size(dev, cap, pd, &sqp->qp);
         if (err)
                 return err;
 
diff --git a/drivers/infiniband/hw/mthca/mthca_srq.c b/drivers/infiniband/hw/mthca/mthca_srq.c
index f7d234295efe..e7e153d9c4c6 100644
--- a/drivers/infiniband/hw/mthca/mthca_srq.c
+++ b/drivers/infiniband/hw/mthca/mthca_srq.c
@@ -201,7 +201,7 @@ int mthca_alloc_srq(struct mthca_dev *dev, struct mthca_pd *pd,
         if (mthca_is_memfree(dev))
                 srq->max = roundup_pow_of_two(srq->max + 1);
 
-        ds = min(64UL,
+        ds = max(64UL,
                  roundup_pow_of_two(sizeof (struct mthca_next_seg) +
                                     srq->max_gs * sizeof (struct mthca_data_seg)));
         srq->wqe_shift = long_log2(ds);
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index ee9fe226ae99..dd488d3cffa9 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -39,6 +39,7 @@
 #include <linux/string.h>
 #include <linux/parser.h>
 #include <linux/random.h>
+#include <linux/jiffies.h>
 
 #include <asm/atomic.h>
 
diff --git a/drivers/input/keyboard/corgikbd.c b/drivers/input/keyboard/corgikbd.c
index 64672d491222..e301ee4ca264 100644
--- a/drivers/input/keyboard/corgikbd.c
+++ b/drivers/input/keyboard/corgikbd.c
@@ -19,7 +19,6 @@
 #include <linux/jiffies.h>
 #include <linux/module.h>
 #include <linux/slab.h>
-#include <asm/irq.h>
 
 #include <asm/arch/corgi.h>
 #include <asm/arch/hardware.h>
@@ -343,10 +342,9 @@ static int __init corgikbd_probe(struct platform_device *pdev)
         for (i = 0; i < CORGI_KEY_SENSE_NUM; i++) {
                 pxa_gpio_mode(CORGI_GPIO_KEY_SENSE(i) | GPIO_IN);
                 if (request_irq(CORGI_IRQ_GPIO_KEY_SENSE(i), corgikbd_interrupt,
-                                                SA_INTERRUPT, "corgikbd", corgikbd))
+                                SA_INTERRUPT | SA_TRIGGER_RISING,
+                                "corgikbd", corgikbd))
                         printk(KERN_WARNING "corgikbd: Can't get IRQ: %d!\n", i);
-                else
-                        set_irq_type(CORGI_IRQ_GPIO_KEY_SENSE(i),IRQT_RISING);
         }
 
         /* Set Strobe lines as outputs - set high */
diff --git a/drivers/input/keyboard/spitzkbd.c b/drivers/input/keyboard/spitzkbd.c
index 6a15fe3bc527..83999d583122 100644
--- a/drivers/input/keyboard/spitzkbd.c
+++ b/drivers/input/keyboard/spitzkbd.c
@@ -19,7 +19,6 @@
 #include <linux/jiffies.h>
 #include <linux/module.h>
 #include <linux/slab.h>
-#include <asm/irq.h>
 
 #include <asm/arch/spitz.h>
 #include <asm/arch/hardware.h>
@@ -407,10 +406,9 @@ static int __init spitzkbd_probe(struct platform_device *dev)
         for (i = 0; i < SPITZ_KEY_SENSE_NUM; i++) {
                 pxa_gpio_mode(spitz_senses[i] | GPIO_IN);
                 if (request_irq(IRQ_GPIO(spitz_senses[i]), spitzkbd_interrupt,
-                                                SA_INTERRUPT, "Spitzkbd Sense", spitzkbd))
+                                SA_INTERRUPT|SA_TRIGGER_RISING,
+                                "Spitzkbd Sense", spitzkbd))
                         printk(KERN_WARNING "spitzkbd: Can't get Sense IRQ: %d!\n", i);
-                else
-                        set_irq_type(IRQ_GPIO(spitz_senses[i]),IRQT_RISING);
         }
 
         /* Set Strobe lines as outputs - set high */
@@ -422,15 +420,18 @@ static int __init spitzkbd_probe(struct platform_device *dev)
         pxa_gpio_mode(SPITZ_GPIO_SWA | GPIO_IN);
         pxa_gpio_mode(SPITZ_GPIO_SWB | GPIO_IN);
 
-        request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt, SA_INTERRUPT, "Spitzkbd Sync", spitzkbd);
-        request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt, SA_INTERRUPT, "Spitzkbd PwrOn", spitzkbd);
-        request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr, SA_INTERRUPT, "Spitzkbd SWA", spitzkbd);
-        request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr, SA_INTERRUPT, "Spitzkbd SWB", spitzkbd);
-
-        set_irq_type(SPITZ_IRQ_GPIO_SYNC, IRQT_BOTHEDGE);
-        set_irq_type(SPITZ_IRQ_GPIO_ON_KEY, IRQT_BOTHEDGE);
-        set_irq_type(SPITZ_IRQ_GPIO_SWA, IRQT_BOTHEDGE);
-        set_irq_type(SPITZ_IRQ_GPIO_SWB, IRQT_BOTHEDGE);
+        request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt,
+                    SA_INTERRUPT | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
+                    "Spitzkbd Sync", spitzkbd);
+        request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt,
+                    SA_INTERRUPT | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
+                    "Spitzkbd PwrOn", spitzkbd);
+        request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr,
+                    SA_INTERRUPT | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
+                    "Spitzkbd SWA", spitzkbd);
+        request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr,
+                    SA_INTERRUPT | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
+                    "Spitzkbd SWB", spitzkbd);
 
         printk(KERN_INFO "input: Spitz Keyboard Registered\n");
 
diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index 1cd7657f7e42..1be963961c15 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -60,8 +60,6 @@ static struct fasync_struct *hp_sdc_rtc_async_queue;
 
 static DECLARE_WAIT_QUEUE_HEAD(hp_sdc_rtc_wait);
 
-static loff_t hp_sdc_rtc_llseek(struct file *file, loff_t offset, int origin);
-
 static ssize_t hp_sdc_rtc_read(struct file *file, char *buf,
                                size_t count, loff_t *ppos);
 
@@ -387,11 +385,6 @@ static int hp_sdc_rtc_set_i8042timer (struct timeval *setto, uint8_t setcmd)
         return 0;
 }
 
-static loff_t hp_sdc_rtc_llseek(struct file *file, loff_t offset, int origin)
-{
-        return -ESPIPE;
-}
-
 static ssize_t hp_sdc_rtc_read(struct file *file, char *buf,
                                size_t count, loff_t *ppos) {
         ssize_t retval;
@@ -679,7 +672,7 @@ static int hp_sdc_rtc_ioctl(struct inode *inode, struct file *file,
 
 static struct file_operations hp_sdc_rtc_fops = {
         .owner =        THIS_MODULE,
-        .llseek =       hp_sdc_rtc_llseek,
+        .llseek =       no_llseek,
         .read =         hp_sdc_rtc_read,
         .poll =         hp_sdc_rtc_poll,
         .ioctl =        hp_sdc_rtc_ioctl,
diff --git a/drivers/isdn/act2000/act2000.h b/drivers/isdn/act2000/act2000.h
index b091d1a54125..d4c50512a1ff 100644
--- a/drivers/isdn/act2000/act2000.h
+++ b/drivers/isdn/act2000/act2000.h
@@ -181,17 +181,17 @@ typedef struct act2000_card {
         char regname[35];               /* Name used for request_region     */
 } act2000_card;
 
-extern __inline__ void act2000_schedule_tx(act2000_card *card)
+static inline void act2000_schedule_tx(act2000_card *card)
 {
         schedule_work(&card->snd_tq);
 }
 
-extern __inline__ void act2000_schedule_rx(act2000_card *card)
+static inline void act2000_schedule_rx(act2000_card *card)
 {
         schedule_work(&card->rcv_tq);
 }
 
-extern __inline__ void act2000_schedule_poll(act2000_card *card)
+static inline void act2000_schedule_poll(act2000_card *card)
 {
         schedule_work(&card->poll_tq);
 }
diff --git a/drivers/isdn/act2000/capi.h b/drivers/isdn/act2000/capi.h
index f6d5f530b86b..49f453c53c64 100644
--- a/drivers/isdn/act2000/capi.h
+++ b/drivers/isdn/act2000/capi.h
@@ -78,29 +78,29 @@ typedef union  actcapi_infoel {              /* info element                 */
 typedef struct actcapi_msn {
         __u8 eaz;
         __u8 len;                            /* Length of MSN                */
-        __u8 msn[15] __attribute__ ((packed));
-} actcapi_msn;
+        __u8 msn[15];
+}  __attribute__((packed)) actcapi_msn;
 
 typedef struct actcapi_dlpd {
         __u8 len;                            /* Length of structure          */
-        __u16 dlen __attribute__ ((packed)); /* Data Length                  */
-        __u8 laa __attribute__ ((packed));   /* Link Address A               */
+        __u16 dlen;                          /* Data Length                  */
+        __u8 laa;                            /* Link Address A               */
         __u8 lab;                            /* Link Address B               */
         __u8 modulo;                         /* Modulo Mode                  */
         __u8 win;                            /* Window size                  */
         __u8 xid[100];                       /* XID Information              */
-} actcapi_dlpd;
+} __attribute__((packed)) actcapi_dlpd;
 
 typedef struct actcapi_ncpd {
         __u8   len;                          /* Length of structure          */
-        __u16  lic __attribute__ ((packed));
-        __u16  hic __attribute__ ((packed));
-        __u16  ltc __attribute__ ((packed));
-        __u16  htc __attribute__ ((packed));
-        __u16  loc __attribute__ ((packed));
-        __u16  hoc __attribute__ ((packed));
-        __u8   modulo __attribute__ ((packed));
-} actcapi_ncpd;
+        __u16  lic;
+        __u16  hic;
+        __u16  ltc;
+        __u16  htc;
+        __u16  loc;
+        __u16  hoc;
+        __u8   modulo;
+} __attribute__((packed)) actcapi_ncpd;
 #define actcapi_ncpi actcapi_ncpd
 
 /*
@@ -168,19 +168,19 @@ typedef struct actcapi_msg {
                         __u16 manuf_msg;
                         __u16 controller;
                         actcapi_msn msnmap;
-                } manufacturer_req_msn;
+                } __attribute ((packed)) manufacturer_req_msn;
                 /* TODO: TraceInit-req/conf/ind/resp and
                  *       TraceDump-req/conf/ind/resp
                  */
                 struct connect_req {
                         __u8  controller;
                         __u8  bchan;
-                        __u32 infomask __attribute__ ((packed));
+                        __u32 infomask;
                         __u8  si1;
                         __u8  si2;
                         __u8  eaz;
                         actcapi_addr addr;
-                } connect_req;
+                } __attribute__ ((packed)) connect_req;
                 struct connect_conf {
                         __u16 plci;
                         __u16 info;
@@ -192,7 +192,7 @@ typedef struct actcapi_msg {
                         __u8  si2;
                         __u8  eaz;
                         actcapi_addr addr;
-                } connect_ind;
+                } __attribute__ ((packed)) connect_ind;
                 struct connect_resp {
                         __u16 plci;
                         __u8  rejectcause;
@@ -200,14 +200,14 @@ typedef struct actcapi_msg {
                 struct connect_active_ind {
                         __u16 plci;
                         actcapi_addr addr;
-                } connect_active_ind;
+                } __attribute__ ((packed)) connect_active_ind;
                 struct connect_active_resp {
                         __u16 plci;
                 } connect_active_resp;
                 struct connect_b3_req {
                         __u16 plci;
                         actcapi_ncpi ncpi;
-                } connect_b3_req;
+                } __attribute__ ((packed)) connect_b3_req;
                 struct connect_b3_conf {
                         __u16 plci;
                         __u16 ncci;
@@ -217,12 +217,12 @@ typedef struct actcapi_msg {
                         __u16 ncci;
                         __u16 plci;
                         actcapi_ncpi ncpi;
-                } connect_b3_ind;
+                } __attribute__ ((packed)) connect_b3_ind;
                 struct connect_b3_resp {
                         __u16 ncci;
                         __u8  rejectcause;
-                        actcapi_ncpi ncpi __attribute__ ((packed));
-                } connect_b3_resp;
+                        actcapi_ncpi ncpi;
+                } __attribute__ ((packed)) connect_b3_resp;
                 struct disconnect_req {
                         __u16 plci;
                         __u8  cause;
@@ -241,14 +241,14 @@ typedef struct actcapi_msg {
                 struct connect_b3_active_ind {
                         __u16 ncci;
                         actcapi_ncpi ncpi;
-                } connect_b3_active_ind;
+                } __attribute__ ((packed)) connect_b3_active_ind;
                 struct connect_b3_active_resp {
                         __u16 ncci;
                 } connect_b3_active_resp;
                 struct disconnect_b3_req {
                         __u16 ncci;
                         actcapi_ncpi ncpi;
-                } disconnect_b3_req;
+                } __attribute__ ((packed)) disconnect_b3_req;
                 struct disconnect_b3_conf {
                         __u16 ncci;
                         __u16 info;
@@ -257,7 +257,7 @@ typedef struct actcapi_msg {
                         __u16 ncci;
                         __u16 info;
                         actcapi_ncpi ncpi;
-                } disconnect_b3_ind;
+                } __attribute__ ((packed)) disconnect_b3_ind;
                 struct disconnect_b3_resp {
                         __u16 ncci;
                 } disconnect_b3_resp;
@@ -265,7 +265,7 @@ typedef struct actcapi_msg {
                         __u16 plci;
                         actcapi_infonr nr;
                         actcapi_infoel el;
-                } info_ind;
+                } __attribute__ ((packed)) info_ind;
                 struct info_resp {
                         __u16 plci;
                 } info_resp;
@@ -279,8 +279,8 @@ typedef struct actcapi_msg {
                 struct select_b2_protocol_req {
                         __u16 plci;
                         __u8  protocol;
-                        actcapi_dlpd dlpd __attribute__ ((packed));
-                } select_b2_protocol_req;
+                        actcapi_dlpd dlpd;
+                } __attribute__ ((packed)) select_b2_protocol_req;
                 struct select_b2_protocol_conf {
                         __u16 plci;
                         __u16 info;
@@ -288,49 +288,49 @@ typedef struct actcapi_msg {
                 struct select_b3_protocol_req {
                         __u16 plci;
                         __u8  protocol;
-                        actcapi_ncpd ncpd __attribute__ ((packed));
-                } select_b3_protocol_req;
+                        actcapi_ncpd ncpd;
+                } __attribute__ ((packed)) select_b3_protocol_req;
                 struct select_b3_protocol_conf {
                         __u16 plci;
                         __u16 info;
                 } select_b3_protocol_conf;
                 struct listen_req {
                         __u8  controller;
-                        __u32 infomask __attribute__ ((packed));  
-                        __u16 eazmask __attribute__ ((packed));
-                        __u16 simask __attribute__ ((packed));
-                } listen_req;
+                        __u32 infomask;
+                        __u16 eazmask;
+                        __u16 simask;
+                } __attribute__ ((packed)) listen_req;
                 struct listen_conf {
                         __u8  controller;
-                        __u16 info __attribute__ ((packed));
-                } listen_conf;
+                        __u16 info;
+                } __attribute__ ((packed)) listen_conf;
                 struct data_b3_req {
                         __u16 fakencci;
                         __u16 datalen;
                         __u32 unused;
                         __u8  blocknr;
-                        __u16 flags __attribute__ ((packed));
-                } data_b3_req;
+                        __u16 flags;
+                } __attribute ((packed)) data_b3_req;
                 struct data_b3_ind {
                         __u16 fakencci;
                         __u16 datalen;
                         __u32 unused;
                         __u8  blocknr;
-                        __u16 flags __attribute__ ((packed));
-                } data_b3_ind;
+                        __u16 flags;
+                } __attribute__ ((packed)) data_b3_ind;
                 struct data_b3_resp {
                         __u16 ncci;
                         __u8  blocknr;
-                } data_b3_resp;
+                } __attribute__ ((packed)) data_b3_resp;
                 struct data_b3_conf {
                         __u16 ncci;
                         __u8  blocknr;
-                        __u16 info __attribute__ ((packed));
-                } data_b3_conf;
+                        __u16 info;
+                } __attribute__ ((packed)) data_b3_conf;
         } msg;
-} actcapi_msg;
+} __attribute__ ((packed)) actcapi_msg;
 
-extern __inline__ unsigned short
+static inline unsigned short
 actcapi_nextsmsg(act2000_card *card)
 {
         unsigned long flags;
diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c
index 7b564c0dd996..207cae366256 100644
--- a/drivers/isdn/capi/capifs.c
+++ b/drivers/isdn/capi/capifs.c
@@ -17,6 +17,8 @@
 #include <linux/ctype.h>
 #include <linux/sched.h>        /* current */
 
+#include "capifs.h"
+
 MODULE_DESCRIPTION("CAPI4Linux: /dev/capi/ filesystem");
 MODULE_AUTHOR("Carsten Paeth");
 MODULE_LICENSE("GPL");
diff --git a/drivers/isdn/hardware/eicon/os_4bri.c b/drivers/isdn/hardware/eicon/os_4bri.c
index cccfabc1117d..11e6f937c1e4 100644
--- a/drivers/isdn/hardware/eicon/os_4bri.c
+++ b/drivers/isdn/hardware/eicon/os_4bri.c
@@ -16,6 +16,7 @@
 #include "diva_pci.h"
 #include "mi_pc.h"
 #include "dsrv4bri.h"
+#include "helpers.h"
 
 static void *diva_xdiLoadFileFile = NULL;
 static dword diva_xdiLoadFileLength = 0;
@@ -815,7 +816,7 @@ diva_4bri_cmd_card_proc(struct _diva_os_xdi_adapter *a,
         return (ret);
 }
 
-void *xdiLoadFile(char *FileName, unsigned long *FileLength,
+void *xdiLoadFile(char *FileName, dword *FileLength,
                   unsigned long lim)
 {
         void *ret = diva_xdiLoadFileFile;
diff --git a/drivers/isdn/hardware/eicon/os_bri.c b/drivers/isdn/hardware/eicon/os_bri.c
index 4cc44a5dd1db..f31bba5b16ff 100644
--- a/drivers/isdn/hardware/eicon/os_bri.c
+++ b/drivers/isdn/hardware/eicon/os_bri.c
@@ -16,6 +16,7 @@
 #include "diva_pci.h"
 #include "mi_pc.h"
 #include "pc_maint.h"
+#include "dsrv_bri.h"
 
 /*
 **  IMPORTS
diff --git a/drivers/isdn/hardware/eicon/os_pri.c b/drivers/isdn/hardware/eicon/os_pri.c
index 8ac207f75e54..a296a846f296 100644
--- a/drivers/isdn/hardware/eicon/os_pri.c
+++ b/drivers/isdn/hardware/eicon/os_pri.c
@@ -18,6 +18,7 @@
 #include "pc_maint.h"
 #include "dsp_tst.h"
 #include "diva_dma.h"
+#include "dsrv_pri.h"
 
 /* --------------------------------------------------------------------------
    OS Dependent part of XDI driver for DIVA PRI Adapter
diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
index c82105920d71..0ef560144be3 100644
--- a/drivers/isdn/hisax/Kconfig
+++ b/drivers/isdn/hisax/Kconfig
@@ -110,7 +110,7 @@ config HISAX_16_3
 
 config HISAX_TELESPCI
         bool "Teles PCI"
-        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || FRV))
         help
           This enables HiSax support for the Teles PCI.
           See <file:Documentation/isdn/README.HiSax> on how to configure it.
@@ -238,7 +238,7 @@ config HISAX_MIC
 
 config HISAX_NETJET
         bool "NETjet card"
-        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || FRV))
         help
           This enables HiSax support for the NetJet from Traverse
           Technologies.
@@ -249,7 +249,7 @@ config HISAX_NETJET
 
 config HISAX_NETJET_U
         bool "NETspider U card"
-        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || FRV))
         help
           This enables HiSax support for the Netspider U interface ISDN card
           from Traverse Technologies.
@@ -317,7 +317,7 @@ config HISAX_GAZEL
 
 config HISAX_HFC_PCI
         bool "HFC PCI-Bus cards"
-        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || FRV))
         help
           This enables HiSax support for the HFC-S PCI 2BDS0 based cards.
 
@@ -344,7 +344,7 @@ config HISAX_HFC_SX
 
 config HISAX_ENTERNOW_PCI
         bool "Formula-n enter:now PCI card"
-        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || FRV))
         help
           This enables HiSax support for the Formula-n enter:now PCI
           ISDN card.
diff --git a/drivers/isdn/hisax/hisax.h b/drivers/isdn/hisax/hisax.h
index 26c545fa223b..1b85ce166af8 100644
--- a/drivers/isdn/hisax/hisax.h
+++ b/drivers/isdn/hisax/hisax.h
@@ -396,17 +396,17 @@ struct isar_hw {
 
 struct hdlc_stat_reg {
 #ifdef __BIG_ENDIAN
-        u_char fill __attribute__((packed));
-        u_char mode __attribute__((packed));
-        u_char xml  __attribute__((packed));
-        u_char cmd  __attribute__((packed));
+        u_char fill;
+        u_char mode;
+        u_char xml;
+        u_char cmd;
 #else
-        u_char cmd  __attribute__((packed));
-        u_char xml  __attribute__((packed));
-        u_char mode __attribute__((packed));
-        u_char fill __attribute__((packed));
+        u_char cmd;
+        u_char xml;
+        u_char mode;
+        u_char fill;
 #endif
-};
+} __attribute__((packed));
 
 struct hdlc_hw {
         union {
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.h b/drivers/isdn/hisax/hisax_fcpcipnp.h
index bd8a22e4d6a2..21fbcedf3a94 100644
--- a/drivers/isdn/hisax/hisax_fcpcipnp.h
+++ b/drivers/isdn/hisax/hisax_fcpcipnp.h
@@ -12,17 +12,17 @@ enum {
 
 struct hdlc_stat_reg {
 #ifdef __BIG_ENDIAN
-        u_char fill __attribute__((packed));
-        u_char mode __attribute__((packed));
-        u_char xml  __attribute__((packed));
-        u_char cmd  __attribute__((packed));
+        u_char fill;
+        u_char mode;
+        u_char xml;
+        u_char cmd;
 #else
-        u_char cmd  __attribute__((packed));
-        u_char xml  __attribute__((packed));
-        u_char mode __attribute__((packed));
-        u_char fill __attribute__((packed));
+        u_char cmd;
+        u_char xml;
+        u_char mode;
+        u_char fill;
 #endif
-};
+} __attribute__((packed));
 
 struct fritz_bcs {
         struct hisax_b_if b_if;
diff --git a/drivers/isdn/sc/command.c b/drivers/isdn/sc/command.c
index 19f2fcf0ae4a..b4b24335f716 100644
--- a/drivers/isdn/sc/command.c
+++ b/drivers/isdn/sc/command.c
@@ -43,7 +43,6 @@ extern int send_and_receive(int, unsigned int, unsigned char, unsigned char,
                 RspMessage *, int);
 extern int sendmessage(int, unsigned int, unsigned int, unsigned int,
                 unsigned int, unsigned int, unsigned int, unsigned int *);
-extern inline void pullphone(char *, char *);
 
 #ifdef DEBUG
 /*
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index a0ea44c3e8b1..7d4a0ac28c06 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -149,14 +149,14 @@ config MAC_EMUMOUSEBTN
 
 config THERM_WINDTUNNEL
         tristate "Support for thermal management on Windtunnel G4s"
-        depends on I2C && I2C_KEYWEST && PPC_PMAC && !PPC_PMAC64
+        depends on I2C && I2C_POWERMAC && PPC_PMAC && !PPC_PMAC64
         help
           This driver provides some thermostat and fan control for the desktop
           G4 "Windtunnel"
 
 config THERM_ADT746X
         tristate "Support for thermal mgmnt on laptops with ADT 746x chipset"
-        depends on I2C && I2C_KEYWEST && PPC_PMAC && !PPC_PMAC64
+        depends on I2C && I2C_POWERMAC && PPC_PMAC && !PPC_PMAC64
         help
           This driver provides some thermostat and fan control for the
           iBook G4, and the ATI based aluminium PowerBooks, allowing slighlty
@@ -164,7 +164,7 @@ config THERM_ADT746X
 
 config THERM_PM72
         tristate "Support for thermal management on PowerMac G5"
-        depends on I2C && I2C_KEYWEST && PPC_PMAC64
+        depends on I2C && I2C_POWERMAC && PPC_PMAC64
         help
           This driver provides thermostat and fan control for the desktop
           G5 machines. 
@@ -175,14 +175,14 @@ config WINDFARM
 config WINDFARM_PM81
         tristate "Support for thermal management on iMac G5"
         depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU
-        select I2C_PMAC_SMU
+        select I2C_POWERMAC
         help
           This driver provides thermal control for the iMacG5
 
 config WINDFARM_PM91
         tristate "Support for thermal management on PowerMac9,1"
         depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU
-        select I2C_PMAC_SMU
+        select I2C_POWERMAC
         help
           This driver provides thermal control for the PowerMac9,1
           which is the recent (SMU based) single CPU desktop G5
diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
index 228e1852a836..2a545ceb523b 100644
--- a/drivers/macintosh/macio_asic.c
+++ b/drivers/macintosh/macio_asic.c
@@ -3,6 +3,13 @@
  * a MacIO ASIC. Interface to new driver model mostly
  * stolen from the PCI version.
  * 
+ *  Copyright (C) 2005 Ben. Herrenschmidt (benh@kernel.crashing.org)
+ *
+ *  This program is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU General Public License
+ *  as published by the Free Software Foundation; either version
+ *  2 of the License, or (at your option) any later version.
+ *
  * TODO:
  * 
  *  - Don't probe below media bay by default, but instead provide
@@ -218,12 +225,14 @@ postcore_initcall(macio_bus_driver_init);
 
 
 /**
- * macio_release_dev - free a macio device structure when all users of it are finished.
+ * macio_release_dev - free a macio device structure when all users of it are
+ * finished.
  * @dev: device that's been disconnected
  *
- * Will be called only by the device core when all users of this macio device are
- * done. This currently means never as we don't hot remove any macio device yet,
- * though that will happen with mediabay based devices in a later implementation.
+ * Will be called only by the device core when all users of this macio device
+ * are done. This currently means never as we don't hot remove any macio
+ * device yet, though that will happen with mediabay based devices in a later
+ * implementation.
  */
 static void macio_release_dev(struct device *dev)
 {
@@ -242,49 +251,114 @@ static void macio_release_dev(struct device *dev)
  * If this routine returns non-null, then the resource is completely
  * skipped.
  */
-static int macio_resource_quirks(struct device_node *np, struct resource *res, int index)
+static int macio_resource_quirks(struct device_node *np, struct resource *res,
+                                 int index)
 {
         if (res->flags & IORESOURCE_MEM) {
                 /* Grand Central has too large resource 0 on some machines */
-                if (index == 0 && !strcmp(np->name, "gc")) {
-                        np->addrs[0].size = 0x20000;
+                if (index == 0 && !strcmp(np->name, "gc"))
                         res->end = res->start + 0x1ffff;
-                }
+
                 /* Airport has bogus resource 2 */
                 if (index >= 2 && !strcmp(np->name, "radio"))
                         return 1;
+
+#ifndef CONFIG_PPC64
                 /* DBDMAs may have bogus sizes */
-                if ((res->start & 0x0001f000) == 0x00008000) {
-                        np->addrs[index].size = 0x100;
+                if ((res->start & 0x0001f000) == 0x00008000)
                         res->end = res->start + 0xff;
-                }
-                /* ESCC parent eats child resources. We could have added a level of hierarchy,
-                 * but I don't really feel the need for it */
+#endif /* CONFIG_PPC64 */
+
+                /* ESCC parent eats child resources. We could have added a
+                 * level of hierarchy, but I don't really feel the need
+                 * for it
+                 */
                 if (!strcmp(np->name, "escc"))
                         return 1;
+
                 /* ESCC has bogus resources >= 3 */
-                if (index >= 3 && !(strcmp(np->name, "ch-a") && strcmp(np->name, "ch-b")))
+                if (index >= 3 && !(strcmp(np->name, "ch-a") &&
+                                    strcmp(np->name, "ch-b")))
                         return 1;
+
                 /* Media bay has too many resources, keep only first one */
                 if (index > 0 && !strcmp(np->name, "media-bay"))
                         return 1;
+
                 /* Some older IDE resources have bogus sizes */
                 if (!(strcmp(np->name, "IDE") && strcmp(np->name, "ATA") &&
                       strcmp(np->type, "ide") && strcmp(np->type, "ata"))) {
-                        if (index == 0 && np->addrs[0].size > 0x1000) {
-                                np->addrs[0].size = 0x1000;
+                        if (index == 0 && (res->end - res->start) > 0xfff)
                                 res->end = res->start + 0xfff;
-                        }
-                        if (index == 1 && np->addrs[1].size > 0x100) {
-                                np->addrs[1].size = 0x100;
+                        if (index == 1 && (res->end - res->start) > 0xff)
                                 res->end = res->start + 0xff;
-                        }
                 }
         }
         return 0;
 }
 
 
+static void macio_setup_interrupts(struct macio_dev *dev)
+{
+        struct device_node *np = dev->ofdev.node;
+        int i,j;
+
+        /* For now, we use pre-parsed entries in the device-tree for
+         * interrupt routing and addresses, but we should change that
+         * to dynamically parsed entries and so get rid of most of the
+         * clutter in struct device_node
+         */
+        for (i = j = 0; i < np->n_intrs; i++) {
+                struct resource *res = &dev->interrupt[j];
+
+                if (j >= MACIO_DEV_COUNT_IRQS)
+                        break;
+                res->start = np->intrs[i].line;
+                res->flags = IORESOURCE_IO;
+                if (np->intrs[j].sense)
+                        res->flags |= IORESOURCE_IRQ_LOWLEVEL;
+                else
+                        res->flags |= IORESOURCE_IRQ_HIGHEDGE;
+                res->name = dev->ofdev.dev.bus_id;
+                if (macio_resource_quirks(np, res, i))
+                        memset(res, 0, sizeof(struct resource));
+                else
+                        j++;
+        }
+        dev->n_interrupts = j;
+}
+
+static void macio_setup_resources(struct macio_dev *dev,
+                                  struct resource *parent_res)
+{
+        struct device_node *np = dev->ofdev.node;
+        struct resource r;
+        int index;
+
+        for (index = 0; of_address_to_resource(np, index, &r) == 0; index++) {
+                struct resource *res = &dev->resource[index];
+                if (index >= MACIO_DEV_COUNT_RESOURCES)
+                        break;
+                *res = r;
+                res->name = dev->ofdev.dev.bus_id;
+
+                if (macio_resource_quirks(np, res, index)) {
+                        memset(res, 0, sizeof(struct resource));
+                        continue;
+                }
+                /* Currently, we consider failure as harmless, this may
+                 * change in the future, once I've found all the device
+                 * tree bugs in older machines & worked around them
+                 */
+                if (insert_resource(parent_res, res)) {
+                        printk(KERN_WARNING "Can't request resource "
+                               "%d for MacIO device %s\n",
+                               index, dev->ofdev.dev.bus_id);
+                }
+        }
+        dev->n_resources = index;
+}
+
 /**
  * macio_add_one_device - Add one device from OF node to the device tree
  * @chip: pointer to the macio_chip holding the device
@@ -294,12 +368,13 @@ static int macio_resource_quirks(struct device_node *np, struct resource *res, i
  * When media-bay is changed to hotswap drivers, this function will
  * be exposed to the bay driver some way...
  */
-static struct macio_dev * macio_add_one_device(struct macio_chip *chip, struct device *parent,
-                                               struct device_node *np, struct macio_dev *in_bay,
+static struct macio_dev * macio_add_one_device(struct macio_chip *chip,
+                                               struct device *parent,
+                                               struct device_node *np,
+                                               struct macio_dev *in_bay,
                                                struct resource *parent_res)
 {
         struct macio_dev *dev;
-        int i, j;
         u32 *reg;
         
         if (np == NULL)
@@ -326,7 +401,8 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip, struct d
 
         /* MacIO itself has a different reg, we use it's PCI base */
         if (np == chip->of_node) {
-                sprintf(dev->ofdev.dev.bus_id, "%1d.%08lx:%.*s", chip->lbus.index,
+                sprintf(dev->ofdev.dev.bus_id, "%1d.%08lx:%.*s",
+                        chip->lbus.index,
 #ifdef CONFIG_PCI
                         pci_resource_start(chip->lbus.pdev, 0),
 #else
@@ -335,57 +411,16 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip, struct d
                         MAX_NODE_NAME_SIZE, np->name);
         } else {
                 reg = (u32 *)get_property(np, "reg", NULL);
-                sprintf(dev->ofdev.dev.bus_id, "%1d.%08x:%.*s", chip->lbus.index,
+                sprintf(dev->ofdev.dev.bus_id, "%1d.%08x:%.*s",
+                        chip->lbus.index,
                         reg ? *reg : 0, MAX_NODE_NAME_SIZE, np->name);
         }
 
-        /* For now, we use pre-parsed entries in the device-tree for
-         * interrupt routing and addresses, but we should change that
-         * to dynamically parsed entries and so get rid of most of the
-         * clutter in struct device_node
-         */
-        for (i = j = 0; i < np->n_intrs; i++) {
-                struct resource *res = &dev->interrupt[j];
-
-                if (j >= MACIO_DEV_COUNT_IRQS)
-                        break;
-                res->start = np->intrs[i].line;
-                res->flags = IORESOURCE_IO;
-                if (np->intrs[j].sense)
-                        res->flags |= IORESOURCE_IRQ_LOWLEVEL;
-                else
-                        res->flags |= IORESOURCE_IRQ_HIGHEDGE;
-                res->name = dev->ofdev.dev.bus_id;
-                if (macio_resource_quirks(np, res, i))
-                        memset(res, 0, sizeof(struct resource));
-                else
-                        j++;
-        }
-        dev->n_interrupts = j;
-        for (i = j = 0; i < np->n_addrs; i++) {
-                struct resource *res = &dev->resource[j];
-                
-                if (j >= MACIO_DEV_COUNT_RESOURCES)
-                        break;
-                res->start = np->addrs[i].address;
-                res->end = np->addrs[i].address + np->addrs[i].size - 1;
-                res->flags = IORESOURCE_MEM;
-                res->name = dev->ofdev.dev.bus_id;
-                if (macio_resource_quirks(np, res, i))
-                        memset(res, 0, sizeof(struct resource));
-                else {
-                        j++;
-                        /* Currently, we consider failure as harmless, this may
-                         * change in the future, once I've found all the device
-                         * tree bugs in older machines & worked around them
-                         */
-                        if (insert_resource(parent_res, res))
-                                printk(KERN_WARNING "Can't request resource %d for MacIO"
-                                       " device %s\n", i, dev->ofdev.dev.bus_id);
-                }
-        }
-        dev->n_resources = j;
+        /* Setup interrupts & resources */
+        macio_setup_interrupts(dev);
+        macio_setup_resources(dev, parent_res);
 
+        /* Register with core */
         if (of_device_register(&dev->ofdev) != 0) {
                 printk(KERN_DEBUG"macio: device registration error for %s!\n",
                        dev->ofdev.dev.bus_id);
@@ -442,36 +477,42 @@ static void macio_pci_add_devices(struct macio_chip *chip)
 
         /* First scan 1st level */
         for (np = NULL; (np = of_get_next_child(pnode, np)) != NULL;) {
-                if (!macio_skip_device(np)) {
-                        of_node_get(np);
-                        mdev = macio_add_one_device(chip, &rdev->ofdev.dev, np, NULL, root_res);
-                        if (mdev == NULL)
-                                of_node_put(np);
-                        else if (strncmp(np->name, "media-bay", 9) == 0)
-                                mbdev = mdev;
-                        else if (strncmp(np->name, "escc", 4) == 0)
-                                sdev = mdev;
-                }
+                if (macio_skip_device(np))
+                        continue;
+                of_node_get(np);
+                mdev = macio_add_one_device(chip, &rdev->ofdev.dev, np, NULL,
+                                            root_res);
+                if (mdev == NULL)
+                        of_node_put(np);
+                else if (strncmp(np->name, "media-bay", 9) == 0)
+                        mbdev = mdev;
+                else if (strncmp(np->name, "escc", 4) == 0)
+                        sdev = mdev;
         }
 
         /* Add media bay devices if any */
         if (mbdev)
-                for (np = NULL; (np = of_get_next_child(mbdev->ofdev.node, np)) != NULL;)
-                        if (!macio_skip_device(np)) {
-                                of_node_get(np);
-                                if (macio_add_one_device(chip, &mbdev->ofdev.dev, np, mbdev,
-                                                         root_res) == NULL)
-                                        of_node_put(np);
-                        }
+                for (np = NULL; (np = of_get_next_child(mbdev->ofdev.node, np))
+                             != NULL;) {
+                        if (macio_skip_device(np))
+                                continue;
+                        of_node_get(np);
+                        if (macio_add_one_device(chip, &mbdev->ofdev.dev, np,
+                                                 mbdev,  root_res) == NULL)
+                                of_node_put(np);
+                }
+
         /* Add serial ports if any */
         if (sdev) {
-                for (np = NULL; (np = of_get_next_child(sdev->ofdev.node, np)) != NULL;)
-                        if (!macio_skip_device(np)) {
-                                of_node_get(np);
-                                if (macio_add_one_device(chip, &sdev->ofdev.dev, np, NULL,
-                                                         root_res) == NULL)
-                                        of_node_put(np);
-                        }
+                for (np = NULL; (np = of_get_next_child(sdev->ofdev.node, np))
+                             != NULL;) {
+                        if (macio_skip_device(np))
+                                continue;
+                        of_node_get(np);
+                        if (macio_add_one_device(chip, &sdev->ofdev.dev, np,
+                                                 NULL, root_res) == NULL)
+                                of_node_put(np);
+                }
         }
 }
 
@@ -519,7 +560,8 @@ void macio_unregister_driver(struct macio_driver *drv)
  *      Returns 0 on success, or %EBUSY on error.  A warning
  *      message is also printed on failure.
  */
-int macio_request_resource(struct macio_dev *dev, int resource_no, const char *name)
+int macio_request_resource(struct macio_dev *dev, int resource_no,
+                           const char *name)
 {
         if (macio_resource_len(dev, resource_no) == 0)
                 return 0;
@@ -606,20 +648,20 @@ static int __devinit macio_pci_probe(struct pci_dev *pdev, const struct pci_devi
         if (ent->vendor != PCI_VENDOR_ID_APPLE)
                 return -ENODEV;
 
-        /* Note regarding refcounting: We assume pci_device_to_OF_node() is ported
-         * to new OF APIs and returns a node with refcount incremented. This isn't
-         * the case today, but on the other hand ppc32 doesn't do refcounting. This
-         * will have to be fixed when going to ppc64. --BenH.
+        /* Note regarding refcounting: We assume pci_device_to_OF_node() is
+         * ported to new OF APIs and returns a node with refcount incremented.
          */
         np = pci_device_to_OF_node(pdev);
         if (np == NULL)
                 return -ENODEV;
 
-        /* This assumption is wrong, fix that here for now until I fix the arch */
+        /* The above assumption is wrong !!!
+         * fix that here for now until I fix the arch code
+         */
         of_node_get(np);
 
-        /* We also assume that pmac_feature will have done a get() on nodes stored
-         * in the macio chips array
+        /* We also assume that pmac_feature will have done a get() on nodes
+         * stored in the macio chips array
          */
         chip = macio_find(np, macio_unknown);
         of_node_put(np);
@@ -639,9 +681,9 @@ static int __devinit macio_pci_probe(struct pci_dev *pdev, const struct pci_devi
 
         /*
          * HACK ALERT: The WallStreet PowerBook and some OHare based machines
-         * have 2 macio ASICs. I must probe the "main" one first or IDE ordering
-         * will be incorrect. So I put on "hold" the second one since it seem to
-         * appear first on PCI
+         * have 2 macio ASICs. I must probe the "main" one first or IDE
+         * ordering will be incorrect. So I put on "hold" the second one since
+         * it seem to appear first on PCI
          */
         if (chip->type == macio_gatwick || chip->type == macio_ohareII)
                 if (macio_chips[0].lbus.pdev == NULL) {
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index b856bb67169c..8dbf2852bae0 100644
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -647,6 +647,7 @@ static int __devinit media_bay_attach(struct macio_dev *mdev, const struct of_de
         struct media_bay_info* bay;
         u32 __iomem *regbase;
         struct device_node *ofnode;
+        unsigned long base;
         int i;
 
         ofnode = mdev->ofdev.node;
@@ -656,10 +657,11 @@ static int __devinit media_bay_attach(struct macio_dev *mdev, const struct of_de
         if (macio_request_resources(mdev, "media-bay"))
                 return -EBUSY;
         /* Media bay registers are located at the beginning of the
-         * mac-io chip, we get the parent address for now (hrm...)
+         * mac-io chip, for now, we trick and align down the first
+         * resource passed in
          */
-        regbase = (u32 __iomem *)
-                ioremap(ofnode->parent->addrs[0].address, 0x100);
+        base = macio_resource_start(mdev, 0) & 0xffff0000u;
+        regbase = (u32 __iomem *)ioremap(base, 0x100);
         if (regbase == NULL) {
                 macio_release_resources(mdev);
                 return -ENOMEM;
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
index e8378274d710..db2ae71d07ef 100644
--- a/drivers/macintosh/smu.c
+++ b/drivers/macintosh/smu.c
@@ -53,7 +53,7 @@
 #undef DEBUG_SMU
 
 #ifdef DEBUG_SMU
-#define DPRINTK(fmt, args...) do { udbg_printf(KERN_DEBUG fmt , ##args); } while (0)
+#define DPRINTK(fmt, args...) do { printk(KERN_DEBUG fmt , ##args); } while (0)
 #else
 #define DPRINTK(fmt, args...) do { } while (0)
 #endif
@@ -94,6 +94,8 @@ struct smu_device {
 static struct smu_device        *smu;
 static DECLARE_MUTEX(smu_part_access);
 
+static void smu_i2c_retry(unsigned long data);
+
 /*
  * SMU driver low level stuff
  */
@@ -469,7 +471,6 @@ int __init smu_init (void)
         smu->of_node = np;
         smu->db_irq = NO_IRQ;
         smu->msg_irq = NO_IRQ;
-        init_timer(&smu->i2c_timer);
 
         /* smu_cmdbuf_abs is in the low 2G of RAM, can be converted to a
          * 32 bits value safely
@@ -544,6 +545,10 @@ static int smu_late_init(void)
         if (!smu)
                 return 0;
 
+        init_timer(&smu->i2c_timer);
+        smu->i2c_timer.function = smu_i2c_retry;
+        smu->i2c_timer.data = (unsigned long)smu;
+
         /*
          * Try to request the interrupts
          */
@@ -570,7 +575,10 @@ static int smu_late_init(void)
 
         return 0;
 }
-arch_initcall(smu_late_init);
+/* This has to be before arch_initcall as the low i2c stuff relies on the
+ * above having been done before we reach arch_initcalls
+ */
+core_initcall(smu_late_init);
 
 /*
  * sysfs visibility
@@ -580,20 +588,10 @@ static void smu_expose_childs(void *unused)
 {
         struct device_node *np;
 
-        for (np = NULL; (np = of_get_next_child(smu->of_node, np)) != NULL;) {
-                if (device_is_compatible(np, "smu-i2c")) {
-                        char name[32];
-                        u32 *reg = (u32 *)get_property(np, "reg", NULL);
-
-                        if (reg == NULL)
-                                continue;
-                        sprintf(name, "smu-i2c-%02x", *reg);
-                        of_platform_device_create(np, name, &smu->of_dev->dev);
-                }
+        for (np = NULL; (np = of_get_next_child(smu->of_node, np)) != NULL;)
                 if (device_is_compatible(np, "smu-sensors"))
-                        of_platform_device_create(np, "smu-sensors", &smu->of_dev->dev);
-        }
-
+                        of_platform_device_create(np, "smu-sensors",
+                                                  &smu->of_dev->dev);
 }
 
 static DECLARE_WORK(smu_expose_childs_work, smu_expose_childs, NULL);
@@ -712,13 +710,13 @@ static void smu_i2c_complete_command(struct smu_i2c_cmd *cmd, int fail)
 
 static void smu_i2c_retry(unsigned long data)
 {
-        struct smu_i2c_cmd      *cmd = (struct smu_i2c_cmd *)data;
+        struct smu_i2c_cmd      *cmd = smu->cmd_i2c_cur;
 
         DPRINTK("SMU: i2c failure, requeuing...\n");
 
         /* requeue command simply by resetting reply_len */
         cmd->pdata[0] = 0xff;
-        cmd->scmd.reply_len = 0x10;
+        cmd->scmd.reply_len = sizeof(cmd->pdata);
         smu_queue_cmd(&cmd->scmd);
 }
 
@@ -747,10 +745,8 @@ static void smu_i2c_low_completion(struct smu_cmd *scmd, void *misc)
          */
         if (fail && --cmd->retries > 0) {
                 DPRINTK("SMU: i2c failure, starting timer...\n");
-                smu->i2c_timer.function = smu_i2c_retry;
-                smu->i2c_timer.data = (unsigned long)cmd;
-                smu->i2c_timer.expires = jiffies + msecs_to_jiffies(5);
-                add_timer(&smu->i2c_timer);
+                BUG_ON(cmd != smu->cmd_i2c_cur);
+                mod_timer(&smu->i2c_timer, jiffies + msecs_to_jiffies(5));
                 return;
         }
 
@@ -764,7 +760,7 @@ static void smu_i2c_low_completion(struct smu_cmd *scmd, void *misc)
 
         /* Ok, initial command complete, now poll status */
         scmd->reply_buf = cmd->pdata;
-        scmd->reply_len = 0x10;
+        scmd->reply_len = sizeof(cmd->pdata);
         scmd->data_buf = cmd->pdata;
         scmd->data_len = 1;
         cmd->pdata[0] = 0;
@@ -786,7 +782,7 @@ int smu_queue_i2c(struct smu_i2c_cmd *cmd)
         cmd->scmd.done = smu_i2c_low_completion;
         cmd->scmd.misc = cmd;
         cmd->scmd.reply_buf = cmd->pdata;
-        cmd->scmd.reply_len = 0x10;
+        cmd->scmd.reply_len = sizeof(cmd->pdata);
         cmd->scmd.data_buf = (u8 *)(char *)&cmd->info;
         cmd->scmd.status = 1;
         cmd->stage = 0;
@@ -909,10 +905,13 @@ static struct smu_sdbp_header *smu_create_sdb_partition(int id)
         struct property *prop;
 
         /* First query the partition info */
+        DPRINTK("SMU: Query partition infos ... (irq=%d)\n", smu->db_irq);
         smu_queue_simple(&cmd, SMU_CMD_PARTITION_COMMAND, 2,
                          smu_done_complete, &comp,
                          SMU_CMD_PARTITION_LATEST, id);
         wait_for_completion(&comp);
+        DPRINTK("SMU: done, status: %d, reply_len: %d\n",
+                cmd.cmd.status, cmd.cmd.reply_len);
 
         /* Partition doesn't exist (or other error) */
         if (cmd.cmd.status != 0 || cmd.cmd.reply_len != 6)
@@ -975,6 +974,8 @@ struct smu_sdbp_header *__smu_get_sdb_partition(int id, unsigned int *size,
 
         sprintf(pname, "sdb-partition-%02x", id);
 
+        DPRINTK("smu_get_sdb_partition(%02x)\n", id);
+
         if (interruptible) {
                 int rc;
                 rc = down_interruptible(&smu_part_access);
@@ -986,6 +987,7 @@ struct smu_sdbp_header *__smu_get_sdb_partition(int id, unsigned int *size,
         part = (struct smu_sdbp_header *)get_property(smu->of_node,
                                                       pname, size);
         if (part == NULL) {
+                DPRINTK("trying to extract from SMU ...\n");
                 part = smu_create_sdb_partition(id);
                 if (part != NULL && size)
                         *size = part->len << 2;
diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c
index d843a6c9c6df..2d9d79150403 100644
--- a/drivers/macintosh/via-cuda.c
+++ b/drivers/macintosh/via-cuda.c
@@ -127,39 +127,34 @@ struct adb_driver via_cuda_driver = {
 #endif /* CONFIG_ADB */
 
 #ifdef CONFIG_PPC
-int __init
-find_via_cuda(void)
+int __init find_via_cuda(void)
 {
-    int err;
     struct adb_request req;
+    phys_addr_t taddr;
+    u32 *reg;
+    int err;
 
     if (vias != 0)
         return 1;
-    vias = find_devices("via-cuda");
+    vias = of_find_node_by_name(NULL, "via-cuda");
     if (vias == 0)
         return 0;
-    if (vias->next != 0)
-        printk(KERN_WARNING "Warning: only using 1st via-cuda\n");
-
-#if 0
-    { int i;
-
-    printk("find_via_cuda: node = %p, addrs =", vias->node);
-    for (i = 0; i < vias->n_addrs; ++i)
-        printk(" %x(%x)", vias->addrs[i].address, vias->addrs[i].size);
-    printk(", intrs =");
-    for (i = 0; i < vias->n_intrs; ++i)
-        printk(" %x", vias->intrs[i].line);
-    printk("\n"); }
-#endif
 
-    if (vias->n_addrs != 1 || vias->n_intrs != 1) {
-        printk(KERN_ERR "via-cuda: expecting 1 address (%d) and 1 interrupt (%d)\n",
-               vias->n_addrs, vias->n_intrs);
-        if (vias->n_addrs < 1 || vias->n_intrs < 1)
-            return 0;
+    reg = (u32 *)get_property(vias, "reg", NULL);
+    if (reg == NULL) {
+            printk(KERN_ERR "via-cuda: No \"reg\" property !\n");
+            goto fail;
+    }
+    taddr = of_translate_address(vias, reg);
+    if (taddr == 0) {
+            printk(KERN_ERR "via-cuda: Can't translate address !\n");
+            goto fail;
+    }
+    via = ioremap(taddr, 0x2000);
+    if (via == NULL) {
+            printk(KERN_ERR "via-cuda: Can't map address !\n");
+            goto fail;
     }
-    via = ioremap(vias->addrs->address, 0x2000);
 
     cuda_state = idle;
     sys_ctrler = SYS_CTRLER_CUDA;
@@ -185,6 +180,11 @@ find_via_cuda(void)
         cuda_poll();
 
     return 1;
+
+ fail:
+    of_node_put(vias);
+    vias = NULL;
+    return 0;
 }
 #endif /* CONFIG_PPC */
 
@@ -193,10 +193,6 @@ static int __init via_cuda_start(void)
     if (via == NULL)
         return -ENODEV;
 
-#ifdef CONFIG_PPC
-    request_OF_resource(vias, 0, NULL);
-#endif
-
     if (request_irq(CUDA_IRQ, cuda_interrupt, 0, "ADB", cuda_interrupt)) {
         printk(KERN_ERR "cuda_init: can't get irq %d\n", CUDA_IRQ);
         return -EAGAIN;
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 564043508569..6eb93e45fcd3 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -55,6 +55,8 @@
 #include <asm/sections.h>
 #include <asm/irq.h>
 #include <asm/pmac_feature.h>
+#include <asm/pmac_pfunc.h>
+#include <asm/pmac_low_i2c.h>
 #include <asm/uaccess.h>
 #include <asm/mmu_context.h>
 #include <asm/cputable.h>
@@ -147,6 +149,7 @@ static struct device_node *vias;
 static int pmu_kind = PMU_UNKNOWN;
 static int pmu_fully_inited = 0;
 static int pmu_has_adb;
+static struct device_node *gpio_node;
 static unsigned char __iomem *gpio_reg = NULL;
 static int gpio_irq = -1;
 static int gpio_irq_enabled = -1;
@@ -157,8 +160,8 @@ static int pmu_version;
 static int drop_interrupts;
 #if defined(CONFIG_PM) && defined(CONFIG_PPC32)
 static int option_lid_wakeup = 1;
-static int sleep_in_progress;
 #endif /* CONFIG_PM && CONFIG_PPC32 */
+static int sleep_in_progress;
 static unsigned long async_req_locks;
 static unsigned int pmu_irq_stats[11];
 
@@ -196,7 +199,6 @@ static int pmu_adb_reset_bus(void);
 #endif /* CONFIG_ADB */
 
 static int init_pmu(void);
-static int pmu_queue_request(struct adb_request *req);
 static void pmu_start(void);
 static irqreturn_t via_pmu_interrupt(int irq, void *arg, struct pt_regs *regs);
 static irqreturn_t gpio1_interrupt(int irq, void *arg, struct pt_regs *regs);
@@ -295,22 +297,26 @@ static struct backlight_controller pmu_backlight_controller = {
 };
 #endif /* CONFIG_PMAC_BACKLIGHT */
 
-int
-find_via_pmu(void)
+int __init find_via_pmu(void)
 {
+        u64 taddr;
+        u32 *reg;
+
         if (via != 0)
                 return 1;
-        vias = find_devices("via-pmu");
-        if (vias == 0)
+        vias = of_find_node_by_name(NULL, "via-pmu");
+        if (vias == NULL)
                 return 0;
-        if (vias->next != 0)
-                printk(KERN_WARNING "Warning: only using 1st via-pmu\n");
 
-        if (vias->n_addrs < 1 || vias->n_intrs < 1) {
-                printk(KERN_ERR "via-pmu: %d addresses, %d interrupts!\n",
-                       vias->n_addrs, vias->n_intrs);
-                if (vias->n_addrs < 1 || vias->n_intrs < 1)
-                        return 0;
+        reg = (u32 *)get_property(vias, "reg", NULL);
+        if (reg == NULL) {
+                printk(KERN_ERR "via-pmu: No \"reg\" property !\n");
+                goto fail;
+        }
+        taddr = of_translate_address(vias, reg);
+        if (taddr == OF_BAD_ADDR) {
+                printk(KERN_ERR "via-pmu: Can't translate address !\n");
+                goto fail;
         }
 
         spin_lock_init(&pmu_lock);
@@ -331,7 +337,8 @@ find_via_pmu(void)
                 pmu_kind = PMU_HEATHROW_BASED;
         else if (device_is_compatible(vias->parent, "Keylargo")
                  || device_is_compatible(vias->parent, "K2-Keylargo")) {
-                struct device_node *gpio, *gpiop;
+                struct device_node *gpiop;
+                u64 gaddr = OF_BAD_ADDR;
 
                 pmu_kind = PMU_KEYLARGO_BASED;
                 pmu_has_adb = (find_type_devices("adb") != NULL);
@@ -341,19 +348,24 @@ find_via_pmu(void)
                                 PMU_INT_TICK |
                                 PMU_INT_ENVIRONMENT;
                 
-                gpiop = find_devices("gpio");
-                if (gpiop && gpiop->n_addrs) {
-                        gpio_reg = ioremap(gpiop->addrs->address, 0x10);
-                        gpio = find_devices("extint-gpio1");
-                        if (gpio == NULL)
-                                gpio = find_devices("pmu-interrupt");
-                        if (gpio && gpio->parent == gpiop && gpio->n_intrs)
-                                gpio_irq = gpio->intrs[0].line;
+                gpiop = of_find_node_by_name(NULL, "gpio");
+                if (gpiop) {
+                        reg = (u32 *)get_property(gpiop, "reg", NULL);
+                        if (reg)
+                                gaddr = of_translate_address(gpiop, reg);
+                        if (gaddr != OF_BAD_ADDR)
+                                gpio_reg = ioremap(gaddr, 0x10);
                 }
+                if (gpio_reg == NULL)
+                        printk(KERN_ERR "via-pmu: Can't find GPIO reg !\n");
         } else
                 pmu_kind = PMU_UNKNOWN;
 
-        via = ioremap(vias->addrs->address, 0x2000);
+        via = ioremap(taddr, 0x2000);
+        if (via == NULL) {
+                printk(KERN_ERR "via-pmu: Can't map address !\n");
+                goto fail;
+        }
         
         out_8(&via[IER], IER_CLR | 0x7f);       /* disable all intrs */
         out_8(&via[IFR], 0x7f);                 /* clear IFR */
@@ -365,23 +377,25 @@ find_via_pmu(void)
                 return 0;
         }
 
-        printk(KERN_INFO "PMU driver %d initialized for %s, firmware: %02x\n",
+        printk(KERN_INFO "PMU driver v%d initialized for %s, firmware: %02x\n",
                PMU_DRIVER_VERSION, pbook_type[pmu_kind], pmu_version);
                
         sys_ctrler = SYS_CTRLER_PMU;
         
         return 1;
+ fail:
+        of_node_put(vias);
+        vias = NULL;
+        return 0;
 }
 
 #ifdef CONFIG_ADB
-static int
-pmu_probe(void)
+static int pmu_probe(void)
 {
         return vias == NULL? -ENODEV: 0;
 }
 
-static int __init
-pmu_init(void)
+static int __init pmu_init(void)
 {
         if (vias == NULL)
                 return -ENODEV;
@@ -405,7 +419,7 @@ static int __init via_pmu_start(void)
         bright_req_2.complete = 1;
         batt_req.complete = 1;
 
-#if defined(CONFIG_PPC32) && !defined(CONFIG_PPC_MERGE)
+#ifndef CONFIG_PPC_MERGE
         if (pmu_kind == PMU_KEYLARGO_BASED)
                 openpic_set_irq_priority(vias->intrs[0].line,
                                          OPENPIC_PRIORITY_DEFAULT + 1);
@@ -418,10 +432,22 @@ static int __init via_pmu_start(void)
                 return -EAGAIN;
         }
 
-        if (pmu_kind == PMU_KEYLARGO_BASED && gpio_irq != -1) {
-                if (request_irq(gpio_irq, gpio1_interrupt, 0, "GPIO1 ADB", (void *)0))
-                        printk(KERN_ERR "pmu: can't get irq %d (GPIO1)\n", gpio_irq);
-                gpio_irq_enabled = 1;
+        if (pmu_kind == PMU_KEYLARGO_BASED) {
+                gpio_node = of_find_node_by_name(NULL, "extint-gpio1");
+                if (gpio_node == NULL)
+                        gpio_node = of_find_node_by_name(NULL,
+                                                         "pmu-interrupt");
+                if (gpio_node && gpio_node->n_intrs > 0)
+                        gpio_irq = gpio_node->intrs[0].line;
+
+                if (gpio_irq != -1) {
+                        if (request_irq(gpio_irq, gpio1_interrupt, 0,
+                                        "GPIO1 ADB", (void *)0))
+                                printk(KERN_ERR "pmu: can't get irq %d"
+                                       " (GPIO1)\n", gpio_irq);
+                        else
+                                gpio_irq_enabled = 1;
+                }
         }
 
         /* Enable interrupts */
@@ -454,9 +480,6 @@ static int __init via_pmu_dev_init(void)
         if (vias == NULL)
                 return -ENODEV;
 
-#ifndef CONFIG_PPC64
-        request_OF_resource(vias, 0, NULL);
-#endif
 #ifdef CONFIG_PMAC_BACKLIGHT
         /* Enable backlight */
         register_backlight_controller(&pmu_backlight_controller, NULL, "pmu");
@@ -1371,7 +1394,6 @@ next:
                         }
                         pmu_done(req);
                 } else {
-#if defined(CONFIG_XMON) && !defined(CONFIG_PPC64)
                         if (len == 4 && data[1] == 0x2c) {
                                 extern int xmon_wants_key, xmon_adb_keycode;
                                 if (xmon_wants_key) {
@@ -1379,7 +1401,6 @@ next:
                                         return;
                                 }
                         }
-#endif /* defined(CONFIG_XMON) && !defined(CONFIG_PPC64) */
 #ifdef CONFIG_ADB
                         /*
                          * XXX On the [23]400 the PMU gives us an up
@@ -1782,258 +1803,6 @@ pmu_present(void)
         return via != 0;
 }
 
-struct pmu_i2c_hdr {
-        u8      bus;
-        u8      mode;
-        u8      bus2;
-        u8      address;
-        u8      sub_addr;
-        u8      comb_addr;
-        u8      count;
-};
-
-int
-pmu_i2c_combined_read(int bus, int addr, int subaddr,  u8* data, int len)
-{
-        struct adb_request      req;
-        struct pmu_i2c_hdr      *hdr = (struct pmu_i2c_hdr *)&req.data[1];
-        int retry;
-        int rc;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                hdr->bus = bus;
-                hdr->address = addr & 0xfe;
-                hdr->mode = PMU_I2C_MODE_COMBINED;
-                hdr->bus2 = 0;
-                hdr->sub_addr = subaddr;
-                hdr->comb_addr = addr | 1;
-                hdr->count = len;
-                
-                req.nbytes = sizeof(struct pmu_i2c_hdr) + 1;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.data[0] = PMU_I2C_CMD;
-                req.reply[0] = 0xff;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        break;
-                mdelay(15);
-        }
-        if (req.reply[0] != PMU_I2C_STATUS_OK)
-                return -1;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                mdelay(15);
-
-                hdr->bus = PMU_I2C_BUS_STATUS;
-                req.reply[0] = 0xff;
-                
-                req.nbytes = 2;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.data[0] = PMU_I2C_CMD;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_DATAREAD) {
-                        memcpy(data, &req.reply[1], req.reply_len - 1);
-                        return req.reply_len - 1;
-                }
-        }
-        return -1;
-}
-
-int
-pmu_i2c_stdsub_write(int bus, int addr, int subaddr,  u8* data, int len)
-{
-        struct adb_request      req;
-        struct pmu_i2c_hdr      *hdr = (struct pmu_i2c_hdr *)&req.data[1];
-        int retry;
-        int rc;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                hdr->bus = bus;
-                hdr->address = addr & 0xfe;
-                hdr->mode = PMU_I2C_MODE_STDSUB;
-                hdr->bus2 = 0;
-                hdr->sub_addr = subaddr;
-                hdr->comb_addr = addr & 0xfe;
-                hdr->count = len;
-
-                req.data[0] = PMU_I2C_CMD;
-                memcpy(&req.data[sizeof(struct pmu_i2c_hdr) + 1], data, len);
-                req.nbytes = sizeof(struct pmu_i2c_hdr) + len + 1;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.reply[0] = 0xff;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        break;
-                mdelay(15);
-        }
-        if (req.reply[0] != PMU_I2C_STATUS_OK)
-                return -1;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                mdelay(15);
-
-                hdr->bus = PMU_I2C_BUS_STATUS;
-                req.reply[0] = 0xff;
-                
-                req.nbytes = 2;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.data[0] = PMU_I2C_CMD;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        return len;
-        }
-        return -1;
-}
-
-int
-pmu_i2c_simple_read(int bus, int addr,  u8* data, int len)
-{
-        struct adb_request      req;
-        struct pmu_i2c_hdr      *hdr = (struct pmu_i2c_hdr *)&req.data[1];
-        int retry;
-        int rc;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                hdr->bus = bus;
-                hdr->address = addr | 1;
-                hdr->mode = PMU_I2C_MODE_SIMPLE;
-                hdr->bus2 = 0;
-                hdr->sub_addr = 0;
-                hdr->comb_addr = 0;
-                hdr->count = len;
-
-                req.data[0] = PMU_I2C_CMD;
-                req.nbytes = sizeof(struct pmu_i2c_hdr) + 1;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.reply[0] = 0xff;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        break;
-                mdelay(15);
-        }
-        if (req.reply[0] != PMU_I2C_STATUS_OK)
-                return -1;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                mdelay(15);
-
-                hdr->bus = PMU_I2C_BUS_STATUS;
-                req.reply[0] = 0xff;
-                
-                req.nbytes = 2;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.data[0] = PMU_I2C_CMD;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_DATAREAD) {
-                        memcpy(data, &req.reply[1], req.reply_len - 1);
-                        return req.reply_len - 1;
-                }
-        }
-        return -1;
-}
-
-int
-pmu_i2c_simple_write(int bus, int addr,  u8* data, int len)
-{
-        struct adb_request      req;
-        struct pmu_i2c_hdr      *hdr = (struct pmu_i2c_hdr *)&req.data[1];
-        int retry;
-        int rc;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                hdr->bus = bus;
-                hdr->address = addr & 0xfe;
-                hdr->mode = PMU_I2C_MODE_SIMPLE;
-                hdr->bus2 = 0;
-                hdr->sub_addr = 0;
-                hdr->comb_addr = 0;
-                hdr->count = len;
-
-                req.data[0] = PMU_I2C_CMD;
-                memcpy(&req.data[sizeof(struct pmu_i2c_hdr) + 1], data, len);
-                req.nbytes = sizeof(struct pmu_i2c_hdr) + len + 1;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.reply[0] = 0xff;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        break;
-                mdelay(15);
-        }
-        if (req.reply[0] != PMU_I2C_STATUS_OK)
-                return -1;
-
-        for (retry=0; retry<16; retry++) {
-                memset(&req, 0, sizeof(req));
-
-                mdelay(15);
-
-                hdr->bus = PMU_I2C_BUS_STATUS;
-                req.reply[0] = 0xff;
-                
-                req.nbytes = 2;
-                req.reply_expected = 0;
-                req.reply_len = 0;
-                req.data[0] = PMU_I2C_CMD;
-                rc = pmu_queue_request(&req);
-                if (rc)
-                        return rc;
-                while(!req.complete)
-                        pmu_poll();
-                if (req.reply[0] == PMU_I2C_STATUS_OK)
-                        return len;
-        }
-        return -1;
-}
-
 #ifdef CONFIG_PM
 
 static LIST_HEAD(sleep_notifiers);
@@ -2338,8 +2107,9 @@ pmac_suspend_devices(void)
                 return -EBUSY;
         }
 
-        /* Disable clock spreading on some machines */
-        pmac_tweak_clock_spreading(0);
+        /* Call platform functions marked "on sleep" */
+        pmac_pfunc_i2c_suspend();
+        pmac_pfunc_base_suspend();
 
         /* Stop preemption */
         preempt_disable();
@@ -2411,8 +2181,9 @@ pmac_wakeup_devices(void)
         mdelay(10);
         preempt_enable();
 
-        /* Re-enable clock spreading on some machines */
-        pmac_tweak_clock_spreading(1);
+        /* Call platform functions marked "on wake" */
+        pmac_pfunc_base_resume();
+        pmac_pfunc_i2c_resume();
 
         /* Resume devices */
         device_resume();
@@ -3130,16 +2901,13 @@ static int __init init_pmu_sysfs(void)
 subsys_initcall(init_pmu_sysfs);
 
 EXPORT_SYMBOL(pmu_request);
+EXPORT_SYMBOL(pmu_queue_request);
 EXPORT_SYMBOL(pmu_poll);
 EXPORT_SYMBOL(pmu_poll_adb);
 EXPORT_SYMBOL(pmu_wait_complete);
 EXPORT_SYMBOL(pmu_suspend);
 EXPORT_SYMBOL(pmu_resume);
 EXPORT_SYMBOL(pmu_unlock);
-EXPORT_SYMBOL(pmu_i2c_combined_read);
-EXPORT_SYMBOL(pmu_i2c_stdsub_write);
-EXPORT_SYMBOL(pmu_i2c_simple_read);
-EXPORT_SYMBOL(pmu_i2c_simple_write);
 #if defined(CONFIG_PM) && defined(CONFIG_PPC32)
 EXPORT_SYMBOL(pmu_enable_irled);
 EXPORT_SYMBOL(pmu_battery_count);
diff --git a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c
index 57460e46c89f..906d3ecae6e6 100644
--- a/drivers/macintosh/windfarm_lm75_sensor.c
+++ b/drivers/macintosh/windfarm_lm75_sensor.c
@@ -21,6 +21,7 @@
 #include <asm/io.h>
 #include <asm/system.h>
 #include <asm/sections.h>
+#include <asm/pmac_low_i2c.h>
 
 #include "windfarm.h"
 
@@ -157,53 +158,21 @@ static struct wf_lm75_sensor *wf_lm75_create(struct i2c_adapter *adapter,
 
 static int wf_lm75_attach(struct i2c_adapter *adapter)
 {
-        u8 bus_id;
-        struct device_node *smu, *bus, *dev;
-
-        /* We currently only deal with LM75's hanging off the SMU
-         * i2c busses. If we extend that driver to other/older
-         * machines, we should split this function into SMU-i2c,
-         * keywest-i2c, PMU-i2c, ...
-         */
+        struct device_node *busnode, *dev;
+        struct pmac_i2c_bus *bus;
 
         DBG("wf_lm75: adapter %s detected\n", adapter->name);
 
-        if (strncmp(adapter->name, "smu-i2c-", 8) != 0)
-                return 0;
-        smu = of_find_node_by_type(NULL, "smu");
-        if (smu == NULL)
-                return 0;
-
-        /* Look for the bus in the device-tree */
-        bus_id = (u8)simple_strtoul(adapter->name + 8, NULL, 16);
-
-        DBG("wf_lm75: bus ID is %x\n", bus_id);
-
-        /* Look for sensors subdir */
-        for (bus = NULL;
-             (bus = of_get_next_child(smu, bus)) != NULL;) {
-                u32 *reg;
-
-                if (strcmp(bus->name, "i2c"))
-                        continue;
-                reg = (u32 *)get_property(bus, "reg", NULL);
-                if (reg == NULL)
-                        continue;
-                if (bus_id == *reg)
-                        break;
-        }
-        of_node_put(smu);
-        if (bus == NULL) {
-                printk(KERN_WARNING "windfarm: SMU i2c bus 0x%x not found"
-                       " in device-tree !\n", bus_id);
-                return 0;
-        }
+        bus = pmac_i2c_adapter_to_bus(adapter);
+        if (bus == NULL)
+                return -ENODEV;
+        busnode = pmac_i2c_get_bus_node(bus);
 
         DBG("wf_lm75: bus found, looking for device...\n");
 
         /* Now look for lm75(s) in there */
         for (dev = NULL;
-             (dev = of_get_next_child(bus, dev)) != NULL;) {
+             (dev = of_get_next_child(busnode, dev)) != NULL;) {
                 const char *loc =
                         get_property(dev, "hwsensor-location", NULL);
                 u32 *reg = (u32 *)get_property(dev, "reg", NULL);
@@ -217,9 +186,6 @@ static int wf_lm75_attach(struct i2c_adapter *adapter)
                 else if (device_is_compatible(dev, "ds1775"))
                         wf_lm75_create(adapter, *reg, 1, loc);
         }
-
-        of_node_put(bus);
-
         return 0;
 }
 
diff --git a/drivers/macintosh/windfarm_smu_controls.c b/drivers/macintosh/windfarm_smu_controls.c
index 2c3158c81ff2..4d811600bdab 100644
--- a/drivers/macintosh/windfarm_smu_controls.c
+++ b/drivers/macintosh/windfarm_smu_controls.c
@@ -14,6 +14,7 @@
 #include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/wait.h>
+#include <linux/completion.h>
 #include <asm/prom.h>
 #include <asm/machdep.h>
 #include <asm/io.h>
diff --git a/drivers/macintosh/windfarm_smu_sensors.c b/drivers/macintosh/windfarm_smu_sensors.c
index b558cc209d49..1a00d9c75a23 100644
--- a/drivers/macintosh/windfarm_smu_sensors.c
+++ b/drivers/macintosh/windfarm_smu_sensors.c
@@ -14,6 +14,7 @@
 #include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/wait.h>
+#include <linux/completion.h>
 #include <asm/prom.h>
 #include <asm/machdep.h>
 #include <asm/io.h>
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 1b76fb29fb70..e423a16ba3c9 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3598,12 +3598,21 @@ static int set_disk_faulty(mddev_t *mddev, dev_t dev)
         return 0;
 }
 
+static int md_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        mddev_t *mddev = bdev->bd_disk->private_data;
+
+        geo->heads = 2;
+        geo->sectors = 4;
+        geo->cylinders = get_capacity(mddev->gendisk) / 8;
+        return 0;
+}
+
 static int md_ioctl(struct inode *inode, struct file *file,
                         unsigned int cmd, unsigned long arg)
 {
         int err = 0;
         void __user *argp = (void __user *)arg;
-        struct hd_geometry __user *loc = argp;
         mddev_t *mddev = NULL;
 
         if (!capable(CAP_SYS_ADMIN))
@@ -3765,24 +3774,6 @@ static int md_ioctl(struct inode *inode, struct file *file,
          * 4 sectors (with a BIG number of cylinders...). This drives
          * dosfs just mad... ;-)
          */
-                case HDIO_GETGEO:
-                        if (!loc) {
-                                err = -EINVAL;
-                                goto abort_unlock;
-                        }
-                        err = put_user (2, (char __user *) &loc->heads);
-                        if (err)
-                                goto abort_unlock;
-                        err = put_user (4, (char __user *) &loc->sectors);
-                        if (err)
-                                goto abort_unlock;
-                        err = put_user(get_capacity(mddev->gendisk)/8,
-                                        (short __user *) &loc->cylinders);
-                        if (err)
-                                goto abort_unlock;
-                        err = put_user (get_start_sect(inode->i_bdev),
-                                                (long __user *) &loc->start);
-                        goto done_unlock;
         }
 
         /*
@@ -3911,6 +3902,7 @@ static struct block_device_operations md_fops =
         .open           = md_open,
         .release        = md_release,
         .ioctl          = md_ioctl,
+        .getgeo         = md_getgeo,
         .media_changed  = md_media_changed,
         .revalidate_disk= md_revalidate,
 };
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index abbca150202b..d03f99cf4b7d 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -306,9 +306,6 @@ static int raid0_run (mddev_t *mddev)
         printk("raid0 : conf->hash_spacing is %llu blocks.\n",
                 (unsigned long long)conf->hash_spacing);
         {
-#if __GNUC__ < 3
-                volatile
-#endif
                 sector_t s = mddev->array_size;
                 sector_t space = conf->hash_spacing;
                 int round;
@@ -439,9 +436,6 @@ static int raid0_make_request (request_queue_t *q, struct bio *bio)
  
 
         {
-#if __GNUC__ < 3
-                volatile
-#endif
                 sector_t x = block >> conf->preshift;
                 sector_div(x, (u32)conf->hash_spacing);
                 zone = conf->hash_table[x];
diff --git a/drivers/media/common/saa7146_fops.c b/drivers/media/common/saa7146_fops.c
index 09ec964dec5c..b614612be7b4 100644
--- a/drivers/media/common/saa7146_fops.c
+++ b/drivers/media/common/saa7146_fops.c
@@ -253,7 +253,10 @@ static int fops_open(struct inode *inode, struct file *file)
 
         if( fh->type == V4L2_BUF_TYPE_VBI_CAPTURE) {
                 DEB_S(("initializing vbi...\n"));
-                result = saa7146_vbi_uops.open(dev,file);
+                if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)
+                        result = saa7146_vbi_uops.open(dev,file);
+                if (dev->ext_vv_data->vbi_fops.open)
+                        dev->ext_vv_data->vbi_fops.open(inode, file);
         } else {
                 DEB_S(("initializing video...\n"));
                 result = saa7146_video_uops.open(dev,file);
@@ -289,7 +292,10 @@ static int fops_release(struct inode *inode, struct file *file)
                 return -ERESTARTSYS;
 
         if( fh->type == V4L2_BUF_TYPE_VBI_CAPTURE) {
-                saa7146_vbi_uops.release(dev,file);
+                if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)
+                        saa7146_vbi_uops.release(dev,file);
+                if (dev->ext_vv_data->vbi_fops.release)
+                        dev->ext_vv_data->vbi_fops.release(inode, file);
         } else {
                 saa7146_video_uops.release(dev,file);
         }
@@ -332,6 +338,7 @@ static int fops_mmap(struct file *file, struct vm_area_struct * vma)
                 BUG();
                 return 0;
         }
+
         return videobuf_mmap_mapper(q,vma);
 }
 
@@ -381,7 +388,10 @@ static ssize_t fops_read(struct file *file, char __user *data, size_t count, lof
                 }
         case V4L2_BUF_TYPE_VBI_CAPTURE: {
 //              DEB_EE(("V4L2_BUF_TYPE_VBI_CAPTURE: file:%p, data:%p, count:%lu\n", file, data, (unsigned long)count));
-                return saa7146_vbi_uops.read(file,data,count,ppos);
+                if (fh->dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)
+                        return saa7146_vbi_uops.read(file,data,count,ppos);
+                else
+                        return -EINVAL;
                 }
                 break;
         default:
@@ -390,12 +400,31 @@ static ssize_t fops_read(struct file *file, char __user *data, size_t count, lof
         }
 }
 
+static ssize_t fops_write(struct file *file, const char __user *data, size_t count, loff_t *ppos)
+{
+        struct saa7146_fh *fh = file->private_data;
+
+        switch (fh->type) {
+        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+                return -EINVAL;
+        case V4L2_BUF_TYPE_VBI_CAPTURE:
+                if (fh->dev->ext_vv_data->vbi_fops.write)
+                        return fh->dev->ext_vv_data->vbi_fops.write(file, data, count, ppos);
+                else
+                        return -EINVAL;
+        default:
+                BUG();
+                return -EINVAL;
+        }
+}
+
 static struct file_operations video_fops =
 {
         .owner          = THIS_MODULE,
         .open           = fops_open,
         .release        = fops_release,
         .read           = fops_read,
+        .write          = fops_write,
         .poll           = fops_poll,
         .mmap           = fops_mmap,
         .ioctl          = fops_ioctl,
@@ -467,7 +496,8 @@ int saa7146_vv_init(struct saa7146_dev* dev, struct saa7146_ext_vv *ext_vv)
         memset(vv->d_clipping.cpu_addr, 0x0, SAA7146_CLIPPING_MEM);
 
         saa7146_video_uops.init(dev,vv);
-        saa7146_vbi_uops.init(dev,vv);
+        if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)
+                saa7146_vbi_uops.init(dev,vv);
 
         dev->vv_data = vv;
         dev->vv_callback = &vv_callback;
diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c
index ec52dff8cb69..33bec8a6843b 100644
--- a/drivers/media/common/saa7146_hlp.c
+++ b/drivers/media/common/saa7146_hlp.c
@@ -562,19 +562,26 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int
 
         int b_depth = vv->ov_fmt->depth;
         int b_bpl = vv->ov_fb.fmt.bytesperline;
-        u32 base = (u32)vv->ov_fb.base;
+        /* The unsigned long cast is to remove a 64-bit compile warning since
+           it looks like a 64-bit address is cast to a 32-bit value, even
+           though the base pointer is really a 32-bit physical address that
+           goes into a 32-bit DMA register.
+           FIXME: might not work on some 64-bit platforms, but see the FIXME
+           in struct v4l2_framebuffer (videodev2.h) for that.
+         */
+        u32 base = (u32)(unsigned long)vv->ov_fb.base;
 
         struct  saa7146_video_dma vdma1;
 
         /* calculate memory offsets for picture, look if we shall top-down-flip */
         vdma1.pitch     = 2*b_bpl;
         if ( 0 == vv->vflip ) {
-                vdma1.base_even = (u32)base + (w_y * (vdma1.pitch/2)) + (w_x * (b_depth / 8));
+                vdma1.base_even = base + (w_y * (vdma1.pitch/2)) + (w_x * (b_depth / 8));
                 vdma1.base_odd  = vdma1.base_even + (vdma1.pitch / 2);
                 vdma1.prot_addr = vdma1.base_even + (w_height * (vdma1.pitch / 2));
         }
         else {
-                vdma1.base_even = (u32)base + ((w_y+w_height) * (vdma1.pitch/2)) + (w_x * (b_depth / 8));
+                vdma1.base_even = base + ((w_y+w_height) * (vdma1.pitch/2)) + (w_x * (b_depth / 8));
                 vdma1.base_odd  = vdma1.base_even - (vdma1.pitch / 2);
                 vdma1.prot_addr = vdma1.base_odd - (w_height * (vdma1.pitch / 2));
         }
diff --git a/drivers/media/common/saa7146_vbi.c b/drivers/media/common/saa7146_vbi.c
index 063986ec16b5..468d3c959075 100644
--- a/drivers/media/common/saa7146_vbi.c
+++ b/drivers/media/common/saa7146_vbi.c
@@ -500,9 +500,9 @@ static ssize_t vbi_read(struct file *file, char __user *data, size_t count, loff
 }
 
 struct saa7146_use_ops saa7146_vbi_uops = {
-        .init           = vbi_init,
-        .open           = vbi_open,
+        .init           = vbi_init,
+        .open           = vbi_open,
         .release        = vbi_close,
         .irq_done       = vbi_irq_done,
-        .read           = vbi_read,
+        .read           = vbi_read,
 };
diff --git a/drivers/media/common/saa7146_video.c b/drivers/media/common/saa7146_video.c
index 1d961023b837..7ebac7949df3 100644
--- a/drivers/media/common/saa7146_video.c
+++ b/drivers/media/common/saa7146_video.c
@@ -151,8 +151,8 @@ static int try_win(struct saa7146_dev *dev, struct v4l2_window *win)
 
         if (V4L2_FIELD_ANY == field) {
                 field = (win->w.height > maxh/2)
-                        ? V4L2_FIELD_INTERLACED
-                        : V4L2_FIELD_TOP;
+                        ? V4L2_FIELD_INTERLACED
+                        : V4L2_FIELD_TOP;
                 }
         switch (field) {
         case V4L2_FIELD_TOP:
@@ -1114,10 +1114,6 @@ int saa7146_video_do_ioctl(struct inode *inode, struct file *file, unsigned int
                 return 0;
         }
         case VIDIOC_OVERLAY:
-
-
-
-
         {
                 int on = *(int *)arg;
                 int err = 0;
@@ -1359,7 +1355,6 @@ static void buffer_queue(struct videobuf_queue *q, struct videobuf_buffer *vb)
         saa7146_buffer_queue(fh->dev,&vv->video_q,buf);
 }
 
-
 static void buffer_release(struct videobuf_queue *q, struct videobuf_buffer *vb)
 {
         struct file *file = q->priv_data;
diff --git a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
index 21a9045b3ef6..0b940e152b79 100644
--- a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
+++ b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
@@ -298,7 +298,7 @@ static int flexcop_fe_request_firmware(struct dvb_frontend* fe, const struct fir
 }
 
 static int lgdt3303_pll_set(struct dvb_frontend* fe,
-                            struct dvb_frontend_parameters* params)
+                            struct dvb_frontend_parameters* params)
 {
         struct flexcop_device *fc = fe->dvb->priv;
         u8 buf[4];
@@ -485,12 +485,16 @@ static struct stv0297_config alps_tdee4_stv0297_config = {
 /* try to figure out the frontend, each card/box can have on of the following list */
 int flexcop_frontend_init(struct flexcop_device *fc)
 {
+        struct dvb_frontend_ops *ops;
+
         /* try the sky v2.6 (stv0299/Samsung tbmu24112(sl1935)) */
         if ((fc->fe = stv0299_attach(&samsung_tbmu24112_config, &fc->i2c_adap)) != NULL) {
-                fc->fe->ops->set_voltage = flexcop_set_voltage;
+                ops = fc->fe->ops;
+
+                ops->set_voltage = flexcop_set_voltage;
 
-                fc->fe_sleep             = fc->fe->ops->sleep;
-                fc->fe->ops->sleep       = flexcop_sleep;
+                fc->fe_sleep             = ops->sleep;
+                ops->sleep               = flexcop_sleep;
 
                 fc->dev_type          = FC_SKY;
                 info("found the stv0299 at i2c address: 0x%02x",samsung_tbmu24112_config.demod_address);
@@ -522,15 +526,17 @@ int flexcop_frontend_init(struct flexcop_device *fc)
         } else
         /* try the sky v2.3 (vp310/Samsung tbdu18132(tsa5059)) */
         if ((fc->fe = vp310_attach(&skystar23_samsung_tbdu18132_config, &fc->i2c_adap)) != NULL) {
-                fc->fe->ops->diseqc_send_master_cmd = flexcop_diseqc_send_master_cmd;
-                fc->fe->ops->diseqc_send_burst      = flexcop_diseqc_send_burst;
-                fc->fe->ops->set_tone               = flexcop_set_tone;
-                fc->fe->ops->set_voltage            = flexcop_set_voltage;
+                ops = fc->fe->ops;
+
+                ops->diseqc_send_master_cmd = flexcop_diseqc_send_master_cmd;
+                ops->diseqc_send_burst      = flexcop_diseqc_send_burst;
+                ops->set_tone               = flexcop_set_tone;
+                ops->set_voltage            = flexcop_set_voltage;
 
-                fc->fe_sleep                        = fc->fe->ops->sleep;
-                fc->fe->ops->sleep                  = flexcop_sleep;
+                fc->fe_sleep                = ops->sleep;
+                ops->sleep                  = flexcop_sleep;
 
-                fc->dev_type                        = FC_SKY_OLD;
+                fc->dev_type                = FC_SKY_OLD;
                 info("found the vp310 (aka mt312) at i2c address: 0x%02x",skystar23_samsung_tbdu18132_config.demod_address);
         }
 
@@ -540,8 +546,9 @@ int flexcop_frontend_init(struct flexcop_device *fc)
         } else {
                 if (dvb_register_frontend(&fc->dvb_adapter, fc->fe)) {
                         err("frontend registration failed!");
-                        if (fc->fe->ops->release != NULL)
-                                fc->fe->ops->release(fc->fe);
+                        ops = fc->fe->ops;
+                        if (ops->release != NULL)
+                                ops->release(fc->fe);
                         fc->fe = NULL;
                         return -EINVAL;
                 }
diff --git a/drivers/media/dvb/b2c2/flexcop-reg.h b/drivers/media/dvb/b2c2/flexcop-reg.h
index 23cc6431e2b8..3153f9513c63 100644
--- a/drivers/media/dvb/b2c2/flexcop-reg.h
+++ b/drivers/media/dvb/b2c2/flexcop-reg.h
@@ -39,11 +39,13 @@ extern const char *flexcop_device_names[];
 /* FlexCop IBI Registers */
 #if defined(__LITTLE_ENDIAN)
         #include "flexcop_ibi_value_le.h"
-#elif defined(__BIG_ENDIAN)
+#else
+#if defined(__BIG_ENDIAN)
         #include "flexcop_ibi_value_be.h"
 #else
         #error no endian defined
 #endif
+#endif
 
 #define fc_data_Tag_ID_DVB  0x3e
 #define fc_data_Tag_ID_ATSC 0x3f
diff --git a/drivers/media/dvb/bt8xx/dst.c b/drivers/media/dvb/bt8xx/dst.c
index 8977c7a313df..3a2ff1cc24b7 100644
--- a/drivers/media/dvb/bt8xx/dst.c
+++ b/drivers/media/dvb/bt8xx/dst.c
@@ -1341,30 +1341,40 @@ static int dst_read_snr(struct dvb_frontend *fe, u16 *snr)
         return 0;
 }
 
-static int dst_set_frontend(struct dvb_frontend *fe, struct dvb_frontend_parameters *p)
+static int dst_set_frontend(struct dvb_frontend* fe,
+                            struct dvb_frontend_parameters* p,
+                            unsigned int mode_flags,
+                            int *delay,
+                            fe_status_t *status)
 {
         struct dst_state *state = fe->demodulator_priv;
 
-        dst_set_freq(state, p->frequency);
-        dprintk(verbose, DST_DEBUG, 1, "Set Frequency=[%d]", p->frequency);
+        if (p != NULL) {
+                dst_set_freq(state, p->frequency);
+                dprintk(verbose, DST_DEBUG, 1, "Set Frequency=[%d]", p->frequency);
 
-        if (state->dst_type == DST_TYPE_IS_SAT) {
-                if (state->type_flags & DST_TYPE_HAS_OBS_REGS)
-                        dst_set_inversion(state, p->inversion);
-                dst_set_fec(state, p->u.qpsk.fec_inner);
-                dst_set_symbolrate(state, p->u.qpsk.symbol_rate);
-                dst_set_polarization(state);
-                dprintk(verbose, DST_DEBUG, 1, "Set Symbolrate=[%d]", p->u.qpsk.symbol_rate);
-
-        } else if (state->dst_type == DST_TYPE_IS_TERR)
-                dst_set_bandwidth(state, p->u.ofdm.bandwidth);
-        else if (state->dst_type == DST_TYPE_IS_CABLE) {
-                dst_set_fec(state, p->u.qam.fec_inner);
-                dst_set_symbolrate(state, p->u.qam.symbol_rate);
-                dst_set_modulation(state, p->u.qam.modulation);
+                if (state->dst_type == DST_TYPE_IS_SAT) {
+                        if (state->type_flags & DST_TYPE_HAS_OBS_REGS)
+                                dst_set_inversion(state, p->inversion);
+                        dst_set_fec(state, p->u.qpsk.fec_inner);
+                        dst_set_symbolrate(state, p->u.qpsk.symbol_rate);
+                        dst_set_polarization(state);
+                        dprintk(verbose, DST_DEBUG, 1, "Set Symbolrate=[%d]", p->u.qpsk.symbol_rate);
+
+                } else if (state->dst_type == DST_TYPE_IS_TERR)
+                        dst_set_bandwidth(state, p->u.ofdm.bandwidth);
+                else if (state->dst_type == DST_TYPE_IS_CABLE) {
+                        dst_set_fec(state, p->u.qam.fec_inner);
+                        dst_set_symbolrate(state, p->u.qam.symbol_rate);
+                        dst_set_modulation(state, p->u.qam.modulation);
+                }
+                dst_write_tuna(fe);
         }
-        dst_write_tuna(fe);
 
+        if (!(mode_flags & FE_TUNE_MODE_ONESHOT))
+                dst_read_status(fe, status);
+
+        *delay = HZ/10;
         return 0;
 }
 
@@ -1445,7 +1455,7 @@ static struct dvb_frontend_ops dst_dvbt_ops = {
 
         .release = dst_release,
         .init = dst_init,
-        .set_frontend = dst_set_frontend,
+        .tune = dst_set_frontend,
         .get_frontend = dst_get_frontend,
         .read_status = dst_read_status,
         .read_signal_strength = dst_read_signal_strength,
@@ -1469,7 +1479,7 @@ static struct dvb_frontend_ops dst_dvbs_ops = {
 
         .release = dst_release,
         .init = dst_init,
-        .set_frontend = dst_set_frontend,
+        .tune = dst_set_frontend,
         .get_frontend = dst_get_frontend,
         .read_status = dst_read_status,
         .read_signal_strength = dst_read_signal_strength,
@@ -1496,7 +1506,7 @@ static struct dvb_frontend_ops dst_dvbc_ops = {
 
         .release = dst_release,
         .init = dst_init,
-        .set_frontend = dst_set_frontend,
+        .tune = dst_set_frontend,
         .get_frontend = dst_get_frontend,
         .read_status = dst_read_status,
         .read_signal_strength = dst_read_signal_strength,
diff --git a/drivers/media/dvb/bt8xx/dst_ca.c b/drivers/media/dvb/bt8xx/dst_ca.c
index 2239651969c8..c650b4bf7f5f 100644
--- a/drivers/media/dvb/bt8xx/dst_ca.c
+++ b/drivers/media/dvb/bt8xx/dst_ca.c
@@ -283,16 +283,17 @@ static int handle_dst_tag(struct dst_state *state, struct ca_msg *p_ca_message,
                 hw_buffer->msg[4] = 0x03;
                 hw_buffer->msg[5] = length & 0xff;
                 hw_buffer->msg[6] = 0x00;
+
                 /*
                  *      Need to compute length for EN50221 section 8.3.2, for the time being
                  *      assuming 8.3.2 is not applicable
                  */
                 memcpy(&hw_buffer->msg[7], &p_ca_message->msg[4], length);
         }
+
         return 0;
 }
 
-
 static int write_to_8820(struct dst_state *state, struct ca_msg *hw_buffer, u8 length, u8 reply)
 {
         if ((dst_put_ci(state, hw_buffer->msg, length, hw_buffer->msg, reply)) < 0) {
diff --git a/drivers/media/dvb/bt8xx/dvb-bt8xx.c b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
index 77977e9c013e..01b4e0aac049 100644
--- a/drivers/media/dvb/bt8xx/dvb-bt8xx.c
+++ b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
@@ -600,7 +600,6 @@ static void frontend_init(struct dvb_bt8xx_card *card, u32 type)
         struct dst_state* state = NULL;
 
         switch(type) {
-#ifdef BTTV_BOARD_DVICO_DVBT_LITE
         case BTTV_BOARD_DVICO_DVBT_LITE:
                 card->fe = mt352_attach(&thomson_dtt7579_config, card->i2c_adapter);
                 if (card->fe != NULL) {
@@ -608,22 +607,15 @@ static void frontend_init(struct dvb_bt8xx_card *card, u32 type)
                         card->fe->ops->info.frequency_max = 862000000;
                 }
                 break;
-#endif
 
-#ifdef BTTV_BOARD_DVICO_FUSIONHDTV_5_LITE
         case BTTV_BOARD_DVICO_FUSIONHDTV_5_LITE:
                 lgdt330x_reset(card);
                 card->fe = lgdt330x_attach(&tdvs_tua6034_config, card->i2c_adapter);
                 if (card->fe != NULL)
                         dprintk ("dvb_bt8xx: lgdt330x detected\n");
                 break;
-#endif
 
-#ifdef BTTV_BOARD_TWINHAN_VP3021
-        case BTTV_BOARD_TWINHAN_VP3021:
-#else
         case BTTV_BOARD_NEBULA_DIGITV:
-#endif
                 /*
                  * It is possible to determine the correct frontend using the I2C bus (see the Nebula SDK);
                  * this would be a cleaner solution than trying each frontend in turn.
@@ -812,9 +804,7 @@ static int dvb_bt8xx_probe(struct device *dev)
                 card->irq_err_ignore = 0;
                 break;
 
-#ifdef BTTV_BOARD_DVICO_DVBT_LITE
         case BTTV_BOARD_DVICO_DVBT_LITE:
-#endif
                 card->gpio_mode = 0x0400C060;
                 card->op_sync_orin = 0;
                 card->irq_err_ignore = 0;
@@ -823,19 +813,13 @@ static int dvb_bt8xx_probe(struct device *dev)
                  * DA_APP(parallel) */
                 break;
 
-#ifdef BTTV_BOARD_DVICO_FUSIONHDTV_5_LITE
         case BTTV_BOARD_DVICO_FUSIONHDTV_5_LITE:
-#endif
                 card->gpio_mode = 0x0400c060;
                 card->op_sync_orin = BT878_RISC_SYNC_MASK;
                 card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
                 break;
 
-#ifdef BTTV_BOARD_TWINHAN_VP3021
-        case BTTV_BOARD_TWINHAN_VP3021:
-#else
         case BTTV_BOARD_NEBULA_DIGITV:
-#endif
         case BTTV_BOARD_AVDVBT_761:
                 card->gpio_mode = (1 << 26) | (1 << 14) | (1 << 5);
                 card->op_sync_orin = 0;
diff --git a/drivers/media/dvb/cinergyT2/Kconfig b/drivers/media/dvb/cinergyT2/Kconfig
index 7cf4c4a888ec..6018fcdba1e6 100644
--- a/drivers/media/dvb/cinergyT2/Kconfig
+++ b/drivers/media/dvb/cinergyT2/Kconfig
@@ -21,35 +21,35 @@ config DVB_CINERGYT2_TUNING
 config DVB_CINERGYT2_STREAM_URB_COUNT
         int "Number of queued USB Request Blocks for Highspeed Stream Transfers"
         depends on DVB_CINERGYT2_TUNING
-        default "32"
+        default "32"
         help
           USB Request Blocks for Highspeed Stream transfers are scheduled in
           a queue for the Host Controller.
 
           Usually the default value is a safe choice.
 
-          You may increase this number if you are using this device in a 
-          Server Environment with many high-traffic USB Highspeed devices 
+          You may increase this number if you are using this device in a
+          Server Environment with many high-traffic USB Highspeed devices
           sharing the same USB bus.
 
 
 config DVB_CINERGYT2_STREAM_BUF_SIZE
         int "Size of URB Stream Buffers for Highspeed Transfers"
         depends on DVB_CINERGYT2_TUNING
-        default "512"
+        default "512"
         help
           Should be a multiple of native buffer size of 512 bytes.
           Default value is a safe choice.
 
-          You may increase this number if you are using this device in a 
-          Server Environment with many high-traffic USB Highspeed devices 
+          You may increase this number if you are using this device in a
+          Server Environment with many high-traffic USB Highspeed devices
           sharing the same USB bus.
 
 
 config DVB_CINERGYT2_QUERY_INTERVAL
         int "Status update interval [milliseconds]"
         depends on DVB_CINERGYT2_TUNING
-        default "250"
+        default "250"
         help
           This is the interval for status readouts from the demodulator.
           You may try lower values if you need more responsive signal quality
@@ -64,9 +64,9 @@ config DVB_CINERGYT2_QUERY_INTERVAL
 config DVB_CINERGYT2_ENABLE_RC_INPUT_DEVICE
         bool "Register the onboard IR Remote Control Receiver as Input Device"
         depends on DVB_CINERGYT2_TUNING
-        default "yes"
+        default "yes"
         help
-          Enable this option if you want to use the onboard Infrared Remote 
+          Enable this option if you want to use the onboard Infrared Remote
           Control Receiver as Linux-Input device.
 
           Right now only the keycode table for the default Remote Control
@@ -77,7 +77,7 @@ config DVB_CINERGYT2_ENABLE_RC_INPUT_DEVICE
 config DVB_CINERGYT2_RC_QUERY_INTERVAL
         int "Infrared Remote Controller update interval [milliseconds]"
         depends on DVB_CINERGYT2_TUNING && DVB_CINERGYT2_ENABLE_RC_INPUT_DEVICE
-        default "50"
+        default "50"
         help
           If you have a very fast-repeating remote control you can try lower
           values, for normal consumer receivers the default value should be
diff --git a/drivers/media/dvb/cinergyT2/cinergyT2.c b/drivers/media/dvb/cinergyT2/cinergyT2.c
index 1d69bf031fb9..c4b4c5b6b7c8 100644
--- a/drivers/media/dvb/cinergyT2/cinergyT2.c
+++ b/drivers/media/dvb/cinergyT2/cinergyT2.c
@@ -131,6 +131,8 @@ struct cinergyt2 {
 
         wait_queue_head_t poll_wq;
         int pending_fe_events;
+        int disconnect_pending;
+        atomic_t inuse;
 
         void *streambuf;
         dma_addr_t streambuf_dmahandle;
@@ -343,7 +345,7 @@ static int cinergyt2_start_feed(struct dvb_demux_feed *dvbdmxfeed)
         struct dvb_demux *demux = dvbdmxfeed->demux;
         struct cinergyt2 *cinergyt2 = demux->priv;
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return -ERESTARTSYS;
 
         if (cinergyt2->streaming == 0)
@@ -359,7 +361,7 @@ static int cinergyt2_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
         struct dvb_demux *demux = dvbdmxfeed->demux;
         struct cinergyt2 *cinergyt2 = demux->priv;
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return -ERESTARTSYS;
 
         if (--cinergyt2->streaming == 0)
@@ -479,23 +481,37 @@ static int cinergyt2_open (struct inode *inode, struct file *file)
 {
         struct dvb_device *dvbdev = file->private_data;
         struct cinergyt2 *cinergyt2 = dvbdev->priv;
-        int err;
+        int err = -ERESTARTSYS;
 
-        if ((err = dvb_generic_open(inode, file)))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
+                return -ERESTARTSYS;
+
+        if ((err = dvb_generic_open(inode, file))) {
+                up(&cinergyt2->sem);
                 return err;
+        }
 
-        if (down_interruptible(&cinergyt2->sem))
-                return -ERESTARTSYS;
 
         if ((file->f_flags & O_ACCMODE) != O_RDONLY) {
                 cinergyt2_sleep(cinergyt2, 0);
                 schedule_delayed_work(&cinergyt2->query_work, HZ/2);
         }
 
+        atomic_inc(&cinergyt2->inuse);
+
         up(&cinergyt2->sem);
         return 0;
 }
 
+static void cinergyt2_unregister(struct cinergyt2 *cinergyt2)
+{
+        dvb_unregister_device(cinergyt2->fedev);
+        dvb_unregister_adapter(&cinergyt2->adapter);
+
+        cinergyt2_free_stream_urbs(cinergyt2);
+        kfree(cinergyt2);
+}
+
 static int cinergyt2_release (struct inode *inode, struct file *file)
 {
         struct dvb_device *dvbdev = file->private_data;
@@ -504,7 +520,7 @@ static int cinergyt2_release (struct inode *inode, struct file *file)
         if (down_interruptible(&cinergyt2->sem))
                 return -ERESTARTSYS;
 
-        if ((file->f_flags & O_ACCMODE) != O_RDONLY) {
+        if (!cinergyt2->disconnect_pending && (file->f_flags & O_ACCMODE) != O_RDONLY) {
                 cancel_delayed_work(&cinergyt2->query_work);
                 flush_scheduled_work();
                 cinergyt2_sleep(cinergyt2, 1);
@@ -512,6 +528,11 @@ static int cinergyt2_release (struct inode *inode, struct file *file)
 
         up(&cinergyt2->sem);
 
+        if (atomic_dec_and_test(&cinergyt2->inuse) && cinergyt2->disconnect_pending) {
+                warn("delayed unregister in release");
+                cinergyt2_unregister(cinergyt2);
+        }
+
         return dvb_generic_release(inode, file);
 }
 
@@ -519,7 +540,14 @@ static unsigned int cinergyt2_poll (struct file *file, struct poll_table_struct
 {
         struct dvb_device *dvbdev = file->private_data;
         struct cinergyt2 *cinergyt2 = dvbdev->priv;
+
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
+                return -ERESTARTSYS;
+
         poll_wait(file, &cinergyt2->poll_wq, wait);
+
+        up(&cinergyt2->sem);
+
         return (POLLIN | POLLRDNORM | POLLPRI);
 }
 
@@ -564,10 +592,15 @@ static int cinergyt2_ioctl (struct inode *inode, struct file *file,
                                 (__u16 __user *) arg);
 
         case FE_READ_UNCORRECTED_BLOCKS:
-                /* UNC are already converted to host byte order... */
-                return put_user(stat->uncorrected_block_count,
-                                (__u32 __user *) arg);
+        {
+                uint32_t unc_count;
+
+                unc_count = stat->uncorrected_block_count;
+                stat->uncorrected_block_count = 0;
 
+                /* UNC are already converted to host byte order... */
+                return put_user(unc_count,(__u32 __user *) arg);
+        }
         case FE_SET_FRONTEND:
         {
                 struct dvbt_set_parameters_msg *param = &cinergyt2->param;
@@ -580,7 +613,7 @@ static int cinergyt2_ioctl (struct inode *inode, struct file *file,
                 if (copy_from_user(&p, (void  __user*) arg, sizeof(p)))
                         return -EFAULT;
 
-                if (down_interruptible(&cinergyt2->sem))
+                if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                         return -ERESTARTSYS;
 
                 param->cmd = CINERGYT2_EP1_SET_TUNER_PARAMETERS;
@@ -691,7 +724,7 @@ static void cinergyt2_query_rc (void *data)
         struct cinergyt2_rc_event rc_events[12];
         int n, len, i;
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return;
 
         len = cinergyt2_command(cinergyt2, buf, sizeof(buf),
@@ -786,7 +819,6 @@ static int cinergyt2_register_rc(struct cinergyt2 *cinergyt2)
 static void cinergyt2_unregister_rc(struct cinergyt2 *cinergyt2)
 {
         cancel_delayed_work(&cinergyt2->rc_query_work);
-        flush_scheduled_work();
         input_unregister_device(cinergyt2->rc_input_dev);
 }
 
@@ -817,7 +849,7 @@ static void cinergyt2_query (void *data)
         uint8_t lock_bits;
         uint32_t unc;
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return;
 
         unc = s->uncorrected_block_count;
@@ -917,28 +949,25 @@ static void cinergyt2_disconnect (struct usb_interface *intf)
 {
         struct cinergyt2 *cinergyt2 = usb_get_intfdata (intf);
 
-        if (down_interruptible(&cinergyt2->sem))
-                return;
+        flush_scheduled_work();
 
         cinergyt2_unregister_rc(cinergyt2);
 
+        cancel_delayed_work(&cinergyt2->query_work);
+        wake_up_interruptible(&cinergyt2->poll_wq);
+
         cinergyt2->demux.dmx.close(&cinergyt2->demux.dmx);
-        dvb_net_release(&cinergyt2->dvbnet);
-        dvb_dmxdev_release(&cinergyt2->dmxdev);
-        dvb_dmx_release(&cinergyt2->demux);
-        dvb_unregister_device(cinergyt2->fedev);
-        dvb_unregister_adapter(&cinergyt2->adapter);
+        cinergyt2->disconnect_pending = 1;
 
-        cinergyt2_free_stream_urbs(cinergyt2);
-        up(&cinergyt2->sem);
-        kfree(cinergyt2);
+        if (!atomic_read(&cinergyt2->inuse))
+                cinergyt2_unregister(cinergyt2);
 }
 
 static int cinergyt2_suspend (struct usb_interface *intf, pm_message_t state)
 {
         struct cinergyt2 *cinergyt2 = usb_get_intfdata (intf);
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return -ERESTARTSYS;
 
         if (state.event > PM_EVENT_ON) {
@@ -961,7 +990,7 @@ static int cinergyt2_resume (struct usb_interface *intf)
         struct cinergyt2 *cinergyt2 = usb_get_intfdata (intf);
         struct dvbt_set_parameters_msg *param = &cinergyt2->param;
 
-        if (down_interruptible(&cinergyt2->sem))
+        if (cinergyt2->disconnect_pending || down_interruptible(&cinergyt2->sem))
                 return -ERESTARTSYS;
 
         if (!cinergyt2->sleeping) {
@@ -1014,4 +1043,3 @@ module_exit (cinergyt2_exit);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Holger Waechtler, Daniel Mack");
-
diff --git a/drivers/media/dvb/dvb-core/Kconfig b/drivers/media/dvb/dvb-core/Kconfig
index a9a7b3421048..12ee912a5705 100644
--- a/drivers/media/dvb/dvb-core/Kconfig
+++ b/drivers/media/dvb/dvb-core/Kconfig
@@ -5,7 +5,7 @@ config DVB_CORE
         help
           DVB core utility functions for device handling, software fallbacks etc.
           Say Y when you have a DVB card and want to use it. Say Y if your want
-          to build your drivers outside the kernel, but need the DVB core. All 
+          to build your drivers outside the kernel, but need the DVB core. All
           in-kernel drivers will select this automatically if needed.
           If unsure say N.
 
diff --git a/drivers/media/dvb/dvb-core/Makefile b/drivers/media/dvb/dvb-core/Makefile
index c6baac20f529..7adb50c1e8eb 100644
--- a/drivers/media/dvb/dvb-core/Makefile
+++ b/drivers/media/dvb/dvb-core/Makefile
@@ -3,7 +3,7 @@
 #
 
 dvb-core-objs = dvbdev.o dmxdev.o dvb_demux.o dvb_filter.o \
-                dvb_ca_en50221.o dvb_frontend.o \
+                dvb_ca_en50221.o dvb_frontend.o \
                 dvb_net.o dvb_ringbuffer.o
 
 obj-$(CONFIG_DVB_CORE) += dvb-core.o
diff --git a/drivers/media/dvb/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb/dvb-core/dvb_ca_en50221.c
index 5956c35d34ac..4bb779aeff6a 100644
--- a/drivers/media/dvb/dvb-core/dvb_ca_en50221.c
+++ b/drivers/media/dvb/dvb-core/dvb_ca_en50221.c
@@ -1745,9 +1745,7 @@ void dvb_ca_en50221_release(struct dvb_ca_en50221 *pubca)
 
         for (i = 0; i < ca->slot_count; i++) {
                 dvb_ca_en50221_slot_shutdown(ca, i);
-                if (ca->slot_info[i].rx_buffer.data != NULL) {
-                        vfree(ca->slot_info[i].rx_buffer.data);
-                }
+                vfree(ca->slot_info[i].rx_buffer.data);
         }
         kfree(ca->slot_info);
         dvb_unregister_device(ca->dvbdev);
diff --git a/drivers/media/dvb/dvb-core/dvb_filter.c b/drivers/media/dvb/dvb-core/dvb_filter.c
index c49fd0bd7181..772003fb1821 100644
--- a/drivers/media/dvb/dvb-core/dvb_filter.c
+++ b/drivers/media/dvb/dvb-core/dvb_filter.c
@@ -409,16 +409,16 @@ static u8 *skip_pes_header(u8 **bufp)
 
         if ((inbuf[6] & 0xc0) == 0x80){ /* mpeg2 */
                 if (buf[7] & PTS_ONLY)
-                        pts = buf+9;
+                        pts = buf+9;
                 else pts = NULL;
                 buf = inbuf + 9 + inbuf[8];
         } else {        /* mpeg1 */
                 for (buf = inbuf + 6; *buf == 0xff; buf++)
-                        if (buf == inbuf + 6 + 16) {
-                                break;
-                        }
+                        if (buf == inbuf + 6 + 16) {
+                                break;
+                        }
                 if ((*buf & 0xc0) == 0x40)
-                        buf += 2;
+                        buf += 2;
                 skip = mpeg1_skip_table [*buf >> 4];
                 if (skip == 5 || skip == 10) pts = buf;
                 else pts = NULL;
@@ -529,9 +529,9 @@ static void init_mpg_picture( struct mpg_picture *pic, int chan, int32_t field_t
         pic->picture_header = 0;
         pic->sequence_header_data
                 = ( INIT_HORIZONTAL_SIZE << 20 )
-                        | ( INIT_VERTICAL_SIZE << 8 )
-                        | ( INIT_ASPECT_RATIO << 4 )
-                        | ( INIT_FRAME_RATE );
+                        | ( INIT_VERTICAL_SIZE << 8 )
+                        | ( INIT_ASPECT_RATIO << 4 )
+                        | ( INIT_FRAME_RATE );
         pic->mpeg1_flag = 0;
         pic->vinfo.horizontal_size
                 = INIT_DISP_HORIZONTAL_SIZE;
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 95ea5095e07e..4a08c4ab6730 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -92,6 +92,7 @@ static DECLARE_MUTEX(frontend_mutex);
 
 struct dvb_frontend_private {
 
+        /* thread/frontend values */
         struct dvb_device *dvbdev;
         struct dvb_frontend_parameters parameters;
         struct dvb_fe_events events;
@@ -100,20 +101,25 @@ struct dvb_frontend_private {
         wait_queue_head_t wait_queue;
         pid_t thread_pid;
         unsigned long release_jiffies;
-        int state;
-        int bending;
-        int lnb_drift;
-        int inversion;
-        int auto_step;
-        int auto_sub_step;
-        int started_auto_step;
-        int min_delay;
-        int max_drift;
-        int step_size;
-        int exit;
-        int wakeup;
+        unsigned int exit;
+        unsigned int wakeup;
         fe_status_t status;
-        fe_sec_tone_mode_t tone;
+        unsigned long tune_mode_flags;
+        unsigned int delay;
+
+        /* swzigzag values */
+        unsigned int state;
+        unsigned int bending;
+        int lnb_drift;
+        unsigned int inversion;
+        unsigned int auto_step;
+        unsigned int auto_sub_step;
+        unsigned int started_auto_step;
+        unsigned int min_delay;
+        unsigned int max_drift;
+        unsigned int step_size;
+        int quality;
+        unsigned int check_wrapped;
 };
 
 
@@ -208,21 +214,21 @@ static void dvb_frontend_init(struct dvb_frontend *fe)
                 fe->ops->init(fe);
 }
 
-static void update_delay(int *quality, int *delay, int min_delay, int locked)
+static void dvb_frontend_swzigzag_update_delay(struct dvb_frontend_private *fepriv, int locked)
 {
-            int q2;
+        int q2;
 
-            dprintk ("%s\n", __FUNCTION__);
+        dprintk ("%s\n", __FUNCTION__);
 
-            if (locked)
-                      (*quality) = (*quality * 220 + 36*256) / 256;
-            else
-                      (*quality) = (*quality * 220 + 0) / 256;
+        if (locked)
+                (fepriv->quality) = (fepriv->quality * 220 + 36*256) / 256;
+        else
+                (fepriv->quality) = (fepriv->quality * 220 + 0) / 256;
 
-            q2 = *quality - 128;
-            q2 *= q2;
+        q2 = fepriv->quality - 128;
+        q2 *= q2;
 
-            *delay = min_delay + q2 * HZ / (128*128);
+        fepriv->delay = fepriv->min_delay + q2 * HZ / (128*128);
 }
 
 /**
@@ -232,7 +238,7 @@ static void update_delay(int *quality, int *delay, int min_delay, int locked)
  * @param check_wrapped Checks if an iteration has completed. DO NOT SET ON THE FIRST ATTEMPT
  * @returns Number of complete iterations that have been performed.
  */
-static int dvb_frontend_autotune(struct dvb_frontend *fe, int check_wrapped)
+static int dvb_frontend_swzigzag_autotune(struct dvb_frontend *fe, int check_wrapped)
 {
         int autoinversion;
         int ready = 0;
@@ -321,6 +327,129 @@ static int dvb_frontend_autotune(struct dvb_frontend *fe, int check_wrapped)
         return 0;
 }
 
+static void dvb_frontend_swzigzag(struct dvb_frontend *fe)
+{
+        fe_status_t s;
+        struct dvb_frontend_private *fepriv = fe->frontend_priv;
+
+        /* if we've got no parameters, just keep idling */
+        if (fepriv->state & FESTATE_IDLE) {
+                fepriv->delay = 3*HZ;
+                fepriv->quality = 0;
+                return;
+        }
+
+        /* in SCAN mode, we just set the frontend when asked and leave it alone */
+        if (fepriv->tune_mode_flags & FE_TUNE_MODE_ONESHOT) {
+                if (fepriv->state & FESTATE_RETUNE) {
+                        if (fe->ops->set_frontend)
+                                fe->ops->set_frontend(fe, &fepriv->parameters);
+                        fepriv->state = FESTATE_TUNED;
+                }
+                fepriv->delay = 3*HZ;
+                fepriv->quality = 0;
+                return;
+        }
+
+        /* get the frontend status */
+        if (fepriv->state & FESTATE_RETUNE) {
+                s = 0;
+        } else {
+                if (fe->ops->read_status)
+                        fe->ops->read_status(fe, &s);
+                if (s != fepriv->status) {
+                        dvb_frontend_add_event(fe, s);
+                        fepriv->status = s;
+                }
+        }
+
+        /* if we're not tuned, and we have a lock, move to the TUNED state */
+        if ((fepriv->state & FESTATE_WAITFORLOCK) && (s & FE_HAS_LOCK)) {
+                dvb_frontend_swzigzag_update_delay(fepriv, s & FE_HAS_LOCK);
+                fepriv->state = FESTATE_TUNED;
+
+                /* if we're tuned, then we have determined the correct inversion */
+                if ((!(fe->ops->info.caps & FE_CAN_INVERSION_AUTO)) &&
+                    (fepriv->parameters.inversion == INVERSION_AUTO)) {
+                        fepriv->parameters.inversion = fepriv->inversion;
+                }
+                return;
+        }
+
+        /* if we are tuned already, check we're still locked */
+        if (fepriv->state & FESTATE_TUNED) {
+                dvb_frontend_swzigzag_update_delay(fepriv, s & FE_HAS_LOCK);
+
+                /* we're tuned, and the lock is still good... */
+                if (s & FE_HAS_LOCK) {
+                        return;
+                } else { /* if we _WERE_ tuned, but now don't have a lock */
+                        fepriv->state = FESTATE_ZIGZAG_FAST;
+                        fepriv->started_auto_step = fepriv->auto_step;
+                        fepriv->check_wrapped = 0;
+                }
+        }
+
+        /* don't actually do anything if we're in the LOSTLOCK state,
+         * the frontend is set to FE_CAN_RECOVER, and the max_drift is 0 */
+        if ((fepriv->state & FESTATE_LOSTLOCK) &&
+            (fe->ops->info.caps & FE_CAN_RECOVER) && (fepriv->max_drift == 0)) {
+                dvb_frontend_swzigzag_update_delay(fepriv, s & FE_HAS_LOCK);
+                return;
+        }
+
+        /* don't do anything if we're in the DISEQC state, since this
+         * might be someone with a motorized dish controlled by DISEQC.
+         * If its actually a re-tune, there will be a SET_FRONTEND soon enough. */
+        if (fepriv->state & FESTATE_DISEQC) {
+                dvb_frontend_swzigzag_update_delay(fepriv, s & FE_HAS_LOCK);
+                return;
+        }
+
+        /* if we're in the RETUNE state, set everything up for a brand
+         * new scan, keeping the current inversion setting, as the next
+         * tune is _very_ likely to require the same */
+        if (fepriv->state & FESTATE_RETUNE) {
+                fepriv->lnb_drift = 0;
+                fepriv->auto_step = 0;
+                fepriv->auto_sub_step = 0;
+                fepriv->started_auto_step = 0;
+                fepriv->check_wrapped = 0;
+        }
+
+        /* fast zigzag. */
+        if ((fepriv->state & FESTATE_SEARCHING_FAST) || (fepriv->state & FESTATE_RETUNE)) {
+                fepriv->delay = fepriv->min_delay;
+
+                /* peform a tune */
+                if (dvb_frontend_swzigzag_autotune(fe, fepriv->check_wrapped)) {
+                        /* OK, if we've run out of trials at the fast speed.
+                         * Drop back to slow for the _next_ attempt */
+                        fepriv->state = FESTATE_SEARCHING_SLOW;
+                        fepriv->started_auto_step = fepriv->auto_step;
+                        return;
+                }
+                fepriv->check_wrapped = 1;
+
+                /* if we've just retuned, enter the ZIGZAG_FAST state.
+                 * This ensures we cannot return from an
+                 * FE_SET_FRONTEND ioctl before the first frontend tune
+                 * occurs */
+                if (fepriv->state & FESTATE_RETUNE) {
+                        fepriv->state = FESTATE_TUNING_FAST;
+                }
+        }
+
+        /* slow zigzag */
+        if (fepriv->state & FESTATE_SEARCHING_SLOW) {
+                dvb_frontend_swzigzag_update_delay(fepriv, s & FE_HAS_LOCK);
+
+                /* Note: don't bother checking for wrapping; we stay in this
+                 * state until we get a lock */
+                dvb_frontend_swzigzag_autotune(fe, 0);
+        }
+}
+
 static int dvb_frontend_is_exiting(struct dvb_frontend *fe)
 {
         struct dvb_frontend_private *fepriv = fe->frontend_priv;
@@ -330,7 +459,7 @@ static int dvb_frontend_is_exiting(struct dvb_frontend *fe)
 
         if (fepriv->dvbdev->writers == 1)
                 if (time_after(jiffies, fepriv->release_jiffies +
-                                        dvb_shutdown_timeout * HZ))
+                                  dvb_shutdown_timeout * HZ))
                         return 1;
 
         return 0;
@@ -355,18 +484,14 @@ static void dvb_frontend_wakeup(struct dvb_frontend *fe)
         wake_up_interruptible(&fepriv->wait_queue);
 }
 
-/*
- * FIXME: use linux/kthread.h
- */
 static int dvb_frontend_thread(void *data)
 {
         struct dvb_frontend *fe = data;
         struct dvb_frontend_private *fepriv = fe->frontend_priv;
         unsigned long timeout;
         char name [15];
-        int quality = 0, delay = 3*HZ;
         fe_status_t s;
-        int check_wrapped = 0;
+        struct dvb_frontend_parameters *params;
 
         dprintk("%s\n", __FUNCTION__);
 
@@ -377,6 +502,9 @@ static int dvb_frontend_thread(void *data)
         sigfillset(&current->blocked);
         unlock_kernel();
 
+        fepriv->check_wrapped = 0;
+        fepriv->quality = 0;
+        fepriv->delay = 3*HZ;
         fepriv->status = 0;
         dvb_frontend_init(fe);
         fepriv->wakeup = 0;
@@ -386,7 +514,7 @@ static int dvb_frontend_thread(void *data)
 
                 timeout = wait_event_interruptible_timeout(fepriv->wait_queue,
                                                            dvb_frontend_should_wakeup(fe),
-                                                           delay);
+                                                           fepriv->delay);
                 if (0 != dvb_frontend_is_exiting(fe)) {
                         /* got signal or quitting */
                         break;
@@ -397,108 +525,22 @@ static int dvb_frontend_thread(void *data)
                 if (down_interruptible(&fepriv->sem))
                         break;
 
-                /* if we've got no parameters, just keep idling */
-                if (fepriv->state & FESTATE_IDLE) {
-                        delay = 3*HZ;
-                        quality = 0;
-                        continue;
-                }
+                /* do an iteration of the tuning loop */
+                if (fe->ops->tune) {
+                        /* have we been asked to retune? */
+                        params = NULL;
+                        if (fepriv->state & FESTATE_RETUNE) {
+                                params = &fepriv->parameters;
+                                fepriv->state = FESTATE_TUNED;
+                        }
 
-                /* get the frontend status */
-                if (fepriv->state & FESTATE_RETUNE) {
-                        s = 0;
-                } else {
-                        if (fe->ops->read_status)
-                                fe->ops->read_status(fe, &s);
+                        fe->ops->tune(fe, params, fepriv->tune_mode_flags, &fepriv->delay, &s);
                         if (s != fepriv->status) {
                                 dvb_frontend_add_event(fe, s);
                                 fepriv->status = s;
                         }
-                }
-                /* if we're not tuned, and we have a lock, move to the TUNED state */
-                if ((fepriv->state & FESTATE_WAITFORLOCK) && (s & FE_HAS_LOCK)) {
-                        update_delay(&quality, &delay, fepriv->min_delay, s & FE_HAS_LOCK);
-                        fepriv->state = FESTATE_TUNED;
-
-                        /* if we're tuned, then we have determined the correct inversion */
-                        if ((!(fe->ops->info.caps & FE_CAN_INVERSION_AUTO)) &&
-                            (fepriv->parameters.inversion == INVERSION_AUTO)) {
-                                fepriv->parameters.inversion = fepriv->inversion;
-                        }
-                        continue;
-                }
-
-                /* if we are tuned already, check we're still locked */
-                if (fepriv->state & FESTATE_TUNED) {
-                        update_delay(&quality, &delay, fepriv->min_delay, s & FE_HAS_LOCK);
-
-                        /* we're tuned, and the lock is still good... */
-                        if (s & FE_HAS_LOCK)
-                                continue;
-                        else { /* if we _WERE_ tuned, but now don't have a lock */
-                                fepriv->state = FESTATE_ZIGZAG_FAST;
-                                fepriv->started_auto_step = fepriv->auto_step;
-                                check_wrapped = 0;
-                        }
-                }
-
-                /* don't actually do anything if we're in the LOSTLOCK state,
-                 * the frontend is set to FE_CAN_RECOVER, and the max_drift is 0 */
-                if ((fepriv->state & FESTATE_LOSTLOCK) &&
-                    (fe->ops->info.caps & FE_CAN_RECOVER) && (fepriv->max_drift == 0)) {
-                        update_delay(&quality, &delay, fepriv->min_delay, s & FE_HAS_LOCK);
-                        continue;
-                }
-
-                /* don't do anything if we're in the DISEQC state, since this
-                 * might be someone with a motorized dish controlled by DISEQC.
-                 * If its actually a re-tune, there will be a SET_FRONTEND soon enough. */
-                if (fepriv->state & FESTATE_DISEQC) {
-                        update_delay(&quality, &delay, fepriv->min_delay, s & FE_HAS_LOCK);
-                        continue;
-                }
-
-                /* if we're in the RETUNE state, set everything up for a brand
-                 * new scan, keeping the current inversion setting, as the next
-                 * tune is _very_ likely to require the same */
-                if (fepriv->state & FESTATE_RETUNE) {
-                        fepriv->lnb_drift = 0;
-                        fepriv->auto_step = 0;
-                        fepriv->auto_sub_step = 0;
-                        fepriv->started_auto_step = 0;
-                        check_wrapped = 0;
-                }
-
-                /* fast zigzag. */
-                if ((fepriv->state & FESTATE_SEARCHING_FAST) || (fepriv->state & FESTATE_RETUNE)) {
-                        delay = fepriv->min_delay;
-
-                        /* peform a tune */
-                        if (dvb_frontend_autotune(fe, check_wrapped)) {
-                                /* OK, if we've run out of trials at the fast speed.
-                                 * Drop back to slow for the _next_ attempt */
-                                fepriv->state = FESTATE_SEARCHING_SLOW;
-                                fepriv->started_auto_step = fepriv->auto_step;
-                                continue;
-                        }
-                        check_wrapped = 1;
-
-                        /* if we've just retuned, enter the ZIGZAG_FAST state.
-                         * This ensures we cannot return from an
-                         * FE_SET_FRONTEND ioctl before the first frontend tune
-                         * occurs */
-                        if (fepriv->state & FESTATE_RETUNE) {
-                                fepriv->state = FESTATE_TUNING_FAST;
-                        }
-                }
-
-                /* slow zigzag */
-                if (fepriv->state & FESTATE_SEARCHING_SLOW) {
-                        update_delay(&quality, &delay, fepriv->min_delay, s & FE_HAS_LOCK);
-
-                        /* Note: don't bother checking for wrapping; we stay in this
-                         * state until we get a lock */
-                        dvb_frontend_autotune(fe, 0);
+                } else {
+                        dvb_frontend_swzigzag(fe);
                 }
         }
 
@@ -733,7 +775,6 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
                         err = fe->ops->set_tone(fe, (fe_sec_tone_mode_t) parg);
                         fepriv->state = FESTATE_DISEQC;
                         fepriv->status = 0;
-                        fepriv->tone = (fe_sec_tone_mode_t) parg;
                 }
                 break;
 
@@ -747,7 +788,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
 
         case FE_DISHNETWORK_SEND_LEGACY_CMD:
                 if (fe->ops->dishnetwork_send_legacy_command) {
-                        err = fe->ops->dishnetwork_send_legacy_command(fe, (unsigned int) parg);
+                        err = fe->ops->dishnetwork_send_legacy_command(fe, (unsigned long) parg);
                         fepriv->state = FESTATE_DISEQC;
                         fepriv->status = 0;
                 } else if (fe->ops->set_voltage) {
@@ -767,13 +808,13 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
                          * initialization, so parg is 8 bits and does not
                          * include the initialization or start bit
                          */
-                        unsigned int cmd = ((unsigned int) parg) << 1;
+                        unsigned long cmd = ((unsigned long) parg) << 1;
                         struct timeval nexttime;
                         struct timeval tv[10];
                         int i;
                         u8 last = 1;
                         if (dvb_frontend_debug)
-                                printk("%s switch command: 0x%04x\n", __FUNCTION__, cmd);
+                                printk("%s switch command: 0x%04lx\n", __FUNCTION__, cmd);
                         do_gettimeofday(&nexttime);
                         if (dvb_frontend_debug)
                                 memcpy(&tv[0], &nexttime, sizeof(struct timeval));
@@ -814,7 +855,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
 
         case FE_ENABLE_HIGH_LNB_VOLTAGE:
                 if (fe->ops->enable_high_lnb_voltage)
-                        err = fe->ops->enable_high_lnb_voltage(fe, (int) parg);
+                        err = fe->ops->enable_high_lnb_voltage(fe, (long) parg);
                 break;
 
         case FE_SET_FRONTEND: {
@@ -891,6 +932,10 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
                         err = fe->ops->get_frontend(fe, (struct dvb_frontend_parameters*) parg);
                 }
                 break;
+
+        case FE_SET_FRONTEND_TUNE_MODE:
+                fepriv->tune_mode_flags = (unsigned long) parg;
+                break;
         };
 
         up (&fepriv->sem);
@@ -932,6 +977,9 @@ static int dvb_frontend_open(struct inode *inode, struct file *file)
 
                 /*  empty event queue */
                 fepriv->events.eventr = fepriv->events.eventw = 0;
+
+                /* normal tune mode when opened R/W */
+                fepriv->tune_mode_flags &= ~FE_TUNE_MODE_ONESHOT;
         }
 
         return ret;
@@ -990,7 +1038,6 @@ int dvb_register_frontend(struct dvb_adapter* dvb,
         init_MUTEX (&fepriv->events.sem);
         fe->dvb = dvb;
         fepriv->inversion = INVERSION_OFF;
-        fepriv->tone = SEC_TONE_OFF;
 
         printk ("DVB: registering frontend %i (%s)...\n",
                 fe->dvb->num,
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.h b/drivers/media/dvb/dvb-core/dvb_frontend.h
index 1e0840d02f1f..70a6d14efda7 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.h
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.h
@@ -58,10 +58,19 @@ struct dvb_frontend_ops {
         int (*init)(struct dvb_frontend* fe);
         int (*sleep)(struct dvb_frontend* fe);
 
+        /* if this is set, it overrides the default swzigzag */
+        int (*tune)(struct dvb_frontend* fe,
+                    struct dvb_frontend_parameters* params,
+                    unsigned int mode_flags,
+                    int *delay,
+                    fe_status_t *status);
+
+        /* these two are only used for the swzigzag code */
         int (*set_frontend)(struct dvb_frontend* fe, struct dvb_frontend_parameters* params);
-        int (*get_frontend)(struct dvb_frontend* fe, struct dvb_frontend_parameters* params);
         int (*get_tune_settings)(struct dvb_frontend* fe, struct dvb_frontend_tune_settings* settings);
 
+        int (*get_frontend)(struct dvb_frontend* fe, struct dvb_frontend_parameters* params);
+
         int (*read_status)(struct dvb_frontend* fe, fe_status_t* status);
         int (*read_ber)(struct dvb_frontend* fe, u32* ber);
         int (*read_signal_strength)(struct dvb_frontend* fe, u16* strength);
@@ -74,8 +83,9 @@ struct dvb_frontend_ops {
         int (*diseqc_send_burst)(struct dvb_frontend* fe, fe_sec_mini_cmd_t minicmd);
         int (*set_tone)(struct dvb_frontend* fe, fe_sec_tone_mode_t tone);
         int (*set_voltage)(struct dvb_frontend* fe, fe_sec_voltage_t voltage);
-        int (*enable_high_lnb_voltage)(struct dvb_frontend* fe, int arg);
-        int (*dishnetwork_send_legacy_command)(struct dvb_frontend* fe, unsigned int cmd);
+        int (*enable_high_lnb_voltage)(struct dvb_frontend* fe, long arg);
+        int (*dishnetwork_send_legacy_command)(struct dvb_frontend* fe, unsigned long cmd);
+        int (*i2c_gate_ctrl)(struct dvb_frontend* fe, int enable);
 };
 
 #define MAX_EVENT 8
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index 86bba81e851e..6711eb6a058c 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -1222,7 +1222,7 @@ static int dvb_net_add_if(struct dvb_net *dvbnet, u16 pid, u8 feedtype)
         return if_num;
 }
 
-static int dvb_net_remove_if(struct dvb_net *dvbnet, unsigned int num)
+static int dvb_net_remove_if(struct dvb_net *dvbnet, unsigned long num)
 {
         struct net_device *net = dvbnet->device[num];
         struct dvb_net_priv *priv;
@@ -1296,9 +1296,9 @@ static int dvb_net_do_ioctl(struct inode *inode, struct file *file,
 
                 if (!capable(CAP_SYS_ADMIN))
                         return -EPERM;
-                if ((unsigned int) parg >= DVB_NET_DEVICES_MAX)
+                if ((unsigned long) parg >= DVB_NET_DEVICES_MAX)
                         return -EINVAL;
-                ret = dvb_net_remove_if(dvbnet, (unsigned int) parg);
+                ret = dvb_net_remove_if(dvbnet, (unsigned long) parg);
                 if (!ret)
                         module_put(dvbdev->adapter->module);
                 return ret;
diff --git a/drivers/media/dvb/dvb-core/dvb_ringbuffer.c b/drivers/media/dvb/dvb-core/dvb_ringbuffer.c
index 283c6e9339a4..77ad2410f4d3 100644
--- a/drivers/media/dvb/dvb-core/dvb_ringbuffer.c
+++ b/drivers/media/dvb/dvb-core/dvb_ringbuffer.c
@@ -112,10 +112,10 @@ ssize_t dvb_ringbuffer_read(struct dvb_ringbuffer *rbuf, u8 *buf, size_t len, in
         split = (rbuf->pread + len > rbuf->size) ? rbuf->size - rbuf->pread : 0;
         if (split > 0) {
                 if (!usermem)
-                        memcpy(buf, rbuf->data+rbuf->pread, split);
+                        memcpy(buf, rbuf->data+rbuf->pread, split);
                 else
-                        if (copy_to_user(buf, rbuf->data+rbuf->pread, split))
-                                return -EFAULT;
+                        if (copy_to_user(buf, rbuf->data+rbuf->pread, split))
+                                return -EFAULT;
                 buf += split;
                 todo -= split;
                 rbuf->pread = 0;
@@ -124,7 +124,7 @@ ssize_t dvb_ringbuffer_read(struct dvb_ringbuffer *rbuf, u8 *buf, size_t len, in
                 memcpy(buf, rbuf->data+rbuf->pread, todo);
         else
                 if (copy_to_user(buf, rbuf->data+rbuf->pread, todo))
-                        return -EFAULT;
+                        return -EFAULT;
 
         rbuf->pread = (rbuf->pread + todo) % rbuf->size;
 
@@ -167,7 +167,7 @@ ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer *rbuf, u8* buf, size_t le
 }
 
 ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer *rbuf, size_t idx,
-                                int offset, u8* buf, size_t len, int usermem)
+                                int offset, u8* buf, size_t len, int usermem)
 {
         size_t todo;
         size_t split;
@@ -183,10 +183,10 @@ ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer *rbuf, size_t idx,
         split = ((idx + len) > rbuf->size) ? rbuf->size - idx : 0;
         if (split > 0) {
                 if (!usermem)
-                        memcpy(buf, rbuf->data+idx, split);
+                        memcpy(buf, rbuf->data+idx, split);
                 else
-                        if (copy_to_user(buf, rbuf->data+idx, split))
-                                return -EFAULT;
+                        if (copy_to_user(buf, rbuf->data+idx, split))
+                                return -EFAULT;
                 buf += split;
                 todo -= split;
                 idx = 0;
@@ -195,7 +195,7 @@ ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer *rbuf, size_t idx,
                 memcpy(buf, rbuf->data+idx, todo);
         else
                 if (copy_to_user(buf, rbuf->data+idx, todo))
-                        return -EFAULT;
+                        return -EFAULT;
 
         return len;
 }
@@ -209,12 +209,12 @@ void dvb_ringbuffer_pkt_dispose(struct dvb_ringbuffer *rbuf, size_t idx)
         // clean up disposed packets
         while(dvb_ringbuffer_avail(rbuf) > DVB_RINGBUFFER_PKTHDRSIZE) {
                 if (DVB_RINGBUFFER_PEEK(rbuf, 2) == PKT_DISPOSED) {
-                        pktlen = DVB_RINGBUFFER_PEEK(rbuf, 0) << 8;
-                        pktlen |= DVB_RINGBUFFER_PEEK(rbuf, 1);
-                        DVB_RINGBUFFER_SKIP(rbuf, pktlen + DVB_RINGBUFFER_PKTHDRSIZE);
+                        pktlen = DVB_RINGBUFFER_PEEK(rbuf, 0) << 8;
+                        pktlen |= DVB_RINGBUFFER_PEEK(rbuf, 1);
+                        DVB_RINGBUFFER_SKIP(rbuf, pktlen + DVB_RINGBUFFER_PKTHDRSIZE);
                 } else {
-                        // first packet is not disposed, so we stop cleaning now
-                        break;
+                        // first packet is not disposed, so we stop cleaning now
+                        break;
                 }
         }
 }
@@ -242,8 +242,8 @@ ssize_t dvb_ringbuffer_pkt_next(struct dvb_ringbuffer *rbuf, size_t idx, size_t*
                 curpktstatus = rbuf->data[(idx + 2) % rbuf->size];
 
                 if (curpktstatus == PKT_READY) {
-                        *pktlen = curpktlen;
-                        return idx;
+                        *pktlen = curpktlen;
+                        return idx;
                 }
 
                 consumed += curpktlen + DVB_RINGBUFFER_PKTHDRSIZE;
diff --git a/drivers/media/dvb/dvb-core/dvb_ringbuffer.h b/drivers/media/dvb/dvb-core/dvb_ringbuffer.h
index fa476f662f82..6d2560972771 100644
--- a/drivers/media/dvb/dvb-core/dvb_ringbuffer.h
+++ b/drivers/media/dvb/dvb-core/dvb_ringbuffer.h
@@ -106,7 +106,7 @@ extern void dvb_ringbuffer_flush_spinlock_wakeup(struct dvb_ringbuffer *rbuf);
 ** returns number of bytes transferred or -EFAULT
 */
 extern ssize_t dvb_ringbuffer_read(struct dvb_ringbuffer *rbuf, u8 *buf,
-                                   size_t len, int usermem);
+                                   size_t len, int usermem);
 
 
 /* write routines & macros */
@@ -121,7 +121,7 @@ extern ssize_t dvb_ringbuffer_read(struct dvb_ringbuffer *rbuf, u8 *buf,
 ** returns number of bytes transferred or -EFAULT
 */
 extern ssize_t dvb_ringbuffer_write(struct dvb_ringbuffer *rbuf, const u8 *buf,
-                                    size_t len);
+                                    size_t len);
 
 
 /**
@@ -133,7 +133,7 @@ extern ssize_t dvb_ringbuffer_write(struct dvb_ringbuffer *rbuf, const u8 *buf,
  * returns Number of bytes written, or -EFAULT, -ENOMEM, -EVINAL.
  */
 extern ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer *rbuf, u8* buf,
-                                        size_t len);
+                                        size_t len);
 
 /**
  * Read from a packet in the ringbuffer. Note: unlike dvb_ringbuffer_read(), this
@@ -149,7 +149,7 @@ extern ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer *rbuf, u8* buf,
  * returns Number of bytes read, or -EFAULT.
  */
 extern ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer *rbuf, size_t idx,
-                                       int offset, u8* buf, size_t len, int usermem);
+                                       int offset, u8* buf, size_t len, int usermem);
 
 /**
  * Dispose of a packet in the ring buffer.
diff --git a/drivers/media/dvb/dvb-core/dvbdev.c b/drivers/media/dvb/dvb-core/dvbdev.c
index a4aee8665854..06b696e9acbd 100644
--- a/drivers/media/dvb/dvb-core/dvbdev.c
+++ b/drivers/media/dvb/dvb-core/dvbdev.c
@@ -92,10 +92,10 @@ static int dvb_device_open(struct inode *inode, struct file *file)
                 old_fops = file->f_op;
                 file->f_op = fops_get(dvbdev->fops);
                 if(file->f_op->open)
-                        err = file->f_op->open(inode,file);
+                        err = file->f_op->open(inode,file);
                 if (err) {
-                        fops_put(file->f_op);
-                        file->f_op = fops_get(old_fops);
+                        fops_put(file->f_op);
+                        file->f_op = fops_get(old_fops);
                 }
                 fops_put(old_fops);
                 return err;
@@ -356,18 +356,18 @@ int dvb_usercopy(struct inode *inode, struct file *file,
         case _IOC_WRITE:
         case (_IOC_WRITE | _IOC_READ):
                 if (_IOC_SIZE(cmd) <= sizeof(sbuf)) {
-                        parg = sbuf;
+                        parg = sbuf;
                 } else {
-                        /* too big to allocate from stack */
-                        mbuf = kmalloc(_IOC_SIZE(cmd),GFP_KERNEL);
-                        if (NULL == mbuf)
-                                return -ENOMEM;
-                        parg = mbuf;
+                        /* too big to allocate from stack */
+                        mbuf = kmalloc(_IOC_SIZE(cmd),GFP_KERNEL);
+                        if (NULL == mbuf)
+                                return -ENOMEM;
+                        parg = mbuf;
                 }
 
                 err = -EFAULT;
                 if (copy_from_user(parg, (void __user *)arg, _IOC_SIZE(cmd)))
-                        goto out;
+                        goto out;
                 break;
         }
 
@@ -384,7 +384,7 @@ int dvb_usercopy(struct inode *inode, struct file *file,
         case _IOC_READ:
         case (_IOC_WRITE | _IOC_READ):
                 if (copy_to_user((void __user *)arg, parg, _IOC_SIZE(cmd)))
-                        err = -EFAULT;
+                        err = -EFAULT;
                 break;
         }
 
diff --git a/drivers/media/dvb/dvb-core/dvbdev.h b/drivers/media/dvb/dvb-core/dvbdev.h
index 0cc6e4a0e27c..74ed5853f0fb 100644
--- a/drivers/media/dvb/dvb-core/dvbdev.h
+++ b/drivers/media/dvb/dvb-core/dvbdev.h
@@ -97,7 +97,7 @@ we simply define out own dvb_usercopy(), which will hopefully become
 generic_usercopy()  someday... */
 
 extern int dvb_usercopy(struct inode *inode, struct file *file,
-                            unsigned int cmd, unsigned long arg,
+                            unsigned int cmd, unsigned long arg,
                             int (*func)(struct inode *inode, struct file *file,
                             unsigned int cmd, void *arg));
 
diff --git a/drivers/media/dvb/dvb-usb/Kconfig b/drivers/media/dvb/dvb-usb/Kconfig
index 54e2b29076b1..90a69d343b79 100644
--- a/drivers/media/dvb/dvb-usb/Kconfig
+++ b/drivers/media/dvb/dvb-usb/Kconfig
@@ -37,16 +37,16 @@ config DVB_USB_DIBUSB_MB
           DiBcom (<http://www.dibcom.fr>) equipped with a DiB3000M-B demodulator.
 
           Devices supported by this driver:
-            TwinhanDTV USB-Ter (VP7041)
-            TwinhanDTV Magic Box (VP7041e)
-            KWorld/JetWay/ADSTech V-Stream XPERT DTV - DVB-T USB1.1 and USB2.0
-            Hama DVB-T USB1.1-Box
-            DiBcom USB1.1 reference devices (non-public)
-            Ultima Electronic/Artec T1 USB TVBOX
+            Artec T1 USB1.1 boxes
+            Avermedia AverTV DVBT USB1.1
             Compro Videomate DVB-U2000 - DVB-T USB
+            DiBcom USB1.1 reference devices (non-public)
             Grandtec DVB-T USB
-            Avermedia AverTV DVBT USB1.1
-            Artec T1 USB1.1 boxes
+            Hama DVB-T USB1.1-Box
+            KWorld/JetWay/ADSTech V-Stream XPERT DTV - DVB-T USB1.1 and USB2.0
+            TwinhanDTV Magic Box (VP7041e)
+            TwinhanDTV USB-Ter (VP7041)
+            Ultima Electronic/Artec T1 USB TVBOX
 
           The VP7041 seems to be identical to "CTS Portable" (Chinese
           Television System).
@@ -54,6 +54,12 @@ config DVB_USB_DIBUSB_MB
           Say Y if you own such a device and want to use it. You should build it as
           a module.
 
+config DVB_USB_DIBUSB_MB_FAULTY
+        bool "Support faulty USB IDs"
+        depends on DVB_USB_DIBUSB_MB
+        help
+          Support for faulty USB IDs due to an invalid EEPROM on some Artec devices.
+
 config DVB_USB_DIBUSB_MC
         tristate "DiBcom USB DVB-T devices (based on the DiB3000M-C/P) (see help for device list)"
         depends on DVB_USB
@@ -63,8 +69,8 @@ config DVB_USB_DIBUSB_MC
           DiBcom (<http://www.dibcom.fr>) equipped with a DiB3000M-C/P demodulator.
 
           Devices supported by this driver:
-            DiBcom USB2.0 reference devices (non-public)
             Artec T1 USB2.0 boxes
+            DiBcom USB2.0 reference devices (non-public)
 
           Say Y if you own such a device and want to use it. You should build it as
           a module.
diff --git a/drivers/media/dvb/dvb-usb/cxusb.c b/drivers/media/dvb/dvb-usb/cxusb.c
index d05fab01cccd..358ed153865f 100644
--- a/drivers/media/dvb/dvb-usb/cxusb.c
+++ b/drivers/media/dvb/dvb-usb/cxusb.c
@@ -11,10 +11,11 @@
  * design, so it can be reused for the "analogue-only" device (if it will
  * appear at all).
  *
- * TODO: check if the cx25840-driver (from ivtv) can be used for the analogue
- * part
+ * TODO: Use the cx25840-driver for the analogue part
  *
  * Copyright (C) 2005 Patrick Boettcher (patrick.boettcher@desy.de)
+ * Copyright (C) 2005 Michael Krufky (mkrufky@m1k.net)
+ * Copyright (C) 2006 Chris Pascoe (c.pascoe@itee.uq.edu.au)
  *
  *      This program is free software; you can redistribute it and/or modify it
  *      under the terms of the GNU General Public License as published by the Free
@@ -25,6 +26,9 @@
 #include "cxusb.h"
 
 #include "cx22702.h"
+#include "lgdt330x.h"
+#include "mt352.h"
+#include "mt352_priv.h"
 
 /* debug */
 int dvb_usb_cxusb_debug;
@@ -156,6 +160,99 @@ static int cxusb_streaming_ctrl(struct dvb_usb_device *d, int onoff)
         return 0;
 }
 
+static int cxusb_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
+{
+        struct dvb_usb_rc_key *keymap = d->props.rc_key_map;
+        u8 ircode[4];
+        int i;
+
+        cxusb_ctrl_msg(d, CMD_GET_IR_CODE, NULL, 0, ircode, 4);
+
+        *event = 0;
+        *state = REMOTE_NO_KEY_PRESSED;
+
+        for (i = 0; i < d->props.rc_key_map_size; i++) {
+                if (keymap[i].custom == ircode[2] &&
+                    keymap[i].data == ircode[3]) {
+                        *event = keymap[i].event;
+                        *state = REMOTE_KEY_PRESSED;
+
+                        return 0;
+                }
+        }
+
+        return 0;
+}
+
+struct dvb_usb_rc_key dvico_mce_rc_keys[] = {
+        { 0xfe, 0x02, KEY_TV },
+        { 0xfe, 0x0e, KEY_MP3 },
+        { 0xfe, 0x1a, KEY_DVD },
+        { 0xfe, 0x1e, KEY_FAVORITES },
+        { 0xfe, 0x16, KEY_SETUP },
+        { 0xfe, 0x46, KEY_POWER2 },
+        { 0xfe, 0x0a, KEY_EPG },
+        { 0xfe, 0x49, KEY_BACK },
+        { 0xfe, 0x4d, KEY_MENU },
+        { 0xfe, 0x51, KEY_UP },
+        { 0xfe, 0x5b, KEY_LEFT },
+        { 0xfe, 0x5f, KEY_RIGHT },
+        { 0xfe, 0x53, KEY_DOWN },
+        { 0xfe, 0x5e, KEY_OK },
+        { 0xfe, 0x59, KEY_INFO },
+        { 0xfe, 0x55, KEY_TAB },
+        { 0xfe, 0x0f, KEY_PREVIOUSSONG },/* Replay */
+        { 0xfe, 0x12, KEY_NEXTSONG },   /* Skip */
+        { 0xfe, 0x42, KEY_ENTER  },     /* Windows/Start */
+        { 0xfe, 0x15, KEY_VOLUMEUP },
+        { 0xfe, 0x05, KEY_VOLUMEDOWN },
+        { 0xfe, 0x11, KEY_CHANNELUP },
+        { 0xfe, 0x09, KEY_CHANNELDOWN },
+        { 0xfe, 0x52, KEY_CAMERA },
+        { 0xfe, 0x5a, KEY_TUNER },      /* Live */
+        { 0xfe, 0x19, KEY_OPEN },
+        { 0xfe, 0x0b, KEY_1 },
+        { 0xfe, 0x17, KEY_2 },
+        { 0xfe, 0x1b, KEY_3 },
+        { 0xfe, 0x07, KEY_4 },
+        { 0xfe, 0x50, KEY_5 },
+        { 0xfe, 0x54, KEY_6 },
+        { 0xfe, 0x48, KEY_7 },
+        { 0xfe, 0x4c, KEY_8 },
+        { 0xfe, 0x58, KEY_9 },
+        { 0xfe, 0x13, KEY_ANGLE },      /* Aspect */
+        { 0xfe, 0x03, KEY_0 },
+        { 0xfe, 0x1f, KEY_ZOOM },
+        { 0xfe, 0x43, KEY_REWIND },
+        { 0xfe, 0x47, KEY_PLAYPAUSE },
+        { 0xfe, 0x4f, KEY_FASTFORWARD },
+        { 0xfe, 0x57, KEY_MUTE },
+        { 0xfe, 0x0d, KEY_STOP },
+        { 0xfe, 0x01, KEY_RECORD },
+        { 0xfe, 0x4e, KEY_POWER },
+};
+
+static int cxusb_dee1601_demod_init(struct dvb_frontend* fe)
+{
+        static u8 clock_config []  = { CLOCK_CTL,  0x38, 0x38 };
+        static u8 reset []         = { RESET,      0x80 };
+        static u8 adc_ctl_1_cfg [] = { ADC_CTL_1,  0x40 };
+        static u8 agc_cfg []       = { AGC_TARGET, 0x28, 0x20 };
+        static u8 gpp_ctl_cfg []   = { GPP_CTL,    0x33 };
+        static u8 capt_range_cfg[] = { CAPT_RANGE, 0x32 };
+
+        mt352_write(fe, clock_config,   sizeof(clock_config));
+        udelay(200);
+        mt352_write(fe, reset,          sizeof(reset));
+        mt352_write(fe, adc_ctl_1_cfg,  sizeof(adc_ctl_1_cfg));
+
+        mt352_write(fe, agc_cfg,        sizeof(agc_cfg));
+        mt352_write(fe, gpp_ctl_cfg,    sizeof(gpp_ctl_cfg));
+        mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
+
+        return 0;
+}
+
 struct cx22702_config cxusb_cx22702_config = {
         .demod_address = 0x63,
 
@@ -165,17 +262,47 @@ struct cx22702_config cxusb_cx22702_config = {
         .pll_set  = dvb_usb_pll_set_i2c,
 };
 
+struct lgdt330x_config cxusb_lgdt330x_config = {
+        .demod_address = 0x0e,
+        .demod_chip    = LGDT3303,
+        .pll_set       = dvb_usb_pll_set_i2c,
+};
+
+struct mt352_config cxusb_dee1601_config = {
+        .demod_address = 0x0f,
+        .demod_init    = cxusb_dee1601_demod_init,
+        .pll_set       = dvb_usb_pll_set,
+};
+
 /* Callbacks for DVB USB */
-static int cxusb_tuner_attach(struct dvb_usb_device *d)
+static int cxusb_fmd1216me_tuner_attach(struct dvb_usb_device *d)
 {
         u8 bpll[4] = { 0x0b, 0xdc, 0x9c, 0xa0 };
         d->pll_addr = 0x61;
-        memcpy(d->pll_init,bpll,4);
+        memcpy(d->pll_init, bpll, 4);
         d->pll_desc = &dvb_pll_fmd1216me;
         return 0;
 }
 
-static int cxusb_frontend_attach(struct dvb_usb_device *d)
+static int cxusb_lgh064f_tuner_attach(struct dvb_usb_device *d)
+{
+        u8 bpll[4] = { 0x00, 0x00, 0x18, 0x50 };
+        /* bpll[2] : unset bit 3, set bits 4&5
+           bpll[3] : 0x50 - digital, 0x20 - analog */
+        d->pll_addr = 0x61;
+        memcpy(d->pll_init, bpll, 4);
+        d->pll_desc = &dvb_pll_tdvs_tua6034;
+        return 0;
+}
+
+static int cxusb_dee1601_tuner_attach(struct dvb_usb_device *d)
+{
+        d->pll_addr = 0x61;
+        d->pll_desc = &dvb_pll_thomson_dtt7579;
+        return 0;
+}
+
+static int cxusb_cx22702_frontend_attach(struct dvb_usb_device *d)
 {
         u8 b;
         if (usb_set_interface(d->udev,0,6) < 0)
@@ -189,22 +316,84 @@ static int cxusb_frontend_attach(struct dvb_usb_device *d)
         return -EIO;
 }
 
+static int cxusb_lgdt330x_frontend_attach(struct dvb_usb_device *d)
+{
+        if (usb_set_interface(d->udev,0,7) < 0)
+                err("set interface failed");
+
+        cxusb_ctrl_msg(d,CMD_DIGITAL, NULL, 0, NULL, 0);
+
+        if ((d->fe = lgdt330x_attach(&cxusb_lgdt330x_config, &d->i2c_adap)) != NULL)
+                return 0;
+
+        return -EIO;
+}
+
+static int cxusb_dee1601_frontend_attach(struct dvb_usb_device *d)
+{
+        if (usb_set_interface(d->udev,0,0) < 0)
+                err("set interface failed");
+
+        cxusb_ctrl_msg(d,CMD_DIGITAL, NULL, 0, NULL, 0);
+
+        if ((d->fe = mt352_attach(&cxusb_dee1601_config, &d->i2c_adap)) != NULL)
+                return 0;
+
+        return -EIO;
+}
+
+/*
+ * DViCO bluebird firmware needs the "warm" product ID to be patched into the
+ * firmware file before download.
+ */
+
+#define BLUEBIRD_01_ID_OFFSET 6638
+static int bluebird_patch_dvico_firmware_download(struct usb_device *udev, const struct firmware *fw)
+{
+        if (fw->size < BLUEBIRD_01_ID_OFFSET + 4)
+                return -EINVAL;
+
+        if (fw->data[BLUEBIRD_01_ID_OFFSET] == (USB_VID_DVICO & 0xff) &&
+            fw->data[BLUEBIRD_01_ID_OFFSET + 1] == USB_VID_DVICO >> 8) {
+
+                /* FIXME: are we allowed to change the fw-data ? */
+                fw->data[BLUEBIRD_01_ID_OFFSET + 2] = udev->descriptor.idProduct + 1;
+                fw->data[BLUEBIRD_01_ID_OFFSET + 3] = udev->descriptor.idProduct >> 8;
+
+                return usb_cypress_load_firmware(udev,fw,CYPRESS_FX2);
+        }
+
+        return -EINVAL;
+}
+
 /* DVB USB Driver stuff */
-static struct dvb_usb_properties cxusb_properties;
+static struct dvb_usb_properties cxusb_medion_properties;
+static struct dvb_usb_properties cxusb_bluebird_lgh064f_properties;
+static struct dvb_usb_properties cxusb_bluebird_dee1601_properties;
 
 static int cxusb_probe(struct usb_interface *intf,
                 const struct usb_device_id *id)
 {
-        return dvb_usb_device_init(intf,&cxusb_properties,THIS_MODULE,NULL);
+        if (dvb_usb_device_init(intf,&cxusb_medion_properties,THIS_MODULE,NULL) == 0 ||
+                dvb_usb_device_init(intf,&cxusb_bluebird_lgh064f_properties,THIS_MODULE,NULL) == 0 ||
+                dvb_usb_device_init(intf,&cxusb_bluebird_dee1601_properties,THIS_MODULE,NULL) == 0) {
+                return 0;
+        }
+
+        return -EINVAL;
 }
 
 static struct usb_device_id cxusb_table [] = {
                 { USB_DEVICE(USB_VID_MEDION, USB_PID_MEDION_MD95700) },
+                { USB_DEVICE(USB_VID_DVICO, USB_PID_DVICO_BLUEBIRD_LG064F_COLD) },
+                { USB_DEVICE(USB_VID_DVICO, USB_PID_DVICO_BLUEBIRD_LG064F_WARM) },
+                { USB_DEVICE(USB_VID_DVICO, USB_PID_DVICO_BLUEBIRD_DEE1601_COLD) },
+                { USB_DEVICE(USB_VID_DVICO, USB_PID_DVICO_BLUEBIRD_DEE1601_WARM) },
                 {}              /* Terminating entry */
 };
 MODULE_DEVICE_TABLE (usb, cxusb_table);
 
-static struct dvb_usb_properties cxusb_properties = {
+static struct dvb_usb_properties cxusb_medion_properties = {
         .caps = DVB_USB_IS_AN_I2C_ADAPTER,
 
         .usb_ctrl = CYPRESS_FX2,
@@ -213,8 +402,8 @@ static struct dvb_usb_properties cxusb_properties = {
 
         .streaming_ctrl   = cxusb_streaming_ctrl,
         .power_ctrl       = cxusb_power_ctrl,
-        .frontend_attach  = cxusb_frontend_attach,
-        .tuner_attach     = cxusb_tuner_attach,
+        .frontend_attach  = cxusb_cx22702_frontend_attach,
+        .tuner_attach     = cxusb_fmd1216me_tuner_attach,
 
         .i2c_algo         = &cxusb_i2c_algo,
 
@@ -240,6 +429,91 @@ static struct dvb_usb_properties cxusb_properties = {
         }
 };
 
+static struct dvb_usb_properties cxusb_bluebird_lgh064f_properties = {
+        .caps = DVB_USB_IS_AN_I2C_ADAPTER,
+
+        .usb_ctrl          = DEVICE_SPECIFIC,
+        .firmware          = "dvb-usb-bluebird-01.fw",
+        .download_firmware = bluebird_patch_dvico_firmware_download,
+        /* use usb alt setting 0 for EP4 transfer (dvb-t),
+           use usb alt setting 7 for EP2 transfer (atsc) */
+
+        .size_of_priv     = sizeof(struct cxusb_state),
+
+        .streaming_ctrl   = cxusb_streaming_ctrl,
+        .power_ctrl       = cxusb_power_ctrl,
+        .frontend_attach  = cxusb_lgdt330x_frontend_attach,
+        .tuner_attach     = cxusb_lgh064f_tuner_attach,
+
+        .i2c_algo         = &cxusb_i2c_algo,
+
+        .generic_bulk_ctrl_endpoint = 0x01,
+        /* parameter for the MPEG2-data transfer */
+        .urb = {
+                .type = DVB_USB_BULK,
+                .count = 5,
+                .endpoint = 0x02,
+                .u = {
+                        .bulk = {
+                                .buffersize = 8192,
+                        }
+                }
+        },
+
+        .num_device_descs = 1,
+        .devices = {
+                {   "DViCO FusionHDTV5 USB Gold",
+                        { &cxusb_table[1], NULL },
+                        { &cxusb_table[2], NULL },
+                },
+        }
+};
+
+static struct dvb_usb_properties cxusb_bluebird_dee1601_properties = {
+        .caps = DVB_USB_IS_AN_I2C_ADAPTER,
+
+        .usb_ctrl          = DEVICE_SPECIFIC,
+        .firmware          = "dvb-usb-bluebird-01.fw",
+        .download_firmware = bluebird_patch_dvico_firmware_download,
+        /* use usb alt setting 0 for EP4 transfer (dvb-t),
+           use usb alt setting 7 for EP2 transfer (atsc) */
+
+        .size_of_priv     = sizeof(struct cxusb_state),
+
+        .streaming_ctrl   = cxusb_streaming_ctrl,
+        .power_ctrl       = cxusb_power_ctrl,
+        .frontend_attach  = cxusb_dee1601_frontend_attach,
+        .tuner_attach     = cxusb_dee1601_tuner_attach,
+
+        .i2c_algo         = &cxusb_i2c_algo,
+
+        .rc_interval      = 150,
+        .rc_key_map       = dvico_mce_rc_keys,
+        .rc_key_map_size  = ARRAY_SIZE(dvico_mce_rc_keys),
+        .rc_query         = cxusb_rc_query,
+
+        .generic_bulk_ctrl_endpoint = 0x01,
+        /* parameter for the MPEG2-data transfer */
+        .urb = {
+                .type = DVB_USB_BULK,
+                .count = 5,
+                .endpoint = 0x04,
+                .u = {
+                        .bulk = {
+                                .buffersize = 8192,
+                        }
+                }
+        },
+
+        .num_device_descs = 1,
+        .devices = {
+                {   "DViCO FusionHDTV DVB-T Dual USB",
+                        { &cxusb_table[3], NULL },
+                        { &cxusb_table[4], NULL },
+                },
+        }
+};
+
 static struct usb_driver cxusb_driver = {
         .name           = "dvb_usb_cxusb",
         .probe          = cxusb_probe,
diff --git a/drivers/media/dvb/dvb-usb/cxusb.h b/drivers/media/dvb/dvb-usb/cxusb.h
index 135c2a81f581..087c99427853 100644
--- a/drivers/media/dvb/dvb-usb/cxusb.h
+++ b/drivers/media/dvb/dvb-usb/cxusb.h
@@ -21,6 +21,8 @@ extern int dvb_usb_cxusb_debug;
 #define CMD_STREAMING_ON  0x36
 #define CMD_STREAMING_OFF 0x37
 
+#define CMD_GET_IR_CODE   0x47
+
 #define CMD_ANALOG        0x50
 #define CMD_DIGITAL       0x51
 
diff --git a/drivers/media/dvb/dvb-usb/dibusb-mb.c b/drivers/media/dvb/dvb-usb/dibusb-mb.c
index 52ac3e5adf5d..dd5a13195886 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-mb.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-mb.c
@@ -65,11 +65,11 @@ static int dibusb_tuner_probe_and_attach(struct dvb_usb_device *d)
                 d->tuner_pass_ctrl(d->fe,0,msg[0].addr);
 
         if (b2[0] == 0xfe) {
-                info("this device has the Thomson Cable onboard. Which is default.");
+                info("This device has the Thomson Cable onboard. Which is default.");
                 dibusb_thomson_tuner_attach(d);
         } else {
                 u8 bpll[4] = { 0x0b, 0xf5, 0x85, 0xab };
-                info("this device has the Panasonic ENV77H11D5 onboard.");
+                info("This device has the Panasonic ENV77H11D5 onboard.");
                 d->pll_addr = 0x60;
                 memcpy(d->pll_init,bpll,4);
                 d->pll_desc = &dvb_pll_tda665x;
@@ -98,15 +98,15 @@ static int dibusb_probe(struct usb_interface *intf,
 
 /* do not change the order of the ID table */
 static struct usb_device_id dibusb_dib3000mb_table [] = {
-/* 00 */        { USB_DEVICE(USB_VID_WIDEVIEW,          USB_PID_AVERMEDIA_DVBT_USB_COLD)},
-/* 01 */        { USB_DEVICE(USB_VID_WIDEVIEW,          USB_PID_AVERMEDIA_DVBT_USB_WARM)},
+/* 00 */        { USB_DEVICE(USB_VID_WIDEVIEW,          USB_PID_AVERMEDIA_DVBT_USB_COLD) },
+/* 01 */        { USB_DEVICE(USB_VID_WIDEVIEW,          USB_PID_AVERMEDIA_DVBT_USB_WARM) },
 /* 02 */        { USB_DEVICE(USB_VID_COMPRO,            USB_PID_COMPRO_DVBU2000_COLD) },
 /* 03 */        { USB_DEVICE(USB_VID_COMPRO,            USB_PID_COMPRO_DVBU2000_WARM) },
 /* 04 */        { USB_DEVICE(USB_VID_COMPRO_UNK,        USB_PID_COMPRO_DVBU2000_UNK_COLD) },
 /* 05 */        { USB_DEVICE(USB_VID_DIBCOM,            USB_PID_DIBCOM_MOD3000_COLD) },
 /* 06 */        { USB_DEVICE(USB_VID_DIBCOM,            USB_PID_DIBCOM_MOD3000_WARM) },
-/* 07 */        { USB_DEVICE(USB_VID_EMPIA,                     USB_PID_KWORLD_VSTREAM_COLD) },
-/* 08 */        { USB_DEVICE(USB_VID_EMPIA,                     USB_PID_KWORLD_VSTREAM_WARM) },
+/* 07 */        { USB_DEVICE(USB_VID_EMPIA,             USB_PID_KWORLD_VSTREAM_COLD) },
+/* 08 */        { USB_DEVICE(USB_VID_EMPIA,             USB_PID_KWORLD_VSTREAM_WARM) },
 /* 09 */        { USB_DEVICE(USB_VID_GRANDTEC,          USB_PID_GRANDTEC_DVBT_USB_COLD) },
 /* 10 */        { USB_DEVICE(USB_VID_GRANDTEC,          USB_PID_GRANDTEC_DVBT_USB_WARM) },
 /* 11 */        { USB_DEVICE(USB_VID_GRANDTEC,          USB_PID_DIBCOM_MOD3000_COLD) },
@@ -117,27 +117,34 @@ static struct usb_device_id dibusb_dib3000mb_table [] = {
 /* 16 */        { USB_DEVICE(USB_VID_VISIONPLUS,        USB_PID_TWINHAN_VP7041_WARM) },
 /* 17 */        { USB_DEVICE(USB_VID_TWINHAN,           USB_PID_TWINHAN_VP7041_COLD) },
 /* 18 */        { USB_DEVICE(USB_VID_TWINHAN,           USB_PID_TWINHAN_VP7041_WARM) },
-/* 19 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_COLD) },
-/* 20 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_WARM) },
-/* 21 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_AN2235_COLD) },
-/* 22 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_AN2235_WARM) },
+/* 19 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_COLD) },
+/* 20 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_WARM) },
+/* 21 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_AN2235_COLD) },
+/* 22 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_AN2235_WARM) },
 /* 23 */        { USB_DEVICE(USB_VID_ADSTECH,           USB_PID_ADSTECH_USB2_COLD) },
 
 /* device ID with default DIBUSB2_0-firmware and with the hacked firmware */
 /* 24 */        { USB_DEVICE(USB_VID_ADSTECH,           USB_PID_ADSTECH_USB2_WARM) },
-/* 25 */        { USB_DEVICE(USB_VID_KYE,                       USB_PID_KYE_DVB_T_COLD) },
-/* 26 */        { USB_DEVICE(USB_VID_KYE,                       USB_PID_KYE_DVB_T_WARM) },
+/* 25 */        { USB_DEVICE(USB_VID_KYE,               USB_PID_KYE_DVB_T_COLD) },
+/* 26 */        { USB_DEVICE(USB_VID_KYE,               USB_PID_KYE_DVB_T_WARM) },
 
 /* 27 */        { USB_DEVICE(USB_VID_KWORLD,            USB_PID_KWORLD_VSTREAM_COLD) },
 
-/* 28 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC,         USB_PID_ULTIMA_TVBOX_USB2_COLD) },
-/* 29 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC,         USB_PID_ULTIMA_TVBOX_USB2_WARM) },
+/* 28 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_USB2_COLD) },
+/* 29 */        { USB_DEVICE(USB_VID_ULTIMA_ELECTRONIC, USB_PID_ULTIMA_TVBOX_USB2_WARM) },
 
-// #define DVB_USB_DIBUSB_MB_FAULTY_USB_IDs
+/*
+ * XXX: As Artec just 'forgot' to program the EEPROM on some Artec T1 devices
+ *      we don't catch these faulty IDs (namely 'Cypress FX1 USB controller') that
+ *      have been left on the device. If you don't have such a device but an Artec
+ *      device that's supposed to work with this driver but is not detected by it,
+ *      free to enable CONFIG_DVB_USB_DIBUSB_MB_FAULTY via your kernel config.
+ */
 
-#ifdef DVB_USB_DIBUSB_MB_FAULTY_USB_IDs
+#ifdef CONFIG_DVB_USB_DIBUSB_MB_FAULTY
 /* 30 */        { USB_DEVICE(USB_VID_ANCHOR,            USB_PID_ULTIMA_TVBOX_ANCHOR_COLD) },
 #endif
+
                         { }             /* Terminating entry */
 };
 MODULE_DEVICE_TABLE (usb, dibusb_dib3000mb_table);
@@ -257,7 +264,7 @@ static struct dvb_usb_properties dibusb1_1_an2235_properties = {
                 }
         },
 
-#ifdef DVB_USB_DIBUSB_MB_FAULTY_USB_IDs
+#ifdef CONFIG_DVB_USB_DIBUSB_MB_FAULTY
         .num_device_descs = 2,
 #else
         .num_device_descs = 1,
@@ -267,11 +274,12 @@ static struct dvb_usb_properties dibusb1_1_an2235_properties = {
                         { &dibusb_dib3000mb_table[20], NULL },
                         { &dibusb_dib3000mb_table[21], NULL },
                 },
-#ifdef DVB_USB_DIBUSB_MB_FAULTY_USB_IDs
+#ifdef CONFIG_DVB_USB_DIBUSB_MB_FAULTY
                 {       "Artec T1 USB1.1 TVBOX with AN2235 (faulty USB IDs)",
                         { &dibusb_dib3000mb_table[30], NULL },
                         { NULL },
                 },
+                { NULL },
 #endif
         }
 };
@@ -323,6 +331,7 @@ static struct dvb_usb_properties dibusb2_0b_properties = {
                         { &dibusb_dib3000mb_table[27], NULL },
                         { NULL }
                 },
+                { NULL },
         }
 };
 
@@ -369,6 +378,7 @@ static struct dvb_usb_properties artec_t1_usb2_properties = {
                         { &dibusb_dib3000mb_table[28], NULL },
                         { &dibusb_dib3000mb_table[29], NULL },
                 },
+                { NULL },
         }
 };
 
diff --git a/drivers/media/dvb/dvb-usb/digitv.c b/drivers/media/dvb/dvb-usb/digitv.c
index 450417a9e64b..e6c55c9c9417 100644
--- a/drivers/media/dvb/dvb-usb/digitv.c
+++ b/drivers/media/dvb/dvb-usb/digitv.c
@@ -32,7 +32,7 @@ static int digitv_ctrl_msg(struct dvb_usb_device *d,
         sndbuf[1] = vv;
         sndbuf[2] = wo ? wlen : rlen;
 
-        if (!wo) {
+        if (wo) {
                 memcpy(&sndbuf[3],wbuf,wlen);
                 dvb_usb_generic_write(d,sndbuf,7);
         } else {
diff --git a/drivers/media/dvb/dvb-usb/dtt200u.c b/drivers/media/dvb/dvb-usb/dtt200u.c
index 6e2bac873445..130ea7f21f5e 100644
--- a/drivers/media/dvb/dvb-usb/dtt200u.c
+++ b/drivers/media/dvb/dvb-usb/dtt200u.c
@@ -151,7 +151,7 @@ static struct dvb_usb_properties dtt200u_properties = {
                   .cold_ids = { &dtt200u_usb_table[0], NULL },
                   .warm_ids = { &dtt200u_usb_table[1], NULL },
                 },
-                { NULL },
+                { 0 },
         }
 };
 
@@ -160,7 +160,7 @@ static struct dvb_usb_properties wt220u_properties = {
         .pid_filter_count = 15,
 
         .usb_ctrl = CYPRESS_FX2,
-        .firmware = "dvb-usb-wt220u-01.fw",
+        .firmware = "dvb-usb-wt220u-02.fw",
 
         .power_ctrl      = dtt200u_power_ctrl,
         .streaming_ctrl  = dtt200u_streaming_ctrl,
@@ -192,7 +192,7 @@ static struct dvb_usb_properties wt220u_properties = {
                   .cold_ids = { &dtt200u_usb_table[2], NULL },
                   .warm_ids = { &dtt200u_usb_table[3], NULL },
                 },
-                { NULL },
+                { 0 },
         }
 };
 
diff --git a/drivers/media/dvb/dvb-usb/dtt200u.h b/drivers/media/dvb/dvb-usb/dtt200u.h
index 6f1f3042e21a..005b0a7df358 100644
--- a/drivers/media/dvb/dvb-usb/dtt200u.h
+++ b/drivers/media/dvb/dvb-usb/dtt200u.h
@@ -13,6 +13,7 @@
 #define _DVB_USB_DTT200U_H_
 
 #define DVB_USB_LOG_PREFIX "dtt200u"
+
 #include "dvb-usb.h"
 
 extern int dvb_usb_dtt200u_debug;
@@ -25,15 +26,15 @@ extern int dvb_usb_dtt200u_debug;
  *  88 - locking 2 bytes (0x80 0x40 == no signal, 0x89 0x20 == nice signal)
  */
 
-#define GET_SPEED            0x00
-#define GET_TUNE_STATUS      0x81
-#define GET_RC_CODE          0x84
-#define GET_CONFIGURATION    0x88
-#define GET_AGC              0x89
-#define GET_SNR              0x8a
-#define GET_VIT_ERR_CNT      0x8c
-#define GET_RS_ERR_CNT       0x8d
-#define GET_RS_UNCOR_BLK_CNT 0x8e
+#define GET_SPEED               0x00
+#define GET_TUNE_STATUS         0x81
+#define GET_RC_CODE             0x84
+#define GET_CONFIGURATION       0x88
+#define GET_AGC                 0x89
+#define GET_SNR                 0x8a
+#define GET_VIT_ERR_CNT         0x8c
+#define GET_RS_ERR_CNT          0x8d
+#define GET_RS_UNCOR_BLK_CNT    0x8e
 
 /* write
  *  01 - init
@@ -44,12 +45,12 @@ extern int dvb_usb_dtt200u_debug;
  *  08 - transfer switch
  */
 
-#define SET_INIT         0x01
-#define SET_RF_FREQ      0x02
-#define SET_BANDWIDTH    0x03
-#define SET_PID_FILTER   0x04
-#define RESET_PID_FILTER 0x05
-#define SET_STREAMING    0x08
+#define SET_INIT                0x01
+#define SET_RF_FREQ             0x02
+#define SET_BANDWIDTH           0x03
+#define SET_PID_FILTER          0x04
+#define RESET_PID_FILTER        0x05
+#define SET_STREAMING           0x08
 
 extern struct dvb_frontend * dtt200u_fe_attach(struct dvb_usb_device *d);
 
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-common.h b/drivers/media/dvb/dvb-usb/dvb-usb-common.h
index 7300489d3e24..a3460bf2d9fa 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-common.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-common.h
@@ -24,7 +24,7 @@ extern int dvb_usb_disable_rc_polling;
 #define deb_mem(args...)  dprintk(dvb_usb_debug,0x80,args)
 
 /* commonly used  methods */
-extern int usb_cypress_load_firmware(struct usb_device *, const char *, int);
+extern int dvb_usb_download_firmware(struct usb_device *, struct dvb_usb_properties *);
 
 extern int dvb_usb_urb_submit(struct dvb_usb_device *);
 extern int dvb_usb_urb_kill(struct dvb_usb_device *);
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
index 5244e39770a0..8535895819fb 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
@@ -9,7 +9,6 @@
  */
 #include "dvb-usb-common.h"
 
-#include <linux/firmware.h>
 #include <linux/usb.h>
 
 struct usb_cypress_controller {
@@ -19,9 +18,10 @@ struct usb_cypress_controller {
 };
 
 static struct usb_cypress_controller cypress[] = {
-        { .id = CYPRESS_AN2135, .name = "Cypress AN2135", .cpu_cs_register = 0x7f92 },
-        { .id = CYPRESS_AN2235, .name = "Cypress AN2235", .cpu_cs_register = 0x7f92 },
-        { .id = CYPRESS_FX2,    .name = "Cypress FX2",    .cpu_cs_register = 0xe600 },
+        { .id = DEVICE_SPECIFIC, .name = "Device specific", .cpu_cs_register = 0 },
+        { .id = CYPRESS_AN2135,  .name = "Cypress AN2135",  .cpu_cs_register = 0x7f92 },
+        { .id = CYPRESS_AN2235,  .name = "Cypress AN2235",  .cpu_cs_register = 0x7f92 },
+        { .id = CYPRESS_FX2,     .name = "Cypress FX2",     .cpu_cs_register = 0xe600 },
 };
 
 /*
@@ -30,71 +30,117 @@ static struct usb_cypress_controller cypress[] = {
 static int usb_cypress_writemem(struct usb_device *udev,u16 addr,u8 *data, u8 len)
 {
         return usb_control_msg(udev, usb_sndctrlpipe(udev,0),
-                        0xa0, USB_TYPE_VENDOR, addr, 0x00, data, len, 5*HZ);
+                        0xa0, USB_TYPE_VENDOR, addr, 0x00, data, len, 5000);
 }
 
-int usb_cypress_load_firmware(struct usb_device *udev, const char *filename, int type)
+int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw, int type)
 {
-        const struct firmware *fw = NULL;
-        u16 addr;
-        u8 *b,*p;
-        int ret = 0,i;
+        struct hexline hx;
+        u8 reset;
+        int ret,pos=0;
 
-        if ((ret = request_firmware(&fw, filename, &udev->dev)) != 0) {
-                err("did not find the firmware file. (%s) "
-                        "Please see linux/Documentation/dvb/ for more details on firmware-problems.",
-                        filename);
+        /* stop the CPU */
+        reset = 1;
+        if ((ret = usb_cypress_writemem(udev,cypress[type].cpu_cs_register,&reset,1)) != 1)
+                err("could not stop the USB controller CPU.");
+
+        while ((ret = dvb_usb_get_hexline(fw,&hx,&pos)) > 0) {
+                deb_fw("writing to address 0x%04x (buffer: 0x%02x %02x)\n",hx.addr,hx.len,hx.chk);
+                ret = usb_cypress_writemem(udev,hx.addr,hx.data,hx.len);
+
+                if (ret != hx.len) {
+                        err("error while transferring firmware "
+                                "(transferred size: %d, block size: %d)",
+                                ret,hx.len);
+                        ret = -EINVAL;
+                        break;
+                }
+        }
+        if (ret < 0) {
+                err("firmware download failed at %d with %d",pos,ret);
                 return ret;
         }
 
-        info("downloading firmware from file '%s' to the '%s'",filename,cypress[type].name);
-
-        p = kmalloc(fw->size,GFP_KERNEL);
-        if (p != NULL) {
-                u8 reset;
-                /*
-                 * you cannot use the fw->data as buffer for
-                 * usb_control_msg, a new buffer has to be
-                 * created
-                 */
-                memcpy(p,fw->data,fw->size);
-
-                /* stop the CPU */
-                reset = 1;
-                if ((ret = usb_cypress_writemem(udev,cypress[type].cpu_cs_register,&reset,1)) != 1)
-                        err("could not stop the USB controller CPU.");
-                for(i = 0; p[i+3] == 0 && i < fw->size; ) {
-                        b = (u8 *) &p[i];
-                        addr = cpu_to_le16( *((u16 *) &b[1]) );
-
-                        deb_fw("writing to address 0x%04x (buffer: 0x%02x%02x)\n",addr,b[1],b[2]);
-
-                        ret = usb_cypress_writemem(udev,addr,&b[4],b[0]);
-
-                        if (ret != b[0]) {
-                                err("error while transferring firmware "
-                                        "(transferred size: %d, block size: %d)",
-                                        ret,b[0]);
-                                ret = -EINVAL;
-                                break;
-                        }
-                        i += 5 + b[0];
-                }
-                /* length in ret */
-                if (ret > 0)
-                        ret = 0;
+        if (ret == 0) {
                 /* restart the CPU */
                 reset = 0;
                 if (ret || usb_cypress_writemem(udev,cypress[type].cpu_cs_register,&reset,1) != 1) {
                         err("could not restart the USB controller CPU.");
                         ret = -EINVAL;
                 }
+        } else
+                ret = -EIO;
 
-                kfree(p);
-        } else {
-                ret = -ENOMEM;
+        return ret;
+}
+EXPORT_SYMBOL(usb_cypress_load_firmware);
+
+int dvb_usb_download_firmware(struct usb_device *udev, struct dvb_usb_properties *props)
+{
+        int ret;
+        const struct firmware *fw = NULL;
+
+        if ((ret = request_firmware(&fw, props->firmware, &udev->dev)) != 0) {
+                err("did not find the firmware file. (%s) "
+                        "Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)",
+                        props->firmware,ret);
+                return ret;
         }
-        release_firmware(fw);
 
+        info("downloading firmware from file '%s'",props->firmware);
+
+        switch (props->usb_ctrl) {
+                case CYPRESS_AN2135:
+                case CYPRESS_AN2235:
+                case CYPRESS_FX2:
+                        ret = usb_cypress_load_firmware(udev, fw, props->usb_ctrl);
+                        break;
+                case DEVICE_SPECIFIC:
+                        if (props->download_firmware)
+                                ret = props->download_firmware(udev,fw);
+                        else {
+                                err("BUG: driver didn't specified a download_firmware-callback, although it claims to have a DEVICE_SPECIFIC one.");
+                                ret = -EINVAL;
+                        }
+                        break;
+                default:
+                        ret = -EINVAL;
+                        break;
+        }
+
+        release_firmware(fw);
         return ret;
 }
+
+int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx, int *pos)
+{
+        u8 *b = (u8 *) &fw->data[*pos];
+        int data_offs = 4;
+        if (*pos >= fw->size)
+                return 0;
+
+        memset(hx,0,sizeof(struct hexline));
+
+        hx->len  = b[0];
+
+        if ((*pos + hx->len + 4) >= fw->size)
+                return -EINVAL;
+
+        hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
+        hx->type = b[3];
+
+        if (hx->type == 0x04) {
+                /* b[4] and b[5] are the Extended linear address record data field */
+                hx->addr |= (b[4] << 24) | (b[5] << 16);
+/*              hx->len -= 2;
+                data_offs += 2; */
+        }
+        memcpy(hx->data,&b[data_offs],hx->len);
+        hx->chk = b[hx->len + data_offs];
+
+        *pos += hx->len + 5;
+
+        return *pos;
+}
+EXPORT_SYMBOL(dvb_usb_get_hexline);
+
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c b/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c
index da970947dfc7..9b254532af4d 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c
@@ -52,9 +52,8 @@ int dvb_usb_pll_init_i2c(struct dvb_frontend *fe)
         struct i2c_msg msg = { .addr = d->pll_addr, .flags = 0, .buf = d->pll_init, .len = 4 };
         int ret = 0;
 
-        /* if there is nothing to initialize */
-        if (d->pll_init[0] == 0x00 && d->pll_init[1] == 0x00 &&
-                d->pll_init[2] == 0x00 && d->pll_init[3] == 0x00)
+        /* if pll_desc is not used */
+        if (d->pll_desc == NULL)
                 return 0;
 
         if (d->tuner_pass_ctrl)
@@ -80,6 +79,9 @@ int dvb_usb_pll_set(struct dvb_frontend *fe, struct dvb_frontend_parameters *fep
 {
         struct dvb_usb_device *d = fe->dvb->priv;
 
+        if (d->pll_desc == NULL)
+                return 0;
+
         deb_pll("pll addr: %x, freq: %d %p\n",d->pll_addr,fep->frequency,d->pll_desc);
 
         b[0] = d->pll_addr << 1;
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 6be99e537e12..d22934383226 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -86,11 +86,15 @@
 #define USB_PID_WINTV_NOVA_T_USB2_COLD          0x9300
 #define USB_PID_WINTV_NOVA_T_USB2_WARM          0x9301
 #define USB_PID_NEBULA_DIGITV                           0x0201
-#define USB_PID_DVICO_BLUEBIRD_LGZ201           0xdb00
-#define USB_PID_DVICO_BLUEBIRD_TH7579           0xdb10
 #define USB_PID_DVICO_BLUEBIRD_LGDT                     0xd820
-#define USB_PID_DVICO_BLUEBIRD_LGZ201_1         0xdb01
-#define USB_PID_DVICO_BLUEBIRD_TH7579_2         0xdb11
+#define USB_PID_DVICO_BLUEBIRD_LG064F_COLD              0xd500
+#define USB_PID_DVICO_BLUEBIRD_LG064F_WARM              0xd501
+#define USB_PID_DVICO_BLUEBIRD_LGZ201_COLD              0xdb00
+#define USB_PID_DVICO_BLUEBIRD_LGZ201_WARM              0xdb01
+#define USB_PID_DVICO_BLUEBIRD_TH7579_COLD              0xdb10
+#define USB_PID_DVICO_BLUEBIRD_TH7579_WARM              0xdb11
+#define USB_PID_DVICO_BLUEBIRD_DEE1601_COLD             0xdb50
+#define USB_PID_DVICO_BLUEBIRD_DEE1601_WARM             0xdb51
 #define USB_PID_MEDION_MD95700                          0x0932
 #define USB_PID_KYE_DVB_T_COLD                          0x701e
 #define USB_PID_KYE_DVB_T_WARM                          0x701f
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-init.c b/drivers/media/dvb/dvb-usb/dvb-usb-init.c
index dd8e0b94edba..2e23060cbbca 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-init.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-init.c
@@ -138,6 +138,9 @@ int dvb_usb_device_init(struct usb_interface *intf, struct dvb_usb_properties
 
         int ret = -ENOMEM,cold=0;
 
+        if (du != NULL)
+                *du = NULL;
+
         if ((desc = dvb_usb_find_device(udev,props,&cold)) == NULL) {
                 deb_err("something went very wrong, device was not found in current device list - let's see what comes next.\n");
                 return -ENODEV;
@@ -145,38 +148,40 @@ int dvb_usb_device_init(struct usb_interface *intf, struct dvb_usb_properties
 
         if (cold) {
                 info("found a '%s' in cold state, will try to load a firmware",desc->name);
-                ret = usb_cypress_load_firmware(udev,props->firmware,props->usb_ctrl);
-        } else {
-                info("found a '%s' in warm state.",desc->name);
-                d = kmalloc(sizeof(struct dvb_usb_device),GFP_KERNEL);
-                if (d == NULL) {
-                        err("no memory for 'struct dvb_usb_device'");
+                ret = dvb_usb_download_firmware(udev,props);
+                if (!props->no_reconnect)
                         return ret;
+        }
+
+        info("found a '%s' in warm state.",desc->name);
+        d = kmalloc(sizeof(struct dvb_usb_device),GFP_KERNEL);
+        if (d == NULL) {
+                err("no memory for 'struct dvb_usb_device'");
+                return ret;
+        }
+        memset(d,0,sizeof(struct dvb_usb_device));
+
+        d->udev = udev;
+        memcpy(&d->props,props,sizeof(struct dvb_usb_properties));
+        d->desc = desc;
+        d->owner = owner;
+
+        if (d->props.size_of_priv > 0) {
+                d->priv = kmalloc(d->props.size_of_priv,GFP_KERNEL);
+                if (d->priv == NULL) {
+                        err("no memory for priv in 'struct dvb_usb_device'");
+                        kfree(d);
+                        return -ENOMEM;
                 }
-                memset(d,0,sizeof(struct dvb_usb_device));
-
-                d->udev = udev;
-                memcpy(&d->props,props,sizeof(struct dvb_usb_properties));
-                d->desc = desc;
-                d->owner = owner;
-
-                if (d->props.size_of_priv > 0) {
-                        d->priv = kmalloc(d->props.size_of_priv,GFP_KERNEL);
-                        if (d->priv == NULL) {
-                                err("no memory for priv in 'struct dvb_usb_device'");
-                                kfree(d);
-                                return -ENOMEM;
-                        }
-                        memset(d->priv,0,d->props.size_of_priv);
-                }
+                memset(d->priv,0,d->props.size_of_priv);
+        }
 
-                usb_set_intfdata(intf, d);
+        usb_set_intfdata(intf, d);
 
-                if (du != NULL)
-                        *du = d;
+        if (du != NULL)
+                *du = d;
 
-                ret = dvb_usb_init(d);
-        }
+        ret = dvb_usb_init(d);
 
         if (ret == 0)
                 info("%s successfully initialized and connected.",desc->name);
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb.h b/drivers/media/dvb/dvb-usb/dvb-usb.h
index b4a1a98006c7..dd568396e594 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb.h
@@ -10,8 +10,8 @@
 
 #include <linux/config.h>
 #include <linux/input.h>
-#include <linux/module.h>
 #include <linux/usb.h>
+#include <linux/firmware.h>
 
 #include "dvb_frontend.h"
 #include "dvb_demux.h"
@@ -94,7 +94,11 @@ struct dvb_usb_device;
  * @usb_ctrl: which USB device-side controller is in use. Needed for firmware
  *  download.
  * @firmware: name of the firmware file.
- *
+ * @download_firmware: called to download the firmware when the usb_ctrl is
+ *  DEVICE_SPECIFIC.
+ * @no_reconnect: device doesn't do a reconnect after downloading the firmware,
+    so do the warm initialization right after it
+
  * @size_of_priv: how many bytes shall be allocated for the private field
  *  of struct dvb_usb_device.
  *
@@ -142,11 +146,14 @@ struct dvb_usb_properties {
         int caps;
         int pid_filter_count;
 
-#define CYPRESS_AN2135  0
-#define CYPRESS_AN2235  1
-#define CYPRESS_FX2     2
+#define DEVICE_SPECIFIC 0
+#define CYPRESS_AN2135  1
+#define CYPRESS_AN2235  2
+#define CYPRESS_FX2     3
         int usb_ctrl;
-        const char *firmware;
+        const char firmware[FIRMWARE_NAME_MAX];
+        int (*download_firmware) (struct usb_device *, const struct firmware *);
+        int no_reconnect;
 
         int size_of_priv;
 
@@ -326,5 +333,15 @@ extern int dvb_usb_pll_init_i2c(struct dvb_frontend *);
 extern int dvb_usb_pll_set(struct dvb_frontend *, struct dvb_frontend_parameters *, u8[]);
 extern int dvb_usb_pll_set_i2c(struct dvb_frontend *, struct dvb_frontend_parameters *);
 
+/* commonly used firmware download types and function */
+struct hexline {
+        u8 len;
+        u32 addr;
+        u8 type;
+        u8 data[255];
+        u8 chk;
+};
+extern int dvb_usb_get_hexline(const struct firmware *, struct hexline *, int *);
+extern int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw, int type);
 
 #endif
diff --git a/drivers/media/dvb/dvb-usb/nova-t-usb2.c b/drivers/media/dvb/dvb-usb/nova-t-usb2.c
index fac48fc7a4ac..412039d8dbae 100644
--- a/drivers/media/dvb/dvb-usb/nova-t-usb2.c
+++ b/drivers/media/dvb/dvb-usb/nova-t-usb2.c
@@ -129,10 +129,6 @@ static int nova_t_read_mac_address (struct dvb_usb_device *d, u8 mac[6])
                 dibusb_read_eeprom_byte(d,i, &b);
 
                 mac[5 - (i - 136)] = b;
-
-/*              deb_ee("%02x ",b);
-                if ((i+1) % 16 == 0)
-                        deb_ee("\n");*/
         }
 
         return 0;
@@ -153,7 +149,7 @@ static struct usb_device_id nova_t_table [] = {
 /* 01 */        { USB_DEVICE(USB_VID_HAUPPAUGE,     USB_PID_WINTV_NOVA_T_USB2_WARM) },
                         { }             /* Terminating entry */
 };
-MODULE_DEVICE_TABLE (usb, nova_t_table);
+MODULE_DEVICE_TABLE(usb, nova_t_table);
 
 static struct dvb_usb_properties nova_t_properties = {
         .caps = DVB_USB_HAS_PID_FILTER | DVB_USB_PID_FILTER_CAN_BE_TURNED_OFF | DVB_USB_IS_AN_I2C_ADAPTER,
@@ -198,6 +194,7 @@ static struct dvb_usb_properties nova_t_properties = {
                         { &nova_t_table[0], NULL },
                         { &nova_t_table[1], NULL },
                 },
+                { NULL },
         }
 };
 
diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe.c b/drivers/media/dvb/dvb-usb/vp702x-fe.c
index 104b5d016c7b..0885d9fb2bf2 100644
--- a/drivers/media/dvb/dvb-usb/vp702x-fe.c
+++ b/drivers/media/dvb/dvb-usb/vp702x-fe.c
@@ -190,7 +190,7 @@ static int vp702x_fe_get_frontend(struct dvb_frontend* fe,
 }
 
 static int vp702x_fe_send_diseqc_msg (struct dvb_frontend* fe,
-                                    struct dvb_diseqc_master_cmd *m)
+                                    struct dvb_diseqc_master_cmd *m)
 {
         struct vp702x_fe_state *st = fe->demodulator_priv;
         u8 cmd[8],ibuf[10];
diff --git a/drivers/media/dvb/dvb-usb/vp702x.h b/drivers/media/dvb/dvb-usb/vp702x.h
index 4a3e8c7eca2b..a808d48e7bf2 100644
--- a/drivers/media/dvb/dvb-usb/vp702x.h
+++ b/drivers/media/dvb/dvb-usb/vp702x.h
@@ -13,47 +13,47 @@ extern int dvb_usb_vp702x_debug;
 /* commands are read and written with USB control messages */
 
 /* consecutive read/write operation */
-#define REQUEST_OUT       0xB2
-#define REQUEST_IN                0xB3
+#define REQUEST_OUT             0xB2
+#define REQUEST_IN              0xB3
 
 /* the out-buffer of these consecutive operations contain sub-commands when b[0] = 0
  * request: 0xB2; i: 0; v: 0; b[0] = 0, b[1] = subcmd, additional buffer
  * the returning buffer looks as follows
  * request: 0xB3; i: 0; v: 0; b[0] = 0xB3, additional buffer */
 
-#define GET_TUNER_STATUS  0x05
+#define GET_TUNER_STATUS        0x05
 /* additional in buffer:
  * 0   1   2    3              4   5   6               7       8
  * N/A N/A 0x05 signal-quality N/A N/A signal-strength lock==0 N/A */
 
-#define GET_SYSTEM_STRING 0x06
+#define GET_SYSTEM_STRING       0x06
 /* additional in buffer:
  * 0   1   2   3   4   5   6   7   8
  * N/A 'U' 'S' 'B' '7' '0' '2' 'X' N/A */
 
-#define SET_DISEQC_CMD    0x08
+#define SET_DISEQC_CMD          0x08
 /* additional out buffer:
  * 0    1  2  3  4
  * len  X1 X2 X3 X4
  * additional in buffer:
  * 0   1 2
- * N/A 0 0   b[1] == b[2] == 0 -> success otherwise not */
+ * N/A 0 0   b[1] == b[2] == 0 -> success, failure otherwise */
 
-#define SET_LNB_POWER     0x09
+#define SET_LNB_POWER           0x09
 /* additional out buffer:
  * 0    1    2
  * 0x00 0xff 1 = on, 0 = off
  * additional in buffer:
  * 0   1 2
- * N/A 0 0   b[1] == b[2] == 0 -> success otherwise not */
+ * N/A 0 0   b[1] == b[2] == 0 -> success failure otherwise */
 
-#define GET_MAC_ADDRESS   0x0A
+#define GET_MAC_ADDRESS         0x0A
 /* #define GET_MAC_ADDRESS   0x0B */
 /* additional in buffer:
  * 0   1   2            3    4    5    6    7    8
  * N/A N/A 0x0A or 0x0B MAC0 MAC1 MAC2 MAC3 MAC4 MAC5 */
 
-#define SET_PID_FILTER    0x11
+#define SET_PID_FILTER          0x11
 /* additional in buffer:
  * 0        1        ... 14       15       16
  * PID0_MSB PID0_LSB ... PID7_MSB PID7_LSB PID_active (bits) */
@@ -64,39 +64,38 @@ extern int dvb_usb_vp702x_debug;
  * freq0 freq1 divstep srate0 srate1 srate2 flag chksum
  */
 
-
 /* one direction requests */
-#define READ_REMOTE_REQ       0xB4
+#define READ_REMOTE_REQ         0xB4
 /* IN  i: 0; v: 0; b[0] == request, b[1] == key */
 
-#define READ_PID_NUMBER_REQ   0xB5
+#define READ_PID_NUMBER_REQ     0xB5
 /* IN  i: 0; v: 0; b[0] == request, b[1] == 0, b[2] = pid number */
 
-#define WRITE_EEPROM_REQ      0xB6
+#define WRITE_EEPROM_REQ        0xB6
 /* OUT i: offset; v: value to write; no extra buffer */
 
-#define READ_EEPROM_REQ       0xB7
+#define READ_EEPROM_REQ         0xB7
 /* IN  i: bufferlen; v: offset; buffer with bufferlen bytes */
 
-#define READ_STATUS           0xB8
+#define READ_STATUS             0xB8
 /* IN  i: 0; v: 0; bufferlen 10 */
 
-#define READ_TUNER_REG_REQ    0xB9
+#define READ_TUNER_REG_REQ      0xB9
 /* IN  i: 0; v: register; b[0] = value */
 
-#define READ_FX2_REG_REQ      0xBA
+#define READ_FX2_REG_REQ        0xBA
 /* IN  i: offset; v: 0; b[0] = value */
 
-#define WRITE_FX2_REG_REQ     0xBB
+#define WRITE_FX2_REG_REQ       0xBB
 /* OUT i: offset; v: value to write; 1 byte extra buffer */
 
-#define SET_TUNER_POWER_REQ   0xBC
+#define SET_TUNER_POWER_REQ     0xBC
 /* IN  i: 0 = power off, 1 = power on */
 
-#define WRITE_TUNER_REG_REQ   0xBD
+#define WRITE_TUNER_REG_REQ     0xBD
 /* IN  i: register, v: value to write, no extra buffer */
 
-#define RESET_TUNER           0xBE
+#define RESET_TUNER             0xBE
 /* IN  i: 0, v: 0, no extra buffer */
 
 extern struct dvb_frontend * vp702x_fe_attach(struct dvb_usb_device *d);
diff --git a/drivers/media/dvb/dvb-usb/vp7045.c b/drivers/media/dvb/dvb-usb/vp7045.c
index 3835235b68df..028204956bb0 100644
--- a/drivers/media/dvb/dvb-usb/vp7045.c
+++ b/drivers/media/dvb/dvb-usb/vp7045.c
@@ -247,7 +247,7 @@ static struct dvb_usb_properties vp7045_properties = {
                   .cold_ids = { &vp7045_usb_table[2], NULL },
                   .warm_ids = { &vp7045_usb_table[3], NULL },
                 },
-                { NULL },
+                { 0 },
         }
 };
 
diff --git a/drivers/media/dvb/frontends/Kconfig b/drivers/media/dvb/frontends/Kconfig
index 8e269e1c1f9d..db3a8b40031e 100644
--- a/drivers/media/dvb/frontends/Kconfig
+++ b/drivers/media/dvb/frontends/Kconfig
@@ -16,6 +16,12 @@ config DVB_CX24110
         help
           A DVB-S tuner module. Say Y when you want to support this frontend.
 
+config DVB_CX24123
+        tristate "Conexant CX24123 based"
+        depends on DVB_CORE
+        help
+          A DVB-S tuner module. Say Y when you want to support this frontend.
+
 config DVB_TDA8083
         tristate "Philips TDA8083 based"
         depends on DVB_CORE
@@ -50,18 +56,19 @@ comment "DVB-T (terrestrial) frontends"
         depends on DVB_CORE
 
 config DVB_SP8870
-        tristate "Spase sp8870 based"
+        tristate "Spase sp8870 based"
         depends on DVB_CORE
         select FW_LOADER
         help
-          A DVB-T tuner module. Say Y when you want to support this frontend.
+          A DVB-T tuner module. Say Y when you want to support this frontend.
 
           This driver needs external firmware. Please use the command
           "<kerneldir>/Documentation/dvb/get_dvb_firmware sp8870" to
-          download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+          download/extract it, and then copy it to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
 
 config DVB_SP887X
-        tristate "Spase sp887x based"
+        tristate "Spase sp887x based"
         depends on DVB_CORE
         select FW_LOADER
         help
@@ -69,7 +76,8 @@ config DVB_SP887X
 
           This driver needs external firmware. Please use the command
           "<kerneldir>/Documentation/dvb/get_dvb_firmware sp887x" to
-          download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+          download/extract it, and then copy it to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
 
 config DVB_CX22700
         tristate "Conexant CX22700 based"
@@ -78,10 +86,10 @@ config DVB_CX22700
           A DVB-T tuner module. Say Y when you want to support this frontend.
 
 config DVB_CX22702
-        tristate "Conexant cx22702 demodulator (OFDM)"
-        depends on DVB_CORE
-        help
-          A DVB-T tuner module. Say Y when you want to support this frontend.
+        tristate "Conexant cx22702 demodulator (OFDM)"
+        depends on DVB_CORE
+        help
+          A DVB-T tuner module. Say Y when you want to support this frontend.
 
 config DVB_L64781
         tristate "LSI L64781"
@@ -98,8 +106,9 @@ config DVB_TDA1004X
 
           This driver needs external firmware. Please use the commands
           "<kerneldir>/Documentation/dvb/get_dvb_firmware tda10045",
-          "<kerneldir>/Documentation/dvb/get_dvb_firmware tda10046" to
-          download/extract them, and then copy them to /usr/lib/hotplug/firmware.
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware tda10046" to
+          download/extract them, and then copy them to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
 
 config DVB_NXT6000
         tristate "NxtWave Communications NXT6000 based"
@@ -140,13 +149,13 @@ config DVB_VES1820
         tristate "VLSI VES1820 based"
         depends on DVB_CORE
         help
-          A DVB-C tuner module. Say Y when you want to support this frontend.
+          A DVB-C tuner module. Say Y when you want to support this frontend.
 
 config DVB_TDA10021
         tristate "Philips TDA10021 based"
         depends on DVB_CORE
         help
-          A DVB-C tuner module. Say Y when you want to support this frontend.
+          A DVB-C tuner module. Say Y when you want to support this frontend.
 
 config DVB_STV0297
         tristate "ST STV0297 based"
@@ -164,6 +173,11 @@ config DVB_NXT2002
         help
           An ATSC 8VSB tuner module. Say Y when you want to support this frontend.
 
+          This driver needs external firmware. Please use the command
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware nxt2002" to
+          download/extract it, and then copy it to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
+
 config DVB_NXT200X
         tristate "Nextwave NXT2002/NXT2004 based"
         depends on DVB_CORE
@@ -172,6 +186,12 @@ config DVB_NXT200X
           An ATSC 8VSB and QAM64/256 tuner module. Say Y when you want
           to support this frontend.
 
+          This driver needs external firmware. Please use the commands
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware nxt2002" and
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware nxt2004" to
+          download/extract them, and then copy them to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
+
 config DVB_OR51211
         tristate "or51211 based (pcHDTV HD2000 card)"
         depends on DVB_CORE
diff --git a/drivers/media/dvb/frontends/Makefile b/drivers/media/dvb/frontends/Makefile
index a98760fe08a1..615ec830e1c9 100644
--- a/drivers/media/dvb/frontends/Makefile
+++ b/drivers/media/dvb/frontends/Makefile
@@ -32,3 +32,4 @@ obj-$(CONFIG_DVB_OR51132) += or51132.o
 obj-$(CONFIG_DVB_BCM3510) += bcm3510.o
 obj-$(CONFIG_DVB_S5H1420) += s5h1420.o
 obj-$(CONFIG_DVB_LGDT330X) += lgdt330x.o
+obj-$(CONFIG_DVB_CX24123) += cx24123.o
diff --git a/drivers/media/dvb/frontends/bcm3510.c b/drivers/media/dvb/frontends/bcm3510.c
index 8ceb9a33c7af..3b132bafd4de 100644
--- a/drivers/media/dvb/frontends/bcm3510.c
+++ b/drivers/media/dvb/frontends/bcm3510.c
@@ -255,7 +255,7 @@ static int bcm3510_bert_reset(struct bcm3510_state *st)
         bcm3510_register_value b;
         int ret;
 
-        if ((ret < bcm3510_readB(st,0xfa,&b)) < 0)
+        if ((ret = bcm3510_readB(st,0xfa,&b)) < 0)
                 return ret;
 
         b.BERCTL_fa.RESYNC = 0; bcm3510_writeB(st,0xfa,b);
@@ -623,13 +623,13 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
                 err("could not load firmware (%s): %d",BCM3510_DEFAULT_FIRMWARE,ret);
                 return ret;
         }
-        deb_info("got firmware: %d\n",fw->size);
+        deb_info("got firmware: %zd\n",fw->size);
 
         b = fw->data;
         for (i = 0; i < fw->size;) {
                 addr = le16_to_cpu( *( (u16 *)&b[i] ) );
                 len  = le16_to_cpu( *( (u16 *)&b[i+2] ) );
-                deb_info("firmware chunk, addr: 0x%04x, len: 0x%04x, total length: 0x%04x\n",addr,len,fw->size);
+                deb_info("firmware chunk, addr: 0x%04x, len: 0x%04x, total length: 0x%04zx\n",addr,len,fw->size);
                 if ((ret = bcm3510_write_ram(st,addr,&b[i+4],len)) < 0) {
                         err("firmware download failed: %d\n",ret);
                         return ret;
diff --git a/drivers/media/dvb/frontends/cx22702.c b/drivers/media/dvb/frontends/cx22702.c
index 5de0e6d350b1..0fc899f81c5e 100644
--- a/drivers/media/dvb/frontends/cx22702.c
+++ b/drivers/media/dvb/frontends/cx22702.c
@@ -195,6 +195,16 @@ static int cx22702_get_tps (struct cx22702_state *state, struct dvb_ofdm_paramet
         return 0;
 }
 
+static int cx22702_i2c_gate_ctrl(struct dvb_frontend* fe, int enable)
+{
+        struct cx22702_state* state = fe->demodulator_priv;
+        dprintk ("%s(%d)\n", __FUNCTION__, enable);
+        if (enable)
+                return cx22702_writereg (state, 0x0D, cx22702_readreg(state, 0x0D) & 0xfe);
+        else
+                return cx22702_writereg (state, 0x0D, cx22702_readreg(state, 0x0D) | 1);
+}
+
 /* Talk to the demod, set the FEC, GUARD, QAM settings etc */
 static int cx22702_set_tps (struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
 {
@@ -202,7 +212,7 @@ static int cx22702_set_tps (struct dvb_frontend* fe, struct dvb_frontend_paramet
         struct cx22702_state* state = fe->demodulator_priv;
 
         /* set PLL */
-        cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) &0xfe);
+        cx22702_i2c_gate_ctrl(fe, 1);
         if (state->config->pll_set) {
                 state->config->pll_set(fe, p);
         } else if (state->config->pll_desc) {
@@ -216,7 +226,7 @@ static int cx22702_set_tps (struct dvb_frontend* fe, struct dvb_frontend_paramet
         } else {
                 BUG();
         }
-        cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) | 1);
+        cx22702_i2c_gate_ctrl(fe, 0);
 
         /* set inversion */
         cx22702_set_inversion (state, p->inversion);
@@ -349,11 +359,10 @@ static int cx22702_init (struct dvb_frontend* fe)
         cx22702_writereg (state, 0xf8, (state->config->output_mode << 1) & 0x02);
 
         /* init PLL */
-        if (state->config->pll_init) {
-                cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) & 0xfe);
+        if (state->config->pll_init)
                 state->config->pll_init(fe);
-                cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) | 1);
-        }
+
+        cx22702_i2c_gate_ctrl(fe, 0);
 
         return 0;
 }
@@ -531,6 +540,7 @@ static struct dvb_frontend_ops cx22702_ops = {
         .read_signal_strength = cx22702_read_signal_strength,
         .read_snr = cx22702_read_snr,
         .read_ucblocks = cx22702_read_ucblocks,
+        .i2c_gate_ctrl = cx22702_i2c_gate_ctrl,
 };
 
 module_param(debug, int, 0644);
diff --git a/drivers/media/dvb/frontends/cx24110.c b/drivers/media/dvb/frontends/cx24110.c
index 0c4db80ec332..d15d32c51dc5 100644
--- a/drivers/media/dvb/frontends/cx24110.c
+++ b/drivers/media/dvb/frontends/cx24110.c
@@ -27,7 +27,6 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/init.h>
-#include <linux/jiffies.h>
 
 #include "dvb_frontend.h"
 #include "cx24110.h"
@@ -56,7 +55,7 @@ static int debug;
 
 static struct {u8 reg; u8 data;} cx24110_regdata[]=
                       /* Comments beginning with @ denote this value should
-                         be the default */
+                         be the default */
         {{0x09,0x01}, /* SoftResetAll */
          {0x09,0x00}, /* release reset */
          {0x01,0xe8}, /* MSB of code rate 27.5MS/s */
@@ -67,26 +66,26 @@ static struct {u8 reg; u8 data;} cx24110_regdata[]=
          {0x07,0x01}, /* @ Fclk, i.e. sampling clock, 60MHz */
          {0x0a,0x00}, /* @ partial chip disables, do not set */
          {0x0b,0x01}, /* set output clock in gapped mode, start signal low
-                         active for first byte */
+                         active for first byte */
          {0x0c,0x11}, /* no parity bytes, large hold time, serial data out */
          {0x0d,0x6f}, /* @ RS Sync/Unsync thresholds */
          {0x10,0x40}, /* chip doc is misleading here: write bit 6 as 1
-                         to avoid starting the BER counter. Reset the
-                         CRC test bit. Finite counting selected */
+                         to avoid starting the BER counter. Reset the
+                         CRC test bit. Finite counting selected */
          {0x15,0xff}, /* @ size of the limited time window for RS BER
-                         estimation. It is <value>*256 RS blocks, this
-                         gives approx. 2.6 sec at 27.5MS/s, rate 3/4 */
+                         estimation. It is <value>*256 RS blocks, this
+                         gives approx. 2.6 sec at 27.5MS/s, rate 3/4 */
          {0x16,0x00}, /* @ enable all RS output ports */
          {0x17,0x04}, /* @ time window allowed for the RS to sync */
          {0x18,0xae}, /* @ allow all standard DVB code rates to be scanned
-                         for automatically */
+                         for automatically */
                       /* leave the current code rate and normalization
-                         registers as they are after reset... */
+                         registers as they are after reset... */
          {0x21,0x10}, /* @ during AutoAcq, search each viterbi setting
-                         only once */
+                         only once */
          {0x23,0x18}, /* @ size of the limited time window for Viterbi BER
-                         estimation. It is <value>*65536 channel bits, i.e.
-                         approx. 38ms at 27.5MS/s, rate 3/4 */
+                         estimation. It is <value>*65536 channel bits, i.e.
+                         approx. 38ms at 27.5MS/s, rate 3/4 */
          {0x24,0x24}, /* do not trigger Viterbi CRC test. Finite count window */
                       /* leave front-end AGC parameters at default values */
                       /* leave decimation AGC parameters at default values */
diff --git a/drivers/media/dvb/frontends/cx24123.c b/drivers/media/dvb/frontends/cx24123.c
new file mode 100644
index 000000000000..d661c6f9cbe5
--- /dev/null
+++ b/drivers/media/dvb/frontends/cx24123.c
@@ -0,0 +1,889 @@
+/*
+    Conexant cx24123/cx24109 - DVB QPSK Satellite demod/tuner driver
+
+    Copyright (C) 2005 Steven Toth <stoth@hauppauge.com>
+
+    Support for KWorld DVB-S 100 by Vadim Catana <skystar@moldova.cc>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
+
+#include <linux/slab.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/init.h>
+
+#include "dvb_frontend.h"
+#include "cx24123.h"
+
+static int debug;
+#define dprintk(args...) \
+        do { \
+                if (debug) printk (KERN_DEBUG "cx24123: " args); \
+        } while (0)
+
+struct cx24123_state
+{
+        struct i2c_adapter* i2c;
+        struct dvb_frontend_ops ops;
+        const struct cx24123_config* config;
+
+        struct dvb_frontend frontend;
+
+        u32 lastber;
+        u16 snr;
+        u8  lnbreg;
+
+        /* Some PLL specifics for tuning */
+        u32 VCAarg;
+        u32 VGAarg;
+        u32 bandselectarg;
+        u32 pllarg;
+
+        /* The Demod/Tuner can't easily provide these, we cache them */
+        u32 currentfreq;
+        u32 currentsymbolrate;
+};
+
+/* Various tuner defaults need to be established for a given symbol rate Sps */
+static struct
+{
+        u32 symbolrate_low;
+        u32 symbolrate_high;
+        u32 VCAslope;
+        u32 VCAoffset;
+        u32 VGA1offset;
+        u32 VGA2offset;
+        u32 VCAprogdata;
+        u32 VGAprogdata;
+} cx24123_AGC_vals[] =
+{
+        {
+                .symbolrate_low         = 1000000,
+                .symbolrate_high        = 4999999,
+                .VCAslope               = 0x07,
+                .VCAoffset              = 0x0f,
+                .VGA1offset             = 0x1f8,
+                .VGA2offset             = 0x1f8,
+                .VGAprogdata            = (2 << 18) | (0x1f8 << 9) | 0x1f8,
+                .VCAprogdata            = (4 << 18) | (0x07 << 9) | 0x07,
+        },
+        {
+                .symbolrate_low         =  5000000,
+                .symbolrate_high        = 14999999,
+                .VCAslope               = 0x1f,
+                .VCAoffset              = 0x1f,
+                .VGA1offset             = 0x1e0,
+                .VGA2offset             = 0x180,
+                .VGAprogdata            = (2 << 18) | (0x180 << 9) | 0x1e0,
+                .VCAprogdata            = (4 << 18) | (0x07 << 9) | 0x1f,
+        },
+        {
+                .symbolrate_low         = 15000000,
+                .symbolrate_high        = 45000000,
+                .VCAslope               = 0x3f,
+                .VCAoffset              = 0x3f,
+                .VGA1offset             = 0x180,
+                .VGA2offset             = 0x100,
+                .VGAprogdata            = (2 << 18) | (0x100 << 9) | 0x180,
+                .VCAprogdata            = (4 << 18) | (0x07 << 9) | 0x3f,
+        },
+};
+
+/*
+ * Various tuner defaults need to be established for a given frequency kHz.
+ * fixme: The bounds on the bands do not match the doc in real life.
+ * fixme: Some of them have been moved, other might need adjustment.
+ */
+static struct
+{
+        u32 freq_low;
+        u32 freq_high;
+        u32 bandselect;
+        u32 VCOdivider;
+        u32 VCOnumber;
+        u32 progdata;
+} cx24123_bandselect_vals[] =
+{
+        {
+                .freq_low       = 950000,
+                .freq_high      = 1018999,
+                .bandselect     = 0x40,
+                .VCOdivider     = 4,
+                .VCOnumber      = 7,
+                .progdata       = (0 << 18) | (0 << 9) | 0x40,
+        },
+        {
+                .freq_low       = 1019000,
+                .freq_high      = 1074999,
+                .bandselect     = 0x80,
+                .VCOdivider     = 4,
+                .VCOnumber      = 8,
+                .progdata       = (0 << 18) | (0 << 9) | 0x80,
+        },
+        {
+                .freq_low       = 1075000,
+                .freq_high      = 1227999,
+                .bandselect     = 0x01,
+                .VCOdivider     = 2,
+                .VCOnumber      = 1,
+                .progdata       = (0 << 18) | (1 << 9) | 0x01,
+        },
+        {
+                .freq_low       = 1228000,
+                .freq_high      = 1349999,
+                .bandselect     = 0x02,
+                .VCOdivider     = 2,
+                .VCOnumber      = 2,
+                .progdata       = (0 << 18) | (1 << 9) | 0x02,
+        },
+        {
+                .freq_low       = 1350000,
+                .freq_high      = 1481999,
+                .bandselect     = 0x04,
+                .VCOdivider     = 2,
+                .VCOnumber      = 3,
+                .progdata       = (0 << 18) | (1 << 9) | 0x04,
+        },
+        {
+                .freq_low       = 1482000,
+                .freq_high      = 1595999,
+                .bandselect     = 0x08,
+                .VCOdivider     = 2,
+                .VCOnumber      = 4,
+                .progdata       = (0 << 18) | (1 << 9) | 0x08,
+        },
+        {
+                .freq_low       = 1596000,
+                .freq_high      = 1717999,
+                .bandselect     = 0x10,
+                .VCOdivider     = 2,
+                .VCOnumber      = 5,
+                .progdata       = (0 << 18) | (1 << 9) | 0x10,
+        },
+        {
+                .freq_low       = 1718000,
+                .freq_high      = 1855999,
+                .bandselect     = 0x20,
+                .VCOdivider     = 2,
+                .VCOnumber      = 6,
+                .progdata       = (0 << 18) | (1 << 9) | 0x20,
+        },
+        {
+                .freq_low       = 1856000,
+                .freq_high      = 2035999,
+                .bandselect     = 0x40,
+                .VCOdivider     = 2,
+                .VCOnumber      = 7,
+                .progdata       = (0 << 18) | (1 << 9) | 0x40,
+        },
+        {
+                .freq_low       = 2036000,
+                .freq_high      = 2149999,
+                .bandselect     = 0x80,
+                .VCOdivider     = 2,
+                .VCOnumber      = 8,
+                .progdata       = (0 << 18) | (1 << 9) | 0x80,
+        },
+};
+
+static struct {
+        u8 reg;
+        u8 data;
+} cx24123_regdata[] =
+{
+        {0x00, 0x03}, /* Reset system */
+        {0x00, 0x00}, /* Clear reset */
+        {0x01, 0x3b}, /* Apply sensible defaults, from an i2c sniffer */
+        {0x03, 0x07},
+        {0x04, 0x10},
+        {0x05, 0x04},
+        {0x06, 0x31},
+        {0x0d, 0x02},
+        {0x0e, 0x03},
+        {0x0f, 0xfe},
+        {0x10, 0x01},
+        {0x14, 0x01},
+        {0x15, 0x98},
+        {0x16, 0x00},
+        {0x17, 0x01},
+        {0x1b, 0x05},
+        {0x1c, 0x80},
+        {0x1d, 0x00},
+        {0x1e, 0x00},
+        {0x20, 0x41},
+        {0x21, 0x15},
+        {0x27, 0x14},
+        {0x28, 0x46},
+        {0x29, 0x00},
+        {0x2a, 0xb0},
+        {0x2b, 0x73},
+        {0x2c, 0x00},
+        {0x2d, 0x00},
+        {0x2e, 0x00},
+        {0x2f, 0x00},
+        {0x30, 0x00},
+        {0x31, 0x00},
+        {0x32, 0x8c},
+        {0x33, 0x00},
+        {0x34, 0x00},
+        {0x35, 0x03},
+        {0x36, 0x02},
+        {0x37, 0x3a},
+        {0x3a, 0x00},   /* Enable AGC accumulator */
+        {0x44, 0x00},
+        {0x45, 0x00},
+        {0x46, 0x05},
+        {0x56, 0x41},
+        {0x57, 0xff},
+        {0x67, 0x83},
+};
+
+static int cx24123_writereg(struct cx24123_state* state, int reg, int data)
+{
+        u8 buf[] = { reg, data };
+        struct i2c_msg msg = { .addr = state->config->demod_address, .flags = 0, .buf = buf, .len = 2 };
+        int err;
+
+        if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) {
+                printk("%s: writereg error(err == %i, reg == 0x%02x,"
+                         " data == 0x%02x)\n", __FUNCTION__, err, reg, data);
+                return -EREMOTEIO;
+        }
+
+        return 0;
+}
+
+static int cx24123_writelnbreg(struct cx24123_state* state, int reg, int data)
+{
+        u8 buf[] = { reg, data };
+        /* fixme: put the intersil addr int the config */
+        struct i2c_msg msg = { .addr = 0x08, .flags = 0, .buf = buf, .len = 2 };
+        int err;
+
+        if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) {
+                printk("%s: writelnbreg error (err == %i, reg == 0x%02x,"
+                         " data == 0x%02x)\n", __FUNCTION__, err, reg, data);
+                return -EREMOTEIO;
+        }
+
+        /* cache the write, no way to read back */
+        state->lnbreg = data;
+
+        return 0;
+}
+
+static int cx24123_readreg(struct cx24123_state* state, u8 reg)
+{
+        int ret;
+        u8 b0[] = { reg };
+        u8 b1[] = { 0 };
+        struct i2c_msg msg[] = {
+                { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 1 },
+                { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 1 }
+        };
+
+        ret = i2c_transfer(state->i2c, msg, 2);
+
+        if (ret != 2) {
+                printk("%s: reg=0x%x (error=%d)\n", __FUNCTION__, reg, ret);
+                return ret;
+        }
+
+        return b1[0];
+}
+
+static int cx24123_readlnbreg(struct cx24123_state* state, u8 reg)
+{
+        return state->lnbreg;
+}
+
+static int cx24123_set_inversion(struct cx24123_state* state, fe_spectral_inversion_t inversion)
+{
+        switch (inversion) {
+        case INVERSION_OFF:
+                cx24123_writereg(state, 0x0e, cx24123_readreg(state, 0x0e) & 0x7f);
+                cx24123_writereg(state, 0x10, cx24123_readreg(state, 0x10) | 0x80);
+                break;
+        case INVERSION_ON:
+                cx24123_writereg(state, 0x0e, cx24123_readreg(state, 0x0e) | 0x80);
+                cx24123_writereg(state, 0x10, cx24123_readreg(state, 0x10) | 0x80);
+                break;
+        case INVERSION_AUTO:
+                cx24123_writereg(state, 0x10, cx24123_readreg(state, 0x10) & 0x7f);
+                break;
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+static int cx24123_get_inversion(struct cx24123_state* state, fe_spectral_inversion_t *inversion)
+{
+        u8 val;
+
+        val = cx24123_readreg(state, 0x1b) >> 7;
+
+        if (val == 0)
+                *inversion = INVERSION_OFF;
+        else
+                *inversion = INVERSION_ON;
+
+        return 0;
+}
+
+static int cx24123_set_fec(struct cx24123_state* state, fe_code_rate_t fec)
+{
+        if ( (fec < FEC_NONE) || (fec > FEC_AUTO) )
+                fec = FEC_AUTO;
+
+        /* Hardware has 5/11 and 3/5 but are never unused */
+        switch (fec) {
+        case FEC_NONE:
+                return cx24123_writereg(state, 0x0f, 0x01);
+        case FEC_1_2:
+                return cx24123_writereg(state, 0x0f, 0x02);
+        case FEC_2_3:
+                return cx24123_writereg(state, 0x0f, 0x04);
+        case FEC_3_4:
+                return cx24123_writereg(state, 0x0f, 0x08);
+        case FEC_5_6:
+                return cx24123_writereg(state, 0x0f, 0x20);
+        case FEC_7_8:
+                return cx24123_writereg(state, 0x0f, 0x80);
+        case FEC_AUTO:
+                return cx24123_writereg(state, 0x0f, 0xae);
+        default:
+                return -EOPNOTSUPP;
+        }
+}
+
+static int cx24123_get_fec(struct cx24123_state* state, fe_code_rate_t *fec)
+{
+        int ret;
+        u8 val;
+
+        ret = cx24123_readreg (state, 0x1b);
+        if (ret < 0)
+                return ret;
+        val = ret & 0x07;
+        switch (val) {
+        case 1:
+                *fec = FEC_1_2;
+                break;
+        case 3:
+                *fec = FEC_2_3;
+                break;
+        case 4:
+                *fec = FEC_3_4;
+                break;
+        case 5:
+                *fec = FEC_4_5;
+                break;
+        case 6:
+                *fec = FEC_5_6;
+                break;
+        case 7:
+                *fec = FEC_7_8;
+                break;
+        case 2: /* *fec = FEC_3_5; break; */
+        case 0: /* *fec = FEC_5_11; break; */
+                *fec = FEC_AUTO;
+                break;
+        default:
+                *fec = FEC_NONE; // can't happen
+        }
+
+        return 0;
+}
+
+/* fixme: Symbol rates < 3MSps may not work because of precision loss */
+static int cx24123_set_symbolrate(struct cx24123_state* state, u32 srate)
+{
+        u32 val;
+
+        val = (srate / 1185) * 100;
+
+        /* Compensate for scaling up, by removing 17 symbols per 1Msps */
+        val = val - (17 * (srate / 1000000));
+
+        cx24123_writereg(state, 0x08, (val >> 16) & 0xff );
+        cx24123_writereg(state, 0x09, (val >>  8) & 0xff );
+        cx24123_writereg(state, 0x0a, (val      ) & 0xff );
+
+        return 0;
+}
+
+/*
+ * Based on the required frequency and symbolrate, the tuner AGC has to be configured
+ * and the correct band selected. Calculate those values
+ */
+static int cx24123_pll_calculate(struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        u32 ndiv = 0, adiv = 0, vco_div = 0;
+        int i = 0;
+
+        /* Defaults for low freq, low rate */
+        state->VCAarg = cx24123_AGC_vals[0].VCAprogdata;
+        state->VGAarg = cx24123_AGC_vals[0].VGAprogdata;
+        state->bandselectarg = cx24123_bandselect_vals[0].progdata;
+        vco_div = cx24123_bandselect_vals[0].VCOdivider;
+
+        /* For the given symbolerate, determine the VCA and VGA programming bits */
+        for (i = 0; i < sizeof(cx24123_AGC_vals) / sizeof(cx24123_AGC_vals[0]); i++)
+        {
+                if ((cx24123_AGC_vals[i].symbolrate_low <= p->u.qpsk.symbol_rate) &&
+                                (cx24123_AGC_vals[i].symbolrate_high >= p->u.qpsk.symbol_rate) ) {
+                        state->VCAarg = cx24123_AGC_vals[i].VCAprogdata;
+                        state->VGAarg = cx24123_AGC_vals[i].VGAprogdata;
+                }
+        }
+
+        /* For the given frequency, determine the bandselect programming bits */
+        for (i = 0; i < sizeof(cx24123_bandselect_vals) / sizeof(cx24123_bandselect_vals[0]); i++)
+        {
+                if ((cx24123_bandselect_vals[i].freq_low <= p->frequency) &&
+                                (cx24123_bandselect_vals[i].freq_high >= p->frequency) ) {
+                        state->bandselectarg = cx24123_bandselect_vals[i].progdata;
+                        vco_div = cx24123_bandselect_vals[i].VCOdivider;
+                }
+        }
+
+        /* Determine the N/A dividers for the requested lband freq (in kHz). */
+        /* Note: 10111 (kHz) is the Crystal Freq and divider of 10. */
+        ndiv = ( ((p->frequency * vco_div) / (10111 / 10) / 2) / 32) & 0x1ff;
+        adiv = ( ((p->frequency * vco_div) / (10111 / 10) / 2) % 32) & 0x1f;
+
+        if (adiv == 0)
+                adiv++;
+
+        /* determine the correct pll frequency values. */
+        /* Command 11, refdiv 11, cpump polarity 1, cpump current 3mA 10. */
+        state->pllarg = (3 << 19) | (3 << 17) | (1 << 16) | (2 << 14);
+        state->pllarg |= (ndiv << 5) | adiv;
+
+        return 0;
+}
+
+/*
+ * Tuner data is 21 bits long, must be left-aligned in data.
+ * Tuner cx24109 is written through a dedicated 3wire interface on the demod chip.
+ */
+static int cx24123_pll_writereg(struct dvb_frontend* fe, struct dvb_frontend_parameters *p, u32 data)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        unsigned long timeout;
+
+        /* align the 21 bytes into to bit23 boundary */
+        data = data << 3;
+
+        /* Reset the demod pll word length to 0x15 bits */
+        cx24123_writereg(state, 0x21, 0x15);
+
+        /* write the msb 8 bits, wait for the send to be completed */
+        timeout = jiffies + msecs_to_jiffies(40);
+        cx24123_writereg(state, 0x22, (data >> 16) & 0xff);
+        while ((cx24123_readreg(state, 0x20) & 0x40) == 0) {
+                if (time_after(jiffies, timeout)) {
+                        printk("%s:  demodulator is not responding, possibly hung, aborting.\n", __FUNCTION__);
+                        return -EREMOTEIO;
+                }
+                msleep(10);
+        }
+
+        /* send another 8 bytes, wait for the send to be completed */
+        timeout = jiffies + msecs_to_jiffies(40);
+        cx24123_writereg(state, 0x22, (data>>8) & 0xff );
+        while ((cx24123_readreg(state, 0x20) & 0x40) == 0) {
+                if (time_after(jiffies, timeout)) {
+                        printk("%s:  demodulator is not responding, possibly hung, aborting.\n", __FUNCTION__);
+                        return -EREMOTEIO;
+                }
+                msleep(10);
+        }
+
+        /* send the lower 5 bits of this byte, padded with 3 LBB, wait for the send to be completed */
+        timeout = jiffies + msecs_to_jiffies(40);
+        cx24123_writereg(state, 0x22, (data) & 0xff );
+        while ((cx24123_readreg(state, 0x20) & 0x80)) {
+                if (time_after(jiffies, timeout)) {
+                        printk("%s:  demodulator is not responding, possibly hung, aborting.\n", __FUNCTION__);
+                        return -EREMOTEIO;
+                }
+                msleep(10);
+        }
+
+        /* Trigger the demod to configure the tuner */
+        cx24123_writereg(state, 0x20, cx24123_readreg(state, 0x20) | 2);
+        cx24123_writereg(state, 0x20, cx24123_readreg(state, 0x20) & 0xfd);
+
+        return 0;
+}
+
+static int cx24123_pll_tune(struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+
+        if (cx24123_pll_calculate(fe, p) != 0) {
+                printk("%s: cx24123_pll_calcutate failed\n",__FUNCTION__);
+                return -EINVAL;
+        }
+
+        /* Write the new VCO/VGA */
+        cx24123_pll_writereg(fe, p, state->VCAarg);
+        cx24123_pll_writereg(fe, p, state->VGAarg);
+
+        /* Write the new bandselect and pll args */
+        cx24123_pll_writereg(fe, p, state->bandselectarg);
+        cx24123_pll_writereg(fe, p, state->pllarg);
+
+        return 0;
+}
+
+static int cx24123_initfe(struct dvb_frontend* fe)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        int i;
+
+        /* Configure the demod to a good set of defaults */
+        for (i = 0; i < sizeof(cx24123_regdata) / sizeof(cx24123_regdata[0]); i++)
+                cx24123_writereg(state, cx24123_regdata[i].reg, cx24123_regdata[i].data);
+
+        if (state->config->pll_init)
+                state->config->pll_init(fe);
+
+        /* Configure the LNB for 14V */
+        if (state->config->use_isl6421)
+                cx24123_writelnbreg(state, 0x0, 0x2a);
+
+        return 0;
+}
+
+static int cx24123_set_voltage(struct dvb_frontend* fe, fe_sec_voltage_t voltage)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        u8 val;
+
+        switch (state->config->use_isl6421) {
+
+        case 1:
+
+                val = cx24123_readlnbreg(state, 0x0);
+
+                switch (voltage) {
+                case SEC_VOLTAGE_13:
+                        return cx24123_writelnbreg(state, 0x0, val & 0x32); /* V 13v */
+                case SEC_VOLTAGE_18:
+                        return cx24123_writelnbreg(state, 0x0, val | 0x04); /* H 18v */
+                case SEC_VOLTAGE_OFF:
+                        return cx24123_writelnbreg(state, 0x0, val & 0x30);
+                default:
+                        return -EINVAL;
+                };
+
+        case 0:
+
+                val = cx24123_readreg(state, 0x29);
+
+                switch (voltage) {
+                case SEC_VOLTAGE_13:
+                        dprintk("%s: setting voltage 13V\n", __FUNCTION__);
+                        if (state->config->enable_lnb_voltage)
+                                state->config->enable_lnb_voltage(fe, 1);
+                        return cx24123_writereg(state, 0x29, val | 0x80);
+                case SEC_VOLTAGE_18:
+                        dprintk("%s: setting voltage 18V\n", __FUNCTION__);
+                        if (state->config->enable_lnb_voltage)
+                                state->config->enable_lnb_voltage(fe, 1);
+                        return cx24123_writereg(state, 0x29, val & 0x7f);
+                case SEC_VOLTAGE_OFF:
+                        dprintk("%s: setting voltage off\n", __FUNCTION__);
+                        if (state->config->enable_lnb_voltage)
+                                state->config->enable_lnb_voltage(fe, 0);
+                        return 0;
+                default:
+                        return -EINVAL;
+                };
+        }
+
+        return 0;
+}
+
+static int cx24123_send_diseqc_msg(struct dvb_frontend* fe,
+                                   struct dvb_diseqc_master_cmd *cmd)
+{
+        /* fixme: Implement diseqc */
+        printk("%s: No support yet\n",__FUNCTION__);
+
+        return -ENOTSUPP;
+}
+
+static int cx24123_read_status(struct dvb_frontend* fe, fe_status_t* status)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+
+        int sync = cx24123_readreg(state, 0x14);
+        int lock = cx24123_readreg(state, 0x20);
+
+        *status = 0;
+        if (lock & 0x01)
+                *status |= FE_HAS_CARRIER | FE_HAS_SIGNAL;
+        if (sync & 0x04)
+                *status |= FE_HAS_VITERBI;
+        if (sync & 0x08)
+                *status |= FE_HAS_CARRIER;
+        if (sync & 0x80)
+                *status |= FE_HAS_SYNC | FE_HAS_LOCK;
+
+        return 0;
+}
+
+/*
+ * Configured to return the measurement of errors in blocks, because no UCBLOCKS value
+ * is available, so this value doubles up to satisfy both measurements
+ */
+static int cx24123_read_ber(struct dvb_frontend* fe, u32* ber)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+
+        state->lastber =
+                ((cx24123_readreg(state, 0x1c) & 0x3f) << 16) |
+                (cx24123_readreg(state, 0x1d) << 8 |
+                cx24123_readreg(state, 0x1e));
+
+        /* Do the signal quality processing here, it's derived from the BER. */
+        /* Scale the BER from a 24bit to a SNR 16 bit where higher = better */
+        if (state->lastber < 5000)
+                state->snr = 655*100;
+        else if ( (state->lastber >=   5000) && (state->lastber <  55000) )
+                state->snr = 655*90;
+        else if ( (state->lastber >=  55000) && (state->lastber < 150000) )
+                state->snr = 655*80;
+        else if ( (state->lastber >= 150000) && (state->lastber < 250000) )
+                state->snr = 655*70;
+        else if ( (state->lastber >= 250000) && (state->lastber < 450000) )
+                state->snr = 655*65;
+        else
+                state->snr = 0;
+
+        *ber = state->lastber;
+
+        return 0;
+}
+
+static int cx24123_read_signal_strength(struct dvb_frontend* fe, u16* signal_strength)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        *signal_strength = cx24123_readreg(state, 0x3b) << 8; /* larger = better */
+
+        return 0;
+}
+
+static int cx24123_read_snr(struct dvb_frontend* fe, u16* snr)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        *snr = state->snr;
+
+        return 0;
+}
+
+static int cx24123_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        *ucblocks = state->lastber;
+
+        return 0;
+}
+
+static int cx24123_set_frontend(struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+
+        if (state->config->set_ts_params)
+                state->config->set_ts_params(fe, 0);
+
+        state->currentfreq=p->frequency;
+        state->currentsymbolrate = p->u.qpsk.symbol_rate;
+
+        cx24123_set_inversion(state, p->inversion);
+        cx24123_set_fec(state, p->u.qpsk.fec_inner);
+        cx24123_set_symbolrate(state, p->u.qpsk.symbol_rate);
+        cx24123_pll_tune(fe, p);
+
+        /* Enable automatic aquisition and reset cycle */
+        cx24123_writereg(state, 0x03, (cx24123_readreg(state, 0x03) | 0x07));
+        cx24123_writereg(state, 0x00, 0x10);
+        cx24123_writereg(state, 0x00, 0);
+
+        return 0;
+}
+
+static int cx24123_get_frontend(struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+
+        if (cx24123_get_inversion(state, &p->inversion) != 0) {
+                printk("%s: Failed to get inversion status\n",__FUNCTION__);
+                return -EREMOTEIO;
+        }
+        if (cx24123_get_fec(state, &p->u.qpsk.fec_inner) != 0) {
+                printk("%s: Failed to get fec status\n",__FUNCTION__);
+                return -EREMOTEIO;
+        }
+        p->frequency = state->currentfreq;
+        p->u.qpsk.symbol_rate = state->currentsymbolrate;
+
+        return 0;
+}
+
+static int cx24123_set_tone(struct dvb_frontend* fe, fe_sec_tone_mode_t tone)
+{
+        struct cx24123_state *state = fe->demodulator_priv;
+        u8 val;
+
+        switch (state->config->use_isl6421) {
+        case 1:
+
+                val = cx24123_readlnbreg(state, 0x0);
+
+                switch (tone) {
+                case SEC_TONE_ON:
+                        return cx24123_writelnbreg(state, 0x0, val | 0x10);
+                case SEC_TONE_OFF:
+                        return cx24123_writelnbreg(state, 0x0, val & 0x2f);
+                default:
+                        printk("%s: CASE reached default with tone=%d\n", __FUNCTION__, tone);
+                        return -EINVAL;
+                }
+
+        case 0:
+
+                val = cx24123_readreg(state, 0x29);
+
+                switch (tone) {
+                case SEC_TONE_ON:
+                        dprintk("%s: setting tone on\n", __FUNCTION__);
+                        return cx24123_writereg(state, 0x29, val | 0x10);
+                case SEC_TONE_OFF:
+                        dprintk("%s: setting tone off\n",__FUNCTION__);
+                        return cx24123_writereg(state, 0x29, val & 0xef);
+                default:
+                        printk("%s: CASE reached default with tone=%d\n", __FUNCTION__, tone);
+                        return -EINVAL;
+                }
+        }
+
+        return 0;
+}
+
+static void cx24123_release(struct dvb_frontend* fe)
+{
+        struct cx24123_state* state = fe->demodulator_priv;
+        dprintk("%s\n",__FUNCTION__);
+        kfree(state);
+}
+
+static struct dvb_frontend_ops cx24123_ops;
+
+struct dvb_frontend* cx24123_attach(const struct cx24123_config* config,
+                                    struct i2c_adapter* i2c)
+{
+        struct cx24123_state* state = NULL;
+        int ret;
+
+        dprintk("%s\n",__FUNCTION__);
+
+        /* allocate memory for the internal state */
+        state = kmalloc(sizeof(struct cx24123_state), GFP_KERNEL);
+        if (state == NULL) {
+                printk("Unable to kmalloc\n");
+                goto error;
+        }
+
+        /* setup the state */
+        state->config = config;
+        state->i2c = i2c;
+        memcpy(&state->ops, &cx24123_ops, sizeof(struct dvb_frontend_ops));
+        state->lastber = 0;
+        state->snr = 0;
+        state->lnbreg = 0;
+        state->VCAarg = 0;
+        state->VGAarg = 0;
+        state->bandselectarg = 0;
+        state->pllarg = 0;
+        state->currentfreq = 0;
+        state->currentsymbolrate = 0;
+
+        /* check if the demod is there */
+        ret = cx24123_readreg(state, 0x00);
+        if ((ret != 0xd1) && (ret != 0xe1)) {
+                printk("Version != d1 or e1\n");
+                goto error;
+        }
+
+        /* create dvb_frontend */
+        state->frontend.ops = &state->ops;
+        state->frontend.demodulator_priv = state;
+        return &state->frontend;
+
+error:
+        kfree(state);
+
+        return NULL;
+}
+
+static struct dvb_frontend_ops cx24123_ops = {
+
+        .info = {
+                .name = "Conexant CX24123/CX24109",
+                .type = FE_QPSK,
+                .frequency_min = 950000,
+                .frequency_max = 2150000,
+                .frequency_stepsize = 1011, /* kHz for QPSK frontends */
+                .frequency_tolerance = 29500,
+                .symbol_rate_min = 1000000,
+                .symbol_rate_max = 45000000,
+                .caps = FE_CAN_INVERSION_AUTO |
+                        FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
+                        FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO |
+                        FE_CAN_QPSK | FE_CAN_RECOVER
+        },
+
+        .release = cx24123_release,
+
+        .init = cx24123_initfe,
+        .set_frontend = cx24123_set_frontend,
+        .get_frontend = cx24123_get_frontend,
+        .read_status = cx24123_read_status,
+        .read_ber = cx24123_read_ber,
+        .read_signal_strength = cx24123_read_signal_strength,
+        .read_snr = cx24123_read_snr,
+        .read_ucblocks = cx24123_read_ucblocks,
+        .diseqc_send_master_cmd = cx24123_send_diseqc_msg,
+        .set_tone = cx24123_set_tone,
+        .set_voltage = cx24123_set_voltage,
+};
+
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, "Turn on/off frontend debugging (default:off).");
+
+MODULE_DESCRIPTION("DVB Frontend module for Conexant cx24123/cx24109 hardware");
+MODULE_AUTHOR("Steven Toth");
+MODULE_LICENSE("GPL");
+
+EXPORT_SYMBOL(cx24123_attach);
diff --git a/drivers/media/dvb/frontends/cx24123.h b/drivers/media/dvb/frontends/cx24123.h
new file mode 100644
index 000000000000..0c922b5e9263
--- /dev/null
+++ b/drivers/media/dvb/frontends/cx24123.h
@@ -0,0 +1,51 @@
+/*
+    Conexant cx24123/cx24109 - DVB QPSK Satellite demod/tuner driver
+
+    Copyright (C) 2005 Steven Toth <stoth@hauppauge.com>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
+
+#ifndef CX24123_H
+#define CX24123_H
+
+#include <linux/dvb/frontend.h>
+
+struct cx24123_config
+{
+        /* the demodulator's i2c address */
+        u8 demod_address;
+
+        /*
+           cards like Hauppauge Nova-S Plus/Nova-SE2 use an Intersil ISL6421 chip
+           for LNB control, while KWorld DVB-S 100 use the LNBDC and LNBTone bits
+           from register 0x29 of the CX24123 demodulator
+        */
+        int use_isl6421;
+
+        /* PLL maintenance */
+        int (*pll_init)(struct dvb_frontend* fe);
+        int (*pll_set)(struct dvb_frontend* fe, struct dvb_frontend_parameters* params);
+
+        /* Need to set device param for start_dma */
+        int (*set_ts_params)(struct dvb_frontend* fe, int is_punctured);
+
+        void (*enable_lnb_voltage)(struct dvb_frontend* fe, int on);
+};
+
+extern struct dvb_frontend* cx24123_attach(const struct cx24123_config* config,
+                                           struct i2c_adapter* i2c);
+
+#endif /* CX24123_H */
diff --git a/drivers/media/dvb/frontends/dvb-pll.c b/drivers/media/dvb/frontends/dvb-pll.c
index f857b869616c..a3d57ce9dd12 100644
--- a/drivers/media/dvb/frontends/dvb-pll.c
+++ b/drivers/media/dvb/frontends/dvb-pll.c
@@ -107,18 +107,19 @@ struct dvb_pll_desc dvb_pll_microtune_4042 = {
 };
 EXPORT_SYMBOL(dvb_pll_microtune_4042);
 
-struct dvb_pll_desc dvb_pll_thomson_dtt7611 = {
-        .name  = "Thomson dtt7611",
-        .min   =  44000000,
-        .max   = 958000000,
+struct dvb_pll_desc dvb_pll_thomson_dtt761x = {
+        /* DTT 7611 7611A 7612 7613 7613A 7614 7615 7615A */
+        .name  = "Thomson dtt761x",
+        .min   =  57000000,
+        .max   = 863000000,
         .count = 3,
         .entries = {
-                { 157250000, 44000000, 62500, 0x8e, 0x39 },
-                { 454000000, 44000000, 62500, 0x8e, 0x3a },
+                { 147000000, 44000000, 62500, 0x8e, 0x39 },
+                { 417000000, 44000000, 62500, 0x8e, 0x3a },
                 { 999999999, 44000000, 62500, 0x8e, 0x3c },
         },
 };
-EXPORT_SYMBOL(dvb_pll_thomson_dtt7611);
+EXPORT_SYMBOL(dvb_pll_thomson_dtt761x);
 
 struct dvb_pll_desc dvb_pll_unknown_1 = {
         .name  = "unknown 1", /* used by dntv live dvb-t */
diff --git a/drivers/media/dvb/frontends/dvb-pll.h b/drivers/media/dvb/frontends/dvb-pll.h
index 497d31dcf41e..24d4d2e9acd8 100644
--- a/drivers/media/dvb/frontends/dvb-pll.h
+++ b/drivers/media/dvb/frontends/dvb-pll.h
@@ -25,7 +25,7 @@ extern struct dvb_pll_desc dvb_pll_thomson_dtt759x;
 extern struct dvb_pll_desc dvb_pll_thomson_dtt7610;
 extern struct dvb_pll_desc dvb_pll_lg_z201;
 extern struct dvb_pll_desc dvb_pll_microtune_4042;
-extern struct dvb_pll_desc dvb_pll_thomson_dtt7611;
+extern struct dvb_pll_desc dvb_pll_thomson_dtt761x;
 extern struct dvb_pll_desc dvb_pll_unknown_1;
 
 extern struct dvb_pll_desc dvb_pll_tua6010xs;
diff --git a/drivers/media/dvb/frontends/lgdt330x.c b/drivers/media/dvb/frontends/lgdt330x.c
index cb5301865d07..9d214643b87a 100644
--- a/drivers/media/dvb/frontends/lgdt330x.c
+++ b/drivers/media/dvb/frontends/lgdt330x.c
@@ -27,6 +27,7 @@
  *   DViCO FusionHDTV 3 Gold-T
  *   DViCO FusionHDTV 5 Gold
  *   DViCO FusionHDTV 5 Lite
+ *   DViCO FusionHDTV 5 USB Gold
  *   Air2PC/AirStar 2 ATSC 3rd generation (HD5000)
  *
  * TODO:
@@ -402,6 +403,8 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe,
                 state->config->pll_set(fe, param);
 
         /* Keep track of the new frequency */
+        /* FIXME this is the wrong way to do this...           */
+        /* The tuner is shared with the video4linux analog API */
         state->current_frequency = param->frequency;
 
         lgdt330x_SwReset(state);
diff --git a/drivers/media/dvb/frontends/mt312.c b/drivers/media/dvb/frontends/mt312.c
index 8d672283c93d..ec4e641acc64 100644
--- a/drivers/media/dvb/frontends/mt312.c
+++ b/drivers/media/dvb/frontends/mt312.c
@@ -501,7 +501,8 @@ static int mt312_set_frontend(struct dvb_frontend* fe,
         case ID_VP310:
         // For now we will do this only for the VP310.
         // It should be better for the mt312 as well, but tunning will be slower. ACCJr 09/29/03
-                if ((ret = mt312_readreg(state, CONFIG, &config_val) < 0))
+                ret = mt312_readreg(state, CONFIG, &config_val);
+                if (ret < 0)
                         return ret;
                 if (p->u.qpsk.symbol_rate >= 30000000) //Note that 30MS/s should use 90MHz
                 {
diff --git a/drivers/media/dvb/frontends/nxt2002.c b/drivers/media/dvb/frontends/nxt2002.c
index 52c416043a62..4f263e65ba14 100644
--- a/drivers/media/dvb/frontends/nxt2002.c
+++ b/drivers/media/dvb/frontends/nxt2002.c
@@ -22,7 +22,8 @@
 /*
  * This driver needs external firmware. Please use the command
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware nxt2002" to
- * download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+ * download/extract it, and then copy it to /usr/lib/hotplug/firmware
+ * or /lib/firmware (depending on configuration of firmware hotplug).
  */
 #define NXT2002_DEFAULT_FIRMWARE "dvb-fe-nxt2002.fw"
 #define CRC_CCIT_MASK 0x1021
diff --git a/drivers/media/dvb/frontends/nxt6000.c b/drivers/media/dvb/frontends/nxt6000.c
index a458a3bfff70..a16eeba0020d 100644
--- a/drivers/media/dvb/frontends/nxt6000.c
+++ b/drivers/media/dvb/frontends/nxt6000.c
@@ -574,11 +574,11 @@ static struct dvb_frontend_ops nxt6000_ops = {
                 .symbol_rate_max = 9360000,     /* FIXME */
                 .symbol_rate_tolerance = 4000,
                 .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
-                        FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 |
-                        FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_FEC_AUTO |
-                        FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
-                        FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO |
-                        FE_CAN_HIERARCHY_AUTO,
+                        FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 |
+                        FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_FEC_AUTO |
+                        FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
+                        FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO |
+                        FE_CAN_HIERARCHY_AUTO,
         },
 
         .release = nxt6000_release,
diff --git a/drivers/media/dvb/frontends/or51211.c b/drivers/media/dvb/frontends/or51211.c
index 531f76246e5f..7c3aed1f546b 100644
--- a/drivers/media/dvb/frontends/or51211.c
+++ b/drivers/media/dvb/frontends/or51211.c
@@ -25,7 +25,8 @@
 /*
  * This driver needs external firmware. Please use the command
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware or51211" to
- * download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+ * download/extract it, and then copy it to /usr/lib/hotplug/firmware
+ * or /lib/firmware (depending on configuration of firmware hotplug).
  */
 #define OR51211_DEFAULT_FIRMWARE "dvb-fe-or51211.fw"
 
@@ -112,7 +113,7 @@ static int or51211_load_firmware (struct dvb_frontend* fe,
         u8 tudata[585];
         int i;
 
-        dprintk("Firmware is %d bytes\n",fw->size);
+        dprintk("Firmware is %zd bytes\n",fw->size);
 
         /* Get eprom data */
         tudata[0] = 17;
diff --git a/drivers/media/dvb/frontends/s5h1420.c b/drivers/media/dvb/frontends/s5h1420.c
index 18715091aed8..d69477596921 100644
--- a/drivers/media/dvb/frontends/s5h1420.c
+++ b/drivers/media/dvb/frontends/s5h1420.c
@@ -521,8 +521,8 @@ static void s5h1420_setfec_inversion(struct s5h1420_state* state,
 
                 case FEC_3_4:
                         s5h1420_writereg(state, 0x30, 0x04);
-                        s5h1420_writereg(state, 0x31, 0x12 | inversion);
-                        break;
+                        s5h1420_writereg(state, 0x31, 0x12 | inversion);
+                        break;
 
                 case FEC_5_6:
                         s5h1420_writereg(state, 0x30, 0x08);
diff --git a/drivers/media/dvb/frontends/sp8870.c b/drivers/media/dvb/frontends/sp8870.c
index fc06cd6b46c3..73829e647e50 100644
--- a/drivers/media/dvb/frontends/sp8870.c
+++ b/drivers/media/dvb/frontends/sp8870.c
@@ -22,7 +22,8 @@
 /*
  * This driver needs external firmware. Please use the command
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware alps_tdlb7" to
- * download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+ * download/extract it, and then copy it to /usr/lib/hotplug/firmware
+ * or /lib/firmware (depending on configuration of firmware hotplug).
  */
 #define SP8870_DEFAULT_FIRMWARE "dvb-fe-sp8870.fw"
 
diff --git a/drivers/media/dvb/frontends/sp887x.c b/drivers/media/dvb/frontends/sp887x.c
index e3b665782243..eb8a602198ca 100644
--- a/drivers/media/dvb/frontends/sp887x.c
+++ b/drivers/media/dvb/frontends/sp887x.c
@@ -5,7 +5,8 @@
 /*
  * This driver needs external firmware. Please use the command
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware sp887x" to
- * download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+ * download/extract it, and then copy it to /usr/lib/hotplug/firmware
+ * or /lib/firmware (depending on configuration of firmware hotplug).
  */
 #define SP887X_DEFAULT_FIRMWARE "dvb-fe-sp887x.fw"
 
@@ -581,7 +582,7 @@ static struct dvb_frontend_ops sp887x_ops = {
                 .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
                         FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO |
                         FE_CAN_QPSK | FE_CAN_QAM_16 | FE_CAN_QAM_64 |
-                        FE_CAN_RECOVER
+                        FE_CAN_RECOVER
         },
 
         .release = sp887x_release,
diff --git a/drivers/media/dvb/frontends/stv0299.c b/drivers/media/dvb/frontends/stv0299.c
index 177d71d56b67..5bcd00f792e6 100644
--- a/drivers/media/dvb/frontends/stv0299.c
+++ b/drivers/media/dvb/frontends/stv0299.c
@@ -131,6 +131,13 @@ static int stv0299_readregs (struct stv0299_state* state, u8 reg1, u8 *b, u8 len
         return ret == 2 ? 0 : ret;
 }
 
+int stv0299_enable_plli2c (struct dvb_frontend* fe)
+{
+        struct stv0299_state* state = fe->demodulator_priv;
+
+        return stv0299_writeregI(state, 0x05, 0xb5);    /*  enable i2c repeater on stv0299  */
+}
+
 static int stv0299_set_FEC (struct stv0299_state* state, fe_code_rate_t fec)
 {
         dprintk ("%s\n", __FUNCTION__);
@@ -387,7 +394,7 @@ static int stv0299_set_voltage (struct dvb_frontend* fe, fe_sec_voltage_t voltag
         };
 }
 
-static int stv0299_send_legacy_dish_cmd (struct dvb_frontend* fe, u32 cmd)
+static int stv0299_send_legacy_dish_cmd (struct dvb_frontend* fe, unsigned long cmd)
 {
         struct stv0299_state* state = fe->demodulator_priv;
         u8 reg0x08;
@@ -407,7 +414,7 @@ static int stv0299_send_legacy_dish_cmd (struct dvb_frontend* fe, u32 cmd)
 
         cmd = cmd << 1;
         if (debug_legacy_dish_switch)
-                printk ("%s switch command: 0x%04x\n",__FUNCTION__, cmd);
+                printk ("%s switch command: 0x%04lx\n",__FUNCTION__, cmd);
 
         do_gettimeofday (&nexttime);
         if (debug_legacy_dish_switch)
@@ -717,5 +724,6 @@ MODULE_AUTHOR("Ralph Metzler, Holger Waechtler, Peter Schildmann, Felix Domke, "
               "Andreas Oberritter, Andrew de Quincey, Kenneth Aafløy");
 MODULE_LICENSE("GPL");
 
+EXPORT_SYMBOL(stv0299_enable_plli2c);
 EXPORT_SYMBOL(stv0299_writereg);
 EXPORT_SYMBOL(stv0299_attach);
diff --git a/drivers/media/dvb/frontends/stv0299.h b/drivers/media/dvb/frontends/stv0299.h
index 9af3d71c89db..32c87b4c2f13 100644
--- a/drivers/media/dvb/frontends/stv0299.h
+++ b/drivers/media/dvb/frontends/stv0299.h
@@ -94,6 +94,7 @@ struct stv0299_config
 };
 
 extern int stv0299_writereg (struct dvb_frontend* fe, u8 reg, u8 data);
+extern int stv0299_enable_plli2c (struct dvb_frontend* fe);
 
 extern struct dvb_frontend* stv0299_attach(const struct stv0299_config* config,
                                            struct i2c_adapter* i2c);
diff --git a/drivers/media/dvb/frontends/tda10021.c b/drivers/media/dvb/frontends/tda10021.c
index 425cd19136fe..21255cac9793 100644
--- a/drivers/media/dvb/frontends/tda10021.c
+++ b/drivers/media/dvb/frontends/tda10021.c
@@ -95,7 +95,7 @@ static u8 tda10021_readreg (struct tda10021_state* state, u8 reg)
         u8 b0 [] = { reg };
         u8 b1 [] = { 0 };
         struct i2c_msg msg [] = { { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 1 },
-                                  { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 1 } };
+                                  { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 1 } };
         int ret;
 
         ret = i2c_transfer (state->i2c, msg, 2);
@@ -434,7 +434,7 @@ static struct dvb_frontend_ops tda10021_ops = {
                 .frequency_max = 858000000,
                 .symbol_rate_min = (XIN/2)/64,     /* SACLK/64 == (XIN/2)/64 */
                 .symbol_rate_max = (XIN/2)/4,      /* SACLK/4 */
-        #if 0
+#if 0
                 .frequency_tolerance = ???,
                 .symbol_rate_tolerance = ???,  /* ppm */  /* == 8% (spec p. 5) */
         #endif
diff --git a/drivers/media/dvb/frontends/tda1004x.c b/drivers/media/dvb/frontends/tda1004x.c
index dd02aff467fe..c63e9a5084eb 100644
--- a/drivers/media/dvb/frontends/tda1004x.c
+++ b/drivers/media/dvb/frontends/tda1004x.c
@@ -23,7 +23,8 @@
  * This driver needs external firmware. Please use the commands
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware tda10045",
  * "<kerneldir>/Documentation/dvb/get_dvb_firmware tda10046" to
- * download/extract them, and then copy them to /usr/lib/hotplug/firmware.
+ * download/extract them, and then copy them to /usr/lib/hotplug/firmware
+ * or /lib/firmware (depending on configuration of firmware hotplug).
  */
 #define TDA10045_DEFAULT_FIRMWARE "dvb-fe-tda10045.fw"
 #define TDA10046_DEFAULT_FIRMWARE "dvb-fe-tda10046.fw"
@@ -271,32 +272,57 @@ static int tda10045h_set_bandwidth(struct tda1004x_state *state,
 static int tda10046h_set_bandwidth(struct tda1004x_state *state,
                                    fe_bandwidth_t bandwidth)
 {
-        static u8 bandwidth_6mhz[] = { 0x80, 0x15, 0xfe, 0xab, 0x8e };
-        static u8 bandwidth_7mhz[] = { 0x6e, 0x02, 0x53, 0xc8, 0x25 };
-        static u8 bandwidth_8mhz[] = { 0x60, 0x12, 0xa8, 0xe4, 0xbd };
-
+        static u8 bandwidth_6mhz_53M[] = { 0x7b, 0x2e, 0x11, 0xf0, 0xd2 };
+        static u8 bandwidth_7mhz_53M[] = { 0x6a, 0x02, 0x6a, 0x43, 0x9f };
+        static u8 bandwidth_8mhz_53M[] = { 0x5c, 0x32, 0xc2, 0x96, 0x6d };
+
+        static u8 bandwidth_6mhz_48M[] = { 0x70, 0x02, 0x49, 0x24, 0x92 };
+        static u8 bandwidth_7mhz_48M[] = { 0x60, 0x02, 0xaa, 0xaa, 0xab };
+        static u8 bandwidth_8mhz_48M[] = { 0x54, 0x03, 0x0c, 0x30, 0xc3 };
+        int tda10046_clk53m;
+
+        if ((state->config->if_freq == TDA10046_FREQ_045) ||
+            (state->config->if_freq == TDA10046_FREQ_052))
+                tda10046_clk53m = 0;
+        else
+                tda10046_clk53m = 1;
         switch (bandwidth) {
         case BANDWIDTH_6_MHZ:
-                tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_6mhz, sizeof(bandwidth_6mhz));
+                if (tda10046_clk53m)
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_6mhz_53M,
+                                                  sizeof(bandwidth_6mhz_53M));
+                else
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_6mhz_48M,
+                                                  sizeof(bandwidth_6mhz_48M));
                 if (state->config->if_freq == TDA10046_FREQ_045) {
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x09);
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x4f);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0a);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0xab);
                 }
                 break;
 
         case BANDWIDTH_7_MHZ:
-                tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_7mhz, sizeof(bandwidth_7mhz));
+                if (tda10046_clk53m)
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_7mhz_53M,
+                                                  sizeof(bandwidth_7mhz_53M));
+                else
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_7mhz_48M,
+                                                  sizeof(bandwidth_7mhz_48M));
                 if (state->config->if_freq == TDA10046_FREQ_045) {
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0a);
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x79);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0c);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x00);
                 }
                 break;
 
         case BANDWIDTH_8_MHZ:
-                tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_8mhz, sizeof(bandwidth_8mhz));
+                if (tda10046_clk53m)
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_8mhz_53M,
+                                                  sizeof(bandwidth_8mhz_53M));
+                else
+                        tda1004x_write_buf(state, TDA10046H_TIME_WREF1, bandwidth_8mhz_48M,
+                                                  sizeof(bandwidth_8mhz_48M));
                 if (state->config->if_freq == TDA10046_FREQ_045) {
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0b);
-                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0xa3);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0d);
+                        tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x55);
                 }
                 break;
 
@@ -418,9 +444,22 @@ static int tda10045_fwupload(struct dvb_frontend* fe)
 static void tda10046_init_plls(struct dvb_frontend* fe)
 {
         struct tda1004x_state* state = fe->demodulator_priv;
+        int tda10046_clk53m;
+
+        if ((state->config->if_freq == TDA10046_FREQ_045) ||
+            (state->config->if_freq == TDA10046_FREQ_052))
+                tda10046_clk53m = 0;
+        else
+                tda10046_clk53m = 1;
 
         tda1004x_write_byteI(state, TDA10046H_CONFPLL1, 0xf0);
-        tda1004x_write_byteI(state, TDA10046H_CONFPLL2, 0x0a); // PLL M = 10
+        if(tda10046_clk53m) {
+                printk(KERN_INFO "tda1004x: setting up plls for 53MHz sampling clock\n");
+                tda1004x_write_byteI(state, TDA10046H_CONFPLL2, 0x08); // PLL M = 8
+        } else {
+                printk(KERN_INFO "tda1004x: setting up plls for 48MHz sampling clock\n");
+                tda1004x_write_byteI(state, TDA10046H_CONFPLL2, 0x03); // PLL M = 3
+        }
         if (state->config->xtal_freq == TDA10046_XTAL_4M ) {
                 dprintk("%s: setting up PLLs for a 4 MHz Xtal\n", __FUNCTION__);
                 tda1004x_write_byteI(state, TDA10046H_CONFPLL3, 0); // PLL P = N = 0
@@ -428,26 +467,32 @@ static void tda10046_init_plls(struct dvb_frontend* fe)
                 dprintk("%s: setting up PLLs for a 16 MHz Xtal\n", __FUNCTION__);
                 tda1004x_write_byteI(state, TDA10046H_CONFPLL3, 3); // PLL P = 0, N = 3
         }
-        tda1004x_write_byteI(state, TDA10046H_FREQ_OFFSET, 99);
+        if(tda10046_clk53m)
+                tda1004x_write_byteI(state, TDA10046H_FREQ_OFFSET, 0x67);
+        else
+                tda1004x_write_byteI(state, TDA10046H_FREQ_OFFSET, 0x72);
+        /* Note clock frequency is handled implicitly */
         switch (state->config->if_freq) {
-        case TDA10046_FREQ_3617:
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0xd4);
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x2c);
-                break;
-        case TDA10046_FREQ_3613:
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0xd4);
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x13);
-                break;
         case TDA10046_FREQ_045:
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0b);
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0xa3);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0c);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x00);
                 break;
         case TDA10046_FREQ_052:
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0c);
-                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x06);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0x0d);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0xc7);
+                break;
+        case TDA10046_FREQ_3617:
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0xd7);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x59);
+                break;
+        case TDA10046_FREQ_3613:
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_MSB, 0xd7);
+                tda1004x_write_byteI(state, TDA10046H_FREQ_PHY2_LSB, 0x3f);
                 break;
         }
         tda10046h_set_bandwidth(state, BANDWIDTH_8_MHZ); // default bandwidth 8 MHz
+        /* let the PLLs settle */
+        msleep(120);
 }
 
 static int tda10046_fwupload(struct dvb_frontend* fe)
@@ -462,13 +507,13 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
         /* let the clocks recover from sleep */
         msleep(5);
 
+        /* The PLLs need to be reprogrammed after sleep */
+        tda10046_init_plls(fe);
+
         /* don't re-upload unless necessary */
         if (tda1004x_check_upload_ok(state) == 0)
                 return 0;
 
-        /* set parameters */
-        tda10046_init_plls(fe);
-
         if (state->config->request_firmware != NULL) {
                 /* request the firmware, this will block until someone uploads it */
                 printk(KERN_INFO "tda1004x: waiting for firmware upload...\n");
@@ -484,7 +529,6 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
                         return ret;
         } else {
                 /* boot from firmware eeprom */
-                /* Hac Note: we might need to do some GPIO Magic here */
                 printk(KERN_INFO "tda1004x: booting from eeprom\n");
                 tda1004x_write_mask(state, TDA1004X_CONFC4, 4, 4);
                 msleep(300);
@@ -606,10 +650,9 @@ static int tda10046_init(struct dvb_frontend* fe)
 
         // tda setup
         tda1004x_write_mask(state, TDA1004X_CONFC4, 0x20, 0); // disable DSP watchdog timer
-        tda1004x_write_byteI(state, TDA1004X_AUTO, 7); // select HP stream
-        tda1004x_write_byteI(state, TDA1004X_CONFC1, 8); // disable pulse killer
+        tda1004x_write_byteI(state, TDA1004X_AUTO, 0x87);    // 100 ppm crystal, select HP stream
+        tda1004x_write_byteI(state, TDA1004X_CONFC1, 8);      // disable pulse killer
 
-        tda10046_init_plls(fe);
         switch (state->config->agc_config) {
         case TDA10046_AGC_DEFAULT:
                 tda1004x_write_byteI(state, TDA10046H_AGC_CONF, 0x00); // AGC setup
@@ -626,25 +669,22 @@ static int tda10046_init(struct dvb_frontend* fe)
         case TDA10046_AGC_TDA827X:
                 tda1004x_write_byteI(state, TDA10046H_AGC_CONF, 0x02);   // AGC setup
                 tda1004x_write_byteI(state, TDA10046H_AGC_THR, 0x70);    // AGC Threshold
-                tda1004x_write_byteI(state, TDA10046H_AGC_RENORM, 0x0E); // Gain Renormalize
-                tda1004x_write_byteI(state, TDA10046H_CONF_POLARITY, 0x60); // set AGC polarities
+                tda1004x_write_byteI(state, TDA10046H_AGC_RENORM, 0x08); // Gain Renormalize
+                tda1004x_write_byteI(state, TDA10046H_CONF_POLARITY, 0x6a); // set AGC polarities
                 break;
         }
+        tda1004x_write_byteI(state, TDA1004X_CONFADC2, 0x38);
         tda1004x_write_byteI(state, TDA10046H_CONF_TRISTATE1, 0x61); // Turn both AGC outputs on
         tda1004x_write_byteI(state, TDA10046H_AGC_TUN_MIN, 0);    // }
         tda1004x_write_byteI(state, TDA10046H_AGC_TUN_MAX, 0xff); // } AGC min/max values
         tda1004x_write_byteI(state, TDA10046H_AGC_IF_MIN, 0);     // }
         tda1004x_write_byteI(state, TDA10046H_AGC_IF_MAX, 0xff);  // }
-        tda1004x_write_byteI(state, TDA10046H_AGC_GAINS, 1); // IF gain 2, TUN gain 1
+        tda1004x_write_byteI(state, TDA10046H_AGC_GAINS, 0x12); // IF gain 2, TUN gain 1
         tda1004x_write_byteI(state, TDA10046H_CVBER_CTRL, 0x1a); // 10^6 VBER measurement bits
         tda1004x_write_byteI(state, TDA1004X_CONF_TS1, 7); // MPEG2 interface config
         tda1004x_write_byteI(state, TDA1004X_CONF_TS2, 0xc0); // MPEG2 interface config
         tda1004x_write_mask(state, 0x3a, 0x80, state->config->invert_oclk << 7);
 
-        tda1004x_write_byteI(state, TDA10046H_CONF_TRISTATE2, 0xe1); // tristate setup
-        tda1004x_write_byteI(state, TDA10046H_GPIO_OUT_SEL, 0xcc); // GPIO output config
-        tda1004x_write_byteI(state, TDA10046H_GPIO_SELECT, 8); // GPIO select
-
         state->initialised = 1;
         return 0;
 }
@@ -686,9 +726,9 @@ static int tda1004x_set_fe(struct dvb_frontend* fe,
 
         // Set standard params.. or put them to auto
         if ((fe_params->u.ofdm.code_rate_HP == FEC_AUTO) ||
-            (fe_params->u.ofdm.code_rate_LP == FEC_AUTO) ||
-            (fe_params->u.ofdm.constellation == QAM_AUTO) ||
-            (fe_params->u.ofdm.hierarchy_information == HIERARCHY_AUTO)) {
+                (fe_params->u.ofdm.code_rate_LP == FEC_AUTO) ||
+                (fe_params->u.ofdm.constellation == QAM_AUTO) ||
+                (fe_params->u.ofdm.hierarchy_information == HIERARCHY_AUTO)) {
                 tda1004x_write_mask(state, TDA1004X_AUTO, 1, 1);        // enable auto
                 tda1004x_write_mask(state, TDA1004X_IN_CONF1, 0x03, 0); // turn off constellation bits
                 tda1004x_write_mask(state, TDA1004X_IN_CONF1, 0x60, 0); // turn off hierarchy bits
@@ -851,6 +891,7 @@ static int tda1004x_set_fe(struct dvb_frontend* fe,
 static int tda1004x_get_fe(struct dvb_frontend* fe, struct dvb_frontend_parameters *fe_params)
 {
         struct tda1004x_state* state = fe->demodulator_priv;
+
         dprintk("%s\n", __FUNCTION__);
 
         // inversion status
@@ -875,16 +916,18 @@ static int tda1004x_get_fe(struct dvb_frontend* fe, struct dvb_frontend_paramete
                         break;
                 }
                 break;
-
         case TDA1004X_DEMOD_TDA10046:
                 switch (tda1004x_read_byte(state, TDA10046H_TIME_WREF1)) {
-                case 0x60:
+                case 0x5c:
+                case 0x54:
                         fe_params->u.ofdm.bandwidth = BANDWIDTH_8_MHZ;
                         break;
-                case 0x6e:
+                case 0x6a:
+                case 0x60:
                         fe_params->u.ofdm.bandwidth = BANDWIDTH_7_MHZ;
                         break;
-                case 0x80:
+                case 0x7b:
+                case 0x70:
                         fe_params->u.ofdm.bandwidth = BANDWIDTH_6_MHZ;
                         break;
                 }
diff --git a/drivers/media/dvb/pluto2/Kconfig b/drivers/media/dvb/pluto2/Kconfig
index f02842be0d60..84f8f9f52869 100644
--- a/drivers/media/dvb/pluto2/Kconfig
+++ b/drivers/media/dvb/pluto2/Kconfig
@@ -8,7 +8,7 @@ config DVB_PLUTO2
           Support for PCI cards based on the Pluto2 FPGA like the Satelco
           Easywatch Mobile Terrestrial DVB-T Receiver.
 
-          Since these cards have no MPEG decoder onboard, they transmit
+          Since these cards have no MPEG decoder onboard, they transmit
           only compressed MPEG data over the PCI bus, so you need
           an external software decoder to watch TV on your computer.
 
diff --git a/drivers/media/dvb/ttpci/Kconfig b/drivers/media/dvb/ttpci/Kconfig
index fa5034a9ecf5..5b2aadb8385c 100644
--- a/drivers/media/dvb/ttpci/Kconfig
+++ b/drivers/media/dvb/ttpci/Kconfig
@@ -18,9 +18,10 @@ config DVB_AV7110
           This driver only supports the fullfeatured cards with
           onboard MPEG2 decoder.
 
-          This driver needs an external firmware. Please use the script
-          "<kerneldir>/Documentation/dvb/get_dvb_firmware av7110" to
-          download/extract it, and then copy it to /usr/lib/hotplug/firmware.
+          This driver needs an external firmware. Please use the script
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware av7110" to
+          download/extract it, and then copy it to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
 
           Say Y if you own such a card and want to use it.
 
diff --git a/drivers/media/dvb/ttpci/Makefile b/drivers/media/dvb/ttpci/Makefile
index 825ab1c38a4f..a690730ac39d 100644
--- a/drivers/media/dvb/ttpci/Makefile
+++ b/drivers/media/dvb/ttpci/Makefile
@@ -16,7 +16,7 @@ EXTRA_CFLAGS = -Idrivers/media/dvb/dvb-core/ -Idrivers/media/dvb/frontends/
 hostprogs-y     := fdump
 
 ifdef CONFIG_DVB_AV7110_FIRMWARE
-$(obj)/av7110.o: $(obj)/fdump $(obj)/av7110_firm.h 
+$(obj)/av7110.o: $(obj)/fdump $(obj)/av7110_firm.h
 
 $(obj)/av7110_firm.h:
         $(obj)/fdump $(CONFIG_DVB_AV7110_FIRMWARE_FILE) dvb_ttpci_fw $@
diff --git a/drivers/media/dvb/ttpci/av7110.c b/drivers/media/dvb/ttpci/av7110.c
index 7dae91e5863c..8ce4146f55f1 100644
--- a/drivers/media/dvb/ttpci/av7110.c
+++ b/drivers/media/dvb/ttpci/av7110.c
@@ -133,7 +133,13 @@ static void init_av7110_av(struct av7110 *av7110)
         /* remaining inits according to card and frontend type */
         av7110->analog_tuner_flags = 0;
         av7110->current_input = 0;
-        if (i2c_writereg(av7110, 0x20, 0x00, 0x00) == 1) {
+        if (dev->pci->subsystem_vendor == 0x13c2 && dev->pci->subsystem_device == 0x000a) {
+                printk("dvb-ttpci: MSP3415 audio DAC @ card %d\n",
+                        av7110->dvb_adapter.num);
+                av7110->adac_type = DVB_ADAC_MSP34x5;
+                av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, ADSwitch, 1, 0); // SPDIF on
+        }
+        else if (i2c_writereg(av7110, 0x20, 0x00, 0x00) == 1) {
                 printk ("dvb-ttpci: Crystal audio DAC @ card %d detected\n",
                         av7110->dvb_adapter.num);
                 av7110->adac_type = DVB_ADAC_CRYSTAL;
@@ -156,10 +162,10 @@ static void init_av7110_av(struct av7110 *av7110)
         else {
                 av7110->adac_type = adac;
                 printk("dvb-ttpci: adac type set to %d @ card %d\n",
-                        av7110->dvb_adapter.num, av7110->adac_type);
+                        av7110->adac_type, av7110->dvb_adapter.num);
         }
 
-        if (av7110->adac_type == DVB_ADAC_NONE || av7110->adac_type == DVB_ADAC_MSP) {
+        if (av7110->adac_type == DVB_ADAC_NONE || av7110->adac_type == DVB_ADAC_MSP34x0) {
                 // switch DVB SCART on
                 ret = av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, MainSwitch, 1, 0);
                 if (ret < 0)
@@ -190,17 +196,15 @@ static void recover_arm(struct av7110 *av7110)
 
         av7110_bootarm(av7110);
         msleep(100);
-        restart_feeds(av7110);
-        av7110_fw_cmd(av7110, COMTYPE_PIDFILTER, SetIR, 1, av7110->ir_config);
-}
 
-static void arm_error(struct av7110 *av7110)
-{
-        dprintk(4, "%p\n",av7110);
+        init_av7110_av(av7110);
+
+        /* card-specific recovery */
+        if (av7110->recover)
+                av7110->recover(av7110);
 
-        av7110->arm_errors++;
-        av7110->arm_ready = 0;
-        recover_arm(av7110);
+        restart_feeds(av7110);
+        av7110_fw_cmd(av7110, COMTYPE_PIDFILTER, SetIR, 1, av7110->ir_config);
 }
 
 static void av7110_arm_sync(struct av7110 *av7110)
@@ -240,26 +244,22 @@ static int arm_thread(void *data)
 
                 if (down_interruptible(&av7110->dcomlock))
                         break;
-
                 newloops = rdebi(av7110, DEBINOSWAP, STATUS_LOOPS, 0, 2);
                 up(&av7110->dcomlock);
 
-                if (newloops == av7110->arm_loops) {
+                if (newloops == av7110->arm_loops || av7110->arm_errors > 3) {
                         printk(KERN_ERR "dvb-ttpci: ARM crashed @ card %d\n",
                                av7110->dvb_adapter.num);
 
-                        arm_error(av7110);
-                        av7710_set_video_mode(av7110, vidmode);
-
-                        init_av7110_av(av7110);
+                        recover_arm(av7110);
 
                         if (down_interruptible(&av7110->dcomlock))
                                 break;
-
                         newloops = rdebi(av7110, DEBINOSWAP, STATUS_LOOPS, 0, 2) - 1;
                         up(&av7110->dcomlock);
                 }
                 av7110->arm_loops = newloops;
+                av7110->arm_errors = 0;
         }
 
         av7110->arm_thread = NULL;
@@ -510,10 +510,6 @@ static void gpioirq(unsigned long data)
                 iwdebi(av7110, DEBINOSWAP, RX_BUFF, 0, 2);
 
                 av7110->video_size.h = h_ar & 0xfff;
-                dprintk(8, "GPIO0 irq: DATA_MPEG_VIDEO_EVENT: w/h/ar = %u/%u/%u\n",
-                        av7110->video_size.w,
-                        av7110->video_size.h,
-                        av7110->video_size.aspect_ratio);
 
                 event.type = VIDEO_EVENT_SIZE_CHANGED;
                 event.u.size.w = av7110->video_size.w;
@@ -535,6 +531,11 @@ static void gpioirq(unsigned long data)
                         event.u.size.aspect_ratio = VIDEO_FORMAT_4_3;
                         av7110->videostate.video_format = VIDEO_FORMAT_4_3;
                 }
+
+                dprintk(8, "GPIO0 irq: DATA_MPEG_VIDEO_EVENT: w/h/ar = %u/%u/%u\n",
+                        av7110->video_size.w, av7110->video_size.h,
+                        av7110->video_size.aspect_ratio);
+
                 dvb_video_add_event(av7110, &event);
                 break;
         }
@@ -714,6 +715,8 @@ static struct dvb_device dvbdev_osd = {
 static inline int SetPIDs(struct av7110 *av7110, u16 vpid, u16 apid, u16 ttpid,
                           u16 subpid, u16 pcrpid)
 {
+        u16 aflags = 0;
+
         dprintk(4, "%p\n", av7110);
 
         if (vpid == 0x1fff || apid == 0x1fff ||
@@ -725,8 +728,11 @@ static inline int SetPIDs(struct av7110 *av7110, u16 vpid, u16 apid, u16 ttpid,
                 av7110->pids[DMX_PES_PCR] = 0;
         }
 
-        return av7110_fw_cmd(av7110, COMTYPE_PIDFILTER, MultiPID, 5,
-                             pcrpid, vpid, apid, ttpid, subpid);
+        if (av7110->audiostate.bypass_mode)
+                aflags |= 0x8000;
+
+        return av7110_fw_cmd(av7110, COMTYPE_PIDFILTER, MultiPID, 6,
+                             pcrpid, vpid, apid, ttpid, subpid, aflags);
 }
 
 int ChangePIDs(struct av7110 *av7110, u16 vpid, u16 apid, u16 ttpid,
@@ -1043,7 +1049,7 @@ static void restart_feeds(struct av7110 *av7110)
         struct dvb_demux *dvbdmx = &av7110->demux;
         struct dvb_demux_feed *feed;
         int mode;
-        int i;
+        int i, j;
 
         dprintk(4, "%p\n", av7110);
 
@@ -1051,10 +1057,21 @@ static void restart_feeds(struct av7110 *av7110)
         av7110->playing = 0;
         av7110->rec_mode = 0;
 
-        for (i = 0; i < dvbdmx->filternum; i++) {
+        for (i = 0; i < dvbdmx->feednum; i++) {
                 feed = &dvbdmx->feed[i];
-                if (feed->state == DMX_STATE_GO)
+                if (feed->state == DMX_STATE_GO) {
+                        if (feed->type == DMX_TYPE_SEC) {
+                                for (j = 0; j < dvbdmx->filternum; j++) {
+                                        if (dvbdmx->filter[j].type != DMX_TYPE_SEC)
+                                                continue;
+                                        if (dvbdmx->filter[j].filter.parent != &feed->feed.sec)
+                                                continue;
+                                        if (dvbdmx->filter[j].state == DMX_STATE_GO)
+                                                dvbdmx->filter[j].state = DMX_STATE_READY;
+                                }
+                        }
                         av7110_start_feed(feed);
+                }
         }
 
         if (mode)
@@ -1483,9 +1500,9 @@ static int get_firmware(struct av7110* av7110)
                 if (ret == -ENOENT) {
                         printk(KERN_ERR "dvb-ttpci: could not load firmware,"
                                " file not found: dvb-ttpci-01.fw\n");
-                        printk(KERN_ERR "dvb-ttpci: usually this should be in"
-                               " /usr/lib/hotplug/firmware\n");
-                        printk(KERN_ERR "dvb-ttpci: and can be downloaded here"
+                        printk(KERN_ERR "dvb-ttpci: usually this should be in "
+                               "/usr/lib/hotplug/firmware or /lib/firmware\n");
+                        printk(KERN_ERR "dvb-ttpci: and can be downloaded from"
                                " http://www.linuxtv.org/download/dvb/firmware/\n");
                 } else
                         printk(KERN_ERR "dvb-ttpci: cannot request firmware"
@@ -2110,8 +2127,10 @@ static int av7110_fe_set_frontend(struct dvb_frontend* fe, struct dvb_frontend_p
         struct av7110* av7110 = fe->dvb->priv;
 
         int ret = av7110_fe_lock_fix(av7110, 0);
-        if (!ret)
+        if (!ret) {
+                av7110->saved_fe_params = *params;
                 ret = av7110->fe_set_frontend(fe, params);
+        }
         return ret;
 }
 
@@ -2153,8 +2172,10 @@ static int av7110_fe_diseqc_send_master_cmd(struct dvb_frontend* fe,
         struct av7110* av7110 = fe->dvb->priv;
 
         int ret = av7110_fe_lock_fix(av7110, 0);
-        if (!ret)
+        if (!ret) {
+                av7110->saved_master_cmd = *cmd;
                 ret = av7110->fe_diseqc_send_master_cmd(fe, cmd);
+        }
         return ret;
 }
 
@@ -2163,8 +2184,10 @@ static int av7110_fe_diseqc_send_burst(struct dvb_frontend* fe, fe_sec_mini_cmd_
         struct av7110* av7110 = fe->dvb->priv;
 
         int ret = av7110_fe_lock_fix(av7110, 0);
-        if (!ret)
+        if (!ret) {
+                av7110->saved_minicmd = minicmd;
                 ret = av7110->fe_diseqc_send_burst(fe, minicmd);
+        }
         return ret;
 }
 
@@ -2173,8 +2196,10 @@ static int av7110_fe_set_tone(struct dvb_frontend* fe, fe_sec_tone_mode_t tone)
         struct av7110* av7110 = fe->dvb->priv;
 
         int ret = av7110_fe_lock_fix(av7110, 0);
-        if (!ret)
+        if (!ret) {
+                av7110->saved_tone = tone;
                 ret = av7110->fe_set_tone(fe, tone);
+        }
         return ret;
 }
 
@@ -2183,12 +2208,14 @@ static int av7110_fe_set_voltage(struct dvb_frontend* fe, fe_sec_voltage_t volta
         struct av7110* av7110 = fe->dvb->priv;
 
         int ret = av7110_fe_lock_fix(av7110, 0);
-        if (!ret)
+        if (!ret) {
+                av7110->saved_voltage = voltage;
                 ret = av7110->fe_set_voltage(fe, voltage);
+        }
         return ret;
 }
 
-static int av7110_fe_dishnetwork_send_legacy_command(struct dvb_frontend* fe, unsigned int cmd)
+static int av7110_fe_dishnetwork_send_legacy_command(struct dvb_frontend* fe, unsigned long cmd)
 {
         struct av7110* av7110 = fe->dvb->priv;
 
@@ -2198,6 +2225,23 @@ static int av7110_fe_dishnetwork_send_legacy_command(struct dvb_frontend* fe, un
         return ret;
 }
 
+static void dvb_s_recover(struct av7110* av7110)
+{
+        av7110_fe_init(av7110->fe);
+
+        av7110_fe_set_voltage(av7110->fe, av7110->saved_voltage);
+        if (av7110->saved_master_cmd.msg_len) {
+                msleep(20);
+                av7110_fe_diseqc_send_master_cmd(av7110->fe, &av7110->saved_master_cmd);
+        }
+        msleep(20);
+        av7110_fe_diseqc_send_burst(av7110->fe, av7110->saved_minicmd);
+        msleep(20);
+        av7110_fe_set_tone(av7110->fe, av7110->saved_tone);
+
+        av7110_fe_set_frontend(av7110->fe, &av7110->saved_fe_params);
+}
+
 static u8 read_pwm(struct av7110* av7110)
 {
         u8 b = 0xff;
@@ -2235,6 +2279,7 @@ static int frontend_init(struct av7110 *av7110)
                                 av7110->fe->ops->diseqc_send_master_cmd = av7110_diseqc_send_master_cmd;
                                 av7110->fe->ops->diseqc_send_burst = av7110_diseqc_send_burst;
                                 av7110->fe->ops->set_tone = av7110_set_tone;
+                                av7110->recover = dvb_s_recover;
                                 break;
                         }
 
@@ -2244,15 +2289,17 @@ static int frontend_init(struct av7110 *av7110)
                                 av7110->fe->ops->diseqc_send_master_cmd = av7110_diseqc_send_master_cmd;
                                 av7110->fe->ops->diseqc_send_burst = av7110_diseqc_send_burst;
                                 av7110->fe->ops->set_tone = av7110_set_tone;
+                                av7110->recover = dvb_s_recover;
                                 break;
                         }
 
                         // Try the grundig 29504-451
-                        av7110->fe = tda8083_attach(&grundig_29504_451_config, &av7110->i2c_adap);
+                        av7110->fe = tda8083_attach(&grundig_29504_451_config, &av7110->i2c_adap);
                         if (av7110->fe) {
                                 av7110->fe->ops->diseqc_send_master_cmd = av7110_diseqc_send_master_cmd;
                                 av7110->fe->ops->diseqc_send_burst = av7110_diseqc_send_burst;
                                 av7110->fe->ops->set_tone = av7110_set_tone;
+                                av7110->recover = dvb_s_recover;
                                 break;
                         }
 
@@ -2274,12 +2321,12 @@ static int frontend_init(struct av7110 *av7110)
                 case 0x0001: // Hauppauge/TT Nexus-T premium rev1.X
 
                         // ALPS TDLB7
-                        av7110->fe = sp8870_attach(&alps_tdlb7_config, &av7110->i2c_adap);
+                        av7110->fe = sp8870_attach(&alps_tdlb7_config, &av7110->i2c_adap);
                         break;
 
                 case 0x0002: // Hauppauge/TT DVB-C premium rev2.X
 
-                        av7110->fe = ves1820_attach(&alps_tdbe2_config, &av7110->i2c_adap, read_pwm(av7110));
+                        av7110->fe = ves1820_attach(&alps_tdbe2_config, &av7110->i2c_adap, read_pwm(av7110));
                         break;
 
                 case 0x0006: /* Fujitsu-Siemens DVB-S rev 1.6 */
@@ -2289,6 +2336,7 @@ static int frontend_init(struct av7110 *av7110)
                                 av7110->fe->ops->diseqc_send_master_cmd = av7110_diseqc_send_master_cmd;
                                 av7110->fe->ops->diseqc_send_burst = av7110_diseqc_send_burst;
                                 av7110->fe->ops->set_tone = av7110_set_tone;
+                                av7110->recover = dvb_s_recover;
                         }
                         break;
 
@@ -2314,8 +2362,11 @@ static int frontend_init(struct av7110 *av7110)
                 case 0x000E: /* Hauppauge/TT Nexus-S rev 2.3 */
                         /* ALPS BSBE1 */
                         av7110->fe = stv0299_attach(&alps_bsbe1_config, &av7110->i2c_adap);
-                        if (av7110->fe)
+                        if (av7110->fe) {
                                 av7110->fe->ops->set_voltage = lnbp21_set_voltage;
+                                av7110->fe->ops->dishnetwork_send_legacy_command = NULL;
+                                av7110->recover = dvb_s_recover;
+                        }
                         break;
                 }
         }
diff --git a/drivers/media/dvb/ttpci/av7110.h b/drivers/media/dvb/ttpci/av7110.h
index cce00ef293e9..6ea30df2e823 100644
--- a/drivers/media/dvb/ttpci/av7110.h
+++ b/drivers/media/dvb/ttpci/av7110.h
@@ -98,7 +98,8 @@ struct av7110 {
         int adac_type;         /* audio DAC type */
 #define DVB_ADAC_TI       0
 #define DVB_ADAC_CRYSTAL  1
-#define DVB_ADAC_MSP      2
+#define DVB_ADAC_MSP34x0  2
+#define DVB_ADAC_MSP34x5  3
 #define DVB_ADAC_NONE    -1
 
 
@@ -228,6 +229,9 @@ struct av7110 {
         struct dvb_video_events  video_events;
         video_size_t             video_size;
 
+        u16                     wssMode;
+        u16                     wssData;
+
         u32                     ir_config;
         u32                     ir_command;
         void                    (*ir_handler)(struct av7110 *av7110, u32 ircom);
@@ -245,6 +249,15 @@ struct av7110 {
 
         struct dvb_frontend* fe;
         fe_status_t fe_status;
+
+        /* crash recovery */
+        void                            (*recover)(struct av7110* av7110);
+        struct dvb_frontend_parameters  saved_fe_params;
+        fe_sec_voltage_t                saved_voltage;
+        fe_sec_tone_mode_t              saved_tone;
+        struct dvb_diseqc_master_cmd    saved_master_cmd;
+        fe_sec_mini_cmd_t               saved_minicmd;
+
         int (*fe_init)(struct dvb_frontend* fe);
         int (*fe_read_status)(struct dvb_frontend* fe, fe_status_t* status);
         int (*fe_diseqc_reset_overload)(struct dvb_frontend* fe);
@@ -252,7 +265,7 @@ struct av7110 {
         int (*fe_diseqc_send_burst)(struct dvb_frontend* fe, fe_sec_mini_cmd_t minicmd);
         int (*fe_set_tone)(struct dvb_frontend* fe, fe_sec_tone_mode_t tone);
         int (*fe_set_voltage)(struct dvb_frontend* fe, fe_sec_voltage_t voltage);
-        int (*fe_dishnetwork_send_legacy_command)(struct dvb_frontend* fe, unsigned int cmd);
+        int (*fe_dishnetwork_send_legacy_command)(struct dvb_frontend* fe, unsigned long cmd);
         int (*fe_set_frontend)(struct dvb_frontend* fe, struct dvb_frontend_parameters* params);
 };
 
diff --git a/drivers/media/dvb/ttpci/av7110_av.c b/drivers/media/dvb/ttpci/av7110_av.c
index 0696a5a4f855..400facec7407 100644
--- a/drivers/media/dvb/ttpci/av7110_av.c
+++ b/drivers/media/dvb/ttpci/av7110_av.c
@@ -309,7 +309,7 @@ int av7110_set_volume(struct av7110 *av7110, int volleft, int volright)
                 i2c_writereg(av7110, 0x20, 0x04, volright);
                 return 0;
 
-        case DVB_ADAC_MSP:
+        case DVB_ADAC_MSP34x0:
                 vol  = (volleft > volright) ? volleft : volright;
                 val     = (vol * 0x73 / 255) << 8;
                 if (vol > 0)
@@ -1256,7 +1256,9 @@ static int dvb_audio_ioctl(struct inode *inode, struct file *file,
                 break;
 
         case AUDIO_SET_BYPASS_MODE:
-                ret = -EINVAL;
+                if (FW_VERSION(av7110->arm_app) < 0x2621)
+                        ret = -EINVAL;
+                av7110->audiostate.bypass_mode = (int)arg;
                 break;
 
         case AUDIO_CHANNEL_SELECT:
@@ -1295,7 +1297,11 @@ static int dvb_audio_ioctl(struct inode *inode, struct file *file,
                 break;
 
         case AUDIO_GET_CAPABILITIES:
-                *(int *)parg = AUDIO_CAP_LPCM | AUDIO_CAP_MP1 | AUDIO_CAP_MP2;
+                if (FW_VERSION(av7110->arm_app) < 0x2621)
+                        *(unsigned int *)parg = AUDIO_CAP_LPCM | AUDIO_CAP_MP1 | AUDIO_CAP_MP2;
+                else
+                        *(unsigned int *)parg = AUDIO_CAP_LPCM | AUDIO_CAP_DTS | AUDIO_CAP_AC3 |
+                                                AUDIO_CAP_MP1 | AUDIO_CAP_MP2;
                 break;
 
         case AUDIO_CLEAR_BUFFER:
diff --git a/drivers/media/dvb/ttpci/av7110_hw.c b/drivers/media/dvb/ttpci/av7110_hw.c
index 87106e8bf35b..cb377452b57d 100644
--- a/drivers/media/dvb/ttpci/av7110_hw.c
+++ b/drivers/media/dvb/ttpci/av7110_hw.c
@@ -230,6 +230,8 @@ int av7110_bootarm(struct av7110 *av7110)
 
         dprintk(4, "%p\n", av7110);
 
+        av7110->arm_ready = 0;
+
         saa7146_setgpio(dev, RESET_LINE, SAA7146_GPIO_OUTLO);
 
         /* Disable DEBI and GPIO irq */
@@ -361,6 +363,7 @@ static int __av7110_send_fw_cmd(struct av7110 *av7110, u16* buf, int length)
                         break;
                 if (err) {
                         printk(KERN_ERR "dvb-ttpci: %s(): timeout waiting for COMMAND idle\n", __FUNCTION__);
+                        av7110->arm_errors++;
                         return -ETIMEDOUT;
                 }
                 msleep(1);
@@ -1206,9 +1209,9 @@ int av7110_osd_capability(struct av7110 *av7110, osd_cap_t *cap)
         switch (cap->cmd) {
         case OSD_CAP_MEMSIZE:
                 if (FW_4M_SDRAM(av7110->arm_app))
-                        cap->val = 1000000;
+                        cap->val = 1000000;
                 else
-                        cap->val = 92000;
+                        cap->val = 92000;
                 return 0;
         default:
                 return -EINVAL;
diff --git a/drivers/media/dvb/ttpci/av7110_hw.h b/drivers/media/dvb/ttpci/av7110_hw.h
index 2a5e87ba1052..84b83299b8be 100644
--- a/drivers/media/dvb/ttpci/av7110_hw.h
+++ b/drivers/media/dvb/ttpci/av7110_hw.h
@@ -167,7 +167,8 @@ enum av7110_encoder_command {
         LoadVidCode,
         SetMonitorType,
         SetPanScanType,
-        SetFreezeMode
+        SetFreezeMode,
+        SetWSSConfig
 };
 
 enum av7110_rec_play_state {
diff --git a/drivers/media/dvb/ttpci/av7110_ir.c b/drivers/media/dvb/ttpci/av7110_ir.c
index f5e59fc924af..9138132ad25f 100644
--- a/drivers/media/dvb/ttpci/av7110_ir.c
+++ b/drivers/media/dvb/ttpci/av7110_ir.c
@@ -17,6 +17,8 @@ static int av_cnt;
 static struct av7110 *av_list[4];
 static struct input_dev *input_dev;
 
+static u8 delay_timer_finished;
+
 static u16 key_map [256] = {
         KEY_0, KEY_1, KEY_2, KEY_3, KEY_4, KEY_5, KEY_6, KEY_7,
         KEY_8, KEY_9, KEY_BACK, 0, KEY_POWER, KEY_MUTE, 0, KEY_INFO,
@@ -112,13 +114,16 @@ static void av7110_emit_key(unsigned long parm)
         if (timer_pending(&keyup_timer)) {
                 del_timer(&keyup_timer);
                 if (keyup_timer.data != keycode || new_toggle != old_toggle) {
+                        delay_timer_finished = 0;
                         input_event(input_dev, EV_KEY, keyup_timer.data, !!0);
                         input_event(input_dev, EV_KEY, keycode, !0);
                 } else
-                        input_event(input_dev, EV_KEY, keycode, 2);
-
-        } else
+                        if (delay_timer_finished)
+                                input_event(input_dev, EV_KEY, keycode, 2);
+        } else {
+                delay_timer_finished = 0;
                 input_event(input_dev, EV_KEY, keycode, !0);
+        }
 
         keyup_timer.expires = jiffies + UP_TIMEOUT;
         keyup_timer.data = keycode;
@@ -145,7 +150,8 @@ static void input_register_keys(void)
 
 static void input_repeat_key(unsigned long data)
 {
-       /* dummy routine to disable autorepeat in the input driver */
+        /* called by the input driver after rep[REP_DELAY] ms */
+        delay_timer_finished = 1;
 }
 
 
diff --git a/drivers/media/dvb/ttpci/av7110_v4l.c b/drivers/media/dvb/ttpci/av7110_v4l.c
index b5aea4129fa7..94cf38c7e8a8 100644
--- a/drivers/media/dvb/ttpci/av7110_v4l.c
+++ b/drivers/media/dvb/ttpci/av7110_v4l.c
@@ -490,6 +490,58 @@ static int av7110_ioctl(struct saa7146_fh *fh, unsigned int cmd, void *arg)
                 dprintk(2, "VIDIOC_S_AUDIO: %d\n", a->index);
                 break;
         }
+        case VIDIOC_G_SLICED_VBI_CAP:
+        {
+                struct v4l2_sliced_vbi_cap *cap = arg;
+                dprintk(2, "VIDIOC_G_SLICED_VBI_CAP\n");
+                memset(cap, 0, sizeof *cap);
+                if (FW_VERSION(av7110->arm_app) >= 0x2623) {
+                        cap->service_set = V4L2_SLICED_WSS_625;
+                        cap->service_lines[0][23] = V4L2_SLICED_WSS_625;
+                }
+                break;
+        }
+        case VIDIOC_G_FMT:
+        {
+                struct v4l2_format *f = arg;
+                dprintk(2, "VIDIOC_G_FMT:\n");
+                if (f->type != V4L2_BUF_TYPE_SLICED_VBI_OUTPUT ||
+                    FW_VERSION(av7110->arm_app) < 0x2623)
+                        return -EAGAIN; /* handled by core driver */
+                memset(&f->fmt.sliced, 0, sizeof f->fmt.sliced);
+                if (av7110->wssMode) {
+                        f->fmt.sliced.service_set = V4L2_SLICED_WSS_625;
+                        f->fmt.sliced.service_lines[0][23] = V4L2_SLICED_WSS_625;
+                        f->fmt.sliced.io_size = sizeof (struct v4l2_sliced_vbi_data);
+                }
+                break;
+        }
+        case VIDIOC_S_FMT:
+        {
+                struct v4l2_format *f = arg;
+                dprintk(2, "VIDIOC_S_FMT\n");
+                if (f->type != V4L2_BUF_TYPE_SLICED_VBI_OUTPUT ||
+                    FW_VERSION(av7110->arm_app) < 0x2623)
+                        return -EAGAIN; /* handled by core driver */
+                if (f->fmt.sliced.service_set != V4L2_SLICED_WSS_625 &&
+                    f->fmt.sliced.service_lines[0][23] != V4L2_SLICED_WSS_625) {
+                        memset(&f->fmt.sliced, 0, sizeof f->fmt.sliced);
+                        /* WSS controlled by firmware */
+                        av7110->wssMode = 0;
+                        av7110->wssData = 0;
+                        return av7110_fw_cmd(av7110, COMTYPE_ENCODER,
+                                             SetWSSConfig, 1, 0);
+                } else {
+                        memset(&f->fmt.sliced, 0, sizeof f->fmt.sliced);
+                        f->fmt.sliced.service_set = V4L2_SLICED_WSS_625;
+                        f->fmt.sliced.service_lines[0][23] = V4L2_SLICED_WSS_625;
+                        f->fmt.sliced.io_size = sizeof (struct v4l2_sliced_vbi_data);
+                        /* WSS controlled by userspace */
+                        av7110->wssMode = 1;
+                        av7110->wssData = 0;
+                }
+                break;
+        }
         default:
                 printk("no such ioctl\n");
                 return -ENOIOCTLCMD;
@@ -497,6 +549,46 @@ static int av7110_ioctl(struct saa7146_fh *fh, unsigned int cmd, void *arg)
         return 0;
 }
 
+static int av7110_vbi_reset(struct inode *inode, struct file *file)
+{
+        struct saa7146_fh *fh = file->private_data;
+        struct saa7146_dev *dev = fh->dev;
+        struct av7110 *av7110 = (struct av7110*) dev->ext_priv;
+
+        dprintk(2, "%s\n", __FUNCTION__);
+        av7110->wssMode = 0;
+        av7110->wssData = 0;
+        if (FW_VERSION(av7110->arm_app) < 0x2623)
+                return 0;
+        else
+                return av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetWSSConfig, 1, 0);
+}
+
+static ssize_t av7110_vbi_write(struct file *file, const char __user *data, size_t count, loff_t *ppos)
+{
+        struct saa7146_fh *fh = file->private_data;
+        struct saa7146_dev *dev = fh->dev;
+        struct av7110 *av7110 = (struct av7110*) dev->ext_priv;
+        struct v4l2_sliced_vbi_data d;
+        int rc;
+
+        dprintk(2, "%s\n", __FUNCTION__);
+        if (FW_VERSION(av7110->arm_app) < 0x2623 || !av7110->wssMode || count != sizeof d)
+                return -EINVAL;
+        if (copy_from_user(&d, data, count))
+                return -EFAULT;
+        if ((d.id != 0 && d.id != V4L2_SLICED_WSS_625) || d.field != 0 || d.line != 23)
+                return -EINVAL;
+        if (d.id) {
+                av7110->wssData = ((d.data[1] << 8) & 0x3f00) | d.data[0];
+                rc = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetWSSConfig,
+                                   2, 1, av7110->wssData);
+        } else {
+                av7110->wssData = 0;
+                rc = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetWSSConfig, 1, 0);
+        }
+        return (rc < 0) ? rc : count;
+}
 
 /****************************************************************************
  * INITIALIZATION
@@ -512,6 +604,9 @@ static struct saa7146_extension_ioctls ioctls[] = {
         { VIDIOC_S_TUNER,       SAA7146_EXCLUSIVE },
         { VIDIOC_G_AUDIO,       SAA7146_EXCLUSIVE },
         { VIDIOC_S_AUDIO,       SAA7146_EXCLUSIVE },
+        { VIDIOC_G_SLICED_VBI_CAP, SAA7146_EXCLUSIVE },
+        { VIDIOC_G_FMT,         SAA7146_BEFORE },
+        { VIDIOC_S_FMT,         SAA7146_BEFORE },
         { 0, 0 }
 };
 
@@ -587,7 +682,7 @@ int av7110_init_analog_module(struct av7110 *av7110)
 
         printk("dvb-ttpci: DVB-C analog module @ card %d detected, initializing MSP3400\n",
                 av7110->dvb_adapter.num);
-        av7110->adac_type = DVB_ADAC_MSP;
+        av7110->adac_type = DVB_ADAC_MSP34x0;
         msleep(100); // the probing above resets the msp...
         msp_readreg(av7110, MSP_RD_DSP, 0x001e, &version1);
         msp_readreg(av7110, MSP_RD_DSP, 0x001f, &version2);
@@ -692,12 +787,11 @@ int av7110_init_v4l(struct av7110 *av7110)
                 saa7146_vv_release(dev);
                 return -ENODEV;
         }
-        if (av7110->analog_tuner_flags) {
-                if (saa7146_register_device(&av7110->vbi_dev, dev, "av7110", VFL_TYPE_VBI)) {
-                        ERR(("cannot register vbi v4l2 device. skipping.\n"));
-                } else {
+        if (saa7146_register_device(&av7110->vbi_dev, dev, "av7110", VFL_TYPE_VBI)) {
+                ERR(("cannot register vbi v4l2 device. skipping.\n"));
+        } else {
+                if (av7110->analog_tuner_flags)
                         av7110->analog_tuner_flags |= ANALOG_TUNER_VBI;
-                }
         }
         return 0;
 }
@@ -778,7 +872,7 @@ static int std_callback(struct saa7146_dev* dev, struct saa7146_standard *std)
 static struct saa7146_ext_vv av7110_vv_data_st = {
         .inputs         = 1,
         .audios         = 1,
-        .capabilities   = 0,
+        .capabilities   = V4L2_CAP_SLICED_VBI_OUTPUT,
         .flags          = 0,
 
         .stds           = &standard[0],
@@ -787,12 +881,16 @@ static struct saa7146_ext_vv av7110_vv_data_st = {
 
         .ioctls         = &ioctls[0],
         .ioctl          = av7110_ioctl,
+
+        .vbi_fops.open  = av7110_vbi_reset,
+        .vbi_fops.release = av7110_vbi_reset,
+        .vbi_fops.write = av7110_vbi_write,
 };
 
 static struct saa7146_ext_vv av7110_vv_data_c = {
         .inputs         = 1,
         .audios         = 1,
-        .capabilities   = V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE,
+        .capabilities   = V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE | V4L2_CAP_SLICED_VBI_OUTPUT,
         .flags          = SAA7146_USE_PORT_B_FOR_VBI,
 
         .stds           = &standard[0],
@@ -801,5 +899,9 @@ static struct saa7146_ext_vv av7110_vv_data_c = {
 
         .ioctls         = &ioctls[0],
         .ioctl          = av7110_ioctl,
+
+        .vbi_fops.open  = av7110_vbi_reset,
+        .vbi_fops.release = av7110_vbi_reset,
+        .vbi_fops.write = av7110_vbi_write,
 };
 
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 9f51bae7194c..f9d00452e639 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -127,7 +127,7 @@ static int ciintf_read_attribute_mem(struct dvb_ca_en50221 *ca, int slot, int ad
         saa7146_setgpio(budget_av->budget.dev, 1, SAA7146_GPIO_OUTHI);
         udelay(1);
 
-        result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 0xfff, 1, 0, 0);
+        result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 0xfff, 1, 0, 1);
 
         if (result == -ETIMEDOUT)
                 budget_av->slot_status = 0;
@@ -145,7 +145,7 @@ static int ciintf_write_attribute_mem(struct dvb_ca_en50221 *ca, int slot, int a
         saa7146_setgpio(budget_av->budget.dev, 1, SAA7146_GPIO_OUTHI);
         udelay(1);
 
-        result = ttpci_budget_debiwrite(&budget_av->budget, DEBICICAM, address & 0xfff, 1, value, 0, 0);
+        result = ttpci_budget_debiwrite(&budget_av->budget, DEBICICAM, address & 0xfff, 1, value, 0, 1);
 
         if (result == -ETIMEDOUT)
                 budget_av->slot_status = 0;
@@ -192,7 +192,7 @@ static int ciintf_slot_reset(struct dvb_ca_en50221 *ca, int slot)
 {
         struct budget_av *budget_av = (struct budget_av *) ca->data;
         struct saa7146_dev *saa = budget_av->budget.dev;
-        int timeout = 500; // 5 seconds (4.4.6 Ready)
+        int timeout = 50; // 5 seconds (4.4.6 Ready)
 
         if (slot != 0)
                 return -EINVAL;
@@ -256,19 +256,37 @@ static int ciintf_poll_slot_status(struct dvb_ca_en50221 *ca, int slot, int open
 {
         struct budget_av *budget_av = (struct budget_av *) ca->data;
         struct saa7146_dev *saa = budget_av->budget.dev;
+        int cam_present = 0;
 
         if (slot != 0)
                 return -EINVAL;
 
-        if (!budget_av->slot_status) {
+        if (!budget_av->slot_status)
+        {
+                // first of all test the card detect line
                 saa7146_setgpio(saa, 3, SAA7146_GPIO_INPUT);
                 udelay(1);
                 if (saa7146_read(saa, PSR) & MASK_06)
                 {
+                        cam_present = 1;
+                }
+                saa7146_setgpio(saa, 3, SAA7146_GPIO_OUTLO);
+
+                // that is unreliable however, so try and read from IO memory
+                if (!cam_present)
+                {
+                        saa7146_setgpio(budget_av->budget.dev, 1, SAA7146_GPIO_OUTLO);
+                        if (ttpci_budget_debiread(&budget_av->budget, DEBICICAM, 0, 1, 0, 1) != -ETIMEDOUT)
+                        {
+                                cam_present = 1;
+                        }
+                }
+
+                // did we find something?
+                if (cam_present) {
                         printk(KERN_INFO "budget-av: cam inserted\n");
                         budget_av->slot_status = 1;
                 }
-                saa7146_setgpio(saa, 3, SAA7146_GPIO_OUTLO);
         } else if (!open) {
                 saa7146_setgpio(budget_av->budget.dev, 1, SAA7146_GPIO_OUTLO);
                 if (ttpci_budget_debiread(&budget_av->budget, DEBICICAM, 0, 1, 0, 1) == -ETIMEDOUT)
@@ -484,6 +502,140 @@ static int philips_su1278_ty_ci_pll_set(struct dvb_frontend *fe,
         return 0;
 }
 
+#define MIN2(a,b) ((a) < (b) ? (a) : (b))
+#define MIN3(a,b,c) MIN2(MIN2(a,b),c)
+
+static int philips_su1278sh2_tua6100_pll_set(struct dvb_frontend *fe,
+                                        struct i2c_adapter *i2c,
+                                        struct dvb_frontend_parameters *params)
+{
+        u8 reg0 [2] = { 0x00, 0x00 };
+        u8 reg1 [4] = { 0x01, 0x00, 0x00, 0x00 };
+        u8 reg2 [3] = { 0x02, 0x00, 0x00 };
+        int _fband;
+        int first_ZF;
+        int R, A, N, P, M;
+        struct i2c_msg msg = {.addr = 0x60,.flags = 0,.buf = NULL,.len = 0 };
+        int freq = params->frequency;
+
+        first_ZF = (freq) / 1000;
+
+        if (abs(MIN2(abs(first_ZF-1190),abs(first_ZF-1790))) <
+                   abs(MIN3(abs(first_ZF-1202),abs(first_ZF-1542),abs(first_ZF-1890))))
+                _fband = 2;
+        else
+                _fband = 3;
+
+        if (_fband == 2) {
+                if (((first_ZF >= 950) && (first_ZF < 1350)) ||
+                                    ((first_ZF >= 1430) && (first_ZF < 1950)))
+                        reg0[1] = 0x07;
+                else if (((first_ZF >= 1350) && (first_ZF < 1430)) ||
+                                         ((first_ZF >= 1950) && (first_ZF < 2150)))
+                        reg0[1] = 0x0B;
+        }
+
+        if(_fband == 3) {
+                if (((first_ZF >= 950) && (first_ZF < 1350)) ||
+                                    ((first_ZF >= 1455) && (first_ZF < 1950)))
+                        reg0[1] = 0x07;
+                else if (((first_ZF >= 1350) && (first_ZF < 1420)) ||
+                                         ((first_ZF >= 1950) && (first_ZF < 2150)))
+                        reg0[1] = 0x0B;
+                else if ((first_ZF >= 1420) && (first_ZF < 1455))
+                        reg0[1] = 0x0F;
+        }
+
+        if (first_ZF > 1525)
+                reg1[1] |= 0x80;
+        else
+                reg1[1] &= 0x7F;
+
+        if (_fband == 2) {
+                if (first_ZF > 1430) { /* 1430MHZ */
+                        reg1[1] &= 0xCF; /* N2 */
+                        reg2[1] &= 0xCF; /* R2 */
+                        reg2[1] |= 0x10;
+                } else {
+                        reg1[1] &= 0xCF; /* N2 */
+                        reg1[1] |= 0x20;
+                        reg2[1] &= 0xCF; /* R2 */
+                        reg2[1] |= 0x10;
+                }
+        }
+
+        if (_fband == 3) {
+                if ((first_ZF >= 1455) &&
+                                   (first_ZF < 1630)) {
+                        reg1[1] &= 0xCF; /* N2 */
+                        reg1[1] |= 0x20;
+                        reg2[1] &= 0xCF; /* R2 */
+                                   } else {
+                                           if (first_ZF < 1455) {
+                                                   reg1[1] &= 0xCF; /* N2 */
+                                                   reg1[1] |= 0x20;
+                                                   reg2[1] &= 0xCF; /* R2 */
+                                                   reg2[1] |= 0x10;
+                                           } else {
+                                                   if (first_ZF >= 1630) {
+                                                           reg1[1] &= 0xCF; /* N2 */
+                                                           reg2[1] &= 0xCF; /* R2 */
+                                                           reg2[1] |= 0x10;
+                                                   }
+                                           }
+                                   }
+        }
+
+        /* set ports, enable P0 for symbol rates > 4Ms/s */
+        if (params->u.qpsk.symbol_rate >= 4000000)
+                reg1[1] |= 0x0c;
+        else
+                reg1[1] |= 0x04;
+
+        reg2[1] |= 0x0c;
+
+        R = 64;
+        A = 64;
+        P = 64;  //32
+
+        M = (freq * R) / 4;             /* in Mhz */
+        N = (M - A * 1000) / (P * 1000);
+
+        reg1[1] |= (N >> 9) & 0x03;
+        reg1[2]  = (N >> 1) & 0xff;
+        reg1[3]  = (N << 7) & 0x80;
+
+        reg2[1] |= (R >> 8) & 0x03;
+        reg2[2]  = R & 0xFF;    /* R */
+
+        reg1[3] |= A & 0x7f;    /* A */
+
+        if (P == 64)
+                reg1[1] |= 0x40; /* Prescaler 64/65 */
+
+        reg0[1] |= 0x03;
+
+        /* already enabled - do not reenable i2c repeater or TX fails */
+        msg.buf = reg0;
+        msg.len = sizeof(reg0);
+        if (i2c_transfer(i2c, &msg, 1) != 1)
+                return -EIO;
+
+        stv0299_enable_plli2c(fe);
+        msg.buf = reg1;
+        msg.len = sizeof(reg1);
+        if (i2c_transfer(i2c, &msg, 1) != 1)
+                return -EIO;
+
+        stv0299_enable_plli2c(fe);
+        msg.buf = reg2;
+        msg.len = sizeof(reg2);
+        if (i2c_transfer(i2c, &msg, 1) != 1)
+                return -EIO;
+
+        return 0;
+}
+
 static u8 typhoon_cinergy1200s_inittab[] = {
         0x01, 0x15,
         0x02, 0x30,
@@ -553,6 +705,18 @@ static struct stv0299_config cinergy_1200s_config = {
         .pll_set = philips_su1278_ty_ci_pll_set,
 };
 
+static struct stv0299_config cinergy_1200s_1894_0010_config = {
+        .demod_address = 0x68,
+        .inittab = typhoon_cinergy1200s_inittab,
+        .mclk = 88000000UL,
+        .invert = 1,
+        .skip_reinit = 0,
+        .lock_output = STV0229_LOCKOUTPUT_1,
+        .volt13_op0_op1 = STV0299_VOLT13_OP0,
+        .min_delay_ms = 100,
+        .set_symbol_rate = philips_su1278_ty_ci_set_symbol_rate,
+        .pll_set = philips_su1278sh2_tua6100_pll_set,
+};
 
 static int philips_cu1216_pll_set(struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
 {
@@ -749,6 +913,15 @@ static void frontend_init(struct budget_av *budget_av)
         switch (saa->pci->subsystem_device) {
 
         case SUBID_DVBS_KNC1:
+                if (saa->pci->subsystem_vendor == 0x1894) {
+                        fe = stv0299_attach(&cinergy_1200s_1894_0010_config,
+                                             &budget_av->budget.i2c_adap);
+                } else {
+                        fe = stv0299_attach(&typhoon_config,
+                                             &budget_av->budget.i2c_adap);
+                }
+                break;
+
         case SUBID_DVBS_KNC1_PLUS:
         case SUBID_DVBS_TYPHOON:
                 fe = stv0299_attach(&typhoon_config,
@@ -1003,6 +1176,7 @@ MAKE_BUDGET_INFO(cin1200t, "Terratec Cinergy 1200 DVB-T", BUDGET_CIN1200T);
 static struct pci_device_id pci_tbl[] = {
         MAKE_EXTENSION_PCI(knc1s, 0x1131, 0x4f56),
         MAKE_EXTENSION_PCI(knc1s, 0x1131, 0x0010),
+        MAKE_EXTENSION_PCI(knc1s, 0x1894, 0x0010),
         MAKE_EXTENSION_PCI(knc1sp, 0x1131, 0x0011),
         MAKE_EXTENSION_PCI(knc1c, 0x1894, 0x0020),
         MAKE_EXTENSION_PCI(knc1cp, 0x1894, 0x0021),
diff --git a/drivers/media/dvb/ttpci/budget-core.c b/drivers/media/dvb/ttpci/budget-core.c
index 017fcbccb8cc..633e68c341c8 100644
--- a/drivers/media/dvb/ttpci/budget-core.c
+++ b/drivers/media/dvb/ttpci/budget-core.c
@@ -404,9 +404,7 @@ int ttpci_budget_init(struct budget *budget, struct saa7146_dev *dev,
         tasklet_init(&budget->vpe_tasklet, vpeirq, (unsigned long) budget);
 
         /* frontend power on */
-        if (bi->type == BUDGET_FS_ACTIVY)
-                saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTHI);
-        else
+        if (bi->type != BUDGET_FS_ACTIVY)
                 saa7146_setgpio(dev, 2, SAA7146_GPIO_OUTHI);
 
         if (budget_register(budget) == 0) {
diff --git a/drivers/media/dvb/ttpci/budget.c b/drivers/media/dvb/ttpci/budget.c
index fafe6407b3d0..238c77b52f89 100644
--- a/drivers/media/dvb/ttpci/budget.c
+++ b/drivers/media/dvb/ttpci/budget.c
@@ -112,6 +112,7 @@ static int SendDiSEqCMsg (struct budget *budget, int len, u8 *msg, unsigned long
  *   Routines for the Fujitsu Siemens Activy budget card
  *   22 kHz tone and DiSEqC are handled by the frontend.
  *   Voltage must be set here.
+ *   GPIO 1: LNBP EN, GPIO 2: LNBP VSEL
  */
 static int SetVoltage_Activy (struct budget *budget, fe_sec_voltage_t voltage)
 {
@@ -121,11 +122,16 @@ static int SetVoltage_Activy (struct budget *budget, fe_sec_voltage_t voltage)
 
         switch (voltage) {
                 case SEC_VOLTAGE_13:
+                        saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTHI);
                         saa7146_setgpio(dev, 2, SAA7146_GPIO_OUTLO);
                         break;
                 case SEC_VOLTAGE_18:
+                        saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTHI);
                         saa7146_setgpio(dev, 2, SAA7146_GPIO_OUTHI);
                         break;
+                case SEC_VOLTAGE_OFF:
+                        saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTLO);
+                        break;
                 default:
                         return -EINVAL;
         }
@@ -206,7 +212,7 @@ static int lnbp21_set_voltage(struct dvb_frontend* fe, fe_sec_voltage_t voltage)
         return 0;
 }
 
-static int lnbp21_enable_high_lnb_voltage(struct dvb_frontend* fe, int arg)
+static int lnbp21_enable_high_lnb_voltage(struct dvb_frontend* fe, long arg)
 {
         struct budget* budget = (struct budget*) fe->dvb->priv;
         u8 buf;
@@ -580,6 +586,7 @@ static void frontend_init(struct budget *budget)
                 if (budget->dvb_frontend) {
                         budget->dvb_frontend->ops->set_voltage = lnbp21_set_voltage;
                         budget->dvb_frontend->ops->enable_high_lnb_voltage = lnbp21_enable_high_lnb_voltage;
+                        budget->dvb_frontend->ops->dishnetwork_send_legacy_command = NULL;
                         if (lnbp21_init(budget)) {
                                 printk("%s: No LNBP21 found!\n", __FUNCTION__);
                                 goto error_out;
@@ -624,7 +631,7 @@ static void frontend_init(struct budget *budget)
                 budget->dvb_frontend = stv0299_attach(&alps_bsru6_config, &budget->i2c_adap);
                 if (budget->dvb_frontend) {
                         budget->dvb_frontend->ops->set_voltage = siemens_budget_set_voltage;
-                        break;
+                        budget->dvb_frontend->ops->dishnetwork_send_legacy_command = NULL;
                 }
                 break;
 
@@ -632,7 +639,7 @@ static void frontend_init(struct budget *budget)
                 budget->dvb_frontend = tda8083_attach(&grundig_29504_451_config, &budget->i2c_adap);
                 if (budget->dvb_frontend) {
                         budget->dvb_frontend->ops->set_voltage = siemens_budget_set_voltage;
-                        break;
+                        budget->dvb_frontend->ops->dishnetwork_send_legacy_command = NULL;
                 }
                 break;
 
diff --git a/drivers/media/dvb/ttpci/ttpci-eeprom.c b/drivers/media/dvb/ttpci/ttpci-eeprom.c
index 18aa22b5478d..1f31e91195b0 100644
--- a/drivers/media/dvb/ttpci/ttpci-eeprom.c
+++ b/drivers/media/dvb/ttpci/ttpci-eeprom.c
@@ -13,7 +13,7 @@
     Holger Waechtler    Convergence
 
     Copyright (C) 2002-2003 Ralph Metzler <rjkm@metzlerbros.de>
-                            Metzler Brothers Systementwicklung GbR
+                            Metzler Brothers Systementwicklung GbR
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
diff --git a/drivers/media/dvb/ttusb-budget/Kconfig b/drivers/media/dvb/ttusb-budget/Kconfig
index c6c1d41a2efb..914587d52b57 100644
--- a/drivers/media/dvb/ttusb-budget/Kconfig
+++ b/drivers/media/dvb/ttusb-budget/Kconfig
@@ -10,7 +10,7 @@ config DVB_TTUSB_BUDGET
           Support for external USB adapters designed by Technotrend and
           produced by Hauppauge, shipped under the brand name 'Nova-USB'.
 
-          These devices don't have a MPEG decoder built in, so you need
+          These devices don't have a MPEG decoder built in, so you need
           an external software decoder to watch TV.
 
           Say Y if you own such a device and want to use it.
diff --git a/drivers/media/dvb/ttusb-dec/Kconfig b/drivers/media/dvb/ttusb-dec/Kconfig
index c334526af66f..83611012ef34 100644
--- a/drivers/media/dvb/ttusb-dec/Kconfig
+++ b/drivers/media/dvb/ttusb-dec/Kconfig
@@ -8,14 +8,15 @@ config DVB_TTUSB_DEC
           produced by Hauppauge, shipped under the brand name 'DEC2000-t'
           and 'DEC3000-s'.
 
-          Even if these devices have a MPEG decoder built in, they transmit
+          Even if these devices have a MPEG decoder built in, they transmit
           only compressed MPEG data over the USB bus, so you need
           an external software decoder to watch TV on your computer.
 
-          This driver needs external firmware. Please use the commands
-          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec2000t",
-          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec2540t",
-          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec3000s",
-          download/extract them, and then copy them to /usr/lib/hotplug/firmware.
+          This driver needs external firmware. Please use the commands
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec2000t",
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec2540t",
+          "<kerneldir>/Documentation/dvb/get_dvb_firmware dec3000s",
+          download/extract them, and then copy them to /usr/lib/hotplug/firmware
+          or /lib/firmware (depending on configuration of firmware hotplug).
 
           Say Y if you own such a device and want to use it.
diff --git a/drivers/media/dvb/ttusb-dec/ttusb_dec.c b/drivers/media/dvb/ttusb-dec/ttusb_dec.c
index 8abc21890129..d8966d1d25ee 100644
--- a/drivers/media/dvb/ttusb-dec/ttusb_dec.c
+++ b/drivers/media/dvb/ttusb-dec/ttusb_dec.c
@@ -369,7 +369,7 @@ static int ttusb_dec_get_stb_state (struct ttusb_dec *dec, unsigned int *mode,
 
 static int ttusb_dec_audio_pes2ts_cb(void *priv, unsigned char *data)
 {
-        struct ttusb_dec *dec = (struct ttusb_dec *)priv;
+        struct ttusb_dec *dec = priv;
 
         dec->audio_filter->feed->cb.ts(data, 188, NULL, 0,
                                        &dec->audio_filter->feed->feed.ts,
@@ -380,7 +380,7 @@ static int ttusb_dec_audio_pes2ts_cb(void *priv, unsigned char *data)
 
 static int ttusb_dec_video_pes2ts_cb(void *priv, unsigned char *data)
 {
-        struct ttusb_dec *dec = (struct ttusb_dec *)priv;
+        struct ttusb_dec *dec = priv;
 
         dec->video_filter->feed->cb.ts(data, 188, NULL, 0,
                                        &dec->video_filter->feed->feed.ts,
@@ -965,8 +965,8 @@ static int ttusb_dec_start_ts_feed(struct dvb_demux_feed *dvbdmxfeed)
 
         case DMX_TS_PES_TELETEXT:
                 dec->pid[DMX_PES_TELETEXT] = dvbdmxfeed->pid;
-                dprintk("  pes_type: DMX_TS_PES_TELETEXT\n");
-                break;
+                dprintk("  pes_type: DMX_TS_PES_TELETEXT(not supported)\n");
+                return -ENOSYS;
 
         case DMX_TS_PES_PCR:
                 dprintk("  pes_type: DMX_TS_PES_PCR\n");
@@ -975,8 +975,8 @@ static int ttusb_dec_start_ts_feed(struct dvb_demux_feed *dvbdmxfeed)
                 break;
 
         case DMX_TS_PES_OTHER:
-                dprintk("  pes_type: DMX_TS_PES_OTHER\n");
-                break;
+                dprintk("  pes_type: DMX_TS_PES_OTHER(not supported)\n");
+                return -ENOSYS;
 
         default:
                 dprintk("  pes_type: unknown (%d)\n", dvbdmxfeed->pes_type);
@@ -1182,7 +1182,7 @@ static void ttusb_dec_init_tasklet(struct ttusb_dec *dec)
                      (unsigned long)dec);
 }
 
-static int ttusb_init_rc(struct ttusb_dec *dec)
+static int ttusb_init_rc( struct ttusb_dec *dec)
 {
         struct input_dev *input_dev;
         u8 b[] = { 0x00, 0x01 };
@@ -1203,13 +1203,12 @@ static int ttusb_init_rc(struct ttusb_dec *dec)
         input_dev->keycode = rc_keys;
 
         for (i = 0; i < ARRAY_SIZE(rc_keys); i++)
-                set_bit(rc_keys[i], input_dev->keybit);
+                  set_bit(rc_keys[i], input_dev->keybit);
 
         input_register_device(input_dev);
 
         if (usb_submit_urb(dec->irq_urb, GFP_KERNEL))
                 printk("%s: usb_submit_urb failed\n",__FUNCTION__);
-
         /* enable irq pipe */
         ttusb_dec_send_command(dec,0xb0,sizeof(b),b,NULL,NULL);
 
@@ -1395,6 +1394,7 @@ static int ttusb_dec_init_stb(struct ttusb_dec *dec)
                         /* We can't trust the USB IDs that some firmwares
                            give the box */
                         switch (model) {
+                        case 0x00070001:
                         case 0x00070008:
                         case 0x0007000c:
                                 ttusb_dec_set_model(dec, TTUSB_DEC3000S);
@@ -1588,7 +1588,7 @@ static int fe_send_command(struct dvb_frontend* fe, const u8 command,
                            int param_length, const u8 params[],
                            int *result_length, u8 cmd_result[])
 {
-        struct ttusb_dec* dec = (struct ttusb_dec*) fe->dvb->priv;
+        struct ttusb_dec* dec = fe->dvb->priv;
         return ttusb_dec_send_command(dec, command, param_length, params, result_length, cmd_result);
 }
 
diff --git a/drivers/media/dvb/ttusb-dec/ttusbdecfe.c b/drivers/media/dvb/ttusb-dec/ttusbdecfe.c
index 725af3af5b27..a5a46175fa09 100644
--- a/drivers/media/dvb/ttusb-dec/ttusbdecfe.c
+++ b/drivers/media/dvb/ttusb-dec/ttusbdecfe.c
@@ -42,8 +42,39 @@ struct ttusbdecfe_state {
 
 static int ttusbdecfe_read_status(struct dvb_frontend* fe, fe_status_t* status)
 {
-        *status = FE_HAS_SIGNAL | FE_HAS_VITERBI |
-                  FE_HAS_SYNC | FE_HAS_CARRIER | FE_HAS_LOCK;
+        struct ttusbdecfe_state* state = fe->demodulator_priv;
+        u8 b[] = { 0x00, 0x00, 0x00, 0x00,
+                   0x00, 0x00, 0x00, 0x00 };
+        u8 result[4];
+        int len, ret;
+
+        *status=0;
+
+        ret=state->config->send_command(fe, 0x73, sizeof(b), b, &len, result);
+        if(ret)
+                return ret;
+
+        if(len != 4) {
+                printk(KERN_ERR "%s: unexpected reply\n", __FUNCTION__);
+                return -EIO;
+        }
+
+        switch(result[3]) {
+                case 1:  /* not tuned yet */
+                case 2:  /* no signal/no lock*/
+                        break;
+                case 3:  /* signal found and locked*/
+                        *status = FE_HAS_SIGNAL | FE_HAS_VITERBI |
+                        FE_HAS_SYNC | FE_HAS_CARRIER | FE_HAS_LOCK;
+                        break;
+                case 4:
+                        *status = FE_TIMEDOUT;
+                        break;
+                default:
+                        pr_info("%s: returned unknown value: %d\n",
+                                __FUNCTION__, result[3]);
+                        return -EIO;
+        }
 
         return 0;
 }
@@ -64,6 +95,16 @@ static int ttusbdecfe_dvbt_set_frontend(struct dvb_frontend* fe, struct dvb_fron
         return 0;
 }
 
+static int ttusbdecfe_dvbt_get_tune_settings(struct dvb_frontend* fe,
+                                        struct dvb_frontend_tune_settings* fesettings)
+{
+                fesettings->min_delay_ms = 1500;
+                /* Drift compensation makes no sense for DVB-T */
+                fesettings->step_size = 0;
+                fesettings->max_drift = 0;
+                return 0;
+}
+
 static int ttusbdecfe_dvbs_set_frontend(struct dvb_frontend* fe, struct dvb_frontend_parameters *p)
 {
         struct ttusbdecfe_state* state = (struct ttusbdecfe_state*) fe->demodulator_priv;
@@ -212,6 +253,8 @@ static struct dvb_frontend_ops ttusbdecfe_dvbt_ops = {
 
         .set_frontend = ttusbdecfe_dvbt_set_frontend,
 
+        .get_tune_settings = ttusbdecfe_dvbt_get_tune_settings,
+
         .read_status = ttusbdecfe_read_status,
 };
 
@@ -223,11 +266,11 @@ static struct dvb_frontend_ops ttusbdecfe_dvbs_ops = {
                 .frequency_min          = 950000,
                 .frequency_max          = 2150000,
                 .frequency_stepsize     = 125,
+                .symbol_rate_min        = 1000000,  /* guessed */
+                .symbol_rate_max        = 45000000, /* guessed */
                 .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
                         FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO |
-                        FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
-                        FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO |
-                        FE_CAN_HIERARCHY_AUTO,
+                        FE_CAN_QPSK
         },
 
         .release = ttusbdecfe_release,
diff --git a/drivers/media/radio/miropcm20-radio.c b/drivers/media/radio/miropcm20-radio.c
index c2ebe8754a95..dc292da2605f 100644
--- a/drivers/media/radio/miropcm20-radio.c
+++ b/drivers/media/radio/miropcm20-radio.c
@@ -220,6 +220,7 @@ static struct file_operations pcm20_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = pcm20_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-aimslab.c b/drivers/media/radio/radio-aimslab.c
index 877c770558e9..914deab4e044 100644
--- a/drivers/media/radio/radio-aimslab.c
+++ b/drivers/media/radio/radio-aimslab.c
@@ -299,6 +299,7 @@ static struct file_operations rtrack_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = rt_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-aztech.c b/drivers/media/radio/radio-aztech.c
index 5319a9c9a979..523be820f9c6 100644
--- a/drivers/media/radio/radio-aztech.c
+++ b/drivers/media/radio/radio-aztech.c
@@ -256,6 +256,7 @@ static struct file_operations aztech_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = az_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-cadet.c b/drivers/media/radio/radio-cadet.c
index 9b0406318f2d..f1b5ac81e9d2 100644
--- a/drivers/media/radio/radio-cadet.c
+++ b/drivers/media/radio/radio-cadet.c
@@ -490,6 +490,7 @@ static struct file_operations cadet_fops = {
         .release        = cadet_release,
         .read           = cadet_read,
         .ioctl          = cadet_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-gemtek-pci.c b/drivers/media/radio/radio-gemtek-pci.c
index 630cc786d0a4..42c8fce04aa2 100644
--- a/drivers/media/radio/radio-gemtek-pci.c
+++ b/drivers/media/radio/radio-gemtek-pci.c
@@ -301,6 +301,7 @@ static struct file_operations gemtek_pci_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = gemtek_pci_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-gemtek.c b/drivers/media/radio/radio-gemtek.c
index 6418f03b9ce4..47173be97b9f 100644
--- a/drivers/media/radio/radio-gemtek.c
+++ b/drivers/media/radio/radio-gemtek.c
@@ -233,6 +233,7 @@ static struct file_operations gemtek_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = gemtek_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-maestro.c b/drivers/media/radio/radio-maestro.c
index e5e2021a7312..c30effdf711f 100644
--- a/drivers/media/radio/radio-maestro.c
+++ b/drivers/media/radio/radio-maestro.c
@@ -72,6 +72,7 @@ static struct file_operations maestro_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = radio_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-maxiradio.c b/drivers/media/radio/radio-maxiradio.c
index 02d39a50d5ed..30869308332a 100644
--- a/drivers/media/radio/radio-maxiradio.c
+++ b/drivers/media/radio/radio-maxiradio.c
@@ -80,6 +80,7 @@ static struct file_operations maxiradio_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = radio_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 static struct video_device maxiradio_radio =
diff --git a/drivers/media/radio/radio-rtrack2.c b/drivers/media/radio/radio-rtrack2.c
index b2256d675b44..28a47c9e7a81 100644
--- a/drivers/media/radio/radio-rtrack2.c
+++ b/drivers/media/radio/radio-rtrack2.c
@@ -199,6 +199,7 @@ static struct file_operations rtrack2_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = rt_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-sf16fmi.c b/drivers/media/radio/radio-sf16fmi.c
index 6f03ce4dd7b0..0229f792a059 100644
--- a/drivers/media/radio/radio-sf16fmi.c
+++ b/drivers/media/radio/radio-sf16fmi.c
@@ -225,6 +225,7 @@ static struct file_operations fmi_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = fmi_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c
index 71971e9bb342..26632cead09a 100644
--- a/drivers/media/radio/radio-sf16fmr2.c
+++ b/drivers/media/radio/radio-sf16fmr2.c
@@ -356,6 +356,7 @@ static struct file_operations fmr2_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = fmr2_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-terratec.c b/drivers/media/radio/radio-terratec.c
index b03573c6840e..fcfde2e4f195 100644
--- a/drivers/media/radio/radio-terratec.c
+++ b/drivers/media/radio/radio-terratec.c
@@ -276,6 +276,7 @@ static struct file_operations terratec_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = tt_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-trust.c b/drivers/media/radio/radio-trust.c
index b300bedf7c74..5a099a50d4d0 100644
--- a/drivers/media/radio/radio-trust.c
+++ b/drivers/media/radio/radio-trust.c
@@ -255,6 +255,7 @@ static struct file_operations trust_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = tr_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-typhoon.c b/drivers/media/radio/radio-typhoon.c
index f304f3c14763..8ac9a8ef9094 100644
--- a/drivers/media/radio/radio-typhoon.c
+++ b/drivers/media/radio/radio-typhoon.c
@@ -261,6 +261,7 @@ static struct file_operations typhoon_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = typhoon_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/radio/radio-zoltrix.c b/drivers/media/radio/radio-zoltrix.c
index 4c6d6fb49034..d590e80c922e 100644
--- a/drivers/media/radio/radio-zoltrix.c
+++ b/drivers/media/radio/radio-zoltrix.c
@@ -313,6 +313,7 @@ static struct file_operations zoltrix_fops =
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = zol_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index fc87efc5049c..2fe260fff85d 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -7,6 +7,15 @@ menu "Video For Linux"
 
 comment "Video Adapters"
 
+config VIDEO_ADV_DEBUG
+        bool "Enable advanced debug functionality"
+        depends on VIDEO_DEV
+        default n
+        ---help---
+          Say Y here to enable advanced debugging functionality on some
+          V4L devices.
+          In doubt, say N.
+
 config VIDEO_BT848
         tristate "BT848 Video For Linux"
         depends on VIDEO_DEV && PCI && I2C
@@ -342,6 +351,6 @@ config VIDEO_DECODER
         depends on VIDEO_DEV && I2C && EXPERIMENTAL
         ---help---
           Say Y here to compile drivers for SAA7115, SAA7127 and CX25840
-          video  decoders.
+          video decoders.
 
 endmenu
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index 82060f9909d8..dd24896906fe 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -3,15 +3,19 @@
 #
 
 bttv-objs       :=      bttv-driver.o bttv-cards.o bttv-if.o \
-                        bttv-risc.o bttv-vbi.o bttv-i2c.o bttv-gpio.o
+                        bttv-risc.o bttv-vbi.o bttv-i2c.o bttv-gpio.o \
+                        bttv-input.o
 zoran-objs      :=      zr36120.o zr36120_i2c.o zr36120_mem.o
 zr36067-objs    :=      zoran_procfs.o zoran_device.o \
                         zoran_driver.o zoran_card.o
 tuner-objs      :=      tuner-core.o tuner-simple.o mt20xx.o tda8290.o tea5767.o
-obj-$(CONFIG_VIDEO_DEV) += videodev.o v4l2-common.o v4l1-compat.o
+
+msp3400-objs    :=      msp3400-driver.o msp3400-kthreads.o
+
+obj-$(CONFIG_VIDEO_DEV) += videodev.o v4l2-common.o v4l1-compat.o compat_ioctl32.o
 
 obj-$(CONFIG_VIDEO_BT848) += bttv.o msp3400.o tvaudio.o \
-        tda7432.o tda9875.o ir-kbd-i2c.o ir-kbd-gpio.o
+        tda7432.o tda9875.o ir-kbd-i2c.o
 obj-$(CONFIG_SOUND_TVMIXER) += tvmixer.o
 
 obj-$(CONFIG_VIDEO_ZR36120) += zoran.o
diff --git a/drivers/media/video/arv.c b/drivers/media/video/arv.c
index 881cdcb1875d..7d5a068353f2 100644
--- a/drivers/media/video/arv.c
+++ b/drivers/media/video/arv.c
@@ -749,6 +749,7 @@ static struct file_operations ar_fops = {
         .release        = video_exclusive_release,
         .read           = ar_read,
         .ioctl          = ar_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/video/bt832.c b/drivers/media/video/bt832.c
index 1c3ff5f38a6d..dda4aa6bef27 100644
--- a/drivers/media/video/bt832.c
+++ b/drivers/media/video/bt832.c
@@ -30,8 +30,9 @@
 #include <linux/init.h>
 #include <linux/errno.h>
 #include <linux/slab.h>
-
 #include <media/audiochip.h>
+#include <media/v4l2-common.h>
+
 #include "bttv.h"
 #include "bt832.h"
 
@@ -42,9 +43,10 @@ static unsigned short normal_i2c[] = { I2C_BT832_ALT1>>1, I2C_BT832_ALT2>>1,
                                        I2C_CLIENT_END };
 I2C_CLIENT_INSMOD;
 
-/* ---------------------------------------------------------------------- */
+int debug    = 0;    /* debug output */
+module_param(debug,            int, 0644);
 
-#define dprintk     if (debug) printk
+/* ---------------------------------------------------------------------- */
 
 static int bt832_detach(struct i2c_client *client);
 
@@ -61,23 +63,26 @@ int bt832_hexdump(struct i2c_client *i2c_client_s, unsigned char *buf)
         int i,rc;
         buf[0]=0x80; // start at register 0 with auto-increment
         if (1 != (rc = i2c_master_send(i2c_client_s,buf,1)))
-                printk("bt832: i2c i/o error: rc == %d (should be 1)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error: rc == %d (should be 1)\n",rc);
 
         for(i=0;i<65;i++)
                 buf[i]=0;
         if (65 != (rc=i2c_master_recv(i2c_client_s,buf,65)))
-                printk("bt832: i2c i/o error: rc == %d (should be 65)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error: rc == %d (should be 65)\n",rc);
 
         // Note: On READ the first byte is the current index
         //  (e.g. 0x80, what we just wrote)
 
-        if(1) {
+        if(debug>1) {
                 int i;
-                printk("BT832 hexdump:\n");
+                v4l_dbg(2,i2c_client_s,"hexdump:");
                 for(i=1;i<65;i++) {
                         if(i!=1) {
-                          if(((i-1)%8)==0) printk(" ");
-                          if(((i-1)%16)==0) printk("\n");
+                                if(((i-1)%8)==0) printk(" ");
+                                if(((i-1)%16)==0) {
+                                        printk("\n");
+                                        v4l_dbg(2,i2c_client_s,"hexdump:");
+                                }
                         }
                         printk(" %02x",buf[i]);
                 }
@@ -96,56 +101,56 @@ int bt832_init(struct i2c_client *i2c_client_s)
         bt832_hexdump(i2c_client_s,buf);
 
         if(buf[0x40] != 0x31) {
-                printk("bt832: this i2c chip is no bt832 (id=%02x). Detaching.\n",buf[0x40]);
+                v4l_err(i2c_client_s,"This i2c chip is no bt832 (id=%02x). Detaching.\n",buf[0x40]);
                 kfree(buf);
                 return 0;
         }
 
-        printk("Write 0 tp VPSTATUS\n");
+        v4l_err(i2c_client_s,"Write 0 tp VPSTATUS\n");
         buf[0]=BT832_VP_STATUS; // Reg.52
         buf[1]= 0x00;
         if (2 != (rc = i2c_master_send(i2c_client_s,buf,2)))
-                printk("bt832: i2c i/o error VPS: rc == %d (should be 2)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error VPS: rc == %d (should be 2)\n",rc);
 
         bt832_hexdump(i2c_client_s,buf);
 
 
         // Leave low power mode:
-        printk("Bt832: leave low power mode.\n");
+        v4l_err(i2c_client_s,"leave low power mode.\n");
         buf[0]=BT832_CAM_SETUP0; //0x39 57
         buf[1]=0x08;
         if (2 != (rc = i2c_master_send(i2c_client_s,buf,2)))
-                printk("bt832: i2c i/o error LLPM: rc == %d (should be 2)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error LLPM: rc == %d (should be 2)\n",rc);
 
         bt832_hexdump(i2c_client_s,buf);
 
-        printk("Write 0 tp VPSTATUS\n");
+        v4l_info(i2c_client_s,"Write 0 tp VPSTATUS\n");
         buf[0]=BT832_VP_STATUS; // Reg.52
         buf[1]= 0x00;
         if (2 != (rc = i2c_master_send(i2c_client_s,buf,2)))
-                printk("bt832: i2c i/o error VPS: rc == %d (should be 2)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error VPS: rc == %d (should be 2)\n",rc);
 
         bt832_hexdump(i2c_client_s,buf);
 
 
         // Enable Output
-        printk("Enable Output\n");
+        v4l_info(i2c_client_s,"Enable Output\n");
         buf[0]=BT832_VP_CONTROL1; // Reg.40
         buf[1]= 0x27 & (~0x01); // Default | !skip
         if (2 != (rc = i2c_master_send(i2c_client_s,buf,2)))
-                printk("bt832: i2c i/o error EO: rc == %d (should be 2)\n",rc);
+                v4l_err(i2c_client_s,"i2c i/o error EO: rc == %d (should be 2)\n",rc);
 
         bt832_hexdump(i2c_client_s,buf);
 
 
         // for testing (even works when no camera attached)
-        printk("bt832: *** Generate NTSC M Bars *****\n");
+        v4l_info(i2c_client_s,"*** Generate NTSC M Bars *****\n");
         buf[0]=BT832_VP_TESTCONTROL0; // Reg. 42
         buf[1]=3; // Generate NTSC System M bars, Generate Frame timing internally
         if (2 != (rc = i2c_master_send(i2c_client_s,buf,2)))
-                printk("bt832: i2c i/o error MBAR: rc == %d (should be 2)\n",rc);
+                v4l_info(i2c_client_s,"i2c i/o error MBAR: rc == %d (should be 2)\n",rc);
 
-        printk("Bt832: Camera Present: %s\n",
+        v4l_info(i2c_client_s,"Camera Present: %s\n",
                 (buf[1+BT832_CAM_STATUS] & BT832_56_CAMERA_PRESENT) ? "yes":"no");
 
         bt832_hexdump(i2c_client_s,buf);
@@ -159,13 +164,9 @@ static int bt832_attach(struct i2c_adapter *adap, int addr, int kind)
 {
         struct bt832 *t;
 
-        printk("bt832_attach\n");
-
         client_template.adapter = adap;
         client_template.addr    = addr;
 
-        printk("bt832: chip found @ 0x%x\n", addr<<1);
-
         if (NULL == (t = kmalloc(sizeof(*t), GFP_KERNEL)))
                 return -ENOMEM;
         memset(t,0,sizeof(*t));
@@ -173,6 +174,9 @@ static int bt832_attach(struct i2c_adapter *adap, int addr, int kind)
         i2c_set_clientdata(&t->client, t);
         i2c_attach_client(&t->client);
 
+        v4l_info(&t->client,"chip found @ 0x%x\n", addr<<1);
+
+
         if(! bt832_init(&t->client)) {
                 bt832_detach(&t->client);
                 return -1;
@@ -183,13 +187,8 @@ static int bt832_attach(struct i2c_adapter *adap, int addr, int kind)
 
 static int bt832_probe(struct i2c_adapter *adap)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, bt832_attach);
-#else
-        if (adap->id == I2C_HW_B_BT848)
-                return i2c_probe(adap, &addr_data, bt832_attach);
-#endif
         return 0;
 }
 
@@ -197,7 +196,7 @@ static int bt832_detach(struct i2c_client *client)
 {
         struct bt832 *t = i2c_get_clientdata(client);
 
-        printk("bt832: detach.\n");
+        v4l_info(&t->client,"dettach\n");
         i2c_detach_client(client);
         kfree(t);
         return 0;
@@ -208,7 +207,8 @@ bt832_command(struct i2c_client *client, unsigned int cmd, void *arg)
 {
         struct bt832 *t = i2c_get_clientdata(client);
 
-        printk("bt832: command %x\n",cmd);
+        if (debug>1)
+                v4l_i2c_print_ioctl(&t->client,cmd);
 
         switch (cmd) {
                 case BT832_HEXDUMP: {
@@ -219,7 +219,7 @@ bt832_command(struct i2c_client *client, unsigned int cmd, void *arg)
                 }
                 break;
                 case BT832_REATTACH:
-                        printk("bt832: re-attach\n");
+                        v4l_info(&t->client,"re-attach\n");
                         i2c_del_driver(&driver);
                         i2c_add_driver(&driver);
                 break;
@@ -231,9 +231,9 @@ bt832_command(struct i2c_client *client, unsigned int cmd, void *arg)
 
 static struct i2c_driver driver = {
         .driver = {
-                .name   = "i2c bt832 driver",
+                .name   = "bt832",
         },
-        .id             = -1, /* FIXME */
+        .id             = 0, /* FIXME */
         .attach_adapter = bt832_probe,
         .detach_client  = bt832_detach,
         .command        = bt832_command,
diff --git a/drivers/media/video/bttv-cards.c b/drivers/media/video/bttv-cards.c
index 012be639aa18..1621ab133d23 100644
--- a/drivers/media/video/bttv-cards.c
+++ b/drivers/media/video/bttv-cards.c
@@ -38,6 +38,7 @@
 #include <asm/io.h>
 
 #include "bttvp.h"
+#include <media/v4l2-common.h>
 
 /* fwd decl */
 static void boot_msp34xx(struct bttv *btv, int pin);
@@ -292,6 +293,9 @@ static struct CARD {
         /* likely broken, vendor id doesn't match the other magic views ...
          * { 0xa0fca04f, BTTV_BOARD_MAGICTVIEW063, "Guillemot Maxi TV Video 3" }, */
 
+        /* Duplicate PCI ID, reconfigure for this board during the eeprom read.
+        * { 0x13eb0070, BTTV_BOARD_HAUPPAUGE_IMPACTVCB,  "Hauppauge ImpactVCB" }, */
+
         /* DVB cards (using pci function .1 for mpeg data xfer) */
         { 0x01010071, BTTV_BOARD_NEBULA_DIGITV, "Nebula Electronics DigiTV" },
         { 0x07611461, BTTV_BOARD_AVDVBT_761,    "AverMedia AverTV DVB-T 761" },
@@ -2136,7 +2140,6 @@ struct tvcard bttv_tvcards[] = {
                 .has_remote     = 1,
                 .gpiomask       = 0x1b,
                 .no_gpioirq     = 1,
-                .any_irq                = 1,
         },
         [BTTV_BOARD_PV143] = {
                 /* Jorge Boncompte - DTI2 <jorge@dti2.net> */
@@ -2817,6 +2820,22 @@ struct tvcard bttv_tvcards[] = {
                 .tuner_addr     = ADDR_UNSET,
                 .has_radio      = 1,
         },
+        /* ---- card 0x8f ---------------------------------- */
+        [BTTV_BOARD_HAUPPAUGE_IMPACTVCB] = {
+                .name           = "Hauppauge ImpactVCB (bt878)",
+                .video_inputs   = 4,
+                .audio_inputs   = 0,
+                .tuner          = -1,
+                .svhs           = -1,
+                .gpiomask       = 0x0f, /* old: 7 */
+                .muxsel         = { 0, 1, 3, 2}, /* Composite 0-3 */
+                .no_msp34xx     = 1,
+                .no_tda9875     = 1,
+                .no_tda7432     = 1,
+                .tuner_type     = -1,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+        },
 };
 
 static const unsigned int bttv_num_tvcards = ARRAY_SIZE(bttv_tvcards);
@@ -3037,26 +3056,33 @@ static void miro_pinnacle_gpio(struct bttv *btv)
                 switch (id) {
                 case 1:
                         info = "PAL / mono";
+                        btv->tda9887_conf = TDA9887_INTERCARRIER;
                         break;
                 case 2:
                         info = "PAL+SECAM / stereo";
                         btv->has_radio = 1;
+                        btv->tda9887_conf = TDA9887_QSS;
                         break;
                 case 3:
                         info = "NTSC / stereo";
                         btv->has_radio = 1;
+                        btv->tda9887_conf = TDA9887_QSS;
                         break;
                 case 4:
                         info = "PAL+SECAM / mono";
+                        btv->tda9887_conf = TDA9887_QSS;
                         break;
                 case 5:
                         info = "NTSC / mono";
+                        btv->tda9887_conf = TDA9887_INTERCARRIER;
                         break;
                 case 6:
                         info = "NTSC / stereo";
+                        btv->tda9887_conf = TDA9887_INTERCARRIER;
                         break;
                 case 7:
                         info = "PAL / stereo";
+                        btv->tda9887_conf = TDA9887_INTERCARRIER;
                         break;
                 default:
                         info = "oops: unknown card";
@@ -3067,8 +3093,7 @@ static void miro_pinnacle_gpio(struct bttv *btv)
                 printk(KERN_INFO
                        "bttv%d: pinnacle/mt: id=%d info=\"%s\" radio=%s\n",
                        btv->c.nr, id, info, btv->has_radio ? "yes" : "no");
-                btv->tuner_type  = 33;
-                btv->pinnacle_id = id;
+                btv->tuner_type = TUNER_MT2032;
         }
 }
 
@@ -3370,9 +3395,9 @@ void __devinit bttv_init_card2(struct bttv *btv)
                 bttv_call_i2c_clients(btv, TUNER_SET_TYPE_ADDR, &tun_setup);
         }
 
-        if (btv->pinnacle_id != UNSET) {
-                bttv_call_i2c_clients(btv, AUDC_CONFIG_PINNACLE,
-                                                        &btv->pinnacle_id);
+        if (btv->tda9887_conf) {
+                bttv_call_i2c_clients(btv, TDA9887_SET_CONFIG,
+                                                        &btv->tda9887_conf);
         }
 
         btv->svhs = bttv_tvcards[btv->c.type].svhs;
@@ -3387,8 +3412,6 @@ void __devinit bttv_init_card2(struct bttv *btv)
                 btv->has_remote=1;
         if (!bttv_tvcards[btv->c.type].no_gpioirq)
                 btv->gpioirq=1;
-        if (bttv_tvcards[btv->c.type].any_irq)
-                btv->any_irq = 1;
         if (bttv_tvcards[btv->c.type].audio_hook)
                 btv->audio_hook=bttv_tvcards[btv->c.type].audio_hook;
 
@@ -3424,7 +3447,7 @@ void __devinit bttv_init_card2(struct bttv *btv)
 
         /* tuner modules */
         tda9887 = 0;
-        if (btv->pinnacle_id != UNSET)
+        if (btv->tda9887_conf)
                 tda9887 = 1;
         if (0 == tda9887 && 0 == bttv_tvcards[btv->c.type].has_dvb &&
             bttv_I2CRead(btv, I2C_TDA9887, "TDA9887") >=0)
@@ -3471,6 +3494,21 @@ static void __devinit hauppauge_eeprom(struct bttv *btv)
         tveeprom_hauppauge_analog(&btv->i2c_client, &tv, eeprom_data);
         btv->tuner_type = tv.tuner_type;
         btv->has_radio  = tv.has_radio;
+
+        printk("bttv%d: Hauppauge eeprom indicates model#%d\n",
+                btv->c.nr, tv.model);
+
+        /*
+         * Some of the 878 boards have duplicate PCI IDs. Switch the board
+         * type based on model #.
+         */
+        if(tv.model == 64900) {
+                printk("bttv%d: Switching board type from %s to %s\n",
+                        btv->c.nr,
+                        bttv_tvcards[btv->c.type].name,
+                        bttv_tvcards[BTTV_BOARD_HAUPPAUGE_IMPACTVCB].name);
+                btv->c.type = BTTV_BOARD_HAUPPAUGE_IMPACTVCB;
+        }
 }
 
 static int terratec_active_radio_upgrade(struct bttv *btv)
diff --git a/drivers/media/video/bttv-driver.c b/drivers/media/video/bttv-driver.c
index 1ddf9ba613ef..0e6970346788 100644
--- a/drivers/media/video/bttv-driver.c
+++ b/drivers/media/video/bttv-driver.c
@@ -34,13 +34,14 @@
 #include <linux/sched.h>
 #include <linux/interrupt.h>
 #include <linux/kdev_t.h>
+#include "bttvp.h"
+#include <media/v4l2-common.h>
+
 #include <linux/dma-mapping.h>
 
 #include <asm/io.h>
 #include <asm/byteorder.h>
 
-#include "bttvp.h"
-
 #include "rds.h"
 
 
@@ -210,6 +211,9 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x20,
                 .vbipack        = 255,
                 .sram           = 0,
+                /* ITU-R frame line number of the first VBI line
+                   we can capture, of the first and second field. */
+                .vbistart       = { 7,320 },
         },{
                 .v4l2_id        = V4L2_STD_NTSC_M,
                 .name           = "NTSC",
@@ -226,6 +230,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x1a,
                 .vbipack        = 144,
                 .sram           = 1,
+                .vbistart       = { 10, 273 },
         },{
                 .v4l2_id        = V4L2_STD_SECAM,
                 .name           = "SECAM",
@@ -242,6 +247,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x20,
                 .vbipack        = 255,
                 .sram           = 0, /* like PAL, correct? */
+                .vbistart       = { 7, 320 },
         },{
                 .v4l2_id        = V4L2_STD_PAL_Nc,
                 .name           = "PAL-Nc",
@@ -258,6 +264,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x1a,
                 .vbipack        = 144,
                 .sram           = -1,
+                .vbistart       = { 7, 320 },
         },{
                 .v4l2_id        = V4L2_STD_PAL_M,
                 .name           = "PAL-M",
@@ -274,6 +281,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x1a,
                 .vbipack        = 144,
                 .sram           = -1,
+                .vbistart       = { 10, 273 },
         },{
                 .v4l2_id        = V4L2_STD_PAL_N,
                 .name           = "PAL-N",
@@ -290,6 +298,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x20,
                 .vbipack        = 144,
                 .sram           = -1,
+                .vbistart       = { 7, 320},
         },{
                 .v4l2_id        = V4L2_STD_NTSC_M_JP,
                 .name           = "NTSC-JP",
@@ -306,6 +315,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vdelay         = 0x16,
                 .vbipack        = 144,
                 .sram           = -1,
+                .vbistart       = {10, 273},
         },{
                 /* that one hopefully works with the strange timing
                  * which video recorders produce when playing a NTSC
@@ -326,6 +336,7 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                 .vbipack        = 255,
                 .vtotal         = 524,
                 .sram           = -1,
+                .vbistart       = { 10, 273 },
         }
 };
 static const unsigned int BTTV_TVNORMS = ARRAY_SIZE(bttv_tvnorms);
@@ -1510,14 +1521,6 @@ static struct videobuf_queue_ops bttv_video_qops = {
         .buf_release  = buffer_release,
 };
 
-static const char *v4l1_ioctls[] = {
-        "?", "CGAP", "GCHAN", "SCHAN", "GTUNER", "STUNER", "GPICT", "SPICT",
-        "CCAPTURE", "GWIN", "SWIN", "GFBUF", "SFBUF", "KEY", "GFREQ",
-        "SFREQ", "GAUDIO", "SAUDIO", "SYNC", "MCAPTURE", "GMBUF", "GUNIT",
-        "GCAPTURE", "SCAPTURE", "SPLAYMODE", "SWRITEMODE", "GPLAYINFO",
-        "SMICROCODE", "GVBIFMT", "SVBIFMT" };
-#define V4L1_IOCTLS ARRAY_SIZE(v4l1_ioctls)
-
 static int bttv_common_ioctls(struct bttv *btv, unsigned int cmd, void *arg)
 {
         switch (cmd) {
@@ -2206,22 +2209,9 @@ static int bttv_do_ioctl(struct inode *inode, struct file *file,
         unsigned long flags;
         int retval = 0;
 
-        if (bttv_debug > 1) {
-                switch (_IOC_TYPE(cmd)) {
-                case 'v':
-                        printk("bttv%d: ioctl 0x%x (v4l1, VIDIOC%s)\n",
-                               btv->c.nr, cmd, (_IOC_NR(cmd) < V4L1_IOCTLS) ?
-                               v4l1_ioctls[_IOC_NR(cmd)] : "???");
-                        break;
-                case 'V':
-                        printk("bttv%d: ioctl 0x%x (v4l2, %s)\n",
-                               btv->c.nr, cmd,  v4l2_ioctl_names[_IOC_NR(cmd)]);
-                        break;
-                default:
-                        printk("bttv%d: ioctl 0x%x (???)\n",
-                               btv->c.nr, cmd);
-                }
-        }
+        if (bttv_debug > 1)
+                v4l_print_ioctl(btv->c.name, cmd);
+
         if (btv->errors)
                 bttv_reinit_bt848(btv);
 
@@ -2570,10 +2560,10 @@ static int bttv_do_ioctl(struct inode *inode, struct file *file,
                 fmt->count[0]         = fmt2.fmt.vbi.count[0];
                 fmt->start[1]         = fmt2.fmt.vbi.start[1];
                 fmt->count[1]         = fmt2.fmt.vbi.count[1];
-                if (fmt2.fmt.vbi.flags & VBI_UNSYNC)
-                        fmt->flags   |= V4L2_VBI_UNSYNC;
-                if (fmt2.fmt.vbi.flags & VBI_INTERLACED)
-                        fmt->flags   |= V4L2_VBI_INTERLACED;
+                if (fmt2.fmt.vbi.flags & V4L2_VBI_UNSYNC)
+                        fmt->flags   |= VBI_UNSYNC;
+                if (fmt2.fmt.vbi.flags & V4L2_VBI_INTERLACED)
+                        fmt->flags   |= VBI_INTERLACED;
                 return 0;
         }
         case VIDIOCSVBIFMT:
@@ -3120,6 +3110,7 @@ static struct file_operations bttv_fops =
         .open     = bttv_open,
         .release  = bttv_release,
         .ioctl    = bttv_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek   = no_llseek,
         .read     = bttv_read,
         .mmap     = bttv_mmap,
@@ -3229,6 +3220,7 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
         case VIDIOCSFREQ:
         case VIDIOCGAUDIO:
         case VIDIOCSAUDIO:
+        case VIDIOC_LOG_STATUS:
                 return bttv_common_ioctls(btv,cmd,arg);
 
         default:
@@ -3701,8 +3693,8 @@ static irqreturn_t bttv_irq(int irq, void *dev_id, struct pt_regs * regs)
 
         btv=(struct bttv *)dev_id;
 
-        if (btv->any_irq)
-                handled = bttv_any_irq(&btv->c);
+        if (btv->custom_irq)
+                handled = btv->custom_irq(btv);
 
         count=0;
         while (1) {
@@ -3738,9 +3730,9 @@ static irqreturn_t bttv_irq(int irq, void *dev_id, struct pt_regs * regs)
                 if (astat&BT848_INT_VSYNC)
                         btv->field_count++;
 
-                if (astat & BT848_INT_GPINT) {
+                if ((astat & BT848_INT_GPINT) && btv->remote) {
                         wake_up(&btv->gpioq);
-                        bttv_gpio_irq(&btv->c);
+                        bttv_input_irq(btv);
                 }
 
                 if (astat & BT848_INT_I2CDONE) {
@@ -3946,7 +3938,6 @@ static int __devinit bttv_probe(struct pci_dev *dev,
 
         btv->i2c_rc = -1;
         btv->tuner_type  = UNSET;
-        btv->pinnacle_id = UNSET;
         btv->new_input   = UNSET;
         btv->has_radio=radio[btv->c.nr];
 
@@ -4065,11 +4056,11 @@ static int __devinit bttv_probe(struct pci_dev *dev,
         }
 
         /* add subdevices */
-        if (btv->has_remote)
-                bttv_sub_add_device(&btv->c, "remote");
         if (bttv_tvcards[btv->c.type].has_dvb)
                 bttv_sub_add_device(&btv->c, "dvb");
 
+        bttv_input_init(btv);
+
         /* everything is fine */
         bttv_num++;
         return 0;
@@ -4104,6 +4095,7 @@ static void __devexit bttv_remove(struct pci_dev *pci_dev)
         /* tell gpio modules we are leaving ... */
         btv->shutdown=1;
         wake_up(&btv->gpioq);
+        bttv_input_fini(btv);
         bttv_sub_del_devices(&btv->c);
 
         /* unregister i2c_bus + input */
@@ -4253,7 +4245,7 @@ static int bttv_init_module(void)
         bttv_check_chipset();
 
         bus_register(&bttv_sub_bus_type);
-        return pci_module_init(&bttv_pci_driver);
+        return pci_register_driver(&bttv_pci_driver);
 }
 
 static void bttv_cleanup_module(void)
diff --git a/drivers/media/video/bttv-gpio.c b/drivers/media/video/bttv-gpio.c
index 616a5b7e510c..575ce8b8e714 100644
--- a/drivers/media/video/bttv-gpio.c
+++ b/drivers/media/video/bttv-gpio.c
@@ -113,24 +113,6 @@ void bttv_gpio_irq(struct bttv_core *core)
         }
 }
 
-int bttv_any_irq(struct bttv_core *core)
-{
-        struct bttv_sub_driver *drv;
-        struct bttv_sub_device *dev;
-        struct list_head *item;
-        int handled = 0;
-
-        list_for_each(item,&core->subs) {
-                dev = list_entry(item,struct bttv_sub_device,list);
-                drv = to_bttv_sub_drv(dev->dev.driver);
-                if (drv && drv->any_irq) {
-                        if (drv->any_irq(dev))
-                                handled = 1;
-                }
-        }
-        return handled;
-}
-
 /* ----------------------------------------------------------------------- */
 /* external: sub-driver register/unregister                                */
 
diff --git a/drivers/media/video/bttv-i2c.c b/drivers/media/video/bttv-i2c.c
index d6418c023d39..748d630c7fe4 100644
--- a/drivers/media/video/bttv-i2c.c
+++ b/drivers/media/video/bttv-i2c.c
@@ -28,10 +28,11 @@
 #include <linux/moduleparam.h>
 #include <linux/init.h>
 #include <linux/delay.h>
-#include <linux/jiffies.h>
-#include <asm/io.h>
 
 #include "bttvp.h"
+#include <media/v4l2-common.h>
+#include <linux/jiffies.h>
+#include <asm/io.h>
 
 static struct i2c_algo_bit_data bttv_i2c_algo_bit_template;
 static struct i2c_adapter bttv_i2c_adap_sw_template;
@@ -105,10 +106,8 @@ static struct i2c_algo_bit_data bttv_i2c_algo_bit_template = {
 
 static struct i2c_adapter bttv_i2c_adap_sw_template = {
         .owner             = THIS_MODULE,
-#ifdef I2C_CLASS_TV_ANALOG
         .class             = I2C_CLASS_TV_ANALOG,
-#endif
-        .name              = "bt848",
+        .name              = "bttv",
         .id                = I2C_HW_B_BT848,
         .client_register   = attach_inform,
 };
@@ -275,10 +274,8 @@ static struct i2c_algorithm bttv_algo = {
 };
 
 static struct i2c_adapter bttv_i2c_adap_hw_template = {
-        .owner         = THIS_MODULE,
-#ifdef I2C_CLASS_TV_ANALOG
+        .owner             = THIS_MODULE,
         .class         = I2C_CLASS_TV_ANALOG,
-#endif
         .name          = "bt878",
         .id            = I2C_HW_B_BT848 /* FIXME */,
         .algo          = &bttv_algo,
@@ -441,12 +438,10 @@ int __devinit init_bttv_i2c(struct bttv *btv)
         i2c_set_adapdata(&btv->c.i2c_adap, btv);
         btv->i2c_client.adapter = &btv->c.i2c_adap;
 
-#ifdef I2C_CLASS_TV_ANALOG
         if (bttv_tvcards[btv->c.type].no_video)
                 btv->c.i2c_adap.class &= ~I2C_CLASS_TV_ANALOG;
         if (bttv_tvcards[btv->c.type].has_dvb)
                 btv->c.i2c_adap.class |= I2C_CLASS_TV_DIGITAL;
-#endif
 
         if (btv->use_i2c_hw) {
                 btv->i2c_rc = i2c_add_adapter(&btv->c.i2c_adap);
diff --git a/drivers/media/video/ir-kbd-gpio.c b/drivers/media/video/bttv-input.c
index de1385e5d05e..12197f1b2757 100644
--- a/drivers/media/video/ir-kbd-gpio.c
+++ b/drivers/media/video/bttv-input.c
@@ -24,11 +24,9 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/input.h>
-#include <linux/pci.h>
-
-#include <media/ir-common.h>
 
 #include "bttv.h"
+#include "bttvp.h"
 
 /* ---------------------------------------------------------------------- */
 
@@ -156,9 +154,6 @@ static IR_KEYTAB_TYPE ir_codes_apac_viewcomp[IR_KEYTAB_SIZE] = {
 
 /* ---------------------------------------------------------------------- */
 
-/* Ricardo Cerqueira <v4l@cerqueira.org> */
-/* Weird matching, since the remote has "uncommon" keys */
-
 static IR_KEYTAB_TYPE ir_codes_conceptronic[IR_KEYTAB_SIZE] = {
 
         [ 30 ] = KEY_POWER,       // power
@@ -279,34 +274,6 @@ static IR_KEYTAB_TYPE ir_codes_nebula[IR_KEYTAB_SIZE] = {
         [0x36] = KEY_PC
 };
 
-struct IR {
-        struct bttv_sub_device  *sub;
-        struct input_dev        *input;
-        struct ir_input_state   ir;
-        char                    name[32];
-        char                    phys[32];
-
-        /* Usual gpio signalling */
-
-        u32                     mask_keycode;
-        u32                     mask_keydown;
-        u32                     mask_keyup;
-        u32                     polling;
-        u32                     last_gpio;
-        struct work_struct      work;
-        struct timer_list       timer;
-
-        /* RC5 gpio */
-        u32 rc5_gpio;
-        struct timer_list timer_end;    /* timer_end for code completion */
-        struct timer_list timer_keyup;  /* timer_end for key release */
-        u32 last_rc5;                   /* last good rc5 code */
-        u32 last_bit;                   /* last raw bit seen */
-        u32 code;                       /* raw code under construction */
-        struct timeval base_time;       /* time of last seen code */
-        int active;                     /* building raw code */
-};
-
 static int debug;
 module_param(debug, int, 0644);    /* debug level (0,1,2) */
 static int repeat_delay = 500;
@@ -314,31 +281,17 @@ module_param(repeat_delay, int, 0644);
 static int repeat_period = 33;
 module_param(repeat_period, int, 0644);
 
-#define DEVNAME "ir-kbd-gpio"
-#define dprintk(fmt, arg...)    if (debug) \
-        printk(KERN_DEBUG DEVNAME ": " fmt , ## arg)
-
-static void ir_irq(struct bttv_sub_device *sub);
-static int ir_probe(struct device *dev);
-static int ir_remove(struct device *dev);
-
-static struct bttv_sub_driver driver = {
-        .drv = {
-                .name   = DEVNAME,
-                .probe  = ir_probe,
-                .remove = ir_remove,
-        },
-        .gpio_irq       = ir_irq,
-};
+#define DEVNAME "bttv-input"
 
 /* ---------------------------------------------------------------------- */
 
-static void ir_handle_key(struct IR *ir)
+static void ir_handle_key(struct bttv *btv)
 {
+        struct bttv_ir *ir = btv->remote;
         u32 gpio,data;
 
         /* read gpio value */
-        gpio = bttv_gpio_read(ir->sub->core);
+        gpio = bttv_gpio_read(&btv->c);
         if (ir->polling) {
                 if (ir->last_gpio == gpio)
                         return;
@@ -347,56 +300,36 @@ static void ir_handle_key(struct IR *ir)
 
         /* extract data */
         data = ir_extract_bits(gpio, ir->mask_keycode);
-        dprintk(DEVNAME ": irq gpio=0x%x code=%d | %s%s%s\n",
+        dprintk(KERN_INFO DEVNAME ": irq gpio=0x%x code=%d | %s%s%s\n",
                 gpio, data,
                 ir->polling               ? "poll"  : "irq",
                 (gpio & ir->mask_keydown) ? " down" : "",
                 (gpio & ir->mask_keyup)   ? " up"   : "");
 
-        if (ir->mask_keydown) {
-                /* bit set on keydown */
-                if (gpio & ir->mask_keydown) {
-                        ir_input_keydown(ir->input, &ir->ir, data, data);
-                } else {
-                        ir_input_nokey(ir->input, &ir->ir);
-                }
-
-        } else if (ir->mask_keyup) {
-                /* bit cleared on keydown */
-                if (0 == (gpio & ir->mask_keyup)) {
-                        ir_input_keydown(ir->input, &ir->ir, data, data);
-                } else {
-                        ir_input_nokey(ir->input, &ir->ir);
-                }
-
+        if ((ir->mask_keydown  &&  (0 != (gpio & ir->mask_keydown))) ||
+            (ir->mask_keyup    &&  (0 == (gpio & ir->mask_keyup)))) {
+                ir_input_keydown(ir->dev,&ir->ir,data,data);
         } else {
-                /* can't disturgissh keydown/up :-/ */
-                ir_input_keydown(ir->input, &ir->ir, data, data);
-                ir_input_nokey(ir->input, &ir->ir);
+                ir_input_nokey(ir->dev,&ir->ir);
         }
-}
-
-static void ir_irq(struct bttv_sub_device *sub)
-{
-        struct IR *ir = dev_get_drvdata(&sub->dev);
 
-        if (!ir->polling)
-                ir_handle_key(ir);
 }
 
-static void ir_timer(unsigned long data)
+void bttv_input_irq(struct bttv *btv)
 {
-        struct IR *ir = (struct IR*)data;
+        struct bttv_ir *ir = btv->remote;
 
-        schedule_work(&ir->work);
+        if (!ir->polling)
+                ir_handle_key(btv);
 }
 
-static void ir_work(void *data)
+static void bttv_input_timer(unsigned long data)
 {
-        struct IR *ir = data;
+        struct bttv *btv = (struct bttv*)data;
+        struct bttv_ir *ir = btv->remote;
         unsigned long timeout;
 
-        ir_handle_key(ir);
+        ir_handle_key(btv);
         timeout = jiffies + (ir->polling * HZ / 1000);
         mod_timer(&ir->timer, timeout);
 }
@@ -435,26 +368,26 @@ static u32 rc5_decode(unsigned int code)
                         rc5 |= 1;
                         break;
                 case 3:
-                        dprintk("bad code: %x\n", org_code);
+                        dprintk(KERN_WARNING "bad code: %x\n", org_code);
                         return 0;
                 }
         }
-        dprintk("code=%x, rc5=%x, start=%x, toggle=%x, address=%x, "
+        dprintk(KERN_WARNING "code=%x, rc5=%x, start=%x, toggle=%x, address=%x, "
                 "instr=%x\n", rc5, org_code, RC5_START(rc5),
                 RC5_TOGGLE(rc5), RC5_ADDR(rc5), RC5_INSTR(rc5));
         return rc5;
 }
 
-static int ir_rc5_irq(struct bttv_sub_device *sub)
+static int bttv_rc5_irq(struct bttv *btv)
 {
-        struct IR *ir = dev_get_drvdata(&sub->dev);
+        struct bttv_ir *ir = btv->remote;
         struct timeval tv;
         u32 gpio;
         u32 gap;
         unsigned long current_jiffies, timeout;
 
         /* read gpio port */
-        gpio = bttv_gpio_read(ir->sub->core);
+        gpio = bttv_gpio_read(&btv->c);
 
         /* remote IRQ? */
         if (!(gpio & 0x20))
@@ -493,14 +426,15 @@ static int ir_rc5_irq(struct bttv_sub_device *sub)
         }
 
         /* toggle GPIO pin 4 to reset the irq */
-        bttv_gpio_write(ir->sub->core, gpio & ~(1 << 4));
-        bttv_gpio_write(ir->sub->core, gpio | (1 << 4));
+        bttv_gpio_write(&btv->c, gpio & ~(1 << 4));
+        bttv_gpio_write(&btv->c, gpio | (1 << 4));
         return 1;
 }
 
-static void ir_rc5_timer_end(unsigned long data)
+
+static void bttv_rc5_timer_end(unsigned long data)
 {
-        struct IR *ir = (struct IR *)data;
+        struct bttv_ir *ir = (struct bttv_ir *)data;
         struct timeval tv;
         unsigned long current_jiffies, timeout;
         u32 gap;
@@ -519,20 +453,20 @@ static void ir_rc5_timer_end(unsigned long data)
 
         /* Allow some timmer jitter (RC5 is ~24ms anyway so this is ok) */
         if (gap < 28000) {
-                dprintk("spurious timer_end\n");
+                dprintk(KERN_WARNING "spurious timer_end\n");
                 return;
         }
 
         ir->active = 0;
         if (ir->last_bit < 20) {
                 /* ignore spurious codes (caused by light/other remotes) */
-                dprintk("short code: %x\n", ir->code);
+                dprintk(KERN_WARNING "short code: %x\n", ir->code);
         } else {
                 u32 rc5 = rc5_decode(ir->code);
 
                 /* two start bits? */
                 if (RC5_START(rc5) != 3) {
-                        dprintk("rc5 start bits invalid: %u\n", RC5_START(rc5));
+                        dprintk(KERN_WARNING "rc5 start bits invalid: %u\n", RC5_START(rc5));
 
                         /* right address? */
                 } else if (RC5_ADDR(rc5) == 0x0) {
@@ -542,10 +476,10 @@ static void ir_rc5_timer_end(unsigned long data)
                         /* Good code, decide if repeat/repress */
                         if (toggle != RC5_TOGGLE(ir->last_rc5) ||
                             instr != RC5_INSTR(ir->last_rc5)) {
-                                dprintk("instruction %x, toggle %x\n", instr,
+                                dprintk(KERN_WARNING "instruction %x, toggle %x\n", instr,
                                         toggle);
-                                ir_input_nokey(ir->input, &ir->ir);
-                                ir_input_keydown(ir->input, &ir->ir, instr,
+                                ir_input_nokey(ir->dev, &ir->ir);
+                                ir_input_keydown(ir->dev, &ir->ir, instr,
                                                  instr);
                         }
 
@@ -560,34 +494,37 @@ static void ir_rc5_timer_end(unsigned long data)
         }
 }
 
-static void ir_rc5_timer_keyup(unsigned long data)
+static void bttv_rc5_timer_keyup(unsigned long data)
 {
-        struct IR *ir = (struct IR *)data;
+        struct bttv_ir *ir = (struct bttv_ir *)data;
 
-        dprintk("key released\n");
-        ir_input_nokey(ir->input, &ir->ir);
+        dprintk(KERN_DEBUG "key released\n");
+        ir_input_nokey(ir->dev, &ir->ir);
 }
 
 /* ---------------------------------------------------------------------- */
 
-static int ir_probe(struct device *dev)
+int bttv_input_init(struct bttv *btv)
 {
-        struct bttv_sub_device *sub = to_bttv_sub_dev(dev);
-        struct IR *ir;
-        struct input_dev *input_dev;
+        struct bttv_ir *ir;
         IR_KEYTAB_TYPE *ir_codes = NULL;
+        struct input_dev *input_dev;
         int ir_type = IR_TYPE_OTHER;
 
-        ir = kzalloc(sizeof(*ir), GFP_KERNEL);
+        if (!btv->has_remote)
+                return -ENODEV;
+
+        ir = kzalloc(sizeof(*ir),GFP_KERNEL);
         input_dev = input_allocate_device();
         if (!ir || !input_dev) {
                 kfree(ir);
                 input_free_device(input_dev);
                 return -ENOMEM;
         }
+        memset(ir,0,sizeof(*ir));
 
         /* detect & configure */
-        switch (sub->core->type) {
+        switch (btv->c.type) {
         case BTTV_BOARD_AVERMEDIA:
         case BTTV_BOARD_AVPHONE98:
         case BTTV_BOARD_AVERMEDIA98:
@@ -643,12 +580,12 @@ static int ir_probe(struct device *dev)
                 break;
         case BTTV_BOARD_NEBULA_DIGITV:
                 ir_codes = ir_codes_nebula;
-                driver.any_irq = ir_rc5_irq;
-                driver.gpio_irq = NULL;
+                btv->custom_irq = bttv_rc5_irq;
                 ir->rc5_gpio = 1;
                 break;
         }
         if (NULL == ir_codes) {
+                dprintk(KERN_INFO "Ooops: IR config error [card=%d]\n",btv->c.type);
                 kfree(ir);
                 input_free_device(input_dev);
                 return -ENODEV;
@@ -657,109 +594,92 @@ static int ir_probe(struct device *dev)
         if (ir->rc5_gpio) {
                 u32 gpio;
                 /* enable remote irq */
-                bttv_gpio_inout(sub->core, (1 << 4), 1 << 4);
-                gpio = bttv_gpio_read(sub->core);
-                bttv_gpio_write(sub->core, gpio & ~(1 << 4));
-                bttv_gpio_write(sub->core, gpio | (1 << 4));
+                bttv_gpio_inout(&btv->c, (1 << 4), 1 << 4);
+                gpio = bttv_gpio_read(&btv->c);
+                bttv_gpio_write(&btv->c, gpio & ~(1 << 4));
+                bttv_gpio_write(&btv->c, gpio | (1 << 4));
         } else {
                 /* init hardware-specific stuff */
-                bttv_gpio_inout(sub->core, ir->mask_keycode | ir->mask_keydown, 0);
+                bttv_gpio_inout(&btv->c, ir->mask_keycode | ir->mask_keydown, 0);
         }
 
         /* init input device */
+        ir->dev = input_dev;
+
         snprintf(ir->name, sizeof(ir->name), "bttv IR (card=%d)",
-                 sub->core->type);
+                 btv->c.type);
         snprintf(ir->phys, sizeof(ir->phys), "pci-%s/ir0",
-                 pci_name(sub->core->pci));
+                 pci_name(btv->c.pci));
 
         ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
         input_dev->name = ir->name;
         input_dev->phys = ir->phys;
         input_dev->id.bustype = BUS_PCI;
         input_dev->id.version = 1;
-        if (sub->core->pci->subsystem_vendor) {
-                input_dev->id.vendor  = sub->core->pci->subsystem_vendor;
-                input_dev->id.product = sub->core->pci->subsystem_device;
+        if (btv->c.pci->subsystem_vendor) {
+                input_dev->id.vendor  = btv->c.pci->subsystem_vendor;
+                input_dev->id.product = btv->c.pci->subsystem_device;
         } else {
-                input_dev->id.vendor  = sub->core->pci->vendor;
-                input_dev->id.product = sub->core->pci->device;
+                input_dev->id.vendor  = btv->c.pci->vendor;
+                input_dev->id.product = btv->c.pci->device;
         }
-        input_dev->cdev.dev = &sub->core->pci->dev;
-
-        ir->input = input_dev;
-        ir->sub = sub;
+        input_dev->cdev.dev = &btv->c.pci->dev;
 
+        btv->remote = ir;
         if (ir->polling) {
-                INIT_WORK(&ir->work, ir_work, ir);
                 init_timer(&ir->timer);
-                ir->timer.function = ir_timer;
-                ir->timer.data     = (unsigned long)ir;
-                schedule_work(&ir->work);
+                ir->timer.function = bttv_input_timer;
+                ir->timer.data     = (unsigned long)btv;
+                ir->timer.expires  = jiffies + HZ;
+                add_timer(&ir->timer);
         } else if (ir->rc5_gpio) {
                 /* set timer_end for code completion */
                 init_timer(&ir->timer_end);
-                ir->timer_end.function = ir_rc5_timer_end;
+                ir->timer_end.function = bttv_rc5_timer_end;
                 ir->timer_end.data = (unsigned long)ir;
 
                 init_timer(&ir->timer_keyup);
-                ir->timer_keyup.function = ir_rc5_timer_keyup;
+                ir->timer_keyup.function = bttv_rc5_timer_keyup;
                 ir->timer_keyup.data = (unsigned long)ir;
         }
 
         /* all done */
-        dev_set_drvdata(dev, ir);
-        input_register_device(ir->input);
+        input_register_device(btv->remote->dev);
+        printk(DEVNAME ": %s detected at %s\n",ir->name,ir->phys);
 
         /* the remote isn't as bouncy as a keyboard */
-        ir->input->rep[REP_DELAY] = repeat_delay;
-        ir->input->rep[REP_PERIOD] = repeat_period;
+        ir->dev->rep[REP_DELAY] = repeat_delay;
+        ir->dev->rep[REP_PERIOD] = repeat_period;
 
         return 0;
 }
 
-static int ir_remove(struct device *dev)
+void bttv_input_fini(struct bttv *btv)
 {
-        struct IR *ir = dev_get_drvdata(dev);
+        if (btv->remote == NULL)
+                return;
 
-        if (ir->polling) {
-                del_timer(&ir->timer);
+        if (btv->remote->polling) {
+                del_timer_sync(&btv->remote->timer);
                 flush_scheduled_work();
         }
 
-        if (ir->rc5_gpio) {
+
+        if (btv->remote->rc5_gpio) {
                 u32 gpio;
 
-                del_timer(&ir->timer_end);
+                del_timer_sync(&btv->remote->timer_end);
                 flush_scheduled_work();
 
-                gpio = bttv_gpio_read(ir->sub->core);
-                bttv_gpio_write(ir->sub->core, gpio & ~(1 << 4));
+                gpio = bttv_gpio_read(&btv->c);
+                bttv_gpio_write(&btv->c, gpio & ~(1 << 4));
         }
 
-        input_unregister_device(ir->input);
-        kfree(ir);
-        return 0;
-}
-
-/* ---------------------------------------------------------------------- */
-
-MODULE_AUTHOR("Gerd Knorr, Pavel Machek");
-MODULE_DESCRIPTION("input driver for bt8x8 gpio IR remote controls");
-MODULE_LICENSE("GPL");
-
-static int ir_init(void)
-{
-        return bttv_sub_register(&driver, "remote");
+        input_unregister_device(btv->remote->dev);
+        kfree(btv->remote);
+        btv->remote = NULL;
 }
 
-static void ir_fini(void)
-{
-        bttv_sub_unregister(&driver);
-}
-
-module_init(ir_init);
-module_exit(ir_fini);
-
 
 /*
  * Local variables:
diff --git a/drivers/media/video/bttv-vbi.c b/drivers/media/video/bttv-vbi.c
index f4f58c60f152..72afdd64b882 100644
--- a/drivers/media/video/bttv-vbi.c
+++ b/drivers/media/video/bttv-vbi.c
@@ -31,6 +31,12 @@
 #include <asm/io.h>
 #include "bttvp.h"
 
+/* Offset from line sync pulse leading edge (0H) in 1 / sampling_rate:
+   bt8x8 /HRESET pulse starts at 0H and has length 64 / fCLKx1 (E|O_VTC
+   HSFMT = 0). VBI_HDELAY (always 0) is an offset from the trailing edge
+   of /HRESET in 1 / fCLKx1, and the sampling_rate tvnorm->Fsc is fCLKx2. */
+#define VBI_OFFSET ((64 + 0) * 2)
+
 #define VBI_DEFLINES 16
 #define VBI_MAXLINES 32
 
@@ -163,40 +169,30 @@ void bttv_vbi_setlines(struct bttv_fh *fh, struct bttv *btv, int lines)
 void bttv_vbi_try_fmt(struct bttv_fh *fh, struct v4l2_format *f)
 {
         const struct bttv_tvnorm *tvnorm;
-        u32 start0,start1;
-        s32 count0,count1,count;
+        s64 count0,count1,count;
 
         tvnorm = &bttv_tvnorms[fh->btv->tvnorm];
         f->type = V4L2_BUF_TYPE_VBI_CAPTURE;
         f->fmt.vbi.sampling_rate    = tvnorm->Fsc;
         f->fmt.vbi.samples_per_line = 2048;
         f->fmt.vbi.sample_format    = V4L2_PIX_FMT_GREY;
-        f->fmt.vbi.offset           = 244;
+        f->fmt.vbi.offset           = VBI_OFFSET;
         f->fmt.vbi.flags            = 0;
-        switch (fh->btv->tvnorm) {
-        case 1: /* NTSC */
-                start0 = 10;
-                start1 = 273;
-                break;
-        case 0: /* PAL */
-        case 2: /* SECAM */
-        default:
-                start0 = 7;
-                start1 = 320;
-        }
 
-        count0 = (f->fmt.vbi.start[0] + f->fmt.vbi.count[0]) - start0;
-        count1 = (f->fmt.vbi.start[1] + f->fmt.vbi.count[1]) - start1;
-        count  = max(count0,count1);
-        if (count > VBI_MAXLINES)
-                count = VBI_MAXLINES;
-        if (count < 1)
-                count = 1;
+        /* s64 to prevent overflow. */
+        count0 = (s64) f->fmt.vbi.start[0] + f->fmt.vbi.count[0]
+                - tvnorm->vbistart[0];
+        count1 = (s64) f->fmt.vbi.start[1] + f->fmt.vbi.count[1]
+                - tvnorm->vbistart[1];
+        count  = clamp (max (count0, count1), 1LL, (s64) VBI_MAXLINES);
 
-        f->fmt.vbi.start[0] = start0;
-        f->fmt.vbi.start[1] = start1;
+        f->fmt.vbi.start[0] = tvnorm->vbistart[0];
+        f->fmt.vbi.start[1] = tvnorm->vbistart[1];
         f->fmt.vbi.count[0] = count;
         f->fmt.vbi.count[1] = count;
+
+        f->fmt.vbi.reserved[0] = 0;
+        f->fmt.vbi.reserved[1] = 0;
 }
 
 void bttv_vbi_get_fmt(struct bttv_fh *fh, struct v4l2_format *f)
@@ -209,21 +205,12 @@ void bttv_vbi_get_fmt(struct bttv_fh *fh, struct v4l2_format *f)
         f->fmt.vbi.sampling_rate    = tvnorm->Fsc;
         f->fmt.vbi.samples_per_line = 2048;
         f->fmt.vbi.sample_format    = V4L2_PIX_FMT_GREY;
-        f->fmt.vbi.offset           = 244;
+        f->fmt.vbi.offset           = VBI_OFFSET;
+        f->fmt.vbi.start[0]         = tvnorm->vbistart[0];
+        f->fmt.vbi.start[1]         = tvnorm->vbistart[1];
         f->fmt.vbi.count[0]         = fh->lines;
         f->fmt.vbi.count[1]         = fh->lines;
         f->fmt.vbi.flags            = 0;
-        switch (fh->btv->tvnorm) {
-        case 1: /* NTSC */
-                f->fmt.vbi.start[0] = 10;
-                f->fmt.vbi.start[1] = 273;
-                break;
-        case 0: /* PAL */
-        case 2: /* SECAM */
-        default:
-                f->fmt.vbi.start[0] = 7;
-                f->fmt.vbi.start[1] = 319;
-        }
 }
 
 /* ----------------------------------------------------------------------- */
diff --git a/drivers/media/video/bttv.h b/drivers/media/video/bttv.h
index 93298f06e019..9feaa6bab207 100644
--- a/drivers/media/video/bttv.h
+++ b/drivers/media/video/bttv.h
@@ -16,6 +16,8 @@
 
 #include <linux/videodev.h>
 #include <linux/i2c.h>
+#include <media/ir-common.h>
+#include <media/ir-kbd-i2c.h>
 
 /* ---------------------------------------------------------- */
 /* exported by bttv-cards.c                                   */
@@ -163,6 +165,7 @@
 #define BTTV_BOARD_OSPREY440               0x8c
 #define BTTV_BOARD_ASOUND_SKYEYE           0x8d
 #define BTTV_BOARD_SABRENT_TVFM            0x8e
+#define BTTV_BOARD_HAUPPAUGE_IMPACTVCB     0x8f
 
 /* i2c address list */
 #define I2C_TSA5522        0xc2
@@ -210,6 +213,34 @@ struct bttv_core {
 
 struct bttv;
 
+
+struct bttv_ir {
+        struct input_dev        *dev;
+        struct ir_input_state   ir;
+        char                    name[32];
+        char                    phys[32];
+
+        /* Usual gpio signalling */
+
+        u32                     mask_keycode;
+        u32                     mask_keydown;
+        u32                     mask_keyup;
+        u32                     polling;
+        u32                     last_gpio;
+        struct work_struct      work;
+        struct timer_list       timer;
+
+        /* RC5 gpio */
+        u32 rc5_gpio;
+        struct timer_list timer_end;    /* timer_end for code completion */
+        struct timer_list timer_keyup;  /* timer_end for key release */
+        u32 last_rc5;                   /* last good rc5 code */
+        u32 last_bit;                   /* last raw bit seen */
+        u32 code;                       /* raw code under construction */
+        struct timeval base_time;       /* time of last seen code */
+        int active;                     /* building raw code */
+};
+
 struct tvcard
 {
         char *name;
@@ -235,7 +266,6 @@ struct tvcard
         unsigned int has_dvb:1;
         unsigned int has_remote:1;
         unsigned int no_gpioirq:1;
-        unsigned int any_irq:1;
 
         /* other settings */
         unsigned int pll;
@@ -335,7 +365,6 @@ struct bttv_sub_driver {
         struct device_driver   drv;
         char                   wanted[BUS_ID_SIZE];
         void                   (*gpio_irq)(struct bttv_sub_device *sub);
-        int                    (*any_irq)(struct bttv_sub_device *sub);
 };
 #define to_bttv_sub_drv(x) container_of((x), struct bttv_sub_driver, drv)
 
@@ -363,6 +392,10 @@ extern int bttv_I2CWrite(struct bttv *btv, unsigned char addr, unsigned char b1,
                          unsigned char b2, int both);
 extern void bttv_readee(struct bttv *btv, unsigned char *eedata, int addr);
 
+extern int bttv_input_init(struct bttv *dev);
+extern void bttv_input_fini(struct bttv *dev);
+extern void bttv_input_irq(struct bttv *dev);
+
 #endif /* _BTTV_H_ */
 /*
  * Local variables:
diff --git a/drivers/media/video/bttvp.h b/drivers/media/video/bttvp.h
index 1e6a5632c3c7..dd00c20ab95e 100644
--- a/drivers/media/video/bttvp.h
+++ b/drivers/media/video/bttvp.h
@@ -73,6 +73,8 @@
 
 #define UNSET (-1U)
 
+#define clamp(x, low, high) min (max (low, x), high)
+
 /* ---------------------------------------------------------- */
 
 struct bttv_tvnorm {
@@ -88,6 +90,9 @@ struct bttv_tvnorm {
         u8    vbipack;
         u16   vtotal;
         int   sram;
+        /* ITU-R frame line number of the first VBI line we can
+           capture, of the first and second field. */
+        u16   vbistart[2];
 };
 extern const struct bttv_tvnorm bttv_tvnorms[];
 
@@ -209,7 +214,6 @@ extern struct bus_type bttv_sub_bus_type;
 int bttv_sub_add_device(struct bttv_core *core, char *name);
 int bttv_sub_del_devices(struct bttv_core *core);
 void bttv_gpio_irq(struct bttv_core *core);
-int bttv_any_irq(struct bttv_core *core);
 
 
 /* ---------------------------------------------------------- */
@@ -270,12 +274,13 @@ struct bttv {
         /* card configuration info */
         unsigned int cardid;   /* pci subsystem id (bt878 based ones) */
         unsigned int tuner_type;  /* tuner chip type */
-        unsigned int pinnacle_id;
+        unsigned int tda9887_conf;
         unsigned int svhs;
         struct bttv_pll_info pll;
         int triton1;
         int gpioirq;
-        int any_irq;
+        int (*custom_irq)(struct bttv *btv);
+
         int use_i2c_hw;
 
         /* old gpio interface */
@@ -300,7 +305,7 @@ struct bttv {
 
         /* infrared remote */
         int has_remote;
-        struct bttv_input *remote;
+        struct bttv_ir *remote;
 
         /* locking */
         spinlock_t s_lock;
diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c
index 0065d0c240d1..6bad93ef969f 100644
--- a/drivers/media/video/bw-qcam.c
+++ b/drivers/media/video/bw-qcam.c
@@ -875,6 +875,7 @@ static struct file_operations qcam_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = qcam_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .read           = qcam_read,
         .llseek         = no_llseek,
 };
diff --git a/drivers/media/video/c-qcam.c b/drivers/media/video/c-qcam.c
index 75442ec49f35..9976db4f6da8 100644
--- a/drivers/media/video/c-qcam.c
+++ b/drivers/media/video/c-qcam.c
@@ -687,6 +687,7 @@ static struct file_operations qcam_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = qcam_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .read           = qcam_read,
         .llseek         = no_llseek,
 };
diff --git a/drivers/media/video/compat_ioctl32.c b/drivers/media/video/compat_ioctl32.c
new file mode 100644
index 000000000000..6194b0125576
--- /dev/null
+++ b/drivers/media/video/compat_ioctl32.c
@@ -0,0 +1,732 @@
+/*
+ * ioctl32.c: Conversion between 32bit and 64bit native ioctls.
+ *      Separated from fs stuff by Arnd Bergmann <arnd@arndb.de>
+ *
+ * Copyright (C) 1997-2000  Jakub Jelinek  (jakub@redhat.com)
+ * Copyright (C) 1998  Eddie C. Dost  (ecd@skynet.be)
+ * Copyright (C) 2001,2002  Andi Kleen, SuSE Labs
+ * Copyright (C) 2003       Pavel Machek (pavel@suse.cz)
+ * Copyright (C) 2005       Philippe De Muyter (phdm@macqel.be)
+ *
+ * These routines maintain argument size conversion between 32bit and 64bit
+ * ioctls.
+ */
+
+#include <linux/config.h>
+#include <linux/compat.h>
+#include <linux/videodev.h>
+#include <linux/videodev2.h>
+#include <linux/module.h>
+#include <linux/smp_lock.h>
+
+#ifdef CONFIG_COMPAT
+struct video_tuner32 {
+        compat_int_t tuner;
+        char name[32];
+        compat_ulong_t rangelow, rangehigh;
+        u32 flags;      /* It is really u32 in videodev.h */
+        u16 mode, signal;
+};
+
+static int get_video_tuner32(struct video_tuner *kp, struct video_tuner32 __user *up)
+{
+        if(get_user(kp->tuner, &up->tuner))
+                return -EFAULT;
+        __copy_from_user(kp->name, up->name, 32);
+        __get_user(kp->rangelow, &up->rangelow);
+        __get_user(kp->rangehigh, &up->rangehigh);
+        __get_user(kp->flags, &up->flags);
+        __get_user(kp->mode, &up->mode);
+        __get_user(kp->signal, &up->signal);
+        return 0;
+}
+
+static int put_video_tuner32(struct video_tuner *kp, struct video_tuner32 __user *up)
+{
+        if(put_user(kp->tuner, &up->tuner))
+                return -EFAULT;
+        __copy_to_user(up->name, kp->name, 32);
+        __put_user(kp->rangelow, &up->rangelow);
+        __put_user(kp->rangehigh, &up->rangehigh);
+        __put_user(kp->flags, &up->flags);
+        __put_user(kp->mode, &up->mode);
+        __put_user(kp->signal, &up->signal);
+        return 0;
+}
+
+struct video_buffer32 {
+        compat_caddr_t base;
+        compat_int_t height, width, depth, bytesperline;
+};
+
+static int get_video_buffer32(struct video_buffer *kp, struct video_buffer32 __user *up)
+{
+        u32 tmp;
+
+        if (get_user(tmp, &up->base))
+                return -EFAULT;
+
+        /* This is actually a physical address stored
+         * as a void pointer.
+         */
+        kp->base = (void *)(unsigned long) tmp;
+
+        __get_user(kp->height, &up->height);
+        __get_user(kp->width, &up->width);
+        __get_user(kp->depth, &up->depth);
+        __get_user(kp->bytesperline, &up->bytesperline);
+        return 0;
+}
+
+static int put_video_buffer32(struct video_buffer *kp, struct video_buffer32 __user *up)
+{
+        u32 tmp = (u32)((unsigned long)kp->base);
+
+        if(put_user(tmp, &up->base))
+                return -EFAULT;
+        __put_user(kp->height, &up->height);
+        __put_user(kp->width, &up->width);
+        __put_user(kp->depth, &up->depth);
+        __put_user(kp->bytesperline, &up->bytesperline);
+        return 0;
+}
+
+struct video_clip32 {
+        s32 x, y, width, height;        /* Its really s32 in videodev.h */
+        compat_caddr_t next;
+};
+
+struct video_window32 {
+        u32 x, y, width, height, chromakey, flags;
+        compat_caddr_t clips;
+        compat_int_t clipcount;
+};
+
+static int native_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+        int ret = -ENOIOCTLCMD;
+
+        if (file->f_op->unlocked_ioctl)
+                ret = file->f_op->unlocked_ioctl(file, cmd, arg);
+        else if (file->f_op->ioctl) {
+                lock_kernel();
+                ret = file->f_op->ioctl(file->f_dentry->d_inode, file, cmd, arg);
+                unlock_kernel();
+        }
+
+        return ret;
+}
+
+
+/* You get back everything except the clips... */
+static int put_video_window32(struct video_window *kp, struct video_window32 __user *up)
+{
+        if(put_user(kp->x, &up->x))
+                return -EFAULT;
+        __put_user(kp->y, &up->y);
+        __put_user(kp->width, &up->width);
+        __put_user(kp->height, &up->height);
+        __put_user(kp->chromakey, &up->chromakey);
+        __put_user(kp->flags, &up->flags);
+        __put_user(kp->clipcount, &up->clipcount);
+        return 0;
+}
+
+struct v4l2_clip32
+{
+        struct v4l2_rect        c;
+        compat_caddr_t          next;
+};
+
+struct v4l2_window32
+{
+        struct v4l2_rect        w;
+        enum v4l2_field         field;
+        __u32                   chromakey;
+        compat_caddr_t          clips; /* actually struct v4l2_clip32 * */
+        __u32                   clipcount;
+        compat_caddr_t          bitmap;
+};
+
+static int get_v4l2_window32(struct v4l2_window *kp, struct v4l2_window32 __user *up)
+{
+        if (copy_from_user(&kp->w, &up->w, sizeof(up->w)))
+                return -EFAULT;
+        __get_user(kp->field, &up->field);
+        __get_user(kp->chromakey, &up->chromakey);
+        __get_user(kp->clipcount, &up->clipcount);
+        if (kp->clipcount > 2048)
+                return -EINVAL;
+        if (kp->clipcount) {
+                struct v4l2_clip32 *uclips = compat_ptr(up->clips);
+                struct v4l2_clip *kclips;
+                int n = kp->clipcount;
+
+                kclips = compat_alloc_user_space(n * sizeof(struct v4l2_clip));
+                kp->clips = kclips;
+                while (--n >= 0) {
+                        copy_from_user(&kclips->c, &uclips->c, sizeof(uclips->c));
+                        kclips->next = n ? kclips + 1 : 0;
+                        uclips += 1;
+                        kclips += 1;
+                }
+        } else
+                kp->clips = 0;
+        return 0;
+}
+
+static int put_v4l2_window32(struct v4l2_window *kp, struct v4l2_window32 __user *up)
+{
+        if (copy_to_user(&up->w, &kp->w, sizeof(up->w)))
+                return -EFAULT;
+        __put_user(kp->field, &up->field);
+        __put_user(kp->chromakey, &up->chromakey);
+        __put_user(kp->clipcount, &up->clipcount);
+        return 0;
+}
+
+static inline int get_v4l2_pix_format(struct v4l2_pix_format *kp, struct v4l2_pix_format __user *up)
+{
+        return copy_from_user(kp, up, sizeof(struct v4l2_pix_format));
+}
+
+static inline int put_v4l2_pix_format(struct v4l2_pix_format *kp, struct v4l2_pix_format __user *up)
+{
+        return copy_to_user(up, kp, sizeof(struct v4l2_pix_format));
+}
+
+static inline int get_v4l2_vbi_format(struct v4l2_vbi_format *kp, struct v4l2_vbi_format __user *up)
+{
+        return copy_from_user(kp, up, sizeof(struct v4l2_vbi_format));
+}
+
+static inline int put_v4l2_vbi_format(struct v4l2_vbi_format *kp, struct v4l2_vbi_format __user *up)
+{
+        return copy_to_user(up, kp, sizeof(struct v4l2_vbi_format));
+}
+
+struct v4l2_format32
+{
+        enum v4l2_buf_type type;
+        union
+        {
+                struct v4l2_pix_format  pix;  // V4L2_BUF_TYPE_VIDEO_CAPTURE
+                struct v4l2_window32    win;  // V4L2_BUF_TYPE_VIDEO_OVERLAY
+                struct v4l2_vbi_format  vbi;  // V4L2_BUF_TYPE_VBI_CAPTURE
+                __u8    raw_data[200];        // user-defined
+        } fmt;
+};
+
+static int get_v4l2_format32(struct v4l2_format *kp, struct v4l2_format32 __user *up)
+{
+        if(get_user(kp->type, &up->type))
+                return -EFAULT;
+        switch (kp->type) {
+        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+                return get_v4l2_pix_format(&kp->fmt.pix, &up->fmt.pix);
+        case V4L2_BUF_TYPE_VIDEO_OVERLAY:
+                return get_v4l2_window32(&kp->fmt.win, &up->fmt.win);
+        case V4L2_BUF_TYPE_VBI_CAPTURE:
+                return get_v4l2_vbi_format(&kp->fmt.vbi, &up->fmt.vbi);
+        default:
+                printk("compat_ioctl : unexpected VIDIOC_FMT type %d\n",
+                                                                kp->type);
+                return -ENXIO;
+        }
+}
+
+static int put_v4l2_format32(struct v4l2_format *kp, struct v4l2_format32 __user *up)
+{
+        if(put_user(kp->type, &up->type))
+                return -EFAULT;
+        switch (kp->type) {
+        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+                return put_v4l2_pix_format(&kp->fmt.pix, &up->fmt.pix);
+        case V4L2_BUF_TYPE_VIDEO_OVERLAY:
+                return put_v4l2_window32(&kp->fmt.win, &up->fmt.win);
+        case V4L2_BUF_TYPE_VBI_CAPTURE:
+                return put_v4l2_vbi_format(&kp->fmt.vbi, &up->fmt.vbi);
+        default:
+                return -ENXIO;
+        }
+}
+
+struct v4l2_standard32
+{
+        __u32                index;
+        __u32                id[2]; /* __u64 would get the alignment wrong */
+        __u8                 name[24];
+        struct v4l2_fract    frameperiod; /* Frames, not fields */
+        __u32                framelines;
+        __u32                reserved[4];
+};
+
+static int get_v4l2_standard32(struct v4l2_standard *kp, struct v4l2_standard32 __user *up)
+{
+        /* other fields are not set by the user, nor used by the driver */
+        return get_user(kp->index, &up->index);
+}
+
+static int put_v4l2_standard32(struct v4l2_standard *kp, struct v4l2_standard32 __user *up)
+{
+        if(put_user(kp->index, &up->index))
+                return -EFAULT;
+        __copy_to_user(up->id, &kp->id, sizeof(__u64));
+        __copy_to_user(up->name, kp->name, 24);
+        __put_user(kp->frameperiod, &up->frameperiod);
+        __put_user(kp->framelines, &up->framelines);
+        __copy_to_user(up->reserved, kp->reserved, 4 * sizeof(__u32));
+        return 0;
+}
+
+struct v4l2_buffer32
+{
+        __u32                   index;
+        enum v4l2_buf_type      type;
+        __u32                   bytesused;
+        __u32                   flags;
+        enum v4l2_field         field;
+        struct compat_timeval   timestamp;
+        struct v4l2_timecode    timecode;
+        __u32                   sequence;
+
+        /* memory location */
+        enum v4l2_memory        memory;
+        union {
+                __u32           offset;
+                compat_long_t   userptr;
+        } m;
+        __u32                   length;
+        __u32                   input;
+        __u32                   reserved;
+};
+
+static int get_v4l2_buffer32(struct v4l2_buffer *kp, struct v4l2_buffer32 __user *up)
+{
+
+        if (get_user(kp->index, &up->index))
+                return -EFAULT;
+        __get_user(kp->type, &up->type);
+        __get_user(kp->flags, &up->flags);
+        __get_user(kp->memory, &up->memory);
+        __get_user(kp->input, &up->input);
+        switch(kp->memory) {
+        case V4L2_MEMORY_MMAP:
+                break;
+        case V4L2_MEMORY_USERPTR:
+                {
+                unsigned long tmp = (unsigned long)compat_ptr(up->m.userptr);
+
+                __get_user(kp->length, &up->length);
+                __get_user(kp->m.userptr, &tmp);
+                }
+                break;
+        case V4L2_MEMORY_OVERLAY:
+                __get_user(kp->m.offset, &up->m.offset);
+                break;
+        }
+        return 0;
+}
+
+static int put_v4l2_buffer32(struct v4l2_buffer *kp, struct v4l2_buffer32 __user *up)
+{
+        if (put_user(kp->index, &up->index))
+                return -EFAULT;
+        __put_user(kp->type, &up->type);
+        __put_user(kp->flags, &up->flags);
+        __put_user(kp->memory, &up->memory);
+        __put_user(kp->input, &up->input);
+        switch(kp->memory) {
+        case V4L2_MEMORY_MMAP:
+                __put_user(kp->length, &up->length);
+                __put_user(kp->m.offset, &up->m.offset);
+                break;
+        case V4L2_MEMORY_USERPTR:
+                __put_user(kp->length, &up->length);
+                __put_user(kp->m.userptr, &up->m.userptr);
+                break;
+        case V4L2_MEMORY_OVERLAY:
+                __put_user(kp->m.offset, &up->m.offset);
+                break;
+        }
+        __put_user(kp->bytesused, &up->bytesused);
+        __put_user(kp->field, &up->field);
+        __put_user(kp->timestamp.tv_sec, &up->timestamp.tv_sec);
+        __put_user(kp->timestamp.tv_usec, &up->timestamp.tv_usec);
+        __copy_to_user(&up->timecode, &kp->timecode, sizeof(struct v4l2_timecode));
+        __put_user(kp->sequence, &up->sequence);
+        __put_user(kp->reserved, &up->reserved);
+        return 0;
+}
+
+struct v4l2_framebuffer32
+{
+        __u32                   capability;
+        __u32                   flags;
+        compat_caddr_t          base;
+        struct v4l2_pix_format  fmt;
+};
+
+static int get_v4l2_framebuffer32(struct v4l2_framebuffer *kp, struct v4l2_framebuffer32 __user *up)
+{
+        u32 tmp;
+
+        if (get_user(tmp, &up->base))
+                return -EFAULT;
+        kp->base = compat_ptr(tmp);
+        __get_user(kp->capability, &up->capability);
+        __get_user(kp->flags, &up->flags);
+        get_v4l2_pix_format(&kp->fmt, &up->fmt);
+        return 0;
+}
+
+static int put_v4l2_framebuffer32(struct v4l2_framebuffer *kp, struct v4l2_framebuffer32 __user *up)
+{
+        u32 tmp = (u32)((unsigned long)kp->base);
+
+        if(put_user(tmp, &up->base))
+                return -EFAULT;
+        __put_user(kp->capability, &up->capability);
+        __put_user(kp->flags, &up->flags);
+        put_v4l2_pix_format(&kp->fmt, &up->fmt);
+        return 0;
+}
+
+struct v4l2_input32     /* identical layout, but different size */
+{
+        __u32        index;             /*  Which input */
+        __u8         name[32];          /*  Label */
+        __u32        type;              /*  Type of input */
+        __u32        audioset;          /*  Associated audios (bitfield) */
+        __u32        tuner;             /*  Associated tuner */
+        __u32        std[2];            /* __u64 would get the padding wrong */
+        __u32        status;
+        __u32        reserved[4];
+};
+
+#define VIDIOCGTUNER32          _IOWR('v',4, struct video_tuner32)
+#define VIDIOCSTUNER32          _IOW('v',5, struct video_tuner32)
+#define VIDIOCGWIN32            _IOR('v',9, struct video_window32)
+#define VIDIOCSWIN32            _IOW('v',10, struct video_window32)
+#define VIDIOCGFBUF32           _IOR('v',11, struct video_buffer32)
+#define VIDIOCSFBUF32           _IOW('v',12, struct video_buffer32)
+#define VIDIOCGFREQ32           _IOR('v',14, u32)
+#define VIDIOCSFREQ32           _IOW('v',15, u32)
+
+#define VIDIOC_G_FMT32          _IOWR ('V',  4, struct v4l2_format32)
+#define VIDIOC_S_FMT32          _IOWR ('V',  5, struct v4l2_format32)
+#define VIDIOC_QUERYBUF32       _IOWR ('V',  9, struct v4l2_buffer32)
+#define VIDIOC_G_FBUF32         _IOR  ('V', 10, struct v4l2_framebuffer32)
+#define VIDIOC_S_FBUF32         _IOW  ('V', 11, struct v4l2_framebuffer32)
+/* VIDIOC_OVERLAY is now _IOW, but was _IOWR */
+#define VIDIOC_OVERLAY32        _IOWR ('V', 14, compat_int_t)
+#define VIDIOC_QBUF32           _IOWR ('V', 15, struct v4l2_buffer32)
+#define VIDIOC_DQBUF32          _IOWR ('V', 17, struct v4l2_buffer32)
+#define VIDIOC_STREAMON32       _IOW  ('V', 18, compat_int_t)
+#define VIDIOC_STREAMOFF32      _IOW  ('V', 19, compat_int_t)
+#define VIDIOC_ENUMSTD32        _IOWR ('V', 25, struct v4l2_standard32)
+#define VIDIOC_ENUMINPUT32      _IOWR ('V', 26, struct v4l2_input32)
+/* VIDIOC_S_CTRL is now _IOWR, but was _IOW */
+#define VIDIOC_S_CTRL32         _IOW  ('V', 28, struct v4l2_control)
+#define VIDIOC_G_INPUT32        _IOR  ('V', 38, compat_int_t)
+#define VIDIOC_S_INPUT32        _IOWR ('V', 39, compat_int_t)
+#define VIDIOC_TRY_FMT32        _IOWR ('V', 64, struct v4l2_format32)
+
+enum {
+        MaxClips = (~0U-sizeof(struct video_window))/sizeof(struct video_clip)
+};
+
+static int do_set_window(struct file *file, unsigned int cmd, unsigned long arg)
+{
+        struct video_window32 __user *up = compat_ptr(arg);
+        struct video_window __user *vw;
+        struct video_clip __user *p;
+        int nclips;
+        u32 n;
+
+        if (get_user(nclips, &up->clipcount))
+                return -EFAULT;
+
+        /* Peculiar interface... */
+        if (nclips < 0)
+                nclips = VIDEO_CLIPMAP_SIZE;
+
+        if (nclips > MaxClips)
+                return -ENOMEM;
+
+        vw = compat_alloc_user_space(sizeof(struct video_window) +
+                                    nclips * sizeof(struct video_clip));
+
+        p = nclips ? (struct video_clip __user *)(vw + 1) : NULL;
+
+        if (get_user(n, &up->x) || put_user(n, &vw->x) ||
+            get_user(n, &up->y) || put_user(n, &vw->y) ||
+            get_user(n, &up->width) || put_user(n, &vw->width) ||
+            get_user(n, &up->height) || put_user(n, &vw->height) ||
+            get_user(n, &up->chromakey) || put_user(n, &vw->chromakey) ||
+            get_user(n, &up->flags) || put_user(n, &vw->flags) ||
+            get_user(n, &up->clipcount) || put_user(n, &vw->clipcount) ||
+            get_user(n, &up->clips) || put_user(p, &vw->clips))
+                return -EFAULT;
+
+        if (nclips) {
+                struct video_clip32 __user *u = compat_ptr(n);
+                int i;
+                if (!u)
+                        return -EINVAL;
+                for (i = 0; i < nclips; i++, u++, p++) {
+                        s32 v;
+                        if (get_user(v, &u->x) ||
+                            put_user(v, &p->x) ||
+                            get_user(v, &u->y) ||
+                            put_user(v, &p->y) ||
+                            get_user(v, &u->width) ||
+                            put_user(v, &p->width) ||
+                            get_user(v, &u->height) ||
+                            put_user(v, &p->height) ||
+                            put_user(NULL, &p->next))
+                                return -EFAULT;
+                }
+        }
+
+        return native_ioctl(file, VIDIOCSWIN, (unsigned long)vw);
+}
+
+static int do_video_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+        union {
+                struct video_tuner vt;
+                struct video_buffer vb;
+                struct video_window vw;
+                struct v4l2_format v2f;
+                struct v4l2_buffer v2b;
+                struct v4l2_framebuffer v2fb;
+                struct v4l2_standard v2s;
+                unsigned long vx;
+        } karg;
+        void __user *up = compat_ptr(arg);
+        int compatible_arg = 1;
+        int err = 0;
+
+        /* First, convert the command. */
+        switch(cmd) {
+        case VIDIOCGTUNER32: cmd = VIDIOCGTUNER; break;
+        case VIDIOCSTUNER32: cmd = VIDIOCSTUNER; break;
+        case VIDIOCGWIN32: cmd = VIDIOCGWIN; break;
+        case VIDIOCGFBUF32: cmd = VIDIOCGFBUF; break;
+        case VIDIOCSFBUF32: cmd = VIDIOCSFBUF; break;
+        case VIDIOCGFREQ32: cmd = VIDIOCGFREQ; break;
+        case VIDIOCSFREQ32: cmd = VIDIOCSFREQ; break;
+        case VIDIOC_G_FMT32: cmd = VIDIOC_G_FMT; break;
+        case VIDIOC_S_FMT32: cmd = VIDIOC_S_FMT; break;
+        case VIDIOC_QUERYBUF32: cmd = VIDIOC_QUERYBUF; break;
+        case VIDIOC_QBUF32: cmd = VIDIOC_QBUF; break;
+        case VIDIOC_DQBUF32: cmd = VIDIOC_DQBUF; break;
+        case VIDIOC_STREAMON32: cmd = VIDIOC_STREAMON; break;
+        case VIDIOC_STREAMOFF32: cmd = VIDIOC_STREAMOFF; break;
+        case VIDIOC_G_FBUF32: cmd = VIDIOC_G_FBUF; break;
+        case VIDIOC_S_FBUF32: cmd = VIDIOC_S_FBUF; break;
+        case VIDIOC_OVERLAY32: cmd = VIDIOC_OVERLAY; break;
+        case VIDIOC_ENUMSTD32: cmd = VIDIOC_ENUMSTD; break;
+        case VIDIOC_ENUMINPUT32: cmd = VIDIOC_ENUMINPUT; break;
+        case VIDIOC_S_CTRL32: cmd = VIDIOC_S_CTRL; break;
+        case VIDIOC_G_INPUT32: cmd = VIDIOC_G_INPUT; break;
+        case VIDIOC_S_INPUT32: cmd = VIDIOC_S_INPUT; break;
+        case VIDIOC_TRY_FMT32: cmd = VIDIOC_TRY_FMT; break;
+        };
+
+        switch(cmd) {
+        case VIDIOCSTUNER:
+        case VIDIOCGTUNER:
+                err = get_video_tuner32(&karg.vt, up);
+                compatible_arg = 0;
+
+                break;
+
+        case VIDIOCSFBUF:
+                err = get_video_buffer32(&karg.vb, up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOCSFREQ:
+        case VIDIOC_S_INPUT:
+        case VIDIOC_OVERLAY:
+        case VIDIOC_STREAMON:
+        case VIDIOC_STREAMOFF:
+                err = get_user(karg.vx, (u32 __user *)up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOC_S_FBUF:
+                err = get_v4l2_framebuffer32(&karg.v2fb, up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOC_G_FMT:
+        case VIDIOC_S_FMT:
+        case VIDIOC_TRY_FMT:
+                err = get_v4l2_format32(&karg.v2f, up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOC_QUERYBUF:
+        case VIDIOC_QBUF:
+        case VIDIOC_DQBUF:
+                err = get_v4l2_buffer32(&karg.v2b, up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOC_ENUMSTD:
+                err = get_v4l2_standard32(&karg.v2s, up);
+                compatible_arg = 0;
+                break;
+
+        case VIDIOCGWIN:
+        case VIDIOCGFBUF:
+        case VIDIOCGFREQ:
+        case VIDIOC_G_FBUF:
+        case VIDIOC_G_INPUT:
+                compatible_arg = 0;
+        };
+
+        if(err)
+                goto out;
+
+        if(compatible_arg)
+                err = native_ioctl(file, cmd, (unsigned long)up);
+        else {
+                mm_segment_t old_fs = get_fs();
+
+                set_fs(KERNEL_DS);
+                err = native_ioctl(file, cmd, (unsigned long)&karg);
+                set_fs(old_fs);
+        }
+        if(err == 0) {
+                switch(cmd) {
+                case VIDIOCGTUNER:
+                        err = put_video_tuner32(&karg.vt, up);
+                        break;
+
+                case VIDIOCGWIN:
+                        err = put_video_window32(&karg.vw, up);
+                        break;
+
+                case VIDIOCGFBUF:
+                        err = put_video_buffer32(&karg.vb, up);
+                        break;
+
+                case VIDIOC_G_FBUF:
+                        err = put_v4l2_framebuffer32(&karg.v2fb, up);
+                        break;
+
+                case VIDIOC_G_FMT:
+                case VIDIOC_S_FMT:
+                case VIDIOC_TRY_FMT:
+                        err = put_v4l2_format32(&karg.v2f, up);
+                        break;
+
+                case VIDIOC_QUERYBUF:
+                case VIDIOC_QBUF:
+                case VIDIOC_DQBUF:
+                        err = put_v4l2_buffer32(&karg.v2b, up);
+                        break;
+
+                case VIDIOC_ENUMSTD:
+                        err = put_v4l2_standard32(&karg.v2s, up);
+                        break;
+
+                case VIDIOCGFREQ:
+                case VIDIOC_G_INPUT:
+                        err = put_user(((u32)karg.vx), (u32 __user *)up);
+                        break;
+                };
+        }
+out:
+        return err;
+}
+
+long v4l_compat_ioctl32(struct file *file, unsigned int cmd, unsigned long arg)
+{
+        int ret = -ENOIOCTLCMD;
+
+        if (!file->f_op->ioctl)
+                return ret;
+
+        switch (cmd) {
+        case VIDIOCSWIN32:
+                ret = do_set_window(file, cmd, arg);
+                break;
+        case VIDIOCGTUNER32:
+        case VIDIOCSTUNER32:
+        case VIDIOCGWIN32:
+        case VIDIOCGFBUF32:
+        case VIDIOCSFBUF32:
+        case VIDIOCGFREQ32:
+        case VIDIOCSFREQ32:
+        case VIDIOC_QUERYCAP:
+        case VIDIOC_ENUM_FMT:
+        case VIDIOC_G_FMT32:
+        case VIDIOC_S_FMT32:
+        case VIDIOC_REQBUFS:
+        case VIDIOC_QUERYBUF32:
+        case VIDIOC_G_FBUF32:
+        case VIDIOC_S_FBUF32:
+        case VIDIOC_OVERLAY32:
+        case VIDIOC_QBUF32:
+        case VIDIOC_DQBUF32:
+        case VIDIOC_STREAMON32:
+        case VIDIOC_STREAMOFF32:
+        case VIDIOC_G_PARM:
+        case VIDIOC_G_STD:
+        case VIDIOC_S_STD:
+        case VIDIOC_ENUMSTD32:
+        case VIDIOC_ENUMINPUT32:
+        case VIDIOC_G_CTRL:
+        case VIDIOC_S_CTRL32:
+        case VIDIOC_QUERYCTRL:
+        case VIDIOC_G_INPUT32:
+        case VIDIOC_S_INPUT32:
+        case VIDIOC_TRY_FMT32:
+                ret = do_video_ioctl(file, cmd, arg);
+                break;
+
+        /* Little v, the video4linux ioctls (conflict?) */
+        case VIDIOCGCAP:
+        case VIDIOCGCHAN:
+        case VIDIOCSCHAN:
+        case VIDIOCGPICT:
+        case VIDIOCSPICT:
+        case VIDIOCCAPTURE:
+        case VIDIOCKEY:
+        case VIDIOCGAUDIO:
+        case VIDIOCSAUDIO:
+        case VIDIOCSYNC:
+        case VIDIOCMCAPTURE:
+        case VIDIOCGMBUF:
+        case VIDIOCGUNIT:
+        case VIDIOCGCAPTURE:
+        case VIDIOCSCAPTURE:
+
+        /* BTTV specific... */
+        case _IOW('v',  BASE_VIDIOCPRIVATE+0, char [256]):
+        case _IOR('v',  BASE_VIDIOCPRIVATE+1, char [256]):
+        case _IOR('v' , BASE_VIDIOCPRIVATE+2, unsigned int):
+        case _IOW('v' , BASE_VIDIOCPRIVATE+3, char [16]): /* struct bttv_pll_info */
+        case _IOR('v' , BASE_VIDIOCPRIVATE+4, int):
+        case _IOR('v' , BASE_VIDIOCPRIVATE+5, int):
+        case _IOR('v' , BASE_VIDIOCPRIVATE+6, int):
+        case _IOR('v' , BASE_VIDIOCPRIVATE+7, int):
+                ret = native_ioctl(file, cmd, (unsigned long)compat_ptr(arg));
+                break;
+        }
+        return ret;
+}
+#else
+long v4l_compat_ioctl32(struct file *file, unsigned int cmd, unsigned long arg)
+{
+        return -ENOIOCTLCMD;
+}
+#endif
+EXPORT_SYMBOL_GPL(v4l_compat_ioctl32);
+
+MODULE_LICENSE("GPL");
diff --git a/drivers/media/video/cpia.c b/drivers/media/video/cpia.c
index b7ec9bf45085..9f59541155d9 100644
--- a/drivers/media/video/cpia.c
+++ b/drivers/media/video/cpia.c
@@ -3807,6 +3807,7 @@ static struct file_operations cpia_fops = {
         .read           = cpia_read,
         .mmap           = cpia_mmap,
         .ioctl          = cpia_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/video/cs53l32a.c b/drivers/media/video/cs53l32a.c
index 643ead1a87ee..b421068f7ea3 100644
--- a/drivers/media/video/cs53l32a.c
+++ b/drivers/media/video/cs53l32a.c
@@ -27,7 +27,7 @@
 #include <linux/i2c.h>
 #include <linux/i2c-id.h>
 #include <linux/videodev.h>
-#include <media/audiochip.h>
+#include <media/v4l2-common.h>
 
 MODULE_DESCRIPTION("i2c device driver for cs53l32a Audio ADC");
 MODULE_AUTHOR("Martin Vaughan");
@@ -39,21 +39,6 @@ module_param(debug, bool, 0644);
 
 MODULE_PARM_DESC(debug, "Debugging messages\n\t\t\t0=Off (default), 1=On");
 
-#define cs53l32a_dbg(fmt, arg...) \
-        do { \
-                if (debug) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                               client->driver->driver.name, \
-                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-#define cs53l32a_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-                i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define cs53l32a_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-                i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
 static unsigned short normal_i2c[] = { 0x22 >> 1, I2C_CLIENT_END };
 
 
@@ -74,50 +59,59 @@ static int cs53l32a_read(struct i2c_client *client, u8 reg)
 static int cs53l32a_command(struct i2c_client *client, unsigned int cmd,
                             void *arg)
 {
-        int *input = arg;
+        struct v4l2_audio *input = arg;
+        struct v4l2_control *ctrl = arg;
 
         switch (cmd) {
-        case AUDC_SET_INPUT:
-                switch (*input) {
-                case AUDIO_TUNER:
-                        cs53l32a_write(client, 0x01, 0x01);
-                        break;
-                case AUDIO_EXTERN:
-                        cs53l32a_write(client, 0x01, 0x21);
-                        break;
-                case AUDIO_MUTE:
-                        cs53l32a_write(client, 0x03, 0xF0);
-                        break;
-                case AUDIO_UNMUTE:
-                        cs53l32a_write(client, 0x03, 0x30);
-                        break;
-                default:
-                        cs53l32a_err("Invalid input %d.\n", *input);
+        case VIDIOC_S_AUDIO:
+                /* There are 2 physical inputs, but the second input can be
+                   placed in two modes, the first mode bypasses the PGA (gain),
+                   the second goes through the PGA. Hence there are three
+                   possible inputs to choose from. */
+                if (input->index > 2) {
+                        v4l_err(client, "Invalid input %d.\n", input->index);
                         return -EINVAL;
                 }
+                cs53l32a_write(client, 0x01, 0x01 + (input->index << 4));
+                break;
+
+        case VIDIOC_G_AUDIO:
+                memset(input, 0, sizeof(*input));
+                input->index = (cs53l32a_read(client, 0x01) >> 4) & 3;
+                break;
+
+        case VIDIOC_G_CTRL:
+                if (ctrl->id == V4L2_CID_AUDIO_MUTE) {
+                        ctrl->value = (cs53l32a_read(client, 0x03) & 0xc0) != 0;
+                        break;
+                }
+                if (ctrl->id != V4L2_CID_AUDIO_VOLUME)
+                        return -EINVAL;
+                ctrl->value = (s8)cs53l32a_read(client, 0x04);
                 break;
 
         case VIDIOC_S_CTRL:
-                {
-                        struct v4l2_control *ctrl = arg;
-
-                        if (ctrl->id != V4L2_CID_AUDIO_VOLUME)
-                                return -EINVAL;
-                        if (ctrl->value > 12 || ctrl->value < -90)
-                                return -EINVAL;
-                        cs53l32a_write(client, 0x04, (u8) ctrl->value);
-                        cs53l32a_write(client, 0x05, (u8) ctrl->value);
+                if (ctrl->id == V4L2_CID_AUDIO_MUTE) {
+                        cs53l32a_write(client, 0x03, ctrl->value ? 0xf0 : 0x30);
                         break;
                 }
+                if (ctrl->id != V4L2_CID_AUDIO_VOLUME)
+                        return -EINVAL;
+                if (ctrl->value > 12 || ctrl->value < -96)
+                        return -EINVAL;
+                cs53l32a_write(client, 0x04, (u8) ctrl->value);
+                cs53l32a_write(client, 0x05, (u8) ctrl->value);
+                break;
 
         case VIDIOC_LOG_STATUS:
                 {
                         u8 v = cs53l32a_read(client, 0x01);
                         u8 m = cs53l32a_read(client, 0x03);
+                        s8 vol = cs53l32a_read(client, 0x04);
 
-                        cs53l32a_info("Input: %s%s\n",
-                                      v == 0x21 ? "external line in" : "tuner",
+                        v4l_info(client, "Input:  %d%s\n", (v >> 4) & 3,
                                       (m & 0xC0) ? " (muted)" : "");
+                        v4l_info(client, "Volume: %d dB\n", vol);
                         break;
                 }
 
@@ -157,12 +151,12 @@ static int cs53l32a_attach(struct i2c_adapter *adapter, int address, int kind)
         client->driver = &i2c_driver;
         snprintf(client->name, sizeof(client->name) - 1, "cs53l32a");
 
-        cs53l32a_info("chip found @ 0x%x (%s)\n", address << 1, adapter->name);
+        v4l_info(client, "chip found @ 0x%x (%s)\n", address << 1, adapter->name);
 
         for (i = 1; i <= 7; i++) {
                 u8 v = cs53l32a_read(client, i);
 
-                cs53l32a_dbg("Read Reg %d %02x\n", i, v);
+                v4l_dbg(1, client, "Read Reg %d %02x\n", i, v);
         }
 
         /* Set cs53l32a internal register for Adaptec 2010/2410 setup */
@@ -180,7 +174,7 @@ static int cs53l32a_attach(struct i2c_adapter *adapter, int address, int kind)
         for (i = 1; i <= 7; i++) {
                 u8 v = cs53l32a_read(client, i);
 
-                cs53l32a_dbg("Read Reg %d %02x\n", i, v);
+                v4l_dbg(1, client, "Read Reg %d %02x\n", i, v);
         }
 
         i2c_attach_client(client);
@@ -190,11 +184,7 @@ static int cs53l32a_attach(struct i2c_adapter *adapter, int address, int kind)
 
 static int cs53l32a_probe(struct i2c_adapter *adapter)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adapter->class & I2C_CLASS_TV_ANALOG)
-#else
-        if (adapter->id == I2C_HW_B_BT848)
-#endif
                 return i2c_probe(adapter, &addr_data, cs53l32a_attach);
         return 0;
 }
diff --git a/drivers/media/video/cx25840/cx25840-audio.c b/drivers/media/video/cx25840/cx25840-audio.c
index 740908f8027d..cb9a7981e408 100644
--- a/drivers/media/video/cx25840/cx25840-audio.c
+++ b/drivers/media/video/cx25840/cx25840-audio.c
@@ -23,11 +23,13 @@
 
 #include "cx25840.h"
 
-inline static int set_audclk_freq(struct i2c_client *client,
-                                 enum v4l2_audio_clock_freq freq)
+static int set_audclk_freq(struct i2c_client *client, u32 freq)
 {
         struct cx25840_state *state = i2c_get_clientdata(client);
 
+        if (freq != 32000 && freq != 44100 && freq != 48000)
+                return -EINVAL;
+
         /* assert soft reset */
         cx25840_and_or(client, 0x810, ~0x1, 0x01);
 
@@ -35,10 +37,9 @@ inline static int set_audclk_freq(struct i2c_client *client,
         /* SA_MCLK_SEL=1, SA_MCLK_DIV=0x10 */
         cx25840_write(client, 0x127, 0x50);
 
-        switch (state->audio_input) {
-        case AUDIO_TUNER:
+        if (state->aud_input != CX25840_AUDIO_SERIAL) {
                 switch (freq) {
-                case V4L2_AUDCLK_32_KHZ:
+                case 32000:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f040610);
 
@@ -51,7 +52,7 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write4(client, 0x90c, 0x7ff70108);
                         break;
 
-                case V4L2_AUDCLK_441_KHZ:
+                case 44100:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f040910);
 
@@ -64,7 +65,7 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write4(client, 0x90c, 0x596d0108);
                         break;
 
-                case V4L2_AUDCLK_48_KHZ:
+                case 48000:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f040a10);
 
@@ -77,14 +78,9 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write4(client, 0x90c, 0xaa4f0108);
                         break;
                 }
-                break;
-
-        case AUDIO_EXTERN_1:
-        case AUDIO_EXTERN_2:
-        case AUDIO_INTERN:
-        case AUDIO_RADIO:
+        } else {
                 switch (freq) {
-                case V4L2_AUDCLK_32_KHZ:
+                case 32000:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f04081e);
 
@@ -103,7 +99,7 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write(client, 0x127, 0x54);
                         break;
 
-                case V4L2_AUDCLK_441_KHZ:
+                case 44100:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f040918);
 
@@ -119,7 +115,7 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write4(client, 0x90c, 0x85730108);
                         break;
 
-                case V4L2_AUDCLK_48_KHZ:
+                case 48000:
                         /* VID_PLL and AUX_PLL */
                         cx25840_write4(client, 0x108, 0x0f040a18);
 
@@ -135,7 +131,6 @@ inline static int set_audclk_freq(struct i2c_client *client,
                         cx25840_write4(client, 0x90c, 0x55550108);
                         break;
                 }
-                break;
         }
 
         /* deassert soft reset */
@@ -146,51 +141,36 @@ inline static int set_audclk_freq(struct i2c_client *client,
         return 0;
 }
 
-static int set_input(struct i2c_client *client, int audio_input)
+void cx25840_audio_set_path(struct i2c_client *client)
 {
         struct cx25840_state *state = i2c_get_clientdata(client);
 
-        cx25840_dbg("set audio input (%d)\n", audio_input);
-
         /* stop microcontroller */
         cx25840_and_or(client, 0x803, ~0x10, 0);
 
         /* Mute everything to prevent the PFFT! */
         cx25840_write(client, 0x8d3, 0x1f);
 
-        switch (audio_input) {
-        case AUDIO_TUNER:
-                /* Set Path1 to Analog Demod Main Channel */
-                cx25840_write4(client, 0x8d0, 0x7038061f);
-
-                /* When the microcontroller detects the
-                 * audio format, it will unmute the lines */
-                cx25840_and_or(client, 0x803, ~0x10, 0x10);
-                break;
-
-        case AUDIO_EXTERN_1:
-        case AUDIO_EXTERN_2:
-        case AUDIO_INTERN:
-        case AUDIO_RADIO:
+        if (state->aud_input == CX25840_AUDIO_SERIAL) {
                 /* Set Path1 to Serial Audio Input */
                 cx25840_write4(client, 0x8d0, 0x12100101);
 
                 /* The microcontroller should not be started for the
                  * non-tuner inputs: autodetection is specific for
                  * TV audio. */
-                break;
+        } else {
+                /* Set Path1 to Analog Demod Main Channel */
+                cx25840_write4(client, 0x8d0, 0x7038061f);
 
-        default:
-                cx25840_dbg("Invalid audio input selection %d\n", audio_input);
-                return -EINVAL;
+                /* When the microcontroller detects the
+                 * audio format, it will unmute the lines */
+                cx25840_and_or(client, 0x803, ~0x10, 0x10);
         }
 
-        state->audio_input = audio_input;
-
-        return set_audclk_freq(client, state->audclk_freq);
+        set_audclk_freq(client, state->audclk_freq);
 }
 
-inline static int get_volume(struct i2c_client *client)
+static int get_volume(struct i2c_client *client)
 {
         /* Volume runs +18dB to -96dB in 1/2dB steps
          * change to fit the msp3400 -114dB to +12dB range */
@@ -201,7 +181,7 @@ inline static int get_volume(struct i2c_client *client)
         return vol << 9;
 }
 
-inline static void set_volume(struct i2c_client *client, int volume)
+static void set_volume(struct i2c_client *client, int volume)
 {
         /* First convert the volume to msp3400 values (0-127) */
         int vol = volume >> 9;
@@ -218,7 +198,7 @@ inline static void set_volume(struct i2c_client *client, int volume)
         cx25840_write(client, 0x8d4, 228 - (vol * 2));
 }
 
-inline static int get_bass(struct i2c_client *client)
+static int get_bass(struct i2c_client *client)
 {
         /* bass is 49 steps +12dB to -12dB */
 
@@ -228,13 +208,13 @@ inline static int get_bass(struct i2c_client *client)
         return bass;
 }
 
-inline static void set_bass(struct i2c_client *client, int bass)
+static void set_bass(struct i2c_client *client, int bass)
 {
         /* PATH1_EQ_BASS_VOL */
         cx25840_and_or(client, 0x8d9, ~0x3f, 48 - (bass * 48 / 0xffff));
 }
 
-inline static int get_treble(struct i2c_client *client)
+static int get_treble(struct i2c_client *client)
 {
         /* treble is 49 steps +12dB to -12dB */
 
@@ -244,13 +224,13 @@ inline static int get_treble(struct i2c_client *client)
         return treble;
 }
 
-inline static void set_treble(struct i2c_client *client, int treble)
+static void set_treble(struct i2c_client *client, int treble)
 {
         /* PATH1_EQ_TREBLE_VOL */
         cx25840_and_or(client, 0x8db, ~0x3f, 48 - (treble * 48 / 0xffff));
 }
 
-inline static int get_balance(struct i2c_client *client)
+static int get_balance(struct i2c_client *client)
 {
         /* balance is 7 bit, 0 to -96dB */
 
@@ -264,7 +244,7 @@ inline static int get_balance(struct i2c_client *client)
         return balance << 8;
 }
 
-inline static void set_balance(struct i2c_client *client, int balance)
+static void set_balance(struct i2c_client *client, int balance)
 {
         int bal = balance >> 8;
         if (bal > 0x80) {
@@ -280,17 +260,17 @@ inline static void set_balance(struct i2c_client *client, int balance)
         }
 }
 
-inline static int get_mute(struct i2c_client *client)
+static int get_mute(struct i2c_client *client)
 {
         /* check SRC1_MUTE_EN */
         return cx25840_read(client, 0x8d3) & 0x2 ? 1 : 0;
 }
 
-inline static void set_mute(struct i2c_client *client, int mute)
+static void set_mute(struct i2c_client *client, int mute)
 {
         struct cx25840_state *state = i2c_get_clientdata(client);
 
-        if (state->audio_input == AUDIO_TUNER) {
+        if (state->aud_input != CX25840_AUDIO_SERIAL) {
                 /* Must turn off microcontroller in order to mute sound.
                  * Not sure if this is the best method, but it does work.
                  * If the microcontroller is running, then it will undo any
@@ -314,10 +294,9 @@ int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg)
         struct v4l2_control *ctrl = arg;
 
         switch (cmd) {
-        case AUDC_SET_INPUT:
-                return set_input(client, *(int *)arg);
         case VIDIOC_INT_AUDIO_CLOCK_FREQ:
-                return set_audclk_freq(client, *(enum v4l2_audio_clock_freq *)arg);
+                return set_audclk_freq(client, *(u32 *)arg);
+
         case VIDIOC_G_CTRL:
                 switch (ctrl->id) {
                 case V4L2_CID_AUDIO_VOLUME:
@@ -339,6 +318,7 @@ int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg)
                         return -EINVAL;
                 }
                 break;
+
         case VIDIOC_S_CTRL:
                 switch (ctrl->id) {
                 case V4L2_CID_AUDIO_VOLUME:
@@ -360,6 +340,7 @@ int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg)
                         return -EINVAL;
                 }
                 break;
+
         default:
                 return -EINVAL;
         }
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index 3b09f46dddf6..d45237d508c4 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -43,11 +43,11 @@ MODULE_LICENSE("GPL");
 static unsigned short normal_i2c[] = { 0x88 >> 1, I2C_CLIENT_END };
 
 
-int cx25840_debug = 0;
+int debug = 0;
 
-module_param(cx25840_debug, bool, 0644);
+module_param(debug, bool, 0644);
 
-MODULE_PARM_DESC(cx25840_debug, "Debugging messages [0=Off (default) 1=On]");
+MODULE_PARM_DESC(debug, "Debugging messages [0=Off (default) 1=On]");
 
 I2C_CLIENT_INSMOD;
 
@@ -115,13 +115,13 @@ int cx25840_and_or(struct i2c_client *client, u16 addr, u8 and_mask,
 
 /* ----------------------------------------------------------------------- */
 
-static int set_input(struct i2c_client *, enum cx25840_input);
-static void input_change(struct i2c_client *);
+static int set_input(struct i2c_client *client, enum cx25840_video_input vid_input,
+                                                enum cx25840_audio_input aud_input);
 static void log_status(struct i2c_client *client);
 
 /* ----------------------------------------------------------------------- */
 
-static inline void init_dll1(struct i2c_client *client)
+static void init_dll1(struct i2c_client *client)
 {
         /* This is the Hauppauge sequence used to
          * initialize the Delay Lock Loop 1 (ADC DLL). */
@@ -135,7 +135,7 @@ static inline void init_dll1(struct i2c_client *client)
         cx25840_write(client, 0x15b, 0x10);
 }
 
-static inline void init_dll2(struct i2c_client *client)
+static void init_dll2(struct i2c_client *client)
 {
         /* This is the Hauppauge sequence used to
          * initialize the Delay Lock Loop 2 (ADC DLL). */
@@ -195,10 +195,8 @@ static void cx25840_initialize(struct i2c_client *client, int loadfw)
         /* AC97 shift */
         cx25840_write(client, 0x8cf, 0x0f);
 
-        /* (re)set video input */
-        set_input(client, state->input);
-        /* (re)set audio input */
-        cx25840_audio(client, AUDC_SET_INPUT, &state->audio_input);
+        /* (re)set input */
+        set_input(client, state->vid_input, state->aud_input);
 
         /* start microcontroller */
         cx25840_and_or(client, 0x803, ~0x10, 0x10);
@@ -223,7 +221,7 @@ static void input_change(struct i2c_client *client)
                 cx25840_write(client, 0x80b, 0x10);
         } else if (std & V4L2_STD_NTSC) {
                 /* NTSC */
-                if (state->cardtype == CARDTYPE_PVR150_WORKAROUND) {
+                if (state->pvr150_workaround) {
                         /* Certain Hauppauge PVR150 models have a hardware bug
                            that causes audio to drop out. For these models the
                            audio standard must be set explicitly.
@@ -259,72 +257,68 @@ static void input_change(struct i2c_client *client)
         }
 }
 
-static int set_input(struct i2c_client *client, enum cx25840_input input)
+static int set_input(struct i2c_client *client, enum cx25840_video_input vid_input,
+                                                enum cx25840_audio_input aud_input)
 {
         struct cx25840_state *state = i2c_get_clientdata(client);
+        u8 is_composite = (vid_input >= CX25840_COMPOSITE1 &&
+                           vid_input <= CX25840_COMPOSITE8);
+        u8 reg;
 
-        cx25840_dbg("decoder set input (%d)\n", input);
+        v4l_dbg(1, client, "decoder set video input %d, audio input %d\n",
+                        vid_input, aud_input);
 
-        switch (input) {
-        case CX25840_TUNER:
-                cx25840_dbg("now setting Tuner input\n");
-
-                if (state->cardtype == CARDTYPE_PVR150 ||
-                    state->cardtype == CARDTYPE_PVR150_WORKAROUND) {
-                        /* CH_SEL_ADC2=1 */
-                        cx25840_and_or(client, 0x102, ~0x2, 0x02);
-                }
-
-                /* Video Input Control */
-                if (state->cardtype == CARDTYPE_PG600) {
-                        cx25840_write(client, 0x103, 0x11);
-                } else {
-                        cx25840_write(client, 0x103, 0x46);
-                }
-
-                /* INPUT_MODE=0 */
-                cx25840_and_or(client, 0x401, ~0x6, 0x00);
-                break;
-
-        case CX25840_COMPOSITE0:
-        case CX25840_COMPOSITE1:
-                cx25840_dbg("now setting Composite input\n");
+        if (is_composite) {
+                reg = 0xf0 + (vid_input - CX25840_COMPOSITE1);
+        } else {
+                int luma = vid_input & 0xf0;
+                int chroma = vid_input & 0xf00;
 
-                /* Video Input Control */
-                if (state->cardtype == CARDTYPE_PG600) {
-                        cx25840_write(client, 0x103, 0x00);
-                } else {
-                        cx25840_write(client, 0x103, 0x02);
+                if ((vid_input & ~0xff0) ||
+                    luma < CX25840_SVIDEO_LUMA1 || luma > CX25840_SVIDEO_LUMA4 ||
+                    chroma < CX25840_SVIDEO_CHROMA4 || chroma > CX25840_SVIDEO_CHROMA8) {
+                        v4l_err(client, "0x%04x is not a valid video input!\n", vid_input);
+                        return -EINVAL;
                 }
-
-                /* INPUT_MODE=0 */
-                cx25840_and_or(client, 0x401, ~0x6, 0x00);
-                break;
-
-        case CX25840_SVIDEO0:
-        case CX25840_SVIDEO1:
-                cx25840_dbg("now setting S-Video input\n");
-
-                /* CH_SEL_ADC2=0 */
-                cx25840_and_or(client, 0x102, ~0x2, 0x00);
-
-                /* Video Input Control */
-                if (state->cardtype == CARDTYPE_PG600) {
-                        cx25840_write(client, 0x103, 0x02);
+                reg = 0xf0 + ((luma - CX25840_SVIDEO_LUMA1) >> 4);
+                if (chroma >= CX25840_SVIDEO_CHROMA7) {
+                        reg &= 0x3f;
+                        reg |= (chroma - CX25840_SVIDEO_CHROMA7) >> 2;
                 } else {
-                        cx25840_write(client, 0x103, 0x10);
+                        reg &= 0xcf;
+                        reg |= (chroma - CX25840_SVIDEO_CHROMA4) >> 4;
                 }
+        }
 
-                /* INPUT_MODE=1 */
-                cx25840_and_or(client, 0x401, ~0x6, 0x02);
+        switch (aud_input) {
+        case CX25840_AUDIO_SERIAL:
+                /* do nothing, use serial audio input */
                 break;
+        case CX25840_AUDIO4: reg &= ~0x30; break;
+        case CX25840_AUDIO5: reg &= ~0x30; reg |= 0x10; break;
+        case CX25840_AUDIO6: reg &= ~0x30; reg |= 0x20; break;
+        case CX25840_AUDIO7: reg &= ~0xc0; break;
+        case CX25840_AUDIO8: reg &= ~0xc0; reg |= 0x40; break;
 
         default:
-                cx25840_err("%d is not a valid input!\n", input);
+                v4l_err(client, "0x%04x is not a valid audio input!\n", aud_input);
                 return -EINVAL;
         }
 
-        state->input = input;
+        cx25840_write(client, 0x103, reg);
+        /* Set INPUT_MODE to Composite (0) or S-Video (1) */
+        cx25840_and_or(client, 0x401, ~0x6, is_composite ? 0 : 0x02);
+        /* Set CH_SEL_ADC2 to 1 if input comes from CH3 */
+        cx25840_and_or(client, 0x102, ~0x2, (reg & 0x80) == 0 ? 2 : 0);
+        /* Set DUAL_MODE_ADC2 to 1 if input comes from both CH2 and CH3 */
+        if ((reg & 0xc0) != 0xc0 && (reg & 0x30) != 0x30)
+                cx25840_and_or(client, 0x102, ~0x4, 4);
+        else
+                cx25840_and_or(client, 0x102, ~0x4, 0);
+
+        state->vid_input = vid_input;
+        state->aud_input = aud_input;
+        cx25840_audio_set_path(client);
         input_change(client);
         return 0;
 }
@@ -395,23 +389,14 @@ static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
         struct cx25840_state *state = i2c_get_clientdata(client);
 
         switch (ctrl->id) {
-        case CX25840_CID_CARDTYPE:
-                switch (ctrl->value) {
-                case CARDTYPE_PVR150:
-                case CARDTYPE_PVR150_WORKAROUND:
-                case CARDTYPE_PG600:
-                        state->cardtype = ctrl->value;
-                        break;
-                default:
-                        return -ERANGE;
-                }
-
-                set_input(client, state->input);
+        case CX25840_CID_ENABLE_PVR150_WORKAROUND:
+                state->pvr150_workaround = ctrl->value;
+                set_input(client, state->vid_input, state->aud_input);
                 break;
 
         case V4L2_CID_BRIGHTNESS:
                 if (ctrl->value < 0 || ctrl->value > 255) {
-                        cx25840_err("invalid brightness setting %d\n",
+                        v4l_err(client, "invalid brightness setting %d\n",
                                     ctrl->value);
                         return -ERANGE;
                 }
@@ -421,7 +406,7 @@ static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
 
         case V4L2_CID_CONTRAST:
                 if (ctrl->value < 0 || ctrl->value > 127) {
-                        cx25840_err("invalid contrast setting %d\n",
+                        v4l_err(client, "invalid contrast setting %d\n",
                                     ctrl->value);
                         return -ERANGE;
                 }
@@ -431,7 +416,7 @@ static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
 
         case V4L2_CID_SATURATION:
                 if (ctrl->value < 0 || ctrl->value > 127) {
-                        cx25840_err("invalid saturation setting %d\n",
+                        v4l_err(client, "invalid saturation setting %d\n",
                                     ctrl->value);
                         return -ERANGE;
                 }
@@ -442,7 +427,7 @@ static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
 
         case V4L2_CID_HUE:
                 if (ctrl->value < -127 || ctrl->value > 127) {
-                        cx25840_err("invalid hue setting %d\n", ctrl->value);
+                        v4l_err(client, "invalid hue setting %d\n", ctrl->value);
                         return -ERANGE;
                 }
 
@@ -455,6 +440,9 @@ static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
         case V4L2_CID_AUDIO_BALANCE:
         case V4L2_CID_AUDIO_MUTE:
                 return cx25840_audio(client, VIDIOC_S_CTRL, ctrl);
+
+        default:
+                return -EINVAL;
         }
 
         return 0;
@@ -465,11 +453,11 @@ static int get_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
         struct cx25840_state *state = i2c_get_clientdata(client);
 
         switch (ctrl->id) {
-        case CX25840_CID_CARDTYPE:
-                ctrl->value = state->cardtype;
+        case CX25840_CID_ENABLE_PVR150_WORKAROUND:
+                ctrl->value = state->pvr150_workaround;
                 break;
         case V4L2_CID_BRIGHTNESS:
-                ctrl->value = cx25840_read(client, 0x414) + 128;
+                ctrl->value = (s8)cx25840_read(client, 0x414) + 128;
                 break;
         case V4L2_CID_CONTRAST:
                 ctrl->value = cx25840_read(client, 0x415) >> 1;
@@ -478,7 +466,7 @@ static int get_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
                 ctrl->value = cx25840_read(client, 0x420) >> 1;
                 break;
         case V4L2_CID_HUE:
-                ctrl->value = cx25840_read(client, 0x422);
+                ctrl->value = (s8)cx25840_read(client, 0x422);
                 break;
         case V4L2_CID_AUDIO_VOLUME:
         case V4L2_CID_AUDIO_BASS:
@@ -527,7 +515,7 @@ static int set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
 
                 if ((pix->width * 16 < Hsrc) || (Hsrc < pix->width) ||
                     (Vlines * 8 < Vsrc) || (Vsrc < Vlines)) {
-                        cx25840_err("%dx%d is not a valid size!\n",
+                        v4l_err(client, "%dx%d is not a valid size!\n",
                                     pix->width, pix->height);
                         return -ERANGE;
                 }
@@ -545,7 +533,7 @@ static int set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
                 else
                         filter = 3;
 
-                cx25840_dbg("decoder set size %dx%d -> scale  %ux%u\n",
+                v4l_dbg(1, client, "decoder set size %dx%d -> scale  %ux%u\n",
                             pix->width, pix->height, HSC, VSC);
 
                 /* HSCALE=HSC */
@@ -574,17 +562,98 @@ static int set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
 
 /* ----------------------------------------------------------------------- */
 
+static struct v4l2_queryctrl cx25840_qctrl[] = {
+        {
+                .id            = V4L2_CID_BRIGHTNESS,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Brightness",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 128,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_CONTRAST,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Contrast",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 64,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_SATURATION,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Saturation",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 64,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_HUE,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Hue",
+                .minimum       = -128,
+                .maximum       = 127,
+                .step          = 1,
+                .default_value = 0,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_AUDIO_VOLUME,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Volume",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 58880,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_AUDIO_BALANCE,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Balance",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_AUDIO_MUTE,
+                .type          = V4L2_CTRL_TYPE_BOOLEAN,
+                .name          = "Mute",
+                .minimum       = 0,
+                .maximum       = 1,
+                .step          = 1,
+                .default_value = 1,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_AUDIO_BASS,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Bass",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+        }, {
+                .id            = V4L2_CID_AUDIO_TREBLE,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Treble",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+        },
+};
+
+/* ----------------------------------------------------------------------- */
+
 static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                            void *arg)
 {
         struct cx25840_state *state = i2c_get_clientdata(client);
         struct v4l2_tuner *vt = arg;
-        int result = 0;
 
         switch (cmd) {
-        case 0:
-                break;
-
 #ifdef CONFIG_VIDEO_ADV_DEBUG
         /* ioctls to allow direct access to the
          * cx25840 registers for testing */
@@ -615,18 +684,16 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                 return cx25840_vbi(client, cmd, arg);
 
         case VIDIOC_INT_AUDIO_CLOCK_FREQ:
-        case AUDC_SET_INPUT:
-                result = cx25840_audio(client, cmd, arg);
-                break;
+                return cx25840_audio(client, cmd, arg);
 
         case VIDIOC_STREAMON:
-                cx25840_dbg("enable output\n");
+                v4l_dbg(1, client, "enable output\n");
                 cx25840_write(client, 0x115, 0x8c);
                 cx25840_write(client, 0x116, 0x07);
                 break;
 
         case VIDIOC_STREAMOFF:
-                cx25840_dbg("disable output\n");
+                v4l_dbg(1, client, "disable output\n");
                 cx25840_write(client, 0x115, 0x00);
                 cx25840_write(client, 0x116, 0x00);
                 break;
@@ -636,28 +703,58 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                 break;
 
         case VIDIOC_G_CTRL:
-                result = get_v4lctrl(client, (struct v4l2_control *)arg);
-                break;
+                return get_v4lctrl(client, (struct v4l2_control *)arg);
 
         case VIDIOC_S_CTRL:
-                result = set_v4lctrl(client, (struct v4l2_control *)arg);
-                break;
+                return set_v4lctrl(client, (struct v4l2_control *)arg);
+
+        case VIDIOC_QUERYCTRL:
+        {
+                struct v4l2_queryctrl *qc = arg;
+                int i;
+
+                for (i = 0; i < ARRAY_SIZE(cx25840_qctrl); i++)
+                        if (qc->id && qc->id == cx25840_qctrl[i].id) {
+                                memcpy(qc, &cx25840_qctrl[i], sizeof(*qc));
+                                return 0;
+                        }
+                return -EINVAL;
+        }
 
         case VIDIOC_G_STD:
                 *(v4l2_std_id *)arg = cx25840_get_v4lstd(client);
                 break;
 
         case VIDIOC_S_STD:
-                result = set_v4lstd(client, *(v4l2_std_id *)arg);
+                state->radio = 0;
+                return set_v4lstd(client, *(v4l2_std_id *)arg);
+
+        case AUDC_SET_RADIO:
+                state->radio = 1;
                 break;
 
         case VIDIOC_G_INPUT:
-                *(int *)arg = state->input;
+                *(int *)arg = state->vid_input;
                 break;
 
         case VIDIOC_S_INPUT:
-                result = set_input(client, *(int *)arg);
+                return set_input(client, *(enum cx25840_video_input *)arg, state->aud_input);
+
+        case VIDIOC_S_AUDIO:
+        {
+                struct v4l2_audio *input = arg;
+
+                return set_input(client, state->vid_input, input->index);
+        }
+
+        case VIDIOC_G_AUDIO:
+        {
+                struct v4l2_audio *input = arg;
+
+                memset(input, 0, sizeof(*input));
+                input->index = state->aud_input;
                 break;
+        }
 
         case VIDIOC_S_FREQUENCY:
                 input_change(client);
@@ -670,6 +767,9 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                 u8 vpres = cx25840_read(client, 0x80a) & 0x10;
                 int val = 0;
 
+                if (state->radio)
+                        break;
+
                 vt->capability |=
                     V4L2_TUNER_CAP_STEREO | V4L2_TUNER_CAP_LANG1 |
                     V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
@@ -724,12 +824,10 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                 break;
 
         case VIDIOC_G_FMT:
-                result = get_v4lfmt(client, (struct v4l2_format *)arg);
-                break;
+                return get_v4lfmt(client, (struct v4l2_format *)arg);
 
         case VIDIOC_S_FMT:
-                result = set_v4lfmt(client, (struct v4l2_format *)arg);
-                break;
+                return set_v4lfmt(client, (struct v4l2_format *)arg);
 
         case VIDIOC_INT_RESET:
                 cx25840_initialize(client, 0);
@@ -741,11 +839,10 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd,
                 break;
 
         default:
-                cx25840_err("invalid ioctl %x\n", cmd);
                 return -EINVAL;
         }
 
-        return result;
+        return 0;
 }
 
 /* ----------------------------------------------------------------------- */
@@ -775,7 +872,7 @@ static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
         client->driver = &i2c_driver_cx25840;
         snprintf(client->name, sizeof(client->name) - 1, "cx25840");
 
-        cx25840_dbg("detecting cx25840 client on address 0x%x\n", address << 1);
+        v4l_dbg(1, client, "detecting cx25840 client on address 0x%x\n", address << 1);
 
         device_id = cx25840_read(client, 0x101) << 8;
         device_id |= cx25840_read(client, 0x100);
@@ -783,12 +880,12 @@ static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
         /* The high byte of the device ID should be
          * 0x84 if chip is present */
         if ((device_id & 0xff00) != 0x8400) {
-                cx25840_dbg("cx25840 not found\n");
+                v4l_dbg(1, client, "cx25840 not found\n");
                 kfree(client);
                 return 0;
         }
 
-        cx25840_info("cx25%3x-2%x found @ 0x%x (%s)\n",
+        v4l_info(client, "cx25%3x-2%x found @ 0x%x (%s)\n",
                     (device_id & 0xfff0) >> 4,
                     (device_id & 0x0f) < 3 ? (device_id & 0x0f) + 1 : 3,
                     address << 1, adapter->name);
@@ -801,10 +898,10 @@ static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
 
         i2c_set_clientdata(client, state);
         memset(state, 0, sizeof(struct cx25840_state));
-        state->input = CX25840_TUNER;
-        state->audclk_freq = V4L2_AUDCLK_48_KHZ;
-        state->audio_input = AUDIO_TUNER;
-        state->cardtype = CARDTYPE_PVR150;
+        state->vid_input = CX25840_COMPOSITE7;
+        state->aud_input = CX25840_AUDIO8;
+        state->audclk_freq = 48000;
+        state->pvr150_workaround = 0;
 
         cx25840_initialize(client, 1);
 
@@ -815,11 +912,7 @@ static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
 
 static int cx25840_attach_adapter(struct i2c_adapter *adapter)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adapter->class & I2C_CLASS_TV_ANALOG)
-#else
-        if (adapter->id == I2C_HW_B_BT848)
-#endif
                 return i2c_probe(adapter, &addr_data, &cx25840_detect_client);
         return 0;
 }
@@ -846,9 +939,7 @@ static struct i2c_driver i2c_driver_cx25840 = {
         .driver = {
                 .name = "cx25840",
         },
-
         .id = I2C_DRIVERID_CX25840,
-
         .attach_adapter = cx25840_attach_adapter,
         .detach_client = cx25840_detach_client,
         .command = cx25840_command,
@@ -892,11 +983,13 @@ static void log_status(struct i2c_client *client)
         u8 pref_mode = cx25840_read(client, 0x809);
         u8 afc0 = cx25840_read(client, 0x80b);
         u8 mute_ctl = cx25840_read(client, 0x8d3);
+        int vid_input = state->vid_input;
+        int aud_input = state->aud_input;
         char *p;
 
-        cx25840_info("Video signal:              %spresent\n",
+        v4l_info(client, "Video signal:              %spresent\n",
                     (microctrl_vidfmt & 0x10) ? "" : "not ");
-        cx25840_info("Detected format:           %s\n",
+        v4l_info(client, "Detected format:           %s\n",
                     fmt_strs[gen_stat1 & 0xf]);
 
         switch (mod_det_stat0) {
@@ -911,7 +1004,7 @@ static void log_status(struct i2c_client *client)
         case 0xfe: p = "forced mode"; break;
         default: p = "not defined";
         }
-        cx25840_info("Detected audio mode:       %s\n", p);
+        v4l_info(client, "Detected audio mode:       %s\n", p);
 
         switch (mod_det_stat1) {
         case 0x00: p = "not defined"; break;
@@ -937,10 +1030,10 @@ static void log_status(struct i2c_client *client)
         case 0xff: p = "no detected audio standard"; break;
         default: p = "not defined";
         }
-        cx25840_info("Detected audio standard:   %s\n", p);
-        cx25840_info("Audio muted:               %s\n",
+        v4l_info(client, "Detected audio standard:   %s\n", p);
+        v4l_info(client, "Audio muted:               %s\n",
                     (mute_ctl & 0x2) ? "yes" : "no");
-        cx25840_info("Audio microcontroller:     %s\n",
+        v4l_info(client, "Audio microcontroller:     %s\n",
                     (download_ctl & 0x10) ? "running" : "stopped");
 
         switch (audio_config >> 4) {
@@ -962,7 +1055,7 @@ static void log_status(struct i2c_client *client)
         case 0x0f: p = "automatic detection"; break;
         default: p = "undefined";
         }
-        cx25840_info("Configured audio standard: %s\n", p);
+        v4l_info(client, "Configured audio standard: %s\n", p);
 
         if ((audio_config >> 4) < 0xF) {
                 switch (audio_config & 0xF) {
@@ -979,7 +1072,7 @@ static void log_status(struct i2c_client *client)
                 case 0x0a: p = "SAP"; break;
                 default: p = "undefined";
                 }
-                cx25840_info("Configured audio mode:     %s\n", p);
+                v4l_info(client, "Configured audio mode:     %s\n", p);
         } else {
                 switch (audio_config & 0xF) {
                 case 0x00: p = "BG"; break;
@@ -995,30 +1088,27 @@ static void log_status(struct i2c_client *client)
                 case 0x0f: p = "automatic standard and mode detection"; break;
                 default: p = "undefined";
                 }
-                cx25840_info("Configured audio system:   %s\n", p);
+                v4l_info(client, "Configured audio system:   %s\n", p);
         }
 
-        cx25840_info("Specified standard:        %s\n",
+        v4l_info(client, "Specified standard:        %s\n",
                     vidfmt_sel ? fmt_strs[vidfmt_sel] : "automatic detection");
 
-        switch (state->input) {
-        case CX25840_COMPOSITE0: p = "Composite 0"; break;
-        case CX25840_COMPOSITE1: p = "Composite 1"; break;
-        case CX25840_SVIDEO0: p = "S-Video 0"; break;
-        case CX25840_SVIDEO1: p = "S-Video 1"; break;
-        case CX25840_TUNER: p = "Tuner"; break;
+        if (vid_input >= CX25840_COMPOSITE1 &&
+            vid_input <= CX25840_COMPOSITE8) {
+                v4l_info(client, "Specified video input:     Composite %d\n",
+                        vid_input - CX25840_COMPOSITE1 + 1);
+        } else {
+                v4l_info(client, "Specified video input:     S-Video (Luma In%d, Chroma In%d)\n",
+                        (vid_input & 0xf0) >> 4, (vid_input & 0xf00) >> 8);
         }
-        cx25840_info("Specified input:           %s\n", p);
-        cx25840_info("Specified audio input:     %s\n",
-                    state->audio_input == 0 ? "Tuner" : "External");
-
-        switch (state->audclk_freq) {
-        case V4L2_AUDCLK_441_KHZ: p = "44.1 kHz"; break;
-        case V4L2_AUDCLK_48_KHZ: p = "48 kHz"; break;
-        case V4L2_AUDCLK_32_KHZ: p = "32 kHz"; break;
-        default: p = "undefined";
+        if (aud_input) {
+                v4l_info(client, "Specified audio input:     Tuner (In%d)\n", aud_input);
+        } else {
+                v4l_info(client, "Specified audio input:     External\n");
         }
-        cx25840_info("Specified audioclock freq: %s\n", p);
+
+        v4l_info(client, "Specified audioclock freq: %d Hz\n", state->audclk_freq);
 
         switch (pref_mode & 0xf) {
         case 0: p = "mono/language A"; break;
@@ -1031,7 +1121,7 @@ static void log_status(struct i2c_client *client)
         case 7: p = "language AB"; break;
         default: p = "undefined";
         }
-        cx25840_info("Preferred audio mode:      %s\n", p);
+        v4l_info(client, "Preferred audio mode:      %s\n", p);
 
         if ((audio_config & 0xf) == 0xf) {
                 switch ((afc0 >> 3) & 0x3) {
@@ -1040,7 +1130,7 @@ static void log_status(struct i2c_client *client)
                 case 2: p = "autodetect"; break;
                 default: p = "undefined";
                 }
-                cx25840_info("Selected 65 MHz format:    %s\n", p);
+                v4l_info(client, "Selected 65 MHz format:    %s\n", p);
 
                 switch (afc0 & 0x7) {
                 case 0: p = "chroma"; break;
@@ -1050,6 +1140,6 @@ static void log_status(struct i2c_client *client)
                 case 4: p = "autodetect"; break;
                 default: p = "undefined";
                 }
-                cx25840_info("Selected 45 MHz format:    %s\n", p);
+                v4l_info(client, "Selected 45 MHz format:    %s\n", p);
         }
 }
diff --git a/drivers/media/video/cx25840/cx25840-firmware.c b/drivers/media/video/cx25840/cx25840-firmware.c
index df9d50a75542..e1a7823d82cd 100644
--- a/drivers/media/video/cx25840/cx25840-firmware.c
+++ b/drivers/media/video/cx25840/cx25840-firmware.c
@@ -15,7 +15,6 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-
 #include <linux/module.h>
 #include <linux/i2c.h>
 #include <linux/i2c-algo-bit.h>
@@ -38,7 +37,7 @@ module_param(firmware, charp, 0444);
 MODULE_PARM_DESC(fastfw, "Load firmware fast [0=100MHz 1=333MHz (default)]");
 MODULE_PARM_DESC(firmware, "Firmware image [default: " FWFILE "]");
 
-static inline void set_i2c_delay(struct i2c_client *client, int delay)
+static void set_i2c_delay(struct i2c_client *client, int delay)
 {
         struct i2c_algo_bit_data *algod = client->adapter->algo_data;
 
@@ -52,7 +51,7 @@ static inline void set_i2c_delay(struct i2c_client *client, int delay)
         }
 }
 
-static inline void start_fw_load(struct i2c_client *client)
+static void start_fw_load(struct i2c_client *client)
 {
         /* DL_ADDR_LB=0 DL_ADDR_HB=0 */
         cx25840_write(client, 0x800, 0x00);
@@ -66,7 +65,7 @@ static inline void start_fw_load(struct i2c_client *client)
                 set_i2c_delay(client, 3);
 }
 
-static inline void end_fw_load(struct i2c_client *client)
+static void end_fw_load(struct i2c_client *client)
 {
         if (fastfw)
                 set_i2c_delay(client, 10);
@@ -77,38 +76,47 @@ static inline void end_fw_load(struct i2c_client *client)
         cx25840_write(client, 0x803, 0x03);
 }
 
-static inline int check_fw_load(struct i2c_client *client, int size)
+static int check_fw_load(struct i2c_client *client, int size)
 {
         /* DL_ADDR_HB DL_ADDR_LB */
         int s = cx25840_read(client, 0x801) << 8;
         s |= cx25840_read(client, 0x800);
 
         if (size != s) {
-                cx25840_err("firmware %s load failed\n", firmware);
+                v4l_err(client, "firmware %s load failed\n", firmware);
                 return -EINVAL;
         }
 
-        cx25840_info("loaded %s firmware (%d bytes)\n", firmware, size);
+        v4l_info(client, "loaded %s firmware (%d bytes)\n", firmware, size);
         return 0;
 }
 
-static inline int fw_write(struct i2c_client *client, u8 * data, int size)
+static int fw_write(struct i2c_client *client, u8 * data, int size)
 {
-        if (i2c_master_send(client, data, size) < size) {
+        int sent;
+
+        if ((sent = i2c_master_send(client, data, size)) < size) {
 
                 if (fastfw) {
-                        cx25840_err("333MHz i2c firmware load failed\n");
+                        v4l_err(client, "333MHz i2c firmware load failed\n");
                         fastfw = 0;
                         set_i2c_delay(client, 10);
 
+                        if (sent > 2) {
+                                u16 dl_addr = cx25840_read(client, 0x801) << 8;
+                                dl_addr |= cx25840_read(client, 0x800);
+                                dl_addr -= sent - 2;
+                                cx25840_write(client, 0x801, dl_addr >> 8);
+                                cx25840_write(client, 0x800, dl_addr & 0xff);
+                        }
+
                         if (i2c_master_send(client, data, size) < size) {
-                                cx25840_err
-                                    ("100MHz i2c firmware load failed\n");
+                                v4l_err(client, "100MHz i2c firmware load failed\n");
                                 return -ENOSYS;
                         }
 
                 } else {
-                        cx25840_err("firmware load i2c failure\n");
+                        v4l_err(client, "firmware load i2c failure\n");
                         return -ENOSYS;
                 }
 
@@ -124,7 +132,7 @@ int cx25840_loadfw(struct i2c_client *client)
         int size, send, retval;
 
         if (request_firmware(&fw, firmware, FWDEV(client)) != 0) {
-                cx25840_err("unable to open firmware %s\n", firmware);
+                v4l_err(client, "unable to open firmware %s\n", firmware);
                 return -EINVAL;
         }
 
diff --git a/drivers/media/video/cx25840/cx25840-vbi.c b/drivers/media/video/cx25840/cx25840-vbi.c
index 13ba4e15ddea..04d879da7d63 100644
--- a/drivers/media/video/cx25840/cx25840-vbi.c
+++ b/drivers/media/video/cx25840/cx25840-vbi.c
@@ -22,7 +22,7 @@
 
 #include "cx25840.h"
 
-static inline int odd_parity(u8 c)
+static int odd_parity(u8 c)
 {
         c ^= (c >> 4);
         c ^= (c >> 2);
@@ -31,7 +31,7 @@ static inline int odd_parity(u8 c)
         return c & 1;
 }
 
-static inline int decode_vps(u8 * dst, u8 * p)
+static int decode_vps(u8 * dst, u8 * p)
 {
         static const u8 biphase_tbl[] = {
                 0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
diff --git a/drivers/media/video/cx25840/cx25840.h b/drivers/media/video/cx25840/cx25840.h
index 40aa59f9c525..fd22f30dcc1b 100644
--- a/drivers/media/video/cx25840/cx25840.h
+++ b/drivers/media/video/cx25840/cx25840.h
@@ -24,48 +24,60 @@
 #include <linux/videodev2.h>
 #include <linux/i2c.h>
 
-extern int cx25840_debug;
-
-#define cx25840_dbg(fmt, arg...) do { if (cx25840_debug) \
-        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-               client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
-#define cx25840_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
-#define cx25840_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
-#define CX25840_CID_CARDTYPE (V4L2_CID_PRIVATE_BASE+0)
-
-/* The CARDTYPE_PVR150_WORKAROUND cardtype activates a workaround for a
-   hardware bug that is present in PVR150 (and possible PVR500) cards that
-   have certain NTSC tuners (tveeprom model numbers 85, 99 and 112). The
+/* ENABLE_PVR150_WORKAROUND activates a workaround for a hardware bug that is
+   present in Hauppauge PVR-150 (and possibly PVR-500) cards that have
+   certain NTSC tuners (tveeprom tuner model numbers 85, 99 and 112). The
    audio autodetect fails on some channels for these models and the workaround
    is to select the audio standard explicitly. Many thanks to Hauppauge for
    providing this information. */
-enum cx25840_cardtype {
-        CARDTYPE_PVR150,
-        CARDTYPE_PG600,
-        CARDTYPE_PVR150_WORKAROUND,
+#define CX25840_CID_ENABLE_PVR150_WORKAROUND (V4L2_CID_PRIVATE_BASE+0)
+
+enum cx25840_video_input {
+        /* Composite video inputs In1-In8 */
+        CX25840_COMPOSITE1 = 1,
+        CX25840_COMPOSITE2,
+        CX25840_COMPOSITE3,
+        CX25840_COMPOSITE4,
+        CX25840_COMPOSITE5,
+        CX25840_COMPOSITE6,
+        CX25840_COMPOSITE7,
+        CX25840_COMPOSITE8,
+
+        /* S-Video inputs consist of one luma input (In1-In4) ORed with one
+           chroma input (In5-In8) */
+        CX25840_SVIDEO_LUMA1 = 0x10,
+        CX25840_SVIDEO_LUMA2 = 0x20,
+        CX25840_SVIDEO_LUMA3 = 0x30,
+        CX25840_SVIDEO_LUMA4 = 0x40,
+        CX25840_SVIDEO_CHROMA4 = 0x400,
+        CX25840_SVIDEO_CHROMA5 = 0x500,
+        CX25840_SVIDEO_CHROMA6 = 0x600,
+        CX25840_SVIDEO_CHROMA7 = 0x700,
+        CX25840_SVIDEO_CHROMA8 = 0x800,
+
+        /* S-Video aliases for common luma/chroma combinations */
+        CX25840_SVIDEO1 = 0x510,
+        CX25840_SVIDEO2 = 0x620,
+        CX25840_SVIDEO3 = 0x730,
+        CX25840_SVIDEO4 = 0x840,
 };
 
-enum cx25840_input {
-        CX25840_TUNER,
-        CX25840_COMPOSITE0,
-        CX25840_COMPOSITE1,
-        CX25840_SVIDEO0,
-        CX25840_SVIDEO1
+enum cx25840_audio_input {
+        /* Audio inputs: serial or In4-In8 */
+        CX25840_AUDIO_SERIAL,
+        CX25840_AUDIO4 = 4,
+        CX25840_AUDIO5,
+        CX25840_AUDIO6,
+        CX25840_AUDIO7,
+        CX25840_AUDIO8,
 };
 
 struct cx25840_state {
-        enum cx25840_cardtype cardtype;
-        enum cx25840_input input;
-        int audio_input;
-        enum v4l2_audio_clock_freq audclk_freq;
+        int pvr150_workaround;
+        int radio;
+        enum cx25840_video_input vid_input;
+        enum cx25840_audio_input aud_input;
+        u32 audclk_freq;
 };
 
 /* ----------------------------------------------------------------------- */
@@ -84,6 +96,7 @@ int cx25840_loadfw(struct i2c_client *client);
 /* ----------------------------------------------------------------------- */
 /* cx25850-audio.c                                                         */
 int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg);
+void cx25840_audio_set_path(struct i2c_client *client);
 
 /* ----------------------------------------------------------------------- */
 /* cx25850-vbi.c                                                           */
diff --git a/drivers/media/video/cx88/Kconfig b/drivers/media/video/cx88/Kconfig
index 85ba4106dc79..76fcb4e995c9 100644
--- a/drivers/media/video/cx88/Kconfig
+++ b/drivers/media/video/cx88/Kconfig
@@ -29,6 +29,21 @@ config VIDEO_CX88_DVB
           You must also select one or more DVB/ATSC demodulators.
           If you are unsure which you need, choose all of them.
 
+config VIDEO_CX88_ALSA
+        tristate "ALSA DMA audio support"
+        depends on VIDEO_CX88 && SND
+        select SND_PCM_OSS
+        ---help---
+          This is a video4linux driver for direct (DMA) audio on
+          Conexant 2388x based TV cards.
+          It only works with boards with function 01 enabled.
+          To check if your board supports, use lspci -n.
+          If supported, you should see 1471:8801 or 1471:8811
+          PCI device.
+
+          To compile this driver as a module, choose M here: the
+          module will be called cx88-alsa.
+
 config VIDEO_CX88_DVB_ALL_FRONTENDS
         bool "Build all supported frontends for cx2388x based TV cards"
         default y
@@ -38,6 +53,7 @@ config VIDEO_CX88_DVB_ALL_FRONTENDS
         select DVB_CX22702
         select DVB_LGDT330X
         select DVB_NXT200X
+        select DVB_CX24123
         ---help---
           This builds cx88-dvb with all currently supported frontend
           demodulators.  If you wish to tweak your configuration, and
@@ -89,3 +105,12 @@ config VIDEO_CX88_DVB_NXT200X
         ---help---
           This adds ATSC 8VSB and QAM64/256 support for cards based on the
           Connexant 2388x chip and the NXT2002/NXT2004 demodulator.
+
+config VIDEO_CX88_DVB_CX24123
+        bool "Conexant CX24123 DVB-S Support"
+        default y
+        depends on VIDEO_CX88_DVB && !VIDEO_CX88_DVB_ALL_FRONTENDS
+        select DVB_CX24123
+        ---help---
+          This adds DVB-S support for cards based on the
+          Connexant 2388x chip and the CX24123 demodulator.
diff --git a/drivers/media/video/cx88/Makefile b/drivers/media/video/cx88/Makefile
index 54401b02b7ce..e4b2134fe567 100644
--- a/drivers/media/video/cx88/Makefile
+++ b/drivers/media/video/cx88/Makefile
@@ -4,7 +4,7 @@ cx8800-objs	:= cx88-video.o cx88-vbi.o
 cx8802-objs     := cx88-mpeg.o
 
 obj-$(CONFIG_VIDEO_CX88) += cx88xx.o cx8800.o cx8802.o cx88-blackbird.o
-obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o
+obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o cx88-vp3054-i2c.o
 
 EXTRA_CFLAGS += -I$(src)/..
 EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
@@ -16,5 +16,7 @@ extra-cflags-$(CONFIG_DVB_OR51132)   += -DHAVE_OR51132=1
 extra-cflags-$(CONFIG_DVB_LGDT330X)  += -DHAVE_LGDT330X=1
 extra-cflags-$(CONFIG_DVB_MT352)     += -DHAVE_MT352=1
 extra-cflags-$(CONFIG_DVB_NXT200X)   += -DHAVE_NXT200X=1
+extra-cflags-$(CONFIG_DVB_CX24123)   += -DHAVE_CX24123=1
+extra-cflags-$(CONFIG_VIDEO_CX88_DVB)+= -DHAVE_VP3054_I2C=1
 
 EXTRA_CFLAGS += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/video/cx88/cx88-alsa.c b/drivers/media/video/cx88/cx88-alsa.c
new file mode 100644
index 000000000000..7695b521eb35
--- /dev/null
+++ b/drivers/media/video/cx88/cx88-alsa.c
@@ -0,0 +1,848 @@
+/*
+ *
+ *  Support for audio capture
+ *  PCI function #1 of the cx2388x.
+ *
+ *    (c) 2005,2006 Ricardo Cerqueira <v4l@cerqueira.org>
+ *    (c) 2005 Mauro Carvalho Chehab <mchehab@brturbo.com.br>
+ *    Based on a dummy cx88 module by Gerd Knorr <kraxel@bytesex.org>
+ *    Based on dummy.c by Jaroslav Kysela <perex@suse.cz>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/interrupt.h>
+#include <asm/delay.h>
+#include <sound/driver.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/control.h>
+#include <sound/initval.h>
+
+#include "cx88.h"
+#include "cx88-reg.h"
+
+#define dprintk(level,fmt, arg...)      if (debug >= level) \
+        printk(KERN_INFO "%s/1: " fmt, chip->core->name , ## arg)
+
+#define dprintk_core(level,fmt, arg...) if (debug >= level) \
+        printk(KERN_DEBUG "%s/1: " fmt, chip->core->name , ## arg)
+
+
+/****************************************************************************
+        Data type declarations - Can be moded to a header file later
+ ****************************************************************************/
+
+/* These can be replaced after done */
+#define MIXER_ADDR_LAST MAX_CX88_INPUT
+
+struct cx88_audio_dev {
+        struct cx88_core           *core;
+        struct cx88_dmaqueue       q;
+
+        /* pci i/o */
+        struct pci_dev             *pci;
+        unsigned char              pci_rev,pci_lat;
+
+        /* audio controls */
+        int                        irq;
+
+        snd_card_t                 *card;
+
+        spinlock_t                 reg_lock;
+
+        unsigned int               dma_size;
+        unsigned int               period_size;
+        unsigned int               num_periods;
+
+        struct videobuf_dmabuf dma_risc;
+
+        int                        mixer_volume[MIXER_ADDR_LAST+1][2];
+        int                        capture_source[MIXER_ADDR_LAST+1][2];
+
+        long int read_count;
+        long int read_offset;
+
+        struct cx88_buffer   *buf;
+
+        long opened;
+        snd_pcm_substream_t *substream;
+
+};
+typedef struct cx88_audio_dev snd_cx88_card_t;
+
+
+
+/****************************************************************************
+                        Module global static vars
+ ****************************************************************************/
+
+static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;      /* Index 0-MAX */
+static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;       /* ID for this card */
+static int enable[SNDRV_CARDS] = {1, [1 ... (SNDRV_CARDS - 1)] = 1};
+static snd_card_t *snd_cx88_cards[SNDRV_CARDS];
+
+module_param_array(enable, bool, NULL, 0444);
+MODULE_PARM_DESC(enable, "Enable cx88x soundcard. default enabled.");
+
+module_param_array(index, int, NULL, 0444);
+MODULE_PARM_DESC(index, "Index value for cx88x capture interface(s).");
+
+
+/****************************************************************************
+                                Module macros
+ ****************************************************************************/
+
+MODULE_DESCRIPTION("ALSA driver module for cx2388x based TV cards");
+MODULE_AUTHOR("Ricardo Cerqueira");
+MODULE_AUTHOR("Mauro Carvalho Chehab <mchehab@brturbo.com.br>");
+MODULE_LICENSE("GPL");
+MODULE_SUPPORTED_DEVICE("{{Conexant,23881},"
+                        "{{Conexant,23882},"
+                        "{{Conexant,23883}");
+static unsigned int debug = 0;
+module_param(debug,int,0644);
+MODULE_PARM_DESC(debug,"enable debug messages");
+
+/****************************************************************************
+                        Module specific funtions
+ ****************************************************************************/
+
+/*
+ * BOARD Specific: Sets audio DMA
+ */
+
+int _cx88_start_audio_dma(snd_cx88_card_t *chip)
+{
+        struct cx88_buffer   *buf = chip->buf;
+        struct cx88_core *core=chip->core;
+        struct sram_channel *audio_ch = &cx88_sram_channels[SRAM_CH25];
+
+
+        dprintk(1, "Starting audio DMA for %i bytes/line and %i (%i) lines at address %08x\n",buf->bpl, chip->num_periods, audio_ch->fifo_size / buf->bpl, audio_ch->fifo_start);
+
+        /* setup fifo + format - out channel */
+        cx88_sram_channel_setup(chip->core, &cx88_sram_channels[SRAM_CH25],
+                                buf->bpl, buf->risc.dma);
+
+        /* sets bpl size */
+        cx_write(MO_AUDD_LNGTH, buf->bpl);
+
+        /* reset counter */
+        cx_write(MO_AUDD_GPCNTRL,GP_COUNT_CONTROL_RESET);
+
+        dprintk(1,"Enabling IRQ, setting mask from 0x%x to 0x%x\n",chip->core->pci_irqmask,(chip->core->pci_irqmask | 0x02));
+        /* enable irqs */
+        cx_set(MO_PCI_INTMSK, chip->core->pci_irqmask | 0x02);
+
+
+        /* Enables corresponding bits at AUD_INT_STAT */
+        cx_write(MO_AUD_INTMSK,
+                        (1<<16)|
+                        (1<<12)|
+                        (1<<4)|
+                        (1<<0)
+                        );
+
+        /* start dma */
+        cx_set(MO_DEV_CNTRL2, (1<<5)); /* Enables Risc Processor */
+        cx_set(MO_AUD_DMACNTRL, 0x11); /* audio downstream FIFO and RISC enable */
+
+        if (debug)
+                cx88_sram_channel_dump(chip->core, &cx88_sram_channels[SRAM_CH25]);
+
+        return 0;
+}
+
+/*
+ * BOARD Specific: Resets audio DMA
+ */
+int _cx88_stop_audio_dma(snd_cx88_card_t *chip)
+{
+        struct cx88_core *core=chip->core;
+        dprintk(1, "Stopping audio DMA\n");
+
+        /* stop dma */
+        cx_clear(MO_AUD_DMACNTRL, 0x11);
+
+        /* disable irqs */
+        cx_clear(MO_PCI_INTMSK, 0x02);
+        cx_clear(MO_AUD_INTMSK,
+                        (1<<16)|
+                        (1<<12)|
+                        (1<<4)|
+                        (1<<0)
+                        );
+
+        if (debug)
+                cx88_sram_channel_dump(chip->core, &cx88_sram_channels[SRAM_CH25]);
+
+        return 0;
+}
+
+#define MAX_IRQ_LOOP 10
+
+/*
+ * BOARD Specific: IRQ dma bits
+ */
+static char *cx88_aud_irqs[32] = {
+        "dn_risci1", "up_risci1", "rds_dn_risc1", /* 0-2 */
+        NULL,                                     /* reserved */
+        "dn_risci2", "up_risci2", "rds_dn_risc2", /* 4-6 */
+        NULL,                                     /* reserved */
+        "dnf_of", "upf_uf", "rds_dnf_uf",         /* 8-10 */
+        NULL,                                     /* reserved */
+        "dn_sync", "up_sync", "rds_dn_sync",      /* 12-14 */
+        NULL,                                     /* reserved */
+        "opc_err", "par_err", "rip_err",          /* 16-18 */
+        "pci_abort", "ber_irq", "mchg_irq"        /* 19-21 */
+};
+
+/*
+ * BOARD Specific: Threats IRQ audio specific calls
+ */
+static void cx8801_aud_irq(snd_cx88_card_t *chip)
+{
+        struct cx88_core *core = chip->core;
+        u32 status, mask;
+        u32 count;
+
+        status = cx_read(MO_AUD_INTSTAT);
+        mask   = cx_read(MO_AUD_INTMSK);
+        if (0 == (status & mask)) {
+                spin_unlock(&chip->reg_lock);
+                return;
+        }
+        cx_write(MO_AUD_INTSTAT, status);
+        if (debug > 1  ||  (status & mask & ~0xff))
+                cx88_print_irqbits(core->name, "irq aud",
+                                   cx88_aud_irqs, status, mask);
+        /* risc op code error */
+        if (status & (1 << 16)) {
+                printk(KERN_WARNING "%s/0: audio risc op code error\n",core->name);
+                cx_clear(MO_AUD_DMACNTRL, 0x11);
+                cx88_sram_channel_dump(core, &cx88_sram_channels[SRAM_CH25]);
+        }
+
+        /* risc1 downstream */
+        if (status & 0x01) {
+                spin_lock(&chip->reg_lock);
+                count = cx_read(MO_AUDD_GPCNT);
+                spin_unlock(&chip->reg_lock);
+                if (chip->read_count == 0)
+                        chip->read_count += chip->dma_size;
+        }
+
+        if  (chip->read_count >= chip->period_size) {
+                dprintk(2, "Elapsing period\n");
+                snd_pcm_period_elapsed(chip->substream);
+        }
+
+        dprintk(3,"Leaving audio IRQ handler...\n");
+
+        /* FIXME: Any other status should deserve a special handling? */
+}
+
+/*
+ * BOARD Specific: Handles IRQ calls
+ */
+static irqreturn_t cx8801_irq(int irq, void *dev_id, struct pt_regs *regs)
+{
+        snd_cx88_card_t *chip = dev_id;
+        struct cx88_core *core = chip->core;
+        u32 status;
+        int loop, handled = 0;
+
+        for (loop = 0; loop < MAX_IRQ_LOOP; loop++) {
+                status = cx_read(MO_PCI_INTSTAT) & (core->pci_irqmask | 0x02);
+                if (0 == status)
+                        goto out;
+                dprintk( 3, "cx8801_irq\n" );
+                dprintk( 3, "    loop: %d/%d\n", loop, MAX_IRQ_LOOP );
+                dprintk( 3, "    status: %d\n", status );
+                handled = 1;
+                cx_write(MO_PCI_INTSTAT, status);
+
+                if (status & 0x02)
+                {
+                        dprintk( 2, "    ALSA IRQ handling\n" );
+                        cx8801_aud_irq(chip);
+                }
+        };
+
+        if (MAX_IRQ_LOOP == loop) {
+                dprintk( 0, "clearing mask\n" );
+                dprintk(1,"%s/0: irq loop -- clearing mask\n",
+                       core->name);
+                cx_clear(MO_PCI_INTMSK,0x02);
+        }
+
+ out:
+        return IRQ_RETVAL(handled);
+}
+
+
+static int dsp_buffer_free(snd_cx88_card_t *chip)
+{
+        BUG_ON(!chip->dma_size);
+
+        dprintk(2,"Freeing buffer\n");
+        videobuf_dma_pci_unmap(chip->pci, &chip->dma_risc);
+        videobuf_dma_free(&chip->dma_risc);
+        btcx_riscmem_free(chip->pci,&chip->buf->risc);
+        kfree(chip->buf);
+
+        chip->dma_size = 0;
+
+       return 0;
+}
+
+/****************************************************************************
+                                ALSA PCM Interface
+ ****************************************************************************/
+
+/*
+ * Digital hardware definition
+ */
+static snd_pcm_hardware_t snd_cx88_digital_hw = {
+        .info = SNDRV_PCM_INFO_MMAP |
+                SNDRV_PCM_INFO_INTERLEAVED |
+                SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                SNDRV_PCM_INFO_MMAP_VALID,
+        .formats = SNDRV_PCM_FMTBIT_S16_LE,
+
+        .rates =                SNDRV_PCM_RATE_48000,
+        .rate_min =             48000,
+        .rate_max =             48000,
+        .channels_min = 1,
+        .channels_max = 2,
+        .buffer_bytes_max = (2*2048),
+        .period_bytes_min = 256,
+        .period_bytes_max = 2048,
+        .periods_min = 2,
+        .periods_max = 16,
+};
+
+/*
+ * audio pcm capture runtime free
+ */
+static void snd_card_cx88_runtime_free(snd_pcm_runtime_t *runtime)
+{
+}
+/*
+ * audio pcm capture open callback
+ */
+static int snd_cx88_pcm_open(snd_pcm_substream_t *substream)
+{
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+        snd_pcm_runtime_t *runtime = substream->runtime;
+        int err;
+
+        if (test_and_set_bit(0, &chip->opened))
+                return -EBUSY;
+
+        err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
+        if (err < 0)
+                goto _error;
+
+        chip->substream = substream;
+
+        chip->read_count = 0;
+        chip->read_offset = 0;
+
+        runtime->private_free = snd_card_cx88_runtime_free;
+        runtime->hw = snd_cx88_digital_hw;
+
+        return 0;
+_error:
+        dprintk(1,"Error opening PCM!\n");
+        clear_bit(0, &chip->opened);
+        smp_mb__after_clear_bit();
+        return err;
+}
+
+/*
+ * audio close callback
+ */
+static int snd_cx88_close(snd_pcm_substream_t *substream)
+{
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+
+        clear_bit(0, &chip->opened);
+        smp_mb__after_clear_bit();
+
+        return 0;
+}
+
+/*
+ * hw_params callback
+ */
+static int snd_cx88_hw_params(snd_pcm_substream_t * substream,
+                                 snd_pcm_hw_params_t * hw_params)
+{
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+        struct cx88_buffer *buf;
+
+        if (substream->runtime->dma_area) {
+                dsp_buffer_free(chip);
+                substream->runtime->dma_area = NULL;
+        }
+
+
+        chip->period_size = params_period_bytes(hw_params);
+        chip->num_periods = params_periods(hw_params);
+        chip->dma_size = chip->period_size * params_periods(hw_params);
+
+        BUG_ON(!chip->dma_size);
+
+        dprintk(1,"Setting buffer\n");
+
+        buf = kmalloc(sizeof(*buf),GFP_KERNEL);
+        if (NULL == buf)
+                return -ENOMEM;
+        memset(buf,0,sizeof(*buf));
+
+
+        buf->vb.memory = V4L2_MEMORY_MMAP;
+        buf->vb.width  = chip->period_size;
+        buf->vb.height = chip->num_periods;
+        buf->vb.size   = chip->dma_size;
+        buf->vb.field  = V4L2_FIELD_NONE;
+
+        videobuf_dma_init(&buf->vb.dma);
+        videobuf_dma_init_kernel(&buf->vb.dma,PCI_DMA_FROMDEVICE,
+                        (PAGE_ALIGN(buf->vb.size) >> PAGE_SHIFT));
+
+        videobuf_dma_pci_map(chip->pci,&buf->vb.dma);
+
+
+        cx88_risc_databuffer(chip->pci, &buf->risc,
+                        buf->vb.dma.sglist,
+                        buf->vb.width, buf->vb.height);
+
+        buf->risc.jmp[0] = cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC);
+        buf->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
+
+        buf->vb.state = STATE_PREPARED;
+
+        buf->bpl = chip->period_size;
+        chip->buf = buf;
+        chip->dma_risc = buf->vb.dma;
+
+        dprintk(1,"Buffer ready at %u\n",chip->dma_risc.nr_pages);
+        substream->runtime->dma_area = chip->dma_risc.vmalloc;
+        return 0;
+}
+
+/*
+ * hw free callback
+ */
+static int snd_cx88_hw_free(snd_pcm_substream_t * substream)
+{
+
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+
+        if (substream->runtime->dma_area) {
+                dsp_buffer_free(chip);
+                substream->runtime->dma_area = NULL;
+        }
+
+        return 0;
+}
+
+/*
+ * prepare callback
+ */
+static int snd_cx88_prepare(snd_pcm_substream_t *substream)
+{
+        return 0;
+}
+
+
+/*
+ * trigger callback
+ */
+static int snd_cx88_card_trigger(snd_pcm_substream_t *substream, int cmd)
+{
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+        int err;
+
+        spin_lock(&chip->reg_lock);
+
+        switch (cmd) {
+        case SNDRV_PCM_TRIGGER_START:
+                err=_cx88_start_audio_dma(chip);
+                break;
+        case SNDRV_PCM_TRIGGER_STOP:
+                err=_cx88_stop_audio_dma(chip);
+                break;
+        default:
+                err=-EINVAL;
+                break;
+        }
+
+        spin_unlock(&chip->reg_lock);
+
+        return err;
+}
+
+/*
+ * pointer callback
+ */
+static snd_pcm_uframes_t snd_cx88_pointer(snd_pcm_substream_t *substream)
+{
+        snd_cx88_card_t *chip = snd_pcm_substream_chip(substream);
+        snd_pcm_runtime_t *runtime = substream->runtime;
+
+        if (chip->read_count) {
+                chip->read_count -= snd_pcm_lib_period_bytes(substream);
+                chip->read_offset += snd_pcm_lib_period_bytes(substream);
+                if (chip->read_offset == chip->dma_size)
+                        chip->read_offset = 0;
+        }
+
+        dprintk(2, "Pointer time, will return %li, read %li\n",chip->read_offset,chip->read_count);
+        return bytes_to_frames(runtime, chip->read_offset);
+
+}
+
+/*
+ * operators
+ */
+static snd_pcm_ops_t snd_cx88_pcm_ops = {
+        .open = snd_cx88_pcm_open,
+        .close = snd_cx88_close,
+        .ioctl = snd_pcm_lib_ioctl,
+        .hw_params = snd_cx88_hw_params,
+        .hw_free = snd_cx88_hw_free,
+        .prepare = snd_cx88_prepare,
+        .trigger = snd_cx88_card_trigger,
+        .pointer = snd_cx88_pointer,
+};
+
+/*
+ * create a PCM device
+ */
+static int __devinit snd_cx88_pcm(snd_cx88_card_t *chip, int device, char *name)
+{
+        int err;
+        snd_pcm_t *pcm;
+
+        err = snd_pcm_new(chip->card, name, device, 0, 1, &pcm);
+        if (err < 0)
+                return err;
+        pcm->private_data = chip;
+        strcpy(pcm->name, name);
+        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_cx88_pcm_ops);
+
+        return 0;
+}
+
+/****************************************************************************
+                                CONTROL INTERFACE
+ ****************************************************************************/
+static int snd_cx88_capture_volume_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *info)
+{
+        info->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
+        info->count = 1;
+        info->value.integer.min = 0;
+        info->value.integer.max = 0x3f;
+
+        return 0;
+}
+
+/* OK - TODO: test it */
+static int snd_cx88_capture_volume_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *value)
+{
+        snd_cx88_card_t *chip = snd_kcontrol_chip(kcontrol);
+        struct cx88_core *core=chip->core;
+
+        value->value.integer.value[0] = 0x3f - (cx_read(AUD_VOL_CTL) & 0x3f);
+
+        return 0;
+}
+
+/* OK - TODO: test it */
+static int snd_cx88_capture_volume_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *value)
+{
+        snd_cx88_card_t *chip = snd_kcontrol_chip(kcontrol);
+        struct cx88_core *core=chip->core;
+        int v;
+        u32 old_control;
+
+        spin_lock_irq(&chip->reg_lock);
+        old_control = 0x3f - (cx_read(AUD_VOL_CTL) & 0x3f);
+        v = 0x3f - (value->value.integer.value[0] & 0x3f);
+        cx_andor(AUD_VOL_CTL, 0x3f, v);
+        spin_unlock_irq(&chip->reg_lock);
+
+        return v != old_control;
+}
+
+static snd_kcontrol_new_t snd_cx88_capture_volume = {
+        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+        .name = "Capture Volume",
+        .info = snd_cx88_capture_volume_info,
+        .get = snd_cx88_capture_volume_get,
+        .put = snd_cx88_capture_volume_put,
+};
+
+
+/****************************************************************************
+                        Basic Flow for Sound Devices
+ ****************************************************************************/
+
+/*
+ * PCI ID Table - 14f1:8801 and 14f1:8811 means function 1: Audio
+ * Only boards with eeprom and byte 1 at eeprom=1 have it
+ */
+
+struct pci_device_id cx88_audio_pci_tbl[] = {
+        {0x14f1,0x8801,PCI_ANY_ID,PCI_ANY_ID,0,0,0},
+        {0x14f1,0x8811,PCI_ANY_ID,PCI_ANY_ID,0,0,0},
+        {0, }
+};
+MODULE_DEVICE_TABLE(pci, cx88_audio_pci_tbl);
+
+/*
+ * Chip-specific destructor
+ */
+
+static int snd_cx88_free(snd_cx88_card_t *chip)
+{
+
+        if (chip->irq >= 0){
+                synchronize_irq(chip->irq);
+                free_irq(chip->irq, chip);
+        }
+
+        cx88_core_put(chip->core,chip->pci);
+
+        pci_disable_device(chip->pci);
+        return 0;
+}
+
+/*
+ * Component Destructor
+ */
+static void snd_cx88_dev_free(snd_card_t * card)
+{
+        snd_cx88_card_t *chip = card->private_data;
+
+        snd_cx88_free(chip);
+}
+
+
+/*
+ * Alsa Constructor - Component probe
+ */
+
+static int devno=0;
+static int __devinit snd_cx88_create(snd_card_t *card, struct pci_dev *pci,
+                                    snd_cx88_card_t **rchip)
+{
+        snd_cx88_card_t   *chip;
+        struct cx88_core  *core;
+        int               err;
+
+        *rchip = NULL;
+
+        err = pci_enable_device(pci);
+        if (err < 0)
+                return err;
+
+        pci_set_master(pci);
+
+        chip = (snd_cx88_card_t *) card->private_data;
+
+        core = cx88_core_get(pci);
+
+        if (!pci_dma_supported(pci,0xffffffff)) {
+                dprintk(0, "%s/1: Oops: no 32bit PCI DMA ???\n",core->name);
+                err = -EIO;
+                cx88_core_put(core,pci);
+                return err;
+        }
+
+
+        /* pci init */
+        chip->card = card;
+        chip->pci = pci;
+        chip->irq = -1;
+        spin_lock_init(&chip->reg_lock);
+
+        cx88_reset(core);
+        if (NULL == core) {
+                err = -EINVAL;
+                kfree (chip);
+                return err;
+        }
+        chip->core = core;
+
+        /* get irq */
+        err = request_irq(chip->pci->irq, cx8801_irq,
+                          SA_SHIRQ | SA_INTERRUPT, chip->core->name, chip);
+        if (err < 0) {
+                dprintk(0, "%s: can't get IRQ %d\n",
+                       chip->core->name, chip->pci->irq);
+                return err;
+        }
+
+        /* print pci info */
+        pci_read_config_byte(pci, PCI_CLASS_REVISION, &chip->pci_rev);
+        pci_read_config_byte(pci, PCI_LATENCY_TIMER,  &chip->pci_lat);
+
+        dprintk(1,"ALSA %s/%i: found at %s, rev: %d, irq: %d, "
+               "latency: %d, mmio: 0x%lx\n", core->name, devno,
+               pci_name(pci), chip->pci_rev, pci->irq,
+               chip->pci_lat,pci_resource_start(pci,0));
+
+        chip->irq = pci->irq;
+        synchronize_irq(chip->irq);
+
+        snd_card_set_dev(card, &pci->dev);
+
+        *rchip = chip;
+
+        return 0;
+}
+
+static int __devinit cx88_audio_initdev(struct pci_dev *pci,
+                                    const struct pci_device_id *pci_id)
+{
+        snd_card_t       *card;
+        snd_cx88_card_t  *chip;
+        int              err;
+
+        if (devno >= SNDRV_CARDS)
+                return (-ENODEV);
+
+        if (!enable[devno]) {
+                ++devno;
+                return (-ENOENT);
+        }
+
+        card = snd_card_new(index[devno], id[devno], THIS_MODULE, sizeof(snd_cx88_card_t));
+        if (!card)
+                return (-ENOMEM);
+
+        card->private_free = snd_cx88_dev_free;
+
+        err = snd_cx88_create(card, pci, &chip);
+        if (err < 0)
+                return (err);
+
+        err = snd_cx88_pcm(chip, 0, "CX88 Digital");
+
+        if (err < 0) {
+                snd_card_free(card);
+                return (err);
+        }
+
+        err = snd_ctl_add(card, snd_ctl_new1(&snd_cx88_capture_volume, chip));
+        if (err < 0) {
+                snd_card_free(card);
+                return (err);
+        }
+
+        strcpy (card->driver, "CX88x");
+        sprintf(card->shortname, "Conexant CX%x", pci->device);
+        sprintf(card->longname, "%s at %#lx",
+                card->shortname, pci_resource_start(pci, 0));
+        strcpy (card->mixername, "CX88");
+
+        dprintk (0, "%s/%i: ALSA support for cx2388x boards\n",
+               card->driver,devno);
+
+        err = snd_card_register(card);
+        if (err < 0) {
+                snd_card_free(card);
+                return (err);
+        }
+        snd_cx88_cards[devno] = card;
+
+        pci_set_drvdata(pci,card);
+
+        devno++;
+        return 0;
+}
+/*
+ * ALSA destructor
+ */
+static void __devexit cx88_audio_finidev(struct pci_dev *pci)
+{
+        struct cx88_audio_dev *card = pci_get_drvdata(pci);
+
+        snd_card_free((void *)card);
+
+        pci_set_drvdata(pci, NULL);
+
+        devno--;
+}
+
+/*
+ * PCI driver definition
+ */
+
+static struct pci_driver cx88_audio_pci_driver = {
+        .name     = "cx88_audio",
+        .id_table = cx88_audio_pci_tbl,
+        .probe    = cx88_audio_initdev,
+        .remove   = cx88_audio_finidev,
+        SND_PCI_PM_CALLBACKS
+};
+
+/****************************************************************************
+                                LINUX MODULE INIT
+ ****************************************************************************/
+
+/*
+ * module init
+ */
+static int cx88_audio_init(void)
+{
+        printk(KERN_INFO "cx2388x alsa driver version %d.%d.%d loaded\n",
+               (CX88_VERSION_CODE >> 16) & 0xff,
+               (CX88_VERSION_CODE >>  8) & 0xff,
+               CX88_VERSION_CODE & 0xff);
+#ifdef SNAPSHOT
+        printk(KERN_INFO "cx2388x: snapshot date %04d-%02d-%02d\n",
+               SNAPSHOT/10000, (SNAPSHOT/100)%100, SNAPSHOT%100);
+#endif
+        return pci_register_driver(&cx88_audio_pci_driver);
+}
+
+/*
+ * module remove
+ */
+static void cx88_audio_fini(void)
+{
+
+        pci_unregister_driver(&cx88_audio_pci_driver);
+}
+
+module_init(cx88_audio_init);
+module_exit(cx88_audio_fini);
+
+/* ----------------------------------------------------------- */
+/*
+ * Local variables:
+ * c-basic-offset: 8
+ * End:
+ */
diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c
index 74e57a53116f..a49062119313 100644
--- a/drivers/media/video/cx88/cx88-blackbird.c
+++ b/drivers/media/video/cx88/cx88-blackbird.c
@@ -32,10 +32,10 @@
 #include <linux/firmware.h>
 
 #include "cx88.h"
+#include <media/v4l2-common.h>
 
 MODULE_DESCRIPTION("driver for cx2388x/cx23416 based mpeg encoder cards");
-MODULE_AUTHOR("Jelle Foks <jelle@foks.8m.com>");
-MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
+MODULE_AUTHOR("Jelle Foks <jelle@foks.8m.com>, Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
 MODULE_LICENSE("GPL");
 
 static unsigned int mpegbufs = 32;
@@ -1375,7 +1375,7 @@ static int mpeg_do_ioctl(struct inode *inode, struct file *file,
         struct cx88_core  *core = dev->core;
 
         if (debug > 1)
-                cx88_print_ioctl(core->name,cmd);
+                v4l_print_ioctl(core->name,cmd);
 
         switch (cmd) {
 
@@ -1689,6 +1689,18 @@ static int __devinit blackbird_probe(struct pci_dev *pci_dev,
         memcpy(&dev->params,&default_mpeg_params,sizeof(default_mpeg_params));
         memcpy(&dev->dnr_params,&default_dnr_params,sizeof(default_dnr_params));
 
+        if (core->board == CX88_BOARD_HAUPPAUGE_ROSLYN) {
+
+                if (core->tuner_formats & V4L2_STD_525_60) {
+                        dev->height = 480;
+                        dev->params.vi_frame_rate = 30;
+                } else {
+                        dev->height = 576;
+                        dev->params.vi_frame_rate = 25;
+                }
+
+        }
+
         err = cx8802_init_common(dev);
         if (0 != err)
                 goto fail_free;
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index 951709aa88ba..a76d54503b6f 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -611,12 +611,12 @@ struct cx88_board cx88_boards[] = {
                 .input          = {{
                         .type   = CX88_VMUX_TELEVISION,
                         .vmux   = 0,
-                        .gpio0  = 0xed12,  /* internal decoder */
+                        .gpio0  = 0xed1a,
                         .gpio2  = 0x00ff,
                 },{
                         .type   = CX88_VMUX_DEBUG,
                         .vmux   = 0,
-                        .gpio0  = 0xff01,  /* mono from tuner chip */
+                        .gpio0  = 0xff01,
                 },{
                         .type   = CX88_VMUX_COMPOSITE1,
                         .vmux   = 1,
@@ -708,7 +708,7 @@ struct cx88_board cx88_boards[] = {
         },
         [CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_T] = {
                 .name           = "DViCO FusionHDTV 3 Gold-T",
-                .tuner_type     = TUNER_THOMSON_DTT7611,
+                .tuner_type     = TUNER_THOMSON_DTT761X,
                 .radio_type     = UNSET,
                 .tuner_addr     = ADDR_UNSET,
                 .radio_addr     = ADDR_UNSET,
@@ -897,6 +897,158 @@ struct cx88_board cx88_boards[] = {
                         .gpio3  = 0x0000,
                 }},
         },
+        [CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1] = {
+                .name           = "Hauppauge Nova-S-Plus DVB-S",
+                .tuner_type     = TUNER_ABSENT,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .input          = {{
+                        .type   = CX88_VMUX_DVB,
+                        .vmux   = 0,
+                },{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                }},
+                .dvb            = 1,
+        },
+        [CX88_BOARD_HAUPPAUGE_NOVASE2_S1] = {
+                .name           = "Hauppauge Nova-SE2 DVB-S",
+                .tuner_type     = TUNER_ABSENT,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .input          = {{
+                        .type   = CX88_VMUX_DVB,
+                        .vmux   = 0,
+                }},
+                .dvb            = 1,
+        },
+        [CX88_BOARD_KWORLD_DVBS_100] = {
+                .name           = "KWorld DVB-S 100",
+                .tuner_type     = TUNER_ABSENT,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .input          = {{
+                        .type   = CX88_VMUX_DVB,
+                        .vmux   = 0,
+                },{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                }},
+                .dvb            = 1,
+        },
+        [CX88_BOARD_HAUPPAUGE_HVR1100] = {
+                .name           = "Hauppauge WinTV-HVR1100 DVB-T/Hybrid",
+                .tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .tda9887_conf   = TDA9887_PRESENT,
+                .input          = {{
+                        .type   = CX88_VMUX_TELEVISION,
+                        .vmux   = 0,
+                },{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                }},
+                /* fixme: Add radio support */
+                .dvb            = 1,
+        },
+        [CX88_BOARD_HAUPPAUGE_HVR1100LP] = {
+                .name           = "Hauppauge WinTV-HVR1100 DVB-T/Hybrid (Low Profile)",
+                .tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .tda9887_conf   = TDA9887_PRESENT,
+                .input          = {{
+                        .type   = CX88_VMUX_TELEVISION,
+                        .vmux   = 0,
+                },{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                }},
+                /* fixme: Add radio support */
+                .dvb            = 1,
+        },
+        [CX88_BOARD_DNTV_LIVE_DVB_T_PRO] = {
+                .name           = "digitalnow DNTV Live! DVB-T Pro",
+                .tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .tda9887_conf   = TDA9887_PRESENT | TDA9887_PORT1_ACTIVE |
+                                  TDA9887_PORT2_ACTIVE,
+                .input          = {{
+                        .type   = CX88_VMUX_TELEVISION,
+                        .vmux   = 0,
+                        .gpio0  = 0xf80808,
+                },{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                        .gpio0  = 0xf80808,
+                },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                        .gpio0  = 0xf80808,
+                }},
+                .radio = {
+                         .type  = CX88_RADIO,
+                         .gpio0 = 0xf80808,
+                },
+                .dvb            = 1,
+        },
+        [CX88_BOARD_KWORLD_DVB_T_CX22702] = {
+                /* Kworld V-stream Xpert DVB-T with Thomson tuner */
+                /* DTT 7579 Conexant CX22702-19 Conexant CX2388x  */
+                /* Manenti Marco <marco_manenti@colman.it> */
+                .name           = "KWorld/VStream XPert DVB-T with cx22702",
+                .tuner_type     = TUNER_ABSENT,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .input          = {{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                        .gpio0  = 0x0700,
+                        .gpio2  = 0x0101,
+                },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                        .gpio0  = 0x0700,
+                        .gpio2  = 0x0101,
+                }},
+                .dvb            = 1,
+        },
+        [CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL] = {
+                .name           = "DViCO FusionHDTV DVB-T Dual Digital",
+                .tuner_type     = TUNER_ABSENT, /* No analog tuner */
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .input          = {{
+                        .type   = CX88_VMUX_COMPOSITE1,
+                        .vmux   = 1,
+                        .gpio0  = 0x000027df,
+                 },{
+                        .type   = CX88_VMUX_SVIDEO,
+                        .vmux   = 2,
+                        .gpio0  = 0x000027df,
+                }},
+                .dvb            = 1,
+        },
+
 };
 const unsigned int cx88_bcount = ARRAY_SIZE(cx88_boards);
 
@@ -1044,6 +1196,54 @@ struct cx88_subid cx88_subids[] = {
                 .subvendor = 0x1461,
                 .subdevice = 0x000a,
                 .card      = CX88_BOARD_AVERTV_303,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9200,
+                .card      = CX88_BOARD_HAUPPAUGE_NOVASE2_S1,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9201,
+                .card      = CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9202,
+                .card      = CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1,
+        },{
+                .subvendor = 0x17de,
+                .subdevice = 0x08b2,
+                .card      = CX88_BOARD_KWORLD_DVBS_100,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9400,
+                .card      = CX88_BOARD_HAUPPAUGE_HVR1100,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9402,
+                .card      = CX88_BOARD_HAUPPAUGE_HVR1100,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9800,
+                .card      = CX88_BOARD_HAUPPAUGE_HVR1100LP,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9802,
+                .card      = CX88_BOARD_HAUPPAUGE_HVR1100LP,
+        },{
+                .subvendor = 0x0070,
+                .subdevice = 0x9001,
+                .card      = CX88_BOARD_HAUPPAUGE_DVB_T1,
+        },{
+                .subvendor = 0x1822,
+                .subdevice = 0x0025,
+                .card      = CX88_BOARD_DNTV_LIVE_DVB_T_PRO,
+        },{
+                .subvendor = 0x17de,
+                .subdevice = 0x08a1,
+                .card      = CX88_BOARD_KWORLD_DVB_T_CX22702,
+        },{
+                .subvendor = 0x18ac,
+                .subdevice = 0xdb50,
+                .card      = CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL,
         },
 };
 const unsigned int cx88_idcount = ARRAY_SIZE(cx88_subids);
@@ -1075,20 +1275,19 @@ static void __devinit leadtek_eeprom(struct cx88_core *core, u8 *eeprom_data)
                core->name, core->tuner_type, eeprom_data[0]);
 }
 
-
-/* ----------------------------------------------------------------------- */
-
 static void hauppauge_eeprom(struct cx88_core *core, u8 *eeprom_data)
 {
         struct tveeprom tv;
 
         tveeprom_hauppauge_analog(&core->i2c_client, &tv, eeprom_data);
         core->tuner_type = tv.tuner_type;
+        core->tuner_formats = tv.tuner_formats;
         core->has_radio  = tv.has_radio;
 
         /* Make sure we support the board model */
         switch (tv.model)
         {
+        case 28552: /* WinTV-PVR 'Roslyn' (No IR) */
         case 90002: /* Nova-T-PCI (9002) */
         case 92001: /* Nova-S-Plus (Video and IR) */
         case 92002: /* Nova-S-Plus (Video and IR) */
@@ -1096,7 +1295,9 @@ static void hauppauge_eeprom(struct cx88_core *core, u8 *eeprom_data)
         case 90500: /* Nova-T-PCI (oem) */
         case 90501: /* Nova-T-PCI (oem/IR) */
         case 92000: /* Nova-SE2 (OEM, No Video or IR) */
-
+        case 94009: /* WinTV-HVR1100 (Video and IR Retail) */
+        case 94501: /* WinTV-HVR1100 (Video and IR OEM) */
+        case 98559: /* WinTV-HVR1100LP (Video no IR, Retail - Low Profile) */
                 /* known */
                 break;
         default:
@@ -1211,12 +1412,21 @@ void cx88_card_setup(struct cx88_core *core)
                 if (0 == core->i2c_rc)
                         leadtek_eeprom(core,eeprom);
                 break;
+        case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
+        case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
         case CX88_BOARD_HAUPPAUGE_DVB_T1:
+        case CX88_BOARD_HAUPPAUGE_HVR1100:
+        case CX88_BOARD_HAUPPAUGE_HVR1100LP:
                 if (0 == core->i2c_rc)
                         hauppauge_eeprom(core,eeprom);
                 break;
+        case CX88_BOARD_KWORLD_DVBS_100:
+                cx_write(MO_GP0_IO, 0x000007f8);
+                cx_write(MO_GP1_IO, 0x00000001);
+                break;
         case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T1:
         case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_PLUS:
+        case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL:
                 /* GPIO0:0 is hooked to mt352 reset pin */
                 cx_set(MO_GP0_IO, 0x00000101);
                 cx_clear(MO_GP0_IO, 0x00000001);
@@ -1232,6 +1442,9 @@ void cx88_card_setup(struct cx88_core *core)
                 cx_clear(MO_GP0_IO, 0x00000007);
                 cx_set(MO_GP2_IO, 0x00000101);
                 break;
+        case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
+                cx_write(MO_GP0_IO, 0x00080808);
+                break;
         case CX88_BOARD_ATI_HDTVWONDER:
                 if (0 == core->i2c_rc) {
                         /* enable tuner */
diff --git a/drivers/media/video/cx88/cx88-core.c b/drivers/media/video/cx88/cx88-core.c
index bb6eb54e19ce..9975be1aca38 100644
--- a/drivers/media/video/cx88/cx88-core.c
+++ b/drivers/media/video/cx88/cx88-core.c
@@ -34,6 +34,7 @@
 #include <linux/videodev2.h>
 
 #include "cx88.h"
+#include <media/v4l2-common.h>
 
 MODULE_DESCRIPTION("v4l2 driver module for cx2388x based TV cards");
 MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
@@ -76,60 +77,6 @@ static unsigned int cx88_devcount;
 static LIST_HEAD(cx88_devlist);
 static DECLARE_MUTEX(devlist);
 
-/* ------------------------------------------------------------------ */
-/* debug help functions                                               */
-
-static const char *v4l1_ioctls[] = {
-        "0", "CGAP", "GCHAN", "SCHAN", "GTUNER", "STUNER", "GPICT", "SPICT",
-        "CCAPTURE", "GWIN", "SWIN", "GFBUF", "SFBUF", "KEY", "GFREQ",
-        "SFREQ", "GAUDIO", "SAUDIO", "SYNC", "MCAPTURE", "GMBUF", "GUNIT",
-        "GCAPTURE", "SCAPTURE", "SPLAYMODE", "SWRITEMODE", "GPLAYINFO",
-        "SMICROCODE", "GVBIFMT", "SVBIFMT" };
-#define V4L1_IOCTLS ARRAY_SIZE(v4l1_ioctls)
-
-static const char *v4l2_ioctls[] = {
-        "QUERYCAP", "1", "ENUM_PIXFMT", "ENUM_FBUFFMT", "G_FMT", "S_FMT",
-        "G_COMP", "S_COMP", "REQBUFS", "QUERYBUF", "G_FBUF", "S_FBUF",
-        "G_WIN", "S_WIN", "PREVIEW", "QBUF", "16", "DQBUF", "STREAMON",
-        "STREAMOFF", "G_PERF", "G_PARM", "S_PARM", "G_STD", "S_STD",
-        "ENUMSTD", "ENUMINPUT", "G_CTRL", "S_CTRL", "G_TUNER", "S_TUNER",
-        "G_FREQ", "S_FREQ", "G_AUDIO", "S_AUDIO", "35", "QUERYCTRL",
-        "QUERYMENU", "G_INPUT", "S_INPUT", "ENUMCVT", "41", "42", "43",
-        "44", "45",  "G_OUTPUT", "S_OUTPUT", "ENUMOUTPUT", "G_AUDOUT",
-        "S_AUDOUT", "ENUMFX", "G_EFFECT", "S_EFFECT", "G_MODULATOR",
-        "S_MODULATOR"
-};
-#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
-
-void cx88_print_ioctl(char *name, unsigned int cmd)
-{
-        char *dir;
-
-        switch (_IOC_DIR(cmd)) {
-        case _IOC_NONE:              dir = "--"; break;
-        case _IOC_READ:              dir = "r-"; break;
-        case _IOC_WRITE:             dir = "-w"; break;
-        case _IOC_READ | _IOC_WRITE: dir = "rw"; break;
-        default:                     dir = "??"; break;
-        }
-        switch (_IOC_TYPE(cmd)) {
-        case 'v':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l1, %s, VIDIOC%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L1_IOCTLS) ?
-                       v4l1_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        case 'V':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l2, %s, VIDIOC_%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L2_IOCTLS) ?
-                       v4l2_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        default:
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (???, %s, #%d)\n",
-                       name, cmd, dir, _IOC_NR(cmd));
-        }
-}
-
-/* ------------------------------------------------------------------ */
 #define NO_SYNC_LINE (-1U)
 
 static u32* cx88_risc_field(u32 *rp, struct scatterlist *sglist,
@@ -291,9 +238,9 @@ cx88_free_buffer(struct pci_dev *pci, struct cx88_buffer *buf)
  *    channel  22    (u video)  -  2.0k
  *    channel  23    (v video)  -  2.0k
  *    channel  24    (vbi)      -  4.0k
- *    channels 25+26 (audio)    -  0.5k
+ *    channels 25+26 (audio)    -  4.0k
  *    channel  28    (mpeg)     -  4.0k
- *    TOTAL                     = 25.5k
+ *    TOTAL                     = 29.0k
  *
  * Every channel has 160 bytes control data (64 bytes instruction
  * queue and 6 CDT entries), which is close to 2k total.
@@ -359,7 +306,7 @@ struct sram_channel cx88_sram_channels[] = {
                 .ctrl_start = 0x180680,
                 .cdt        = 0x180680 + 64,
                 .fifo_start = 0x185400,
-                .fifo_size  = 0x000200,
+                .fifo_size  = 0x001000,
                 .ptr1_reg   = MO_DMA25_PTR1,
                 .ptr2_reg   = MO_DMA25_PTR2,
                 .cnt1_reg   = MO_DMA25_CNT1,
@@ -371,7 +318,7 @@ struct sram_channel cx88_sram_channels[] = {
                 .ctrl_start = 0x180720,
                 .cdt        = 0x180680 + 64,  /* same as audio IN */
                 .fifo_start = 0x185400,       /* same as audio IN */
-                .fifo_size  = 0x000200,       /* same as audio IN */
+                .fifo_size  = 0x001000,       /* same as audio IN */
                 .ptr1_reg   = MO_DMA26_PTR1,
                 .ptr2_reg   = MO_DMA26_PTR2,
                 .cnt1_reg   = MO_DMA26_CNT1,
@@ -382,7 +329,7 @@ struct sram_channel cx88_sram_channels[] = {
                 .cmds_start = 0x180200,
                 .ctrl_start = 0x1807C0,
                 .cdt        = 0x1807C0 + 64,
-                .fifo_start = 0x185600,
+                .fifo_start = 0x186400,
                 .fifo_size  = 0x001000,
                 .ptr1_reg   = MO_DMA28_PTR1,
                 .ptr2_reg   = MO_DMA28_PTR2,
@@ -848,7 +795,6 @@ int cx88_start_audio_dma(struct cx88_core *core)
 
         /* start dma */
         cx_write(MO_AUD_DMACNTRL, 0x0003); /* Up and Down fifo enable */
-
         return 0;
 }
 
@@ -1208,7 +1154,6 @@ void cx88_core_put(struct cx88_core *core, struct pci_dev *pci)
 
 /* ------------------------------------------------------------------ */
 
-EXPORT_SYMBOL(cx88_print_ioctl);
 EXPORT_SYMBOL(cx88_print_irqbits);
 
 EXPORT_SYMBOL(cx88_core_irq);
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index 99ea955f5987..42c012aaa849 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -3,7 +3,7 @@
  * device driver for Conexant 2388x based TV cards
  * MPEG Transport Stream (DVB) routines
  *
- * (c) 2004 Chris Pascoe <c.pascoe@itee.uq.edu.au>
+ * (c) 2004, 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
  * (c) 2004 Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -31,10 +31,14 @@
 
 #include "cx88.h"
 #include "dvb-pll.h"
+#include <media/v4l2-common.h>
 
 #ifdef HAVE_MT352
 # include "mt352.h"
 # include "mt352_priv.h"
+# ifdef HAVE_VP3054_I2C
+#  include "cx88-vp3054-i2c.h"
+# endif
 #endif
 #ifdef HAVE_CX22702
 # include "cx22702.h"
@@ -48,6 +52,9 @@
 #ifdef HAVE_NXT200X
 # include "nxt200x.h"
 #endif
+#ifdef HAVE_CX24123
+# include "cx24123.h"
+#endif
 
 MODULE_DESCRIPTION("driver for cx2388x based DVB cards");
 MODULE_AUTHOR("Chris Pascoe <c.pascoe@itee.uq.edu.au>");
@@ -125,6 +132,27 @@ static int dvico_fusionhdtv_demod_init(struct dvb_frontend* fe)
         return 0;
 }
 
+static int dvico_dual_demod_init(struct dvb_frontend *fe)
+{
+        static u8 clock_config []  = { CLOCK_CTL,  0x38, 0x38 };
+        static u8 reset []         = { RESET,      0x80 };
+        static u8 adc_ctl_1_cfg [] = { ADC_CTL_1,  0x40 };
+        static u8 agc_cfg []       = { AGC_TARGET, 0x28, 0x20 };
+        static u8 gpp_ctl_cfg []   = { GPP_CTL,    0x33 };
+        static u8 capt_range_cfg[] = { CAPT_RANGE, 0x32 };
+
+        mt352_write(fe, clock_config,   sizeof(clock_config));
+        udelay(200);
+        mt352_write(fe, reset,          sizeof(reset));
+        mt352_write(fe, adc_ctl_1_cfg,  sizeof(adc_ctl_1_cfg));
+
+        mt352_write(fe, agc_cfg,        sizeof(agc_cfg));
+        mt352_write(fe, gpp_ctl_cfg,    sizeof(gpp_ctl_cfg));
+        mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
+
+        return 0;
+}
+
 static int dntv_live_dvbt_demod_init(struct dvb_frontend* fe)
 {
         static u8 clock_config []  = { 0x89, 0x38, 0x39 };
@@ -172,6 +200,98 @@ static struct mt352_config dntv_live_dvbt_config = {
         .demod_init    = dntv_live_dvbt_demod_init,
         .pll_set       = mt352_pll_set,
 };
+
+static struct mt352_config dvico_fusionhdtv_dual = {
+        .demod_address = 0x0F,
+        .demod_init    = dvico_dual_demod_init,
+        .pll_set       = mt352_pll_set,
+};
+
+#ifdef HAVE_VP3054_I2C
+static int dntv_live_dvbt_pro_demod_init(struct dvb_frontend* fe)
+{
+        static u8 clock_config []  = { 0x89, 0x38, 0x38 };
+        static u8 reset []         = { 0x50, 0x80 };
+        static u8 adc_ctl_1_cfg [] = { 0x8E, 0x40 };
+        static u8 agc_cfg []       = { 0x67, 0x10, 0x20, 0x00, 0xFF, 0xFF,
+                                       0x00, 0xFF, 0x00, 0x40, 0x40 };
+        static u8 dntv_extra[]     = { 0xB5, 0x7A };
+        static u8 capt_range_cfg[] = { 0x75, 0x32 };
+
+        mt352_write(fe, clock_config,   sizeof(clock_config));
+        udelay(2000);
+        mt352_write(fe, reset,          sizeof(reset));
+        mt352_write(fe, adc_ctl_1_cfg,  sizeof(adc_ctl_1_cfg));
+
+        mt352_write(fe, agc_cfg,        sizeof(agc_cfg));
+        udelay(2000);
+        mt352_write(fe, dntv_extra,     sizeof(dntv_extra));
+        mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
+
+        return 0;
+}
+
+static int philips_fmd1216_pll_init(struct dvb_frontend *fe)
+{
+        struct cx8802_dev *dev= fe->dvb->priv;
+
+        /* this message is to set up ATC and ALC */
+        static u8 fmd1216_init[] = { 0x0b, 0xdc, 0x9c, 0xa0 };
+        struct i2c_msg msg =
+                { .addr = dev->core->pll_addr, .flags = 0,
+                  .buf = fmd1216_init, .len = sizeof(fmd1216_init) };
+        int err;
+
+        if ((err = i2c_transfer(&dev->core->i2c_adap, &msg, 1)) != 1) {
+                if (err < 0)
+                        return err;
+                else
+                        return -EREMOTEIO;
+        }
+
+        return 0;
+}
+
+static int dntv_live_dvbt_pro_pll_set(struct dvb_frontend* fe,
+                                      struct dvb_frontend_parameters* params,
+                                      u8* pllbuf)
+{
+        struct cx8802_dev *dev= fe->dvb->priv;
+        struct i2c_msg msg =
+                { .addr = dev->core->pll_addr, .flags = 0,
+                  .buf = pllbuf+1, .len = 4 };
+        int err;
+
+        /* Switch PLL to DVB mode */
+        err = philips_fmd1216_pll_init(fe);
+        if (err)
+                return err;
+
+        /* Tune PLL */
+        pllbuf[0] = dev->core->pll_addr << 1;
+        dvb_pll_configure(dev->core->pll_desc, pllbuf+1,
+                          params->frequency,
+                          params->u.ofdm.bandwidth);
+        if ((err = i2c_transfer(&dev->core->i2c_adap, &msg, 1)) != 1) {
+                printk(KERN_WARNING "cx88-dvb: %s error "
+                           "(addr %02x <- %02x, err = %i)\n",
+                           __FUNCTION__, pllbuf[0], pllbuf[1], err);
+                if (err < 0)
+                        return err;
+                else
+                        return -EREMOTEIO;
+        }
+
+        return 0;
+}
+
+static struct mt352_config dntv_live_dvbt_pro_config = {
+        .demod_address = 0x0f,
+        .no_tuner      = 1,
+        .demod_init    = dntv_live_dvbt_pro_demod_init,
+        .pll_set       = dntv_live_dvbt_pro_pll_set,
+};
+#endif
 #endif
 
 #ifdef HAVE_CX22702
@@ -188,6 +308,12 @@ static struct cx22702_config hauppauge_novat_config = {
         .pll_address   = 0x61,
         .pll_desc      = &dvb_pll_thomson_dtt759x,
 };
+static struct cx22702_config hauppauge_hvr1100_config = {
+        .demod_address = 0x63,
+        .output_mode   = CX22702_SERIAL_OUTPUT,
+        .pll_address   = 0x61,
+        .pll_desc      = &dvb_pll_fmd1216me,
+};
 #endif
 
 #ifdef HAVE_OR51132
@@ -314,6 +440,40 @@ static struct nxt200x_config ati_hdtvwonder = {
 };
 #endif
 
+#ifdef HAVE_CX24123
+static int cx24123_set_ts_param(struct dvb_frontend* fe,
+        int is_punctured)
+{
+        struct cx8802_dev *dev= fe->dvb->priv;
+        dev->ts_gen_cntrl = 0x2;
+        return 0;
+}
+
+static void cx24123_enable_lnb_voltage(struct dvb_frontend* fe, int on)
+{
+        struct cx8802_dev *dev= fe->dvb->priv;
+        struct cx88_core *core = dev->core;
+
+        if (on)
+                cx_write(MO_GP0_IO, 0x000006f9);
+        else
+                cx_write(MO_GP0_IO, 0x000006fB);
+}
+
+static struct cx24123_config hauppauge_novas_config = {
+        .demod_address          = 0x55,
+        .use_isl6421            = 1,
+        .set_ts_params          = cx24123_set_ts_param,
+};
+
+static struct cx24123_config kworld_dvbs_100_config = {
+        .demod_address          = 0x15,
+        .use_isl6421            = 0,
+        .set_ts_params          = cx24123_set_ts_param,
+        .enable_lnb_voltage     = cx24123_enable_lnb_voltage,
+};
+#endif
+
 static int dvb_register(struct cx8802_dev *dev)
 {
         /* init struct videobuf_dvb */
@@ -329,10 +489,16 @@ static int dvb_register(struct cx8802_dev *dev)
                 break;
         case CX88_BOARD_TERRATEC_CINERGY_1400_DVB_T1:
         case CX88_BOARD_CONEXANT_DVB_T1:
+        case CX88_BOARD_KWORLD_DVB_T_CX22702:
         case CX88_BOARD_WINFAST_DTV1000:
                 dev->dvb.frontend = cx22702_attach(&connexant_refboard_config,
                                                    &dev->core->i2c_adap);
                 break;
+        case CX88_BOARD_HAUPPAUGE_HVR1100:
+        case CX88_BOARD_HAUPPAUGE_HVR1100LP:
+                dev->dvb.frontend = cx22702_attach(&hauppauge_hvr1100_config,
+                                                   &dev->core->i2c_adap);
+                break;
 #endif
 #ifdef HAVE_MT352
         case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T1:
@@ -355,6 +521,24 @@ static int dvb_register(struct cx8802_dev *dev)
                 dev->dvb.frontend = mt352_attach(&dntv_live_dvbt_config,
                                                  &dev->core->i2c_adap);
                 break;
+        case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
+#ifdef HAVE_VP3054_I2C
+                dev->core->pll_addr = 0x61;
+                dev->core->pll_desc = &dvb_pll_fmd1216me;
+                dev->dvb.frontend = mt352_attach(&dntv_live_dvbt_pro_config,
+                        &((struct vp3054_i2c_state *)dev->card_priv)->adap);
+#else
+                printk("%s: built without vp3054 support\n", dev->core->name);
+#endif
+                break;
+        case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL:
+                /* The tin box says DEE1601, but it seems to be DTT7579
+                 * compatible, with a slightly different MT352 AGC gain. */
+                dev->core->pll_addr = 0x61;
+                dev->core->pll_desc = &dvb_pll_thomson_dtt7579;
+                dev->dvb.frontend = mt352_attach(&dvico_fusionhdtv_dual,
+                                                 &dev->core->i2c_adap);
+                break;
 #endif
 #ifdef HAVE_OR51132
         case CX88_BOARD_PCHDTV_HD3000:
@@ -393,7 +577,7 @@ static int dvb_register(struct cx8802_dev *dev)
                 cx_set(MO_GP0_IO, 9);
                 mdelay(200);
                 dev->core->pll_addr = 0x61;
-                dev->core->pll_desc = &dvb_pll_thomson_dtt7611;
+                dev->core->pll_desc = &dvb_pll_thomson_dtt761x;
                 dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_3_gold,
                                                     &dev->core->i2c_adap);
                 }
@@ -421,6 +605,17 @@ static int dvb_register(struct cx8802_dev *dev)
                                                  &dev->core->i2c_adap);
                 break;
 #endif
+#ifdef HAVE_CX24123
+        case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
+        case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
+                dev->dvb.frontend = cx24123_attach(&hauppauge_novas_config,
+                        &dev->core->i2c_adap);
+                break;
+        case CX88_BOARD_KWORLD_DVBS_100:
+                dev->dvb.frontend = cx24123_attach(&kworld_dvbs_100_config,
+                        &dev->core->i2c_adap);
+                break;
+#endif
         default:
                 printk("%s: The frontend of your DVB/ATSC card isn't supported yet\n",
                        dev->core->name);
@@ -473,6 +668,12 @@ static int __devinit dvb_probe(struct pci_dev *pci_dev,
         if (0 != err)
                 goto fail_free;
 
+#ifdef HAVE_VP3054_I2C
+        err = vp3054_i2c_probe(dev);
+        if (0 != err)
+                goto fail_free;
+#endif
+
         /* dvb stuff */
         printk("%s/2: cx2388x based dvb card\n", core->name);
         videobuf_queue_init(&dev->dvb.dvbq, &dvb_qops,
@@ -484,6 +685,9 @@ static int __devinit dvb_probe(struct pci_dev *pci_dev,
         err = dvb_register(dev);
         if (0 != err)
                 goto fail_fini;
+
+        /* Maintain a reference to cx88-video can query the 8802 device. */
+        core->dvbdev = dev;
         return 0;
 
  fail_fini:
@@ -499,9 +703,16 @@ static void __devexit dvb_remove(struct pci_dev *pci_dev)
 {
         struct cx8802_dev *dev = pci_get_drvdata(pci_dev);
 
+        /* Destroy any 8802 reference. */
+        dev->core->dvbdev = NULL;
+
         /* dvb */
         videobuf_dvb_unregister(&dev->dvb);
 
+#ifdef HAVE_VP3054_I2C
+        vp3054_i2c_remove(dev);
+#endif
+
         /* common */
         cx8802_fini_common(dev);
         cx88_core_put(dev->core,dev->pci);
diff --git a/drivers/media/video/cx88/cx88-i2c.c b/drivers/media/video/cx88/cx88-i2c.c
index 4a8fb161b16a..f720901e9638 100644
--- a/drivers/media/video/cx88/cx88-i2c.c
+++ b/drivers/media/video/cx88/cx88-i2c.c
@@ -30,6 +30,7 @@
 #include <asm/io.h>
 
 #include "cx88.h"
+#include <media/v4l2-common.h>
 
 static unsigned int i2c_debug = 0;
 module_param(i2c_debug, int, 0644);
@@ -135,7 +136,17 @@ void cx88_call_i2c_clients(struct cx88_core *core, unsigned int cmd, void *arg)
 {
         if (0 != core->i2c_rc)
                 return;
-        i2c_clients_command(&core->i2c_adap, cmd, arg);
+
+        if (core->dvbdev) {
+                if (core->dvbdev->dvb.frontend->ops->i2c_gate_ctrl)
+                        core->dvbdev->dvb.frontend->ops->i2c_gate_ctrl(core->dvbdev->dvb.frontend, 1);
+
+                i2c_clients_command(&core->i2c_adap, cmd, arg);
+
+                if (core->dvbdev->dvb.frontend->ops->i2c_gate_ctrl)
+                        core->dvbdev->dvb.frontend->ops->i2c_gate_ctrl(core->dvbdev->dvb.frontend, 0);
+        } else
+                i2c_clients_command(&core->i2c_adap, cmd, arg);
 }
 
 static struct i2c_algo_bit_data cx8800_i2c_algo_template = {
diff --git a/drivers/media/video/cx88/cx88-input.c b/drivers/media/video/cx88/cx88-input.c
index 461019dca901..286c85b6bdf9 100644
--- a/drivers/media/video/cx88/cx88-input.c
+++ b/drivers/media/video/cx88/cx88-input.c
@@ -5,7 +5,7 @@
  *
  * Copyright (c) 2003 Pavel Machek
  * Copyright (c) 2004 Gerd Knorr
- * Copyright (c) 2004 Chris Pascoe
+ * Copyright (c) 2004, 2005 Chris Pascoe
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -29,9 +29,8 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 
-#include <media/ir-common.h>
-
 #include "cx88.h"
+#include <media/ir-common.h>
 
 /* ---------------------------------------------------------------------- */
 
@@ -258,6 +257,114 @@ static IR_KEYTAB_TYPE ir_codes_cinergy_1400[IR_KEYTAB_SIZE] = {
 
 /* ---------------------------------------------------------------------- */
 
+/* AVERTV STUDIO 303 Remote */
+static IR_KEYTAB_TYPE ir_codes_avertv_303[IR_KEYTAB_SIZE] = {
+        [ 0x2a ] = KEY_KP1,
+        [ 0x32 ] = KEY_KP2,
+        [ 0x3a ] = KEY_KP3,
+        [ 0x4a ] = KEY_KP4,
+        [ 0x52 ] = KEY_KP5,
+        [ 0x5a ] = KEY_KP6,
+        [ 0x6a ] = KEY_KP7,
+        [ 0x72 ] = KEY_KP8,
+        [ 0x7a ] = KEY_KP9,
+        [ 0x0e ] = KEY_KP0,
+
+        [ 0x02 ] = KEY_POWER,
+        [ 0x22 ] = KEY_VIDEO,
+        [ 0x42 ] = KEY_AUDIO,
+        [ 0x62 ] = KEY_ZOOM,
+        [ 0x0a ] = KEY_TV,
+        [ 0x12 ] = KEY_CD,
+        [ 0x1a ] = KEY_TEXT,
+
+        [ 0x16 ] = KEY_SUBTITLE,
+        [ 0x1e ] = KEY_REWIND,
+        [ 0x06 ] = KEY_PRINT,
+
+        [ 0x2e ] = KEY_SEARCH,
+        [ 0x36 ] = KEY_SLEEP,
+        [ 0x3e ] = KEY_SHUFFLE,
+        [ 0x26 ] = KEY_MUTE,
+
+        [ 0x4e ] = KEY_RECORD,
+        [ 0x56 ] = KEY_PAUSE,
+        [ 0x5e ] = KEY_STOP,
+        [ 0x46 ] = KEY_PLAY,
+
+        [ 0x6e ] = KEY_RED,
+        [ 0x0b ] = KEY_GREEN,
+        [ 0x66 ] = KEY_YELLOW,
+        [ 0x03 ] = KEY_BLUE,
+
+        [ 0x76 ] = KEY_LEFT,
+        [ 0x7e ] = KEY_RIGHT,
+        [ 0x13 ] = KEY_DOWN,
+        [ 0x1b ] = KEY_UP,
+};
+
+/* ---------------------------------------------------------------------- */
+
+/* DigitalNow DNTV Live! DVB-T Pro Remote */
+static IR_KEYTAB_TYPE ir_codes_dntv_live_dvbt_pro[IR_KEYTAB_SIZE] = {
+        [ 0x16 ] = KEY_POWER,
+        [ 0x5b ] = KEY_HOME,
+
+        [ 0x55 ] = KEY_TV,              /* live tv */
+        [ 0x58 ] = KEY_TUNER,           /* digital Radio */
+        [ 0x5a ] = KEY_RADIO,           /* FM radio */
+        [ 0x59 ] = KEY_DVD,             /* dvd menu */
+        [ 0x03 ] = KEY_1,
+        [ 0x01 ] = KEY_2,
+        [ 0x06 ] = KEY_3,
+        [ 0x09 ] = KEY_4,
+        [ 0x1d ] = KEY_5,
+        [ 0x1f ] = KEY_6,
+        [ 0x0d ] = KEY_7,
+        [ 0x19 ] = KEY_8,
+        [ 0x1b ] = KEY_9,
+        [ 0x0c ] = KEY_CANCEL,
+        [ 0x15 ] = KEY_0,
+        [ 0x4a ] = KEY_CLEAR,
+        [ 0x13 ] = KEY_BACK,
+        [ 0x00 ] = KEY_TAB,
+        [ 0x4b ] = KEY_UP,
+        [ 0x4e ] = KEY_LEFT,
+        [ 0x4f ] = KEY_OK,
+        [ 0x52 ] = KEY_RIGHT,
+        [ 0x51 ] = KEY_DOWN,
+        [ 0x1e ] = KEY_VOLUMEUP,
+        [ 0x0a ] = KEY_VOLUMEDOWN,
+        [ 0x02 ] = KEY_CHANNELDOWN,
+        [ 0x05 ] = KEY_CHANNELUP,
+        [ 0x11 ] = KEY_RECORD,
+        [ 0x14 ] = KEY_PLAY,
+        [ 0x4c ] = KEY_PAUSE,
+        [ 0x1a ] = KEY_STOP,
+        [ 0x40 ] = KEY_REWIND,
+        [ 0x12 ] = KEY_FASTFORWARD,
+        [ 0x41 ] = KEY_PREVIOUSSONG,    /* replay |< */
+        [ 0x42 ] = KEY_NEXTSONG,        /* skip >| */
+        [ 0x54 ] = KEY_CAMERA,          /* capture */
+        [ 0x50 ] = KEY_LANGUAGE,        /* sap */
+        [ 0x47 ] = KEY_TV2,             /* pip */
+        [ 0x4d ] = KEY_SCREEN,
+        [ 0x43 ] = KEY_SUBTITLE,
+        [ 0x10 ] = KEY_MUTE,
+        [ 0x49 ] = KEY_AUDIO,           /* l/r */
+        [ 0x07 ] = KEY_SLEEP,
+        [ 0x08 ] = KEY_VIDEO,           /* a/v */
+        [ 0x0e ] = KEY_PREVIOUS,        /* recall */
+        [ 0x45 ] = KEY_ZOOM,            /* zoom + */
+        [ 0x46 ] = KEY_ANGLE,           /* zoom - */
+        [ 0x56 ] = KEY_RED,
+        [ 0x57 ] = KEY_GREEN,
+        [ 0x5c ] = KEY_YELLOW,
+        [ 0x5d ] = KEY_BLUE,
+};
+
+/* ---------------------------------------------------------------------- */
+
 struct cx88_IR {
         struct cx88_core *core;
         struct input_dev *input;
@@ -266,7 +373,7 @@ struct cx88_IR {
         char phys[32];
 
         /* sample from gpio pin 16 */
-        int sampling;
+        u32 sampling;
         u32 samples[16];
         int scount;
         unsigned long release;
@@ -384,10 +491,13 @@ int cx88_ir_init(struct cx88_core *core, struct pci_dev *pci)
         case CX88_BOARD_TERRATEC_CINERGY_1400_DVB_T1:
                 ir_codes = ir_codes_cinergy_1400;
                 ir_type = IR_TYPE_PD;
-                ir->sampling = 1;
+                ir->sampling = 0xeb04; /* address */
                 break;
         case CX88_BOARD_HAUPPAUGE:
         case CX88_BOARD_HAUPPAUGE_DVB_T1:
+        case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
+        case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
+        case CX88_BOARD_HAUPPAUGE_HVR1100:
                 ir_codes = ir_codes_hauppauge_new;
                 ir_type = IR_TYPE_RC5;
                 ir->sampling = 1;
@@ -427,6 +537,19 @@ int cx88_ir_init(struct cx88_core *core, struct pci_dev *pci)
                 ir->mask_keyup = 0x40;
                 ir->polling = 1; /* ms */
                 break;
+        case CX88_BOARD_AVERTV_303:
+        case CX88_BOARD_AVERTV_STUDIO_303:
+                ir_codes         = ir_codes_avertv_303;
+                ir->gpio_addr    = MO_GP2_IO;
+                ir->mask_keycode = 0xfb;
+                ir->mask_keydown = 0x02;
+                ir->polling      = 50; /* ms */
+                break;
+        case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
+                ir_codes = ir_codes_dntv_live_dvbt_pro;
+                ir_type = IR_TYPE_PD;
+                ir->sampling = 0xff00; /* address */
+                break;
         }
 
         if (NULL == ir_codes) {
@@ -484,6 +607,10 @@ int cx88_ir_fini(struct cx88_core *core)
         if (NULL == ir)
                 return 0;
 
+        if (ir->sampling) {
+                cx_write(MO_DDSCFG_IO, 0x0);
+                core->pci_irqmask &= ~(1 << 18);
+        }
         if (ir->polling) {
                 del_timer(&ir->timer);
                 flush_scheduled_work();
@@ -535,6 +662,7 @@ void cx88_ir_irq(struct cx88_core *core)
         /* decode it */
         switch (core->board) {
         case CX88_BOARD_TERRATEC_CINERGY_1400_DVB_T1:
+        case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
                 ircode = ir_decode_pulsedistance(ir->samples, ir->scount, 1, 4);
 
                 if (ircode == 0xffffffff) { /* decoding error */
@@ -550,7 +678,7 @@ void cx88_ir_irq(struct cx88_core *core)
                         break;
                 }
 
-                if ((ircode & 0xffff) != 0xeb04) { /* wrong address */
+                if ((ircode & 0xffff) != (ir->sampling & 0xffff)) { /* wrong address */
                         ir_dprintk("pulse distance decoded wrong address\n");
                         break;
                 }
@@ -567,6 +695,8 @@ void cx88_ir_irq(struct cx88_core *core)
                 break;
         case CX88_BOARD_HAUPPAUGE:
         case CX88_BOARD_HAUPPAUGE_DVB_T1:
+        case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
+        case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
                 ircode = ir_decode_biphase(ir->samples, ir->scount, 5, 7);
                 ir_dprintk("biphase decoded: %x\n", ircode);
                 if ((ircode & 0xfffff000) != 0x3000)
diff --git a/drivers/media/video/cx88/cx88-mpeg.c b/drivers/media/video/cx88/cx88-mpeg.c
index 35e6d0c2b872..c79cc1d2bf8b 100644
--- a/drivers/media/video/cx88/cx88-mpeg.c
+++ b/drivers/media/video/cx88/cx88-mpeg.c
@@ -78,6 +78,11 @@ static int cx8802_start_dma(struct cx8802_dev    *dev,
                 case CX88_BOARD_DVICO_FUSIONHDTV_5_GOLD:
                         cx_write(TS_SOP_STAT, 1<<13);
                         break;
+                case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
+                case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
+                        cx_write(MO_PINMUX_IO, 0x88); /* Enable MPEG parallel IO and video signal pins */
+                        udelay(100);
+                        break;
                 default:
                         cx_write(TS_SOP_STAT, 0x00);
                         break;
diff --git a/drivers/media/video/cx88/cx88-tvaudio.c b/drivers/media/video/cx88/cx88-tvaudio.c
index a1b120c8a9b5..24118e43e73a 100644
--- a/drivers/media/video/cx88/cx88-tvaudio.c
+++ b/drivers/media/video/cx88/cx88-tvaudio.c
@@ -132,14 +132,22 @@ static void set_audio_finish(struct cx88_core *core, u32 ctl)
 {
         u32 volume;
 
+#ifndef USING_CX88_ALSA
         /* restart dma; This avoids buzz in NICAM and is good in others  */
         cx88_stop_audio_dma(core);
+#endif
         cx_write(AUD_RATE_THRES_DMD, 0x000000C0);
+#ifndef USING_CX88_ALSA
         cx88_start_audio_dma(core);
+#endif
 
         if (cx88_boards[core->board].blackbird) {
                 /* sets sound input from external adc */
-                cx_set(AUD_CTL, EN_I2SIN_ENABLE);
+                if (core->board == CX88_BOARD_HAUPPAUGE_ROSLYN)
+                        cx_clear(AUD_CTL, EN_I2SIN_ENABLE);
+                else
+                        cx_set(AUD_CTL, EN_I2SIN_ENABLE);
+
                 cx_write(AUD_I2SINPUTCNTL, 4);
                 cx_write(AUD_BAUDRATE, 1);
                 /* 'pass-thru mode': this enables the i2s output to the mpeg encoder */
diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 24a48f8a48c1..9a02515fe18b 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -33,6 +33,7 @@
 #include <asm/div64.h>
 
 #include "cx88.h"
+#include <media/v4l2-common.h>
 
 /* Include V4L1 specific functions. Should be removed soon */
 #include <linux/videodev.h>
@@ -240,7 +241,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                         .minimum       = 0,
                         .maximum       = 0xff,
                         .step          = 1,
-                        .default_value = 0,
+                        .default_value = 0x3f,
                         .type          = V4L2_CTRL_TYPE_INTEGER,
                 },
                 .off                   = 0,
@@ -271,7 +272,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                         .minimum       = 0,
                         .maximum       = 0xff,
                         .step          = 1,
-                        .default_value = 0,
+                        .default_value = 0x7f,
                         .type          = V4L2_CTRL_TYPE_INTEGER,
                 },
                 .off                   = 0,
@@ -285,6 +286,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                         .name          = "Mute",
                         .minimum       = 0,
                         .maximum       = 1,
+                        .default_value = 1,
                         .type          = V4L2_CTRL_TYPE_BOOLEAN,
                 },
                 .reg                   = AUD_VOL_CTL,
@@ -298,7 +300,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                         .minimum       = 0,
                         .maximum       = 0x3f,
                         .step          = 1,
-                        .default_value = 0,
+                        .default_value = 0x1f,
                         .type          = V4L2_CTRL_TYPE_INTEGER,
                 },
                 .reg                   = AUD_VOL_CTL,
@@ -917,6 +919,9 @@ static int get_control(struct cx88_core *core, struct v4l2_control *ctl)
                 ctl->value = ((value + (c->off << c->shift)) & c->mask) >> c->shift;
                 break;
         }
+        printk("get_control id=0x%X reg=0x%02x val=0x%02x (mask 0x%02x)%s\n",
+                                        ctl->id, c->reg, ctl->value,
+                                        c->mask, c->sreg ? " [shadowed]" : "");
         return 0;
 }
 
@@ -925,13 +930,13 @@ static int set_control(struct cx88_core *core, struct v4l2_control *ctl)
 {
         /* struct cx88_core *core = dev->core; */
         struct cx88_ctrl *c = NULL;
-        u32 v_sat_value;
-        u32 value;
+        u32 value,mask;
         int i;
-
-        for (i = 0; i < CX8800_CTLS; i++)
-                if (cx8800_ctls[i].v.id == ctl->id)
+        for (i = 0; i < CX8800_CTLS; i++) {
+                if (cx8800_ctls[i].v.id == ctl->id) {
                         c = &cx8800_ctls[i];
+                }
+        }
         if (NULL == c)
                 return -EINVAL;
 
@@ -939,6 +944,7 @@ static int set_control(struct cx88_core *core, struct v4l2_control *ctl)
                 ctl->value = c->v.minimum;
         if (ctl->value > c->v.maximum)
                 ctl->value = c->v.maximum;
+        mask=c->mask;
         switch (ctl->id) {
         case V4L2_CID_AUDIO_BALANCE:
                 value = (ctl->value < 0x40) ? (0x40 - ctl->value) : ctl->value;
@@ -948,56 +954,44 @@ static int set_control(struct cx88_core *core, struct v4l2_control *ctl)
                 break;
         case V4L2_CID_SATURATION:
                 /* special v_sat handling */
-                v_sat_value = ctl->value - (0x7f - 0x5a);
-                if (v_sat_value > 0xff)
-                        v_sat_value = 0xff;
-                if (v_sat_value < 0x00)
-                        v_sat_value = 0x00;
-                cx_andor(MO_UV_SATURATION, 0xff00, v_sat_value << 8);
-                /* fall through to default route for u_sat */
+
+                value = ((ctl->value - c->off) << c->shift) & c->mask;
+
+                if (core->tvnorm->id & V4L2_STD_SECAM) {
+                        /* For SECAM, both U and V sat should be equal */
+                        value=value<<8|value;
+                } else {
+                        /* Keeps U Saturation proportional to V Sat */
+                        value=(value*0x5a)/0x7f<<8|value;
+                }
+                mask=0xffff;
+                break;
         default:
                 value = ((ctl->value - c->off) << c->shift) & c->mask;
                 break;
         }
-        dprintk(1,"set_control id=0x%X reg=0x%x val=0x%x%s\n",
-                ctl->id, c->reg, value, c->sreg ? " [shadowed]" : "");
+        printk("set_control id=0x%X reg=0x%02x val=0x%02x (mask 0x%02x)%s\n",
+                                        ctl->id, c->reg, value,
+                                        mask, c->sreg ? " [shadowed]" : "");
         if (c->sreg) {
-                cx_sandor(c->sreg, c->reg, c->mask, value);
+                cx_sandor(c->sreg, c->reg, mask, value);
         } else {
-                cx_andor(c->reg, c->mask, value);
+                cx_andor(c->reg, mask, value);
         }
         return 0;
 }
 
-/* static void init_controls(struct cx8800_dev *dev) */
 static void init_controls(struct cx88_core *core)
 {
-        static struct v4l2_control mute = {
-                .id    = V4L2_CID_AUDIO_MUTE,
-                .value = 1,
-        };
-        static struct v4l2_control volume = {
-                .id    = V4L2_CID_AUDIO_VOLUME,
-                .value = 0x3f,
-        };
-        static struct v4l2_control hue = {
-                .id    = V4L2_CID_HUE,
-                .value = 0x80,
-        };
-        static struct v4l2_control contrast = {
-                .id    = V4L2_CID_CONTRAST,
-                .value = 0x80,
-        };
-        static struct v4l2_control brightness = {
-                .id    = V4L2_CID_BRIGHTNESS,
-                .value = 0x80,
-        };
+        struct v4l2_control ctrl;
+        int i;
 
-        set_control(core,&mute);
-        set_control(core,&volume);
-        set_control(core,&hue);
-        set_control(core,&contrast);
-        set_control(core,&brightness);
+        for (i = 0; i < CX8800_CTLS; i++) {
+                ctrl.id=cx8800_ctls[i].v.id;
+                ctrl.value=cx8800_ctls[i].v.default_value
+                                +cx8800_ctls[i].off;
+                set_control(core, &ctrl);
+        }
 }
 
 /* ------------------------------------------------------------------ */
@@ -1125,7 +1119,7 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
         int err;
 
         if (video_debug > 1)
-                cx88_print_ioctl(core->name,cmd);
+                v4l_print_ioctl(core->name,cmd);
         switch (cmd) {
 
         /* --- capabilities ------------------------------------------ */
@@ -1261,7 +1255,7 @@ int cx88_do_ioctl(struct inode *inode, struct file *file, int radio,
 
         dprintk( 1, "CORE IOCTL: 0x%x\n", cmd );
         if (video_debug > 1)
-                cx88_print_ioctl(core->name,cmd);
+                v4l_print_ioctl(core->name,cmd);
 
         switch (cmd) {
         /* ---------- tv norms ---------- */
@@ -1481,7 +1475,7 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
         struct cx88_core  *core = dev->core;
 
         if (video_debug > 1)
-                cx88_print_ioctl(core->name,cmd);
+                v4l_print_ioctl(core->name,cmd);
 
         switch (cmd) {
         case VIDIOC_QUERYCAP:
@@ -1740,6 +1734,7 @@ static struct file_operations video_fops =
         .poll          = video_poll,
         .mmap          = video_mmap,
         .ioctl         = video_ioctl,
+        .compat_ioctl  = v4l_compat_ioctl32,
         .llseek        = no_llseek,
 };
 
@@ -1767,6 +1762,7 @@ static struct file_operations radio_fops =
         .open          = video_open,
         .release       = video_release,
         .ioctl         = radio_ioctl,
+        .compat_ioctl  = v4l_compat_ioctl32,
         .llseek        = no_llseek,
 };
 
@@ -1928,8 +1924,8 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
 
         /* initial device configuration */
         down(&core->lock);
-        init_controls(core);
         cx88_set_tvnorm(core,tvnorms);
+        init_controls(core);
         video_mux(core,0);
         up(&core->lock);
 
diff --git a/drivers/media/video/cx88/cx88-vp3054-i2c.c b/drivers/media/video/cx88/cx88-vp3054-i2c.c
new file mode 100644
index 000000000000..372cd29cedbd
--- /dev/null
+++ b/drivers/media/video/cx88/cx88-vp3054-i2c.c
@@ -0,0 +1,173 @@
+/*
+
+    cx88-vp3054-i2c.c  --  support for the secondary I2C bus of the
+                           DNTV Live! DVB-T Pro (VP-3054), wired as:
+                           GPIO[0] -> SCL, GPIO[1] -> SDA
+
+    (c) 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/init.h>
+
+#include <asm/io.h>
+
+#include "cx88.h"
+#include "cx88-vp3054-i2c.h"
+
+
+/* ----------------------------------------------------------------------- */
+
+static void vp3054_bit_setscl(void *data, int state)
+{
+        struct cx8802_dev *dev = data;
+        struct cx88_core *core = dev->core;
+        struct vp3054_i2c_state *vp3054_i2c = dev->card_priv;
+
+        if (state) {
+                vp3054_i2c->state |=  0x0001;   /* SCL high */
+                vp3054_i2c->state &= ~0x0100;   /* external pullup */
+        } else {
+                vp3054_i2c->state &= ~0x0001;   /* SCL low */
+                vp3054_i2c->state |=  0x0100;   /* drive pin */
+        }
+        cx_write(MO_GP0_IO, 0x010000 | vp3054_i2c->state);
+        cx_read(MO_GP0_IO);
+}
+
+static void vp3054_bit_setsda(void *data, int state)
+{
+        struct cx8802_dev *dev = data;
+        struct cx88_core *core = dev->core;
+        struct vp3054_i2c_state *vp3054_i2c = dev->card_priv;
+
+        if (state) {
+                vp3054_i2c->state |=  0x0002;   /* SDA high */
+                vp3054_i2c->state &= ~0x0200;   /* tristate pin */
+        } else {
+                vp3054_i2c->state &= ~0x0002;   /* SDA low */
+                vp3054_i2c->state |=  0x0200;   /* drive pin */
+        }
+        cx_write(MO_GP0_IO, 0x020000 | vp3054_i2c->state);
+        cx_read(MO_GP0_IO);
+}
+
+static int vp3054_bit_getscl(void *data)
+{
+        struct cx8802_dev *dev = data;
+        struct cx88_core *core = dev->core;
+        u32 state;
+
+        state = cx_read(MO_GP0_IO);
+        return (state & 0x01) ? 1 : 0;
+}
+
+static int vp3054_bit_getsda(void *data)
+{
+        struct cx8802_dev *dev = data;
+        struct cx88_core *core = dev->core;
+        u32 state;
+
+        state = cx_read(MO_GP0_IO);
+        return (state & 0x02) ? 1 : 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static struct i2c_algo_bit_data vp3054_i2c_algo_template = {
+        .setsda  = vp3054_bit_setsda,
+        .setscl  = vp3054_bit_setscl,
+        .getsda  = vp3054_bit_getsda,
+        .getscl  = vp3054_bit_getscl,
+        .udelay  = 16,
+        .mdelay  = 10,
+        .timeout = 200,
+};
+
+/* ----------------------------------------------------------------------- */
+
+static struct i2c_adapter vp3054_i2c_adap_template = {
+        .name              = "cx2388x",
+        .owner             = THIS_MODULE,
+        .id                = I2C_HW_B_CX2388x,
+};
+
+static struct i2c_client vp3054_i2c_client_template = {
+        .name   = "VP-3054",
+};
+
+int vp3054_i2c_probe(struct cx8802_dev *dev)
+{
+        struct cx88_core *core = dev->core;
+        struct vp3054_i2c_state *vp3054_i2c;
+        int rc;
+
+        if (core->board != CX88_BOARD_DNTV_LIVE_DVB_T_PRO)
+                return 0;
+
+        dev->card_priv = kzalloc(sizeof(*vp3054_i2c), GFP_KERNEL);
+        if (dev->card_priv == NULL)
+                return -ENOMEM;
+        vp3054_i2c = dev->card_priv;
+
+        memcpy(&vp3054_i2c->adap, &vp3054_i2c_adap_template,
+               sizeof(vp3054_i2c->adap));
+        memcpy(&vp3054_i2c->algo, &vp3054_i2c_algo_template,
+               sizeof(vp3054_i2c->algo));
+        memcpy(&vp3054_i2c->client, &vp3054_i2c_client_template,
+               sizeof(vp3054_i2c->client));
+
+        vp3054_i2c->adap.class |= I2C_CLASS_TV_DIGITAL;
+
+        vp3054_i2c->adap.dev.parent = &dev->pci->dev;
+        strlcpy(vp3054_i2c->adap.name, core->name,
+                sizeof(vp3054_i2c->adap.name));
+        vp3054_i2c->algo.data = dev;
+        i2c_set_adapdata(&vp3054_i2c->adap, dev);
+        vp3054_i2c->adap.algo_data = &vp3054_i2c->algo;
+        vp3054_i2c->client.adapter = &vp3054_i2c->adap;
+
+        vp3054_bit_setscl(dev,1);
+        vp3054_bit_setsda(dev,1);
+
+        rc = i2c_bit_add_bus(&vp3054_i2c->adap);
+        if (0 != rc) {
+                printk("%s: vp3054_i2c register FAILED\n", core->name);
+
+                kfree(dev->card_priv);
+                dev->card_priv = NULL;
+        }
+
+        return rc;
+}
+
+void vp3054_i2c_remove(struct cx8802_dev *dev)
+{
+        struct vp3054_i2c_state *vp3054_i2c = dev->card_priv;
+
+        if (vp3054_i2c == NULL ||
+            dev->core->board != CX88_BOARD_DNTV_LIVE_DVB_T_PRO)
+                return;
+
+        i2c_bit_del_bus(&vp3054_i2c->adap);
+        kfree(vp3054_i2c);
+}
+
+EXPORT_SYMBOL(vp3054_i2c_probe);
+EXPORT_SYMBOL(vp3054_i2c_remove);
diff --git a/drivers/media/video/cx88/cx88-vp3054-i2c.h b/drivers/media/video/cx88/cx88-vp3054-i2c.h
new file mode 100644
index 000000000000..b7a0a04d2423
--- /dev/null
+++ b/drivers/media/video/cx88/cx88-vp3054-i2c.h
@@ -0,0 +1,35 @@
+/*
+
+    cx88-vp3054-i2c.h  --  support for the secondary I2C bus of the
+                           DNTV Live! DVB-T Pro (VP-3054), wired as:
+                           GPIO[0] -> SCL, GPIO[1] -> SDA
+
+    (c) 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
+/* ----------------------------------------------------------------------- */
+struct vp3054_i2c_state {
+        struct i2c_adapter         adap;
+        struct i2c_algo_bit_data   algo;
+        struct i2c_client          client;
+        u32                        state;
+};
+
+/* ----------------------------------------------------------------------- */
+int  vp3054_i2c_probe(struct cx8802_dev *dev);
+void vp3054_i2c_remove(struct cx8802_dev *dev);
diff --git a/drivers/media/video/cx88/cx88.h b/drivers/media/video/cx88/cx88.h
index 77beafc5c327..e9fd55b57fa6 100644
--- a/drivers/media/video/cx88/cx88.h
+++ b/drivers/media/video/cx88/cx88.h
@@ -179,6 +179,14 @@ extern struct sram_channel cx88_sram_channels[];
 #define CX88_BOARD_ATI_HDTVWONDER          34
 #define CX88_BOARD_WINFAST_DTV1000         35
 #define CX88_BOARD_AVERTV_303              36
+#define CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1  37
+#define CX88_BOARD_HAUPPAUGE_NOVASE2_S1    38
+#define CX88_BOARD_KWORLD_DVBS_100         39
+#define CX88_BOARD_HAUPPAUGE_HVR1100       40
+#define CX88_BOARD_HAUPPAUGE_HVR1100LP     41
+#define CX88_BOARD_DNTV_LIVE_DVB_T_PRO     42
+#define CX88_BOARD_KWORLD_DVB_T_CX22702    43
+#define CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL 44
 
 enum cx88_itype {
         CX88_VMUX_COMPOSITE1 = 1,
@@ -280,6 +288,9 @@ struct cx88_core {
         unsigned int               tda9887_conf;
         unsigned int               has_radio;
 
+        /* Supported V4L _STD_ tuner formats */
+        unsigned int               tuner_formats;
+
         /* config info -- dvb */
         struct dvb_pll_desc        *pll_desc;
         unsigned int               pll_addr;
@@ -301,6 +312,9 @@ struct cx88_core {
 
         /* various v4l controls */
         u32                        freq;
+
+        /* cx88-video needs to access cx8802 for hybrid tuner pll access. */
+        struct cx8802_dev          *dvbdev;
 };
 
 struct cx8800_dev;
@@ -411,6 +425,8 @@ struct cx8802_dev {
         struct videobuf_dvb        dvb;
         void*                      fe_handle;
         int                        (*fe_release)(void *handle);
+
+        void                       *card_priv;
         /* for switching modulation types */
         unsigned char              ts_gen_cntrl;
 
@@ -447,7 +463,6 @@ struct cx8802_dev {
 
 extern void cx88_print_irqbits(char *name, char *tag, char **strings,
                                u32 bits, u32 mask);
-extern void cx88_print_ioctl(char *name, unsigned int cmd);
 
 extern int cx88_core_irq(struct cx88_core *core, u32 status);
 extern void cx88_wakeup(struct cx88_core *core,
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index 57779e63f35d..58f7b4194a0d 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -30,6 +30,7 @@
 #include <media/tuner.h>
 #include <media/audiochip.h>
 #include <media/tveeprom.h>
+#include <media/v4l2-common.h>
 #include "msp3400.h"
 
 #include "em28xx.h"
@@ -261,7 +262,6 @@ void em28xx_card_setup(struct em28xx *dev)
         /* request some modules */
         if (dev->model == EM2820_BOARD_HAUPPAUGE_WINTV_USB_2) {
                 struct tveeprom tv;
-                struct v4l2_audioout ao;
 #ifdef CONFIG_MODULES
                 request_module("tveeprom");
                 request_module("ir-kbd-i2c");
@@ -274,12 +274,8 @@ void em28xx_card_setup(struct em28xx *dev)
 
                 dev->tuner_type= tv.tuner_type;
                 if (tv.audio_processor == AUDIO_CHIP_MSP34XX) {
+                        dev->i2s_speed=2048000;
                         dev->has_msp34xx=1;
-                        memset (&ao,0,sizeof(ao));
-
-                        ao.index=2;
-                        ao.mode=V4L2_AUDMODE_32BITS;
-                        em28xx_i2c_call_clients(dev, VIDIOC_S_AUDOUT, &ao);
                 } else
                         dev->has_msp34xx=0;
         }
diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index 0cfe75416ec6..dff3893f32fd 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -32,7 +32,7 @@
 
 /* #define ENABLE_DEBUG_ISOC_FRAMES */
 
-static unsigned int core_debug;
+static unsigned int core_debug = 0;
 module_param(core_debug,int,0644);
 MODULE_PARM_DESC(core_debug,"enable debug messages [core]");
 
@@ -41,7 +41,7 @@ MODULE_PARM_DESC(core_debug,"enable debug messages [core]");
                 printk(KERN_INFO "%s %s :"fmt, \
                          dev->name, __FUNCTION__ , ##arg); } while (0)
 
-static unsigned int reg_debug;
+static unsigned int reg_debug = 0;
 module_param(reg_debug,int,0644);
 MODULE_PARM_DESC(reg_debug,"enable debug messages [URB reg]");
 
@@ -50,7 +50,7 @@ MODULE_PARM_DESC(reg_debug,"enable debug messages [URB reg]");
                 printk(KERN_INFO "%s %s :"fmt, \
                          dev->name, __FUNCTION__ , ##arg); } while (0)
 
-static unsigned int isoc_debug;
+static unsigned int isoc_debug = 0;
 module_param(isoc_debug,int,0644);
 MODULE_PARM_DESC(isoc_debug,"enable debug messages [isoc transfers]");
 
@@ -63,59 +63,6 @@ static int alt = EM28XX_PINOUT;
 module_param(alt, int, 0644);
 MODULE_PARM_DESC(alt, "alternate setting to use for video endpoint");
 
-/* ------------------------------------------------------------------ */
-/* debug help functions                                               */
-
-static const char *v4l1_ioctls[] = {
-        "0", "CGAP", "GCHAN", "SCHAN", "GTUNER", "STUNER", "GPICT", "SPICT",
-        "CCAPTURE", "GWIN", "SWIN", "GFBUF", "SFBUF", "KEY", "GFREQ",
-        "SFREQ", "GAUDIO", "SAUDIO", "SYNC", "MCAPTURE", "GMBUF", "GUNIT",
-        "GCAPTURE", "SCAPTURE", "SPLAYMODE", "SWRITEMODE", "GPLAYINFO",
-        "SMICROCODE", "GVBIFMT", "SVBIFMT" };
-#define V4L1_IOCTLS ARRAY_SIZE(v4l1_ioctls)
-
-static const char *v4l2_ioctls[] = {
-        "QUERYCAP", "1", "ENUM_PIXFMT", "ENUM_FBUFFMT", "G_FMT", "S_FMT",
-        "G_COMP", "S_COMP", "REQBUFS", "QUERYBUF", "G_FBUF", "S_FBUF",
-        "G_WIN", "S_WIN", "PREVIEW", "QBUF", "16", "DQBUF", "STREAMON",
-        "STREAMOFF", "G_PERF", "G_PARM", "S_PARM", "G_STD", "S_STD",
-        "ENUMSTD", "ENUMINPUT", "G_CTRL", "S_CTRL", "G_TUNER", "S_TUNER",
-        "G_FREQ", "S_FREQ", "G_AUDIO", "S_AUDIO", "35", "QUERYCTRL",
-        "QUERYMENU", "G_INPUT", "S_INPUT", "ENUMCVT", "41", "42", "43",
-        "44", "45",  "G_OUTPUT", "S_OUTPUT", "ENUMOUTPUT", "G_AUDOUT",
-        "S_AUDOUT", "ENUMFX", "G_EFFECT", "S_EFFECT", "G_MODULATOR",
-        "S_MODULATOR"
-};
-#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
-
-void em28xx_print_ioctl(char *name, unsigned int cmd)
-{
-        char *dir;
-
-        switch (_IOC_DIR(cmd)) {
-        case _IOC_NONE:              dir = "--"; break;
-        case _IOC_READ:              dir = "r-"; break;
-        case _IOC_WRITE:             dir = "-w"; break;
-        case _IOC_READ | _IOC_WRITE: dir = "rw"; break;
-        default:                     dir = "??"; break;
-        }
-        switch (_IOC_TYPE(cmd)) {
-        case 'v':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l1, %s, VIDIOC%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L1_IOCTLS) ?
-                       v4l1_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        case 'V':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l2, %s, VIDIOC_%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L2_IOCTLS) ?
-                       v4l2_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        default:
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (???, %s, #%d)\n",
-                       name, cmd, dir, _IOC_NR(cmd));
-        }
-}
-
 
 /*
  * em28xx_request_buffers()
@@ -126,7 +73,7 @@ u32 em28xx_request_buffers(struct em28xx *dev, u32 count)
         const size_t imagesize = PAGE_ALIGN(dev->frame_size);   /*needs to be page aligned cause the buffers can be mapped individually! */
         void *buff = NULL;
         u32 i;
-        em28xx_coredbg("requested %i buffers with size %zd", count, imagesize);
+        em28xx_coredbg("requested %i buffers with size %zi", count, imagesize);
         if (count > EM28XX_NUM_FRAMES)
                 count = EM28XX_NUM_FRAMES;
 
diff --git a/drivers/media/video/em28xx/em28xx-i2c.c b/drivers/media/video/em28xx/em28xx-i2c.c
index d14bcf4ceaea..0591a705b7a1 100644
--- a/drivers/media/video/em28xx/em28xx-i2c.c
+++ b/drivers/media/video/em28xx/em28xx-i2c.c
@@ -28,6 +28,7 @@
 #include <linux/video_decoder.h>
 
 #include "em28xx.h"
+#include <media/v4l2-common.h>
 #include <media/tuner.h>
 
 /* ----------------------------------------------------------- */
@@ -486,9 +487,7 @@ static struct i2c_adapter em28xx_adap_template = {
         .inc_use = inc_use,
         .dec_use = dec_use,
 #endif
-#ifdef I2C_CLASS_TV_ANALOG
         .class = I2C_CLASS_TV_ANALOG,
-#endif
         .name = "em28xx",
         .id = I2C_HW_B_EM28XX,
         .algo = &em28xx_algo,
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 3a56120397ae..fdc255918dde 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -32,6 +32,7 @@
 
 #include "em28xx.h"
 #include <media/tuner.h>
+#include <media/v4l2-common.h>
 
 #define DRIVER_AUTHOR "Ludovico Cavedon <cavedon@sssup.it>, " \
                       "Markus Rechberger <mrechberger@gmail.com>, " \
@@ -106,8 +107,32 @@ static const unsigned char saa7114_i2c_init[] = {
 #define TVNORMS ARRAY_SIZE(tvnorms)
 
 /* supported controls */
+/* Common to all boards */
 static struct v4l2_queryctrl em28xx_qctrl[] = {
         {
+                .id = V4L2_CID_AUDIO_VOLUME,
+                .type = V4L2_CTRL_TYPE_INTEGER,
+                .name = "Volume",
+                .minimum = 0x0,
+                .maximum = 0x1f,
+                .step = 0x1,
+                .default_value = 0x1f,
+                .flags = 0,
+        },{
+                .id = V4L2_CID_AUDIO_MUTE,
+                .type = V4L2_CTRL_TYPE_BOOLEAN,
+                .name = "Mute",
+                .minimum = 0,
+                .maximum = 1,
+                .step = 1,
+                .default_value = 1,
+                .flags = 0,
+        }
+};
+
+/* FIXME: These are specific to saa711x - should be moved to its code */
+static struct v4l2_queryctrl saa711x_qctrl[] = {
+        {
                 .id = V4L2_CID_BRIGHTNESS,
                 .type = V4L2_CTRL_TYPE_INTEGER,
                 .name = "Brightness",
@@ -135,24 +160,6 @@ static struct v4l2_queryctrl em28xx_qctrl[] = {
                 .default_value = 0x10,
                 .flags = 0,
         },{
-                .id = V4L2_CID_AUDIO_VOLUME,
-                .type = V4L2_CTRL_TYPE_INTEGER,
-                .name = "Volume",
-                .minimum = 0x0,
-                .maximum = 0x1f,
-                .step = 0x1,
-                .default_value = 0x1f,
-                .flags = 0,
-        },{
-                .id = V4L2_CID_AUDIO_MUTE,
-                .type = V4L2_CTRL_TYPE_BOOLEAN,
-                .name = "Mute",
-                .minimum = 0,
-                .maximum = 1,
-                .step = 1,
-                .default_value = 1,
-                .flags = 0,
-        },{
                 .id = V4L2_CID_RED_BALANCE,
                 .type = V4L2_CTRL_TYPE_INTEGER,
                 .name = "Red chroma balance",
@@ -179,7 +186,7 @@ static struct v4l2_queryctrl em28xx_qctrl[] = {
                 .step = 0x1,
                 .default_value = 0x20,
                 .flags = 0,
-         }
+        }
 };
 
 static struct usb_driver em28xx_usb_driver;
@@ -280,6 +287,8 @@ static void video_mux(struct em28xx *dev, int index)
         em28xx_videodbg("Setting input index=%d, vmux=%d, amux=%d\n",index,input,dev->ctl_ainput);
 
         if (dev->has_msp34xx) {
+                if (dev->i2s_speed)
+                        em28xx_i2c_call_clients(dev, VIDIOC_INT_I2S_CLOCK_FREQ, &dev->i2s_speed);
                 em28xx_i2c_call_clients(dev, VIDIOC_S_AUDIO, &dev->ctl_ainput);
                 ainput = EM28XX_AUDIO_SRC_TUNER;
                 em28xx_audio_source(dev, ainput);
@@ -674,7 +683,6 @@ static int em28xx_v4l2_mmap(struct file *filp, struct vm_area_struct *vma)
  */
 static int em28xx_get_ctrl(struct em28xx *dev, struct v4l2_control *ctrl)
 {
-        s32 tmp;
         switch (ctrl->id) {
         case V4L2_CID_AUDIO_MUTE:
                 ctrl->value = dev->mute;
@@ -682,6 +690,16 @@ static int em28xx_get_ctrl(struct em28xx *dev, struct v4l2_control *ctrl)
         case V4L2_CID_AUDIO_VOLUME:
                 ctrl->value = dev->volume;
                 return 0;
+        default:
+                return -EINVAL;
+        }
+}
+
+/*FIXME: should be moved to saa711x */
+static int saa711x_get_ctrl(struct em28xx *dev, struct v4l2_control *ctrl)
+{
+        s32 tmp;
+        switch (ctrl->id) {
         case V4L2_CID_BRIGHTNESS:
                 if ((tmp = em28xx_brightness_get(dev)) < 0)
                         return -EIO;
@@ -731,6 +749,15 @@ static int em28xx_set_ctrl(struct em28xx *dev, const struct v4l2_control *ctrl)
         case V4L2_CID_AUDIO_VOLUME:
                 dev->volume = ctrl->value;
                 return em28xx_audio_analog_set(dev);
+        default:
+                return -EINVAL;
+        }
+}
+
+/*FIXME: should be moved to saa711x */
+static int saa711x_set_ctrl(struct em28xx *dev, const struct v4l2_control *ctrl)
+{
+        switch (ctrl->id) {
         case V4L2_CID_BRIGHTNESS:
                 return em28xx_brightness_set(dev, ctrl->value);
         case V4L2_CID_CONTRAST:
@@ -994,14 +1021,34 @@ static int em28xx_do_ioctl(struct inode *inode, struct file *filp,
         case VIDIOC_QUERYCTRL:
                 {
                         struct v4l2_queryctrl *qc = arg;
-                        u8 i, n;
-                        n = sizeof(em28xx_qctrl) / sizeof(em28xx_qctrl[0]);
-                        for (i = 0; i < n; i++)
-                                if (qc->id && qc->id == em28xx_qctrl[i].id) {
-                                        memcpy(qc, &(em28xx_qctrl[i]),
+                        int i, id=qc->id;
+
+                        memset(qc,0,sizeof(*qc));
+                        qc->id=id;
+
+                        if (!dev->has_msp34xx) {
+                                for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+                                        if (qc->id && qc->id == em28xx_qctrl[i].id) {
+                                                memcpy(qc, &(em28xx_qctrl[i]),
+                                                sizeof(*qc));
+                                                return 0;
+                                        }
+                                }
+                        }
+                        if (dev->decoder == EM28XX_TVP5150) {
+                                em28xx_i2c_call_clients(dev,cmd,qc);
+                                if (qc->type)
+                                        return 0;
+                                else
+                                        return -EINVAL;
+                        }
+                        for (i = 0; i < ARRAY_SIZE(saa711x_qctrl); i++) {
+                                if (qc->id && qc->id == saa711x_qctrl[i].id) {
+                                        memcpy(qc, &(saa711x_qctrl[i]),
                                                sizeof(*qc));
                                         return 0;
                                 }
+                        }
 
                         return -EINVAL;
                 }
@@ -1009,29 +1056,64 @@ static int em28xx_do_ioctl(struct inode *inode, struct file *filp,
         case VIDIOC_G_CTRL:
                 {
                         struct v4l2_control *ctrl = arg;
+                        int retval=-EINVAL;
 
+                        if (!dev->has_msp34xx)
+                                retval=em28xx_get_ctrl(dev, ctrl);
+                        if (retval==-EINVAL) {
+                                if (dev->decoder == EM28XX_TVP5150) {
+                                        em28xx_i2c_call_clients(dev,cmd,arg);
+                                        return 0;
+                                }
 
-                        return em28xx_get_ctrl(dev, ctrl);
+                                return saa711x_get_ctrl(dev, ctrl);
+                        } else return retval;
                 }
 
-        case VIDIOC_S_CTRL_OLD: /* ??? */
         case VIDIOC_S_CTRL:
                 {
                         struct v4l2_control *ctrl = arg;
-                        u8 i, n;
-
-
-                        n = sizeof(em28xx_qctrl) / sizeof(em28xx_qctrl[0]);
-                        for (i = 0; i < n; i++)
-                                if (ctrl->id == em28xx_qctrl[i].id) {
-                                        if (ctrl->value <
-                                            em28xx_qctrl[i].minimum
-                                            || ctrl->value >
-                                            em28xx_qctrl[i].maximum)
-                                                return -ERANGE;
+                        u8 i;
+
+                        if (!dev->has_msp34xx){
+                                for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+                                        if (ctrl->id == em28xx_qctrl[i].id) {
+                                                if (ctrl->value <
+                                                em28xx_qctrl[i].minimum
+                                                || ctrl->value >
+                                                em28xx_qctrl[i].maximum)
+                                                        return -ERANGE;
+                                                return em28xx_set_ctrl(dev, ctrl);
+                                        }
+                                }
+                        }
 
-                                        return em28xx_set_ctrl(dev, ctrl);
+                        if (dev->decoder == EM28XX_TVP5150) {
+                                em28xx_i2c_call_clients(dev,cmd,arg);
+                                return 0;
+                        } else if (!dev->has_msp34xx) {
+                                for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+                                        if (ctrl->id == em28xx_qctrl[i].id) {
+                                                if (ctrl->value <
+                                                em28xx_qctrl[i].minimum
+                                                || ctrl->value >
+                                                em28xx_qctrl[i].maximum)
+                                                        return -ERANGE;
+                                                return em28xx_set_ctrl(dev, ctrl);
+                                        }
                                 }
+                                for (i = 0; i < ARRAY_SIZE(saa711x_qctrl); i++) {
+                                        if (ctrl->id == saa711x_qctrl[i].id) {
+                                                if (ctrl->value <
+                                                saa711x_qctrl[i].minimum
+                                                || ctrl->value >
+                                                saa711x_qctrl[i].maximum)
+                                                        return -ERANGE;
+                                                return saa711x_set_ctrl(dev, ctrl);
+                                        }
+                                }
+                        }
+
                         return -EINVAL;
                 }
 
@@ -1187,7 +1269,7 @@ static int em28xx_video_do_ioctl(struct inode *inode, struct file *filp,
                 return -ENODEV;
 
         if (video_debug > 1)
-                em28xx_print_ioctl(dev->name,cmd);
+                v4l_print_ioctl(dev->name,cmd);
 
         switch (cmd) {
 
@@ -1564,6 +1646,8 @@ static struct file_operations em28xx_v4l_fops = {
         .poll = em28xx_v4l2_poll,
         .mmap = em28xx_v4l2_mmap,
         .llseek = no_llseek,
+        .compat_ioctl   = v4l_compat_ioctl32,
+
 };
 
 /******************************** usb interface *****************************************/
@@ -1848,9 +1932,12 @@ static void em28xx_usb_disconnect(struct usb_interface *interface)
         struct em28xx *dev = usb_get_intfdata(interface);
         usb_set_intfdata(interface, NULL);
 
+/*FIXME: IR should be disconnected */
+
         if (!dev)
                 return;
 
+
         down_write(&em28xx_disconnect);
 
         down(&dev->lock);
diff --git a/drivers/media/video/em28xx/em28xx.h b/drivers/media/video/em28xx/em28xx.h
index 5c7a41ce69f3..33de9d846af5 100644
--- a/drivers/media/video/em28xx/em28xx.h
+++ b/drivers/media/video/em28xx/em28xx.h
@@ -1,5 +1,5 @@
 /*
-   em28xx-cards.c - driver for Empia EM2800/EM2820/2840 USB video capture devices
+   em28xx.h - driver for Empia EM2800/EM2820/2840 USB video capture devices
 
    Copyright (C) 2005 Markus Rechberger <mrechberger@gmail.com>
                       Ludovico Cavedon <cavedon@sssup.it>
@@ -216,6 +216,8 @@ struct em28xx {
         unsigned int has_msp34xx:1;
         unsigned int has_tda9887:1;
 
+        u32 i2s_speed;          /* I2S speed for audio digital stream */
+
         enum em28xx_decoder decoder;
 
         int tuner_type;         /* type of the tuner */
@@ -293,8 +295,6 @@ void em28xx_set_ir(struct em28xx * dev,struct IR_i2c *ir);
 
 /* Provided by em28xx-core.c */
 
-void em28xx_print_ioctl(char *name, unsigned int cmd);
-
 u32 em28xx_request_buffers(struct em28xx *dev, u32 count);
 void em28xx_queue_unusedframes(struct em28xx *dev);
 void em28xx_release_buffers(struct em28xx *dev);
diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c
index 3cc1d6a6019b..58b0e6982822 100644
--- a/drivers/media/video/ir-kbd-i2c.c
+++ b/drivers/media/video/ir-kbd-i2c.c
@@ -279,7 +279,7 @@ static int ir_probe(struct i2c_adapter *adap);
 
 static struct i2c_driver driver = {
         .driver = {
-                .name   = "ir remote kbd driver",
+                .name   = "ir-kbd-i2c",
         },
         .id             = I2C_DRIVERID_INFRARED,
         .attach_adapter = ir_probe,
@@ -304,18 +304,20 @@ static int ir_attach(struct i2c_adapter *adap, int addr,
         ir = kzalloc(sizeof(struct IR_i2c),GFP_KERNEL);
         input_dev = input_allocate_device();
         if (!ir || !input_dev) {
-                kfree(ir);
                 input_free_device(input_dev);
+                kfree(ir);
                 return -ENOMEM;
         }
+        memset(ir,0,sizeof(*ir));
 
         ir->c = client_template;
         ir->input = input_dev;
 
-        i2c_set_clientdata(&ir->c, ir);
         ir->c.adapter = adap;
         ir->c.addr    = addr;
 
+        i2c_set_clientdata(&ir->c, ir);
+
         switch(addr) {
         case 0x64:
                 name        = "Pixelview";
@@ -378,13 +380,15 @@ static int ir_attach(struct i2c_adapter *adap, int addr,
                  ir->c.dev.bus_id);
 
         /* init + register input device */
-        ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
-        input_dev->id.bustype   = BUS_I2C;
-        input_dev->name         = ir->c.name;
-        input_dev->phys         = ir->phys;
+        ir_input_init(input_dev,&ir->ir,ir_type,ir->ir_codes);
+        input_dev->id.bustype = BUS_I2C;
+        input_dev->name       = ir->c.name;
+        input_dev->phys       = ir->phys;
 
         /* register event device */
         input_register_device(ir->input);
+        printk(DEVNAME ": %s detected at %s [%s]\n",
+               ir->input->name,ir->input->phys,adap->name);
 
         /* start polling via eventd */
         INIT_WORK(&ir->work, ir_work, ir);
diff --git a/drivers/media/video/meye.c b/drivers/media/video/meye.c
index 3f2a882bc20a..2869464aee0d 100644
--- a/drivers/media/video/meye.c
+++ b/drivers/media/video/meye.c
@@ -1754,6 +1754,7 @@ static struct file_operations meye_fops = {
         .release        = meye_release,
         .mmap           = meye_mmap,
         .ioctl          = meye_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .poll           = meye_poll,
         .llseek         = no_llseek,
 };
diff --git a/drivers/media/video/msp3400-driver.c b/drivers/media/video/msp3400-driver.c
new file mode 100644
index 000000000000..aa8c556b6ba1
--- /dev/null
+++ b/drivers/media/video/msp3400-driver.c
@@ -0,0 +1,1274 @@
+/*
+ * Programming the mspx4xx sound processor family
+ *
+ * (c) 1997-2001 Gerd Knorr <kraxel@bytesex.org>
+ *
+ * what works and what doesn't:
+ *
+ *  AM-Mono
+ *      Support for Hauppauge cards added (decoding handled by tuner) added by
+ *      Frederic Crozat <fcrozat@mail.dotcom.fr>
+ *
+ *  FM-Mono
+ *      should work. The stereo modes are backward compatible to FM-mono,
+ *      therefore FM-Mono should be allways available.
+ *
+ *  FM-Stereo (B/G, used in germany)
+ *      should work, with autodetect
+ *
+ *  FM-Stereo (satellite)
+ *      should work, no autodetect (i.e. default is mono, but you can
+ *      switch to stereo -- untested)
+ *
+ *  NICAM (B/G, L , used in UK, Scandinavia, Spain and France)
+ *      should work, with autodetect. Support for NICAM was added by
+ *      Pekka Pietikainen <pp@netppl.fi>
+ *
+ * TODO:
+ *   - better SAT support
+ *
+ * 980623  Thomas Sailer (sailer@ife.ee.ethz.ch)
+ *         using soundcore instead of OSS
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/videodev.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-common.h>
+#include <media/audiochip.h>
+#include <linux/kthread.h>
+#include <linux/suspend.h>
+#include "msp3400.h"
+
+/* ---------------------------------------------------------------------- */
+
+MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
+MODULE_AUTHOR("Gerd Knorr");
+MODULE_LICENSE("GPL");
+
+/* module parameters */
+static int opmode   = OPMODE_AUTO;
+int debug    = 0;    /* debug output */
+int once     = 0;    /* no continous stereo monitoring */
+int amsound  = 0;    /* hard-wire AM sound at 6.5 Hz (france),
+                               the autoscan seems work well only with FM... */
+int standard = 1;    /* Override auto detect of audio standard, if needed. */
+int dolby    = 0;
+
+int stereo_threshold = 0x190; /* a2 threshold for stereo/bilingual
+                                        (msp34xxg only) 0x00a0-0x03c0 */
+
+/* read-only */
+module_param(opmode,           int, 0444);
+
+/* read-write */
+module_param(once,             bool, 0644);
+module_param(debug,            int, 0644);
+module_param(stereo_threshold, int, 0644);
+module_param(standard,         int, 0644);
+module_param(amsound,          bool, 0644);
+module_param(dolby,            bool, 0644);
+
+MODULE_PARM_DESC(opmode, "Forces a MSP3400 opmode. 0=Manual, 1=Autodetect, 2=Autodetect and autoselect");
+MODULE_PARM_DESC(once, "No continuous stereo monitoring");
+MODULE_PARM_DESC(debug, "Enable debug messages [0-3]");
+MODULE_PARM_DESC(stereo_threshold, "Sets signal threshold to activate stereo");
+MODULE_PARM_DESC(standard, "Specify audio standard: 32 = NTSC, 64 = radio, Default: Autodetect");
+MODULE_PARM_DESC(amsound, "Hardwire AM sound at 6.5Hz (France), FM can autoscan");
+MODULE_PARM_DESC(dolby, "Activates Dolby processsing");
+
+/* ---------------------------------------------------------------------- */
+
+/* control subaddress */
+#define I2C_MSP_CONTROL 0x00
+/* demodulator unit subaddress */
+#define I2C_MSP_DEM     0x10
+/* DSP unit subaddress */
+#define I2C_MSP_DSP     0x12
+
+/* Addresses to scan */
+static unsigned short normal_i2c[] = { 0x80 >> 1, 0x88 >> 1, I2C_CLIENT_END };
+I2C_CLIENT_INSMOD;
+
+/* ----------------------------------------------------------------------- */
+/* functions for talking to the MSP3400C Sound processor                   */
+
+int msp_reset(struct i2c_client *client)
+{
+        /* reset and read revision code */
+        static u8 reset_off[3] = { I2C_MSP_CONTROL, 0x80, 0x00 };
+        static u8 reset_on[3]  = { I2C_MSP_CONTROL, 0x00, 0x00 };
+        static u8 write[3]     = { I2C_MSP_DSP + 1, 0x00, 0x1e };
+        u8 read[2];
+        struct i2c_msg reset[2] = {
+                { client->addr, I2C_M_IGNORE_NAK, 3, reset_off },
+                { client->addr, I2C_M_IGNORE_NAK, 3, reset_on  },
+        };
+        struct i2c_msg test[2] = {
+                { client->addr, 0,        3, write },
+                { client->addr, I2C_M_RD, 2, read  },
+        };
+
+        v4l_dbg(3, client, "msp_reset\n");
+        if (i2c_transfer(client->adapter, &reset[0], 1) != 1 ||
+            i2c_transfer(client->adapter, &reset[1], 1) != 1 ||
+            i2c_transfer(client->adapter, test, 2) != 2) {
+                v4l_err(client, "chip reset failed\n");
+                return -1;
+        }
+        return 0;
+}
+
+static int msp_read(struct i2c_client *client, int dev, int addr)
+{
+        int err, retval;
+        u8 write[3];
+        u8 read[2];
+        struct i2c_msg msgs[2] = {
+                { client->addr, 0,        3, write },
+                { client->addr, I2C_M_RD, 2, read  }
+        };
+
+        write[0] = dev + 1;
+        write[1] = addr >> 8;
+        write[2] = addr & 0xff;
+
+        for (err = 0; err < 3; err++) {
+                if (i2c_transfer(client->adapter, msgs, 2) == 2)
+                        break;
+                v4l_warn(client, "I/O error #%d (read 0x%02x/0x%02x)\n", err,
+                       dev, addr);
+                current->state = TASK_INTERRUPTIBLE;
+                schedule_timeout(msecs_to_jiffies(10));
+        }
+        if (err == 3) {
+                v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
+                msp_reset(client);
+                return -1;
+        }
+        retval = read[0] << 8 | read[1];
+        v4l_dbg(3, client, "msp_read(0x%x, 0x%x): 0x%x\n", dev, addr, retval);
+        return retval;
+}
+
+int msp_read_dem(struct i2c_client *client, int addr)
+{
+        return msp_read(client, I2C_MSP_DEM, addr);
+}
+
+int msp_read_dsp(struct i2c_client *client, int addr)
+{
+        return msp_read(client, I2C_MSP_DSP, addr);
+}
+
+static int msp_write(struct i2c_client *client, int dev, int addr, int val)
+{
+        int err;
+        u8 buffer[5];
+
+        buffer[0] = dev;
+        buffer[1] = addr >> 8;
+        buffer[2] = addr &  0xff;
+        buffer[3] = val  >> 8;
+        buffer[4] = val  &  0xff;
+
+        v4l_dbg(3, client, "msp_write(0x%x, 0x%x, 0x%x)\n", dev, addr, val);
+        for (err = 0; err < 3; err++) {
+                if (i2c_master_send(client, buffer, 5) == 5)
+                        break;
+                v4l_warn(client, "I/O error #%d (write 0x%02x/0x%02x)\n", err,
+                       dev, addr);
+                current->state = TASK_INTERRUPTIBLE;
+                schedule_timeout(msecs_to_jiffies(10));
+        }
+        if (err == 3) {
+                v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
+                msp_reset(client);
+                return -1;
+        }
+        return 0;
+}
+
+int msp_write_dem(struct i2c_client *client, int addr, int val)
+{
+        return msp_write(client, I2C_MSP_DEM, addr, val);
+}
+
+int msp_write_dsp(struct i2c_client *client, int addr, int val)
+{
+        return msp_write(client, I2C_MSP_DSP, addr, val);
+}
+
+/* ----------------------------------------------------------------------- *
+ * bits  9  8  5 - SCART DSP input Select:
+ *       0  0  0 - SCART 1 to DSP input (reset position)
+ *       0  1  0 - MONO to DSP input
+ *       1  0  0 - SCART 2 to DSP input
+ *       1  1  1 - Mute DSP input
+ *
+ * bits 11 10  6 - SCART 1 Output Select:
+ *       0  0  0 - undefined (reset position)
+ *       0  1  0 - SCART 2 Input to SCART 1 Output (for devices with 2 SCARTS)
+ *       1  0  0 - MONO input to SCART 1 Output
+ *       1  1  0 - SCART 1 DA to SCART 1 Output
+ *       0  0  1 - SCART 2 DA to SCART 1 Output
+ *       0  1  1 - SCART 1 Input to SCART 1 Output
+ *       1  1  1 - Mute SCART 1 Output
+ *
+ * bits 13 12  7 - SCART 2 Output Select (for devices with 2 Output SCART):
+ *       0  0  0 - SCART 1 DA to SCART 2 Output (reset position)
+ *       0  1  0 - SCART 1 Input to SCART 2 Output
+ *       1  0  0 - MONO input to SCART 2 Output
+ *       0  0  1 - SCART 2 DA to SCART 2 Output
+ *       0  1  1 - SCART 2 Input to SCART 2 Output
+ *       1  1  0 - Mute SCART 2 Output
+ *
+ * Bits 4 to 0 should be zero.
+ * ----------------------------------------------------------------------- */
+
+static int scarts[3][9] = {
+        /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
+        /* SCART DSP Input select */
+        { 0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
+        /* SCART1 Output select */
+        { 0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
+        /* SCART2 Output select */
+        { 0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
+};
+
+static char *scart_names[] = {
+        "mask", "in1", "in2", "in1 da", "in2 da", "in3", "in4", "mono", "mute"
+};
+
+void msp_set_scart(struct i2c_client *client, int in, int out)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        state->in_scart=in;
+
+        if (in >= 1 && in <= 8 && out >= 0 && out <= 2) {
+                if (-1 == scarts[out][in])
+                        return;
+
+                state->acb &= ~scarts[out][SCART_MASK];
+                state->acb |=  scarts[out][in];
+        } else
+                state->acb = 0xf60; /* Mute Input and SCART 1 Output */
+
+        v4l_dbg(1, client, "scart switch: %s => %d (ACB=0x%04x)\n",
+                                                scart_names[in], out, state->acb);
+        msp_write_dsp(client, 0x13, state->acb);
+
+        /* Sets I2S speed 0 = 1.024 Mbps, 1 = 2.048 Mbps */
+        msp_write_dem(client, 0x40, state->i2s_mode);
+}
+
+void msp_set_mute(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        v4l_dbg(1, client, "mute audio\n");
+        msp_write_dsp(client, 0x0000, 0);
+        msp_write_dsp(client, 0x0007, 1);
+        if (state->has_scart2_out_volume)
+                msp_write_dsp(client, 0x0040, 1);
+        if (state->has_headphones)
+                msp_write_dsp(client, 0x0006, 0);
+}
+
+void msp_set_audio(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int bal = 0, bass, treble, loudness;
+        int val = 0;
+
+        if (!state->muted)
+                val = (state->volume * 0x7f / 65535) << 8;
+
+        v4l_dbg(1, client, "mute=%s volume=%d\n",
+                state->muted ? "on" : "off", state->volume);
+
+        msp_write_dsp(client, 0x0000, val);
+        msp_write_dsp(client, 0x0007, state->muted ? 0x1 : (val | 0x1));
+        if (state->has_scart2_out_volume)
+                msp_write_dsp(client, 0x0040, state->muted ? 0x1 : (val | 0x1));
+        if (state->has_headphones)
+                msp_write_dsp(client, 0x0006, val);
+        if (!state->has_sound_processing)
+                return;
+
+        if (val)
+                bal = (u8)((state->balance / 256) - 128);
+        bass = ((state->bass - 32768) * 0x60 / 65535) << 8;
+        treble = ((state->treble - 32768) * 0x60 / 65535) << 8;
+        loudness = state->loudness ? ((5 * 4) << 8) : 0;
+
+        v4l_dbg(1, client, "balance=%d bass=%d treble=%d loudness=%d\n",
+                state->balance, state->bass, state->treble, state->loudness);
+
+        msp_write_dsp(client, 0x0001, bal << 8);
+        msp_write_dsp(client, 0x0002, bass);
+        msp_write_dsp(client, 0x0003, treble);
+        msp_write_dsp(client, 0x0004, loudness);
+        if (!state->has_headphones)
+                return;
+        msp_write_dsp(client, 0x0030, bal << 8);
+        msp_write_dsp(client, 0x0031, bass);
+        msp_write_dsp(client, 0x0032, treble);
+        msp_write_dsp(client, 0x0033, loudness);
+}
+
+int msp_modus(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        if (state->radio) {
+                v4l_dbg(1, client, "video mode selected to Radio\n");
+                return 0x0003;
+        }
+
+        if (state->v4l2_std & V4L2_STD_PAL) {
+                v4l_dbg(1, client, "video mode selected to PAL\n");
+
+#if 1
+                /* experimental: not sure this works with all chip versions */
+                return 0x7003;
+#else
+                /* previous value, try this if it breaks ... */
+                return 0x1003;
+#endif
+        }
+        if (state->v4l2_std & V4L2_STD_NTSC) {
+                v4l_dbg(1, client, "video mode selected to NTSC\n");
+                return 0x2003;
+        }
+        if (state->v4l2_std & V4L2_STD_SECAM) {
+                v4l_dbg(1, client, "video mode selected to SECAM\n");
+                return 0x0003;
+        }
+        return 0x0003;
+}
+
+/* ------------------------------------------------------------------------ */
+
+
+static void msp_wake_thread(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        if (NULL == state->kthread)
+                return;
+        msp_set_mute(client);
+        state->watch_stereo = 0;
+        state->restart = 1;
+        wake_up_interruptible(&state->wq);
+}
+
+int msp_sleep(struct msp_state *state, int timeout)
+{
+        DECLARE_WAITQUEUE(wait, current);
+
+        add_wait_queue(&state->wq, &wait);
+        if (!kthread_should_stop()) {
+                if (timeout < 0) {
+                        set_current_state(TASK_INTERRUPTIBLE);
+                        schedule();
+                } else {
+                        schedule_timeout_interruptible
+                                                (msecs_to_jiffies(timeout));
+                }
+        }
+
+        remove_wait_queue(&state->wq, &wait);
+        try_to_freeze();
+        return state->restart;
+}
+
+/* ------------------------------------------------------------------------ */
+
+static int msp_mode_v4l2_to_v4l1(int rxsubchans)
+{
+        int mode = 0;
+
+        if (rxsubchans & V4L2_TUNER_SUB_STEREO)
+                mode |= VIDEO_SOUND_STEREO;
+        if (rxsubchans & V4L2_TUNER_SUB_LANG2)
+                mode |= VIDEO_SOUND_LANG2;
+        if (rxsubchans & V4L2_TUNER_SUB_LANG1)
+                mode |= VIDEO_SOUND_LANG1;
+        if (mode == 0)
+                mode |= VIDEO_SOUND_MONO;
+        return mode;
+}
+
+static int msp_mode_v4l1_to_v4l2(int mode)
+{
+        if (mode & VIDEO_SOUND_STEREO)
+                return V4L2_TUNER_MODE_STEREO;
+        if (mode & VIDEO_SOUND_LANG2)
+                return V4L2_TUNER_MODE_LANG2;
+        if (mode & VIDEO_SOUND_LANG1)
+                return V4L2_TUNER_MODE_LANG1;
+        return V4L2_TUNER_MODE_MONO;
+}
+
+static void msp_any_detect_stereo(struct i2c_client *client)
+{
+        struct msp_state *state  = i2c_get_clientdata(client);
+
+        switch (state->opmode) {
+        case OPMODE_MANUAL:
+        case OPMODE_AUTODETECT:
+                autodetect_stereo(client);
+                break;
+        case OPMODE_AUTOSELECT:
+                msp34xxg_detect_stereo(client);
+                break;
+        }
+}
+
+static struct v4l2_queryctrl msp_qctrl_std[] = {
+        {
+                .id            = V4L2_CID_AUDIO_VOLUME,
+                .name          = "Volume",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 58880,
+                .flags         = 0,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+        },{
+                .id            = V4L2_CID_AUDIO_MUTE,
+                .name          = "Mute",
+                .minimum       = 0,
+                .maximum       = 1,
+                .step          = 1,
+                .default_value = 1,
+                .flags         = 0,
+                .type          = V4L2_CTRL_TYPE_BOOLEAN,
+        },
+};
+
+static struct v4l2_queryctrl msp_qctrl_sound_processing[] = {
+        {
+                .id            = V4L2_CID_AUDIO_BALANCE,
+                .name          = "Balance",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+                .flags         = 0,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+        },{
+                .id            = V4L2_CID_AUDIO_BASS,
+                .name          = "Bass",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+        },{
+                .id            = V4L2_CID_AUDIO_TREBLE,
+                .name          = "Treble",
+                .minimum       = 0,
+                .maximum       = 65535,
+                .step          = 65535/100,
+                .default_value = 32768,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+        },{
+                .id            = V4L2_CID_AUDIO_LOUDNESS,
+                .name          = "Loudness",
+                .minimum       = 0,
+                .maximum       = 1,
+                .step          = 1,
+                .default_value = 1,
+                .flags         = 0,
+                .type          = V4L2_CTRL_TYPE_BOOLEAN,
+        },
+};
+
+
+static void msp_any_set_audmode(struct i2c_client *client, int audmode)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        switch (state->opmode) {
+        case OPMODE_MANUAL:
+        case OPMODE_AUTODETECT:
+                state->watch_stereo = 0;
+                msp3400c_setstereo(client, audmode);
+                break;
+        case OPMODE_AUTOSELECT:
+                msp34xxg_set_audmode(client, audmode);
+                break;
+        }
+}
+
+static int msp_get_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case V4L2_CID_AUDIO_VOLUME:
+                ctrl->value = state->volume;
+                break;
+
+        case V4L2_CID_AUDIO_MUTE:
+                ctrl->value = state->muted;
+                break;
+
+        case V4L2_CID_AUDIO_BALANCE:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                ctrl->value = state->balance;
+                break;
+
+        case V4L2_CID_AUDIO_BASS:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                ctrl->value = state->bass;
+                break;
+
+        case V4L2_CID_AUDIO_TREBLE:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                ctrl->value = state->treble;
+                break;
+
+        case V4L2_CID_AUDIO_LOUDNESS:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                ctrl->value = state->loudness;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+        return 0;
+}
+
+static int msp_set_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case V4L2_CID_AUDIO_VOLUME:
+                state->volume = ctrl->value;
+                if (state->volume == 0)
+                        state->balance = 32768;
+                break;
+
+        case V4L2_CID_AUDIO_MUTE:
+                if (ctrl->value < 0 || ctrl->value >= 2)
+                        return -ERANGE;
+                state->muted = ctrl->value;
+                break;
+
+        case V4L2_CID_AUDIO_BASS:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                state->bass = ctrl->value;
+                break;
+
+        case V4L2_CID_AUDIO_TREBLE:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                state->treble = ctrl->value;
+                break;
+
+        case V4L2_CID_AUDIO_LOUDNESS:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                state->loudness = ctrl->value;
+                break;
+
+        case V4L2_CID_AUDIO_BALANCE:
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                state->balance = ctrl->value;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+        msp_set_audio(client);
+        return 0;
+}
+
+static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        u16 *sarg = arg;
+        int scart = 0;
+
+        if (debug >= 2)
+                v4l_i2c_print_ioctl(client, cmd);
+
+        switch (cmd) {
+        case AUDC_SET_INPUT:
+                if (*sarg == state->input)
+                        break;
+                state->input = *sarg;
+                switch (*sarg) {
+                case AUDIO_RADIO:
+                        /* Hauppauge uses IN2 for the radio */
+                        state->mode = MSP_MODE_FM_RADIO;
+                        scart       = SCART_IN2;
+                        break;
+                case AUDIO_EXTERN_1:
+                        /* IN1 is often used for external input ... */
+                        state->mode = MSP_MODE_EXTERN;
+                        scart       = SCART_IN1;
+                        break;
+                case AUDIO_EXTERN_2:
+                        /* ... sometimes it is IN2 through ;) */
+                        state->mode = MSP_MODE_EXTERN;
+                        scart       = SCART_IN2;
+                        break;
+                case AUDIO_TUNER:
+                        state->mode = -1;
+                        break;
+                default:
+                        if (*sarg & AUDIO_MUTE)
+                                msp_set_scart(client, SCART_MUTE, 0);
+                        break;
+                }
+                if (scart) {
+                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                        state->audmode = V4L2_TUNER_MODE_STEREO;
+                        msp_set_scart(client, scart, 0);
+                        msp_write_dsp(client, 0x000d, 0x1900);
+                        if (state->opmode != OPMODE_AUTOSELECT)
+                                msp3400c_setstereo(client, state->audmode);
+                }
+                msp_wake_thread(client);
+                break;
+
+        case AUDC_SET_RADIO:
+                if (state->radio)
+                        return 0;
+                state->radio = 1;
+                v4l_dbg(1, client, "switching to radio mode\n");
+                state->watch_stereo = 0;
+                switch (state->opmode) {
+                case OPMODE_MANUAL:
+                        /* set msp3400 to FM radio mode */
+                        msp3400c_setmode(client, MSP_MODE_FM_RADIO);
+                        msp3400c_setcarrier(client, MSP_CARRIER(10.7),
+                                            MSP_CARRIER(10.7));
+                        msp_set_audio(client);
+                        break;
+                case OPMODE_AUTODETECT:
+                case OPMODE_AUTOSELECT:
+                        /* the thread will do for us */
+                        msp_wake_thread(client);
+                        break;
+                }
+                break;
+
+        /* --- v4l ioctls --- */
+        /* take care: bttv does userspace copying, we'll get a
+           kernel pointer here... */
+        case VIDIOCGAUDIO:
+        {
+                struct video_audio *va = arg;
+
+                va->flags |= VIDEO_AUDIO_VOLUME | VIDEO_AUDIO_MUTABLE;
+                if (state->has_sound_processing)
+                        va->flags |= VIDEO_AUDIO_BALANCE |
+                                VIDEO_AUDIO_BASS |
+                                VIDEO_AUDIO_TREBLE;
+                if (state->muted)
+                        va->flags |= VIDEO_AUDIO_MUTE;
+                va->volume = state->volume;
+                va->balance = state->volume ? state->balance : 32768;
+                va->bass = state->bass;
+                va->treble = state->treble;
+
+                if (state->radio)
+                        break;
+                if (state->opmode == OPMODE_AUTOSELECT)
+                        msp_any_detect_stereo(client);
+                va->mode = msp_mode_v4l2_to_v4l1(state->rxsubchans);
+                break;
+        }
+
+        case VIDIOCSAUDIO:
+        {
+                struct video_audio *va = arg;
+
+                state->muted = (va->flags & VIDEO_AUDIO_MUTE);
+                state->volume = va->volume;
+                state->balance = va->balance;
+                state->bass = va->bass;
+                state->treble = va->treble;
+                msp_set_audio(client);
+
+                if (va->mode != 0 && state->radio == 0)
+                        msp_any_set_audmode(client, msp_mode_v4l1_to_v4l2(va->mode));
+                break;
+        }
+
+        case VIDIOCSCHAN:
+        {
+                struct video_channel *vc = arg;
+                int update = 0;
+                v4l2_std_id std;
+
+                if (state->radio)
+                        update = 1;
+                state->radio = 0;
+                if (vc->norm == VIDEO_MODE_PAL)
+                        std = V4L2_STD_PAL;
+                else if (vc->norm == VIDEO_MODE_SECAM)
+                        std = V4L2_STD_SECAM;
+                else
+                        std = V4L2_STD_NTSC;
+                if (std != state->v4l2_std) {
+                        state->v4l2_std = std;
+                        update = 1;
+                }
+                if (update)
+                        msp_wake_thread(client);
+                break;
+        }
+
+        case VIDIOCSFREQ:
+        case VIDIOC_S_FREQUENCY:
+        {
+                /* new channel -- kick audio carrier scan */
+                msp_wake_thread(client);
+                break;
+        }
+
+        /* msp34xx specific */
+        case MSP_SET_MATRIX:
+        {
+                struct msp_matrix *mspm = arg;
+
+                msp_set_scart(client, mspm->input, mspm->output);
+                break;
+        }
+
+        /* --- v4l2 ioctls --- */
+        case VIDIOC_S_STD:
+        {
+                v4l2_std_id *id = arg;
+                int update = state->radio || state->v4l2_std != *id;
+
+                state->v4l2_std = *id;
+                state->radio = 0;
+                if (update)
+                        msp_wake_thread(client);
+                return 0;
+        }
+
+        case VIDIOC_ENUMINPUT:
+        {
+                struct v4l2_input *i = arg;
+
+                if (i->index != 0)
+                        return -EINVAL;
+
+                i->type = V4L2_INPUT_TYPE_TUNER;
+                switch (i->index) {
+                case AUDIO_RADIO:
+                        strcpy(i->name, "Radio");
+                        break;
+                case AUDIO_EXTERN_1:
+                        strcpy(i->name, "Extern 1");
+                        break;
+                case AUDIO_EXTERN_2:
+                        strcpy(i->name, "Extern 2");
+                        break;
+                case AUDIO_TUNER:
+                        strcpy(i->name, "Television");
+                        break;
+                default:
+                        return -EINVAL;
+                }
+                return 0;
+        }
+
+        case VIDIOC_G_AUDIO:
+        {
+                struct v4l2_audio *a = arg;
+
+                memset(a, 0, sizeof(*a));
+
+                switch (a->index) {
+                case AUDIO_RADIO:
+                        strcpy(a->name, "Radio");
+                        break;
+                case AUDIO_EXTERN_1:
+                        strcpy(a->name, "Extern 1");
+                        break;
+                case AUDIO_EXTERN_2:
+                        strcpy(a->name, "Extern 2");
+                        break;
+                case AUDIO_TUNER:
+                        strcpy(a->name, "Television");
+                        break;
+                default:
+                        return -EINVAL;
+                }
+
+                msp_any_detect_stereo(client);
+                if (state->audmode == V4L2_TUNER_MODE_STEREO) {
+                        a->capability = V4L2_AUDCAP_STEREO;
+                }
+
+                break;
+        }
+
+        case VIDIOC_S_AUDIO:
+        {
+                struct v4l2_audio *sarg = arg;
+
+                switch (sarg->index) {
+                case AUDIO_RADIO:
+                        /* Hauppauge uses IN2 for the radio */
+                        state->mode = MSP_MODE_FM_RADIO;
+                        scart       = SCART_IN2;
+                        break;
+                case AUDIO_EXTERN_1:
+                        /* IN1 is often used for external input ... */
+                        state->mode = MSP_MODE_EXTERN;
+                        scart       = SCART_IN1;
+                        break;
+                case AUDIO_EXTERN_2:
+                        /* ... sometimes it is IN2 through ;) */
+                        state->mode = MSP_MODE_EXTERN;
+                        scart       = SCART_IN2;
+                        break;
+                case AUDIO_TUNER:
+                        state->mode = -1;
+                        break;
+                }
+                if (scart) {
+                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                        state->audmode = V4L2_TUNER_MODE_STEREO;
+                        msp_set_scart(client, scart, 0);
+                        msp_write_dsp(client, 0x000d, 0x1900);
+                }
+                if (sarg->capability == V4L2_AUDCAP_STEREO) {
+                        state->audmode = V4L2_TUNER_MODE_STEREO;
+                } else {
+                        state->audmode &= ~V4L2_TUNER_MODE_STEREO;
+                }
+                msp_any_set_audmode(client, state->audmode);
+                msp_wake_thread(client);
+                break;
+        }
+
+        case VIDIOC_G_TUNER:
+        {
+                struct v4l2_tuner *vt = arg;
+
+                if (state->radio)
+                        break;
+                if (state->opmode == OPMODE_AUTOSELECT)
+                        msp_any_detect_stereo(client);
+                vt->audmode    = state->audmode;
+                vt->rxsubchans = state->rxsubchans;
+                vt->capability = V4L2_TUNER_CAP_STEREO |
+                        V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2;
+                break;
+        }
+
+        case VIDIOC_S_TUNER:
+        {
+                struct v4l2_tuner *vt = (struct v4l2_tuner *)arg;
+
+                if (state->radio)
+                        break;
+                /* only set audmode */
+                if (vt->audmode != -1 && vt->audmode != 0)
+                        msp_any_set_audmode(client, vt->audmode);
+                break;
+        }
+
+        case VIDIOC_G_AUDOUT:
+        {
+                struct v4l2_audioout *a = (struct v4l2_audioout *)arg;
+                int idx = a->index;
+
+                memset(a, 0, sizeof(*a));
+
+                switch (idx) {
+                case 0:
+                        strcpy(a->name, "Scart1 Out");
+                        break;
+                case 1:
+                        strcpy(a->name, "Scart2 Out");
+                        break;
+                case 2:
+                        strcpy(a->name, "I2S Out");
+                        break;
+                default:
+                        return -EINVAL;
+                }
+                break;
+
+        }
+
+        case VIDIOC_S_AUDOUT:
+        {
+                struct v4l2_audioout *a = (struct v4l2_audioout *)arg;
+
+                if (a->index < 0 || a->index > 2)
+                        return -EINVAL;
+
+                v4l_dbg(1, client, "Setting audio out on msp34xx to input %i\n", a->index);
+                msp_set_scart(client, state->in_scart, a->index + 1);
+
+                break;
+        }
+
+        case VIDIOC_INT_I2S_CLOCK_FREQ:
+        {
+                u32 *a = (u32 *)arg;
+
+                v4l_dbg(1, client, "Setting I2S speed to %d\n", *a);
+
+                switch (*a) {
+                        case 1024000:
+                                state->i2s_mode = 0;
+                                break;
+                        case 2048000:
+                                state->i2s_mode = 1;
+                                break;
+                        default:
+                                return -EINVAL;
+                }
+                break;
+        }
+
+        case VIDIOC_QUERYCTRL:
+        {
+                struct v4l2_queryctrl *qc = arg;
+                int i;
+
+                for (i = 0; i < ARRAY_SIZE(msp_qctrl_std); i++)
+                        if (qc->id && qc->id == msp_qctrl_std[i].id) {
+                                memcpy(qc, &msp_qctrl_std[i], sizeof(*qc));
+                                return 0;
+                        }
+                if (!state->has_sound_processing)
+                        return -EINVAL;
+                for (i = 0; i < ARRAY_SIZE(msp_qctrl_sound_processing); i++)
+                        if (qc->id && qc->id == msp_qctrl_sound_processing[i].id) {
+                                memcpy(qc, &msp_qctrl_sound_processing[i], sizeof(*qc));
+                                return 0;
+                        }
+                return -EINVAL;
+        }
+
+        case VIDIOC_G_CTRL:
+                return msp_get_ctrl(client, arg);
+
+        case VIDIOC_S_CTRL:
+                return msp_set_ctrl(client, arg);
+
+        case VIDIOC_LOG_STATUS:
+        {
+                const char *p;
+
+                if (state->opmode == OPMODE_AUTOSELECT)
+                        msp_any_detect_stereo(client);
+                v4l_info(client, "%s rev1 = 0x%04x rev2 = 0x%04x\n",
+                                client->name, state->rev1, state->rev2);
+                v4l_info(client, "Audio:    volume %d%s\n",
+                                state->volume, state->muted ? " (muted)" : "");
+                if (state->has_sound_processing) {
+                        v4l_info(client, "Audio:    balance %d bass %d treble %d loudness %s\n",
+                                        state->balance, state->bass, state->treble,
+                                        state->loudness ? "on" : "off");
+                }
+                switch (state->mode) {
+                case MSP_MODE_AM_DETECT: p = "AM (for carrier detect)"; break;
+                case MSP_MODE_FM_RADIO: p = "FM Radio"; break;
+                case MSP_MODE_FM_TERRA: p = "Terrestial FM-mono + FM-stereo"; break;
+                case MSP_MODE_FM_SAT: p = "Satellite FM-mono"; break;
+                case MSP_MODE_FM_NICAM1: p = "NICAM/FM (B/G, D/K)"; break;
+                case MSP_MODE_FM_NICAM2: p = "NICAM/FM (I)"; break;
+                case MSP_MODE_AM_NICAM: p = "NICAM/AM (L)"; break;
+                case MSP_MODE_BTSC: p = "BTSC"; break;
+                case MSP_MODE_EXTERN: p = "External input"; break;
+                default: p = "unknown"; break;
+                }
+                if (state->opmode == OPMODE_MANUAL) {
+                        v4l_info(client, "Mode:     %s (%s%s)\n", p,
+                                (state->rxsubchans & V4L2_TUNER_SUB_STEREO) ? "stereo" : "mono",
+                                (state->rxsubchans & V4L2_TUNER_SUB_LANG2) ? ", dual" : "");
+                } else {
+                        v4l_info(client, "Mode:     %s\n", p);
+                        v4l_info(client, "Standard: %s (%s%s)\n",
+                                msp_standard_std_name(state->std),
+                                (state->rxsubchans & V4L2_TUNER_SUB_STEREO) ? "stereo" : "mono",
+                                (state->rxsubchans & V4L2_TUNER_SUB_LANG2) ? ", dual" : "");
+                }
+                v4l_info(client, "ACB:      0x%04x\n", state->acb);
+                break;
+        }
+
+        default:
+                /* nothing */
+                break;
+        }
+        return 0;
+}
+
+static int msp_suspend(struct device * dev, pm_message_t state)
+{
+        struct i2c_client *client = container_of(dev, struct i2c_client, dev);
+
+        v4l_dbg(1, client, "suspend\n");
+        msp_reset(client);
+        return 0;
+}
+
+static int msp_resume(struct device * dev)
+{
+        struct i2c_client *client = container_of(dev, struct i2c_client, dev);
+
+        v4l_dbg(1, client, "resume\n");
+        msp_wake_thread(client);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static struct i2c_driver i2c_driver;
+
+static int msp_attach(struct i2c_adapter *adapter, int address, int kind)
+{
+        struct i2c_client *client;
+        struct msp_state *state;
+        int (*thread_func)(void *data) = NULL;
+        int msp_hard;
+        int msp_family;
+        int msp_revision;
+        int msp_product, msp_prod_hi, msp_prod_lo;
+        int msp_rom;
+
+        client = kmalloc(sizeof(*client), GFP_KERNEL);
+        if (client == NULL)
+                return -ENOMEM;
+        memset(client, 0, sizeof(*client));
+        client->addr = address;
+        client->adapter = adapter;
+        client->driver = &i2c_driver;
+        snprintf(client->name, sizeof(client->name) - 1, "msp3400");
+
+        if (msp_reset(client) == -1) {
+                v4l_dbg(1, client, "msp3400 not found\n");
+                kfree(client);
+                return -1;
+        }
+
+        state = kmalloc(sizeof(*state), GFP_KERNEL);
+        if (state == NULL) {
+                kfree(client);
+                return -ENOMEM;
+        }
+        i2c_set_clientdata(client, state);
+
+        memset(state, 0, sizeof(*state));
+        state->v4l2_std = V4L2_STD_NTSC;
+        state->volume = 58880;  /* 0db gain */
+        state->balance = 32768; /* 0db gain */
+        state->bass = 32768;
+        state->treble = 32768;
+        state->loudness = 0;
+        state->input = -1;
+        state->muted = 0;
+        state->i2s_mode = 0;
+        init_waitqueue_head(&state->wq);
+
+        state->rev1 = msp_read_dsp(client, 0x1e);
+        if (state->rev1 != -1)
+                state->rev2 = msp_read_dsp(client, 0x1f);
+        v4l_dbg(1, client, "rev1=0x%04x, rev2=0x%04x\n", state->rev1, state->rev2);
+        if (state->rev1 == -1 || (state->rev1 == 0 && state->rev2 == 0)) {
+                v4l_dbg(1, client, "not an msp3400 (cannot read chip version)\n");
+                kfree(state);
+                kfree(client);
+                return -1;
+        }
+
+        msp_set_audio(client);
+
+        msp_family = ((state->rev1 >> 4) & 0x0f) + 3;
+        msp_product = (state->rev2 >> 8) & 0xff;
+        msp_prod_hi = msp_product / 10;
+        msp_prod_lo = msp_product % 10;
+        msp_revision = (state->rev1 & 0x0f) + '@';
+        msp_hard = ((state->rev1 >> 8) & 0xff) + '@';
+        msp_rom = state->rev2 & 0x1f;
+        snprintf(client->name, sizeof(client->name), "MSP%d4%02d%c-%c%d",
+                        msp_family, msp_product,
+                        msp_revision, msp_hard, msp_rom);
+
+        /* Has NICAM support: all mspx41x and mspx45x products have NICAM */
+        state->has_nicam = msp_prod_hi == 1 || msp_prod_hi == 5;
+        /* Has radio support: was added with revision G */
+        state->has_radio = msp_revision >= 'G';
+        /* Has headphones output: not for stripped down products */
+        state->has_headphones = msp_prod_lo < 5;
+        /* Has scart4 input: not in pre D revisions, not in stripped D revs */
+        state->has_scart4 = msp_family >= 4 || (msp_revision >= 'D' && msp_prod_lo < 5);
+        /* Has scart2 and scart3 inputs and scart2 output: not in stripped
+           down products of the '3' family */
+        state->has_scart23_in_scart2_out = msp_family >= 4 || msp_prod_lo < 5;
+        /* Has scart2 a volume control? Not in pre-D revisions. */
+        state->has_scart2_out_volume = msp_revision > 'C' && state->has_scart23_in_scart2_out;
+        /* Has a configurable i2s out? */
+        state->has_i2s_conf = msp_revision >= 'G' && msp_prod_lo < 7;
+        /* Has subwoofer output: not in pre-D revs and not in stripped down products */
+        state->has_subwoofer = msp_revision >= 'D' && msp_prod_lo < 5;
+        /* Has soundprocessing (bass/treble/balance/loudness/equalizer): not in
+           stripped down products */
+        state->has_sound_processing = msp_prod_lo < 7;
+        /* Has Virtual Dolby Surround: only in msp34x1 */
+        state->has_virtual_dolby_surround = msp_revision == 'G' && msp_prod_lo == 1;
+        /* Has Virtual Dolby Surround & Dolby Pro Logic: only in msp34x2 */
+        state->has_dolby_pro_logic = msp_revision == 'G' && msp_prod_lo == 2;
+
+        state->opmode = opmode;
+        if (state->opmode == OPMODE_AUTO) {
+                /* MSP revision G and up have both autodetect and autoselect */
+                if (msp_revision >= 'G')
+                        state->opmode = OPMODE_AUTOSELECT;
+                /* MSP revision D and up have autodetect */
+                else if (msp_revision >= 'D')
+                        state->opmode = OPMODE_AUTODETECT;
+                else
+                        state->opmode = OPMODE_MANUAL;
+        }
+
+        /* hello world :-) */
+        v4l_info(client, "%s found @ 0x%x (%s)\n", client->name, address << 1, adapter->name);
+        v4l_info(client, "%s ", client->name);
+        if (state->has_nicam && state->has_radio)
+                printk("supports nicam and radio, ");
+        else if (state->has_nicam)
+                printk("supports nicam, ");
+        else if (state->has_radio)
+                printk("supports radio, ");
+        printk("mode is ");
+
+        /* version-specific initialization */
+        switch (state->opmode) {
+        case OPMODE_MANUAL:
+                printk("manual");
+                thread_func = msp3400c_thread;
+                break;
+        case OPMODE_AUTODETECT:
+                printk("autodetect");
+                thread_func = msp3410d_thread;
+                break;
+        case OPMODE_AUTOSELECT:
+                printk("autodetect and autoselect");
+                thread_func = msp34xxg_thread;
+                break;
+        }
+        printk("\n");
+
+        /* startup control thread if needed */
+        if (thread_func) {
+                state->kthread = kthread_run(thread_func, client, "msp34xx");
+
+                if (state->kthread == NULL)
+                        v4l_warn(client, "kernel_thread() failed\n");
+                msp_wake_thread(client);
+        }
+
+        /* done */
+        i2c_attach_client(client);
+
+        return 0;
+}
+
+static int msp_probe(struct i2c_adapter *adapter)
+{
+        if (adapter->class & I2C_CLASS_TV_ANALOG)
+                return i2c_probe(adapter, &addr_data, msp_attach);
+        return 0;
+}
+
+static int msp_detach(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int err;
+
+        /* shutdown control thread */
+        if (state->kthread) {
+                state->restart = 1;
+                kthread_stop(state->kthread);
+        }
+        msp_reset(client);
+
+        err = i2c_detach_client(client);
+        if (err) {
+                return err;
+        }
+
+        kfree(state);
+        kfree(client);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+/* i2c implementation */
+static struct i2c_driver i2c_driver = {
+        .id             = I2C_DRIVERID_MSP3400,
+        .attach_adapter = msp_probe,
+        .detach_client  = msp_detach,
+        .command        = msp_command,
+        .driver = {
+                .name    = "msp3400",
+                .suspend = msp_suspend,
+                .resume  = msp_resume,
+        },
+};
+
+static int __init msp3400_init_module(void)
+{
+        return i2c_add_driver(&i2c_driver);
+}
+
+static void __exit msp3400_cleanup_module(void)
+{
+        i2c_del_driver(&i2c_driver);
+}
+
+module_init(msp3400_init_module);
+module_exit(msp3400_cleanup_module);
+
+/*
+ * Overrides for Emacs so that we follow Linus's tabbing style.
+ * ---------------------------------------------------------------------------
+ * Local variables:
+ * c-basic-offset: 8
+ * End:
+ */
diff --git a/drivers/media/video/msp3400-kthreads.c b/drivers/media/video/msp3400-kthreads.c
new file mode 100644
index 000000000000..2b59b6847535
--- /dev/null
+++ b/drivers/media/video/msp3400-kthreads.c
@@ -0,0 +1,1010 @@
+/*
+ * Programming the mspx4xx sound processor family
+ *
+ * (c) 1997-2001 Gerd Knorr <kraxel@bytesex.org>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/videodev.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-common.h>
+#include <media/audiochip.h>
+#include <linux/kthread.h>
+#include <linux/suspend.h>
+#include "msp3400.h"
+
+/* this one uses the automatic sound standard detection of newer msp34xx
+   chip versions */
+static struct {
+        int retval;
+        int main, second;
+        char *name;
+} msp_stdlist[] = {
+        { 0x0000, 0, 0, "could not detect sound standard" },
+        { 0x0001, 0, 0, "autodetect start" },
+        { 0x0002, MSP_CARRIER(4.5), MSP_CARRIER(4.72), "4.5/4.72  M Dual FM-Stereo" },
+        { 0x0003, MSP_CARRIER(5.5), MSP_CARRIER(5.7421875), "5.5/5.74  B/G Dual FM-Stereo" },
+        { 0x0004, MSP_CARRIER(6.5), MSP_CARRIER(6.2578125), "6.5/6.25  D/K1 Dual FM-Stereo" },
+        { 0x0005, MSP_CARRIER(6.5), MSP_CARRIER(6.7421875), "6.5/6.74  D/K2 Dual FM-Stereo" },
+        { 0x0006, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  D/K FM-Mono (HDEV3)" },
+        { 0x0008, MSP_CARRIER(5.5), MSP_CARRIER(5.85), "5.5/5.85  B/G NICAM FM" },
+        { 0x0009, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  L NICAM AM" },
+        { 0x000a, MSP_CARRIER(6.0), MSP_CARRIER(6.55), "6.0/6.55  I NICAM FM" },
+        { 0x000b, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM" },
+        { 0x000c, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV2)" },
+        { 0x0020, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Stereo" },
+        { 0x0021, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Mono + SAP" },
+        { 0x0030, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M EIA-J Japan Stereo" },
+        { 0x0040, MSP_CARRIER(10.7), MSP_CARRIER(10.7), "10.7  FM-Stereo Radio" },
+        { 0x0050, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  SAT-Mono" },
+        { 0x0051, MSP_CARRIER(7.02), MSP_CARRIER(7.20), "7.02/7.20  SAT-Stereo" },
+        { 0x0060, MSP_CARRIER(7.2), MSP_CARRIER(7.2), "7.2  SAT ADR" },
+        {     -1, 0, 0, NULL }, /* EOF */
+};
+
+static struct msp3400c_init_data_dem {
+        int fir1[6];
+        int fir2[6];
+        int cdo1;
+        int cdo2;
+        int ad_cv;
+        int mode_reg;
+        int dsp_src;
+        int dsp_matrix;
+} msp3400c_init_data[] = {
+        {       /* AM (for carrier detect / msp3400) */
+                {75, 19, 36, 35, 39, 40},
+                {75, 19, 36, 35, 39, 40},
+                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+                0x00d0, 0x0500, 0x0020, 0x3000
+        },{     /* AM (for carrier detect / msp3410) */
+                {-1, -1, -8, 2, 59, 126},
+                {-1, -1, -8, 2, 59, 126},
+                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+                0x00d0, 0x0100, 0x0020, 0x3000
+        },{     /* FM Radio */
+                {-8, -8, 4, 6, 78, 107},
+                {-8, -8, 4, 6, 78, 107},
+                MSP_CARRIER(10.7), MSP_CARRIER(10.7),
+                0x00d0, 0x0480, 0x0020, 0x3000
+        },{     /* Terrestial FM-mono + FM-stereo */
+                {3, 18, 27, 48, 66, 72},
+                {3, 18, 27, 48, 66, 72},
+                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+                0x00d0, 0x0480, 0x0030, 0x3000
+        },{     /* Sat FM-mono */
+                { 1, 9, 14, 24, 33, 37},
+                { 3, 18, 27, 48, 66, 72},
+                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
+                0x00c6, 0x0480, 0x0000, 0x3000
+        },{     /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
+                {-2, -8, -10, 10, 50, 86},
+                {3, 18, 27, 48, 66, 72},
+                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+                0x00d0, 0x0040, 0x0120, 0x3000
+        },{     /* NICAM/FM -- I (6.0/6.552) */
+                {2, 4, -6, -4, 40, 94},
+                {3, 18, 27, 48, 66, 72},
+                MSP_CARRIER(6.0), MSP_CARRIER(6.0),
+                0x00d0, 0x0040, 0x0120, 0x3000
+        },{     /* NICAM/AM -- L (6.5/5.85) */
+                {-2, -8, -10, 10, 50, 86},
+                {-4, -12, -9, 23, 79, 126},
+                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
+                0x00c6, 0x0140, 0x0120, 0x7c03
+        },
+};
+
+struct msp3400c_carrier_detect {
+        int   cdo;
+        char *name;
+};
+
+static struct msp3400c_carrier_detect msp3400c_carrier_detect_main[] = {
+        /* main carrier */
+        { MSP_CARRIER(4.5),        "4.5   NTSC"                   },
+        { MSP_CARRIER(5.5),        "5.5   PAL B/G"                },
+        { MSP_CARRIER(6.0),        "6.0   PAL I"                  },
+        { MSP_CARRIER(6.5),        "6.5   PAL D/K + SAT + SECAM"  }
+};
+
+static struct msp3400c_carrier_detect msp3400c_carrier_detect_55[] = {
+        /* PAL B/G */
+        { MSP_CARRIER(5.7421875),  "5.742 PAL B/G FM-stereo"     },
+        { MSP_CARRIER(5.85),       "5.85  PAL B/G NICAM"         }
+};
+
+static struct msp3400c_carrier_detect msp3400c_carrier_detect_65[] = {
+        /* PAL SAT / SECAM */
+        { MSP_CARRIER(5.85),       "5.85  PAL D/K + SECAM NICAM" },
+        { MSP_CARRIER(6.2578125),  "6.25  PAL D/K1 FM-stereo" },
+        { MSP_CARRIER(6.7421875),  "6.74  PAL D/K2 FM-stereo" },
+        { MSP_CARRIER(7.02),       "7.02  PAL SAT FM-stereo s/b" },
+        { MSP_CARRIER(7.20),       "7.20  PAL SAT FM-stereo s"   },
+        { MSP_CARRIER(7.38),       "7.38  PAL SAT FM-stereo b"   },
+};
+
+/* ------------------------------------------------------------------------ */
+
+const char *msp_standard_std_name(int std)
+{
+        int i;
+
+        for (i = 0; msp_stdlist[i].name != NULL; i++)
+                if (msp_stdlist[i].retval == std)
+                        return msp_stdlist[i].name;
+        return "unknown";
+}
+
+void msp3400c_setcarrier(struct i2c_client *client, int cdo1, int cdo2)
+{
+        msp_write_dem(client, 0x0093, cdo1 & 0xfff);
+        msp_write_dem(client, 0x009b, cdo1 >> 12);
+        msp_write_dem(client, 0x00a3, cdo2 & 0xfff);
+        msp_write_dem(client, 0x00ab, cdo2 >> 12);
+        msp_write_dem(client, 0x0056, 0); /*LOAD_REG_1/2*/
+}
+
+void msp3400c_setmode(struct i2c_client *client, int type)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int i;
+
+        v4l_dbg(1, client, "setmode: %d\n", type);
+        state->mode       = type;
+        state->audmode    = V4L2_TUNER_MODE_MONO;
+        state->rxsubchans = V4L2_TUNER_SUB_MONO;
+
+        msp_write_dem(client, 0x00bb, msp3400c_init_data[type].ad_cv);
+
+        for (i = 5; i >= 0; i--)               /* fir 1 */
+                msp_write_dem(client, 0x0001, msp3400c_init_data[type].fir1[i]);
+
+        msp_write_dem(client, 0x0005, 0x0004); /* fir 2 */
+        msp_write_dem(client, 0x0005, 0x0040);
+        msp_write_dem(client, 0x0005, 0x0000);
+        for (i = 5; i >= 0; i--)
+                msp_write_dem(client, 0x0005, msp3400c_init_data[type].fir2[i]);
+
+        msp_write_dem(client, 0x0083, msp3400c_init_data[type].mode_reg);
+
+        msp3400c_setcarrier(client, msp3400c_init_data[type].cdo1,
+                            msp3400c_init_data[type].cdo2);
+
+        msp_write_dem(client, 0x0056, 0); /*LOAD_REG_1/2*/
+
+        if (dolby) {
+                msp_write_dsp(client, 0x0008, 0x0520); /* I2S1 */
+                msp_write_dsp(client, 0x0009, 0x0620); /* I2S2 */
+                msp_write_dsp(client, 0x000b, msp3400c_init_data[type].dsp_src);
+        } else {
+                msp_write_dsp(client, 0x0008, msp3400c_init_data[type].dsp_src);
+                msp_write_dsp(client, 0x0009, msp3400c_init_data[type].dsp_src);
+                msp_write_dsp(client, 0x000b, msp3400c_init_data[type].dsp_src);
+        }
+        msp_write_dsp(client, 0x000a, msp3400c_init_data[type].dsp_src);
+        msp_write_dsp(client, 0x000e, msp3400c_init_data[type].dsp_matrix);
+
+        if (state->has_nicam) {
+                /* nicam prescale */
+                msp_write_dsp(client, 0x0010, 0x5a00); /* was: 0x3000 */
+        }
+}
+
+/* turn on/off nicam + stereo */
+void msp3400c_setstereo(struct i2c_client *client, int mode)
+{
+        static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
+        struct msp_state *state = i2c_get_clientdata(client);
+        int nicam = 0;          /* channel source: FM/AM or nicam */
+        int src = 0;
+
+        if (state->opmode == OPMODE_AUTOSELECT) {
+                /* this method would break everything, let's make sure
+                 * it's never called
+                 */
+                v4l_dbg(1, client, "setstereo called with mode=%d instead of set_source (ignored)\n",
+                     mode);
+                return;
+        }
+
+        /* switch demodulator */
+        switch (state->mode) {
+        case MSP_MODE_FM_TERRA:
+                v4l_dbg(1, client, "FM setstereo: %s\n", strmode[mode]);
+                msp3400c_setcarrier(client, state->second, state->main);
+                switch (mode) {
+                case V4L2_TUNER_MODE_STEREO:
+                        msp_write_dsp(client, 0x000e, 0x3001);
+                        break;
+                case V4L2_TUNER_MODE_MONO:
+                case V4L2_TUNER_MODE_LANG1:
+                case V4L2_TUNER_MODE_LANG2:
+                        msp_write_dsp(client, 0x000e, 0x3000);
+                        break;
+                }
+                break;
+        case MSP_MODE_FM_SAT:
+                v4l_dbg(1, client, "SAT setstereo: %s\n", strmode[mode]);
+                switch (mode) {
+                case V4L2_TUNER_MODE_MONO:
+                        msp3400c_setcarrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
+                        break;
+                case V4L2_TUNER_MODE_STEREO:
+                        msp3400c_setcarrier(client, MSP_CARRIER(7.2), MSP_CARRIER(7.02));
+                        break;
+                case V4L2_TUNER_MODE_LANG1:
+                        msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
+                        break;
+                case V4L2_TUNER_MODE_LANG2:
+                        msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
+                        break;
+                }
+                break;
+        case MSP_MODE_FM_NICAM1:
+        case MSP_MODE_FM_NICAM2:
+        case MSP_MODE_AM_NICAM:
+                v4l_dbg(1, client, "NICAM setstereo: %s\n",strmode[mode]);
+                msp3400c_setcarrier(client,state->second,state->main);
+                if (state->nicam_on)
+                        nicam=0x0100;
+                break;
+        case MSP_MODE_BTSC:
+                v4l_dbg(1, client, "BTSC setstereo: %s\n",strmode[mode]);
+                nicam=0x0300;
+                break;
+        case MSP_MODE_EXTERN:
+                v4l_dbg(1, client, "extern setstereo: %s\n",strmode[mode]);
+                nicam = 0x0200;
+                break;
+        case MSP_MODE_FM_RADIO:
+                v4l_dbg(1, client, "FM-Radio setstereo: %s\n",strmode[mode]);
+                break;
+        default:
+                v4l_dbg(1, client, "mono setstereo\n");
+                return;
+        }
+
+        /* switch audio */
+        switch (mode) {
+        case V4L2_TUNER_MODE_STEREO:
+                src = 0x0020 | nicam;
+                break;
+        case V4L2_TUNER_MODE_MONO:
+                if (state->mode == MSP_MODE_AM_NICAM) {
+                        v4l_dbg(1, client, "switching to AM mono\n");
+                        /* AM mono decoding is handled by tuner, not MSP chip */
+                        /* SCART switching control register */
+                        msp_set_scart(client, SCART_MONO, 0);
+                        src = 0x0200;
+                        break;
+                }
+        case V4L2_TUNER_MODE_LANG1:
+                src = 0x0000 | nicam;
+                break;
+        case V4L2_TUNER_MODE_LANG2:
+                src = 0x0010 | nicam;
+                break;
+        }
+        v4l_dbg(1, client, "setstereo final source/matrix = 0x%x\n", src);
+
+        if (dolby) {
+                msp_write_dsp(client, 0x0008, 0x0520);
+                msp_write_dsp(client, 0x0009, 0x0620);
+                msp_write_dsp(client, 0x000a, src);
+                msp_write_dsp(client, 0x000b, src);
+        } else {
+                msp_write_dsp(client, 0x0008, src);
+                msp_write_dsp(client, 0x0009, src);
+                msp_write_dsp(client, 0x000a, src);
+                msp_write_dsp(client, 0x000b, src);
+                msp_write_dsp(client, 0x000c, src);
+                if (state->has_scart23_in_scart2_out)
+                        msp_write_dsp(client, 0x0041, src);
+        }
+}
+
+static void msp3400c_print_mode(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        if (state->main == state->second) {
+                v4l_dbg(1, client, "mono sound carrier: %d.%03d MHz\n",
+                       state->main / 910000, (state->main / 910) % 1000);
+        } else {
+                v4l_dbg(1, client, "main sound carrier: %d.%03d MHz\n",
+                       state->main / 910000, (state->main / 910) % 1000);
+        }
+        if (state->mode == MSP_MODE_FM_NICAM1 || state->mode == MSP_MODE_FM_NICAM2)
+                v4l_dbg(1, client, "NICAM/FM carrier  : %d.%03d MHz\n",
+                       state->second / 910000, (state->second/910) % 1000);
+        if (state->mode == MSP_MODE_AM_NICAM)
+                v4l_dbg(1, client, "NICAM/AM carrier  : %d.%03d MHz\n",
+                       state->second / 910000, (state->second / 910) % 1000);
+        if (state->mode == MSP_MODE_FM_TERRA && state->main != state->second) {
+                v4l_dbg(1, client, "FM-stereo carrier : %d.%03d MHz\n",
+                       state->second / 910000, (state->second / 910) % 1000);
+        }
+}
+
+/* ----------------------------------------------------------------------- */
+
+int autodetect_stereo(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int val;
+        int rxsubchans = state->rxsubchans;
+        int newnicam   = state->nicam_on;
+        int update = 0;
+
+        switch (state->mode) {
+        case MSP_MODE_FM_TERRA:
+                val = msp_read_dsp(client, 0x18);
+                if (val > 32767)
+                        val -= 65536;
+                v4l_dbg(2, client, "stereo detect register: %d\n", val);
+                if (val > 4096) {
+                        rxsubchans = V4L2_TUNER_SUB_STEREO | V4L2_TUNER_SUB_MONO;
+                } else if (val < -4096) {
+                        rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+                } else {
+                        rxsubchans = V4L2_TUNER_SUB_MONO;
+                }
+                newnicam = 0;
+                break;
+        case MSP_MODE_FM_NICAM1:
+        case MSP_MODE_FM_NICAM2:
+        case MSP_MODE_AM_NICAM:
+                val = msp_read_dem(client, 0x23);
+                v4l_dbg(2, client, "nicam sync=%d, mode=%d\n",
+                        val & 1, (val & 0x1e) >> 1);
+
+                if (val & 1) {
+                        /* nicam synced */
+                        switch ((val & 0x1e) >> 1)  {
+                        case 0:
+                        case 8:
+                                rxsubchans = V4L2_TUNER_SUB_STEREO;
+                                break;
+                        case 1:
+                        case 9:
+                                rxsubchans = V4L2_TUNER_SUB_MONO
+                                        | V4L2_TUNER_SUB_LANG1;
+                                break;
+                        case 2:
+                        case 10:
+                                rxsubchans = V4L2_TUNER_SUB_MONO
+                                        | V4L2_TUNER_SUB_LANG1
+                                        | V4L2_TUNER_SUB_LANG2;
+                                break;
+                        default:
+                                rxsubchans = V4L2_TUNER_SUB_MONO;
+                                break;
+                        }
+                        newnicam = 1;
+                } else {
+                        newnicam = 0;
+                        rxsubchans = V4L2_TUNER_SUB_MONO;
+                }
+                break;
+        case MSP_MODE_BTSC:
+                val = msp_read_dem(client, 0x200);
+                v4l_dbg(2, client, "status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
+                        val,
+                        (val & 0x0002) ? "no"     : "yes",
+                        (val & 0x0004) ? "no"     : "yes",
+                        (val & 0x0040) ? "stereo" : "mono",
+                        (val & 0x0080) ? ", nicam 2nd mono" : "",
+                        (val & 0x0100) ? ", bilingual/SAP"  : "");
+                rxsubchans = V4L2_TUNER_SUB_MONO;
+                if (val & 0x0040) rxsubchans |= V4L2_TUNER_SUB_STEREO;
+                if (val & 0x0100) rxsubchans |= V4L2_TUNER_SUB_LANG1;
+                break;
+        }
+        if (rxsubchans != state->rxsubchans) {
+                update = 1;
+                v4l_dbg(1, client, "watch: rxsubchans %d => %d\n",
+                        state->rxsubchans,rxsubchans);
+                state->rxsubchans = rxsubchans;
+        }
+        if (newnicam != state->nicam_on) {
+                update = 1;
+                v4l_dbg(1, client, "watch: nicam %d => %d\n",
+                        state->nicam_on,newnicam);
+                state->nicam_on = newnicam;
+        }
+        return update;
+}
+
+/*
+ * A kernel thread for msp3400 control -- we don't want to block the
+ * in the ioctl while doing the sound carrier & stereo detect
+ */
+/* stereo/multilang monitoring */
+static void watch_stereo(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        if (autodetect_stereo(client)) {
+                if (state->rxsubchans & V4L2_TUNER_SUB_STEREO)
+                        msp3400c_setstereo(client, V4L2_TUNER_MODE_STEREO);
+                else if (state->rxsubchans & V4L2_TUNER_SUB_LANG1)
+                        msp3400c_setstereo(client, V4L2_TUNER_MODE_LANG1);
+                else
+                        msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+        }
+
+        if (once)
+                state->watch_stereo = 0;
+}
+
+int msp3400c_thread(void *data)
+{
+        struct i2c_client *client = data;
+        struct msp_state *state = i2c_get_clientdata(client);
+        struct msp3400c_carrier_detect *cd;
+        int count, max1,max2,val1,val2, val,this;
+
+
+        v4l_dbg(1, client, "msp3400 daemon started\n");
+        for (;;) {
+                v4l_dbg(2, client, "msp3400 thread: sleep\n");
+                msp_sleep(state, -1);
+                v4l_dbg(2, client, "msp3400 thread: wakeup\n");
+
+        restart:
+                v4l_dbg(1, client, "thread: restart scan\n");
+                state->restart = 0;
+                if (kthread_should_stop())
+                        break;
+
+                if (state->radio || MSP_MODE_EXTERN == state->mode) {
+                        /* no carrier scan, just unmute */
+                        v4l_dbg(1, client, "thread: no carrier scan\n");
+                        msp_set_audio(client);
+                        continue;
+                }
+
+                /* mute */
+                msp_set_mute(client);
+                msp3400c_setmode(client, MSP_MODE_AM_DETECT /* +1 */ );
+                val1 = val2 = 0;
+                max1 = max2 = -1;
+                state->watch_stereo = 0;
+
+                /* some time for the tuner to sync */
+                if (msp_sleep(state,200))
+                        goto restart;
+
+                /* carrier detect pass #1 -- main carrier */
+                cd = msp3400c_carrier_detect_main;
+                count = ARRAY_SIZE(msp3400c_carrier_detect_main);
+
+                if (amsound && (state->v4l2_std & V4L2_STD_SECAM)) {
+                        /* autodetect doesn't work well with AM ... */
+                        max1 = 3;
+                        count = 0;
+                        v4l_dbg(1, client, "AM sound override\n");
+                }
+
+                for (this = 0; this < count; this++) {
+                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
+                        if (msp_sleep(state,100))
+                                goto restart;
+                        val = msp_read_dsp(client, 0x1b);
+                        if (val > 32767)
+                                val -= 65536;
+                        if (val1 < val)
+                                val1 = val, max1 = this;
+                        v4l_dbg(1, client, "carrier1 val: %5d / %s\n", val,cd[this].name);
+                }
+
+                /* carrier detect pass #2 -- second (stereo) carrier */
+                switch (max1) {
+                case 1: /* 5.5 */
+                        cd = msp3400c_carrier_detect_55;
+                        count = ARRAY_SIZE(msp3400c_carrier_detect_55);
+                        break;
+                case 3: /* 6.5 */
+                        cd = msp3400c_carrier_detect_65;
+                        count = ARRAY_SIZE(msp3400c_carrier_detect_65);
+                        break;
+                case 0: /* 4.5 */
+                case 2: /* 6.0 */
+                default:
+                        cd = NULL;
+                        count = 0;
+                        break;
+                }
+
+                if (amsound && (state->v4l2_std & V4L2_STD_SECAM)) {
+                        /* autodetect doesn't work well with AM ... */
+                        cd = NULL;
+                        count = 0;
+                        max2 = 0;
+                }
+                for (this = 0; this < count; this++) {
+                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
+                        if (msp_sleep(state,100))
+                                goto restart;
+                        val = msp_read_dsp(client, 0x1b);
+                        if (val > 32767)
+                                val -= 65536;
+                        if (val2 < val)
+                                val2 = val, max2 = this;
+                        v4l_dbg(1, client, "carrier2 val: %5d / %s\n", val,cd[this].name);
+                }
+
+                /* program the msp3400 according to the results */
+                state->main   = msp3400c_carrier_detect_main[max1].cdo;
+                switch (max1) {
+                case 1: /* 5.5 */
+                        if (max2 == 0) {
+                                /* B/G FM-stereo */
+                                state->second = msp3400c_carrier_detect_55[max2].cdo;
+                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                                state->nicam_on = 0;
+                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                                state->watch_stereo = 1;
+                        } else if (max2 == 1 && state->has_nicam) {
+                                /* B/G NICAM */
+                                state->second = msp3400c_carrier_detect_55[max2].cdo;
+                                msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
+                                state->nicam_on = 1;
+                                msp3400c_setcarrier(client, state->second, state->main);
+                                state->watch_stereo = 1;
+                        } else {
+                                goto no_second;
+                        }
+                        break;
+                case 2: /* 6.0 */
+                        /* PAL I NICAM */
+                        state->second = MSP_CARRIER(6.552);
+                        msp3400c_setmode(client, MSP_MODE_FM_NICAM2);
+                        state->nicam_on = 1;
+                        msp3400c_setcarrier(client, state->second, state->main);
+                        state->watch_stereo = 1;
+                        break;
+                case 3: /* 6.5 */
+                        if (max2 == 1 || max2 == 2) {
+                                /* D/K FM-stereo */
+                                state->second = msp3400c_carrier_detect_65[max2].cdo;
+                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                                state->nicam_on = 0;
+                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                                state->watch_stereo = 1;
+                        } else if (max2 == 0 && (state->v4l2_std & V4L2_STD_SECAM)) {
+                                /* L NICAM or AM-mono */
+                                state->second = msp3400c_carrier_detect_65[max2].cdo;
+                                msp3400c_setmode(client, MSP_MODE_AM_NICAM);
+                                state->nicam_on = 0;
+                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                                msp3400c_setcarrier(client, state->second, state->main);
+                                /* volume prescale for SCART (AM mono input) */
+                                msp_write_dsp(client, 0x000d, 0x1900);
+                                state->watch_stereo = 1;
+                        } else if (max2 == 0 && state->has_nicam) {
+                                /* D/K NICAM */
+                                state->second = msp3400c_carrier_detect_65[max2].cdo;
+                                msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
+                                state->nicam_on = 1;
+                                msp3400c_setcarrier(client, state->second, state->main);
+                                state->watch_stereo = 1;
+                        } else {
+                                goto no_second;
+                        }
+                        break;
+                case 0: /* 4.5 */
+                default:
+                no_second:
+                        state->second = msp3400c_carrier_detect_main[max1].cdo;
+                        msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                        state->nicam_on = 0;
+                        msp3400c_setcarrier(client, state->second, state->main);
+                        state->rxsubchans = V4L2_TUNER_SUB_MONO;
+                        msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                        break;
+                }
+
+                /* unmute */
+                msp_set_audio(client);
+
+                if (debug)
+                        msp3400c_print_mode(client);
+
+                /* monitor tv audio mode */
+                while (state->watch_stereo) {
+                        if (msp_sleep(state,5000))
+                                goto restart;
+                        watch_stereo(client);
+                }
+        }
+        v4l_dbg(1, client, "thread: exit\n");
+        return 0;
+}
+
+
+int msp3410d_thread(void *data)
+{
+        struct i2c_client *client = data;
+        struct msp_state *state = i2c_get_clientdata(client);
+        int val, i, std;
+
+        v4l_dbg(1, client, "msp3410 daemon started\n");
+
+        for (;;) {
+                v4l_dbg(2, client, "msp3410 thread: sleep\n");
+                msp_sleep(state,-1);
+                v4l_dbg(2, client, "msp3410 thread: wakeup\n");
+
+        restart:
+                v4l_dbg(1, client, "thread: restart scan\n");
+                state->restart = 0;
+                if (kthread_should_stop())
+                        break;
+
+                if (state->mode == MSP_MODE_EXTERN) {
+                        /* no carrier scan needed, just unmute */
+                        v4l_dbg(1, client, "thread: no carrier scan\n");
+                        msp_set_audio(client);
+                        continue;
+                }
+
+                /* put into sane state (and mute) */
+                msp_reset(client);
+
+                /* some time for the tuner to sync */
+                if (msp_sleep(state,200))
+                        goto restart;
+
+                /* start autodetect */
+                if (state->radio)
+                        std = 0x40;
+                else
+                        std = (state->v4l2_std & V4L2_STD_NTSC) ? 0x20 : 1;
+                state->watch_stereo = 0;
+
+                if (debug)
+                        v4l_dbg(1, client, "setting standard: %s (0x%04x)\n",
+                               msp_standard_std_name(std), std);
+
+                if (std != 1) {
+                        /* programmed some specific mode */
+                        val = std;
+                } else {
+                        /* triggered autodetect */
+                        msp_write_dem(client, 0x20, std);
+                        for (;;) {
+                                if (msp_sleep(state, 100))
+                                        goto restart;
+
+                                /* check results */
+                                val = msp_read_dem(client, 0x7e);
+                                if (val < 0x07ff)
+                                        break;
+                                v4l_dbg(1, client, "detection still in progress\n");
+                        }
+                }
+                for (i = 0; msp_stdlist[i].name != NULL; i++)
+                        if (msp_stdlist[i].retval == val)
+                                break;
+                v4l_dbg(1, client, "current standard: %s (0x%04x)\n",
+                        msp_standard_std_name(val), val);
+                state->main   = msp_stdlist[i].main;
+                state->second = msp_stdlist[i].second;
+                state->std = val;
+
+                if (amsound && !state->radio && (state->v4l2_std & V4L2_STD_SECAM) &&
+                                (val != 0x0009)) {
+                        /* autodetection has failed, let backup */
+                        v4l_dbg(1, client, "autodetection failed,"
+                                " switching to backup standard: %s (0x%04x)\n",
+                                msp_stdlist[8].name ? msp_stdlist[8].name : "unknown",val);
+                        val = 0x0009;
+                        msp_write_dem(client, 0x20, val);
+                }
+
+                /* set various prescales */
+                msp_write_dsp(client, 0x0d, 0x1900); /* scart */
+                msp_write_dsp(client, 0x0e, 0x2403); /* FM */
+                msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
+
+                /* set stereo */
+                switch (val) {
+                case 0x0008: /* B/G NICAM */
+                case 0x000a: /* I NICAM */
+                        if (val == 0x0008)
+                                state->mode = MSP_MODE_FM_NICAM1;
+                        else
+                                state->mode = MSP_MODE_FM_NICAM2;
+                        /* just turn on stereo */
+                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                        state->nicam_on = 1;
+                        state->watch_stereo = 1;
+                        msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
+                        break;
+                case 0x0009:
+                        state->mode = MSP_MODE_AM_NICAM;
+                        state->rxsubchans = V4L2_TUNER_SUB_MONO;
+                        state->nicam_on = 1;
+                        msp3400c_setstereo(client,V4L2_TUNER_MODE_MONO);
+                        state->watch_stereo = 1;
+                        break;
+                case 0x0020: /* BTSC */
+                        /* just turn on stereo */
+                        state->mode = MSP_MODE_BTSC;
+                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                        state->nicam_on = 0;
+                        state->watch_stereo = 1;
+                        msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
+                        break;
+                case 0x0040: /* FM radio */
+                        state->mode = MSP_MODE_FM_RADIO;
+                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                        state->audmode = V4L2_TUNER_MODE_STEREO;
+                        state->nicam_on = 0;
+                        state->watch_stereo = 0;
+                        /* not needed in theory if we have radio, but
+                           short programming enables carrier mute */
+                        msp3400c_setmode(client, MSP_MODE_FM_RADIO);
+                        msp3400c_setcarrier(client, MSP_CARRIER(10.7),
+                                            MSP_CARRIER(10.7));
+                        /* scart routing */
+                        msp_set_scart(client,SCART_IN2,0);
+                        /* msp34xx does radio decoding */
+                        msp_write_dsp(client, 0x08, 0x0020);
+                        msp_write_dsp(client, 0x09, 0x0020);
+                        msp_write_dsp(client, 0x0b, 0x0020);
+                        break;
+                case 0x0003:
+                case 0x0004:
+                case 0x0005:
+                        state->mode = MSP_MODE_FM_TERRA;
+                        state->rxsubchans = V4L2_TUNER_SUB_MONO;
+                        state->audmode = V4L2_TUNER_MODE_MONO;
+                        state->nicam_on = 0;
+                        state->watch_stereo = 1;
+                        break;
+                }
+
+                /* unmute, restore misc registers */
+                msp_set_audio(client);
+                msp_write_dsp(client, 0x13, state->acb);
+                if (state->has_i2s_conf)
+                        msp_write_dem(client, 0x40, state->i2s_mode);
+
+                /* monitor tv audio mode */
+                while (state->watch_stereo) {
+                        if (msp_sleep(state,5000))
+                                goto restart;
+                        watch_stereo(client);
+                }
+        }
+        v4l_dbg(1, client, "thread: exit\n");
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+/* msp34xxG + (autoselect no-thread)                                          */
+/* this one uses both automatic standard detection and automatic sound     */
+/* select which are available in the newer G versions                      */
+/* struct msp: only norm, acb and source are really used in this mode      */
+
+/* set the same 'source' for the loudspeaker, scart and quasi-peak detector
+ * the value for source is the same as bit 15:8 of DSP registers 0x08,
+ * 0x0a and 0x0c: 0=mono, 1=stereo or A|B, 2=SCART, 3=stereo or A, 4=stereo or B
+ *
+ * this function replaces msp3400c_setstereo
+ */
+static void msp34xxg_set_source(struct i2c_client *client, int source)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        /* fix matrix mode to stereo and let the msp choose what
+         * to output according to 'source', as recommended
+         * for MONO (source==0) downmixing set bit[7:0] to 0x30
+         */
+        int value = (source & 0x07) << 8 | (source == 0 ? 0x30 : 0x20);
+
+        v4l_dbg(1, client, "set source to %d (0x%x)\n", source, value);
+        /* Loudspeaker Output */
+        msp_write_dsp(client, 0x08, value);
+        /* SCART1 DA Output */
+        msp_write_dsp(client, 0x0a, value);
+        /* Quasi-peak detector */
+        msp_write_dsp(client, 0x0c, value);
+        /*
+         * set identification threshold. Personally, I
+         * I set it to a higher value that the default
+         * of 0x190 to ignore noisy stereo signals.
+         * this needs tuning. (recommended range 0x00a0-0x03c0)
+         * 0x7f0 = forced mono mode
+         */
+        /* a2 threshold for stereo/bilingual */
+        msp_write_dem(client, 0x22, stereo_threshold);
+        state->source = source;
+}
+
+/* (re-)initialize the msp34xxg, according to the current norm in state->norm
+ * return 0 if it worked, -1 if it failed
+ */
+static int msp34xxg_reset(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int modus, std;
+
+        if (msp_reset(client))
+                return -1;
+
+        /* make sure that input/output is muted (paranoid mode) */
+        /* ACB, mute DSP input, mute SCART 1 */
+        if (msp_write_dsp(client, 0x13, 0x0f20))
+                return -1;
+
+        if (state->has_i2s_conf)
+                msp_write_dem(client, 0x40, state->i2s_mode);
+
+        /* step-by-step initialisation, as described in the manual */
+        modus = msp_modus(client);
+        if (state->radio)
+                std = 0x40;
+        else
+                std = (state->v4l2_std & V4L2_STD_NTSC) ? 0x20 : 1;
+        modus &= ~0x03; /* STATUS_CHANGE = 0 */
+        modus |= 0x01;  /* AUTOMATIC_SOUND_DETECTION = 1 */
+        if (msp_write_dem(client, 0x30, modus))
+                return -1;
+        if (msp_write_dem(client, 0x20, std))
+                return -1;
+
+        /* write the dsps that may have an influence on
+           standard/audio autodetection right now */
+        msp34xxg_set_source(client, state->source);
+
+        /* AM/FM Prescale [15:8] 75khz deviation */
+        if (msp_write_dsp(client, 0x0e, 0x3000))
+                return -1;
+
+        /* NICAM Prescale 9db gain (as recommended) */
+        if (msp_write_dsp(client, 0x10, 0x5a00))
+                return -1;
+
+        return 0;
+}
+
+int msp34xxg_thread(void *data)
+{
+        struct i2c_client *client = data;
+        struct msp_state *state = i2c_get_clientdata(client);
+        int val, std, i;
+
+        v4l_dbg(1, client, "msp34xxg daemon started\n");
+
+        state->source = 1; /* default */
+        for (;;) {
+                v4l_dbg(2, client, "msp34xxg thread: sleep\n");
+                msp_sleep(state, -1);
+                v4l_dbg(2, client, "msp34xxg thread: wakeup\n");
+
+        restart:
+                v4l_dbg(1, client, "thread: restart scan\n");
+                state->restart = 0;
+                if (kthread_should_stop())
+                        break;
+
+                /* setup the chip*/
+                msp34xxg_reset(client);
+                std = standard;
+                if (std != 0x01)
+                        goto unmute;
+
+                /* watch autodetect */
+                v4l_dbg(1, client, "triggered autodetect, waiting for result\n");
+                for (i = 0; i < 10; i++) {
+                        if (msp_sleep(state, 100))
+                                goto restart;
+
+                        /* check results */
+                        val = msp_read_dem(client, 0x7e);
+                        if (val < 0x07ff) {
+                                std = val;
+                                break;
+                        }
+                        v4l_dbg(2, client, "detection still in progress\n");
+                }
+                if (std == 1) {
+                        v4l_dbg(1, client, "detection still in progress after 10 tries. giving up.\n");
+                        continue;
+                }
+
+        unmute:
+                state->std = std;
+                v4l_dbg(1, client, "current standard: %s (0x%04x)\n",
+                        msp_standard_std_name(std), std);
+
+                /* unmute: dispatch sound to scart output, set scart volume */
+                msp_set_audio(client);
+
+                /* restore ACB */
+                if (msp_write_dsp(client, 0x13, state->acb))
+                        return -1;
+
+                msp_write_dem(client, 0x40, state->i2s_mode);
+        }
+        v4l_dbg(1, client, "thread: exit\n");
+        return 0;
+}
+
+void msp34xxg_detect_stereo(struct i2c_client *client)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+
+        int status = msp_read_dem(client, 0x0200);
+        int is_bilingual = status & 0x100;
+        int is_stereo = status & 0x40;
+
+        state->rxsubchans = 0;
+        if (is_stereo)
+                state->rxsubchans |= V4L2_TUNER_SUB_STEREO;
+        else
+                state->rxsubchans |= V4L2_TUNER_SUB_MONO;
+        if (is_bilingual) {
+                state->rxsubchans |= V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+                /* I'm supposed to check whether it's SAP or not
+                 * and set only LANG2/SAP in this case. Yet, the MSP
+                 * does a lot of work to hide this and handle everything
+                 * the same way. I don't want to work around it so unless
+                 * this is a problem, I'll handle SAP just like lang1/lang2.
+                 */
+        }
+        v4l_dbg(1, client, "status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
+                status, is_stereo, is_bilingual, state->rxsubchans);
+}
+
+void msp34xxg_set_audmode(struct i2c_client *client, int audmode)
+{
+        struct msp_state *state = i2c_get_clientdata(client);
+        int source;
+
+        switch (audmode) {
+        case V4L2_TUNER_MODE_MONO:
+                source = 0; /* mono only */
+                break;
+        case V4L2_TUNER_MODE_STEREO:
+                source = 1; /* stereo or A|B, see comment in msp34xxg_get_v4l2_stereo() */
+                /* problem: that could also mean 2 (scart input) */
+                break;
+        case V4L2_TUNER_MODE_LANG1:
+                source = 3; /* stereo or A */
+                break;
+        case V4L2_TUNER_MODE_LANG2:
+                source = 4; /* stereo or B */
+                break;
+        default:
+                audmode = 0;
+                source  = 1;
+                break;
+        }
+        state->audmode = audmode;
+        msp34xxg_set_source(client, source);
+}
+
diff --git a/drivers/media/video/msp3400.c b/drivers/media/video/msp3400.c
deleted file mode 100644
index 183253e2dd91..000000000000
--- a/drivers/media/video/msp3400.c
+++ /dev/null
@@ -1,2229 +0,0 @@
-/*
- * programming the msp34* sound processor family
- *
- * (c) 1997-2001 Gerd Knorr <kraxel@bytesex.org>
- *
- * what works and what doesn't:
- *
- *  AM-Mono
- *      Support for Hauppauge cards added (decoding handled by tuner) added by
- *      Frederic Crozat <fcrozat@mail.dotcom.fr>
- *
- *  FM-Mono
- *      should work. The stereo modes are backward compatible to FM-mono,
- *      therefore FM-Mono should be allways available.
- *
- *  FM-Stereo (B/G, used in germany)
- *      should work, with autodetect
- *
- *  FM-Stereo (satellite)
- *      should work, no autodetect (i.e. default is mono, but you can
- *      switch to stereo -- untested)
- *
- *  NICAM (B/G, L , used in UK, Scandinavia, Spain and France)
- *      should work, with autodetect. Support for NICAM was added by
- *      Pekka Pietikainen <pp@netppl.fi>
- *
- *
- * TODO:
- *   - better SAT support
- *
- *
- * 980623  Thomas Sailer (sailer@ife.ee.ethz.ch)
- *         using soundcore instead of OSS
- *
- */
-
-#include <linux/config.h>
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/kernel.h>
-#include <linux/sched.h>
-#include <linux/string.h>
-#include <linux/timer.h>
-#include <linux/delay.h>
-#include <linux/errno.h>
-#include <linux/slab.h>
-#include <linux/i2c.h>
-#include <linux/videodev.h>
-#include <linux/init.h>
-#include <linux/smp_lock.h>
-#include <linux/kthread.h>
-#include <linux/suspend.h>
-#include <asm/semaphore.h>
-#include <asm/pgtable.h>
-
-#include <media/audiochip.h>
-#include "msp3400.h"
-
-#define msp3400_dbg(fmt, arg...) \
-        do { \
-                if (debug) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                               client->driver->driver.name, \
-                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-/* Medium volume debug. */
-#define msp3400_dbg_mediumvol(fmt, arg...) \
-        do { \
-                if (debug >= 2) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                                client->driver->driver.name, \
-                                i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-/* High volume debug. Use with care. */
-#define msp3400_dbg_highvol(fmt, arg...) \
-        do { \
-                if (debug >= 16) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                                client->driver->driver.name, \
-                                i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-#define msp3400_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-                i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define msp3400_warn(fmt, arg...) do { \
-        printk(KERN_WARNING "%s %d-%04x: " fmt, client->driver->driver.name, \
-                i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define msp3400_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-                i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
-#define OPMODE_AUTO    -1
-#define OPMODE_MANUAL   0
-#define OPMODE_SIMPLE   1   /* use short programming (>= msp3410 only) */
-#define OPMODE_SIMPLER  2   /* use shorter programming (>= msp34xxG)   */
-
-/* insmod parameters */
-static int opmode   = OPMODE_AUTO;
-static int debug    = 0;    /* debug output */
-static int once     = 0;    /* no continous stereo monitoring */
-static int amsound  = 0;    /* hard-wire AM sound at 6.5 Hz (france),
-                               the autoscan seems work well only with FM... */
-static int standard = 1;    /* Override auto detect of audio standard, if needed. */
-static int dolby    = 0;
-
-static int stereo_threshold = 0x190; /* a2 threshold for stereo/bilingual
-                                        (msp34xxg only) 0x00a0-0x03c0 */
-#define DFP_COUNT 0x41
-static const int bl_dfp[] = {
-        0x00, 0x01, 0x02, 0x03, 0x06, 0x08, 0x09, 0x0a,
-        0x0b, 0x0d, 0x0e, 0x10
-};
-
-#define IS_MSP34XX_G(msp) ((msp)->opmode==2)
-
-struct msp3400c {
-        int rev1,rev2;
-
-        int opmode;
-        int nicam;
-        int mode;
-        int norm;
-        int stereo;
-        int nicam_on;
-        int acb;
-        int in_scart;
-        int i2s_mode;
-        int main, second;       /* sound carrier */
-        int input;
-        int source;             /* see msp34xxg_set_source */
-
-        /* v4l2 */
-        int audmode;
-        int rxsubchans;
-
-        int muted;
-        int left, right;        /* volume */
-        int bass, treble;
-
-        /* shadow register set */
-        int dfp_regs[DFP_COUNT];
-
-        /* thread */
-        struct task_struct   *kthread;
-        wait_queue_head_t    wq;
-        int                  restart:1;
-        int                  watch_stereo:1;
-};
-
-#define MIN(a,b) (((a)>(b))?(b):(a))
-#define MAX(a,b) (((a)>(b))?(a):(b))
-#define HAVE_NICAM(msp)   (((msp->rev2>>8) & 0xff) != 00)
-#define HAVE_SIMPLE(msp)  ((msp->rev1      & 0xff) >= 'D'-'@')
-#define HAVE_SIMPLER(msp) ((msp->rev1      & 0xff) >= 'G'-'@')
-#define HAVE_RADIO(msp)   ((msp->rev1      & 0xff) >= 'G'-'@')
-
-#define VIDEO_MODE_RADIO 16      /* norm magic for radio mode */
-
-/* ---------------------------------------------------------------------- */
-
-/* read-only */
-module_param(opmode,           int, 0444);
-
-/* read-write */
-module_param(once,             int, 0644);
-module_param(debug,            int, 0644);
-module_param(stereo_threshold, int, 0644);
-module_param(standard,         int, 0644);
-module_param(amsound,          int, 0644);
-module_param(dolby,            int, 0644);
-
-MODULE_PARM_DESC(opmode, "Forces a MSP3400 opmode. 0=Manual, 1=Simple, 2=Simpler");
-MODULE_PARM_DESC(once, "No continuous stereo monitoring");
-MODULE_PARM_DESC(debug, "Enable debug messages");
-MODULE_PARM_DESC(stereo_threshold, "Sets signal threshold to activate stereo");
-MODULE_PARM_DESC(standard, "Specify audio standard: 32 = NTSC, 64 = radio, Default: Autodetect");
-MODULE_PARM_DESC(amsound, "Hardwire AM sound at 6.5Hz (France), FM can autoscan");
-MODULE_PARM_DESC(dolby, "Activates Dolby processsing");
-
-/* ---------------------------------------------------------------------- */
-
-#define I2C_MSP3400C       0x80
-#define I2C_MSP3400C_ALT   0x88
-
-#define I2C_MSP3400C_DEM   0x10
-#define I2C_MSP3400C_DFP   0x12
-
-/* Addresses to scan */
-static unsigned short normal_i2c[] = {
-        I2C_MSP3400C      >> 1,
-        I2C_MSP3400C_ALT  >> 1,
-        I2C_CLIENT_END
-};
-I2C_CLIENT_INSMOD;
-
-MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
-MODULE_AUTHOR("Gerd Knorr");
-MODULE_LICENSE("GPL");
-
-/* ----------------------------------------------------------------------- */
-/* functions for talking to the MSP3400C Sound processor                   */
-
-static int msp3400c_reset(struct i2c_client *client)
-{
-        /* reset and read revision code */
-        static char reset_off[3] = { 0x00, 0x80, 0x00 };
-        static char reset_on[3]  = { 0x00, 0x00, 0x00 };
-        static char write[3]     = { I2C_MSP3400C_DFP + 1, 0x00, 0x1e };
-        char read[2];
-        struct i2c_msg reset[2] = {
-                { client->addr, I2C_M_IGNORE_NAK, 3, reset_off },
-                { client->addr, I2C_M_IGNORE_NAK, 3, reset_on  },
-        };
-        struct i2c_msg test[2] = {
-                { client->addr, 0,        3, write },
-                { client->addr, I2C_M_RD, 2, read  },
-        };
-
-        msp3400_dbg_highvol("msp3400c_reset\n");
-        if ( (1 != i2c_transfer(client->adapter,&reset[0],1)) ||
-             (1 != i2c_transfer(client->adapter,&reset[1],1)) ||
-             (2 != i2c_transfer(client->adapter,test,2)) ) {
-                msp3400_err("chip reset failed\n");
-                return -1;
-        }
-        return 0;
-}
-
-static int msp3400c_read(struct i2c_client *client, int dev, int addr)
-{
-        int err,retval;
-
-        unsigned char write[3];
-        unsigned char read[2];
-        struct i2c_msg msgs[2] = {
-                { client->addr, 0,        3, write },
-                { client->addr, I2C_M_RD, 2, read  }
-        };
-
-        write[0] = dev+1;
-        write[1] = addr >> 8;
-        write[2] = addr & 0xff;
-
-        for (err = 0; err < 3;) {
-                if (2 == i2c_transfer(client->adapter,msgs,2))
-                        break;
-                err++;
-                msp3400_warn("I/O error #%d (read 0x%02x/0x%02x)\n", err,
-                       dev, addr);
-                current->state = TASK_INTERRUPTIBLE;
-                schedule_timeout(msecs_to_jiffies(10));
-        }
-        if (3 == err) {
-                msp3400_warn("giving up, resetting chip. Sound will go off, sorry folks :-|\n");
-                msp3400c_reset(client);
-                return -1;
-        }
-        retval = read[0] << 8 | read[1];
-        msp3400_dbg_highvol("msp3400c_read(0x%x, 0x%x): 0x%x\n", dev, addr, retval);
-        return retval;
-}
-
-static int msp3400c_write(struct i2c_client *client, int dev, int addr, int val)
-{
-        int err;
-        unsigned char buffer[5];
-
-        buffer[0] = dev;
-        buffer[1] = addr >> 8;
-        buffer[2] = addr &  0xff;
-        buffer[3] = val  >> 8;
-        buffer[4] = val  &  0xff;
-
-        msp3400_dbg_highvol("msp3400c_write(0x%x, 0x%x, 0x%x)\n", dev, addr, val);
-        for (err = 0; err < 3;) {
-                if (5 == i2c_master_send(client, buffer, 5))
-                        break;
-                err++;
-                msp3400_warn("I/O error #%d (write 0x%02x/0x%02x)\n", err,
-                       dev, addr);
-                current->state = TASK_INTERRUPTIBLE;
-                schedule_timeout(msecs_to_jiffies(10));
-        }
-        if (3 == err) {
-                msp3400_warn("giving up, reseting chip. Sound will go off, sorry folks :-|\n");
-                msp3400c_reset(client);
-                return -1;
-        }
-        return 0;
-}
-
-/* ------------------------------------------------------------------------ */
-
-/* This macro is allowed for *constants* only, gcc must calculate it
-   at compile time.  Remember -- no floats in kernel mode */
-#define MSP_CARRIER(freq) ((int)((float)(freq/18.432)*(1<<24)))
-
-#define MSP_MODE_AM_DETECT   0
-#define MSP_MODE_FM_RADIO    2
-#define MSP_MODE_FM_TERRA    3
-#define MSP_MODE_FM_SAT      4
-#define MSP_MODE_FM_NICAM1   5
-#define MSP_MODE_FM_NICAM2   6
-#define MSP_MODE_AM_NICAM    7
-#define MSP_MODE_BTSC        8
-#define MSP_MODE_EXTERN      9
-
-static struct MSP_INIT_DATA_DEM {
-        int fir1[6];
-        int fir2[6];
-        int cdo1;
-        int cdo2;
-        int ad_cv;
-        int mode_reg;
-        int dfp_src;
-        int dfp_matrix;
-} msp_init_data[] = {
-        {       /* AM (for carrier detect / msp3400) */
-                {75, 19, 36, 35, 39, 40},
-                {75, 19, 36, 35, 39, 40},
-                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-                0x00d0, 0x0500, 0x0020, 0x3000
-        },{     /* AM (for carrier detect / msp3410) */
-                {-1, -1, -8, 2, 59, 126},
-                {-1, -1, -8, 2, 59, 126},
-                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-                0x00d0, 0x0100, 0x0020, 0x3000
-        },{     /* FM Radio */
-                {-8, -8, 4, 6, 78, 107},
-                {-8, -8, 4, 6, 78, 107},
-                MSP_CARRIER(10.7), MSP_CARRIER(10.7),
-                0x00d0, 0x0480, 0x0020, 0x3000
-        },{     /* Terrestial FM-mono + FM-stereo */
-                {3, 18, 27, 48, 66, 72},
-                {3, 18, 27, 48, 66, 72},
-                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-                0x00d0, 0x0480, 0x0030, 0x3000
-        },{     /* Sat FM-mono */
-                { 1, 9, 14, 24, 33, 37},
-                { 3, 18, 27, 48, 66, 72},
-                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
-                0x00c6, 0x0480, 0x0000, 0x3000
-        },{     /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
-                {-2, -8, -10, 10, 50, 86},
-                {3, 18, 27, 48, 66, 72},
-                MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-                0x00d0, 0x0040, 0x0120, 0x3000
-        },{     /* NICAM/FM -- I (6.0/6.552) */
-                {2, 4, -6, -4, 40, 94},
-                {3, 18, 27, 48, 66, 72},
-                MSP_CARRIER(6.0), MSP_CARRIER(6.0),
-                0x00d0, 0x0040, 0x0120, 0x3000
-        },{     /* NICAM/AM -- L (6.5/5.85) */
-                {-2, -8, -10, 10, 50, 86},
-                {-4, -12, -9, 23, 79, 126},
-                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
-                0x00c6, 0x0140, 0x0120, 0x7c03
-        },
-};
-
-struct CARRIER_DETECT {
-        int   cdo;
-        char *name;
-};
-
-static struct CARRIER_DETECT carrier_detect_main[] = {
-        /* main carrier */
-        { MSP_CARRIER(4.5),        "4.5   NTSC"                   },
-        { MSP_CARRIER(5.5),        "5.5   PAL B/G"                },
-        { MSP_CARRIER(6.0),        "6.0   PAL I"                  },
-        { MSP_CARRIER(6.5),        "6.5   PAL D/K + SAT + SECAM"  }
-};
-
-static struct CARRIER_DETECT carrier_detect_55[] = {
-        /* PAL B/G */
-        { MSP_CARRIER(5.7421875),  "5.742 PAL B/G FM-stereo"     },
-        { MSP_CARRIER(5.85),       "5.85  PAL B/G NICAM"         }
-};
-
-static struct CARRIER_DETECT carrier_detect_65[] = {
-        /* PAL SAT / SECAM */
-        { MSP_CARRIER(5.85),       "5.85  PAL D/K + SECAM NICAM" },
-        { MSP_CARRIER(6.2578125),  "6.25  PAL D/K1 FM-stereo" },
-        { MSP_CARRIER(6.7421875),  "6.74  PAL D/K2 FM-stereo" },
-        { MSP_CARRIER(7.02),       "7.02  PAL SAT FM-stereo s/b" },
-        { MSP_CARRIER(7.20),       "7.20  PAL SAT FM-stereo s"   },
-        { MSP_CARRIER(7.38),       "7.38  PAL SAT FM-stereo b"   },
-};
-
-#define CARRIER_COUNT(x) (sizeof(x)/sizeof(struct CARRIER_DETECT))
-
-/* ----------------------------------------------------------------------- *
- * bits  9  8  5 - SCART DSP input Select:
- *       0  0  0 - SCART 1 to DSP input (reset position)
- *       0  1  0 - MONO to DSP input
- *       1  0  0 - SCART 2 to DSP input
- *       1  1  1 - Mute DSP input
- *
- * bits 11 10  6 - SCART 1 Output Select:
- *       0  0  0 - undefined (reset position)
- *       0  1  0 - SCART 2 Input to SCART 1 Output (for devices with 2 SCARTS)
- *       1  0  0 - MONO input to SCART 1 Output
- *       1  1  0 - SCART 1 DA to SCART 1 Output
- *       0  0  1 - SCART 2 DA to SCART 1 Output
- *       0  1  1 - SCART 1 Input to SCART 1 Output
- *       1  1  1 - Mute SCART 1 Output
- *
- * bits 13 12  7 - SCART 2 Output Select (for devices with 2 Output SCART):
- *       0  0  0 - SCART 1 DA to SCART 2 Output (reset position)
- *       0  1  0 - SCART 1 Input to SCART 2 Output
- *       1  0  0 - MONO input to SCART 2 Output
- *       0  0  1 - SCART 2 DA to SCART 2 Output
- *       0  1  1 - SCART 2 Input to SCART 2 Output
- *       1  1  0 - Mute SCART 2 Output
- *
- * Bits 4 to 0 should be zero.
- * ----------------------------------------------------------------------- */
-
-static int scarts[3][9] = {
-        /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
-        /* SCART DSP Input select */
-        { 0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
-        /* SCART1 Output select */
-        { 0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
-        /* SCART2 Output select */
-        { 0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
-};
-
-static char *scart_names[] = {
-        "mask", "in1", "in2", "in1 da", "in2 da", "in3", "in4", "mono", "mute"
-};
-
-static void msp3400c_set_scart(struct i2c_client *client, int in, int out)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-
-        msp->in_scart=in;
-
-        if (in >= 1 && in <= 8 && out >= 0 && out <= 2) {
-                if (-1 == scarts[out][in])
-                        return;
-
-                msp->acb &= ~scarts[out][SCART_MASK];
-                msp->acb |=  scarts[out][in];
-        } else
-                msp->acb = 0xf60; /* Mute Input and SCART 1 Output */
-
-        msp3400_dbg("scart switch: %s => %d (ACB=0x%04x)\n",
-                                                scart_names[in], out, msp->acb);
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x13, msp->acb);
-
-        /* Sets I2S speed 0 = 1.024 Mbps, 1 = 2.048 Mbps */
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
-}
-
-/* ------------------------------------------------------------------------ */
-
-static void msp3400c_setcarrier(struct i2c_client *client, int cdo1, int cdo2)
-{
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0093, cdo1 & 0xfff);
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x009b, cdo1 >> 12);
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x00a3, cdo2 & 0xfff);
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x00ab, cdo2 >> 12);
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0056, 0); /*LOAD_REG_1/2*/
-}
-
-static void msp3400c_setvolume(struct i2c_client *client,
-                               int muted, int left, int right)
- {
-        int vol = 0, val = 0, balance = 0;
-
-        if (!muted) {
-                /* 0x7f instead if 0x73 here has sound quality issues,
-                 * probably due to overmodulation + clipping ... */
-                vol = (left > right) ? left : right;
-                val = (vol * 0x73 / 65535) << 8;
-        }
-        if (vol > 0) {
-                balance = ((right - left) * 127) / vol;
-        }
-
-        msp3400_dbg("setvolume: mute=%s %d:%d  v=0x%02x b=0x%02x\n",
-                muted ? "on" : "off", left, right, val >> 8, balance);
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0000, val); /* loudspeaker */
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0006, val); /* headphones  */
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0007,
-                                        muted ? 0x1 : (val | 0x1));
-        msp3400c_write(client, I2C_MSP3400C_DFP, 0x0001, balance << 8);
-}
-
-static void msp3400c_setbass(struct i2c_client *client, int bass)
-{
-        int val = ((bass-32768) * 0x60 / 65535) << 8;
-
-        msp3400_dbg("setbass: %d 0x%02x\n", bass, val >> 8);
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0002, val); /* loudspeaker */
-}
-
-static void msp3400c_settreble(struct i2c_client *client, int treble)
-{
-        int val = ((treble-32768) * 0x60 / 65535) << 8;
-
-        msp3400_dbg("settreble: %d 0x%02x\n",treble, val>>8);
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0003, val); /* loudspeaker */
-}
-
-static void msp3400c_setmode(struct i2c_client *client, int type)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int i;
-
-        msp3400_dbg("setmode: %d\n",type);
-        msp->mode       = type;
-        msp->audmode    = V4L2_TUNER_MODE_MONO;
-        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
-
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x00bb,          /* ad_cv */
-                       msp_init_data[type].ad_cv);
-
-        for (i = 5; i >= 0; i--)                                   /* fir 1 */
-                msp3400c_write(client,I2C_MSP3400C_DEM, 0x0001,
-                               msp_init_data[type].fir1[i]);
-
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0005, 0x0004); /* fir 2 */
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0005, 0x0040);
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0005, 0x0000);
-        for (i = 5; i >= 0; i--)
-                msp3400c_write(client,I2C_MSP3400C_DEM, 0x0005,
-                               msp_init_data[type].fir2[i]);
-
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0083,     /* MODE_REG */
-                       msp_init_data[type].mode_reg);
-
-        msp3400c_setcarrier(client, msp_init_data[type].cdo1,
-                            msp_init_data[type].cdo2);
-
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x0056, 0); /*LOAD_REG_1/2*/
-
-        if (dolby) {
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,
-                               0x0520); /* I2S1 */
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0009,
-                               0x0620); /* I2S2 */
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000b,
-                               msp_init_data[type].dfp_src);
-        } else {
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,
-                               msp_init_data[type].dfp_src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0009,
-                               msp_init_data[type].dfp_src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000b,
-                               msp_init_data[type].dfp_src);
-        }
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x000a,
-                       msp_init_data[type].dfp_src);
-        msp3400c_write(client,I2C_MSP3400C_DFP, 0x000e,
-                       msp_init_data[type].dfp_matrix);
-
-        if (HAVE_NICAM(msp)) {
-                /* nicam prescale */
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0010, 0x5a00); /* was: 0x3000 */
-        }
-}
-
-/* given a bitmask of VIDEO_SOUND_XXX returns the "best" in the bitmask */
-static int best_video_sound(int rxsubchans)
-{
-        if (rxsubchans & V4L2_TUNER_SUB_STEREO)
-                return V4L2_TUNER_MODE_STEREO;
-        if (rxsubchans & V4L2_TUNER_SUB_LANG1)
-                return V4L2_TUNER_MODE_LANG1;
-        if (rxsubchans & V4L2_TUNER_SUB_LANG2)
-                return V4L2_TUNER_MODE_LANG2;
-        return V4L2_TUNER_MODE_MONO;
-}
-
-/* turn on/off nicam + stereo */
-static void msp3400c_setstereo(struct i2c_client *client, int mode)
-{
-        static char *strmode[] = { "0", "mono", "stereo", "3",
-                "lang1", "5", "6", "7", "lang2"
-        };
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int nicam = 0;          /* channel source: FM/AM or nicam */
-        int src = 0;
-
-        if (IS_MSP34XX_G(msp)) {
-                /* this method would break everything, let's make sure
-                 * it's never called
-                 */
-                msp3400_dbg
-                    ("DEBUG WARNING setstereo called with mode=%d instead of set_source (ignored)\n",
-                     mode);
-                return;
-        }
-
-        /* switch demodulator */
-        switch (msp->mode) {
-        case MSP_MODE_FM_TERRA:
-                msp3400_dbg("FM setstereo: %s\n", strmode[mode]);
-                msp3400c_setcarrier(client,msp->second,msp->main);
-                switch (mode) {
-                case V4L2_TUNER_MODE_STEREO:
-                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x000e, 0x3001);
-                        break;
-                case V4L2_TUNER_MODE_MONO:
-                case V4L2_TUNER_MODE_LANG1:
-                case V4L2_TUNER_MODE_LANG2:
-                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x000e, 0x3000);
-                        break;
-                }
-                break;
-        case MSP_MODE_FM_SAT:
-                msp3400_dbg("SAT setstereo: %s\n", strmode[mode]);
-                switch (mode) {
-                case V4L2_TUNER_MODE_MONO:
-                        msp3400c_setcarrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
-                        break;
-                case V4L2_TUNER_MODE_STEREO:
-                        msp3400c_setcarrier(client, MSP_CARRIER(7.2), MSP_CARRIER(7.02));
-                        break;
-                case V4L2_TUNER_MODE_LANG1:
-                        msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
-                        break;
-                case V4L2_TUNER_MODE_LANG2:
-                        msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
-                        break;
-                }
-                break;
-        case MSP_MODE_FM_NICAM1:
-        case MSP_MODE_FM_NICAM2:
-        case MSP_MODE_AM_NICAM:
-                msp3400_dbg("NICAM setstereo: %s\n",strmode[mode]);
-                msp3400c_setcarrier(client,msp->second,msp->main);
-                if (msp->nicam_on)
-                        nicam=0x0100;
-                break;
-        case MSP_MODE_BTSC:
-                msp3400_dbg("BTSC setstereo: %s\n",strmode[mode]);
-                nicam=0x0300;
-                break;
-        case MSP_MODE_EXTERN:
-                msp3400_dbg("extern setstereo: %s\n",strmode[mode]);
-                nicam = 0x0200;
-                break;
-        case MSP_MODE_FM_RADIO:
-                msp3400_dbg("FM-Radio setstereo: %s\n",strmode[mode]);
-                break;
-        default:
-                msp3400_dbg("mono setstereo\n");
-                return;
-        }
-
-        /* switch audio */
-        switch (best_video_sound(mode)) {
-        case V4L2_TUNER_MODE_STEREO:
-                src = 0x0020 | nicam;
-                break;
-        case V4L2_TUNER_MODE_MONO:
-                if (msp->mode == MSP_MODE_AM_NICAM) {
-                        msp3400_dbg("switching to AM mono\n");
-                        /* AM mono decoding is handled by tuner, not MSP chip */
-                        /* SCART switching control register */
-                        msp3400c_set_scart(client,SCART_MONO,0);
-                        src = 0x0200;
-                        break;
-                }
-        case V4L2_TUNER_MODE_LANG1:
-                src = 0x0000 | nicam;
-                break;
-        case V4L2_TUNER_MODE_LANG2:
-                src = 0x0010 | nicam;
-                break;
-        }
-        msp3400_dbg("setstereo final source/matrix = 0x%x\n", src);
-
-        if (dolby) {
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,0x0520);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0009,0x0620);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000a,src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000b,src);
-        } else {
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0009,src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000a,src);
-                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000b,src);
-        }
-}
-
-static void
-msp3400c_print_mode(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-
-        if (msp->main == msp->second) {
-                msp3400_dbg("mono sound carrier: %d.%03d MHz\n",
-                       msp->main/910000,(msp->main/910)%1000);
-        } else {
-                msp3400_dbg("main sound carrier: %d.%03d MHz\n",
-                       msp->main/910000,(msp->main/910)%1000);
-        }
-        if (msp->mode == MSP_MODE_FM_NICAM1 || msp->mode == MSP_MODE_FM_NICAM2)
-                msp3400_dbg("NICAM/FM carrier   : %d.%03d MHz\n",
-                       msp->second/910000,(msp->second/910)%1000);
-        if (msp->mode == MSP_MODE_AM_NICAM)
-                msp3400_dbg("NICAM/AM carrier   : %d.%03d MHz\n",
-                       msp->second/910000,(msp->second/910)%1000);
-        if (msp->mode == MSP_MODE_FM_TERRA &&
-            msp->main != msp->second) {
-                msp3400_dbg("FM-stereo carrier : %d.%03d MHz\n",
-                       msp->second/910000,(msp->second/910)%1000);
-        }
-}
-
-#define MSP3400_MAX 4
-static struct i2c_client *msps[MSP3400_MAX];
-static void msp3400c_restore_dfp(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int i;
-
-        for (i = 0; i < DFP_COUNT; i++) {
-                if (-1 == msp->dfp_regs[i])
-                        continue;
-                msp3400c_write(client, I2C_MSP3400C_DFP, i, msp->dfp_regs[i]);
-        }
-}
-
-/* if the dfp_regs is set, set what's in there. Otherwise, set the default value */
-static int msp3400c_write_dfp_with_default(struct i2c_client *client,
-                                        int addr, int default_value)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int value = default_value;
-        if (addr < DFP_COUNT && -1 != msp->dfp_regs[addr])
-                value = msp->dfp_regs[addr];
-        return msp3400c_write(client, I2C_MSP3400C_DFP, addr, value);
-}
-
-/* ----------------------------------------------------------------------- */
-
-struct REGISTER_DUMP {
-        int   addr;
-        char *name;
-};
-
-struct REGISTER_DUMP d1[] = {
-        {0x007e, "autodetect"},
-        {0x0023, "C_AD_BITS "},
-        {0x0038, "ADD_BITS  "},
-        {0x003e, "CIB_BITS  "},
-        {0x0057, "ERROR_RATE"},
-};
-
-static int autodetect_stereo(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int val;
-        int rxsubchans = msp->rxsubchans;
-        int newnicam   = msp->nicam_on;
-        int update = 0;
-
-        switch (msp->mode) {
-        case MSP_MODE_FM_TERRA:
-                val = msp3400c_read(client, I2C_MSP3400C_DFP, 0x18);
-                if (val > 32767)
-                        val -= 65536;
-                msp3400_dbg("stereo detect register: %d\n",val);
-                if (val > 4096) {
-                        rxsubchans = V4L2_TUNER_SUB_STEREO | V4L2_TUNER_SUB_MONO;
-                } else if (val < -4096) {
-                        rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
-                } else {
-                        rxsubchans = V4L2_TUNER_SUB_MONO;
-                }
-                newnicam = 0;
-                break;
-        case MSP_MODE_FM_NICAM1:
-        case MSP_MODE_FM_NICAM2:
-        case MSP_MODE_AM_NICAM:
-                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x23);
-                msp3400_dbg("nicam sync=%d, mode=%d\n",
-                        val & 1, (val & 0x1e) >> 1);
-
-                if (val & 1) {
-                        /* nicam synced */
-                        switch ((val & 0x1e) >> 1)  {
-                        case 0:
-                        case 8:
-                                rxsubchans = V4L2_TUNER_SUB_STEREO;
-                                break;
-                        case 1:
-                        case 9:
-                                rxsubchans = V4L2_TUNER_SUB_MONO
-                                        | V4L2_TUNER_SUB_LANG1;
-                                break;
-                        case 2:
-                        case 10:
-                                rxsubchans = V4L2_TUNER_SUB_MONO
-                                        | V4L2_TUNER_SUB_LANG1
-                                        | V4L2_TUNER_SUB_LANG2;
-                                break;
-                        default:
-                                rxsubchans = V4L2_TUNER_SUB_MONO;
-                                break;
-                        }
-                        newnicam=1;
-                } else {
-                        newnicam = 0;
-                        rxsubchans = V4L2_TUNER_SUB_MONO;
-                }
-                break;
-        case MSP_MODE_BTSC:
-                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x200);
-                msp3400_dbg("status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
-                        val,
-                        (val & 0x0002) ? "no"     : "yes",
-                        (val & 0x0004) ? "no"     : "yes",
-                        (val & 0x0040) ? "stereo" : "mono",
-                        (val & 0x0080) ? ", nicam 2nd mono" : "",
-                        (val & 0x0100) ? ", bilingual/SAP"  : "");
-                rxsubchans = V4L2_TUNER_SUB_MONO;
-                if (val & 0x0040) rxsubchans |= V4L2_TUNER_SUB_STEREO;
-                if (val & 0x0100) rxsubchans |= V4L2_TUNER_SUB_LANG1;
-                break;
-        }
-        if (rxsubchans != msp->rxsubchans) {
-                update = 1;
-                msp3400_dbg("watch: rxsubchans %d => %d\n",
-                        msp->rxsubchans,rxsubchans);
-                msp->rxsubchans = rxsubchans;
-        }
-        if (newnicam != msp->nicam_on) {
-                update = 1;
-                msp3400_dbg("watch: nicam %d => %d\n",
-                        msp->nicam_on,newnicam);
-                msp->nicam_on = newnicam;
-        }
-        return update;
-}
-
-/*
- * A kernel thread for msp3400 control -- we don't want to block the
- * in the ioctl while doing the sound carrier & stereo detect
- */
-
-static int msp34xx_sleep(struct msp3400c *msp, int timeout)
-{
-        DECLARE_WAITQUEUE(wait, current);
-
-        add_wait_queue(&msp->wq, &wait);
-        if (!kthread_should_stop()) {
-                if (timeout < 0) {
-                        set_current_state(TASK_INTERRUPTIBLE);
-                        schedule();
-                } else {
-                        schedule_timeout_interruptible
-                                                (msecs_to_jiffies(timeout));
-                }
-        }
-
-        remove_wait_queue(&msp->wq, &wait);
-        try_to_freeze();
-        return msp->restart;
-}
-
-/* stereo/multilang monitoring */
-static void watch_stereo(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-
-        if (autodetect_stereo(client)) {
-                if (msp->stereo & V4L2_TUNER_MODE_STEREO)
-                        msp3400c_setstereo(client, V4L2_TUNER_MODE_STEREO);
-                else if (msp->stereo & VIDEO_SOUND_LANG1)
-                        msp3400c_setstereo(client, V4L2_TUNER_MODE_LANG1);
-                else
-                        msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
-        }
-
-        if (once)
-                msp->watch_stereo = 0;
-}
-
-
-static int msp3400c_thread(void *data)
-{
-        struct i2c_client *client = data;
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        struct CARRIER_DETECT *cd;
-        int count, max1,max2,val1,val2, val,this;
-
-
-        msp3400_info("msp3400 daemon started\n");
-        for (;;) {
-                msp3400_dbg_mediumvol("msp3400 thread: sleep\n");
-                msp34xx_sleep(msp,-1);
-                msp3400_dbg_mediumvol("msp3400 thread: wakeup\n");
-
-        restart:
-                msp3400_dbg("thread: restart scan\n");
-                msp->restart = 0;
-                if (kthread_should_stop())
-                        break;
-
-                if (VIDEO_MODE_RADIO == msp->norm ||
-                    MSP_MODE_EXTERN  == msp->mode) {
-                        /* no carrier scan, just unmute */
-                        msp3400_info("thread: no carrier scan\n");
-                        msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                        continue;
-                }
-
-                /* mute */
-                msp3400c_setvolume(client, msp->muted, 0, 0);
-                msp3400c_setmode(client, MSP_MODE_AM_DETECT /* +1 */ );
-                val1 = val2 = 0;
-                max1 = max2 = -1;
-                msp->watch_stereo = 0;
-
-                /* some time for the tuner to sync */
-                if (msp34xx_sleep(msp,200))
-                        goto restart;
-
-                /* carrier detect pass #1 -- main carrier */
-                cd = carrier_detect_main;
-                count = CARRIER_COUNT(carrier_detect_main);
-
-                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
-                        /* autodetect doesn't work well with AM ... */
-                        max1 = 3;
-                        count = 0;
-                        msp3400_dbg("AM sound override\n");
-                }
-
-                for (this = 0; this < count; this++) {
-                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
-                        if (msp34xx_sleep(msp,100))
-                                goto restart;
-                        val = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1b);
-                        if (val > 32767)
-                                val -= 65536;
-                        if (val1 < val)
-                                val1 = val, max1 = this;
-                        msp3400_dbg("carrier1 val: %5d / %s\n", val,cd[this].name);
-                }
-
-                /* carrier detect pass #2 -- second (stereo) carrier */
-                switch (max1) {
-                case 1: /* 5.5 */
-                        cd = carrier_detect_55;
-                        count = CARRIER_COUNT(carrier_detect_55);
-                        break;
-                case 3: /* 6.5 */
-                        cd = carrier_detect_65;
-                        count = CARRIER_COUNT(carrier_detect_65);
-                        break;
-                case 0: /* 4.5 */
-                case 2: /* 6.0 */
-                default:
-                        cd = NULL;
-                        count = 0;
-                        break;
-                }
-
-                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
-                        /* autodetect doesn't work well with AM ... */
-                        cd = NULL;
-                        count = 0;
-                        max2 = 0;
-                }
-                for (this = 0; this < count; this++) {
-                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
-                        if (msp34xx_sleep(msp,100))
-                                goto restart;
-                        val = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1b);
-                        if (val > 32767)
-                                val -= 65536;
-                        if (val2 < val)
-                                val2 = val, max2 = this;
-                        msp3400_dbg("carrier2 val: %5d / %s\n", val,cd[this].name);
-                }
-
-                /* programm the msp3400 according to the results */
-                msp->main   = carrier_detect_main[max1].cdo;
-                switch (max1) {
-                case 1: /* 5.5 */
-                        if (max2 == 0) {
-                                /* B/G FM-stereo */
-                                msp->second = carrier_detect_55[max2].cdo;
-                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
-                                msp->nicam_on = 0;
-                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
-                                msp->watch_stereo = 1;
-                        } else if (max2 == 1 && HAVE_NICAM(msp)) {
-                                /* B/G NICAM */
-                                msp->second = carrier_detect_55[max2].cdo;
-                                msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
-                                msp->nicam_on = 1;
-                                msp3400c_setcarrier(client, msp->second, msp->main);
-                                msp->watch_stereo = 1;
-                        } else {
-                                goto no_second;
-                        }
-                        break;
-                case 2: /* 6.0 */
-                        /* PAL I NICAM */
-                        msp->second = MSP_CARRIER(6.552);
-                        msp3400c_setmode(client, MSP_MODE_FM_NICAM2);
-                        msp->nicam_on = 1;
-                        msp3400c_setcarrier(client, msp->second, msp->main);
-                        msp->watch_stereo = 1;
-                        break;
-                case 3: /* 6.5 */
-                        if (max2 == 1 || max2 == 2) {
-                                /* D/K FM-stereo */
-                                msp->second = carrier_detect_65[max2].cdo;
-                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
-                                msp->nicam_on = 0;
-                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
-                                msp->watch_stereo = 1;
-                        } else if (max2 == 0 &&
-                                   msp->norm == VIDEO_MODE_SECAM) {
-                                /* L NICAM or AM-mono */
-                                msp->second = carrier_detect_65[max2].cdo;
-                                msp3400c_setmode(client, MSP_MODE_AM_NICAM);
-                                msp->nicam_on = 0;
-                                msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
-                                msp3400c_setcarrier(client, msp->second, msp->main);
-                                /* volume prescale for SCART (AM mono input) */
-                                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000d, 0x1900);
-                                msp->watch_stereo = 1;
-                        } else if (max2 == 0 && HAVE_NICAM(msp)) {
-                                /* D/K NICAM */
-                                msp->second = carrier_detect_65[max2].cdo;
-                                msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
-                                msp->nicam_on = 1;
-                                msp3400c_setcarrier(client, msp->second, msp->main);
-                                msp->watch_stereo = 1;
-                        } else {
-                                goto no_second;
-                        }
-                        break;
-                case 0: /* 4.5 */
-                default:
-                no_second:
-                        msp->second = carrier_detect_main[max1].cdo;
-                        msp3400c_setmode(client, MSP_MODE_FM_TERRA);
-                        msp->nicam_on = 0;
-                        msp3400c_setcarrier(client, msp->second, msp->main);
-                        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
-                        msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
-                        break;
-                }
-
-                /* unmute */
-                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                msp3400c_restore_dfp(client);
-
-                if (debug)
-                        msp3400c_print_mode(client);
-
-                /* monitor tv audio mode */
-                while (msp->watch_stereo) {
-                        if (msp34xx_sleep(msp,5000))
-                                goto restart;
-                        watch_stereo(client);
-                }
-        }
-        msp3400_dbg("thread: exit\n");
-        return 0;
-}
-
-/* ----------------------------------------------------------------------- */
-/* this one uses the automatic sound standard detection of newer           */
-/* msp34xx chip versions                                                   */
-
-static struct MODES {
-        int retval;
-        int main, second;
-        char *name;
-} modelist[] = {
-        { 0x0000, 0, 0, "ERROR" },
-        { 0x0001, 0, 0, "autodetect start" },
-        { 0x0002, MSP_CARRIER(4.5), MSP_CARRIER(4.72), "4.5/4.72  M Dual FM-Stereo" },
-        { 0x0003, MSP_CARRIER(5.5), MSP_CARRIER(5.7421875), "5.5/5.74  B/G Dual FM-Stereo" },
-        { 0x0004, MSP_CARRIER(6.5), MSP_CARRIER(6.2578125), "6.5/6.25  D/K1 Dual FM-Stereo" },
-        { 0x0005, MSP_CARRIER(6.5), MSP_CARRIER(6.7421875), "6.5/6.74  D/K2 Dual FM-Stereo" },
-        { 0x0006, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  D/K FM-Mono (HDEV3)" },
-        { 0x0008, MSP_CARRIER(5.5), MSP_CARRIER(5.85), "5.5/5.85  B/G NICAM FM" },
-        { 0x0009, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  L NICAM AM" },
-        { 0x000a, MSP_CARRIER(6.0), MSP_CARRIER(6.55), "6.0/6.55  I NICAM FM" },
-        { 0x000b, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM" },
-        { 0x000c, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV2)" },
-        { 0x0020, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Stereo" },
-        { 0x0021, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Mono + SAP" },
-        { 0x0030, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M EIA-J Japan Stereo" },
-        { 0x0040, MSP_CARRIER(10.7), MSP_CARRIER(10.7), "10.7  FM-Stereo Radio" },
-        { 0x0050, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  SAT-Mono" },
-        { 0x0051, MSP_CARRIER(7.02), MSP_CARRIER(7.20), "7.02/7.20  SAT-Stereo" },
-        { 0x0060, MSP_CARRIER(7.2), MSP_CARRIER(7.2), "7.2  SAT ADR" },
-        {     -1, 0, 0, NULL }, /* EOF */
-};
-
-static inline const char *msp34xx_standard_mode_name(int mode)
-{
-        int i;
-        for (i = 0; modelist[i].name != NULL; i++)
-                if (modelist[i].retval == mode)
-                        return modelist[i].name;
-        return "unknown";
-}
-
-static int msp34xx_modus(struct i2c_client *client, int norm)
-{
-        switch (norm) {
-        case VIDEO_MODE_PAL:
-                msp3400_dbg("video mode selected to PAL\n");
-
-#if 1
-                /* experimental: not sure this works with all chip versions */
-                return 0x7003;
-#else
-                /* previous value, try this if it breaks ... */
-                return 0x1003;
-#endif
-        case VIDEO_MODE_NTSC:  /* BTSC */
-                msp3400_dbg("video mode selected to NTSC\n");
-                return 0x2003;
-        case VIDEO_MODE_SECAM:
-                msp3400_dbg("video mode selected to SECAM\n");
-                return 0x0003;
-        case VIDEO_MODE_RADIO:
-                msp3400_dbg("video mode selected to Radio\n");
-                return 0x0003;
-        case VIDEO_MODE_AUTO:
-                msp3400_dbg("video mode selected to Auto\n");
-                return 0x2003;
-        default:
-                return 0x0003;
-        }
-}
-
-static int msp34xx_standard(int norm)
-{
-        switch (norm) {
-        case VIDEO_MODE_PAL:
-                return 1;
-        case VIDEO_MODE_NTSC:  /* BTSC */
-                return 0x0020;
-        case VIDEO_MODE_SECAM:
-                return 1;
-        case VIDEO_MODE_RADIO:
-                return 0x0040;
-        default:
-                return 1;
-        }
-}
-
-static int msp3410d_thread(void *data)
-{
-        struct i2c_client *client = data;
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int mode,val,i,std;
-
-        msp3400_info("msp3410 daemon started\n");
-
-        for (;;) {
-                msp3400_dbg_mediumvol("msp3410 thread: sleep\n");
-                msp34xx_sleep(msp,-1);
-                msp3400_dbg_mediumvol("msp3410 thread: wakeup\n");
-
-        restart:
-                msp3400_dbg("thread: restart scan\n");
-                msp->restart = 0;
-                if (kthread_should_stop())
-                        break;
-
-                if (msp->mode == MSP_MODE_EXTERN) {
-                        /* no carrier scan needed, just unmute */
-                        msp3400_dbg("thread: no carrier scan\n");
-                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                        continue;
-                }
-
-                /* put into sane state (and mute) */
-                msp3400c_reset(client);
-
-                /* some time for the tuner to sync */
-                if (msp34xx_sleep(msp,200))
-                        goto restart;
-
-                /* start autodetect */
-                mode = msp34xx_modus(client, msp->norm);
-                std  = msp34xx_standard(msp->norm);
-                msp3400c_write(client, I2C_MSP3400C_DEM, 0x30, mode);
-                msp3400c_write(client, I2C_MSP3400C_DEM, 0x20, std);
-                msp->watch_stereo = 0;
-
-                if (debug)
-                        msp3400_dbg("setting mode: %s (0x%04x)\n",
-                               msp34xx_standard_mode_name(std) ,std);
-
-                if (std != 1) {
-                        /* programmed some specific mode */
-                        val = std;
-                } else {
-                        /* triggered autodetect */
-                        for (;;) {
-                                if (msp34xx_sleep(msp,100))
-                                        goto restart;
-
-                                /* check results */
-                                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x7e);
-                                if (val < 0x07ff)
-                                        break;
-                                msp3400_dbg("detection still in progress\n");
-                        }
-                }
-                for (i = 0; modelist[i].name != NULL; i++)
-                        if (modelist[i].retval == val)
-                                break;
-                msp3400_dbg("current mode: %s (0x%04x)\n",
-                        modelist[i].name ? modelist[i].name : "unknown",
-                        val);
-                msp->main   = modelist[i].main;
-                msp->second = modelist[i].second;
-
-                if (amsound && (msp->norm == VIDEO_MODE_SECAM) && (val != 0x0009)) {
-                        /* autodetection has failed, let backup */
-                        msp3400_dbg("autodetection failed,"
-                                " switching to backup mode: %s (0x%04x)\n",
-                                modelist[8].name ? modelist[8].name : "unknown",val);
-                        val = 0x0009;
-                        msp3400c_write(client, I2C_MSP3400C_DEM, 0x20, val);
-                }
-
-                /* set various prescales */
-                msp3400c_write(client, I2C_MSP3400C_DFP, 0x0d, 0x1900); /* scart */
-                msp3400c_write(client, I2C_MSP3400C_DFP, 0x0e, 0x2403); /* FM */
-                msp3400c_write(client, I2C_MSP3400C_DFP, 0x10, 0x5a00); /* nicam */
-
-                /* set stereo */
-                switch (val) {
-                case 0x0008: /* B/G NICAM */
-                case 0x000a: /* I NICAM */
-                        if (val == 0x0008)
-                                msp->mode = MSP_MODE_FM_NICAM1;
-                        else
-                                msp->mode = MSP_MODE_FM_NICAM2;
-                        /* just turn on stereo */
-                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
-                        msp->nicam_on = 1;
-                        msp->watch_stereo = 1;
-                        msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
-                        break;
-                case 0x0009:
-                        msp->mode = MSP_MODE_AM_NICAM;
-                        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
-                        msp->nicam_on = 1;
-                        msp3400c_setstereo(client,V4L2_TUNER_MODE_MONO);
-                        msp->watch_stereo = 1;
-                        break;
-                case 0x0020: /* BTSC */
-                        /* just turn on stereo */
-                        msp->mode = MSP_MODE_BTSC;
-                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
-                        msp->nicam_on = 0;
-                        msp->watch_stereo = 1;
-                        msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
-                        break;
-                case 0x0040: /* FM radio */
-                        msp->mode   = MSP_MODE_FM_RADIO;
-                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
-                        msp->audmode = V4L2_TUNER_MODE_STEREO;
-                        msp->nicam_on = 0;
-                        msp->watch_stereo = 0;
-                        /* not needed in theory if HAVE_RADIO(), but
-                           short programming enables carrier mute */
-                        msp3400c_setmode(client,MSP_MODE_FM_RADIO);
-                        msp3400c_setcarrier(client, MSP_CARRIER(10.7),
-                                            MSP_CARRIER(10.7));
-                        /* scart routing */
-                        msp3400c_set_scart(client,SCART_IN2,0);
-                        /* msp34xx does radio decoding */
-                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x08, 0x0020);
-                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x09, 0x0020);
-                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0b, 0x0020);
-                        break;
-                case 0x0003:
-                case 0x0004:
-                case 0x0005:
-                        msp->mode   = MSP_MODE_FM_TERRA;
-                        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
-                        msp->audmode = V4L2_TUNER_MODE_MONO;
-                        msp->nicam_on = 0;
-                        msp->watch_stereo = 1;
-                        break;
-                }
-
-                /* unmute, restore misc registers */
-                msp3400c_setbass(client, msp->bass);
-                msp3400c_settreble(client, msp->treble);
-                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                msp3400c_write(client, I2C_MSP3400C_DFP, 0x13, msp->acb);
-                msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
-                msp3400c_restore_dfp(client);
-
-                /* monitor tv audio mode */
-                while (msp->watch_stereo) {
-                        if (msp34xx_sleep(msp,5000))
-                                goto restart;
-                        watch_stereo(client);
-                }
-        }
-        msp3400_dbg("thread: exit\n");
-        return 0;
-}
-
-/* ----------------------------------------------------------------------- */
-/* msp34xxG + (simpler no-thread)                                          */
-/* this one uses both automatic standard detection and automatic sound     */
-/* select which are available in the newer G versions                      */
-/* struct msp: only norm, acb and source are really used in this mode      */
-
-static void msp34xxg_set_source(struct i2c_client *client, int source);
-
-/* (re-)initialize the msp34xxg, according to the current norm in msp->norm
- * return 0 if it worked, -1 if it failed
- */
-static int msp34xxg_reset(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int modus,std;
-
-        if (msp3400c_reset(client))
-                return -1;
-
-        /* make sure that input/output is muted (paranoid mode) */
-        if (msp3400c_write(client,
-                           I2C_MSP3400C_DFP,
-                           0x13, /* ACB */
-                           0x0f20 /* mute DSP input, mute SCART 1 */))
-                return -1;
-
-        msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
-
-        /* step-by-step initialisation, as described in the manual */
-        modus = msp34xx_modus(client, msp->norm);
-        std   = msp34xx_standard(msp->norm);
-        modus &= ~0x03; /* STATUS_CHANGE=0 */
-        modus |= 0x01;  /* AUTOMATIC_SOUND_DETECTION=1 */
-        if (msp3400c_write(client,
-                           I2C_MSP3400C_DEM,
-                           0x30/*MODUS*/,
-                           modus))
-                return -1;
-        if (msp3400c_write(client,
-                           I2C_MSP3400C_DEM,
-                           0x20/*standard*/,
-                           std))
-                return -1;
-
-        /* write the dfps that may have an influence on
-           standard/audio autodetection right now */
-        msp34xxg_set_source(client, msp->source);
-
-        if (msp3400c_write_dfp_with_default(client, 0x0e,       /* AM/FM Prescale */
-                                            0x3000
-                                            /* default: [15:8] 75khz deviation */
-            ))
-                return -1;
-
-        if (msp3400c_write_dfp_with_default(client, 0x10,       /* NICAM Prescale */
-                                            0x5a00
-                                            /* default: 9db gain (as recommended) */
-            ))
-                return -1;
-
-        return 0;
-}
-
-static int msp34xxg_thread(void *data)
-{
-        struct i2c_client *client = data;
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int val, std, i;
-
-        msp3400_info("msp34xxg daemon started\n");
-
-        msp->source = 1; /* default */
-        for (;;) {
-                msp3400_dbg_mediumvol("msp34xxg thread: sleep\n");
-                msp34xx_sleep(msp,-1);
-                msp3400_dbg_mediumvol("msp34xxg thread: wakeup\n");
-
-        restart:
-                msp3400_dbg("thread: restart scan\n");
-                msp->restart = 0;
-                if (kthread_should_stop())
-                        break;
-
-                /* setup the chip*/
-                msp34xxg_reset(client);
-                std = standard;
-                if (std != 0x01)
-                        goto unmute;
-
-                /* watch autodetect */
-                msp3400_dbg("triggered autodetect, waiting for result\n");
-                for (i = 0; i < 10; i++) {
-                        if (msp34xx_sleep(msp,100))
-                                goto restart;
-
-                        /* check results */
-                        val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x7e);
-                        if (val < 0x07ff) {
-                                std = val;
-                                break;
-                        }
-                        msp3400_dbg("detection still in progress\n");
-                }
-                if (0x01 == std) {
-                        msp3400_dbg("detection still in progress after 10 tries. giving up.\n");
-                        continue;
-                }
-
-        unmute:
-                msp3400_dbg("current mode: %s (0x%04x)\n",
-                        msp34xx_standard_mode_name(std), std);
-
-                /* unmute: dispatch sound to scart output, set scart volume */
-                msp3400_dbg("unmute\n");
-
-                msp3400c_setbass(client, msp->bass);
-                msp3400c_settreble(client, msp->treble);
-                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-
-                /* restore ACB */
-                if (msp3400c_write(client,
-                                   I2C_MSP3400C_DFP,
-                                   0x13, /* ACB */
-                                   msp->acb))
-                        return -1;
-
-                msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
-        }
-        msp3400_dbg("thread: exit\n");
-        return 0;
-}
-
-/* set the same 'source' for the loudspeaker, scart and quasi-peak detector
- * the value for source is the same as bit 15:8 of DFP registers 0x08,
- * 0x0a and 0x0c: 0=mono, 1=stereo or A|B, 2=SCART, 3=stereo or A, 4=stereo or B
- *
- * this function replaces msp3400c_setstereo
- */
-static void msp34xxg_set_source(struct i2c_client *client, int source)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-
-        /* fix matrix mode to stereo and let the msp choose what
-         * to output according to 'source', as recommended
-         * for MONO (source==0) downmixing set bit[7:0] to 0x30
-         */
-        int value = (source&0x07)<<8|(source==0 ? 0x30:0x20);
-        msp3400_dbg("set source to %d (0x%x)\n", source, value);
-        msp3400c_write(client,
-                       I2C_MSP3400C_DFP,
-                       0x08, /* Loudspeaker Output */
-                       value);
-        msp3400c_write(client,
-                       I2C_MSP3400C_DFP,
-                       0x0a, /* SCART1 DA Output */
-                       value);
-        msp3400c_write(client,
-                       I2C_MSP3400C_DFP,
-                       0x0c, /* Quasi-peak detector */
-                       value);
-        /*
-         * set identification threshold. Personally, I
-         * I set it to a higher value that the default
-         * of 0x190 to ignore noisy stereo signals.
-         * this needs tuning. (recommended range 0x00a0-0x03c0)
-         * 0x7f0 = forced mono mode
-         */
-        msp3400c_write(client,
-                       I2C_MSP3400C_DEM,
-                       0x22, /* a2 threshold for stereo/bilingual */
-                       stereo_threshold);
-        msp->source=source;
-}
-
-static void msp34xxg_detect_stereo(struct i2c_client *client)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-
-        int status = msp3400c_read(client,
-                                   I2C_MSP3400C_DEM,
-                                   0x0200 /* STATUS */);
-        int is_bilingual = status&0x100;
-        int is_stereo = status&0x40;
-
-        msp->rxsubchans = 0;
-        if (is_stereo)
-                msp->rxsubchans |= V4L2_TUNER_SUB_STEREO;
-        else
-                msp->rxsubchans |= V4L2_TUNER_SUB_MONO;
-        if (is_bilingual) {
-                msp->rxsubchans |= V4L2_TUNER_SUB_LANG1|V4L2_TUNER_SUB_LANG2;
-                /* I'm supposed to check whether it's SAP or not
-                 * and set only LANG2/SAP in this case. Yet, the MSP
-                 * does a lot of work to hide this and handle everything
-                 * the same way. I don't want to work around it so unless
-                 * this is a problem, I'll handle SAP just like lang1/lang2.
-                 */
-        }
-        msp3400_dbg("status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
-                status, is_stereo, is_bilingual, msp->rxsubchans);
-}
-
-static void msp34xxg_set_audmode(struct i2c_client *client, int audmode)
-{
-        struct msp3400c *msp = i2c_get_clientdata(client);
-        int source;
-
-        switch (audmode) {
-        case V4L2_TUNER_MODE_MONO:
-                source=0; /* mono only */
-                break;
-        case V4L2_TUNER_MODE_STEREO:
-                source=1; /* stereo or A|B, see comment in msp34xxg_get_v4l2_stereo() */
-                /* problem: that could also mean 2 (scart input) */
-                break;
-        case V4L2_TUNER_MODE_LANG1:
-                source=3; /* stereo or A */
-                break;
-        case V4L2_TUNER_MODE_LANG2:
-                source=4; /* stereo or B */
-                break;
-        default:
-                audmode = 0;
-                source  = 1;
-                break;
-        }
-        msp->audmode = audmode;
-        msp34xxg_set_source(client, source);
-}
-
-
-/* ----------------------------------------------------------------------- */
-
-static int msp_attach(struct i2c_adapter *adap, int addr, int kind);
-static int msp_detach(struct i2c_client *client);
-static int msp_probe(struct i2c_adapter *adap);
-static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg);
-
-static int msp_suspend(struct device * dev, pm_message_t state);
-static int msp_resume(struct device * dev);
-
-static void msp_wake_thread(struct i2c_client *client);
-
-static struct i2c_driver driver = {
-        .id             = I2C_DRIVERID_MSP3400,
-        .attach_adapter = msp_probe,
-        .detach_client  = msp_detach,
-        .command        = msp_command,
-        .driver = {
-                .name    = "i2c msp3400 driver",
-                .suspend = msp_suspend,
-                .resume  = msp_resume,
-        },
-};
-
-static struct i2c_client client_template =
-{
-        .name      = "(unset)",
-        .driver    = &driver,
-};
-
-static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
-{
-        struct msp3400c *msp;
-        struct i2c_client *client = &client_template;
-        int (*thread_func)(void *data) = NULL;
-        int i;
-
-        client_template.adapter = adap;
-        client_template.addr = addr;
-
-        if (-1 == msp3400c_reset(&client_template)) {
-                msp3400_dbg("no chip found\n");
-                return -1;
-        }
-
-        if (NULL == (client = kmalloc(sizeof(struct i2c_client),GFP_KERNEL)))
-                return -ENOMEM;
-        memcpy(client,&client_template,sizeof(struct i2c_client));
-        if (NULL == (msp = kmalloc(sizeof(struct msp3400c),GFP_KERNEL))) {
-                kfree(client);
-                return -ENOMEM;
-        }
-
-        memset(msp,0,sizeof(struct msp3400c));
-        msp->norm = VIDEO_MODE_NTSC;
-        msp->left = 58880;      /* 0db gain */
-        msp->right = 58880;     /* 0db gain */
-        msp->bass = 32768;
-        msp->treble = 32768;
-        msp->input = -1;
-        msp->muted = 0;
-        msp->i2s_mode = 0;
-        for (i = 0; i < DFP_COUNT; i++)
-                msp->dfp_regs[i] = -1;
-
-        i2c_set_clientdata(client, msp);
-        init_waitqueue_head(&msp->wq);
-
-        if (-1 == msp3400c_reset(client)) {
-                kfree(msp);
-                kfree(client);
-                msp3400_dbg("no chip found\n");
-                return -1;
-        }
-
-        msp->rev1 = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1e);
-        if (-1 != msp->rev1)
-                msp->rev2 = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1f);
-        if ((-1 == msp->rev1) || (0 == msp->rev1 && 0 == msp->rev2)) {
-                kfree(msp);
-                kfree(client);
-                msp3400_dbg("error while reading chip version\n");
-                return -1;
-        }
-        msp3400_dbg("rev1=0x%04x, rev2=0x%04x\n", msp->rev1, msp->rev2);
-
-        msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-
-        snprintf(client->name, sizeof(client->name), "MSP%c4%02d%c-%c%d",
-                 ((msp->rev1>>4)&0x0f) + '3',
-                 (msp->rev2>>8)&0xff, (msp->rev1&0x0f)+'@',
-                 ((msp->rev1>>8)&0xff)+'@', msp->rev2&0x1f);
-
-        msp->opmode = opmode;
-        if (OPMODE_AUTO == msp->opmode) {
-                if (HAVE_SIMPLER(msp))
-                        msp->opmode = OPMODE_SIMPLER;
-                else if (HAVE_SIMPLE(msp))
-                        msp->opmode = OPMODE_SIMPLE;
-                else
-                        msp->opmode = OPMODE_MANUAL;
-        }
-
-        /* hello world :-) */
-        msp3400_info("chip=%s", client->name);
-        if (HAVE_NICAM(msp))
-                printk(" +nicam");
-        if (HAVE_SIMPLE(msp))
-                printk(" +simple");
-        if (HAVE_SIMPLER(msp))
-                printk(" +simpler");
-        if (HAVE_RADIO(msp))
-                printk(" +radio");
-
-        /* version-specific initialization */
-        switch (msp->opmode) {
-        case OPMODE_MANUAL:
-                printk(" mode=manual");
-                thread_func = msp3400c_thread;
-                break;
-        case OPMODE_SIMPLE:
-                printk(" mode=simple");
-                thread_func = msp3410d_thread;
-                break;
-        case OPMODE_SIMPLER:
-                printk(" mode=simpler");
-                thread_func = msp34xxg_thread;
-                break;
-        }
-        printk("\n");
-
-        /* startup control thread if needed */
-        if (thread_func) {
-                msp->kthread = kthread_run(thread_func, client, "msp34xx");
-
-                if (NULL == msp->kthread)
-                        msp3400_warn("kernel_thread() failed\n");
-                msp_wake_thread(client);
-        }
-
-        /* done */
-        i2c_attach_client(client);
-
-        /* update our own array */
-        for (i = 0; i < MSP3400_MAX; i++) {
-                if (NULL == msps[i]) {
-                        msps[i] = client;
-                        break;
-                }
-        }
-
-        return 0;
-}
-
-static int msp_detach(struct i2c_client *client)
-{
-        struct msp3400c *msp  = i2c_get_clientdata(client);
-        int i;
-
-        /* shutdown control thread */
-        if (msp->kthread) {
-                msp->restart = 1;
-                kthread_stop(msp->kthread);
-        }
-        msp3400c_reset(client);
-
-        /* update our own array */
-        for (i = 0; i < MSP3400_MAX; i++) {
-                if (client == msps[i]) {
-                        msps[i] = NULL;
-                        break;
-                }
-        }
-
-        i2c_detach_client(client);
-
-        kfree(msp);
-        kfree(client);
-        return 0;
-}
-
-static int msp_probe(struct i2c_adapter *adap)
-{
-        if (adap->class & I2C_CLASS_TV_ANALOG)
-                return i2c_probe(adap, &addr_data, msp_attach);
-        return 0;
-}
-
-static void msp_wake_thread(struct i2c_client *client)
-{
-        struct msp3400c *msp  = i2c_get_clientdata(client);
-
-        if (NULL == msp->kthread)
-                return;
-        msp3400c_setvolume(client,msp->muted,0,0);
-        msp->watch_stereo = 0;
-        msp->restart = 1;
-        wake_up_interruptible(&msp->wq);
-}
-
-/* ----------------------------------------------------------------------- */
-
-static int mode_v4l2_to_v4l1(int rxsubchans)
-{
-        int mode = 0;
-
-        if (rxsubchans & V4L2_TUNER_SUB_STEREO)
-                mode |= VIDEO_SOUND_STEREO;
-        if (rxsubchans & V4L2_TUNER_SUB_LANG2)
-                mode |= VIDEO_SOUND_LANG2;
-        if (rxsubchans & V4L2_TUNER_SUB_LANG1)
-                mode |= VIDEO_SOUND_LANG1;
-        if (0 == mode)
-                mode |= VIDEO_SOUND_MONO;
-        return mode;
-}
-
-static int mode_v4l1_to_v4l2(int mode)
-{
-        if (mode & VIDEO_SOUND_STEREO)
-                return V4L2_TUNER_MODE_STEREO;
-        if (mode & VIDEO_SOUND_LANG2)
-                return V4L2_TUNER_MODE_LANG2;
-        if (mode & VIDEO_SOUND_LANG1)
-                return V4L2_TUNER_MODE_LANG1;
-        return V4L2_TUNER_MODE_MONO;
-}
-
-static void msp_any_detect_stereo(struct i2c_client *client)
-{
-        struct msp3400c *msp  = i2c_get_clientdata(client);
-
-        switch (msp->opmode) {
-        case OPMODE_MANUAL:
-        case OPMODE_SIMPLE:
-                autodetect_stereo(client);
-                break;
-        case OPMODE_SIMPLER:
-                msp34xxg_detect_stereo(client);
-                break;
-        }
-}
-
-static void msp_any_set_audmode(struct i2c_client *client, int audmode)
-{
-        struct msp3400c *msp  = i2c_get_clientdata(client);
-
-        switch (msp->opmode) {
-        case OPMODE_MANUAL:
-        case OPMODE_SIMPLE:
-                msp->watch_stereo = 0;
-                msp3400c_setstereo(client, audmode);
-                break;
-        case OPMODE_SIMPLER:
-                msp34xxg_set_audmode(client, audmode);
-                break;
-        }
-}
-
-
-static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
-{
-        struct msp3400c *msp  = i2c_get_clientdata(client);
-        __u16           *sarg = arg;
-        int scart = 0;
-
-        switch (cmd) {
-
-        case AUDC_SET_INPUT:
-                msp3400_dbg("AUDC_SET_INPUT(%d)\n",*sarg);
-
-                if (*sarg == msp->input)
-                        break;
-                msp->input = *sarg;
-                switch (*sarg) {
-                case AUDIO_RADIO:
-                        /* Hauppauge uses IN2 for the radio */
-                        msp->mode   = MSP_MODE_FM_RADIO;
-                        scart       = SCART_IN2;
-                        break;
-                case AUDIO_EXTERN_1:
-                        /* IN1 is often used for external input ... */
-                        msp->mode   = MSP_MODE_EXTERN;
-                        scart       = SCART_IN1;
-                        break;
-                case AUDIO_EXTERN_2:
-                        /* ... sometimes it is IN2 through ;) */
-                        msp->mode   = MSP_MODE_EXTERN;
-                        scart       = SCART_IN2;
-                        break;
-                case AUDIO_TUNER:
-                        msp->mode   = -1;
-                        break;
-                default:
-                        if (*sarg & AUDIO_MUTE)
-                                msp3400c_set_scart(client,SCART_MUTE,0);
-                        break;
-                }
-                if (scart) {
-                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
-                        msp->audmode = V4L2_TUNER_MODE_STEREO;
-                        msp3400c_set_scart(client,scart,0);
-                        msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
-                        if (msp->opmode != OPMODE_SIMPLER)
-                                msp3400c_setstereo(client, msp->audmode);
-                }
-                msp_wake_thread(client);
-                break;
-
-        case AUDC_SET_RADIO:
-                msp3400_dbg("AUDC_SET_RADIO\n");
-                msp->norm = VIDEO_MODE_RADIO;
-                msp3400_dbg("switching to radio mode\n");
-                msp->watch_stereo = 0;
-                switch (msp->opmode) {
-                case OPMODE_MANUAL:
-                        /* set msp3400 to FM radio mode */
-                        msp3400c_setmode(client,MSP_MODE_FM_RADIO);
-                        msp3400c_setcarrier(client, MSP_CARRIER(10.7),
-                                            MSP_CARRIER(10.7));
-                        msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                        break;
-                case OPMODE_SIMPLE:
-                case OPMODE_SIMPLER:
-                        /* the thread will do for us */
-                        msp_wake_thread(client);
-                        break;
-                }
-                break;
-                /* work-in-progress:  hook to control the DFP registers */
-        case MSP_SET_DFPREG:
-        {
-                struct msp_dfpreg *r = arg;
-                int i;
-
-                if (r->reg < 0 || r->reg >= DFP_COUNT)
-                        return -EINVAL;
-                for (i = 0; i < sizeof(bl_dfp) / sizeof(int); i++)
-                        if (r->reg == bl_dfp[i])
-                                return -EINVAL;
-                msp->dfp_regs[r->reg] = r->value;
-                msp3400c_write(client, I2C_MSP3400C_DFP, r->reg, r->value);
-                return 0;
-        }
-        case MSP_GET_DFPREG:
-        {
-                struct msp_dfpreg *r = arg;
-
-                if (r->reg < 0 || r->reg >= DFP_COUNT)
-                        return -EINVAL;
-                r->value = msp3400c_read(client, I2C_MSP3400C_DFP, r->reg);
-                return 0;
-        }
-
-        /* --- v4l ioctls --- */
-        /* take care: bttv does userspace copying, we'll get a
-           kernel pointer here... */
-        case VIDIOCGAUDIO:
-        {
-                struct video_audio *va = arg;
-
-                msp3400_dbg("VIDIOCGAUDIO\n");
-                va->flags |= VIDEO_AUDIO_VOLUME |
-                        VIDEO_AUDIO_BASS |
-                        VIDEO_AUDIO_TREBLE |
-                        VIDEO_AUDIO_MUTABLE;
-                if (msp->muted)
-                        va->flags |= VIDEO_AUDIO_MUTE;
-
-                if (msp->muted)
-                        va->flags |= VIDEO_AUDIO_MUTE;
-                va->volume = MAX(msp->left, msp->right);
-                va->balance = (32768 * MIN(msp->left, msp->right)) /
-                    (va->volume ? va->volume : 1);
-                va->balance = (msp->left < msp->right) ?
-                    (65535 - va->balance) : va->balance;
-                if (0 == va->volume)
-                        va->balance = 32768;
-                va->bass = msp->bass;
-                va->treble = msp->treble;
-
-                msp_any_detect_stereo(client);
-                va->mode = mode_v4l2_to_v4l1(msp->rxsubchans);
-                break;
-        }
-        case VIDIOCSAUDIO:
-        {
-                struct video_audio *va = arg;
-
-                msp3400_dbg("VIDIOCSAUDIO\n");
-                msp->muted = (va->flags & VIDEO_AUDIO_MUTE);
-                msp->left = (MIN(65536 - va->balance, 32768) *
-                             va->volume) / 32768;
-                msp->right = (MIN(va->balance, 32768) * va->volume) / 32768;
-                msp->bass = va->bass;
-                msp->treble = va->treble;
-                msp3400_dbg("VIDIOCSAUDIO setting va->volume to %d\n",
-                        va->volume);
-                msp3400_dbg("VIDIOCSAUDIO setting va->balance to %d\n",
-                        va->balance);
-                msp3400_dbg("VIDIOCSAUDIO setting va->flags to %d\n",
-                        va->flags);
-                msp3400_dbg("VIDIOCSAUDIO setting msp->left to %d\n",
-                        msp->left);
-                msp3400_dbg("VIDIOCSAUDIO setting msp->right to %d\n",
-                        msp->right);
-                msp3400_dbg("VIDIOCSAUDIO setting msp->bass to %d\n",
-                        msp->bass);
-                msp3400_dbg("VIDIOCSAUDIO setting msp->treble to %d\n",
-                        msp->treble);
-                msp3400_dbg("VIDIOCSAUDIO setting msp->mode to %d\n",
-                        msp->mode);
-                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-                msp3400c_setbass(client, msp->bass);
-                msp3400c_settreble(client, msp->treble);
-
-                if (va->mode != 0 && msp->norm != VIDEO_MODE_RADIO)
-                        msp_any_set_audmode(client,mode_v4l1_to_v4l2(va->mode));
-                break;
-        }
-
-        case VIDIOCSCHAN:
-        {
-                struct video_channel *vc = arg;
-
-                msp3400_dbg("VIDIOCSCHAN (norm=%d)\n",vc->norm);
-                msp->norm = vc->norm;
-                msp_wake_thread(client);
-                break;
-        }
-
-        case VIDIOCSFREQ:
-        case VIDIOC_S_FREQUENCY:
-        {
-                /* new channel -- kick audio carrier scan */
-                msp3400_dbg("VIDIOCSFREQ\n");
-                msp_wake_thread(client);
-                break;
-        }
-
-        /* msp34xx specific */
-        case MSP_SET_MATRIX:
-        {
-                struct msp_matrix *mspm = arg;
-
-                msp3400_dbg("MSP_SET_MATRIX\n");
-                msp3400c_set_scart(client, mspm->input, mspm->output);
-                break;
-        }
-
-        /* --- v4l2 ioctls --- */
-        case VIDIOC_S_STD:
-        {
-                v4l2_std_id *id = arg;
-
-                /*FIXME: use V4L2 mode flags on msp3400 instead of V4L1*/
-                if (*id & V4L2_STD_PAL) {
-                        msp->norm=VIDEO_MODE_PAL;
-                } else if (*id & V4L2_STD_SECAM) {
-                        msp->norm=VIDEO_MODE_SECAM;
-                } else {
-                        msp->norm=VIDEO_MODE_NTSC;
-                }
-
-                msp_wake_thread(client);
-                return 0;
-        }
-
-        case VIDIOC_ENUMINPUT:
-        {
-                struct v4l2_input *i = arg;
-
-                if (i->index != 0)
-                        return -EINVAL;
-
-                i->type = V4L2_INPUT_TYPE_TUNER;
-                switch (i->index) {
-                case AUDIO_RADIO:
-                        strcpy(i->name,"Radio");
-                        break;
-                case AUDIO_EXTERN_1:
-                        strcpy(i->name,"Extern 1");
-                        break;
-                case AUDIO_EXTERN_2:
-                        strcpy(i->name,"Extern 2");
-                        break;
-                case AUDIO_TUNER:
-                        strcpy(i->name,"Television");
-                        break;
-                default:
-                        return -EINVAL;
-                }
-                return 0;
-        }
-
-        case VIDIOC_G_AUDIO:
-        {
-                struct v4l2_audio *a = arg;
-
-                memset(a,0,sizeof(*a));
-
-                switch (a->index) {
-                case AUDIO_RADIO:
-                        strcpy(a->name,"Radio");
-                        break;
-                case AUDIO_EXTERN_1:
-                        strcpy(a->name,"Extern 1");
-                        break;
-                case AUDIO_EXTERN_2:
-                        strcpy(a->name,"Extern 2");
-                        break;
-                case AUDIO_TUNER:
-                        strcpy(a->name,"Television");
-                        break;
-                default:
-                        return -EINVAL;
-                }
-
-                msp_any_detect_stereo(client);
-                if (msp->audmode == V4L2_TUNER_MODE_STEREO) {
-                        a->capability=V4L2_AUDCAP_STEREO;
-                }
-
-                break;
-        }
-        case VIDIOC_S_AUDIO:
-        {
-                struct v4l2_audio *sarg = arg;
-
-                switch (sarg->index) {
-                case AUDIO_RADIO:
-                        /* Hauppauge uses IN2 for the radio */
-                        msp->mode   = MSP_MODE_FM_RADIO;
-                        scart       = SCART_IN2;
-                        break;
-                case AUDIO_EXTERN_1:
-                        /* IN1 is often used for external input ... */
-                        msp->mode   = MSP_MODE_EXTERN;
-                        scart       = SCART_IN1;
-                        break;
-                case AUDIO_EXTERN_2:
-                        /* ... sometimes it is IN2 through ;) */
-                        msp->mode   = MSP_MODE_EXTERN;
-                        scart       = SCART_IN2;
-                        break;
-                case AUDIO_TUNER:
-                        msp->mode   = -1;
-                        break;
-                }
-                if (scart) {
-                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
-                        msp->audmode = V4L2_TUNER_MODE_STEREO;
-                        msp3400c_set_scart(client,scart,0);
-                        msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
-                }
-                if (sarg->capability==V4L2_AUDCAP_STEREO) {
-                        msp->audmode = V4L2_TUNER_MODE_STEREO;
-                } else {
-                        msp->audmode &= ~V4L2_TUNER_MODE_STEREO;
-                }
-                msp_any_set_audmode(client, msp->audmode);
-                msp_wake_thread(client);
-                break;
-        }
-        case VIDIOC_G_TUNER:
-        {
-                struct v4l2_tuner *vt = arg;
-
-                msp_any_detect_stereo(client);
-                vt->audmode    = msp->audmode;
-                vt->rxsubchans = msp->rxsubchans;
-                vt->capability = V4L2_TUNER_CAP_STEREO |
-                        V4L2_TUNER_CAP_LANG1|
-                        V4L2_TUNER_CAP_LANG2;
-                break;
-        }
-        case VIDIOC_S_TUNER:
-        {
-                struct v4l2_tuner *vt=(struct v4l2_tuner *)arg;
-
-                /* only set audmode */
-                if (vt->audmode != -1 && vt->audmode != 0)
-                        msp_any_set_audmode(client, vt->audmode);
-                break;
-        }
-
-        case VIDIOC_G_AUDOUT:
-        {
-                struct v4l2_audioout *a=(struct v4l2_audioout *)arg;
-                int idx=a->index;
-
-                memset(a,0,sizeof(*a));
-
-                switch (idx) {
-                case 0:
-                        strcpy(a->name,"Scart1 Out");
-                        break;
-                case 1:
-                        strcpy(a->name,"Scart2 Out");
-                        break;
-                case 2:
-                        strcpy(a->name,"I2S Out");
-                        break;
-                default:
-                        return -EINVAL;
-                }
-                break;
-
-        }
-        case VIDIOC_S_AUDOUT:
-        {
-                struct v4l2_audioout *a=(struct v4l2_audioout *)arg;
-
-                if (a->index<0||a->index>2)
-                        return -EINVAL;
-
-                if (a->index==2) {
-                        if (a->mode == V4L2_AUDMODE_32BITS)
-                                msp->i2s_mode=1;
-                        else
-                                msp->i2s_mode=0;
-                }
-                msp3400_dbg("Setting audio out on msp34xx to input %i, mode %i\n",
-                                                a->index,msp->i2s_mode);
-                msp3400c_set_scart(client,msp->in_scart,a->index+1);
-
-                break;
-        }
-
-        default:
-                /* nothing */
-                break;
-        }
-        return 0;
-}
-
-static int msp_suspend(struct device * dev, pm_message_t state)
-{
-        struct i2c_client *client = container_of(dev, struct i2c_client, dev);
-
-        msp3400_dbg("msp34xx: suspend\n");
-        msp3400c_reset(client);
-        return 0;
-}
-
-static int msp_resume(struct device * dev)
-{
-        struct i2c_client *client = container_of(dev, struct i2c_client, dev);
-
-        msp3400_dbg("msp34xx: resume\n");
-        msp_wake_thread(client);
-        return 0;
-}
-
-/* ----------------------------------------------------------------------- */
-
-static int __init msp3400_init_module(void)
-{
-        return i2c_add_driver(&driver);
-}
-
-static void __exit msp3400_cleanup_module(void)
-{
-        i2c_del_driver(&driver);
-}
-
-module_init(msp3400_init_module);
-module_exit(msp3400_cleanup_module);
-
-/*
- * Overrides for Emacs so that we follow Linus's tabbing style.
- * ---------------------------------------------------------------------------
- * Local variables:
- * c-basic-offset: 8
- * End:
- */
diff --git a/drivers/media/video/msp3400.h b/drivers/media/video/msp3400.h
index 2d9ff40f0b09..8a05cf500a8c 100644
--- a/drivers/media/video/msp3400.h
+++ b/drivers/media/video/msp3400.h
@@ -6,22 +6,28 @@
 
 /* ---------------------------------------------------------------------- */
 
-struct msp_dfpreg {
-    int reg;
-    int value;
-};
-
 struct msp_matrix {
   int input;
   int output;
 };
 
-#define MSP_SET_DFPREG     _IOW('m',15,struct msp_dfpreg)
-#define MSP_GET_DFPREG     _IOW('m',16,struct msp_dfpreg)
-
 /* ioctl for MSP_SET_MATRIX will have to be registered */
 #define MSP_SET_MATRIX     _IOW('m',17,struct msp_matrix)
 
+/* This macro is allowed for *constants* only, gcc must calculate it
+   at compile time.  Remember -- no floats in kernel mode */
+#define MSP_CARRIER(freq) ((int)((float)(freq / 18.432) * (1 << 24)))
+
+#define MSP_MODE_AM_DETECT   0
+#define MSP_MODE_FM_RADIO    2
+#define MSP_MODE_FM_TERRA    3
+#define MSP_MODE_FM_SAT      4
+#define MSP_MODE_FM_NICAM1   5
+#define MSP_MODE_FM_NICAM2   6
+#define MSP_MODE_AM_NICAM    7
+#define MSP_MODE_BTSC        8
+#define MSP_MODE_EXTERN      9
+
 #define SCART_MASK    0
 #define SCART_IN1     1
 #define SCART_IN2     2
@@ -36,4 +42,84 @@ struct msp_matrix {
 #define SCART1_OUT    1
 #define SCART2_OUT    2
 
+#define OPMODE_AUTO       -1
+#define OPMODE_MANUAL      0
+#define OPMODE_AUTODETECT  1   /* use autodetect (>= msp3410 only) */
+#define OPMODE_AUTOSELECT  2   /* use autodetect & autoselect (>= msp34xxG)   */
+
+/* module parameters */
+extern int debug;
+extern int once;
+extern int amsound;
+extern int standard;
+extern int dolby;
+extern int stereo_threshold;
+
+struct msp_state {
+        int rev1, rev2;
+        u8 has_nicam;
+        u8 has_radio;
+        u8 has_headphones;
+        u8 has_ntsc_jp_d_k3;
+        u8 has_scart4;
+        u8 has_scart23_in_scart2_out;
+        u8 has_scart2_out_volume;
+        u8 has_i2s_conf;
+        u8 has_subwoofer;
+        u8 has_sound_processing;
+        u8 has_virtual_dolby_surround;
+        u8 has_dolby_pro_logic;
+
+        int radio;
+        int opmode;
+        int std;
+        int mode;
+        v4l2_std_id v4l2_std;
+        int nicam_on;
+        int acb;
+        int in_scart;
+        int i2s_mode;
+        int main, second;       /* sound carrier */
+        int input;
+        int source;             /* see msp34xxg_set_source */
+
+        /* v4l2 */
+        int audmode;
+        int rxsubchans;
+
+        int volume, muted;
+        int balance, loudness;
+        int bass, treble;
+
+        /* thread */
+        struct task_struct   *kthread;
+        wait_queue_head_t    wq;
+        int                  restart:1;
+        int                  watch_stereo:1;
+};
+
+/* msp3400-driver.c */
+int msp_write_dem(struct i2c_client *client, int addr, int val);
+int msp_write_dsp(struct i2c_client *client, int addr, int val);
+int msp_read_dem(struct i2c_client *client, int addr);
+int msp_read_dsp(struct i2c_client *client, int addr);
+int msp_reset(struct i2c_client *client);
+void msp_set_scart(struct i2c_client *client, int in, int out);
+void msp_set_mute(struct i2c_client *client);
+void msp_set_audio(struct i2c_client *client);
+int msp_modus(struct i2c_client *client);
+int msp_sleep(struct msp_state *state, int timeout);
+
+/* msp3400-kthreads.c */
+const char *msp_standard_std_name(int std);
+void msp3400c_setcarrier(struct i2c_client *client, int cdo1, int cdo2);
+void msp3400c_setmode(struct i2c_client *client, int type);
+void msp3400c_setstereo(struct i2c_client *client, int mode);
+int autodetect_stereo(struct i2c_client *client);
+int msp3400c_thread(void *data);
+int msp3410d_thread(void *data);
+int msp34xxg_thread(void *data);
+void msp34xxg_detect_stereo(struct i2c_client *client);
+void msp34xxg_set_audmode(struct i2c_client *client, int audmode);
+
 #endif /* MSP3400_H */
diff --git a/drivers/media/video/mt20xx.c b/drivers/media/video/mt20xx.c
index 2180018f06de..2c19c9588c02 100644
--- a/drivers/media/video/mt20xx.c
+++ b/drivers/media/video/mt20xx.c
@@ -20,6 +20,9 @@ module_param(tv_antenna,        int, 0644);
 static unsigned int radio_antenna = 0;
 module_param(radio_antenna,     int, 0644);
 
+/* from tuner-core.c */
+extern int debug;
+
 /* ---------------------------------------------------------------------- */
 
 #define MT2032 0x04
@@ -401,7 +404,7 @@ static void mt2050_set_if_freq(struct i2c_client *c,unsigned int freq, unsigned
         div2a=(lo2/8)-1;
         div2b=lo2-(div2a+1)*8;
 
-        if (tuner_debug > 1) {
+        if (debug > 1) {
                 tuner_dbg("lo1 lo2 = %d %d\n", lo1, lo2);
                 tuner_dbg("num1 num2 div1a div1b div2a div2b= %x %x %x %x %x %x\n",
                           num1,num2,div1a,div1b,div2a,div2b);
@@ -417,7 +420,7 @@ static void mt2050_set_if_freq(struct i2c_client *c,unsigned int freq, unsigned
         buf[5]=div2a;
         if(num2!=0) buf[5]=buf[5]|0x40;
 
-        if (tuner_debug > 1) {
+        if (debug > 1) {
                 int i;
                 tuner_dbg("bufs is: ");
                 for(i=0;i<6;i++)
@@ -494,11 +497,18 @@ int microtune_init(struct i2c_client *c)
         t->tv_freq    = NULL;
         t->radio_freq = NULL;
         t->standby    = NULL;
+        if (t->std & V4L2_STD_525_60) {
+                tuner_dbg("pinnacle ntsc\n");
+                t->radio_if2 = 41300 * 1000;
+        } else {
+                tuner_dbg("pinnacle pal\n");
+                t->radio_if2 = 33300 * 1000;
+        }
         name = "unknown";
 
         i2c_master_send(c,buf,1);
         i2c_master_recv(c,buf,21);
-        if (tuner_debug) {
+        if (debug) {
                 int i;
                 tuner_dbg("MT20xx hexdump:");
                 for(i=0;i<21;i++) {
diff --git a/drivers/media/video/mxb.c b/drivers/media/video/mxb.c
index d04793fb80fc..91681aa6c657 100644
--- a/drivers/media/video/mxb.c
+++ b/drivers/media/video/mxb.c
@@ -26,6 +26,7 @@
 #include <media/saa7146_vv.h>
 #include <media/tuner.h>
 #include <linux/video_decoder.h>
+#include <media/v4l2-common.h>
 
 #include "mxb.h"
 #include "tea6415c.h"
diff --git a/drivers/media/video/pms.c b/drivers/media/video/pms.c
index 2504207b2e3d..9e6448639480 100644
--- a/drivers/media/video/pms.c
+++ b/drivers/media/video/pms.c
@@ -883,6 +883,7 @@ static struct file_operations pms_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = pms_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .read           = pms_read,
         .llseek         = no_llseek,
 };
diff --git a/drivers/media/video/saa5249.c b/drivers/media/video/saa5249.c
index a51c7bd96618..73b4f0e2abf0 100644
--- a/drivers/media/video/saa5249.c
+++ b/drivers/media/video/saa5249.c
@@ -702,6 +702,7 @@ static struct file_operations saa_fops = {
         .open           = saa5249_open,
         .release        = saa5249_release,
         .ioctl          = saa5249_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/media/video/saa6588.c b/drivers/media/video/saa6588.c
index d60a783e0473..e70b17ef36e9 100644
--- a/drivers/media/video/saa6588.c
+++ b/drivers/media/video/saa6588.c
@@ -427,18 +427,8 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
 
 static int saa6588_probe(struct i2c_adapter *adap)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, saa6588_attach);
-#else
-        switch (adap->id) {
-        case I2C_HW_B_BT848:
-        case I2C_HW_B_RIVA:
-        case I2C_HW_SAA7134:
-                return i2c_probe(adap, &addr_data, saa6588_attach);
-                break;
-        }
-#endif
         return 0;
 }
 
@@ -496,7 +486,7 @@ static int saa6588_command(struct i2c_client *client, unsigned int cmd,
 
 static struct i2c_driver driver = {
         .driver = {
-                .name = "i2c saa6588 driver",
+                .name = "saa6588",
         },
         .id = -1,               /* FIXME */
         .attach_adapter = saa6588_probe,
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 29e28c742cd4..4a4bc69fb0e9 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -39,31 +39,18 @@
 #include <linux/i2c.h>
 #include <linux/videodev2.h>
 #include <media/v4l2-common.h>
+#include <media/audiochip.h>
+#include <asm/div64.h>
 
 MODULE_DESCRIPTION("Philips SAA7114/SAA7115 video decoder driver");
 MODULE_AUTHOR("Maxim Yevtyushkin, Kevin Thayer, Chris Kennedy, Hans Verkuil");
 MODULE_LICENSE("GPL");
 
 static int debug = 0;
-module_param(debug, int, 0644);
+module_param(debug, bool, 0644);
 
 MODULE_PARM_DESC(debug, "Debug level (0-1)");
 
-#define saa7115_dbg(fmt,arg...) \
-        do { \
-                if (debug) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                               client->driver->driver.name, \
-                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-#define saa7115_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define saa7115_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
 static unsigned short normal_i2c[] = { 0x42 >> 1, 0x40 >> 1, I2C_CLIENT_END };
 
 
@@ -73,12 +60,13 @@ struct saa7115_state {
         v4l2_std_id std;
         int input;
         int enable;
+        int radio;
         int bright;
         int contrast;
         int hue;
         int sat;
         enum v4l2_chip_ident ident;
-        enum v4l2_audio_clock_freq audclk_freq;
+        u32 audclk_freq;
 };
 
 /* ----------------------------------------------------------------------- */
@@ -469,80 +457,6 @@ static const unsigned char saa7115_init_misc[] = {
         0x00, 0x00
 };
 
-/* ============== SAA7715 AUDIO settings ============= */
-
-/* 48.0 kHz */
-static const unsigned char saa7115_cfg_48_audio[] = {
-        0x34, 0xce,
-        0x35, 0xfb,
-        0x36, 0x30,
-        0x00, 0x00
-};
-
-/* 44.1 kHz */
-static const unsigned char saa7115_cfg_441_audio[] = {
-        0x34, 0xf2,
-        0x35, 0x00,
-        0x36, 0x2d,
-        0x00, 0x00
-};
-
-/* 32.0 kHz */
-static const unsigned char saa7115_cfg_32_audio[] = {
-        0x34, 0xdf,
-        0x35, 0xa7,
-        0x36, 0x20,
-        0x00, 0x00
-};
-
-/* 48.0 kHz 60hz */
-static const unsigned char saa7115_cfg_60hz_48_audio[] = {
-        0x30, 0xcd,
-        0x31, 0x20,
-        0x32, 0x03,
-        0x00, 0x00
-};
-
-/* 48.0 kHz 50hz */
-static const unsigned char saa7115_cfg_50hz_48_audio[] = {
-        0x30, 0x00,
-        0x31, 0xc0,
-        0x32, 0x03,
-        0x00, 0x00
-};
-
-/* 44.1 kHz 60hz */
-static const unsigned char saa7115_cfg_60hz_441_audio[] = {
-        0x30, 0xbc,
-        0x31, 0xdf,
-        0x32, 0x02,
-        0x00, 0x00
-};
-
-/* 44.1 kHz 50hz */
-static const unsigned char saa7115_cfg_50hz_441_audio[] = {
-        0x30, 0x00,
-        0x31, 0x72,
-        0x32, 0x03,
-        0x00, 0x00
-};
-
-/* 32.0 kHz 60hz */
-static const unsigned char saa7115_cfg_60hz_32_audio[] = {
-        0x30, 0xde,
-        0x31, 0x15,
-        0x32, 0x02,
-        0x00, 0x00
-};
-
-/* 32.0 kHz 50hz */
-static const unsigned char saa7115_cfg_50hz_32_audio[] = {
-        0x30, 0x00,
-        0x31, 0x80,
-        0x32, 0x02,
-        0x00, 0x00
-};
-
 static int saa7115_odd_parity(u8 c)
 {
         c ^= (c >> 4);
@@ -627,40 +541,38 @@ static int saa7115_decode_wss(u8 * p)
 }
 
 
-static int saa7115_set_audio_clock_freq(struct i2c_client *client, enum v4l2_audio_clock_freq freq)
+static int saa7115_set_audio_clock_freq(struct i2c_client *client, u32 freq)
 {
         struct saa7115_state *state = i2c_get_clientdata(client);
+        u32 acpf;
+        u32 acni;
+        u32 hz;
+        u64 f;
 
-        saa7115_dbg("set audio clock freq: %d\n", freq);
-        switch (freq) {
-                case V4L2_AUDCLK_32_KHZ:
-                        saa7115_writeregs(client, saa7115_cfg_32_audio);
-                        if (state->std & V4L2_STD_525_60) {
-                                saa7115_writeregs(client, saa7115_cfg_60hz_32_audio);
-                        } else {
-                                saa7115_writeregs(client, saa7115_cfg_50hz_32_audio);
-                        }
-                        break;
-                case V4L2_AUDCLK_441_KHZ:
-                        saa7115_writeregs(client, saa7115_cfg_441_audio);
-                        if (state->std & V4L2_STD_525_60) {
-                                saa7115_writeregs(client, saa7115_cfg_60hz_441_audio);
-                        } else {
-                                saa7115_writeregs(client, saa7115_cfg_50hz_441_audio);
-                        }
-                        break;
-                case V4L2_AUDCLK_48_KHZ:
-                        saa7115_writeregs(client, saa7115_cfg_48_audio);
-                        if (state->std & V4L2_STD_525_60) {
-                                saa7115_writeregs(client, saa7115_cfg_60hz_48_audio);
-                        } else {
-                                saa7115_writeregs(client, saa7115_cfg_50hz_48_audio);
-                        }
-                        break;
-                default:
-                        saa7115_dbg("invalid audio setting %d\n", freq);
-                        return -EINVAL;
-        }
+        v4l_dbg(1, client, "set audio clock freq: %d\n", freq);
+
+        /* sanity check */
+        if (freq < 32000 || freq > 48000)
+                return -EINVAL;
+
+        /* hz is the refresh rate times 100 */
+        hz = (state->std & V4L2_STD_525_60) ? 5994 : 5000;
+        /* acpf = (256 * freq) / field_frequency == (256 * 100 * freq) / hz */
+        acpf = (25600 * freq) / hz;
+        /* acni = (256 * freq * 2^23) / crystal_frequency =
+                  (freq * 2^(8+23)) / crystal_frequency =
+                  (freq << 31) / 32.11 MHz */
+        f = freq;
+        f = f << 31;
+        do_div(f, 32110000);
+        acni = f;
+
+        saa7115_write(client, 0x30, acpf & 0xff);
+        saa7115_write(client, 0x31, (acpf >> 8) & 0xff);
+        saa7115_write(client, 0x32, (acpf >> 16) & 0x03);
+        saa7115_write(client, 0x34, acni & 0xff);
+        saa7115_write(client, 0x35, (acni >> 8) & 0xff);
+        saa7115_write(client, 0x36, (acni >> 16) & 0x3f);
         state->audclk_freq = freq;
         return 0;
 }
@@ -672,7 +584,7 @@ static int saa7115_set_v4lctrl(struct i2c_client *client, struct v4l2_control *c
         switch (ctrl->id) {
         case V4L2_CID_BRIGHTNESS:
                 if (ctrl->value < 0 || ctrl->value > 255) {
-                        saa7115_err("invalid brightness setting %d\n", ctrl->value);
+                        v4l_err(client, "invalid brightness setting %d\n", ctrl->value);
                         return -ERANGE;
                 }
 
@@ -682,7 +594,7 @@ static int saa7115_set_v4lctrl(struct i2c_client *client, struct v4l2_control *c
 
         case V4L2_CID_CONTRAST:
                 if (ctrl->value < 0 || ctrl->value > 127) {
-                        saa7115_err("invalid contrast setting %d\n", ctrl->value);
+                        v4l_err(client, "invalid contrast setting %d\n", ctrl->value);
                         return -ERANGE;
                 }
 
@@ -692,7 +604,7 @@ static int saa7115_set_v4lctrl(struct i2c_client *client, struct v4l2_control *c
 
         case V4L2_CID_SATURATION:
                 if (ctrl->value < 0 || ctrl->value > 127) {
-                        saa7115_err("invalid saturation setting %d\n", ctrl->value);
+                        v4l_err(client, "invalid saturation setting %d\n", ctrl->value);
                         return -ERANGE;
                 }
 
@@ -702,13 +614,16 @@ static int saa7115_set_v4lctrl(struct i2c_client *client, struct v4l2_control *c
 
         case V4L2_CID_HUE:
                 if (ctrl->value < -127 || ctrl->value > 127) {
-                        saa7115_err("invalid hue setting %d\n", ctrl->value);
+                        v4l_err(client, "invalid hue setting %d\n", ctrl->value);
                         return -ERANGE;
                 }
 
                 state->hue = ctrl->value;
                 saa7115_write(client, 0x0d, state->hue);
                 break;
+
+        default:
+                return -EINVAL;
         }
 
         return 0;
@@ -743,12 +658,22 @@ static void saa7115_set_v4lstd(struct i2c_client *client, v4l2_std_id std)
         struct saa7115_state *state = i2c_get_clientdata(client);
         int taskb = saa7115_read(client, 0x80) & 0x10;
 
+        /* Prevent unnecessary standard changes. During a standard
+           change the I-Port is temporarily disabled. Any devices
+           reading from that port can get confused.
+           Note that VIDIOC_S_STD is also used to switch from
+           radio to TV mode, so if a VIDIOC_S_STD is broadcast to
+           all I2C devices then you do not want to have an unwanted
+           side-effect here. */
+        if (std == state->std)
+                return;
+
         // This works for NTSC-M, SECAM-L and the 50Hz PAL variants.
         if (std & V4L2_STD_525_60) {
-                saa7115_dbg("decoder set standard 60 Hz\n");
+                v4l_dbg(1, client, "decoder set standard 60 Hz\n");
                 saa7115_writeregs(client, saa7115_cfg_60hz_video);
         } else {
-                saa7115_dbg("decoder set standard 50 Hz\n");
+                v4l_dbg(1, client, "decoder set standard 50 Hz\n");
                 saa7115_writeregs(client, saa7115_cfg_50hz_video);
         }
 
@@ -773,24 +698,17 @@ static v4l2_std_id saa7115_get_v4lstd(struct i2c_client *client)
 static void saa7115_log_status(struct i2c_client *client)
 {
         struct saa7115_state *state = i2c_get_clientdata(client);
-        char *audfreq = "undefined";
         int reg1e, reg1f;
         int signalOk;
         int vcr;
 
-        switch (state->audclk_freq) {
-                case V4L2_AUDCLK_32_KHZ:  audfreq = "32 kHz"; break;
-                case V4L2_AUDCLK_441_KHZ: audfreq = "44.1 kHz"; break;
-                case V4L2_AUDCLK_48_KHZ:  audfreq = "48 kHz"; break;
-        }
-
-        saa7115_info("Audio frequency: %s\n", audfreq);
+        v4l_info(client, "Audio frequency: %d Hz\n", state->audclk_freq);
         if (client->name[6] == '4') {
                 /* status for the saa7114 */
                 reg1f = saa7115_read(client, 0x1f);
                 signalOk = (reg1f & 0xc1) == 0x81;
-                saa7115_info("Video signal:    %s\n", signalOk ? "ok" : "bad");
-                saa7115_info("Frequency:       %s\n", (reg1f & 0x20) ? "60Hz" : "50Hz");
+                v4l_info(client, "Video signal:    %s\n", signalOk ? "ok" : "bad");
+                v4l_info(client, "Frequency:       %s\n", (reg1f & 0x20) ? "60 Hz" : "50 Hz");
                 return;
         }
 
@@ -801,21 +719,26 @@ static void saa7115_log_status(struct i2c_client *client)
         signalOk = (reg1f & 0xc1) == 0x81 && (reg1e & 0xc0) == 0x80;
         vcr = !(reg1f & 0x10);
 
-        saa7115_info("Video signal:    %s\n", signalOk ? (vcr ? "VCR" : "broadcast/DVD") : "bad");
-        saa7115_info("Frequency:       %s\n", (reg1f & 0x20) ? "60Hz" : "50Hz");
+        if (state->input >= 6) {
+                v4l_info(client, "Input:           S-Video %d\n", state->input - 6);
+        } else {
+                v4l_info(client, "Input:           Composite %d\n", state->input);
+        }
+        v4l_info(client, "Video signal:    %s\n", signalOk ? (vcr ? "VCR" : "broadcast/DVD") : "bad");
+        v4l_info(client, "Frequency:       %s\n", (reg1f & 0x20) ? "60 Hz" : "50 Hz");
 
         switch (reg1e & 0x03) {
                 case 1:
-                        saa7115_info("Detected format: NTSC\n");
+                        v4l_info(client, "Detected format: NTSC\n");
                         break;
                 case 2:
-                        saa7115_info("Detected format: PAL\n");
+                        v4l_info(client, "Detected format: PAL\n");
                         break;
                 case 3:
-                        saa7115_info("Detected format: SECAM\n");
+                        v4l_info(client, "Detected format: SECAM\n");
                         break;
                 default:
-                        saa7115_info("Detected format: BW/No color\n");
+                        v4l_info(client, "Detected format: BW/No color\n");
                         break;
         }
 }
@@ -940,7 +863,7 @@ static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt
 
         pix = &(fmt->fmt.pix);
 
-        saa7115_dbg("decoder set size\n");
+        v4l_dbg(1, client, "decoder set size\n");
 
         /* FIXME need better bounds checking here */
         if ((pix->width < 1) || (pix->width > 1440))
@@ -966,7 +889,7 @@ static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt
                 HPSC = HPSC ? HPSC : 1;
                 HFSC = (int)((1024 * 720) / (HPSC * pix->width));
 
-                saa7115_dbg("Hpsc: 0x%05x, Hfsc: 0x%05x\n", HPSC, HFSC);
+                v4l_dbg(1, client, "Hpsc: 0x%05x, Hfsc: 0x%05x\n", HPSC, HFSC);
                 /* FIXME hardcodes to "Task B"
                  * write H prescaler integer */
                 saa7115_write(client, 0xd0, (u8) (HPSC & 0x3f));
@@ -980,10 +903,10 @@ static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt
                 saa7115_write(client, 0xDD, (u8) ((HFSC >> 9) & 0xff));
         } else {
                 if (is_50hz) {
-                        saa7115_dbg("Setting full 50hz width\n");
+                        v4l_dbg(1, client, "Setting full 50hz width\n");
                         saa7115_writeregs(client, saa7115_cfg_50hz_fullres_x);
                 } else {
-                        saa7115_dbg("Setting full 60hz width\n");
+                        v4l_dbg(1, client, "Setting full 60hz width\n");
                         saa7115_writeregs(client, saa7115_cfg_60hz_fullres_x);
                 }
         }
@@ -992,7 +915,7 @@ static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt
 
         if (pix->height != Vsrc) {
                 VSCY = (int)((1024 * Vsrc) / pix->height);
-                saa7115_dbg("Vsrc: %d, Vscy: 0x%05x\n", Vsrc, VSCY);
+                v4l_dbg(1, client, "Vsrc: %d, Vscy: 0x%05x\n", Vsrc, VSCY);
 
                 /* Correct Contrast and Luminance */
                 saa7115_write(client, 0xd5, (u8) (64 * 1024 / VSCY));
@@ -1006,10 +929,10 @@ static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt
                 saa7115_write(client, 0xe3, (u8) ((VSCY >> 8) & 0xff));
         } else {
                 if (is_50hz) {
-                        saa7115_dbg("Setting full 50Hz height\n");
+                        v4l_dbg(1, client, "Setting full 50Hz height\n");
                         saa7115_writeregs(client, saa7115_cfg_50hz_fullres_y);
                 } else {
-                        saa7115_dbg("Setting full 60hz height\n");
+                        v4l_dbg(1, client, "Setting full 60hz height\n");
                         saa7115_writeregs(client, saa7115_cfg_60hz_fullres_y);
                 }
         }
@@ -1089,6 +1012,48 @@ static void saa7115_decode_vbi_line(struct i2c_client *client,
 
 /* ============ SAA7115 AUDIO settings (end) ============= */
 
+static struct v4l2_queryctrl saa7115_qctrl[] = {
+        {
+                .id            = V4L2_CID_BRIGHTNESS,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Brightness",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 128,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_CONTRAST,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Contrast",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 64,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_SATURATION,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Saturation",
+                .minimum       = 0,
+                .maximum       = 255,
+                .step          = 1,
+                .default_value = 64,
+                .flags         = 0,
+        }, {
+                .id            = V4L2_CID_HUE,
+                .type          = V4L2_CTRL_TYPE_INTEGER,
+                .name          = "Hue",
+                .minimum       = -128,
+                .maximum       = 127,
+                .step          = 1,
+                .default_value = 0,
+                .flags         = 0,
+        },
+};
+
+/* ----------------------------------------------------------------------- */
+
 static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *arg)
 {
         struct saa7115_state *state = i2c_get_clientdata(client);
@@ -1103,16 +1068,18 @@ static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *ar
                 return saa7115_get_v4lfmt(client, (struct v4l2_format *)arg);
 
         case VIDIOC_INT_AUDIO_CLOCK_FREQ:
-                return saa7115_set_audio_clock_freq(client, *(enum v4l2_audio_clock_freq *)arg);
+                return saa7115_set_audio_clock_freq(client, *(u32 *)arg);
 
         case VIDIOC_G_TUNER:
         {
                 struct v4l2_tuner *vt = arg;
                 int status;
 
+                if (state->radio)
+                        break;
                 status = saa7115_read(client, 0x1f);
 
-                saa7115_dbg("status: 0x%02x\n", status);
+                v4l_dbg(1, client, "status: 0x%02x\n", status);
                 vt->signal = ((status & (1 << 6)) == 0) ? 0xffff : 0x0;
                 break;
         }
@@ -1127,20 +1094,38 @@ static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *ar
         case VIDIOC_S_CTRL:
                 return saa7115_set_v4lctrl(client, (struct v4l2_control *)arg);
 
+        case VIDIOC_QUERYCTRL:
+        {
+                struct v4l2_queryctrl *qc = arg;
+                int i;
+
+                for (i = 0; i < ARRAY_SIZE(saa7115_qctrl); i++)
+                        if (qc->id && qc->id == saa7115_qctrl[i].id) {
+                                memcpy(qc, &saa7115_qctrl[i], sizeof(*qc));
+                                return 0;
+                        }
+                return -EINVAL;
+        }
+
         case VIDIOC_G_STD:
                 *(v4l2_std_id *)arg = saa7115_get_v4lstd(client);
                 break;
 
         case VIDIOC_S_STD:
+                state->radio = 0;
                 saa7115_set_v4lstd(client, *(v4l2_std_id *)arg);
                 break;
 
+        case AUDC_SET_RADIO:
+                state->radio = 1;
+                break;
+
         case VIDIOC_G_INPUT:
                 *(int *)arg = state->input;
                 break;
 
         case VIDIOC_S_INPUT:
-                saa7115_dbg("decoder set input %d\n", *iarg);
+                v4l_dbg(1, client, "decoder set input %d\n", *iarg);
                 /* inputs from 0-9 are available */
                 if (*iarg < 0 || *iarg > 9) {
                         return -EINVAL;
@@ -1148,7 +1133,7 @@ static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *ar
 
                 if (state->input == *iarg)
                         break;
-                saa7115_dbg("now setting %s input\n",
+                v4l_dbg(1, client, "now setting %s input\n",
                         *iarg >= 6 ? "S-Video" : "Composite");
                 state->input = *iarg;
 
@@ -1165,7 +1150,7 @@ static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *ar
 
         case VIDIOC_STREAMON:
         case VIDIOC_STREAMOFF:
-                saa7115_dbg("%s output\n",
+                v4l_dbg(1, client, "%s output\n",
                         (cmd == VIDIOC_STREAMON) ? "enable" : "disable");
 
                 if (state->enable != (cmd == VIDIOC_STREAMON)) {
@@ -1179,7 +1164,7 @@ static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *ar
                 break;
 
         case VIDIOC_INT_RESET:
-                saa7115_dbg("decoder RESET\n");
+                v4l_dbg(1, client, "decoder RESET\n");
                 saa7115_writeregs(client, saa7115_cfg_reset_scaler);
                 break;
 
@@ -1273,19 +1258,19 @@ static int saa7115_attach(struct i2c_adapter *adapter, int address, int kind)
         client->driver = &i2c_driver_saa7115;
         snprintf(client->name, sizeof(client->name) - 1, "saa7115");
 
-        saa7115_dbg("detecting saa7115 client on address 0x%x\n", address << 1);
+        v4l_dbg(1, client, "detecting saa7115 client on address 0x%x\n", address << 1);
 
         saa7115_write(client, 0, 5);
         chip_id = saa7115_read(client, 0) & 0x0f;
         if (chip_id != 4 && chip_id != 5) {
-                saa7115_dbg("saa7115 not found\n");
+                v4l_dbg(1, client, "saa7115 not found\n");
                 kfree(client);
                 return 0;
         }
         if (chip_id == 4) {
                 snprintf(client->name, sizeof(client->name) - 1, "saa7114");
         }
-        saa7115_info("saa711%d found @ 0x%x (%s)\n", chip_id, address << 1, adapter->name);
+        v4l_info(client, "saa711%d found @ 0x%x (%s)\n", chip_id, address << 1, adapter->name);
 
         state = kmalloc(sizeof(struct saa7115_state), GFP_KERNEL);
         i2c_set_clientdata(client, state);
@@ -1297,14 +1282,15 @@ static int saa7115_attach(struct i2c_adapter *adapter, int address, int kind)
         state->std = V4L2_STD_NTSC;
         state->input = -1;
         state->enable = 1;
+        state->radio = 0;
         state->bright = 128;
         state->contrast = 64;
         state->hue = 0;
         state->sat = 64;
         state->ident = (chip_id == 4) ? V4L2_IDENT_SAA7114 : V4L2_IDENT_SAA7115;
-        state->audclk_freq = V4L2_AUDCLK_48_KHZ;
+        state->audclk_freq = 48000;
 
-        saa7115_dbg("writing init values\n");
+        v4l_dbg(1, client, "writing init values\n");
 
         /* init to 60hz/48khz */
         saa7115_writeregs(client, saa7115_init_auto_input);
@@ -1312,13 +1298,12 @@ static int saa7115_attach(struct i2c_adapter *adapter, int address, int kind)
         saa7115_writeregs(client, saa7115_cfg_60hz_fullres_x);
         saa7115_writeregs(client, saa7115_cfg_60hz_fullres_y);
         saa7115_writeregs(client, saa7115_cfg_60hz_video);
-        saa7115_writeregs(client, saa7115_cfg_48_audio);
-        saa7115_writeregs(client, saa7115_cfg_60hz_48_audio);
+        saa7115_set_audio_clock_freq(client, state->audclk_freq);
         saa7115_writeregs(client, saa7115_cfg_reset_scaler);
 
         i2c_attach_client(client);
 
-        saa7115_dbg("status: (1E) 0x%02x, (1F) 0x%02x\n",
+        v4l_dbg(1, client, "status: (1E) 0x%02x, (1F) 0x%02x\n",
                 saa7115_read(client, 0x1e), saa7115_read(client, 0x1f));
 
         return 0;
@@ -1326,11 +1311,7 @@ static int saa7115_attach(struct i2c_adapter *adapter, int address, int kind)
 
 static int saa7115_probe(struct i2c_adapter *adapter)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adapter->class & I2C_CLASS_TV_ANALOG)
-#else
-        if (adapter->id == I2C_HW_B_BT848)
-#endif
                 return i2c_probe(adapter, &addr_data, &saa7115_attach);
         return 0;
 }
diff --git a/drivers/media/video/saa711x.c b/drivers/media/video/saa711x.c
index 8008537391b5..f39a7be08588 100644
--- a/drivers/media/video/saa711x.c
+++ b/drivers/media/video/saa711x.c
@@ -567,9 +567,7 @@ static struct i2c_driver i2c_driver_saa711x = {
         .driver = {
                 .name = "saa711x",
         },
-
         .id = I2C_DRIVERID_SAA711X,
-
         .attach_adapter = saa711x_attach_adapter,
         .detach_client = saa711x_detach_client,
         .command = saa711x_command,
diff --git a/drivers/media/video/saa7127.c b/drivers/media/video/saa7127.c
index bca6ed0e2752..2009c1bc4720 100644
--- a/drivers/media/video/saa7127.c
+++ b/drivers/media/video/saa7127.c
@@ -66,30 +66,6 @@ module_param(test_image, int, 0644);
 MODULE_PARM_DESC(debug, "debug level (0-2)");
 MODULE_PARM_DESC(test_image, "test_image (0-1)");
 
-#define saa7127_dbg(fmt, arg...) \
-        do { \
-                if (debug >= 1) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                               client->driver->driver.name, \
-                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-/* High volume debug. Use with care. */
-#define saa7127_dbg_highvol(fmt, arg...) \
-        do { \
-                if (debug == 2) \
-                        printk(KERN_INFO "%s debug %d-%04x: " fmt, \
-                               client->driver->driver.name, \
-                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
-        } while (0)
-
-#define saa7127_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define saa7127_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
 static unsigned short normal_i2c[] = { 0x88 >> 1, I2C_CLIENT_END };
 
 
@@ -336,7 +312,7 @@ static int saa7127_write(struct i2c_client *client, u8 reg, u8 val)
                 if (i2c_smbus_write_byte_data(client, reg, val) == 0)
                         return 0;
         }
-        saa7127_err("I2C Write Problem\n");
+        v4l_err(client, "I2C Write Problem\n");
         return -1;
 }
 
@@ -362,7 +338,7 @@ static int saa7127_set_vps(struct i2c_client *client, struct v4l2_sliced_vbi_dat
         if (enable && (data->field != 0 || data->line != 16))
                 return -EINVAL;
         if (state->vps_enable != enable) {
-                saa7127_dbg("Turn VPS Signal %s\n", enable ? "on" : "off");
+                v4l_dbg(1, client, "Turn VPS Signal %s\n", enable ? "on" : "off");
                 saa7127_write(client, 0x54, enable << 7);
                 state->vps_enable = enable;
         }
@@ -374,7 +350,7 @@ static int saa7127_set_vps(struct i2c_client *client, struct v4l2_sliced_vbi_dat
         state->vps_data[2] = data->data[11];
         state->vps_data[3] = data->data[12];
         state->vps_data[4] = data->data[13];
-        saa7127_dbg("Set VPS data %02x %02x %02x %02x %02x\n",
+        v4l_dbg(1, client, "Set VPS data %02x %02x %02x %02x %02x\n",
                 state->vps_data[0], state->vps_data[1],
                 state->vps_data[2], state->vps_data[3],
                 state->vps_data[4]);
@@ -397,7 +373,7 @@ static int saa7127_set_cc(struct i2c_client *client, struct v4l2_sliced_vbi_data
         if (enable && (data->field != 0 || data->line != 21))
                 return -EINVAL;
         if (state->cc_enable != enable) {
-                saa7127_dbg("Turn CC %s\n", enable ? "on" : "off");
+                v4l_dbg(1, client, "Turn CC %s\n", enable ? "on" : "off");
                 saa7127_write(client, SAA7127_REG_CLOSED_CAPTION,
                                 (state->xds_enable << 7) | (enable << 6) | 0x11);
                 state->cc_enable = enable;
@@ -405,7 +381,7 @@ static int saa7127_set_cc(struct i2c_client *client, struct v4l2_sliced_vbi_data
         if (!enable)
                 return 0;
 
-        saa7127_dbg_highvol("CC data: %04x\n", cc);
+        v4l_dbg(2, client, "CC data: %04x\n", cc);
         saa7127_write(client, SAA7127_REG_LINE_21_ODD_0, cc & 0xff);
         saa7127_write(client, SAA7127_REG_LINE_21_ODD_1, cc >> 8);
         state->cc_data = cc;
@@ -423,7 +399,7 @@ static int saa7127_set_xds(struct i2c_client *client, struct v4l2_sliced_vbi_dat
         if (enable && (data->field != 1 || data->line != 21))
                 return -EINVAL;
         if (state->xds_enable != enable) {
-                saa7127_dbg("Turn XDS %s\n", enable ? "on" : "off");
+                v4l_dbg(1, client, "Turn XDS %s\n", enable ? "on" : "off");
                 saa7127_write(client, SAA7127_REG_CLOSED_CAPTION,
                                 (enable << 7) | (state->cc_enable << 6) | 0x11);
                 state->xds_enable = enable;
@@ -431,7 +407,7 @@ static int saa7127_set_xds(struct i2c_client *client, struct v4l2_sliced_vbi_dat
         if (!enable)
                 return 0;
 
-        saa7127_dbg_highvol("XDS data: %04x\n", xds);
+        v4l_dbg(2, client, "XDS data: %04x\n", xds);
         saa7127_write(client, SAA7127_REG_LINE_21_EVEN_0, xds & 0xff);
         saa7127_write(client, SAA7127_REG_LINE_21_EVEN_1, xds >> 8);
         state->xds_data = xds;
@@ -448,7 +424,7 @@ static int saa7127_set_wss(struct i2c_client *client, struct v4l2_sliced_vbi_dat
         if (enable && (data->field != 0 || data->line != 23))
                 return -EINVAL;
         if (state->wss_enable != enable) {
-                saa7127_dbg("Turn WSS %s\n", enable ? "on" : "off");
+                v4l_dbg(1, client, "Turn WSS %s\n", enable ? "on" : "off");
                 saa7127_write(client, 0x27, enable << 7);
                 state->wss_enable = enable;
         }
@@ -457,7 +433,7 @@ static int saa7127_set_wss(struct i2c_client *client, struct v4l2_sliced_vbi_dat
 
         saa7127_write(client, 0x26, data->data[0]);
         saa7127_write(client, 0x27, 0x80 | (data->data[1] & 0x3f));
-        saa7127_dbg("WSS mode: %s\n", wss_strs[data->data[0] & 0xf]);
+        v4l_dbg(1, client, "WSS mode: %s\n", wss_strs[data->data[0] & 0xf]);
         state->wss_mode = (data->data[1] & 0x3f) << 8 | data->data[0];
         return 0;
 }
@@ -469,11 +445,11 @@ static int saa7127_set_video_enable(struct i2c_client *client, int enable)
         struct saa7127_state *state = i2c_get_clientdata(client);
 
         if (enable) {
-                saa7127_dbg("Enable Video Output\n");
+                v4l_dbg(1, client, "Enable Video Output\n");
                 saa7127_write(client, 0x2d, state->reg_2d);
                 saa7127_write(client, 0x61, state->reg_61);
         } else {
-                saa7127_dbg("Disable Video Output\n");
+                v4l_dbg(1, client, "Disable Video Output\n");
                 saa7127_write(client, 0x2d, (state->reg_2d & 0xf0));
                 saa7127_write(client, 0x61, (state->reg_61 | 0xc0));
         }
@@ -489,11 +465,11 @@ static int saa7127_set_std(struct i2c_client *client, v4l2_std_id std)
         const struct i2c_reg_value *inittab;
 
         if (std & V4L2_STD_525_60) {
-                saa7127_dbg("Selecting 60 Hz video Standard\n");
+                v4l_dbg(1, client, "Selecting 60 Hz video Standard\n");
                 inittab = saa7127_init_config_60hz;
                 state->reg_61 = SAA7127_60HZ_DAC_CONTROL;
         } else {
-                saa7127_dbg("Selecting 50 Hz video Standard\n");
+                v4l_dbg(1, client, "Selecting 50 Hz video Standard\n");
                 inittab = saa7127_init_config_50hz;
                 state->reg_61 = SAA7127_50HZ_DAC_CONTROL;
         }
@@ -544,7 +520,7 @@ static int saa7127_set_output_type(struct i2c_client *client, int output)
         default:
                 return -EINVAL;
         }
-        saa7127_dbg("Selecting %s output type\n", output_strs[output]);
+        v4l_dbg(1, client, "Selecting %s output type\n", output_strs[output]);
 
         /* Configure Encoder */
         saa7127_write(client, 0x2d, state->reg_2d);
@@ -561,12 +537,12 @@ static int saa7127_set_input_type(struct i2c_client *client, int input)
 
         switch (input) {
         case SAA7127_INPUT_TYPE_NORMAL: /* avia */
-                saa7127_dbg("Selecting Normal Encoder Input\n");
+                v4l_dbg(1, client, "Selecting Normal Encoder Input\n");
                 state->reg_3a_cb = 0;
                 break;
 
         case SAA7127_INPUT_TYPE_TEST_IMAGE:     /* color bar */
-                saa7127_dbg("Selecting Color Bar generator\n");
+                v4l_dbg(1, client, "Selecting Color Bar generator\n");
                 state->reg_3a_cb = 0x80;
                 break;
 
@@ -633,14 +609,14 @@ static int saa7127_command(struct i2c_client *client,
                 break;
 
         case VIDIOC_LOG_STATUS:
-                saa7127_info("Standard: %s\n", (state->std & V4L2_STD_525_60) ? "60 Hz" : "50 Hz");
-                saa7127_info("Input:    %s\n", state->input_type ?  "color bars" : "normal");
-                saa7127_info("Output:   %s\n", state->video_enable ?
+                v4l_info(client, "Standard: %s\n", (state->std & V4L2_STD_525_60) ? "60 Hz" : "50 Hz");
+                v4l_info(client, "Input:    %s\n", state->input_type ?  "color bars" : "normal");
+                v4l_info(client, "Output:   %s\n", state->video_enable ?
                         output_strs[state->output_type] : "disabled");
-                saa7127_info("WSS:      %s\n", state->wss_enable ?
+                v4l_info(client, "WSS:      %s\n", state->wss_enable ?
                         wss_strs[state->wss_mode] : "disabled");
-                saa7127_info("VPS:      %s\n", state->vps_enable ? "enabled" : "disabled");
-                saa7127_info("CC:       %s\n", state->cc_enable ? "enabled" : "disabled");
+                v4l_info(client, "VPS:      %s\n", state->vps_enable ? "enabled" : "disabled");
+                v4l_info(client, "CC:       %s\n", state->cc_enable ? "enabled" : "disabled");
                 break;
 
 #ifdef CONFIG_VIDEO_ADV_DEBUG
@@ -723,7 +699,7 @@ static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
         client->driver = &i2c_driver_saa7127;
         snprintf(client->name, sizeof(client->name) - 1, "saa7127");
 
-        saa7127_dbg("detecting saa7127 client on address 0x%x\n", address << 1);
+        v4l_dbg(1, client, "detecting saa7127 client on address 0x%x\n", address << 1);
 
         /* First test register 0: Bits 5-7 are a version ID (should be 0),
            and bit 2 should also be 0.
@@ -732,7 +708,7 @@ static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
            0x1d after a reset and not expected to ever change. */
         if ((saa7127_read(client, 0) & 0xe4) != 0 ||
                         (saa7127_read(client, 0x29) & 0x3f) != 0x1d) {
-                saa7127_dbg("saa7127 not found\n");
+                v4l_dbg(1, client, "saa7127 not found\n");
                 kfree(client);
                 return 0;
         }
@@ -748,7 +724,7 @@ static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
 
         /* Configure Encoder */
 
-        saa7127_dbg("Configuring encoder\n");
+        v4l_dbg(1, client, "Configuring encoder\n");
         saa7127_write_inittab(client, saa7127_init_config_common);
         saa7127_set_std(client, V4L2_STD_NTSC);
         saa7127_set_output_type(client, SAA7127_OUTPUT_TYPE_BOTH);
@@ -769,12 +745,12 @@ static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
         read_result = saa7127_read(client, SAA7129_REG_FADE_KEY_COL2);
         saa7127_write(client, SAA7129_REG_FADE_KEY_COL2, 0xaa);
         if (saa7127_read(client, SAA7129_REG_FADE_KEY_COL2) == 0xaa) {
-                saa7127_info("saa7129 found @ 0x%x (%s)\n", address << 1, adapter->name);
+                v4l_info(client, "saa7129 found @ 0x%x (%s)\n", address << 1, adapter->name);
                 saa7127_write(client, SAA7129_REG_FADE_KEY_COL2, read_result);
                 saa7127_write_inittab(client, saa7129_init_config_extra);
                 state->ident = V4L2_IDENT_SAA7129;
         } else {
-                saa7127_info("saa7127 found @ 0x%x (%s)\n", address << 1, adapter->name);
+                v4l_info(client, "saa7127 found @ 0x%x (%s)\n", address << 1, adapter->name);
                 state->ident = V4L2_IDENT_SAA7127;
         }
 
@@ -787,11 +763,7 @@ static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
 
 static int saa7127_probe(struct i2c_adapter *adapter)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adapter->class & I2C_CLASS_TV_ANALOG)
-#else
-        if (adapter->id == I2C_HW_B_BT848)
-#endif
                 return i2c_probe(adapter, &addr_data, saa7127_attach);
         return 0;
 }
diff --git a/drivers/media/video/saa7134/saa6752hs.c b/drivers/media/video/saa7134/saa6752hs.c
index 4615a982ac64..ad73c4a60f2b 100644
--- a/drivers/media/video/saa7134/saa6752hs.c
+++ b/drivers/media/video/saa7134/saa6752hs.c
@@ -9,7 +9,8 @@
 #include <linux/poll.h>
 #include <linux/i2c.h>
 #include <linux/types.h>
-#include <linux/videodev.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-common.h>
 #include <linux/init.h>
 #include <linux/crc32.h>
 
@@ -509,7 +510,6 @@ static int saa6752hs_attach(struct i2c_adapter *adap, int addr, int kind)
 {
         struct saa6752hs_state *h;
 
-        printk("saa6752hs: chip found @ 0x%x\n", addr<<1);
 
         if (NULL == (h = kmalloc(sizeof(*h), GFP_KERNEL)))
                 return -ENOMEM;
@@ -525,6 +525,8 @@ static int saa6752hs_attach(struct i2c_adapter *adap, int addr, int kind)
         i2c_set_clientdata(&h->client, h);
         i2c_attach_client(&h->client);
 
+        v4l_info(&h->client,"saa6752hs: chip found @ 0x%x\n", addr<<1);
+
         return 0;
 }
 
@@ -598,7 +600,7 @@ saa6752hs_command(struct i2c_client *client, unsigned int cmd, void *arg)
 
 static struct i2c_driver driver = {
         .driver = {
-                .name   = "i2c saa6752hs MPEG encoder",
+                .name   = "saa6752hs",
         },
         .id             = I2C_DRIVERID_SAA6752HS,
         .attach_adapter = saa6752hs_probe,
diff --git a/drivers/media/video/saa7134/saa7134-alsa.c b/drivers/media/video/saa7134/saa7134-alsa.c
index ade05f75fdb0..a7a6ab9298a9 100644
--- a/drivers/media/video/saa7134/saa7134-alsa.c
+++ b/drivers/media/video/saa7134/saa7134-alsa.c
@@ -20,13 +20,13 @@
  *
  */
 
-#include <sound/driver.h>
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/time.h>
 #include <linux/wait.h>
 #include <linux/moduleparam.h>
 #include <linux/module.h>
+#include <sound/driver.h>
 #include <sound/core.h>
 #include <sound/control.h>
 #include <sound/pcm.h>
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index 672fb205959f..77e5be98e4c6 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -25,6 +25,7 @@
 
 #include "saa7134-reg.h"
 #include "saa7134.h"
+#include <media/v4l2-common.h>
 
 /* commly used strings */
 static char name_mute[]    = "mute";
@@ -2555,6 +2556,69 @@ struct saa7134_board saa7134_boards[] = {
                         .amux   = LINE1,
                 },
         },
+        [SAA7134_BOARD_CINERGY250PCI] = {
+                /* remote-control does not work. The signal about a
+                   key press comes in via gpio, but the key code
+                   doesn't. Neither does it have an i2c remote control
+                   interface. */
+                .name           = "Terratec Cinergy 250 PCI TV",
+                .audio_clock    = 0x00187de7,
+                .tuner_type     = TUNER_PHILIPS_TDA8290,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .gpiomask       = 0x80200000,
+                .inputs         = {{
+                        .name = name_tv,
+                        .vmux = 1,
+                        .amux = TV,
+                        .tv   = 1,
+                },{
+                        .name = name_svideo,  /* NOT tested */
+                        .vmux = 8,
+                        .amux = LINE1,
+                }},
+                .radio = {
+                        .name   = name_radio,
+                        .amux   = LINE1,
+                        .gpio   = 0x0200000,
+                },
+        },
+        [SAA7134_BOARD_FLYDVB_TRIO] = {
+                /* LifeView LR319 FlyDVB Trio */
+                /* Peter Missel <peter.missel@onlinehome.de> */
+                .name           = "LifeView FlyDVB Trio",
+                .audio_clock    = 0x00200000,
+                .tuner_type     = TUNER_PHILIPS_TDA8290,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .gpiomask       = 0x00200000,
+                .inputs         = {{
+                        .name = name_tv,        /* Analog broadcast/cable TV */
+                        .vmux = 1,
+                        .amux = TV,
+                        .gpio = 0x200000,       /* GPIO21=High for TV input */
+                        .tv   = 1,
+                },{
+                        .name = name_svideo,    /* S-Video signal on S-Video input */
+                        .vmux = 8,
+                        .amux = LINE2,
+                },{
+                        .name = name_comp1,     /* Composite signal on S-Video input */
+                        .vmux = 0,
+                        .amux = LINE2,
+                },{
+                        .name = name_comp2,     /* Composite input */
+                        .vmux = 3,
+                        .amux = LINE2,
+                }},
+                .radio = {
+                        .name = name_radio,
+                        .amux = TV,
+                        .gpio = 0x000000,       /* GPIO21=Low for FM radio antenna */
+                },
+        },
 };
 
 const unsigned int saa7134_bcount = ARRAY_SIZE(saa7134_boards);
@@ -2895,6 +2959,12 @@ struct pci_device_id saa7134_pci_tbl[] = {
                 .vendor       = PCI_VENDOR_ID_PHILIPS,
                 .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
                 .subvendor    = 0x1421,
+                .subdevice    = 0x0351,         /* PCI version, new revision */
+                .driver_data  = SAA7134_BOARD_ADS_INSTANT_TV,
+        },{
+                .vendor       = PCI_VENDOR_ID_PHILIPS,
+                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
+                .subvendor    = 0x1421,
                 .subdevice    = 0x0370,         /* cardbus version */
                 .driver_data  = SAA7134_BOARD_ADS_INSTANT_TV,
         },{
@@ -3002,6 +3072,18 @@ struct pci_device_id saa7134_pci_tbl[] = {
                 .subdevice    = 0x6231,
                 .driver_data  = SAA7134_BOARD_MSI_TVATANYWHERE_PLUS,
         },{
+                .vendor       = PCI_VENDOR_ID_PHILIPS,
+                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
+                .subvendor    = 0x153b,
+                .subdevice    = 0x1160,
+                .driver_data  = SAA7134_BOARD_CINERGY250PCI,
+        },{
+                .vendor       = PCI_VENDOR_ID_PHILIPS,
+                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,  /* SAA 7131E */
+                .subvendor    = 0x5168,
+                .subdevice    = 0x0319,
+                .driver_data  = SAA7134_BOARD_FLYDVB_TRIO,
+        },{
                 /* --- boards without eeprom + subsystem ID --- */
                 .vendor       = PCI_VENDOR_ID_PHILIPS,
                 .device       = PCI_DEVICE_ID_PHILIPS_SAA7134,
@@ -3090,6 +3172,7 @@ int saa7134_board_init1(struct saa7134_dev *dev)
         case SAA7134_BOARD_AVERMEDIA_GO_007_FM:
 /*      case SAA7134_BOARD_SABRENT_SBTTVFM:  */ /* not finished yet */
         case SAA7134_BOARD_VIDEOMATE_TV_PVR:
+        case SAA7134_BOARD_VIDEOMATE_GOLD_PLUS:
         case SAA7134_BOARD_VIDEOMATE_TV_GOLD_PLUSII:
         case SAA7134_BOARD_VIDEOMATE_DVBT_300:
         case SAA7134_BOARD_VIDEOMATE_DVBT_200:
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index 23d8747338ed..accbc32725cf 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -95,77 +95,6 @@ int (*dmasound_exit)(struct saa7134_dev *dev);
 #define dprintk(fmt, arg...)    if (core_debug) \
         printk(KERN_DEBUG "%s/core: " fmt, dev->name , ## arg)
 
-/* ------------------------------------------------------------------ */
-/* debug help functions                                               */
-
-static const char *v4l1_ioctls[] = {
-        "0", "GCAP", "GCHAN", "SCHAN", "GTUNER", "STUNER", "GPICT", "SPICT",
-        "CCAPTURE", "GWIN", "SWIN", "GFBUF", "SFBUF", "KEY", "GFREQ",
-        "SFREQ", "GAUDIO", "SAUDIO", "SYNC", "MCAPTURE", "GMBUF", "GUNIT",
-        "GCAPTURE", "SCAPTURE", "SPLAYMODE", "SWRITEMODE", "GPLAYINFO",
-        "SMICROCODE", "GVBIFMT", "SVBIFMT" };
-#define V4L1_IOCTLS ARRAY_SIZE(v4l1_ioctls)
-
-static const char *v4l2_ioctls[] = {
-        "QUERYCAP", "1", "ENUM_PIXFMT", "ENUM_FBUFFMT", "G_FMT", "S_FMT",
-        "G_COMP", "S_COMP", "REQBUFS", "QUERYBUF", "G_FBUF", "S_FBUF",
-        "G_WIN", "S_WIN", "PREVIEW", "QBUF", "16", "DQBUF", "STREAMON",
-        "STREAMOFF", "G_PERF", "G_PARM", "S_PARM", "G_STD", "S_STD",
-        "ENUMSTD", "ENUMINPUT", "G_CTRL", "S_CTRL", "G_TUNER", "S_TUNER",
-        "G_FREQ", "S_FREQ", "G_AUDIO", "S_AUDIO", "35", "QUERYCTRL",
-        "QUERYMENU", "G_INPUT", "S_INPUT", "ENUMCVT", "41", "42", "43",
-        "44", "45",  "G_OUTPUT", "S_OUTPUT", "ENUMOUTPUT", "G_AUDOUT",
-        "S_AUDOUT", "ENUMFX", "G_EFFECT", "S_EFFECT", "G_MODULATOR",
-        "S_MODULATOR"
-};
-#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
-
-static const char *osspcm_ioctls[] = {
-        "RESET", "SYNC", "SPEED", "STEREO", "GETBLKSIZE", "SETFMT",
-        "CHANNELS", "?", "POST", "SUBDIVIDE", "SETFRAGMENT", "GETFMTS",
-        "GETOSPACE", "GETISPACE", "NONBLOCK", "GETCAPS", "GET/SETTRIGGER",
-        "GETIPTR", "GETOPTR", "MAPINBUF", "MAPOUTBUF", "SETSYNCRO",
-        "SETDUPLEX", "GETODELAY"
-};
-#define OSSPCM_IOCTLS ARRAY_SIZE(v4l2_ioctls)
-
-void saa7134_print_ioctl(char *name, unsigned int cmd)
-{
-        char *dir;
-
-        switch (_IOC_DIR(cmd)) {
-        case _IOC_NONE:              dir = "--"; break;
-        case _IOC_READ:              dir = "r-"; break;
-        case _IOC_WRITE:             dir = "-w"; break;
-        case _IOC_READ | _IOC_WRITE: dir = "rw"; break;
-        default:                     dir = "??"; break;
-        }
-        switch (_IOC_TYPE(cmd)) {
-        case 'v':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l1, %s, VIDIOC%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L1_IOCTLS) ?
-                       v4l1_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        case 'V':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (v4l2, %s, VIDIOC_%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < V4L2_IOCTLS) ?
-                       v4l2_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        case 'P':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (oss dsp, %s, SNDCTL_DSP_%s)\n",
-                       name, cmd, dir, (_IOC_NR(cmd) < OSSPCM_IOCTLS) ?
-                       osspcm_ioctls[_IOC_NR(cmd)] : "???");
-                break;
-        case 'M':
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (oss mixer, %s, #%d)\n",
-                       name, cmd, dir, _IOC_NR(cmd));
-                break;
-        default:
-                printk(KERN_DEBUG "%s: ioctl 0x%08x (???, %s, #%d)\n",
-                       name, cmd, dir, _IOC_NR(cmd));
-        }
-}
-
 void saa7134_track_gpio(struct saa7134_dev *dev, char *msg)
 {
         unsigned long mode,status;
@@ -211,7 +140,7 @@ static int pending_call(struct notifier_block *self, unsigned long state,
         return NOTIFY_DONE;
 }
 
-static int pending_registered;
+static int pending_registered=0;
 static struct notifier_block pending_notifier = {
         .notifier_call = pending_call,
 };
@@ -610,11 +539,38 @@ static irqreturn_t saa7134_irq(int irq, void *dev_id, struct pt_regs *regs)
                     card_has_mpeg(dev))
                         saa7134_irq_ts_done(dev,status);
 
-                if ((report & (SAA7134_IRQ_REPORT_GPIO16 |
-                               SAA7134_IRQ_REPORT_GPIO18)) &&
-                    dev->remote)
-                        saa7134_input_irq(dev);
+                if (report & SAA7134_IRQ_REPORT_GPIO16) {
+                        switch (dev->has_remote) {
+                                case SAA7134_REMOTE_GPIO:
+                                        if  (dev->remote->mask_keydown & 0x10000) {
+                                                saa7134_input_irq(dev);
+                                        }
+                                        break;
+
+                                case SAA7134_REMOTE_I2C:
+                                        break;                  /* FIXME: invoke I2C get_key() */
 
+                                default:                        /* GPIO16 not used by IR remote */
+                                        break;
+                        }
+                }
+
+                if (report & SAA7134_IRQ_REPORT_GPIO18) {
+                        switch (dev->has_remote) {
+                                case SAA7134_REMOTE_GPIO:
+                                        if ((dev->remote->mask_keydown & 0x40000) ||
+                                            (dev->remote->mask_keyup & 0x40000)) {
+                                                saa7134_input_irq(dev);
+                                        }
+                                        break;
+
+                                case SAA7134_REMOTE_I2C:
+                                        break;                  /* FIXME: invoke I2C get_key() */
+
+                                default:                        /* GPIO18 not used by IR remote */
+                                        break;
+                        }
+                }
         }
 
         if (10 == loop) {
@@ -624,13 +580,16 @@ static irqreturn_t saa7134_irq(int irq, void *dev_id, struct pt_regs *regs)
                         printk(KERN_WARNING "%s/irq: looping -- "
                                "clearing PE (parity error!) enable bit\n",dev->name);
                         saa_clearl(SAA7134_IRQ2,SAA7134_IRQ2_INTE_PE);
-                } else if (report & (SAA7134_IRQ_REPORT_GPIO16 |
-                                     SAA7134_IRQ_REPORT_GPIO18)) {
-                        /* disable gpio IRQs */
+                } else if (report & SAA7134_IRQ_REPORT_GPIO16) {
+                        /* disable gpio16 IRQ */
                         printk(KERN_WARNING "%s/irq: looping -- "
-                               "clearing GPIO enable bits\n",dev->name);
-                        saa_clearl(SAA7134_IRQ2, (SAA7134_IRQ2_INTE_GPIO16 |
-                                                  SAA7134_IRQ2_INTE_GPIO18));
+                               "clearing GPIO16 enable bit\n",dev->name);
+                        saa_clearl(SAA7134_IRQ2, SAA7134_IRQ2_INTE_GPIO16);
+                } else if (report & SAA7134_IRQ_REPORT_GPIO18) {
+                        /* disable gpio18 IRQs */
+                        printk(KERN_WARNING "%s/irq: looping -- "
+                               "clearing GPIO18 enable bit\n",dev->name);
+                        saa_clearl(SAA7134_IRQ2, SAA7134_IRQ2_INTE_GPIO18);
                 } else {
                         /* disable all irqs */
                         printk(KERN_WARNING "%s/irq: looping -- "
@@ -711,10 +670,14 @@ static int saa7134_hwinit2(struct saa7134_dev *dev)
                 SAA7134_IRQ2_INTE_PE      |
                 SAA7134_IRQ2_INTE_AR;
 
-        if (dev->has_remote == SAA7134_REMOTE_GPIO)
-                irq2_mask |= (SAA7134_IRQ2_INTE_GPIO18  |
-                              SAA7134_IRQ2_INTE_GPIO18A |
-                              SAA7134_IRQ2_INTE_GPIO16  );
+        if (dev->has_remote == SAA7134_REMOTE_GPIO) {
+                if (dev->remote->mask_keydown & 0x10000)
+                        irq2_mask |= SAA7134_IRQ2_INTE_GPIO16;
+                else if (dev->remote->mask_keydown & 0x40000)
+                        irq2_mask |= SAA7134_IRQ2_INTE_GPIO18;
+                else if (dev->remote->mask_keyup & 0x40000)
+                        irq2_mask |= SAA7134_IRQ2_INTE_GPIO18A;
+        }
 
         saa_writel(SAA7134_IRQ1, 0);
         saa_writel(SAA7134_IRQ2, irq2_mask);
@@ -1156,7 +1119,7 @@ static int saa7134_init(void)
         printk(KERN_INFO "saa7130/34: snapshot date %04d-%02d-%02d\n",
                SNAPSHOT/10000, (SNAPSHOT/100)%100, SNAPSHOT%100);
 #endif
-        return pci_module_init(&saa7134_pci_driver);
+        return pci_register_driver(&saa7134_pci_driver);
 }
 
 static void saa7134_fini(void)
@@ -1173,7 +1136,6 @@ module_exit(saa7134_fini);
 
 /* ----------------------------------------------------------- */
 
-EXPORT_SYMBOL(saa7134_print_ioctl);
 EXPORT_SYMBOL(saa7134_i2c_call_clients);
 EXPORT_SYMBOL(saa7134_devlist);
 EXPORT_SYMBOL(saa7134_boards);
diff --git a/drivers/media/video/saa7134/saa7134-dvb.c b/drivers/media/video/saa7134/saa7134-dvb.c
index e016480c3468..399f9952596c 100644
--- a/drivers/media/video/saa7134/saa7134-dvb.c
+++ b/drivers/media/video/saa7134/saa7134-dvb.c
@@ -31,6 +31,7 @@
 
 #include "saa7134-reg.h"
 #include "saa7134.h"
+#include <media/v4l2-common.h>
 
 #ifdef HAVE_MT352
 # include "mt352.h"
diff --git a/drivers/media/video/saa7134/saa7134-empress.c b/drivers/media/video/saa7134/saa7134-empress.c
index 575f3e835f91..bd4c389d4c37 100644
--- a/drivers/media/video/saa7134/saa7134-empress.c
+++ b/drivers/media/video/saa7134/saa7134-empress.c
@@ -29,6 +29,7 @@
 #include "saa7134.h"
 
 #include <media/saa6752hs.h>
+#include <media/v4l2-common.h>
 
 /* ------------------------------------------------------------------ */
 
@@ -163,7 +164,7 @@ static int ts_do_ioctl(struct inode *inode, struct file *file,
         struct saa7134_dev *dev = file->private_data;
 
         if (debug > 1)
-                saa7134_print_ioctl(dev->name,cmd);
+                v4l_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case VIDIOC_QUERYCAP:
         {
diff --git a/drivers/media/video/saa7134/saa7134-i2c.c b/drivers/media/video/saa7134/saa7134-i2c.c
index 1792d03d621d..6162550c4136 100644
--- a/drivers/media/video/saa7134/saa7134-i2c.c
+++ b/drivers/media/video/saa7134/saa7134-i2c.c
@@ -30,6 +30,7 @@
 
 #include "saa7134-reg.h"
 #include "saa7134.h"
+#include <media/v4l2-common.h>
 
 /* ----------------------------------------------------------- */
 
@@ -390,9 +391,7 @@ static struct i2c_algorithm saa7134_algo = {
 
 static struct i2c_adapter saa7134_adap_template = {
         .owner         = THIS_MODULE,
-#ifdef I2C_CLASS_TV_ANALOG
         .class         = I2C_CLASS_TV_ANALOG,
-#endif
         .name          = "saa7134",
         .id            = I2C_HW_SAA7134,
         .algo          = &saa7134_algo,
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index ab75ca5ac356..82d28cbf289f 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -56,23 +56,23 @@ static IR_KEYTAB_TYPE flyvideo_codes[IR_KEYTAB_SIZE] = {
         [   12 ] = KEY_KP8,
         [   13 ] = KEY_KP9,
 
-        [   14 ] = KEY_TUNER,        // Air/Cable
+        [   14 ] = KEY_MODE,         // Air/Cable
         [   17 ] = KEY_VIDEO,        // Video
         [   21 ] = KEY_AUDIO,        // Audio
-        [    0 ] = KEY_POWER,        // Pover
+        [    0 ] = KEY_POWER,        // Power
+        [   24 ] = KEY_TUNER,        // AV Source
         [    2 ] = KEY_ZOOM,         // Fullscreen
+        [   26 ] = KEY_LANGUAGE,     // Stereo
         [   27 ] = KEY_MUTE,         // Mute
-        [   20 ] = KEY_VOLUMEUP,
-        [   23 ] = KEY_VOLUMEDOWN,
+        [   20 ] = KEY_VOLUMEUP,     // Volume +
+        [   23 ] = KEY_VOLUMEDOWN,   // Volume -
         [   18 ] = KEY_CHANNELUP,    // Channel +
         [   19 ] = KEY_CHANNELDOWN,  // Channel -
-        [    6 ] = KEY_AGAIN,        // Recal
-        [   16 ] = KEY_KPENTER,      // Enter
-
-        [   26 ] = KEY_F22,          // Stereo
-        [   24 ] = KEY_EDIT,         // AV Source
+        [    6 ] = KEY_AGAIN,        // Recall
+        [   16 ] = KEY_ENTER,      // Enter
 };
 
+
 static IR_KEYTAB_TYPE cinergy_codes[IR_KEYTAB_SIZE] = {
         [    0 ] = KEY_KP0,
         [    1 ] = KEY_KP1,
@@ -543,12 +543,22 @@ static int build_key(struct saa7134_dev *dev)
         dprintk("build_key gpio=0x%x mask=0x%x data=%d\n",
                 gpio, ir->mask_keycode, data);
 
-        if ((ir->mask_keydown  &&  (0 != (gpio & ir->mask_keydown))) ||
-            (ir->mask_keyup    &&  (0 == (gpio & ir->mask_keyup)))) {
-                ir_input_keydown(ir->dev, &ir->ir, data, data);
-        } else {
-                ir_input_nokey(ir->dev, &ir->ir);
+        if (ir->polling) {
+                if ((ir->mask_keydown  &&  (0 != (gpio & ir->mask_keydown))) ||
+                    (ir->mask_keyup    &&  (0 == (gpio & ir->mask_keyup)))) {
+                        ir_input_keydown(ir->dev, &ir->ir, data, data);
+                } else {
+                        ir_input_nokey(ir->dev, &ir->ir);
+                }
+        }
+        else {  /* IRQ driven mode - handle key press and release in one go */
+                if ((ir->mask_keydown  &&  (0 != (gpio & ir->mask_keydown))) ||
+                    (ir->mask_keyup    &&  (0 == (gpio & ir->mask_keyup)))) {
+                        ir_input_keydown(ir->dev, &ir->ir, data, data);
+                        ir_input_nokey(ir->dev, &ir->ir);
+                }
         }
+
         return 0;
 }
 
@@ -686,6 +696,7 @@ int saa7134_input_init1(struct saa7134_dev *dev)
                 polling      = 50; // ms
                 break;
         case SAA7134_BOARD_VIDEOMATE_TV_PVR:
+        case SAA7134_BOARD_VIDEOMATE_GOLD_PLUS:
         case SAA7134_BOARD_VIDEOMATE_TV_GOLD_PLUSII:
                 ir_codes     = videomate_tv_pvr_codes;
                 mask_keycode = 0x00003F;
diff --git a/drivers/media/video/saa7134/saa7134-oss.c b/drivers/media/video/saa7134/saa7134-oss.c
index 8badd2a9cb2f..7448e386a804 100644
--- a/drivers/media/video/saa7134/saa7134-oss.c
+++ b/drivers/media/video/saa7134/saa7134-oss.c
@@ -373,6 +373,42 @@ static ssize_t dsp_write(struct file *file, const char __user *buffer,
         return -EINVAL;
 }
 
+static const char *osspcm_ioctls[] = {
+        "RESET", "SYNC", "SPEED", "STEREO", "GETBLKSIZE", "SETFMT",
+        "CHANNELS", "?", "POST", "SUBDIVIDE", "SETFRAGMENT", "GETFMTS",
+        "GETOSPACE", "GETISPACE", "NONBLOCK", "GETCAPS", "GET/SETTRIGGER",
+        "GETIPTR", "GETOPTR", "MAPINBUF", "MAPOUTBUF", "SETSYNCRO",
+        "SETDUPLEX", "GETODELAY"
+};
+#define OSSPCM_IOCTLS ARRAY_SIZE(osspcm_ioctls)
+
+static void saa7134_oss_print_ioctl(char *name, unsigned int cmd)
+{
+        char *dir;
+
+        switch (_IOC_DIR(cmd)) {
+        case _IOC_NONE:              dir = "--"; break;
+        case _IOC_READ:              dir = "r-"; break;
+        case _IOC_WRITE:             dir = "-w"; break;
+        case _IOC_READ | _IOC_WRITE: dir = "rw"; break;
+        default:                     dir = "??"; break;
+        }
+        switch (_IOC_TYPE(cmd)) {
+        case 'P':
+                printk(KERN_DEBUG "%s: ioctl 0x%08x (oss dsp, %s, SNDCTL_DSP_%s)\n",
+                       name, cmd, dir, (_IOC_NR(cmd) < OSSPCM_IOCTLS) ?
+                       osspcm_ioctls[_IOC_NR(cmd)] : "???");
+                break;
+        case 'M':
+                printk(KERN_DEBUG "%s: ioctl 0x%08x (oss mixer, %s, #%d)\n",
+                       name, cmd, dir, _IOC_NR(cmd));
+                break;
+        default:
+                printk(KERN_DEBUG "%s: ioctl 0x%08x (???, %s, #%d)\n",
+                       name, cmd, dir, _IOC_NR(cmd));
+        }
+}
+
 static int dsp_ioctl(struct inode *inode, struct file *file,
                      unsigned int cmd, unsigned long arg)
 {
@@ -382,7 +418,7 @@ static int dsp_ioctl(struct inode *inode, struct file *file,
         int val = 0;
 
         if (debug > 1)
-                saa7134_print_ioctl(dev->name,cmd);
+                saa7134_oss_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case OSS_GETVERSION:
                 return put_user(SOUND_VERSION, p);
@@ -678,7 +714,7 @@ static int mixer_ioctl(struct inode *inode, struct file *file,
         int __user *p = argp;
 
         if (debug > 1)
-                saa7134_print_ioctl(dev->name,cmd);
+                saa7134_oss_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case OSS_GETVERSION:
                 return put_user(SOUND_VERSION, p);
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index 45c852df13ed..adfa8fe49a11 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -29,6 +29,7 @@
 
 #include "saa7134-reg.h"
 #include "saa7134.h"
+#include <media/v4l2-common.h>
 
 /* Include V4L1 specific functions. Should be removed soon */
 #include <linux/videodev.h>
@@ -1689,7 +1690,7 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
         int err;
 
         if (video_debug > 1)
-                saa7134_print_ioctl(dev->name,cmd);
+                v4l_print_ioctl(dev->name,cmd);
 
         switch (cmd) {
         case VIDIOC_S_CTRL:
@@ -2142,7 +2143,7 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
         struct saa7134_dev *dev = fh->dev;
 
         if (video_debug > 1)
-                saa7134_print_ioctl(dev->name,cmd);
+                v4l_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case VIDIOC_QUERYCAP:
         {
@@ -2262,6 +2263,7 @@ static struct file_operations video_fops =
         .poll     = video_poll,
         .mmap     = video_mmap,
         .ioctl    = video_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek   = no_llseek,
 };
 
@@ -2271,6 +2273,7 @@ static struct file_operations radio_fops =
         .open     = video_open,
         .release  = video_release,
         .ioctl    = radio_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek   = no_llseek,
 };
 
diff --git a/drivers/media/video/saa7134/saa7134.h b/drivers/media/video/saa7134/saa7134.h
index add49db1ad41..e70eae8d29bb 100644
--- a/drivers/media/video/saa7134/saa7134.h
+++ b/drivers/media/video/saa7134/saa7134.h
@@ -37,6 +37,9 @@
 #include <media/ir-common.h>
 #include <media/ir-kbd-i2c.h>
 #include <media/video-buf.h>
+#include <sound/driver.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
 #include <media/video-buf-dvb.h>
 
 #ifndef TRUE
@@ -47,10 +50,6 @@
 #endif
 #define UNSET (-1U)
 
-#include <sound/driver.h>
-#include <sound/core.h>
-#include <sound/pcm.h>
-
 /* ----------------------------------------------------------- */
 /* enums                                                       */
 
@@ -209,6 +208,8 @@ struct saa7134_format {
 #define SAA7134_BOARD_ASUSTEK_DIGIMATRIX_TV 80
 #define SAA7134_BOARD_PHILIPS_TIGER  81
 #define SAA7134_BOARD_MSI_TVATANYWHERE_PLUS  82
+#define SAA7134_BOARD_CINERGY250PCI 83
+#define SAA7134_BOARD_FLYDVB_TRIO 84
 
 #define SAA7134_MAXBOARDS 8
 #define SAA7134_INPUT_MAX 8
@@ -546,7 +547,6 @@ struct saa7134_dev {
 
 extern struct list_head  saa7134_devlist;
 
-void saa7134_print_ioctl(char *name, unsigned int cmd);
 void saa7134_track_gpio(struct saa7134_dev *dev, char *msg);
 
 #define SAA7134_PGTABLE_SIZE 4096
diff --git a/drivers/media/video/stradis.c b/drivers/media/video/stradis.c
index d4497dbae05c..6ee54a45411f 100644
--- a/drivers/media/video/stradis.c
+++ b/drivers/media/video/stradis.c
@@ -1974,6 +1974,7 @@ static struct file_operations saa_fops =
         .open           = saa_open,
         .release        = saa_release,
         .ioctl          = saa_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .read           = saa_read,
         .llseek         = no_llseek,
         .write          = saa_write,
diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
index 549c9929f107..99261f15e66e 100644
--- a/drivers/media/video/tda7432.c
+++ b/drivers/media/video/tda7432.c
@@ -50,6 +50,7 @@
 
 #include "bttv.h"
 #include <media/audiochip.h>
+#include <media/v4l2-common.h>
 
 #ifndef VIDEO_AUDIO_BALANCE
 # define VIDEO_AUDIO_BALANCE 32
@@ -90,9 +91,6 @@ struct tda7432 {
 static struct i2c_driver driver;
 static struct i2c_client client_template;
 
-#define dprintk  if (debug) printk
-#define d2printk if (debug > 1) printk
-
 /* The TDA7432 is made by STS-Thompson
  * http://www.st.com
  * http://us.st.com/stonline/books/pdf/docs/4056.pdf
@@ -229,12 +227,12 @@ static struct i2c_client client_template;
 static int tda7432_write(struct i2c_client *client, int subaddr, int val)
 {
         unsigned char buffer[2];
-        d2printk("tda7432: In tda7432_write\n");
-        dprintk("tda7432: Writing %d 0x%x\n", subaddr, val);
+        v4l_dbg(2,client,"In tda7432_write\n");
+        v4l_dbg(1,client,"Writing %d 0x%x\n", subaddr, val);
         buffer[0] = subaddr;
         buffer[1] = val;
         if (2 != i2c_master_send(client,buffer,2)) {
-                printk(KERN_WARNING "tda7432: I/O error, trying (write %d 0x%x)\n",
+                v4l_err(client,"I/O error, trying (write %d 0x%x)\n",
                        subaddr, val);
                 return -1;
         }
@@ -247,9 +245,9 @@ static int tda7432_set(struct i2c_client *client)
 {
         struct tda7432 *t = i2c_get_clientdata(client);
         unsigned char buf[16];
-        d2printk("tda7432: In tda7432_set\n");
+        v4l_dbg(2,client,"In tda7432_set\n");
 
-        dprintk(KERN_INFO
+        v4l_dbg(1,client,
                 "tda7432: 7432_set(0x%02x,0x%02x,0x%02x,0x%02x,0x%02x,0x%02x,0x%02x,0x%02x,0x%02x)\n",
                 t->input,t->volume,t->bass,t->treble,t->lf,t->lr,t->rf,t->rr,t->loud);
         buf[0]  = TDA7432_IN;
@@ -263,7 +261,7 @@ static int tda7432_set(struct i2c_client *client)
         buf[8]  = t->rr;
         buf[9]  = t->loud;
         if (10 != i2c_master_send(client,buf,10)) {
-                printk(KERN_WARNING "tda7432: I/O error, trying tda7432_set\n");
+                v4l_err(client,"I/O error, trying tda7432_set\n");
                 return -1;
         }
 
@@ -273,7 +271,7 @@ static int tda7432_set(struct i2c_client *client)
 static void do_tda7432_init(struct i2c_client *client)
 {
         struct tda7432 *t = i2c_get_clientdata(client);
-        d2printk("tda7432: In tda7432_init\n");
+        v4l_dbg(2,client,"In tda7432_init\n");
 
         t->input  = TDA7432_STEREO_IN |  /* Main (stereo) input   */
                     TDA7432_BASS_SYM  |  /* Symmetric bass cut    */
@@ -301,7 +299,6 @@ static int tda7432_attach(struct i2c_adapter *adap, int addr, int kind)
 {
         struct tda7432 *t;
         struct i2c_client *client;
-        d2printk("tda7432: In tda7432_attach\n");
 
         t = kmalloc(sizeof *t,GFP_KERNEL);
         if (!t)
@@ -315,21 +312,16 @@ static int tda7432_attach(struct i2c_adapter *adap, int addr, int kind)
         i2c_set_clientdata(client, t);
 
         do_tda7432_init(client);
-        printk(KERN_INFO "tda7432: init\n");
-
         i2c_attach_client(client);
+
+        v4l_info(client, "chip found @ 0x%x (%s)\n", addr << 1, adap->name);
         return 0;
 }
 
 static int tda7432_probe(struct i2c_adapter *adap)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, tda7432_attach);
-#else
-        if (adap->id == I2C_HW_B_BT848)
-                return i2c_probe(adap, &addr_data, tda7432_attach);
-#endif
         return 0;
 }
 
@@ -348,7 +340,9 @@ static int tda7432_command(struct i2c_client *client,
                            unsigned int cmd, void *arg)
 {
         struct tda7432 *t = i2c_get_clientdata(client);
-        d2printk("tda7432: In tda7432_command\n");
+        v4l_dbg(2,client,"In tda7432_command\n");
+        if (debug>1)
+                v4l_i2c_print_ioctl(client,cmd);
 
         switch (cmd) {
         /* --- v4l ioctls --- */
@@ -359,7 +353,6 @@ static int tda7432_command(struct i2c_client *client,
         case VIDIOCGAUDIO:
         {
                 struct video_audio *va = arg;
-                dprintk("tda7432: VIDIOCGAUDIO\n");
 
                 va->flags |= VIDEO_AUDIO_VOLUME |
                         VIDEO_AUDIO_BASS |
@@ -414,7 +407,6 @@ static int tda7432_command(struct i2c_client *client,
         case VIDIOCSAUDIO:
         {
                 struct video_audio *va = arg;
-                dprintk("tda7432: VIDEOCSAUDIO\n");
 
                 if(va->flags & VIDEO_AUDIO_VOLUME){
                         if(!maxvol){ /* max +20db */
@@ -490,11 +482,6 @@ static int tda7432_command(struct i2c_client *client,
 
         } /* end of VIDEOCSAUDIO case */
 
-        default: /* Not VIDEOCGAUDIO or VIDEOCSAUDIO */
-
-                /* nothing */
-                d2printk("tda7432: Default\n");
-
         } /* end of (cmd) switch */
 
         return 0;
@@ -502,7 +489,7 @@ static int tda7432_command(struct i2c_client *client,
 
 static struct i2c_driver driver = {
         .driver = {
-                .name    = "i2c tda7432 driver",
+                .name    = "tda7432",
         },
         .id              = I2C_DRIVERID_TDA7432,
         .attach_adapter  = tda7432_probe,
@@ -519,7 +506,7 @@ static struct i2c_client client_template =
 static int __init tda7432_init(void)
 {
         if ( (loudness < 0) || (loudness > 15) ) {
-                printk(KERN_ERR "tda7432: loudness parameter must be between 0 and 15\n");
+                printk(KERN_ERR "loudness parameter must be between 0 and 15\n");
                 return -EINVAL;
         }
 
diff --git a/drivers/media/video/tda8290.c b/drivers/media/video/tda8290.c
index 61d94ddaff41..2498b76df429 100644
--- a/drivers/media/video/tda8290.c
+++ b/drivers/media/video/tda8290.c
@@ -398,14 +398,8 @@ static int tda8290_tune(struct i2c_client *c, u16 ifc, unsigned int freq)
         return 0;
 }
 
-
 /*---------------------------------------------------------------------*/
 
-#define V4L2_STD_MN     (V4L2_STD_PAL_M|V4L2_STD_PAL_N|V4L2_STD_PAL_Nc|V4L2_STD_NTSC)
-#define V4L2_STD_B      (V4L2_STD_PAL_B|V4L2_STD_PAL_B1|V4L2_STD_SECAM_B)
-#define V4L2_STD_GH     (V4L2_STD_PAL_G|V4L2_STD_PAL_H|V4L2_STD_SECAM_G|V4L2_STD_SECAM_H)
-#define V4L2_STD_DK     (V4L2_STD_PAL_DK|V4L2_STD_SECAM_DK)
-
 static void set_audio(struct tuner *t)
 {
         char* mode;
diff --git a/drivers/media/video/tda9875.c b/drivers/media/video/tda9875.c
index 9c3ecf7a0fed..299393bf900a 100644
--- a/drivers/media/video/tda9875.c
+++ b/drivers/media/video/tda9875.c
@@ -257,13 +257,8 @@ static int tda9875_attach(struct i2c_adapter *adap, int addr, int kind)
 
 static int tda9875_probe(struct i2c_adapter *adap)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, tda9875_attach);
-#else
-        if (adap->id == I2C_HW_B_BT848)
-                return i2c_probe(adap, &addr_data, tda9875_attach);
-#endif
         return 0;
 }
 
@@ -373,7 +368,7 @@ static int tda9875_command(struct i2c_client *client,
 
 static struct i2c_driver driver = {
         .driver = {
-                .name   = "i2c tda9875 driver",
+                .name   = "tda9875",
         },
         .id             = I2C_DRIVERID_TDA9875,
         .attach_adapter = tda9875_probe,
diff --git a/drivers/media/video/tda9887.c b/drivers/media/video/tda9887.c
index 7165a1b9625a..9cf47dc65579 100644
--- a/drivers/media/video/tda9887.c
+++ b/drivers/media/video/tda9887.c
@@ -9,7 +9,7 @@
 #include <linux/slab.h>
 #include <linux/delay.h>
 
-#include <media/audiochip.h>
+#include <media/v4l2-common.h>
 #include <media/tuner.h>
 
 
@@ -57,7 +57,6 @@ struct tda9887 {
         v4l2_std_id        std;
         enum tuner_mode    mode;
         unsigned int       config;
-        unsigned int       pinnacle_id;
         unsigned int       using_v4l2;
         unsigned int       radio_mode;
         unsigned char      data[4];
@@ -115,6 +114,9 @@ static struct i2c_client client_template;
 #define cAudioGain0             0x00    // bit c7
 #define cAudioGain6             0x80    // bit c7
 
+#define cTopMask                0x1f    // bit c0:4
+#define cTopPalSecamDefault     0x14    // bit c0:4
+#define cTopNtscRadioDefault    0x10    // bit c0:4
 
 //// third reg (e)
 #define cAudioIF_4_5             0x00    // bit e0:1
@@ -146,13 +148,15 @@ static struct i2c_client client_template;
 
 static struct tvnorm tvnorms[] = {
         {
-                .std   = V4L2_STD_PAL_BG,
-                .name  = "PAL-BG",
+                .std   = V4L2_STD_PAL_BG | V4L2_STD_PAL_H | V4L2_STD_PAL_N,
+                .name  = "PAL-BGHN",
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis50  ),
-                .e     = ( cAudioIF_5_5   |
+                           cDeemphasis50  |
+                           cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_5_5   |
                            cVideoIF_38_90 ),
         },{
                 .std   = V4L2_STD_PAL_I,
@@ -160,8 +164,10 @@ static struct tvnorm tvnorms[] = {
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis50  ),
-                .e     = ( cAudioIF_6_0   |
+                           cDeemphasis50  |
+                           cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_6_0   |
                            cVideoIF_38_90 ),
         },{
                 .std   = V4L2_STD_PAL_DK,
@@ -169,52 +175,80 @@ static struct tvnorm tvnorms[] = {
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis50  ),
-                .e     = ( cAudioIF_6_5   |
-                           cVideoIF_38_00 ),
+                           cDeemphasis50  |
+                           cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_6_5   |
+                           cVideoIF_38_90 ),
         },{
-                .std   = V4L2_STD_PAL_M | V4L2_STD_PAL_N,
-                .name  = "PAL-M/N",
+                .std   = V4L2_STD_PAL_M | V4L2_STD_PAL_Nc,
+                .name  = "PAL-M/Nc",
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis75  ),
-                .e     = ( cAudioIF_4_5   |
+                           cDeemphasis75  |
+                           cTopNtscRadioDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_4_5   |
                            cVideoIF_45_75 ),
         },{
+                .std   = V4L2_STD_SECAM_B | V4L2_STD_SECAM_G | V4L2_STD_SECAM_H,
+                .name  = "SECAM-BGH",
+                .b     = ( cPositiveAmTV  |
+                           cQSS           ),
+                .c     = ( cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_5_5   |
+                           cVideoIF_38_90 ),
+        },{
                 .std   = V4L2_STD_SECAM_L,
                 .name  = "SECAM-L",
                 .b     = ( cPositiveAmTV  |
                            cQSS           ),
+                .c     = ( cTopPalSecamDefault),
                 .e     = ( cGating_36     |
                            cAudioIF_6_5   |
                            cVideoIF_38_90 ),
         },{
+                .std   = V4L2_STD_SECAM_LC,
+                .name  = "SECAM-L'",
+                .b     = ( cOutputPort2Inactive |
+                           cPositiveAmTV  |
+                           cQSS           ),
+                .c     = ( cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_6_5   |
+                           cVideoIF_33_90 ),
+        },{
                 .std   = V4L2_STD_SECAM_DK,
                 .name  = "SECAM-DK",
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis50  ),
-                .e     = ( cAudioIF_6_5   |
-                           cVideoIF_38_00 ),
+                           cDeemphasis50  |
+                           cTopPalSecamDefault),
+                .e     = ( cGating_36     |
+                           cAudioIF_6_5   |
+                           cVideoIF_38_90 ),
         },{
                 .std   = V4L2_STD_NTSC_M,
                 .name  = "NTSC-M",
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis75  ),
+                           cDeemphasis75  |
+                           cTopNtscRadioDefault),
                 .e     = ( cGating_36     |
                            cAudioIF_4_5   |
                            cVideoIF_45_75 ),
         },{
                 .std   = V4L2_STD_NTSC_M_JP,
-                .name  = "NTSC-JP",
+                .name  = "NTSC-M-JP",
                 .b     = ( cNegativeFmTV  |
                            cQSS           ),
                 .c     = ( cDeemphasisON  |
-                           cDeemphasis50  ),
+                           cDeemphasis50  |
+                           cTopNtscRadioDefault),
                 .e     = ( cGating_36     |
                            cAudioIF_4_5   |
                            cVideoIF_58_75 ),
@@ -226,8 +260,10 @@ static struct tvnorm radio_stereo = {
         .b    = ( cFmRadio       |
                   cQSS           ),
         .c    = ( cDeemphasisOFF |
-                  cAudioGain6 ),
-        .e    = ( cAudioIF_5_5   |
+                  cAudioGain6    |
+                  cTopNtscRadioDefault),
+        .e    = ( cTunerGainLow  |
+                  cAudioIF_5_5   |
                   cRadioIF_38_90 ),
 };
 
@@ -236,8 +272,10 @@ static struct tvnorm radio_mono = {
         .b    = ( cFmRadio       |
                   cQSS           ),
         .c    = ( cDeemphasisON  |
-                  cDeemphasis50),
-        .e    = ( cAudioIF_5_5   |
+                  cDeemphasis75  |
+                  cTopNtscRadioDefault),
+        .e    = ( cTunerGainLow  |
+                  cAudioIF_5_5   |
                   cRadioIF_38_90 ),
 };
 
@@ -400,7 +438,8 @@ static int tda9887_set_tvnorm(struct tda9887 *t, char *buf)
 static unsigned int port1  = UNSET;
 static unsigned int port2  = UNSET;
 static unsigned int qss    = UNSET;
-static unsigned int adjust = 0x10;
+static unsigned int adjust = UNSET;
+
 module_param(port1, int, 0644);
 module_param(port2, int, 0644);
 module_param(qss, int, 0644);
@@ -428,8 +467,10 @@ static int tda9887_set_insmod(struct tda9887 *t, char *buf)
                         buf[1] &= ~cQSS;
         }
 
-        if (adjust >= 0x00 && adjust < 0x20)
+        if (adjust >= 0x00 && adjust < 0x20) {
+                buf[2] &= ~cTopMask;
                 buf[2] |= adjust;
+        }
         return 0;
 }
 
@@ -465,6 +506,10 @@ static int tda9887_set_config(struct tda9887 *t, char *buf)
                         break;
                 }
         }
+        if (t->config & TDA9887_TOP_SET) {
+                buf[2] &= ~cTopMask;
+                buf[2] |= (t->config >> 8) & cTopMask;
+        }
         if ((t->config & TDA9887_INTERCARRIER_NTSC) && (t->std & V4L2_STD_NTSC))
                 buf[1] &= ~cQSS;
         return 0;
@@ -472,38 +517,13 @@ static int tda9887_set_config(struct tda9887 *t, char *buf)
 
 /* ---------------------------------------------------------------------- */
 
-static int tda9887_set_pinnacle(struct tda9887 *t, char *buf)
-{
-        unsigned int bCarrierMode = UNSET;
-
-        if (t->std & V4L2_STD_625_50) {
-                if ((1 == t->pinnacle_id) || (7 == t->pinnacle_id)) {
-                        bCarrierMode = cIntercarrier;
-                } else {
-                        bCarrierMode = cQSS;
-                }
-        }
-        if (t->std & V4L2_STD_525_60) {
-                if ((5 == t->pinnacle_id) || (6 == t->pinnacle_id)) {
-                        bCarrierMode = cIntercarrier;
-                } else {
-                        bCarrierMode = cQSS;
-                }
-        }
-
-        if (bCarrierMode != UNSET) {
-                buf[1] &= ~0x04;
-                buf[1] |= bCarrierMode;
-        }
-        return 0;
-}
-
-/* ---------------------------------------------------------------------- */
+static char pal[] = "--";
+static char secam[] = "--";
+static char ntsc[] = "-";
 
-static char pal[] = "-";
 module_param_string(pal, pal, sizeof(pal), 0644);
-static char secam[] = "-";
 module_param_string(secam, secam, sizeof(secam), 0644);
+module_param_string(ntsc, ntsc, sizeof(ntsc), 0644);
 
 static int tda9887_fixup_std(struct tda9887 *t)
 {
@@ -514,8 +534,17 @@ static int tda9887_fixup_std(struct tda9887 *t)
                 case 'B':
                 case 'g':
                 case 'G':
-                        tda9887_dbg("insmod fixup: PAL => PAL-BG\n");
-                        t->std = V4L2_STD_PAL_BG;
+                case 'h':
+                case 'H':
+                case 'n':
+                case 'N':
+                        if (pal[1] == 'c' || pal[1] == 'C') {
+                                tda9887_dbg("insmod fixup: PAL => PAL-Nc\n");
+                                t->std = V4L2_STD_PAL_Nc;
+                        } else {
+                                tda9887_dbg("insmod fixup: PAL => PAL-BGHN\n");
+                                t->std = V4L2_STD_PAL_BG | V4L2_STD_PAL_H | V4L2_STD_PAL_N;
+                        }
                         break;
                 case 'i':
                 case 'I':
@@ -529,6 +558,11 @@ static int tda9887_fixup_std(struct tda9887 *t)
                         tda9887_dbg("insmod fixup: PAL => PAL-DK\n");
                         t->std = V4L2_STD_PAL_DK;
                         break;
+                case 'm':
+                case 'M':
+                        tda9887_dbg("insmod fixup: PAL => PAL-M\n");
+                        t->std = V4L2_STD_PAL_M;
+                        break;
                 case '-':
                         /* default parameter, do nothing */
                         break;
@@ -539,6 +573,15 @@ static int tda9887_fixup_std(struct tda9887 *t)
         }
         if ((t->std & V4L2_STD_SECAM) == V4L2_STD_SECAM) {
                 switch (secam[0]) {
+                case 'b':
+                case 'B':
+                case 'g':
+                case 'G':
+                case 'h':
+                case 'H':
+                        tda9887_dbg("insmod fixup: SECAM => SECAM-BGH\n");
+                        t->std = V4L2_STD_SECAM_B | V4L2_STD_SECAM_G | V4L2_STD_SECAM_H;
+                        break;
                 case 'd':
                 case 'D':
                 case 'k':
@@ -548,8 +591,13 @@ static int tda9887_fixup_std(struct tda9887 *t)
                         break;
                 case 'l':
                 case 'L':
-                        tda9887_dbg("insmod fixup: SECAM => SECAM-L\n");
-                        t->std = V4L2_STD_SECAM_L;
+                        if (secam[1] == 'c' || secam[1] == 'C') {
+                                tda9887_dbg("insmod fixup: SECAM => SECAM-L'\n");
+                                t->std = V4L2_STD_SECAM_LC;
+                        } else {
+                                tda9887_dbg("insmod fixup: SECAM => SECAM-L\n");
+                                t->std = V4L2_STD_SECAM_L;
+                        }
                         break;
                 case '-':
                         /* default parameter, do nothing */
@@ -559,6 +607,26 @@ static int tda9887_fixup_std(struct tda9887 *t)
                         break;
                 }
         }
+        if ((t->std & V4L2_STD_NTSC) == V4L2_STD_NTSC) {
+                switch (ntsc[0]) {
+                case 'm':
+                case 'M':
+                        tda9887_dbg("insmod fixup: NTSC => NTSC-M\n");
+                        t->std = V4L2_STD_NTSC_M;
+                        break;
+                case 'j':
+                case 'J':
+                        tda9887_dbg("insmod fixup: NTSC => NTSC_M_JP\n");
+                        t->std = V4L2_STD_NTSC_M_JP;
+                        break;
+                case '-':
+                        /* default parameter, do nothing */
+                        break;
+                default:
+                        tda9887_info("ntsc= argument not recognised\n");
+                        break;
+                }
+        }
         return 0;
 }
 
@@ -581,12 +649,22 @@ static int tda9887_configure(struct tda9887 *t)
         memset(t->data,0,sizeof(t->data));
         tda9887_set_tvnorm(t,t->data);
 
+        /* A note on the port settings:
+           These settings tend to depend on the specifics of the board.
+           By default they are set to inactive (bit value 1) by this driver,
+           overwriting any changes made by the tvnorm. This means that it
+           is the responsibility of the module using the tda9887 to set
+           these values in case of changes in the tvnorm.
+           In many cases port 2 should be made active (0) when selecting
+           SECAM-L, and port 2 should remain inactive (1) for SECAM-L'.
+
+           For the other standards the tda9887 application note says that
+           the ports should be set to active (0), but, again, that may
+           differ depending on the precise hardware configuration.
+         */
         t->data[1] |= cOutputPort1Inactive;
         t->data[1] |= cOutputPort2Inactive;
 
-        if (UNSET != t->pinnacle_id) {
-                tda9887_set_pinnacle(t,t->data);
-        }
         tda9887_set_config(t,t->data);
         tda9887_set_insmod(t,t->data);
 
@@ -594,7 +672,6 @@ static int tda9887_configure(struct tda9887 *t)
                 t->data[1] |= cForcedMuteAudioON;
         }
 
-
         tda9887_dbg("writing: b=0x%02x c=0x%02x e=0x%02x\n",
                 t->data[1],t->data[2],t->data[3]);
         if (debug > 1)
@@ -625,7 +702,6 @@ static int tda9887_attach(struct i2c_adapter *adap, int addr, int kind)
 
         t->client      = client_template;
         t->std         = 0;
-        t->pinnacle_id = UNSET;
         t->radio_mode = V4L2_TUNER_MODE_STEREO;
 
         tda9887_info("chip found @ 0x%x (%s)\n", addr<<1, adap->name);
@@ -638,18 +714,8 @@ static int tda9887_attach(struct i2c_adapter *adap, int addr, int kind)
 
 static int tda9887_probe(struct i2c_adapter *adap)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, tda9887_attach);
-#else
-        switch (adap->id) {
-        case I2C_HW_B_BT848:
-        case I2C_HW_B_RIVA:
-        case I2C_HW_SAA7134:
-                return i2c_probe(adap, &addr_data, tda9887_attach);
-                break;
-        }
-#endif
         return 0;
 }
 
@@ -689,14 +755,6 @@ tda9887_command(struct i2c_client *client, unsigned int cmd, void *arg)
                 tda9887_configure(t);
                 break;
         }
-        case AUDC_CONFIG_PINNACLE:
-        {
-                int *i = arg;
-
-                t->pinnacle_id = *i;
-                tda9887_configure(t);
-                break;
-        }
         case TDA9887_SET_CONFIG:
         {
                 int *i = arg;
@@ -787,7 +845,7 @@ tda9887_command(struct i2c_client *client, unsigned int cmd, void *arg)
         }
         case VIDIOC_LOG_STATUS:
         {
-                tda9887_info("Data bytes: b=%02x c=%02x e=%02x\n", t->data[1], t->data[2], t->data[3]);
+                tda9887_info("Data bytes: b=0x%02x c=0x%02x e=0x%02x\n", t->data[1], t->data[2], t->data[3]);
                 break;
         }
         default:
@@ -824,7 +882,7 @@ static struct i2c_driver driver = {
         .detach_client  = tda9887_detach,
         .command        = tda9887_command,
         .driver = {
-                .name    = "i2c tda9887 driver",
+                .name    = "tda9887",
                 .suspend = tda9887_suspend,
                 .resume  = tda9887_resume,
         },
diff --git a/drivers/media/video/tea5767.c b/drivers/media/video/tea5767.c
index a9375ef05de1..261b7a3c0417 100644
--- a/drivers/media/video/tea5767.c
+++ b/drivers/media/video/tea5767.c
@@ -17,6 +17,9 @@
 
 #define PREFIX "TEA5767 "
 
+/* from tuner-core.c */
+extern int debug;
+
 /*****************************************************************************/
 
 /******************************
@@ -246,7 +249,7 @@ static void set_radio_freq(struct i2c_client *c, unsigned int frq)
         if (5 != (rc = i2c_master_send(c, buffer, 5)))
                 tuner_warn("i2c i/o error: rc == %d (should be 5)\n", rc);
 
-        if (tuner_debug) {
+        if (debug) {
                 if (5 != (rc = i2c_master_recv(c, buffer, 5)))
                         tuner_warn("i2c i/o error: rc == %d (should be 5)\n", rc);
                 else
@@ -264,7 +267,7 @@ static int tea5767_signal(struct i2c_client *c)
         if (5 != (rc = i2c_master_recv(c, buffer, 5)))
                 tuner_warn("i2c i/o error: rc == %d (should be 5)\n", rc);
 
-        return ((buffer[3] & TEA5767_ADC_LEVEL_MASK) << (13 - 4));
+        return ((buffer[3] & TEA5767_ADC_LEVEL_MASK) << 8);
 }
 
 static int tea5767_stereo(struct i2c_client *c)
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index c13c7b95ef35..57bc585a6955 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -20,10 +20,9 @@
 #include <linux/init.h>
 
 #include <media/tuner.h>
+#include <media/v4l2-common.h>
 #include <media/audiochip.h>
 
-#include "msp3400.h"
-
 #define UNSET (-1U)
 
 /* standard i2c insmod options */
@@ -38,21 +37,30 @@ I2C_CLIENT_INSMOD;
 
 /* insmod options used at init time => read/only */
 static unsigned int addr = 0;
-module_param(addr, int, 0444);
-
 static unsigned int no_autodetect = 0;
-module_param(no_autodetect, int, 0444);
-
 static unsigned int show_i2c = 0;
-module_param(show_i2c, int, 0444);
 
 /* insmod options used at runtime => read/write */
-unsigned int tuner_debug = 0;
-module_param(tuner_debug, int, 0644);
+static unsigned int tuner_debug = 0;
+int debug = 0;
 
 static unsigned int tv_range[2] = { 44, 958 };
 static unsigned int radio_range[2] = { 65, 108 };
 
+static char pal[] = "--";
+static char secam[] = "--";
+static char ntsc[] = "-";
+
+module_param(addr, int, 0444);
+module_param(no_autodetect, int, 0444);
+module_param(show_i2c, int, 0444);
+/* Note: tuner_debug is deprecated and will be removed in 2.6.17 */
+module_param(tuner_debug, int, 0444);
+module_param(debug, int, 0644);
+
+module_param_string(pal, pal, sizeof(pal), 0644);
+module_param_string(secam, secam, sizeof(secam), 0644);
+module_param_string(ntsc, ntsc, sizeof(ntsc), 0644);
 module_param_array(tv_range, int, NULL, 0644);
 module_param_array(radio_range, int, NULL, 0644);
 
@@ -249,11 +257,6 @@ static inline int check_mode(struct tuner *t, char *cmd)
         return 0;
 }
 
-static char pal[] = "-";
-module_param_string(pal, pal, sizeof(pal), 0644);
-static char secam[] = "--";
-module_param_string(secam, secam, sizeof(secam), 0644);
-
 /* get more precise norm info from insmod option */
 static int tuner_fixup_std(struct tuner *t)
 {
@@ -285,8 +288,13 @@ static int tuner_fixup_std(struct tuner *t)
                         break;
                 case 'N':
                 case 'n':
-                        tuner_dbg ("insmod fixup: PAL => PAL-N\n");
-                        t->std = V4L2_STD_PAL_N;
+                        if (pal[1] == 'c' || pal[1] == 'C') {
+                                tuner_dbg("insmod fixup: PAL => PAL-Nc\n");
+                                t->std = V4L2_STD_PAL_Nc;
+                        } else {
+                                tuner_dbg ("insmod fixup: PAL => PAL-N\n");
+                                t->std = V4L2_STD_PAL_N;
+                        }
                         break;
                 case '-':
                         /* default parameter, do nothing */
@@ -298,6 +306,15 @@ static int tuner_fixup_std(struct tuner *t)
         }
         if ((t->std & V4L2_STD_SECAM) == V4L2_STD_SECAM) {
                 switch (secam[0]) {
+                case 'b':
+                case 'B':
+                case 'g':
+                case 'G':
+                case 'h':
+                case 'H':
+                        tuner_dbg("insmod fixup: SECAM => SECAM-BGH\n");
+                        t->std = V4L2_STD_SECAM_B | V4L2_STD_SECAM_G | V4L2_STD_SECAM_H;
+                        break;
                 case 'd':
                 case 'D':
                 case 'k':
@@ -324,9 +341,60 @@ static int tuner_fixup_std(struct tuner *t)
                 }
         }
 
+        if ((t->std & V4L2_STD_NTSC) == V4L2_STD_NTSC) {
+                switch (ntsc[0]) {
+                case 'm':
+                case 'M':
+                        tuner_dbg("insmod fixup: NTSC => NTSC-M\n");
+                        t->std = V4L2_STD_NTSC_M;
+                        break;
+                case 'j':
+                case 'J':
+                        tuner_dbg("insmod fixup: NTSC => NTSC_M_JP\n");
+                        t->std = V4L2_STD_NTSC_M_JP;
+                        break;
+                case '-':
+                        /* default parameter, do nothing */
+                        break;
+                default:
+                        tuner_info("ntsc= argument not recognised\n");
+                        break;
+                }
+        }
         return 0;
 }
 
+static void tuner_status(struct i2c_client *client)
+{
+        struct tuner *t = i2c_get_clientdata(client);
+        unsigned long freq, freq_fraction;
+        const char *p;
+
+        switch (t->mode) {
+                case V4L2_TUNER_RADIO:      p = "radio"; break;
+                case V4L2_TUNER_ANALOG_TV:  p = "analog TV"; break;
+                case V4L2_TUNER_DIGITAL_TV: p = "digital TV"; break;
+                default: p = "undefined"; break;
+        }
+        if (t->mode == V4L2_TUNER_RADIO) {
+                freq = t->freq / 16000;
+                freq_fraction = (t->freq % 16000) * 100 / 16000;
+        } else {
+                freq = t->freq / 16;
+                freq_fraction = (t->freq % 16) * 100 / 16;
+        }
+        tuner_info("Tuner mode:      %s\n", p);
+        tuner_info("Frequency:       %lu.%02lu MHz\n", freq, freq_fraction);
+        tuner_info("Standard:        0x%08llx\n", t->std);
+        if (t->mode == V4L2_TUNER_RADIO) {
+                if (t->has_signal) {
+                        tuner_info("Signal strength: %d\n", t->has_signal(client));
+                }
+                if (t->is_stereo) {
+                        tuner_info("Stereo:          %s\n", t->is_stereo(client) ? "yes" : "no");
+                }
+        }
+}
 /* ---------------------------------------------------------------------- */
 
 /* static var Used only in tuner_attach and tuner_probe */
@@ -352,6 +420,11 @@ static int tuner_attach(struct i2c_adapter *adap, int addr, int kind)
         t->radio_if2 = 10700 * 1000;    /* 10.7MHz - FM radio */
         t->audmode = V4L2_TUNER_MODE_STEREO;
         t->mode_mask = T_UNINITIALIZED;
+        if (tuner_debug) {
+                debug = tuner_debug;
+                printk(KERN_ERR "tuner: tuner_debug is deprecated and will be removed in 2.6.17.\n");
+                printk(KERN_ERR "tuner: use the debug option instead.\n");
+        }
 
         if (show_i2c) {
                 unsigned char buffer[16];
@@ -478,7 +551,9 @@ static inline int check_v4l2(struct tuner *t)
 static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
 {
         struct tuner *t = i2c_get_clientdata(client);
-        unsigned int *iarg = (int *)arg;
+
+        if (debug>1)
+                v4l_i2c_print_ioctl(&(t->i2c),cmd);
 
         switch (cmd) {
         /* --- configuration --- */
@@ -501,18 +576,6 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
                                 t->standby (client);
                         break;
                 }
-        case AUDC_CONFIG_PINNACLE:
-                switch (*iarg) {
-                case 2:
-                        tuner_dbg("pinnacle pal\n");
-                        t->radio_if2 = 33300 * 1000;
-                        break;
-                case 3:
-                        tuner_dbg("pinnacle ntsc\n");
-                        t->radio_if2 = 41300 * 1000;
-                        break;
-                }
-                break;
         case VIDIOCSAUDIO:
                 if (check_mode(t, "VIDIOCSAUDIO") == EINVAL)
                         return 0;
@@ -523,9 +586,6 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
                 tuner_dbg("VIDIOCSAUDIO not implemented.\n");
 
                 break;
-        case MSP_SET_MATRIX:
-        case TDA9887_SET_CONFIG:
-                break;
         /* --- v4l ioctls --- */
         /* take care: bttv does userspace copying, we'll get a
            kernel pointer here... */
@@ -708,10 +768,8 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
                         }
                         break;
                 }
-        default:
-                tuner_dbg("Unimplemented IOCTL 0x%08x(dir=%d,tp='%c',nr=%d,sz=%d)\n",
-                                         cmd, _IOC_DIR(cmd), _IOC_TYPE(cmd),
-                                        _IOC_NR(cmd), _IOC_SIZE(cmd));
+        case VIDIOC_LOG_STATUS:
+                tuner_status(client);
                 break;
         }
 
@@ -747,10 +805,10 @@ static struct i2c_driver driver = {
         .detach_client = tuner_detach,
         .command = tuner_command,
         .driver = {
-                   .name = "tuner",
-                   .suspend = tuner_suspend,
-                   .resume = tuner_resume,
-                   },
+                .name    = "tuner",
+                .suspend = tuner_suspend,
+                .resume  = tuner_resume,
+        },
 };
 static struct i2c_client client_template = {
         .name = "(tuner unset)",
diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c
index e0c9fdb9914a..e5fb74365836 100644
--- a/drivers/media/video/tuner-simple.c
+++ b/drivers/media/video/tuner-simple.c
@@ -8,6 +8,10 @@
 #include <linux/videodev.h>
 #include <media/tuner.h>
 
+static int offset = 0;
+module_param(offset, int, 0666);
+MODULE_PARM_DESC(offset,"Allows to specify an offset for tuner");
+
 /* ---------------------------------------------------------------------- */
 
 /* tv standard selection for Temic 4046 FM5
@@ -75,24 +79,20 @@
 #define TUNER_PLL_LOCKED   0x40
 #define TUNER_STEREO_MK3   0x04
 
+#define TUNER_MAX_RANGES   3
+
 /* ---------------------------------------------------------------------- */
 
 struct tunertype
 {
         char *name;
-        unsigned char Vendor;
-        unsigned char Type;
-
-        unsigned short thresh1;  /*  band switch VHF_LO <=> VHF_HI  */
-        unsigned short thresh2;  /*  band switch VHF_HI <=> UHF     */
-        unsigned char VHF_L;
-        unsigned char VHF_H;
-        unsigned char UHF;
+
+        int count;
+        struct {
+                unsigned short thresh;
+                unsigned char cb;
+        } ranges[TUNER_MAX_RANGES];
         unsigned char config;
-        unsigned short IFPCoff; /* 622.4=16*38.90 MHz PAL,
-                                   732  =16*45.75 NTSCi,
-                                   940  =16*58.75 NTSC-Japan
-                                   704  =16*44    ATSC */
 };
 
 /*
@@ -102,158 +102,696 @@ struct tunertype
  */
 static struct tunertype tuners[] = {
         /* 0-9 */
-        { "Temic PAL (4002 FH5)", TEMIC, PAL,
-          16*140.25,16*463.25,0x02,0x04,0x01,0x8e,623},
-        { "Philips PAL_I (FI1246 and compatibles)", Philips, PAL_I,
-          16*140.25,16*463.25,0xa0,0x90,0x30,0x8e,623},
-        { "Philips NTSC (FI1236,FM1236 and compatibles)", Philips, NTSC,
-          16*157.25,16*451.25,0xA0,0x90,0x30,0x8e,732},
-        { "Philips (SECAM+PAL_BG) (FI1216MF, FM1216MF, FR1216MF)", Philips, SECAM,
-          16*168.25,16*447.25,0xA7,0x97,0x37,0x8e,623},
-        { "NoTuner", NoTuner, NOTUNER,
-          0,0,0x00,0x00,0x00,0x00,0x00},
-        { "Philips PAL_BG (FI1216 and compatibles)", Philips, PAL,
-          16*168.25,16*447.25,0xA0,0x90,0x30,0x8e,623},
-        { "Temic NTSC (4032 FY5)", TEMIC, NTSC,
-          16*157.25,16*463.25,0x02,0x04,0x01,0x8e,732},
-        { "Temic PAL_I (4062 FY5)", TEMIC, PAL_I,
-          16*170.00,16*450.00,0x02,0x04,0x01,0x8e,623},
-        { "Temic NTSC (4036 FY5)", TEMIC, NTSC,
-          16*157.25,16*463.25,0xa0,0x90,0x30,0x8e,732},
-        { "Alps HSBH1", TEMIC, NTSC,
-          16*137.25,16*385.25,0x01,0x02,0x08,0x8e,732},
+        [TUNER_TEMIC_PAL] = { /* TEMIC PAL */
+                .name   = "Temic PAL (4002 FH5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 140.25 /*MHz*/, 0x02, },
+                        { 16 * 463.25 /*MHz*/, 0x04, },
+                        { 16 * 999.99        , 0x01, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_PAL_I] = { /* Philips PAL_I */
+                .name   = "Philips PAL_I (FI1246 and compatibles)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 140.25 /*MHz*/, 0xa0, },
+                        { 16 * 463.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_NTSC] = { /* Philips NTSC */
+                .name   = "Philips NTSC (FI1236,FM1236 and compatibles)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0xa0, },
+                        { 16 * 451.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_SECAM] = { /* Philips SECAM */
+                .name   = "Philips (SECAM+PAL_BG) (FI1216MF, FM1216MF, FR1216MF)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 168.25 /*MHz*/, 0xa7, },
+                        { 16 * 447.25 /*MHz*/, 0x97, },
+                        { 16 * 999.99        , 0x37, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ABSENT] = { /* Tuner Absent */
+                .name   = "NoTuner",
+                .count  = 1,
+                .ranges = {
+                        { 0, 0x00, },
+                },
+                .config = 0x00,
+        },
+        [TUNER_PHILIPS_PAL] = { /* Philips PAL */
+                .name   = "Philips PAL_BG (FI1216 and compatibles)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 168.25 /*MHz*/, 0xa0, },
+                        { 16 * 447.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_NTSC] = { /* TEMIC NTSC */
+                .name   = "Temic NTSC (4032 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0x02, },
+                        { 16 * 463.25 /*MHz*/, 0x04, },
+                        { 16 * 999.99        , 0x01, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_PAL_I] = { /* TEMIC PAL_I */
+                .name   = "Temic PAL_I (4062 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0x02, },
+                        { 16 * 450.00 /*MHz*/, 0x04, },
+                        { 16 * 999.99        , 0x01, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4036FY5_NTSC] = { /* TEMIC NTSC */
+                .name   = "Temic NTSC (4036 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0xa0, },
+                        { 16 * 463.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ALPS_TSBH1_NTSC] = { /* TEMIC NTSC */
+                .name   = "Alps HSBH1",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 137.25 /*MHz*/, 0x01, },
+                        { 16 * 385.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
 
         /* 10-19 */
-        { "Alps TSBE1", TEMIC, PAL,
-          16*137.25,16*385.25,0x01,0x02,0x08,0x8e,732},
-        { "Alps TSBB5", Alps, PAL_I, /* tested (UK UHF) with Modulartech MM205 */
-          16*133.25,16*351.25,0x01,0x02,0x08,0x8e,632},
-        { "Alps TSBE5", Alps, PAL, /* untested - data sheet guess. Only IF differs. */
-          16*133.25,16*351.25,0x01,0x02,0x08,0x8e,622},
-        { "Alps TSBC5", Alps, PAL, /* untested - data sheet guess. Only IF differs. */
-          16*133.25,16*351.25,0x01,0x02,0x08,0x8e,608},
-        { "Temic PAL_BG (4006FH5)", TEMIC, PAL,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "Alps TSCH6", Alps, NTSC,
-          16*137.25,16*385.25,0x14,0x12,0x11,0x8e,732},
-        { "Temic PAL_DK (4016 FY5)", TEMIC, PAL,
-          16*168.25,16*456.25,0xa0,0x90,0x30,0x8e,623},
-        { "Philips NTSC_M (MK2)", Philips, NTSC,
-          16*160.00,16*454.00,0xa0,0x90,0x30,0x8e,732},
-        { "Temic PAL_I (4066 FY5)", TEMIC, PAL_I,
-          16*169.00, 16*454.00, 0xa0,0x90,0x30,0x8e,623},
-        { "Temic PAL* auto (4006 FN5)", TEMIC, PAL,
-          16*169.00, 16*454.00, 0xa0,0x90,0x30,0x8e,623},
+        [TUNER_ALPS_TSBE1_PAL] = { /* TEMIC PAL */
+                .name   = "Alps TSBE1",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 137.25 /*MHz*/, 0x01, },
+                        { 16 * 385.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ALPS_TSBB5_PAL_I] = { /* Alps PAL_I */
+                .name   = "Alps TSBB5",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 133.25 /*MHz*/, 0x01, },
+                        { 16 * 351.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ALPS_TSBE5_PAL] = { /* Alps PAL */
+                .name   = "Alps TSBE5",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 133.25 /*MHz*/, 0x01, },
+                        { 16 * 351.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ALPS_TSBC5_PAL] = { /* Alps PAL */
+                .name   = "Alps TSBC5",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 133.25 /*MHz*/, 0x01, },
+                        { 16 * 351.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4006FH5_PAL] = { /* TEMIC PAL */
+                .name   = "Temic PAL_BG (4006FH5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_ALPS_TSHC6_NTSC] = { /* Alps NTSC */
+                .name   = "Alps TSCH6",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 137.25 /*MHz*/, 0x14, },
+                        { 16 * 385.25 /*MHz*/, 0x12, },
+                        { 16 * 999.99        , 0x11, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_PAL_DK] = { /* TEMIC PAL */
+                .name   = "Temic PAL_DK (4016 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 168.25 /*MHz*/, 0xa0, },
+                        { 16 * 456.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_NTSC_M] = { /* Philips NTSC */
+                .name   = "Philips NTSC_M (MK2)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4066FY5_PAL_I] = { /* TEMIC PAL_I */
+                .name   = "Temic PAL_I (4066 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 169.00 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4006FN5_MULTI_PAL] = { /* TEMIC PAL */
+                .name   = "Temic PAL* auto (4006 FN5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 169.00 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
 
         /* 20-29 */
-        { "Temic PAL_BG (4009 FR5) or PAL_I (4069 FR5)", TEMIC, PAL,
-          16*141.00, 16*464.00, 0xa0,0x90,0x30,0x8e,623},
-        { "Temic NTSC (4039 FR5)", TEMIC, NTSC,
-          16*158.00, 16*453.00, 0xa0,0x90,0x30,0x8e,732},
-        { "Temic PAL/SECAM multi (4046 FM5)", TEMIC, PAL,
-          16*169.00, 16*454.00, 0xa0,0x90,0x30,0x8e,623},
-        { "Philips PAL_DK (FI1256 and compatibles)", Philips, PAL,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "Philips PAL/SECAM multi (FQ1216ME)", Philips, PAL,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "LG PAL_I+FM (TAPC-I001D)", LGINNOTEK, PAL_I,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "LG PAL_I (TAPC-I701D)", LGINNOTEK, PAL_I,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "LG NTSC+FM (TPI8NSR01F)", LGINNOTEK, NTSC,
-          16*210.00,16*497.00,0xa0,0x90,0x30,0x8e,732},
-        { "LG PAL_BG+FM (TPI8PSB01D)", LGINNOTEK, PAL,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
-        { "LG PAL_BG (TPI8PSB11D)", LGINNOTEK, PAL,
-          16*170.00,16*450.00,0xa0,0x90,0x30,0x8e,623},
+        [TUNER_TEMIC_4009FR5_PAL] = { /* TEMIC PAL */
+                .name   = "Temic PAL_BG (4009 FR5) or PAL_I (4069 FR5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 141.00 /*MHz*/, 0xa0, },
+                        { 16 * 464.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4039FR5_NTSC] = { /* TEMIC NTSC */
+                .name   = "Temic NTSC (4039 FR5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 158.00 /*MHz*/, 0xa0, },
+                        { 16 * 453.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4046FM5] = { /* TEMIC PAL */
+                .name   = "Temic PAL/SECAM multi (4046 FM5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 169.00 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_PAL_DK] = { /* Philips PAL */
+                .name   = "Philips PAL_DK (FI1256 and compatibles)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_FQ1216ME] = { /* Philips PAL */
+                .name   = "Philips PAL/SECAM multi (FQ1216ME)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_PAL_I_FM] = { /* LGINNOTEK PAL_I */
+                .name   = "LG PAL_I+FM (TAPC-I001D)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_PAL_I] = { /* LGINNOTEK PAL_I */
+                .name   = "LG PAL_I (TAPC-I701D)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_NTSC_FM] = { /* LGINNOTEK NTSC */
+                .name   = "LG NTSC+FM (TPI8NSR01F)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 210.00 /*MHz*/, 0xa0, },
+                        { 16 * 497.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_PAL_FM] = { /* LGINNOTEK PAL */
+                .name   = "LG PAL_BG+FM (TPI8PSB01D)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_PAL] = { /* LGINNOTEK PAL */
+                .name   = "LG PAL_BG (TPI8PSB11D)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0xa0, },
+                        { 16 * 450.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
 
         /* 30-39 */
-        { "Temic PAL* auto + FM (4009 FN5)", TEMIC, PAL,
-          16*141.00, 16*464.00, 0xa0,0x90,0x30,0x8e,623},
-        { "SHARP NTSC_JP (2U5JF5540)", SHARP, NTSC, /* 940=16*58.75 NTSC@Japan */
-          16*137.25,16*317.25,0x01,0x02,0x08,0x8e,940 },
-        { "Samsung PAL TCPM9091PD27", Samsung, PAL, /* from sourceforge v3tv */
-          16*169,16*464,0xA0,0x90,0x30,0x8e,623},
-        { "MT20xx universal", Microtune, PAL|NTSC,
+        [TUNER_TEMIC_4009FN5_MULTI_PAL_FM] = { /* TEMIC PAL */
+                .name   = "Temic PAL* auto + FM (4009 FN5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 141.00 /*MHz*/, 0xa0, },
+                        { 16 * 464.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_SHARP_2U5JF5540_NTSC] = { /* SHARP NTSC */
+                .name   = "SHARP NTSC_JP (2U5JF5540)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 137.25 /*MHz*/, 0x01, },
+                        { 16 * 317.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_Samsung_PAL_TCPM9091PD27] = { /* Samsung PAL */
+                .name   = "Samsung PAL TCPM9091PD27",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 169 /*MHz*/, 0xa0, },
+                        { 16 * 464 /*MHz*/, 0x90, },
+                        { 16 * 999.99     , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_MT2032] = { /* Microtune PAL|NTSC */
+                .name   = "MT20xx universal",
           /* see mt20xx.c for details */ },
-        { "Temic PAL_BG (4106 FH5)", TEMIC, PAL,
-          16*141.00, 16*464.00, 0xa0,0x90,0x30,0x8e,623},
-        { "Temic PAL_DK/SECAM_L (4012 FY5)", TEMIC, PAL,
-          16*140.25, 16*463.25, 0x02,0x04,0x01,0x8e,623},
-        { "Temic NTSC (4136 FY5)", TEMIC, NTSC,
-          16*158.00, 16*453.00, 0xa0,0x90,0x30,0x8e,732},
-        { "LG PAL (newer TAPC series)", LGINNOTEK, PAL,
-          16*170.00, 16*450.00, 0x01,0x02,0x08,0x8e,623},
-        { "Philips PAL/SECAM multi (FM1216ME MK3)", Philips, PAL,
-          16*158.00,16*442.00,0x01,0x02,0x04,0x8e,623 },
-        { "LG NTSC (newer TAPC series)", LGINNOTEK, NTSC,
-          16*170.00, 16*450.00, 0x01,0x02,0x08,0x8e,732},
+        [TUNER_TEMIC_4106FH5] = { /* TEMIC PAL */
+                .name   = "Temic PAL_BG (4106 FH5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 141.00 /*MHz*/, 0xa0, },
+                        { 16 * 464.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4012FY5] = { /* TEMIC PAL */
+                .name   = "Temic PAL_DK/SECAM_L (4012 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 140.25 /*MHz*/, 0x02, },
+                        { 16 * 463.25 /*MHz*/, 0x04, },
+                        { 16 * 999.99        , 0x01, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEMIC_4136FY5] = { /* TEMIC NTSC */
+                .name   = "Temic NTSC (4136 FY5)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 158.00 /*MHz*/, 0xa0, },
+                        { 16 * 453.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_PAL_NEW_TAPC] = { /* LGINNOTEK PAL */
+                .name   = "LG PAL (newer TAPC series)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0x01, },
+                        { 16 * 450.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_FM1216ME_MK3] = { /* Philips PAL */
+                .name   = "Philips PAL/SECAM multi (FM1216ME MK3)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 158.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_NTSC_NEW_TAPC] = { /* LGINNOTEK NTSC */
+                .name   = "LG NTSC (newer TAPC series)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0x01, },
+                        { 16 * 450.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
 
         /* 40-49 */
-        { "HITACHI V7-J180AT", HITACHI, NTSC,
-          16*170.00, 16*450.00, 0x01,0x02,0x08,0x8e,940 },
-        { "Philips PAL_MK (FI1216 MK)", Philips, PAL,
-          16*140.25,16*463.25,0x01,0xc2,0xcf,0x8e,623},
-        { "Philips 1236D ATSC/NTSC daul in", Philips, ATSC,
-          16*157.25,16*454.00,0xa0,0x90,0x30,0x8e,732},
-        { "Philips NTSC MK3 (FM1236MK3 or FM1236/F)", Philips, NTSC,
-          16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732},
-        { "Philips 4 in 1 (ATI TV Wonder Pro/Conexant)", Philips, NTSC,
-          16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732},
-        { "Microtune 4049 FM5", Microtune, PAL,
-          16*141.00,16*464.00,0xa0,0x90,0x30,0x8e,623},
-        { "Panasonic VP27s/ENGE4324D", Panasonic, NTSC,
-          16*160.00,16*454.00,0x01,0x02,0x08,0xce,940},
-        { "LG NTSC (TAPE series)", LGINNOTEK, NTSC,
-          16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732 },
-        { "Tenna TNF 8831 BGFF)", Philips, PAL,
-          16*161.25,16*463.25,0xa0,0x90,0x30,0x8e,623},
-        { "Microtune 4042 FI5 ATSC/NTSC dual in", Microtune, NTSC,
-          16*162.00,16*457.00,0xa2,0x94,0x31,0x8e,732},
+        [TUNER_HITACHI_NTSC] = { /* HITACHI NTSC */
+                .name   = "HITACHI V7-J180AT",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0x01, },
+                        { 16 * 450.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_PAL_MK] = { /* Philips PAL */
+                .name   = "Philips PAL_MK (FI1216 MK)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 140.25 /*MHz*/, 0x01, },
+                        { 16 * 463.25 /*MHz*/, 0xc2, },
+                        { 16 * 999.99        , 0xcf, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_ATSC] = { /* Philips ATSC */
+                .name   = "Philips 1236D ATSC/NTSC dual in",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_FM1236_MK3] = { /* Philips NTSC */
+                .name   = "Philips NTSC MK3 (FM1236MK3 or FM1236/F)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_4IN1] = { /* Philips NTSC */
+                .name   = "Philips 4 in 1 (ATI TV Wonder Pro/Conexant)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_MICROTUNE_4049FM5] = { /* Microtune PAL */
+                .name   = "Microtune 4049 FM5",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 141.00 /*MHz*/, 0xa0, },
+                        { 16 * 464.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PANASONIC_VP27] = { /* Panasonic NTSC */
+                .name   = "Panasonic VP27s/ENGE4324D",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 454.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0xce,
+        },
+        [TUNER_LG_NTSC_TAPE] = { /* LGINNOTEK NTSC */
+                .name   = "LG NTSC (TAPE series)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TNF_8831BGFF] = { /* Philips PAL */
+                .name   = "Tenna TNF 8831 BGFF)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 161.25 /*MHz*/, 0xa0, },
+                        { 16 * 463.25 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_MICROTUNE_4042FI5] = { /* Microtune NTSC */
+                .name   = "Microtune 4042 FI5 ATSC/NTSC dual in",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 162.00 /*MHz*/, 0xa2, },
+                        { 16 * 457.00 /*MHz*/, 0x94, },
+                        { 16 * 999.99        , 0x31, },
+                },
+                .config = 0x8e,
+        },
 
         /* 50-59 */
-        { "TCL 2002N", TCL, NTSC,
-          16*172.00,16*448.00,0x01,0x02,0x08,0x8e,732},
-        { "Philips PAL/SECAM_D (FM 1256 I-H3)", Philips, PAL,
-          16*160.00,16*442.00,0x01,0x02,0x04,0x8e,623 },
-        { "Thomson DDT 7610 (ATSC/NTSC)", THOMSON, ATSC,
-          16*157.25,16*454.00,0x39,0x3a,0x3c,0x8e,732},
-        { "Philips FQ1286", Philips, NTSC,
-          16*160.00,16*454.00,0x41,0x42,0x04,0x8e,940}, /* UHF band untested */
-        { "tda8290+75", Philips, PAL|NTSC,
+        [TUNER_TCL_2002N] = { /* TCL NTSC */
+                .name   = "TCL 2002N",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 172.00 /*MHz*/, 0x01, },
+                        { 16 * 448.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_FM1256_IH3] = { /* Philips PAL */
+                .name   = "Philips PAL/SECAM_D (FM 1256 I-H3)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_THOMSON_DTT7610] = { /* THOMSON ATSC */
+                .name   = "Thomson DTT 7610 (ATSC/NTSC)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0x39, },
+                        { 16 * 454.00 /*MHz*/, 0x3a, },
+                        { 16 * 999.99        , 0x3c, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_FQ1286] = { /* Philips NTSC */
+                .name   = "Philips FQ1286",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x41, },
+                        { 16 * 454.00 /*MHz*/, 0x42, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_TDA8290] = { /* Philips PAL|NTSC */
+                .name   = "tda8290+75",
           /* see tda8290.c for details */ },
-        { "TCL 2002MB", TCL, PAL,
-          16*170.00, 16*450.00, 0x01,0x02,0x08,0xce,623},
-        { "Philips PAL/SECAM multi (FQ1216AME MK4)", Philips, PAL,
-          16*160.00,16*442.00,0x01,0x02,0x04,0xce,623 },
-        { "Philips FQ1236A MK4", Philips, NTSC,
-          16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732 },
-        { "Ymec TVision TVF-8531MF/8831MF/8731MF", Philips, NTSC,
-          16*160.00,16*454.00,0xa0,0x90,0x30,0x8e,732},
-        { "Ymec TVision TVF-5533MF", Philips, NTSC,
-          16*160.00,16*454.00,0x01,0x02,0x04,0x8e,732},
+        [TUNER_TCL_2002MB] = { /* TCL PAL */
+                .name   = "TCL 2002MB",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 170.00 /*MHz*/, 0x01, },
+                        { 16 * 450.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0xce,
+        },
+        [TUNER_PHILIPS_FQ1216AME_MK4] = { /* Philips PAL */
+                .name   = "Philips PAL/SECAM multi (FQ1216AME MK4)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0xce,
+        },
+        [TUNER_PHILIPS_FQ1236A_MK4] = { /* Philips NTSC */
+                .name   = "Philips FQ1236A MK4",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 442.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_YMEC_TVF_8531MF] = { /* Philips NTSC */
+                .name   = "Ymec TVision TVF-8531MF/8831MF/8731MF",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0xa0, },
+                        { 16 * 454.00 /*MHz*/, 0x90, },
+                        { 16 * 999.99        , 0x30, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_YMEC_TVF_5533MF] = { /* Philips NTSC */
+                .name   = "Ymec TVision TVF-5533MF",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01, },
+                        { 16 * 454.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
 
         /* 60-69 */
-        { "Thomson DDT 7611 (ATSC/NTSC)", THOMSON, ATSC,
-          16*157.25,16*454.00,0x39,0x3a,0x3c,0x8e,732},
-        { "Tena TNF9533-D/IF/TNF9533-B/DF", Philips, PAL,
-          16*160.25,16*464.25,0x01,0x02,0x04,0x8e,623},
-        { "Philips TEA5767HN FM Radio", Philips, RADIO,
+        [TUNER_THOMSON_DTT761X] = { /* THOMSON ATSC */
+                /* DTT 7611 7611A 7612 7613 7613A 7614 7615 7615A */
+                .name   = "Thomson DTT 761X (ATSC/NTSC)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 145.25 /*MHz*/, 0x39, },
+                        { 16 * 415.25 /*MHz*/, 0x3a, },
+                        { 16 * 999.99        , 0x3c, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TENA_9533_DI] = { /* Philips PAL */
+                .name   = "Tena TNF9533-D/IF/TNF9533-B/DF",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.25 /*MHz*/, 0x01, },
+                        { 16 * 464.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_TEA5767] = { /* Philips RADIO */
+                .name   = "Philips TEA5767HN FM Radio",
           /* see tea5767.c for details */},
-        { "Philips FMD1216ME MK3 Hybrid Tuner", Philips, PAL,
-          16*160.00,16*442.00,0x51,0x52,0x54,0x86,623 },
-        { "LG TDVS-H062F/TUA6034", LGINNOTEK, ATSC,
-          16*160.00,16*455.00,0x01,0x02,0x04,0x8e,732},
-        { "Ymec TVF66T5-B/DFF", Philips, PAL,
-          16*160.25,16*464.25,0x01,0x02,0x08,0x8e,623},
-        { "LG NTSC (TALN mini series)", LGINNOTEK, NTSC,
-          16*137.25,16*373.25,0x01,0x02,0x08,0x8e,732 },
-        { "Philips TD1316 Hybrid Tuner", Philips, PAL,
-          16*160.00,16*442.00,0xa1,0xa2,0xa4,0xc8,623 },
-        { "Philips TUV1236D ATSC/NTSC dual in", Philips, ATSC,
-          16*157.25,16*454.00,0x01,0x02,0x04,0xce,732 },
-        { "Tena TNF 5335 MF", Philips, NTSC,
-          16*157.25,16*454.00,0x01,0x02,0x04,0x8e,732 },
+        [TUNER_PHILIPS_FMD1216ME_MK3] = { /* Philips PAL */
+                .name   = "Philips FMD1216ME MK3 Hybrid Tuner",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x51, },
+                        { 16 * 442.00 /*MHz*/, 0x52, },
+                        { 16 * 999.99        , 0x54, },
+                },
+                .config = 0x86,
+        },
+        [TUNER_LG_TDVS_H062F] = { /* LGINNOTEK ATSC */
+                .name   = "LG TDVS-H062F/TUA6034",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0x01 },
+                        { 16 * 455.00 /*MHz*/, 0x02 },
+                        { 16 * 999.99        , 0x04 },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_YMEC_TVF66T5_B_DFF] = { /* Philips PAL */
+                .name   = "Ymec TVF66T5-B/DFF",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.25 /*MHz*/, 0x01, },
+                        { 16 * 464.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_LG_NTSC_TALN_MINI] = { /* LGINNOTEK NTSC */
+                .name   = "LG NTSC (TALN mini series)",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 137.25 /*MHz*/, 0x01, },
+                        { 16 * 373.25 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x08, },
+                },
+                .config = 0x8e,
+        },
+        [TUNER_PHILIPS_TD1316] = { /* Philips PAL */
+                .name   = "Philips TD1316 Hybrid Tuner",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 160.00 /*MHz*/, 0xa1, },
+                        { 16 * 442.00 /*MHz*/, 0xa2, },
+                        { 16 * 999.99        , 0xa4, },
+                },
+                .config = 0xc8,
+        },
+        [TUNER_PHILIPS_TUV1236D] = { /* Philips ATSC */
+                .name   = "Philips TUV1236D ATSC/NTSC dual in",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0x01, },
+                        { 16 * 454.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0xce,
+        },
+        [TUNER_TNF_5335MF] = { /* Philips NTSC */
+                .name   = "Tena TNF 5335 MF",
+                .count  = 3,
+                .ranges = {
+                        { 16 * 157.25 /*MHz*/, 0x01, },
+                        { 16 * 454.00 /*MHz*/, 0x02, },
+                        { 16 * 999.99        , 0x04, },
+                },
+                .config = 0x8e,
+        },
 };
 
 unsigned const int tuner_count = ARRAY_SIZE(tuners);
@@ -305,20 +843,19 @@ static void default_set_tv_freq(struct i2c_client *c, unsigned int freq)
         u16 div;
         struct tunertype *tun;
         unsigned char buffer[4];
-        int rc;
+        int rc, IFPCoff, i;
 
         tun = &tuners[t->type];
-        if (freq < tun->thresh1) {
-                config = tun->VHF_L;
-                tuner_dbg("tv: VHF lowrange\n");
-        } else if (freq < tun->thresh2) {
-                config = tun->VHF_H;
-                tuner_dbg("tv: VHF high range\n");
-        } else {
-                config = tun->UHF;
-                tuner_dbg("tv: UHF range\n");
+        for (i = 0; i < tun->count; i++) {
+                if (freq > tun->ranges[i].thresh)
+                        continue;
+                break;
         }
-
+        config = tun->ranges[i].cb;
+        /*  i == 0 -> VHF_LO  */
+        /*  i == 1 -> VHF_HI  */
+        /*  i == 2 -> UHF     */
+        tuner_dbg("tv: range %d\n",i);
 
         /* tv norm specific stuff for multi-norm tuners */
         switch (t->type) {
@@ -420,7 +957,37 @@ static void default_set_tv_freq(struct i2c_client *c, unsigned int freq)
          * frequency in case (wanted frequency < current frequency).
          */
 
-        div=freq + tun->IFPCoff;
+        /* IFPCoff = Video Intermediate Frequency - Vif:
+                940  =16*58.75  NTSC/J (Japan)
+                732  =16*45.75  M/N STD
+                704  =16*44     ATSC (at DVB code)
+                632  =16*39.50  I U.K.
+                622.4=16*38.90  B/G D/K I, L STD
+                592  =16*37.00  D China
+                590  =16.36.875 B Australia
+                543.2=16*33.95  L' STD
+                171.2=16*10.70  FM Radio (at set_radio_freq)
+        */
+
+        if (t->std == V4L2_STD_NTSC_M_JP) {
+                IFPCoff = 940;
+        } else if ((t->std & V4L2_STD_MN) &&
+                  !(t->std & ~V4L2_STD_MN)) {
+                IFPCoff = 732;
+        } else if (t->std == V4L2_STD_SECAM_LC) {
+                IFPCoff = 543;
+        } else {
+                IFPCoff = 623;
+        }
+
+        div=freq + IFPCoff + offset;
+
+        tuner_dbg("Freq= %d.%02d MHz, V_IF=%d.%02d MHz, Offset=%d.%02d MHz, div=%0d\n",
+                                        freq / 16, freq % 16 * 100 / 16,
+                                        IFPCoff / 16, IFPCoff % 16 * 100 / 16,
+                                        offset / 16, offset % 16 * 100 / 16,
+                                        div);
+
         if (t->type == TUNER_PHILIPS_SECAM && freq < t->freq) {
                 buffer[0] = tun->config;
                 buffer[1] = config;
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index 0292c5abf14a..b582943a0d3e 100644
--- a/drivers/media/video/tvaudio.c
+++ b/drivers/media/video/tvaudio.c
@@ -31,6 +31,7 @@
 #include <linux/smp_lock.h>
 
 #include <media/audiochip.h>
+#include <media/v4l2-common.h>
 
 #include "tvaudio.h"
 
@@ -46,17 +47,6 @@ MODULE_LICENSE("GPL");
 
 #define UNSET    (-1U)
 
-#define tvaudio_info(fmt, arg...) do {\
-        printk(KERN_INFO "tvaudio %d-%04x: " fmt, \
-                        chip->c.adapter->nr, chip->c.addr , ##arg); } while (0)
-#define tvaudio_warn(fmt, arg...) do {\
-        printk(KERN_WARNING "tvaudio %d-%04x: " fmt, \
-                        chip->c.adapter->nr, chip->c.addr , ##arg); } while (0)
-#define tvaudio_dbg(fmt, arg...) do {\
-        if (debug) \
-                printk(KERN_INFO "tvaudio %d-%04x: " fmt, \
-                        chip->c.adapter->nr, chip->c.addr , ##arg); } while (0)
-
 /* ---------------------------------------------------------------------- */
 /* our structs                                                            */
 
@@ -131,7 +121,7 @@ struct CHIPSTATE {
         /* current settings */
         __u16 left,right,treble,bass,mode;
         int prevmode;
-        int norm;
+        int radio;
 
         /* thread */
         pid_t                tpid;
@@ -142,8 +132,6 @@ struct CHIPSTATE {
         int                  watch_stereo;
 };
 
-#define VIDEO_MODE_RADIO 16      /* norm magic for radio mode */
-
 /* ---------------------------------------------------------------------- */
 /* i2c addresses                                                          */
 
@@ -171,23 +159,23 @@ static int chip_write(struct CHIPSTATE *chip, int subaddr, int val)
         unsigned char buffer[2];
 
         if (-1 == subaddr) {
-                tvaudio_dbg("%s: chip_write: 0x%x\n",
+                v4l_dbg(1, &chip->c, "%s: chip_write: 0x%x\n",
                         chip->c.name, val);
                 chip->shadow.bytes[1] = val;
                 buffer[0] = val;
                 if (1 != i2c_master_send(&chip->c,buffer,1)) {
-                        tvaudio_warn("%s: I/O error (write 0x%x)\n",
+                        v4l_warn(&chip->c, "%s: I/O error (write 0x%x)\n",
                                 chip->c.name, val);
                         return -1;
                 }
         } else {
-                tvaudio_dbg("%s: chip_write: reg%d=0x%x\n",
+                v4l_dbg(1, &chip->c, "%s: chip_write: reg%d=0x%x\n",
                         chip->c.name, subaddr, val);
                 chip->shadow.bytes[subaddr+1] = val;
                 buffer[0] = subaddr;
                 buffer[1] = val;
                 if (2 != i2c_master_send(&chip->c,buffer,2)) {
-                        tvaudio_warn("%s: I/O error (write reg%d=0x%x)\n",
+                        v4l_warn(&chip->c, "%s: I/O error (write reg%d=0x%x)\n",
                         chip->c.name, subaddr, val);
                         return -1;
                 }
@@ -212,11 +200,11 @@ static int chip_read(struct CHIPSTATE *chip)
         unsigned char buffer;
 
         if (1 != i2c_master_recv(&chip->c,&buffer,1)) {
-                tvaudio_warn("%s: I/O error (read)\n",
+                v4l_warn(&chip->c, "%s: I/O error (read)\n",
                 chip->c.name);
                 return -1;
         }
-        tvaudio_dbg("%s: chip_read: 0x%x\n",chip->c.name, buffer);
+        v4l_dbg(1, &chip->c, "%s: chip_read: 0x%x\n",chip->c.name, buffer);
         return buffer;
 }
 
@@ -231,10 +219,10 @@ static int chip_read2(struct CHIPSTATE *chip, int subaddr)
         write[0] = subaddr;
 
         if (2 != i2c_transfer(chip->c.adapter,msgs,2)) {
-                tvaudio_warn("%s: I/O error (read2)\n", chip->c.name);
+                v4l_warn(&chip->c, "%s: I/O error (read2)\n", chip->c.name);
                 return -1;
         }
-        tvaudio_dbg("%s: chip_read2: reg%d=0x%x\n",
+        v4l_dbg(1, &chip->c, "%s: chip_read2: reg%d=0x%x\n",
                 chip->c.name, subaddr,read[0]);
         return read[0];
 }
@@ -247,7 +235,7 @@ static int chip_cmd(struct CHIPSTATE *chip, char *name, audiocmd *cmd)
                 return 0;
 
         /* update our shadow register set; print bytes if (debug > 0) */
-        tvaudio_dbg("%s: chip_cmd(%s): reg=%d, data:",
+        v4l_dbg(1, &chip->c, "%s: chip_cmd(%s): reg=%d, data:",
                 chip->c.name, name,cmd->bytes[0]);
         for (i = 1; i < cmd->count; i++) {
                 if (debug)
@@ -259,7 +247,7 @@ static int chip_cmd(struct CHIPSTATE *chip, char *name, audiocmd *cmd)
 
         /* send data to the chip */
         if (cmd->count != i2c_master_send(&chip->c,cmd->bytes,cmd->count)) {
-                tvaudio_warn("%s: I/O error (%s)\n", chip->c.name, name);
+                v4l_warn(&chip->c, "%s: I/O error (%s)\n", chip->c.name, name);
                 return -1;
         }
         return 0;
@@ -286,7 +274,7 @@ static int chip_thread(void *data)
 
         daemonize("%s", chip->c.name);
         allow_signal(SIGTERM);
-        tvaudio_dbg("%s: thread started\n", chip->c.name);
+        v4l_dbg(1, &chip->c, "%s: thread started\n", chip->c.name);
 
         for (;;) {
                 add_wait_queue(&chip->wq, &wait);
@@ -298,10 +286,10 @@ static int chip_thread(void *data)
                 try_to_freeze();
                 if (chip->done || signal_pending(current))
                         break;
-                tvaudio_dbg("%s: thread wakeup\n", chip->c.name);
+                v4l_dbg(1, &chip->c, "%s: thread wakeup\n", chip->c.name);
 
                 /* don't do anything for radio or if mode != auto */
-                if (chip->norm == VIDEO_MODE_RADIO || chip->mode != 0)
+                if (chip->radio || chip->mode != 0)
                         continue;
 
                 /* have a look what's going on */
@@ -311,7 +299,7 @@ static int chip_thread(void *data)
                 mod_timer(&chip->wt, jiffies+2*HZ);
         }
 
-        tvaudio_dbg("%s: thread exiting\n", chip->c.name);
+        v4l_dbg(1, &chip->c, "%s: thread exiting\n", chip->c.name);
         complete_and_exit(&chip->texit, 0);
         return 0;
 }
@@ -324,7 +312,7 @@ static void generic_checkmode(struct CHIPSTATE *chip)
         if (mode == chip->prevmode)
         return;
 
-        tvaudio_dbg("%s: thread checkmode\n", chip->c.name);
+        v4l_dbg(1, &chip->c, "%s: thread checkmode\n", chip->c.name);
         chip->prevmode = mode;
 
         if (mode & VIDEO_SOUND_STEREO)
@@ -371,7 +359,7 @@ static int tda9840_getmode(struct CHIPSTATE *chip)
         if (val & TDA9840_ST_STEREO)
                 mode |= VIDEO_SOUND_STEREO;
 
-        tvaudio_dbg ("tda9840_getmode(): raw chip read: %d, return: %d\n",
+        v4l_dbg(1, &chip->c, "tda9840_getmode(): raw chip read: %d, return: %d\n",
                 val, mode);
         return mode;
 }
@@ -667,7 +655,7 @@ static int tda9873_getmode(struct CHIPSTATE *chip)
                 mode |= VIDEO_SOUND_STEREO;
         if (val & TDA9873_DUAL)
                 mode |= VIDEO_SOUND_LANG1 | VIDEO_SOUND_LANG2;
-        tvaudio_dbg ("tda9873_getmode(): raw chip read: %d, return: %d\n",
+        v4l_dbg(1, &chip->c, "tda9873_getmode(): raw chip read: %d, return: %d\n",
                 val, mode);
         return mode;
 }
@@ -678,12 +666,12 @@ static void tda9873_setmode(struct CHIPSTATE *chip, int mode)
         /*      int adj_data = chip->shadow.bytes[TDA9873_AD+1] ; */
 
         if ((sw_data & TDA9873_INP_MASK) != TDA9873_INTERNAL) {
-                tvaudio_dbg("tda9873_setmode(): external input\n");
+                v4l_dbg(1, &chip->c, "tda9873_setmode(): external input\n");
                 return;
         }
 
-        tvaudio_dbg("tda9873_setmode(): chip->shadow.bytes[%d] = %d\n", TDA9873_SW+1, chip->shadow.bytes[TDA9873_SW+1]);
-        tvaudio_dbg("tda9873_setmode(): sw_data  = %d\n", sw_data);
+        v4l_dbg(1, &chip->c, "tda9873_setmode(): chip->shadow.bytes[%d] = %d\n", TDA9873_SW+1, chip->shadow.bytes[TDA9873_SW+1]);
+        v4l_dbg(1, &chip->c, "tda9873_setmode(): sw_data  = %d\n", sw_data);
 
         switch (mode) {
         case VIDEO_SOUND_MONO:
@@ -704,7 +692,7 @@ static void tda9873_setmode(struct CHIPSTATE *chip, int mode)
         }
 
         chip_write(chip, TDA9873_SW, sw_data);
-        tvaudio_dbg("tda9873_setmode(): req. mode %d; chip_write: %d\n",
+        v4l_dbg(1, &chip->c, "tda9873_setmode(): req. mode %d; chip_write: %d\n",
                 mode, sw_data);
 }
 
@@ -843,7 +831,7 @@ static int tda9874a_setup(struct CHIPSTATE *chip)
                 chip_write(chip, TDA9874A_SDACOSR, (tda9874a_mode) ? 0x81:0x80);
                 chip_write(chip, TDA9874A_AOSR, 0x00); /* or 0x10 */
         }
-        tvaudio_dbg("tda9874a_setup(): %s [0x%02X].\n",
+        v4l_dbg(1, &chip->c, "tda9874a_setup(): %s [0x%02X].\n",
                 tda9874a_modelist[tda9874a_STD].name,tda9874a_STD);
         return 1;
 }
@@ -886,7 +874,7 @@ static int tda9874a_getmode(struct CHIPSTATE *chip)
                         mode |= VIDEO_SOUND_LANG1 | VIDEO_SOUND_LANG2;
         }
 
-        tvaudio_dbg("tda9874a_getmode(): DSR=0x%X, NSR=0x%X, NECR=0x%X, return: %d.\n",
+        v4l_dbg(1, &chip->c, "tda9874a_getmode(): DSR=0x%X, NSR=0x%X, NECR=0x%X, return: %d.\n",
                  dsr, nsr, necr, mode);
         return mode;
 }
@@ -932,7 +920,7 @@ static void tda9874a_setmode(struct CHIPSTATE *chip, int mode)
                 chip_write(chip, TDA9874A_AOSR, aosr);
                 chip_write(chip, TDA9874A_MDACOSR, mdacosr);
 
-                tvaudio_dbg("tda9874a_setmode(): req. mode %d; AOSR=0x%X, MDACOSR=0x%X.\n",
+                v4l_dbg(1, &chip->c, "tda9874a_setmode(): req. mode %d; AOSR=0x%X, MDACOSR=0x%X.\n",
                         mode, aosr, mdacosr);
 
         } else { /* dic == 0x07 */
@@ -967,7 +955,7 @@ static void tda9874a_setmode(struct CHIPSTATE *chip, int mode)
                 chip_write(chip, TDA9874A_FMMR, fmmr);
                 chip_write(chip, TDA9874A_AOSR, aosr);
 
-                tvaudio_dbg("tda9874a_setmode(): req. mode %d; FMMR=0x%X, AOSR=0x%X.\n",
+                v4l_dbg(1, &chip->c, "tda9874a_setmode(): req. mode %d; FMMR=0x%X, AOSR=0x%X.\n",
                         mode, fmmr, aosr);
         }
 }
@@ -981,10 +969,10 @@ static int tda9874a_checkit(struct CHIPSTATE *chip)
         if(-1 == (sic = chip_read2(chip,TDA9874A_SIC)))
                 return 0;
 
-        tvaudio_dbg("tda9874a_checkit(): DIC=0x%X, SIC=0x%X.\n", dic, sic);
+        v4l_dbg(1, &chip->c, "tda9874a_checkit(): DIC=0x%X, SIC=0x%X.\n", dic, sic);
 
         if((dic == 0x11)||(dic == 0x07)) {
-                tvaudio_info("found tda9874%s.\n", (dic == 0x11) ? "a":"h");
+                v4l_info(&chip->c, "found tda9874%s.\n", (dic == 0x11) ? "a":"h");
                 tda9874a_dic = dic;     /* remember device id. */
                 return 1;
         }
@@ -1196,7 +1184,7 @@ static int ta8874z_getmode(struct CHIPSTATE *chip)
         }else if (!(val & TA8874Z_B0)){
                 mode |= VIDEO_SOUND_STEREO;
         }
-        /* tvaudio_dbg ("ta8874z_getmode(): raw chip read: 0x%02x, return: 0x%02x\n", val, mode); */
+        /* v4l_dbg(1, &chip->c, "ta8874z_getmode(): raw chip read: 0x%02x, return: 0x%02x\n", val, mode); */
         return mode;
 }
 
@@ -1209,7 +1197,7 @@ static void ta8874z_setmode(struct CHIPSTATE *chip, int mode)
 {
         int update = 1;
         audiocmd *t = NULL;
-        tvaudio_dbg("ta8874z_setmode(): mode: 0x%02x\n", mode);
+        v4l_dbg(1, &chip->c, "ta8874z_setmode(): mode: 0x%02x\n", mode);
 
         switch(mode){
         case VIDEO_SOUND_MONO:
@@ -1490,7 +1478,7 @@ static int chip_attach(struct i2c_adapter *adap, int addr, int kind)
         i2c_set_clientdata(&chip->c, chip);
 
         /* find description for the chip */
-        tvaudio_dbg("chip found @ 0x%x\n", addr<<1);
+        v4l_dbg(1, &chip->c, "chip found @ 0x%x\n", addr<<1);
         for (desc = chiplist; desc->name != NULL; desc++) {
                 if (0 == *(desc->insmodopt))
                         continue;
@@ -1502,12 +1490,12 @@ static int chip_attach(struct i2c_adapter *adap, int addr, int kind)
                 break;
         }
         if (desc->name == NULL) {
-                tvaudio_dbg("no matching chip description found\n");
+                v4l_dbg(1, &chip->c, "no matching chip description found\n");
                 return -EIO;
         }
-        tvaudio_info("%s found @ 0x%x (%s)\n", desc->name, addr<<1, adap->name);
+        v4l_info(&chip->c, "%s found @ 0x%x (%s)\n", desc->name, addr<<1, adap->name);
         if (desc->flags) {
-                tvaudio_dbg("matches:%s%s%s.\n",
+                v4l_dbg(1, &chip->c, "matches:%s%s%s.\n",
                         (desc->flags & CHIP_HAS_VOLUME)     ? " volume"      : "",
                         (desc->flags & CHIP_HAS_BASSTREBLE) ? " bass/treble" : "",
                         (desc->flags & CHIP_HAS_INPUTSEL)   ? " audiomux"    : "");
@@ -1550,7 +1538,7 @@ static int chip_attach(struct i2c_adapter *adap, int addr, int kind)
                 init_completion(&chip->texit);
                 chip->tpid = kernel_thread(chip_thread,(void *)chip,0);
                 if (chip->tpid < 0)
-                        tvaudio_warn("%s: kernel_thread() failed\n",
+                        v4l_warn(&chip->c, "%s: kernel_thread() failed\n",
                                chip->c.name);
                 wake_up_interruptible(&chip->wq);
         }
@@ -1563,17 +1551,8 @@ static int chip_probe(struct i2c_adapter *adap)
            because dedicated drivers are used */
         if ((adap->id == I2C_HW_SAA7146))
                 return 0;
-#ifdef I2C_CLASS_TV_ANALOG
         if (adap->class & I2C_CLASS_TV_ANALOG)
                 return i2c_probe(adap, &addr_data, chip_attach);
-#else
-        switch (adap->id) {
-        case I2C_HW_B_BT848:
-        case I2C_HW_B_RIVA:
-        case I2C_HW_SAA7134:
-                return i2c_probe(adap, &addr_data, chip_attach);
-        }
-#endif
         return 0;
 }
 
@@ -1604,7 +1583,7 @@ static int chip_command(struct i2c_client *client,
         struct CHIPSTATE *chip = i2c_get_clientdata(client);
         struct CHIPDESC  *desc = chiplist + chip->type;
 
-        tvaudio_dbg("%s: chip_command 0x%x\n", chip->c.name, cmd);
+        v4l_dbg(1, &chip->c, "%s: chip_command 0x%x\n", chip->c.name, cmd);
 
         switch (cmd) {
         case AUDC_SET_INPUT:
@@ -1617,7 +1596,7 @@ static int chip_command(struct i2c_client *client,
                 break;
 
         case AUDC_SET_RADIO:
-                chip->norm = VIDEO_MODE_RADIO;
+                chip->radio = 1;
                 chip->watch_stereo = 0;
                 /* del_timer(&chip->wt); */
                 break;
@@ -1643,7 +1622,7 @@ static int chip_command(struct i2c_client *client,
                         va->bass   = chip->bass;
                         va->treble = chip->treble;
                 }
-                if (chip->norm != VIDEO_MODE_RADIO) {
+                if (!chip->radio) {
                         if (desc->getmode)
                                 va->mode = desc->getmode(chip);
                         else
@@ -1678,15 +1657,80 @@ static int chip_command(struct i2c_client *client,
                 }
                 break;
         }
-        case VIDIOCSCHAN:
+
+        case VIDIOC_S_TUNER:
         {
-                struct video_channel *vc = arg;
+                struct v4l2_tuner *vt = arg;
+                int mode = 0;
 
-                chip->norm = vc->norm;
+                switch (vt->audmode) {
+                case V4L2_TUNER_MODE_MONO:
+                        mode = VIDEO_SOUND_MONO;
+                        break;
+                case V4L2_TUNER_MODE_STEREO:
+                        mode = VIDEO_SOUND_STEREO;
+                        break;
+                case V4L2_TUNER_MODE_LANG1:
+                        mode = VIDEO_SOUND_LANG1;
+                        break;
+                case V4L2_TUNER_MODE_LANG2:
+                        mode = VIDEO_SOUND_LANG2;
+                        break;
+                default:
+                        break;
+                }
+
+                if (desc->setmode && mode) {
+                        chip->watch_stereo = 0;
+                        /* del_timer(&chip->wt); */
+                        chip->mode = mode;
+                        desc->setmode(chip, mode);
+                }
                 break;
         }
-        case VIDIOCSFREQ:
+
+        case VIDIOC_G_TUNER:
         {
+                struct v4l2_tuner *vt = arg;
+                int mode = VIDEO_SOUND_MONO;
+
+                if (chip->radio)
+                        break;
+                vt->audmode = 0;
+                vt->rxsubchans = 0;
+                vt->capability = V4L2_TUNER_CAP_STEREO |
+                        V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2;
+
+                if (desc->getmode)
+                        mode = desc->getmode(chip);
+
+                if (mode & VIDEO_SOUND_MONO)
+                        vt->rxsubchans |= V4L2_TUNER_SUB_MONO;
+                if (mode & VIDEO_SOUND_STEREO)
+                        vt->rxsubchans |= V4L2_TUNER_SUB_STEREO;
+                if (mode & VIDEO_SOUND_LANG1)
+                        vt->rxsubchans |= V4L2_TUNER_SUB_LANG1 |
+                                          V4L2_TUNER_SUB_LANG2;
+
+                mode = chip->mode;
+                if (mode & VIDEO_SOUND_MONO)
+                        vt->audmode = V4L2_TUNER_MODE_MONO;
+                if (mode & VIDEO_SOUND_STEREO)
+                        vt->audmode = V4L2_TUNER_MODE_STEREO;
+                if (mode & VIDEO_SOUND_LANG1)
+                        vt->audmode = V4L2_TUNER_MODE_LANG1;
+                if (mode & VIDEO_SOUND_LANG2)
+                        vt->audmode = V4L2_TUNER_MODE_LANG2;
+                break;
+        }
+
+        case VIDIOCSCHAN:
+        case VIDIOC_S_STD:
+                chip->radio = 0;
+                break;
+
+        case VIDIOCSFREQ:
+        case VIDIOC_S_FREQUENCY:
                 chip->mode = 0; /* automatic */
                 if (desc->checkmode) {
                         desc->setmode(chip,VIDEO_SOUND_MONO);
@@ -1695,15 +1739,14 @@ static int chip_command(struct i2c_client *client,
                         mod_timer(&chip->wt, jiffies+2*HZ);
                         /* the thread will call checkmode() later */
                 }
-        }
+                break;
         }
         return 0;
 }
 
-
 static struct i2c_driver driver = {
         .driver = {
-                .name    = "generic i2c audio driver",
+                .name    = "tvaudio",
         },
         .id              = I2C_DRIVERID_TVAUDIO,
         .attach_adapter  = chip_probe,
diff --git a/drivers/media/video/tveeprom.c b/drivers/media/video/tveeprom.c
index 8ac4cb82a459..fd0acc5da667 100644
--- a/drivers/media/video/tveeprom.c
+++ b/drivers/media/video/tveeprom.c
@@ -40,6 +40,7 @@
 
 #include <media/tuner.h>
 #include <media/tveeprom.h>
+#include <media/v4l2-common.h>
 #include <media/audiochip.h>
 
 MODULE_DESCRIPTION("i2c Hauppauge eeprom decoder driver");
@@ -52,21 +53,19 @@ MODULE_PARM_DESC(debug, "Debug level (0-1)");
 
 #define STRM(array,i) (i < sizeof(array)/sizeof(char*) ? array[i] : "unknown")
 
-#define tveeprom_info(fmt, arg...) do {\
-        printk(KERN_INFO "tveeprom %d-%04x: " fmt, \
-                        c->adapter->nr, c->addr , ##arg); } while (0)
-#define tveeprom_warn(fmt, arg...) do {\
-        printk(KERN_WARNING "tveeprom %d-%04x: " fmt, \
-                        c->adapter->nr, c->addr , ##arg); } while (0)
-#define tveeprom_dbg(fmt, arg...) do {\
+#define tveeprom_info(fmt, arg...) \
+        v4l_printk(KERN_INFO, "tveeprom", c->adapter, c->addr, fmt , ## arg)
+#define tveeprom_warn(fmt, arg...) \
+        v4l_printk(KERN_WARNING, "tveeprom", c->adapter, c->addr, fmt , ## arg)
+#define tveeprom_dbg(fmt, arg...) do { \
         if (debug) \
-                printk(KERN_INFO "tveeprom %d-%04x: " fmt, \
-                        c->adapter->nr, c->addr , ##arg); } while (0)
-
-
-/* ----------------------------------------------------------------------- */
-/* some hauppauge specific stuff                                           */
+                v4l_printk(KERN_DEBUG, "tveeprom", c->adapter, c->addr, fmt , ## arg); \
+        } while (0)
 
+/*
+ * The Hauppauge eeprom uses an 8bit field to determine which
+ * tuner formats the tuner supports.
+ */
 static struct HAUPPAUGE_TUNER_FMT
 {
         int     id;
@@ -74,14 +73,14 @@ static struct HAUPPAUGE_TUNER_FMT
 }
 hauppauge_tuner_fmt[] =
 {
-        { 0x00000000, " unknown1" },
-        { 0x00000000, " unknown2" },
-        { 0x00000007, " PAL(B/G)" },
-        { 0x00001000, " NTSC(M)" },
-        { 0x00000010, " PAL(I)" },
-        { 0x00400000, " SECAM(L/L')" },
-        { 0x00000e00, " PAL(D/K)" },
-        { 0x03000000, " ATSC/DVB Digital" },
+        { V4L2_STD_UNKNOWN," UNKNOWN" },
+        { V4L2_STD_UNKNOWN," FM" },
+        { V4L2_STD_PAL_BG, " PAL(B/G)" },
+        { V4L2_STD_NTSC_M, " NTSC(M)" },
+        { V4L2_STD_PAL_I,  " PAL(I)" },
+        { V4L2_STD_SECAM_L," SECAM(L/L')" },
+        { V4L2_STD_PAL_DK, " PAL(D/D1/K)" },
+        { V4L2_STD_ATSC,   " ATSC/DVB Digital" },
 };
 
 /* This is the full list of possible tuners. Many thanks to Hauppauge for
@@ -387,7 +386,7 @@ void tveeprom_hauppauge_analog(struct i2c_client *c, struct tveeprom *tvee,
         if ((eeprom_data[0] == 0x1a) && (eeprom_data[1] == 0xeb) &&
                         (eeprom_data[2] == 0x67) && (eeprom_data[3] == 0x95))
                 start=0xa0; /* Generic em28xx offset */
-        else if (((eeprom_data[0] & 0xf0) == 0x10) &&
+        else if (((eeprom_data[0] & 0xe1) == 0x01) &&
                                         (eeprom_data[1] == 0x00) &&
                                         (eeprom_data[2] == 0x00) &&
                                         (eeprom_data[8] == 0x84))
diff --git a/drivers/media/video/tvmixer.c b/drivers/media/video/tvmixer.c
index e837f9f7fed6..9e86caeb96a7 100644
--- a/drivers/media/video/tvmixer.c
+++ b/drivers/media/video/tvmixer.c
@@ -227,13 +227,9 @@ static int tvmixer_release(struct inode *inode, struct file *file)
 }
 
 static struct i2c_driver driver = {
-#ifdef I2C_PEC
         .driver = {
-                .name    = "tv card mixer driver",
+                .name    = "tvmixer",
         },
-#else
-        .name            = "tv card mixer driver",
-#endif
         .id              = I2C_DRIVERID_TVMIXER,
         .detach_adapter  = tvmixer_adapters,
         .attach_adapter  = tvmixer_adapters,
@@ -267,22 +263,8 @@ static int tvmixer_clients(struct i2c_client *client)
         struct video_audio va;
         int i,minor;
 
-#ifdef I2C_CLASS_TV_ANALOG
         if (!(client->adapter->class & I2C_CLASS_TV_ANALOG))
                 return -1;
-#else
-        /* TV card ??? */
-        switch (client->adapter->id) {
-        case I2C_HW_SMBUS_VOODOO3:
-        case I2C_HW_B_BT848:
-        case I2C_HW_B_RIVA:
-                /* ok, have a look ... */
-                break;
-        default:
-                /* ignore that one */
-                return -1;
-        }
-#endif
 
         /* unregister ?? */
         for (i = 0; i < DEV_MAX; i++) {
diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c
index a60442ea4f94..c35b8042eee5 100644
--- a/drivers/media/video/tvp5150.c
+++ b/drivers/media/video/tvp5150.c
@@ -9,6 +9,7 @@
 #include <linux/videodev.h>
 #include <linux/delay.h>
 #include <linux/video_decoder.h>
+#include <media/v4l2-common.h>
 
 #include "tvp5150_reg.h"
 
@@ -28,33 +29,38 @@ static int debug = 0;
 module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "Debug level (0-1)");
 
-#define dprintk(num, format, args...) \
+#define tvp5150_info(fmt, arg...) do { \
+        printk(KERN_INFO "%s %d-%04x: " fmt, c->driver->driver.name, \
+               i2c_adapter_id(c->adapter), c->addr , ## arg); } while (0)
+#define tvp5150_dbg(num, fmt, arg...) \
         do { \
                 if (debug >= num) \
-                        printk(format, ##args); \
-        } while (0)
+                        printk(KERN_DEBUG "%s debug %d-%04x: " fmt,\
+                                c->driver->driver.name, \
+                                i2c_adapter_id(c->adapter), \
+                                c->addr , ## arg); } while (0)
 
 /* supported controls */
 static struct v4l2_queryctrl tvp5150_qctrl[] = {
         {
-         .id = V4L2_CID_BRIGHTNESS,
-         .type = V4L2_CTRL_TYPE_INTEGER,
-         .name = "Brightness",
-         .minimum = 0,
-         .maximum = 255,
-         .step = 1,
-         .default_value = 0,
-         .flags = 0,
-         }, {
-             .id = V4L2_CID_CONTRAST,
-             .type = V4L2_CTRL_TYPE_INTEGER,
-             .name = "Contrast",
-             .minimum = 0,
-             .maximum = 255,
-             .step = 0x1,
-             .default_value = 0x10,
-             .flags = 0,
-             }, {
+                .id = V4L2_CID_BRIGHTNESS,
+                .type = V4L2_CTRL_TYPE_INTEGER,
+                .name = "Brightness",
+                .minimum = 0,
+                .maximum = 255,
+                .step = 1,
+                .default_value = 0,
+                .flags = 0,
+        }, {
+                .id = V4L2_CID_CONTRAST,
+                .type = V4L2_CTRL_TYPE_INTEGER,
+                .name = "Contrast",
+                .minimum = 0,
+                .maximum = 255,
+                .step = 0x1,
+                .default_value = 0x10,
+                .flags = 0,
+        }, {
                  .id = V4L2_CID_SATURATION,
                  .type = V4L2_CTRL_TYPE_INTEGER,
                  .name = "Saturation",
@@ -63,16 +69,16 @@ static struct v4l2_queryctrl tvp5150_qctrl[] = {
                  .step = 0x1,
                  .default_value = 0x10,
                  .flags = 0,
-                 }, {
-                     .id = V4L2_CID_HUE,
-                     .type = V4L2_CTRL_TYPE_INTEGER,
-                     .name = "Hue",
-                     .minimum = -128,
-                     .maximum = 127,
-                     .step = 0x1,
-                     .default_value = 0x10,
-                     .flags = 0,
-                     }
+        }, {
+                .id = V4L2_CID_HUE,
+                .type = V4L2_CTRL_TYPE_INTEGER,
+                .name = "Hue",
+                .minimum = -128,
+                .maximum = 127,
+                .step = 0x1,
+                .default_value = 0x10,
+                .flags = 0,
+        }
 };
 
 struct tvp5150 {
@@ -94,12 +100,14 @@ static inline int tvp5150_read(struct i2c_client *c, unsigned char addr)
 
         buffer[0] = addr;
         if (1 != (rc = i2c_master_send(c, buffer, 1)))
-                dprintk(0, "i2c i/o error: rc == %d (should be 1)\n", rc);
+                tvp5150_dbg(0, "i2c i/o error: rc == %d (should be 1)\n", rc);
 
         msleep(10);
 
         if (1 != (rc = i2c_master_recv(c, buffer, 1)))
-                dprintk(0, "i2c i/o error: rc == %d (should be 1)\n", rc);
+                tvp5150_dbg(0, "i2c i/o error: rc == %d (should be 1)\n", rc);
+
+        tvp5150_dbg(2, "tvp5150: read 0x%02x = 0x%02x\n", addr, buffer[0]);
 
         return (buffer[0]);
 }
@@ -109,13 +117,12 @@ static inline void tvp5150_write(struct i2c_client *c, unsigned char addr,
 {
         unsigned char buffer[2];
         int rc;
-/*      struct tvp5150 *core = i2c_get_clientdata(c); */
 
         buffer[0] = addr;
         buffer[1] = value;
-        dprintk(1, "tvp5150: writing 0x%02x 0x%02x\n", buffer[0], buffer[1]);
+        tvp5150_dbg(2, "tvp5150: writing 0x%02x 0x%02x\n", buffer[0], buffer[1]);
         if (2 != (rc = i2c_master_send(c, buffer, 2)))
-                dprintk(0, "i2c i/o error: rc == %d (should be 2)\n", rc);
+                tvp5150_dbg(0, "i2c i/o error: rc == %d (should be 2)\n", rc);
 }
 
 static void dump_reg(struct i2c_client *c)
@@ -437,48 +444,346 @@ enum tvp5150_input {
 static inline void tvp5150_selmux(struct i2c_client *c,
                                   enum tvp5150_input input)
 {
+        int opmode=0;
+
         struct tvp5150 *decoder = i2c_get_clientdata(c);
 
         if (!decoder->enable)
                 input |= TVP5150_BLACK_SCREEN;
 
+        switch (input) {
+        case TVP5150_ANALOG_CH0:
+        case TVP5150_ANALOG_CH1:
+                opmode=0x30;            /* TV Mode */
+                break;
+        default:
+                opmode=0;               /* Auto Mode */
+                break;
+        }
+
+        tvp5150_write(c, TVP5150_OP_MODE_CTL, opmode);
         tvp5150_write(c, TVP5150_VD_IN_SRC_SEL_1, input);
 };
 
-static inline void tvp5150_reset(struct i2c_client *c)
+struct i2c_reg_value {
+        unsigned char reg;
+        unsigned char value;
+};
+
+/* Default values as sugested at TVP5150AM1 datasheet */
+static const struct i2c_reg_value tvp5150_init_default[] = {
+        { /* 0x00 */
+                TVP5150_VD_IN_SRC_SEL_1,0x00
+        },
+        { /* 0x01 */
+                TVP5150_ANAL_CHL_CTL,0x15
+        },
+        { /* 0x02 */
+                TVP5150_OP_MODE_CTL,0x00
+        },
+        { /* 0x03 */
+                TVP5150_MISC_CTL,0x01
+        },
+        { /* 0x06 */
+                TVP5150_COLOR_KIL_THSH_CTL,0x10
+        },
+        { /* 0x07 */
+                TVP5150_LUMA_PROC_CTL_1,0x60
+        },
+        { /* 0x08 */
+                TVP5150_LUMA_PROC_CTL_2,0x00
+        },
+        { /* 0x09 */
+                TVP5150_BRIGHT_CTL,0x80
+        },
+        { /* 0x0a */
+                TVP5150_SATURATION_CTL,0x80
+        },
+        { /* 0x0b */
+                TVP5150_HUE_CTL,0x00
+        },
+        { /* 0x0c */
+                TVP5150_CONTRAST_CTL,0x80
+        },
+        { /* 0x0d */
+                TVP5150_DATA_RATE_SEL,0x47
+        },
+        { /* 0x0e */
+                TVP5150_LUMA_PROC_CTL_3,0x00
+        },
+        { /* 0x0f */
+                TVP5150_CONF_SHARED_PIN,0x08
+        },
+        { /* 0x11 */
+                TVP5150_ACT_VD_CROP_ST_MSB,0x00
+        },
+        { /* 0x12 */
+                TVP5150_ACT_VD_CROP_ST_LSB,0x00
+        },
+        { /* 0x13 */
+                TVP5150_ACT_VD_CROP_STP_MSB,0x00
+        },
+        { /* 0x14 */
+                TVP5150_ACT_VD_CROP_STP_LSB,0x00
+        },
+        { /* 0x15 */
+                TVP5150_GENLOCK,0x01
+        },
+        { /* 0x16 */
+                TVP5150_HORIZ_SYNC_START,0x80
+        },
+        { /* 0x18 */
+                TVP5150_VERT_BLANKING_START,0x00
+        },
+        { /* 0x19 */
+                TVP5150_VERT_BLANKING_STOP,0x00
+        },
+        { /* 0x1a */
+                TVP5150_CHROMA_PROC_CTL_1,0x0c
+        },
+        { /* 0x1b */
+                TVP5150_CHROMA_PROC_CTL_2,0x14
+        },
+        { /* 0x1c */
+                TVP5150_INT_RESET_REG_B,0x00
+        },
+        { /* 0x1d */
+                TVP5150_INT_ENABLE_REG_B,0x00
+        },
+        { /* 0x1e */
+                TVP5150_INTT_CONFIG_REG_B,0x00
+        },
+        { /* 0x28 */
+                TVP5150_VIDEO_STD,0x00
+        },
+        { /* 0x2e */
+                TVP5150_MACROVISION_ON_CTR,0x0f
+        },
+        { /* 0x2f */
+                TVP5150_MACROVISION_OFF_CTR,0x01
+        },
+        { /* 0xbb */
+                TVP5150_TELETEXT_FIL_ENA,0x00
+        },
+        { /* 0xc0 */
+                TVP5150_INT_STATUS_REG_A,0x00
+        },
+        { /* 0xc1 */
+                TVP5150_INT_ENABLE_REG_A,0x00
+        },
+        { /* 0xc2 */
+                TVP5150_INT_CONF,0x04
+        },
+        { /* 0xc8 */
+                TVP5150_FIFO_INT_THRESHOLD,0x80
+        },
+        { /* 0xc9 */
+                TVP5150_FIFO_RESET,0x00
+        },
+        { /* 0xca */
+                TVP5150_LINE_NUMBER_INT,0x00
+        },
+        { /* 0xcb */
+                TVP5150_PIX_ALIGN_REG_LOW,0x4e
+        },
+        { /* 0xcc */
+                TVP5150_PIX_ALIGN_REG_HIGH,0x00
+        },
+        { /* 0xcd */
+                TVP5150_FIFO_OUT_CTRL,0x01
+        },
+        { /* 0xcf */
+                TVP5150_FULL_FIELD_ENA_1,0x00
+        },
+        { /* 0xd0 */
+                TVP5150_FULL_FIELD_ENA_2,0x00
+        },
+        { /* 0xfc */
+                TVP5150_FULL_FIELD_MODE_REG,0x7f
+        },
+        { /* end of data */
+                0xff,0xff
+        }
+};
+
+/* Default values as sugested at TVP5150AM1 datasheet */
+static const struct i2c_reg_value tvp5150_init_enable[] = {
+        {
+                TVP5150_CONF_SHARED_PIN, 2
+        },{     /* Automatic offset and AGC enabled */
+                TVP5150_ANAL_CHL_CTL, 0x15
+        },{     /* Activate YCrCb output 0x9 or 0xd ? */
+                TVP5150_MISC_CTL, 0x6f
+        },{     /* Activates video std autodetection for all standards */
+                TVP5150_AUTOSW_MSK, 0x0
+        },{     /* Default format: 0x47. For 4:2:2: 0x40 */
+                TVP5150_DATA_RATE_SEL, 0x47
+        },{
+                TVP5150_CHROMA_PROC_CTL_1, 0x0c
+        },{
+                TVP5150_CHROMA_PROC_CTL_2, 0x54
+        },{     /* Non documented, but initialized on WinTV USB2 */
+                0x27, 0x20
+        },{
+                0xff,0xff
+        }
+};
+
+struct i2c_vbi_ram_value {
+        u16 reg;
+        unsigned char values[26];
+};
+
+struct i2c_vbi_ram_value vbi_ram_default[] =
 {
-        struct tvp5150 *decoder = i2c_get_clientdata(c);
+        {0x010, /* WST SECAM 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0xe7, 0x2e, 0x20, 0x26, 0xe6, 0xb4, 0x0e, 0x0, 0x0, 0x0, 0x10, 0x0 }
+        },
+        {0x030, /* WST PAL B 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0x27, 0x2e, 0x20, 0x2b, 0xa6, 0x72, 0x10, 0x0, 0x0, 0x0, 0x10, 0x0 }
+        },
+        {0x050, /* WST PAL C 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0xe7, 0x2e, 0x20, 0x22, 0xa6, 0x98, 0x0d, 0x0, 0x0, 0x0, 0x10, 0x0 }
+        },
+        {0x070, /* WST NTSC 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0x27, 0x2e, 0x20, 0x23, 0x69, 0x93, 0x0d, 0x0, 0x0, 0x0, 0x10, 0x0 }
+        },
+        {0x090, /* NABTS, NTSC 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0xe7, 0x2e, 0x20, 0x22, 0x69, 0x93, 0x0d, 0x0, 0x0, 0x0, 0x15, 0x0 }
+        },
+        {0x0b0, /* NABTS, NTSC-J 6 */
+                { 0xaa, 0xaa, 0xff, 0xff , 0xa7, 0x2e, 0x20, 0x23, 0x69, 0x93, 0x0d, 0x0, 0x0, 0x0, 0x10, 0x0 }
+        },
+        {0x0d0, /* CC, PAL/SECAM 6 */
+                { 0xaa, 0x2a, 0xff, 0x3f , 0x04, 0x51, 0x6e, 0x02, 0xa6, 0x7b, 0x09, 0x0, 0x0, 0x0, 0x27, 0x0 }
+        },
+        {0x0f0, /* CC, NTSC 6 */
+                { 0xaa, 0x2a, 0xff, 0x3f , 0x04, 0x51, 0x6e, 0x02, 0x69, 0x8c, 0x09, 0x0, 0x0, 0x0, 0x27, 0x0 }
+        },
+        {0x110, /* WSS, PAL/SECAM 6 */
+                { 0x5b, 0x55, 0xc5, 0xff , 0x0, 0x71, 0x6e, 0x42, 0xa6, 0xcd, 0x0f, 0x0, 0x0, 0x0, 0x3a, 0x0 }
+        },
+        {0x130, /* WSS, NTSC C */
+                { 0x38, 0x00, 0x3f, 0x00 , 0x0, 0x71, 0x6e, 0x43, 0x69, 0x7c, 0x08, 0x0, 0x0, 0x0, 0x39, 0x0 }
+        },
+        {0x150, /* VITC, PAL/SECAM 6 */
+                { 0x0, 0x0, 0x0, 0x0 , 0x0, 0x8f, 0x6d, 0x49, 0xa6, 0x85, 0x08, 0x0, 0x0, 0x0, 0x4c, 0x0 }
+        },
+        {0x170, /* VITC, NTSC 6 */
+                { 0x0, 0x0, 0x0, 0x0 , 0x0, 0x8f, 0x6d, 0x49, 0x69, 0x94, 0x08, 0x0, 0x0, 0x0, 0x4c, 0x0 }
+        },
+        { (u16)-1 }
+};
 
-        tvp5150_write(c, TVP5150_CONF_SHARED_PIN, 2);
+static int tvp5150_write_inittab(struct i2c_client *c,
+                                 const struct i2c_reg_value *regs)
+{
+        while (regs->reg != 0xff) {
+                tvp5150_write(c, regs->reg, regs->value);
+                regs++;
+        }
+        return 0;
+}
 
-        /* Automatic offset and AGC enabled */
-        tvp5150_write(c, TVP5150_ANAL_CHL_CTL, 0x15);
+static int tvp5150_vdp_init(struct i2c_client *c,
+                                 const struct i2c_vbi_ram_value *regs)
+{
+        unsigned int i;
 
-        /* Normal Operation */
-//      tvp5150_write(c, TVP5150_OP_MODE_CTL, 0x00);
+        /* Disable Full Field */
+        tvp5150_write(c, TVP5150_FULL_FIELD_ENA_1, 0);
 
-        /* Activate YCrCb output 0x9 or 0xd ? */
-        tvp5150_write(c, TVP5150_MISC_CTL, 0x6f);
+        /* Before programming, Line mode should be at 0xff */
+        for (i=TVP5150_FULL_FIELD_ENA_2; i<=TVP5150_LINE_MODE_REG_44; i++)
+                tvp5150_write(c, i, 0xff);
 
-        /* Activates video std autodetection for all standards */
-        tvp5150_write(c, TVP5150_AUTOSW_MSK, 0x0);
+        /* Load Ram Table */
+        while (regs->reg != (u16)-1 ) {
+                tvp5150_write(c, TVP5150_CONF_RAM_ADDR_HIGH,regs->reg>>8);
+                tvp5150_write(c, TVP5150_CONF_RAM_ADDR_LOW,regs->reg);
 
-        /* Default format: 0x47, 4:2:2: 0x40 */
-        tvp5150_write(c, TVP5150_DATA_RATE_SEL, 0x47);
+                for (i=0;i<16;i++)
+                        tvp5150_write(c, TVP5150_VDP_CONF_RAM_DATA,regs->values[i]);
 
-        tvp5150_selmux(c, decoder->input);
+                regs++;
+        }
+        return 0;
+}
+
+static int tvp5150_set_std(struct i2c_client *c, v4l2_std_id std)
+{
+        struct tvp5150 *decoder = i2c_get_clientdata(c);
+        int fmt=0;
+
+        decoder->norm=std;
+
+        /* First tests should be against specific std */
+
+        if (std == V4L2_STD_ALL) {
+                fmt=0;  /* Autodetect mode */
+        } else if (std & V4L2_STD_NTSC_443) {
+                fmt=0xa;
+        } else if (std & V4L2_STD_PAL_M) {
+                fmt=0x6;
+        } else if (std & (V4L2_STD_PAL_N| V4L2_STD_PAL_Nc)) {
+                fmt=0x8;
+        } else {
+                /* Then, test against generic ones */
+                if (std & V4L2_STD_NTSC) {
+                        fmt=0x2;
+                } else if (std & V4L2_STD_PAL) {
+                        fmt=0x4;
+                } else if (std & V4L2_STD_SECAM) {
+                        fmt=0xc;
+                }
+        }
+
+        tvp5150_dbg(1,"Set video std register to %d.\n",fmt);
+        tvp5150_write(c, TVP5150_VIDEO_STD, fmt);
 
-        tvp5150_write(c, TVP5150_CHROMA_PROC_CTL_1, 0x0c);
-        tvp5150_write(c, TVP5150_CHROMA_PROC_CTL_2, 0x54);
+        return 0;
+}
 
-        tvp5150_write(c, 0x27, 0x20);   /* ?????????? */
+static inline void tvp5150_reset(struct i2c_client *c)
+{
+        u8 type, ver_656, msb_id, lsb_id, msb_rom, lsb_rom;
+        struct tvp5150 *decoder = i2c_get_clientdata(c);
 
-        tvp5150_write(c, TVP5150_VIDEO_STD, 0x0);       /* Auto switch */
+        type=tvp5150_read(c,TVP5150_AUTOSW_MSK);
+        msb_id=tvp5150_read(c,TVP5150_MSB_DEV_ID);
+        lsb_id=tvp5150_read(c,TVP5150_LSB_DEV_ID);
+        msb_rom=tvp5150_read(c,TVP5150_ROM_MAJOR_VER);
+        lsb_rom=tvp5150_read(c,TVP5150_ROM_MINOR_VER);
+
+        if (type==0xdc) {
+                ver_656=tvp5150_read(c,TVP5150_REV_SELECT);
+                tvp5150_info("tvp%02x%02xam1 detected 656 version is %d.\n",msb_id, lsb_id,ver_656);
+        } else if (type==0xfc) {
+                tvp5150_info("tvp%02x%02xa detected.\n",msb_id, lsb_id);
+        } else {
+                tvp5150_info("unknown tvp%02x%02x chip detected(%d).\n",msb_id,lsb_id,type);
+        }
+        tvp5150_info("Rom ver is %d.%d\n",msb_rom,lsb_rom);
 
+        /* Initializes TVP5150 to its default values */
+        tvp5150_write_inittab(c, tvp5150_init_default);
+
+        /* Initializes VDP registers */
+        tvp5150_vdp_init(c, vbi_ram_default);
+
+        /* Selects decoder input */
+        tvp5150_selmux(c, decoder->input);
+
+        /* Initializes TVP5150 to stream enabled values */
+        tvp5150_write_inittab(c, tvp5150_init_enable);
+
+        /* Initialize image preferences */
         tvp5150_write(c, TVP5150_BRIGHT_CTL, decoder->bright >> 8);
         tvp5150_write(c, TVP5150_CONTRAST_CTL, decoder->contrast >> 8);
         tvp5150_write(c, TVP5150_SATURATION_CTL, decoder->contrast >> 8);
         tvp5150_write(c, TVP5150_HUE_CTL, (decoder->hue - 32768) >> 8);
+
+        tvp5150_set_std(c, decoder->norm);
 };
 
 static int tvp5150_get_ctrl(struct i2c_client *c, struct v4l2_control *ctrl)
@@ -498,9 +803,8 @@ static int tvp5150_get_ctrl(struct i2c_client *c, struct v4l2_control *ctrl)
         case V4L2_CID_HUE:
                 ctrl->value = tvp5150_read(c, TVP5150_HUE_CTL);
                 return 0;
-        default:
-                return -EINVAL;
         }
+        return -EINVAL;
 }
 
 static int tvp5150_set_ctrl(struct i2c_client *c, struct v4l2_control *ctrl)
@@ -520,28 +824,59 @@ static int tvp5150_set_ctrl(struct i2c_client *c, struct v4l2_control *ctrl)
         case V4L2_CID_HUE:
                 tvp5150_write(c, TVP5150_HUE_CTL, ctrl->value);
                 return 0;
-        default:
-                return -EINVAL;
         }
+        return -EINVAL;
 }
 
 /****************************************************************************
                         I2C Command
  ****************************************************************************/
-static int tvp5150_command(struct i2c_client *client,
+static int tvp5150_command(struct i2c_client *c,
                            unsigned int cmd, void *arg)
 {
-        struct tvp5150 *decoder = i2c_get_clientdata(client);
+        struct tvp5150 *decoder = i2c_get_clientdata(c);
 
         switch (cmd) {
 
         case 0:
+        case VIDIOC_INT_RESET:
         case DECODER_INIT:
-                tvp5150_reset(client);
+                tvp5150_reset(c);
+                break;
+        case VIDIOC_S_STD:
+                if (decoder->norm == *(v4l2_std_id *)arg)
+                        break;
+                return tvp5150_set_std(c, *(v4l2_std_id *)arg);
+        case VIDIOC_G_STD:
+                *(v4l2_std_id *)arg = decoder->norm;
+                break;
+
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+        case VIDIOC_INT_G_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_TVP5150)
+                        return -EINVAL;
+                reg->val = tvp5150_read(c, reg->reg & 0xff);
+                break;
+        }
+
+        case VIDIOC_INT_S_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_TVP5150)
+                        return -EINVAL;
+                if (!capable(CAP_SYS_ADMIN))
+                        return -EPERM;
+                tvp5150_write(c, reg->reg & 0xff, reg->val & 0xff);
                 break;
+        }
+#endif
 
         case DECODER_DUMP:
-                dump_reg(client);
+                dump_reg(c);
                 break;
 
         case DECODER_GET_CAPABILITIES:
@@ -600,7 +935,7 @@ static int tvp5150_command(struct i2c_client *client,
                         }
 
                         decoder->input = *iarg;
-                        tvp5150_selmux(client, decoder->input);
+                        tvp5150_selmux(c, decoder->input);
 
                         break;
                 }
@@ -620,19 +955,18 @@ static int tvp5150_command(struct i2c_client *client,
 
                         decoder->enable = (*iarg != 0);
 
-                        tvp5150_selmux(client, decoder->input);
+                        tvp5150_selmux(c, decoder->input);
 
                         break;
                 }
         case VIDIOC_QUERYCTRL:
                 {
                         struct v4l2_queryctrl *qc = arg;
-                        u8 i, n;
+                        int i;
 
-                        dprintk(1, KERN_DEBUG "VIDIOC_QUERYCTRL");
+                        tvp5150_dbg(1, "VIDIOC_QUERYCTRL called\n");
 
-                        n = sizeof(tvp5150_qctrl) / sizeof(tvp5150_qctrl[0]);
-                        for (i = 0; i < n; i++)
+                        for (i = 0; i < ARRAY_SIZE(tvp5150_qctrl); i++)
                                 if (qc->id && qc->id == tvp5150_qctrl[i].id) {
                                         memcpy(qc, &(tvp5150_qctrl[i]),
                                                sizeof(*qc));
@@ -644,16 +978,14 @@ static int tvp5150_command(struct i2c_client *client,
         case VIDIOC_G_CTRL:
                 {
                         struct v4l2_control *ctrl = arg;
-                        dprintk(1, KERN_DEBUG "VIDIOC_G_CTRL");
+                        tvp5150_dbg(1, "VIDIOC_G_CTRL called\n");
 
-                        return tvp5150_get_ctrl(client, ctrl);
+                        return tvp5150_get_ctrl(c, ctrl);
                 }
-        case VIDIOC_S_CTRL_OLD: /* ??? */
         case VIDIOC_S_CTRL:
                 {
                         struct v4l2_control *ctrl = arg;
                         u8 i, n;
-                        dprintk(1, KERN_DEBUG "VIDIOC_S_CTRL");
                         n = sizeof(tvp5150_qctrl) / sizeof(tvp5150_qctrl[0]);
                         for (i = 0; i < n; i++)
                                 if (ctrl->id == tvp5150_qctrl[i].id) {
@@ -662,11 +994,10 @@ static int tvp5150_command(struct i2c_client *client,
                                             || ctrl->value >
                                             tvp5150_qctrl[i].maximum)
                                                 return -ERANGE;
-                                        dprintk(1,
-                                                KERN_DEBUG
-                                                "VIDIOC_S_CTRL: id=%d, value=%d",
+                                        tvp5150_dbg(1,
+                                                "VIDIOC_S_CTRL: id=%d, value=%d\n",
                                                 ctrl->id, ctrl->value);
-                                        return tvp5150_set_ctrl(client, ctrl);
+                                        return tvp5150_set_ctrl(c, ctrl);
                                 }
                         return -EINVAL;
                 }
@@ -677,25 +1008,25 @@ static int tvp5150_command(struct i2c_client *client,
                         if (decoder->bright != pic->brightness) {
                                 /* We want 0 to 255 we get 0-65535 */
                                 decoder->bright = pic->brightness;
-                                tvp5150_write(client, TVP5150_BRIGHT_CTL,
+                                tvp5150_write(c, TVP5150_BRIGHT_CTL,
                                               decoder->bright >> 8);
                         }
                         if (decoder->contrast != pic->contrast) {
                                 /* We want 0 to 255 we get 0-65535 */
                                 decoder->contrast = pic->contrast;
-                                tvp5150_write(client, TVP5150_CONTRAST_CTL,
+                                tvp5150_write(c, TVP5150_CONTRAST_CTL,
                                               decoder->contrast >> 8);
                         }
                         if (decoder->sat != pic->colour) {
                                 /* We want 0 to 255 we get 0-65535 */
                                 decoder->sat = pic->colour;
-                                tvp5150_write(client, TVP5150_SATURATION_CTL,
+                                tvp5150_write(c, TVP5150_SATURATION_CTL,
                                               decoder->contrast >> 8);
                         }
                         if (decoder->hue != pic->hue) {
                                 /* We want -128 to 127 we get 0-65535 */
                                 decoder->hue = pic->hue;
-                                tvp5150_write(client, TVP5150_HUE_CTL,
+                                tvp5150_write(c, TVP5150_HUE_CTL,
                                               (decoder->hue - 32768) >> 8);
                         }
                         break;
@@ -720,12 +1051,12 @@ static struct i2c_client client_template = {
 static int tvp5150_detect_client(struct i2c_adapter *adapter,
                                  int address, int kind)
 {
-        struct i2c_client *client;
+        struct i2c_client *c;
         struct tvp5150 *core;
         int rv;
 
-        dprintk(1,
-                KERN_INFO
+        if (debug)
+                printk( KERN_INFO
                 "tvp5150.c: detecting tvp5150 client on address 0x%x\n",
                 address << 1);
 
@@ -738,22 +1069,22 @@ static int tvp5150_detect_client(struct i2c_adapter *adapter,
              I2C_FUNC_SMBUS_READ_BYTE | I2C_FUNC_SMBUS_WRITE_BYTE_DATA))
                 return 0;
 
-        client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (client == 0)
+        c = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+        if (c == 0)
                 return -ENOMEM;
-        memcpy(client, &client_template, sizeof(struct i2c_client));
+        memcpy(c, &client_template, sizeof(struct i2c_client));
 
         core = kmalloc(sizeof(struct tvp5150), GFP_KERNEL);
         if (core == 0) {
-                kfree(client);
+                kfree(c);
                 return -ENOMEM;
         }
         memset(core, 0, sizeof(struct tvp5150));
-        i2c_set_clientdata(client, core);
+        i2c_set_clientdata(c, core);
 
-        rv = i2c_attach_client(client);
+        rv = i2c_attach_client(c);
 
-        core->norm = VIDEO_MODE_AUTO;
+        core->norm = V4L2_STD_ALL;
         core->input = 2;
         core->enable = 1;
         core->bright = 32768;
@@ -762,37 +1093,41 @@ static int tvp5150_detect_client(struct i2c_adapter *adapter,
         core->sat = 32768;
 
         if (rv) {
-                kfree(client);
+                kfree(c);
                 kfree(core);
                 return rv;
         }
 
         if (debug > 1)
-                dump_reg(client);
+                dump_reg(c);
         return 0;
 }
 
 static int tvp5150_attach_adapter(struct i2c_adapter *adapter)
 {
-        dprintk(1,
-                KERN_INFO
+        if (debug)
+                printk( KERN_INFO
                 "tvp5150.c: starting probe for adapter %s (0x%x)\n",
                 adapter->name, adapter->id);
         return i2c_probe(adapter, &addr_data, &tvp5150_detect_client);
 }
 
-static int tvp5150_detach_client(struct i2c_client *client)
+static int tvp5150_detach_client(struct i2c_client *c)
 {
-        struct tvp5150 *decoder = i2c_get_clientdata(client);
+        struct tvp5150 *decoder = i2c_get_clientdata(c);
         int err;
 
-        err = i2c_detach_client(client);
+        tvp5150_dbg(1,
+                "tvp5150.c: removing tvp5150 adapter on address 0x%x\n",
+                c->addr << 1);
+
+        err = i2c_detach_client(c);
         if (err) {
                 return err;
         }
 
         kfree(decoder);
-        kfree(client);
+        kfree(c);
 
         return 0;
 }
@@ -803,9 +1138,7 @@ static struct i2c_driver driver = {
         .driver = {
                 .name = "tvp5150",
         },
-
-        /* FIXME */
-        .id = I2C_DRIVERID_SAA7110,
+        .id = I2C_DRIVERID_TVP5150,
 
         .attach_adapter = tvp5150_attach_adapter,
         .detach_client = tvp5150_detach_client,
diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c
index 4134549d11a8..2ab5b4093800 100644
--- a/drivers/media/video/v4l1-compat.c
+++ b/drivers/media/video/v4l1-compat.c
@@ -951,6 +951,10 @@ v4l_compat_translate_ioctl(struct inode         *inode,
                         dprintk("VIDIOCGVBIFMT / VIDIOC_G_FMT: %d\n", err);
                         break;
                 }
+                if (fmt2->fmt.vbi.sample_format != V4L2_PIX_FMT_GREY) {
+                        err = -EINVAL;
+                        break;
+                }
                 memset(fmt, 0, sizeof(*fmt));
                 fmt->samples_per_line = fmt2->fmt.vbi.samples_per_line;
                 fmt->sampling_rate    = fmt2->fmt.vbi.sampling_rate;
@@ -966,6 +970,11 @@ v4l_compat_translate_ioctl(struct inode         *inode,
         {
                 struct vbi_format      *fmt = arg;
 
+                if (VIDEO_PALETTE_RAW != fmt->sample_format) {
+                        err = -EINVAL;
+                        break;
+                }
+
                 fmt2 = kmalloc(sizeof(*fmt2),GFP_KERNEL);
                 memset(fmt2, 0, sizeof(*fmt2));
 
@@ -986,7 +995,7 @@ v4l_compat_translate_ioctl(struct inode         *inode,
 
                 if (fmt2->fmt.vbi.samples_per_line != fmt->samples_per_line ||
                     fmt2->fmt.vbi.sampling_rate    != fmt->sampling_rate    ||
-                    VIDEO_PALETTE_RAW              != fmt->sample_format    ||
+                    fmt2->fmt.vbi.sample_format    != V4L2_PIX_FMT_GREY     ||
                     fmt2->fmt.vbi.start[0]         != fmt->start[0]         ||
                     fmt2->fmt.vbi.count[0]         != fmt->count[0]         ||
                     fmt2->fmt.vbi.start[1]         != fmt->start[1]         ||
diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c
index 597b8db35a13..5dbd7c1b362a 100644
--- a/drivers/media/video/v4l2-common.c
+++ b/drivers/media/video/v4l2-common.c
@@ -58,6 +58,8 @@
 #include <asm/pgtable.h>
 #include <asm/io.h>
 #include <asm/div64.h>
+#include <linux/video_decoder.h>
+#include <media/v4l2-common.h>
 
 #ifdef CONFIG_KMOD
 #include <linux/kmod.h>
@@ -190,57 +192,174 @@ char *v4l2_type_names[] = {
         [V4L2_BUF_TYPE_VBI_OUTPUT]    = "vbi-out",
 };
 
-char *v4l2_ioctl_names[256] = {
-#if __GNUC__ >= 3
-        [0 ... 255]                      = "UNKNOWN",
+/* ------------------------------------------------------------------ */
+/* debug help functions                                               */
+
+#ifdef HAVE_V4L1
+static const char *v4l1_ioctls[] = {
+        [_IOC_NR(VIDIOCGCAP)]       = "VIDIOCGCAP",
+        [_IOC_NR(VIDIOCGCHAN)]      = "VIDIOCGCHAN",
+        [_IOC_NR(VIDIOCSCHAN)]      = "VIDIOCSCHAN",
+        [_IOC_NR(VIDIOCGTUNER)]     = "VIDIOCGTUNER",
+        [_IOC_NR(VIDIOCSTUNER)]     = "VIDIOCSTUNER",
+        [_IOC_NR(VIDIOCGPICT)]      = "VIDIOCGPICT",
+        [_IOC_NR(VIDIOCSPICT)]      = "VIDIOCSPICT",
+        [_IOC_NR(VIDIOCCAPTURE)]    = "VIDIOCCAPTURE",
+        [_IOC_NR(VIDIOCGWIN)]       = "VIDIOCGWIN",
+        [_IOC_NR(VIDIOCSWIN)]       = "VIDIOCSWIN",
+        [_IOC_NR(VIDIOCGFBUF)]      = "VIDIOCGFBUF",
+        [_IOC_NR(VIDIOCSFBUF)]      = "VIDIOCSFBUF",
+        [_IOC_NR(VIDIOCKEY)]        = "VIDIOCKEY",
+        [_IOC_NR(VIDIOCGFREQ)]      = "VIDIOCGFREQ",
+        [_IOC_NR(VIDIOCSFREQ)]      = "VIDIOCSFREQ",
+        [_IOC_NR(VIDIOCGAUDIO)]     = "VIDIOCGAUDIO",
+        [_IOC_NR(VIDIOCSAUDIO)]     = "VIDIOCSAUDIO",
+        [_IOC_NR(VIDIOCSYNC)]       = "VIDIOCSYNC",
+        [_IOC_NR(VIDIOCMCAPTURE)]   = "VIDIOCMCAPTURE",
+        [_IOC_NR(VIDIOCGMBUF)]      = "VIDIOCGMBUF",
+        [_IOC_NR(VIDIOCGUNIT)]      = "VIDIOCGUNIT",
+        [_IOC_NR(VIDIOCGCAPTURE)]   = "VIDIOCGCAPTURE",
+        [_IOC_NR(VIDIOCSCAPTURE)]   = "VIDIOCSCAPTURE",
+        [_IOC_NR(VIDIOCSPLAYMODE)]  = "VIDIOCSPLAYMODE",
+        [_IOC_NR(VIDIOCSWRITEMODE)] = "VIDIOCSWRITEMODE",
+        [_IOC_NR(VIDIOCGPLAYINFO)]  = "VIDIOCGPLAYINFO",
+        [_IOC_NR(VIDIOCSMICROCODE)] = "VIDIOCSMICROCODE",
+        [_IOC_NR(VIDIOCGVBIFMT)]    = "VIDIOCGVBIFMT",
+        [_IOC_NR(VIDIOCSVBIFMT)]    = "VIDIOCSVBIFMT"
+};
+#define V4L1_IOCTLS ARRAY_SIZE(v4l1_ioctls)
+#endif
+
+static const char *v4l2_ioctls[] = {
+        [_IOC_NR(VIDIOC_QUERYCAP)]         = "VIDIOC_QUERYCAP",
+        [_IOC_NR(VIDIOC_RESERVED)]         = "VIDIOC_RESERVED",
+        [_IOC_NR(VIDIOC_ENUM_FMT)]         = "VIDIOC_ENUM_FMT",
+        [_IOC_NR(VIDIOC_G_FMT)]            = "VIDIOC_G_FMT",
+        [_IOC_NR(VIDIOC_S_FMT)]            = "VIDIOC_S_FMT",
+        [_IOC_NR(VIDIOC_G_MPEGCOMP)]       = "VIDIOC_G_MPEGCOMP",
+        [_IOC_NR(VIDIOC_S_MPEGCOMP)]       = "VIDIOC_S_MPEGCOMP",
+        [_IOC_NR(VIDIOC_REQBUFS)]          = "VIDIOC_REQBUFS",
+        [_IOC_NR(VIDIOC_QUERYBUF)]         = "VIDIOC_QUERYBUF",
+        [_IOC_NR(VIDIOC_G_FBUF)]           = "VIDIOC_G_FBUF",
+        [_IOC_NR(VIDIOC_S_FBUF)]           = "VIDIOC_S_FBUF",
+        [_IOC_NR(VIDIOC_OVERLAY)]          = "VIDIOC_OVERLAY",
+        [_IOC_NR(VIDIOC_QBUF)]             = "VIDIOC_QBUF",
+        [_IOC_NR(VIDIOC_DQBUF)]            = "VIDIOC_DQBUF",
+        [_IOC_NR(VIDIOC_STREAMON)]         = "VIDIOC_STREAMON",
+        [_IOC_NR(VIDIOC_STREAMOFF)]        = "VIDIOC_STREAMOFF",
+        [_IOC_NR(VIDIOC_G_PARM)]           = "VIDIOC_G_PARM",
+        [_IOC_NR(VIDIOC_S_PARM)]           = "VIDIOC_S_PARM",
+        [_IOC_NR(VIDIOC_G_STD)]            = "VIDIOC_G_STD",
+        [_IOC_NR(VIDIOC_S_STD)]            = "VIDIOC_S_STD",
+        [_IOC_NR(VIDIOC_ENUMSTD)]          = "VIDIOC_ENUMSTD",
+        [_IOC_NR(VIDIOC_ENUMINPUT)]        = "VIDIOC_ENUMINPUT",
+        [_IOC_NR(VIDIOC_G_CTRL)]           = "VIDIOC_G_CTRL",
+        [_IOC_NR(VIDIOC_S_CTRL)]           = "VIDIOC_S_CTRL",
+        [_IOC_NR(VIDIOC_G_TUNER)]          = "VIDIOC_G_TUNER",
+        [_IOC_NR(VIDIOC_S_TUNER)]          = "VIDIOC_S_TUNER",
+        [_IOC_NR(VIDIOC_G_AUDIO)]          = "VIDIOC_G_AUDIO",
+        [_IOC_NR(VIDIOC_S_AUDIO)]          = "VIDIOC_S_AUDIO",
+        [_IOC_NR(VIDIOC_QUERYCTRL)]        = "VIDIOC_QUERYCTRL",
+        [_IOC_NR(VIDIOC_QUERYMENU)]        = "VIDIOC_QUERYMENU",
+        [_IOC_NR(VIDIOC_G_INPUT)]          = "VIDIOC_G_INPUT",
+        [_IOC_NR(VIDIOC_S_INPUT)]          = "VIDIOC_S_INPUT",
+        [_IOC_NR(VIDIOC_G_OUTPUT)]         = "VIDIOC_G_OUTPUT",
+        [_IOC_NR(VIDIOC_S_OUTPUT)]         = "VIDIOC_S_OUTPUT",
+        [_IOC_NR(VIDIOC_ENUMOUTPUT)]       = "VIDIOC_ENUMOUTPUT",
+        [_IOC_NR(VIDIOC_G_AUDOUT)]         = "VIDIOC_G_AUDOUT",
+        [_IOC_NR(VIDIOC_S_AUDOUT)]         = "VIDIOC_S_AUDOUT",
+        [_IOC_NR(VIDIOC_G_MODULATOR)]      = "VIDIOC_G_MODULATOR",
+        [_IOC_NR(VIDIOC_S_MODULATOR)]      = "VIDIOC_S_MODULATOR",
+        [_IOC_NR(VIDIOC_G_FREQUENCY)]      = "VIDIOC_G_FREQUENCY",
+        [_IOC_NR(VIDIOC_S_FREQUENCY)]      = "VIDIOC_S_FREQUENCY",
+        [_IOC_NR(VIDIOC_CROPCAP)]          = "VIDIOC_CROPCAP",
+        [_IOC_NR(VIDIOC_G_CROP)]           = "VIDIOC_G_CROP",
+        [_IOC_NR(VIDIOC_S_CROP)]           = "VIDIOC_S_CROP",
+        [_IOC_NR(VIDIOC_G_JPEGCOMP)]       = "VIDIOC_G_JPEGCOMP",
+        [_IOC_NR(VIDIOC_S_JPEGCOMP)]       = "VIDIOC_S_JPEGCOMP",
+        [_IOC_NR(VIDIOC_QUERYSTD)]         = "VIDIOC_QUERYSTD",
+        [_IOC_NR(VIDIOC_TRY_FMT)]          = "VIDIOC_TRY_FMT",
+        [_IOC_NR(VIDIOC_ENUMAUDIO)]        = "VIDIOC_ENUMAUDIO",
+        [_IOC_NR(VIDIOC_ENUMAUDOUT)]       = "VIDIOC_ENUMAUDOUT",
+        [_IOC_NR(VIDIOC_G_PRIORITY)]       = "VIDIOC_G_PRIORITY",
+        [_IOC_NR(VIDIOC_S_PRIORITY)]       = "VIDIOC_S_PRIORITY",
+#if 1
+        [_IOC_NR(VIDIOC_G_SLICED_VBI_CAP)] = "VIDIOC_G_SLICED_VBI_CAP",
 #endif
-        [_IOC_NR(VIDIOC_QUERYCAP)]       = "VIDIOC_QUERYCAP",
-        [_IOC_NR(VIDIOC_RESERVED)]       = "VIDIOC_RESERVED",
-        [_IOC_NR(VIDIOC_ENUM_FMT)]       = "VIDIOC_ENUM_FMT",
-        [_IOC_NR(VIDIOC_G_FMT)]          = "VIDIOC_G_FMT",
-        [_IOC_NR(VIDIOC_S_FMT)]          = "VIDIOC_S_FMT",
-        [_IOC_NR(VIDIOC_REQBUFS)]        = "VIDIOC_REQBUFS",
-        [_IOC_NR(VIDIOC_QUERYBUF)]       = "VIDIOC_QUERYBUF",
-        [_IOC_NR(VIDIOC_G_FBUF)]         = "VIDIOC_G_FBUF",
-        [_IOC_NR(VIDIOC_S_FBUF)]         = "VIDIOC_S_FBUF",
-        [_IOC_NR(VIDIOC_OVERLAY)]        = "VIDIOC_OVERLAY",
-        [_IOC_NR(VIDIOC_QBUF)]           = "VIDIOC_QBUF",
-        [_IOC_NR(VIDIOC_DQBUF)]          = "VIDIOC_DQBUF",
-        [_IOC_NR(VIDIOC_STREAMON)]       = "VIDIOC_STREAMON",
-        [_IOC_NR(VIDIOC_STREAMOFF)]      = "VIDIOC_STREAMOFF",
-        [_IOC_NR(VIDIOC_G_PARM)]         = "VIDIOC_G_PARM",
-        [_IOC_NR(VIDIOC_S_PARM)]         = "VIDIOC_S_PARM",
-        [_IOC_NR(VIDIOC_G_STD)]          = "VIDIOC_G_STD",
-        [_IOC_NR(VIDIOC_S_STD)]          = "VIDIOC_S_STD",
-        [_IOC_NR(VIDIOC_ENUMSTD)]        = "VIDIOC_ENUMSTD",
-        [_IOC_NR(VIDIOC_ENUMINPUT)]      = "VIDIOC_ENUMINPUT",
-        [_IOC_NR(VIDIOC_G_CTRL)]         = "VIDIOC_G_CTRL",
-        [_IOC_NR(VIDIOC_S_CTRL)]         = "VIDIOC_S_CTRL",
-        [_IOC_NR(VIDIOC_G_TUNER)]        = "VIDIOC_G_TUNER",
-        [_IOC_NR(VIDIOC_S_TUNER)]        = "VIDIOC_S_TUNER",
-        [_IOC_NR(VIDIOC_G_AUDIO)]        = "VIDIOC_G_AUDIO",
-        [_IOC_NR(VIDIOC_S_AUDIO)]        = "VIDIOC_S_AUDIO",
-        [_IOC_NR(VIDIOC_QUERYCTRL)]      = "VIDIOC_QUERYCTRL",
-        [_IOC_NR(VIDIOC_QUERYMENU)]      = "VIDIOC_QUERYMENU",
-        [_IOC_NR(VIDIOC_G_INPUT)]        = "VIDIOC_G_INPUT",
-        [_IOC_NR(VIDIOC_S_INPUT)]        = "VIDIOC_S_INPUT",
-        [_IOC_NR(VIDIOC_G_OUTPUT)]       = "VIDIOC_G_OUTPUT",
-        [_IOC_NR(VIDIOC_S_OUTPUT)]       = "VIDIOC_S_OUTPUT",
-        [_IOC_NR(VIDIOC_ENUMOUTPUT)]     = "VIDIOC_ENUMOUTPUT",
-        [_IOC_NR(VIDIOC_G_AUDOUT)]       = "VIDIOC_G_AUDOUT",
-        [_IOC_NR(VIDIOC_S_AUDOUT)]       = "VIDIOC_S_AUDOUT",
-        [_IOC_NR(VIDIOC_G_MODULATOR)]    = "VIDIOC_G_MODULATOR",
-        [_IOC_NR(VIDIOC_S_MODULATOR)]    = "VIDIOC_S_MODULATOR",
-        [_IOC_NR(VIDIOC_G_FREQUENCY)]    = "VIDIOC_G_FREQUENCY",
-        [_IOC_NR(VIDIOC_S_FREQUENCY)]    = "VIDIOC_S_FREQUENCY",
-        [_IOC_NR(VIDIOC_CROPCAP)]        = "VIDIOC_CROPCAP",
-        [_IOC_NR(VIDIOC_G_CROP)]         = "VIDIOC_G_CROP",
-        [_IOC_NR(VIDIOC_S_CROP)]         = "VIDIOC_S_CROP",
-        [_IOC_NR(VIDIOC_G_JPEGCOMP)]     = "VIDIOC_G_JPEGCOMP",
-        [_IOC_NR(VIDIOC_S_JPEGCOMP)]     = "VIDIOC_S_JPEGCOMP",
-        [_IOC_NR(VIDIOC_QUERYSTD)]       = "VIDIOC_QUERYSTD",
-        [_IOC_NR(VIDIOC_TRY_FMT)]        = "VIDIOC_TRY_FMT",
+        [_IOC_NR(VIDIOC_LOG_STATUS)]       = "VIDIOC_LOG_STATUS"
 };
+#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
+
+static const char *v4l2_int_ioctls[] = {
+#ifdef HAVE_VIDEO_DECODER
+        [_IOC_NR(DECODER_GET_CAPABILITIES)]    = "DECODER_GET_CAPABILITIES",
+        [_IOC_NR(DECODER_GET_STATUS)]          = "DECODER_GET_STATUS",
+        [_IOC_NR(DECODER_SET_NORM)]            = "DECODER_SET_NORM",
+        [_IOC_NR(DECODER_SET_INPUT)]           = "DECODER_SET_INPUT",
+        [_IOC_NR(DECODER_SET_OUTPUT)]          = "DECODER_SET_OUTPUT",
+        [_IOC_NR(DECODER_ENABLE_OUTPUT)]       = "DECODER_ENABLE_OUTPUT",
+        [_IOC_NR(DECODER_SET_PICTURE)]         = "DECODER_SET_PICTURE",
+        [_IOC_NR(DECODER_SET_GPIO)]            = "DECODER_SET_GPIO",
+        [_IOC_NR(DECODER_INIT)]                = "DECODER_INIT",
+        [_IOC_NR(DECODER_SET_VBI_BYPASS)]      = "DECODER_SET_VBI_BYPASS",
+        [_IOC_NR(DECODER_DUMP)]                = "DECODER_DUMP",
+#endif
+        [_IOC_NR(AUDC_SET_RADIO)]              = "AUDC_SET_RADIO",
+        [_IOC_NR(AUDC_SET_INPUT)]              = "AUDC_SET_INPUT",
+
+        [_IOC_NR(TUNER_SET_TYPE_ADDR)]         = "TUNER_SET_TYPE_ADDR",
+        [_IOC_NR(TUNER_SET_STANDBY)]           = "TUNER_SET_STANDBY",
+        [_IOC_NR(TDA9887_SET_CONFIG)]          = "TDA9887_SET_CONFIG",
+
+        [_IOC_NR(VIDIOC_INT_S_REGISTER)]       = "VIDIOC_INT_S_REGISTER",
+        [_IOC_NR(VIDIOC_INT_G_REGISTER)]       = "VIDIOC_INT_G_REGISTER",
+        [_IOC_NR(VIDIOC_INT_RESET)]            = "VIDIOC_INT_RESET",
+        [_IOC_NR(VIDIOC_INT_AUDIO_CLOCK_FREQ)] = "VIDIOC_INT_AUDIO_CLOCK_FREQ",
+        [_IOC_NR(VIDIOC_INT_DECODE_VBI_LINE)]  = "VIDIOC_INT_DECODE_VBI_LINE",
+        [_IOC_NR(VIDIOC_INT_S_VBI_DATA)]       = "VIDIOC_INT_S_VBI_DATA",
+        [_IOC_NR(VIDIOC_INT_G_VBI_DATA)]       = "VIDIOC_INT_G_VBI_DATA",
+        [_IOC_NR(VIDIOC_INT_G_CHIP_IDENT)]     = "VIDIOC_INT_G_CHIP_IDENT",
+        [_IOC_NR(VIDIOC_INT_I2S_CLOCK_FREQ)]   = "VIDIOC_INT_I2S_CLOCK_FREQ"
+};
+#define V4L2_INT_IOCTLS ARRAY_SIZE(v4l2_int_ioctls)
+
+/* Common ioctl debug function. This function can be used by
+   external ioctl messages as well as internal V4L ioctl */
+void v4l_printk_ioctl(unsigned int cmd)
+{
+        char *dir;
+
+        switch (_IOC_DIR(cmd)) {
+        case _IOC_NONE:              dir = "--"; break;
+        case _IOC_READ:              dir = "r-"; break;
+        case _IOC_WRITE:             dir = "-w"; break;
+        case _IOC_READ | _IOC_WRITE: dir = "rw"; break;
+        default:                     dir = "*ERR*"; break;
+        }
+        switch (_IOC_TYPE(cmd)) {
+        case 'd':
+                printk("v4l2_int ioctl %s, dir=%s (0x%08x)\n",
+                       (_IOC_NR(cmd) < V4L2_INT_IOCTLS) ?
+                       v4l2_int_ioctls[_IOC_NR(cmd)] : "UNKNOWN", dir, cmd);
+                break;
+#ifdef HAVE_V4L1
+        case 'v':
+                printk("v4l1 ioctl %s, dir=%s (0x%08x)\n",
+                       (_IOC_NR(cmd) < V4L1_IOCTLS) ?
+                       v4l1_ioctls[_IOC_NR(cmd)] : "UNKNOWN", dir, cmd);
+                break;
+#endif
+        case 'V':
+                printk("v4l2 ioctl %s, dir=%s (0x%08x)\n",
+                       (_IOC_NR(cmd) < V4L2_IOCTLS) ?
+                       v4l2_ioctls[_IOC_NR(cmd)] : "UNKNOWN", dir, cmd);
+                break;
+
+        default:
+                printk("unknown ioctl '%c', dir=%s, #%d (0x%08x)\n",
+                       _IOC_TYPE(cmd), dir, _IOC_NR(cmd), cmd);
+        }
+}
 
 /* ----------------------------------------------------------------- */
 
@@ -255,7 +374,7 @@ EXPORT_SYMBOL(v4l2_prio_check);
 
 EXPORT_SYMBOL(v4l2_field_names);
 EXPORT_SYMBOL(v4l2_type_names);
-EXPORT_SYMBOL(v4l2_ioctl_names);
+EXPORT_SYMBOL(v4l_printk_ioctl);
 
 /*
  * Local variables:
diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index 6de5b0094b82..9a9902c56ae7 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -68,7 +68,8 @@ static void video_release(struct class_device *cd)
 {
         struct video_device *vfd = container_of(cd, struct video_device, class_dev);
 
-#if 1 /* needed until all drivers are fixed */
+#if 1
+        /* needed until all drivers are fixed */
         if (!vfd->release)
                 return;
 #endif
@@ -338,13 +339,14 @@ int video_register_device(struct video_device *vfd, int type, int nr)
         if (vfd->dev)
                 vfd->class_dev.dev = vfd->dev;
         vfd->class_dev.class       = &video_class;
-        vfd->class_dev.devt       = MKDEV(VIDEO_MAJOR, vfd->minor);
+        vfd->class_dev.devt        = MKDEV(VIDEO_MAJOR, vfd->minor);
         strlcpy(vfd->class_dev.class_id, vfd->devfs_name + 4, BUS_ID_SIZE);
         class_device_register(&vfd->class_dev);
         class_device_create_file(&vfd->class_dev,
-                                 &class_device_attr_name);
+                                &class_device_attr_name);
 
-#if 1 /* needed until all drivers are fixed */
+#if 1
+        /* needed until all drivers are fixed */
         if (!vfd->release)
                 printk(KERN_WARNING "videodev: \"%s\" has no release callback. "
                        "Please fix your driver for proper sysfs support, see "
diff --git a/drivers/media/video/w9966.c b/drivers/media/video/w9966.c
index c318ba32fbaf..b7b0afffd214 100644
--- a/drivers/media/video/w9966.c
+++ b/drivers/media/video/w9966.c
@@ -187,6 +187,7 @@ static struct file_operations w9966_fops = {
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
         .ioctl          = w9966_v4l_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .read           = w9966_v4l_read,
         .llseek         = no_llseek,
 };
diff --git a/drivers/media/video/wm8775.c b/drivers/media/video/wm8775.c
index bbfd55cd9948..c2e6d2e9f5f1 100644
--- a/drivers/media/video/wm8775.c
+++ b/drivers/media/video/wm8775.c
@@ -25,7 +25,6 @@
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/ioctl.h>
@@ -33,20 +32,12 @@
 #include <linux/i2c.h>
 #include <linux/i2c-id.h>
 #include <linux/videodev.h>
-#include <media/audiochip.h>
+#include <media/v4l2-common.h>
 
 MODULE_DESCRIPTION("wm8775 driver");
 MODULE_AUTHOR("Ulf Eklund, Hans Verkuil");
 MODULE_LICENSE("GPL");
 
-#define wm8775_err(fmt, arg...) do { \
-        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-#define wm8775_info(fmt, arg...) do { \
-        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
-               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
-
-
 static unsigned short normal_i2c[] = { 0x36 >> 1, I2C_CLIENT_END };
 
 
@@ -70,7 +61,7 @@ static int wm8775_write(struct i2c_client *client, int reg, u16 val)
         int i;
 
         if (reg < 0 || reg >= TOT_REGS) {
-                wm8775_err("Invalid register R%d\n", reg);
+                v4l_err(client, "Invalid register R%d\n", reg);
                 return -1;
         }
 
@@ -80,7 +71,7 @@ static int wm8775_write(struct i2c_client *client, int reg, u16 val)
                         return 0;
                 }
         }
-        wm8775_err("I2C: cannot write %03x to register R%d\n", val, reg);
+        v4l_err(client, "I2C: cannot write %03x to register R%d\n", val, reg);
         return -1;
 }
 
@@ -88,38 +79,53 @@ static int wm8775_command(struct i2c_client *client, unsigned int cmd,
                           void *arg)
 {
         struct wm8775_state *state = i2c_get_clientdata(client);
-        int *input = arg;
+        struct v4l2_audio *input = arg;
+        struct v4l2_control *ctrl = arg;
 
         switch (cmd) {
-        case AUDC_SET_INPUT:
+        case VIDIOC_S_AUDIO:
+                /* There are 4 inputs and one output. Zero or more inputs
+                   are multiplexed together to the output. Hence there are
+                   16 combinations.
+                   If only one input is active (the normal case) then the
+                   input values 1, 2, 4 or 8 should be used. */
+                if (input->index > 15) {
+                        v4l_err(client, "Invalid input %d.\n", input->index);
+                        return -EINVAL;
+                }
+                state->input = input->index;
+                if (state->muted)
+                        break;
                 wm8775_write(client, R21, 0x0c0);
                 wm8775_write(client, R14, 0x1d4);
                 wm8775_write(client, R15, 0x1d4);
+                wm8775_write(client, R21, 0x100 + state->input);
+                break;
 
-                if (*input == AUDIO_RADIO) {
-                        wm8775_write(client, R21, 0x108);
-                        state->input = 8;
-                        state->muted = 0;
-                        break;
-                }
-                if (*input == AUDIO_MUTE) {
-                        state->muted = 1;
-                        break;
-                }
-                if (*input == AUDIO_UNMUTE) {
+        case VIDIOC_G_AUDIO:
+                memset(input, 0, sizeof(*input));
+                input->index = state->input;
+                break;
+
+        case VIDIOC_G_CTRL:
+                if (ctrl->id != V4L2_CID_AUDIO_MUTE)
+                        return -EINVAL;
+                ctrl->value = state->muted;
+                break;
+
+        case VIDIOC_S_CTRL:
+                if (ctrl->id != V4L2_CID_AUDIO_MUTE)
+                        return -EINVAL;
+                state->muted = ctrl->value;
+                wm8775_write(client, R21, 0x0c0);
+                wm8775_write(client, R14, 0x1d4);
+                wm8775_write(client, R15, 0x1d4);
+                if (!state->muted)
                         wm8775_write(client, R21, 0x100 + state->input);
-                        state->muted = 0;
-                        break;
-                }
-                /* All other inputs... */
-                wm8775_write(client, R21, 0x102);
-                state->input = 2;
-                state->muted = 0;
                 break;
 
         case VIDIOC_LOG_STATUS:
-                wm8775_info("Input: %s%s\n",
-                            state->input == 8 ? "radio" : "default",
+                v4l_info(client, "Input: %d%s\n", state->input,
                             state->muted ? " (muted)" : "");
                 break;
 
@@ -170,7 +176,7 @@ static int wm8775_attach(struct i2c_adapter *adapter, int address, int kind)
         client->driver = &i2c_driver;
         snprintf(client->name, sizeof(client->name) - 1, "wm8775");
 
-        wm8775_info("chip found @ 0x%x (%s)\n", address << 1, adapter->name);
+        v4l_info(client, "chip found @ 0x%x (%s)\n", address << 1, adapter->name);
 
         state = kmalloc(sizeof(struct wm8775_state), GFP_KERNEL);
         if (state == NULL) {
@@ -206,11 +212,7 @@ static int wm8775_attach(struct i2c_adapter *adapter, int address, int kind)
 
 static int wm8775_probe(struct i2c_adapter *adapter)
 {
-#ifdef I2C_CLASS_TV_ANALOG
         if (adapter->class & I2C_CLASS_TV_ANALOG)
-#else
-        if (adapter->id == I2C_HW_B_BT848)
-#endif
                 return i2c_probe(adapter, &addr_data, wm8775_attach);
         return 0;
 }
@@ -235,12 +237,10 @@ static struct i2c_driver i2c_driver = {
         .driver = {
                 .name = "wm8775",
         },
-
-        .id = I2C_DRIVERID_WM8775,
-
+        .id             = I2C_DRIVERID_WM8775,
         .attach_adapter = wm8775_probe,
-        .detach_client = wm8775_detach,
-        .command = wm8775_command,
+        .detach_client  = wm8775_detach,
+        .command        = wm8775_command,
 };
 
 
diff --git a/drivers/media/video/zoran_driver.c b/drivers/media/video/zoran_driver.c
index 4034f1b45366..15283f44e79f 100644
--- a/drivers/media/video/zoran_driver.c
+++ b/drivers/media/video/zoran_driver.c
@@ -4678,6 +4678,7 @@ static struct file_operations zoran_fops = {
         .open = zoran_open,
         .release = zoran_close,
         .ioctl = zoran_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek = no_llseek,
         .read = zoran_read,
         .write = zoran_write,
diff --git a/drivers/media/video/zr36120.c b/drivers/media/video/zr36120.c
index 07286816d7df..d4c633b8a7f5 100644
--- a/drivers/media/video/zr36120.c
+++ b/drivers/media/video/zr36120.c
@@ -1490,6 +1490,7 @@ static struct video_device zr36120_template=
         .write          = zoran_write,
         .poll           = zoran_poll,
         .ioctl          = zoran_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .mmap           = zoran_mmap,
         .minor          = -1,
 };
diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c
index 5b1febed3133..b09fb6307153 100644
--- a/drivers/message/i2o/i2o_block.c
+++ b/drivers/message/i2o/i2o_block.c
@@ -662,6 +662,13 @@ static int i2o_block_release(struct inode *inode, struct file *file)
         return 0;
 }
 
+static int i2o_block_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        i2o_block_biosparam(get_capacity(bdev->bd_disk),
+                            &geo->cylinders, &geo->heads, &geo->sectors);
+        return 0;
+}
+
 /**
  *      i2o_block_ioctl - Issue device specific ioctl calls.
  *      @cmd: ioctl command
@@ -676,7 +683,6 @@ static int i2o_block_ioctl(struct inode *inode, struct file *file,
 {
         struct gendisk *disk = inode->i_bdev->bd_disk;
         struct i2o_block_device *dev = disk->private_data;
-        void __user *argp = (void __user *)arg;
 
         /* Anyone capable of this syscall can do *real bad* things */
 
@@ -684,15 +690,6 @@ static int i2o_block_ioctl(struct inode *inode, struct file *file,
                 return -EPERM;
 
         switch (cmd) {
-        case HDIO_GETGEO:
-                {
-                        struct hd_geometry g;
-                        i2o_block_biosparam(get_capacity(disk),
-                                            &g.cylinders, &g.heads, &g.sectors);
-                        g.start = get_start_sect(inode->i_bdev);
-                        return copy_to_user(argp, &g, sizeof(g)) ? -EFAULT : 0;
-                }
-
         case BLKI2OGRSTRAT:
                 return put_user(dev->rcache, (int __user *)arg);
         case BLKI2OGWSTRAT:
@@ -962,6 +959,7 @@ static struct block_device_operations i2o_block_fops = {
         .open = i2o_block_open,
         .release = i2o_block_release,
         .ioctl = i2o_block_ioctl,
+        .getgeo = i2o_block_getgeo,
         .media_changed = i2o_block_media_changed
 };
 
diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c
index e335d54c4659..b42e0fbab59b 100644
--- a/drivers/mfd/ucb1x00-core.c
+++ b/drivers/mfd/ucb1x00-core.c
@@ -27,7 +27,6 @@
 
 #include <asm/dma.h>
 #include <asm/hardware.h>
-#include <asm/irq.h>
 
 #include "ucb1x00.h"
 
@@ -507,14 +506,14 @@ static int ucb1x00_probe(struct mcp *mcp)
                 goto err_free;
         }
 
-        ret = request_irq(ucb->irq, ucb1x00_irq, 0, "UCB1x00", ucb);
+        ret = request_irq(ucb->irq, ucb1x00_irq, SA_TRIGGER_RISING,
+                          "UCB1x00", ucb);
         if (ret) {
                 printk(KERN_ERR "ucb1x00: unable to grab irq%d: %d\n",
                         ucb->irq, ret);
                 goto err_free;
         }
 
-        set_irq_type(ucb->irq, IRQT_RISING);
         mcp_set_drvdata(mcp, ucb);
 
         ret = class_device_register(&ucb->cdev);
diff --git a/drivers/mfd/ucb1x00-ts.c b/drivers/mfd/ucb1x00-ts.c
index 551061c2eadf..79fd062ccb34 100644
--- a/drivers/mfd/ucb1x00-ts.c
+++ b/drivers/mfd/ucb1x00-ts.c
@@ -32,7 +32,6 @@
 #include <linux/suspend.h>
 #include <linux/slab.h>
 #include <linux/kthread.h>
-#include <linux/delay.h>
 
 #include <asm/dma.h>
 #include <asm/semaphore.h>
diff --git a/drivers/mmc/mmc_block.c b/drivers/mmc/mmc_block.c
index f43cdfcbfd2c..f2c42b13945d 100644
--- a/drivers/mmc/mmc_block.c
+++ b/drivers/mmc/mmc_block.c
@@ -113,31 +113,18 @@ static int mmc_blk_release(struct inode *inode, struct file *filp)
 }
 
 static int
-mmc_blk_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, unsigned long arg)
+mmc_blk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct block_device *bdev = inode->i_bdev;
-
-        if (cmd == HDIO_GETGEO) {
-                struct hd_geometry geo;
-
-                memset(&geo, 0, sizeof(struct hd_geometry));
-
-                geo.cylinders   = get_capacity(bdev->bd_disk) / (4 * 16);
-                geo.heads       = 4;
-                geo.sectors     = 16;
-                geo.start       = get_start_sect(bdev);
-
-                return copy_to_user((void __user *)arg, &geo, sizeof(geo))
-                        ? -EFAULT : 0;
-        }
-
-        return -ENOTTY;
+        geo->cylinders = get_capacity(bdev->bd_disk) / (4 * 16);
+        geo->heads = 4;
+        geo->sectors = 16;
+        return 0;
 }
 
 static struct block_device_operations mmc_bdops = {
         .open                   = mmc_blk_open,
         .release                = mmc_blk_release,
-        .ioctl                  = mmc_blk_ioctl,
+        .getgeo                 = mmc_blk_getgeo,
         .owner                  = THIS_MODULE,
 };
 
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 339cb1218eaa..7f3ff500b68e 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -194,6 +194,14 @@ static int blktrans_release(struct inode *i, struct file *f)
         return ret;
 }
 
+static int blktrans_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct mtd_blktrans_dev *dev = bdev->bd_disk->private_data;
+
+        if (dev->tr->getgeo)
+                return dev->tr->getgeo(dev, geo);
+        return -ENOTTY;
+}
 
 static int blktrans_ioctl(struct inode *inode, struct file *file,
                               unsigned int cmd, unsigned long arg)
@@ -207,22 +215,6 @@ static int blktrans_ioctl(struct inode *inode, struct file *file,
                         return tr->flush(dev);
                 /* The core code did the work, we had nothing to do. */
                 return 0;
-
-        case HDIO_GETGEO:
-                if (tr->getgeo) {
-                        struct hd_geometry g;
-                        int ret;
-
-                        memset(&g, 0, sizeof(g));
-                        ret = tr->getgeo(dev, &g);
-                        if (ret)
-                                return ret;
-
-                        g.start = get_start_sect(inode->i_bdev);
-                        if (copy_to_user((void __user *)arg, &g, sizeof(g)))
-                                return -EFAULT;
-                        return 0;
-                } /* else */
         default:
                 return -ENOTTY;
         }
@@ -233,6 +225,7 @@ struct block_device_operations mtd_blktrans_ops = {
         .open           = blktrans_open,
         .release        = blktrans_release,
         .ioctl          = blktrans_ioctl,
+        .getgeo         = blktrans_getgeo,
 };
 
 int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
diff --git a/drivers/mtd/onenand/generic.c b/drivers/mtd/onenand/generic.c
index 45c077d0f063..af06a80f44de 100644
--- a/drivers/mtd/onenand/generic.c
+++ b/drivers/mtd/onenand/generic.c
@@ -14,6 +14,7 @@
 
 #include <linux/module.h>
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/platform_device.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/onenand.h>
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 20ce212638fc..a3e00a4635a5 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -18,6 +18,7 @@
 #include <linux/mtd/blktrans.h>
 #include <linux/mtd/mtd.h>
 #include <linux/vmalloc.h>
+#include <linux/slab.h>
 #include <linux/jiffies.h>
 
 #include <asm/types.h>
diff --git a/drivers/net/3c503.c b/drivers/net/3c503.c
index 5c5eebdb6914..dcc98afa65d7 100644
--- a/drivers/net/3c503.c
+++ b/drivers/net/3c503.c
@@ -148,14 +148,6 @@ el2_pio_probe(struct net_device *dev)
     return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        /* NB: el2_close() handles free_irq */
-        release_region(dev->base_addr, EL2_IO_EXTENT);
-        if (ei_status.mem)
-                iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init el2_probe(int unit)
 {
@@ -726,6 +718,14 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        /* NB: el2_close() handles free_irq */
+        release_region(dev->base_addr, EL2_IO_EXTENT);
+        if (ei_status.mem)
+                iounmap(ei_status.mem);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/3c527.h b/drivers/net/3c527.h
index c10f009ce9b6..53b5b071df08 100644
--- a/drivers/net/3c527.h
+++ b/drivers/net/3c527.h
@@ -32,43 +32,43 @@
 
 struct mc32_mailbox
 {
-        u16     mbox __attribute((packed));
-        u16     data[1] __attribute((packed));
-};
+        u16 mbox;
+        u16 data[1];
+} __attribute((packed));
 
 struct skb_header
 {
-        u8      status __attribute((packed));
-        u8      control __attribute((packed));
-        u16     next __attribute((packed));     /* Do not change! */
-        u16     length __attribute((packed));
-        u32     data __attribute((packed));
-};
+        u8 status;
+        u8 control;
+        u16 next;       /* Do not change! */
+        u16 length;
+        u32 data;
+} __attribute((packed));
 
 struct mc32_stats
 {
         /* RX Errors */
-        u32     rx_crc_errors       __attribute((packed));      
-        u32     rx_alignment_errors  __attribute((packed));     
-        u32     rx_overrun_errors    __attribute((packed));
-        u32     rx_tooshort_errors  __attribute((packed));
-        u32     rx_toolong_errors   __attribute((packed));
-        u32     rx_outofresource_errors  __attribute((packed)); 
+        u32 rx_crc_errors;
+        u32 rx_alignment_errors;
+        u32 rx_overrun_errors;
+        u32 rx_tooshort_errors;
+        u32 rx_toolong_errors;
+        u32 rx_outofresource_errors;
 
-        u32     rx_discarded   __attribute((packed));  /* via card pattern match filter */ 
+        u32 rx_discarded;  /* via card pattern match filter */
 
         /* TX Errors */
-        u32     tx_max_collisions __attribute((packed)); 
-        u32     tx_carrier_errors __attribute((packed)); 
-        u32     tx_underrun_errors __attribute((packed)); 
-        u32     tx_cts_errors     __attribute((packed)); 
-        u32     tx_timeout_errors __attribute((packed)) ;
+        u32 tx_max_collisions;
+        u32 tx_carrier_errors;
+        u32 tx_underrun_errors;
+        u32 tx_cts_errors;
+        u32 tx_timeout_errors;
         
         /* various cruft */
-        u32     dataA[6] __attribute((packed));   
-        u16     dataB[5] __attribute((packed));   
-        u32     dataC[14] __attribute((packed));        
-};
+        u32 dataA[6];
+        u16 dataB[5];
+        u32 dataC[14];
+} __attribute((packed));
 
 #define STATUS_MASK     0x0F
 #define COMPLETED       (1<<7)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e2fa29b612cd..733bc25b2bf9 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -129,7 +129,7 @@ config NET_SB1000
 
           If you don't have this card, of course say N.
 
-        source "drivers/net/arcnet/Kconfig"
+source "drivers/net/arcnet/Kconfig"
 
 source "drivers/net/phy/Kconfig"
 
@@ -844,7 +844,7 @@ config SMC9194
 
 config DM9000
         tristate "DM9000 support"
-        depends on ARM && NET_ETHERNET
+        depends on (ARM || MIPS) && NET_ETHERNET
         select CRC32
         select MII
         ---help---
@@ -1374,7 +1374,7 @@ config FORCEDETH
 
 config CS89x0
         tristate "CS89x0 support"
-        depends on (NET_PCI && (ISA || ARCH_IXDP2X01)) || ARCH_PNX0105
+        depends on NET_PCI && (ISA || ARCH_IXDP2X01 || ARCH_PNX010X)
         ---help---
           Support for CS89x0 chipset based Ethernet cards. If you have a
           network (Ethernet) card of this type, say Y and read the
diff --git a/drivers/net/ac3200.c b/drivers/net/ac3200.c
index 8a0af5453e21..7952dc6d77e3 100644
--- a/drivers/net/ac3200.c
+++ b/drivers/net/ac3200.c
@@ -123,14 +123,6 @@ static int __init do_ac3200_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        /* Someday free_irq may be in ac_close_card() */
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr, AC_IO_EXTENT);
-        iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init ac3200_probe(int unit)
 {
@@ -406,6 +398,14 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        /* Someday free_irq may be in ac_close_card() */
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr, AC_IO_EXTENT);
+        iounmap(ei_status.mem);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 015c7f1d1bc0..f20bb85c1ea5 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -205,7 +205,7 @@ struct bonding {
  *
  * Caller must hold bond lock for read
  */
-extern inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct net_device *slave_dev)
+static inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct net_device *slave_dev)
 {
         struct slave *slave = NULL;
         int i;
@@ -219,7 +219,7 @@ extern inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct n
         return slave;
 }
 
-extern inline struct bonding *bond_get_bond_by_slave(struct slave *slave)
+static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)
 {
         if (!slave || !slave->dev->master) {
                 return NULL;
@@ -228,13 +228,13 @@ extern inline struct bonding *bond_get_bond_by_slave(struct slave *slave)
         return (struct bonding *)slave->dev->master->priv;
 }
 
-extern inline void bond_set_slave_inactive_flags(struct slave *slave)
+static inline void bond_set_slave_inactive_flags(struct slave *slave)
 {
         slave->state = BOND_STATE_BACKUP;
         slave->dev->flags |= IFF_NOARP;
 }
 
-extern inline void bond_set_slave_active_flags(struct slave *slave)
+static inline void bond_set_slave_active_flags(struct slave *slave)
 {
         slave->state = BOND_STATE_ACTIVE;
         slave->dev->flags &= ~IFF_NOARP;
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
index a6078ad9b654..907c01009746 100644
--- a/drivers/net/cs89x0.c
+++ b/drivers/net/cs89x0.c
@@ -175,7 +175,7 @@ static unsigned int cs8900_irq_map[] = {1,0,0,0};
 #include <asm/irq.h>
 static unsigned int netcard_portlist[] __initdata = {IXDP2X01_CS8900_VIRT_BASE, 0};
 static unsigned int cs8900_irq_map[] = {IRQ_IXDP2X01_CS8900, 0, 0, 0};
-#elif defined(CONFIG_ARCH_PNX0105)
+#elif defined(CONFIG_ARCH_PNX010X)
 #include <asm/irq.h>
 #include <asm/arch/gpio.h>
 #define CIRRUS_DEFAULT_BASE     IO_ADDRESS(EXT_STATIC2_s0_BASE + 0x200000)      /* = Physical address 0x48200000 */
@@ -338,30 +338,86 @@ out:
 }
 #endif
 
+#if defined(CONFIG_ARCH_IXDP2X01)
 static int
-readreg(struct net_device *dev, int portno)
+readword(unsigned long base_addr, int portno)
 {
-        outw(portno, dev->base_addr + ADD_PORT);
-        return inw(dev->base_addr + DATA_PORT);
+        return (u16)__raw_readl(base_addr + (portno << 1));
 }
 
 static void
-writereg(struct net_device *dev, int portno, int value)
+writeword(unsigned long base_addr, int portno, int value)
 {
-        outw(portno, dev->base_addr + ADD_PORT);
-        outw(value, dev->base_addr + DATA_PORT);
+        __raw_writel((u16)value, base_addr + (portno << 1));
+}
+#else
+#if defined(CONFIG_ARCH_PNX010X)
+static int
+readword(unsigned long base_addr, int portno)
+{
+        return inw(base_addr + (portno << 1));
+}
+
+static void
+writeword(unsigned long base_addr, int portno, int value)
+{
+        outw(value, base_addr + (portno << 1));
+}
+#else
+static int
+readword(unsigned long base_addr, int portno)
+{
+        return inw(base_addr + portno);
+}
+
+static void
+writeword(unsigned long base_addr, int portno, int value)
+{
+        outw(value, base_addr + portno);
+}
+#endif
+#endif
+
+static void
+readwords(unsigned long base_addr, int portno, void *buf, int length)
+{
+        u8 *buf8 = (u8 *)buf;
+
+        do {
+                u32 tmp32;
+
+                tmp32 = readword(base_addr, portno);
+                *buf8++ = (u8)tmp32;
+                *buf8++ = (u8)(tmp32 >> 8);
+        } while (--length);
+}
+
+static void
+writewords(unsigned long base_addr, int portno, void *buf, int length)
+{
+        u8 *buf8 = (u8 *)buf;
+
+        do {
+                u32 tmp32;
+
+                tmp32 = *buf8++;
+                tmp32 |= (*buf8++) << 8;
+                writeword(base_addr, portno, tmp32);
+        } while (--length);
 }
 
 static int
-readword(struct net_device *dev, int portno)
+readreg(struct net_device *dev, int regno)
 {
-        return inw(dev->base_addr + portno);
+        writeword(dev->base_addr, ADD_PORT, regno);
+        return readword(dev->base_addr, DATA_PORT);
 }
 
 static void
-writeword(struct net_device *dev, int portno, int value)
+writereg(struct net_device *dev, int regno, int value)
 {
-        outw(value, dev->base_addr + portno);
+        writeword(dev->base_addr, ADD_PORT, regno);
+        writeword(dev->base_addr, DATA_PORT, value);
 }
 
 static int __init
@@ -456,7 +512,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
 #endif
         }
 
-#ifdef CONFIG_ARCH_PNX0105
+#ifdef CONFIG_ARCH_PNX010X
         initialize_ebi();
 
         /* Map GPIO registers for the pins connected to the CS8900a. */
@@ -491,8 +547,8 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
 
 #ifdef CONFIG_SH_HICOSH4
         /* truely reset the chip */
-        outw(0x0114, ioaddr + ADD_PORT);
-        outw(0x0040, ioaddr + DATA_PORT);
+        writeword(ioaddr, ADD_PORT, 0x0114);
+        writeword(ioaddr, DATA_PORT, 0x0040);
 #endif
 
         /* if they give us an odd I/O address, then do ONE write to
@@ -503,24 +559,24 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
                 if (net_debug > 1)
                         printk(KERN_INFO "%s: odd ioaddr 0x%x\n", dev->name, ioaddr);
                 if ((ioaddr & 2) != 2)
-                        if ((inw((ioaddr & ~3)+ ADD_PORT) & ADD_MASK) != ADD_SIG) {
+                        if ((readword(ioaddr & ~3, ADD_PORT) & ADD_MASK) != ADD_SIG) {
                                 printk(KERN_ERR "%s: bad signature 0x%x\n",
-                                        dev->name, inw((ioaddr & ~3)+ ADD_PORT));
+                                        dev->name, readword(ioaddr & ~3, ADD_PORT));
                                 retval = -ENODEV;
                                 goto out2;
                         }
         }
-        printk(KERN_DEBUG "PP_addr at %x: 0x%x\n",
-                        ioaddr + ADD_PORT, inw(ioaddr + ADD_PORT));
+        printk(KERN_DEBUG "PP_addr at %x[%x]: 0x%x\n",
+                        ioaddr, ADD_PORT, readword(ioaddr, ADD_PORT));
 
         ioaddr &= ~3;
-        outw(PP_ChipID, ioaddr + ADD_PORT);
+        writeword(ioaddr, ADD_PORT, PP_ChipID);
 
-        tmp = inw(ioaddr + DATA_PORT);
+        tmp = readword(ioaddr, DATA_PORT);
         if (tmp != CHIP_EISA_ID_SIG) {
-                printk(KERN_DEBUG "%s: incorrect signature at %x: 0x%x!="
+                printk(KERN_DEBUG "%s: incorrect signature at %x[%x]: 0x%x!="
                         CHIP_EISA_ID_SIG_STR "\n",
-                        dev->name, ioaddr + DATA_PORT, tmp);
+                        dev->name, ioaddr, DATA_PORT, tmp);
                 retval = -ENODEV;
                 goto out2;
         }
@@ -724,7 +780,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
         } else {
                 i = lp->isa_config & INT_NO_MASK;
                 if (lp->chip_type == CS8900) {
-#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX0105)
+#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX010X)
                         i = cs8900_irq_map[0];
 #else
                         /* Translate the IRQ using the IRQ mapping table. */
@@ -790,7 +846,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
                 goto out3;
         return 0;
 out3:
-        outw(PP_ChipID, dev->base_addr + ADD_PORT);
+        writeword(dev->base_addr, ADD_PORT, PP_ChipID);
 out2:
         release_region(ioaddr & ~3, NETCARD_IO_EXTENT);
 out1:
@@ -970,11 +1026,11 @@ void  __init reset_chip(struct net_device *dev)
 #ifndef CONFIG_ARCH_IXDP2X01
         if (lp->chip_type != CS8900) {
                 /* Hardware problem requires PNP registers to be reconfigured after a reset */
-                outw(PP_CS8920_ISAINT, ioaddr + ADD_PORT);
+                writeword(ioaddr, ADD_PORT, PP_CS8920_ISAINT);
                 outb(dev->irq, ioaddr + DATA_PORT);
                 outb(0,      ioaddr + DATA_PORT + 1);
 
-                outw(PP_CS8920_ISAMemB, ioaddr + ADD_PORT);
+                writeword(ioaddr, ADD_PORT, PP_CS8920_ISAMemB);
                 outb((dev->mem_start >> 16) & 0xff, ioaddr + DATA_PORT);
                 outb((dev->mem_start >> 8) & 0xff,   ioaddr + DATA_PORT + 1);
         }
@@ -1104,8 +1160,8 @@ send_test_pkt(struct net_device *dev)
         memcpy(test_packet,          dev->dev_addr, ETH_ALEN);
         memcpy(test_packet+ETH_ALEN, dev->dev_addr, ETH_ALEN);
 
-        writeword(dev, TX_CMD_PORT, TX_AFTER_ALL);
-        writeword(dev, TX_LEN_PORT, ETH_ZLEN);
+        writeword(dev->base_addr, TX_CMD_PORT, TX_AFTER_ALL);
+        writeword(dev->base_addr, TX_LEN_PORT, ETH_ZLEN);
 
         /* Test to see if the chip has allocated memory for the packet */
         while (jiffies - timenow < 5)
@@ -1115,7 +1171,7 @@ send_test_pkt(struct net_device *dev)
                 return 0;       /* this shouldn't happen */
 
         /* Write the contents of the packet */
-        outsw(dev->base_addr + TX_FRAME_PORT,test_packet,(ETH_ZLEN+1) >>1);
+        writewords(dev->base_addr, TX_FRAME_PORT,test_packet,(ETH_ZLEN+1) >>1);
 
         if (net_debug > 1) printk("Sending test packet ");
         /* wait a couple of jiffies for packet to be received */
@@ -1200,7 +1256,7 @@ net_open(struct net_device *dev)
         int i;
         int ret;
 
-#if !defined(CONFIG_SH_HICOSH4) && !defined(CONFIG_ARCH_PNX0105) /* uses irq#1, so this won't work */
+#if !defined(CONFIG_SH_HICOSH4) && !defined(CONFIG_ARCH_PNX010X) /* uses irq#1, so this won't work */
         if (dev->irq < 2) {
                 /* Allow interrupts to be generated by the chip */
 /* Cirrus' release had this: */
@@ -1231,7 +1287,7 @@ net_open(struct net_device *dev)
         else
 #endif
         {
-#if !defined(CONFIG_ARCH_IXDP2X01) && !defined(CONFIG_ARCH_PNX0105)
+#if !defined(CONFIG_ARCH_IXDP2X01) && !defined(CONFIG_ARCH_PNX010X)
                 if (((1 << dev->irq) & lp->irq_map) == 0) {
                         printk(KERN_ERR "%s: IRQ %d is not in our map of allowable IRQs, which is %x\n",
                                dev->name, dev->irq, lp->irq_map);
@@ -1316,7 +1372,7 @@ net_open(struct net_device *dev)
         case A_CNF_MEDIA_10B_2: result = lp->adapter_cnf & A_CNF_10B_2; break;
         default: result = lp->adapter_cnf & (A_CNF_10B_T | A_CNF_AUI | A_CNF_10B_2);
         }
-#ifdef CONFIG_ARCH_PNX0105
+#ifdef CONFIG_ARCH_PNX010X
         result = A_CNF_10B_T;
 #endif
         if (!result) {
@@ -1457,8 +1513,8 @@ static int net_send_packet(struct sk_buff *skb, struct net_device *dev)
         netif_stop_queue(dev);
 
         /* initiate a transmit sequence */
-        writeword(dev, TX_CMD_PORT, lp->send_cmd);
-        writeword(dev, TX_LEN_PORT, skb->len);
+        writeword(dev->base_addr, TX_CMD_PORT, lp->send_cmd);
+        writeword(dev->base_addr, TX_LEN_PORT, skb->len);
 
         /* Test to see if the chip has allocated memory for the packet */
         if ((readreg(dev, PP_BusST) & READY_FOR_TX_NOW) == 0) {
@@ -1472,7 +1528,7 @@ static int net_send_packet(struct sk_buff *skb, struct net_device *dev)
                 return 1;
         }
         /* Write the contents of the packet */
-        outsw(dev->base_addr + TX_FRAME_PORT,skb->data,(skb->len+1) >>1);
+        writewords(dev->base_addr, TX_FRAME_PORT,skb->data,(skb->len+1) >>1);
         spin_unlock_irq(&lp->lock);
         lp->stats.tx_bytes += skb->len;
         dev->trans_start = jiffies;
@@ -1512,7 +1568,7 @@ static irqreturn_t net_interrupt(int irq, void *dev_id, struct pt_regs * regs)
            course, if you're on a slow machine, and packets are arriving
            faster than you can read them off, you're screwed.  Hasta la
            vista, baby!  */
-        while ((status = readword(dev, ISQ_PORT))) {
+        while ((status = readword(dev->base_addr, ISQ_PORT))) {
                 if (net_debug > 4)printk("%s: event=%04x\n", dev->name, status);
                 handled = 1;
                 switch(status & ISQ_EVENT_MASK) {
@@ -1606,8 +1662,8 @@ net_rx(struct net_device *dev)
         int status, length;
 
         int ioaddr = dev->base_addr;
-        status = inw(ioaddr + RX_FRAME_PORT);
-        length = inw(ioaddr + RX_FRAME_PORT);
+        status = readword(ioaddr, RX_FRAME_PORT);
+        length = readword(ioaddr, RX_FRAME_PORT);
 
         if ((status & RX_OK) == 0) {
                 count_rx_errors(status, lp);
@@ -1626,9 +1682,9 @@ net_rx(struct net_device *dev)
         skb_reserve(skb, 2);    /* longword align L3 header */
         skb->dev = dev;
 
-        insw(ioaddr + RX_FRAME_PORT, skb_put(skb, length), length >> 1);
+        readwords(ioaddr, RX_FRAME_PORT, skb_put(skb, length), length >> 1);
         if (length & 1)
-                skb->data[length-1] = inw(ioaddr + RX_FRAME_PORT);
+                skb->data[length-1] = readword(ioaddr, RX_FRAME_PORT);
 
         if (net_debug > 3) {
                 printk( "%s: received %d byte packet of type %x\n",
@@ -1901,7 +1957,7 @@ void
 cleanup_module(void)
 {
         unregister_netdev(dev_cs89x0);
-        outw(PP_ChipID, dev_cs89x0->base_addr + ADD_PORT);
+        writeword(dev_cs89x0->base_addr, ADD_PORT, PP_ChipID);
         release_region(dev_cs89x0->base_addr, NETCARD_IO_EXTENT);
         free_netdev(dev_cs89x0);
 }
diff --git a/drivers/net/cs89x0.h b/drivers/net/cs89x0.h
index decea264f121..bd954aaa636f 100644
--- a/drivers/net/cs89x0.h
+++ b/drivers/net/cs89x0.h
@@ -16,13 +16,6 @@
 
 #include <linux/config.h>
 
-#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX0105)
-/* IXDP2401/IXDP2801 uses dword-aligned register addressing */
-#define CS89x0_PORT(reg) ((reg) * 2)
-#else
-#define CS89x0_PORT(reg) (reg)
-#endif
-
 #define PP_ChipID 0x0000        /* offset   0h -> Corp -ID              */
                                 /* offset   2h -> Model/Product Number  */
                                 /* offset   3h -> Chip Revision Number  */
@@ -332,16 +325,16 @@
 #define RAM_SIZE        0x1000       /*  The card has 4k bytes or RAM */
 #define PKT_START PP_TxFrame  /*  Start of packet RAM */
 
-#define RX_FRAME_PORT   CS89x0_PORT(0x0000)
+#define RX_FRAME_PORT   0x0000
 #define TX_FRAME_PORT RX_FRAME_PORT
-#define TX_CMD_PORT     CS89x0_PORT(0x0004)
+#define TX_CMD_PORT     0x0004
 #define TX_NOW          0x0000       /*  Tx packet after   5 bytes copied */
 #define TX_AFTER_381    0x0040       /*  Tx packet after 381 bytes copied */
 #define TX_AFTER_ALL    0x00c0       /*  Tx packet after all bytes copied */
-#define TX_LEN_PORT     CS89x0_PORT(0x0006)
-#define ISQ_PORT        CS89x0_PORT(0x0008)
-#define ADD_PORT        CS89x0_PORT(0x000A)
-#define DATA_PORT       CS89x0_PORT(0x000C)
+#define TX_LEN_PORT     0x0006
+#define ISQ_PORT        0x0008
+#define ADD_PORT        0x000A
+#define DATA_PORT       0x000C
 
 #define EEPROM_WRITE_EN         0x00F0
 #define EEPROM_WRITE_DIS        0x0000
diff --git a/drivers/net/e1000/e1000_param.c b/drivers/net/e1000/e1000_param.c
index 38695d5b4637..ccbbe5ad8e0f 100644
--- a/drivers/net/e1000/e1000_param.c
+++ b/drivers/net/e1000/e1000_param.c
@@ -545,7 +545,7 @@ e1000_check_fiber_options(struct e1000_adapter *adapter)
 static void __devinit
 e1000_check_copper_options(struct e1000_adapter *adapter)
 {
-        int speed, dplx;
+        int speed, dplx, an;
         int bd = adapter->bd_number;
 
         { /* Speed */
@@ -641,8 +641,12 @@ e1000_check_copper_options(struct e1000_adapter *adapter)
                                          .p = an_list }}
                 };
 
-                int an = AutoNeg[bd];
-                e1000_validate_option(&an, &opt, adapter);
+                if (num_AutoNeg > bd) {
+                        an = AutoNeg[bd];
+                        e1000_validate_option(&an, &opt, adapter);
+                } else {
+                        an = opt.def;
+                }
                 adapter->hw.autoneg_advertised = an;
         }
 
diff --git a/drivers/net/e2100.c b/drivers/net/e2100.c
index f5a4dd7d8564..e5c5cd2a2712 100644
--- a/drivers/net/e2100.c
+++ b/drivers/net/e2100.c
@@ -140,13 +140,6 @@ static int  __init do_e2100_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        /* NB: e21_close() handles free_irq */
-        iounmap(ei_status.mem);
-        release_region(dev->base_addr, E21_IO_EXTENT);
-}
-
 #ifndef MODULE
 struct net_device * __init e2100_probe(int unit)
 {
@@ -463,6 +456,13 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        /* NB: e21_close() handles free_irq */
+        iounmap(ei_status.mem);
+        release_region(dev->base_addr, E21_IO_EXTENT);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/es3210.c b/drivers/net/es3210.c
index 50f8e23bb9e5..6b0ab1eac3fb 100644
--- a/drivers/net/es3210.c
+++ b/drivers/net/es3210.c
@@ -155,13 +155,6 @@ static int __init do_es_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr, ES_IO_EXTENT);
-        iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init es_probe(int unit)
 {
@@ -456,6 +449,13 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr, ES_IO_EXTENT);
+        iounmap(ei_status.mem);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index c39344adecce..3682ec61e8a8 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -101,6 +101,7 @@
  *      0.46: 20 Oct 2005: Add irq optimization modes.
  *      0.47: 26 Oct 2005: Add phyaddr 0 in phy scan.
  *      0.48: 24 Dec 2005: Disable TSO, bugfix for pci_map_single
+ *      0.49: 10 Dec 2005: Fix tso for large buffers.
  *
  * Known bugs:
  * We suspect that on some hardware no TX done interrupts are generated.
@@ -112,7 +113,7 @@
  * DEV_NEED_TIMERIRQ will not harm you on sane hardware, only generating a few
  * superfluous timer interrupts from the nic.
  */
-#define FORCEDETH_VERSION               "0.48"
+#define FORCEDETH_VERSION               "0.49"
 #define DRV_NAME                        "forcedeth"
 
 #include <linux/module.h>
@@ -349,6 +350,8 @@ typedef union _ring_type {
 #define NV_TX2_VALID            (1<<31)
 #define NV_TX2_TSO              (1<<28)
 #define NV_TX2_TSO_SHIFT        14
+#define NV_TX2_TSO_MAX_SHIFT    14
+#define NV_TX2_TSO_MAX_SIZE     (1<<NV_TX2_TSO_MAX_SHIFT)
 #define NV_TX2_CHECKSUM_L3      (1<<27)
 #define NV_TX2_CHECKSUM_L4      (1<<26)
 
@@ -408,15 +411,15 @@ typedef union _ring_type {
 #define NV_WATCHDOG_TIMEO       (5*HZ)
 
 #define RX_RING         128
-#define TX_RING         64
+#define TX_RING         256
 /* 
  * If your nic mysteriously hangs then try to reduce the limits
  * to 1/0: It might be required to set NV_TX_LASTPACKET in the
  * last valid ring entry. But this would be impossible to
  * implement - probably a disassembly error.
  */
-#define TX_LIMIT_STOP   63
-#define TX_LIMIT_START  62
+#define TX_LIMIT_STOP   255
+#define TX_LIMIT_START  254
 
 /* rx/tx mac addr + type + vlan + align + slack*/
 #define NV_RX_HEADERS           (64)
@@ -535,6 +538,7 @@ struct fe_priv {
         unsigned int next_tx, nic_tx;
         struct sk_buff *tx_skbuff[TX_RING];
         dma_addr_t tx_dma[TX_RING];
+        unsigned int tx_dma_len[TX_RING];
         u32 tx_flags;
 };
 
@@ -935,6 +939,7 @@ static void nv_init_tx(struct net_device *dev)
                 else
                         np->tx_ring.ex[i].FlagLen = 0;
                 np->tx_skbuff[i] = NULL;
+                np->tx_dma[i] = 0;
         }
 }
 
@@ -945,30 +950,27 @@ static int nv_init_ring(struct net_device *dev)
         return nv_alloc_rx(dev);
 }
 
-static void nv_release_txskb(struct net_device *dev, unsigned int skbnr)
+static int nv_release_txskb(struct net_device *dev, unsigned int skbnr)
 {
         struct fe_priv *np = netdev_priv(dev);
-        struct sk_buff *skb = np->tx_skbuff[skbnr];
-        unsigned int j, entry, fragments;
-                        
-        dprintk(KERN_INFO "%s: nv_release_txskb for skbnr %d, skb %p\n",
-                dev->name, skbnr, np->tx_skbuff[skbnr]);
-        
-        entry = skbnr;
-        if ((fragments = skb_shinfo(skb)->nr_frags) != 0) {
-                for (j = fragments; j >= 1; j--) {
-                        skb_frag_t *frag = &skb_shinfo(skb)->frags[j-1];
-                        pci_unmap_page(np->pci_dev, np->tx_dma[entry],
-                                       frag->size,
-                                       PCI_DMA_TODEVICE);
-                        entry = (entry - 1) % TX_RING;
-                }
+
+        dprintk(KERN_INFO "%s: nv_release_txskb for skbnr %d\n",
+                dev->name, skbnr);
+
+        if (np->tx_dma[skbnr]) {
+                pci_unmap_page(np->pci_dev, np->tx_dma[skbnr],
+                               np->tx_dma_len[skbnr],
+                               PCI_DMA_TODEVICE);
+                np->tx_dma[skbnr] = 0;
+        }
+
+        if (np->tx_skbuff[skbnr]) {
+                dev_kfree_skb_irq(np->tx_skbuff[skbnr]);
+                np->tx_skbuff[skbnr] = NULL;
+                return 1;
+        } else {
+                return 0;
         }
-        pci_unmap_single(np->pci_dev, np->tx_dma[entry],
-                         skb->len - skb->data_len,
-                         PCI_DMA_TODEVICE);
-        dev_kfree_skb_irq(skb);
-        np->tx_skbuff[skbnr] = NULL;
 }
 
 static void nv_drain_tx(struct net_device *dev)
@@ -981,10 +983,8 @@ static void nv_drain_tx(struct net_device *dev)
                         np->tx_ring.orig[i].FlagLen = 0;
                 else
                         np->tx_ring.ex[i].FlagLen = 0;
-                if (np->tx_skbuff[i]) {
-                        nv_release_txskb(dev, i);
+                if (nv_release_txskb(dev, i))
                         np->stats.tx_dropped++;
-                }
         }
 }
 
@@ -1021,68 +1021,105 @@ static void drain_ring(struct net_device *dev)
 static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
         struct fe_priv *np = netdev_priv(dev);
+        u32 tx_flags = 0;
         u32 tx_flags_extra = (np->desc_ver == DESC_VER_1 ? NV_TX_LASTPACKET : NV_TX2_LASTPACKET);
         unsigned int fragments = skb_shinfo(skb)->nr_frags;
-        unsigned int nr = (np->next_tx + fragments) % TX_RING;
+        unsigned int nr = (np->next_tx - 1) % TX_RING;
+        unsigned int start_nr = np->next_tx % TX_RING;
         unsigned int i;
+        u32 offset = 0;
+        u32 bcnt;
+        u32 size = skb->len-skb->data_len;
+        u32 entries = (size >> NV_TX2_TSO_MAX_SHIFT) + ((size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
+
+        /* add fragments to entries count */
+        for (i = 0; i < fragments; i++) {
+                entries += (skb_shinfo(skb)->frags[i].size >> NV_TX2_TSO_MAX_SHIFT) +
+                           ((skb_shinfo(skb)->frags[i].size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
+        }
 
         spin_lock_irq(&np->lock);
 
-        if ((np->next_tx - np->nic_tx + fragments) > TX_LIMIT_STOP) {
+        if ((np->next_tx - np->nic_tx + entries - 1) > TX_LIMIT_STOP) {
                 spin_unlock_irq(&np->lock);
                 netif_stop_queue(dev);
                 return NETDEV_TX_BUSY;
         }
 
-        np->tx_skbuff[nr] = skb;
-        
-        if (fragments) {
-                dprintk(KERN_DEBUG "%s: nv_start_xmit: buffer contains %d fragments\n", dev->name, fragments);
-                /* setup descriptors in reverse order */
-                for (i = fragments; i >= 1; i--) {
-                        skb_frag_t *frag = &skb_shinfo(skb)->frags[i-1];
-                        np->tx_dma[nr] = pci_map_page(np->pci_dev, frag->page, frag->page_offset, frag->size,
-                                                        PCI_DMA_TODEVICE);
+        /* setup the header buffer */
+        do {
+                bcnt = (size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : size;
+                nr = (nr + 1) % TX_RING;
+
+                np->tx_dma[nr] = pci_map_single(np->pci_dev, skb->data + offset, bcnt,
+                                                PCI_DMA_TODEVICE);
+                np->tx_dma_len[nr] = bcnt;
+
+                if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
+                        np->tx_ring.orig[nr].PacketBuffer = cpu_to_le32(np->tx_dma[nr]);
+                        np->tx_ring.orig[nr].FlagLen = cpu_to_le32((bcnt-1) | tx_flags);
+                } else {
+                        np->tx_ring.ex[nr].PacketBufferHigh = cpu_to_le64(np->tx_dma[nr]) >> 32;
+                        np->tx_ring.ex[nr].PacketBufferLow = cpu_to_le64(np->tx_dma[nr]) & 0x0FFFFFFFF;
+                        np->tx_ring.ex[nr].FlagLen = cpu_to_le32((bcnt-1) | tx_flags);
+                }
+                tx_flags = np->tx_flags;
+                offset += bcnt;
+                size -= bcnt;
+        } while(size);
+
+        /* setup the fragments */
+        for (i = 0; i < fragments; i++) {
+                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
+                u32 size = frag->size;
+                offset = 0;
+
+                do {
+                        bcnt = (size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : size;
+                        nr = (nr + 1) % TX_RING;
+
+                        np->tx_dma[nr] = pci_map_page(np->pci_dev, frag->page, frag->page_offset+offset, bcnt,
+                                                      PCI_DMA_TODEVICE);
+                        np->tx_dma_len[nr] = bcnt;
 
                         if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
                                 np->tx_ring.orig[nr].PacketBuffer = cpu_to_le32(np->tx_dma[nr]);
-                                np->tx_ring.orig[nr].FlagLen = cpu_to_le32( (frag->size-1) | np->tx_flags | tx_flags_extra);
+                                np->tx_ring.orig[nr].FlagLen = cpu_to_le32((bcnt-1) | tx_flags);
                         } else {
                                 np->tx_ring.ex[nr].PacketBufferHigh = cpu_to_le64(np->tx_dma[nr]) >> 32;
                                 np->tx_ring.ex[nr].PacketBufferLow = cpu_to_le64(np->tx_dma[nr]) & 0x0FFFFFFFF;
-                                np->tx_ring.ex[nr].FlagLen = cpu_to_le32( (frag->size-1) | np->tx_flags | tx_flags_extra);
+                                np->tx_ring.ex[nr].FlagLen = cpu_to_le32((bcnt-1) | tx_flags);
                         }
-                        
-                        nr = (nr - 1) % TX_RING;
+                        offset += bcnt;
+                        size -= bcnt;
+                } while (size);
+        }
 
-                        if (np->desc_ver == DESC_VER_1)
-                                tx_flags_extra &= ~NV_TX_LASTPACKET;
-                        else
-                                tx_flags_extra &= ~NV_TX2_LASTPACKET;           
-                }
+        /* set last fragment flag  */
+        if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
+                np->tx_ring.orig[nr].FlagLen |= cpu_to_le32(tx_flags_extra);
+        } else {
+                np->tx_ring.ex[nr].FlagLen |= cpu_to_le32(tx_flags_extra);
         }
 
+        np->tx_skbuff[nr] = skb;
+
 #ifdef NETIF_F_TSO
         if (skb_shinfo(skb)->tso_size)
-                tx_flags_extra |= NV_TX2_TSO | (skb_shinfo(skb)->tso_size << NV_TX2_TSO_SHIFT);
+                tx_flags_extra = NV_TX2_TSO | (skb_shinfo(skb)->tso_size << NV_TX2_TSO_SHIFT);
         else
 #endif
-        tx_flags_extra |= (skb->ip_summed == CHECKSUM_HW ? (NV_TX2_CHECKSUM_L3|NV_TX2_CHECKSUM_L4) : 0);
+        tx_flags_extra = (skb->ip_summed == CHECKSUM_HW ? (NV_TX2_CHECKSUM_L3|NV_TX2_CHECKSUM_L4) : 0);
 
-        np->tx_dma[nr] = pci_map_single(np->pci_dev, skb->data, skb->len-skb->data_len,
-                                        PCI_DMA_TODEVICE);
-        
+        /* set tx flags */
         if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
-                np->tx_ring.orig[nr].PacketBuffer = cpu_to_le32(np->tx_dma[nr]);
-                np->tx_ring.orig[nr].FlagLen = cpu_to_le32( (skb->len-skb->data_len-1) | np->tx_flags | tx_flags_extra);
+                np->tx_ring.orig[start_nr].FlagLen |= cpu_to_le32(tx_flags | tx_flags_extra);
         } else {
-                np->tx_ring.ex[nr].PacketBufferHigh = cpu_to_le64(np->tx_dma[nr]) >> 32;
-                np->tx_ring.ex[nr].PacketBufferLow = cpu_to_le64(np->tx_dma[nr]) & 0x0FFFFFFFF;
-                np->tx_ring.ex[nr].FlagLen = cpu_to_le32( (skb->len-skb->data_len-1) | np->tx_flags | tx_flags_extra);
+                np->tx_ring.ex[start_nr].FlagLen |= cpu_to_le32(tx_flags | tx_flags_extra);
         }       
 
-        dprintk(KERN_DEBUG "%s: nv_start_xmit: packet packet %d queued for transmission. tx_flags_extra: %x\n",
-                                dev->name, np->next_tx, tx_flags_extra);
+        dprintk(KERN_DEBUG "%s: nv_start_xmit: packet %d (entries %d) queued for transmission. tx_flags_extra: %x\n",
+                dev->name, np->next_tx, entries, tx_flags_extra);
         {
                 int j;
                 for (j=0; j<64; j++) {
@@ -1093,7 +1130,7 @@ static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 dprintk("\n");
         }
 
-        np->next_tx += 1 + fragments;
+        np->next_tx += entries;
 
         dev->trans_start = jiffies;
         spin_unlock_irq(&np->lock);
@@ -1140,7 +1177,6 @@ static void nv_tx_done(struct net_device *dev)
                                         np->stats.tx_packets++;
                                         np->stats.tx_bytes += skb->len;
                                 }
-                                nv_release_txskb(dev, i);
                         }
                 } else {
                         if (Flags & NV_TX2_LASTPACKET) {
@@ -1156,9 +1192,9 @@ static void nv_tx_done(struct net_device *dev)
                                         np->stats.tx_packets++;
                                         np->stats.tx_bytes += skb->len;
                                 }                               
-                                nv_release_txskb(dev, i);
                         }
                 }
+                nv_release_txskb(dev, i);
                 np->nic_tx++;
         }
         if (np->next_tx - np->nic_tx < TX_LIMIT_START)
@@ -2456,7 +2492,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
                 np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
                 dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;
 #ifdef NETIF_F_TSO
-                /* disabled dev->features |= NETIF_F_TSO; */
+                dev->features |= NETIF_F_TSO;
 #endif
         }
 
diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index 94a91da84fbb..cb9d66ac3ab9 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -718,14 +718,14 @@ struct gfar_private {
         uint32_t msg_enable;
 };
 
-extern inline u32 gfar_read(volatile unsigned *addr)
+static inline u32 gfar_read(volatile unsigned *addr)
 {
         u32 val;
         val = in_be32(addr);
         return val;
 }
 
-extern inline void gfar_write(volatile unsigned *addr, u32 val)
+static inline void gfar_write(volatile unsigned *addr, u32 val)
 {
         out_be32(addr, val);
 }
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index 3e9accf137e7..41b3d83c2ab8 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -524,6 +524,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len)
         ax->dev->trans_start = jiffies;
         ax->xleft = count - actual;
         ax->xhead = ax->xbuff + actual;
+        spin_unlock_bh(&ax->buflock);
 }
 
 /* Encapsulate an AX.25 packet and kick it into a TTY queue. */
diff --git a/drivers/net/hp-plus.c b/drivers/net/hp-plus.c
index 0abf5dd08b4c..74e167e7dea7 100644
--- a/drivers/net/hp-plus.c
+++ b/drivers/net/hp-plus.c
@@ -138,12 +138,6 @@ static int __init do_hpp_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        /* NB: hpp_close() handles free_irq */
-        release_region(dev->base_addr - NIC_OFFSET, HP_IO_EXTENT);
-}
-
 #ifndef MODULE
 struct net_device * __init hp_plus_probe(int unit)
 {
@@ -473,6 +467,12 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        /* NB: hpp_close() handles free_irq */
+        release_region(dev->base_addr - NIC_OFFSET, HP_IO_EXTENT);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/hp.c b/drivers/net/hp.c
index 59cf841b14ab..cf9fb3698a6b 100644
--- a/drivers/net/hp.c
+++ b/drivers/net/hp.c
@@ -102,12 +102,6 @@ static int __init do_hp_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr - NIC_OFFSET, HP_IO_EXTENT);
-}
-
 #ifndef MODULE
 struct net_device * __init hp_probe(int unit)
 {
@@ -444,6 +438,12 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr - NIC_OFFSET, HP_IO_EXTENT);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/ibm_emac/ibm_emac.h b/drivers/net/ibm_emac/ibm_emac.h
index 644edbff4f94..c2dae6092c4c 100644
--- a/drivers/net/ibm_emac/ibm_emac.h
+++ b/drivers/net/ibm_emac/ibm_emac.h
@@ -110,6 +110,7 @@ struct emac_regs {
 #define EMAC_MR1_TFS_2K                 0x00080000
 #define EMAC_MR1_TR0_MULT               0x00008000
 #define EMAC_MR1_JPSM                   0x00000000
+#define EMAC_MR1_MWSW_001               0x00000000
 #define EMAC_MR1_BASE(opb)              (EMAC_MR1_TFS_2K | EMAC_MR1_TR0_MULT)
 #else
 #define EMAC_MR1_RFS_4K                 0x00180000
@@ -130,7 +131,7 @@ struct emac_regs {
                                          (freq) <= 83  ? EMAC_MR1_OBCI_83 : \
                                          (freq) <= 100 ? EMAC_MR1_OBCI_100 : EMAC_MR1_OBCI_100P)
 #define EMAC_MR1_BASE(opb)              (EMAC_MR1_TFS_2K | EMAC_MR1_TR | \
-                                         EMAC_MR1_MWSW_001 | EMAC_MR1_OBCI(opb))
+                                         EMAC_MR1_OBCI(opb))
 #endif
 
 /* EMACx_TMR0 */
diff --git a/drivers/net/ibm_emac/ibm_emac_core.c b/drivers/net/ibm_emac/ibm_emac_core.c
index 1da8a66f91e1..591c5864ffb1 100644
--- a/drivers/net/ibm_emac/ibm_emac_core.c
+++ b/drivers/net/ibm_emac/ibm_emac_core.c
@@ -408,7 +408,7 @@ static int emac_configure(struct ocp_enet_private *dev)
         /* Mode register */
         r = EMAC_MR1_BASE(emac_opb_mhz()) | EMAC_MR1_VLE | EMAC_MR1_IST;
         if (dev->phy.duplex == DUPLEX_FULL)
-                r |= EMAC_MR1_FDE;
+                r |= EMAC_MR1_FDE | EMAC_MR1_MWSW_001;
         dev->stop_timeout = STOP_TIMEOUT_10;
         switch (dev->phy.speed) {
         case SPEED_1000:
diff --git a/drivers/net/irda/vlsi_ir.h b/drivers/net/irda/vlsi_ir.h
index 741aecc655df..a82a4ba8de4f 100644
--- a/drivers/net/irda/vlsi_ir.h
+++ b/drivers/net/irda/vlsi_ir.h
@@ -577,8 +577,8 @@ struct ring_descr_hw {
                 struct {
                         u8              addr_res[3];
                         volatile u8     status;         /* descriptor status */
-                } rd_s __attribute__((packed));
-        } rd_u __attribute((packed));
+                } __attribute__((packed)) rd_s;
+        } __attribute((packed)) rd_u;
 } __attribute__ ((packed));
 
 #define rd_addr         rd_u.addr
diff --git a/drivers/net/lance.c b/drivers/net/lance.c
index 1d75ca0bb939..d1d714faa6ce 100644
--- a/drivers/net/lance.c
+++ b/drivers/net/lance.c
@@ -309,17 +309,6 @@ static void lance_tx_timeout (struct net_device *dev);
 
 
 
-static void cleanup_card(struct net_device *dev)
-{
-        struct lance_private *lp = dev->priv;
-        if (dev->dma != 4)
-                free_dma(dev->dma);
-        release_region(dev->base_addr, LANCE_TOTAL_SIZE);
-        kfree(lp->tx_bounce_buffs);
-        kfree((void*)lp->rx_buffs);
-        kfree(lp);
-}
-
 #ifdef MODULE
 #define MAX_CARDS               8       /* Max number of interfaces (cards) per module */
 
@@ -367,6 +356,17 @@ int init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        struct lance_private *lp = dev->priv;
+        if (dev->dma != 4)
+                free_dma(dev->dma);
+        release_region(dev->base_addr, LANCE_TOTAL_SIZE);
+        kfree(lp->tx_bounce_buffs);
+        kfree((void*)lp->rx_buffs);
+        kfree(lp);
+}
+
 void cleanup_module(void)
 {
         int this_dev;
diff --git a/drivers/net/lne390.c b/drivers/net/lne390.c
index 309d254842cf..646e89fc3562 100644
--- a/drivers/net/lne390.c
+++ b/drivers/net/lne390.c
@@ -145,13 +145,6 @@ static int __init do_lne390_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr, LNE390_IO_EXTENT);
-        iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init lne390_probe(int unit)
 {
@@ -440,6 +433,13 @@ int init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr, LNE390_IO_EXTENT);
+        iounmap(ei_status.mem);
+}
+
 void cleanup_module(void)
 {
         int this_dev;
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 3cb9b3fe0cf1..22c3a37bba5a 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -6,7 +6,7 @@
  * Copyright (C) 2002 rabeeh@galileo.co.il
  *
  * Copyright (C) 2003 PMC-Sierra, Inc.,
- *      written by Manish Lachwani (lachwani@pmc-sierra.com)
+ *      written by Manish Lachwani
  *
  * Copyright (C) 2003 Ralf Baechle <ralf@linux-mips.org>
  *
diff --git a/drivers/net/ne.c b/drivers/net/ne.c
index 0de8fdd2aa86..94f782d51f0f 100644
--- a/drivers/net/ne.c
+++ b/drivers/net/ne.c
@@ -212,15 +212,6 @@ static int __init do_ne_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        struct pnp_dev *idev = (struct pnp_dev *)ei_status.priv;
-        if (idev)
-                pnp_device_detach(idev);
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr, NE_IO_EXTENT);
-}
-
 #ifndef MODULE
 struct net_device * __init ne_probe(int unit)
 {
@@ -859,6 +850,15 @@ int init_module(void)
         return -ENODEV;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        struct pnp_dev *idev = (struct pnp_dev *)ei_status.priv;
+        if (idev)
+                pnp_device_detach(idev);
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr, NE_IO_EXTENT);
+}
+
 void cleanup_module(void)
 {
         int this_dev;
diff --git a/drivers/net/ne2.c b/drivers/net/ne2.c
index 6d62ada85de6..e6df375a1d4b 100644
--- a/drivers/net/ne2.c
+++ b/drivers/net/ne2.c
@@ -278,14 +278,6 @@ static int __init do_ne2_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        mca_mark_as_unused(ei_status.priv);
-        mca_set_adapter_procfn( ei_status.priv, NULL, NULL);
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr, NE_IO_EXTENT);
-}
-
 #ifndef MODULE
 struct net_device * __init ne2_probe(int unit)
 {
@@ -812,6 +804,14 @@ int init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        mca_mark_as_unused(ei_status.priv);
+        mca_set_adapter_procfn( ei_status.priv, NULL, NULL);
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr, NE_IO_EXTENT);
+}
+
 void cleanup_module(void)
 {
         int this_dev;
diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
index 9a76ac180b11..197edd74fbb5 100644
--- a/drivers/net/sk98lin/skge.c
+++ b/drivers/net/sk98lin/skge.c
@@ -282,26 +282,22 @@ SK_U32 Val)		/* pointer to store the read value */
  * Description:
  *      This function initialize the PCI resources and IO
  *
- * Returns: N/A
- *      
+ * Returns:
+ *      0 - indicate everything worked ok.
+ *      != 0 - error indication
  */
-int SkGeInitPCI(SK_AC *pAC)
+static __devinit int SkGeInitPCI(SK_AC *pAC)
 {
         struct SK_NET_DEVICE *dev = pAC->dev[0];
         struct pci_dev *pdev = pAC->PciDev;
         int retval;
 
-        if (pci_enable_device(pdev) != 0) {
-                return 1;
-        }
-
         dev->mem_start = pci_resource_start (pdev, 0);
         pci_set_master(pdev);
 
-        if (pci_request_regions(pdev, "sk98lin") != 0) {
-                retval = 2;
-                goto out_disable;
-        }
+        retval = pci_request_regions(pdev, "sk98lin");
+        if (retval)
+                goto out;
 
 #ifdef SK_BIG_ENDIAN
         /*
@@ -320,9 +316,8 @@ int SkGeInitPCI(SK_AC *pAC)
          * Remap the regs into kernel space.
          */
         pAC->IoBase = ioremap_nocache(dev->mem_start, 0x4000);
-
-        if (!pAC->IoBase){
-                retval = 3;
+        if (!pAC->IoBase) {
+                retval = -EIO;
                 goto out_release;
         }
 
@@ -330,8 +325,7 @@ int SkGeInitPCI(SK_AC *pAC)
 
  out_release:
         pci_release_regions(pdev);
- out_disable:
-        pci_disable_device(pdev);
+ out:
         return retval;
 }
 
@@ -492,7 +486,7 @@ module_param_array(AutoSizing, charp, NULL, 0);
  *      0, if everything is ok
  *      !=0, on error
  */
-static int __init SkGeBoardInit(struct SK_NET_DEVICE *dev, SK_AC *pAC)
+static int __devinit SkGeBoardInit(struct SK_NET_DEVICE *dev, SK_AC *pAC)
 {
 short   i;
 unsigned long Flags;
@@ -529,7 +523,7 @@ SK_BOOL	DualNet;
         if (SkGeInit(pAC, pAC->IoBase, SK_INIT_DATA) != 0) {
                 printk("HWInit (0) failed.\n");
                 spin_unlock_irqrestore(&pAC->SlowPathLock, Flags);
-                return(-EAGAIN);
+                return -EIO;
         }
         SkI2cInit(  pAC, pAC->IoBase, SK_INIT_DATA);
         SkEventInit(pAC, pAC->IoBase, SK_INIT_DATA);
@@ -551,7 +545,7 @@ SK_BOOL	DualNet;
         if (SkGeInit(pAC, pAC->IoBase, SK_INIT_IO) != 0) {
                 printk("sk98lin: HWInit (1) failed.\n");
                 spin_unlock_irqrestore(&pAC->SlowPathLock, Flags);
-                return(-EAGAIN);
+                return -EIO;
         }
         SkI2cInit(  pAC, pAC->IoBase, SK_INIT_IO);
         SkEventInit(pAC, pAC->IoBase, SK_INIT_IO);
@@ -583,20 +577,20 @@ SK_BOOL	DualNet;
         } else {
                 printk(KERN_WARNING "sk98lin: Illegal number of ports: %d\n",
                        pAC->GIni.GIMacsFound);
-                return -EAGAIN;
+                return -EIO;
         }
 
         if (Ret) {
                 printk(KERN_WARNING "sk98lin: Requested IRQ %d is busy.\n",
                        dev->irq);
-                return -EAGAIN;
+                return Ret;
         }
         pAC->AllocFlag |= SK_ALLOC_IRQ;
 
         /* Alloc memory for this board (Mem for RxD/TxD) : */
         if(!BoardAllocMem(pAC)) {
                 printk("No memory for descriptor rings.\n");
-                return(-EAGAIN);
+                return -ENOMEM;
         }
 
         BoardInitMem(pAC);
@@ -612,7 +606,7 @@ SK_BOOL	DualNet;
                 DualNet)) {
                 BoardFreeMem(pAC);
                 printk("sk98lin: SkGeInitAssignRamToQueues failed.\n");
-                return(-EAGAIN);
+                return -EIO;
         }
 
         return (0);
@@ -633,8 +627,7 @@ SK_BOOL	DualNet;
  *      SK_TRUE, if all memory could be allocated
  *      SK_FALSE, if not
  */
-static SK_BOOL BoardAllocMem(
-SK_AC   *pAC)
+static __devinit SK_BOOL BoardAllocMem(SK_AC    *pAC)
 {
 caddr_t         pDescrMem;      /* pointer to descriptor memory area */
 size_t          AllocLength;    /* length of complete descriptor area */
@@ -727,8 +720,7 @@ size_t		AllocLength;	/* length of complete descriptor area */
  *
  * Returns:     N/A
  */
-static void BoardInitMem(
-SK_AC   *pAC)   /* pointer to adapter context */
+static __devinit void BoardInitMem(SK_AC *pAC)
 {
 int     i;              /* loop counter */
 int     RxDescrSize;    /* the size of a rx descriptor rounded up to alignment*/
@@ -4776,32 +4768,47 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
         struct net_device       *dev = NULL;
         static int boards_found = 0;
         int error = -ENODEV;
+        int using_dac = 0;
         char DeviceStr[80];
 
         if (pci_enable_device(pdev))
                 goto out;
  
         /* Configure DMA attributes. */
-        if (pci_set_dma_mask(pdev, DMA_64BIT_MASK) &&
-            pci_set_dma_mask(pdev, DMA_32BIT_MASK))
-                goto out_disable_device;
-
+        if (sizeof(dma_addr_t) > sizeof(u32) &&
+            !(error = pci_set_dma_mask(pdev, DMA_64BIT_MASK))) {
+                using_dac = 1;
+                error = pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK);
+                if (error < 0) {
+                        printk(KERN_ERR "sk98lin %s unable to obtain 64 bit DMA "
+                               "for consistent allocations\n", pci_name(pdev));
+                        goto out_disable_device;
+                }
+        } else {
+                error = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
+                if (error) {
+                        printk(KERN_ERR "sk98lin %s no usable DMA configuration\n",
+                               pci_name(pdev));
+                        goto out_disable_device;
+                }
+        }
 
-        if ((dev = alloc_etherdev(sizeof(DEV_NET))) == NULL) {
-                printk(KERN_ERR "Unable to allocate etherdev "
+        error = -ENOMEM;
+        dev = alloc_etherdev(sizeof(DEV_NET));
+        if (!dev) {
+                printk(KERN_ERR "sk98lin: unable to allocate etherdev "
                        "structure!\n");
                 goto out_disable_device;
         }
 
         pNet = netdev_priv(dev);
-        pNet->pAC = kmalloc(sizeof(SK_AC), GFP_KERNEL);
+        pNet->pAC = kzalloc(sizeof(SK_AC), GFP_KERNEL);
         if (!pNet->pAC) {
-                printk(KERN_ERR "Unable to allocate adapter "
+                printk(KERN_ERR "sk98lin: unable to allocate adapter "
                        "structure!\n");
                 goto out_free_netdev;
         }
 
-        memset(pNet->pAC, 0, sizeof(SK_AC));
         pAC = pNet->pAC;
         pAC->PciDev = pdev;
 
@@ -4810,6 +4817,7 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
         pAC->CheckQueue = SK_FALSE;
 
         dev->irq = pdev->irq;
+
         error = SkGeInitPCI(pAC);
         if (error) {
                 printk(KERN_ERR "sk98lin: PCI setup failed: %i\n", error);
@@ -4844,19 +4852,25 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
 #endif
         }
 
+        if (using_dac)
+                dev->features |= NETIF_F_HIGHDMA;
+
         pAC->Index = boards_found++;
 
-        if (SkGeBoardInit(dev, pAC))
+        error = SkGeBoardInit(dev, pAC);
+        if (error)
                 goto out_free_netdev;
 
         /* Read Adapter name from VPD */
         if (ProductStr(pAC, DeviceStr, sizeof(DeviceStr)) != 0) {
+                error = -EIO;
                 printk(KERN_ERR "sk98lin: Could not read VPD data.\n");
                 goto out_free_resources;
         }
 
         /* Register net device */
-        if (register_netdev(dev)) {
+        error = register_netdev(dev);
+        if (error) {
                 printk(KERN_ERR "sk98lin: Could not register device.\n");
                 goto out_free_resources;
         }
@@ -4883,15 +4897,17 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
 
         boards_found++;
 
+        pci_set_drvdata(pdev, dev);
+
         /* More then one port found */
         if ((pAC->GIni.GIMacsFound == 2 ) && (pAC->RlmtNets == 2)) {
-                if ((dev = alloc_etherdev(sizeof(DEV_NET))) == 0) {
-                        printk(KERN_ERR "Unable to allocate etherdev "
+                dev = alloc_etherdev(sizeof(DEV_NET));
+                if (!dev) {
+                        printk(KERN_ERR "sk98lin: unable to allocate etherdev "
                                 "structure!\n");
-                        goto out;
+                        goto single_port;
                 }
 
-                pAC->dev[1]   = dev;
                 pNet          = netdev_priv(dev);
                 pNet->PortNr  = 1;
                 pNet->NetNr   = 1;
@@ -4920,20 +4936,28 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
 #endif
                 }
 
-                if (register_netdev(dev)) {
-                        printk(KERN_ERR "sk98lin: Could not register device for seconf port.\n");
+                if (using_dac)
+                        dev->features |= NETIF_F_HIGHDMA;
+
+                error = register_netdev(dev);
+                if (error) {
+                        printk(KERN_ERR "sk98lin: Could not register device"
+                               " for second port. (%d)\n", error);
                         free_netdev(dev);
-                        pAC->dev[1] = pAC->dev[0];
-                } else {
-                        memcpy(&dev->dev_addr,
-                                        &pAC->Addr.Net[1].CurrentMacAddress, 6);
-                        memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
-        
-                        printk("%s: %s\n", dev->name, DeviceStr);
-                        printk("      PrefPort:B  RlmtMode:Dual Check Link State\n");
+                        goto single_port;
                 }
+
+                pAC->dev[1]   = dev;
+                memcpy(&dev->dev_addr,
+                       &pAC->Addr.Net[1].CurrentMacAddress, 6);
+                memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
+
+                printk("%s: %s\n", dev->name, DeviceStr);
+                printk("      PrefPort:B  RlmtMode:Dual Check Link State\n");
         }
 
+single_port:
+
         /* Save the hardware revision */
         pAC->HWRevision = (((pAC->GIni.GIPciHwRev >> 4) & 0x0F)*10) +
                 (pAC->GIni.GIPciHwRev & 0x0F);
@@ -4945,7 +4969,6 @@ static int __devinit skge_probe_one(struct pci_dev *pdev,
         memset(&pAC->PnmiBackup, 0, sizeof(SK_PNMI_STRUCT_DATA));
         memcpy(&pAC->PnmiBackup, &pAC->PnmiStruct, sizeof(SK_PNMI_STRUCT_DATA));
 
-        pci_set_drvdata(pdev, dev);
         return 0;
 
  out_free_resources:
diff --git a/drivers/net/smc-ultra.c b/drivers/net/smc-ultra.c
index ba8593ac3f8a..3db30cd0625e 100644
--- a/drivers/net/smc-ultra.c
+++ b/drivers/net/smc-ultra.c
@@ -168,18 +168,6 @@ static int __init do_ultra_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        /* NB: ultra_close_card() does free_irq */
-#ifdef __ISAPNP__
-        struct pnp_dev *idev = (struct pnp_dev *)ei_status.priv;
-        if (idev)
-                pnp_device_detach(idev);
-#endif
-        release_region(dev->base_addr - ULTRA_NIC_OFFSET, ULTRA_IO_EXTENT);
-        iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init ultra_probe(int unit)
 {
@@ -594,6 +582,18 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        /* NB: ultra_close_card() does free_irq */
+#ifdef __ISAPNP__
+        struct pnp_dev *idev = (struct pnp_dev *)ei_status.priv;
+        if (idev)
+                pnp_device_detach(idev);
+#endif
+        release_region(dev->base_addr - ULTRA_NIC_OFFSET, ULTRA_IO_EXTENT);
+        iounmap(ei_status.mem);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index 28bf2e69eb5e..7ec08127c9d6 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -88,7 +88,6 @@ static const char version[] =
 #include <linux/skbuff.h>
 
 #include <asm/io.h>
-#include <asm/irq.h>
 
 #include "smc91x.h"
 
@@ -2007,12 +2006,10 @@ static int __init smc_probe(struct net_device *dev, void __iomem *ioaddr)
         }
 
         /* Grab the IRQ */
-        retval = request_irq(dev->irq, &smc_interrupt, 0, dev->name, dev);
+        retval = request_irq(dev->irq, &smc_interrupt, SMC_IRQ_FLAGS, dev->name, dev);
         if (retval)
                 goto err_out;
 
-        set_irq_type(dev->irq, SMC_IRQ_TRIGGER_TYPE);
-
 #ifdef SMC_USE_PXA_DMA
         {
                 int dma = pxa_request_dma(dev->name, DMA_PRIO_LOW,
diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
index 5c2824be4ee6..e0efd1964e72 100644
--- a/drivers/net/smc91x.h
+++ b/drivers/net/smc91x.h
@@ -90,7 +90,7 @@
                         __l--;                                          \
                 }                                                       \
         } while (0)
-#define set_irq_type(irq, type)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif defined(CONFIG_SA1100_PLEB)
 /* We can only do 16-bit reads and writes in the static memory space. */
@@ -109,7 +109,7 @@
 #define SMC_outw(v, a, r)       writew(v, (a) + (r))
 #define SMC_outsw(a, r, p, l)   writesw((a) + (r), p, l)
 
-#define set_irq_type(irq, type) do {} while (0)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif defined(CONFIG_SA1100_ASSABET)
 
@@ -185,11 +185,11 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #include <asm/mach-types.h>
 #include <asm/arch/cpu.h>
 
-#define SMC_IRQ_TRIGGER_TYPE (( \
+#define SMC_IRQ_FLAGS (( \
                    machine_is_omap_h2() \
                 || machine_is_omap_h3() \
                 || (machine_is_omap_innovator() && !cpu_is_omap1510()) \
-        ) ? IRQT_FALLING : IRQT_RISING)
+        ) ? SA_TRIGGER_FALLING : SA_TRIGGER_RISING)
 
 
 #elif   defined(CONFIG_SH_SH4202_MICRODEV)
@@ -209,7 +209,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #define SMC_insw(a, r, p, l)    insw((a) + (r) - 0xa0000000, p, l)
 #define SMC_outsw(a, r, p, l)   outsw((a) + (r) - 0xa0000000, p, l)
 
-#define set_irq_type(irq, type) do {} while(0)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif   defined(CONFIG_ISA)
 
@@ -237,7 +237,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #define SMC_insw(a, r, p, l)    insw(((u32)a) + (r), p, l)
 #define SMC_outsw(a, r, p, l)   outsw(((u32)a) + (r), p, l)
 
-#define set_irq_type(irq, type) do {} while(0)
+#define SMC_IRQ_FLAGS           (0)
 
 #define RPC_LSA_DEFAULT         RPC_LED_TX_RX
 #define RPC_LSB_DEFAULT         RPC_LED_100_10
@@ -319,7 +319,7 @@ static inline void SMC_outsw (unsigned long a, int r, unsigned char* p, int l)
                         au_writew(*_p++ , _a); \
         } while(0)
 
-#define set_irq_type(irq, type) do {} while (0)
+#define SMC_IRQ_FLAGS           (0)
 
 #else
 
@@ -342,8 +342,8 @@ static inline void SMC_outsw (unsigned long a, int r, unsigned char* p, int l)
 
 #endif
 
-#ifndef SMC_IRQ_TRIGGER_TYPE
-#define SMC_IRQ_TRIGGER_TYPE    IRQT_RISING
+#ifndef SMC_IRQ_FLAGS
+#define SMC_IRQ_FLAGS           SA_TRIGGER_RISING
 #endif
 
 #ifdef SMC_USE_PXA_DMA
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 125ed00e95a5..c67c91251d04 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1564,7 +1564,7 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
                             dev->dev_addr, 6);
                 }
 #endif
-#if defined(__i386__)           /* Patch up x86 BIOS bug. */
+#if defined(__i386__) || defined(__x86_64__)    /* Patch up x86 BIOS bug. */
                 if (last_irq)
                         irq = last_irq;
 #endif
diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c
index 036adc4f8ba7..22e794071cf4 100644
--- a/drivers/net/wan/sdla.c
+++ b/drivers/net/wan/sdla.c
@@ -329,9 +329,9 @@ static int sdla_cpuspeed(struct net_device *dev, struct ifreq *ifr)
 
 struct _dlci_stat 
 {
-        short dlci              __attribute__((packed));
-        char  flags             __attribute__((packed));
-};
+        short dlci;
+        char  flags;
+} __attribute__((packed));
 
 struct _frad_stat 
 {
diff --git a/drivers/net/wd.c b/drivers/net/wd.c
index b03feae459fc..7caa8dc88a58 100644
--- a/drivers/net/wd.c
+++ b/drivers/net/wd.c
@@ -127,13 +127,6 @@ static int __init do_wd_probe(struct net_device *dev)
         return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-        free_irq(dev->irq, dev);
-        release_region(dev->base_addr - WD_NIC_OFFSET, WD_IO_EXTENT);
-        iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init wd_probe(int unit)
 {
@@ -538,6 +531,13 @@ init_module(void)
         return -ENXIO;
 }
 
+static void cleanup_card(struct net_device *dev)
+{
+        free_irq(dev->irq, dev);
+        release_region(dev->base_addr - WD_NIC_OFFSET, WD_IO_EXTENT);
+        iounmap(ei_status.mem);
+}
+
 void
 cleanup_module(void)
 {
diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c
index 44cd3fcd1572..cf05661fb1bd 100644
--- a/drivers/net/wireless/ipw2100.c
+++ b/drivers/net/wireless/ipw2100.c
@@ -7153,7 +7153,7 @@ static int ipw2100_wx_get_range(struct net_device *dev,
 
         /* Set the Wireless Extension versions */
         range->we_version_compiled = WIRELESS_EXT;
-        range->we_version_source = 16;
+        range->we_version_source = 18;
 
 //      range->retry_capa;      /* What retry options are supported */
 //      range->retry_flags;     /* How to decode max/min retry limit */
@@ -7184,6 +7184,9 @@ static int ipw2100_wx_get_range(struct net_device *dev,
                                 IW_EVENT_CAPA_MASK(SIOCGIWAP));
         range->event_capa[1] = IW_EVENT_CAPA_K_1;
 
+        range->enc_capa = IW_ENC_CAPA_WPA | IW_ENC_CAPA_WPA2 |
+                IW_ENC_CAPA_CIPHER_TKIP | IW_ENC_CAPA_CIPHER_CCMP;
+
         IPW_DEBUG_WX("GET Range\n");
 
         return 0;
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index 531b07313141..b2e8e49c8659 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -43,13 +43,16 @@ static void process_task_mortuary(void);
  * list for processing. Only after two full buffer syncs
  * does the task eventually get freed, because by then
  * we are sure we will not reference it again.
+ * Can be invoked from softirq via RCU callback due to
+ * call_rcu() of the task struct, hence the _irqsave.
  */
 static int task_free_notify(struct notifier_block * self, unsigned long val, void * data)
 {
+        unsigned long flags;
         struct task_struct * task = data;
-        spin_lock(&task_mortuary);
+        spin_lock_irqsave(&task_mortuary, flags);
         list_add(&task->tasks, &dying_tasks);
-        spin_unlock(&task_mortuary);
+        spin_unlock_irqrestore(&task_mortuary, flags);
         return NOTIFY_OK;
 }
 
@@ -431,25 +434,22 @@ static void increment_tail(struct oprofile_cpu_buffer * b)
  */
 static void process_task_mortuary(void)
 {
-        struct list_head * pos;
-        struct list_head * pos2;
+        unsigned long flags;
+        LIST_HEAD(local_dead_tasks);
         struct task_struct * task;
+        struct task_struct * ttask;
 
-        spin_lock(&task_mortuary);
+        spin_lock_irqsave(&task_mortuary, flags);
 
-        list_for_each_safe(pos, pos2, &dead_tasks) {
-                task = list_entry(pos, struct task_struct, tasks);
-                list_del(&task->tasks);
-                free_task(task);
-        }
+        list_splice_init(&dead_tasks, &local_dead_tasks);
+        list_splice_init(&dying_tasks, &dead_tasks);
 
-        list_for_each_safe(pos, pos2, &dying_tasks) {
-                task = list_entry(pos, struct task_struct, tasks);
+        spin_unlock_irqrestore(&task_mortuary, flags);
+
+        list_for_each_entry_safe(task, ttask, &local_dead_tasks, tasks) {
                 list_del(&task->tasks);
-                list_add_tail(&task->tasks, &dead_tasks);
+                free_task(task);
         }
-
-        spin_unlock(&task_mortuary);
 }
 
 
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
index 026f671ea558..78193e4bbdb5 100644
--- a/drivers/oprofile/cpu_buffer.c
+++ b/drivers/oprofile/cpu_buffer.c
@@ -52,7 +52,8 @@ int alloc_cpu_buffers(void)
         for_each_online_cpu(i) {
                 struct oprofile_cpu_buffer * b = &cpu_buffer[i];
  
-                b->buffer = vmalloc(sizeof(struct op_sample) * buffer_size);
+                b->buffer = vmalloc_node(sizeof(struct op_sample) * buffer_size,
+                        cpu_to_node(i));
                 if (!b->buffer)
                         goto fail;
  
diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
index b8241561da45..a665951b1586 100644
--- a/drivers/parport/Kconfig
+++ b/drivers/parport/Kconfig
@@ -34,7 +34,7 @@ config PARPORT
 
 config PARPORT_PC
         tristate "PC-style hardware"
-        depends on PARPORT && (!SPARC64 || PCI) && !SPARC32 && !M32R
+        depends on PARPORT && (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV
         ---help---
           You should say Y here if you have a PC-style parallel port. All
           IBM PC compatible computers and some Alphas have PC-style
diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index 18e85ccdae67..9302b8fd7461 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -2371,8 +2371,10 @@ void parport_pc_unregister_port (struct parport *p)
         spin_lock(&ports_lock);
         list_del_init(&priv->list);
         spin_unlock(&ports_lock);
+#if defined(CONFIG_PARPORT_PC_FIFO) && defined(HAS_DMA)
         if (p->dma != PARPORT_DMA_NONE)
                 free_dma(p->dma);
+#endif
         if (p->irq != PARPORT_IRQ_NONE)
                 free_irq(p->irq, p);
         release_region(p->base, 3);
@@ -2380,14 +2382,12 @@ void parport_pc_unregister_port (struct parport *p)
                 release_region(p->base + 3, p->size - 3);
         if (p->modes & PARPORT_MODE_ECP)
                 release_region(p->base_hi, 3);
-#ifdef CONFIG_PARPORT_PC_FIFO
-#ifdef HAS_DMA
+#if defined(CONFIG_PARPORT_PC_FIFO) && defined(HAS_DMA)
         if (priv->dma_buf)
                 pci_free_consistent(priv->dev, PAGE_SIZE,
                                     priv->dma_buf,
                                     priv->dma_handle);
 #endif
-#endif
         kfree (p->private_data);
         parport_put_port(p);
         kfree (ops); /* hope no-one cached it */
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 6a61b9f286e1..0aac6a61337d 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -32,6 +32,7 @@
 #include <linux/types.h>
 #include <linux/pci.h>
 #include <linux/delay.h>
+#include <linux/sched.h>                /* signal_pending() */
 #include <linux/pcieport_if.h>
 #include "pci_hotplug.h"
 
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 0b8b26beb163..ac1e495c314e 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -30,6 +30,9 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/types.h>
+#include <linux/signal.h>
+#include <linux/jiffies.h>
+#include <linux/timer.h>
 #include <linux/pci.h>
 #include <linux/interrupt.h>
 
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 4f7ed4bd3be9..94e30fe4b8f3 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -24,6 +24,8 @@
 #include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/timer.h>
+#include <linux/jiffies.h>
+#include <linux/slab.h>
 
 #include "rio.h"
 
diff --git a/drivers/rapidio/rio-sysfs.c b/drivers/rapidio/rio-sysfs.c
index 30a11436e241..bef9316e95df 100644
--- a/drivers/rapidio/rio-sysfs.c
+++ b/drivers/rapidio/rio-sysfs.c
@@ -15,6 +15,7 @@
 #include <linux/rio.h>
 #include <linux/rio_drv.h>
 #include <linux/stat.h>
+#include <linux/sched.h>        /* for capable() */
 
 #include "rio.h"
 
diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
index 3ca1011ceaac..5e382470faa2 100644
--- a/drivers/rapidio/rio.c
+++ b/drivers/rapidio/rio.c
@@ -23,6 +23,7 @@
 #include <linux/rio_regs.h>
 #include <linux/module.h>
 #include <linux/spinlock.h>
+#include <linux/slab.h>
 
 #include "rio.h"
 
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index f779f674dfa0..2472fa1a1be1 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -18,6 +18,7 @@
 #include <linux/major.h>
 #include <linux/slab.h>
 #include <linux/buffer_head.h>
+#include <linux/hdreg.h>
 
 #include <asm/ccwdev.h>
 #include <asm/ebcdic.h>
@@ -1723,12 +1724,34 @@ dasd_release(struct inode *inp, struct file *filp)
         return 0;
 }
 
+/*
+ * Return disk geometry.
+ */
+static int
+dasd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+        struct dasd_device *device;
+
+        device = bdev->bd_disk->private_data;
+        if (!device)
+                return -ENODEV;
+
+        if (!device->discipline ||
+            !device->discipline->fill_geometry)
+                return -EINVAL;
+
+        device->discipline->fill_geometry(device, geo);
+        geo->start = get_start_sect(bdev) >> device->s2b_shift;
+        return 0;
+}
+
 struct block_device_operations
 dasd_device_operations = {
         .owner          = THIS_MODULE,
         .open           = dasd_open,
         .release        = dasd_release,
         .ioctl          = dasd_ioctl,
+        .getgeo         = dasd_getgeo,
 };
 
 
diff --git a/drivers/s390/block/dasd_ioctl.c b/drivers/s390/block/dasd_ioctl.c
index 044b75371990..8e4dcd58599e 100644
--- a/drivers/s390/block/dasd_ioctl.c
+++ b/drivers/s390/block/dasd_ioctl.c
@@ -486,33 +486,6 @@ dasd_ioctl_set_ro(struct block_device *bdev, int no, long args)
 }
 
 /*
- * Return disk geometry.
- */
-static int
-dasd_ioctl_getgeo(struct block_device *bdev, int no, long args)
-{
-        struct hd_geometry geo = { 0, };
-        struct dasd_device *device;
-
-        device =  bdev->bd_disk->private_data;
-        if (device == NULL)
-                return -ENODEV;
-
-        if (device == NULL || device->discipline == NULL ||
-            device->discipline->fill_geometry == NULL)
-                return -EINVAL;
-
-        geo = (struct hd_geometry) {};
-        device->discipline->fill_geometry(device, &geo);
-        geo.start = get_start_sect(bdev) >> device->s2b_shift;
-        if (copy_to_user((struct hd_geometry __user *) args, &geo,
-                         sizeof (struct hd_geometry)))
-                return -EFAULT;
-
-        return 0;
-}
-
-/*
  * List of static ioctls.
  */
 static struct { int no; dasd_ioctl_fn_t fn; } dasd_ioctls[] =
@@ -528,7 +501,6 @@ static struct { int no; dasd_ioctl_fn_t fn; } dasd_ioctls[] =
         { BIODASDPRRST, dasd_ioctl_reset_profile },
         { BLKROSET, dasd_ioctl_set_ro },
         { DASDAPIVER, dasd_ioctl_api_version },
-        { HDIO_GETGEO, dasd_ioctl_getgeo },
         { -1, NULL }
 };
 
diff --git a/drivers/s390/block/xpram.c b/drivers/s390/block/xpram.c
index bf3a67c3cc5e..54ecd548c318 100644
--- a/drivers/s390/block/xpram.c
+++ b/drivers/s390/block/xpram.c
@@ -328,31 +328,27 @@ fail:
         return 0;
 }
 
-static int xpram_ioctl (struct inode *inode, struct file *filp,
-                 unsigned int cmd, unsigned long arg)
+static int xpram_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
-        struct hd_geometry __user *geo;
         unsigned long size;
-        if (cmd != HDIO_GETGEO)
-                return -EINVAL;
+
         /*
          * get geometry: we have to fake one...  trim the size to a
          * multiple of 64 (32k): tell we have 16 sectors, 4 heads,
          * whatever cylinders. Tell also that data starts at sector. 4.
          */
-        geo = (struct hd_geometry __user *) arg;
         size = (xpram_pages * 8) & ~0x3f;
-        put_user(size >> 6, &geo->cylinders);
-        put_user(4, &geo->heads);
-        put_user(16, &geo->sectors);
-        put_user(4, &geo->start);
+        geo->cylinders = size >> 6;
+        geo->heads = 4;
+        geo->sectors = 16;
+        geo->start = 4;
         return 0;
 }
 
 static struct block_device_operations xpram_devops =
 {
         .owner  = THIS_MODULE,
-        .ioctl  = xpram_ioctl,
+        .getgeo = xpram_getgeo,
 };
 
 /*
diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c
index 932dcf0366eb..311a4122bd70 100644
--- a/drivers/scsi/mac53c94.c
+++ b/drivers/scsi/mac53c94.c
@@ -432,11 +432,12 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         struct Scsi_Host *host;
         void *dma_cmd_space;
         unsigned char *clkprop;
-        int proplen;
+        int proplen, rc = -ENODEV;
 
         if (macio_resource_count(mdev) != 2 || macio_irq_count(mdev) != 2) {
-                printk(KERN_ERR "mac53c94: expected 2 addrs and intrs (got %d/%d)\n",
-                       node->n_addrs, node->n_intrs);
+                printk(KERN_ERR "mac53c94: expected 2 addrs and intrs"
+                       " (got %d/%d)\n",
+                       macio_resource_count(mdev), macio_irq_count(mdev));
                 return -ENODEV;
         }
 
@@ -448,6 +449,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         host = scsi_host_alloc(&mac53c94_template, sizeof(struct fsc_state));
         if (host == NULL) {
                 printk(KERN_ERR "mac53c94: couldn't register host");
+                rc = -ENOMEM;
                 goto out_release;
         }
 
@@ -486,6 +488,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         if (dma_cmd_space == 0) {
                 printk(KERN_ERR "mac53c94: couldn't allocate dma "
                        "command space for %s\n", node->full_name);
+                rc = -ENOMEM;
                 goto out_free;
         }
         state->dma_cmds = (struct dbdma_cmd *)DBDMA_ALIGN(dma_cmd_space);
@@ -495,18 +498,21 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
 
         mac53c94_init(state);
 
-        if (request_irq(state->intr, do_mac53c94_interrupt, 0, "53C94", state)) {
+        if (request_irq(state->intr, do_mac53c94_interrupt, 0, "53C94",state)) {
                 printk(KERN_ERR "mac53C94: can't get irq %d for %s\n",
                        state->intr, node->full_name);
                 goto out_free_dma;
         }
 
-        /* XXX FIXME: handle failure */
-        scsi_add_host(host, &mdev->ofdev.dev);
-        scsi_scan_host(host);
+        rc = scsi_add_host(host, &mdev->ofdev.dev);
+        if (rc != 0)
+                goto out_release_irq;
 
+        scsi_scan_host(host);
         return 0;
 
+ out_release_irq:
+        free_irq(state->intr, state);
  out_free_dma:
         kfree(state->dma_cmd_space);
  out_free:
@@ -518,7 +524,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
  out_release:
         macio_release_resources(mdev);
 
-        return  -ENODEV;
+        return rc;
 }
 
 static int mac53c94_remove(struct macio_dev *mdev)
diff --git a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c
index bdccf73cf9fe..d6d2125f9044 100644
--- a/drivers/scsi/mesh.c
+++ b/drivers/scsi/mesh.c
@@ -1869,7 +1869,8 @@ static int mesh_probe(struct macio_dev *mdev, const struct of_device_id *match)
 
         if (macio_resource_count(mdev) != 2 || macio_irq_count(mdev) != 2) {
                 printk(KERN_ERR "mesh: expected 2 addrs and 2 intrs"
-                       " (got %d,%d)\n", mesh->n_addrs, mesh->n_intrs);
+                       " (got %d,%d)\n", macio_resource_count(mdev),
+                       macio_irq_count(mdev));
                 return -ENODEV;
         }
 
diff --git a/drivers/scsi/sata_nv.c b/drivers/scsi/sata_nv.c
index c0cf52cb975a..bbbb55eeb73a 100644
--- a/drivers/scsi/sata_nv.c
+++ b/drivers/scsi/sata_nv.c
@@ -29,6 +29,12 @@
  *  NV-specific details such as register offsets, SATA phy location,
  *  hotplug info, etc.
  *
+ *  0.10
+ *     - Fixed spurious interrupts issue seen with the Maxtor 6H500F0 500GB
+ *       drive.  Also made the check_hotplug() callbacks return whether there
+ *       was a hotplug interrupt or not.  This was not the source of the
+ *       spurious interrupts, but is the right thing to do anyway.
+ *
  *  0.09
  *     - Fixed bug introduced by 0.08's MCP51 and MCP55 support.
  *
@@ -124,10 +130,10 @@ static void nv_scr_write (struct ata_port *ap, unsigned int sc_reg, u32 val);
 static void nv_host_stop (struct ata_host_set *host_set);
 static void nv_enable_hotplug(struct ata_probe_ent *probe_ent);
 static void nv_disable_hotplug(struct ata_host_set *host_set);
-static void nv_check_hotplug(struct ata_host_set *host_set);
+static int nv_check_hotplug(struct ata_host_set *host_set);
 static void nv_enable_hotplug_ck804(struct ata_probe_ent *probe_ent);
 static void nv_disable_hotplug_ck804(struct ata_host_set *host_set);
-static void nv_check_hotplug_ck804(struct ata_host_set *host_set);
+static int nv_check_hotplug_ck804(struct ata_host_set *host_set);
 
 enum nv_host_type
 {
@@ -176,7 +182,7 @@ struct nv_host_desc
         enum nv_host_type       host_type;
         void                    (*enable_hotplug)(struct ata_probe_ent *probe_ent);
         void                    (*disable_hotplug)(struct ata_host_set *host_set);
-        void                    (*check_hotplug)(struct ata_host_set *host_set);
+        int                     (*check_hotplug)(struct ata_host_set *host_set);
 
 };
 static struct nv_host_desc nv_device_tbl[] = {
@@ -309,12 +315,16 @@ static irqreturn_t nv_interrupt (int irq, void *dev_instance,
                         qc = ata_qc_from_tag(ap, ap->active_tag);
                         if (qc && (!(qc->tf.ctl & ATA_NIEN)))
                                 handled += ata_host_intr(ap, qc);
+                        else
+                                // No request pending?  Clear interrupt status
+                                // anyway, in case there's one pending.
+                                ap->ops->check_status(ap);
                 }
 
         }
 
         if (host->host_desc->check_hotplug)
-                host->host_desc->check_hotplug(host_set);
+                handled += host->host_desc->check_hotplug(host_set);
 
         spin_unlock_irqrestore(&host_set->lock, flags);
 
@@ -497,7 +507,7 @@ static void nv_disable_hotplug(struct ata_host_set *host_set)
         outb(intr_mask, host_set->ports[0]->ioaddr.scr_addr + NV_INT_ENABLE);
 }
 
-static void nv_check_hotplug(struct ata_host_set *host_set)
+static int nv_check_hotplug(struct ata_host_set *host_set)
 {
         u8 intr_status;
 
@@ -522,7 +532,11 @@ static void nv_check_hotplug(struct ata_host_set *host_set)
                 if (intr_status & NV_INT_STATUS_SDEV_REMOVED)
                         printk(KERN_WARNING "nv_sata: "
                                 "Secondary device removed\n");
+
+                return 1;
         }
+
+        return 0;
 }
 
 static void nv_enable_hotplug_ck804(struct ata_probe_ent *probe_ent)
@@ -560,7 +574,7 @@ static void nv_disable_hotplug_ck804(struct ata_host_set *host_set)
         pci_write_config_byte(pdev, NV_MCP_SATA_CFG_20, regval);
 }
 
-static void nv_check_hotplug_ck804(struct ata_host_set *host_set)
+static int nv_check_hotplug_ck804(struct ata_host_set *host_set)
 {
         u8 intr_status;
 
@@ -585,7 +599,11 @@ static void nv_check_hotplug_ck804(struct ata_host_set *host_set)
                 if (intr_status & NV_INT_STATUS_SDEV_REMOVED)
                         printk(KERN_WARNING "nv_sata: "
                                 "Secondary device removed\n");
+
+                return 1;
         }
+
+        return 0;
 }
 
 static int __init nv_init(void)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 180676d7115a..ee5f4dfdab14 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -69,7 +69,6 @@
 #include "scsi_logging.h"
 
 static void scsi_done(struct scsi_cmnd *cmd);
-static int scsi_retry_command(struct scsi_cmnd *cmd);
 
 /*
  * Definitions and constants.
@@ -752,7 +751,7 @@ static void scsi_done(struct scsi_cmnd *cmd)
  * isn't running --- used by scsi_times_out */
 void __scsi_done(struct scsi_cmnd *cmd)
 {
-        unsigned long flags;
+        struct request *rq = cmd->request;
 
         /*
          * Set the serial numbers back to zero
@@ -763,71 +762,14 @@ void __scsi_done(struct scsi_cmnd *cmd)
         if (cmd->result)
                 atomic_inc(&cmd->device->ioerr_cnt);
 
+        BUG_ON(!rq);
+
         /*
-         * Next, enqueue the command into the done queue.
-         * It is a per-CPU queue, so we just disable local interrupts
-         * and need no spinlock.
+         * The uptodate/nbytes values don't matter, as we allow partial
+         * completes and thus will check this in the softirq callback
          */
-        local_irq_save(flags);
-        list_add_tail(&cmd->eh_entry, &__get_cpu_var(scsi_done_q));
-        raise_softirq_irqoff(SCSI_SOFTIRQ);
-        local_irq_restore(flags);
-}
-
-/**
- * scsi_softirq - Perform post-interrupt processing of finished SCSI commands.
- *
- * This is the consumer of the done queue.
- *
- * This is called with all interrupts enabled.  This should reduce
- * interrupt latency, stack depth, and reentrancy of the low-level
- * drivers.
- */
-static void scsi_softirq(struct softirq_action *h)
-{
-        int disposition;
-        LIST_HEAD(local_q);
-
-        local_irq_disable();
-        list_splice_init(&__get_cpu_var(scsi_done_q), &local_q);
-        local_irq_enable();
-
-        while (!list_empty(&local_q)) {
-                struct scsi_cmnd *cmd = list_entry(local_q.next,
-                                                   struct scsi_cmnd, eh_entry);
-                /* The longest time any command should be outstanding is the
-                 * per command timeout multiplied by the number of retries.
-                 *
-                 * For a typical command, this is 2.5 minutes */
-                unsigned long wait_for 
-                        = cmd->allowed * cmd->timeout_per_command;
-                list_del_init(&cmd->eh_entry);
-
-                disposition = scsi_decide_disposition(cmd);
-                if (disposition != SUCCESS &&
-                    time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) {
-                        sdev_printk(KERN_ERR, cmd->device,
-                                    "timing out command, waited %lus\n",
-                                    wait_for/HZ);
-                        disposition = SUCCESS;
-                }
-                        
-                scsi_log_completion(cmd, disposition);
-                switch (disposition) {
-                case SUCCESS:
-                        scsi_finish_command(cmd);
-                        break;
-                case NEEDS_RETRY:
-                        scsi_retry_command(cmd);
-                        break;
-                case ADD_TO_MLQUEUE:
-                        scsi_queue_insert(cmd, SCSI_MLQUEUE_DEVICE_BUSY);
-                        break;
-                default:
-                        if (!scsi_eh_scmd_add(cmd, 0))
-                                scsi_finish_command(cmd);
-                }
-        }
+        rq->completion_data = cmd;
+        blk_complete_request(rq);
 }
 
 /*
@@ -840,7 +782,7 @@ static void scsi_softirq(struct softirq_action *h)
  *              level drivers should not become re-entrant as a result of
  *              this.
  */
-static int scsi_retry_command(struct scsi_cmnd *cmd)
+int scsi_retry_command(struct scsi_cmnd *cmd)
 {
         /*
          * Restore the SCSI command state.
@@ -1273,38 +1215,6 @@ int scsi_device_cancel(struct scsi_device *sdev, int recovery)
 }
 EXPORT_SYMBOL(scsi_device_cancel);
 
-#ifdef CONFIG_HOTPLUG_CPU
-static int scsi_cpu_notify(struct notifier_block *self,
-                           unsigned long action, void *hcpu)
-{
-        int cpu = (unsigned long)hcpu;
-
-        switch(action) {
-        case CPU_DEAD:
-                /* Drain scsi_done_q. */
-                local_irq_disable();
-                list_splice_init(&per_cpu(scsi_done_q, cpu),
-                                 &__get_cpu_var(scsi_done_q));
-                raise_softirq_irqoff(SCSI_SOFTIRQ);
-                local_irq_enable();
-                break;
-        default:
-                break;
-        }
-        return NOTIFY_OK;
-}
-
-static struct notifier_block __devinitdata scsi_cpu_nb = {
-        .notifier_call  = scsi_cpu_notify,
-};
-
-#define register_scsi_cpu() register_cpu_notifier(&scsi_cpu_nb)
-#define unregister_scsi_cpu() unregister_cpu_notifier(&scsi_cpu_nb)
-#else
-#define register_scsi_cpu()
-#define unregister_scsi_cpu()
-#endif /* CONFIG_HOTPLUG_CPU */
-
 MODULE_DESCRIPTION("SCSI core");
 MODULE_LICENSE("GPL");
 
@@ -1338,8 +1248,6 @@ static int __init init_scsi(void)
                 INIT_LIST_HEAD(&per_cpu(scsi_done_q, i));
 
         devfs_mk_dir("scsi");
-        open_softirq(SCSI_SOFTIRQ, scsi_softirq, NULL);
-        register_scsi_cpu();
         printk(KERN_NOTICE "SCSI subsystem initialized\n");
         return 0;
 
@@ -1367,7 +1275,6 @@ static void __exit exit_scsi(void)
         devfs_remove("scsi");
         scsi_exit_procfs();
         scsi_exit_queue();
-        unregister_scsi_cpu();
 }
 
 subsys_initcall(init_scsi);
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index ba93d6e66d48..00c9bf383e23 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1493,6 +1493,41 @@ static void scsi_kill_request(struct request *req, request_queue_t *q)
         __scsi_done(cmd);
 }
 
+static void scsi_softirq_done(struct request *rq)
+{
+        struct scsi_cmnd *cmd = rq->completion_data;
+        unsigned long wait_for = cmd->allowed * cmd->timeout_per_command;
+        int disposition;
+
+        INIT_LIST_HEAD(&cmd->eh_entry);
+
+        disposition = scsi_decide_disposition(cmd);
+        if (disposition != SUCCESS &&
+            time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) {
+                sdev_printk(KERN_ERR, cmd->device,
+                            "timing out command, waited %lus\n",
+                            wait_for/HZ);
+                disposition = SUCCESS;
+        }
+                        
+        scsi_log_completion(cmd, disposition);
+
+        switch (disposition) {
+                case SUCCESS:
+                        scsi_finish_command(cmd);
+                        break;
+                case NEEDS_RETRY:
+                        scsi_retry_command(cmd);
+                        break;
+                case ADD_TO_MLQUEUE:
+                        scsi_queue_insert(cmd, SCSI_MLQUEUE_DEVICE_BUSY);
+                        break;
+                default:
+                        if (!scsi_eh_scmd_add(cmd, 0))
+                                scsi_finish_command(cmd);
+        }
+}
+
 /*
  * Function:    scsi_request_fn()
  *
@@ -1667,6 +1702,7 @@ struct request_queue *scsi_alloc_queue(struct scsi_device *sdev)
         blk_queue_bounce_limit(q, scsi_calculate_bounce_limit(shost));
         blk_queue_segment_boundary(q, shost->dma_boundary);
         blk_queue_issue_flush_fn(q, scsi_issue_flush_fn);
+        blk_queue_softirq_done(q, scsi_softirq_done);
 
         if (!shost->use_clustering)
                 clear_bit(QUEUE_FLAG_CLUSTER, &q->queue_flags);
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index f04e7e11f57a..14a6198cb8d2 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -44,6 +44,7 @@ extern void scsi_init_cmd_from_req(struct scsi_cmnd *cmd,
                 struct scsi_request *sreq);
 extern void __scsi_release_request(struct scsi_request *sreq);
 extern void __scsi_done(struct scsi_cmnd *cmd);
+extern int scsi_retry_command(struct scsi_cmnd *cmd);
 #ifdef CONFIG_SCSI_LOGGING
 void scsi_log_send(struct scsi_cmnd *cmd);
 void scsi_log_completion(struct scsi_cmnd *cmd, int disposition);
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 32d4d8d7b9f3..4c5127ed379c 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -527,7 +527,7 @@ static int sd_release(struct inode *inode, struct file *filp)
         return 0;
 }
 
-static int sd_hdio_getgeo(struct block_device *bdev, struct hd_geometry __user *loc)
+static int sd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
         struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
         struct scsi_device *sdp = sdkp->device;
@@ -545,15 +545,9 @@ static int sd_hdio_getgeo(struct block_device *bdev, struct hd_geometry __user *
         else
                 scsicam_bios_param(bdev, sdkp->capacity, diskinfo);
 
-        if (put_user(diskinfo[0], &loc->heads))
-                return -EFAULT;
-        if (put_user(diskinfo[1], &loc->sectors))
-                return -EFAULT;
-        if (put_user(diskinfo[2], &loc->cylinders))
-                return -EFAULT;
-        if (put_user((unsigned)get_start_sect(bdev),
-                     (unsigned long __user *)&loc->start))
-                return -EFAULT;
+        geo->heads = diskinfo[0];
+        geo->sectors = diskinfo[1];
+        geo->cylinders = diskinfo[2];
         return 0;
 }
 
@@ -593,12 +587,6 @@ static int sd_ioctl(struct inode * inode, struct file * filp,
         if (!scsi_block_when_processing_errors(sdp) || !error)
                 return error;
 
-        if (cmd == HDIO_GETGEO) {
-                if (!arg)
-                        return -EINVAL;
-                return sd_hdio_getgeo(bdev, p);
-        }
-
         /*
          * Send SCSI addressing ioctls directly to mid level, send other
          * ioctls to block level and then onto mid level if they can't be
@@ -800,6 +788,7 @@ static struct block_device_operations sd_fops = {
         .open                   = sd_open,
         .release                = sd_release,
         .ioctl                  = sd_ioctl,
+        .getgeo                 = sd_getgeo,
 #ifdef CONFIG_COMPAT
         .compat_ioctl           = sd_compat_ioctl,
 #endif
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 221e96e2620a..78aad9582bcf 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -2493,7 +2493,7 @@ sg_page_malloc(int rqSz, int lowDma, int *retSzp)
         }
         if (resp) {
                 if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
-                        memset(resp, 0, resSz);
+                        memset(page_address(resp), 0, resSz);
                 if (retSzp)
                         *retSzp = resSz;
         }
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c
index 987d22b53c22..16af5626c243 100644
--- a/drivers/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/serial/cpm_uart/cpm_uart_core.c
@@ -608,7 +608,7 @@ static int cpm_uart_tx_pump(struct uart_port *port)
 
                 p = cpm2cpu_addr(bdp->cbd_bufaddr);
 
-                *p++ = xmit->buf[xmit->tail];
+                *p++ = port->x_char;
                 bdp->cbd_datlen = 1;
                 bdp->cbd_sc |= BD_SC_READY;
                 /* Get next BD. */
diff --git a/drivers/serial/pmac_zilog.c b/drivers/serial/pmac_zilog.c
index 5ddd8ab1f108..ea24129eb6b9 100644
--- a/drivers/serial/pmac_zilog.c
+++ b/drivers/serial/pmac_zilog.c
@@ -1431,11 +1431,14 @@ static int __init pmz_init_port(struct uart_pmac_port *uap)
                 char    name[1];
         } *slots;
         int len;
+        struct resource r_ports, r_rxdma, r_txdma;
 
         /*
          * Request & map chip registers
          */
-        uap->port.mapbase = np->addrs[0].address;
+        if (of_address_to_resource(np, 0, &r_ports))
+                return -ENODEV;
+        uap->port.mapbase = r_ports.start;
         uap->port.membase = ioremap(uap->port.mapbase, 0x1000);
       
         uap->control_reg = uap->port.membase;
@@ -1445,16 +1448,20 @@ static int __init pmz_init_port(struct uart_pmac_port *uap)
          * Request & map DBDMA registers
          */
 #ifdef HAS_DBDMA
-        if (np->n_addrs >= 3 && np->n_intrs >= 3)
+        if (of_address_to_resource(np, 1, &r_txdma) == 0 &&
+            of_address_to_resource(np, 2, &r_rxdma) == 0)
                 uap->flags |= PMACZILOG_FLAG_HAS_DMA;
+#else
+        memset(&r_txdma, 0, sizeof(struct resource));
+        memset(&r_rxdma, 0, sizeof(struct resource));
 #endif  
         if (ZS_HAS_DMA(uap)) {
-                uap->tx_dma_regs = ioremap(np->addrs[np->n_addrs - 2].address, 0x1000);
+                uap->tx_dma_regs = ioremap(r_txdma.start, 0x100);
                 if (uap->tx_dma_regs == NULL) { 
                         uap->flags &= ~PMACZILOG_FLAG_HAS_DMA;
                         goto no_dma;
                 }
-                uap->rx_dma_regs = ioremap(np->addrs[np->n_addrs - 1].address, 0x1000);
+                uap->rx_dma_regs = ioremap(r_rxdma.start, 0x100);
                 if (uap->rx_dma_regs == NULL) { 
                         iounmap(uap->tx_dma_regs);
                         uap->tx_dma_regs = NULL;
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
index c44bbedec817..4ddc453023a2 100644
--- a/drivers/usb/core/inode.c
+++ b/drivers/usb/core/inode.c
@@ -186,7 +186,7 @@ static void update_bus(struct dentry *bus)
 
         down(&bus->d_inode->i_sem);
 
-        list_for_each_entry(dev, &bus->d_subdirs, d_child)
+        list_for_each_entry(dev, &bus->d_subdirs, d_u.d_child)
                 if (dev->d_inode)
                         update_dev(dev);
 
@@ -203,7 +203,7 @@ static void update_sb(struct super_block *sb)
 
         down(&root->d_inode->i_sem);
 
-        list_for_each_entry(bus, &root->d_subdirs, d_child) {
+        list_for_each_entry(bus, &root->d_subdirs, d_u.d_child) {
                 if (bus->d_inode) {
                         switch (S_IFMT & bus->d_inode->i_mode) {
                         case S_IFDIR:
@@ -319,7 +319,7 @@ static int usbfs_empty (struct dentry *dentry)
         spin_lock(&dcache_lock);
 
         list_for_each(list, &dentry->d_subdirs) {
-                struct dentry *de = list_entry(list, struct dentry, d_child);
+                struct dentry *de = list_entry(list, struct dentry, d_u.d_child);
                 if (usbfs_positive(de)) {
                         spin_unlock(&dcache_lock);
                         return 0;
diff --git a/drivers/usb/host/ohci-au1xxx.c b/drivers/usb/host/ohci-au1xxx.c
index d9cf3b327d96..77cd6ac07e3c 100644
--- a/drivers/usb/host/ohci-au1xxx.c
+++ b/drivers/usb/host/ohci-au1xxx.c
@@ -19,6 +19,7 @@
  */
 
 #include <linux/platform_device.h>
+#include <linux/signal.h>
 
 #include <asm/mach-au1x00/au1000.h>
 
diff --git a/drivers/usb/host/ohci-lh7a404.c b/drivers/usb/host/ohci-lh7a404.c
index 3959ccc88332..0020ed7a39d0 100644
--- a/drivers/usb/host/ohci-lh7a404.c
+++ b/drivers/usb/host/ohci-lh7a404.c
@@ -17,6 +17,7 @@
  */
 
 #include <linux/platform_device.h>
+#include <linux/signal.h>
 
 #include <asm/hardware.h>
 
diff --git a/drivers/usb/host/ohci-ppc-soc.c b/drivers/usb/host/ohci-ppc-soc.c
index 2ec6a78bd65e..b2a8dfa48870 100644
--- a/drivers/usb/host/ohci-ppc-soc.c
+++ b/drivers/usb/host/ohci-ppc-soc.c
@@ -15,6 +15,7 @@
  */
 
 #include <linux/platform_device.h>
+#include <linux/signal.h>
 
 /* configure so an HC device and id are always provided */
 /* always called with process context; sleeping is OK */
diff --git a/drivers/usb/media/dsbr100.c b/drivers/usb/media/dsbr100.c
index 6a5700e9d428..25646804d5be 100644
--- a/drivers/usb/media/dsbr100.c
+++ b/drivers/usb/media/dsbr100.c
@@ -127,6 +127,7 @@ static struct file_operations usb_dsbr100_fops = {
         .open =         usb_dsbr100_open,
         .release =      usb_dsbr100_close,
         .ioctl =        usb_dsbr100_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek =       no_llseek,
 };
 
diff --git a/drivers/usb/media/ov511.c b/drivers/usb/media/ov511.c
index 3a0e8ce67ebe..8af665bbe330 100644
--- a/drivers/usb/media/ov511.c
+++ b/drivers/usb/media/ov511.c
@@ -4774,6 +4774,7 @@ static struct file_operations ov511_fops = {
         .read =         ov51x_v4l1_read,
         .mmap =         ov51x_v4l1_mmap,
         .ioctl =        ov51x_v4l1_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek =       no_llseek,
 };
 
diff --git a/drivers/usb/media/pwc/pwc-if.c b/drivers/usb/media/pwc/pwc-if.c
index 09ca6128ac20..4f9b0dc6fd7b 100644
--- a/drivers/usb/media/pwc/pwc-if.c
+++ b/drivers/usb/media/pwc/pwc-if.c
@@ -154,6 +154,7 @@ static struct file_operations pwc_fops = {
         .poll =         pwc_video_poll,
         .mmap =         pwc_video_mmap,
         .ioctl =        pwc_video_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek =       no_llseek,
 };
 static struct video_device pwc_template = {
diff --git a/drivers/usb/media/se401.c b/drivers/usb/media/se401.c
index b2ae29af5940..2ba562285fda 100644
--- a/drivers/usb/media/se401.c
+++ b/drivers/usb/media/se401.c
@@ -1193,6 +1193,7 @@ static struct file_operations se401_fops = {
         .read =         se401_read,
         .mmap =         se401_mmap,
         .ioctl =        se401_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek =       no_llseek,
 };
 static struct video_device se401_template = {
diff --git a/drivers/usb/media/stv680.c b/drivers/usb/media/stv680.c
index 774038b352cd..b497a6a0a206 100644
--- a/drivers/usb/media/stv680.c
+++ b/drivers/usb/media/stv680.c
@@ -1343,6 +1343,7 @@ static struct file_operations stv680_fops = {
         .read =         stv680_read,
         .mmap =         stv680_mmap,
         .ioctl =        stv680_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek =       no_llseek,
 };
 static struct video_device stv680_template = {
diff --git a/drivers/usb/media/usbvideo.c b/drivers/usb/media/usbvideo.c
index 4bd113325ef9..63a72e550a1b 100644
--- a/drivers/usb/media/usbvideo.c
+++ b/drivers/usb/media/usbvideo.c
@@ -953,6 +953,7 @@ static struct file_operations usbvideo_fops = {
         .read =   usbvideo_v4l_read,
         .mmap =   usbvideo_v4l_mmap,
         .ioctl =  usbvideo_v4l_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .llseek = no_llseek,
 };
 static const struct video_device usbvideo_template = {
diff --git a/drivers/usb/media/vicam.c b/drivers/usb/media/vicam.c
index 1c73155c8d77..5df144073871 100644
--- a/drivers/usb/media/vicam.c
+++ b/drivers/usb/media/vicam.c
@@ -1236,6 +1236,7 @@ static struct file_operations vicam_fops = {
         .read           = vicam_read,
         .mmap           = vicam_mmap,
         .ioctl          = vicam_ioctl,
+        .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
 
diff --git a/drivers/usb/media/w9968cf.c b/drivers/usb/media/w9968cf.c
index 3605a6f3067b..bff9434c8e55 100644
--- a/drivers/usb/media/w9968cf.c
+++ b/drivers/usb/media/w9968cf.c
@@ -3490,6 +3490,7 @@ static struct file_operations w9968cf_fops = {
         .release = w9968cf_release,
         .read =    w9968cf_read,
         .ioctl =   w9968cf_ioctl,
+        .compat_ioctl = v4l_compat_ioctl32,
         .mmap =    w9968cf_mmap,
         .llseek =  no_llseek,
 };
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index cc8e3bf5001b..3f04427c9026 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1151,7 +1151,7 @@ config FB_VOODOO1
 
 config FB_CYBLA
         tristate "Cyberblade/i1 support"
-        depends on FB && PCI
+        depends on FB && PCI && X86_32 && !64BIT
         select FB_CFB_IMAGEBLIT
         select VIDEO_SELECT
         ---help---
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index a5d09e159cd1..6ee449858a5c 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -6,7 +6,7 @@ menu "Console display driver support"
 
 config VGA_CONSOLE
         bool "VGA text console" if EMBEDDED || !X86
-        depends on !ARCH_ACORN && !ARCH_EBSA110 && !4xx && !8xx && !SPARC && !M68K && !PARISC && !ARCH_VERSATILE
+        depends on !ARCH_ACORN && !ARCH_EBSA110 && !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && !ARCH_VERSATILE
         default y
         help
           Saying Y here will allow you to use Linux in text mode through a
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 167de397e4b4..12d9329d1408 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -56,6 +56,8 @@
 static DEFINE_SPINLOCK(vga_lock);
 static int cursor_size_lastfrom;
 static int cursor_size_lastto;
+static u32 vgacon_xres;
+static u32 vgacon_yres;
 static struct vgastate state;
 
 #define BLANK 0x0020
@@ -69,7 +71,7 @@ static struct vgastate state;
  * appear.
  */
 #undef TRIDENT_GLITCH
-
+#define VGA_FONTWIDTH       8   /* VGA does not support fontwidths != 8 */
 /*
  *  Interface used by the world
  */
@@ -325,6 +327,10 @@ static const char __init *vgacon_startup(void)
                 vga_scan_lines =
                     vga_video_font_height * vga_video_num_lines;
         }
+
+        vgacon_xres = ORIG_VIDEO_COLS * VGA_FONTWIDTH;
+        vgacon_yres = vga_scan_lines;
+
         return display_desc;
 }
 
@@ -503,10 +509,18 @@ static int vgacon_doresize(struct vc_data *c,
 {
         unsigned long flags;
         unsigned int scanlines = height * c->vc_font.height;
-        u8 scanlines_lo, r7, vsync_end, mode;
+        u8 scanlines_lo, r7, vsync_end, mode, max_scan;
 
         spin_lock_irqsave(&vga_lock, flags);
 
+        outb_p(VGA_CRTC_MAX_SCAN, vga_video_port_reg);
+        max_scan = inb_p(vga_video_port_val);
+
+        if (max_scan & 0x80)
+                scanlines <<= 1;
+
+        vgacon_xres = width * VGA_FONTWIDTH;
+        vgacon_yres = height * c->vc_font.height;
         outb_p(VGA_CRTC_MODE, vga_video_port_reg);
         mode = inb_p(vga_video_port_val);
 
@@ -551,6 +565,10 @@ static int vgacon_doresize(struct vc_data *c,
 
 static int vgacon_switch(struct vc_data *c)
 {
+        int x = c->vc_cols * VGA_FONTWIDTH;
+        int y = c->vc_rows * c->vc_font.height;
+        int rows = ORIG_VIDEO_LINES * vga_default_font_height/
+                c->vc_font.height;
         /*
          * We need to save screen size here as it's the only way
          * we can spot the screen has been resized and we need to
@@ -566,10 +584,11 @@ static int vgacon_switch(struct vc_data *c)
                 scr_memcpyw((u16 *) c->vc_origin, (u16 *) c->vc_screenbuf,
                             c->vc_screenbuf_size > vga_vram_size ?
                                 vga_vram_size : c->vc_screenbuf_size);
-                if (!(vga_video_num_columns % 2) &&
-                    vga_video_num_columns <= ORIG_VIDEO_COLS &&
-                    vga_video_num_lines <= (ORIG_VIDEO_LINES *
-                        vga_default_font_height) / c->vc_font.height)
+
+                if ((vgacon_xres != x || vgacon_yres != y) &&
+                    (!(vga_video_num_columns % 2) &&
+                     vga_video_num_columns <= ORIG_VIDEO_COLS &&
+                     vga_video_num_lines <= rows))
                         vgacon_doresize(c, c->vc_cols, c->vc_rows);
         }
 
@@ -993,7 +1012,8 @@ static int vgacon_font_set(struct vc_data *c, struct console_font *font, unsigne
         if (vga_video_type < VIDEO_TYPE_EGAM)
                 return -EINVAL;
 
-        if (font->width != 8 || (charcount != 256 && charcount != 512))
+        if (font->width != VGA_FONTWIDTH ||
+            (charcount != 256 && charcount != 512))
                 return -EINVAL;
 
         rc = vgacon_do_font_op(&state, font->data, 1, charcount == 512);
@@ -1010,7 +1030,7 @@ static int vgacon_font_get(struct vc_data *c, struct console_font *font)
         if (vga_video_type < VIDEO_TYPE_EGAM)
                 return -EINVAL;
 
-        font->width = 8;
+        font->width = VGA_FONTWIDTH;
         font->height = c->vc_font.height;
         font->charcount = vga_512_chars ? 512 : 256;
         if (!font->data)
diff --git a/drivers/video/controlfb.c b/drivers/video/controlfb.c
index 403d17377f8d..03798e9c882d 100644
--- a/drivers/video/controlfb.c
+++ b/drivers/video/controlfb.c
@@ -133,12 +133,6 @@ static int controlfb_mmap(struct fb_info *info, struct file *file,
 static int controlfb_set_par (struct fb_info *info);
 static int controlfb_check_var (struct fb_var_screeninfo *var, struct fb_info *info);
 
-/*
- * inititialization
- */
-int control_init(void);
-void control_setup(char *);
-
 /******************** Prototypes for internal functions **********************/
 
 static void set_control_clock(unsigned char *params);
@@ -550,9 +544,46 @@ static void control_set_hardware(struct fb_info_control *p, struct fb_par_contro
 
 
 /*
- * Called from fbmem.c for probing & initializing
+ * Parse user speficied options (`video=controlfb:')
  */
-int __init control_init(void)
+static void __init control_setup(char *options)
+{
+        char *this_opt;
+
+        if (!options || !*options)
+                return;
+
+        while ((this_opt = strsep(&options, ",")) != NULL) {
+                if (!strncmp(this_opt, "vmode:", 6)) {
+                        int vmode = simple_strtoul(this_opt+6, NULL, 0);
+                        if (vmode > 0 && vmode <= VMODE_MAX &&
+                            control_mac_modes[vmode - 1].m[1] >= 0)
+                                default_vmode = vmode;
+                } else if (!strncmp(this_opt, "cmode:", 6)) {
+                        int depth = simple_strtoul(this_opt+6, NULL, 0);
+                        switch (depth) {
+                         case CMODE_8:
+                         case CMODE_16:
+                         case CMODE_32:
+                                default_cmode = depth;
+                                break;
+                         case 8:
+                                default_cmode = CMODE_8;
+                                break;
+                         case 15:
+                         case 16:
+                                default_cmode = CMODE_16;
+                                break;
+                         case 24:
+                         case 32:
+                                default_cmode = CMODE_32;
+                                break;
+                        }
+                }
+        }
+}
+
+static int __init control_init(void)
 {
         struct device_node *dp;
         char *option = NULL;
@@ -651,15 +682,16 @@ static void __init find_vram_size(struct fb_info_control *p)
 static int __init control_of_init(struct device_node *dp)
 {
         struct fb_info_control  *p;
-        unsigned long           addr;
-        int                     i;
+        struct resource         fb_res, reg_res;
 
         if (control_fb) {
                 printk(KERN_ERR "controlfb: only one control is supported\n");
                 return -ENXIO;
         }
-        if(dp->n_addrs != 2) {
-                printk(KERN_ERR "expecting 2 address for control (got %d)", dp->n_addrs);
+
+        if (of_pci_address_to_resource(dp, 2, &fb_res) ||
+            of_pci_address_to_resource(dp, 1, &reg_res)) {
+                printk(KERN_ERR "can't get 2 addresses for control\n");
                 return -ENXIO;
         }
         p = kmalloc(sizeof(*p), GFP_KERNEL);
@@ -669,18 +701,12 @@ static int __init control_of_init(struct device_node *dp)
         memset(p, 0, sizeof(*p));
 
         /* Map in frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                if (dp->addrs[i].size >= 0x800000) {
-                        p->fb_orig_base = addr;
-                        p->fb_orig_size = dp->addrs[i].size;
-                        /* use the big-endian aperture (??) */
-                        p->frame_buffer_phys = addr + 0x800000;
-                } else {
-                        p->control_regs_phys = addr;
-                        p->control_regs_size = dp->addrs[i].size;
-                }
-        }
+        p->fb_orig_base = fb_res.start;
+        p->fb_orig_size = fb_res.end - fb_res.start + 1;
+        /* use the big-endian aperture (??) */
+        p->frame_buffer_phys = fb_res.start + 0x800000;
+        p->control_regs_phys = reg_res.start;
+        p->control_regs_size = reg_res.end - reg_res.start + 1;
 
         if (!p->fb_orig_base ||
             !request_mem_region(p->fb_orig_base,p->fb_orig_size,"controlfb")) {
@@ -1059,43 +1085,3 @@ static void control_cleanup(void)
 }
 
 
-/*
- * Parse user speficied options (`video=controlfb:')
- */
-void __init control_setup(char *options)
-{
-        char *this_opt;
-
-        if (!options || !*options)
-                return;
-
-        while ((this_opt = strsep(&options, ",")) != NULL) {
-                if (!strncmp(this_opt, "vmode:", 6)) {
-                        int vmode = simple_strtoul(this_opt+6, NULL, 0);
-                        if (vmode > 0 && vmode <= VMODE_MAX &&
-                            control_mac_modes[vmode - 1].m[1] >= 0)
-                                default_vmode = vmode;
-                } else if (!strncmp(this_opt, "cmode:", 6)) {
-                        int depth = simple_strtoul(this_opt+6, NULL, 0);
-                        switch (depth) {
-                         case CMODE_8:
-                         case CMODE_16:
-                         case CMODE_32:
-                                default_cmode = depth;
-                                break;
-                         case 8:
-                                default_cmode = CMODE_8;
-                                break;
-                         case 15:
-                         case 16:
-                                default_cmode = CMODE_16;
-                                break;
-                         case 24:
-                         case 32:
-                                default_cmode = CMODE_32;
-                                break;
-                        }
-                }
-        }
-}
-
diff --git a/drivers/video/cyblafb.c b/drivers/video/cyblafb.c
index 03fbe83d71a8..e9f5dee67e3c 100644
--- a/drivers/video/cyblafb.c
+++ b/drivers/video/cyblafb.c
@@ -7,11 +7,12 @@
  *      tridentfb.c by Jani Monoses
  *      see files above for further credits
  *
- * TODO:
- *
  */
 
 #define CYBLAFB_DEBUG 0
+#define CYBLAFB_KD_GRAPHICS_QUIRK 1
+
+#define CYBLAFB_PIXMAPSIZE 8192
 
 #include <linux/config.h>
 #include <linux/module.h>
@@ -22,7 +23,7 @@
 #include <asm/types.h>
 #include <video/cyblafb.h>
 
-#define VERSION "0.54"
+#define VERSION "0.62"
 
 struct cyblafb_par {
         u32 pseudo_pal[16];
@@ -32,7 +33,9 @@ struct cyblafb_par {
 static struct fb_fix_screeninfo cyblafb_fix __devinitdata = {
         .id = "CyBla",
         .type = FB_TYPE_PACKED_PIXELS,
+        .xpanstep = 1,
         .ypanstep = 1,
+        .ywrapstep = 1,
         .visual = FB_VISUAL_PSEUDOCOLOR,
         .accel = FB_ACCEL_NONE,
 };
@@ -43,8 +46,9 @@ static int ref __devinitdata = 75;
 static int fp __devinitdata;
 static int crt __devinitdata;
 static int memsize __devinitdata;
-static int vesafb __devinitdata;
 
+static int basestride;
+static int vesafb;
 static int nativex;
 static int center;
 static int stretch;
@@ -52,26 +56,50 @@ static int pciwb = 1;
 static int pcirb = 1;
 static int pciwr = 1;
 static int pcirr = 1;
+static int disabled;
 static int verbosity;
 static int displaytype;
 
-static void __iomem * io_virt; // iospace virtual memory address
-
-module_param(mode,charp,0);
-module_param(bpp,int,0);
-module_param(ref,int,0);
-module_param(fp,int,0);
-module_param(crt,int,0);
-module_param(nativex,int,0);
-module_param(center,int,0);
-module_param(stretch,int,0);
-module_param(pciwb,int,0);
-module_param(pcirb,int,0);
-module_param(pciwr,int,0);
-module_param(pcirr,int,0);
-module_param(memsize,int,0);
-module_param(verbosity,int,0);
-module_param(vesafb,int,0);
+static void __iomem *io_virt;   // iospace virtual memory address
+
+module_param(mode, charp, 0);
+module_param(bpp, int, 0);
+module_param(ref, int, 0);
+module_param(fp, int, 0);
+module_param(crt, int, 0);
+module_param(nativex, int, 0);
+module_param(center, int, 0);
+module_param(stretch, int, 0);
+module_param(pciwb, int, 0);
+module_param(pcirb, int, 0);
+module_param(pciwr, int, 0);
+module_param(pcirr, int, 0);
+module_param(memsize, int, 0);
+module_param(verbosity, int, 0);
+
+//=========================================
+//
+// Well, we have to fix the upper layers.
+// Until this has been done, we work around
+// the bugs.
+//
+//=========================================
+
+#if (CYBLAFB_KD_GRAPHICS_QUIRK && CYBLAFB_DEBUG)
+        if (disabled) { \
+                printk("********\n");\
+                dump_stack();\
+                return val;\
+        }
+
+#elif CYBLAFB_KD_GRAPHICS_QUIRK
+#define KD_GRAPHICS_RETURN(val)\
+        if (disabled) {\
+                return val;\
+        }
+#else
+#define KD_GRAPHICS_RETURN(val)
+#endif
 
 //=========================================
 //
@@ -79,10 +107,10 @@ module_param(vesafb,int,0);
 //
 //=========================================
 
-#define out8(r,v) writeb(v,io_virt+r)
-#define out32(r,v) writel(v,io_virt+r)
-#define in8(r) readb(io_virt+r)
-#define in32(r) readl(io_virt+r)
+#define out8(r, v) writeb(v, io_virt + r)
+#define out32(r, v) writel(v, io_virt + r)
+#define in8(r) readb(io_virt + r)
+#define in32(r) readl(io_virt + r)
 
 //======================================
 //
@@ -90,47 +118,47 @@ module_param(vesafb,int,0);
 //
 //======================================
 
-static inline unsigned char read3X4(int reg)
+static inline u8 read3X4(u32 reg)
 {
-        out8(0x3D4,reg);
+        out8(0x3D4, reg);
         return in8(0x3D5);
 }
 
-static inline unsigned char read3C4(int reg)
+static inline u8 read3C4(u32 reg)
 {
-        out8(0x3C4,reg);
+        out8(0x3C4, reg);
         return in8(0x3C5);
 }
 
-static inline unsigned char read3CE(int reg)
+static inline u8 read3CE(u32 reg)
 {
-        out8(0x3CE,reg);
+        out8(0x3CE, reg);
         return in8(0x3CF);
 }
 
-static inline void write3X4(int reg,unsigned char val)
+static inline void write3X4(u32 reg, u8 val)
 {
-        out8(0x3D4,reg);
-        out8(0x3D5,val);
+        out8(0x3D4, reg);
+        out8(0x3D5, val);
 }
 
-static inline void write3C4(int reg,unsigned char val)
+static inline void write3C4(u32 reg, u8 val)
 {
-        out8(0x3C4,reg);
-        out8(0x3C5,val);
+        out8(0x3C4, reg);
+        out8(0x3C5, val);
 }
 
-static inline void write3CE(int reg,unsigned char val)
+static inline void write3CE(u32 reg, u8 val)
 {
-        out8(0x3CE,reg);
-        out8(0x3CF,val);
+        out8(0x3CE, reg);
+        out8(0x3CF, val);
 }
 
-static inline void write3C0(int reg,unsigned char val)
+static inline void write3C0(u32 reg, u8 val)
 {
-        in8(0x3DA);     // read to reset index
-        out8(0x3C0,reg);
-        out8(0x3C0,val);
+        in8(0x3DA);             // read to reset index
+        out8(0x3C0, reg);
+        out8(0x3C0, val);
 }
 
 //=================================================
@@ -139,58 +167,62 @@ static inline void write3C0(int reg,unsigned char val)
 //
 //=================================================
 
-static inline void enable_mmio(void)
+static void enable_mmio(void)
 {
-        int tmp;
+        u8 tmp;
 
-        outb(0x0B,0x3C4);
+        outb(0x0B, 0x3C4);
         inb(0x3C5);             // Set NEW mode
-        outb(SR0E,0x3C4);       // write enable a lot of extended ports
-        outb(0x80,0x3C5);
+        outb(SR0E, 0x3C4);      // write enable a lot of extended ports
+        outb(0x80, 0x3C5);
 
-        outb(SR11,0x3C4);       // write enable those extended ports that
-        outb(0x87,0x3C5);       // are not affected by SR0E_New
+        outb(SR11, 0x3C4);      // write enable those extended ports that
+        outb(0x87, 0x3C5);      // are not affected by SR0E_New
 
-        outb(CR1E,0x3d4);       // clear write protect bit for port 0x3c2
-        tmp=inb(0x3d5) & 0xBF;
-        outb(CR1E,0x3d4);
-        outb(tmp,0x3d5);
+        outb(CR1E, 0x3d4);      // clear write protect bit for port 0x3c2
+        tmp = inb(0x3d5) & 0xBF;
+        outb(CR1E, 0x3d4);
+        outb(tmp, 0x3d5);
 
-        outb(CR39,0x3D4);
-        outb(inb(0x3D5)|0x01,0x3D5); // Enable mmio, everything else untouched
+        outb(CR39, 0x3D4);
+        outb(inb(0x3D5) | 0x01, 0x3D5); // Enable mmio
 }
 
 //=================================================
 //
 // Set pixel clock VCLK1
-//   - multipliers set elswhere
-//   - freq in units of 0.01 MHz
+// - multipliers set elswhere
+// - freq in units of 0.01 MHz
+//
+// Hardware bug: SR18 >= 250 is broken for the
+//               cyberblade/i1
 //
 //=================================================
 
 static void set_vclk(struct cyblafb_par *par, int freq)
 {
-        u32 m,n,k;
-        int f,fi,d,di;
-        u8 lo=0,hi=0;
+        u32 m, n, k;
+        int f, fi, d, di;
+        u8 lo = 0, hi = 0;
 
         d = 2000;
         k = freq >= 10000 ? 0 : freq >= 5000 ? 1 : freq >= 2500 ? 2 : 3;
-        for(m = 0;m<64;m++)
-        for(n = 0;n<250;n++) { // max 249 is a hardware limit for cybla/i1 !
-                fi = (int)(((5864727*(n+8))/((m+2)*(1<<k)))>>12);
-                if ((di = abs(fi - freq)) < d) {
-                        d = di;
-                        f = fi;
-                        lo = (u8) n;
-                        hi = (u8) ((k<<6) | m);
+        for (m = 0; m < 64; m++)
+                for (n = 0; n < 250; n++) {
+                        fi = (int)(((5864727 * (n + 8)) /
+                                    ((m + 2) * (1 << k))) >> 12);
+                        if ((di = abs(fi - freq)) < d) {
+                                d = di;
+                                f = fi;
+                                lo = (u8) n;
+                                hi = (u8) ((k << 6) | m);
+                        }
                 }
-        }
-        write3C4(SR19,hi);
-        write3C4(SR18,lo);
-        if(verbosity > 1)
+        write3C4(SR19, hi);
+        write3C4(SR18, lo);
+        if (verbosity > 0)
                 output("pixclock = %d.%02d MHz, k/m/n %x %x %x\n",
-                freq/100,freq%100,(hi&0xc0)>>6,hi&0x3f,lo);
+                       freq / 100, freq % 100, (hi & 0xc0) >> 6, hi & 0x3f, lo);
 }
 
 //================================================
@@ -199,83 +231,83 @@ static void set_vclk(struct cyblafb_par *par, int freq)
 //
 //================================================
 
-static void cyblafb_setup_GE(int pitch,int bpp)
+static void cyblafb_setup_GE(int pitch, int bpp)
 {
-        int base = (pitch>>3)<<20;
+        KD_GRAPHICS_RETURN();
 
         switch (bpp) {
-                case  8: base |= (0<<29); break;
-                case 15: base |= (5<<29); break;
-                case 16: base |= (1<<29); break;
-                case 24:
-                case 32: base |= (2<<29); break;
+        case 8:
+                basestride = ((pitch >> 3) << 20) | (0 << 29);
+                break;
+        case 15:
+                basestride = ((pitch >> 3) << 20) | (5 << 29);
+                break;
+        case 16:
+                basestride = ((pitch >> 3) << 20) | (1 << 29);
+                break;
+        case 24:
+        case 32:
+                basestride = ((pitch >> 3) << 20) | (2 << 29);
+                break;
         }
 
-        write3X4(CR36,0x90);    // reset GE
-        write3X4(CR36,0x80);    // enable GE
-
-        out32(GE24,1<<7);       // reset all GE pointers
-        out32(GE24,0);
-
-        write3X4(CR2D,0x00);    // GE Timinigs, no delays
-
-        out32(GEB8,base); // Destination Stride / Buffer Base 0, p 133
-        out32(GEBC,base); // Destination Stride / Buffer Base 1, p 133
-        out32(GEC0,base); // Destination Stride / Buffer Base 2, p 133
-        out32(GEC4,base); // Destination Stride / Buffer Base 3, p 133
-        out32(GEC8,base); // Source Stride / Buffer Base 0, p 133
-        out32(GECC,base); // Source Stride / Buffer Base 1, p 133
-        out32(GED0,base); // Source Stride / Buffer Base 2, p 133
-        out32(GED4,base); // Source Stride / Buffer Base 3, p 133
-        out32(GE6C,0);    // Pattern and Style, p 129, ok
+        write3X4(CR36, 0x90);   // reset GE
+        write3X4(CR36, 0x80);   // enable GE
+        out32(GE24, 1 << 7);    // reset all GE pointers by toggling
+        out32(GE24, 0);         //   d7 of GE24
+        write3X4(CR2D, 0x00);   // GE Timinigs, no delays
+        out32(GE6C, 0);         // Pattern and Style, p 129, ok
 }
 
 //=====================================================================
 //
-// Although this is a .fb_sync function that could be enabled in
-// cyblafb_ops, we do not include it there. We sync immediately before
-// new GE operations to improve performance.
+// Cyberblade specific syncing
+//
+//   A timeout might be caused by disabled mmio.
+//   Cause:
+//     - bit CR39 & 1 == 0 upon return, X trident driver bug
+//     - kdm bug (KD_GRAPHICS not set on first switch)
+//     - kernel design flaw (it believes in the correctness
+//       of kdm/X
+//   First we try to sync ignoring that problem, as most of the
+//   time that will succeed immediately and the enable_mmio()
+//   would only degrade performance.
 //
 //=====================================================================
 
 static int cyblafb_sync(struct fb_info *info)
 {
-        int status, i=100000;
-        while( ((status=in32(GE20)) & 0xFA800000) && i != 0)
+        u32 status, i = 100000;
+
+        KD_GRAPHICS_RETURN(0);
+
+        while (((status = in32(GE20)) & 0xFe800000) && i != 0)
                 i--;
 
         if (i == 0) {
-                // The timeout might be caused by disabled mmio.
-                // Cause:
-                //   - bit CR39 & 1 == 0 upon return, X trident driver bug
-                //   - kdm bug (KD_GRAPHICS not set on first switch)
-                //   - kernel design flaw (it believes in the correctness
-                //     of kdm/X
-                // So we make sure that mmio is enabled first ...
                 enable_mmio();
-//              show_trace(NULL,&status);
-                i=1000000;
-                while( ((status=in32(GE20)) & 0xFA800000) && i != 0)
+                i = 1000000;
+                while (((status = in32(GE20)) & 0xFA800000) && i != 0)
                         i--;
                 if (i == 0) {
-                        output("GE Timeout, status: %x\n",status);
-                        if(status & 0x80000000)
+                        output("GE Timeout, status: %x\n", status);
+                        if (status & 0x80000000)
                                 output("Bresenham Engine : Busy\n");
-                        if(status & 0x40000000)
+                        if (status & 0x40000000)
                                 output("Setup Engine     : Busy\n");
-                        if(status & 0x20000000)
+                        if (status & 0x20000000)
                                 output("SP / DPE         : Busy\n");
-                        if(status & 0x10000000)
+                        if (status & 0x10000000)
                                 output("Memory Interface : Busy\n");
-                        if(status & 0x08000000)
+                        if (status & 0x08000000)
                                 output("Com Lst Proc     : Busy\n");
-                        if(status & 0x04000000)
+                        if (status & 0x04000000)
                                 output("Block Write      : Busy\n");
-                        if(status & 0x02000000)
+                        if (status & 0x02000000)
                                 output("Command Buffer   : Full\n");
-                        if(status & 0x01000000)
+                        if (status & 0x01000000)
                                 output("RESERVED         : Busy\n");
-                        if(status & 0x00800000)
+                        if (status & 0x00800000)
                                 output("PCI Write Buffer : Busy\n");
                         cyblafb_setup_GE(info->var.xres,
                                          info->var.bits_per_pixel);
@@ -291,142 +323,193 @@ static int cyblafb_sync(struct fb_info *info)
 //
 //==============================
 
-static void cyblafb_fillrect(struct fb_info * info,
-                             const struct fb_fillrect *fr)
+static void cyblafb_fillrect(struct fb_info *info, const struct fb_fillrect *fr)
 {
-        int bpp = info->var.bits_per_pixel;
-        int col;
+        u32 bpp = info->var.bits_per_pixel, col, desty, height;
+
+        KD_GRAPHICS_RETURN();
 
         switch (bpp) {
-                default:
-                case 8: col = fr->color;
-                        col |= col <<8;
-                        col |= col <<16;
-                        break;
-                case 16: col = ((u32 *)(info->pseudo_palette))[fr->color];
-                         col |= col <<16;
-                         break;
-                case 32: col = ((u32 *)(info->pseudo_palette))[fr->color];
-                         break;
+        default:
+        case 8:
+                col = fr->color;
+                col |= col << 8;
+                col |= col << 16;
+                break;
+        case 16:
+                col = ((u32 *) (info->pseudo_palette))[fr->color];
+                col |= col << 16;
+                break;
+        case 32:
+                col = ((u32 *) (info->pseudo_palette))[fr->color];
+                break;
         }
 
-        cyblafb_sync(info);
-
-        out32(GE60,col);
-        out32(GE48,fr->rop ? 0x66:ROP_S);
-        out32(GE44,0x20000000|1<<19|1<<4|2<<2);
-        out32(GE08,point(fr->dx,fr->dy));
-        out32(GE0C,point(fr->dx+fr->width-1,fr->dy+fr->height-1));
-
+        desty = fr->dy;
+        height = fr->height;
+        while (height) {
+                out32(GEB8, basestride | ((desty * info->var.xres_virtual *
+                                           bpp) >> 6));
+                out32(GE60, col);
+                out32(GE48, fr->rop ? 0x66 : ROP_S);
+                out32(GE44, 0x20000000 | 1 << 19 | 1 << 4 | 2 << 2);
+                out32(GE08, point(fr->dx, 0));
+                out32(GE0C, point(fr->dx + fr->width - 1,
+                                  height > 4096 ? 4095 : height - 1));
+                if (likely(height <= 4096))
+                        return;
+                desty += 4096;
+                height -= 4096;
+        }
 }
 
-//==============================
+//================================================
 //
 // Cyberblade specific copyarea
 //
-//==============================
+// This function silently assumes that it never
+// will be called with width or height exceeding
+// 4096.
+//
+//================================================
 
-static void cyblafb_copyarea(struct fb_info *info,
-                             const struct fb_copyarea *ca)
+static void cyblafb_copyarea(struct fb_info *info, const struct fb_copyarea *ca)
 {
-        __u32 s1,s2,d1,d2;
-        int direction;
+        u32 s1, s2, d1, d2, direction;
+
+        KD_GRAPHICS_RETURN();
+
+        s1 = point(ca->sx, 0);
+        s2 = point(ca->sx + ca->width - 1, ca->height - 1);
+        d1 = point(ca->dx, 0);
+        d2 = point(ca->dx + ca->width - 1, ca->height - 1);
 
-        s1 = point(ca->sx,ca->sy);
-        s2 = point(ca->sx+ca->width-1,ca->sy+ca->height-1);
-        d1 = point(ca->dx,ca->dy);
-        d2 = point(ca->dx+ca->width-1,ca->dy+ca->height-1);
         if ((ca->sy > ca->dy) || ((ca->sy == ca->dy) && (ca->sx > ca->dx)))
                 direction = 0;
         else
                 direction = 2;
 
-        cyblafb_sync(info);
-
-        out32(GE44,0xa0000000|1<<19|1<<2|direction);
-        out32(GE00,direction?s2:s1);
-        out32(GE04,direction?s1:s2);
-        out32(GE08,direction?d2:d1);
-        out32(GE0C,direction?d1:d2);
-
+        out32(GEB8, basestride | ((ca->dy * info->var.xres_virtual *
+                                   info->var.bits_per_pixel) >> 6));
+        out32(GEC8, basestride | ((ca->sy * info->var.xres_virtual *
+                                   info->var.bits_per_pixel) >> 6));
+        out32(GE44, 0xa0000000 | 1 << 19 | 1 << 2 | direction);
+        out32(GE00, direction ? s2 : s1);
+        out32(GE04, direction ? s1 : s2);
+        out32(GE08, direction ? d2 : d1);
+        out32(GE0C, direction ? d1 : d2);
 }
 
 //=======================================================================
 //
 // Cyberblade specific imageblit
 //
-// Accelerated for the most usual case, blitting 1-bit deep character
-// character images. Everything else is passed to the generic imageblit.
+// Accelerated for the most usual case, blitting 1 - bit deep
+// character images. Everything else is passed to the generic imageblit
+// unless it is so insane that it is better to printk an alert.
+//
+// Hardware bug: _Never_ blit across pixel column 2048, that will lock
+// the system. We split those blit requests into three blitting
+// operations.
 //
 //=======================================================================
 
 static void cyblafb_imageblit(struct fb_info *info,
                               const struct fb_image *image)
 {
-
         u32 fgcol, bgcol;
+        u32 *pd = (u32 *) image->data;
+        u32 bpp = info->var.bits_per_pixel;
 
-        int i;
-        int bpp = info->var.bits_per_pixel;
-        int index = 0;
-        int index_end=image->height * image->width / 8;
-        int width_dds=image->width / 32;
-        int width_dbs=image->width % 32;
-
-        if (image->depth != 1 || bpp < 8 || bpp > 32 || bpp % 8 != 0 ||
-            image->width % 8 != 0 || image->width == 0 || image->height == 0) {
-                cfb_imageblit(info,image);
+        KD_GRAPHICS_RETURN();
+
+        // Used only for drawing the penguine (image->depth > 1)
+        if (image->depth != 1) {
+                cfb_imageblit(info, image);
+                return;
+        }
+        // That should never happen, but it would be fatal
+        if (image->width == 0 || image->height == 0) {
+                output("imageblit: width/height 0 detected\n");
                 return;
         }
 
         if (info->fix.visual == FB_VISUAL_TRUECOLOR ||
             info->fix.visual == FB_VISUAL_DIRECTCOLOR) {
-                fgcol = ((u32*)(info->pseudo_palette))[image->fg_color];
-                bgcol = ((u32*)(info->pseudo_palette))[image->bg_color];
+                fgcol = ((u32 *) (info->pseudo_palette))[image->fg_color];
+                bgcol = ((u32 *) (info->pseudo_palette))[image->bg_color];
         } else {
                 fgcol = image->fg_color;
                 bgcol = image->bg_color;
         }
 
         switch (bpp) {
-                case 8:
-                        fgcol |= fgcol <<8; fgcol |= fgcol <<16;
-                        bgcol |= bgcol <<8; bgcol |= bgcol <<16;
-                        break;
-                case 16:
-                        fgcol |= fgcol <<16;
-                        bgcol |= bgcol <<16;
-                        break;
-                default:
-                         break;
+        case 8:
+                fgcol |= fgcol << 8;
+                bgcol |= bgcol << 8;
+        case 16:
+                fgcol |= fgcol << 16;
+                bgcol |= bgcol << 16;
+        default:
+                break;
         }
 
-        cyblafb_sync(info);
-
-        out32(GE60,fgcol);
-        out32(GE64,bgcol);
-        out32(GE44,0xa0000000 | 1<<20 | 1<<19);
-        out32(GE08,point(image->dx,image->dy));
-        out32(GE0C,point(image->dx+image->width-1,image->dy+image->height-1));
+        out32(GEB8, basestride | ((image->dy * info->var.xres_virtual *
+                                   bpp) >> 6));
+        out32(GE60, fgcol);
+        out32(GE64, bgcol);
+
+        if (!(image->dx < 2048 && (image->dx + image->width - 1) >= 2048)) {
+                u32 dds = ((image->width + 31) >> 5) * image->height;
+                out32(GE44, 0xa0000000 | 1 << 20 | 1 << 19);
+                out32(GE08, point(image->dx, 0));
+                out32(GE0C, point(image->dx + image->width - 1,
+                                  image->height - 1));
+                while (dds--)
+                        out32(GE9C, *pd++);
+        } else {
+                int i, j;
+                u32 ddstotal = (image->width + 31) >> 5;
+                u32 ddsleft = (2048 - image->dx + 31) >> 5;
+                u32 skipleft = ddstotal - ddsleft;
+
+                out32(GE44, 0xa0000000 | 1 << 20 | 1 << 19);
+                out32(GE08, point(image->dx, 0));
+                out32(GE0C, point(2048 - 1, image->height - 1));
+                for (i = 0; i < image->height; i++) {
+                        for (j = 0; j < ddsleft; j++)
+                                out32(GE9C, *pd++);
+                        pd += skipleft;
+                }
 
-        while(index < index_end) {
-                const char *p = image->data + index;
-                for(i=0;i<width_dds;i++) {
-                        out32(GE9C,*(u32*)p);
-                        p+=4;
-                        index+=4;
+                if (image->dx % 32) {
+                        out32(GE44, 0xa0000000 | 1 << 20 | 1 << 19);
+                        out32(GE08, point(2048, 0));
+                        if (image->width > ddsleft << 5)
+                                out32(GE0C, point(image->dx + (ddsleft << 5) -
+                                                  1, image->height - 1));
+                        else
+                                out32(GE0C, point(image->dx + image->width - 1,
+                                                  image->height - 1));
+                        pd = ((u32 *) image->data) + ddstotal - skipleft - 1;
+                        for (i = 0; i < image->height; i++) {
+                                out32(GE9C, swab32(swab32(*pd) << ((32 -
+                                            (image->dx & 31)) & 31)));
+                                pd += ddstotal;
+                        }
                 }
-                switch(width_dbs) {
-                case 0: break;
-                case 8: out32(GE9C,*(u8*)p);
-                        index+=1;
-                        break;
-                case 16: out32(GE9C,*(u16*)p);
-                        index+=2;
-                        break;
-                case 24: out32(GE9C,*(u16*)p | *(u8*)(p+2)<<16);
-                        index+=3;
-                        break;
+
+                if (skipleft) {
+                        out32(GE44, 0xa0000000 | 1 << 20 | 1 << 19);
+                        out32(GE08, point(image->dx + (ddsleft << 5), 0));
+                        out32(GE0C, point(image->dx + image->width - 1,
+                                          image->height - 1));
+                        pd = (u32 *) image->data;
+                        for (i = 0; i < image->height; i++) {
+                                pd += ddsleft;
+                                for (j = 0; j < skipleft; j++)
+                                        out32(GE9C, *pd++);
+                        }
                 }
         }
 }
@@ -443,7 +526,6 @@ static int cyblafb_check_var(struct fb_var_screeninfo *var,
                              struct fb_info *info)
 {
         int bpp = var->bits_per_pixel;
-        int s,t,maxvyres;
 
         //
         // we try to support 8, 16, 24 and 32 bpp modes,
@@ -453,9 +535,9 @@ static int cyblafb_check_var(struct fb_var_screeninfo *var,
         // (This is what tridentfb does ... will be changed in the future)
         //
         //
-        if ( bpp % 8 != 0 || bpp < 8 || bpp >32)
+        if (bpp % 8 != 0 || bpp < 8 || bpp > 32)
                 bpp = 8;
-        if (bpp == 24 )
+        if (bpp == 24)
                 bpp = var->bits_per_pixel = 32;
 
         //
@@ -472,65 +554,93 @@ static int cyblafb_check_var(struct fb_var_screeninfo *var,
                 return -EINVAL;
 
         //
-        // xres != xres_virtual is broken, fail if such an
-        // unusual mode is requested
+        // we do not allow vclk to exceed 230 MHz. If the requested
+        // vclk is too high, we default to 200 MHz
         //
-        if (var->xres != var->xres_virtual)
-                return -EINVAL;
+        if ((bpp == 32 ? 200000000 : 100000000) / var->pixclock > 23000)
+                var->pixclock = (bpp == 32 ? 200000000 : 100000000) / 20000;
 
         //
-        // we do not allow vclk to exceed 230 MHz
+        // enforce (h|v)sync_len limits
         //
-        if ((bpp==32 ? 200000000 : 100000000) / var->pixclock > 23000)
-                return -EINVAL;
+        var->hsync_len &= ~7;
+        if(var->hsync_len > 248)
+                var->hsync_len = 248;
+
+        var->vsync_len &= 15;
 
         //
-        // calc max yres_virtual that would fit in memory
-        // and max yres_virtual that could be used for scrolling
-        // and use minimum of the results as maxvyres
-        //
-        // adjust vyres_virtual to maxvyres if necessary
-        // fail if requested yres is bigger than maxvyres
+        // Enforce horizontal and vertical hardware limits.
+        // 1600x1200 is mentioned as a maximum, but higher resolutions could
+        // work with slow refresh, small margins and short sync.
         //
-        s = (0x1fffff / (var->xres * bpp/8)) + var->yres;
-        t = info->fix.smem_len / (var->xres * bpp/8);
-        maxvyres = t < s ? t : s;
-        if (maxvyres < var->yres_virtual)
-                var->yres_virtual=maxvyres;
-        if (maxvyres < var->yres)
+        var->xres &= ~7;
+
+        if (((var->xres + var->left_margin + var->right_margin +
+                        var->hsync_len) > (bpp == 32 ? 2040 : 4088)) ||
+                        ((var->yres + var->upper_margin + var->lower_margin +
+                        var->vsync_len) > 2047))
                 return -EINVAL;
 
-        switch (bpp) {
-                case 8:
-                        var->red.offset = 0;
-                        var->green.offset = 0;
-                        var->blue.offset = 0;
-                        var->red.length = 6;
-                        var->green.length = 6;
-                        var->blue.length = 6;
-                        break;
-                case 16:
-                        var->red.offset = 11;
-                        var->green.offset = 5;
-                        var->blue.offset = 0;
-                        var->red.length = 5;
-                        var->green.length = 6;
-                        var->blue.length = 5;
-                        break;
-                case 32:
-                        var->red.offset = 16;
-                        var->green.offset = 8;
-                        var->blue.offset = 0;
-                        var->red.length = 8;
-                        var->green.length = 8;
-                        var->blue.length = 8;
-                        break;
-                default:
+        if ((var->xres > 1600) || (var->yres > 1200))
+                output("Mode %dx%d exceeds documented limits.\n",
+                                           var->xres, var->yres);
+        //
+        // try to be smart about (x|y)res_virtual problems.
+        //
+        if (var->xres > var->xres_virtual)
+                var->xres_virtual = var->xres;
+        if (var->yres > var->yres_virtual)
+                var->yres_virtual = var->yres;
+
+        if (bpp == 8 || bpp == 16) {
+                if (var->xres_virtual > 4088)
+                        var->xres_virtual = 4088;
+        } else {
+                if (var->xres_virtual > 2040)
+                        var->xres_virtual = 2040;
+        }
+        var->xres_virtual &= ~7;
+        while (var->xres_virtual * var->yres_virtual * bpp / 8 >
+               info->fix.smem_len) {
+                if (var->yres_virtual > var->yres)
+                        var->yres_virtual--;
+                else if (var->xres_virtual > var->xres)
+                        var->xres_virtual -= 8;
+                else
                         return -EINVAL;
         }
 
-        return 0;
+        switch (bpp) {
+        case 8:
+                var->red.offset = 0;
+                var->green.offset = 0;
+                var->blue.offset = 0;
+                var->red.length = 6;
+                var->green.length = 6;
+                var->blue.length = 6;
+                break;
+        case 16:
+                var->red.offset = 11;
+                var->green.offset = 5;
+                var->blue.offset = 0;
+                var->red.length = 5;
+                var->green.length = 6;
+                var->blue.length = 5;
+                break;
+        case 32:
+                var->red.offset = 16;
+                var->green.offset = 8;
+                var->blue.offset = 0;
+                var->red.length = 8;
+                var->green.length = 8;
+                var->blue.length = 8;
+                break;
+        default:
+                return -EINVAL;
+        }
 
+        return 0;
 }
 
 //=====================================================================
@@ -543,23 +653,25 @@ static int cyblafb_check_var(struct fb_var_screeninfo *var,
 // it, so it is also safe to be used here. BTW: datasheet CR0E on page
 // 90 really is CR1E, the real CRE is documented on page 72.
 //
+// BUT:
+//
+// As of internal version 0.60 we do not use vga panning any longer.
+// Vga panning did not allow us the use of all available video memory
+// and thus prevented ywrap scrolling. We do use the "right view"
+// register now.
+//
+//
 //=====================================================================
 
 static int cyblafb_pan_display(struct fb_var_screeninfo *var,
                                struct fb_info *info)
 {
-        unsigned int offset;
+        KD_GRAPHICS_RETURN(0);
 
-        offset=(var->xoffset+(var->yoffset*var->xres))*var->bits_per_pixel/32;
         info->var.xoffset = var->xoffset;
         info->var.yoffset = var->yoffset;
-
-        write3X4(CR0D,offset & 0xFF);
-        write3X4(CR0C,(offset & 0xFF00) >> 8);
-        write3X4(CR1E,(read3X4(CR1E) & 0xDF) | ((offset & 0x10000) >> 11));
-        write3X4(CR27,(read3X4(CR27) & 0xF8) | ((offset & 0xE0000) >> 17));
-        write3X4(CR2B,(read3X4(CR2B) & 0xDF) | ((offset & 0x100000) >> 15));
-
+        out32(GE10, 0x80000000 | ((var->xoffset + (var->yoffset *
+                    var->xres_virtual)) * var->bits_per_pixel / 32));
         return 0;
 }
 
@@ -578,56 +690,96 @@ static void regdump(struct cyblafb_par *par)
                 return;
 
         printk("\n");
-        for(i=0; i<=0xff; i++) {
-                outb(i,0x3d4);
-                printk("CR%02x=%02x ",i,inb(0x3d5));
-                if (i%16==15)
+        for (i = 0; i <= 0xff; i++) {
+                outb(i, 0x3d4);
+                printk("CR%02x=%02x ", i, inb(0x3d5));
+                if (i % 16 == 15)
                         printk("\n");
         }
 
-        outb(0x30,0x3ce);
-        outb(inb(0x3cf) | 0x40,0x3cf);
-        for(i=0; i<=0x1f; i++) {
-                if (i==0 || (i>2 && i<8) || i==0x10 || i==0x11 || i==0x16) {
-                        outb(i,0x3d4);
-                        printk("CR%02x=%02x ",i,inb(0x3d5));
+        outb(0x30, 0x3ce);
+        outb(inb(0x3cf) | 0x40, 0x3cf);
+        for (i = 0; i <= 0x1f; i++) {
+                if (i == 0 || (i > 2 && i < 8) || i == 0x10 || i == 0x11
+                    || i == 0x16) {
+                        outb(i, 0x3d4);
+                        printk("CR%02x=%02x ", i, inb(0x3d5));
                 } else
                         printk("------- ");
-                if (i%16==15)
+                if (i % 16 == 15)
                         printk("\n");
         }
-        outb(0x30,0x3ce);
-        outb(inb(0x3cf) & 0xbf,0x3cf);
+        outb(0x30, 0x3ce);
+        outb(inb(0x3cf) & 0xbf, 0x3cf);
 
         printk("\n");
-        for(i=0; i<=0x7f; i++) {
-                outb(i,0x3ce);
-                printk("GR%02x=%02x ",i,inb(0x3cf));
-                if (i%16==15)
+        for (i = 0; i <= 0x7f; i++) {
+                outb(i, 0x3ce);
+                printk("GR%02x=%02x ", i, inb(0x3cf));
+                if (i % 16 == 15)
                         printk("\n");
         }
 
         printk("\n");
-        for(i=0; i<=0xff; i++) {
-                outb(i,0x3c4);
-                printk("SR%02x=%02x ",i,inb(0x3c5));
-                if (i%16==15)
+        for (i = 0; i <= 0xff; i++) {
+                outb(i, 0x3c4);
+                printk("SR%02x=%02x ", i, inb(0x3c5));
+                if (i % 16 == 15)
                         printk("\n");
         }
 
         printk("\n");
-        for(i=0; i <= 0x1F; i++) {
-                inb(0x3da); // next access is index!
-                outb(i,0x3c0);
-                printk("AR%02x=%02x ",i,inb(0x3c1));
-                if (i%16==15)
+        for (i = 0; i <= 0x1F; i++) {
+                inb(0x3da);     // next access is index!
+                outb(i, 0x3c0);
+                printk("AR%02x=%02x ", i, inb(0x3c1));
+                if (i % 16 == 15)
                         printk("\n");
         }
         printk("\n");
 
-        inb(0x3DA);                     // reset internal flag to 3c0 index
-        outb(0x20,0x3C0);               // enable attr
+        inb(0x3DA);             // reset internal flag to 3c0 index
+        outb(0x20, 0x3C0);      // enable attr
+
+        return;
+}
+
+//=======================================================================
+//
+// Save State
+//
+// This function is called while a switch to KD_TEXT is in progress,
+// before any of the other functions are called.
+//
+//=======================================================================
 
+static void cyblafb_save_state(struct fb_info *info)
+{
+        struct cyblafb_par *par = info->par;
+        if (verbosity > 0)
+                output("Switching to KD_TEXT\n");
+        disabled = 0;
+        regdump(par);
+        enable_mmio();
+        return;
+}
+
+//=======================================================================
+//
+// Restore State
+//
+// This function is called while a switch to KD_GRAPHICS is in progress,
+// We have to turn on vga style panning registers again because the
+// trident driver of X does not know about GE10.
+//
+//=======================================================================
+
+static void cyblafb_restore_state(struct fb_info *info)
+{
+        if (verbosity > 0)
+                output("Switching to KD_GRAPHICS\n");
+        out32(GE10, 0);
+        disabled = 1;
         return;
 }
 
@@ -640,32 +792,34 @@ static void regdump(struct cyblafb_par *par)
 static int cyblafb_set_par(struct fb_info *info)
 {
         struct cyblafb_par *par = info->par;
-        u32
-        htotal,hdispend,hsyncstart,hsyncend,hblankstart,hblankend,preendfetch,
-                vtotal,vdispend,vsyncstart,vsyncend,vblankstart,vblankend;
+        u32 htotal, hdispend, hsyncstart, hsyncend, hblankstart,
+            hblankend, preendfetch, vtotal, vdispend, vsyncstart,
+            vsyncend, vblankstart, vblankend;
         struct fb_var_screeninfo *var = &info->var;
         int bpp = var->bits_per_pixel;
         int i;
 
+        KD_GRAPHICS_RETURN(0);
+
         if (verbosity > 0)
                 output("Switching to new mode: "
                        "fbset -g %d %d %d %d %d -t %d %d %d %d %d %d %d\n",
-                        var->xres,var->yres,var->xres_virtual,
-                        var->yres_virtual,var->bits_per_pixel,var->pixclock,
-                        var->left_margin,var->right_margin,var->upper_margin,
-                        var->lower_margin,var->hsync_len,var->vsync_len);
+                       var->xres, var->yres, var->xres_virtual,
+                       var->yres_virtual, var->bits_per_pixel, var->pixclock,
+                       var->left_margin, var->right_margin, var->upper_margin,
+                       var->lower_margin, var->hsync_len, var->vsync_len);
 
         htotal = (var->xres + var->left_margin + var->right_margin +
-                                                 var->hsync_len) / 8 - 5;
-        hdispend = var->xres/8 - 1;
-        hsyncstart = (var->xres + var->right_margin)/8;
-        hsyncend = var->hsync_len/8;
+                  var->hsync_len) / 8 - 5;
+        hdispend = var->xres / 8 - 1;
+        hsyncstart = (var->xres + var->right_margin) / 8;
+        hsyncend = var->hsync_len / 8;
         hblankstart = hdispend + 1;
         hblankend = htotal + 3; // should be htotal + 5, bios does it this way
-        preendfetch = ((var->xres >> 3) + 1) * ((bpp+1) >> 3);
+        preendfetch = ((var->xres >> 3) + 1) * ((bpp + 1) >> 3);
 
         vtotal = var->yres + var->upper_margin + var->lower_margin +
-                                                 var->vsync_len - 2;
+                                                        var->vsync_len - 2;
         vdispend = var->yres - 1;
         vsyncstart = var->yres + var->lower_margin;
         vblankstart = var->yres;
@@ -674,101 +828,99 @@ static int cyblafb_set_par(struct fb_info *info)
 
         enable_mmio();          // necessary! ... check X ...
 
-        write3X4(CR11,read3X4(CR11) & 0x7F); // unlock cr00 .. cr07
+        write3X4(CR11, read3X4(CR11) & 0x7F);   // unlock cr00 .. cr07
 
-        write3CE(GR30,8);
+        write3CE(GR30, 8);
 
         if ((displaytype == DISPLAY_FP) && var->xres < nativex) {
 
                 // stretch or center ?
 
-                out8(0x3C2,0xEB);
+                out8(0x3C2, 0xEB);
 
-                write3CE(GR30,read3CE(GR30) | 0x81); // shadow mode on
+                write3CE(GR30, read3CE(GR30) | 0x81);   // shadow mode on
 
                 if (center) {
-                        write3CE(GR52,(read3CE(GR52) & 0x7C) | 0x80);
-                        write3CE(GR53,(read3CE(GR53) & 0x7C) | 0x80);
-                }
-                else if (stretch) {
-                        write3CE(GR5D,0);
-                        write3CE(GR52,(read3CE(GR52) & 0x7C) | 1);
-                        write3CE(GR53,(read3CE(GR53) & 0x7C) | 1);
+                        write3CE(GR52, (read3CE(GR52) & 0x7C) | 0x80);
+                        write3CE(GR53, (read3CE(GR53) & 0x7C) | 0x80);
+                } else if (stretch) {
+                        write3CE(GR5D, 0);
+                        write3CE(GR52, (read3CE(GR52) & 0x7C) | 1);
+                        write3CE(GR53, (read3CE(GR53) & 0x7C) | 1);
                 }
 
         } else {
-                out8(0x3C2,0x2B);
-                write3CE(GR30,8);
+                out8(0x3C2, 0x2B);
+                write3CE(GR30, 8);
         }
 
         //
         // Setup CRxx regs
         //
 
-        write3X4(CR00,htotal & 0xFF);
-        write3X4(CR01,hdispend & 0xFF);
-        write3X4(CR02,hblankstart & 0xFF);
-        write3X4(CR03,hblankend & 0x1F);
-        write3X4(CR04,hsyncstart & 0xFF);
-        write3X4(CR05,(hsyncend & 0x1F) | ((hblankend & 0x20)<<2));
-        write3X4(CR06,vtotal & 0xFF);
-        write3X4(CR07,(vtotal & 0x100) >> 8 |
-                      (vdispend & 0x100) >> 7 |
-                      (vsyncstart & 0x100) >> 6 |
-                      (vblankstart & 0x100) >> 5 |
-                      0x10 |
-                      (vtotal & 0x200) >> 4 |
-                      (vdispend & 0x200) >> 3 |
-                      (vsyncstart & 0x200) >> 2);
-        write3X4(CR08,0);
-        write3X4(CR09,(vblankstart & 0x200) >> 4 | 0x40 |  // FIX !!!
-                      ((info->var.vmode & FB_VMODE_DOUBLE) ? 0x80 : 0));
-        write3X4(CR0A,0);  // Init to some reasonable default
-        write3X4(CR0B,0);  // Init to some reasonable default
-        write3X4(CR0C,0);  // Offset 0
-        write3X4(CR0D,0);  // Offset 0
-        write3X4(CR0E,0);  // Init to some reasonable default
-        write3X4(CR0F,0);  // Init to some reasonable default
-        write3X4(CR10,vsyncstart & 0xFF);
-        write3X4(CR11,(vsyncend & 0x0F));
-        write3X4(CR12,vdispend & 0xFF);
-        write3X4(CR13,((info->var.xres * bpp)/(4*16)) & 0xFF);
-        write3X4(CR14,0x40);  // double word mode
-        write3X4(CR15,vblankstart & 0xFF);
-        write3X4(CR16,vblankend & 0xFF);
-        write3X4(CR17,0xC3);
-        write3X4(CR18,0xFF);
+        write3X4(CR00, htotal & 0xFF);
+        write3X4(CR01, hdispend & 0xFF);
+        write3X4(CR02, hblankstart & 0xFF);
+        write3X4(CR03, hblankend & 0x1F);
+        write3X4(CR04, hsyncstart & 0xFF);
+        write3X4(CR05, (hsyncend & 0x1F) | ((hblankend & 0x20) << 2));
+        write3X4(CR06, vtotal & 0xFF);
+        write3X4(CR07, (vtotal & 0x100) >> 8 |
+                       (vdispend & 0x100) >> 7 |
+                       (vsyncstart & 0x100) >> 6 |
+                       (vblankstart & 0x100) >> 5 |
+                       0x10 |
+                       (vtotal & 0x200) >> 4 |
+                       (vdispend & 0x200) >> 3 | (vsyncstart & 0x200) >> 2);
+        write3X4(CR08, 0);
+        write3X4(CR09, (vblankstart & 0x200) >> 4 | 0x40 |      // FIX !!!
+                       ((info->var.vmode & FB_VMODE_DOUBLE) ? 0x80 : 0));
+        write3X4(CR0A, 0);      // Init to some reasonable default
+        write3X4(CR0B, 0);      // Init to some reasonable default
+        write3X4(CR0C, 0);      // Offset 0
+        write3X4(CR0D, 0);      // Offset 0
+        write3X4(CR0E, 0);      // Init to some reasonable default
+        write3X4(CR0F, 0);      // Init to some reasonable default
+        write3X4(CR10, vsyncstart & 0xFF);
+        write3X4(CR11, (vsyncend & 0x0F));
+        write3X4(CR12, vdispend & 0xFF);
+        write3X4(CR13, ((info->var.xres_virtual * bpp) / (4 * 16)) & 0xFF);
+        write3X4(CR14, 0x40);   // double word mode
+        write3X4(CR15, vblankstart & 0xFF);
+        write3X4(CR16, vblankend & 0xFF);
+        write3X4(CR17, 0xE3);
+        write3X4(CR18, 0xFF);
         //       CR19: needed for interlaced modes ... ignore it for now
-        write3X4(CR1A,0x07); // Arbitration Control Counter 1
-        write3X4(CR1B,0x07); // Arbitration Control Counter 2
-        write3X4(CR1C,0x07); // Arbitration Control Counter 3
-        write3X4(CR1D,0x00); // Don't know, doesn't hurt ;-)
-        write3X4(CR1E,(info->var.vmode & FB_VMODE_INTERLACED) ? 0x84 : 0x80);
+        write3X4(CR1A, 0x07);   // Arbitration Control Counter 1
+        write3X4(CR1B, 0x07);   // Arbitration Control Counter 2
+        write3X4(CR1C, 0x07);   // Arbitration Control Counter 3
+        write3X4(CR1D, 0x00);   // Don't know, doesn't hurt ; -)
+        write3X4(CR1E, (info->var.vmode & FB_VMODE_INTERLACED) ? 0x84 : 0x80);
         //       CR1F: do not set, contains BIOS info about memsize
-        write3X4(CR20,0x20); // enabe wr buf, disable 16bit planar mode
-        write3X4(CR21,0x20); // enable linear memory access
+        write3X4(CR20, 0x20);   // enabe wr buf, disable 16bit planar mode
+        write3X4(CR21, 0x20);   // enable linear memory access
         //       CR22: RO cpu latch readback
         //       CR23: ???
         //       CR24: RO AR flag state
         //       CR25: RAMDAC rw timing, pclk buffer tristate control ????
         //       CR26: ???
-        write3X4(CR27,(vdispend & 0x400) >> 6 |
-                      (vsyncstart & 0x400) >> 5 |
-                      (vblankstart & 0x400) >> 4 |
-                      (vtotal & 0x400) >> 3 |
-                      0x8);
+        write3X4(CR27, (vdispend & 0x400) >> 6 |
+                       (vsyncstart & 0x400) >> 5 |
+                       (vblankstart & 0x400) >> 4 |
+                       (vtotal & 0x400) >> 3 |
+                       0x8);
         //       CR28: ???
-        write3X4(CR29,(read3X4(CR29) & 0xCF) |
-                      ((((info->var.xres * bpp) / (4*16)) & 0x300) >>4));
-        write3X4(CR2A,read3X4(CR2A) | 0x40);
-        write3X4(CR2B,(htotal & 0x100) >> 8 |
-                      (hdispend & 0x100) >> 7 |
-                      // (0x00 & 0x100) >> 6 |   hinterlace para bit 8 ???
-                      (hsyncstart & 0x100) >> 5 |
-                      (hblankstart & 0x100) >> 4);
+        write3X4(CR29, (read3X4(CR29) & 0xCF) | ((((info->var.xres_virtual *
+                        bpp) / (4 * 16)) & 0x300) >> 4));
+        write3X4(CR2A, read3X4(CR2A) | 0x40);
+        write3X4(CR2B, (htotal & 0x100) >> 8 |
+                       (hdispend & 0x100) >> 7 |
+                       // (0x00 & 0x100) >> 6 |   hinterlace para bit 8 ???
+                       (hsyncstart & 0x100) >> 5 |
+                       (hblankstart & 0x100) >> 4);
         //       CR2C: ???
         //       CR2D: initialized in cyblafb_setup_GE()
-        write3X4(CR2F,0x92); // conservative, better signal quality
+        write3X4(CR2F, 0x92);   // conservative, better signal quality
         //       CR30: reserved
         //       CR31: reserved
         //       CR32: reserved
@@ -777,96 +929,116 @@ static int cyblafb_set_par(struct fb_info *info)
         //       CR35: disabled in CR36
         //       CR36: initialized in cyblafb_setup_GE
         //       CR37: i2c, ignore for now
-        write3X4(CR38,(bpp == 8) ? 0x00 :       //
-                      (bpp == 16) ? 0x05 :      // highcolor
-                      (bpp == 24) ? 0x29 :      // packed 24bit truecolor
-                      (bpp == 32) ? 0x09 : 0);  // truecolor, 16 bit pixelbus
-        write3X4(CR39,0x01 |                    // MMIO enable
-                      (pcirb ? 0x02 : 0) | // pci read burst enable
-                      (pciwb ? 0x04 : 0)); // pci write burst enable
-        write3X4(CR55,0x1F | // pci clocks * 2 for STOP# during 1st data phase
-                      (pcirr ? 0x40 : 0) | // pci read retry enable
-                      (pciwr ? 0x80 : 0)); // pci write retry enable
-        write3X4(CR56,preendfetch >> 8 < 2 ? (preendfetch >> 8 & 0x01)|2 : 0);
-        write3X4(CR57,preendfetch >> 8 < 2 ? preendfetch & 0xff : 0);
-        write3X4(CR58,0x82);    // Bios does this .... don't know more
+        write3X4(CR38, (bpp == 8) ? 0x00 :      //
+                       (bpp == 16) ? 0x05 :     // highcolor
+                       (bpp == 24) ? 0x29 :     // packed 24bit truecolor
+                       (bpp == 32) ? 0x09 : 0); // truecolor, 16 bit pixelbus
+        write3X4(CR39, 0x01 |   // MMIO enable
+                       (pcirb ? 0x02 : 0) |     // pci read burst enable
+                       (pciwb ? 0x04 : 0));     // pci write burst enable
+        write3X4(CR55, 0x1F | // pci clocks * 2 for STOP# during 1st data phase
+                       (pcirr ? 0x40 : 0) |     // pci read retry enable
+                       (pciwr ? 0x80 : 0));     // pci write retry enable
+        write3X4(CR56, preendfetch >> 8 < 2 ? (preendfetch >> 8 & 0x01) | 2
+                                            : 0);
+        write3X4(CR57, preendfetch >> 8 < 2 ? preendfetch & 0xff : 0);
+        write3X4(CR58, 0x82);   // Bios does this .... don't know more
         //
         // Setup SRxx regs
         //
-        write3C4(SR00,3);
-        write3C4(SR01,1);       //set char clock 8 dots wide
-        write3C4(SR02,0x0F);    //enable 4 maps needed in chain4 mode
-        write3C4(SR03,0);       //no character map select
-        write3C4(SR04,0x0E);    //memory mode: ext mem, even, chain4
+        write3C4(SR00, 3);
+        write3C4(SR01, 1);      //set char clock 8 dots wide
+        write3C4(SR02, 0x0F);   //enable 4 maps needed in chain4 mode
+        write3C4(SR03, 0);      //no character map select
+        write3C4(SR04, 0x0E);   //memory mode: ext mem, even, chain4
 
-        out8(0x3C4,0x0b);
+        out8(0x3C4, 0x0b);
         in8(0x3C5);             // Set NEW mode
-        write3C4(SR0D,0x00);    // test ... check
+        write3C4(SR0D, 0x00);   // test ... check
 
-        set_vclk(par,(bpp==32 ? 200000000 : 100000000)/
-                 info->var.pixclock); //SR18,SR19
+        set_vclk(par, (bpp == 32 ? 200000000 : 100000000)
+                                        / info->var.pixclock);  //SR18, SR19
 
         //
         // Setup GRxx regs
         //
-        write3CE(GR00,0x00);    // test ... check
-        write3CE(GR01,0x00);    // test ... check
-        write3CE(GR02,0x00);    // test ... check
-        write3CE(GR03,0x00);    // test ... check
-        write3CE(GR04,0x00);    // test ... check
-        write3CE(GR05,0x40);    // no CGA compat,allow 256 col
-        write3CE(GR06,0x05);    // graphics mode
-        write3CE(GR07,0x0F);    // planes?
-        write3CE(GR08,0xFF);    // test ... check
-        write3CE(GR0F,(bpp==32)?0x1A:0x12); // div vclk by 2 if 32bpp, chain4
-        write3CE(GR20,0xC0);    // test ... check
-        write3CE(GR2F,0xA0);    // PCLK = VCLK, no skew,
+        write3CE(GR00, 0x00);   // test ... check
+        write3CE(GR01, 0x00);   // test ... check
+        write3CE(GR02, 0x00);   // test ... check
+        write3CE(GR03, 0x00);   // test ... check
+        write3CE(GR04, 0x00);   // test ... check
+        write3CE(GR05, 0x40);   // no CGA compat, allow 256 col
+        write3CE(GR06, 0x05);   // graphics mode
+        write3CE(GR07, 0x0F);   // planes?
+        write3CE(GR08, 0xFF);   // test ... check
+        write3CE(GR0F, (bpp == 32) ? 0x1A : 0x12); // vclk / 2 if 32bpp, chain4
+        write3CE(GR20, 0xC0);   // test ... check
+        write3CE(GR2F, 0xA0);   // PCLK = VCLK, no skew,
 
         //
         // Setup ARxx regs
         //
-        for(i = 0;i < 0x10;i++) // set AR00 .. AR0f
-                write3C0(i,i);
-        write3C0(AR10,0x41);    // graphics mode and support 256 color modes
-        write3C0(AR12,0x0F);    // planes
-        write3C0(AR13,0);       // horizontal pel panning
+        for (i = 0; i < 0x10; i++)      // set AR00 .. AR0f
+                write3C0(i, i);
+        write3C0(AR10, 0x41);   // graphics mode and support 256 color modes
+        write3C0(AR12, 0x0F);   // planes
+        write3C0(AR13, 0);      // horizontal pel panning
         in8(0x3DA);             // reset internal flag to 3c0 index
-        out8(0x3C0,0x20);       // enable attr
+        out8(0x3C0, 0x20);      // enable attr
 
         //
         // Setup hidden RAMDAC command register
         //
-        in8(0x3C8);  // these reads are
-        in8(0x3C6);  // necessary to
-        in8(0x3C6);  // unmask the RAMDAC
-        in8(0x3C6);  // command reg, otherwise
-        in8(0x3C6);  // we would write the pixelmask reg!
-        out8(0x3C6,(bpp ==  8) ? 0x00 :         // 256 colors
-                   (bpp == 15) ? 0x10 :         //
-                   (bpp == 16) ? 0x30 :         // hicolor
-                   (bpp == 24) ? 0xD0 :         // truecolor
-                   (bpp == 32) ? 0xD0 : 0);     // truecolor
+        in8(0x3C8);             // these reads are
+        in8(0x3C6);             // necessary to
+        in8(0x3C6);             // unmask the RAMDAC
+        in8(0x3C6);             // command reg, otherwise
+        in8(0x3C6);             // we would write the pixelmask reg!
+        out8(0x3C6, (bpp == 8) ? 0x00 : // 256 colors
+             (bpp == 15) ? 0x10 :       //
+             (bpp == 16) ? 0x30 :       // hicolor
+             (bpp == 24) ? 0xD0 :       // truecolor
+             (bpp == 32) ? 0xD0 : 0);   // truecolor
         in8(0x3C8);
 
         //
         // GR31 is not mentioned in the datasheet
         //
         if (displaytype == DISPLAY_FP)
-                write3CE(GR31,(read3CE(GR31) & 0x8F) |
+                write3CE(GR31, (read3CE(GR31) & 0x8F) |
                          ((info->var.yres > 1024) ? 0x50 :
-                         (info->var.yres >   768) ? 0x30 :
-                         (info->var.yres >   600) ? 0x20 :
-                         (info->var.yres >   480) ? 0x10 : 0));
+                          (info->var.yres > 768) ? 0x30 :
+                          (info->var.yres > 600) ? 0x20 :
+                          (info->var.yres > 480) ? 0x10 : 0));
 
         info->fix.visual = (bpp == 8) ? FB_VISUAL_PSEUDOCOLOR
                                       : FB_VISUAL_TRUECOLOR;
-        info->fix.line_length = info->var.xres * (bpp >> 3);
-        info->cmap.len = (bpp == 8) ? 256: 16;
+        info->fix.line_length = info->var.xres_virtual * (bpp >> 3);
+        info->cmap.len = (bpp == 8) ? 256 : 16;
 
         //
         // init acceleration engine
         //
-        cyblafb_setup_GE(info->var.xres,info->var.bits_per_pixel);
+        cyblafb_setup_GE(info->var.xres_virtual, info->var.bits_per_pixel);
+
+        //
+        // Set/clear flags to allow proper scroll mode selection.
+        //
+        if (var->xres == var->xres_virtual)
+                info->flags &= ~FBINFO_HWACCEL_XPAN;
+        else
+                info->flags |= FBINFO_HWACCEL_XPAN;
+
+        if (var->yres == var->yres_virtual)
+                info->flags &= ~FBINFO_HWACCEL_YPAN;
+        else
+                info->flags |= FBINFO_HWACCEL_YPAN;
+
+        if (info->fix.smem_len !=
+            var->xres_virtual * var->yres_virtual * bpp / 8)
+                info->flags &= ~FBINFO_HWACCEL_YWRAP;
+        else
+                info->flags |= FBINFO_HWACCEL_YWRAP;
 
         regdump(par);
 
@@ -885,27 +1057,27 @@ static int cyblafb_setcolreg(unsigned regno, unsigned red, unsigned green,
 {
         int bpp = info->var.bits_per_pixel;
 
+        KD_GRAPHICS_RETURN(0);
+
         if (regno >= info->cmap.len)
                 return 1;
 
         if (bpp == 8) {
-                out8(0x3C6,0xFF);
-                out8(0x3C8,regno);
-                out8(0x3C9,red>>10);
-                out8(0x3C9,green>>10);
-                out8(0x3C9,blue>>10);
-
-        } else if (bpp == 16)                           // RGB 565
-                ((u32*)info->pseudo_palette)[regno] =
-                        (red & 0xF800) |
-                        ((green & 0xFC00) >> 5) |
-                        ((blue & 0xF800) >> 11);
-        else if (bpp == 32)                             // ARGB 8888
-                ((u32*)info->pseudo_palette)[regno] =
-                        ((transp & 0xFF00) <<16) |
-                        ((red & 0xFF00) << 8) |
-                        ((green & 0xFF00)) |
-                        ((blue & 0xFF00)>>8);
+                out8(0x3C6, 0xFF);
+                out8(0x3C8, regno);
+                out8(0x3C9, red >> 10);
+                out8(0x3C9, green >> 10);
+                out8(0x3C9, blue >> 10);
+
+        } else if (bpp == 16)   // RGB 565
+                ((u32 *) info->pseudo_palette)[regno] =
+                    (red & 0xF800) |
+                    ((green & 0xFC00) >> 5) | ((blue & 0xF800) >> 11);
+        else if (bpp == 32)     // ARGB 8888
+                ((u32 *) info->pseudo_palette)[regno] =
+                    ((transp & 0xFF00) << 16) |
+                    ((red & 0xFF00) << 8) |
+                    ((green & 0xFF00)) | ((blue & 0xFF00) >> 8);
 
         return 0;
 }
@@ -918,40 +1090,41 @@ static int cyblafb_setcolreg(unsigned regno, unsigned red, unsigned green,
 
 static int cyblafb_blank(int blank_mode, struct fb_info *info)
 {
-        unsigned char PMCont,DPMSCont;
+        unsigned char PMCont, DPMSCont;
+
+        KD_GRAPHICS_RETURN(0);
 
         if (displaytype == DISPLAY_FP)
                 return 0;
 
-        out8(0x83C8,0x04);              // DPMS Control
+        out8(0x83C8, 0x04);     // DPMS Control
         PMCont = in8(0x83C6) & 0xFC;
 
         DPMSCont = read3CE(GR23) & 0xFC;
 
-        switch (blank_mode)
-        {
-        case FB_BLANK_UNBLANK:       // Screen: On, HSync: On, VSync: On
-        case FB_BLANK_NORMAL:        // Screen: Off, HSync: On, VSync: On
+        switch (blank_mode) {
+        case FB_BLANK_UNBLANK:  // Screen: On, HSync: On, VSync: On
+        case FB_BLANK_NORMAL:   // Screen: Off, HSync: On, VSync: On
                 PMCont |= 0x03;
                 DPMSCont |= 0x00;
                 break;
-        case FB_BLANK_HSYNC_SUSPEND: // Screen: Off, HSync: Off, VSync: On
+        case FB_BLANK_HSYNC_SUSPEND:    // Screen: Off, HSync: Off, VSync: On
                 PMCont |= 0x02;
                 DPMSCont |= 0x01;
                 break;
-        case FB_BLANK_VSYNC_SUSPEND: // Screen: Off, HSync: On, VSync: Off
+        case FB_BLANK_VSYNC_SUSPEND:    // Screen: Off, HSync: On, VSync: Off
                 PMCont |= 0x02;
                 DPMSCont |= 0x02;
                 break;
-        case FB_BLANK_POWERDOWN:     // Screen: Off, HSync: Off, VSync: Off
+        case FB_BLANK_POWERDOWN:        // Screen: Off, HSync: Off, VSync: Off
                 PMCont |= 0x00;
                 DPMSCont |= 0x03;
                 break;
         }
 
-        write3CE(GR23,DPMSCont);
-        out8(0x83C8,4);
-        out8(0x83C6,PMCont);
+        write3CE(GR23, DPMSCont);
+        out8(0x83C8, 4);
+        out8(0x83C6, PMCont);
         //
         // let fbcon do a softblank for us
         //
@@ -959,15 +1132,18 @@ static int cyblafb_blank(int blank_mode, struct fb_info *info)
 }
 
 static struct fb_ops cyblafb_ops __devinitdata = {
-        .owner  = THIS_MODULE,
+        .owner = THIS_MODULE,
         .fb_setcolreg = cyblafb_setcolreg,
         .fb_pan_display = cyblafb_pan_display,
         .fb_blank = cyblafb_blank,
         .fb_check_var = cyblafb_check_var,
         .fb_set_par = cyblafb_set_par,
         .fb_fillrect = cyblafb_fillrect,
-        .fb_copyarea= cyblafb_copyarea,
+        .fb_copyarea = cyblafb_copyarea,
         .fb_imageblit = cyblafb_imageblit,
+        .fb_sync = cyblafb_sync,
+        .fb_restore_state = cyblafb_restore_state,
+        .fb_save_state = cyblafb_save_state,
 };
 
 //==========================================================================
@@ -986,74 +1162,89 @@ static struct fb_ops cyblafb_ops __devinitdata = {
 
 static int __devinit getstartupmode(struct fb_info *info)
 {
-        u32     htotal,hdispend,hsyncstart,hsyncend,hblankstart,hblankend,
-                vtotal,vdispend,vsyncstart,vsyncend,vblankstart,vblankend,
-                cr00,cr01,cr02,cr03,cr04,cr05,cr2b,
-                cr06,cr07,cr09,cr10,cr11,cr12,cr15,cr16,cr27,
-                cr38,
-                sr0d,sr18,sr19,
-                gr0f,
-                fi,pxclkdiv,vclkdiv,tmp,i;
+        u32 htotal, hdispend, hsyncstart, hsyncend, hblankstart, hblankend,
+            vtotal, vdispend, vsyncstart, vsyncend, vblankstart, vblankend,
+            cr00, cr01, cr02, cr03, cr04, cr05, cr2b,
+            cr06, cr07, cr09, cr10, cr11, cr12, cr15, cr16, cr27,
+            cr38, sr0d, sr18, sr19, gr0f, fi, pxclkdiv, vclkdiv, tmp, i;
 
         struct modus {
-                int xres; int yres; int vyres; int bpp; int pxclk;
-                int left_margin; int right_margin; int upper_margin;
-                int lower_margin; int hsync_len; int vsync_len;
-        }  modedb[5] = {
-                {   0,    0, 8000, 0, 0,   0,  0,  0, 0,   0,  0},
-                { 640,  480, 3756, 0, 0, -40, 24, 17, 0, 216,  3},
-                { 800,  600, 3221, 0, 0,  96, 24, 14, 0, 136, 11},
-                {1024,  768, 2815, 0, 0, 144, 24, 29, 0, 120,  3},
-                {1280, 1024, 2662, 0, 0, 232, 16, 39, 0, 160,  3}
+                int xres; int vxres; int yres; int vyres;
+                int bpp; int pxclk;
+                int left_margin; int right_margin;
+                int upper_margin; int lower_margin;
+                int hsync_len; int vsync_len;
+        } modedb[5] = {
+                {
+                0, 2048, 0, 4096, 0, 0, 0, 0, 0, 0, 0, 0}, {
+                640, 2048, 480, 4096, 0, 0, -40, 24, 17, 0, 216, 3}, {
+                800, 2048, 600, 4096, 0, 0, 96, 24, 14, 0, 136, 11}, {
+                1024, 2048, 768, 4096, 0, 0, 144, 24, 29, 0, 120, 3}, {
+                1280, 2048, 1024, 4096, 0, 0, 232, 16, 39, 0, 160, 3}
         };
 
-        outb(0x00,0x3d4); cr00=inb(0x3d5); outb(0x01,0x3d4); cr01=inb(0x3d5);
-        outb(0x02,0x3d4); cr02=inb(0x3d5); outb(0x03,0x3d4); cr03=inb(0x3d5);
-        outb(0x04,0x3d4); cr04=inb(0x3d5); outb(0x05,0x3d4); cr05=inb(0x3d5);
-        outb(0x06,0x3d4); cr06=inb(0x3d5); outb(0x07,0x3d4); cr07=inb(0x3d5);
-        outb(0x09,0x3d4); cr09=inb(0x3d5); outb(0x10,0x3d4); cr10=inb(0x3d5);
-        outb(0x11,0x3d4); cr11=inb(0x3d5); outb(0x12,0x3d4); cr12=inb(0x3d5);
-        outb(0x15,0x3d4); cr15=inb(0x3d5); outb(0x16,0x3d4); cr16=inb(0x3d5);
-        outb(0x27,0x3d4); cr27=inb(0x3d5); outb(0x2b,0x3d4); cr2b=inb(0x3d5);
-        outb(0x38,0x3d4); cr38=inb(0x3d5); outb(0x0b,0x3c4); inb(0x3c5);
-        outb(0x0d,0x3c4); sr0d=inb(0x3c5); outb(0x18,0x3c4); sr18=inb(0x3c5);
-        outb(0x19,0x3c4); sr19=inb(0x3c5); outb(0x0f,0x3ce); gr0f=inb(0x3cf);
-
-        htotal      = cr00 | (cr2b & 0x01) << 8;
-        hdispend    = cr01 | (cr2b & 0x02) << 7;
+        outb(0x00, 0x3d4); cr00 = inb(0x3d5);
+        outb(0x01, 0x3d4); cr01 = inb(0x3d5);
+        outb(0x02, 0x3d4); cr02 = inb(0x3d5);
+        outb(0x03, 0x3d4); cr03 = inb(0x3d5);
+        outb(0x04, 0x3d4); cr04 = inb(0x3d5);
+        outb(0x05, 0x3d4); cr05 = inb(0x3d5);
+        outb(0x06, 0x3d4); cr06 = inb(0x3d5);
+        outb(0x07, 0x3d4); cr07 = inb(0x3d5);
+        outb(0x09, 0x3d4); cr09 = inb(0x3d5);
+        outb(0x10, 0x3d4); cr10 = inb(0x3d5);
+        outb(0x11, 0x3d4); cr11 = inb(0x3d5);
+        outb(0x12, 0x3d4); cr12 = inb(0x3d5);
+        outb(0x15, 0x3d4); cr15 = inb(0x3d5);
+        outb(0x16, 0x3d4); cr16 = inb(0x3d5);
+        outb(0x27, 0x3d4); cr27 = inb(0x3d5);
+        outb(0x2b, 0x3d4); cr2b = inb(0x3d5);
+        outb(0x38, 0x3d4); cr38 = inb(0x3d5);
+
+        outb(0x0b, 0x3c4);
+        inb(0x3c5);
+
+        outb(0x0d, 0x3c4); sr0d = inb(0x3c5);
+        outb(0x18, 0x3c4); sr18 = inb(0x3c5);
+        outb(0x19, 0x3c4); sr19 = inb(0x3c5);
+        outb(0x0f, 0x3ce); gr0f = inb(0x3cf);
+
+        htotal = cr00 | (cr2b & 0x01) << 8;
+        hdispend = cr01 | (cr2b & 0x02) << 7;
         hblankstart = cr02 | (cr2b & 0x10) << 4;
-        hblankend   = (cr03 & 0x1f) | (cr05 & 0x80) >> 2;
-        hsyncstart  = cr04 | (cr2b & 0x08) << 5;
-        hsyncend    = cr05 & 0x1f;
+        hblankend = (cr03 & 0x1f) | (cr05 & 0x80) >> 2;
+        hsyncstart = cr04 | (cr2b & 0x08) << 5;
+        hsyncend = cr05 & 0x1f;
 
         modedb[0].xres = hblankstart * 8;
         modedb[0].hsync_len = hsyncend * 8;
         modedb[0].right_margin = hsyncstart * 8 - modedb[0].xres;
         modedb[0].left_margin = (htotal + 5) * 8 - modedb[0].xres -
-                modedb[0].right_margin - modedb[0].hsync_len;
-
-        vtotal      = cr06 | (cr07 & 0x01) << 8 | (cr07 & 0x20) << 4
-                           | (cr27 & 0x80) << 3;
-        vdispend    = cr12 | (cr07 & 0x02) << 7 | (cr07 & 0x40) << 3
-                           | (cr27 & 0x10) << 6;
-        vsyncstart  = cr10 | (cr07 & 0x04) << 6 | (cr07 & 0x80) << 2
-                           | (cr27 & 0x20) << 5;
-        vsyncend    = cr11 & 0x0f;
+            modedb[0].right_margin - modedb[0].hsync_len;
+
+        vtotal = cr06 | (cr07 & 0x01) << 8 | (cr07 & 0x20) << 4
+            | (cr27 & 0x80) << 3;
+        vdispend = cr12 | (cr07 & 0x02) << 7 | (cr07 & 0x40) << 3
+            | (cr27 & 0x10) << 6;
+        vsyncstart = cr10 | (cr07 & 0x04) << 6 | (cr07 & 0x80) << 2
+            | (cr27 & 0x20) << 5;
+        vsyncend = cr11 & 0x0f;
         vblankstart = cr15 | (cr07 & 0x08) << 5 | (cr09 & 0x20) << 4
-                           | (cr27 & 0x40) << 4;
-        vblankend   = cr16;
+            | (cr27 & 0x40) << 4;
+        vblankend = cr16;
 
-        modedb[0].yres         = vdispend + 1;
-        modedb[0].vsync_len    = vsyncend;
+        modedb[0].yres = vdispend + 1;
+        modedb[0].vsync_len = vsyncend;
         modedb[0].lower_margin = vsyncstart - modedb[0].yres;
         modedb[0].upper_margin = vtotal - modedb[0].yres -
-                modedb[0].lower_margin - modedb[0].vsync_len + 2;
+            modedb[0].lower_margin - modedb[0].vsync_len + 2;
 
         tmp = cr38 & 0x3c;
         modedb[0].bpp = tmp == 0 ? 8 : tmp == 4 ? 16 : tmp == 28 ? 24 :
-                        tmp == 8 ? 32 : 8;
+            tmp == 8 ? 32 : 8;
 
-        fi = ((5864727*(sr18+8))/(((sr19&0x3f)+2)*(1<<((sr19&0xc0)>>6))))>>12;
+        fi = ((5864727 * (sr18 + 8)) /
+              (((sr19 & 0x3f) + 2) * (1 << ((sr19 & 0xc0) >> 6)))) >> 12;
         pxclkdiv = ((gr0f & 0x08) >> 3 | (gr0f & 0x40) >> 5) + 1;
         tmp = sr0d & 0x06;
         vclkdiv = tmp == 0 ? 2 : tmp == 2 ? 4 : tmp == 4 ? 8 : 3; // * 2 !
@@ -1062,10 +1253,10 @@ static int __devinit getstartupmode(struct fb_info *info)
         if (verbosity > 0)
                 output("detected startup mode: "
                        "fbset -g %d %d %d ??? %d -t %d %d %d %d %d %d %d\n",
-                       modedb[0].xres,modedb[0].yres,modedb[0].xres,
-                       modedb[0].bpp,modedb[0].pxclk,modedb[0].left_margin,
-                       modedb[0].right_margin,modedb[0].upper_margin,
-                       modedb[0].lower_margin,modedb[0].hsync_len,
+                       modedb[0].xres, modedb[0].yres, modedb[0].xres,
+                       modedb[0].bpp, modedb[0].pxclk, modedb[0].left_margin,
+                       modedb[0].right_margin, modedb[0].upper_margin,
+                       modedb[0].lower_margin, modedb[0].hsync_len,
                        modedb[0].vsync_len);
 
         //
@@ -1073,36 +1264,39 @@ static int __devinit getstartupmode(struct fb_info *info)
         // do not want to do it in another way!
         //
 
-        tryagain:
+      tryagain:
 
         i = (mode == NULL) ? 0 :
-            !strncmp(mode,"640x480",7) ? 1 :
-            !strncmp(mode,"800x600",7) ? 2 :
-            !strncmp(mode,"1024x768",8) ? 3 :
-            !strncmp(mode,"1280x1024",9) ? 4 : 0;
+            !strncmp(mode, "640x480", 7) ? 1 :
+            !strncmp(mode, "800x600", 7) ? 2 :
+            !strncmp(mode, "1024x768", 8) ? 3 :
+            !strncmp(mode, "1280x1024", 9) ? 4 : 0;
 
         ref = (ref < 50) ? 50 : (ref > 85) ? 85 : ref;
 
-        if(i==0) {
+        if (i == 0) {
                 info->var.pixclock = modedb[i].pxclk;
                 info->var.bits_per_pixel = modedb[i].bpp;
         } else {
                 info->var.pixclock = (100000000 /
-                        ((modedb[i].left_margin + modedb[i].xres +
-                          modedb[i].right_margin + modedb[i].hsync_len
-                         ) * (
-                          modedb[i].upper_margin + modedb[i].yres +
-                          modedb[i].lower_margin + modedb[i].vsync_len
-                         ) *
-                          ref / 10000
-                        ));
+                                      ((modedb[i].left_margin +
+                                        modedb[i].xres +
+                                        modedb[i].right_margin +
+                                        modedb[i].hsync_len) *
+                                       (modedb[i].upper_margin +
+                                        modedb[i].yres +
+                                        modedb[i].lower_margin +
+                                        modedb[i].vsync_len) * ref / 10000));
                 info->var.bits_per_pixel = bpp;
         }
 
         info->var.left_margin = modedb[i].left_margin;
         info->var.right_margin = modedb[i].right_margin;
         info->var.xres = modedb[i].xres;
-        info->var.xres_virtual = modedb[i].xres;
+        if (!(modedb[i].yres == 1280 && modedb[i].bpp == 32))
+                info->var.xres_virtual = modedb[i].vxres;
+        else
+                info->var.xres_virtual = modedb[i].xres;
         info->var.xoffset = 0;
         info->var.hsync_len = modedb[i].hsync_len;
         info->var.upper_margin = modedb[i].upper_margin;
@@ -1114,33 +1308,32 @@ static int __devinit getstartupmode(struct fb_info *info)
         info->var.sync = 0;
         info->var.vmode = FB_VMODE_NONINTERLACED;
 
-        if(cyblafb_check_var(&info->var,info)) {
-                // 640x480-8@75 should really never fail. One case would
+        if (cyblafb_check_var(&info->var, info)) {
+                // 640x480 - 8@75 should really never fail. One case would
                 // be fp == 1 and nativex < 640 ... give up then
-                if(i==1 && bpp == 8 && ref == 75){
+                if (i == 1 && bpp == 8 && ref == 75) {
                         output("Can't find a valid mode :-(\n");
                         return -EINVAL;
                 }
                 // Our detected mode is unlikely to fail. If it does,
-                // try 640x480-8@75 ...
-                if(i==0) {
-                        mode="640x480";
-                        bpp=8;
-                        ref=75;
+                // try 640x480 - 8@75 ...
+                if (i == 0) {
+                        mode = "640x480";
+                        bpp = 8;
+                        ref = 75;
                         output("Detected mode failed check_var! "
-                               "Trying 640x480-8@75\n");
+                               "Trying 640x480 - 8@75\n");
                         goto tryagain;
                 }
                 // A specified video mode failed for some reason.
                 // Try the startup mode first
                 output("Specified mode '%s' failed check! "
-                        "Falling back to startup mode.\n",mode);
-                mode=NULL;
+                       "Falling back to startup mode.\n", mode);
+                mode = NULL;
                 goto tryagain;
         }
 
         return 0;
-
 }
 
 //========================================================
@@ -1160,21 +1353,28 @@ static unsigned int __devinit get_memsize(void)
         else {
                 tmp = read3X4(CR1F) & 0x0F;
                 switch (tmp) {
-                        case 0x03: k = 1 * Mb; break;
-                        case 0x07: k = 2 * Mb; break;
-                        case 0x0F: k = 4 * Mb; break;
-                        case 0x04: k = 8 * Mb; break;
-                        default:
-                                k = 1 * Mb;
-                                output("Unknown memory size code %x in CR1F."
-                                       " We default to 1 Mb for now, please"
-                                       " do provide a memsize parameter!\n",
-                                       tmp);
+                case 0x03:
+                        k = 1 * 1024 * 1024;
+                        break;
+                case 0x07:
+                        k = 2 * 1024 * 1024;
+                        break;
+                case 0x0F:
+                        k = 4 * 1024 * 1024;
+                        break;
+                case 0x04:
+                        k = 8 * 1024 * 1024;
+                        break;
+                default:
+                        k = 1 * 1024 * 1024;
+                        output("Unknown memory size code %x in CR1F."
+                               " We default to 1 Mb for now, please"
+                               " do provide a memsize parameter!\n", tmp);
                 }
         }
 
         if (verbosity > 0)
-                output("framebuffer size = %d Kb\n",k/Kb);
+                output("framebuffer size = %d Kb\n", k / Kb);
         return k;
 }
 
@@ -1192,7 +1392,7 @@ static unsigned int __devinit get_displaytype(void)
                 return DISPLAY_FP;
         if (crt)
                 return DISPLAY_CRT;
-        return (read3CE(GR33) & 0x10)?DISPLAY_FP:DISPLAY_CRT;
+        return (read3CE(GR33) & 0x10) ? DISPLAY_FP : DISPLAY_CRT;
 }
 
 //=====================================
@@ -1203,7 +1403,7 @@ static unsigned int __devinit get_displaytype(void)
 
 static int __devinit get_nativex(void)
 {
-        int x,y,tmp;
+        int x, y, tmp;
 
         if (nativex)
                 return nativex;
@@ -1211,29 +1411,45 @@ static int __devinit get_nativex(void)
         tmp = (read3CE(GR52) >> 4) & 3;
 
         switch (tmp) {
-                case 0:  x = 1280; y = 1024; break;
-                case 2:  x = 1024; y = 768;  break;
-                case 3:  x = 800;  y = 600;  break;
-                case 4:  x = 1400; y = 1050; break;
-                case 1:
-                default: x = 640;  y = 480;  break;
+        case 0: x = 1280; y = 1024;
+                break;
+        case 2: x = 1024; y = 768;
+                break;
+        case 3: x = 800;  y = 600;
+                break;
+        case 4: x = 1400; y = 1050;
+                break;
+        case 1:
+        default:
+                x = 640; y = 480;
+                break;
         }
 
         if (verbosity > 0)
-                output("%dx%d flat panel found\n",x,y);
+                output("%dx%d flat panel found\n", x, y);
         return x;
 }
 
-static int __devinit cybla_pci_probe(struct pci_dev * dev,
-                                     const struct pci_device_id * id)
+static int __devinit cybla_pci_probe(struct pci_dev *dev,
+                                     const struct pci_device_id *id)
 {
         struct fb_info *info;
         struct cyblafb_par *par;
 
-        info = framebuffer_alloc(sizeof(struct cyblafb_par),&dev->dev);
-
+        info = framebuffer_alloc(sizeof(struct cyblafb_par), &dev->dev);
         if (!info)
-                goto errout_alloc;
+                goto errout_alloc_info;
+
+        info->pixmap.addr = kzalloc(CYBLAFB_PIXMAPSIZE, GFP_KERNEL);
+        if (!info->pixmap.addr) {
+                output("allocation of pixmap buffer failed!\n");
+                goto errout_alloc_pixmap;
+        }
+        info->pixmap.size = CYBLAFB_PIXMAPSIZE - 4;
+        info->pixmap.buf_align = 4;
+        info->pixmap.access_align = 32;
+        info->pixmap.flags = FB_PIXMAP_SYSTEM;
+        info->pixmap.scan_align = 4;
 
         par = info->par;
         par->ops = cyblafb_ops;
@@ -1246,26 +1462,31 @@ static int __devinit cybla_pci_probe(struct pci_dev * dev,
                 output("could not enable device!\n");
                 goto errout_enable;
         }
-
         // might already be requested by vga console or vesafb,
         // so we do care about success
-        request_region(0x3c0,32,"cyblafb");
+        if (!request_region(0x3c0, 0x20, "cyblafb")) {
+                output("region 0x3c0/0x20 already reserved\n");
+                vesafb |= 1;
 
+        }
         //
         // Graphics Engine Registers
         //
-        request_region(GEBase,0x100,"cyblafb");
+        if (!request_region(GEBase, 0x100, "cyblafb")) {
+                output("region %#x/0x100 already reserved\n", GEBase);
+                vesafb |= 2;
+        }
 
         regdump(par);
 
         enable_mmio();
 
         // setup MMIO region
-        info->fix.mmio_start = pci_resource_start(dev,1);
+        info->fix.mmio_start = pci_resource_start(dev, 1);
         info->fix.mmio_len = 0x20000;
 
         if (!request_mem_region(info->fix.mmio_start,
-                                info->fix.mmio_len,"cyblafb")) {
+                                info->fix.mmio_len, "cyblafb")) {
                 output("request_mem_region failed for mmio region!\n");
                 goto errout_mmio_reqmem;
         }
@@ -1276,18 +1497,17 @@ static int __devinit cybla_pci_probe(struct pci_dev * dev,
                 output("ioremap failed for mmio region\n");
                 goto errout_mmio_remap;
         }
-
         // setup framebuffer memory ... might already be requested
         // by vesafb. Not to fail in case of an unsuccessful request
-        // is useful for the development cycle
-        info->fix.smem_start = pci_resource_start(dev,0);
+        // is useful if both are loaded.
+        info->fix.smem_start = pci_resource_start(dev, 0);
         info->fix.smem_len = get_memsize();
 
         if (!request_mem_region(info->fix.smem_start,
-                                info->fix.smem_len,"cyblafb")) {
-                output("request_mem_region failed for smem region!\n");
-                if (!vesafb)
-                        goto errout_smem_req;
+                                info->fix.smem_len, "cyblafb")) {
+                output("region %#lx/%#x already reserved\n",
+                       info->fix.smem_start, info->fix.smem_len);
+                vesafb |= 4;
         }
 
         info->screen_base = ioremap_nocache(info->fix.smem_start,
@@ -1300,31 +1520,30 @@ static int __devinit cybla_pci_probe(struct pci_dev * dev,
 
         displaytype = get_displaytype();
 
-        if(displaytype == DISPLAY_FP)
+        if (displaytype == DISPLAY_FP)
                 nativex = get_nativex();
 
-        //
-        // FBINFO_HWACCEL_YWRAP    .... does not work (could be made to work?)
-        // FBINFO_PARTIAL_PAN_OK   .... is not ok
-        // FBINFO_READS_FAST       .... is necessary for optimal scrolling
-        //
-        info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN
-                      | FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT
-                      | FBINFO_HWACCEL_IMAGEBLIT | FBINFO_READS_FAST;
+        info->flags = FBINFO_DEFAULT
+                    | FBINFO_HWACCEL_COPYAREA
+                    | FBINFO_HWACCEL_FILLRECT
+                    | FBINFO_HWACCEL_IMAGEBLIT
+                    | FBINFO_READS_FAST
+//                  | FBINFO_PARTIAL_PAN_OK
+                    | FBINFO_MISC_ALWAYS_SETPAR;
 
         info->pseudo_palette = par->pseudo_pal;
 
-        if(getstartupmode(info))
+        if (getstartupmode(info))
                 goto errout_findmode;
 
-        fb_alloc_cmap(&info->cmap,256,0);
+        fb_alloc_cmap(&info->cmap, 256, 0);
 
         if (register_framebuffer(info)) {
                 output("Could not register CyBla framebuffer\n");
                 goto errout_register;
         }
 
-        pci_set_drvdata(dev,info);
+        pci_set_drvdata(dev, info);
 
         //
         // normal exit and error paths
@@ -1332,23 +1551,24 @@ static int __devinit cybla_pci_probe(struct pci_dev * dev,
 
         return 0;
 
- errout_register:
- errout_findmode:
+      errout_register:
+      errout_findmode:
         iounmap(info->screen_base);
- errout_smem_remap:
-        release_mem_region(info->fix.smem_start,
-                           info->fix.smem_len);
- errout_smem_req:
+      errout_smem_remap:
+        if (!(vesafb & 4))
+                release_mem_region(info->fix.smem_start, info->fix.smem_len);
         iounmap(io_virt);
- errout_mmio_remap:
-        release_mem_region(info->fix.mmio_start,
-                           info->fix.mmio_len);
- errout_mmio_reqmem:
-//      release_region(0x3c0,32);
- errout_enable:
+      errout_mmio_remap:
+        release_mem_region(info->fix.mmio_start, info->fix.mmio_len);
+      errout_mmio_reqmem:
+        if (!(vesafb & 1))
+                release_region(0x3c0, 32);
+      errout_enable:
+        kfree(info->pixmap.addr);
+      errout_alloc_pixmap:
         framebuffer_release(info);
- errout_alloc:
-        output("CyblaFB version %s aborting init.\n",VERSION);
+      errout_alloc_info:
+        output("CyblaFB version %s aborting init.\n", VERSION);
         return -ENODEV;
 }
 
@@ -1359,35 +1579,41 @@ static void __devexit cybla_pci_remove(struct pci_dev *dev)
         unregister_framebuffer(info);
         iounmap(io_virt);
         iounmap(info->screen_base);
-        release_mem_region(info->fix.smem_start,info->fix.smem_len);
-        release_mem_region(info->fix.mmio_start,info->fix.mmio_len);
+        if (!(vesafb & 4))
+                release_mem_region(info->fix.smem_start, info->fix.smem_len);
+        release_mem_region(info->fix.mmio_start, info->fix.mmio_len);
         fb_dealloc_cmap(&info->cmap);
+        if (!(vesafb & 2))
+                release_region(GEBase, 0x100);
+        if (!(vesafb & 1))
+                release_region(0x3c0, 32);
+        kfree(info->pixmap.addr);
         framebuffer_release(info);
-        output("CyblaFB version %s normal exit.\n",VERSION);
+        output("CyblaFB version %s normal exit.\n", VERSION);
 }
 
 //
 // List of boards that we are trying to support
 //
 static struct pci_device_id cybla_devices[] = {
-        {PCI_VENDOR_ID_TRIDENT,CYBERBLADEi1,PCI_ANY_ID,PCI_ANY_ID,0,0,0},
+        {PCI_VENDOR_ID_TRIDENT, CYBERBLADEi1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
         {0,}
 };
 
-MODULE_DEVICE_TABLE(pci,cybla_devices);
+MODULE_DEVICE_TABLE(pci, cybla_devices);
 
 static struct pci_driver cyblafb_pci_driver = {
-        .name           = "cyblafb",
-        .id_table       = cybla_devices,
-        .probe          = cybla_pci_probe,
-        .remove         = __devexit_p(cybla_pci_remove)
+        .name = "cyblafb",
+        .id_table = cybla_devices,
+        .probe = cybla_pci_probe,
+        .remove = __devexit_p(cybla_pci_remove)
 };
 
 //=============================================================
 //
 // kernel command line example:
 //
-//      video=cyblafb:1280x1024,bpp=16,ref=50 ...
+//      video=cyblafb:1280x1024, bpp=16, ref=50 ...
 //
 // modprobe command line example:
 //
@@ -1401,45 +1627,44 @@ static int __devinit cyblafb_init(void)
         char *options = NULL;
         char *opt;
 
-        if (fb_get_options("cyblafb",&options))
+        if (fb_get_options("cyblafb", &options))
                 return -ENODEV;
 
         if (options && *options)
-                while((opt = strsep(&options,",")) != NULL ) {
-                        if (!*opt) continue;
-                        else if (!strncmp(opt,"bpp=",4))
-                                bpp = simple_strtoul(opt+4,NULL,0);
-                        else if (!strncmp(opt,"ref=",4))
-                                ref = simple_strtoul(opt+4,NULL,0);
-                        else if (!strncmp(opt,"fp",2))
+                while ((opt = strsep(&options, ",")) != NULL) {
+                        if (!*opt)
+                                continue;
+                        else if (!strncmp(opt, "bpp=", 4))
+                                bpp = simple_strtoul(opt + 4, NULL, 0);
+                        else if (!strncmp(opt, "ref=", 4))
+                                ref = simple_strtoul(opt + 4, NULL, 0);
+                        else if (!strncmp(opt, "fp", 2))
                                 displaytype = DISPLAY_FP;
-                        else if (!strncmp(opt,"crt",3))
+                        else if (!strncmp(opt, "crt", 3))
                                 displaytype = DISPLAY_CRT;
-                        else if (!strncmp(opt,"nativex=",8))
-                                nativex = simple_strtoul(opt+8,NULL,0);
-                        else if (!strncmp(opt,"center",6))
+                        else if (!strncmp(opt, "nativex=", 8))
+                                nativex = simple_strtoul(opt + 8, NULL, 0);
+                        else if (!strncmp(opt, "center", 6))
                                 center = 1;
-                        else if (!strncmp(opt,"stretch",7))
+                        else if (!strncmp(opt, "stretch", 7))
                                 stretch = 1;
-                        else if (!strncmp(opt,"pciwb=",6))
-                                pciwb = simple_strtoul(opt+6,NULL,0);
-                        else if (!strncmp(opt,"pcirb=",6))
-                                pcirb = simple_strtoul(opt+6,NULL,0);
-                        else if (!strncmp(opt,"pciwr=",6))
-                                pciwr = simple_strtoul(opt+6,NULL,0);
-                        else if (!strncmp(opt,"pcirr=",6))
-                                pcirr = simple_strtoul(opt+6,NULL,0);
-                        else if (!strncmp(opt,"memsize=",8))
-                                memsize = simple_strtoul(opt+8,NULL,0);
-                        else if (!strncmp(opt,"verbosity=",10))
-                                verbosity = simple_strtoul(opt+10,NULL,0);
-                        else if (!strncmp(opt,"vesafb",6))
-                                vesafb = 1;
+                        else if (!strncmp(opt, "pciwb=", 6))
+                                pciwb = simple_strtoul(opt + 6, NULL, 0);
+                        else if (!strncmp(opt, "pcirb=", 6))
+                                pcirb = simple_strtoul(opt + 6, NULL, 0);
+                        else if (!strncmp(opt, "pciwr=", 6))
+                                pciwr = simple_strtoul(opt + 6, NULL, 0);
+                        else if (!strncmp(opt, "pcirr=", 6))
+                                pcirr = simple_strtoul(opt + 6, NULL, 0);
+                        else if (!strncmp(opt, "memsize=", 8))
+                                memsize = simple_strtoul(opt + 8, NULL, 0);
+                        else if (!strncmp(opt, "verbosity=", 10))
+                                verbosity = simple_strtoul(opt + 10, NULL, 0);
                         else
                                 mode = opt;
                 }
 #endif
-        output("CyblaFB version %s initializing\n",VERSION);
+        output("CyblaFB version %s initializing\n", VERSION);
         return pci_module_init(&cyblafb_pci_driver);
 }
 
diff --git a/drivers/video/offb.c b/drivers/video/offb.c
index 00d87f5bb7be..ad1434e3f227 100644
--- a/drivers/video/offb.c
+++ b/drivers/video/offb.c
@@ -223,6 +223,7 @@ static int offb_blank(int blank, struct fb_info *info)
 int __init offb_init(void)
 {
         struct device_node *dp = NULL, *boot_disp = NULL;
+
 #if defined(CONFIG_BOOTX_TEXT) && defined(CONFIG_PPC32)
         struct device_node *macos_display = NULL;
 #endif
@@ -234,60 +235,54 @@ int __init offb_init(void)
         if (boot_infos != 0) {
                 unsigned long addr =
                     (unsigned long) boot_infos->dispDeviceBase;
+                u32 *addrp;
+                u64 daddr, dsize;
+                unsigned int flags;
+
                 /* find the device node corresponding to the macos display */
                 while ((dp = of_find_node_by_type(dp, "display"))) {
                         int i;
-                        /*
-                         * Grrr...  It looks like the MacOS ATI driver
-                         * munges the assigned-addresses property (but
-                         * the AAPL,address value is OK).
-                         */
-                        if (strncmp(dp->name, "ATY,", 4) == 0
-                            && dp->n_addrs == 1) {
-                                unsigned int *ap =
-                                    (unsigned int *) get_property(dp,
-                                                                  "AAPL,address",
-                                                                  NULL);
-                                if (ap != NULL) {
-                                        dp->addrs[0].address = *ap;
-                                        dp->addrs[0].size = 0x01000000;
-                                }
-                        }
 
                         /*
-                         * The LTPro on the Lombard powerbook has no addresses
-                         * on the display nodes, they are on their parent.
+                         * Look for an AAPL,address property first.
                          */
-                        if (dp->n_addrs == 0
-                            && device_is_compatible(dp, "ATY,264LTPro")) {
-                                int na;
-                                unsigned int *ap = (unsigned int *)
-                                    get_property(dp, "AAPL,address", &na);
-                                if (ap != 0)
-                                        for (na /= sizeof(unsigned int);
-                                             na > 0; --na, ++ap)
-                                                if (*ap <= addr
-                                                    && addr <
-                                                    *ap + 0x1000000)
-                                                        goto foundit;
+                        unsigned int na;
+                        unsigned int *ap =
+                                (unsigned int *)get_property(dp, "AAPL,address",
+                                                             &na);
+                        if (ap != 0) {
+                                for (na /= sizeof(unsigned int); na > 0;
+                                     --na, ++ap)
+                                        if (*ap <= addr &&
+                                            addr < *ap + 0x1000000) {
+                                                macos_display = dp;
+                                                goto foundit;
+                                        }
                         }
 
                         /*
                          * See if the display address is in one of the address
                          * ranges for this display.
                          */
-                        for (i = 0; i < dp->n_addrs; ++i) {
-                                if (dp->addrs[i].address <= addr
-                                    && addr <
-                                    dp->addrs[i].address +
-                                    dp->addrs[i].size)
+                        i = 0;
+                        for (;;) {
+                                addrp = of_get_address(dp, i++, &dsize, &flags);
+                                if (addrp == NULL)
                                         break;
+                                if (!(flags & IORESOURCE_MEM))
+                                        continue;
+                                daddr = of_translate_address(dp, addrp);
+                                if (daddr == OF_BAD_ADDR)
+                                        continue;
+                                if (daddr <= addr && addr < (daddr + dsize)) {
+                                        macos_display = dp;
+                                        goto foundit;
+                                }
                         }
-                        if (i < dp->n_addrs) {
-                              foundit:
+                foundit:
+                        if (macos_display) {
                                 printk(KERN_INFO "MacOS display is %s\n",
                                        dp->full_name);
-                                macos_display = dp;
                                 break;
                         }
                 }
@@ -326,8 +321,10 @@ static void __init offb_init_nodriver(struct device_node *dp)
         int *pp, i;
         unsigned int len;
         int width = 640, height = 480, depth = 8, pitch;
-        unsigned int rsize, *up;
-        unsigned long address = 0;
+        unsigned int flags, rsize, *up;
+        u64 address = OF_BAD_ADDR;
+        u32 *addrp;
+        u64 asize;
 
         if ((pp = (int *) get_property(dp, "depth", &len)) != NULL
             && len == sizeof(int))
@@ -363,7 +360,7 @@ static void __init offb_init_nodriver(struct device_node *dp)
                                break;
                }
                if (pdev) {
-                       for (i = 0; i < 6 && address == 0; i++) {
+                       for (i = 0; i < 6 && address == OF_BAD_ADDR; i++) {
                                if ((pci_resource_flags(pdev, i) &
                                     IORESOURCE_MEM) &&
                                    (pci_resource_len(pdev, i) >= rsize))
@@ -374,27 +371,33 @@ static void __init offb_init_nodriver(struct device_node *dp)
         }
 #endif /* CONFIG_PCI */
 
-        if (address == 0 &&
-            (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
-            len == sizeof(unsigned))
-                address = (u_long) * up;
-        if (address == 0) {
-                for (i = 0; i < dp->n_addrs; ++i)
-                        if (dp->addrs[i].size >=
-                            pitch * height * depth / 8)
-                                break;
-                if (i >= dp->n_addrs) {
+       /* This one is dodgy, we may drop it ... */
+       if (address == OF_BAD_ADDR &&
+           (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
+           len == sizeof(unsigned int))
+               address = (u64) * up;
+
+       if (address == OF_BAD_ADDR) {
+               for (i = 0; (addrp = of_get_address(dp, i, &asize, &flags))
+                            != NULL; i++) {
+                       if (!(flags & IORESOURCE_MEM))
+                               continue;
+                       if (asize >= pitch * height * depth / 8)
+                               break;
+               }
+                if (addrp == NULL) {
                         printk(KERN_ERR
                                "no framebuffer address found for %s\n",
                                dp->full_name);
                         return;
                 }
-
-                address = (u_long) dp->addrs[i].address;
-
-#ifdef CONFIG_PPC64
-                address += ((struct pci_dn *)dp->data)->phb->pci_mem_offset;
-#endif
+                address = of_translate_address(dp, addrp);
+                if (address == OF_BAD_ADDR) {
+                        printk(KERN_ERR
+                               "can't translate framebuffer address for %s\n",
+                               dp->full_name);
+                        return;
+                }
 
                 /* kludge for valkyrie */
                 if (strcmp(dp->name, "valkyrie") == 0)
@@ -459,7 +462,9 @@ static void __init offb_init_fb(const char *name, const char *full_name,
 
         par->cmap_type = cmap_unknown;
         if (depth == 8) {
-                /* XXX kludge for ati */
+
+                /* Palette hacks disabled for now */
+#if 0
                 if (dp && !strncmp(name, "ATY,Rage128", 11)) {
                         unsigned long regbase = dp->addrs[2].address;
                         par->cmap_adr = ioremap(regbase, 0x1FFF);
@@ -490,6 +495,7 @@ static void __init offb_init_fb(const char *name, const char *full_name,
                         par->cmap_adr = ioremap(regbase + 0x6000, 0x1000);
                         par->cmap_type = cmap_gxt2000;
                 }
+#endif
                 fix->visual = par->cmap_adr ? FB_VISUAL_PSEUDOCOLOR
                     : FB_VISUAL_STATIC_PSEUDOCOLOR;
         } else
diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
index ca4082ae5a18..335e37465559 100644
--- a/drivers/video/platinumfb.c
+++ b/drivers/video/platinumfb.c
@@ -69,6 +69,8 @@ struct fb_info_platinum {
         unsigned long                   total_vram;
         int                             clktype;
         int                             dactype;
+
+        struct resource                 rsrc_fb, rsrc_reg;
 };
 
 /*
@@ -97,9 +99,6 @@ static int platinum_var_to_par(struct fb_var_screeninfo *var,
  * Interface used by the world
  */
 
-int platinumfb_init(void);
-int platinumfb_setup(char*);
-
 static struct fb_ops platinumfb_ops = {
         .owner =        THIS_MODULE,
         .fb_check_var   = platinumfb_check_var,
@@ -138,13 +137,15 @@ static int platinumfb_set_par (struct fb_info *info)
 
         init = platinum_reg_init[pinfo->vmode-1];
         
-        if (pinfo->vmode == 13 && pinfo->cmode > 0)
-                offset = 0x10;
+        if ((pinfo->vmode == VMODE_832_624_75) && (pinfo->cmode > CMODE_8))
+                offset = 0x10;
+
         info->screen_base = pinfo->frame_buffer + init->fb_offset + offset;
         info->fix.smem_start = (pinfo->frame_buffer_phys) + init->fb_offset + offset;
         info->fix.visual = (pinfo->cmode == CMODE_8) ?
                 FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_DIRECTCOLOR;
-        info->fix.line_length = vmode_attrs[pinfo->vmode-1].hres * (1<<pinfo->cmode) + offset;
+        info->fix.line_length = vmode_attrs[pinfo->vmode-1].hres * (1<<pinfo->cmode)
+                + offset;
         printk("line_length: %x\n", info->fix.line_length);
         return 0;
 }
@@ -221,7 +222,9 @@ static int platinumfb_setcolreg(u_int regno, u_int red, u_int green, u_int blue,
 static inline int platinum_vram_reqd(int video_mode, int color_mode)
 {
         return vmode_attrs[video_mode-1].vres *
-               (vmode_attrs[video_mode-1].hres * (1<<color_mode) + 0x20) +0x1000;
+               (vmode_attrs[video_mode-1].hres * (1<<color_mode) +
+                ((video_mode == VMODE_832_624_75) &&
+                 (color_mode > CMODE_8)) ? 0x10 : 0x20) + 0x1000;
 }
 
 #define STORE_D2(a, d) { \
@@ -481,7 +484,7 @@ static int platinum_var_to_par(struct fb_var_screeninfo *var,
 /* 
  * Parse user speficied options (`video=platinumfb:')
  */
-int __init platinumfb_setup(char *options)
+static int __init platinumfb_setup(char *options)
 {
         char *this_opt;
 
@@ -522,19 +525,15 @@ int __init platinumfb_setup(char *options)
 #define invalidate_cache(addr)
 #endif
 
-static int __devinit platinumfb_probe(struct of_device* odev, const struct of_device_id *match)
+static int __devinit platinumfb_probe(struct of_device* odev,
+                                      const struct of_device_id *match)
 {
         struct device_node      *dp = odev->node;
         struct fb_info          *info;
         struct fb_info_platinum *pinfo;
-        unsigned long           addr, size;
         volatile __u8           *fbuffer;
-        int                     i, bank0, bank1, bank2, bank3, rc;
+        int                     bank0, bank1, bank2, bank3, rc;
 
-        if (dp->n_addrs != 2) {
-                printk(KERN_ERR "expecting 2 address for platinum (got %d)", dp->n_addrs);
-                return -ENXIO;
-        }
         printk(KERN_INFO "platinumfb: Found Apple Platinum video hardware\n");
 
         info = framebuffer_alloc(sizeof(*pinfo), &odev->dev);
@@ -542,26 +541,39 @@ static int __devinit platinumfb_probe(struct of_device* odev, const struct of_de
                 return -ENOMEM;
         pinfo = info->par;
 
-        /* Map in frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                size = dp->addrs[i].size;
-                /* Let's assume we can request either all or nothing */
-                if (!request_mem_region(addr, size, "platinumfb")) {
-                        framebuffer_release(info);
-                        return -ENXIO;
-                }
-                if (size >= 0x400000) {
-                        /* frame buffer - map only 4MB */
-                        pinfo->frame_buffer_phys = addr;
-                        pinfo->frame_buffer = __ioremap(addr, 0x400000, _PAGE_WRITETHRU);
-                        pinfo->base_frame_buffer = pinfo->frame_buffer;
-                } else {
-                        /* registers */
-                        pinfo->platinum_regs_phys = addr;
-                        pinfo->platinum_regs = ioremap(addr, size);
-                }
+        if (of_address_to_resource(dp, 0, &pinfo->rsrc_reg) ||
+            of_address_to_resource(dp, 1, &pinfo->rsrc_fb)) {
+                printk(KERN_ERR "platinumfb: Can't get resources\n");
+                framebuffer_release(info);
+                return -ENXIO;
         }
+        if (!request_mem_region(pinfo->rsrc_reg.start,
+                                pinfo->rsrc_reg.start -
+                                pinfo->rsrc_reg.end + 1,
+                                "platinumfb registers")) {
+                framebuffer_release(info);
+                return -ENXIO;
+        }
+        if (!request_mem_region(pinfo->rsrc_fb.start,
+                                pinfo->rsrc_fb.start
+                                - pinfo->rsrc_fb.end + 1,
+                                "platinumfb framebuffer")) {
+                release_mem_region(pinfo->rsrc_reg.start,
+                                   pinfo->rsrc_reg.end -
+                                   pinfo->rsrc_reg.start + 1);
+                framebuffer_release(info);
+                return -ENXIO;
+        }
+
+        /* frame buffer - map only 4MB */
+        pinfo->frame_buffer_phys = pinfo->rsrc_fb.start;
+        pinfo->frame_buffer = __ioremap(pinfo->rsrc_fb.start, 0x400000,
+                                        _PAGE_WRITETHRU);
+        pinfo->base_frame_buffer = pinfo->frame_buffer;
+
+        /* registers */
+        pinfo->platinum_regs_phys = pinfo->rsrc_reg.start;
+        pinfo->platinum_regs = ioremap(pinfo->rsrc_reg.start, 0x1000);
 
         pinfo->cmap_regs_phys = 0xf301b000;     /* XXX not in prom? */
         request_mem_region(pinfo->cmap_regs_phys, 0x1000, "platinumfb cmap");
@@ -624,18 +636,16 @@ static int __devexit platinumfb_remove(struct of_device* odev)
 {
         struct fb_info          *info = dev_get_drvdata(&odev->dev);
         struct fb_info_platinum *pinfo = info->par;
-        struct device_node *dp = odev->node;
-        unsigned long addr, size;
-        int i;
         
         unregister_framebuffer (info);
         
         /* Unmap frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                size = dp->addrs[i].size;
-                release_mem_region(addr, size);
-        }
+        release_mem_region(pinfo->rsrc_fb.start,
+                           pinfo->rsrc_fb.end -
+                           pinfo->rsrc_fb.start + 1);
+        release_mem_region(pinfo->rsrc_reg.start,
+                           pinfo->rsrc_reg.end -
+                           pinfo->rsrc_reg.start + 1);
         iounmap(pinfo->frame_buffer);
         iounmap(pinfo->platinum_regs);
         release_mem_region(pinfo->cmap_regs_phys, 0x1000);
@@ -662,7 +672,7 @@ static struct of_platform_driver platinum_driver =
         .remove         = platinumfb_remove,
 };
 
-int __init platinumfb_init(void)
+static int __init platinumfb_init(void)
 {
 #ifndef MODULE
         char *option = NULL;
@@ -676,7 +686,7 @@ int __init platinumfb_init(void)
         return 0;
 }
 
-void __exit platinumfb_exit(void)
+static void __exit platinumfb_exit(void)
 {
         of_unregister_driver(&platinum_driver); 
 }
diff --git a/drivers/video/platinumfb.h b/drivers/video/platinumfb.h
index 2834fc1c344b..f6bd77cafd17 100644
--- a/drivers/video/platinumfb.h
+++ b/drivers/video/platinumfb.h
@@ -158,7 +158,9 @@ static struct platinum_regvals platinum_reg_init_14 = {
 /* 832x624, 75Hz (13) */
 static struct platinum_regvals platinum_reg_init_13 = {
         0x70,
-        { 864, 1680, 3360 },    /* MacOS does 1680 instead of 1696 to fit 16bpp in 1MB */
+        { 864, 1680, 3344 },    /* MacOS does 1680 instead of 1696 to fit 16bpp in 1MB,
+                                 * and we use 3344 instead of 3360 to fit in 2Mb
+                                 */
         { 0xff0, 4, 0, 0, 0, 0, 0x299, 0,
           0, 0x21e, 0x120, 0x10, 0x23f, 0x1f, 0x25, 0x37,
           0x8a, 0x22a, 0x23e, 0x536, 0x534, 4, 9, 0x52,
diff --git a/drivers/video/valkyriefb.c b/drivers/video/valkyriefb.c
index ce97ec8eae97..2bdeb4baa952 100644
--- a/drivers/video/valkyriefb.c
+++ b/drivers/video/valkyriefb.c
@@ -342,19 +342,19 @@ int __init valkyriefb_init(void)
 #else /* ppc (!CONFIG_MAC) */
         {
                 struct device_node *dp;
+                struct resource r;
 
-                dp = find_devices("valkyrie");
+                dp = of_find_node_by_name(NULL, "valkyrie");
                 if (dp == 0)
                         return 0;
 
-                if (dp->n_addrs != 1) {
-                        printk(KERN_ERR "expecting 1 address for valkyrie (got %d)\n",
-                               dp->n_addrs);
+                if (of_address_to_resource(dp, 0, &r)) {
+                        printk(KERN_ERR "can't find address for valkyrie\n");
                         return 0;
                 }
 
-                frame_buffer_phys = dp->addrs[0].address;
-                cmap_regs_phys = dp->addrs[0].address+0x304000;
+                frame_buffer_phys = r.start;
+                cmap_regs_phys = r.start + 0x304000;
                 flags = _PAGE_WRITETHRU;
         }
 #endif /* ppc (!CONFIG_MAC) */