284 files changed, 8767 insertions, 6294 deletions

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb194f3c..1622772f802d 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -30,6 +30,7 @@
 #include <net/bluetooth/bluetooth.h>
 
 #define VERSION "1.0"
+#define ATH3K_FIRMWARE  "ath3k-1.fw"
 
 #define ATH3K_DNLOAD                            0x01
 #define ATH3K_GETSTATE                          0x05
@@ -400,9 +401,15 @@ static int ath3k_probe(struct usb_interface *intf,
                 return 0;
         }
 
-        if (request_firmware(&firmware, "ath3k-1.fw", &udev->dev) < 0) {
-                BT_ERR("Error loading firmware");
-                return -EIO;
+        ret = request_firmware(&firmware, ATH3K_FIRMWARE, &udev->dev);
+        if (ret < 0) {
+                if (ret == -ENOENT)
+                        BT_ERR("Firmware file \"%s\" not found",
+                                                        ATH3K_FIRMWARE);
+                else
+                        BT_ERR("Firmware file \"%s\" request failed (err=%d)",
+                                                        ATH3K_FIRMWARE, ret);
+                return ret;
         }
 
         ret = ath3k_load_firmware(udev, firmware);
@@ -441,4 +448,4 @@ MODULE_AUTHOR("Atheros Communications");
 MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
 MODULE_VERSION(VERSION);
 MODULE_LICENSE("GPL");
-MODULE_FIRMWARE("ath3k-1.fw");
+MODULE_FIRMWARE(ATH3K_FIRMWARE);
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index 61b591470a90..a936763b8c3d 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -751,9 +751,7 @@ static void bfusb_disconnect(struct usb_interface *intf)
 
         bfusb_close(hdev);
 
-        if (hci_unregister_dev(hdev) < 0)
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 }
 
diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
index aed1904ea67b..c6a0c6103743 100644
--- a/drivers/bluetooth/bluecard_cs.c
+++ b/drivers/bluetooth/bluecard_cs.c
@@ -844,9 +844,7 @@ static int bluecard_close(bluecard_info_t *info)
         /* Turn FPGA off */
         outb(0x80, iobase + 0x30);
 
-        if (hci_unregister_dev(hdev) < 0)
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 
         return 0;
diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
index 4fc01949d399..0c97e5d514b6 100644
--- a/drivers/bluetooth/bt3c_cs.c
+++ b/drivers/bluetooth/bt3c_cs.c
@@ -636,9 +636,7 @@ static int bt3c_close(bt3c_info_t *info)
 
         bt3c_hci_close(hdev);
 
-        if (hci_unregister_dev(hdev) < 0)
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 
         return 0;
diff --git a/drivers/bluetooth/btuart_cs.c b/drivers/bluetooth/btuart_cs.c
index 526b61807d94..200b3a2877d6 100644
--- a/drivers/bluetooth/btuart_cs.c
+++ b/drivers/bluetooth/btuart_cs.c
@@ -565,9 +565,7 @@ static int btuart_close(btuart_info_t *info)
 
         spin_unlock_irqrestore(&(info->lock), flags);
 
-        if (hci_unregister_dev(hdev) < 0)
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 
         return 0;
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fe4ebc375b3d..2bd87d45f1c2 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -315,7 +315,8 @@ static int btusb_submit_intr_urb(struct hci_dev *hdev, gfp_t mem_flags)
 
         err = usb_submit_urb(urb, mem_flags);
         if (err < 0) {
-                BT_ERR("%s urb %p submission failed (%d)",
+                if (err != -EPERM && err != -ENODEV)
+                        BT_ERR("%s urb %p submission failed (%d)",
                                                 hdev->name, urb, -err);
                 usb_unanchor_urb(urb);
         }
@@ -400,7 +401,8 @@ static int btusb_submit_bulk_urb(struct hci_dev *hdev, gfp_t mem_flags)
 
         err = usb_submit_urb(urb, mem_flags);
         if (err < 0) {
-                BT_ERR("%s urb %p submission failed (%d)",
+                if (err != -EPERM && err != -ENODEV)
+                        BT_ERR("%s urb %p submission failed (%d)",
                                                 hdev->name, urb, -err);
                 usb_unanchor_urb(urb);
         }
@@ -523,7 +525,8 @@ static int btusb_submit_isoc_urb(struct hci_dev *hdev, gfp_t mem_flags)
 
         err = usb_submit_urb(urb, mem_flags);
         if (err < 0) {
-                BT_ERR("%s urb %p submission failed (%d)",
+                if (err != -EPERM && err != -ENODEV)
+                        BT_ERR("%s urb %p submission failed (%d)",
                                                 hdev->name, urb, -err);
                 usb_unanchor_urb(urb);
         }
@@ -727,6 +730,9 @@ static int btusb_send_frame(struct sk_buff *skb)
                 usb_fill_bulk_urb(urb, data->udev, pipe,
                                 skb->data, skb->len, btusb_tx_complete, skb);
 
+                if (skb->priority >= HCI_PRIO_MAX - 1)
+                        urb->transfer_flags  = URB_ISO_ASAP;
+
                 hdev->stat.acl_tx++;
                 break;
 
@@ -770,7 +776,9 @@ skip_waking:
 
         err = usb_submit_urb(urb, GFP_ATOMIC);
         if (err < 0) {
-                BT_ERR("%s urb %p submission failed", hdev->name, urb);
+                if (err != -EPERM && err != -ENODEV)
+                        BT_ERR("%s urb %p submission failed (%d)",
+                                                hdev->name, urb, -err);
                 kfree(urb->setup_packet);
                 usb_unanchor_urb(urb);
         } else {
diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c
index 5e4c2de9fc3f..969bb22e493f 100644
--- a/drivers/bluetooth/dtl1_cs.c
+++ b/drivers/bluetooth/dtl1_cs.c
@@ -551,9 +551,7 @@ static int dtl1_close(dtl1_info_t *info)
 
         spin_unlock_irqrestore(&(info->lock), flags);
 
-        if (hci_unregister_dev(hdev) < 0)
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 
         return 0;
diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index 67c180c2c1e0..2e302a11ab55 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -264,10 +264,7 @@ static int vhci_release(struct inode *inode, struct file *file)
         struct vhci_data *data = file->private_data;
         struct hci_dev *hdev = data->hdev;
 
-        if (hci_unregister_dev(hdev) < 0) {
-                BT_ERR("Can't unregister HCI device %s", hdev->name);
-        }
-
+        hci_unregister_dev(hdev);
         hci_free_dev(hdev);
 
         file->private_data = NULL;
diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index eb0e2ccc79ae..73d453159408 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -343,7 +343,7 @@ static void ieee802154_fake_setup(struct net_device *dev)
 {
         dev->addr_len           = IEEE802154_ADDR_LEN;
         memset(dev->broadcast, 0xff, IEEE802154_ADDR_LEN);
-        dev->features           = NETIF_F_NO_CSUM;
+        dev->features           = NETIF_F_HW_CSUM;
         dev->needed_tailroom    = 2; /* FCS */
         dev->mtu                = 127;
         dev->tx_queue_len       = 10;
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index c00d2f3f8966..4b3fa711a247 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -1589,7 +1589,7 @@ static const struct ethtool_ops nes_ethtool_ops = {
         .set_pauseparam = nes_netdev_set_pauseparam,
 };
 
-static void nes_vlan_mode(struct net_device *netdev, struct nes_device *nesdev, u32 features)
+static void nes_vlan_mode(struct net_device *netdev, struct nes_device *nesdev, netdev_features_t features)
 {
         struct nes_adapter *nesadapter = nesdev->nesadapter;
         u32 u32temp;
@@ -1610,7 +1610,7 @@ static void nes_vlan_mode(struct net_device *netdev, struct nes_device *nesdev,
         spin_unlock_irqrestore(&nesadapter->phy_lock, flags);
 }
 
-static u32 nes_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t nes_fix_features(struct net_device *netdev, netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -1624,7 +1624,7 @@ static u32 nes_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int nes_set_features(struct net_device *netdev, u32 features)
+static int nes_set_features(struct net_device *netdev, netdev_features_t features)
 {
         struct nes_vnic *nesvnic = netdev_priv(netdev);
         struct nes_device *nesdev = nesvnic->nesdev;
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 7567b6000230..efd7a9636aff 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -171,7 +171,7 @@ static int ipoib_stop(struct net_device *dev)
         return 0;
 }
 
-static u32 ipoib_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t ipoib_fix_features(struct net_device *dev, netdev_features_t features)
 {
         struct ipoib_dev_priv *priv = netdev_priv(dev);
 
diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/lguest_device.c
index 0dc30ffde5ad..595d73197016 100644
--- a/drivers/lguest/lguest_device.c
+++ b/drivers/lguest/lguest_device.c
@@ -381,6 +381,11 @@ error:
         return PTR_ERR(vqs[i]);
 }
 
+static const char *lg_bus_name(struct virtio_device *vdev)
+{
+        return "";
+}
+
 /* The ops structure which hooks everything together. */
 static struct virtio_config_ops lguest_config_ops = {
         .get_features = lg_get_features,
@@ -392,6 +397,7 @@ static struct virtio_config_ops lguest_config_ops = {
         .reset = lg_reset,
         .find_vqs = lg_find_vqs,
         .del_vqs = lg_del_vqs,
+        .bus_name = lg_bus_name,
 };
 
 /*
diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
index 42f067347bc7..3fac67a5204c 100644
--- a/drivers/misc/sgi-xp/xpnet.c
+++ b/drivers/misc/sgi-xp/xpnet.c
@@ -576,7 +576,7 @@ xpnet_init(void)
          * report an error if the data is not retrievable and the
          * packet will be dropped.
          */
-        xpnet_device->features = NETIF_F_NO_CSUM;
+        xpnet_device->features = NETIF_F_HW_CSUM;
 
         result = register_netdev(xpnet_device);
         if (result != 0) {
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 654a5e94e0e7..debdf1c07c5b 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -125,6 +125,8 @@ config IFB
           'ifb1' etc.
           Look at the iproute2 documentation directory for usage etc
 
+source "drivers/net/team/Kconfig"
+
 config MACVLAN
         tristate "MAC-VLAN support (EXPERIMENTAL)"
         depends on EXPERIMENTAL
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index fa877cd2b139..4e4ebfe1aa53 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -17,6 +17,7 @@ obj-$(CONFIG_NET) += Space.o loopback.o
 obj-$(CONFIG_NETCONSOLE) += netconsole.o
 obj-$(CONFIG_PHYLIB) += phy/
 obj-$(CONFIG_RIONET) += rionet.o
+obj-$(CONFIG_NET_TEAM) += team/
 obj-$(CONFIG_TUN) += tun.o
 obj-$(CONFIG_VETH) += veth.o
 obj-$(CONFIG_VIRTIO_NET) += virtio_net.o
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b0c577256487..25a44d94be17 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1325,11 +1325,12 @@ static int bond_sethwaddr(struct net_device *bond_dev,
         return 0;
 }
 
-static u32 bond_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t bond_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct slave *slave;
         struct bonding *bond = netdev_priv(dev);
-        u32 mask;
+        netdev_features_t mask;
         int i;
 
         read_lock(&bond->lock);
@@ -1363,7 +1364,7 @@ static void bond_compute_features(struct bonding *bond)
 {
         struct slave *slave;
         struct net_device *bond_dev = bond->dev;
-        u32 vlan_features = BOND_VLAN_FEATURES;
+        netdev_features_t vlan_features = BOND_VLAN_FEATURES;
         unsigned short max_hard_header_len = ETH_HLEN;
         int i;
 
@@ -1897,7 +1898,7 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
         struct bonding *bond = netdev_priv(bond_dev);
         struct slave *slave, *oldcurrent;
         struct sockaddr addr;
-        u32 old_features = bond_dev->features;
+        netdev_features_t old_features = bond_dev->features;
 
         /* slave is not a slave or master is not master of this slave */
         if (!(slave_dev->flags & IFF_SLAVE) ||
@@ -4360,7 +4361,7 @@ static void bond_setup(struct net_device *bond_dev)
                                 NETIF_F_HW_VLAN_RX |
                                 NETIF_F_HW_VLAN_FILTER;
 
-        bond_dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_NO_CSUM);
+        bond_dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_HW_CSUM);
         bond_dev->features |= bond_dev->hw_features;
 }
 
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 25695bde0549..120f1ab5a2ce 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -454,7 +454,7 @@ static void can_setup(struct net_device *dev)
 
         /* New-style flags. */
         dev->flags = IFF_NOARP;
-        dev->features = NETIF_F_NO_CSUM;
+        dev->features = NETIF_F_HW_CSUM;
 }
 
 struct sk_buff *alloc_can_skb(struct net_device *dev, struct can_frame **cf)
diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index ec4a3119e2c9..1c82dd8b896e 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -581,7 +581,10 @@ static int mscan_open(struct net_device *dev)
 
         priv->open_time = jiffies;
 
-        clrbits8(&regs->canctl1, MSCAN_LISTEN);
+        if (priv->can.ctrlmode & CAN_CTRLMODE_LISTENONLY)
+                setbits8(&regs->canctl1, MSCAN_LISTEN);
+        else
+                clrbits8(&regs->canctl1, MSCAN_LISTEN);
 
         ret = mscan_start(dev);
         if (ret)
@@ -690,7 +693,8 @@ struct net_device *alloc_mscandev(void)
         priv->can.bittiming_const = &mscan_bittiming_const;
         priv->can.do_set_bittiming = mscan_do_set_bittiming;
         priv->can.do_set_mode = mscan_do_set_mode;
-        priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
+        priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
+                CAN_CTRLMODE_LISTENONLY;
 
         for (i = 0; i < TX_QUEUE_SIZE; i++) {
                 priv->tx_queue[i].id = i;
diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c
index a979b006f459..3f1ebcc2cb83 100644
--- a/drivers/net/can/slcan.c
+++ b/drivers/net/can/slcan.c
@@ -387,7 +387,7 @@ static void slc_setup(struct net_device *dev)
 
         /* New-style flags. */
         dev->flags              = IFF_NOARP;
-        dev->features           = NETIF_F_NO_CSUM;
+        dev->features           = NETIF_F_HW_CSUM;
 }
 
 /******************************************
diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c
index a7c5e8831e8c..087648ea1edb 100644
--- a/drivers/net/dummy.c
+++ b/drivers/net/dummy.c
@@ -134,7 +134,7 @@ static void dummy_setup(struct net_device *dev)
         dev->flags |= IFF_NOARP;
         dev->flags &= ~IFF_MULTICAST;
         dev->features   |= NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO;
-        dev->features   |= NETIF_F_NO_CSUM | NETIF_F_HIGHDMA | NETIF_F_LLTX;
+        dev->features   |= NETIF_F_HW_CSUM | NETIF_F_HIGHDMA | NETIF_F_LLTX;
         random_ether_addr(dev->dev_addr);
 }
 
diff --git a/drivers/net/ethernet/3com/3c589_cs.c b/drivers/net/ethernet/3com/3c589_cs.c
index 972f80ecc510..da410f036869 100644
--- a/drivers/net/ethernet/3com/3c589_cs.c
+++ b/drivers/net/ethernet/3com/3c589_cs.c
@@ -468,9 +468,10 @@ static void tc589_reset(struct net_device *dev)
 static void netdev_get_drvinfo(struct net_device *dev,
                                struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        sprintf(info->bus_info, "PCMCIA 0x%lx", dev->base_addr);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        snprintf(info->bus_info, sizeof(info->bus_info),
+                "PCMCIA 0x%lx", dev->base_addr);
 }
 
 static const struct ethtool_ops netdev_ethtool_ops = {
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
index b42c06baba89..8153a3e0a1a4 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -2929,15 +2929,17 @@ static void vortex_get_drvinfo(struct net_device *dev,
 {
         struct vortex_private *vp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
         if (VORTEX_PCI(vp)) {
-                strcpy(info->bus_info, pci_name(VORTEX_PCI(vp)));
+                strlcpy(info->bus_info, pci_name(VORTEX_PCI(vp)),
+                        sizeof(info->bus_info));
         } else {
                 if (VORTEX_EISA(vp))
-                        strcpy(info->bus_info, dev_name(vp->gendev));
+                        strlcpy(info->bus_info, dev_name(vp->gendev),
+                                sizeof(info->bus_info));
                 else
-                        sprintf(info->bus_info, "EISA 0x%lx %d",
-                                        dev->base_addr, dev->irq);
+                        snprintf(info->bus_info, sizeof(info->bus_info),
+                                "EISA 0x%lx %d", dev->base_addr, dev->irq);
         }
 }
 
diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c
index 20ea07508ac7..6d6bc754b1a8 100644
--- a/drivers/net/ethernet/3com/typhoon.c
+++ b/drivers/net/ethernet/3com/typhoon.c
@@ -988,21 +988,23 @@ typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 
         smp_rmb();
         if(tp->card_state == Sleeping) {
-                strcpy(info->fw_version, "Sleep image");
+                strlcpy(info->fw_version, "Sleep image",
+                        sizeof(info->fw_version));
         } else {
                 INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_READ_VERSIONS);
                 if(typhoon_issue_command(tp, 1, &xp_cmd, 3, xp_resp) < 0) {
-                        strcpy(info->fw_version, "Unknown runtime");
+                        strlcpy(info->fw_version, "Unknown runtime",
+                                sizeof(info->fw_version));
                 } else {
                         u32 sleep_ver = le32_to_cpu(xp_resp[0].parm2);
-                        snprintf(info->fw_version, 32, "%02x.%03x.%03x",
-                                 sleep_ver >> 24, (sleep_ver >> 12) & 0xfff,
-                                 sleep_ver & 0xfff);
+                        snprintf(info->fw_version, sizeof(info->fw_version),
+                                "%02x.%03x.%03x", sleep_ver >> 24,
+                                (sleep_ver >> 12) & 0xfff, sleep_ver & 0xfff);
                 }
         }
 
-        strcpy(info->driver, KBUILD_MODNAME);
-        strcpy(info->bus_info, pci_name(pci_dev));
+        strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
+        strlcpy(info->bus_info, pci_name(pci_dev), sizeof(info->bus_info));
 }
 
 static int
diff --git a/drivers/net/ethernet/8390/8390.h b/drivers/net/ethernet/8390/8390.h
index 58a12e4c78f9..ef325ffa1b5a 100644
--- a/drivers/net/ethernet/8390/8390.h
+++ b/drivers/net/ethernet/8390/8390.h
@@ -14,8 +14,6 @@
 
 #define TX_PAGES 12     /* Two Tx slots */
 
-#define ETHER_ADDR_LEN 6
-
 /* The 8390 specific per-packet-header format. */
 struct e8390_pkt_hdr {
   unsigned char status; /* status */
diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
index 547737340cbb..3ad5d2f9a49c 100644
--- a/drivers/net/ethernet/8390/apne.c
+++ b/drivers/net/ethernet/8390/apne.c
@@ -318,7 +318,7 @@ static int __init apne_probe1(struct net_device *dev, int ioaddr)
     i = request_irq(dev->irq, apne_interrupt, IRQF_SHARED, DRV_NAME, dev);
     if (i) return i;
 
-    for(i = 0; i < ETHER_ADDR_LEN; i++)
+    for (i = 0; i < ETH_ALEN; i++)
         dev->dev_addr[i] = SA_prom[i];
 
     printk(" %pM\n", dev->dev_addr);
diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c
index e9f8432f55b4..2a3b8c2676bd 100644
--- a/drivers/net/ethernet/8390/ax88796.c
+++ b/drivers/net/ethernet/8390/ax88796.c
@@ -735,15 +735,14 @@ static int ax_init_dev(struct net_device *dev)
         if (ax->plat->flags & AXFLG_MAC_FROMDEV) {
                 ei_outb(E8390_NODMA + E8390_PAGE1 + E8390_STOP,
                         ei_local->mem + E8390_CMD); /* 0x61 */
-                for (i = 0; i < ETHER_ADDR_LEN; i++)
+                for (i = 0; i < ETH_ALEN; i++)
                         dev->dev_addr[i] =
                                 ei_inb(ioaddr + EN1_PHYS_SHIFT(i));
         }
 
         if ((ax->plat->flags & AXFLG_MAC_FROMPLATFORM) &&
             ax->plat->mac_addr)
-                memcpy(dev->dev_addr, ax->plat->mac_addr,
-                       ETHER_ADDR_LEN);
+                memcpy(dev->dev_addr, ax->plat->mac_addr, ETH_ALEN);
 
         ax_reset_8390(dev);
 
diff --git a/drivers/net/ethernet/8390/es3210.c b/drivers/net/ethernet/8390/es3210.c
index 7a09575ecff0..6428f9e7a554 100644
--- a/drivers/net/ethernet/8390/es3210.c
+++ b/drivers/net/ethernet/8390/es3210.c
@@ -195,7 +195,7 @@ static int __init es_probe1(struct net_device *dev, int ioaddr)
                 goto out;
         }
 
-        for (i = 0; i < ETHER_ADDR_LEN ; i++)
+        for (i = 0; i < ETH_ALEN ; i++)
                 dev->dev_addr[i] = inb(ioaddr + ES_SA_PROM + i);
 
 /*      Check the Racal vendor ID as well. */
diff --git a/drivers/net/ethernet/8390/hp-plus.c b/drivers/net/ethernet/8390/hp-plus.c
index eeac843dcd2d..d42938b6b596 100644
--- a/drivers/net/ethernet/8390/hp-plus.c
+++ b/drivers/net/ethernet/8390/hp-plus.c
@@ -202,7 +202,7 @@ static int __init hpp_probe1(struct net_device *dev, int ioaddr)
         /* Retrieve and checksum the station address. */
         outw(MAC_Page, ioaddr + HP_PAGING);
 
-        for(i = 0; i < ETHER_ADDR_LEN; i++) {
+        for(i = 0; i < ETH_ALEN; i++) {
                 unsigned char inval = inb(ioaddr + 8 + i);
                 dev->dev_addr[i] = inval;
                 checksum += inval;
diff --git a/drivers/net/ethernet/8390/hp.c b/drivers/net/ethernet/8390/hp.c
index 18564d4a7c04..113f1e075a26 100644
--- a/drivers/net/ethernet/8390/hp.c
+++ b/drivers/net/ethernet/8390/hp.c
@@ -156,7 +156,7 @@ static int __init hp_probe1(struct net_device *dev, int ioaddr)
 
         printk("%s: %s (ID %02x) at %#3x,", dev->name, name, board_id, ioaddr);
 
-        for(i = 0; i < ETHER_ADDR_LEN; i++)
+        for(i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = inb(ioaddr + i);
 
         printk(" %pM", dev->dev_addr);
diff --git a/drivers/net/ethernet/8390/hydra.c b/drivers/net/ethernet/8390/hydra.c
index 3dac937a67c4..5370c884620b 100644
--- a/drivers/net/ethernet/8390/hydra.c
+++ b/drivers/net/ethernet/8390/hydra.c
@@ -129,7 +129,7 @@ static int __devinit hydra_init(struct zorro_dev *z)
     if (!dev)
         return -ENOMEM;
 
-    for(j = 0; j < ETHER_ADDR_LEN; j++)
+    for (j = 0; j < ETH_ALEN; j++)
         dev->dev_addr[j] = *((u8 *)(board + HYDRA_ADDRPROM + 2*j));
 
     /* We must set the 8390 for word mode. */
diff --git a/drivers/net/ethernet/8390/lne390.c b/drivers/net/ethernet/8390/lne390.c
index f9888d20177b..69490ae018ea 100644
--- a/drivers/net/ethernet/8390/lne390.c
+++ b/drivers/net/ethernet/8390/lne390.c
@@ -191,14 +191,14 @@ static int __init lne390_probe1(struct net_device *dev, int ioaddr)
                 || inb(ioaddr + LNE390_SA_PROM + 1) != LNE390_ADDR1
                 || inb(ioaddr + LNE390_SA_PROM + 2) != LNE390_ADDR2 ) {
                 printk("lne390.c: card not found");
-                for(i = 0; i < ETHER_ADDR_LEN; i++)
+                for (i = 0; i < ETH_ALEN; i++)
                         printk(" %02x", inb(ioaddr + LNE390_SA_PROM + i));
                 printk(" (invalid prefix).\n");
                 return -ENODEV;
         }
 #endif
 
-        for(i = 0; i < ETHER_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = inb(ioaddr + LNE390_SA_PROM + i);
         printk("lne390.c: LNE390%X in EISA slot %d, address %pM.\n",
                0xa+revision, ioaddr/0x1000, dev->dev_addr);
diff --git a/drivers/net/ethernet/8390/ne-h8300.c b/drivers/net/ethernet/8390/ne-h8300.c
index cd36a6a5f408..9b9c77d5a65c 100644
--- a/drivers/net/ethernet/8390/ne-h8300.c
+++ b/drivers/net/ethernet/8390/ne-h8300.c
@@ -312,7 +312,7 @@ static int __init ne_probe1(struct net_device *dev, int ioaddr)
 
         dev->base_addr = ioaddr;
 
-        for(i = 0; i < ETHER_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = SA_prom[i];
         printk(" %pM\n", dev->dev_addr);
 
diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c
index 1063093b3afc..f92ea2a65a57 100644
--- a/drivers/net/ethernet/8390/ne.c
+++ b/drivers/net/ethernet/8390/ne.c
@@ -503,12 +503,12 @@ static int __init ne_probe1(struct net_device *dev, unsigned long ioaddr)
 #ifdef CONFIG_PLAT_MAPPI
         outb_p(E8390_NODMA + E8390_PAGE1 + E8390_STOP,
                 ioaddr + E8390_CMD); /* 0x61 */
-        for (i = 0 ; i < ETHER_ADDR_LEN ; i++) {
+        for (i = 0; i < ETH_ALEN; i++) {
                 dev->dev_addr[i] = SA_prom[i]
                         = inb_p(ioaddr + EN1_PHYS_SHIFT(i));
         }
 #else
-        for(i = 0; i < ETHER_ADDR_LEN; i++) {
+        for (i = 0; i < ETH_ALEN; i++) {
                 dev->dev_addr[i] = SA_prom[i];
         }
 #endif
diff --git a/drivers/net/ethernet/8390/ne2.c b/drivers/net/ethernet/8390/ne2.c
index 70cdc6996342..922b32036c63 100644
--- a/drivers/net/ethernet/8390/ne2.c
+++ b/drivers/net/ethernet/8390/ne2.c
@@ -460,7 +460,7 @@ static int __init ne2_probe1(struct net_device *dev, int slot)
 
         dev->base_addr = base_addr;
 
-        for(i = 0; i < ETHER_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = SA_prom[i];
 
         printk(" %pM\n", dev->dev_addr);
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
index 39923425ba25..3fab04a0034a 100644
--- a/drivers/net/ethernet/8390/ne2k-pci.c
+++ b/drivers/net/ethernet/8390/ne2k-pci.c
@@ -639,9 +639,9 @@ static void ne2k_pci_get_drvinfo(struct net_device *dev,
         struct ei_device *ei = netdev_priv(dev);
         struct pci_dev *pci_dev = (struct pci_dev *) ei->priv;
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(pci_dev), sizeof(info->bus_info));
 }
 
 static const struct ethtool_ops ne2k_pci_ethtool_ops = {
diff --git a/drivers/net/ethernet/8390/ne3210.c b/drivers/net/ethernet/8390/ne3210.c
index 243ed2aee88e..2a3e8057feae 100644
--- a/drivers/net/ethernet/8390/ne3210.c
+++ b/drivers/net/ethernet/8390/ne3210.c
@@ -125,7 +125,7 @@ static int __init ne3210_eisa_probe (struct device *device)
 #endif
 
         port_index = inb(ioaddr + NE3210_CFG2) >> 6;
-        for(i = 0; i < ETHER_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = inb(ioaddr + NE3210_SA_PROM + i);
         printk("ne3210.c: NE3210 in EISA slot %d, media: %s, addr: %pM.\n",
                 edev->slot, ifmap[port_index], dev->dev_addr);
diff --git a/drivers/net/ethernet/8390/stnic.c b/drivers/net/ethernet/8390/stnic.c
index d85f0a84bc7b..3b903759980a 100644
--- a/drivers/net/ethernet/8390/stnic.c
+++ b/drivers/net/ethernet/8390/stnic.c
@@ -114,7 +114,7 @@ static int __init stnic_probe(void)
 #ifdef CONFIG_SH_STANDARD_BIOS
   sh_bios_get_node_addr (stnic_eadr);
 #endif
-  for (i = 0; i < ETHER_ADDR_LEN; i++)
+  for (i = 0; i < ETH_ALEN; i++)
     dev->dev_addr[i] = stnic_eadr[i];
 
   /* Set the base address to point to the NIC, not the "real" base! */
diff --git a/drivers/net/ethernet/8390/zorro8390.c b/drivers/net/ethernet/8390/zorro8390.c
index 3aa9fe9999b5..bcd27323b203 100644
--- a/drivers/net/ethernet/8390/zorro8390.c
+++ b/drivers/net/ethernet/8390/zorro8390.c
@@ -365,7 +365,7 @@ static int __devinit zorro8390_init(struct net_device *dev,
         if (i)
                 return i;
 
-        for (i = 0; i < ETHER_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = SA_prom[i];
 
         pr_debug("Found ethernet address: %pM\n", dev->dev_addr);
diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c
index 6d9f6911000f..a446e251908b 100644
--- a/drivers/net/ethernet/adaptec/starfire.c
+++ b/drivers/net/ethernet/adaptec/starfire.c
@@ -1842,9 +1842,9 @@ static int check_if_running(struct net_device *dev)
 static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct netdev_private *np = netdev_priv(dev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c
index a9745f4ddbfe..33e0a8c20f6b 100644
--- a/drivers/net/ethernet/amd/amd8111e.c
+++ b/drivers/net/ethernet/amd/amd8111e.c
@@ -499,7 +499,7 @@ static int amd8111e_restart(struct net_device *dev)
         writel( VAL0 | APAD_XMT | REX_RTRY, mmio + CMD2 );
 
         /* Setting the MAC address to the device */
-        for(i = 0; i < ETH_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 writeb( dev->dev_addr[i], mmio + PADR + i );
 
         /* Enable interrupt coalesce */
@@ -1412,10 +1412,11 @@ static void amd8111e_get_drvinfo(struct net_device* dev, struct ethtool_drvinfo
 {
         struct amd8111e_priv *lp = netdev_priv(dev);
         struct pci_dev *pci_dev = lp->pci_dev;
-        strcpy (info->driver, MODULE_NAME);
-        strcpy (info->version, MODULE_VERS);
-        sprintf(info->fw_version,"%u",chip_version);
-        strcpy (info->bus_info, pci_name(pci_dev));
+        strlcpy(info->driver, MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, MODULE_VERS, sizeof(info->version));
+        snprintf(info->fw_version, sizeof(info->fw_version),
+                "%u", chip_version);
+        strlcpy(info->bus_info, pci_name(pci_dev), sizeof(info->bus_info));
 }
 
 static int amd8111e_get_regs_len(struct net_device *dev)
@@ -1549,7 +1550,7 @@ static int amd8111e_set_mac_address(struct net_device *dev, void *p)
         memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
         spin_lock_irq(&lp->lock);
         /* Setting the MAC address to the device */
-        for(i = 0; i < ETH_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 writeb( dev->dev_addr[i], lp->mmio + PADR + i );
 
         spin_unlock_irq(&lp->lock);
@@ -1885,7 +1886,7 @@ static int __devinit amd8111e_probe_one(struct pci_dev *pdev,
         }
 
         /* Initializing MAC address */
-        for(i = 0; i < ETH_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = readb(lp->mmio + PADR + i);
 
         /* Setting user defined parametrs */
diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 2ff2e7a12dd0..5bbb53a1999c 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -586,7 +586,6 @@ typedef enum {
 
 #define PKT_BUFF_SZ                     1536
 #define MIN_PKT_LEN                     60
-#define ETH_ADDR_LEN                    6
 
 #define  AMD8111E_TX_TIMEOUT            (3 * HZ)/* 3 sec */
 #define SOFT_TIMER_FREQ                 0xBEBC  /* 0.5 sec */
diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 3accd5d21b08..6be0dd67631a 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -160,8 +160,6 @@ Include Files
 Defines
 ---------------------------------------------------------------------------- */
 
-#define ETHER_ADDR_LEN                  ETH_ALEN
-                                        /* 6 bytes in an Ethernet Address */
 #define MACE_LADRF_LEN                  8
                                         /* 8 bytes in Logical Address Filter */
 
@@ -600,7 +598,7 @@ static int mace_init(mace_private *lp, unsigned int ioaddr, char *enet_addr)
         }
   }
   /* Set PADR register */
-  for (i = 0; i < ETHER_ADDR_LEN; i++)
+  for (i = 0; i < ETH_ALEN; i++)
     mace_write(lp, ioaddr, MACE_PADR, enet_addr[i]);
 
   /* MAC Configuration Control Register should be written last */
@@ -639,11 +637,11 @@ static int nmclan_config(struct pcmcia_device *link)
 
   /* Read the ethernet address from the CIS. */
   len = pcmcia_get_tuple(link, 0x80, &buf);
-  if (!buf || len < ETHER_ADDR_LEN) {
+  if (!buf || len < ETH_ALEN) {
           kfree(buf);
           goto failed;
   }
-  memcpy(dev->dev_addr, buf, ETHER_ADDR_LEN);
+  memcpy(dev->dev_addr, buf, ETH_ALEN);
   kfree(buf);
 
   /* Verify configuration by reading the MACE ID. */
@@ -822,9 +820,10 @@ static int mace_close(struct net_device *dev)
 static void netdev_get_drvinfo(struct net_device *dev,
                                struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        sprintf(info->bus_info, "PCMCIA 0x%lx", dev->base_addr);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        snprintf(info->bus_info, sizeof(info->bus_info),
+                "PCMCIA 0x%lx", dev->base_addr);
 }
 
 static const struct ethtool_ops netdev_ethtool_ops = {
@@ -1420,7 +1419,7 @@ Output
 static void set_multicast_list(struct net_device *dev)
 {
   mace_private *lp = netdev_priv(dev);
-  int adr[ETHER_ADDR_LEN] = {0}; /* Ethernet address */
+  int adr[ETH_ALEN] = {0}; /* Ethernet address */
   struct netdev_hw_addr *ha;
 
 #ifdef PCMCIA_DEBUG
@@ -1442,7 +1441,7 @@ static void set_multicast_list(struct net_device *dev)
     /* Calculate multicast logical address filter */
     memset(lp->multicast_ladrf, 0, MACE_LADRF_LEN);
     netdev_for_each_mc_addr(ha, dev) {
-      memcpy(adr, ha->addr, ETHER_ADDR_LEN);
+      memcpy(adr, ha->addr, ETH_ALEN);
       BuildLAF(lp->multicast_ladrf, adr);
     }
   }
diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
index f92bc6e34828..20e6dab0186c 100644
--- a/drivers/net/ethernet/amd/pcnet32.c
+++ b/drivers/net/ethernet/amd/pcnet32.c
@@ -711,12 +711,14 @@ static void pcnet32_get_drvinfo(struct net_device *dev,
 {
         struct pcnet32_private *lp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
         if (lp->pci_dev)
-                strcpy(info->bus_info, pci_name(lp->pci_dev));
+                strlcpy(info->bus_info, pci_name(lp->pci_dev),
+                        sizeof(info->bus_info));
         else
-                sprintf(info->bus_info, "VLB 0x%lx", dev->base_addr);
+                snprintf(info->bus_info, sizeof(info->bus_info),
+                        "VLB 0x%lx", dev->base_addr);
 }
 
 static u32 pcnet32_get_link(struct net_device *dev)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 02c7ed8d9eca..b8591246eb4c 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -411,7 +411,7 @@ static void atl1c_set_multi(struct net_device *netdev)
         }
 }
 
-static void __atl1c_vlan_mode(u32 features, u32 *mac_ctrl_data)
+static void __atl1c_vlan_mode(netdev_features_t features, u32 *mac_ctrl_data)
 {
         if (features & NETIF_F_HW_VLAN_RX) {
                 /* enable VLAN tag insert/strip */
@@ -422,7 +422,8 @@ static void __atl1c_vlan_mode(u32 features, u32 *mac_ctrl_data)
         }
 }
 
-static void atl1c_vlan_mode(struct net_device *netdev, u32 features)
+static void atl1c_vlan_mode(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct atl1c_adapter *adapter = netdev_priv(netdev);
         struct pci_dev *pdev = adapter->pdev;
@@ -482,7 +483,8 @@ static void atl1c_set_rxbufsize(struct atl1c_adapter *adapter,
                 roundup(mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN, 8) : AT_RX_BUF_SIZE;
 }
 
-static u32 atl1c_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t atl1c_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -499,9 +501,10 @@ static u32 atl1c_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int atl1c_set_features(struct net_device *netdev, u32 features)
+static int atl1c_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 atl1c_vlan_mode(netdev, features);
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c b/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c
index 6269438d365f..6e61f9f9ebb5 100644
--- a/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c
+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c
@@ -310,10 +310,12 @@ static void atl1e_get_drvinfo(struct net_device *netdev,
 {
         struct atl1e_adapter *adapter = netdev_priv(netdev);
 
-        strncpy(drvinfo->driver,  atl1e_driver_name, 32);
-        strncpy(drvinfo->version, atl1e_driver_version, 32);
-        strncpy(drvinfo->fw_version, "L1e", 32);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->driver,  atl1e_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, atl1e_driver_version,
+                sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "L1e", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = 0;
         drvinfo->testinfo_len = 0;
         drvinfo->regdump_len = atl1e_get_regs_len(netdev);
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
index 95483bcac1d0..c915c0873810 100644
--- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
@@ -313,7 +313,7 @@ static void atl1e_set_multi(struct net_device *netdev)
         }
 }
 
-static void __atl1e_vlan_mode(u32 features, u32 *mac_ctrl_data)
+static void __atl1e_vlan_mode(netdev_features_t features, u32 *mac_ctrl_data)
 {
         if (features & NETIF_F_HW_VLAN_RX) {
                 /* enable VLAN tag insert/strip */
@@ -324,7 +324,8 @@ static void __atl1e_vlan_mode(u32 features, u32 *mac_ctrl_data)
         }
 }
 
-static void atl1e_vlan_mode(struct net_device *netdev, u32 features)
+static void atl1e_vlan_mode(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct atl1e_adapter *adapter = netdev_priv(netdev);
         u32 mac_ctrl_data = 0;
@@ -370,7 +371,8 @@ static int atl1e_set_mac_addr(struct net_device *netdev, void *p)
         return 0;
 }
 
-static u32 atl1e_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t atl1e_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -384,9 +386,10 @@ static u32 atl1e_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int atl1e_set_features(struct net_device *netdev, u32 features)
+static int atl1e_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 atl1e_vlan_mode(netdev, features);
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index 1feae5928a4b..071f4c858969 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -361,7 +361,7 @@ static inline void atl2_irq_disable(struct atl2_adapter *adapter)
     synchronize_irq(adapter->pdev->irq);
 }
 
-static void __atl2_vlan_mode(u32 features, u32 *ctrl)
+static void __atl2_vlan_mode(netdev_features_t features, u32 *ctrl)
 {
         if (features & NETIF_F_HW_VLAN_RX) {
                 /* enable VLAN tag insert/strip */
@@ -372,7 +372,8 @@ static void __atl2_vlan_mode(u32 features, u32 *ctrl)
         }
 }
 
-static void atl2_vlan_mode(struct net_device *netdev, u32 features)
+static void atl2_vlan_mode(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct atl2_adapter *adapter = netdev_priv(netdev);
         u32 ctrl;
@@ -391,7 +392,8 @@ static void atl2_restore_vlan(struct atl2_adapter *adapter)
         atl2_vlan_mode(adapter->netdev, adapter->netdev->features);
 }
 
-static u32 atl2_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t atl2_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -405,9 +407,10 @@ static u32 atl2_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int atl2_set_features(struct net_device *netdev, u32 features)
+static int atl2_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 atl2_vlan_mode(netdev, features);
@@ -2049,10 +2052,12 @@ static void atl2_get_drvinfo(struct net_device *netdev,
 {
         struct atl2_adapter *adapter = netdev_priv(netdev);
 
-        strncpy(drvinfo->driver,  atl2_driver_name, 32);
-        strncpy(drvinfo->version, atl2_driver_version, 32);
-        strncpy(drvinfo->fw_version, "L2", 32);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->driver,  atl2_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, atl2_driver_version,
+                sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "L2", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = 0;
         drvinfo->testinfo_len = 0;
         drvinfo->regdump_len = atl2_get_regs_len(netdev);
diff --git a/drivers/net/ethernet/atheros/atlx/atlx.c b/drivers/net/ethernet/atheros/atlx/atlx.c
index aabcf4b5745a..8ff7411094d5 100644
--- a/drivers/net/ethernet/atheros/atlx/atlx.c
+++ b/drivers/net/ethernet/atheros/atlx/atlx.c
@@ -211,7 +211,7 @@ static void atlx_link_chg_task(struct work_struct *work)
         spin_unlock_irqrestore(&adapter->lock, flags);
 }
 
-static void __atlx_vlan_mode(u32 features, u32 *ctrl)
+static void __atlx_vlan_mode(netdev_features_t features, u32 *ctrl)
 {
         if (features & NETIF_F_HW_VLAN_RX) {
                 /* enable VLAN tag insert/strip */
@@ -222,7 +222,8 @@ static void __atlx_vlan_mode(u32 features, u32 *ctrl)
         }
 }
 
-static void atlx_vlan_mode(struct net_device *netdev, u32 features)
+static void atlx_vlan_mode(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct atlx_adapter *adapter = netdev_priv(netdev);
         unsigned long flags;
@@ -242,7 +243,8 @@ static void atlx_restore_vlan(struct atlx_adapter *adapter)
         atlx_vlan_mode(adapter->netdev, adapter->netdev->features);
 }
 
-static u32 atlx_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t atlx_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -256,9 +258,10 @@ static u32 atlx_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int atlx_set_features(struct net_device *netdev, u32 features)
+static int atlx_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 atlx_vlan_mode(netdev, features);
diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
index 965c7235804d..66f6e7f654c3 100644
--- a/drivers/net/ethernet/broadcom/bnx2.c
+++ b/drivers/net/ethernet/broadcom/bnx2.c
@@ -2064,21 +2064,12 @@ __acquires(&bp->phy_lock)
                 bnx2_read_phy(bp, MII_CTRL1000, &adv1000_reg);
                 adv1000_reg &= PHY_ALL_1000_SPEED;
 
-                if (bp->advertising & ADVERTISED_10baseT_Half)
-                        new_adv_reg |= ADVERTISE_10HALF;
-                if (bp->advertising & ADVERTISED_10baseT_Full)
-                        new_adv_reg |= ADVERTISE_10FULL;
-                if (bp->advertising & ADVERTISED_100baseT_Half)
-                        new_adv_reg |= ADVERTISE_100HALF;
-                if (bp->advertising & ADVERTISED_100baseT_Full)
-                        new_adv_reg |= ADVERTISE_100FULL;
-                if (bp->advertising & ADVERTISED_1000baseT_Full)
-                        new_adv1000_reg |= ADVERTISE_1000FULL;
-
+                new_adv_reg = ethtool_adv_to_mii_100bt(bp->advertising);
                 new_adv_reg |= ADVERTISE_CSMA;
-
                 new_adv_reg |= bnx2_phy_get_pause_adv(bp);
 
+                new_adv1000_reg |= ethtool_adv_to_mii_1000T(bp->advertising);
+
                 if ((adv1000_reg != new_adv1000_reg) ||
                         (adv_reg != new_adv_reg) ||
                         ((bmcr & BMCR_ANENABLE) == 0)) {
@@ -2734,31 +2725,27 @@ bnx2_free_rx_page(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, u16 index)
 }
 
 static inline int
-bnx2_alloc_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, u16 index, gfp_t gfp)
+bnx2_alloc_rx_data(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, u16 index, gfp_t gfp)
 {
-        struct sk_buff *skb;
+        u8 *data;
         struct sw_bd *rx_buf = &rxr->rx_buf_ring[index];
         dma_addr_t mapping;
         struct rx_bd *rxbd = &rxr->rx_desc_ring[RX_RING(index)][RX_IDX(index)];
-        unsigned long align;
 
-        skb = __netdev_alloc_skb(bp->dev, bp->rx_buf_size, gfp);
-        if (skb == NULL) {
+        data = kmalloc(bp->rx_buf_size, gfp);
+        if (!data)
                 return -ENOMEM;
-        }
-
-        if (unlikely((align = (unsigned long) skb->data & (BNX2_RX_ALIGN - 1))))
-                skb_reserve(skb, BNX2_RX_ALIGN - align);
 
-        mapping = dma_map_single(&bp->pdev->dev, skb->data, bp->rx_buf_use_size,
+        mapping = dma_map_single(&bp->pdev->dev,
+                                 get_l2_fhdr(data),
+                                 bp->rx_buf_use_size,
                                  PCI_DMA_FROMDEVICE);
         if (dma_mapping_error(&bp->pdev->dev, mapping)) {
-                dev_kfree_skb(skb);
+                kfree(data);
                 return -EIO;
         }
 
-        rx_buf->skb = skb;
-        rx_buf->desc = (struct l2_fhdr *) skb->data;
+        rx_buf->data = data;
         dma_unmap_addr_set(rx_buf, mapping, mapping);
 
         rxbd->rx_bd_haddr_hi = (u64) mapping >> 32;
@@ -2965,8 +2952,8 @@ bnx2_reuse_rx_skb_pages(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr,
 }
 
 static inline void
-bnx2_reuse_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr,
-                  struct sk_buff *skb, u16 cons, u16 prod)
+bnx2_reuse_rx_data(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr,
+                   u8 *data, u16 cons, u16 prod)
 {
         struct sw_bd *cons_rx_buf, *prod_rx_buf;
         struct rx_bd *cons_bd, *prod_bd;
@@ -2980,8 +2967,7 @@ bnx2_reuse_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr,
 
         rxr->rx_prod_bseq += bp->rx_buf_use_size;
 
-        prod_rx_buf->skb = skb;
-        prod_rx_buf->desc = (struct l2_fhdr *) skb->data;
+        prod_rx_buf->data = data;
 
         if (cons == prod)
                 return;
@@ -2995,33 +2981,39 @@ bnx2_reuse_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr,
         prod_bd->rx_bd_haddr_lo = cons_bd->rx_bd_haddr_lo;
 }
 
-static int
-bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
+static struct sk_buff *
+bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, u8 *data,
             unsigned int len, unsigned int hdr_len, dma_addr_t dma_addr,
             u32 ring_idx)
 {
         int err;
         u16 prod = ring_idx & 0xffff;
+        struct sk_buff *skb;
 
-        err = bnx2_alloc_rx_skb(bp, rxr, prod, GFP_ATOMIC);
+        err = bnx2_alloc_rx_data(bp, rxr, prod, GFP_ATOMIC);
         if (unlikely(err)) {
-                bnx2_reuse_rx_skb(bp, rxr, skb, (u16) (ring_idx >> 16), prod);
+                bnx2_reuse_rx_data(bp, rxr, data, (u16) (ring_idx >> 16), prod);
+error:
                 if (hdr_len) {
                         unsigned int raw_len = len + 4;
                         int pages = PAGE_ALIGN(raw_len - hdr_len) >> PAGE_SHIFT;
 
                         bnx2_reuse_rx_skb_pages(bp, rxr, NULL, pages);
                 }
-                return err;
+                return NULL;
         }
 
-        skb_reserve(skb, BNX2_RX_OFFSET);
         dma_unmap_single(&bp->pdev->dev, dma_addr, bp->rx_buf_use_size,
                          PCI_DMA_FROMDEVICE);
-
+        skb = build_skb(data);
+        if (!skb) {
+                kfree(data);
+                goto error;
+        }
+        skb_reserve(skb, ((u8 *)get_l2_fhdr(data) - data) + BNX2_RX_OFFSET);
         if (hdr_len == 0) {
                 skb_put(skb, len);
-                return 0;
+                return skb;
         } else {
                 unsigned int i, frag_len, frag_size, pages;
                 struct sw_pg *rx_pg;
@@ -3052,7 +3044,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
                                         skb_frag_size_sub(frag, tail);
                                         skb->data_len -= tail;
                                 }
-                                return 0;
+                                return skb;
                         }
                         rx_pg = &rxr->rx_pg_ring[pg_cons];
 
@@ -3074,7 +3066,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
                                 rxr->rx_pg_prod = pg_prod;
                                 bnx2_reuse_rx_skb_pages(bp, rxr, skb,
                                                         pages - i);
-                                return err;
+                                return NULL;
                         }
 
                         dma_unmap_page(&bp->pdev->dev, mapping_old,
@@ -3091,7 +3083,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
                 rxr->rx_pg_prod = pg_prod;
                 rxr->rx_pg_cons = pg_cons;
         }
-        return 0;
+        return skb;
 }
 
 static inline u16
@@ -3130,19 +3122,17 @@ bnx2_rx_int(struct bnx2 *bp, struct bnx2_napi *bnapi, int budget)
                 struct sw_bd *rx_buf, *next_rx_buf;
                 struct sk_buff *skb;
                 dma_addr_t dma_addr;
+                u8 *data;
 
                 sw_ring_cons = RX_RING_IDX(sw_cons);
                 sw_ring_prod = RX_RING_IDX(sw_prod);
 
                 rx_buf = &rxr->rx_buf_ring[sw_ring_cons];
-                skb = rx_buf->skb;
-                prefetchw(skb);
-
-                next_rx_buf =
-                        &rxr->rx_buf_ring[RX_RING_IDX(NEXT_RX_BD(sw_cons))];
-                prefetch(next_rx_buf->desc);
+                data = rx_buf->data;
+                rx_buf->data = NULL;
 
-                rx_buf->skb = NULL;
+                rx_hdr = get_l2_fhdr(data);
+                prefetch(rx_hdr);
 
                 dma_addr = dma_unmap_addr(rx_buf, mapping);
 
@@ -3150,7 +3140,10 @@ bnx2_rx_int(struct bnx2 *bp, struct bnx2_napi *bnapi, int budget)
                         BNX2_RX_OFFSET + BNX2_RX_COPY_THRESH,
                         PCI_DMA_FROMDEVICE);
 
-                rx_hdr = rx_buf->desc;
+                next_rx_buf =
+                        &rxr->rx_buf_ring[RX_RING_IDX(NEXT_RX_BD(sw_cons))];
+                prefetch(get_l2_fhdr(next_rx_buf->data));
+
                 len = rx_hdr->l2_fhdr_pkt_len;
                 status = rx_hdr->l2_fhdr_status;
 
@@ -3169,7 +3162,7 @@ bnx2_rx_int(struct bnx2 *bp, struct bnx2_napi *bnapi, int budget)
                                        L2_FHDR_ERRORS_TOO_SHORT |
                                        L2_FHDR_ERRORS_GIANT_FRAME))) {
 
-                        bnx2_reuse_rx_skb(bp, rxr, skb, sw_ring_cons,
+                        bnx2_reuse_rx_data(bp, rxr, data, sw_ring_cons,
                                           sw_ring_prod);
                         if (pg_ring_used) {
                                 int pages;
@@ -3184,30 +3177,29 @@ bnx2_rx_int(struct bnx2 *bp, struct bnx2_napi *bnapi, int budget)
                 len -= 4;
 
                 if (len <= bp->rx_copy_thresh) {
-                        struct sk_buff *new_skb;
-
-                        new_skb = netdev_alloc_skb(bp->dev, len + 6);
-                        if (new_skb == NULL) {
-                                bnx2_reuse_rx_skb(bp, rxr, skb, sw_ring_cons,
+                        skb = netdev_alloc_skb(bp->dev, len + 6);
+                        if (skb == NULL) {
+                                bnx2_reuse_rx_data(bp, rxr, data, sw_ring_cons,
                                                   sw_ring_prod);
                                 goto next_rx;
                         }
 
                         /* aligned copy */
-                        skb_copy_from_linear_data_offset(skb,
-                                                         BNX2_RX_OFFSET - 6,
-                                      new_skb->data, len + 6);
-                        skb_reserve(new_skb, 6);
-                        skb_put(new_skb, len);
+                        memcpy(skb->data,
+                               (u8 *)rx_hdr + BNX2_RX_OFFSET - 6,
+                               len + 6);
+                        skb_reserve(skb, 6);
+                        skb_put(skb, len);
 
-                        bnx2_reuse_rx_skb(bp, rxr, skb,
+                        bnx2_reuse_rx_data(bp, rxr, data,
                                 sw_ring_cons, sw_ring_prod);
 
-                        skb = new_skb;
-                } else if (unlikely(bnx2_rx_skb(bp, rxr, skb, len, hdr_len,
-                           dma_addr, (sw_ring_cons << 16) | sw_ring_prod)))
-                        goto next_rx;
-
+                } else {
+                        skb = bnx2_rx_skb(bp, rxr, data, len, hdr_len, dma_addr,
+                                          (sw_ring_cons << 16) | sw_ring_prod);
+                        if (!skb)
+                                goto next_rx;
+                }
                 if ((status & L2_FHDR_STATUS_L2_VLAN_TAG) &&
                     !(bp->rx_mode & BNX2_EMAC_RX_MODE_KEEP_VLAN_TAG))
                         __vlan_hwaccel_put_tag(skb, rx_hdr->l2_fhdr_vlan_tag);
@@ -5234,7 +5226,7 @@ bnx2_init_rx_ring(struct bnx2 *bp, int ring_num)
 
         ring_prod = prod = rxr->rx_prod;
         for (i = 0; i < bp->rx_ring_size; i++) {
-                if (bnx2_alloc_rx_skb(bp, rxr, ring_prod, GFP_KERNEL) < 0) {
+                if (bnx2_alloc_rx_data(bp, rxr, ring_prod, GFP_KERNEL) < 0) {
                         netdev_warn(bp->dev, "init'ed rx ring %d with %d/%d skbs only\n",
                                     ring_num, i, bp->rx_ring_size);
                         break;
@@ -5329,7 +5321,7 @@ bnx2_set_rx_ring_size(struct bnx2 *bp, u32 size)
         rx_size = bp->dev->mtu + ETH_HLEN + BNX2_RX_OFFSET + 8;
 
         rx_space = SKB_DATA_ALIGN(rx_size + BNX2_RX_ALIGN) + NET_SKB_PAD +
-                sizeof(struct skb_shared_info);
+                SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
 
         bp->rx_copy_thresh = BNX2_RX_COPY_THRESH;
         bp->rx_pg_ring_size = 0;
@@ -5351,8 +5343,9 @@ bnx2_set_rx_ring_size(struct bnx2 *bp, u32 size)
         }
 
         bp->rx_buf_use_size = rx_size;
-        /* hw alignment */
-        bp->rx_buf_size = bp->rx_buf_use_size + BNX2_RX_ALIGN;
+        /* hw alignment + build_skb() overhead*/
+        bp->rx_buf_size = SKB_DATA_ALIGN(bp->rx_buf_use_size + BNX2_RX_ALIGN) +
+                NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
         bp->rx_jumbo_thresh = rx_size - BNX2_RX_OFFSET;
         bp->rx_ring_size = size;
         bp->rx_max_ring = bnx2_find_max_ring(size, MAX_RX_RINGS);
@@ -5418,9 +5411,9 @@ bnx2_free_rx_skbs(struct bnx2 *bp)
 
                 for (j = 0; j < bp->rx_max_ring_idx; j++) {
                         struct sw_bd *rx_buf = &rxr->rx_buf_ring[j];
-                        struct sk_buff *skb = rx_buf->skb;
+                        u8 *data = rx_buf->data;
 
-                        if (skb == NULL)
+                        if (data == NULL)
                                 continue;
 
                         dma_unmap_single(&bp->pdev->dev,
@@ -5428,9 +5421,9 @@ bnx2_free_rx_skbs(struct bnx2 *bp)
                                          bp->rx_buf_use_size,
                                          PCI_DMA_FROMDEVICE);
 
-                        rx_buf->skb = NULL;
+                        rx_buf->data = NULL;
 
-                        dev_kfree_skb(skb);
+                        kfree(data);
                 }
                 for (j = 0; j < bp->rx_max_pg_ring_idx; j++)
                         bnx2_free_rx_page(bp, rxr, j);
@@ -5736,7 +5729,8 @@ static int
 bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
 {
         unsigned int pkt_size, num_pkts, i;
-        struct sk_buff *skb, *rx_skb;
+        struct sk_buff *skb;
+        u8 *data;
         unsigned char *packet;
         u16 rx_start_idx, rx_idx;
         dma_addr_t map;
@@ -5828,14 +5822,14 @@ bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
         }
 
         rx_buf = &rxr->rx_buf_ring[rx_start_idx];
-        rx_skb = rx_buf->skb;
+        data = rx_buf->data;
 
-        rx_hdr = rx_buf->desc;
-        skb_reserve(rx_skb, BNX2_RX_OFFSET);
+        rx_hdr = get_l2_fhdr(data);
+        data = (u8 *)rx_hdr + BNX2_RX_OFFSET;
 
         dma_sync_single_for_cpu(&bp->pdev->dev,
                 dma_unmap_addr(rx_buf, mapping),
-                bp->rx_buf_size, PCI_DMA_FROMDEVICE);
+                bp->rx_buf_use_size, PCI_DMA_FROMDEVICE);
 
         if (rx_hdr->l2_fhdr_status &
                 (L2_FHDR_ERRORS_BAD_CRC |
@@ -5852,7 +5846,7 @@ bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
         }
 
         for (i = 14; i < pkt_size; i++) {
-                if (*(rx_skb->data + i) != (unsigned char) (i & 0xff)) {
+                if (*(data + i) != (unsigned char) (i & 0xff)) {
                         goto loopback_test_done;
                 }
         }
@@ -6873,10 +6867,10 @@ bnx2_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct bnx2 *bp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_MODULE_NAME);
-        strcpy(info->version, DRV_MODULE_VERSION);
-        strcpy(info->bus_info, pci_name(bp->pdev));
-        strcpy(info->fw_version, bp->fw_version);
+        strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(bp->pdev), sizeof(info->bus_info));
+        strlcpy(info->fw_version, bp->fw_version, sizeof(info->fw_version));
 }
 
 #define BNX2_REGDUMP_LEN                (32 * 1024)
@@ -7571,8 +7565,8 @@ bnx2_set_phys_id(struct net_device *dev, enum ethtool_phys_id_state state)
         return 0;
 }
 
-static u32
-bnx2_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t
+bnx2_fix_features(struct net_device *dev, netdev_features_t features)
 {
         struct bnx2 *bp = netdev_priv(dev);
 
@@ -7583,7 +7577,7 @@ bnx2_fix_features(struct net_device *dev, u32 features)
 }
 
 static int
-bnx2_set_features(struct net_device *dev, u32 features)
+bnx2_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct bnx2 *bp = netdev_priv(dev);
 
diff --git a/drivers/net/ethernet/broadcom/bnx2.h b/drivers/net/ethernet/broadcom/bnx2.h
index 99d31a7d6aaa..1db2d51ba3f1 100644
--- a/drivers/net/ethernet/broadcom/bnx2.h
+++ b/drivers/net/ethernet/broadcom/bnx2.h
@@ -6563,12 +6563,25 @@ struct l2_fhdr {
 #define MB_TX_CID_ADDR  MB_GET_CID_ADDR(TX_CID)
 #define MB_RX_CID_ADDR  MB_GET_CID_ADDR(RX_CID)
 
+/*
+ * This driver uses new build_skb() API :
+ * RX ring buffer contains pointer to kmalloc() data only,
+ * skb are built only after Hardware filled the frame.
+ */
 struct sw_bd {
-        struct sk_buff          *skb;
-        struct l2_fhdr          *desc;
+        u8                      *data;
         DEFINE_DMA_UNMAP_ADDR(mapping);
 };
 
+/* Its faster to compute this from data than storing it in sw_bd
+ * (less cache misses)
+ */
+static inline struct l2_fhdr *get_l2_fhdr(u8 *data)
+{
+        return (struct l2_fhdr *)(PTR_ALIGN(data, BNX2_RX_ALIGN) + NET_SKB_PAD);
+}
+
+
 struct sw_pg {
         struct page             *page;
         DEFINE_DMA_UNMAP_ADDR(mapping);
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index aec7212ac983..0f7b7a463eba 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
@@ -23,8 +23,8 @@
  * (you will need to reboot afterwards) */
 /* #define BNX2X_STOP_ON_ERROR */
 
-#define DRV_MODULE_VERSION      "1.70.30-0"
-#define DRV_MODULE_RELDATE      "2011/10/25"
+#define DRV_MODULE_VERSION      "1.70.35-0"
+#define DRV_MODULE_RELDATE      "2011/11/10"
 #define BNX2X_BC_VER            0x040200
 
 #if defined(CONFIG_DCB)
@@ -293,8 +293,13 @@ enum {
 #define FCOE_TXQ_IDX(bp)        (MAX_ETH_TXQ_IDX(bp))
 
 /* fast path */
+/*
+ * This driver uses new build_skb() API :
+ * RX ring buffer contains pointer to kmalloc() data only,
+ * skb are built only after Hardware filled the frame.
+ */
 struct sw_rx_bd {
-        struct sk_buff  *skb;
+        u8              *data;
         DEFINE_DMA_UNMAP_ADDR(mapping);
 };
 
@@ -411,8 +416,7 @@ union db_prod {
 
 
 /* Number of u64 elements in SGE mask array */
-#define RX_SGE_MASK_LEN                 ((NUM_RX_SGE_PAGES * RX_SGE_CNT) / \
-                                         BIT_VEC64_ELEM_SZ)
+#define RX_SGE_MASK_LEN                 (NUM_RX_SGE / BIT_VEC64_ELEM_SZ)
 #define RX_SGE_MASK_LEN_MASK            (RX_SGE_MASK_LEN - 1)
 #define NEXT_SGE_MASK_ELEM(el)          (((el) + 1) & RX_SGE_MASK_LEN_MASK)
 
@@ -425,8 +429,8 @@ union host_hc_status_block {
 
 struct bnx2x_agg_info {
         /*
-         * First aggregation buffer is an skb, the following - are pages.
-         * We will preallocate the skbs for each aggregation when
+         * First aggregation buffer is a data buffer, the following - are pages.
+         * We will preallocate the data buffer for each aggregation when
          * we open the interface and will replace the BD at the consumer
          * with this one when we receive the TPA_START CQE in order to
          * keep the Rx BD ring consistent.
@@ -440,6 +444,7 @@ struct bnx2x_agg_info {
         u16                     parsing_flags;
         u16                     vlan_tag;
         u16                     len_on_bd;
+        u32                     rxhash;
 };
 
 #define Q_STATS_OFFSET32(stat_name) \
@@ -507,6 +512,7 @@ struct bnx2x_fastpath {
         __le16                  fp_hc_idx;
 
         u8                      index;          /* number in fp array */
+        u8                      rx_queue;       /* index for skb_record */
         u8                      cl_id;          /* eth client id */
         u8                      cl_qzone_id;
         u8                      fw_sb_id;       /* status block number in FW */
@@ -1141,6 +1147,7 @@ struct bnx2x_fw_stats_data {
 enum {
         BNX2X_SP_RTNL_SETUP_TC,
         BNX2X_SP_RTNL_TX_TIMEOUT,
+        BNX2X_SP_RTNL_FAN_FAILURE,
 };
 
 
@@ -1186,10 +1193,20 @@ struct bnx2x {
 #define ETH_MAX_JUMBO_PACKET_SIZE       9600
 
         /* Max supported alignment is 256 (8 shift) */
-#define BNX2X_RX_ALIGN_SHIFT            ((L1_CACHE_SHIFT < 8) ? \
-                                         L1_CACHE_SHIFT : 8)
-        /* FW use 2 Cache lines Alignment for start packet and size  */
-#define BNX2X_FW_RX_ALIGN               (2 << BNX2X_RX_ALIGN_SHIFT)
+#define BNX2X_RX_ALIGN_SHIFT            min(8, L1_CACHE_SHIFT)
+
+        /* FW uses 2 Cache lines Alignment for start packet and size
+         *
+         * We assume skb_build() uses sizeof(struct skb_shared_info) bytes
+         * at the end of skb->data, to avoid wasting a full cache line.
+         * This reduces memory use (skb->truesize).
+         */
+#define BNX2X_FW_RX_ALIGN_START (1UL << BNX2X_RX_ALIGN_SHIFT)
+
+#define BNX2X_FW_RX_ALIGN_END                                   \
+        max(1UL << BNX2X_RX_ALIGN_SHIFT,                        \
+            SKB_DATA_ALIGN(sizeof(struct skb_shared_info)))
+
 #define BNX2X_PXP_DRAM_ALIGN            (BNX2X_RX_ALIGN_SHIFT - 5)
 
         struct host_sp_status_block *def_status_blk;
@@ -1984,13 +2001,6 @@ static inline u32 reg_poll(struct bnx2x *bp, u32 reg, u32 expected, int ms,
 #define HW_PRTY_ASSERT_SET_4 (AEU_INPUTS_ATTN_BITS_PGLUE_PARITY_ERROR | \
                               AEU_INPUTS_ATTN_BITS_ATC_PARITY_ERROR)
 
-#define RSS_FLAGS(bp) \
-                (TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV4_CAPABILITY | \
-                 TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV4_TCP_CAPABILITY | \
-                 TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV6_CAPABILITY | \
-                 TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV6_TCP_CAPABILITY | \
-                 (bp->multi_mode << \
-                  TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_MODE_SHIFT))
 #define MULTI_MASK                      0x7f
 
 
@@ -2055,6 +2065,8 @@ static inline u32 reg_poll(struct bnx2x *bp, u32 reg, u32 expected, int ms,
 #define BNX2X_VPD_LEN                   128
 #define VENDOR_ID_LEN                   4
 
+int bnx2x_close(struct net_device *dev);
+
 /* Congestion management fairness mode */
 #define CMNG_FNS_NONE           0
 #define CMNG_FNS_MINMAX         1
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 580b44edb066..8336c784db49 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -79,19 +79,21 @@ static inline void bnx2x_bz_fp(struct bnx2x *bp, int index)
  * @to:         destination FP index
  *
  * Makes sure the contents of the bp->fp[to].napi is kept
- * intact.
+ * intact. This is done by first copying the napi struct from
+ * the target to the source, and then mem copying the entire
+ * source onto the target
  */
 static inline void bnx2x_move_fp(struct bnx2x *bp, int from, int to)
 {
         struct bnx2x_fastpath *from_fp = &bp->fp[from];
         struct bnx2x_fastpath *to_fp = &bp->fp[to];
-        struct napi_struct orig_napi = to_fp->napi;
+
+        /* Copy the NAPI object as it has been already initialized */
+        from_fp->napi = to_fp->napi;
+
         /* Move bnx2x_fastpath contents */
         memcpy(to_fp, from_fp, sizeof(*to_fp));
         to_fp->index = to;
-
-        /* Restore the NAPI object as it has been already initialized */
-        to_fp->napi = orig_napi;
 }
 
 int load_count[2][3] = { {0} }; /* per-path: 0-common, 1-port0, 2-port1 */
@@ -292,8 +294,21 @@ static void bnx2x_update_sge_prod(struct bnx2x_fastpath *fp,
            fp->last_max_sge, fp->rx_sge_prod);
 }
 
+/* Set Toeplitz hash value in the skb using the value from the
+ * CQE (calculated by HW).
+ */
+static u32 bnx2x_get_rxhash(const struct bnx2x *bp,
+                            const struct eth_fast_path_rx_cqe *cqe)
+{
+        /* Set Toeplitz hash from CQE */
+        if ((bp->dev->features & NETIF_F_RXHASH) &&
+            (cqe->status_flags & ETH_FAST_PATH_RX_CQE_RSS_HASH_FLG))
+                return le32_to_cpu(cqe->rss_hash_result);
+        return 0;
+}
+
 static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
-                            struct sk_buff *skb, u16 cons, u16 prod,
+                            u16 cons, u16 prod,
                             struct eth_fast_path_rx_cqe *cqe)
 {
         struct bnx2x *bp = fp->bp;
@@ -308,9 +323,9 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
         if (tpa_info->tpa_state != BNX2X_TPA_STOP)
                 BNX2X_ERR("start of bin not in stop [%d]\n", queue);
 
-        /* Try to map an empty skb from the aggregation info  */
+        /* Try to map an empty data buffer from the aggregation info  */
         mapping = dma_map_single(&bp->pdev->dev,
-                                 first_buf->skb->data,
+                                 first_buf->data + NET_SKB_PAD,
                                  fp->rx_buf_size, DMA_FROM_DEVICE);
         /*
          *  ...if it fails - move the skb from the consumer to the producer
@@ -320,15 +335,15 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
 
         if (unlikely(dma_mapping_error(&bp->pdev->dev, mapping))) {
                 /* Move the BD from the consumer to the producer */
-                bnx2x_reuse_rx_skb(fp, cons, prod);
+                bnx2x_reuse_rx_data(fp, cons, prod);
                 tpa_info->tpa_state = BNX2X_TPA_ERROR;
                 return;
         }
 
-        /* move empty skb from pool to prod */
-        prod_rx_buf->skb = first_buf->skb;
+        /* move empty data from pool to prod */
+        prod_rx_buf->data = first_buf->data;
         dma_unmap_addr_set(prod_rx_buf, mapping, mapping);
-        /* point prod_bd to new skb */
+        /* point prod_bd to new data */
         prod_bd->addr_hi = cpu_to_le32(U64_HI(mapping));
         prod_bd->addr_lo = cpu_to_le32(U64_LO(mapping));
 
@@ -342,6 +357,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
         tpa_info->tpa_state = BNX2X_TPA_START;
         tpa_info->len_on_bd = le16_to_cpu(cqe->len_on_bd);
         tpa_info->placement_offset = cqe->placement_offset;
+        tpa_info->rxhash = bnx2x_get_rxhash(bp, cqe);
 
 #ifdef BNX2X_STOP_ON_ERROR
         fp->tpa_queue_used |= (1 << queue);
@@ -469,11 +485,12 @@ static void bnx2x_tpa_stop(struct bnx2x *bp, struct bnx2x_fastpath *fp,
 {
         struct bnx2x_agg_info *tpa_info = &fp->tpa_info[queue];
         struct sw_rx_bd *rx_buf = &tpa_info->first_buf;
-        u8 pad = tpa_info->placement_offset;
+        u32 pad = tpa_info->placement_offset;
         u16 len = tpa_info->len_on_bd;
-        struct sk_buff *skb = rx_buf->skb;
+        struct sk_buff *skb = NULL;
+        u8 *data = rx_buf->data;
         /* alloc new skb */
-        struct sk_buff *new_skb;
+        u8 *new_data;
         u8 old_tpa_state = tpa_info->tpa_state;
 
         tpa_info->tpa_state = BNX2X_TPA_STOP;
@@ -484,18 +501,18 @@ static void bnx2x_tpa_stop(struct bnx2x *bp, struct bnx2x_fastpath *fp,
         if (old_tpa_state == BNX2X_TPA_ERROR)
                 goto drop;
 
-        /* Try to allocate the new skb */
-        new_skb = netdev_alloc_skb(bp->dev, fp->rx_buf_size);
+        /* Try to allocate the new data */
+        new_data = kmalloc(fp->rx_buf_size + NET_SKB_PAD, GFP_ATOMIC);
 
         /* Unmap skb in the pool anyway, as we are going to change
            pool entry status to BNX2X_TPA_STOP even if new skb allocation
            fails. */
         dma_unmap_single(&bp->pdev->dev, dma_unmap_addr(rx_buf, mapping),
                          fp->rx_buf_size, DMA_FROM_DEVICE);
+        if (likely(new_data))
+                skb = build_skb(data);
 
-        if (likely(new_skb)) {
-                prefetch(skb);
-                prefetch(((char *)(skb)) + L1_CACHE_BYTES);
+        if (likely(skb)) {
 
 #ifdef BNX2X_STOP_ON_ERROR
                 if (pad + len > fp->rx_buf_size) {
@@ -507,8 +524,9 @@ static void bnx2x_tpa_stop(struct bnx2x *bp, struct bnx2x_fastpath *fp,
                 }
 #endif
 
-                skb_reserve(skb, pad);
+                skb_reserve(skb, pad + NET_SKB_PAD);
                 skb_put(skb, len);
+                skb->rxhash = tpa_info->rxhash;
 
                 skb->protocol = eth_type_trans(skb, bp->dev);
                 skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -524,8 +542,8 @@ static void bnx2x_tpa_stop(struct bnx2x *bp, struct bnx2x_fastpath *fp,
                 }
 
 
-                /* put new skb in bin */
-                rx_buf->skb = new_skb;
+                /* put new data in bin */
+                rx_buf->data = new_data;
 
                 return;
         }
@@ -537,19 +555,6 @@ drop:
         fp->eth_q_stats.rx_skb_alloc_failed++;
 }
 
-/* Set Toeplitz hash value in the skb using the value from the
- * CQE (calculated by HW).
- */
-static inline void bnx2x_set_skb_rxhash(struct bnx2x *bp, union eth_rx_cqe *cqe,
-                                        struct sk_buff *skb)
-{
-        /* Set Toeplitz hash from CQE */
-        if ((bp->dev->features & NETIF_F_RXHASH) &&
-            (cqe->fast_path_cqe.status_flags &
-             ETH_FAST_PATH_RX_CQE_RSS_HASH_FLG))
-                skb->rxhash =
-                le32_to_cpu(cqe->fast_path_cqe.rss_hash_result);
-}
 
 int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget)
 {
@@ -592,6 +597,7 @@ int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget)
                 u8 cqe_fp_flags;
                 enum eth_rx_cqe_type cqe_fp_type;
                 u16 len, pad;
+                u8 *data;
 
 #ifdef BNX2X_STOP_ON_ERROR
                 if (unlikely(bp->panic))
@@ -602,13 +608,6 @@ int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget)
                 bd_prod = RX_BD(bd_prod);
                 bd_cons = RX_BD(bd_cons);
 
-                /* Prefetch the page containing the BD descriptor
-                   at producer's index. It will be needed when new skb is
-                   allocated */
-                prefetch((void *)(PAGE_ALIGN((unsigned long)
-                                             (&fp->rx_desc_ring[bd_prod])) -
-                                  PAGE_SIZE + 1));
-
                 cqe = &fp->rx_comp_ring[comp_ring_cons];
                 cqe_fp = &cqe->fast_path_cqe;
                 cqe_fp_flags = cqe_fp->type_error_flags;
@@ -624,125 +623,110 @@ int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget)
                 if (unlikely(CQE_TYPE_SLOW(cqe_fp_type))) {
                         bnx2x_sp_event(fp, cqe);
                         goto next_cqe;
+                }
+                rx_buf = &fp->rx_buf_ring[bd_cons];
+                data = rx_buf->data;
 
-                /* this is an rx packet */
-                } else {
-                        rx_buf = &fp->rx_buf_ring[bd_cons];
-                        skb = rx_buf->skb;
-                        prefetch(skb);
-
-                        if (!CQE_TYPE_FAST(cqe_fp_type)) {
+                if (!CQE_TYPE_FAST(cqe_fp_type)) {
 #ifdef BNX2X_STOP_ON_ERROR
-                                /* sanity check */
-                                if (fp->disable_tpa &&
-                                    (CQE_TYPE_START(cqe_fp_type) ||
-                                     CQE_TYPE_STOP(cqe_fp_type)))
-                                        BNX2X_ERR("START/STOP packet while "
-                                                  "disable_tpa type %x\n",
-                                                  CQE_TYPE(cqe_fp_type));
+                        /* sanity check */
+                        if (fp->disable_tpa &&
+                            (CQE_TYPE_START(cqe_fp_type) ||
+                             CQE_TYPE_STOP(cqe_fp_type)))
+                                BNX2X_ERR("START/STOP packet while "
+                                          "disable_tpa type %x\n",
+                                          CQE_TYPE(cqe_fp_type));
 #endif
 
-                                if (CQE_TYPE_START(cqe_fp_type)) {
-                                        u16 queue = cqe_fp->queue_index;
-                                        DP(NETIF_MSG_RX_STATUS,
-                                           "calling tpa_start on queue %d\n",
-                                           queue);
-
-                                        bnx2x_tpa_start(fp, queue, skb,
-                                                        bd_cons, bd_prod,
-                                                        cqe_fp);
-
-                                        /* Set Toeplitz hash for LRO skb */
-                                        bnx2x_set_skb_rxhash(bp, cqe, skb);
+                        if (CQE_TYPE_START(cqe_fp_type)) {
+                                u16 queue = cqe_fp->queue_index;
+                                DP(NETIF_MSG_RX_STATUS,
+                                   "calling tpa_start on queue %d\n",
+                                   queue);
 
-                                        goto next_rx;
-
-                                } else {
-                                        u16 queue =
-                                                cqe->end_agg_cqe.queue_index;
-                                        DP(NETIF_MSG_RX_STATUS,
-                                           "calling tpa_stop on queue %d\n",
-                                           queue);
-
-                                        bnx2x_tpa_stop(bp, fp, queue,
-                                                       &cqe->end_agg_cqe,
-                                                       comp_ring_cons);
+                                bnx2x_tpa_start(fp, queue,
+                                                bd_cons, bd_prod,
+                                                cqe_fp);
+                                goto next_rx;
+                        } else {
+                                u16 queue =
+                                        cqe->end_agg_cqe.queue_index;
+                                DP(NETIF_MSG_RX_STATUS,
+                                   "calling tpa_stop on queue %d\n",
+                                   queue);
+
+                                bnx2x_tpa_stop(bp, fp, queue,
+                                               &cqe->end_agg_cqe,
+                                               comp_ring_cons);
 #ifdef BNX2X_STOP_ON_ERROR
-                                        if (bp->panic)
-                                                return 0;
+                                if (bp->panic)
+                                        return 0;
 #endif
 
-                                        bnx2x_update_sge_prod(fp, cqe_fp);
-                                        goto next_cqe;
-                                }
+                                bnx2x_update_sge_prod(fp, cqe_fp);
+                                goto next_cqe;
                         }
-                        /* non TPA */
-                        len = le16_to_cpu(cqe_fp->pkt_len);
-                        pad = cqe_fp->placement_offset;
-                        dma_sync_single_for_cpu(&bp->pdev->dev,
+                }
+                /* non TPA */
+                len = le16_to_cpu(cqe_fp->pkt_len);
+                pad = cqe_fp->placement_offset;
+                dma_sync_single_for_cpu(&bp->pdev->dev,
                                         dma_unmap_addr(rx_buf, mapping),
-                                                       pad + RX_COPY_THRESH,
-                                                       DMA_FROM_DEVICE);
-                        prefetch(((char *)(skb)) + L1_CACHE_BYTES);
+                                        pad + RX_COPY_THRESH,
+                                        DMA_FROM_DEVICE);
+                pad += NET_SKB_PAD;
+                prefetch(data + pad); /* speedup eth_type_trans() */
+                /* is this an error packet? */
+                if (unlikely(cqe_fp_flags & ETH_RX_ERROR_FALGS)) {
+                        DP(NETIF_MSG_RX_ERR,
+                           "ERROR  flags %x  rx packet %u\n",
+                           cqe_fp_flags, sw_comp_cons);
+                        fp->eth_q_stats.rx_err_discard_pkt++;
+                        goto reuse_rx;
+                }
 
-                        /* is this an error packet? */
-                        if (unlikely(cqe_fp_flags & ETH_RX_ERROR_FALGS)) {
+                /* Since we don't have a jumbo ring
+                 * copy small packets if mtu > 1500
+                 */
+                if ((bp->dev->mtu > ETH_MAX_PACKET_SIZE) &&
+                    (len <= RX_COPY_THRESH)) {
+                        skb = netdev_alloc_skb_ip_align(bp->dev, len);
+                        if (skb == NULL) {
                                 DP(NETIF_MSG_RX_ERR,
-                                   "ERROR  flags %x  rx packet %u\n",
-                                   cqe_fp_flags, sw_comp_cons);
-                                fp->eth_q_stats.rx_err_discard_pkt++;
+                                   "ERROR  packet dropped because of alloc failure\n");
+                                fp->eth_q_stats.rx_skb_alloc_failed++;
                                 goto reuse_rx;
                         }
-
-                        /* Since we don't have a jumbo ring
-                         * copy small packets if mtu > 1500
-                         */
-                        if ((bp->dev->mtu > ETH_MAX_PACKET_SIZE) &&
-                            (len <= RX_COPY_THRESH)) {
-                                struct sk_buff *new_skb;
-
-                                new_skb = netdev_alloc_skb(bp->dev, len + pad);
-                                if (new_skb == NULL) {
-                                        DP(NETIF_MSG_RX_ERR,
-                                           "ERROR  packet dropped "
-                                           "because of alloc failure\n");
-                                        fp->eth_q_stats.rx_skb_alloc_failed++;
-                                        goto reuse_rx;
-                                }
-
-                                /* aligned copy */
-                                skb_copy_from_linear_data_offset(skb, pad,
-                                                    new_skb->data + pad, len);
-                                skb_reserve(new_skb, pad);
-                                skb_put(new_skb, len);
-
-                                bnx2x_reuse_rx_skb(fp, bd_cons, bd_prod);
-
-                                skb = new_skb;
-
-                        } else
-                        if (likely(bnx2x_alloc_rx_skb(bp, fp, bd_prod) == 0)) {
+                        memcpy(skb->data, data + pad, len);
+                        bnx2x_reuse_rx_data(fp, bd_cons, bd_prod);
+                } else {
+                        if (likely(bnx2x_alloc_rx_data(bp, fp, bd_prod) == 0)) {
                                 dma_unmap_single(&bp->pdev->dev,
-                                        dma_unmap_addr(rx_buf, mapping),
+                                                 dma_unmap_addr(rx_buf, mapping),
                                                  fp->rx_buf_size,
                                                  DMA_FROM_DEVICE);
+                                skb = build_skb(data);
+                                if (unlikely(!skb)) {
+                                        kfree(data);
+                                        fp->eth_q_stats.rx_skb_alloc_failed++;
+                                        goto next_rx;
+                                }
                                 skb_reserve(skb, pad);
-                                skb_put(skb, len);
-
                         } else {
                                 DP(NETIF_MSG_RX_ERR,
                                    "ERROR  packet dropped because "
                                    "of alloc failure\n");
                                 fp->eth_q_stats.rx_skb_alloc_failed++;
 reuse_rx:
-                                bnx2x_reuse_rx_skb(fp, bd_cons, bd_prod);
+                                bnx2x_reuse_rx_data(fp, bd_cons, bd_prod);
                                 goto next_rx;
                         }
 
+                        skb_put(skb, len);
                         skb->protocol = eth_type_trans(skb, bp->dev);
 
                         /* Set Toeplitz hash for a none-LRO skb */
-                        bnx2x_set_skb_rxhash(bp, cqe, skb);
+                        skb->rxhash = bnx2x_get_rxhash(bp, cqe_fp);
 
                         skb_checksum_none_assert(skb);
 
@@ -755,7 +739,7 @@ reuse_rx:
                         }
                 }
 
-                skb_record_rx_queue(skb, fp->index);
+                skb_record_rx_queue(skb, fp->rx_queue);
 
                 if (le16_to_cpu(cqe_fp->pars_flags.flags) &
                     PARSING_FLAGS_VLAN)
@@ -765,7 +749,7 @@ reuse_rx:
 
 
 next_rx:
-                rx_buf->skb = NULL;
+                rx_buf->data = NULL;
 
                 bd_cons = NEXT_RX_IDX(bd_cons);
                 bd_prod = NEXT_RX_IDX(bd_prod);
@@ -1011,9 +995,9 @@ void bnx2x_init_rx_rings(struct bnx2x *bp)
                                 struct sw_rx_bd *first_buf =
                                         &tpa_info->first_buf;
 
-                                first_buf->skb = netdev_alloc_skb(bp->dev,
-                                                       fp->rx_buf_size);
-                                if (!first_buf->skb) {
+                                first_buf->data = kmalloc(fp->rx_buf_size + NET_SKB_PAD,
+                                                          GFP_ATOMIC);
+                                if (!first_buf->data) {
                                         BNX2X_ERR("Failed to allocate TPA "
                                                   "skb pool for queue[%d] - "
                                                   "disabling TPA on this "
@@ -1094,13 +1078,11 @@ static void bnx2x_free_tx_skbs(struct bnx2x *bp)
                 for_each_cos_in_tx_queue(fp, cos) {
                         struct bnx2x_fp_txdata *txdata = &fp->txdata[cos];
 
-                        u16 bd_cons = txdata->tx_bd_cons;
                         u16 sw_prod = txdata->tx_pkt_prod;
                         u16 sw_cons = txdata->tx_pkt_cons;
 
                         while (sw_cons != sw_prod) {
-                                bd_cons = bnx2x_free_tx_pkt(bp, txdata,
-                                                            TX_BD(sw_cons));
+                                bnx2x_free_tx_pkt(bp, txdata, TX_BD(sw_cons));
                                 sw_cons++;
                         }
                 }
@@ -1118,16 +1100,16 @@ static void bnx2x_free_rx_bds(struct bnx2x_fastpath *fp)
 
         for (i = 0; i < NUM_RX_BD; i++) {
                 struct sw_rx_bd *rx_buf = &fp->rx_buf_ring[i];
-                struct sk_buff *skb = rx_buf->skb;
+                u8 *data = rx_buf->data;
 
-                if (skb == NULL)
+                if (data == NULL)
                         continue;
                 dma_unmap_single(&bp->pdev->dev,
                                  dma_unmap_addr(rx_buf, mapping),
                                  fp->rx_buf_size, DMA_FROM_DEVICE);
 
-                rx_buf->skb = NULL;
-                dev_kfree_skb(skb);
+                rx_buf->data = NULL;
+                kfree(data);
         }
 }
 
@@ -1509,6 +1491,7 @@ static inline void bnx2x_set_rx_buf_size(struct bnx2x *bp)
 
         for_each_queue(bp, i) {
                 struct bnx2x_fastpath *fp = &bp->fp[i];
+                u32 mtu;
 
                 /* Always use a mini-jumbo MTU for the FCoE L2 ring */
                 if (IS_FCOE_IDX(i))
@@ -1518,13 +1501,15 @@ static inline void bnx2x_set_rx_buf_size(struct bnx2x *bp)
                          * IP_HEADER_ALIGNMENT_PADDING to prevent a buffer
                          * overrun attack.
                          */
-                        fp->rx_buf_size =
-                                BNX2X_FCOE_MINI_JUMBO_MTU + ETH_OVREHEAD +
-                                BNX2X_FW_RX_ALIGN + IP_HEADER_ALIGNMENT_PADDING;
+                        mtu = BNX2X_FCOE_MINI_JUMBO_MTU;
                 else
-                        fp->rx_buf_size =
-                                bp->dev->mtu + ETH_OVREHEAD +
-                                BNX2X_FW_RX_ALIGN + IP_HEADER_ALIGNMENT_PADDING;
+                        mtu = bp->dev->mtu;
+                fp->rx_buf_size = BNX2X_FW_RX_ALIGN_START +
+                                  IP_HEADER_ALIGNMENT_PADDING +
+                                  ETH_OVREHEAD +
+                                  mtu +
+                                  BNX2X_FW_RX_ALIGN_END;
+                /* Note : rx_buf_size doesnt take into account NET_SKB_PAD */
         }
 }
 
@@ -1929,13 +1914,17 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
                 break;
         }
 
-        if (!bp->port.pmf)
+        if (bp->port.pmf)
+                bnx2x_update_drv_flags(bp, DRV_FLAGS_DCB_CONFIGURED, 0);
+        else
                 bnx2x__link_status_update(bp);
 
         /* start the timer */
         mod_timer(&bp->timer, jiffies + bp->current_interval);
 
 #ifdef BCM_CNIC
+        /* re-read iscsi info */
+        bnx2x_get_iscsi_info(bp);
         bnx2x_setup_cnic_irq_info(bp);
         if (bp->state == BNX2X_STATE_OPEN)
                 bnx2x_cnic_notify(bp, CNIC_CTL_START_CMD);
@@ -3409,7 +3398,8 @@ int bnx2x_change_mtu(struct net_device *dev, int new_mtu)
         return bnx2x_reload_if_running(dev);
 }
 
-u32 bnx2x_fix_features(struct net_device *dev, u32 features)
+netdev_features_t bnx2x_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct bnx2x *bp = netdev_priv(dev);
 
@@ -3420,7 +3410,7 @@ u32 bnx2x_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-int bnx2x_set_features(struct net_device *dev, u32 features)
+int bnx2x_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct bnx2x *bp = netdev_priv(dev);
         u32 flags = bp->flags;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index 283d663da180..80c5ed08e419 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
@@ -533,8 +533,9 @@ int bnx2x_change_mtu(struct net_device *dev, int new_mtu);
  */
 int bnx2x_fcoe_get_wwn(struct net_device *dev, u64 *wwn, int type);
 #endif
-u32 bnx2x_fix_features(struct net_device *dev, u32 features);
-int bnx2x_set_features(struct net_device *dev, u32 features);
+netdev_features_t bnx2x_fix_features(struct net_device *dev,
+        netdev_features_t features);
+int bnx2x_set_features(struct net_device *dev, netdev_features_t features);
 
 /**
  * bnx2x_tx_timeout - tx timeout netdev callback
@@ -874,8 +875,7 @@ static inline void bnx2x_clear_sge_mask_next_elems(struct bnx2x_fastpath *fp)
 static inline void bnx2x_init_sge_ring_bit_mask(struct bnx2x_fastpath *fp)
 {
         /* Set the mask to all 1-s: it's faster to compare to 0 than to 0xf-s */
-        memset(fp->sge_mask, 0xff,
-               (NUM_RX_SGE >> BIT_VEC64_ELEM_SHIFT)*sizeof(u64));
+        memset(fp->sge_mask, 0xff, sizeof(fp->sge_mask));
 
         /* Clear the two last indices in the page to 1:
            these are the indices that correspond to the "next" element,
@@ -911,26 +911,27 @@ static inline int bnx2x_alloc_rx_sge(struct bnx2x *bp,
         return 0;
 }
 
-static inline int bnx2x_alloc_rx_skb(struct bnx2x *bp,
-                                     struct bnx2x_fastpath *fp, u16 index)
+static inline int bnx2x_alloc_rx_data(struct bnx2x *bp,
+                                      struct bnx2x_fastpath *fp, u16 index)
 {
-        struct sk_buff *skb;
+        u8 *data;
         struct sw_rx_bd *rx_buf = &fp->rx_buf_ring[index];
         struct eth_rx_bd *rx_bd = &fp->rx_desc_ring[index];
         dma_addr_t mapping;
 
-        skb = netdev_alloc_skb(bp->dev, fp->rx_buf_size);
-        if (unlikely(skb == NULL))
+        data = kmalloc(fp->rx_buf_size + NET_SKB_PAD, GFP_ATOMIC);
+        if (unlikely(data == NULL))
                 return -ENOMEM;
 
-        mapping = dma_map_single(&bp->pdev->dev, skb->data, fp->rx_buf_size,
+        mapping = dma_map_single(&bp->pdev->dev, data + NET_SKB_PAD,
+                                 fp->rx_buf_size,
                                  DMA_FROM_DEVICE);
         if (unlikely(dma_mapping_error(&bp->pdev->dev, mapping))) {
-                dev_kfree_skb_any(skb);
+                kfree(data);
                 return -ENOMEM;
         }
 
-        rx_buf->skb = skb;
+        rx_buf->data = data;
         dma_unmap_addr_set(rx_buf, mapping, mapping);
 
         rx_bd->addr_hi = cpu_to_le32(U64_HI(mapping));
@@ -939,12 +940,12 @@ static inline int bnx2x_alloc_rx_skb(struct bnx2x *bp,
         return 0;
 }
 
-/* note that we are not allocating a new skb,
+/* note that we are not allocating a new buffer,
  * we are just moving one from cons to prod
  * we are not creating a new mapping,
  * so there is no need to check for dma_mapping_error().
  */
-static inline void bnx2x_reuse_rx_skb(struct bnx2x_fastpath *fp,
+static inline void bnx2x_reuse_rx_data(struct bnx2x_fastpath *fp,
                                       u16 cons, u16 prod)
 {
         struct sw_rx_bd *cons_rx_buf = &fp->rx_buf_ring[cons];
@@ -954,7 +955,7 @@ static inline void bnx2x_reuse_rx_skb(struct bnx2x_fastpath *fp,
 
         dma_unmap_addr_set(prod_rx_buf, mapping,
                            dma_unmap_addr(cons_rx_buf, mapping));
-        prod_rx_buf->skb = cons_rx_buf->skb;
+        prod_rx_buf->data = cons_rx_buf->data;
         *prod_bd = *cons_bd;
 }
 
@@ -1030,9 +1031,9 @@ static inline void bnx2x_free_tpa_pool(struct bnx2x *bp,
         for (i = 0; i < last; i++) {
                 struct bnx2x_agg_info *tpa_info = &fp->tpa_info[i];
                 struct sw_rx_bd *first_buf = &tpa_info->first_buf;
-                struct sk_buff *skb = first_buf->skb;
+                u8 *data = first_buf->data;
 
-                if (skb == NULL) {
+                if (data == NULL) {
                         DP(NETIF_MSG_IFDOWN, "tpa bin %d empty on free\n", i);
                         continue;
                 }
@@ -1040,8 +1041,8 @@ static inline void bnx2x_free_tpa_pool(struct bnx2x *bp,
                         dma_unmap_single(&bp->pdev->dev,
                                          dma_unmap_addr(first_buf, mapping),
                                          fp->rx_buf_size, DMA_FROM_DEVICE);
-                dev_kfree_skb(skb);
-                first_buf->skb = NULL;
+                kfree(data);
+                first_buf->data = NULL;
         }
 }
 
@@ -1149,7 +1150,7 @@ static inline int bnx2x_alloc_rx_bds(struct bnx2x_fastpath *fp,
          * fp->eth_q_stats.rx_skb_alloc_failed = 0
          */
         for (i = 0; i < rx_ring_size; i++) {
-                if (bnx2x_alloc_rx_skb(bp, fp, ring_prod) < 0) {
+                if (bnx2x_alloc_rx_data(bp, fp, ring_prod) < 0) {
                         fp->eth_q_stats.rx_skb_alloc_failed++;
                         continue;
                 }
@@ -1318,6 +1319,7 @@ static inline void bnx2x_init_fcoe_fp(struct bnx2x *bp)
         struct bnx2x_fastpath *fp = bnx2x_fcoe_fp(bp);
         unsigned long q_type = 0;
 
+        bnx2x_fcoe(bp, rx_queue) = BNX2X_NUM_ETH_QUEUES(bp);
         bnx2x_fcoe(bp, cl_id) = bnx2x_cnic_eth_cl_id(bp,
                                                      BNX2X_FCOE_ETH_CL_ID_IDX);
         /** Current BNX2X_FCOE_ETH_CID deffinition implies not more than
@@ -1488,4 +1490,68 @@ static inline u16 bnx2x_extract_max_cfg(struct bnx2x *bp, u32 mf_cfg)
         return max_cfg;
 }
 
+#ifdef BCM_CNIC
+/**
+ * bnx2x_get_iscsi_info - update iSCSI params according to licensing info.
+ *
+ * @bp:         driver handle
+ *
+ */
+void bnx2x_get_iscsi_info(struct bnx2x *bp);
+#endif
+
+/* returns func by VN for current port */
+static inline int func_by_vn(struct bnx2x *bp, int vn)
+{
+        return 2 * vn + BP_PORT(bp);
+}
+
+/**
+ * bnx2x_link_sync_notify - send notification to other functions.
+ *
+ * @bp:         driver handle
+ *
+ */
+static inline void bnx2x_link_sync_notify(struct bnx2x *bp)
+{
+        int func;
+        int vn;
+
+        /* Set the attention towards other drivers on the same port */
+        for (vn = VN_0; vn < BP_MAX_VN_NUM(bp); vn++) {
+                if (vn == BP_VN(bp))
+                        continue;
+
+                func = func_by_vn(bp, vn);
+                REG_WR(bp, MISC_REG_AEU_GENERAL_ATTN_0 +
+                       (LINK_SYNC_ATTENTION_BIT_FUNC_0 + func)*4, 1);
+        }
+}
+
+/**
+ * bnx2x_update_drv_flags - update flags in shmem
+ *
+ * @bp:         driver handle
+ * @flags:      flags to update
+ * @set:        set or clear
+ *
+ */
+static inline void bnx2x_update_drv_flags(struct bnx2x *bp, u32 flags, u32 set)
+{
+        if (SHMEM2_HAS(bp, drv_flags)) {
+                u32 drv_flags;
+                bnx2x_acquire_hw_lock(bp, HW_LOCK_DRV_FLAGS);
+                drv_flags = SHMEM2_RD(bp, drv_flags);
+
+                if (set)
+                        SET_FLAGS(drv_flags, flags);
+                else
+                        RESET_FLAGS(drv_flags, flags);
+
+                SHMEM2_WR(bp, drv_flags, drv_flags);
+                DP(NETIF_MSG_HW, "drv_flags 0x%08x\n", drv_flags);
+                bnx2x_release_hw_lock(bp, HW_LOCK_DRV_FLAGS);
+        }
+}
+
 #endif /* BNX2X_CMN_H */
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
index 51bd7485ab18..5051cf3deb20 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
@@ -685,24 +685,6 @@ int bnx2x_dcbnl_update_applist(struct bnx2x *bp, bool delall)
 }
 #endif
 
-static inline void bnx2x_update_drv_flags(struct bnx2x *bp, u32 flags, u32 set)
-{
-        if (SHMEM2_HAS(bp, drv_flags)) {
-                u32 drv_flags;
-                bnx2x_acquire_hw_lock(bp, HW_LOCK_DRV_FLAGS);
-                drv_flags = SHMEM2_RD(bp, drv_flags);
-
-                if (set)
-                        SET_FLAGS(drv_flags, flags);
-                else
-                        RESET_FLAGS(drv_flags, flags);
-
-                SHMEM2_WR(bp, drv_flags, drv_flags);
-                DP(NETIF_MSG_HW, "drv_flags 0x%08x\n", drv_flags);
-                bnx2x_release_hw_lock(bp, HW_LOCK_DRV_FLAGS);
-        }
-}
-
 static inline void bnx2x_dcbx_update_tc_mapping(struct bnx2x *bp)
 {
         u8 prio, cos;
@@ -755,18 +737,26 @@ void bnx2x_dcbx_set_params(struct bnx2x *bp, u32 state)
                         /* mark DCBX result for PMF migration */
                         bnx2x_update_drv_flags(bp, DRV_FLAGS_DCB_CONFIGURED, 1);
 #ifdef BCM_DCBNL
-                        /**
+                        /*
                          * Add new app tlvs to dcbnl
                          */
                         bnx2x_dcbnl_update_applist(bp, false);
 #endif
-                        bnx2x_dcbx_stop_hw_tx(bp);
-
-                        /* reconfigure the netdevice with the results of the new
+                        /*
+                         * reconfigure the netdevice with the results of the new
                          * dcbx negotiation.
                          */
                         bnx2x_dcbx_update_tc_mapping(bp);
 
+                        /*
+                         * allow other funtions to update their netdevices
+                         * accordingly
+                         */
+                        if (IS_MF(bp))
+                                bnx2x_link_sync_notify(bp);
+
+                        bnx2x_dcbx_stop_hw_tx(bp);
+
                         return;
                 }
         case BNX2X_DCBX_STATE_TX_PAUSED:
@@ -775,6 +765,7 @@ void bnx2x_dcbx_set_params(struct bnx2x *bp, u32 state)
 
                 bnx2x_dcbx_update_ets_params(bp);
                 bnx2x_dcbx_resume_hw_tx(bp);
+
                 return;
         case BNX2X_DCBX_STATE_TX_RELEASED:
                 DP(NETIF_MSG_LINK, "BNX2X_DCBX_STATE_TX_RELEASED\n");
@@ -883,7 +874,7 @@ static void bnx2x_dcbx_admin_mib_updated_params(struct bnx2x *bp,
                 /*For IEEE admin_recommendation_bw_precentage
                  *For IEEE admin_recommendation_ets_pg */
                 af->pfc.pri_en_bitmap = (u8)dp->admin_pfc_bitmap;
-                for (i = 0; i < 4; i++) {
+                for (i = 0; i < DCBX_CONFIG_MAX_APP_PROTOCOL; i++) {
                         if (dp->admin_priority_app_table[i].valid) {
                                 struct bnx2x_admin_priority_app_table *table =
                                         dp->admin_priority_app_table;
@@ -923,7 +914,7 @@ static void bnx2x_dcbx_admin_mib_updated_params(struct bnx2x *bp,
 
 void bnx2x_dcbx_set_state(struct bnx2x *bp, bool dcb_on, u32 dcbx_enabled)
 {
-        if (!CHIP_IS_E1x(bp) && !CHIP_IS_E3(bp)) {
+        if (!CHIP_IS_E1x(bp)) {
                 bp->dcb_state = dcb_on;
                 bp->dcbx_enabled = dcbx_enabled;
         } else {
@@ -1863,7 +1854,7 @@ static void bnx2x_dcbx_fw_struct(struct bnx2x *bp,
 void bnx2x_dcbx_pmf_update(struct bnx2x *bp)
 {
         /* if we need to syncronize DCBX result from prev PMF
-         * read it from shmem and update bp accordingly
+         * read it from shmem and update bp and netdev accordingly
          */
         if (SHMEM2_HAS(bp, drv_flags) &&
            GET_FLAGS(SHMEM2_RD(bp, drv_flags), DRV_FLAGS_DCB_CONFIGURED)) {
@@ -1875,6 +1866,22 @@ void bnx2x_dcbx_pmf_update(struct bnx2x *bp)
                                           bp->dcbx_error);
                 bnx2x_get_dcbx_drv_param(bp, &bp->dcbx_local_feat,
                                          bp->dcbx_error);
+#ifdef BCM_DCBNL
+                /*
+                 * Add new app tlvs to dcbnl
+                 */
+                bnx2x_dcbnl_update_applist(bp, false);
+                /*
+                 * Send a notification for the new negotiated parameters
+                 */
+                dcbnl_cee_notify(bp->dev, RTM_GETDCB, DCB_CMD_CEE_GET, 0, 0);
+#endif
+                /*
+                 * reconfigure the netdevice with the results of the new
+                 * dcbx negotiation.
+                 */
+                bnx2x_dcbx_update_tc_mapping(bp);
+
         }
 }
 
@@ -2242,7 +2249,7 @@ static int bnx2x_set_admin_app_up(struct bnx2x *bp, u8 idtype, u16 idval, u8 up)
         int i, ff;
 
         /* iterate over the app entries looking for idtype and idval */
-        for (i = 0, ff = -1; i < 4; i++) {
+        for (i = 0, ff = -1; i < DCBX_CONFIG_MAX_APP_PROTOCOL; i++) {
                 struct bnx2x_admin_priority_app_table *app_ent =
                         &bp->dcbx_config_params.admin_priority_app_table[i];
                 if (bnx2x_admin_app_is_equal(app_ent, idtype, idval))
@@ -2251,7 +2258,7 @@ static int bnx2x_set_admin_app_up(struct bnx2x *bp, u8 idtype, u16 idval, u8 up)
                 if (ff < 0 && !app_ent->valid)
                         ff = i;
         }
-        if (i < 4)
+        if (i < DCBX_CONFIG_MAX_APP_PROTOCOL)
                 /* if found overwrite up */
                 bp->dcbx_config_params.
                         admin_priority_app_table[i].priority = up;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h
index 2c6a3bca6f28..2ab9254e2d5e 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.h
@@ -90,6 +90,7 @@ struct bnx2x_admin_priority_app_table {
                 u32 app_id;
 };
 
+#define DCBX_CONFIG_MAX_APP_PROTOCOL 4
 struct bnx2x_config_dcbx_params {
         u32 overwrite_settings;
         u32 admin_dcbx_version;
@@ -109,7 +110,8 @@ struct bnx2x_config_dcbx_params {
         u32 admin_recommendation_bw_precentage[8];
         u32 admin_recommendation_ets_pg[8];
         u32 admin_pfc_bitmap;
-        struct bnx2x_admin_priority_app_table admin_priority_app_table[4];
+        struct bnx2x_admin_priority_app_table
+                admin_priority_app_table[DCBX_CONFIG_MAX_APP_PROTOCOL];
         u32 admin_default_priority;
 };
 
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index f0ca8b27a55e..ec318711f483 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -761,8 +761,8 @@ static void bnx2x_get_drvinfo(struct net_device *dev,
         struct bnx2x *bp = netdev_priv(dev);
         u8 phy_fw_ver[PHY_FW_VER_LEN];
 
-        strcpy(info->driver, DRV_MODULE_NAME);
-        strcpy(info->version, DRV_MODULE_VERSION);
+        strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
 
         phy_fw_ver[0] = '\0';
         if (bp->port.pmf) {
@@ -773,14 +773,14 @@ static void bnx2x_get_drvinfo(struct net_device *dev,
                 bnx2x_release_phy_lock(bp);
         }
 
-        strncpy(info->fw_version, bp->fw_ver, 32);
+        strlcpy(info->fw_version, bp->fw_ver, sizeof(info->fw_version));
         snprintf(info->fw_version + strlen(bp->fw_ver), 32 - strlen(bp->fw_ver),
                  "bc %d.%d.%d%s%s",
                  (bp->common.bc_ver & 0xff0000) >> 16,
                  (bp->common.bc_ver & 0xff00) >> 8,
                  (bp->common.bc_ver & 0xff),
                  ((phy_fw_ver[0] != '\0') ? " phy " : ""), phy_fw_ver);
-        strcpy(info->bus_info, pci_name(bp->pdev));
+        strlcpy(info->bus_info, pci_name(bp->pdev), sizeof(info->bus_info));
         info->n_stats = BNX2X_NUM_STATS;
         info->testinfo_len = BNX2X_NUM_TESTS;
         info->eedump_len = bp->common.flash_size;
@@ -1740,6 +1740,7 @@ static int bnx2x_run_loopback(struct bnx2x *bp, int loopback_mode)
         struct sw_rx_bd *rx_buf;
         u16 len;
         int rc = -ENODEV;
+        u8 *data;
 
         /* check the loopback mode */
         switch (loopback_mode) {
@@ -1865,10 +1866,9 @@ static int bnx2x_run_loopback(struct bnx2x *bp, int loopback_mode)
         dma_sync_single_for_cpu(&bp->pdev->dev,
                                    dma_unmap_addr(rx_buf, mapping),
                                    fp_rx->rx_buf_size, DMA_FROM_DEVICE);
-        skb = rx_buf->skb;
-        skb_reserve(skb, cqe->fast_path_cqe.placement_offset);
+        data = rx_buf->data + NET_SKB_PAD + cqe->fast_path_cqe.placement_offset;
         for (i = ETH_HLEN; i < pkt_size; i++)
-                if (*(skb->data + i) != (unsigned char) (i & 0xff))
+                if (*(data + i) != (unsigned char) (i & 0xff))
                         goto test_loopback_rx_exit;
 
         rc = 0;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 2f6361e949f0..83481e20f144 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -2318,12 +2318,6 @@ static void bnx2x_calc_vn_weight_sum(struct bnx2x *bp)
                                         CMNG_FLAGS_PER_PORT_FAIRNESS_VN;
 }
 
-/* returns func by VN for current port */
-static inline int func_by_vn(struct bnx2x *bp, int vn)
-{
-        return 2 * vn + BP_PORT(bp);
-}
-
 static void bnx2x_init_vn_minmax(struct bnx2x *bp, int vn)
 {
         struct rate_shaping_vars_per_vn m_rs_vn;
@@ -2475,22 +2469,6 @@ static void bnx2x_cmng_fns_init(struct bnx2x *bp, u8 read_cfg, u8 cmng_type)
            "rate shaping and fairness are disabled\n");
 }
 
-static inline void bnx2x_link_sync_notify(struct bnx2x *bp)
-{
-        int func;
-        int vn;
-
-        /* Set the attention towards other drivers on the same port */
-        for (vn = VN_0; vn < BP_MAX_VN_NUM(bp); vn++) {
-                if (vn == BP_VN(bp))
-                        continue;
-
-                func = func_by_vn(bp, vn);
-                REG_WR(bp, MISC_REG_AEU_GENERAL_ATTN_0 +
-                       (LINK_SYNC_ATTENTION_BIT_FUNC_0 + func)*4, 1);
-        }
-}
-
 /* This function is called upon link interrupt */
 static void bnx2x_link_attn(struct bnx2x *bp)
 {
@@ -2549,6 +2527,9 @@ void bnx2x__link_status_update(struct bnx2x *bp)
         if (bp->state != BNX2X_STATE_OPEN)
                 return;
 
+        /* read updated dcb configuration */
+        bnx2x_dcbx_pmf_update(bp);
+
         bnx2x_link_status_update(&bp->link_params, &bp->link_vars);
 
         if (bp->link_vars.link_up)
@@ -2808,8 +2789,8 @@ static void bnx2x_pf_rx_q_prep(struct bnx2x *bp,
         /* This should be a maximum number of data bytes that may be
          * placed on the BD (not including paddings).
          */
-        rxq_init->buf_sz = fp->rx_buf_size - BNX2X_FW_RX_ALIGN -
-                IP_HEADER_ALIGNMENT_PADDING;
+        rxq_init->buf_sz = fp->rx_buf_size - BNX2X_FW_RX_ALIGN_START -
+                BNX2X_FW_RX_ALIGN_END - IP_HEADER_ALIGNMENT_PADDING;
 
         rxq_init->cl_qzone_id = fp->cl_qzone_id;
         rxq_init->tpa_agg_sz = tpa_agg_size;
@@ -3318,6 +3299,17 @@ static inline void bnx2x_fan_failure(struct bnx2x *bp)
         netdev_err(bp->dev, "Fan Failure on Network Controller has caused"
                " the driver to shutdown the card to prevent permanent"
                " damage.  Please contact OEM Support for assistance\n");
+
+        /*
+         * Scheudle device reset (unload)
+         * This is due to some boards consuming sufficient power when driver is
+         * up to overheat if fan fails.
+         */
+        smp_mb__before_clear_bit();
+        set_bit(BNX2X_SP_RTNL_FAN_FAILURE, &bp->sp_rtnl_state);
+        smp_mb__after_clear_bit();
+        schedule_delayed_work(&bp->sp_rtnl_task, 0);
+
 }
 
 static inline void bnx2x_attn_int_deasserted0(struct bnx2x *bp, u32 attn)
@@ -5247,7 +5239,7 @@ static void bnx2x_init_eth_fp(struct bnx2x *bp, int fp_idx)
         u8 cos;
         unsigned long q_type = 0;
         u32 cids[BNX2X_MULTI_TX_COS] = { 0 };
-
+        fp->rx_queue = fp_idx;
         fp->cid = fp_idx;
         fp->cl_id = bnx2x_fp_cl_id(fp);
         fp->fw_sb_id = bnx2x_fp_fw_sb_id(fp);
@@ -8522,6 +8514,17 @@ sp_rtnl_not_reset:
         if (test_and_clear_bit(BNX2X_SP_RTNL_SETUP_TC, &bp->sp_rtnl_state))
                 bnx2x_setup_tc(bp->dev, bp->dcbx_port_params.ets.num_of_cos);
 
+        /*
+         * in case of fan failure we need to reset id if the "stop on error"
+         * debug flag is set, since we trying to prevent permanent overheating
+         * damage
+         */
+        if (test_and_clear_bit(BNX2X_SP_RTNL_FAN_FAILURE, &bp->sp_rtnl_state)) {
+                DP(BNX2X_MSG_SP, "fan failure detected. Unloading driver\n");
+                netif_device_detach(bp->dev);
+                bnx2x_close(bp->dev);
+        }
+
 sp_rtnl_exit:
         rtnl_unlock();
 }
@@ -9268,21 +9271,38 @@ static void __devinit bnx2x_get_port_hwinfo(struct bnx2x *bp)
 }
 
 #ifdef BCM_CNIC
-static void __devinit bnx2x_get_cnic_info(struct bnx2x *bp)
+void bnx2x_get_iscsi_info(struct bnx2x *bp)
 {
         int port = BP_PORT(bp);
-        int func = BP_ABS_FUNC(bp);
 
         u32 max_iscsi_conn = FW_ENCODE_32BIT_PATTERN ^ SHMEM_RD(bp,
                                 drv_lic_key[port].max_iscsi_conn);
-        u32 max_fcoe_conn = FW_ENCODE_32BIT_PATTERN ^ SHMEM_RD(bp,
-                                drv_lic_key[port].max_fcoe_conn);
 
-        /* Get the number of maximum allowed iSCSI and FCoE connections */
+        /* Get the number of maximum allowed iSCSI connections */
         bp->cnic_eth_dev.max_iscsi_conn =
                 (max_iscsi_conn & BNX2X_MAX_ISCSI_INIT_CONN_MASK) >>
                 BNX2X_MAX_ISCSI_INIT_CONN_SHIFT;
 
+        BNX2X_DEV_INFO("max_iscsi_conn 0x%x\n",
+                       bp->cnic_eth_dev.max_iscsi_conn);
+
+        /*
+         * If maximum allowed number of connections is zero -
+         * disable the feature.
+         */
+        if (!bp->cnic_eth_dev.max_iscsi_conn)
+                bp->flags |= NO_ISCSI_FLAG;
+}
+
+static void __devinit bnx2x_get_fcoe_info(struct bnx2x *bp)
+{
+        int port = BP_PORT(bp);
+        int func = BP_ABS_FUNC(bp);
+
+        u32 max_fcoe_conn = FW_ENCODE_32BIT_PATTERN ^ SHMEM_RD(bp,
+                                drv_lic_key[port].max_fcoe_conn);
+
+        /* Get the number of maximum allowed FCoE connections */
         bp->cnic_eth_dev.max_fcoe_conn =
                 (max_fcoe_conn & BNX2X_MAX_FCOE_INIT_CONN_MASK) >>
                 BNX2X_MAX_FCOE_INIT_CONN_SHIFT;
@@ -9334,20 +9354,26 @@ static void __devinit bnx2x_get_cnic_info(struct bnx2x *bp)
                 }
         }
 
-        BNX2X_DEV_INFO("max_iscsi_conn 0x%x max_fcoe_conn 0x%x\n",
-                       bp->cnic_eth_dev.max_iscsi_conn,
-                       bp->cnic_eth_dev.max_fcoe_conn);
+        BNX2X_DEV_INFO("max_fcoe_conn 0x%x\n", bp->cnic_eth_dev.max_fcoe_conn);
 
         /*
          * If maximum allowed number of connections is zero -
          * disable the feature.
          */
-        if (!bp->cnic_eth_dev.max_iscsi_conn)
-                bp->flags |= NO_ISCSI_OOO_FLAG | NO_ISCSI_FLAG;
-
         if (!bp->cnic_eth_dev.max_fcoe_conn)
                 bp->flags |= NO_FCOE_FLAG;
 }
+
+static void __devinit bnx2x_get_cnic_info(struct bnx2x *bp)
+{
+        /*
+         * iSCSI may be dynamically disabled but reading
+         * info here we will decrease memory usage by driver
+         * if the feature is disabled for good
+         */
+        bnx2x_get_iscsi_info(bp);
+        bnx2x_get_fcoe_info(bp);
+}
 #endif
 
 static void __devinit bnx2x_get_mac_hwinfo(struct bnx2x *bp)
@@ -9965,7 +9991,7 @@ static int bnx2x_open(struct net_device *dev)
 }
 
 /* called with rtnl_lock */
-static int bnx2x_close(struct net_device *dev)
+int bnx2x_close(struct net_device *dev)
 {
         struct bnx2x *bp = netdev_priv(dev);
 
@@ -10823,8 +10849,8 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev,
         bp->qm_cid_count = bnx2x_set_qm_cid_count(bp);
 
 #ifdef BCM_CNIC
-        /* disable FCOE L2 queue for E1x and E3*/
-        if (CHIP_IS_E1x(bp) || CHIP_IS_E3(bp))
+        /* disable FCOE L2 queue for E1x */
+        if (CHIP_IS_E1x(bp))
                 bp->flags |= NO_FCOE_FLAG;
 
 #endif
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c
index 02ac6a771bf9..3034f0e31938 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c
@@ -1349,12 +1349,14 @@ void bnx2x_stats_handle(struct bnx2x *bp, enum bnx2x_stats_event event)
         enum bnx2x_stats_state state;
         if (unlikely(bp->panic))
                 return;
-        bnx2x_stats_stm[bp->stats_state][event].action(bp);
+
         spin_lock_bh(&bp->stats_lock);
         state = bp->stats_state;
         bp->stats_state = bnx2x_stats_stm[state][event].next_state;
         spin_unlock_bh(&bp->stats_lock);
 
+        bnx2x_stats_stm[state][event].action(bp);
+
         if ((event != STATS_EVENT_UPDATE) || netif_msg_timer(bp))
                 DP(BNX2X_MSG_STATS, "state %d -> event %d -> state %d\n",
                    state, event, bp->stats_state);
diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index 0a1d7f279fc8..aa58f9e3f913 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -163,7 +163,6 @@ enum sbmac_state {
 #define SBMAC_MAX_TXDESCR       256
 #define SBMAC_MAX_RXDESCR       256
 
-#define ETHER_ADDR_LEN          6
 #define ENET_PACKET_SIZE        1518
 /*#define ENET_PACKET_SIZE      9216 */
 
@@ -266,7 +265,7 @@ struct sbmac_softc {
         int                     sbm_pause;      /* current pause setting */
         int                     sbm_link;       /* current link state */
 
-        unsigned char           sbm_hwaddr[ETHER_ADDR_LEN];
+        unsigned char           sbm_hwaddr[ETH_ALEN];
 
         struct sbmacdma         sbm_txdma;      /* only channel 0 for now */
         struct sbmacdma         sbm_rxdma;
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index bf4074167d6a..024ca1d4d028 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -3594,15 +3594,7 @@ static int tg3_phy_autoneg_cfg(struct tg3 *tp, u32 advertise, u32 flowctrl)
         u32 val, new_adv;
 
         new_adv = ADVERTISE_CSMA;
-        if (advertise & ADVERTISED_10baseT_Half)
-                new_adv |= ADVERTISE_10HALF;
-        if (advertise & ADVERTISED_10baseT_Full)
-                new_adv |= ADVERTISE_10FULL;
-        if (advertise & ADVERTISED_100baseT_Half)
-                new_adv |= ADVERTISE_100HALF;
-        if (advertise & ADVERTISED_100baseT_Full)
-                new_adv |= ADVERTISE_100FULL;
-
+        new_adv |= ethtool_adv_to_mii_100bt(advertise);
         new_adv |= tg3_advert_flowctrl_1000T(flowctrl);
 
         err = tg3_writephy(tp, MII_ADVERTISE, new_adv);
@@ -3612,11 +3604,7 @@ static int tg3_phy_autoneg_cfg(struct tg3 *tp, u32 advertise, u32 flowctrl)
         if (tp->phy_flags & TG3_PHYFLG_10_100_ONLY)
                 goto done;
 
-        new_adv = 0;
-        if (advertise & ADVERTISED_1000baseT_Half)
-                new_adv |= ADVERTISE_1000HALF;
-        if (advertise & ADVERTISED_1000baseT_Full)
-                new_adv |= ADVERTISE_1000FULL;
+        new_adv = ethtool_adv_to_mii_1000T(advertise);
 
         if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
             tp->pci_chip_rev_id == CHIPREV_ID_5701_B0)
@@ -3790,14 +3778,7 @@ static int tg3_copper_is_advertising_all(struct tg3 *tp, u32 mask)
 {
         u32 adv_reg, all_mask = 0;
 
-        if (mask & ADVERTISED_10baseT_Half)
-                all_mask |= ADVERTISE_10HALF;
-        if (mask & ADVERTISED_10baseT_Full)
-                all_mask |= ADVERTISE_10FULL;
-        if (mask & ADVERTISED_100baseT_Half)
-                all_mask |= ADVERTISE_100HALF;
-        if (mask & ADVERTISED_100baseT_Full)
-                all_mask |= ADVERTISE_100FULL;
+        all_mask = ethtool_adv_to_mii_100bt(mask);
 
         if (tg3_readphy(tp, MII_ADVERTISE, &adv_reg))
                 return 0;
@@ -3808,11 +3789,7 @@ static int tg3_copper_is_advertising_all(struct tg3 *tp, u32 mask)
         if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) {
                 u32 tg3_ctrl;
 
-                all_mask = 0;
-                if (mask & ADVERTISED_1000baseT_Half)
-                        all_mask |= ADVERTISE_1000HALF;
-                if (mask & ADVERTISED_1000baseT_Full)
-                        all_mask |= ADVERTISE_1000FULL;
+                all_mask = ethtool_adv_to_mii_1000T(mask);
 
                 if (tg3_readphy(tp, MII_CTRL1000, &tg3_ctrl))
                         return 0;
@@ -4903,23 +4880,19 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
             (tp->phy_flags & TG3_PHYFLG_PARALLEL_DETECT)) {
                 /* do nothing, just check for link up at the end */
         } else if (tp->link_config.autoneg == AUTONEG_ENABLE) {
-                u32 adv, new_adv;
+                u32 adv, newadv;
 
                 err |= tg3_readphy(tp, MII_ADVERTISE, &adv);
-                new_adv = adv & ~(ADVERTISE_1000XFULL | ADVERTISE_1000XHALF |
-                                  ADVERTISE_1000XPAUSE |
-                                  ADVERTISE_1000XPSE_ASYM |
-                                  ADVERTISE_SLCT);
-
-                new_adv |= tg3_advert_flowctrl_1000X(tp->link_config.flowctrl);
+                newadv = adv & ~(ADVERTISE_1000XFULL | ADVERTISE_1000XHALF |
+                                 ADVERTISE_1000XPAUSE |
+                                 ADVERTISE_1000XPSE_ASYM |
+                                 ADVERTISE_SLCT);
 
-                if (tp->link_config.advertising & ADVERTISED_1000baseT_Half)
-                        new_adv |= ADVERTISE_1000XHALF;
-                if (tp->link_config.advertising & ADVERTISED_1000baseT_Full)
-                        new_adv |= ADVERTISE_1000XFULL;
+                newadv |= tg3_advert_flowctrl_1000X(tp->link_config.flowctrl);
+                newadv |= ethtool_adv_to_mii_1000X(tp->link_config.advertising);
 
-                if ((new_adv != adv) || !(bmcr & BMCR_ANENABLE)) {
-                        tg3_writephy(tp, MII_ADVERTISE, new_adv);
+                if ((newadv != adv) || !(bmcr & BMCR_ANENABLE)) {
+                        tg3_writephy(tp, MII_ADVERTISE, newadv);
                         bmcr |= BMCR_ANENABLE | BMCR_ANRESTART;
                         tg3_writephy(tp, MII_BMCR, bmcr);
 
@@ -6968,7 +6941,7 @@ static int tg3_phy_lpbk_set(struct tg3 *tp, u32 speed, bool extlpbk)
         return 0;
 }
 
-static void tg3_set_loopback(struct net_device *dev, u32 features)
+static void tg3_set_loopback(struct net_device *dev, netdev_features_t features)
 {
         struct tg3 *tp = netdev_priv(dev);
 
@@ -6994,7 +6967,8 @@ static void tg3_set_loopback(struct net_device *dev, u32 features)
         }
 }
 
-static u32 tg3_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t tg3_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct tg3 *tp = netdev_priv(dev);
 
@@ -7004,9 +6978,9 @@ static u32 tg3_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int tg3_set_features(struct net_device *dev, u32 features)
+static int tg3_set_features(struct net_device *dev, netdev_features_t features)
 {
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if ((changed & NETIF_F_LOOPBACK) && netif_running(dev))
                 tg3_set_loopback(dev, features);
@@ -10428,10 +10402,10 @@ static void tg3_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
 {
         struct tg3 *tp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_MODULE_NAME);
-        strcpy(info->version, DRV_MODULE_VERSION);
-        strcpy(info->fw_version, tp->fw_ver);
-        strcpy(info->bus_info, pci_name(tp->pdev));
+        strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, tp->fw_ver, sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(tp->pdev), sizeof(info->bus_info));
 }
 
 static void tg3_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
@@ -15313,7 +15287,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
         u32 sndmbx, rcvmbx, intmbx;
         char str[40];
         u64 dma_mask, persist_dma_mask;
-        u32 features = 0;
+        netdev_features_t features = 0;
 
         printk_once(KERN_INFO "%s\n", version);
 
diff --git a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
index fd3dcc1e9145..38d5c66075f9 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
@@ -296,8 +296,8 @@ bnad_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
         struct bfa_ioc_attr *ioc_attr;
         unsigned long flags;
 
-        strcpy(drvinfo->driver, BNAD_NAME);
-        strcpy(drvinfo->version, BNAD_VERSION);
+        strlcpy(drvinfo->driver, BNAD_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, BNAD_VERSION, sizeof(drvinfo->version));
 
         ioc_attr = kzalloc(sizeof(*ioc_attr), GFP_KERNEL);
         if (ioc_attr) {
@@ -305,12 +305,13 @@ bnad_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
                 bfa_nw_ioc_get_attr(&bnad->bna.ioceth.ioc, ioc_attr);
                 spin_unlock_irqrestore(&bnad->bna_lock, flags);
 
-                strncpy(drvinfo->fw_version, ioc_attr->adapter_attr.fw_ver,
-                        sizeof(drvinfo->fw_version) - 1);
+                strlcpy(drvinfo->fw_version, ioc_attr->adapter_attr.fw_ver,
+                        sizeof(drvinfo->fw_version));
                 kfree(ioc_attr);
         }
 
-        strncpy(drvinfo->bus_info, pci_name(bnad->pcidev), ETHTOOL_BUSINFO_LEN);
+        strlcpy(drvinfo->bus_info, pci_name(bnad->pcidev),
+                sizeof(drvinfo->bus_info));
 }
 
 static void
diff --git a/drivers/net/ethernet/brocade/bna/cna.h b/drivers/net/ethernet/brocade/bna/cna.h
index 1b3e90dfbd9a..32e8f178ab76 100644
--- a/drivers/net/ethernet/brocade/bna/cna.h
+++ b/drivers/net/ethernet/brocade/bna/cna.h
@@ -43,8 +43,7 @@ extern char bfa_version[];
 
 #pragma pack(1)
 
-#define MAC_ADDRLEN     (6)
-typedef struct mac { u8 mac[MAC_ADDRLEN]; } mac_t;
+typedef struct mac { u8 mac[ETH_ALEN]; } mac_t;
 
 #pragma pack()
 
diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
index ca26d97171bd..a971796b2262 100644
--- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
+++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
@@ -434,10 +434,11 @@ static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct adapter *adapter = dev->ml_priv;
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
-        strcpy(info->bus_info, pci_name(adapter->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(adapter->pdev),
+                sizeof(info->bus_info));
 }
 
 static int get_sset_count(struct net_device *dev, int sset)
@@ -849,7 +850,8 @@ static int t1_set_mac_addr(struct net_device *dev, void *p)
         return 0;
 }
 
-static u32 t1_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t t1_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -863,9 +865,9 @@ static u32 t1_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int t1_set_features(struct net_device *dev, u32 features)
+static int t1_set_features(struct net_device *dev, netdev_features_t features)
 {
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
         struct adapter *adapter = dev->ml_priv;
 
         if (changed & NETIF_F_HW_VLAN_RX)
diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.c b/drivers/net/ethernet/chelsio/cxgb/sge.c
index f9b602300040..47a84359d4e4 100644
--- a/drivers/net/ethernet/chelsio/cxgb/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb/sge.c
@@ -742,7 +742,7 @@ static inline void setup_ring_params(struct adapter *adapter, u64 addr,
 /*
  * Enable/disable VLAN acceleration.
  */
-void t1_vlan_mode(struct adapter *adapter, u32 features)
+void t1_vlan_mode(struct adapter *adapter, netdev_features_t features)
 {
         struct sge *sge = adapter->sge;
 
diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.h b/drivers/net/ethernet/chelsio/cxgb/sge.h
index e03980bcdd65..b9bf16b385f7 100644
--- a/drivers/net/ethernet/chelsio/cxgb/sge.h
+++ b/drivers/net/ethernet/chelsio/cxgb/sge.h
@@ -79,7 +79,7 @@ irqreturn_t t1_interrupt(int irq, void *cookie);
 int t1_poll(struct napi_struct *, int);
 
 netdev_tx_t t1_start_xmit(struct sk_buff *skb, struct net_device *dev);
-void t1_vlan_mode(struct adapter *adapter, u32 features);
+void t1_vlan_mode(struct adapter *adapter, netdev_features_t features);
 void t1_sge_start(struct sge *);
 void t1_sge_stop(struct sge *);
 int t1_sge_intr_error_handler(struct sge *);
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
index 4d15c8f99c3b..63ffaa7e255f 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
@@ -1576,11 +1576,12 @@ static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
         t3_get_tp_version(adapter, &tp_vers);
         spin_unlock(&adapter->stats_lock);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(adapter->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(adapter->pdev),
+                sizeof(info->bus_info));
         if (!fw_vers)
-                strcpy(info->fw_version, "N/A");
+                strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
         else {
                 snprintf(info->fw_version, sizeof(info->fw_version),
                          "%s %u.%u.%u TP %u.%u.%u",
@@ -2531,7 +2532,7 @@ static void t3_synchronize_rx(struct adapter *adap, const struct port_info *p)
         }
 }
 
-static void cxgb_vlan_mode(struct net_device *dev, u32 features)
+static void cxgb_vlan_mode(struct net_device *dev, netdev_features_t features)
 {
         struct port_info *pi = netdev_priv(dev);
         struct adapter *adapter = pi->adapter;
@@ -2552,7 +2553,8 @@ static void cxgb_vlan_mode(struct net_device *dev, u32 features)
         t3_synchronize_rx(adapter, pi);
 }
 
-static u32 cxgb_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t cxgb_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -2566,9 +2568,9 @@ static u32 cxgb_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int cxgb_set_features(struct net_device *dev, u32 features)
+static int cxgb_set_features(struct net_device *dev, netdev_features_t features)
 {
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 cxgb_vlan_mode(dev, features);
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 4c8f42afa3c6..fd6d460ea475 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -1002,12 +1002,13 @@ static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct adapter *adapter = netdev2adap(dev);
 
-        strcpy(info->driver, KBUILD_MODNAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(adapter->pdev));
+        strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(adapter->pdev),
+                sizeof(info->bus_info));
 
         if (!adapter->params.fw_vers)
-                strcpy(info->fw_version, "N/A");
+                strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
         else
                 snprintf(info->fw_version, sizeof(info->fw_version),
                         "%u.%u.%u.%u, TP %u.%u.%u.%u",
@@ -1855,10 +1856,10 @@ static int set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
         return err;
 }
 
-static int cxgb_set_features(struct net_device *dev, u32 features)
+static int cxgb_set_features(struct net_device *dev, netdev_features_t features)
 {
         const struct port_info *pi = netdev_priv(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
         int err;
 
         if (!(changed & NETIF_F_HW_VLAN_RX))
@@ -3537,7 +3538,7 @@ static int __devinit init_one(struct pci_dev *pdev,
 {
         int func, i, err;
         struct port_info *pi;
-        unsigned int highdma = 0;
+        bool highdma = false;
         struct adapter *adapter = NULL;
 
         printk_once(KERN_INFO "%s - version %s\n", DRV_DESC, DRV_VERSION);
@@ -3563,7 +3564,7 @@ static int __devinit init_one(struct pci_dev *pdev,
         }
 
         if (!pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
-                highdma = NETIF_F_HIGHDMA;
+                highdma = true;
                 err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
                 if (err) {
                         dev_err(&pdev->dev, "unable to obtain 64-bit DMA for "
@@ -3637,7 +3638,9 @@ static int __devinit init_one(struct pci_dev *pdev,
                         NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
                         NETIF_F_RXCSUM | NETIF_F_RXHASH |
                         NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
-                netdev->features |= netdev->hw_features | highdma;
+                if (highdma)
+                        netdev->hw_features |= NETIF_F_HIGHDMA;
+                netdev->features |= netdev->hw_features;
                 netdev->vlan_features = netdev->features & VLAN_FEAT;
 
                 netdev->priv_flags |= IFF_UNICAST_FLT;
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index da9072bfca8b..8155cfecae19 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -1092,7 +1092,8 @@ static int cxgb4vf_change_mtu(struct net_device *dev, int new_mtu)
         return ret;
 }
 
-static u32 cxgb4vf_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t cxgb4vf_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -1106,10 +1107,11 @@ static u32 cxgb4vf_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int cxgb4vf_set_features(struct net_device *dev, u32 features)
+static int cxgb4vf_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct port_info *pi = netdev_priv(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 t4vf_set_rxmode(pi->adapter, pi->viid, -1, -1, -1, -1,
@@ -1203,9 +1205,10 @@ static void cxgb4vf_get_drvinfo(struct net_device *dev,
 {
         struct adapter *adapter = netdev2adap(dev);
 
-        strcpy(drvinfo->driver, KBUILD_MODNAME);
-        strcpy(drvinfo->version, DRV_VERSION);
-        strcpy(drvinfo->bus_info, pci_name(to_pci_dev(dev->dev.parent)));
+        strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
+        strlcpy(drvinfo->bus_info, pci_name(to_pci_dev(dev->dev.parent)),
+                sizeof(drvinfo->bus_info));
         snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
                  "%u.%u.%u.%u, TP %u.%u.%u.%u",
                  FW_HDR_FW_VER_MAJOR_GET(adapter->params.dev.fwrev),
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index c3786fda11db..1fe5df0284a6 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -217,11 +217,11 @@ static void enic_get_drvinfo(struct net_device *netdev,
 
         enic_dev_fw_info(enic, &fw_info);
 
-        strncpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
-        strncpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
-        strncpy(drvinfo->fw_version, fw_info->fw_version,
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, fw_info->fw_version,
                 sizeof(drvinfo->fw_version));
-        strncpy(drvinfo->bus_info, pci_name(enic->pdev),
+        strlcpy(drvinfo->bus_info, pci_name(enic->pdev),
                 sizeof(drvinfo->bus_info));
 }
 
diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
index 438f4580bf66..26be1dfc1577 100644
--- a/drivers/net/ethernet/davicom/dm9000.c
+++ b/drivers/net/ethernet/davicom/dm9000.c
@@ -474,10 +474,11 @@ static int dm9000_nway_reset(struct net_device *dev)
         return mii_nway_restart(&dm->mii);
 }
 
-static int dm9000_set_features(struct net_device *dev, u32 features)
+static int dm9000_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         board_info_t *dm = to_dm9000_board(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
         unsigned long flags;
 
         if (!(changed & NETIF_F_RXCSUM))
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index 1427739d9a51..1eb46a0bb488 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c
@@ -1598,9 +1598,9 @@ static void de_get_drvinfo (struct net_device *dev,struct ethtool_drvinfo *info)
 {
         struct de_private *de = netdev_priv(dev);
 
-        strcpy (info->driver, DRV_NAME);
-        strcpy (info->version, DRV_VERSION);
-        strcpy (info->bus_info, pci_name(de->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(de->pdev), sizeof(info->bus_info));
         info->eedump_len = DE_EEPROM_SIZE;
 }
 
diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c
index 17b11ee1745a..51f7542eb451 100644
--- a/drivers/net/ethernet/dec/tulip/dmfe.c
+++ b/drivers/net/ethernet/dec/tulip/dmfe.c
@@ -1085,10 +1085,11 @@ static void dmfe_ethtool_get_drvinfo(struct net_device *dev,
 {
         struct dmfe_board_info *np = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
         if (np->pdev)
-                strcpy(info->bus_info, pci_name(np->pdev));
+                strlcpy(info->bus_info, pci_name(np->pdev),
+                        sizeof(info->bus_info));
         else
                 sprintf(info->bus_info, "EISA 0x%lx %d",
                         dev->base_addr, dev->irq);
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 9656dd0647d9..4eb0d76145c2 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -871,9 +871,9 @@ static struct net_device_stats *tulip_get_stats(struct net_device *dev)
 static void tulip_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct tulip_private *np = netdev_priv(dev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(np->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pdev), sizeof(info->bus_info));
 }
 
 
diff --git a/drivers/net/ethernet/dec/tulip/uli526x.c b/drivers/net/ethernet/dec/tulip/uli526x.c
index 7a44a7a6adc8..48b0b6566eef 100644
--- a/drivers/net/ethernet/dec/tulip/uli526x.c
+++ b/drivers/net/ethernet/dec/tulip/uli526x.c
@@ -960,10 +960,11 @@ static void netdev_get_drvinfo(struct net_device *dev,
 {
         struct uli526x_board_info *np = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
         if (np->pdev)
-                strcpy(info->bus_info, pci_name(np->pdev));
+                strlcpy(info->bus_info, pci_name(np->pdev),
+                        sizeof(info->bus_info));
         else
                 sprintf(info->bus_info, "EISA 0x%lx %d",
                         dev->base_addr, dev->irq);
diff --git a/drivers/net/ethernet/dec/tulip/winbond-840.c b/drivers/net/ethernet/dec/tulip/winbond-840.c
index 4d01219ba22f..52da7b2fe3b6 100644
--- a/drivers/net/ethernet/dec/tulip/winbond-840.c
+++ b/drivers/net/ethernet/dec/tulip/winbond-840.c
@@ -1390,9 +1390,9 @@ static void netdev_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *
 {
         struct netdev_private *np = netdev_priv(dev);
 
-        strcpy (info->driver, DRV_NAME);
-        strcpy (info->version, DRV_VERSION);
-        strcpy (info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c
index dcd7f7a71ad4..28a3a9b50b8b 100644
--- a/drivers/net/ethernet/dlink/sundance.c
+++ b/drivers/net/ethernet/dlink/sundance.c
@@ -1634,9 +1634,9 @@ static int check_if_running(struct net_device *dev)
 static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct netdev_private *np = netdev_priv(dev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c
index c1063d1540c2..d94b9686b80c 100644
--- a/drivers/net/ethernet/dnet.c
+++ b/drivers/net/ethernet/dnet.c
@@ -804,9 +804,9 @@ static int dnet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 static void dnet_get_drvinfo(struct net_device *dev,
                              struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, "0");
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, "0", sizeof(info->bus_info));
 }
 
 static const struct ethtool_ops dnet_ethtool_ops = {
diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index 644e8fed8364..34f162db9f2e 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -289,14 +289,12 @@ struct be_drv_stats {
 
 struct be_vf_cfg {
         unsigned char vf_mac_addr[ETH_ALEN];
-        u32 vf_if_handle;
-        u32 vf_pmac_id;
+        int vf_if_handle;
+        int vf_pmac_id;
         u16 vf_vlan_tag;
         u32 vf_tx_rate;
 };
 
-#define BE_INVALID_PMAC_ID              0xffffffff
-
 struct be_adapter {
         struct pci_dev *pdev;
         struct net_device *netdev;
@@ -347,11 +345,13 @@ struct be_adapter {
 
         /* Ethtool knobs and info */
         char fw_ver[FW_VER_LEN];
-        u32 if_handle;          /* Used to configure filtering */
+        int if_handle;          /* Used to configure filtering */
         u32 pmac_id;            /* MAC addr handle used by BE card */
         u32 beacon_state;       /* for set_phys_id */
 
         bool eeh_err;
+        bool ue_detected;
+        bool fw_timeout;
         u32 port_num;
         bool promiscuous;
         bool wol;
@@ -359,7 +359,6 @@ struct be_adapter {
         u32 function_caps;
         u32 rx_fc;              /* Rx flow control */
         u32 tx_fc;              /* Tx flow control */
-        bool ue_detected;
         bool stats_cmd_sent;
         int link_speed;
         u8 port_type;
@@ -524,6 +523,11 @@ static inline bool be_multi_rxq(const struct be_adapter *adapter)
         return adapter->num_rx_qs > 1;
 }
 
+static inline bool be_error(struct be_adapter *adapter)
+{
+        return adapter->eeh_err || adapter->ue_detected || adapter->fw_timeout;
+}
+
 extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
                 u16 num_popped);
 extern void be_link_status_update(struct be_adapter *adapter, u32 link_status);
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
index 2c7b36673dfc..64f0c1aa1b09 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.c
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
@@ -31,11 +31,8 @@ static void be_mcc_notify(struct be_adapter *adapter)
         struct be_queue_info *mccq = &adapter->mcc_obj.q;
         u32 val = 0;
 
-        if (adapter->eeh_err) {
-                dev_info(&adapter->pdev->dev,
-                        "Error in Card Detected! Cannot issue commands\n");
+        if (be_error(adapter))
                 return;
-        }
 
         val |= mccq->id & DB_MCCQ_RING_ID_MASK;
         val |= 1 << DB_MCCQ_NUM_POSTED_SHIFT;
@@ -266,10 +263,10 @@ static int be_mcc_wait_compl(struct be_adapter *adapter)
         int i, num, status = 0;
         struct be_mcc_obj *mcc_obj = &adapter->mcc_obj;
 
-        if (adapter->eeh_err)
-                return -EIO;
-
         for (i = 0; i < mcc_timeout; i++) {
+                if (be_error(adapter))
+                        return -EIO;
+
                 num = be_process_mcc(adapter, &status);
                 if (num)
                         be_cq_notify(adapter, mcc_obj->cq.id,
@@ -280,7 +277,8 @@ static int be_mcc_wait_compl(struct be_adapter *adapter)
                 udelay(100);
         }
         if (i == mcc_timeout) {
-                dev_err(&adapter->pdev->dev, "mccq poll timed out\n");
+                dev_err(&adapter->pdev->dev, "FW not responding\n");
+                adapter->fw_timeout = true;
                 return -1;
         }
         return status;
@@ -298,26 +296,21 @@ static int be_mbox_db_ready_wait(struct be_adapter *adapter, void __iomem *db)
         int msecs = 0;
         u32 ready;
 
-        if (adapter->eeh_err) {
-                dev_err(&adapter->pdev->dev,
-                        "Error detected in card.Cannot issue commands\n");
-                return -EIO;
-        }
-
         do {
+                if (be_error(adapter))
+                        return -EIO;
+
                 ready = ioread32(db);
-                if (ready == 0xffffffff) {
-                        dev_err(&adapter->pdev->dev,
-                                "pci slot disconnected\n");
+                if (ready == 0xffffffff)
                         return -1;
-                }
 
                 ready &= MPU_MAILBOX_DB_RDY_MASK;
                 if (ready)
                         break;
 
                 if (msecs > 4000) {
-                        dev_err(&adapter->pdev->dev, "mbox poll timed out\n");
+                        dev_err(&adapter->pdev->dev, "FW not responding\n");
+                        adapter->fw_timeout = true;
                         be_detect_dump_ue(adapter);
                         return -1;
                 }
@@ -555,9 +548,6 @@ int be_cmd_fw_clean(struct be_adapter *adapter)
         u8 *wrb;
         int status;
 
-        if (adapter->eeh_err)
-                return -EIO;
-
         if (mutex_lock_interruptible(&adapter->mbox_lock))
                 return -1;
 
@@ -695,12 +685,15 @@ err:
 }
 
 /* Uses synchronous MCCQ */
-int be_cmd_pmac_del(struct be_adapter *adapter, u32 if_id, u32 pmac_id, u32 dom)
+int be_cmd_pmac_del(struct be_adapter *adapter, u32 if_id, int pmac_id, u32 dom)
 {
         struct be_mcc_wrb *wrb;
         struct be_cmd_req_pmac_del *req;
         int status;
 
+        if (pmac_id == -1)
+                return 0;
+
         spin_lock_bh(&adapter->mcc_lock);
 
         wrb = wrb_from_mccq(adapter);
@@ -923,10 +916,14 @@ int be_cmd_txq_create(struct be_adapter *adapter,
         void *ctxt;
         int status;
 
-        if (mutex_lock_interruptible(&adapter->mbox_lock))
-                return -1;
+        spin_lock_bh(&adapter->mcc_lock);
+
+        wrb = wrb_from_mccq(adapter);
+        if (!wrb) {
+                status = -EBUSY;
+                goto err;
+        }
 
-        wrb = wrb_from_mbox(adapter);
         req = embedded_payload(wrb);
         ctxt = &req->context;
 
@@ -952,14 +949,15 @@ int be_cmd_txq_create(struct be_adapter *adapter,
 
         be_cmd_page_addrs_prepare(req->pages, ARRAY_SIZE(req->pages), q_mem);
 
-        status = be_mbox_notify_wait(adapter);
+        status = be_mcc_notify_wait(adapter);
         if (!status) {
                 struct be_cmd_resp_eth_tx_create *resp = embedded_payload(wrb);
                 txq->id = le16_to_cpu(resp->cid);
                 txq->created = true;
         }
 
-        mutex_unlock(&adapter->mbox_lock);
+err:
+        spin_unlock_bh(&adapter->mcc_lock);
 
         return status;
 }
@@ -1018,9 +1016,6 @@ int be_cmd_q_destroy(struct be_adapter *adapter, struct be_queue_info *q,
         u8 subsys = 0, opcode = 0;
         int status;
 
-        if (adapter->eeh_err)
-                return -EIO;
-
         if (mutex_lock_interruptible(&adapter->mbox_lock))
                 return -1;
 
@@ -1136,16 +1131,13 @@ err:
 }
 
 /* Uses MCCQ */
-int be_cmd_if_destroy(struct be_adapter *adapter, u32 interface_id, u32 domain)
+int be_cmd_if_destroy(struct be_adapter *adapter, int interface_id, u32 domain)
 {
         struct be_mcc_wrb *wrb;
         struct be_cmd_req_if_destroy *req;
         int status;
 
-        if (adapter->eeh_err)
-                return -EIO;
-
-        if (!interface_id)
+        if (interface_id == -1)
                 return 0;
 
         spin_lock_bh(&adapter->mcc_lock);
@@ -1254,6 +1246,9 @@ int be_cmd_link_status_query(struct be_adapter *adapter, u8 *mac_speed,
         }
         req = embedded_payload(wrb);
 
+        if (lancer_chip(adapter))
+                req->hdr.version = 1;
+
         be_wrb_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
                 OPCODE_COMMON_NTWK_LINK_STATUS_QUERY, sizeof(*req), wrb, NULL);
 
@@ -1836,6 +1831,53 @@ err_unlock:
         return status;
 }
 
+int lancer_cmd_read_object(struct be_adapter *adapter, struct be_dma_mem *cmd,
+                u32 data_size, u32 data_offset, const char *obj_name,
+                u32 *data_read, u32 *eof, u8 *addn_status)
+{
+        struct be_mcc_wrb *wrb;
+        struct lancer_cmd_req_read_object *req;
+        struct lancer_cmd_resp_read_object *resp;
+        int status;
+
+        spin_lock_bh(&adapter->mcc_lock);
+
+        wrb = wrb_from_mccq(adapter);
+        if (!wrb) {
+                status = -EBUSY;
+                goto err_unlock;
+        }
+
+        req = embedded_payload(wrb);
+
+        be_wrb_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
+                        OPCODE_COMMON_READ_OBJECT,
+                        sizeof(struct lancer_cmd_req_read_object), wrb,
+                        NULL);
+
+        req->desired_read_len = cpu_to_le32(data_size);
+        req->read_offset = cpu_to_le32(data_offset);
+        strcpy(req->object_name, obj_name);
+        req->descriptor_count = cpu_to_le32(1);
+        req->buf_len = cpu_to_le32(data_size);
+        req->addr_low = cpu_to_le32((cmd->dma & 0xFFFFFFFF));
+        req->addr_high = cpu_to_le32(upper_32_bits(cmd->dma));
+
+        status = be_mcc_notify_wait(adapter);
+
+        resp = embedded_payload(wrb);
+        if (!status) {
+                *data_read = le32_to_cpu(resp->actual_read_len);
+                *eof = le32_to_cpu(resp->eof);
+        } else {
+                *addn_status = resp->additional_status;
+        }
+
+err_unlock:
+        spin_unlock_bh(&adapter->mcc_lock);
+        return status;
+}
+
 int be_cmd_write_flashrom(struct be_adapter *adapter, struct be_dma_mem *cmd,
                         u32 flash_type, u32 flash_opcode, u32 buf_size)
 {
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
index a35cd03fac4e..ac112465e719 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.h
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
@@ -189,6 +189,7 @@ struct be_mcc_mailbox {
 #define OPCODE_COMMON_GET_PHY_DETAILS                   102
 #define OPCODE_COMMON_SET_DRIVER_FUNCTION_CAP           103
 #define OPCODE_COMMON_GET_CNTL_ADDITIONAL_ATTRIBUTES    121
+#define OPCODE_COMMON_READ_OBJECT                       171
 #define OPCODE_COMMON_WRITE_OBJECT                      172
 
 #define OPCODE_ETH_RSS_CONFIG                           1
@@ -1161,6 +1162,38 @@ struct lancer_cmd_resp_write_object {
         u32 actual_write_len;
 };
 
+/************************ Lancer Read FW info **************/
+#define LANCER_READ_FILE_CHUNK                  (32*1024)
+#define LANCER_READ_FILE_EOF_MASK               0x80000000
+
+#define LANCER_FW_DUMP_FILE                     "/dbg/dump.bin"
+#define LANCER_VPD_PF_FILE                      "/vpd/ntr_pf.vpd"
+#define LANCER_VPD_VF_FILE                      "/vpd/ntr_vf.vpd"
+
+struct lancer_cmd_req_read_object {
+        struct be_cmd_req_hdr hdr;
+        u32 desired_read_len;
+        u32 read_offset;
+        u8 object_name[104];
+        u32 descriptor_count;
+        u32 buf_len;
+        u32 addr_low;
+        u32 addr_high;
+};
+
+struct lancer_cmd_resp_read_object {
+        u8 opcode;
+        u8 subsystem;
+        u8 rsvd1[2];
+        u8 status;
+        u8 additional_status;
+        u8 rsvd2[2];
+        u32 resp_len;
+        u32 actual_resp_len;
+        u32 actual_read_len;
+        u32 eof;
+};
+
 /************************ WOL *******************************/
 struct be_cmd_req_acpi_wol_magic_config{
         struct be_cmd_req_hdr hdr;
@@ -1417,11 +1450,11 @@ extern int be_cmd_mac_addr_query(struct be_adapter *adapter, u8 *mac_addr,
 extern int be_cmd_pmac_add(struct be_adapter *adapter, u8 *mac_addr,
                         u32 if_id, u32 *pmac_id, u32 domain);
 extern int be_cmd_pmac_del(struct be_adapter *adapter, u32 if_id,
-                        u32 pmac_id, u32 domain);
+                        int pmac_id, u32 domain);
 extern int be_cmd_if_create(struct be_adapter *adapter, u32 cap_flags,
                         u32 en_flags, u8 *mac, u32 *if_handle, u32 *pmac_id,
                         u32 domain);
-extern int be_cmd_if_destroy(struct be_adapter *adapter, u32 if_handle,
+extern int be_cmd_if_destroy(struct be_adapter *adapter, int if_handle,
                         u32 domain);
 extern int be_cmd_eq_create(struct be_adapter *adapter,
                         struct be_queue_info *eq, int eq_delay);
@@ -1480,6 +1513,9 @@ extern int lancer_cmd_write_object(struct be_adapter *adapter,
                                 u32 data_size, u32 data_offset,
                                 const char *obj_name,
                                 u32 *data_written, u8 *addn_status);
+int lancer_cmd_read_object(struct be_adapter *adapter, struct be_dma_mem *cmd,
+                u32 data_size, u32 data_offset, const char *obj_name,
+                u32 *data_read, u32 *eof, u8 *addn_status);
 int be_cmd_get_flash_crc(struct be_adapter *adapter, u8 *flashed_crc,
                                 int offset);
 extern int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index bf8153ea4ed8..575c78306313 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -127,8 +127,8 @@ static void be_get_drvinfo(struct net_device *netdev,
         memset(fw_on_flash, 0 , sizeof(fw_on_flash));
         be_cmd_get_fw_ver(adapter, adapter->fw_ver, fw_on_flash);
 
-        strcpy(drvinfo->driver, DRV_NAME);
-        strcpy(drvinfo->version, DRV_VER);
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, DRV_VER, sizeof(drvinfo->version));
         strncpy(drvinfo->fw_version, adapter->fw_ver, FW_VER_LEN);
         if (memcmp(adapter->fw_ver, fw_on_flash, FW_VER_LEN) != 0) {
                 strcat(drvinfo->fw_version, " [");
@@ -136,21 +136,84 @@ static void be_get_drvinfo(struct net_device *netdev,
                 strcat(drvinfo->fw_version, "]");
         }
 
-        strcpy(drvinfo->bus_info, pci_name(adapter->pdev));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->testinfo_len = 0;
         drvinfo->regdump_len = 0;
         drvinfo->eedump_len = 0;
 }
 
+static u32
+lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name)
+{
+        u32 data_read = 0, eof;
+        u8 addn_status;
+        struct be_dma_mem data_len_cmd;
+        int status;
+
+        memset(&data_len_cmd, 0, sizeof(data_len_cmd));
+        /* data_offset and data_size should be 0 to get reg len */
+        status = lancer_cmd_read_object(adapter, &data_len_cmd, 0, 0,
+                                file_name, &data_read, &eof, &addn_status);
+
+        return data_read;
+}
+
+static int
+lancer_cmd_read_file(struct be_adapter *adapter, u8 *file_name,
+                u32 buf_len, void *buf)
+{
+        struct be_dma_mem read_cmd;
+        u32 read_len = 0, total_read_len = 0, chunk_size;
+        u32 eof = 0;
+        u8 addn_status;
+        int status = 0;
+
+        read_cmd.size = LANCER_READ_FILE_CHUNK;
+        read_cmd.va = pci_alloc_consistent(adapter->pdev, read_cmd.size,
+                        &read_cmd.dma);
+
+        if (!read_cmd.va) {
+                dev_err(&adapter->pdev->dev,
+                                "Memory allocation failure while reading dump\n");
+                return -ENOMEM;
+        }
+
+        while ((total_read_len < buf_len) && !eof) {
+                chunk_size = min_t(u32, (buf_len - total_read_len),
+                                LANCER_READ_FILE_CHUNK);
+                chunk_size = ALIGN(chunk_size, 4);
+                status = lancer_cmd_read_object(adapter, &read_cmd, chunk_size,
+                                total_read_len, file_name, &read_len,
+                                &eof, &addn_status);
+                if (!status) {
+                        memcpy(buf + total_read_len, read_cmd.va, read_len);
+                        total_read_len += read_len;
+                        eof &= LANCER_READ_FILE_EOF_MASK;
+                } else {
+                        status = -EIO;
+                        break;
+                }
+        }
+        pci_free_consistent(adapter->pdev, read_cmd.size, read_cmd.va,
+                        read_cmd.dma);
+
+        return status;
+}
+
 static int
 be_get_reg_len(struct net_device *netdev)
 {
         struct be_adapter *adapter = netdev_priv(netdev);
         u32 log_size = 0;
 
-        if (be_physfn(adapter))
-                be_cmd_get_reg_len(adapter, &log_size);
-
+        if (be_physfn(adapter)) {
+                if (lancer_chip(adapter))
+                        log_size = lancer_cmd_get_file_len(adapter,
+                                        LANCER_FW_DUMP_FILE);
+                else
+                        be_cmd_get_reg_len(adapter, &log_size);
+        }
         return log_size;
 }
 
@@ -161,7 +224,11 @@ be_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *buf)
 
         if (be_physfn(adapter)) {
                 memset(buf, 0, regs->len);
-                be_cmd_get_regs(adapter, regs->len, buf);
+                if (lancer_chip(adapter))
+                        lancer_cmd_read_file(adapter, LANCER_FW_DUMP_FILE,
+                                        regs->len, buf);
+                else
+                        be_cmd_get_regs(adapter, regs->len, buf);
         }
 }
 
@@ -660,7 +727,17 @@ be_do_flash(struct net_device *netdev, struct ethtool_flash *efl)
 static int
 be_get_eeprom_len(struct net_device *netdev)
 {
-        return BE_READ_SEEPROM_LEN;
+        struct be_adapter *adapter = netdev_priv(netdev);
+        if (lancer_chip(adapter)) {
+                if (be_physfn(adapter))
+                        return lancer_cmd_get_file_len(adapter,
+                                        LANCER_VPD_PF_FILE);
+                else
+                        return lancer_cmd_get_file_len(adapter,
+                                        LANCER_VPD_VF_FILE);
+        } else {
+                return BE_READ_SEEPROM_LEN;
+        }
 }
 
 static int
@@ -675,6 +752,15 @@ be_read_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom,
         if (!eeprom->len)
                 return -EINVAL;
 
+        if (lancer_chip(adapter)) {
+                if (be_physfn(adapter))
+                        return lancer_cmd_read_file(adapter, LANCER_VPD_PF_FILE,
+                                        eeprom->len, data);
+                else
+                        return lancer_cmd_read_file(adapter, LANCER_VPD_VF_FILE,
+                                        eeprom->len, data);
+        }
+
         eeprom->magic = BE_VENDOR_ID | (adapter->pdev->device<<16);
 
         memset(&eeprom_cmd, 0, sizeof(struct be_dma_mem));
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index bf266a00c774..93869d457b14 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -848,15 +848,11 @@ static int be_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
         if (!is_valid_ether_addr(mac) || (vf >= num_vfs))
                 return -EINVAL;
 
-        if (adapter->vf_cfg[vf].vf_pmac_id != BE_INVALID_PMAC_ID)
-                status = be_cmd_pmac_del(adapter,
-                                        adapter->vf_cfg[vf].vf_if_handle,
-                                        adapter->vf_cfg[vf].vf_pmac_id, vf + 1);
+        status = be_cmd_pmac_del(adapter, adapter->vf_cfg[vf].vf_if_handle,
+                                adapter->vf_cfg[vf].vf_pmac_id, vf + 1);
 
-        status = be_cmd_pmac_add(adapter, mac,
-                                adapter->vf_cfg[vf].vf_if_handle,
+        status = be_cmd_pmac_add(adapter, mac, adapter->vf_cfg[vf].vf_if_handle,
                                 &adapter->vf_cfg[vf].vf_pmac_id, vf + 1);
-
         if (status)
                 dev_err(&adapter->pdev->dev, "MAC %pM set on VF %d Failed\n",
                                 mac, vf);
@@ -1693,9 +1689,6 @@ static int be_tx_queues_create(struct be_adapter *adapter)
                 if (be_queue_alloc(adapter, q, TX_Q_LEN,
                         sizeof(struct be_eth_wrb)))
                         goto err;
-
-                if (be_cmd_txq_create(adapter, q, cq))
-                        goto err;
         }
         return 0;
 
@@ -1982,6 +1975,9 @@ void be_detect_dump_ue(struct be_adapter *adapter)
         u32 sliport_status = 0, sliport_err1 = 0, sliport_err2 = 0;
         u32 i;
 
+        if (adapter->eeh_err || adapter->ue_detected)
+                return;
+
         if (lancer_chip(adapter)) {
                 sliport_status = ioread32(adapter->db + SLIPORT_STATUS_OFFSET);
                 if (sliport_status & SLIPORT_STATUS_ERR_MASK) {
@@ -2008,7 +2004,8 @@ void be_detect_dump_ue(struct be_adapter *adapter)
                 sliport_status & SLIPORT_STATUS_ERR_MASK) {
                 adapter->ue_detected = true;
                 adapter->eeh_err = true;
-                dev_err(&adapter->pdev->dev, "UE Detected!!\n");
+                dev_err(&adapter->pdev->dev,
+                        "Unrecoverable error in the card\n");
         }
 
         if (ue_lo) {
@@ -2043,8 +2040,7 @@ static void be_worker(struct work_struct *work)
         struct be_rx_obj *rxo;
         int i;
 
-        if (!adapter->ue_detected)
-                be_detect_dump_ue(adapter);
+        be_detect_dump_ue(adapter);
 
         /* when interrupts are not yet enabled, just reap any pending
         * mcc completions */
@@ -2488,17 +2484,13 @@ static void be_vf_clear(struct be_adapter *adapter)
 {
         u32 vf;
 
-        for (vf = 0; vf < num_vfs; vf++) {
-                if (adapter->vf_cfg[vf].vf_pmac_id != BE_INVALID_PMAC_ID)
-                        be_cmd_pmac_del(adapter,
-                                        adapter->vf_cfg[vf].vf_if_handle,
-                                        adapter->vf_cfg[vf].vf_pmac_id, vf + 1);
-        }
+        for (vf = 0; vf < num_vfs; vf++)
+                be_cmd_pmac_del(adapter, adapter->vf_cfg[vf].vf_if_handle,
+                                adapter->vf_cfg[vf].vf_pmac_id, vf + 1);
 
         for (vf = 0; vf < num_vfs; vf++)
-                if (adapter->vf_cfg[vf].vf_if_handle)
-                        be_cmd_if_destroy(adapter,
-                                adapter->vf_cfg[vf].vf_if_handle, vf + 1);
+                be_cmd_if_destroy(adapter, adapter->vf_cfg[vf].vf_if_handle,
+                                vf + 1);
 }
 
 static int be_clear(struct be_adapter *adapter)
@@ -2511,22 +2503,30 @@ static int be_clear(struct be_adapter *adapter)
         be_mcc_queues_destroy(adapter);
         be_rx_queues_destroy(adapter);
         be_tx_queues_destroy(adapter);
-        adapter->eq_next_idx = 0;
-
-        adapter->be3_native = false;
-        adapter->promiscuous = false;
 
         /* tell fw we're done with firing cmds */
         be_cmd_fw_clean(adapter);
         return 0;
 }
 
+static void be_vf_setup_init(struct be_adapter *adapter)
+{
+        int vf;
+
+        for (vf = 0; vf < num_vfs; vf++) {
+                adapter->vf_cfg[vf].vf_if_handle = -1;
+                adapter->vf_cfg[vf].vf_pmac_id = -1;
+        }
+}
+
 static int be_vf_setup(struct be_adapter *adapter)
 {
         u32 cap_flags, en_flags, vf;
         u16 lnk_speed;
         int status;
 
+        be_vf_setup_init(adapter);
+
         cap_flags = en_flags = BE_IF_FLAGS_UNTAGGED | BE_IF_FLAGS_BROADCAST;
         for (vf = 0; vf < num_vfs; vf++) {
                 status = be_cmd_if_create(adapter, cap_flags, en_flags, NULL,
@@ -2534,7 +2534,6 @@ static int be_vf_setup(struct be_adapter *adapter)
                                         NULL, vf+1);
                 if (status)
                         goto err;
-                adapter->vf_cfg[vf].vf_pmac_id = BE_INVALID_PMAC_ID;
         }
 
         if (!lancer_chip(adapter)) {
@@ -2555,17 +2554,26 @@ err:
         return status;
 }
 
+static void be_setup_init(struct be_adapter *adapter)
+{
+        adapter->vlan_prio_bmap = 0xff;
+        adapter->link_speed = -1;
+        adapter->if_handle = -1;
+        adapter->be3_native = false;
+        adapter->promiscuous = false;
+        adapter->eq_next_idx = 0;
+}
+
 static int be_setup(struct be_adapter *adapter)
 {
         struct net_device *netdev = adapter->netdev;
         u32 cap_flags, en_flags;
         u32 tx_fc, rx_fc;
-        int status;
+        int status, i;
         u8 mac[ETH_ALEN];
+        struct be_tx_obj *txo;
 
-        /* Allow all priorities by default. A GRP5 evt may modify this */
-        adapter->vlan_prio_bmap = 0xff;
-        adapter->link_speed = -1;
+        be_setup_init(adapter);
 
         be_cmd_req_native_mode(adapter);
 
@@ -2592,7 +2600,8 @@ static int be_setup(struct be_adapter *adapter)
         en_flags = BE_IF_FLAGS_UNTAGGED | BE_IF_FLAGS_BROADCAST |
                         BE_IF_FLAGS_MULTICAST | BE_IF_FLAGS_PASS_L3L4_ERRORS;
         cap_flags = en_flags | BE_IF_FLAGS_MCAST_PROMISCUOUS |
-                        BE_IF_FLAGS_PROMISCUOUS;
+                        BE_IF_FLAGS_VLAN_PROMISCUOUS | BE_IF_FLAGS_PROMISCUOUS;
+
         if (adapter->function_caps & BE_FUNCTION_CAPS_RSS) {
                 cap_flags |= BE_IF_FLAGS_RSS;
                 en_flags |= BE_IF_FLAGS_RSS;
@@ -2603,6 +2612,12 @@ static int be_setup(struct be_adapter *adapter)
         if (status != 0)
                 goto err;
 
+         for_all_tx_queues(adapter, txo, i) {
+                status = be_cmd_txq_create(adapter, &txo->q, &txo->cq);
+                if (status)
+                        goto err;
+        }
+
         /* For BEx, the VF's permanent mac queried from card is incorrect.
          * Query the mac configued by the PF using if_handle
          */
@@ -3559,6 +3574,8 @@ static pci_ers_result_t be_eeh_reset(struct pci_dev *pdev)
 
         dev_info(&adapter->pdev->dev, "EEH reset\n");
         adapter->eeh_err = false;
+        adapter->ue_detected = false;
+        adapter->fw_timeout = false;
 
         status = pci_enable_device(pdev);
         if (status)
diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
index 61d2bddec1fa..c82d444b582d 100644
--- a/drivers/net/ethernet/fealnx.c
+++ b/drivers/net/ethernet/fealnx.c
@@ -1818,9 +1818,9 @@ static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *i
 {
         struct netdev_private *np = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 52f4e8ad48e7..8dee1aed47e4 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -183,28 +183,10 @@ void fsl_pq_mdio_bus_name(char *name, struct device_node *np)
 }
 EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);
 
-/* Scan the bus in reverse, looking for an empty spot */
-static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
-{
-        int i;
-
-        for (i = PHY_MAX_ADDR; i > 0; i--) {
-                u32 phy_id;
-
-                if (get_phy_id(new_bus, i, &phy_id))
-                        return -1;
-
-                if (phy_id == 0xffffffff)
-                        break;
-        }
-
-        return i;
-}
 
-
-#if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE)
 static u32 __iomem *get_gfar_tbipa(struct fsl_pq_mdio __iomem *regs, struct device_node *np)
 {
+#if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE)
         struct gfar __iomem *enet_regs;
 
         /*
@@ -220,15 +202,15 @@ static u32 __iomem *get_gfar_tbipa(struct fsl_pq_mdio __iomem *regs, struct devi
         } else if (of_device_is_compatible(np, "fsl,etsec2-mdio") ||
                         of_device_is_compatible(np, "fsl,etsec2-tbi")) {
                 return of_iomap(np, 1);
-        } else
-                return NULL;
-}
+        }
 #endif
+        return NULL;
+}
 
 
-#if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE)
 static int get_ucc_id_for_range(u64 start, u64 end, u32 *ucc_id)
 {
+#if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE)
         struct device_node *np = NULL;
         int err = 0;
 
@@ -261,9 +243,10 @@ static int get_ucc_id_for_range(u64 start, u64 end, u32 *ucc_id)
                 return err;
         else
                 return -EINVAL;
-}
+#else
+        return -ENODEV;
 #endif
-
+}
 
 static int fsl_pq_mdio_probe(struct platform_device *ofdev)
 {
@@ -339,19 +322,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
                         of_device_is_compatible(np, "fsl,etsec2-mdio") ||
                         of_device_is_compatible(np, "fsl,etsec2-tbi") ||
                         of_device_is_compatible(np, "gianfar")) {
-#if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE)
                 tbipa = get_gfar_tbipa(regs, np);
                 if (!tbipa) {
                         err = -EINVAL;
                         goto err_free_irqs;
                 }
-#else
-                err = -ENODEV;
-                goto err_free_irqs;
-#endif
         } else if (of_device_is_compatible(np, "fsl,ucc-mdio") ||
                         of_device_is_compatible(np, "ucc_geth_phy")) {
-#if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE)
                 u32 id;
                 static u32 mii_mng_master;
 
@@ -364,10 +341,6 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
                         mii_mng_master = id;
                         ucc_set_qe_mux_mii_mng(id - 1);
                 }
-#else
-                err = -ENODEV;
-                goto err_free_irqs;
-#endif
         } else {
                 err = -ENODEV;
                 goto err_free_irqs;
@@ -383,26 +356,16 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
 
                 if (prop)
                         tbiaddr = *prop;
-        }
-
-        if (tbiaddr == -1) {
-                out_be32(tbipa, 0);
 
-                tbiaddr = fsl_pq_mdio_find_free(new_bus);
-        }
-
-        /*
-         * We define TBIPA at 0 to be illegal, opting to fail for boards that
-         * have PHYs at 1-31, rather than change tbipa and rescan.
-         */
-        if (tbiaddr == 0) {
-                err = -EBUSY;
+                if (tbiaddr == -1) {
+                        err = -EBUSY;
 
-                goto err_free_irqs;
+                        goto err_free_irqs;
+                } else {
+                        out_be32(tbipa, tbiaddr);
+                }
         }
 
-        out_be32(tbipa, tbiaddr);
-
         err = of_mdiobus_register(new_bus, np);
         if (err) {
                 printk (KERN_ERR "%s: Cannot register as MDIO bus\n",
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 83199fd0d62b..8e21ceb3b7da 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -734,7 +734,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
 
         mac_addr = of_get_mac_address(np);
         if (mac_addr)
-                memcpy(dev->dev_addr, mac_addr, MAC_ADDR_LEN);
+                memcpy(dev->dev_addr, mac_addr, ETH_ALEN);
 
         if (model && !strcasecmp(model, "TSEC"))
                 priv->device_flags =
@@ -2306,7 +2306,7 @@ void gfar_check_rx_parser_mode(struct gfar_private *priv)
 }
 
 /* Enables and disables VLAN insertion/extraction */
-void gfar_vlan_mode(struct net_device *dev, u32 features)
+void gfar_vlan_mode(struct net_device *dev, netdev_features_t features)
 {
         struct gfar_private *priv = netdev_priv(dev);
         struct gfar __iomem *regs = NULL;
@@ -3114,7 +3114,7 @@ static void gfar_set_multi(struct net_device *dev)
 static void gfar_clear_exact_match(struct net_device *dev)
 {
         int idx;
-        static const u8 zero_arr[MAC_ADDR_LEN] = {0, 0, 0, 0, 0, 0};
+        static const u8 zero_arr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
 
         for(idx = 1;idx < GFAR_EM_NUM + 1;idx++)
                 gfar_set_mac_for_addr(dev, idx, zero_arr);
@@ -3137,7 +3137,7 @@ static void gfar_set_hash_for_addr(struct net_device *dev, u8 *addr)
 {
         u32 tempval;
         struct gfar_private *priv = netdev_priv(dev);
-        u32 result = ether_crc(MAC_ADDR_LEN, addr);
+        u32 result = ether_crc(ETH_ALEN, addr);
         int width = priv->hash_width;
         u8 whichbit = (result >> (32 - width)) & 0x1f;
         u8 whichreg = result >> (32 - width + 5);
@@ -3158,7 +3158,7 @@ static void gfar_set_mac_for_addr(struct net_device *dev, int num,
         struct gfar_private *priv = netdev_priv(dev);
         struct gfar __iomem *regs = priv->gfargrp[0].regs;
         int idx;
-        char tmpbuf[MAC_ADDR_LEN];
+        char tmpbuf[ETH_ALEN];
         u32 tempval;
         u32 __iomem *macptr = &regs->macstnaddr1;
 
@@ -3166,8 +3166,8 @@ static void gfar_set_mac_for_addr(struct net_device *dev, int num,
 
         /* Now copy it into the mac registers backwards, cuz */
         /* little endian is silly */
-        for (idx = 0; idx < MAC_ADDR_LEN; idx++)
-                tmpbuf[MAC_ADDR_LEN - 1 - idx] = addr[idx];
+        for (idx = 0; idx < ETH_ALEN; idx++)
+                tmpbuf[ETH_ALEN - 1 - idx] = addr[idx];
 
         gfar_write(macptr, *((u32 *) (tmpbuf)));
 
diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h
index 9aa43773e8e3..fe7ac3a83194 100644
--- a/drivers/net/ethernet/freescale/gianfar.h
+++ b/drivers/net/ethernet/freescale/gianfar.h
@@ -74,9 +74,6 @@ struct ethtool_rx_list {
  * will be the next highest multiple of 512 bytes. */
 #define INCREMENTAL_BUFFER_SIZE 512
 
-
-#define MAC_ADDR_LEN 6
-
 #define PHY_INIT_TIMEOUT 100000
 #define GFAR_PHY_CHANGE_TIME 2
 
@@ -1179,9 +1176,9 @@ extern void gfar_phy_test(struct mii_bus *bus, struct phy_device *phydev,
 extern void gfar_configure_coalescing(struct gfar_private *priv,
                 unsigned long tx_mask, unsigned long rx_mask);
 void gfar_init_sysfs(struct net_device *dev);
-int gfar_set_features(struct net_device *dev, u32 features);
+int gfar_set_features(struct net_device *dev, netdev_features_t features);
 extern void gfar_check_rx_parser_mode(struct gfar_private *priv);
-extern void gfar_vlan_mode(struct net_device *dev, u32 features);
+extern void gfar_vlan_mode(struct net_device *dev, netdev_features_t features);
 
 extern const struct ethtool_ops gfar_ethtool_ops;
 
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
index 212736bab6bb..1ea0eb9ee643 100644
--- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
@@ -519,12 +519,12 @@ static int gfar_sringparam(struct net_device *dev, struct ethtool_ringparam *rva
         return err;
 }
 
-int gfar_set_features(struct net_device *dev, u32 features)
+int gfar_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct gfar_private *priv = netdev_priv(dev);
         unsigned long flags;
         int err = 0, i = 0;
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if (changed & (NETIF_F_HW_VLAN_TX|NETIF_F_HW_VLAN_RX))
                 gfar_vlan_mode(dev, features);
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index b5dc0273a1d1..ba2dc083bfc0 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -443,7 +443,7 @@ static void hw_add_addr_in_hash(struct ucc_geth_private *ugeth,
 
 static inline int compare_addr(u8 **addr1, u8 **addr2)
 {
-        return memcmp(addr1, addr2, ENET_NUM_OCTETS_PER_ADDRESS);
+        return memcmp(addr1, addr2, ETH_ALEN);
 }
 
 #ifdef DEBUG
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index d12fcad145e9..2e395a2566b8 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h
@@ -20,6 +20,7 @@
 
 #include <linux/kernel.h>
 #include <linux/list.h>
+#include <linux/if_ether.h>
 
 #include <asm/immap_qe.h>
 #include <asm/qe.h>
@@ -881,7 +882,6 @@ struct ucc_geth_hardware_statistics {
 #define TX_RING_MOD_MASK(size)                  (size-1)
 #define RX_RING_MOD_MASK(size)                  (size-1)
 
-#define ENET_NUM_OCTETS_PER_ADDRESS             6
 #define ENET_GROUP_ADDR                         0x01    /* Group address mask
                                                            for ethernet
                                                            addresses */
@@ -1051,7 +1051,7 @@ enum ucc_geth_num_of_station_addresses {
 
 /* UCC GETH 82xx Ethernet Address Container */
 struct enet_addr_container {
-        u8 address[ENET_NUM_OCTETS_PER_ADDRESS];        /* ethernet address */
+        u8 address[ETH_ALEN];   /* ethernet address */
         enum ucc_geth_enet_address_recognition_location location;       /* location in
                                                                    82xx address
                                                                    recognition
@@ -1194,7 +1194,7 @@ struct ucc_geth_private {
         u16 cpucount[NUM_TX_QUEUES];
         u16 __iomem *p_cpucount[NUM_TX_QUEUES];
         int indAddrRegUsed[NUM_OF_PADDRS];
-        u8 paddr[NUM_OF_PADDRS][ENET_NUM_OCTETS_PER_ADDRESS];   /* ethernet address */
+        u8 paddr[NUM_OF_PADDRS][ETH_ALEN];      /* ethernet address */
         u8 numGroupAddrInHash;
         u8 numIndAddrInHash;
         u8 numIndAddrInReg;
diff --git a/drivers/net/ethernet/fujitsu/fmvj18x_cs.c b/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
index 15416752c13e..ee84b472cee6 100644
--- a/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
+++ b/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
@@ -1058,9 +1058,10 @@ static void fjn_rx(struct net_device *dev)
 static void netdev_get_drvinfo(struct net_device *dev,
                                struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        sprintf(info->bus_info, "PCMCIA 0x%lx", dev->base_addr);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        snprintf(info->bus_info, sizeof(info->bus_info),
+                "PCMCIA 0x%lx", dev->base_addr);
 }
 
 static const struct ethtool_ops netdev_ethtool_ops = {
diff --git a/drivers/net/ethernet/i825xx/eepro.c b/drivers/net/ethernet/i825xx/eepro.c
index 067c46069a11..114cda7721fe 100644
--- a/drivers/net/ethernet/i825xx/eepro.c
+++ b/drivers/net/ethernet/i825xx/eepro.c
@@ -1726,9 +1726,10 @@ static int eepro_ethtool_get_settings(struct net_device *dev,
 static void eepro_ethtool_get_drvinfo(struct net_device *dev,
                                         struct ethtool_drvinfo *drvinfo)
 {
-        strcpy(drvinfo->driver, DRV_NAME);
-        strcpy(drvinfo->version, DRV_VERSION);
-        sprintf(drvinfo->bus_info, "ISA 0x%lx", dev->base_addr);
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
+        snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info),
+                "ISA 0x%lx", dev->base_addr);
 }
 
 static const struct ethtool_ops eepro_ethtool_ops = {
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index ed79b2d3ad3e..2abce965c7bd 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -2924,6 +2924,9 @@ static int __devexit emac_remove(struct platform_device *ofdev)
         if (emac_has_feature(dev, EMAC_FTR_HAS_ZMII))
                 zmii_detach(dev->zmii_dev, dev->zmii_port);
 
+        busy_phy_map &= ~(1 << dev->phy.address);
+        DBG(dev, "busy_phy_map now %#x" NL, busy_phy_map);
+
         mal_unregister_commac(dev->mal, &dev->commac);
         emac_put_deps(dev);
 
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index b1cd41b9c61c..e877371680a9 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -735,7 +735,8 @@ static void netdev_get_drvinfo(struct net_device *dev,
                 sizeof(info->version) - 1);
 }
 
-static u32 ibmveth_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t ibmveth_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         /*
          * Since the ibmveth firmware interface does not have the
@@ -838,7 +839,8 @@ static int ibmveth_set_csum_offload(struct net_device *dev, u32 data)
         return rc1 ? rc1 : rc2;
 }
 
-static int ibmveth_set_features(struct net_device *dev, u32 features)
+static int ibmveth_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct ibmveth_adapter *adapter = netdev_priv(dev);
         int rx_csum = !!(features & NETIF_F_RXCSUM);
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 5a2fdf7a00c8..46003278ffa0 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -2376,10 +2376,11 @@ static void e100_get_drvinfo(struct net_device *netdev,
         struct ethtool_drvinfo *info)
 {
         struct nic *nic = netdev_priv(netdev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
-        strcpy(info->bus_info, pci_name(nic->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(nic->pdev),
+                sizeof(info->bus_info));
 }
 
 #define E100_PHY_REGS 0x1C
diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
index 2b223ac99c42..63faec693deb 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
@@ -515,14 +515,15 @@ static void e1000_get_drvinfo(struct net_device *netdev,
                               struct ethtool_drvinfo *drvinfo)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
-        char firmware_version[32];
 
-        strncpy(drvinfo->driver,  e1000_driver_name, 32);
-        strncpy(drvinfo->version, e1000_driver_version, 32);
+        strlcpy(drvinfo->driver,  e1000_driver_name,
+                sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, e1000_driver_version,
+                sizeof(drvinfo->version));
 
-        sprintf(firmware_version, "N/A");
-        strncpy(drvinfo->fw_version, firmware_version, 32);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = e1000_get_regs_len(netdev);
         drvinfo->eedump_len = e1000_get_eeprom_len(netdev);
 }
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.h b/drivers/net/ethernet/intel/e1000/e1000_hw.h
index 5c9a8403668b..cf7e3c094477 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_hw.h
+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.h
@@ -448,7 +448,6 @@ void e1000_io_write(struct e1000_hw *hw, unsigned long port, u32 value);
 #define E1000_DEV_ID_INTEL_CE4100_GBE    0x2E6E
 
 #define NODE_ADDRESS_SIZE 6
-#define ETH_LENGTH_OF_ADDRESS 6
 
 /* MAC decode size is 128K - This is the size of BAR0 */
 #define MAC_DECODE_SIZE (128 * 1024)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index cf480b554622..82f4ef142259 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -167,7 +167,8 @@ static int e1000_82547_fifo_workaround(struct e1000_adapter *adapter,
                                        struct sk_buff *skb);
 
 static bool e1000_vlan_used(struct e1000_adapter *adapter);
-static void e1000_vlan_mode(struct net_device *netdev, u32 features);
+static void e1000_vlan_mode(struct net_device *netdev,
+                            netdev_features_t features);
 static void e1000_vlan_rx_add_vid(struct net_device *netdev, u16 vid);
 static void e1000_vlan_rx_kill_vid(struct net_device *netdev, u16 vid);
 static void e1000_restore_vlan(struct e1000_adapter *adapter);
@@ -806,7 +807,8 @@ static int e1000_is_need_ioport(struct pci_dev *pdev)
         }
 }
 
-static u32 e1000_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t e1000_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -820,10 +822,11 @@ static u32 e1000_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int e1000_set_features(struct net_device *netdev, u32 features)
+static int e1000_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
-        u32 changed = features ^ netdev->features;
+        netdev_features_t changed = features ^ netdev->features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 e1000_vlan_mode(netdev, features);
@@ -4577,7 +4580,8 @@ static void e1000_vlan_filter_on_off(struct e1000_adapter *adapter,
                 e1000_irq_enable(adapter);
 }
 
-static void e1000_vlan_mode(struct net_device *netdev, u32 features)
+static void e1000_vlan_mode(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
         struct e1000_hw *hw = &adapter->hw;
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c
index 69c9d2199140..fb2c28e799a2 100644
--- a/drivers/net/ethernet/intel/e1000e/ethtool.c
+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c
@@ -579,26 +579,24 @@ static void e1000_get_drvinfo(struct net_device *netdev,
                               struct ethtool_drvinfo *drvinfo)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
-        char firmware_version[32];
 
-        strncpy(drvinfo->driver,  e1000e_driver_name,
-                sizeof(drvinfo->driver) - 1);
-        strncpy(drvinfo->version, e1000e_driver_version,
-                sizeof(drvinfo->version) - 1);
+        strlcpy(drvinfo->driver,  e1000e_driver_name,
+                sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, e1000e_driver_version,
+                sizeof(drvinfo->version));
 
         /*
          * EEPROM image version # is reported as firmware version # for
          * PCI-E controllers
          */
-        snprintf(firmware_version, sizeof(firmware_version), "%d.%d-%d",
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                "%d.%d-%d",
                 (adapter->eeprom_vers & 0xF000) >> 12,
                 (adapter->eeprom_vers & 0x0FF0) >> 4,
                 (adapter->eeprom_vers & 0x000F));
 
-        strncpy(drvinfo->fw_version, firmware_version,
-                sizeof(drvinfo->fw_version) - 1);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev),
-                sizeof(drvinfo->bus_info) - 1);
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = e1000_get_regs_len(netdev);
         drvinfo->eedump_len = e1000_get_eeprom_len(netdev);
 }
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index a855db1ad249..a5bd7a3dafc9 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -163,16 +163,13 @@ static void e1000_regdump(struct e1000_hw *hw, struct e1000_reg_info *reginfo)
                         regs[n] = __er32(hw, E1000_TARC(n));
                 break;
         default:
-                printk(KERN_INFO "%-15s %08x\n",
-                       reginfo->name, __er32(hw, reginfo->ofs));
+                pr_info("%-15s %08x\n",
+                        reginfo->name, __er32(hw, reginfo->ofs));
                 return;
         }
 
         snprintf(rname, 16, "%s%s", reginfo->name, "[0-1]");
-        printk(KERN_INFO "%-15s ", rname);
-        for (n = 0; n < 2; n++)
-                printk(KERN_CONT "%08x ", regs[n]);
-        printk(KERN_CONT "\n");
+        pr_info("%-15s %08x %08x\n", rname, regs[0], regs[1]);
 }
 
 /*
@@ -208,16 +205,15 @@ static void e1000e_dump(struct e1000_adapter *adapter)
         /* Print netdevice Info */
         if (netdev) {
                 dev_info(&adapter->pdev->dev, "Net device Info\n");
-                printk(KERN_INFO "Device Name     state            "
-                       "trans_start      last_rx\n");
-                printk(KERN_INFO "%-15s %016lX %016lX %016lX\n",
-                       netdev->name, netdev->state, netdev->trans_start,
-                       netdev->last_rx);
+                pr_info("Device Name     state            trans_start      last_rx\n");
+                pr_info("%-15s %016lX %016lX %016lX\n",
+                        netdev->name, netdev->state, netdev->trans_start,
+                        netdev->last_rx);
         }
 
         /* Print Registers */
         dev_info(&adapter->pdev->dev, "Register Dump\n");
-        printk(KERN_INFO " Register Name   Value\n");
+        pr_info(" Register Name   Value\n");
         for (reginfo = (struct e1000_reg_info *)e1000_reg_info_tbl;
              reginfo->name; reginfo++) {
                 e1000_regdump(hw, reginfo);
@@ -228,15 +224,14 @@ static void e1000e_dump(struct e1000_adapter *adapter)
                 goto exit;
 
         dev_info(&adapter->pdev->dev, "Tx Ring Summary\n");
-        printk(KERN_INFO "Queue [NTU] [NTC] [bi(ntc)->dma  ]"
-               " leng ntw timestamp\n");
+        pr_info("Queue [NTU] [NTC] [bi(ntc)->dma  ] leng ntw timestamp\n");
         buffer_info = &tx_ring->buffer_info[tx_ring->next_to_clean];
-        printk(KERN_INFO " %5d %5X %5X %016llX %04X %3X %016llX\n",
-               0, tx_ring->next_to_use, tx_ring->next_to_clean,
-               (unsigned long long)buffer_info->dma,
-               buffer_info->length,
-               buffer_info->next_to_watch,
-               (unsigned long long)buffer_info->time_stamp);
+        pr_info(" %5d %5X %5X %016llX %04X %3X %016llX\n",
+                0, tx_ring->next_to_use, tx_ring->next_to_clean,
+                (unsigned long long)buffer_info->dma,
+                buffer_info->length,
+                buffer_info->next_to_watch,
+                (unsigned long long)buffer_info->time_stamp);
 
         /* Print Tx Ring */
         if (!netif_msg_tx_done(adapter))
@@ -271,37 +266,32 @@ static void e1000e_dump(struct e1000_adapter *adapter)
          *   +----------------------------------------------------------------+
          *   63       48 47     40 39  36 35    32 31     24 23  20 19        0
          */
-        printk(KERN_INFO "Tl[desc]     [address 63:0  ] [SpeCssSCmCsLen]"
-               " [bi->dma       ] leng  ntw timestamp        bi->skb "
-               "<-- Legacy format\n");
-        printk(KERN_INFO "Tc[desc]     [Ce CoCsIpceCoS] [MssHlRSCm0Plen]"
-               " [bi->dma       ] leng  ntw timestamp        bi->skb "
-               "<-- Ext Context format\n");
-        printk(KERN_INFO "Td[desc]     [address 63:0  ] [VlaPoRSCm1Dlen]"
-               " [bi->dma       ] leng  ntw timestamp        bi->skb "
-               "<-- Ext Data format\n");
+        pr_info("Tl[desc]     [address 63:0  ] [SpeCssSCmCsLen] [bi->dma       ] leng  ntw timestamp        bi->skb <-- Legacy format\n");
+        pr_info("Tc[desc]     [Ce CoCsIpceCoS] [MssHlRSCm0Plen] [bi->dma       ] leng  ntw timestamp        bi->skb <-- Ext Context format\n");
+        pr_info("Td[desc]     [address 63:0  ] [VlaPoRSCm1Dlen] [bi->dma       ] leng  ntw timestamp        bi->skb <-- Ext Data format\n");
         for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
+                const char *next_desc;
                 tx_desc = E1000_TX_DESC(*tx_ring, i);
                 buffer_info = &tx_ring->buffer_info[i];
                 u0 = (struct my_u0 *)tx_desc;
-                printk(KERN_INFO "T%c[0x%03X]    %016llX %016llX %016llX "
-                       "%04X  %3X %016llX %p",
-                       (!(le64_to_cpu(u0->b) & (1 << 29)) ? 'l' :
-                        ((le64_to_cpu(u0->b) & (1 << 20)) ? 'd' : 'c')), i,
-                       (unsigned long long)le64_to_cpu(u0->a),
-                       (unsigned long long)le64_to_cpu(u0->b),
-                       (unsigned long long)buffer_info->dma,
-                       buffer_info->length, buffer_info->next_to_watch,
-                       (unsigned long long)buffer_info->time_stamp,
-                       buffer_info->skb);
                 if (i == tx_ring->next_to_use && i == tx_ring->next_to_clean)
-                        printk(KERN_CONT " NTC/U\n");
+                        next_desc = " NTC/U";
                 else if (i == tx_ring->next_to_use)
-                        printk(KERN_CONT " NTU\n");
+                        next_desc = " NTU";
                 else if (i == tx_ring->next_to_clean)
-                        printk(KERN_CONT " NTC\n");
+                        next_desc = " NTC";
                 else
-                        printk(KERN_CONT "\n");
+                        next_desc = "";
+                pr_info("T%c[0x%03X]    %016llX %016llX %016llX %04X  %3X %016llX %p%s\n",
+                        (!(le64_to_cpu(u0->b) & (1 << 29)) ? 'l' :
+                         ((le64_to_cpu(u0->b) & (1 << 20)) ? 'd' : 'c')),
+                        i,
+                        (unsigned long long)le64_to_cpu(u0->a),
+                        (unsigned long long)le64_to_cpu(u0->b),
+                        (unsigned long long)buffer_info->dma,
+                        buffer_info->length, buffer_info->next_to_watch,
+                        (unsigned long long)buffer_info->time_stamp,
+                        buffer_info->skb, next_desc);
 
                 if (netif_msg_pktdata(adapter) && buffer_info->dma != 0)
                         print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS,
@@ -312,9 +302,9 @@ static void e1000e_dump(struct e1000_adapter *adapter)
         /* Print Rx Ring Summary */
 rx_ring_summary:
         dev_info(&adapter->pdev->dev, "Rx Ring Summary\n");
-        printk(KERN_INFO "Queue [NTU] [NTC]\n");
-        printk(KERN_INFO " %5d %5X %5X\n", 0,
-               rx_ring->next_to_use, rx_ring->next_to_clean);
+        pr_info("Queue [NTU] [NTC]\n");
+        pr_info(" %5d %5X %5X\n",
+                0, rx_ring->next_to_use, rx_ring->next_to_clean);
 
         /* Print Rx Ring */
         if (!netif_msg_rx_status(adapter))
@@ -337,10 +327,7 @@ rx_ring_summary:
                  * 24 |                Buffer Address 3 [63:0]              |
                  *    +-----------------------------------------------------+
                  */
-                printk(KERN_INFO "R  [desc]      [buffer 0 63:0 ] "
-                       "[buffer 1 63:0 ] "
-                       "[buffer 2 63:0 ] [buffer 3 63:0 ] [bi->dma       ] "
-                       "[bi->skb] <-- Ext Pkt Split format\n");
+                pr_info("R  [desc]      [buffer 0 63:0 ] [buffer 1 63:0 ] [buffer 2 63:0 ] [buffer 3 63:0 ] [bi->dma       ] [bi->skb] <-- Ext Pkt Split format\n");
                 /* [Extended] Receive Descriptor (Write-Back) Format
                  *
                  *   63       48 47    32 31     13 12    8 7    4 3        0
@@ -352,35 +339,40 @@ rx_ring_summary:
                  *   +------------------------------------------------------+
                  *   63       48 47    32 31            20 19               0
                  */
-                printk(KERN_INFO "RWB[desc]      [ck ipid mrqhsh] "
-                       "[vl   l0 ee  es] "
-                       "[ l3  l2  l1 hs] [reserved      ] ---------------- "
-                       "[bi->skb] <-- Ext Rx Write-Back format\n");
+                pr_info("RWB[desc]      [ck ipid mrqhsh] [vl   l0 ee  es] [ l3  l2  l1 hs] [reserved      ] ---------------- [bi->skb] <-- Ext Rx Write-Back format\n");
                 for (i = 0; i < rx_ring->count; i++) {
+                        const char *next_desc;
                         buffer_info = &rx_ring->buffer_info[i];
                         rx_desc_ps = E1000_RX_DESC_PS(*rx_ring, i);
                         u1 = (struct my_u1 *)rx_desc_ps;
                         staterr =
                             le32_to_cpu(rx_desc_ps->wb.middle.status_error);
+
+                        if (i == rx_ring->next_to_use)
+                                next_desc = " NTU";
+                        else if (i == rx_ring->next_to_clean)
+                                next_desc = " NTC";
+                        else
+                                next_desc = "";
+
                         if (staterr & E1000_RXD_STAT_DD) {
                                 /* Descriptor Done */
-                                printk(KERN_INFO "RWB[0x%03X]     %016llX "
-                                       "%016llX %016llX %016llX "
-                                       "---------------- %p", i,
-                                       (unsigned long long)le64_to_cpu(u1->a),
-                                       (unsigned long long)le64_to_cpu(u1->b),
-                                       (unsigned long long)le64_to_cpu(u1->c),
-                                       (unsigned long long)le64_to_cpu(u1->d),
-                                       buffer_info->skb);
+                                pr_info("%s[0x%03X]     %016llX %016llX %016llX %016llX ---------------- %p%s\n",
+                                        "RWB", i,
+                                        (unsigned long long)le64_to_cpu(u1->a),
+                                        (unsigned long long)le64_to_cpu(u1->b),
+                                        (unsigned long long)le64_to_cpu(u1->c),
+                                        (unsigned long long)le64_to_cpu(u1->d),
+                                        buffer_info->skb, next_desc);
                         } else {
-                                printk(KERN_INFO "R  [0x%03X]     %016llX "
-                                       "%016llX %016llX %016llX %016llX %p", i,
-                                       (unsigned long long)le64_to_cpu(u1->a),
-                                       (unsigned long long)le64_to_cpu(u1->b),
-                                       (unsigned long long)le64_to_cpu(u1->c),
-                                       (unsigned long long)le64_to_cpu(u1->d),
-                                       (unsigned long long)buffer_info->dma,
-                                       buffer_info->skb);
+                                pr_info("%s[0x%03X]     %016llX %016llX %016llX %016llX %016llX %p%s\n",
+                                        "R  ", i,
+                                        (unsigned long long)le64_to_cpu(u1->a),
+                                        (unsigned long long)le64_to_cpu(u1->b),
+                                        (unsigned long long)le64_to_cpu(u1->c),
+                                        (unsigned long long)le64_to_cpu(u1->d),
+                                        (unsigned long long)buffer_info->dma,
+                                        buffer_info->skb, next_desc);
 
                                 if (netif_msg_pktdata(adapter))
                                         print_hex_dump(KERN_INFO, "",
@@ -388,13 +380,6 @@ rx_ring_summary:
                                                 phys_to_virt(buffer_info->dma),
                                                 adapter->rx_ps_bsize0, true);
                         }
-
-                        if (i == rx_ring->next_to_use)
-                                printk(KERN_CONT " NTU\n");
-                        else if (i == rx_ring->next_to_clean)
-                                printk(KERN_CONT " NTC\n");
-                        else
-                                printk(KERN_CONT "\n");
                 }
                 break;
         default:
@@ -407,9 +392,7 @@ rx_ring_summary:
                  * 8 |                      Reserved                       |
                  *   +-----------------------------------------------------+
                  */
-                printk(KERN_INFO "R  [desc]      [buf addr 63:0 ] "
-                       "[reserved 63:0 ] [bi->dma       ] "
-                       "[bi->skb] <-- Ext (Read) format\n");
+                pr_info("R  [desc]      [buf addr 63:0 ] [reserved 63:0 ] [bi->dma       ] [bi->skb] <-- Ext (Read) format\n");
                 /* Extended Receive Descriptor (Write-Back) Format
                  *
                  *   63       48 47    32 31    24 23            4 3        0
@@ -423,29 +406,37 @@ rx_ring_summary:
                  *   +------------------------------------------------------+
                  *   63       48 47    32 31            20 19               0
                  */
-                printk(KERN_INFO "RWB[desc]      [cs ipid    mrq] "
-                       "[vt   ln xe  xs] "
-                       "[bi->skb] <-- Ext (Write-Back) format\n");
+                pr_info("RWB[desc]      [cs ipid    mrq] [vt   ln xe  xs] [bi->skb] <-- Ext (Write-Back) format\n");
 
                 for (i = 0; i < rx_ring->count; i++) {
+                        const char *next_desc;
+
                         buffer_info = &rx_ring->buffer_info[i];
                         rx_desc = E1000_RX_DESC_EXT(*rx_ring, i);
                         u1 = (struct my_u1 *)rx_desc;
                         staterr = le32_to_cpu(rx_desc->wb.upper.status_error);
+
+                        if (i == rx_ring->next_to_use)
+                                next_desc = " NTU";
+                        else if (i == rx_ring->next_to_clean)
+                                next_desc = " NTC";
+                        else
+                                next_desc = "";
+
                         if (staterr & E1000_RXD_STAT_DD) {
                                 /* Descriptor Done */
-                                printk(KERN_INFO "RWB[0x%03X]     %016llX "
-                                       "%016llX ---------------- %p", i,
-                                       (unsigned long long)le64_to_cpu(u1->a),
-                                       (unsigned long long)le64_to_cpu(u1->b),
-                                       buffer_info->skb);
+                                pr_info("%s[0x%03X]     %016llX %016llX ---------------- %p%s\n",
+                                        "RWB", i,
+                                        (unsigned long long)le64_to_cpu(u1->a),
+                                        (unsigned long long)le64_to_cpu(u1->b),
+                                        buffer_info->skb, next_desc);
                         } else {
-                                printk(KERN_INFO "R  [0x%03X]     %016llX "
-                                       "%016llX %016llX %p", i,
-                                       (unsigned long long)le64_to_cpu(u1->a),
-                                       (unsigned long long)le64_to_cpu(u1->b),
-                                       (unsigned long long)buffer_info->dma,
-                                       buffer_info->skb);
+                                pr_info("%s[0x%03X]     %016llX %016llX %016llX %p%s\n",
+                                        "R  ", i,
+                                        (unsigned long long)le64_to_cpu(u1->a),
+                                        (unsigned long long)le64_to_cpu(u1->b),
+                                        (unsigned long long)buffer_info->dma,
+                                        buffer_info->skb, next_desc);
 
                                 if (netif_msg_pktdata(adapter))
                                         print_hex_dump(KERN_INFO, "",
@@ -456,13 +447,6 @@ rx_ring_summary:
                                                        adapter->rx_buffer_len,
                                                        true);
                         }
-
-                        if (i == rx_ring->next_to_use)
-                                printk(KERN_CONT " NTU\n");
-                        else if (i == rx_ring->next_to_clean)
-                                printk(KERN_CONT " NTC\n");
-                        else
-                                printk(KERN_CONT "\n");
                 }
         }
 
@@ -1222,8 +1206,7 @@ static bool e1000_clean_rx_irq_ps(struct e1000_adapter *adapter,
                         adapter->flags2 |= FLAG2_IS_DISCARDING;
 
                 if (adapter->flags2 & FLAG2_IS_DISCARDING) {
-                        e_dbg("Packet Split buffers didn't pick up the full "
-                              "packet\n");
+                        e_dbg("Packet Split buffers didn't pick up the full packet\n");
                         dev_kfree_skb_irq(skb);
                         if (staterr & E1000_RXD_STAT_EOP)
                                 adapter->flags2 &= ~FLAG2_IS_DISCARDING;
@@ -1238,8 +1221,7 @@ static bool e1000_clean_rx_irq_ps(struct e1000_adapter *adapter,
                 length = le16_to_cpu(rx_desc->wb.middle.length0);
 
                 if (!length) {
-                        e_dbg("Last part of the packet spanning multiple "
-                              "descriptors\n");
+                        e_dbg("Last part of the packet spanning multiple descriptors\n");
                         dev_kfree_skb_irq(skb);
                         goto next_desc;
                 }
@@ -1917,8 +1899,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter)
                                         return;
                         }
                         /* MSI-X failed, so fall through and try MSI */
-                        e_err("Failed to initialize MSI-X interrupts.  "
-                              "Falling back to MSI interrupts.\n");
+                        e_err("Failed to initialize MSI-X interrupts.  Falling back to MSI interrupts.\n");
                         e1000e_reset_interrupt_capability(adapter);
                 }
                 adapter->int_mode = E1000E_INT_MODE_MSI;
@@ -1928,8 +1909,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter)
                         adapter->flags |= FLAG_MSI_ENABLED;
                 } else {
                         adapter->int_mode = E1000E_INT_MODE_LEGACY;
-                        e_err("Failed to initialize MSI interrupts.  Falling "
-                              "back to legacy interrupts.\n");
+                        e_err("Failed to initialize MSI interrupts.  Falling back to legacy interrupts.\n");
                 }
                 /* Fall through */
         case E1000E_INT_MODE_LEGACY:
@@ -3113,79 +3093,147 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
 }
 
 /**
- *  e1000_update_mc_addr_list - Update Multicast addresses
- *  @hw: pointer to the HW structure
- *  @mc_addr_list: array of multicast addresses to program
- *  @mc_addr_count: number of multicast addresses to program
+ * e1000e_write_mc_addr_list - write multicast addresses to MTA
+ * @netdev: network interface device structure
+ *
+ * Writes multicast address list to the MTA hash table.
+ * Returns: -ENOMEM on failure
+ *                0 on no addresses written
+ *                X on writing X addresses to MTA
+ */
+static int e1000e_write_mc_addr_list(struct net_device *netdev)
+{
+        struct e1000_adapter *adapter = netdev_priv(netdev);
+        struct e1000_hw *hw = &adapter->hw;
+        struct netdev_hw_addr *ha;
+        u8 *mta_list;
+        int i;
+
+        if (netdev_mc_empty(netdev)) {
+                /* nothing to program, so clear mc list */
+                hw->mac.ops.update_mc_addr_list(hw, NULL, 0);
+                return 0;
+        }
+
+        mta_list = kzalloc(netdev_mc_count(netdev) * ETH_ALEN, GFP_ATOMIC);
+        if (!mta_list)
+                return -ENOMEM;
+
+        /* update_mc_addr_list expects a packed array of only addresses. */
+        i = 0;
+        netdev_for_each_mc_addr(ha, netdev)
+                memcpy(mta_list + (i++ * ETH_ALEN), ha->addr, ETH_ALEN);
+
+        hw->mac.ops.update_mc_addr_list(hw, mta_list, i);
+        kfree(mta_list);
+
+        return netdev_mc_count(netdev);
+}
+
+/**
+ * e1000e_write_uc_addr_list - write unicast addresses to RAR table
+ * @netdev: network interface device structure
  *
- *  Updates the Multicast Table Array.
- *  The caller must have a packed mc_addr_list of multicast addresses.
+ * Writes unicast address list to the RAR table.
+ * Returns: -ENOMEM on failure/insufficient address space
+ *                0 on no addresses written
+ *                X on writing X addresses to the RAR table
  **/
-static void e1000_update_mc_addr_list(struct e1000_hw *hw, u8 *mc_addr_list,
-                                      u32 mc_addr_count)
+static int e1000e_write_uc_addr_list(struct net_device *netdev)
 {
-        hw->mac.ops.update_mc_addr_list(hw, mc_addr_list, mc_addr_count);
+        struct e1000_adapter *adapter = netdev_priv(netdev);
+        struct e1000_hw *hw = &adapter->hw;
+        unsigned int rar_entries = hw->mac.rar_entry_count;
+        int count = 0;
+
+        /* save a rar entry for our hardware address */
+        rar_entries--;
+
+        /* save a rar entry for the LAA workaround */
+        if (adapter->flags & FLAG_RESET_OVERWRITES_LAA)
+                rar_entries--;
+
+        /* return ENOMEM indicating insufficient memory for addresses */
+        if (netdev_uc_count(netdev) > rar_entries)
+                return -ENOMEM;
+
+        if (!netdev_uc_empty(netdev) && rar_entries) {
+                struct netdev_hw_addr *ha;
+
+                /*
+                 * write the addresses in reverse order to avoid write
+                 * combining
+                 */
+                netdev_for_each_uc_addr(ha, netdev) {
+                        if (!rar_entries)
+                                break;
+                        e1000e_rar_set(hw, ha->addr, rar_entries--);
+                        count++;
+                }
+        }
+
+        /* zero out the remaining RAR entries not used above */
+        for (; rar_entries > 0; rar_entries--) {
+                ew32(RAH(rar_entries), 0);
+                ew32(RAL(rar_entries), 0);
+        }
+        e1e_flush();
+
+        return count;
 }
 
 /**
- * e1000_set_multi - Multicast and Promiscuous mode set
+ * e1000e_set_rx_mode - secondary unicast, Multicast and Promiscuous mode set
  * @netdev: network interface device structure
  *
- * The set_multi entry point is called whenever the multicast address
- * list or the network interface flags are updated.  This routine is
- * responsible for configuring the hardware for proper multicast,
+ * The ndo_set_rx_mode entry point is called whenever the unicast or multicast
+ * address list or the network interface flags are updated.  This routine is
+ * responsible for configuring the hardware for proper unicast, multicast,
  * promiscuous mode, and all-multi behavior.
  **/
-static void e1000_set_multi(struct net_device *netdev)
+static void e1000e_set_rx_mode(struct net_device *netdev)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
         struct e1000_hw *hw = &adapter->hw;
-        struct netdev_hw_addr *ha;
-        u8  *mta_list;
         u32 rctl;
 
         /* Check for Promiscuous and All Multicast modes */
-
         rctl = er32(RCTL);
 
+        /* clear the affected bits */
+        rctl &= ~(E1000_RCTL_UPE | E1000_RCTL_MPE);
+
         if (netdev->flags & IFF_PROMISC) {
                 rctl |= (E1000_RCTL_UPE | E1000_RCTL_MPE);
-                rctl &= ~E1000_RCTL_VFE;
                 /* Do not hardware filter VLANs in promisc mode */
                 e1000e_vlan_filter_disable(adapter);
         } else {
+                int count;
                 if (netdev->flags & IFF_ALLMULTI) {
                         rctl |= E1000_RCTL_MPE;
-                        rctl &= ~E1000_RCTL_UPE;
                 } else {
-                        rctl &= ~(E1000_RCTL_UPE | E1000_RCTL_MPE);
+                        /*
+                         * Write addresses to the MTA, if the attempt fails
+                         * then we should just turn on promiscuous mode so
+                         * that we can at least receive multicast traffic
+                         */
+                        count = e1000e_write_mc_addr_list(netdev);
+                        if (count < 0)
+                                rctl |= E1000_RCTL_MPE;
                 }
                 e1000e_vlan_filter_enable(adapter);
-        }
-
-        ew32(RCTL, rctl);
-
-        if (!netdev_mc_empty(netdev)) {
-                int i = 0;
-
-                mta_list = kmalloc(netdev_mc_count(netdev) * 6, GFP_ATOMIC);
-                if (!mta_list)
-                        return;
-
-                /* prepare a packed array of only addresses. */
-                netdev_for_each_mc_addr(ha, netdev)
-                        memcpy(mta_list + (i++ * ETH_ALEN), ha->addr, ETH_ALEN);
-
-                e1000_update_mc_addr_list(hw, mta_list, i);
-                kfree(mta_list);
-        } else {
                 /*
-                 * if we're called from probe, we might not have
-                 * anything to do here, so clear out the list
+                 * Write addresses to available RAR registers, if there is not
+                 * sufficient space to store all the addresses then enable
+                 * unicast promiscuous mode
                  */
-                e1000_update_mc_addr_list(hw, NULL, 0);
+                count = e1000e_write_uc_addr_list(netdev);
+                if (count < 0)
+                        rctl |= E1000_RCTL_UPE;
         }
 
+        ew32(RCTL, rctl);
+
         if (netdev->features & NETIF_F_HW_VLAN_RX)
                 e1000e_vlan_strip_enable(adapter);
         else
@@ -3198,7 +3246,7 @@ static void e1000_set_multi(struct net_device *netdev)
  **/
 static void e1000_configure(struct e1000_adapter *adapter)
 {
-        e1000_set_multi(adapter->netdev);
+        e1000e_set_rx_mode(adapter->netdev);
 
         e1000_restore_vlan(adapter);
         e1000_init_manageability_pt(adapter);
@@ -4168,16 +4216,13 @@ static void e1000_print_link_info(struct e1000_adapter *adapter)
         u32 ctrl = er32(CTRL);
 
         /* Link status message must follow this format for user tools */
-        printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s, "
-               "Flow Control: %s\n",
-               adapter->netdev->name,
-               adapter->link_speed,
-               (adapter->link_duplex == FULL_DUPLEX) ?
-               "Full Duplex" : "Half Duplex",
-               ((ctrl & E1000_CTRL_TFCE) && (ctrl & E1000_CTRL_RFCE)) ?
-               "Rx/Tx" :
-               ((ctrl & E1000_CTRL_RFCE) ? "Rx" :
-                ((ctrl & E1000_CTRL_TFCE) ? "Tx" : "None")));
+        printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n",
+                adapter->netdev->name,
+                adapter->link_speed,
+                adapter->link_duplex == FULL_DUPLEX ? "Full" : "Half",
+                (ctrl & E1000_CTRL_TFCE) && (ctrl & E1000_CTRL_RFCE) ? "Rx/Tx" :
+                (ctrl & E1000_CTRL_RFCE) ? "Rx" :
+                (ctrl & E1000_CTRL_TFCE) ? "Tx" : "None");
 }
 
 static bool e1000e_has_link(struct e1000_adapter *adapter)
@@ -4323,10 +4368,7 @@ static void e1000_watchdog_task(struct work_struct *work)
                                 e1e_rphy(hw, PHY_AUTONEG_EXP, &autoneg_exp);
 
                                 if (!(autoneg_exp & NWAY_ER_LP_NWAY_CAPS))
-                                        e_info("Autonegotiated half duplex but"
-                                               " link partner cannot autoneg. "
-                                               " Try forcing full duplex if "
-                                               "link gets many collisions.\n");
+                                        e_info("Autonegotiated half duplex but link partner cannot autoneg.  Try forcing full duplex if link gets many collisions.\n");
                         }
 
                         /* adjust timeout factor according to speed/duplex */
@@ -5110,8 +5152,7 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu)
         if ((adapter->hw.mac.type == e1000_pch2lan) &&
             !(adapter->flags2 & FLAG2_CRC_STRIPPING) &&
             (new_mtu > ETH_DATA_LEN)) {
-                e_err("Jumbo Frames not supported on 82579 when CRC "
-                      "stripping is disabled.\n");
+                e_err("Jumbo Frames not supported on 82579 when CRC stripping is disabled.\n");
                 return -EINVAL;
         }
 
@@ -5331,7 +5372,7 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake,
 
         if (wufc) {
                 e1000_setup_rctl(adapter);
-                e1000_set_multi(netdev);
+                e1000e_set_rx_mode(netdev);
 
                 /* turn on all-multi mode if wake on multicast is enabled */
                 if (wufc & E1000_WUFC_MC) {
@@ -5527,8 +5568,8 @@ static int __e1000_resume(struct pci_dev *pdev)
                                 phy_data & E1000_WUS_MC ? "Multicast Packet" :
                                 phy_data & E1000_WUS_BC ? "Broadcast Packet" :
                                 phy_data & E1000_WUS_MAG ? "Magic Packet" :
-                                phy_data & E1000_WUS_LNKC ? "Link Status "
-                                " Change" : "other");
+                                phy_data & E1000_WUS_LNKC ?
+                                "Link Status Change" : "other");
                 }
                 e1e_wphy(&adapter->hw, BM_WUS, ~0);
         } else {
@@ -5859,10 +5900,11 @@ static void e1000_eeprom_checks(struct e1000_adapter *adapter)
         }
 }
 
-static int e1000_set_features(struct net_device *netdev, u32 features)
+static int e1000_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct e1000_adapter *adapter = netdev_priv(netdev);
-        u32 changed = features ^ netdev->features;
+        netdev_features_t changed = features ^ netdev->features;
 
         if (changed & (NETIF_F_TSO | NETIF_F_TSO6))
                 adapter->flags |= FLAG_TSO_FORCE;
@@ -5884,7 +5926,7 @@ static const struct net_device_ops e1000e_netdev_ops = {
         .ndo_stop               = e1000_close,
         .ndo_start_xmit         = e1000_xmit_frame,
         .ndo_get_stats64        = e1000e_get_stats64,
-        .ndo_set_rx_mode        = e1000_set_multi,
+        .ndo_set_rx_mode        = e1000e_set_rx_mode,
         .ndo_set_mac_address    = e1000_set_mac,
         .ndo_change_mtu         = e1000_change_mtu,
         .ndo_do_ioctl           = e1000_ioctl,
@@ -5949,8 +5991,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
                         err = dma_set_coherent_mask(&pdev->dev,
                                                     DMA_BIT_MASK(32));
                         if (err) {
-                                dev_err(&pdev->dev, "No usable DMA "
-                                        "configuration, aborting\n");
+                                dev_err(&pdev->dev, "No usable DMA configuration, aborting\n");
                                 goto err_dma;
                         }
                 }
@@ -6076,6 +6117,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
                                   NETIF_F_TSO6 |
                                   NETIF_F_HW_CSUM);
 
+        netdev->priv_flags |= IFF_UNICAST_FLT;
+
         if (pci_using_dac) {
                 netdev->features |= NETIF_F_HIGHDMA;
                 netdev->vlan_features |= NETIF_F_HIGHDMA;
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c
index 7881fb95a25b..b8e20f037d0a 100644
--- a/drivers/net/ethernet/intel/igb/e1000_82575.c
+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c
@@ -29,6 +29,8 @@
  * e1000_82576
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/if_ether.h>
 
@@ -244,8 +246,7 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw)
          * Check for invalid size
          */
         if ((hw->mac.type == e1000_82576) && (size > 15)) {
-                printk("igb: The NVM size is not valid, "
-                        "defaulting to 32K.\n");
+                pr_notice("The NVM size is not valid, defaulting to 32K\n");
                 size = 15;
         }
         nvm->word_size = 1 << size;
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 43873eba2f63..e9335efac386 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -673,25 +673,22 @@ static void igb_get_drvinfo(struct net_device *netdev,
                             struct ethtool_drvinfo *drvinfo)
 {
         struct igb_adapter *adapter = netdev_priv(netdev);
-        char firmware_version[32];
         u16 eeprom_data;
 
-        strncpy(drvinfo->driver,  igb_driver_name, sizeof(drvinfo->driver) - 1);
-        strncpy(drvinfo->version, igb_driver_version,
-                sizeof(drvinfo->version) - 1);
+        strlcpy(drvinfo->driver,  igb_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version));
 
         /* EEPROM image version # is reported as firmware version # for
          * 82575 controllers */
         adapter->hw.nvm.ops.read(&adapter->hw, 5, 1, &eeprom_data);
-        sprintf(firmware_version, "%d.%d-%d",
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                "%d.%d-%d",
                 (eeprom_data & 0xF000) >> 12,
                 (eeprom_data & 0x0FF0) >> 4,
                 eeprom_data & 0x000F);
 
-        strncpy(drvinfo->fw_version, firmware_version,
-                sizeof(drvinfo->fw_version) - 1);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev),
-                sizeof(drvinfo->bus_info) - 1);
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = IGB_STATS_LEN;
         drvinfo->testinfo_len = IGB_TEST_LEN;
         drvinfo->regdump_len = igb_get_regs_len(netdev);
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index ced544499f1b..bd9b30e6ae9d 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -25,6 +25,8 @@
 
 *******************************************************************************/
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/init.h>
@@ -145,7 +147,7 @@ static bool igb_clean_rx_irq(struct igb_q_vector *, int);
 static int igb_ioctl(struct net_device *, struct ifreq *, int cmd);
 static void igb_tx_timeout(struct net_device *);
 static void igb_reset_task(struct work_struct *);
-static void igb_vlan_mode(struct net_device *netdev, u32 features);
+static void igb_vlan_mode(struct net_device *netdev, netdev_features_t features);
 static void igb_vlan_rx_add_vid(struct net_device *, u16);
 static void igb_vlan_rx_kill_vid(struct net_device *, u16);
 static void igb_restore_vlan(struct igb_adapter *);
@@ -325,16 +327,13 @@ static void igb_regdump(struct e1000_hw *hw, struct igb_reg_info *reginfo)
                         regs[n] = rd32(E1000_TXDCTL(n));
                 break;
         default:
-                printk(KERN_INFO "%-15s %08x\n",
-                        reginfo->name, rd32(reginfo->ofs));
+                pr_info("%-15s %08x\n", reginfo->name, rd32(reginfo->ofs));
                 return;
         }
 
         snprintf(rname, 16, "%s%s", reginfo->name, "[0-3]");
-        printk(KERN_INFO "%-15s ", rname);
-        for (n = 0; n < 4; n++)
-                printk(KERN_CONT "%08x ", regs[n]);
-        printk(KERN_CONT "\n");
+        pr_info("%-15s %08x %08x %08x %08x\n", rname, regs[0], regs[1],
+                regs[2], regs[3]);
 }
 
 /*
@@ -359,18 +358,15 @@ static void igb_dump(struct igb_adapter *adapter)
         /* Print netdevice Info */
         if (netdev) {
                 dev_info(&adapter->pdev->dev, "Net device Info\n");
-                printk(KERN_INFO "Device Name     state            "
-                        "trans_start      last_rx\n");
-                printk(KERN_INFO "%-15s %016lX %016lX %016lX\n",
-                netdev->name,
-                netdev->state,
-                netdev->trans_start,
-                netdev->last_rx);
+                pr_info("Device Name     state            trans_start      "
+                        "last_rx\n");
+                pr_info("%-15s %016lX %016lX %016lX\n", netdev->name,
+                        netdev->state, netdev->trans_start, netdev->last_rx);
         }
 
         /* Print Registers */
         dev_info(&adapter->pdev->dev, "Register Dump\n");
-        printk(KERN_INFO " Register Name   Value\n");
+        pr_info(" Register Name   Value\n");
         for (reginfo = (struct igb_reg_info *)igb_reg_info_tbl;
              reginfo->name; reginfo++) {
                 igb_regdump(hw, reginfo);
@@ -381,18 +377,17 @@ static void igb_dump(struct igb_adapter *adapter)
                 goto exit;
 
         dev_info(&adapter->pdev->dev, "TX Rings Summary\n");
-        printk(KERN_INFO "Queue [NTU] [NTC] [bi(ntc)->dma  ]"
-                " leng ntw timestamp\n");
+        pr_info("Queue [NTU] [NTC] [bi(ntc)->dma  ] leng ntw timestamp\n");
         for (n = 0; n < adapter->num_tx_queues; n++) {
                 struct igb_tx_buffer *buffer_info;
                 tx_ring = adapter->tx_ring[n];
                 buffer_info = &tx_ring->tx_buffer_info[tx_ring->next_to_clean];
-                printk(KERN_INFO " %5d %5X %5X %016llX %04X %p %016llX\n",
-                           n, tx_ring->next_to_use, tx_ring->next_to_clean,
-                           (u64)buffer_info->dma,
-                           buffer_info->length,
-                           buffer_info->next_to_watch,
-                           (u64)buffer_info->time_stamp);
+                pr_info(" %5d %5X %5X %016llX %04X %p %016llX\n",
+                        n, tx_ring->next_to_use, tx_ring->next_to_clean,
+                        (u64)buffer_info->dma,
+                        buffer_info->length,
+                        buffer_info->next_to_watch,
+                        (u64)buffer_info->time_stamp);
         }
 
         /* Print TX Rings */
@@ -414,36 +409,38 @@ static void igb_dump(struct igb_adapter *adapter)
 
         for (n = 0; n < adapter->num_tx_queues; n++) {
                 tx_ring = adapter->tx_ring[n];
-                printk(KERN_INFO "------------------------------------\n");
-                printk(KERN_INFO "TX QUEUE INDEX = %d\n", tx_ring->queue_index);
-                printk(KERN_INFO "------------------------------------\n");
-                printk(KERN_INFO "T [desc]     [address 63:0  ] "
-                        "[PlPOCIStDDM Ln] [bi->dma       ] "
-                        "leng  ntw timestamp        bi->skb\n");
+                pr_info("------------------------------------\n");
+                pr_info("TX QUEUE INDEX = %d\n", tx_ring->queue_index);
+                pr_info("------------------------------------\n");
+                pr_info("T [desc]     [address 63:0  ] [PlPOCIStDDM Ln] "
+                        "[bi->dma       ] leng  ntw timestamp        "
+                        "bi->skb\n");
 
                 for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
+                        const char *next_desc;
                         struct igb_tx_buffer *buffer_info;
                         tx_desc = IGB_TX_DESC(tx_ring, i);
                         buffer_info = &tx_ring->tx_buffer_info[i];
                         u0 = (struct my_u0 *)tx_desc;
-                        printk(KERN_INFO "T [0x%03X]    %016llX %016llX %016llX"
-                                " %04X  %p %016llX %p", i,
+                        if (i == tx_ring->next_to_use &&
+                            i == tx_ring->next_to_clean)
+                                next_desc = " NTC/U";
+                        else if (i == tx_ring->next_to_use)
+                                next_desc = " NTU";
+                        else if (i == tx_ring->next_to_clean)
+                                next_desc = " NTC";
+                        else
+                                next_desc = "";
+
+                        pr_info("T [0x%03X]    %016llX %016llX %016llX"
+                                " %04X  %p %016llX %p%s\n", i,
                                 le64_to_cpu(u0->a),
                                 le64_to_cpu(u0->b),
                                 (u64)buffer_info->dma,
                                 buffer_info->length,
                                 buffer_info->next_to_watch,
                                 (u64)buffer_info->time_stamp,
-                                buffer_info->skb);
-                        if (i == tx_ring->next_to_use &&
-                                i == tx_ring->next_to_clean)
-                                printk(KERN_CONT " NTC/U\n");
-                        else if (i == tx_ring->next_to_use)
-                                printk(KERN_CONT " NTU\n");
-                        else if (i == tx_ring->next_to_clean)
-                                printk(KERN_CONT " NTC\n");
-                        else
-                                printk(KERN_CONT "\n");
+                                buffer_info->skb, next_desc);
 
                         if (netif_msg_pktdata(adapter) && buffer_info->dma != 0)
                                 print_hex_dump(KERN_INFO, "",
@@ -456,11 +453,11 @@ static void igb_dump(struct igb_adapter *adapter)
         /* Print RX Rings Summary */
 rx_ring_summary:
         dev_info(&adapter->pdev->dev, "RX Rings Summary\n");
-        printk(KERN_INFO "Queue [NTU] [NTC]\n");
+        pr_info("Queue [NTU] [NTC]\n");
         for (n = 0; n < adapter->num_rx_queues; n++) {
                 rx_ring = adapter->rx_ring[n];
-                printk(KERN_INFO " %5d %5X %5X\n", n,
-                           rx_ring->next_to_use, rx_ring->next_to_clean);
+                pr_info(" %5d %5X %5X\n",
+                        n, rx_ring->next_to_use, rx_ring->next_to_clean);
         }
 
         /* Print RX Rings */
@@ -492,36 +489,43 @@ rx_ring_summary:
 
         for (n = 0; n < adapter->num_rx_queues; n++) {
                 rx_ring = adapter->rx_ring[n];
-                printk(KERN_INFO "------------------------------------\n");
-                printk(KERN_INFO "RX QUEUE INDEX = %d\n", rx_ring->queue_index);
-                printk(KERN_INFO "------------------------------------\n");
-                printk(KERN_INFO "R  [desc]      [ PktBuf     A0] "
-                        "[  HeadBuf   DD] [bi->dma       ] [bi->skb] "
-                        "<-- Adv Rx Read format\n");
-                printk(KERN_INFO "RWB[desc]      [PcsmIpSHl PtRs] "
-                        "[vl er S cks ln] ---------------- [bi->skb] "
-                        "<-- Adv Rx Write-Back format\n");
+                pr_info("------------------------------------\n");
+                pr_info("RX QUEUE INDEX = %d\n", rx_ring->queue_index);
+                pr_info("------------------------------------\n");
+                pr_info("R  [desc]      [ PktBuf     A0] [  HeadBuf   DD] "
+                        "[bi->dma       ] [bi->skb] <-- Adv Rx Read format\n");
+                pr_info("RWB[desc]      [PcsmIpSHl PtRs] [vl er S cks ln] -----"
+                        "----------- [bi->skb] <-- Adv Rx Write-Back format\n");
 
                 for (i = 0; i < rx_ring->count; i++) {
+                        const char *next_desc;
                         struct igb_rx_buffer *buffer_info;
                         buffer_info = &rx_ring->rx_buffer_info[i];
                         rx_desc = IGB_RX_DESC(rx_ring, i);
                         u0 = (struct my_u0 *)rx_desc;
                         staterr = le32_to_cpu(rx_desc->wb.upper.status_error);
+
+                        if (i == rx_ring->next_to_use)
+                                next_desc = " NTU";
+                        else if (i == rx_ring->next_to_clean)
+                                next_desc = " NTC";
+                        else
+                                next_desc = "";
+
                         if (staterr & E1000_RXD_STAT_DD) {
                                 /* Descriptor Done */
-                                printk(KERN_INFO "RWB[0x%03X]     %016llX "
-                                        "%016llX ---------------- %p", i,
+                                pr_info("%s[0x%03X]     %016llX %016llX -------"
+                                        "--------- %p%s\n", "RWB", i,
                                         le64_to_cpu(u0->a),
                                         le64_to_cpu(u0->b),
-                                        buffer_info->skb);
+                                        buffer_info->skb, next_desc);
                         } else {
-                                printk(KERN_INFO "R  [0x%03X]     %016llX "
-                                        "%016llX %016llX %p", i,
+                                pr_info("%s[0x%03X]     %016llX %016llX %016llX"
+                                        " %p%s\n", "R  ", i,
                                         le64_to_cpu(u0->a),
                                         le64_to_cpu(u0->b),
                                         (u64)buffer_info->dma,
-                                        buffer_info->skb);
+                                        buffer_info->skb, next_desc);
 
                                 if (netif_msg_pktdata(adapter)) {
                                         print_hex_dump(KERN_INFO, "",
@@ -538,14 +542,6 @@ rx_ring_summary:
                                           PAGE_SIZE/2, true);
                                 }
                         }
-
-                        if (i == rx_ring->next_to_use)
-                                printk(KERN_CONT " NTU\n");
-                        else if (i == rx_ring->next_to_clean)
-                                printk(KERN_CONT " NTC\n");
-                        else
-                                printk(KERN_CONT "\n");
-
                 }
         }
 
@@ -599,10 +595,10 @@ struct net_device *igb_get_hw_dev(struct e1000_hw *hw)
 static int __init igb_init_module(void)
 {
         int ret;
-        printk(KERN_INFO "%s - version %s\n",
+        pr_info("%s - version %s\n",
                igb_driver_string, igb_driver_version);
 
-        printk(KERN_INFO "%s\n", igb_copyright);
+        pr_info("%s\n", igb_copyright);
 
 #ifdef CONFIG_IGB_DCA
         dca_register_notify(&dca_notifier);
@@ -1742,7 +1738,8 @@ void igb_reset(struct igb_adapter *adapter)
         igb_get_phy_info(hw);
 }
 
-static u32 igb_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t igb_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -1756,9 +1753,10 @@ static u32 igb_fix_features(struct net_device *netdev, u32 features)
         return features;
 }
 
-static int igb_set_features(struct net_device *netdev, u32 features)
+static int igb_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 igb_vlan_mode(netdev, features);
@@ -3640,23 +3638,23 @@ static void igb_watchdog_task(struct work_struct *work)
 
                         ctrl = rd32(E1000_CTRL);
                         /* Links status message must follow this format */
-                        printk(KERN_INFO "igb: %s NIC Link is Up %d Mbps %s, "
-                                 "Flow Control: %s\n",
+                        printk(KERN_INFO "igb: %s NIC Link is Up %d Mbps %s "
+                               "Duplex, Flow Control: %s\n",
                                netdev->name,
                                adapter->link_speed,
                                adapter->link_duplex == FULL_DUPLEX ?
-                                 "Full Duplex" : "Half Duplex",
-                               ((ctrl & E1000_CTRL_TFCE) &&
-                                (ctrl & E1000_CTRL_RFCE)) ? "RX/TX" :
-                               ((ctrl & E1000_CTRL_RFCE) ?  "RX" :
-                               ((ctrl & E1000_CTRL_TFCE) ?  "TX" : "None")));
+                               "Full" : "Half",
+                               (ctrl & E1000_CTRL_TFCE) &&
+                               (ctrl & E1000_CTRL_RFCE) ? "RX/TX" :
+                               (ctrl & E1000_CTRL_RFCE) ?  "RX" :
+                               (ctrl & E1000_CTRL_TFCE) ?  "TX" : "None");
 
                         /* check for thermal sensor event */
-                        if (igb_thermal_sensor_event(hw, E1000_THSTAT_LINK_THROTTLE)) {
-                                printk(KERN_INFO "igb: %s The network adapter "
-                                                 "link speed was downshifted "
-                                                 "because it overheated.\n",
-                                                 netdev->name);
+                        if (igb_thermal_sensor_event(hw,
+                            E1000_THSTAT_LINK_THROTTLE)) {
+                                netdev_info(netdev, "The network adapter link "
+                                            "speed was downshifted because it "
+                                            "overheated\n");
                         }
 
                         /* adjust timeout factor according to speed/duplex */
@@ -3686,11 +3684,10 @@ static void igb_watchdog_task(struct work_struct *work)
                         adapter->link_duplex = 0;
 
                         /* check for thermal sensor event */
-                        if (igb_thermal_sensor_event(hw, E1000_THSTAT_PWR_DOWN)) {
-                                printk(KERN_ERR "igb: %s The network adapter "
-                                                "was stopped because it "
-                                                "overheated.\n",
-                                                netdev->name);
+                        if (igb_thermal_sensor_event(hw,
+                            E1000_THSTAT_PWR_DOWN)) {
+                                netdev_err(netdev, "The network adapter was "
+                                           "stopped because it overheated\n");
                         }
 
                         /* Links status message must follow this format */
@@ -6467,7 +6464,7 @@ s32 igb_write_pcie_cap_reg(struct e1000_hw *hw, u32 reg, u16 *value)
         return 0;
 }
 
-static void igb_vlan_mode(struct net_device *netdev, u32 features)
+static void igb_vlan_mode(struct net_device *netdev, netdev_features_t features)
 {
         struct igb_adapter *adapter = netdev_priv(netdev);
         struct e1000_hw *hw = &adapter->hw;
diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c
index 2c25858cc0ff..e60f1c6957af 100644
--- a/drivers/net/ethernet/intel/igbvf/ethtool.c
+++ b/drivers/net/ethernet/intel/igbvf/ethtool.c
@@ -191,12 +191,14 @@ static void igbvf_get_drvinfo(struct net_device *netdev,
                               struct ethtool_drvinfo *drvinfo)
 {
         struct igbvf_adapter *adapter = netdev_priv(netdev);
-        char firmware_version[32] = "N/A";
 
-        strncpy(drvinfo->driver,  igbvf_driver_name, 32);
-        strncpy(drvinfo->version, igbvf_driver_version, 32);
-        strncpy(drvinfo->fw_version, firmware_version, 32);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->driver,  igbvf_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, igbvf_driver_version,
+                sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "N/A",
+                sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = igbvf_get_regs_len(netdev);
         drvinfo->eedump_len = igbvf_get_eeprom_len(netdev);
 }
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index cca78124be31..c358973ce414 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -25,6 +25,8 @@
 
 *******************************************************************************/
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/init.h>
@@ -1746,10 +1748,9 @@ void igbvf_update_stats(struct igbvf_adapter *adapter)
 
 static void igbvf_print_link_info(struct igbvf_adapter *adapter)
 {
-        dev_info(&adapter->pdev->dev, "Link is Up %d Mbps %s\n",
-                 adapter->link_speed,
-                 ((adapter->link_duplex == FULL_DUPLEX) ?
-                  "Full Duplex" : "Half Duplex"));
+        dev_info(&adapter->pdev->dev, "Link is Up %d Mbps %s Duplex\n",
+                 adapter->link_speed,
+                 adapter->link_duplex == FULL_DUPLEX ? "Full" : "Half");
 }
 
 static bool igbvf_has_link(struct igbvf_adapter *adapter)
@@ -2532,7 +2533,8 @@ static void igbvf_print_device_info(struct igbvf_adapter *adapter)
         dev_info(&pdev->dev, "Address: %pM\n", netdev->dev_addr);
 }
 
-static int igbvf_set_features(struct net_device *netdev, u32 features)
+static int igbvf_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct igbvf_adapter *adapter = netdev_priv(netdev);
 
@@ -2842,9 +2844,8 @@ static struct pci_driver igbvf_driver = {
 static int __init igbvf_init_module(void)
 {
         int ret;
-        printk(KERN_INFO "%s - version %s\n",
-               igbvf_driver_string, igbvf_driver_version);
-        printk(KERN_INFO "%s\n", igbvf_copyright);
+        pr_info("%s - version %s\n", igbvf_driver_string, igbvf_driver_version);
+        pr_info("%s\n", igbvf_copyright);
 
         ret = pci_register_driver(&igbvf_driver);
 
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c
index 9dfce7dff79b..96fcb0e06450 100644
--- a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c
@@ -473,10 +473,13 @@ ixgb_get_drvinfo(struct net_device *netdev,
 {
         struct ixgb_adapter *adapter = netdev_priv(netdev);
 
-        strncpy(drvinfo->driver,  ixgb_driver_name, 32);
-        strncpy(drvinfo->version, ixgb_driver_version, 32);
-        strncpy(drvinfo->fw_version, "N/A", 32);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->driver,  ixgb_driver_name,
+                sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, ixgb_driver_version,
+                sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = IXGB_STATS_LEN;
         drvinfo->regdump_len = ixgb_get_regs_len(netdev);
         drvinfo->eedump_len = ixgb_get_eeprom_len(netdev);
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
index e21148f8b160..247cf9219e03 100644
--- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
+++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
@@ -325,8 +325,8 @@ ixgb_reset(struct ixgb_adapter *adapter)
         }
 }
 
-static u32
-ixgb_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t
+ixgb_fix_features(struct net_device *netdev, netdev_features_t features)
 {
         /*
          * Tx VLAN insertion does not work per HW design when Rx stripping is
@@ -339,10 +339,10 @@ ixgb_fix_features(struct net_device *netdev, u32 features)
 }
 
 static int
-ixgb_set_features(struct net_device *netdev, u32 features)
+ixgb_set_features(struct net_device *netdev, netdev_features_t features)
 {
         struct ixgb_adapter *adapter = netdev_priv(netdev);
-        u32 changed = features ^ netdev->features;
+        netdev_features_t changed = features ^ netdev->features;
 
         if (!(changed & (NETIF_F_RXCSUM|NETIF_F_HW_VLAN_RX)))
                 return 0;
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 70d58c3849b0..91f871b6b3ba 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -888,23 +888,19 @@ static void ixgbe_get_drvinfo(struct net_device *netdev,
                               struct ethtool_drvinfo *drvinfo)
 {
         struct ixgbe_adapter *adapter = netdev_priv(netdev);
-        char firmware_version[32];
         u32 nvm_track_id;
 
-        strncpy(drvinfo->driver, ixgbe_driver_name,
-                sizeof(drvinfo->driver) - 1);
-        strncpy(drvinfo->version, ixgbe_driver_version,
-                sizeof(drvinfo->version) - 1);
+        strlcpy(drvinfo->driver, ixgbe_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, ixgbe_driver_version,
+                sizeof(drvinfo->version));
 
         nvm_track_id = (adapter->eeprom_verh << 16) |
                         adapter->eeprom_verl;
-        snprintf(firmware_version, sizeof(firmware_version), "0x%08x",
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), "0x%08x",
                  nvm_track_id);
 
-        strncpy(drvinfo->fw_version, firmware_version,
-                sizeof(drvinfo->fw_version) - 1);
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev),
-                sizeof(drvinfo->bus_info) - 1);
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = IXGBE_STATS_LEN;
         drvinfo->testinfo_len = IXGBE_TEST_LEN;
         drvinfo->regdump_len = ixgbe_get_regs_len(netdev);
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 8ef92d1a6aa1..820fc040c241 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7174,7 +7174,8 @@ void ixgbe_do_reset(struct net_device *netdev)
                 ixgbe_reset(adapter);
 }
 
-static u32 ixgbe_fix_features(struct net_device *netdev, u32 data)
+static netdev_features_t ixgbe_fix_features(struct net_device *netdev,
+        netdev_features_t data)
 {
         struct ixgbe_adapter *adapter = netdev_priv(netdev);
 
@@ -7204,7 +7205,8 @@ static u32 ixgbe_fix_features(struct net_device *netdev, u32 data)
         return data;
 }
 
-static int ixgbe_set_features(struct net_device *netdev, u32 data)
+static int ixgbe_set_features(struct net_device *netdev,
+        netdev_features_t data)
 {
         struct ixgbe_adapter *adapter = netdev_priv(netdev);
         bool need_reset = false;
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 00fcd39ad666..cf6812dd1436 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -572,7 +572,7 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf)
 
                 /* reply to reset with ack and vf mac address */
                 msgbuf[0] = IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK;
-                memcpy(new_mac, vf_mac, IXGBE_ETH_LENGTH_OF_ADDRESS);
+                memcpy(new_mac, vf_mac, ETH_ALEN);
                 /*
                  * Piggyback the multicast filter type so VF can compute the
                  * correct vectors
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
index 6c5cca808bd7..242643a69b3f 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
@@ -1710,8 +1710,6 @@ enum {
 #define IXGBE_NVM_POLL_WRITE       1  /* Flag for polling for write complete */
 #define IXGBE_NVM_POLL_READ        0  /* Flag for polling for read complete */
 
-#define IXGBE_ETH_LENGTH_OF_ADDRESS   6
-
 #define IXGBE_EEPROM_PAGE_SIZE_MAX       128
 #define IXGBE_EEPROM_RD_BUFFER_MAX_COUNT 512 /* EEPROM words # read in burst */
 #define IXGBE_EEPROM_WR_BUFFER_MAX_COUNT 256 /* EEPROM words # wr in burst */
@@ -2802,9 +2800,9 @@ struct ixgbe_eeprom_info {
 struct ixgbe_mac_info {
         struct ixgbe_mac_operations     ops;
         enum ixgbe_mac_type             type;
-        u8                              addr[IXGBE_ETH_LENGTH_OF_ADDRESS];
-        u8                              perm_addr[IXGBE_ETH_LENGTH_OF_ADDRESS];
-        u8                              san_addr[IXGBE_ETH_LENGTH_OF_ADDRESS];
+        u8                              addr[ETH_ALEN];
+        u8                              perm_addr[ETH_ALEN];
+        u8                              san_addr[ETH_ALEN];
         /* prefix for World Wide Node Name (WWNN) */
         u16                             wwnn_prefix;
         /* prefix for World Wide Port Name (WWPN) */
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
index e5101e91b6b5..8cc5eccfd651 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
@@ -751,16 +751,20 @@ static s32 ixgbe_blink_led_start_X540(struct ixgbe_hw *hw, u32 index)
 {
         u32 macc_reg;
         u32 ledctl_reg;
+        ixgbe_link_speed speed;
+        bool link_up;
 
         /*
-         * In order for the blink bit in the LED control register
-         * to work, link and speed must be forced in the MAC. We
-         * will reverse this when we stop the blinking.
+         * Link should be up in order for the blink bit in the LED control
+         * register to work. Force link and speed in the MAC if link is down.
+         * This will be reversed when we stop the blinking.
          */
-        macc_reg = IXGBE_READ_REG(hw, IXGBE_MACC);
-        macc_reg |= IXGBE_MACC_FLU | IXGBE_MACC_FSV_10G | IXGBE_MACC_FS;
-        IXGBE_WRITE_REG(hw, IXGBE_MACC, macc_reg);
-
+        hw->mac.ops.check_link(hw, &speed, &link_up, false);
+        if (link_up == false) {
+                macc_reg = IXGBE_READ_REG(hw, IXGBE_MACC);
+                macc_reg |= IXGBE_MACC_FLU | IXGBE_MACC_FSV_10G | IXGBE_MACC_FS;
+                IXGBE_WRITE_REG(hw, IXGBE_MACC, macc_reg);
+        }
         /* Set the LED to LINK_UP + BLINK. */
         ledctl_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
         ledctl_reg &= ~IXGBE_LED_MODE_MASK(index);
diff --git a/drivers/net/ethernet/intel/ixgbevf/defines.h b/drivers/net/ethernet/intel/ixgbevf/defines.h
index 78abb6f1a866..2eb89cb94a0d 100644
--- a/drivers/net/ethernet/intel/ixgbevf/defines.h
+++ b/drivers/net/ethernet/intel/ixgbevf/defines.h
@@ -35,7 +35,6 @@
 #define IXGBE_VF_IRQ_CLEAR_MASK         7
 #define IXGBE_VF_MAX_TX_QUEUES          1
 #define IXGBE_VF_MAX_RX_QUEUES          1
-#define IXGBE_ETH_LENGTH_OF_ADDRESS     6
 
 /* Link speed */
 typedef u32 ixgbe_link_speed;
diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
index e29ba4506b74..149fa520d7f2 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
@@ -27,6 +27,8 @@
 
 /* ethtool support for ixgbevf */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/slab.h>
@@ -549,8 +551,8 @@ static const u32 register_test_patterns[] = {
         writel((W & M), (adapter->hw.hw_addr + R));                           \
         val = readl(adapter->hw.hw_addr + R);                                 \
         if ((W & M) != (val & M)) {                                           \
-                printk(KERN_ERR "set/check reg %04X test failed: got 0x%08X " \
-                                 "expected 0x%08X\n", R, (val & M), (W & M)); \
+                pr_err("set/check reg %04X test failed: got 0x%08X expected " \
+                       "0x%08X\n", R, (val & M), (W & M));                    \
                 *data = R;                                                    \
                 writel(before, (adapter->hw.hw_addr + R));                    \
                 return 1;                                                     \
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 4c8e19951d57..0c39bb1ac3bb 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -29,6 +29,9 @@
 /******************************************************************************
  Copyright (c)2006 - 2007 Myricom, Inc. for some LRO specific code
 ******************************************************************************/
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/bitops.h>
 #include <linux/module.h>
@@ -1437,7 +1440,7 @@ static int ixgbevf_write_uc_addr_list(struct net_device *netdev)
         int count = 0;
 
         if ((netdev_uc_count(netdev)) > 10) {
-                printk(KERN_ERR "Too many unicast filters - No Space\n");
+                pr_err("Too many unicast filters - No Space\n");
                 return -ENOSPC;
         }
 
@@ -2135,7 +2138,7 @@ static int ixgbevf_init_interrupt_scheme(struct ixgbevf_adapter *adapter)
 
         err = ixgbevf_alloc_queues(adapter);
         if (err) {
-                printk(KERN_ERR "Unable to allocate memory for queues\n");
+                pr_err("Unable to allocate memory for queues\n");
                 goto err_alloc_queues;
         }
 
@@ -2189,7 +2192,7 @@ static int __devinit ixgbevf_sw_init(struct ixgbevf_adapter *adapter)
         } else {
                 err = hw->mac.ops.init_hw(hw);
                 if (err) {
-                        printk(KERN_ERR "init_shared_code failed: %d\n", err);
+                        pr_err("init_shared_code failed: %d\n", err);
                         goto out;
                 }
         }
@@ -2630,8 +2633,8 @@ static int ixgbevf_open(struct net_device *netdev)
                  * the vf can't start. */
                 if (hw->adapter_stopped) {
                         err = IXGBE_ERR_MBX;
-                        printk(KERN_ERR "Unable to start - perhaps the PF"
-                               " Driver isn't up yet\n");
+                        pr_err("Unable to start - perhaps the PF Driver isn't "
+                               "up yet\n");
                         goto err_setup_reset;
                 }
         }
@@ -2842,10 +2845,8 @@ static bool ixgbevf_tx_csum(struct ixgbevf_adapter *adapter,
                                 break;
                         default:
                                 if (unlikely(net_ratelimit())) {
-                                        printk(KERN_WARNING
-                                               "partial checksum but "
-                                               "proto=%x!\n",
-                                               skb->protocol);
+                                        pr_warn("partial checksum but "
+                                                "proto=%x!\n", skb->protocol);
                                 }
                                 break;
                         }
@@ -3249,7 +3250,8 @@ static struct rtnl_link_stats64 *ixgbevf_get_stats(struct net_device *netdev,
         return stats;
 }
 
-static int ixgbevf_set_features(struct net_device *netdev, u32 features)
+static int ixgbevf_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct ixgbevf_adapter *adapter = netdev_priv(netdev);
 
@@ -3414,7 +3416,7 @@ static int __devinit ixgbevf_probe(struct pci_dev *pdev,
         memcpy(netdev->perm_addr, adapter->hw.mac.addr, netdev->addr_len);
 
         if (!is_valid_ether_addr(netdev->dev_addr)) {
-                printk(KERN_ERR "invalid MAC address\n");
+                pr_err("invalid MAC address\n");
                 err = -EIO;
                 goto err_sw_init;
         }
@@ -3535,10 +3537,10 @@ static struct pci_driver ixgbevf_driver = {
 static int __init ixgbevf_init_module(void)
 {
         int ret;
-        printk(KERN_INFO "ixgbevf: %s - version %s\n", ixgbevf_driver_string,
-               ixgbevf_driver_version);
+        pr_info("%s - version %s\n", ixgbevf_driver_string,
+                ixgbevf_driver_version);
 
-        printk(KERN_INFO "%s\n", ixgbevf_copyright);
+        pr_info("%s\n", ixgbevf_copyright);
 
         ret = pci_register_driver(&ixgbevf_driver);
         return ret;
diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
index aa3682e8c473..21533e300367 100644
--- a/drivers/net/ethernet/intel/ixgbevf/vf.c
+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
@@ -108,7 +108,7 @@ static s32 ixgbevf_reset_hw_vf(struct ixgbe_hw *hw)
         if (msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK))
                 return IXGBE_ERR_INVALID_MAC_ADDR;
 
-        memcpy(hw->mac.perm_addr, addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
+        memcpy(hw->mac.perm_addr, addr, ETH_ALEN);
         hw->mac.mc_filter_type = msgbuf[IXGBE_VF_MC_TYPE_WORD];
 
         return 0;
@@ -211,7 +211,7 @@ static s32 ixgbevf_mta_vector(struct ixgbe_hw *hw, u8 *mc_addr)
  **/
 static s32 ixgbevf_get_mac_addr_vf(struct ixgbe_hw *hw, u8 *mac_addr)
 {
-        memcpy(mac_addr, hw->mac.perm_addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
+        memcpy(mac_addr, hw->mac.perm_addr, ETH_ALEN);
 
         return 0;
 }
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 7becff1f387d..5c0b531949e2 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -1883,7 +1883,7 @@ jme_fill_tx_map(struct pci_dev *pdev,
                 struct page *page,
                 u32 page_offset,
                 u32 len,
-                u8 hidma)
+                bool hidma)
 {
         dma_addr_t dmaaddr;
 
@@ -1917,7 +1917,7 @@ jme_map_tx_skb(struct jme_adapter *jme, struct sk_buff *skb, int idx)
         struct jme_ring *txring = &(jme->txring[0]);
         struct txdesc *txdesc = txring->desc, *ctxdesc;
         struct jme_buffer_info *txbi = txring->bufinf, *ctxbi;
-        u8 hidma = jme->dev->features & NETIF_F_HIGHDMA;
+        bool hidma = jme->dev->features & NETIF_F_HIGHDMA;
         int i, nr_frags = skb_shinfo(skb)->nr_frags;
         int mask = jme->tx_ring_mask;
         const struct skb_frag_struct *frag;
@@ -2292,9 +2292,9 @@ jme_get_drvinfo(struct net_device *netdev,
 {
         struct jme_adapter *jme = netdev_priv(netdev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(jme->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(jme->pdev), sizeof(info->bus_info));
 }
 
 static int
@@ -2620,8 +2620,8 @@ jme_set_msglevel(struct net_device *netdev, u32 value)
         jme->msg_enable = value;
 }
 
-static u32
-jme_fix_features(struct net_device *netdev, u32 features)
+static netdev_features_t
+jme_fix_features(struct net_device *netdev, netdev_features_t features)
 {
         if (netdev->mtu > 1900)
                 features &= ~(NETIF_F_ALL_TSO | NETIF_F_ALL_CSUM);
@@ -2629,7 +2629,7 @@ jme_fix_features(struct net_device *netdev, u32 features)
 }
 
 static int
-jme_set_features(struct net_device *netdev, u32 features)
+jme_set_features(struct net_device *netdev, netdev_features_t features)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
 
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 194a03113802..43e3e6102149 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -1502,10 +1502,11 @@ mv643xx_eth_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static void mv643xx_eth_get_drvinfo(struct net_device *dev,
                                     struct ethtool_drvinfo *drvinfo)
 {
-        strncpy(drvinfo->driver,  mv643xx_eth_driver_name, 32);
-        strncpy(drvinfo->version, mv643xx_eth_driver_version, 32);
-        strncpy(drvinfo->fw_version, "N/A", 32);
-        strncpy(drvinfo->bus_info, "platform", 32);
+        strlcpy(drvinfo->driver, mv643xx_eth_driver_name, sizeof(info->driver));
+        strlcpy(drvinfo->version, mv643xx_eth_driver_version,
+                sizeof(info->version));
+        strlcpy(drvinfo->fw_version, "N/A", sizeof(info->fw_version));
+        strlcpy(drvinfo->bus_info, "platform", sizeof(info->bus_info));
         drvinfo->n_stats = ARRAY_SIZE(mv643xx_eth_stats);
 }
 
@@ -1578,10 +1579,10 @@ mv643xx_eth_set_ringparam(struct net_device *dev, struct ethtool_ringparam *er)
 
 
 static int
-mv643xx_eth_set_features(struct net_device *dev, u32 features)
+mv643xx_eth_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct mv643xx_eth_private *mp = netdev_priv(dev);
-        u32 rx_csum = features & NETIF_F_RXCSUM;
+        bool rx_csum = features & NETIF_F_RXCSUM;
 
         wrlp(mp, PORT_CONFIG, rx_csum ? 0x02000000 : 0x00000000);
 
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index c7b60839ac99..3943f5f7bb4a 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -394,10 +394,11 @@ static void skge_get_drvinfo(struct net_device *dev,
 {
         struct skge_port *skge = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
-        strcpy(info->bus_info, pci_name(skge->hw->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(skge->hw->pdev),
+                sizeof(info->bus_info));
 }
 
 static const struct skge_stat {
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 7803efa46eb2..ca33908bc7f3 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -1284,7 +1284,7 @@ static const uint32_t rss_init_key[10] = {
 };
 
 /* Enable/disable receive hash calculation (RSS) */
-static void rx_set_rss(struct net_device *dev, u32 features)
+static void rx_set_rss(struct net_device *dev, netdev_features_t features)
 {
         struct sky2_port *sky2 = netdev_priv(dev);
         struct sky2_hw *hw = sky2->hw;
@@ -1402,7 +1402,7 @@ static int sky2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 
 #define SKY2_VLAN_OFFLOADS (NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO)
 
-static void sky2_vlan_mode(struct net_device *dev, u32 features)
+static void sky2_vlan_mode(struct net_device *dev, netdev_features_t features)
 {
         struct sky2_port *sky2 = netdev_priv(dev);
         struct sky2_hw *hw = sky2->hw;
@@ -3643,10 +3643,11 @@ static void sky2_get_drvinfo(struct net_device *dev,
 {
         struct sky2_port *sky2 = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
-        strcpy(info->bus_info, pci_name(sky2->hw->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(sky2->hw->pdev),
+                sizeof(info->bus_info));
 }
 
 static const struct sky2_stat {
@@ -4311,7 +4312,8 @@ static int sky2_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom
         return sky2_vpd_write(sky2->hw, cap, data, eeprom->offset, eeprom->len);
 }
 
-static u32 sky2_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t sky2_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         const struct sky2_port *sky2 = netdev_priv(dev);
         const struct sky2_hw *hw = sky2->hw;
@@ -4335,13 +4337,13 @@ static u32 sky2_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int sky2_set_features(struct net_device *dev, u32 features)
+static int sky2_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct sky2_port *sky2 = netdev_priv(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if (changed & NETIF_F_RXCSUM) {
-                u32 on = features & NETIF_F_RXCSUM;
+                bool on = features & NETIF_F_RXCSUM;
                 sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
                              on ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
         }
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index 74e2a2a8a02b..ee637a200915 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -45,13 +45,16 @@ mlx4_en_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo)
         struct mlx4_en_priv *priv = netdev_priv(dev);
         struct mlx4_en_dev *mdev = priv->mdev;
 
-        strncpy(drvinfo->driver, DRV_NAME, 32);
-        strncpy(drvinfo->version, DRV_VERSION " (" DRV_RELDATE ")", 32);
-        sprintf(drvinfo->fw_version, "%d.%d.%d",
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, DRV_VERSION " (" DRV_RELDATE ")",
+                sizeof(drvinfo->version));
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                "%d.%d.%d",
                 (u16) (mdev->dev->caps.fw_ver >> 32),
                 (u16) ((mdev->dev->caps.fw_ver >> 16) & 0xffff),
                 (u16) (mdev->dev->caps.fw_ver & 0xffff));
-        strncpy(drvinfo->bus_info, pci_name(mdev->dev->pdev), 32);
+        strlcpy(drvinfo->bus_info, pci_name(mdev->dev->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = 0;
         drvinfo->regdump_len = 0;
         drvinfo->eedump_len = 0;
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 7ece990381c8..7abd510fe01f 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -743,8 +743,7 @@
 /* Change default LED mode. */
 #define SET_DEFAULT_LED                 LED_SPEED_DUPLEX_ACT
 
-#define MAC_ADDR_LEN                    6
-#define MAC_ADDR_ORDER(i)               (MAC_ADDR_LEN - 1 - (i))
+#define MAC_ADDR_ORDER(i)               (ETH_ALEN - 1 - (i))
 
 #define MAX_ETHERNET_BODY_SIZE          1500
 #define ETHERNET_HEADER_SIZE            14
@@ -1043,7 +1042,7 @@ enum {
  * @valid:      Valid setting indicating the entry is being used.
  */
 struct ksz_mac_table {
-        u8 mac_addr[MAC_ADDR_LEN];
+        u8 mac_addr[ETH_ALEN];
         u16 vid;
         u8 fid;
         u8 ports;
@@ -1187,8 +1186,8 @@ struct ksz_switch {
         u8 diffserv[DIFFSERV_ENTRIES];
         u8 p_802_1p[PRIO_802_1P_ENTRIES];
 
-        u8 br_addr[MAC_ADDR_LEN];
-        u8 other_addr[MAC_ADDR_LEN];
+        u8 br_addr[ETH_ALEN];
+        u8 other_addr[ETH_ALEN];
 
         u8 broad_per;
         u8 member;
@@ -1292,14 +1291,14 @@ struct ksz_hw {
         int tx_int_mask;
         int tx_size;
 
-        u8 perm_addr[MAC_ADDR_LEN];
-        u8 override_addr[MAC_ADDR_LEN];
-        u8 address[ADDITIONAL_ENTRIES][MAC_ADDR_LEN];
+        u8 perm_addr[ETH_ALEN];
+        u8 override_addr[ETH_ALEN];
+        u8 address[ADDITIONAL_ENTRIES][ETH_ALEN];
         u8 addr_list_size;
         u8 mac_override;
         u8 promiscuous;
         u8 all_multi;
-        u8 multi_list[MAX_MULTICAST_LIST][MAC_ADDR_LEN];
+        u8 multi_list[MAX_MULTICAST_LIST][ETH_ALEN];
         u8 multi_bits[HW_MULTICAST_SIZE];
         u8 multi_list_size;
 
@@ -3654,7 +3653,7 @@ static void hw_add_wol_bcast(struct ksz_hw *hw)
         static const u8 mask[] = { 0x3F };
         static const u8 pattern[] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
 
-        hw_set_wol_frame(hw, 2, 1, mask, MAC_ADDR_LEN, pattern);
+        hw_set_wol_frame(hw, 2, 1, mask, ETH_ALEN, pattern);
 }
 
 /**
@@ -3689,7 +3688,7 @@ static void hw_add_wol_ucast(struct ksz_hw *hw)
 {
         static const u8 mask[] = { 0x3F };
 
-        hw_set_wol_frame(hw, 0, 1, mask, MAC_ADDR_LEN, hw->override_addr);
+        hw_set_wol_frame(hw, 0, 1, mask, ETH_ALEN, hw->override_addr);
 }
 
 /**
@@ -4055,7 +4054,7 @@ static void hw_set_addr(struct ksz_hw *hw)
 {
         int i;
 
-        for (i = 0; i < MAC_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 writeb(hw->override_addr[MAC_ADDR_ORDER(i)],
                         hw->io + KS884X_ADDR_0_OFFSET + i);
 
@@ -4072,17 +4071,16 @@ static void hw_read_addr(struct ksz_hw *hw)
 {
         int i;
 
-        for (i = 0; i < MAC_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 hw->perm_addr[MAC_ADDR_ORDER(i)] = readb(hw->io +
                         KS884X_ADDR_0_OFFSET + i);
 
         if (!hw->mac_override) {
-                memcpy(hw->override_addr, hw->perm_addr, MAC_ADDR_LEN);
+                memcpy(hw->override_addr, hw->perm_addr, ETH_ALEN);
                 if (empty_addr(hw->override_addr)) {
-                        memcpy(hw->perm_addr, DEFAULT_MAC_ADDRESS,
-                                MAC_ADDR_LEN);
+                        memcpy(hw->perm_addr, DEFAULT_MAC_ADDRESS, ETH_ALEN);
                         memcpy(hw->override_addr, DEFAULT_MAC_ADDRESS,
-                                MAC_ADDR_LEN);
+                               ETH_ALEN);
                         hw->override_addr[5] += hw->id;
                         hw_set_addr(hw);
                 }
@@ -4130,16 +4128,16 @@ static int hw_add_addr(struct ksz_hw *hw, u8 *mac_addr)
         int i;
         int j = ADDITIONAL_ENTRIES;
 
-        if (!memcmp(hw->override_addr, mac_addr, MAC_ADDR_LEN))
+        if (!memcmp(hw->override_addr, mac_addr, ETH_ALEN))
                 return 0;
         for (i = 0; i < hw->addr_list_size; i++) {
-                if (!memcmp(hw->address[i], mac_addr, MAC_ADDR_LEN))
+                if (!memcmp(hw->address[i], mac_addr, ETH_ALEN))
                         return 0;
                 if (ADDITIONAL_ENTRIES == j && empty_addr(hw->address[i]))
                         j = i;
         }
         if (j < ADDITIONAL_ENTRIES) {
-                memcpy(hw->address[j], mac_addr, MAC_ADDR_LEN);
+                memcpy(hw->address[j], mac_addr, ETH_ALEN);
                 hw_ena_add_addr(hw, j, hw->address[j]);
                 return 0;
         }
@@ -4151,8 +4149,8 @@ static int hw_del_addr(struct ksz_hw *hw, u8 *mac_addr)
         int i;
 
         for (i = 0; i < hw->addr_list_size; i++) {
-                if (!memcmp(hw->address[i], mac_addr, MAC_ADDR_LEN)) {
-                        memset(hw->address[i], 0, MAC_ADDR_LEN);
+                if (!memcmp(hw->address[i], mac_addr, ETH_ALEN)) {
+                        memset(hw->address[i], 0, ETH_ALEN);
                         writel(0, hw->io + ADD_ADDR_INCR * i +
                                 KS_ADD_ADDR_0_HI);
                         return 0;
@@ -5676,7 +5674,7 @@ static int netdev_set_mac_address(struct net_device *dev, void *addr)
                 hw_del_addr(hw, dev->dev_addr);
         else {
                 hw->mac_override = 1;
-                memcpy(hw->override_addr, mac->sa_data, MAC_ADDR_LEN);
+                memcpy(hw->override_addr, mac->sa_data, ETH_ALEN);
         }
 
         memcpy(dev->dev_addr, mac->sa_data, MAX_ADDR_LEN);
@@ -5786,7 +5784,7 @@ static void netdev_set_rx_mode(struct net_device *dev)
                 netdev_for_each_mc_addr(ha, dev) {
                         if (i >= MAX_MULTICAST_LIST)
                                 break;
-                        memcpy(hw->multi_list[i++], ha->addr, MAC_ADDR_LEN);
+                        memcpy(hw->multi_list[i++], ha->addr, ETH_ALEN);
                 }
                 hw->multi_list_size = (u8) i;
                 hw_set_grp_addr(hw);
@@ -6093,9 +6091,10 @@ static void netdev_get_drvinfo(struct net_device *dev,
         struct dev_priv *priv = netdev_priv(dev);
         struct dev_info *hw_priv = priv->adapter;
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(hw_priv->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(hw_priv->pdev),
+                sizeof(info->bus_info));
 }
 
 /**
@@ -6587,7 +6586,8 @@ static void netdev_get_ethtool_stats(struct net_device *dev,
  *
  * Return 0 if successful; otherwise an error code.
  */
-static int netdev_set_features(struct net_device *dev, u32 features)
+static int netdev_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct dev_priv *priv = netdev_priv(dev);
         struct dev_info *hw_priv = priv->adapter;
@@ -6860,7 +6860,7 @@ static void get_mac_addr(struct dev_info *hw_priv, u8 *macaddr, int port)
         int num;
 
         i = j = num = got_num = 0;
-        while (j < MAC_ADDR_LEN) {
+        while (j < ETH_ALEN) {
                 if (macaddr[i]) {
                         int digit;
 
@@ -6891,7 +6891,7 @@ static void get_mac_addr(struct dev_info *hw_priv, u8 *macaddr, int port)
                 }
                 i++;
         }
-        if (MAC_ADDR_LEN == j) {
+        if (ETH_ALEN == j) {
                 if (MAIN_PORT == port)
                         hw_priv->hw.mac_override = 1;
         }
@@ -7058,7 +7058,7 @@ static int __devinit pcidev_init(struct pci_dev *pdev,
 
         /* Multiple device interfaces mode requires a second MAC address. */
         if (hw->dev_count > 1) {
-                memcpy(sw->other_addr, hw->override_addr, MAC_ADDR_LEN);
+                memcpy(sw->other_addr, hw->override_addr, ETH_ALEN);
                 read_other_addr(hw);
                 if (mac1addr[0] != ':')
                         get_mac_addr(hw_priv, mac1addr, OTHER_PORT);
@@ -7108,12 +7108,11 @@ static int __devinit pcidev_init(struct pci_dev *pdev,
                 dev->irq = pdev->irq;
                 if (MAIN_PORT == i)
                         memcpy(dev->dev_addr, hw_priv->hw.override_addr,
-                                MAC_ADDR_LEN);
+                               ETH_ALEN);
                 else {
-                        memcpy(dev->dev_addr, sw->other_addr,
-                                MAC_ADDR_LEN);
+                        memcpy(dev->dev_addr, sw->other_addr, ETH_ALEN);
                         if (!memcmp(sw->other_addr, hw->override_addr,
-                                        MAC_ADDR_LEN))
+                                    ETH_ALEN))
                                 dev->dev_addr[5] += port->first_port;
                 }
 
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 0778edcf7b9a..20b72ecb020a 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -1491,7 +1491,7 @@ myri10ge_clean_rx_done(struct myri10ge_slice_state *ss, int budget)
          * access to avoid theoretical race condition with functions that
          * change NETIF_F_LRO flag at runtime.
          */
-        bool lro_enabled = ACCESS_ONCE(mgp->dev->features) & NETIF_F_LRO;
+        bool lro_enabled = !!(ACCESS_ONCE(mgp->dev->features) & NETIF_F_LRO);
 
         while (rx_done->entry[idx].length != 0 && work_done < budget) {
                 length = ntohs(rx_done->entry[idx].length);
@@ -3149,7 +3149,8 @@ static int myri10ge_set_mac_address(struct net_device *dev, void *addr)
         return 0;
 }
 
-static u32 myri10ge_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t myri10ge_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         if (!(features & NETIF_F_RXCSUM))
                 features &= ~NETIF_F_LRO;
diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c
index 6ca047aab793..ac7b16b6e7af 100644
--- a/drivers/net/ethernet/natsemi/natsemi.c
+++ b/drivers/net/ethernet/natsemi/natsemi.c
@@ -2555,9 +2555,9 @@ static void set_rx_mode(struct net_device *dev)
 static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct netdev_private *np = netdev_priv(dev);
-        strncpy(info->driver, DRV_NAME, ETHTOOL_BUSINFO_LEN);
-        strncpy(info->version, DRV_VERSION, ETHTOOL_BUSINFO_LEN);
-        strncpy(info->bus_info, pci_name(np->pci_dev), ETHTOOL_BUSINFO_LEN);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int get_regs_len(struct net_device *dev)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index 2b8f64ddfb55..c24b46cbfe27 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -1364,9 +1364,9 @@ static int ns83820_set_settings(struct net_device *ndev,
 static void ns83820_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *info)
 {
         struct ns83820 *dev = PRIV(ndev);
-        strcpy(info->driver, "ns83820");
-        strcpy(info->version, VERSION);
-        strcpy(info->bus_info, pci_name(dev->pci_dev));
+        strlcpy(info->driver, "ns83820", sizeof(info->driver));
+        strlcpy(info->version, VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(dev->pci_dev), sizeof(info->bus_info));
 }
 
 static u32 ns83820_get_link(struct net_device *ndev)
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index c27fb3dda9f4..76ae47627200 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -5391,10 +5391,10 @@ static void s2io_ethtool_gdrvinfo(struct net_device *dev,
 {
         struct s2io_nic *sp = netdev_priv(dev);
 
-        strncpy(info->driver, s2io_driver_name, sizeof(info->driver));
-        strncpy(info->version, s2io_driver_version, sizeof(info->version));
-        strncpy(info->fw_version, "", sizeof(info->fw_version));
-        strncpy(info->bus_info, pci_name(sp->pdev), sizeof(info->bus_info));
+        strlcpy(info->driver, s2io_driver_name, sizeof(info->driver));
+        strlcpy(info->version, s2io_driver_version, sizeof(info->version));
+        strlcpy(info->fw_version, "", sizeof(info->fw_version));
+        strlcpy(info->bus_info, pci_name(sp->pdev), sizeof(info->bus_info));
         info->regdump_len = XENA_REG_SPACE;
         info->eedump_len = XENA_EEPROM_SPACE;
 }
@@ -6616,10 +6616,10 @@ static void s2io_ethtool_get_strings(struct net_device *dev,
         }
 }
 
-static int s2io_set_features(struct net_device *dev, u32 features)
+static int s2io_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct s2io_nic *sp = netdev_priv(dev);
-        u32 changed = (features ^ dev->features) & NETIF_F_LRO;
+        netdev_features_t changed = (features ^ dev->features) & NETIF_F_LRO;
 
         if (changed && netif_running(dev)) {
                 int rc;
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index a83197d757c1..16d4d8e913c3 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -2662,9 +2662,10 @@ static void vxge_poll_vp_lockup(unsigned long data)
         mod_timer(&vdev->vp_lockup_timer, jiffies + HZ / 1000);
 }
 
-static u32 vxge_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t vxge_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         /* Enabling RTH requires some of the logic in vxge_device_register and a
          * vpath reset.  Due to these restrictions, only allow modification
@@ -2676,10 +2677,10 @@ static u32 vxge_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int vxge_set_features(struct net_device *dev, u32 features)
+static int vxge_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct vxgedev *vdev = netdev_priv(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
 
         if (!(changed & NETIF_F_RXHASH))
                 return 0;
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 1c61d36e6570..8db0b376d5b7 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -65,7 +65,8 @@
 #include <linux/slab.h>
 #include <linux/uaccess.h>
 #include <linux/prefetch.h>
-#include  <linux/io.h>
+#include <linux/u64_stats_sync.h>
+#include <linux/io.h>
 
 #include <asm/irq.h>
 #include <asm/system.h>
@@ -736,6 +737,16 @@ struct nv_skb_map {
  * - tx setup is lockless: it relies on netif_tx_lock. Actual submission
  *      needs netdev_priv(dev)->lock :-(
  * - set_multicast_list: preparation lockless, relies on netif_tx_lock.
+ *
+ * Hardware stats updates are protected by hwstats_lock:
+ * - updated by nv_do_stats_poll (timer). This is meant to avoid
+ *   integer wraparound in the NIC stats registers, at low frequency
+ *   (0.1 Hz)
+ * - updated by nv_get_ethtool_stats + nv_get_stats64
+ *
+ * Software stats are accessed only through 64b synchronization points
+ * and are not subject to other synchronization techniques (single
+ * update thread on the TX or RX paths).
  */
 
 /* in dev: base, irq */
@@ -745,9 +756,10 @@ struct fe_priv {
         struct net_device *dev;
         struct napi_struct napi;
 
-        /* General data:
-         * Locking: spin_lock(&np->lock); */
+        /* hardware stats are updated in syscall and timer */
+        spinlock_t hwstats_lock;
         struct nv_ethtool_stats estats;
+
         int in_shutdown;
         u32 linkspeed;
         int duplex;
@@ -798,6 +810,13 @@ struct fe_priv {
         u32 nic_poll_irq;
         int rx_ring_size;
 
+        /* RX software stats */
+        struct u64_stats_sync swstats_rx_syncp;
+        u64 stat_rx_packets;
+        u64 stat_rx_bytes; /* not always available in HW */
+        u64 stat_rx_missed_errors;
+        u64 stat_rx_dropped;
+
         /* media detection workaround.
          * Locking: Within irq hander or disable_irq+spin_lock(&np->lock);
          */
@@ -820,6 +839,12 @@ struct fe_priv {
         struct nv_skb_map *tx_end_flip;
         int tx_stop;
 
+        /* TX software stats */
+        struct u64_stats_sync swstats_tx_syncp;
+        u64 stat_tx_packets; /* not always available in HW */
+        u64 stat_tx_bytes;
+        u64 stat_tx_dropped;
+
         /* msi/msi-x fields */
         u32 msi_flags;
         struct msix_entry msi_x_entry[NV_MSI_X_MAX_VECTORS];
@@ -892,6 +917,11 @@ enum {
 static int dma_64bit = NV_DMA_64BIT_ENABLED;
 
 /*
+ * Debug output control for tx_timeout
+ */
+static bool debug_tx_timeout = false;
+
+/*
  * Crossover Detection
  * Realtek 8201 phy + some OEM boards do not work properly.
  */
@@ -1630,11 +1660,19 @@ static void nv_mac_reset(struct net_device *dev)
         pci_push(base);
 }
 
-static void nv_get_hw_stats(struct net_device *dev)
+/* Caller must appropriately lock netdev_priv(dev)->hwstats_lock */
+static void nv_update_stats(struct net_device *dev)
 {
         struct fe_priv *np = netdev_priv(dev);
         u8 __iomem *base = get_hwbase(dev);
 
+        /* If it happens that this is run in top-half context, then
+         * replace the spin_lock of hwstats_lock with
+         * spin_lock_irqsave() in calling functions. */
+        WARN_ONCE(in_irq(), "forcedeth: estats spin_lock(_bh) from top-half");
+        assert_spin_locked(&np->hwstats_lock);
+
+        /* query hardware */
         np->estats.tx_bytes += readl(base + NvRegTxCnt);
         np->estats.tx_zero_rexmt += readl(base + NvRegTxZeroReXmt);
         np->estats.tx_one_rexmt += readl(base + NvRegTxOneReXmt);
@@ -1693,40 +1731,73 @@ static void nv_get_hw_stats(struct net_device *dev)
 }
 
 /*
- * nv_get_stats: dev->get_stats function
+ * nv_get_stats64: dev->ndo_get_stats64 function
  * Get latest stats value from the nic.
  * Called with read_lock(&dev_base_lock) held for read -
  * only synchronized against unregister_netdevice.
  */
-static struct net_device_stats *nv_get_stats(struct net_device *dev)
+static struct rtnl_link_stats64*
+nv_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *storage)
+        __acquires(&netdev_priv(dev)->hwstats_lock)
+        __releases(&netdev_priv(dev)->hwstats_lock)
 {
         struct fe_priv *np = netdev_priv(dev);
+        unsigned int syncp_start;
+
+        /*
+         * Note: because HW stats are not always available and for
+         * consistency reasons, the following ifconfig stats are
+         * managed by software: rx_bytes, tx_bytes, rx_packets and
+         * tx_packets. The related hardware stats reported by ethtool
+         * should be equivalent to these ifconfig stats, with 4
+         * additional bytes per packet (Ethernet FCS CRC), except for
+         * tx_packets when TSO kicks in.
+         */
+
+        /* software stats */
+        do {
+                syncp_start = u64_stats_fetch_begin_bh(&np->swstats_rx_syncp);
+                storage->rx_packets       = np->stat_rx_packets;
+                storage->rx_bytes         = np->stat_rx_bytes;
+                storage->rx_dropped       = np->stat_rx_dropped;
+                storage->rx_missed_errors = np->stat_rx_missed_errors;
+        } while (u64_stats_fetch_retry_bh(&np->swstats_rx_syncp, syncp_start));
+
+        do {
+                syncp_start = u64_stats_fetch_begin_bh(&np->swstats_tx_syncp);
+                storage->tx_packets = np->stat_tx_packets;
+                storage->tx_bytes   = np->stat_tx_bytes;
+                storage->tx_dropped = np->stat_tx_dropped;
+        } while (u64_stats_fetch_retry_bh(&np->swstats_tx_syncp, syncp_start));
 
         /* If the nic supports hw counters then retrieve latest values */
-        if (np->driver_data & (DEV_HAS_STATISTICS_V1|DEV_HAS_STATISTICS_V2|DEV_HAS_STATISTICS_V3)) {
-                nv_get_hw_stats(dev);
+        if (np->driver_data & DEV_HAS_STATISTICS_V123) {
+                spin_lock_bh(&np->hwstats_lock);
 
-                /*
-                 * Note: because HW stats are not always available and
-                 * for consistency reasons, the following ifconfig
-                 * stats are managed by software: rx_bytes, tx_bytes,
-                 * rx_packets and tx_packets. The related hardware
-                 * stats reported by ethtool should be equivalent to
-                 * these ifconfig stats, with 4 additional bytes per
-                 * packet (Ethernet FCS CRC).
-                 */
+                nv_update_stats(dev);
 
-                /* copy to net_device stats */
-                dev->stats.tx_fifo_errors = np->estats.tx_fifo_errors;
-                dev->stats.tx_carrier_errors = np->estats.tx_carrier_errors;
-                dev->stats.rx_crc_errors = np->estats.rx_crc_errors;
-                dev->stats.rx_over_errors = np->estats.rx_over_errors;
-                dev->stats.rx_fifo_errors = np->estats.rx_drop_frame;
-                dev->stats.rx_errors = np->estats.rx_errors_total;
-                dev->stats.tx_errors = np->estats.tx_errors_total;
+                /* generic stats */
+                storage->rx_errors = np->estats.rx_errors_total;
+                storage->tx_errors = np->estats.tx_errors_total;
+
+                /* meaningful only when NIC supports stats v3 */
+                storage->multicast = np->estats.rx_multicast;
+
+                /* detailed rx_errors */
+                storage->rx_length_errors = np->estats.rx_length_error;
+                storage->rx_over_errors   = np->estats.rx_over_errors;
+                storage->rx_crc_errors    = np->estats.rx_crc_errors;
+                storage->rx_frame_errors  = np->estats.rx_frame_align_error;
+                storage->rx_fifo_errors   = np->estats.rx_drop_frame;
+
+                /* detailed tx_errors */
+                storage->tx_carrier_errors = np->estats.tx_carrier_errors;
+                storage->tx_fifo_errors    = np->estats.tx_fifo_errors;
+
+                spin_unlock_bh(&np->hwstats_lock);
         }
 
-        return &dev->stats;
+        return storage;
 }
 
 /*
@@ -1759,8 +1830,12 @@ static int nv_alloc_rx(struct net_device *dev)
                                 np->put_rx.orig = np->first_rx.orig;
                         if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
                                 np->put_rx_ctx = np->first_rx_ctx;
-                } else
+                } else {
+                        u64_stats_update_begin(&np->swstats_rx_syncp);
+                        np->stat_rx_dropped++;
+                        u64_stats_update_end(&np->swstats_rx_syncp);
                         return 1;
+                }
         }
         return 0;
 }
@@ -1791,8 +1866,12 @@ static int nv_alloc_rx_optimized(struct net_device *dev)
                                 np->put_rx.ex = np->first_rx.ex;
                         if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
                                 np->put_rx_ctx = np->first_rx_ctx;
-                } else
+                } else {
+                        u64_stats_update_begin(&np->swstats_rx_syncp);
+                        np->stat_rx_dropped++;
+                        u64_stats_update_end(&np->swstats_rx_syncp);
                         return 1;
+                }
         }
         return 0;
 }
@@ -1927,8 +2006,11 @@ static void nv_drain_tx(struct net_device *dev)
                         np->tx_ring.ex[i].bufhigh = 0;
                         np->tx_ring.ex[i].buflow = 0;
                 }
-                if (nv_release_txskb(np, &np->tx_skb[i]))
-                        dev->stats.tx_dropped++;
+                if (nv_release_txskb(np, &np->tx_skb[i])) {
+                        u64_stats_update_begin(&np->swstats_tx_syncp);
+                        np->stat_tx_dropped++;
+                        u64_stats_update_end(&np->swstats_tx_syncp);
+                }
                 np->tx_skb[i].dma = 0;
                 np->tx_skb[i].dma_len = 0;
                 np->tx_skb[i].dma_single = 0;
@@ -2385,11 +2467,14 @@ static int nv_tx_done(struct net_device *dev, int limit)
                 if (np->desc_ver == DESC_VER_1) {
                         if (flags & NV_TX_LASTPACKET) {
                                 if (flags & NV_TX_ERROR) {
-                                        if ((flags & NV_TX_RETRYERROR) && !(flags & NV_TX_RETRYCOUNT_MASK))
+                                        if ((flags & NV_TX_RETRYERROR)
+                                            && !(flags & NV_TX_RETRYCOUNT_MASK))
                                                 nv_legacybackoff_reseed(dev);
                                 } else {
-                                        dev->stats.tx_packets++;
-                                        dev->stats.tx_bytes += np->get_tx_ctx->skb->len;
+                                        u64_stats_update_begin(&np->swstats_tx_syncp);
+                                        np->stat_tx_packets++;
+                                        np->stat_tx_bytes += np->get_tx_ctx->skb->len;
+                                        u64_stats_update_end(&np->swstats_tx_syncp);
                                 }
                                 dev_kfree_skb_any(np->get_tx_ctx->skb);
                                 np->get_tx_ctx->skb = NULL;
@@ -2398,11 +2483,14 @@ static int nv_tx_done(struct net_device *dev, int limit)
                 } else {
                         if (flags & NV_TX2_LASTPACKET) {
                                 if (flags & NV_TX2_ERROR) {
-                                        if ((flags & NV_TX2_RETRYERROR) && !(flags & NV_TX2_RETRYCOUNT_MASK))
+                                        if ((flags & NV_TX2_RETRYERROR)
+                                            && !(flags & NV_TX2_RETRYCOUNT_MASK))
                                                 nv_legacybackoff_reseed(dev);
                                 } else {
-                                        dev->stats.tx_packets++;
-                                        dev->stats.tx_bytes += np->get_tx_ctx->skb->len;
+                                        u64_stats_update_begin(&np->swstats_tx_syncp);
+                                        np->stat_tx_packets++;
+                                        np->stat_tx_bytes += np->get_tx_ctx->skb->len;
+                                        u64_stats_update_end(&np->swstats_tx_syncp);
                                 }
                                 dev_kfree_skb_any(np->get_tx_ctx->skb);
                                 np->get_tx_ctx->skb = NULL;
@@ -2436,15 +2524,18 @@ static int nv_tx_done_optimized(struct net_device *dev, int limit)
 
                 if (flags & NV_TX2_LASTPACKET) {
                         if (flags & NV_TX2_ERROR) {
-                                if ((flags & NV_TX2_RETRYERROR) && !(flags & NV_TX2_RETRYCOUNT_MASK)) {
+                                if ((flags & NV_TX2_RETRYERROR)
+                                    && !(flags & NV_TX2_RETRYCOUNT_MASK)) {
                                         if (np->driver_data & DEV_HAS_GEAR_MODE)
                                                 nv_gear_backoff_reseed(dev);
                                         else
                                                 nv_legacybackoff_reseed(dev);
                                 }
                         } else {
-                                dev->stats.tx_packets++;
-                                dev->stats.tx_bytes += np->get_tx_ctx->skb->len;
+                                u64_stats_update_begin(&np->swstats_tx_syncp);
+                                np->stat_tx_packets++;
+                                np->stat_tx_bytes += np->get_tx_ctx->skb->len;
+                                u64_stats_update_end(&np->swstats_tx_syncp);
                         }
 
                         dev_kfree_skb_any(np->get_tx_ctx->skb);
@@ -2477,56 +2568,64 @@ static void nv_tx_timeout(struct net_device *dev)
         u32 status;
         union ring_type put_tx;
         int saved_tx_limit;
-        int i;
 
         if (np->msi_flags & NV_MSI_X_ENABLED)
                 status = readl(base + NvRegMSIXIrqStatus) & NVREG_IRQSTAT_MASK;
         else
                 status = readl(base + NvRegIrqStatus) & NVREG_IRQSTAT_MASK;
 
-        netdev_info(dev, "Got tx_timeout. irq: %08x\n", status);
+        netdev_warn(dev, "Got tx_timeout. irq status: %08x\n", status);
 
-        netdev_info(dev, "Ring at %lx\n", (unsigned long)np->ring_addr);
-        netdev_info(dev, "Dumping tx registers\n");
-        for (i = 0; i <= np->register_size; i += 32) {
-                netdev_info(dev,
-                            "%3x: %08x %08x %08x %08x %08x %08x %08x %08x\n",
-                            i,
-                            readl(base + i + 0), readl(base + i + 4),
-                            readl(base + i + 8), readl(base + i + 12),
-                            readl(base + i + 16), readl(base + i + 20),
-                            readl(base + i + 24), readl(base + i + 28));
-        }
-        netdev_info(dev, "Dumping tx ring\n");
-        for (i = 0; i < np->tx_ring_size; i += 4) {
-                if (!nv_optimized(np)) {
-                        netdev_info(dev,
-                                    "%03x: %08x %08x // %08x %08x // %08x %08x // %08x %08x\n",
-                                    i,
-                                    le32_to_cpu(np->tx_ring.orig[i].buf),
-                                    le32_to_cpu(np->tx_ring.orig[i].flaglen),
-                                    le32_to_cpu(np->tx_ring.orig[i+1].buf),
-                                    le32_to_cpu(np->tx_ring.orig[i+1].flaglen),
-                                    le32_to_cpu(np->tx_ring.orig[i+2].buf),
-                                    le32_to_cpu(np->tx_ring.orig[i+2].flaglen),
-                                    le32_to_cpu(np->tx_ring.orig[i+3].buf),
-                                    le32_to_cpu(np->tx_ring.orig[i+3].flaglen));
-                } else {
+        if (unlikely(debug_tx_timeout)) {
+                int i;
+
+                netdev_info(dev, "Ring at %lx\n", (unsigned long)np->ring_addr);
+                netdev_info(dev, "Dumping tx registers\n");
+                for (i = 0; i <= np->register_size; i += 32) {
                         netdev_info(dev,
-                                    "%03x: %08x %08x %08x // %08x %08x %08x // %08x %08x %08x // %08x %08x %08x\n",
+                                    "%3x: %08x %08x %08x %08x "
+                                    "%08x %08x %08x %08x\n",
                                     i,
-                                    le32_to_cpu(np->tx_ring.ex[i].bufhigh),
-                                    le32_to_cpu(np->tx_ring.ex[i].buflow),
-                                    le32_to_cpu(np->tx_ring.ex[i].flaglen),
-                                    le32_to_cpu(np->tx_ring.ex[i+1].bufhigh),
-                                    le32_to_cpu(np->tx_ring.ex[i+1].buflow),
-                                    le32_to_cpu(np->tx_ring.ex[i+1].flaglen),
-                                    le32_to_cpu(np->tx_ring.ex[i+2].bufhigh),
-                                    le32_to_cpu(np->tx_ring.ex[i+2].buflow),
-                                    le32_to_cpu(np->tx_ring.ex[i+2].flaglen),
-                                    le32_to_cpu(np->tx_ring.ex[i+3].bufhigh),
-                                    le32_to_cpu(np->tx_ring.ex[i+3].buflow),
-                                    le32_to_cpu(np->tx_ring.ex[i+3].flaglen));
+                                    readl(base + i + 0), readl(base + i + 4),
+                                    readl(base + i + 8), readl(base + i + 12),
+                                    readl(base + i + 16), readl(base + i + 20),
+                                    readl(base + i + 24), readl(base + i + 28));
+                }
+                netdev_info(dev, "Dumping tx ring\n");
+                for (i = 0; i < np->tx_ring_size; i += 4) {
+                        if (!nv_optimized(np)) {
+                                netdev_info(dev,
+                                            "%03x: %08x %08x // %08x %08x "
+                                            "// %08x %08x // %08x %08x\n",
+                                            i,
+                                            le32_to_cpu(np->tx_ring.orig[i].buf),
+                                            le32_to_cpu(np->tx_ring.orig[i].flaglen),
+                                            le32_to_cpu(np->tx_ring.orig[i+1].buf),
+                                            le32_to_cpu(np->tx_ring.orig[i+1].flaglen),
+                                            le32_to_cpu(np->tx_ring.orig[i+2].buf),
+                                            le32_to_cpu(np->tx_ring.orig[i+2].flaglen),
+                                            le32_to_cpu(np->tx_ring.orig[i+3].buf),
+                                            le32_to_cpu(np->tx_ring.orig[i+3].flaglen));
+                        } else {
+                                netdev_info(dev,
+                                            "%03x: %08x %08x %08x "
+                                            "// %08x %08x %08x "
+                                            "// %08x %08x %08x "
+                                            "// %08x %08x %08x\n",
+                                            i,
+                                            le32_to_cpu(np->tx_ring.ex[i].bufhigh),
+                                            le32_to_cpu(np->tx_ring.ex[i].buflow),
+                                            le32_to_cpu(np->tx_ring.ex[i].flaglen),
+                                            le32_to_cpu(np->tx_ring.ex[i+1].bufhigh),
+                                            le32_to_cpu(np->tx_ring.ex[i+1].buflow),
+                                            le32_to_cpu(np->tx_ring.ex[i+1].flaglen),
+                                            le32_to_cpu(np->tx_ring.ex[i+2].bufhigh),
+                                            le32_to_cpu(np->tx_ring.ex[i+2].buflow),
+                                            le32_to_cpu(np->tx_ring.ex[i+2].flaglen),
+                                            le32_to_cpu(np->tx_ring.ex[i+3].bufhigh),
+                                            le32_to_cpu(np->tx_ring.ex[i+3].buflow),
+                                            le32_to_cpu(np->tx_ring.ex[i+3].flaglen));
+                        }
                 }
         }
 
@@ -2649,8 +2748,11 @@ static int nv_rx_process(struct net_device *dev, int limit)
                                         }
                                         /* the rest are hard errors */
                                         else {
-                                                if (flags & NV_RX_MISSEDFRAME)
-                                                        dev->stats.rx_missed_errors++;
+                                                if (flags & NV_RX_MISSEDFRAME) {
+                                                        u64_stats_update_begin(&np->swstats_rx_syncp);
+                                                        np->stat_rx_missed_errors++;
+                                                        u64_stats_update_end(&np->swstats_rx_syncp);
+                                                }
                                                 dev_kfree_skb(skb);
                                                 goto next_pkt;
                                         }
@@ -2693,8 +2795,10 @@ static int nv_rx_process(struct net_device *dev, int limit)
                 skb_put(skb, len);
                 skb->protocol = eth_type_trans(skb, dev);
                 napi_gro_receive(&np->napi, skb);
-                dev->stats.rx_packets++;
-                dev->stats.rx_bytes += len;
+                u64_stats_update_begin(&np->swstats_rx_syncp);
+                np->stat_rx_packets++;
+                np->stat_rx_bytes += len;
+                u64_stats_update_end(&np->swstats_rx_syncp);
 next_pkt:
                 if (unlikely(np->get_rx.orig++ == np->last_rx.orig))
                         np->get_rx.orig = np->first_rx.orig;
@@ -2777,8 +2881,10 @@ static int nv_rx_process_optimized(struct net_device *dev, int limit)
                                 __vlan_hwaccel_put_tag(skb, vid);
                         }
                         napi_gro_receive(&np->napi, skb);
-                        dev->stats.rx_packets++;
-                        dev->stats.rx_bytes += len;
+                        u64_stats_update_begin(&np->swstats_rx_syncp);
+                        np->stat_rx_packets++;
+                        np->stat_rx_bytes += len;
+                        u64_stats_update_end(&np->swstats_rx_syncp);
                 } else {
                         dev_kfree_skb(skb);
                 }
@@ -3021,6 +3127,73 @@ static void nv_update_pause(struct net_device *dev, u32 pause_flags)
         }
 }
 
+static void nv_force_linkspeed(struct net_device *dev, int speed, int duplex)
+{
+        struct fe_priv *np = netdev_priv(dev);
+        u8 __iomem *base = get_hwbase(dev);
+        u32 phyreg, txreg;
+        int mii_status;
+
+        np->linkspeed = NVREG_LINKSPEED_FORCE|speed;
+        np->duplex = duplex;
+
+        /* see if gigabit phy */
+        mii_status = mii_rw(dev, np->phyaddr, MII_BMSR, MII_READ);
+        if (mii_status & PHY_GIGABIT) {
+                np->gigabit = PHY_GIGABIT;
+                phyreg = readl(base + NvRegSlotTime);
+                phyreg &= ~(0x3FF00);
+                if ((np->linkspeed & 0xFFF) == NVREG_LINKSPEED_10)
+                        phyreg |= NVREG_SLOTTIME_10_100_FULL;
+                else if ((np->linkspeed & 0xFFF) == NVREG_LINKSPEED_100)
+                        phyreg |= NVREG_SLOTTIME_10_100_FULL;
+                else if ((np->linkspeed & 0xFFF) == NVREG_LINKSPEED_1000)
+                        phyreg |= NVREG_SLOTTIME_1000_FULL;
+                writel(phyreg, base + NvRegSlotTime);
+        }
+
+        phyreg = readl(base + NvRegPhyInterface);
+        phyreg &= ~(PHY_HALF|PHY_100|PHY_1000);
+        if (np->duplex == 0)
+                phyreg |= PHY_HALF;
+        if ((np->linkspeed & NVREG_LINKSPEED_MASK) == NVREG_LINKSPEED_100)
+                phyreg |= PHY_100;
+        else if ((np->linkspeed & NVREG_LINKSPEED_MASK) ==
+                                                        NVREG_LINKSPEED_1000)
+                phyreg |= PHY_1000;
+        writel(phyreg, base + NvRegPhyInterface);
+
+        if (phyreg & PHY_RGMII) {
+                if ((np->linkspeed & NVREG_LINKSPEED_MASK) ==
+                                                        NVREG_LINKSPEED_1000)
+                        txreg = NVREG_TX_DEFERRAL_RGMII_1000;
+                else
+                        txreg = NVREG_TX_DEFERRAL_RGMII_10_100;
+        } else {
+                txreg = NVREG_TX_DEFERRAL_DEFAULT;
+        }
+        writel(txreg, base + NvRegTxDeferral);
+
+        if (np->desc_ver == DESC_VER_1) {
+                txreg = NVREG_TX_WM_DESC1_DEFAULT;
+        } else {
+                if ((np->linkspeed & NVREG_LINKSPEED_MASK) ==
+                                         NVREG_LINKSPEED_1000)
+                        txreg = NVREG_TX_WM_DESC2_3_1000;
+                else
+                        txreg = NVREG_TX_WM_DESC2_3_DEFAULT;
+        }
+        writel(txreg, base + NvRegTxWatermark);
+
+        writel(NVREG_MISC1_FORCE | (np->duplex ? 0 : NVREG_MISC1_HD),
+                        base + NvRegMisc1);
+        pci_push(base);
+        writel(np->linkspeed, base + NvRegLinkSpeed);
+        pci_push(base);
+
+        return;
+}
+
 /**
  * nv_update_linkspeed: Setup the MAC according to the link partner
  * @dev: Network device to be configured
@@ -3042,11 +3215,25 @@ static int nv_update_linkspeed(struct net_device *dev)
         int newls = np->linkspeed;
         int newdup = np->duplex;
         int mii_status;
+        u32 bmcr;
         int retval = 0;
         u32 control_1000, status_1000, phyreg, pause_flags, txreg;
         u32 txrxFlags = 0;
         u32 phy_exp;
 
+        /* If device loopback is enabled, set carrier on and enable max link
+         * speed.
+         */
+        bmcr = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
+        if (bmcr & BMCR_LOOPBACK) {
+                if (netif_running(dev)) {
+                        nv_force_linkspeed(dev, NVREG_LINKSPEED_1000, 1);
+                        if (!netif_carrier_ok(dev))
+                                netif_carrier_on(dev);
+                }
+                return 1;
+        }
+
         /* BMSR_LSTATUS is latched, read it twice:
          * we want the current value.
          */
@@ -3729,6 +3916,7 @@ static int nv_request_irq(struct net_device *dev, int intr_test)
                                 writel(0, base + NvRegMSIXMap0);
                                 writel(0, base + NvRegMSIXMap1);
                         }
+                        netdev_info(dev, "MSI-X enabled\n");
                 }
         }
         if (ret != 0 && np->msi_flags & NV_MSI_CAPABLE) {
@@ -3750,6 +3938,7 @@ static int nv_request_irq(struct net_device *dev, int intr_test)
                         writel(0, base + NvRegMSIMap1);
                         /* enable msi vector 0 */
                         writel(NVREG_MSI_VECTOR_0_ENABLED, base + NvRegMSIIrqMask);
+                        netdev_info(dev, "MSI enabled\n");
                 }
         }
         if (ret != 0) {
@@ -3904,11 +4093,18 @@ static void nv_poll_controller(struct net_device *dev)
 #endif
 
 static void nv_do_stats_poll(unsigned long data)
+        __acquires(&netdev_priv(dev)->hwstats_lock)
+        __releases(&netdev_priv(dev)->hwstats_lock)
 {
         struct net_device *dev = (struct net_device *) data;
         struct fe_priv *np = netdev_priv(dev);
 
-        nv_get_hw_stats(dev);
+        /* If lock is currently taken, the stats are being refreshed
+         * and hence fresh enough */
+        if (spin_trylock(&np->hwstats_lock)) {
+                nv_update_stats(dev);
+                spin_unlock(&np->hwstats_lock);
+        }
 
         if (!np->in_shutdown)
                 mod_timer(&np->stats_poll,
@@ -3918,9 +4114,9 @@ static void nv_do_stats_poll(unsigned long data)
 static void nv_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct fe_priv *np = netdev_priv(dev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, FORCEDETH_VERSION);
-        strcpy(info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, FORCEDETH_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static void nv_get_wol(struct net_device *dev, struct ethtool_wolinfo *wolinfo)
@@ -4473,7 +4669,63 @@ static int nv_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam*
         return 0;
 }
 
-static u32 nv_fix_features(struct net_device *dev, u32 features)
+static int nv_set_loopback(struct net_device *dev, netdev_features_t features)
+{
+        struct fe_priv *np = netdev_priv(dev);
+        unsigned long flags;
+        u32 miicontrol;
+        int err, retval = 0;
+
+        spin_lock_irqsave(&np->lock, flags);
+        miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
+        if (features & NETIF_F_LOOPBACK) {
+                if (miicontrol & BMCR_LOOPBACK) {
+                        spin_unlock_irqrestore(&np->lock, flags);
+                        netdev_info(dev, "Loopback already enabled\n");
+                        return 0;
+                }
+                nv_disable_irq(dev);
+                /* Turn on loopback mode */
+                miicontrol |= BMCR_LOOPBACK | BMCR_FULLDPLX | BMCR_SPEED1000;
+                err = mii_rw(dev, np->phyaddr, MII_BMCR, miicontrol);
+                if (err) {
+                        retval = PHY_ERROR;
+                        spin_unlock_irqrestore(&np->lock, flags);
+                        phy_init(dev);
+                } else {
+                        if (netif_running(dev)) {
+                                /* Force 1000 Mbps full-duplex */
+                                nv_force_linkspeed(dev, NVREG_LINKSPEED_1000,
+                                                                         1);
+                                /* Force link up */
+                                netif_carrier_on(dev);
+                        }
+                        spin_unlock_irqrestore(&np->lock, flags);
+                        netdev_info(dev,
+                                "Internal PHY loopback mode enabled.\n");
+                }
+        } else {
+                if (!(miicontrol & BMCR_LOOPBACK)) {
+                        spin_unlock_irqrestore(&np->lock, flags);
+                        netdev_info(dev, "Loopback already disabled\n");
+                        return 0;
+                }
+                nv_disable_irq(dev);
+                /* Turn off loopback */
+                spin_unlock_irqrestore(&np->lock, flags);
+                netdev_info(dev, "Internal PHY loopback mode disabled.\n");
+                phy_init(dev);
+        }
+        msleep(500);
+        spin_lock_irqsave(&np->lock, flags);
+        nv_enable_irq(dev);
+        spin_unlock_irqrestore(&np->lock, flags);
+
+        return retval;
+}
+
+static netdev_features_t nv_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         /* vlan is dependent on rx checksum offload */
         if (features & (NETIF_F_HW_VLAN_TX|NETIF_F_HW_VLAN_RX))
@@ -4482,7 +4734,7 @@ static u32 nv_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static void nv_vlan_mode(struct net_device *dev, u32 features)
+static void nv_vlan_mode(struct net_device *dev, netdev_features_t features)
 {
         struct fe_priv *np = get_nvpriv(dev);
 
@@ -4503,11 +4755,18 @@ static void nv_vlan_mode(struct net_device *dev, u32 features)
         spin_unlock_irq(&np->lock);
 }
 
-static int nv_set_features(struct net_device *dev, u32 features)
+static int nv_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct fe_priv *np = netdev_priv(dev);
         u8 __iomem *base = get_hwbase(dev);
-        u32 changed = dev->features ^ features;
+        netdev_features_t changed = dev->features ^ features;
+        int retval;
+
+        if ((changed & NETIF_F_LOOPBACK) && netif_running(dev)) {
+                retval = nv_set_loopback(dev, features);
+                if (retval != 0)
+                        return retval;
+        }
 
         if (changed & NETIF_F_RXCSUM) {
                 spin_lock_irq(&np->lock);
@@ -4553,14 +4812,18 @@ static int nv_get_sset_count(struct net_device *dev, int sset)
         }
 }
 
-static void nv_get_ethtool_stats(struct net_device *dev, struct ethtool_stats *estats, u64 *buffer)
+static void nv_get_ethtool_stats(struct net_device *dev,
+                                 struct ethtool_stats *estats, u64 *buffer)
+        __acquires(&netdev_priv(dev)->hwstats_lock)
+        __releases(&netdev_priv(dev)->hwstats_lock)
 {
         struct fe_priv *np = netdev_priv(dev);
 
-        /* update stats */
-        nv_get_hw_stats(dev);
-
-        memcpy(buffer, &np->estats, nv_get_sset_count(dev, ETH_SS_STATS)*sizeof(u64));
+        spin_lock_bh(&np->hwstats_lock);
+        nv_update_stats(dev);
+        memcpy(buffer, &np->estats,
+               nv_get_sset_count(dev, ETH_SS_STATS)*sizeof(u64));
+        spin_unlock_bh(&np->hwstats_lock);
 }
 
 static int nv_link_test(struct net_device *dev)
@@ -5142,6 +5405,12 @@ static int nv_open(struct net_device *dev)
 
         spin_unlock_irq(&np->lock);
 
+        /* If the loopback feature was set while the device was down, make sure
+         * that it's set correctly now.
+         */
+        if (dev->features & NETIF_F_LOOPBACK)
+                nv_set_loopback(dev, dev->features);
+
         return 0;
 out_drain:
         nv_drain_rxtx(dev);
@@ -5198,7 +5467,7 @@ static int nv_close(struct net_device *dev)
 static const struct net_device_ops nv_netdev_ops = {
         .ndo_open               = nv_open,
         .ndo_stop               = nv_close,
-        .ndo_get_stats          = nv_get_stats,
+        .ndo_get_stats64        = nv_get_stats64,
         .ndo_start_xmit         = nv_start_xmit,
         .ndo_tx_timeout         = nv_tx_timeout,
         .ndo_change_mtu         = nv_change_mtu,
@@ -5215,7 +5484,7 @@ static const struct net_device_ops nv_netdev_ops = {
 static const struct net_device_ops nv_netdev_ops_optimized = {
         .ndo_open               = nv_open,
         .ndo_stop               = nv_close,
-        .ndo_get_stats          = nv_get_stats,
+        .ndo_get_stats64        = nv_get_stats64,
         .ndo_start_xmit         = nv_start_xmit_optimized,
         .ndo_tx_timeout         = nv_tx_timeout,
         .ndo_change_mtu         = nv_change_mtu,
@@ -5254,6 +5523,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
         np->dev = dev;
         np->pci_dev = pci_dev;
         spin_lock_init(&np->lock);
+        spin_lock_init(&np->hwstats_lock);
         SET_NETDEV_DEV(dev, &pci_dev->dev);
 
         init_timer(&np->oom_kick);
@@ -5262,7 +5532,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
         init_timer(&np->nic_poll);
         np->nic_poll.data = (unsigned long) dev;
         np->nic_poll.function = nv_do_nic_poll; /* timer handler */
-        init_timer(&np->stats_poll);
+        init_timer_deferrable(&np->stats_poll);
         np->stats_poll.data = (unsigned long) dev;
         np->stats_poll.function = nv_do_stats_poll;     /* timer handler */
 
@@ -5346,6 +5616,9 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
 
         dev->features |= dev->hw_features;
 
+        /* Add loopback capability to the device. */
+        dev->hw_features |= NETIF_F_LOOPBACK;
+
         np->pause_flags = NV_PAUSEFRAME_RX_CAPABLE | NV_PAUSEFRAME_RX_REQ | NV_PAUSEFRAME_AUTONEG;
         if ((id->driver_data & DEV_HAS_PAUSEFRAME_TX_V1) ||
             (id->driver_data & DEV_HAS_PAUSEFRAME_TX_V2) ||
@@ -5621,12 +5894,14 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
         dev_info(&pci_dev->dev, "ifname %s, PHY OUI 0x%x @ %d, addr %pM\n",
                  dev->name, np->phy_oui, np->phyaddr, dev->dev_addr);
 
-        dev_info(&pci_dev->dev, "%s%s%s%s%s%s%s%s%s%sdesc-v%u\n",
+        dev_info(&pci_dev->dev, "%s%s%s%s%s%s%s%s%s%s%sdesc-v%u\n",
                  dev->features & NETIF_F_HIGHDMA ? "highdma " : "",
                  dev->features & (NETIF_F_IP_CSUM | NETIF_F_SG) ?
                         "csum " : "",
                  dev->features & (NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_TX) ?
                         "vlan " : "",
+                 dev->features & (NETIF_F_LOOPBACK) ?
+                        "loopback " : "",
                  id->driver_data & DEV_HAS_POWER_CNTRL ? "pwrctl " : "",
                  id->driver_data & DEV_HAS_MGMT_UNIT ? "mgmt " : "",
                  id->driver_data & DEV_NEED_TIMERIRQ ? "timirq " : "",
@@ -6000,6 +6275,9 @@ module_param(phy_cross, int, 0);
 MODULE_PARM_DESC(phy_cross, "Phy crossover detection for Realtek 8201 phy is enabled by setting to 1 and disabled by setting to 0.");
 module_param(phy_power_down, int, 0);
 MODULE_PARM_DESC(phy_power_down, "Power down phy and disable link when interface is down (1), or leave phy powered up (0).");
+module_param(debug_tx_timeout, bool, 0);
+MODULE_PARM_DESC(debug_tx_timeout,
+                 "Dump tx related registers and ring when tx_timeout happens");
 
 MODULE_AUTHOR("Manfred Spraul <manfred@colorfullife.com>");
 MODULE_DESCRIPTION("Reverse Engineered nForce ethernet driver");
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
index 8c8027176bef..0063194adb9e 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
@@ -161,10 +161,11 @@ static void pch_gbe_get_drvinfo(struct net_device *netdev,
 {
         struct pch_gbe_adapter *adapter = netdev_priv(netdev);
 
-        strcpy(drvinfo->driver, KBUILD_MODNAME);
-        strcpy(drvinfo->version, pch_driver_version);
-        strcpy(drvinfo->fw_version, "N/A");
-        strcpy(drvinfo->bus_info, pci_name(adapter->pdev));
+        strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, pch_driver_version, sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = pch_gbe_get_regs_len(netdev);
 }
 
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 48406ca382f1..964e9c0948bc 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2109,10 +2109,11 @@ static int pch_gbe_change_mtu(struct net_device *netdev, int new_mtu)
  * Returns
  *      0:              HW state updated successfully
  */
-static int pch_gbe_set_features(struct net_device *netdev, u32 features)
+static int pch_gbe_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct pch_gbe_adapter *adapter = netdev_priv(netdev);
-        u32 changed = features ^ netdev->features;
+        netdev_features_t changed = features ^ netdev->features;
 
         if (!(changed & NETIF_F_RXCSUM))
                 return 0;
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
index e09ea83b8c47..8a371985319f 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
@@ -83,14 +83,18 @@ netxen_nic_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo)
         u32 fw_minor = 0;
         u32 fw_build = 0;
 
-        strncpy(drvinfo->driver, netxen_nic_driver_name, 32);
-        strncpy(drvinfo->version, NETXEN_NIC_LINUX_VERSIONID, 32);
+        strlcpy(drvinfo->driver, netxen_nic_driver_name,
+                sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, NETXEN_NIC_LINUX_VERSIONID,
+                sizeof(drvinfo->version));
         fw_major = NXRD32(adapter, NETXEN_FW_VERSION_MAJOR);
         fw_minor = NXRD32(adapter, NETXEN_FW_VERSION_MINOR);
         fw_build = NXRD32(adapter, NETXEN_FW_VERSION_SUB);
-        sprintf(drvinfo->fw_version, "%d.%d.%d", fw_major, fw_minor, fw_build);
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                "%d.%d.%d", fw_major, fw_minor, fw_build);
 
-        strncpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = NETXEN_NIC_REGS_LEN;
         drvinfo->eedump_len = netxen_nic_get_eeprom_len(dev);
 }
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 8cf3173ba488..7dd9a4b107e6 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -544,7 +544,8 @@ static void netxen_set_multicast_list(struct net_device *dev)
         adapter->set_multi(dev);
 }
 
-static u32 netxen_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t netxen_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         if (!(features & NETIF_F_RXCSUM)) {
                 netdev_info(dev, "disabling LRO as RXCSUM is off\n");
@@ -555,7 +556,8 @@ static u32 netxen_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int netxen_set_features(struct net_device *dev, u32 features)
+static int netxen_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct netxen_adapter *adapter = netdev_priv(dev);
         int hw_lro;
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index a4bdff438a5e..9416f297100e 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -1735,10 +1735,12 @@ static void ql_get_drvinfo(struct net_device *ndev,
                            struct ethtool_drvinfo *drvinfo)
 {
         struct ql3_adapter *qdev = netdev_priv(ndev);
-        strncpy(drvinfo->driver, ql3xxx_driver_name, 32);
-        strncpy(drvinfo->version, ql3xxx_driver_version, 32);
-        strncpy(drvinfo->fw_version, "N/A", 32);
-        strncpy(drvinfo->bus_info, pci_name(qdev->pdev), 32);
+        strlcpy(drvinfo->driver, ql3xxx_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, ql3xxx_driver_version,
+                sizeof(drvinfo->version));
+        strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
+        strlcpy(drvinfo->bus_info, pci_name(qdev->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->regdump_len = 0;
         drvinfo->eedump_len = 0;
 }
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
index 7ed53dbb8646..60976fc4ccc6 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
@@ -1466,8 +1466,9 @@ void qlcnic_advert_link_change(struct qlcnic_adapter *adapter, int linkup);
 
 int qlcnic_fw_cmd_set_mtu(struct qlcnic_adapter *adapter, int mtu);
 int qlcnic_change_mtu(struct net_device *netdev, int new_mtu);
-u32 qlcnic_fix_features(struct net_device *netdev, u32 features);
-int qlcnic_set_features(struct net_device *netdev, u32 features);
+netdev_features_t qlcnic_fix_features(struct net_device *netdev,
+        netdev_features_t features);
+int qlcnic_set_features(struct net_device *netdev, netdev_features_t features);
 int qlcnic_config_hw_lro(struct qlcnic_adapter *adapter, int enable);
 int qlcnic_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable);
 int qlcnic_send_lro_cleanup(struct qlcnic_adapter *adapter);
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
index 8aa1c6e8667b..cc228cf3d84b 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
@@ -140,11 +140,14 @@ qlcnic_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo)
         fw_major = QLCRD32(adapter, QLCNIC_FW_VERSION_MAJOR);
         fw_minor = QLCRD32(adapter, QLCNIC_FW_VERSION_MINOR);
         fw_build = QLCRD32(adapter, QLCNIC_FW_VERSION_SUB);
-        sprintf(drvinfo->fw_version, "%d.%d.%d", fw_major, fw_minor, fw_build);
-
-        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
-        strlcpy(drvinfo->driver, qlcnic_driver_name, 32);
-        strlcpy(drvinfo->version, QLCNIC_LINUX_VERSIONID, 32);
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                "%d.%d.%d", fw_major, fw_minor, fw_build);
+
+        strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
+                sizeof(drvinfo->bus_info));
+        strlcpy(drvinfo->driver, qlcnic_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, QLCNIC_LINUX_VERSIONID,
+                sizeof(drvinfo->version));
 }
 
 static int
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
index bcb81e47543a..b528e52a8ee1 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
@@ -817,12 +817,13 @@ int qlcnic_change_mtu(struct net_device *netdev, int mtu)
 }
 
 
-u32 qlcnic_fix_features(struct net_device *netdev, u32 features)
+netdev_features_t qlcnic_fix_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct qlcnic_adapter *adapter = netdev_priv(netdev);
 
         if ((adapter->flags & QLCNIC_ESWITCH_ENABLED)) {
-                u32 changed = features ^ netdev->features;
+                netdev_features_t changed = features ^ netdev->features;
                 features ^= changed & (NETIF_F_ALL_CSUM | NETIF_F_RXCSUM);
         }
 
@@ -833,10 +834,10 @@ u32 qlcnic_fix_features(struct net_device *netdev, u32 features)
 }
 
 
-int qlcnic_set_features(struct net_device *netdev, u32 features)
+int qlcnic_set_features(struct net_device *netdev, netdev_features_t features)
 {
         struct qlcnic_adapter *adapter = netdev_priv(netdev);
-        u32 changed = netdev->features ^ features;
+        netdev_features_t changed = netdev->features ^ features;
         int hw_lro = (features & NETIF_F_LRO) ? QLCNIC_LRO_ENABLED : 0;
 
         if (!(changed & NETIF_F_LRO))
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 0bd163828e33..823f845ddc04 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -792,7 +792,7 @@ qlcnic_set_netdev_features(struct qlcnic_adapter *adapter,
                 struct qlcnic_esw_func_cfg *esw_cfg)
 {
         struct net_device *netdev = adapter->netdev;
-        unsigned long features, vlan_features;
+        netdev_features_t features, vlan_features;
 
         features = (NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
                         NETIF_F_IPV6_CSUM | NETIF_F_GRO);
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
index 9b67bfea035f..8e2c2a74f3a5 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
@@ -366,13 +366,16 @@ static void ql_get_drvinfo(struct net_device *ndev,
                            struct ethtool_drvinfo *drvinfo)
 {
         struct ql_adapter *qdev = netdev_priv(ndev);
-        strncpy(drvinfo->driver, qlge_driver_name, 32);
-        strncpy(drvinfo->version, qlge_driver_version, 32);
-        snprintf(drvinfo->fw_version, 32, "v%d.%d.%d",
+        strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->version, qlge_driver_version,
+                sizeof(drvinfo->version));
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                 "v%d.%d.%d",
                  (qdev->fw_rev_id & 0x00ff0000) >> 16,
                  (qdev->fw_rev_id & 0x0000ff00) >> 8,
                  (qdev->fw_rev_id & 0x000000ff));
-        strncpy(drvinfo->bus_info, pci_name(qdev->pdev), 32);
+        strlcpy(drvinfo->bus_info, pci_name(qdev->pdev),
+                sizeof(drvinfo->bus_info));
         drvinfo->n_stats = 0;
         drvinfo->testinfo_len = 0;
         if (!test_bit(QL_FRC_COREDUMP, &qdev->flags))
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index c92afcd912e2..1ce4e08037b8 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -2307,7 +2307,7 @@ static int ql_napi_poll_msix(struct napi_struct *napi, int budget)
         return work_done;
 }
 
-static void qlge_vlan_mode(struct net_device *ndev, u32 features)
+static void qlge_vlan_mode(struct net_device *ndev, netdev_features_t features)
 {
         struct ql_adapter *qdev = netdev_priv(ndev);
 
@@ -2323,7 +2323,8 @@ static void qlge_vlan_mode(struct net_device *ndev, u32 features)
         }
 }
 
-static u32 qlge_fix_features(struct net_device *ndev, u32 features)
+static netdev_features_t qlge_fix_features(struct net_device *ndev,
+        netdev_features_t features)
 {
         /*
          * Since there is no support for separate rx/tx vlan accel
@@ -2337,9 +2338,10 @@ static u32 qlge_fix_features(struct net_device *ndev, u32 features)
         return features;
 }
 
-static int qlge_set_features(struct net_device *ndev, u32 features)
+static int qlge_set_features(struct net_device *ndev,
+        netdev_features_t features)
 {
-        u32 changed = ndev->features ^ features;
+        netdev_features_t changed = ndev->features ^ features;
 
         if (changed & NETIF_F_HW_VLAN_RX)
                 qlge_vlan_mode(ndev, features);
diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
index ee5da9293ce0..87cff10f7be7 100644
--- a/drivers/net/ethernet/realtek/8139cp.c
+++ b/drivers/net/ethernet/realtek/8139cp.c
@@ -1319,9 +1319,9 @@ static void cp_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *info
 {
         struct cp_private *cp = netdev_priv(dev);
 
-        strcpy (info->driver, DRV_NAME);
-        strcpy (info->version, DRV_VERSION);
-        strcpy (info->bus_info, pci_name(cp->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(cp->pdev), sizeof(info->bus_info));
 }
 
 static void cp_get_ringparam(struct net_device *dev,
@@ -1392,7 +1392,7 @@ static void cp_set_msglevel(struct net_device *dev, u32 value)
         cp->msg_enable = value;
 }
 
-static int cp_set_features(struct net_device *dev, u32 features)
+static int cp_set_features(struct net_device *dev, netdev_features_t features)
 {
         struct cp_private *cp = netdev_priv(dev);
         unsigned long flags;
diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c
index 4d6b254fc6c1..d9c72273e428 100644
--- a/drivers/net/ethernet/realtek/8139too.c
+++ b/drivers/net/ethernet/realtek/8139too.c
@@ -2330,9 +2330,9 @@ static int rtl8139_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 static void rtl8139_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct rtl8139_private *tp = netdev_priv(dev);
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(tp->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info));
         info->regdump_len = tp->regs_len;
 }
 
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 6f06aa10f0d7..f7bc310f5185 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -69,9 +69,6 @@
    The RTL chips use a 64 element hash table based on the Ethernet CRC. */
 static const int multicast_filter_limit = 32;
 
-/* MAC address length */
-#define MAC_ADDR_LEN    6
-
 #define MAX_READ_REQUEST_SHIFT  12
 #define TX_DMA_BURST    6       /* Maximum PCI burst, '6' is 1024 */
 #define SafeMtu         0x1c20  /* ... actually life sucks beyond ~7k */
@@ -1404,12 +1401,12 @@ static void rtl8169_get_drvinfo(struct net_device *dev,
         struct rtl8169_private *tp = netdev_priv(dev);
         struct rtl_fw *rtl_fw = tp->rtl_fw;
 
-        strcpy(info->driver, MODULENAME);
-        strcpy(info->version, RTL8169_VERSION);
-        strcpy(info->bus_info, pci_name(tp->pci_dev));
+        strlcpy(info->driver, MODULENAME, sizeof(info->driver));
+        strlcpy(info->version, RTL8169_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info));
         BUILD_BUG_ON(sizeof(info->fw_version) < sizeof(rtl_fw->version));
-        strcpy(info->fw_version, IS_ERR_OR_NULL(rtl_fw) ? "N/A" :
-               rtl_fw->version);
+        strlcpy(info->fw_version, IS_ERR_OR_NULL(rtl_fw) ? "N/A" :
+               rtl_fw->version, sizeof(info->fw_version));
 }
 
 static int rtl8169_get_regs_len(struct net_device *dev)
@@ -1553,7 +1550,8 @@ static int rtl8169_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         return ret;
 }
 
-static u32 rtl8169_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t rtl8169_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct rtl8169_private *tp = netdev_priv(dev);
 
@@ -1567,7 +1565,8 @@ static u32 rtl8169_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int rtl8169_set_features(struct net_device *dev, u32 features)
+static int rtl8169_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct rtl8169_private *tp = netdev_priv(dev);
         void __iomem *ioaddr = tp->mmio_addr;
@@ -4099,7 +4098,7 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
         spin_lock_init(&tp->lock);
 
         /* Get MAC address */
-        for (i = 0; i < MAC_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 dev->dev_addr[i] = RTL_R8(MAC0 + i);
         memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
 
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index d5731f1fe6d6..14e134d3b4d7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -1900,7 +1900,7 @@ static void efx_set_multicast_list(struct net_device *net_dev)
         /* Otherwise efx_start_port() will do this */
 }
 
-static int efx_set_features(struct net_device *net_dev, u32 data)
+static int efx_set_features(struct net_device *net_dev, netdev_features_t data)
 {
         struct efx_nic *efx = netdev_priv(net_dev);
 
diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h
index b8e251a1ee48..c49502bab6a3 100644
--- a/drivers/net/ethernet/sfc/net_driver.h
+++ b/drivers/net/ethernet/sfc/net_driver.h
@@ -908,7 +908,7 @@ struct efx_nic_type {
         unsigned int phys_addr_channels;
         unsigned int tx_dc_base;
         unsigned int rx_dc_base;
-        u32 offload_features;
+        netdev_features_t offload_features;
 };
 
 /**************************************************************************
diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c
index 1b4658c99391..5b118cd5bf94 100644
--- a/drivers/net/ethernet/sis/sis190.c
+++ b/drivers/net/ethernet/sis/sis190.c
@@ -47,8 +47,6 @@
 #define sis190_rx_skb                   netif_rx
 #define sis190_rx_quota(count, quota)   count
 
-#define MAC_ADDR_LEN            6
-
 #define NUM_TX_DESC             64      /* [8..1024] */
 #define NUM_RX_DESC             64      /* [8..8192] */
 #define TX_RING_BYTES           (NUM_TX_DESC * sizeof(struct TxDesc))
@@ -1601,7 +1599,7 @@ static int __devinit sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev,
         }
 
         /* Get MAC address from EEPROM */
-        for (i = 0; i < MAC_ADDR_LEN / 2; i++) {
+        for (i = 0; i < ETH_ALEN / 2; i++) {
                 u16 w = sis190_read_eeprom(ioaddr, EEPROMMACAddr + i);
 
                 ((__le16 *)dev->dev_addr)[i] = cpu_to_le16(w);
@@ -1653,7 +1651,7 @@ static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
         udelay(50);
         pci_read_config_byte(isa_bridge, 0x48, &reg);
 
-        for (i = 0; i < MAC_ADDR_LEN; i++) {
+        for (i = 0; i < ETH_ALEN; i++) {
                 outb(0x9 + i, 0x78);
                 dev->dev_addr[i] = inb(0x79);
         }
@@ -1692,7 +1690,7 @@ static inline void sis190_init_rxfilter(struct net_device *dev)
          */
         SIS_W16(RxMacControl, ctl & ~0x0f00);
 
-        for (i = 0; i < MAC_ADDR_LEN; i++)
+        for (i = 0; i < ETH_ALEN; i++)
                 SIS_W8(RxMacAddr + i, dev->dev_addr[i]);
 
         SIS_W16(RxMacControl, ctl);
@@ -1760,9 +1758,10 @@ static void sis190_get_drvinfo(struct net_device *dev,
 {
         struct sis190_private *tp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(tp->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(tp->pci_dev),
+                sizeof(info->bus_info));
 }
 
 static int sis190_get_regs_len(struct net_device *dev)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index a184abc5ef11..c8efc708c792 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -1991,9 +1991,10 @@ static void sis900_get_drvinfo(struct net_device *net_dev,
 {
         struct sis900_private *sis_priv = netdev_priv(net_dev);
 
-        strcpy (info->driver, SIS900_MODULE_NAME);
-        strcpy (info->version, SIS900_DRV_VERSION);
-        strcpy (info->bus_info, pci_name(sis_priv->pci_dev));
+        strlcpy(info->driver, SIS900_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, SIS900_DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(sis_priv->pci_dev),
+                sizeof(info->bus_info));
 }
 
 static u32 sis900_get_msglevel(struct net_device *net_dev)
diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c
index 0a5dfb814157..2c077ce0b6d6 100644
--- a/drivers/net/ethernet/smsc/epic100.c
+++ b/drivers/net/ethernet/smsc/epic100.c
@@ -1414,9 +1414,9 @@ static void netdev_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *
 {
         struct epic_private *np = netdev_priv(dev);
 
-        strcpy (info->driver, DRV_NAME);
-        strcpy (info->version, DRV_VERSION);
-        strcpy (info->bus_info, pci_name(np->pci_dev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info));
 }
 
 static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/smsc/smc91c92_cs.c b/drivers/net/ethernet/smsc/smc91c92_cs.c
index cbfa98187131..ada927aba7a5 100644
--- a/drivers/net/ethernet/smsc/smc91c92_cs.c
+++ b/drivers/net/ethernet/smsc/smc91c92_cs.c
@@ -1909,8 +1909,8 @@ static int check_if_running(struct net_device *dev)
 
 static void smc_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
 }
 
 static int smc_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
diff --git a/drivers/net/ethernet/smsc/smsc9420.c b/drivers/net/ethernet/smsc/smsc9420.c
index edb24b0e337b..a9efbdfe5302 100644
--- a/drivers/net/ethernet/smsc/smsc9420.c
+++ b/drivers/net/ethernet/smsc/smsc9420.c
@@ -279,9 +279,10 @@ static void smsc9420_ethtool_get_drvinfo(struct net_device *netdev,
 {
         struct smsc9420_pdata *pd = netdev_priv(netdev);
 
-        strcpy(drvinfo->driver, DRV_NAME);
-        strcpy(drvinfo->bus_info, pci_name(pd->pdev));
-        strcpy(drvinfo->version, DRV_VERSION);
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->bus_info, pci_name(pd->pdev),
+                sizeof(drvinfo->bus_info));
+        strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
 }
 
 static u32 smsc9420_ethtool_get_msglevel(struct net_device *netdev)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index 0395f9eba801..ed83c4c47b8a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -185,9 +185,10 @@ static void stmmac_ethtool_getdrvinfo(struct net_device *dev,
         struct stmmac_priv *priv = netdev_priv(dev);
 
         if (priv->plat->has_gmac)
-                strcpy(info->driver, GMAC_ETHTOOL_NAME);
+                strlcpy(info->driver, GMAC_ETHTOOL_NAME, sizeof(info->driver));
         else
-                strcpy(info->driver, MAC100_ETHTOOL_NAME);
+                strlcpy(info->driver, MAC100_ETHTOOL_NAME,
+                        sizeof(info->driver));
 
         strcpy(info->version, DRV_MODULE_VERSION);
         info->fw_version[0] = '\0';
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 8ea770a89f25..de71859bb295 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1466,7 +1466,8 @@ static int stmmac_change_mtu(struct net_device *dev, int new_mtu)
         return 0;
 }
 
-static u32 stmmac_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t stmmac_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct stmmac_priv *priv = netdev_priv(dev);
 
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index fd40988c19a6..f10665f594c4 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -4532,10 +4532,9 @@ static void cas_set_multicast(struct net_device *dev)
 static void cas_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct cas *cp = netdev_priv(dev);
-        strncpy(info->driver, DRV_MODULE_NAME, ETHTOOL_BUSINFO_LEN);
-        strncpy(info->version, DRV_MODULE_VERSION, ETHTOOL_BUSINFO_LEN);
-        info->fw_version[0] = '\0';
-        strncpy(info->bus_info, pci_name(cp->pdev), ETHTOOL_BUSINFO_LEN);
+        strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(cp->pdev), sizeof(info->bus_info));
         info->regdump_len = cp->casreg_len < CAS_MAX_REGS ?
                 cp->casreg_len : CAS_MAX_REGS;
         info->n_stats = CAS_NUM_STAT_KEYS;
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
index 73c708107a37..9997be525089 100644
--- a/drivers/net/ethernet/sun/niu.c
+++ b/drivers/net/ethernet/sun/niu.c
@@ -1151,19 +1151,8 @@ static int link_status_mii(struct niu *np, int *link_up_p)
                 supported |= SUPPORTED_1000baseT_Full;
         lp->supported = supported;
 
-        advertising = 0;
-        if (advert & ADVERTISE_10HALF)
-                advertising |= ADVERTISED_10baseT_Half;
-        if (advert & ADVERTISE_10FULL)
-                advertising |= ADVERTISED_10baseT_Full;
-        if (advert & ADVERTISE_100HALF)
-                advertising |= ADVERTISED_100baseT_Half;
-        if (advert & ADVERTISE_100FULL)
-                advertising |= ADVERTISED_100baseT_Full;
-        if (ctrl1000 & ADVERTISE_1000HALF)
-                advertising |= ADVERTISED_1000baseT_Half;
-        if (ctrl1000 & ADVERTISE_1000FULL)
-                advertising |= ADVERTISED_1000baseT_Full;
+        advertising = mii_adv_to_ethtool_100bt(advert);
+        advertising |= mii_adv_to_ethtool_1000T(ctrl1000);
 
         if (bmcr & BMCR_ANENABLE) {
                 int neg, neg1000;
@@ -6823,12 +6812,13 @@ static void niu_get_drvinfo(struct net_device *dev,
         struct niu *np = netdev_priv(dev);
         struct niu_vpd *vpd = &np->vpd;
 
-        strcpy(info->driver, DRV_MODULE_NAME);
-        strcpy(info->version, DRV_MODULE_VERSION);
-        sprintf(info->fw_version, "%d.%d",
+        strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
+        snprintf(info->fw_version, sizeof(info->fw_version), "%d.%d",
                 vpd->fcode_major, vpd->fcode_minor);
         if (np->parent->plat_type != PLAT_TYPE_NIU)
-                strcpy(info->bus_info, pci_name(np->pdev));
+                strlcpy(info->bus_info, pci_name(np->pdev),
+                        sizeof(info->bus_info));
 }
 
 static int niu_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index ceab215bb4a3..31441a870b0b 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -2517,9 +2517,9 @@ static void gem_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
 {
         struct gem *gp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(gp->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(gp->pdev), sizeof(info->bus_info));
 }
 
 static int gem_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index cf14ab9db576..eebd52f10365 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -2457,11 +2457,11 @@ static void hme_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
 {
         struct happy_meal *hp = netdev_priv(dev);
 
-        strcpy(info->driver, "sunhme");
-        strcpy(info->version, "2.02");
+        strlcpy(info->driver, "sunhme", sizeof(info->driver));
+        strlcpy(info->version, "2.02", sizeof(info->version));
         if (hp->happy_flags & HFLAG_PCI) {
                 struct pci_dev *pdev = hp->happy_dev;
-                strcpy(info->bus_info, pci_name(pdev));
+                strlcpy(info->bus_info, pci_name(pdev), sizeof(info->bus_info));
         }
 #ifdef CONFIG_SBUS
         else {
@@ -2469,7 +2469,8 @@ static void hme_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
                 struct platform_device *op = hp->happy_dev;
                 regs = of_get_property(op->dev.of_node, "regs", NULL);
                 if (regs)
-                        sprintf(info->bus_info, "SBUS:%d",
+                        snprintf(info->bus_info, sizeof(info->bus_info),
+                                "SBUS:%d",
                                 regs->which_io);
         }
 #endif
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index f34dd99fe579..5587ecdf32e3 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -2009,9 +2009,9 @@ static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *i
 {
         struct rhine_private *rp = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->bus_info, pci_name(rp->pdev));
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(rp->pdev), sizeof(info->bus_info));
 }
 
 static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index 4535d7cc848e..59bb5fd56afe 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -3270,9 +3270,9 @@ static int velocity_set_settings(struct net_device *dev,
 static void velocity_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
         struct velocity_info *vptr = netdev_priv(dev);
-        strcpy(info->driver, VELOCITY_NAME);
-        strcpy(info->version, VELOCITY_VERSION);
-        strcpy(info->bus_info, pci_name(vptr->pdev));
+        strlcpy(info->driver, VELOCITY_NAME, sizeof(info->driver));
+        strlcpy(info->version, VELOCITY_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, pci_name(vptr->pdev), sizeof(info->bus_info));
 }
 
 static void velocity_ethtool_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 2681b53820ee..1ade9e18d299 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -920,12 +920,26 @@ temac_poll_controller(struct net_device *ndev)
 }
 #endif
 
+static int temac_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd)
+{
+        struct temac_local *lp = netdev_priv(ndev);
+
+        if (!netif_running(ndev))
+                return -EINVAL;
+
+        if (!lp->phy_dev)
+                return -EINVAL;
+
+        return phy_mii_ioctl(lp->phy_dev, rq, cmd);
+}
+
 static const struct net_device_ops temac_netdev_ops = {
         .ndo_open = temac_open,
         .ndo_stop = temac_stop,
         .ndo_start_xmit = temac_start_xmit,
         .ndo_set_mac_address = netdev_set_mac_address,
         .ndo_validate_addr = eth_validate_addr,
+        .ndo_do_ioctl = temac_ioctl,
 #ifdef CONFIG_NET_POLL_CONTROLLER
         .ndo_poll_controller = temac_poll_controller,
 #endif
diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c
index bbe8b7dbf3f3..33979c3ac943 100644
--- a/drivers/net/ethernet/xircom/xirc2ps_cs.c
+++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c
@@ -1411,7 +1411,7 @@ do_open(struct net_device *dev)
 static void netdev_get_drvinfo(struct net_device *dev,
                                struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, "xirc2ps_cs");
+        strlcpy(info->driver, "xirc2ps_cs", sizeof(info->driver));
         sprintf(info->bus_info, "PCMCIA 0x%lx", dev->base_addr);
 }
 
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 46b5f5fd686b..e05b645bbc32 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -164,7 +164,7 @@ static const struct net_device_ops ifb_netdev_ops = {
         .ndo_validate_addr = eth_validate_addr,
 };
 
-#define IFB_FEATURES (NETIF_F_NO_CSUM | NETIF_F_SG  | NETIF_F_FRAGLIST  | \
+#define IFB_FEATURES (NETIF_F_HW_CSUM | NETIF_F_SG  | NETIF_F_FRAGLIST  | \
                       NETIF_F_TSO_ECN | NETIF_F_TSO | NETIF_F_TSO6      | \
                       NETIF_F_HIGHDMA | NETIF_F_HW_VLAN_TX)
 
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 4ce9e5f2c069..b71998d0b5b4 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -169,7 +169,7 @@ static void loopback_setup(struct net_device *dev)
         dev->features           = NETIF_F_SG | NETIF_F_FRAGLIST
                 | NETIF_F_ALL_TSO
                 | NETIF_F_UFO
-                | NETIF_F_NO_CSUM
+                | NETIF_F_HW_CSUM
                 | NETIF_F_RXCSUM
                 | NETIF_F_HIGHDMA
                 | NETIF_F_LLTX
diff --git a/drivers/net/mii.c b/drivers/net/mii.c
index c62e7816d548..d0a296272713 100644
--- a/drivers/net/mii.c
+++ b/drivers/net/mii.c
@@ -41,20 +41,8 @@ static u32 mii_get_an(struct mii_if_info *mii, u16 addr)
         advert = mii->mdio_read(mii->dev, mii->phy_id, addr);
         if (advert & LPA_LPACK)
                 result |= ADVERTISED_Autoneg;
-        if (advert & ADVERTISE_10HALF)
-                result |= ADVERTISED_10baseT_Half;
-        if (advert & ADVERTISE_10FULL)
-                result |= ADVERTISED_10baseT_Full;
-        if (advert & ADVERTISE_100HALF)
-                result |= ADVERTISED_100baseT_Half;
-        if (advert & ADVERTISE_100FULL)
-                result |= ADVERTISED_100baseT_Full;
-        if (advert & ADVERTISE_PAUSE_CAP)
-                result |= ADVERTISED_Pause;
-        if (advert & ADVERTISE_PAUSE_ASYM)
-                result |= ADVERTISED_Asym_Pause;
-
-        return result;
+
+        return result | mii_adv_to_ethtool_100bt(advert);
 }
 
 /**
@@ -104,19 +92,13 @@ int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
                 ecmd->autoneg = AUTONEG_ENABLE;
 
                 ecmd->advertising |= mii_get_an(mii, MII_ADVERTISE);
-                if (ctrl1000 & ADVERTISE_1000HALF)
-                        ecmd->advertising |= ADVERTISED_1000baseT_Half;
-                if (ctrl1000 & ADVERTISE_1000FULL)
-                        ecmd->advertising |= ADVERTISED_1000baseT_Full;
+                if (mii->supports_gmii)
+                        ecmd->advertising |= mii_adv_to_ethtool_1000T(ctrl1000);
 
                 if (bmsr & BMSR_ANEGCOMPLETE) {
                         ecmd->lp_advertising = mii_get_an(mii, MII_LPA);
-                        if (stat1000 & LPA_1000HALF)
-                                ecmd->lp_advertising |=
-                                        ADVERTISED_1000baseT_Half;
-                        if (stat1000 & LPA_1000FULL)
-                                ecmd->lp_advertising |=
-                                        ADVERTISED_1000baseT_Full;
+                        ecmd->lp_advertising |=
+                                             mii_lpa_to_ethtool_1000T(stat1000);
                 } else {
                         ecmd->lp_advertising = 0;
                 }
@@ -204,20 +186,10 @@ int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
                         advert2 = mii->mdio_read(dev, mii->phy_id, MII_CTRL1000);
                         tmp2 = advert2 & ~(ADVERTISE_1000HALF | ADVERTISE_1000FULL);
                 }
-                if (ecmd->advertising & ADVERTISED_10baseT_Half)
-                        tmp |= ADVERTISE_10HALF;
-                if (ecmd->advertising & ADVERTISED_10baseT_Full)
-                        tmp |= ADVERTISE_10FULL;
-                if (ecmd->advertising & ADVERTISED_100baseT_Half)
-                        tmp |= ADVERTISE_100HALF;
-                if (ecmd->advertising & ADVERTISED_100baseT_Full)
-                        tmp |= ADVERTISE_100FULL;
-                if (mii->supports_gmii) {
-                        if (ecmd->advertising & ADVERTISED_1000baseT_Half)
-                                tmp2 |= ADVERTISE_1000HALF;
-                        if (ecmd->advertising & ADVERTISED_1000baseT_Full)
-                                tmp2 |= ADVERTISE_1000FULL;
-                }
+                tmp |= ethtool_adv_to_mii_100bt(ecmd->advertising);
+
+                if (mii->supports_gmii)
+                        tmp2 |= ethtool_adv_to_mii_1000T(ecmd->advertising);
                 if (advert != tmp) {
                         mii->mdio_write(dev, mii->phy_id, MII_ADVERTISE, tmp);
                         mii->advertising = tmp;
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
index 65391891d8c4..daec9b05d168 100644
--- a/drivers/net/phy/mdio-bitbang.c
+++ b/drivers/net/phy/mdio-bitbang.c
@@ -202,6 +202,14 @@ static int mdiobb_write(struct mii_bus *bus, int phy, int reg, u16 val)
         return 0;
 }
 
+static int mdiobb_reset(struct mii_bus *bus)
+{
+        struct mdiobb_ctrl *ctrl = bus->priv;
+        if (ctrl->reset)
+                ctrl->reset(bus);
+        return 0;
+}
+
 struct mii_bus *alloc_mdio_bitbang(struct mdiobb_ctrl *ctrl)
 {
         struct mii_bus *bus;
@@ -214,6 +222,7 @@ struct mii_bus *alloc_mdio_bitbang(struct mdiobb_ctrl *ctrl)
 
         bus->read = mdiobb_read;
         bus->write = mdiobb_write;
+        bus->reset = mdiobb_reset;
         bus->priv = ctrl;
 
         return bus;
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 2843c90f712f..89c5a3eccc12 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -95,6 +95,7 @@ static struct mii_bus * __devinit mdio_gpio_bus_init(struct device *dev,
                 goto out;
 
         bitbang->ctrl.ops = &mdio_gpio_ops;
+        bitbang->ctrl.reset = pdata->reset;
         bitbang->mdc = pdata->mdc;
         bitbang->mdio = pdata->mdio;
 
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 83a5a5afec67..edb905f80115 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -563,20 +563,9 @@ static int genphy_config_advert(struct phy_device *phydev)
         if (adv < 0)
                 return adv;
 
-        adv &= ~(ADVERTISE_ALL | ADVERTISE_100BASE4 | ADVERTISE_PAUSE_CAP | 
+        adv &= ~(ADVERTISE_ALL | ADVERTISE_100BASE4 | ADVERTISE_PAUSE_CAP |
                  ADVERTISE_PAUSE_ASYM);
-        if (advertise & ADVERTISED_10baseT_Half)
-                adv |= ADVERTISE_10HALF;
-        if (advertise & ADVERTISED_10baseT_Full)
-                adv |= ADVERTISE_10FULL;
-        if (advertise & ADVERTISED_100baseT_Half)
-                adv |= ADVERTISE_100HALF;
-        if (advertise & ADVERTISED_100baseT_Full)
-                adv |= ADVERTISE_100FULL;
-        if (advertise & ADVERTISED_Pause)
-                adv |= ADVERTISE_PAUSE_CAP;
-        if (advertise & ADVERTISED_Asym_Pause)
-                adv |= ADVERTISE_PAUSE_ASYM;
+        adv |= ethtool_adv_to_mii_100bt(advertise);
 
         if (adv != oldadv) {
                 err = phy_write(phydev, MII_ADVERTISE, adv);
@@ -595,10 +584,7 @@ static int genphy_config_advert(struct phy_device *phydev)
                         return adv;
 
                 adv &= ~(ADVERTISE_1000FULL | ADVERTISE_1000HALF);
-                if (advertise & SUPPORTED_1000baseT_Half)
-                        adv |= ADVERTISE_1000HALF;
-                if (advertise & SUPPORTED_1000baseT_Full)
-                        adv |= ADVERTISE_1000FULL;
+                adv |= ethtool_adv_to_mii_1000T(advertise);
 
                 if (adv != oldadv) {
                         err = phy_write(phydev, MII_CTRL1000, adv);
diff --git a/drivers/net/team/Kconfig b/drivers/net/team/Kconfig
new file mode 100644
index 000000000000..248a144033ca
--- /dev/null
+++ b/drivers/net/team/Kconfig
@@ -0,0 +1,43 @@
+menuconfig NET_TEAM
+        tristate "Ethernet team driver support (EXPERIMENTAL)"
+        depends on EXPERIMENTAL
+        ---help---
+          This allows one to create virtual interfaces that teams together
+          multiple ethernet devices.
+
+          Team devices can be added using the "ip" command from the
+          iproute2 package:
+
+          "ip link add link [ address MAC ] [ NAME ] type team"
+
+          To compile this driver as a module, choose M here: the module
+          will be called team.
+
+if NET_TEAM
+
+config NET_TEAM_MODE_ROUNDROBIN
+        tristate "Round-robin mode support"
+        depends on NET_TEAM
+        ---help---
+          Basic mode where port used for transmitting packets is selected in
+          round-robin fashion using packet counter.
+
+          All added ports are setup to have bond's mac address.
+
+          To compile this team mode as a module, choose M here: the module
+          will be called team_mode_roundrobin.
+
+config NET_TEAM_MODE_ACTIVEBACKUP
+        tristate "Active-backup mode support"
+        depends on NET_TEAM
+        ---help---
+          Only one port is active at a time and the rest of ports are used
+          for backup.
+
+          Mac addresses of ports are not modified. Userspace is responsible
+          to do so.
+
+          To compile this team mode as a module, choose M here: the module
+          will be called team_mode_activebackup.
+
+endif # NET_TEAM
diff --git a/drivers/net/team/Makefile b/drivers/net/team/Makefile
new file mode 100644
index 000000000000..85f2028a87af
--- /dev/null
+++ b/drivers/net/team/Makefile
@@ -0,0 +1,7 @@
+#
+# Makefile for the network team driver
+#
+
+obj-$(CONFIG_NET_TEAM) += team.o
+obj-$(CONFIG_NET_TEAM_MODE_ROUNDROBIN) += team_mode_roundrobin.o
+obj-$(CONFIG_NET_TEAM_MODE_ACTIVEBACKUP) += team_mode_activebackup.o
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
new file mode 100644
index 000000000000..064155d56bce
--- /dev/null
+++ b/drivers/net/team/team.c
@@ -0,0 +1,1661 @@
+/*
+ * net/drivers/team/team.c - Network team device driver
+ * Copyright (c) 2011 Jiri Pirko <jpirko@redhat.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/rcupdate.h>
+#include <linux/errno.h>
+#include <linux/ctype.h>
+#include <linux/notifier.h>
+#include <linux/netdevice.h>
+#include <linux/if_arp.h>
+#include <linux/socket.h>
+#include <linux/etherdevice.h>
+#include <linux/rtnetlink.h>
+#include <net/rtnetlink.h>
+#include <net/genetlink.h>
+#include <net/netlink.h>
+#include <linux/if_team.h>
+
+#define DRV_NAME "team"
+
+
+/**********
+ * Helpers
+ **********/
+
+#define team_port_exists(dev) (dev->priv_flags & IFF_TEAM_PORT)
+
+static struct team_port *team_port_get_rcu(const struct net_device *dev)
+{
+        struct team_port *port = rcu_dereference(dev->rx_handler_data);
+
+        return team_port_exists(dev) ? port : NULL;
+}
+
+static struct team_port *team_port_get_rtnl(const struct net_device *dev)
+{
+        struct team_port *port = rtnl_dereference(dev->rx_handler_data);
+
+        return team_port_exists(dev) ? port : NULL;
+}
+
+/*
+ * Since the ability to change mac address for open port device is tested in
+ * team_port_add, this function can be called without control of return value
+ */
+static int __set_port_mac(struct net_device *port_dev,
+                          const unsigned char *dev_addr)
+{
+        struct sockaddr addr;
+
+        memcpy(addr.sa_data, dev_addr, ETH_ALEN);
+        addr.sa_family = ARPHRD_ETHER;
+        return dev_set_mac_address(port_dev, &addr);
+}
+
+int team_port_set_orig_mac(struct team_port *port)
+{
+        return __set_port_mac(port->dev, port->orig.dev_addr);
+}
+
+int team_port_set_team_mac(struct team_port *port)
+{
+        return __set_port_mac(port->dev, port->team->dev->dev_addr);
+}
+EXPORT_SYMBOL(team_port_set_team_mac);
+
+
+/*******************
+ * Options handling
+ *******************/
+
+struct team_option *__team_find_option(struct team *team, const char *opt_name)
+{
+        struct team_option *option;
+
+        list_for_each_entry(option, &team->option_list, list) {
+                if (strcmp(option->name, opt_name) == 0)
+                        return option;
+        }
+        return NULL;
+}
+
+int team_options_register(struct team *team,
+                          const struct team_option *option,
+                          size_t option_count)
+{
+        int i;
+        struct team_option **dst_opts;
+        int err;
+
+        dst_opts = kzalloc(sizeof(struct team_option *) * option_count,
+                           GFP_KERNEL);
+        if (!dst_opts)
+                return -ENOMEM;
+        for (i = 0; i < option_count; i++, option++) {
+                if (__team_find_option(team, option->name)) {
+                        err = -EEXIST;
+                        goto rollback;
+                }
+                dst_opts[i] = kmemdup(option, sizeof(*option), GFP_KERNEL);
+                if (!dst_opts[i]) {
+                        err = -ENOMEM;
+                        goto rollback;
+                }
+        }
+
+        for (i = 0; i < option_count; i++)
+                list_add_tail(&dst_opts[i]->list, &team->option_list);
+
+        kfree(dst_opts);
+        return 0;
+
+rollback:
+        for (i = 0; i < option_count; i++)
+                kfree(dst_opts[i]);
+
+        kfree(dst_opts);
+        return err;
+}
+
+EXPORT_SYMBOL(team_options_register);
+
+static void __team_options_change_check(struct team *team,
+                                        struct team_option *changed_option);
+
+static void __team_options_unregister(struct team *team,
+                                      const struct team_option *option,
+                                      size_t option_count)
+{
+        int i;
+
+        for (i = 0; i < option_count; i++, option++) {
+                struct team_option *del_opt;
+
+                del_opt = __team_find_option(team, option->name);
+                if (del_opt) {
+                        list_del(&del_opt->list);
+                        kfree(del_opt);
+                }
+        }
+}
+
+void team_options_unregister(struct team *team,
+                             const struct team_option *option,
+                             size_t option_count)
+{
+        __team_options_unregister(team, option, option_count);
+        __team_options_change_check(team, NULL);
+}
+EXPORT_SYMBOL(team_options_unregister);
+
+static int team_option_get(struct team *team, struct team_option *option,
+                           void *arg)
+{
+        return option->getter(team, arg);
+}
+
+static int team_option_set(struct team *team, struct team_option *option,
+                           void *arg)
+{
+        int err;
+
+        err = option->setter(team, arg);
+        if (err)
+                return err;
+
+        __team_options_change_check(team, option);
+        return err;
+}
+
+/****************
+ * Mode handling
+ ****************/
+
+static LIST_HEAD(mode_list);
+static DEFINE_SPINLOCK(mode_list_lock);
+
+static struct team_mode *__find_mode(const char *kind)
+{
+        struct team_mode *mode;
+
+        list_for_each_entry(mode, &mode_list, list) {
+                if (strcmp(mode->kind, kind) == 0)
+                        return mode;
+        }
+        return NULL;
+}
+
+static bool is_good_mode_name(const char *name)
+{
+        while (*name != '\0') {
+                if (!isalpha(*name) && !isdigit(*name) && *name != '_')
+                        return false;
+                name++;
+        }
+        return true;
+}
+
+int team_mode_register(struct team_mode *mode)
+{
+        int err = 0;
+
+        if (!is_good_mode_name(mode->kind) ||
+            mode->priv_size > TEAM_MODE_PRIV_SIZE)
+                return -EINVAL;
+        spin_lock(&mode_list_lock);
+        if (__find_mode(mode->kind)) {
+                err = -EEXIST;
+                goto unlock;
+        }
+        list_add_tail(&mode->list, &mode_list);
+unlock:
+        spin_unlock(&mode_list_lock);
+        return err;
+}
+EXPORT_SYMBOL(team_mode_register);
+
+int team_mode_unregister(struct team_mode *mode)
+{
+        spin_lock(&mode_list_lock);
+        list_del_init(&mode->list);
+        spin_unlock(&mode_list_lock);
+        return 0;
+}
+EXPORT_SYMBOL(team_mode_unregister);
+
+static struct team_mode *team_mode_get(const char *kind)
+{
+        struct team_mode *mode;
+
+        spin_lock(&mode_list_lock);
+        mode = __find_mode(kind);
+        if (!mode) {
+                spin_unlock(&mode_list_lock);
+                request_module("team-mode-%s", kind);
+                spin_lock(&mode_list_lock);
+                mode = __find_mode(kind);
+        }
+        if (mode)
+                if (!try_module_get(mode->owner))
+                        mode = NULL;
+
+        spin_unlock(&mode_list_lock);
+        return mode;
+}
+
+static void team_mode_put(const struct team_mode *mode)
+{
+        module_put(mode->owner);
+}
+
+static bool team_dummy_transmit(struct team *team, struct sk_buff *skb)
+{
+        dev_kfree_skb_any(skb);
+        return false;
+}
+
+rx_handler_result_t team_dummy_receive(struct team *team,
+                                       struct team_port *port,
+                                       struct sk_buff *skb)
+{
+        return RX_HANDLER_ANOTHER;
+}
+
+static void team_adjust_ops(struct team *team)
+{
+        /*
+         * To avoid checks in rx/tx skb paths, ensure here that non-null and
+         * correct ops are always set.
+         */
+
+        if (list_empty(&team->port_list) ||
+            !team->mode || !team->mode->ops->transmit)
+                team->ops.transmit = team_dummy_transmit;
+        else
+                team->ops.transmit = team->mode->ops->transmit;
+
+        if (list_empty(&team->port_list) ||
+            !team->mode || !team->mode->ops->receive)
+                team->ops.receive = team_dummy_receive;
+        else
+                team->ops.receive = team->mode->ops->receive;
+}
+
+/*
+ * We can benefit from the fact that it's ensured no port is present
+ * at the time of mode change. Therefore no packets are in fly so there's no
+ * need to set mode operations in any special way.
+ */
+static int __team_change_mode(struct team *team,
+                              const struct team_mode *new_mode)
+{
+        /* Check if mode was previously set and do cleanup if so */
+        if (team->mode) {
+                void (*exit_op)(struct team *team) = team->ops.exit;
+
+                /* Clear ops area so no callback is called any longer */
+                memset(&team->ops, 0, sizeof(struct team_mode_ops));
+                team_adjust_ops(team);
+
+                if (exit_op)
+                        exit_op(team);
+                team_mode_put(team->mode);
+                team->mode = NULL;
+                /* zero private data area */
+                memset(&team->mode_priv, 0,
+                       sizeof(struct team) - offsetof(struct team, mode_priv));
+        }
+
+        if (!new_mode)
+                return 0;
+
+        if (new_mode->ops->init) {
+                int err;
+
+                err = new_mode->ops->init(team);
+                if (err)
+                        return err;
+        }
+
+        team->mode = new_mode;
+        memcpy(&team->ops, new_mode->ops, sizeof(struct team_mode_ops));
+        team_adjust_ops(team);
+
+        return 0;
+}
+
+static int team_change_mode(struct team *team, const char *kind)
+{
+        struct team_mode *new_mode;
+        struct net_device *dev = team->dev;
+        int err;
+
+        if (!list_empty(&team->port_list)) {
+                netdev_err(dev, "No ports can be present during mode change\n");
+                return -EBUSY;
+        }
+
+        if (team->mode && strcmp(team->mode->kind, kind) == 0) {
+                netdev_err(dev, "Unable to change to the same mode the team is in\n");
+                return -EINVAL;
+        }
+
+        new_mode = team_mode_get(kind);
+        if (!new_mode) {
+                netdev_err(dev, "Mode \"%s\" not found\n", kind);
+                return -EINVAL;
+        }
+
+        err = __team_change_mode(team, new_mode);
+        if (err) {
+                netdev_err(dev, "Failed to change to mode \"%s\"\n", kind);
+                team_mode_put(new_mode);
+                return err;
+        }
+
+        netdev_info(dev, "Mode changed to \"%s\"\n", kind);
+        return 0;
+}
+
+
+/************************
+ * Rx path frame handler
+ ************************/
+
+/* note: already called with rcu_read_lock */
+static rx_handler_result_t team_handle_frame(struct sk_buff **pskb)
+{
+        struct sk_buff *skb = *pskb;
+        struct team_port *port;
+        struct team *team;
+        rx_handler_result_t res;
+
+        skb = skb_share_check(skb, GFP_ATOMIC);
+        if (!skb)
+                return RX_HANDLER_CONSUMED;
+
+        *pskb = skb;
+
+        port = team_port_get_rcu(skb->dev);
+        team = port->team;
+
+        res = team->ops.receive(team, port, skb);
+        if (res == RX_HANDLER_ANOTHER) {
+                struct team_pcpu_stats *pcpu_stats;
+
+                pcpu_stats = this_cpu_ptr(team->pcpu_stats);
+                u64_stats_update_begin(&pcpu_stats->syncp);
+                pcpu_stats->rx_packets++;
+                pcpu_stats->rx_bytes += skb->len;
+                if (skb->pkt_type == PACKET_MULTICAST)
+                        pcpu_stats->rx_multicast++;
+                u64_stats_update_end(&pcpu_stats->syncp);
+
+                skb->dev = team->dev;
+        } else {
+                this_cpu_inc(team->pcpu_stats->rx_dropped);
+        }
+
+        return res;
+}
+
+
+/****************
+ * Port handling
+ ****************/
+
+static bool team_port_find(const struct team *team,
+                           const struct team_port *port)
+{
+        struct team_port *cur;
+
+        list_for_each_entry(cur, &team->port_list, list)
+                if (cur == port)
+                        return true;
+        return false;
+}
+
+/*
+ * Add/delete port to the team port list. Write guarded by rtnl_lock.
+ * Takes care of correct port->index setup (might be racy).
+ */
+static void team_port_list_add_port(struct team *team,
+                                    struct team_port *port)
+{
+        port->index = team->port_count++;
+        hlist_add_head_rcu(&port->hlist,
+                           team_port_index_hash(team, port->index));
+        list_add_tail_rcu(&port->list, &team->port_list);
+}
+
+static void __reconstruct_port_hlist(struct team *team, int rm_index)
+{
+        int i;
+        struct team_port *port;
+
+        for (i = rm_index + 1; i < team->port_count; i++) {
+                port = team_get_port_by_index(team, i);
+                hlist_del_rcu(&port->hlist);
+                port->index--;
+                hlist_add_head_rcu(&port->hlist,
+                                   team_port_index_hash(team, port->index));
+        }
+}
+
+static void team_port_list_del_port(struct team *team,
+                                   struct team_port *port)
+{
+        int rm_index = port->index;
+
+        hlist_del_rcu(&port->hlist);
+        list_del_rcu(&port->list);
+        __reconstruct_port_hlist(team, rm_index);
+        team->port_count--;
+}
+
+#define TEAM_VLAN_FEATURES (NETIF_F_ALL_CSUM | NETIF_F_SG | \
+                            NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \
+                            NETIF_F_HIGHDMA | NETIF_F_LRO)
+
+static void __team_compute_features(struct team *team)
+{
+        struct team_port *port;
+        u32 vlan_features = TEAM_VLAN_FEATURES;
+        unsigned short max_hard_header_len = ETH_HLEN;
+
+        list_for_each_entry(port, &team->port_list, list) {
+                vlan_features = netdev_increment_features(vlan_features,
+                                        port->dev->vlan_features,
+                                        TEAM_VLAN_FEATURES);
+
+                if (port->dev->hard_header_len > max_hard_header_len)
+                        max_hard_header_len = port->dev->hard_header_len;
+        }
+
+        team->dev->vlan_features = vlan_features;
+        team->dev->hard_header_len = max_hard_header_len;
+
+        netdev_change_features(team->dev);
+}
+
+static void team_compute_features(struct team *team)
+{
+        mutex_lock(&team->lock);
+        __team_compute_features(team);
+        mutex_unlock(&team->lock);
+}
+
+static int team_port_enter(struct team *team, struct team_port *port)
+{
+        int err = 0;
+
+        dev_hold(team->dev);
+        port->dev->priv_flags |= IFF_TEAM_PORT;
+        if (team->ops.port_enter) {
+                err = team->ops.port_enter(team, port);
+                if (err) {
+                        netdev_err(team->dev, "Device %s failed to enter team mode\n",
+                                   port->dev->name);
+                        goto err_port_enter;
+                }
+        }
+
+        return 0;
+
+err_port_enter:
+        port->dev->priv_flags &= ~IFF_TEAM_PORT;
+        dev_put(team->dev);
+
+        return err;
+}
+
+static void team_port_leave(struct team *team, struct team_port *port)
+{
+        if (team->ops.port_leave)
+                team->ops.port_leave(team, port);
+        port->dev->priv_flags &= ~IFF_TEAM_PORT;
+        dev_put(team->dev);
+}
+
+static void __team_port_change_check(struct team_port *port, bool linkup);
+
+static int team_port_add(struct team *team, struct net_device *port_dev)
+{
+        struct net_device *dev = team->dev;
+        struct team_port *port;
+        char *portname = port_dev->name;
+        int err;
+
+        if (port_dev->flags & IFF_LOOPBACK ||
+            port_dev->type != ARPHRD_ETHER) {
+                netdev_err(dev, "Device %s is of an unsupported type\n",
+                           portname);
+                return -EINVAL;
+        }
+
+        if (team_port_exists(port_dev)) {
+                netdev_err(dev, "Device %s is already a port "
+                                "of a team device\n", portname);
+                return -EBUSY;
+        }
+
+        if (port_dev->flags & IFF_UP) {
+                netdev_err(dev, "Device %s is up. Set it down before adding it as a team port\n",
+                           portname);
+                return -EBUSY;
+        }
+
+        port = kzalloc(sizeof(struct team_port), GFP_KERNEL);
+        if (!port)
+                return -ENOMEM;
+
+        port->dev = port_dev;
+        port->team = team;
+
+        port->orig.mtu = port_dev->mtu;
+        err = dev_set_mtu(port_dev, dev->mtu);
+        if (err) {
+                netdev_dbg(dev, "Error %d calling dev_set_mtu\n", err);
+                goto err_set_mtu;
+        }
+
+        memcpy(port->orig.dev_addr, port_dev->dev_addr, ETH_ALEN);
+
+        err = team_port_enter(team, port);
+        if (err) {
+                netdev_err(dev, "Device %s failed to enter team mode\n",
+                           portname);
+                goto err_port_enter;
+        }
+
+        err = dev_open(port_dev);
+        if (err) {
+                netdev_dbg(dev, "Device %s opening failed\n",
+                           portname);
+                goto err_dev_open;
+        }
+
+        err = netdev_set_master(port_dev, dev);
+        if (err) {
+                netdev_err(dev, "Device %s failed to set master\n", portname);
+                goto err_set_master;
+        }
+
+        err = netdev_rx_handler_register(port_dev, team_handle_frame,
+                                         port);
+        if (err) {
+                netdev_err(dev, "Device %s failed to register rx_handler\n",
+                           portname);
+                goto err_handler_register;
+        }
+
+        team_port_list_add_port(team, port);
+        team_adjust_ops(team);
+        __team_compute_features(team);
+        __team_port_change_check(port, !!netif_carrier_ok(port_dev));
+
+        netdev_info(dev, "Port device %s added\n", portname);
+
+        return 0;
+
+err_handler_register:
+        netdev_set_master(port_dev, NULL);
+
+err_set_master:
+        dev_close(port_dev);
+
+err_dev_open:
+        team_port_leave(team, port);
+        team_port_set_orig_mac(port);
+
+err_port_enter:
+        dev_set_mtu(port_dev, port->orig.mtu);
+
+err_set_mtu:
+        kfree(port);
+
+        return err;
+}
+
+static int team_port_del(struct team *team, struct net_device *port_dev)
+{
+        struct net_device *dev = team->dev;
+        struct team_port *port;
+        char *portname = port_dev->name;
+
+        port = team_port_get_rtnl(port_dev);
+        if (!port || !team_port_find(team, port)) {
+                netdev_err(dev, "Device %s does not act as a port of this team\n",
+                           portname);
+                return -ENOENT;
+        }
+
+        __team_port_change_check(port, false);
+        team_port_list_del_port(team, port);
+        team_adjust_ops(team);
+        netdev_rx_handler_unregister(port_dev);
+        netdev_set_master(port_dev, NULL);
+        dev_close(port_dev);
+        team_port_leave(team, port);
+        team_port_set_orig_mac(port);
+        dev_set_mtu(port_dev, port->orig.mtu);
+        synchronize_rcu();
+        kfree(port);
+        netdev_info(dev, "Port device %s removed\n", portname);
+        __team_compute_features(team);
+
+        return 0;
+}
+
+
+/*****************
+ * Net device ops
+ *****************/
+
+static const char team_no_mode_kind[] = "*NOMODE*";
+
+static int team_mode_option_get(struct team *team, void *arg)
+{
+        const char **str = arg;
+
+        *str = team->mode ? team->mode->kind : team_no_mode_kind;
+        return 0;
+}
+
+static int team_mode_option_set(struct team *team, void *arg)
+{
+        const char **str = arg;
+
+        return team_change_mode(team, *str);
+}
+
+static const struct team_option team_options[] = {
+        {
+                .name = "mode",
+                .type = TEAM_OPTION_TYPE_STRING,
+                .getter = team_mode_option_get,
+                .setter = team_mode_option_set,
+        },
+};
+
+static int team_init(struct net_device *dev)
+{
+        struct team *team = netdev_priv(dev);
+        int i;
+        int err;
+
+        team->dev = dev;
+        mutex_init(&team->lock);
+
+        team->pcpu_stats = alloc_percpu(struct team_pcpu_stats);
+        if (!team->pcpu_stats)
+                return -ENOMEM;
+
+        for (i = 0; i < TEAM_PORT_HASHENTRIES; i++)
+                INIT_HLIST_HEAD(&team->port_hlist[i]);
+        INIT_LIST_HEAD(&team->port_list);
+
+        team_adjust_ops(team);
+
+        INIT_LIST_HEAD(&team->option_list);
+        err = team_options_register(team, team_options, ARRAY_SIZE(team_options));
+        if (err)
+                goto err_options_register;
+        netif_carrier_off(dev);
+
+        return 0;
+
+err_options_register:
+        free_percpu(team->pcpu_stats);
+
+        return err;
+}
+
+static void team_uninit(struct net_device *dev)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+        struct team_port *tmp;
+
+        mutex_lock(&team->lock);
+        list_for_each_entry_safe(port, tmp, &team->port_list, list)
+                team_port_del(team, port->dev);
+
+        __team_change_mode(team, NULL); /* cleanup */
+        __team_options_unregister(team, team_options, ARRAY_SIZE(team_options));
+        mutex_unlock(&team->lock);
+}
+
+static void team_destructor(struct net_device *dev)
+{
+        struct team *team = netdev_priv(dev);
+
+        free_percpu(team->pcpu_stats);
+        free_netdev(dev);
+}
+
+static int team_open(struct net_device *dev)
+{
+        netif_carrier_on(dev);
+        return 0;
+}
+
+static int team_close(struct net_device *dev)
+{
+        netif_carrier_off(dev);
+        return 0;
+}
+
+/*
+ * note: already called with rcu_read_lock
+ */
+static netdev_tx_t team_xmit(struct sk_buff *skb, struct net_device *dev)
+{
+        struct team *team = netdev_priv(dev);
+        bool tx_success = false;
+        unsigned int len = skb->len;
+
+        tx_success = team->ops.transmit(team, skb);
+        if (tx_success) {
+                struct team_pcpu_stats *pcpu_stats;
+
+                pcpu_stats = this_cpu_ptr(team->pcpu_stats);
+                u64_stats_update_begin(&pcpu_stats->syncp);
+                pcpu_stats->tx_packets++;
+                pcpu_stats->tx_bytes += len;
+                u64_stats_update_end(&pcpu_stats->syncp);
+        } else {
+                this_cpu_inc(team->pcpu_stats->tx_dropped);
+        }
+
+        return NETDEV_TX_OK;
+}
+
+static void team_change_rx_flags(struct net_device *dev, int change)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+        int inc;
+
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                if (change & IFF_PROMISC) {
+                        inc = dev->flags & IFF_PROMISC ? 1 : -1;
+                        dev_set_promiscuity(port->dev, inc);
+                }
+                if (change & IFF_ALLMULTI) {
+                        inc = dev->flags & IFF_ALLMULTI ? 1 : -1;
+                        dev_set_allmulti(port->dev, inc);
+                }
+        }
+        rcu_read_unlock();
+}
+
+static void team_set_rx_mode(struct net_device *dev)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                dev_uc_sync(port->dev, dev);
+                dev_mc_sync(port->dev, dev);
+        }
+        rcu_read_unlock();
+}
+
+static int team_set_mac_address(struct net_device *dev, void *p)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+        struct sockaddr *addr = p;
+
+        memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list)
+                if (team->ops.port_change_mac)
+                        team->ops.port_change_mac(team, port);
+        rcu_read_unlock();
+        return 0;
+}
+
+static int team_change_mtu(struct net_device *dev, int new_mtu)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+        int err;
+
+        /*
+         * Alhough this is reader, it's guarded by team lock. It's not possible
+         * to traverse list in reverse under rcu_read_lock
+         */
+        mutex_lock(&team->lock);
+        list_for_each_entry(port, &team->port_list, list) {
+                err = dev_set_mtu(port->dev, new_mtu);
+                if (err) {
+                        netdev_err(dev, "Device %s failed to change mtu",
+                                   port->dev->name);
+                        goto unwind;
+                }
+        }
+        mutex_unlock(&team->lock);
+
+        dev->mtu = new_mtu;
+
+        return 0;
+
+unwind:
+        list_for_each_entry_continue_reverse(port, &team->port_list, list)
+                dev_set_mtu(port->dev, dev->mtu);
+        mutex_unlock(&team->lock);
+
+        return err;
+}
+
+static struct rtnl_link_stats64 *
+team_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_pcpu_stats *p;
+        u64 rx_packets, rx_bytes, rx_multicast, tx_packets, tx_bytes;
+        u32 rx_dropped = 0, tx_dropped = 0;
+        unsigned int start;
+        int i;
+
+        for_each_possible_cpu(i) {
+                p = per_cpu_ptr(team->pcpu_stats, i);
+                do {
+                        start = u64_stats_fetch_begin_bh(&p->syncp);
+                        rx_packets      = p->rx_packets;
+                        rx_bytes        = p->rx_bytes;
+                        rx_multicast    = p->rx_multicast;
+                        tx_packets      = p->tx_packets;
+                        tx_bytes        = p->tx_bytes;
+                } while (u64_stats_fetch_retry_bh(&p->syncp, start));
+
+                stats->rx_packets       += rx_packets;
+                stats->rx_bytes         += rx_bytes;
+                stats->multicast        += rx_multicast;
+                stats->tx_packets       += tx_packets;
+                stats->tx_bytes         += tx_bytes;
+                /*
+                 * rx_dropped & tx_dropped are u32, updated
+                 * without syncp protection.
+                 */
+                rx_dropped      += p->rx_dropped;
+                tx_dropped      += p->tx_dropped;
+        }
+        stats->rx_dropped       = rx_dropped;
+        stats->tx_dropped       = tx_dropped;
+        return stats;
+}
+
+static void team_vlan_rx_add_vid(struct net_device *dev, uint16_t vid)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                const struct net_device_ops *ops = port->dev->netdev_ops;
+
+                if (ops->ndo_vlan_rx_add_vid)
+                        ops->ndo_vlan_rx_add_vid(port->dev, vid);
+        }
+        rcu_read_unlock();
+}
+
+static void team_vlan_rx_kill_vid(struct net_device *dev, uint16_t vid)
+{
+        struct team *team = netdev_priv(dev);
+        struct team_port *port;
+
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                const struct net_device_ops *ops = port->dev->netdev_ops;
+
+                if (ops->ndo_vlan_rx_kill_vid)
+                        ops->ndo_vlan_rx_kill_vid(port->dev, vid);
+        }
+        rcu_read_unlock();
+}
+
+static int team_add_slave(struct net_device *dev, struct net_device *port_dev)
+{
+        struct team *team = netdev_priv(dev);
+        int err;
+
+        mutex_lock(&team->lock);
+        err = team_port_add(team, port_dev);
+        mutex_unlock(&team->lock);
+        return err;
+}
+
+static int team_del_slave(struct net_device *dev, struct net_device *port_dev)
+{
+        struct team *team = netdev_priv(dev);
+        int err;
+
+        mutex_lock(&team->lock);
+        err = team_port_del(team, port_dev);
+        mutex_unlock(&team->lock);
+        return err;
+}
+
+static netdev_features_t team_fix_features(struct net_device *dev,
+                                           netdev_features_t features)
+{
+        struct team_port *port;
+        struct team *team = netdev_priv(dev);
+        netdev_features_t mask;
+
+        mask = features;
+        features &= ~NETIF_F_ONE_FOR_ALL;
+        features |= NETIF_F_ALL_FOR_ALL;
+
+        rcu_read_lock();
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                features = netdev_increment_features(features,
+                                                     port->dev->features,
+                                                     mask);
+        }
+        rcu_read_unlock();
+        return features;
+}
+
+static const struct net_device_ops team_netdev_ops = {
+        .ndo_init               = team_init,
+        .ndo_uninit             = team_uninit,
+        .ndo_open               = team_open,
+        .ndo_stop               = team_close,
+        .ndo_start_xmit         = team_xmit,
+        .ndo_change_rx_flags    = team_change_rx_flags,
+        .ndo_set_rx_mode        = team_set_rx_mode,
+        .ndo_set_mac_address    = team_set_mac_address,
+        .ndo_change_mtu         = team_change_mtu,
+        .ndo_get_stats64        = team_get_stats64,
+        .ndo_vlan_rx_add_vid    = team_vlan_rx_add_vid,
+        .ndo_vlan_rx_kill_vid   = team_vlan_rx_kill_vid,
+        .ndo_add_slave          = team_add_slave,
+        .ndo_del_slave          = team_del_slave,
+        .ndo_fix_features       = team_fix_features,
+};
+
+
+/***********************
+ * rt netlink interface
+ ***********************/
+
+static void team_setup(struct net_device *dev)
+{
+        ether_setup(dev);
+
+        dev->netdev_ops = &team_netdev_ops;
+        dev->destructor = team_destructor;
+        dev->tx_queue_len = 0;
+        dev->flags |= IFF_MULTICAST;
+        dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING);
+
+        /*
+         * Indicate we support unicast address filtering. That way core won't
+         * bring us to promisc mode in case a unicast addr is added.
+         * Let this up to underlay drivers.
+         */
+        dev->priv_flags |= IFF_UNICAST_FLT;
+
+        dev->features |= NETIF_F_LLTX;
+        dev->features |= NETIF_F_GRO;
+        dev->hw_features = NETIF_F_HW_VLAN_TX |
+                           NETIF_F_HW_VLAN_RX |
+                           NETIF_F_HW_VLAN_FILTER;
+
+        dev->features |= dev->hw_features;
+}
+
+static int team_newlink(struct net *src_net, struct net_device *dev,
+                        struct nlattr *tb[], struct nlattr *data[])
+{
+        int err;
+
+        if (tb[IFLA_ADDRESS] == NULL)
+                random_ether_addr(dev->dev_addr);
+
+        err = register_netdevice(dev);
+        if (err)
+                return err;
+
+        return 0;
+}
+
+static int team_validate(struct nlattr *tb[], struct nlattr *data[])
+{
+        if (tb[IFLA_ADDRESS]) {
+                if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN)
+                        return -EINVAL;
+                if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS])))
+                        return -EADDRNOTAVAIL;
+        }
+        return 0;
+}
+
+static struct rtnl_link_ops team_link_ops __read_mostly = {
+        .kind           = DRV_NAME,
+        .priv_size      = sizeof(struct team),
+        .setup          = team_setup,
+        .newlink        = team_newlink,
+        .validate       = team_validate,
+};
+
+
+/***********************************
+ * Generic netlink custom interface
+ ***********************************/
+
+static struct genl_family team_nl_family = {
+        .id             = GENL_ID_GENERATE,
+        .name           = TEAM_GENL_NAME,
+        .version        = TEAM_GENL_VERSION,
+        .maxattr        = TEAM_ATTR_MAX,
+        .netnsok        = true,
+};
+
+static const struct nla_policy team_nl_policy[TEAM_ATTR_MAX + 1] = {
+        [TEAM_ATTR_UNSPEC]                      = { .type = NLA_UNSPEC, },
+        [TEAM_ATTR_TEAM_IFINDEX]                = { .type = NLA_U32 },
+        [TEAM_ATTR_LIST_OPTION]                 = { .type = NLA_NESTED },
+        [TEAM_ATTR_LIST_PORT]                   = { .type = NLA_NESTED },
+};
+
+static const struct nla_policy
+team_nl_option_policy[TEAM_ATTR_OPTION_MAX + 1] = {
+        [TEAM_ATTR_OPTION_UNSPEC]               = { .type = NLA_UNSPEC, },
+        [TEAM_ATTR_OPTION_NAME] = {
+                .type = NLA_STRING,
+                .len = TEAM_STRING_MAX_LEN,
+        },
+        [TEAM_ATTR_OPTION_CHANGED]              = { .type = NLA_FLAG },
+        [TEAM_ATTR_OPTION_TYPE]                 = { .type = NLA_U8 },
+        [TEAM_ATTR_OPTION_DATA] = {
+                .type = NLA_BINARY,
+                .len = TEAM_STRING_MAX_LEN,
+        },
+};
+
+static int team_nl_cmd_noop(struct sk_buff *skb, struct genl_info *info)
+{
+        struct sk_buff *msg;
+        void *hdr;
+        int err;
+
+        msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+        if (!msg)
+                return -ENOMEM;
+
+        hdr = genlmsg_put(msg, info->snd_pid, info->snd_seq,
+                          &team_nl_family, 0, TEAM_CMD_NOOP);
+        if (IS_ERR(hdr)) {
+                err = PTR_ERR(hdr);
+                goto err_msg_put;
+        }
+
+        genlmsg_end(msg, hdr);
+
+        return genlmsg_unicast(genl_info_net(info), msg, info->snd_pid);
+
+err_msg_put:
+        nlmsg_free(msg);
+
+        return err;
+}
+
+/*
+ * Netlink cmd functions should be locked by following two functions.
+ * Since dev gets held here, that ensures dev won't disappear in between.
+ */
+static struct team *team_nl_team_get(struct genl_info *info)
+{
+        struct net *net = genl_info_net(info);
+        int ifindex;
+        struct net_device *dev;
+        struct team *team;
+
+        if (!info->attrs[TEAM_ATTR_TEAM_IFINDEX])
+                return NULL;
+
+        ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
+        dev = dev_get_by_index(net, ifindex);
+        if (!dev || dev->netdev_ops != &team_netdev_ops) {
+                if (dev)
+                        dev_put(dev);
+                return NULL;
+        }
+
+        team = netdev_priv(dev);
+        mutex_lock(&team->lock);
+        return team;
+}
+
+static void team_nl_team_put(struct team *team)
+{
+        mutex_unlock(&team->lock);
+        dev_put(team->dev);
+}
+
+static int team_nl_send_generic(struct genl_info *info, struct team *team,
+                                int (*fill_func)(struct sk_buff *skb,
+                                                 struct genl_info *info,
+                                                 int flags, struct team *team))
+{
+        struct sk_buff *skb;
+        int err;
+
+        skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+        if (!skb)
+                return -ENOMEM;
+
+        err = fill_func(skb, info, NLM_F_ACK, team);
+        if (err < 0)
+                goto err_fill;
+
+        err = genlmsg_unicast(genl_info_net(info), skb, info->snd_pid);
+        return err;
+
+err_fill:
+        nlmsg_free(skb);
+        return err;
+}
+
+static int team_nl_fill_options_get_changed(struct sk_buff *skb,
+                                            u32 pid, u32 seq, int flags,
+                                            struct team *team,
+                                            struct team_option *changed_option)
+{
+        struct nlattr *option_list;
+        void *hdr;
+        struct team_option *option;
+
+        hdr = genlmsg_put(skb, pid, seq, &team_nl_family, flags,
+                          TEAM_CMD_OPTIONS_GET);
+        if (IS_ERR(hdr))
+                return PTR_ERR(hdr);
+
+        NLA_PUT_U32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex);
+        option_list = nla_nest_start(skb, TEAM_ATTR_LIST_OPTION);
+        if (!option_list)
+                return -EMSGSIZE;
+
+        list_for_each_entry(option, &team->option_list, list) {
+                struct nlattr *option_item;
+                long arg;
+
+                option_item = nla_nest_start(skb, TEAM_ATTR_ITEM_OPTION);
+                if (!option_item)
+                        goto nla_put_failure;
+                NLA_PUT_STRING(skb, TEAM_ATTR_OPTION_NAME, option->name);
+                if (option == changed_option)
+                        NLA_PUT_FLAG(skb, TEAM_ATTR_OPTION_CHANGED);
+                switch (option->type) {
+                case TEAM_OPTION_TYPE_U32:
+                        NLA_PUT_U8(skb, TEAM_ATTR_OPTION_TYPE, NLA_U32);
+                        team_option_get(team, option, &arg);
+                        NLA_PUT_U32(skb, TEAM_ATTR_OPTION_DATA, arg);
+                        break;
+                case TEAM_OPTION_TYPE_STRING:
+                        NLA_PUT_U8(skb, TEAM_ATTR_OPTION_TYPE, NLA_STRING);
+                        team_option_get(team, option, &arg);
+                        NLA_PUT_STRING(skb, TEAM_ATTR_OPTION_DATA,
+                                       (char *) arg);
+                        break;
+                default:
+                        BUG();
+                }
+                nla_nest_end(skb, option_item);
+        }
+
+        nla_nest_end(skb, option_list);
+        return genlmsg_end(skb, hdr);
+
+nla_put_failure:
+        genlmsg_cancel(skb, hdr);
+        return -EMSGSIZE;
+}
+
+static int team_nl_fill_options_get(struct sk_buff *skb,
+                                    struct genl_info *info, int flags,
+                                    struct team *team)
+{
+        return team_nl_fill_options_get_changed(skb, info->snd_pid,
+                                                info->snd_seq, NLM_F_ACK,
+                                                team, NULL);
+}
+
+static int team_nl_cmd_options_get(struct sk_buff *skb, struct genl_info *info)
+{
+        struct team *team;
+        int err;
+
+        team = team_nl_team_get(info);
+        if (!team)
+                return -EINVAL;
+
+        err = team_nl_send_generic(info, team, team_nl_fill_options_get);
+
+        team_nl_team_put(team);
+
+        return err;
+}
+
+static int team_nl_cmd_options_set(struct sk_buff *skb, struct genl_info *info)
+{
+        struct team *team;
+        int err = 0;
+        int i;
+        struct nlattr *nl_option;
+
+        team = team_nl_team_get(info);
+        if (!team)
+                return -EINVAL;
+
+        err = -EINVAL;
+        if (!info->attrs[TEAM_ATTR_LIST_OPTION]) {
+                err = -EINVAL;
+                goto team_put;
+        }
+
+        nla_for_each_nested(nl_option, info->attrs[TEAM_ATTR_LIST_OPTION], i) {
+                struct nlattr *mode_attrs[TEAM_ATTR_OPTION_MAX + 1];
+                enum team_option_type opt_type;
+                struct team_option *option;
+                char *opt_name;
+                bool opt_found = false;
+
+                if (nla_type(nl_option) != TEAM_ATTR_ITEM_OPTION) {
+                        err = -EINVAL;
+                        goto team_put;
+                }
+                err = nla_parse_nested(mode_attrs, TEAM_ATTR_OPTION_MAX,
+                                       nl_option, team_nl_option_policy);
+                if (err)
+                        goto team_put;
+                if (!mode_attrs[TEAM_ATTR_OPTION_NAME] ||
+                    !mode_attrs[TEAM_ATTR_OPTION_TYPE] ||
+                    !mode_attrs[TEAM_ATTR_OPTION_DATA]) {
+                        err = -EINVAL;
+                        goto team_put;
+                }
+                switch (nla_get_u8(mode_attrs[TEAM_ATTR_OPTION_TYPE])) {
+                case NLA_U32:
+                        opt_type = TEAM_OPTION_TYPE_U32;
+                        break;
+                case NLA_STRING:
+                        opt_type = TEAM_OPTION_TYPE_STRING;
+                        break;
+                default:
+                        goto team_put;
+                }
+
+                opt_name = nla_data(mode_attrs[TEAM_ATTR_OPTION_NAME]);
+                list_for_each_entry(option, &team->option_list, list) {
+                        long arg;
+                        struct nlattr *opt_data_attr;
+
+                        if (option->type != opt_type ||
+                            strcmp(option->name, opt_name))
+                                continue;
+                        opt_found = true;
+                        opt_data_attr = mode_attrs[TEAM_ATTR_OPTION_DATA];
+                        switch (opt_type) {
+                        case TEAM_OPTION_TYPE_U32:
+                                arg = nla_get_u32(opt_data_attr);
+                                break;
+                        case TEAM_OPTION_TYPE_STRING:
+                                arg = (long) nla_data(opt_data_attr);
+                                break;
+                        default:
+                                BUG();
+                        }
+                        err = team_option_set(team, option, &arg);
+                        if (err)
+                                goto team_put;
+                }
+                if (!opt_found) {
+                        err = -ENOENT;
+                        goto team_put;
+                }
+        }
+
+team_put:
+        team_nl_team_put(team);
+
+        return err;
+}
+
+static int team_nl_fill_port_list_get_changed(struct sk_buff *skb,
+                                              u32 pid, u32 seq, int flags,
+                                              struct team *team,
+                                              struct team_port *changed_port)
+{
+        struct nlattr *port_list;
+        void *hdr;
+        struct team_port *port;
+
+        hdr = genlmsg_put(skb, pid, seq, &team_nl_family, flags,
+                          TEAM_CMD_PORT_LIST_GET);
+        if (IS_ERR(hdr))
+                return PTR_ERR(hdr);
+
+        NLA_PUT_U32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex);
+        port_list = nla_nest_start(skb, TEAM_ATTR_LIST_PORT);
+        if (!port_list)
+                return -EMSGSIZE;
+
+        list_for_each_entry(port, &team->port_list, list) {
+                struct nlattr *port_item;
+
+                port_item = nla_nest_start(skb, TEAM_ATTR_ITEM_PORT);
+                if (!port_item)
+                        goto nla_put_failure;
+                NLA_PUT_U32(skb, TEAM_ATTR_PORT_IFINDEX, port->dev->ifindex);
+                if (port == changed_port)
+                        NLA_PUT_FLAG(skb, TEAM_ATTR_PORT_CHANGED);
+                if (port->linkup)
+                        NLA_PUT_FLAG(skb, TEAM_ATTR_PORT_LINKUP);
+                NLA_PUT_U32(skb, TEAM_ATTR_PORT_SPEED, port->speed);
+                NLA_PUT_U8(skb, TEAM_ATTR_PORT_DUPLEX, port->duplex);
+                nla_nest_end(skb, port_item);
+        }
+
+        nla_nest_end(skb, port_list);
+        return genlmsg_end(skb, hdr);
+
+nla_put_failure:
+        genlmsg_cancel(skb, hdr);
+        return -EMSGSIZE;
+}
+
+static int team_nl_fill_port_list_get(struct sk_buff *skb,
+                                      struct genl_info *info, int flags,
+                                      struct team *team)
+{
+        return team_nl_fill_port_list_get_changed(skb, info->snd_pid,
+                                                  info->snd_seq, NLM_F_ACK,
+                                                  team, NULL);
+}
+
+static int team_nl_cmd_port_list_get(struct sk_buff *skb,
+                                     struct genl_info *info)
+{
+        struct team *team;
+        int err;
+
+        team = team_nl_team_get(info);
+        if (!team)
+                return -EINVAL;
+
+        err = team_nl_send_generic(info, team, team_nl_fill_port_list_get);
+
+        team_nl_team_put(team);
+
+        return err;
+}
+
+static struct genl_ops team_nl_ops[] = {
+        {
+                .cmd = TEAM_CMD_NOOP,
+                .doit = team_nl_cmd_noop,
+                .policy = team_nl_policy,
+        },
+        {
+                .cmd = TEAM_CMD_OPTIONS_SET,
+                .doit = team_nl_cmd_options_set,
+                .policy = team_nl_policy,
+                .flags = GENL_ADMIN_PERM,
+        },
+        {
+                .cmd = TEAM_CMD_OPTIONS_GET,
+                .doit = team_nl_cmd_options_get,
+                .policy = team_nl_policy,
+                .flags = GENL_ADMIN_PERM,
+        },
+        {
+                .cmd = TEAM_CMD_PORT_LIST_GET,
+                .doit = team_nl_cmd_port_list_get,
+                .policy = team_nl_policy,
+                .flags = GENL_ADMIN_PERM,
+        },
+};
+
+static struct genl_multicast_group team_change_event_mcgrp = {
+        .name = TEAM_GENL_CHANGE_EVENT_MC_GRP_NAME,
+};
+
+static int team_nl_send_event_options_get(struct team *team,
+                                          struct team_option *changed_option)
+{
+        struct sk_buff *skb;
+        int err;
+        struct net *net = dev_net(team->dev);
+
+        skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+        if (!skb)
+                return -ENOMEM;
+
+        err = team_nl_fill_options_get_changed(skb, 0, 0, 0, team,
+                                               changed_option);
+        if (err < 0)
+                goto err_fill;
+
+        err = genlmsg_multicast_netns(net, skb, 0, team_change_event_mcgrp.id,
+                                      GFP_KERNEL);
+        return err;
+
+err_fill:
+        nlmsg_free(skb);
+        return err;
+}
+
+static int team_nl_send_event_port_list_get(struct team_port *port)
+{
+        struct sk_buff *skb;
+        int err;
+        struct net *net = dev_net(port->team->dev);
+
+        skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+        if (!skb)
+                return -ENOMEM;
+
+        err = team_nl_fill_port_list_get_changed(skb, 0, 0, 0,
+                                                 port->team, port);
+        if (err < 0)
+                goto err_fill;
+
+        err = genlmsg_multicast_netns(net, skb, 0, team_change_event_mcgrp.id,
+                                      GFP_KERNEL);
+        return err;
+
+err_fill:
+        nlmsg_free(skb);
+        return err;
+}
+
+static int team_nl_init(void)
+{
+        int err;
+
+        err = genl_register_family_with_ops(&team_nl_family, team_nl_ops,
+                                            ARRAY_SIZE(team_nl_ops));
+        if (err)
+                return err;
+
+        err = genl_register_mc_group(&team_nl_family, &team_change_event_mcgrp);
+        if (err)
+                goto err_change_event_grp_reg;
+
+        return 0;
+
+err_change_event_grp_reg:
+        genl_unregister_family(&team_nl_family);
+
+        return err;
+}
+
+static void team_nl_fini(void)
+{
+        genl_unregister_family(&team_nl_family);
+}
+
+
+/******************
+ * Change checkers
+ ******************/
+
+static void __team_options_change_check(struct team *team,
+                                        struct team_option *changed_option)
+{
+        int err;
+
+        err = team_nl_send_event_options_get(team, changed_option);
+        if (err)
+                netdev_warn(team->dev, "Failed to send options change via netlink\n");
+}
+
+/* rtnl lock is held */
+static void __team_port_change_check(struct team_port *port, bool linkup)
+{
+        int err;
+
+        if (port->linkup == linkup)
+                return;
+
+        port->linkup = linkup;
+        if (linkup) {
+                struct ethtool_cmd ecmd;
+
+                err = __ethtool_get_settings(port->dev, &ecmd);
+                if (!err) {
+                        port->speed = ethtool_cmd_speed(&ecmd);
+                        port->duplex = ecmd.duplex;
+                        goto send_event;
+                }
+        }
+        port->speed = 0;
+        port->duplex = 0;
+
+send_event:
+        err = team_nl_send_event_port_list_get(port);
+        if (err)
+                netdev_warn(port->team->dev, "Failed to send port change of device %s via netlink\n",
+                            port->dev->name);
+
+}
+
+static void team_port_change_check(struct team_port *port, bool linkup)
+{
+        struct team *team = port->team;
+
+        mutex_lock(&team->lock);
+        __team_port_change_check(port, linkup);
+        mutex_unlock(&team->lock);
+}
+
+/************************************
+ * Net device notifier event handler
+ ************************************/
+
+static int team_device_event(struct notifier_block *unused,
+                             unsigned long event, void *ptr)
+{
+        struct net_device *dev = (struct net_device *) ptr;
+        struct team_port *port;
+
+        port = team_port_get_rtnl(dev);
+        if (!port)
+                return NOTIFY_DONE;
+
+        switch (event) {
+        case NETDEV_UP:
+                if (netif_carrier_ok(dev))
+                        team_port_change_check(port, true);
+        case NETDEV_DOWN:
+                team_port_change_check(port, false);
+        case NETDEV_CHANGE:
+                if (netif_running(port->dev))
+                        team_port_change_check(port,
+                                               !!netif_carrier_ok(port->dev));
+                break;
+        case NETDEV_UNREGISTER:
+                team_del_slave(port->team->dev, dev);
+                break;
+        case NETDEV_FEAT_CHANGE:
+                team_compute_features(port->team);
+                break;
+        case NETDEV_CHANGEMTU:
+                /* Forbid to change mtu of underlaying device */
+                return NOTIFY_BAD;
+        case NETDEV_PRE_TYPE_CHANGE:
+                /* Forbid to change type of underlaying device */
+                return NOTIFY_BAD;
+        }
+        return NOTIFY_DONE;
+}
+
+static struct notifier_block team_notifier_block __read_mostly = {
+        .notifier_call = team_device_event,
+};
+
+
+/***********************
+ * Module init and exit
+ ***********************/
+
+static int __init team_module_init(void)
+{
+        int err;
+
+        register_netdevice_notifier(&team_notifier_block);
+
+        err = rtnl_link_register(&team_link_ops);
+        if (err)
+                goto err_rtnl_reg;
+
+        err = team_nl_init();
+        if (err)
+                goto err_nl_init;
+
+        return 0;
+
+err_nl_init:
+        rtnl_link_unregister(&team_link_ops);
+
+err_rtnl_reg:
+        unregister_netdevice_notifier(&team_notifier_block);
+
+        return err;
+}
+
+static void __exit team_module_exit(void)
+{
+        team_nl_fini();
+        rtnl_link_unregister(&team_link_ops);
+        unregister_netdevice_notifier(&team_notifier_block);
+}
+
+module_init(team_module_init);
+module_exit(team_module_exit);
+
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Jiri Pirko <jpirko@redhat.com>");
+MODULE_DESCRIPTION("Ethernet team device driver");
+MODULE_ALIAS_RTNL_LINK(DRV_NAME);
diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c
new file mode 100644
index 000000000000..b34427502b54
--- /dev/null
+++ b/drivers/net/team/team_mode_activebackup.c
@@ -0,0 +1,136 @@
+/*
+ * net/drivers/team/team_mode_activebackup.c - Active-backup mode for team
+ * Copyright (c) 2011 Jiri Pirko <jpirko@redhat.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/errno.h>
+#include <linux/netdevice.h>
+#include <net/rtnetlink.h>
+#include <linux/if_team.h>
+
+struct ab_priv {
+        struct team_port __rcu *active_port;
+};
+
+static struct ab_priv *ab_priv(struct team *team)
+{
+        return (struct ab_priv *) &team->mode_priv;
+}
+
+static rx_handler_result_t ab_receive(struct team *team, struct team_port *port,
+                                      struct sk_buff *skb) {
+        struct team_port *active_port;
+
+        active_port = rcu_dereference(ab_priv(team)->active_port);
+        if (active_port != port)
+                return RX_HANDLER_EXACT;
+        return RX_HANDLER_ANOTHER;
+}
+
+static bool ab_transmit(struct team *team, struct sk_buff *skb)
+{
+        struct team_port *active_port;
+
+        active_port = rcu_dereference(ab_priv(team)->active_port);
+        if (unlikely(!active_port))
+                goto drop;
+        skb->dev = active_port->dev;
+        if (dev_queue_xmit(skb))
+                return false;
+        return true;
+
+drop:
+        dev_kfree_skb_any(skb);
+        return false;
+}
+
+static void ab_port_leave(struct team *team, struct team_port *port)
+{
+        if (ab_priv(team)->active_port == port)
+                rcu_assign_pointer(ab_priv(team)->active_port, NULL);
+}
+
+static int ab_active_port_get(struct team *team, void *arg)
+{
+        u32 *ifindex = arg;
+
+        *ifindex = 0;
+        if (ab_priv(team)->active_port)
+                *ifindex = ab_priv(team)->active_port->dev->ifindex;
+        return 0;
+}
+
+static int ab_active_port_set(struct team *team, void *arg)
+{
+        u32 *ifindex = arg;
+        struct team_port *port;
+
+        list_for_each_entry_rcu(port, &team->port_list, list) {
+                if (port->dev->ifindex == *ifindex) {
+                        rcu_assign_pointer(ab_priv(team)->active_port, port);
+                        return 0;
+                }
+        }
+        return -ENOENT;
+}
+
+static const struct team_option ab_options[] = {
+        {
+                .name = "activeport",
+                .type = TEAM_OPTION_TYPE_U32,
+                .getter = ab_active_port_get,
+                .setter = ab_active_port_set,
+        },
+};
+
+int ab_init(struct team *team)
+{
+        return team_options_register(team, ab_options, ARRAY_SIZE(ab_options));
+}
+
+void ab_exit(struct team *team)
+{
+        team_options_unregister(team, ab_options, ARRAY_SIZE(ab_options));
+}
+
+static const struct team_mode_ops ab_mode_ops = {
+        .init                   = ab_init,
+        .exit                   = ab_exit,
+        .receive                = ab_receive,
+        .transmit               = ab_transmit,
+        .port_leave             = ab_port_leave,
+};
+
+static struct team_mode ab_mode = {
+        .kind           = "activebackup",
+        .owner          = THIS_MODULE,
+        .priv_size      = sizeof(struct ab_priv),
+        .ops            = &ab_mode_ops,
+};
+
+static int __init ab_init_module(void)
+{
+        return team_mode_register(&ab_mode);
+}
+
+static void __exit ab_cleanup_module(void)
+{
+        team_mode_unregister(&ab_mode);
+}
+
+module_init(ab_init_module);
+module_exit(ab_cleanup_module);
+
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Jiri Pirko <jpirko@redhat.com>");
+MODULE_DESCRIPTION("Active-backup mode for team");
+MODULE_ALIAS("team-mode-activebackup");
diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c
new file mode 100644
index 000000000000..a0e8f806331a
--- /dev/null
+++ b/drivers/net/team/team_mode_roundrobin.c
@@ -0,0 +1,107 @@
+/*
+ * net/drivers/team/team_mode_roundrobin.c - Round-robin mode for team
+ * Copyright (c) 2011 Jiri Pirko <jpirko@redhat.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/errno.h>
+#include <linux/netdevice.h>
+#include <linux/if_team.h>
+
+struct rr_priv {
+        unsigned int sent_packets;
+};
+
+static struct rr_priv *rr_priv(struct team *team)
+{
+        return (struct rr_priv *) &team->mode_priv;
+}
+
+static struct team_port *__get_first_port_up(struct team *team,
+                                             struct team_port *port)
+{
+        struct team_port *cur;
+
+        if (port->linkup)
+                return port;
+        cur = port;
+        list_for_each_entry_continue_rcu(cur, &team->port_list, list)
+                if (cur->linkup)
+                        return cur;
+        list_for_each_entry_rcu(cur, &team->port_list, list) {
+                if (cur == port)
+                        break;
+                if (cur->linkup)
+                        return cur;
+        }
+        return NULL;
+}
+
+static bool rr_transmit(struct team *team, struct sk_buff *skb)
+{
+        struct team_port *port;
+        int port_index;
+
+        port_index = rr_priv(team)->sent_packets++ % team->port_count;
+        port = team_get_port_by_index_rcu(team, port_index);
+        port = __get_first_port_up(team, port);
+        if (unlikely(!port))
+                goto drop;
+        skb->dev = port->dev;
+        if (dev_queue_xmit(skb))
+                return false;
+        return true;
+
+drop:
+        dev_kfree_skb_any(skb);
+        return false;
+}
+
+static int rr_port_enter(struct team *team, struct team_port *port)
+{
+        return team_port_set_team_mac(port);
+}
+
+static void rr_port_change_mac(struct team *team, struct team_port *port)
+{
+        team_port_set_team_mac(port);
+}
+
+static const struct team_mode_ops rr_mode_ops = {
+        .transmit               = rr_transmit,
+        .port_enter             = rr_port_enter,
+        .port_change_mac        = rr_port_change_mac,
+};
+
+static struct team_mode rr_mode = {
+        .kind           = "roundrobin",
+        .owner          = THIS_MODULE,
+        .priv_size      = sizeof(struct rr_priv),
+        .ops            = &rr_mode_ops,
+};
+
+static int __init rr_init_module(void)
+{
+        return team_mode_register(&rr_mode);
+}
+
+static void __exit rr_cleanup_module(void)
+{
+        team_mode_unregister(&rr_mode);
+}
+
+module_init(rr_init_module);
+module_exit(rr_cleanup_module);
+
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Jiri Pirko <jpirko@redhat.com>");
+MODULE_DESCRIPTION("Round-robin mode for team");
+MODULE_ALIAS("team-mode-roundrobin");
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 7bea9c65119e..3dd13d606d00 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -123,7 +123,7 @@ struct tun_struct {
         gid_t                   group;
 
         struct net_device       *dev;
-        u32                     set_features;
+        netdev_features_t       set_features;
 #define TUN_USER_FEATURES (NETIF_F_HW_CSUM|NETIF_F_TSO_ECN|NETIF_F_TSO| \
                           NETIF_F_TSO6|NETIF_F_UFO)
         struct fasync_struct    *fasync;
@@ -454,7 +454,8 @@ tun_net_change_mtu(struct net_device *dev, int new_mtu)
         return 0;
 }
 
-static u32 tun_net_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t tun_net_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct tun_struct *tun = netdev_priv(dev);
 
@@ -1196,7 +1197,7 @@ static int tun_get_iff(struct net *net, struct tun_struct *tun,
  * privs required. */
 static int set_offload(struct tun_struct *tun, unsigned long arg)
 {
-        u32 features = 0;
+        netdev_features_t features = 0;
 
         if (arg & TUN_F_CSUM) {
                 features |= NETIF_F_HW_CSUM;
@@ -1589,16 +1590,16 @@ static void tun_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
 {
         struct tun_struct *tun = netdev_priv(dev);
 
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
 
         switch (tun->flags & TUN_TYPE_MASK) {
         case TUN_TUN_DEV:
-                strcpy(info->bus_info, "tun");
+                strlcpy(info->bus_info, "tun", sizeof(info->bus_info));
                 break;
         case TUN_TAP_DEV:
-                strcpy(info->bus_info, "tap");
+                strlcpy(info->bus_info, "tap", sizeof(info->bus_info));
                 break;
         }
 }
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index a5b9b12ef268..7d62c39f65cf 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -728,7 +728,8 @@ static int smsc75xx_change_mtu(struct net_device *netdev, int new_mtu)
 }
 
 /* Enable or disable Rx checksum offload engine */
-static int smsc75xx_set_features(struct net_device *netdev, u32 features)
+static int smsc75xx_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct usbnet *dev = netdev_priv(netdev);
         struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index eff67678c5a6..56f3894d701a 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -516,7 +516,8 @@ static void smsc95xx_status(struct usbnet *dev, struct urb *urb)
 }
 
 /* Enable or disable Tx & Rx checksum offload engines */
-static int smsc95xx_set_features(struct net_device *netdev, u32 features)
+static int smsc95xx_set_features(struct net_device *netdev,
+        netdev_features_t features)
 {
         struct usbnet *dev = netdev_priv(netdev);
         u32 read_buf;
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index ef883e97cee0..b576812bdc59 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -27,8 +27,8 @@
 
 struct veth_net_stats {
         u64                     rx_packets;
-        u64                     tx_packets;
         u64                     rx_bytes;
+        u64                     tx_packets;
         u64                     tx_bytes;
         u64                     rx_dropped;
         struct u64_stats_sync   syncp;
@@ -66,9 +66,9 @@ static int veth_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 
 static void veth_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 {
-        strcpy(info->driver, DRV_NAME);
-        strcpy(info->version, DRV_VERSION);
-        strcpy(info->fw_version, "N/A");
+        strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
+        strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
 }
 
 static void veth_get_strings(struct net_device *dev, u32 stringset, u8 *buf)
@@ -271,7 +271,7 @@ static void veth_setup(struct net_device *dev)
         dev->features |= NETIF_F_LLTX;
         dev->destructor = veth_dev_free;
 
-        dev->hw_features = NETIF_F_NO_CSUM | NETIF_F_SG | NETIF_F_RXCSUM;
+        dev->hw_features = NETIF_F_HW_CSUM | NETIF_F_SG | NETIF_F_RXCSUM;
 }
 
 /*
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 6ee8410443c4..4dc9d842a7a3 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -39,6 +39,7 @@ module_param(gso, bool, 0444);
 #define GOOD_COPY_LEN   128
 
 #define VIRTNET_SEND_COMMAND_SG_MAX    2
+#define VIRTNET_DRIVER_VERSION "1.0.0"
 
 struct virtnet_stats {
         struct u64_stats_sync syncp;
@@ -889,7 +890,21 @@ static void virtnet_get_ringparam(struct net_device *dev,
 
 }
 
+
+static void virtnet_get_drvinfo(struct net_device *dev,
+                                struct ethtool_drvinfo *info)
+{
+        struct virtnet_info *vi = netdev_priv(dev);
+        struct virtio_device *vdev = vi->vdev;
+
+        strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
+        strlcpy(info->version, VIRTNET_DRIVER_VERSION, sizeof(info->version));
+        strlcpy(info->bus_info, virtio_bus_name(vdev), sizeof(info->bus_info));
+
+}
+
 static const struct ethtool_ops virtnet_ethtool_ops = {
+        .get_drvinfo = virtnet_get_drvinfo,
         .get_link = ethtool_op_get_link,
         .get_ringparam = virtnet_get_ringparam,
 };
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index e662cbc8bfbd..77f723415c9c 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -262,11 +262,11 @@ vmxnet3_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
         }
 }
 
-int vmxnet3_set_features(struct net_device *netdev, u32 features)
+int vmxnet3_set_features(struct net_device *netdev, netdev_features_t features)
 {
         struct vmxnet3_adapter *adapter = netdev_priv(netdev);
         unsigned long flags;
-        u32 changed = features ^ netdev->features;
+        netdev_features_t changed = features ^ netdev->features;
 
         if (changed & (NETIF_F_RXCSUM | NETIF_F_LRO | NETIF_F_HW_VLAN_RX)) {
                 if (features & NETIF_F_RXCSUM)
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index b18eac1dccaa..ed54797db191 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -401,7 +401,7 @@ void
 vmxnet3_rq_destroy_all(struct vmxnet3_adapter *adapter);
 
 int
-vmxnet3_set_features(struct net_device *netdev, u32 features);
+vmxnet3_set_features(struct net_device *netdev, netdev_features_t features);
 
 int
 vmxnet3_create_queues(struct vmxnet3_adapter *adapter,
diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile
index 0a304b060b6c..c1c0678b1fb6 100644
--- a/drivers/net/wireless/Makefile
+++ b/drivers/net/wireless/Makefile
@@ -58,6 +58,6 @@ obj-$(CONFIG_WL12XX_PLATFORM_DATA)	+= wl12xx/
 obj-$(CONFIG_IWM)       += iwmc3200wifi/
 
 obj-$(CONFIG_MWIFIEX)   += mwifiex/
-obj-$(CONFIG_BRCMFMAC) += brcm80211/
-obj-$(CONFIG_BRCMUMAC) += brcm80211/
-obj-$(CONFIG_BRCMSMAC) += brcm80211/
+
+obj-$(CONFIG_BRCMFMAC)  += brcm80211/
+obj-$(CONFIG_BRCMSMAC)  += brcm80211/
diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
index 0f9ee46cfc97..4596c33a7a69 100644
--- a/drivers/net/wireless/ath/ath.h
+++ b/drivers/net/wireless/ath/ath.h
@@ -239,6 +239,7 @@ enum ATH_DEBUG {
         ATH_DBG_BTCOEX          = 0x00002000,
         ATH_DBG_WMI             = 0x00004000,
         ATH_DBG_BSTUCK          = 0x00008000,
+        ATH_DBG_MCI             = 0x00010000,
         ATH_DBG_ANY             = 0xffffffff
 };
 
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index f517eb8f7b44..5ac2bc2ebee6 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -1734,7 +1734,8 @@ static int ath6kl_mgmt_tx(struct wiphy *wiphy, struct net_device *dev,
                           struct ieee80211_channel *chan, bool offchan,
                           enum nl80211_channel_type channel_type,
                           bool channel_type_valid, unsigned int wait,
-                          const u8 *buf, size_t len, bool no_cck, u64 *cookie)
+                          const u8 *buf, size_t len, bool no_cck,
+                          bool dont_wait_for_ack, u64 *cookie)
 {
         struct ath6kl *ar = ath6kl_priv(dev);
         u32 id;
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index c1d2366704b5..81e0031012ca 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1548,7 +1548,8 @@ static int ath6kl_init(struct net_device *dev)
         ar->conf_flags = ATH6KL_CONF_IGNORE_ERP_BARKER |
                          ATH6KL_CONF_ENABLE_11N | ATH6KL_CONF_ENABLE_TX_BURST;
 
-        ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
+        ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM |
+                                  WIPHY_FLAG_HAVE_AP_SME;
 
         status = ath6kl_target_config_wlan_params(ar);
         if (!status)
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index d9c08c619a3a..7b4c074e12fa 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -25,6 +25,7 @@ config ATH9K
 
 config ATH9K_PCI
         bool "Atheros ath9k PCI/PCIe bus support"
+        default y
         depends on ATH9K && PCI
         ---help---
           This option enables the PCI bus support in ath9k.
diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
index 36ed3c46fec6..49d3f25f509d 100644
--- a/drivers/net/wireless/ath/ath9k/Makefile
+++ b/drivers/net/wireless/ath/ath9k/Makefile
@@ -4,6 +4,7 @@ ath9k-y +=	beacon.o \
                 main.o \
                 recv.o \
                 xmit.o \
+                mci.o \
 
 ath9k-$(CONFIG_ATH9K_RATE_CONTROL) += rc.o
 ath9k-$(CONFIG_ATH9K_PCI) += pci.o
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 3b262ba6b172..a93bd63ad23b 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -121,10 +121,8 @@ static const struct ar9300_eeprom ar9300_default = {
                  * if the register is per chain
                  */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {1, 1, 1},/* 3 chain */
-                .db_stage2 = {1, 1, 1}, /* 3 chain  */
-                .db_stage3 = {0, 0, 0},
-                .db_stage4 = {0, 0, 0},
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -144,7 +142,7 @@ static const struct ar9300_eeprom ar9300_default = {
          },
         .base_ext1 = {
                 .ant_div_control = 0,
-                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
+                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
         },
         .calFreqPier2G = {
                 FREQ2FBIN(2412, 1),
@@ -323,10 +321,8 @@ static const struct ar9300_eeprom ar9300_default = {
                 .spurChans = {0, 0, 0, 0, 0},
                 /* noiseFloorThreshCh Check if the register is per chain */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {3, 3, 3}, /* 3 chain */
-                .db_stage2 = {3, 3, 3}, /* 3 chain */
-                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
-                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -698,10 +694,8 @@ static const struct ar9300_eeprom ar9300_x113 = {
                  * if the register is per chain
                  */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {1, 1, 1},/* 3 chain */
-                .db_stage2 = {1, 1, 1}, /* 3 chain  */
-                .db_stage3 = {0, 0, 0},
-                .db_stage4 = {0, 0, 0},
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -721,7 +715,7 @@ static const struct ar9300_eeprom ar9300_x113 = {
          },
          .base_ext1 = {
                 .ant_div_control = 0,
-                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
+                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
          },
         .calFreqPier2G = {
                 FREQ2FBIN(2412, 1),
@@ -900,10 +894,8 @@ static const struct ar9300_eeprom ar9300_x113 = {
                 .spurChans = {FREQ2FBIN(5500, 0), 0, 0, 0, 0},
                 /* noiseFloorThreshCh Check if the register is per chain */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {3, 3, 3}, /* 3 chain */
-                .db_stage2 = {3, 3, 3}, /* 3 chain */
-                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
-                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0xf,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -1276,10 +1268,8 @@ static const struct ar9300_eeprom ar9300_h112 = {
                  * if the register is per chain
                  */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {1, 1, 1},/* 3 chain */
-                .db_stage2 = {1, 1, 1}, /* 3 chain  */
-                .db_stage3 = {0, 0, 0},
-                .db_stage4 = {0, 0, 0},
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -1291,20 +1281,20 @@ static const struct ar9300_eeprom ar9300_h112 = {
                 .txEndToRxOn = 0x2,
                 .txFrameToXpaOn = 0xe,
                 .thresh62 = 28,
-                .papdRateMaskHt20 = LE32(0x80c080),
-                .papdRateMaskHt40 = LE32(0x80c080),
+                .papdRateMaskHt20 = LE32(0x0c80c080),
+                .papdRateMaskHt40 = LE32(0x0080c080),
                 .futureModal = {
                         0, 0, 0, 0, 0, 0, 0, 0,
                 },
         },
         .base_ext1 = {
                 .ant_div_control = 0,
-                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
+                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
         },
         .calFreqPier2G = {
                 FREQ2FBIN(2412, 1),
                 FREQ2FBIN(2437, 1),
-                FREQ2FBIN(2472, 1),
+                FREQ2FBIN(2462, 1),
         },
         /* ar9300_cal_data_per_freq_op_loop 2g */
         .calPierData2G = {
@@ -1314,7 +1304,7 @@ static const struct ar9300_eeprom ar9300_h112 = {
         },
         .calTarget_freqbin_Cck = {
                 FREQ2FBIN(2412, 1),
-                FREQ2FBIN(2484, 1),
+                FREQ2FBIN(2472, 1),
         },
         .calTarget_freqbin_2G = {
                 FREQ2FBIN(2412, 1),
@@ -1478,10 +1468,8 @@ static const struct ar9300_eeprom ar9300_h112 = {
                 .spurChans = {0, 0, 0, 0, 0},
                 /* noiseFloorThreshCh Check if the register is per chain */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {3, 3, 3}, /* 3 chain */
-                .db_stage2 = {3, 3, 3}, /* 3 chain */
-                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
-                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -1515,7 +1503,7 @@ static const struct ar9300_eeprom ar9300_h112 = {
                 FREQ2FBIN(5500, 0),
                 FREQ2FBIN(5600, 0),
                 FREQ2FBIN(5700, 0),
-                FREQ2FBIN(5825, 0)
+                FREQ2FBIN(5785, 0)
         },
         .calPierData5G = {
                 {
@@ -1854,10 +1842,8 @@ static const struct ar9300_eeprom ar9300_x112 = {
                  * if the register is per chain
                  */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {1, 1, 1},/* 3 chain */
-                .db_stage2 = {1, 1, 1}, /* 3 chain  */
-                .db_stage3 = {0, 0, 0},
-                .db_stage4 = {0, 0, 0},
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -1877,7 +1863,7 @@ static const struct ar9300_eeprom ar9300_x112 = {
         },
         .base_ext1 = {
                 .ant_div_control = 0,
-                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
+                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
         },
         .calFreqPier2G = {
                 FREQ2FBIN(2412, 1),
@@ -2056,10 +2042,8 @@ static const struct ar9300_eeprom ar9300_x112 = {
                 .spurChans = {0, 0, 0, 0, 0},
                 /* noiseFloorThreshch check if the register is per chain */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {3, 3, 3}, /* 3 chain */
-                .db_stage2 = {3, 3, 3}, /* 3 chain */
-                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
-                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -2431,10 +2415,8 @@ static const struct ar9300_eeprom ar9300_h116 = {
                  * if the register is per chain
                  */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {1, 1, 1},/* 3 chain */
-                .db_stage2 = {1, 1, 1}, /* 3 chain  */
-                .db_stage3 = {0, 0, 0},
-                .db_stage4 = {0, 0, 0},
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -2454,12 +2436,12 @@ static const struct ar9300_eeprom ar9300_h116 = {
          },
          .base_ext1 = {
                 .ant_div_control = 0,
-                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
+                .future = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
          },
         .calFreqPier2G = {
                 FREQ2FBIN(2412, 1),
                 FREQ2FBIN(2437, 1),
-                FREQ2FBIN(2472, 1),
+                FREQ2FBIN(2462, 1),
          },
         /* ar9300_cal_data_per_freq_op_loop 2g */
         .calPierData2G = {
@@ -2633,10 +2615,8 @@ static const struct ar9300_eeprom ar9300_h116 = {
                 .spurChans = {0, 0, 0, 0, 0},
                 /* noiseFloorThreshCh Check if the register is per chain */
                 .noiseFloorThreshCh = {-1, 0, 0},
-                .ob = {3, 3, 3}, /* 3 chain */
-                .db_stage2 = {3, 3, 3}, /* 3 chain */
-                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
-                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
+                .reserved = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+                .quick_drop = 0,
                 .xpaBiasLvl = 0,
                 .txFrameToDataStart = 0x0e,
                 .txFrameToPaOn = 0x0e,
@@ -2663,7 +2643,7 @@ static const struct ar9300_eeprom ar9300_h116 = {
                 .xatten1MarginHigh = {0, 0, 0}
          },
         .calFreqPier5G = {
-                FREQ2FBIN(5180, 0),
+                FREQ2FBIN(5160, 0),
                 FREQ2FBIN(5220, 0),
                 FREQ2FBIN(5320, 0),
                 FREQ2FBIN(5400, 0),
@@ -3023,6 +3003,8 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
                 return eep->modalHeader5G.antennaGain;
         case EEP_ANTENNA_GAIN_2G:
                 return eep->modalHeader2G.antennaGain;
+        case EEP_QUICK_DROP:
+                return pBase->miscConfiguration & BIT(1);
         default:
                 return 0;
         }
@@ -3428,25 +3410,14 @@ static u32 ar9003_dump_modal_eeprom(char *buf, u32 len, u32 size,
         PR_EEP("Chain0 NF Threshold", modal_hdr->noiseFloorThreshCh[0]);
         PR_EEP("Chain1 NF Threshold", modal_hdr->noiseFloorThreshCh[1]);
         PR_EEP("Chain2 NF Threshold", modal_hdr->noiseFloorThreshCh[2]);
+        PR_EEP("Quick Drop", modal_hdr->quick_drop);
+        PR_EEP("txEndToXpaOff", modal_hdr->txEndToXpaOff);
         PR_EEP("xPA Bias Level", modal_hdr->xpaBiasLvl);
         PR_EEP("txFrameToDataStart", modal_hdr->txFrameToDataStart);
         PR_EEP("txFrameToPaOn", modal_hdr->txFrameToPaOn);
         PR_EEP("txFrameToXpaOn", modal_hdr->txFrameToXpaOn);
         PR_EEP("txClip", modal_hdr->txClip);
         PR_EEP("ADC Desired size", modal_hdr->adcDesiredSize);
-        PR_EEP("Chain0 ob", modal_hdr->ob[0]);
-        PR_EEP("Chain1 ob", modal_hdr->ob[1]);
-        PR_EEP("Chain2 ob", modal_hdr->ob[2]);
-
-        PR_EEP("Chain0 db_stage2", modal_hdr->db_stage2[0]);
-        PR_EEP("Chain1 db_stage2", modal_hdr->db_stage2[1]);
-        PR_EEP("Chain2 db_stage2", modal_hdr->db_stage2[2]);
-        PR_EEP("Chain0 db_stage3", modal_hdr->db_stage3[0]);
-        PR_EEP("Chain1 db_stage3", modal_hdr->db_stage3[1]);
-        PR_EEP("Chain2 db_stage3", modal_hdr->db_stage3[2]);
-        PR_EEP("Chain0 db_stage4", modal_hdr->db_stage4[0]);
-        PR_EEP("Chain1 db_stage4", modal_hdr->db_stage4[1]);
-        PR_EEP("Chain2 db_stage4", modal_hdr->db_stage4[2]);
 
         return len;
 }
@@ -3503,6 +3474,7 @@ static u32 ath9k_hw_ar9003_dump_eeprom(struct ath_hw *ah, bool dump_base_hdr,
         PR_EEP("Internal regulator", !!(pBase->featureEnable & BIT(4)));
         PR_EEP("Enable Paprd", !!(pBase->featureEnable & BIT(5)));
         PR_EEP("Driver Strength", !!(pBase->miscConfiguration & BIT(0)));
+        PR_EEP("Quick Drop", !!(pBase->miscConfiguration & BIT(1)));
         PR_EEP("Chain mask Reduce", (pBase->miscConfiguration >> 0x3) & 0x1);
         PR_EEP("Write enable Gpio", pBase->eepromWriteEnableGpio);
         PR_EEP("WLAN Disable Gpio", pBase->wlanDisableGpio);
@@ -3965,6 +3937,40 @@ static void ar9003_hw_apply_tuning_caps(struct ath_hw *ah)
         }
 }
 
+static void ar9003_hw_quick_drop_apply(struct ath_hw *ah, u16 freq)
+{
+        struct ar9300_eeprom *eep = &ah->eeprom.ar9300_eep;
+        int quick_drop = ath9k_hw_ar9300_get_eeprom(ah, EEP_QUICK_DROP);
+        s32 t[3], f[3] = {5180, 5500, 5785};
+
+        if (!quick_drop)
+                return;
+
+        if (freq < 4000)
+                quick_drop = eep->modalHeader2G.quick_drop;
+        else {
+                t[0] = eep->base_ext1.quick_drop_low;
+                t[1] = eep->modalHeader5G.quick_drop;
+                t[2] = eep->base_ext1.quick_drop_high;
+                quick_drop = ar9003_hw_power_interpolate(freq, f, t, 3);
+        }
+        REG_RMW_FIELD(ah, AR_PHY_AGC, AR_PHY_AGC_QUICK_DROP, quick_drop);
+}
+
+static void ar9003_hw_txend_to_xpa_off_apply(struct ath_hw *ah, u16 freq)
+{
+        struct ar9300_eeprom *eep = &ah->eeprom.ar9300_eep;
+        u32 value;
+
+        value = (freq < 4000) ? eep->modalHeader2G.txEndToXpaOff :
+                                eep->modalHeader5G.txEndToXpaOff;
+
+        REG_RMW_FIELD(ah, AR_PHY_XPA_TIMING_CTL,
+                      AR_PHY_XPA_TIMING_CTL_TX_END_XPAB_OFF, value);
+        REG_RMW_FIELD(ah, AR_PHY_XPA_TIMING_CTL,
+                      AR_PHY_XPA_TIMING_CTL_TX_END_XPAA_OFF, value);
+}
+
 static void ath9k_hw_ar9300_set_board_values(struct ath_hw *ah,
                                              struct ath9k_channel *chan)
 {
@@ -3972,10 +3978,12 @@ static void ath9k_hw_ar9300_set_board_values(struct ath_hw *ah,
         ar9003_hw_ant_ctrl_apply(ah, IS_CHAN_2GHZ(chan));
         ar9003_hw_drive_strength_apply(ah);
         ar9003_hw_atten_apply(ah, chan);
+        ar9003_hw_quick_drop_apply(ah, chan->channel);
         if (!AR_SREV_9330(ah) && !AR_SREV_9340(ah))
                 ar9003_hw_internal_regulator_apply(ah);
         if (AR_SREV_9485(ah) || AR_SREV_9330(ah) || AR_SREV_9340(ah))
                 ar9003_hw_apply_tuning_caps(ah);
+        ar9003_hw_txend_to_xpa_off_apply(ah, chan->channel);
 }
 
 static void ath9k_hw_ar9300_set_addac(struct ath_hw *ah,
@@ -5051,6 +5059,8 @@ static void ath9k_hw_ar9300_set_txpower(struct ath_hw *ah,
                         regulatory->max_power_level = targetPowerValT2[i];
         }
 
+        ath9k_hw_update_regulatory_maxpower(ah);
+
         if (test)
                 return;
 
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.h b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.h
index 6335a867527e..bb223fe82816 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.h
@@ -216,10 +216,8 @@ struct ar9300_modal_eep_header {
         u8 spurChans[AR_EEPROM_MODAL_SPURS];
         /* 3  Check if the register is per chain */
         int8_t noiseFloorThreshCh[AR9300_MAX_CHAINS];
-        u8 ob[AR9300_MAX_CHAINS];
-        u8 db_stage2[AR9300_MAX_CHAINS];
-        u8 db_stage3[AR9300_MAX_CHAINS];
-        u8 db_stage4[AR9300_MAX_CHAINS];
+        u8 reserved[11];
+        int8_t quick_drop;
         u8 xpaBiasLvl;
         u8 txFrameToDataStart;
         u8 txFrameToPaOn;
@@ -269,7 +267,9 @@ struct cal_ctl_data_5g {
 
 struct ar9300_BaseExtension_1 {
         u8 ant_div_control;
-        u8 future[13];
+        u8 future[11];
+        int8_t quick_drop_low;
+        int8_t quick_drop_high;
 } __packed;
 
 struct ar9300_BaseExtension_2 {
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index 2330e7ede199..e41d26939ab8 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -199,12 +199,14 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
                         synth_freq = chan->channel;
                 }
         } else {
-                range = 10;
+                range = AR_SREV_9462(ah) ? 5 : 10;
                 max_spur_cnts = 4;
                 synth_freq = chan->channel;
         }
 
         for (i = 0; i < max_spur_cnts; i++) {
+                if (AR_SREV_9462(ah) && (i == 0 || i == 3))
+                        continue;
                 negative = 0;
                 if (AR_SREV_9485(ah) || AR_SREV_9340(ah) || AR_SREV_9330(ah))
                         cur_bb_spur = FBIN2FREQ(spur_fbin_ptr[i],
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
index 4114fe752c6b..497d7461838a 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
@@ -389,6 +389,8 @@
 #define AR_PHY_DAG_CTRLCCK_RSSI_THR_S   10
 
 #define AR_PHY_RIFS_INIT_DELAY         0x3ff0000
+#define AR_PHY_AGC_QUICK_DROP       0x03c00000
+#define AR_PHY_AGC_QUICK_DROP_S     22
 #define AR_PHY_AGC_COARSE_LOW       0x00007F80
 #define AR_PHY_AGC_COARSE_LOW_S     7
 #define AR_PHY_AGC_COARSE_HIGH      0x003F8000
diff --git a/drivers/net/wireless/ath/ath9k/ar9462_2p0_initvals.h b/drivers/net/wireless/ath/ath9k/ar9462_2p0_initvals.h
index 9c51b395b4ff..259a6f312afb 100644
--- a/drivers/net/wireless/ath/ath9k/ar9462_2p0_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9462_2p0_initvals.h
@@ -43,16 +43,16 @@ static const u32 ar9462_2p0_baseband_postamble[][5] = {
         /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
         {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8011, 0xd00a8011},
         {0x00009820, 0x206a022e, 0x206a022e, 0x206a012e, 0x206a012e},
-        {0x00009824, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0},
-        {0x00009828, 0x06903081, 0x06903081, 0x06903881, 0x06903881},
+        {0x00009824, 0x5ac640de, 0x5ac640d0, 0x5ac640d0, 0x5ac640de},
+        {0x00009828, 0x0796be89, 0x0696b081, 0x0696b881, 0x0796be89},
         {0x0000982c, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4},
         {0x00009830, 0x0000059c, 0x0000059c, 0x0000119c, 0x0000119c},
         {0x00009c00, 0x000000c4, 0x000000c4, 0x000000c4, 0x000000c4},
         {0x00009e00, 0x0372111a, 0x0372111a, 0x037216a0, 0x037216a0},
         {0x00009e04, 0x001c2020, 0x001c2020, 0x001c2020, 0x001c2020},
         {0x00009e0c, 0x6c4000e2, 0x6d4000e2, 0x6d4000e2, 0x6c4000e2},
-        {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec84d2e, 0x7ec84d2e},
-        {0x00009e14, 0x37b95d5e, 0x37b9605e, 0x3039605e, 0x33795d5e},
+        {0x00009e10, 0x92c88d2e, 0x7ec88d2e, 0x7ec84d2e, 0x92c84d2e},
+        {0x00009e14, 0x37b95d5e, 0x37b9605e, 0x3379605e, 0x33795d5e},
         {0x00009e18, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
         {0x00009e1c, 0x0001cf9c, 0x0001cf9c, 0x00021f9c, 0x00021f9c},
         {0x00009e20, 0x000003b5, 0x000003b5, 0x000003ce, 0x000003ce},
@@ -688,8 +688,8 @@ static const u32 ar9462_2p0_mac_postamble_emulation[][5] = {
 static const u32 ar9462_2p0_radio_postamble_sys3ant[][5] = {
         /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
         {0x000160ac, 0xa4646c08, 0xa4646c08, 0x24645808, 0x24645808},
-        {0x00016140, 0x10804008, 0x10804008, 0x90804008, 0x90804008},
-        {0x00016540, 0x10804008, 0x10804008, 0x90804008, 0x90804008},
+        {0x00016140, 0x10804008, 0x10804008, 0x50804008, 0x50804008},
+        {0x00016540, 0x10804008, 0x10804008, 0x50804008, 0x50804008},
 };
 
 static const u32 ar9462_2p0_baseband_postamble_emulation[][5] = {
@@ -717,8 +717,8 @@ static const u32 ar9462_2p0_baseband_postamble_emulation[][5] = {
 static const u32 ar9462_2p0_radio_postamble_sys2ant[][5] = {
         /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
         {0x000160ac, 0xa4646c08, 0xa4646c08, 0x24645808, 0x24645808},
-        {0x00016140, 0x10804008, 0x10804008, 0x90804008, 0x90804008},
-        {0x00016540, 0x10804008, 0x10804008, 0x90804008, 0x90804008},
+        {0x00016140, 0x10804008, 0x10804008, 0x50804008, 0x50804008},
+        {0x00016540, 0x10804008, 0x10804008, 0x50804008, 0x50804008},
 };
 
 static const u32 ar9462_common_wo_xlna_rx_gain_table_2p0[][2] = {
@@ -1059,7 +1059,7 @@ static const u32 ar9462_modes_low_ob_db_tx_gain_table_2p0[][5] = {
 
 static const u32 ar9462_2p0_soc_postamble[][5] = {
         /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
-        {0x00007010, 0x00002233, 0x00002233, 0x00002233, 0x00002233},
+        {0x00007010, 0x00000033, 0x00000033, 0x00000033, 0x00000033},
 };
 
 static const u32 ar9462_2p0_baseband_core[][2] = {
@@ -1257,8 +1257,8 @@ static const u32 ar9462_modes_high_ob_db_tx_gain_table_2p0[][5] = {
         {0x0000a540, 0x48025e6c, 0x48025e6c, 0x38001660, 0x38001660},
         {0x0000a544, 0x4e025e8e, 0x4e025e8e, 0x3b001861, 0x3b001861},
         {0x0000a548, 0x53025eb2, 0x53025eb2, 0x3e001a81, 0x3e001a81},
-        {0x0000a54c, 0x59025eb2, 0x59025eb2, 0x42001a83, 0x42001a83},
-        {0x0000a550, 0x5f025ef6, 0x5f025ef6, 0x44001c84, 0x44001c84},
+        {0x0000a54c, 0x59025eb6, 0x59025eb6, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x5d025ef6, 0x5d025ef6, 0x44001c84, 0x44001c84},
         {0x0000a554, 0x62025f56, 0x62025f56, 0x48001ce3, 0x48001ce3},
         {0x0000a558, 0x66027f56, 0x66027f56, 0x4c001ce5, 0x4c001ce5},
         {0x0000a55c, 0x6a029f56, 0x6a029f56, 0x50001ce9, 0x50001ce9},
@@ -1850,8 +1850,8 @@ static const u32 ar9462_modes_green_ob_db_tx_gain_table_2p0[][5] = {
         {0x0000a540, 0x48025e6c, 0x48025e6c, 0x38001660, 0x38001660},
         {0x0000a544, 0x4e025e8e, 0x4e025e8e, 0x3b001861, 0x3b001861},
         {0x0000a548, 0x53025eb2, 0x53025eb2, 0x3e001a81, 0x3e001a81},
-        {0x0000a54c, 0x59025eb2, 0x59025eb2, 0x42001a83, 0x42001a83},
-        {0x0000a550, 0x5f025ef6, 0x5f025ef6, 0x44001c84, 0x44001c84},
+        {0x0000a54c, 0x59025eb6, 0x59025eb6, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x5d025ef6, 0x5d025ef6, 0x44001c84, 0x44001c84},
         {0x0000a554, 0x62025f56, 0x62025f56, 0x48001ce3, 0x48001ce3},
         {0x0000a558, 0x66027f56, 0x66027f56, 0x4c001ce5, 0x4c001ce5},
         {0x0000a55c, 0x6a029f56, 0x6a029f56, 0x50001ce9, 0x50001ce9},
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 1c269f50822b..93b45b4b3033 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -25,6 +25,7 @@
 
 #include "debug.h"
 #include "common.h"
+#include "mci.h"
 
 /*
  * Header for the ath9k.ko driver core *only* -- hw code nor any other driver
@@ -252,6 +253,7 @@ struct ath_node {
 #ifdef CONFIG_ATH9K_DEBUGFS
         struct list_head list; /* for sc->nodes */
         struct ieee80211_sta *sta; /* station struct we're part of */
+        struct ieee80211_vif *vif; /* interface with which we're associated */
 #endif
         struct ath_atx_tid tid[WME_NUM_TID];
         struct ath_atx_ac ac[WME_NUM_AC];
@@ -443,7 +445,9 @@ struct ath_btcoex {
         u32 btcoex_no_stomp; /* in usec */
         u32 btcoex_period; /* in usec */
         u32 btscan_no_stomp; /* in usec */
+        u32 duty_cycle;
         struct ath_gen_timer *no_stomp_timer; /* Timer for no BT stomping */
+        struct ath_mci_profile mci;
 };
 
 int ath_init_btcoex_timer(struct ath_softc *sc);
diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 2741203e803f..6fb719d85b37 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -709,24 +709,29 @@ static ssize_t read_file_stations(struct file *file, char __user *user_buf,
 
         len += snprintf(buf + len, size - len,
                         "Stations:\n"
-                        " tid: addr sched paused buf_q-empty an ac\n"
+                        " tid: addr sched paused buf_q-empty an ac baw\n"
                         " ac: addr sched tid_q-empty txq\n");
 
         spin_lock(&sc->nodes_lock);
         list_for_each_entry(an, &sc->nodes, list) {
+                unsigned short ma = an->maxampdu;
+                if (ma == 0)
+                        ma = 65535; /* see ath_lookup_rate */
                 len += snprintf(buf + len, size - len,
-                                "%pM\n", an->sta->addr);
+                                "iface: %pM  sta: %pM max-ampdu: %hu mpdu-density: %uus\n",
+                                an->vif->addr, an->sta->addr, ma,
+                                (unsigned int)(an->mpdudensity));
                 if (len >= size)
                         goto done;
 
                 for (q = 0; q < WME_NUM_TID; q++) {
                         struct ath_atx_tid *tid = &(an->tid[q]);
                         len += snprintf(buf + len, size - len,
-                                        " tid: %p %s %s %i %p %p\n",
+                                        " tid: %p %s %s %i %p %p %hu\n",
                                         tid, tid->sched ? "sched" : "idle",
                                         tid->paused ? "paused" : "running",
                                         skb_queue_empty(&tid->buf_q),
-                                        tid->an, tid->ac);
+                                        tid->an, tid->ac, tid->baw_size);
                         if (len >= size)
                                 goto done;
                 }
diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h
index 49abd34be741..5ff7ab965120 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.h
+++ b/drivers/net/wireless/ath/ath9k/eeprom.h
@@ -249,7 +249,8 @@ enum eeprom_param {
         EEP_ANT_DIV_CTL1,
         EEP_CHAIN_MASK_REDUCE,
         EEP_ANTENNA_GAIN_2G,
-        EEP_ANTENNA_GAIN_5G
+        EEP_ANTENNA_GAIN_5G,
+        EEP_QUICK_DROP
 };
 
 enum ar5416_rates {
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
index 655576c8fdab..2c279dcaf4ba 100644
--- a/drivers/net/wireless/ath/ath9k/gpio.c
+++ b/drivers/net/wireless/ath/ath9k/gpio.c
@@ -189,8 +189,8 @@ static void ath_btcoex_period_timer(unsigned long data)
         bool is_btscan;
 
         ath9k_ps_wakeup(sc);
-        ath_detect_bt_priority(sc);
-
+        if (!(ah->caps.hw_caps & ATH9K_HW_CAP_MCI))
+                ath_detect_bt_priority(sc);
         is_btscan = sc->sc_flags & SC_OP_BT_SCAN;
 
         spin_lock_bh(&btcoex->btcoex_lock);
@@ -212,8 +212,9 @@ static void ath_btcoex_period_timer(unsigned long data)
         }
 
         ath9k_ps_restore(sc);
+        timer_period = btcoex->btcoex_period / 1000;
         mod_timer(&btcoex->period_timer, jiffies +
-                                  msecs_to_jiffies(ATH_BTCOEX_DEF_BT_PERIOD));
+                                  msecs_to_jiffies(timer_period));
 }
 
 /*
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 2f91acccb7db..662ab7e9a0f0 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -2335,7 +2335,7 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
                         ah->enabled_cals |= TX_IQ_ON_AGC_CAL;
         }
         if (AR_SREV_9462(ah))
-                pCap->hw_caps |= ATH9K_HW_CAP_RTT;
+                pCap->hw_caps |= ATH9K_HW_CAP_RTT | ATH9K_HW_CAP_MCI;
 
         return 0;
 }
@@ -2583,7 +2583,7 @@ void ath9k_hw_set_txpowerlimit(struct ath_hw *ah, u32 limit, bool test)
         struct ath9k_channel *chan = ah->curchan;
         struct ieee80211_channel *channel = chan->chan;
 
-        reg->power_limit = min_t(int, limit, MAX_RATE_POWER);
+        reg->power_limit = min_t(u32, limit, MAX_RATE_POWER);
         if (test)
                 channel->max_power = MAX_RATE_POWER / 2;
 
diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
index f389b3c93cf3..33e8f2f9d425 100644
--- a/drivers/net/wireless/ath/ath9k/hw.h
+++ b/drivers/net/wireless/ath/ath9k/hw.h
@@ -203,6 +203,7 @@ enum ath9k_hw_caps {
         ATH9K_HW_CAP_5GHZ                       = BIT(14),
         ATH9K_HW_CAP_APM                        = BIT(15),
         ATH9K_HW_CAP_RTT                        = BIT(16),
+        ATH9K_HW_CAP_MCI                        = BIT(17),
 };
 
 struct ath9k_hw_capabilities {
@@ -419,6 +420,16 @@ enum ath9k_rx_qtype {
         ATH9K_RX_QUEUE_MAX,
 };
 
+enum ath_mci_gpm_coex_profile_type {
+        MCI_GPM_COEX_PROFILE_UNKNOWN,
+        MCI_GPM_COEX_PROFILE_RFCOMM,
+        MCI_GPM_COEX_PROFILE_A2DP,
+        MCI_GPM_COEX_PROFILE_HID,
+        MCI_GPM_COEX_PROFILE_BNEP,
+        MCI_GPM_COEX_PROFILE_VOICE,
+        MCI_GPM_COEX_PROFILE_MAX
+};
+
 struct ath9k_beacon_state {
         u32 bs_nexttbtt;
         u32 bs_nextdtim;
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index d4c909f8e474..e046de94836a 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -424,6 +424,8 @@ static int ath9k_init_btcoex(struct ath_softc *sc)
                 txq = sc->tx.txq_map[WME_AC_BE];
                 ath9k_hw_init_btcoex_hw(sc->sc_ah, txq->axq_qnum);
                 sc->btcoex.bt_stomp_type = ATH_BTCOEX_STOMP_LOW;
+                sc->btcoex.duty_cycle = ATH_BTCOEX_DEF_DUTY_CYCLE;
+                INIT_LIST_HEAD(&sc->btcoex.mci.info);
                 break;
         default:
                 WARN_ON(1);
@@ -695,6 +697,7 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
                 hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
 
         hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
+        hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS;
 
         hw->queues = 4;
         hw->max_rates = 4;
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 93fbe6f40898..e43c41cff25b 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -630,7 +630,8 @@ set_timer:
         }
 }
 
-static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta)
+static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta,
+                            struct ieee80211_vif *vif)
 {
         struct ath_node *an;
         an = (struct ath_node *)sta->drv_priv;
@@ -640,6 +641,7 @@ static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta)
         list_add(&an->list, &sc->nodes);
         spin_unlock(&sc->nodes_lock);
         an->sta = sta;
+        an->vif = vif;
 #endif
         if (sc->sc_flags & SC_OP_TXAGGR) {
                 ath_tx_node_init(sc, an);
@@ -1133,8 +1135,9 @@ static int ath9k_start(struct ieee80211_hw *hw)
 
         if ((ah->btcoex_hw.scheme != ATH_BTCOEX_CFG_NONE) &&
             !ah->btcoex_hw.enabled) {
-                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
-                                           AR_STOMP_LOW_WLAN_WGHT);
+                if (!(sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_MCI))
+                        ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
+                                                   AR_STOMP_LOW_WLAN_WGHT);
                 ath9k_hw_btcoex_enable(ah);
 
                 if (ah->btcoex_hw.scheme == ATH_BTCOEX_CFG_3WIRE)
@@ -1237,6 +1240,7 @@ static void ath9k_stop(struct ieee80211_hw *hw)
                 ath9k_hw_btcoex_disable(ah);
                 if (ah->btcoex_hw.scheme == ATH_BTCOEX_CFG_3WIRE)
                         ath9k_btcoex_timer_pause(sc);
+                ath_mci_flush_profile(&sc->btcoex.mci);
         }
 
         spin_lock_bh(&sc->sc_pcu_lock);
@@ -1798,7 +1802,7 @@ static int ath9k_sta_add(struct ieee80211_hw *hw,
         struct ath_node *an = (struct ath_node *) sta->drv_priv;
         struct ieee80211_key_conf ps_key = { };
 
-        ath_node_attach(sc, sta);
+        ath_node_attach(sc, sta, vif);
 
         if (vif->type != NL80211_IFTYPE_AP &&
             vif->type != NL80211_IFTYPE_AP_VLAN)
diff --git a/drivers/net/wireless/ath/ath9k/mci.c b/drivers/net/wireless/ath/ath9k/mci.c
new file mode 100644
index 000000000000..0fbb141bc302
--- /dev/null
+++ b/drivers/net/wireless/ath/ath9k/mci.c
@@ -0,0 +1,254 @@
+/*
+ * Copyright (c) 2010-2011 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include "ath9k.h"
+#include "mci.h"
+
+u8 ath_mci_duty_cycle[] = { 0, 50, 60, 70, 80, 85, 90, 95, 98 };
+
+static struct ath_mci_profile_info*
+ath_mci_find_profile(struct ath_mci_profile *mci,
+                     struct ath_mci_profile_info *info)
+{
+        struct ath_mci_profile_info *entry;
+
+        list_for_each_entry(entry, &mci->info, list) {
+                if (entry->conn_handle == info->conn_handle)
+                        break;
+        }
+        return entry;
+}
+
+static bool ath_mci_add_profile(struct ath_common *common,
+                                struct ath_mci_profile *mci,
+                                struct ath_mci_profile_info *info)
+{
+        struct ath_mci_profile_info *entry;
+
+        if ((mci->num_sco == ATH_MCI_MAX_SCO_PROFILE) &&
+            (info->type == MCI_GPM_COEX_PROFILE_VOICE)) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Too many SCO profile, failed to add new profile\n");
+                return false;
+        }
+
+        if (((NUM_PROF(mci) - mci->num_sco) == ATH_MCI_MAX_ACL_PROFILE) &&
+            (info->type != MCI_GPM_COEX_PROFILE_VOICE)) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Too many ACL profile, failed to add new profile\n");
+                return false;
+        }
+
+        entry = ath_mci_find_profile(mci, info);
+
+        if (entry)
+                memcpy(entry, info, 10);
+        else {
+                entry = kzalloc(sizeof(*entry), GFP_KERNEL);
+                if (!entry)
+                        return false;
+
+                memcpy(entry, info, 10);
+                INC_PROF(mci, info);
+                list_add_tail(&info->list, &mci->info);
+        }
+        return true;
+}
+
+static void ath_mci_del_profile(struct ath_common *common,
+                                struct ath_mci_profile *mci,
+                                struct ath_mci_profile_info *info)
+{
+        struct ath_mci_profile_info *entry;
+
+        entry = ath_mci_find_profile(mci, info);
+
+        if (!entry) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Profile to be deleted not found\n");
+                return;
+        }
+        DEC_PROF(mci, entry);
+        list_del(&entry->list);
+        kfree(entry);
+}
+
+void ath_mci_flush_profile(struct ath_mci_profile *mci)
+{
+        struct ath_mci_profile_info *info, *tinfo;
+
+        list_for_each_entry_safe(info, tinfo, &mci->info, list) {
+                list_del(&info->list);
+                DEC_PROF(mci, info);
+                kfree(info);
+        }
+        mci->aggr_limit = 0;
+}
+
+static void ath_mci_adjust_aggr_limit(struct ath_btcoex *btcoex)
+{
+        struct ath_mci_profile *mci = &btcoex->mci;
+        u32 wlan_airtime = btcoex->btcoex_period *
+                                (100 - btcoex->duty_cycle) / 100;
+
+        /*
+         * Scale: wlan_airtime is in ms, aggr_limit is in 0.25 ms.
+         * When wlan_airtime is less than 4ms, aggregation limit has to be
+         * adjusted half of wlan_airtime to ensure that the aggregation can fit
+         * without collision with BT traffic.
+         */
+        if ((wlan_airtime <= 4) &&
+            (!mci->aggr_limit || (mci->aggr_limit > (2 * wlan_airtime))))
+                mci->aggr_limit = 2 * wlan_airtime;
+}
+
+static void ath_mci_update_scheme(struct ath_softc *sc)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_btcoex *btcoex = &sc->btcoex;
+        struct ath_mci_profile *mci = &btcoex->mci;
+        struct ath_mci_profile_info *info;
+        u32 num_profile = NUM_PROF(mci);
+
+        if (num_profile == 1) {
+                info = list_first_entry(&mci->info,
+                                        struct ath_mci_profile_info,
+                                        list);
+                if (mci->num_sco && info->T == 12) {
+                        mci->aggr_limit = 8;
+                        ath_dbg(common, ATH_DBG_MCI,
+                                "Single SCO, aggregation limit 2 ms\n");
+                } else if ((info->type == MCI_GPM_COEX_PROFILE_BNEP) &&
+                           !info->master) {
+                        btcoex->btcoex_period = 60;
+                        ath_dbg(common, ATH_DBG_MCI,
+                                "Single slave PAN/FTP, bt period 60 ms\n");
+                } else if ((info->type == MCI_GPM_COEX_PROFILE_HID) &&
+                         (info->T > 0 && info->T < 50) &&
+                         (info->A > 1 || info->W > 1)) {
+                        btcoex->duty_cycle = 30;
+                        mci->aggr_limit = 8;
+                        ath_dbg(common, ATH_DBG_MCI,
+                                "Multiple attempt/timeout single HID "
+                                "aggregation limit 2 ms dutycycle 30%%\n");
+                }
+        } else if ((num_profile == 2) && (mci->num_hid == 2)) {
+                btcoex->duty_cycle = 30;
+                mci->aggr_limit = 8;
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Two HIDs aggregation limit 2 ms dutycycle 30%%\n");
+        } else if (num_profile > 3) {
+                mci->aggr_limit = 6;
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Three or more profiles aggregation limit 1.5 ms\n");
+        }
+
+        if (IS_CHAN_2GHZ(sc->sc_ah->curchan)) {
+                if (IS_CHAN_HT(sc->sc_ah->curchan))
+                        ath_mci_adjust_aggr_limit(btcoex);
+                else
+                        btcoex->btcoex_period >>= 1;
+        }
+
+        ath9k_hw_btcoex_disable(sc->sc_ah);
+        ath9k_btcoex_timer_pause(sc);
+
+        if (IS_CHAN_5GHZ(sc->sc_ah->curchan))
+                return;
+
+        btcoex->duty_cycle += (mci->num_bdr ? ATH_MCI_MAX_DUTY_CYCLE : 0);
+        if (btcoex->duty_cycle > ATH_MCI_MAX_DUTY_CYCLE)
+                btcoex->duty_cycle = ATH_MCI_MAX_DUTY_CYCLE;
+
+        btcoex->btcoex_period *= 1000;
+        btcoex->btcoex_no_stomp =  btcoex->btcoex_period *
+                                        (100 - btcoex->duty_cycle) / 100;
+
+        ath9k_hw_btcoex_enable(sc->sc_ah);
+        ath9k_btcoex_timer_resume(sc);
+}
+
+void ath_mci_process_profile(struct ath_softc *sc,
+                             struct ath_mci_profile_info *info)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_btcoex *btcoex = &sc->btcoex;
+        struct ath_mci_profile *mci = &btcoex->mci;
+
+        if (info->start) {
+                if (!ath_mci_add_profile(common, mci, info))
+                        return;
+        } else
+                ath_mci_del_profile(common, mci, info);
+
+        btcoex->btcoex_period = ATH_MCI_DEF_BT_PERIOD;
+        mci->aggr_limit = mci->num_sco ? 6 : 0;
+        if (NUM_PROF(mci)) {
+                btcoex->bt_stomp_type = ATH_BTCOEX_STOMP_LOW;
+                btcoex->duty_cycle = ath_mci_duty_cycle[NUM_PROF(mci)];
+        } else {
+                btcoex->bt_stomp_type = mci->num_mgmt ? ATH_BTCOEX_STOMP_ALL :
+                                                        ATH_BTCOEX_STOMP_LOW;
+                btcoex->duty_cycle = ATH_BTCOEX_DEF_DUTY_CYCLE;
+        }
+
+        ath_mci_update_scheme(sc);
+}
+
+void ath_mci_process_status(struct ath_softc *sc,
+                            struct ath_mci_profile_status *status)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_btcoex *btcoex = &sc->btcoex;
+        struct ath_mci_profile *mci = &btcoex->mci;
+        struct ath_mci_profile_info info;
+        int i = 0, old_num_mgmt = mci->num_mgmt;
+
+        /* Link status type are not handled */
+        if (status->is_link) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Skip link type status update\n");
+                return;
+        }
+
+        memset(&info, 0, sizeof(struct ath_mci_profile_info));
+
+        info.conn_handle = status->conn_handle;
+        if (ath_mci_find_profile(mci, &info)) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Skip non link state update for existing profile %d\n",
+                        status->conn_handle);
+                return;
+        }
+        if (status->conn_handle >= ATH_MCI_MAX_PROFILE) {
+                ath_dbg(common, ATH_DBG_MCI,
+                        "Ignore too many non-link update\n");
+                return;
+        }
+        if (status->is_critical)
+                __set_bit(status->conn_handle, mci->status);
+        else
+                __clear_bit(status->conn_handle, mci->status);
+
+        mci->num_mgmt = 0;
+        do {
+                if (test_bit(i, mci->status))
+                        mci->num_mgmt++;
+        } while (++i < ATH_MCI_MAX_PROFILE);
+
+        if (old_num_mgmt != mci->num_mgmt)
+                ath_mci_update_scheme(sc);
+}
diff --git a/drivers/net/wireless/ath/ath9k/mci.h b/drivers/net/wireless/ath/ath9k/mci.h
new file mode 100644
index 000000000000..9590c61822d1
--- /dev/null
+++ b/drivers/net/wireless/ath/ath9k/mci.h
@@ -0,0 +1,118 @@
+/*
+ * Copyright (c) 2010-2011 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#ifndef MCI_H
+#define MCI_H
+
+#define ATH_MCI_DEF_BT_PERIOD           40
+#define ATH_MCI_BDR_DUTY_CYCLE          20
+#define ATH_MCI_MAX_DUTY_CYCLE          90
+
+#define ATH_MCI_DEF_AGGR_LIMIT          6 /* in 0.24 ms */
+#define ATH_MCI_MAX_ACL_PROFILE         7
+#define ATH_MCI_MAX_SCO_PROFILE         1
+#define ATH_MCI_MAX_PROFILE             (ATH_MCI_MAX_ACL_PROFILE +\
+                                         ATH_MCI_MAX_SCO_PROFILE)
+
+#define INC_PROF(_mci, _info) do {               \
+                switch (_info->type) {           \
+                case MCI_GPM_COEX_PROFILE_RFCOMM:\
+                        _mci->num_other_acl++;   \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_A2DP:  \
+                        _mci->num_a2dp++;        \
+                        if (!_info->edr)         \
+                                _mci->num_bdr++; \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_HID:   \
+                        _mci->num_hid++;         \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_BNEP:  \
+                        _mci->num_pan++;         \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_VOICE: \
+                        _mci->num_sco++;         \
+                        break;                   \
+                default:                         \
+                        break;                   \
+                }                                \
+        } while (0)
+
+#define DEC_PROF(_mci, _info) do {               \
+                switch (_info->type) {           \
+                case MCI_GPM_COEX_PROFILE_RFCOMM:\
+                        _mci->num_other_acl--;   \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_A2DP:  \
+                        _mci->num_a2dp--;        \
+                        if (!_info->edr)         \
+                                _mci->num_bdr--; \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_HID:   \
+                        _mci->num_hid--;         \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_BNEP:  \
+                        _mci->num_pan--;         \
+                        break;                   \
+                case MCI_GPM_COEX_PROFILE_VOICE: \
+                        _mci->num_sco--;         \
+                        break;                   \
+                default:                         \
+                        break;                   \
+                }                                \
+        } while (0)
+
+#define NUM_PROF(_mci)  (_mci->num_other_acl + _mci->num_a2dp + \
+                         _mci->num_hid + _mci->num_pan + _mci->num_sco)
+
+struct ath_mci_profile_info {
+        u8 type;
+        u8 conn_handle;
+        bool start;
+        bool master;
+        bool edr;
+        u8 voice_type;
+        u16 T;          /* Voice: Tvoice, HID: Tsniff,        in slots */
+        u8 W;           /* Voice: Wvoice, HID: Sniff timeout, in slots */
+        u8 A;           /*                HID: Sniff attempt, in slots */
+        struct list_head list;
+};
+
+struct ath_mci_profile_status {
+        bool is_critical;
+        bool is_link;
+        u8 conn_handle;
+};
+
+struct ath_mci_profile {
+        struct list_head info;
+        DECLARE_BITMAP(status, ATH_MCI_MAX_PROFILE);
+        u16 aggr_limit;
+        u8 num_mgmt;
+        u8 num_sco;
+        u8 num_a2dp;
+        u8 num_hid;
+        u8 num_pan;
+        u8 num_other_acl;
+        u8 num_bdr;
+};
+
+void ath_mci_flush_profile(struct ath_mci_profile *mci);
+void ath_mci_process_profile(struct ath_softc *sc,
+                             struct ath_mci_profile_info *info);
+void ath_mci_process_status(struct ath_softc *sc,
+                            struct ath_mci_profile_status *status);
+#endif
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 03b0a651a591..55d077e7135d 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -601,6 +601,7 @@ static u32 ath_lookup_rate(struct ath_softc *sc, struct ath_buf *bf,
         struct sk_buff *skb;
         struct ieee80211_tx_info *tx_info;
         struct ieee80211_tx_rate *rates;
+        struct ath_mci_profile *mci = &sc->btcoex.mci;
         u32 max_4ms_framelen, frmlen;
         u16 aggr_limit, legacy = 0;
         int i;
@@ -645,7 +646,9 @@ static u32 ath_lookup_rate(struct ath_softc *sc, struct ath_buf *bf,
         if (tx_info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE || legacy)
                 return 0;
 
-        if (sc->sc_flags & SC_OP_BT_PRIORITY_DETECTED)
+        if ((sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_MCI) && mci->aggr_limit)
+                aggr_limit = (max_4ms_framelen * mci->aggr_limit) >> 4;
+        else if (sc->sc_flags & SC_OP_BT_PRIORITY_DETECTED)
                 aggr_limit = min((max_4ms_framelen * 3) / 8,
                                  (u32)ATH_AMPDU_LIMIT_MAX);
         else
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/Makefile b/drivers/net/wireless/brcm80211/brcmfmac/Makefile
index b44e3094588a..d58aa1b0a932 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/Makefile
+++ b/drivers/net/wireless/brcm80211/brcmfmac/Makefile
@@ -26,7 +26,8 @@ DHDOFILES = \
         dhd_sdio.o      \
         dhd_linux.o \
         bcmsdh.o \
-        bcmsdh_sdmmc.o
+        bcmsdh_sdmmc.o \
+        sdio_chip.o
 
 obj-$(CONFIG_BRCMFMAC) += brcmfmac.o
 brcmfmac-objs += $(DHDOFILES)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmchip.h b/drivers/net/wireless/brcm80211/brcmfmac/bcmchip.h
index d7d3afd5a10f..cecb5e5f412b 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmchip.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmchip.h
@@ -18,13 +18,6 @@
 #define _bcmchip_h_
 
 /* bcm4329 */
-/* SDIO device core, ID 0x829 */
-#define BCM4329_CORE_BUS_BASE           0x18011000
-/* internal memory core, ID 0x80e */
-#define BCM4329_CORE_SOCRAM_BASE        0x18003000
-/* ARM Cortex M3 core, ID 0x82a */
-#define BCM4329_CORE_ARM_BASE           0x18002000
-#define BCM4329_RAMSIZE                 0x48000
 /* firmware name */
 #define BCM4329_FW_NAME                 "brcm/bcm4329-fullmac-4.bin"
 #define BCM4329_NV_NAME                 "brcm/bcm4329-fullmac-4.txt"
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd.h b/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
index 4645766b4070..6da519e7578f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
@@ -87,7 +87,7 @@
 #define TOE_TX_CSUM_OL          0x00000001
 #define TOE_RX_CSUM_OL          0x00000002
 
-#define BRCMF_BSS_INFO_VERSION  108 /* current ver of brcmf_bss_info struct */
+#define BRCMF_BSS_INFO_VERSION  108 /* curr ver of brcmf_bss_info_le struct */
 
 /* size of brcmf_scan_params not including variable length array */
 #define BRCMF_SCAN_PARAMS_FIXED_SIZE 64
@@ -122,8 +122,6 @@
 
 /* For supporting multiple interfaces */
 #define BRCMF_MAX_IFS   16
-#define BRCMF_DEL_IF    -0xe
-#define BRCMF_BAD_IF    -0xf
 
 #define DOT11_BSSTYPE_ANY                       2
 #define DOT11_MAX_DEFAULT_KEYS  4
@@ -365,7 +363,7 @@ struct brcmf_pkt_filter_enable_le {
  * Applications MUST CHECK ie_offset field and length field to access IEs and
  * next bss_info structure in a vector (in struct brcmf_scan_results)
  */
-struct brcmf_bss_info {
+struct brcmf_bss_info_le {
         __le32 version;         /* version field */
         __le32 length;          /* byte length of data in this record,
                                  * starting at version and including IEs
@@ -466,14 +464,13 @@ struct brcmf_scan_results {
         u32 buflen;
         u32 version;
         u32 count;
-        struct brcmf_bss_info bss_info[1];
+        struct brcmf_bss_info_le bss_info_le[];
 };
 
 struct brcmf_scan_results_le {
         __le32 buflen;
         __le32 version;
         __le32 count;
-        struct brcmf_bss_info bss_info[1];
 };
 
 /* used for association with a specific BSSID and chanspec list */
@@ -493,10 +490,6 @@ struct brcmf_join_params {
         struct brcmf_assoc_params_le params_le;
 };
 
-/* size of brcmf_scan_results not including variable length array */
-#define BRCMF_SCAN_RESULTS_FIXED_SIZE \
-        (sizeof(struct brcmf_scan_results) - sizeof(struct brcmf_bss_info))
-
 /* incremental scan results struct */
 struct brcmf_iscan_results {
         union {
@@ -511,7 +504,7 @@ struct brcmf_iscan_results {
 
 /* size of brcmf_iscan_results not including variable length array */
 #define BRCMF_ISCAN_RESULTS_FIXED_SIZE \
-        (BRCMF_SCAN_RESULTS_FIXED_SIZE + \
+        (sizeof(struct brcmf_scan_results) + \
          offsetof(struct brcmf_iscan_results, results))
 
 struct brcmf_wsec_key {
@@ -734,8 +727,7 @@ extern int brcmf_c_host_event(struct brcmf_info *drvr_priv, int *idx,
 extern void brcmf_c_init(void);
 
 extern int brcmf_add_if(struct brcmf_info *drvr_priv, int ifidx,
-                        struct net_device *ndev, char *name, u8 *mac_addr,
-                        u32 flags, u8 bssidx);
+                        char *name, u8 *mac_addr);
 extern void brcmf_del_if(struct brcmf_info *drvr_priv, int ifidx);
 
 /* Send packet to dongle via data channel */
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
index 891826197f96..40928e58b6a6 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
@@ -488,10 +488,9 @@ brcmf_c_host_event(struct brcmf_info *drvr_priv, int *ifidx, void *pktdata,
 
                 if (ifevent->ifidx > 0 && ifevent->ifidx < BRCMF_MAX_IFS) {
                         if (ifevent->action == BRCMF_E_IF_ADD)
-                                brcmf_add_if(drvr_priv, ifevent->ifidx, NULL,
+                                brcmf_add_if(drvr_priv, ifevent->ifidx,
                                              event->ifname,
-                                             pvt_data->eth.h_dest,
-                                             ifevent->flags, ifevent->bssidx);
+                                             pvt_data->eth.h_dest);
                         else
                                 brcmf_del_if(drvr_priv, ifevent->ifidx);
                 } else {
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
index 4acbac5a74c6..719fd9397eb6 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
@@ -58,7 +58,6 @@ struct brcmf_if {
         struct net_device *ndev;
         struct net_device_stats stats;
         int idx;                /* iface idx in dongle */
-        int state;              /* interface state */
         u8 mac_addr[ETH_ALEN];  /* assigned MAC address */
 };
 
@@ -80,20 +79,6 @@ struct brcmf_info {
 /* Error bits */
 module_param(brcmf_msg_level, int, 0);
 
-
-static int brcmf_net2idx(struct brcmf_info *drvr_priv, struct net_device *ndev)
-{
-        int i = 0;
-
-        while (i < BRCMF_MAX_IFS) {
-                if (drvr_priv->iflist[i] && drvr_priv->iflist[i]->ndev == ndev)
-                        return i;
-                i++;
-        }
-
-        return BRCMF_BAD_IF;
-}
-
 int brcmf_ifname2idx(struct brcmf_info *drvr_priv, char *name)
 {
         int i = BRCMF_MAX_IFS;
@@ -285,14 +270,9 @@ _brcmf_set_mac_address(struct work_struct *work)
 
 static int brcmf_netdev_set_mac_address(struct net_device *ndev, void *addr)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
         struct sockaddr *sa = (struct sockaddr *)addr;
-        int ifidx;
-
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-        if (ifidx == BRCMF_BAD_IF)
-                return -1;
 
         memcpy(&drvr_priv->macvalue, sa->sa_data, ETH_ALEN);
         schedule_work(&drvr_priv->setmacaddr_work);
@@ -301,13 +281,8 @@ static int brcmf_netdev_set_mac_address(struct net_device *ndev, void *addr)
 
 static void brcmf_netdev_set_multicast_list(struct net_device *ndev)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
-        int ifidx;
-
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-        if (ifidx == BRCMF_BAD_IF)
-                return;
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
         schedule_work(&drvr_priv->multicast_work);
 }
@@ -341,9 +316,8 @@ int brcmf_sendpkt(struct brcmf_pub *drvr, int ifidx, struct sk_buff *pktbuf)
 static int brcmf_netdev_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
         int ret;
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
-        int ifidx;
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
         brcmf_dbg(TRACE, "Enter\n");
 
@@ -355,9 +329,8 @@ static int brcmf_netdev_start_xmit(struct sk_buff *skb, struct net_device *ndev)
                 return -ENODEV;
         }
 
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-        if (ifidx == BRCMF_BAD_IF) {
-                brcmf_dbg(ERROR, "bad ifidx %d\n", ifidx);
+        if (!drvr_priv->iflist[ifp->idx]) {
+                brcmf_dbg(ERROR, "bad ifidx %d\n", ifp->idx);
                 netif_stop_queue(ndev);
                 return -ENODEV;
         }
@@ -367,20 +340,20 @@ static int brcmf_netdev_start_xmit(struct sk_buff *skb, struct net_device *ndev)
                 struct sk_buff *skb2;
 
                 brcmf_dbg(INFO, "%s: insufficient headroom\n",
-                          brcmf_ifname(&drvr_priv->pub, ifidx));
+                          brcmf_ifname(&drvr_priv->pub, ifp->idx));
                 drvr_priv->pub.tx_realloc++;
                 skb2 = skb_realloc_headroom(skb, drvr_priv->pub.hdrlen);
                 dev_kfree_skb(skb);
                 skb = skb2;
                 if (skb == NULL) {
                         brcmf_dbg(ERROR, "%s: skb_realloc_headroom failed\n",
-                                  brcmf_ifname(&drvr_priv->pub, ifidx));
+                                  brcmf_ifname(&drvr_priv->pub, ifp->idx));
                         ret = -ENOMEM;
                         goto done;
                 }
         }
 
-        ret = brcmf_sendpkt(&drvr_priv->pub, ifidx, skb);
+        ret = brcmf_sendpkt(&drvr_priv->pub, ifp->idx, skb);
 
 done:
         if (ret)
@@ -482,12 +455,10 @@ void brcmf_rx_frame(struct brcmf_pub *drvr, int ifidx, struct sk_buff *skb,
                                           skb_mac_header(skb),
                                           &event, &data);
 
-                if (drvr_priv->iflist[ifidx] &&
-                    !drvr_priv->iflist[ifidx]->state)
+                if (drvr_priv->iflist[ifidx]) {
                         ifp = drvr_priv->iflist[ifidx];
-
-                if (ifp->ndev)
                         ifp->ndev->last_rx = jiffies;
+                }
 
                 drvr->dstats.rx_bytes += skb->len;
                 drvr->rx_packets++;     /* Local count */
@@ -524,19 +495,11 @@ void brcmf_txcomplete(struct brcmf_pub *drvr, struct sk_buff *txp, bool success)
 
 static struct net_device_stats *brcmf_netdev_get_stats(struct net_device *ndev)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
-        struct brcmf_if *ifp;
-        int ifidx;
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
         brcmf_dbg(TRACE, "Enter\n");
 
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-        if (ifidx == BRCMF_BAD_IF)
-                return NULL;
-
-        ifp = drvr_priv->iflist[ifidx];
-
         if (drvr_priv->pub.up)
                 /* Use the protocol to get dongle stats */
                 brcmf_proto_dstats(&drvr_priv->pub);
@@ -637,8 +600,8 @@ static int brcmf_toe_set(struct brcmf_info *drvr_priv, int ifidx, u32 toe_ol)
 static void brcmf_ethtool_get_drvinfo(struct net_device *ndev,
                                     struct ethtool_drvinfo *info)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
         sprintf(info->driver, KBUILD_MODNAME);
         sprintf(info->version, "%lu", drvr_priv->pub.drv_version);
@@ -765,14 +728,12 @@ static int brcmf_ethtool(struct brcmf_info *drvr_priv, void __user *uaddr)
 static int brcmf_netdev_ioctl_entry(struct net_device *ndev, struct ifreq *ifr,
                                     int cmd)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
-        int ifidx;
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-        brcmf_dbg(TRACE, "ifidx %d, cmd 0x%04x\n", ifidx, cmd);
+        brcmf_dbg(TRACE, "ifidx %d, cmd 0x%04x\n", ifp->idx, cmd);
 
-        if (ifidx == BRCMF_BAD_IF)
+        if (!drvr_priv->iflist[ifp->idx])
                 return -1;
 
         if (cmd == SIOCETHTOOL)
@@ -788,17 +749,14 @@ s32 brcmf_exec_dcmd(struct net_device *ndev, u32 cmd, void *arg, u32 len)
         s32 err = 0;
         int buflen = 0;
         bool is_set_key_cmd;
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
-        int ifidx;
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
 
         memset(&dcmd, 0, sizeof(dcmd));
         dcmd.cmd = cmd;
         dcmd.buf = arg;
         dcmd.len = len;
 
-        ifidx = brcmf_net2idx(drvr_priv, ndev);
-
         if (dcmd.buf != NULL)
                 buflen = min_t(uint, dcmd.len, BRCMF_DCMD_MAXLEN);
 
@@ -826,7 +784,7 @@ s32 brcmf_exec_dcmd(struct net_device *ndev, u32 cmd, void *arg, u32 len)
         if (is_set_key_cmd)
                 brcmf_netdev_wait_pend8021x(ndev);
 
-        err = brcmf_proto_dcmd(&drvr_priv->pub, ifidx, &dcmd, buflen);
+        err = brcmf_proto_dcmd(&drvr_priv->pub, ifp->idx, &dcmd, buflen);
 
 done:
         if (err > 0)
@@ -837,7 +795,8 @@ done:
 
 static int brcmf_netdev_stop(struct net_device *ndev)
 {
-        struct brcmf_pub *drvr = *(struct brcmf_pub **) netdev_priv(ndev);
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_pub *drvr = &ifp->info->pub;
 
         brcmf_dbg(TRACE, "Enter\n");
         brcmf_cfg80211_down(drvr->config);
@@ -853,16 +812,14 @@ static int brcmf_netdev_stop(struct net_device *ndev)
 
 static int brcmf_netdev_open(struct net_device *ndev)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)
-                                        netdev_priv(ndev);
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
         u32 toe_ol;
-        int ifidx = brcmf_net2idx(drvr_priv, ndev);
         s32 ret = 0;
 
-        brcmf_dbg(TRACE, "ifidx %d\n", ifidx);
-
-        if (ifidx == 0) {       /* do it only for primary eth0 */
+        brcmf_dbg(TRACE, "ifidx %d\n", ifp->idx);
 
+        if (ifp->idx == 0) {    /* do it only for primary eth0 */
                 /* try to bring up bus */
                 ret = brcmf_bus_start(&drvr_priv->pub);
                 if (ret != 0) {
@@ -874,12 +831,12 @@ static int brcmf_netdev_open(struct net_device *ndev)
                 memcpy(ndev->dev_addr, drvr_priv->pub.mac, ETH_ALEN);
 
                 /* Get current TOE mode from dongle */
-                if (brcmf_toe_get(drvr_priv, ifidx, &toe_ol) >= 0
+                if (brcmf_toe_get(drvr_priv, ifp->idx, &toe_ol) >= 0
                     && (toe_ol & TOE_TX_CSUM_OL) != 0)
-                        drvr_priv->iflist[ifidx]->ndev->features |=
+                        drvr_priv->iflist[ifp->idx]->ndev->features |=
                                 NETIF_F_IP_CSUM;
                 else
-                        drvr_priv->iflist[ifidx]->ndev->features &=
+                        drvr_priv->iflist[ifp->idx]->ndev->features &=
                                 ~NETIF_F_IP_CSUM;
         }
         /* Allow transmit calls */
@@ -893,75 +850,62 @@ static int brcmf_netdev_open(struct net_device *ndev)
         return ret;
 }
 
+static const struct net_device_ops brcmf_netdev_ops_pri = {
+        .ndo_open = brcmf_netdev_open,
+        .ndo_stop = brcmf_netdev_stop,
+        .ndo_get_stats = brcmf_netdev_get_stats,
+        .ndo_do_ioctl = brcmf_netdev_ioctl_entry,
+        .ndo_start_xmit = brcmf_netdev_start_xmit,
+        .ndo_set_mac_address = brcmf_netdev_set_mac_address,
+        .ndo_set_rx_mode = brcmf_netdev_set_multicast_list
+};
+
 int
-brcmf_add_if(struct brcmf_info *drvr_priv, int ifidx, struct net_device *ndev,
-             char *name, u8 *mac_addr, u32 flags, u8 bssidx)
+brcmf_add_if(struct brcmf_info *drvr_priv, int ifidx, char *name, u8 *mac_addr)
 {
         struct brcmf_if *ifp;
-        int ret = 0, err = 0;
+        struct net_device *ndev;
 
-        brcmf_dbg(TRACE, "idx %d, handle->%p\n", ifidx, ndev);
+        brcmf_dbg(TRACE, "idx %d\n", ifidx);
 
         ifp = drvr_priv->iflist[ifidx];
-        if (!ifp) {
-                ifp = kmalloc(sizeof(struct brcmf_if), GFP_ATOMIC);
-                if (!ifp)
-                        return -ENOMEM;
+        /*
+         * Delete the existing interface before overwriting it
+         * in case we missed the BRCMF_E_IF_DEL event.
+         */
+        if (ifp) {
+                brcmf_dbg(ERROR, "ERROR: netdev:%s already exists, try free & unregister\n",
+                          ifp->ndev->name);
+                netif_stop_queue(ifp->ndev);
+                unregister_netdev(ifp->ndev);
+                free_netdev(ifp->ndev);
+                drvr_priv->iflist[ifidx] = NULL;
+        }
+
+        /* Allocate netdev, including space for private structure */
+        ndev = alloc_netdev(sizeof(struct brcmf_if), name, ether_setup);
+        if (!ndev) {
+                brcmf_dbg(ERROR, "OOM - alloc_netdev\n");
+                return -ENOMEM;
         }
 
-        memset(ifp, 0, sizeof(struct brcmf_if));
+        ifp = netdev_priv(ndev);
+        ifp->ndev = ndev;
         ifp->info = drvr_priv;
         drvr_priv->iflist[ifidx] = ifp;
+        ifp->idx = ifidx;
         if (mac_addr != NULL)
                 memcpy(&ifp->mac_addr, mac_addr, ETH_ALEN);
 
-        if (ndev == NULL) {
-                ifp->state = BRCMF_E_IF_ADD;
-                ifp->idx = ifidx;
-                /*
-                 * Delete the existing interface before overwriting it
-                 * in case we missed the BRCMF_E_IF_DEL event.
-                 */
-                if (ifp->ndev != NULL) {
-                        brcmf_dbg(ERROR, "ERROR: netdev:%s already exists, try free & unregister\n",
-                                  ifp->ndev->name);
-                        netif_stop_queue(ifp->ndev);
-                        unregister_netdev(ifp->ndev);
-                        free_netdev(ifp->ndev);
-                }
-
-                /* Allocate netdev, including space for private structure */
-                ifp->ndev = alloc_netdev(sizeof(drvr_priv), "wlan%d",
-                                         ether_setup);
-                if (!ifp->ndev) {
-                        brcmf_dbg(ERROR, "OOM - alloc_netdev\n");
-                        ret = -ENOMEM;
-                }
-
-                if (ret == 0) {
-                        memcpy(netdev_priv(ifp->ndev), &drvr_priv,
-                               sizeof(drvr_priv));
-                        err = brcmf_net_attach(&drvr_priv->pub, ifp->idx);
-                        if (err != 0) {
-                                brcmf_dbg(ERROR, "brcmf_net_attach failed, err %d\n",
-                                          err);
-                                ret = -EOPNOTSUPP;
-                        } else {
-                                brcmf_dbg(TRACE, " ==== pid:%x, net_device for if:%s created ===\n",
-                                          current->pid, ifp->ndev->name);
-                                ifp->state = 0;
-                        }
-                }
-
-                if (ret < 0) {
-                        if (ifp->ndev)
-                                free_netdev(ifp->ndev);
+        if (brcmf_net_attach(&drvr_priv->pub, ifp->idx)) {
+                brcmf_dbg(ERROR, "brcmf_net_attach failed");
+                free_netdev(ifp->ndev);
+                drvr_priv->iflist[ifidx] = NULL;
+                return -EOPNOTSUPP;
+        }
 
-                        drvr_priv->iflist[ifp->idx] = NULL;
-                        kfree(ifp);
-                }
-        } else
-                ifp->ndev = ndev;
+        brcmf_dbg(TRACE, " ==== pid:%x, net_device for if:%s created ===\n",
+                  current->pid, ifp->ndev->name);
 
         return 0;
 }
@@ -977,47 +921,36 @@ void brcmf_del_if(struct brcmf_info *drvr_priv, int ifidx)
                 brcmf_dbg(ERROR, "Null interface\n");
                 return;
         }
+        if (ifp->ndev) {
+                if (ifidx == 0) {
+                        if (ifp->ndev->netdev_ops == &brcmf_netdev_ops_pri) {
+                                rtnl_lock();
+                                brcmf_netdev_stop(ifp->ndev);
+                                rtnl_unlock();
+                        }
+                } else {
+                        netif_stop_queue(ifp->ndev);
+                }
 
-        ifp->state = BRCMF_E_IF_DEL;
-        ifp->idx = ifidx;
-        if (ifp->ndev != NULL) {
-                netif_stop_queue(ifp->ndev);
                 unregister_netdev(ifp->ndev);
-                free_netdev(ifp->ndev);
                 drvr_priv->iflist[ifidx] = NULL;
-                kfree(ifp);
+                if (ifidx == 0)
+                        brcmf_cfg80211_detach(drvr_priv->pub.config);
+                free_netdev(ifp->ndev);
         }
 }
 
 struct brcmf_pub *brcmf_attach(struct brcmf_bus *bus, uint bus_hdrlen)
 {
         struct brcmf_info *drvr_priv = NULL;
-        struct net_device *ndev;
 
         brcmf_dbg(TRACE, "Enter\n");
 
-        /* Allocate netdev, including space for private structure */
-        ndev = alloc_netdev(sizeof(drvr_priv), "wlan%d", ether_setup);
-        if (!ndev) {
-                brcmf_dbg(ERROR, "OOM - alloc_netdev\n");
-                goto fail;
-        }
-
         /* Allocate primary brcmf_info */
         drvr_priv = kzalloc(sizeof(struct brcmf_info), GFP_ATOMIC);
         if (!drvr_priv)
                 goto fail;
 
-        /*
-         * Save the brcmf_info into the priv
-         */
-        memcpy(netdev_priv(ndev), &drvr_priv, sizeof(drvr_priv));
-
-        if (brcmf_add_if(drvr_priv, 0, ndev, ndev->name, NULL, 0, 0) ==
-            BRCMF_BAD_IF)
-                goto fail;
-
-        ndev->netdev_ops = NULL;
         mutex_init(&drvr_priv->proto_block);
 
         /* Link to info module */
@@ -1033,29 +966,12 @@ struct brcmf_pub *brcmf_attach(struct brcmf_bus *bus, uint bus_hdrlen)
                 goto fail;
         }
 
-        /* Attach and link in the cfg80211 */
-        drvr_priv->pub.config =
-                        brcmf_cfg80211_attach(ndev,
-                                              brcmf_bus_get_device(bus),
-                                              &drvr_priv->pub);
-        if (drvr_priv->pub.config == NULL) {
-                brcmf_dbg(ERROR, "wl_cfg80211_attach failed\n");
-                goto fail;
-        }
-
         INIT_WORK(&drvr_priv->setmacaddr_work, _brcmf_set_mac_address);
         INIT_WORK(&drvr_priv->multicast_work, _brcmf_set_multicast_list);
 
-        /*
-         * Save the brcmf_info into the priv
-         */
-        memcpy(netdev_priv(ndev), &drvr_priv, sizeof(drvr_priv));
-
         return &drvr_priv->pub;
 
 fail:
-        if (ndev)
-                free_netdev(ndev);
         if (drvr_priv)
                 brcmf_detach(&drvr_priv->pub);
 
@@ -1123,16 +1039,6 @@ int brcmf_bus_start(struct brcmf_pub *drvr)
         return 0;
 }
 
-static struct net_device_ops brcmf_netdev_ops_pri = {
-        .ndo_open = brcmf_netdev_open,
-        .ndo_stop = brcmf_netdev_stop,
-        .ndo_get_stats = brcmf_netdev_get_stats,
-        .ndo_do_ioctl = brcmf_netdev_ioctl_entry,
-        .ndo_start_xmit = brcmf_netdev_start_xmit,
-        .ndo_set_mac_address = brcmf_netdev_set_mac_address,
-        .ndo_set_rx_mode = brcmf_netdev_set_multicast_list
-};
-
 int brcmf_net_attach(struct brcmf_pub *drvr, int ifidx)
 {
         struct brcmf_info *drvr_priv = drvr->info;
@@ -1169,6 +1075,18 @@ int brcmf_net_attach(struct brcmf_pub *drvr, int ifidx)
 
         memcpy(ndev->dev_addr, temp_addr, ETH_ALEN);
 
+        /* attach to cfg80211 for primary interface */
+        if (!ifidx) {
+                drvr->config =
+                        brcmf_cfg80211_attach(ndev,
+                                              brcmf_bus_get_device(drvr->bus),
+                                              drvr);
+                if (drvr->config == NULL) {
+                        brcmf_dbg(ERROR, "wl_cfg80211_attach failed\n");
+                        goto fail;
+                }
+        }
+
         if (register_netdev(ndev) != 0) {
                 brcmf_dbg(ERROR, "couldn't register the net device\n");
                 goto fail;
@@ -1210,21 +1128,13 @@ void brcmf_detach(struct brcmf_pub *drvr)
         if (drvr) {
                 drvr_priv = drvr->info;
                 if (drvr_priv) {
-                        struct brcmf_if *ifp;
                         int i;
 
-                        for (i = 1; i < BRCMF_MAX_IFS; i++)
+                        /* make sure primary interface removed last */
+                        for (i = BRCMF_MAX_IFS-1; i > -1; i--)
                                 if (drvr_priv->iflist[i])
                                         brcmf_del_if(drvr_priv, i);
 
-                        ifp = drvr_priv->iflist[0];
-                        if (ifp->ndev->netdev_ops == &brcmf_netdev_ops_pri) {
-                                rtnl_lock();
-                                brcmf_netdev_stop(ifp->ndev);
-                                rtnl_unlock();
-                                unregister_netdev(ifp->ndev);
-                        }
-
                         cancel_work_sync(&drvr_priv->setmacaddr_work);
                         cancel_work_sync(&drvr_priv->multicast_work);
 
@@ -1233,10 +1143,6 @@ void brcmf_detach(struct brcmf_pub *drvr)
                         if (drvr->prot)
                                 brcmf_proto_detach(drvr);
 
-                        brcmf_cfg80211_detach(drvr->config);
-
-                        free_netdev(ifp->ndev);
-                        kfree(ifp);
                         kfree(drvr_priv);
                 }
         }
@@ -1302,7 +1208,8 @@ static int brcmf_get_pend_8021x_cnt(struct brcmf_info *drvr_priv)
 
 int brcmf_netdev_wait_pend8021x(struct net_device *ndev)
 {
-        struct brcmf_info *drvr_priv = *(struct brcmf_info **)netdev_priv(ndev);
+        struct brcmf_if *ifp = netdev_priv(ndev);
+        struct brcmf_info *drvr_priv = ifp->info;
         int timeout = 10 * HZ / 1000;
         int ntimes = MAX_WAIT_FOR_8021X_TX;
         int pend = brcmf_get_pend_8021x_cnt(drvr_priv);
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
index 313b8bf592d1..22913af26db8 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
@@ -28,6 +28,7 @@
 #include <linux/semaphore.h>
 #include <linux/firmware.h>
 #include <linux/module.h>
+#include <linux/bcma/bcma.h>
 #include <asm/unaligned.h>
 #include <defs.h>
 #include <brcmu_wifi.h>
@@ -35,6 +36,7 @@
 #include <brcm_hw_ids.h>
 #include <soc.h>
 #include "sdio_host.h"
+#include "sdio_chip.h"
 
 #define DCMD_RESP_TIMEOUT  2000 /* In milli second */
 
@@ -134,33 +136,6 @@ struct rte_console {
 /*   Force no backplane reset */
 #define SBSDIO_DEVCTL_RST_NOBPRESET     0x20
 
-/* SBSDIO_FUNC1_CHIPCLKCSR */
-
-/* Force ALP request to backplane */
-#define SBSDIO_FORCE_ALP                0x01
-/* Force HT request to backplane */
-#define SBSDIO_FORCE_HT                 0x02
-/* Force ILP request to backplane */
-#define SBSDIO_FORCE_ILP                0x04
-/* Make ALP ready (power up xtal) */
-#define SBSDIO_ALP_AVAIL_REQ            0x08
-/* Make HT ready (power up PLL) */
-#define SBSDIO_HT_AVAIL_REQ             0x10
-/* Squelch clock requests from HW */
-#define SBSDIO_FORCE_HW_CLKREQ_OFF      0x20
-/* Status: ALP is ready */
-#define SBSDIO_ALP_AVAIL                0x40
-/* Status: HT is ready */
-#define SBSDIO_HT_AVAIL                 0x80
-
-#define SBSDIO_AVBITS           (SBSDIO_HT_AVAIL | SBSDIO_ALP_AVAIL)
-#define SBSDIO_ALPAV(regval)    ((regval) & SBSDIO_AVBITS)
-#define SBSDIO_HTAV(regval)     (((regval) & SBSDIO_AVBITS) == SBSDIO_AVBITS)
-#define SBSDIO_ALPONLY(regval)  (SBSDIO_ALPAV(regval) && !SBSDIO_HTAV(regval))
-
-#define SBSDIO_CLKAV(regval, alponly) \
-        (SBSDIO_ALPAV(regval) && (alponly ? 1 : SBSDIO_HTAV(regval)))
-
 /* direct(mapped) cis space */
 
 /* MAPPED common CIS address */
@@ -335,50 +310,6 @@ struct rte_console {
 /* Flags for SDH calls */
 #define F2SYNC  (SDIO_REQ_4BYTE | SDIO_REQ_FIXED)
 
-/* sbimstate */
-#define SBIM_IBE                0x20000 /* inbanderror */
-#define SBIM_TO                 0x40000 /* timeout */
-#define SBIM_BY                 0x01800000      /* busy (sonics >= 2.3) */
-#define SBIM_RJ                 0x02000000      /* reject (sonics >= 2.3) */
-
-/* sbtmstatelow */
-
-/* reset */
-#define SBTML_RESET             0x0001
-/* reject field */
-#define SBTML_REJ_MASK          0x0006
-/* reject */
-#define SBTML_REJ               0x0002
-/* temporary reject, for error recovery */
-#define SBTML_TMPREJ            0x0004
-
-/* Shift to locate the SI control flags in sbtml */
-#define SBTML_SICF_SHIFT        16
-
-/* sbtmstatehigh */
-#define SBTMH_SERR              0x0001  /* serror */
-#define SBTMH_INT               0x0002  /* interrupt */
-#define SBTMH_BUSY              0x0004  /* busy */
-#define SBTMH_TO                0x0020  /* timeout (sonics >= 2.3) */
-
-/* Shift to locate the SI status flags in sbtmh */
-#define SBTMH_SISF_SHIFT        16
-
-/* sbidlow */
-#define SBIDL_INIT              0x80    /* initiator */
-
-/* sbidhigh */
-#define SBIDH_RC_MASK           0x000f  /* revision code */
-#define SBIDH_RCE_MASK          0x7000  /* revision code extension field */
-#define SBIDH_RCE_SHIFT         8
-#define SBCOREREV(sbidh) \
-        ((((sbidh) & SBIDH_RCE_MASK) >> SBIDH_RCE_SHIFT) | \
-          ((sbidh) & SBIDH_RC_MASK))
-#define SBIDH_CC_MASK           0x8ff0  /* core code */
-#define SBIDH_CC_SHIFT          4
-#define SBIDH_VC_MASK           0xffff0000      /* vendor code */
-#define SBIDH_VC_SHIFT          16
-
 /*
  * Conversion of 802.1D priority to precedence level
  */
@@ -388,17 +319,6 @@ static uint prio2prec(u32 prio)
                (prio^2) : prio;
 }
 
-/*
- * Core reg address translation.
- * Both macro's returns a 32 bits byte address on the backplane bus.
- */
-#define CORE_CC_REG(base, field) \
-                (base + offsetof(struct chipcregs, field))
-#define CORE_BUS_REG(base, field) \
-                (base + offsetof(struct sdpcmd_regs, field))
-#define CORE_SB(base, field) \
-                (base + SBCONFIGOFF + offsetof(struct sbconfig, field))
-
 /* core registers */
 struct sdpcmd_regs {
         u32 corecontrol;                /* 0x00, rev8 */
@@ -524,21 +444,6 @@ struct sdpcm_shared_le {
 
 
 /* misc chip info needed by some of the routines */
-struct chip_info {
-        u32 chip;
-        u32 chiprev;
-        u32 cccorebase;
-        u32 ccrev;
-        u32 cccaps;
-        u32 buscorebase; /* 32 bits backplane bus address */
-        u32 buscorerev;
-        u32 buscoretype;
-        u32 ramcorebase;
-        u32 armcorebase;
-        u32 pmurev;
-        u32 ramsize;
-};
-
 /* Private data for SDIO bus interaction */
 struct brcmf_bus {
         struct brcmf_pub *drvr;
@@ -574,7 +479,7 @@ struct brcmf_bus {
         uint txminmax;
 
         struct sk_buff *glomd;  /* Packet containing glomming descriptor */
-        struct sk_buff *glom;   /* Packet chain for glommed superframe */
+        struct sk_buff_head glom; /* Packet list for glommed superframe */
         uint glomerr;           /* Glom packet read errors */
 
         u8 *rxbuf;              /* Buffer for receiving control packets */
@@ -663,46 +568,6 @@ struct brcmf_bus {
         u32 fw_ptr;
 };
 
-struct sbconfig {
-        u32 PAD[2];
-        u32 sbipsflag;  /* initiator port ocp slave flag */
-        u32 PAD[3];
-        u32 sbtpsflag;  /* target port ocp slave flag */
-        u32 PAD[11];
-        u32 sbtmerrloga;        /* (sonics >= 2.3) */
-        u32 PAD;
-        u32 sbtmerrlog; /* (sonics >= 2.3) */
-        u32 PAD[3];
-        u32 sbadmatch3; /* address match3 */
-        u32 PAD;
-        u32 sbadmatch2; /* address match2 */
-        u32 PAD;
-        u32 sbadmatch1; /* address match1 */
-        u32 PAD[7];
-        u32 sbimstate;  /* initiator agent state */
-        u32 sbintvec;   /* interrupt mask */
-        u32 sbtmstatelow;       /* target state */
-        u32 sbtmstatehigh;      /* target state */
-        u32 sbbwa0;             /* bandwidth allocation table0 */
-        u32 PAD;
-        u32 sbimconfiglow;      /* initiator configuration */
-        u32 sbimconfighigh;     /* initiator configuration */
-        u32 sbadmatch0; /* address match0 */
-        u32 PAD;
-        u32 sbtmconfiglow;      /* target configuration */
-        u32 sbtmconfighigh;     /* target configuration */
-        u32 sbbconfig;  /* broadcast configuration */
-        u32 PAD;
-        u32 sbbstate;   /* broadcast state */
-        u32 PAD[3];
-        u32 sbactcnfg;  /* activate configuration */
-        u32 PAD[3];
-        u32 sbflagst;   /* current sbflags */
-        u32 PAD[3];
-        u32 sbidlow;            /* identification */
-        u32 sbidhigh;   /* identification */
-};
-
 /* clkstate */
 #define CLK_NONE        0
 #define CLK_SDONLY      1
@@ -750,10 +615,12 @@ static bool data_ok(struct brcmf_bus *bus)
 static void
 r_sdreg32(struct brcmf_bus *bus, u32 *regvar, u32 reg_offset, u32 *retryvar)
 {
+        u8 idx = brcmf_sdio_chip_getinfidx(bus->ci, BCMA_CORE_SDIO_DEV);
         *retryvar = 0;
         do {
                 *regvar = brcmf_sdcard_reg_read(bus->sdiodev,
-                                bus->ci->buscorebase + reg_offset, sizeof(u32));
+                                bus->ci->c_inf[idx].base + reg_offset,
+                                sizeof(u32));
         } while (brcmf_sdcard_regfail(bus->sdiodev) &&
                  (++(*retryvar) <= retry_limit));
         if (*retryvar) {
@@ -768,10 +635,11 @@ r_sdreg32(struct brcmf_bus *bus, u32 *regvar, u32 reg_offset, u32 *retryvar)
 static void
 w_sdreg32(struct brcmf_bus *bus, u32 regval, u32 reg_offset, u32 *retryvar)
 {
+        u8 idx = brcmf_sdio_chip_getinfidx(bus->ci, BCMA_CORE_SDIO_DEV);
         *retryvar = 0;
         do {
                 brcmf_sdcard_reg_write(bus->sdiodev,
-                                       bus->ci->buscorebase + reg_offset,
+                                       bus->ci->c_inf[idx].base + reg_offset,
                                        sizeof(u32), regval);
         } while (brcmf_sdcard_regfail(bus->sdiodev) &&
                  (++(*retryvar) <= retry_limit));
@@ -812,10 +680,6 @@ static int brcmf_sdbrcm_htclk(struct brcmf_bus *bus, bool on, bool pendok)
                 clkreq =
                     bus->alp_only ? SBSDIO_ALP_AVAIL_REQ : SBSDIO_HT_AVAIL_REQ;
 
-                if ((bus->ci->chip == BCM4329_CHIP_ID)
-                    && (bus->ci->chiprev == 0))
-                        clkreq |= SBSDIO_FORCE_ALP;
-
                 brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
                                        SBSDIO_FUNC1_CHIPCLKCSR, clkreq, &err);
                 if (err) {
@@ -823,14 +687,6 @@ static int brcmf_sdbrcm_htclk(struct brcmf_bus *bus, bool on, bool pendok)
                         return -EBADE;
                 }
 
-                if (pendok && ((bus->ci->buscoretype == PCMCIA_CORE_ID)
-                               && (bus->ci->buscorerev == 9))) {
-                        u32 dummy, retries;
-                        r_sdreg32(bus, &dummy,
-                                  offsetof(struct sdpcmd_regs, clockctlstatus),
-                                  &retries);
-                }
-
                 /* Check current status */
                 clkctl = brcmf_sdcard_cfg_read(bus->sdiodev, SDIO_FUNC_1,
                                                SBSDIO_FUNC1_CHIPCLKCSR, &err);
@@ -1034,11 +890,9 @@ static int brcmf_sdbrcm_bussleep(struct brcmf_bus *bus, bool sleep)
                         SBSDIO_FORCE_HW_CLKREQ_OFF, NULL);
 
                 /* Isolate the bus */
-                if (bus->ci->chip != BCM4329_CHIP_ID) {
-                        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                                SBSDIO_DEVICE_CTL,
-                                SBSDIO_DEVCTL_PADS_ISO, NULL);
-                }
+                brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
+                        SBSDIO_DEVICE_CTL,
+                        SBSDIO_DEVCTL_PADS_ISO, NULL);
 
                 /* Change state */
                 bus->sleeping = true;
@@ -1049,13 +903,6 @@ static int brcmf_sdbrcm_bussleep(struct brcmf_bus *bus, bool sleep)
                 brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
                         SBSDIO_FUNC1_CHIPCLKCSR, 0, NULL);
 
-                /* Force pad isolation off if possible
-                         (in case power never toggled) */
-                if ((bus->ci->buscoretype == PCMCIA_CORE_ID)
-                    && (bus->ci->buscorerev >= 10))
-                        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                                SBSDIO_DEVICE_CTL, 0, NULL);
-
                 /* Make sure the controller has the bus up */
                 brcmf_sdbrcm_clkctl(bus, CLK_AVAIL, false);
 
@@ -1222,6 +1069,51 @@ static void brcmf_sdbrcm_rxfail(struct brcmf_bus *bus, bool abort, bool rtx)
                 bus->drvr->busstate = BRCMF_BUS_DOWN;
 }
 
+/* copy a buffer into a pkt buffer chain */
+static uint brcmf_sdbrcm_glom_from_buf(struct brcmf_bus *bus, uint len)
+{
+        uint n, ret = 0;
+        struct sk_buff *p;
+        u8 *buf;
+
+        buf = bus->dataptr;
+
+        /* copy the data */
+        skb_queue_walk(&bus->glom, p) {
+                n = min_t(uint, p->len, len);
+                memcpy(p->data, buf, n);
+                buf += n;
+                len -= n;
+                ret += n;
+                if (!len)
+                        break;
+        }
+
+        return ret;
+}
+
+/* return total length of buffer chain */
+static uint brcmf_sdbrcm_glom_len(struct brcmf_bus *bus)
+{
+        struct sk_buff *p;
+        uint total;
+
+        total = 0;
+        skb_queue_walk(&bus->glom, p)
+                total += p->len;
+        return total;
+}
+
+static void brcmf_sdbrcm_free_glom(struct brcmf_bus *bus)
+{
+        struct sk_buff *cur, *next;
+
+        skb_queue_walk_safe(&bus->glom, cur, next) {
+                skb_unlink(cur, &bus->glom);
+                brcmu_pkt_buf_free_skb(cur);
+        }
+}
+
 static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
 {
         u16 dlen, totlen;
@@ -1240,7 +1132,8 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
         /* If packets, issue read(s) and send up packet chain */
         /* Return sequence numbers consumed? */
 
-        brcmf_dbg(TRACE, "start: glomd %p glom %p\n", bus->glomd, bus->glom);
+        brcmf_dbg(TRACE, "start: glomd %p glom %p\n",
+                  bus->glomd, skb_peek(&bus->glom));
 
         /* If there's a descriptor, generate the packet chain */
         if (bus->glomd) {
@@ -1287,12 +1180,7 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
                                           num, sublen);
                                 break;
                         }
-                        if (!pfirst) {
-                                pfirst = plast = pnext;
-                        } else {
-                                plast->next = pnext;
-                                plast = pnext;
-                        }
+                        skb_queue_tail(&bus->glom, pnext);
 
                         /* Adhere to start alignment requirements */
                         pkt_align(pnext, sublen, BRCMF_SDALIGN);
@@ -1308,12 +1196,9 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
                                 brcmf_dbg(GLOM, "glomdesc mismatch: nextlen %d glomdesc %d rxseq %d\n",
                                           bus->nextlen, totlen, rxseq);
                         }
-                        bus->glom = pfirst;
                         pfirst = pnext = NULL;
                 } else {
-                        if (pfirst)
-                                brcmu_pkt_buf_free_skb(pfirst);
-                        bus->glom = NULL;
+                        brcmf_sdbrcm_free_glom(bus);
                         num = 0;
                 }
 
@@ -1325,18 +1210,18 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
 
         /* Ok -- either we just generated a packet chain,
                  or had one from before */
-        if (bus->glom) {
+        if (!skb_queue_empty(&bus->glom)) {
                 if (BRCMF_GLOM_ON()) {
                         brcmf_dbg(GLOM, "try superframe read, packet chain:\n");
-                        for (pnext = bus->glom; pnext; pnext = pnext->next) {
+                        skb_queue_walk(&bus->glom, pnext) {
                                 brcmf_dbg(GLOM, "    %p: %p len 0x%04x (%d)\n",
                                           pnext, (u8 *) (pnext->data),
                                           pnext->len, pnext->len);
                         }
                 }
 
-                pfirst = bus->glom;
-                dlen = (u16) brcmu_pkttotlen(pfirst);
+                pfirst = skb_peek(&bus->glom);
+                dlen = (u16) brcmf_sdbrcm_glom_len(bus);
 
                 /* Do an SDIO read for the superframe.  Configurable iovar to
                  * read directly into the chained packet, or allocate a large
@@ -1354,8 +1239,7 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
                                         SDIO_FUNC_2,
                                         F2SYNC, bus->dataptr, dlen,
                                         NULL);
-                        sublen = (u16) brcmu_pktfrombuf(pfirst, 0, dlen,
-                                                bus->dataptr);
+                        sublen = (u16) brcmf_sdbrcm_glom_from_buf(bus, dlen);
                         if (sublen != dlen) {
                                 brcmf_dbg(ERROR, "FAILED TO COPY, dlen %d sublen %d\n",
                                           dlen, sublen);
@@ -1380,9 +1264,8 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
                         } else {
                                 bus->glomerr = 0;
                                 brcmf_sdbrcm_rxfail(bus, true, false);
-                                brcmu_pkt_buf_free_skb(bus->glom);
                                 bus->rxglomfail++;
-                                bus->glom = NULL;
+                                brcmf_sdbrcm_free_glom(bus);
                         }
                         return 0;
                 }
@@ -1503,9 +1386,8 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
                         } else {
                                 bus->glomerr = 0;
                                 brcmf_sdbrcm_rxfail(bus, true, false);
-                                brcmu_pkt_buf_free_skb(bus->glom);
                                 bus->rxglomfail++;
-                                bus->glom = NULL;
+                                brcmf_sdbrcm_free_glom(bus);
                         }
                         bus->nextlen = 0;
                         return 0;
@@ -1513,7 +1395,6 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_bus *bus, u8 rxseq)
 
                 /* Basic SD framing looks ok - process each packet (header) */
                 save_pfirst = pfirst;
-                bus->glom = NULL;
                 plast = NULL;
 
                 for (num = 0; pfirst; rxseq++, pfirst = pnext) {
@@ -1850,10 +1731,10 @@ brcmf_sdbrcm_readframes(struct brcmf_bus *bus, uint maxframes, bool *finished)
              rxseq++, rxleft--) {
 
                 /* Handle glomming separately */
-                if (bus->glom || bus->glomd) {
+                if (bus->glomd || !skb_queue_empty(&bus->glom)) {
                         u8 cnt;
                         brcmf_dbg(GLOM, "calling rxglom: glomd %p, glom %p\n",
-                                  bus->glomd, bus->glom);
+                                  bus->glomd, skb_peek(&bus->glom));
                         cnt = brcmf_sdbrcm_rxglom(bus, rxseq);
                         brcmf_dbg(GLOM, "rxglom returned %d\n", cnt);
                         rxseq += cnt - 1;
@@ -3210,135 +3091,11 @@ static int brcmf_sdbrcm_write_vars(struct brcmf_bus *bus)
         return bcmerror;
 }
 
-static void
-brcmf_sdbrcm_chip_disablecore(struct brcmf_sdio_dev *sdiodev, u32 corebase)
-{
-        u32 regdata;
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                CORE_SB(corebase, sbtmstatelow), 4);
-        if (regdata & SBTML_RESET)
-                return;
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                CORE_SB(corebase, sbtmstatelow), 4);
-        if ((regdata & (SICF_CLOCK_EN << SBTML_SICF_SHIFT)) != 0) {
-                /*
-                 * set target reject and spin until busy is clear
-                 * (preserve core-specific bits)
-                 */
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbtmstatelow), 4);
-                brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbtmstatelow),
-                                       4, regdata | SBTML_REJ);
-
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbtmstatelow), 4);
-                udelay(1);
-                SPINWAIT((brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbtmstatehigh), 4) &
-                        SBTMH_BUSY), 100000);
-
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbtmstatehigh), 4);
-                if (regdata & SBTMH_BUSY)
-                        brcmf_dbg(ERROR, "ARM core still busy\n");
-
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbidlow), 4);
-                if (regdata & SBIDL_INIT) {
-                        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4) |
-                                SBIM_RJ;
-                        brcmf_sdcard_reg_write(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4,
-                                regdata);
-                        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4);
-                        udelay(1);
-                        SPINWAIT((brcmf_sdcard_reg_read(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4) &
-                                SBIM_BY), 100000);
-                }
-
-                /* set reset and reject while enabling the clocks */
-                brcmf_sdcard_reg_write(sdiodev,
-                        CORE_SB(corebase, sbtmstatelow), 4,
-                        (((SICF_FGC | SICF_CLOCK_EN) << SBTML_SICF_SHIFT) |
-                        SBTML_REJ | SBTML_RESET));
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbtmstatelow), 4);
-                udelay(10);
-
-                /* clear the initiator reject bit */
-                regdata = brcmf_sdcard_reg_read(sdiodev,
-                        CORE_SB(corebase, sbidlow), 4);
-                if (regdata & SBIDL_INIT) {
-                        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4) &
-                                ~SBIM_RJ;
-                        brcmf_sdcard_reg_write(sdiodev,
-                                CORE_SB(corebase, sbimstate), 4,
-                                regdata);
-                }
-        }
-
-        /* leave reset and reject asserted */
-        brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbtmstatelow), 4,
-                (SBTML_REJ | SBTML_RESET));
-        udelay(1);
-}
-
-static void
-brcmf_sdbrcm_chip_resetcore(struct brcmf_sdio_dev *sdiodev, u32 corebase)
-{
-        u32 regdata;
-
-        /*
-         * Must do the disable sequence first to work for
-         * arbitrary current core state.
-         */
-        brcmf_sdbrcm_chip_disablecore(sdiodev, corebase);
-
-        /*
-         * Now do the initialization sequence.
-         * set reset while enabling the clock and
-         * forcing them on throughout the core
-         */
-        brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbtmstatelow), 4,
-                ((SICF_FGC | SICF_CLOCK_EN) << SBTML_SICF_SHIFT) |
-                SBTML_RESET);
-        udelay(1);
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                        CORE_SB(corebase, sbtmstatehigh), 4);
-        if (regdata & SBTMH_SERR)
-                brcmf_sdcard_reg_write(sdiodev,
-                                       CORE_SB(corebase, sbtmstatehigh), 4, 0);
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                        CORE_SB(corebase, sbimstate), 4);
-        if (regdata & (SBIM_IBE | SBIM_TO))
-                brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbimstate), 4,
-                        regdata & ~(SBIM_IBE | SBIM_TO));
-
-        /* clear reset and allow it to propagate throughout the core */
-        brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbtmstatelow), 4,
-                (SICF_FGC << SBTML_SICF_SHIFT) |
-                (SICF_CLOCK_EN << SBTML_SICF_SHIFT));
-        udelay(1);
-
-        /* leave clock enabled */
-        brcmf_sdcard_reg_write(sdiodev, CORE_SB(corebase, sbtmstatelow), 4,
-                (SICF_CLOCK_EN << SBTML_SICF_SHIFT));
-        udelay(1);
-}
-
 static int brcmf_sdbrcm_download_state(struct brcmf_bus *bus, bool enter)
 {
         uint retries;
-        u32 regdata;
         int bcmerror = 0;
+        struct chip_info *ci = bus->ci;
 
         /* To enter download state, disable ARM and reset SOCRAM.
          * To exit download state, simply reset ARM (default is RAM boot).
@@ -3346,10 +3103,9 @@ static int brcmf_sdbrcm_download_state(struct brcmf_bus *bus, bool enter)
         if (enter) {
                 bus->alp_only = true;
 
-                brcmf_sdbrcm_chip_disablecore(bus->sdiodev,
-                                              bus->ci->armcorebase);
+                ci->coredisable(bus->sdiodev, ci, BCMA_CORE_ARM_CM3);
 
-                brcmf_sdbrcm_chip_resetcore(bus->sdiodev, bus->ci->ramcorebase);
+                ci->resetcore(bus->sdiodev, ci, BCMA_CORE_INTERNAL_MEM);
 
                 /* Clear the top bit of memory */
                 if (bus->ramsize) {
@@ -3358,11 +3114,7 @@ static int brcmf_sdbrcm_download_state(struct brcmf_bus *bus, bool enter)
                                          (u8 *)&zeros, 4);
                 }
         } else {
-                regdata = brcmf_sdcard_reg_read(bus->sdiodev,
-                        CORE_SB(bus->ci->ramcorebase, sbtmstatelow), 4);
-                regdata &= (SBTML_RESET | SBTML_REJ_MASK |
-                        (SICF_CLOCK_EN << SBTML_SICF_SHIFT));
-                if ((SICF_CLOCK_EN << SBTML_SICF_SHIFT) != regdata) {
+                if (!ci->iscoreup(bus->sdiodev, ci, BCMA_CORE_INTERNAL_MEM)) {
                         brcmf_dbg(ERROR, "SOCRAM core is down after reset?\n");
                         bcmerror = -EBADE;
                         goto fail;
@@ -3377,7 +3129,7 @@ static int brcmf_sdbrcm_download_state(struct brcmf_bus *bus, bool enter)
                 w_sdreg32(bus, 0xFFFFFFFF,
                           offsetof(struct sdpcmd_regs, intstatus), &retries);
 
-                brcmf_sdbrcm_chip_resetcore(bus->sdiodev, bus->ci->armcorebase);
+                ci->resetcore(bus->sdiodev, ci, BCMA_CORE_ARM_CM3);
 
                 /* Allow HT Clock now that the ARM is running. */
                 bus->alp_only = false;
@@ -3661,11 +3413,7 @@ void brcmf_sdbrcm_bus_stop(struct brcmf_bus *bus)
         /* Clear any held glomming stuff */
         if (bus->glomd)
                 brcmu_pkt_buf_free_skb(bus->glomd);
-
-        if (bus->glom)
-                brcmu_pkt_buf_free_skb(bus->glom);
-
-        bus->glom = bus->glomd = NULL;
+        brcmf_sdbrcm_free_glom(bus);
 
         /* Clear rx control and wake any waiters */
         bus->rxlen = 0;
@@ -3950,269 +3698,6 @@ fail:
         return false;
 }
 
-/* SDIO Pad drive strength to select value mappings */
-struct sdiod_drive_str {
-        u8 strength;    /* Pad Drive Strength in mA */
-        u8 sel;         /* Chip-specific select value */
-};
-
-/* SDIO Drive Strength to sel value table for PMU Rev 1 */
-static const struct sdiod_drive_str sdiod_drive_strength_tab1[] = {
-        {
-        4, 0x2}, {
-        2, 0x3}, {
-        1, 0x0}, {
-        0, 0x0}
-        };
-
-/* SDIO Drive Strength to sel value table for PMU Rev 2, 3 */
-static const struct sdiod_drive_str sdiod_drive_strength_tab2[] = {
-        {
-        12, 0x7}, {
-        10, 0x6}, {
-        8, 0x5}, {
-        6, 0x4}, {
-        4, 0x2}, {
-        2, 0x1}, {
-        0, 0x0}
-        };
-
-/* SDIO Drive Strength to sel value table for PMU Rev 8 (1.8V) */
-static const struct sdiod_drive_str sdiod_drive_strength_tab3[] = {
-        {
-        32, 0x7}, {
-        26, 0x6}, {
-        22, 0x5}, {
-        16, 0x4}, {
-        12, 0x3}, {
-        8, 0x2}, {
-        4, 0x1}, {
-        0, 0x0}
-        };
-
-#define SDIOD_DRVSTR_KEY(chip, pmu)     (((chip) << 16) | (pmu))
-
-static char *brcmf_chipname(uint chipid, char *buf, uint len)
-{
-        const char *fmt;
-
-        fmt = ((chipid > 0xa000) || (chipid < 0x4000)) ? "%d" : "%x";
-        snprintf(buf, len, fmt, chipid);
-        return buf;
-}
-
-static void brcmf_sdbrcm_sdiod_drive_strength_init(struct brcmf_bus *bus,
-                                                   u32 drivestrength) {
-        struct sdiod_drive_str *str_tab = NULL;
-        u32 str_mask = 0;
-        u32 str_shift = 0;
-        char chn[8];
-
-        if (!(bus->ci->cccaps & CC_CAP_PMU))
-                return;
-
-        switch (SDIOD_DRVSTR_KEY(bus->ci->chip, bus->ci->pmurev)) {
-        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 1):
-                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab1;
-                str_mask = 0x30000000;
-                str_shift = 28;
-                break;
-        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 2):
-        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 3):
-                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab2;
-                str_mask = 0x00003800;
-                str_shift = 11;
-                break;
-        case SDIOD_DRVSTR_KEY(BCM4336_CHIP_ID, 8):
-                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab3;
-                str_mask = 0x00003800;
-                str_shift = 11;
-                break;
-        default:
-                brcmf_dbg(ERROR, "No SDIO Drive strength init done for chip %s rev %d pmurev %d\n",
-                          brcmf_chipname(bus->ci->chip, chn, 8),
-                          bus->ci->chiprev, bus->ci->pmurev);
-                break;
-        }
-
-        if (str_tab != NULL) {
-                u32 drivestrength_sel = 0;
-                u32 cc_data_temp;
-                int i;
-
-                for (i = 0; str_tab[i].strength != 0; i++) {
-                        if (drivestrength >= str_tab[i].strength) {
-                                drivestrength_sel = str_tab[i].sel;
-                                break;
-                        }
-                }
-
-                brcmf_sdcard_reg_write(bus->sdiodev,
-                        CORE_CC_REG(bus->ci->cccorebase, chipcontrol_addr),
-                        4, 1);
-                cc_data_temp = brcmf_sdcard_reg_read(bus->sdiodev,
-                        CORE_CC_REG(bus->ci->cccorebase, chipcontrol_addr), 4);
-                cc_data_temp &= ~str_mask;
-                drivestrength_sel <<= str_shift;
-                cc_data_temp |= drivestrength_sel;
-                brcmf_sdcard_reg_write(bus->sdiodev,
-                        CORE_CC_REG(bus->ci->cccorebase, chipcontrol_addr),
-                        4, cc_data_temp);
-
-                brcmf_dbg(INFO, "SDIO: %dmA drive strength selected, set to 0x%08x\n",
-                          drivestrength, cc_data_temp);
-        }
-}
-
-static int
-brcmf_sdbrcm_chip_recognition(struct brcmf_sdio_dev *sdiodev,
-                              struct chip_info *ci, u32 regs)
-{
-        u32 regdata;
-
-        /*
-         * Get CC core rev
-         * Chipid is assume to be at offset 0 from regs arg
-         * For different chiptypes or old sdio hosts w/o chipcommon,
-         * other ways of recognition should be added here.
-         */
-        ci->cccorebase = regs;
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                CORE_CC_REG(ci->cccorebase, chipid), 4);
-        ci->chip = regdata & CID_ID_MASK;
-        ci->chiprev = (regdata & CID_REV_MASK) >> CID_REV_SHIFT;
-
-        brcmf_dbg(INFO, "chipid=0x%x chiprev=%d\n", ci->chip, ci->chiprev);
-
-        /* Address of cores for new chips should be added here */
-        switch (ci->chip) {
-        case BCM4329_CHIP_ID:
-                ci->buscorebase = BCM4329_CORE_BUS_BASE;
-                ci->ramcorebase = BCM4329_CORE_SOCRAM_BASE;
-                ci->armcorebase = BCM4329_CORE_ARM_BASE;
-                ci->ramsize = BCM4329_RAMSIZE;
-                break;
-        default:
-                brcmf_dbg(ERROR, "chipid 0x%x is not supported\n", ci->chip);
-                return -ENODEV;
-        }
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                CORE_SB(ci->cccorebase, sbidhigh), 4);
-        ci->ccrev = SBCOREREV(regdata);
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                CORE_CC_REG(ci->cccorebase, pmucapabilities), 4);
-        ci->pmurev = regdata & PCAP_REV_MASK;
-
-        regdata = brcmf_sdcard_reg_read(sdiodev,
-                                        CORE_SB(ci->buscorebase, sbidhigh), 4);
-        ci->buscorerev = SBCOREREV(regdata);
-        ci->buscoretype = (regdata & SBIDH_CC_MASK) >> SBIDH_CC_SHIFT;
-
-        brcmf_dbg(INFO, "ccrev=%d, pmurev=%d, buscore rev/type=%d/0x%x\n",
-                  ci->ccrev, ci->pmurev, ci->buscorerev, ci->buscoretype);
-
-        /* get chipcommon capabilites */
-        ci->cccaps = brcmf_sdcard_reg_read(sdiodev,
-                CORE_CC_REG(ci->cccorebase, capabilities), 4);
-
-        return 0;
-}
-
-static int
-brcmf_sdbrcm_chip_attach(struct brcmf_bus *bus, u32 regs)
-{
-        struct chip_info *ci;
-        int err;
-        u8 clkval, clkset;
-
-        brcmf_dbg(TRACE, "Enter\n");
-
-        /* alloc chip_info_t */
-        ci = kzalloc(sizeof(struct chip_info), GFP_ATOMIC);
-        if (NULL == ci)
-                return -ENOMEM;
-
-        /* bus/core/clk setup for register access */
-        /* Try forcing SDIO core to do ALPAvail request only */
-        clkset = SBSDIO_FORCE_HW_CLKREQ_OFF | SBSDIO_ALP_AVAIL_REQ;
-        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                               SBSDIO_FUNC1_CHIPCLKCSR, clkset, &err);
-        if (err) {
-                brcmf_dbg(ERROR, "error writing for HT off\n");
-                goto fail;
-        }
-
-        /* If register supported, wait for ALPAvail and then force ALP */
-        /* This may take up to 15 milliseconds */
-        clkval = brcmf_sdcard_cfg_read(bus->sdiodev, SDIO_FUNC_1,
-                        SBSDIO_FUNC1_CHIPCLKCSR, NULL);
-        if ((clkval & ~SBSDIO_AVBITS) == clkset) {
-                SPINWAIT(((clkval =
-                                brcmf_sdcard_cfg_read(bus->sdiodev, SDIO_FUNC_1,
-                                                SBSDIO_FUNC1_CHIPCLKCSR,
-                                                NULL)),
-                                !SBSDIO_ALPAV(clkval)),
-                                PMU_MAX_TRANSITION_DLY);
-                if (!SBSDIO_ALPAV(clkval)) {
-                        brcmf_dbg(ERROR, "timeout on ALPAV wait, clkval 0x%02x\n",
-                                  clkval);
-                        err = -EBUSY;
-                        goto fail;
-                }
-                clkset = SBSDIO_FORCE_HW_CLKREQ_OFF |
-                                SBSDIO_FORCE_ALP;
-                brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                                SBSDIO_FUNC1_CHIPCLKCSR,
-                                clkset, &err);
-                udelay(65);
-        } else {
-                brcmf_dbg(ERROR, "ChipClkCSR access: wrote 0x%02x read 0x%02x\n",
-                          clkset, clkval);
-                err = -EACCES;
-                goto fail;
-        }
-
-        /* Also, disable the extra SDIO pull-ups */
-        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                               SBSDIO_FUNC1_SDIOPULLUP, 0, NULL);
-
-        err = brcmf_sdbrcm_chip_recognition(bus->sdiodev, ci, regs);
-        if (err)
-                goto fail;
-
-        /*
-         * Make sure any on-chip ARM is off (in case strapping is wrong),
-         * or downloaded code was already running.
-         */
-        brcmf_sdbrcm_chip_disablecore(bus->sdiodev, ci->armcorebase);
-
-        brcmf_sdcard_reg_write(bus->sdiodev,
-                CORE_CC_REG(ci->cccorebase, gpiopullup), 4, 0);
-        brcmf_sdcard_reg_write(bus->sdiodev,
-                CORE_CC_REG(ci->cccorebase, gpiopulldown), 4, 0);
-
-        /* Disable F2 to clear any intermediate frame state on the dongle */
-        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_0, SDIO_CCCR_IOEx,
-                SDIO_FUNC_ENABLE_1, NULL);
-
-        /* WAR: cmd52 backplane read so core HW will drop ALPReq */
-        clkval = brcmf_sdcard_cfg_read(bus->sdiodev, SDIO_FUNC_1,
-                        0, NULL);
-
-        /* Done with backplane-dependent accesses, can drop clock... */
-        brcmf_sdcard_cfg_write(bus->sdiodev, SDIO_FUNC_1,
-                               SBSDIO_FUNC1_CHIPCLKCSR, 0, NULL);
-
-        bus->ci = ci;
-        return 0;
-fail:
-        bus->ci = NULL;
-        kfree(ci);
-        return err;
-}
-
 static bool
 brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
 {
@@ -4220,6 +3705,7 @@ brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
         int err = 0;
         int reg_addr;
         u32 reg_val;
+        u8 idx;
 
         bus->alp_only = true;
 
@@ -4234,7 +3720,7 @@ brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
 #endif                          /* BCMDBG */
 
         /*
-         * Force PLL off until brcmf_sdbrcm_chip_attach()
+         * Force PLL off until brcmf_sdio_chip_attach()
          * programs PLL control regs
          */
 
@@ -4252,8 +3738,8 @@ brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
                 goto fail;
         }
 
-        if (brcmf_sdbrcm_chip_attach(bus, regsva)) {
-                brcmf_dbg(ERROR, "brcmf_sdbrcm_chip_attach failed!\n");
+        if (brcmf_sdio_chip_attach(bus->sdiodev, &bus->ci, regsva)) {
+                brcmf_dbg(ERROR, "brcmf_sdio_chip_attach failed!\n");
                 goto fail;
         }
 
@@ -4262,11 +3748,10 @@ brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
                 goto fail;
         }
 
-        brcmf_sdbrcm_sdiod_drive_strength_init(bus, SDIO_DRIVE_STRENGTH);
+        brcmf_sdio_chip_drivestrengthinit(bus->sdiodev, bus->ci,
+                                          SDIO_DRIVE_STRENGTH);
 
-        /* Get info on the ARM and SOCRAM cores... */
-        brcmf_sdcard_reg_read(bus->sdiodev,
-                  CORE_SB(bus->ci->armcorebase, sbidhigh), 4);
+        /* Get info on the SOCRAM cores... */
         bus->ramsize = bus->ci->ramsize;
         if (!(bus->ramsize)) {
                 brcmf_dbg(ERROR, "failed to find SOCRAM memory!\n");
@@ -4274,7 +3759,8 @@ brcmf_sdbrcm_probe_attach(struct brcmf_bus *bus, u32 regsva)
         }
 
         /* Set core control so an SDIO reset does a backplane reset */
-        reg_addr = bus->ci->buscorebase +
+        idx = brcmf_sdio_chip_getinfidx(bus->ci, BCMA_CORE_SDIO_DEV);
+        reg_addr = bus->ci->c_inf[idx].base +
                    offsetof(struct sdpcmd_regs, corecontrol);
         reg_val = brcmf_sdcard_reg_read(bus->sdiodev, reg_addr, sizeof(u32));
         brcmf_sdcard_reg_write(bus->sdiodev, reg_addr, sizeof(u32),
@@ -4364,15 +3850,6 @@ brcmf_sdbrcm_watchdog(unsigned long data)
         }
 }
 
-static void
-brcmf_sdbrcm_chip_detach(struct brcmf_bus *bus)
-{
-        brcmf_dbg(TRACE, "Enter\n");
-
-        kfree(bus->ci);
-        bus->ci = NULL;
-}
-
 static void brcmf_sdbrcm_release_dongle(struct brcmf_bus *bus)
 {
         brcmf_dbg(TRACE, "Enter\n");
@@ -4380,7 +3857,7 @@ static void brcmf_sdbrcm_release_dongle(struct brcmf_bus *bus)
         if (bus->ci) {
                 brcmf_sdbrcm_clkctl(bus, CLK_AVAIL, false);
                 brcmf_sdbrcm_clkctl(bus, CLK_NONE, false);
-                brcmf_sdbrcm_chip_detach(bus);
+                brcmf_sdio_chip_detach(&bus->ci);
                 if (bus->vars && bus->varsz)
                         kfree(bus->vars);
                 bus->vars = NULL;
@@ -4440,6 +3917,7 @@ void *brcmf_sdbrcm_probe(u16 bus_no, u16 slot, u16 func, uint bustype,
 
         bus->sdiodev = sdiodev;
         sdiodev->bus = bus;
+        skb_queue_head_init(&bus->glom);
         bus->txbound = BRCMF_TXBOUND;
         bus->rxbound = BRCMF_RXBOUND;
         bus->txminmax = BRCMF_TXMINMAX;
@@ -4521,9 +3999,10 @@ void *brcmf_sdbrcm_probe(u16 bus_no, u16 slot, u16 func, uint bustype,
                         goto fail;
                 }
         }
-        /* Ok, have the per-port tell the stack we're open for business */
-        if (brcmf_net_attach(bus->drvr, 0) != 0) {
-                brcmf_dbg(ERROR, "Net attach failed!!\n");
+
+        /* add interface and open for business */
+        if (brcmf_add_if((struct brcmf_info *)bus->drvr, 0, "wlan%d", NULL)) {
+                brcmf_dbg(ERROR, "Add primary net device interface failed!!\n");
                 goto fail;
         }
 
@@ -4554,10 +4033,6 @@ struct device *brcmf_bus_get_device(struct brcmf_bus *bus)
 void
 brcmf_sdbrcm_wd_timer(struct brcmf_bus *bus, uint wdtick)
 {
-        /* don't start the wd until fw is loaded */
-        if (bus->drvr->busstate == BRCMF_BUS_DOWN)
-                return;
-
         /* Totally stop the timer */
         if (!wdtick && bus->wd_timer_valid == true) {
                 del_timer_sync(&bus->timer);
@@ -4566,6 +4041,10 @@ brcmf_sdbrcm_wd_timer(struct brcmf_bus *bus, uint wdtick)
                 return;
         }
 
+        /* don't start the wd until fw is loaded */
+        if (bus->drvr->busstate == BRCMF_BUS_DOWN)
+                return;
+
         if (wdtick) {
                 if (bus->save_ms != BRCMF_WD_POLL_MS) {
                         if (bus->wd_timer_valid == true)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c
new file mode 100644
index 000000000000..f6b1822031fe
--- /dev/null
+++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c
@@ -0,0 +1,622 @@
+/*
+ * Copyright (c) 2011 Broadcom Corporation
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
+ * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
+ * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+/* ***** SDIO interface chip backplane handle functions ***** */
+
+#include <linux/types.h>
+#include <linux/netdevice.h>
+#include <linux/mmc/card.h>
+#include <linux/ssb/ssb_regs.h>
+#include <linux/bcma/bcma.h>
+
+#include <chipcommon.h>
+#include <brcm_hw_ids.h>
+#include <brcmu_wifi.h>
+#include <brcmu_utils.h>
+#include <soc.h>
+#include "dhd.h"
+#include "dhd_dbg.h"
+#include "sdio_host.h"
+#include "sdio_chip.h"
+
+/* chip core base & ramsize */
+/* bcm4329 */
+/* SDIO device core, ID 0x829 */
+#define BCM4329_CORE_BUS_BASE           0x18011000
+/* internal memory core, ID 0x80e */
+#define BCM4329_CORE_SOCRAM_BASE        0x18003000
+/* ARM Cortex M3 core, ID 0x82a */
+#define BCM4329_CORE_ARM_BASE           0x18002000
+#define BCM4329_RAMSIZE                 0x48000
+
+#define SBCOREREV(sbidh) \
+        ((((sbidh) & SSB_IDHIGH_RCHI) >> SSB_IDHIGH_RCHI_SHIFT) | \
+          ((sbidh) & SSB_IDHIGH_RCLO))
+
+/* SOC Interconnect types (aka chip types) */
+#define SOCI_SB         0
+#define SOCI_AI         1
+
+/* EROM CompIdentB */
+#define CIB_REV_MASK            0xff000000
+#define CIB_REV_SHIFT           24
+
+#define SDIOD_DRVSTR_KEY(chip, pmu)     (((chip) << 16) | (pmu))
+/* SDIO Pad drive strength to select value mappings */
+struct sdiod_drive_str {
+        u8 strength;    /* Pad Drive Strength in mA */
+        u8 sel;         /* Chip-specific select value */
+};
+/* SDIO Drive Strength to sel value table for PMU Rev 1 */
+static const struct sdiod_drive_str sdiod_drive_strength_tab1[] = {
+        {
+        4, 0x2}, {
+        2, 0x3}, {
+        1, 0x0}, {
+        0, 0x0}
+        };
+/* SDIO Drive Strength to sel value table for PMU Rev 2, 3 */
+static const struct sdiod_drive_str sdiod_drive_strength_tab2[] = {
+        {
+        12, 0x7}, {
+        10, 0x6}, {
+        8, 0x5}, {
+        6, 0x4}, {
+        4, 0x2}, {
+        2, 0x1}, {
+        0, 0x0}
+        };
+/* SDIO Drive Strength to sel value table for PMU Rev 8 (1.8V) */
+static const struct sdiod_drive_str sdiod_drive_strength_tab3[] = {
+        {
+        32, 0x7}, {
+        26, 0x6}, {
+        22, 0x5}, {
+        16, 0x4}, {
+        12, 0x3}, {
+        8, 0x2}, {
+        4, 0x1}, {
+        0, 0x0}
+        };
+
+u8
+brcmf_sdio_chip_getinfidx(struct chip_info *ci, u16 coreid)
+{
+        u8 idx;
+
+        for (idx = 0; idx < BRCMF_MAX_CORENUM; idx++)
+                if (coreid == ci->c_inf[idx].id)
+                        return idx;
+
+        return BRCMF_MAX_CORENUM;
+}
+
+static u32
+brcmf_sdio_sb_corerev(struct brcmf_sdio_dev *sdiodev,
+                      struct chip_info *ci, u16 coreid)
+{
+        u32 regdata;
+        u8 idx;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbidhigh), 4);
+        return SBCOREREV(regdata);
+}
+
+static u32
+brcmf_sdio_ai_corerev(struct brcmf_sdio_dev *sdiodev,
+                      struct chip_info *ci, u16 coreid)
+{
+        u8 idx;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        return (ci->c_inf[idx].cib & CIB_REV_MASK) >> CIB_REV_SHIFT;
+}
+
+static bool
+brcmf_sdio_sb_iscoreup(struct brcmf_sdio_dev *sdiodev,
+                       struct chip_info *ci, u16 coreid)
+{
+        u32 regdata;
+        u8 idx;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        regdata &= (SSB_TMSLOW_RESET | SSB_TMSLOW_REJECT |
+                    SSB_IMSTATE_REJECT | SSB_TMSLOW_CLOCK);
+        return (SSB_TMSLOW_CLOCK == regdata);
+}
+
+static bool
+brcmf_sdio_ai_iscoreup(struct brcmf_sdio_dev *sdiodev,
+                       struct chip_info *ci, u16 coreid)
+{
+        u32 regdata;
+        u8 idx;
+        bool ret;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_IOCTL, 4);
+        ret = (regdata & (BCMA_IOCTL_FGC | BCMA_IOCTL_CLK)) == BCMA_IOCTL_CLK;
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_RESET_CTL,
+                                        4);
+        ret = ret && ((regdata & BCMA_RESET_CTL_RESET) == 0);
+
+        return ret;
+}
+
+static void
+brcmf_sdio_sb_coredisable(struct brcmf_sdio_dev *sdiodev,
+                          struct chip_info *ci, u16 coreid)
+{
+        u32 regdata;
+        u8 idx;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        if (regdata & SSB_TMSLOW_RESET)
+                return;
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        if ((regdata & SSB_TMSLOW_CLOCK) != 0) {
+                /*
+                 * set target reject and spin until busy is clear
+                 * (preserve core-specific bits)
+                 */
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+                brcmf_sdcard_reg_write(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbtmstatelow),
+                                4, regdata | SSB_TMSLOW_REJECT);
+
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+                udelay(1);
+                SPINWAIT((brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatehigh), 4) &
+                        SSB_TMSHIGH_BUSY), 100000);
+
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatehigh), 4);
+                if (regdata & SSB_TMSHIGH_BUSY)
+                        brcmf_dbg(ERROR, "core state still busy\n");
+
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbidlow), 4);
+                if (regdata & SSB_IDLOW_INITIATOR) {
+                        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4) |
+                                SSB_IMSTATE_REJECT;
+                        brcmf_sdcard_reg_write(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4,
+                                regdata);
+                        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4);
+                        udelay(1);
+                        SPINWAIT((brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4) &
+                                SSB_IMSTATE_BUSY), 100000);
+                }
+
+                /* set reset and reject while enabling the clocks */
+                brcmf_sdcard_reg_write(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4,
+                        (SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK |
+                        SSB_TMSLOW_REJECT | SSB_TMSLOW_RESET));
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+                udelay(10);
+
+                /* clear the initiator reject bit */
+                regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbidlow), 4);
+                if (regdata & SSB_IDLOW_INITIATOR) {
+                        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4) &
+                                ~SSB_IMSTATE_REJECT;
+                        brcmf_sdcard_reg_write(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4,
+                                regdata);
+                }
+        }
+
+        /* leave reset and reject asserted */
+        brcmf_sdcard_reg_write(sdiodev,
+                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4,
+                (SSB_TMSLOW_REJECT | SSB_TMSLOW_RESET));
+        udelay(1);
+}
+
+static void
+brcmf_sdio_ai_coredisable(struct brcmf_sdio_dev *sdiodev,
+                          struct chip_info *ci, u16 coreid)
+{
+        u8 idx;
+        u32 regdata;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        /* if core is already in reset, just return */
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_RESET_CTL,
+                                        4);
+        if ((regdata & BCMA_RESET_CTL_RESET) != 0)
+                return;
+
+        brcmf_sdcard_reg_write(sdiodev, ci->c_inf[idx].wrapbase+BCMA_IOCTL,
+                               4, 0);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_IOCTL, 4);
+        udelay(10);
+
+        brcmf_sdcard_reg_write(sdiodev, ci->c_inf[idx].wrapbase+BCMA_RESET_CTL,
+                               4, BCMA_RESET_CTL_RESET);
+        udelay(1);
+}
+
+static void
+brcmf_sdio_sb_resetcore(struct brcmf_sdio_dev *sdiodev,
+                        struct chip_info *ci, u16 coreid)
+{
+        u32 regdata;
+        u8 idx;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        /*
+         * Must do the disable sequence first to work for
+         * arbitrary current core state.
+         */
+        brcmf_sdio_sb_coredisable(sdiodev, ci, coreid);
+
+        /*
+         * Now do the initialization sequence.
+         * set reset while enabling the clock and
+         * forcing them on throughout the core
+         */
+        brcmf_sdcard_reg_write(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4,
+                        SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK | SSB_TMSLOW_RESET);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        udelay(1);
+
+        /* clear any serror */
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbtmstatehigh), 4);
+        if (regdata & SSB_TMSHIGH_SERR)
+                brcmf_sdcard_reg_write(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbtmstatehigh), 4, 0);
+
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbimstate), 4);
+        if (regdata & (SSB_IMSTATE_IBE | SSB_IMSTATE_TO))
+                brcmf_sdcard_reg_write(sdiodev,
+                        CORE_SB(ci->c_inf[idx].base, sbimstate), 4,
+                        regdata & ~(SSB_IMSTATE_IBE | SSB_IMSTATE_TO));
+
+        /* clear reset and allow it to propagate throughout the core */
+        brcmf_sdcard_reg_write(sdiodev,
+                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4,
+                SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        udelay(1);
+
+        /* leave clock enabled */
+        brcmf_sdcard_reg_write(sdiodev,
+                               CORE_SB(ci->c_inf[idx].base, sbtmstatelow),
+                               4, SSB_TMSLOW_CLOCK);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                CORE_SB(ci->c_inf[idx].base, sbtmstatelow), 4);
+        udelay(1);
+}
+
+static void
+brcmf_sdio_ai_resetcore(struct brcmf_sdio_dev *sdiodev,
+                        struct chip_info *ci, u16 coreid)
+{
+        u8 idx;
+        u32 regdata;
+
+        idx = brcmf_sdio_chip_getinfidx(ci, coreid);
+
+        /* must disable first to work for arbitrary current core state */
+        brcmf_sdio_ai_coredisable(sdiodev, ci, coreid);
+
+        /* now do initialization sequence */
+        brcmf_sdcard_reg_write(sdiodev, ci->c_inf[idx].wrapbase+BCMA_IOCTL,
+                               4, BCMA_IOCTL_FGC | BCMA_IOCTL_CLK);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_IOCTL, 4);
+        brcmf_sdcard_reg_write(sdiodev, ci->c_inf[idx].wrapbase+BCMA_RESET_CTL,
+                               4, 0);
+        udelay(1);
+
+        brcmf_sdcard_reg_write(sdiodev, ci->c_inf[idx].wrapbase+BCMA_IOCTL,
+                               4, BCMA_IOCTL_CLK);
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                                        ci->c_inf[idx].wrapbase+BCMA_IOCTL, 4);
+        udelay(1);
+}
+
+static int brcmf_sdio_chip_recognition(struct brcmf_sdio_dev *sdiodev,
+                                       struct chip_info *ci, u32 regs)
+{
+        u32 regdata;
+
+        /*
+         * Get CC core rev
+         * Chipid is assume to be at offset 0 from regs arg
+         * For different chiptypes or old sdio hosts w/o chipcommon,
+         * other ways of recognition should be added here.
+         */
+        ci->c_inf[0].id = BCMA_CORE_CHIPCOMMON;
+        ci->c_inf[0].base = regs;
+        regdata = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_CC_REG(ci->c_inf[0].base, chipid), 4);
+        ci->chip = regdata & CID_ID_MASK;
+        ci->chiprev = (regdata & CID_REV_MASK) >> CID_REV_SHIFT;
+        ci->socitype = (regdata & CID_TYPE_MASK) >> CID_TYPE_SHIFT;
+
+        brcmf_dbg(INFO, "chipid=0x%x chiprev=%d\n", ci->chip, ci->chiprev);
+
+        /* Address of cores for new chips should be added here */
+        switch (ci->chip) {
+        case BCM4329_CHIP_ID:
+                ci->c_inf[1].id = BCMA_CORE_SDIO_DEV;
+                ci->c_inf[1].base = BCM4329_CORE_BUS_BASE;
+                ci->c_inf[2].id = BCMA_CORE_INTERNAL_MEM;
+                ci->c_inf[2].base = BCM4329_CORE_SOCRAM_BASE;
+                ci->c_inf[3].id = BCMA_CORE_ARM_CM3;
+                ci->c_inf[3].base = BCM4329_CORE_ARM_BASE;
+                ci->ramsize = BCM4329_RAMSIZE;
+                break;
+        default:
+                brcmf_dbg(ERROR, "chipid 0x%x is not supported\n", ci->chip);
+                return -ENODEV;
+        }
+
+        switch (ci->socitype) {
+        case SOCI_SB:
+                ci->iscoreup = brcmf_sdio_sb_iscoreup;
+                ci->corerev = brcmf_sdio_sb_corerev;
+                ci->coredisable = brcmf_sdio_sb_coredisable;
+                ci->resetcore = brcmf_sdio_sb_resetcore;
+                break;
+        case SOCI_AI:
+                ci->iscoreup = brcmf_sdio_ai_iscoreup;
+                ci->corerev = brcmf_sdio_ai_corerev;
+                ci->coredisable = brcmf_sdio_ai_coredisable;
+                ci->resetcore = brcmf_sdio_ai_resetcore;
+                break;
+        default:
+                brcmf_dbg(ERROR, "socitype %u not supported\n", ci->socitype);
+                return -ENODEV;
+        }
+
+        return 0;
+}
+
+static int
+brcmf_sdio_chip_buscoreprep(struct brcmf_sdio_dev *sdiodev)
+{
+        int err = 0;
+        u8 clkval, clkset;
+
+        /* Try forcing SDIO core to do ALPAvail request only */
+        clkset = SBSDIO_FORCE_HW_CLKREQ_OFF | SBSDIO_ALP_AVAIL_REQ;
+        brcmf_sdcard_cfg_write(sdiodev, SDIO_FUNC_1,
+                               SBSDIO_FUNC1_CHIPCLKCSR, clkset, &err);
+        if (err) {
+                brcmf_dbg(ERROR, "error writing for HT off\n");
+                return err;
+        }
+
+        /* If register supported, wait for ALPAvail and then force ALP */
+        /* This may take up to 15 milliseconds */
+        clkval = brcmf_sdcard_cfg_read(sdiodev, SDIO_FUNC_1,
+                                       SBSDIO_FUNC1_CHIPCLKCSR, NULL);
+
+        if ((clkval & ~SBSDIO_AVBITS) != clkset) {
+                brcmf_dbg(ERROR, "ChipClkCSR access: wrote 0x%02x read 0x%02x\n",
+                          clkset, clkval);
+                return -EACCES;
+        }
+
+        SPINWAIT(((clkval = brcmf_sdcard_cfg_read(sdiodev, SDIO_FUNC_1,
+                                SBSDIO_FUNC1_CHIPCLKCSR, NULL)),
+                        !SBSDIO_ALPAV(clkval)),
+                        PMU_MAX_TRANSITION_DLY);
+        if (!SBSDIO_ALPAV(clkval)) {
+                brcmf_dbg(ERROR, "timeout on ALPAV wait, clkval 0x%02x\n",
+                          clkval);
+                return -EBUSY;
+        }
+
+        clkset = SBSDIO_FORCE_HW_CLKREQ_OFF | SBSDIO_FORCE_ALP;
+        brcmf_sdcard_cfg_write(sdiodev, SDIO_FUNC_1,
+                               SBSDIO_FUNC1_CHIPCLKCSR, clkset, &err);
+        udelay(65);
+
+        /* Also, disable the extra SDIO pull-ups */
+        brcmf_sdcard_cfg_write(sdiodev, SDIO_FUNC_1,
+                               SBSDIO_FUNC1_SDIOPULLUP, 0, NULL);
+
+        return 0;
+}
+
+static void
+brcmf_sdio_chip_buscoresetup(struct brcmf_sdio_dev *sdiodev,
+                             struct chip_info *ci)
+{
+        /* get chipcommon rev */
+        ci->c_inf[0].rev = ci->corerev(sdiodev, ci, ci->c_inf[0].id);
+
+        /* get chipcommon capabilites */
+        ci->c_inf[0].caps =
+                brcmf_sdcard_reg_read(sdiodev,
+                CORE_CC_REG(ci->c_inf[0].base, capabilities), 4);
+
+        /* get pmu caps & rev */
+        if (ci->c_inf[0].caps & CC_CAP_PMU) {
+                ci->pmucaps = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_CC_REG(ci->c_inf[0].base, pmucapabilities), 4);
+                ci->pmurev = ci->pmucaps & PCAP_REV_MASK;
+        }
+
+        ci->c_inf[1].rev = ci->corerev(sdiodev, ci, ci->c_inf[1].id);
+
+        brcmf_dbg(INFO, "ccrev=%d, pmurev=%d, buscore rev/type=%d/0x%x\n",
+                  ci->c_inf[0].rev, ci->pmurev,
+                  ci->c_inf[1].rev, ci->c_inf[1].id);
+
+        /*
+         * Make sure any on-chip ARM is off (in case strapping is wrong),
+         * or downloaded code was already running.
+         */
+        ci->coredisable(sdiodev, ci, BCMA_CORE_ARM_CM3);
+}
+
+int brcmf_sdio_chip_attach(struct brcmf_sdio_dev *sdiodev,
+                           struct chip_info **ci_ptr, u32 regs)
+{
+        int ret;
+        struct chip_info *ci;
+
+        brcmf_dbg(TRACE, "Enter\n");
+
+        /* alloc chip_info_t */
+        ci = kzalloc(sizeof(struct chip_info), GFP_ATOMIC);
+        if (!ci)
+                return -ENOMEM;
+
+        ret = brcmf_sdio_chip_buscoreprep(sdiodev);
+        if (ret != 0)
+                goto err;
+
+        ret = brcmf_sdio_chip_recognition(sdiodev, ci, regs);
+        if (ret != 0)
+                goto err;
+
+        brcmf_sdio_chip_buscoresetup(sdiodev, ci);
+
+        brcmf_sdcard_reg_write(sdiodev,
+                CORE_CC_REG(ci->c_inf[0].base, gpiopullup), 4, 0);
+        brcmf_sdcard_reg_write(sdiodev,
+                CORE_CC_REG(ci->c_inf[0].base, gpiopulldown), 4, 0);
+
+        *ci_ptr = ci;
+        return 0;
+
+err:
+        kfree(ci);
+        return ret;
+}
+
+void
+brcmf_sdio_chip_detach(struct chip_info **ci_ptr)
+{
+        brcmf_dbg(TRACE, "Enter\n");
+
+        kfree(*ci_ptr);
+        *ci_ptr = NULL;
+}
+
+static char *brcmf_sdio_chip_name(uint chipid, char *buf, uint len)
+{
+        const char *fmt;
+
+        fmt = ((chipid > 0xa000) || (chipid < 0x4000)) ? "%d" : "%x";
+        snprintf(buf, len, fmt, chipid);
+        return buf;
+}
+
+void
+brcmf_sdio_chip_drivestrengthinit(struct brcmf_sdio_dev *sdiodev,
+                                  struct chip_info *ci, u32 drivestrength)
+{
+        struct sdiod_drive_str *str_tab = NULL;
+        u32 str_mask = 0;
+        u32 str_shift = 0;
+        char chn[8];
+
+        if (!(ci->c_inf[0].caps & CC_CAP_PMU))
+                return;
+
+        switch (SDIOD_DRVSTR_KEY(ci->chip, ci->pmurev)) {
+        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 1):
+                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab1;
+                str_mask = 0x30000000;
+                str_shift = 28;
+                break;
+        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 2):
+        case SDIOD_DRVSTR_KEY(BCM4325_CHIP_ID, 3):
+                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab2;
+                str_mask = 0x00003800;
+                str_shift = 11;
+                break;
+        case SDIOD_DRVSTR_KEY(BCM4336_CHIP_ID, 8):
+                str_tab = (struct sdiod_drive_str *)&sdiod_drive_strength_tab3;
+                str_mask = 0x00003800;
+                str_shift = 11;
+                break;
+        default:
+                brcmf_dbg(ERROR, "No SDIO Drive strength init done for chip %s rev %d pmurev %d\n",
+                          brcmf_sdio_chip_name(ci->chip, chn, 8),
+                          ci->chiprev, ci->pmurev);
+                break;
+        }
+
+        if (str_tab != NULL) {
+                u32 drivestrength_sel = 0;
+                u32 cc_data_temp;
+                int i;
+
+                for (i = 0; str_tab[i].strength != 0; i++) {
+                        if (drivestrength >= str_tab[i].strength) {
+                                drivestrength_sel = str_tab[i].sel;
+                                break;
+                        }
+                }
+
+                brcmf_sdcard_reg_write(sdiodev,
+                        CORE_CC_REG(ci->c_inf[0].base, chipcontrol_addr),
+                        4, 1);
+                cc_data_temp = brcmf_sdcard_reg_read(sdiodev,
+                        CORE_CC_REG(ci->c_inf[0].base, chipcontrol_addr), 4);
+                cc_data_temp &= ~str_mask;
+                drivestrength_sel <<= str_shift;
+                cc_data_temp |= drivestrength_sel;
+                brcmf_sdcard_reg_write(sdiodev,
+                        CORE_CC_REG(ci->c_inf[0].base, chipcontrol_addr),
+                        4, cc_data_temp);
+
+                brcmf_dbg(INFO, "SDIO: %dmA drive strength selected, set to 0x%08x\n",
+                          drivestrength, cc_data_temp);
+        }
+}
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.h b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.h
new file mode 100644
index 000000000000..ce974d76bd92
--- /dev/null
+++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.h
@@ -0,0 +1,136 @@
+/*
+ * Copyright (c) 2011 Broadcom Corporation
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
+ * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
+ * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#ifndef _BRCMFMAC_SDIO_CHIP_H_
+#define _BRCMFMAC_SDIO_CHIP_H_
+
+/*
+ * Core reg address translation.
+ * Both macro's returns a 32 bits byte address on the backplane bus.
+ */
+#define CORE_CC_REG(base, field) \
+                (base + offsetof(struct chipcregs, field))
+#define CORE_BUS_REG(base, field) \
+                (base + offsetof(struct sdpcmd_regs, field))
+#define CORE_SB(base, field) \
+                (base + SBCONFIGOFF + offsetof(struct sbconfig, field))
+
+/* SDIO function 1 register CHIPCLKCSR */
+/* Force ALP request to backplane */
+#define SBSDIO_FORCE_ALP                0x01
+/* Force HT request to backplane */
+#define SBSDIO_FORCE_HT                 0x02
+/* Force ILP request to backplane */
+#define SBSDIO_FORCE_ILP                0x04
+/* Make ALP ready (power up xtal) */
+#define SBSDIO_ALP_AVAIL_REQ            0x08
+/* Make HT ready (power up PLL) */
+#define SBSDIO_HT_AVAIL_REQ             0x10
+/* Squelch clock requests from HW */
+#define SBSDIO_FORCE_HW_CLKREQ_OFF      0x20
+/* Status: ALP is ready */
+#define SBSDIO_ALP_AVAIL                0x40
+/* Status: HT is ready */
+#define SBSDIO_HT_AVAIL                 0x80
+#define SBSDIO_AVBITS           (SBSDIO_HT_AVAIL | SBSDIO_ALP_AVAIL)
+#define SBSDIO_ALPAV(regval)    ((regval) & SBSDIO_AVBITS)
+#define SBSDIO_HTAV(regval)     (((regval) & SBSDIO_AVBITS) == SBSDIO_AVBITS)
+#define SBSDIO_ALPONLY(regval)  (SBSDIO_ALPAV(regval) && !SBSDIO_HTAV(regval))
+#define SBSDIO_CLKAV(regval, alponly) \
+        (SBSDIO_ALPAV(regval) && (alponly ? 1 : SBSDIO_HTAV(regval)))
+
+#define BRCMF_MAX_CORENUM       6
+
+struct chip_core_info {
+        u16 id;
+        u16 rev;
+        u32 base;
+        u32 wrapbase;
+        u32 caps;
+        u32 cib;
+};
+
+struct chip_info {
+        u32 chip;
+        u32 chiprev;
+        u32 socitype;
+        /* core info */
+        /* always put chipcommon core at 0, bus core at 1 */
+        struct chip_core_info c_inf[BRCMF_MAX_CORENUM];
+        u32 pmurev;
+        u32 pmucaps;
+        u32 ramsize;
+
+        bool (*iscoreup)(struct brcmf_sdio_dev *sdiodev, struct chip_info *ci,
+                         u16 coreid);
+        u32 (*corerev)(struct brcmf_sdio_dev *sdiodev, struct chip_info *ci,
+                         u16 coreid);
+        void (*coredisable)(struct brcmf_sdio_dev *sdiodev,
+                        struct chip_info *ci, u16 coreid);
+        void (*resetcore)(struct brcmf_sdio_dev *sdiodev,
+                        struct chip_info *ci, u16 coreid);
+};
+
+struct sbconfig {
+        u32 PAD[2];
+        u32 sbipsflag;  /* initiator port ocp slave flag */
+        u32 PAD[3];
+        u32 sbtpsflag;  /* target port ocp slave flag */
+        u32 PAD[11];
+        u32 sbtmerrloga;        /* (sonics >= 2.3) */
+        u32 PAD;
+        u32 sbtmerrlog; /* (sonics >= 2.3) */
+        u32 PAD[3];
+        u32 sbadmatch3; /* address match3 */
+        u32 PAD;
+        u32 sbadmatch2; /* address match2 */
+        u32 PAD;
+        u32 sbadmatch1; /* address match1 */
+        u32 PAD[7];
+        u32 sbimstate;  /* initiator agent state */
+        u32 sbintvec;   /* interrupt mask */
+        u32 sbtmstatelow;       /* target state */
+        u32 sbtmstatehigh;      /* target state */
+        u32 sbbwa0;             /* bandwidth allocation table0 */
+        u32 PAD;
+        u32 sbimconfiglow;      /* initiator configuration */
+        u32 sbimconfighigh;     /* initiator configuration */
+        u32 sbadmatch0; /* address match0 */
+        u32 PAD;
+        u32 sbtmconfiglow;      /* target configuration */
+        u32 sbtmconfighigh;     /* target configuration */
+        u32 sbbconfig;  /* broadcast configuration */
+        u32 PAD;
+        u32 sbbstate;   /* broadcast state */
+        u32 PAD[3];
+        u32 sbactcnfg;  /* activate configuration */
+        u32 PAD[3];
+        u32 sbflagst;   /* current sbflags */
+        u32 PAD[3];
+        u32 sbidlow;            /* identification */
+        u32 sbidhigh;   /* identification */
+};
+
+extern int brcmf_sdio_chip_attach(struct brcmf_sdio_dev *sdiodev,
+                                  struct chip_info **ci_ptr, u32 regs);
+extern void brcmf_sdio_chip_detach(struct chip_info **ci_ptr);
+extern void brcmf_sdio_chip_drivestrengthinit(struct brcmf_sdio_dev *sdiodev,
+                                              struct chip_info *ci,
+                                              u32 drivestrength);
+extern u8 brcmf_sdio_chip_getinfidx(struct chip_info *ci, u16 coreid);
+
+
+#endif          /* _BRCMFMAC_SDIO_CHIP_H_ */
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index 5eddabe5228a..cc19a733ac65 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -1997,7 +1997,7 @@ done:
 }
 
 static s32 brcmf_inform_single_bss(struct brcmf_cfg80211_priv *cfg_priv,
-                                   struct brcmf_bss_info *bi)
+                                   struct brcmf_bss_info_le *bi)
 {
         struct wiphy *wiphy = cfg_to_wiphy(cfg_priv);
         struct ieee80211_channel *notify_channel;
@@ -2049,18 +2049,27 @@ static s32 brcmf_inform_single_bss(struct brcmf_cfg80211_priv *cfg_priv,
                 notify_timestamp, notify_capability, notify_interval, notify_ie,
                 notify_ielen, notify_signal, GFP_KERNEL);
 
-        if (!bss) {
-                WL_ERR("cfg80211_inform_bss_frame error\n");
-                return -EINVAL;
-        }
+        if (!bss)
+                return -ENOMEM;
+
+        cfg80211_put_bss(bss);
 
         return err;
 }
 
+static struct brcmf_bss_info_le *
+next_bss_le(struct brcmf_scan_results *list, struct brcmf_bss_info_le *bss)
+{
+        if (bss == NULL)
+                return list->bss_info_le;
+        return (struct brcmf_bss_info_le *)((unsigned long)bss +
+                                            le32_to_cpu(bss->length));
+}
+
 static s32 brcmf_inform_bss(struct brcmf_cfg80211_priv *cfg_priv)
 {
         struct brcmf_scan_results *bss_list;
-        struct brcmf_bss_info *bi = NULL;       /* must be initialized */
+        struct brcmf_bss_info_le *bi = NULL;    /* must be initialized */
         s32 err = 0;
         int i;
 
@@ -2072,7 +2081,7 @@ static s32 brcmf_inform_bss(struct brcmf_cfg80211_priv *cfg_priv)
         }
         WL_SCAN("scanned AP count (%d)\n", bss_list->count);
         for (i = 0; i < bss_list->count && i < WL_AP_MAX; i++) {
-                bi = next_bss(bss_list, bi);
+                bi = next_bss_le(bss_list, bi);
                 err = brcmf_inform_single_bss(cfg_priv, bi);
                 if (err)
                         break;
@@ -2085,8 +2094,9 @@ static s32 wl_inform_ibss(struct brcmf_cfg80211_priv *cfg_priv,
 {
         struct wiphy *wiphy = cfg_to_wiphy(cfg_priv);
         struct ieee80211_channel *notify_channel;
-        struct brcmf_bss_info *bi = NULL;
+        struct brcmf_bss_info_le *bi = NULL;
         struct ieee80211_supported_band *band;
+        struct cfg80211_bss *bss;
         u8 *buf = NULL;
         s32 err = 0;
         u16 channel;
@@ -2114,7 +2124,7 @@ static s32 wl_inform_ibss(struct brcmf_cfg80211_priv *cfg_priv,
                 goto CleanUp;
         }
 
-        bi = (struct brcmf_bss_info *)(buf + 4);
+        bi = (struct brcmf_bss_info_le *)(buf + 4);
 
         channel = bi->ctl_ch ? bi->ctl_ch :
                                 CHSPEC_CHANNEL(le16_to_cpu(bi->chanspec));
@@ -2140,10 +2150,17 @@ static s32 wl_inform_ibss(struct brcmf_cfg80211_priv *cfg_priv,
         WL_CONN("signal: %d\n", notify_signal);
         WL_CONN("notify_timestamp: %#018llx\n", notify_timestamp);
 
-        cfg80211_inform_bss(wiphy, notify_channel, bssid,
+        bss = cfg80211_inform_bss(wiphy, notify_channel, bssid,
                 notify_timestamp, notify_capability, notify_interval,
                 notify_ie, notify_ielen, notify_signal, GFP_KERNEL);
 
+        if (!bss) {
+                err = -ENOMEM;
+                goto CleanUp;
+        }
+
+        cfg80211_put_bss(bss);
+
 CleanUp:
 
         kfree(buf);
@@ -2188,7 +2205,7 @@ static struct brcmf_tlv *brcmf_parse_tlvs(void *buf, int buflen, uint key)
 
 static s32 brcmf_update_bss_info(struct brcmf_cfg80211_priv *cfg_priv)
 {
-        struct brcmf_bss_info *bi;
+        struct brcmf_bss_info_le *bi;
         struct brcmf_ssid *ssid;
         struct brcmf_tlv *tim;
         u16 beacon_interval;
@@ -2211,7 +2228,7 @@ static s32 brcmf_update_bss_info(struct brcmf_cfg80211_priv *cfg_priv)
                 goto update_bss_info_out;
         }
 
-        bi = (struct brcmf_bss_info *)(cfg_priv->extra_buf + 4);
+        bi = (struct brcmf_bss_info_le *)(cfg_priv->extra_buf + 4);
         err = brcmf_inform_single_bss(cfg_priv, bi);
         if (err)
                 goto update_bss_info_out;
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
index 62dc46144ede..a613b49cb13f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
@@ -352,15 +352,6 @@ brcmf_cfg80211_connect_info *cfg_to_conn(struct brcmf_cfg80211_priv *cfg)
         return &cfg->conn_info;
 }
 
-static inline struct brcmf_bss_info *next_bss(struct brcmf_scan_results *list,
-                                           struct brcmf_bss_info *bss)
-{
-        return bss = bss ?
-                (struct brcmf_bss_info *)((unsigned long)bss +
-                                       le32_to_cpu(bss->length)) :
-                list->bss_info;
-}
-
 extern struct brcmf_cfg80211_dev *brcmf_cfg80211_attach(struct net_device *ndev,
                                                         struct device *busdev,
                                                         void *data);
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.h b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.h
index 106a7424a7cd..b51d1e421e24 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.h
@@ -38,88 +38,12 @@
 /* PCIE Client Mode sb2pcitranslation2 (2 ZettaBytes), high 32 bits */
 #define SI_PCIE_DMA_H32         0x80000000
 
-/* core codes */
-#define NODEV_CORE_ID           0x700   /* Invalid coreid */
-#define CC_CORE_ID              0x800   /* chipcommon core */
-#define ILINE20_CORE_ID         0x801   /* iline20 core */
-#define SRAM_CORE_ID            0x802   /* sram core */
-#define SDRAM_CORE_ID           0x803   /* sdram core */
-#define PCI_CORE_ID             0x804   /* pci core */
-#define MIPS_CORE_ID            0x805   /* mips core */
-#define ENET_CORE_ID            0x806   /* enet mac core */
-#define CODEC_CORE_ID           0x807   /* v90 codec core */
-#define USB_CORE_ID             0x808   /* usb 1.1 host/device core */
-#define ADSL_CORE_ID            0x809   /* ADSL core */
-#define ILINE100_CORE_ID        0x80a   /* iline100 core */
-#define IPSEC_CORE_ID           0x80b   /* ipsec core */
-#define UTOPIA_CORE_ID          0x80c   /* utopia core */
-#define PCMCIA_CORE_ID          0x80d   /* pcmcia core */
-#define SOCRAM_CORE_ID          0x80e   /* internal memory core */
-#define MEMC_CORE_ID            0x80f   /* memc sdram core */
-#define OFDM_CORE_ID            0x810   /* OFDM phy core */
-#define EXTIF_CORE_ID           0x811   /* external interface core */
-#define D11_CORE_ID             0x812   /* 802.11 MAC core */
-#define APHY_CORE_ID            0x813   /* 802.11a phy core */
-#define BPHY_CORE_ID            0x814   /* 802.11b phy core */
-#define GPHY_CORE_ID            0x815   /* 802.11g phy core */
-#define MIPS33_CORE_ID          0x816   /* mips3302 core */
-#define USB11H_CORE_ID          0x817   /* usb 1.1 host core */
-#define USB11D_CORE_ID          0x818   /* usb 1.1 device core */
-#define USB20H_CORE_ID          0x819   /* usb 2.0 host core */
-#define USB20D_CORE_ID          0x81a   /* usb 2.0 device core */
-#define SDIOH_CORE_ID           0x81b   /* sdio host core */
-#define ROBO_CORE_ID            0x81c   /* roboswitch core */
-#define ATA100_CORE_ID          0x81d   /* parallel ATA core */
-#define SATAXOR_CORE_ID         0x81e   /* serial ATA & XOR DMA core */
-#define GIGETH_CORE_ID          0x81f   /* gigabit ethernet core */
-#define PCIE_CORE_ID            0x820   /* pci express core */
-#define NPHY_CORE_ID            0x821   /* 802.11n 2x2 phy core */
-#define SRAMC_CORE_ID           0x822   /* SRAM controller core */
-#define MINIMAC_CORE_ID         0x823   /* MINI MAC/phy core */
-#define ARM11_CORE_ID           0x824   /* ARM 1176 core */
-#define ARM7S_CORE_ID           0x825   /* ARM7tdmi-s core */
-#define LPPHY_CORE_ID           0x826   /* 802.11a/b/g phy core */
-#define PMU_CORE_ID             0x827   /* PMU core */
-#define SSNPHY_CORE_ID          0x828   /* 802.11n single-stream phy core */
-#define SDIOD_CORE_ID           0x829   /* SDIO device core */
-#define ARMCM3_CORE_ID          0x82a   /* ARM Cortex M3 core */
-#define HTPHY_CORE_ID           0x82b   /* 802.11n 4x4 phy core */
-#define MIPS74K_CORE_ID         0x82c   /* mips 74k core */
-#define GMAC_CORE_ID            0x82d   /* Gigabit MAC core */
-#define DMEMC_CORE_ID           0x82e   /* DDR1/2 memory controller core */
-#define PCIERC_CORE_ID          0x82f   /* PCIE Root Complex core */
-#define OCP_CORE_ID             0x830   /* OCP2OCP bridge core */
-#define SC_CORE_ID              0x831   /* shared common core */
-#define AHB_CORE_ID             0x832   /* OCP2AHB bridge core */
-#define SPIH_CORE_ID            0x833   /* SPI host core */
-#define I2S_CORE_ID             0x834   /* I2S core */
-#define DMEMS_CORE_ID           0x835   /* SDR/DDR1 memory controller core */
-#define DEF_SHIM_COMP           0x837   /* SHIM component in ubus/6362 */
-#define OOB_ROUTER_CORE_ID      0x367   /* OOB router core ID */
-#define DEF_AI_COMP             0xfff   /* Default component, in ai chips it
-                                         * maps all unused address ranges
-                                         */
-
 /* chipcommon being the first core: */
 #define SI_CC_IDX               0
 
 /* SOC Interconnect types (aka chip types) */
 #define SOCI_AI                 1
 
-/* Common core control flags */
-#define SICF_BIST_EN            0x8000
-#define SICF_PME_EN             0x4000
-#define SICF_CORE_BITS          0x3ffc
-#define SICF_FGC                0x0002
-#define SICF_CLOCK_EN           0x0001
-
-/* Common core status flags */
-#define SISF_BIST_DONE          0x8000
-#define SISF_BIST_ERROR         0x4000
-#define SISF_GATED_CLK          0x2000
-#define SISF_DMA64              0x1000
-#define SISF_CORE_BITS          0x0fff
-
 /* A register that is common to all cores to
  * communicate w/PMU regarding clock control.
  */
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
index 7f27dbdb6b60..43f7a724dda8 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
@@ -649,7 +649,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
                 len = roundup(len, 4);
                 ampdu_len += (len + (ndelim + 1) * AMPDU_DELIMITER_LEN);
 
-                dma_len += (u16) brcmu_pkttotlen(p);
+                dma_len += (u16) p->len;
 
                 BCMMSG(wlc->wiphy, "wl%d: ampdu_len %d"
                         " seg_cnt %d null delim %d\n",
@@ -741,9 +741,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
                 if (p) {
                         if ((tx_info->flags & IEEE80211_TX_CTL_AMPDU) &&
                             ((u8) (p->priority) == tid)) {
-
-                                plen = brcmu_pkttotlen(p) +
-                                       AMPDU_MAX_MPDU_OVERHEAD;
+                                plen = p->len + AMPDU_MAX_MPDU_OVERHEAD;
                                 plen = max(scb_ampdu->min_len, plen);
 
                                 if ((plen + ampdu_len) > max_ampdu_bytes) {
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/channel.c b/drivers/net/wireless/brcm80211/brcmsmac/channel.c
index 89ad1b7dab8f..55e9f45fce22 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/channel.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/channel.c
@@ -1153,121 +1153,6 @@ brcms_c_channel_set_chanspec(struct brcms_cm_info *wlc_cm, u16 chanspec,
                               &txpwr);
 }
 
-#ifdef POWER_DBG
-static void wlc_phy_txpower_limits_dump(struct txpwr_limits *txpwr)
-{
-        int i;
-        char buf[80];
-        char fraction[4][4] = { "   ", ".25", ".5 ", ".75" };
-
-        sprintf(buf, "CCK                ");
-        for (i = 0; i < BRCMS_NUM_RATES_CCK; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->cck[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->cck[i] % BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz OFDM SISO   ");
-        for (i = 0; i < BRCMS_NUM_RATES_OFDM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->ofdm[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->ofdm[i] % BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz OFDM CDD    ");
-        for (i = 0; i < BRCMS_NUM_RATES_OFDM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->ofdm_cdd[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->ofdm_cdd[i] % BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz OFDM SISO   ");
-        for (i = 0; i < BRCMS_NUM_RATES_OFDM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->ofdm_40_siso[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->ofdm_40_siso[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz OFDM CDD    ");
-        for (i = 0; i < BRCMS_NUM_RATES_OFDM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->ofdm_40_cdd[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->ofdm_40_cdd[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz MCS0-7 SISO ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_20_siso[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_20_siso[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz MCS0-7 CDD  ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_20_cdd[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_20_cdd[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz MCS0-7 STBC ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_20_stbc[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_20_stbc[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "20 MHz MCS8-15 SDM ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_2_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_20_mimo[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_20_mimo[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz MCS0-7 SISO ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_40_siso[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_40_siso[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz MCS0-7 CDD  ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_40_cdd[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_40_cdd[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz MCS0-7 STBC ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_1_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_40_stbc[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_40_stbc[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        printk(KERN_DEBUG "%s\n", buf);
-
-        sprintf(buf, "40 MHz MCS8-15 SDM ");
-        for (i = 0; i < BRCMS_NUM_RATES_MCS_2_STREAM; i++)
-                sprintf(buf[strlen(buf)], " %2d%s",
-                        txpwr->mcs_40_mimo[i] / BRCMS_TXPWR_DB_FACTOR,
-                        fraction[txpwr->mcs_40_mimo[i] %
-                                                        BRCMS_TXPWR_DB_FACTOR]);
-        }
-        printk(KERN_DEBUG "%s\n", buf);
-
-        printk(KERN_DEBUG "MCS32               %2d%s\n",
-               txpwr->mcs32 / BRCMS_TXPWR_DB_FACTOR,
-               fraction[txpwr->mcs32 % BRCMS_TXPWR_DB_FACTOR]);
-}
-#endif                          /* POWER_DBG */
-
 void
 brcms_c_channel_reg_limits(struct brcms_cm_info *wlc_cm, u16 chanspec,
                        struct txpwr_limits *txpwr)
@@ -1478,9 +1363,6 @@ brcms_c_channel_reg_limits(struct brcms_cm_info *wlc_cm, u16 chanspec,
                         txpwr->mcs_40_stbc[i] = txpwr->mcs_40_cdd[i];
         }
 
-#ifdef POWER_DBG
-        wlc_phy_txpower_limits_dump(txpwr);
-#endif
         return;
 }
 
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/brcm80211/brcmsmac/dma.c
index 6ebec8f42846..e286fb4d4813 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/dma.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/dma.c
@@ -14,7 +14,6 @@
  * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 #include <linux/slab.h>
-#include <linux/skbuff.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
 
@@ -22,6 +21,7 @@
 #include <aiutils.h>
 #include "types.h"
 #include "dma.h"
+#include "soc.h"
 
 /*
  * DMA hardware requires each descriptor ring to be 8kB aligned, and fit within
@@ -901,7 +901,7 @@ static struct sk_buff *_dma_getnextrxp(struct dma_info *di, bool forceall)
 
 /*
  * !! rx entry routine
- * returns a pointer to the next frame received, or NULL if there are no more
+ * returns the number packages in the next frame, or 0 if there are no more
  *   if DMA_CTRL_RXMULTI is defined, DMA scattering(multiple buffers) is
  *   supported with pkts chain
  *   otherwise, it's treated as giant pkt and will be tossed.
@@ -909,38 +909,40 @@ static struct sk_buff *_dma_getnextrxp(struct dma_info *di, bool forceall)
  *   buffer data. After it reaches the max size of buffer, the data continues
  *   in next DMA descriptor buffer WITHOUT DMA header
  */
-struct sk_buff *dma_rx(struct dma_pub *pub)
+int dma_rx(struct dma_pub *pub, struct sk_buff_head *skb_list)
 {
         struct dma_info *di = (struct dma_info *)pub;
-        struct sk_buff *p, *head, *tail;
+        struct sk_buff_head dma_frames;
+        struct sk_buff *p, *next;
         uint len;
         uint pkt_len;
         int resid = 0;
+        int pktcnt = 1;
 
+        skb_queue_head_init(&dma_frames);
  next_frame:
-        head = _dma_getnextrxp(di, false);
-        if (head == NULL)
-                return NULL;
+        p = _dma_getnextrxp(di, false);
+        if (p == NULL)
+                return 0;
 
-        len = le16_to_cpu(*(__le16 *) (head->data));
+        len = le16_to_cpu(*(__le16 *) (p->data));
         DMA_TRACE(("%s: dma_rx len %d\n", di->name, len));
-        dma_spin_for_len(len, head);
+        dma_spin_for_len(len, p);
 
         /* set actual length */
         pkt_len = min((di->rxoffset + len), di->rxbufsize);
-        __skb_trim(head, pkt_len);
+        __skb_trim(p, pkt_len);
+        skb_queue_tail(&dma_frames, p);
         resid = len - (di->rxbufsize - di->rxoffset);
 
         /* check for single or multi-buffer rx */
         if (resid > 0) {
-                tail = head;
                 while ((resid > 0) && (p = _dma_getnextrxp(di, false))) {
-                        tail->next = p;
                         pkt_len = min_t(uint, resid, di->rxbufsize);
                         __skb_trim(p, pkt_len);
-
-                        tail = p;
+                        skb_queue_tail(&dma_frames, p);
                         resid -= di->rxbufsize;
+                        pktcnt++;
                 }
 
 #ifdef BCMDBG
@@ -959,13 +961,18 @@ struct sk_buff *dma_rx(struct dma_pub *pub)
                 if ((di->dma.dmactrlflags & DMA_CTRL_RXMULTI) == 0) {
                         DMA_ERROR(("%s: dma_rx: bad frame length (%d)\n",
                                    di->name, len));
-                        brcmu_pkt_buf_free_skb(head);
+                        skb_queue_walk_safe(&dma_frames, p, next) {
+                                skb_unlink(p, &dma_frames);
+                                brcmu_pkt_buf_free_skb(p);
+                        }
                         di->dma.rxgiants++;
+                        pktcnt = 1;
                         goto next_frame;
                 }
         }
 
-        return head;
+        skb_queue_splice_tail(&dma_frames, skb_list);
+        return pktcnt;
 }
 
 static bool dma64_rxidle(struct dma_info *di)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/dma.h b/drivers/net/wireless/brcm80211/brcmsmac/dma.h
index ebc5bc546f3b..d317c7c12f91 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/dma.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/dma.h
@@ -18,6 +18,7 @@
 #define _BRCM_DMA_H_
 
 #include <linux/delay.h>
+#include <linux/skbuff.h>
 #include "types.h"              /* forward structure declarations */
 
 /* map/unmap direction */
@@ -80,7 +81,7 @@ extern struct dma_pub *dma_attach(char *name, struct si_pub *sih,
                             uint nrxpost, uint rxoffset, uint *msg_level);
 
 void dma_rxinit(struct dma_pub *pub);
-struct sk_buff *dma_rx(struct dma_pub *pub);
+int dma_rx(struct dma_pub *pub, struct sk_buff_head *skb_list);
 bool dma_rxfill(struct dma_pub *pub);
 bool dma_rxreset(struct dma_pub *pub);
 bool dma_txreset(struct dma_pub *pub);
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
index 0d8a9cdf897a..8457e969eb4f 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
@@ -216,8 +216,7 @@ static const struct ieee80211_supported_band brcms_band_2GHz_nphy_template = {
         .ht_cap = {
                    /* from include/linux/ieee80211.h */
                    .cap = IEEE80211_HT_CAP_GRN_FLD |
-                   IEEE80211_HT_CAP_SGI_20 |
-                   IEEE80211_HT_CAP_SGI_40 | IEEE80211_HT_CAP_40MHZ_INTOLERANT,
+                          IEEE80211_HT_CAP_SGI_20 | IEEE80211_HT_CAP_SGI_40,
                    .ht_supported = true,
                    .ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K,
                    .ampdu_density = AMPDU_DEF_MPDU_DENSITY,
@@ -238,8 +237,7 @@ static const struct ieee80211_supported_band brcms_band_5GHz_nphy_template = {
                         BRCMS_LEGACY_5G_RATE_OFFSET,
         .ht_cap = {
                    .cap = IEEE80211_HT_CAP_GRN_FLD | IEEE80211_HT_CAP_SGI_20 |
-                          IEEE80211_HT_CAP_SGI_40 |
-                          IEEE80211_HT_CAP_40MHZ_INTOLERANT, /* No 40 mhz yet */
+                          IEEE80211_HT_CAP_SGI_40,
                    .ht_supported = true,
                    .ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K,
                    .ampdu_density = AMPDU_DEF_MPDU_DENSITY,
@@ -287,6 +285,7 @@ static int brcms_ops_start(struct ieee80211_hw *hw)
 {
         struct brcms_info *wl = hw->priv;
         bool blocked;
+        int err;
 
         ieee80211_wake_queues(hw);
         spin_lock_bh(&wl->lock);
@@ -295,57 +294,69 @@ static int brcms_ops_start(struct ieee80211_hw *hw)
         if (!blocked)
                 wiphy_rfkill_stop_polling(wl->pub->ieee_hw->wiphy);
 
-        return 0;
+        spin_lock_bh(&wl->lock);
+        /* avoid acknowledging frames before a non-monitor device is added */
+        wl->mute_tx = true;
+
+        if (!wl->pub->up)
+                err = brcms_up(wl);
+        else
+                err = -ENODEV;
+        spin_unlock_bh(&wl->lock);
+
+        if (err != 0)
+                wiphy_err(hw->wiphy, "%s: brcms_up() returned %d\n", __func__,
+                          err);
+        return err;
 }
 
 static void brcms_ops_stop(struct ieee80211_hw *hw)
 {
+        struct brcms_info *wl = hw->priv;
+        int status;
+
         ieee80211_stop_queues(hw);
+
+        if (wl->wlc == NULL)
+                return;
+
+        spin_lock_bh(&wl->lock);
+        status = brcms_c_chipmatch(wl->wlc->hw->vendorid,
+                                   wl->wlc->hw->deviceid);
+        spin_unlock_bh(&wl->lock);
+        if (!status) {
+                wiphy_err(wl->wiphy,
+                          "wl: brcms_ops_stop: chipmatch failed\n");
+                return;
+        }
+
+        /* put driver in down state */
+        spin_lock_bh(&wl->lock);
+        brcms_down(wl);
+        spin_unlock_bh(&wl->lock);
 }
 
 static int
 brcms_ops_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 {
-        struct brcms_info *wl;
-        int err;
+        struct brcms_info *wl = hw->priv;
 
         /* Just STA for now */
-        if (vif->type != NL80211_IFTYPE_AP &&
-            vif->type != NL80211_IFTYPE_MESH_POINT &&
-            vif->type != NL80211_IFTYPE_STATION &&
-            vif->type != NL80211_IFTYPE_WDS &&
-            vif->type != NL80211_IFTYPE_ADHOC) {
+        if (vif->type != NL80211_IFTYPE_STATION) {
                 wiphy_err(hw->wiphy, "%s: Attempt to add type %d, only"
                           " STA for now\n", __func__, vif->type);
                 return -EOPNOTSUPP;
         }
 
-        wl = hw->priv;
-        spin_lock_bh(&wl->lock);
-        if (!wl->pub->up)
-                err = brcms_up(wl);
-        else
-                err = -ENODEV;
-        spin_unlock_bh(&wl->lock);
-
-        if (err != 0)
-                wiphy_err(hw->wiphy, "%s: brcms_up() returned %d\n", __func__,
-                          err);
+        wl->mute_tx = false;
+        brcms_c_mute(wl->wlc, false);
 
-        return err;
+        return 0;
 }
 
 static void
 brcms_ops_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 {
-        struct brcms_info *wl;
-
-        wl = hw->priv;
-
-        /* put driver in down state */
-        spin_lock_bh(&wl->lock);
-        brcms_down(wl);
-        spin_unlock_bh(&wl->lock);
 }
 
 static int brcms_ops_config(struct ieee80211_hw *hw, u32 changed)
@@ -609,13 +620,6 @@ brcms_ops_sta_add(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
         wl->pub->global_ampdu->scb = scb;
         wl->pub->global_ampdu->max_pdu = 16;
 
-        sta->ht_cap.ht_supported = true;
-        sta->ht_cap.ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K;
-        sta->ht_cap.ampdu_density = AMPDU_DEF_MPDU_DENSITY;
-        sta->ht_cap.cap = IEEE80211_HT_CAP_GRN_FLD |
-            IEEE80211_HT_CAP_SGI_20 |
-            IEEE80211_HT_CAP_SGI_40 | IEEE80211_HT_CAP_40MHZ_INTOLERANT;
-
         /*
          * minstrel_ht initiates addBA on our behalf by calling
          * ieee80211_start_tx_ba_session()
@@ -877,37 +881,18 @@ static void brcms_free(struct brcms_info *wl)
 }
 
 /*
-* called from both kernel as from this kernel module.
+* called from both kernel as from this kernel module (error flow on attach)
 * precondition: perimeter lock is not acquired.
 */
 static void brcms_remove(struct pci_dev *pdev)
 {
-        struct brcms_info *wl;
-        struct ieee80211_hw *hw;
-        int status;
-
-        hw = pci_get_drvdata(pdev);
-        wl = hw->priv;
-        if (!wl) {
-                pr_err("wl: brcms_remove: pci_get_drvdata failed\n");
-                return;
-        }
+        struct ieee80211_hw *hw = pci_get_drvdata(pdev);
+        struct brcms_info *wl = hw->priv;
 
-        spin_lock_bh(&wl->lock);
-        status = brcms_c_chipmatch(pdev->vendor, pdev->device);
-        spin_unlock_bh(&wl->lock);
-        if (!status) {
-                wiphy_err(wl->wiphy, "wl: brcms_remove: chipmatch "
-                                     "failed\n");
-                return;
-        }
         if (wl->wlc) {
                 wiphy_rfkill_set_hw_state(wl->pub->ieee_hw->wiphy, false);
                 wiphy_rfkill_stop_polling(wl->pub->ieee_hw->wiphy);
                 ieee80211_unregister_hw(hw);
-                spin_lock_bh(&wl->lock);
-                brcms_down(wl);
-                spin_unlock_bh(&wl->lock);
         }
         pci_disable_device(pdev);
 
@@ -1081,9 +1066,6 @@ static struct brcms_info *brcms_attach(u16 vendor, u16 device,
 
         wl->pub->ieee_hw = hw;
 
-        /* disable mpc */
-        brcms_c_set_radio_mpc(wl->wlc, false);
-
         /* register our interrupt handler */
         if (request_irq(irq, brcms_isr, IRQF_SHARED, KBUILD_MODNAME, wl)) {
                 wiphy_err(wl->wiphy, "wl%d: request_irq() failed\n", unit);
@@ -1319,8 +1301,7 @@ void brcms_init(struct brcms_info *wl)
 {
         BCMMSG(wl->pub->ieee_hw->wiphy, "wl%d\n", wl->pub->unit);
         brcms_reset(wl);
-
-        brcms_c_init(wl->wlc);
+        brcms_c_init(wl->wlc, wl->mute_tx);
 }
 
 /*
@@ -1337,6 +1318,14 @@ uint brcms_reset(struct brcms_info *wl)
         return 0;
 }
 
+void brcms_fatal_error(struct brcms_info *wl)
+{
+        wiphy_err(wl->wlc->wiphy, "wl%d: fatal error, reinitializing\n",
+                  wl->wlc->pub->unit);
+        brcms_reset(wl);
+        ieee80211_restart_hw(wl->pub->ieee_hw);
+}
+
 /*
  * These are interrupt on/off entry points. Disable interrupts
  * during interrupt state transition.
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.h b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.h
index 177f0e44e4b6..6242f188b717 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.h
@@ -80,6 +80,7 @@ struct brcms_info {
         struct brcms_firmware fw;
         struct wiphy *wiphy;
         struct brcms_ucode ucode;
+        bool mute_tx;
 };
 
 /* misc callbacks */
@@ -104,5 +105,6 @@ extern bool brcms_del_timer(struct brcms_timer *timer);
 extern void brcms_msleep(struct brcms_info *wl, uint ms);
 extern void brcms_dpc(unsigned long data);
 extern void brcms_timer(struct brcms_timer *t);
+extern void brcms_fatal_error(struct brcms_info *wl);
 
 #endif                          /* _BRCM_MAC80211_IF_H_ */
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 510e9bb52287..36e3e0638300 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -30,44 +30,21 @@
 #include "mac80211_if.h"
 #include "ucode_loader.h"
 #include "main.h"
+#include "soc.h"
 
 /*
  * Indication for txflowcontrol that all priority bits in
  * TXQ_STOP_FOR_PRIOFC_MASK are to be considered.
  */
-#define ALLPRIO         -1
-
-/*
- * 32 SSID chars, max of 4 chars for each SSID char "\xFF", plus NULL.
- */
-#define SSID_FMT_BUF_LEN        ((4 * IEEE80211_MAX_SSID_LEN) + 1)
+#define ALLPRIO                         -1
 
 /* watchdog timer, in unit of ms */
-#define TIMER_INTERVAL_WATCHDOG 1000
+#define TIMER_INTERVAL_WATCHDOG         1000
 /* radio monitor timer, in unit of ms */
-#define TIMER_INTERVAL_RADIOCHK 800
-
-/* Max MPC timeout, in unit of watchdog */
-#ifndef BRCMS_MPC_MAX_DELAYCNT
-#define BRCMS_MPC_MAX_DELAYCNT  10
-#endif
-
-/* Min MPC timeout, in unit of watchdog */
-#define BRCMS_MPC_MIN_DELAYCNT  1
-#define BRCMS_MPC_THRESHOLD     3       /* MPC count threshold level */
+#define TIMER_INTERVAL_RADIOCHK         800
 
 /* beacon interval, in unit of 1024TU */
-#define BEACON_INTERVAL_DEFAULT 100
-/* DTIM interval, in unit of beacon interval */
-#define DTIM_INTERVAL_DEFAULT   3
-
-/* Scale down delays to accommodate QT slow speed */
-/* beacon interval, in unit of 1024TU */
-#define BEACON_INTERVAL_DEF_QT  20
-/* DTIM interval, in unit of beacon interval */
-#define DTIM_INTERVAL_DEF_QT    1
-
-#define TBTT_ALIGN_LEEWAY_US    100     /* min leeway before first TBTT in us */
+#define BEACON_INTERVAL_DEFAULT         100
 
 /* n-mode support capability */
 /* 2x2 includes both 1x1 & 2x2 devices
@@ -78,113 +55,71 @@
 #define WL_11N_3x3                      3
 #define WL_11N_4x4                      4
 
-/* define 11n feature disable flags */
-#define WLFEATURE_DISABLE_11N           0x00000001
-#define WLFEATURE_DISABLE_11N_STBC_TX   0x00000002
-#define WLFEATURE_DISABLE_11N_STBC_RX   0x00000004
-#define WLFEATURE_DISABLE_11N_SGI_TX    0x00000008
-#define WLFEATURE_DISABLE_11N_SGI_RX    0x00000010
-#define WLFEATURE_DISABLE_11N_AMPDU_TX  0x00000020
-#define WLFEATURE_DISABLE_11N_AMPDU_RX  0x00000040
-#define WLFEATURE_DISABLE_11N_GF        0x00000080
-
-#define EDCF_ACI_MASK                0x60
-#define EDCF_ACI_SHIFT               5
-#define EDCF_ECWMIN_MASK             0x0f
-#define EDCF_ECWMAX_SHIFT            4
-#define EDCF_AIFSN_MASK              0x0f
-#define EDCF_AIFSN_MAX               15
-#define EDCF_ECWMAX_MASK             0xf0
-
-#define EDCF_AC_BE_TXOP_STA          0x0000
-#define EDCF_AC_BK_TXOP_STA          0x0000
-#define EDCF_AC_VO_ACI_STA           0x62
-#define EDCF_AC_VO_ECW_STA           0x32
-#define EDCF_AC_VI_ACI_STA           0x42
-#define EDCF_AC_VI_ECW_STA           0x43
-#define EDCF_AC_BK_ECW_STA           0xA4
-#define EDCF_AC_VI_TXOP_STA          0x005e
-#define EDCF_AC_VO_TXOP_STA          0x002f
-#define EDCF_AC_BE_ACI_STA           0x03
-#define EDCF_AC_BE_ECW_STA           0xA4
-#define EDCF_AC_BK_ACI_STA           0x27
-#define EDCF_AC_VO_TXOP_AP           0x002f
-
-#define EDCF_TXOP2USEC(txop)         ((txop) << 5)
-#define EDCF_ECW2CW(exp)             ((1 << (exp)) - 1)
-
-#define APHY_SYMBOL_TIME        4
-#define APHY_PREAMBLE_TIME      16
-#define APHY_SIGNAL_TIME        4
-#define APHY_SIFS_TIME          16
-#define APHY_SERVICE_NBITS      16
-#define APHY_TAIL_NBITS         6
-#define BPHY_SIFS_TIME          10
-#define BPHY_PLCP_SHORT_TIME    96
-
-#define PREN_PREAMBLE           24
-#define PREN_MM_EXT             12
-#define PREN_PREAMBLE_EXT       4
+#define EDCF_ACI_MASK                   0x60
+#define EDCF_ACI_SHIFT                  5
+#define EDCF_ECWMIN_MASK                0x0f
+#define EDCF_ECWMAX_SHIFT               4
+#define EDCF_AIFSN_MASK                 0x0f
+#define EDCF_AIFSN_MAX                  15
+#define EDCF_ECWMAX_MASK                0xf0
+
+#define EDCF_AC_BE_TXOP_STA             0x0000
+#define EDCF_AC_BK_TXOP_STA             0x0000
+#define EDCF_AC_VO_ACI_STA              0x62
+#define EDCF_AC_VO_ECW_STA              0x32
+#define EDCF_AC_VI_ACI_STA              0x42
+#define EDCF_AC_VI_ECW_STA              0x43
+#define EDCF_AC_BK_ECW_STA              0xA4
+#define EDCF_AC_VI_TXOP_STA             0x005e
+#define EDCF_AC_VO_TXOP_STA             0x002f
+#define EDCF_AC_BE_ACI_STA              0x03
+#define EDCF_AC_BE_ECW_STA              0xA4
+#define EDCF_AC_BK_ACI_STA              0x27
+#define EDCF_AC_VO_TXOP_AP              0x002f
+
+#define EDCF_TXOP2USEC(txop)            ((txop) << 5)
+#define EDCF_ECW2CW(exp)                ((1 << (exp)) - 1)
+
+#define APHY_SYMBOL_TIME                4
+#define APHY_PREAMBLE_TIME              16
+#define APHY_SIGNAL_TIME                4
+#define APHY_SIFS_TIME                  16
+#define APHY_SERVICE_NBITS              16
+#define APHY_TAIL_NBITS                 6
+#define BPHY_SIFS_TIME                  10
+#define BPHY_PLCP_SHORT_TIME            96
+
+#define PREN_PREAMBLE                   24
+#define PREN_MM_EXT                     12
+#define PREN_PREAMBLE_EXT               4
 
 #define DOT11_MAC_HDR_LEN               24
-#define DOT11_ACK_LEN           10
-#define DOT11_BA_LEN            4
+#define DOT11_ACK_LEN                   10
+#define DOT11_BA_LEN                    4
 #define DOT11_OFDM_SIGNAL_EXTENSION     6
 #define DOT11_MIN_FRAG_LEN              256
-#define DOT11_RTS_LEN           16
-#define DOT11_CTS_LEN           10
+#define DOT11_RTS_LEN                   16
+#define DOT11_CTS_LEN                   10
 #define DOT11_BA_BITMAP_LEN             128
 #define DOT11_MIN_BEACON_PERIOD         1
 #define DOT11_MAX_BEACON_PERIOD         0xFFFF
-#define DOT11_MAXNUMFRAGS       16
+#define DOT11_MAXNUMFRAGS               16
 #define DOT11_MAX_FRAG_LEN              2346
 
-#define BPHY_PLCP_TIME          192
-#define RIFS_11N_TIME           2
-
-#define WME_VER                 1
-#define WME_SUBTYPE_PARAM_IE    1
-#define WME_TYPE                2
-#define WME_OUI                 "\x00\x50\xf2"
-
-#define AC_BE                   0
-#define AC_BK                   1
-#define AC_VI                   2
-#define AC_VO                   3
+#define BPHY_PLCP_TIME                  192
+#define RIFS_11N_TIME                   2
 
-#define BCN_TMPL_LEN            512     /* length of the BCN template area */
+/* length of the BCN template area */
+#define BCN_TMPL_LEN                    512
 
 /* brcms_bss_info flag bit values */
-#define BRCMS_BSS_HT            0x0020  /* BSS is HT (MIMO) capable */
+#define BRCMS_BSS_HT                    0x0020  /* BSS is HT (MIMO) capable */
 
-/* Flags used in brcms_c_txq_info.stopped */
-/* per prio flow control bits */
-#define TXQ_STOP_FOR_PRIOFC_MASK        0x000000FF
-/* stop txq enqueue for packet drain */
-#define TXQ_STOP_FOR_PKT_DRAIN          0x00000100
-/* stop txq enqueue for ampdu flow control */
-#define TXQ_STOP_FOR_AMPDU_FLOW_CNTRL   0x00000200
-
-#define BRCMS_HWRXOFF           38      /* chip rx buffer offset */
-
-/* Find basic rate for a given rate */
-static u8 brcms_basic_rate(struct brcms_c_info *wlc, u32 rspec)
-{
-        if (is_mcs_rate(rspec))
-                return wlc->band->basic_rate[mcs_table[rspec & RSPEC_RATE_MASK]
-                       .leg_ofdm];
-        return wlc->band->basic_rate[rspec & RSPEC_RATE_MASK];
-}
-
-static u16 frametype(u32 rspec, u8 mimoframe)
-{
-        if (is_mcs_rate(rspec))
-                return mimoframe;
-        return is_cck_rate(rspec) ? FT_CCK : FT_OFDM;
-}
+/* chip rx buffer offset */
+#define BRCMS_HWRXOFF                   38
 
 /* rfdisable delay timer 500 ms, runs of ALP clock */
-#define RFDISABLE_DEFAULT       10000000
+#define RFDISABLE_DEFAULT               10000000
 
 #define BRCMS_TEMPSENSE_PERIOD          10      /* 10 second timeout */
 
@@ -194,87 +129,83 @@ static u16 frametype(u32 rspec, u8 mimoframe)
  * These constants are used ONLY by wlc_prio2prec_map.  Do not use them
  * elsewhere.
  */
-#define _BRCMS_PREC_NONE                0       /* None = - */
-#define _BRCMS_PREC_BK          2       /* BK - Background */
-#define _BRCMS_PREC_BE          4       /* BE - Best-effort */
-#define _BRCMS_PREC_EE          6       /* EE - Excellent-effort */
-#define _BRCMS_PREC_CL          8       /* CL - Controlled Load */
-#define _BRCMS_PREC_VI          10      /* Vi - Video */
-#define _BRCMS_PREC_VO          12      /* Vo - Voice */
-#define _BRCMS_PREC_NC          14      /* NC - Network Control */
-
-/* The BSS is generating beacons in HW */
-#define BRCMS_BSSCFG_HW_BCN     0x20
-
-#define SYNTHPU_DLY_APHY_US     3700    /* a phy synthpu_dly time in us */
-#define SYNTHPU_DLY_BPHY_US     1050    /* b/g phy synthpu_dly time in us */
-#define SYNTHPU_DLY_NPHY_US     2048    /* n phy REV3 synthpu_dly time in us */
-#define SYNTHPU_DLY_LPPHY_US    300     /* lpphy synthpu_dly time in us */
-
-#define SYNTHPU_DLY_PHY_US_QT   100     /* QT synthpu_dly time in us */
-
-#define ANTCNT                  10      /* vanilla M_MAX_ANTCNT value */
+#define _BRCMS_PREC_NONE                0       /* None = - */
+#define _BRCMS_PREC_BK                  2       /* BK - Background */
+#define _BRCMS_PREC_BE                  4       /* BE - Best-effort */
+#define _BRCMS_PREC_EE                  6       /* EE - Excellent-effort */
+#define _BRCMS_PREC_CL                  8       /* CL - Controlled Load */
+#define _BRCMS_PREC_VI                  10      /* Vi - Video */
+#define _BRCMS_PREC_VO                  12      /* Vo - Voice */
+#define _BRCMS_PREC_NC                  14      /* NC - Network Control */
+
+/* synthpu_dly times in us */
+#define SYNTHPU_DLY_APHY_US             3700
+#define SYNTHPU_DLY_BPHY_US             1050
+#define SYNTHPU_DLY_NPHY_US             2048
+#define SYNTHPU_DLY_LPPHY_US            300
+
+#define ANTCNT                          10      /* vanilla M_MAX_ANTCNT val */
 
 /* Per-AC retry limit register definitions; uses defs.h bitfield macros */
-#define EDCF_SHORT_S            0
-#define EDCF_SFB_S              4
-#define EDCF_LONG_S             8
-#define EDCF_LFB_S              12
-#define EDCF_SHORT_M            BITFIELD_MASK(4)
-#define EDCF_SFB_M              BITFIELD_MASK(4)
-#define EDCF_LONG_M             BITFIELD_MASK(4)
-#define EDCF_LFB_M              BITFIELD_MASK(4)
+#define EDCF_SHORT_S                    0
+#define EDCF_SFB_S                      4
+#define EDCF_LONG_S                     8
+#define EDCF_LFB_S                      12
+#define EDCF_SHORT_M                    BITFIELD_MASK(4)
+#define EDCF_SFB_M                      BITFIELD_MASK(4)
+#define EDCF_LONG_M                     BITFIELD_MASK(4)
+#define EDCF_LFB_M                      BITFIELD_MASK(4)
 
-#define RETRY_SHORT_DEF                 7       /* Default Short retry Limit */
-#define RETRY_SHORT_MAX                 255     /* Maximum Short retry Limit */
-#define RETRY_LONG_DEF                  4       /* Default Long retry count */
-#define RETRY_SHORT_FB                  3 /* Short count for fallback rate */
-#define RETRY_LONG_FB                   2 /* Long count for fallback rate */
+#define RETRY_SHORT_DEF                 7       /* Default Short retry Limit */
+#define RETRY_SHORT_MAX                 255     /* Maximum Short retry Limit */
+#define RETRY_LONG_DEF                  4       /* Default Long retry count */
+#define RETRY_SHORT_FB                  3       /* Short count for fb rate */
+#define RETRY_LONG_FB                   2       /* Long count for fb rate */
 
-#define APHY_CWMIN              15
-#define PHY_CWMAX               1023
+#define APHY_CWMIN                      15
+#define PHY_CWMAX                       1023
 
-#define EDCF_AIFSN_MIN               1
+#define EDCF_AIFSN_MIN                  1
 
-#define FRAGNUM_MASK            0xF
+#define FRAGNUM_MASK                    0xF
 
-#define APHY_SLOT_TIME          9
-#define BPHY_SLOT_TIME          20
+#define APHY_SLOT_TIME                  9
+#define BPHY_SLOT_TIME                  20
 
-#define WL_SPURAVOID_OFF        0
-#define WL_SPURAVOID_ON1        1
-#define WL_SPURAVOID_ON2        2
+#define WL_SPURAVOID_OFF                0
+#define WL_SPURAVOID_ON1                1
+#define WL_SPURAVOID_ON2                2
 
 /* invalid core flags, use the saved coreflags */
-#define BRCMS_USE_COREFLAGS     0xffffffff
+#define BRCMS_USE_COREFLAGS             0xffffffff
 
 /* values for PLCPHdr_override */
-#define BRCMS_PLCP_AUTO -1
-#define BRCMS_PLCP_SHORT        0
-#define BRCMS_PLCP_LONG 1
+#define BRCMS_PLCP_AUTO                 -1
+#define BRCMS_PLCP_SHORT                0
+#define BRCMS_PLCP_LONG                 1
 
 /* values for g_protection_override and n_protection_override */
 #define BRCMS_PROTECTION_AUTO           -1
 #define BRCMS_PROTECTION_OFF            0
 #define BRCMS_PROTECTION_ON             1
 #define BRCMS_PROTECTION_MMHDR_ONLY     2
-#define BRCMS_PROTECTION_CTS_ONLY               3
+#define BRCMS_PROTECTION_CTS_ONLY       3
 
 /* values for g_protection_control and n_protection_control */
-#define BRCMS_PROTECTION_CTL_OFF                0
+#define BRCMS_PROTECTION_CTL_OFF        0
 #define BRCMS_PROTECTION_CTL_LOCAL      1
 #define BRCMS_PROTECTION_CTL_OVERLAP    2
 
 /* values for n_protection */
 #define BRCMS_N_PROTECTION_OFF          0
 #define BRCMS_N_PROTECTION_OPTIONAL     1
-#define BRCMS_N_PROTECTION_20IN40               2
+#define BRCMS_N_PROTECTION_20IN40       2
 #define BRCMS_N_PROTECTION_MIXEDMODE    3
 
 /* values for band specific 40MHz capabilities */
-#define BRCMS_N_BW_20ALL                        0
-#define BRCMS_N_BW_40ALL                        1
-#define BRCMS_N_BW_20IN2G_40IN5G                2
+#define BRCMS_N_BW_20ALL                0
+#define BRCMS_N_BW_40ALL                1
+#define BRCMS_N_BW_20IN2G_40IN5G        2
 
 /* bitflags for SGI support (sgi_rx iovar) */
 #define BRCMS_N_SGI_20                  0x01
@@ -282,48 +213,42 @@ static u16 frametype(u32 rspec, u8 mimoframe)
 
 /* defines used by the nrate iovar */
 /* MSC in use,indicates b0-6 holds an mcs */
-#define NRATE_MCS_INUSE 0x00000080
+#define NRATE_MCS_INUSE                 0x00000080
 /* rate/mcs value */
-#define NRATE_RATE_MASK 0x0000007f
+#define NRATE_RATE_MASK                 0x0000007f
 /* stf mode mask: siso, cdd, stbc, sdm */
-#define NRATE_STF_MASK  0x0000ff00
+#define NRATE_STF_MASK                  0x0000ff00
 /* stf mode shift */
-#define NRATE_STF_SHIFT 8
-/* bit indicates override both rate & mode */
-#define NRATE_OVERRIDE  0x80000000
+#define NRATE_STF_SHIFT                 8
 /* bit indicate to override mcs only */
-#define NRATE_OVERRIDE_MCS_ONLY 0x40000000
-#define NRATE_SGI_MASK  0x00800000      /* sgi mode */
-#define NRATE_SGI_SHIFT 23      /* sgi mode */
-#define NRATE_LDPC_CODING 0x00400000    /* bit indicates adv coding in use */
-#define NRATE_LDPC_SHIFT 22     /* ldpc shift */
+#define NRATE_OVERRIDE_MCS_ONLY         0x40000000
+#define NRATE_SGI_MASK                  0x00800000      /* sgi mode */
+#define NRATE_SGI_SHIFT                 23              /* sgi mode */
+#define NRATE_LDPC_CODING               0x00400000      /* adv coding in use */
+#define NRATE_LDPC_SHIFT                22              /* ldpc shift */
 
-#define NRATE_STF_SISO  0       /* stf mode SISO */
-#define NRATE_STF_CDD   1       /* stf mode CDD */
-#define NRATE_STF_STBC  2       /* stf mode STBC */
-#define NRATE_STF_SDM   3       /* stf mode SDM */
+#define NRATE_STF_SISO                  0               /* stf mode SISO */
+#define NRATE_STF_CDD                   1               /* stf mode CDD */
+#define NRATE_STF_STBC                  2               /* stf mode STBC */
+#define NRATE_STF_SDM                   3               /* stf mode SDM */
 
-#define MAX_DMA_SEGS 4
+#define MAX_DMA_SEGS                    4
 
 /* Max # of entries in Tx FIFO based on 4kb page size */
-#define NTXD            256
+#define NTXD                            256
 /* Max # of entries in Rx FIFO based on 4kb page size */
-#define NRXD            256
+#define NRXD                            256
 
 /* try to keep this # rbufs posted to the chip */
-#define NRXBUFPOST      32
+#define NRXBUFPOST                      32
 
 /* data msg txq hiwat mark */
-#define BRCMS_DATAHIWAT         50
+#define BRCMS_DATAHIWAT                 50
 
-/* bounded rx loops */
-#define RXBND           8 /* max # frames to process in brcms_c_recv() */
-#define TXSBND          8 /* max # tx status to process in wlc_txstatus() */
-
-/*
- * 32 SSID chars, max of 4 chars for each SSID char "\xFF", plus NULL.
- */
-#define SSID_FMT_BUF_LEN        ((4 * IEEE80211_MAX_SSID_LEN) + 1)
+/* max # frames to process in brcms_c_recv() */
+#define RXBND                           8
+/* max # tx status to process in wlc_txstatus() */
+#define TXSBND                          8
 
 /* brcmu_format_flags() bit description structure */
 struct brcms_c_bit_desc {
@@ -375,10 +300,22 @@ uint brcm_msg_level =
 #endif                          /* BCMDBG */
 
 /* TX FIFO number to WME/802.1E Access Category */
-static const u8 wme_fifo2ac[] = { AC_BK, AC_BE, AC_VI, AC_VO, AC_BE, AC_BE };
+static const u8 wme_fifo2ac[] = {
+        IEEE80211_AC_BK,
+        IEEE80211_AC_BE,
+        IEEE80211_AC_VI,
+        IEEE80211_AC_VO,
+        IEEE80211_AC_BE,
+        IEEE80211_AC_BE
+};
 
-/* WME/802.1E Access Category to TX FIFO number */
-static const u8 wme_ac2fifo[] = { 1, 0, 2, 3 };
+/* ieee80211 Access Category to TX FIFO number */
+static const u8 wme_ac2fifo[] = {
+        TX_AC_VO_FIFO,
+        TX_AC_VI_FIFO,
+        TX_AC_BE_FIFO,
+        TX_AC_BK_FIFO
+};
 
 /* 802.1D Priority to precedence queue mapping */
 const u8 wlc_prio2prec_map[] = {
@@ -405,13 +342,6 @@ static const u16 xmtfifo_sz[][NFIFO] = {
         {9, 58, 22, 14, 14, 5},
 };
 
-static const u8 acbitmap2maxprio[] = {
-        PRIO_8021D_BE, PRIO_8021D_BE, PRIO_8021D_BK, PRIO_8021D_BK,
-        PRIO_8021D_VI, PRIO_8021D_VI, PRIO_8021D_VI, PRIO_8021D_VI,
-        PRIO_8021D_VO, PRIO_8021D_VO, PRIO_8021D_VO, PRIO_8021D_VO,
-        PRIO_8021D_VO, PRIO_8021D_VO, PRIO_8021D_VO, PRIO_8021D_VO
-};
-
 #ifdef BCMDBG
 static const char * const fifo_names[] = {
         "AC_BK", "AC_BE", "AC_VI", "AC_VO", "BCMC", "ATIM" };
@@ -424,6 +354,22 @@ static const char fifo_names[6][0];
 static struct brcms_c_info *wlc_info_dbg = (struct brcms_c_info *) (NULL);
 #endif
 
+/* Find basic rate for a given rate */
+static u8 brcms_basic_rate(struct brcms_c_info *wlc, u32 rspec)
+{
+        if (is_mcs_rate(rspec))
+                return wlc->band->basic_rate[mcs_table[rspec & RSPEC_RATE_MASK]
+                       .leg_ofdm];
+        return wlc->band->basic_rate[rspec & RSPEC_RATE_MASK];
+}
+
+static u16 frametype(u32 rspec, u8 mimoframe)
+{
+        if (is_mcs_rate(rspec))
+                return mimoframe;
+        return is_cck_rate(rspec) ? FT_CCK : FT_OFDM;
+}
+
 /* currently the best mechanism for determining SIFS is the band in use */
 static u16 get_sifs(struct brcms_band *band)
 {
@@ -470,20 +416,6 @@ static int brcms_chspec_bw(u16 chanspec)
         return BRCMS_10_MHZ;
 }
 
-/*
- * return true if Minimum Power Consumption should
- * be entered, false otherwise
- */
-static bool brcms_c_is_non_delay_mpc(struct brcms_c_info *wlc)
-{
-        return false;
-}
-
-static bool brcms_c_ismpc(struct brcms_c_info *wlc)
-{
-        return (wlc->mpc_delay_off == 0) && (brcms_c_is_non_delay_mpc(wlc));
-}
-
 static void brcms_c_bsscfg_mfree(struct brcms_bss_cfg *cfg)
 {
         if (cfg == NULL)
@@ -669,9 +601,8 @@ static void brcms_b_update_slot_timing(struct brcms_hardware *wlc_hw,
  * calculate frame duration of a given rate and length, return
  * time in usec unit
  */
-uint
-brcms_c_calc_frame_time(struct brcms_c_info *wlc, u32 ratespec,
-                        u8 preamble_type, uint mac_len)
+static uint brcms_c_calc_frame_time(struct brcms_c_info *wlc, u32 ratespec,
+                                    u8 preamble_type, uint mac_len)
 {
         uint nsyms, dur = 0, Ndps, kNdps;
         uint rate = rspec2rate(ratespec);
@@ -969,7 +900,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
                     lfbl,       /* Long Frame Rate Fallback Limit */
                     fbl;
 
-                if (queue < AC_COUNT) {
+                if (queue < IEEE80211_NUM_ACS) {
                         sfbl = GFIELD(wlc->wme_retries[wme_fifo2ac[queue]],
                                       EDCF_SFB);
                         lfbl = GFIELD(wlc->wme_retries[wme_fifo2ac[queue]],
@@ -1018,7 +949,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
                         tx_info->flags |= IEEE80211_TX_STAT_ACK;
         }
 
-        totlen = brcmu_pkttotlen(p);
+        totlen = p->len;
         free_pdu = true;
 
         brcms_c_txfifo_complete(wlc, queue, 1);
@@ -2352,13 +2283,6 @@ void brcms_b_antsel_type_set(struct brcms_hardware *wlc_hw, u8 antsel_type)
         wlc_phy_antsel_type_set(wlc_hw->band->pi, antsel_type);
 }
 
-static void brcms_c_fatal_error(struct brcms_c_info *wlc)
-{
-        wiphy_err(wlc->wiphy, "wl%d: fatal error, reinitializing\n",
-                  wlc->pub->unit);
-        brcms_init(wlc->wl);
-}
-
 static void brcms_b_fifoerrors(struct brcms_hardware *wlc_hw)
 {
         bool fatal = false;
@@ -2414,7 +2338,7 @@ static void brcms_b_fifoerrors(struct brcms_hardware *wlc_hw)
                 }
 
                 if (fatal) {
-                        brcms_c_fatal_error(wlc_hw->wlc);       /* big hammer */
+                        brcms_fatal_error(wlc_hw->wlc->wl); /* big hammer */
                         break;
                 } else
                         W_REG(&regs->intctrlregs[idx].intstatus,
@@ -2479,6 +2403,7 @@ void brcms_c_intrsrestore(struct brcms_c_info *wlc, u32 macintmask)
         W_REG(&wlc_hw->regs->macintmask, wlc->macintmask);
 }
 
+/* assumes that the d11 MAC is enabled */
 static void brcms_b_tx_fifo_suspend(struct brcms_hardware *wlc_hw,
                                     uint tx_fifo)
 {
@@ -2535,11 +2460,12 @@ static void brcms_b_tx_fifo_resume(struct brcms_hardware *wlc_hw,
         }
 }
 
-static void brcms_b_mute(struct brcms_hardware *wlc_hw, bool on, u32 flags)
+/* precondition: requires the mac core to be enabled */
+static void brcms_b_mute(struct brcms_hardware *wlc_hw, bool mute_tx)
 {
         static const u8 null_ether_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
 
-        if (on) {
+        if (mute_tx) {
                 /* suspend tx fifos */
                 brcms_b_tx_fifo_suspend(wlc_hw, TX_DATA_FIFO);
                 brcms_b_tx_fifo_suspend(wlc_hw, TX_CTL_FIFO);
@@ -2561,14 +2487,20 @@ static void brcms_b_mute(struct brcms_hardware *wlc_hw, bool on, u32 flags)
                                        wlc_hw->etheraddr);
         }
 
-        wlc_phy_mute_upd(wlc_hw->band->pi, on, flags);
+        wlc_phy_mute_upd(wlc_hw->band->pi, mute_tx, 0);
 
-        if (on)
+        if (mute_tx)
                 brcms_c_ucode_mute_override_set(wlc_hw);
         else
                 brcms_c_ucode_mute_override_clear(wlc_hw);
 }
 
+void
+brcms_c_mute(struct brcms_c_info *wlc, bool mute_tx)
+{
+        brcms_b_mute(wlc->hw, mute_tx);
+}
+
 /*
  * Read and clear macintmask and macintstatus and intstatus registers.
  * This routine should be called with interrupts off
@@ -3437,8 +3369,7 @@ static void brcms_b_coreinit(struct brcms_c_info *wlc)
 }
 
 void
-static brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec,
-                          bool mute) {
+static brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec) {
         u32 macintmask;
         bool fastclk;
         struct brcms_c_info *wlc = wlc_hw->wlc;
@@ -3463,10 +3394,6 @@ static brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec,
         /* core-specific initialization */
         brcms_b_coreinit(wlc);
 
-        /* suspend the tx fifos and mute the phy for preism cac time */
-        if (mute)
-                brcms_b_mute(wlc_hw, ON, PHY_MUTE_FOR_PREISM);
-
         /* band-specific inits */
         brcms_b_bsinit(wlc, chanspec);
 
@@ -3656,42 +3583,30 @@ static void brcms_c_bandinit_ordered(struct brcms_c_info *wlc,
         brcms_c_set_phy_chanspec(wlc, chanspec);
 }
 
-static void brcms_c_mac_bcn_promisc(struct brcms_c_info *wlc)
-{
-        if (wlc->bcnmisc_monitor)
-                brcms_b_mctrl(wlc->hw, MCTL_BCNS_PROMISC, MCTL_BCNS_PROMISC);
-        else
-                brcms_b_mctrl(wlc->hw, MCTL_BCNS_PROMISC, 0);
-}
-
-void brcms_c_mac_bcn_promisc_change(struct brcms_c_info *wlc, bool promisc)
-{
-        wlc->bcnmisc_monitor = promisc;
-        brcms_c_mac_bcn_promisc(wlc);
-}
-
-/* set or clear maccontrol bits MCTL_PROMISC and MCTL_KEEPCONTROL */
+/*
+ * Set or clear maccontrol bits MCTL_PROMISC, MCTL_BCNS_PROMISC and
+ * MCTL_KEEPCONTROL
+ */
 static void brcms_c_mac_promisc(struct brcms_c_info *wlc)
 {
         u32 promisc_bits = 0;
 
-        /*
-         * promiscuous mode just sets MCTL_PROMISC
-         * Note: APs get all BSS traffic without the need to set
-         * the MCTL_PROMISC bit since all BSS data traffic is
-         * directed at the AP
-         */
-        if (wlc->pub->promisc)
-                promisc_bits |= MCTL_PROMISC;
+        if (wlc->bcnmisc_monitor)
+                promisc_bits |= MCTL_BCNS_PROMISC;
 
-        /* monitor mode needs both MCTL_PROMISC and MCTL_KEEPCONTROL
-         * Note: monitor mode also needs MCTL_BCNS_PROMISC, but that is
-         * handled in brcms_c_mac_bcn_promisc()
-         */
         if (wlc->monitor)
-                promisc_bits |= MCTL_PROMISC | MCTL_KEEPCONTROL;
+                promisc_bits |=
+                        MCTL_PROMISC | MCTL_BCNS_PROMISC | MCTL_KEEPCONTROL;
 
-        brcms_b_mctrl(wlc->hw, MCTL_PROMISC | MCTL_KEEPCONTROL, promisc_bits);
+        brcms_b_mctrl(wlc->hw,
+                        MCTL_PROMISC | MCTL_BCNS_PROMISC | MCTL_KEEPCONTROL,
+                        promisc_bits);
+}
+
+void brcms_c_mac_bcn_promisc_change(struct brcms_c_info *wlc, bool promisc)
+{
+        wlc->bcnmisc_monitor = promisc;
+        brcms_c_mac_promisc(wlc);
 }
 
 /*
@@ -3723,7 +3638,6 @@ static void brcms_c_ucode_mac_upd(struct brcms_c_info *wlc)
         }
 
         /* update the various promisc bits */
-        brcms_c_mac_bcn_promisc(wlc);
         brcms_c_mac_promisc(wlc);
 }
 
@@ -3979,7 +3893,7 @@ static void brcms_c_set_home_chanspec(struct brcms_c_info *wlc, u16 chanspec)
 
 void
 brcms_b_set_chanspec(struct brcms_hardware *wlc_hw, u16 chanspec,
-                      bool mute, struct txpwr_limits *txpwr)
+                      bool mute_tx, struct txpwr_limits *txpwr)
 {
         uint bandunit;
 
@@ -4005,7 +3919,7 @@ brcms_b_set_chanspec(struct brcms_hardware *wlc_hw, u16 chanspec,
                 }
         }
 
-        wlc_phy_initcal_enable(wlc_hw->band->pi, !mute);
+        wlc_phy_initcal_enable(wlc_hw->band->pi, !mute_tx);
 
         if (!wlc_hw->up) {
                 if (wlc_hw->clk)
@@ -4017,7 +3931,7 @@ brcms_b_set_chanspec(struct brcms_hardware *wlc_hw, u16 chanspec,
                 wlc_phy_txpower_limit_set(wlc_hw->band->pi, txpwr, chanspec);
 
                 /* Update muting of the channel */
-                brcms_b_mute(wlc_hw, mute, 0);
+                brcms_b_mute(wlc_hw, mute_tx);
         }
 }
 
@@ -4205,7 +4119,7 @@ void brcms_c_wme_setparams(struct brcms_c_info *wlc, u16 aci,
             EDCF_TXOP2USEC(acp_shm.txop);
         acp_shm.aifs = (params->aifs & EDCF_AIFSN_MASK);
 
-        if (aci == AC_VI && acp_shm.txop == 0
+        if (aci == IEEE80211_AC_VI && acp_shm.txop == 0
             && acp_shm.aifs < EDCF_AIFSN_MAX)
                 acp_shm.aifs++;
 
@@ -4242,7 +4156,7 @@ void brcms_c_wme_setparams(struct brcms_c_info *wlc, u16 aci,
         }
 }
 
-void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
+static void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
 {
         u16 aci;
         int i_ac;
@@ -4255,7 +4169,7 @@ void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
         }; /* ucode needs these parameters during its initialization */
         const struct edcf_acparam *edcf_acp = &default_edcf_acparams[0];
 
-        for (i_ac = 0; i_ac < AC_COUNT; i_ac++, edcf_acp++) {
+        for (i_ac = 0; i_ac < IEEE80211_NUM_ACS; i_ac++, edcf_acp++) {
                 /* find out which ac this set of params applies to */
                 aci = (edcf_acp->ACI & EDCF_ACI_MASK) >> EDCF_ACI_SHIFT;
 
@@ -4277,17 +4191,6 @@ void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
         }
 }
 
-/* maintain LED behavior in down state */
-static void brcms_c_down_led_upd(struct brcms_c_info *wlc)
-{
-        /*
-         * maintain LEDs while in down state, turn on sbclk if
-         * not available yet. Turn on sbclk if necessary
-         */
-        brcms_b_pllreq(wlc->hw, true, BRCMS_PLLREQ_FLIP);
-        brcms_b_pllreq(wlc->hw, false, BRCMS_PLLREQ_FLIP);
-}
-
 static void brcms_c_radio_monitor_start(struct brcms_c_info *wlc)
 {
         /* Don't start the timer if HWRADIO feature is disabled */
@@ -4299,28 +4202,6 @@ static void brcms_c_radio_monitor_start(struct brcms_c_info *wlc)
         brcms_add_timer(wlc->radio_timer, TIMER_INTERVAL_RADIOCHK, true);
 }
 
-static void brcms_c_radio_disable(struct brcms_c_info *wlc)
-{
-        if (!wlc->pub->up) {
-                brcms_c_down_led_upd(wlc);
-                return;
-        }
-
-        brcms_c_radio_monitor_start(wlc);
-        brcms_down(wlc->wl);
-}
-
-static void brcms_c_radio_enable(struct brcms_c_info *wlc)
-{
-        if (wlc->pub->up)
-                return;
-
-        if (brcms_deviceremoved(wlc))
-                return;
-
-        brcms_up(wlc->wl);
-}
-
 static bool brcms_c_radio_monitor_stop(struct brcms_c_info *wlc)
 {
         if (!wlc->radio_monitor)
@@ -4343,18 +4224,6 @@ static void brcms_c_radio_hwdisable_upd(struct brcms_c_info *wlc)
                 mboolclr(wlc->pub->radio_disabled, WL_RADIO_HW_DISABLE);
 }
 
-/*
- * centralized radio disable/enable function,
- * invoke radio enable/disable after updating hwradio status
- */
-static void brcms_c_radio_upd(struct brcms_c_info *wlc)
-{
-        if (wlc->pub->radio_disabled)
-                brcms_c_radio_disable(wlc);
-        else
-                brcms_c_radio_enable(wlc);
-}
-
 /* update hwradio status and return it */
 bool brcms_c_check_radio_disabled(struct brcms_c_info *wlc)
 {
@@ -4376,12 +4245,7 @@ static void brcms_c_radio_timer(void *arg)
                 return;
         }
 
-        /* cap mpc off count */
-        if (wlc->mpc_offcnt < BRCMS_MPC_MAX_DELAYCNT)
-                wlc->mpc_offcnt++;
-
         brcms_c_radio_hwdisable_upd(wlc);
-        brcms_c_radio_upd(wlc);
 }
 
 /* common low-level watchdog code */
@@ -4407,60 +4271,6 @@ static void brcms_b_watchdog(void *arg)
         wlc_phy_watchdog(wlc_hw->band->pi);
 }
 
-static void brcms_c_radio_mpc_upd(struct brcms_c_info *wlc)
-{
-        bool mpc_radio, radio_state;
-
-        /*
-         * Clear the WL_RADIO_MPC_DISABLE bit when mpc feature is disabled
-         * in case the WL_RADIO_MPC_DISABLE bit was set. Stop the radio
-         * monitor also when WL_RADIO_MPC_DISABLE is the only reason that
-         * the radio is going down.
-         */
-        if (!wlc->mpc) {
-                if (!wlc->pub->radio_disabled)
-                        return;
-                mboolclr(wlc->pub->radio_disabled, WL_RADIO_MPC_DISABLE);
-                brcms_c_radio_upd(wlc);
-                if (!wlc->pub->radio_disabled)
-                        brcms_c_radio_monitor_stop(wlc);
-                return;
-        }
-
-        /*
-         * sync ismpc logic with WL_RADIO_MPC_DISABLE bit in
-         * wlc->pub->radio_disabled to go ON, always call radio_upd
-         * synchronously to go OFF, postpone radio_upd to later when
-         * context is safe(e.g. watchdog)
-         */
-        radio_state =
-            (mboolisset(wlc->pub->radio_disabled, WL_RADIO_MPC_DISABLE) ? OFF :
-             ON);
-        mpc_radio = (brcms_c_ismpc(wlc) == true) ? OFF : ON;
-
-        if (radio_state == ON && mpc_radio == OFF)
-                wlc->mpc_delay_off = wlc->mpc_dlycnt;
-        else if (radio_state == OFF && mpc_radio == ON) {
-                mboolclr(wlc->pub->radio_disabled, WL_RADIO_MPC_DISABLE);
-                brcms_c_radio_upd(wlc);
-                if (wlc->mpc_offcnt < BRCMS_MPC_THRESHOLD)
-                        wlc->mpc_dlycnt = BRCMS_MPC_MAX_DELAYCNT;
-                else
-                        wlc->mpc_dlycnt = BRCMS_MPC_MIN_DELAYCNT;
-        }
-        /*
-         * Below logic is meant to capture the transition from mpc off
-         * to mpc on for reasons other than wlc->mpc_delay_off keeping
-         * the mpc off. In that case reset wlc->mpc_delay_off to
-         * wlc->mpc_dlycnt, so that we restart the countdown of mpc_delay_off
-         */
-        if ((wlc->prev_non_delay_mpc == false) &&
-            (brcms_c_is_non_delay_mpc(wlc) == true) && wlc->mpc_delay_off)
-                wlc->mpc_delay_off = wlc->mpc_dlycnt;
-
-        wlc->prev_non_delay_mpc = brcms_c_is_non_delay_mpc(wlc);
-}
-
 /* common watchdog code */
 static void brcms_c_watchdog(void *arg)
 {
@@ -4481,21 +4291,7 @@ static void brcms_c_watchdog(void *arg)
         /* increment second count */
         wlc->pub->now++;
 
-        /* delay radio disable */
-        if (wlc->mpc_delay_off) {
-                if (--wlc->mpc_delay_off == 0) {
-                        mboolset(wlc->pub->radio_disabled,
-                                 WL_RADIO_MPC_DISABLE);
-                        if (wlc->mpc && brcms_c_ismpc(wlc))
-                                wlc->mpc_offcnt = 0;
-                }
-        }
-
-        /* mpc sync */
-        brcms_c_radio_mpc_upd(wlc);
-        /* radio sync: sw/hw/mpc --> radio_disable/radio_enable */
         brcms_c_radio_hwdisable_upd(wlc);
-        brcms_c_radio_upd(wlc);
         /* if radio is disable, driver may be down, quit here */
         if (wlc->pub->radio_disabled)
                 return;
@@ -4599,9 +4395,6 @@ static void brcms_c_info_init(struct brcms_c_info *wlc, int unit)
         /* WME QoS mode is Auto by default */
         wlc->pub->_ampdu = AMPDU_AGG_HOST;
         wlc->pub->bcmerror = 0;
-
-        /* initialize mpc delay */
-        wlc->mpc_delay_off = wlc->mpc_dlycnt = BRCMS_MPC_MIN_DELAYCNT;
 }
 
 static uint brcms_c_attach_module(struct brcms_c_info *wlc)
@@ -5259,9 +5052,6 @@ static void brcms_c_ap_upd(struct brcms_c_info *wlc)
 {
         /* STA-BSS; short capable */
         wlc->PLCPHdr_override = BRCMS_PLCP_SHORT;
-
-        /* fixup mpc */
-        wlc->mpc = true;
 }
 
 /* Initialize just the hardware when coming out of POR or S3/S5 system states */
@@ -5376,7 +5166,7 @@ static void brcms_c_wme_retries_write(struct brcms_c_info *wlc)
         if (!wlc->clk)
                 return;
 
-        for (ac = 0; ac < AC_COUNT; ac++)
+        for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
                 brcms_b_write_shm(wlc->hw, M_AC_TXLMT_ADDR(ac),
                                   wlc->wme_retries[ac]);
 }
@@ -5575,7 +5365,6 @@ uint brcms_c_down(struct brcms_c_info *wlc)
         if (!wlc->pub->up)
                 return callbacks;
 
-        /* in between, mpc could try to bring down again.. */
         wlc->going_down = true;
 
         callbacks += brcms_b_bmac_down_prep(wlc->hw);
@@ -5852,7 +5641,7 @@ int brcms_c_set_rate_limit(struct brcms_c_info *wlc, u16 srl, u16 lrl)
 
         brcms_b_retrylimit_upd(wlc->hw, wlc->SRL, wlc->LRL);
 
-        for (ac = 0; ac < AC_COUNT; ac++) {
+        for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
                 wlc->wme_retries[ac] =  SFIELD(wlc->wme_retries[ac],
                                                EDCF_SHORT,  wlc->SRL);
                 wlc->wme_retries[ac] =  SFIELD(wlc->wme_retries[ac],
@@ -6103,7 +5892,6 @@ void brcms_c_print_txdesc(struct d11txh *txh)
 
         u8 *rtsph = txh->RTSPhyHeader;
         struct ieee80211_rts rts = txh->rts_frame;
-        char hexbuf[256];
 
         /* add plcp header along with txh descriptor */
         printk(KERN_DEBUG "Raw TxDesc + plcp header:\n");
@@ -6124,17 +5912,16 @@ void brcms_c_print_txdesc(struct d11txh *txh)
         printk(KERN_DEBUG "XtraFrameTypes: %04x ", xtraft);
         printk(KERN_DEBUG "\n");
 
-        brcmu_format_hex(hexbuf, iv, sizeof(txh->IV));
-        printk(KERN_DEBUG "SecIV:       %s\n", hexbuf);
-        brcmu_format_hex(hexbuf, ra, sizeof(txh->TxFrameRA));
-        printk(KERN_DEBUG "RA:          %s\n", hexbuf);
+        print_hex_dump_bytes("SecIV:", DUMP_PREFIX_OFFSET, iv, sizeof(txh->IV));
+        print_hex_dump_bytes("RA:", DUMP_PREFIX_OFFSET,
+                             ra, sizeof(txh->TxFrameRA));
 
         printk(KERN_DEBUG "Fb FES Time: %04x ", tfestfb);
-        brcmu_format_hex(hexbuf, rtspfb, sizeof(txh->RTSPLCPFallback));
-        printk(KERN_DEBUG "RTS PLCP: %s ", hexbuf);
+        print_hex_dump_bytes("Fb RTS PLCP:", DUMP_PREFIX_OFFSET,
+                             rtspfb, sizeof(txh->RTSPLCPFallback));
         printk(KERN_DEBUG "RTS DUR: %04x ", rtsdfb);
-        brcmu_format_hex(hexbuf, fragpfb, sizeof(txh->FragPLCPFallback));
-        printk(KERN_DEBUG "PLCP: %s ", hexbuf);
+        print_hex_dump_bytes("PLCP:", DUMP_PREFIX_OFFSET,
+                             fragpfb, sizeof(txh->FragPLCPFallback));
         printk(KERN_DEBUG "DUR: %04x", fragdfb);
         printk(KERN_DEBUG "\n");
 
@@ -6149,18 +5936,18 @@ void brcms_c_print_txdesc(struct d11txh *txh)
         printk(KERN_DEBUG "MaxAggbyte_fb:  %04x\n", mabyte_f);
         printk(KERN_DEBUG "MinByte:     %04x\n", mmbyte);
 
-        brcmu_format_hex(hexbuf, rtsph, sizeof(txh->RTSPhyHeader));
-        printk(KERN_DEBUG "RTS PLCP: %s ", hexbuf);
-        brcmu_format_hex(hexbuf, (u8 *) &rts, sizeof(txh->rts_frame));
-        printk(KERN_DEBUG "RTS Frame: %s", hexbuf);
+        print_hex_dump_bytes("RTS PLCP:", DUMP_PREFIX_OFFSET,
+                             rtsph, sizeof(txh->RTSPhyHeader));
+        print_hex_dump_bytes("RTS Frame:", DUMP_PREFIX_OFFSET,
+                             (u8 *)&rts, sizeof(txh->rts_frame));
         printk(KERN_DEBUG "\n");
 }
 #endif                          /* defined(BCMDBG) */
 
 #if defined(BCMDBG)
-int
+static int
 brcms_c_format_flags(const struct brcms_c_bit_desc *bd, u32 flags, char *buf,
-                   int len)
+                     int len)
 {
         int i;
         char *p = buf;
@@ -6916,7 +6703,7 @@ brcms_c_d11hdrs_mac80211(struct brcms_c_info *wlc, struct ieee80211_hw *hw,
         qos = ieee80211_is_data_qos(h->frame_control);
 
         /* compute length of frame in bytes for use in PLCP computations */
-        len = brcmu_pkttotlen(p);
+        len = p->len;
         phylen = len + FCS_LEN;
 
         /* Get tx_info */
@@ -8253,12 +8040,6 @@ int brcms_c_get_tx_power(struct brcms_c_info *wlc)
         return (int)(qdbm / BRCMS_TXPWR_DB_FACTOR);
 }
 
-void brcms_c_set_radio_mpc(struct brcms_c_info *wlc, bool mpc)
-{
-        wlc->mpc = mpc;
-        brcms_c_radio_mpc_upd(wlc);
-}
-
 /* Process received frames */
 /*
  * Return true if more frames need to be processed. false otherwise.
@@ -8328,21 +8109,17 @@ static bool
 brcms_b_recv(struct brcms_hardware *wlc_hw, uint fifo, bool bound)
 {
         struct sk_buff *p;
-        struct sk_buff *head = NULL;
-        struct sk_buff *tail = NULL;
+        struct sk_buff *next = NULL;
+        struct sk_buff_head recv_frames;
+
         uint n = 0;
         uint bound_limit = bound ? RXBND : -1;
 
         BCMMSG(wlc_hw->wlc->wiphy, "wl%d\n", wlc_hw->unit);
-        /* gather received frames */
-        while ((p = dma_rx(wlc_hw->di[fifo]))) {
+        skb_queue_head_init(&recv_frames);
 
-                if (!tail)
-                        head = tail = p;
-                else {
-                        tail->prev = p;
-                        tail = p;
-                }
+        /* gather received frames */
+        while (dma_rx(wlc_hw->di[fifo], &recv_frames)) {
 
                 /* !give others some time to run! */
                 if (++n >= bound_limit)
@@ -8353,12 +8130,11 @@ brcms_b_recv(struct brcms_hardware *wlc_hw, uint fifo, bool bound)
         dma_rxfill(wlc_hw->di[fifo]);
 
         /* process each frame */
-        while ((p = head) != NULL) {
+        skb_queue_walk_safe(&recv_frames, p, next) {
                 struct d11rxhdr_le *rxh_le;
                 struct d11rxhdr *rxh;
-                head = head->prev;
-                p->prev = NULL;
 
+                skb_unlink(p, &recv_frames);
                 rxh_le = (struct d11rxhdr_le *)p->data;
                 rxh = (struct d11rxhdr *)p->data;
 
@@ -8448,8 +8224,7 @@ bool brcms_c_dpc(struct brcms_c_info *wlc, bool bounded)
                 printk_once("%s : PSM Watchdog, chipid 0x%x, chiprev 0x%x\n",
                                         __func__, wlc_hw->sih->chip,
                                         wlc_hw->sih->chiprev);
-                /* big hammer */
-                brcms_init(wlc->wl);
+                brcms_fatal_error(wlc_hw->wlc->wl);
         }
 
         /* gptimer timeout */
@@ -8470,15 +8245,14 @@ bool brcms_c_dpc(struct brcms_c_info *wlc, bool bounded)
         return wlc->macintstatus != 0;
 
  fatal:
-        brcms_init(wlc->wl);
+        brcms_fatal_error(wlc_hw->wlc->wl);
         return wlc->macintstatus != 0;
 }
 
-void brcms_c_init(struct brcms_c_info *wlc)
+void brcms_c_init(struct brcms_c_info *wlc, bool mute_tx)
 {
         struct d11regs __iomem *regs;
         u16 chanspec;
-        bool mute = false;
 
         BCMMSG(wlc->wiphy, "wl%d\n", wlc->pub->unit);
 
@@ -8494,7 +8268,7 @@ void brcms_c_init(struct brcms_c_info *wlc)
         else
                 chanspec = brcms_c_init_chanspec(wlc);
 
-        brcms_b_init(wlc->hw, chanspec, mute);
+        brcms_b_init(wlc->hw, chanspec);
 
         /* update beacon listen interval */
         brcms_c_bcn_li_upd(wlc);
@@ -8560,15 +8334,16 @@ void brcms_c_init(struct brcms_c_info *wlc)
         /* ..now really unleash hell (allow the MAC out of suspend) */
         brcms_c_enable_mac(wlc);
 
+        /* suspend the tx fifos and mute the phy for preism cac time */
+        if (mute_tx)
+                brcms_b_mute(wlc->hw, true);
+
         /* clear tx flow control */
         brcms_c_txflowcontrol_reset(wlc);
 
         /* enable the RF Disable Delay timer */
         W_REG(&wlc->regs->rfdisabledly, RFDISABLE_DEFAULT);
 
-        /* initialize mpc delay */
-        wlc->mpc_delay_off = wlc->mpc_dlycnt = BRCMS_MPC_MIN_DELAYCNT;
-
         /*
          * Initialize WME parameters; if they haven't been set by some other
          * mechanism (IOVar, etc) then read them from the hardware.
@@ -8577,7 +8352,7 @@ void brcms_c_init(struct brcms_c_info *wlc)
                 /* Uninitialized; read from HW */
                 int ac;
 
-                for (ac = 0; ac < AC_COUNT; ac++)
+                for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
                         wlc->wme_retries[ac] =
                             brcms_b_read_shm(wlc->hw, M_AC_TXLMT_ADDR(ac));
         }
@@ -8754,8 +8529,6 @@ brcms_c_attach(struct brcms_info *wl, u16 vendor, u16 device, uint unit,
                 brcms_c_ht_update_sgi_rx(wlc, 0);
         }
 
-        /* initialize radio_mpc_disable according to wlc->mpc */
-        brcms_c_radio_mpc_upd(wlc);
         brcms_b_antsel_set(wlc->hw, wlc->asi->antsel_avail);
 
         if (perr)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.h b/drivers/net/wireless/brcm80211/brcmsmac/main.h
index c0e0fcfdfaf8..251c350b3164 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.h
@@ -44,8 +44,6 @@
 /* transmit buffer max headroom for protocol headers */
 #define TXOFF (D11_TXH_LEN + D11_PHY_HDR_LEN)
 
-#define AC_COUNT                4
-
 /* Macros for doing definition and get/set of bitfields
  * Usage example, e.g. a three-bit field (bits 4-6):
  *    #define <NAME>_M  BITFIELD_MASK(3)
@@ -427,11 +425,6 @@ struct brcms_txq_info {
  * bandinit_pending: track band init in auto band.
  * radio_monitor: radio timer is running.
  * going_down: down path intermediate variable.
- * mpc: enable minimum power consumption.
- * mpc_dlycnt: # of watchdog cnt before turn disable radio.
- * mpc_offcnt: # of watchdog cnt that radio is disabled.
- * mpc_delay_off: delay radio disable by # of watchdog cnt.
- * prev_non_delay_mpc: prev state brcms_c_is_non_delay_mpc.
  * wdtimer: timer for watchdog routine.
  * radio_timer: timer for hw radio button monitor routine.
  * monitor: monitor (MPDU sniffing) mode.
@@ -441,7 +434,7 @@ struct brcms_txq_info {
  * bcn_li_dtim: beacon listen interval in # dtims.
  * WDarmed: watchdog timer is armed.
  * WDlast: last time wlc_watchdog() was called.
- * edcf_txop[AC_COUNT]: current txop for each ac.
+ * edcf_txop[IEEE80211_NUM_ACS]: current txop for each ac.
  * wme_retries: per-AC retry limits.
  * tx_prec_map: Precedence map based on HW FIFO space.
  * fifo2prec_map[NFIFO]: pointer to fifo2_prec map based on WME.
@@ -522,12 +515,6 @@ struct brcms_c_info {
         bool radio_monitor;
         bool going_down;
 
-        bool mpc;
-        u8 mpc_dlycnt;
-        u8 mpc_offcnt;
-        u8 mpc_delay_off;
-        u8 prev_non_delay_mpc;
-
         struct brcms_timer *wdtimer;
         struct brcms_timer *radio_timer;
 
@@ -546,9 +533,9 @@ struct brcms_c_info {
         u32 WDlast;
 
         /* WME */
-        u16 edcf_txop[AC_COUNT];
+        u16 edcf_txop[IEEE80211_NUM_ACS];
 
-        u16 wme_retries[AC_COUNT];
+        u16 wme_retries[IEEE80211_NUM_ACS];
         u16 tx_prec_map;
         u16 fifo2prec_map[NFIFO];
 
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
index a3149254cbcd..e17edf7e6833 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
@@ -112,7 +112,7 @@ static const struct chan_info_basic chan_info_all[] = {
         {216, 50800}
 };
 
-const u8 ofdm_rate_lookup[] = {
+static const u8 ofdm_rate_lookup[] = {
 
         BRCM_RATE_48M,
         BRCM_RATE_24M,
@@ -190,15 +190,7 @@ u16 read_radio_reg(struct brcms_phy *pi, u16 addr)
                 data = R_REG(&pi->regs->radioregdata);
         } else {
                 W_REG_FLUSH(&pi->regs->phy4waddr, addr);
-
-#ifdef __ARM_ARCH_4T__
-                __asm__(" .align 4 ");
-                __asm__(" nop ");
-                data = R_REG(&pi->regs->phy4wdatalo);
-#else
                 data = R_REG(&pi->regs->phy4wdatalo);
-#endif
-
         }
         pi->phy_wreg = 0;
 
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h
index bea85241a244..5f9478b1c993 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h
@@ -774,11 +774,6 @@ struct brcms_phy {
         s16 nphy_noise_win[PHY_CORE_MAX][PHY_NOISE_WINDOW_SZ];
         u8 nphy_noise_index;
 
-        u8 nphy_txpid2g[PHY_CORE_NUM_2];
-        u8 nphy_txpid5g[PHY_CORE_NUM_2];
-        u8 nphy_txpid5gl[PHY_CORE_NUM_2];
-        u8 nphy_txpid5gh[PHY_CORE_NUM_2];
-
         bool nphy_gain_boost;
         bool nphy_elna_gain_config;
         u16 old_bphy_test;
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
index cd19c2f7a347..ec9b56639d54 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
@@ -29,6 +29,7 @@
 #include "phy_radio.h"
 #include "phyreg_n.h"
 #include "phytbl_n.h"
+#include "soc.h"
 
 #define READ_RADIO_REG2(pi, radio_type, jspace, core, reg_name) \
         read_radio_reg(pi, radio_type##_##jspace##_##reg_name | \
@@ -14417,12 +14418,6 @@ static void wlc_phy_txpwr_srom_read_ppr_nphy(struct brcms_phy *pi)
                 switch (band_num) {
                 case 0:
 
-                        pi->nphy_txpid2g[PHY_CORE_0] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID2GA0);
-                        pi->nphy_txpid2g[PHY_CORE_1] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID2GA1);
                         pi->nphy_pwrctrl_info[PHY_CORE_0].max_pwr_2g =
                                 (s8) wlapi_getintvar(shim,
                                                      BRCMS_SROM_MAXP2GA0);
@@ -14486,12 +14481,6 @@ static void wlc_phy_txpwr_srom_read_ppr_nphy(struct brcms_phy *pi)
                         break;
                 case 1:
 
-                        pi->nphy_txpid5g[PHY_CORE_0] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GA0);
-                        pi->nphy_txpid5g[PHY_CORE_1] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GA1);
                         pi->nphy_pwrctrl_info[PHY_CORE_0].max_pwr_5gm =
                                 (s8) wlapi_getintvar(shim, BRCMS_SROM_MAXP5GA0);
                         pi->nphy_pwrctrl_info[PHY_CORE_1].max_pwr_5gm =
@@ -14551,12 +14540,6 @@ static void wlc_phy_txpwr_srom_read_ppr_nphy(struct brcms_phy *pi)
                         break;
                 case 2:
 
-                        pi->nphy_txpid5gl[0] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GLA0);
-                        pi->nphy_txpid5gl[1] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GLA1);
                         pi->nphy_pwrctrl_info[0].max_pwr_5gl =
                                 (s8) wlapi_getintvar(shim,
                                                      BRCMS_SROM_MAXP5GLA0);
@@ -14615,12 +14598,6 @@ static void wlc_phy_txpwr_srom_read_ppr_nphy(struct brcms_phy *pi)
                         break;
                 case 3:
 
-                        pi->nphy_txpid5gh[0] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GHA0);
-                        pi->nphy_txpid5gh[1] =
-                                (u8) wlapi_getintvar(shim,
-                                                     BRCMS_SROM_TXPID5GHA1);
                         pi->nphy_pwrctrl_info[0].max_pwr_5gh =
                                 (s8) wlapi_getintvar(shim,
                                                      BRCMS_SROM_MAXP5GHA0);
@@ -27994,20 +27971,11 @@ void wlc_phy_txpwr_fixpower_nphy(struct brcms_phy *pi)
                 chan_freq_range = wlc_phy_get_chan_freq_range_nphy(pi, 0);
                 switch (chan_freq_range) {
                 case WL_CHAN_FREQ_RANGE_2G:
-                        txpi[0] = pi->nphy_txpid2g[0];
-                        txpi[1] = pi->nphy_txpid2g[1];
-                        break;
                 case WL_CHAN_FREQ_RANGE_5GL:
-                        txpi[0] = pi->nphy_txpid5gl[0];
-                        txpi[1] = pi->nphy_txpid5gl[1];
-                        break;
                 case WL_CHAN_FREQ_RANGE_5GM:
-                        txpi[0] = pi->nphy_txpid5g[0];
-                        txpi[1] = pi->nphy_txpid5g[1];
-                        break;
                 case WL_CHAN_FREQ_RANGE_5GH:
-                        txpi[0] = pi->nphy_txpid5gh[0];
-                        txpi[1] = pi->nphy_txpid5gh[1];
+                        txpi[0] = 0;
+                        txpi[1] = 0;
                         break;
                 default:
                         txpi[0] = txpi[1] = 91;
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/pmu.c b/drivers/net/wireless/brcm80211/brcmsmac/pmu.c
index 3b36e3acfd74..12ba575f5785 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/pmu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/pmu.c
@@ -23,6 +23,7 @@
 #include "pub.h"
 #include "aiutils.h"
 #include "pmu.h"
+#include "soc.h"
 
 /*
  * external LPO crystal frequency
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/pub.h b/drivers/net/wireless/brcm80211/brcmsmac/pub.h
index 37bb2dcc113f..21ccf3a03987 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/pub.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/pub.h
@@ -170,22 +170,6 @@ enum brcms_srom_id {
         BRCMS_SROM_TSSIPOS2G,
         BRCMS_SROM_TSSIPOS5G,
         BRCMS_SROM_TXCHAIN,
-        BRCMS_SROM_TXPID2GA0,
-        BRCMS_SROM_TXPID2GA1,
-        BRCMS_SROM_TXPID2GA2,
-        BRCMS_SROM_TXPID2GA3,
-        BRCMS_SROM_TXPID5GA0,
-        BRCMS_SROM_TXPID5GA1,
-        BRCMS_SROM_TXPID5GA2,
-        BRCMS_SROM_TXPID5GA3,
-        BRCMS_SROM_TXPID5GHA0,
-        BRCMS_SROM_TXPID5GHA1,
-        BRCMS_SROM_TXPID5GHA2,
-        BRCMS_SROM_TXPID5GHA3,
-        BRCMS_SROM_TXPID5GLA0,
-        BRCMS_SROM_TXPID5GLA1,
-        BRCMS_SROM_TXPID5GLA2,
-        BRCMS_SROM_TXPID5GLA3,
         /*
          * per-path identifiers (see srom.c)
          */
@@ -225,10 +209,6 @@ enum brcms_srom_id {
         BRCMS_SROM_PA2GW2A1,
         BRCMS_SROM_PA2GW2A2,
         BRCMS_SROM_PA2GW2A3,
-        BRCMS_SROM_PA2GW3A0,
-        BRCMS_SROM_PA2GW3A1,
-        BRCMS_SROM_PA2GW3A2,
-        BRCMS_SROM_PA2GW3A3,
         BRCMS_SROM_PA5GHW0A0,
         BRCMS_SROM_PA5GHW0A1,
         BRCMS_SROM_PA5GHW0A2,
@@ -241,10 +221,6 @@ enum brcms_srom_id {
         BRCMS_SROM_PA5GHW2A1,
         BRCMS_SROM_PA5GHW2A2,
         BRCMS_SROM_PA5GHW2A3,
-        BRCMS_SROM_PA5GHW3A0,
-        BRCMS_SROM_PA5GHW3A1,
-        BRCMS_SROM_PA5GHW3A2,
-        BRCMS_SROM_PA5GHW3A3,
         BRCMS_SROM_PA5GLW0A0,
         BRCMS_SROM_PA5GLW0A1,
         BRCMS_SROM_PA5GLW0A2,
@@ -257,10 +233,6 @@ enum brcms_srom_id {
         BRCMS_SROM_PA5GLW2A1,
         BRCMS_SROM_PA5GLW2A2,
         BRCMS_SROM_PA5GLW2A3,
-        BRCMS_SROM_PA5GLW3A0,
-        BRCMS_SROM_PA5GLW3A1,
-        BRCMS_SROM_PA5GLW3A2,
-        BRCMS_SROM_PA5GLW3A3,
         BRCMS_SROM_PA5GW0A0,
         BRCMS_SROM_PA5GW0A1,
         BRCMS_SROM_PA5GW0A2,
@@ -273,14 +245,9 @@ enum brcms_srom_id {
         BRCMS_SROM_PA5GW2A1,
         BRCMS_SROM_PA5GW2A2,
         BRCMS_SROM_PA5GW2A3,
-        BRCMS_SROM_PA5GW3A0,
-        BRCMS_SROM_PA5GW3A1,
-        BRCMS_SROM_PA5GW3A2,
-        BRCMS_SROM_PA5GW3A3,
 };
 
 #define BRCMS_NUMRATES  16      /* max # of rates in a rateset */
-#define D11_PHY_HDR_LEN 6       /* Phy header length - 6 bytes */
 
 /* phy types */
 #define PHY_TYPE_A      0       /* Phy type A */
@@ -414,7 +381,6 @@ struct brcms_pub {
         uint _nbands;           /* # bands supported */
         uint now;               /* # elapsed seconds */
 
-        bool promisc;           /* promiscuous destination address */
         bool delayed_down;      /* down delayed */
         bool associated;        /* true:part of [I]BSS, false: not */
         /* (union of stas_associated, aps_associated) */
@@ -572,7 +538,7 @@ extern int brcms_c_up(struct brcms_c_info *wlc);
 extern uint brcms_c_down(struct brcms_c_info *wlc);
 
 extern bool brcms_c_chipmatch(u16 vendor, u16 device);
-extern void brcms_c_init(struct brcms_c_info *wlc);
+extern void brcms_c_init(struct brcms_c_info *wlc, bool mute_tx);
 extern void brcms_c_reset(struct brcms_c_info *wlc);
 
 extern void brcms_c_intrson(struct brcms_c_info *wlc);
@@ -628,7 +594,7 @@ extern void brcms_c_set_beacon_listen_interval(struct brcms_c_info *wlc,
                                         u8 interval);
 extern int brcms_c_set_tx_power(struct brcms_c_info *wlc, int txpwr);
 extern int brcms_c_get_tx_power(struct brcms_c_info *wlc);
-extern void brcms_c_set_radio_mpc(struct brcms_c_info *wlc, bool mpc);
 extern bool brcms_c_check_radio_disabled(struct brcms_c_info *wlc);
+extern void brcms_c_mute(struct brcms_c_info *wlc, bool on);
 
 #endif                          /* _BRCM_PUB_H_ */
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/rate.h b/drivers/net/wireless/brcm80211/brcmsmac/rate.h
index e7b9dc2f2731..980d578825cc 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/rate.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/rate.h
@@ -19,6 +19,7 @@
 
 #include "types.h"
 #include "d11.h"
+#include "phy_hal.h"
 
 extern const u8 rate_info[];
 extern const struct brcms_c_rateset cck_ofdm_mimo_rates;
@@ -198,11 +199,9 @@ static inline u8 cck_rspec(u8 cck)
 
 /* Convert encoded rate value in plcp header to numerical rates in 500 KHz
  * increments */
-extern const u8 ofdm_rate_lookup[];
-
 static inline u8 ofdm_phy2mac_rate(u8 rlpt)
 {
-        return ofdm_rate_lookup[rlpt & 0x7];
+        return wlc_phy_get_ofdm_rate_lookup()[rlpt & 0x7];
 }
 
 static inline u8 cck_phy2mac_rate(u8 signal)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/srom.c b/drivers/net/wireless/brcm80211/brcmsmac/srom.c
index 99f791048e84..b6987ea9fc68 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/srom.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/srom.c
@@ -28,6 +28,7 @@
 #include "aiutils.h"
 #include "otp.h"
 #include "srom.h"
+#include "soc.h"
 
 /*
  * SROM CRC8 polynomial value:
@@ -62,9 +63,6 @@
 #define SROM_MACHI_ET1          42
 #define SROM_MACMID_ET1         43
 #define SROM_MACLO_ET1          44
-#define SROM3_MACHI             37
-#define SROM3_MACMID            38
-#define SROM3_MACLO             39
 
 #define SROM_BXARSSI2G          40
 #define SROM_BXARSSI5G          41
@@ -101,7 +99,6 @@
 
 #define SROM_BFL                57
 #define SROM_BFL2               28
-#define SROM3_BFL2              61
 
 #define SROM_AG10               58
 
@@ -109,99 +106,16 @@
 
 #define SROM_OPO                60
 
-#define SROM3_LEDDC             62
-
 #define SROM_CRCREV             63
 
-/* SROM Rev 4: Reallocate the software part of the srom to accommodate
- * MIMO features. It assumes up to two PCIE functions and 440 bytes
- * of usable srom i.e. the usable storage in chips with OTP that
- * implements hardware redundancy.
- */
-
 #define SROM4_WORDS             220
 
-#define SROM4_SIGN              32
-#define SROM4_SIGNATURE         0x5372
-
-#define SROM4_BREV              33
-
-#define SROM4_BFL0              34
-#define SROM4_BFL1              35
-#define SROM4_BFL2              36
-#define SROM4_BFL3              37
-#define SROM5_BFL0              37
-#define SROM5_BFL1              38
-#define SROM5_BFL2              39
-#define SROM5_BFL3              40
-
-#define SROM4_MACHI             38
-#define SROM4_MACMID            39
-#define SROM4_MACLO             40
-#define SROM5_MACHI             41
-#define SROM5_MACMID            42
-#define SROM5_MACLO             43
-
-#define SROM4_CCODE             41
-#define SROM4_REGREV            42
-#define SROM5_CCODE             34
-#define SROM5_REGREV            35
-
-#define SROM4_LEDBH10           43
-#define SROM4_LEDBH32           44
-#define SROM5_LEDBH10           59
-#define SROM5_LEDBH32           60
-
-#define SROM4_LEDDC             45
-#define SROM5_LEDDC             45
-
-#define SROM4_AA                46
-
-#define SROM4_AG10              47
-#define SROM4_AG32              48
-
-#define SROM4_TXPID2G           49
-#define SROM4_TXPID5G           51
-#define SROM4_TXPID5GL          53
-#define SROM4_TXPID5GH          55
-
-#define SROM4_TXRXC             61
 #define SROM4_TXCHAIN_MASK      0x000f
-#define SROM4_TXCHAIN_SHIFT     0
 #define SROM4_RXCHAIN_MASK      0x00f0
-#define SROM4_RXCHAIN_SHIFT     4
 #define SROM4_SWITCH_MASK       0xff00
-#define SROM4_SWITCH_SHIFT      8
 
 /* Per-path fields */
 #define MAX_PATH_SROM           4
-#define SROM4_PATH0             64
-#define SROM4_PATH1             87
-#define SROM4_PATH2             110
-#define SROM4_PATH3             133
-
-#define SROM4_2G_ITT_MAXP       0
-#define SROM4_2G_PA             1
-#define SROM4_5G_ITT_MAXP       5
-#define SROM4_5GLH_MAXP         6
-#define SROM4_5G_PA             7
-#define SROM4_5GL_PA            11
-#define SROM4_5GH_PA            15
-
-/* All the miriad power offsets */
-#define SROM4_2G_CCKPO          156
-#define SROM4_2G_OFDMPO         157
-#define SROM4_5G_OFDMPO         159
-#define SROM4_5GL_OFDMPO        161
-#define SROM4_5GH_OFDMPO        163
-#define SROM4_2G_MCSPO          165
-#define SROM4_5G_MCSPO          173
-#define SROM4_5GL_MCSPO         181
-#define SROM4_5GH_MCSPO         189
-#define SROM4_CDDPO             197
-#define SROM4_STBCPO            198
-#define SROM4_BW40PO            199
-#define SROM4_BWDUPPO           200
 
 #define SROM4_CRCREV            219
 
@@ -424,103 +338,32 @@ struct brcms_varbuf {
 static const struct brcms_sromvar pci_sromvars[] = {
         {BRCMS_SROM_DEVID, 0xffffff00, SRFL_PRHEX | SRFL_NOVAR, PCI_F0DEVID,
          0xffff},
-        {BRCMS_SROM_BOARDREV, 0x0000000e, SRFL_PRHEX, SROM_AABREV,
-         SROM_BR_MASK},
-        {BRCMS_SROM_BOARDREV, 0x000000f0, SRFL_PRHEX, SROM4_BREV, 0xffff},
         {BRCMS_SROM_BOARDREV, 0xffffff00, SRFL_PRHEX, SROM8_BREV, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS, 0x00000002, SRFL_PRHEX, SROM_BFL, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS, 0x00000004, SRFL_PRHEX | SRFL_MORE, SROM_BFL,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM_BFL2, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS, 0x00000008, SRFL_PRHEX | SRFL_MORE, SROM_BFL,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM3_BFL2, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS, 0x00000010, SRFL_PRHEX | SRFL_MORE, SROM4_BFL0,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_BFL1, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS, 0x000000e0, SRFL_PRHEX | SRFL_MORE, SROM5_BFL0,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM5_BFL1, 0xffff},
         {BRCMS_SROM_BOARDFLAGS, 0xffffff00, SRFL_PRHEX | SRFL_MORE, SROM8_BFL0,
          0xffff},
         {BRCMS_SROM_CONT, 0, 0, SROM8_BFL1, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS2, 0x00000010, SRFL_PRHEX | SRFL_MORE, SROM4_BFL2,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_BFL3, 0xffff},
-        {BRCMS_SROM_BOARDFLAGS2, 0x000000e0, SRFL_PRHEX | SRFL_MORE, SROM5_BFL2,
-         0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM5_BFL3, 0xffff},
         {BRCMS_SROM_BOARDFLAGS2, 0xffffff00, SRFL_PRHEX | SRFL_MORE, SROM8_BFL2,
          0xffff},
         {BRCMS_SROM_CONT, 0, 0, SROM8_BFL3, 0xffff},
         {BRCMS_SROM_BOARDTYPE, 0xfffffffc, SRFL_PRHEX, SROM_SSID, 0xffff},
-        {BRCMS_SROM_BOARDNUM, 0x00000006, 0, SROM_MACLO_IL0, 0xffff},
-        {BRCMS_SROM_BOARDNUM, 0x00000008, 0, SROM3_MACLO, 0xffff},
-        {BRCMS_SROM_BOARDNUM, 0x00000010, 0, SROM4_MACLO, 0xffff},
-        {BRCMS_SROM_BOARDNUM, 0x000000e0, 0, SROM5_MACLO, 0xffff},
         {BRCMS_SROM_BOARDNUM, 0xffffff00, 0, SROM8_MACLO, 0xffff},
-        {BRCMS_SROM_CC, 0x00000002, 0, SROM_AABREV, SROM_CC_MASK},
-        {BRCMS_SROM_REGREV, 0x00000008, 0, SROM_OPO, 0xff00},
-        {BRCMS_SROM_REGREV, 0x00000010, 0, SROM4_REGREV, 0x00ff},
-        {BRCMS_SROM_REGREV, 0x000000e0, 0, SROM5_REGREV, 0x00ff},
         {BRCMS_SROM_REGREV, 0xffffff00, 0, SROM8_REGREV, 0x00ff},
-        {BRCMS_SROM_LEDBH0, 0x0000000e, SRFL_NOFFS, SROM_LEDBH10, 0x00ff},
-        {BRCMS_SROM_LEDBH1, 0x0000000e, SRFL_NOFFS, SROM_LEDBH10, 0xff00},
-        {BRCMS_SROM_LEDBH2, 0x0000000e, SRFL_NOFFS, SROM_LEDBH32, 0x00ff},
-        {BRCMS_SROM_LEDBH3, 0x0000000e, SRFL_NOFFS, SROM_LEDBH32, 0xff00},
-        {BRCMS_SROM_LEDBH0, 0x00000010, SRFL_NOFFS, SROM4_LEDBH10, 0x00ff},
-        {BRCMS_SROM_LEDBH1, 0x00000010, SRFL_NOFFS, SROM4_LEDBH10, 0xff00},
-        {BRCMS_SROM_LEDBH2, 0x00000010, SRFL_NOFFS, SROM4_LEDBH32, 0x00ff},
-        {BRCMS_SROM_LEDBH3, 0x00000010, SRFL_NOFFS, SROM4_LEDBH32, 0xff00},
-        {BRCMS_SROM_LEDBH0, 0x000000e0, SRFL_NOFFS, SROM5_LEDBH10, 0x00ff},
-        {BRCMS_SROM_LEDBH1, 0x000000e0, SRFL_NOFFS, SROM5_LEDBH10, 0xff00},
-        {BRCMS_SROM_LEDBH2, 0x000000e0, SRFL_NOFFS, SROM5_LEDBH32, 0x00ff},
-        {BRCMS_SROM_LEDBH3, 0x000000e0, SRFL_NOFFS, SROM5_LEDBH32, 0xff00},
         {BRCMS_SROM_LEDBH0, 0xffffff00, SRFL_NOFFS, SROM8_LEDBH10, 0x00ff},
         {BRCMS_SROM_LEDBH1, 0xffffff00, SRFL_NOFFS, SROM8_LEDBH10, 0xff00},
         {BRCMS_SROM_LEDBH2, 0xffffff00, SRFL_NOFFS, SROM8_LEDBH32, 0x00ff},
         {BRCMS_SROM_LEDBH3, 0xffffff00, SRFL_NOFFS, SROM8_LEDBH32, 0xff00},
-        {BRCMS_SROM_PA0B0, 0x0000000e, SRFL_PRHEX, SROM_WL0PAB0, 0xffff},
-        {BRCMS_SROM_PA0B1, 0x0000000e, SRFL_PRHEX, SROM_WL0PAB1, 0xffff},
-        {BRCMS_SROM_PA0B2, 0x0000000e, SRFL_PRHEX, SROM_WL0PAB2, 0xffff},
-        {BRCMS_SROM_PA0ITSSIT, 0x0000000e, 0, SROM_ITT, 0x00ff},
-        {BRCMS_SROM_PA0MAXPWR, 0x0000000e, 0, SROM_WL10MAXP, 0x00ff},
         {BRCMS_SROM_PA0B0, 0xffffff00, SRFL_PRHEX, SROM8_W0_PAB0, 0xffff},
         {BRCMS_SROM_PA0B1, 0xffffff00, SRFL_PRHEX, SROM8_W0_PAB1, 0xffff},
         {BRCMS_SROM_PA0B2, 0xffffff00, SRFL_PRHEX, SROM8_W0_PAB2, 0xffff},
         {BRCMS_SROM_PA0ITSSIT, 0xffffff00, 0, SROM8_W0_ITTMAXP, 0xff00},
         {BRCMS_SROM_PA0MAXPWR, 0xffffff00, 0, SROM8_W0_ITTMAXP, 0x00ff},
-        {BRCMS_SROM_OPO, 0x0000000c, 0, SROM_OPO, 0x00ff},
         {BRCMS_SROM_OPO, 0xffffff00, 0, SROM8_2G_OFDMPO, 0x00ff},
-        {BRCMS_SROM_AA2G, 0x0000000e, 0, SROM_AABREV, SROM_AA0_MASK},
-        {BRCMS_SROM_AA2G, 0x000000f0, 0, SROM4_AA, 0x00ff},
         {BRCMS_SROM_AA2G, 0xffffff00, 0, SROM8_AA, 0x00ff},
-        {BRCMS_SROM_AA5G, 0x0000000e, 0, SROM_AABREV, SROM_AA1_MASK},
-        {BRCMS_SROM_AA5G, 0x000000f0, 0, SROM4_AA, 0xff00},
         {BRCMS_SROM_AA5G, 0xffffff00, 0, SROM8_AA, 0xff00},
-        {BRCMS_SROM_AG0, 0x0000000e, 0, SROM_AG10, 0x00ff},
-        {BRCMS_SROM_AG1, 0x0000000e, 0, SROM_AG10, 0xff00},
-        {BRCMS_SROM_AG0, 0x000000f0, 0, SROM4_AG10, 0x00ff},
-        {BRCMS_SROM_AG1, 0x000000f0, 0, SROM4_AG10, 0xff00},
-        {BRCMS_SROM_AG2, 0x000000f0, 0, SROM4_AG32, 0x00ff},
-        {BRCMS_SROM_AG3, 0x000000f0, 0, SROM4_AG32, 0xff00},
         {BRCMS_SROM_AG0, 0xffffff00, 0, SROM8_AG10, 0x00ff},
         {BRCMS_SROM_AG1, 0xffffff00, 0, SROM8_AG10, 0xff00},
         {BRCMS_SROM_AG2, 0xffffff00, 0, SROM8_AG32, 0x00ff},
         {BRCMS_SROM_AG3, 0xffffff00, 0, SROM8_AG32, 0xff00},
-        {BRCMS_SROM_PA1B0, 0x0000000e, SRFL_PRHEX, SROM_WL1PAB0, 0xffff},
-        {BRCMS_SROM_PA1B1, 0x0000000e, SRFL_PRHEX, SROM_WL1PAB1, 0xffff},
-        {BRCMS_SROM_PA1B2, 0x0000000e, SRFL_PRHEX, SROM_WL1PAB2, 0xffff},
-        {BRCMS_SROM_PA1LOB0, 0x0000000c, SRFL_PRHEX, SROM_WL1LPAB0, 0xffff},
-        {BRCMS_SROM_PA1LOB1, 0x0000000c, SRFL_PRHEX, SROM_WL1LPAB1, 0xffff},
-        {BRCMS_SROM_PA1LOB2, 0x0000000c, SRFL_PRHEX, SROM_WL1LPAB2, 0xffff},
-        {BRCMS_SROM_PA1HIB0, 0x0000000c, SRFL_PRHEX, SROM_WL1HPAB0, 0xffff},
-        {BRCMS_SROM_PA1HIB1, 0x0000000c, SRFL_PRHEX, SROM_WL1HPAB1, 0xffff},
-        {BRCMS_SROM_PA1HIB2, 0x0000000c, SRFL_PRHEX, SROM_WL1HPAB2, 0xffff},
-        {BRCMS_SROM_PA1ITSSIT, 0x0000000e, 0, SROM_ITT, 0xff00},
-        {BRCMS_SROM_PA1MAXPWR, 0x0000000e, 0, SROM_WL10MAXP, 0xff00},
-        {BRCMS_SROM_PA1LOMAXPWR, 0x0000000c, 0, SROM_WL1LHMAXP, 0xff00},
-        {BRCMS_SROM_PA1HIMAXPWR, 0x0000000c, 0, SROM_WL1LHMAXP, 0x00ff},
         {BRCMS_SROM_PA1B0, 0xffffff00, SRFL_PRHEX, SROM8_W1_PAB0, 0xffff},
         {BRCMS_SROM_PA1B1, 0xffffff00, SRFL_PRHEX, SROM8_W1_PAB1, 0xffff},
         {BRCMS_SROM_PA1B2, 0xffffff00, SRFL_PRHEX, SROM8_W1_PAB2, 0xffff},
@@ -534,40 +377,20 @@ static const struct brcms_sromvar pci_sromvars[] = {
         {BRCMS_SROM_PA1MAXPWR, 0xffffff00, 0, SROM8_W1_ITTMAXP, 0x00ff},
         {BRCMS_SROM_PA1LOMAXPWR, 0xffffff00, 0, SROM8_W1_MAXP_LCHC, 0xff00},
         {BRCMS_SROM_PA1HIMAXPWR, 0xffffff00, 0, SROM8_W1_MAXP_LCHC, 0x00ff},
-        {BRCMS_SROM_BXA2G, 0x00000008, 0, SROM_BXARSSI2G, 0x1800},
-        {BRCMS_SROM_RSSISAV2G, 0x00000008, 0, SROM_BXARSSI2G, 0x0700},
-        {BRCMS_SROM_RSSISMC2G, 0x00000008, 0, SROM_BXARSSI2G, 0x00f0},
-        {BRCMS_SROM_RSSISMF2G, 0x00000008, 0, SROM_BXARSSI2G, 0x000f},
         {BRCMS_SROM_BXA2G, 0xffffff00, 0, SROM8_BXARSSI2G, 0x1800},
         {BRCMS_SROM_RSSISAV2G, 0xffffff00, 0, SROM8_BXARSSI2G, 0x0700},
         {BRCMS_SROM_RSSISMC2G, 0xffffff00, 0, SROM8_BXARSSI2G, 0x00f0},
         {BRCMS_SROM_RSSISMF2G, 0xffffff00, 0, SROM8_BXARSSI2G, 0x000f},
-        {BRCMS_SROM_BXA5G, 0x00000008, 0, SROM_BXARSSI5G, 0x1800},
-        {BRCMS_SROM_RSSISAV5G, 0x00000008, 0, SROM_BXARSSI5G, 0x0700},
-        {BRCMS_SROM_RSSISMC5G, 0x00000008, 0, SROM_BXARSSI5G, 0x00f0},
-        {BRCMS_SROM_RSSISMF5G, 0x00000008, 0, SROM_BXARSSI5G, 0x000f},
         {BRCMS_SROM_BXA5G, 0xffffff00, 0, SROM8_BXARSSI5G, 0x1800},
         {BRCMS_SROM_RSSISAV5G, 0xffffff00, 0, SROM8_BXARSSI5G, 0x0700},
         {BRCMS_SROM_RSSISMC5G, 0xffffff00, 0, SROM8_BXARSSI5G, 0x00f0},
         {BRCMS_SROM_RSSISMF5G, 0xffffff00, 0, SROM8_BXARSSI5G, 0x000f},
-        {BRCMS_SROM_TRI2G, 0x00000008, 0, SROM_TRI52G, 0x00ff},
-        {BRCMS_SROM_TRI5G, 0x00000008, 0, SROM_TRI52G, 0xff00},
-        {BRCMS_SROM_TRI5GL, 0x00000008, 0, SROM_TRI5GHL, 0x00ff},
-        {BRCMS_SROM_TRI5GH, 0x00000008, 0, SROM_TRI5GHL, 0xff00},
         {BRCMS_SROM_TRI2G, 0xffffff00, 0, SROM8_TRI52G, 0x00ff},
         {BRCMS_SROM_TRI5G, 0xffffff00, 0, SROM8_TRI52G, 0xff00},
         {BRCMS_SROM_TRI5GL, 0xffffff00, 0, SROM8_TRI5GHL, 0x00ff},
         {BRCMS_SROM_TRI5GH, 0xffffff00, 0, SROM8_TRI5GHL, 0xff00},
-        {BRCMS_SROM_RXPO2G, 0x00000008, SRFL_PRSIGN, SROM_RXPO52G, 0x00ff},
-        {BRCMS_SROM_RXPO5G, 0x00000008, SRFL_PRSIGN, SROM_RXPO52G, 0xff00},
         {BRCMS_SROM_RXPO2G, 0xffffff00, SRFL_PRSIGN, SROM8_RXPO52G, 0x00ff},
         {BRCMS_SROM_RXPO5G, 0xffffff00, SRFL_PRSIGN, SROM8_RXPO52G, 0xff00},
-        {BRCMS_SROM_TXCHAIN, 0x000000f0, SRFL_NOFFS, SROM4_TXRXC,
-         SROM4_TXCHAIN_MASK},
-        {BRCMS_SROM_RXCHAIN, 0x000000f0, SRFL_NOFFS, SROM4_TXRXC,
-         SROM4_RXCHAIN_MASK},
-        {BRCMS_SROM_ANTSWITCH, 0x000000f0, SRFL_NOFFS, SROM4_TXRXC,
-         SROM4_SWITCH_MASK},
         {BRCMS_SROM_TXCHAIN, 0xffffff00, SRFL_NOFFS, SROM8_TXRXC,
          SROM4_TXCHAIN_MASK},
         {BRCMS_SROM_RXCHAIN, 0xffffff00, SRFL_NOFFS, SROM8_TXRXC,
@@ -594,43 +417,11 @@ static const struct brcms_sromvar pci_sromvars[] = {
          SROM8_FEM_ANTSWLUT_MASK},
         {BRCMS_SROM_TEMPTHRESH, 0xffffff00, 0, SROM8_THERMAL, 0xff00},
         {BRCMS_SROM_TEMPOFFSET, 0xffffff00, 0, SROM8_THERMAL, 0x00ff},
-        {BRCMS_SROM_TXPID2GA0, 0x000000f0, 0, SROM4_TXPID2G, 0x00ff},
-        {BRCMS_SROM_TXPID2GA1, 0x000000f0, 0, SROM4_TXPID2G, 0xff00},
-        {BRCMS_SROM_TXPID2GA2, 0x000000f0, 0, SROM4_TXPID2G + 1, 0x00ff},
-        {BRCMS_SROM_TXPID2GA3, 0x000000f0, 0, SROM4_TXPID2G + 1, 0xff00},
-        {BRCMS_SROM_TXPID5GA0, 0x000000f0, 0, SROM4_TXPID5G, 0x00ff},
-        {BRCMS_SROM_TXPID5GA1, 0x000000f0, 0, SROM4_TXPID5G, 0xff00},
-        {BRCMS_SROM_TXPID5GA2, 0x000000f0, 0, SROM4_TXPID5G + 1, 0x00ff},
-        {BRCMS_SROM_TXPID5GA3, 0x000000f0, 0, SROM4_TXPID5G + 1, 0xff00},
-        {BRCMS_SROM_TXPID5GLA0, 0x000000f0, 0, SROM4_TXPID5GL, 0x00ff},
-        {BRCMS_SROM_TXPID5GLA1, 0x000000f0, 0, SROM4_TXPID5GL, 0xff00},
-        {BRCMS_SROM_TXPID5GLA2, 0x000000f0, 0, SROM4_TXPID5GL + 1, 0x00ff},
-        {BRCMS_SROM_TXPID5GLA3, 0x000000f0, 0, SROM4_TXPID5GL + 1, 0xff00},
-        {BRCMS_SROM_TXPID5GHA0, 0x000000f0, 0, SROM4_TXPID5GH, 0x00ff},
-        {BRCMS_SROM_TXPID5GHA1, 0x000000f0, 0, SROM4_TXPID5GH, 0xff00},
-        {BRCMS_SROM_TXPID5GHA2, 0x000000f0, 0, SROM4_TXPID5GH + 1, 0x00ff},
-        {BRCMS_SROM_TXPID5GHA3, 0x000000f0, 0, SROM4_TXPID5GH + 1, 0xff00},
-
-        {BRCMS_SROM_CCODE, 0x0000000f, SRFL_CCODE, SROM_CCODE, 0xffff},
-        {BRCMS_SROM_CCODE, 0x00000010, SRFL_CCODE, SROM4_CCODE, 0xffff},
-        {BRCMS_SROM_CCODE, 0x000000e0, SRFL_CCODE, SROM5_CCODE, 0xffff},
+
         {BRCMS_SROM_CCODE, 0xffffff00, SRFL_CCODE, SROM8_CCODE, 0xffff},
         {BRCMS_SROM_MACADDR, 0xffffff00, SRFL_ETHADDR, SROM8_MACHI, 0xffff},
-        {BRCMS_SROM_MACADDR, 0x000000e0, SRFL_ETHADDR, SROM5_MACHI, 0xffff},
-        {BRCMS_SROM_MACADDR, 0x00000010, SRFL_ETHADDR, SROM4_MACHI, 0xffff},
-        {BRCMS_SROM_MACADDR, 0x00000008, SRFL_ETHADDR, SROM3_MACHI, 0xffff},
-        {BRCMS_SROM_IL0MACADDR, 0x00000007, SRFL_ETHADDR, SROM_MACHI_IL0,
-         0xffff},
-        {BRCMS_SROM_ET1MACADDR, 0x00000007, SRFL_ETHADDR, SROM_MACHI_ET1,
-         0xffff},
         {BRCMS_SROM_LEDDC, 0xffffff00, SRFL_NOFFS | SRFL_LEDDC, SROM8_LEDDC,
          0xffff},
-        {BRCMS_SROM_LEDDC, 0x000000e0, SRFL_NOFFS | SRFL_LEDDC, SROM5_LEDDC,
-         0xffff},
-        {BRCMS_SROM_LEDDC, 0x00000010, SRFL_NOFFS | SRFL_LEDDC, SROM4_LEDDC,
-         0xffff},
-        {BRCMS_SROM_LEDDC, 0x00000008, SRFL_NOFFS | SRFL_LEDDC, SROM3_LEDDC,
-         0xffff},
         {BRCMS_SROM_RAWTEMPSENSE, 0xffffff00, SRFL_PRHEX, SROM8_MPWR_RAWTS,
          0x01ff},
         {BRCMS_SROM_MEASPOWER, 0xffffff00, SRFL_PRHEX, SROM8_MPWR_RAWTS,
@@ -650,16 +441,7 @@ static const struct brcms_sromvar pci_sromvars[] = {
         {BRCMS_SROM_PHYCAL_TEMPDELTA, 0xffffff00, 0, SROM8_PHYCAL_TEMPDELTA,
          0x00ff},
 
-        {BRCMS_SROM_CCK2GPO, 0x000000f0, 0, SROM4_2G_CCKPO, 0xffff},
         {BRCMS_SROM_CCK2GPO, 0x00000100, 0, SROM8_2G_CCKPO, 0xffff},
-        {BRCMS_SROM_OFDM2GPO, 0x000000f0, SRFL_MORE, SROM4_2G_OFDMPO, 0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_2G_OFDMPO + 1, 0xffff},
-        {BRCMS_SROM_OFDM5GPO, 0x000000f0, SRFL_MORE, SROM4_5G_OFDMPO, 0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_5G_OFDMPO + 1, 0xffff},
-        {BRCMS_SROM_OFDM5GLPO, 0x000000f0, SRFL_MORE, SROM4_5GL_OFDMPO, 0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_5GL_OFDMPO + 1, 0xffff},
-        {BRCMS_SROM_OFDM5GHPO, 0x000000f0, SRFL_MORE, SROM4_5GH_OFDMPO, 0xffff},
-        {BRCMS_SROM_CONT, 0, 0, SROM4_5GH_OFDMPO + 1, 0xffff},
         {BRCMS_SROM_OFDM2GPO, 0x00000100, SRFL_MORE, SROM8_2G_OFDMPO, 0xffff},
         {BRCMS_SROM_CONT, 0, 0, SROM8_2G_OFDMPO + 1, 0xffff},
         {BRCMS_SROM_OFDM5GPO, 0x00000100, SRFL_MORE, SROM8_5G_OFDMPO, 0xffff},
@@ -668,38 +450,6 @@ static const struct brcms_sromvar pci_sromvars[] = {
         {BRCMS_SROM_CONT, 0, 0, SROM8_5GL_OFDMPO + 1, 0xffff},
         {BRCMS_SROM_OFDM5GHPO, 0x00000100, SRFL_MORE, SROM8_5GH_OFDMPO, 0xffff},
         {BRCMS_SROM_CONT, 0, 0, SROM8_5GH_OFDMPO + 1, 0xffff},
-        {BRCMS_SROM_MCS2GPO0, 0x000000f0, 0, SROM4_2G_MCSPO, 0xffff},
-        {BRCMS_SROM_MCS2GPO1, 0x000000f0, 0, SROM4_2G_MCSPO + 1, 0xffff},
-        {BRCMS_SROM_MCS2GPO2, 0x000000f0, 0, SROM4_2G_MCSPO + 2, 0xffff},
-        {BRCMS_SROM_MCS2GPO3, 0x000000f0, 0, SROM4_2G_MCSPO + 3, 0xffff},
-        {BRCMS_SROM_MCS2GPO4, 0x000000f0, 0, SROM4_2G_MCSPO + 4, 0xffff},
-        {BRCMS_SROM_MCS2GPO5, 0x000000f0, 0, SROM4_2G_MCSPO + 5, 0xffff},
-        {BRCMS_SROM_MCS2GPO6, 0x000000f0, 0, SROM4_2G_MCSPO + 6, 0xffff},
-        {BRCMS_SROM_MCS2GPO7, 0x000000f0, 0, SROM4_2G_MCSPO + 7, 0xffff},
-        {BRCMS_SROM_MCS5GPO0, 0x000000f0, 0, SROM4_5G_MCSPO, 0xffff},
-        {BRCMS_SROM_MCS5GPO1, 0x000000f0, 0, SROM4_5G_MCSPO + 1, 0xffff},
-        {BRCMS_SROM_MCS5GPO2, 0x000000f0, 0, SROM4_5G_MCSPO + 2, 0xffff},
-        {BRCMS_SROM_MCS5GPO3, 0x000000f0, 0, SROM4_5G_MCSPO + 3, 0xffff},
-        {BRCMS_SROM_MCS5GPO4, 0x000000f0, 0, SROM4_5G_MCSPO + 4, 0xffff},
-        {BRCMS_SROM_MCS5GPO5, 0x000000f0, 0, SROM4_5G_MCSPO + 5, 0xffff},
-        {BRCMS_SROM_MCS5GPO6, 0x000000f0, 0, SROM4_5G_MCSPO + 6, 0xffff},
-        {BRCMS_SROM_MCS5GPO7, 0x000000f0, 0, SROM4_5G_MCSPO + 7, 0xffff},
-        {BRCMS_SROM_MCS5GLPO0, 0x000000f0, 0, SROM4_5GL_MCSPO, 0xffff},
-        {BRCMS_SROM_MCS5GLPO1, 0x000000f0, 0, SROM4_5GL_MCSPO + 1, 0xffff},
-        {BRCMS_SROM_MCS5GLPO2, 0x000000f0, 0, SROM4_5GL_MCSPO + 2, 0xffff},
-        {BRCMS_SROM_MCS5GLPO3, 0x000000f0, 0, SROM4_5GL_MCSPO + 3, 0xffff},
-        {BRCMS_SROM_MCS5GLPO4, 0x000000f0, 0, SROM4_5GL_MCSPO + 4, 0xffff},
-        {BRCMS_SROM_MCS5GLPO5, 0x000000f0, 0, SROM4_5GL_MCSPO + 5, 0xffff},
-        {BRCMS_SROM_MCS5GLPO6, 0x000000f0, 0, SROM4_5GL_MCSPO + 6, 0xffff},
-        {BRCMS_SROM_MCS5GLPO7, 0x000000f0, 0, SROM4_5GL_MCSPO + 7, 0xffff},
-        {BRCMS_SROM_MCS5GHPO0, 0x000000f0, 0, SROM4_5GH_MCSPO, 0xffff},
-        {BRCMS_SROM_MCS5GHPO1, 0x000000f0, 0, SROM4_5GH_MCSPO + 1, 0xffff},
-        {BRCMS_SROM_MCS5GHPO2, 0x000000f0, 0, SROM4_5GH_MCSPO + 2, 0xffff},
-        {BRCMS_SROM_MCS5GHPO3, 0x000000f0, 0, SROM4_5GH_MCSPO + 3, 0xffff},
-        {BRCMS_SROM_MCS5GHPO4, 0x000000f0, 0, SROM4_5GH_MCSPO + 4, 0xffff},
-        {BRCMS_SROM_MCS5GHPO5, 0x000000f0, 0, SROM4_5GH_MCSPO + 5, 0xffff},
-        {BRCMS_SROM_MCS5GHPO6, 0x000000f0, 0, SROM4_5GH_MCSPO + 6, 0xffff},
-        {BRCMS_SROM_MCS5GHPO7, 0x000000f0, 0, SROM4_5GH_MCSPO + 7, 0xffff},
         {BRCMS_SROM_MCS2GPO0, 0x00000100, 0, SROM8_2G_MCSPO, 0xffff},
         {BRCMS_SROM_MCS2GPO1, 0x00000100, 0, SROM8_2G_MCSPO + 1, 0xffff},
         {BRCMS_SROM_MCS2GPO2, 0x00000100, 0, SROM8_2G_MCSPO + 2, 0xffff},
@@ -732,10 +482,6 @@ static const struct brcms_sromvar pci_sromvars[] = {
         {BRCMS_SROM_MCS5GHPO5, 0x00000100, 0, SROM8_5GH_MCSPO + 5, 0xffff},
         {BRCMS_SROM_MCS5GHPO6, 0x00000100, 0, SROM8_5GH_MCSPO + 6, 0xffff},
         {BRCMS_SROM_MCS5GHPO7, 0x00000100, 0, SROM8_5GH_MCSPO + 7, 0xffff},
-        {BRCMS_SROM_CDDPO, 0x000000f0, 0, SROM4_CDDPO, 0xffff},
-        {BRCMS_SROM_STBCPO, 0x000000f0, 0, SROM4_STBCPO, 0xffff},
-        {BRCMS_SROM_BW40PO, 0x000000f0, 0, SROM4_BW40PO, 0xffff},
-        {BRCMS_SROM_BWDUPPO, 0x000000f0, 0, SROM4_BWDUPPO, 0xffff},
         {BRCMS_SROM_CDDPO, 0x00000100, 0, SROM8_CDDPO, 0xffff},
         {BRCMS_SROM_STBCPO, 0x00000100, 0, SROM8_STBCPO, 0xffff},
         {BRCMS_SROM_BW40PO, 0x00000100, 0, SROM8_BW40PO, 0xffff},
@@ -811,34 +557,6 @@ static const struct brcms_sromvar pci_sromvars[] = {
 };
 
 static const struct brcms_sromvar perpath_pci_sromvars[] = {
-        {BRCMS_SROM_MAXP2GA0, 0x000000f0, 0, SROM4_2G_ITT_MAXP, 0x00ff},
-        {BRCMS_SROM_ITT2GA0, 0x000000f0, 0, SROM4_2G_ITT_MAXP, 0xff00},
-        {BRCMS_SROM_ITT5GA0, 0x000000f0, 0, SROM4_5G_ITT_MAXP, 0xff00},
-        {BRCMS_SROM_PA2GW0A0, 0x000000f0, SRFL_PRHEX, SROM4_2G_PA, 0xffff},
-        {BRCMS_SROM_PA2GW1A0, 0x000000f0, SRFL_PRHEX, SROM4_2G_PA + 1, 0xffff},
-        {BRCMS_SROM_PA2GW2A0, 0x000000f0, SRFL_PRHEX, SROM4_2G_PA + 2, 0xffff},
-        {BRCMS_SROM_PA2GW3A0, 0x000000f0, SRFL_PRHEX, SROM4_2G_PA + 3, 0xffff},
-        {BRCMS_SROM_MAXP5GA0, 0x000000f0, 0, SROM4_5G_ITT_MAXP, 0x00ff},
-        {BRCMS_SROM_MAXP5GHA0, 0x000000f0, 0, SROM4_5GLH_MAXP, 0x00ff},
-        {BRCMS_SROM_MAXP5GLA0, 0x000000f0, 0, SROM4_5GLH_MAXP, 0xff00},
-        {BRCMS_SROM_PA5GW0A0, 0x000000f0, SRFL_PRHEX, SROM4_5G_PA, 0xffff},
-        {BRCMS_SROM_PA5GW1A0, 0x000000f0, SRFL_PRHEX, SROM4_5G_PA + 1, 0xffff},
-        {BRCMS_SROM_PA5GW2A0, 0x000000f0, SRFL_PRHEX, SROM4_5G_PA + 2, 0xffff},
-        {BRCMS_SROM_PA5GW3A0, 0x000000f0, SRFL_PRHEX, SROM4_5G_PA + 3, 0xffff},
-        {BRCMS_SROM_PA5GLW0A0, 0x000000f0, SRFL_PRHEX, SROM4_5GL_PA, 0xffff},
-        {BRCMS_SROM_PA5GLW1A0, 0x000000f0, SRFL_PRHEX, SROM4_5GL_PA + 1,
-         0xffff},
-        {BRCMS_SROM_PA5GLW2A0, 0x000000f0, SRFL_PRHEX, SROM4_5GL_PA + 2,
-         0xffff},
-        {BRCMS_SROM_PA5GLW3A0, 0x000000f0, SRFL_PRHEX, SROM4_5GL_PA + 3,
-         0xffff},
-        {BRCMS_SROM_PA5GHW0A0, 0x000000f0, SRFL_PRHEX, SROM4_5GH_PA, 0xffff},
-        {BRCMS_SROM_PA5GHW1A0, 0x000000f0, SRFL_PRHEX, SROM4_5GH_PA + 1,
-         0xffff},
-        {BRCMS_SROM_PA5GHW2A0, 0x000000f0, SRFL_PRHEX, SROM4_5GH_PA + 2,
-         0xffff},
-        {BRCMS_SROM_PA5GHW3A0, 0x000000f0, SRFL_PRHEX, SROM4_5GH_PA + 3,
-         0xffff},
         {BRCMS_SROM_MAXP2GA0, 0xffffff00, 0, SROM8_2G_ITT_MAXP, 0x00ff},
         {BRCMS_SROM_ITT2GA0, 0xffffff00, 0, SROM8_2G_ITT_MAXP, 0xff00},
         {BRCMS_SROM_ITT5GA0, 0xffffff00, 0, SROM8_5G_ITT_MAXP, 0xff00},
@@ -868,24 +586,17 @@ static const struct brcms_sromvar perpath_pci_sromvars[] = {
  * shared between devices. */
 static u8 brcms_srom_crc8_table[CRC8_TABLE_SIZE];
 
-static u16 __iomem *
+static u8 __iomem *
 srom_window_address(struct si_pub *sih, u8 __iomem *curmap)
 {
         if (sih->ccrev < 32)
-                return (u16 __iomem *)(curmap + PCI_BAR0_SPROM_OFFSET);
+                return curmap + PCI_BAR0_SPROM_OFFSET;
         if (sih->cccaps & CC_CAP_SROM)
-                return (u16 __iomem *)
-                       (curmap + PCI_16KB0_CCREGS_OFFSET + CC_SROM_OTP);
+                return curmap + PCI_16KB0_CCREGS_OFFSET + CC_SROM_OTP;
 
         return NULL;
 }
 
-/* Parse SROM and create name=value pairs. 'srom' points to
- * the SROM word array. 'off' specifies the offset of the
- * first word 'srom' points to, which should be either 0 or
- * SROM3_SWRG_OFF (full SROM or software region).
- */
-
 static uint mask_shift(u16 mask)
 {
         uint i;
@@ -906,18 +617,16 @@ static uint mask_width(u16 mask)
         return 0;
 }
 
-static inline void ltoh16_buf(u16 *buf, unsigned int size)
+static inline void le16_to_cpu_buf(u16 *buf, uint nwords)
 {
-        size /= 2;
-        while (size--)
-                *(buf + size) = le16_to_cpu(*(__le16 *)(buf + size));
+        while (nwords--)
+                *(buf + nwords) = le16_to_cpu(*(__le16 *)(buf + nwords));
 }
 
-static inline void htol16_buf(u16 *buf, unsigned int size)
+static inline void cpu_to_le16_buf(u16 *buf, uint nwords)
 {
-        size /= 2;
-        while (size--)
-                *(__le16 *)(buf + size) = cpu_to_le16(*(buf + size));
+        while (nwords--)
+                *(__le16 *)(buf + nwords) = cpu_to_le16(*(buf + nwords));
 }
 
 /*
@@ -929,11 +638,14 @@ _initvars_srom_pci(u8 sromrev, u16 *srom, struct list_head *var_list)
         struct brcms_srom_list_head *entry;
         enum brcms_srom_id id;
         u16 w;
-        u32 val;
+        u32 val = 0;
         const struct brcms_sromvar *srv;
         uint width;
         uint flags;
         u32 sr = (1 << sromrev);
+        uint p;
+        uint pb =  SROM8_PATH0;
+        const uint psz = SROM8_PATH1 - SROM8_PATH0;
 
         /* first store the srom revision */
         entry = kzalloc(sizeof(struct brcms_srom_list_head), GFP_KERNEL);
@@ -1031,47 +743,34 @@ _initvars_srom_pci(u8 sromrev, u16 *srom, struct list_head *var_list)
                 list_add(&entry->var_list, var_list);
         }
 
-        if (sromrev >= 4) {
-                /* Do per-path variables */
-                uint p, pb, psz;
-
-                if (sromrev >= 8) {
-                        pb = SROM8_PATH0;
-                        psz = SROM8_PATH1 - SROM8_PATH0;
-                } else {
-                        pb = SROM4_PATH0;
-                        psz = SROM4_PATH1 - SROM4_PATH0;
-                }
-
-                for (p = 0; p < MAX_PATH_SROM; p++) {
-                        for (srv = perpath_pci_sromvars;
-                             srv->varid != BRCMS_SROM_NULL; srv++) {
-                                if ((srv->revmask & sr) == 0)
-                                        continue;
+        for (p = 0; p < MAX_PATH_SROM; p++) {
+                for (srv = perpath_pci_sromvars;
+                     srv->varid != BRCMS_SROM_NULL; srv++) {
+                        if ((srv->revmask & sr) == 0)
+                                continue;
 
-                                if (srv->flags & SRFL_NOVAR)
-                                        continue;
+                        if (srv->flags & SRFL_NOVAR)
+                                continue;
 
-                                w = srom[pb + srv->off];
-                                val = (w & srv->mask) >> mask_shift(srv->mask);
-                                width = mask_width(srv->mask);
+                        w = srom[pb + srv->off];
+                        val = (w & srv->mask) >> mask_shift(srv->mask);
+                        width = mask_width(srv->mask);
 
-                                /* Cheating: no per-path var is more than
-                                 * 1 word */
-                                if ((srv->flags & SRFL_NOFFS)
-                                    && ((int)val == (1 << width) - 1))
-                                        continue;
+                        /* Cheating: no per-path var is more than
+                         * 1 word */
+                        if ((srv->flags & SRFL_NOFFS)
+                            && ((int)val == (1 << width) - 1))
+                                continue;
 
-                                entry =
-                                    kzalloc(sizeof(struct brcms_srom_list_head),
-                                            GFP_KERNEL);
-                                entry->varid = srv->varid+p;
-                                entry->var_type = BRCMS_SROM_UNUMBER;
-                                entry->uval = val;
-                                list_add(&entry->var_list, var_list);
-                        }
-                        pb += psz;
+                        entry =
+                            kzalloc(sizeof(struct brcms_srom_list_head),
+                                    GFP_KERNEL);
+                        entry->varid = srv->varid+p;
+                        entry->var_type = BRCMS_SROM_UNUMBER;
+                        entry->uval = val;
+                        list_add(&entry->var_list, var_list);
                 }
+                pb += psz;
         }
 }
 
@@ -1080,41 +779,38 @@ _initvars_srom_pci(u8 sromrev, u16 *srom, struct list_head *var_list)
  * Return 0 on success, nonzero on error.
  */
 static int
-sprom_read_pci(struct si_pub *sih, u16 __iomem *sprom, uint wordoff,
+sprom_read_pci(struct si_pub *sih, u8 __iomem *sprom, uint wordoff,
                u16 *buf, uint nwords, bool check_crc)
 {
         int err = 0;
         uint i;
+        u8 *bbuf = (u8 *)buf; /* byte buffer */
+        uint nbytes = nwords << 1;
 
-        /* read the sprom */
-        for (i = 0; i < nwords; i++)
-                buf[i] = R_REG(&sprom[wordoff + i]);
-
-        if (check_crc) {
+        /* read the sprom in bytes */
+        for (i = 0; i < nbytes; i++)
+                bbuf[i] = readb(sprom+i);
 
-                if (buf[0] == 0xffff)
-                        /*
-                         * The hardware thinks that an srom that starts with
-                         * 0xffff is blank, regardless of the rest of the
-                         * content, so declare it bad.
-                         */
-                        return -ENODATA;
-
-                /* fixup the endianness so crc8 will pass */
-                htol16_buf(buf, nwords * 2);
-                if (crc8(brcms_srom_crc8_table, (u8 *) buf, nwords * 2,
-                         CRC8_INIT_VALUE) !=
-                         CRC8_GOOD_VALUE(brcms_srom_crc8_table))
-                        /* DBG only pci always read srom4 first, then srom8/9 */
-                        err = -EIO;
+        if (buf[0] == 0xffff)
+                /*
+                 * The hardware thinks that an srom that starts with
+                 * 0xffff is blank, regardless of the rest of the
+                 * content, so declare it bad.
+                 */
+                return -ENODATA;
 
+        if (check_crc &&
+            crc8(brcms_srom_crc8_table, bbuf, nbytes, CRC8_INIT_VALUE) !=
+                 CRC8_GOOD_VALUE(brcms_srom_crc8_table))
+                err = -EIO;
+        else
                 /* now correct the endianness of the byte array */
-                ltoh16_buf(buf, nwords * 2);
-        }
+                le16_to_cpu_buf(buf, nwords);
+
         return err;
 }
 
-static int otp_read_pci(struct si_pub *sih, u16 *buf, uint bufsz)
+static int otp_read_pci(struct si_pub *sih, u16 *buf, uint nwords)
 {
         u8 *otp;
         uint sz = OTP_SZ_MAX / 2;       /* size in words */
@@ -1126,7 +822,8 @@ static int otp_read_pci(struct si_pub *sih, u16 *buf, uint bufsz)
 
         err = otp_read_region(sih, OTP_HW_RGN, (u16 *) otp, &sz);
 
-        memcpy(buf, otp, bufsz);
+        sz = min_t(uint, sz, nwords);
+        memcpy(buf, otp, sz * 2);
 
         kfree(otp);
 
@@ -1139,13 +836,13 @@ static int otp_read_pci(struct si_pub *sih, u16 *buf, uint bufsz)
                 return -ENODATA;
 
         /* fixup the endianness so crc8 will pass */
-        htol16_buf(buf, bufsz);
-        if (crc8(brcms_srom_crc8_table, (u8 *) buf, SROM4_WORDS * 2,
+        cpu_to_le16_buf(buf, sz);
+        if (crc8(brcms_srom_crc8_table, (u8 *) buf, sz * 2,
                  CRC8_INIT_VALUE) != CRC8_GOOD_VALUE(brcms_srom_crc8_table))
                 err = -EIO;
-
-        /* now correct the endianness of the byte array */
-        ltoh16_buf(buf, bufsz);
+        else
+                /* now correct the endianness of the byte array */
+                le16_to_cpu_buf(buf, sz);
 
         return err;
 }
@@ -1157,7 +854,7 @@ static int otp_read_pci(struct si_pub *sih, u16 *buf, uint bufsz)
 static int initvars_srom_pci(struct si_pub *sih, void __iomem *curmap)
 {
         u16 *srom;
-        u16 __iomem *sromwindow;
+        u8 __iomem *sromwindow;
         u8 sromrev = 0;
         u32 sr;
         int err = 0;
@@ -1173,29 +870,16 @@ static int initvars_srom_pci(struct si_pub *sih, void __iomem *curmap)
 
         crc8_populate_lsb(brcms_srom_crc8_table, SROM_CRC8_POLY);
         if (ai_is_sprom_available(sih)) {
-                err = sprom_read_pci(sih, sromwindow, 0, srom, SROM_WORDS,
-                                     true);
-
-                if ((srom[SROM4_SIGN] == SROM4_SIGNATURE) ||
-                    (((sih->buscoretype == PCIE_CORE_ID)
-                      && (sih->buscorerev >= 6))
-                     || ((sih->buscoretype == PCI_CORE_ID)
-                         && (sih->buscorerev >= 0xe)))) {
-                        /* sromrev >= 4, read more */
-                        err = sprom_read_pci(sih, sromwindow, 0, srom,
-                                             SROM4_WORDS, true);
-                        sromrev = srom[SROM4_CRCREV] & 0xff;
-                } else if (err == 0) {
-                        /* srom is good and is rev < 4 */
+                err = sprom_read_pci(sih, sromwindow, 0, srom,
+                                     SROM4_WORDS, true);
+
+                if (err == 0)
+                        /* srom read and passed crc */
                         /* top word of sprom contains version and crc8 */
-                        sromrev = srom[SROM_CRCREV] & 0xff;
-                        /* bcm4401 sroms misprogrammed */
-                        if (sromrev == 0x10)
-                                sromrev = 1;
-                }
+                        sromrev = srom[SROM4_CRCREV] & 0xff;
         } else {
                 /* Use OTP if SPROM not available */
-                err = otp_read_pci(sih, srom, SROM_MAX);
+                err = otp_read_pci(sih, srom, SROM4_WORDS);
                 if (err == 0)
                         /* OTP only contain SROM rev8/rev9 for now */
                         sromrev = srom[SROM4_CRCREV] & 0xff;
@@ -1208,10 +892,9 @@ static int initvars_srom_pci(struct si_pub *sih, void __iomem *curmap)
                 sr = 1 << sromrev;
 
                 /*
-                 * srom version check: Current valid versions: 1, 2, 3, 4, 5, 8,
-                 * 9
+                 * srom version check: Current valid versions: 8, 9
                  */
-                if ((sr & 0x33e) == 0) {
+                if ((sr & 0x300) == 0) {
                         err = -EINVAL;
                         goto errout;
                 }
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/srom.h b/drivers/net/wireless/brcm80211/brcmsmac/srom.h
index 708c43ff51cc..c81df9798e50 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/srom.h
+++ b/drivers/net/wireless/brcm80211/brcmsmac/srom.h
@@ -26,9 +26,4 @@ extern void srom_free_vars(struct si_pub *sih);
 extern int srom_read(struct si_pub *sih, uint bus, void *curmap,
                      uint byteoff, uint nbytes, u16 *buf, bool check_crc);
 
-/* parse standard PCMCIA cis, normally used by SB/PCMCIA/SDIO/SPI/OTP
- *   and extract from it into name=value pairs
- */
-extern int srom_parsecis(u8 **pcis, uint ciscnt,
-                         char **vars, uint *count);
 #endif                          /* _BRCM_SROM_H_ */
diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
index f27c48910827..b7537f70a795 100644
--- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
+++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
@@ -16,6 +16,7 @@
 
 #include <linux/netdevice.h>
 #include <linux/module.h>
+
 #include <brcmu_utils.h>
 
 MODULE_AUTHOR("Broadcom Corporation");
@@ -40,74 +41,20 @@ EXPORT_SYMBOL(brcmu_pkt_buf_get_skb);
 /* Free the driver packet. Free the tag if present */
 void brcmu_pkt_buf_free_skb(struct sk_buff *skb)
 {
-        struct sk_buff *nskb;
-        int nest = 0;
-
-        /* perversion: we use skb->next to chain multi-skb packets */
-        while (skb) {
-                nskb = skb->next;
-                skb->next = NULL;
-
-                if (skb->destructor)
-                        /* cannot kfree_skb() on hard IRQ (net/core/skbuff.c) if
-                         * destructor exists
-                         */
-                        dev_kfree_skb_any(skb);
-                else
-                        /* can free immediately (even in_irq()) if destructor
-                         * does not exist
-                         */
-                        dev_kfree_skb(skb);
-
-                nest++;
-                skb = nskb;
-        }
+        WARN_ON(skb->next);
+        if (skb->destructor)
+                /* cannot kfree_skb() on hard IRQ (net/core/skbuff.c) if
+                 * destructor exists
+                 */
+                dev_kfree_skb_any(skb);
+        else
+                /* can free immediately (even in_irq()) if destructor
+                 * does not exist
+                 */
+                dev_kfree_skb(skb);
 }
 EXPORT_SYMBOL(brcmu_pkt_buf_free_skb);
 
-
-/* copy a buffer into a pkt buffer chain */
-uint brcmu_pktfrombuf(struct sk_buff *p, uint offset, int len,
-                unsigned char *buf)
-{
-        uint n, ret = 0;
-
-        /* skip 'offset' bytes */
-        for (; p && offset; p = p->next) {
-                if (offset < (uint) (p->len))
-                        break;
-                offset -= p->len;
-        }
-
-        if (!p)
-                return 0;
-
-        /* copy the data */
-        for (; p && len; p = p->next) {
-                n = min((uint) (p->len) - offset, (uint) len);
-                memcpy(p->data + offset, buf, n);
-                buf += n;
-                len -= n;
-                ret += n;
-                offset = 0;
-        }
-
-        return ret;
-}
-EXPORT_SYMBOL(brcmu_pktfrombuf);
-
-/* return total length of buffer chain */
-uint brcmu_pkttotlen(struct sk_buff *p)
-{
-        uint total;
-
-        total = 0;
-        for (; p; p = p->next)
-                total += p->len;
-        return total;
-}
-EXPORT_SYMBOL(brcmu_pkttotlen);
-
 /*
  * osl multiple-precedence packet queue
  * hi_prec is always >= the number of the highest non-empty precedence
@@ -115,21 +62,13 @@ EXPORT_SYMBOL(brcmu_pkttotlen);
 struct sk_buff *brcmu_pktq_penq(struct pktq *pq, int prec,
                                       struct sk_buff *p)
 {
-        struct pktq_prec *q;
+        struct sk_buff_head *q;
 
         if (pktq_full(pq) || pktq_pfull(pq, prec))
                 return NULL;
 
-        q = &pq->q[prec];
-
-        if (q->head)
-                q->tail->prev = p;
-        else
-                q->head = p;
-
-        q->tail = p;
-        q->len++;
-
+        q = &pq->q[prec].skblist;
+        skb_queue_tail(q, p);
         pq->len++;
 
         if (pq->hi_prec < prec)
@@ -142,20 +81,13 @@ EXPORT_SYMBOL(brcmu_pktq_penq);
 struct sk_buff *brcmu_pktq_penq_head(struct pktq *pq, int prec,
                                            struct sk_buff *p)
 {
-        struct pktq_prec *q;
+        struct sk_buff_head *q;
 
         if (pktq_full(pq) || pktq_pfull(pq, prec))
                 return NULL;
 
-        q = &pq->q[prec];
-
-        if (q->head == NULL)
-                q->tail = p;
-
-        p->prev = q->head;
-        q->head = p;
-        q->len++;
-
+        q = &pq->q[prec].skblist;
+        skb_queue_head(q, p);
         pq->len++;
 
         if (pq->hi_prec < prec)
@@ -167,53 +99,30 @@ EXPORT_SYMBOL(brcmu_pktq_penq_head);
 
 struct sk_buff *brcmu_pktq_pdeq(struct pktq *pq, int prec)
 {
-        struct pktq_prec *q;
+        struct sk_buff_head *q;
         struct sk_buff *p;
 
-        q = &pq->q[prec];
-
-        p = q->head;
+        q = &pq->q[prec].skblist;
+        p = skb_dequeue(q);
         if (p == NULL)
                 return NULL;
 
-        q->head = p->prev;
-        if (q->head == NULL)
-                q->tail = NULL;
-
-        q->len--;
-
         pq->len--;
-
-        p->prev = NULL;
-
         return p;
 }
 EXPORT_SYMBOL(brcmu_pktq_pdeq);
 
 struct sk_buff *brcmu_pktq_pdeq_tail(struct pktq *pq, int prec)
 {
-        struct pktq_prec *q;
-        struct sk_buff *p, *prev;
-
-        q = &pq->q[prec];
+        struct sk_buff_head *q;
+        struct sk_buff *p;
 
-        p = q->head;
+        q = &pq->q[prec].skblist;
+        p = skb_dequeue_tail(q);
         if (p == NULL)
                 return NULL;
 
-        for (prev = NULL; p != q->tail; p = p->prev)
-                prev = p;
-
-        if (prev)
-                prev->prev = NULL;
-        else
-                q->head = NULL;
-
-        q->tail = prev;
-        q->len--;
-
         pq->len--;
-
         return p;
 }
 EXPORT_SYMBOL(brcmu_pktq_pdeq_tail);
@@ -222,31 +131,17 @@ void
 brcmu_pktq_pflush(struct pktq *pq, int prec, bool dir,
                   bool (*fn)(struct sk_buff *, void *), void *arg)
 {
-        struct pktq_prec *q;
-        struct sk_buff *p, *prev = NULL;
+        struct sk_buff_head *q;
+        struct sk_buff *p, *next;
 
-        q = &pq->q[prec];
-        p = q->head;
-        while (p) {
+        q = &pq->q[prec].skblist;
+        skb_queue_walk_safe(q, p, next) {
                 if (fn == NULL || (*fn) (p, arg)) {
-                        bool head = (p == q->head);
-                        if (head)
-                                q->head = p->prev;
-                        else
-                                prev->prev = p->prev;
-                        p->prev = NULL;
+                        skb_unlink(p, q);
                         brcmu_pkt_buf_free_skb(p);
-                        q->len--;
                         pq->len--;
-                        p = (head ? q->head : prev->prev);
-                } else {
-                        prev = p;
-                        p = p->prev;
                 }
         }
-
-        if (q->head == NULL)
-                q->tail = NULL;
 }
 EXPORT_SYMBOL(brcmu_pktq_pflush);
 
@@ -271,8 +166,10 @@ void brcmu_pktq_init(struct pktq *pq, int num_prec, int max_len)
 
         pq->max = (u16) max_len;
 
-        for (prec = 0; prec < num_prec; prec++)
+        for (prec = 0; prec < num_prec; prec++) {
                 pq->q[prec].max = pq->max;
+                skb_queue_head_init(&pq->q[prec].skblist);
+        }
 }
 EXPORT_SYMBOL(brcmu_pktq_init);
 
@@ -284,13 +181,13 @@ struct sk_buff *brcmu_pktq_peek_tail(struct pktq *pq, int *prec_out)
                 return NULL;
 
         for (prec = 0; prec < pq->hi_prec; prec++)
-                if (pq->q[prec].head)
+                if (!skb_queue_empty(&pq->q[prec].skblist))
                         break;
 
         if (prec_out)
                 *prec_out = prec;
 
-        return pq->q[prec].tail;
+        return skb_peek_tail(&pq->q[prec].skblist);
 }
 EXPORT_SYMBOL(brcmu_pktq_peek_tail);
 
@@ -303,7 +200,7 @@ int brcmu_pktq_mlen(struct pktq *pq, uint prec_bmp)
 
         for (prec = 0; prec <= pq->hi_prec; prec++)
                 if (prec_bmp & (1 << prec))
-                        len += pq->q[prec].len;
+                        len += pq->q[prec].skblist.qlen;
 
         return len;
 }
@@ -313,39 +210,32 @@ EXPORT_SYMBOL(brcmu_pktq_mlen);
 struct sk_buff *brcmu_pktq_mdeq(struct pktq *pq, uint prec_bmp,
                                       int *prec_out)
 {
-        struct pktq_prec *q;
+        struct sk_buff_head *q;
         struct sk_buff *p;
         int prec;
 
         if (pq->len == 0)
                 return NULL;
 
-        while ((prec = pq->hi_prec) > 0 && pq->q[prec].head == NULL)
+        while ((prec = pq->hi_prec) > 0 &&
+               skb_queue_empty(&pq->q[prec].skblist))
                 pq->hi_prec--;
 
-        while ((prec_bmp & (1 << prec)) == 0 || pq->q[prec].head == NULL)
+        while ((prec_bmp & (1 << prec)) == 0 ||
+               skb_queue_empty(&pq->q[prec].skblist))
                 if (prec-- == 0)
                         return NULL;
 
-        q = &pq->q[prec];
-
-        p = q->head;
+        q = &pq->q[prec].skblist;
+        p = skb_dequeue(q);
         if (p == NULL)
                 return NULL;
 
-        q->head = p->prev;
-        if (q->head == NULL)
-                q->tail = NULL;
-
-        q->len--;
+        pq->len--;
 
         if (prec_out)
                 *prec_out = prec;
 
-        pq->len--;
-
-        p->prev = NULL;
-
         return p;
 }
 EXPORT_SYMBOL(brcmu_pktq_mdeq);
@@ -364,23 +254,3 @@ void brcmu_prpkt(const char *msg, struct sk_buff *p0)
 }
 EXPORT_SYMBOL(brcmu_prpkt);
 #endif                          /* defined(BCMDBG) */
-
-#if defined(BCMDBG)
-/*
- * print bytes formatted as hex to a string. return the resulting
- * string length
- */
-int brcmu_format_hex(char *str, const void *bytes, int len)
-{
-        int i;
-        char *p = str;
-        const u8 *src = (const u8 *)bytes;
-
-        for (i = 0; i < len; i++) {
-                p += snprintf(p, 3, "%02X", *src);
-                src++;
-        }
-        return (int)(p - str);
-}
-EXPORT_SYMBOL(brcmu_format_hex);
-#endif                          /* defined(BCMDBG) */
diff --git a/drivers/net/wireless/brcm80211/include/brcmu_utils.h b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
index 7d0f46e0eb95..ad249a0b4730 100644
--- a/drivers/net/wireless/brcm80211/include/brcmu_utils.h
+++ b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
@@ -65,9 +65,7 @@
 #define ETHER_ADDR_STR_LEN      18
 
 struct pktq_prec {
-        struct sk_buff *head;   /* first packet to dequeue */
-        struct sk_buff *tail;   /* last packet to dequeue */
-        u16 len;                /* number of queued packets */
+        struct sk_buff_head skblist;
         u16 max;                /* maximum number of queued packets */
 };
 
@@ -88,32 +86,32 @@ struct pktq {
 
 static inline int pktq_plen(struct pktq *pq, int prec)
 {
-        return pq->q[prec].len;
+        return pq->q[prec].skblist.qlen;
 }
 
 static inline int pktq_pavail(struct pktq *pq, int prec)
 {
-        return pq->q[prec].max - pq->q[prec].len;
+        return pq->q[prec].max - pq->q[prec].skblist.qlen;
 }
 
 static inline bool pktq_pfull(struct pktq *pq, int prec)
 {
-        return pq->q[prec].len >= pq->q[prec].max;
+        return pq->q[prec].skblist.qlen >= pq->q[prec].max;
 }
 
 static inline bool pktq_pempty(struct pktq *pq, int prec)
 {
-        return pq->q[prec].len == 0;
+        return skb_queue_empty(&pq->q[prec].skblist);
 }
 
 static inline struct sk_buff *pktq_ppeek(struct pktq *pq, int prec)
 {
-        return pq->q[prec].head;
+        return skb_peek(&pq->q[prec].skblist);
 }
 
 static inline struct sk_buff *pktq_ppeek_tail(struct pktq *pq, int prec)
 {
-        return pq->q[prec].tail;
+        return skb_peek_tail(&pq->q[prec].skblist);
 }
 
 extern struct sk_buff *brcmu_pktq_penq(struct pktq *pq, int prec,
@@ -172,24 +170,16 @@ extern void brcmu_pktq_flush(struct pktq *pq, bool dir,
                 bool (*fn)(struct sk_buff *, void *), void *arg);
 
 /* externs */
-/* packet */
-extern uint brcmu_pktfrombuf(struct sk_buff *p,
-        uint offset, int len, unsigned char *buf);
-extern uint brcmu_pkttotlen(struct sk_buff *p);
-
 /* ip address */
 struct ipv4_addr;
 
+
+/* externs */
+/* format/print */
 #ifdef BCMDBG
 extern void brcmu_prpkt(const char *msg, struct sk_buff *p0);
 #else
 #define brcmu_prpkt(a, b)
 #endif                          /* BCMDBG */
 
-/* externs */
-/* format/print */
-#if defined(BCMDBG)
-extern int brcmu_format_hex(char *str, const void *bytes, int len);
-#endif
-
 #endif                          /* _BRCMU_UTILS_H_ */
diff --git a/drivers/net/wireless/brcm80211/include/defs.h b/drivers/net/wireless/brcm80211/include/defs.h
index 1e5f310af1e7..f0d8c04a9c8c 100644
--- a/drivers/net/wireless/brcm80211/include/defs.h
+++ b/drivers/net/wireless/brcm80211/include/defs.h
@@ -62,7 +62,6 @@
 
 #define WL_RADIO_SW_DISABLE             (1<<0)
 #define WL_RADIO_HW_DISABLE             (1<<1)
-#define WL_RADIO_MPC_DISABLE            (1<<2)
 /* some countries don't support any channel */
 #define WL_RADIO_COUNTRY_DISABLE        (1<<3)
 
diff --git a/drivers/net/wireless/brcm80211/include/soc.h b/drivers/net/wireless/brcm80211/include/soc.h
index 4fcb956ad9e0..4e9b7e4827ea 100644
--- a/drivers/net/wireless/brcm80211/include/soc.h
+++ b/drivers/net/wireless/brcm80211/include/soc.h
@@ -77,8 +77,9 @@
 #define DMEMS_CORE_ID           0x835   /* SDR/DDR1 memory controller core */
 #define DEF_SHIM_COMP           0x837   /* SHIM component in ubus/6362 */
 #define OOB_ROUTER_CORE_ID      0x367   /* OOB router core ID */
-/* Default component, in ai chips it maps all unused address ranges */
-#define DEF_AI_COMP             0xfff
+#define DEF_AI_COMP             0xfff   /* Default component, in ai chips it
+                                         * maps all unused address ranges
+                                         */
 
 /* Common core control flags */
 #define SICF_BIST_EN            0x8000
@@ -87,4 +88,11 @@
 #define SICF_FGC                0x0002
 #define SICF_CLOCK_EN           0x0001
 
+/* Common core status flags */
+#define SISF_BIST_DONE          0x8000
+#define SISF_BIST_ERROR         0x4000
+#define SISF_GATED_CLK          0x2000
+#define SISF_DMA64              0x1000
+#define SISF_CORE_BITS          0x0fff
+
 #endif                          /* _BRCM_SOC_H */
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 99a710dfe771..99575884ff52 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -131,6 +131,14 @@ static struct ieee80211_rate ipw2200_rates[] = {
 #define ipw2200_bg_rates        (ipw2200_rates + 0)
 #define ipw2200_num_bg_rates    12
 
+/* Ugly macro to convert literal channel numbers into their mhz equivalents
+ * There are certianly some conditions that will break this (like feeding it '30')
+ * but they shouldn't arise since nothing talks on channel 30. */
+#define ieee80211chan2mhz(x) \
+        (((x) <= 14) ? \
+        (((x) == 14) ? 2484 : ((x) * 5) + 2407) : \
+        ((x) + 1000) * 5)
+
 #ifdef CONFIG_IPW2200_QOS
 static int qos_enable = 0;
 static int qos_burst_enable = 0;
diff --git a/drivers/net/wireless/ipw2x00/libipw.h b/drivers/net/wireless/ipw2x00/libipw.h
index 70f5586d96bd..3d5821eeb054 100644
--- a/drivers/net/wireless/ipw2x00/libipw.h
+++ b/drivers/net/wireless/ipw2x00/libipw.h
@@ -66,16 +66,8 @@ extern u32 libipw_debug_level;
 do { if (libipw_debug_level & (level)) \
   printk(KERN_DEBUG "libipw: %c %s " fmt, \
          in_interrupt() ? 'I' : 'U', __func__ , ## args); } while (0)
-static inline bool libipw_ratelimit_debug(u32 level)
-{
-        return (libipw_debug_level & level) && net_ratelimit();
-}
 #else
 #define LIBIPW_DEBUG(level, fmt, args...) do {} while (0)
-static inline bool libipw_ratelimit_debug(u32 level)
-{
-        return false;
-}
 #endif                          /* CONFIG_LIBIPW_DEBUG */
 
 /*
diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
index c73e5ed8db5e..a7ab280994c8 100644
--- a/drivers/net/wireless/iwlwifi/Makefile
+++ b/drivers/net/wireless/iwlwifi/Makefile
@@ -1,6 +1,6 @@
 # WIFI
 obj-$(CONFIG_IWLWIFI)   += iwlwifi.o
-iwlwifi-objs            := iwl-agn.o iwl-agn-rs.o
+iwlwifi-objs            := iwl-agn.o iwl-agn-rs.o iwl-mac80211.o
 iwlwifi-objs            += iwl-agn-ucode.o iwl-agn-tx.o
 iwlwifi-objs            += iwl-agn-lib.o iwl-agn-calib.o iwl-io.o
 iwlwifi-objs            += iwl-agn-tt.o iwl-agn-sta.o iwl-agn-rx.o
diff --git a/drivers/net/wireless/iwlwifi/iwl-2000.c b/drivers/net/wireless/iwlwifi/iwl-2000.c
index 79431977a968..b3193571ed07 100644
--- a/drivers/net/wireless/iwlwifi/iwl-2000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-2000.c
@@ -270,11 +270,6 @@ struct iwl_cfg iwl2000_2bgn_cfg = {
         .ht_params = &iwl2000_ht_params,
 };
 
-struct iwl_cfg iwl2000_2bg_cfg = {
-        .name = "2000 Series 2x2 BG",
-        IWL_DEVICE_2000,
-};
-
 struct iwl_cfg iwl2000_2bgn_d_cfg = {
         .name = "2000D Series 2x2 BGN",
         IWL_DEVICE_2000,
@@ -304,11 +299,6 @@ struct iwl_cfg iwl2030_2bgn_cfg = {
         .ht_params = &iwl2000_ht_params,
 };
 
-struct iwl_cfg iwl2030_2bg_cfg = {
-        .name = "2000 Series 2x2 BG/BT",
-        IWL_DEVICE_2030,
-};
-
 #define IWL_DEVICE_105                                          \
         .fw_name_pre = IWL105_FW_PRE,                           \
         .ucode_api_max = IWL105_UCODE_API_MAX,                  \
@@ -326,11 +316,6 @@ struct iwl_cfg iwl2030_2bg_cfg = {
         .rx_with_siso_diversity = true,                         \
         .iq_invert = true                                       \
 
-struct iwl_cfg iwl105_bg_cfg = {
-        .name = "105 Series 1x1 BG",
-        IWL_DEVICE_105,
-};
-
 struct iwl_cfg iwl105_bgn_cfg = {
         .name = "105 Series 1x1 BGN",
         IWL_DEVICE_105,
@@ -361,11 +346,6 @@ struct iwl_cfg iwl105_bgn_d_cfg = {
         .rx_with_siso_diversity = true,                         \
         .iq_invert = true                                       \
 
-struct iwl_cfg iwl135_bg_cfg = {
-        .name = "135 Series 1x1 BG/BT",
-        IWL_DEVICE_135,
-};
-
 struct iwl_cfg iwl135_bgn_cfg = {
         .name = "135 Series 1x1 BGN/BT",
         IWL_DEVICE_135,
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c
index c840c78278db..ee3363fdf309 100644
--- a/drivers/net/wireless/iwlwifi/iwl-6000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-6000.c
@@ -439,16 +439,6 @@ struct iwl_cfg iwl6035_2agn_cfg = {
         .ht_params = &iwl6000_ht_params,
 };
 
-struct iwl_cfg iwl6035_2abg_cfg = {
-        .name = "6035 Series 2x2 ABG/BT",
-        IWL_DEVICE_6030,
-};
-
-struct iwl_cfg iwl6035_2bg_cfg = {
-        .name = "6035 Series 2x2 BG/BT",
-        IWL_DEVICE_6030,
-};
-
 struct iwl_cfg iwl1030_bgn_cfg = {
         .name = "Intel(R) Centrino(R) Wireless-N 1030 BGN",
         IWL_DEVICE_6030,
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
index 1a52ed29f2d6..0bc962217351 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
@@ -827,6 +827,7 @@ static int iwl_get_idle_rx_chain_count(struct iwl_priv *priv, int active_cnt)
         case IEEE80211_SMPS_STATIC:
         case IEEE80211_SMPS_DYNAMIC:
                 return IWL_NUM_IDLE_CHAINS_SINGLE;
+        case IEEE80211_SMPS_AUTOMATIC:
         case IEEE80211_SMPS_OFF:
                 return active_cnt;
         default:
@@ -983,3 +984,360 @@ void iwlagn_remove_notification(struct iwl_priv *priv,
         list_del(&wait_entry->list);
         spin_unlock_bh(&priv->notif_wait_lock);
 }
+
+#ifdef CONFIG_PM_SLEEP
+static void iwlagn_convert_p1k(u16 *p1k, __le16 *out)
+{
+        int i;
+
+        for (i = 0; i < IWLAGN_P1K_SIZE; i++)
+                out[i] = cpu_to_le16(p1k[i]);
+}
+
+struct wowlan_key_data {
+        struct iwl_rxon_context *ctx;
+        struct iwlagn_wowlan_rsc_tsc_params_cmd *rsc_tsc;
+        struct iwlagn_wowlan_tkip_params_cmd *tkip;
+        const u8 *bssid;
+        bool error, use_rsc_tsc, use_tkip;
+};
+
+
+static void iwlagn_wowlan_program_keys(struct ieee80211_hw *hw,
+                               struct ieee80211_vif *vif,
+                               struct ieee80211_sta *sta,
+                               struct ieee80211_key_conf *key,
+                               void *_data)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct wowlan_key_data *data = _data;
+        struct iwl_rxon_context *ctx = data->ctx;
+        struct aes_sc *aes_sc, *aes_tx_sc = NULL;
+        struct tkip_sc *tkip_sc, *tkip_tx_sc = NULL;
+        struct iwlagn_p1k_cache *rx_p1ks;
+        u8 *rx_mic_key;
+        struct ieee80211_key_seq seq;
+        u32 cur_rx_iv32 = 0;
+        u16 p1k[IWLAGN_P1K_SIZE];
+        int ret, i;
+
+        mutex_lock(&priv->shrd->mutex);
+
+        if ((key->cipher == WLAN_CIPHER_SUITE_WEP40 ||
+             key->cipher == WLAN_CIPHER_SUITE_WEP104) &&
+             !sta && !ctx->key_mapping_keys)
+                ret = iwl_set_default_wep_key(priv, ctx, key);
+        else
+                ret = iwl_set_dynamic_key(priv, ctx, key, sta);
+
+        if (ret) {
+                IWL_ERR(priv, "Error setting key during suspend!\n");
+                data->error = true;
+        }
+
+        switch (key->cipher) {
+        case WLAN_CIPHER_SUITE_TKIP:
+                if (sta) {
+                        tkip_sc = data->rsc_tsc->all_tsc_rsc.tkip.unicast_rsc;
+                        tkip_tx_sc = &data->rsc_tsc->all_tsc_rsc.tkip.tsc;
+
+                        rx_p1ks = data->tkip->rx_uni;
+
+                        ieee80211_get_key_tx_seq(key, &seq);
+                        tkip_tx_sc->iv16 = cpu_to_le16(seq.tkip.iv16);
+                        tkip_tx_sc->iv32 = cpu_to_le32(seq.tkip.iv32);
+
+                        ieee80211_get_tkip_p1k_iv(key, seq.tkip.iv32, p1k);
+                        iwlagn_convert_p1k(p1k, data->tkip->tx.p1k);
+
+                        memcpy(data->tkip->mic_keys.tx,
+                               &key->key[NL80211_TKIP_DATA_OFFSET_TX_MIC_KEY],
+                               IWLAGN_MIC_KEY_SIZE);
+
+                        rx_mic_key = data->tkip->mic_keys.rx_unicast;
+                } else {
+                        tkip_sc =
+                                data->rsc_tsc->all_tsc_rsc.tkip.multicast_rsc;
+                        rx_p1ks = data->tkip->rx_multi;
+                        rx_mic_key = data->tkip->mic_keys.rx_mcast;
+                }
+
+                /*
+                 * For non-QoS this relies on the fact that both the uCode and
+                 * mac80211 use TID 0 (as they need to to avoid replay attacks)
+                 * for checking the IV in the frames.
+                 */
+                for (i = 0; i < IWLAGN_NUM_RSC; i++) {
+                        ieee80211_get_key_rx_seq(key, i, &seq);
+                        tkip_sc[i].iv16 = cpu_to_le16(seq.tkip.iv16);
+                        tkip_sc[i].iv32 = cpu_to_le32(seq.tkip.iv32);
+                        /* wrapping isn't allowed, AP must rekey */
+                        if (seq.tkip.iv32 > cur_rx_iv32)
+                                cur_rx_iv32 = seq.tkip.iv32;
+                }
+
+                ieee80211_get_tkip_rx_p1k(key, data->bssid, cur_rx_iv32, p1k);
+                iwlagn_convert_p1k(p1k, rx_p1ks[0].p1k);
+                ieee80211_get_tkip_rx_p1k(key, data->bssid,
+                                          cur_rx_iv32 + 1, p1k);
+                iwlagn_convert_p1k(p1k, rx_p1ks[1].p1k);
+
+                memcpy(rx_mic_key,
+                       &key->key[NL80211_TKIP_DATA_OFFSET_RX_MIC_KEY],
+                       IWLAGN_MIC_KEY_SIZE);
+
+                data->use_tkip = true;
+                data->use_rsc_tsc = true;
+                break;
+        case WLAN_CIPHER_SUITE_CCMP:
+                if (sta) {
+                        u8 *pn = seq.ccmp.pn;
+
+                        aes_sc = data->rsc_tsc->all_tsc_rsc.aes.unicast_rsc;
+                        aes_tx_sc = &data->rsc_tsc->all_tsc_rsc.aes.tsc;
+
+                        ieee80211_get_key_tx_seq(key, &seq);
+                        aes_tx_sc->pn = cpu_to_le64(
+                                        (u64)pn[5] |
+                                        ((u64)pn[4] << 8) |
+                                        ((u64)pn[3] << 16) |
+                                        ((u64)pn[2] << 24) |
+                                        ((u64)pn[1] << 32) |
+                                        ((u64)pn[0] << 40));
+                } else
+                        aes_sc = data->rsc_tsc->all_tsc_rsc.aes.multicast_rsc;
+
+                /*
+                 * For non-QoS this relies on the fact that both the uCode and
+                 * mac80211 use TID 0 for checking the IV in the frames.
+                 */
+                for (i = 0; i < IWLAGN_NUM_RSC; i++) {
+                        u8 *pn = seq.ccmp.pn;
+
+                        ieee80211_get_key_rx_seq(key, i, &seq);
+                        aes_sc->pn = cpu_to_le64(
+                                        (u64)pn[5] |
+                                        ((u64)pn[4] << 8) |
+                                        ((u64)pn[3] << 16) |
+                                        ((u64)pn[2] << 24) |
+                                        ((u64)pn[1] << 32) |
+                                        ((u64)pn[0] << 40));
+                }
+                data->use_rsc_tsc = true;
+                break;
+        }
+
+        mutex_unlock(&priv->shrd->mutex);
+}
+
+int iwlagn_send_patterns(struct iwl_priv *priv,
+                        struct cfg80211_wowlan *wowlan)
+{
+        struct iwlagn_wowlan_patterns_cmd *pattern_cmd;
+        struct iwl_host_cmd cmd = {
+                .id = REPLY_WOWLAN_PATTERNS,
+                .dataflags[0] = IWL_HCMD_DFL_NOCOPY,
+                .flags = CMD_SYNC,
+        };
+        int i, err;
+
+        if (!wowlan->n_patterns)
+                return 0;
+
+        cmd.len[0] = sizeof(*pattern_cmd) +
+                wowlan->n_patterns * sizeof(struct iwlagn_wowlan_pattern);
+
+        pattern_cmd = kmalloc(cmd.len[0], GFP_KERNEL);
+        if (!pattern_cmd)
+                return -ENOMEM;
+
+        pattern_cmd->n_patterns = cpu_to_le32(wowlan->n_patterns);
+
+        for (i = 0; i < wowlan->n_patterns; i++) {
+                int mask_len = DIV_ROUND_UP(wowlan->patterns[i].pattern_len, 8);
+
+                memcpy(&pattern_cmd->patterns[i].mask,
+                        wowlan->patterns[i].mask, mask_len);
+                memcpy(&pattern_cmd->patterns[i].pattern,
+                        wowlan->patterns[i].pattern,
+                        wowlan->patterns[i].pattern_len);
+                pattern_cmd->patterns[i].mask_size = mask_len;
+                pattern_cmd->patterns[i].pattern_size =
+                        wowlan->patterns[i].pattern_len;
+        }
+
+        cmd.data[0] = pattern_cmd;
+        err = iwl_trans_send_cmd(trans(priv), &cmd);
+        kfree(pattern_cmd);
+        return err;
+}
+
+int iwlagn_suspend(struct iwl_priv *priv,
+                struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
+{
+        struct iwlagn_wowlan_wakeup_filter_cmd wakeup_filter_cmd;
+        struct iwl_rxon_cmd rxon;
+        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
+        struct iwlagn_wowlan_kek_kck_material_cmd kek_kck_cmd;
+        struct iwlagn_wowlan_tkip_params_cmd tkip_cmd = {};
+        struct iwlagn_d3_config_cmd d3_cfg_cmd = {};
+        struct wowlan_key_data key_data = {
+                .ctx = ctx,
+                .bssid = ctx->active.bssid_addr,
+                .use_rsc_tsc = false,
+                .tkip = &tkip_cmd,
+                .use_tkip = false,
+        };
+        int ret, i;
+        u16 seq;
+
+        key_data.rsc_tsc = kzalloc(sizeof(*key_data.rsc_tsc), GFP_KERNEL);
+        if (!key_data.rsc_tsc)
+                return -ENOMEM;
+
+        memset(&wakeup_filter_cmd, 0, sizeof(wakeup_filter_cmd));
+
+        /*
+         * We know the last used seqno, and the uCode expects to know that
+         * one, it will increment before TX.
+         */
+        seq = le16_to_cpu(priv->last_seq_ctl) & IEEE80211_SCTL_SEQ;
+        wakeup_filter_cmd.non_qos_seq = cpu_to_le16(seq);
+
+        /*
+         * For QoS counters, we store the one to use next, so subtract 0x10
+         * since the uCode will add 0x10 before using the value.
+         */
+        for (i = 0; i < 8; i++) {
+                seq = priv->shrd->tid_data[IWL_AP_ID][i].seq_number;
+                seq -= 0x10;
+                wakeup_filter_cmd.qos_seq[i] = cpu_to_le16(seq);
+        }
+
+        if (wowlan->disconnect)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_BEACON_MISS |
+                                    IWLAGN_WOWLAN_WAKEUP_LINK_CHANGE);
+        if (wowlan->magic_pkt)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_MAGIC_PACKET);
+        if (wowlan->gtk_rekey_failure)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_GTK_REKEY_FAIL);
+        if (wowlan->eap_identity_req)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_EAP_IDENT_REQ);
+        if (wowlan->four_way_handshake)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_4WAY_HANDSHAKE);
+        if (wowlan->n_patterns)
+                wakeup_filter_cmd.enabled |=
+                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_PATTERN_MATCH);
+
+        if (wowlan->rfkill_release)
+                d3_cfg_cmd.wakeup_flags |=
+                        cpu_to_le32(IWLAGN_D3_WAKEUP_RFKILL);
+
+        iwl_scan_cancel_timeout(priv, 200);
+
+        memcpy(&rxon, &ctx->active, sizeof(rxon));
+
+        iwl_trans_stop_device(trans(priv));
+
+        priv->shrd->wowlan = true;
+
+        ret = iwlagn_load_ucode_wait_alive(priv, IWL_UCODE_WOWLAN);
+        if (ret)
+                goto out;
+
+        /* now configure WoWLAN ucode */
+        ret = iwl_alive_start(priv);
+        if (ret)
+                goto out;
+
+        memcpy(&ctx->staging, &rxon, sizeof(rxon));
+        ret = iwlagn_commit_rxon(priv, ctx);
+        if (ret)
+                goto out;
+
+        ret = iwl_power_update_mode(priv, true);
+        if (ret)
+                goto out;
+
+        if (!iwlagn_mod_params.sw_crypto) {
+                /* mark all keys clear */
+                priv->ucode_key_table = 0;
+                ctx->key_mapping_keys = 0;
+
+                /*
+                 * This needs to be unlocked due to lock ordering
+                 * constraints. Since we're in the suspend path
+                 * that isn't really a problem though.
+                 */
+                mutex_unlock(&priv->shrd->mutex);
+                ieee80211_iter_keys(priv->hw, ctx->vif,
+                                    iwlagn_wowlan_program_keys,
+                                    &key_data);
+                mutex_lock(&priv->shrd->mutex);
+                if (key_data.error) {
+                        ret = -EIO;
+                        goto out;
+                }
+
+                if (key_data.use_rsc_tsc) {
+                        struct iwl_host_cmd rsc_tsc_cmd = {
+                                .id = REPLY_WOWLAN_TSC_RSC_PARAMS,
+                                .flags = CMD_SYNC,
+                                .data[0] = key_data.rsc_tsc,
+                                .dataflags[0] = IWL_HCMD_DFL_NOCOPY,
+                                .len[0] = sizeof(key_data.rsc_tsc),
+                        };
+
+                        ret = iwl_trans_send_cmd(trans(priv), &rsc_tsc_cmd);
+                        if (ret)
+                                goto out;
+                }
+
+                if (key_data.use_tkip) {
+                        ret = iwl_trans_send_cmd_pdu(trans(priv),
+                                                 REPLY_WOWLAN_TKIP_PARAMS,
+                                                 CMD_SYNC, sizeof(tkip_cmd),
+                                                 &tkip_cmd);
+                        if (ret)
+                                goto out;
+                }
+
+                if (priv->have_rekey_data) {
+                        memset(&kek_kck_cmd, 0, sizeof(kek_kck_cmd));
+                        memcpy(kek_kck_cmd.kck, priv->kck, NL80211_KCK_LEN);
+                        kek_kck_cmd.kck_len = cpu_to_le16(NL80211_KCK_LEN);
+                        memcpy(kek_kck_cmd.kek, priv->kek, NL80211_KEK_LEN);
+                        kek_kck_cmd.kek_len = cpu_to_le16(NL80211_KEK_LEN);
+                        kek_kck_cmd.replay_ctr = priv->replay_ctr;
+
+                        ret = iwl_trans_send_cmd_pdu(trans(priv),
+                                                 REPLY_WOWLAN_KEK_KCK_MATERIAL,
+                                                 CMD_SYNC, sizeof(kek_kck_cmd),
+                                                 &kek_kck_cmd);
+                        if (ret)
+                                goto out;
+                }
+        }
+
+        ret = iwl_trans_send_cmd_pdu(trans(priv), REPLY_D3_CONFIG, CMD_SYNC,
+                                     sizeof(d3_cfg_cmd), &d3_cfg_cmd);
+        if (ret)
+                goto out;
+
+        ret = iwl_trans_send_cmd_pdu(trans(priv), REPLY_WOWLAN_WAKEUP_FILTER,
+                                 CMD_SYNC, sizeof(wakeup_filter_cmd),
+                                 &wakeup_filter_cmd);
+        if (ret)
+                goto out;
+
+        ret = iwlagn_send_patterns(priv, wowlan);
+ out:
+        kfree(key_data.rsc_tsc);
+        return ret;
+}
+#endif
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index 66118cea2af3..359c47a4fcea 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -1458,10 +1458,8 @@ static int rs_move_legacy_other(struct iwl_priv *priv,
                 break;
         case IWL_BT_COEX_TRAFFIC_LOAD_LOW:
                 /* avoid antenna B unless MIMO */
-                valid_tx_ant =
-                        first_antenna(hw_params(priv).valid_tx_ant);
                 if (tbl->action == IWL_LEGACY_SWITCH_ANTENNA2)
-                        tbl->action = IWL_LEGACY_SWITCH_ANTENNA1;
+                        tbl->action = IWL_LEGACY_SWITCH_SISO;
                 break;
         case IWL_BT_COEX_TRAFFIC_LOAD_HIGH:
         case IWL_BT_COEX_TRAFFIC_LOAD_CONTINUOUS:
@@ -1636,10 +1634,8 @@ static int rs_move_siso_to_other(struct iwl_priv *priv,
                 break;
         case IWL_BT_COEX_TRAFFIC_LOAD_LOW:
                 /* avoid antenna B unless MIMO */
-                valid_tx_ant =
-                        first_antenna(hw_params(priv).valid_tx_ant);
                 if (tbl->action == IWL_SISO_SWITCH_ANTENNA2)
-                        tbl->action = IWL_SISO_SWITCH_ANTENNA1;
+                        tbl->action = IWL_SISO_SWITCH_MIMO2_AB;
                 break;
         case IWL_BT_COEX_TRAFFIC_LOAD_HIGH:
         case IWL_BT_COEX_TRAFFIC_LOAD_CONTINUOUS:
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rx.c b/drivers/net/wireless/iwlwifi/iwl-agn-rx.c
index 5af9e6258a16..fdb4c3786114 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rx.c
@@ -800,7 +800,8 @@ static void iwlagn_pass_packet_to_mac80211(struct iwl_priv *priv,
                                                ctx->active.bssid_addr))
                                 continue;
                         ctx->last_tx_rejected = false;
-                        iwl_trans_wake_any_queue(trans(priv), ctx->ctxid);
+                        iwl_trans_wake_any_queue(trans(priv), ctx->ctxid,
+                                "channel got active");
                 }
         }
 
@@ -1032,6 +1033,50 @@ static int iwlagn_rx_reply_rx(struct iwl_priv *priv,
         return 0;
 }
 
+static int iwlagn_rx_noa_notification(struct iwl_priv *priv,
+                                      struct iwl_rx_mem_buffer *rxb,
+                                      struct iwl_device_cmd *cmd)
+{
+        struct iwl_wipan_noa_data *new_data, *old_data;
+        struct iwl_rx_packet *pkt = rxb_addr(rxb);
+        struct iwl_wipan_noa_notification *noa_notif = (void *)pkt->u.raw;
+
+        /* no condition -- we're in softirq */
+        old_data = rcu_dereference_protected(priv->noa_data, true);
+
+        if (noa_notif->noa_active) {
+                u32 len = le16_to_cpu(noa_notif->noa_attribute.length);
+                u32 copylen = len;
+
+                /* EID, len, OUI, subtype */
+                len += 1 + 1 + 3 + 1;
+                /* P2P id, P2P length */
+                len += 1 + 2;
+                copylen += 1 + 2;
+
+                new_data = kmalloc(sizeof(*new_data) + len, GFP_ATOMIC);
+                if (new_data) {
+                        new_data->length = len;
+                        new_data->data[0] = WLAN_EID_VENDOR_SPECIFIC;
+                        new_data->data[1] = len - 2; /* not counting EID, len */
+                        new_data->data[2] = (WLAN_OUI_WFA >> 16) & 0xff;
+                        new_data->data[3] = (WLAN_OUI_WFA >> 8) & 0xff;
+                        new_data->data[4] = (WLAN_OUI_WFA >> 0) & 0xff;
+                        new_data->data[5] = WLAN_OUI_TYPE_WFA_P2P;
+                        memcpy(&new_data->data[6], &noa_notif->noa_attribute,
+                               copylen);
+                }
+        } else
+                new_data = NULL;
+
+        rcu_assign_pointer(priv->noa_data, new_data);
+
+        if (old_data)
+                kfree_rcu(old_data, rcu_head);
+
+        return 0;
+}
+
 /**
  * iwl_setup_rx_handlers - Initialize Rx handler callbacks
  *
@@ -1055,6 +1100,8 @@ void iwl_setup_rx_handlers(struct iwl_priv *priv)
         handlers[BEACON_NOTIFICATION]           = iwlagn_rx_beacon_notif;
         handlers[REPLY_ADD_STA]                 = iwl_add_sta_callback;
 
+        handlers[REPLY_WIPAN_NOA_NOTIFICATION]  = iwlagn_rx_noa_notification;
+
         /*
          * The same handler is used for both the REPLY to a discrete
          * statistics request from the host as well as for the periodic
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
index 58a381c01c89..8de97f5a1825 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
@@ -45,7 +45,8 @@ static int iwlagn_disable_bss(struct iwl_priv *priv,
         send->filter_flags = old_filter;
 
         if (ret)
-                IWL_ERR(priv, "Error clearing ASSOC_MSK on BSS (%d)\n", ret);
+                IWL_DEBUG_QUIET_RFKILL(priv,
+                        "Error clearing ASSOC_MSK on BSS (%d)\n", ret);
 
         return ret;
 }
@@ -116,7 +117,7 @@ static void iwlagn_update_qos(struct iwl_priv *priv,
         if (ctx->ht.enabled)
                 ctx->qos_data.def_qos_parm.qos_flags |= QOS_PARAM_FLG_TGN_MSK;
 
-        IWL_DEBUG_QOS(priv, "send QoS cmd with Qos active=%d FLAGS=0x%X\n",
+        IWL_DEBUG_INFO(priv, "send QoS cmd with Qos active=%d FLAGS=0x%X\n",
                       ctx->qos_data.qos_active,
                       ctx->qos_data.def_qos_parm.qos_flags);
 
@@ -124,7 +125,7 @@ static void iwlagn_update_qos(struct iwl_priv *priv,
                                sizeof(struct iwl_qosparam_cmd),
                                &ctx->qos_data.def_qos_parm);
         if (ret)
-                IWL_ERR(priv, "Failed to update QoS\n");
+                IWL_DEBUG_QUIET_RFKILL(priv, "Failed to update QoS\n");
 }
 
 static int iwlagn_update_beacon(struct iwl_priv *priv,
@@ -541,6 +542,9 @@ int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed)
 
         mutex_lock(&priv->shrd->mutex);
 
+        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status))
+                goto out;
+
         if (unlikely(test_bit(STATUS_SCANNING, &priv->shrd->status))) {
                 IWL_DEBUG_MAC80211(priv, "leave - scanning\n");
                 goto out;
@@ -840,7 +844,8 @@ void iwlagn_bss_info_changed(struct ieee80211_hw *hw,
                         if (ctx->last_tx_rejected) {
                                 ctx->last_tx_rejected = false;
                                 iwl_trans_wake_any_queue(trans(priv),
-                                                         ctx->ctxid);
+                                                         ctx->ctxid,
+                                                         "Disassoc: flush queue");
                         }
                         ctx->staging.filter_flags &= ~RXON_FILTER_ASSOC_MSK;
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
index ed6283623932..901fd9485d75 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
@@ -647,7 +647,7 @@ void iwl_reprogram_ap_sta(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
         int ret;
         struct iwl_addsta_cmd sta_cmd;
         struct iwl_link_quality_cmd lq;
-        bool active;
+        bool active, have_lq = false;
 
         spin_lock_irqsave(&priv->shrd->sta_lock, flags);
         if (!(priv->stations[sta_id].used & IWL_STA_DRIVER_ACTIVE)) {
@@ -657,7 +657,10 @@ void iwl_reprogram_ap_sta(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
 
         memcpy(&sta_cmd, &priv->stations[sta_id].sta, sizeof(sta_cmd));
         sta_cmd.mode = 0;
-        memcpy(&lq, priv->stations[sta_id].lq, sizeof(lq));
+        if (priv->stations[sta_id].lq) {
+                memcpy(&lq, priv->stations[sta_id].lq, sizeof(lq));
+                have_lq = true;
+        }
 
         active = priv->stations[sta_id].used & IWL_STA_UCODE_ACTIVE;
         priv->stations[sta_id].used &= ~IWL_STA_DRIVER_ACTIVE;
@@ -679,7 +682,8 @@ void iwl_reprogram_ap_sta(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
         if (ret)
                 IWL_ERR(priv, "failed to re-add STA %pM (%d)\n",
                         priv->stations[sta_id].sta.sta.addr, ret);
-        iwl_send_lq_cmd(priv, ctx, &lq, CMD_SYNC, true);
+        if (have_lq)
+                iwl_send_lq_cmd(priv, ctx, &lq, CMD_SYNC, true);
 }
 
 int iwl_get_free_ucode_key_offset(struct iwl_priv *priv)
@@ -825,28 +829,6 @@ int iwl_send_lq_cmd(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
         return ret;
 }
 
-int iwlagn_mac_sta_remove(struct ieee80211_hw *hw,
-                       struct ieee80211_vif *vif,
-                       struct ieee80211_sta *sta)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
-        int ret;
-
-        IWL_DEBUG_MAC80211(priv, "enter: received request to remove "
-                           "station %pM\n", sta->addr);
-        mutex_lock(&priv->shrd->mutex);
-        IWL_DEBUG_INFO(priv, "proceeding to remove station %pM\n",
-                        sta->addr);
-        ret = iwl_remove_station(priv, sta_priv->sta_id, sta->addr);
-        if (ret)
-                IWL_ERR(priv, "Error removing station %pM\n",
-                        sta->addr);
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return ret;
-}
 
 void iwl_sta_fill_lq(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
                      u8 sta_id, struct iwl_link_quality_cmd *link_cmd)
@@ -1464,20 +1446,7 @@ int iwl_sta_rx_agg_stop(struct iwl_priv *priv, struct ieee80211_sta *sta,
         return iwl_send_add_sta(priv, &sta_cmd, CMD_SYNC);
 }
 
-static void iwl_sta_modify_ps_wake(struct iwl_priv *priv, int sta_id)
-{
-        unsigned long flags;
 
-        spin_lock_irqsave(&priv->shrd->sta_lock, flags);
-        priv->stations[sta_id].sta.station_flags &= ~STA_FLG_PWR_SAVE_MSK;
-        priv->stations[sta_id].sta.station_flags_msk = STA_FLG_PWR_SAVE_MSK;
-        priv->stations[sta_id].sta.sta.modify_mask = 0;
-        priv->stations[sta_id].sta.sleep_tx_count = 0;
-        priv->stations[sta_id].sta.mode = STA_CONTROL_MODIFY_MSK;
-        iwl_send_add_sta(priv, &priv->stations[sta_id].sta, CMD_ASYNC);
-        spin_unlock_irqrestore(&priv->shrd->sta_lock, flags);
-
-}
 
 void iwl_sta_modify_sleep_tx_count(struct iwl_priv *priv, int sta_id, int cnt)
 {
@@ -1494,36 +1463,3 @@ void iwl_sta_modify_sleep_tx_count(struct iwl_priv *priv, int sta_id, int cnt)
         spin_unlock_irqrestore(&priv->shrd->sta_lock, flags);
 
 }
-
-void iwlagn_mac_sta_notify(struct ieee80211_hw *hw,
-                           struct ieee80211_vif *vif,
-                           enum sta_notify_cmd cmd,
-                           struct ieee80211_sta *sta)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
-        int sta_id;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        switch (cmd) {
-        case STA_NOTIFY_SLEEP:
-                WARN_ON(!sta_priv->client);
-                sta_priv->asleep = true;
-                if (atomic_read(&sta_priv->pending_frames) > 0)
-                        ieee80211_sta_block_awake(hw, sta, true);
-                break;
-        case STA_NOTIFY_AWAKE:
-                WARN_ON(!sta_priv->client);
-                if (!sta_priv->asleep)
-                        break;
-                sta_priv->asleep = false;
-                sta_id = iwl_sta_id(sta);
-                if (sta_id != IWL_INVALID_STATION)
-                        iwl_sta_modify_ps_wake(priv, sta_id);
-                break;
-        default:
-                break;
-        }
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-tx.c b/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
index 35a6b71f358c..e6a02e09ee18 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
@@ -283,6 +283,19 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
                 IWL_DEBUG_TX(priv, "Sending REASSOC frame\n");
 #endif
 
+        if (unlikely(ieee80211_is_probe_resp(fc))) {
+                struct iwl_wipan_noa_data *noa_data =
+                        rcu_dereference(priv->noa_data);
+
+                if (noa_data &&
+                    pskb_expand_head(skb, 0, noa_data->length,
+                                     GFP_ATOMIC) == 0) {
+                        memcpy(skb_put(skb, noa_data->length),
+                               noa_data->data, noa_data->length);
+                        hdr = (struct ieee80211_hdr *)skb->data;
+                }
+        }
+
         hdr_len = ieee80211_hdrlen(fc);
 
         /* For management frames use broadcast id to do not break aggregation */
@@ -800,7 +813,8 @@ int iwlagn_rx_reply_tx(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb,
                             iwl_is_associated_ctx(ctx) && ctx->vif &&
                             ctx->vif->type == NL80211_IFTYPE_STATION) {
                                 ctx->last_tx_rejected = true;
-                                iwl_trans_stop_queue(trans(priv), txq_id);
+                                iwl_trans_stop_queue(trans(priv), txq_id,
+                                        "Tx on passive channel");
 
                                 IWL_DEBUG_TX_REPLY(priv,
                                            "TXQ %d status %s (0x%08x) "
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c b/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
index 8ba0dd54e37d..9ec315b31d45 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
@@ -31,6 +31,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/sched.h>
+#include <linux/dma-mapping.h>
 
 #include "iwl-dev.h"
 #include "iwl-core.h"
@@ -72,51 +73,98 @@ static struct iwl_wimax_coex_event_entry cu_priorities[COEX_NUM_OF_EVENTS] = {
         {COEX_CU_RSRVD2_RP, COEX_CU_RSRVD2_WP, 0, COEX_RSRVD2_FLAGS}
 };
 
+/******************************************************************************
+ *
+ * uCode download functions
+ *
+ ******************************************************************************/
+
+static void iwl_free_fw_desc(struct iwl_bus *bus, struct fw_desc *desc)
+{
+        if (desc->v_addr)
+                dma_free_coherent(bus->dev, desc->len,
+                                  desc->v_addr, desc->p_addr);
+        desc->v_addr = NULL;
+        desc->len = 0;
+}
+
+static void iwl_free_fw_img(struct iwl_bus *bus, struct fw_img *img)
+{
+        iwl_free_fw_desc(bus, &img->code);
+        iwl_free_fw_desc(bus, &img->data);
+}
+
+void iwl_dealloc_ucode(struct iwl_trans *trans)
+{
+        iwl_free_fw_img(bus(trans), &trans->ucode_rt);
+        iwl_free_fw_img(bus(trans), &trans->ucode_init);
+        iwl_free_fw_img(bus(trans), &trans->ucode_wowlan);
+}
+
+int iwl_alloc_fw_desc(struct iwl_bus *bus, struct fw_desc *desc,
+                      const void *data, size_t len)
+{
+        if (!len) {
+                desc->v_addr = NULL;
+                return -EINVAL;
+        }
+
+        desc->v_addr = dma_alloc_coherent(bus->dev, len,
+                                          &desc->p_addr, GFP_KERNEL);
+        if (!desc->v_addr)
+                return -ENOMEM;
+
+        desc->len = len;
+        memcpy(desc->v_addr, data, len);
+        return 0;
+}
+
 /*
  * ucode
  */
-static int iwlagn_load_section(struct iwl_priv *priv, const char *name,
+static int iwlagn_load_section(struct iwl_trans *trans, const char *name,
                                 struct fw_desc *image, u32 dst_addr)
 {
+        struct iwl_bus *bus = bus(trans);
         dma_addr_t phy_addr = image->p_addr;
         u32 byte_cnt = image->len;
         int ret;
 
-        priv->ucode_write_complete = 0;
+        trans->ucode_write_complete = 0;
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_TCSR_CHNL_TX_CONFIG_REG(FH_SRVC_CHNL),
                 FH_TCSR_TX_CONFIG_REG_VAL_DMA_CHNL_PAUSE);
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_SRVC_CHNL_SRAM_ADDR_REG(FH_SRVC_CHNL), dst_addr);
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_TFDIB_CTRL0_REG(FH_SRVC_CHNL),
                 phy_addr & FH_MEM_TFDIB_DRAM_ADDR_LSB_MSK);
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_TFDIB_CTRL1_REG(FH_SRVC_CHNL),
                 (iwl_get_dma_hi_addr(phy_addr)
                         << FH_MEM_TFDIB_REG1_ADDR_BITSHIFT) | byte_cnt);
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_TCSR_CHNL_TX_BUF_STS_REG(FH_SRVC_CHNL),
                 1 << FH_TCSR_CHNL_TX_BUF_STS_REG_POS_TB_NUM |
                 1 << FH_TCSR_CHNL_TX_BUF_STS_REG_POS_TB_IDX |
                 FH_TCSR_CHNL_TX_BUF_STS_REG_VAL_TFDB_VALID);
 
-        iwl_write_direct32(bus(priv),
+        iwl_write_direct32(bus,
                 FH_TCSR_CHNL_TX_CONFIG_REG(FH_SRVC_CHNL),
                 FH_TCSR_TX_CONFIG_REG_VAL_DMA_CHNL_ENABLE       |
                 FH_TCSR_TX_CONFIG_REG_VAL_DMA_CREDIT_DISABLE    |
                 FH_TCSR_TX_CONFIG_REG_VAL_CIRQ_HOST_ENDTFD);
 
-        IWL_DEBUG_FW(priv, "%s uCode section being loaded...\n", name);
-        ret = wait_event_timeout(priv->shrd->wait_command_queue,
-                                 priv->ucode_write_complete, 5 * HZ);
+        IWL_DEBUG_FW(bus, "%s uCode section being loaded...\n", name);
+        ret = wait_event_timeout(trans->shrd->wait_command_queue,
+                                 trans->ucode_write_complete, 5 * HZ);
         if (!ret) {
-                IWL_ERR(priv, "Could not load the %s uCode section\n",
+                IWL_ERR(trans, "Could not load the %s uCode section\n",
                         name);
                 return -ETIMEDOUT;
         }
@@ -124,17 +172,41 @@ static int iwlagn_load_section(struct iwl_priv *priv, const char *name,
         return 0;
 }
 
-static int iwlagn_load_given_ucode(struct iwl_priv *priv,
-                                   struct fw_img *image)
+static inline struct fw_img *iwl_get_ucode_image(struct iwl_trans *trans,
+                                        enum iwl_ucode_type ucode_type)
+{
+        switch (ucode_type) {
+        case IWL_UCODE_INIT:
+                return &trans->ucode_init;
+        case IWL_UCODE_WOWLAN:
+                return &trans->ucode_wowlan;
+        case IWL_UCODE_REGULAR:
+                return &trans->ucode_rt;
+        case IWL_UCODE_NONE:
+                break;
+        }
+        return NULL;
+}
+
+static int iwlagn_load_given_ucode(struct iwl_trans *trans,
+                                   enum iwl_ucode_type ucode_type)
 {
         int ret = 0;
+        struct fw_img *image = iwl_get_ucode_image(trans, ucode_type);
+
+
+        if (!image) {
+                IWL_ERR(trans, "Invalid ucode requested (%d)\n",
+                        ucode_type);
+                return -EINVAL;
+        }
 
-        ret = iwlagn_load_section(priv, "INST", &image->code,
+        ret = iwlagn_load_section(trans, "INST", &image->code,
                                    IWLAGN_RTC_INST_LOWER_BOUND);
         if (ret)
                 return ret;
 
-        return iwlagn_load_section(priv, "DATA", &image->data,
+        return iwlagn_load_section(trans, "DATA", &image->data,
                                     IWLAGN_RTC_DATA_LOWER_BOUND);
 }
 
@@ -418,7 +490,7 @@ static int iwlagn_alive_notify(struct iwl_priv *priv)
  *   using sample data 100 bytes apart.  If these sample points are good,
  *   it's a pretty good bet that everything between them is good, too.
  */
-static int iwl_verify_inst_sparse(struct iwl_priv *priv,
+static int iwl_verify_inst_sparse(struct iwl_bus *bus,
                                       struct fw_desc *fw_desc)
 {
         __le32 *image = (__le32 *)fw_desc->v_addr;
@@ -426,15 +498,15 @@ static int iwl_verify_inst_sparse(struct iwl_priv *priv,
         u32 val;
         u32 i;
 
-        IWL_DEBUG_FW(priv, "ucode inst image size is %u\n", len);
+        IWL_DEBUG_FW(bus, "ucode inst image size is %u\n", len);
 
         for (i = 0; i < len; i += 100, image += 100/sizeof(u32)) {
                 /* read data comes through single port, auto-incr addr */
                 /* NOTE: Use the debugless read so we don't flood kernel log
                  * if IWL_DL_IO is set */
-                iwl_write_direct32(bus(priv), HBUS_TARG_MEM_RADDR,
+                iwl_write_direct32(bus, HBUS_TARG_MEM_RADDR,
                         i + IWLAGN_RTC_INST_LOWER_BOUND);
-                val = iwl_read32(bus(priv), HBUS_TARG_MEM_RDAT);
+                val = iwl_read32(bus, HBUS_TARG_MEM_RDAT);
                 if (val != le32_to_cpu(*image))
                         return -EIO;
         }
@@ -442,7 +514,7 @@ static int iwl_verify_inst_sparse(struct iwl_priv *priv,
         return 0;
 }
 
-static void iwl_print_mismatch_inst(struct iwl_priv *priv,
+static void iwl_print_mismatch_inst(struct iwl_bus *bus,
                                     struct fw_desc *fw_desc)
 {
         __le32 *image = (__le32 *)fw_desc->v_addr;
@@ -451,18 +523,18 @@ static void iwl_print_mismatch_inst(struct iwl_priv *priv,
         u32 offs;
         int errors = 0;
 
-        IWL_DEBUG_FW(priv, "ucode inst image size is %u\n", len);
+        IWL_DEBUG_FW(bus, "ucode inst image size is %u\n", len);
 
-        iwl_write_direct32(bus(priv), HBUS_TARG_MEM_RADDR,
+        iwl_write_direct32(bus, HBUS_TARG_MEM_RADDR,
                            IWLAGN_RTC_INST_LOWER_BOUND);
 
         for (offs = 0;
              offs < len && errors < 20;
              offs += sizeof(u32), image++) {
                 /* read data comes through single port, auto-incr addr */
-                val = iwl_read32(bus(priv), HBUS_TARG_MEM_RDAT);
+                val = iwl_read32(bus, HBUS_TARG_MEM_RDAT);
                 if (val != le32_to_cpu(*image)) {
-                        IWL_ERR(priv, "uCode INST section at "
+                        IWL_ERR(bus, "uCode INST section at "
                                 "offset 0x%x, is 0x%x, s/b 0x%x\n",
                                 offs, val, le32_to_cpu(*image));
                         errors++;
@@ -474,16 +546,24 @@ static void iwl_print_mismatch_inst(struct iwl_priv *priv,
  * iwl_verify_ucode - determine which instruction image is in SRAM,
  *    and verify its contents
  */
-static int iwl_verify_ucode(struct iwl_priv *priv, struct fw_img *img)
+static int iwl_verify_ucode(struct iwl_trans *trans,
+                            enum iwl_ucode_type ucode_type)
 {
-        if (!iwl_verify_inst_sparse(priv, &img->code)) {
-                IWL_DEBUG_FW(priv, "uCode is good in inst SRAM\n");
+        struct fw_img *img = iwl_get_ucode_image(trans, ucode_type);
+
+        if (!img) {
+                IWL_ERR(trans, "Invalid ucode requested (%d)\n", ucode_type);
+                return -EINVAL;
+        }
+
+        if (!iwl_verify_inst_sparse(bus(trans), &img->code)) {
+                IWL_DEBUG_FW(trans, "uCode is good in inst SRAM\n");
                 return 0;
         }
 
-        IWL_ERR(priv, "UCODE IMAGE IN INSTRUCTION SRAM NOT VALID!!\n");
+        IWL_ERR(trans, "UCODE IMAGE IN INSTRUCTION SRAM NOT VALID!!\n");
 
-        iwl_print_mismatch_inst(priv, &img->code);
+        iwl_print_mismatch_inst(bus(trans), &img->code);
         return -EIO;
 }
 
@@ -519,13 +599,12 @@ static void iwlagn_alive_fn(struct iwl_priv *priv,
 #define UCODE_CALIB_TIMEOUT     (2*HZ)
 
 int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
-                                 struct fw_img *image,
-                                 enum iwlagn_ucode_type ucode_type)
+                                 enum iwl_ucode_type ucode_type)
 {
         struct iwl_notification_wait alive_wait;
         struct iwlagn_alive_data alive_data;
         int ret;
-        enum iwlagn_ucode_type old_type;
+        enum iwl_ucode_type old_type;
 
         ret = iwl_trans_start_device(trans(priv));
         if (ret)
@@ -537,7 +616,7 @@ int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
         old_type = priv->ucode_type;
         priv->ucode_type = ucode_type;
 
-        ret = iwlagn_load_given_ucode(priv, image);
+        ret = iwlagn_load_given_ucode(trans(priv), ucode_type);
         if (ret) {
                 priv->ucode_type = old_type;
                 iwlagn_remove_notification(priv, &alive_wait);
@@ -568,7 +647,7 @@ int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
          * skip it for WoWLAN.
          */
         if (ucode_type != IWL_UCODE_WOWLAN) {
-                ret = iwl_verify_ucode(priv, image);
+                ret = iwl_verify_ucode(trans(priv), ucode_type);
                 if (ret) {
                         priv->ucode_type = old_type;
                         return ret;
@@ -597,7 +676,7 @@ int iwlagn_run_init_ucode(struct iwl_priv *priv)
         lockdep_assert_held(&priv->shrd->mutex);
 
         /* No init ucode required? Curious, but maybe ok */
-        if (!priv->ucode_init.code.len)
+        if (!trans(priv)->ucode_init.code.len)
                 return 0;
 
         if (priv->ucode_type != IWL_UCODE_NONE)
@@ -608,8 +687,7 @@ int iwlagn_run_init_ucode(struct iwl_priv *priv)
                                       NULL, NULL);
 
         /* Will also start the device */
-        ret = iwlagn_load_ucode_wait_alive(priv, &priv->ucode_init,
-                                           IWL_UCODE_INIT);
+        ret = iwlagn_load_ucode_wait_alive(priv, IWL_UCODE_INIT);
         if (ret)
                 goto error;
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index ccba69b7f8a7..e235e84de8b4 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -30,7 +30,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-#include <linux/dma-mapping.h>
 #include <linux/delay.h>
 #include <linux/sched.h>
 #include <linux/skbuff.h>
@@ -452,52 +451,6 @@ static void iwl_bg_tx_flush(struct work_struct *work)
         iwlagn_dev_txfifo_flush(priv, IWL_DROP_ALL);
 }
 
-/******************************************************************************
- *
- * uCode download functions
- *
- ******************************************************************************/
-
-static void iwl_free_fw_desc(struct iwl_priv *priv, struct fw_desc *desc)
-{
-        if (desc->v_addr)
-                dma_free_coherent(bus(priv)->dev, desc->len,
-                                  desc->v_addr, desc->p_addr);
-        desc->v_addr = NULL;
-        desc->len = 0;
-}
-
-static void iwl_free_fw_img(struct iwl_priv *priv, struct fw_img *img)
-{
-        iwl_free_fw_desc(priv, &img->code);
-        iwl_free_fw_desc(priv, &img->data);
-}
-
-static void iwl_dealloc_ucode(struct iwl_priv *priv)
-{
-        iwl_free_fw_img(priv, &priv->ucode_rt);
-        iwl_free_fw_img(priv, &priv->ucode_init);
-        iwl_free_fw_img(priv, &priv->ucode_wowlan);
-}
-
-static int iwl_alloc_fw_desc(struct iwl_priv *priv, struct fw_desc *desc,
-                             const void *data, size_t len)
-{
-        if (!len) {
-                desc->v_addr = NULL;
-                return -EINVAL;
-        }
-
-        desc->v_addr = dma_alloc_coherent(bus(priv)->dev, len,
-                                          &desc->p_addr, GFP_KERNEL);
-        if (!desc->v_addr)
-                return -ENOMEM;
-
-        desc->len = len;
-        memcpy(desc->v_addr, data, len);
-        return 0;
-}
-
 static void iwl_init_context(struct iwl_priv *priv, u32 ucode_flags)
 {
         int i;
@@ -555,16 +508,7 @@ static void iwl_init_context(struct iwl_priv *priv, u32 ucode_flags)
         BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
 }
 
-
-struct iwlagn_ucode_capabilities {
-        u32 max_probe_length;
-        u32 standard_phy_calibration_size;
-        u32 flags;
-};
-
 static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context);
-static int iwlagn_mac_setup_register(struct iwl_priv *priv,
-                                  struct iwlagn_ucode_capabilities *capa);
 
 #define UCODE_EXPERIMENTAL_INDEX        100
 #define UCODE_EXPERIMENTAL_TAG          "exp"
@@ -1040,30 +984,32 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
         /* Runtime instructions and 2 copies of data:
          * 1) unmodified from disk
          * 2) backup cache for save/restore during power-downs */
-        if (iwl_alloc_fw_desc(priv, &priv->ucode_rt.code,
+        if (iwl_alloc_fw_desc(bus(priv), &trans(priv)->ucode_rt.code,
                               pieces.inst, pieces.inst_size))
                 goto err_pci_alloc;
-        if (iwl_alloc_fw_desc(priv, &priv->ucode_rt.data,
+        if (iwl_alloc_fw_desc(bus(priv), &trans(priv)->ucode_rt.data,
                               pieces.data, pieces.data_size))
                 goto err_pci_alloc;
 
         /* Initialization instructions and data */
         if (pieces.init_size && pieces.init_data_size) {
-                if (iwl_alloc_fw_desc(priv, &priv->ucode_init.code,
+                if (iwl_alloc_fw_desc(bus(priv), &trans(priv)->ucode_init.code,
                                       pieces.init, pieces.init_size))
                         goto err_pci_alloc;
-                if (iwl_alloc_fw_desc(priv, &priv->ucode_init.data,
+                if (iwl_alloc_fw_desc(bus(priv), &trans(priv)->ucode_init.data,
                                       pieces.init_data, pieces.init_data_size))
                         goto err_pci_alloc;
         }
 
         /* WoWLAN instructions and data */
         if (pieces.wowlan_inst_size && pieces.wowlan_data_size) {
-                if (iwl_alloc_fw_desc(priv, &priv->ucode_wowlan.code,
+                if (iwl_alloc_fw_desc(bus(priv),
+                                      &trans(priv)->ucode_wowlan.code,
                                       pieces.wowlan_inst,
                                       pieces.wowlan_inst_size))
                         goto err_pci_alloc;
-                if (iwl_alloc_fw_desc(priv, &priv->ucode_wowlan.data,
+                if (iwl_alloc_fw_desc(bus(priv),
+                                      &trans(priv)->ucode_wowlan.data,
                                       pieces.wowlan_data,
                                       pieces.wowlan_data_size))
                         goto err_pci_alloc;
@@ -1156,7 +1102,7 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
 
  err_pci_alloc:
         IWL_ERR(priv, "failed to allocate pci memory\n");
-        iwl_dealloc_ucode(priv);
+        iwl_dealloc_ucode(trans(priv));
  out_unbind:
         complete(&priv->firmware_loading_complete);
         device_release_driver(bus(priv)->dev);
@@ -1352,7 +1298,7 @@ int iwl_alive_start(struct iwl_priv *priv)
 
 static void iwl_cancel_deferred_work(struct iwl_priv *priv);
 
-static void __iwl_down(struct iwl_priv *priv)
+void __iwl_down(struct iwl_priv *priv)
 {
         int exit_pending;
 
@@ -1415,7 +1361,7 @@ static void __iwl_down(struct iwl_priv *priv)
         priv->beacon_skb = NULL;
 }
 
-static void iwl_down(struct iwl_priv *priv)
+void iwl_down(struct iwl_priv *priv)
 {
         mutex_lock(&priv->shrd->mutex);
         __iwl_down(priv);
@@ -1424,57 +1370,6 @@ static void iwl_down(struct iwl_priv *priv)
         iwl_cancel_deferred_work(priv);
 }
 
-#define MAX_HW_RESTARTS 5
-
-static int __iwl_up(struct iwl_priv *priv)
-{
-        struct iwl_rxon_context *ctx;
-        int ret;
-
-        lockdep_assert_held(&priv->shrd->mutex);
-
-        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status)) {
-                IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
-                return -EIO;
-        }
-
-        for_each_context(priv, ctx) {
-                ret = iwlagn_alloc_bcast_station(priv, ctx);
-                if (ret) {
-                        iwl_dealloc_bcast_stations(priv);
-                        return ret;
-                }
-        }
-
-        ret = iwlagn_run_init_ucode(priv);
-        if (ret) {
-                IWL_ERR(priv, "Failed to run INIT ucode: %d\n", ret);
-                goto error;
-        }
-
-        ret = iwlagn_load_ucode_wait_alive(priv,
-                                           &priv->ucode_rt,
-                                           IWL_UCODE_REGULAR);
-        if (ret) {
-                IWL_ERR(priv, "Failed to start RT ucode: %d\n", ret);
-                goto error;
-        }
-
-        ret = iwl_alive_start(priv);
-        if (ret)
-                goto error;
-        return 0;
-
- error:
-        set_bit(STATUS_EXIT_PENDING, &priv->shrd->status);
-        __iwl_down(priv);
-        clear_bit(STATUS_EXIT_PENDING, &priv->shrd->status);
-
-        IWL_ERR(priv, "Unable to initialize device.\n");
-        return ret;
-}
-
-
 /*****************************************************************************
  *
  * Workqueue callbacks
@@ -1502,7 +1397,7 @@ static void iwl_bg_run_time_calib_work(struct work_struct *work)
         mutex_unlock(&priv->shrd->mutex);
 }
 
-static void iwlagn_prepare_restart(struct iwl_priv *priv)
+void iwlagn_prepare_restart(struct iwl_priv *priv)
 {
         struct iwl_rxon_context *ctx;
         bool bt_full_concurrent;
@@ -1559,1173 +1454,8 @@ static void iwl_bg_restart(struct work_struct *data)
         }
 }
 
-/*****************************************************************************
- *
- * mac80211 entry point functions
- *
- *****************************************************************************/
-
-static const struct ieee80211_iface_limit iwlagn_sta_ap_limits[] = {
-        {
-                .max = 1,
-                .types = BIT(NL80211_IFTYPE_STATION),
-        },
-        {
-                .max = 1,
-                .types = BIT(NL80211_IFTYPE_AP),
-        },
-};
-
-static const struct ieee80211_iface_limit iwlagn_2sta_limits[] = {
-        {
-                .max = 2,
-                .types = BIT(NL80211_IFTYPE_STATION),
-        },
-};
-
-static const struct ieee80211_iface_limit iwlagn_p2p_sta_go_limits[] = {
-        {
-                .max = 1,
-                .types = BIT(NL80211_IFTYPE_STATION),
-        },
-        {
-                .max = 1,
-                .types = BIT(NL80211_IFTYPE_P2P_GO) |
-                         BIT(NL80211_IFTYPE_AP),
-        },
-};
-
-static const struct ieee80211_iface_limit iwlagn_p2p_2sta_limits[] = {
-        {
-                .max = 2,
-                .types = BIT(NL80211_IFTYPE_STATION),
-        },
-        {
-                .max = 1,
-                .types = BIT(NL80211_IFTYPE_P2P_CLIENT),
-        },
-};
-
-static const struct ieee80211_iface_combination
-iwlagn_iface_combinations_dualmode[] = {
-        { .num_different_channels = 1,
-          .max_interfaces = 2,
-          .beacon_int_infra_match = true,
-          .limits = iwlagn_sta_ap_limits,
-          .n_limits = ARRAY_SIZE(iwlagn_sta_ap_limits),
-        },
-        { .num_different_channels = 1,
-          .max_interfaces = 2,
-          .limits = iwlagn_2sta_limits,
-          .n_limits = ARRAY_SIZE(iwlagn_2sta_limits),
-        },
-};
-
-static const struct ieee80211_iface_combination
-iwlagn_iface_combinations_p2p[] = {
-        { .num_different_channels = 1,
-          .max_interfaces = 2,
-          .beacon_int_infra_match = true,
-          .limits = iwlagn_p2p_sta_go_limits,
-          .n_limits = ARRAY_SIZE(iwlagn_p2p_sta_go_limits),
-        },
-        { .num_different_channels = 1,
-          .max_interfaces = 2,
-          .limits = iwlagn_p2p_2sta_limits,
-          .n_limits = ARRAY_SIZE(iwlagn_p2p_2sta_limits),
-        },
-};
-
-/*
- * Not a mac80211 entry point function, but it fits in with all the
- * other mac80211 functions grouped here.
- */
-static int iwlagn_mac_setup_register(struct iwl_priv *priv,
-                                  struct iwlagn_ucode_capabilities *capa)
-{
-        int ret;
-        struct ieee80211_hw *hw = priv->hw;
-        struct iwl_rxon_context *ctx;
-
-        hw->rate_control_algorithm = "iwl-agn-rs";
-
-        /* Tell mac80211 our characteristics */
-        hw->flags = IEEE80211_HW_SIGNAL_DBM |
-                    IEEE80211_HW_AMPDU_AGGREGATION |
-                    IEEE80211_HW_NEED_DTIM_PERIOD |
-                    IEEE80211_HW_SPECTRUM_MGMT |
-                    IEEE80211_HW_REPORTS_TX_ACK_STATUS;
-
-        /*
-         * Including the following line will crash some AP's.  This
-         * workaround removes the stimulus which causes the crash until
-         * the AP software can be fixed.
-        hw->max_tx_aggregation_subframes = LINK_QUAL_AGG_FRAME_LIMIT_DEF;
-         */
-
-        hw->flags |= IEEE80211_HW_SUPPORTS_PS |
-                     IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
-
-        if (priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE)
-                hw->flags |= IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS |
-                             IEEE80211_HW_SUPPORTS_STATIC_SMPS;
-
-        if (capa->flags & IWL_UCODE_TLV_FLAGS_MFP)
-                hw->flags |= IEEE80211_HW_MFP_CAPABLE;
-
-        hw->sta_data_size = sizeof(struct iwl_station_priv);
-        hw->vif_data_size = sizeof(struct iwl_vif_priv);
-
-        for_each_context(priv, ctx) {
-                hw->wiphy->interface_modes |= ctx->interface_modes;
-                hw->wiphy->interface_modes |= ctx->exclusive_interface_modes;
-        }
-
-        BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
-
-        if (hw->wiphy->interface_modes & BIT(NL80211_IFTYPE_P2P_CLIENT)) {
-                hw->wiphy->iface_combinations = iwlagn_iface_combinations_p2p;
-                hw->wiphy->n_iface_combinations =
-                        ARRAY_SIZE(iwlagn_iface_combinations_p2p);
-        } else if (hw->wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) {
-                hw->wiphy->iface_combinations = iwlagn_iface_combinations_dualmode;
-                hw->wiphy->n_iface_combinations =
-                        ARRAY_SIZE(iwlagn_iface_combinations_dualmode);
-        }
-
-        hw->wiphy->max_remain_on_channel_duration = 1000;
-
-        hw->wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY |
-                            WIPHY_FLAG_DISABLE_BEACON_HINTS |
-                            WIPHY_FLAG_IBSS_RSN;
-
-        if (priv->ucode_wowlan.code.len && device_can_wakeup(bus(priv)->dev)) {
-                hw->wiphy->wowlan.flags = WIPHY_WOWLAN_MAGIC_PKT |
-                                          WIPHY_WOWLAN_DISCONNECT |
-                                          WIPHY_WOWLAN_EAP_IDENTITY_REQ |
-                                          WIPHY_WOWLAN_RFKILL_RELEASE;
-                if (!iwlagn_mod_params.sw_crypto)
-                        hw->wiphy->wowlan.flags |=
-                                WIPHY_WOWLAN_SUPPORTS_GTK_REKEY |
-                                WIPHY_WOWLAN_GTK_REKEY_FAILURE;
-
-                hw->wiphy->wowlan.n_patterns = IWLAGN_WOWLAN_MAX_PATTERNS;
-                hw->wiphy->wowlan.pattern_min_len =
-                                        IWLAGN_WOWLAN_MIN_PATTERN_LEN;
-                hw->wiphy->wowlan.pattern_max_len =
-                                        IWLAGN_WOWLAN_MAX_PATTERN_LEN;
-        }
-
-        if (iwlagn_mod_params.power_save)
-                hw->wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT;
-        else
-                hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
-        hw->wiphy->max_scan_ssids = PROBE_OPTION_MAX;
-        /* we create the 802.11 header and a zero-length SSID element */
-        hw->wiphy->max_scan_ie_len = capa->max_probe_length - 24 - 2;
-
-        /* Default value; 4 EDCA QOS priorities */
-        hw->queues = 4;
-
-        hw->max_listen_interval = IWL_CONN_MAX_LISTEN_INTERVAL;
-
-        if (priv->bands[IEEE80211_BAND_2GHZ].n_channels)
-                priv->hw->wiphy->bands[IEEE80211_BAND_2GHZ] =
-                        &priv->bands[IEEE80211_BAND_2GHZ];
-        if (priv->bands[IEEE80211_BAND_5GHZ].n_channels)
-                priv->hw->wiphy->bands[IEEE80211_BAND_5GHZ] =
-                        &priv->bands[IEEE80211_BAND_5GHZ];
-
-        iwl_leds_init(priv);
-
-        ret = ieee80211_register_hw(priv->hw);
-        if (ret) {
-                IWL_ERR(priv, "Failed to register hw (error %d)\n", ret);
-                return ret;
-        }
-        priv->mac80211_registered = 1;
-
-        return 0;
-}
-
-
-static int iwlagn_mac_start(struct ieee80211_hw *hw)
-{
-        struct iwl_priv *priv = hw->priv;
-        int ret;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        /* we should be verifying the device is ready to be opened */
-        mutex_lock(&priv->shrd->mutex);
-        ret = __iwl_up(priv);
-        mutex_unlock(&priv->shrd->mutex);
-        if (ret)
-                return ret;
-
-        IWL_DEBUG_INFO(priv, "Start UP work done.\n");
-
-        /* Now we should be done, and the READY bit should be set. */
-        if (WARN_ON(!test_bit(STATUS_READY, &priv->shrd->status)))
-                ret = -EIO;
-
-        iwlagn_led_enable(priv);
-
-        priv->is_open = 1;
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-        return 0;
-}
-
-static void iwlagn_mac_stop(struct ieee80211_hw *hw)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        if (!priv->is_open)
-                return;
-
-        priv->is_open = 0;
-
-        iwl_down(priv);
-
-        flush_workqueue(priv->shrd->workqueue);
-
-        /* User space software may expect getting rfkill changes
-         * even if interface is down */
-        iwl_write32(bus(priv), CSR_INT, 0xFFFFFFFF);
-        iwl_enable_rfkill_int(priv);
-
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
-
-#ifdef CONFIG_PM_SLEEP
-static int iwlagn_send_patterns(struct iwl_priv *priv,
-                                struct cfg80211_wowlan *wowlan)
-{
-        struct iwlagn_wowlan_patterns_cmd *pattern_cmd;
-        struct iwl_host_cmd cmd = {
-                .id = REPLY_WOWLAN_PATTERNS,
-                .dataflags[0] = IWL_HCMD_DFL_NOCOPY,
-                .flags = CMD_SYNC,
-        };
-        int i, err;
-
-        if (!wowlan->n_patterns)
-                return 0;
-
-        cmd.len[0] = sizeof(*pattern_cmd) +
-                        wowlan->n_patterns * sizeof(struct iwlagn_wowlan_pattern);
-
-        pattern_cmd = kmalloc(cmd.len[0], GFP_KERNEL);
-        if (!pattern_cmd)
-                return -ENOMEM;
-
-        pattern_cmd->n_patterns = cpu_to_le32(wowlan->n_patterns);
-
-        for (i = 0; i < wowlan->n_patterns; i++) {
-                int mask_len = DIV_ROUND_UP(wowlan->patterns[i].pattern_len, 8);
-
-                memcpy(&pattern_cmd->patterns[i].mask,
-                        wowlan->patterns[i].mask, mask_len);
-                memcpy(&pattern_cmd->patterns[i].pattern,
-                        wowlan->patterns[i].pattern,
-                        wowlan->patterns[i].pattern_len);
-                pattern_cmd->patterns[i].mask_size = mask_len;
-                pattern_cmd->patterns[i].pattern_size =
-                        wowlan->patterns[i].pattern_len;
-        }
-
-        cmd.data[0] = pattern_cmd;
-        err = iwl_trans_send_cmd(trans(priv), &cmd);
-        kfree(pattern_cmd);
-        return err;
-}
-#endif
-
-static void iwlagn_mac_set_rekey_data(struct ieee80211_hw *hw,
-                                      struct ieee80211_vif *vif,
-                                      struct cfg80211_gtk_rekey_data *data)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        if (iwlagn_mod_params.sw_crypto)
-                return;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        if (priv->contexts[IWL_RXON_CTX_BSS].vif != vif)
-                goto out;
-
-        memcpy(priv->kek, data->kek, NL80211_KEK_LEN);
-        memcpy(priv->kck, data->kck, NL80211_KCK_LEN);
-        priv->replay_ctr = cpu_to_le64(be64_to_cpup((__be64 *)&data->replay_ctr));
-        priv->have_rekey_data = true;
-
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
-
-struct wowlan_key_data {
-        struct iwl_rxon_context *ctx;
-        struct iwlagn_wowlan_rsc_tsc_params_cmd *rsc_tsc;
-        struct iwlagn_wowlan_tkip_params_cmd *tkip;
-        const u8 *bssid;
-        bool error, use_rsc_tsc, use_tkip;
-};
-
-#ifdef CONFIG_PM_SLEEP
-static void iwlagn_convert_p1k(u16 *p1k, __le16 *out)
-{
-        int i;
-
-        for (i = 0; i < IWLAGN_P1K_SIZE; i++)
-                out[i] = cpu_to_le16(p1k[i]);
-}
-
-static void iwlagn_wowlan_program_keys(struct ieee80211_hw *hw,
-                                       struct ieee80211_vif *vif,
-                                       struct ieee80211_sta *sta,
-                                       struct ieee80211_key_conf *key,
-                                       void *_data)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct wowlan_key_data *data = _data;
-        struct iwl_rxon_context *ctx = data->ctx;
-        struct aes_sc *aes_sc, *aes_tx_sc = NULL;
-        struct tkip_sc *tkip_sc, *tkip_tx_sc = NULL;
-        struct iwlagn_p1k_cache *rx_p1ks;
-        u8 *rx_mic_key;
-        struct ieee80211_key_seq seq;
-        u32 cur_rx_iv32 = 0;
-        u16 p1k[IWLAGN_P1K_SIZE];
-        int ret, i;
-
-        mutex_lock(&priv->shrd->mutex);
-
-        if ((key->cipher == WLAN_CIPHER_SUITE_WEP40 ||
-             key->cipher == WLAN_CIPHER_SUITE_WEP104) &&
-             !sta && !ctx->key_mapping_keys)
-                ret = iwl_set_default_wep_key(priv, ctx, key);
-        else
-                ret = iwl_set_dynamic_key(priv, ctx, key, sta);
-
-        if (ret) {
-                IWL_ERR(priv, "Error setting key during suspend!\n");
-                data->error = true;
-        }
-
-        switch (key->cipher) {
-        case WLAN_CIPHER_SUITE_TKIP:
-                if (sta) {
-                        tkip_sc = data->rsc_tsc->all_tsc_rsc.tkip.unicast_rsc;
-                        tkip_tx_sc = &data->rsc_tsc->all_tsc_rsc.tkip.tsc;
-
-                        rx_p1ks = data->tkip->rx_uni;
-
-                        ieee80211_get_key_tx_seq(key, &seq);
-                        tkip_tx_sc->iv16 = cpu_to_le16(seq.tkip.iv16);
-                        tkip_tx_sc->iv32 = cpu_to_le32(seq.tkip.iv32);
-
-                        ieee80211_get_tkip_p1k_iv(key, seq.tkip.iv32, p1k);
-                        iwlagn_convert_p1k(p1k, data->tkip->tx.p1k);
-
-                        memcpy(data->tkip->mic_keys.tx,
-                               &key->key[NL80211_TKIP_DATA_OFFSET_TX_MIC_KEY],
-                               IWLAGN_MIC_KEY_SIZE);
-
-                        rx_mic_key = data->tkip->mic_keys.rx_unicast;
-                } else {
-                        tkip_sc = data->rsc_tsc->all_tsc_rsc.tkip.multicast_rsc;
-                        rx_p1ks = data->tkip->rx_multi;
-                        rx_mic_key = data->tkip->mic_keys.rx_mcast;
-                }
-
-                /*
-                 * For non-QoS this relies on the fact that both the uCode and
-                 * mac80211 use TID 0 (as they need to to avoid replay attacks)
-                 * for checking the IV in the frames.
-                 */
-                for (i = 0; i < IWLAGN_NUM_RSC; i++) {
-                        ieee80211_get_key_rx_seq(key, i, &seq);
-                        tkip_sc[i].iv16 = cpu_to_le16(seq.tkip.iv16);
-                        tkip_sc[i].iv32 = cpu_to_le32(seq.tkip.iv32);
-                        /* wrapping isn't allowed, AP must rekey */
-                        if (seq.tkip.iv32 > cur_rx_iv32)
-                                cur_rx_iv32 = seq.tkip.iv32;
-                }
-
-                ieee80211_get_tkip_rx_p1k(key, data->bssid, cur_rx_iv32, p1k);
-                iwlagn_convert_p1k(p1k, rx_p1ks[0].p1k);
-                ieee80211_get_tkip_rx_p1k(key, data->bssid,
-                                          cur_rx_iv32 + 1, p1k);
-                iwlagn_convert_p1k(p1k, rx_p1ks[1].p1k);
-
-                memcpy(rx_mic_key,
-                       &key->key[NL80211_TKIP_DATA_OFFSET_RX_MIC_KEY],
-                       IWLAGN_MIC_KEY_SIZE);
-
-                data->use_tkip = true;
-                data->use_rsc_tsc = true;
-                break;
-        case WLAN_CIPHER_SUITE_CCMP:
-                if (sta) {
-                        u8 *pn = seq.ccmp.pn;
-
-                        aes_sc = data->rsc_tsc->all_tsc_rsc.aes.unicast_rsc;
-                        aes_tx_sc = &data->rsc_tsc->all_tsc_rsc.aes.tsc;
-
-                        ieee80211_get_key_tx_seq(key, &seq);
-                        aes_tx_sc->pn = cpu_to_le64(
-                                        (u64)pn[5] |
-                                        ((u64)pn[4] << 8) |
-                                        ((u64)pn[3] << 16) |
-                                        ((u64)pn[2] << 24) |
-                                        ((u64)pn[1] << 32) |
-                                        ((u64)pn[0] << 40));
-                } else
-                        aes_sc = data->rsc_tsc->all_tsc_rsc.aes.multicast_rsc;
-
-                /*
-                 * For non-QoS this relies on the fact that both the uCode and
-                 * mac80211 use TID 0 for checking the IV in the frames.
-                 */
-                for (i = 0; i < IWLAGN_NUM_RSC; i++) {
-                        u8 *pn = seq.ccmp.pn;
-
-                        ieee80211_get_key_rx_seq(key, i, &seq);
-                        aes_sc->pn = cpu_to_le64(
-                                        (u64)pn[5] |
-                                        ((u64)pn[4] << 8) |
-                                        ((u64)pn[3] << 16) |
-                                        ((u64)pn[2] << 24) |
-                                        ((u64)pn[1] << 32) |
-                                        ((u64)pn[0] << 40));
-                }
-                data->use_rsc_tsc = true;
-                break;
-        }
-
-        mutex_unlock(&priv->shrd->mutex);
-}
-
-static int iwlagn_mac_suspend(struct ieee80211_hw *hw,
-                              struct cfg80211_wowlan *wowlan)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwlagn_wowlan_wakeup_filter_cmd wakeup_filter_cmd;
-        struct iwl_rxon_cmd rxon;
-        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
-        struct iwlagn_wowlan_kek_kck_material_cmd kek_kck_cmd;
-        struct iwlagn_wowlan_tkip_params_cmd tkip_cmd = {};
-        struct wowlan_key_data key_data = {
-                .ctx = ctx,
-                .bssid = ctx->active.bssid_addr,
-                .use_rsc_tsc = false,
-                .tkip = &tkip_cmd,
-                .use_tkip = false,
-        };
-        int ret, i;
-        u16 seq;
-
-        if (WARN_ON(!wowlan))
-                return -EINVAL;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        /* Don't attempt WoWLAN when not associated, tear down instead. */
-        if (!ctx->vif || ctx->vif->type != NL80211_IFTYPE_STATION ||
-            !iwl_is_associated_ctx(ctx)) {
-                ret = 1;
-                goto out;
-        }
-
-        key_data.rsc_tsc = kzalloc(sizeof(*key_data.rsc_tsc), GFP_KERNEL);
-        if (!key_data.rsc_tsc) {
-                ret = -ENOMEM;
-                goto out;
-        }
-
-        memset(&wakeup_filter_cmd, 0, sizeof(wakeup_filter_cmd));
-
-        /*
-         * We know the last used seqno, and the uCode expects to know that
-         * one, it will increment before TX.
-         */
-        seq = le16_to_cpu(priv->last_seq_ctl) & IEEE80211_SCTL_SEQ;
-        wakeup_filter_cmd.non_qos_seq = cpu_to_le16(seq);
-
-        /*
-         * For QoS counters, we store the one to use next, so subtract 0x10
-         * since the uCode will add 0x10 before using the value.
-         */
-        for (i = 0; i < 8; i++) {
-                seq = priv->shrd->tid_data[IWL_AP_ID][i].seq_number;
-                seq -= 0x10;
-                wakeup_filter_cmd.qos_seq[i] = cpu_to_le16(seq);
-        }
-
-        if (wowlan->disconnect)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_BEACON_MISS |
-                                    IWLAGN_WOWLAN_WAKEUP_LINK_CHANGE);
-        if (wowlan->magic_pkt)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_MAGIC_PACKET);
-        if (wowlan->gtk_rekey_failure)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_GTK_REKEY_FAIL);
-        if (wowlan->eap_identity_req)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_EAP_IDENT_REQ);
-        if (wowlan->four_way_handshake)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_4WAY_HANDSHAKE);
-        if (wowlan->rfkill_release)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_RFKILL);
-        if (wowlan->n_patterns)
-                wakeup_filter_cmd.enabled |=
-                        cpu_to_le32(IWLAGN_WOWLAN_WAKEUP_PATTERN_MATCH);
-
-        iwl_scan_cancel_timeout(priv, 200);
-
-        memcpy(&rxon, &ctx->active, sizeof(rxon));
-
-        iwl_trans_stop_device(trans(priv));
-
-        priv->shrd->wowlan = true;
-
-        ret = iwlagn_load_ucode_wait_alive(priv, &priv->ucode_wowlan,
-                                           IWL_UCODE_WOWLAN);
-        if (ret)
-                goto error;
-
-        /* now configure WoWLAN ucode */
-        ret = iwl_alive_start(priv);
-        if (ret)
-                goto error;
-
-        memcpy(&ctx->staging, &rxon, sizeof(rxon));
-        ret = iwlagn_commit_rxon(priv, ctx);
-        if (ret)
-                goto error;
-
-        ret = iwl_power_update_mode(priv, true);
-        if (ret)
-                goto error;
-
-        if (!iwlagn_mod_params.sw_crypto) {
-                /* mark all keys clear */
-                priv->ucode_key_table = 0;
-                ctx->key_mapping_keys = 0;
-
-                /*
-                 * This needs to be unlocked due to lock ordering
-                 * constraints. Since we're in the suspend path
-                 * that isn't really a problem though.
-                 */
-                mutex_unlock(&priv->shrd->mutex);
-                ieee80211_iter_keys(priv->hw, ctx->vif,
-                                    iwlagn_wowlan_program_keys,
-                                    &key_data);
-                mutex_lock(&priv->shrd->mutex);
-                if (key_data.error) {
-                        ret = -EIO;
-                        goto error;
-                }
-
-                if (key_data.use_rsc_tsc) {
-                        struct iwl_host_cmd rsc_tsc_cmd = {
-                                .id = REPLY_WOWLAN_TSC_RSC_PARAMS,
-                                .flags = CMD_SYNC,
-                                .data[0] = key_data.rsc_tsc,
-                                .dataflags[0] = IWL_HCMD_DFL_NOCOPY,
-                                .len[0] = sizeof(*key_data.rsc_tsc),
-                        };
-
-                        ret = iwl_trans_send_cmd(trans(priv), &rsc_tsc_cmd);
-                        if (ret)
-                                goto error;
-                }
-
-                if (key_data.use_tkip) {
-                        ret = iwl_trans_send_cmd_pdu(trans(priv),
-                                                 REPLY_WOWLAN_TKIP_PARAMS,
-                                                 CMD_SYNC, sizeof(tkip_cmd),
-                                                 &tkip_cmd);
-                        if (ret)
-                                goto error;
-                }
-
-                if (priv->have_rekey_data) {
-                        memset(&kek_kck_cmd, 0, sizeof(kek_kck_cmd));
-                        memcpy(kek_kck_cmd.kck, priv->kck, NL80211_KCK_LEN);
-                        kek_kck_cmd.kck_len = cpu_to_le16(NL80211_KCK_LEN);
-                        memcpy(kek_kck_cmd.kek, priv->kek, NL80211_KEK_LEN);
-                        kek_kck_cmd.kek_len = cpu_to_le16(NL80211_KEK_LEN);
-                        kek_kck_cmd.replay_ctr = priv->replay_ctr;
-
-                        ret = iwl_trans_send_cmd_pdu(trans(priv),
-                                                 REPLY_WOWLAN_KEK_KCK_MATERIAL,
-                                                 CMD_SYNC, sizeof(kek_kck_cmd),
-                                                 &kek_kck_cmd);
-                        if (ret)
-                                goto error;
-                }
-        }
-
-        ret = iwl_trans_send_cmd_pdu(trans(priv), REPLY_WOWLAN_WAKEUP_FILTER,
-                                 CMD_SYNC, sizeof(wakeup_filter_cmd),
-                                 &wakeup_filter_cmd);
-        if (ret)
-                goto error;
-
-        ret = iwlagn_send_patterns(priv, wowlan);
-        if (ret)
-                goto error;
-
-        device_set_wakeup_enable(bus(priv)->dev, true);
-
-        /* Now let the ucode operate on its own */
-        iwl_write32(bus(priv), CSR_UCODE_DRV_GP1_SET,
-                          CSR_UCODE_DRV_GP1_BIT_D3_CFG_COMPLETE);
-
-        goto out;
-
- error:
-        priv->shrd->wowlan = false;
-        iwlagn_prepare_restart(priv);
-        ieee80211_restart_hw(priv->hw);
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        kfree(key_data.rsc_tsc);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return ret;
-}
-
-static int iwlagn_mac_resume(struct ieee80211_hw *hw)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
-        struct ieee80211_vif *vif;
-        unsigned long flags;
-        u32 base, status = 0xffffffff;
-        int ret = -EIO;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        iwl_write32(bus(priv), CSR_UCODE_DRV_GP1_CLR,
-                          CSR_UCODE_DRV_GP1_BIT_D3_CFG_COMPLETE);
-
-        base = priv->device_pointers.error_event_table;
-        if (iwlagn_hw_valid_rtc_data_addr(base)) {
-                spin_lock_irqsave(&bus(priv)->reg_lock, flags);
-                ret = iwl_grab_nic_access_silent(bus(priv));
-                if (ret == 0) {
-                        iwl_write32(bus(priv), HBUS_TARG_MEM_RADDR, base);
-                        status = iwl_read32(bus(priv), HBUS_TARG_MEM_RDAT);
-                        iwl_release_nic_access(bus(priv));
-                }
-                spin_unlock_irqrestore(&bus(priv)->reg_lock, flags);
-
-#ifdef CONFIG_IWLWIFI_DEBUGFS
-                if (ret == 0) {
-                        if (!priv->wowlan_sram)
-                                priv->wowlan_sram =
-                                        kzalloc(priv->ucode_wowlan.data.len,
-                                                GFP_KERNEL);
-
-                        if (priv->wowlan_sram)
-                                _iwl_read_targ_mem_words(
-                                        bus(priv), 0x800000, priv->wowlan_sram,
-                                        priv->ucode_wowlan.data.len / 4);
-                }
-#endif
-        }
-
-        /* we'll clear ctx->vif during iwlagn_prepare_restart() */
-        vif = ctx->vif;
-
-        priv->shrd->wowlan = false;
-
-        device_set_wakeup_enable(bus(priv)->dev, false);
-
-        iwlagn_prepare_restart(priv);
-
-        memset((void *)&ctx->active, 0, sizeof(ctx->active));
-        iwl_connection_init_rx_config(priv, ctx);
-        iwlagn_set_rxon_chain(priv, ctx);
-
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        ieee80211_resume_disconnect(vif);
-
-        return 1;
-}
-#endif
-
-static void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        IWL_DEBUG_MACDUMP(priv, "enter\n");
-
-        IWL_DEBUG_TX(priv, "dev->xmit(%d bytes) at rate 0x%02x\n", skb->len,
-                     ieee80211_get_tx_rate(hw, IEEE80211_SKB_CB(skb))->bitrate);
-
-        if (iwlagn_tx_skb(priv, skb))
-                dev_kfree_skb_any(skb);
-
-        IWL_DEBUG_MACDUMP(priv, "leave\n");
-}
-
-static void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
-                                       struct ieee80211_vif *vif,
-                                       struct ieee80211_key_conf *keyconf,
-                                       struct ieee80211_sta *sta,
-                                       u32 iv32, u16 *phase1key)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        iwl_update_tkip_key(priv, vif, keyconf, sta, iv32, phase1key);
-}
-
-static int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
-                              struct ieee80211_vif *vif,
-                              struct ieee80211_sta *sta,
-                              struct ieee80211_key_conf *key)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
-        struct iwl_rxon_context *ctx = vif_priv->ctx;
-        int ret;
-        bool is_default_wep_key = false;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        if (iwlagn_mod_params.sw_crypto) {
-                IWL_DEBUG_MAC80211(priv, "leave - hwcrypto disabled\n");
-                return -EOPNOTSUPP;
-        }
-
-        /*
-         * We could program these keys into the hardware as well, but we
-         * don't expect much multicast traffic in IBSS and having keys
-         * for more stations is probably more useful.
-         *
-         * Mark key TX-only and return 0.
-         */
-        if (vif->type == NL80211_IFTYPE_ADHOC &&
-            !(key->flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
-                key->hw_key_idx = WEP_INVALID_OFFSET;
-                return 0;
-        }
-
-        /* If they key was TX-only, accept deletion */
-        if (cmd == DISABLE_KEY && key->hw_key_idx == WEP_INVALID_OFFSET)
-                return 0;
-
-        mutex_lock(&priv->shrd->mutex);
-        iwl_scan_cancel_timeout(priv, 100);
-
-        BUILD_BUG_ON(WEP_INVALID_OFFSET == IWLAGN_HW_KEY_DEFAULT);
-
-        /*
-         * If we are getting WEP group key and we didn't receive any key mapping
-         * so far, we are in legacy wep mode (group key only), otherwise we are
-         * in 1X mode.
-         * In legacy wep mode, we use another host command to the uCode.
-         */
-        if ((key->cipher == WLAN_CIPHER_SUITE_WEP40 ||
-             key->cipher == WLAN_CIPHER_SUITE_WEP104) && !sta) {
-                if (cmd == SET_KEY)
-                        is_default_wep_key = !ctx->key_mapping_keys;
-                else
-                        is_default_wep_key =
-                                key->hw_key_idx == IWLAGN_HW_KEY_DEFAULT;
-        }
-
-
-        switch (cmd) {
-        case SET_KEY:
-                if (is_default_wep_key) {
-                        ret = iwl_set_default_wep_key(priv, vif_priv->ctx, key);
-                        break;
-                }
-                ret = iwl_set_dynamic_key(priv, vif_priv->ctx, key, sta);
-                if (ret) {
-                        /*
-                         * can't add key for RX, but we don't need it
-                         * in the device for TX so still return 0
-                         */
-                        ret = 0;
-                        key->hw_key_idx = WEP_INVALID_OFFSET;
-                }
-
-                IWL_DEBUG_MAC80211(priv, "enable hwcrypto key\n");
-                break;
-        case DISABLE_KEY:
-                if (is_default_wep_key)
-                        ret = iwl_remove_default_wep_key(priv, ctx, key);
-                else
-                        ret = iwl_remove_dynamic_key(priv, ctx, key, sta);
-
-                IWL_DEBUG_MAC80211(priv, "disable hwcrypto key\n");
-                break;
-        default:
-                ret = -EINVAL;
-        }
-
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return ret;
-}
-
-static int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
-                                   struct ieee80211_vif *vif,
-                                   enum ieee80211_ampdu_mlme_action action,
-                                   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
-                                   u8 buf_size)
-{
-        struct iwl_priv *priv = hw->priv;
-        int ret = -EINVAL;
-        struct iwl_station_priv *sta_priv = (void *) sta->drv_priv;
-        struct iwl_rxon_context *ctx =  iwl_rxon_ctx_from_vif(vif);
-
-        IWL_DEBUG_HT(priv, "A-MPDU action on addr %pM tid %d\n",
-                     sta->addr, tid);
-
-        if (!(priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE))
-                return -EACCES;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        switch (action) {
-        case IEEE80211_AMPDU_RX_START:
-                IWL_DEBUG_HT(priv, "start Rx\n");
-                ret = iwl_sta_rx_agg_start(priv, sta, tid, *ssn);
-                break;
-        case IEEE80211_AMPDU_RX_STOP:
-                IWL_DEBUG_HT(priv, "stop Rx\n");
-                ret = iwl_sta_rx_agg_stop(priv, sta, tid);
-                if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status))
-                        ret = 0;
-                break;
-        case IEEE80211_AMPDU_TX_START:
-                IWL_DEBUG_HT(priv, "start Tx\n");
-                ret = iwlagn_tx_agg_start(priv, vif, sta, tid, ssn);
-                break;
-        case IEEE80211_AMPDU_TX_STOP:
-                IWL_DEBUG_HT(priv, "stop Tx\n");
-                ret = iwlagn_tx_agg_stop(priv, vif, sta, tid);
-                if ((ret == 0) && (priv->agg_tids_count > 0)) {
-                        priv->agg_tids_count--;
-                        IWL_DEBUG_HT(priv, "priv->agg_tids_count = %u\n",
-                                     priv->agg_tids_count);
-                }
-                if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status))
-                        ret = 0;
-                if (!priv->agg_tids_count && priv->cfg->ht_params &&
-                    priv->cfg->ht_params->use_rts_for_aggregation) {
-                        /*
-                         * switch off RTS/CTS if it was previously enabled
-                         */
-                        sta_priv->lq_sta.lq.general_params.flags &=
-                                ~LINK_QUAL_FLAGS_SET_STA_TLC_RTS_MSK;
-                        iwl_send_lq_cmd(priv, iwl_rxon_ctx_from_vif(vif),
-                                        &sta_priv->lq_sta.lq, CMD_ASYNC, false);
-                }
-                break;
-        case IEEE80211_AMPDU_TX_OPERATIONAL:
-                buf_size = min_t(int, buf_size, LINK_QUAL_AGG_FRAME_LIMIT_DEF);
-
-                iwl_trans_tx_agg_setup(trans(priv), ctx->ctxid, iwl_sta_id(sta),
-                                tid, buf_size);
-
-                /*
-                 * If the limit is 0, then it wasn't initialised yet,
-                 * use the default. We can do that since we take the
-                 * minimum below, and we don't want to go above our
-                 * default due to hardware restrictions.
-                 */
-                if (sta_priv->max_agg_bufsize == 0)
-                        sta_priv->max_agg_bufsize =
-                                LINK_QUAL_AGG_FRAME_LIMIT_DEF;
-
-                /*
-                 * Even though in theory the peer could have different
-                 * aggregation reorder buffer sizes for different sessions,
-                 * our ucode doesn't allow for that and has a global limit
-                 * for each station. Therefore, use the minimum of all the
-                 * aggregation sessions and our default value.
-                 */
-                sta_priv->max_agg_bufsize =
-                        min(sta_priv->max_agg_bufsize, buf_size);
-
-                if (priv->cfg->ht_params &&
-                    priv->cfg->ht_params->use_rts_for_aggregation) {
-                        /*
-                         * switch to RTS/CTS if it is the prefer protection
-                         * method for HT traffic
-                         */
-
-                        sta_priv->lq_sta.lq.general_params.flags |=
-                                LINK_QUAL_FLAGS_SET_STA_TLC_RTS_MSK;
-                }
-                priv->agg_tids_count++;
-                IWL_DEBUG_HT(priv, "priv->agg_tids_count = %u\n",
-                             priv->agg_tids_count);
-
-                sta_priv->lq_sta.lq.agg_params.agg_frame_cnt_limit =
-                        sta_priv->max_agg_bufsize;
-
-                iwl_send_lq_cmd(priv, iwl_rxon_ctx_from_vif(vif),
-                                &sta_priv->lq_sta.lq, CMD_ASYNC, false);
-
-                IWL_INFO(priv, "Tx aggregation enabled on ra = %pM tid = %d\n",
-                         sta->addr, tid);
-                ret = 0;
-                break;
-        }
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-        return ret;
-}
-
-static int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
-                              struct ieee80211_vif *vif,
-                              struct ieee80211_sta *sta)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
-        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
-        bool is_ap = vif->type == NL80211_IFTYPE_STATION;
-        int ret = 0;
-        u8 sta_id;
-
-        IWL_DEBUG_MAC80211(priv, "received request to add station %pM\n",
-                        sta->addr);
-        mutex_lock(&priv->shrd->mutex);
-        IWL_DEBUG_INFO(priv, "proceeding to add station %pM\n",
-                        sta->addr);
-        sta_priv->sta_id = IWL_INVALID_STATION;
-
-        atomic_set(&sta_priv->pending_frames, 0);
-        if (vif->type == NL80211_IFTYPE_AP)
-                sta_priv->client = true;
-
-        ret = iwl_add_station_common(priv, vif_priv->ctx, sta->addr,
-                                     is_ap, sta, &sta_id);
-        if (ret) {
-                IWL_ERR(priv, "Unable to add station %pM (%d)\n",
-                        sta->addr, ret);
-                /* Should we return success if return code is EEXIST ? */
-                goto out;
-        }
-
-        sta_priv->sta_id = sta_id;
-
-        /* Initialize rate scaling */
-        IWL_DEBUG_INFO(priv, "Initializing rate scaling for station %pM\n",
-                       sta->addr);
-        iwl_rs_rate_init(priv, sta, sta_id);
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return ret;
-}
-
-static void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
-                                struct ieee80211_channel_switch *ch_switch)
-{
-        struct iwl_priv *priv = hw->priv;
-        const struct iwl_channel_info *ch_info;
-        struct ieee80211_conf *conf = &hw->conf;
-        struct ieee80211_channel *channel = ch_switch->channel;
-        struct iwl_ht_config *ht_conf = &priv->current_ht_config;
-        /*
-         * MULTI-FIXME
-         * When we add support for multiple interfaces, we need to
-         * revisit this. The channel switch command in the device
-         * only affects the BSS context, but what does that really
-         * mean? And what if we get a CSA on the second interface?
-         * This needs a lot of work.
-         */
-        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
-        u16 ch;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        mutex_lock(&priv->shrd->mutex);
-
-        if (iwl_is_rfkill(priv->shrd))
-                goto out;
-
-        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status) ||
-            test_bit(STATUS_SCANNING, &priv->shrd->status) ||
-            test_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status))
-                goto out;
-
-        if (!iwl_is_associated_ctx(ctx))
-                goto out;
-
-        if (!priv->cfg->lib->set_channel_switch)
-                goto out;
-
-        ch = channel->hw_value;
-        if (le16_to_cpu(ctx->active.channel) == ch)
-                goto out;
-
-        ch_info = iwl_get_channel_info(priv, channel->band, ch);
-        if (!is_channel_valid(ch_info)) {
-                IWL_DEBUG_MAC80211(priv, "invalid channel\n");
-                goto out;
-        }
-
-        spin_lock_irq(&priv->shrd->lock);
-
-        priv->current_ht_config.smps = conf->smps_mode;
-
-        /* Configure HT40 channels */
-        ctx->ht.enabled = conf_is_ht(conf);
-        if (ctx->ht.enabled) {
-                if (conf_is_ht40_minus(conf)) {
-                        ctx->ht.extension_chan_offset =
-                                IEEE80211_HT_PARAM_CHA_SEC_BELOW;
-                        ctx->ht.is_40mhz = true;
-                } else if (conf_is_ht40_plus(conf)) {
-                        ctx->ht.extension_chan_offset =
-                                IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
-                        ctx->ht.is_40mhz = true;
-                } else {
-                        ctx->ht.extension_chan_offset =
-                                IEEE80211_HT_PARAM_CHA_SEC_NONE;
-                        ctx->ht.is_40mhz = false;
-                }
-        } else
-                ctx->ht.is_40mhz = false;
-
-        if ((le16_to_cpu(ctx->staging.channel) != ch))
-                ctx->staging.flags = 0;
-
-        iwl_set_rxon_channel(priv, channel, ctx);
-        iwl_set_rxon_ht(priv, ht_conf);
-        iwl_set_flags_for_band(priv, ctx, channel->band, ctx->vif);
-
-        spin_unlock_irq(&priv->shrd->lock);
-
-        iwl_set_rate(priv);
-        /*
-         * at this point, staging_rxon has the
-         * configuration for channel switch
-         */
-        set_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status);
-        priv->switch_channel = cpu_to_le16(ch);
-        if (priv->cfg->lib->set_channel_switch(priv, ch_switch)) {
-                clear_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status);
-                priv->switch_channel = 0;
-                ieee80211_chswitch_done(ctx->vif, false);
-        }
-
-out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
-
-static void iwlagn_configure_filter(struct ieee80211_hw *hw,
-                                    unsigned int changed_flags,
-                                    unsigned int *total_flags,
-                                    u64 multicast)
-{
-        struct iwl_priv *priv = hw->priv;
-        __le32 filter_or = 0, filter_nand = 0;
-        struct iwl_rxon_context *ctx;
-
-#define CHK(test, flag) do { \
-        if (*total_flags & (test))              \
-                filter_or |= (flag);            \
-        else                                    \
-                filter_nand |= (flag);          \
-        } while (0)
-
-        IWL_DEBUG_MAC80211(priv, "Enter: changed: 0x%x, total: 0x%x\n",
-                        changed_flags, *total_flags);
 
-        CHK(FIF_OTHER_BSS | FIF_PROMISC_IN_BSS, RXON_FILTER_PROMISC_MSK);
-        /* Setting _just_ RXON_FILTER_CTL2HOST_MSK causes FH errors */
-        CHK(FIF_CONTROL, RXON_FILTER_CTL2HOST_MSK | RXON_FILTER_PROMISC_MSK);
-        CHK(FIF_BCN_PRBRESP_PROMISC, RXON_FILTER_BCON_AWARE_MSK);
 
-#undef CHK
-
-        mutex_lock(&priv->shrd->mutex);
-
-        for_each_context(priv, ctx) {
-                ctx->staging.filter_flags &= ~filter_nand;
-                ctx->staging.filter_flags |= filter_or;
-
-                /*
-                 * Not committing directly because hardware can perform a scan,
-                 * but we'll eventually commit the filter flags change anyway.
-                 */
-        }
-
-        mutex_unlock(&priv->shrd->mutex);
-
-        /*
-         * Receiving all multicast frames is always enabled by the
-         * default flags setup in iwl_connection_init_rx_config()
-         * since we currently do not support programming multicast
-         * filters into the device.
-         */
-        *total_flags &= FIF_OTHER_BSS | FIF_ALLMULTI | FIF_PROMISC_IN_BSS |
-                        FIF_BCN_PRBRESP_PROMISC | FIF_CONTROL;
-}
-
-static void iwlagn_mac_flush(struct ieee80211_hw *hw, bool drop)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        mutex_lock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status)) {
-                IWL_DEBUG_TX(priv, "Aborting flush due to device shutdown\n");
-                goto done;
-        }
-        if (iwl_is_rfkill(priv->shrd)) {
-                IWL_DEBUG_TX(priv, "Aborting flush due to RF Kill\n");
-                goto done;
-        }
-
-        /*
-         * mac80211 will not push any more frames for transmit
-         * until the flush is completed
-         */
-        if (drop) {
-                IWL_DEBUG_MAC80211(priv, "send flush command\n");
-                if (iwlagn_txfifo_flush(priv, IWL_DROP_ALL)) {
-                        IWL_ERR(priv, "flush request fail\n");
-                        goto done;
-                }
-        }
-        IWL_DEBUG_MAC80211(priv, "wait transmit/flush all frames\n");
-        iwl_trans_wait_tx_queue_empty(trans(priv));
-done:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
 
 void iwlagn_disable_roc(struct iwl_priv *priv)
 {
@@ -2759,160 +1489,6 @@ static void iwlagn_disable_roc_work(struct work_struct *work)
         mutex_unlock(&priv->shrd->mutex);
 }
 
-static int iwlagn_mac_remain_on_channel(struct ieee80211_hw *hw,
-                                     struct ieee80211_channel *channel,
-                                     enum nl80211_channel_type channel_type,
-                                     int duration)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_PAN];
-        int err = 0;
-
-        if (!(priv->shrd->valid_contexts & BIT(IWL_RXON_CTX_PAN)))
-                return -EOPNOTSUPP;
-
-        if (!(ctx->interface_modes & BIT(NL80211_IFTYPE_P2P_CLIENT)))
-                return -EOPNOTSUPP;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        if (test_bit(STATUS_SCAN_HW, &priv->shrd->status)) {
-                err = -EBUSY;
-                goto out;
-        }
-
-        priv->hw_roc_channel = channel;
-        priv->hw_roc_chantype = channel_type;
-        priv->hw_roc_duration = duration;
-        priv->hw_roc_start_notified = false;
-        cancel_delayed_work(&priv->hw_roc_disable_work);
-
-        if (!ctx->is_active) {
-                ctx->is_active = true;
-                ctx->staging.dev_type = RXON_DEV_TYPE_P2P;
-                memcpy(ctx->staging.node_addr,
-                       priv->contexts[IWL_RXON_CTX_BSS].staging.node_addr,
-                       ETH_ALEN);
-                memcpy(ctx->staging.bssid_addr,
-                       priv->contexts[IWL_RXON_CTX_BSS].staging.node_addr,
-                       ETH_ALEN);
-                err = iwlagn_commit_rxon(priv, ctx);
-                if (err)
-                        goto out;
-                ctx->staging.filter_flags |= RXON_FILTER_ASSOC_MSK |
-                                             RXON_FILTER_PROMISC_MSK |
-                                             RXON_FILTER_CTL2HOST_MSK;
-
-                err = iwlagn_commit_rxon(priv, ctx);
-                if (err) {
-                        iwlagn_disable_roc(priv);
-                        goto out;
-                }
-                priv->hw_roc_setup = true;
-        }
-
-        err = iwl_scan_initiate(priv, ctx->vif, IWL_SCAN_ROC, channel->band);
-        if (err)
-                iwlagn_disable_roc(priv);
-
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return err;
-}
-
-static int iwlagn_mac_cancel_remain_on_channel(struct ieee80211_hw *hw)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        if (!(priv->shrd->valid_contexts & BIT(IWL_RXON_CTX_PAN)))
-                return -EOPNOTSUPP;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-        iwl_scan_cancel_timeout(priv, priv->hw_roc_duration);
-        iwlagn_disable_roc(priv);
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return 0;
-}
-
-static int iwlagn_mac_tx_sync(struct ieee80211_hw *hw,
-                              struct ieee80211_vif *vif,
-                              const u8 *bssid,
-                              enum ieee80211_tx_sync_type type)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
-        struct iwl_rxon_context *ctx = vif_priv->ctx;
-        int ret;
-        u8 sta_id;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        if (iwl_is_associated_ctx(ctx)) {
-                ret = 0;
-                goto out;
-        }
-
-        if (ctx->preauth_bssid || test_bit(STATUS_SCAN_HW, &priv->shrd->status)) {
-                ret = -EBUSY;
-                goto out;
-        }
-
-        ret = iwl_add_station_common(priv, ctx, bssid, true, NULL, &sta_id);
-        if (ret)
-                goto out;
-
-        if (WARN_ON(sta_id != ctx->ap_sta_id)) {
-                ret = -EIO;
-                goto out_remove_sta;
-        }
-
-        memcpy(ctx->bssid, bssid, ETH_ALEN);
-        ctx->preauth_bssid = true;
-
-        ret = iwlagn_commit_rxon(priv, ctx);
-
-        if (ret == 0)
-                goto out;
-
- out_remove_sta:
-        iwl_remove_station(priv, sta_id, bssid);
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return ret;
-}
-
-static void iwlagn_mac_finish_tx_sync(struct ieee80211_hw *hw,
-                                   struct ieee80211_vif *vif,
-                                   const u8 *bssid,
-                                   enum ieee80211_tx_sync_type type)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
-        struct iwl_rxon_context *ctx = vif_priv->ctx;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        if (iwl_is_associated_ctx(ctx))
-                goto out;
-
-        iwl_remove_station(priv, ctx->ap_sta_id, bssid);
-        ctx->preauth_bssid = false;
-        /* no need to commit */
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
-
 /*****************************************************************************
  *
  * driver setup and teardown
@@ -3062,81 +1638,13 @@ static void iwl_uninit_drv(struct iwl_priv *priv)
                 kmem_cache_destroy(priv->tx_cmd_pool);
         kfree(priv->scan_cmd);
         kfree(priv->beacon_cmd);
+        kfree(rcu_dereference_raw(priv->noa_data));
 #ifdef CONFIG_IWLWIFI_DEBUGFS
         kfree(priv->wowlan_sram);
 #endif
 }
 
-static void iwlagn_mac_rssi_callback(struct ieee80211_hw *hw,
-                           enum ieee80211_rssi_event rssi_event)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-        mutex_lock(&priv->shrd->mutex);
-
-        if (priv->cfg->bt_params &&
-                        priv->cfg->bt_params->advanced_bt_coexist) {
-                if (rssi_event == RSSI_EVENT_LOW)
-                        priv->bt_enable_pspoll = true;
-                else if (rssi_event == RSSI_EVENT_HIGH)
-                        priv->bt_enable_pspoll = false;
-
-                iwlagn_send_advance_bt_config(priv);
-        } else {
-                IWL_DEBUG_MAC80211(priv, "Advanced BT coex disabled,"
-                                "ignoring RSSI callback\n");
-        }
-
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-}
-
-static int iwlagn_mac_set_tim(struct ieee80211_hw *hw,
-                           struct ieee80211_sta *sta, bool set)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        queue_work(priv->shrd->workqueue, &priv->beacon_update);
 
-        return 0;
-}
-
-struct ieee80211_ops iwlagn_hw_ops = {
-        .tx = iwlagn_mac_tx,
-        .start = iwlagn_mac_start,
-        .stop = iwlagn_mac_stop,
-#ifdef CONFIG_PM_SLEEP
-        .suspend = iwlagn_mac_suspend,
-        .resume = iwlagn_mac_resume,
-#endif
-        .add_interface = iwlagn_mac_add_interface,
-        .remove_interface = iwlagn_mac_remove_interface,
-        .change_interface = iwlagn_mac_change_interface,
-        .config = iwlagn_mac_config,
-        .configure_filter = iwlagn_configure_filter,
-        .set_key = iwlagn_mac_set_key,
-        .update_tkip_key = iwlagn_mac_update_tkip_key,
-        .set_rekey_data = iwlagn_mac_set_rekey_data,
-        .conf_tx = iwlagn_mac_conf_tx,
-        .bss_info_changed = iwlagn_bss_info_changed,
-        .ampdu_action = iwlagn_mac_ampdu_action,
-        .hw_scan = iwlagn_mac_hw_scan,
-        .sta_notify = iwlagn_mac_sta_notify,
-        .sta_add = iwlagn_mac_sta_add,
-        .sta_remove = iwlagn_mac_sta_remove,
-        .channel_switch = iwlagn_mac_channel_switch,
-        .flush = iwlagn_mac_flush,
-        .tx_last_beacon = iwlagn_mac_tx_last_beacon,
-        .remain_on_channel = iwlagn_mac_remain_on_channel,
-        .cancel_remain_on_channel = iwlagn_mac_cancel_remain_on_channel,
-        .rssi_callback = iwlagn_mac_rssi_callback,
-        CFG80211_TESTMODE_CMD(iwlagn_mac_testmode_cmd)
-        CFG80211_TESTMODE_DUMP(iwlagn_mac_testmode_dump)
-        .tx_sync = iwlagn_mac_tx_sync,
-        .finish_tx_sync = iwlagn_mac_finish_tx_sync,
-        .set_tim = iwlagn_mac_set_tim,
-};
 
 static u32 iwl_hw_detect(struct iwl_priv *priv)
 {
@@ -3170,27 +1678,7 @@ static int iwl_set_hw_params(struct iwl_priv *priv)
         return priv->cfg->lib->set_hw_params(priv);
 }
 
-/* This function both allocates and initializes hw and priv. */
-static struct ieee80211_hw *iwl_alloc_all(struct iwl_cfg *cfg)
-{
-        struct iwl_priv *priv;
-        /* mac80211 allocates memory for this device instance, including
-         *   space for this driver's private structure */
-        struct ieee80211_hw *hw;
-
-        hw = ieee80211_alloc_hw(sizeof(struct iwl_priv), &iwlagn_hw_ops);
-        if (hw == NULL) {
-                pr_err("%s: Can not allocate network device\n",
-                       cfg->name);
-                goto out;
-        }
 
-        priv = hw->priv;
-        priv->hw = hw;
-
-out:
-        return hw;
-}
 
 int iwl_probe(struct iwl_bus *bus, const struct iwl_trans_ops *trans_ops,
                 struct iwl_cfg *cfg)
@@ -3204,8 +1692,9 @@ int iwl_probe(struct iwl_bus *bus, const struct iwl_trans_ops *trans_ops,
         /************************
          * 1. Allocating HW data
          ************************/
-        hw = iwl_alloc_all(cfg);
+        hw = iwl_alloc_all();
         if (!hw) {
+                pr_err("%s: Cannot allocate network device\n", cfg->name);
                 err = -ENOMEM;
                 goto out;
         }
@@ -3397,7 +1886,7 @@ void __devexit iwl_remove(struct iwl_priv * priv)
         /*This will stop the queues, move the device to low power state */
         iwl_trans_stop_device(trans(priv));
 
-        iwl_dealloc_ucode(priv);
+        iwl_dealloc_ucode(trans(priv));
 
         iwl_eeprom_free(priv);
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h
index 5b936ec1a541..5d8d2f445923 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.h
@@ -65,6 +65,12 @@
 
 #include "iwl-dev.h"
 
+struct iwlagn_ucode_capabilities {
+        u32 max_probe_length;
+        u32 standard_phy_calibration_size;
+        u32 flags;
+};
+
 extern struct ieee80211_ops iwlagn_hw_ops;
 
 int iwl_reset_ict(struct iwl_trans *trans);
@@ -77,6 +83,15 @@ static inline void iwl_set_calib_hdr(struct iwl_calib_hdr *hdr, u8 cmd)
         hdr->data_valid = 1;
 }
 
+void __iwl_down(struct iwl_priv *priv);
+void iwl_down(struct iwl_priv *priv);
+void iwlagn_prepare_restart(struct iwl_priv *priv);
+
+/* MAC80211 */
+struct ieee80211_hw *iwl_alloc_all(void);
+int iwlagn_mac_setup_register(struct iwl_priv *priv,
+                              struct iwlagn_ucode_capabilities *capa);
+
 /* RXON */
 int iwlagn_set_pan_params(struct iwl_priv *priv);
 int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx);
@@ -95,8 +110,7 @@ int iwlagn_send_bt_env(struct iwl_priv *priv, u8 action, u8 type);
 void iwlagn_send_prio_tbl(struct iwl_priv *priv);
 int iwlagn_run_init_ucode(struct iwl_priv *priv);
 int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
-                                 struct fw_img *image,
-                                 enum iwlagn_ucode_type ucode_type);
+                                 enum iwl_ucode_type ucode_type);
 
 /* lib */
 int iwlagn_send_tx_power(struct iwl_priv *priv);
@@ -105,6 +119,12 @@ u16 iwlagn_eeprom_calib_version(struct iwl_priv *priv);
 int iwlagn_txfifo_flush(struct iwl_priv *priv, u16 flush_control);
 void iwlagn_dev_txfifo_flush(struct iwl_priv *priv, u16 flush_control);
 int iwlagn_send_beacon_cmd(struct iwl_priv *priv);
+#ifdef CONFIG_PM_SLEEP
+int iwlagn_send_patterns(struct iwl_priv *priv,
+                         struct cfg80211_wowlan *wowlan);
+int iwlagn_suspend(struct iwl_priv *priv,
+                   struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan);
+#endif
 
 /* rx */
 int iwlagn_hwrate_to_mac80211_idx(u32 rate_n_flags, enum ieee80211_band band);
@@ -196,9 +216,6 @@ int iwl_add_station_common(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
                            struct ieee80211_sta *sta, u8 *sta_id_r);
 int iwl_remove_station(struct iwl_priv *priv, const u8 sta_id,
                        const u8 *addr);
-int iwlagn_mac_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
-                       struct ieee80211_sta *sta);
-
 u8 iwl_prep_station(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
                     const u8 *addr, bool is_ap, struct ieee80211_sta *sta);
 
@@ -316,10 +333,6 @@ void iwl_sta_modify_sleep_tx_count(struct iwl_priv *priv, int sta_id, int cnt);
 int iwl_update_bcast_station(struct iwl_priv *priv,
                              struct iwl_rxon_context *ctx);
 int iwl_update_bcast_stations(struct iwl_priv *priv);
-void iwlagn_mac_sta_notify(struct ieee80211_hw *hw,
-                           struct ieee80211_vif *vif,
-                           enum sta_notify_cmd cmd,
-                           struct ieee80211_sta *sta);
 
 /* rate */
 static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
diff --git a/drivers/net/wireless/iwlwifi/iwl-cfg.h b/drivers/net/wireless/iwlwifi/iwl-cfg.h
index 2a2dc4597ba1..e1d78257e4a9 100644
--- a/drivers/net/wireless/iwlwifi/iwl-cfg.h
+++ b/drivers/net/wireless/iwlwifi/iwl-cfg.h
@@ -101,17 +101,11 @@ extern struct iwl_cfg iwl100_bg_cfg;
 extern struct iwl_cfg iwl130_bgn_cfg;
 extern struct iwl_cfg iwl130_bg_cfg;
 extern struct iwl_cfg iwl2000_2bgn_cfg;
-extern struct iwl_cfg iwl2000_2bg_cfg;
 extern struct iwl_cfg iwl2000_2bgn_d_cfg;
 extern struct iwl_cfg iwl2030_2bgn_cfg;
-extern struct iwl_cfg iwl2030_2bg_cfg;
 extern struct iwl_cfg iwl6035_2agn_cfg;
-extern struct iwl_cfg iwl6035_2abg_cfg;
-extern struct iwl_cfg iwl6035_2bg_cfg;
-extern struct iwl_cfg iwl105_bg_cfg;
 extern struct iwl_cfg iwl105_bgn_cfg;
 extern struct iwl_cfg iwl105_bgn_d_cfg;
-extern struct iwl_cfg iwl135_bg_cfg;
 extern struct iwl_cfg iwl135_bgn_cfg;
 
 #endif /* __iwl_pci_h__ */
diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
index 69d5f85d11e2..f4eccf583775 100644
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
@@ -198,6 +198,7 @@ enum {
         REPLY_WOWLAN_TKIP_PARAMS = 0xe3,
         REPLY_WOWLAN_KEK_KCK_MATERIAL = 0xe4,
         REPLY_WOWLAN_GET_STATUS = 0xe5,
+        REPLY_D3_CONFIG = 0xd3,
 
         REPLY_MAX = 0xff
 };
@@ -3801,6 +3802,19 @@ struct iwl_bt_coex_prot_env_cmd {
 } __attribute__((packed));
 
 /*
+ * REPLY_D3_CONFIG
+ */
+enum iwlagn_d3_wakeup_filters {
+        IWLAGN_D3_WAKEUP_RFKILL         = BIT(0),
+        IWLAGN_D3_WAKEUP_SYSASSERT      = BIT(1),
+};
+
+struct iwlagn_d3_config_cmd {
+        __le32 min_sleep_time;
+        __le32 wakeup_flags;
+} __packed;
+
+/*
  * REPLY_WOWLAN_PATTERNS
  */
 #define IWLAGN_WOWLAN_MIN_PATTERN_LEN   16
@@ -3830,19 +3844,16 @@ enum iwlagn_wowlan_wakeup_filters {
         IWLAGN_WOWLAN_WAKEUP_BEACON_MISS        = BIT(2),
         IWLAGN_WOWLAN_WAKEUP_LINK_CHANGE        = BIT(3),
         IWLAGN_WOWLAN_WAKEUP_GTK_REKEY_FAIL     = BIT(4),
-        IWLAGN_WOWLAN_WAKEUP_RFKILL             = BIT(5),
-        IWLAGN_WOWLAN_WAKEUP_UCODE_ERROR        = BIT(6),
-        IWLAGN_WOWLAN_WAKEUP_EAP_IDENT_REQ      = BIT(7),
-        IWLAGN_WOWLAN_WAKEUP_4WAY_HANDSHAKE     = BIT(8),
-        IWLAGN_WOWLAN_WAKEUP_ALWAYS             = BIT(9),
-        IWLAGN_WOWLAN_WAKEUP_ENABLE_NET_DETECT  = BIT(10),
+        IWLAGN_WOWLAN_WAKEUP_EAP_IDENT_REQ      = BIT(5),
+        IWLAGN_WOWLAN_WAKEUP_4WAY_HANDSHAKE     = BIT(6),
+        IWLAGN_WOWLAN_WAKEUP_ALWAYS             = BIT(7),
+        IWLAGN_WOWLAN_WAKEUP_ENABLE_NET_DETECT  = BIT(8),
 };
 
 struct iwlagn_wowlan_wakeup_filter_cmd {
         __le32 enabled;
         __le16 non_qos_seq;
-        u8 min_sleep_seconds;
-        u8 reserved;
+        __le16 reserved;
         __le16 qos_seq[8];
 };
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index 001fdf140abb..f9e9170e977a 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -1120,229 +1120,8 @@ int iwl_send_statistics_request(struct iwl_priv *priv, u8 flags, bool clear)
                                         &statistics_cmd);
 }
 
-int iwlagn_mac_conf_tx(struct ieee80211_hw *hw,
-                    struct ieee80211_vif *vif, u16 queue,
-                    const struct ieee80211_tx_queue_params *params)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_rxon_context *ctx;
-        unsigned long flags;
-        int q;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        if (!iwl_is_ready_rf(priv->shrd)) {
-                IWL_DEBUG_MAC80211(priv, "leave - RF not ready\n");
-                return -EIO;
-        }
-
-        if (queue >= AC_NUM) {
-                IWL_DEBUG_MAC80211(priv, "leave - queue >= AC_NUM %d\n", queue);
-                return 0;
-        }
-
-        q = AC_NUM - 1 - queue;
-
-        spin_lock_irqsave(&priv->shrd->lock, flags);
-
-        /*
-         * MULTI-FIXME
-         * This may need to be done per interface in nl80211/cfg80211/mac80211.
-         */
-        for_each_context(priv, ctx) {
-                ctx->qos_data.def_qos_parm.ac[q].cw_min =
-                        cpu_to_le16(params->cw_min);
-                ctx->qos_data.def_qos_parm.ac[q].cw_max =
-                        cpu_to_le16(params->cw_max);
-                ctx->qos_data.def_qos_parm.ac[q].aifsn = params->aifs;
-                ctx->qos_data.def_qos_parm.ac[q].edca_txop =
-                                cpu_to_le16((params->txop * 32));
-
-                ctx->qos_data.def_qos_parm.ac[q].reserved1 = 0;
-        }
-
-        spin_unlock_irqrestore(&priv->shrd->lock, flags);
-
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-        return 0;
-}
-
-int iwlagn_mac_tx_last_beacon(struct ieee80211_hw *hw)
-{
-        struct iwl_priv *priv = hw->priv;
-
-        return priv->ibss_manager == IWL_IBSS_MANAGER;
-}
-
-static int iwl_set_mode(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
-{
-        iwl_connection_init_rx_config(priv, ctx);
-
-        iwlagn_set_rxon_chain(priv, ctx);
-
-        return iwlagn_commit_rxon(priv, ctx);
-}
-
-static int iwl_setup_interface(struct iwl_priv *priv,
-                               struct iwl_rxon_context *ctx)
-{
-        struct ieee80211_vif *vif = ctx->vif;
-        int err;
-
-        lockdep_assert_held(&priv->shrd->mutex);
-
-        /*
-         * This variable will be correct only when there's just
-         * a single context, but all code using it is for hardware
-         * that supports only one context.
-         */
-        priv->iw_mode = vif->type;
-
-        ctx->is_active = true;
-
-        err = iwl_set_mode(priv, ctx);
-        if (err) {
-                if (!ctx->always_active)
-                        ctx->is_active = false;
-                return err;
-        }
-
-        if (priv->cfg->bt_params && priv->cfg->bt_params->advanced_bt_coexist &&
-            vif->type == NL80211_IFTYPE_ADHOC) {
-                /*
-                 * pretend to have high BT traffic as long as we
-                 * are operating in IBSS mode, as this will cause
-                 * the rate scaling etc. to behave as intended.
-                 */
-                priv->bt_traffic_load = IWL_BT_COEX_TRAFFIC_LOAD_HIGH;
-        }
-
-        return 0;
-}
-
-int iwlagn_mac_add_interface(struct ieee80211_hw *hw,
-                             struct ieee80211_vif *vif)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
-        struct iwl_rxon_context *tmp, *ctx = NULL;
-        int err;
-        enum nl80211_iftype viftype = ieee80211_vif_type_p2p(vif);
-
-        IWL_DEBUG_MAC80211(priv, "enter: type %d, addr %pM\n",
-                           viftype, vif->addr);
-
-        cancel_delayed_work_sync(&priv->hw_roc_disable_work);
-
-        mutex_lock(&priv->shrd->mutex);
-
-        iwlagn_disable_roc(priv);
-
-        if (!iwl_is_ready_rf(priv->shrd)) {
-                IWL_WARN(priv, "Try to add interface when device not ready\n");
-                err = -EINVAL;
-                goto out;
-        }
-
-        for_each_context(priv, tmp) {
-                u32 possible_modes =
-                        tmp->interface_modes | tmp->exclusive_interface_modes;
-
-                if (tmp->vif) {
-                        /* check if this busy context is exclusive */
-                        if (tmp->exclusive_interface_modes &
-                                                BIT(tmp->vif->type)) {
-                                err = -EINVAL;
-                                goto out;
-                        }
-                        continue;
-                }
-
-                if (!(possible_modes & BIT(viftype)))
-                        continue;
 
-                /* have maybe usable context w/o interface */
-                ctx = tmp;
-                break;
-        }
-
-        if (!ctx) {
-                err = -EOPNOTSUPP;
-                goto out;
-        }
-
-        vif_priv->ctx = ctx;
-        ctx->vif = vif;
-
-        err = iwl_setup_interface(priv, ctx);
-        if (!err)
-                goto out;
 
-        ctx->vif = NULL;
-        priv->iw_mode = NL80211_IFTYPE_STATION;
- out:
-        mutex_unlock(&priv->shrd->mutex);
-
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-        return err;
-}
-
-static void iwl_teardown_interface(struct iwl_priv *priv,
-                                   struct ieee80211_vif *vif,
-                                   bool mode_change)
-{
-        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
-
-        lockdep_assert_held(&priv->shrd->mutex);
-
-        if (priv->scan_vif == vif) {
-                iwl_scan_cancel_timeout(priv, 200);
-                iwl_force_scan_end(priv);
-        }
-
-        if (!mode_change) {
-                iwl_set_mode(priv, ctx);
-                if (!ctx->always_active)
-                        ctx->is_active = false;
-        }
-
-        /*
-         * When removing the IBSS interface, overwrite the
-         * BT traffic load with the stored one from the last
-         * notification, if any. If this is a device that
-         * doesn't implement this, this has no effect since
-         * both values are the same and zero.
-         */
-        if (vif->type == NL80211_IFTYPE_ADHOC)
-                priv->bt_traffic_load = priv->last_bt_traffic_load;
-}
-
-void iwlagn_mac_remove_interface(struct ieee80211_hw *hw,
-                              struct ieee80211_vif *vif)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        mutex_lock(&priv->shrd->mutex);
-
-        if (WARN_ON(ctx->vif != vif)) {
-                struct iwl_rxon_context *tmp;
-                IWL_ERR(priv, "ctx->vif = %p, vif = %p\n", ctx->vif, vif);
-                for_each_context(priv, tmp)
-                        IWL_ERR(priv, "\tID = %d:\tctx = %p\tctx->vif = %p\n",
-                                tmp->ctxid, tmp, tmp->vif);
-        }
-        ctx->vif = NULL;
-
-        iwl_teardown_interface(priv, vif, false);
-
-        mutex_unlock(&priv->shrd->mutex);
-
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-}
 
 #ifdef CONFIG_IWLWIFI_DEBUGFS
 
@@ -1649,97 +1428,13 @@ int iwl_force_reset(struct iwl_priv *priv, int mode, bool external)
         return 0;
 }
 
-int iwlagn_mac_change_interface(struct ieee80211_hw *hw,
-                                struct ieee80211_vif *vif,
-                                enum nl80211_iftype newtype, bool newp2p)
-{
-        struct iwl_priv *priv = hw->priv;
-        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
-        struct iwl_rxon_context *bss_ctx = &priv->contexts[IWL_RXON_CTX_BSS];
-        struct iwl_rxon_context *tmp;
-        enum nl80211_iftype newviftype = newtype;
-        u32 interface_modes;
-        int err;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        newtype = ieee80211_iftype_p2p(newtype, newp2p);
-
-        mutex_lock(&priv->shrd->mutex);
-
-        if (!ctx->vif || !iwl_is_ready_rf(priv->shrd)) {
-                /*
-                 * Huh? But wait ... this can maybe happen when
-                 * we're in the middle of a firmware restart!
-                 */
-                err = -EBUSY;
-                goto out;
-        }
-
-        interface_modes = ctx->interface_modes | ctx->exclusive_interface_modes;
-
-        if (!(interface_modes & BIT(newtype))) {
-                err = -EBUSY;
-                goto out;
-        }
-
-        /*
-         * Refuse a change that should be done by moving from the PAN
-         * context to the BSS context instead, if the BSS context is
-         * available and can support the new interface type.
-         */
-        if (ctx->ctxid == IWL_RXON_CTX_PAN && !bss_ctx->vif &&
-            (bss_ctx->interface_modes & BIT(newtype) ||
-             bss_ctx->exclusive_interface_modes & BIT(newtype))) {
-                BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
-                err = -EBUSY;
-                goto out;
-        }
-
-        if (ctx->exclusive_interface_modes & BIT(newtype)) {
-                for_each_context(priv, tmp) {
-                        if (ctx == tmp)
-                                continue;
-
-                        if (!tmp->vif)
-                                continue;
-
-                        /*
-                         * The current mode switch would be exclusive, but
-                         * another context is active ... refuse the switch.
-                         */
-                        err = -EBUSY;
-                        goto out;
-                }
-        }
-
-        /* success */
-        iwl_teardown_interface(priv, vif, true);
-        vif->type = newviftype;
-        vif->p2p = newp2p;
-        err = iwl_setup_interface(priv, ctx);
-        WARN_ON(err);
-        /*
-         * We've switched internally, but submitting to the
-         * device may have failed for some reason. Mask this
-         * error, because otherwise mac80211 will not switch
-         * (and set the interface type back) and we'll be
-         * out of sync with it.
-         */
-        err = 0;
-
- out:
-        mutex_unlock(&priv->shrd->mutex);
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        return err;
-}
 
 int iwl_cmd_echo_test(struct iwl_priv *priv)
 {
         int ret;
         struct iwl_host_cmd cmd = {
                 .id = REPLY_ECHO,
+                .len = { 0 },
                 .flags = CMD_SYNC,
         };
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.h b/drivers/net/wireless/iwlwifi/iwl-core.h
index 137da3380704..fa47f75185df 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.h
+++ b/drivers/net/wireless/iwlwifi/iwl-core.h
@@ -237,10 +237,6 @@ struct iwl_cfg {
  *   L i b                 *
  ***************************/
 
-int iwlagn_mac_conf_tx(struct ieee80211_hw *hw,
-                    struct ieee80211_vif *vif, u16 queue,
-                    const struct ieee80211_tx_queue_params *params);
-int iwlagn_mac_tx_last_beacon(struct ieee80211_hw *hw);
 void iwl_set_rxon_hwcrypto(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
                            int hw_decrypt);
 int iwl_check_rxon_cmd(struct iwl_priv *priv, struct iwl_rxon_context *ctx);
@@ -260,13 +256,6 @@ bool iwl_is_ht40_tx_allowed(struct iwl_priv *priv,
 void iwl_connection_init_rx_config(struct iwl_priv *priv,
                                    struct iwl_rxon_context *ctx);
 void iwl_set_rate(struct iwl_priv *priv);
-int iwlagn_mac_add_interface(struct ieee80211_hw *hw,
-                          struct ieee80211_vif *vif);
-void iwlagn_mac_remove_interface(struct ieee80211_hw *hw,
-                              struct ieee80211_vif *vif);
-int iwlagn_mac_change_interface(struct ieee80211_hw *hw,
-                             struct ieee80211_vif *vif,
-                             enum nl80211_iftype newtype, bool newp2p);
 int iwl_cmd_echo_test(struct iwl_priv *priv);
 #ifdef CONFIG_IWLWIFI_DEBUGFS
 int iwl_alloc_traffic_mem(struct iwl_priv *priv);
@@ -323,9 +312,6 @@ void iwl_init_scan_params(struct iwl_priv *priv);
 int iwl_scan_cancel(struct iwl_priv *priv);
 void iwl_scan_cancel_timeout(struct iwl_priv *priv, unsigned long ms);
 void iwl_force_scan_end(struct iwl_priv *priv);
-int iwlagn_mac_hw_scan(struct ieee80211_hw *hw,
-                    struct ieee80211_vif *vif,
-                    struct cfg80211_scan_request *req);
 void iwl_internal_short_hw_scan(struct iwl_priv *priv);
 int iwl_force_reset(struct iwl_priv *priv, int mode, bool external);
 u16 iwl_fill_probe_req(struct iwl_priv *priv, struct ieee80211_mgmt *frame,
diff --git a/drivers/net/wireless/iwlwifi/iwl-csr.h b/drivers/net/wireless/iwlwifi/iwl-csr.h
index b9f3267e720c..fbc3095c7b44 100644
--- a/drivers/net/wireless/iwlwifi/iwl-csr.h
+++ b/drivers/net/wireless/iwlwifi/iwl-csr.h
@@ -284,8 +284,8 @@
 #define CSR_HW_REV_TYPE_6x35           CSR_HW_REV_TYPE_6x05
 #define CSR_HW_REV_TYPE_2x30           (0x00000C0)
 #define CSR_HW_REV_TYPE_2x00           (0x0000100)
-#define CSR_HW_REV_TYPE_200            (0x0000110)
-#define CSR_HW_REV_TYPE_230            (0x0000120)
+#define CSR_HW_REV_TYPE_105            (0x0000110)
+#define CSR_HW_REV_TYPE_135            (0x0000120)
 #define CSR_HW_REV_TYPE_NONE           (0x00001F0)
 
 /* EEPROM REG */
diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index 69a77e24d229..40ef97bac1aa 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -70,10 +70,25 @@ do {                                            			\
                                DUMP_PREFIX_OFFSET, 16, 1, p, len, 1);   \
 } while (0)
 
+#define IWL_DEBUG_QUIET_RFKILL(p, fmt, args...)                 \
+do {                                                                    \
+        if (!iwl_is_rfkill(p->shrd))                            \
+                dev_printk(KERN_ERR, bus(p)->dev, "%c %s " fmt, \
+                (in_interrupt() ? 'I' : 'U'), __func__ , ##args);       \
+        else if (iwl_get_debug_level(p->shrd) & IWL_DL_RADIO)   \
+                dev_printk(KERN_ERR, bus(p)->dev, "(RFKILL) %c %s " fmt, \
+                (in_interrupt() ? 'I' : 'U'), __func__ , ##args);       \
+} while (0)
+
 #else
 #define IWL_DEBUG(m, level, fmt, args...)
 #define IWL_DEBUG_LIMIT(m, level, fmt, args...)
 #define iwl_print_hex_dump(m, level, p, len)
+#define IWL_DEBUG_QUIET_RFKILL(p, fmt, args...) \
+do {                                                    \
+        if (!iwl_is_rfkill(p->shrd))                    \
+                IWL_ERR(p, fmt, ##args);                \
+} while (0)
 #endif                          /* CONFIG_IWLWIFI_DEBUG */
 
 #ifdef CONFIG_IWLWIFI_DEBUGFS
@@ -151,7 +166,7 @@ static inline void iwl_dbgfs_unregister(struct iwl_priv *priv)
 #define IWL_DL_11H              (1 << 28)
 #define IWL_DL_STATS            (1 << 29)
 #define IWL_DL_TX_REPLY         (1 << 30)
-#define IWL_DL_QOS              (1 << 31)
+#define IWL_DL_TX_QUEUES        (1 << 31)
 
 #define IWL_DEBUG_INFO(p, f, a...)      IWL_DEBUG(p, IWL_DL_INFO, f, ## a)
 #define IWL_DEBUG_MAC80211(p, f, a...)  IWL_DEBUG(p, IWL_DL_MAC80211, f, ## a)
@@ -188,7 +203,7 @@ static inline void iwl_dbgfs_unregister(struct iwl_priv *priv)
 #define IWL_DEBUG_TX_REPLY(p, f, a...)  IWL_DEBUG(p, IWL_DL_TX_REPLY, f, ## a)
 #define IWL_DEBUG_TX_REPLY_LIMIT(p, f, a...) \
                 IWL_DEBUG_LIMIT(p, IWL_DL_TX_REPLY, f, ## a)
-#define IWL_DEBUG_QOS(p, f, a...)       IWL_DEBUG(p, IWL_DL_QOS, f, ## a)
+#define IWL_DEBUG_TX_QUEUES(p, f, a...) IWL_DEBUG(p, IWL_DL_TX_QUEUES, f, ## a)
 #define IWL_DEBUG_RADIO(p, f, a...)     IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
 #define IWL_DEBUG_POWER(p, f, a...)     IWL_DEBUG(p, IWL_DL_POWER, f, ## a)
 #define IWL_DEBUG_11H(p, f, a...)       IWL_DEBUG(p, IWL_DL_11H, f, ## a)
diff --git a/drivers/net/wireless/iwlwifi/iwl-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
index a1670e3f8bfa..68b04f5b10ce 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debugfs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
@@ -236,9 +236,9 @@ static ssize_t iwl_dbgfs_sram_read(struct file *file,
         if (!priv->dbgfs_sram_offset && !priv->dbgfs_sram_len) {
                 priv->dbgfs_sram_offset = 0x800000;
                 if (priv->ucode_type == IWL_UCODE_INIT)
-                        priv->dbgfs_sram_len = priv->ucode_init.data.len;
+                        priv->dbgfs_sram_len = trans(priv)->ucode_init.data.len;
                 else
-                        priv->dbgfs_sram_len = priv->ucode_rt.data.len;
+                        priv->dbgfs_sram_len = trans(priv)->ucode_rt.data.len;
         }
         len = priv->dbgfs_sram_len;
 
@@ -341,7 +341,7 @@ static ssize_t iwl_dbgfs_wowlan_sram_read(struct file *file,
 
         return simple_read_from_buffer(user_buf, count, ppos,
                                        priv->wowlan_sram,
-                                       priv->ucode_wowlan.data.len);
+                                       trans(priv)->ucode_wowlan.data.len);
 }
 static ssize_t iwl_dbgfs_stations_read(struct file *file, char __user *user_buf,
                                         size_t count, loff_t *ppos)
@@ -430,7 +430,7 @@ static ssize_t iwl_dbgfs_nvm_read(struct file *file,
         eeprom_ver = iwl_eeprom_query16(priv, EEPROM_VERSION);
         pos += scnprintf(buf + pos, buf_size - pos, "NVM Type: %s, "
                         "version: 0x%x\n",
-                        (priv->nvm_device_type == NVM_DEVICE_TYPE_OTP)
+                        (trans(priv)->nvm_device_type == NVM_DEVICE_TYPE_OTP)
                          ? "OTP" : "EEPROM", eeprom_ver);
         for (ofs = 0 ; ofs < eeprom_len ; ofs += 16) {
                 pos += scnprintf(buf + pos, buf_size - pos, "0x%.4x ", ofs);
diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h
index 6c00a447963d..556e4a2c19bc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-dev.h
+++ b/drivers/net/wireless/iwlwifi/iwl-dev.h
@@ -230,17 +230,6 @@ struct iwl_vif_priv {
         u8 ibss_bssid_sta_id;
 };
 
-/* one for each uCode image (inst/data, boot/init/runtime) */
-struct fw_desc {
-        void *v_addr;           /* access by driver */
-        dma_addr_t p_addr;      /* access by card's busmaster DMA */
-        u32 len;                /* bytes */
-};
-
-struct fw_img {
-        struct fw_desc code, data;
-};
-
 /* v1/v2 uCode file layout */
 struct iwl_ucode_header {
         __le32 ver;     /* major/minor/API/serial */
@@ -805,13 +794,6 @@ enum iwl_scan_type {
         IWL_SCAN_ROC,
 };
 
-enum iwlagn_ucode_type {
-        IWL_UCODE_NONE,
-        IWL_UCODE_REGULAR,
-        IWL_UCODE_INIT,
-        IWL_UCODE_WOWLAN,
-};
-
 #ifdef CONFIG_IWLWIFI_DEVICE_SVTOOL
 struct iwl_testmode_trace {
         u32 buff_size;
@@ -824,6 +806,12 @@ struct iwl_testmode_trace {
 };
 #endif
 
+struct iwl_wipan_noa_data {
+        struct rcu_head rcu_head;
+        u32 length;
+        u8 data[];
+};
+
 struct iwl_priv {
 
         /*data shared among all the driver's layers */
@@ -883,6 +871,8 @@ struct iwl_priv {
         /* init calibration results */
         struct iwl_calib_result calib_results[IWL_CALIB_MAX];
 
+        struct iwl_wipan_noa_data __rcu *noa_data;
+
         /* Scan related variables */
         unsigned long scan_start;
         unsigned long scan_start_tsf;
@@ -907,12 +897,7 @@ struct iwl_priv {
         u32 ucode_ver;                  /* version of ucode, copy of
                                            iwl_ucode.ver */
 
-        struct fw_img ucode_rt;
-        struct fw_img ucode_init;
-        struct fw_img ucode_wowlan;
-
-        enum iwlagn_ucode_type ucode_type;
-        u8 ucode_write_complete;        /* the image write is complete */
+        enum iwl_ucode_type ucode_type;
         char firmware_name[25];
 
         struct iwl_rxon_context contexts[NUM_IWL_RXON_CTX];
@@ -959,7 +944,6 @@ struct iwl_priv {
 
         /* eeprom -- this is in the card's little endian byte order */
         u8 *eeprom;
-        int    nvm_device_type;
         struct iwl_eeprom_calib_info *calib_info;
 
         enum nl80211_iftype iw_mode;
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.c b/drivers/net/wireless/iwlwifi/iwl-devtrace.c
index a635a7e75447..2a2c8de64a04 100644
--- a/drivers/net/wireless/iwlwifi/iwl-devtrace.c
+++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.c
@@ -28,7 +28,7 @@
 
 /* sparse doesn't like tracepoint macros */
 #ifndef __CHECKER__
-#include "iwl-dev.h"
+#include "iwl-trans.h"
 
 #define CREATE_TRACE_POINTS
 #include "iwl-devtrace.h"
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.h b/drivers/net/wireless/iwlwifi/iwl-devtrace.h
index 8a51c5ccda1e..f9d3319ecad5 100644
--- a/drivers/net/wireless/iwlwifi/iwl-devtrace.h
+++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.h
@@ -29,7 +29,6 @@
 
 #include <linux/tracepoint.h>
 
-struct iwl_priv;
 
 #if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__)
 #undef TRACE_EVENT
@@ -37,14 +36,14 @@ struct iwl_priv;
 static inline void trace_ ## name(proto) {}
 #endif
 
-#define PRIV_ENTRY      __field(struct iwl_priv *, priv)
+#define PRIV_ENTRY      __field(void *, priv)
 #define PRIV_ASSIGN     __entry->priv = priv
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM iwlwifi_io
 
 TRACE_EVENT(iwlwifi_dev_ioread32,
-        TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val),
+        TP_PROTO(void *priv, u32 offs, u32 val),
         TP_ARGS(priv, offs, val),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -60,7 +59,7 @@ TRACE_EVENT(iwlwifi_dev_ioread32,
 );
 
 TRACE_EVENT(iwlwifi_dev_iowrite8,
-        TP_PROTO(struct iwl_priv *priv, u32 offs, u8 val),
+        TP_PROTO(void *priv, u32 offs, u8 val),
         TP_ARGS(priv, offs, val),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -76,7 +75,7 @@ TRACE_EVENT(iwlwifi_dev_iowrite8,
 );
 
 TRACE_EVENT(iwlwifi_dev_iowrite32,
-        TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val),
+        TP_PROTO(void *priv, u32 offs, u32 val),
         TP_ARGS(priv, offs, val),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -95,7 +94,7 @@ TRACE_EVENT(iwlwifi_dev_iowrite32,
 #define TRACE_SYSTEM iwlwifi_ucode
 
 TRACE_EVENT(iwlwifi_dev_ucode_cont_event,
-        TP_PROTO(struct iwl_priv *priv, u32 time, u32 data, u32 ev),
+        TP_PROTO(void *priv, u32 time, u32 data, u32 ev),
         TP_ARGS(priv, time, data, ev),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -115,7 +114,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_cont_event,
 );
 
 TRACE_EVENT(iwlwifi_dev_ucode_wrap_event,
-        TP_PROTO(struct iwl_priv *priv, u32 wraps, u32 n_entry, u32 p_entry),
+        TP_PROTO(void *priv, u32 wraps, u32 n_entry, u32 p_entry),
         TP_ARGS(priv, wraps, n_entry, p_entry),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -139,7 +138,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_wrap_event,
 #define TRACE_SYSTEM iwlwifi
 
 TRACE_EVENT(iwlwifi_dev_hcmd,
-        TP_PROTO(struct iwl_priv *priv, u32 flags,
+        TP_PROTO(void *priv, u32 flags,
                  const void *hcmd0, size_t len0,
                  const void *hcmd1, size_t len1,
                  const void *hcmd2, size_t len2),
@@ -164,7 +163,7 @@ TRACE_EVENT(iwlwifi_dev_hcmd,
 );
 
 TRACE_EVENT(iwlwifi_dev_rx,
-        TP_PROTO(struct iwl_priv *priv, void *rxbuf, size_t len),
+        TP_PROTO(void *priv, void *rxbuf, size_t len),
         TP_ARGS(priv, rxbuf, len),
         TP_STRUCT__entry(
                 PRIV_ENTRY
@@ -179,7 +178,7 @@ TRACE_EVENT(iwlwifi_dev_rx,
 );
 
 TRACE_EVENT(iwlwifi_dev_tx,
-        TP_PROTO(struct iwl_priv *priv, void *tfd, size_t tfdlen,
+        TP_PROTO(void *priv, void *tfd, size_t tfdlen,
                  void *buf0, size_t buf0_len,
                  void *buf1, size_t buf1_len),
         TP_ARGS(priv, tfd, tfdlen, buf0, buf0_len, buf1, buf1_len),
@@ -211,7 +210,7 @@ TRACE_EVENT(iwlwifi_dev_tx,
 );
 
 TRACE_EVENT(iwlwifi_dev_ucode_error,
-        TP_PROTO(struct iwl_priv *priv, u32 desc, u32 tsf_low,
+        TP_PROTO(void *priv, u32 desc, u32 tsf_low,
                  u32 data1, u32 data2, u32 line, u32 blink1,
                  u32 blink2, u32 ilink1, u32 ilink2, u32 bcon_time,
                  u32 gp1, u32 gp2, u32 gp3, u32 ucode_ver, u32 hw_ver,
@@ -271,7 +270,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_error,
 );
 
 TRACE_EVENT(iwlwifi_dev_ucode_event,
-        TP_PROTO(struct iwl_priv *priv, u32 time, u32 data, u32 ev),
+        TP_PROTO(void *priv, u32 time, u32 data, u32 ev),
         TP_ARGS(priv, time, data, ev),
         TP_STRUCT__entry(
                 PRIV_ENTRY
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.c b/drivers/net/wireless/iwlwifi/iwl-eeprom.c
index a4e43bd4a547..dcada0827ea4 100644
--- a/drivers/net/wireless/iwlwifi/iwl-eeprom.c
+++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.c
@@ -149,23 +149,23 @@ static const u8 iwl_eeprom_band_7[] = {       /* 5.2 ht40 channel */
  * EEPROM chip, not a single event, so even reads could conflict if they
  * weren't arbitrated by the semaphore.
  */
-static int iwl_eeprom_acquire_semaphore(struct iwl_priv *priv)
+static int iwl_eeprom_acquire_semaphore(struct iwl_bus *bus)
 {
         u16 count;
         int ret;
 
         for (count = 0; count < EEPROM_SEM_RETRY_LIMIT; count++) {
                 /* Request semaphore */
-                iwl_set_bit(bus(priv), CSR_HW_IF_CONFIG_REG,
+                iwl_set_bit(bus, CSR_HW_IF_CONFIG_REG,
                             CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
 
                 /* See if we got it */
-                ret = iwl_poll_bit(bus(priv), CSR_HW_IF_CONFIG_REG,
+                ret = iwl_poll_bit(bus, CSR_HW_IF_CONFIG_REG,
                                 CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
                                 CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
                                 EEPROM_SEM_TIMEOUT);
                 if (ret >= 0) {
-                        IWL_DEBUG_EEPROM(priv,
+                        IWL_DEBUG_EEPROM(bus,
                                 "Acquired semaphore after %d tries.\n",
                                 count+1);
                         return ret;
@@ -175,39 +175,39 @@ static int iwl_eeprom_acquire_semaphore(struct iwl_priv *priv)
         return ret;
 }
 
-static void iwl_eeprom_release_semaphore(struct iwl_priv *priv)
+static void iwl_eeprom_release_semaphore(struct iwl_bus *bus)
 {
-        iwl_clear_bit(bus(priv), CSR_HW_IF_CONFIG_REG,
+        iwl_clear_bit(bus, CSR_HW_IF_CONFIG_REG,
                 CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
 
 }
 
-static int iwl_eeprom_verify_signature(struct iwl_priv *priv)
+static int iwl_eeprom_verify_signature(struct iwl_trans *trans)
 {
-        u32 gp = iwl_read32(bus(priv), CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK;
+        u32 gp = iwl_read32(bus(trans), CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK;
         int ret = 0;
 
-        IWL_DEBUG_EEPROM(priv, "EEPROM signature=0x%08x\n", gp);
+        IWL_DEBUG_EEPROM(trans, "EEPROM signature=0x%08x\n", gp);
         switch (gp) {
         case CSR_EEPROM_GP_BAD_SIG_EEP_GOOD_SIG_OTP:
-                if (priv->nvm_device_type != NVM_DEVICE_TYPE_OTP) {
-                        IWL_ERR(priv, "EEPROM with bad signature: 0x%08x\n",
+                if (trans->nvm_device_type != NVM_DEVICE_TYPE_OTP) {
+                        IWL_ERR(trans, "EEPROM with bad signature: 0x%08x\n",
                                 gp);
                         ret = -ENOENT;
                 }
                 break;
         case CSR_EEPROM_GP_GOOD_SIG_EEP_LESS_THAN_4K:
         case CSR_EEPROM_GP_GOOD_SIG_EEP_MORE_THAN_4K:
-                if (priv->nvm_device_type != NVM_DEVICE_TYPE_EEPROM) {
-                        IWL_ERR(priv, "OTP with bad signature: 0x%08x\n", gp);
+                if (trans->nvm_device_type != NVM_DEVICE_TYPE_EEPROM) {
+                        IWL_ERR(trans, "OTP with bad signature: 0x%08x\n", gp);
                         ret = -ENOENT;
                 }
                 break;
         case CSR_EEPROM_GP_BAD_SIGNATURE_BOTH_EEP_AND_OTP:
         default:
-                IWL_ERR(priv, "bad EEPROM/OTP signature, type=%s, "
+                IWL_ERR(trans, "bad EEPROM/OTP signature, type=%s, "
                         "EEPROM_GP=0x%08x\n",
-                        (priv->nvm_device_type == NVM_DEVICE_TYPE_OTP)
+                        (trans->nvm_device_type == NVM_DEVICE_TYPE_OTP)
                         ? "OTP" : "EEPROM", gp);
                 ret = -ENOENT;
                 break;
@@ -302,19 +302,19 @@ void iwl_eeprom_get_mac(const struct iwl_priv *priv, u8 *mac)
  *
 ******************************************************************************/
 
-static void iwl_set_otp_access(struct iwl_priv *priv, enum iwl_access_mode mode)
+static void iwl_set_otp_access(struct iwl_bus *bus, enum iwl_access_mode mode)
 {
-        iwl_read32(bus(priv), CSR_OTP_GP_REG);
+        iwl_read32(bus, CSR_OTP_GP_REG);
 
         if (mode == IWL_OTP_ACCESS_ABSOLUTE)
-                iwl_clear_bit(bus(priv), CSR_OTP_GP_REG,
+                iwl_clear_bit(bus, CSR_OTP_GP_REG,
                               CSR_OTP_GP_REG_OTP_ACCESS_MODE);
         else
-                iwl_set_bit(bus(priv), CSR_OTP_GP_REG,
+                iwl_set_bit(bus, CSR_OTP_GP_REG,
                             CSR_OTP_GP_REG_OTP_ACCESS_MODE);
 }
 
-static int iwl_get_nvm_type(struct iwl_priv *priv, u32 hw_rev)
+static int iwl_get_nvm_type(struct iwl_bus *bus, u32 hw_rev)
 {
         u32 otpgp;
         int nvm_type;
@@ -322,7 +322,7 @@ static int iwl_get_nvm_type(struct iwl_priv *priv, u32 hw_rev)
         /* OTP only valid for CP/PP and after */
         switch (hw_rev & CSR_HW_REV_TYPE_MSK) {
         case CSR_HW_REV_TYPE_NONE:
-                IWL_ERR(priv, "Unknown hardware type\n");
+                IWL_ERR(bus, "Unknown hardware type\n");
                 return -ENOENT;
         case CSR_HW_REV_TYPE_5300:
         case CSR_HW_REV_TYPE_5350:
@@ -331,7 +331,7 @@ static int iwl_get_nvm_type(struct iwl_priv *priv, u32 hw_rev)
                 nvm_type = NVM_DEVICE_TYPE_EEPROM;
                 break;
         default:
-                otpgp = iwl_read32(bus(priv), CSR_OTP_GP_REG);
+                otpgp = iwl_read32(bus, CSR_OTP_GP_REG);
                 if (otpgp & CSR_OTP_GP_REG_DEVICE_SELECT)
                         nvm_type = NVM_DEVICE_TYPE_OTP;
                 else
@@ -341,73 +341,73 @@ static int iwl_get_nvm_type(struct iwl_priv *priv, u32 hw_rev)
         return  nvm_type;
 }
 
-static int iwl_init_otp_access(struct iwl_priv *priv)
+static int iwl_init_otp_access(struct iwl_bus *bus)
 {
         int ret;
 
         /* Enable 40MHz radio clock */
-        iwl_write32(bus(priv), CSR_GP_CNTRL,
-                    iwl_read32(bus(priv), CSR_GP_CNTRL) |
+        iwl_write32(bus, CSR_GP_CNTRL,
+                    iwl_read32(bus, CSR_GP_CNTRL) |
                     CSR_GP_CNTRL_REG_FLAG_INIT_DONE);
 
         /* wait for clock to be ready */
-        ret = iwl_poll_bit(bus(priv), CSR_GP_CNTRL,
+        ret = iwl_poll_bit(bus, CSR_GP_CNTRL,
                                  CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
                                  CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
                                  25000);
         if (ret < 0)
-                IWL_ERR(priv, "Time out access OTP\n");
+                IWL_ERR(bus, "Time out access OTP\n");
         else {
-                iwl_set_bits_prph(bus(priv), APMG_PS_CTRL_REG,
+                iwl_set_bits_prph(bus, APMG_PS_CTRL_REG,
                                   APMG_PS_CTRL_VAL_RESET_REQ);
                 udelay(5);
-                iwl_clear_bits_prph(bus(priv), APMG_PS_CTRL_REG,
+                iwl_clear_bits_prph(bus, APMG_PS_CTRL_REG,
                                     APMG_PS_CTRL_VAL_RESET_REQ);
 
                 /*
                  * CSR auto clock gate disable bit -
                  * this is only applicable for HW with OTP shadow RAM
                  */
-                if (priv->cfg->base_params->shadow_ram_support)
-                        iwl_set_bit(bus(priv), CSR_DBG_LINK_PWR_MGMT_REG,
+                if (priv(bus)->cfg->base_params->shadow_ram_support)
+                        iwl_set_bit(bus, CSR_DBG_LINK_PWR_MGMT_REG,
                                 CSR_RESET_LINK_PWR_MGMT_DISABLED);
         }
         return ret;
 }
 
-static int iwl_read_otp_word(struct iwl_priv *priv, u16 addr, __le16 *eeprom_data)
+static int iwl_read_otp_word(struct iwl_bus *bus, u16 addr, __le16 *eeprom_data)
 {
         int ret = 0;
         u32 r;
         u32 otpgp;
 
-        iwl_write32(bus(priv), CSR_EEPROM_REG,
+        iwl_write32(bus, CSR_EEPROM_REG,
                     CSR_EEPROM_REG_MSK_ADDR & (addr << 1));
-        ret = iwl_poll_bit(bus(priv), CSR_EEPROM_REG,
+        ret = iwl_poll_bit(bus, CSR_EEPROM_REG,
                                  CSR_EEPROM_REG_READ_VALID_MSK,
                                  CSR_EEPROM_REG_READ_VALID_MSK,
                                  IWL_EEPROM_ACCESS_TIMEOUT);
         if (ret < 0) {
-                IWL_ERR(priv, "Time out reading OTP[%d]\n", addr);
+                IWL_ERR(bus, "Time out reading OTP[%d]\n", addr);
                 return ret;
         }
-        r = iwl_read32(bus(priv), CSR_EEPROM_REG);
+        r = iwl_read32(bus, CSR_EEPROM_REG);
         /* check for ECC errors: */
-        otpgp = iwl_read32(bus(priv), CSR_OTP_GP_REG);
+        otpgp = iwl_read32(bus, CSR_OTP_GP_REG);
         if (otpgp & CSR_OTP_GP_REG_ECC_UNCORR_STATUS_MSK) {
                 /* stop in this case */
                 /* set the uncorrectable OTP ECC bit for acknowledgement */
-                iwl_set_bit(bus(priv), CSR_OTP_GP_REG,
+                iwl_set_bit(bus, CSR_OTP_GP_REG,
                         CSR_OTP_GP_REG_ECC_UNCORR_STATUS_MSK);
-                IWL_ERR(priv, "Uncorrectable OTP ECC error, abort OTP read\n");
+                IWL_ERR(bus, "Uncorrectable OTP ECC error, abort OTP read\n");
                 return -EINVAL;
         }
         if (otpgp & CSR_OTP_GP_REG_ECC_CORR_STATUS_MSK) {
                 /* continue in this case */
                 /* set the correctable OTP ECC bit for acknowledgement */
-                iwl_set_bit(bus(priv), CSR_OTP_GP_REG,
+                iwl_set_bit(bus, CSR_OTP_GP_REG,
                                 CSR_OTP_GP_REG_ECC_CORR_STATUS_MSK);
-                IWL_ERR(priv, "Correctable OTP ECC error, continue read\n");
+                IWL_ERR(bus, "Correctable OTP ECC error, continue read\n");
         }
         *eeprom_data = cpu_to_le16(r >> 16);
         return 0;
@@ -416,20 +416,20 @@ static int iwl_read_otp_word(struct iwl_priv *priv, u16 addr, __le16 *eeprom_dat
 /*
  * iwl_is_otp_empty: check for empty OTP
  */
-static bool iwl_is_otp_empty(struct iwl_priv *priv)
+static bool iwl_is_otp_empty(struct iwl_bus *bus)
 {
         u16 next_link_addr = 0;
         __le16 link_value;
         bool is_empty = false;
 
         /* locate the beginning of OTP link list */
-        if (!iwl_read_otp_word(priv, next_link_addr, &link_value)) {
+        if (!iwl_read_otp_word(bus, next_link_addr, &link_value)) {
                 if (!link_value) {
-                        IWL_ERR(priv, "OTP is empty\n");
+                        IWL_ERR(bus, "OTP is empty\n");
                         is_empty = true;
                 }
         } else {
-                IWL_ERR(priv, "Unable to read first block of OTP list.\n");
+                IWL_ERR(bus, "Unable to read first block of OTP list.\n");
                 is_empty = true;
         }
 
@@ -446,7 +446,7 @@ static bool iwl_is_otp_empty(struct iwl_priv *priv)
  *   we should read and used to configure the device.
  *   only perform this operation if shadow RAM is disabled
  */
-static int iwl_find_otp_image(struct iwl_priv *priv,
+static int iwl_find_otp_image(struct iwl_bus *bus,
                                         u16 *validblockaddr)
 {
         u16 next_link_addr = 0, valid_addr;
@@ -454,10 +454,10 @@ static int iwl_find_otp_image(struct iwl_priv *priv,
         int usedblocks = 0;
 
         /* set addressing mode to absolute to traverse the link list */
-        iwl_set_otp_access(priv, IWL_OTP_ACCESS_ABSOLUTE);
+        iwl_set_otp_access(bus, IWL_OTP_ACCESS_ABSOLUTE);
 
         /* checking for empty OTP or error */
-        if (iwl_is_otp_empty(priv))
+        if (iwl_is_otp_empty(bus))
                 return -EINVAL;
 
         /*
@@ -471,9 +471,9 @@ static int iwl_find_otp_image(struct iwl_priv *priv,
                  */
                 valid_addr = next_link_addr;
                 next_link_addr = le16_to_cpu(link_value) * sizeof(u16);
-                IWL_DEBUG_EEPROM(priv, "OTP blocks %d addr 0x%x\n",
+                IWL_DEBUG_EEPROM(bus, "OTP blocks %d addr 0x%x\n",
                                usedblocks, next_link_addr);
-                if (iwl_read_otp_word(priv, next_link_addr, &link_value))
+                if (iwl_read_otp_word(bus, next_link_addr, &link_value))
                         return -EINVAL;
                 if (!link_value) {
                         /*
@@ -488,10 +488,10 @@ static int iwl_find_otp_image(struct iwl_priv *priv,
                 }
                 /* more in the link list, continue */
                 usedblocks++;
-        } while (usedblocks <= priv->cfg->base_params->max_ll_items);
+        } while (usedblocks <= priv(bus)->cfg->base_params->max_ll_items);
 
         /* OTP has no valid blocks */
-        IWL_DEBUG_EEPROM(priv, "OTP has no valid blocks\n");
+        IWL_DEBUG_EEPROM(bus, "OTP has no valid blocks\n");
         return -EINVAL;
 }
 
@@ -504,28 +504,28 @@ static int iwl_find_otp_image(struct iwl_priv *priv,
  * iwl_get_max_txpower_avg - get the highest tx power from all chains.
  *     find the highest tx power from all chains for the channel
  */
-static s8 iwl_get_max_txpower_avg(struct iwl_priv *priv,
+static s8 iwl_get_max_txpower_avg(struct iwl_cfg *cfg,
                 struct iwl_eeprom_enhanced_txpwr *enhanced_txpower,
                 int element, s8 *max_txpower_in_half_dbm)
 {
         s8 max_txpower_avg = 0; /* (dBm) */
 
         /* Take the highest tx power from any valid chains */
-        if ((priv->cfg->valid_tx_ant & ANT_A) &&
+        if ((cfg->valid_tx_ant & ANT_A) &&
             (enhanced_txpower[element].chain_a_max > max_txpower_avg))
                 max_txpower_avg = enhanced_txpower[element].chain_a_max;
-        if ((priv->cfg->valid_tx_ant & ANT_B) &&
+        if ((cfg->valid_tx_ant & ANT_B) &&
             (enhanced_txpower[element].chain_b_max > max_txpower_avg))
                 max_txpower_avg = enhanced_txpower[element].chain_b_max;
-        if ((priv->cfg->valid_tx_ant & ANT_C) &&
+        if ((cfg->valid_tx_ant & ANT_C) &&
             (enhanced_txpower[element].chain_c_max > max_txpower_avg))
                 max_txpower_avg = enhanced_txpower[element].chain_c_max;
-        if (((priv->cfg->valid_tx_ant == ANT_AB) |
-            (priv->cfg->valid_tx_ant == ANT_BC) |
-            (priv->cfg->valid_tx_ant == ANT_AC)) &&
+        if (((cfg->valid_tx_ant == ANT_AB) |
+            (cfg->valid_tx_ant == ANT_BC) |
+            (cfg->valid_tx_ant == ANT_AC)) &&
             (enhanced_txpower[element].mimo2_max > max_txpower_avg))
                 max_txpower_avg =  enhanced_txpower[element].mimo2_max;
-        if ((priv->cfg->valid_tx_ant == ANT_ABC) &&
+        if ((cfg->valid_tx_ant == ANT_ABC) &&
             (enhanced_txpower[element].mimo3_max > max_txpower_avg))
                 max_txpower_avg = enhanced_txpower[element].mimo3_max;
 
@@ -627,7 +627,7 @@ void iwl_eeprom_enhanced_txpower(struct iwl_priv *priv)
                                  ((txp->delta_20_in_40 & 0xf0) >> 4),
                                  (txp->delta_20_in_40 & 0x0f));
 
-                max_txp_avg = iwl_get_max_txpower_avg(priv, txp_array, idx,
+                max_txp_avg = iwl_get_max_txpower_avg(priv->cfg, txp_array, idx,
                                                       &max_txp_avg_halfdbm);
 
                 /*
@@ -660,8 +660,8 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
         u16 validblockaddr = 0;
         u16 cache_addr = 0;
 
-        priv->nvm_device_type = iwl_get_nvm_type(priv, hw_rev);
-        if (priv->nvm_device_type == -ENOENT)
+        trans(priv)->nvm_device_type = iwl_get_nvm_type(bus(priv), hw_rev);
+        if (trans(priv)->nvm_device_type == -ENOENT)
                 return -ENOENT;
         /* allocate eeprom */
         sz = priv->cfg->base_params->eeprom_size;
@@ -675,7 +675,7 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
 
         iwl_apm_init(priv);
 
-        ret = iwl_eeprom_verify_signature(priv);
+        ret = iwl_eeprom_verify_signature(trans(priv));
         if (ret < 0) {
                 IWL_ERR(priv, "EEPROM not found, EEPROM_GP=0x%08x\n", gp);
                 ret = -ENOENT;
@@ -683,16 +683,16 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
         }
 
         /* Make sure driver (instead of uCode) is allowed to read EEPROM */
-        ret = iwl_eeprom_acquire_semaphore(priv);
+        ret = iwl_eeprom_acquire_semaphore(bus(priv));
         if (ret < 0) {
                 IWL_ERR(priv, "Failed to acquire EEPROM semaphore.\n");
                 ret = -ENOENT;
                 goto err;
         }
 
-        if (priv->nvm_device_type == NVM_DEVICE_TYPE_OTP) {
+        if (trans(priv)->nvm_device_type == NVM_DEVICE_TYPE_OTP) {
 
-                ret = iwl_init_otp_access(priv);
+                ret = iwl_init_otp_access(bus(priv));
                 if (ret) {
                         IWL_ERR(priv, "Failed to initialize OTP access.\n");
                         ret = -ENOENT;
@@ -707,7 +707,7 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
                              CSR_OTP_GP_REG_ECC_UNCORR_STATUS_MSK);
                 /* traversing the linked list if no shadow ram supported */
                 if (!priv->cfg->base_params->shadow_ram_support) {
-                        if (iwl_find_otp_image(priv, &validblockaddr)) {
+                        if (iwl_find_otp_image(bus(priv), &validblockaddr)) {
                                 ret = -ENOENT;
                                 goto done;
                         }
@@ -716,7 +716,7 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
                      addr += sizeof(u16)) {
                         __le16 eeprom_data;
 
-                        ret = iwl_read_otp_word(priv, addr, &eeprom_data);
+                        ret = iwl_read_otp_word(bus(priv), addr, &eeprom_data);
                         if (ret)
                                 goto done;
                         e[cache_addr / 2] = eeprom_data;
@@ -744,13 +744,13 @@ int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
         }
 
         IWL_DEBUG_EEPROM(priv, "NVM Type: %s, version: 0x%x\n",
-                       (priv->nvm_device_type == NVM_DEVICE_TYPE_OTP)
+                       (trans(priv)->nvm_device_type == NVM_DEVICE_TYPE_OTP)
                        ? "OTP" : "EEPROM",
                        iwl_eeprom_query16(priv, EEPROM_VERSION));
 
         ret = 0;
 done:
-        iwl_eeprom_release_semaphore(priv);
+        iwl_eeprom_release_semaphore(bus(priv));
 
 err:
         if (ret)
diff --git a/drivers/net/wireless/iwlwifi/iwl-mac80211.c b/drivers/net/wireless/iwlwifi/iwl-mac80211.c
new file mode 100644
index 000000000000..05b1f0d2f387
--- /dev/null
+++ b/drivers/net/wireless/iwlwifi/iwl-mac80211.c
@@ -0,0 +1,1632 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
+ *
+ * Portions of this file are derived from the ipw3945 project, as well
+ * as portions of the ieee80211 subsystem header files.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ *  Intel Linux Wireless <ilw@linux.intel.com>
+ * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+ *
+ *****************************************************************************/
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/dma-mapping.h>
+#include <linux/delay.h>
+#include <linux/sched.h>
+#include <linux/skbuff.h>
+#include <linux/netdevice.h>
+#include <linux/firmware.h>
+#include <linux/etherdevice.h>
+#include <linux/if_arp.h>
+
+#include <net/mac80211.h>
+
+#include <asm/div64.h>
+
+#include "iwl-eeprom.h"
+#include "iwl-dev.h"
+#include "iwl-core.h"
+#include "iwl-io.h"
+#include "iwl-agn-calib.h"
+#include "iwl-agn.h"
+#include "iwl-shared.h"
+#include "iwl-bus.h"
+#include "iwl-trans.h"
+
+/*****************************************************************************
+ *
+ * mac80211 entry point functions
+ *
+ *****************************************************************************/
+
+static const struct ieee80211_iface_limit iwlagn_sta_ap_limits[] = {
+        {
+                .max = 1,
+                .types = BIT(NL80211_IFTYPE_STATION),
+        },
+        {
+                .max = 1,
+                .types = BIT(NL80211_IFTYPE_AP),
+        },
+};
+
+static const struct ieee80211_iface_limit iwlagn_2sta_limits[] = {
+        {
+                .max = 2,
+                .types = BIT(NL80211_IFTYPE_STATION),
+        },
+};
+
+static const struct ieee80211_iface_limit iwlagn_p2p_sta_go_limits[] = {
+        {
+                .max = 1,
+                .types = BIT(NL80211_IFTYPE_STATION),
+        },
+        {
+                .max = 1,
+                .types = BIT(NL80211_IFTYPE_P2P_GO) |
+                         BIT(NL80211_IFTYPE_AP),
+        },
+};
+
+static const struct ieee80211_iface_limit iwlagn_p2p_2sta_limits[] = {
+        {
+                .max = 2,
+                .types = BIT(NL80211_IFTYPE_STATION),
+        },
+        {
+                .max = 1,
+                .types = BIT(NL80211_IFTYPE_P2P_CLIENT),
+        },
+};
+
+static const struct ieee80211_iface_combination
+iwlagn_iface_combinations_dualmode[] = {
+        { .num_different_channels = 1,
+          .max_interfaces = 2,
+          .beacon_int_infra_match = true,
+          .limits = iwlagn_sta_ap_limits,
+          .n_limits = ARRAY_SIZE(iwlagn_sta_ap_limits),
+        },
+        { .num_different_channels = 1,
+          .max_interfaces = 2,
+          .limits = iwlagn_2sta_limits,
+          .n_limits = ARRAY_SIZE(iwlagn_2sta_limits),
+        },
+};
+
+static const struct ieee80211_iface_combination
+iwlagn_iface_combinations_p2p[] = {
+        { .num_different_channels = 1,
+          .max_interfaces = 2,
+          .beacon_int_infra_match = true,
+          .limits = iwlagn_p2p_sta_go_limits,
+          .n_limits = ARRAY_SIZE(iwlagn_p2p_sta_go_limits),
+        },
+        { .num_different_channels = 1,
+          .max_interfaces = 2,
+          .limits = iwlagn_p2p_2sta_limits,
+          .n_limits = ARRAY_SIZE(iwlagn_p2p_2sta_limits),
+        },
+};
+
+/*
+ * Not a mac80211 entry point function, but it fits in with all the
+ * other mac80211 functions grouped here.
+ */
+int iwlagn_mac_setup_register(struct iwl_priv *priv,
+                                  struct iwlagn_ucode_capabilities *capa)
+{
+        int ret;
+        struct ieee80211_hw *hw = priv->hw;
+        struct iwl_rxon_context *ctx;
+
+        hw->rate_control_algorithm = "iwl-agn-rs";
+
+        /* Tell mac80211 our characteristics */
+        hw->flags = IEEE80211_HW_SIGNAL_DBM |
+                    IEEE80211_HW_AMPDU_AGGREGATION |
+                    IEEE80211_HW_NEED_DTIM_PERIOD |
+                    IEEE80211_HW_SPECTRUM_MGMT |
+                    IEEE80211_HW_REPORTS_TX_ACK_STATUS;
+
+        /*
+         * Including the following line will crash some AP's.  This
+         * workaround removes the stimulus which causes the crash until
+         * the AP software can be fixed.
+        hw->max_tx_aggregation_subframes = LINK_QUAL_AGG_FRAME_LIMIT_DEF;
+         */
+
+        hw->flags |= IEEE80211_HW_SUPPORTS_PS |
+                     IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
+
+        if (priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE)
+                hw->flags |= IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS |
+                             IEEE80211_HW_SUPPORTS_STATIC_SMPS;
+
+        if (capa->flags & IWL_UCODE_TLV_FLAGS_MFP)
+                hw->flags |= IEEE80211_HW_MFP_CAPABLE;
+
+        hw->sta_data_size = sizeof(struct iwl_station_priv);
+        hw->vif_data_size = sizeof(struct iwl_vif_priv);
+
+        for_each_context(priv, ctx) {
+                hw->wiphy->interface_modes |= ctx->interface_modes;
+                hw->wiphy->interface_modes |= ctx->exclusive_interface_modes;
+        }
+
+        BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
+
+        if (hw->wiphy->interface_modes & BIT(NL80211_IFTYPE_P2P_CLIENT)) {
+                hw->wiphy->iface_combinations = iwlagn_iface_combinations_p2p;
+                hw->wiphy->n_iface_combinations =
+                        ARRAY_SIZE(iwlagn_iface_combinations_p2p);
+        } else if (hw->wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) {
+                hw->wiphy->iface_combinations =
+                        iwlagn_iface_combinations_dualmode;
+                hw->wiphy->n_iface_combinations =
+                        ARRAY_SIZE(iwlagn_iface_combinations_dualmode);
+        }
+
+        hw->wiphy->max_remain_on_channel_duration = 1000;
+
+        hw->wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY |
+                            WIPHY_FLAG_DISABLE_BEACON_HINTS |
+                            WIPHY_FLAG_IBSS_RSN;
+
+        if (trans(priv)->ucode_wowlan.code.len &&
+            device_can_wakeup(bus(priv)->dev)) {
+                hw->wiphy->wowlan.flags = WIPHY_WOWLAN_MAGIC_PKT |
+                                          WIPHY_WOWLAN_DISCONNECT |
+                                          WIPHY_WOWLAN_EAP_IDENTITY_REQ |
+                                          WIPHY_WOWLAN_RFKILL_RELEASE;
+                if (!iwlagn_mod_params.sw_crypto)
+                        hw->wiphy->wowlan.flags |=
+                                WIPHY_WOWLAN_SUPPORTS_GTK_REKEY |
+                                WIPHY_WOWLAN_GTK_REKEY_FAILURE;
+
+                hw->wiphy->wowlan.n_patterns = IWLAGN_WOWLAN_MAX_PATTERNS;
+                hw->wiphy->wowlan.pattern_min_len =
+                                        IWLAGN_WOWLAN_MIN_PATTERN_LEN;
+                hw->wiphy->wowlan.pattern_max_len =
+                                        IWLAGN_WOWLAN_MAX_PATTERN_LEN;
+        }
+
+        if (iwlagn_mod_params.power_save)
+                hw->wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT;
+        else
+                hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+
+        hw->wiphy->max_scan_ssids = PROBE_OPTION_MAX;
+        /* we create the 802.11 header and a zero-length SSID element */
+        hw->wiphy->max_scan_ie_len = capa->max_probe_length - 24 - 2;
+
+        /* Default value; 4 EDCA QOS priorities */
+        hw->queues = 4;
+
+        hw->max_listen_interval = IWL_CONN_MAX_LISTEN_INTERVAL;
+
+        if (priv->bands[IEEE80211_BAND_2GHZ].n_channels)
+                priv->hw->wiphy->bands[IEEE80211_BAND_2GHZ] =
+                        &priv->bands[IEEE80211_BAND_2GHZ];
+        if (priv->bands[IEEE80211_BAND_5GHZ].n_channels)
+                priv->hw->wiphy->bands[IEEE80211_BAND_5GHZ] =
+                        &priv->bands[IEEE80211_BAND_5GHZ];
+
+        iwl_leds_init(priv);
+
+        ret = ieee80211_register_hw(priv->hw);
+        if (ret) {
+                IWL_ERR(priv, "Failed to register hw (error %d)\n", ret);
+                return ret;
+        }
+        priv->mac80211_registered = 1;
+
+        return 0;
+}
+
+static int __iwl_up(struct iwl_priv *priv)
+{
+        struct iwl_rxon_context *ctx;
+        int ret;
+
+        lockdep_assert_held(&priv->shrd->mutex);
+
+        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status)) {
+                IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
+                return -EIO;
+        }
+
+        for_each_context(priv, ctx) {
+                ret = iwlagn_alloc_bcast_station(priv, ctx);
+                if (ret) {
+                        iwl_dealloc_bcast_stations(priv);
+                        return ret;
+                }
+        }
+
+        ret = iwlagn_run_init_ucode(priv);
+        if (ret) {
+                IWL_ERR(priv, "Failed to run INIT ucode: %d\n", ret);
+                goto error;
+        }
+
+        ret = iwlagn_load_ucode_wait_alive(priv, IWL_UCODE_REGULAR);
+        if (ret) {
+                IWL_ERR(priv, "Failed to start RT ucode: %d\n", ret);
+                goto error;
+        }
+
+        ret = iwl_alive_start(priv);
+        if (ret)
+                goto error;
+        return 0;
+
+ error:
+        set_bit(STATUS_EXIT_PENDING, &priv->shrd->status);
+        __iwl_down(priv);
+        clear_bit(STATUS_EXIT_PENDING, &priv->shrd->status);
+
+        IWL_ERR(priv, "Unable to initialize device.\n");
+        return ret;
+}
+
+static int iwlagn_mac_start(struct ieee80211_hw *hw)
+{
+        struct iwl_priv *priv = hw->priv;
+        int ret;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        /* we should be verifying the device is ready to be opened */
+        mutex_lock(&priv->shrd->mutex);
+        ret = __iwl_up(priv);
+        mutex_unlock(&priv->shrd->mutex);
+        if (ret)
+                return ret;
+
+        IWL_DEBUG_INFO(priv, "Start UP work done.\n");
+
+        /* Now we should be done, and the READY bit should be set. */
+        if (WARN_ON(!test_bit(STATUS_READY, &priv->shrd->status)))
+                ret = -EIO;
+
+        iwlagn_led_enable(priv);
+
+        priv->is_open = 1;
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+        return 0;
+}
+
+static void iwlagn_mac_stop(struct ieee80211_hw *hw)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        if (!priv->is_open)
+                return;
+
+        priv->is_open = 0;
+
+        iwl_down(priv);
+
+        flush_workqueue(priv->shrd->workqueue);
+
+        /* User space software may expect getting rfkill changes
+         * even if interface is down */
+        iwl_write32(bus(priv), CSR_INT, 0xFFFFFFFF);
+        iwl_enable_rfkill_int(priv);
+
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+static void iwlagn_mac_set_rekey_data(struct ieee80211_hw *hw,
+                                      struct ieee80211_vif *vif,
+                                      struct cfg80211_gtk_rekey_data *data)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        if (iwlagn_mod_params.sw_crypto)
+                return;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        if (priv->contexts[IWL_RXON_CTX_BSS].vif != vif)
+                goto out;
+
+        memcpy(priv->kek, data->kek, NL80211_KEK_LEN);
+        memcpy(priv->kck, data->kck, NL80211_KCK_LEN);
+        priv->replay_ctr =
+                cpu_to_le64(be64_to_cpup((__be64 *)&data->replay_ctr));
+        priv->have_rekey_data = true;
+
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+#ifdef CONFIG_PM_SLEEP
+
+static int iwlagn_mac_suspend(struct ieee80211_hw *hw,
+                              struct cfg80211_wowlan *wowlan)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
+        int ret;
+
+        if (WARN_ON(!wowlan))
+                return -EINVAL;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        /* Don't attempt WoWLAN when not associated, tear down instead. */
+        if (!ctx->vif || ctx->vif->type != NL80211_IFTYPE_STATION ||
+            !iwl_is_associated_ctx(ctx)) {
+                ret = 1;
+                goto out;
+        }
+
+        ret = iwlagn_suspend(priv, hw, wowlan);
+        if (ret)
+                goto error;
+
+        device_set_wakeup_enable(bus(priv)->dev, true);
+
+        /* Now let the ucode operate on its own */
+        iwl_write32(bus(priv), CSR_UCODE_DRV_GP1_SET,
+                          CSR_UCODE_DRV_GP1_BIT_D3_CFG_COMPLETE);
+
+        goto out;
+
+ error:
+        priv->shrd->wowlan = false;
+        iwlagn_prepare_restart(priv);
+        ieee80211_restart_hw(priv->hw);
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return ret;
+}
+
+static int iwlagn_mac_resume(struct ieee80211_hw *hw)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
+        struct ieee80211_vif *vif;
+        unsigned long flags;
+        u32 base, status = 0xffffffff;
+        int ret = -EIO;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        iwl_write32(bus(priv), CSR_UCODE_DRV_GP1_CLR,
+                          CSR_UCODE_DRV_GP1_BIT_D3_CFG_COMPLETE);
+
+        base = priv->device_pointers.error_event_table;
+        if (iwlagn_hw_valid_rtc_data_addr(base)) {
+                spin_lock_irqsave(&bus(priv)->reg_lock, flags);
+                ret = iwl_grab_nic_access_silent(bus(priv));
+                if (ret == 0) {
+                        iwl_write32(bus(priv), HBUS_TARG_MEM_RADDR, base);
+                        status = iwl_read32(bus(priv), HBUS_TARG_MEM_RDAT);
+                        iwl_release_nic_access(bus(priv));
+                }
+                spin_unlock_irqrestore(&bus(priv)->reg_lock, flags);
+
+#ifdef CONFIG_IWLWIFI_DEBUGFS
+                if (ret == 0) {
+                        struct iwl_trans *trans = trans(priv);
+                        if (!priv->wowlan_sram)
+                                priv->wowlan_sram =
+                                        kzalloc(trans->ucode_wowlan.data.len,
+                                                GFP_KERNEL);
+
+                        if (priv->wowlan_sram)
+                                _iwl_read_targ_mem_words(
+                                        bus(priv), 0x800000, priv->wowlan_sram,
+                                        trans->ucode_wowlan.data.len / 4);
+                }
+#endif
+        }
+
+        /* we'll clear ctx->vif during iwlagn_prepare_restart() */
+        vif = ctx->vif;
+
+        priv->shrd->wowlan = false;
+
+        device_set_wakeup_enable(bus(priv)->dev, false);
+
+        iwlagn_prepare_restart(priv);
+
+        memset((void *)&ctx->active, 0, sizeof(ctx->active));
+        iwl_connection_init_rx_config(priv, ctx);
+        iwlagn_set_rxon_chain(priv, ctx);
+
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        ieee80211_resume_disconnect(vif);
+
+        return 1;
+}
+
+#endif
+
+static void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        IWL_DEBUG_MACDUMP(priv, "enter\n");
+
+        IWL_DEBUG_TX(priv, "dev->xmit(%d bytes) at rate 0x%02x\n", skb->len,
+                     ieee80211_get_tx_rate(hw, IEEE80211_SKB_CB(skb))->bitrate);
+
+        if (iwlagn_tx_skb(priv, skb))
+                dev_kfree_skb_any(skb);
+
+        IWL_DEBUG_MACDUMP(priv, "leave\n");
+}
+
+static void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
+                                       struct ieee80211_vif *vif,
+                                       struct ieee80211_key_conf *keyconf,
+                                       struct ieee80211_sta *sta,
+                                       u32 iv32, u16 *phase1key)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        iwl_update_tkip_key(priv, vif, keyconf, sta, iv32, phase1key);
+}
+
+static int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
+                              struct ieee80211_vif *vif,
+                              struct ieee80211_sta *sta,
+                              struct ieee80211_key_conf *key)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        struct iwl_rxon_context *ctx = vif_priv->ctx;
+        int ret;
+        bool is_default_wep_key = false;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        if (iwlagn_mod_params.sw_crypto) {
+                IWL_DEBUG_MAC80211(priv, "leave - hwcrypto disabled\n");
+                return -EOPNOTSUPP;
+        }
+
+        /*
+         * We could program these keys into the hardware as well, but we
+         * don't expect much multicast traffic in IBSS and having keys
+         * for more stations is probably more useful.
+         *
+         * Mark key TX-only and return 0.
+         */
+        if (vif->type == NL80211_IFTYPE_ADHOC &&
+            !(key->flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
+                key->hw_key_idx = WEP_INVALID_OFFSET;
+                return 0;
+        }
+
+        /* If they key was TX-only, accept deletion */
+        if (cmd == DISABLE_KEY && key->hw_key_idx == WEP_INVALID_OFFSET)
+                return 0;
+
+        mutex_lock(&priv->shrd->mutex);
+        iwl_scan_cancel_timeout(priv, 100);
+
+        BUILD_BUG_ON(WEP_INVALID_OFFSET == IWLAGN_HW_KEY_DEFAULT);
+
+        /*
+         * If we are getting WEP group key and we didn't receive any key mapping
+         * so far, we are in legacy wep mode (group key only), otherwise we are
+         * in 1X mode.
+         * In legacy wep mode, we use another host command to the uCode.
+         */
+        if ((key->cipher == WLAN_CIPHER_SUITE_WEP40 ||
+             key->cipher == WLAN_CIPHER_SUITE_WEP104) && !sta) {
+                if (cmd == SET_KEY)
+                        is_default_wep_key = !ctx->key_mapping_keys;
+                else
+                        is_default_wep_key =
+                                key->hw_key_idx == IWLAGN_HW_KEY_DEFAULT;
+        }
+
+
+        switch (cmd) {
+        case SET_KEY:
+                if (is_default_wep_key) {
+                        ret = iwl_set_default_wep_key(priv, vif_priv->ctx, key);
+                        break;
+                }
+                ret = iwl_set_dynamic_key(priv, vif_priv->ctx, key, sta);
+                if (ret) {
+                        /*
+                         * can't add key for RX, but we don't need it
+                         * in the device for TX so still return 0
+                         */
+                        ret = 0;
+                        key->hw_key_idx = WEP_INVALID_OFFSET;
+                }
+
+                IWL_DEBUG_MAC80211(priv, "enable hwcrypto key\n");
+                break;
+        case DISABLE_KEY:
+                if (is_default_wep_key)
+                        ret = iwl_remove_default_wep_key(priv, ctx, key);
+                else
+                        ret = iwl_remove_dynamic_key(priv, ctx, key, sta);
+
+                IWL_DEBUG_MAC80211(priv, "disable hwcrypto key\n");
+                break;
+        default:
+                ret = -EINVAL;
+        }
+
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return ret;
+}
+
+static int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
+                                   struct ieee80211_vif *vif,
+                                   enum ieee80211_ampdu_mlme_action action,
+                                   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
+                                   u8 buf_size)
+{
+        struct iwl_priv *priv = hw->priv;
+        int ret = -EINVAL;
+        struct iwl_station_priv *sta_priv = (void *) sta->drv_priv;
+        struct iwl_rxon_context *ctx =  iwl_rxon_ctx_from_vif(vif);
+
+        IWL_DEBUG_HT(priv, "A-MPDU action on addr %pM tid %d\n",
+                     sta->addr, tid);
+
+        if (!(priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE))
+                return -EACCES;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        switch (action) {
+        case IEEE80211_AMPDU_RX_START:
+                IWL_DEBUG_HT(priv, "start Rx\n");
+                ret = iwl_sta_rx_agg_start(priv, sta, tid, *ssn);
+                break;
+        case IEEE80211_AMPDU_RX_STOP:
+                IWL_DEBUG_HT(priv, "stop Rx\n");
+                ret = iwl_sta_rx_agg_stop(priv, sta, tid);
+                if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status))
+                        ret = 0;
+                break;
+        case IEEE80211_AMPDU_TX_START:
+                IWL_DEBUG_HT(priv, "start Tx\n");
+                ret = iwlagn_tx_agg_start(priv, vif, sta, tid, ssn);
+                break;
+        case IEEE80211_AMPDU_TX_STOP:
+                IWL_DEBUG_HT(priv, "stop Tx\n");
+                ret = iwlagn_tx_agg_stop(priv, vif, sta, tid);
+                if ((ret == 0) && (priv->agg_tids_count > 0)) {
+                        priv->agg_tids_count--;
+                        IWL_DEBUG_HT(priv, "priv->agg_tids_count = %u\n",
+                                     priv->agg_tids_count);
+                }
+                if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status))
+                        ret = 0;
+                if (!priv->agg_tids_count && priv->cfg->ht_params &&
+                    priv->cfg->ht_params->use_rts_for_aggregation) {
+                        /*
+                         * switch off RTS/CTS if it was previously enabled
+                         */
+                        sta_priv->lq_sta.lq.general_params.flags &=
+                                ~LINK_QUAL_FLAGS_SET_STA_TLC_RTS_MSK;
+                        iwl_send_lq_cmd(priv, iwl_rxon_ctx_from_vif(vif),
+                                        &sta_priv->lq_sta.lq, CMD_ASYNC, false);
+                }
+                break;
+        case IEEE80211_AMPDU_TX_OPERATIONAL:
+                buf_size = min_t(int, buf_size, LINK_QUAL_AGG_FRAME_LIMIT_DEF);
+
+                iwl_trans_tx_agg_setup(trans(priv), ctx->ctxid, iwl_sta_id(sta),
+                                tid, buf_size);
+
+                /*
+                 * If the limit is 0, then it wasn't initialised yet,
+                 * use the default. We can do that since we take the
+                 * minimum below, and we don't want to go above our
+                 * default due to hardware restrictions.
+                 */
+                if (sta_priv->max_agg_bufsize == 0)
+                        sta_priv->max_agg_bufsize =
+                                LINK_QUAL_AGG_FRAME_LIMIT_DEF;
+
+                /*
+                 * Even though in theory the peer could have different
+                 * aggregation reorder buffer sizes for different sessions,
+                 * our ucode doesn't allow for that and has a global limit
+                 * for each station. Therefore, use the minimum of all the
+                 * aggregation sessions and our default value.
+                 */
+                sta_priv->max_agg_bufsize =
+                        min(sta_priv->max_agg_bufsize, buf_size);
+
+                if (priv->cfg->ht_params &&
+                    priv->cfg->ht_params->use_rts_for_aggregation) {
+                        /*
+                         * switch to RTS/CTS if it is the prefer protection
+                         * method for HT traffic
+                         */
+
+                        sta_priv->lq_sta.lq.general_params.flags |=
+                                LINK_QUAL_FLAGS_SET_STA_TLC_RTS_MSK;
+                }
+                priv->agg_tids_count++;
+                IWL_DEBUG_HT(priv, "priv->agg_tids_count = %u\n",
+                             priv->agg_tids_count);
+
+                sta_priv->lq_sta.lq.agg_params.agg_frame_cnt_limit =
+                        sta_priv->max_agg_bufsize;
+
+                iwl_send_lq_cmd(priv, iwl_rxon_ctx_from_vif(vif),
+                                &sta_priv->lq_sta.lq, CMD_ASYNC, false);
+
+                IWL_INFO(priv, "Tx aggregation enabled on ra = %pM tid = %d\n",
+                         sta->addr, tid);
+                ret = 0;
+                break;
+        }
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+        return ret;
+}
+
+static int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
+                              struct ieee80211_vif *vif,
+                              struct ieee80211_sta *sta)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        bool is_ap = vif->type == NL80211_IFTYPE_STATION;
+        int ret = 0;
+        u8 sta_id;
+
+        IWL_DEBUG_MAC80211(priv, "received request to add station %pM\n",
+                        sta->addr);
+        mutex_lock(&priv->shrd->mutex);
+        IWL_DEBUG_INFO(priv, "proceeding to add station %pM\n",
+                        sta->addr);
+        sta_priv->sta_id = IWL_INVALID_STATION;
+
+        atomic_set(&sta_priv->pending_frames, 0);
+        if (vif->type == NL80211_IFTYPE_AP)
+                sta_priv->client = true;
+
+        ret = iwl_add_station_common(priv, vif_priv->ctx, sta->addr,
+                                     is_ap, sta, &sta_id);
+        if (ret) {
+                IWL_ERR(priv, "Unable to add station %pM (%d)\n",
+                        sta->addr, ret);
+                /* Should we return success if return code is EEXIST ? */
+                goto out;
+        }
+
+        sta_priv->sta_id = sta_id;
+
+        /* Initialize rate scaling */
+        IWL_DEBUG_INFO(priv, "Initializing rate scaling for station %pM\n",
+                       sta->addr);
+        iwl_rs_rate_init(priv, sta, sta_id);
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return ret;
+}
+
+static void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
+                                struct ieee80211_channel_switch *ch_switch)
+{
+        struct iwl_priv *priv = hw->priv;
+        const struct iwl_channel_info *ch_info;
+        struct ieee80211_conf *conf = &hw->conf;
+        struct ieee80211_channel *channel = ch_switch->channel;
+        struct iwl_ht_config *ht_conf = &priv->current_ht_config;
+        /*
+         * MULTI-FIXME
+         * When we add support for multiple interfaces, we need to
+         * revisit this. The channel switch command in the device
+         * only affects the BSS context, but what does that really
+         * mean? And what if we get a CSA on the second interface?
+         * This needs a lot of work.
+         */
+        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
+        u16 ch;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        mutex_lock(&priv->shrd->mutex);
+
+        if (iwl_is_rfkill(priv->shrd))
+                goto out;
+
+        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status) ||
+            test_bit(STATUS_SCANNING, &priv->shrd->status) ||
+            test_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status))
+                goto out;
+
+        if (!iwl_is_associated_ctx(ctx))
+                goto out;
+
+        if (!priv->cfg->lib->set_channel_switch)
+                goto out;
+
+        ch = channel->hw_value;
+        if (le16_to_cpu(ctx->active.channel) == ch)
+                goto out;
+
+        ch_info = iwl_get_channel_info(priv, channel->band, ch);
+        if (!is_channel_valid(ch_info)) {
+                IWL_DEBUG_MAC80211(priv, "invalid channel\n");
+                goto out;
+        }
+
+        spin_lock_irq(&priv->shrd->lock);
+
+        priv->current_ht_config.smps = conf->smps_mode;
+
+        /* Configure HT40 channels */
+        ctx->ht.enabled = conf_is_ht(conf);
+        if (ctx->ht.enabled) {
+                if (conf_is_ht40_minus(conf)) {
+                        ctx->ht.extension_chan_offset =
+                                IEEE80211_HT_PARAM_CHA_SEC_BELOW;
+                        ctx->ht.is_40mhz = true;
+                } else if (conf_is_ht40_plus(conf)) {
+                        ctx->ht.extension_chan_offset =
+                                IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
+                        ctx->ht.is_40mhz = true;
+                } else {
+                        ctx->ht.extension_chan_offset =
+                                IEEE80211_HT_PARAM_CHA_SEC_NONE;
+                        ctx->ht.is_40mhz = false;
+                }
+        } else
+                ctx->ht.is_40mhz = false;
+
+        if ((le16_to_cpu(ctx->staging.channel) != ch))
+                ctx->staging.flags = 0;
+
+        iwl_set_rxon_channel(priv, channel, ctx);
+        iwl_set_rxon_ht(priv, ht_conf);
+        iwl_set_flags_for_band(priv, ctx, channel->band, ctx->vif);
+
+        spin_unlock_irq(&priv->shrd->lock);
+
+        iwl_set_rate(priv);
+        /*
+         * at this point, staging_rxon has the
+         * configuration for channel switch
+         */
+        set_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status);
+        priv->switch_channel = cpu_to_le16(ch);
+        if (priv->cfg->lib->set_channel_switch(priv, ch_switch)) {
+                clear_bit(STATUS_CHANNEL_SWITCH_PENDING, &priv->shrd->status);
+                priv->switch_channel = 0;
+                ieee80211_chswitch_done(ctx->vif, false);
+        }
+
+out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+static void iwlagn_configure_filter(struct ieee80211_hw *hw,
+                                    unsigned int changed_flags,
+                                    unsigned int *total_flags,
+                                    u64 multicast)
+{
+        struct iwl_priv *priv = hw->priv;
+        __le32 filter_or = 0, filter_nand = 0;
+        struct iwl_rxon_context *ctx;
+
+#define CHK(test, flag) do { \
+        if (*total_flags & (test))              \
+                filter_or |= (flag);            \
+        else                                    \
+                filter_nand |= (flag);          \
+        } while (0)
+
+        IWL_DEBUG_MAC80211(priv, "Enter: changed: 0x%x, total: 0x%x\n",
+                        changed_flags, *total_flags);
+
+        CHK(FIF_OTHER_BSS | FIF_PROMISC_IN_BSS, RXON_FILTER_PROMISC_MSK);
+        /* Setting _just_ RXON_FILTER_CTL2HOST_MSK causes FH errors */
+        CHK(FIF_CONTROL, RXON_FILTER_CTL2HOST_MSK | RXON_FILTER_PROMISC_MSK);
+        CHK(FIF_BCN_PRBRESP_PROMISC, RXON_FILTER_BCON_AWARE_MSK);
+
+#undef CHK
+
+        mutex_lock(&priv->shrd->mutex);
+
+        for_each_context(priv, ctx) {
+                ctx->staging.filter_flags &= ~filter_nand;
+                ctx->staging.filter_flags |= filter_or;
+
+                /*
+                 * Not committing directly because hardware can perform a scan,
+                 * but we'll eventually commit the filter flags change anyway.
+                 */
+        }
+
+        mutex_unlock(&priv->shrd->mutex);
+
+        /*
+         * Receiving all multicast frames is always enabled by the
+         * default flags setup in iwl_connection_init_rx_config()
+         * since we currently do not support programming multicast
+         * filters into the device.
+         */
+        *total_flags &= FIF_OTHER_BSS | FIF_ALLMULTI | FIF_PROMISC_IN_BSS |
+                        FIF_BCN_PRBRESP_PROMISC | FIF_CONTROL;
+}
+
+static void iwlagn_mac_flush(struct ieee80211_hw *hw, bool drop)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        mutex_lock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        if (test_bit(STATUS_EXIT_PENDING, &priv->shrd->status)) {
+                IWL_DEBUG_TX(priv, "Aborting flush due to device shutdown\n");
+                goto done;
+        }
+        if (iwl_is_rfkill(priv->shrd)) {
+                IWL_DEBUG_TX(priv, "Aborting flush due to RF Kill\n");
+                goto done;
+        }
+
+        /*
+         * mac80211 will not push any more frames for transmit
+         * until the flush is completed
+         */
+        if (drop) {
+                IWL_DEBUG_MAC80211(priv, "send flush command\n");
+                if (iwlagn_txfifo_flush(priv, IWL_DROP_ALL)) {
+                        IWL_ERR(priv, "flush request fail\n");
+                        goto done;
+                }
+        }
+        IWL_DEBUG_MAC80211(priv, "wait transmit/flush all frames\n");
+        iwl_trans_wait_tx_queue_empty(trans(priv));
+done:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+static int iwlagn_mac_remain_on_channel(struct ieee80211_hw *hw,
+                                     struct ieee80211_channel *channel,
+                                     enum nl80211_channel_type channel_type,
+                                     int duration)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_PAN];
+        int err = 0;
+
+        if (!(priv->shrd->valid_contexts & BIT(IWL_RXON_CTX_PAN)))
+                return -EOPNOTSUPP;
+
+        if (!(ctx->interface_modes & BIT(NL80211_IFTYPE_P2P_CLIENT)))
+                return -EOPNOTSUPP;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        if (test_bit(STATUS_SCAN_HW, &priv->shrd->status)) {
+                err = -EBUSY;
+                goto out;
+        }
+
+        priv->hw_roc_channel = channel;
+        priv->hw_roc_chantype = channel_type;
+        /* convert from ms to TU */
+        priv->hw_roc_duration = DIV_ROUND_UP(1000 * duration, 1024);
+        priv->hw_roc_start_notified = false;
+        cancel_delayed_work(&priv->hw_roc_disable_work);
+
+        if (!ctx->is_active) {
+                static const struct iwl_qos_info default_qos_data = {
+                        .def_qos_parm = {
+                                .ac[0] = {
+                                        .cw_min = cpu_to_le16(3),
+                                        .cw_max = cpu_to_le16(7),
+                                        .aifsn = 2,
+                                        .edca_txop = cpu_to_le16(1504),
+                                },
+                                .ac[1] = {
+                                        .cw_min = cpu_to_le16(7),
+                                        .cw_max = cpu_to_le16(15),
+                                        .aifsn = 2,
+                                        .edca_txop = cpu_to_le16(3008),
+                                },
+                                .ac[2] = {
+                                        .cw_min = cpu_to_le16(15),
+                                        .cw_max = cpu_to_le16(1023),
+                                        .aifsn = 3,
+                                },
+                                .ac[3] = {
+                                        .cw_min = cpu_to_le16(15),
+                                        .cw_max = cpu_to_le16(1023),
+                                        .aifsn = 7,
+                                },
+                        },
+                };
+
+                ctx->is_active = true;
+                ctx->qos_data = default_qos_data;
+                ctx->staging.dev_type = RXON_DEV_TYPE_P2P;
+                memcpy(ctx->staging.node_addr,
+                       priv->contexts[IWL_RXON_CTX_BSS].staging.node_addr,
+                       ETH_ALEN);
+                memcpy(ctx->staging.bssid_addr,
+                       priv->contexts[IWL_RXON_CTX_BSS].staging.node_addr,
+                       ETH_ALEN);
+                err = iwlagn_commit_rxon(priv, ctx);
+                if (err)
+                        goto out;
+                ctx->staging.filter_flags |= RXON_FILTER_ASSOC_MSK |
+                                             RXON_FILTER_PROMISC_MSK |
+                                             RXON_FILTER_CTL2HOST_MSK;
+
+                err = iwlagn_commit_rxon(priv, ctx);
+                if (err) {
+                        iwlagn_disable_roc(priv);
+                        goto out;
+                }
+                priv->hw_roc_setup = true;
+        }
+
+        err = iwl_scan_initiate(priv, ctx->vif, IWL_SCAN_ROC, channel->band);
+        if (err)
+                iwlagn_disable_roc(priv);
+
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return err;
+}
+
+static int iwlagn_mac_cancel_remain_on_channel(struct ieee80211_hw *hw)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        if (!(priv->shrd->valid_contexts & BIT(IWL_RXON_CTX_PAN)))
+                return -EOPNOTSUPP;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+        iwl_scan_cancel_timeout(priv, priv->hw_roc_duration);
+        iwlagn_disable_roc(priv);
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return 0;
+}
+
+static int iwlagn_mac_tx_sync(struct ieee80211_hw *hw,
+                              struct ieee80211_vif *vif,
+                              const u8 *bssid,
+                              enum ieee80211_tx_sync_type type)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        struct iwl_rxon_context *ctx = vif_priv->ctx;
+        int ret;
+        u8 sta_id;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        if (iwl_is_associated_ctx(ctx)) {
+                ret = 0;
+                goto out;
+        }
+
+        if (ctx->preauth_bssid || test_bit(STATUS_SCAN_HW,
+            &priv->shrd->status)) {
+                ret = -EBUSY;
+                goto out;
+        }
+
+        ret = iwl_add_station_common(priv, ctx, bssid, true, NULL, &sta_id);
+        if (ret)
+                goto out;
+
+        if (WARN_ON(sta_id != ctx->ap_sta_id)) {
+                ret = -EIO;
+                goto out_remove_sta;
+        }
+
+        memcpy(ctx->bssid, bssid, ETH_ALEN);
+        ctx->preauth_bssid = true;
+
+        ret = iwlagn_commit_rxon(priv, ctx);
+
+        if (ret == 0)
+                goto out;
+
+ out_remove_sta:
+        iwl_remove_station(priv, sta_id, bssid);
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return ret;
+}
+
+static void iwlagn_mac_finish_tx_sync(struct ieee80211_hw *hw,
+                                   struct ieee80211_vif *vif,
+                                   const u8 *bssid,
+                                   enum ieee80211_tx_sync_type type)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        struct iwl_rxon_context *ctx = vif_priv->ctx;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        if (iwl_is_associated_ctx(ctx))
+                goto out;
+
+        iwl_remove_station(priv, ctx->ap_sta_id, bssid);
+        ctx->preauth_bssid = false;
+        /* no need to commit */
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+static void iwlagn_mac_rssi_callback(struct ieee80211_hw *hw,
+                           enum ieee80211_rssi_event rssi_event)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->shrd->mutex);
+
+        if (priv->cfg->bt_params &&
+                        priv->cfg->bt_params->advanced_bt_coexist) {
+                if (rssi_event == RSSI_EVENT_LOW)
+                        priv->bt_enable_pspoll = true;
+                else if (rssi_event == RSSI_EVENT_HIGH)
+                        priv->bt_enable_pspoll = false;
+
+                iwlagn_send_advance_bt_config(priv);
+        } else {
+                IWL_DEBUG_MAC80211(priv, "Advanced BT coex disabled,"
+                                "ignoring RSSI callback\n");
+        }
+
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+static int iwlagn_mac_set_tim(struct ieee80211_hw *hw,
+                           struct ieee80211_sta *sta, bool set)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        queue_work(priv->shrd->workqueue, &priv->beacon_update);
+
+        return 0;
+}
+
+static int iwlagn_mac_conf_tx(struct ieee80211_hw *hw,
+                    struct ieee80211_vif *vif, u16 queue,
+                    const struct ieee80211_tx_queue_params *params)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        struct iwl_rxon_context *ctx = vif_priv->ctx;
+        unsigned long flags;
+        int q;
+
+        if (WARN_ON(!ctx))
+                return -EINVAL;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        if (!iwl_is_ready_rf(priv->shrd)) {
+                IWL_DEBUG_MAC80211(priv, "leave - RF not ready\n");
+                return -EIO;
+        }
+
+        if (queue >= AC_NUM) {
+                IWL_DEBUG_MAC80211(priv, "leave - queue >= AC_NUM %d\n", queue);
+                return 0;
+        }
+
+        q = AC_NUM - 1 - queue;
+
+        spin_lock_irqsave(&priv->shrd->lock, flags);
+
+        ctx->qos_data.def_qos_parm.ac[q].cw_min =
+                cpu_to_le16(params->cw_min);
+        ctx->qos_data.def_qos_parm.ac[q].cw_max =
+                cpu_to_le16(params->cw_max);
+        ctx->qos_data.def_qos_parm.ac[q].aifsn = params->aifs;
+        ctx->qos_data.def_qos_parm.ac[q].edca_txop =
+                        cpu_to_le16((params->txop * 32));
+
+        ctx->qos_data.def_qos_parm.ac[q].reserved1 = 0;
+
+        spin_unlock_irqrestore(&priv->shrd->lock, flags);
+
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+        return 0;
+}
+
+static int iwlagn_mac_tx_last_beacon(struct ieee80211_hw *hw)
+{
+        struct iwl_priv *priv = hw->priv;
+
+        return priv->ibss_manager == IWL_IBSS_MANAGER;
+}
+
+static int iwl_set_mode(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
+{
+        iwl_connection_init_rx_config(priv, ctx);
+
+        iwlagn_set_rxon_chain(priv, ctx);
+
+        return iwlagn_commit_rxon(priv, ctx);
+}
+
+static int iwl_setup_interface(struct iwl_priv *priv,
+                               struct iwl_rxon_context *ctx)
+{
+        struct ieee80211_vif *vif = ctx->vif;
+        int err;
+
+        lockdep_assert_held(&priv->shrd->mutex);
+
+        /*
+         * This variable will be correct only when there's just
+         * a single context, but all code using it is for hardware
+         * that supports only one context.
+         */
+        priv->iw_mode = vif->type;
+
+        ctx->is_active = true;
+
+        err = iwl_set_mode(priv, ctx);
+        if (err) {
+                if (!ctx->always_active)
+                        ctx->is_active = false;
+                return err;
+        }
+
+        if (priv->cfg->bt_params && priv->cfg->bt_params->advanced_bt_coexist &&
+            vif->type == NL80211_IFTYPE_ADHOC) {
+                /*
+                 * pretend to have high BT traffic as long as we
+                 * are operating in IBSS mode, as this will cause
+                 * the rate scaling etc. to behave as intended.
+                 */
+                priv->bt_traffic_load = IWL_BT_COEX_TRAFFIC_LOAD_HIGH;
+        }
+
+        return 0;
+}
+
+static int iwlagn_mac_add_interface(struct ieee80211_hw *hw,
+                             struct ieee80211_vif *vif)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
+        struct iwl_rxon_context *tmp, *ctx = NULL;
+        int err;
+        enum nl80211_iftype viftype = ieee80211_vif_type_p2p(vif);
+
+        IWL_DEBUG_MAC80211(priv, "enter: type %d, addr %pM\n",
+                           viftype, vif->addr);
+
+        cancel_delayed_work_sync(&priv->hw_roc_disable_work);
+
+        mutex_lock(&priv->shrd->mutex);
+
+        iwlagn_disable_roc(priv);
+
+        if (!iwl_is_ready_rf(priv->shrd)) {
+                IWL_WARN(priv, "Try to add interface when device not ready\n");
+                err = -EINVAL;
+                goto out;
+        }
+
+        for_each_context(priv, tmp) {
+                u32 possible_modes =
+                        tmp->interface_modes | tmp->exclusive_interface_modes;
+
+                if (tmp->vif) {
+                        /* check if this busy context is exclusive */
+                        if (tmp->exclusive_interface_modes &
+                                                BIT(tmp->vif->type)) {
+                                err = -EINVAL;
+                                goto out;
+                        }
+                        continue;
+                }
+
+                if (!(possible_modes & BIT(viftype)))
+                        continue;
+
+                /* have maybe usable context w/o interface */
+                ctx = tmp;
+                break;
+        }
+
+        if (!ctx) {
+                err = -EOPNOTSUPP;
+                goto out;
+        }
+
+        vif_priv->ctx = ctx;
+        ctx->vif = vif;
+
+        err = iwl_setup_interface(priv, ctx);
+        if (!err)
+                goto out;
+
+        ctx->vif = NULL;
+        priv->iw_mode = NL80211_IFTYPE_STATION;
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+        return err;
+}
+
+static void iwl_teardown_interface(struct iwl_priv *priv,
+                                   struct ieee80211_vif *vif,
+                                   bool mode_change)
+{
+        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
+
+        lockdep_assert_held(&priv->shrd->mutex);
+
+        if (priv->scan_vif == vif) {
+                iwl_scan_cancel_timeout(priv, 200);
+                iwl_force_scan_end(priv);
+        }
+
+        if (!mode_change) {
+                iwl_set_mode(priv, ctx);
+                if (!ctx->always_active)
+                        ctx->is_active = false;
+        }
+
+        /*
+         * When removing the IBSS interface, overwrite the
+         * BT traffic load with the stored one from the last
+         * notification, if any. If this is a device that
+         * doesn't implement this, this has no effect since
+         * both values are the same and zero.
+         */
+        if (vif->type == NL80211_IFTYPE_ADHOC)
+                priv->bt_traffic_load = priv->last_bt_traffic_load;
+}
+
+static void iwlagn_mac_remove_interface(struct ieee80211_hw *hw,
+                              struct ieee80211_vif *vif)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        mutex_lock(&priv->shrd->mutex);
+
+        if (WARN_ON(ctx->vif != vif)) {
+                struct iwl_rxon_context *tmp;
+                IWL_ERR(priv, "ctx->vif = %p, vif = %p\n", ctx->vif, vif);
+                for_each_context(priv, tmp)
+                        IWL_ERR(priv, "\tID = %d:\tctx = %p\tctx->vif = %p\n",
+                                tmp->ctxid, tmp, tmp->vif);
+        }
+        ctx->vif = NULL;
+
+        iwl_teardown_interface(priv, vif, false);
+
+        mutex_unlock(&priv->shrd->mutex);
+
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+}
+
+static int iwlagn_mac_change_interface(struct ieee80211_hw *hw,
+                                struct ieee80211_vif *vif,
+                                enum nl80211_iftype newtype, bool newp2p)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
+        struct iwl_rxon_context *bss_ctx = &priv->contexts[IWL_RXON_CTX_BSS];
+        struct iwl_rxon_context *tmp;
+        enum nl80211_iftype newviftype = newtype;
+        u32 interface_modes;
+        int err;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        newtype = ieee80211_iftype_p2p(newtype, newp2p);
+
+        mutex_lock(&priv->shrd->mutex);
+
+        if (!ctx->vif || !iwl_is_ready_rf(priv->shrd)) {
+                /*
+                 * Huh? But wait ... this can maybe happen when
+                 * we're in the middle of a firmware restart!
+                 */
+                err = -EBUSY;
+                goto out;
+        }
+
+        interface_modes = ctx->interface_modes | ctx->exclusive_interface_modes;
+
+        if (!(interface_modes & BIT(newtype))) {
+                err = -EBUSY;
+                goto out;
+        }
+
+        /*
+         * Refuse a change that should be done by moving from the PAN
+         * context to the BSS context instead, if the BSS context is
+         * available and can support the new interface type.
+         */
+        if (ctx->ctxid == IWL_RXON_CTX_PAN && !bss_ctx->vif &&
+            (bss_ctx->interface_modes & BIT(newtype) ||
+             bss_ctx->exclusive_interface_modes & BIT(newtype))) {
+                BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
+                err = -EBUSY;
+                goto out;
+        }
+
+        if (ctx->exclusive_interface_modes & BIT(newtype)) {
+                for_each_context(priv, tmp) {
+                        if (ctx == tmp)
+                                continue;
+
+                        if (!tmp->vif)
+                                continue;
+
+                        /*
+                         * The current mode switch would be exclusive, but
+                         * another context is active ... refuse the switch.
+                         */
+                        err = -EBUSY;
+                        goto out;
+                }
+        }
+
+        /* success */
+        iwl_teardown_interface(priv, vif, true);
+        vif->type = newviftype;
+        vif->p2p = newp2p;
+        err = iwl_setup_interface(priv, ctx);
+        WARN_ON(err);
+        /*
+         * We've switched internally, but submitting to the
+         * device may have failed for some reason. Mask this
+         * error, because otherwise mac80211 will not switch
+         * (and set the interface type back) and we'll be
+         * out of sync with it.
+         */
+        err = 0;
+
+ out:
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return err;
+}
+
+static int iwlagn_mac_hw_scan(struct ieee80211_hw *hw,
+                    struct ieee80211_vif *vif,
+                    struct cfg80211_scan_request *req)
+{
+        struct iwl_priv *priv = hw->priv;
+        int ret;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        if (req->n_channels == 0)
+                return -EINVAL;
+
+        mutex_lock(&priv->shrd->mutex);
+
+        /*
+         * If an internal scan is in progress, just set
+         * up the scan_request as per above.
+         */
+        if (priv->scan_type != IWL_SCAN_NORMAL) {
+                IWL_DEBUG_SCAN(priv,
+                               "SCAN request during internal scan - defer\n");
+                priv->scan_request = req;
+                priv->scan_vif = vif;
+                ret = 0;
+        } else {
+                priv->scan_request = req;
+                priv->scan_vif = vif;
+                /*
+                 * mac80211 will only ask for one band at a time
+                 * so using channels[0] here is ok
+                 */
+                ret = iwl_scan_initiate(priv, vif, IWL_SCAN_NORMAL,
+                                        req->channels[0]->band);
+                if (ret) {
+                        priv->scan_request = NULL;
+                        priv->scan_vif = NULL;
+                }
+        }
+
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        mutex_unlock(&priv->shrd->mutex);
+
+        return ret;
+}
+
+static int iwlagn_mac_sta_remove(struct ieee80211_hw *hw,
+                       struct ieee80211_vif *vif,
+                       struct ieee80211_sta *sta)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
+        int ret;
+
+        IWL_DEBUG_MAC80211(priv, "enter: received request to remove "
+                           "station %pM\n", sta->addr);
+        mutex_lock(&priv->shrd->mutex);
+        IWL_DEBUG_INFO(priv, "proceeding to remove station %pM\n",
+                        sta->addr);
+        ret = iwl_remove_station(priv, sta_priv->sta_id, sta->addr);
+        if (ret)
+                IWL_DEBUG_QUIET_RFKILL(priv, "Error removing station %pM\n",
+                        sta->addr);
+        mutex_unlock(&priv->shrd->mutex);
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+
+        return ret;
+}
+
+static void iwl_sta_modify_ps_wake(struct iwl_priv *priv, int sta_id)
+{
+        unsigned long flags;
+
+        spin_lock_irqsave(&priv->shrd->sta_lock, flags);
+        priv->stations[sta_id].sta.station_flags &= ~STA_FLG_PWR_SAVE_MSK;
+        priv->stations[sta_id].sta.station_flags_msk = STA_FLG_PWR_SAVE_MSK;
+        priv->stations[sta_id].sta.sta.modify_mask = 0;
+        priv->stations[sta_id].sta.sleep_tx_count = 0;
+        priv->stations[sta_id].sta.mode = STA_CONTROL_MODIFY_MSK;
+        iwl_send_add_sta(priv, &priv->stations[sta_id].sta, CMD_ASYNC);
+        spin_unlock_irqrestore(&priv->shrd->sta_lock, flags);
+
+}
+
+static void iwlagn_mac_sta_notify(struct ieee80211_hw *hw,
+                           struct ieee80211_vif *vif,
+                           enum sta_notify_cmd cmd,
+                           struct ieee80211_sta *sta)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
+        int sta_id;
+
+        IWL_DEBUG_MAC80211(priv, "enter\n");
+
+        switch (cmd) {
+        case STA_NOTIFY_SLEEP:
+                WARN_ON(!sta_priv->client);
+                sta_priv->asleep = true;
+                if (atomic_read(&sta_priv->pending_frames) > 0)
+                        ieee80211_sta_block_awake(hw, sta, true);
+                break;
+        case STA_NOTIFY_AWAKE:
+                WARN_ON(!sta_priv->client);
+                if (!sta_priv->asleep)
+                        break;
+                sta_priv->asleep = false;
+                sta_id = iwl_sta_id(sta);
+                if (sta_id != IWL_INVALID_STATION)
+                        iwl_sta_modify_ps_wake(priv, sta_id);
+                break;
+        default:
+                break;
+        }
+        IWL_DEBUG_MAC80211(priv, "leave\n");
+}
+
+struct ieee80211_ops iwlagn_hw_ops = {
+        .tx = iwlagn_mac_tx,
+        .start = iwlagn_mac_start,
+        .stop = iwlagn_mac_stop,
+#ifdef CONFIG_PM_SLEEP
+        .suspend = iwlagn_mac_suspend,
+        .resume = iwlagn_mac_resume,
+#endif
+        .add_interface = iwlagn_mac_add_interface,
+        .remove_interface = iwlagn_mac_remove_interface,
+        .change_interface = iwlagn_mac_change_interface,
+        .config = iwlagn_mac_config,
+        .configure_filter = iwlagn_configure_filter,
+        .set_key = iwlagn_mac_set_key,
+        .update_tkip_key = iwlagn_mac_update_tkip_key,
+        .set_rekey_data = iwlagn_mac_set_rekey_data,
+        .conf_tx = iwlagn_mac_conf_tx,
+        .bss_info_changed = iwlagn_bss_info_changed,
+        .ampdu_action = iwlagn_mac_ampdu_action,
+        .hw_scan = iwlagn_mac_hw_scan,
+        .sta_notify = iwlagn_mac_sta_notify,
+        .sta_add = iwlagn_mac_sta_add,
+        .sta_remove = iwlagn_mac_sta_remove,
+        .channel_switch = iwlagn_mac_channel_switch,
+        .flush = iwlagn_mac_flush,
+        .tx_last_beacon = iwlagn_mac_tx_last_beacon,
+        .remain_on_channel = iwlagn_mac_remain_on_channel,
+        .cancel_remain_on_channel = iwlagn_mac_cancel_remain_on_channel,
+        .rssi_callback = iwlagn_mac_rssi_callback,
+        CFG80211_TESTMODE_CMD(iwlagn_mac_testmode_cmd)
+        CFG80211_TESTMODE_DUMP(iwlagn_mac_testmode_dump)
+        .tx_sync = iwlagn_mac_tx_sync,
+        .finish_tx_sync = iwlagn_mac_finish_tx_sync,
+        .set_tim = iwlagn_mac_set_tim,
+};
+
+/* This function both allocates and initializes hw and priv. */
+struct ieee80211_hw *iwl_alloc_all(void)
+{
+        struct iwl_priv *priv;
+        /* mac80211 allocates memory for this device instance, including
+         *   space for this driver's private structure */
+        struct ieee80211_hw *hw;
+
+        hw = ieee80211_alloc_hw(sizeof(struct iwl_priv), &iwlagn_hw_ops);
+        if (!hw)
+                goto out;
+
+        priv = hw->priv;
+        priv->hw = hw;
+
+out:
+        return hw;
+}
diff --git a/drivers/net/wireless/iwlwifi/iwl-pci.c b/drivers/net/wireless/iwlwifi/iwl-pci.c
index 1800029911ad..850ec8e51b17 100644
--- a/drivers/net/wireless/iwlwifi/iwl-pci.c
+++ b/drivers/net/wireless/iwlwifi/iwl-pci.c
@@ -256,6 +256,8 @@ static DEFINE_PCI_DEVICE_TABLE(iwl_hw_card_ids) = {
         {IWL_PCI_DEVICE(0x0082, 0xC020, iwl6005_2agn_sff_cfg)},
         {IWL_PCI_DEVICE(0x0085, 0xC220, iwl6005_2agn_sff_cfg)},
         {IWL_PCI_DEVICE(0x0082, 0x1341, iwl6005_2agn_d_cfg)},
+        {IWL_PCI_DEVICE(0x0082, 0x1304, iwl6005_2agn_cfg)},/* low 5GHz active */
+        {IWL_PCI_DEVICE(0x0082, 0x1305, iwl6005_2agn_cfg)},/* high 5GHz active */
 
 /* 6x30 Series */
         {IWL_PCI_DEVICE(0x008A, 0x5305, iwl1030_bgn_cfg)},
@@ -325,46 +327,28 @@ static DEFINE_PCI_DEVICE_TABLE(iwl_hw_card_ids) = {
         {IWL_PCI_DEVICE(0x0890, 0x4022, iwl2000_2bgn_cfg)},
         {IWL_PCI_DEVICE(0x0891, 0x4222, iwl2000_2bgn_cfg)},
         {IWL_PCI_DEVICE(0x0890, 0x4422, iwl2000_2bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0890, 0x4026, iwl2000_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x0891, 0x4226, iwl2000_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x0890, 0x4426, iwl2000_2bg_cfg)},
         {IWL_PCI_DEVICE(0x0890, 0x4822, iwl2000_2bgn_d_cfg)},
 
 /* 2x30 Series */
         {IWL_PCI_DEVICE(0x0887, 0x4062, iwl2030_2bgn_cfg)},
         {IWL_PCI_DEVICE(0x0888, 0x4262, iwl2030_2bgn_cfg)},
         {IWL_PCI_DEVICE(0x0887, 0x4462, iwl2030_2bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0887, 0x4066, iwl2030_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x0888, 0x4266, iwl2030_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x0887, 0x4466, iwl2030_2bg_cfg)},
 
 /* 6x35 Series */
         {IWL_PCI_DEVICE(0x088E, 0x4060, iwl6035_2agn_cfg)},
         {IWL_PCI_DEVICE(0x088F, 0x4260, iwl6035_2agn_cfg)},
         {IWL_PCI_DEVICE(0x088E, 0x4460, iwl6035_2agn_cfg)},
-        {IWL_PCI_DEVICE(0x088E, 0x4064, iwl6035_2abg_cfg)},
-        {IWL_PCI_DEVICE(0x088F, 0x4264, iwl6035_2abg_cfg)},
-        {IWL_PCI_DEVICE(0x088E, 0x4464, iwl6035_2abg_cfg)},
-        {IWL_PCI_DEVICE(0x088E, 0x4066, iwl6035_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x088F, 0x4266, iwl6035_2bg_cfg)},
-        {IWL_PCI_DEVICE(0x088E, 0x4466, iwl6035_2bg_cfg)},
 
 /* 105 Series */
         {IWL_PCI_DEVICE(0x0894, 0x0022, iwl105_bgn_cfg)},
         {IWL_PCI_DEVICE(0x0895, 0x0222, iwl105_bgn_cfg)},
         {IWL_PCI_DEVICE(0x0894, 0x0422, iwl105_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0894, 0x0026, iwl105_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0895, 0x0226, iwl105_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0894, 0x0426, iwl105_bg_cfg)},
         {IWL_PCI_DEVICE(0x0894, 0x0822, iwl105_bgn_d_cfg)},
 
 /* 135 Series */
         {IWL_PCI_DEVICE(0x0892, 0x0062, iwl135_bgn_cfg)},
         {IWL_PCI_DEVICE(0x0893, 0x0262, iwl135_bgn_cfg)},
         {IWL_PCI_DEVICE(0x0892, 0x0462, iwl135_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0892, 0x0066, iwl135_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0893, 0x0266, iwl135_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0892, 0x0466, iwl135_bg_cfg)},
 
         {0}
 };
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index e5d727f537d0..359d2182757b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -416,6 +416,8 @@ static u16 iwl_limit_dwell(struct iwl_priv *priv, u16 dwell_time)
 
                 if (!iwl_is_associated_ctx(ctx))
                         continue;
+                if (ctx->staging.dev_type == RXON_DEV_TYPE_P2P)
+                        continue;
                 value = ctx->beacon_int;
                 if (!value)
                         value = IWL_PASSIVE_DWELL_BASE;
@@ -678,7 +680,8 @@ static int iwlagn_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif)
                         priv->contexts[IWL_RXON_CTX_BSS].active.flags &
                                                 RXON_FLG_CHANNEL_MODE_MSK)
                                        >> RXON_FLG_CHANNEL_MODE_POS;
-                if (chan_mod == CHANNEL_MODE_PURE_40) {
+                if ((priv->scan_request && priv->scan_request->no_cck) ||
+                    chan_mod == CHANNEL_MODE_PURE_40) {
                         rate = IWL_RATE_6M_PLCP;
                 } else {
                         rate = IWL_RATE_1M_PLCP;
@@ -938,51 +941,6 @@ int __must_check iwl_scan_initiate(struct iwl_priv *priv,
         return 0;
 }
 
-int iwlagn_mac_hw_scan(struct ieee80211_hw *hw,
-                    struct ieee80211_vif *vif,
-                    struct cfg80211_scan_request *req)
-{
-        struct iwl_priv *priv = hw->priv;
-        int ret;
-
-        IWL_DEBUG_MAC80211(priv, "enter\n");
-
-        if (req->n_channels == 0)
-                return -EINVAL;
-
-        mutex_lock(&priv->shrd->mutex);
-
-        /*
-         * If an internal scan is in progress, just set
-         * up the scan_request as per above.
-         */
-        if (priv->scan_type != IWL_SCAN_NORMAL) {
-                IWL_DEBUG_SCAN(priv,
-                               "SCAN request during internal scan - defer\n");
-                priv->scan_request = req;
-                priv->scan_vif = vif;
-                ret = 0;
-        } else {
-                priv->scan_request = req;
-                priv->scan_vif = vif;
-                /*
-                 * mac80211 will only ask for one band at a time
-                 * so using channels[0] here is ok
-                 */
-                ret = iwl_scan_initiate(priv, vif, IWL_SCAN_NORMAL,
-                                        req->channels[0]->band);
-                if (ret) {
-                        priv->scan_request = NULL;
-                        priv->scan_vif = NULL;
-                }
-        }
-
-        IWL_DEBUG_MAC80211(priv, "leave\n");
-
-        mutex_unlock(&priv->shrd->mutex);
-
-        return ret;
-}
 
 /*
  * internal short scan, this function should only been called while associated.
diff --git a/drivers/net/wireless/iwlwifi/iwl-sv-open.c b/drivers/net/wireless/iwlwifi/iwl-sv-open.c
index 5e50d88f302b..e3882d0cfc85 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sv-open.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sv-open.c
@@ -396,8 +396,7 @@ static int iwl_testmode_driver(struct ieee80211_hw *hw, struct nlattr **tb)
                 break;
 
         case IWL_TM_CMD_APP2DEV_LOAD_INIT_FW:
-                status = iwlagn_load_ucode_wait_alive(priv, &priv->ucode_init,
-                                                      IWL_UCODE_INIT);
+                status = iwlagn_load_ucode_wait_alive(priv, IWL_UCODE_INIT);
                 if (status)
                         IWL_DEBUG_INFO(priv,
                                 "Error loading init ucode: %d\n", status);
@@ -409,9 +408,7 @@ static int iwl_testmode_driver(struct ieee80211_hw *hw, struct nlattr **tb)
                 break;
 
         case IWL_TM_CMD_APP2DEV_LOAD_RUNTIME_FW:
-                status = iwlagn_load_ucode_wait_alive(priv,
-                                           &priv->ucode_rt,
-                                           IWL_UCODE_REGULAR);
+                status = iwlagn_load_ucode_wait_alive(priv, IWL_UCODE_REGULAR);
                 if (status) {
                         IWL_DEBUG_INFO(priv,
                                 "Error loading runtime ucode: %d\n", status);
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h
index 2b6756e8b8f9..afaaa2a51b96 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h
@@ -355,7 +355,7 @@ static inline void iwl_set_swq_id(struct iwl_tx_queue *txq, u8 ac, u8 hwq)
 }
 
 static inline void iwl_wake_queue(struct iwl_trans *trans,
-                                  struct iwl_tx_queue *txq)
+                                  struct iwl_tx_queue *txq, const char *msg)
 {
         u8 queue = txq->swq_id;
         u8 ac = queue & 3;
@@ -363,13 +363,22 @@ static inline void iwl_wake_queue(struct iwl_trans *trans,
         struct iwl_trans_pcie *trans_pcie =
                 IWL_TRANS_GET_PCIE_TRANS(trans);
 
-        if (test_and_clear_bit(hwq, trans_pcie->queue_stopped))
-                if (atomic_dec_return(&trans_pcie->queue_stop_count[ac]) <= 0)
+        if (test_and_clear_bit(hwq, trans_pcie->queue_stopped)) {
+                if (atomic_dec_return(&trans_pcie->queue_stop_count[ac]) <= 0) {
                         iwl_wake_sw_queue(priv(trans), ac);
+                        IWL_DEBUG_TX_QUEUES(trans, "Wake hwq %d ac %d. %s",
+                                            hwq, ac, msg);
+                } else {
+                        IWL_DEBUG_TX_QUEUES(trans, "Don't wake hwq %d ac %d"
+                                            " stop count %d. %s",
+                                            hwq, ac, atomic_read(&trans_pcie->
+                                            queue_stop_count[ac]), msg);
+                }
+        }
 }
 
 static inline void iwl_stop_queue(struct iwl_trans *trans,
-                                  struct iwl_tx_queue *txq)
+                                  struct iwl_tx_queue *txq, const char *msg)
 {
         u8 queue = txq->swq_id;
         u8 ac = queue & 3;
@@ -377,9 +386,23 @@ static inline void iwl_stop_queue(struct iwl_trans *trans,
         struct iwl_trans_pcie *trans_pcie =
                 IWL_TRANS_GET_PCIE_TRANS(trans);
 
-        if (!test_and_set_bit(hwq, trans_pcie->queue_stopped))
-                if (atomic_inc_return(&trans_pcie->queue_stop_count[ac]) > 0)
+        if (!test_and_set_bit(hwq, trans_pcie->queue_stopped)) {
+                if (atomic_inc_return(&trans_pcie->queue_stop_count[ac]) > 0) {
                         iwl_stop_sw_queue(priv(trans), ac);
+                        IWL_DEBUG_TX_QUEUES(trans, "Stop hwq %d ac %d"
+                                            " stop count %d. %s",
+                                            hwq, ac, atomic_read(&trans_pcie->
+                                            queue_stop_count[ac]), msg);
+                } else {
+                        IWL_DEBUG_TX_QUEUES(trans, "Don't stop hwq %d ac %d"
+                                            " stop count %d. %s",
+                                            hwq, ac, atomic_read(&trans_pcie->
+                                            queue_stop_count[ac]), msg);
+                }
+        } else {
+                IWL_DEBUG_TX_QUEUES(trans, "stop hwq %d, but it is stopped/ %s",
+                                    hwq, msg);
+        }
 }
 
 #ifdef ieee80211_stop_queue
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
index 374c68cc1d70..ee126f844a5c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
@@ -1108,7 +1108,7 @@ void iwl_irq_tasklet(struct iwl_trans *trans)
                 isr_stats->tx++;
                 handled |= CSR_INT_BIT_FH_TX;
                 /* Wake up uCode load routine, now that load is complete */
-                priv(trans)->ucode_write_complete = 1;
+                trans->ucode_write_complete = 1;
                 wake_up(&trans->shrd->wait_command_queue);
         }
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c
index 4a0c95302a7e..6dba1515023c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c
@@ -430,7 +430,7 @@ void iwl_trans_tx_queue_set_status(struct iwl_trans *trans,
 
         txq->sched_retry = scd_retry;
 
-        IWL_DEBUG_INFO(trans, "%s %s Queue %d on FIFO %d\n",
+        IWL_DEBUG_TX_QUEUES(trans, "%s %s Queue %d on FIFO %d\n",
                        active ? "Activate" : "Deactivate",
                        scd_retry ? "BA" : "AC/CMD", txq_id, tx_fifo_id);
 }
@@ -561,12 +561,13 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans,
 
         tid_data = &trans->shrd->tid_data[sta_id][tid];
         if (tid_data->tfds_in_queue == 0) {
-                IWL_DEBUG_HT(trans, "HW queue is empty\n");
+                IWL_DEBUG_TX_QUEUES(trans, "HW queue is empty\n");
                 tid_data->agg.state = IWL_AGG_ON;
                 iwl_start_tx_ba_trans_ready(priv(trans), ctx, sta_id, tid);
         } else {
-                IWL_DEBUG_HT(trans, "HW queue is NOT empty: %d packets in HW"
-                             "queue\n", tid_data->tfds_in_queue);
+                IWL_DEBUG_TX_QUEUES(trans,
+                                    "HW queue is NOT empty: %d packets in HW"
+                                    " queue\n", tid_data->tfds_in_queue);
                 tid_data->agg.state = IWL_EMPTYING_HW_QUEUE_ADDBA;
         }
         spin_unlock_irqrestore(&trans->shrd->sta_lock, flags);
@@ -643,14 +644,15 @@ int iwl_trans_pcie_tx_agg_disable(struct iwl_trans *trans,
 
         /* The queue is not empty */
         if (write_ptr != read_ptr) {
-                IWL_DEBUG_HT(trans, "Stopping a non empty AGG HW QUEUE\n");
+                IWL_DEBUG_TX_QUEUES(trans,
+                                    "Stopping a non empty AGG HW QUEUE\n");
                 trans->shrd->tid_data[sta_id][tid].agg.state =
                         IWL_EMPTYING_HW_QUEUE_DELBA;
                 spin_unlock_irqrestore(&trans->shrd->sta_lock, flags);
                 return 0;
         }
 
-        IWL_DEBUG_HT(trans, "HW queue is empty\n");
+        IWL_DEBUG_TX_QUEUES(trans, "HW queue is empty\n");
 turn_off:
         trans->shrd->tid_data[sta_id][tid].agg.state = IWL_AGG_OFF;
 
@@ -982,7 +984,8 @@ static int iwl_send_cmd_async(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
 
         ret = iwl_enqueue_hcmd(trans, cmd);
         if (ret < 0) {
-                IWL_ERR(trans, "Error sending %s: enqueue_hcmd failed: %d\n",
+                IWL_DEBUG_QUIET_RFKILL(trans,
+                        "Error sending %s: enqueue_hcmd failed: %d\n",
                           get_cmd_string(cmd->id), ret);
                 return ret;
         }
@@ -1000,6 +1003,20 @@ static int iwl_send_cmd_sync(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
         IWL_DEBUG_INFO(trans, "Attempting to send sync command %s\n",
                         get_cmd_string(cmd->id));
 
+        if (test_bit(STATUS_EXIT_PENDING, &trans->shrd->status))
+                return -EBUSY;
+
+
+        if (test_bit(STATUS_RF_KILL_HW, &trans->shrd->status)) {
+                IWL_ERR(trans, "Command %s aborted: RF KILL Switch\n",
+                               get_cmd_string(cmd->id));
+                return -ECANCELED;
+        }
+        if (test_bit(STATUS_FW_ERROR, &trans->shrd->status)) {
+                IWL_ERR(trans, "Command %s failed: FW Error\n",
+                               get_cmd_string(cmd->id));
+                return -EIO;
+        }
         set_bit(STATUS_HCMD_ACTIVE, &trans->shrd->status);
         IWL_DEBUG_INFO(trans, "Setting HCMD_ACTIVE for command %s\n",
                         get_cmd_string(cmd->id));
@@ -1008,7 +1025,8 @@ static int iwl_send_cmd_sync(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
         if (cmd_idx < 0) {
                 ret = cmd_idx;
                 clear_bit(STATUS_HCMD_ACTIVE, &trans->shrd->status);
-                IWL_ERR(trans, "Error sending %s: enqueue_hcmd failed: %d\n",
+                IWL_DEBUG_QUIET_RFKILL(trans,
+                        "Error sending %s: enqueue_hcmd failed: %d\n",
                           get_cmd_string(cmd->id), ret);
                 return ret;
         }
@@ -1022,12 +1040,12 @@ static int iwl_send_cmd_sync(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
                                 &trans_pcie->txq[trans->shrd->cmd_queue];
                         struct iwl_queue *q = &txq->q;
 
-                        IWL_ERR(trans,
+                        IWL_DEBUG_QUIET_RFKILL(trans,
                                 "Error sending %s: time out after %dms.\n",
                                 get_cmd_string(cmd->id),
                                 jiffies_to_msecs(HOST_COMPLETE_TIMEOUT));
 
-                        IWL_ERR(trans,
+                        IWL_DEBUG_QUIET_RFKILL(trans,
                                 "Current CMD queue read_ptr %d write_ptr %d\n",
                                 q->read_ptr, q->write_ptr);
 
@@ -1039,18 +1057,6 @@ static int iwl_send_cmd_sync(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
                 }
         }
 
-        if (test_bit(STATUS_RF_KILL_HW, &trans->shrd->status)) {
-                IWL_ERR(trans, "Command %s aborted: RF KILL Switch\n",
-                               get_cmd_string(cmd->id));
-                ret = -ECANCELED;
-                goto fail;
-        }
-        if (test_bit(STATUS_FW_ERROR, &trans->shrd->status)) {
-                IWL_ERR(trans, "Command %s failed: FW Error\n",
-                               get_cmd_string(cmd->id));
-                ret = -EIO;
-                goto fail;
-        }
         if ((cmd->flags & CMD_WANT_SKB) && !cmd->reply_page) {
                 IWL_ERR(trans, "Error: Response NULL in '%s'\n",
                           get_cmd_string(cmd->id));
@@ -1071,7 +1077,7 @@ cancel:
                 trans_pcie->txq[trans->shrd->cmd_queue].meta[cmd_idx].flags &=
                                                         ~CMD_WANT_SKB;
         }
-fail:
+
         if (cmd->reply_page) {
                 iwl_free_pages(trans->shrd, cmd->reply_page);
                 cmd->reply_page = 0;
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
index ce918980e977..93c4f56ac408 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
@@ -1232,7 +1232,7 @@ static int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb,
                         txq->need_update = 1;
                         iwl_txq_update_write_ptr(trans, txq);
                 } else {
-                        iwl_stop_queue(trans, txq);
+                        iwl_stop_queue(trans, txq, "Queue is full");
                 }
         }
         return 0;
@@ -1284,20 +1284,21 @@ static int iwlagn_txq_check_empty(struct iwl_trans *trans,
                 /* aggregated HW queue */
                 if ((txq_id  == tid_data->agg.txq_id) &&
                     (q->read_ptr == q->write_ptr)) {
-                        IWL_DEBUG_HT(trans,
+                        IWL_DEBUG_TX_QUEUES(trans,
                                 "HW queue empty: continue DELBA flow\n");
                         iwl_trans_pcie_txq_agg_disable(trans, txq_id);
                         tid_data->agg.state = IWL_AGG_OFF;
                         iwl_stop_tx_ba_trans_ready(priv(trans),
                                                    NUM_IWL_RXON_CTX,
                                                    sta_id, tid);
-                        iwl_wake_queue(trans, &trans_pcie->txq[txq_id]);
+                        iwl_wake_queue(trans, &trans_pcie->txq[txq_id],
+                                       "DELBA flow complete");
                 }
                 break;
         case IWL_EMPTYING_HW_QUEUE_ADDBA:
                 /* We are reclaiming the last packet of the queue */
                 if (tid_data->tfds_in_queue == 0) {
-                        IWL_DEBUG_HT(trans,
+                        IWL_DEBUG_TX_QUEUES(trans,
                                 "HW queue empty: continue ADDBA flow\n");
                         tid_data->agg.state = IWL_AGG_ON;
                         iwl_start_tx_ba_trans_ready(priv(trans),
@@ -1355,7 +1356,7 @@ static void iwl_trans_pcie_reclaim(struct iwl_trans *trans, int sta_id, int tid,
                                 ssn , tfd_num, txq_id, txq->swq_id);
                 freed = iwl_tx_queue_reclaim(trans, txq_id, tfd_num, skbs);
                 if (iwl_queue_space(&txq->q) > txq->q.low_mark && cond)
-                        iwl_wake_queue(trans, txq);
+                        iwl_wake_queue(trans, txq, "Packets reclaimed");
         }
 
         iwl_free_tfds_in_queue(trans, sta_id, tid, freed);
@@ -1419,7 +1420,8 @@ static int iwl_trans_pcie_resume(struct iwl_trans *trans)
 #endif /* CONFIG_PM_SLEEP */
 
 static void iwl_trans_pcie_wake_any_queue(struct iwl_trans *trans,
-                                          enum iwl_rxon_context_id ctx)
+                                          enum iwl_rxon_context_id ctx,
+                                          const char *msg)
 {
         u8 ac, txq_id;
         struct iwl_trans_pcie *trans_pcie =
@@ -1427,11 +1429,11 @@ static void iwl_trans_pcie_wake_any_queue(struct iwl_trans *trans,
 
         for (ac = 0; ac < AC_NUM; ac++) {
                 txq_id = trans_pcie->ac_to_queue[ctx][ac];
-                IWL_DEBUG_INFO(trans, "Queue Status: Q[%d] %s\n",
+                IWL_DEBUG_TX_QUEUES(trans, "Queue Status: Q[%d] %s\n",
                         ac,
                         (atomic_read(&trans_pcie->queue_stop_count[ac]) > 0)
                               ? "stopped" : "awake");
-                iwl_wake_queue(trans, &trans_pcie->txq[txq_id]);
+                iwl_wake_queue(trans, &trans_pcie->txq[txq_id], msg);
         }
 }
 
@@ -1454,11 +1456,12 @@ static struct iwl_trans *iwl_trans_pcie_alloc(struct iwl_shared *shrd)
         return iwl_trans;
 }
 
-static void iwl_trans_pcie_stop_queue(struct iwl_trans *trans, int txq_id)
+static void iwl_trans_pcie_stop_queue(struct iwl_trans *trans, int txq_id,
+                                      const char *msg)
 {
         struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);
 
-        iwl_stop_queue(trans, &trans_pcie->txq[txq_id]);
+        iwl_stop_queue(trans, &trans_pcie->txq[txq_id], msg);
 }
 
 #define IWL_FLUSH_WAIT_MS       2000
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.h b/drivers/net/wireless/iwlwifi/iwl-trans.h
index c5923125c3f9..50227ebc0ee2 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans.h
+++ b/drivers/net/wireless/iwlwifi/iwl-trans.h
@@ -171,7 +171,8 @@ struct iwl_trans_ops {
         void (*tx_start)(struct iwl_trans *trans);
 
         void (*wake_any_queue)(struct iwl_trans *trans,
-                               enum iwl_rxon_context_id ctx);
+                               enum iwl_rxon_context_id ctx,
+                               const char *msg);
 
         int (*send_cmd)(struct iwl_trans *trans, struct iwl_host_cmd *cmd);
 
@@ -196,7 +197,7 @@ struct iwl_trans_ops {
 
         void (*free)(struct iwl_trans *trans);
 
-        void (*stop_queue)(struct iwl_trans *trans, int q);
+        void (*stop_queue)(struct iwl_trans *trans, int q, const char *msg);
 
         int (*dbgfs_register)(struct iwl_trans *trans, struct dentry* dir);
         int (*check_stuck_queue)(struct iwl_trans *trans, int q);
@@ -207,17 +208,48 @@ struct iwl_trans_ops {
 #endif
 };
 
+/* one for each uCode image (inst/data, boot/init/runtime) */
+struct fw_desc {
+        dma_addr_t p_addr;      /* hardware address */
+        void *v_addr;           /* software address */
+        u32 len;                /* size in bytes */
+};
+
+struct fw_img {
+        struct fw_desc code;    /* firmware code image */
+        struct fw_desc data;    /* firmware data image */
+};
+
+enum iwl_ucode_type {
+        IWL_UCODE_NONE,
+        IWL_UCODE_REGULAR,
+        IWL_UCODE_INIT,
+        IWL_UCODE_WOWLAN,
+};
+
 /**
  * struct iwl_trans - transport common data
  * @ops - pointer to iwl_trans_ops
  * @shrd - pointer to iwl_shared which holds shared data from the upper layer
  * @hcmd_lock: protects HCMD
+ * @ucode_write_complete: indicates that the ucode has been copied.
+ * @ucode_rt: run time ucode image
+ * @ucode_init: init ucode image
+ * @ucode_wowlan: wake on wireless ucode image (optional)
  */
 struct iwl_trans {
         const struct iwl_trans_ops *ops;
         struct iwl_shared *shrd;
         spinlock_t hcmd_lock;
 
+        u8 ucode_write_complete;        /* the image write is complete */
+        struct fw_img ucode_rt;
+        struct fw_img ucode_init;
+        struct fw_img ucode_wowlan;
+
+        /* eeprom related variables */
+        int    nvm_device_type;
+
         /* pointer to trans specific struct */
         /*Ensure that this pointer will always be aligned to sizeof pointer */
         char trans_specific[0] __attribute__((__aligned__(sizeof(void *))));
@@ -249,9 +281,10 @@ static inline void iwl_trans_tx_start(struct iwl_trans *trans)
 }
 
 static inline void iwl_trans_wake_any_queue(struct iwl_trans *trans,
-                                            enum iwl_rxon_context_id ctx)
+                                            enum iwl_rxon_context_id ctx,
+                                            const char *msg)
 {
-        trans->ops->wake_any_queue(trans, ctx);
+        trans->ops->wake_any_queue(trans, ctx, msg);
 }
 
 
@@ -311,9 +344,10 @@ static inline void iwl_trans_free(struct iwl_trans *trans)
         trans->ops->free(trans);
 }
 
-static inline void iwl_trans_stop_queue(struct iwl_trans *trans, int q)
+static inline void iwl_trans_stop_queue(struct iwl_trans *trans, int q,
+                                        const char *msg)
 {
-        trans->ops->stop_queue(trans, q);
+        trans->ops->stop_queue(trans, q, msg);
 }
 
 static inline int iwl_trans_wait_tx_queue_empty(struct iwl_trans *trans)
@@ -348,4 +382,8 @@ static inline int iwl_trans_resume(struct iwl_trans *trans)
 ******************************************************/
 extern const struct iwl_trans_ops trans_ops_pcie;
 
+int iwl_alloc_fw_desc(struct iwl_bus *bus, struct fw_desc *desc,
+                      const void *data, size_t len);
+void iwl_dealloc_ucode(struct iwl_trans *trans);
+
 #endif /* __iwl_trans_h__ */
diff --git a/drivers/net/wireless/iwmc3200wifi/cfg80211.c b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
index c42be81e979e..48e8218fd23b 100644
--- a/drivers/net/wireless/iwmc3200wifi/cfg80211.c
+++ b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
@@ -165,11 +165,15 @@ static int iwm_cfg80211_add_key(struct wiphy *wiphy, struct net_device *ndev,
                                 struct key_params *params)
 {
         struct iwm_priv *iwm = ndev_to_iwm(ndev);
-        struct iwm_key *key = &iwm->keys[key_index];
+        struct iwm_key *key;
         int ret;
 
         IWM_DBG_WEXT(iwm, DBG, "Adding key for %pM\n", mac_addr);
 
+        if (key_index >= IWM_NUM_KEYS)
+                return -ENOENT;
+
+        key = &iwm->keys[key_index];
         memset(key, 0, sizeof(struct iwm_key));
         ret = iwm_key_init(key, key_index, mac_addr, params);
         if (ret < 0) {
@@ -214,8 +218,12 @@ static int iwm_cfg80211_del_key(struct wiphy *wiphy, struct net_device *ndev,
                                 u8 key_index, bool pairwise, const u8 *mac_addr)
 {
         struct iwm_priv *iwm = ndev_to_iwm(ndev);
-        struct iwm_key *key = &iwm->keys[key_index];
+        struct iwm_key *key;
 
+        if (key_index >= IWM_NUM_KEYS)
+                return -ENOENT;
+
+        key = &iwm->keys[key_index];
         if (!iwm->keys[key_index].key_len) {
                 IWM_DBG_WEXT(iwm, DBG, "Key %d not used\n", key_index);
                 return 0;
@@ -236,6 +244,9 @@ static int iwm_cfg80211_set_default_key(struct wiphy *wiphy,
 
         IWM_DBG_WEXT(iwm, DBG, "Default key index is: %d\n", key_index);
 
+        if (key_index >= IWM_NUM_KEYS)
+                return -ENOENT;
+
         if (!iwm->keys[key_index].key_len) {
                 IWM_ERR(iwm, "Key %d not used\n", key_index);
                 return -EINVAL;
diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
index a7f1ab28940d..d1d84e0e30fc 100644
--- a/drivers/net/wireless/libertas/cfg.c
+++ b/drivers/net/wireless/libertas/cfg.c
@@ -485,6 +485,7 @@ static int lbs_cfg_set_channel(struct wiphy *wiphy,
 static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
         struct cmd_header *resp)
 {
+        struct cfg80211_bss *bss;
         struct cmd_ds_802_11_scan_rsp *scanresp = (void *)resp;
         int bsssize;
         const u8 *pos;
@@ -632,12 +633,14 @@ static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
                                      LBS_SCAN_RSSI_TO_MBM(rssi)/100);
 
                         if (channel &&
-                            !(channel->flags & IEEE80211_CHAN_DISABLED))
-                                cfg80211_inform_bss(wiphy, channel,
+                            !(channel->flags & IEEE80211_CHAN_DISABLED)) {
+                                bss = cfg80211_inform_bss(wiphy, channel,
                                         bssid, get_unaligned_le64(tsfdesc),
                                         capa, intvl, ie, ielen,
                                         LBS_SCAN_RSSI_TO_MBM(rssi),
                                         GFP_KERNEL);
+                                cfg80211_put_bss(bss);
+                        }
                 } else
                         lbs_deb_scan("scan response: missing BSS channel IE\n");
 
@@ -1720,6 +1723,7 @@ static void lbs_join_post(struct lbs_private *priv,
                    2 + 2 +                      /* atim */
                    2 + 8];                      /* extended rates */
         u8 *fake = fake_ie;
+        struct cfg80211_bss *bss;
 
         lbs_deb_enter(LBS_DEB_CFG80211);
 
@@ -1763,14 +1767,15 @@ static void lbs_join_post(struct lbs_private *priv,
         *fake++ = 0x6c;
         lbs_deb_hex(LBS_DEB_CFG80211, "IE", fake_ie, fake - fake_ie);
 
-        cfg80211_inform_bss(priv->wdev->wiphy,
-                            params->channel,
-                            bssid,
-                            0,
-                            capability,
-                            params->beacon_interval,
-                            fake_ie, fake - fake_ie,
-                            0, GFP_KERNEL);
+        bss = cfg80211_inform_bss(priv->wdev->wiphy,
+                                  params->channel,
+                                  bssid,
+                                  0,
+                                  capability,
+                                  params->beacon_interval,
+                                  fake_ie, fake - fake_ie,
+                                  0, GFP_KERNEL);
+        cfg80211_put_bss(bss);
 
         memcpy(priv->wdev->ssid, params->ssid, params->ssid_len);
         priv->wdev->ssid_len = params->ssid_len;
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 523ad55a2885..6cf6d6d25e21 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -1748,6 +1748,8 @@ static int __init init_mac80211_hwsim(void)
                             IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS |
                             IEEE80211_HW_AMPDU_AGGREGATION;
 
+                hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS;
+
                 /* ask mac80211 to reserve space for magic */
                 hw->vif_data_size = sizeof(struct hwsim_vif_priv);
                 hw->sta_data_size = sizeof(struct hwsim_sta_priv);
diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c b/drivers/net/wireless/mwifiex/11n_rxreorder.c
index 7aa9aa0ac958..681d3f2a4c28 100644
--- a/drivers/net/wireless/mwifiex/11n_rxreorder.c
+++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c
@@ -33,7 +33,7 @@
  * Since the buffer is linear, the function uses rotation to simulate
  * circular buffer.
  */
-static int
+static void
 mwifiex_11n_dispatch_pkt_until_start_win(struct mwifiex_private *priv,
                                          struct mwifiex_rx_reorder_tbl
                                          *rx_reor_tbl_ptr, int start_win)
@@ -71,8 +71,6 @@ mwifiex_11n_dispatch_pkt_until_start_win(struct mwifiex_private *priv,
 
         rx_reor_tbl_ptr->start_win = start_win;
         spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
-
-        return 0;
 }
 
 /*
@@ -83,7 +81,7 @@ mwifiex_11n_dispatch_pkt_until_start_win(struct mwifiex_private *priv,
  * Since the buffer is linear, the function uses rotation to simulate
  * circular buffer.
  */
-static int
+static void
 mwifiex_11n_scan_and_dispatch(struct mwifiex_private *priv,
                               struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr)
 {
@@ -119,7 +117,6 @@ mwifiex_11n_scan_and_dispatch(struct mwifiex_private *priv,
         rx_reor_tbl_ptr->start_win = (rx_reor_tbl_ptr->start_win + i)
                 &(MAX_TID_VALUE - 1);
         spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
-        return 0;
 }
 
 /*
@@ -405,7 +402,7 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
                                 u8 *ta, u8 pkt_type, void *payload)
 {
         struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr;
-        int start_win, end_win, win_size, ret;
+        int start_win, end_win, win_size;
         u16 pkt_index;
 
         rx_reor_tbl_ptr =
@@ -452,11 +449,8 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
                         start_win = (end_win - win_size) + 1;
                 else
                         start_win = (MAX_TID_VALUE - (win_size - seq_num)) + 1;
-                ret = mwifiex_11n_dispatch_pkt_until_start_win(priv,
+                mwifiex_11n_dispatch_pkt_until_start_win(priv,
                                                 rx_reor_tbl_ptr, start_win);
-
-                if (ret)
-                        return ret;
         }
 
         if (pkt_type != PKT_TYPE_BAR) {
@@ -475,9 +469,9 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
          * Dispatch all packets sequentially from start_win until a
          * hole is found and adjust the start_win appropriately
          */
-        ret = mwifiex_11n_scan_and_dispatch(priv, rx_reor_tbl_ptr);
+        mwifiex_11n_scan_and_dispatch(priv, rx_reor_tbl_ptr);
 
-        return ret;
+        return 0;
 }
 
 /*
diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
index 462c71067bfb..e9ab9a3fbe9c 100644
--- a/drivers/net/wireless/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/mwifiex/cfg80211.c
@@ -780,6 +780,7 @@ static int mwifiex_cfg80211_inform_ibss_bss(struct mwifiex_private *priv)
 {
         struct ieee80211_channel *chan;
         struct mwifiex_bss_info bss_info;
+        struct cfg80211_bss *bss;
         int ie_len;
         u8 ie_buf[IEEE80211_MAX_SSID_LEN + sizeof(struct ieee_types_header)];
         enum ieee80211_band band;
@@ -800,9 +801,10 @@ static int mwifiex_cfg80211_inform_ibss_bss(struct mwifiex_private *priv)
                         ieee80211_channel_to_frequency(bss_info.bss_chan,
                                                        band));
 
-        cfg80211_inform_bss(priv->wdev->wiphy, chan,
+        bss = cfg80211_inform_bss(priv->wdev->wiphy, chan,
                 bss_info.bssid, 0, WLAN_CAPABILITY_IBSS,
                 0, ie_buf, ie_len, 0, GFP_KERNEL);
+        cfg80211_put_bss(bss);
         memcpy(priv->cfg_bssid, bss_info.bssid, ETH_ALEN);
 
         return 0;
diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h
index 0cc5d73cb0c1..35cb29cbd96e 100644
--- a/drivers/net/wireless/mwifiex/fw.h
+++ b/drivers/net/wireless/mwifiex/fw.h
@@ -673,7 +673,7 @@ struct host_cmd_ds_802_11_ad_hoc_start {
         union ieee_types_phy_param_set phy_param_set;
         u16 reserved1;
         __le16 cap_info_bitmap;
-        u8 DataRate[HOSTCMD_SUPPORTED_RATES];
+        u8 data_rate[HOSTCMD_SUPPORTED_RATES];
 } __packed;
 
 struct host_cmd_ds_802_11_ad_hoc_result {
diff --git a/drivers/net/wireless/mwifiex/init.c b/drivers/net/wireless/mwifiex/init.c
index d792b3fb7c16..26940455255b 100644
--- a/drivers/net/wireless/mwifiex/init.c
+++ b/drivers/net/wireless/mwifiex/init.c
@@ -187,8 +187,6 @@ static void mwifiex_init_adapter(struct mwifiex_adapter *adapter)
         struct mwifiex_opt_sleep_confirm *sleep_cfm_buf = NULL;
 
         skb_put(adapter->sleep_cfm, sizeof(struct mwifiex_opt_sleep_confirm));
-        sleep_cfm_buf = (struct mwifiex_opt_sleep_confirm *)
-                                                (adapter->sleep_cfm->data);
 
         adapter->cmd_sent = false;
 
@@ -254,6 +252,8 @@ static void mwifiex_init_adapter(struct mwifiex_adapter *adapter)
         mwifiex_wmm_init(adapter);
 
         if (adapter->sleep_cfm) {
+                sleep_cfm_buf = (struct mwifiex_opt_sleep_confirm *)
+                                                adapter->sleep_cfm->data;
                 memset(sleep_cfm_buf, 0, adapter->sleep_cfm->len);
                 sleep_cfm_buf->command =
                                 cpu_to_le16(HostCmd_CMD_802_11_PS_MODE_ENH);
diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c
index 62b4c2938608..1c4981367e50 100644
--- a/drivers/net/wireless/mwifiex/join.c
+++ b/drivers/net/wireless/mwifiex/join.c
@@ -724,8 +724,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
         u32 cmd_append_size = 0;
         u32 i;
         u16 tmp_cap;
-        uint16_t ht_cap_info;
         struct mwifiex_ie_types_chan_list_param_set *chan_tlv;
+        u8 radio_type;
 
         struct mwifiex_ie_types_htcap *ht_cap;
         struct mwifiex_ie_types_htinfo *ht_info;
@@ -837,8 +837,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
                 bss_desc->privacy = MWIFIEX_802_11_PRIV_FILTER_ACCEPT_ALL;
         }
 
-        memset(adhoc_start->DataRate, 0, sizeof(adhoc_start->DataRate));
-        mwifiex_get_active_data_rates(priv, adhoc_start->DataRate);
+        memset(adhoc_start->data_rate, 0, sizeof(adhoc_start->data_rate));
+        mwifiex_get_active_data_rates(priv, adhoc_start->data_rate);
         if ((adapter->adhoc_start_band & BAND_G) &&
             (priv->curr_pkt_filter & HostCmd_ACT_MAC_ADHOC_G_PROTECTION_ON)) {
                 if (mwifiex_send_cmd_async(priv, HostCmd_CMD_MAC_CONTROL,
@@ -850,20 +850,19 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
                 }
         }
         /* Find the last non zero */
-        for (i = 0; i < sizeof(adhoc_start->DataRate) &&
-                        adhoc_start->DataRate[i];
-                        i++)
-                        ;
+        for (i = 0; i < sizeof(adhoc_start->data_rate); i++)
+                if (!adhoc_start->data_rate[i])
+                        break;
 
         priv->curr_bss_params.num_of_rates = i;
 
         /* Copy the ad-hoc creating rates into Current BSS rate structure */
         memcpy(&priv->curr_bss_params.data_rates,
-               &adhoc_start->DataRate, priv->curr_bss_params.num_of_rates);
+               &adhoc_start->data_rate, priv->curr_bss_params.num_of_rates);
 
         dev_dbg(adapter->dev, "info: ADHOC_S_CMD: rates=%02x %02x %02x %02x\n",
-               adhoc_start->DataRate[0], adhoc_start->DataRate[1],
-               adhoc_start->DataRate[2], adhoc_start->DataRate[3]);
+               adhoc_start->data_rate[0], adhoc_start->data_rate[1],
+               adhoc_start->data_rate[2], adhoc_start->data_rate[3]);
 
         dev_dbg(adapter->dev, "info: ADHOC_S_CMD: AD-HOC Start command is ready\n");
 
@@ -914,55 +913,40 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
         }
 
         if (adapter->adhoc_11n_enabled) {
-                {
-                        ht_cap = (struct mwifiex_ie_types_htcap *) pos;
-                        memset(ht_cap, 0,
-                               sizeof(struct mwifiex_ie_types_htcap));
-                        ht_cap->header.type =
-                                cpu_to_le16(WLAN_EID_HT_CAPABILITY);
-                        ht_cap->header.len =
-                               cpu_to_le16(sizeof(struct ieee80211_ht_cap));
-                        ht_cap_info = le16_to_cpu(ht_cap->ht_cap.cap_info);
-
-                        ht_cap_info |= IEEE80211_HT_CAP_SGI_20;
-                        if (adapter->chan_offset) {
-                                ht_cap_info |= IEEE80211_HT_CAP_SGI_40;
-                                ht_cap_info |= IEEE80211_HT_CAP_DSSSCCK40;
-                                ht_cap_info |= IEEE80211_HT_CAP_SUP_WIDTH_20_40;
-                                SETHT_MCS32(ht_cap->ht_cap.mcs.rx_mask);
-                        }
+                /* Fill HT CAPABILITY */
+                ht_cap = (struct mwifiex_ie_types_htcap *) pos;
+                memset(ht_cap, 0, sizeof(struct mwifiex_ie_types_htcap));
+                ht_cap->header.type = cpu_to_le16(WLAN_EID_HT_CAPABILITY);
+                ht_cap->header.len =
+                       cpu_to_le16(sizeof(struct ieee80211_ht_cap));
+                radio_type = mwifiex_band_to_radio_type(
+                                        priv->adapter->config_bands);
+                mwifiex_fill_cap_info(priv, radio_type, ht_cap);
+
+                pos += sizeof(struct mwifiex_ie_types_htcap);
+                cmd_append_size +=
+                        sizeof(struct mwifiex_ie_types_htcap);
 
-                        ht_cap->ht_cap.ampdu_params_info
-                                        = IEEE80211_HT_MAX_AMPDU_64K;
-                        ht_cap->ht_cap.mcs.rx_mask[0] = 0xff;
-                        pos += sizeof(struct mwifiex_ie_types_htcap);
-                        cmd_append_size +=
-                                sizeof(struct mwifiex_ie_types_htcap);
-                }
-                {
-                        ht_info = (struct mwifiex_ie_types_htinfo *) pos;
-                        memset(ht_info, 0,
-                               sizeof(struct mwifiex_ie_types_htinfo));
-                        ht_info->header.type =
-                                cpu_to_le16(WLAN_EID_HT_INFORMATION);
-                        ht_info->header.len =
-                                cpu_to_le16(sizeof(struct ieee80211_ht_info));
-                        ht_info->ht_info.control_chan =
-                                (u8) priv->curr_bss_params.bss_descriptor.
-                                channel;
-                        if (adapter->chan_offset) {
-                                ht_info->ht_info.ht_param =
-                                        adapter->chan_offset;
-                                ht_info->ht_info.ht_param |=
+                /* Fill HT INFORMATION */
+                ht_info = (struct mwifiex_ie_types_htinfo *) pos;
+                memset(ht_info, 0, sizeof(struct mwifiex_ie_types_htinfo));
+                ht_info->header.type = cpu_to_le16(WLAN_EID_HT_INFORMATION);
+                ht_info->header.len =
+                        cpu_to_le16(sizeof(struct ieee80211_ht_info));
+
+                ht_info->ht_info.control_chan =
+                        (u8) priv->curr_bss_params.bss_descriptor.channel;
+                if (adapter->chan_offset) {
+                        ht_info->ht_info.ht_param = adapter->chan_offset;
+                        ht_info->ht_info.ht_param |=
                                         IEEE80211_HT_PARAM_CHAN_WIDTH_ANY;
-                        }
-                        ht_info->ht_info.operation_mode =
-                             cpu_to_le16(IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT);
-                        ht_info->ht_info.basic_set[0] = 0xff;
-                        pos += sizeof(struct mwifiex_ie_types_htinfo);
-                        cmd_append_size +=
-                                sizeof(struct mwifiex_ie_types_htinfo);
                 }
+                ht_info->ht_info.operation_mode =
+                     cpu_to_le16(IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT);
+                ht_info->ht_info.basic_set[0] = 0xff;
+                pos += sizeof(struct mwifiex_ie_types_htinfo);
+                cmd_append_size +=
+                        sizeof(struct mwifiex_ie_types_htinfo);
         }
 
         cmd->size = cpu_to_le16((u16)
diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
index d34acf082d3a..a2f32008f9a8 100644
--- a/drivers/net/wireless/mwifiex/pcie.c
+++ b/drivers/net/wireless/mwifiex/pcie.c
@@ -386,7 +386,6 @@ static int mwifiex_pcie_create_txbd_ring(struct mwifiex_adapter *adapter)
         card->txbd_ring_vbase = kzalloc(card->txbd_ring_size, GFP_KERNEL);
         if (!card->txbd_ring_vbase) {
                 dev_err(adapter->dev, "Unable to allocate buffer for txbd ring.\n");
-                kfree(card->txbd_ring_vbase);
                 return -1;
         }
         card->txbd_ring_pbase = virt_to_phys(card->txbd_ring_vbase);
@@ -1229,9 +1228,12 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter,
         if (!skb)
                 return 0;
 
-        if (rdptr >= MWIFIEX_MAX_EVT_BD)
+        if (rdptr >= MWIFIEX_MAX_EVT_BD) {
                 dev_err(adapter->dev, "event_complete: Invalid rdptr 0x%x\n",
                                         rdptr);
+                ret = -EINVAL;
+                goto done;
+        }
 
         /* Read the event ring write pointer set by firmware */
         if (mwifiex_read_reg(adapter, REG_EVTBD_WRPTR, &wrptr)) {
@@ -1672,9 +1674,8 @@ static int mwifiex_pcie_host_to_card(struct mwifiex_adapter *adapter, u8 type,
                                      struct sk_buff *skb,
                                      struct mwifiex_tx_param *tx_param)
 {
-        if (!adapter || !skb) {
-                dev_err(adapter->dev, "Invalid parameter in %s <%p, %p>\n",
-                                __func__, adapter, skb);
+        if (!skb) {
+                dev_err(adapter->dev, "Passed NULL skb to %s\n", __func__);
                 return -1;
         }
 
diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
index 8d3ab378662b..b8b9d37b01a9 100644
--- a/drivers/net/wireless/mwifiex/scan.c
+++ b/drivers/net/wireless/mwifiex/scan.c
@@ -1537,11 +1537,6 @@ done:
         return 0;
 }
 
-static void mwifiex_free_bss_priv(struct cfg80211_bss *bss)
-{
-        kfree(bss->priv);
-}
-
 /*
  * This function handles the command response of scan.
  *
@@ -1767,7 +1762,7 @@ int mwifiex_ret_802_11_scan(struct mwifiex_private *priv,
                                               cap_info_bitmap, beacon_period,
                                               ie_buf, ie_len, rssi, GFP_KERNEL);
                                 *(u8 *)bss->priv = band;
-                                bss->free_priv = mwifiex_free_bss_priv;
+                                cfg80211_put_bss(bss);
 
                                 if (priv->media_connected && !memcmp(bssid,
                                         priv->curr_bss_params.bss_descriptor
diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
index 283171bbcedf..ffaf3f3a57df 100644
--- a/drivers/net/wireless/mwifiex/sdio.c
+++ b/drivers/net/wireless/mwifiex/sdio.c
@@ -1630,14 +1630,14 @@ static int mwifiex_init_sdio(struct mwifiex_adapter *adapter)
         card->mpa_tx.pkt_cnt = 0;
         card->mpa_tx.start_port = 0;
 
-        card->mpa_tx.enabled = 0;
+        card->mpa_tx.enabled = 1;
         card->mpa_tx.pkt_aggr_limit = SDIO_MP_AGGR_DEF_PKT_LIMIT;
 
         card->mpa_rx.buf_len = 0;
         card->mpa_rx.pkt_cnt = 0;
         card->mpa_rx.start_port = 0;
 
-        card->mpa_rx.enabled = 0;
+        card->mpa_rx.enabled = 1;
         card->mpa_rx.pkt_aggr_limit = SDIO_MP_AGGR_DEF_PKT_LIMIT;
 
         /* Allocate buffers for SDIO MP-A */
diff --git a/drivers/net/wireless/mwifiex/sta_rx.c b/drivers/net/wireless/mwifiex/sta_rx.c
index 27430512f7cd..5e1ef7e5da4f 100644
--- a/drivers/net/wireless/mwifiex/sta_rx.c
+++ b/drivers/net/wireless/mwifiex/sta_rx.c
@@ -126,6 +126,9 @@ int mwifiex_process_sta_rx_packet(struct mwifiex_adapter *adapter,
         u16 rx_pkt_type;
         struct mwifiex_private *priv = adapter->priv[rx_info->bss_index];
 
+        if (!priv)
+                return -1;
+
         local_rx_pd = (struct rxpd *) (skb->data);
         rx_pkt_type = local_rx_pd->rx_pkt_type;
 
@@ -189,12 +192,11 @@ int mwifiex_process_sta_rx_packet(struct mwifiex_adapter *adapter,
                                              (u8) local_rx_pd->rx_pkt_type,
                                              skb);
 
-        if (ret || (rx_pkt_type == PKT_TYPE_BAR)) {
-                if (priv && (ret == -1))
-                        priv->stats.rx_dropped++;
-
+        if (ret || (rx_pkt_type == PKT_TYPE_BAR))
                 dev_kfree_skb_any(skb);
-        }
+
+        if (ret)
+                priv->stats.rx_dropped++;
 
         return ret;
 }
diff --git a/drivers/net/wireless/orinoco/scan.c b/drivers/net/wireless/orinoco/scan.c
index e99ca1c1e0d8..96e39edfec77 100644
--- a/drivers/net/wireless/orinoco/scan.c
+++ b/drivers/net/wireless/orinoco/scan.c
@@ -76,6 +76,7 @@ static void orinoco_add_hostscan_result(struct orinoco_private *priv,
 {
         struct wiphy *wiphy = priv_to_wiphy(priv);
         struct ieee80211_channel *channel;
+        struct cfg80211_bss *cbss;
         u8 *ie;
         u8 ie_buf[46];
         u64 timestamp;
@@ -121,9 +122,10 @@ static void orinoco_add_hostscan_result(struct orinoco_private *priv,
         beacon_interval = le16_to_cpu(bss->a.beacon_interv);
         signal = SIGNAL_TO_MBM(le16_to_cpu(bss->a.level));
 
-        cfg80211_inform_bss(wiphy, channel, bss->a.bssid, timestamp,
-                            capability, beacon_interval, ie_buf, ie_len,
-                            signal, GFP_KERNEL);
+        cbss = cfg80211_inform_bss(wiphy, channel, bss->a.bssid, timestamp,
+                                   capability, beacon_interval, ie_buf, ie_len,
+                                   signal, GFP_KERNEL);
+        cfg80211_put_bss(cbss);
 }
 
 void orinoco_add_extscan_result(struct orinoco_private *priv,
@@ -132,6 +134,7 @@ void orinoco_add_extscan_result(struct orinoco_private *priv,
 {
         struct wiphy *wiphy = priv_to_wiphy(priv);
         struct ieee80211_channel *channel;
+        struct cfg80211_bss *cbss;
         const u8 *ie;
         u64 timestamp;
         s32 signal;
@@ -152,9 +155,10 @@ void orinoco_add_extscan_result(struct orinoco_private *priv,
         ie = bss->data;
         signal = SIGNAL_TO_MBM(bss->level);
 
-        cfg80211_inform_bss(wiphy, channel, bss->bssid, timestamp,
-                            capability, beacon_interval, ie, ie_len,
-                            signal, GFP_KERNEL);
+        cbss = cfg80211_inform_bss(wiphy, channel, bss->bssid, timestamp,
+                                   capability, beacon_interval, ie, ie_len,
+                                   signal, GFP_KERNEL);
+        cfg80211_put_bss(cbss);
 }
 
 void orinoco_add_hostscan_results(struct orinoco_private *priv,
diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 0c13840a7de5..620e3c0e88e0 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -414,6 +414,7 @@ struct ndis_80211_pmkid {
 #define RNDIS_WLAN_ALG_TKIP     (1<<1)
 #define RNDIS_WLAN_ALG_CCMP     (1<<2)
 
+#define RNDIS_WLAN_NUM_KEYS             4
 #define RNDIS_WLAN_KEY_MGMT_NONE        0
 #define RNDIS_WLAN_KEY_MGMT_802_1X      (1<<0)
 #define RNDIS_WLAN_KEY_MGMT_PSK         (1<<1)
@@ -516,7 +517,7 @@ struct rndis_wlan_private {
 
         /* encryption stuff */
         int  encr_tx_key_index;
-        struct rndis_wlan_encr_key encr_keys[4];
+        struct rndis_wlan_encr_key encr_keys[RNDIS_WLAN_NUM_KEYS];
         int  wpa_version;
 
         u8 command_buffer[COMMAND_BUFFER_SIZE];
@@ -1535,6 +1536,9 @@ static int remove_key(struct usbnet *usbdev, int index, const u8 *bssid)
         bool is_wpa;
         int ret;
 
+        if (index >= RNDIS_WLAN_NUM_KEYS)
+                return -ENOENT;
+
         if (priv->encr_keys[index].len == 0)
                 return 0;
 
@@ -1972,11 +1976,12 @@ static int rndis_scan(struct wiphy *wiphy, struct net_device *dev,
         return ret;
 }
 
-static struct cfg80211_bss *rndis_bss_info_update(struct usbnet *usbdev,
-                                        struct ndis_80211_bssid_ex *bssid)
+static bool rndis_bss_info_update(struct usbnet *usbdev,
+                                  struct ndis_80211_bssid_ex *bssid)
 {
         struct rndis_wlan_private *priv = get_rndis_wlan_priv(usbdev);
         struct ieee80211_channel *channel;
+        struct cfg80211_bss *bss;
         s32 signal;
         u64 timestamp;
         u16 capability;
@@ -2015,9 +2020,12 @@ static struct cfg80211_bss *rndis_bss_info_update(struct usbnet *usbdev,
         capability = le16_to_cpu(fixed->capabilities);
         beacon_interval = le16_to_cpu(fixed->beacon_interval);
 
-        return cfg80211_inform_bss(priv->wdev.wiphy, channel, bssid->mac,
+        bss = cfg80211_inform_bss(priv->wdev.wiphy, channel, bssid->mac,
                 timestamp, capability, beacon_interval, ie, ie_len, signal,
                 GFP_KERNEL);
+        cfg80211_put_bss(bss);
+
+        return (bss != NULL);
 }
 
 static struct ndis_80211_bssid_ex *next_bssid_list_item(
@@ -2451,6 +2459,9 @@ static int rndis_set_default_key(struct wiphy *wiphy, struct net_device *netdev,
 
         netdev_dbg(usbdev->net, "%s(%i)\n", __func__, key_index);
 
+        if (key_index >= RNDIS_WLAN_NUM_KEYS)
+                return -ENOENT;
+
         priv->encr_tx_key_index = key_index;
 
         if (is_wpa_key(priv, key_index))
@@ -2641,6 +2652,7 @@ static void rndis_wlan_craft_connected_bss(struct usbnet *usbdev, u8 *bssid,
         struct ieee80211_channel *channel;
         struct ndis_80211_conf config;
         struct ndis_80211_ssid ssid;
+        struct cfg80211_bss *bss;
         s32 signal;
         u64 timestamp;
         u16 capability;
@@ -2714,9 +2726,10 @@ static void rndis_wlan_craft_connected_bss(struct usbnet *usbdev, u8 *bssid,
                 bssid, (u32)timestamp, capability, beacon_interval, ie_len,
                 ssid.essid, signal);
 
-        cfg80211_inform_bss(priv->wdev.wiphy, channel, bssid,
+        bss = cfg80211_inform_bss(priv->wdev.wiphy, channel, bssid,
                 timestamp, capability, beacon_interval, ie_buf, ie_len,
                 signal, GFP_KERNEL);
+        cfg80211_put_bss(bss);
 }
 
 /*
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index c244f2f1b83f..94a3e1706158 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -275,6 +275,8 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8191, rtl92cu_hal_cfg)},
 
         /****** 8188CU ********/
+        /* RTL8188CTV */
+        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x018a, rtl92cu_hal_cfg)},
         /* 8188CE-VAU USB minCard */
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8170, rtl92cu_hal_cfg)},
         /* 8188cu 1*1 dongle */
@@ -291,14 +293,14 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817e, rtl92cu_hal_cfg)},
         /* 8188RU in Alfa AWUS036NHR */
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817f, rtl92cu_hal_cfg)},
+        /* RTL8188CUS-VL */
+        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x818a, rtl92cu_hal_cfg)},
         /* 8188 Combo for BC4 */
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8754, rtl92cu_hal_cfg)},
 
         /****** 8192CU ********/
-        /* 8191cu 1*2 */
-        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8177, rtl92cu_hal_cfg)},
         /* 8192cu 2*2 */
-        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817b, rtl92cu_hal_cfg)},
+        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8178, rtl92cu_hal_cfg)},
         /* 8192CE-VAU USB minCard */
         {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817c, rtl92cu_hal_cfg)},
 
@@ -309,13 +311,17 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
         {RTL_USB_DEVICE(0x07b8, 0x8188, rtl92cu_hal_cfg)}, /*Abocom - Abocom*/
         {RTL_USB_DEVICE(0x07b8, 0x8189, rtl92cu_hal_cfg)}, /*Funai - Abocom*/
         {RTL_USB_DEVICE(0x0846, 0x9041, rtl92cu_hal_cfg)}, /*NetGear WNA1000M*/
-        {RTL_USB_DEVICE(0x0Df6, 0x0052, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/
+        {RTL_USB_DEVICE(0x0df6, 0x0052, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/
+        {RTL_USB_DEVICE(0x0df6, 0x005c, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/
         {RTL_USB_DEVICE(0x0eb0, 0x9071, rtl92cu_hal_cfg)}, /*NO Brand - Etop*/
         /* HP - Lite-On ,8188CUS Slim Combo */
         {RTL_USB_DEVICE(0x103c, 0x1629, rtl92cu_hal_cfg)},
         {RTL_USB_DEVICE(0x13d3, 0x3357, rtl92cu_hal_cfg)}, /* AzureWave */
         {RTL_USB_DEVICE(0x2001, 0x3308, rtl92cu_hal_cfg)}, /*D-Link - Alpha*/
+        {RTL_USB_DEVICE(0x2019, 0x4902, rtl92cu_hal_cfg)}, /*Planex - Etop*/
         {RTL_USB_DEVICE(0x2019, 0xab2a, rtl92cu_hal_cfg)}, /*Planex - Abocom*/
+        /*SW-WF02-AD15 -Abocom*/
+        {RTL_USB_DEVICE(0x2019, 0xab2e, rtl92cu_hal_cfg)},
         {RTL_USB_DEVICE(0x2019, 0xed17, rtl92cu_hal_cfg)}, /*PCI - Edimax*/
         {RTL_USB_DEVICE(0x20f4, 0x648b, rtl92cu_hal_cfg)}, /*TRENDnet - Cameo*/
         {RTL_USB_DEVICE(0x7392, 0x7811, rtl92cu_hal_cfg)}, /*Edimax - Edimax*/
@@ -326,14 +332,36 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
         {RTL_USB_DEVICE(0x4855, 0x0091, rtl92cu_hal_cfg)}, /* NetweeN-Feixun */
         {RTL_USB_DEVICE(0x9846, 0x9041, rtl92cu_hal_cfg)}, /* Netgear Cameo */
 
+        /****** 8188 RU ********/
+        /* Netcore */
+        {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x317f, rtl92cu_hal_cfg)},
+
+        /****** 8188CUS Slim Solo********/
+        {RTL_USB_DEVICE(0x04f2, 0xaff7, rtl92cu_hal_cfg)}, /*Xavi*/
+        {RTL_USB_DEVICE(0x04f2, 0xaff9, rtl92cu_hal_cfg)}, /*Xavi*/
+        {RTL_USB_DEVICE(0x04f2, 0xaffa, rtl92cu_hal_cfg)}, /*Xavi*/
+
+        /****** 8188CUS Slim Combo ********/
+        {RTL_USB_DEVICE(0x04f2, 0xaff8, rtl92cu_hal_cfg)}, /*Xavi*/
+        {RTL_USB_DEVICE(0x04f2, 0xaffb, rtl92cu_hal_cfg)}, /*Xavi*/
+        {RTL_USB_DEVICE(0x04f2, 0xaffc, rtl92cu_hal_cfg)}, /*Xavi*/
+        {RTL_USB_DEVICE(0x2019, 0x1201, rtl92cu_hal_cfg)}, /*Planex-Vencer*/
+
         /****** 8192CU ********/
+        {RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belcom-Sercomm*/
+        {RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belcom-Edimax*/
         {RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel -Abocom*/
         {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
         {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
+        {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
+        {RTL_USB_DEVICE(0x0b05, 0x17ab, rtl92cu_hal_cfg)}, /*ASUS-Edimax*/
+        {RTL_USB_DEVICE(0x0df6, 0x0061, rtl92cu_hal_cfg)}, /*Sitecom-Edimax*/
+        {RTL_USB_DEVICE(0x0e66, 0x0019, rtl92cu_hal_cfg)}, /*Hawking-Edimax*/
         {RTL_USB_DEVICE(0x2001, 0x3307, rtl92cu_hal_cfg)}, /*D-Link-Cameo*/
         {RTL_USB_DEVICE(0x2001, 0x3309, rtl92cu_hal_cfg)}, /*D-Link-Alpha*/
         {RTL_USB_DEVICE(0x2001, 0x330a, rtl92cu_hal_cfg)}, /*D-Link-Alpha*/
         {RTL_USB_DEVICE(0x2019, 0xab2b, rtl92cu_hal_cfg)}, /*Planex -Abocom*/
+        {RTL_USB_DEVICE(0x20f4, 0x624d, rtl92cu_hal_cfg)}, /*TRENDNet*/
         {RTL_USB_DEVICE(0x7392, 0x7822, rtl92cu_hal_cfg)}, /*Edimax -Edimax*/
         {}
 };
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 182562952c79..0b5c18feb303 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -165,7 +165,8 @@ static int xenvif_change_mtu(struct net_device *dev, int mtu)
         return 0;
 }
 
-static u32 xenvif_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t xenvif_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct xenvif *vif = netdev_priv(dev);
 
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 226faab23603..4312db8cdeab 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -201,7 +201,7 @@ static void xennet_sysfs_delif(struct net_device *netdev);
 #define xennet_sysfs_delif(dev) do { } while (0)
 #endif
 
-static int xennet_can_sg(struct net_device *dev)
+static bool xennet_can_sg(struct net_device *dev)
 {
         return dev->features & NETIF_F_SG;
 }
@@ -1190,7 +1190,8 @@ static void xennet_uninit(struct net_device *dev)
         gnttab_free_grant_references(np->gref_rx_head);
 }
 
-static u32 xennet_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t xennet_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct netfront_info *np = netdev_priv(dev);
         int val;
@@ -1216,7 +1217,8 @@ static u32 xennet_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int xennet_set_features(struct net_device *dev, u32 features)
+static int xennet_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         if (!(features & NETIF_F_SG) && dev->mtu > ETH_DATA_LEN) {
                 netdev_info(dev, "Reducing MTU because no SG offload");
diff --git a/drivers/s390/kvm/kvm_virtio.c b/drivers/s390/kvm/kvm_virtio.c
index 94f49ffa70ba..8af868bab20b 100644
--- a/drivers/s390/kvm/kvm_virtio.c
+++ b/drivers/s390/kvm/kvm_virtio.c
@@ -263,6 +263,11 @@ error:
         return PTR_ERR(vqs[i]);
 }
 
+static const char *kvm_bus_name(struct virtio_device *vdev)
+{
+        return "";
+}
+
 /*
  * The config ops structure as defined by virtio config
  */
@@ -276,6 +281,7 @@ static struct virtio_config_ops kvm_vq_configspace_ops = {
         .reset = kvm_reset,
         .find_vqs = kvm_find_vqs,
         .del_vqs = kvm_del_vqs,
+        .bus_name = kvm_bus_name,
 };
 
 /*
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 4d5307ddbe55..63578925bc59 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -3209,7 +3209,8 @@ static int qeth_l3_stop(struct net_device *dev)
         return 0;
 }
 
-static u32 qeth_l3_fix_features(struct net_device *dev, u32 features)
+static netdev_features_t qeth_l3_fix_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct qeth_card *card = dev->ml_priv;
 
@@ -3223,7 +3224,8 @@ static u32 qeth_l3_fix_features(struct net_device *dev, u32 features)
         return features;
 }
 
-static int qeth_l3_set_features(struct net_device *dev, u32 features)
+static int qeth_l3_set_features(struct net_device *dev,
+        netdev_features_t features)
 {
         struct qeth_card *card = dev->ml_priv;
         u32 changed = dev->features ^ features;
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index acc5e43c373e..2f57380d7ed4 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -361,7 +361,12 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
         return 0;
 }
 
+static const char *vm_bus_name(struct virtio_device *vdev)
+{
+        struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
 
+        return vm_dev->pdev->name;
+}
 
 static struct virtio_config_ops virtio_mmio_config_ops = {
         .get            = vm_get,
@@ -373,6 +378,7 @@ static struct virtio_config_ops virtio_mmio_config_ops = {
         .del_vqs        = vm_del_vqs,
         .get_features   = vm_get_features,
         .finalize_features = vm_finalize_features,
+        .bus_name       = vm_bus_name,
 };
 
 
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 3d1bf41e8892..91683e6e7af5 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -580,6 +580,13 @@ static int vp_find_vqs(struct virtio_device *vdev, unsigned nvqs,
                                   false, false);
 }
 
+static const char *vp_bus_name(struct virtio_device *vdev)
+{
+        struct virtio_pci_device *vp_dev = to_vp_device(vdev);
+
+        return pci_name(vp_dev->pci_dev);
+}
+
 static struct virtio_config_ops virtio_pci_config_ops = {
         .get            = vp_get,
         .set            = vp_set,
@@ -590,6 +597,7 @@ static struct virtio_config_ops virtio_pci_config_ops = {
         .del_vqs        = vp_del_vqs,
         .get_features   = vp_get_features,
         .finalize_features = vp_finalize_features,
+        .bus_name       = vp_bus_name,
 };
 
 static void virtio_pci_release_dev(struct device *_d)