173 files changed, 5168 insertions, 5485 deletions

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 33e2ca847a26..82710ae39228 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -205,6 +205,18 @@ config ACPI_IBM
 
           If you have an IBM ThinkPad laptop, say Y or M here.
 
+config ACPI_IBM_DOCK
+        bool "Legacy Docking Station Support"
+        depends on ACPI_IBM
+        default n
+        ---help---
+          Allows the ibm_acpi driver to handle docking station events.
+          This support is obsoleted by CONFIG_HOTPLUG_PCI_ACPI.  It will
+          allow locking and removing the laptop from the docking station,
+          but will not properly connect PCI devices.
+
+          If you are not sure, say N here.
+
 config ACPI_TOSHIBA
         tristate "Toshiba Laptop Extras"
         depends on X86
diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 5cc090326ddc..262b1f41335a 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -160,13 +160,13 @@ IBM_HANDLE(cmos, root, "\\UCMS",	/* R50, R50e, R50p, R51, T4x, X31, X40 */
            "\\CMOS",            /* A3x, G4x, R32, T23, T30, X22-24, X30 */
            "\\CMS",             /* R40, R40e */
     );                          /* all others */
-
+#ifdef CONFIG_ACPI_IBM_DOCK
 IBM_HANDLE(dock, root, "\\_SB.GDCK",    /* X30, X31, X40 */
            "\\_SB.PCI0.DOCK",   /* 600e/x,770e,770x,A2xm/p,T20-22,X20-21 */
            "\\_SB.PCI0.PCI1.DOCK",      /* all others */
            "\\_SB.PCI.ISA.SLCE",        /* 570 */
     );                          /* A21e,G4x,R30,R31,R32,R40,R40e,R50e */
-
+#endif
 IBM_HANDLE(bay, root, "\\_SB.PCI.IDE.SECN.MAST",        /* 570 */
            "\\_SB.PCI0.IDE0.IDES.IDSM", /* 600e/x, 770e, 770x */
            "\\_SB.PCI0.IDE0.SCND.MSTR", /* all others */
@@ -844,7 +844,7 @@ static int _sta(acpi_handle handle)
 
         return status;
 }
-
+#ifdef CONFIG_ACPI_IBM_DOCK
 #define dock_docked() (_sta(dock_handle) & 1)
 
 static int dock_read(char *p)
@@ -907,6 +907,7 @@ static void dock_notify(struct ibm_struct *ibm, u32 event)
                 acpi_bus_generate_event(ibm->device, event, 0); /* unknown */
         }
 }
+#endif
 
 static int bay_status_supported;
 static int bay_status2_supported;
@@ -1574,6 +1575,7 @@ static struct ibm_struct ibms[] = {
          .read = light_read,
          .write = light_write,
          },
+#ifdef CONFIG_ACPI_IBM_DOCK
         {
          .name = "dock",
          .read = dock_read,
@@ -1589,6 +1591,7 @@ static struct ibm_struct ibms[] = {
          .handle = &pci_handle,
          .type = ACPI_SYSTEM_NOTIFY,
          },
+#endif
         {
          .name = "bay",
          .init = bay_init,
@@ -1880,7 +1883,9 @@ IBM_PARAM(hotkey);
 IBM_PARAM(bluetooth);
 IBM_PARAM(video);
 IBM_PARAM(light);
+#ifdef CONFIG_ACPI_IBM_DOCK
 IBM_PARAM(dock);
+#endif
 IBM_PARAM(bay);
 IBM_PARAM(cmos);
 IBM_PARAM(led);
@@ -1927,7 +1932,9 @@ static int __init acpi_ibm_init(void)
         IBM_HANDLE_INIT(hkey);
         IBM_HANDLE_INIT(lght);
         IBM_HANDLE_INIT(cmos);
+#ifdef CONFIG_ACPI_IBM_DOCK
         IBM_HANDLE_INIT(dock);
+#endif
         IBM_HANDLE_INIT(pci);
         IBM_HANDLE_INIT(bay);
         if (bay_handle)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 9271e5209ac1..a0ab828b2cc5 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -23,7 +23,6 @@ static LIST_HEAD(acpi_device_list);
 DEFINE_SPINLOCK(acpi_device_lock);
 LIST_HEAD(acpi_wakeup_device_list);
 
-static int acpi_bus_trim(struct acpi_device *start, int rmdevice);
 
 static void acpi_device_release(struct kobject *kobj)
 {
@@ -1284,7 +1283,7 @@ int acpi_bus_start(struct acpi_device *device)
 
 EXPORT_SYMBOL(acpi_bus_start);
 
-static int acpi_bus_trim(struct acpi_device *start, int rmdevice)
+int acpi_bus_trim(struct acpi_device *start, int rmdevice)
 {
         acpi_status status;
         struct acpi_device *parent, *child;
@@ -1337,6 +1336,8 @@ static int acpi_bus_trim(struct acpi_device *start, int rmdevice)
         }
         return err;
 }
+EXPORT_SYMBOL_GPL(acpi_bus_trim);
+
 
 static int acpi_bus_scan_fixed(struct acpi_device *root)
 {
diff --git a/drivers/base/power/suspend.c b/drivers/base/power/suspend.c
index 8660779fb288..bdb60663f2ef 100644
--- a/drivers/base/power/suspend.c
+++ b/drivers/base/power/suspend.c
@@ -8,6 +8,7 @@
  *
  */
 
+#include <linux/vt_kern.h>
 #include <linux/device.h>
 #include "../base.h"
 #include "power.h"
@@ -62,7 +63,6 @@ int suspend_device(struct device * dev, pm_message_t state)
         return error;
 }
 
-
 /**
  *      device_suspend - Save state and stop all devices in system.
  *      @state:         Power state to put each device in.
@@ -82,6 +82,9 @@ int device_suspend(pm_message_t state)
 {
         int error = 0;
 
+        if (!is_console_suspend_safe())
+                return -EINVAL;
+
         down(&dpm_sem);
         down(&dpm_list_sem);
         while (!list_empty(&dpm_active) && error == 0) {
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index cf39cf9aac25..e29b8926f80e 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -3268,8 +3268,8 @@ clean2:
         unregister_blkdev(hba[i]->major, hba[i]->devname);
 clean1:
         release_io_mem(hba[i]);
-        free_hba(i);
         hba[i]->busy_initializing = 0;
+        free_hba(i);
         return(-1);
 }
 
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index d23b54332d7e..fb2d0be7cdeb 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -179,6 +179,7 @@ static int print_unex = 1;
 #include <linux/devfs_fs_kernel.h>
 #include <linux/platform_device.h>
 #include <linux/buffer_head.h>  /* for invalidate_buffers() */
+#include <linux/mutex.h>
 
 /*
  * PS/2 floppies have much slower step rates than regular floppies.
@@ -413,7 +414,7 @@ static struct floppy_write_errors write_errors[N_DRIVE];
 static struct timer_list motor_off_timer[N_DRIVE];
 static struct gendisk *disks[N_DRIVE];
 static struct block_device *opened_bdev[N_DRIVE];
-static DECLARE_MUTEX(open_lock);
+static DEFINE_MUTEX(open_lock);
 static struct floppy_raw_cmd *raw_cmd, default_raw_cmd;
 
 /*
@@ -3333,7 +3334,7 @@ static inline int set_geometry(unsigned int cmd, struct floppy_struct *g,
         if (type) {
                 if (!capable(CAP_SYS_ADMIN))
                         return -EPERM;
-                down(&open_lock);
+                mutex_lock(&open_lock);
                 LOCK_FDC(drive, 1);
                 floppy_type[type] = *g;
                 floppy_type[type].name = "user format";
@@ -3347,7 +3348,7 @@ static inline int set_geometry(unsigned int cmd, struct floppy_struct *g,
                                 continue;
                         __invalidate_device(bdev);
                 }
-                up(&open_lock);
+                mutex_unlock(&open_lock);
         } else {
                 int oldStretch;
                 LOCK_FDC(drive, 1);
@@ -3674,7 +3675,7 @@ static int floppy_release(struct inode *inode, struct file *filp)
 {
         int drive = (long)inode->i_bdev->bd_disk->private_data;
 
-        down(&open_lock);
+        mutex_lock(&open_lock);
         if (UDRS->fd_ref < 0)
                 UDRS->fd_ref = 0;
         else if (!UDRS->fd_ref--) {
@@ -3684,7 +3685,7 @@ static int floppy_release(struct inode *inode, struct file *filp)
         if (!UDRS->fd_ref)
                 opened_bdev[drive] = NULL;
         floppy_release_irq_and_dma();
-        up(&open_lock);
+        mutex_unlock(&open_lock);
         return 0;
 }
 
@@ -3702,7 +3703,7 @@ static int floppy_open(struct inode *inode, struct file *filp)
         char *tmp;
 
         filp->private_data = (void *)0;
-        down(&open_lock);
+        mutex_lock(&open_lock);
         old_dev = UDRS->fd_device;
         if (opened_bdev[drive] && opened_bdev[drive] != inode->i_bdev)
                 goto out2;
@@ -3785,7 +3786,7 @@ static int floppy_open(struct inode *inode, struct file *filp)
                 if ((filp->f_mode & 2) && !(UTESTF(FD_DISK_WRITABLE)))
                         goto out;
         }
-        up(&open_lock);
+        mutex_unlock(&open_lock);
         return 0;
 out:
         if (UDRS->fd_ref < 0)
@@ -3796,7 +3797,7 @@ out:
                 opened_bdev[drive] = NULL;
         floppy_release_irq_and_dma();
 out2:
-        up(&open_lock);
+        mutex_unlock(&open_lock);
         return res;
 }
 
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 0010704739e3..74bf0255e98f 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1144,7 +1144,7 @@ static int lo_ioctl(struct inode * inode, struct file * file,
         struct loop_device *lo = inode->i_bdev->bd_disk->private_data;
         int err;
 
-        down(&lo->lo_ctl_mutex);
+        mutex_lock(&lo->lo_ctl_mutex);
         switch (cmd) {
         case LOOP_SET_FD:
                 err = loop_set_fd(lo, file, inode->i_bdev, arg);
@@ -1170,7 +1170,7 @@ static int lo_ioctl(struct inode * inode, struct file * file,
         default:
                 err = lo->ioctl ? lo->ioctl(lo, cmd, arg) : -EINVAL;
         }
-        up(&lo->lo_ctl_mutex);
+        mutex_unlock(&lo->lo_ctl_mutex);
         return err;
 }
 
@@ -1178,9 +1178,9 @@ static int lo_open(struct inode *inode, struct file *file)
 {
         struct loop_device *lo = inode->i_bdev->bd_disk->private_data;
 
-        down(&lo->lo_ctl_mutex);
+        mutex_lock(&lo->lo_ctl_mutex);
         lo->lo_refcnt++;
-        up(&lo->lo_ctl_mutex);
+        mutex_unlock(&lo->lo_ctl_mutex);
 
         return 0;
 }
@@ -1189,9 +1189,9 @@ static int lo_release(struct inode *inode, struct file *file)
 {
         struct loop_device *lo = inode->i_bdev->bd_disk->private_data;
 
-        down(&lo->lo_ctl_mutex);
+        mutex_lock(&lo->lo_ctl_mutex);
         --lo->lo_refcnt;
-        up(&lo->lo_ctl_mutex);
+        mutex_unlock(&lo->lo_ctl_mutex);
 
         return 0;
 }
@@ -1233,12 +1233,12 @@ int loop_unregister_transfer(int number)
         xfer_funcs[n] = NULL;
 
         for (lo = &loop_dev[0]; lo < &loop_dev[max_loop]; lo++) {
-                down(&lo->lo_ctl_mutex);
+                mutex_lock(&lo->lo_ctl_mutex);
 
                 if (lo->lo_encryption == xfer)
                         loop_release_xfer(lo);
 
-                up(&lo->lo_ctl_mutex);
+                mutex_unlock(&lo->lo_ctl_mutex);
         }
 
         return 0;
@@ -1285,7 +1285,7 @@ static int __init loop_init(void)
                 lo->lo_queue = blk_alloc_queue(GFP_KERNEL);
                 if (!lo->lo_queue)
                         goto out_mem4;
-                init_MUTEX(&lo->lo_ctl_mutex);
+                mutex_init(&lo->lo_ctl_mutex);
                 init_completion(&lo->lo_done);
                 init_completion(&lo->lo_bh_done);
                 lo->lo_number = i;
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 6997d8e6bfb5..a9bde30dadad 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -459,9 +459,9 @@ static void do_nbd_request(request_queue_t * q)
                 req->errors = 0;
                 spin_unlock_irq(q->queue_lock);
 
-                down(&lo->tx_lock);
+                mutex_lock(&lo->tx_lock);
                 if (unlikely(!lo->sock)) {
-                        up(&lo->tx_lock);
+                        mutex_unlock(&lo->tx_lock);
                         printk(KERN_ERR "%s: Attempted send on closed socket\n",
                                lo->disk->disk_name);
                         req->errors++;
@@ -484,7 +484,7 @@ static void do_nbd_request(request_queue_t * q)
                 }
 
                 lo->active_req = NULL;
-                up(&lo->tx_lock);
+                mutex_unlock(&lo->tx_lock);
                 wake_up_all(&lo->active_wq);
 
                 spin_lock_irq(q->queue_lock);
@@ -534,9 +534,9 @@ static int nbd_ioctl(struct inode *inode, struct file *file,
  
         case NBD_CLEAR_SOCK:
                 error = 0;
-                down(&lo->tx_lock);
+                mutex_lock(&lo->tx_lock);
                 lo->sock = NULL;
-                up(&lo->tx_lock);
+                mutex_unlock(&lo->tx_lock);
                 file = lo->file;
                 lo->file = NULL;
                 nbd_clear_que(lo);
@@ -590,7 +590,7 @@ static int nbd_ioctl(struct inode *inode, struct file *file,
                  * FIXME: This code is duplicated from sys_shutdown, but
                  * there should be a more generic interface rather than
                  * calling socket ops directly here */
-                down(&lo->tx_lock);
+                mutex_lock(&lo->tx_lock);
                 if (lo->sock) {
                         printk(KERN_WARNING "%s: shutting down socket\n",
                                 lo->disk->disk_name);
@@ -598,7 +598,7 @@ static int nbd_ioctl(struct inode *inode, struct file *file,
                                 SEND_SHUTDOWN|RCV_SHUTDOWN);
                         lo->sock = NULL;
                 }
-                up(&lo->tx_lock);
+                mutex_unlock(&lo->tx_lock);
                 file = lo->file;
                 lo->file = NULL;
                 nbd_clear_que(lo);
@@ -683,7 +683,7 @@ static int __init nbd_init(void)
                 nbd_dev[i].flags = 0;
                 spin_lock_init(&nbd_dev[i].queue_lock);
                 INIT_LIST_HEAD(&nbd_dev[i].queue_head);
-                init_MUTEX(&nbd_dev[i].tx_lock);
+                mutex_init(&nbd_dev[i].tx_lock);
                 init_waitqueue_head(&nbd_dev[i].active_wq);
                 nbd_dev[i].blksize = 1024;
                 nbd_dev[i].bytesize = 0x7ffffc00ULL << 10; /* 2TB */
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 476a5b553f34..1d261f985f31 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -56,6 +56,7 @@
 #include <linux/seq_file.h>
 #include <linux/miscdevice.h>
 #include <linux/suspend.h>
+#include <linux/mutex.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_ioctl.h>
 #include <scsi/scsi.h>
@@ -81,7 +82,7 @@
 static struct pktcdvd_device *pkt_devs[MAX_WRITERS];
 static struct proc_dir_entry *pkt_proc;
 static int pkt_major;
-static struct semaphore ctl_mutex;      /* Serialize open/close/setup/teardown */
+static struct mutex ctl_mutex;  /* Serialize open/close/setup/teardown */
 static mempool_t *psd_pool;
 
 
@@ -2018,7 +2019,7 @@ static int pkt_open(struct inode *inode, struct file *file)
 
         VPRINTK("pktcdvd: entering open\n");
 
-        down(&ctl_mutex);
+        mutex_lock(&ctl_mutex);
         pd = pkt_find_dev_from_minor(iminor(inode));
         if (!pd) {
                 ret = -ENODEV;
@@ -2044,14 +2045,14 @@ static int pkt_open(struct inode *inode, struct file *file)
                 set_blocksize(inode->i_bdev, CD_FRAMESIZE);
         }
 
-        up(&ctl_mutex);
+        mutex_unlock(&ctl_mutex);
         return 0;
 
 out_dec:
         pd->refcnt--;
 out:
         VPRINTK("pktcdvd: failed open (%d)\n", ret);
-        up(&ctl_mutex);
+        mutex_unlock(&ctl_mutex);
         return ret;
 }
 
@@ -2060,14 +2061,14 @@ static int pkt_close(struct inode *inode, struct file *file)
         struct pktcdvd_device *pd = inode->i_bdev->bd_disk->private_data;
         int ret = 0;
 
-        down(&ctl_mutex);
+        mutex_lock(&ctl_mutex);
         pd->refcnt--;
         BUG_ON(pd->refcnt < 0);
         if (pd->refcnt == 0) {
                 int flush = test_bit(PACKET_WRITABLE, &pd->flags);
                 pkt_release_dev(pd, flush);
         }
-        up(&ctl_mutex);
+        mutex_unlock(&ctl_mutex);
         return ret;
 }
 
@@ -2596,21 +2597,21 @@ static int pkt_ctl_ioctl(struct inode *inode, struct file *file, unsigned int cm
         case PKT_CTRL_CMD_SETUP:
                 if (!capable(CAP_SYS_ADMIN))
                         return -EPERM;
-                down(&ctl_mutex);
+                mutex_lock(&ctl_mutex);
                 ret = pkt_setup_dev(&ctrl_cmd);
-                up(&ctl_mutex);
+                mutex_unlock(&ctl_mutex);
                 break;
         case PKT_CTRL_CMD_TEARDOWN:
                 if (!capable(CAP_SYS_ADMIN))
                         return -EPERM;
-                down(&ctl_mutex);
+                mutex_lock(&ctl_mutex);
                 ret = pkt_remove_dev(&ctrl_cmd);
-                up(&ctl_mutex);
+                mutex_unlock(&ctl_mutex);
                 break;
         case PKT_CTRL_CMD_STATUS:
-                down(&ctl_mutex);
+                mutex_lock(&ctl_mutex);
                 pkt_get_status(&ctrl_cmd);
-                up(&ctl_mutex);
+                mutex_unlock(&ctl_mutex);
                 break;
         default:
                 return -ENOTTY;
@@ -2656,7 +2657,7 @@ static int __init pkt_init(void)
                 goto out;
         }
 
-        init_MUTEX(&ctl_mutex);
+        mutex_init(&ctl_mutex);
 
         pkt_proc = proc_mkdir("pktcdvd", proc_root_driver);
 
diff --git a/drivers/block/rd.c b/drivers/block/rd.c
index ffd6abd6d5a0..1c54f46d3f70 100644
--- a/drivers/block/rd.c
+++ b/drivers/block/rd.c
@@ -310,12 +310,12 @@ static int rd_ioctl(struct inode *inode, struct file *file,
          * cache
          */
         error = -EBUSY;
-        down(&bdev->bd_sem);
+        mutex_lock(&bdev->bd_mutex);
         if (bdev->bd_openers <= 2) {
                 truncate_inode_pages(bdev->bd_inode->i_mapping, 0);
                 error = 0;
         }
-        up(&bdev->bd_sem);
+        mutex_unlock(&bdev->bd_mutex);
         return error;
 }
 
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 879bbc26ce96..a59876a0bfa1 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -407,7 +407,6 @@ int register_cdrom(struct cdrom_device_info *cdi)
         ENSURE(get_mcn, CDC_MCN);
         ENSURE(reset, CDC_RESET);
         ENSURE(audio_ioctl, CDC_PLAY_AUDIO);
-        ENSURE(dev_ioctl, CDC_IOCTLS);
         ENSURE(generic_packet, CDC_GENERIC_PACKET);
         cdi->mc_flags = 0;
         cdo->n_minors = 0;
@@ -2196,395 +2195,586 @@ retry:
         return cdrom_read_cdda_old(cdi, ubuf, lba, nframes);    
 }
 
-/* Just about every imaginable ioctl is supported in the Uniform layer
- * these days. ATAPI / SCSI specific code now mainly resides in
- * mmc_ioct().
- */
-int cdrom_ioctl(struct file * file, struct cdrom_device_info *cdi,
-                struct inode *ip, unsigned int cmd, unsigned long arg)
+static int cdrom_ioctl_multisession(struct cdrom_device_info *cdi,
+                void __user *argp)
 {
-        struct cdrom_device_ops *cdo = cdi->ops;
+        struct cdrom_multisession ms_info;
+        u8 requested_format;
         int ret;
 
-        /* Try the generic SCSI command ioctl's first.. */
-        ret = scsi_cmd_ioctl(file, ip->i_bdev->bd_disk, cmd, (void __user *)arg);
-        if (ret != -ENOTTY)
+        cdinfo(CD_DO_IOCTL, "entering CDROMMULTISESSION\n");
+
+        if (!(cdi->ops->capability & CDC_MULTI_SESSION))
+                return -ENOSYS;
+
+        if (copy_from_user(&ms_info, argp, sizeof(ms_info)))
+                return -EFAULT;
+
+        requested_format = ms_info.addr_format;
+        if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
+                return -EINVAL;
+        ms_info.addr_format = CDROM_LBA;
+
+        ret = cdi->ops->get_last_session(cdi, &ms_info);
+        if (ret)
                 return ret;
 
-        /* the first few commands do not deal with audio drive_info, but
-           only with routines in cdrom device operations. */
-        switch (cmd) {
-        case CDROMMULTISESSION: {
-                struct cdrom_multisession ms_info;
-                u_char requested_format;
-                cdinfo(CD_DO_IOCTL, "entering CDROMMULTISESSION\n"); 
-                if (!(cdo->capability & CDC_MULTI_SESSION))
-                        return -ENOSYS;
-                IOCTL_IN(arg, struct cdrom_multisession, ms_info);
-                requested_format = ms_info.addr_format;
-                if (!((requested_format == CDROM_MSF) ||
-                        (requested_format == CDROM_LBA)))
-                                return -EINVAL;
-                ms_info.addr_format = CDROM_LBA;
-                if ((ret=cdo->get_last_session(cdi, &ms_info)))
+        sanitize_format(&ms_info.addr, &ms_info.addr_format, requested_format);
+
+        if (copy_to_user(argp, &ms_info, sizeof(ms_info)))
+                return -EFAULT;
+
+        cdinfo(CD_DO_IOCTL, "CDROMMULTISESSION successful\n");
+        return 0;
+}
+
+static int cdrom_ioctl_eject(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMEJECT\n");
+
+        if (!CDROM_CAN(CDC_OPEN_TRAY))
+                return -ENOSYS;
+        if (cdi->use_count != 1 || keeplocked)
+                return -EBUSY;
+        if (CDROM_CAN(CDC_LOCK)) {
+                int ret = cdi->ops->lock_door(cdi, 0);
+                if (ret)
                         return ret;
-                sanitize_format(&ms_info.addr, &ms_info.addr_format,
-                                requested_format);
-                IOCTL_OUT(arg, struct cdrom_multisession, ms_info);
-                cdinfo(CD_DO_IOCTL, "CDROMMULTISESSION successful\n"); 
-                return 0;
-                }
+        }
 
-        case CDROMEJECT: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMEJECT\n"); 
-                if (!CDROM_CAN(CDC_OPEN_TRAY))
-                        return -ENOSYS;
-                if (cdi->use_count != 1 || keeplocked)
-                        return -EBUSY;
-                if (CDROM_CAN(CDC_LOCK))
-                        if ((ret=cdo->lock_door(cdi, 0)))
-                                return ret;
+        return cdi->ops->tray_move(cdi, 1);
+}
 
-                return cdo->tray_move(cdi, 1);
-                }
+static int cdrom_ioctl_closetray(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMCLOSETRAY\n");
 
-        case CDROMCLOSETRAY: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMCLOSETRAY\n"); 
-                if (!CDROM_CAN(CDC_CLOSE_TRAY))
-                        return -ENOSYS;
-                return cdo->tray_move(cdi, 0);
-                }
+        if (!CDROM_CAN(CDC_CLOSE_TRAY))
+                return -ENOSYS;
+        return cdi->ops->tray_move(cdi, 0);
+}
 
-        case CDROMEJECT_SW: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMEJECT_SW\n"); 
-                if (!CDROM_CAN(CDC_OPEN_TRAY))
-                        return -ENOSYS;
-                if (keeplocked)
-                        return -EBUSY;
-                cdi->options &= ~(CDO_AUTO_CLOSE | CDO_AUTO_EJECT);
-                if (arg)
-                        cdi->options |= CDO_AUTO_CLOSE | CDO_AUTO_EJECT;
-                return 0;
-                }
+static int cdrom_ioctl_eject_sw(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMEJECT_SW\n");
 
-        case CDROM_MEDIA_CHANGED: {
-                struct cdrom_changer_info *info;
-                int changed;
+        if (!CDROM_CAN(CDC_OPEN_TRAY))
+                return -ENOSYS;
+        if (keeplocked)
+                return -EBUSY;
 
-                cdinfo(CD_DO_IOCTL, "entering CDROM_MEDIA_CHANGED\n"); 
-                if (!CDROM_CAN(CDC_MEDIA_CHANGED))
-                        return -ENOSYS;
+        cdi->options &= ~(CDO_AUTO_CLOSE | CDO_AUTO_EJECT);
+        if (arg)
+                cdi->options |= CDO_AUTO_CLOSE | CDO_AUTO_EJECT;
+        return 0;
+}
 
-                /* cannot select disc or select current disc */
-                if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
-                        return media_changed(cdi, 1);
+static int cdrom_ioctl_media_changed(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        struct cdrom_changer_info *info;
+        int ret;
 
-                if ((unsigned int)arg >= cdi->capacity)
-                        return -EINVAL;
+        cdinfo(CD_DO_IOCTL, "entering CDROM_MEDIA_CHANGED\n");
 
-                info = kmalloc(sizeof(*info), GFP_KERNEL);
-                if (!info)
-                        return -ENOMEM;
+        if (!CDROM_CAN(CDC_MEDIA_CHANGED))
+                return -ENOSYS;
 
-                if ((ret = cdrom_read_mech_status(cdi, info))) {
-                        kfree(info);
-                        return ret;
-                }
+        /* cannot select disc or select current disc */
+        if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
+                return media_changed(cdi, 1);
 
-                changed = info->slots[arg].change;
-                kfree(info);
-                return changed;
-                }
+        if ((unsigned int)arg >= cdi->capacity)
+                return -EINVAL;
 
-        case CDROM_SET_OPTIONS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SET_OPTIONS\n"); 
-                /* options need to be in sync with capability. too late for
-                   that, so we have to check each one separately... */
-                switch (arg) {
-                case CDO_USE_FFLAGS:
-                case CDO_CHECK_TYPE:
-                        break;
-                case CDO_LOCK:
-                        if (!CDROM_CAN(CDC_LOCK))
-                                return -ENOSYS;
-                        break;
-                case 0:
-                        return cdi->options;
-                /* default is basically CDO_[AUTO_CLOSE|AUTO_EJECT] */
-                default:
-                        if (!CDROM_CAN(arg))
-                                return -ENOSYS;
-                }
-                cdi->options |= (int) arg;
-                return cdi->options;
-                }
+        info = kmalloc(sizeof(*info), GFP_KERNEL);
+        if (!info)
+                return -ENOMEM;
 
-        case CDROM_CLEAR_OPTIONS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_CLEAR_OPTIONS\n"); 
-                cdi->options &= ~(int) arg;
-                return cdi->options;
-                }
+        ret = cdrom_read_mech_status(cdi, info);
+        if (!ret)
+                ret = info->slots[arg].change;
+        kfree(info);
+        return ret;
+}
 
-        case CDROM_SELECT_SPEED: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_SPEED\n"); 
-                if (!CDROM_CAN(CDC_SELECT_SPEED))
-                        return -ENOSYS;
-                return cdo->select_speed(cdi, arg);
-                }
+static int cdrom_ioctl_set_options(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SET_OPTIONS\n");
 
-        case CDROM_SELECT_DISC: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_DISC\n"); 
-                if (!CDROM_CAN(CDC_SELECT_DISC))
+        /*
+         * Options need to be in sync with capability.
+         * Too late for that, so we have to check each one separately.
+         */
+        switch (arg) {
+        case CDO_USE_FFLAGS:
+        case CDO_CHECK_TYPE:
+                break;
+        case CDO_LOCK:
+                if (!CDROM_CAN(CDC_LOCK))
+                        return -ENOSYS;
+                break;
+        case 0:
+                return cdi->options;
+        /* default is basically CDO_[AUTO_CLOSE|AUTO_EJECT] */
+        default:
+                if (!CDROM_CAN(arg))
                         return -ENOSYS;
+        }
+        cdi->options |= (int) arg;
+        return cdi->options;
+}
 
-                if ((arg != CDSL_CURRENT) && (arg != CDSL_NONE))
-                        if ((int)arg >= cdi->capacity)
-                                return -EINVAL;
-
-                /* cdo->select_disc is a hook to allow a driver-specific
-                 * way of seleting disc.  However, since there is no
-                 * equiv hook for cdrom_slot_status this may not 
-                 * actually be useful...
-                 */
-                if (cdo->select_disc != NULL)
-                        return cdo->select_disc(cdi, arg);
-
-                /* no driver specific select_disc(), call our own */
-                cdinfo(CD_CHANGER, "Using generic cdrom_select_disc()\n"); 
-                return cdrom_select_disc(cdi, arg);
-                }
+static int cdrom_ioctl_clear_options(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_CLEAR_OPTIONS\n");
 
-        case CDROMRESET: {
-                if (!capable(CAP_SYS_ADMIN))
-                        return -EACCES;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_RESET\n");
-                if (!CDROM_CAN(CDC_RESET))
-                        return -ENOSYS;
-                invalidate_bdev(ip->i_bdev, 0);
-                return cdo->reset(cdi);
-                }
+        cdi->options &= ~(int) arg;
+        return cdi->options;
+}
 
-        case CDROM_LOCKDOOR: {
-                cdinfo(CD_DO_IOCTL, "%socking door.\n", arg ? "L" : "Unl");
-                if (!CDROM_CAN(CDC_LOCK))
-                        return -EDRIVE_CANT_DO_THIS;
-                keeplocked = arg ? 1 : 0;
-                /* don't unlock the door on multiple opens,but allow root
-                 * to do so */
-                if ((cdi->use_count != 1) && !arg && !capable(CAP_SYS_ADMIN))
-                        return -EBUSY;
-                return cdo->lock_door(cdi, arg);
-                }
+static int cdrom_ioctl_select_speed(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_SPEED\n");
 
-        case CDROM_DEBUG: {
-                if (!capable(CAP_SYS_ADMIN))
-                        return -EACCES;
-                cdinfo(CD_DO_IOCTL, "%sabling debug.\n", arg ? "En" : "Dis");
-                debug = arg ? 1 : 0;
-                return debug;
-                }
+        if (!CDROM_CAN(CDC_SELECT_SPEED))
+                return -ENOSYS;
+        return cdi->ops->select_speed(cdi, arg);
+}
 
-        case CDROM_GET_CAPABILITY: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_GET_CAPABILITY\n");
-                return (cdo->capability & ~cdi->mask);
-                }
+static int cdrom_ioctl_select_disc(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_DISC\n");
+
+        if (!CDROM_CAN(CDC_SELECT_DISC))
+                return -ENOSYS;
+
+        if (arg != CDSL_CURRENT && arg != CDSL_NONE) {
+                if ((int)arg >= cdi->capacity)
+                        return -EINVAL;
+        }
+
+        /*
+         * ->select_disc is a hook to allow a driver-specific way of
+         * seleting disc.  However, since there is no equivalent hook for
+         * cdrom_slot_status this may not actually be useful...
+         */
+        if (cdi->ops->select_disc)
+                return cdi->ops->select_disc(cdi, arg);
+
+        cdinfo(CD_CHANGER, "Using generic cdrom_select_disc()\n");
+        return cdrom_select_disc(cdi, arg);
+}
+
+static int cdrom_ioctl_reset(struct cdrom_device_info *cdi,
+                struct block_device *bdev)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_RESET\n");
+
+        if (!capable(CAP_SYS_ADMIN))
+                return -EACCES;
+        if (!CDROM_CAN(CDC_RESET))
+                return -ENOSYS;
+        invalidate_bdev(bdev, 0);
+        return cdi->ops->reset(cdi);
+}
+
+static int cdrom_ioctl_lock_door(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "%socking door.\n", arg ? "L" : "Unl");
+
+        if (!CDROM_CAN(CDC_LOCK))
+                return -EDRIVE_CANT_DO_THIS;
+
+        keeplocked = arg ? 1 : 0;
+
+        /*
+         * Don't unlock the door on multiple opens by default, but allow
+         * root to do so.
+         */
+        if (cdi->use_count != 1 && !arg && !capable(CAP_SYS_ADMIN))
+                return -EBUSY;
+        return cdi->ops->lock_door(cdi, arg);
+}
+
+static int cdrom_ioctl_debug(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "%sabling debug.\n", arg ? "En" : "Dis");
+
+        if (!capable(CAP_SYS_ADMIN))
+                return -EACCES;
+        debug = arg ? 1 : 0;
+        return debug;
+}
 
-/* The following function is implemented, although very few audio
+static int cdrom_ioctl_get_capability(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_GET_CAPABILITY\n");
+        return (cdi->ops->capability & ~cdi->mask);
+}
+
+/*
+ * The following function is implemented, although very few audio
  * discs give Universal Product Code information, which should just be
  * the Medium Catalog Number on the box.  Note, that the way the code
  * is written on the CD is /not/ uniform across all discs!
  */
-        case CDROM_GET_MCN: {
-                struct cdrom_mcn mcn;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_GET_MCN\n"); 
-                if (!(cdo->capability & CDC_MCN))
-                        return -ENOSYS;
-                if ((ret=cdo->get_mcn(cdi, &mcn)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_mcn, mcn);
-                cdinfo(CD_DO_IOCTL, "CDROM_GET_MCN successful\n"); 
-                return 0;
-                }
+static int cdrom_ioctl_get_mcn(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_mcn mcn;
+        int ret;
 
-        case CDROM_DRIVE_STATUS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_DRIVE_STATUS\n"); 
-                if (!(cdo->capability & CDC_DRIVE_STATUS))
-                        return -ENOSYS;
-                if (!CDROM_CAN(CDC_SELECT_DISC))
-                        return cdo->drive_status(cdi, CDSL_CURRENT);
-                if ((arg == CDSL_CURRENT) || (arg == CDSL_NONE)) 
-                        return cdo->drive_status(cdi, CDSL_CURRENT);
-                if (((int)arg >= cdi->capacity))
-                        return -EINVAL;
-                return cdrom_slot_status(cdi, arg);
-                }
+        cdinfo(CD_DO_IOCTL, "entering CDROM_GET_MCN\n");
 
-        /* Ok, this is where problems start.  The current interface for the
-           CDROM_DISC_STATUS ioctl is flawed.  It makes the false assumption
-           that CDs are all CDS_DATA_1 or all CDS_AUDIO, etc.  Unfortunatly,
-           while this is often the case, it is also very common for CDs to
-           have some tracks with data, and some tracks with audio.  Just 
-           because I feel like it, I declare the following to be the best
-           way to cope.  If the CD has ANY data tracks on it, it will be
-           returned as a data CD.  If it has any XA tracks, I will return
-           it as that.  Now I could simplify this interface by combining these 
-           returns with the above, but this more clearly demonstrates
-           the problem with the current interface.  Too bad this wasn't 
-           designed to use bitmasks...         -Erik 
-
-           Well, now we have the option CDS_MIXED: a mixed-type CD. 
-           User level programmers might feel the ioctl is not very useful.
-                                                ---david
-        */
-        case CDROM_DISC_STATUS: {
-                tracktype tracks;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_DISC_STATUS\n"); 
-                cdrom_count_tracks(cdi, &tracks);
-                if (tracks.error) 
-                        return(tracks.error);
-
-                /* Policy mode on */
-                if (tracks.audio > 0) {
-                        if (tracks.data==0 && tracks.cdi==0 && tracks.xa==0) 
-                                return CDS_AUDIO;
-                        else
-                                return CDS_MIXED;
-                }
-                if (tracks.cdi > 0) return CDS_XA_2_2;
-                if (tracks.xa > 0) return CDS_XA_2_1;
-                if (tracks.data > 0) return CDS_DATA_1;
-                /* Policy mode off */
+        if (!(cdi->ops->capability & CDC_MCN))
+                return -ENOSYS;
+        ret = cdi->ops->get_mcn(cdi, &mcn);
+        if (ret)
+                return ret;
 
-                cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
-                return CDS_NO_INFO;
-                }
+        if (copy_to_user(argp, &mcn, sizeof(mcn)))
+                return -EFAULT;
+        cdinfo(CD_DO_IOCTL, "CDROM_GET_MCN successful\n");
+        return 0;
+}
 
-        case CDROM_CHANGER_NSLOTS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_CHANGER_NSLOTS\n"); 
-                return cdi->capacity;
-                }
+static int cdrom_ioctl_drive_status(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_DRIVE_STATUS\n");
+
+        if (!(cdi->ops->capability & CDC_DRIVE_STATUS))
+                return -ENOSYS;
+        if (!CDROM_CAN(CDC_SELECT_DISC) ||
+            (arg == CDSL_CURRENT || arg == CDSL_NONE))
+                return cdi->ops->drive_status(cdi, CDSL_CURRENT);
+        if (((int)arg >= cdi->capacity))
+                return -EINVAL;
+        return cdrom_slot_status(cdi, arg);
+}
+
+/*
+ * Ok, this is where problems start.  The current interface for the
+ * CDROM_DISC_STATUS ioctl is flawed.  It makes the false assumption that
+ * CDs are all CDS_DATA_1 or all CDS_AUDIO, etc.  Unfortunatly, while this
+ * is often the case, it is also very common for CDs to have some tracks
+ * with data, and some tracks with audio.  Just because I feel like it,
+ * I declare the following to be the best way to cope.  If the CD has ANY
+ * data tracks on it, it will be returned as a data CD.  If it has any XA
+ * tracks, I will return it as that.  Now I could simplify this interface
+ * by combining these  returns with the above, but this more clearly
+ * demonstrates the problem with the current interface.  Too bad this
+ * wasn't designed to use bitmasks...         -Erik
+ *
+ * Well, now we have the option CDS_MIXED: a mixed-type CD.
+ * User level programmers might feel the ioctl is not very useful.
+ *                                      ---david
+ */
+static int cdrom_ioctl_disc_status(struct cdrom_device_info *cdi)
+{
+        tracktype tracks;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROM_DISC_STATUS\n");
+
+        cdrom_count_tracks(cdi, &tracks);
+        if (tracks.error)
+                return tracks.error;
+
+        /* Policy mode on */
+        if (tracks.audio > 0) {
+                if (!tracks.data && !tracks.cdi && !tracks.xa)
+                        return CDS_AUDIO;
+                else
+                        return CDS_MIXED;
         }
 
-        /* use the ioctls that are implemented through the generic_packet()
-           interface. this may look at bit funny, but if -ENOTTY is
-           returned that particular ioctl is not implemented and we
-           let it go through the device specific ones. */
+        if (tracks.cdi > 0)
+                return CDS_XA_2_2;
+        if (tracks.xa > 0)
+                return CDS_XA_2_1;
+        if (tracks.data > 0)
+                return CDS_DATA_1;
+        /* Policy mode off */
+
+        cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
+        return CDS_NO_INFO;
+}
+
+static int cdrom_ioctl_changer_nslots(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_CHANGER_NSLOTS\n");
+        return cdi->capacity;
+}
+
+static int cdrom_ioctl_get_subchnl(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_subchnl q;
+        u8 requested, back;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL,"entering CDROMSUBCHNL\n");*/
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&q, argp, sizeof(q)))
+                return -EFAULT;
+
+        requested = q.cdsc_format;
+        if (requested != CDROM_MSF && requested != CDROM_LBA)
+                return -EINVAL;
+        q.cdsc_format = CDROM_MSF;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMSUBCHNL, &q);
+        if (ret)
+                return ret;
+
+        back = q.cdsc_format; /* local copy */
+        sanitize_format(&q.cdsc_absaddr, &back, requested);
+        sanitize_format(&q.cdsc_reladdr, &q.cdsc_format, requested);
+
+        if (copy_to_user(argp, &q, sizeof(q)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMSUBCHNL successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_read_tochdr(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_tochdr header;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCHDR\n"); */
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&header, argp, sizeof(header)))
+                return -EFAULT;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCHDR, &header);
+        if (ret)
+                return ret;
+
+        if (copy_to_user(argp, &header, sizeof(header)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCHDR successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_read_tocentry(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_tocentry entry;
+        u8 requested_format;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCENTRY\n"); */
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&entry, argp, sizeof(entry)))
+                return -EFAULT;
+
+        requested_format = entry.cdte_format;
+        if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
+                return -EINVAL;
+        /* make interface to low-level uniform */
+        entry.cdte_format = CDROM_MSF;
+        ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCENTRY, &entry);
+        if (ret)
+                return ret;
+        sanitize_format(&entry.cdte_addr, &entry.cdte_format, requested_format);
+
+        if (copy_to_user(argp, &entry, sizeof(entry)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCENTRY successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_play_msf(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_msf msf;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMPLAYMSF\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&msf, argp, sizeof(msf)))
+                return -EFAULT;
+        return cdi->ops->audio_ioctl(cdi, CDROMPLAYMSF, &msf);
+}
+
+static int cdrom_ioctl_play_trkind(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_ti ti;
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMPLAYTRKIND\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&ti, argp, sizeof(ti)))
+                return -EFAULT;
+
+        ret = check_for_audio_disc(cdi, cdi->ops);
+        if (ret)
+                return ret;
+        return cdi->ops->audio_ioctl(cdi, CDROMPLAYTRKIND, &ti);
+}
+static int cdrom_ioctl_volctrl(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_volctrl volume;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMVOLCTRL\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&volume, argp, sizeof(volume)))
+                return -EFAULT;
+        return cdi->ops->audio_ioctl(cdi, CDROMVOLCTRL, &volume);
+}
+
+static int cdrom_ioctl_volread(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_volctrl volume;
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMVOLREAD\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMVOLREAD, &volume);
+        if (ret)
+                return ret;
+
+        if (copy_to_user(argp, &volume, sizeof(volume)))
+                return -EFAULT;
+        return 0;
+}
+
+static int cdrom_ioctl_audioctl(struct cdrom_device_info *cdi,
+                unsigned int cmd)
+{
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "doing audio ioctl (start/stop/pause/resume)\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        ret = check_for_audio_disc(cdi, cdi->ops);
+        if (ret)
+                return ret;
+        return cdi->ops->audio_ioctl(cdi, cmd, NULL);
+}
+
+/*
+ * Just about every imaginable ioctl is supported in the Uniform layer
+ * these days.
+ * ATAPI / SCSI specific code now mainly resides in mmc_ioctl().
+ */
+int cdrom_ioctl(struct file * file, struct cdrom_device_info *cdi,
+                struct inode *ip, unsigned int cmd, unsigned long arg)
+{
+        void __user *argp = (void __user *)arg;
+        int ret;
+
+        /*
+         * Try the generic SCSI command ioctl's first.
+         */
+        ret = scsi_cmd_ioctl(file, ip->i_bdev->bd_disk, cmd, argp);
+        if (ret != -ENOTTY)
+                return ret;
+
+        switch (cmd) {
+        case CDROMMULTISESSION:
+                return cdrom_ioctl_multisession(cdi, argp);
+        case CDROMEJECT:
+                return cdrom_ioctl_eject(cdi);
+        case CDROMCLOSETRAY:
+                return cdrom_ioctl_closetray(cdi);
+        case CDROMEJECT_SW:
+                return cdrom_ioctl_eject_sw(cdi, arg);
+        case CDROM_MEDIA_CHANGED:
+                return cdrom_ioctl_media_changed(cdi, arg);
+        case CDROM_SET_OPTIONS:
+                return cdrom_ioctl_set_options(cdi, arg);
+        case CDROM_CLEAR_OPTIONS:
+                return cdrom_ioctl_clear_options(cdi, arg);
+        case CDROM_SELECT_SPEED:
+                return cdrom_ioctl_select_speed(cdi, arg);
+        case CDROM_SELECT_DISC:
+                return cdrom_ioctl_select_disc(cdi, arg);
+        case CDROMRESET:
+                return cdrom_ioctl_reset(cdi, ip->i_bdev);
+        case CDROM_LOCKDOOR:
+                return cdrom_ioctl_lock_door(cdi, arg);
+        case CDROM_DEBUG:
+                return cdrom_ioctl_debug(cdi, arg);
+        case CDROM_GET_CAPABILITY:
+                return cdrom_ioctl_get_capability(cdi);
+        case CDROM_GET_MCN:
+                return cdrom_ioctl_get_mcn(cdi, argp);
+        case CDROM_DRIVE_STATUS:
+                return cdrom_ioctl_drive_status(cdi, arg);
+        case CDROM_DISC_STATUS:
+                return cdrom_ioctl_disc_status(cdi);
+        case CDROM_CHANGER_NSLOTS:
+                return cdrom_ioctl_changer_nslots(cdi);
+        }
+
+        /*
+         * Use the ioctls that are implemented through the generic_packet()
+         * interface. this may look at bit funny, but if -ENOTTY is
+         * returned that particular ioctl is not implemented and we
+         * let it go through the device specific ones.
+         */
         if (CDROM_CAN(CDC_GENERIC_PACKET)) {
                 ret = mmc_ioctl(cdi, cmd, arg);
-                if (ret != -ENOTTY) {
+                if (ret != -ENOTTY)
                         return ret;
-                }
         }
 
-        /* note: most of the cdinfo() calls are commented out here,
-           because they fill up the sys log when CD players poll
-           the drive. */
+        /*
+         * Note: most of the cdinfo() calls are commented out here,
+         * because they fill up the sys log when CD players poll
+         * the drive.
+         */
         switch (cmd) {
-        case CDROMSUBCHNL: {
-                struct cdrom_subchnl q;
-                u_char requested, back;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL,"entering CDROMSUBCHNL\n");*/ 
-                IOCTL_IN(arg, struct cdrom_subchnl, q);
-                requested = q.cdsc_format;
-                if (!((requested == CDROM_MSF) ||
-                      (requested == CDROM_LBA)))
-                        return -EINVAL;
-                q.cdsc_format = CDROM_MSF;
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &q)))
-                        return ret;
-                back = q.cdsc_format; /* local copy */
-                sanitize_format(&q.cdsc_absaddr, &back, requested);
-                sanitize_format(&q.cdsc_reladdr, &q.cdsc_format, requested);
-                IOCTL_OUT(arg, struct cdrom_subchnl, q);
-                /* cdinfo(CD_DO_IOCTL, "CDROMSUBCHNL successful\n"); */ 
-                return 0;
-                }
-        case CDROMREADTOCHDR: {
-                struct cdrom_tochdr header;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCHDR\n"); */ 
-                IOCTL_IN(arg, struct cdrom_tochdr, header);
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &header)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_tochdr, header);
-                /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCHDR successful\n"); */ 
-                return 0;
-                }
-        case CDROMREADTOCENTRY: {
-                struct cdrom_tocentry entry;
-                u_char requested_format;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCENTRY\n"); */ 
-                IOCTL_IN(arg, struct cdrom_tocentry, entry);
-                requested_format = entry.cdte_format;
-                if (!((requested_format == CDROM_MSF) || 
-                        (requested_format == CDROM_LBA)))
-                                return -EINVAL;
-                /* make interface to low-level uniform */
-                entry.cdte_format = CDROM_MSF;
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &entry)))
-                        return ret;
-                sanitize_format(&entry.cdte_addr,
-                &entry.cdte_format, requested_format);
-                IOCTL_OUT(arg, struct cdrom_tocentry, entry);
-                /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCENTRY successful\n"); */ 
-                return 0;
-                }
-        case CDROMPLAYMSF: {
-                struct cdrom_msf msf;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMPLAYMSF\n"); 
-                IOCTL_IN(arg, struct cdrom_msf, msf);
-                return cdo->audio_ioctl(cdi, cmd, &msf);
-                }
-        case CDROMPLAYTRKIND: {
-                struct cdrom_ti ti;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMPLAYTRKIND\n"); 
-                IOCTL_IN(arg, struct cdrom_ti, ti);
-                CHECKAUDIO;
-                return cdo->audio_ioctl(cdi, cmd, &ti);
-                }
-        case CDROMVOLCTRL: {
-                struct cdrom_volctrl volume;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMVOLCTRL\n"); 
-                IOCTL_IN(arg, struct cdrom_volctrl, volume);
-                return cdo->audio_ioctl(cdi, cmd, &volume);
-                }
-        case CDROMVOLREAD: {
-                struct cdrom_volctrl volume;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMVOLREAD\n"); 
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &volume)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_volctrl, volume);
-                return 0;
-                }
+        case CDROMSUBCHNL:
+                return cdrom_ioctl_get_subchnl(cdi, argp);
+        case CDROMREADTOCHDR:
+                return cdrom_ioctl_read_tochdr(cdi, argp);
+        case CDROMREADTOCENTRY:
+                return cdrom_ioctl_read_tocentry(cdi, argp);
+        case CDROMPLAYMSF:
+                return cdrom_ioctl_play_msf(cdi, argp);
+        case CDROMPLAYTRKIND:
+                return cdrom_ioctl_play_trkind(cdi, argp);
+        case CDROMVOLCTRL:
+                return cdrom_ioctl_volctrl(cdi, argp);
+        case CDROMVOLREAD:
+                return cdrom_ioctl_volread(cdi, argp);
         case CDROMSTART:
         case CDROMSTOP:
         case CDROMPAUSE:
-        case CDROMRESUME: {
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "doing audio ioctl (start/stop/pause/resume)\n"); 
-                CHECKAUDIO;
-                return cdo->audio_ioctl(cdi, cmd, NULL);
-                }
-        } /* switch */
+        case CDROMRESUME:
+                return cdrom_ioctl_audioctl(cdi, cmd);
+        }
 
-        /* do the device specific ioctls */
-        if (CDROM_CAN(CDC_IOCTLS))
-                return cdo->dev_ioctl(cdi, cmd, arg);
-        
         return -ENOSYS;
 }
 
diff --git a/drivers/cdrom/cdu31a.c b/drivers/cdrom/cdu31a.c
index 378e88d20757..72ffd64e8b1e 100644
--- a/drivers/cdrom/cdu31a.c
+++ b/drivers/cdrom/cdu31a.c
@@ -2668,7 +2668,7 @@ static int scd_audio_ioctl(struct cdrom_device_info *cdi,
         return retval;
 }
 
-static int scd_dev_ioctl(struct cdrom_device_info *cdi,
+static int scd_read_audio(struct cdrom_device_info *cdi,
                          unsigned int cmd, unsigned long arg)
 {
         void __user *argp = (void __user *)arg;
@@ -2894,11 +2894,10 @@ static struct cdrom_device_ops scd_dops = {
         .get_mcn                = scd_get_mcn,
         .reset                  = scd_reset,
         .audio_ioctl            = scd_audio_ioctl,
-        .dev_ioctl              = scd_dev_ioctl,
         .capability             = CDC_OPEN_TRAY | CDC_CLOSE_TRAY | CDC_LOCK |
                                   CDC_SELECT_SPEED | CDC_MULTI_SESSION |
                                   CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO |
-                                  CDC_RESET | CDC_IOCTLS | CDC_DRIVE_STATUS,
+                                  CDC_RESET | CDC_DRIVE_STATUS,
         .n_minors               = 1,
 };
 
@@ -2936,6 +2935,9 @@ static int scd_block_ioctl(struct inode *inode, struct file *file,
                 case CDROMCLOSETRAY:
                         retval = scd_tray_move(&scd_info, 0);
                         break;
+                case CDROMREADAUDIO:
+                        retval = scd_read_audio(&scd_info, CDROMREADAUDIO, arg);
+                        break;
                 default:
                         retval = cdrom_ioctl(file, &scd_info, inode, cmd, arg);
         }
diff --git a/drivers/cdrom/cm206.c b/drivers/cdrom/cm206.c
index ce127f7ec0f6..fad27a87ce35 100644
--- a/drivers/cdrom/cm206.c
+++ b/drivers/cdrom/cm206.c
@@ -1157,32 +1157,6 @@ static int cm206_audio_ioctl(struct cdrom_device_info *cdi, unsigned int cmd,
         }
 }
 
-/* Ioctl. These ioctls are specific to the cm206 driver. I have made
-   some driver statistics accessible through ioctl calls.
- */
-
-static int cm206_ioctl(struct cdrom_device_info *cdi, unsigned int cmd,
-                       unsigned long arg)
-{
-        switch (cmd) {
-#ifdef STATISTICS
-        case CM206CTL_GET_STAT:
-                if (arg >= NR_STATS)
-                        return -EINVAL;
-                else
-                        return cd->stats[arg];
-        case CM206CTL_GET_LAST_STAT:
-                if (arg >= NR_STATS)
-                        return -EINVAL;
-                else
-                        return cd->last_stat[arg];
-#endif
-        default:
-                debug(("Unknown ioctl call 0x%x\n", cmd));
-                return -EINVAL;
-        }
-}
-
 static int cm206_media_changed(struct cdrom_device_info *cdi, int disc_nr)
 {
         if (cd != NULL) {
@@ -1321,11 +1295,10 @@ static struct cdrom_device_ops cm206_dops = {
         .get_mcn                = cm206_get_upc,
         .reset                  = cm206_reset,
         .audio_ioctl            = cm206_audio_ioctl,
-        .dev_ioctl              = cm206_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                   CDC_MULTI_SESSION | CDC_MEDIA_CHANGED |
                                   CDC_MCN | CDC_PLAY_AUDIO | CDC_SELECT_SPEED |
-                                  CDC_IOCTLS | CDC_DRIVE_STATUS,
+                                  CDC_DRIVE_STATUS,
         .n_minors               = 1,
 };
 
@@ -1350,6 +1323,21 @@ static int cm206_block_release(struct inode *inode, struct file *file)
 static int cm206_block_ioctl(struct inode *inode, struct file *file,
                                 unsigned cmd, unsigned long arg)
 {
+        switch (cmd) {
+#ifdef STATISTICS
+        case CM206CTL_GET_STAT:
+                if (arg >= NR_STATS)
+                        return -EINVAL;
+                return cd->stats[arg];
+        case CM206CTL_GET_LAST_STAT:
+                if (arg >= NR_STATS)
+                        return -EINVAL;
+                return cd->last_stat[arg];
+#endif
+        default:
+                break;
+        }
+
         return cdrom_ioctl(file, &cm206_info, inode, cmd, arg);
 }
 
diff --git a/drivers/cdrom/sbpcd.c b/drivers/cdrom/sbpcd.c
index 466e9c2974bd..4760f515f591 100644
--- a/drivers/cdrom/sbpcd.c
+++ b/drivers/cdrom/sbpcd.c
@@ -4160,332 +4160,6 @@ static int sbpcd_get_last_session(struct cdrom_device_info *cdi, struct cdrom_mu
         return  0;
 }
 
-/*==========================================================================*/
-/*==========================================================================*/
-/*
- * ioctl support
- */
-static int sbpcd_dev_ioctl(struct cdrom_device_info *cdi, u_int cmd,
-                      u_long arg)
-{
-        struct sbpcd_drive *p = cdi->handle;
-        int i;
-        
-        msg(DBG_IO2,"ioctl(%s, 0x%08lX, 0x%08lX)\n", cdi->name, cmd, arg);
-        if (p->drv_id==-1) {
-                msg(DBG_INF, "ioctl: bad device: %s\n", cdi->name);
-                return (-ENXIO);             /* no such drive */
-        }
-        down(&ioctl_read_sem);
-        if (p != current_drive)
-                switch_drive(p);
-        
-        msg(DBG_IO2,"ioctl: device %s, request %04X\n",cdi->name,cmd);
-        switch (cmd)            /* Sun-compatible */
-        {
-        case DDIOCSDBG:         /* DDI Debug */
-                if (!capable(CAP_SYS_ADMIN)) RETURN_UP(-EPERM);
-                i=sbpcd_dbg_ioctl(arg,1);
-                RETURN_UP(i);
-        case CDROMRESET:      /* hard reset the drive */
-                msg(DBG_IOC,"ioctl: CDROMRESET entered.\n");
-                i=DriveReset();
-                current_drive->audio_state=0;
-                RETURN_UP(i);
-                
-        case CDROMREADMODE1:
-                msg(DBG_IOC,"ioctl: CDROMREADMODE1 requested.\n");
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */
-                cc_ModeSelect(CD_FRAMESIZE);
-                cc_ModeSense();
-                current_drive->mode=READ_M1;
-                RETURN_UP(0);
-                
-        case CDROMREADMODE2: /* not usable at the moment */
-                msg(DBG_IOC,"ioctl: CDROMREADMODE2 requested.\n");
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */
-                cc_ModeSelect(CD_FRAMESIZE_RAW1);
-                cc_ModeSense();
-                current_drive->mode=READ_M2;
-                RETURN_UP(0);
-                
-        case CDROMAUDIOBUFSIZ: /* configure the audio buffer size */
-                msg(DBG_IOC,"ioctl: CDROMAUDIOBUFSIZ entered.\n");
-                if (current_drive->sbp_audsiz>0)
-                        vfree(current_drive->aud_buf);
-                current_drive->aud_buf=NULL;
-                current_drive->sbp_audsiz=arg;
-                
-                if (current_drive->sbp_audsiz>16)
-                {
-                        current_drive->sbp_audsiz = 0;
-                        RETURN_UP(current_drive->sbp_audsiz);
-                }
-        
-                if (current_drive->sbp_audsiz>0)
-                {
-                        current_drive->aud_buf=(u_char *) vmalloc(current_drive->sbp_audsiz*CD_FRAMESIZE_RAW);
-                        if (current_drive->aud_buf==NULL)
-                        {
-                                msg(DBG_INF,"audio buffer (%d frames) not available.\n",current_drive->sbp_audsiz);
-                                current_drive->sbp_audsiz=0;
-                        }
-                        else msg(DBG_INF,"audio buffer size: %d frames.\n",current_drive->sbp_audsiz);
-                }
-                RETURN_UP(current_drive->sbp_audsiz);
-
-        case CDROMREADAUDIO:
-        { /* start of CDROMREADAUDIO */
-                int i=0, j=0, frame, block=0;
-                u_int try=0;
-                u_long timeout;
-                u_char *p;
-                u_int data_tries = 0;
-                u_int data_waits = 0;
-                u_int data_retrying = 0;
-                int status_tries;
-                int error_flag;
-                
-                msg(DBG_IOC,"ioctl: CDROMREADAUDIO entered.\n");
-                if (fam0_drive) RETURN_UP(-EINVAL);
-                if (famL_drive) RETURN_UP(-EINVAL);
-                if (famV_drive) RETURN_UP(-EINVAL);
-                if (famT_drive) RETURN_UP(-EINVAL);
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
-                if (current_drive->aud_buf==NULL) RETURN_UP(-EINVAL);
-                if (copy_from_user(&read_audio, (void __user *)arg,
-                                   sizeof(struct cdrom_read_audio)))
-                        RETURN_UP(-EFAULT);
-                if (read_audio.nframes < 0 || read_audio.nframes>current_drive->sbp_audsiz) RETURN_UP(-EINVAL);
-                if (!access_ok(VERIFY_WRITE, read_audio.buf,
-                              read_audio.nframes*CD_FRAMESIZE_RAW))
-                        RETURN_UP(-EFAULT);
-                
-                if (read_audio.addr_format==CDROM_MSF) /* MSF-bin specification of where to start */
-                        block=msf2lba(&read_audio.addr.msf.minute);
-                else if (read_audio.addr_format==CDROM_LBA) /* lba specification of where to start */
-                        block=read_audio.addr.lba;
-                else RETURN_UP(-EINVAL);
-#if 000
-                i=cc_SetSpeed(speed_150,0,0);
-                if (i) msg(DBG_AUD,"read_audio: SetSpeed error %d\n", i);
-#endif
-                msg(DBG_AUD,"read_audio: lba: %d, msf: %06X\n",
-                    block, blk2msf(block));
-                msg(DBG_AUD,"read_audio: before cc_ReadStatus.\n");
-#if OLD_BUSY
-                while (busy_data) sbp_sleep(HZ/10); /* wait a bit */
-                busy_audio=1;
-#endif /* OLD_BUSY */ 
-                error_flag=0;
-                for (data_tries=5; data_tries>0; data_tries--)
-                {
-                        msg(DBG_AUD,"data_tries=%d ...\n", data_tries);
-                        current_drive->mode=READ_AU;
-                        cc_ModeSelect(CD_FRAMESIZE_RAW);
-                        cc_ModeSense();
-                        for (status_tries=3; status_tries > 0; status_tries--)
-                        {
-                                flags_cmd_out |= f_respo3;
-                                cc_ReadStatus();
-                                if (sbp_status() != 0) break;
-                                if (st_check) cc_ReadError();
-                                sbp_sleep(1);    /* wait a bit, try again */
-                        }
-                        if (status_tries == 0)
-                        {
-                                msg(DBG_AUD,"read_audio: sbp_status: failed after 3 tries in line %d.\n", __LINE__);
-                                continue;
-                        }
-                        msg(DBG_AUD,"read_audio: sbp_status: ok.\n");
-                        
-                        flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
-                        if (fam0L_drive)
-                        {
-                                flags_cmd_out |= f_lopsta | f_getsta | f_bit1;
-                                cmd_type=READ_M2;
-                                drvcmd[0]=CMD0_READ_XA; /* "read XA frames", old drives */
-                                drvcmd[1]=(block>>16)&0x000000ff;
-                                drvcmd[2]=(block>>8)&0x000000ff;
-                                drvcmd[3]=block&0x000000ff;
-                                drvcmd[4]=0;
-                                drvcmd[5]=read_audio.nframes; /* # of frames */
-                                drvcmd[6]=0;
-                        }
-                        else if (fam1_drive)
-                        {
-                                drvcmd[0]=CMD1_READ; /* "read frames", new drives */
-                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
-                                drvcmd[4]=0;
-                                drvcmd[5]=0;
-                                drvcmd[6]=read_audio.nframes; /* # of frames */
-                        }
-                        else if (fam2_drive)
-                        {
-                                drvcmd[0]=CMD2_READ_XA2;
-                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
-                                drvcmd[4]=0;
-                                drvcmd[5]=read_audio.nframes; /* # of frames */
-                                drvcmd[6]=0x11; /* raw mode */
-                        }
-                        else if (famT_drive) /* CD-55A: not tested yet */
-                        {
-                        }
-                        msg(DBG_AUD,"read_audio: before giving \"read\" command.\n");
-                        flags_cmd_out=f_putcmd;
-                        response_count=0;
-                        i=cmd_out();
-                        if (i<0) msg(DBG_INF,"error giving READ AUDIO command: %0d\n", i);
-                        sbp_sleep(0);
-                        msg(DBG_AUD,"read_audio: after giving \"read\" command.\n");
-                        for (frame=1;frame<2 && !error_flag; frame++)
-                        {
-                                try=maxtim_data;
-                                for (timeout=jiffies+9*HZ; ; )
-                                {
-                                        for ( ; try!=0;try--)
-                                        {
-                                                j=inb(CDi_status);
-                                                if (!(j&s_not_data_ready)) break;
-                                                if (!(j&s_not_result_ready)) break;
-                                                if (fam0L_drive) if (j&s_attention) break;
-                                        }
-                                        if (try != 0 || time_after_eq(jiffies, timeout)) break;
-                                        if (data_retrying == 0) data_waits++;
-                                        data_retrying = 1;
-                                        sbp_sleep(1);
-                                        try = 1;
-                                }
-                                if (try==0)
-                                {
-                                        msg(DBG_INF,"read_audio: sbp_data: CDi_status timeout.\n");
-                                        error_flag++;
-                                        break;
-                                }
-                                msg(DBG_AUD,"read_audio: sbp_data: CDi_status ok.\n");
-                                if (j&s_not_data_ready)
-                                {
-                                        msg(DBG_INF, "read_audio: sbp_data: DATA_READY timeout.\n");
-                                        error_flag++;
-                                        break;
-                                }
-                                msg(DBG_AUD,"read_audio: before reading data.\n");
-                                error_flag=0;
-                                p = current_drive->aud_buf;
-                                if (sbpro_type==1) OUT(CDo_sel_i_d,1);
-                                if (do_16bit)
-                                {
-                                        u_short *p2 = (u_short *) p;
-
-                                        for (; (u_char *) p2 < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
-                                        {
-                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
-
-                                                /* get one sample */
-                                                *p2++ = inw_p(CDi_data);
-                                                *p2++ = inw_p(CDi_data);
-                                        }
-                                } else {
-                                        for (; p < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
-                                        {
-                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
-
-                                                /* get one sample */
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                        }
-                                }
-                                if (sbpro_type==1) OUT(CDo_sel_i_d,0);
-                                data_retrying = 0;
-                        }
-                        msg(DBG_AUD,"read_audio: after reading data.\n");
-                        if (error_flag)    /* must have been spurious D_RDY or (ATTN&&!D_RDY) */
-                        {
-                                msg(DBG_AUD,"read_audio: read aborted by drive\n");
-#if 0000
-                                i=cc_DriveReset();                /* ugly fix to prevent a hang */
-#else
-                                i=cc_ReadError();
-#endif
-                                continue;
-                        }
-                        if (fam0L_drive)
-                        {
-                                i=maxtim_data;
-                                for (timeout=jiffies+9*HZ; time_before(jiffies, timeout); timeout--)
-                                {
-                                        for ( ;i!=0;i--)
-                                        {
-                                                j=inb(CDi_status);
-                                                if (!(j&s_not_data_ready)) break;
-                                                if (!(j&s_not_result_ready)) break;
-                                                if (j&s_attention) break;
-                                        }
-                                        if (i != 0 || time_after_eq(jiffies, timeout)) break;
-                                        sbp_sleep(0);
-                                        i = 1;
-                                }
-                                if (i==0) msg(DBG_AUD,"read_audio: STATUS TIMEOUT AFTER READ");
-                                if (!(j&s_attention))
-                                {
-                                        msg(DBG_AUD,"read_audio: sbp_data: timeout waiting DRV_ATTN - retrying\n");
-                                        i=cc_DriveReset();  /* ugly fix to prevent a hang */
-                                        continue;
-                                }
-                        }
-                        do
-                        {
-                                if (fam0L_drive) cc_ReadStatus();
-                                i=ResponseStatus();  /* builds status_bits, returns orig. status (old) or faked p_success (new) */
-                                if (i<0) { msg(DBG_AUD,
-                                               "read_audio: cc_ReadStatus error after read: %02X\n",
-                                               current_drive->status_bits);
-                                           continue; /* FIXME */
-                                   }
-                        }
-                        while ((fam0L_drive)&&(!st_check)&&(!(i&p_success)));
-                        if (st_check)
-                        {
-                                i=cc_ReadError();
-                                msg(DBG_AUD,"read_audio: cc_ReadError was necessary after read: %02X\n",i);
-                                continue;
-                        }
-                        if (copy_to_user(read_audio.buf,
-                                         current_drive->aud_buf,
-                                         read_audio.nframes * CD_FRAMESIZE_RAW))
-                                RETURN_UP(-EFAULT);
-                        msg(DBG_AUD,"read_audio: copy_to_user done.\n");
-                        break;
-                }
-                cc_ModeSelect(CD_FRAMESIZE);
-                cc_ModeSense();
-                current_drive->mode=READ_M1;
-#if OLD_BUSY
-                busy_audio=0;
-#endif /* OLD_BUSY */ 
-                if (data_tries == 0)
-                {
-                        msg(DBG_AUD,"read_audio: failed after 5 tries in line %d.\n", __LINE__);
-                        RETURN_UP(-EIO);
-                }
-                msg(DBG_AUD,"read_audio: successful return.\n");
-                RETURN_UP(0);
-        } /* end of CDROMREADAUDIO */
-                
-        default:
-                msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
-                RETURN_UP(-EINVAL);
-        } /* end switch(cmd) */
-}
-
 static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                        void * arg)
 {
@@ -4530,7 +4204,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 default:
                         RETURN_UP(-EINVAL);
                 }
-                
+
         case CDROMRESUME: /* resume paused audio play */
                 msg(DBG_IOC,"ioctl: CDROMRESUME entered.\n");
                 /* resume playing audio tracks when a previous PLAY AUDIO call has  */
@@ -4544,12 +4218,12 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 if (i<0) RETURN_UP(-EIO);
                 current_drive->audio_state=audio_playing;
                 RETURN_UP(0);
-                
+
         case CDROMPLAYMSF:
                 msg(DBG_IOC,"ioctl: CDROMPLAYMSF entered.\n");
 #ifdef SAFE_MIXED
                 if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
                 if (current_drive->audio_state==audio_playing)
                 {
                         i=cc_Pause_Resume(1);
@@ -4584,7 +4258,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 msg(DBG_IOC,"ioctl: CDROMPLAYTRKIND entered.\n");
 #ifdef SAFE_MIXED
                 if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
                 if (current_drive->audio_state==audio_playing)
                 {
                         msg(DBG_IOX,"CDROMPLAYTRKIND: already audio_playing.\n");
@@ -4654,13 +4328,13 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 cc_DriveReset();
 #endif
                 RETURN_UP(i);
-                
+
         case CDROMSTART:  /* Spin up the drive */
                 msg(DBG_IOC,"ioctl: CDROMSTART entered.\n");
                 cc_SpinUp();
                 current_drive->audio_state=0;
                 RETURN_UP(0);
-                
+
         case CDROMVOLCTRL:   /* Volume control */
                 msg(DBG_IOC,"ioctl: CDROMVOLCTRL entered.\n");
                 memcpy(&volctrl,(char *) arg,sizeof(volctrl));
@@ -4670,7 +4344,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 current_drive->vol_ctrl1=volctrl.channel1;
                 i=cc_SetVolume();
                 RETURN_UP(0);
-                
+
         case CDROMVOLREAD:   /* read Volume settings from drive */
                 msg(DBG_IOC,"ioctl: CDROMVOLREAD entered.\n");
                 st=cc_GetVolume();
@@ -4694,7 +4368,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 if (i<0) {
                         j=cc_ReadError(); /* clear out error status from drive */
                         current_drive->audio_state=CDROM_AUDIO_NO_STATUS;
-                        /* get and set the disk state here, 
+                        /* get and set the disk state here,
                         probably not the right place, but who cares!
                         It makes it work properly! --AJK */
                         if (current_drive->CD_changed==0xFF) {
@@ -4715,8 +4389,8 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                         }
                 }
                 memcpy(&SC, (void *) arg, sizeof(struct cdrom_subchnl));
-                /* 
-                        This virtual crap is very bogus! 
+                /*
+                        This virtual crap is very bogus!
                         It doesn't detect when the cd is done playing audio!
                         Lets do this right with proper hardware register reading!
                 */
@@ -4775,7 +4449,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                     SC.cdsc_trk,SC.cdsc_ind,
                     SC.cdsc_absaddr,SC.cdsc_reladdr);
                 RETURN_UP(0);
-                
+
         default:
                 msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
                 RETURN_UP(-EINVAL);
@@ -4788,7 +4462,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
 static void sbp_transfer(struct request *req)
 {
         long offs;
-        
+
         while ( (req->nr_sectors > 0) &&
                (req->sector/4 >= current_drive->sbp_first_frame) &&
                (req->sector/4 <= current_drive->sbp_last_frame) )
@@ -4807,11 +4481,11 @@ static void sbp_transfer(struct request *req)
  *
  *  This is a kludge so we don't need to modify end_request.
  *  We put the req we take out after INIT_REQUEST in the requests list,
- *  so that end_request will discard it. 
+ *  so that end_request will discard it.
  *
  *  The bug could be present in other block devices, perhaps we
  *  should modify INIT_REQUEST and end_request instead, and
- *  change every block device.. 
+ *  change every block device..
  *
  *  Could be a race here?? Could e.g. a timer interrupt schedule() us?
  *  If so, we should copy end_request here, and do it right.. (or
@@ -4883,19 +4557,19 @@ static void do_sbpcd_request(request_queue_t * q)
         while (busy_audio) sbp_sleep(HZ); /* wait a bit */
         busy_data=1;
 #endif /* OLD_BUSY */
-        
+
         if (p->audio_state==audio_playing) goto err_done;
         if (p != current_drive)
                 switch_drive(p);
 
         block = req->sector; /* always numbered as 512-byte-pieces */
         nsect = req->nr_sectors; /* always counted as 512-byte-pieces */
-        
+
         msg(DBG_BSZ,"read sector %d (%d sectors)\n", block, nsect);
 #if 0
         msg(DBG_MUL,"read LBA %d\n", block/4);
 #endif
-        
+
         sbp_transfer(req);
         /* if we satisfied the request from the buffer, we're done. */
         if (req->nr_sectors == 0)
@@ -4914,10 +4588,10 @@ static void do_sbpcd_request(request_queue_t * q)
         i=prepare(0,0); /* at moment not really a hassle check, but ... */
         if (i!=0)
                 msg(DBG_INF,"\"prepare\" tells error %d -- ignored\n", i);
-#endif /* FUTURE */ 
-        
+#endif /* FUTURE */
+
         if (!st_spinning) cc_SpinUp();
-        
+
         for (data_tries=n_retries; data_tries > 0; data_tries--)
         {
                 for (status_tries=3; status_tries > 0; status_tries--)
@@ -4940,7 +4614,7 @@ static void do_sbpcd_request(request_queue_t * q)
                 {
 #ifdef SAFE_MIXED
                         current_drive->has_data=2; /* is really a data disk */
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
 #ifdef DEBUG_GTL
                         printk(" do_sbpcd_request[%do](%p:%ld+%ld) end 3, Time:%li\n",
                                 xnr, req, req->sector, req->nr_sectors, jiffies);
@@ -4951,7 +4625,7 @@ static void do_sbpcd_request(request_queue_t * q)
                         goto request_loop;
                 }
         }
-        
+
  err_done:
 #if OLD_BUSY
         busy_data=0;
@@ -4976,7 +4650,7 @@ static void sbp_read_cmd(struct request *req)
 
         int i;
         int block;
-        
+
         current_drive->sbp_first_frame=current_drive->sbp_last_frame=-1;      /* purge buffer */
         current_drive->sbp_current = 0;
         block=req->sector/4;
@@ -4993,7 +4667,7 @@ static void sbp_read_cmd(struct request *req)
                         current_drive->sbp_read_frames=1;
                 }
         }
-        
+
         flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
         clr_cmdbuf();
         if (famV_drive)
@@ -5092,7 +4766,7 @@ static int sbp_data(struct request *req)
         int success;
         int wait;
         int duration;
-        
+
         error_flag=0;
         success=0;
 #if LONG_TIMING
@@ -5105,12 +4779,12 @@ static int sbp_data(struct request *req)
         for (frame=0;frame<current_drive->sbp_read_frames&&!error_flag; frame++)
         {
                 SBPCD_CLI;
-                
+
                 del_timer(&data_timer);
                 data_timer.expires=jiffies+max_latency;
                 timed_out_data=0;
                 add_timer(&data_timer);
-                while (!timed_out_data) 
+                while (!timed_out_data)
                 {
                         if (current_drive->f_multisession) try=maxtim_data*4;
                         else try=maxtim_data;
@@ -5207,9 +4881,9 @@ static int sbp_data(struct request *req)
                         else
                           {
                             sbp_sleep(1);
-                            OUT(CDo_sel_i_d,0); 
+                            OUT(CDo_sel_i_d,0);
                             i=inb(CDi_status);
-                          } 
+                          }
                         if (!(i&s_not_data_ready))
                         {
                                 OUT(CDo_sel_i_d,1);
@@ -5311,7 +4985,7 @@ static int sbp_data(struct request *req)
                 }
                 SBPCD_STI;
         }
-        
+
 #if 0
         if (!success)
 #endif
@@ -5370,7 +5044,326 @@ static int sbpcd_block_ioctl(struct inode *inode, struct file *file,
                                 unsigned cmd, unsigned long arg)
 {
         struct sbpcd_drive *p = inode->i_bdev->bd_disk->private_data;
-        return cdrom_ioctl(file, p->sbpcd_infop, inode, cmd, arg);
+        struct cdrom_device_info *cdi = p->sbpcd_infop;
+        int ret, i;
+
+        ret = cdrom_ioctl(file, p->sbpcd_infop, inode, cmd, arg);
+        if (ret != -ENOSYS)
+                return ret;
+
+        msg(DBG_IO2,"ioctl(%s, 0x%08lX, 0x%08lX)\n", cdi->name, cmd, arg);
+        if (p->drv_id==-1) {
+                msg(DBG_INF, "ioctl: bad device: %s\n", cdi->name);
+                return (-ENXIO);             /* no such drive */
+        }
+        down(&ioctl_read_sem);
+        if (p != current_drive)
+                switch_drive(p);
+        
+        msg(DBG_IO2,"ioctl: device %s, request %04X\n",cdi->name,cmd);
+        switch (cmd)            /* Sun-compatible */
+        {
+        case DDIOCSDBG:         /* DDI Debug */
+                if (!capable(CAP_SYS_ADMIN)) RETURN_UP(-EPERM);
+                i=sbpcd_dbg_ioctl(arg,1);
+                RETURN_UP(i);
+        case CDROMRESET:      /* hard reset the drive */
+                msg(DBG_IOC,"ioctl: CDROMRESET entered.\n");
+                i=DriveReset();
+                current_drive->audio_state=0;
+                RETURN_UP(i);
+
+        case CDROMREADMODE1:
+                msg(DBG_IOC,"ioctl: CDROMREADMODE1 requested.\n");
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                cc_ModeSelect(CD_FRAMESIZE);
+                cc_ModeSense();
+                current_drive->mode=READ_M1;
+                RETURN_UP(0);
+
+        case CDROMREADMODE2: /* not usable at the moment */
+                msg(DBG_IOC,"ioctl: CDROMREADMODE2 requested.\n");
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                cc_ModeSelect(CD_FRAMESIZE_RAW1);
+                cc_ModeSense();
+                current_drive->mode=READ_M2;
+                RETURN_UP(0);
+
+        case CDROMAUDIOBUFSIZ: /* configure the audio buffer size */
+                msg(DBG_IOC,"ioctl: CDROMAUDIOBUFSIZ entered.\n");
+                if (current_drive->sbp_audsiz>0)
+                        vfree(current_drive->aud_buf);
+                current_drive->aud_buf=NULL;
+                current_drive->sbp_audsiz=arg;
+
+                if (current_drive->sbp_audsiz>16)
+                {
+                        current_drive->sbp_audsiz = 0;
+                        RETURN_UP(current_drive->sbp_audsiz);
+                }
+        
+                if (current_drive->sbp_audsiz>0)
+                {
+                        current_drive->aud_buf=(u_char *) vmalloc(current_drive->sbp_audsiz*CD_FRAMESIZE_RAW);
+                        if (current_drive->aud_buf==NULL)
+                        {
+                                msg(DBG_INF,"audio buffer (%d frames) not available.\n",current_drive->sbp_audsiz);
+                                current_drive->sbp_audsiz=0;
+                        }
+                        else msg(DBG_INF,"audio buffer size: %d frames.\n",current_drive->sbp_audsiz);
+                }
+                RETURN_UP(current_drive->sbp_audsiz);
+
+        case CDROMREADAUDIO:
+        { /* start of CDROMREADAUDIO */
+                int i=0, j=0, frame, block=0;
+                u_int try=0;
+                u_long timeout;
+                u_char *p;
+                u_int data_tries = 0;
+                u_int data_waits = 0;
+                u_int data_retrying = 0;
+                int status_tries;
+                int error_flag;
+
+                msg(DBG_IOC,"ioctl: CDROMREADAUDIO entered.\n");
+                if (fam0_drive) RETURN_UP(-EINVAL);
+                if (famL_drive) RETURN_UP(-EINVAL);
+                if (famV_drive) RETURN_UP(-EINVAL);
+                if (famT_drive) RETURN_UP(-EINVAL);
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                if (current_drive->aud_buf==NULL) RETURN_UP(-EINVAL);
+                if (copy_from_user(&read_audio, (void __user *)arg,
+                                   sizeof(struct cdrom_read_audio)))
+                        RETURN_UP(-EFAULT);
+                if (read_audio.nframes < 0 || read_audio.nframes>current_drive->sbp_audsiz) RETURN_UP(-EINVAL);
+                if (!access_ok(VERIFY_WRITE, read_audio.buf,
+                              read_audio.nframes*CD_FRAMESIZE_RAW))
+                        RETURN_UP(-EFAULT);
+
+                if (read_audio.addr_format==CDROM_MSF) /* MSF-bin specification of where to start */
+                        block=msf2lba(&read_audio.addr.msf.minute);
+                else if (read_audio.addr_format==CDROM_LBA) /* lba specification of where to start */
+                        block=read_audio.addr.lba;
+                else RETURN_UP(-EINVAL);
+#if 000
+                i=cc_SetSpeed(speed_150,0,0);
+                if (i) msg(DBG_AUD,"read_audio: SetSpeed error %d\n", i);
+#endif
+                msg(DBG_AUD,"read_audio: lba: %d, msf: %06X\n",
+                    block, blk2msf(block));
+                msg(DBG_AUD,"read_audio: before cc_ReadStatus.\n");
+#if OLD_BUSY
+                while (busy_data) sbp_sleep(HZ/10); /* wait a bit */
+                busy_audio=1;
+#endif /* OLD_BUSY */
+                error_flag=0;
+                for (data_tries=5; data_tries>0; data_tries--)
+                {
+                        msg(DBG_AUD,"data_tries=%d ...\n", data_tries);
+                        current_drive->mode=READ_AU;
+                        cc_ModeSelect(CD_FRAMESIZE_RAW);
+                        cc_ModeSense();
+                        for (status_tries=3; status_tries > 0; status_tries--)
+                        {
+                                flags_cmd_out |= f_respo3;
+                                cc_ReadStatus();
+                                if (sbp_status() != 0) break;
+                                if (st_check) cc_ReadError();
+                                sbp_sleep(1);    /* wait a bit, try again */
+                        }
+                        if (status_tries == 0)
+                        {
+                                msg(DBG_AUD,"read_audio: sbp_status: failed after 3 tries in line %d.\n", __LINE__);
+                                continue;
+                        }
+                        msg(DBG_AUD,"read_audio: sbp_status: ok.\n");
+
+                        flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
+                        if (fam0L_drive)
+                        {
+                                flags_cmd_out |= f_lopsta | f_getsta | f_bit1;
+                                cmd_type=READ_M2;
+                                drvcmd[0]=CMD0_READ_XA; /* "read XA frames", old drives */
+                                drvcmd[1]=(block>>16)&0x000000ff;
+                                drvcmd[2]=(block>>8)&0x000000ff;
+                                drvcmd[3]=block&0x000000ff;
+                                drvcmd[4]=0;
+                                drvcmd[5]=read_audio.nframes; /* # of frames */
+                                drvcmd[6]=0;
+                        }
+                        else if (fam1_drive)
+                        {
+                                drvcmd[0]=CMD1_READ; /* "read frames", new drives */
+                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
+                                drvcmd[4]=0;
+                                drvcmd[5]=0;
+                                drvcmd[6]=read_audio.nframes; /* # of frames */
+                        }
+                        else if (fam2_drive)
+                        {
+                                drvcmd[0]=CMD2_READ_XA2;
+                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
+                                drvcmd[4]=0;
+                                drvcmd[5]=read_audio.nframes; /* # of frames */
+                                drvcmd[6]=0x11; /* raw mode */
+                        }
+                        else if (famT_drive) /* CD-55A: not tested yet */
+                        {
+                        }
+                        msg(DBG_AUD,"read_audio: before giving \"read\" command.\n");
+                        flags_cmd_out=f_putcmd;
+                        response_count=0;
+                        i=cmd_out();
+                        if (i<0) msg(DBG_INF,"error giving READ AUDIO command: %0d\n", i);
+                        sbp_sleep(0);
+                        msg(DBG_AUD,"read_audio: after giving \"read\" command.\n");
+                        for (frame=1;frame<2 && !error_flag; frame++)
+                        {
+                                try=maxtim_data;
+                                for (timeout=jiffies+9*HZ; ; )
+                                {
+                                        for ( ; try!=0;try--)
+                                        {
+                                                j=inb(CDi_status);
+                                                if (!(j&s_not_data_ready)) break;
+                                                if (!(j&s_not_result_ready)) break;
+                                                if (fam0L_drive) if (j&s_attention) break;
+                                        }
+                                        if (try != 0 || time_after_eq(jiffies, timeout)) break;
+                                        if (data_retrying == 0) data_waits++;
+                                        data_retrying = 1;
+                                        sbp_sleep(1);
+                                        try = 1;
+                                }
+                                if (try==0)
+                                {
+                                        msg(DBG_INF,"read_audio: sbp_data: CDi_status timeout.\n");
+                                        error_flag++;
+                                        break;
+                                }
+                                msg(DBG_AUD,"read_audio: sbp_data: CDi_status ok.\n");
+                                if (j&s_not_data_ready)
+                                {
+                                        msg(DBG_INF, "read_audio: sbp_data: DATA_READY timeout.\n");
+                                        error_flag++;
+                                        break;
+                                }
+                                msg(DBG_AUD,"read_audio: before reading data.\n");
+                                error_flag=0;
+                                p = current_drive->aud_buf;
+                                if (sbpro_type==1) OUT(CDo_sel_i_d,1);
+                                if (do_16bit)
+                                {
+                                        u_short *p2 = (u_short *) p;
+
+                                        for (; (u_char *) p2 < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
+                                        {
+                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
+
+                                                /* get one sample */
+                                                *p2++ = inw_p(CDi_data);
+                                                *p2++ = inw_p(CDi_data);
+                                        }
+                                } else {
+                                        for (; p < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
+                                        {
+                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
+
+                                                /* get one sample */
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                        }
+                                }
+                                if (sbpro_type==1) OUT(CDo_sel_i_d,0);
+                                data_retrying = 0;
+                        }
+                        msg(DBG_AUD,"read_audio: after reading data.\n");
+                        if (error_flag)    /* must have been spurious D_RDY or (ATTN&&!D_RDY) */
+                        {
+                                msg(DBG_AUD,"read_audio: read aborted by drive\n");
+#if 0000
+                                i=cc_DriveReset();                /* ugly fix to prevent a hang */
+#else
+                                i=cc_ReadError();
+#endif
+                                continue;
+                        }
+                        if (fam0L_drive)
+                        {
+                                i=maxtim_data;
+                                for (timeout=jiffies+9*HZ; time_before(jiffies, timeout); timeout--)
+                                {
+                                        for ( ;i!=0;i--)
+                                        {
+                                                j=inb(CDi_status);
+                                                if (!(j&s_not_data_ready)) break;
+                                                if (!(j&s_not_result_ready)) break;
+                                                if (j&s_attention) break;
+                                        }
+                                        if (i != 0 || time_after_eq(jiffies, timeout)) break;
+                                        sbp_sleep(0);
+                                        i = 1;
+                                }
+                                if (i==0) msg(DBG_AUD,"read_audio: STATUS TIMEOUT AFTER READ");
+                                if (!(j&s_attention))
+                                {
+                                        msg(DBG_AUD,"read_audio: sbp_data: timeout waiting DRV_ATTN - retrying\n");
+                                        i=cc_DriveReset();  /* ugly fix to prevent a hang */
+                                        continue;
+                                }
+                        }
+                        do
+                        {
+                                if (fam0L_drive) cc_ReadStatus();
+                                i=ResponseStatus();  /* builds status_bits, returns orig. status (old) or faked p_success (new) */
+                                if (i<0) { msg(DBG_AUD,
+                                               "read_audio: cc_ReadStatus error after read: %02X\n",
+                                               current_drive->status_bits);
+                                           continue; /* FIXME */
+                                   }
+                        }
+                        while ((fam0L_drive)&&(!st_check)&&(!(i&p_success)));
+                        if (st_check)
+                        {
+                                i=cc_ReadError();
+                                msg(DBG_AUD,"read_audio: cc_ReadError was necessary after read: %02X\n",i);
+                                continue;
+                        }
+                        if (copy_to_user(read_audio.buf,
+                                         current_drive->aud_buf,
+                                         read_audio.nframes * CD_FRAMESIZE_RAW))
+                                RETURN_UP(-EFAULT);
+                        msg(DBG_AUD,"read_audio: copy_to_user done.\n");
+                        break;
+                }
+                cc_ModeSelect(CD_FRAMESIZE);
+                cc_ModeSense();
+                current_drive->mode=READ_M1;
+#if OLD_BUSY
+                busy_audio=0;
+#endif /* OLD_BUSY */
+                if (data_tries == 0)
+                {
+                        msg(DBG_AUD,"read_audio: failed after 5 tries in line %d.\n", __LINE__);
+                        RETURN_UP(-EIO);
+                }
+                msg(DBG_AUD,"read_audio: successful return.\n");
+                RETURN_UP(0);
+        } /* end of CDROMREADAUDIO */
+
+        default:
+                msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
+                RETURN_UP(-EINVAL);
+        } /* end switch(cmd) */
 }
 
 static int sbpcd_block_media_changed(struct gendisk *disk)
@@ -5478,10 +5471,9 @@ static struct cdrom_device_ops sbpcd_dops = {
         .get_mcn                = sbpcd_get_mcn,
         .reset                  = sbpcd_reset,
         .audio_ioctl            = sbpcd_audio_ioctl,
-        .dev_ioctl              = sbpcd_dev_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                 CDC_MULTI_SESSION | CDC_MEDIA_CHANGED |
-                                CDC_MCN | CDC_PLAY_AUDIO | CDC_IOCTLS,
+                                CDC_MCN | CDC_PLAY_AUDIO,
         .n_minors               = 1,
 };
 
diff --git a/drivers/cdrom/viocd.c b/drivers/cdrom/viocd.c
index e27617259552..c0f817ba7adb 100644
--- a/drivers/cdrom/viocd.c
+++ b/drivers/cdrom/viocd.c
@@ -627,7 +627,7 @@ static struct cdrom_device_ops viocd_dops = {
         .media_changed = viocd_media_changed,
         .lock_door = viocd_lock_door,
         .generic_packet = viocd_packet,
-        .capability = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK | CDC_SELECT_SPEED | CDC_SELECT_DISC | CDC_MULTI_SESSION | CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET | CDC_IOCTLS | CDC_DRIVE_STATUS | CDC_GENERIC_PACKET | CDC_CD_R | CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_RAM
+        .capability = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK | CDC_SELECT_SPEED | CDC_SELECT_DISC | CDC_MULTI_SESSION | CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET | CDC_DRIVE_STATUS | CDC_GENERIC_PACKET | CDC_CD_R | CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_RAM
 };
 
 static int __init find_capability(const char *type)
diff --git a/drivers/char/amiserial.c b/drivers/char/amiserial.c
index 7ac365b5d9ec..6602b3156df5 100644
--- a/drivers/char/amiserial.c
+++ b/drivers/char/amiserial.c
@@ -46,8 +46,6 @@
 
 /* Sanity checks */
 
-#define SERIAL_INLINE
-  
 #if defined(MODULE) && defined(SERIAL_DEBUG_MCOUNT)
 #define DBG_CNT(s) printk("(%s): [%x] refc=%d, serc=%d, ttyc=%d -> %s\n", \
  tty->name, (info->flags), serial_driver->refcount,info->count,tty->count,s)
@@ -95,10 +93,6 @@ static char *serial_version = "4.30";
 #include <asm/amigahw.h>
 #include <asm/amigaints.h>
 
-#ifdef SERIAL_INLINE
-#define _INLINE_ inline
-#endif
-
 #define custom amiga_custom
 static char *serial_name = "Amiga-builtin serial driver";
 
@@ -253,14 +247,14 @@ static void rs_start(struct tty_struct *tty)
  * This routine is used by the interrupt handler to schedule
  * processing in the software interrupt portion of the driver.
  */
-static _INLINE_ void rs_sched_event(struct async_struct *info,
-                                  int event)
+static void rs_sched_event(struct async_struct *info,
+                           int event)
 {
         info->event |= 1 << event;
         tasklet_schedule(&info->tlet);
 }
 
-static _INLINE_ void receive_chars(struct async_struct *info)
+static void receive_chars(struct async_struct *info)
 {
         int status;
         int serdatr;
@@ -349,7 +343,7 @@ out:
         return;
 }
 
-static _INLINE_ void transmit_chars(struct async_struct *info)
+static void transmit_chars(struct async_struct *info)
 {
         custom.intreq = IF_TBE;
         mb();
@@ -389,7 +383,7 @@ static _INLINE_ void transmit_chars(struct async_struct *info)
         }
 }
 
-static _INLINE_ void check_modem_status(struct async_struct *info)
+static void check_modem_status(struct async_struct *info)
 {
         unsigned char status = ciab.pra & (SER_DCD | SER_CTS | SER_DSR);
         unsigned char dstatus;
@@ -1959,7 +1953,7 @@ done:
  * number, and identifies which options were configured into this
  * driver.
  */
-static _INLINE_ void show_serial_version(void)
+static void show_serial_version(void)
 {
         printk(KERN_INFO "%s version %s\n", serial_name, serial_version);
 }
diff --git a/drivers/char/generic_serial.c b/drivers/char/generic_serial.c
index e38a5f0e07bb..5e59c0b42731 100644
--- a/drivers/char/generic_serial.c
+++ b/drivers/char/generic_serial.c
@@ -48,8 +48,8 @@ static int gs_debug;
 #define NEW_WRITE_LOCKING 1
 #if NEW_WRITE_LOCKING
 #define DECL      /* Nothing */
-#define LOCKIT    down (& port->port_write_sem);
-#define RELEASEIT up (&port->port_write_sem);
+#define LOCKIT    mutex_lock(& port->port_write_mutex);
+#define RELEASEIT mutex_unlock(&port->port_write_mutex);
 #else
 #define DECL      unsigned long flags;
 #define LOCKIT    save_flags (flags);cli ()
@@ -124,14 +124,14 @@ int gs_write(struct tty_struct * tty,
         /* get exclusive "write" access to this port (problem 3) */
         /* This is not a spinlock because we can have a disk access (page 
                  fault) in copy_from_user */
-        down (& port->port_write_sem);
+        mutex_lock(& port->port_write_mutex);
 
         while (1) {
 
                 c = count;
  
                 /* This is safe because we "OWN" the "head". Noone else can 
-                   change the "head": we own the port_write_sem. */
+                   change the "head": we own the port_write_mutex. */
                 /* Don't overrun the end of the buffer */
                 t = SERIAL_XMIT_SIZE - port->xmit_head;
                 if (t < c) c = t;
@@ -153,7 +153,7 @@ int gs_write(struct tty_struct * tty,
                 count -= c;
                 total += c;
         }
-        up (& port->port_write_sem);
+        mutex_unlock(& port->port_write_mutex);
 
         gs_dprintk (GS_DEBUG_WRITE, "write: interrupts are %s\n", 
                     (port->flags & GS_TX_INTEN)?"enabled": "disabled"); 
@@ -214,7 +214,7 @@ int gs_write(struct tty_struct * tty,
                 c = count;
 
                 /* This is safe because we "OWN" the "head". Noone else can 
-                   change the "head": we own the port_write_sem. */
+                   change the "head": we own the port_write_mutex. */
                 /* Don't overrun the end of the buffer */
                 t = SERIAL_XMIT_SIZE - port->xmit_head;
                 if (t < c) c = t;
@@ -888,7 +888,7 @@ int gs_init_port(struct gs_port *port)
         spin_lock_irqsave (&port->driver_lock, flags);
         if (port->tty) 
                 clear_bit(TTY_IO_ERROR, &port->tty->flags);
-        init_MUTEX(&port->port_write_sem);
+        mutex_init(&port->port_write_mutex);
         port->xmit_cnt = port->xmit_head = port->xmit_tail = 0;
         spin_unlock_irqrestore(&port->driver_lock, flags);
         gs_set_termios(port->tty, NULL);
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index 28c5a3193b81..ede128356af2 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -181,7 +181,6 @@ static struct tty_driver	*stli_serial;
  *      is already swapping a shared buffer won't make things any worse.
  */
 static char                     *stli_tmpwritebuf;
-static DECLARE_MUTEX(stli_tmpwritesem);
 
 #define STLI_TXBUFSIZE          4096
 
diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
index ccad7ae94541..ede365d05387 100644
--- a/drivers/char/n_tty.c
+++ b/drivers/char/n_tty.c
@@ -132,7 +132,7 @@ static void put_tty_queue(unsigned char c, struct tty_struct *tty)
  *      We test the TTY_THROTTLED bit first so that it always
  *      indicates the current state. The decision about whether
  *      it is worth allowing more input has been taken by the caller.
- *      Can sleep, may be called under the atomic_read semaphore but
+ *      Can sleep, may be called under the atomic_read_lock mutex but
  *      this is not guaranteed.
  */
  
@@ -1132,7 +1132,7 @@ static inline int input_available_p(struct tty_struct *tty, int amt)
  *      buffer, and once to drain the space from the (physical) beginning of
  *      the buffer to head pointer.
  *
- *      Called under the tty->atomic_read sem and with TTY_DONT_FLIP set
+ *      Called under the tty->atomic_read_lock sem and with TTY_DONT_FLIP set
  *
  */
  
@@ -1262,11 +1262,11 @@ do_it_again:
          *      Internal serialization of reads.
          */
         if (file->f_flags & O_NONBLOCK) {
-                if (down_trylock(&tty->atomic_read))
+                if (!mutex_trylock(&tty->atomic_read_lock))
                         return -EAGAIN;
         }
         else {
-                if (down_interruptible(&tty->atomic_read))
+                if (mutex_lock_interruptible(&tty->atomic_read_lock))
                         return -ERESTARTSYS;
         }
 
@@ -1393,7 +1393,7 @@ do_it_again:
                         timeout = time;
         }
         clear_bit(TTY_DONT_FLIP, &tty->flags);
-        up(&tty->atomic_read);
+        mutex_unlock(&tty->atomic_read_lock);
         remove_wait_queue(&tty->read_wait, &wait);
 
         if (!waitqueue_active(&tty->read_wait))
diff --git a/drivers/char/nwflash.c b/drivers/char/nwflash.c
index ca41d62b1d9d..8865387d3448 100644
--- a/drivers/char/nwflash.c
+++ b/drivers/char/nwflash.c
@@ -27,6 +27,7 @@
 #include <linux/rwsem.h>
 #include <linux/init.h>
 #include <linux/smp_lock.h>
+#include <linux/mutex.h>
 
 #include <asm/hardware/dec21285.h>
 #include <asm/io.h>
@@ -56,7 +57,7 @@ static int gbWriteEnable;
 static int gbWriteBase64Enable;
 static volatile unsigned char *FLASH_BASE;
 static int gbFlashSize = KFLASH_SIZE;
-static DECLARE_MUTEX(nwflash_sem);
+static DEFINE_MUTEX(nwflash_mutex);
 
 extern spinlock_t gpio_lock;
 
@@ -140,7 +141,7 @@ static ssize_t flash_read(struct file *file, char __user *buf, size_t size,
                 /*
                  * We now lock against reads and writes. --rmk
                  */
-                if (down_interruptible(&nwflash_sem))
+                if (mutex_lock_interruptible(&nwflash_mutex))
                         return -ERESTARTSYS;
 
                 ret = copy_to_user(buf, (void *)(FLASH_BASE + p), count);
@@ -149,7 +150,7 @@ static ssize_t flash_read(struct file *file, char __user *buf, size_t size,
                         *ppos += count;
                 } else
                         ret = -EFAULT;
-                up(&nwflash_sem);
+                mutex_unlock(&nwflash_mutex);
         }
         return ret;
 }
@@ -188,7 +189,7 @@ static ssize_t flash_write(struct file *file, const char __user *buf,
         /*
          * We now lock against reads and writes. --rmk
          */
-        if (down_interruptible(&nwflash_sem))
+        if (mutex_lock_interruptible(&nwflash_mutex))
                 return -ERESTARTSYS;
 
         written = 0;
@@ -277,7 +278,7 @@ static ssize_t flash_write(struct file *file, const char __user *buf,
          */
         leds_event(led_release);
 
-        up(&nwflash_sem);
+        mutex_unlock(&nwflash_mutex);
 
         return written;
 }
diff --git a/drivers/char/raw.c b/drivers/char/raw.c
index 30e4cbe16bb0..15a7b4086524 100644
--- a/drivers/char/raw.c
+++ b/drivers/char/raw.c
@@ -19,6 +19,7 @@
 #include <linux/uio.h>
 #include <linux/cdev.h>
 #include <linux/device.h>
+#include <linux/mutex.h>
 
 #include <asm/uaccess.h>
 
@@ -29,7 +30,7 @@ struct raw_device_data {
 
 static struct class *raw_class;
 static struct raw_device_data raw_devices[MAX_RAW_MINORS];
-static DECLARE_MUTEX(raw_mutex);
+static DEFINE_MUTEX(raw_mutex);
 static struct file_operations raw_ctl_fops;          /* forward declaration */
 
 /*
@@ -53,7 +54,7 @@ static int raw_open(struct inode *inode, struct file *filp)
                 return 0;
         }
 
-        down(&raw_mutex);
+        mutex_lock(&raw_mutex);
 
         /*
          * All we need to do on open is check that the device is bound.
@@ -78,7 +79,7 @@ static int raw_open(struct inode *inode, struct file *filp)
                 filp->f_dentry->d_inode->i_mapping =
                         bdev->bd_inode->i_mapping;
         filp->private_data = bdev;
-        up(&raw_mutex);
+        mutex_unlock(&raw_mutex);
         return 0;
 
 out2:
@@ -86,7 +87,7 @@ out2:
 out1:
         blkdev_put(bdev);
 out:
-        up(&raw_mutex);
+        mutex_unlock(&raw_mutex);
         return err;
 }
 
@@ -99,14 +100,14 @@ static int raw_release(struct inode *inode, struct file *filp)
         const int minor= iminor(inode);
         struct block_device *bdev;
 
-        down(&raw_mutex);
+        mutex_lock(&raw_mutex);
         bdev = raw_devices[minor].binding;
         if (--raw_devices[minor].inuse == 0) {
                 /* Here  inode->i_mapping == bdev->bd_inode->i_mapping  */
                 inode->i_mapping = &inode->i_data;
                 inode->i_mapping->backing_dev_info = &default_backing_dev_info;
         }
-        up(&raw_mutex);
+        mutex_unlock(&raw_mutex);
 
         bd_release(bdev);
         blkdev_put(bdev);
@@ -187,9 +188,9 @@ static int raw_ctl_ioctl(struct inode *inode, struct file *filp,
                                 goto out;
                         }
 
-                        down(&raw_mutex);
+                        mutex_lock(&raw_mutex);
                         if (rawdev->inuse) {
-                                up(&raw_mutex);
+                                mutex_unlock(&raw_mutex);
                                 err = -EBUSY;
                                 goto out;
                         }
@@ -211,11 +212,11 @@ static int raw_ctl_ioctl(struct inode *inode, struct file *filp,
                                         bind_device(&rq);
                                 }
                         }
-                        up(&raw_mutex);
+                        mutex_unlock(&raw_mutex);
                 } else {
                         struct block_device *bdev;
 
-                        down(&raw_mutex);
+                        mutex_lock(&raw_mutex);
                         bdev = rawdev->binding;
                         if (bdev) {
                                 rq.block_major = MAJOR(bdev->bd_dev);
@@ -223,7 +224,7 @@ static int raw_ctl_ioctl(struct inode *inode, struct file *filp,
                         } else {
                                 rq.block_major = rq.block_minor = 0;
                         }
-                        up(&raw_mutex);
+                        mutex_unlock(&raw_mutex);
                         if (copy_to_user((void __user *)arg, &rq, sizeof(rq))) {
                                 err = -EFAULT;
                                 goto out;
diff --git a/drivers/char/ser_a2232.c b/drivers/char/ser_a2232.c
index fee68cc895f8..510bd3e0e88b 100644
--- a/drivers/char/ser_a2232.c
+++ b/drivers/char/ser_a2232.c
@@ -97,7 +97,7 @@
 #include <asm/amigahw.h>
 #include <linux/zorro.h>
 #include <asm/irq.h>
-#include <asm/semaphore.h>
+#include <linux/mutex.h>
 
 #include <linux/delay.h>
 
@@ -654,7 +654,7 @@ static void a2232_init_portstructs(void)
                 port->gs.closing_wait = 30 * HZ;
                 port->gs.rd = &a2232_real_driver;
 #ifdef NEW_WRITE_LOCKING
-                init_MUTEX(&(port->gs.port_write_sem));
+                init_MUTEX(&(port->gs.port_write_mutex));
 #endif
                 init_waitqueue_head(&port->gs.open_wait);
                 init_waitqueue_head(&port->gs.close_wait);
diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c
index 0e7d216e7eb0..b543821d8cb4 100644
--- a/drivers/char/snsc.c
+++ b/drivers/char/snsc.c
@@ -5,7 +5,7 @@
  * License.  See the file "COPYING" in the main directory of this archive
  * for more details.
  *
- * Copyright (C) 2004 Silicon Graphics, Inc. All rights reserved.
+ * Copyright (C) 2004, 2006 Silicon Graphics, Inc. All rights reserved.
  */
 
 /*
@@ -77,7 +77,7 @@ scdrv_open(struct inode *inode, struct file *file)
         scd = container_of(inode->i_cdev, struct sysctl_data_s, scd_cdev);
 
         /* allocate memory for subchannel data */
-        sd = kmalloc(sizeof (struct subch_data_s), GFP_KERNEL);
+        sd = kzalloc(sizeof (struct subch_data_s), GFP_KERNEL);
         if (sd == NULL) {
                 printk("%s: couldn't allocate subchannel data\n",
                        __FUNCTION__);
@@ -85,7 +85,6 @@ scdrv_open(struct inode *inode, struct file *file)
         }
 
         /* initialize subch_data_s fields */
-        memset(sd, 0, sizeof (struct subch_data_s));
         sd->sd_nasid = scd->scd_nasid;
         sd->sd_subch = ia64_sn_irtr_open(scd->scd_nasid);
 
@@ -394,7 +393,7 @@ scdrv_init(void)
                         sprintf(devnamep, "#%d", geo_slab(geoid));
 
                         /* allocate sysctl device data */
-                        scd = kmalloc(sizeof (struct sysctl_data_s),
+                        scd = kzalloc(sizeof (struct sysctl_data_s),
                                       GFP_KERNEL);
                         if (!scd) {
                                 printk("%s: failed to allocate device info"
@@ -402,7 +401,6 @@ scdrv_init(void)
                                        SYSCTL_BASENAME, devname);
                                 continue;
                         }
-                        memset(scd, 0, sizeof (struct sysctl_data_s));
 
                         /* initialize sysctl device data fields */
                         scd->scd_nasid = cnodeid_to_nasid(cnode);
diff --git a/drivers/char/snsc_event.c b/drivers/char/snsc_event.c
index a4fa507eed9e..e234d50e142a 100644
--- a/drivers/char/snsc_event.c
+++ b/drivers/char/snsc_event.c
@@ -287,7 +287,7 @@ scdrv_event_init(struct sysctl_data_s *scd)
 {
         int rv;
 
-        event_sd = kmalloc(sizeof (struct subch_data_s), GFP_KERNEL);
+        event_sd = kzalloc(sizeof (struct subch_data_s), GFP_KERNEL);
         if (event_sd == NULL) {
                 printk(KERN_WARNING "%s: couldn't allocate subchannel info"
                        " for event monitoring\n", __FUNCTION__);
@@ -295,7 +295,6 @@ scdrv_event_init(struct sysctl_data_s *scd)
         }
 
         /* initialize subch_data_s fields */
-        memset(event_sd, 0, sizeof (struct subch_data_s));
         event_sd->sd_nasid = scd->scd_nasid;
         spin_lock_init(&event_sd->sd_rlock);
 
@@ -321,5 +320,3 @@ scdrv_event_init(struct sysctl_data_s *scd)
                 return;
         }
 }
-
-
diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
index bdaab6992109..3f5d6077f39c 100644
--- a/drivers/char/stallion.c
+++ b/drivers/char/stallion.c
@@ -148,7 +148,6 @@ static struct tty_driver	*stl_serial;
  *      is already swapping a shared buffer won't make things any worse.
  */
 static char                     *stl_tmpwritebuf;
-static DECLARE_MUTEX(stl_tmpwritesem);
 
 /*
  *      Define a local default termios struct. All ports will be created
diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index a6b4f02bdceb..3b4747230270 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -2318,7 +2318,7 @@ static int sx_init_portstructs (int nboards, int nports)
                         port->board = board;
                         port->gs.rd = &sx_real_driver;
 #ifdef NEW_WRITE_LOCKING
-                        port->gs.port_write_sem = MUTEX;
+                        port->gs.port_write_mutex = MUTEX;
 #endif
                         port->gs.driver_lock = SPIN_LOCK_UNLOCKED;
                         /*
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 53d3d066554e..76592ee1fb38 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -130,7 +130,7 @@ LIST_HEAD(tty_drivers);			/* linked list of tty drivers */
 
 /* Semaphore to protect creating and releasing a tty. This is shared with
    vt.c for deeply disgusting hack reasons */
-DECLARE_MUTEX(tty_sem);
+DEFINE_MUTEX(tty_mutex);
 
 #ifdef CONFIG_UNIX98_PTYS
 extern struct tty_driver *ptm_driver;   /* Unix98 pty masters; for /dev/ptmx */
@@ -1188,11 +1188,11 @@ void disassociate_ctty(int on_exit)
 
         lock_kernel();
 
-        down(&tty_sem);
+        mutex_lock(&tty_mutex);
         tty = current->signal->tty;
         if (tty) {
                 tty_pgrp = tty->pgrp;
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 if (on_exit && tty->driver->type != TTY_DRIVER_TYPE_PTY)
                         tty_vhangup(tty);
         } else {
@@ -1200,7 +1200,7 @@ void disassociate_ctty(int on_exit)
                         kill_pg(current->signal->tty_old_pgrp, SIGHUP, on_exit);
                         kill_pg(current->signal->tty_old_pgrp, SIGCONT, on_exit);
                 }
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 unlock_kernel();        
                 return;
         }
@@ -1211,7 +1211,7 @@ void disassociate_ctty(int on_exit)
         }
 
         /* Must lock changes to tty_old_pgrp */
-        down(&tty_sem);
+        mutex_lock(&tty_mutex);
         current->signal->tty_old_pgrp = 0;
         tty->session = 0;
         tty->pgrp = -1;
@@ -1222,7 +1222,7 @@ void disassociate_ctty(int on_exit)
                 p->signal->tty = NULL;
         } while_each_task_pid(current->signal->session, PIDTYPE_SID, p);
         read_unlock(&tasklist_lock);
-        up(&tty_sem);
+        mutex_unlock(&tty_mutex);
         unlock_kernel();
 }
 
@@ -1306,7 +1306,7 @@ static inline ssize_t do_tty_write(
         ssize_t ret = 0, written = 0;
         unsigned int chunk;
         
-        if (down_interruptible(&tty->atomic_write)) {
+        if (mutex_lock_interruptible(&tty->atomic_write_lock)) {
                 return -ERESTARTSYS;
         }
 
@@ -1329,7 +1329,7 @@ static inline ssize_t do_tty_write(
         if (count < chunk)
                 chunk = count;
 
-        /* write_buf/write_cnt is protected by the atomic_write semaphore */
+        /* write_buf/write_cnt is protected by the atomic_write_lock mutex */
         if (tty->write_cnt < chunk) {
                 unsigned char *buf;
 
@@ -1338,7 +1338,7 @@ static inline ssize_t do_tty_write(
 
                 buf = kmalloc(chunk, GFP_KERNEL);
                 if (!buf) {
-                        up(&tty->atomic_write);
+                        mutex_unlock(&tty->atomic_write_lock);
                         return -ENOMEM;
                 }
                 kfree(tty->write_buf);
@@ -1374,7 +1374,7 @@ static inline ssize_t do_tty_write(
                 inode->i_mtime = current_fs_time(inode->i_sb);
                 ret = written;
         }
-        up(&tty->atomic_write);
+        mutex_unlock(&tty->atomic_write_lock);
         return ret;
 }
 
@@ -1442,8 +1442,8 @@ static inline void tty_line_name(struct tty_driver *driver, int index, char *p)
 
 /*
  * WSH 06/09/97: Rewritten to remove races and properly clean up after a
- * failed open.  The new code protects the open with a semaphore, so it's
- * really quite straightforward.  The semaphore locking can probably be
+ * failed open.  The new code protects the open with a mutex, so it's
+ * really quite straightforward.  The mutex locking can probably be
  * relaxed for the (most common) case of reopening a tty.
  */
 static int init_dev(struct tty_driver *driver, int idx,
@@ -1640,7 +1640,7 @@ fast_track:
 success:
         *ret_tty = tty;
         
-        /* All paths come through here to release the semaphore */
+        /* All paths come through here to release the mutex */
 end_init:
         return retval;
 
@@ -1837,7 +1837,7 @@ static void release_dev(struct file * filp)
                 /* Guard against races with tty->count changes elsewhere and
                    opens on /dev/tty */
                    
-                down(&tty_sem);
+                mutex_lock(&tty_mutex);
                 tty_closing = tty->count <= 1;
                 o_tty_closing = o_tty &&
                         (o_tty->count <= (pty_master ? 1 : 0));
@@ -1868,7 +1868,7 @@ static void release_dev(struct file * filp)
 
                 printk(KERN_WARNING "release_dev: %s: read/write wait queue "
                                     "active!\n", tty_name(tty, buf));
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 schedule();
         }       
 
@@ -1934,7 +1934,7 @@ static void release_dev(struct file * filp)
                 read_unlock(&tasklist_lock);
         }
 
-        up(&tty_sem);
+        mutex_unlock(&tty_mutex);
 
         /* check whether both sides are closing ... */
         if (!tty_closing || (o_tty && !o_tty_closing))
@@ -2040,11 +2040,11 @@ retry_open:
         index  = -1;
         retval = 0;
         
-        down(&tty_sem);
+        mutex_lock(&tty_mutex);
 
         if (device == MKDEV(TTYAUX_MAJOR,0)) {
                 if (!current->signal->tty) {
-                        up(&tty_sem);
+                        mutex_unlock(&tty_mutex);
                         return -ENXIO;
                 }
                 driver = current->signal->tty->driver;
@@ -2070,18 +2070,18 @@ retry_open:
                         noctty = 1;
                         goto got_driver;
                 }
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 return -ENODEV;
         }
 
         driver = get_tty_driver(device, &index);
         if (!driver) {
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 return -ENODEV;
         }
 got_driver:
         retval = init_dev(driver, index, &tty);
-        up(&tty_sem);
+        mutex_unlock(&tty_mutex);
         if (retval)
                 return retval;
 
@@ -2167,9 +2167,9 @@ static int ptmx_open(struct inode * inode, struct file * filp)
         }
         up(&allocated_ptys_lock);
 
-        down(&tty_sem);
+        mutex_lock(&tty_mutex);
         retval = init_dev(ptm_driver, index, &tty);
-        up(&tty_sem);
+        mutex_unlock(&tty_mutex);
         
         if (retval)
                 goto out;
@@ -2915,8 +2915,8 @@ static void initialize_tty_struct(struct tty_struct *tty)
         init_waitqueue_head(&tty->write_wait);
         init_waitqueue_head(&tty->read_wait);
         INIT_WORK(&tty->hangup_work, do_tty_hangup, tty);
-        sema_init(&tty->atomic_read, 1);
-        sema_init(&tty->atomic_write, 1);
+        mutex_init(&tty->atomic_read_lock);
+        mutex_init(&tty->atomic_write_lock);
         spin_lock_init(&tty->read_lock);
         INIT_LIST_HEAD(&tty->tty_files);
         INIT_WORK(&tty->SAK_work, NULL, NULL);
diff --git a/drivers/char/vme_scc.c b/drivers/char/vme_scc.c
index d9325281e482..fd00822ac145 100644
--- a/drivers/char/vme_scc.c
+++ b/drivers/char/vme_scc.c
@@ -184,7 +184,7 @@ static void scc_init_portstructs(void)
                 port->gs.closing_wait = 30 * HZ;
                 port->gs.rd = &scc_real_driver;
 #ifdef NEW_WRITE_LOCKING
-                port->gs.port_write_sem = MUTEX;
+                port->gs.port_write_mutex = MUTEX;
 #endif
                 init_waitqueue_head(&port->gs.open_wait);
                 init_waitqueue_head(&port->gs.close_wait);
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 0900d1dbee59..ca4844c527da 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2489,7 +2489,7 @@ static int con_open(struct tty_struct *tty, struct file *filp)
 }
 
 /*
- * We take tty_sem in here to prevent another thread from coming in via init_dev
+ * We take tty_mutex in here to prevent another thread from coming in via init_dev
  * and taking a ref against the tty while we're in the process of forgetting
  * about it and cleaning things up.
  *
@@ -2497,7 +2497,7 @@ static int con_open(struct tty_struct *tty, struct file *filp)
  */
 static void con_close(struct tty_struct *tty, struct file *filp)
 {
-        down(&tty_sem);
+        mutex_lock(&tty_mutex);
         acquire_console_sem();
         if (tty && tty->count == 1) {
                 struct vc_data *vc = tty->driver_data;
@@ -2507,15 +2507,15 @@ static void con_close(struct tty_struct *tty, struct file *filp)
                 tty->driver_data = NULL;
                 release_console_sem();
                 vcs_remove_devfs(tty);
-                up(&tty_sem);
+                mutex_unlock(&tty_mutex);
                 /*
-                 * tty_sem is released, but we still hold BKL, so there is
+                 * tty_mutex is released, but we still hold BKL, so there is
                  * still exclusion against init_dev()
                  */
                 return;
         }
         release_console_sem();
-        up(&tty_sem);
+        mutex_unlock(&tty_mutex);
 }
 
 static void vc_init(struct vc_data *vc, unsigned int rows,
@@ -2869,9 +2869,9 @@ void unblank_screen(void)
 }
 
 /*
- * We defer the timer blanking to work queue so it can take the console semaphore
+ * We defer the timer blanking to work queue so it can take the console mutex
  * (console operations can still happen at irq time, but only from printk which
- * has the console semaphore. Not perfect yet, but better than no locking
+ * has the console mutex. Not perfect yet, but better than no locking
  */
 static void blank_screen_t(unsigned long dummy)
 {
@@ -3234,6 +3234,14 @@ void vcs_scr_writew(struct vc_data *vc, u16 val, u16 *org)
         }
 }
 
+int is_console_suspend_safe(void)
+{
+        /* It is unsafe to suspend devices while X has control of the
+         * hardware. Make sure we are running on a kernel-controlled console.
+         */
+        return vc_cons[fg_console].d->vc_mode == KD_TEXT;
+}
+
 /*
  *      Visible symbols for modules
  */
diff --git a/drivers/char/watchdog/pcwd_usb.c b/drivers/char/watchdog/pcwd_usb.c
index 1533f56baa42..2700c5c45b8a 100644
--- a/drivers/char/watchdog/pcwd_usb.c
+++ b/drivers/char/watchdog/pcwd_usb.c
@@ -42,6 +42,7 @@
 #include <linux/completion.h>
 #include <asm/uaccess.h>
 #include <linux/usb.h>
+#include <linux/mutex.h>
 
 
 #ifdef CONFIG_USB_DEBUG
@@ -143,7 +144,7 @@ struct usb_pcwd_private {
 static struct usb_pcwd_private *usb_pcwd_device;
 
 /* prevent races between open() and disconnect() */
-static DECLARE_MUTEX (disconnect_sem);
+static DEFINE_MUTEX(disconnect_mutex);
 
 /* local function prototypes */
 static int usb_pcwd_probe       (struct usb_interface *interface, const struct usb_device_id *id);
@@ -723,7 +724,7 @@ static void usb_pcwd_disconnect(struct usb_interface *interface)
         struct usb_pcwd_private *usb_pcwd;
 
         /* prevent races with open() */
-        down (&disconnect_sem);
+        mutex_lock(&disconnect_mutex);
 
         usb_pcwd = usb_get_intfdata (interface);
         usb_set_intfdata (interface, NULL);
@@ -749,7 +750,7 @@ static void usb_pcwd_disconnect(struct usb_interface *interface)
 
         cards_found--;
 
-        up (&disconnect_sem);
+        mutex_unlock(&disconnect_mutex);
 
         printk(KERN_INFO PFX "USB PC Watchdog disconnected\n");
 }
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index d7125f4d9113..35897079a78d 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -26,6 +26,7 @@
 #include <linux/netlink.h>
 #include <linux/moduleparam.h>
 #include <linux/connector.h>
+#include <linux/mutex.h>
 
 #include <net/sock.h>
 
@@ -41,7 +42,7 @@ module_param(cn_val, uint, 0);
 MODULE_PARM_DESC(cn_idx, "Connector's main device idx.");
 MODULE_PARM_DESC(cn_val, "Connector's main device val.");
 
-static DECLARE_MUTEX(notify_lock);
+static DEFINE_MUTEX(notify_lock);
 static LIST_HEAD(notify_list);
 
 static struct cn_dev cdev;
@@ -260,7 +261,7 @@ static void cn_notify(struct cb_id *id, u32 notify_event)
 {
         struct cn_ctl_entry *ent;
 
-        down(&notify_lock);
+        mutex_lock(&notify_lock);
         list_for_each_entry(ent, &notify_list, notify_entry) {
                 int i;
                 struct cn_notify_req *req;
@@ -293,7 +294,7 @@ static void cn_notify(struct cb_id *id, u32 notify_event)
                         cn_netlink_send(&m, ctl->group, GFP_KERNEL);
                 }
         }
-        up(&notify_lock);
+        mutex_unlock(&notify_lock);
 }
 
 /*
@@ -407,14 +408,14 @@ static void cn_callback(void *data)
         if (ctl->group == 0) {
                 struct cn_ctl_entry *n;
 
-                down(&notify_lock);
+                mutex_lock(&notify_lock);
                 list_for_each_entry_safe(ent, n, &notify_list, notify_entry) {
                         if (cn_ctl_msg_equals(ent->msg, ctl)) {
                                 list_del(&ent->notify_entry);
                                 kfree(ent);
                         }
                 }
-                up(&notify_lock);
+                mutex_unlock(&notify_lock);
 
                 return;
         }
@@ -429,9 +430,9 @@ static void cn_callback(void *data)
 
         memcpy(ent->msg, ctl, size - sizeof(*ent));
 
-        down(&notify_lock);
+        mutex_lock(&notify_lock);
         list_add(&ent->notify_entry, &notify_list);
-        up(&notify_lock);
+        mutex_unlock(&notify_lock);
 }
 
 static int __init cn_init(void)
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 3a4e5c5b4e1f..d6543fc4a923 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -33,6 +33,7 @@
 #include <linux/spinlock.h>
 #include <linux/string.h>
 #include <linux/types.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 #include <asm/semaphore.h>
 
@@ -48,7 +49,7 @@ static u8 *smi_data_buf;
 static dma_addr_t smi_data_buf_handle;
 static unsigned long smi_data_buf_size;
 static u32 smi_data_buf_phys_addr;
-static DECLARE_MUTEX(smi_data_lock);
+static DEFINE_MUTEX(smi_data_lock);
 
 static unsigned int host_control_action;
 static unsigned int host_control_smi_type;
@@ -139,9 +140,9 @@ static ssize_t smi_data_buf_size_store(struct device *dev,
         buf_size = simple_strtoul(buf, NULL, 10);
 
         /* make sure SMI data buffer is at least buf_size */
-        down(&smi_data_lock);
+        mutex_lock(&smi_data_lock);
         ret = smi_data_buf_realloc(buf_size);
-        up(&smi_data_lock);
+        mutex_unlock(&smi_data_lock);
         if (ret)
                 return ret;
 
@@ -154,7 +155,7 @@ static ssize_t smi_data_read(struct kobject *kobj, char *buf, loff_t pos,
         size_t max_read;
         ssize_t ret;
 
-        down(&smi_data_lock);
+        mutex_lock(&smi_data_lock);
 
         if (pos >= smi_data_buf_size) {
                 ret = 0;
@@ -165,7 +166,7 @@ static ssize_t smi_data_read(struct kobject *kobj, char *buf, loff_t pos,
         ret = min(max_read, count);
         memcpy(buf, smi_data_buf + pos, ret);
 out:
-        up(&smi_data_lock);
+        mutex_unlock(&smi_data_lock);
         return ret;
 }
 
@@ -174,7 +175,7 @@ static ssize_t smi_data_write(struct kobject *kobj, char *buf, loff_t pos,
 {
         ssize_t ret;
 
-        down(&smi_data_lock);
+        mutex_lock(&smi_data_lock);
 
         ret = smi_data_buf_realloc(pos + count);
         if (ret)
@@ -183,7 +184,7 @@ static ssize_t smi_data_write(struct kobject *kobj, char *buf, loff_t pos,
         memcpy(smi_data_buf + pos, buf, count);
         ret = count;
 out:
-        up(&smi_data_lock);
+        mutex_unlock(&smi_data_lock);
         return ret;
 }
 
@@ -201,9 +202,9 @@ static ssize_t host_control_action_store(struct device *dev,
         ssize_t ret;
 
         /* make sure buffer is available for host control command */
-        down(&smi_data_lock);
+        mutex_lock(&smi_data_lock);
         ret = smi_data_buf_realloc(sizeof(struct apm_cmd));
-        up(&smi_data_lock);
+        mutex_unlock(&smi_data_lock);
         if (ret)
                 return ret;
 
@@ -302,7 +303,7 @@ static ssize_t smi_request_store(struct device *dev,
         unsigned long val = simple_strtoul(buf, NULL, 10);
         ssize_t ret;
 
-        down(&smi_data_lock);
+        mutex_lock(&smi_data_lock);
 
         if (smi_data_buf_size < sizeof(struct smi_cmd)) {
                 ret = -ENODEV;
@@ -334,7 +335,7 @@ static ssize_t smi_request_store(struct device *dev,
         }
 
 out:
-        up(&smi_data_lock);
+        mutex_unlock(&smi_data_lock);
         return ret;
 }
 
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 7230d4e08196..99cdc612d2c6 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -406,13 +406,14 @@ config SENSORS_W83L785TS
           will be called w83l785ts.
 
 config SENSORS_W83627HF
-        tristate "Winbond W83627HF, W83627THF, W83637HF, W83697HF"
-        depends on HWMON && I2C && EXPERIMENTAL
+        tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+        depends on HWMON && I2C
         select I2C_ISA
         select HWMON_VID
         help
           If you say yes here you get support for the Winbond W836X7 series
-          of sensor chips: the W83627HF, W83627THF, W83637HF, and the W83697HF
+          of sensor chips: the W83627HF, W83627THF, W83637HF, W83687THF and
+          W83697HF.
 
           This driver can also be built as a module.  If so, the module
           will be called w83627hf.
diff --git a/drivers/hwmon/adm1021.c b/drivers/hwmon/adm1021.c
index 665612729cb9..2b6e74dd4a82 100644
--- a/drivers/hwmon/adm1021.c
+++ b/drivers/hwmon/adm1021.c
@@ -26,6 +26,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 
 /* Addresses to scan */
@@ -92,7 +93,7 @@ struct adm1021_data {
         struct class_device *class_dev;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -162,10 +163,10 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
         struct adm1021_data *data = i2c_get_clientdata(client); \
         int temp = simple_strtoul(buf, NULL, 10);               \
                                                                 \
-        down(&data->update_lock);                               \
+        mutex_lock(&data->update_lock);                         \
         data->value = TEMP_TO_REG(temp);                        \
         adm1021_write_value(client, reg, data->value);          \
-        up(&data->update_lock);                                 \
+        mutex_unlock(&data->update_lock);                       \
         return count;                                           \
 }
 set(temp_max, ADM1021_REG_TOS_W);
@@ -275,7 +276,7 @@ static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind)
         strlcpy(new_client->name, type_name, I2C_NAME_SIZE);
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -351,7 +352,7 @@ static struct adm1021_data *adm1021_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct adm1021_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -375,7 +376,7 @@ static struct adm1021_data *adm1021_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/adm1025.c b/drivers/hwmon/adm1025.c
index 9331c56d2ba6..a4c859c9fbf8 100644
--- a/drivers/hwmon/adm1025.c
+++ b/drivers/hwmon/adm1025.c
@@ -53,6 +53,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -133,7 +134,7 @@ static struct i2c_driver adm1025_driver = {
 struct adm1025_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -207,11 +208,11 @@ static ssize_t set_in##offset##_min(struct device *dev, struct device_attribute
         struct adm1025_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->in_min[offset] = IN_TO_REG(val, in_scale[offset]); \
         i2c_smbus_write_byte_data(client, ADM1025_REG_IN_MIN(offset), \
                                   data->in_min[offset]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 } \
 static ssize_t set_in##offset##_max(struct device *dev, struct device_attribute *attr, const char *buf, \
@@ -221,11 +222,11 @@ static ssize_t set_in##offset##_max(struct device *dev, struct device_attribute
         struct adm1025_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->in_max[offset] = IN_TO_REG(val, in_scale[offset]); \
         i2c_smbus_write_byte_data(client, ADM1025_REG_IN_MAX(offset), \
                                   data->in_max[offset]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 } \
 static DEVICE_ATTR(in##offset##_min, S_IWUSR | S_IRUGO, \
@@ -247,11 +248,11 @@ static ssize_t set_temp##offset##_min(struct device *dev, struct device_attribut
         struct adm1025_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->temp_min[offset-1] = TEMP_TO_REG(val); \
         i2c_smbus_write_byte_data(client, ADM1025_REG_TEMP_LOW(offset-1), \
                                   data->temp_min[offset-1]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 } \
 static ssize_t set_temp##offset##_max(struct device *dev, struct device_attribute *attr, const char *buf, \
@@ -261,11 +262,11 @@ static ssize_t set_temp##offset##_max(struct device *dev, struct device_attribut
         struct adm1025_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->temp_max[offset-1] = TEMP_TO_REG(val); \
         i2c_smbus_write_byte_data(client, ADM1025_REG_TEMP_HIGH(offset-1), \
                                   data->temp_max[offset-1]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 } \
 static DEVICE_ATTR(temp##offset##_min, S_IWUSR | S_IRUGO, \
@@ -404,7 +405,7 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
         /* We can fill in the remaining client fields */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -523,7 +524,7 @@ static struct adm1025_data *adm1025_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct adm1025_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
                 int i;
@@ -558,7 +559,7 @@ static struct adm1025_data *adm1025_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/adm1026.c b/drivers/hwmon/adm1026.c
index fefe6e74fd02..6d4f8b8d358e 100644
--- a/drivers/hwmon/adm1026.c
+++ b/drivers/hwmon/adm1026.c
@@ -32,6 +32,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };
@@ -260,10 +261,10 @@ struct pwm_data {
 struct adm1026_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         int valid;              /* !=0 if following fields are valid */
         unsigned long last_reading;     /* In jiffies */
         unsigned long last_config;      /* In jiffies */
@@ -298,9 +299,8 @@ static int adm1026_attach_adapter(struct i2c_adapter *adapter);
 static int adm1026_detect(struct i2c_adapter *adapter, int address,
         int kind);
 static int adm1026_detach_client(struct i2c_client *client);
-static int adm1026_read_value(struct i2c_client *client, u8 register);
-static int adm1026_write_value(struct i2c_client *client, u8 register,
-        int value); 
+static int adm1026_read_value(struct i2c_client *client, u8 reg);
+static int adm1026_write_value(struct i2c_client *client, u8 reg, int value);
 static void adm1026_print_gpio(struct i2c_client *client);
 static void adm1026_fixup_gpio(struct i2c_client *client); 
 static struct adm1026_data *adm1026_update_device(struct device *dev);
@@ -575,7 +575,7 @@ static struct adm1026_data *adm1026_update_device(struct device *dev)
         int i;
         long value, alarms, gpio;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (!data->valid
             || time_after(jiffies, data->last_reading + ADM1026_DATA_INTERVAL)) {
                 /* Things that change quickly */
@@ -710,7 +710,7 @@ static struct adm1026_data *adm1026_update_device(struct device *dev)
         dev_dbg(&client->dev, "Setting VID from GPIO11-15.\n");
         data->vid = (data->gpio >> 11) & 0x1f;
         data->valid = 1;
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return data;
 }
 
@@ -739,10 +739,10 @@ static ssize_t set_in_min(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = INS_TO_REG(nr, val);
         adm1026_write_value(client, ADM1026_REG_IN_MIN[nr], data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count; 
 }
 static ssize_t show_in_max(struct device *dev, struct device_attribute *attr,
@@ -762,10 +762,10 @@ static ssize_t set_in_max(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = INS_TO_REG(nr, val);
         adm1026_write_value(client, ADM1026_REG_IN_MAX[nr], data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -813,10 +813,10 @@ static ssize_t set_in16_min(struct device *dev, struct device_attribute *attr, c
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[16] = INS_TO_REG(16, val + NEG12_OFFSET);
         adm1026_write_value(client, ADM1026_REG_IN_MIN[16], data->in_min[16]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count; 
 }
 static ssize_t show_in16_max(struct device *dev, struct device_attribute *attr, char *buf)
@@ -831,10 +831,10 @@ static ssize_t set_in16_max(struct device *dev, struct device_attribute *attr, c
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[16] = INS_TO_REG(16, val+NEG12_OFFSET);
         adm1026_write_value(client, ADM1026_REG_IN_MAX[16], data->in_max[16]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -874,11 +874,11 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, data->fan_div[nr]);
         adm1026_write_value(client, ADM1026_REG_FAN_MIN(nr),
                 data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -939,7 +939,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
         if (new_div == 0) {
                 return -EINVAL;
         }
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         orig_div = data->fan_div[nr];
         data->fan_div[nr] = DIV_FROM_REG(new_div);
 
@@ -958,7 +958,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
         if (data->fan_div[nr] != orig_div) {
                 fixup_fan_min(dev,nr,orig_div);
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1001,11 +1001,11 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[nr] = TEMP_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_TEMP_MIN[nr],
                 data->temp_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_temp_max(struct device *dev, struct device_attribute *attr,
@@ -1025,11 +1025,11 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[nr] = TEMP_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_TEMP_MAX[nr],
                 data->temp_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1064,11 +1064,11 @@ static ssize_t set_temp_offset(struct device *dev,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_offset[nr] = TEMP_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_TEMP_OFFSET[nr],
                 data->temp_offset[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1115,11 +1115,11 @@ static ssize_t set_temp_auto_point1_temp(struct device *dev,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_tmin[nr] = TEMP_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_TEMP_TMIN[nr],
                 data->temp_tmin[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1150,11 +1150,11 @@ static ssize_t set_temp_crit_enable(struct device *dev,
         int val = simple_strtol(buf, NULL, 10);
 
         if ((val == 1) || (val==0)) {
-                down(&data->update_lock);
+                mutex_lock(&data->update_lock);
                 data->config1 = (data->config1 & ~CFG1_THERM_HOT) | (val << 4);
                 adm1026_write_value(client, ADM1026_REG_CONFIG1, 
                         data->config1);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
         }
         return count;
 }
@@ -1184,11 +1184,11 @@ static ssize_t set_temp_crit(struct device *dev, struct device_attribute *attr,
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_crit[nr] = TEMP_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_TEMP_THERM[nr],
                 data->temp_crit[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1212,10 +1212,10 @@ static ssize_t set_analog_out_reg(struct device *dev, struct device_attribute *a
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->analog_out = DAC_TO_REG(val);
         adm1026_write_value(client, ADM1026_REG_DAC, data->analog_out);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1267,7 +1267,7 @@ static ssize_t set_alarm_mask(struct device *dev, struct device_attribute *attr,
         int val = simple_strtol(buf, NULL, 10);
         unsigned long mask;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->alarm_mask = val & 0x7fffffff;
         mask = data->alarm_mask
                 | (data->gpio_mask & 0x10000 ? 0x80000000 : 0);
@@ -1282,7 +1282,7 @@ static ssize_t set_alarm_mask(struct device *dev, struct device_attribute *attr,
         mask >>= 8;
         adm1026_write_value(client, ADM1026_REG_MASK4,
                 mask & 0xff);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1303,7 +1303,7 @@ static ssize_t set_gpio(struct device *dev, struct device_attribute *attr, const
         int val = simple_strtol(buf, NULL, 10);
         long   gpio;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->gpio = val & 0x1ffff;
         gpio = data->gpio;
         adm1026_write_value(client, ADM1026_REG_GPIO_STATUS_0_7,gpio & 0xff);
@@ -1311,7 +1311,7 @@ static ssize_t set_gpio(struct device *dev, struct device_attribute *attr, const
         adm1026_write_value(client, ADM1026_REG_GPIO_STATUS_8_15,gpio & 0xff);
         gpio = ((gpio >> 1) & 0x80) | (data->alarms >> 24 & 0x7f);
         adm1026_write_value(client, ADM1026_REG_STATUS4,gpio & 0xff);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1331,7 +1331,7 @@ static ssize_t set_gpio_mask(struct device *dev, struct device_attribute *attr,
         int val = simple_strtol(buf, NULL, 10);
         long   mask;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->gpio_mask = val & 0x1ffff;
         mask = data->gpio_mask;
         adm1026_write_value(client, ADM1026_REG_GPIO_MASK_0_7,mask & 0xff);
@@ -1339,7 +1339,7 @@ static ssize_t set_gpio_mask(struct device *dev, struct device_attribute *attr,
         adm1026_write_value(client, ADM1026_REG_GPIO_MASK_8_15,mask & 0xff);
         mask = ((mask >> 1) & 0x80) | (data->alarm_mask >> 24 & 0x7f);
         adm1026_write_value(client, ADM1026_REG_MASK1,mask & 0xff);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1359,10 +1359,10 @@ static ssize_t set_pwm_reg(struct device *dev, struct device_attribute *attr, co
         if (data->pwm1.enable == 1) {
                 int val = simple_strtol(buf, NULL, 10);
 
-                down(&data->update_lock);
+                mutex_lock(&data->update_lock);
                 data->pwm1.pwm = PWM_TO_REG(val);
                 adm1026_write_value(client, ADM1026_REG_PWM, data->pwm1.pwm);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
         }
         return count;
 }
@@ -1378,14 +1378,14 @@ static ssize_t set_auto_pwm_min(struct device *dev, struct device_attribute *att
         struct adm1026_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm1.auto_pwm_min = SENSORS_LIMIT(val,0,255);
         if (data->pwm1.enable == 2) { /* apply immediately */
                 data->pwm1.pwm = PWM_TO_REG((data->pwm1.pwm & 0x0f) |
                         PWM_MIN_TO_REG(data->pwm1.auto_pwm_min)); 
                 adm1026_write_value(client, ADM1026_REG_PWM, data->pwm1.pwm);
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_auto_pwm_max(struct device *dev, struct device_attribute *attr, char *buf)
@@ -1406,7 +1406,7 @@ static ssize_t set_pwm_enable(struct device *dev, struct device_attribute *attr,
         int     old_enable;
 
         if ((val >= 0) && (val < 3)) {
-                down(&data->update_lock);
+                mutex_lock(&data->update_lock);
                 old_enable = data->pwm1.enable;
                 data->pwm1.enable = val;
                 data->config1 = (data->config1 & ~CFG1_PWM_AFC)
@@ -1424,7 +1424,7 @@ static ssize_t set_pwm_enable(struct device *dev, struct device_attribute *attr,
                         adm1026_write_value(client, ADM1026_REG_PWM, 
                                 data->pwm1.pwm);
                 }
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
         }
         return count;
 }
@@ -1541,7 +1541,7 @@ static int adm1026_detect(struct i2c_adapter *adapter, int address,
         /* Fill in the remaining client fields */
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index d06397966081..3bf2da621aed 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -28,6 +28,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Following macros takes channel parameter starting from 0 to 2 */
 #define ADM1031_REG_FAN_SPEED(nr)       (0x08 + (nr))
@@ -70,7 +71,7 @@ typedef u8 auto_chan_table_t[8][2];
 struct adm1031_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         int chip_type;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
@@ -262,10 +263,10 @@ set_fan_auto_channel(struct device *dev, const char *buf, size_t count, int nr)
 
         old_fan_mode = data->conf1;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         
         if ((ret = get_fan_auto_nearest(data, nr, val, data->conf1, &reg))) {
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return ret;
         }
         if (((data->conf1 = FAN_CHAN_TO_REG(reg, data->conf1)) & ADM1031_CONF1_AUTO_MODE) ^ 
@@ -288,7 +289,7 @@ set_fan_auto_channel(struct device *dev, const char *buf, size_t count, int nr)
         }
         data->conf1 = FAN_CHAN_TO_REG(reg, data->conf1);
         adm1031_write_value(client, ADM1031_REG_CONF1, data->conf1);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -329,11 +330,11 @@ set_auto_temp_min(struct device *dev, const char *buf, size_t count, int nr)
         struct adm1031_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->auto_temp[nr] = AUTO_TEMP_MIN_TO_REG(val, data->auto_temp[nr]);
         adm1031_write_value(client, ADM1031_REG_AUTO_TEMP(nr),
                             data->auto_temp[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_auto_temp_max(struct device *dev, char *buf, int nr)
@@ -349,11 +350,11 @@ set_auto_temp_max(struct device *dev, const char *buf, size_t count, int nr)
         struct adm1031_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[nr] = AUTO_TEMP_MAX_TO_REG(val, data->auto_temp[nr], data->pwm[nr]);
         adm1031_write_value(client, ADM1031_REG_AUTO_TEMP(nr),
                             data->temp_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -405,11 +406,11 @@ set_pwm(struct device *dev, const char *buf, size_t count, int nr)
         int val = simple_strtol(buf, NULL, 10);
         int reg;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if ((data->conf1 & ADM1031_CONF1_AUTO_MODE) && 
             (((val>>4) & 0xf) != 5)) {
                 /* In automatic mode, the only PWM accepted is 33% */
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
         data->pwm[nr] = PWM_TO_REG(val);
@@ -417,7 +418,7 @@ set_pwm(struct device *dev, const char *buf, size_t count, int nr)
         adm1031_write_value(client, ADM1031_REG_PWM,
                             nr ? ((data->pwm[nr] << 4) & 0xf0) | (reg & 0xf)
                             : (data->pwm[nr] & 0xf) | (reg & 0xf0));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -511,7 +512,7 @@ set_fan_min(struct device *dev, const char *buf, size_t count, int nr)
         struct adm1031_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (val) {
                 data->fan_min[nr] = 
                         FAN_TO_REG(val, FAN_DIV_FROM_REG(data->fan_div[nr]));
@@ -519,7 +520,7 @@ set_fan_min(struct device *dev, const char *buf, size_t count, int nr)
                 data->fan_min[nr] = 0xff;
         }
         adm1031_write_value(client, ADM1031_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t
@@ -540,7 +541,7 @@ set_fan_div(struct device *dev, const char *buf, size_t count, int nr)
         if (tmp == 0xff)
                 return -EINVAL;
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         old_div = FAN_DIV_FROM_REG(data->fan_div[nr]);
         data->fan_div[nr] = (tmp & 0xC0) | (0x3f & data->fan_div[nr]);
         new_min = data->fan_min[nr] * old_div / 
@@ -553,7 +554,7 @@ set_fan_div(struct device *dev, const char *buf, size_t count, int nr)
                             data->fan_div[nr]);
         adm1031_write_value(client, ADM1031_REG_FAN_MIN(nr), 
                             data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -627,11 +628,11 @@ set_temp_min(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtol(buf, NULL, 10);
         val = SENSORS_LIMIT(val, -55000, nr == 0 ? 127750 : 127875);
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[nr] = TEMP_TO_REG(val);
         adm1031_write_value(client, ADM1031_REG_TEMP_MIN(nr),
                             data->temp_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t
@@ -643,11 +644,11 @@ set_temp_max(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtol(buf, NULL, 10);
         val = SENSORS_LIMIT(val, -55000, nr == 0 ? 127750 : 127875);
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[nr] = TEMP_TO_REG(val);
         adm1031_write_value(client, ADM1031_REG_TEMP_MAX(nr),
                             data->temp_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t
@@ -659,11 +660,11 @@ set_temp_crit(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtol(buf, NULL, 10);
         val = SENSORS_LIMIT(val, -55000, nr == 0 ? 127750 : 127875);
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_crit[nr] = TEMP_TO_REG(val);
         adm1031_write_value(client, ADM1031_REG_TEMP_CRIT(nr),
                             data->temp_crit[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -778,7 +779,7 @@ static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind)
 
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -891,7 +892,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
         struct adm1031_data *data = i2c_get_clientdata(client);
         int chan;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -965,7 +966,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
index 5ddc22fea4a3..43f6991b588c 100644
--- a/drivers/hwmon/adm9240.c
+++ b/drivers/hwmon/adm9240.c
@@ -49,6 +49,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f,
@@ -150,7 +151,7 @@ struct adm9240_data {
         enum chips type;
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;
         unsigned long last_updated_measure;
         unsigned long last_updated_config;
@@ -195,11 +196,11 @@ static ssize_t set_max(struct device *dev, struct device_attribute *devattr,
         struct adm9240_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[attr->index] = TEMP_TO_REG(val);
         i2c_smbus_write_byte_data(client, ADM9240_REG_TEMP_MAX(attr->index),
                         data->temp_max[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -246,11 +247,11 @@ static ssize_t set_in_min(struct device *dev,
         struct adm9240_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[attr->index] = IN_TO_REG(val, attr->index);
         i2c_smbus_write_byte_data(client, ADM9240_REG_IN_MIN(attr->index),
                         data->in_min[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -263,11 +264,11 @@ static ssize_t set_in_max(struct device *dev,
         struct adm9240_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[attr->index] = IN_TO_REG(val, attr->index);
         i2c_smbus_write_byte_data(client, ADM9240_REG_IN_MAX(attr->index),
                         data->in_max[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -350,7 +351,7 @@ static ssize_t set_fan_min(struct device *dev,
         int nr = attr->index;
         u8 new_div;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (!val) {
                 data->fan_min[nr] = 255;
@@ -390,7 +391,7 @@ static ssize_t set_fan_min(struct device *dev,
         i2c_smbus_write_byte_data(client, ADM9240_REG_FAN_MIN(nr),
                         data->fan_min[nr]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -439,10 +440,10 @@ static ssize_t set_aout(struct device *dev,
         struct adm9240_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->aout = AOUT_TO_REG(val);
         i2c_smbus_write_byte_data(client, ADM9240_REG_ANALOG_OUT, data->aout);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static DEVICE_ATTR(aout_output, S_IRUGO | S_IWUSR, show_aout, set_aout);
@@ -539,7 +540,7 @@ static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
         /* fill in the remaining client fields and attach */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->type = kind;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         if ((err = i2c_attach_client(new_client)))
                 goto exit_free;
@@ -691,7 +692,7 @@ static struct adm9240_data *adm9240_update_device(struct device *dev)
         struct adm9240_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         /* minimum measurement cycle: 1.75 seconds */
         if (time_after(jiffies, data->last_updated_measure + (HZ * 7 / 4))
@@ -771,7 +772,7 @@ static struct adm9240_data *adm9240_update_device(struct device *dev)
                 data->last_updated_config = jiffies;
                 data->valid = 1;
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return data;
 }
 
diff --git a/drivers/hwmon/asb100.c b/drivers/hwmon/asb100.c
index ae9de63cf2e0..65b2709f750c 100644
--- a/drivers/hwmon/asb100.c
+++ b/drivers/hwmon/asb100.c
@@ -44,6 +44,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/jiffies.h>
+#include <linux/mutex.h>
 #include "lm75.h"
 
 /*
@@ -182,10 +183,10 @@ static u8 DIV_TO_REG(long val)
 struct asb100_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         unsigned long last_updated;     /* In jiffies */
 
         /* array of 2 pointers to subclients */
@@ -245,11 +246,11 @@ static ssize_t set_in_##reg(struct device *dev, const char *buf, \
         struct asb100_data *data = i2c_get_clientdata(client); \
         unsigned long val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->in_##reg[nr] = IN_TO_REG(val); \
         asb100_write_value(client, ASB100_REG_IN_##REG(nr), \
                 data->in_##reg[nr]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 
@@ -331,10 +332,10 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct asb100_data *data = i2c_get_clientdata(client);
         u32 val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         asb100_write_value(client, ASB100_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -351,7 +352,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         unsigned long val = simple_strtoul(buf, NULL, 10);
         int reg;
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         min = FAN_FROM_REG(data->fan_min[nr],
                         DIV_FROM_REG(data->fan_div[nr]));
@@ -381,7 +382,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
                 FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         asb100_write_value(client, ASB100_REG_FAN_MIN(nr), data->fan_min[nr]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -461,7 +462,7 @@ static ssize_t set_##reg(struct device *dev, const char *buf, \
         struct asb100_data *data = i2c_get_clientdata(client); \
         unsigned long val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         switch (nr) { \
         case 1: case 2: \
                 data->reg[nr] = LM75_TEMP_TO_REG(val); \
@@ -472,7 +473,7 @@ static ssize_t set_##reg(struct device *dev, const char *buf, \
         } \
         asb100_write_value(client, ASB100_REG_TEMP_##REG(nr+1), \
                         data->reg[nr]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 
@@ -574,11 +575,11 @@ static ssize_t set_pwm1(struct device *dev, struct device_attribute *attr, const
         struct asb100_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm &= 0x80; /* keep the enable bit */
         data->pwm |= (0x0f & ASB100_PWM_TO_REG(val));
         asb100_write_value(client, ASB100_REG_PWM1, data->pwm);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -595,11 +596,11 @@ static ssize_t set_pwm_enable1(struct device *dev, struct device_attribute *attr
         struct asb100_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm &= 0x0f; /* keep the duty cycle bits */
         data->pwm |= (val ? 0x80 : 0x00);
         asb100_write_value(client, ASB100_REG_PWM1, data->pwm);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -729,7 +730,7 @@ static int asb100_detect(struct i2c_adapter *adapter, int address, int kind)
         }
 
         new_client = &data->client;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
         new_client->adapter = adapter;
@@ -789,7 +790,7 @@ static int asb100_detect(struct i2c_adapter *adapter, int address, int kind)
         data->type = kind;
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -885,7 +886,7 @@ static int asb100_read_value(struct i2c_client *client, u16 reg)
         struct i2c_client *cl;
         int res, bank;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
 
         bank = (reg >> 8) & 0x0f;
         if (bank > 2)
@@ -919,7 +920,7 @@ static int asb100_read_value(struct i2c_client *client, u16 reg)
         if (bank > 2)
                 i2c_smbus_write_byte_data(client, ASB100_REG_BANK, 0);
 
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 
         return res;
 }
@@ -930,7 +931,7 @@ static void asb100_write_value(struct i2c_client *client, u16 reg, u16 value)
         struct i2c_client *cl;
         int bank;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
 
         bank = (reg >> 8) & 0x0f;
         if (bank > 2)
@@ -960,7 +961,7 @@ static void asb100_write_value(struct i2c_client *client, u16 reg, u16 value)
         if (bank > 2)
                 i2c_smbus_write_byte_data(client, ASB100_REG_BANK, 0);
 
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 }
 
 static void asb100_init_client(struct i2c_client *client)
@@ -984,7 +985,7 @@ static struct asb100_data *asb100_update_device(struct device *dev)
         struct asb100_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
                 || !data->valid) {
@@ -1042,7 +1043,7 @@ static struct asb100_data *asb100_update_device(struct device *dev)
                 dev_dbg(&client->dev, "... device update complete\n");
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/atxp1.c b/drivers/hwmon/atxp1.c
index b0c490073c8e..728a1e8b9190 100644
--- a/drivers/hwmon/atxp1.c
+++ b/drivers/hwmon/atxp1.c
@@ -26,6 +26,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("System voltages control via Attansic ATXP1");
@@ -60,7 +61,7 @@ static struct i2c_driver atxp1_driver = {
 struct atxp1_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         unsigned long last_updated;
         u8 valid;
         struct {
@@ -80,7 +81,7 @@ static struct atxp1_data * atxp1_update_device(struct device *dev)
         client = to_i2c_client(dev);
         data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
 
@@ -93,7 +94,7 @@ static struct atxp1_data * atxp1_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return(data);
 }
@@ -309,7 +310,7 @@ static int atxp1_detect(struct i2c_adapter *adapter, int address, int kind)
 
         data->valid = 0;
 
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         err = i2c_attach_client(new_client);
 
diff --git a/drivers/hwmon/ds1621.c b/drivers/hwmon/ds1621.c
index 203f9c7abb20..478eb4bb8570 100644
--- a/drivers/hwmon/ds1621.c
+++ b/drivers/hwmon/ds1621.c
@@ -28,6 +28,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include "lm75.h"
 
 /* Addresses to scan */
@@ -72,7 +73,7 @@ MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low")
 struct ds1621_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;                     /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -156,10 +157,10 @@ static ssize_t set_temp_##suffix(struct device *dev, struct device_attribute *at
         struct ds1621_data *data = ds1621_update_client(dev);           \
         u16 val = LM75_TEMP_TO_REG(simple_strtoul(buf, NULL, 10));      \
                                                                         \
-        down(&data->update_lock);                                       \
+        mutex_lock(&data->update_lock);                                 \
         data->value = val;                                              \
         ds1621_write_value(client, reg, data->value);                   \
-        up(&data->update_lock);                                         \
+        mutex_unlock(&data->update_lock);                               \
         return count;                                                   \
 }
 
@@ -242,7 +243,7 @@ static int ds1621_detect(struct i2c_adapter *adapter, int address,
         /* Fill in remaining client fields and put it into the global list */
         strlcpy(new_client->name, "ds1621", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -297,7 +298,7 @@ static struct ds1621_data *ds1621_update_client(struct device *dev)
         struct ds1621_data *data = i2c_get_clientdata(client);
         u8 new_conf;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -327,7 +328,7 @@ static struct ds1621_data *ds1621_update_client(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
index e029e0a94ecc..885465df6e6a 100644
--- a/drivers/hwmon/f71805f.c
+++ b/drivers/hwmon/f71805f.c
@@ -30,6 +30,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 static struct platform_device *pdev;
@@ -131,10 +132,10 @@ static struct resource f71805f_resource __initdata = {
 struct f71805f_data {
         unsigned short addr;
         const char *name;
-        struct semaphore lock;
+        struct mutex lock;
         struct class_device *class_dev;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
         unsigned long last_limits;      /* In jiffies */
@@ -224,20 +225,20 @@ static u8 f71805f_read8(struct f71805f_data *data, u8 reg)
 {
         u8 val;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb(reg, data->addr + ADDR_REG_OFFSET);
         val = inb(data->addr + DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 
         return val;
 }
 
 static void f71805f_write8(struct f71805f_data *data, u8 reg, u8 val)
 {
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb(reg, data->addr + ADDR_REG_OFFSET);
         outb(val, data->addr + DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 }
 
 /* It is important to read the MSB first, because doing so latches the
@@ -246,24 +247,24 @@ static u16 f71805f_read16(struct f71805f_data *data, u8 reg)
 {
         u16 val;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb(reg, data->addr + ADDR_REG_OFFSET);
         val = inb(data->addr + DATA_REG_OFFSET) << 8;
         outb(++reg, data->addr + ADDR_REG_OFFSET);
         val |= inb(data->addr + DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 
         return val;
 }
 
 static void f71805f_write16(struct f71805f_data *data, u8 reg, u16 val)
 {
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb(reg, data->addr + ADDR_REG_OFFSET);
         outb(val >> 8, data->addr + DATA_REG_OFFSET);
         outb(++reg, data->addr + ADDR_REG_OFFSET);
         outb(val & 0xff, data->addr + DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 }
 
 static struct f71805f_data *f71805f_update_device(struct device *dev)
@@ -271,7 +272,7 @@ static struct f71805f_data *f71805f_update_device(struct device *dev)
         struct f71805f_data *data = dev_get_drvdata(dev);
         int nr;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         /* Limit registers cache is refreshed after 60 seconds */
         if (time_after(jiffies, data->last_updated + 60 * HZ)
@@ -323,7 +324,7 @@ static struct f71805f_data *f71805f_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
@@ -362,10 +363,10 @@ static ssize_t set_in0_max(struct device *dev, struct device_attribute
         struct f71805f_data *data = dev_get_drvdata(dev);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_high[0] = in0_to_reg(val);
         f71805f_write8(data, F71805F_REG_IN_HIGH(0), data->in_high[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -376,18 +377,14 @@ static ssize_t set_in0_min(struct device *dev, struct device_attribute
         struct f71805f_data *data = dev_get_drvdata(dev);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_low[0] = in0_to_reg(val);
         f71805f_write8(data, F71805F_REG_IN_LOW(0), data->in_low[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-static DEVICE_ATTR(in0_input, S_IRUGO, show_in0, NULL);
-static DEVICE_ATTR(in0_max, S_IRUGO| S_IWUSR, show_in0_max, set_in0_max);
-static DEVICE_ATTR(in0_min, S_IRUGO| S_IWUSR, show_in0_min, set_in0_min);
-
 static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
                        char *buf)
 {
@@ -426,10 +423,10 @@ static ssize_t set_in_max(struct device *dev, struct device_attribute
         int nr = attr->index;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_high[nr] = in_to_reg(val);
         f71805f_write8(data, F71805F_REG_IN_HIGH(nr), data->in_high[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -442,31 +439,14 @@ static ssize_t set_in_min(struct device *dev, struct device_attribute
         int nr = attr->index;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_low[nr] = in_to_reg(val);
         f71805f_write8(data, F71805F_REG_IN_LOW(nr), data->in_low[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-#define sysfs_in(offset)                                        \
-static SENSOR_DEVICE_ATTR(in##offset##_input, S_IRUGO,          \
-                show_in, NULL, offset);                         \
-static SENSOR_DEVICE_ATTR(in##offset##_max, S_IRUGO | S_IWUSR,  \
-                show_in_max, set_in_max, offset);               \
-static SENSOR_DEVICE_ATTR(in##offset##_min, S_IRUGO | S_IWUSR,  \
-                show_in_min, set_in_min, offset)
-
-sysfs_in(1);
-sysfs_in(2);
-sysfs_in(3);
-sysfs_in(4);
-sysfs_in(5);
-sysfs_in(6);
-sysfs_in(7);
-sysfs_in(8);
-
 static ssize_t show_fan(struct device *dev, struct device_attribute *devattr,
                         char *buf)
 {
@@ -495,24 +475,14 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute
         int nr = attr->index;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_low[nr] = fan_to_reg(val);
         f71805f_write16(data, F71805F_REG_FAN_LOW(nr), data->fan_low[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-#define sysfs_fan(offset)                                       \
-static SENSOR_DEVICE_ATTR(fan##offset##_input, S_IRUGO,         \
-                show_fan, NULL, offset - 1);                    \
-static SENSOR_DEVICE_ATTR(fan##offset##_min, S_IRUGO | S_IWUSR, \
-                show_fan_min, set_fan_min, offset - 1)
-
-sysfs_fan(1);
-sysfs_fan(2);
-sysfs_fan(3);
-
 static ssize_t show_temp(struct device *dev, struct device_attribute *devattr,
                          char *buf)
 {
@@ -562,10 +532,10 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute
         int nr = attr->index;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_high[nr] = temp_to_reg(val);
         f71805f_write8(data, F71805F_REG_TEMP_HIGH(nr), data->temp_high[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -578,28 +548,14 @@ static ssize_t set_temp_hyst(struct device *dev, struct device_attribute
         int nr = attr->index;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_hyst[nr] = temp_to_reg(val);
         f71805f_write8(data, F71805F_REG_TEMP_HYST(nr), data->temp_hyst[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-#define sysfs_temp(offset)                                              \
-static SENSOR_DEVICE_ATTR(temp##offset##_input, S_IRUGO,                \
-                show_temp, NULL, offset - 1);                           \
-static SENSOR_DEVICE_ATTR(temp##offset##_max, S_IRUGO | S_IWUSR,        \
-                show_temp_max, set_temp_max, offset - 1);               \
-static SENSOR_DEVICE_ATTR(temp##offset##_max_hyst, S_IRUGO | S_IWUSR,   \
-                show_temp_hyst, set_temp_hyst, offset - 1);             \
-static SENSOR_DEVICE_ATTR(temp##offset##_type, S_IRUGO,                 \
-                show_temp_type, NULL, offset - 1)
-
-sysfs_temp(1);
-sysfs_temp(2);
-sysfs_temp(3);
-
 static ssize_t show_alarms_in(struct device *dev, struct device_attribute
                               *devattr, char *buf)
 {
@@ -625,10 +581,6 @@ static ssize_t show_alarms_temp(struct device *dev, struct device_attribute
         return sprintf(buf, "%d\n", (data->alarms[1] >> 3) & 0x07);
 }
 
-static DEVICE_ATTR(alarms_in, S_IRUGO, show_alarms_in, NULL);
-static DEVICE_ATTR(alarms_fan, S_IRUGO, show_alarms_fan, NULL);
-static DEVICE_ATTR(alarms_temp, S_IRUGO, show_alarms_temp, NULL);
-
 static ssize_t show_name(struct device *dev, struct device_attribute
                          *devattr, char *buf)
 {
@@ -637,7 +589,89 @@ static ssize_t show_name(struct device *dev, struct device_attribute
         return sprintf(buf, "%s\n", data->name);
 }
 
-static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
+static struct device_attribute f71805f_dev_attr[] = {
+        __ATTR(in0_input, S_IRUGO, show_in0, NULL),
+        __ATTR(in0_max, S_IRUGO| S_IWUSR, show_in0_max, set_in0_max),
+        __ATTR(in0_min, S_IRUGO| S_IWUSR, show_in0_min, set_in0_min),
+        __ATTR(alarms_in, S_IRUGO, show_alarms_in, NULL),
+        __ATTR(alarms_fan, S_IRUGO, show_alarms_fan, NULL),
+        __ATTR(alarms_temp, S_IRUGO, show_alarms_temp, NULL),
+        __ATTR(name, S_IRUGO, show_name, NULL),
+};
+
+static struct sensor_device_attribute f71805f_sensor_attr[] = {
+        SENSOR_ATTR(in1_input, S_IRUGO, show_in, NULL, 1),
+        SENSOR_ATTR(in1_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 1),
+        SENSOR_ATTR(in1_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 1),
+        SENSOR_ATTR(in2_input, S_IRUGO, show_in, NULL, 2),
+        SENSOR_ATTR(in2_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 2),
+        SENSOR_ATTR(in2_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 2),
+        SENSOR_ATTR(in3_input, S_IRUGO, show_in, NULL, 3),
+        SENSOR_ATTR(in3_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 3),
+        SENSOR_ATTR(in3_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 3),
+        SENSOR_ATTR(in4_input, S_IRUGO, show_in, NULL, 4),
+        SENSOR_ATTR(in4_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 4),
+        SENSOR_ATTR(in4_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 4),
+        SENSOR_ATTR(in5_input, S_IRUGO, show_in, NULL, 5),
+        SENSOR_ATTR(in5_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 5),
+        SENSOR_ATTR(in5_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 5),
+        SENSOR_ATTR(in6_input, S_IRUGO, show_in, NULL, 6),
+        SENSOR_ATTR(in6_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 6),
+        SENSOR_ATTR(in6_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 6),
+        SENSOR_ATTR(in7_input, S_IRUGO, show_in, NULL, 7),
+        SENSOR_ATTR(in7_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 7),
+        SENSOR_ATTR(in7_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 7),
+        SENSOR_ATTR(in8_input, S_IRUGO, show_in, NULL, 8),
+        SENSOR_ATTR(in8_max, S_IRUGO | S_IWUSR,
+                    show_in_max, set_in_max, 8),
+        SENSOR_ATTR(in8_min, S_IRUGO | S_IWUSR,
+                    show_in_min, set_in_min, 8),
+
+        SENSOR_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0),
+        SENSOR_ATTR(temp1_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 0),
+        SENSOR_ATTR(temp1_max_hyst, S_IRUGO | S_IWUSR,
+                    show_temp_hyst, set_temp_hyst, 0),
+        SENSOR_ATTR(temp1_type, S_IRUGO, show_temp_type, NULL, 0),
+        SENSOR_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 1),
+        SENSOR_ATTR(temp2_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 1),
+        SENSOR_ATTR(temp2_max_hyst, S_IRUGO | S_IWUSR,
+                    show_temp_hyst, set_temp_hyst, 1),
+        SENSOR_ATTR(temp2_type, S_IRUGO, show_temp_type, NULL, 1),
+        SENSOR_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 2),
+        SENSOR_ATTR(temp3_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 2),
+        SENSOR_ATTR(temp3_max_hyst, S_IRUGO | S_IWUSR,
+                    show_temp_hyst, set_temp_hyst, 2),
+        SENSOR_ATTR(temp3_type, S_IRUGO, show_temp_type, NULL, 2),
+};
+
+static struct sensor_device_attribute f71805f_fan_attr[] = {
+        SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0),
+        SENSOR_ATTR(fan1_min, S_IRUGO | S_IWUSR,
+                    show_fan_min, set_fan_min, 0),
+        SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 1),
+        SENSOR_ATTR(fan2_min, S_IRUGO | S_IWUSR,
+                    show_fan_min, set_fan_min, 1),
+        SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 2),
+        SENSOR_ATTR(fan3_min, S_IRUGO | S_IWUSR,
+                    show_fan_min, set_fan_min, 2),
+};
 
 /*
  * Device registration and initialization
@@ -668,7 +702,7 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
 {
         struct f71805f_data *data;
         struct resource *res;
-        int err;
+        int i, err;
 
         if (!(data = kzalloc(sizeof(struct f71805f_data), GFP_KERNEL))) {
                 err = -ENOMEM;
@@ -678,9 +712,9 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
 
         res = platform_get_resource(pdev, IORESOURCE_IO, 0);
         data->addr = res->start;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         data->name = "f71805f";
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         platform_set_drvdata(pdev, data);
 
@@ -695,76 +729,31 @@ static int __devinit f71805f_probe(struct platform_device *pdev)
         f71805f_init_device(data);
 
         /* Register sysfs interface files */
-        device_create_file(&pdev->dev, &dev_attr_in0_input);
-        device_create_file(&pdev->dev, &dev_attr_in0_max);
-        device_create_file(&pdev->dev, &dev_attr_in0_min);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in1_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in2_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in3_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in4_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in5_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in6_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in7_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in8_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in1_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in2_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in3_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in4_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in5_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in6_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in7_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in8_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in1_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in2_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in3_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in4_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in5_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in6_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in7_min.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_in8_min.dev_attr);
-        if (data->fan_enabled & (1 << 0)) {
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan1_input.dev_attr);
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan1_min.dev_attr);
+        for (i = 0; i < ARRAY_SIZE(f71805f_dev_attr); i++) {
+                err = device_create_file(&pdev->dev, &f71805f_dev_attr[i]);
+                if (err)
+                        goto exit_class;
         }
-        if (data->fan_enabled & (1 << 1)) {
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan2_input.dev_attr);
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan2_min.dev_attr);
+        for (i = 0; i < ARRAY_SIZE(f71805f_sensor_attr); i++) {
+                err = device_create_file(&pdev->dev,
+                                         &f71805f_sensor_attr[i].dev_attr);
+                if (err)
+                        goto exit_class;
         }
-        if (data->fan_enabled & (1 << 2)) {
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan3_input.dev_attr);
-                device_create_file(&pdev->dev,
-                                   &sensor_dev_attr_fan3_min.dev_attr);
+        for (i = 0; i < ARRAY_SIZE(f71805f_fan_attr); i++) {
+                if (!(data->fan_enabled & (1 << (i / 2))))
+                        continue;
+                err = device_create_file(&pdev->dev,
+                                         &f71805f_fan_attr[i].dev_attr);
+                if (err)
+                        goto exit_class;
         }
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp1_input.dev_attr);
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp2_input.dev_attr);
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp3_input.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp1_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp2_max.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp3_max.dev_attr);
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp1_max_hyst.dev_attr);
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp2_max_hyst.dev_attr);
-        device_create_file(&pdev->dev,
-                           &sensor_dev_attr_temp3_max_hyst.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp1_type.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp2_type.dev_attr);
-        device_create_file(&pdev->dev, &sensor_dev_attr_temp3_type.dev_attr);
-        device_create_file(&pdev->dev, &dev_attr_alarms_in);
-        device_create_file(&pdev->dev, &dev_attr_alarms_fan);
-        device_create_file(&pdev->dev, &dev_attr_alarms_temp);
-        device_create_file(&pdev->dev, &dev_attr_name);
 
         return 0;
 
+exit_class:
+        dev_err(&pdev->dev, "Sysfs interface creation failed\n");
+        hwmon_device_unregister(data->class_dev);
 exit_free:
         kfree(data);
 exit:
diff --git a/drivers/hwmon/fscher.c b/drivers/hwmon/fscher.c
index 25409181d1eb..6bc76b407636 100644
--- a/drivers/hwmon/fscher.c
+++ b/drivers/hwmon/fscher.c
@@ -33,6 +33,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -133,7 +134,7 @@ static struct i2c_driver fscher_driver = {
 struct fscher_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -332,7 +333,7 @@ static int fscher_detect(struct i2c_adapter *adapter, int address, int kind)
          * global list */
         strlcpy(new_client->name, "fscher", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -417,7 +418,7 @@ static struct fscher_data *fscher_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct fscher_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {
 
@@ -457,7 +458,7 @@ static struct fscher_data *fscher_update_device(struct device *dev)
                 data->valid = 1;                 
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
@@ -472,10 +473,10 @@ static ssize_t set_fan_status(struct i2c_client *client, struct fscher_data *dat
         /* bits 0..1, 3..7 reserved => mask with 0x04 */  
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0x04;
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_status[FAN_INDEX_FROM_NUM(nr)] &= ~v;
         fscher_write_value(client, reg, v);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -490,10 +491,10 @@ static ssize_t set_pwm(struct i2c_client *client, struct fscher_data *data,
 {
         unsigned long v = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[FAN_INDEX_FROM_NUM(nr)] = v > 0xff ? 0xff : v;
         fscher_write_value(client, reg, data->fan_min[FAN_INDEX_FROM_NUM(nr)]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -518,14 +519,14 @@ static ssize_t set_fan_div(struct i2c_client *client, struct fscher_data *data,
                 return -EINVAL;
         }
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         /* bits 2..7 reserved => mask with 0x03 */
         data->fan_ripple[FAN_INDEX_FROM_NUM(nr)] &= ~0x03;
         data->fan_ripple[FAN_INDEX_FROM_NUM(nr)] |= v;
 
         fscher_write_value(client, reg, data->fan_ripple[FAN_INDEX_FROM_NUM(nr)]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -552,10 +553,10 @@ static ssize_t set_temp_status(struct i2c_client *client, struct fscher_data *da
         /* bits 2..7 reserved, 0 read only => mask with 0x02 */  
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0x02;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_status[TEMP_INDEX_FROM_NUM(nr)] &= ~v;
         fscher_write_value(client, reg, v);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -609,10 +610,10 @@ static ssize_t set_control(struct i2c_client *client, struct fscher_data *data,
         /* bits 1..7 reserved => mask with 0x01 */  
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0x01;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->global_control &= ~v;
         fscher_write_value(client, reg, v);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -631,11 +632,11 @@ static ssize_t set_watchdog_control(struct i2c_client *client, struct
         /* bits 0..3 reserved => mask with 0xf0 */  
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0xf0;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->watchdog[2] &= ~0xf0;
         data->watchdog[2] |= v;
         fscher_write_value(client, reg, data->watchdog[2]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -651,10 +652,10 @@ static ssize_t set_watchdog_status(struct i2c_client *client, struct fscher_data
         /* bits 0, 2..7 reserved => mask with 0x02 */  
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0x02;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->watchdog[1] &= ~v;
         fscher_write_value(client, reg, v);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -669,10 +670,10 @@ static ssize_t set_watchdog_preset(struct i2c_client *client, struct fscher_data
 {
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0xff;
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->watchdog[0] = v;
         fscher_write_value(client, reg, data->watchdog[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
diff --git a/drivers/hwmon/fscpos.c b/drivers/hwmon/fscpos.c
index 6d0146b57020..6dc4846b9eeb 100644
--- a/drivers/hwmon/fscpos.c
+++ b/drivers/hwmon/fscpos.c
@@ -37,6 +37,7 @@
 #include <linux/init.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -89,8 +90,8 @@ static int fscpos_attach_adapter(struct i2c_adapter *adapter);
 static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind);
 static int fscpos_detach_client(struct i2c_client *client);
 
-static int fscpos_read_value(struct i2c_client *client, u8 register);
-static int fscpos_write_value(struct i2c_client *client, u8 register, u8 value);
+static int fscpos_read_value(struct i2c_client *client, u8 reg);
+static int fscpos_write_value(struct i2c_client *client, u8 reg, u8 value);
 static struct fscpos_data *fscpos_update_device(struct device *dev);
 static void fscpos_init_client(struct i2c_client *client);
 
@@ -114,7 +115,7 @@ static struct i2c_driver fscpos_driver = {
 struct fscpos_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* 0 until following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -208,13 +209,13 @@ static ssize_t set_fan_ripple(struct i2c_client *client, struct fscpos_data
                 return -EINVAL;
         }
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         /* bits 2..7 reserved => mask with 0x03 */
         data->fan_ripple[nr - 1] &= ~0x03;
         data->fan_ripple[nr - 1] |= v;
         
         fscpos_write_value(client, reg, data->fan_ripple[nr - 1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -232,10 +233,10 @@ static ssize_t set_pwm(struct i2c_client *client, struct fscpos_data *data,
         if (v < 0) v = 0;
         if (v > 255) v = 255;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[nr - 1] = v;
         fscpos_write_value(client, reg, data->pwm[nr - 1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -278,11 +279,11 @@ static ssize_t set_wdog_control(struct i2c_client *client, struct fscpos_data
         /* bits 0..3 reserved => mask with 0xf0 */
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0xf0;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->wdog_control &= ~0xf0;
         data->wdog_control |= v;
         fscpos_write_value(client, reg, data->wdog_control);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -304,10 +305,10 @@ static ssize_t set_wdog_state(struct i2c_client *client, struct fscpos_data
                 return -EINVAL;
         }
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->wdog_state &= ~v;
         fscpos_write_value(client, reg, v);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -321,10 +322,10 @@ static ssize_t set_wdog_preset(struct i2c_client *client, struct fscpos_data
 {
         unsigned long v = simple_strtoul(buf, NULL, 10) & 0xff;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->wdog_preset = v;
         fscpos_write_value(client, reg, data->wdog_preset);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -483,7 +484,7 @@ static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind)
         strlcpy(new_client->name, "fscpos", I2C_NAME_SIZE);
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -579,7 +580,7 @@ static struct fscpos_data *fscpos_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct fscpos_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {
                 int i;
@@ -625,7 +626,7 @@ static struct fscpos_data *fscpos_update_device(struct device *dev)
                 data->last_updated = jiffies;
                 data->valid = 1;
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return data;
 }
 
diff --git a/drivers/hwmon/gl518sm.c b/drivers/hwmon/gl518sm.c
index 9e685e3a3bc9..6606aabdb49d 100644
--- a/drivers/hwmon/gl518sm.c
+++ b/drivers/hwmon/gl518sm.c
@@ -43,6 +43,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, I2C_CLIENT_END };
@@ -120,7 +121,7 @@ struct gl518_data {
         struct class_device *class_dev;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -212,10 +213,10 @@ static ssize_t set_##suffix(struct device *dev, struct device_attribute *attr, c
         struct gl518_data *data = i2c_get_clientdata(client);           \
         long val = simple_strtol(buf, NULL, 10);                        \
                                                                         \
-        down(&data->update_lock);                                       \
+        mutex_lock(&data->update_lock);                                 \
         data->value = type##_TO_REG(val);                               \
         gl518_write_value(client, reg, data->value);                    \
-        up(&data->update_lock);                                         \
+        mutex_unlock(&data->update_lock);                               \
         return count;                                                   \
 }
 
@@ -228,12 +229,12 @@ static ssize_t set_##suffix(struct device *dev, struct device_attribute *attr, c
         int regvalue;                                                   \
         unsigned long val = simple_strtoul(buf, NULL, 10);              \
                                                                         \
-        down(&data->update_lock);                                       \
+        mutex_lock(&data->update_lock);                                 \
         regvalue = gl518_read_value(client, reg);                       \
         data->value = type##_TO_REG(val);                               \
         regvalue = (regvalue & ~mask) | (data->value << shift);         \
         gl518_write_value(client, reg, regvalue);                       \
-        up(&data->update_lock);                                         \
+        mutex_unlock(&data->update_lock);                               \
         return count;                                                   \
 }
 
@@ -265,7 +266,7 @@ static ssize_t set_fan_min1(struct device *dev, struct device_attribute *attr, c
         int regvalue;
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         regvalue = gl518_read_value(client, GL518_REG_FAN_LIMIT);
         data->fan_min[0] = FAN_TO_REG(val,
                 DIV_FROM_REG(data->fan_div[0]));
@@ -280,7 +281,7 @@ static ssize_t set_fan_min1(struct device *dev, struct device_attribute *attr, c
         data->beep_mask &= data->alarm_mask;
         gl518_write_value(client, GL518_REG_ALARM, data->beep_mask);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -291,7 +292,7 @@ static ssize_t set_fan_min2(struct device *dev, struct device_attribute *attr, c
         int regvalue;
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         regvalue = gl518_read_value(client, GL518_REG_FAN_LIMIT);
         data->fan_min[1] = FAN_TO_REG(val,
                 DIV_FROM_REG(data->fan_div[1]));
@@ -306,7 +307,7 @@ static ssize_t set_fan_min2(struct device *dev, struct device_attribute *attr, c
         data->beep_mask &= data->alarm_mask;
         gl518_write_value(client, GL518_REG_ALARM, data->beep_mask);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -407,7 +408,7 @@ static int gl518_detect(struct i2c_adapter *adapter, int address, int kind)
         strlcpy(new_client->name, "gl518sm", I2C_NAME_SIZE);
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -525,7 +526,7 @@ static struct gl518_data *gl518_update_device(struct device *dev)
         struct gl518_data *data = i2c_get_clientdata(client);
         int val;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -586,7 +587,7 @@ static struct gl518_data *gl518_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/gl520sm.c b/drivers/hwmon/gl520sm.c
index baee60e44b52..47b4d49f75c6 100644
--- a/drivers/hwmon/gl520sm.c
+++ b/drivers/hwmon/gl520sm.c
@@ -29,6 +29,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Type of the extra sensor */
 static unsigned short extra_sensor_type;
@@ -121,7 +122,7 @@ static struct i2c_driver gl520_driver = {
 struct gl520_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* zero until the following fields are valid */
         unsigned long last_updated;     /* in jiffies */
 
@@ -303,7 +304,7 @@ static ssize_t set_in_min(struct i2c_client *client, struct gl520_data *data, co
         long v = simple_strtol(buf, NULL, 10);
         u8 r;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (n == 0)
                 r = VDD_TO_REG(v);
@@ -317,7 +318,7 @@ static ssize_t set_in_min(struct i2c_client *client, struct gl520_data *data, co
         else
                 gl520_write_value(client, reg, r);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -331,7 +332,7 @@ static ssize_t set_in_max(struct i2c_client *client, struct gl520_data *data, co
         else
                 r = IN_TO_REG(v);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         data->in_max[n] = r;
 
@@ -340,7 +341,7 @@ static ssize_t set_in_max(struct i2c_client *client, struct gl520_data *data, co
         else
                 gl520_write_value(client, reg, r);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -373,7 +374,7 @@ static ssize_t set_fan_min(struct i2c_client *client, struct gl520_data *data, c
         unsigned long v = simple_strtoul(buf, NULL, 10);
         u8 r;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         r = FAN_TO_REG(v, data->fan_div[n - 1]);
         data->fan_min[n - 1] = r;
 
@@ -390,7 +391,7 @@ static ssize_t set_fan_min(struct i2c_client *client, struct gl520_data *data, c
         data->beep_mask &= data->alarm_mask;
         gl520_write_value(client, GL520_REG_BEEP_MASK, data->beep_mask);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -409,7 +410,7 @@ static ssize_t set_fan_div(struct i2c_client *client, struct gl520_data *data, c
                 return -EINVAL;
         }
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_div[n - 1] = r;
 
         if (n == 1)
@@ -417,7 +418,7 @@ static ssize_t set_fan_div(struct i2c_client *client, struct gl520_data *data, c
         else
                 gl520_write_value(client, reg, (gl520_read_value(client, reg) & ~0x30) | (r << 4));
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -425,10 +426,10 @@ static ssize_t set_fan_off(struct i2c_client *client, struct gl520_data *data, c
 {
         u8 r = simple_strtoul(buf, NULL, 10)?1:0;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_off = r;
         gl520_write_value(client, reg, (gl520_read_value(client, reg) & ~0x0c) | (r << 2));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -454,10 +455,10 @@ static ssize_t set_temp_max(struct i2c_client *client, struct gl520_data *data,
 {
         long v = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[n - 1] = TEMP_TO_REG(v);;
         gl520_write_value(client, reg, data->temp_max[n - 1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -465,10 +466,10 @@ static ssize_t set_temp_max_hyst(struct i2c_client *client, struct gl520_data *d
 {
         long v = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max_hyst[n - 1] = TEMP_TO_REG(v);
         gl520_write_value(client, reg, data->temp_max_hyst[n - 1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -491,10 +492,10 @@ static ssize_t set_beep_enable(struct i2c_client *client, struct gl520_data *dat
 {
         u8 r = simple_strtoul(buf, NULL, 10)?0:1;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->beep_enable = !r;
         gl520_write_value(client, reg, (gl520_read_value(client, reg) & ~0x04) | (r << 2));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -502,11 +503,11 @@ static ssize_t set_beep_mask(struct i2c_client *client, struct gl520_data *data,
 {
         u8 r = simple_strtoul(buf, NULL, 10);
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         r &= data->alarm_mask;
         data->beep_mask = r;
         gl520_write_value(client, reg, r);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -561,7 +562,7 @@ static int gl520_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields */
         strlcpy(new_client->name, "gl520sm", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -685,7 +686,7 @@ static struct gl520_data *gl520_update_device(struct device *dev)
         struct gl520_data *data = i2c_get_clientdata(client);
         int val;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {
 
@@ -750,7 +751,7 @@ static struct gl520_data *gl520_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
index 23a9e1ea8e32..7636c1a58f9c 100644
--- a/drivers/hwmon/hdaps.c
+++ b/drivers/hwmon/hdaps.c
@@ -33,6 +33,7 @@
 #include <linux/module.h>
 #include <linux/timer.h>
 #include <linux/dmi.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 #define HDAPS_LOW_PORT          0x1600  /* first port used by hdaps */
@@ -70,10 +71,10 @@ static u8 km_activity;
 static int rest_x;
 static int rest_y;
 
-static DECLARE_MUTEX(hdaps_sem);
+static DEFINE_MUTEX(hdaps_mutex);
 
 /*
- * __get_latch - Get the value from a given port.  Callers must hold hdaps_sem.
+ * __get_latch - Get the value from a given port.  Callers must hold hdaps_mutex.
  */
 static inline u8 __get_latch(u16 port)
 {
@@ -82,7 +83,7 @@ static inline u8 __get_latch(u16 port)
 
 /*
  * __check_latch - Check a port latch for a given value.  Returns zero if the
- * port contains the given value.  Callers must hold hdaps_sem.
+ * port contains the given value.  Callers must hold hdaps_mutex.
  */
 static inline int __check_latch(u16 port, u8 val)
 {
@@ -93,7 +94,7 @@ static inline int __check_latch(u16 port, u8 val)
 
 /*
  * __wait_latch - Wait up to 100us for a port latch to get a certain value,
- * returning zero if the value is obtained.  Callers must hold hdaps_sem.
+ * returning zero if the value is obtained.  Callers must hold hdaps_mutex.
  */
 static int __wait_latch(u16 port, u8 val)
 {
@@ -110,7 +111,7 @@ static int __wait_latch(u16 port, u8 val)
 
 /*
  * __device_refresh - request a refresh from the accelerometer.  Does not wait
- * for refresh to complete.  Callers must hold hdaps_sem.
+ * for refresh to complete.  Callers must hold hdaps_mutex.
  */
 static void __device_refresh(void)
 {
@@ -124,7 +125,7 @@ static void __device_refresh(void)
 /*
  * __device_refresh_sync - request a synchronous refresh from the
  * accelerometer.  We wait for the refresh to complete.  Returns zero if
- * successful and nonzero on error.  Callers must hold hdaps_sem.
+ * successful and nonzero on error.  Callers must hold hdaps_mutex.
  */
 static int __device_refresh_sync(void)
 {
@@ -134,7 +135,7 @@ static int __device_refresh_sync(void)
 
 /*
  * __device_complete - indicate to the accelerometer that we are done reading
- * data, and then initiate an async refresh.  Callers must hold hdaps_sem.
+ * data, and then initiate an async refresh.  Callers must hold hdaps_mutex.
  */
 static inline void __device_complete(void)
 {
@@ -152,7 +153,7 @@ static int hdaps_readb_one(unsigned int port, u8 *val)
 {
         int ret;
 
-        down(&hdaps_sem);
+        mutex_lock(&hdaps_mutex);
 
         /* do a sync refresh -- we need to be sure that we read fresh data */
         ret = __device_refresh_sync();
@@ -163,7 +164,7 @@ static int hdaps_readb_one(unsigned int port, u8 *val)
         __device_complete();
 
 out:
-        up(&hdaps_sem);
+        mutex_unlock(&hdaps_mutex);
         return ret;
 }
 
@@ -198,9 +199,9 @@ static int hdaps_read_pair(unsigned int port1, unsigned int port2,
 {
         int ret;
 
-        down(&hdaps_sem);
+        mutex_lock(&hdaps_mutex);
         ret = __hdaps_read_pair(port1, port2, val1, val2);
-        up(&hdaps_sem);
+        mutex_unlock(&hdaps_mutex);
 
         return ret;
 }
@@ -213,7 +214,7 @@ static int hdaps_device_init(void)
 {
         int total, ret = -ENXIO;
 
-        down(&hdaps_sem);
+        mutex_lock(&hdaps_mutex);
 
         outb(0x13, 0x1610);
         outb(0x01, 0x161f);
@@ -279,7 +280,7 @@ static int hdaps_device_init(void)
         }
 
 out:
-        up(&hdaps_sem);
+        mutex_unlock(&hdaps_mutex);
         return ret;
 }
 
@@ -313,7 +314,7 @@ static struct platform_driver hdaps_driver = {
 };
 
 /*
- * hdaps_calibrate - Set our "resting" values.  Callers must hold hdaps_sem.
+ * hdaps_calibrate - Set our "resting" values.  Callers must hold hdaps_mutex.
  */
 static void hdaps_calibrate(void)
 {
@@ -325,7 +326,7 @@ static void hdaps_mousedev_poll(unsigned long unused)
         int x, y;
 
         /* Cannot sleep.  Try nonblockingly.  If we fail, try again later. */
-        if (down_trylock(&hdaps_sem)) {
+        if (!mutex_trylock(&hdaps_mutex)) {
                 mod_timer(&hdaps_timer,jiffies + HDAPS_POLL_PERIOD);
                 return;
         }
@@ -340,7 +341,7 @@ static void hdaps_mousedev_poll(unsigned long unused)
         mod_timer(&hdaps_timer, jiffies + HDAPS_POLL_PERIOD);
 
 out:
-        up(&hdaps_sem);
+        mutex_unlock(&hdaps_mutex);
 }
 
 
@@ -420,9 +421,9 @@ static ssize_t hdaps_calibrate_store(struct device *dev,
                                      struct device_attribute *attr,
                                      const char *buf, size_t count)
 {
-        down(&hdaps_sem);
+        mutex_lock(&hdaps_mutex);
         hdaps_calibrate();
-        up(&hdaps_sem);
+        mutex_unlock(&hdaps_mutex);
 
         return count;
 }
diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
index e497274916ce..a74a44f16f51 100644
--- a/drivers/hwmon/hwmon-vid.c
+++ b/drivers/hwmon/hwmon-vid.c
@@ -54,6 +54,10 @@
     (IMVP-II). You can find more information in the datasheet of Max1718
     http://www.maxim-ic.com/quick_view2.cfm/qv_pk/2452
 
+    The 13 specification corresponds to the Intel Pentium M series. There
+    doesn't seem to be any named specification for these. The conversion
+    tables are detailed directly in the various Pentium M datasheets:
+    http://www.intel.com/design/intarch/pentiumm/docs_pentiumm.htm
 */
 
 /* vrm is the VRM/VRD document version multiplied by 10.
@@ -100,6 +104,8 @@ int vid_from_reg(int val, u8 vrm)
         case 17:                /* Intel IMVP-II */
                 return(val & 0x10 ? 975 - (val & 0xF) * 25 :
                                     1750 - val * 50);
+        case 13:
+                return(1708 - (val & 0x3f) * 16);
         default:                /* report 0 for unknown */
                 printk(KERN_INFO "hwmon-vid: requested unknown VRM version\n");
                 return 0;
@@ -129,8 +135,9 @@ struct vrm_model {
 static struct vrm_model vrm_models[] = {
         {X86_VENDOR_AMD, 0x6, ANY, ANY, 90},            /* Athlon Duron etc */
         {X86_VENDOR_AMD, 0xF, ANY, ANY, 24},            /* Athlon 64, Opteron and above VRM 24 */
-        {X86_VENDOR_INTEL, 0x6, 0x9, ANY, 85},          /* 0.13um too */
+        {X86_VENDOR_INTEL, 0x6, 0x9, ANY, 13},          /* Pentium M (130 nm) */
         {X86_VENDOR_INTEL, 0x6, 0xB, ANY, 85},          /* Tualatin */
+        {X86_VENDOR_INTEL, 0x6, 0xD, ANY, 13},          /* Pentium M (90 nm) */
         {X86_VENDOR_INTEL, 0x6, ANY, ANY, 82},          /* any P6 */
         {X86_VENDOR_INTEL, 0x7, ANY, ANY, 0},           /* Itanium */
         {X86_VENDOR_INTEL, 0xF, 0x0, ANY, 90},          /* P4 */
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index dddd3eb9b387..106fa01cdb60 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -17,6 +17,7 @@
 #include <linux/idr.h>
 #include <linux/hwmon.h>
 #include <linux/gfp.h>
+#include <linux/spinlock.h>
 
 #define HWMON_ID_PREFIX "hwmon"
 #define HWMON_ID_FORMAT HWMON_ID_PREFIX "%d"
@@ -24,6 +25,7 @@
 static struct class *hwmon_class;
 
 static DEFINE_IDR(hwmon_idr);
+static DEFINE_SPINLOCK(idr_lock);
 
 /**
  * hwmon_device_register - register w/ hwmon sysfs class
@@ -37,20 +39,30 @@ static DEFINE_IDR(hwmon_idr);
 struct class_device *hwmon_device_register(struct device *dev)
 {
         struct class_device *cdev;
-        int id;
+        int id, err;
 
-        if (idr_pre_get(&hwmon_idr, GFP_KERNEL) == 0)
+again:
+        if (unlikely(idr_pre_get(&hwmon_idr, GFP_KERNEL) == 0))
                 return ERR_PTR(-ENOMEM);
 
-        if (idr_get_new(&hwmon_idr, NULL, &id) < 0)
-                return ERR_PTR(-ENOMEM);
+        spin_lock(&idr_lock);
+        err = idr_get_new(&hwmon_idr, NULL, &id);
+        spin_unlock(&idr_lock);
+
+        if (unlikely(err == -EAGAIN))
+                goto again;
+        else if (unlikely(err))
+                return ERR_PTR(err);
 
         id = id & MAX_ID_MASK;
         cdev = class_device_create(hwmon_class, NULL, MKDEV(0,0), dev,
                                         HWMON_ID_FORMAT, id);
 
-        if (IS_ERR(cdev))
+        if (IS_ERR(cdev)) {
+                spin_lock(&idr_lock);
                 idr_remove(&hwmon_idr, id);
+                spin_unlock(&idr_lock);
+        }
 
         return cdev;
 }
@@ -64,9 +76,11 @@ void hwmon_device_unregister(struct class_device *cdev)
 {
         int id;
 
-        if (sscanf(cdev->class_id, HWMON_ID_FORMAT, &id) == 1) {
+        if (likely(sscanf(cdev->class_id, HWMON_ID_FORMAT, &id) == 1)) {
                 class_device_unregister(cdev);
+                spin_lock(&idr_lock);
                 idr_remove(&hwmon_idr, id);
+                spin_unlock(&idr_lock);
         } else
                 dev_dbg(cdev->dev,
                         "hwmon_device_unregister() failed: bad class ID!\n");
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index d7a9401600bb..06df92b3ee49 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -41,6 +41,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 
@@ -194,10 +195,10 @@ static int DIV_TO_REG(int val)
 struct it87_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -224,9 +225,8 @@ static int it87_isa_attach_adapter(struct i2c_adapter *adapter);
 static int it87_detect(struct i2c_adapter *adapter, int address, int kind);
 static int it87_detach_client(struct i2c_client *client);
 
-static int it87_read_value(struct i2c_client *client, u8 register);
-static int it87_write_value(struct i2c_client *client, u8 register,
-                        u8 value);
+static int it87_read_value(struct i2c_client *client, u8 reg);
+static int it87_write_value(struct i2c_client *client, u8 reg, u8 value);
 static struct it87_data *it87_update_device(struct device *dev);
 static int it87_check_pwm(struct i2c_client *client);
 static void it87_init_client(struct i2c_client *client, struct it87_data *data);
@@ -290,11 +290,11 @@ static ssize_t set_in_min(struct device *dev, struct device_attribute *attr,
         struct it87_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = IN_TO_REG(val);
         it87_write_value(client, IT87_REG_VIN_MIN(nr), 
                         data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_in_max(struct device *dev, struct device_attribute *attr,
@@ -307,11 +307,11 @@ static ssize_t set_in_max(struct device *dev, struct device_attribute *attr,
         struct it87_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = IN_TO_REG(val);
         it87_write_value(client, IT87_REG_VIN_MAX(nr), 
                         data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -381,10 +381,10 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *attr,
         struct it87_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_high[nr] = TEMP_TO_REG(val);
         it87_write_value(client, IT87_REG_TEMP_HIGH(nr), data->temp_high[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp_min(struct device *dev, struct device_attribute *attr,
@@ -397,10 +397,10 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *attr,
         struct it87_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_low[nr] = TEMP_TO_REG(val);
         it87_write_value(client, IT87_REG_TEMP_LOW(nr), data->temp_low[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_temp_offset(offset)                                        \
@@ -440,7 +440,7 @@ static ssize_t set_sensor(struct device *dev, struct device_attribute *attr,
         struct it87_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         data->sensor &= ~(1 << nr);
         data->sensor &= ~(8 << nr);
@@ -450,11 +450,11 @@ static ssize_t set_sensor(struct device *dev, struct device_attribute *attr,
         else if (val == 2)
             data->sensor |= 8 << nr;
         else if (val != 0) {
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
         it87_write_value(client, IT87_REG_TEMP_ENABLE, data->sensor);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_sensor_offset(offset)                                      \
@@ -524,7 +524,7 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *attr,
         int val = simple_strtol(buf, NULL, 10);
         u8 reg = it87_read_value(client, IT87_REG_FAN_DIV);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         switch (nr) {
         case 0: data->fan_div[nr] = reg & 0x07; break;
         case 1: data->fan_div[nr] = (reg >> 3) & 0x07; break;
@@ -533,7 +533,7 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *attr,
 
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         it87_write_value(client, IT87_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
@@ -548,7 +548,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
         int i, min[3];
         u8 old;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         old = it87_read_value(client, IT87_REG_FAN_DIV);
 
         for (i = 0; i < 3; i++)
@@ -576,7 +576,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
                 data->fan_min[i]=FAN_TO_REG(min[i], DIV_FROM_REG(data->fan_div[i]));
                 it87_write_value(client, IT87_REG_FAN_MIN(i), data->fan_min[i]);
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_pwm_enable(struct device *dev,
@@ -589,7 +589,7 @@ static ssize_t set_pwm_enable(struct device *dev,
         struct it87_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (val == 0) {
                 int tmp;
@@ -606,11 +606,11 @@ static ssize_t set_pwm_enable(struct device *dev,
                 /* set saved pwm value, clear FAN_CTLX PWM mode bit */
                 it87_write_value(client, IT87_REG_PWM(nr), PWM_TO_REG(data->manual_pwm_ctl[nr]));
         } else {
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
@@ -626,11 +626,11 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
         if (val < 0 || val > 255)
                 return -EINVAL;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->manual_pwm_ctl[nr] = val;
         if (data->fan_main_ctrl & (1 << nr))
                 it87_write_value(client, IT87_REG_PWM(nr), PWM_TO_REG(data->manual_pwm_ctl[nr]));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -776,7 +776,7 @@ static int it87_detect(struct i2c_adapter *adapter, int address, int kind)
 
         new_client = &data->client;
         if (is_isa)
-                init_MUTEX(&data->lock);
+                mutex_init(&data->lock);
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
         new_client->adapter = adapter;
@@ -823,7 +823,7 @@ static int it87_detect(struct i2c_adapter *adapter, int address, int kind)
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -950,10 +950,10 @@ static int it87_read_value(struct i2c_client *client, u8 reg)
 
         int res;
         if (i2c_is_isa_client(client)) {
-                down(&data->lock);
+                mutex_lock(&data->lock);
                 outb_p(reg, client->addr + IT87_ADDR_REG_OFFSET);
                 res = inb_p(client->addr + IT87_DATA_REG_OFFSET);
-                up(&data->lock);
+                mutex_unlock(&data->lock);
                 return res;
         } else
                 return i2c_smbus_read_byte_data(client, reg);
@@ -969,10 +969,10 @@ static int it87_write_value(struct i2c_client *client, u8 reg, u8 value)
         struct it87_data *data = i2c_get_clientdata(client);
 
         if (i2c_is_isa_client(client)) {
-                down(&data->lock);
+                mutex_lock(&data->lock);
                 outb_p(reg, client->addr + IT87_ADDR_REG_OFFSET);
                 outb_p(value, client->addr + IT87_DATA_REG_OFFSET);
-                up(&data->lock);
+                mutex_unlock(&data->lock);
                 return 0;
         } else
                 return i2c_smbus_write_byte_data(client, reg, value);
@@ -1098,7 +1098,7 @@ static struct it87_data *it87_update_device(struct device *dev)
         struct it87_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -1160,7 +1160,7 @@ static struct it87_data *it87_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 6b1aa7ef552e..071f0fc6adec 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -45,6 +45,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -153,7 +154,7 @@ static struct i2c_driver lm63_driver = {
 struct lm63_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -192,13 +193,13 @@ static ssize_t set_fan(struct device *dev, struct device_attribute *dummy,
         struct lm63_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan[1] = FAN_TO_REG(val);
         i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_LSB,
                                   data->fan[1] & 0xFF);
         i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_MSB,
                                   data->fan[1] >> 8);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -222,12 +223,12 @@ static ssize_t set_pwm1(struct device *dev, struct device_attribute *dummy,
                 return -EPERM;
 
         val = simple_strtoul(buf, NULL, 10);
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm1_value = val <= 0 ? 0 :
                            val >= 255 ? 2 * data->pwm1_freq :
                            (val * data->pwm1_freq * 2 + 127) / 255;
         i2c_smbus_write_byte_data(client, LM63_REG_PWM_VALUE, data->pwm1_value);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -253,10 +254,10 @@ static ssize_t set_temp8(struct device *dev, struct device_attribute *dummy,
         struct lm63_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp8[1] = TEMP8_TO_REG(val);
         i2c_smbus_write_byte_data(client, LM63_REG_LOCAL_HIGH, data->temp8[1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -284,13 +285,13 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,
         long val = simple_strtol(buf, NULL, 10);
         int nr = attr->index;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp11[nr] = TEMP11_TO_REG(val);
         i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2],
                                   data->temp11[nr] >> 8);
         i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2 + 1],
                                   data->temp11[nr] & 0xff);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -314,11 +315,11 @@ static ssize_t set_temp2_crit_hyst(struct device *dev, struct device_attribute *
         long val = simple_strtol(buf, NULL, 10);
         long hyst;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         hyst = TEMP8_FROM_REG(data->temp8[2]) - val;
         i2c_smbus_write_byte_data(client, LM63_REG_REMOTE_TCRIT_HYST,
                                   HYST_TO_REG(hyst));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -427,7 +428,7 @@ static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
 
         strlcpy(new_client->name, "lm63", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -530,7 +531,7 @@ static struct lm63_data *lm63_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm63_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
                 if (data->config & 0x04) { /* tachometer enabled  */
@@ -582,7 +583,7 @@ static struct lm63_data *lm63_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index 74ca2c8c61c3..fc25b90ec24a 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -25,6 +25,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include "lm75.h"
 
 
@@ -47,7 +48,7 @@ I2C_CLIENT_INSMOD_1(lm75);
 struct lm75_data {
         struct i2c_client       client;
         struct class_device *class_dev;
-        struct semaphore        update_lock;
+        struct mutex            update_lock;
         char                    valid;          /* !=0 if following fields are valid */
         unsigned long           last_updated;   /* In jiffies */
         u16                     temp_input;     /* Register values */
@@ -91,10 +92,10 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
         struct lm75_data *data = i2c_get_clientdata(client);    \
         int temp = simple_strtoul(buf, NULL, 10);               \
                                                                 \
-        down(&data->update_lock);                               \
+        mutex_lock(&data->update_lock);                         \
         data->value = LM75_TEMP_TO_REG(temp);                   \
         lm75_write_value(client, reg, data->value);             \
-        up(&data->update_lock);                                 \
+        mutex_unlock(&data->update_lock);                                       \
         return count;                                           \
 }
 set(temp_max, LM75_REG_TEMP_OS);
@@ -188,7 +189,7 @@ static int lm75_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields and put it into the global list */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -264,7 +265,7 @@ static struct lm75_data *lm75_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm75_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -277,7 +278,7 @@ static struct lm75_data *lm75_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm77.c b/drivers/hwmon/lm77.c
index df9e02aaa70a..459cc977380a 100644
--- a/drivers/hwmon/lm77.c
+++ b/drivers/hwmon/lm77.c
@@ -32,6 +32,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, I2C_CLIENT_END };
@@ -51,7 +52,7 @@ I2C_CLIENT_INSMOD_1(lm77);
 struct lm77_data {
         struct i2c_client       client;
         struct class_device *class_dev;
-        struct semaphore        update_lock;
+        struct mutex            update_lock;
         char                    valid;
         unsigned long           last_updated;   /* In jiffies */
         int                     temp_input;     /* Temperatures */
@@ -139,10 +140,10 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
         struct lm77_data *data = i2c_get_clientdata(client);                    \
         long val = simple_strtoul(buf, NULL, 10);                               \
                                                                                 \
-        down(&data->update_lock);                                               \
+        mutex_lock(&data->update_lock);                                         \
         data->value = val;                              \
         lm77_write_value(client, reg, LM77_TEMP_TO_REG(data->value));           \
-        up(&data->update_lock);                                                 \
+        mutex_unlock(&data->update_lock);                                       \
         return count;                                                           \
 }
 
@@ -157,11 +158,11 @@ static ssize_t set_temp_crit_hyst(struct device *dev, struct device_attribute *a
         struct lm77_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_hyst = data->temp_crit - val;
         lm77_write_value(client, LM77_REG_TEMP_HYST,
                          LM77_TEMP_TO_REG(data->temp_hyst));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -173,7 +174,7 @@ static ssize_t set_temp_crit(struct device *dev, struct device_attribute *attr,
         long val = simple_strtoul(buf, NULL, 10);
         int oldcrithyst;
         
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         oldcrithyst = data->temp_crit - data->temp_hyst;
         data->temp_crit = val;
         data->temp_hyst = data->temp_crit - oldcrithyst;
@@ -181,7 +182,7 @@ static ssize_t set_temp_crit(struct device *dev, struct device_attribute *attr,
                          LM77_TEMP_TO_REG(data->temp_crit));
         lm77_write_value(client, LM77_REG_TEMP_HYST,
                          LM77_TEMP_TO_REG(data->temp_hyst));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -306,7 +307,7 @@ static int lm77_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields and put it into the global list */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -380,7 +381,7 @@ static struct lm77_data *lm77_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm77_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -406,7 +407,7 @@ static struct lm77_data *lm77_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
index e404001e20da..94be3d797e61 100644
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -27,6 +27,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 /* Addresses to scan */
@@ -131,10 +132,10 @@ static inline int TEMP_FROM_REG(s8 val)
 struct lm78_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -157,8 +158,8 @@ static int lm78_isa_attach_adapter(struct i2c_adapter *adapter);
 static int lm78_detect(struct i2c_adapter *adapter, int address, int kind);
 static int lm78_detach_client(struct i2c_client *client);
 
-static int lm78_read_value(struct i2c_client *client, u8 register);
-static int lm78_write_value(struct i2c_client *client, u8 register, u8 value);
+static int lm78_read_value(struct i2c_client *client, u8 reg);
+static int lm78_write_value(struct i2c_client *client, u8 reg, u8 value);
 static struct lm78_data *lm78_update_device(struct device *dev);
 static void lm78_init_client(struct i2c_client *client);
 
@@ -207,10 +208,10 @@ static ssize_t set_in_min(struct device *dev, const char *buf,
         struct lm78_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = IN_TO_REG(val);
         lm78_write_value(client, LM78_REG_IN_MIN(nr), data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -221,10 +222,10 @@ static ssize_t set_in_max(struct device *dev, const char *buf,
         struct lm78_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = IN_TO_REG(val);
         lm78_write_value(client, LM78_REG_IN_MAX(nr), data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
         
@@ -288,10 +289,10 @@ static ssize_t set_temp_over(struct device *dev, struct device_attribute *attr,
         struct lm78_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_over = TEMP_TO_REG(val);
         lm78_write_value(client, LM78_REG_TEMP_OVER, data->temp_over);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -307,10 +308,10 @@ static ssize_t set_temp_hyst(struct device *dev, struct device_attribute *attr,
         struct lm78_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_hyst = TEMP_TO_REG(val);
         lm78_write_value(client, LM78_REG_TEMP_HYST, data->temp_hyst);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -342,10 +343,10 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct lm78_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         lm78_write_value(client, LM78_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -368,7 +369,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         unsigned long min;
         u8 reg;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = FAN_FROM_REG(data->fan_min[nr],
                            DIV_FROM_REG(data->fan_div[nr]));
 
@@ -380,7 +381,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         default:
                 dev_err(&client->dev, "fan_div value %ld not "
                         "supported. Choose one of 1, 2, 4 or 8!\n", val);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
@@ -398,7 +399,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         data->fan_min[nr] =
                 FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         lm78_write_value(client, LM78_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -548,7 +549,7 @@ static int lm78_detect(struct i2c_adapter *adapter, int address, int kind)
 
         new_client = &data->client;
         if (is_isa)
-                init_MUTEX(&data->lock);
+                mutex_init(&data->lock);
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
         new_client->adapter = adapter;
@@ -598,7 +599,7 @@ static int lm78_detect(struct i2c_adapter *adapter, int address, int kind)
         data->type = kind;
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -697,10 +698,10 @@ static int lm78_read_value(struct i2c_client *client, u8 reg)
         int res;
         if (i2c_is_isa_client(client)) {
                 struct lm78_data *data = i2c_get_clientdata(client);
-                down(&data->lock);
+                mutex_lock(&data->lock);
                 outb_p(reg, client->addr + LM78_ADDR_REG_OFFSET);
                 res = inb_p(client->addr + LM78_DATA_REG_OFFSET);
-                up(&data->lock);
+                mutex_unlock(&data->lock);
                 return res;
         } else
                 return i2c_smbus_read_byte_data(client, reg);
@@ -717,10 +718,10 @@ static int lm78_write_value(struct i2c_client *client, u8 reg, u8 value)
 {
         if (i2c_is_isa_client(client)) {
                 struct lm78_data *data = i2c_get_clientdata(client);
-                down(&data->lock);
+                mutex_lock(&data->lock);
                 outb_p(reg, client->addr + LM78_ADDR_REG_OFFSET);
                 outb_p(value, client->addr + LM78_DATA_REG_OFFSET);
-                up(&data->lock);
+                mutex_unlock(&data->lock);
                 return 0;
         } else
                 return i2c_smbus_write_byte_data(client, reg, value);
@@ -742,7 +743,7 @@ static struct lm78_data *lm78_update_device(struct device *dev)
         struct lm78_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -786,7 +787,7 @@ static struct lm78_data *lm78_update_device(struct device *dev)
                 data->fan_div[2] = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c
index c9a7cdea7bd7..f72120d08c4c 100644
--- a/drivers/hwmon/lm80.c
+++ b/drivers/hwmon/lm80.c
@@ -28,6 +28,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x28, 0x29, 0x2a, 0x2b, 0x2c,
@@ -108,7 +109,7 @@ static inline long TEMP_FROM_REG(u16 temp)
 struct lm80_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -191,10 +192,10 @@ static ssize_t set_in_##suffix(struct device *dev, struct device_attribute *attr
         struct lm80_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock);\
+        mutex_lock(&data->update_lock);\
         data->value = IN_TO_REG(val); \
         lm80_write_value(client, reg, data->value); \
-        up(&data->update_lock);\
+        mutex_unlock(&data->update_lock);\
         return count; \
 }
 set_in(min0, in_min[0], LM80_REG_IN_MIN(0));
@@ -241,10 +242,10 @@ static ssize_t set_fan_##suffix(struct device *dev, struct device_attribute *att
         struct lm80_data *data = i2c_get_clientdata(client); \
         long val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock);\
+        mutex_lock(&data->update_lock);\
         data->value = FAN_TO_REG(val, DIV_FROM_REG(data->div)); \
         lm80_write_value(client, reg, data->value); \
-        up(&data->update_lock);\
+        mutex_unlock(&data->update_lock);\
         return count; \
 }
 set_fan(min1, fan_min[0], LM80_REG_FAN_MIN(1), fan_div[0]);
@@ -263,7 +264,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         u8 reg;
 
         /* Save fan_min */
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = FAN_FROM_REG(data->fan_min[nr],
                            DIV_FROM_REG(data->fan_div[nr]));
 
@@ -275,7 +276,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         default:
                 dev_err(&client->dev, "fan_div value %ld not "
                         "supported. Choose one of 1, 2, 4 or 8!\n", val);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
@@ -286,7 +287,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         /* Restore fan_min */
         data->fan_min[nr] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         lm80_write_value(client, LM80_REG_FAN_MIN(nr + 1), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -325,10 +326,10 @@ static ssize_t set_temp_##suffix(struct device *dev, struct device_attribute *at
         struct lm80_data *data = i2c_get_clientdata(client); \
         long val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->value = TEMP_LIMIT_TO_REG(val); \
         lm80_write_value(client, reg, data->value); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 set_temp(hot_max, temp_hot_max, LM80_REG_TEMP_HOT_MAX);
@@ -437,7 +438,7 @@ static int lm80_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields and put it into the global list */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -545,7 +546,7 @@ static struct lm80_data *lm80_update_device(struct device *dev)
         struct lm80_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {
                 dev_dbg(&client->dev, "Starting lm80 update\n");
@@ -585,7 +586,7 @@ static struct lm80_data *lm80_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
index 26dfa9e216c2..aac4ec2bf694 100644
--- a/drivers/hwmon/lm83.c
+++ b/drivers/hwmon/lm83.c
@@ -35,6 +35,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -139,7 +140,7 @@ static struct i2c_driver lm83_driver = {
 struct lm83_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -171,11 +172,11 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *devattr,
         long val = simple_strtol(buf, NULL, 10);
         int nr = attr->index;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp[nr] = TEMP_TO_REG(val);
         i2c_smbus_write_byte_data(client, LM83_REG_W_HIGH[nr - 4],
                                   data->temp[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -300,7 +301,7 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
         /* We can fill in the remaining client fields */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -373,7 +374,7 @@ static struct lm83_data *lm83_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm83_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
                 int nr;
@@ -393,7 +394,7 @@ static struct lm83_data *lm83_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
index 7389a0127547..342e9663119d 100644
--- a/drivers/hwmon/lm85.c
+++ b/drivers/hwmon/lm85.c
@@ -31,6 +31,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };
@@ -331,10 +332,10 @@ struct lm85_autofan {
 struct lm85_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         int valid;              /* !=0 if following fields are valid */
         unsigned long last_reading;     /* In jiffies */
         unsigned long last_config;      /* In jiffies */
@@ -373,8 +374,8 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
                         int kind);
 static int lm85_detach_client(struct i2c_client *client);
 
-static int lm85_read_value(struct i2c_client *client, u8 register);
-static int lm85_write_value(struct i2c_client *client, u8 register, int value);
+static int lm85_read_value(struct i2c_client *client, u8 reg);
+static int lm85_write_value(struct i2c_client *client, u8 reg, int value);
 static struct lm85_data *lm85_update_device(struct device *dev);
 static void lm85_init_client(struct i2c_client *client);
 
@@ -407,10 +408,10 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val);
         lm85_write_value(client, LM85_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -499,10 +500,10 @@ static ssize_t set_pwm(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[nr] = PWM_TO_REG(val);
         lm85_write_value(client, LM85_REG_PWM(nr), data->pwm[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_pwm_enable(struct device *dev, char *buf, int nr)
@@ -559,10 +560,10 @@ static ssize_t set_in_min(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = INS_TO_REG(nr, val);
         lm85_write_value(client, LM85_REG_IN_MIN(nr), data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_in_max(struct device *dev, char *buf, int nr)
@@ -577,10 +578,10 @@ static ssize_t set_in_max(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = INS_TO_REG(nr, val);
         lm85_write_value(client, LM85_REG_IN_MAX(nr), data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_in_reg(offset)                                             \
@@ -640,10 +641,10 @@ static ssize_t set_temp_min(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[nr] = TEMP_TO_REG(val);
         lm85_write_value(client, LM85_REG_TEMP_MIN(nr), data->temp_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_temp_max(struct device *dev, char *buf, int nr)
@@ -658,10 +659,10 @@ static ssize_t set_temp_max(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);        
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[nr] = TEMP_TO_REG(val);
         lm85_write_value(client, LM85_REG_TEMP_MAX(nr), data->temp_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_temp_reg(offset)                                           \
@@ -713,12 +714,12 @@ static ssize_t set_pwm_auto_channels(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);   
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->autofan[nr].config = (data->autofan[nr].config & (~0xe0))
                 | ZONE_TO_REG(val) ;
         lm85_write_value(client, LM85_REG_AFAN_CONFIG(nr),
                 data->autofan[nr].config);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_pwm_auto_pwm_min(struct device *dev, char *buf, int nr)
@@ -733,11 +734,11 @@ static ssize_t set_pwm_auto_pwm_min(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->autofan[nr].min_pwm = PWM_TO_REG(val);
         lm85_write_value(client, LM85_REG_AFAN_MINPWM(nr),
                 data->autofan[nr].min_pwm);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_pwm_auto_pwm_minctl(struct device *dev, char *buf, int nr)
@@ -752,7 +753,7 @@ static ssize_t set_pwm_auto_pwm_minctl(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->autofan[nr].min_off = val;
         lm85_write_value(client, LM85_REG_AFAN_SPIKE1, data->smooth[0]
                 | data->syncpwm3
@@ -760,7 +761,7 @@ static ssize_t set_pwm_auto_pwm_minctl(struct device *dev, const char *buf,
                 | (data->autofan[1].min_off ? 0x40 : 0)
                 | (data->autofan[2].min_off ? 0x80 : 0)
         );
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_pwm_auto_pwm_freq(struct device *dev, char *buf, int nr)
@@ -775,13 +776,13 @@ static ssize_t set_pwm_auto_pwm_freq(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->autofan[nr].freq = FREQ_TO_REG(val);
         lm85_write_value(client, LM85_REG_AFAN_RANGE(nr),
                 (data->zone[nr].range << 4)
                 | data->autofan[nr].freq
         ); 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define pwm_auto(offset)                                                \
@@ -857,7 +858,7 @@ static ssize_t set_temp_auto_temp_off(struct device *dev, const char *buf,
         int min;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = TEMP_FROM_REG(data->zone[nr].limit);
         data->zone[nr].off_desired = TEMP_TO_REG(val);
         data->zone[nr].hyst = HYST_TO_REG(min - val);
@@ -871,7 +872,7 @@ static ssize_t set_temp_auto_temp_off(struct device *dev, const char *buf,
                         (data->zone[2].hyst << 4)
                 );
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_temp_auto_temp_min(struct device *dev, char *buf, int nr)
@@ -886,7 +887,7 @@ static ssize_t set_temp_auto_temp_min(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->zone[nr].limit = TEMP_TO_REG(val);
         lm85_write_value(client, LM85_REG_AFAN_LIMIT(nr),
                 data->zone[nr].limit);
@@ -913,7 +914,7 @@ static ssize_t set_temp_auto_temp_min(struct device *dev, const char *buf,
                         (data->zone[2].hyst << 4)
                 );
         }
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_temp_auto_temp_max(struct device *dev, char *buf, int nr)
@@ -930,7 +931,7 @@ static ssize_t set_temp_auto_temp_max(struct device *dev, const char *buf,
         int min;
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = TEMP_FROM_REG(data->zone[nr].limit);
         data->zone[nr].max_desired = TEMP_TO_REG(val);
         data->zone[nr].range = RANGE_TO_REG(
@@ -938,7 +939,7 @@ static ssize_t set_temp_auto_temp_max(struct device *dev, const char *buf,
         lm85_write_value(client, LM85_REG_AFAN_RANGE(nr),
                 ((data->zone[nr].range & 0x0f) << 4)
                 | (data->autofan[nr].freq & 0x07));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t show_temp_auto_temp_crit(struct device *dev, char *buf, int nr)
@@ -953,11 +954,11 @@ static ssize_t set_temp_auto_temp_crit(struct device *dev, const char *buf,
         struct lm85_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->zone[nr].critical = TEMP_TO_REG(val);
         lm85_write_value(client, LM85_REG_AFAN_CRITICAL(nr),
                 data->zone[nr].critical);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define temp_auto(offset)                                               \
@@ -1149,7 +1150,7 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
         /* Fill in the remaining client fields */
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -1368,7 +1369,7 @@ static struct lm85_data *lm85_update_device(struct device *dev)
         struct lm85_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if ( !data->valid ||
              time_after(jiffies, data->last_reading + LM85_DATA_INTERVAL) ) {
@@ -1571,7 +1572,7 @@ static struct lm85_data *lm85_update_device(struct device *dev)
 
         data->valid = 1;
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index 6ba34c302d8d..e229daf666de 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -60,6 +60,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -176,7 +177,7 @@ static struct i2c_driver lm87_driver = {
 struct lm87_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* In jiffies */
 
@@ -253,11 +254,11 @@ static void set_in_min(struct device *dev, const char *buf, int nr)
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = IN_TO_REG(val, data->in_scale[nr]);
         lm87_write_value(client, nr<6 ? LM87_REG_IN_MIN(nr) :
                          LM87_REG_AIN_MIN(nr-6), data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 static void set_in_max(struct device *dev, const char *buf, int nr)
@@ -266,11 +267,11 @@ static void set_in_max(struct device *dev, const char *buf, int nr)
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = IN_TO_REG(val, data->in_scale[nr]);
         lm87_write_value(client, nr<6 ? LM87_REG_IN_MAX(nr) :
                          LM87_REG_AIN_MAX(nr-6), data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 #define set_in(offset) \
@@ -327,10 +328,10 @@ static void set_temp_low(struct device *dev, const char *buf, int nr)
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_low[nr] = TEMP_TO_REG(val);
         lm87_write_value(client, LM87_REG_TEMP_LOW[nr], data->temp_low[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 static void set_temp_high(struct device *dev, const char *buf, int nr)
@@ -339,10 +340,10 @@ static void set_temp_high(struct device *dev, const char *buf, int nr)
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_high[nr] = TEMP_TO_REG(val);
         lm87_write_value(client, LM87_REG_TEMP_HIGH[nr], data->temp_high[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 #define set_temp(offset) \
@@ -411,11 +412,11 @@ static void set_fan_min(struct device *dev, const char *buf, int nr)
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val,
                             FAN_DIV_FROM_REG(data->fan_div[nr]));
         lm87_write_value(client, LM87_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 /* Note: we save and restore the fan minimum here, because its value is
@@ -431,7 +432,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         unsigned long min;
         u8 reg;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = FAN_FROM_REG(data->fan_min[nr],
                            FAN_DIV_FROM_REG(data->fan_div[nr]));
 
@@ -441,7 +442,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         case 4: data->fan_div[nr] = 2; break;
         case 8: data->fan_div[nr] = 3; break;
         default:
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
@@ -459,7 +460,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         data->fan_min[nr] = FAN_TO_REG(min, val);
         lm87_write_value(client, LM87_REG_FAN_MIN(nr),
                          data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -522,10 +523,10 @@ static ssize_t set_aout(struct device *dev, struct device_attribute *attr, const
         struct lm87_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->aout = AOUT_TO_REG(val);
         lm87_write_value(client, LM87_REG_AOUT, data->aout);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static DEVICE_ATTR(aout_output, S_IRUGO | S_IWUSR, show_aout, set_aout);
@@ -589,7 +590,7 @@ static int lm87_detect(struct i2c_adapter *adapter, int address, int kind)
         /* We can fill in the remaining client fields */
         strlcpy(new_client->name, "lm87", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -744,7 +745,7 @@ static struct lm87_data *lm87_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm87_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
                 int i, j;
@@ -813,7 +814,7 @@ static struct lm87_data *lm87_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index 5679464447cc..d9eeaf7585bd 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -78,6 +78,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /*
  * Addresses to scan
@@ -201,7 +202,7 @@ static struct i2c_driver lm90_driver = {
 struct lm90_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
         int kind;
@@ -247,13 +248,13 @@ static ssize_t set_temp8(struct device *dev, struct device_attribute *devattr,
         long val = simple_strtol(buf, NULL, 10);
         int nr = attr->index;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (data->kind == adt7461)
                 data->temp8[nr] = TEMP1_TO_REG_ADT7461(val);
         else
                 data->temp8[nr] = TEMP1_TO_REG(val);
         i2c_smbus_write_byte_data(client, reg[nr - 1], data->temp8[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -281,7 +282,7 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,
         long val = simple_strtol(buf, NULL, 10);
         int nr = attr->index;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (data->kind == adt7461)
                 data->temp11[nr] = TEMP2_TO_REG_ADT7461(val);
         else
@@ -290,7 +291,7 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,
                                   data->temp11[nr] >> 8);
         i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2 + 1],
                                   data->temp11[nr] & 0xff);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -311,11 +312,11 @@ static ssize_t set_temphyst(struct device *dev, struct device_attribute *dummy,
         long val = simple_strtol(buf, NULL, 10);
         long hyst;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         hyst = TEMP1_FROM_REG(data->temp8[3]) - val;
         i2c_smbus_write_byte_data(client, LM90_REG_W_TCRIT_HYST,
                                   HYST_TO_REG(hyst));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -558,7 +559,7 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
         data->kind = kind;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -646,7 +647,7 @@ static struct lm90_data *lm90_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm90_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
                 u8 oldh, newh, l;
@@ -692,7 +693,7 @@ static struct lm90_data *lm90_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
index b0c4cb730a7e..197f77226dc4 100644
--- a/drivers/hwmon/lm92.c
+++ b/drivers/hwmon/lm92.c
@@ -46,6 +46,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* The LM92 and MAX6635 have 2 two-state pins for address selection,
    resulting in 4 possible addresses. */
@@ -96,7 +97,7 @@ static struct i2c_driver lm92_driver;
 struct lm92_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -114,7 +115,7 @@ static struct lm92_data *lm92_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct lm92_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ)
          || !data->valid) {
@@ -134,7 +135,7 @@ static struct lm92_data *lm92_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
@@ -158,10 +159,10 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
         struct lm92_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->value = TEMP_TO_REG(val); \
         i2c_smbus_write_word_data(client, reg, swab16(data->value)); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 set_temp(temp1_crit, LM92_REG_TEMP_CRIT);
@@ -194,11 +195,11 @@ static ssize_t set_temp1_crit_hyst(struct device *dev, struct device_attribute *
         struct lm92_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp1_hyst = TEMP_FROM_REG(data->temp1_crit) - val;
         i2c_smbus_write_word_data(client, LM92_REG_TEMP_HYST,
                                   swab16(TEMP_TO_REG(data->temp1_hyst)));
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -348,7 +349,7 @@ static int lm92_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the i2c subsystem a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
diff --git a/drivers/hwmon/max1619.c b/drivers/hwmon/max1619.c
index 3abe330b22ce..b4135b5971f4 100644
--- a/drivers/hwmon/max1619.c
+++ b/drivers/hwmon/max1619.c
@@ -33,6 +33,7 @@
 #include <linux/i2c.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 static unsigned short normal_i2c[] = { 0x18, 0x19, 0x1a,
                                         0x29, 0x2a, 0x2b,
@@ -104,7 +105,7 @@ static struct i2c_driver max1619_driver = {
 struct max1619_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -141,10 +142,10 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
         struct max1619_data *data = i2c_get_clientdata(client); \
         long val = simple_strtol(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->value = TEMP_TO_REG(val); \
         i2c_smbus_write_byte_data(client, reg, data->value); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 
@@ -262,7 +263,7 @@ static int max1619_detect(struct i2c_adapter *adapter, int address, int kind)
         /* We can fill in the remaining client fields */
         strlcpy(new_client->name, name, I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -330,7 +331,7 @@ static struct max1619_data *max1619_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct max1619_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
                 dev_dbg(&client->dev, "Updating max1619 data.\n");
@@ -353,7 +354,7 @@ static struct max1619_data *max1619_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index f161e88e3bb6..ae05e483a778 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -43,6 +43,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 static u8 devid;
@@ -183,8 +184,8 @@ static inline u8 PWM_TO_REG(int val, int inv)
 struct pc87360_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
-        struct semaphore update_lock;
+        struct mutex lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -283,7 +284,7 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *devattr,
         struct pc87360_data *data = i2c_get_clientdata(client);
         long fan_min = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         fan_min = FAN_TO_REG(fan_min, FAN_DIV_FROM_REG(data->fan_status[attr->index]));
 
         /* If it wouldn't fit, change clock divisor */
@@ -300,23 +301,31 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *devattr,
         /* Write new divider, preserve alarm bits */
         pc87360_write_value(data, LD_FAN, NO_BANK, PC87360_REG_FAN_STATUS(attr->index),
                             data->fan_status[attr->index] & 0xF9);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-#define show_and_set_fan(offset) \
-static SENSOR_DEVICE_ATTR(fan##offset##_input, S_IRUGO, \
-        show_fan_input, NULL, offset-1); \
-static SENSOR_DEVICE_ATTR(fan##offset##_min, S_IWUSR | S_IRUGO, \
-        show_fan_min, set_fan_min, offset-1); \
-static SENSOR_DEVICE_ATTR(fan##offset##_div, S_IRUGO, \
-        show_fan_div, NULL, offset-1); \
-static SENSOR_DEVICE_ATTR(fan##offset##_status, S_IRUGO, \
-        show_fan_status, NULL, offset-1);
-show_and_set_fan(1)
-show_and_set_fan(2)
-show_and_set_fan(3)
+static struct sensor_device_attribute fan_input[] = {
+        SENSOR_ATTR(fan1_input, S_IRUGO, show_fan_input, NULL, 0),
+        SENSOR_ATTR(fan2_input, S_IRUGO, show_fan_input, NULL, 1),
+        SENSOR_ATTR(fan3_input, S_IRUGO, show_fan_input, NULL, 2),
+};
+static struct sensor_device_attribute fan_status[] = {
+        SENSOR_ATTR(fan1_status, S_IRUGO, show_fan_status, NULL, 0),
+        SENSOR_ATTR(fan2_status, S_IRUGO, show_fan_status, NULL, 1),
+        SENSOR_ATTR(fan3_status, S_IRUGO, show_fan_status, NULL, 2),
+};
+static struct sensor_device_attribute fan_div[] = {
+        SENSOR_ATTR(fan1_div, S_IRUGO, show_fan_div, NULL, 0),
+        SENSOR_ATTR(fan2_div, S_IRUGO, show_fan_div, NULL, 1),
+        SENSOR_ATTR(fan3_div, S_IRUGO, show_fan_div, NULL, 2),
+};
+static struct sensor_device_attribute fan_min[] = {
+        SENSOR_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan_min, set_fan_min, 0),
+        SENSOR_ATTR(fan2_min, S_IWUSR | S_IRUGO, show_fan_min, set_fan_min, 1),
+        SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min, set_fan_min, 2),
+};
 
 static ssize_t show_pwm(struct device *dev, struct device_attribute *devattr, char *buf)
 {
@@ -335,21 +344,20 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *devattr, con
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[attr->index] = PWM_TO_REG(val,
                               FAN_CONFIG_INVERT(data->fan_conf, attr->index));
         pc87360_write_value(data, LD_FAN, NO_BANK, PC87360_REG_PWM(attr->index),
                             data->pwm[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
-#define show_and_set_pwm(offset) \
-static SENSOR_DEVICE_ATTR(pwm##offset, S_IWUSR | S_IRUGO, \
-        show_pwm, set_pwm, offset-1);
-show_and_set_pwm(1)
-show_and_set_pwm(2)
-show_and_set_pwm(3)
+static struct sensor_device_attribute pwm[] = {
+        SENSOR_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm, set_pwm, 0),
+        SENSOR_ATTR(pwm2, S_IWUSR | S_IRUGO, show_pwm, set_pwm, 1),
+        SENSOR_ATTR(pwm3, S_IWUSR | S_IRUGO, show_pwm, set_pwm, 2),
+};
 
 static ssize_t show_in_input(struct device *dev, struct device_attribute *devattr, char *buf)
 {
@@ -386,11 +394,11 @@ static ssize_t set_in_min(struct device *dev, struct device_attribute *devattr,
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[attr->index] = IN_TO_REG(val, data->in_vref);
         pc87360_write_value(data, LD_IN, attr->index, PC87365_REG_IN_MIN,
                             data->in_min[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_in_max(struct device *dev, struct device_attribute *devattr, const char *buf,
@@ -401,35 +409,67 @@ static ssize_t set_in_max(struct device *dev, struct device_attribute *devattr,
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[attr->index] = IN_TO_REG(val,
                                data->in_vref);
         pc87360_write_value(data, LD_IN, attr->index, PC87365_REG_IN_MAX,
                             data->in_max[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
-#define show_and_set_in(offset) \
-static SENSOR_DEVICE_ATTR(in##offset##_input, S_IRUGO, \
-        show_in_input, NULL, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_min, S_IWUSR | S_IRUGO, \
-        show_in_min, set_in_min, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_max, S_IWUSR | S_IRUGO, \
-        show_in_max, set_in_max, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_status, S_IRUGO, \
-        show_in_status, NULL, offset);
-show_and_set_in(0)
-show_and_set_in(1)
-show_and_set_in(2)
-show_and_set_in(3)
-show_and_set_in(4)
-show_and_set_in(5)
-show_and_set_in(6)
-show_and_set_in(7)
-show_and_set_in(8)
-show_and_set_in(9)
-show_and_set_in(10)
+static struct sensor_device_attribute in_input[] = {
+        SENSOR_ATTR(in0_input, S_IRUGO, show_in_input, NULL, 0),
+        SENSOR_ATTR(in1_input, S_IRUGO, show_in_input, NULL, 1),
+        SENSOR_ATTR(in2_input, S_IRUGO, show_in_input, NULL, 2),
+        SENSOR_ATTR(in3_input, S_IRUGO, show_in_input, NULL, 3),
+        SENSOR_ATTR(in4_input, S_IRUGO, show_in_input, NULL, 4),
+        SENSOR_ATTR(in5_input, S_IRUGO, show_in_input, NULL, 5),
+        SENSOR_ATTR(in6_input, S_IRUGO, show_in_input, NULL, 6),
+        SENSOR_ATTR(in7_input, S_IRUGO, show_in_input, NULL, 7),
+        SENSOR_ATTR(in8_input, S_IRUGO, show_in_input, NULL, 8),
+        SENSOR_ATTR(in9_input, S_IRUGO, show_in_input, NULL, 9),
+        SENSOR_ATTR(in10_input, S_IRUGO, show_in_input, NULL, 10),
+};
+static struct sensor_device_attribute in_status[] = {
+        SENSOR_ATTR(in0_status, S_IRUGO, show_in_status, NULL, 0),
+        SENSOR_ATTR(in1_status, S_IRUGO, show_in_status, NULL, 1),
+        SENSOR_ATTR(in2_status, S_IRUGO, show_in_status, NULL, 2),
+        SENSOR_ATTR(in3_status, S_IRUGO, show_in_status, NULL, 3),
+        SENSOR_ATTR(in4_status, S_IRUGO, show_in_status, NULL, 4),
+        SENSOR_ATTR(in5_status, S_IRUGO, show_in_status, NULL, 5),
+        SENSOR_ATTR(in6_status, S_IRUGO, show_in_status, NULL, 6),
+        SENSOR_ATTR(in7_status, S_IRUGO, show_in_status, NULL, 7),
+        SENSOR_ATTR(in8_status, S_IRUGO, show_in_status, NULL, 8),
+        SENSOR_ATTR(in9_status, S_IRUGO, show_in_status, NULL, 9),
+        SENSOR_ATTR(in10_status, S_IRUGO, show_in_status, NULL, 10),
+};
+static struct sensor_device_attribute in_min[] = {
+        SENSOR_ATTR(in0_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 0),
+        SENSOR_ATTR(in1_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 1),
+        SENSOR_ATTR(in2_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 2),
+        SENSOR_ATTR(in3_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 3),
+        SENSOR_ATTR(in4_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 4),
+        SENSOR_ATTR(in5_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 5),
+        SENSOR_ATTR(in6_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 6),
+        SENSOR_ATTR(in7_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 7),
+        SENSOR_ATTR(in8_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 8),
+        SENSOR_ATTR(in9_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 9),
+        SENSOR_ATTR(in10_min, S_IWUSR | S_IRUGO, show_in_min, set_in_min, 10),
+};
+static struct sensor_device_attribute in_max[] = {
+        SENSOR_ATTR(in0_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 0),
+        SENSOR_ATTR(in1_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 1),
+        SENSOR_ATTR(in2_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 2),
+        SENSOR_ATTR(in3_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 3),
+        SENSOR_ATTR(in4_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 4),
+        SENSOR_ATTR(in5_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 5),
+        SENSOR_ATTR(in6_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 6),
+        SENSOR_ATTR(in7_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 7),
+        SENSOR_ATTR(in8_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 8),
+        SENSOR_ATTR(in9_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 9),
+        SENSOR_ATTR(in10_max, S_IWUSR | S_IRUGO, show_in_max, set_in_max, 10),
+};
 
 static ssize_t show_therm_input(struct device *dev, struct device_attribute *devattr, char *buf)
 {
@@ -473,11 +513,11 @@ static ssize_t set_therm_min(struct device *dev, struct device_attribute *devatt
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[attr->index] = IN_TO_REG(val, data->in_vref);
         pc87360_write_value(data, LD_IN, attr->index, PC87365_REG_TEMP_MIN,
                             data->in_min[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_therm_max(struct device *dev, struct device_attribute *devattr, const char *buf,
@@ -488,11 +528,11 @@ static ssize_t set_therm_max(struct device *dev, struct device_attribute *devatt
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[attr->index] = IN_TO_REG(val, data->in_vref);
         pc87360_write_value(data, LD_IN, attr->index, PC87365_REG_TEMP_MAX,
                             data->in_max[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_therm_crit(struct device *dev, struct device_attribute *devattr, const char *buf,
@@ -503,28 +543,51 @@ static ssize_t set_therm_crit(struct device *dev, struct device_attribute *devat
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_crit[attr->index-11] = IN_TO_REG(val, data->in_vref);
         pc87360_write_value(data, LD_IN, attr->index, PC87365_REG_TEMP_CRIT,
                             data->in_crit[attr->index-11]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
-#define show_and_set_therm(offset) \
-static SENSOR_DEVICE_ATTR(temp##offset##_input, S_IRUGO, \
-        show_therm_input, NULL, 11+offset-4); \
-static SENSOR_DEVICE_ATTR(temp##offset##_min, S_IWUSR | S_IRUGO, \
-        show_therm_min, set_therm_min, 11+offset-4); \
-static SENSOR_DEVICE_ATTR(temp##offset##_max, S_IWUSR | S_IRUGO, \
-        show_therm_max, set_therm_max, 11+offset-4); \
-static SENSOR_DEVICE_ATTR(temp##offset##_crit, S_IWUSR | S_IRUGO, \
-        show_therm_crit, set_therm_crit, 11+offset-4); \
-static SENSOR_DEVICE_ATTR(temp##offset##_status, S_IRUGO, \
-        show_therm_status, NULL, 11+offset-4);
-show_and_set_therm(4)
-show_and_set_therm(5)
-show_and_set_therm(6)
+/* the +11 term below reflects the fact that VLM units 11,12,13 are
+   used in the chip to measure voltage across the thermistors
+*/
+static struct sensor_device_attribute therm_input[] = {
+        SENSOR_ATTR(temp4_input, S_IRUGO, show_therm_input, NULL, 0+11),
+        SENSOR_ATTR(temp5_input, S_IRUGO, show_therm_input, NULL, 1+11),
+        SENSOR_ATTR(temp6_input, S_IRUGO, show_therm_input, NULL, 2+11),
+};
+static struct sensor_device_attribute therm_status[] = {
+        SENSOR_ATTR(temp4_status, S_IRUGO, show_therm_status, NULL, 0+11),
+        SENSOR_ATTR(temp5_status, S_IRUGO, show_therm_status, NULL, 1+11),
+        SENSOR_ATTR(temp6_status, S_IRUGO, show_therm_status, NULL, 2+11),
+};
+static struct sensor_device_attribute therm_min[] = {
+        SENSOR_ATTR(temp4_min, S_IRUGO | S_IWUSR,
+                    show_therm_min, set_therm_min, 0+11),
+        SENSOR_ATTR(temp5_min, S_IRUGO | S_IWUSR,
+                    show_therm_min, set_therm_min, 1+11),
+        SENSOR_ATTR(temp6_min, S_IRUGO | S_IWUSR,
+                    show_therm_min, set_therm_min, 2+11),
+};
+static struct sensor_device_attribute therm_max[] = {
+        SENSOR_ATTR(temp4_max, S_IRUGO | S_IWUSR,
+                    show_therm_max, set_therm_max, 0+11),
+        SENSOR_ATTR(temp5_max, S_IRUGO | S_IWUSR,
+                    show_therm_max, set_therm_max, 1+11),
+        SENSOR_ATTR(temp6_max, S_IRUGO | S_IWUSR,
+                    show_therm_max, set_therm_max, 2+11),
+};
+static struct sensor_device_attribute therm_crit[] = {
+        SENSOR_ATTR(temp4_crit, S_IRUGO | S_IWUSR,
+                    show_therm_crit, set_therm_crit, 0+11),
+        SENSOR_ATTR(temp5_crit, S_IRUGO | S_IWUSR,
+                    show_therm_crit, set_therm_crit, 1+11),
+        SENSOR_ATTR(temp6_crit, S_IRUGO | S_IWUSR,
+                    show_therm_crit, set_therm_crit, 2+11),
+};
 
 static ssize_t show_vid(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -592,11 +655,11 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *devattr
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[attr->index] = TEMP_TO_REG(val);
         pc87360_write_value(data, LD_TEMP, attr->index, PC87365_REG_TEMP_MIN,
                             data->temp_min[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp_max(struct device *dev, struct device_attribute *devattr, const char *buf,
@@ -607,11 +670,11 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *devattr
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[attr->index] = TEMP_TO_REG(val);
         pc87360_write_value(data, LD_TEMP, attr->index, PC87365_REG_TEMP_MAX,
                             data->temp_max[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp_crit(struct device *dev, struct device_attribute *devattr, const char *buf,
@@ -622,28 +685,48 @@ static ssize_t set_temp_crit(struct device *dev, struct device_attribute *devatt
         struct pc87360_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_crit[attr->index] = TEMP_TO_REG(val);
         pc87360_write_value(data, LD_TEMP, attr->index, PC87365_REG_TEMP_CRIT,
                             data->temp_crit[attr->index]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
-#define show_and_set_temp(offset) \
-static SENSOR_DEVICE_ATTR(temp##offset##_input, S_IRUGO, \
-        show_temp_input, NULL, offset-1); \
-static SENSOR_DEVICE_ATTR(temp##offset##_min, S_IWUSR | S_IRUGO, \
-        show_temp_min, set_temp_min, offset-1); \
-static SENSOR_DEVICE_ATTR(temp##offset##_max, S_IWUSR | S_IRUGO, \
-        show_temp_max, set_temp_max, offset-1); \
-static SENSOR_DEVICE_ATTR(temp##offset##_crit, S_IWUSR | S_IRUGO, \
-        show_temp_crit, set_temp_crit, offset-1); \
-static SENSOR_DEVICE_ATTR(temp##offset##_status, S_IRUGO, \
-        show_temp_status, NULL, offset-1);
-show_and_set_temp(1)
-show_and_set_temp(2)
-show_and_set_temp(3)
+static struct sensor_device_attribute temp_input[] = {
+        SENSOR_ATTR(temp1_input, S_IRUGO, show_temp_input, NULL, 0),
+        SENSOR_ATTR(temp2_input, S_IRUGO, show_temp_input, NULL, 1),
+        SENSOR_ATTR(temp3_input, S_IRUGO, show_temp_input, NULL, 2),
+};
+static struct sensor_device_attribute temp_status[] = {
+        SENSOR_ATTR(temp1_status, S_IRUGO, show_temp_status, NULL, 0),
+        SENSOR_ATTR(temp2_status, S_IRUGO, show_temp_status, NULL, 1),
+        SENSOR_ATTR(temp3_status, S_IRUGO, show_temp_status, NULL, 2),
+};
+static struct sensor_device_attribute temp_min[] = {
+        SENSOR_ATTR(temp1_min, S_IRUGO | S_IWUSR,
+                    show_temp_min, set_temp_min, 0),
+        SENSOR_ATTR(temp2_min, S_IRUGO | S_IWUSR,
+                    show_temp_min, set_temp_min, 1),
+        SENSOR_ATTR(temp3_min, S_IRUGO | S_IWUSR,
+                    show_temp_min, set_temp_min, 2),
+};
+static struct sensor_device_attribute temp_max[] = {
+        SENSOR_ATTR(temp1_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 0),
+        SENSOR_ATTR(temp2_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 1),
+        SENSOR_ATTR(temp3_max, S_IRUGO | S_IWUSR,
+                    show_temp_max, set_temp_max, 2),
+};
+static struct sensor_device_attribute temp_crit[] = {
+        SENSOR_ATTR(temp1_crit, S_IRUGO | S_IWUSR,
+                    show_temp_crit, set_temp_crit, 0),
+        SENSOR_ATTR(temp2_crit, S_IRUGO | S_IWUSR,
+                    show_temp_crit, set_temp_crit, 1),
+        SENSOR_ATTR(temp3_crit, S_IRUGO | S_IWUSR,
+                    show_temp_crit, set_temp_crit, 2),
+};
 
 static ssize_t show_temp_alarms(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -749,22 +832,24 @@ static int __init pc87360_find(int sioaddr, u8 *devid, unsigned short *addresses
 static int pc87360_detect(struct i2c_adapter *adapter)
 {
         int i;
-        struct i2c_client *new_client;
+        struct i2c_client *client;
         struct pc87360_data *data;
         int err = 0;
         const char *name = "pc87360";
         int use_thermistors = 0;
+        struct device *dev;
 
         if (!(data = kzalloc(sizeof(struct pc87360_data), GFP_KERNEL)))
                 return -ENOMEM;
 
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        init_MUTEX(&data->lock);
-        new_client->adapter = adapter;
-        new_client->driver = &pc87360_driver;
-        new_client->flags = 0;
+        client = &data->client;
+        dev = &client->dev;
+        i2c_set_clientdata(client, data);
+        client->addr = address;
+        mutex_init(&data->lock);
+        client->adapter = adapter;
+        client->driver = &pc87360_driver;
+        client->flags = 0;
 
         data->fannr = 2;
         data->innr = 0;
@@ -792,15 +877,15 @@ static int pc87360_detect(struct i2c_adapter *adapter)
                 break;
         }
 
-        strcpy(new_client->name, name);
+        strlcpy(client->name, name, sizeof(client->name));
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         for (i = 0; i < 3; i++) {
                 if (((data->address[i] = extra_isa[i]))
                  && !request_region(extra_isa[i], PC87360_EXTENT,
                                     pc87360_driver.driver.name)) {
-                        dev_err(&new_client->dev, "Region 0x%x-0x%x already "
+                        dev_err(&client->dev, "Region 0x%x-0x%x already "
                                 "in use!\n", extra_isa[i],
                                 extra_isa[i]+PC87360_EXTENT-1);
                         for (i--; i >= 0; i--)
@@ -814,7 +899,7 @@ static int pc87360_detect(struct i2c_adapter *adapter)
         if (data->fannr)
                 data->fan_conf = confreg[0] | (confreg[1] << 8);
 
-        if ((err = i2c_attach_client(new_client)))
+        if ((err = i2c_attach_client(client)))
                 goto ERROR2;
 
         /* Use the correct reference voltage
@@ -828,7 +913,7 @@ static int pc87360_detect(struct i2c_adapter *adapter)
                                                 PC87365_REG_TEMP_CONFIG);
                 }
                 data->in_vref = (i&0x02) ? 3025 : 2966;
-                dev_dbg(&new_client->dev, "Using %s reference voltage\n",
+                dev_dbg(&client->dev, "Using %s reference voltage\n",
                         (i&0x02) ? "external" : "internal");
 
                 data->vid_conf = confreg[3];
@@ -847,154 +932,64 @@ static int pc87360_detect(struct i2c_adapter *adapter)
                 if (devid == 0xe9 && data->address[1]) /* PC87366 */
                         use_thermistors = confreg[2] & 0x40;
 
-                pc87360_init_client(new_client, use_thermistors);
+                pc87360_init_client(client, use_thermistors);
         }
 
         /* Register sysfs hooks */
-        data->class_dev = hwmon_device_register(&new_client->dev);
+        data->class_dev = hwmon_device_register(&client->dev);
         if (IS_ERR(data->class_dev)) {
                 err = PTR_ERR(data->class_dev);
                 goto ERROR3;
         }
 
         if (data->innr) {
-                device_create_file(&new_client->dev, &sensor_dev_attr_in0_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in1_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in2_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in3_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in4_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in5_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in6_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in7_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in8_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in9_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in10_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in0_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in1_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in2_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in3_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in4_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in5_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in6_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in7_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in8_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in9_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in10_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in0_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in1_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in2_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in3_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in4_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in5_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in6_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in7_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in8_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in9_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in10_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in0_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in1_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in2_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in3_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in4_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in5_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in6_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in7_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in8_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in9_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_in10_status.dev_attr);
-
-                device_create_file(&new_client->dev, &dev_attr_cpu0_vid);
-                device_create_file(&new_client->dev, &dev_attr_vrm);
-                device_create_file(&new_client->dev, &dev_attr_alarms_in);
+                for (i = 0; i < 11; i++) {
+                        device_create_file(dev, &in_input[i].dev_attr);
+                        device_create_file(dev, &in_min[i].dev_attr);
+                        device_create_file(dev, &in_max[i].dev_attr);
+                        device_create_file(dev, &in_status[i].dev_attr);
+                }
+                device_create_file(dev, &dev_attr_cpu0_vid);
+                device_create_file(dev, &dev_attr_vrm);
+                device_create_file(dev, &dev_attr_alarms_in);
         }
 
         if (data->tempnr) {
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp1_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp2_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp1_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp2_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp1_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp2_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp1_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp2_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp1_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp2_status.dev_attr);
-
-                device_create_file(&new_client->dev, &dev_attr_alarms_temp);
-        }
-        if (data->tempnr == 3) {
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp3_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp3_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp3_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp3_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp3_status.dev_attr);
-        }
-        if (data->innr == 14) {
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp4_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp5_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp6_input.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp4_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp5_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp6_min.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp4_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp5_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp6_max.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp4_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp5_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp6_crit.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp4_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp5_status.dev_attr);
-                device_create_file(&new_client->dev, &sensor_dev_attr_temp6_status.dev_attr);
-        }
-
-        if (data->fannr) {
-                if (FAN_CONFIG_MONITOR(data->fan_conf, 0)) {
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan1_input.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan1_min.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan1_div.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan1_status.dev_attr);
+                for (i = 0; i < data->tempnr; i++) {
+                        device_create_file(dev, &temp_input[i].dev_attr);
+                        device_create_file(dev, &temp_min[i].dev_attr);
+                        device_create_file(dev, &temp_max[i].dev_attr);
+                        device_create_file(dev, &temp_crit[i].dev_attr);
+                        device_create_file(dev, &temp_status[i].dev_attr);
                 }
+                device_create_file(dev, &dev_attr_alarms_temp);
+        }
 
-                if (FAN_CONFIG_MONITOR(data->fan_conf, 1)) {
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan2_input.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan2_min.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan2_div.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan2_status.dev_attr);
+        if (data->innr == 14) {
+                for (i = 0; i < 3; i++) {
+                        device_create_file(dev, &therm_input[i].dev_attr);
+                        device_create_file(dev, &therm_min[i].dev_attr);
+                        device_create_file(dev, &therm_max[i].dev_attr);
+                        device_create_file(dev, &therm_crit[i].dev_attr);
+                        device_create_file(dev, &therm_status[i].dev_attr);
                 }
-
-                if (FAN_CONFIG_CONTROL(data->fan_conf, 0))
-                        device_create_file(&new_client->dev, &sensor_dev_attr_pwm1.dev_attr);
-                if (FAN_CONFIG_CONTROL(data->fan_conf, 1))
-                        device_create_file(&new_client->dev, &sensor_dev_attr_pwm2.dev_attr);
         }
-        if (data->fannr == 3) {
-                if (FAN_CONFIG_MONITOR(data->fan_conf, 2)) {
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan3_input.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan3_min.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan3_div.dev_attr);
-                        device_create_file(&new_client->dev,
-                                           &sensor_dev_attr_fan3_status.dev_attr);
-                }
 
-                if (FAN_CONFIG_CONTROL(data->fan_conf, 2))
-                        device_create_file(&new_client->dev, &sensor_dev_attr_pwm3.dev_attr);
+        for (i = 0; i < data->fannr; i++) {
+                if (FAN_CONFIG_MONITOR(data->fan_conf, i)) {
+                        device_create_file(dev, &fan_input[i].dev_attr);
+                        device_create_file(dev, &fan_min[i].dev_attr);
+                        device_create_file(dev, &fan_div[i].dev_attr);
+                        device_create_file(dev, &fan_status[i].dev_attr);
+                }
+                if (FAN_CONFIG_CONTROL(data->fan_conf, i))
+                        device_create_file(dev, &pwm[i].dev_attr);
         }
 
         return 0;
 
 ERROR3:
-        i2c_detach_client(new_client);
+        i2c_detach_client(client);
 ERROR2:
         for (i = 0; i < 3; i++) {
                 if (data->address[i]) {
@@ -1033,11 +1028,11 @@ static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 {
         int res;
 
-        down(&(data->lock));
+        mutex_lock(&(data->lock));
         if (bank != NO_BANK)
                 outb_p(bank, data->address[ldi] + PC87365_REG_BANK);
         res = inb_p(data->address[ldi] + reg);
-        up(&(data->lock));
+        mutex_unlock(&(data->lock));
 
         return res;
 }
@@ -1045,11 +1040,11 @@ static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 static void pc87360_write_value(struct pc87360_data *data, u8 ldi, u8 bank,
                                 u8 reg, u8 value)
 {
-        down(&(data->lock));
+        mutex_lock(&(data->lock));
         if (bank != NO_BANK)
                 outb_p(bank, data->address[ldi] + PC87365_REG_BANK);
         outb_p(value, data->address[ldi] + reg);
-        up(&(data->lock));
+        mutex_unlock(&(data->lock));
 }
 
 static void pc87360_init_client(struct i2c_client *client, int use_thermistors)
@@ -1071,7 +1066,7 @@ static void pc87360_init_client(struct i2c_client *client, int use_thermistors)
         }
 
         nr = data->innr < 11 ? data->innr : 11;
-        for (i=0; i<nr; i++) {
+        for (i = 0; i < nr; i++) {
                 if (init >= init_in[i]) {
                         /* Forcibly enable voltage channel */
                         reg = pc87360_read_value(data, LD_IN, i,
@@ -1088,14 +1083,14 @@ static void pc87360_init_client(struct i2c_client *client, int use_thermistors)
 
         /* We can't blindly trust the Super-I/O space configuration bit,
            most BIOS won't set it properly */
-        for (i=11; i<data->innr; i++) {
+        for (i = 11; i < data->innr; i++) {
                 reg = pc87360_read_value(data, LD_IN, i,
                                          PC87365_REG_TEMP_STATUS);
                 use_thermistors = use_thermistors || (reg & 0x01);
         }
 
         i = use_thermistors ? 2 : 0;
-        for (; i<data->tempnr; i++) {
+        for (; i < data->tempnr; i++) {
                 if (init >= init_temp[i]) {
                         /* Forcibly enable temperature channel */
                         reg = pc87360_read_value(data, LD_TEMP, i,
@@ -1111,7 +1106,7 @@ static void pc87360_init_client(struct i2c_client *client, int use_thermistors)
         }
 
         if (use_thermistors) {
-                for (i=11; i<data->innr; i++) {
+                for (i = 11; i < data->innr; i++) {
                         if (init >= init_in[i]) {
                                 /* The pin may already be used by thermal
                                    diodes */
@@ -1221,7 +1216,7 @@ static struct pc87360_data *pc87360_update_device(struct device *dev)
         struct pc87360_data *data = i2c_get_clientdata(client);
         u8 i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
                 dev_dbg(&client->dev, "Data update\n");
@@ -1321,7 +1316,7 @@ static struct pc87360_data *pc87360_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c
index 8be5189d9bd9..6f3fda73f70c 100644
--- a/drivers/hwmon/sis5595.c
+++ b/drivers/hwmon/sis5595.c
@@ -60,6 +60,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/jiffies.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 
@@ -167,9 +168,9 @@ static inline u8 DIV_TO_REG(int val)
 struct sis5595_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
         char maxins;            /* == 3 if temp enabled, otherwise == 4 */
@@ -192,8 +193,8 @@ static struct pci_dev *s_bridge;	/* pointer to the (only) sis5595 */
 static int sis5595_detect(struct i2c_adapter *adapter);
 static int sis5595_detach_client(struct i2c_client *client);
 
-static int sis5595_read_value(struct i2c_client *client, u8 register);
-static int sis5595_write_value(struct i2c_client *client, u8 register, u8 value);
+static int sis5595_read_value(struct i2c_client *client, u8 reg);
+static int sis5595_write_value(struct i2c_client *client, u8 reg, u8 value);
 static struct sis5595_data *sis5595_update_device(struct device *dev);
 static void sis5595_init_client(struct i2c_client *client);
 
@@ -231,10 +232,10 @@ static ssize_t set_in_min(struct device *dev, const char *buf,
         struct sis5595_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = IN_TO_REG(val);
         sis5595_write_value(client, SIS5595_REG_IN_MIN(nr), data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -245,10 +246,10 @@ static ssize_t set_in_max(struct device *dev, const char *buf,
         struct sis5595_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = IN_TO_REG(val);
         sis5595_write_value(client, SIS5595_REG_IN_MAX(nr), data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -310,10 +311,10 @@ static ssize_t set_temp_over(struct device *dev, struct device_attribute *attr,
         struct sis5595_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_over = TEMP_TO_REG(val);
         sis5595_write_value(client, SIS5595_REG_TEMP_OVER, data->temp_over);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -329,10 +330,10 @@ static ssize_t set_temp_hyst(struct device *dev, struct device_attribute *attr,
         struct sis5595_data *data = i2c_get_clientdata(client);
         long val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_hyst = TEMP_TO_REG(val);
         sis5595_write_value(client, SIS5595_REG_TEMP_HYST, data->temp_hyst);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -364,10 +365,10 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct sis5595_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         sis5595_write_value(client, SIS5595_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -390,7 +391,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         unsigned long val = simple_strtoul(buf, NULL, 10);
         int reg;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         min = FAN_FROM_REG(data->fan_min[nr],
                         DIV_FROM_REG(data->fan_div[nr]));
         reg = sis5595_read_value(client, SIS5595_REG_FANDIV);
@@ -403,7 +404,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         default:
                 dev_err(&client->dev, "fan_div value %ld not "
                         "supported. Choose one of 1, 2, 4 or 8!\n", val);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
         
@@ -419,7 +420,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         data->fan_min[nr] =
                 FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         sis5595_write_value(client, SIS5595_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -527,7 +528,7 @@ static int sis5595_detect(struct i2c_adapter *adapter)
 
         new_client = &data->client;
         new_client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         i2c_set_clientdata(new_client, data);
         new_client->adapter = adapter;
         new_client->driver = &sis5595_driver;
@@ -548,7 +549,7 @@ static int sis5595_detect(struct i2c_adapter *adapter)
         strlcpy(new_client->name, "sis5595", I2C_NAME_SIZE);
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -635,20 +636,20 @@ static int sis5595_read_value(struct i2c_client *client, u8 reg)
         int res;
 
         struct sis5595_data *data = i2c_get_clientdata(client);
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb_p(reg, client->addr + SIS5595_ADDR_REG_OFFSET);
         res = inb_p(client->addr + SIS5595_DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return res;
 }
 
 static int sis5595_write_value(struct i2c_client *client, u8 reg, u8 value)
 {
         struct sis5595_data *data = i2c_get_clientdata(client);
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb_p(reg, client->addr + SIS5595_ADDR_REG_OFFSET);
         outb_p(value, client->addr + SIS5595_DATA_REG_OFFSET);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return 0;
 }
 
@@ -667,7 +668,7 @@ static struct sis5595_data *sis5595_update_device(struct device *dev)
         struct sis5595_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -707,7 +708,7 @@ static struct sis5595_data *sis5595_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/smsc47b397.c b/drivers/hwmon/smsc47b397.c
index 8663bbbe97f5..b6086186d225 100644
--- a/drivers/hwmon/smsc47b397.c
+++ b/drivers/hwmon/smsc47b397.c
@@ -35,6 +35,7 @@
 #include <linux/hwmon.h>
 #include <linux/err.h>
 #include <linux/init.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 /* Address is autodetected, there is no default value */
@@ -92,9 +93,9 @@ static u8 smsc47b397_reg_temp[] = {0x25, 0x26, 0x27, 0x80};
 struct smsc47b397_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         unsigned long last_updated; /* in jiffies */
         int valid;
 
@@ -108,10 +109,10 @@ static int smsc47b397_read_value(struct i2c_client *client, u8 reg)
         struct smsc47b397_data *data = i2c_get_clientdata(client);
         int res;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         outb(reg, client->addr);
         res = inb_p(client->addr + 1);
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return res;
 }
 
@@ -121,7 +122,7 @@ static struct smsc47b397_data *smsc47b397_update_device(struct device *dev)
         struct smsc47b397_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
                 dev_dbg(&client->dev, "starting device update...\n");
@@ -144,7 +145,7 @@ static struct smsc47b397_data *smsc47b397_update_device(struct device *dev)
                 dev_dbg(&client->dev, "... device update complete\n");
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
@@ -254,14 +255,14 @@ static int smsc47b397_detect(struct i2c_adapter *adapter)
         new_client = &data->client;
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         new_client->adapter = adapter;
         new_client->driver = &smsc47b397_driver;
         new_client->flags = 0;
 
         strlcpy(new_client->name, "smsc47b397", I2C_NAME_SIZE);
 
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         if ((err = i2c_attach_client(new_client)))
                 goto error_free;
diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.c
index d1e3ec0fe4df..7732aec54594 100644
--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -34,6 +34,7 @@
 #include <linux/hwmon.h>
 #include <linux/err.h>
 #include <linux/init.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 /* Address is autodetected, there is no default value */
@@ -102,9 +103,9 @@ superio_exit(void)
 struct smsc47m1_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         unsigned long last_updated;     /* In jiffies */
 
         u8 fan[2];              /* Register value */
@@ -188,18 +189,18 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct smsc47m1_data *data = i2c_get_clientdata(client);
         long rpmdiv, val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         rpmdiv = val * DIV_FROM_REG(data->fan_div[nr]);
 
         if (983040 > 192 * rpmdiv || 2 * rpmdiv > 983040) {
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
         data->fan_preload[nr] = 192 - ((983040 + rpmdiv / 2) / rpmdiv);
         smsc47m1_write_value(client, SMSC47M1_REG_FAN_PRELOAD(nr),
                              data->fan_preload[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -220,14 +221,14 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         if (new_div == old_div) /* No change */
                 return count;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         switch (new_div) {
         case 1: data->fan_div[nr] = 0; break;
         case 2: data->fan_div[nr] = 1; break;
         case 4: data->fan_div[nr] = 2; break;
         case 8: data->fan_div[nr] = 3; break;
         default:
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
@@ -241,7 +242,7 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         data->fan_preload[nr] = SENSORS_LIMIT(tmp, 0, 191);
         smsc47m1_write_value(client, SMSC47M1_REG_FAN_PRELOAD(nr),
                              data->fan_preload[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -257,12 +258,12 @@ static ssize_t set_pwm(struct device *dev, const char *buf,
         if (val < 0 || val > 255)
                 return -EINVAL;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[nr] &= 0x81; /* Preserve additional bits */
         data->pwm[nr] |= PWM_TO_REG(val);
         smsc47m1_write_value(client, SMSC47M1_REG_PWM(nr),
                              data->pwm[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -278,12 +279,12 @@ static ssize_t set_pwm_en(struct device *dev, const char *buf,
         if (val != 0 && val != 1)
                 return -EINVAL;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[nr] &= 0xFE; /* preserve the other bits */
         data->pwm[nr] |= !val;
         smsc47m1_write_value(client, SMSC47M1_REG_PWM(nr),
                              data->pwm[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
@@ -408,13 +409,13 @@ static int smsc47m1_detect(struct i2c_adapter *adapter)
         new_client = &data->client;
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         new_client->adapter = adapter;
         new_client->driver = &smsc47m1_driver;
         new_client->flags = 0;
 
         strlcpy(new_client->name, "smsc47m1", I2C_NAME_SIZE);
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* If no function is properly configured, there's no point in
            actually registering the chip. */
@@ -512,17 +513,17 @@ static int smsc47m1_read_value(struct i2c_client *client, u8 reg)
 {
         int res;
 
-        down(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
+        mutex_lock(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
         res = inb_p(client->addr + reg);
-        up(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
+        mutex_unlock(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
         return res;
 }
 
 static void smsc47m1_write_value(struct i2c_client *client, u8 reg, u8 value)
 {
-        down(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
+        mutex_lock(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
         outb_p(value, client->addr + reg);
-        up(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
+        mutex_unlock(&((struct smsc47m1_data *) i2c_get_clientdata(client))->lock);
 }
 
 static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
@@ -531,7 +532,7 @@ static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
         struct i2c_client *client = to_i2c_client(dev);
         struct smsc47m1_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2) || init) {
                 int i;
@@ -558,7 +559,7 @@ static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
                 data->last_updated = jiffies;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return data;
 }
 
diff --git a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c
index cb01848729b5..166298f1f190 100644
--- a/drivers/hwmon/via686a.c
+++ b/drivers/hwmon/via686a.c
@@ -39,6 +39,7 @@
 #include <linux/hwmon.h>
 #include <linux/err.h>
 #include <linux/init.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 
@@ -296,7 +297,7 @@ static inline long TEMP_FROM_REG10(u16 val)
 struct via686a_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -355,11 +356,11 @@ static ssize_t set_in_min(struct device *dev, const char *buf,
         struct via686a_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = IN_TO_REG(val, nr);
         via686a_write_value(client, VIA686A_REG_IN_MIN(nr),
                         data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_in_max(struct device *dev, const char *buf,
@@ -368,11 +369,11 @@ static ssize_t set_in_max(struct device *dev, const char *buf,
         struct via686a_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = IN_TO_REG(val, nr);
         via686a_write_value(client, VIA686A_REG_IN_MAX(nr),
                         data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_in_offset(offset)                                  \
@@ -432,11 +433,11 @@ static ssize_t set_temp_over(struct device *dev, const char *buf,
         struct via686a_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_over[nr] = TEMP_TO_REG(val);
         via686a_write_value(client, VIA686A_REG_TEMP_OVER[nr],
                             data->temp_over[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp_hyst(struct device *dev, const char *buf,
@@ -445,11 +446,11 @@ static ssize_t set_temp_hyst(struct device *dev, const char *buf,
         struct via686a_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_hyst[nr] = TEMP_TO_REG(val);
         via686a_write_value(client, VIA686A_REG_TEMP_HYST[nr],
                             data->temp_hyst[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 #define show_temp_offset(offset)                                        \
@@ -508,10 +509,10 @@ static ssize_t set_fan_min(struct device *dev, const char *buf,
         struct via686a_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         via686a_write_value(client, VIA686A_REG_FAN_MIN(nr+1), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_fan_div(struct device *dev, const char *buf,
@@ -521,12 +522,12 @@ static ssize_t set_fan_div(struct device *dev, const char *buf,
         int val = simple_strtol(buf, NULL, 10);
         int old;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         old = via686a_read_value(client, VIA686A_REG_FANDIV);
         data->fan_div[nr] = DIV_TO_REG(val);
         old = (old & 0x0f) | (data->fan_div[1] << 6) | (data->fan_div[0] << 4);
         via686a_write_value(client, VIA686A_REG_FANDIV, old);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -639,7 +640,7 @@ static int via686a_detect(struct i2c_adapter *adapter)
         strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
                 goto exit_free;
@@ -733,7 +734,7 @@ static struct via686a_data *via686a_update_device(struct device *dev)
         struct via686a_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -788,7 +789,7 @@ static struct via686a_data *via686a_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
index 271e9cb9532c..686f3deb3093 100644
--- a/drivers/hwmon/vt8231.c
+++ b/drivers/hwmon/vt8231.c
@@ -35,6 +35,7 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 
 static int force_addr;
@@ -148,7 +149,7 @@ static inline u8 FAN_TO_REG(long rpm, int div)
 
 struct vt8231_data {
         struct i2c_client client;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         struct class_device *class_dev;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
@@ -223,10 +224,10 @@ static ssize_t set_in_min(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[nr] = SENSORS_LIMIT(((val * 958) / 10000) + 3, 0, 255);
         vt8231_write_value(client, regvoltmin[nr], data->in_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -239,10 +240,10 @@ static ssize_t set_in_max(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[nr] = SENSORS_LIMIT(((val * 958) / 10000) + 3, 0, 255);
         vt8231_write_value(client, regvoltmax[nr], data->in_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -281,11 +282,11 @@ static ssize_t set_in5_min(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_min[5] = SENSORS_LIMIT(((val * 958 * 34) / (10000 * 54)) + 3,
                                         0, 255);
         vt8231_write_value(client, regvoltmin[5], data->in_min[5]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -296,11 +297,11 @@ static ssize_t set_in5_max(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->in_max[5] = SENSORS_LIMIT(((val * 958 * 34) / (10000 * 54)) + 3,
                                         0, 255);
         vt8231_write_value(client, regvoltmax[5], data->in_max[5]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -351,10 +352,10 @@ static ssize_t set_temp0_max(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[0] = SENSORS_LIMIT((val + 500) / 1000, 0, 255);
         vt8231_write_value(client, regtempmax[0], data->temp_max[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp0_min(struct device *dev, struct device_attribute *attr,
@@ -364,10 +365,10 @@ static ssize_t set_temp0_min(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[0] = SENSORS_LIMIT((val + 500) / 1000, 0, 255);
         vt8231_write_value(client, regtempmin[0], data->temp_min[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -407,10 +408,10 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_max[nr] = SENSORS_LIMIT(TEMP_MAXMIN_TO_REG(val), 0, 255);
         vt8231_write_value(client, regtempmax[nr], data->temp_max[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 static ssize_t set_temp_min(struct device *dev, struct device_attribute *attr,
@@ -422,10 +423,10 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         int val = simple_strtol(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->temp_min[nr] = SENSORS_LIMIT(TEMP_MAXMIN_TO_REG(val), 0, 255);
         vt8231_write_value(client, regtempmin[nr], data->temp_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -520,10 +521,10 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *attr,
         struct vt8231_data *data = i2c_get_clientdata(client);
         int val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
         vt8231_write_value(client, VT8231_REG_FAN_MIN(nr), data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -539,7 +540,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
         long min = FAN_FROM_REG(data->fan_min[nr],
                                  DIV_FROM_REG(data->fan_div[nr]));
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         switch (val) {
         case 1: data->fan_div[nr] = 0; break;
         case 2: data->fan_div[nr] = 1; break;
@@ -548,7 +549,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
         default:
                 dev_err(&client->dev, "fan_div value %ld not supported."
                         "Choose one of 1, 2, 4 or 8!\n", val);
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
@@ -558,7 +559,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
 
         old = (old & 0x0f) | (data->fan_div[1] << 6) | (data->fan_div[0] << 4);
         vt8231_write_value(client, VT8231_REG_FANDIV, old);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -660,7 +661,7 @@ int vt8231_detect(struct i2c_adapter *adapter)
         /* Fill in the remaining client fields and put into the global list */
         strlcpy(client->name, "vt8231", I2C_NAME_SIZE);
 
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(client)))
@@ -745,7 +746,7 @@ static struct vt8231_data *vt8231_update_device(struct device *dev)
         int i;
         u16 low;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -804,7 +805,7 @@ static struct vt8231_data *vt8231_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 12d79f5e4900..b6bd5685fd38 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -42,7 +42,9 @@
 #include <linux/i2c.h>
 #include <linux/i2c-isa.h>
 #include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 #include "lm75.h"
 
@@ -177,9 +179,9 @@ temp1_to_reg(int temp)
 struct w83627ehf_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -230,7 +232,7 @@ static u16 w83627ehf_read_value(struct i2c_client *client, u16 reg)
         struct w83627ehf_data *data = i2c_get_clientdata(client);
         int res, word_sized = is_word_sized(reg);
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
 
         w83627ehf_set_bank(client, reg);
         outb_p(reg & 0xff, client->addr + ADDR_REG_OFFSET);
@@ -242,7 +244,7 @@ static u16 w83627ehf_read_value(struct i2c_client *client, u16 reg)
         }
         w83627ehf_reset_bank(client, reg);
 
-        up(&data->lock);
+        mutex_unlock(&data->lock);
 
         return res;
 }
@@ -252,7 +254,7 @@ static int w83627ehf_write_value(struct i2c_client *client, u16 reg, u16 value)
         struct w83627ehf_data *data = i2c_get_clientdata(client);
         int word_sized = is_word_sized(reg);
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
 
         w83627ehf_set_bank(client, reg);
         outb_p(reg & 0xff, client->addr + ADDR_REG_OFFSET);
@@ -264,7 +266,7 @@ static int w83627ehf_write_value(struct i2c_client *client, u16 reg, u16 value)
         outb_p(value & 0xff, client->addr + DATA_REG_OFFSET);
         w83627ehf_reset_bank(client, reg);
 
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return 0;
 }
 
@@ -322,7 +324,7 @@ static struct w83627ehf_data *w83627ehf_update_device(struct device *dev)
         struct w83627ehf_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ)
          || !data->valid) {
@@ -397,7 +399,7 @@ static struct w83627ehf_data *w83627ehf_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return data;
 }
 
@@ -407,9 +409,12 @@ static struct w83627ehf_data *w83627ehf_update_device(struct device *dev)
 
 #define show_fan_reg(reg) \
 static ssize_t \
-show_##reg(struct device *dev, char *buf, int nr) \
+show_##reg(struct device *dev, struct device_attribute *attr, \
+           char *buf) \
 { \
         struct w83627ehf_data *data = w83627ehf_update_device(dev); \
+        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr); \
+        int nr = sensor_attr->index; \
         return sprintf(buf, "%d\n", \
                        fan_from_reg(data->reg[nr], \
                                     div_from_reg(data->fan_div[nr]))); \
@@ -418,23 +423,28 @@ show_fan_reg(fan);
 show_fan_reg(fan_min);
 
 static ssize_t
-show_fan_div(struct device *dev, char *buf, int nr)
+show_fan_div(struct device *dev, struct device_attribute *attr,
+             char *buf)
 {
         struct w83627ehf_data *data = w83627ehf_update_device(dev);
-        return sprintf(buf, "%u\n",
-                       div_from_reg(data->fan_div[nr]));
+        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
+        int nr = sensor_attr->index;
+        return sprintf(buf, "%u\n", div_from_reg(data->fan_div[nr]));
 }
 
 static ssize_t
-store_fan_min(struct device *dev, const char *buf, size_t count, int nr)
+store_fan_min(struct device *dev, struct device_attribute *attr,
+              const char *buf, size_t count)
 {
         struct i2c_client *client = to_i2c_client(dev);
         struct w83627ehf_data *data = i2c_get_clientdata(client);
+        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
+        int nr = sensor_attr->index;
         unsigned int val = simple_strtoul(buf, NULL, 10);
         unsigned int reg;
         u8 new_div;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (!val) {
                 /* No min limit, alarm disabled */
                 data->fan_min[nr] = 255;
@@ -482,63 +492,46 @@ store_fan_min(struct device *dev, const char *buf, size_t count, int nr)
         }
         w83627ehf_write_value(client, W83627EHF_REG_FAN_MIN[nr],
                               data->fan_min[nr]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return count;
 }
 
-#define sysfs_fan_offset(offset) \
-static ssize_t \
-show_reg_fan_##offset(struct device *dev, struct device_attribute *attr, \
-                      char *buf) \
-{ \
-        return show_fan(dev, buf, offset-1); \
-} \
-static DEVICE_ATTR(fan##offset##_input, S_IRUGO, \
-                   show_reg_fan_##offset, NULL);
+static struct sensor_device_attribute sda_fan_input[] = {
+        SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0),
+        SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 1),
+        SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 2),
+        SENSOR_ATTR(fan4_input, S_IRUGO, show_fan, NULL, 3),
+        SENSOR_ATTR(fan5_input, S_IRUGO, show_fan, NULL, 4),
+};
 
-#define sysfs_fan_min_offset(offset) \
-static ssize_t \
-show_reg_fan##offset##_min(struct device *dev, struct device_attribute *attr, \
-                           char *buf) \
-{ \
-        return show_fan_min(dev, buf, offset-1); \
-} \
-static ssize_t \
-store_reg_fan##offset##_min(struct device *dev, struct device_attribute *attr, \
-                            const char *buf, size_t count) \
-{ \
-        return store_fan_min(dev, buf, count, offset-1); \
-} \
-static DEVICE_ATTR(fan##offset##_min, S_IRUGO | S_IWUSR, \
-                   show_reg_fan##offset##_min, \
-                   store_reg_fan##offset##_min);
+static struct sensor_device_attribute sda_fan_min[] = {
+        SENSOR_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan_min,
+                    store_fan_min, 0),
+        SENSOR_ATTR(fan2_min, S_IWUSR | S_IRUGO, show_fan_min,
+                    store_fan_min, 1),
+        SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min,
+                    store_fan_min, 2),
+        SENSOR_ATTR(fan4_min, S_IWUSR | S_IRUGO, show_fan_min,
+                    store_fan_min, 3),
+        SENSOR_ATTR(fan5_min, S_IWUSR | S_IRUGO, show_fan_min,
+                    store_fan_min, 4),
+};
 
-#define sysfs_fan_div_offset(offset) \
-static ssize_t \
-show_reg_fan##offset##_div(struct device *dev, struct device_attribute *attr, \
-                           char *buf) \
-{ \
-        return show_fan_div(dev, buf, offset - 1); \
-} \
-static DEVICE_ATTR(fan##offset##_div, S_IRUGO, \
-                   show_reg_fan##offset##_div, NULL);
-
-sysfs_fan_offset(1);
-sysfs_fan_min_offset(1);
-sysfs_fan_div_offset(1);
-sysfs_fan_offset(2);
-sysfs_fan_min_offset(2);
-sysfs_fan_div_offset(2);
-sysfs_fan_offset(3);
-sysfs_fan_min_offset(3);
-sysfs_fan_div_offset(3);
-sysfs_fan_offset(4);
-sysfs_fan_min_offset(4);
-sysfs_fan_div_offset(4);
-sysfs_fan_offset(5);
-sysfs_fan_min_offset(5);
-sysfs_fan_div_offset(5);
+static struct sensor_device_attribute sda_fan_div[] = {
+        SENSOR_ATTR(fan1_div, S_IRUGO, show_fan_div, NULL, 0),
+        SENSOR_ATTR(fan2_div, S_IRUGO, show_fan_div, NULL, 1),
+        SENSOR_ATTR(fan3_div, S_IRUGO, show_fan_div, NULL, 2),
+        SENSOR_ATTR(fan4_div, S_IRUGO, show_fan_div, NULL, 3),
+        SENSOR_ATTR(fan5_div, S_IRUGO, show_fan_div, NULL, 4),
+};
+
+static void device_create_file_fan(struct device *dev, int i)
+{
+        device_create_file(dev, &sda_fan_input[i].dev_attr);
+        device_create_file(dev, &sda_fan_div[i].dev_attr);
+        device_create_file(dev, &sda_fan_min[i].dev_attr);
+}
 
 #define show_temp1_reg(reg) \
 static ssize_t \
@@ -561,27 +554,24 @@ store_temp1_##reg(struct device *dev, struct device_attribute *attr, \
         struct w83627ehf_data *data = i2c_get_clientdata(client); \
         u32 val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->temp1_##reg = temp1_to_reg(val); \
         w83627ehf_write_value(client, W83627EHF_REG_TEMP1_##REG, \
                               data->temp1_##reg); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_temp1_reg(OVER, max);
 store_temp1_reg(HYST, max_hyst);
 
-static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp1, NULL);
-static DEVICE_ATTR(temp1_max, S_IRUGO| S_IWUSR,
-                   show_temp1_max, store_temp1_max);
-static DEVICE_ATTR(temp1_max_hyst, S_IRUGO| S_IWUSR,
-                   show_temp1_max_hyst, store_temp1_max_hyst);
-
 #define show_temp_reg(reg) \
 static ssize_t \
-show_##reg (struct device *dev, char *buf, int nr) \
+show_##reg(struct device *dev, struct device_attribute *attr, \
+           char *buf) \
 { \
         struct w83627ehf_data *data = w83627ehf_update_device(dev); \
+        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr); \
+        int nr = sensor_attr->index; \
         return sprintf(buf, "%d\n", \
                        LM75_TEMP_FROM_REG(data->reg[nr])); \
 }
@@ -591,55 +581,42 @@ show_temp_reg(temp_max_hyst);
 
 #define store_temp_reg(REG, reg) \
 static ssize_t \
-store_##reg (struct device *dev, const char *buf, size_t count, int nr) \
+store_##reg(struct device *dev, struct device_attribute *attr, \
+            const char *buf, size_t count) \
 { \
         struct i2c_client *client = to_i2c_client(dev); \
         struct w83627ehf_data *data = i2c_get_clientdata(client); \
+        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr); \
+        int nr = sensor_attr->index; \
         u32 val = simple_strtoul(buf, NULL, 10); \
  \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->reg[nr] = LM75_TEMP_TO_REG(val); \
         w83627ehf_write_value(client, W83627EHF_REG_TEMP_##REG[nr], \
                               data->reg[nr]); \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_temp_reg(OVER, temp_max);
 store_temp_reg(HYST, temp_max_hyst);
 
-#define sysfs_temp_offset(offset) \
-static ssize_t \
-show_reg_temp##offset (struct device *dev, struct device_attribute *attr, \
-                       char *buf) \
-{ \
-        return show_temp(dev, buf, offset - 2); \
-} \
-static DEVICE_ATTR(temp##offset##_input, S_IRUGO, \
-                   show_reg_temp##offset, NULL);
-
-#define sysfs_temp_reg_offset(reg, offset) \
-static ssize_t \
-show_reg_temp##offset##_##reg(struct device *dev, struct device_attribute *attr, \
-                              char *buf) \
-{ \
-        return show_temp_##reg(dev, buf, offset - 2); \
-} \
-static ssize_t \
-store_reg_temp##offset##_##reg(struct device *dev, struct device_attribute *attr, \
-                               const char *buf, size_t count) \
-{ \
-        return store_temp_##reg(dev, buf, count, offset - 2); \
-} \
-static DEVICE_ATTR(temp##offset##_##reg, S_IRUGO| S_IWUSR, \
-                   show_reg_temp##offset##_##reg, \
-                   store_reg_temp##offset##_##reg);
-
-sysfs_temp_offset(2);
-sysfs_temp_reg_offset(max, 2);
-sysfs_temp_reg_offset(max_hyst, 2);
-sysfs_temp_offset(3);
-sysfs_temp_reg_offset(max, 3);
-sysfs_temp_reg_offset(max_hyst, 3);
+static struct sensor_device_attribute sda_temp[] = {
+        SENSOR_ATTR(temp1_input, S_IRUGO, show_temp1, NULL, 0),
+        SENSOR_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 0),
+        SENSOR_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 1),
+        SENSOR_ATTR(temp1_max, S_IRUGO | S_IWUSR, show_temp1_max,
+                    store_temp1_max, 0),
+        SENSOR_ATTR(temp2_max, S_IRUGO | S_IWUSR, show_temp_max,
+                    store_temp_max, 0),
+        SENSOR_ATTR(temp3_max, S_IRUGO | S_IWUSR, show_temp_max,
+                    store_temp_max, 1),
+        SENSOR_ATTR(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1_max_hyst,
+                    store_temp1_max_hyst, 0),
+        SENSOR_ATTR(temp2_max_hyst, S_IRUGO | S_IWUSR, show_temp_max_hyst,
+                    store_temp_max_hyst, 0),
+        SENSOR_ATTR(temp3_max_hyst, S_IRUGO | S_IWUSR, show_temp_max_hyst,
+                    store_temp_max_hyst, 1),
+};
 
 /*
  * Driver and client management
@@ -673,6 +650,7 @@ static int w83627ehf_detect(struct i2c_adapter *adapter)
 {
         struct i2c_client *client;
         struct w83627ehf_data *data;
+        struct device *dev;
         int i, err = 0;
 
         if (!request_region(address + REGION_OFFSET, REGION_LENGTH,
@@ -689,14 +667,15 @@ static int w83627ehf_detect(struct i2c_adapter *adapter)
         client = &data->client;
         i2c_set_clientdata(client, data);
         client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         client->adapter = adapter;
         client->driver = &w83627ehf_driver;
         client->flags = 0;
+        dev = &client->dev;
 
         strlcpy(client->name, "w83627ehf", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the i2c layer a new client has arrived */
         if ((err = i2c_attach_client(client)))
@@ -720,42 +699,18 @@ static int w83627ehf_detect(struct i2c_adapter *adapter)
                 data->has_fan |= (1 << 4);
 
         /* Register sysfs hooks */
-        data->class_dev = hwmon_device_register(&client->dev);
+        data->class_dev = hwmon_device_register(dev);
         if (IS_ERR(data->class_dev)) {
                 err = PTR_ERR(data->class_dev);
                 goto exit_detach;
         }
 
-        device_create_file(&client->dev, &dev_attr_fan1_input);
-        device_create_file(&client->dev, &dev_attr_fan1_min);
-        device_create_file(&client->dev, &dev_attr_fan1_div);
-        device_create_file(&client->dev, &dev_attr_fan2_input);
-        device_create_file(&client->dev, &dev_attr_fan2_min);
-        device_create_file(&client->dev, &dev_attr_fan2_div);
-        device_create_file(&client->dev, &dev_attr_fan3_input);
-        device_create_file(&client->dev, &dev_attr_fan3_min);
-        device_create_file(&client->dev, &dev_attr_fan3_div);
-
-        if (data->has_fan & (1 << 3)) {
-                device_create_file(&client->dev, &dev_attr_fan4_input);
-                device_create_file(&client->dev, &dev_attr_fan4_min);
-                device_create_file(&client->dev, &dev_attr_fan4_div);
-        }
-        if (data->has_fan & (1 << 4)) {
-                device_create_file(&client->dev, &dev_attr_fan5_input);
-                device_create_file(&client->dev, &dev_attr_fan5_min);
-                device_create_file(&client->dev, &dev_attr_fan5_div);
+        for (i = 0; i < 5; i++) {
+                if (data->has_fan & (1 << i))
+                        device_create_file_fan(dev, i);
         }
-
-        device_create_file(&client->dev, &dev_attr_temp1_input);
-        device_create_file(&client->dev, &dev_attr_temp1_max);
-        device_create_file(&client->dev, &dev_attr_temp1_max_hyst);
-        device_create_file(&client->dev, &dev_attr_temp2_input);
-        device_create_file(&client->dev, &dev_attr_temp2_max);
-        device_create_file(&client->dev, &dev_attr_temp2_max_hyst);
-        device_create_file(&client->dev, &dev_attr_temp3_input);
-        device_create_file(&client->dev, &dev_attr_temp3_max);
-        device_create_file(&client->dev, &dev_attr_temp3_max_hyst);
+        for (i = 0; i < ARRAY_SIZE(sda_temp); i++)
+                device_create_file(dev, &sda_temp[i].dev_attr);
 
         return 0;
 
diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
index 7ea441d4da63..71fb7f1af8f5 100644
--- a/drivers/hwmon/w83627hf.c
+++ b/drivers/hwmon/w83627hf.c
@@ -28,6 +28,7 @@
     w83627hf    9       3       2       3       0x20    0x5ca3  no      yes(LPC)
     w83627thf   7       3       3       3       0x90    0x5ca3  no      yes(LPC)
     w83637hf    7       3       3       3       0x80    0x5ca3  no      yes(LPC)
+    w83687thf   7       3       3       3       0x90    0x5ca3  no      yes(LPC)
     w83697hf    8       2       2       2       0x60    0x5ca3  no      yes(LPC)
 
     For other winbond chips, and for i2c support in the above chips,
@@ -46,6 +47,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 #include "lm75.h"
 
@@ -62,7 +64,7 @@ MODULE_PARM_DESC(force_i2c,
 static unsigned short address;
 
 /* Insmod parameters */
-enum chips { any_chip, w83627hf, w83627thf, w83697hf, w83637hf };
+enum chips { any_chip, w83627hf, w83627thf, w83697hf, w83637hf, w83687thf };
 
 static int reset;
 module_param(reset, bool, 0);
@@ -100,6 +102,10 @@ static int VAL;		/* The value to read/write */
 #define W83627THF_GPIO5_IOSR    0xf3 /* w83627thf only */
 #define W83627THF_GPIO5_DR      0xf4 /* w83627thf only */
 
+#define W83687THF_VID_EN        0x29 /* w83687thf only */
+#define W83687THF_VID_CFG       0xF0 /* w83687thf only */
+#define W83687THF_VID_DATA      0xF1 /* w83687thf only */
+
 static inline void
 superio_outb(int reg, int val)
 {
@@ -138,6 +144,7 @@ superio_exit(void)
 #define W627THF_DEVID 0x82
 #define W697_DEVID 0x60
 #define W637_DEVID 0x70
+#define W687THF_DEVID 0x85
 #define WINB_ACT_REG 0x30
 #define WINB_BASE_REG 0x60
 /* Constants specified below */
@@ -201,11 +208,11 @@ superio_exit(void)
 #define W83627HF_REG_PWM1 0x5A
 #define W83627HF_REG_PWM2 0x5B
 
-#define W83627THF_REG_PWM1              0x01    /* 697HF and 637HF too */
-#define W83627THF_REG_PWM2              0x03    /* 697HF and 637HF too */
-#define W83627THF_REG_PWM3              0x11    /* 637HF too */
+#define W83627THF_REG_PWM1              0x01    /* 697HF/637HF/687THF too */
+#define W83627THF_REG_PWM2              0x03    /* 697HF/637HF/687THF too */
+#define W83627THF_REG_PWM3              0x11    /* 637HF/687THF too */
 
-#define W83627THF_REG_VRM_OVT_CFG       0x18    /* 637HF too */
+#define W83627THF_REG_VRM_OVT_CFG       0x18    /* 637HF/687THF too */
 
 static const u8 regpwm_627hf[] = { W83627HF_REG_PWM1, W83627HF_REG_PWM2 };
 static const u8 regpwm[] = { W83627THF_REG_PWM1, W83627THF_REG_PWM2,
@@ -285,10 +292,10 @@ static inline u8 DIV_TO_REG(long val)
 struct w83627hf_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -318,16 +325,15 @@ struct w83627hf_data {
                                    Default = 3435.
                                    Other Betas unimplemented */
         u8 vrm;
-        u8 vrm_ovt;             /* Register value, 627thf & 637hf only */
+        u8 vrm_ovt;             /* Register value, 627THF/637HF/687THF only */
 };
 
 
 static int w83627hf_detect(struct i2c_adapter *adapter);
 static int w83627hf_detach_client(struct i2c_client *client);
 
-static int w83627hf_read_value(struct i2c_client *client, u16 register);
-static int w83627hf_write_value(struct i2c_client *client, u16 register,
-                               u16 value);
+static int w83627hf_read_value(struct i2c_client *client, u16 reg);
+static int w83627hf_write_value(struct i2c_client *client, u16 reg, u16 value);
 static struct w83627hf_data *w83627hf_update_device(struct device *dev);
 static void w83627hf_init_client(struct i2c_client *client);
 
@@ -360,12 +366,12 @@ store_in_##reg (struct device *dev, const char *buf, size_t count, int nr) \
          \
         val = simple_strtoul(buf, NULL, 10); \
          \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->in_##reg[nr] = IN_TO_REG(val); \
         w83627hf_write_value(client, W83781D_REG_IN_##REG(nr), \
                             data->in_##reg[nr]); \
          \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_in_reg(MIN, min)
@@ -413,7 +419,8 @@ static ssize_t show_in_0(struct w83627hf_data *data, char *buf, u8 reg)
         long in0;
 
         if ((data->vrm_ovt & 0x01) &&
-                (w83627thf == data->type || w83637hf == data->type))
+                (w83627thf == data->type || w83637hf == data->type
+                 || w83687thf == data->type))
 
                 /* use VRM9 calculation */
                 in0 = (long)((reg * 488 + 70000 + 50) / 100);
@@ -451,10 +458,11 @@ static ssize_t store_regs_in_min0(struct device *dev, struct device_attribute *a
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         
         if ((data->vrm_ovt & 0x01) &&
-                (w83627thf == data->type || w83637hf == data->type))
+                (w83627thf == data->type || w83637hf == data->type
+                 || w83687thf == data->type))
 
                 /* use VRM9 calculation */
                 data->in_min[0] =
@@ -465,7 +473,7 @@ static ssize_t store_regs_in_min0(struct device *dev, struct device_attribute *a
                 data->in_min[0] = IN_TO_REG(val);
 
         w83627hf_write_value(client, W83781D_REG_IN_MIN(0), data->in_min[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -478,10 +486,11 @@ static ssize_t store_regs_in_max0(struct device *dev, struct device_attribute *a
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if ((data->vrm_ovt & 0x01) &&
-                (w83627thf == data->type || w83637hf == data->type))
+                (w83627thf == data->type || w83637hf == data->type
+                 || w83687thf == data->type))
                 
                 /* use VRM9 calculation */
                 data->in_max[0] =
@@ -492,7 +501,7 @@ static ssize_t store_regs_in_max0(struct device *dev, struct device_attribute *a
                 data->in_max[0] = IN_TO_REG(val);
 
         w83627hf_write_value(client, W83781D_REG_IN_MAX(0), data->in_max[0]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -529,13 +538,13 @@ store_fan_min(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr - 1] =
             FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr - 1]));
         w83627hf_write_value(client, W83781D_REG_FAN_MIN(nr),
                             data->fan_min[nr - 1]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -597,7 +606,7 @@ store_temp_##reg (struct device *dev, const char *buf, size_t count, int nr) \
          \
         val = simple_strtoul(buf, NULL, 10); \
          \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
          \
         if (nr >= 2) {  /* TEMP2 and TEMP3 */ \
                 data->temp_##reg##_add[nr-2] = LM75_TEMP_TO_REG(val); \
@@ -609,7 +618,7 @@ store_temp_##reg (struct device *dev, const char *buf, size_t count, int nr) \
                         data->temp_##reg); \
         } \
          \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_temp_reg(OVER, max);
@@ -718,7 +727,7 @@ store_beep_reg(struct device *dev, const char *buf, size_t count,
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (update_mask == BEEP_MASK) { /* We are storing beep_mask */
                 data->beep_mask = BEEP_MASK_TO_REG(val);
@@ -736,7 +745,7 @@ store_beep_reg(struct device *dev, const char *buf, size_t count,
         w83627hf_write_value(client, W83781D_REG_BEEP_INTS2,
                             val2 | data->beep_enable << 7);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -783,7 +792,7 @@ store_fan_div_reg(struct device *dev, const char *buf, size_t count, int nr)
         u8 reg;
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         /* Save fan_min */
         min = FAN_FROM_REG(data->fan_min[nr],
@@ -805,7 +814,7 @@ store_fan_div_reg(struct device *dev, const char *buf, size_t count, int nr)
         data->fan_min[nr] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         w83627hf_write_value(client, W83781D_REG_FAN_MIN(nr+1), data->fan_min[nr]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -848,7 +857,7 @@ store_pwm_reg(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (data->type == w83627thf) {
                 /* bits 0-3 are reserved  in 627THF */
@@ -865,7 +874,7 @@ store_pwm_reg(struct device *dev, const char *buf, size_t count, int nr)
                                      data->pwm[nr - 1]);
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -907,7 +916,7 @@ store_sensor_reg(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         switch (val) {
         case 1:         /* PII/Celeron diode */
@@ -941,7 +950,7 @@ store_sensor_reg(struct device *dev, const char *buf, size_t count, int nr)
                 break;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -980,7 +989,8 @@ static int __init w83627hf_find(int sioaddr, unsigned short *addr)
         if(val != W627_DEVID &&
            val != W627THF_DEVID &&
            val != W697_DEVID &&
-           val != W637_DEVID) {
+           val != W637_DEVID &&
+           val != W687THF_DEVID) {
                 superio_exit();
                 return -ENODEV;
         }
@@ -1034,6 +1044,8 @@ static int w83627hf_detect(struct i2c_adapter *adapter)
                 kind = w83627thf;
         else if(val == W637_DEVID)
                 kind = w83637hf;
+        else if (val == W687THF_DEVID)
+                kind = w83687thf;
         else {
                 dev_info(&adapter->dev,
                          "Unsupported chip (dev_id=0x%02X).\n", val);
@@ -1057,7 +1069,7 @@ static int w83627hf_detect(struct i2c_adapter *adapter)
         new_client = &data->client;
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         new_client->adapter = adapter;
         new_client->driver = &w83627hf_driver;
         new_client->flags = 0;
@@ -1071,13 +1083,15 @@ static int w83627hf_detect(struct i2c_adapter *adapter)
                 client_name = "w83697hf";
         } else if (kind == w83637hf) {
                 client_name = "w83637hf";
+        } else if (kind == w83687thf) {
+                client_name = "w83687thf";
         }
 
         /* Fill in the remaining client fields and put into the global list */
         strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
         data->type = kind;
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -1106,7 +1120,7 @@ static int w83627hf_detect(struct i2c_adapter *adapter)
         device_create_file_in(new_client, 2);
         device_create_file_in(new_client, 3);
         device_create_file_in(new_client, 4);
-        if (kind != w83627thf && kind != w83637hf) {
+        if (kind == w83627hf || kind == w83697hf) {
                 device_create_file_in(new_client, 5);
                 device_create_file_in(new_client, 6);
         }
@@ -1139,7 +1153,7 @@ static int w83627hf_detect(struct i2c_adapter *adapter)
 
         device_create_file_pwm(new_client, 1);
         device_create_file_pwm(new_client, 2);
-        if (kind == w83627thf || kind == w83637hf)
+        if (kind == w83627thf || kind == w83637hf || kind == w83687thf)
                 device_create_file_pwm(new_client, 3);
 
         device_create_file_sensor(new_client, 1);
@@ -1187,7 +1201,7 @@ static int w83627hf_read_value(struct i2c_client *client, u16 reg)
         struct w83627hf_data *data = i2c_get_clientdata(client);
         int res, word_sized;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         word_sized = (((reg & 0xff00) == 0x100)
                    || ((reg & 0xff00) == 0x200))
                   && (((reg & 0x00ff) == 0x50)
@@ -1213,7 +1227,7 @@ static int w83627hf_read_value(struct i2c_client *client, u16 reg)
                        client->addr + W83781D_ADDR_REG_OFFSET);
                 outb_p(0, client->addr + W83781D_DATA_REG_OFFSET);
         }
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return res;
 }
 
@@ -1247,12 +1261,39 @@ exit:
         return res;
 }
 
+static int w83687thf_read_vid(struct i2c_client *client)
+{
+        int res = 0xff;
+
+        superio_enter();
+        superio_select(W83627HF_LD_HWM);
+
+        /* Make sure these GPIO pins are enabled */
+        if (!(superio_inb(W83687THF_VID_EN) & (1 << 2))) {
+                dev_dbg(&client->dev, "VID disabled, no VID function\n");
+                goto exit;
+        }
+
+        /* Make sure the pins are configured for input */
+        if (!(superio_inb(W83687THF_VID_CFG) & (1 << 4))) {
+                dev_dbg(&client->dev, "VID configured as output, "
+                        "no VID function\n");
+                goto exit;
+        }
+
+        res = superio_inb(W83687THF_VID_DATA) & 0x3f;
+
+exit:
+        superio_exit();
+        return res;
+}
+
 static int w83627hf_write_value(struct i2c_client *client, u16 reg, u16 value)
 {
         struct w83627hf_data *data = i2c_get_clientdata(client);
         int word_sized;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         word_sized = (((reg & 0xff00) == 0x100)
                    || ((reg & 0xff00) == 0x200))
                   && (((reg & 0x00ff) == 0x53)
@@ -1277,7 +1318,7 @@ static int w83627hf_write_value(struct i2c_client *client, u16 reg, u16 value)
                        client->addr + W83781D_ADDR_REG_OFFSET);
                 outb_p(0, client->addr + W83781D_DATA_REG_OFFSET);
         }
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return 0;
 }
 
@@ -1324,10 +1365,13 @@ static void w83627hf_init_client(struct i2c_client *client)
                 data->vid = (lo & 0x0f) | ((hi & 0x01) << 4);
         } else if (w83627thf == data->type) {
                 data->vid = w83627thf_read_gpio5(client);
+        } else if (w83687thf == data->type) {
+                data->vid = w83687thf_read_vid(client);
         }
 
         /* Read VRM & OVT Config only once */
-        if (w83627thf == data->type || w83637hf == data->type) {
+        if (w83627thf == data->type || w83637hf == data->type
+         || w83687thf == data->type) {
                 data->vrm_ovt = 
                         w83627hf_read_value(client, W83627THF_REG_VRM_OVT_CFG);
         }
@@ -1387,14 +1431,14 @@ static struct w83627hf_data *w83627hf_update_device(struct device *dev)
         struct w83627hf_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
                 for (i = 0; i <= 8; i++) {
                         /* skip missing sensors */
                         if (((data->type == w83697hf) && (i == 1)) ||
-                            ((data->type == w83627thf || data->type == w83637hf)
+                            ((data->type != w83627hf && data->type != w83697hf)
                             && (i == 5 || i == 6)))
                                 continue;
                         data->in[i] =
@@ -1470,7 +1514,7 @@ static struct w83627hf_data *w83627hf_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c
index 64c1f8af5bb2..e4c700356c44 100644
--- a/drivers/hwmon/w83781d.c
+++ b/drivers/hwmon/w83781d.c
@@ -42,6 +42,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-vid.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 #include "lm75.h"
 
@@ -56,6 +57,10 @@ I2C_CLIENT_INSMOD_5(w83781d, w83782d, w83783s, w83627hf, as99127f);
 I2C_CLIENT_MODULE_PARM(force_subclients, "List of subclient addresses: "
                     "{bus, clientaddr, subclientaddr1, subclientaddr2}");
 
+static int reset;
+module_param(reset, bool, 0);
+MODULE_PARM_DESC(reset, "Set to one to reset chip on load");
+
 static int init = 1;
 module_param(init, bool, 0);
 MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization");
@@ -226,10 +231,10 @@ DIV_TO_REG(long val, enum chips type)
 struct w83781d_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore lock;
+        struct mutex lock;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -267,9 +272,8 @@ static int w83781d_isa_attach_adapter(struct i2c_adapter *adapter);
 static int w83781d_detect(struct i2c_adapter *adapter, int address, int kind);
 static int w83781d_detach_client(struct i2c_client *client);
 
-static int w83781d_read_value(struct i2c_client *client, u16 register);
-static int w83781d_write_value(struct i2c_client *client, u16 register,
-                               u16 value);
+static int w83781d_read_value(struct i2c_client *client, u16 reg);
+static int w83781d_write_value(struct i2c_client *client, u16 reg, u16 value);
 static struct w83781d_data *w83781d_update_device(struct device *dev);
 static void w83781d_init_client(struct i2c_client *client);
 
@@ -311,11 +315,11 @@ static ssize_t store_in_##reg (struct device *dev, const char *buf, size_t count
          \
         val = simple_strtoul(buf, NULL, 10) / 10; \
          \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
         data->in_##reg[nr] = IN_TO_REG(val); \
         w83781d_write_value(client, W83781D_REG_IN_##REG(nr), data->in_##reg[nr]); \
          \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_in_reg(MIN, min);
@@ -381,13 +385,13 @@ store_fan_min(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->fan_min[nr - 1] =
             FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr - 1]));
         w83781d_write_value(client, W83781D_REG_FAN_MIN(nr),
                             data->fan_min[nr - 1]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -446,7 +450,7 @@ static ssize_t store_temp_##reg (struct device *dev, const char *buf, size_t cou
          \
         val = simple_strtol(buf, NULL, 10); \
          \
-        down(&data->update_lock); \
+        mutex_lock(&data->update_lock); \
          \
         if (nr >= 2) {  /* TEMP2 and TEMP3 */ \
                 data->temp_##reg##_add[nr-2] = LM75_TEMP_TO_REG(val); \
@@ -458,7 +462,7 @@ static ssize_t store_temp_##reg (struct device *dev, const char *buf, size_t cou
                         data->temp_##reg); \
         } \
          \
-        up(&data->update_lock); \
+        mutex_unlock(&data->update_lock); \
         return count; \
 }
 store_temp_reg(OVER, max);
@@ -571,7 +575,7 @@ store_beep_reg(struct device *dev, const char *buf, size_t count,
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (update_mask == BEEP_MASK) { /* We are storing beep_mask */
                 data->beep_mask = BEEP_MASK_TO_REG(val, data->type);
@@ -592,7 +596,7 @@ store_beep_reg(struct device *dev, const char *buf, size_t count,
         w83781d_write_value(client, W83781D_REG_BEEP_INTS2,
                             val2 | data->beep_enable << 7);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -637,7 +641,7 @@ store_fan_div_reg(struct device *dev, const char *buf, size_t count, int nr)
         u8 reg;
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         
         /* Save fan_min */
         min = FAN_FROM_REG(data->fan_min[nr],
@@ -662,7 +666,7 @@ store_fan_div_reg(struct device *dev, const char *buf, size_t count, int nr)
         data->fan_min[nr] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
         w83781d_write_value(client, W83781D_REG_FAN_MIN(nr+1), data->fan_min[nr]);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -709,10 +713,10 @@ store_pwm_reg(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         data->pwm[nr - 1] = PWM_TO_REG(val);
         w83781d_write_value(client, W83781D_REG_PWM(nr), data->pwm[nr - 1]);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -725,7 +729,7 @@ store_pwmenable_reg(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         switch (val) {
         case 0:
@@ -742,11 +746,11 @@ store_pwmenable_reg(struct device *dev, const char *buf, size_t count, int nr)
                 break;
 
         default:
-                up(&data->update_lock);
+                mutex_unlock(&data->update_lock);
                 return -EINVAL;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -808,7 +812,7 @@ store_sensor_reg(struct device *dev, const char *buf, size_t count, int nr)
 
         val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         switch (val) {
         case 1:         /* PII/Celeron diode */
@@ -841,7 +845,7 @@ store_sensor_reg(struct device *dev, const char *buf, size_t count, int nr)
                 break;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -1073,7 +1077,7 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
         new_client = &data->client;
         i2c_set_clientdata(new_client, data);
         new_client->addr = address;
-        init_MUTEX(&data->lock);
+        mutex_init(&data->lock);
         new_client->adapter = adapter;
         new_client->driver = is_isa ? &w83781d_isa_driver : &w83781d_driver;
         new_client->flags = 0;
@@ -1178,7 +1182,7 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
         data->type = kind;
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -1325,7 +1329,7 @@ w83781d_read_value(struct i2c_client *client, u16 reg)
         int res, word_sized, bank;
         struct i2c_client *cl;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         if (i2c_is_isa_client(client)) {
                 word_sized = (((reg & 0xff00) == 0x100)
                               || ((reg & 0xff00) == 0x200))
@@ -1383,7 +1387,7 @@ w83781d_read_value(struct i2c_client *client, u16 reg)
                 if (bank > 2)
                         i2c_smbus_write_byte_data(client, W83781D_REG_BANK, 0);
         }
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return res;
 }
 
@@ -1394,7 +1398,7 @@ w83781d_write_value(struct i2c_client *client, u16 reg, u16 value)
         int word_sized, bank;
         struct i2c_client *cl;
 
-        down(&data->lock);
+        mutex_lock(&data->lock);
         if (i2c_is_isa_client(client)) {
                 word_sized = (((reg & 0xff00) == 0x100)
                               || ((reg & 0xff00) == 0x200))
@@ -1447,7 +1451,7 @@ w83781d_write_value(struct i2c_client *client, u16 reg, u16 value)
                 if (bank > 2)
                         i2c_smbus_write_byte_data(client, W83781D_REG_BANK, 0);
         }
-        up(&data->lock);
+        mutex_unlock(&data->lock);
         return 0;
 }
 
@@ -1459,8 +1463,17 @@ w83781d_init_client(struct i2c_client *client)
         int type = data->type;
         u8 tmp;
 
-        if (init && type != as99127f) { /* this resets registers we don't have
+        if (reset && type != as99127f) { /* this resets registers we don't have
                                            documentation for on the as99127f */
+                /* Resetting the chip has been the default for a long time,
+                   but it causes the BIOS initializations (fan clock dividers,
+                   thermal sensor types...) to be lost, so it is now optional.
+                   It might even go away if nobody reports it as being useful,
+                   as I see very little reason why this would be needed at
+                   all. */
+                dev_info(&client->dev, "If reset=1 solved a problem you were "
+                         "having, please report!\n");
+
                 /* save these registers */
                 i = w83781d_read_value(client, W83781D_REG_BEEP_CONFIG);
                 p = w83781d_read_value(client, W83781D_REG_PWMCLK12);
@@ -1477,6 +1490,13 @@ w83781d_init_client(struct i2c_client *client)
                 w83781d_write_value(client, W83781D_REG_BEEP_INTS2, 0);
         }
 
+        /* Disable power-on abnormal beep, as advised by the datasheet.
+           Already done if reset=1. */
+        if (init && !reset && type != as99127f) {
+                i = w83781d_read_value(client, W83781D_REG_BEEP_CONFIG);
+                w83781d_write_value(client, W83781D_REG_BEEP_CONFIG, i | 0x80);
+        }
+
         data->vrm = vid_which_vrm();
 
         if ((type != w83781d) && (type != as99127f)) {
@@ -1533,7 +1553,7 @@ static struct w83781d_data *w83781d_update_device(struct device *dev)
         struct w83781d_data *data = i2c_get_clientdata(client);
         int i;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
             || !data->valid) {
@@ -1641,7 +1661,7 @@ static struct w83781d_data *w83781d_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/hwmon/w83792d.c b/drivers/hwmon/w83792d.c
index a2f6bb676235..6865c64d8a51 100644
--- a/drivers/hwmon/w83792d.c
+++ b/drivers/hwmon/w83792d.c
@@ -43,6 +43,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f, I2C_CLIENT_END };
@@ -271,7 +272,7 @@ struct w83792d_data {
         struct class_device *class_dev;
         enum chips type;
 
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid;             /* !=0 if following fields are valid */
         unsigned long last_updated;     /* In jiffies */
 
@@ -382,30 +383,40 @@ static ssize_t store_in_##reg (struct device *dev, \
 store_in_reg(MIN, min);
 store_in_reg(MAX, max);
 
-#define sysfs_in_reg(offset) \
-static SENSOR_DEVICE_ATTR(in##offset##_input, S_IRUGO, show_in, \
-                                NULL, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_min, S_IRUGO | S_IWUSR, \
-                                show_in_min, store_in_min, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_max, S_IRUGO | S_IWUSR, \
-                                show_in_max, store_in_max, offset);
-
-sysfs_in_reg(0);
-sysfs_in_reg(1);
-sysfs_in_reg(2);
-sysfs_in_reg(3);
-sysfs_in_reg(4);
-sysfs_in_reg(5);
-sysfs_in_reg(6);
-sysfs_in_reg(7);
-sysfs_in_reg(8);
-
-#define device_create_file_in(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_max.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_min.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_in_input[] = {
+        SENSOR_ATTR(in0_input, S_IRUGO, show_in, NULL, 0),
+        SENSOR_ATTR(in1_input, S_IRUGO, show_in, NULL, 1),
+        SENSOR_ATTR(in2_input, S_IRUGO, show_in, NULL, 2),
+        SENSOR_ATTR(in3_input, S_IRUGO, show_in, NULL, 3),
+        SENSOR_ATTR(in4_input, S_IRUGO, show_in, NULL, 4),
+        SENSOR_ATTR(in5_input, S_IRUGO, show_in, NULL, 5),
+        SENSOR_ATTR(in6_input, S_IRUGO, show_in, NULL, 6),
+        SENSOR_ATTR(in7_input, S_IRUGO, show_in, NULL, 7),
+        SENSOR_ATTR(in8_input, S_IRUGO, show_in, NULL, 8),
+};
+static struct sensor_device_attribute sda_in_min[] = {
+       SENSOR_ATTR(in0_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 0),
+       SENSOR_ATTR(in1_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 1),
+       SENSOR_ATTR(in2_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 2),
+       SENSOR_ATTR(in3_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 3),
+       SENSOR_ATTR(in4_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 4),
+       SENSOR_ATTR(in5_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 5),
+       SENSOR_ATTR(in6_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 6),
+       SENSOR_ATTR(in7_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 7),
+       SENSOR_ATTR(in8_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 8),
+};
+static struct sensor_device_attribute sda_in_max[] = {
+       SENSOR_ATTR(in0_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 0),
+       SENSOR_ATTR(in1_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 1),
+       SENSOR_ATTR(in2_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 2),
+       SENSOR_ATTR(in3_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 3),
+       SENSOR_ATTR(in4_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 4),
+       SENSOR_ATTR(in5_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 5),
+       SENSOR_ATTR(in6_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 6),
+       SENSOR_ATTR(in7_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 7),
+       SENSOR_ATTR(in8_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 8),
+};
+
 
 #define show_fan_reg(reg) \
 static ssize_t show_##reg (struct device *dev, struct device_attribute *attr, \
@@ -486,28 +497,33 @@ store_fan_div(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_fan(offset) \
-static SENSOR_DEVICE_ATTR(fan##offset##_input, S_IRUGO, show_fan, NULL, \
-                                offset); \
-static SENSOR_DEVICE_ATTR(fan##offset##_div, S_IRUGO | S_IWUSR, \
-                                show_fan_div, store_fan_div, offset); \
-static SENSOR_DEVICE_ATTR(fan##offset##_min, S_IRUGO | S_IWUSR, \
-                                show_fan_min, store_fan_min, offset);
-
-sysfs_fan(1);
-sysfs_fan(2);
-sysfs_fan(3);
-sysfs_fan(4);
-sysfs_fan(5);
-sysfs_fan(6);
-sysfs_fan(7);
-
-#define device_create_file_fan(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_div.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_min.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_fan_input[] = {
+        SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 1),
+        SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 2),
+        SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 3),
+        SENSOR_ATTR(fan4_input, S_IRUGO, show_fan, NULL, 4),
+        SENSOR_ATTR(fan5_input, S_IRUGO, show_fan, NULL, 5),
+        SENSOR_ATTR(fan6_input, S_IRUGO, show_fan, NULL, 6),
+        SENSOR_ATTR(fan7_input, S_IRUGO, show_fan, NULL, 7),
+};
+static struct sensor_device_attribute sda_fan_min[] = {
+        SENSOR_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 1),
+        SENSOR_ATTR(fan2_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 2),
+        SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 3),
+        SENSOR_ATTR(fan4_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 4),
+        SENSOR_ATTR(fan5_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 5),
+        SENSOR_ATTR(fan6_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 6),
+        SENSOR_ATTR(fan7_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 7),
+};
+static struct sensor_device_attribute sda_fan_div[] = {
+        SENSOR_ATTR(fan1_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 1),
+        SENSOR_ATTR(fan2_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 2),
+        SENSOR_ATTR(fan3_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 3),
+        SENSOR_ATTR(fan4_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 4),
+        SENSOR_ATTR(fan5_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 5),
+        SENSOR_ATTR(fan6_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 6),
+        SENSOR_ATTR(fan7_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 7),
+};
 
 
 /* read/write the temperature1, includes measured value and limits */
@@ -539,21 +555,6 @@ static ssize_t store_temp1(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-
-static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp1, NULL, 0);
-static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO | S_IWUSR, show_temp1,
-                                store_temp1, 1);
-static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1,
-                                store_temp1, 2);
-
-#define device_create_file_temp1(client) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_max.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_max_hyst.dev_attr); \
-} while (0)
-
-
 /* read/write the temperature2-3, includes measured value and limits */
 
 static ssize_t show_temp23(struct device *dev, struct device_attribute *attr,
@@ -590,25 +591,23 @@ static ssize_t store_temp23(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_temp23(name,idx) \
-static SENSOR_DEVICE_ATTR_2(name##_input, S_IRUGO, show_temp23, NULL, \
-                                idx, 0); \
-static SENSOR_DEVICE_ATTR_2(name##_max, S_IRUGO | S_IWUSR, \
-                                show_temp23, store_temp23, idx, 2); \
-static SENSOR_DEVICE_ATTR_2(name##_max_hyst, S_IRUGO | S_IWUSR, \
-                                show_temp23, store_temp23, idx, 4);
-
-sysfs_temp23(temp2,0)
-sysfs_temp23(temp3,1)
+static struct sensor_device_attribute_2 sda_temp_input[] = {
+        SENSOR_ATTR_2(temp1_input, S_IRUGO, show_temp1, NULL, 0, 0),
+        SENSOR_ATTR_2(temp2_input, S_IRUGO, show_temp23, NULL, 0, 0),
+        SENSOR_ATTR_2(temp3_input, S_IRUGO, show_temp23, NULL, 1, 0),
+};
 
-#define device_create_file_temp_add(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_max.dev_attr); \
-device_create_file(&client->dev, \
-&sensor_dev_attr_temp##offset##_max_hyst.dev_attr); \
-} while (0)
+static struct sensor_device_attribute_2 sda_temp_max[] = {
+        SENSOR_ATTR_2(temp1_max, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 1),
+        SENSOR_ATTR_2(temp2_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 2),
+        SENSOR_ATTR_2(temp3_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 2),
+};
 
+static struct sensor_device_attribute_2 sda_temp_max_hyst[] = {
+        SENSOR_ATTR_2(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 2),
+        SENSOR_ATTR_2(temp2_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 4),
+        SENSOR_ATTR_2(temp3_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 4),
+};
 
 /* get reatime status of all sensors items: voltage, temp, fan */
 static ssize_t
@@ -620,10 +619,6 @@ show_alarms_reg(struct device *dev, struct device_attribute *attr, char *buf)
 
 static
 DEVICE_ATTR(alarms, S_IRUGO, show_alarms_reg, NULL);
-#define device_create_file_alarms(client) \
-device_create_file(&client->dev, &dev_attr_alarms);
-
-
 
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr,
@@ -711,26 +706,19 @@ store_pwmenable(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_pwm(offset) \
-static SENSOR_DEVICE_ATTR(pwm##offset, S_IRUGO | S_IWUSR, \
-                                show_pwm, store_pwm, offset); \
-static SENSOR_DEVICE_ATTR(pwm##offset##_enable, S_IRUGO | S_IWUSR, \
-                                show_pwmenable, store_pwmenable, offset); \
-
-sysfs_pwm(1);
-sysfs_pwm(2);
-sysfs_pwm(3);
-
-
-#define device_create_file_pwm(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset.dev_attr); \
-} while (0)
-
-#define device_create_file_pwmenable(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_enable.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_pwm[] = {
+        SENSOR_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 1),
+        SENSOR_ATTR(pwm2, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 2),
+        SENSOR_ATTR(pwm3, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 3),
+};
+static struct sensor_device_attribute sda_pwm_enable[] = {
+        SENSOR_ATTR(pwm1_enable, S_IWUSR | S_IRUGO,
+                    show_pwmenable, store_pwmenable, 1),
+        SENSOR_ATTR(pwm2_enable, S_IWUSR | S_IRUGO,
+                    show_pwmenable, store_pwmenable, 2),
+        SENSOR_ATTR(pwm3_enable, S_IWUSR | S_IRUGO,
+                    show_pwmenable, store_pwmenable, 3),
+};
 
 
 static ssize_t
@@ -764,18 +752,14 @@ store_pwm_mode(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_pwm_mode(offset) \
-static SENSOR_DEVICE_ATTR(pwm##offset##_mode, S_IRUGO | S_IWUSR, \
-                                show_pwm_mode, store_pwm_mode, offset);
-
-sysfs_pwm_mode(1);
-sysfs_pwm_mode(2);
-sysfs_pwm_mode(3);
-
-#define device_create_file_pwm_mode(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_mode.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_pwm_mode[] = {
+        SENSOR_ATTR(pwm1_mode, S_IWUSR | S_IRUGO,
+                    show_pwm_mode, store_pwm_mode, 1),
+        SENSOR_ATTR(pwm2_mode, S_IWUSR | S_IRUGO,
+                    show_pwm_mode, store_pwm_mode, 2),
+        SENSOR_ATTR(pwm3_mode, S_IWUSR | S_IRUGO,
+                    show_pwm_mode, store_pwm_mode, 3),
+};
 
 
 static ssize_t
@@ -788,12 +772,6 @@ show_regs_chassis(struct device *dev, struct device_attribute *attr,
 
 static DEVICE_ATTR(chassis, S_IRUGO, show_regs_chassis, NULL);
 
-#define device_create_file_chassis(client) \
-do { \
-device_create_file(&client->dev, &dev_attr_chassis); \
-} while (0)
-
-
 static ssize_t
 show_chassis_clear(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -824,13 +802,6 @@ store_chassis_clear(struct device *dev, struct device_attribute *attr,
 static DEVICE_ATTR(chassis_clear, S_IRUGO | S_IWUSR,
                 show_chassis_clear, store_chassis_clear);
 
-#define device_create_file_chassis_clear(client) \
-do { \
-device_create_file(&client->dev, &dev_attr_chassis_clear); \
-} while (0)
-
-
-
 /* For Smart Fan I / Thermal Cruise */
 static ssize_t
 show_thermal_cruise(struct device *dev, struct device_attribute *attr,
@@ -864,20 +835,14 @@ store_thermal_cruise(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_thermal_cruise(offset) \
-static SENSOR_DEVICE_ATTR(thermal_cruise##offset, S_IRUGO | S_IWUSR, \
-                        show_thermal_cruise, store_thermal_cruise, offset);
-
-sysfs_thermal_cruise(1);
-sysfs_thermal_cruise(2);
-sysfs_thermal_cruise(3);
-
-#define device_create_file_thermal_cruise(client, offset) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_thermal_cruise##offset.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute sda_thermal_cruise[] = {
+        SENSOR_ATTR(thermal_cruise1, S_IWUSR | S_IRUGO,
+                    show_thermal_cruise, store_thermal_cruise, 1),
+        SENSOR_ATTR(thermal_cruise2, S_IWUSR | S_IRUGO,
+                    show_thermal_cruise, store_thermal_cruise, 2),
+        SENSOR_ATTR(thermal_cruise3, S_IWUSR | S_IRUGO,
+                    show_thermal_cruise, store_thermal_cruise, 3),
+};
 
 /* For Smart Fan I/Thermal Cruise and Smart Fan II */
 static ssize_t
@@ -916,19 +881,14 @@ store_tolerance(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_tolerance(offset) \
-static SENSOR_DEVICE_ATTR(tolerance##offset, S_IRUGO | S_IWUSR, \
-                                show_tolerance, store_tolerance, offset);
-
-sysfs_tolerance(1);
-sysfs_tolerance(2);
-sysfs_tolerance(3);
-
-#define device_create_file_tolerance(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_tolerance##offset.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute sda_tolerance[] = {
+        SENSOR_ATTR(tolerance1, S_IWUSR | S_IRUGO,
+                    show_tolerance, store_tolerance, 1),
+        SENSOR_ATTR(tolerance2, S_IWUSR | S_IRUGO,
+                    show_tolerance, store_tolerance, 2),
+        SENSOR_ATTR(tolerance3, S_IWUSR | S_IRUGO,
+                    show_tolerance, store_tolerance, 3),
+};
 
 /* For Smart Fan II */
 static ssize_t
@@ -964,28 +924,34 @@ store_sf2_point(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_sf2_point(offset, index) \
-static SENSOR_DEVICE_ATTR_2(sf2_point##offset##_fan##index, S_IRUGO | S_IWUSR, \
-                                show_sf2_point, store_sf2_point, offset, index);
-
-sysfs_sf2_point(1, 1);  /* Fan1 */
-sysfs_sf2_point(2, 1);  /* Fan1 */
-sysfs_sf2_point(3, 1);  /* Fan1 */
-sysfs_sf2_point(4, 1);  /* Fan1 */
-sysfs_sf2_point(1, 2);  /* Fan2 */
-sysfs_sf2_point(2, 2);  /* Fan2 */
-sysfs_sf2_point(3, 2);  /* Fan2 */
-sysfs_sf2_point(4, 2);  /* Fan2 */
-sysfs_sf2_point(1, 3);  /* Fan3 */
-sysfs_sf2_point(2, 3);  /* Fan3 */
-sysfs_sf2_point(3, 3);  /* Fan3 */
-sysfs_sf2_point(4, 3);  /* Fan3 */
-
-#define device_create_file_sf2_point(client, offset, index) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_sf2_point##offset##_fan##index.dev_attr); \
-} while (0)
+static struct sensor_device_attribute_2 sda_sf2_point[] = {
+        SENSOR_ATTR_2(sf2_point1_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 1, 1),
+        SENSOR_ATTR_2(sf2_point2_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 2, 1),
+        SENSOR_ATTR_2(sf2_point3_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 3, 1),
+        SENSOR_ATTR_2(sf2_point4_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 4, 1),
+
+        SENSOR_ATTR_2(sf2_point1_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 1, 2),
+        SENSOR_ATTR_2(sf2_point2_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 2, 2),
+        SENSOR_ATTR_2(sf2_point3_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 3, 2),
+        SENSOR_ATTR_2(sf2_point4_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 4, 2),
+
+        SENSOR_ATTR_2(sf2_point1_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 1, 3),
+        SENSOR_ATTR_2(sf2_point2_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 2, 3),
+        SENSOR_ATTR_2(sf2_point3_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 3, 3),
+        SENSOR_ATTR_2(sf2_point4_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_point, store_sf2_point, 4, 3),
+};
 
 
 static ssize_t
@@ -1026,26 +992,28 @@ store_sf2_level(struct device *dev, struct device_attribute *attr,
         return count;
 }
 
-#define sysfs_sf2_level(offset, index) \
-static SENSOR_DEVICE_ATTR_2(sf2_level##offset##_fan##index, S_IRUGO | S_IWUSR, \
-                                show_sf2_level, store_sf2_level, offset, index);
-
-sysfs_sf2_level(1, 1);  /* Fan1 */
-sysfs_sf2_level(2, 1);  /* Fan1 */
-sysfs_sf2_level(3, 1);  /* Fan1 */
-sysfs_sf2_level(1, 2);  /* Fan2 */
-sysfs_sf2_level(2, 2);  /* Fan2 */
-sysfs_sf2_level(3, 2);  /* Fan2 */
-sysfs_sf2_level(1, 3);  /* Fan3 */
-sysfs_sf2_level(2, 3);  /* Fan3 */
-sysfs_sf2_level(3, 3);  /* Fan3 */
-
-#define device_create_file_sf2_level(client, offset, index) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_sf2_level##offset##_fan##index.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute_2 sda_sf2_level[] = {
+        SENSOR_ATTR_2(sf2_level1_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 1, 1),
+        SENSOR_ATTR_2(sf2_level2_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 2, 1),
+        SENSOR_ATTR_2(sf2_level3_fan1, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 3, 1),
+
+        SENSOR_ATTR_2(sf2_level1_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 1, 2),
+        SENSOR_ATTR_2(sf2_level2_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 2, 2),
+        SENSOR_ATTR_2(sf2_level3_fan2, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 3, 2),
+
+        SENSOR_ATTR_2(sf2_level1_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 1, 3),
+        SENSOR_ATTR_2(sf2_level2_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 2, 3),
+        SENSOR_ATTR_2(sf2_level3_fan3, S_IRUGO | S_IWUSR,
+                      show_sf2_level, store_sf2_level, 3, 3),
+};
 
 /* This function is called when:
      * w83792d_driver is inserted (when this module is loaded), for each
@@ -1147,12 +1115,19 @@ ERROR_SC_0:
         return err;
 }
 
+static void device_create_file_fan(struct device *dev, int i)
+{
+        device_create_file(dev, &sda_fan_input[i].dev_attr);
+        device_create_file(dev, &sda_fan_div[i].dev_attr);
+        device_create_file(dev, &sda_fan_min[i].dev_attr);
+}
 
 static int
 w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
 {
         int i = 0, val1 = 0, val2;
-        struct i2c_client *new_client;
+        struct i2c_client *client;
+        struct device *dev;
         struct w83792d_data *data;
         int err = 0;
         const char *client_name = "";
@@ -1170,12 +1145,13 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                 goto ERROR0;
         }
 
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &w83792d_driver;
-        new_client->flags = 0;
+        client = &data->client;
+        dev = &client->dev;
+        i2c_set_clientdata(client, data);
+        client->addr = address;
+        client->adapter = adapter;
+        client->driver = &w83792d_driver;
+        client->flags = 0;
 
         /* Now, we do the remaining detection. */
 
@@ -1184,13 +1160,12 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
            force_*=... parameter, and the Winbond will be reset to the right
            bank. */
         if (kind < 0) {
-                if (w83792d_read_value(new_client, W83792D_REG_CONFIG) & 0x80) {
-                        dev_warn(&new_client->dev, "Detection failed at step "
-                                "3\n");
+                if (w83792d_read_value(client, W83792D_REG_CONFIG) & 0x80) {
+                        dev_warn(dev, "Detection failed at step 3\n");
                         goto ERROR1;
                 }
-                val1 = w83792d_read_value(new_client, W83792D_REG_BANK);
-                val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
+                val1 = w83792d_read_value(client, W83792D_REG_BANK);
+                val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
                 /* Check for Winbond ID if in bank 0 */
                 if (!(val1 & 0x07)) {  /* is Bank0 */
                         if (((!(val1 & 0x80)) && (val2 != 0xa3)) ||
@@ -1200,34 +1175,33 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                 }
                 /* If Winbond chip, address of chip and W83792D_REG_I2C_ADDR
                    should match */
-                if (w83792d_read_value(new_client,
+                if (w83792d_read_value(client,
                                         W83792D_REG_I2C_ADDR) != address) {
-                        dev_warn(&new_client->dev, "Detection failed "
-                                "at step 5\n");
+                        dev_warn(dev, "Detection failed at step 5\n");
                         goto ERROR1;
                 }
         }
 
         /* We have either had a force parameter, or we have already detected the
            Winbond. Put it now into bank 0 and Vendor ID High Byte */
-        w83792d_write_value(new_client,
+        w83792d_write_value(client,
                             W83792D_REG_BANK,
-                            (w83792d_read_value(new_client,
+                            (w83792d_read_value(client,
                                 W83792D_REG_BANK) & 0x78) | 0x80);
 
         /* Determine the chip type. */
         if (kind <= 0) {
                 /* get vendor ID */
-                val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
+                val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
                 if (val2 != 0x5c) {  /* the vendor is NOT Winbond */
                         goto ERROR1;
                 }
-                val1 = w83792d_read_value(new_client, W83792D_REG_WCHIPID);
+                val1 = w83792d_read_value(client, W83792D_REG_WCHIPID);
                 if (val1 == 0x7a) {
                         kind = w83792d;
                 } else {
                         if (kind == 0)
-                                        dev_warn(&new_client->dev,
+                                        dev_warn(dev,
                                         "w83792d: Ignoring 'force' parameter for"
                                         " unknown chip at adapter %d, address"
                                         " 0x%02x\n", i2c_adapter_id(adapter),
@@ -1239,120 +1213,86 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
         if (kind == w83792d) {
                 client_name = "w83792d";
         } else {
-                dev_err(&new_client->dev, "w83792d: Internal error: unknown"
+                dev_err(dev, "w83792d: Internal error: unknown"
                                           " kind (%d)?!?", kind);
                 goto ERROR1;
         }
 
         /* Fill in the remaining client fields and put into the global list */
-        strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
+        strlcpy(client->name, client_name, I2C_NAME_SIZE);
         data->type = kind;
 
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
+        if ((err = i2c_attach_client(client)))
                 goto ERROR1;
 
         if ((err = w83792d_detect_subclients(adapter, address,
-                        kind, new_client)))
+                        kind, client)))
                 goto ERROR2;
 
         /* Initialize the chip */
-        w83792d_init_client(new_client);
+        w83792d_init_client(client);
 
         /* A few vars need to be filled upon startup */
         for (i = 0; i < 7; i++) {
-                data->fan_min[i] = w83792d_read_value(new_client,
+                data->fan_min[i] = w83792d_read_value(client,
                                         W83792D_REG_FAN_MIN[i]);
         }
 
         /* Register sysfs hooks */
-        data->class_dev = hwmon_device_register(&new_client->dev);
+        data->class_dev = hwmon_device_register(dev);
         if (IS_ERR(data->class_dev)) {
                 err = PTR_ERR(data->class_dev);
                 goto ERROR3;
         }
-        device_create_file_in(new_client, 0);
-        device_create_file_in(new_client, 1);
-        device_create_file_in(new_client, 2);
-        device_create_file_in(new_client, 3);
-        device_create_file_in(new_client, 4);
-        device_create_file_in(new_client, 5);
-        device_create_file_in(new_client, 6);
-        device_create_file_in(new_client, 7);
-        device_create_file_in(new_client, 8);
-
-        device_create_file_fan(new_client, 1);
-        device_create_file_fan(new_client, 2);
-        device_create_file_fan(new_client, 3);
+        for (i = 0; i < 9; i++) {
+                device_create_file(dev, &sda_in_input[i].dev_attr);
+                device_create_file(dev, &sda_in_max[i].dev_attr);
+                device_create_file(dev, &sda_in_min[i].dev_attr);
+        }
+        for (i = 0; i < 3; i++)
+                device_create_file_fan(dev, i);
 
         /* Read GPIO enable register to check if pins for fan 4,5 are used as
            GPIO */
-        val1 = w83792d_read_value(new_client, W83792D_REG_GPIO_EN);
+        val1 = w83792d_read_value(client, W83792D_REG_GPIO_EN);
         if (!(val1 & 0x40))
-                device_create_file_fan(new_client, 4);
+                device_create_file_fan(dev, 3);
         if (!(val1 & 0x20))
-                device_create_file_fan(new_client, 5);
+                device_create_file_fan(dev, 4);
 
-        val1 = w83792d_read_value(new_client, W83792D_REG_PIN);
+        val1 = w83792d_read_value(client, W83792D_REG_PIN);
         if (val1 & 0x40)
-                device_create_file_fan(new_client, 6);
+                device_create_file_fan(dev, 5);
         if (val1 & 0x04)
-                device_create_file_fan(new_client, 7);
-
-        device_create_file_temp1(new_client);           /* Temp1 */
-        device_create_file_temp_add(new_client, 2);     /* Temp2 */
-        device_create_file_temp_add(new_client, 3);     /* Temp3 */
-
-        device_create_file_alarms(new_client);
-
-        device_create_file_pwm(new_client, 1);
-        device_create_file_pwm(new_client, 2);
-        device_create_file_pwm(new_client, 3);
-
-        device_create_file_pwmenable(new_client, 1);
-        device_create_file_pwmenable(new_client, 2);
-        device_create_file_pwmenable(new_client, 3);
-
-        device_create_file_pwm_mode(new_client, 1);
-        device_create_file_pwm_mode(new_client, 2);
-        device_create_file_pwm_mode(new_client, 3);
-
-        device_create_file_chassis(new_client);
-        device_create_file_chassis_clear(new_client);
-
-        device_create_file_thermal_cruise(new_client, 1);
-        device_create_file_thermal_cruise(new_client, 2);
-        device_create_file_thermal_cruise(new_client, 3);
-
-        device_create_file_tolerance(new_client, 1);
-        device_create_file_tolerance(new_client, 2);
-        device_create_file_tolerance(new_client, 3);
-
-        device_create_file_sf2_point(new_client, 1, 1); /* Fan1 */
-        device_create_file_sf2_point(new_client, 2, 1); /* Fan1 */
-        device_create_file_sf2_point(new_client, 3, 1); /* Fan1 */
-        device_create_file_sf2_point(new_client, 4, 1); /* Fan1 */
-        device_create_file_sf2_point(new_client, 1, 2); /* Fan2 */
-        device_create_file_sf2_point(new_client, 2, 2); /* Fan2 */
-        device_create_file_sf2_point(new_client, 3, 2); /* Fan2 */
-        device_create_file_sf2_point(new_client, 4, 2); /* Fan2 */
-        device_create_file_sf2_point(new_client, 1, 3); /* Fan3 */
-        device_create_file_sf2_point(new_client, 2, 3); /* Fan3 */
-        device_create_file_sf2_point(new_client, 3, 3); /* Fan3 */
-        device_create_file_sf2_point(new_client, 4, 3); /* Fan3 */
-
-        device_create_file_sf2_level(new_client, 1, 1); /* Fan1 */
-        device_create_file_sf2_level(new_client, 2, 1); /* Fan1 */
-        device_create_file_sf2_level(new_client, 3, 1); /* Fan1 */
-        device_create_file_sf2_level(new_client, 1, 2); /* Fan2 */
-        device_create_file_sf2_level(new_client, 2, 2); /* Fan2 */
-        device_create_file_sf2_level(new_client, 3, 2); /* Fan2 */
-        device_create_file_sf2_level(new_client, 1, 3); /* Fan3 */
-        device_create_file_sf2_level(new_client, 2, 3); /* Fan3 */
-        device_create_file_sf2_level(new_client, 3, 3); /* Fan3 */
+                device_create_file_fan(dev, 6);
+
+        for (i = 0; i < 3; i++) {
+                device_create_file(dev, &sda_temp_input[i].dev_attr);
+                device_create_file(dev, &sda_temp_max[i].dev_attr);
+                device_create_file(dev, &sda_temp_max_hyst[i].dev_attr);
+                device_create_file(dev, &sda_thermal_cruise[i].dev_attr);
+                device_create_file(dev, &sda_tolerance[i].dev_attr);
+        }
+
+        for (i = 0; i < ARRAY_SIZE(sda_pwm); i++) {
+                device_create_file(dev, &sda_pwm[i].dev_attr);
+                device_create_file(dev, &sda_pwm_enable[i].dev_attr);
+                device_create_file(dev, &sda_pwm_mode[i].dev_attr);
+        }
+
+        device_create_file(dev, &dev_attr_alarms);
+        device_create_file(dev, &dev_attr_chassis);
+        device_create_file(dev, &dev_attr_chassis_clear);
+
+        for (i = 0; i < ARRAY_SIZE(sda_sf2_point); i++)
+                device_create_file(dev, &sda_sf2_point[i].dev_attr);
+
+        for (i = 0; i < ARRAY_SIZE(sda_sf2_level); i++)
+                device_create_file(dev, &sda_sf2_level[i].dev_attr);
 
         return 0;
 
@@ -1366,7 +1306,7 @@ ERROR3:
                 kfree(data->lm75[1]);
         }
 ERROR2:
-        i2c_detach_client(new_client);
+        i2c_detach_client(client);
 ERROR1:
         kfree(data);
 ERROR0:
@@ -1434,7 +1374,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
         int i, j;
         u8 reg_array_tmp[4], pwm_array_tmp[7], reg_tmp;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (time_after
             (jiffies - data->last_updated, (unsigned long) (HZ * 3))
@@ -1545,7 +1485,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
 #ifdef DEBUG
         w83792d_print_debug(data, dev);
diff --git a/drivers/hwmon/w83l785ts.c b/drivers/hwmon/w83l785ts.c
index f66c0cfdeda7..3f2bac125fb1 100644
--- a/drivers/hwmon/w83l785ts.c
+++ b/drivers/hwmon/w83l785ts.c
@@ -39,6 +39,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* How many retries on register read error */
 #define MAX_RETRIES     5
@@ -107,7 +108,7 @@ static struct i2c_driver w83l785ts_driver = {
 struct w83l785ts_data {
         struct i2c_client client;
         struct class_device *class_dev;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
 
@@ -221,7 +222,7 @@ static int w83l785ts_detect(struct i2c_adapter *adapter, int address, int kind)
         /* We can fill in the remaining client fields. */
         strlcpy(new_client->name, "w83l785ts", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Default values in case the first read fails (unlikely). */
         data->temp[1] = data->temp[0] = 0;
@@ -299,7 +300,7 @@ static struct w83l785ts_data *w83l785ts_update_device(struct device *dev)
         struct i2c_client *client = to_i2c_client(dev);
         struct w83l785ts_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (!data->valid || time_after(jiffies, data->last_updated + HZ * 2)) {
                 dev_dbg(&client->dev, "Updating w83l785ts data.\n");
@@ -312,7 +313,7 @@ static struct w83l785ts_data *w83l785ts_update_device(struct device *dev)
                 data->valid = 1;
         }
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         return data;
 }
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index ff92735c7c85..089c6f5b24de 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -168,12 +168,14 @@ config I2C_PIIX4
         help
           If you say yes to this option, support will be included for the Intel
           PIIX4 family of mainboard I2C interfaces.  Specifically, the following
-          versions of the chipset are supported:
+          versions of the chipset are supported (note that Serverworks is part
+          of Broadcom):
             Intel PIIX4
             Intel 440MX
             Serverworks OSB4
             Serverworks CSB5
             Serverworks CSB6
+            Serverworks HT-1000
             SMSC Victory66
 
           This driver can also be built as a module.  If so, the module
@@ -389,10 +391,11 @@ config SCx200_I2C_SDA
           also be specified with a module parameter.
 
 config SCx200_ACB
-        tristate "NatSemi SCx200 ACCESS.bus"
-        depends on I2C && PCI
+        tristate "Geode ACCESS.bus support"
+        depends on X86_32 && I2C && PCI
         help
-          Enable the use of the ACCESS.bus controllers of a SCx200 processor.
+          Enable the use of the ACCESS.bus controllers on the Geode SCx200 and
+          SC1100 processors and the CS5535 and CS5536 Geode companion devices.
 
           If you don't know what to do here, say N.
 
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index 3eb47890db40..d3ef46aeeb3c 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -63,7 +63,6 @@
 #include <linux/i2c.h>
 #include <linux/init.h>
 #include <asm/io.h>
-#include <asm/semaphore.h>
 
 
 /* ALI1535 SMBus address offsets */
@@ -136,7 +135,6 @@
 
 static struct pci_driver ali1535_driver;
 static unsigned short ali1535_smba;
-static DECLARE_MUTEX(i2c_ali1535_sem);
 
 /* Detect whether a ALI1535 can be found, and initialize it, where necessary.
    Note the differences between kernels with the old PCI BIOS interface and
@@ -345,7 +343,6 @@ static s32 ali1535_access(struct i2c_adapter *adap, u16 addr,
         int timeout;
         s32 result = 0;
 
-        down(&i2c_ali1535_sem);
         /* make sure SMBus is idle */
         temp = inb_p(SMBHSTSTS);
         for (timeout = 0;
@@ -460,7 +457,6 @@ static s32 ali1535_access(struct i2c_adapter *adap, u16 addr,
                 break;
         }
 EXIT:
-        up(&i2c_ali1535_sem);
         return result;
 }
 
diff --git a/drivers/i2c/busses/i2c-amd756-s4882.c b/drivers/i2c/busses/i2c-amd756-s4882.c
index 56c7d987590f..08e915730caf 100644
--- a/drivers/i2c/busses/i2c-amd756-s4882.c
+++ b/drivers/i2c/busses/i2c-amd756-s4882.c
@@ -38,6 +38,7 @@
 #include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/i2c.h>
+#include <linux/mutex.h>
 
 extern struct i2c_adapter amd756_smbus;
 
@@ -45,7 +46,7 @@ static struct i2c_adapter *s4882_adapter;
 static struct i2c_algorithm *s4882_algo;
 
 /* Wrapper access functions for multiplexed SMBus */
-static struct semaphore amd756_lock;
+static DEFINE_MUTEX(amd756_lock);
 
 static s32 amd756_access_virt0(struct i2c_adapter * adap, u16 addr,
                                unsigned short flags, char read_write,
@@ -59,12 +60,12 @@ static s32 amd756_access_virt0(struct i2c_adapter * adap, u16 addr,
          || addr == 0x18)
                 return -1;
 
-        down(&amd756_lock);
+        mutex_lock(&amd756_lock);
 
         error = amd756_smbus.algo->smbus_xfer(adap, addr, flags, read_write,
                                               command, size, data);
 
-        up(&amd756_lock);
+        mutex_unlock(&amd756_lock);
 
         return error;
 }
@@ -87,7 +88,7 @@ static inline s32 amd756_access_channel(struct i2c_adapter * adap, u16 addr,
         if (addr != 0x4c && (addr & 0xfc) != 0x50 && (addr & 0xfc) != 0x30)
                 return -1;
 
-        down(&amd756_lock);
+        mutex_lock(&amd756_lock);
 
         if (last_channels != channels) {
                 union i2c_smbus_data mplxdata;
@@ -105,7 +106,7 @@ static inline s32 amd756_access_channel(struct i2c_adapter * adap, u16 addr,
                                               command, size, data);
 
 UNLOCK:
-        up(&amd756_lock);
+        mutex_unlock(&amd756_lock);
         return error;
 }
 
@@ -166,8 +167,6 @@ static int __init amd756_s4882_init(void)
         }
 
         printk(KERN_INFO "Enabling SMBus multiplexing for Tyan S4882\n");
-        init_MUTEX(&amd756_lock);
-
         /* Define the 5 virtual adapters and algorithms structures */
         if (!(s4882_adapter = kzalloc(5 * sizeof(struct i2c_adapter),
                                       GFP_KERNEL))) {
diff --git a/drivers/i2c/busses/i2c-frodo.c b/drivers/i2c/busses/i2c-frodo.c
deleted file mode 100644
index b6f52f5a4138..000000000000
--- a/drivers/i2c/busses/i2c-frodo.c
+++ /dev/null
@@ -1,85 +0,0 @@
-
-/*
- * linux/drivers/i2c/i2c-frodo.c
- *
- * Author: Abraham van der Merwe <abraham@2d3d.co.za>
- *
- * An I2C adapter driver for the 2d3D, Inc. StrongARM SA-1110
- * Development board (Frodo).
- *
- * This source code is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/delay.h>
-#include <linux/i2c.h>
-#include <linux/i2c-algo-bit.h>
-#include <asm/hardware.h>
-
-
-static void frodo_setsda (void *data,int state)
-{
-        if (state)
-                FRODO_CPLD_I2C |= FRODO_I2C_SDA_OUT;
-        else
-                FRODO_CPLD_I2C &= ~FRODO_I2C_SDA_OUT;
-}
-
-static void frodo_setscl (void *data,int state)
-{
-        if (state)
-                FRODO_CPLD_I2C |= FRODO_I2C_SCL_OUT;
-        else
-                FRODO_CPLD_I2C &= ~FRODO_I2C_SCL_OUT;
-}
-
-static int frodo_getsda (void *data)
-{
-        return ((FRODO_CPLD_I2C & FRODO_I2C_SDA_IN) != 0);
-}
-
-static int frodo_getscl (void *data)
-{
-        return ((FRODO_CPLD_I2C & FRODO_I2C_SCL_IN) != 0);
-}
-
-static struct i2c_algo_bit_data bit_frodo_data = {
-        .setsda         = frodo_setsda,
-        .setscl         = frodo_setscl,
-        .getsda         = frodo_getsda,
-        .getscl         = frodo_getscl,
-        .udelay         = 80,
-        .mdelay         = 80,
-        .timeout        = HZ
-};
-
-static struct i2c_adapter frodo_ops = {
-        .owner                  = THIS_MODULE,
-        .id                     = I2C_HW_B_FRODO,
-        .algo_data              = &bit_frodo_data,
-        .dev                    = {
-                .name           = "Frodo adapter driver",
-        },
-};
-
-static int __init i2c_frodo_init (void)
-{
-        return i2c_bit_add_bus(&frodo_ops);
-}
-
-static void __exit i2c_frodo_exit (void)
-{
-        i2c_bit_del_bus(&frodo_ops);
-}
-
-MODULE_AUTHOR ("Abraham van der Merwe <abraham@2d3d.co.za>");
-MODULE_DESCRIPTION ("I2C-Bus adapter routines for Frodo");
-MODULE_LICENSE ("GPL");
-
-module_init (i2c_frodo_init);
-module_exit (i2c_frodo_exit);
-
diff --git a/drivers/i2c/busses/i2c-isa.c b/drivers/i2c/busses/i2c-isa.c
index 4344ae6b1fcb..c3e1d3e888d7 100644
--- a/drivers/i2c/busses/i2c-isa.c
+++ b/drivers/i2c/busses/i2c-isa.c
@@ -125,7 +125,7 @@ int i2c_isa_del_driver(struct i2c_driver *driver)
 
 static int __init i2c_isa_init(void)
 {
-        init_MUTEX(&isa_adapter.clist_lock);
+        mutex_init(&isa_adapter.clist_lock);
         INIT_LIST_HEAD(&isa_adapter.clients);
 
         isa_adapter.nr = ANY_I2C_ISA_BUS;
diff --git a/drivers/i2c/busses/i2c-ite.c b/drivers/i2c/busses/i2c-ite.c
index 5f5d2944808b..d82e6dae8407 100644
--- a/drivers/i2c/busses/i2c-ite.c
+++ b/drivers/i2c/busses/i2c-ite.c
@@ -200,9 +200,7 @@ static struct i2c_adapter iic_ite_ops = {
         .owner          = THIS_MODULE,
         .id             = I2C_HW_I_IIC,
         .algo_data      = &iic_ite_data,
-        .dev            = {
-                .name   = "ITE IIC adapter",
-        },
+        .name           = "ITE IIC adapter",
 };
 
 /* Called when the module is loaded.  This function starts the
diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
index e422d8b2d4d6..2ed07112d683 100644
--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -126,6 +126,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
         drv_data->algo_data.timeout = 100;
 
         drv_data->adapter.id = I2C_HW_B_IXP4XX;
+        drv_data->adapter.class = I2C_CLASS_HWMON;
         strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
                 I2C_NAME_SIZE);
         drv_data->adapter.algo_data = &drv_data->algo_data;
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 692f47345481..d9c7c00e71f9 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -22,7 +22,7 @@
 /*
    Supports:
         Intel PIIX4, 440MX
-        Serverworks OSB4, CSB5, CSB6
+        Serverworks OSB4, CSB5, CSB6, HT-1000
         SMSC Victory66
 
    Note: we assume there can only be one device, with one SMBus interface.
@@ -419,6 +419,8 @@ static struct pci_device_id piix4_ids[] = {
           .driver_data = 0 },
         { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB6),
           .driver_data = 0 },
+        { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_HT1000SB),
+          .driver_data = 0 },
         { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443MX_3),
           .driver_data = 3 },
         { PCI_DEVICE(PCI_VENDOR_ID_EFAR, PCI_DEVICE_ID_EFAR_SLC90E66_3),
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 7579f4b256a8..5155010b455e 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -647,7 +647,7 @@ static inline void i2c_pxa_start_message(struct pxa_i2c *i2c)
 }
 
 /*
- * We are protected by the adapter bus semaphore.
+ * We are protected by the adapter bus mutex.
  */
 static int i2c_pxa_do_xfer(struct pxa_i2c *i2c, struct i2c_msg *msg, int num)
 {
diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
index d3478e084522..8bd305e47f0d 100644
--- a/drivers/i2c/busses/scx200_acb.c
+++ b/drivers/i2c/busses/scx200_acb.c
@@ -1,27 +1,26 @@
-/*  linux/drivers/i2c/scx200_acb.c 
-
+/*
     Copyright (c) 2001,2002 Christer Weinigel <wingel@nano-system.com>
 
     National Semiconductor SCx200 ACCESS.bus support
-    
+    Also supports the AMD CS5535 and AMD CS5536
+
     Based on i2c-keywest.c which is:
         Copyright (c) 2001 Benjamin Herrenschmidt <benh@kernel.crashing.org>
         Copyright (c) 2000 Philip Edelbrock <phil@stimpy.netroedge.com>
-    
+
     This program is free software; you can redistribute it and/or
     modify it under the terms of the GNU General Public License as
     published by the Free Software Foundation; either version 2 of the
     License, or (at your option) any later version.
-   
+
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
     General Public License for more details.
-   
+
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
 */
 
 #include <linux/module.h>
@@ -32,7 +31,9 @@
 #include <linux/smp_lock.h>
 #include <linux/pci.h>
 #include <linux/delay.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
+#include <asm/msr.h>
 
 #include <linux/scx200.h>
 
@@ -47,16 +48,7 @@ static int base[MAX_DEVICES] = { 0x820, 0x840 };
 module_param_array(base, int, NULL, 0);
 MODULE_PARM_DESC(base, "Base addresses for the ACCESS.bus controllers");
 
-#ifdef DEBUG
-#define DBG(x...) printk(KERN_DEBUG NAME ": " x)
-#else
-#define DBG(x...)
-#endif
-
-/* The hardware supports interrupt driven mode too, but I haven't
-   implemented that. */
-#define POLLED_MODE 1
-#define POLL_TIMEOUT (HZ)
+#define POLL_TIMEOUT    (HZ/5)
 
 enum scx200_acb_state {
         state_idle,
@@ -79,12 +71,11 @@ static const char *scx200_acb_state_name[] = {
 };
 
 /* Physical interface */
-struct scx200_acb_iface
-{
+struct scx200_acb_iface {
         struct scx200_acb_iface *next;
         struct i2c_adapter adapter;
         unsigned base;
-        struct semaphore sem;
+        struct mutex mutex;
 
         /* State machine data */
         enum scx200_acb_state state;
@@ -100,7 +91,7 @@ struct scx200_acb_iface
 #define ACBSDA          (iface->base + 0)
 #define ACBST           (iface->base + 1)
 #define    ACBST_SDAST          0x40 /* SDA Status */
-#define    ACBST_BER            0x20 
+#define    ACBST_BER            0x20
 #define    ACBST_NEGACK         0x10 /* Negative Acknowledge */
 #define    ACBST_STASTR         0x08 /* Stall After Start */
 #define    ACBST_MASTER         0x02
@@ -109,9 +100,9 @@ struct scx200_acb_iface
 #define ACBCTL1         (iface->base + 3)
 #define    ACBCTL1_STASTRE      0x80
 #define    ACBCTL1_NMINTE       0x40
-#define    ACBCTL1_ACK          0x10
-#define    ACBCTL1_STOP         0x02
-#define    ACBCTL1_START        0x01
+#define    ACBCTL1_ACK          0x10
+#define    ACBCTL1_STOP         0x02
+#define    ACBCTL1_START        0x01
 #define ACBADDR         (iface->base + 4)
 #define ACBCTL2         (iface->base + 5)
 #define    ACBCTL2_ENABLE       0x01
@@ -122,8 +113,8 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
 {
         const char *errmsg;
 
-        DBG("state %s, status = 0x%02x\n", 
-            scx200_acb_state_name[iface->state], status);
+        dev_dbg(&iface->adapter.dev, "state %s, status = 0x%02x\n",
+                scx200_acb_state_name[iface->state], status);
 
         if (status & ACBST_BER) {
                 errmsg = "bus error";
@@ -133,8 +124,17 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
                 errmsg = "not master";
                 goto error;
         }
-        if (status & ACBST_NEGACK)
-                goto negack;
+        if (status & ACBST_NEGACK) {
+                dev_dbg(&iface->adapter.dev, "negative ack in state %s\n",
+                        scx200_acb_state_name[iface->state]);
+
+                iface->state = state_idle;
+                iface->result = -ENXIO;
+
+                outb(inb(ACBCTL1) | ACBCTL1_STOP, ACBCTL1);
+                outb(ACBST_STASTR | ACBST_NEGACK, ACBST);
+                return;
+        }
 
         switch (iface->state) {
         case state_idle:
@@ -160,10 +160,10 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
         case state_repeat_start:
                 outb(inb(ACBCTL1) | ACBCTL1_START, ACBCTL1);
                 /* fallthrough */
-                
+
         case state_quick:
                 if (iface->address_byte & 1) {
-                        if (iface->len == 1) 
+                        if (iface->len == 1)
                                 outb(inb(ACBCTL1) | ACBCTL1_ACK, ACBCTL1);
                         else
                                 outb(inb(ACBCTL1) & ~ACBCTL1_ACK, ACBCTL1);
@@ -202,26 +202,15 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
                         outb(inb(ACBCTL1) | ACBCTL1_STOP, ACBCTL1);
                         break;
                 }
-                
+
                 outb(*iface->ptr++, ACBSDA);
                 --iface->len;
-                
+
                 break;
         }
 
         return;
 
- negack:
-        DBG("negative acknowledge in state %s\n", 
-            scx200_acb_state_name[iface->state]);
-
-        iface->state = state_idle;
-        iface->result = -ENXIO;
-
-        outb(inb(ACBCTL1) | ACBCTL1_STOP, ACBCTL1);
-        outb(ACBST_STASTR | ACBST_NEGACK, ACBST);
-        return;
-
  error:
         dev_err(&iface->adapter.dev, "%s in state %s\n", errmsg,
                 scx200_acb_state_name[iface->state]);
@@ -231,20 +220,9 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
         iface->needs_reset = 1;
 }
 
-static void scx200_acb_timeout(struct scx200_acb_iface *iface) 
-{
-        dev_err(&iface->adapter.dev, "timeout in state %s\n",
-                scx200_acb_state_name[iface->state]);
-
-        iface->state = state_idle;
-        iface->result = -EIO;
-        iface->needs_reset = 1;
-}
-
-#ifdef POLLED_MODE
 static void scx200_acb_poll(struct scx200_acb_iface *iface)
 {
-        u8 status = 0;
+        u8 status;
         unsigned long timeout;
 
         timeout = jiffies + POLL_TIMEOUT;
@@ -254,17 +232,21 @@ static void scx200_acb_poll(struct scx200_acb_iface *iface)
                         scx200_acb_machine(iface, status);
                         return;
                 }
-                msleep(10);
+                yield();
         }
 
-        scx200_acb_timeout(iface);
+        dev_err(&iface->adapter.dev, "timeout in state %s\n",
+                scx200_acb_state_name[iface->state]);
+
+        iface->state = state_idle;
+        iface->result = -EIO;
+        iface->needs_reset = 1;
 }
-#endif /* POLLED_MODE */
 
 static void scx200_acb_reset(struct scx200_acb_iface *iface)
 {
         /* Disable the ACCESS.bus device and Configure the SCL
-           frequency: 16 clock cycles */
+           frequency: 16 clock cycles */
         outb(0x70, ACBCTL2);
         /* Polling mode */
         outb(0, ACBCTL1);
@@ -283,9 +265,9 @@ static void scx200_acb_reset(struct scx200_acb_iface *iface)
 }
 
 static s32 scx200_acb_smbus_xfer(struct i2c_adapter *adapter,
-                                u16 address, unsigned short flags,      
-                                char rw, u8 command, int size, 
-                                union i2c_smbus_data *data)
+                                 u16 address, unsigned short flags,
+                                 char rw, u8 command, int size,
+                                 union i2c_smbus_data *data)
 {
         struct scx200_acb_iface *iface = i2c_get_adapdata(adapter);
         int len;
@@ -295,53 +277,47 @@ static s32 scx200_acb_smbus_xfer(struct i2c_adapter *adapter,
 
         switch (size) {
         case I2C_SMBUS_QUICK:
-                len = 0;
-                buffer = NULL;
-                break;
+                len = 0;
+                buffer = NULL;
+                break;
+
         case I2C_SMBUS_BYTE:
-                if (rw == I2C_SMBUS_READ) {
-                        len = 1;
-                        buffer = &data->byte;
-                } else {
-                        len = 1;
-                        buffer = &command;
-                }
-                break;
+                len = 1;
+                buffer = rw ? &data->byte : &command;
+                break;
+
         case I2C_SMBUS_BYTE_DATA:
-                len = 1;
-                buffer = &data->byte;
-                break;
+                len = 1;
+                buffer = &data->byte;
+                break;
+
         case I2C_SMBUS_WORD_DATA:
                 len = 2;
-                cur_word = cpu_to_le16(data->word);
-                buffer = (u8 *)&cur_word;
+                cur_word = cpu_to_le16(data->word);
+                buffer = (u8 *)&cur_word;
                 break;
+
         case I2C_SMBUS_BLOCK_DATA:
-                len = data->block[0];
-                buffer = &data->block[1];
+                len = data->block[0];
+                buffer = &data->block[1];
                 break;
+
         default:
-                return -EINVAL;
+                return -EINVAL;
         }
 
-        DBG("size=%d, address=0x%x, command=0x%x, len=%d, read=%d\n",
-            size, address, command, len, rw == I2C_SMBUS_READ);
+        dev_dbg(&adapter->dev,
+                "size=%d, address=0x%x, command=0x%x, len=%d, read=%d\n",
+                size, address, command, len, rw);
 
         if (!len && rw == I2C_SMBUS_READ) {
-                dev_warn(&adapter->dev, "zero length read\n");
+                dev_dbg(&adapter->dev, "zero length read\n");
                 return -EINVAL;
         }
 
-        if (len && !buffer) {
-                dev_warn(&adapter->dev, "nonzero length but no buffer\n");
-                return -EFAULT;
-        }
-
-        down(&iface->sem);
+        mutex_lock(&iface->mutex);
 
-        iface->address_byte = address<<1;
-        if (rw == I2C_SMBUS_READ)
-                iface->address_byte |= 1;
+        iface->address_byte = (address << 1) | rw;
         iface->command = command;
         iface->ptr = buffer;
         iface->len = len;
@@ -355,25 +331,21 @@ static s32 scx200_acb_smbus_xfer(struct i2c_adapter *adapter,
         else
                 iface->state = state_address;
 
-#ifdef POLLED_MODE
         while (iface->state != state_idle)
                 scx200_acb_poll(iface);
-#else /* POLLED_MODE */
-#error Interrupt driven mode not implemented
-#endif /* POLLED_MODE */        
 
         if (iface->needs_reset)
                 scx200_acb_reset(iface);
 
         rc = iface->result;
 
-        up(&iface->sem);
+        mutex_unlock(&iface->mutex);
 
         if (rc == 0 && size == I2C_SMBUS_WORD_DATA && rw == I2C_SMBUS_READ)
-                data->word = le16_to_cpu(cur_word);
+                data->word = le16_to_cpu(cur_word);
 
 #ifdef DEBUG
-        DBG(": transfer done, result: %d", rc);
+        dev_dbg(&adapter->dev, "transfer done, result: %d", rc);
         if (buffer) {
                 int i;
                 printk(" data:");
@@ -400,17 +372,18 @@ static struct i2c_algorithm scx200_acb_algorithm = {
 };
 
 static struct scx200_acb_iface *scx200_acb_list;
+static DECLARE_MUTEX(scx200_acb_list_mutex);
 
 static int scx200_acb_probe(struct scx200_acb_iface *iface)
 {
         u8 val;
 
         /* Disable the ACCESS.bus device and Configure the SCL
-           frequency: 16 clock cycles */
+           frequency: 16 clock cycles */
         outb(0x70, ACBCTL2);
 
         if (inb(ACBCTL2) != 0x70) {
-                DBG("ACBCTL2 readback failed\n");
+                pr_debug(NAME ": ACBCTL2 readback failed\n");
                 return -ENXIO;
         }
 
@@ -418,7 +391,8 @@ static int scx200_acb_probe(struct scx200_acb_iface *iface)
 
         val = inb(ACBCTL1);
         if (val) {
-                DBG("disabled, but ACBCTL1=0x%02x\n", val);
+                pr_debug(NAME ": disabled, but ACBCTL1=0x%02x\n",
+                        val);
                 return -ENXIO;
         }
 
@@ -428,18 +402,19 @@ static int scx200_acb_probe(struct scx200_acb_iface *iface)
 
         val = inb(ACBCTL1);
         if ((val & ACBCTL1_NMINTE) != ACBCTL1_NMINTE) {
-                DBG("enabled, but NMINTE won't be set, ACBCTL1=0x%02x\n", val);
+                pr_debug(NAME ": enabled, but NMINTE won't be set, "
+                         "ACBCTL1=0x%02x\n", val);
                 return -ENXIO;
         }
 
         return 0;
 }
 
-static int  __init scx200_acb_create(int base, int index)
+static int  __init scx200_acb_create(const char *text, int base, int index)
 {
         struct scx200_acb_iface *iface;
         struct i2c_adapter *adapter;
-        int rc = 0;
+        int rc;
         char description[64];
 
         iface = kzalloc(sizeof(*iface), GFP_KERNEL);
@@ -451,50 +426,51 @@ static int  __init scx200_acb_create(int base, int index)
 
         adapter = &iface->adapter;
         i2c_set_adapdata(adapter, iface);
-        snprintf(adapter->name, I2C_NAME_SIZE, "SCx200 ACB%d", index);
+        snprintf(adapter->name, I2C_NAME_SIZE, "%s ACB%d", text, index);
         adapter->owner = THIS_MODULE;
         adapter->id = I2C_HW_SMBUS_SCX200;
         adapter->algo = &scx200_acb_algorithm;
         adapter->class = I2C_CLASS_HWMON;
 
-        init_MUTEX(&iface->sem);
+        mutex_init(&iface->mutex);
+
+        snprintf(description, sizeof(description), "%s ACCESS.bus [%s]",
+                 text, adapter->name);
 
-        snprintf(description, sizeof(description), "NatSemi SCx200 ACCESS.bus [%s]", adapter->name);
         if (request_region(base, 8, description) == 0) {
-                dev_err(&adapter->dev, "can't allocate io 0x%x-0x%x\n",
+                printk(KERN_ERR NAME ": can't allocate io 0x%x-0x%x\n",
                         base, base + 8-1);
                 rc = -EBUSY;
-                goto errout;
+                goto errout_free;
         }
         iface->base = base;
 
         rc = scx200_acb_probe(iface);
         if (rc) {
-                dev_warn(&adapter->dev, "probe failed\n");
-                goto errout;
+                printk(KERN_WARNING NAME ": probe failed\n");
+                goto errout_release;
         }
 
         scx200_acb_reset(iface);
 
         if (i2c_add_adapter(adapter) < 0) {
-                dev_err(&adapter->dev, "failed to register\n");
+                printk(KERN_ERR NAME ": failed to register\n");
                 rc = -ENODEV;
-                goto errout;
+                goto errout_release;
         }
 
-        lock_kernel();
+        down(&scx200_acb_list_mutex);
         iface->next = scx200_acb_list;
         scx200_acb_list = iface;
-        unlock_kernel();
+        up(&scx200_acb_list_mutex);
 
         return 0;
 
+ errout_release:
+        release_region(iface->base, 8);
+ errout_free:
+        kfree(iface);
  errout:
-        if (iface) {
-                if (iface->base)
-                        release_region(iface->base, 8);
-                kfree(iface);
-        }
         return rc;
 }
 
@@ -504,50 +480,69 @@ static struct pci_device_id scx200[] = {
         { },
 };
 
+static struct pci_device_id divil_pci[] = {
+        { PCI_DEVICE(PCI_VENDOR_ID_NS,  PCI_DEVICE_ID_NS_CS5535_ISA) },
+        { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_ISA) },
+        { } /* NULL entry */
+};
+
+#define MSR_LBAR_SMB            0x5140000B
+
+static int scx200_add_cs553x(void)
+{
+        u32     low, hi;
+        u32     smb_base;
+
+        /* Grab & reserve the SMB I/O range */
+        rdmsr(MSR_LBAR_SMB, low, hi);
+
+        /* Check the IO mask and whether SMB is enabled */
+        if (hi != 0x0000F001) {
+                printk(KERN_WARNING NAME ": SMBus not enabled\n");
+                return -ENODEV;
+        }
+
+        /* SMBus IO size is 8 bytes */
+        smb_base = low & 0x0000FFF8;
+
+        return scx200_acb_create("CS5535", smb_base, 0);
+}
+
 static int __init scx200_acb_init(void)
 {
         int i;
-        int rc;
+        int     rc = -ENODEV;
 
         pr_debug(NAME ": NatSemi SCx200 ACCESS.bus Driver\n");
 
         /* Verify that this really is a SCx200 processor */
-        if (pci_dev_present(scx200) == 0)
-                return -ENODEV;
+        if (pci_dev_present(scx200)) {
+                for (i = 0; i < MAX_DEVICES; ++i) {
+                        if (base[i] > 0)
+                                rc = scx200_acb_create("SCx200", base[i], i);
+                }
+        } else if (pci_dev_present(divil_pci))
+                rc = scx200_add_cs553x();
 
-        rc = -ENXIO;
-        for (i = 0; i < MAX_DEVICES; ++i) {
-                if (base[i] > 0)
-                        rc = scx200_acb_create(base[i], i);
-        }
-        if (scx200_acb_list)
-                return 0;
         return rc;
 }
 
 static void __exit scx200_acb_cleanup(void)
 {
         struct scx200_acb_iface *iface;
-        lock_kernel();
+
+        down(&scx200_acb_list_mutex);
         while ((iface = scx200_acb_list) != NULL) {
                 scx200_acb_list = iface->next;
-                unlock_kernel();
+                up(&scx200_acb_list_mutex);
 
                 i2c_del_adapter(&iface->adapter);
                 release_region(iface->base, 8);
                 kfree(iface);
-                lock_kernel();
+                down(&scx200_acb_list_mutex);
         }
-        unlock_kernel();
+        up(&scx200_acb_list_mutex);
 }
 
 module_init(scx200_acb_init);
 module_exit(scx200_acb_cleanup);
-
-/*
-    Local variables:
-        compile-command: "make -k -C ../.. SUBDIRS=drivers/i2c modules"
-        c-basic-offset: 8
-    End:
-*/
-
diff --git a/drivers/i2c/chips/ds1374.c b/drivers/i2c/chips/ds1374.c
index 0710b9da9d54..03d09ed5ec2c 100644
--- a/drivers/i2c/chips/ds1374.c
+++ b/drivers/i2c/chips/ds1374.c
@@ -26,6 +26,7 @@
 #include <linux/i2c.h>
 #include <linux/rtc.h>
 #include <linux/bcd.h>
+#include <linux/mutex.h>
 
 #define DS1374_REG_TOD0         0x00
 #define DS1374_REG_TOD1         0x01
@@ -41,7 +42,7 @@
 
 #define DS1374_DRV_NAME         "ds1374"
 
-static DECLARE_MUTEX(ds1374_mutex);
+static DEFINE_MUTEX(ds1374_mutex);
 
 static struct i2c_driver ds1374_driver;
 static struct i2c_client *save_client;
@@ -114,7 +115,7 @@ ulong ds1374_get_rtc_time(void)
         ulong t1, t2;
         int limit = 10;         /* arbitrary retry limit */
 
-        down(&ds1374_mutex);
+        mutex_lock(&ds1374_mutex);
 
         /*
          * Since the reads are being performed one byte at a time using
@@ -127,7 +128,7 @@ ulong ds1374_get_rtc_time(void)
                 t2 = ds1374_read_rtc();
         } while (t1 != t2 && limit--);
 
-        up(&ds1374_mutex);
+        mutex_unlock(&ds1374_mutex);
 
         if (t1 != t2) {
                 dev_warn(&save_client->dev,
@@ -145,7 +146,7 @@ static void ds1374_set_tlet(ulong arg)
 
         t1 = *(ulong *) arg;
 
-        down(&ds1374_mutex);
+        mutex_lock(&ds1374_mutex);
 
         /*
          * Since the writes are being performed one byte at a time using
@@ -158,7 +159,7 @@ static void ds1374_set_tlet(ulong arg)
                 t2 = ds1374_read_rtc();
         } while (t1 != t2 && limit--);
 
-        up(&ds1374_mutex);
+        mutex_unlock(&ds1374_mutex);
 
         if (t1 != t2)
                 dev_warn(&save_client->dev,
diff --git a/drivers/i2c/chips/eeprom.c b/drivers/i2c/chips/eeprom.c
index 41116b7947f6..13c108269a6d 100644
--- a/drivers/i2c/chips/eeprom.c
+++ b/drivers/i2c/chips/eeprom.c
@@ -33,6 +33,7 @@
 #include <linux/sched.h>
 #include <linux/jiffies.h>
 #include <linux/i2c.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x50, 0x51, 0x52, 0x53, 0x54,
@@ -54,7 +55,7 @@ enum eeprom_nature {
 /* Each client has this additional data */
 struct eeprom_data {
         struct i2c_client client;
-        struct semaphore update_lock;
+        struct mutex update_lock;
         u8 valid;                       /* bitfield, bit!=0 if slice is valid */
         unsigned long last_updated[8];  /* In jiffies, 8 slices */
         u8 data[EEPROM_SIZE];           /* Register values */
@@ -81,7 +82,7 @@ static void eeprom_update_client(struct i2c_client *client, u8 slice)
         struct eeprom_data *data = i2c_get_clientdata(client);
         int i, j;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if (!(data->valid & (1 << slice)) ||
             time_after(jiffies, data->last_updated[slice] + 300 * HZ)) {
@@ -107,7 +108,7 @@ static void eeprom_update_client(struct i2c_client *client, u8 slice)
                 data->valid |= (1 << slice);
         }
 exit:
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 static ssize_t eeprom_read(struct kobject *kobj, char *buf, loff_t off, size_t count)
@@ -187,7 +188,7 @@ static int eeprom_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields */
         strlcpy(new_client->name, "eeprom", I2C_NAME_SIZE);
         data->valid = 0;
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
         data->nature = UNKNOWN;
 
         /* Tell the I2C layer a new client has arrived */
diff --git a/drivers/i2c/chips/isp1301_omap.c b/drivers/i2c/chips/isp1301_omap.c
index 1251c7fc18d5..e6f1ab7b913c 100644
--- a/drivers/i2c/chips/isp1301_omap.c
+++ b/drivers/i2c/chips/isp1301_omap.c
@@ -1635,8 +1635,6 @@ static struct i2c_driver isp1301_driver = {
         .driver = {
                 .name   = "isp1301_omap",
         },
-        .id             = 1301,         /* FIXME "official", i2c-ids.h */
-        .class          = I2C_CLASS_HWMON,
         .attach_adapter = isp1301_scan_bus,
         .detach_client  = isp1301_detach_client,
 };
diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c
index 2dc3d48375fc..b5aabe7cf792 100644
--- a/drivers/i2c/chips/m41t00.c
+++ b/drivers/i2c/chips/m41t00.c
@@ -24,13 +24,14 @@
 #include <linux/i2c.h>
 #include <linux/rtc.h>
 #include <linux/bcd.h>
+#include <linux/mutex.h>
 
 #include <asm/time.h>
 #include <asm/rtc.h>
 
 #define M41T00_DRV_NAME         "m41t00"
 
-static DECLARE_MUTEX(m41t00_mutex);
+static DEFINE_MUTEX(m41t00_mutex);
 
 static struct i2c_driver m41t00_driver;
 static struct i2c_client *save_client;
@@ -54,7 +55,7 @@ m41t00_get_rtc_time(void)
         sec = min = hour = day = mon = year = 0;
         sec1 = min1 = hour1 = day1 = mon1 = year1 = 0;
 
-        down(&m41t00_mutex);
+        mutex_lock(&m41t00_mutex);
         do {
                 if (((sec = i2c_smbus_read_byte_data(save_client, 0)) >= 0)
                         && ((min = i2c_smbus_read_byte_data(save_client, 1))
@@ -80,7 +81,7 @@ m41t00_get_rtc_time(void)
                 mon1 = mon;
                 year1 = year;
         } while (--limit > 0);
-        up(&m41t00_mutex);
+        mutex_unlock(&m41t00_mutex);
 
         if (limit == 0) {
                 dev_warn(&save_client->dev,
@@ -125,7 +126,7 @@ m41t00_set_tlet(ulong arg)
         BIN_TO_BCD(tm.tm_mday);
         BIN_TO_BCD(tm.tm_year);
 
-        down(&m41t00_mutex);
+        mutex_lock(&m41t00_mutex);
         if ((i2c_smbus_write_byte_data(save_client, 0, tm.tm_sec & 0x7f) < 0)
                 || (i2c_smbus_write_byte_data(save_client, 1, tm.tm_min & 0x7f)
                         < 0)
@@ -140,7 +141,7 @@ m41t00_set_tlet(ulong arg)
 
                 dev_warn(&save_client->dev,"m41t00: can't write to rtc chip\n");
 
-        up(&m41t00_mutex);
+        mutex_unlock(&m41t00_mutex);
         return;
 }
 
diff --git a/drivers/i2c/chips/max6875.c b/drivers/i2c/chips/max6875.c
index 6d3ff584155e..88d2ddee4490 100644
--- a/drivers/i2c/chips/max6875.c
+++ b/drivers/i2c/chips/max6875.c
@@ -31,7 +31,7 @@
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/i2c.h>
-#include <asm/semaphore.h>
+#include <linux/mutex.h>
 
 /* Do not scan - the MAX6875 access method will write to some EEPROM chips */
 static unsigned short normal_i2c[] = {I2C_CLIENT_END};
@@ -54,7 +54,7 @@ I2C_CLIENT_INSMOD_1(max6875);
 /* Each client has this additional data */
 struct max6875_data {
         struct i2c_client       client;
-        struct semaphore        update_lock;
+        struct mutex            update_lock;
 
         u32                     valid;
         u8                      data[USER_EEPROM_SIZE];
@@ -83,7 +83,7 @@ static void max6875_update_slice(struct i2c_client *client, int slice)
         if (slice >= USER_EEPROM_SLICES)
                 return;
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         buf = &data->data[slice << SLICE_BITS];
 
@@ -122,7 +122,7 @@ static void max6875_update_slice(struct i2c_client *client, int slice)
                 data->valid |= (1 << slice);
         }
 exit_up:
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 }
 
 static ssize_t max6875_read(struct kobject *kobj, char *buf, loff_t off,
@@ -196,7 +196,7 @@ static int max6875_detect(struct i2c_adapter *adapter, int address, int kind)
         real_client->driver = &max6875_driver;
         real_client->flags = 0;
         strlcpy(real_client->name, "max6875", I2C_NAME_SIZE);
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Init fake client data */
         /* set the client data to the i2c_client so that it will get freed */
diff --git a/drivers/i2c/chips/pcf8591.c b/drivers/i2c/chips/pcf8591.c
index 36cff09c678d..925a6b371fd2 100644
--- a/drivers/i2c/chips/pcf8591.c
+++ b/drivers/i2c/chips/pcf8591.c
@@ -24,6 +24,7 @@
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/i2c.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,
@@ -74,7 +75,7 @@ MODULE_PARM_DESC(input_mode,
 
 struct pcf8591_data {
         struct i2c_client client;
-        struct semaphore update_lock;
+        struct mutex update_lock;
 
         u8 control;
         u8 aout;
@@ -144,13 +145,13 @@ static ssize_t set_out0_enable(struct device *dev, struct device_attribute *attr
         struct pcf8591_data *data = i2c_get_clientdata(client);
         unsigned long val = simple_strtoul(buf, NULL, 10);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
         if (val)
                 data->control |= PCF8591_CONTROL_AOEF;
         else
                 data->control &= ~PCF8591_CONTROL_AOEF;
         i2c_smbus_write_byte(client, data->control);
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
         return count;
 }
 
@@ -200,7 +201,7 @@ static int pcf8591_detect(struct i2c_adapter *adapter, int address, int kind)
         /* Fill in the remaining client fields and put it into the global 
            list */
         strlcpy(new_client->name, "pcf8591", I2C_NAME_SIZE);
-        init_MUTEX(&data->update_lock);
+        mutex_init(&data->update_lock);
 
         /* Tell the I2C layer a new client has arrived */
         if ((err = i2c_attach_client(new_client)))
@@ -265,7 +266,7 @@ static int pcf8591_read_channel(struct device *dev, int channel)
         struct i2c_client *client = to_i2c_client(dev);
         struct pcf8591_data *data = i2c_get_clientdata(client);
 
-        down(&data->update_lock);
+        mutex_lock(&data->update_lock);
 
         if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel) {
                 data->control = (data->control & ~PCF8591_CONTROL_AICH_MASK)
@@ -278,7 +279,7 @@ static int pcf8591_read_channel(struct device *dev, int channel)
         }
         value = i2c_smbus_read_byte(client);
 
-        up(&data->update_lock);
+        mutex_unlock(&data->update_lock);
 
         if ((channel == 2 && input_mode == 2) ||
             (channel != 3 && (input_mode == 1 || input_mode == 3)))
diff --git a/drivers/i2c/chips/tps65010.c b/drivers/i2c/chips/tps65010.c
index 1af3dfbb8086..179b1e022d80 100644
--- a/drivers/i2c/chips/tps65010.c
+++ b/drivers/i2c/chips/tps65010.c
@@ -32,6 +32,7 @@
 #include <linux/suspend.h>
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
+#include <linux/mutex.h>
 
 #include <asm/irq.h>
 #include <asm/mach-types.h>
@@ -81,7 +82,7 @@ enum tps_model {
 
 struct tps65010 {
         struct i2c_client       client;
-        struct semaphore        lock;
+        struct mutex            lock;
         int                     irq;
         struct work_struct      work;
         struct dentry           *file;
@@ -218,7 +219,7 @@ static int dbg_show(struct seq_file *s, void *_)
         seq_printf(s, "driver  %s\nversion %s\nchip    %s\n\n",
                         DRIVER_NAME, DRIVER_VERSION, chip);
 
-        down(&tps->lock);
+        mutex_lock(&tps->lock);
 
         /* FIXME how can we tell whether a battery is present?
          * likely involves a charge gauging chip (like BQ26501).
@@ -300,7 +301,7 @@ static int dbg_show(struct seq_file *s, void *_)
                                 (v2 & (1 << (4 + i))) ? "rising" : "falling");
         }
 
-        up(&tps->lock);
+        mutex_unlock(&tps->lock);
         return 0;
 }
 
@@ -416,7 +417,7 @@ static void tps65010_work(void *_tps)
 {
         struct tps65010         *tps = _tps;
 
-        down(&tps->lock);
+        mutex_lock(&tps->lock);
 
         tps65010_interrupt(tps);
 
@@ -444,7 +445,7 @@ static void tps65010_work(void *_tps)
         if (test_and_clear_bit(FLAG_IRQ_ENABLE, &tps->flags))
                 enable_irq(tps->irq);
 
-        up(&tps->lock);
+        mutex_unlock(&tps->lock);
 }
 
 static irqreturn_t tps65010_irq(int irq, void *_tps, struct pt_regs *regs)
@@ -505,7 +506,7 @@ tps65010_probe(struct i2c_adapter *bus, int address, int kind)
         if (!tps)
                 return 0;
 
-        init_MUTEX(&tps->lock);
+        mutex_init(&tps->lock);
         INIT_WORK(&tps->work, tps65010_work, tps);
         tps->irq = -1;
         tps->client.addr = address;
@@ -695,7 +696,7 @@ int tps65010_set_gpio_out_value(unsigned gpio, unsigned value)
         if ((gpio < GPIO1) || (gpio > GPIO4))
                 return -EINVAL;
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         defgpio = i2c_smbus_read_byte_data(&the_tps->client, TPS_DEFGPIO);
 
@@ -720,7 +721,7 @@ int tps65010_set_gpio_out_value(unsigned gpio, unsigned value)
                 gpio, value ? "high" : "low",
                 i2c_smbus_read_byte_data(&the_tps->client, TPS_DEFGPIO));
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
         return status;
 }
 EXPORT_SYMBOL(tps65010_set_gpio_out_value);
@@ -745,7 +746,7 @@ int tps65010_set_led(unsigned led, unsigned mode)
                 led = LED2;
         }
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         pr_debug("%s: led%i_on   0x%02x\n", DRIVER_NAME, led,
                 i2c_smbus_read_byte_data(&the_tps->client,
@@ -771,7 +772,7 @@ int tps65010_set_led(unsigned led, unsigned mode)
         default:
                 printk(KERN_ERR "%s: Wrong mode parameter for set_led()\n",
                        DRIVER_NAME);
-                up(&the_tps->lock);
+                mutex_unlock(&the_tps->lock);
                 return -EINVAL;
         }
 
@@ -781,7 +782,7 @@ int tps65010_set_led(unsigned led, unsigned mode)
         if (status != 0) {
                 printk(KERN_ERR "%s: Failed to write led%i_on register\n",
                        DRIVER_NAME, led);
-                up(&the_tps->lock);
+                mutex_unlock(&the_tps->lock);
                 return status;
         }
 
@@ -794,7 +795,7 @@ int tps65010_set_led(unsigned led, unsigned mode)
         if (status != 0) {
                 printk(KERN_ERR "%s: Failed to write led%i_per register\n",
                        DRIVER_NAME, led);
-                up(&the_tps->lock);
+                mutex_unlock(&the_tps->lock);
                 return status;
         }
 
@@ -802,7 +803,7 @@ int tps65010_set_led(unsigned led, unsigned mode)
                 i2c_smbus_read_byte_data(&the_tps->client,
                                 TPS_LED1_PER + offs));
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
 
         return status;
 }
@@ -820,7 +821,7 @@ int tps65010_set_vib(unsigned value)
         if (!the_tps)
                 return -ENODEV;
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         vdcdc2 = i2c_smbus_read_byte_data(&the_tps->client, TPS_VDCDC2);
         vdcdc2 &= ~(1 << 1);
@@ -831,7 +832,7 @@ int tps65010_set_vib(unsigned value)
 
         pr_debug("%s: vibrator %s\n", DRIVER_NAME, value ? "on" : "off");
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
         return status;
 }
 EXPORT_SYMBOL(tps65010_set_vib);
@@ -848,7 +849,7 @@ int tps65010_set_low_pwr(unsigned mode)
         if (!the_tps)
                 return -ENODEV;
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         pr_debug("%s: %s low_pwr, vdcdc1 0x%02x\n", DRIVER_NAME,
                 mode ? "enable" : "disable",
@@ -876,7 +877,7 @@ int tps65010_set_low_pwr(unsigned mode)
                 pr_debug("%s: vdcdc1 0x%02x\n", DRIVER_NAME,
                         i2c_smbus_read_byte_data(&the_tps->client, TPS_VDCDC1));
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
 
         return status;
 }
@@ -894,7 +895,7 @@ int tps65010_config_vregs1(unsigned value)
         if (!the_tps)
                 return -ENODEV;
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         pr_debug("%s: vregs1 0x%02x\n", DRIVER_NAME,
                         i2c_smbus_read_byte_data(&the_tps->client, TPS_VREGS1));
@@ -909,7 +910,7 @@ int tps65010_config_vregs1(unsigned value)
                 pr_debug("%s: vregs1 0x%02x\n", DRIVER_NAME,
                         i2c_smbus_read_byte_data(&the_tps->client, TPS_VREGS1));
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
 
         return status;
 }
@@ -931,7 +932,7 @@ int tps65013_set_low_pwr(unsigned mode)
         if (!the_tps || the_tps->por)
                 return -ENODEV;
 
-        down(&the_tps->lock);
+        mutex_lock(&the_tps->lock);
 
         pr_debug("%s: %s low_pwr, chgconfig 0x%02x vdcdc1 0x%02x\n",
                 DRIVER_NAME,
@@ -959,7 +960,7 @@ int tps65013_set_low_pwr(unsigned mode)
         if (status != 0) {
                 printk(KERN_ERR "%s: Failed to write chconfig register\n",
          DRIVER_NAME);
-                up(&the_tps->lock);
+                mutex_unlock(&the_tps->lock);
                 return status;
         }
 
@@ -977,7 +978,7 @@ int tps65013_set_low_pwr(unsigned mode)
                 pr_debug("%s: vdcdc1 0x%02x\n", DRIVER_NAME,
                         i2c_smbus_read_byte_data(&the_tps->client, TPS_VDCDC1));
 
-        up(&the_tps->lock);
+        mutex_unlock(&the_tps->lock);
 
         return status;
 }
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 1a2c9ab5d9e3..45e2cdf54736 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -31,12 +31,13 @@
 #include <linux/idr.h>
 #include <linux/seq_file.h>
 #include <linux/platform_device.h>
+#include <linux/mutex.h>
 #include <asm/uaccess.h>
 
 
 static LIST_HEAD(adapters);
 static LIST_HEAD(drivers);
-static DECLARE_MUTEX(core_lists);
+static DEFINE_MUTEX(core_lists);
 static DEFINE_IDR(i2c_adapter_idr);
 
 /* match always succeeds, as we want the probe() to tell if we really accept this match */
@@ -153,7 +154,7 @@ int i2c_add_adapter(struct i2c_adapter *adap)
         struct list_head   *item;
         struct i2c_driver  *driver;
 
-        down(&core_lists);
+        mutex_lock(&core_lists);
 
         if (idr_pre_get(&i2c_adapter_idr, GFP_KERNEL) == 0) {
                 res = -ENOMEM;
@@ -168,8 +169,8 @@ int i2c_add_adapter(struct i2c_adapter *adap)
         }
 
         adap->nr =  id & MAX_ID_MASK;
-        init_MUTEX(&adap->bus_lock);
-        init_MUTEX(&adap->clist_lock);
+        mutex_init(&adap->bus_lock);
+        mutex_init(&adap->clist_lock);
         list_add_tail(&adap->list,&adapters);
         INIT_LIST_HEAD(&adap->clients);
 
@@ -203,7 +204,7 @@ int i2c_add_adapter(struct i2c_adapter *adap)
         }
 
 out_unlock:
-        up(&core_lists);
+        mutex_unlock(&core_lists);
         return res;
 }
 
@@ -216,7 +217,7 @@ int i2c_del_adapter(struct i2c_adapter *adap)
         struct i2c_client *client;
         int res = 0;
 
-        down(&core_lists);
+        mutex_lock(&core_lists);
 
         /* First make sure that this adapter was ever added */
         list_for_each_entry(adap_from_list, &adapters, list) {
@@ -272,7 +273,7 @@ int i2c_del_adapter(struct i2c_adapter *adap)
         dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
 
  out_unlock:
-        up(&core_lists);
+        mutex_unlock(&core_lists);
         return res;
 }
 
@@ -287,9 +288,7 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 {
         struct list_head   *item;
         struct i2c_adapter *adapter;
-        int res = 0;
-
-        down(&core_lists);
+        int res;
 
         /* add the driver to the list of i2c drivers in the driver core */
         driver->driver.owner = owner;
@@ -297,8 +296,10 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 
         res = driver_register(&driver->driver);
         if (res)
-                goto out_unlock;
+                return res;
         
+        mutex_lock(&core_lists);
+
         list_add_tail(&driver->list,&drivers);
         pr_debug("i2c-core: driver [%s] registered\n", driver->driver.name);
 
@@ -310,9 +311,8 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
                 }
         }
 
- out_unlock:
-        up(&core_lists);
-        return res;
+        mutex_unlock(&core_lists);
+        return 0;
 }
 EXPORT_SYMBOL(i2c_register_driver);
 
@@ -324,7 +324,7 @@ int i2c_del_driver(struct i2c_driver *driver)
         
         int res = 0;
 
-        down(&core_lists);
+        mutex_lock(&core_lists);
 
         /* Have a look at each adapter, if clients of this driver are still
          * attached. If so, detach them to be able to kill the driver 
@@ -363,7 +363,7 @@ int i2c_del_driver(struct i2c_driver *driver)
         pr_debug("i2c-core: driver [%s] unregistered\n", driver->driver.name);
 
  out_unlock:
-        up(&core_lists);
+        mutex_unlock(&core_lists);
         return 0;
 }
 
@@ -384,9 +384,9 @@ int i2c_check_addr(struct i2c_adapter *adapter, int addr)
 {
         int rval;
 
-        down(&adapter->clist_lock);
+        mutex_lock(&adapter->clist_lock);
         rval = __i2c_check_addr(adapter, addr);
-        up(&adapter->clist_lock);
+        mutex_unlock(&adapter->clist_lock);
 
         return rval;
 }
@@ -395,13 +395,13 @@ int i2c_attach_client(struct i2c_client *client)
 {
         struct i2c_adapter *adapter = client->adapter;
 
-        down(&adapter->clist_lock);
+        mutex_lock(&adapter->clist_lock);
         if (__i2c_check_addr(client->adapter, client->addr)) {
-                up(&adapter->clist_lock);
+                mutex_unlock(&adapter->clist_lock);
                 return -EBUSY;
         }
         list_add_tail(&client->list,&adapter->clients);
-        up(&adapter->clist_lock);
+        mutex_unlock(&adapter->clist_lock);
         
         if (adapter->client_register)  {
                 if (adapter->client_register(client))  {
@@ -450,12 +450,12 @@ int i2c_detach_client(struct i2c_client *client)
                 }
         }
 
-        down(&adapter->clist_lock);
+        mutex_lock(&adapter->clist_lock);
         list_del(&client->list);
         init_completion(&client->released);
         device_remove_file(&client->dev, &dev_attr_client_name);
         device_unregister(&client->dev);
-        up(&adapter->clist_lock);
+        mutex_unlock(&adapter->clist_lock);
         wait_for_completion(&client->released);
 
  out:
@@ -513,19 +513,19 @@ void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
         struct list_head  *item;
         struct i2c_client *client;
 
-        down(&adap->clist_lock);
+        mutex_lock(&adap->clist_lock);
         list_for_each(item,&adap->clients) {
                 client = list_entry(item, struct i2c_client, list);
                 if (!try_module_get(client->driver->driver.owner))
                         continue;
                 if (NULL != client->driver->command) {
-                        up(&adap->clist_lock);
+                        mutex_unlock(&adap->clist_lock);
                         client->driver->command(client,cmd,arg);
-                        down(&adap->clist_lock);
+                        mutex_lock(&adap->clist_lock);
                 }
                 module_put(client->driver->driver.owner);
        }
-       up(&adap->clist_lock);
+       mutex_unlock(&adap->clist_lock);
 }
 
 static int __init i2c_init(void)
@@ -569,9 +569,9 @@ int i2c_transfer(struct i2c_adapter * adap, struct i2c_msg *msgs, int num)
                 }
 #endif
 
-                down(&adap->bus_lock);
+                mutex_lock(&adap->bus_lock);
                 ret = adap->algo->master_xfer(adap,msgs,num);
-                up(&adap->bus_lock);
+                mutex_unlock(&adap->bus_lock);
 
                 return ret;
         } else {
@@ -779,12 +779,12 @@ struct i2c_adapter* i2c_get_adapter(int id)
 {
         struct i2c_adapter *adapter;
         
-        down(&core_lists);
+        mutex_lock(&core_lists);
         adapter = (struct i2c_adapter *)idr_find(&i2c_adapter_idr, id);
         if (adapter && !try_module_get(adapter->owner))
                 adapter = NULL;
 
-        up(&core_lists);
+        mutex_unlock(&core_lists);
         return adapter;
 }
 
@@ -919,12 +919,11 @@ s32 i2c_smbus_write_block_data(struct i2c_client *client, u8 command,
                                u8 length, u8 *values)
 {
         union i2c_smbus_data data;
-        int i;
+
         if (length > I2C_SMBUS_BLOCK_MAX)
                 length = I2C_SMBUS_BLOCK_MAX;
-        for (i = 1; i <= length; i++)
-                data.block[i] = values[i-1];
         data.block[0] = length;
+        memcpy(&data.block[1], values, length);
         return i2c_smbus_xfer(client->adapter,client->addr,client->flags,
                               I2C_SMBUS_WRITE,command,
                               I2C_SMBUS_BLOCK_DATA,&data);
@@ -934,16 +933,14 @@ s32 i2c_smbus_write_block_data(struct i2c_client *client, u8 command,
 s32 i2c_smbus_read_i2c_block_data(struct i2c_client *client, u8 command, u8 *values)
 {
         union i2c_smbus_data data;
-        int i;
+
         if (i2c_smbus_xfer(client->adapter,client->addr,client->flags,
                               I2C_SMBUS_READ,command,
                               I2C_SMBUS_I2C_BLOCK_DATA,&data))
                 return -1;
-        else {
-                for (i = 1; i <= data.block[0]; i++)
-                        values[i-1] = data.block[i];
-                return data.block[0];
-        }
+
+        memcpy(values, &data.block[1], data.block[0]);
+        return data.block[0];
 }
 
 s32 i2c_smbus_write_i2c_block_data(struct i2c_client *client, u8 command,
@@ -1118,10 +1115,10 @@ s32 i2c_smbus_xfer(struct i2c_adapter * adapter, u16 addr, unsigned short flags,
         flags &= I2C_M_TEN | I2C_CLIENT_PEC;
 
         if (adapter->algo->smbus_xfer) {
-                down(&adapter->bus_lock);
+                mutex_lock(&adapter->bus_lock);
                 res = adapter->algo->smbus_xfer(adapter,addr,flags,read_write,
                                                 command,size,data);
-                up(&adapter->bus_lock);
+                mutex_unlock(&adapter->bus_lock);
         } else
                 res = i2c_smbus_xfer_emulated(adapter,addr,flags,read_write,
                                               command,size,data);
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 3325660f7248..c7671e188017 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -313,6 +313,7 @@
 #include <linux/cdrom.h>
 #include <linux/ide.h>
 #include <linux/completion.h>
+#include <linux/mutex.h>
 
 #include <scsi/scsi.h>  /* For SCSI -> ATAPI command conversion */
 
@@ -324,7 +325,7 @@
 
 #include "ide-cd.h"
 
-static DECLARE_MUTEX(idecd_ref_sem);
+static DEFINE_MUTEX(idecd_ref_mutex);
 
 #define to_ide_cd(obj) container_of(obj, struct cdrom_info, kref) 
 
@@ -335,11 +336,11 @@ static struct cdrom_info *ide_cd_get(struct gendisk *disk)
 {
         struct cdrom_info *cd = NULL;
 
-        down(&idecd_ref_sem);
+        mutex_lock(&idecd_ref_mutex);
         cd = ide_cd_g(disk);
         if (cd)
                 kref_get(&cd->kref);
-        up(&idecd_ref_sem);
+        mutex_unlock(&idecd_ref_mutex);
         return cd;
 }
 
@@ -347,9 +348,9 @@ static void ide_cd_release(struct kref *);
 
 static void ide_cd_put(struct cdrom_info *cd)
 {
-        down(&idecd_ref_sem);
+        mutex_lock(&idecd_ref_mutex);
         kref_put(&cd->kref, ide_cd_release);
-        up(&idecd_ref_sem);
+        mutex_unlock(&idecd_ref_mutex);
 }
 
 /****************************************************************************
@@ -2471,52 +2472,6 @@ static int ide_cdrom_packet(struct cdrom_device_info *cdi,
 }
 
 static
-int ide_cdrom_dev_ioctl (struct cdrom_device_info *cdi,
-                         unsigned int cmd, unsigned long arg)
-{
-        struct packet_command cgc;
-        char buffer[16];
-        int stat;
-
-        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
-
-        /* These will be moved into the Uniform layer shortly... */
-        switch (cmd) {
-        case CDROMSETSPINDOWN: {
-                char spindown;
- 
-                if (copy_from_user(&spindown, (void __user *) arg, sizeof(char)))
-                        return -EFAULT;
- 
-                if ((stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0)))
-                        return stat;
-
-                buffer[11] = (buffer[11] & 0xf0) | (spindown & 0x0f);
-
-                return cdrom_mode_select(cdi, &cgc);
-        } 
- 
-        case CDROMGETSPINDOWN: {
-                char spindown;
- 
-                if ((stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0)))
-                        return stat;
- 
-                spindown = buffer[11] & 0x0f;
- 
-                if (copy_to_user((void __user *) arg, &spindown, sizeof (char)))
-                        return -EFAULT;
- 
-                return 0;
-        }
-  
-        default:
-                return -EINVAL;
-        }
-
-}
-
-static
 int ide_cdrom_audio_ioctl (struct cdrom_device_info *cdi,
                            unsigned int cmd, void *arg)
                            
@@ -2852,12 +2807,11 @@ static struct cdrom_device_ops ide_cdrom_dops = {
         .get_mcn                = ide_cdrom_get_mcn,
         .reset                  = ide_cdrom_reset,
         .audio_ioctl            = ide_cdrom_audio_ioctl,
-        .dev_ioctl              = ide_cdrom_dev_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                 CDC_SELECT_SPEED | CDC_SELECT_DISC |
                                 CDC_MULTI_SESSION | CDC_MCN |
                                 CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET |
-                                CDC_IOCTLS | CDC_DRIVE_STATUS | CDC_CD_R |
+                                CDC_DRIVE_STATUS | CDC_CD_R |
                                 CDC_CD_RW | CDC_DVD | CDC_DVD_R| CDC_DVD_RAM |
                                 CDC_GENERIC_PACKET | CDC_MO_DRIVE | CDC_MRW |
                                 CDC_MRW_W | CDC_RAM,
@@ -3367,6 +3321,45 @@ static int idecd_release(struct inode * inode, struct file * file)
         return 0;
 }
 
+static int idecd_set_spindown(struct cdrom_device_info *cdi, unsigned long arg)
+{
+        struct packet_command cgc;
+        char buffer[16];
+        int stat;
+        char spindown;
+
+        if (copy_from_user(&spindown, (void __user *)arg, sizeof(char)))
+                return -EFAULT;
+
+        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
+
+        stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0);
+        if (stat)
+                return stat;
+
+        buffer[11] = (buffer[11] & 0xf0) | (spindown & 0x0f);
+        return cdrom_mode_select(cdi, &cgc);
+}
+
+static int idecd_get_spindown(struct cdrom_device_info *cdi, unsigned long arg)
+{
+        struct packet_command cgc;
+        char buffer[16];
+        int stat;
+        char spindown;
+
+        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
+
+        stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0);
+        if (stat)
+                return stat;
+
+        spindown = buffer[11] & 0x0f;
+        if (copy_to_user((void __user *)arg, &spindown, sizeof (char)))
+                return -EFAULT;
+        return 0;
+}
+
 static int idecd_ioctl (struct inode *inode, struct file *file,
                         unsigned int cmd, unsigned long arg)
 {
@@ -3374,7 +3367,16 @@ static int idecd_ioctl (struct inode *inode, struct file *file,
         struct cdrom_info *info = ide_cd_g(bdev->bd_disk);
         int err;
 
-        err  = generic_ide_ioctl(info->drive, file, bdev, cmd, arg);
+        switch (cmd) {
+        case CDROMSETSPINDOWN:
+                return idecd_set_spindown(&info->devinfo, arg);
+        case CDROMGETSPINDOWN:
+                return idecd_get_spindown(&info->devinfo, arg);
+        default:
+                break;
+        }
+
+        err = generic_ide_ioctl(info->drive, file, bdev, cmd, arg);
         if (err == -EINVAL)
                 err = cdrom_ioctl(file, &info->devinfo, inode, cmd, arg);
 
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 09086b8b6486..e238b7da824b 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -60,6 +60,7 @@
 #include <linux/genhd.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/mutex.h>
 
 #define _IDE_DISK
 
@@ -78,7 +79,7 @@ struct ide_disk_obj {
         struct kref     kref;
 };
 
-static DECLARE_MUTEX(idedisk_ref_sem);
+static DEFINE_MUTEX(idedisk_ref_mutex);
 
 #define to_ide_disk(obj) container_of(obj, struct ide_disk_obj, kref)
 
@@ -89,11 +90,11 @@ static struct ide_disk_obj *ide_disk_get(struct gendisk *disk)
 {
         struct ide_disk_obj *idkp = NULL;
 
-        down(&idedisk_ref_sem);
+        mutex_lock(&idedisk_ref_mutex);
         idkp = ide_disk_g(disk);
         if (idkp)
                 kref_get(&idkp->kref);
-        up(&idedisk_ref_sem);
+        mutex_unlock(&idedisk_ref_mutex);
         return idkp;
 }
 
@@ -101,9 +102,9 @@ static void ide_disk_release(struct kref *);
 
 static void ide_disk_put(struct ide_disk_obj *idkp)
 {
-        down(&idedisk_ref_sem);
+        mutex_lock(&idedisk_ref_mutex);
         kref_put(&idkp->kref, ide_disk_release);
-        up(&idedisk_ref_sem);
+        mutex_unlock(&idedisk_ref_mutex);
 }
 
 /*
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 1f8db9ac05d1..a53e3ce4a142 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -98,6 +98,7 @@
 #include <linux/cdrom.h>
 #include <linux/ide.h>
 #include <linux/bitops.h>
+#include <linux/mutex.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -517,7 +518,7 @@ typedef struct {
         u8              reserved[4];
 } idefloppy_mode_parameter_header_t;
 
-static DECLARE_MUTEX(idefloppy_ref_sem);
+static DEFINE_MUTEX(idefloppy_ref_mutex);
 
 #define to_ide_floppy(obj) container_of(obj, struct ide_floppy_obj, kref)
 
@@ -528,11 +529,11 @@ static struct ide_floppy_obj *ide_floppy_get(struct gendisk *disk)
 {
         struct ide_floppy_obj *floppy = NULL;
 
-        down(&idefloppy_ref_sem);
+        mutex_lock(&idefloppy_ref_mutex);
         floppy = ide_floppy_g(disk);
         if (floppy)
                 kref_get(&floppy->kref);
-        up(&idefloppy_ref_sem);
+        mutex_unlock(&idefloppy_ref_mutex);
         return floppy;
 }
 
@@ -540,9 +541,9 @@ static void ide_floppy_release(struct kref *);
 
 static void ide_floppy_put(struct ide_floppy_obj *floppy)
 {
-        down(&idefloppy_ref_sem);
+        mutex_lock(&idefloppy_ref_mutex);
         kref_put(&floppy->kref, ide_floppy_release);
-        up(&idefloppy_ref_sem);
+        mutex_unlock(&idefloppy_ref_mutex);
 }
 
 /*
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 0101d0def7c5..ebc59064b475 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -443,6 +443,7 @@
 #include <linux/smp_lock.h>
 #include <linux/completion.h>
 #include <linux/bitops.h>
+#include <linux/mutex.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -1011,7 +1012,7 @@ typedef struct ide_tape_obj {
          int debug_level; 
 } idetape_tape_t;
 
-static DECLARE_MUTEX(idetape_ref_sem);
+static DEFINE_MUTEX(idetape_ref_mutex);
 
 static struct class *idetape_sysfs_class;
 
@@ -1024,11 +1025,11 @@ static struct ide_tape_obj *ide_tape_get(struct gendisk *disk)
 {
         struct ide_tape_obj *tape = NULL;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         tape = ide_tape_g(disk);
         if (tape)
                 kref_get(&tape->kref);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
         return tape;
 }
 
@@ -1036,9 +1037,9 @@ static void ide_tape_release(struct kref *);
 
 static void ide_tape_put(struct ide_tape_obj *tape)
 {
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         kref_put(&tape->kref, ide_tape_release);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
 }
 
 /*
@@ -1290,11 +1291,11 @@ static struct ide_tape_obj *ide_tape_chrdev_get(unsigned int i)
 {
         struct ide_tape_obj *tape = NULL;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         tape = idetape_devs[i];
         if (tape)
                 kref_get(&tape->kref);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
         return tape;
 }
 
@@ -4870,11 +4871,11 @@ static int ide_tape_probe(ide_drive_t *drive)
 
         drive->driver_data = tape;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         for (minor = 0; idetape_devs[minor]; minor++)
                 ;
         idetape_devs[minor] = tape;
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
 
         idetape_setup(drive, tape, minor);
 
diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c
index feec40cf5900..8c4fcb9027b3 100644
--- a/drivers/isdn/capi/kcapi.c
+++ b/drivers/isdn/capi/kcapi.c
@@ -32,6 +32,7 @@
 #ifdef CONFIG_AVMB1_COMPAT
 #include <linux/b1lli.h>
 #endif
+#include <linux/mutex.h>
 
 static char *revision = "$Revision: 1.1.2.8 $";
 
@@ -66,7 +67,7 @@ LIST_HEAD(capi_drivers);
 DEFINE_RWLOCK(capi_drivers_list_lock);
 
 static DEFINE_RWLOCK(application_lock);
-static DECLARE_MUTEX(controller_sem);
+static DEFINE_MUTEX(controller_mutex);
 
 struct capi20_appl *capi_applications[CAPI_MAXAPPL];
 struct capi_ctr *capi_cards[CAPI_MAXCONTR];
@@ -395,20 +396,20 @@ attach_capi_ctr(struct capi_ctr *card)
 {
         int i;
 
-        down(&controller_sem);
+        mutex_lock(&controller_mutex);
 
         for (i = 0; i < CAPI_MAXCONTR; i++) {
                 if (capi_cards[i] == NULL)
                         break;
         }
         if (i == CAPI_MAXCONTR) {
-                up(&controller_sem);
+                mutex_unlock(&controller_mutex);
                 printk(KERN_ERR "kcapi: out of controller slots\n");
                 return -EBUSY;
         }
         capi_cards[i] = card;
 
-        up(&controller_sem);
+        mutex_unlock(&controller_mutex);
 
         card->nrecvctlpkt = 0;
         card->nrecvdatapkt = 0;
@@ -531,13 +532,13 @@ u16 capi20_register(struct capi20_appl *ap)
 
         write_unlock_irqrestore(&application_lock, flags);
         
-        down(&controller_sem);
+        mutex_lock(&controller_mutex);
         for (i = 0; i < CAPI_MAXCONTR; i++) {
                 if (!capi_cards[i] || capi_cards[i]->cardstate != CARD_RUNNING)
                         continue;
                 register_appl(capi_cards[i], applid, &ap->rparam);
         }
-        up(&controller_sem);
+        mutex_unlock(&controller_mutex);
 
         if (showcapimsgs & 1) {
                 printk(KERN_DEBUG "kcapi: appl %d up\n", applid);
@@ -560,13 +561,13 @@ u16 capi20_release(struct capi20_appl *ap)
         capi_applications[ap->applid - 1] = NULL;
         write_unlock_irqrestore(&application_lock, flags);
 
-        down(&controller_sem);
+        mutex_lock(&controller_mutex);
         for (i = 0; i < CAPI_MAXCONTR; i++) {
                 if (!capi_cards[i] || capi_cards[i]->cardstate != CARD_RUNNING)
                         continue;
                 release_appl(capi_cards[i], ap->applid);
         }
-        up(&controller_sem);
+        mutex_unlock(&controller_mutex);
 
         flush_scheduled_work();
         skb_queue_purge(&ap->recv_queue);
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index df9d65201819..27332506f9f7 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -25,7 +25,6 @@
 #include <linux/workqueue.h>
 #include <linux/interrupt.h>
 #define HISAX_STATUS_BUFSIZE 4096
-#define INCLUDE_INLINE_FUNCS
 
 /*
  * This structure array contains one entry per card. An entry looks
diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c
index 110e9fd669c5..f8ca4b323331 100644
--- a/drivers/isdn/hisax/elsa.c
+++ b/drivers/isdn/hisax/elsa.c
@@ -108,7 +108,6 @@ static const char *ITACVer[] =
 #define ELSA_ASSIGN      4
 
 #define RS_ISR_PASS_LIMIT 256
-#define _INLINE_ inline
 #define FLG_MODEM_ACTIVE 1
 /* IPAC AUX */
 #define ELSA_IPAC_LINE_LED      0x40    /* Bit 6 Gelbe LED */
diff --git a/drivers/media/video/adv7170.c b/drivers/media/video/adv7170.c
index d18bf9097dc9..671e36db224d 100644
--- a/drivers/media/video/adv7170.c
+++ b/drivers/media/video/adv7170.c
@@ -53,7 +53,6 @@ MODULE_AUTHOR("Maxim Yevtyushkin");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(x) (x)->name
 
diff --git a/drivers/media/video/adv7175.c b/drivers/media/video/adv7175.c
index 1a2b111897d5..085e8863cacb 100644
--- a/drivers/media/video/adv7175.c
+++ b/drivers/media/video/adv7175.c
@@ -49,7 +49,6 @@ MODULE_AUTHOR("Dave Perks");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/bt819.c b/drivers/media/video/bt819.c
index c2c450fbf683..d8a18a6a5bee 100644
--- a/drivers/media/video/bt819.c
+++ b/drivers/media/video/bt819.c
@@ -53,7 +53,6 @@ MODULE_AUTHOR("Mike Bernson & Dave Perks");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/bt856.c b/drivers/media/video/bt856.c
index 7c68937853b0..4d47a0a0e974 100644
--- a/drivers/media/video/bt856.c
+++ b/drivers/media/video/bt856.c
@@ -53,7 +53,6 @@ MODULE_AUTHOR("Mike Bernson & Dave Perks");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/saa7110.c b/drivers/media/video/saa7110.c
index 36123fa0b63f..e18ea268384b 100644
--- a/drivers/media/video/saa7110.c
+++ b/drivers/media/video/saa7110.c
@@ -39,7 +39,6 @@ MODULE_AUTHOR("Pauline Middelink");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/saa7111.c b/drivers/media/video/saa7111.c
index cb27917c376a..f9ba0c943adf 100644
--- a/drivers/media/video/saa7111.c
+++ b/drivers/media/video/saa7111.c
@@ -52,7 +52,6 @@ MODULE_AUTHOR("Dave Perks");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/saa7114.c b/drivers/media/video/saa7114.c
index 849b54cd5c24..4a1f841d0c77 100644
--- a/drivers/media/video/saa7114.c
+++ b/drivers/media/video/saa7114.c
@@ -55,7 +55,6 @@ MODULE_AUTHOR("Maxim Yevtyushkin");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(x) (x)->name
 
diff --git a/drivers/media/video/saa711x.c b/drivers/media/video/saa711x.c
index 6c161f2f5e2c..708fae51e8ee 100644
--- a/drivers/media/video/saa711x.c
+++ b/drivers/media/video/saa711x.c
@@ -45,7 +45,6 @@ MODULE_AUTHOR("Dave Perks, Jose Ignacio Gijon, Joerg Heckenbach, Mark McClelland
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/saa7185.c b/drivers/media/video/saa7185.c
index 67dfa7186453..9f99ee1303e0 100644
--- a/drivers/media/video/saa7185.c
+++ b/drivers/media/video/saa7185.c
@@ -49,7 +49,6 @@ MODULE_AUTHOR("Dave Perks");
 MODULE_LICENSE("GPL");
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(s) (s)->name
 
diff --git a/drivers/media/video/vpx3220.c b/drivers/media/video/vpx3220.c
index d0a1e72ea8c4..4cd579967487 100644
--- a/drivers/media/video/vpx3220.c
+++ b/drivers/media/video/vpx3220.c
@@ -30,7 +30,6 @@
 #include <asm/uaccess.h>
 
 #include <linux/i2c.h>
-#include <linux/i2c-dev.h>
 
 #define I2C_NAME(x) (x)->name
 
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 7d213707008a..2671da20a496 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -9,13 +9,54 @@
  * Written by: Michael Chan  (mchan@broadcom.com)
  */
 
+#include <linux/config.h>
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+
+#include <linux/kernel.h>
+#include <linux/timer.h>
+#include <linux/errno.h>
+#include <linux/ioport.h>
+#include <linux/slab.h>
+#include <linux/vmalloc.h>
+#include <linux/interrupt.h>
+#include <linux/pci.h>
+#include <linux/init.h>
+#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
+#include <linux/skbuff.h>
+#include <linux/dma-mapping.h>
+#include <asm/bitops.h>
+#include <asm/io.h>
+#include <asm/irq.h>
+#include <linux/delay.h>
+#include <asm/byteorder.h>
+#include <linux/time.h>
+#include <linux/ethtool.h>
+#include <linux/mii.h>
+#ifdef NETIF_F_HW_VLAN_TX
+#include <linux/if_vlan.h>
+#define BCM_VLAN 1
+#endif
+#ifdef NETIF_F_TSO
+#include <net/ip.h>
+#include <net/tcp.h>
+#include <net/checksum.h>
+#define BCM_TSO 1
+#endif
+#include <linux/workqueue.h>
+#include <linux/crc32.h>
+#include <linux/prefetch.h>
+#include <linux/cache.h>
+
 #include "bnx2.h"
 #include "bnx2_fw.h"
 
 #define DRV_MODULE_NAME         "bnx2"
 #define PFX DRV_MODULE_NAME     ": "
-#define DRV_MODULE_VERSION      "1.4.38"
-#define DRV_MODULE_RELDATE      "February 10, 2006"
+#define DRV_MODULE_VERSION      "1.4.39"
+#define DRV_MODULE_RELDATE      "March 22, 2006"
 
 #define RUN_AT(x) (jiffies + (x))
 
@@ -313,8 +354,6 @@ bnx2_disable_int(struct bnx2 *bp)
 static void
 bnx2_enable_int(struct bnx2 *bp)
 {
-        u32 val;
-
         REG_WR(bp, BNX2_PCICFG_INT_ACK_CMD,
                BNX2_PCICFG_INT_ACK_CMD_INDEX_VALID |
                BNX2_PCICFG_INT_ACK_CMD_MASK_INT | bp->last_status_idx);
@@ -322,8 +361,7 @@ bnx2_enable_int(struct bnx2 *bp)
         REG_WR(bp, BNX2_PCICFG_INT_ACK_CMD,
                BNX2_PCICFG_INT_ACK_CMD_INDEX_VALID | bp->last_status_idx);
 
-        val = REG_RD(bp, BNX2_HC_COMMAND);
-        REG_WR(bp, BNX2_HC_COMMAND, val | BNX2_HC_COMMAND_COAL_NOW);
+        REG_WR(bp, BNX2_HC_COMMAND, bp->hc_cmd | BNX2_HC_COMMAND_COAL_NOW);
 }
 
 static void
@@ -362,15 +400,11 @@ bnx2_free_mem(struct bnx2 *bp)
 {
         int i;
 
-        if (bp->stats_blk) {
-                pci_free_consistent(bp->pdev, sizeof(struct statistics_block),
-                                    bp->stats_blk, bp->stats_blk_mapping);
-                bp->stats_blk = NULL;
-        }
         if (bp->status_blk) {
-                pci_free_consistent(bp->pdev, sizeof(struct status_block),
+                pci_free_consistent(bp->pdev, bp->status_stats_size,
                                     bp->status_blk, bp->status_blk_mapping);
                 bp->status_blk = NULL;
+                bp->stats_blk = NULL;
         }
         if (bp->tx_desc_ring) {
                 pci_free_consistent(bp->pdev,
@@ -395,14 +429,13 @@ bnx2_free_mem(struct bnx2 *bp)
 static int
 bnx2_alloc_mem(struct bnx2 *bp)
 {
-        int i;
+        int i, status_blk_size;
 
-        bp->tx_buf_ring = kmalloc(sizeof(struct sw_bd) * TX_DESC_CNT,
-                                     GFP_KERNEL);
+        bp->tx_buf_ring = kzalloc(sizeof(struct sw_bd) * TX_DESC_CNT,
+                                  GFP_KERNEL);
         if (bp->tx_buf_ring == NULL)
                 return -ENOMEM;
 
-        memset(bp->tx_buf_ring, 0, sizeof(struct sw_bd) * TX_DESC_CNT);
         bp->tx_desc_ring = pci_alloc_consistent(bp->pdev,
                                                 sizeof(struct tx_bd) *
                                                 TX_DESC_CNT,
@@ -428,21 +461,22 @@ bnx2_alloc_mem(struct bnx2 *bp)
 
         }
 
-        bp->status_blk = pci_alloc_consistent(bp->pdev,
-                                              sizeof(struct status_block),
+        /* Combine status and statistics blocks into one allocation. */
+        status_blk_size = L1_CACHE_ALIGN(sizeof(struct status_block));
+        bp->status_stats_size = status_blk_size +
+                                sizeof(struct statistics_block);
+
+        bp->status_blk = pci_alloc_consistent(bp->pdev, bp->status_stats_size,
                                               &bp->status_blk_mapping);
         if (bp->status_blk == NULL)
                 goto alloc_mem_err;
 
-        memset(bp->status_blk, 0, sizeof(struct status_block));
+        memset(bp->status_blk, 0, bp->status_stats_size);
 
-        bp->stats_blk = pci_alloc_consistent(bp->pdev,
-                                             sizeof(struct statistics_block),
-                                             &bp->stats_blk_mapping);
-        if (bp->stats_blk == NULL)
-                goto alloc_mem_err;
+        bp->stats_blk = (void *) ((unsigned long) bp->status_blk +
+                                  status_blk_size);
 
-        memset(bp->stats_blk, 0, sizeof(struct statistics_block));
+        bp->stats_blk_mapping = bp->status_blk_mapping + status_blk_size;
 
         return 0;
 
@@ -1926,6 +1960,13 @@ bnx2_poll(struct net_device *dev, int *budget)
                 spin_lock(&bp->phy_lock);
                 bnx2_phy_int(bp);
                 spin_unlock(&bp->phy_lock);
+
+                /* This is needed to take care of transient status
+                 * during link changes.
+                 */
+                REG_WR(bp, BNX2_HC_COMMAND,
+                       bp->hc_cmd | BNX2_HC_COMMAND_COAL_NOW_WO_INT);
+                REG_RD(bp, BNX2_HC_COMMAND);
         }
 
         if (bp->status_blk->status_tx_quick_consumer_index0 != bp->hw_tx_cons)
@@ -3307,6 +3348,8 @@ bnx2_init_chip(struct bnx2 *bp)
 
         udelay(20);
 
+        bp->hc_cmd = REG_RD(bp, BNX2_HC_COMMAND);
+
         return rc;
 }
 
@@ -3746,7 +3789,6 @@ bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
         struct sk_buff *skb, *rx_skb;
         unsigned char *packet;
         u16 rx_start_idx, rx_idx;
-        u32 val;
         dma_addr_t map;
         struct tx_bd *txbd;
         struct sw_bd *rx_buf;
@@ -3777,8 +3819,9 @@ bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
         map = pci_map_single(bp->pdev, skb->data, pkt_size,
                 PCI_DMA_TODEVICE);
 
-        val = REG_RD(bp, BNX2_HC_COMMAND);
-        REG_WR(bp, BNX2_HC_COMMAND, val | BNX2_HC_COMMAND_COAL_NOW_WO_INT);
+        REG_WR(bp, BNX2_HC_COMMAND,
+               bp->hc_cmd | BNX2_HC_COMMAND_COAL_NOW_WO_INT);
+
         REG_RD(bp, BNX2_HC_COMMAND);
 
         udelay(5);
@@ -3802,8 +3845,9 @@ bnx2_run_loopback(struct bnx2 *bp, int loopback_mode)
 
         udelay(100);
 
-        val = REG_RD(bp, BNX2_HC_COMMAND);
-        REG_WR(bp, BNX2_HC_COMMAND, val | BNX2_HC_COMMAND_COAL_NOW_WO_INT);
+        REG_WR(bp, BNX2_HC_COMMAND,
+               bp->hc_cmd | BNX2_HC_COMMAND_COAL_NOW_WO_INT);
+
         REG_RD(bp, BNX2_HC_COMMAND);
 
         udelay(5);
@@ -3939,7 +3983,6 @@ static int
 bnx2_test_intr(struct bnx2 *bp)
 {
         int i;
-        u32 val;
         u16 status_idx;
 
         if (!netif_running(bp->dev))
@@ -3948,8 +3991,7 @@ bnx2_test_intr(struct bnx2 *bp)
         status_idx = REG_RD(bp, BNX2_PCICFG_INT_ACK_CMD) & 0xffff;
 
         /* This register is not touched during run-time. */
-        val = REG_RD(bp, BNX2_HC_COMMAND);
-        REG_WR(bp, BNX2_HC_COMMAND, val | BNX2_HC_COMMAND_COAL_NOW);
+        REG_WR(bp, BNX2_HC_COMMAND, bp->hc_cmd | BNX2_HC_COMMAND_COAL_NOW);
         REG_RD(bp, BNX2_HC_COMMAND);
 
         for (i = 0; i < 10; i++) {
diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
index fd4b7f2eb477..b87925f6a228 100644
--- a/drivers/net/bnx2.h
+++ b/drivers/net/bnx2.h
@@ -13,46 +13,6 @@
 #ifndef BNX2_H
 #define BNX2_H
 
-#include <linux/config.h>
-
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-
-#include <linux/kernel.h>
-#include <linux/timer.h>
-#include <linux/errno.h>
-#include <linux/ioport.h>
-#include <linux/slab.h>
-#include <linux/vmalloc.h>
-#include <linux/interrupt.h>
-#include <linux/pci.h>
-#include <linux/init.h>
-#include <linux/netdevice.h>
-#include <linux/etherdevice.h>
-#include <linux/skbuff.h>
-#include <linux/dma-mapping.h>
-#include <asm/bitops.h>
-#include <asm/io.h>
-#include <asm/irq.h>
-#include <linux/delay.h>
-#include <asm/byteorder.h>
-#include <linux/time.h>
-#include <linux/ethtool.h>
-#include <linux/mii.h>
-#ifdef NETIF_F_HW_VLAN_TX
-#include <linux/if_vlan.h>
-#define BCM_VLAN 1
-#endif
-#ifdef NETIF_F_TSO
-#include <net/ip.h>
-#include <net/tcp.h>
-#include <net/checksum.h>
-#define BCM_TSO 1
-#endif
-#include <linux/workqueue.h>
-#include <linux/crc32.h>
-#include <linux/prefetch.h>
-
 /* Hardware data structures and register definitions automatically
  * generated from RTL code. Do not modify.
  */
@@ -3917,15 +3877,17 @@ struct bnx2 {
 #define USING_MSI_FLAG                  0x20
 #define ASF_ENABLE_FLAG                 0x40
 
-        struct tx_bd            *tx_desc_ring;
-        struct sw_bd            *tx_buf_ring;
-        u32                     tx_prod_bseq;
-        u16                     tx_prod;
-        u16                     tx_cons;
-        int                     tx_ring_size;
+        /* Put tx producer and consumer fields in separate cache lines. */
 
-        u16                     hw_tx_cons;
-        u16                     hw_rx_cons;
+        u32             tx_prod_bseq __attribute__((aligned(L1_CACHE_BYTES)));
+        u16             tx_prod;
+
+        struct tx_bd    *tx_desc_ring;
+        struct sw_bd    *tx_buf_ring;
+        int             tx_ring_size;
+
+        u16             tx_cons __attribute__((aligned(L1_CACHE_BYTES)));
+        u16             hw_tx_cons;
 
 #ifdef BCM_VLAN 
         struct                  vlan_group *vlgrp;
@@ -3939,6 +3901,7 @@ struct bnx2 {
         u32                     rx_prod_bseq;
         u16                     rx_prod;
         u16                     rx_cons;
+        u16                     hw_rx_cons;
 
         u32                     rx_csum;
 
@@ -4038,6 +4001,7 @@ struct bnx2 {
         struct statistics_block *stats_blk;
         dma_addr_t              stats_blk_mapping;
 
+        u32                     hc_cmd;
         u32                     rx_mode;
 
         u16                     req_line_speed;
@@ -4082,6 +4046,8 @@ struct bnx2 {
 
         struct flash_spec       *flash_info;
         u32                     flash_size;
+
+        int                     status_stats_size;
 };
 
 static u32 bnx2_reg_rd_ind(struct bnx2 *bp, u32 offset);
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 690a1aae0b34..0c13795dca38 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -172,11 +172,9 @@ static struct net_device_stats *get_stats(struct net_device *dev)
 
         memset(stats, 0, sizeof(struct net_device_stats));
 
-        for (i=0; i < NR_CPUS; i++) {
+        for_each_cpu(i) {
                 struct net_device_stats *lb_stats;
 
-                if (!cpu_possible(i)) 
-                        continue;
                 lb_stats = &per_cpu(loopback_stats, i);
                 stats->rx_bytes   += lb_stats->rx_bytes;
                 stats->tx_bytes   += lb_stats->tx_bytes;
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index f608c12e3e8b..b2073fce8216 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -46,6 +46,7 @@
 #include <linux/rwsem.h>
 #include <linux/stddef.h>
 #include <linux/device.h>
+#include <linux/mutex.h>
 #include <net/slhc_vj.h>
 #include <asm/atomic.h>
 
@@ -198,11 +199,11 @@ static unsigned int cardmap_find_first_free(struct cardmap *map);
 static void cardmap_destroy(struct cardmap **map);
 
 /*
- * all_ppp_sem protects the all_ppp_units mapping.
+ * all_ppp_mutex protects the all_ppp_units mapping.
  * It also ensures that finding a ppp unit in the all_ppp_units map
  * and updating its file.refcnt field is atomic.
  */
-static DECLARE_MUTEX(all_ppp_sem);
+static DEFINE_MUTEX(all_ppp_mutex);
 static struct cardmap *all_ppp_units;
 static atomic_t ppp_unit_count = ATOMIC_INIT(0);
 
@@ -804,7 +805,7 @@ static int ppp_unattached_ioctl(struct ppp_file *pf, struct file *file,
                 /* Attach to an existing ppp unit */
                 if (get_user(unit, p))
                         break;
-                down(&all_ppp_sem);
+                mutex_lock(&all_ppp_mutex);
                 err = -ENXIO;
                 ppp = ppp_find_unit(unit);
                 if (ppp != 0) {
@@ -812,7 +813,7 @@ static int ppp_unattached_ioctl(struct ppp_file *pf, struct file *file,
                         file->private_data = &ppp->file;
                         err = 0;
                 }
-                up(&all_ppp_sem);
+                mutex_unlock(&all_ppp_mutex);
                 break;
 
         case PPPIOCATTCHAN:
@@ -2446,7 +2447,7 @@ ppp_create_interface(int unit, int *retp)
         dev->do_ioctl = ppp_net_ioctl;
 
         ret = -EEXIST;
-        down(&all_ppp_sem);
+        mutex_lock(&all_ppp_mutex);
         if (unit < 0)
                 unit = cardmap_find_first_free(all_ppp_units);
         else if (cardmap_get(all_ppp_units, unit) != NULL)
@@ -2465,12 +2466,12 @@ ppp_create_interface(int unit, int *retp)
 
         atomic_inc(&ppp_unit_count);
         cardmap_set(&all_ppp_units, unit, ppp);
-        up(&all_ppp_sem);
+        mutex_unlock(&all_ppp_mutex);
         *retp = 0;
         return ppp;
 
 out2:
-        up(&all_ppp_sem);
+        mutex_unlock(&all_ppp_mutex);
         free_netdev(dev);
 out1:
         kfree(ppp);
@@ -2500,7 +2501,7 @@ static void ppp_shutdown_interface(struct ppp *ppp)
 {
         struct net_device *dev;
 
-        down(&all_ppp_sem);
+        mutex_lock(&all_ppp_mutex);
         ppp_lock(ppp);
         dev = ppp->dev;
         ppp->dev = NULL;
@@ -2514,7 +2515,7 @@ static void ppp_shutdown_interface(struct ppp *ppp)
         ppp->file.dead = 1;
         ppp->owner = NULL;
         wake_up_interruptible(&ppp->file.rwait);
-        up(&all_ppp_sem);
+        mutex_unlock(&all_ppp_mutex);
 }
 
 /*
@@ -2556,7 +2557,7 @@ static void ppp_destroy_interface(struct ppp *ppp)
 
 /*
  * Locate an existing ppp unit.
- * The caller should have locked the all_ppp_sem.
+ * The caller should have locked the all_ppp_mutex.
  */
 static struct ppp *
 ppp_find_unit(int unit)
@@ -2601,7 +2602,7 @@ ppp_connect_channel(struct channel *pch, int unit)
         int ret = -ENXIO;
         int hdrlen;
 
-        down(&all_ppp_sem);
+        mutex_lock(&all_ppp_mutex);
         ppp = ppp_find_unit(unit);
         if (ppp == 0)
                 goto out;
@@ -2626,7 +2627,7 @@ ppp_connect_channel(struct channel *pch, int unit)
  outl:
         write_unlock_bh(&pch->upl);
  out:
-        up(&all_ppp_sem);
+        mutex_unlock(&all_ppp_mutex);
         return ret;
 }
 
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 88829eb9568e..b5473325bff4 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -69,8 +69,8 @@
 
 #define DRV_MODULE_NAME         "tg3"
 #define PFX DRV_MODULE_NAME     ": "
-#define DRV_MODULE_VERSION      "3.53"
-#define DRV_MODULE_RELDATE      "Mar 22, 2006"
+#define DRV_MODULE_VERSION      "3.54"
+#define DRV_MODULE_RELDATE      "Mar 23, 2006"
 
 #define TG3_DEF_MAC_MODE        0
 #define TG3_DEF_RX_MODE         0
@@ -225,6 +225,10 @@ static struct pci_device_id tg3_pci_tbl[] = {
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
         { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5754M,
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
+        { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5755,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
+        { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5755M,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
         { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5787,
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
         { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5787M,
@@ -4557,6 +4561,7 @@ static int tg3_chip_reset(struct tg3 *tp)
         }
 
         if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                 tw32(GRC_FASTBOOT_PC, 0);
 
@@ -6152,6 +6157,9 @@ static int tg3_reset_hw(struct tg3 *tp)
                         gpio_mask |= GRC_LCLCTRL_GPIO_OE3 |
                                      GRC_LCLCTRL_GPIO_OUTPUT3;
 
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
+                        gpio_mask |= GRC_LCLCTRL_GPIO_UART_SEL;
+
                 tp->grc_local_ctrl |= tr32(GRC_LOCAL_CTRL) & gpio_mask;
 
                 /* GPIO1 must be driven high for eeprom write protect */
@@ -6191,7 +6199,8 @@ static int tg3_reset_hw(struct tg3 *tp)
         }
 
         /* Enable host coalescing bug fix */
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755) ||
+            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787))
                 val |= (1 << 29);
 
         tw32_f(WDMAC_MODE, val);
@@ -6249,6 +6258,9 @@ static int tg3_reset_hw(struct tg3 *tp)
         udelay(100);
 
         tp->rx_mode = RX_MODE_ENABLE;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
+                tp->rx_mode |= RX_MODE_IPV6_CSUM_ENABLE;
+
         tw32_f(MAC_RX_MODE, tp->rx_mode);
         udelay(10);
 
@@ -7907,7 +7919,8 @@ static int tg3_set_tx_csum(struct net_device *dev, u32 data)
                 return 0;
         }
   
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                 ethtool_op_set_tx_hw_csum(dev, data);
         else
                 ethtool_op_set_tx_csum(dev, data);
@@ -8332,7 +8345,8 @@ static int tg3_test_memory(struct tg3 *tp)
         int i;
 
         if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                         mem_tbl = mem_tbl_5755;
                 else
                         mem_tbl = mem_tbl_5705;
@@ -8924,6 +8938,47 @@ static void __devinit tg3_get_5752_nvram_info(struct tg3 *tp)
         }
 }
 
+static void __devinit tg3_get_5755_nvram_info(struct tg3 *tp)
+{
+        u32 nvcfg1;
+
+        nvcfg1 = tr32(NVRAM_CFG1);
+
+        /* NVRAM protection for TPM */
+        if (nvcfg1 & (1 << 27))
+                tp->tg3_flags2 |= TG3_FLG2_PROTECTED_NVRAM;
+
+        switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
+                case FLASH_5755VENDOR_ATMEL_EEPROM_64KHZ:
+                case FLASH_5755VENDOR_ATMEL_EEPROM_376KHZ:
+                        tp->nvram_jedecnum = JEDEC_ATMEL;
+                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
+
+                        nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
+                        tw32(NVRAM_CFG1, nvcfg1);
+                        break;
+                case FLASH_5752VENDOR_ATMEL_FLASH_BUFFERED:
+                case FLASH_5755VENDOR_ATMEL_FLASH_1:
+                case FLASH_5755VENDOR_ATMEL_FLASH_2:
+                case FLASH_5755VENDOR_ATMEL_FLASH_3:
+                case FLASH_5755VENDOR_ATMEL_FLASH_4:
+                        tp->nvram_jedecnum = JEDEC_ATMEL;
+                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                        tp->nvram_pagesize = 264;
+                        break;
+                case FLASH_5752VENDOR_ST_M45PE10:
+                case FLASH_5752VENDOR_ST_M45PE20:
+                case FLASH_5752VENDOR_ST_M45PE40:
+                        tp->nvram_jedecnum = JEDEC_ST;
+                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                        tp->nvram_pagesize = 256;
+                        break;
+        }
+}
+
 static void __devinit tg3_get_5787_nvram_info(struct tg3 *tp)
 {
         u32 nvcfg1;
@@ -8997,6 +9052,8 @@ static void __devinit tg3_nvram_init(struct tg3 *tp)
 
                 if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752)
                         tg3_get_5752_nvram_info(tp);
+                else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
+                        tg3_get_5755_nvram_info(tp);
                 else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                         tg3_get_5787_nvram_info(tp);
                 else
@@ -9310,6 +9367,7 @@ static int tg3_nvram_write_block_buffered(struct tg3 *tp, u32 offset, u32 len,
                         nvram_cmd |= NVRAM_CMD_LAST;
 
                 if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5752) &&
+                    (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5755) &&
                     (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5787) &&
                     (tp->nvram_jedecnum == JEDEC_ST) &&
                     (nvram_cmd & NVRAM_CMD_FIRST)) {
@@ -10044,6 +10102,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
 
         if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750 ||
             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787 ||
             (tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
                 tp->tg3_flags2 |= TG3_FLG2_5750_PLUS;
@@ -10053,7 +10112,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                 tp->tg3_flags2 |= TG3_FLG2_5705_PLUS;
 
         if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) {
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787) {
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787) {
                         tp->tg3_flags2 |= TG3_FLG2_HW_TSO_2;
                         tp->tg3_flags2 |= TG3_FLG2_1SHOT_MSI;
                 } else
@@ -10063,6 +10123,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705 &&
             GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5750 &&
             GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5752 &&
+            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5755 &&
             GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5787)
                 tp->tg3_flags2 |= TG3_FLG2_JUMBO_CAPABLE;
 
@@ -10219,6 +10280,9 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752)
                 tp->grc_local_ctrl |= GRC_LCLCTRL_GPIO_OE3;
 
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
+                tp->grc_local_ctrl |= GRC_LCLCTRL_GPIO_UART_SEL;
+
         /* Force the chip into D0. */
         err = tg3_set_power_state(tp, PCI_D0);
         if (err) {
@@ -10274,6 +10338,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                 tp->tg3_flags2 |= TG3_FLG2_PHY_5704_A0_BUG;
 
         if ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+            (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5755) &&
             (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5787))
                 tp->tg3_flags2 |= TG3_FLG2_PHY_BER_BUG;
 
@@ -10413,7 +10478,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         /* All chips before 5787 can get confused if TX buffers
          * straddle the 4GB address boundary in some cases.
          */
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                 tp->dev->hard_start_xmit = tg3_start_xmit;
         else
                 tp->dev->hard_start_xmit = tg3_start_xmit_dma_bug;
@@ -11002,6 +11068,7 @@ static char * __devinit tg3_phy_string(struct tg3 *tp)
         case PHY_ID_BCM5752:    return "5752";
         case PHY_ID_BCM5714:    return "5714";
         case PHY_ID_BCM5780:    return "5780";
+        case PHY_ID_BCM5755:    return "5755";
         case PHY_ID_BCM5787:    return "5787";
         case PHY_ID_BCM8002:    return "8002/serdes";
         case 0:                 return "serdes";
@@ -11350,7 +11417,8 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
          * checksumming.
          */
         if ((tp->tg3_flags & TG3_FLAG_BROKEN_CHECKSUMS) == 0) {
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
                         dev->features |= NETIF_F_HW_CSUM;
                 else
                         dev->features |= NETIF_F_IP_CSUM;
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
index baa34c4721db..c43cc3264202 100644
--- a/drivers/net/tg3.h
+++ b/drivers/net/tg3.h
@@ -138,6 +138,7 @@
 #define   ASIC_REV_5752                  0x06
 #define   ASIC_REV_5780                  0x08
 #define   ASIC_REV_5714                  0x09
+#define   ASIC_REV_5755                  0x0a
 #define   ASIC_REV_5787                  0x0b
 #define  GET_CHIP_REV(CHIP_REV_ID)      ((CHIP_REV_ID) >> 8)
 #define   CHIPREV_5700_AX                0x70
@@ -456,6 +457,7 @@
 #define  RX_MODE_PROMISC                 0x00000100
 #define  RX_MODE_NO_CRC_CHECK            0x00000200
 #define  RX_MODE_KEEP_VLAN_TAG           0x00000400
+#define  RX_MODE_IPV6_CSUM_ENABLE        0x01000000
 #define MAC_RX_STATUS                   0x0000046c
 #define  RX_STATUS_REMOTE_TX_XOFFED      0x00000001
 #define  RX_STATUS_XOFF_RCVD             0x00000002
@@ -1340,6 +1342,7 @@
 #define  GRC_LCLCTRL_CLEARINT           0x00000002
 #define  GRC_LCLCTRL_SETINT             0x00000004
 #define  GRC_LCLCTRL_INT_ON_ATTN        0x00000008
+#define  GRC_LCLCTRL_GPIO_UART_SEL      0x00000010      /* 5755 only */
 #define  GRC_LCLCTRL_USE_SIG_DETECT     0x00000010      /* 5714/5780 only */
 #define  GRC_LCLCTRL_USE_EXT_SIG_DETECT 0x00000020      /* 5714/5780 only */
 #define  GRC_LCLCTRL_GPIO_INPUT3        0x00000020
@@ -1441,6 +1444,9 @@
 #define  FLASH_5755VENDOR_ATMEL_FLASH_1  0x03400001
 #define  FLASH_5755VENDOR_ATMEL_FLASH_2  0x03400002
 #define  FLASH_5755VENDOR_ATMEL_FLASH_3  0x03400000
+#define  FLASH_5755VENDOR_ATMEL_FLASH_4  0x00000003
+#define  FLASH_5755VENDOR_ATMEL_EEPROM_64KHZ     0x03c00003
+#define  FLASH_5755VENDOR_ATMEL_EEPROM_376KHZ    0x03c00002
 #define  FLASH_5787VENDOR_ATMEL_EEPROM_64KHZ     0x03000003
 #define  FLASH_5787VENDOR_ATMEL_EEPROM_376KHZ    0x03000002
 #define  FLASH_5787VENDOR_MICRO_EEPROM_64KHZ     0x03000000
@@ -2259,6 +2265,7 @@ struct tg3 {
 #define PHY_ID_BCM5752                  0x60008100
 #define PHY_ID_BCM5714                  0x60008340
 #define PHY_ID_BCM5780                  0x60008350
+#define PHY_ID_BCM5755                  0xbc050cc0
 #define PHY_ID_BCM5787                  0xbc050ce0
 #define PHY_ID_BCM8002                  0x60010140
 #define PHY_ID_INVALID                  0xffffffff
@@ -2286,7 +2293,7 @@ struct tg3 {
          (X) == PHY_ID_BCM5705 || (X) == PHY_ID_BCM5750 || \
          (X) == PHY_ID_BCM5752 || (X) == PHY_ID_BCM5714 || \
          (X) == PHY_ID_BCM5780 || (X) == PHY_ID_BCM5787 || \
-         (X) == PHY_ID_BCM8002)
+         (X) == PHY_ID_BCM5755 || (X) == PHY_ID_BCM8002)
 
         struct tg3_hw_stats             *hw_stats;
         dma_addr_t                      stats_mapping;
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
index 78193e4bbdb5..330d3869b41e 100644
--- a/drivers/oprofile/cpu_buffer.c
+++ b/drivers/oprofile/cpu_buffer.c
@@ -38,9 +38,8 @@ void free_cpu_buffers(void)
 {
         int i;
  
-        for_each_online_cpu(i) {
+        for_each_online_cpu(i)
                 vfree(cpu_buffer[i].buffer);
-        }
 }
 
 int alloc_cpu_buffers(void)
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index f187fd8aeed6..4d762fc4878c 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -11,24 +11,11 @@ config PCI_MSI
            generate an interrupt using an inbound Memory Write on its
            PCI bus instead of asserting a device IRQ pin.
 
-           If you don't know what to do here, say N.
-
-config PCI_LEGACY_PROC
-        bool "Legacy /proc/pci interface"
-        depends on PCI
-        ---help---
-          This feature enables a procfs file -- /proc/pci -- that provides a 
-          summary of PCI devices in the system. 
-
-          This feature has been deprecated as of v2.5.53, in favor of using the 
-          tool lspci(8). This feature may be removed at a future date. 
+           Use of PCI MSI interrupts can be disabled at kernel boot time
+           by using the 'pci=nomsi' option.  This disables MSI for the
+           entire system.
 
-          lspci can provide the same data, as well as much more. lspci is a part of
-          the pci-utils package, which should be installed by your distribution. 
-          See <file:Documentation/Changes> for information on where to get the latest
-          version. 
-
-          When in doubt, say N.
+           If you don't know what to do here, say N.
 
 config PCI_DEBUG
         bool "PCI Debugging"
diff --git a/drivers/pci/hotplug/Makefile b/drivers/pci/hotplug/Makefile
index 3c71e3077ff1..421cfffb1756 100644
--- a/drivers/pci/hotplug/Makefile
+++ b/drivers/pci/hotplug/Makefile
@@ -22,6 +22,9 @@ ifdef CONFIG_HOTPLUG_PCI_CPCI
 pci_hotplug-objs        +=      cpci_hotplug_core.o     \
                                 cpci_hotplug_pci.o
 endif
+ifdef CONFIG_ACPI
+pci_hotplug-objs        +=      acpi_pcihp.o
+endif
 
 cpqphp-objs             :=      cpqphp_core.o   \
                                 cpqphp_ctrl.o   \
@@ -37,7 +40,8 @@ ibmphp-objs		:=	ibmphp_core.o	\
                                 ibmphp_hpc.o
 
 acpiphp-objs            :=      acpiphp_core.o  \
-                                acpiphp_glue.o
+                                acpiphp_glue.o  \
+                                acpiphp_dock.o
 
 rpaphp-objs             :=      rpaphp_core.o   \
                                 rpaphp_pci.o    \
@@ -50,23 +54,9 @@ pciehp-objs		:=	pciehp_core.o	\
                                 pciehp_ctrl.o   \
                                 pciehp_pci.o    \
                                 pciehp_hpc.o
-ifdef CONFIG_ACPI
-        pciehp-objs += pciehprm_acpi.o
-else
-        pciehp-objs += pciehprm_nonacpi.o
-endif
 
 shpchp-objs             :=      shpchp_core.o   \
                                 shpchp_ctrl.o   \
                                 shpchp_pci.o    \
                                 shpchp_sysfs.o  \
                                 shpchp_hpc.o
-ifdef CONFIG_ACPI
-        shpchp-objs += shpchprm_acpi.o
-else
-        ifdef CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY
-                shpchp-objs += shpchprm_legacy.o
-        else
-                shpchp-objs += shpchprm_nonacpi.o
-        endif
-endif
diff --git a/drivers/pci/hotplug/shpchprm_acpi.c b/drivers/pci/hotplug/acpi_pcihp.c
index 17145e52223a..39af9c325f35 100644
--- a/drivers/pci/hotplug/shpchprm_acpi.c
+++ b/drivers/pci/hotplug/acpi_pcihp.c
@@ -1,7 +1,7 @@
 /*
- * SHPCHPRM ACPI: PHP Resource Manager for ACPI platform
+ * Common ACPI functions for hot plug platforms
  *
- * Copyright (C) 2003-2004 Intel Corporation
+ * Copyright (C) 2006 Intel Corporation
  *
  * All rights reserved.
  *
@@ -31,26 +31,12 @@
 #include <acpi/acpi.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/actypes.h>
-#include "shpchp.h"
+#include "pci_hotplug.h"
 
 #define METHOD_NAME__SUN        "_SUN"
 #define METHOD_NAME__HPP        "_HPP"
 #define METHOD_NAME_OSHP        "OSHP"
 
-static u8 * acpi_path_name( acpi_handle handle)
-{
-        acpi_status             status;
-        static u8       path_name[ACPI_PATHNAME_MAX];
-        struct acpi_buffer              ret_buf = { ACPI_PATHNAME_MAX, path_name };
-
-        memset(path_name, 0, sizeof (path_name));
-        status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &ret_buf);
-
-        if (ACPI_FAILURE(status))
-                return NULL;
-        else
-                return path_name;       
-}
 
 static acpi_status
 acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
@@ -58,18 +44,21 @@ acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
         acpi_status             status;
         u8                      nui[4];
         struct acpi_buffer      ret_buf = { 0, NULL};
+        struct acpi_buffer      string = { ACPI_ALLOCATE_BUFFER, NULL };
         union acpi_object       *ext_obj, *package;
-        u8                      *path_name = acpi_path_name(handle);
         int                     i, len = 0;
 
+        acpi_get_name(handle, ACPI_FULL_PATHNAME, &string);
+
         /* get _hpp */
         status = acpi_evaluate_object(handle, METHOD_NAME__HPP, NULL, &ret_buf);
         switch (status) {
         case AE_BUFFER_OVERFLOW:
                 ret_buf.pointer = kmalloc (ret_buf.length, GFP_KERNEL);
                 if (!ret_buf.pointer) {
-                        err ("%s:%s alloc for _HPP fail\n", __FUNCTION__,
-                                        path_name);
+                        printk(KERN_ERR "%s:%s alloc for _HPP fail\n",
+                                __FUNCTION__, (char *)string.pointer);
+                        acpi_os_free(string.pointer);
                         return AE_NO_MEMORY;
                 }
                 status = acpi_evaluate_object(handle, METHOD_NAME__HPP,
@@ -78,16 +67,17 @@ acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
                         break;
         default:
                 if (ACPI_FAILURE(status)) {
-                        dbg("%s:%s _HPP fail=0x%x\n", __FUNCTION__,
-                                        path_name, status);
+                        pr_debug("%s:%s _HPP fail=0x%x\n", __FUNCTION__,
+                                (char *)string.pointer, status);
+                        acpi_os_free(string.pointer);
                         return status;
                 }
         }
 
         ext_obj = (union acpi_object *) ret_buf.pointer;
         if (ext_obj->type != ACPI_TYPE_PACKAGE) {
-                err ("%s:%s _HPP obj not a package\n", __FUNCTION__,
-                                path_name);
+                printk(KERN_ERR "%s:%s _HPP obj not a package\n", __FUNCTION__,
+                                (char *)string.pointer);
                 status = AE_ERROR;
                 goto free_and_return;
         }
@@ -101,8 +91,8 @@ acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
                         nui[i] = (u8)ext_obj->integer.value;
                         break;
                 default:
-                        err ("%s:%s _HPP obj type incorrect\n", __FUNCTION__,
-                                        path_name);
+                        printk(KERN_ERR "%s:%s _HPP obj type incorrect\n",
+                                __FUNCTION__, (char *)string.pointer);
                         status = AE_ERROR;
                         goto free_and_return;
                 }
@@ -113,54 +103,52 @@ acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
         hpp->enable_serr = nui[2];
         hpp->enable_perr = nui[3];
 
-        dbg("  _HPP: cache_line_size=0x%x\n", hpp->cache_line_size);
-        dbg("  _HPP: latency timer  =0x%x\n", hpp->latency_timer);
-        dbg("  _HPP: enable SERR    =0x%x\n", hpp->enable_serr);
-        dbg("  _HPP: enable PERR    =0x%x\n", hpp->enable_perr);
+        pr_debug("  _HPP: cache_line_size=0x%x\n", hpp->cache_line_size);
+        pr_debug("  _HPP: latency timer  =0x%x\n", hpp->latency_timer);
+        pr_debug("  _HPP: enable SERR    =0x%x\n", hpp->enable_serr);
+        pr_debug("  _HPP: enable PERR    =0x%x\n", hpp->enable_perr);
 
 free_and_return:
-        kfree(ret_buf.pointer);
+        acpi_os_free(string.pointer);
+        acpi_os_free(ret_buf.pointer);
         return status;
 }
 
-static void acpi_run_oshp(acpi_handle handle)
+
+
+/* acpi_run_oshp - get control of hotplug from the firmware
+ *
+ * @handle - the handle of the hotplug controller.
+ */
+acpi_status acpi_run_oshp(acpi_handle handle)
 {
         acpi_status             status;
-        u8                      *path_name = acpi_path_name(handle);
+        struct acpi_buffer      string = { ACPI_ALLOCATE_BUFFER, NULL };
+
+        acpi_get_name(handle, ACPI_FULL_PATHNAME, &string);
 
         /* run OSHP */
         status = acpi_evaluate_object(handle, METHOD_NAME_OSHP, NULL, NULL);
-        if (ACPI_FAILURE(status)) {
-                err("%s:%s OSHP fails=0x%x\n", __FUNCTION__, path_name,
-                                status);
-        } else {
-                dbg("%s:%s OSHP passes\n", __FUNCTION__, path_name);
-        }
-}
-
-int shpchprm_get_physical_slot_number(struct controller *ctrl, u32 *sun, u8 busnum, u8 devnum)
-{
-        int offset = devnum - ctrl->slot_device_offset;
+        if (ACPI_FAILURE(status))
+                printk(KERN_ERR "%s:%s OSHP fails=0x%x\n", __FUNCTION__,
+                        (char *)string.pointer, status);
+        else
+                pr_debug("%s:%s OSHP passes\n", __FUNCTION__,
+                        (char *)string.pointer);
 
-        dbg("%s: ctrl->slot_num_inc %d, offset %d\n", __FUNCTION__, ctrl->slot_num_inc, offset);
-        *sun = (u8) (ctrl->first_slot + ctrl->slot_num_inc *offset);
-        return 0;
+        acpi_os_free(string.pointer);
+        return status;
 }
+EXPORT_SYMBOL_GPL(acpi_run_oshp);
+
 
-void get_hp_hw_control_from_firmware(struct pci_dev *dev)
-{
-        /*
-         * OSHP is an optional ACPI firmware control method. If present,
-         * we need to run it to inform BIOS that we will control SHPC
-         * hardware from now on.
-         */
-        acpi_handle handle = DEVICE_ACPI_HANDLE(&(dev->dev));
-        if (!handle)
-                return;
-        acpi_run_oshp(handle);
-}
 
-void get_hp_params_from_firmware(struct pci_dev *dev,
+/* acpi_get_hp_params_from_firmware
+ *
+ * @dev - the pci_dev of the newly added device
+ * @hpp - allocated by the caller
+ */
+acpi_status acpi_get_hp_params_from_firmware(struct pci_dev *dev,
                 struct hotplug_params *hpp)
 {
         acpi_status status = AE_NOT_FOUND;
@@ -182,5 +170,42 @@ void get_hp_params_from_firmware(struct pci_dev *dev,
                 /* Check if a parent object supports _HPP */
                 pdev = pdev->bus->parent->self;
         }
+        return status;
 }
+EXPORT_SYMBOL_GPL(acpi_get_hp_params_from_firmware);
 
+
+/* acpi_root_bridge - check to see if this acpi object is a root bridge
+ *
+ * @handle - the acpi object in question.
+ */
+int acpi_root_bridge(acpi_handle handle)
+{
+        acpi_status status;
+        struct acpi_device_info *info;
+        struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
+        int i;
+
+        status = acpi_get_object_info(handle, &buffer);
+        if (ACPI_SUCCESS(status)) {
+                info = buffer.pointer;
+                if ((info->valid & ACPI_VALID_HID) &&
+                        !strcmp(PCI_ROOT_HID_STRING,
+                                        info->hardware_id.value)) {
+                        acpi_os_free(buffer.pointer);
+                        return 1;
+                }
+                if (info->valid & ACPI_VALID_CID) {
+                        for (i=0; i < info->compatibility_id.count; i++) {
+                                if (!strcmp(PCI_ROOT_HID_STRING,
+                                        info->compatibility_id.id[i].value)) {
+                                        acpi_os_free(buffer.pointer);
+                                        return 1;
+                                }
+                        }
+                }
+                acpi_os_free(buffer.pointer);
+        }
+        return 0;
+}
+EXPORT_SYMBOL_GPL(acpi_root_bridge);
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
index 293603e1b7c3..467ac70a46ff 100644
--- a/drivers/pci/hotplug/acpiphp.h
+++ b/drivers/pci/hotplug/acpiphp.h
@@ -37,6 +37,7 @@
 
 #include <linux/acpi.h>
 #include <linux/kobject.h>      /* for KOBJ_NAME_LEN */
+#include <linux/mutex.h>
 #include "pci_hotplug.h"
 
 #define dbg(format, arg...)                                     \
@@ -59,26 +60,10 @@ struct acpiphp_slot;
  * struct slot - slot information for each *physical* slot
  */
 struct slot {
-        u8 number;
         struct hotplug_slot     *hotplug_slot;
-        struct list_head        slot_list;
-
         struct acpiphp_slot     *acpi_slot;
 };
 
-/**
- * struct hpp_param - ACPI 2.0 _HPP Hot Plug Parameters
- * @cache_line_size in DWORD
- * @latency_timer in PCI clock
- * @enable_SERR 0 or 1
- * @enable_PERR 0 or 1
- */
-struct hpp_param {
-        u8 cache_line_size;
-        u8 latency_timer;
-        u8 enable_SERR;
-        u8 enable_PERR;
-};
 
 
 /**
@@ -102,7 +87,7 @@ struct acpiphp_bridge {
         struct pci_dev *pci_dev;
 
         /* ACPI 2.0 _HPP parameters */
-        struct hpp_param hpp;
+        struct hotplug_params hpp;
 
         spinlock_t res_lock;
 };
@@ -118,9 +103,9 @@ struct acpiphp_slot {
         struct acpiphp_bridge *bridge;  /* parent */
         struct list_head funcs;         /* one slot may have different
                                            objects (i.e. for each function) */
-        struct semaphore crit_sect;
+        struct slot *slot;
+        struct mutex crit_sect;
 
-        u32             id;             /* slot id (serial #) for hotplug core */
         u8              device;         /* pci device# */
 
         u32             sun;            /* ACPI _SUN (slot unique number) */
@@ -160,6 +145,25 @@ struct acpiphp_attention_info
         struct module *owner;
 };
 
+
+struct dependent_device {
+        struct list_head device_list;
+        struct list_head pci_list;
+        acpi_handle handle;
+        struct acpiphp_func *func;
+};
+
+
+struct acpiphp_dock_station {
+        acpi_handle handle;
+        u32 last_dock_time;
+        u32 flags;
+        struct acpiphp_func *dock_bridge;
+        struct list_head dependent_devices;
+        struct list_head pci_dependent_devices;
+};
+
+
 /* PCI bus bridge HID */
 #define ACPI_PCI_HOST_HID               "PNP0A03"
 
@@ -197,19 +201,27 @@ struct acpiphp_attention_info
 #define FUNC_HAS_PS1            (0x00000020)
 #define FUNC_HAS_PS2            (0x00000040)
 #define FUNC_HAS_PS3            (0x00000080)
+#define FUNC_HAS_DCK            (0x00000100)
+#define FUNC_IS_DD              (0x00000200)
+
+/* dock station flags */
+#define DOCK_DOCKING            (0x00000001)
+#define DOCK_HAS_BRIDGE         (0x00000002)
 
 /* function prototypes */
 
 /* acpiphp_core.c */
 extern int acpiphp_register_attention(struct acpiphp_attention_info*info);
 extern int acpiphp_unregister_attention(struct acpiphp_attention_info *info);
+extern int acpiphp_register_hotplug_slot(struct acpiphp_slot *slot);
+extern void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
 
 /* acpiphp_glue.c */
 extern int acpiphp_glue_init (void);
 extern void acpiphp_glue_exit (void);
 extern int acpiphp_get_num_slots (void);
-extern struct acpiphp_slot *get_slot_from_id (int id);
 typedef int (*acpiphp_callback)(struct acpiphp_slot *slot, void *data);
+void handle_hotplug_event_func(acpi_handle, u32, void*);
 
 extern int acpiphp_enable_slot (struct acpiphp_slot *slot);
 extern int acpiphp_disable_slot (struct acpiphp_slot *slot);
@@ -219,6 +231,16 @@ extern u8 acpiphp_get_latch_status (struct acpiphp_slot *slot);
 extern u8 acpiphp_get_adapter_status (struct acpiphp_slot *slot);
 extern u32 acpiphp_get_address (struct acpiphp_slot *slot);
 
+/* acpiphp_dock.c */
+extern int find_dock_station(void);
+extern void remove_dock_station(void);
+extern void add_dependent_device(struct dependent_device *new_dd);
+extern void add_pci_dependent_device(struct dependent_device *new_dd);
+extern struct dependent_device *get_dependent_device(acpi_handle handle);
+extern int is_dependent_device(acpi_handle handle);
+extern int detect_dependent_devices(acpi_handle *bridge_handle);
+extern struct dependent_device *alloc_dependent_device(acpi_handle handle);
+
 /* variables */
 extern int acpiphp_debug;
 
diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c
index 60c4c38047a3..4f1b0da8e47e 100644
--- a/drivers/pci/hotplug/acpiphp_core.c
+++ b/drivers/pci/hotplug/acpiphp_core.c
@@ -44,8 +44,6 @@
 #include "pci_hotplug.h"
 #include "acpiphp.h"
 
-static LIST_HEAD(slot_list);
-
 #define MY_NAME "acpiphp"
 
 static int debug;
@@ -341,62 +339,53 @@ static void release_slot(struct hotplug_slot *hotplug_slot)
         kfree(slot);
 }
 
-/**
- * init_slots - initialize 'struct slot' structures for each slot
- *
- */
-static int __init init_slots(void)
+/* callback routine to initialize 'struct slot' for each slot */
+int acpiphp_register_hotplug_slot(struct acpiphp_slot *acpiphp_slot)
 {
         struct slot *slot;
+        struct hotplug_slot *hotplug_slot;
+        struct hotplug_slot_info *hotplug_slot_info;
         int retval = -ENOMEM;
-        int i;
-
-        for (i = 0; i < num_slots; ++i) {
-                slot = kmalloc(sizeof(struct slot), GFP_KERNEL);
-                if (!slot)
-                        goto error;
-                memset(slot, 0, sizeof(struct slot));
-
-                slot->hotplug_slot = kmalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
-                if (!slot->hotplug_slot)
-                        goto error_slot;
-                memset(slot->hotplug_slot, 0, sizeof(struct hotplug_slot));
-
-                slot->hotplug_slot->info = kmalloc(sizeof(struct hotplug_slot_info), GFP_KERNEL);
-                if (!slot->hotplug_slot->info)
-                        goto error_hpslot;
-                memset(slot->hotplug_slot->info, 0, sizeof(struct hotplug_slot_info));
-
-                slot->hotplug_slot->name = kmalloc(SLOT_NAME_SIZE, GFP_KERNEL);
-                if (!slot->hotplug_slot->name)
-                        goto error_info;
-
-                slot->number = i;
-
-                slot->hotplug_slot->private = slot;
-                slot->hotplug_slot->release = &release_slot;
-                slot->hotplug_slot->ops = &acpi_hotplug_slot_ops;
-
-                slot->acpi_slot = get_slot_from_id(i);
-                slot->hotplug_slot->info->power_status = acpiphp_get_power_status(slot->acpi_slot);
-                slot->hotplug_slot->info->attention_status = 0;
-                slot->hotplug_slot->info->latch_status = acpiphp_get_latch_status(slot->acpi_slot);
-                slot->hotplug_slot->info->adapter_status = acpiphp_get_adapter_status(slot->acpi_slot);
-                slot->hotplug_slot->info->max_bus_speed = PCI_SPEED_UNKNOWN;
-                slot->hotplug_slot->info->cur_bus_speed = PCI_SPEED_UNKNOWN;
-
-                make_slot_name(slot);
-
-                retval = pci_hp_register(slot->hotplug_slot);
-                if (retval) {
-                        err("pci_hp_register failed with error %d\n", retval);
-                        goto error_name;
-                }
-
-                /* add slot to our internal list */
-                list_add(&slot->slot_list, &slot_list);
-                info("Slot [%s] registered\n", slot->hotplug_slot->name);
-        }
+
+        slot = kzalloc(sizeof(*slot), GFP_KERNEL);
+        if (!slot)
+                goto error;
+
+        slot->hotplug_slot = kzalloc(sizeof(*hotplug_slot), GFP_KERNEL);
+        if (!slot->hotplug_slot)
+                goto error_slot;
+
+        slot->hotplug_slot->info = kzalloc(sizeof(*hotplug_slot_info),
+                                           GFP_KERNEL);
+        if (!slot->hotplug_slot->info)
+                goto error_hpslot;
+
+        slot->hotplug_slot->name = kzalloc(SLOT_NAME_SIZE, GFP_KERNEL);
+        if (!slot->hotplug_slot->name)
+                goto error_info;
+
+        slot->hotplug_slot->private = slot;
+        slot->hotplug_slot->release = &release_slot;
+        slot->hotplug_slot->ops = &acpi_hotplug_slot_ops;
+
+        slot->acpi_slot = acpiphp_slot;
+        slot->hotplug_slot->info->power_status = acpiphp_get_power_status(slot->acpi_slot);
+        slot->hotplug_slot->info->attention_status = 0;
+        slot->hotplug_slot->info->latch_status = acpiphp_get_latch_status(slot->acpi_slot);
+        slot->hotplug_slot->info->adapter_status = acpiphp_get_adapter_status(slot->acpi_slot);
+        slot->hotplug_slot->info->max_bus_speed = PCI_SPEED_UNKNOWN;
+        slot->hotplug_slot->info->cur_bus_speed = PCI_SPEED_UNKNOWN;
+
+        acpiphp_slot->slot = slot;
+        make_slot_name(slot);
+
+        retval = pci_hp_register(slot->hotplug_slot);
+        if (retval) {
+                err("pci_hp_register failed with error %d\n", retval);
+                goto error_name;
+        }
+
+        info("Slot [%s] registered\n", slot->hotplug_slot->name);
 
         return 0;
 error_name:
@@ -412,42 +401,51 @@ error:
 }
 
 
-static void __exit cleanup_slots (void)
+void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *acpiphp_slot)
 {
-        struct list_head *tmp, *n;
-        struct slot *slot;
+        struct slot *slot = acpiphp_slot->slot;
+        int retval = 0;
 
-        list_for_each_safe (tmp, n, &slot_list) {
-                /* memory will be freed in release_slot callback */
-                slot = list_entry(tmp, struct slot, slot_list);
-                list_del(&slot->slot_list);
-                pci_hp_deregister(slot->hotplug_slot);
-        }
+        info ("Slot [%s] unregistered\n", slot->hotplug_slot->name);
+
+        retval = pci_hp_deregister(slot->hotplug_slot);
+        if (retval)
+                err("pci_hp_deregister failed with error %d\n", retval);
 }
 
 
 static int __init acpiphp_init(void)
 {
         int retval;
+        int docking_station;
 
         info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
 
         acpiphp_debug = debug;
 
+        docking_station = find_dock_station();
+
         /* read all the ACPI info from the system */
         retval = init_acpi();
-        if (retval)
-                return retval;
 
-        return init_slots();
+        /* if we have found a docking station, we should
+         * go ahead and load even if init_acpi has found
+         * no slots.  This handles the case when the _DCK
+         * method not defined under the actual dock bridge
+         */
+        if (docking_station)
+                return 0;
+        else
+                return retval;
 }
 
 
 static void __exit acpiphp_exit(void)
 {
-        cleanup_slots();
         /* deallocate internal data structures etc. */
         acpiphp_glue_exit();
+
+        remove_dock_station();
 }
 
 module_init(acpiphp_init);
diff --git a/drivers/pci/hotplug/acpiphp_dock.c b/drivers/pci/hotplug/acpiphp_dock.c
new file mode 100644
index 000000000000..4f1aaf128312
--- /dev/null
+++ b/drivers/pci/hotplug/acpiphp_dock.c
@@ -0,0 +1,438 @@
+/*
+ * ACPI PCI HotPlug dock functions to ACPI CA subsystem
+ *
+ * Copyright (C) 2006 Kristen Carlson Accardi (kristen.c.accardi@intel.com)
+ * Copyright (C) 2006 Intel Corporation
+ *
+ * All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
+ * NON INFRINGEMENT.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * Send feedback to <kristen.c.accardi@intel.com>
+ *
+ */
+#include <linux/init.h>
+#include <linux/module.h>
+
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/smp_lock.h>
+#include <linux/mutex.h>
+
+#include "../pci.h"
+#include "pci_hotplug.h"
+#include "acpiphp.h"
+
+static struct acpiphp_dock_station *ds;
+#define MY_NAME "acpiphp_dock"
+
+
+int is_dependent_device(acpi_handle handle)
+{
+        return (get_dependent_device(handle) ? 1 : 0);
+}
+
+
+static acpi_status
+find_dependent_device(acpi_handle handle, u32 lvl, void *context, void **rv)
+{
+        int *count = (int *)context;
+
+        if (is_dependent_device(handle)) {
+                (*count)++;
+                return AE_CTRL_TERMINATE;
+        } else {
+                return AE_OK;
+        }
+}
+
+
+
+
+void add_dependent_device(struct dependent_device *new_dd)
+{
+        list_add_tail(&new_dd->device_list, &ds->dependent_devices);
+}
+
+
+void add_pci_dependent_device(struct dependent_device *new_dd)
+{
+        list_add_tail(&new_dd->pci_list, &ds->pci_dependent_devices);
+}
+
+
+
+struct dependent_device * get_dependent_device(acpi_handle handle)
+{
+        struct dependent_device *dd;
+
+        if (!ds)
+                return NULL;
+
+        list_for_each_entry(dd, &ds->dependent_devices, device_list) {
+                if (handle == dd->handle)
+                        return dd;
+        }
+        return NULL;
+}
+
+
+
+struct dependent_device *alloc_dependent_device(acpi_handle handle)
+{
+        struct dependent_device *dd;
+
+        dd = kzalloc(sizeof(*dd), GFP_KERNEL);
+        if (dd) {
+                INIT_LIST_HEAD(&dd->pci_list);
+                INIT_LIST_HEAD(&dd->device_list);
+                dd->handle = handle;
+        }
+        return dd;
+}
+
+
+
+static int is_dock(acpi_handle handle)
+{
+        acpi_status status;
+        acpi_handle tmp;
+
+        status = acpi_get_handle(handle, "_DCK", &tmp);
+        if (ACPI_FAILURE(status)) {
+                return 0;
+        }
+        return 1;
+}
+
+
+
+static int dock_present(void)
+{
+        unsigned long sta;
+        acpi_status status;
+
+        if (ds) {
+                status = acpi_evaluate_integer(ds->handle, "_STA", NULL, &sta);
+                if (ACPI_SUCCESS(status) && sta)
+                        return 1;
+        }
+        return 0;
+}
+
+
+
+static void eject_dock(void)
+{
+        struct acpi_object_list arg_list;
+        union acpi_object arg;
+
+        arg_list.count = 1;
+        arg_list.pointer = &arg;
+        arg.type = ACPI_TYPE_INTEGER;
+        arg.integer.value = 1;
+
+        if (ACPI_FAILURE(acpi_evaluate_object(ds->handle, "_EJ0",
+                                        &arg_list, NULL)) || dock_present())
+                warn("%s: failed to eject dock!\n", __FUNCTION__);
+
+        return;
+}
+
+
+
+
+static acpi_status handle_dock(int dock)
+{
+        acpi_status status;
+        struct acpi_object_list arg_list;
+        union acpi_object arg;
+        struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
+
+        dbg("%s: %s\n", __FUNCTION__, dock ? "docking" : "undocking");
+
+        /* _DCK method has one argument */
+        arg_list.count = 1;
+        arg_list.pointer = &arg;
+        arg.type = ACPI_TYPE_INTEGER;
+        arg.integer.value = dock;
+        status = acpi_evaluate_object(ds->handle, "_DCK",
+                                        &arg_list, &buffer);
+        if (ACPI_FAILURE(status))
+                err("%s: failed to execute _DCK\n", __FUNCTION__);
+        acpi_os_free(buffer.pointer);
+
+        return status;
+}
+
+
+
+static inline void dock(void)
+{
+        handle_dock(1);
+}
+
+
+
+static inline void undock(void)
+{
+        handle_dock(0);
+}
+
+
+
+/*
+ * the _DCK method can do funny things... and sometimes not
+ * hah-hah funny.
+ *
+ * TBD - figure out a way to only call fixups for
+ * systems that require them.
+ */
+static void post_dock_fixups(void)
+{
+        struct pci_bus *bus;
+        u32 buses;
+        struct dependent_device *dd;
+
+        list_for_each_entry(dd, &ds->pci_dependent_devices, pci_list) {
+                bus = dd->func->slot->bridge->pci_bus;
+
+                /* fixup bad _DCK function that rewrites
+                 * secondary bridge on slot
+                 */
+                pci_read_config_dword(bus->self,
+                                PCI_PRIMARY_BUS,
+                                &buses);
+
+                if (((buses >> 8) & 0xff) != bus->secondary) {
+                        buses = (buses & 0xff000000)
+                                | ((unsigned int)(bus->primary)     <<  0)
+                                | ((unsigned int)(bus->secondary)   <<  8)
+                                | ((unsigned int)(bus->subordinate) << 16);
+                        pci_write_config_dword(bus->self,
+                                        PCI_PRIMARY_BUS,
+                                        buses);
+                }
+        }
+}
+
+
+
+static void hotplug_pci(u32 type)
+{
+        struct dependent_device *dd;
+
+        list_for_each_entry(dd, &ds->pci_dependent_devices, pci_list)
+                handle_hotplug_event_func(dd->handle, type, dd->func);
+}
+
+
+
+static inline void begin_dock(void)
+{
+        ds->flags |= DOCK_DOCKING;
+}
+
+
+static inline void complete_dock(void)
+{
+        ds->flags &= ~(DOCK_DOCKING);
+        ds->last_dock_time = jiffies;
+}
+
+
+static int dock_in_progress(void)
+{
+        if (ds->flags & DOCK_DOCKING ||
+                ds->last_dock_time == jiffies) {
+                dbg("dock in progress\n");
+                return 1;
+        }
+        return 0;
+}
+
+
+
+static void
+handle_hotplug_event_dock(acpi_handle handle, u32 type, void *context)
+{
+        dbg("%s: enter\n", __FUNCTION__);
+
+        switch (type) {
+                case ACPI_NOTIFY_BUS_CHECK:
+                        dbg("BUS Check\n");
+                        if (!dock_in_progress() && dock_present()) {
+                                begin_dock();
+                                dock();
+                                if (!dock_present()) {
+                                        err("Unable to dock!\n");
+                                        break;
+                                }
+                                post_dock_fixups();
+                                hotplug_pci(type);
+                                complete_dock();
+                        }
+                        break;
+                case ACPI_NOTIFY_EJECT_REQUEST:
+                        dbg("EJECT request\n");
+                        if (!dock_in_progress() && dock_present()) {
+                                hotplug_pci(type);
+                                undock();
+                                eject_dock();
+                                if (dock_present())
+                                        err("Unable to undock!\n");
+                        }
+                        break;
+        }
+}
+
+
+
+
+static acpi_status
+find_dock_ejd(acpi_handle handle, u32 lvl, void *context, void **rv)
+{
+        acpi_status status;
+        acpi_handle tmp;
+        acpi_handle dck_handle = (acpi_handle) context;
+        char objname[64];
+        struct acpi_buffer buffer = { .length = sizeof(objname),
+                                      .pointer = objname };
+        struct acpi_buffer ejd_buffer = {ACPI_ALLOCATE_BUFFER, NULL};
+        union acpi_object *ejd_obj;
+
+        status = acpi_get_handle(handle, "_EJD", &tmp);
+        if (ACPI_FAILURE(status))
+                return AE_OK;
+
+        /* make sure we are dependent on the dock device,
+         * by executing the _EJD method, then getting a handle
+         * to the device referenced by that name.  If that
+         * device handle is the same handle as the dock station
+         * handle, then we are a device dependent on the dock station
+         */
+        acpi_get_name(dck_handle, ACPI_FULL_PATHNAME, &buffer);
+        status = acpi_evaluate_object(handle, "_EJD", NULL, &ejd_buffer);
+        if (ACPI_FAILURE(status)) {
+                err("Unable to execute _EJD!\n");
+                goto find_ejd_out;
+        }
+        ejd_obj = ejd_buffer.pointer;
+        status = acpi_get_handle(NULL, ejd_obj->string.pointer, &tmp);
+        if (ACPI_FAILURE(status))
+                goto find_ejd_out;
+
+        if (tmp == dck_handle) {
+                struct dependent_device *dd;
+                dbg("%s: found device dependent on dock\n", __FUNCTION__);
+                dd = alloc_dependent_device(handle);
+                if (!dd) {
+                        err("Can't allocate memory for dependent device!\n");
+                        goto find_ejd_out;
+                }
+                add_dependent_device(dd);
+        }
+
+find_ejd_out:
+        acpi_os_free(ejd_buffer.pointer);
+        return AE_OK;
+}
+
+
+
+int detect_dependent_devices(acpi_handle *bridge_handle)
+{
+        acpi_status status;
+        int count;
+
+        count = 0;
+
+        status = acpi_walk_namespace(ACPI_TYPE_DEVICE, bridge_handle,
+                                        (u32)1, find_dependent_device,
+                                        (void *)&count, NULL);
+
+        return count;
+}
+
+
+
+
+
+static acpi_status
+find_dock(acpi_handle handle, u32 lvl, void *context, void **rv)
+{
+        int *count = (int *)context;
+
+        if (is_dock(handle)) {
+                dbg("%s: found dock\n", __FUNCTION__);
+                ds = kzalloc(sizeof(*ds), GFP_KERNEL);
+                ds->handle = handle;
+                INIT_LIST_HEAD(&ds->dependent_devices);
+                INIT_LIST_HEAD(&ds->pci_dependent_devices);
+
+                /* look for devices dependent on dock station */
+                acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
+                        ACPI_UINT32_MAX, find_dock_ejd, handle, NULL);
+
+                acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
+                        handle_hotplug_event_dock, ds);
+                (*count)++;
+        }
+
+        return AE_OK;
+}
+
+
+
+
+int find_dock_station(void)
+{
+        int num = 0;
+
+        ds = NULL;
+
+        /* start from the root object, because some laptops define
+         * _DCK methods outside the scope of PCI (IBM x-series laptop)
+         */
+        acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
+                        ACPI_UINT32_MAX, find_dock, &num, NULL);
+
+        return num;
+}
+
+
+
+void remove_dock_station(void)
+{
+        struct dependent_device *dd, *tmp;
+        if (ds) {
+                if (ACPI_FAILURE(acpi_remove_notify_handler(ds->handle,
+                        ACPI_SYSTEM_NOTIFY, handle_hotplug_event_dock)))
+                        err("failed to remove dock notify handler\n");
+
+                /* free all dependent devices */
+                list_for_each_entry_safe(dd, tmp, &ds->dependent_devices,
+                                device_list)
+                        kfree(dd);
+
+                /* no need to touch the pci_dependent_device list,
+                 * cause all memory was freed above
+                 */
+                kfree(ds);
+        }
+}
+
+
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index 509a5b3ae998..053ee843863c 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -46,7 +46,7 @@
 #include <linux/kernel.h>
 #include <linux/pci.h>
 #include <linux/smp_lock.h>
-#include <asm/semaphore.h>
+#include <linux/mutex.h>
 
 #include "../pci.h"
 #include "pci_hotplug.h"
@@ -57,7 +57,6 @@ static LIST_HEAD(bridge_list);
 #define MY_NAME "acpiphp_glue"
 
 static void handle_hotplug_event_bridge (acpi_handle, u32, void *);
-static void handle_hotplug_event_func (acpi_handle, u32, void *);
 static void acpiphp_sanitize_bus(struct pci_bus *bus);
 static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus);
 
@@ -125,11 +124,11 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
         struct acpiphp_bridge *bridge = (struct acpiphp_bridge *)context;
         struct acpiphp_slot *slot;
         struct acpiphp_func *newfunc;
+        struct dependent_device *dd;
         acpi_handle tmp;
         acpi_status status = AE_OK;
         unsigned long adr, sun;
-        int device, function;
-        static int num_slots = 0;       /* XXX if we support I/O node hotplug... */
+        int device, function, retval;
 
         status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
 
@@ -138,21 +137,21 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
 
         status = acpi_get_handle(handle, "_EJ0", &tmp);
 
-        if (ACPI_FAILURE(status))
+        if (ACPI_FAILURE(status) && !(is_dependent_device(handle)))
                 return AE_OK;
 
         device = (adr >> 16) & 0xffff;
         function = adr & 0xffff;
 
-        newfunc = kmalloc(sizeof(struct acpiphp_func), GFP_KERNEL);
+        newfunc = kzalloc(sizeof(struct acpiphp_func), GFP_KERNEL);
         if (!newfunc)
                 return AE_NO_MEMORY;
-        memset(newfunc, 0, sizeof(struct acpiphp_func));
 
         INIT_LIST_HEAD(&newfunc->sibling);
         newfunc->handle = handle;
         newfunc->function = function;
-        newfunc->flags = FUNC_HAS_EJ0;
+        if (ACPI_SUCCESS(status))
+                newfunc->flags = FUNC_HAS_EJ0;
 
         if (ACPI_SUCCESS(acpi_get_handle(handle, "_STA", &tmp)))
                 newfunc->flags |= FUNC_HAS_STA;
@@ -163,6 +162,19 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
         if (ACPI_SUCCESS(acpi_get_handle(handle, "_PS3", &tmp)))
                 newfunc->flags |= FUNC_HAS_PS3;
 
+        if (ACPI_SUCCESS(acpi_get_handle(handle, "_DCK", &tmp))) {
+                newfunc->flags |= FUNC_HAS_DCK;
+                /* add to devices dependent on dock station,
+                 * because this may actually be the dock bridge
+                 */
+                dd = alloc_dependent_device(handle);
+                if (!dd)
+                        err("Can't allocate memory for "
+                                "new dependent device!\n");
+                else
+                        add_dependent_device(dd);
+        }
+
         status = acpi_evaluate_integer(handle, "_SUN", NULL, &sun);
         if (ACPI_FAILURE(status))
                 sun = -1;
@@ -176,19 +188,17 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                 }
 
         if (!slot) {
-                slot = kmalloc(sizeof(struct acpiphp_slot), GFP_KERNEL);
+                slot = kzalloc(sizeof(struct acpiphp_slot), GFP_KERNEL);
                 if (!slot) {
                         kfree(newfunc);
                         return AE_NO_MEMORY;
                 }
 
-                memset(slot, 0, sizeof(struct acpiphp_slot));
                 slot->bridge = bridge;
-                slot->id = num_slots++;
                 slot->device = device;
                 slot->sun = sun;
                 INIT_LIST_HEAD(&slot->funcs);
-                init_MUTEX(&slot->crit_sect);
+                mutex_init(&slot->crit_sect);
 
                 slot->next = bridge->slots;
                 bridge->slots = slot;
@@ -198,6 +208,11 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                 dbg("found ACPI PCI Hotplug slot %d at PCI %04x:%02x:%02x\n",
                                 slot->sun, pci_domain_nr(bridge->pci_bus),
                                 bridge->pci_bus->number, slot->device);
+                retval = acpiphp_register_hotplug_slot(slot);
+                if (retval) {
+                        warn("acpiphp_register_hotplug_slot failed(err code = 0x%x)\n", retval);
+                        goto err_exit;
+                }
         }
 
         newfunc->slot = slot;
@@ -210,16 +225,41 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                 slot->flags |= (SLOT_ENABLED | SLOT_POWEREDON);
         }
 
+        /* if this is a device dependent on a dock station,
+         * associate the acpiphp_func to the dependent_device
+         * struct.
+         */
+        if ((dd = get_dependent_device(handle))) {
+                newfunc->flags |= FUNC_IS_DD;
+                /*
+                 * we don't want any devices which is dependent
+                 * on the dock to have it's _EJ0 method executed.
+                 * because we need to run _DCK first.
+                 */
+                newfunc->flags &= ~FUNC_HAS_EJ0;
+                dd->func = newfunc;
+                add_pci_dependent_device(dd);
+        }
+
         /* install notify handler */
-        status = acpi_install_notify_handler(handle,
+        if (!(newfunc->flags & FUNC_HAS_DCK)) {
+                status = acpi_install_notify_handler(handle,
                                              ACPI_SYSTEM_NOTIFY,
                                              handle_hotplug_event_func,
                                              newfunc);
 
-        if (ACPI_FAILURE(status)) {
-                err("failed to register interrupt notify handler\n");
-                return status;
-        }
+                if (ACPI_FAILURE(status))
+                        err("failed to register interrupt notify handler\n");
+        } else
+                status = AE_OK;
+
+        return status;
+
+ err_exit:
+        bridge->nr_slots--;
+        bridge->slots = slot->next;
+        kfree(slot);
+        kfree(newfunc);
 
         return AE_OK;
 }
@@ -245,57 +285,19 @@ static int detect_ejectable_slots(acpi_handle *bridge_handle)
 static void decode_hpp(struct acpiphp_bridge *bridge)
 {
         acpi_status status;
-        struct acpi_buffer buffer = { .length = ACPI_ALLOCATE_BUFFER,
-                                      .pointer = NULL};
-        union acpi_object *package;
-        int i;
-
-        /* default numbers */
-        bridge->hpp.cache_line_size = 0x10;
-        bridge->hpp.latency_timer = 0x40;
-        bridge->hpp.enable_SERR = 0;
-        bridge->hpp.enable_PERR = 0;
-
-        status = acpi_evaluate_object(bridge->handle, "_HPP", NULL, &buffer);
 
+        status = acpi_get_hp_params_from_firmware(bridge->pci_dev, &bridge->hpp);
         if (ACPI_FAILURE(status)) {
-                dbg("_HPP evaluation failed\n");
-                return;
+                /* use default numbers */
+                bridge->hpp.cache_line_size = 0x10;
+                bridge->hpp.latency_timer = 0x40;
+                bridge->hpp.enable_serr = 0;
+                bridge->hpp.enable_perr = 0;
         }
-
-        package = (union acpi_object *) buffer.pointer;
-
-        if (!package || package->type != ACPI_TYPE_PACKAGE ||
-            package->package.count != 4 || !package->package.elements) {
-                err("invalid _HPP object; ignoring\n");
-                goto err_exit;
-        }
-
-        for (i = 0; i < 4; i++) {
-                if (package->package.elements[i].type != ACPI_TYPE_INTEGER) {
-                        err("invalid _HPP parameter type; ignoring\n");
-                        goto err_exit;
-                }
-        }
-
-        bridge->hpp.cache_line_size = package->package.elements[0].integer.value;
-        bridge->hpp.latency_timer = package->package.elements[1].integer.value;
-        bridge->hpp.enable_SERR = package->package.elements[2].integer.value;
-        bridge->hpp.enable_PERR = package->package.elements[3].integer.value;
-
-        dbg("_HPP parameter = (%02x, %02x, %02x, %02x)\n",
-                bridge->hpp.cache_line_size,
-                bridge->hpp.latency_timer,
-                bridge->hpp.enable_SERR,
-                bridge->hpp.enable_PERR);
-
-        bridge->flags |= BRIDGE_HAS_HPP;
-
- err_exit:
-        kfree(buffer.pointer);
 }
 
 
+
 /* initialize miscellaneous stuff for both root and PCI-to-PCI bridge */
 static void init_bridge_misc(struct acpiphp_bridge *bridge)
 {
@@ -304,9 +306,16 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
         /* decode ACPI 2.0 _HPP (hot plug parameters) */
         decode_hpp(bridge);
 
+        /* must be added to the list prior to calling register_slot */
+        list_add(&bridge->list, &bridge_list);
+
         /* register all slot objects under this bridge */
         status = acpi_walk_namespace(ACPI_TYPE_DEVICE, bridge->handle, (u32)1,
                                      register_slot, bridge, NULL);
+        if (ACPI_FAILURE(status)) {
+                list_del(&bridge->list);
+                return;
+        }
 
         /* install notify handler */
         if (bridge->type != BRIDGE_TYPE_HOST) {
@@ -319,8 +328,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
                         err("failed to register interrupt notify handler\n");
                 }
         }
-
-        list_add(&bridge->list, &bridge_list);
 }
 
 
@@ -329,12 +336,10 @@ static void add_host_bridge(acpi_handle *handle, struct pci_bus *pci_bus)
 {
         struct acpiphp_bridge *bridge;
 
-        bridge = kmalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
+        bridge = kzalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
         if (bridge == NULL)
                 return;
 
-        memset(bridge, 0, sizeof(struct acpiphp_bridge));
-
         bridge->type = BRIDGE_TYPE_HOST;
         bridge->handle = handle;
 
@@ -351,14 +356,12 @@ static void add_p2p_bridge(acpi_handle *handle, struct pci_dev *pci_dev)
 {
         struct acpiphp_bridge *bridge;
 
-        bridge = kmalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
+        bridge = kzalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
         if (bridge == NULL) {
                 err("out of memory\n");
                 return;
         }
 
-        memset(bridge, 0, sizeof(struct acpiphp_bridge));
-
         bridge->type = BRIDGE_TYPE_P2P;
         bridge->handle = handle;
 
@@ -410,11 +413,18 @@ find_p2p_bridge(acpi_handle handle, u32 lvl, void *context, void **rv)
                 goto out;
 
         /* check if this bridge has ejectable slots */
-        if (detect_ejectable_slots(handle) > 0) {
+        if ((detect_ejectable_slots(handle) > 0) ||
+                (detect_dependent_devices(handle) > 0)) {
                 dbg("found PCI-to-PCI bridge at PCI %s\n", pci_name(dev));
                 add_p2p_bridge(handle, dev);
         }
 
+        /* search P2P bridges under this p2p bridge */
+        status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, (u32)1,
+                                     find_p2p_bridge, dev->subordinate, NULL);
+        if (ACPI_FAILURE(status))
+                warn("find_p2p_bridge faied (error code = 0x%x)\n", status);
+
  out:
         pci_dev_put(dev);
         return AE_OK;
@@ -512,15 +522,19 @@ static void cleanup_bridge(struct acpiphp_bridge *bridge)
                 list_for_each_safe (list, tmp, &slot->funcs) {
                         struct acpiphp_func *func;
                         func = list_entry(list, struct acpiphp_func, sibling);
-                        status = acpi_remove_notify_handler(func->handle,
+                        if (!(func->flags & FUNC_HAS_DCK)) {
+                                status = acpi_remove_notify_handler(func->handle,
                                                 ACPI_SYSTEM_NOTIFY,
                                                 handle_hotplug_event_func);
-                        if (ACPI_FAILURE(status))
-                                err("failed to remove notify handler\n");
+                                if (ACPI_FAILURE(status))
+                                        err("failed to remove notify handler\n");
+                        }
                         pci_dev_put(func->pci_dev);
                         list_del(list);
                         kfree(func);
                 }
+                acpiphp_unregister_hotplug_slot(slot);
+                list_del(&slot->funcs);
                 kfree(slot);
                 slot = next;
         }
@@ -551,7 +565,8 @@ static void remove_bridge(acpi_handle handle)
         } else {
                 /* clean-up p2p bridges under this host bridge */
                 acpi_walk_namespace(ACPI_TYPE_DEVICE, handle,
-                                (u32)1, cleanup_p2p_bridge, NULL, NULL);
+                                    ACPI_UINT32_MAX, cleanup_p2p_bridge,
+                                    NULL, NULL);
         }
 }
 
@@ -751,6 +766,113 @@ static int power_off_slot(struct acpiphp_slot *slot)
 }
 
 
+
+/**
+ * acpiphp_max_busnr - return the highest reserved bus number under
+ * the given bus.
+ * @bus: bus to start search with
+ *
+ */
+static unsigned char acpiphp_max_busnr(struct pci_bus *bus)
+{
+        struct list_head *tmp;
+        unsigned char max, n;
+
+        /*
+         * pci_bus_max_busnr will return the highest
+         * reserved busnr for all these children.
+         * that is equivalent to the bus->subordinate
+         * value.  We don't want to use the parent's
+         * bus->subordinate value because it could have
+         * padding in it.
+         */
+        max = bus->secondary;
+
+        list_for_each(tmp, &bus->children) {
+                n = pci_bus_max_busnr(pci_bus_b(tmp));
+                if (n > max)
+                        max = n;
+        }
+        return max;
+}
+
+
+
+/**
+ *  get_func - get a pointer to acpiphp_func given a slot, device
+ *  @slot: slot to search
+ *  @dev:  pci_dev struct to match.
+ *
+ *  This function will increase the reference count of pci_dev,
+ *  so callers should call pci_dev_put when complete.
+ *
+ */
+static struct acpiphp_func *
+get_func(struct acpiphp_slot *slot, struct pci_dev *dev)
+{
+        struct acpiphp_func *func = NULL;
+        struct pci_bus *bus = slot->bridge->pci_bus;
+        struct pci_dev *pdev;
+
+        list_for_each_entry(func, &slot->funcs, sibling) {
+                pdev = pci_get_slot(bus, PCI_DEVFN(slot->device,
+                                        func->function));
+                if (pdev) {
+                        if (pdev == dev)
+                                break;
+                        pci_dev_put(pdev);
+                }
+        }
+        return func;
+}
+
+
+/**
+ * acpiphp_bus_add - add a new bus to acpi subsystem
+ * @func: acpiphp_func of the bridge
+ *
+ */
+static int acpiphp_bus_add(struct acpiphp_func *func)
+{
+        acpi_handle phandle;
+        struct acpi_device *device, *pdevice;
+        int ret_val;
+
+        acpi_get_parent(func->handle, &phandle);
+        if (acpi_bus_get_device(phandle, &pdevice)) {
+                dbg("no parent device, assuming NULL\n");
+                pdevice = NULL;
+        }
+        if (!acpi_bus_get_device(func->handle, &device)) {
+                dbg("bus exists... trim\n");
+                /* this shouldn't be in here, so remove
+                 * the bus then re-add it...
+                 */
+                ret_val = acpi_bus_trim(device, 1);
+                dbg("acpi_bus_trim return %x\n", ret_val);
+        }
+
+        ret_val = acpi_bus_add(&device, pdevice, func->handle,
+                ACPI_BUS_TYPE_DEVICE);
+        if (ret_val) {
+                dbg("error adding bus, %x\n",
+                        -ret_val);
+                goto acpiphp_bus_add_out;
+        }
+        /*
+         * try to start anyway.  We could have failed to add
+         * simply because this bus had previously been added
+         * on another add.  Don't bother with the return value
+         * we just keep going.
+         */
+        ret_val = acpi_bus_start(device);
+
+acpiphp_bus_add_out:
+        return ret_val;
+}
+
+
+
 /**
  * enable_device - enable, configure a slot
  * @slot: slot to be enabled
@@ -788,7 +910,7 @@ static int enable_device(struct acpiphp_slot *slot)
                 goto err_exit;
         }
 
-        max = bus->secondary;
+        max = acpiphp_max_busnr(bus);
         for (pass = 0; pass < 2; pass++) {
                 list_for_each_entry(dev, &bus->devices, bus_list) {
                         if (PCI_SLOT(dev->devfn) != slot->device)
@@ -796,8 +918,15 @@ static int enable_device(struct acpiphp_slot *slot)
                         if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
                             dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
                                 max = pci_scan_bridge(bus, dev, max, pass);
-                                if (pass && dev->subordinate)
+                                if (pass && dev->subordinate) {
                                         pci_bus_size_bridges(dev->subordinate);
+                                        func = get_func(slot, dev);
+                                        if (func) {
+                                                acpiphp_bus_add(func);
+                                                /* side effect of get_func */
+                                                pci_dev_put(dev);
+                                        }
+                                }
                         }
                 }
         }
@@ -806,8 +935,8 @@ static int enable_device(struct acpiphp_slot *slot)
         acpiphp_sanitize_bus(bus);
         pci_enable_bridges(bus);
         pci_bus_add_devices(bus);
-        acpiphp_set_hpp_values(DEVICE_ACPI_HANDLE(&bus->self->dev), bus);
-        acpiphp_configure_ioapics(DEVICE_ACPI_HANDLE(&bus->self->dev));
+        acpiphp_set_hpp_values(slot->bridge->handle, bus);
+        acpiphp_configure_ioapics(slot->bridge->handle);
 
         /* associate pci_dev to our representation */
         list_for_each (l, &slot->funcs) {
@@ -987,11 +1116,11 @@ static void program_hpp(struct pci_dev *dev, struct acpiphp_bridge *bridge)
         pci_write_config_byte(dev, PCI_LATENCY_TIMER,
                         bridge->hpp.latency_timer);
         pci_read_config_word(dev, PCI_COMMAND, &pci_cmd);
-        if (bridge->hpp.enable_SERR)
+        if (bridge->hpp.enable_serr)
                 pci_cmd |= PCI_COMMAND_SERR;
         else
                 pci_cmd &= ~PCI_COMMAND_SERR;
-        if (bridge->hpp.enable_PERR)
+        if (bridge->hpp.enable_perr)
                 pci_cmd |= PCI_COMMAND_PARITY;
         else
                 pci_cmd &= ~PCI_COMMAND_PARITY;
@@ -1002,11 +1131,11 @@ static void program_hpp(struct pci_dev *dev, struct acpiphp_bridge *bridge)
                 pci_write_config_byte(dev, PCI_SEC_LATENCY_TIMER,
                                 bridge->hpp.latency_timer);
                 pci_read_config_word(dev, PCI_BRIDGE_CONTROL, &pci_bctl);
-                if (bridge->hpp.enable_SERR)
+                if (bridge->hpp.enable_serr)
                         pci_bctl |= PCI_BRIDGE_CTL_SERR;
                 else
                         pci_bctl &= ~PCI_BRIDGE_CTL_SERR;
-                if (bridge->hpp.enable_PERR)
+                if (bridge->hpp.enable_perr)
                         pci_bctl |= PCI_BRIDGE_CTL_PARITY;
                 else
                         pci_bctl &= ~PCI_BRIDGE_CTL_PARITY;
@@ -1026,6 +1155,7 @@ static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus)
 
         memset(&bridge, 0, sizeof(bridge));
         bridge.handle = handle;
+        bridge.pci_dev = bus->self;
         decode_hpp(&bridge);
         list_for_each_entry(dev, &bus->devices, bus_list)
                 program_hpp(dev, &bridge);
@@ -1200,7 +1330,7 @@ static void handle_hotplug_event_bridge(acpi_handle handle, u32 type, void *cont
  * handles ACPI event notification on slots
  *
  */
-static void handle_hotplug_event_func(acpi_handle handle, u32 type, void *context)
+void handle_hotplug_event_func(acpi_handle handle, u32 type, void *context)
 {
         struct acpiphp_func *func;
         char objname[64];
@@ -1242,41 +1372,13 @@ static void handle_hotplug_event_func(acpi_handle handle, u32 type, void *contex
         }
 }
 
-static int is_root_bridge(acpi_handle handle)
-{
-        acpi_status status;
-        struct acpi_device_info *info;
-        struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
-        int i;
-
-        status = acpi_get_object_info(handle, &buffer);
-        if (ACPI_SUCCESS(status)) {
-                info = buffer.pointer;
-                if ((info->valid & ACPI_VALID_HID) &&
-                        !strcmp(PCI_ROOT_HID_STRING,
-                                        info->hardware_id.value)) {
-                        acpi_os_free(buffer.pointer);
-                        return 1;
-                }
-                if (info->valid & ACPI_VALID_CID) {
-                        for (i=0; i < info->compatibility_id.count; i++) {
-                                if (!strcmp(PCI_ROOT_HID_STRING,
-                                        info->compatibility_id.id[i].value)) {
-                                        acpi_os_free(buffer.pointer);
-                                        return 1;
-                                }
-                        }
-                }
-        }
-        return 0;
-}
 
 static acpi_status
 find_root_bridges(acpi_handle handle, u32 lvl, void *context, void **rv)
 {
         int *count = (int *)context;
 
-        if (is_root_bridge(handle)) {
+        if (acpi_root_bridge(handle)) {
                 acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
                                 handle_hotplug_event_bridge, NULL);
                         (*count)++;
@@ -1373,26 +1475,6 @@ static int acpiphp_for_each_slot(acpiphp_callback fn, void *data)
 }
 #endif
 
-/* search matching slot from id  */
-struct acpiphp_slot *get_slot_from_id(int id)
-{
-        struct list_head *node;
-        struct acpiphp_bridge *bridge;
-        struct acpiphp_slot *slot;
-
-        list_for_each (node, &bridge_list) {
-                bridge = (struct acpiphp_bridge *)node;
-                for (slot = bridge->slots; slot; slot = slot->next)
-                        if (slot->id == id)
-                                return slot;
-        }
-
-        /* should never happen! */
-        err("%s: no object for id %d\n", __FUNCTION__, id);
-        WARN_ON(1);
-        return NULL;
-}
-
 
 /**
  * acpiphp_enable_slot - power on slot
@@ -1401,7 +1483,7 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot)
 {
         int retval;
 
-        down(&slot->crit_sect);
+        mutex_lock(&slot->crit_sect);
 
         /* wake up all functions */
         retval = power_on_slot(slot);
@@ -1413,7 +1495,7 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot)
                 retval = enable_device(slot);
 
  err_exit:
-        up(&slot->crit_sect);
+        mutex_unlock(&slot->crit_sect);
         return retval;
 }
 
@@ -1424,7 +1506,7 @@ int acpiphp_disable_slot(struct acpiphp_slot *slot)
 {
         int retval = 0;
 
-        down(&slot->crit_sect);
+        mutex_lock(&slot->crit_sect);
 
         /* unconfigure all functions */
         retval = disable_device(slot);
@@ -1437,7 +1519,7 @@ int acpiphp_disable_slot(struct acpiphp_slot *slot)
                 goto err_exit;
 
  err_exit:
-        up(&slot->crit_sect);
+        mutex_unlock(&slot->crit_sect);
         return retval;
 }
 
diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c
index 30af105271a2..037ce4c91687 100644
--- a/drivers/pci/hotplug/cpci_hotplug_core.c
+++ b/drivers/pci/hotplug/cpci_hotplug_core.c
@@ -248,22 +248,19 @@ cpci_hp_register_bus(struct pci_bus *bus, u8 first, u8 last)
          * with the pci_hotplug subsystem.
          */
         for (i = first; i <= last; ++i) {
-                slot = kmalloc(sizeof (struct slot), GFP_KERNEL);
+                slot = kzalloc(sizeof (struct slot), GFP_KERNEL);
                 if (!slot)
                         goto error;
-                memset(slot, 0, sizeof (struct slot));
 
                 hotplug_slot =
-                    kmalloc(sizeof (struct hotplug_slot), GFP_KERNEL);
+                        kzalloc(sizeof (struct hotplug_slot), GFP_KERNEL);
                 if (!hotplug_slot)
                         goto error_slot;
-                memset(hotplug_slot, 0, sizeof (struct hotplug_slot));
                 slot->hotplug_slot = hotplug_slot;
 
-                info = kmalloc(sizeof (struct hotplug_slot_info), GFP_KERNEL);
+                info = kzalloc(sizeof (struct hotplug_slot_info), GFP_KERNEL);
                 if (!info)
                         goto error_hpslot;
-                memset(info, 0, sizeof (struct hotplug_slot_info));
                 hotplug_slot->info = info;
 
                 name = kmalloc(SLOT_NAME_SIZE, GFP_KERNEL);
diff --git a/drivers/pci/hotplug/cpqphp.h b/drivers/pci/hotplug/cpqphp.h
index cb88404c89fe..c74e9e37e76b 100644
--- a/drivers/pci/hotplug/cpqphp.h
+++ b/drivers/pci/hotplug/cpqphp.h
@@ -32,6 +32,7 @@
 #include <linux/interrupt.h>
 #include <asm/io.h>             /* for read? and write? functions */
 #include <linux/delay.h>        /* for delays */
+#include <linux/mutex.h>
 
 #define MY_NAME "cpqphp"
 
@@ -286,7 +287,7 @@ struct event_info {
 struct controller {
         struct controller *next;
         u32 ctrl_int_comp;
-        struct semaphore crit_sect;     /* critical section semaphore */
+        struct mutex crit_sect;         /* critical section mutex */
         void __iomem *hpc_reg;          /* cookie for our pci controller location */
         struct pci_resource *mem_head;
         struct pci_resource *p_mem_head;
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
index b3659ffccac9..9bc1deb8df52 100644
--- a/drivers/pci/hotplug/cpqphp_core.c
+++ b/drivers/pci/hotplug/cpqphp_core.c
@@ -347,26 +347,22 @@ static int ctrl_slot_setup(struct controller *ctrl,
         slot_number = ctrl->first_slot;
 
         while (number_of_slots) {
-                slot = kmalloc(sizeof(*slot), GFP_KERNEL);
+                slot = kzalloc(sizeof(*slot), GFP_KERNEL);
                 if (!slot)
                         goto error;
 
-                memset(slot, 0, sizeof(struct slot));
-                slot->hotplug_slot = kmalloc(sizeof(*(slot->hotplug_slot)),
+                slot->hotplug_slot = kzalloc(sizeof(*(slot->hotplug_slot)),
                                                 GFP_KERNEL);
                 if (!slot->hotplug_slot)
                         goto error_slot;
                 hotplug_slot = slot->hotplug_slot;
-                memset(hotplug_slot, 0, sizeof(struct hotplug_slot));
 
                 hotplug_slot->info =
-                                kmalloc(sizeof(*(hotplug_slot->info)),
+                                kzalloc(sizeof(*(hotplug_slot->info)),
                                                         GFP_KERNEL);
                 if (!hotplug_slot->info)
                         goto error_hpslot;
                 hotplug_slot_info = hotplug_slot->info;
-                memset(hotplug_slot_info, 0,
-                                sizeof(struct hotplug_slot_info));
                 hotplug_slot->name = kmalloc(SLOT_NAME_SIZE, GFP_KERNEL);
 
                 if (!hotplug_slot->name)
@@ -599,7 +595,7 @@ cpqhp_set_attention_status(struct controller *ctrl, struct pci_func *func,
         hp_slot = func->device - ctrl->slot_device_offset;
 
         // Wait for exclusive access to hardware
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         if (status == 1) {
                 amber_LED_on (ctrl, hp_slot);
@@ -607,7 +603,7 @@ cpqhp_set_attention_status(struct controller *ctrl, struct pci_func *func,
                 amber_LED_off (ctrl, hp_slot);
         } else {
                 // Done with exclusive hardware access
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
                 return(1);
         }
 
@@ -617,7 +613,7 @@ cpqhp_set_attention_status(struct controller *ctrl, struct pci_func *func,
         wait_for_ctrl_irq (ctrl);
 
         // Done with exclusive hardware access
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         return(0);
 }
@@ -854,13 +850,12 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                         goto err_disable_device;
                 }
 
-                ctrl = (struct controller *) kmalloc(sizeof(struct controller), GFP_KERNEL);
+                ctrl = kzalloc(sizeof(struct controller), GFP_KERNEL);
                 if (!ctrl) {
                         err("%s : out of memory\n", __FUNCTION__);
                         rc = -ENOMEM;
                         goto err_disable_device;
                 }
-                memset(ctrl, 0, sizeof(struct controller));
 
                 rc = pci_read_config_word(pdev, PCI_SUBSYSTEM_ID, &subsystem_deviceid);
                 if (rc) {
@@ -1084,7 +1079,7 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         dbg("bus device function rev: %d %d %d %d\n", ctrl->bus,
                 PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn), ctrl->rev);
 
-        init_MUTEX(&ctrl->crit_sect);
+        mutex_init(&ctrl->crit_sect);
         init_waitqueue_head(&ctrl->queue);
 
         /* initialize our threads if they haven't already been started up */
@@ -1223,7 +1218,7 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
         // turn off empty slots here unless command line option "ON" set
         // Wait for exclusive access to hardware
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         num_of_slots = readb(ctrl->hpc_reg + SLOT_MASK) & 0x0F;
 
@@ -1270,12 +1265,12 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         rc = init_SERR(ctrl);
         if (rc) {
                 err("init_SERR failed\n");
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
                 goto err_free_irq;
         }
 
         // Done with exclusive hardware access
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         cpqhp_create_debugfs_files(ctrl);
 
diff --git a/drivers/pci/hotplug/cpqphp_ctrl.c b/drivers/pci/hotplug/cpqphp_ctrl.c
index 771ed34b1819..55d2dc7e39ca 100644
--- a/drivers/pci/hotplug/cpqphp_ctrl.c
+++ b/drivers/pci/hotplug/cpqphp_ctrl.c
@@ -1282,9 +1282,7 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
         u8 hp_slot;
         u8 temp_byte;
         u8 adapter_speed;
-        u32 index;
         u32 rc = 0;
-        u32 src = 8;
 
         hp_slot = func->device - ctrl->slot_device_offset;
 
@@ -1299,7 +1297,7 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
                  **********************************/
                 rc = CARD_FUNCTIONING;
         } else {
-                down(&ctrl->crit_sect);
+                mutex_lock(&ctrl->crit_sect);
 
                 /* turn on board without attaching to the bus */
                 enable_slot_power (ctrl, hp_slot);
@@ -1333,12 +1331,12 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
                 /* Wait for SOBS to be unset */
                 wait_for_ctrl_irq (ctrl);
 
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
 
                 if (rc)
                         return rc;
 
-                down(&ctrl->crit_sect);
+                mutex_lock(&ctrl->crit_sect);
 
                 slot_enable (ctrl, hp_slot);
                 green_LED_blink (ctrl, hp_slot);
@@ -1350,7 +1348,7 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
                 /* Wait for SOBS to be unset */
                 wait_for_ctrl_irq (ctrl);
 
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
 
                 /* Wait for ~1 second because of hot plug spec */
                 long_delay(1*HZ);
@@ -1368,76 +1366,30 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
 
                         rc = cpqhp_configure_board(ctrl, func);
 
-                        if (rc || src) {
-                                /* If configuration fails, turn it off
-                                 * Get slot won't work for devices behind
-                                 * bridges, but in this case it will always be
-                                 * called for the "base" bus/dev/func of an
-                                 * adapter. */
+                        /* If configuration fails, turn it off
+                         * Get slot won't work for devices behind
+                         * bridges, but in this case it will always be
+                         * called for the "base" bus/dev/func of an
+                         * adapter. */
 
-                                down(&ctrl->crit_sect);
+                        mutex_lock(&ctrl->crit_sect);
 
-                                amber_LED_on (ctrl, hp_slot);
-                                green_LED_off (ctrl, hp_slot);
-                                slot_disable (ctrl, hp_slot);
-
-                                set_SOGO(ctrl);
-
-                                /* Wait for SOBS to be unset */
-                                wait_for_ctrl_irq (ctrl);
-
-                                up(&ctrl->crit_sect);
-
-                                if (rc)
-                                        return rc;
-                                else
-                                        return 1;
-                        }
-
-                        func->status = 0;
-                        func->switch_save = 0x10;
-
-                        index = 1;
-                        while (((func = cpqhp_slot_find(func->bus, func->device, index)) != NULL) && !rc) {
-                                rc |= cpqhp_configure_board(ctrl, func);
-                                index++;
-                        }
-
-                        if (rc) {
-                                /* If configuration fails, turn it off
-                                 * Get slot won't work for devices behind
-                                 * bridges, but in this case it will always be
-                                 * called for the "base" bus/dev/func of an
-                                 * adapter. */
-
-                                down(&ctrl->crit_sect);
-
-                                amber_LED_on (ctrl, hp_slot);
-                                green_LED_off (ctrl, hp_slot);
-                                slot_disable (ctrl, hp_slot);
-
-                                set_SOGO(ctrl);
-
-                                /* Wait for SOBS to be unset */
-                                wait_for_ctrl_irq (ctrl);
-
-                                up(&ctrl->crit_sect);
-
-                                return rc;
-                        }
-                        /* Done configuring so turn LED on full time */
-
-                        down(&ctrl->crit_sect);
-
-                        green_LED_on (ctrl, hp_slot);
+                        amber_LED_on (ctrl, hp_slot);
+                        green_LED_off (ctrl, hp_slot);
+                        slot_disable (ctrl, hp_slot);
 
                         set_SOGO(ctrl);
 
                         /* Wait for SOBS to be unset */
                         wait_for_ctrl_irq (ctrl);
 
-                        up(&ctrl->crit_sect);
-                        rc = 0;
+                        mutex_unlock(&ctrl->crit_sect);
+
+                        if (rc)
+                                return rc;
+                        else
+                                return 1;
+
                 } else {
                         /* Something is wrong
 
@@ -1445,7 +1397,7 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
                          * in this case it will always be called for the "base"
                          * bus/dev/func of an adapter. */
 
-                        down(&ctrl->crit_sect);
+                        mutex_lock(&ctrl->crit_sect);
 
                         amber_LED_on (ctrl, hp_slot);
                         green_LED_off (ctrl, hp_slot);
@@ -1456,7 +1408,7 @@ static u32 board_replaced(struct pci_func *func, struct controller *ctrl)
                         /* Wait for SOBS to be unset */
                         wait_for_ctrl_irq (ctrl);
 
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                 }
 
         }
@@ -1488,7 +1440,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
         dbg("%s: func->device, slot_offset, hp_slot = %d, %d ,%d\n",
             __FUNCTION__, func->device, ctrl->slot_device_offset, hp_slot);
 
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         /* turn on board without attaching to the bus */
         enable_slot_power(ctrl, hp_slot);
@@ -1522,7 +1474,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
         /* Wait for SOBS to be unset */
         wait_for_ctrl_irq(ctrl);
 
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         if (rc)
                 return rc;
@@ -1532,7 +1484,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
         /* turn on board and blink green LED */
 
         dbg("%s: before down\n", __FUNCTION__);
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
         dbg("%s: after down\n", __FUNCTION__);
 
         dbg("%s: before slot_enable\n", __FUNCTION__);
@@ -1553,7 +1505,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
         dbg("%s: after wait_for_ctrl_irq\n", __FUNCTION__);
 
         dbg("%s: before up\n", __FUNCTION__);
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
         dbg("%s: after up\n", __FUNCTION__);
 
         /* Wait for ~1 second because of hot plug spec */
@@ -1607,7 +1559,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
                 cpqhp_resource_sort_and_combine(&(ctrl->bus_head));
 
                 if (rc) {
-                        down(&ctrl->crit_sect);
+                        mutex_lock(&ctrl->crit_sect);
 
                         amber_LED_on (ctrl, hp_slot);
                         green_LED_off (ctrl, hp_slot);
@@ -1618,7 +1570,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
                         /* Wait for SOBS to be unset */
                         wait_for_ctrl_irq (ctrl);
 
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         return rc;
                 } else {
                         cpqhp_save_slot_config(ctrl, func);
@@ -1640,7 +1592,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
                         }
                 } while (new_slot);
 
-                down(&ctrl->crit_sect);
+                mutex_lock(&ctrl->crit_sect);
 
                 green_LED_on (ctrl, hp_slot);
 
@@ -1649,9 +1601,9 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
                 /* Wait for SOBS to be unset */
                 wait_for_ctrl_irq (ctrl);
 
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
         } else {
-                down(&ctrl->crit_sect);
+                mutex_lock(&ctrl->crit_sect);
 
                 amber_LED_on (ctrl, hp_slot);
                 green_LED_off (ctrl, hp_slot);
@@ -1662,7 +1614,7 @@ static u32 board_added(struct pci_func *func, struct controller *ctrl)
                 /* Wait for SOBS to be unset */
                 wait_for_ctrl_irq (ctrl);
 
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
 
                 return rc;
         }
@@ -1721,7 +1673,7 @@ static u32 remove_board(struct pci_func * func, u32 replace_flag, struct control
                 func->status = 0x01;
         func->configured = 0;
 
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         green_LED_off (ctrl, hp_slot);
         slot_disable (ctrl, hp_slot);
@@ -1736,7 +1688,7 @@ static u32 remove_board(struct pci_func * func, u32 replace_flag, struct control
         /* Wait for SOBS to be unset */
         wait_for_ctrl_irq (ctrl);
 
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         if (!replace_flag && ctrl->add_support) {
                 while (func) {
@@ -1899,7 +1851,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                         dbg("button cancel\n");
                                         del_timer(&p_slot->task_event);
 
-                                        down(&ctrl->crit_sect);
+                                        mutex_lock(&ctrl->crit_sect);
 
                                         if (p_slot->state == BLINKINGOFF_STATE) {
                                                 /* slot is on */
@@ -1922,7 +1874,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                         /* Wait for SOBS to be unset */
                                         wait_for_ctrl_irq (ctrl);
 
-                                        up(&ctrl->crit_sect);
+                                        mutex_unlock(&ctrl->crit_sect);
                                 }
                                 /*** button Released (No action on press...) */
                                 else if (ctrl->event_queue[loop].event_type == INT_BUTTON_RELEASE) {
@@ -1937,7 +1889,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                 p_slot->state = BLINKINGON_STATE;
                                                 info(msg_button_on, p_slot->number);
                                         }
-                                        down(&ctrl->crit_sect);
+                                        mutex_lock(&ctrl->crit_sect);
                                         
                                         dbg("blink green LED and turn off amber\n");
                                         
@@ -1949,7 +1901,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                         /* Wait for SOBS to be unset */
                                         wait_for_ctrl_irq (ctrl);
 
-                                        up(&ctrl->crit_sect);
+                                        mutex_unlock(&ctrl->crit_sect);
                                         init_timer(&p_slot->task_event);
                                         p_slot->hp_slot = hp_slot;
                                         p_slot->ctrl = ctrl;
diff --git a/drivers/pci/hotplug/fakephp.c b/drivers/pci/hotplug/fakephp.c
index 060d74775d7b..71b80c23e8ce 100644
--- a/drivers/pci/hotplug/fakephp.c
+++ b/drivers/pci/hotplug/fakephp.c
@@ -95,15 +95,13 @@ static int add_slot(struct pci_dev *dev)
         struct hotplug_slot *slot;
         int retval = -ENOMEM;
 
-        slot = kmalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
+        slot = kzalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
         if (!slot)
                 goto error;
-        memset(slot, 0, sizeof(*slot));
 
-        slot->info = kmalloc(sizeof(struct hotplug_slot_info), GFP_KERNEL);
+        slot->info = kzalloc(sizeof(struct hotplug_slot_info), GFP_KERNEL);
         if (!slot->info)
                 goto error_slot;
-        memset(slot->info, 0, sizeof(struct hotplug_slot_info));
 
         slot->info->power_status = 1;
         slot->info->max_bus_speed = PCI_SPEED_UNKNOWN;
@@ -227,11 +225,10 @@ static void pci_rescan_bus(const struct pci_bus *bus)
 {
         unsigned int devfn;
         struct pci_dev *dev;
-        dev = kmalloc(sizeof(struct pci_dev), GFP_KERNEL);
+        dev = kzalloc(sizeof(struct pci_dev), GFP_KERNEL);
         if (!dev)
                 return;
 
-        memset(dev, 0, sizeof(dev));
         dev->bus = (struct pci_bus*)bus;
         dev->sysdata = bus->sysdata;
         for (devfn = 0; devfn < 0x100; devfn += 8) {
diff --git a/drivers/pci/hotplug/ibmphp.h b/drivers/pci/hotplug/ibmphp.h
index c22e0284d7b1..dba6d8ca9bda 100644
--- a/drivers/pci/hotplug/ibmphp.h
+++ b/drivers/pci/hotplug/ibmphp.h
@@ -406,8 +406,6 @@ extern void ibmphp_hpc_stop_poll_thread (void);
 //----------------------------------------------------------------------------
 // HPC return codes
 //----------------------------------------------------------------------------
-#define FALSE                           0x00
-#define TRUE                            0x01
 #define HPC_ERROR                       0xFF
 
 //-----------------------------------------------------------------------------
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index dc59da675c08..e13d5b87241a 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -1141,7 +1141,7 @@ static int enable_slot(struct hotplug_slot *hs)
                 goto error_power;
         }
 
-        slot_cur->func = kmalloc(sizeof(struct pci_func), GFP_KERNEL);
+        slot_cur->func = kzalloc(sizeof(struct pci_func), GFP_KERNEL);
         if (!slot_cur->func) {
                 /* We cannot do update_slot_info here, since no memory for
                  * kmalloc n.e.ways, and update_slot_info allocates some */
@@ -1149,7 +1149,6 @@ static int enable_slot(struct hotplug_slot *hs)
                 rc = -ENOMEM;
                 goto error_power;
         }
-        memset(slot_cur->func, 0, sizeof(struct pci_func));
         slot_cur->func->busno = slot_cur->bus;
         slot_cur->func->device = slot_cur->device;
         for (i = 0; i < 4; i++)
@@ -1240,9 +1239,9 @@ int ibmphp_do_disable_slot(struct slot *slot_cur)
         }
         
         flag = slot_cur->flag;
-        slot_cur->flag = TRUE;
+        slot_cur->flag = 1;
 
-        if (flag == TRUE) {
+        if (flag == 1) {
                 rc = validate(slot_cur, DISABLE);
                         /* checking if powered off already & valid slot # */
                 if (rc)
@@ -1252,13 +1251,12 @@ int ibmphp_do_disable_slot(struct slot *slot_cur)
 
         if (slot_cur->func == NULL) {
                 /* We need this for fncs's that were there on bootup */
-                slot_cur->func = kmalloc(sizeof(struct pci_func), GFP_KERNEL);
+                slot_cur->func = kzalloc(sizeof(struct pci_func), GFP_KERNEL);
                 if (!slot_cur->func) {
                         err("out of system memory\n");
                         rc = -ENOMEM;
                         goto error;
                 }
-                memset(slot_cur->func, 0, sizeof(struct pci_func));
                 slot_cur->func->busno = slot_cur->bus;
                 slot_cur->func->device = slot_cur->device;
         }
diff --git a/drivers/pci/hotplug/ibmphp_ebda.c b/drivers/pci/hotplug/ibmphp_ebda.c
index aea1187c73ad..05e4f5a1927a 100644
--- a/drivers/pci/hotplug/ibmphp_ebda.c
+++ b/drivers/pci/hotplug/ibmphp_ebda.c
@@ -72,13 +72,7 @@ static int ebda_rio_table (void);
 
 static struct ebda_hpc_list * __init alloc_ebda_hpc_list (void)
 {
-        struct ebda_hpc_list *list;
-
-        list = kmalloc (sizeof (struct ebda_hpc_list), GFP_KERNEL);
-        if (!list)
-                return NULL;
-        memset (list, 0, sizeof (*list));
-        return list;
+        return kzalloc(sizeof(struct ebda_hpc_list), GFP_KERNEL);
 }
 
 static struct controller *alloc_ebda_hpc (u32 slot_count, u32 bus_count)
@@ -87,21 +81,18 @@ static struct controller *alloc_ebda_hpc (u32 slot_count, u32 bus_count)
         struct ebda_hpc_slot *slots;
         struct ebda_hpc_bus *buses;
 
-        controller = kmalloc (sizeof (struct controller), GFP_KERNEL);
+        controller = kzalloc(sizeof(struct controller), GFP_KERNEL);
         if (!controller)
                 goto error;
-        memset (controller, 0, sizeof (*controller));
 
-        slots = kmalloc (sizeof (struct ebda_hpc_slot) * slot_count, GFP_KERNEL);
+        slots = kcalloc(slot_count, sizeof(struct ebda_hpc_slot), GFP_KERNEL);
         if (!slots)
                 goto error_contr;
-        memset (slots, 0, sizeof (*slots) * slot_count);
         controller->slots = slots;
 
-        buses = kmalloc (sizeof (struct ebda_hpc_bus) * bus_count, GFP_KERNEL);
+        buses = kcalloc(bus_count, sizeof(struct ebda_hpc_bus), GFP_KERNEL);
         if (!buses)
                 goto error_slots;
-        memset (buses, 0, sizeof (*buses) * bus_count);
         controller->buses = buses;
 
         return controller;
@@ -122,24 +113,12 @@ static void free_ebda_hpc (struct controller *controller)
 
 static struct ebda_rsrc_list * __init alloc_ebda_rsrc_list (void)
 {
-        struct ebda_rsrc_list *list;
-
-        list = kmalloc (sizeof (struct ebda_rsrc_list), GFP_KERNEL);
-        if (!list)
-                return NULL;
-        memset (list, 0, sizeof (*list));
-        return list;
+        return kzalloc(sizeof(struct ebda_rsrc_list), GFP_KERNEL);
 }
 
 static struct ebda_pci_rsrc *alloc_ebda_pci_rsrc (void)
 {
-        struct ebda_pci_rsrc *resource;
-
-        resource = kmalloc (sizeof (struct ebda_pci_rsrc), GFP_KERNEL);
-        if (!resource)
-                return NULL;
-        memset (resource, 0, sizeof (*resource));
-        return resource;
+        return kzalloc(sizeof(struct ebda_pci_rsrc), GFP_KERNEL);
 }
 
 static void __init print_bus_info (void)
@@ -390,10 +369,9 @@ int __init ibmphp_access_ebda (void)
                         debug ("now enter io table ---\n");
                         debug ("rio blk id: %x\n", blk_id);
 
-                        rio_table_ptr = kmalloc (sizeof (struct rio_table_hdr), GFP_KERNEL);
+                        rio_table_ptr = kzalloc(sizeof(struct rio_table_hdr), GFP_KERNEL);
                         if (!rio_table_ptr)
                                 return -ENOMEM; 
-                        memset (rio_table_ptr, 0, sizeof (struct rio_table_hdr) );
                         rio_table_ptr->ver_num = readb (io_mem + offset);
                         rio_table_ptr->scal_count = readb (io_mem + offset + 1);
                         rio_table_ptr->riodev_count = readb (io_mem + offset + 2);
@@ -445,10 +423,9 @@ static int __init ebda_rio_table (void)
 
         // we do concern about rio details
         for (i = 0; i < rio_table_ptr->riodev_count; i++) {
-                rio_detail_ptr = kmalloc (sizeof (struct rio_detail), GFP_KERNEL);
+                rio_detail_ptr = kzalloc(sizeof(struct rio_detail), GFP_KERNEL);
                 if (!rio_detail_ptr)
                         return -ENOMEM;
-                memset (rio_detail_ptr, 0, sizeof (struct rio_detail));
                 rio_detail_ptr->rio_node_id = readb (io_mem + offset);
                 rio_detail_ptr->bbar = readl (io_mem + offset + 1);
                 rio_detail_ptr->rio_type = readb (io_mem + offset + 5);
@@ -503,10 +480,9 @@ static int __init combine_wpg_for_chassis (void)
                 rio_detail_ptr = list_entry (list_head_ptr, struct rio_detail, rio_detail_list);
                 opt_rio_ptr = search_opt_vg (rio_detail_ptr->chassis_num);
                 if (!opt_rio_ptr) {
-                        opt_rio_ptr = (struct opt_rio *) kmalloc (sizeof (struct opt_rio), GFP_KERNEL);
+                        opt_rio_ptr = kzalloc(sizeof(struct opt_rio), GFP_KERNEL);
                         if (!opt_rio_ptr)
                                 return -ENOMEM;
-                        memset (opt_rio_ptr, 0, sizeof (struct opt_rio));
                         opt_rio_ptr->rio_type = rio_detail_ptr->rio_type;
                         opt_rio_ptr->chassis_num = rio_detail_ptr->chassis_num;
                         opt_rio_ptr->first_slot_num = rio_detail_ptr->first_slot_num;
@@ -546,10 +522,9 @@ static int combine_wpg_for_expansion (void)
                 rio_detail_ptr = list_entry (list_head_ptr, struct rio_detail, rio_detail_list);
                 opt_rio_lo_ptr = search_opt_lo (rio_detail_ptr->chassis_num);
                 if (!opt_rio_lo_ptr) {
-                        opt_rio_lo_ptr = (struct opt_rio_lo *) kmalloc (sizeof (struct opt_rio_lo), GFP_KERNEL);
+                        opt_rio_lo_ptr = kzalloc(sizeof(struct opt_rio_lo), GFP_KERNEL);
                         if (!opt_rio_lo_ptr)
                                 return -ENOMEM;
-                        memset (opt_rio_lo_ptr, 0, sizeof (struct opt_rio_lo));
                         opt_rio_lo_ptr->rio_type = rio_detail_ptr->rio_type;
                         opt_rio_lo_ptr->chassis_num = rio_detail_ptr->chassis_num;
                         opt_rio_lo_ptr->first_slot_num = rio_detail_ptr->first_slot_num;
@@ -842,12 +817,11 @@ static int __init ebda_rsrc_controller (void)
 
                         bus_info_ptr2 = ibmphp_find_same_bus_num (slot_ptr->slot_bus_num);
                         if (!bus_info_ptr2) {
-                                bus_info_ptr1 = (struct bus_info *) kmalloc (sizeof (struct bus_info), GFP_KERNEL);
+                                bus_info_ptr1 = kzalloc(sizeof(struct bus_info), GFP_KERNEL);
                                 if (!bus_info_ptr1) {
                                         rc = -ENOMEM;
                                         goto error_no_hp_slot;
                                 }
-                                memset (bus_info_ptr1, 0, sizeof (struct bus_info));
                                 bus_info_ptr1->slot_min = slot_ptr->slot_num;
                                 bus_info_ptr1->slot_max = slot_ptr->slot_num;
                                 bus_info_ptr1->slot_count += 1;
@@ -946,19 +920,17 @@ static int __init ebda_rsrc_controller (void)
                 // register slots with hpc core as well as create linked list of ibm slot
                 for (index = 0; index < hpc_ptr->slot_count; index++) {
 
-                        hp_slot_ptr = kmalloc(sizeof(*hp_slot_ptr), GFP_KERNEL);
+                        hp_slot_ptr = kzalloc(sizeof(*hp_slot_ptr), GFP_KERNEL);
                         if (!hp_slot_ptr) {
                                 rc = -ENOMEM;
                                 goto error_no_hp_slot;
                         }
-                        memset(hp_slot_ptr, 0, sizeof(*hp_slot_ptr));
 
-                        hp_slot_ptr->info = kmalloc (sizeof(struct hotplug_slot_info), GFP_KERNEL);
+                        hp_slot_ptr->info = kzalloc(sizeof(struct hotplug_slot_info), GFP_KERNEL);
                         if (!hp_slot_ptr->info) {
                                 rc = -ENOMEM;
                                 goto error_no_hp_info;
                         }
-                        memset(hp_slot_ptr->info, 0, sizeof(struct hotplug_slot_info));
 
                         hp_slot_ptr->name = kmalloc(30, GFP_KERNEL);
                         if (!hp_slot_ptr->name) {
@@ -966,14 +938,13 @@ static int __init ebda_rsrc_controller (void)
                                 goto error_no_hp_name;
                         }
 
-                        tmp_slot = kmalloc(sizeof(*tmp_slot), GFP_KERNEL);
+                        tmp_slot = kzalloc(sizeof(*tmp_slot), GFP_KERNEL);
                         if (!tmp_slot) {
                                 rc = -ENOMEM;
                                 goto error_no_slot;
                         }
-                        memset(tmp_slot, 0, sizeof(*tmp_slot));
 
-                        tmp_slot->flag = TRUE;
+                        tmp_slot->flag = 1;
 
                         tmp_slot->capabilities = hpc_ptr->slots[index].slot_cap;
                         if ((hpc_ptr->slots[index].slot_cap & EBDA_SLOT_133_MAX) == EBDA_SLOT_133_MAX)
diff --git a/drivers/pci/hotplug/ibmphp_hpc.c b/drivers/pci/hotplug/ibmphp_hpc.c
index 1a3eb8d3d4cb..c3ac98a0a6a6 100644
--- a/drivers/pci/hotplug/ibmphp_hpc.c
+++ b/drivers/pci/hotplug/ibmphp_hpc.c
@@ -34,9 +34,11 @@
 #include <linux/pci.h>
 #include <linux/smp_lock.h>
 #include <linux/init.h>
+#include <linux/mutex.h>
+
 #include "ibmphp.h"
 
-static int to_debug = FALSE;
+static int to_debug = 0;
 #define debug_polling(fmt, arg...)      do { if (to_debug) debug (fmt, arg); } while (0)
 
 //----------------------------------------------------------------------------
@@ -93,15 +95,15 @@ static int to_debug = FALSE;
 //----------------------------------------------------------------------------
 // macro utilities
 //----------------------------------------------------------------------------
-// if bits 20,22,25,26,27,29,30 are OFF return TRUE
-#define HPC_I2CSTATUS_CHECK(s)  ((u8)((s & 0x00000A76) ? FALSE : TRUE))
+// if bits 20,22,25,26,27,29,30 are OFF return 1
+#define HPC_I2CSTATUS_CHECK(s)  ((u8)((s & 0x00000A76) ? 0 : 1))
 
 //----------------------------------------------------------------------------
 // global variables
 //----------------------------------------------------------------------------
 static int ibmphp_shutdown;
 static int tid_poll;
-static struct semaphore sem_hpcaccess;  // lock access to HPC
+static struct mutex sem_hpcaccess;      // lock access to HPC
 static struct semaphore semOperations;  // lock all operations and
                                         // access to data structures
 static struct semaphore sem_exit;       // make sure polling thread goes away
@@ -131,11 +133,11 @@ void __init ibmphp_hpc_initvars (void)
 {
         debug ("%s - Entry\n", __FUNCTION__);
 
-        init_MUTEX (&sem_hpcaccess);
+        mutex_init(&sem_hpcaccess);
         init_MUTEX (&semOperations);
         init_MUTEX_LOCKED (&sem_exit);
-        to_debug = FALSE;
-        ibmphp_shutdown = FALSE;
+        to_debug = 0;
+        ibmphp_shutdown = 0;
         tid_poll = 0;
 
         debug ("%s - Exit\n", __FUNCTION__);
@@ -737,21 +739,21 @@ int ibmphp_hpc_writeslot (struct slot * pslot, u8 cmd)
                 // check controller is still not working on the command
                 //--------------------------------------------------------------------
                 timeout = CMD_COMPLETE_TOUT_SEC;
-                done = FALSE;
+                done = 0;
                 while (!done) {
                         rc = hpc_wait_ctlr_notworking (HPC_CTLR_WORKING_TOUT, ctlr_ptr, wpg_bbar,
                                                         &status);
                         if (!rc) {
                                 if (NEEDTOCHECK_CMDSTATUS (cmd)) {
                                         if (CTLR_FINISHED (status) == HPC_CTLR_FINISHED_YES)
-                                                done = TRUE;
+                                                done = 1;
                                 } else
-                                        done = TRUE;
+                                        done = 1;
                         }
                         if (!done) {
                                 msleep(1000);
                                 if (timeout < 1) {
-                                        done = TRUE;
+                                        done = 1;
                                         err ("%s - Error command complete timeout\n", __FUNCTION__);
                                         rc = -EFAULT;
                                 } else
@@ -778,7 +780,7 @@ int ibmphp_hpc_writeslot (struct slot * pslot, u8 cmd)
 *---------------------------------------------------------------------*/
 static void get_hpc_access (void)
 {
-        down (&sem_hpcaccess);
+        mutex_lock(&sem_hpcaccess);
 }
 
 /*----------------------------------------------------------------------
@@ -786,7 +788,7 @@ static void get_hpc_access (void)
 *---------------------------------------------------------------------*/
 void free_hpc_access (void)
 {
-        up (&sem_hpcaccess);
+        mutex_unlock(&sem_hpcaccess);
 }
 
 /*----------------------------------------------------------------------
@@ -797,7 +799,7 @@ void free_hpc_access (void)
 void ibmphp_lock_operations (void)
 {
         down (&semOperations);
-        to_debug = TRUE;
+        to_debug = 1;
 }
 
 /*----------------------------------------------------------------------
@@ -807,7 +809,7 @@ void ibmphp_unlock_operations (void)
 {
         debug ("%s - Entry\n", __FUNCTION__);
         up (&semOperations);
-        to_debug = FALSE;
+        to_debug = 0;
         debug ("%s - Exit\n", __FUNCTION__);
 }
 
@@ -935,40 +937,40 @@ static int process_changeinstatus (struct slot *pslot, struct slot *poldslot)
 {
         u8 status;
         int rc = 0;
-        u8 disable = FALSE;
-        u8 update = FALSE;
+        u8 disable = 0;
+        u8 update = 0;
 
         debug ("process_changeinstatus - Entry pslot[%p], poldslot[%p]\n", pslot, poldslot);
 
         // bit 0 - HPC_SLOT_POWER
         if ((pslot->status & 0x01) != (poldslot->status & 0x01))
-                update = TRUE;
+                update = 1;
 
         // bit 1 - HPC_SLOT_CONNECT
         // ignore
 
         // bit 2 - HPC_SLOT_ATTN
         if ((pslot->status & 0x04) != (poldslot->status & 0x04))
-                update = TRUE;
+                update = 1;
 
         // bit 3 - HPC_SLOT_PRSNT2
         // bit 4 - HPC_SLOT_PRSNT1
         if (((pslot->status & 0x08) != (poldslot->status & 0x08))
                 || ((pslot->status & 0x10) != (poldslot->status & 0x10)))
-                update = TRUE;
+                update = 1;
 
         // bit 5 - HPC_SLOT_PWRGD
         if ((pslot->status & 0x20) != (poldslot->status & 0x20))
                 // OFF -> ON: ignore, ON -> OFF: disable slot
                 if ((poldslot->status & 0x20) && (SLOT_CONNECT (poldslot->status) == HPC_SLOT_CONNECTED) && (SLOT_PRESENT (poldslot->status))) 
-                        disable = TRUE;
+                        disable = 1;
 
         // bit 6 - HPC_SLOT_BUS_SPEED
         // ignore
 
         // bit 7 - HPC_SLOT_LATCH
         if ((pslot->status & 0x80) != (poldslot->status & 0x80)) {
-                update = TRUE;
+                update = 1;
                 // OPEN -> CLOSE
                 if (pslot->status & 0x80) {
                         if (SLOT_PWRGD (pslot->status)) {
@@ -977,7 +979,7 @@ static int process_changeinstatus (struct slot *pslot, struct slot *poldslot)
                                 msleep(1000);
                                 rc = ibmphp_hpc_readslot (pslot, READ_SLOTSTATUS, &status);
                                 if (SLOT_PWRGD (status))
-                                        update = TRUE;
+                                        update = 1;
                                 else    // overwrite power in pslot to OFF
                                         pslot->status &= ~HPC_SLOT_POWER;
                         }
@@ -985,17 +987,17 @@ static int process_changeinstatus (struct slot *pslot, struct slot *poldslot)
                 // CLOSE -> OPEN 
                 else if ((SLOT_PWRGD (poldslot->status) == HPC_SLOT_PWRGD_GOOD)
                         && (SLOT_CONNECT (poldslot->status) == HPC_SLOT_CONNECTED) && (SLOT_PRESENT (poldslot->status))) {
-                        disable = TRUE;
+                        disable = 1;
                 }
                 // else - ignore
         }
         // bit 4 - HPC_SLOT_BLINK_ATTN
         if ((pslot->ext_status & 0x08) != (poldslot->ext_status & 0x08))
-                update = TRUE;
+                update = 1;
 
         if (disable) {
                 debug ("process_changeinstatus - disable slot\n");
-                pslot->flag = FALSE;
+                pslot->flag = 0;
                 rc = ibmphp_do_disable_slot (pslot);
         }
 
@@ -1100,7 +1102,7 @@ void __exit ibmphp_hpc_stop_poll_thread (void)
 {
         debug ("%s - Entry\n", __FUNCTION__);
 
-        ibmphp_shutdown = TRUE;
+        ibmphp_shutdown = 1;
         debug ("before locking operations \n");
         ibmphp_lock_operations ();
         debug ("after locking operations \n");
@@ -1134,7 +1136,7 @@ static int hpc_wait_ctlr_notworking (int timeout, struct controller *ctlr_ptr, v
                                     u8 * pstatus)
 {
         int rc = 0;
-        u8 done = FALSE;
+        u8 done = 0;
 
         debug_polling ("hpc_wait_ctlr_notworking - Entry timeout[%d]\n", timeout);
 
@@ -1142,14 +1144,14 @@ static int hpc_wait_ctlr_notworking (int timeout, struct controller *ctlr_ptr, v
                 *pstatus = ctrl_read (ctlr_ptr, wpg_bbar, WPG_CTLR_INDEX);
                 if (*pstatus == HPC_ERROR) {
                         rc = HPC_ERROR;
-                        done = TRUE;
+                        done = 1;
                 }
                 if (CTLR_WORKING (*pstatus) == HPC_CTLR_WORKING_NO)
-                        done = TRUE;
+                        done = 1;
                 if (!done) {
                         msleep(1000);
                         if (timeout < 1) {
-                                done = TRUE;
+                                done = 1;
                                 err ("HPCreadslot - Error ctlr timeout\n");
                                 rc = HPC_ERROR;
                         } else
diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c
index 155133fe5c12..d87a9e3eaeeb 100644
--- a/drivers/pci/hotplug/ibmphp_pci.c
+++ b/drivers/pci/hotplug/ibmphp_pci.c
@@ -164,12 +164,11 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno)
                                                 cleanup_count = 6;
                                                 goto error;
                                         }
-                                        newfunc = kmalloc(sizeof(*newfunc), GFP_KERNEL);
+                                        newfunc = kzalloc(sizeof(*newfunc), GFP_KERNEL);
                                         if (!newfunc) {
                                                 err ("out of system memory\n");
                                                 return -ENOMEM;
                                         }
-                                        memset (newfunc, 0, sizeof (struct pci_func));
                                         newfunc->busno = cur_func->busno;
                                         newfunc->device = device;
                                         cur_func->next = newfunc;
@@ -200,15 +199,14 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno)
                                         }
 
                                         pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_SECONDARY_BUS, &sec_number);
-                                        flag = FALSE;
+                                        flag = 0;
                                         for (i = 0; i < 32; i++) {
                                                 if (func->devices[i]) {
-                                                        newfunc = kmalloc(sizeof(*newfunc), GFP_KERNEL);
+                                                        newfunc = kzalloc(sizeof(*newfunc), GFP_KERNEL);
                                                         if (!newfunc) {
                                                                 err ("out of system memory\n");
                                                                 return -ENOMEM;
                                                         }
-                                                        memset (newfunc, 0, sizeof (struct pci_func));
                                                         newfunc->busno = sec_number;
                                                         newfunc->device = (u8) i;
                                                         for (j = 0; j < 4; j++)
@@ -228,16 +226,15 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno)
                                                                 cleanup_count = 2;
                                                                 goto error;
                                                         }
-                                                        flag = TRUE;
+                                                        flag = 1;
                                                 }
                                         }
 
-                                        newfunc = kmalloc(sizeof(*newfunc), GFP_KERNEL);
+                                        newfunc = kzalloc(sizeof(*newfunc), GFP_KERNEL);
                                         if (!newfunc) {
                                                 err ("out of system memory\n");
                                                 return -ENOMEM;
                                         }
-                                        memset (newfunc, 0, sizeof (struct pci_func));
                                         newfunc->busno = cur_func->busno;
                                         newfunc->device = device;
                                         for (j = 0; j < 4; j++)
@@ -275,16 +272,15 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno)
                                                 cur_func->busno, device, function);
                                         pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_SECONDARY_BUS, &sec_number);
                                         debug ("after configuring bridge..., sec_number = %x\n", sec_number);
-                                        flag = FALSE;
+                                        flag = 0;
                                         for (i = 0; i < 32; i++) {
                                                 if (func->devices[i]) {
                                                         debug ("inside for loop, device is %x\n", i);
-                                                        newfunc = kmalloc(sizeof(*newfunc), GFP_KERNEL);
+                                                        newfunc = kzalloc(sizeof(*newfunc), GFP_KERNEL);
                                                         if (!newfunc) {
                                                                 err (" out of system memory\n");
                                                                 return -ENOMEM;
                                                         }
-                                                        memset (newfunc, 0, sizeof (struct pci_func));
                                                         newfunc->busno = sec_number;
                                                         newfunc->device = (u8) i;
                                                         for (j = 0; j < 4; j++)
@@ -305,7 +301,7 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno)
                                                                 cleanup_count = 2;
                                                                 goto error;
                                                         }
-                                                        flag = TRUE;
+                                                        flag = 1;
                                                 }
                                         }
 
@@ -405,13 +401,12 @@ static int configure_device (struct pci_func *func)
 
                         debug ("len[count] in IO %x, count %d\n", len[count], count);
 
-                        io[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                        io[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
 
                         if (!io[count]) {
                                 err ("out of system memory\n");
                                 return -ENOMEM;
                         }
-                        memset (io[count], 0, sizeof (struct resource_node));
                         io[count]->type = IO;
                         io[count]->busno = func->busno;
                         io[count]->devfunc = PCI_DEVFN(func->device, func->function);
@@ -444,29 +439,27 @@ static int configure_device (struct pci_func *func)
 
                                 debug ("len[count] in PFMEM %x, count %d\n", len[count], count);
 
-                                pfmem[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                pfmem[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                 if (!pfmem[count]) {
                                         err ("out of system memory\n");
                                         return -ENOMEM;
                                 }
-                                memset (pfmem[count], 0, sizeof (struct resource_node));
                                 pfmem[count]->type = PFMEM;
                                 pfmem[count]->busno = func->busno;
                                 pfmem[count]->devfunc = PCI_DEVFN(func->device,
                                                         func->function);
                                 pfmem[count]->len = len[count];
-                                pfmem[count]->fromMem = FALSE;
+                                pfmem[count]->fromMem = 0;
                                 if (ibmphp_check_resource (pfmem[count], 0) == 0) {
                                         ibmphp_add_resource (pfmem[count]);
                                         func->pfmem[count] = pfmem[count];
                                 } else {
-                                        mem_tmp = kmalloc(sizeof(*mem_tmp), GFP_KERNEL);
+                                        mem_tmp = kzalloc(sizeof(*mem_tmp), GFP_KERNEL);
                                         if (!mem_tmp) {
                                                 err ("out of system memory\n");
                                                 kfree (pfmem[count]);
                                                 return -ENOMEM;
                                         }
-                                        memset (mem_tmp, 0, sizeof (struct resource_node));
                                         mem_tmp->type = MEM;
                                         mem_tmp->busno = pfmem[count]->busno;
                                         mem_tmp->devfunc = pfmem[count]->devfunc;
@@ -474,7 +467,7 @@ static int configure_device (struct pci_func *func)
                                         debug ("there's no pfmem... going into mem.\n");
                                         if (ibmphp_check_resource (mem_tmp, 0) == 0) {
                                                 ibmphp_add_resource (mem_tmp);
-                                                pfmem[count]->fromMem = TRUE;
+                                                pfmem[count]->fromMem = 1;
                                                 pfmem[count]->rangeno = mem_tmp->rangeno;
                                                 pfmem[count]->start = mem_tmp->start;
                                                 pfmem[count]->end = mem_tmp->end;
@@ -512,12 +505,11 @@ static int configure_device (struct pci_func *func)
 
                                 debug ("len[count] in Mem %x, count %d\n", len[count], count);
 
-                                mem[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                mem[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                 if (!mem[count]) {
                                         err ("out of system memory\n");
                                         return -ENOMEM;
                                 }
-                                memset (mem[count], 0, sizeof (struct resource_node));
                                 mem[count]->type = MEM;
                                 mem[count]->busno = func->busno;
                                 mem[count]->devfunc = PCI_DEVFN(func->device,
@@ -579,11 +571,11 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
         u16 pfmem_base;
         u32 bar[2];
         u32 len[2];
-        u8 flag_io = FALSE;
-        u8 flag_mem = FALSE;
-        u8 flag_pfmem = FALSE;
-        u8 need_io_upper = FALSE;
-        u8 need_pfmem_upper = FALSE;
+        u8 flag_io = 0;
+        u8 flag_mem = 0;
+        u8 flag_pfmem = 0;
+        u8 need_io_upper = 0;
+        u8 need_pfmem_upper = 0;
         struct res_needed *amount_needed = NULL;
         struct resource_node *io = NULL;
         struct resource_node *bus_io[2] = {NULL, NULL};
@@ -677,14 +669,13 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
 
                         debug ("len[count] in IO = %x\n", len[count]);
 
-                        bus_io[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                        bus_io[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                 
                         if (!bus_io[count]) {
                                 err ("out of system memory\n");
                                 retval = -ENOMEM;
                                 goto error;
                         }
-                        memset (bus_io[count], 0, sizeof (struct resource_node));
                         bus_io[count]->type = IO;
                         bus_io[count]->busno = func->busno;
                         bus_io[count]->devfunc = PCI_DEVFN(func->device,
@@ -711,37 +702,35 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
 
                                 debug ("len[count] in PFMEM = %x\n", len[count]);
 
-                                bus_pfmem[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                bus_pfmem[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                 if (!bus_pfmem[count]) {
                                         err ("out of system memory\n");
                                         retval = -ENOMEM;
                                         goto error;
                                 }
-                                memset (bus_pfmem[count], 0, sizeof (struct resource_node));
                                 bus_pfmem[count]->type = PFMEM;
                                 bus_pfmem[count]->busno = func->busno;
                                 bus_pfmem[count]->devfunc = PCI_DEVFN(func->device,
                                                         func->function);
                                 bus_pfmem[count]->len = len[count];
-                                bus_pfmem[count]->fromMem = FALSE;
+                                bus_pfmem[count]->fromMem = 0;
                                 if (ibmphp_check_resource (bus_pfmem[count], 0) == 0) {
                                         ibmphp_add_resource (bus_pfmem[count]);
                                         func->pfmem[count] = bus_pfmem[count];
                                 } else {
-                                        mem_tmp = kmalloc(sizeof(*mem_tmp), GFP_KERNEL);
+                                        mem_tmp = kzalloc(sizeof(*mem_tmp), GFP_KERNEL);
                                         if (!mem_tmp) {
                                                 err ("out of system memory\n");
                                                 retval = -ENOMEM;
                                                 goto error;
                                         }
-                                        memset (mem_tmp, 0, sizeof (struct resource_node));
                                         mem_tmp->type = MEM;
                                         mem_tmp->busno = bus_pfmem[count]->busno;
                                         mem_tmp->devfunc = bus_pfmem[count]->devfunc;
                                         mem_tmp->len = bus_pfmem[count]->len;
                                         if (ibmphp_check_resource (mem_tmp, 0) == 0) {
                                                 ibmphp_add_resource (mem_tmp);
-                                                bus_pfmem[count]->fromMem = TRUE;
+                                                bus_pfmem[count]->fromMem = 1;
                                                 bus_pfmem[count]->rangeno = mem_tmp->rangeno;
                                                 ibmphp_add_pfmem_from_mem (bus_pfmem[count]);
                                                 func->pfmem[count] = bus_pfmem[count];
@@ -770,13 +759,12 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
 
                                 debug ("len[count] in Memory is %x\n", len[count]);
 
-                                bus_mem[count] = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                bus_mem[count] = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                 if (!bus_mem[count]) {
                                         err ("out of system memory\n");
                                         retval = -ENOMEM;
                                         goto error;
                                 }
-                                memset (bus_mem[count], 0, sizeof (struct resource_node));
                                 bus_mem[count]->type = MEM;
                                 bus_mem[count]->busno = func->busno;
                                 bus_mem[count]->devfunc = PCI_DEVFN(func->device,
@@ -838,17 +826,16 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
 
         if (!amount_needed->io) {
                 debug ("it doesn't want IO?\n");
-                flag_io = TRUE;
+                flag_io = 1;
         } else {
                 debug ("it wants %x IO behind the bridge\n", amount_needed->io);
-                io = kmalloc(sizeof(*io), GFP_KERNEL);
+                io = kzalloc(sizeof(*io), GFP_KERNEL);
                 
                 if (!io) {
                         err ("out of system memory\n");
                         retval = -ENOMEM;
                         goto error;
                 }
-                memset (io, 0, sizeof (struct resource_node));
                 io->type = IO;
                 io->busno = func->busno;
                 io->devfunc = PCI_DEVFN(func->device, func->function);
@@ -856,71 +843,68 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
                 if (ibmphp_check_resource (io, 1) == 0) {
                         debug ("were we able to add io\n");
                         ibmphp_add_resource (io);
-                        flag_io = TRUE;
+                        flag_io = 1;
                 }
         }
 
         if (!amount_needed->mem) {
                 debug ("it doesn't want n.e.memory?\n");
-                flag_mem = TRUE;
+                flag_mem = 1;
         } else {
                 debug ("it wants %x memory behind the bridge\n", amount_needed->mem);
-                mem = kmalloc(sizeof(*mem), GFP_KERNEL);
+                mem = kzalloc(sizeof(*mem), GFP_KERNEL);
                 if (!mem) {
                         err ("out of system memory\n");
                         retval = -ENOMEM;
                         goto error;
                 }
-                memset (mem, 0, sizeof (struct resource_node));
                 mem->type = MEM;
                 mem->busno = func->busno;
                 mem->devfunc = PCI_DEVFN(func->device, func->function);
                 mem->len = amount_needed->mem;
                 if (ibmphp_check_resource (mem, 1) == 0) {
                         ibmphp_add_resource (mem);
-                        flag_mem = TRUE;
+                        flag_mem = 1;
                         debug ("were we able to add mem\n");
                 }
         }
 
         if (!amount_needed->pfmem) {
                 debug ("it doesn't want n.e.pfmem mem?\n");
-                flag_pfmem = TRUE;
+                flag_pfmem = 1;
         } else {
                 debug ("it wants %x pfmemory behind the bridge\n", amount_needed->pfmem);
-                pfmem = kmalloc(sizeof(*pfmem), GFP_KERNEL);
+                pfmem = kzalloc(sizeof(*pfmem), GFP_KERNEL);
                 if (!pfmem) {
                         err ("out of system memory\n");
                         retval = -ENOMEM;
                         goto error;
                 }
-                memset (pfmem, 0, sizeof (struct resource_node));
                 pfmem->type = PFMEM;
                 pfmem->busno = func->busno;
                 pfmem->devfunc = PCI_DEVFN(func->device, func->function);
                 pfmem->len = amount_needed->pfmem;
-                pfmem->fromMem = FALSE;
+                pfmem->fromMem = 0;
                 if (ibmphp_check_resource (pfmem, 1) == 0) {
                         ibmphp_add_resource (pfmem);
-                        flag_pfmem = TRUE;
+                        flag_pfmem = 1;
                 } else {
-                        mem_tmp = kmalloc(sizeof(*mem_tmp), GFP_KERNEL);
+                        mem_tmp = kzalloc(sizeof(*mem_tmp), GFP_KERNEL);
                         if (!mem_tmp) {
                                 err ("out of system memory\n");
                                 retval = -ENOMEM;
                                 goto error;
                         }
-                        memset (mem_tmp, 0, sizeof (struct resource_node));
                         mem_tmp->type = MEM;
                         mem_tmp->busno = pfmem->busno;
                         mem_tmp->devfunc = pfmem->devfunc;
                         mem_tmp->len = pfmem->len;
                         if (ibmphp_check_resource (mem_tmp, 1) == 0) {
                                 ibmphp_add_resource (mem_tmp);
-                                pfmem->fromMem = TRUE;
+                                pfmem->fromMem = 1;
                                 pfmem->rangeno = mem_tmp->rangeno;
                                 ibmphp_add_pfmem_from_mem (pfmem);
-                                flag_pfmem = TRUE;
+                                flag_pfmem = 1;
                         }
                 }
         }
@@ -936,13 +920,12 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
                  */
                 bus = ibmphp_find_res_bus (sec_number);
                 if (!bus) {
-                        bus = kmalloc(sizeof(*bus), GFP_KERNEL);
+                        bus = kzalloc(sizeof(*bus), GFP_KERNEL);
                         if (!bus) {
                                 err ("out of system memory\n");
                                 retval = -ENOMEM;
                                 goto error;
                         }
-                        memset (bus, 0, sizeof (struct bus_node));
                         bus->busno = sec_number;
                         debug ("b4 adding new bus\n");
                         rc = add_new_bus (bus, io, mem, pfmem, func->busno);
@@ -967,11 +950,11 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno)
 
                 if ((io_base & PCI_IO_RANGE_TYPE_MASK) == PCI_IO_RANGE_TYPE_32) {
                         debug ("io 32\n");
-                        need_io_upper = TRUE;
+                        need_io_upper = 1;
                 }
                 if ((pfmem_base & PCI_PREF_RANGE_TYPE_MASK) == PCI_PREF_RANGE_TYPE_64) {
                         debug ("pfmem 64\n");
-                        need_pfmem_upper = TRUE;
+                        need_pfmem_upper = 1;
                 }
 
                 if (bus->noIORanges) {
@@ -1111,10 +1094,9 @@ static struct res_needed *scan_behind_bridge (struct pci_func * func, u8 busno)
         };
         struct res_needed *amount;
 
-        amount = kmalloc(sizeof(*amount), GFP_KERNEL);
+        amount = kzalloc(sizeof(*amount), GFP_KERNEL);
         if (amount == NULL)
                 return NULL;
-        memset (amount, 0, sizeof (struct res_needed));
 
         ibmphp_pci_bus->number = busno;
 
@@ -1137,7 +1119,7 @@ static struct res_needed *scan_behind_bridge (struct pci_func * func, u8 busno)
                                 debug ("hdr_type behind the bridge is %x\n", hdr_type);
                                 if (hdr_type & PCI_HEADER_TYPE_BRIDGE) {
                                         err ("embedded bridges not supported for hot-plugging.\n");
-                                        amount->not_correct = TRUE;
+                                        amount->not_correct = 1;
                                         return amount;
                                 }
 
@@ -1145,12 +1127,12 @@ static struct res_needed *scan_behind_bridge (struct pci_func * func, u8 busno)
                                 if (class == PCI_CLASS_NOT_DEFINED_VGA) {
                                         err ("The device %x is VGA compatible and as is not supported for hot plugging. "
                                              "Please choose another device.\n", device);
-                                        amount->not_correct = TRUE;
+                                        amount->not_correct = 1;
                                         return amount;
                                 } else if (class == PCI_CLASS_DISPLAY_VGA) {
                                         err ("The device %x is not supported for hot plugging. "
                                              "Please choose another device.\n", device);
-                                        amount->not_correct = TRUE;
+                                        amount->not_correct = 1;
                                         return amount;
                                 }
 
@@ -1210,9 +1192,9 @@ static struct res_needed *scan_behind_bridge (struct pci_func * func, u8 busno)
         }       /* end for */
 
         if (!howmany)
-                amount->not_correct = TRUE;
+                amount->not_correct = 1;
         else
-                amount->not_correct = FALSE;
+                amount->not_correct = 0;
         if ((amount->io) && (amount->io < IOBRIDGE))
                 amount->io = IOBRIDGE;
         if ((amount->mem) && (amount->mem < MEMBRIDGE))
@@ -1672,12 +1654,11 @@ static int add_new_bus (struct bus_node *bus, struct resource_node *io, struct r
                 list_add (&bus->bus_list, &cur_bus->bus_list);
         }
         if (io) {
-                io_range = kmalloc(sizeof(*io_range), GFP_KERNEL);
+                io_range = kzalloc(sizeof(*io_range), GFP_KERNEL);
                 if (!io_range) {
                         err ("out of system memory\n");
                         return -ENOMEM;
                 }
-                memset (io_range, 0, sizeof (struct range_node));
                 io_range->start = io->start;
                 io_range->end = io->end;
                 io_range->rangeno = 1;
@@ -1685,12 +1666,11 @@ static int add_new_bus (struct bus_node *bus, struct resource_node *io, struct r
                 bus->rangeIO = io_range;
         }
         if (mem) {
-                mem_range = kmalloc(sizeof(*mem_range), GFP_KERNEL);
+                mem_range = kzalloc(sizeof(*mem_range), GFP_KERNEL);
                 if (!mem_range) {
                         err ("out of system memory\n");
                         return -ENOMEM;
                 }
-                memset (mem_range, 0, sizeof (struct range_node));
                 mem_range->start = mem->start;
                 mem_range->end = mem->end;
                 mem_range->rangeno = 1;
@@ -1698,12 +1678,11 @@ static int add_new_bus (struct bus_node *bus, struct resource_node *io, struct r
                 bus->rangeMem = mem_range;
         }
         if (pfmem) {
-                pfmem_range = kmalloc(sizeof(*pfmem_range), GFP_KERNEL);
+                pfmem_range = kzalloc(sizeof(*pfmem_range), GFP_KERNEL);
                 if (!pfmem_range) {     
                         err ("out of system memory\n");
                         return -ENOMEM;
                 }
-                memset (pfmem_range, 0, sizeof (struct range_node));
                 pfmem_range->start = pfmem->start;
                 pfmem_range->end = pfmem->end;
                 pfmem_range->rangeno = 1;
diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c
index 9c224c94d698..5636b1ac2a2e 100644
--- a/drivers/pci/hotplug/ibmphp_res.c
+++ b/drivers/pci/hotplug/ibmphp_res.c
@@ -55,13 +55,12 @@ static struct bus_node * __init alloc_error_bus (struct ebda_pci_rsrc * curr, u8
                 return NULL;
         }
 
-        newbus = kmalloc (sizeof (struct bus_node), GFP_KERNEL);
+        newbus = kzalloc(sizeof(struct bus_node), GFP_KERNEL);
         if (!newbus) {
                 err ("out of system memory\n");
                 return NULL;
         }
 
-        memset (newbus, 0, sizeof (struct bus_node));
         if (flag)
                 newbus->busno = busno;
         else
@@ -79,12 +78,11 @@ static struct resource_node * __init alloc_resources (struct ebda_pci_rsrc * cur
                 return NULL;
         }
 
-        rs = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+        rs = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
         if (!rs) {
                 err ("out of system memory\n");
                 return NULL;
         }
-        memset (rs, 0, sizeof (struct resource_node));
         rs->busno = curr->bus_num;
         rs->devfunc = curr->dev_fun;
         rs->start = curr->start_addr;
@@ -100,12 +98,11 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
         u8 num_ranges = 0;
 
         if (first_bus) {
-                newbus = kmalloc (sizeof (struct bus_node), GFP_KERNEL);
+                newbus = kzalloc(sizeof(struct bus_node), GFP_KERNEL);
                 if (!newbus) {
                         err ("out of system memory.\n");
                         return -ENOMEM;
                 }
-                memset (newbus, 0, sizeof (struct bus_node));
                 newbus->busno = curr->bus_num;
         } else {
                 newbus = *new_bus;
@@ -122,14 +119,13 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
                 }
         }
 
-        newrange = kmalloc (sizeof (struct range_node), GFP_KERNEL);
+        newrange = kzalloc(sizeof(struct range_node), GFP_KERNEL);
         if (!newrange) {
                 if (first_bus)
                         kfree (newbus);
                 err ("out of system memory\n");
                 return -ENOMEM;
         }
-        memset (newrange, 0, sizeof (struct range_node));
         newrange->start = curr->start_addr;
         newrange->end = curr->end_addr;
                 
@@ -329,7 +325,7 @@ int __init ibmphp_rsrc_init (void)
                                 if (!new_pfmem)
                                         return -ENOMEM;
                                 new_pfmem->type = PFMEM;
-                                new_pfmem->fromMem = FALSE;
+                                new_pfmem->fromMem = 0;
                                 if (ibmphp_add_resource (new_pfmem) < 0) {
                                         newbus = alloc_error_bus (curr, 0, 0);
                                         if (!newbus)
@@ -466,7 +462,7 @@ static int add_range (int type, struct range_node *range, struct bus_node *bus_c
 static void update_resources (struct bus_node *bus_cur, int type, int rangeno)
 {
         struct resource_node *res = NULL;
-        u8 eol = FALSE; /* end of list indicator */
+        u8 eol = 0;     /* end of list indicator */
 
         switch (type) {
                 case MEM:
@@ -492,7 +488,7 @@ static void update_resources (struct bus_node *bus_cur, int type, int rangeno)
                         else if (res->nextRange)
                                 res = res->nextRange;
                         else {
-                                eol = TRUE;
+                                eol = 1;
                                 break;
                         }
                 }
@@ -983,7 +979,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
         int noranges = 0;
         u32 tmp_start;          /* this is to make sure start address is divisible by the length needed */
         u32 tmp_divide;
-        u8 flag = FALSE;
+        u8 flag = 0;
 
         if (!res)
                 return -EINVAL;
@@ -1050,17 +1046,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
 
                                         if ((range->start % tmp_divide) == 0) {
                                                 /* just perfect, starting address is divisible by length */
-                                                flag = TRUE;
+                                                flag = 1;
                                                 len_cur = len_tmp;
                                                 start_cur = range->start;
                                         } else {
                                                 /* Needs adjusting */
                                                 tmp_start = range->start;
-                                                flag = FALSE;
+                                                flag = 0;
 
                                                 while ((len_tmp = res_cur->start - 1 - tmp_start) >= res->len) {
                                                         if ((tmp_start % tmp_divide) == 0) {
-                                                                flag = TRUE;
+                                                                flag = 1;
                                                                 len_cur = len_tmp;
                                                                 start_cur = tmp_start;
                                                                 break;
@@ -1089,17 +1085,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
 
                                         if (((res_cur->end + 1) % tmp_divide) == 0) {
                                                 /* just perfect, starting address is divisible by length */
-                                                flag = TRUE;
+                                                flag = 1;
                                                 len_cur = len_tmp;
                                                 start_cur = res_cur->end + 1;
                                         } else {
                                                 /* Needs adjusting */
                                                 tmp_start = res_cur->end + 1;
-                                                flag = FALSE;
+                                                flag = 0;
 
                                                 while ((len_tmp = range->end - tmp_start) >= res->len) {
                                                         if ((tmp_start % tmp_divide) == 0) {
-                                                                flag = TRUE;
+                                                                flag = 1;
                                                                 len_cur = len_tmp;
                                                                 start_cur = tmp_start;
                                                                 break;
@@ -1127,17 +1123,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                         if ((len_tmp < len_cur) || (len_cur == 0)) {
                                                 if ((range->start % tmp_divide) == 0) { 
                                                         /* just perfect, starting address is divisible by length */
-                                                        flag = TRUE;
+                                                        flag = 1;
                                                         len_cur = len_tmp;
                                                         start_cur = range->start;
                                                 } else {
                                                         /* Needs adjusting */
                                                         tmp_start = range->start;
-                                                        flag = FALSE;
+                                                        flag = 0;
 
                                                         while ((len_tmp = res_cur->start - 1 - tmp_start) >= res->len) {
                                                                 if ((tmp_start % tmp_divide) == 0) {
-                                                                        flag = TRUE;
+                                                                        flag = 1;
                                                                         len_cur = len_tmp;
                                                                         start_cur = tmp_start;
                                                                         break;
@@ -1162,17 +1158,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                         if ((len_tmp < len_cur) || (len_cur == 0)) {
                                                 if (((res_prev->end + 1) % tmp_divide) == 0) {
                                                         /* just perfect, starting address's divisible by length */
-                                                        flag = TRUE;
+                                                        flag = 1;
                                                         len_cur = len_tmp;
                                                         start_cur = res_prev->end + 1;
                                                 } else {
                                                         /* Needs adjusting */
                                                         tmp_start = res_prev->end + 1;
-                                                        flag = FALSE;
+                                                        flag = 0;
 
                                                         while ((len_tmp = res_cur->start - 1 - tmp_start) >= res->len) {
                                                                 if ((tmp_start % tmp_divide) == 0) {
-                                                                        flag = TRUE;
+                                                                        flag = 1;
                                                                         len_cur = len_tmp;
                                                                         start_cur = tmp_start;
                                                                         break;
@@ -1221,17 +1217,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                 if ((len_tmp < len_cur) || (len_cur == 0)) {
                                         if ((range->start % tmp_divide) == 0) {
                                                 /* just perfect, starting address's divisible by length */
-                                                flag = TRUE;
+                                                flag = 1;
                                                 len_cur = len_tmp;
                                                 start_cur = range->start;
                                         } else {
                                                 /* Needs adjusting */
                                                 tmp_start = range->start;
-                                                flag = FALSE;
+                                                flag = 0;
 
                                                 while ((len_tmp = range->end - tmp_start) >= res->len) {
                                                         if ((tmp_start % tmp_divide) == 0) {
-                                                                flag = TRUE;
+                                                                flag = 1;
                                                                 len_cur = len_tmp;
                                                                 start_cur = tmp_start;
                                                                 break;
@@ -1285,17 +1281,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                         if ((len_tmp < len_cur) || (len_cur == 0)) {
                                                 if ((range->start % tmp_divide) == 0) {
                                                         /* just perfect, starting address's divisible by length */
-                                                        flag = TRUE;
+                                                        flag = 1;
                                                         len_cur = len_tmp;
                                                         start_cur = range->start;
                                                 } else {
                                                         /* Needs adjusting */
                                                         tmp_start = range->start;
-                                                        flag = FALSE;
+                                                        flag = 0;
 
                                                         while ((len_tmp = range->end - tmp_start) >= res->len) {
                                                                 if ((tmp_start % tmp_divide) == 0) {
-                                                                        flag = TRUE;
+                                                                        flag = 1;
                                                                         len_cur = len_tmp;
                                                                         start_cur = tmp_start;
                                                                         break;
@@ -1688,7 +1684,7 @@ static int __init once_over (void)
                 bus_cur = list_entry (tmp, struct bus_node, bus_list);
                 if ((!bus_cur->rangePFMem) && (bus_cur->firstPFMem)) {
                         for (pfmem_cur = bus_cur->firstPFMem, pfmem_prev = NULL; pfmem_cur; pfmem_prev = pfmem_cur, pfmem_cur = pfmem_cur->next) {
-                                pfmem_cur->fromMem = TRUE;
+                                pfmem_cur->fromMem = 1;
                                 if (pfmem_prev)
                                         pfmem_prev->next = pfmem_cur->next;
                                 else
@@ -1705,12 +1701,11 @@ static int __init once_over (void)
 
                                 bus_cur->firstPFMemFromMem = pfmem_cur;
 
-                                mem = kmalloc (sizeof (struct resource_node), GFP_KERNEL);              
+                                mem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                 if (!mem) {
                                         err ("out of system memory\n");
                                         return -ENOMEM;
                                 }
-                                memset (mem, 0, sizeof (struct resource_node));
                                 mem->type = MEM;
                                 mem->busno = pfmem_cur->busno;
                                 mem->devfunc = pfmem_cur->devfunc;
@@ -1994,12 +1989,11 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                 end_address |= (upper_io_end << 16);
 
                                                 if ((start_address) && (start_address <= end_address)) {
-                                                        range = kmalloc (sizeof (struct range_node), GFP_KERNEL);
+                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                         if (!range) {
                                                                 err ("out of system memory\n");
                                                                 return -ENOMEM;
                                                         }
-                                                        memset (range, 0, sizeof (struct range_node));
                                                         range->start = start_address;
                                                         range->end = end_address + 0xfff;
 
@@ -2020,13 +2014,12 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                         fix_resources (bus_sec);
 
                                                         if (ibmphp_find_resource (bus_cur, start_address, &io, IO)) {
-                                                                io = kmalloc (sizeof (struct resource_node), GFP_KERNEL);                                                       
+                                                                io = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                 if (!io) {
                                                                         kfree (range);
                                                                         err ("out of system memory\n");
                                                                         return -ENOMEM;
                                                                 }
-                                                                memset (io, 0, sizeof (struct resource_node));
                                                                 io->type = IO;
                                                                 io->busno = bus_cur->busno;
                                                                 io->devfunc = ((device << 3) | (function & 0x7));
@@ -2045,12 +2038,11 @@ static int __init update_bridge_ranges (struct bus_node **bus)
 
                                                 if ((start_address) && (start_address <= end_address)) {
 
-                                                        range = kmalloc (sizeof (struct range_node), GFP_KERNEL);
+                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                         if (!range) {
                                                                 err ("out of system memory\n");
                                                                 return -ENOMEM;
                                                         }
-                                                        memset (range, 0, sizeof (struct range_node));
                                                         range->start = start_address;
                                                         range->end = end_address + 0xfffff;
 
@@ -2072,13 +2064,12 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                         fix_resources (bus_sec);
 
                                                         if (ibmphp_find_resource (bus_cur, start_address, &mem, MEM)) {
-                                                                mem = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                                                mem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                 if (!mem) {
                                                                         kfree (range);
                                                                         err ("out of system memory\n");
                                                                         return -ENOMEM;
                                                                 }
-                                                                memset (mem, 0, sizeof (struct resource_node));
                                                                 mem->type = MEM;
                                                                 mem->busno = bus_cur->busno;
                                                                 mem->devfunc = ((device << 3) | (function & 0x7));
@@ -2101,12 +2092,11 @@ static int __init update_bridge_ranges (struct bus_node **bus)
 
                                                 if ((start_address) && (start_address <= end_address)) {
 
-                                                        range = kmalloc (sizeof (struct range_node), GFP_KERNEL);
+                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                         if (!range) {
                                                                 err ("out of system memory\n");
                                                                 return -ENOMEM;
                                                         }
-                                                        memset (range, 0, sizeof (struct range_node));
                                                         range->start = start_address;
                                                         range->end = end_address + 0xfffff;
 
@@ -2127,20 +2117,19 @@ static int __init update_bridge_ranges (struct bus_node **bus)
 
                                                         fix_resources (bus_sec);
                                                         if (ibmphp_find_resource (bus_cur, start_address, &pfmem, PFMEM)) {
-                                                                pfmem = kmalloc (sizeof (struct resource_node), GFP_KERNEL);
+                                                                pfmem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                 if (!pfmem) {
                                                                         kfree (range);
                                                                         err ("out of system memory\n");
                                                                         return -ENOMEM;
                                                                 }
-                                                                memset (pfmem, 0, sizeof (struct resource_node));
                                                                 pfmem->type = PFMEM;
                                                                 pfmem->busno = bus_cur->busno;
                                                                 pfmem->devfunc = ((device << 3) | (function & 0x7));
                                                                 pfmem->start = start_address;
                                                                 pfmem->end = end_address + 0xfffff;
                                                                 pfmem->len = pfmem->end - pfmem->start + 1;
-                                                                pfmem->fromMem = FALSE;
+                                                                pfmem->fromMem = 0;
 
                                                                 ibmphp_add_resource (pfmem);
                                                         }
diff --git a/drivers/pci/hotplug/pci_hotplug.h b/drivers/pci/hotplug/pci_hotplug.h
index 88d44f7fef29..eb0d01d47236 100644
--- a/drivers/pci/hotplug/pci_hotplug.h
+++ b/drivers/pci/hotplug/pci_hotplug.h
@@ -176,5 +176,21 @@ extern int pci_hp_change_slot_info	(struct hotplug_slot *slot,
                                          struct hotplug_slot_info *info);
 extern struct subsystem pci_hotplug_slots_subsys;
 
+struct hotplug_params {
+        u8 cache_line_size;
+        u8 latency_timer;
+        u8 enable_serr;
+        u8 enable_perr;
+};
+
+#ifdef CONFIG_ACPI
+#include <acpi/acpi.h>
+#include <acpi/acpi_bus.h>
+#include <acpi/actypes.h>
+extern acpi_status acpi_run_oshp(acpi_handle handle);
+extern acpi_status acpi_get_hp_params_from_firmware(struct pci_dev *dev,
+                                struct hotplug_params *hpp);
+int acpi_root_bridge(acpi_handle handle);
+#endif
 #endif
 
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 0aac6a61337d..92c1f0f1e1ad 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -34,6 +34,7 @@
 #include <linux/delay.h>
 #include <linux/sched.h>                /* signal_pending() */
 #include <linux/pcieport_if.h>
+#include <linux/mutex.h>
 #include "pci_hotplug.h"
 
 #define MY_NAME "pciehp"
@@ -49,12 +50,6 @@ extern int pciehp_force;
 #define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME , ## arg)
 #define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME , ## arg)
 
-struct hotplug_params {
-        u8 cache_line_size;
-        u8 latency_timer;
-        u8 enable_serr;
-        u8 enable_perr;
-};
 
 struct slot {
         struct slot *next;
@@ -96,7 +91,7 @@ struct php_ctlr_state_s {
 #define MAX_EVENTS              10
 struct controller {
         struct controller *next;
-        struct semaphore crit_sect;     /* critical section semaphore */
+        struct mutex crit_sect;         /* critical section mutex */
         struct php_ctlr_state_s *hpc_ctlr_handle; /* HPC controller handle */
         int num_slots;                  /* Number of slots on ctlr */
         int slot_num_inc;               /* 1 or -1 */
@@ -191,9 +186,6 @@ extern u8	pciehp_handle_power_fault	(u8 hp_slot, void *inst_id);
 /* pci functions */
 extern int      pciehp_configure_device         (struct slot *p_slot);
 extern int      pciehp_unconfigure_device       (struct slot *p_slot);
-extern int      pciehp_get_hp_hw_control_from_firmware(struct pci_dev *dev);
-extern void     pciehp_get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp);
 
 
 
@@ -285,4 +277,19 @@ struct hpc_ops {
         int     (*check_lnk_status)     (struct controller *ctrl);
 };
 
+
+#ifdef CONFIG_ACPI
+#define pciehp_get_hp_hw_control_from_firmware(dev) \
+        pciehp_acpi_get_hp_hw_control_from_firmware(dev)
+static inline int pciehp_get_hp_params_from_firmware(struct pci_dev *dev,
+                        struct hotplug_params *hpp)
+{
+        if (ACPI_FAILURE(acpi_get_hp_params_from_firmware(dev, hpp)))
+                return -ENODEV;
+        return 0;
+}
+#else
+#define pciehp_get_hp_hw_control_from_firmware(dev)     0
+#define pciehp_get_hp_params_from_firmware(dev, hpp)    (-ENODEV)
+#endif                          /* CONFIG_ACPI */
 #endif                          /* _PCIEHP_H */
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
index 4fb569018a24..601cf9045b20 100644
--- a/drivers/pci/hotplug/pciehp_core.c
+++ b/drivers/pci/hotplug/pciehp_core.c
@@ -117,27 +117,23 @@ static int init_slots(struct controller *ctrl)
         slot_number = ctrl->first_slot;
 
         while (number_of_slots) {
-                slot = kmalloc(sizeof(*slot), GFP_KERNEL);
+                slot = kzalloc(sizeof(*slot), GFP_KERNEL);
                 if (!slot)
                         goto error;
 
-                memset(slot, 0, sizeof(struct slot));
                 slot->hotplug_slot =
-                                kmalloc(sizeof(*(slot->hotplug_slot)),
+                                kzalloc(sizeof(*(slot->hotplug_slot)),
                                                 GFP_KERNEL);
                 if (!slot->hotplug_slot)
                         goto error_slot;
                 hotplug_slot = slot->hotplug_slot;
-                memset(hotplug_slot, 0, sizeof(struct hotplug_slot));
 
                 hotplug_slot->info =
-                        kmalloc(sizeof(*(hotplug_slot->info)),
+                        kzalloc(sizeof(*(hotplug_slot->info)),
                                                 GFP_KERNEL);
                 if (!hotplug_slot->info)
                         goto error_hpslot;
                 hotplug_slot_info = hotplug_slot->info;
-                memset(hotplug_slot_info, 0,
-                                        sizeof(struct hotplug_slot_info));
                 hotplug_slot->name = kmalloc(SLOT_NAME_SIZE, GFP_KERNEL);
                 if (!hotplug_slot->name)
                         goto error_info;
@@ -373,12 +369,11 @@ static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_
         u8 value;
         struct pci_dev *pdev;
         
-        ctrl = kmalloc(sizeof(*ctrl), GFP_KERNEL);
+        ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
         if (!ctrl) {
                 err("%s : out of memory\n", __FUNCTION__);
                 goto err_out_none;
         }
-        memset(ctrl, 0, sizeof(struct controller));
 
         pdev = dev->port;
         ctrl->pci_dev = pdev;
@@ -439,7 +434,7 @@ static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_
         }
 
         /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         t_slot->hpc_ops->get_adapter_status(t_slot, &value); /* Check if slot is occupied */
         
@@ -447,7 +442,7 @@ static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_
                 rc = t_slot->hpc_ops->power_off_slot(t_slot); /* Power off slot if not occupied*/
                 if (rc) {
                         /* Done with exclusive hardware access */
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         goto err_out_free_ctrl_slot;
                 } else
                         /* Wait for the command to complete */
@@ -455,7 +450,7 @@ static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_
         }
 
         /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         return 0;
 
diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
index 83c4b865718a..33d198768356 100644
--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -229,13 +229,13 @@ u8 pciehp_handle_power_fault(u8 hp_slot, void *inst_id)
 static void set_slot_off(struct controller *ctrl, struct slot * pslot)
 {
         /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         /* turn off slot, turn on Amber LED, turn off Green LED if supported*/
         if (POWER_CTRL(ctrl->ctrlcap)) {
                 if (pslot->hpc_ops->power_off_slot(pslot)) {   
                         err("%s: Issue of Slot Power Off command failed\n", __FUNCTION__);
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         return;
                 }
                 wait_for_ctrl_irq (ctrl);
@@ -249,14 +249,14 @@ static void set_slot_off(struct controller *ctrl, struct slot * pslot)
         if (ATTN_LED(ctrl->ctrlcap)) { 
                 if (pslot->hpc_ops->set_attention_status(pslot, 1)) {   
                         err("%s: Issue of Set Attention Led command failed\n", __FUNCTION__);
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         return;
                 }
                 wait_for_ctrl_irq (ctrl);
         }
 
         /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 }
 
 /**
@@ -279,13 +279,13 @@ static int board_added(struct slot *p_slot)
                         ctrl->slot_device_offset, hp_slot);
 
         /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         if (POWER_CTRL(ctrl->ctrlcap)) {
                 /* Power on slot */
                 rc = p_slot->hpc_ops->power_on_slot(p_slot);
                 if (rc) {
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         return -1;
                 }
 
@@ -301,7 +301,7 @@ static int board_added(struct slot *p_slot)
         }
 
         /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         /* Wait for ~1 second */
         wait_for_ctrl_irq (ctrl);
@@ -335,7 +335,7 @@ static int board_added(struct slot *p_slot)
                 pci_fixup_device(pci_fixup_final, ctrl->pci_dev);
         if (PWR_LED(ctrl->ctrlcap)) {
                 /* Wait for exclusive access to hardware */
-                down(&ctrl->crit_sect);
+                mutex_lock(&ctrl->crit_sect);
 
                 p_slot->hpc_ops->green_led_on(p_slot);
   
@@ -343,7 +343,7 @@ static int board_added(struct slot *p_slot)
                 wait_for_ctrl_irq (ctrl);
         
                 /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
+                mutex_unlock(&ctrl->crit_sect);
         }
         return 0;
 
@@ -375,14 +375,14 @@ static int remove_board(struct slot *p_slot)
         dbg("In %s, hp_slot = %d\n", __FUNCTION__, hp_slot);
 
         /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
+        mutex_lock(&ctrl->crit_sect);
 
         if (POWER_CTRL(ctrl->ctrlcap)) {
                 /* power off slot */
                 rc = p_slot->hpc_ops->power_off_slot(p_slot);
                 if (rc) {
                         err("%s: Issue of Slot Disable command failed\n", __FUNCTION__);
-                        up(&ctrl->crit_sect);
+                        mutex_unlock(&ctrl->crit_sect);
                         return rc;
                 }
                 /* Wait for the command to complete */
@@ -398,7 +398,7 @@ static int remove_board(struct slot *p_slot)
         }
 
         /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
+        mutex_unlock(&ctrl->crit_sect);
 
         return 0;
 }
@@ -445,7 +445,7 @@ static void pciehp_pushbutton_thread(unsigned long slot)
 
                 if (pciehp_enable_slot(p_slot) && PWR_LED(p_slot->ctrl->ctrlcap)) {
                         /* Wait for exclusive access to hardware */
-                        down(&p_slot->ctrl->crit_sect);
+                        mutex_lock(&p_slot->ctrl->crit_sect);
 
                         p_slot->hpc_ops->green_led_off(p_slot);
 
@@ -453,7 +453,7 @@ static void pciehp_pushbutton_thread(unsigned long slot)
                         wait_for_ctrl_irq (p_slot->ctrl);
 
                         /* Done with exclusive hardware access */
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                 }
                 p_slot->state = STATIC_STATE;
         }
@@ -495,7 +495,7 @@ static void pciehp_surprise_rm_thread(unsigned long slot)
 
                 if (pciehp_enable_slot(p_slot) && PWR_LED(p_slot->ctrl->ctrlcap)) {
                         /* Wait for exclusive access to hardware */
-                        down(&p_slot->ctrl->crit_sect);
+                        mutex_lock(&p_slot->ctrl->crit_sect);
 
                         p_slot->hpc_ops->green_led_off(p_slot);
 
@@ -503,7 +503,7 @@ static void pciehp_surprise_rm_thread(unsigned long slot)
                         wait_for_ctrl_irq (p_slot->ctrl);
 
                         /* Done with exclusive hardware access */
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                 }
                 p_slot->state = STATIC_STATE;
         }
@@ -616,7 +616,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                         switch (p_slot->state) {
                                         case BLINKINGOFF_STATE:
                                                 /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
+                                                mutex_lock(&ctrl->crit_sect);
                                                 
                                                 if (PWR_LED(ctrl->ctrlcap)) {
                                                         p_slot->hpc_ops->green_led_on(p_slot);
@@ -630,11 +630,11 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                         wait_for_ctrl_irq (ctrl);
                                                 }
                                                 /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
+                                                mutex_unlock(&ctrl->crit_sect);
                                                 break;
                                         case BLINKINGON_STATE:
                                                 /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
+                                                mutex_lock(&ctrl->crit_sect);
 
                                                 if (PWR_LED(ctrl->ctrlcap)) {
                                                         p_slot->hpc_ops->green_led_off(p_slot);
@@ -647,7 +647,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                         wait_for_ctrl_irq (ctrl);
                                                 }
                                                 /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
+                                                mutex_unlock(&ctrl->crit_sect);
 
                                                 break;
                                         default:
@@ -676,7 +676,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                 }
 
                                                 /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
+                                                mutex_lock(&ctrl->crit_sect);
 
                                                 /* blink green LED and turn off amber */
                                                 if (PWR_LED(ctrl->ctrlcap)) {
@@ -693,7 +693,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                 }
 
                                                 /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
+                                                mutex_unlock(&ctrl->crit_sect);
 
                                                 init_timer(&p_slot->task_event);
                                                 p_slot->task_event.expires = jiffies + 5 * HZ;   /* 5 second delay */
@@ -708,7 +708,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                         if (POWER_CTRL(ctrl->ctrlcap)) {
                                                 dbg("power fault\n");
                                                 /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
+                                                mutex_lock(&ctrl->crit_sect);
 
                                                 if (ATTN_LED(ctrl->ctrlcap)) {
                                                         p_slot->hpc_ops->set_attention_status(p_slot, 1);
@@ -721,7 +721,7 @@ static void interrupt_event_handler(struct controller *ctrl)
                                                 }
 
                                                 /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
+                                                mutex_unlock(&ctrl->crit_sect);
                                         }
                                 }
                                 /***********SURPRISE REMOVAL********************/
@@ -756,19 +756,19 @@ int pciehp_enable_slot(struct slot *p_slot)
         int rc;
 
         /* Check to see if (latch closed, card present, power off) */
-        down(&p_slot->ctrl->crit_sect);
+        mutex_lock(&p_slot->ctrl->crit_sect);
 
         rc = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
         if (rc || !getstatus) {
                 info("%s: no adapter on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
+                mutex_unlock(&p_slot->ctrl->crit_sect);
                 return 1;
         }
         if (MRL_SENS(p_slot->ctrl->ctrlcap)) {  
                 rc = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
                 if (rc || getstatus) {
                         info("%s: latch open on slot(%x)\n", __FUNCTION__, p_slot->number);
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                         return 1;
                 }
         }
@@ -777,11 +777,11 @@ int pciehp_enable_slot(struct slot *p_slot)
                 rc = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
                 if (rc || getstatus) {
                         info("%s: already enabled on slot(%x)\n", __FUNCTION__, p_slot->number);
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                         return 1;
                 }
         }
-        up(&p_slot->ctrl->crit_sect);
+        mutex_unlock(&p_slot->ctrl->crit_sect);
 
         p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
 
@@ -806,13 +806,13 @@ int pciehp_disable_slot(struct slot *p_slot)
                 return 1;
 
         /* Check to see if (latch closed, card present, power on) */
-        down(&p_slot->ctrl->crit_sect);
+        mutex_lock(&p_slot->ctrl->crit_sect);
 
         if (!HP_SUPR_RM(p_slot->ctrl->ctrlcap)) {       
                 ret = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
                 if (ret || !getstatus) {
                         info("%s: no adapter on slot(%x)\n", __FUNCTION__, p_slot->number);
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                         return 1;
                 }
         }
@@ -821,7 +821,7 @@ int pciehp_disable_slot(struct slot *p_slot)
                 ret = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
                 if (ret || getstatus) {
                         info("%s: latch open on slot(%x)\n", __FUNCTION__, p_slot->number);
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                         return 1;
                 }
         }
@@ -830,12 +830,12 @@ int pciehp_disable_slot(struct slot *p_slot)
                 ret = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
                 if (ret || !getstatus) {
                         info("%s: already disabled slot(%x)\n", __FUNCTION__, p_slot->number);
-                        up(&p_slot->ctrl->crit_sect);
+                        mutex_unlock(&p_slot->ctrl->crit_sect);
                         return 1;
                 }
         }
 
-        up(&p_slot->ctrl->crit_sect);
+        mutex_unlock(&p_slot->ctrl->crit_sect);
 
         ret = remove_board(p_slot);
         update_slot_info(p_slot);
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 77e530321de2..6c14d9e46b2e 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -38,7 +38,10 @@
 
 #include "../pci.h"
 #include "pciehp.h"
-
+#include <acpi/acpi.h>
+#include <acpi/acpi_bus.h>
+#include <acpi/actypes.h>
+#include <linux/pci-acpi.h>
 #ifdef DEBUG
 #define DBG_K_TRACE_ENTRY      ((unsigned int)0x00000001)       /* On function entry */
 #define DBG_K_TRACE_EXIT       ((unsigned int)0x00000002)       /* On function exit */
@@ -1236,6 +1239,76 @@ static struct hpc_ops pciehp_hpc_ops = {
         .check_lnk_status               = hpc_check_lnk_status,
 };
 
+#ifdef CONFIG_ACPI
+int pciehp_acpi_get_hp_hw_control_from_firmware(struct pci_dev *dev)
+{
+        acpi_status status;
+        acpi_handle chandle, handle = DEVICE_ACPI_HANDLE(&(dev->dev));
+        struct pci_dev *pdev = dev;
+        struct pci_bus *parent;
+        struct acpi_buffer string = { ACPI_ALLOCATE_BUFFER, NULL };
+
+        /*
+         * Per PCI firmware specification, we should run the ACPI _OSC
+         * method to get control of hotplug hardware before using it.
+         * If an _OSC is missing, we look for an OSHP to do the same thing.
+         * To handle different BIOS behavior, we look for _OSC and OSHP
+         * within the scope of the hotplug controller and its parents, upto
+         * the host bridge under which this controller exists.
+         */
+        while (!handle) {
+                /*
+                 * This hotplug controller was not listed in the ACPI name
+                 * space at all. Try to get acpi handle of parent pci bus.
+                 */
+                if (!pdev || !pdev->bus->parent)
+                        break;
+                parent = pdev->bus->parent;
+                dbg("Could not find %s in acpi namespace, trying parent\n",
+                                pci_name(pdev));
+                if (!parent->self)
+                        /* Parent must be a host bridge */
+                        handle = acpi_get_pci_rootbridge_handle(
+                                        pci_domain_nr(parent),
+                                        parent->number);
+                else
+                        handle = DEVICE_ACPI_HANDLE(
+                                        &(parent->self->dev));
+                pdev = parent->self;
+        }
+
+        while (handle) {
+                acpi_get_name(handle, ACPI_FULL_PATHNAME, &string);
+                dbg("Trying to get hotplug control for %s \n",
+                        (char *)string.pointer);
+                status = pci_osc_control_set(handle,
+                                OSC_PCI_EXPRESS_NATIVE_HP_CONTROL);
+                if (status == AE_NOT_FOUND)
+                        status = acpi_run_oshp(handle);
+                if (ACPI_SUCCESS(status)) {
+                        dbg("Gained control for hotplug HW for pci %s (%s)\n",
+                                pci_name(dev), (char *)string.pointer);
+                        acpi_os_free(string.pointer);
+                        return 0;
+                }
+                if (acpi_root_bridge(handle))
+                        break;
+                chandle = handle;
+                status = acpi_get_parent(chandle, &handle);
+                if (ACPI_FAILURE(status))
+                        break;
+        }
+
+        err("Cannot get control of hotplug hardware for pci %s\n",
+                        pci_name(dev));
+
+        acpi_os_free(string.pointer);
+        return -1;
+}
+#endif
+
+
+
 int pcie_init(struct controller * ctrl, struct pcie_device *dev)
 {
         struct php_ctlr_state_s *php_ctlr, *p;
@@ -1334,7 +1407,7 @@ int pcie_init(struct controller * ctrl, struct pcie_device *dev)
         if (pci_enable_device(pdev))
                 goto abort_free_ctlr;
         
-        init_MUTEX(&ctrl->crit_sect);
+        mutex_init(&ctrl->crit_sect);
         /* setup wait queue */
         init_waitqueue_head(&ctrl->queue);
 
diff --git a/drivers/pci/hotplug/pciehprm_acpi.c b/drivers/pci/hotplug/pciehprm_acpi.c
deleted file mode 100644
index 2bdb30f68bf8..000000000000
--- a/drivers/pci/hotplug/pciehprm_acpi.c
+++ /dev/null
@@ -1,257 +0,0 @@
-/*
- * PCIEHPRM ACPI: PHP Resource Manager for ACPI platform
- *
- * Copyright (C) 2003-2004 Intel Corporation
- *
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT.  See the GNU General Public License for more
- * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Send feedback to <kristen.c.accardi@intel.com>
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/types.h>
-#include <linux/pci.h>
-#include <linux/acpi.h>
-#include <linux/pci-acpi.h>
-#include <acpi/acpi_bus.h>
-#include <acpi/actypes.h>
-#include "pciehp.h"
-
-#define METHOD_NAME__SUN        "_SUN"
-#define METHOD_NAME__HPP        "_HPP"
-#define METHOD_NAME_OSHP        "OSHP"
-
-static u8 * acpi_path_name( acpi_handle handle)
-{
-        acpi_status             status;
-        static u8               path_name[ACPI_PATHNAME_MAX];
-        struct acpi_buffer      ret_buf = { ACPI_PATHNAME_MAX, path_name };
-
-        memset(path_name, 0, sizeof (path_name));
-        status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &ret_buf);
-
-        if (ACPI_FAILURE(status))
-                return NULL;
-        else
-                return path_name;       
-}
-
-static acpi_status
-acpi_run_hpp(acpi_handle handle, struct hotplug_params *hpp)
-{
-        acpi_status             status;
-        u8                      nui[4];
-        struct acpi_buffer      ret_buf = { 0, NULL};
-        union acpi_object       *ext_obj, *package;
-        u8                      *path_name = acpi_path_name(handle);
-        int                     i, len = 0;
-
-        /* get _hpp */
-        status = acpi_evaluate_object(handle, METHOD_NAME__HPP, NULL, &ret_buf);
-        switch (status) {
-        case AE_BUFFER_OVERFLOW:
-                ret_buf.pointer = kmalloc (ret_buf.length, GFP_KERNEL);
-                if (!ret_buf.pointer) {
-                        err ("%s:%s alloc for _HPP fail\n", __FUNCTION__,
-                                        path_name);
-                        return AE_NO_MEMORY;
-                }
-                status = acpi_evaluate_object(handle, METHOD_NAME__HPP,
-                                NULL, &ret_buf);
-                if (ACPI_SUCCESS(status))
-                        break;
-        default:
-                if (ACPI_FAILURE(status)) {
-                        dbg("%s:%s _HPP fail=0x%x\n", __FUNCTION__,
-                                        path_name, status);
-                        return status;
-                }
-        }
-
-        ext_obj = (union acpi_object *) ret_buf.pointer;
-        if (ext_obj->type != ACPI_TYPE_PACKAGE) {
-                err ("%s:%s _HPP obj not a package\n", __FUNCTION__,
-                                path_name);
-                status = AE_ERROR;
-                goto free_and_return;
-        }
-
-        len = ext_obj->package.count;
-        package = (union acpi_object *) ret_buf.pointer;
-        for ( i = 0; (i < len) || (i < 4); i++) {
-                ext_obj = (union acpi_object *) &package->package.elements[i];
-                switch (ext_obj->type) {
-                case ACPI_TYPE_INTEGER:
-                        nui[i] = (u8)ext_obj->integer.value;
-                        break;
-                default:
-                        err ("%s:%s _HPP obj type incorrect\n", __FUNCTION__,
-                                        path_name);
-                        status = AE_ERROR;
-                        goto free_and_return;
-                }
-        }
-
-        hpp->cache_line_size = nui[0];
-        hpp->latency_timer = nui[1];
-        hpp->enable_serr = nui[2];
-        hpp->enable_perr = nui[3];
-
-        dbg("  _HPP: cache_line_size=0x%x\n", hpp->cache_line_size);
-        dbg("  _HPP: latency timer  =0x%x\n", hpp->latency_timer);
-        dbg("  _HPP: enable SERR    =0x%x\n", hpp->enable_serr);
-        dbg("  _HPP: enable PERR    =0x%x\n", hpp->enable_perr);
-
-free_and_return:
-        kfree(ret_buf.pointer);
-        return status;
-}
-
-static acpi_status acpi_run_oshp(acpi_handle handle)
-{
-        acpi_status             status;
-        u8                      *path_name = acpi_path_name(handle);
-
-        /* run OSHP */
-        status = acpi_evaluate_object(handle, METHOD_NAME_OSHP, NULL, NULL);
-        if (ACPI_FAILURE(status)) {
-                dbg("%s:%s OSHP fails=0x%x\n", __FUNCTION__, path_name,
-                                status);
-        } else {
-                dbg("%s:%s OSHP passes\n", __FUNCTION__, path_name);
-        }
-        return status;
-}
-
-static int is_root_bridge(acpi_handle handle)
-{
-        acpi_status status;
-        struct acpi_device_info *info;
-        struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
-        int i;
-
-        status = acpi_get_object_info(handle, &buffer);
-        if (ACPI_SUCCESS(status)) {
-                info = buffer.pointer;
-                if ((info->valid & ACPI_VALID_HID) &&
-                        !strcmp(PCI_ROOT_HID_STRING,
-                                        info->hardware_id.value)) {
-                        acpi_os_free(buffer.pointer);
-                        return 1;
-                }
-                if (info->valid & ACPI_VALID_CID) {
-                        for (i=0; i < info->compatibility_id.count; i++) {
-                                if (!strcmp(PCI_ROOT_HID_STRING,
-                                        info->compatibility_id.id[i].value)) {
-                                        acpi_os_free(buffer.pointer);
-                                        return 1;
-                                }
-                        }
-                }
-        }
-        return 0;
-}
-
-int pciehp_get_hp_hw_control_from_firmware(struct pci_dev *dev)
-{
-        acpi_status status;
-        acpi_handle chandle, handle = DEVICE_ACPI_HANDLE(&(dev->dev));
-        struct pci_dev *pdev = dev;
-        struct pci_bus *parent;
-        u8 *path_name;
-
-        /*
-         * Per PCI firmware specification, we should run the ACPI _OSC
-         * method to get control of hotplug hardware before using it.
-         * If an _OSC is missing, we look for an OSHP to do the same thing.
-         * To handle different BIOS behavior, we look for _OSC and OSHP
-         * within the scope of the hotplug controller and its parents, upto
-         * the host bridge under which this controller exists.
-         */
-        while (!handle) {
-                /*
-                 * This hotplug controller was not listed in the ACPI name
-                 * space at all. Try to get acpi handle of parent pci bus.
-                 */
-                if (!pdev || !pdev->bus->parent)
-                        break;
-                parent = pdev->bus->parent;
-                dbg("Could not find %s in acpi namespace, trying parent\n",
-                                pci_name(pdev));
-                if (!parent->self)
-                        /* Parent must be a host bridge */
-                        handle = acpi_get_pci_rootbridge_handle(
-                                        pci_domain_nr(parent),
-                                        parent->number);
-                else
-                        handle = DEVICE_ACPI_HANDLE(
-                                        &(parent->self->dev));
-                pdev = parent->self;
-        }
-
-        while (handle) {
-                path_name = acpi_path_name(handle);
-                dbg("Trying to get hotplug control for %s \n", path_name);
-                status = pci_osc_control_set(handle,
-                                OSC_PCI_EXPRESS_NATIVE_HP_CONTROL);
-                if (status == AE_NOT_FOUND)
-                        status = acpi_run_oshp(handle);
-                if (ACPI_SUCCESS(status)) {
-                        dbg("Gained control for hotplug HW for pci %s (%s)\n",
-                                pci_name(dev), path_name);
-                        return 0;
-                }
-                if (is_root_bridge(handle))
-                        break;
-                chandle = handle;
-                status = acpi_get_parent(chandle, &handle);
-                if (ACPI_FAILURE(status))
-                        break;
-        }
-
-        err("Cannot get control of hotplug hardware for pci %s\n",
-                        pci_name(dev));
-        return -1;
-}
-
-void pciehp_get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp)
-{
-        acpi_status status = AE_NOT_FOUND;
-        struct pci_dev *pdev = dev;
-
-        /*
-         * _HPP settings apply to all child buses, until another _HPP is
-         * encountered. If we don't find an _HPP for the input pci dev,
-         * look for it in the parent device scope since that would apply to
-         * this pci dev. If we don't find any _HPP, use hardcoded defaults
-         */
-        while (pdev && (ACPI_FAILURE(status))) {
-                acpi_handle handle = DEVICE_ACPI_HANDLE(&(pdev->dev));
-                if (!handle)
-                        break;
-                status = acpi_run_hpp(handle, hpp);
-                if (!(pdev->bus->parent))
-                        break;
-                /* Check if a parent object supports _HPP */
-                pdev = pdev->bus->parent->self;
-        }
-}
-
diff --git a/drivers/pci/hotplug/pciehprm_nonacpi.c b/drivers/pci/hotplug/pciehprm_nonacpi.c
deleted file mode 100644
index 29180dfe8493..000000000000
--- a/drivers/pci/hotplug/pciehprm_nonacpi.c
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * PCIEHPRM NONACPI: PHP Resource Manager for Non-ACPI/Legacy platform
- *
- * Copyright (C) 1995,2001 Compaq Computer Corporation
- * Copyright (C) 2001 Greg Kroah-Hartman (greg@kroah.com)
- * Copyright (C) 2001 IBM Corp.
- * Copyright (C) 2003-2004 Intel Corporation
- *
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT.  See the GNU General Public License for more
- * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Send feedback to <greg@kroah.com>, <kristen.c.accardi@intel.com>
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/types.h>
-#include <linux/sched.h>
-#include <linux/pci.h>
-#include <linux/slab.h>
-#include "pciehp.h"
-
-void pciehp_get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp)
-{
-        return;
-}
-
-int pciehp_get_hp_hw_control_from_firmware(struct pci_dev *dev)
-{
-        return 0;
-}
diff --git a/drivers/pci/hotplug/pcihp_skeleton.c b/drivers/pci/hotplug/pcihp_skeleton.c
index 3194d51c6ec9..0a46f549676a 100644
--- a/drivers/pci/hotplug/pcihp_skeleton.c
+++ b/drivers/pci/hotplug/pcihp_skeleton.c
@@ -37,10 +37,12 @@
 #include <linux/init.h>
 #include "pci_hotplug.h"
 
+#define SLOT_NAME_SIZE  10
 struct slot {
         u8 number;
         struct hotplug_slot *hotplug_slot;
         struct list_head slot_list;
+        char name[SLOT_NAME_SIZE];
 };
 
 static LIST_HEAD(slot_list);
@@ -233,12 +235,10 @@ static void release_slot(struct hotplug_slot *hotplug_slot)
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
         kfree(slot->hotplug_slot->info);
-        kfree(slot->hotplug_slot->name);
         kfree(slot->hotplug_slot);
         kfree(slot);
 }
 
-#define SLOT_NAME_SIZE  10
 static void make_slot_name(struct slot *slot)
 {
         /*
@@ -257,7 +257,6 @@ static int __init init_slots(void)
         struct slot *slot;
         struct hotplug_slot *hotplug_slot;
         struct hotplug_slot_info *info;
-        char *name;
         int retval = -ENOMEM;
         int i;
 
@@ -266,31 +265,23 @@ static int __init init_slots(void)
          * with the pci_hotplug subsystem.
          */
         for (i = 0; i < num_slots; ++i) {
-                slot = kmalloc(sizeof(struct slot), GFP_KERNEL);
+                slot = kzalloc(sizeof(*slot), GFP_KERNEL);
                 if (!slot)
                         goto error;
-                memset(slot, 0, sizeof(struct slot));
 
-                hotplug_slot = kmalloc(sizeof(struct hotplug_slot),
-                                        GFP_KERNEL);
+                hotplug_slot = kzalloc(sizeof(*hotplug_slot), GFP_KERNEL);
                 if (!hotplug_slot)
                         goto error_slot;
-                memset(hotplug_slot, 0, sizeof (struct hotplug_slot));
                 slot->hotplug_slot = hotplug_slot;
 
-                info = kmalloc(sizeof(struct hotplug_slot_info), GFP_KERNEL);
+                info = kzalloc(sizeof(*info), GFP_KERNEL);
                 if (!info)
                         goto error_hpslot;
-                memset(info, 0, sizeof (struct hotplug_slot_info));
                 hotplug_slot->info = info;
 
-                name = kmalloc(SLOT_NAME_SIZE, GFP_KERNEL);
-                if (!name)
-                        goto error_info;
-                hotplug_slot->name = name;
-
                 slot->number = i;
 
+                hotplug_slot->name = slot->name;
                 hotplug_slot->private = slot;
                 hotplug_slot->release = &release_slot;
                 make_slot_name(slot);
@@ -300,16 +291,16 @@ static int __init init_slots(void)
                  * Initialize the slot info structure with some known
                  * good values.
                  */
-                info->power_status = get_power_status(slot);
-                info->attention_status = get_attention_status(slot);
-                info->latch_status = get_latch_status(slot);
-                info->adapter_status = get_adapter_status(slot);
+                get_power_status(hotplug_slot, &info->power_status);
+                get_attention_status(hotplug_slot, &info->attention_status);
+                get_latch_status(hotplug_slot, &info->latch_status);
+                get_adapter_status(hotplug_slot, &info->adapter_status);
                 
                 dbg("registering slot %d\n", i);
                 retval = pci_hp_register(slot->hotplug_slot);
                 if (retval) {
                         err("pci_hp_register failed with error %d\n", retval);
-                        goto error_name;
+                        goto error_info;
                 }
 
                 /* add slot to our internal list */
@@ -317,8 +308,6 @@ static int __init init_slots(void)
         }
 
         return 0;
-error_name:
-        kfree(name);
 error_info:
         kfree(info);
 error_hpslot:
diff --git a/drivers/pci/hotplug/rpaphp_slot.c b/drivers/pci/hotplug/rpaphp_slot.c
index 78943e064b59..b771196a654e 100644
--- a/drivers/pci/hotplug/rpaphp_slot.c
+++ b/drivers/pci/hotplug/rpaphp_slot.c
@@ -84,19 +84,16 @@ struct slot *alloc_slot_struct(struct device_node *dn, int drc_index, char *drc_
 {
         struct slot *slot;
         
-        slot = kmalloc(sizeof (struct slot), GFP_KERNEL);
+        slot = kzalloc(sizeof(struct slot), GFP_KERNEL);
         if (!slot)
                 goto error_nomem;
-        memset(slot, 0, sizeof (struct slot));
-        slot->hotplug_slot = kmalloc(sizeof (struct hotplug_slot), GFP_KERNEL);
+        slot->hotplug_slot = kzalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
         if (!slot->hotplug_slot)
                 goto error_slot;        
-        memset(slot->hotplug_slot, 0, sizeof (struct hotplug_slot));
-        slot->hotplug_slot->info = kmalloc(sizeof (struct hotplug_slot_info),
+        slot->hotplug_slot->info = kzalloc(sizeof(struct hotplug_slot_info),
                                            GFP_KERNEL);
         if (!slot->hotplug_slot->info)
                 goto error_hpslot;
-        memset(slot->hotplug_slot->info, 0, sizeof (struct hotplug_slot_info));
         slot->hotplug_slot->name = kmalloc(BUS_ID_SIZE + 1, GFP_KERNEL);
         if (!slot->hotplug_slot->name)
                 goto error_info;        
diff --git a/drivers/pci/hotplug/sgi_hotplug.c b/drivers/pci/hotplug/sgi_hotplug.c
index a32ae82e5922..c402da8e78ae 100644
--- a/drivers/pci/hotplug/sgi_hotplug.c
+++ b/drivers/pci/hotplug/sgi_hotplug.c
@@ -3,7 +3,7 @@
  * License.  See the file "COPYING" in the main directory of this archive
  * for more details.
  *
- * Copyright (C) 2005 Silicon Graphics, Inc. All rights reserved.
+ * Copyright (C) 2005-2006 Silicon Graphics, Inc. All rights reserved.
  *
  * This work was based on the 2.4/2.6 kernel development by Dick Reigner.
  * Work to add BIOS PROM support was completed by Mike Habeck.
@@ -230,6 +230,13 @@ static void sn_bus_free_data(struct pci_dev *dev)
                 list_for_each_entry(child, &subordinate_bus->devices, bus_list)
                         sn_bus_free_data(child);
         }
+        /*
+         * Some drivers may use dma accesses during the
+         * driver remove function. We release the sysdata
+         * areas after the driver remove functions have
+         * been called.
+         */
+        sn_bus_store_sysdata(dev);
         sn_pci_unfixup_slot(dev);
 }
 
@@ -429,13 +436,6 @@ static int disable_slot(struct hotplug_slot *bss_hotplug_slot)
                                    PCI_DEVFN(slot->device_num + 1,
                                              PCI_FUNC(func)));
                 if (dev) {
-                        /*
-                         * Some drivers may use dma accesses during the
-                         * driver remove function. We release the sysdata
-                         * areas after the driver remove functions have
-                         * been called.
-                         */
-                        sn_bus_store_sysdata(dev);
                         sn_bus_free_data(dev);
                         pci_remove_bus_device(dev);
                         pci_dev_put(dev);
diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h
index 7d6f521d02ea..5c70f43908c4 100644
--- a/drivers/pci/hotplug/shpchp.h
+++ b/drivers/pci/hotplug/shpchp.h
@@ -33,6 +33,7 @@
 #include <linux/pci.h>
 #include <linux/delay.h>
 #include <linux/sched.h>        /* signal_pending(), struct timer_list */
+#include <linux/mutex.h>
 
 #include "pci_hotplug.h"
 
@@ -45,6 +46,7 @@
 extern int shpchp_poll_mode;
 extern int shpchp_poll_time;
 extern int shpchp_debug;
+extern struct workqueue_struct *shpchp_wq;
 
 /*#define dbg(format, arg...) do { if (shpchp_debug) printk(KERN_DEBUG "%s: " format, MY_NAME , ## arg); } while (0)*/
 #define dbg(format, arg...) do { if (shpchp_debug) printk("%s: " format, MY_NAME , ## arg); } while (0)
@@ -52,10 +54,8 @@ extern int shpchp_debug;
 #define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME , ## arg)
 #define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME , ## arg)
 
-#define SLOT_MAGIC      0x67267321
+#define SLOT_NAME_SIZE 10
 struct slot {
-        u32 magic;
-        struct slot *next;
         u8 bus;
         u8 device;
         u16 status;
@@ -70,26 +70,27 @@ struct slot {
         struct hpc_ops *hpc_ops;
         struct hotplug_slot *hotplug_slot;
         struct list_head        slot_list;
+        char name[SLOT_NAME_SIZE];
+        struct work_struct work;        /* work for button event */
+        struct mutex lock;
 };
 
 struct event_info {
         u32 event_type;
-        u8 hp_slot;
+        struct slot *p_slot;
+        struct work_struct work;
 };
 
 struct controller {
-        struct controller *next;
-        struct semaphore crit_sect;     /* critical section semaphore */
+        struct mutex crit_sect;         /* critical section mutex */
+        struct mutex cmd_lock;          /* command lock */
         struct php_ctlr_state_s *hpc_ctlr_handle; /* HPC controller handle */
         int num_slots;                  /* Number of slots on ctlr */
         int slot_num_inc;               /* 1 or -1 */
         struct pci_dev *pci_dev;
-        struct pci_bus *pci_bus;
-        struct event_info event_queue[10];
-        struct slot *slot;
+        struct list_head slot_list;
         struct hpc_ops *hpc_ops;
         wait_queue_head_t queue;        /* sleep & wake process */
-        u8 next_event;
         u8 bus;
         u8 device;
         u8 function;
@@ -105,12 +106,6 @@ struct controller {
         volatile int cmd_busy;
 };
 
-struct hotplug_params {
-        u8      cache_line_size;
-        u8      latency_timer;
-        u8      enable_serr;
-        u8      enable_perr;
-};
 
 /* Define AMD SHPC ID  */
 #define PCI_DEVICE_ID_AMD_GOLAM_7450    0x7450 
@@ -180,11 +175,8 @@ struct hotplug_params {
 /* sysfs functions for the hotplug controller info */
 extern void shpchp_create_ctrl_files    (struct controller *ctrl);
 
-/* controller functions */
-extern int      shpchp_event_start_thread(void);
-extern void     shpchp_event_stop_thread(void);
-extern int      shpchp_enable_slot(struct slot *slot);
-extern int      shpchp_disable_slot(struct slot *slot);
+extern int      shpchp_sysfs_enable_slot(struct slot *slot);
+extern int      shpchp_sysfs_disable_slot(struct slot *slot);
 
 extern u8       shpchp_handle_attention_button(u8 hp_slot, void *inst_id);
 extern u8       shpchp_handle_switch_change(u8 hp_slot, void *inst_id);
@@ -195,16 +187,28 @@ extern u8	shpchp_handle_power_fault(u8 hp_slot, void *inst_id);
 extern int      shpchp_save_config(struct controller *ctrl, int busnumber, int num_ctlr_slots, int first_device_num);
 extern int      shpchp_configure_device(struct slot *p_slot);
 extern int      shpchp_unconfigure_device(struct slot *p_slot);
-extern void     get_hp_hw_control_from_firmware(struct pci_dev *dev);
-extern void     get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp);
-extern int      shpchprm_get_physical_slot_number(struct controller *ctrl,
-                u32 *sun, u8 busnum, u8 devnum);
 extern void     shpchp_remove_ctrl_files(struct controller *ctrl);
+extern void     cleanup_slots(struct controller *ctrl);
+extern void     queue_pushbutton_work(void *data);
 
 
-/* Global variables */
-extern struct controller *shpchp_ctrl_list;
+#ifdef CONFIG_ACPI
+static inline int get_hp_params_from_firmware(struct pci_dev *dev,
+                        struct hotplug_params *hpp)
+{
+        if (ACPI_FAILURE(acpi_get_hp_params_from_firmware(dev, hpp)))
+                        return -ENODEV;
+        return 0;
+}
+#define get_hp_hw_control_from_firmware(pdev) \
+        do { \
+                if (DEVICE_ACPI_HANDLE(&(pdev->dev))) \
+                        acpi_run_oshp(DEVICE_ACPI_HANDLE(&(pdev->dev))); \
+        } while (0)
+#else
+#define get_hp_params_from_firmware(dev, hpp) (-ENODEV)
+#define get_hp_hw_control_from_firmware(dev) do { } while (0)
+#endif
 
 struct ctrl_reg {
         volatile u32 base_offset;
@@ -286,10 +290,6 @@ static inline int slot_paranoia_check (struct slot *slot, const char *function)
                 dbg("%s - slot == NULL", function);
                 return -1;
         }
-        if (slot->magic != SLOT_MAGIC) {
-                dbg("%s - bad magic number for slot", function);
-                return -1;
-        }
         if (!slot->hotplug_slot) {
                 dbg("%s - slot->hotplug_slot == NULL!", function);
                 return -1;
@@ -314,44 +314,19 @@ static inline struct slot *get_slot (struct hotplug_slot *hotplug_slot, const ch
 
 static inline struct slot *shpchp_find_slot (struct controller *ctrl, u8 device)
 {
-        struct slot *p_slot, *tmp_slot = NULL;
+        struct slot *slot;
 
         if (!ctrl)
                 return NULL;
 
-        p_slot = ctrl->slot;
-
-        while (p_slot && (p_slot->device != device)) {
-                tmp_slot = p_slot;
-                p_slot = p_slot->next;
+        list_for_each_entry(slot, &ctrl->slot_list, slot_list) {
+                if (slot->device == device)
+                        return slot;
         }
-        if (p_slot == NULL) {
-                err("ERROR: shpchp_find_slot device=0x%x\n", device);
-                p_slot = tmp_slot;
-        }
-
-        return (p_slot);
-}
-
-static inline int wait_for_ctrl_irq (struct controller *ctrl)
-{
-    DECLARE_WAITQUEUE(wait, current);
-        int retval = 0;
-
-        add_wait_queue(&ctrl->queue, &wait);
 
-        if (!shpchp_poll_mode) {
-                /* Sleep for up to 1 second */
-                msleep_interruptible(1000);
-        } else {
-                /* Sleep for up to 2 seconds */
-                msleep_interruptible(2000);
-        }
-        remove_wait_queue(&ctrl->queue, &wait);
-        if (signal_pending(current))
-                retval =  -EINTR;
+        err("%s: slot (device=0x%x) not found\n", __FUNCTION__, device);
 
-        return retval;
+        return NULL;
 }
 
 static inline void amd_pogo_errata_save_misc_reg(struct slot *p_slot)
@@ -427,13 +402,6 @@ static inline void amd_pogo_errata_restore_misc_reg(struct slot *p_slot)
         pci_write_config_dword(p_slot->ctrl->pci_dev, PCIX_MISCII_OFFSET, pcix_misc2_temp);
 }
 
-#define SLOT_NAME_SIZE 10
-
-static inline void make_slot_name(char *buffer, int buffer_size, struct slot *slot)
-{
-        snprintf(buffer, buffer_size, "%04d_%04d", slot->bus, slot->number);
-}
-
 enum php_ctlr_type {
         PCI,
         ISA,
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c
index a2b3f0010cec..3be4d492ccc2 100644
--- a/drivers/pci/hotplug/shpchp_core.c
+++ b/drivers/pci/hotplug/shpchp_core.c
@@ -32,13 +32,14 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/pci.h>
+#include <linux/workqueue.h>
 #include "shpchp.h"
 
 /* Global variables */
 int shpchp_debug;
 int shpchp_poll_mode;
 int shpchp_poll_time;
-struct controller *shpchp_ctrl_list;    /* = NULL */
+struct workqueue_struct *shpchp_wq;
 
 #define DRIVER_VERSION  "0.4"
 #define DRIVER_AUTHOR   "Dan Zink <dan.zink@compaq.com>, Greg Kroah-Hartman <greg@kroah.com>, Dely Sy <dely.l.sy@intel.com>"
@@ -57,7 +58,6 @@ MODULE_PARM_DESC(shpchp_poll_time, "Polling mechanism frequency, in seconds");
 
 #define SHPC_MODULE_NAME "shpchp"
 
-static int shpc_start_thread (void);
 static int set_attention_status (struct hotplug_slot *slot, u8 value);
 static int enable_slot          (struct hotplug_slot *slot);
 static int disable_slot         (struct hotplug_slot *slot);
@@ -94,107 +94,120 @@ static void release_slot(struct hotplug_slot *hotplug_slot)
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
         kfree(slot->hotplug_slot->info);
-        kfree(slot->hotplug_slot->name);
         kfree(slot->hotplug_slot);
         kfree(slot);
 }
 
+static void make_slot_name(struct slot *slot)
+{
+        snprintf(slot->hotplug_slot->name, SLOT_NAME_SIZE, "%04d_%04d",
+                 slot->bus, slot->number);
+}
+
+
+
+
+static int
+shpchprm_get_physical_slot_number(struct controller *ctrl, u32 *sun,
+                                u8 busnum, u8 devnum)
+{
+        int offset = devnum - ctrl->slot_device_offset;
+
+        dbg("%s: ctrl->slot_num_inc %d, offset %d\n", __FUNCTION__,
+                        ctrl->slot_num_inc, offset);
+        *sun = (u8) (ctrl->first_slot + ctrl->slot_num_inc *offset);
+        return 0;
+}
+
+
+
 static int init_slots(struct controller *ctrl)
 {
-        struct slot *new_slot;
-        u8 number_of_slots;
-        u8 slot_device;
-        u32 slot_number, sun;
-        int result = -ENOMEM;
-
-        number_of_slots = ctrl->num_slots;
-        slot_device = ctrl->slot_device_offset;
-        slot_number = ctrl->first_slot;
-
-        while (number_of_slots) {
-                new_slot = (struct slot *) kmalloc(sizeof(struct slot), GFP_KERNEL);
-                if (!new_slot)
+        struct slot *slot;
+        struct hotplug_slot *hotplug_slot;
+        struct hotplug_slot_info *info;
+        int retval = -ENOMEM;
+        int i;
+        u32 sun;
+
+        for (i = 0; i < ctrl->num_slots; i++) {
+                slot = kzalloc(sizeof(*slot), GFP_KERNEL);
+                if (!slot)
                         goto error;
 
-                memset(new_slot, 0, sizeof(struct slot));
-                new_slot->hotplug_slot = kmalloc (sizeof (struct hotplug_slot), GFP_KERNEL);
-                if (!new_slot->hotplug_slot)
+                hotplug_slot = kzalloc(sizeof(*hotplug_slot), GFP_KERNEL);
+                if (!hotplug_slot)
                         goto error_slot;
-                memset(new_slot->hotplug_slot, 0, sizeof (struct hotplug_slot));
+                slot->hotplug_slot = hotplug_slot;
 
-                new_slot->hotplug_slot->info = kmalloc (sizeof (struct hotplug_slot_info), GFP_KERNEL);
-                if (!new_slot->hotplug_slot->info)
+                info = kzalloc(sizeof(*info), GFP_KERNEL);
+                if (!info)
                         goto error_hpslot;
-                memset(new_slot->hotplug_slot->info, 0, sizeof (struct hotplug_slot_info));
-                new_slot->hotplug_slot->name = kmalloc (SLOT_NAME_SIZE, GFP_KERNEL);
-                if (!new_slot->hotplug_slot->name)
-                        goto error_info;
+                hotplug_slot->info = info;
+
+                hotplug_slot->name = slot->name;
 
-                new_slot->magic = SLOT_MAGIC;
-                new_slot->ctrl = ctrl;
-                new_slot->bus = ctrl->slot_bus;
-                new_slot->device = slot_device;
-                new_slot->hpc_ops = ctrl->hpc_ops;
+                slot->hp_slot = i;
+                slot->ctrl = ctrl;
+                slot->bus = ctrl->slot_bus;
+                slot->device = ctrl->slot_device_offset + i;
+                slot->hpc_ops = ctrl->hpc_ops;
+                mutex_init(&slot->lock);
 
                 if (shpchprm_get_physical_slot_number(ctrl, &sun,
-                                        new_slot->bus, new_slot->device))
-                        goto error_name;
+                                                      slot->bus, slot->device))
+                        goto error_info;
 
-                new_slot->number = sun;
-                new_slot->hp_slot = slot_device - ctrl->slot_device_offset;
+                slot->number = sun;
+                INIT_WORK(&slot->work, queue_pushbutton_work, slot);
 
                 /* register this slot with the hotplug pci core */
-                new_slot->hotplug_slot->private = new_slot;
-                new_slot->hotplug_slot->release = &release_slot;
-                make_slot_name(new_slot->hotplug_slot->name, SLOT_NAME_SIZE, new_slot);
-                new_slot->hotplug_slot->ops = &shpchp_hotplug_slot_ops;
-
-                new_slot->hpc_ops->get_power_status(new_slot, &(new_slot->hotplug_slot->info->power_status));
-                new_slot->hpc_ops->get_attention_status(new_slot, &(new_slot->hotplug_slot->info->attention_status));
-                new_slot->hpc_ops->get_latch_status(new_slot, &(new_slot->hotplug_slot->info->latch_status));
-                new_slot->hpc_ops->get_adapter_status(new_slot, &(new_slot->hotplug_slot->info->adapter_status));
-
-                dbg("Registering bus=%x dev=%x hp_slot=%x sun=%x slot_device_offset=%x\n", new_slot->bus, 
-                        new_slot->device, new_slot->hp_slot, new_slot->number, ctrl->slot_device_offset);
-                result = pci_hp_register (new_slot->hotplug_slot);
-                if (result) {
-                        err ("pci_hp_register failed with error %d\n", result);
-                        goto error_name;
+                hotplug_slot->private = slot;
+                hotplug_slot->release = &release_slot;
+                make_slot_name(slot);
+                hotplug_slot->ops = &shpchp_hotplug_slot_ops;
+
+                get_power_status(hotplug_slot, &info->power_status);
+                get_attention_status(hotplug_slot, &info->attention_status);
+                get_latch_status(hotplug_slot, &info->latch_status);
+                get_adapter_status(hotplug_slot, &info->adapter_status);
+
+                dbg("Registering bus=%x dev=%x hp_slot=%x sun=%x "
+                    "slot_device_offset=%x\n", slot->bus, slot->device,
+                    slot->hp_slot, slot->number, ctrl->slot_device_offset);
+                retval = pci_hp_register(slot->hotplug_slot);
+                if (retval) {
+                        err("pci_hp_register failed with error %d\n", retval);
+                        goto error_info;
                 }
 
-                new_slot->next = ctrl->slot;
-                ctrl->slot = new_slot;
-
-                number_of_slots--;
-                slot_device++;
-                slot_number += ctrl->slot_num_inc;
+                list_add(&slot->slot_list, &ctrl->slot_list);
         }
 
         return 0;
-
-error_name:
-        kfree(new_slot->hotplug_slot->name);
 error_info:
-        kfree(new_slot->hotplug_slot->info);
+        kfree(info);
 error_hpslot:
-        kfree(new_slot->hotplug_slot);
+        kfree(hotplug_slot);
 error_slot:
-        kfree(new_slot);
+        kfree(slot);
 error:
-        return result;
+        return retval;
 }
 
-static void cleanup_slots(struct controller *ctrl)
+void cleanup_slots(struct controller *ctrl)
 {
-        struct slot *old_slot, *next_slot;
-
-        old_slot = ctrl->slot;
-        ctrl->slot = NULL;
-
-        while (old_slot) {
-                next_slot = old_slot->next;
-                pci_hp_deregister(old_slot->hotplug_slot);
-                old_slot = next_slot;
+        struct list_head *tmp;
+        struct list_head *next;
+        struct slot *slot;
+
+        list_for_each_safe(tmp, next, &ctrl->slot_list) {
+                slot = list_entry(tmp, struct slot, slot_list);
+                list_del(&slot->slot_list);
+                cancel_delayed_work(&slot->work);
+                flush_scheduled_work();
+                flush_workqueue(shpchp_wq);
+                pci_hp_deregister(slot->hotplug_slot);
         }
 }
 
@@ -207,9 +220,12 @@ static int get_ctlr_slot_config(struct controller *ctrl)
         int rc;
         int flags;
 
-        rc = shpc_get_ctlr_slot_config(ctrl, &num_ctlr_slots, &first_device_num, &physical_slot_num, &updown, &flags);
+        rc = shpc_get_ctlr_slot_config(ctrl, &num_ctlr_slots,
+                                       &first_device_num, &physical_slot_num,
+                                       &updown, &flags);
         if (rc) {
-                err("%s: get_ctlr_slot_config fail for b:d (%x:%x)\n", __FUNCTION__, ctrl->bus, ctrl->device);
+                err("%s: get_ctlr_slot_config fail for b:d (%x:%x)\n",
+                    __FUNCTION__, ctrl->bus, ctrl->device);
                 return -1;
         }
 
@@ -218,19 +234,19 @@ static int get_ctlr_slot_config(struct controller *ctrl)
         ctrl->first_slot = physical_slot_num;
         ctrl->slot_num_inc = updown;            /* either -1 or 1 */
 
-        dbg("%s: num_slot(0x%x) 1st_dev(0x%x) psn(0x%x) updown(%d) for b:d (%x:%x)\n",
-                __FUNCTION__, num_ctlr_slots, first_device_num, physical_slot_num, updown, ctrl->bus, ctrl->device);
+        dbg("%s: num_slot(0x%x) 1st_dev(0x%x) psn(0x%x) updown(%d) for b:d "
+            "(%x:%x)\n", __FUNCTION__, num_ctlr_slots, first_device_num,
+            physical_slot_num, updown, ctrl->bus, ctrl->device);
 
         return 0;
 }
 
-
 /*
  * set_attention_status - Turns the Amber LED for a slot on, off or blink
  */
 static int set_attention_status (struct hotplug_slot *hotplug_slot, u8 status)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
@@ -240,29 +256,27 @@ static int set_attention_status (struct hotplug_slot *hotplug_slot, u8 status)
         return 0;
 }
 
-
 static int enable_slot (struct hotplug_slot *hotplug_slot)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
-        return shpchp_enable_slot(slot);
+        return shpchp_sysfs_enable_slot(slot);
 }
 
-
 static int disable_slot (struct hotplug_slot *hotplug_slot)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
-        return shpchp_disable_slot(slot);
+        return shpchp_sysfs_disable_slot(slot);
 }
 
 static int get_power_status (struct hotplug_slot *hotplug_slot, u8 *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
@@ -276,7 +290,7 @@ static int get_power_status (struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_attention_status (struct hotplug_slot *hotplug_slot, u8 *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
@@ -290,7 +304,7 @@ static int get_attention_status (struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_latch_status (struct hotplug_slot *hotplug_slot, u8 *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
@@ -304,7 +318,7 @@ static int get_latch_status (struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_adapter_status (struct hotplug_slot *hotplug_slot, u8 *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
@@ -318,7 +332,7 @@ static int get_adapter_status (struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_address (struct hotplug_slot *hotplug_slot, u32 *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         struct pci_bus *bus = slot->ctrl->pci_dev->subordinate;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
@@ -330,11 +344,11 @@ static int get_address (struct hotplug_slot *hotplug_slot, u32 *value)
 
 static int get_max_bus_speed (struct hotplug_slot *hotplug_slot, enum pci_bus_speed *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
-        
+
         retval = slot->hpc_ops->get_max_bus_speed(slot, value);
         if (retval < 0)
                 *value = PCI_SPEED_UNKNOWN;
@@ -344,11 +358,11 @@ static int get_max_bus_speed (struct hotplug_slot *hotplug_slot, enum pci_bus_sp
 
 static int get_cur_bus_speed (struct hotplug_slot *hotplug_slot, enum pci_bus_speed *value)
 {
-        struct slot *slot = get_slot (hotplug_slot, __FUNCTION__);
+        struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
         int retval;
 
         dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
-        
+
         retval = slot->hpc_ops->get_cur_bus_speed(slot, value);
         if (retval < 0)
                 *value = PCI_SPEED_UNKNOWN;
@@ -372,61 +386,54 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         int rc;
         struct controller *ctrl;
         struct slot *t_slot;
-        int first_device_num;   /* first PCI device number supported by this SHPC */
-        int num_ctlr_slots;     /* number of slots supported by this SHPC */
+        int first_device_num;   /* first PCI device number */
+        int num_ctlr_slots;     /* number of slots implemented */
 
         if (!is_shpc_capable(pdev))
                 return -ENODEV;
 
-        ctrl = (struct controller *) kmalloc(sizeof(struct controller), GFP_KERNEL);
+        ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
         if (!ctrl) {
                 err("%s : out of memory\n", __FUNCTION__);
                 goto err_out_none;
         }
-        memset(ctrl, 0, sizeof(struct controller));
+        INIT_LIST_HEAD(&ctrl->slot_list);
 
         rc = shpc_init(ctrl, pdev);
         if (rc) {
-                dbg("%s: controller initialization failed\n", SHPC_MODULE_NAME);
+                dbg("%s: controller initialization failed\n",
+                    SHPC_MODULE_NAME);
                 goto err_out_free_ctrl;
         }
 
         pci_set_drvdata(pdev, ctrl);
 
-        ctrl->pci_bus = kmalloc (sizeof (*ctrl->pci_bus), GFP_KERNEL);
-        if (!ctrl->pci_bus) {
-                err("out of memory\n");
-                rc = -ENOMEM;
-                goto err_out_unmap_mmio_region;
-        }
-        
-        memcpy (ctrl->pci_bus, pdev->bus, sizeof (*ctrl->pci_bus));
         ctrl->bus = pdev->bus->number;
         ctrl->slot_bus = pdev->subordinate->number;
-
         ctrl->device = PCI_SLOT(pdev->devfn);
         ctrl->function = PCI_FUNC(pdev->devfn);
-        dbg("ctrl bus=0x%x, device=%x, function=%x, irq=%x\n", ctrl->bus, ctrl->device, ctrl->function, pdev->irq);
+
+        dbg("ctrl bus=0x%x, device=%x, function=%x, irq=%x\n",
+            ctrl->bus, ctrl->device, ctrl->function, pdev->irq);
 
         /*
-         *      Save configuration headers for this and subordinate PCI buses
+         * Save configuration headers for this and subordinate PCI buses
          */
-
         rc = get_ctlr_slot_config(ctrl);
         if (rc) {
                 err(msg_initialization_err, rc);
-                goto err_out_free_ctrl_bus;
+                goto err_out_release_ctlr;
         }
         first_device_num = ctrl->slot_device_offset;
         num_ctlr_slots = ctrl->num_slots;
 
         ctrl->add_support = 1;
-        
+
         /* Setup the slot information structures */
         rc = init_slots(ctrl);
         if (rc) {
                 err(msg_initialization_err, 6);
-                goto err_out_free_ctrl_slot;
+                goto err_out_release_ctlr;
         }
 
         /* Now hpc_functions (slot->hpc_ops->functions) are ready  */
@@ -437,30 +444,16 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         dbg("%s: t_slot->hp_slot %x\n", __FUNCTION__,t_slot->hp_slot);
 
         if (rc || ctrl->speed == PCI_SPEED_UNKNOWN) {
-                err(SHPC_MODULE_NAME ": Can't get current bus speed. Set to 33MHz PCI.\n");
+                err(SHPC_MODULE_NAME ": Can't get current bus speed. "
+                    "Set to 33MHz PCI.\n");
                 ctrl->speed = PCI_SPEED_33MHz;
         }
 
-        /* Finish setting up the hot plug ctrl device */
-        ctrl->next_event = 0;
-
-        if (!shpchp_ctrl_list) {
-                shpchp_ctrl_list = ctrl;
-                ctrl->next = NULL;
-        } else {
-                ctrl->next = shpchp_ctrl_list;
-                shpchp_ctrl_list = ctrl;
-        }
-
         shpchp_create_ctrl_files(ctrl);
 
         return 0;
 
-err_out_free_ctrl_slot:
-        cleanup_slots(ctrl);
-err_out_free_ctrl_bus:
-        kfree(ctrl->pci_bus);
-err_out_unmap_mmio_region:
+err_out_release_ctlr:
         ctrl->hpc_ops->release_ctlr(ctrl);
 err_out_free_ctrl:
         kfree(ctrl);
@@ -468,74 +461,28 @@ err_out_none:
         return -ENODEV;
 }
 
-
-static int shpc_start_thread(void)
-{
-        int retval = 0;
-        
-        dbg("Initialize + Start the notification/polling mechanism \n");
-
-        retval = shpchp_event_start_thread();
-        if (retval) {
-                dbg("shpchp_event_start_thread() failed\n");
-                return retval;
-        }
-
-        return retval;
-}
-
-static void __exit unload_shpchpd(void)
+static void shpc_remove(struct pci_dev *dev)
 {
-        struct controller *ctrl;
-        struct controller *tctrl;
-
-        ctrl = shpchp_ctrl_list;
-
-        while (ctrl) {
-                shpchp_remove_ctrl_files(ctrl);
-                cleanup_slots(ctrl);
-
-                kfree (ctrl->pci_bus);
-                ctrl->hpc_ops->release_ctlr(ctrl);
-
-                tctrl = ctrl;
-                ctrl = ctrl->next;
-
-                kfree(tctrl);
-        }
-
-        /* Stop the notification mechanism */
-        shpchp_event_stop_thread();
+        struct controller *ctrl = pci_get_drvdata(dev);
 
+        shpchp_remove_ctrl_files(ctrl);
+        ctrl->hpc_ops->release_ctlr(ctrl);
+        kfree(ctrl);
 }
 
-
 static struct pci_device_id shpcd_pci_tbl[] = {
-        {
-        .class =        ((PCI_CLASS_BRIDGE_PCI << 8) | 0x00),
-        .class_mask =   ~0,
-        .vendor =       PCI_ANY_ID,
-        .device =       PCI_ANY_ID,
-        .subvendor =    PCI_ANY_ID,
-        .subdevice =    PCI_ANY_ID,
-        },
-        
+        {PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0)},
         { /* end: all zeroes */ }
 };
-
 MODULE_DEVICE_TABLE(pci, shpcd_pci_tbl);
 
-
-
 static struct pci_driver shpc_driver = {
         .name =         SHPC_MODULE_NAME,
         .id_table =     shpcd_pci_tbl,
         .probe =        shpc_probe,
-        /* remove:      shpc_remove_one, */
+        .remove =       shpc_remove,
 };
 
-
-
 static int __init shpcd_init(void)
 {
         int retval = 0;
@@ -544,17 +491,15 @@ static int __init shpcd_init(void)
         shpchp_poll_mode = 1;
 #endif
 
-        retval = shpc_start_thread();
-        if (retval)
-                goto error_hpc_init;
+        shpchp_wq = create_singlethread_workqueue("shpchpd");
+        if (!shpchp_wq)
+                return -ENOMEM;
 
         retval = pci_register_driver(&shpc_driver);
         dbg("%s: pci_register_driver = %d\n", __FUNCTION__, retval);
         info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
-
-error_hpc_init:
         if (retval) {
-                shpchp_event_stop_thread();
+                destroy_workqueue(shpchp_wq);
         }
         return retval;
 }
@@ -562,10 +507,8 @@ error_hpc_init:
 static void __exit shpcd_cleanup(void)
 {
         dbg("unload_shpchpd()\n");
-        unload_shpchpd();
-
         pci_unregister_driver(&shpc_driver);
-
+        destroy_workqueue(shpchp_wq);
         info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
 }
 
diff --git a/drivers/pci/hotplug/shpchp_ctrl.c b/drivers/pci/hotplug/shpchp_ctrl.c
index 643252d9bf3b..4e6381481c55 100644
--- a/drivers/pci/hotplug/shpchp_ctrl.c
+++ b/drivers/pci/hotplug/shpchp_ctrl.c
@@ -32,65 +32,50 @@
 #include <linux/types.h>
 #include <linux/smp_lock.h>
 #include <linux/pci.h>
+#include <linux/workqueue.h>
 #include "../pci.h"
 #include "shpchp.h"
 
-static void interrupt_event_handler(struct controller *ctrl);
+static void interrupt_event_handler(void *data);
+static int shpchp_enable_slot(struct slot *p_slot);
+static int shpchp_disable_slot(struct slot *p_slot);
 
-static struct semaphore event_semaphore;        /* mutex for process loop (up if something to process) */
-static struct semaphore event_exit;             /* guard ensure thread has exited before calling it quits */
-static int event_finished;
-static unsigned long pushbutton_pending;        /* = 0 */
+static int queue_interrupt_event(struct slot *p_slot, u32 event_type)
+{
+        struct event_info *info;
+
+        info = kmalloc(sizeof(*info), GFP_ATOMIC);
+        if (!info)
+                return -ENOMEM;
+
+        info->event_type = event_type;
+        info->p_slot = p_slot;
+        INIT_WORK(&info->work, interrupt_event_handler, info);
+
+        schedule_work(&info->work);
+
+        return 0;
+}
 
 u8 shpchp_handle_attention_button(u8 hp_slot, void *inst_id)
 {
         struct controller *ctrl = (struct controller *) inst_id;
         struct slot *p_slot;
-        u8 rc = 0;
-        u8 getstatus;
-        struct event_info *taskInfo;
+        u32 event_type;
 
         /* Attention Button Change */
         dbg("shpchp:  Attention button interrupt received.\n");
         
-        /* This is the structure that tells the worker thread what to do */
-        taskInfo = &(ctrl->event_queue[ctrl->next_event]);
         p_slot = shpchp_find_slot(ctrl, hp_slot + ctrl->slot_device_offset);
-
         p_slot->hpc_ops->get_adapter_status(p_slot, &(p_slot->presence_save));
-        p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
-        
-        ctrl->next_event = (ctrl->next_event + 1) % 10;
-        taskInfo->hp_slot = hp_slot;
-
-        rc++;
 
         /*
          *  Button pressed - See if need to TAKE ACTION!!!
          */
         info("Button pressed on Slot(%d)\n", ctrl->first_slot + hp_slot);
-        taskInfo->event_type = INT_BUTTON_PRESS;
-
-        if ((p_slot->state == BLINKINGON_STATE)
-            || (p_slot->state == BLINKINGOFF_STATE)) {
-                /* Cancel if we are still blinking; this means that we press the
-                 * attention again before the 5 sec. limit expires to cancel hot-add
-                 * or hot-remove
-                 */
-                taskInfo->event_type = INT_BUTTON_CANCEL;
-                info("Button cancel on Slot(%d)\n", ctrl->first_slot + hp_slot);
-        } else if ((p_slot->state == POWERON_STATE)
-                   || (p_slot->state == POWEROFF_STATE)) {
-                /* Ignore if the slot is on power-on or power-off state; this 
-                 * means that the previous attention button action to hot-add or
-                 * hot-remove is undergoing
-                 */
-                taskInfo->event_type = INT_BUTTON_IGNORE;
-                info("Button ignore on Slot(%d)\n", ctrl->first_slot + hp_slot);
-        }
+        event_type = INT_BUTTON_PRESS;
 
-        if (rc)
-                up(&event_semaphore);   /* signal event thread that new event is posted */
+        queue_interrupt_event(p_slot, event_type);
 
         return 0;
 
@@ -100,21 +85,12 @@ u8 shpchp_handle_switch_change(u8 hp_slot, void *inst_id)
 {
         struct controller *ctrl = (struct controller *) inst_id;
         struct slot *p_slot;
-        u8 rc = 0;
         u8 getstatus;
-        struct event_info *taskInfo;
+        u32 event_type;
 
         /* Switch Change */
         dbg("shpchp:  Switch interrupt received.\n");
 
-        /* This is the structure that tells the worker thread
-         * what to do
-         */
-        taskInfo = &(ctrl->event_queue[ctrl->next_event]);
-        ctrl->next_event = (ctrl->next_event + 1) % 10;
-        taskInfo->hp_slot = hp_slot;
-
-        rc++;
         p_slot = shpchp_find_slot(ctrl, hp_slot + ctrl->slot_device_offset);
         p_slot->hpc_ops->get_adapter_status(p_slot, &(p_slot->presence_save));
         p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
@@ -126,9 +102,9 @@ u8 shpchp_handle_switch_change(u8 hp_slot, void *inst_id)
                  * Switch opened
                  */
                 info("Latch open on Slot(%d)\n", ctrl->first_slot + hp_slot);
-                taskInfo->event_type = INT_SWITCH_OPEN;
+                event_type = INT_SWITCH_OPEN;
                 if (p_slot->pwr_save && p_slot->presence_save) {
-                        taskInfo->event_type = INT_POWER_FAULT;
+                        event_type = INT_POWER_FAULT;
                         err("Surprise Removal of card\n");
                 }
         } else {
@@ -136,34 +112,23 @@ u8 shpchp_handle_switch_change(u8 hp_slot, void *inst_id)
                  *  Switch closed
                  */
                 info("Latch close on Slot(%d)\n", ctrl->first_slot + hp_slot);
-                taskInfo->event_type = INT_SWITCH_CLOSE;
+                event_type = INT_SWITCH_CLOSE;
         }
 
-        if (rc)
-                up(&event_semaphore);   /* signal event thread that new event is posted */
+        queue_interrupt_event(p_slot, event_type);
 
-        return rc;
+        return 1;
 }
 
 u8 shpchp_handle_presence_change(u8 hp_slot, void *inst_id)
 {
         struct controller *ctrl = (struct controller *) inst_id;
         struct slot *p_slot;
-        u8 rc = 0;
-        /*u8 temp_byte;*/
-        struct event_info *taskInfo;
+        u32 event_type;
 
         /* Presence Change */
         dbg("shpchp:  Presence/Notify input change.\n");
 
-        /* This is the structure that tells the worker thread
-         * what to do
-         */
-        taskInfo = &(ctrl->event_queue[ctrl->next_event]);
-        ctrl->next_event = (ctrl->next_event + 1) % 10;
-        taskInfo->hp_slot = hp_slot;
-
-        rc++;
         p_slot = shpchp_find_slot(ctrl, hp_slot + ctrl->slot_device_offset);
 
         /* 
@@ -175,39 +140,29 @@ u8 shpchp_handle_presence_change(u8 hp_slot, void *inst_id)
                  * Card Present
                  */
                 info("Card present on Slot(%d)\n", ctrl->first_slot + hp_slot);
-                taskInfo->event_type = INT_PRESENCE_ON;
+                event_type = INT_PRESENCE_ON;
         } else {
                 /*
                  * Not Present
                  */
                 info("Card not present on Slot(%d)\n", ctrl->first_slot + hp_slot);
-                taskInfo->event_type = INT_PRESENCE_OFF;
+                event_type = INT_PRESENCE_OFF;
         }
 
-        if (rc)
-                up(&event_semaphore);   /* signal event thread that new event is posted */
+        queue_interrupt_event(p_slot, event_type);
 
-        return rc;
+        return 1;
 }
 
 u8 shpchp_handle_power_fault(u8 hp_slot, void *inst_id)
 {
         struct controller *ctrl = (struct controller *) inst_id;
         struct slot *p_slot;
-        u8 rc = 0;
-        struct event_info *taskInfo;
+        u32 event_type;
 
         /* Power fault */
         dbg("shpchp:  Power fault interrupt received.\n");
 
-        /* This is the structure that tells the worker thread
-         * what to do
-         */
-        taskInfo = &(ctrl->event_queue[ctrl->next_event]);
-        ctrl->next_event = (ctrl->next_event + 1) % 10;
-        taskInfo->hp_slot = hp_slot;
-
-        rc++;
         p_slot = shpchp_find_slot(ctrl, hp_slot + ctrl->slot_device_offset);
 
         if ( !(p_slot->hpc_ops->query_power_fault(p_slot))) {
@@ -216,21 +171,21 @@ u8 shpchp_handle_power_fault(u8 hp_slot, void *inst_id)
                  */
                 info("Power fault cleared on Slot(%d)\n", ctrl->first_slot + hp_slot);
                 p_slot->status = 0x00;
-                taskInfo->event_type = INT_POWER_FAULT_CLEAR;
+                event_type = INT_POWER_FAULT_CLEAR;
         } else {
                 /*
                  *   Power fault
                  */
                 info("Power fault on Slot(%d)\n", ctrl->first_slot + hp_slot);
-                taskInfo->event_type = INT_POWER_FAULT;
+                event_type = INT_POWER_FAULT;
                 /* set power fault status for this board */
                 p_slot->status = 0xFF;
                 info("power fault bit %x set\n", hp_slot);
         }
-        if (rc)
-                up(&event_semaphore);   /* signal event thread that new event is posted */
 
-        return rc;
+        queue_interrupt_event(p_slot, event_type);
+
+        return 1;
 }
 
 /* The following routines constitute the bulk of the 
@@ -242,21 +197,11 @@ static int change_bus_speed(struct controller *ctrl, struct slot *p_slot,
         int rc = 0;
 
         dbg("%s: change to speed %d\n", __FUNCTION__, speed);
-        down(&ctrl->crit_sect);
         if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, speed))) {
-                err("%s: Issue of set bus speed mode command failed\n", __FUNCTION__);
-                up(&ctrl->crit_sect);
+                err("%s: Issue of set bus speed mode command failed\n",
+                    __FUNCTION__);
                 return WRONG_BUS_FREQUENCY;
         }
-                
-        if ((rc = p_slot->hpc_ops->check_cmd_status(ctrl))) {
-                err("%s: Can't set bus speed/mode in the case of adapter & bus mismatch\n",
-                          __FUNCTION__);
-                err("%s: Error code (%d)\n", __FUNCTION__, rc);
-                up(&ctrl->crit_sect);
-                return WRONG_BUS_FREQUENCY;
-        }
-        up(&ctrl->crit_sect);
         return rc;
 }
 
@@ -265,33 +210,26 @@ static int fix_bus_speed(struct controller *ctrl, struct slot *pslot,
                 enum pci_bus_speed msp)
 { 
         int rc = 0;
-        
-        if (flag != 0) { /* Other slots on the same bus are occupied */
-                if ( asp < bsp ) {
-                        err("%s: speed of bus %x and adapter %x mismatch\n", __FUNCTION__, bsp, asp);
-                        return WRONG_BUS_FREQUENCY;
+
+        /*
+         * If other slots on the same bus are occupied, we cannot
+         * change the bus speed.
+         */
+        if (flag) {
+                if (asp < bsp) {
+                        err("%s: speed of bus %x and adapter %x mismatch\n",
+                            __FUNCTION__, bsp, asp);
+                        rc = WRONG_BUS_FREQUENCY;
                 }
+                return rc;
+        }
+
+        if (asp < msp) {
+                if (bsp != asp)
+                        rc = change_bus_speed(ctrl, pslot, asp);
         } else {
-                /* Other slots on the same bus are empty */
-                if (msp == bsp) {
-                /* if adapter_speed >= bus_speed, do nothing */
-                        if (asp < bsp) {
-                                /* 
-                                * Try to lower bus speed to accommodate the adapter if other slots 
-                                * on the same controller are empty
-                                */
-                                if ((rc = change_bus_speed(ctrl, pslot, asp)))
-                                        return rc;
-                        } 
-                } else {
-                        if (asp < msp) {
-                                if ((rc = change_bus_speed(ctrl, pslot, asp)))
-                                        return rc;
-                        } else {
-                                if ((rc = change_bus_speed(ctrl, pslot, msp)))
-                                        return rc;
-                        }
-                }
+                if (bsp != msp)
+                        rc = change_bus_speed(ctrl, pslot, msp);
         }
         return rc;
 }
@@ -308,8 +246,7 @@ static int board_added(struct slot *p_slot)
         u8 hp_slot;
         u8 slots_not_empty = 0;
         int rc = 0;
-        enum pci_bus_speed adapter_speed, bus_speed, max_bus_speed;
-        u8 pi, mode;
+        enum pci_bus_speed asp, bsp, msp;
         struct controller *ctrl = p_slot->ctrl;
 
         hp_slot = p_slot->device - ctrl->slot_device_offset;
@@ -318,187 +255,68 @@ static int board_added(struct slot *p_slot)
                         __FUNCTION__, p_slot->device,
                         ctrl->slot_device_offset, hp_slot);
 
-        /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
-
         /* Power on slot without connecting to bus */
         rc = p_slot->hpc_ops->power_on_slot(p_slot);
         if (rc) {
                 err("%s: Failed to power on slot\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
                 return -1;
         }
         
-        rc = p_slot->hpc_ops->check_cmd_status(ctrl);
-        if (rc) {
-                err("%s: Failed to power on slot, error code(%d)\n", __FUNCTION__, rc);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
-                return -1;
-        }
-
-        
         if ((ctrl->pci_dev->vendor == 0x8086) && (ctrl->pci_dev->device == 0x0332)) {
                 if (slots_not_empty)
                         return WRONG_BUS_FREQUENCY;
                 
                 if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, PCI_SPEED_33MHz))) {
                         err("%s: Issue of set bus speed mode command failed\n", __FUNCTION__);
-                        up(&ctrl->crit_sect);
                         return WRONG_BUS_FREQUENCY;
                 }
                 
-                if ((rc = p_slot->hpc_ops->check_cmd_status(ctrl))) {
-                        err("%s: Can't set bus speed/mode in the case of adapter & bus mismatch\n",
-                                  __FUNCTION__);
-                        err("%s: Error code (%d)\n", __FUNCTION__, rc);
-                        up(&ctrl->crit_sect);
-                        return WRONG_BUS_FREQUENCY;
-                }
                 /* turn on board, blink green LED, turn off Amber LED */
                 if ((rc = p_slot->hpc_ops->slot_enable(p_slot))) {
                         err("%s: Issue of Slot Enable command failed\n", __FUNCTION__);
-                        up(&ctrl->crit_sect);
                         return rc;
                 }
-
-                if ((rc = p_slot->hpc_ops->check_cmd_status(ctrl))) {
-                        err("%s: Failed to enable slot, error code(%d)\n", __FUNCTION__, rc);
-                        up(&ctrl->crit_sect);
-                        return rc;  
-                }
         }
  
-        rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &adapter_speed);
-        /* 0 = PCI 33Mhz, 1 = PCI 66 Mhz, 2 = PCI-X 66 PA, 4 = PCI-X 66 ECC, */
-        /* 5 = PCI-X 133 PA, 7 = PCI-X 133 ECC,  0xa = PCI-X 133 Mhz 266, */
-        /* 0xd = PCI-X 133 Mhz 533 */
-        /* This encoding is different from the one used in cur_bus_speed & */
-        /* max_bus_speed */
-
-        if (rc  || adapter_speed == PCI_SPEED_UNKNOWN) {
-                err("%s: Can't get adapter speed or bus mode mismatch\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
+        rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &asp);
+        if (rc) {
+                err("%s: Can't get adapter speed or bus mode mismatch\n",
+                    __FUNCTION__);
                 return WRONG_BUS_FREQUENCY;
         }
 
-        rc = p_slot->hpc_ops->get_cur_bus_speed(p_slot, &bus_speed);
-        if (rc || bus_speed == PCI_SPEED_UNKNOWN) {
+        rc = p_slot->hpc_ops->get_cur_bus_speed(p_slot, &bsp);
+        if (rc) {
                 err("%s: Can't get bus operation speed\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
                 return WRONG_BUS_FREQUENCY;
         }
 
-        rc = p_slot->hpc_ops->get_max_bus_speed(p_slot, &max_bus_speed);
-        if (rc || max_bus_speed == PCI_SPEED_UNKNOWN) {
+        rc = p_slot->hpc_ops->get_max_bus_speed(p_slot, &msp);
+        if (rc) {
                 err("%s: Can't get max bus operation speed\n", __FUNCTION__);
-                max_bus_speed = bus_speed;
-        }
-
-        /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
-
-        if ((rc  = p_slot->hpc_ops->get_prog_int(p_slot, &pi))) {
-                err("%s: Can't get controller programming interface, set it to 1\n", __FUNCTION__);
-                pi = 1;
+                msp = bsp;
         }
 
         /* Check if there are other slots or devices on the same bus */
         if (!list_empty(&ctrl->pci_dev->subordinate->devices))
                 slots_not_empty = 1;
 
-        dbg("%s: slots_not_empty %d, pi %d\n", __FUNCTION__, 
-                slots_not_empty, pi);
-        dbg("adapter_speed %d, bus_speed %d, max_bus_speed %d\n", 
-                adapter_speed, bus_speed, max_bus_speed);
-
-        if (pi == 2) {
-                dbg("%s: In PI = %d\n", __FUNCTION__, pi);
-                if ((rc = p_slot->hpc_ops->get_mode1_ECC_cap(p_slot, &mode))) {
-                        err("%s: Can't get Mode1_ECC, set mode to 0\n", __FUNCTION__);
-                        mode = 0;
-                }
+        dbg("%s: slots_not_empty %d, adapter_speed %d, bus_speed %d, "
+            "max_bus_speed %d\n", __FUNCTION__, slots_not_empty, asp,
+            bsp, msp);
 
-                switch (adapter_speed) {
-                case PCI_SPEED_133MHz_PCIX_533:
-                case PCI_SPEED_133MHz_PCIX_266:
-                        if ((bus_speed != adapter_speed) &&
-                           ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                return rc;
-                        break;  
-                case PCI_SPEED_133MHz_PCIX_ECC:
-                case PCI_SPEED_133MHz_PCIX:
-                        if (mode) { /* Bus - Mode 1 ECC */
-                                if ((bus_speed != 0x7) &&
-                                   ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                        return rc;
-                        } else {
-                                if ((bus_speed != 0x4) &&
-                                   ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                        return rc;
-                        }
-                        break;
-                case PCI_SPEED_66MHz_PCIX_ECC:
-                case PCI_SPEED_66MHz_PCIX:
-                        if (mode) { /* Bus - Mode 1 ECC */
-                                if ((bus_speed != 0x5) &&
-                                   ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                        return rc;
-                        } else {
-                                if ((bus_speed != 0x2) &&
-                                   ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                        return rc;
-                        }
-                        break;
-                case PCI_SPEED_66MHz:
-                        if ((bus_speed != 0x1) &&
-                           ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed)))) 
-                                return rc;
-                        break;  
-                case PCI_SPEED_33MHz:
-                        if (bus_speed > 0x0) {
-                                if (slots_not_empty == 0) {
-                                        if ((rc = change_bus_speed(ctrl, p_slot, adapter_speed)))
-                                                return rc;
-                                } else {
-                                        err("%s: speed of bus %x and adapter %x mismatch\n", __FUNCTION__, bus_speed, adapter_speed);
-                                        return WRONG_BUS_FREQUENCY;
-                                }
-                        }
-                        break;
-                default:
-                        err("%s: speed of bus %x and adapter %x mismatch\n", __FUNCTION__, bus_speed, adapter_speed);
-                        return WRONG_BUS_FREQUENCY;
-                }
-        } else {
-                /* If adpater_speed == bus_speed, nothing to do here */
-                dbg("%s: In PI = %d\n", __FUNCTION__, pi);
-                if ((adapter_speed != bus_speed) &&
-                   ((rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, adapter_speed, bus_speed, max_bus_speed))))
-                                return rc;
-        }
+        rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, asp, bsp, msp);
+        if (rc)
+                return rc;
 
-        down(&ctrl->crit_sect);
         /* turn on board, blink green LED, turn off Amber LED */
         if ((rc = p_slot->hpc_ops->slot_enable(p_slot))) {
                 err("%s: Issue of Slot Enable command failed\n", __FUNCTION__);
-                up(&ctrl->crit_sect);
                 return rc;
         }
 
-        if ((rc = p_slot->hpc_ops->check_cmd_status(ctrl))) {
-                err("%s: Failed to enable slot, error code(%d)\n", __FUNCTION__, rc);
-                up(&ctrl->crit_sect);
-                return rc;  
-        }
-
-        up(&ctrl->crit_sect);
-
         /* Wait for ~1 second */
-        wait_for_ctrl_irq (ctrl);
+        msleep(1000);
 
         dbg("%s: slot status = %x\n", __FUNCTION__, p_slot->status);
         /* Check for a power fault */
@@ -520,40 +338,18 @@ static int board_added(struct slot *p_slot)
         p_slot->is_a_board = 0x01;
         p_slot->pwr_save = 1;
 
-        /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
-
         p_slot->hpc_ops->green_led_on(p_slot);
 
-        /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
-
         return 0;
 
 err_exit:
-        /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
-
         /* turn off slot, turn on Amber LED, turn off Green LED */
         rc = p_slot->hpc_ops->slot_disable(p_slot);
         if (rc) {
                 err("%s: Issue of Slot Disable command failed\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
-                return rc;
-        }
-
-        rc = p_slot->hpc_ops->check_cmd_status(ctrl);
-        if (rc) {
-                err("%s: Failed to disable slot, error code(%d)\n", __FUNCTION__, rc);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
                 return rc;
         }
 
-        /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
-
         return(rc);
 }
 
@@ -580,37 +376,19 @@ static int remove_board(struct slot *p_slot)
         if (p_slot->is_a_board)
                 p_slot->status = 0x01;
 
-        /* Wait for exclusive access to hardware */
-        down(&ctrl->crit_sect);
-
         /* turn off slot, turn on Amber LED, turn off Green LED */
         rc = p_slot->hpc_ops->slot_disable(p_slot);
         if (rc) {
                 err("%s: Issue of Slot Disable command failed\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
                 return rc;
         }
-
-        rc = p_slot->hpc_ops->check_cmd_status(ctrl);
-        if (rc) {
-                err("%s: Failed to disable slot, error code(%d)\n", __FUNCTION__, rc);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
-                return rc;  
-        }
         
         rc = p_slot->hpc_ops->set_attention_status(p_slot, 0);
         if (rc) {
                 err("%s: Issue of Set Attention command failed\n", __FUNCTION__);
-                /* Done with exclusive hardware access */
-                up(&ctrl->crit_sect);
                 return rc;
         }
 
-        /* Done with exclusive hardware access */
-        up(&ctrl->crit_sect);
-
         p_slot->pwr_save = 0;
         p_slot->is_a_board = 0;
 
@@ -618,13 +396,10 @@ static int remove_board(struct slot *p_slot)
 }
 
 
-static void pushbutton_helper_thread (unsigned long data)
-{
-        pushbutton_pending = data;
-
-        up(&event_semaphore);
-}
-
+struct pushbutton_work_info {
+        struct slot *p_slot;
+        struct work_struct work;
+};
 
 /**
  * shpchp_pushbutton_thread
@@ -633,96 +408,63 @@ static void pushbutton_helper_thread (unsigned long data)
  * Handles all pending events and exits.
  *
  */
-static void shpchp_pushbutton_thread (unsigned long slot)
+static void shpchp_pushbutton_thread(void *data)
 {
-        struct slot *p_slot = (struct slot *) slot;
-        u8 getstatus;
-        
-        pushbutton_pending = 0;
-
-        if (!p_slot) {
-                dbg("%s: Error! slot NULL\n", __FUNCTION__);
-                return;
-        }
-
-        p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
-        if (getstatus) {
-                p_slot->state = POWEROFF_STATE;
+        struct pushbutton_work_info *info = data;
+        struct slot *p_slot = info->p_slot;
 
+        mutex_lock(&p_slot->lock);
+        switch (p_slot->state) {
+        case POWEROFF_STATE:
+                mutex_unlock(&p_slot->lock);
                 shpchp_disable_slot(p_slot);
+                mutex_lock(&p_slot->lock);
                 p_slot->state = STATIC_STATE;
-        } else {
-                p_slot->state = POWERON_STATE;
-
-                if (shpchp_enable_slot(p_slot)) {
-                        /* Wait for exclusive access to hardware */
-                        down(&p_slot->ctrl->crit_sect);
-
+                break;
+        case POWERON_STATE:
+                mutex_unlock(&p_slot->lock);
+                if (shpchp_enable_slot(p_slot))
                         p_slot->hpc_ops->green_led_off(p_slot);
-
-                        /* Done with exclusive hardware access */
-                        up(&p_slot->ctrl->crit_sect);
-                }
+                mutex_lock(&p_slot->lock);
                 p_slot->state = STATIC_STATE;
+                break;
+        default:
+                break;
         }
+        mutex_unlock(&p_slot->lock);
 
-        return;
-}
-
-
-/* this is the main worker thread */
-static int event_thread(void* data)
-{
-        struct controller *ctrl;
-        lock_kernel();
-        daemonize("shpchpd_event");
-        unlock_kernel();
-
-        while (1) {
-                dbg("!!!!event_thread sleeping\n");
-                down_interruptible (&event_semaphore);
-                dbg("event_thread woken finished = %d\n", event_finished);
-                if (event_finished || signal_pending(current))
-                        break;
-                /* Do stuff here */
-                if (pushbutton_pending)
-                        shpchp_pushbutton_thread(pushbutton_pending);
-                else
-                        for (ctrl = shpchp_ctrl_list; ctrl; ctrl=ctrl->next)
-                                interrupt_event_handler(ctrl);
-        }
-        dbg("event_thread signals exit\n");
-        up(&event_exit);
-        return 0;
+        kfree(info);
 }
 
-int shpchp_event_start_thread (void)
+void queue_pushbutton_work(void *data)
 {
-        int pid;
+        struct slot *p_slot = data;
+        struct pushbutton_work_info *info;
 
-        /* initialize our semaphores */
-        init_MUTEX_LOCKED(&event_exit);
-        event_finished=0;
-
-        init_MUTEX_LOCKED(&event_semaphore);
-        pid = kernel_thread(event_thread, NULL, 0);
-
-        if (pid < 0) {
-                err ("Can't start up our event thread\n");
-                return -1;
+        info = kmalloc(sizeof(*info), GFP_KERNEL);
+        if (!info) {
+                err("%s: Cannot allocate memory\n", __FUNCTION__);
+                return;
         }
-        return 0;
-}
-
+        info->p_slot = p_slot;
+        INIT_WORK(&info->work, shpchp_pushbutton_thread, info);
 
-void shpchp_event_stop_thread (void)
-{
-        event_finished = 1;
-        up(&event_semaphore);
-        down(&event_exit);
+        mutex_lock(&p_slot->lock);
+        switch (p_slot->state) {
+        case BLINKINGOFF_STATE:
+                p_slot->state = POWEROFF_STATE;
+                break;
+        case BLINKINGON_STATE:
+                p_slot->state = POWERON_STATE;
+                break;
+        default:
+                goto out;
+        }
+        queue_work(shpchp_wq, &info->work);
+ out:
+        mutex_unlock(&p_slot->lock);
 }
 
-
 static int update_slot_info (struct slot *slot)
 {
         struct hotplug_slot_info *info;
@@ -742,149 +484,110 @@ static int update_slot_info (struct slot *slot)
         return result;
 }
 
-static void interrupt_event_handler(struct controller *ctrl)
+/*
+ * Note: This function must be called with slot->lock held
+ */
+static void handle_button_press_event(struct slot *p_slot)
 {
-        int loop = 0;
-        int change = 1;
-        u8 hp_slot;
         u8 getstatus;
-        struct slot *p_slot;
 
-        while (change) {
-                change = 0;
-
-                for (loop = 0; loop < 10; loop++) {
-                        if (ctrl->event_queue[loop].event_type != 0) {
-                                dbg("%s:loop %x event_type %x\n", __FUNCTION__, loop, 
-                                        ctrl->event_queue[loop].event_type);
-                                hp_slot = ctrl->event_queue[loop].hp_slot;
-
-                                p_slot = shpchp_find_slot(ctrl, hp_slot + ctrl->slot_device_offset);
-
-                                if (ctrl->event_queue[loop].event_type == INT_BUTTON_CANCEL) {
-                                        dbg("%s: button cancel\n", __FUNCTION__);
-                                        del_timer(&p_slot->task_event);
-
-                                        switch (p_slot->state) {
-                                        case BLINKINGOFF_STATE:
-                                                /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
-
-                                                p_slot->hpc_ops->green_led_on(p_slot);
-
-                                                p_slot->hpc_ops->set_attention_status(p_slot, 0);
-
-                                                /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
-                                                break;
-                                        case BLINKINGON_STATE:
-                                                /* Wait for exclusive access to hardware */
-                                                down(&ctrl->crit_sect);
-
-                                                p_slot->hpc_ops->green_led_off(p_slot);
-
-                                                p_slot->hpc_ops->set_attention_status(p_slot, 0);
-
-                                                /* Done with exclusive hardware access */
-                                                up(&ctrl->crit_sect);
-
-                                                break;
-                                        default:
-                                                warn("Not a valid state\n");
-                                                return;
-                                        }
-                                        info(msg_button_cancel, p_slot->number);
-                                        p_slot->state = STATIC_STATE;
-                                } else if (ctrl->event_queue[loop].event_type == INT_BUTTON_PRESS) {
-                                        /* Button Pressed (No action on 1st press...) */
-                                        dbg("%s: Button pressed\n", __FUNCTION__);
-
-                                        p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
-                                        if (getstatus) {
-                                                /* slot is on */
-                                                dbg("%s: slot is on\n", __FUNCTION__);
-                                                p_slot->state = BLINKINGOFF_STATE;
-                                                info(msg_button_off, p_slot->number);
-                                        } else {
-                                                /* slot is off */
-                                                dbg("%s: slot is off\n", __FUNCTION__);
-                                                p_slot->state = BLINKINGON_STATE;
-                                                info(msg_button_on, p_slot->number);
-                                        }
-
-                                        /* Wait for exclusive access to hardware */
-                                        down(&ctrl->crit_sect);
-
-                                        /* blink green LED and turn off amber */
-                                        p_slot->hpc_ops->green_led_blink(p_slot);
-                                        
-                                        p_slot->hpc_ops->set_attention_status(p_slot, 0);
-
-                                        /* Done with exclusive hardware access */
-                                        up(&ctrl->crit_sect);
-
-                                        init_timer(&p_slot->task_event);
-                                        p_slot->task_event.expires = jiffies + 5 * HZ;   /* 5 second delay */
-                                        p_slot->task_event.function = (void (*)(unsigned long)) pushbutton_helper_thread;
-                                        p_slot->task_event.data = (unsigned long) p_slot;
-
-                                        dbg("%s: add_timer p_slot = %p\n", __FUNCTION__,(void *) p_slot);
-                                        add_timer(&p_slot->task_event);
-                                } else if (ctrl->event_queue[loop].event_type == INT_POWER_FAULT) {
-                                        /***********POWER FAULT********************/
-                                        dbg("%s: power fault\n", __FUNCTION__);
-                                        /* Wait for exclusive access to hardware */
-                                        down(&ctrl->crit_sect);
-
-                                        p_slot->hpc_ops->set_attention_status(p_slot, 1);
-                                        
-                                        p_slot->hpc_ops->green_led_off(p_slot);
-
-                                        /* Done with exclusive hardware access */
-                                        up(&ctrl->crit_sect);
-                                } else {
-                                        /* refresh notification */
-                                        if (p_slot)
-                                                update_slot_info(p_slot);
-                                }
-
-                                ctrl->event_queue[loop].event_type = 0;
-
-                                change = 1;
-                        }
-                }               /* End of FOR loop */
+        switch (p_slot->state) {
+        case STATIC_STATE:
+                p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
+                if (getstatus) {
+                        p_slot->state = BLINKINGOFF_STATE;
+                        info(msg_button_off, p_slot->number);
+                } else {
+                        p_slot->state = BLINKINGON_STATE;
+                        info(msg_button_on, p_slot->number);
+                }
+                /* blink green LED and turn off amber */
+                p_slot->hpc_ops->green_led_blink(p_slot);
+                p_slot->hpc_ops->set_attention_status(p_slot, 0);
+
+                schedule_delayed_work(&p_slot->work, 5*HZ);
+                break;
+        case BLINKINGOFF_STATE:
+        case BLINKINGON_STATE:
+                /*
+                 * Cancel if we are still blinking; this means that we
+                 * press the attention again before the 5 sec. limit
+                 * expires to cancel hot-add or hot-remove
+                 */
+                info("Button cancel on Slot(%s)\n", p_slot->name);
+                dbg("%s: button cancel\n", __FUNCTION__);
+                cancel_delayed_work(&p_slot->work);
+                if (p_slot->state == BLINKINGOFF_STATE)
+                        p_slot->hpc_ops->green_led_on(p_slot);
+                else
+                        p_slot->hpc_ops->green_led_off(p_slot);
+                p_slot->hpc_ops->set_attention_status(p_slot, 0);
+                info(msg_button_cancel, p_slot->number);
+                p_slot->state = STATIC_STATE;
+                break;
+        case POWEROFF_STATE:
+        case POWERON_STATE:
+                /*
+                 * Ignore if the slot is on power-on or power-off state;
+                 * this means that the previous attention button action
+                 * to hot-add or hot-remove is undergoing
+                 */
+                info("Button ignore on Slot(%s)\n", p_slot->name);
+                update_slot_info(p_slot);
+                break;
+        default:
+                warn("Not a valid state\n");
+                break;
         }
+}
+
+static void interrupt_event_handler(void *data)
+{
+        struct event_info *info = data;
+        struct slot *p_slot = info->p_slot;
+
+        mutex_lock(&p_slot->lock);
+        switch (info->event_type) {
+        case INT_BUTTON_PRESS:
+                handle_button_press_event(p_slot);
+                break;
+        case INT_POWER_FAULT:
+                dbg("%s: power fault\n", __FUNCTION__);
+                p_slot->hpc_ops->set_attention_status(p_slot, 1);
+                p_slot->hpc_ops->green_led_off(p_slot);
+                break;
+        default:
+                update_slot_info(p_slot);
+                break;
+        }
+        mutex_unlock(&p_slot->lock);
 
-        return;
+        kfree(info);
 }
 
 
-int shpchp_enable_slot (struct slot *p_slot)
+static int shpchp_enable_slot (struct slot *p_slot)
 {
         u8 getstatus = 0;
-        int rc;
+        int rc, retval = -ENODEV;
 
         /* Check to see if (latch closed, card present, power off) */
-        down(&p_slot->ctrl->crit_sect);
+        mutex_lock(&p_slot->ctrl->crit_sect);
         rc = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
         if (rc || !getstatus) {
                 info("%s: no adapter on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
         rc = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
         if (rc || getstatus) {
                 info("%s: latch open on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
         rc = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
         if (rc || getstatus) {
                 info("%s: already enabled on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
-        up(&p_slot->ctrl->crit_sect);
 
         p_slot->is_a_board = 1;
 
@@ -899,56 +602,119 @@ int shpchp_enable_slot (struct slot *p_slot)
              && p_slot->ctrl->num_slots == 1) {
                 /* handle amd pogo errata; this must be done before enable  */
                 amd_pogo_errata_save_misc_reg(p_slot);
-                rc = board_added(p_slot);
+                retval = board_added(p_slot);
                 /* handle amd pogo errata; this must be done after enable  */
                 amd_pogo_errata_restore_misc_reg(p_slot);
         } else
-                rc = board_added(p_slot);
+                retval = board_added(p_slot);
 
-        if (rc) {
+        if (retval) {
                 p_slot->hpc_ops->get_adapter_status(p_slot,
                                 &(p_slot->presence_save));
                 p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
         }
 
         update_slot_info(p_slot);
-        return rc;
+ out:
+        mutex_unlock(&p_slot->ctrl->crit_sect);
+        return retval;
 }
 
 
-int shpchp_disable_slot (struct slot *p_slot)
+static int shpchp_disable_slot (struct slot *p_slot)
 {
         u8 getstatus = 0;
-        int ret = 0;
+        int rc, retval = -ENODEV;
 
         if (!p_slot->ctrl)
                 return -ENODEV;
 
         /* Check to see if (latch closed, card present, power on) */
-        down(&p_slot->ctrl->crit_sect);
+        mutex_lock(&p_slot->ctrl->crit_sect);
 
-        ret = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
-        if (ret || !getstatus) {
+        rc = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
+        if (rc || !getstatus) {
                 info("%s: no adapter on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
-        ret = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
-        if (ret || getstatus) {
+        rc = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
+        if (rc || getstatus) {
                 info("%s: latch open on slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
-        ret = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
-        if (ret || !getstatus) {
+        rc = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
+        if (rc || !getstatus) {
                 info("%s: already disabled slot(%x)\n", __FUNCTION__, p_slot->number);
-                up(&p_slot->ctrl->crit_sect);
-                return -ENODEV;
+                goto out;
         }
-        up(&p_slot->ctrl->crit_sect);
 
-        ret = remove_board(p_slot);
+        retval = remove_board(p_slot);
         update_slot_info(p_slot);
-        return ret;
+ out:
+        mutex_unlock(&p_slot->ctrl->crit_sect);
+        return retval;
 }
 
+int shpchp_sysfs_enable_slot(struct slot *p_slot)
+{
+        int retval = -ENODEV;
+
+        mutex_lock(&p_slot->lock);
+        switch (p_slot->state) {
+        case BLINKINGON_STATE:
+                cancel_delayed_work(&p_slot->work);
+        case STATIC_STATE:
+                p_slot->state = POWERON_STATE;
+                mutex_unlock(&p_slot->lock);
+                retval = shpchp_enable_slot(p_slot);
+                mutex_lock(&p_slot->lock);
+                p_slot->state = STATIC_STATE;
+                break;
+        case POWERON_STATE:
+                info("Slot %s is already in powering on state\n",
+                     p_slot->name);
+                break;
+        case BLINKINGOFF_STATE:
+        case POWEROFF_STATE:
+                info("Already enabled on slot %s\n", p_slot->name);
+                break;
+        default:
+                err("Not a valid state on slot %s\n", p_slot->name);
+                break;
+        }
+        mutex_unlock(&p_slot->lock);
+
+        return retval;
+}
+
+int shpchp_sysfs_disable_slot(struct slot *p_slot)
+{
+        int retval = -ENODEV;
+
+        mutex_lock(&p_slot->lock);
+        switch (p_slot->state) {
+        case BLINKINGOFF_STATE:
+                cancel_delayed_work(&p_slot->work);
+        case STATIC_STATE:
+                p_slot->state = POWEROFF_STATE;
+                mutex_unlock(&p_slot->lock);
+                retval = shpchp_disable_slot(p_slot);
+                mutex_lock(&p_slot->lock);
+                p_slot->state = STATIC_STATE;
+                break;
+        case POWEROFF_STATE:
+                info("Slot %s is already in powering off state\n",
+                     p_slot->name);
+                break;
+        case BLINKINGON_STATE:
+        case POWERON_STATE:
+                info("Already disabled on slot %s\n", p_slot->name);
+                break;
+        default:
+                err("Not a valid state on slot %s\n", p_slot->name);
+                break;
+        }
+        mutex_unlock(&p_slot->lock);
+
+        return retval;
+}
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index b4226ff3a854..66123cf4deaa 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -82,31 +82,6 @@
 #define SLOT_100MHZ_PCIX_533    0x0f000000
 #define SLOT_133MHZ_PCIX_533    0xf0000000
 
-
-/* Secondary Bus Configuration Register */
-/* For PI = 1, Bits 0 to 2 have been encoded as follows to show current bus speed/mode */
-#define PCI_33MHZ               0x0
-#define PCI_66MHZ               0x1
-#define PCIX_66MHZ              0x2
-#define PCIX_100MHZ             0x3
-#define PCIX_133MHZ             0x4
-
-/* For PI = 2, Bits 0 to 3 have been encoded as follows to show current bus speed/mode */
-#define PCI_33MHZ               0x0
-#define PCI_66MHZ               0x1
-#define PCIX_66MHZ              0x2
-#define PCIX_100MHZ             0x3
-#define PCIX_133MHZ             0x4
-#define PCIX_66MHZ_ECC          0x5
-#define PCIX_100MHZ_ECC         0x6
-#define PCIX_133MHZ_ECC         0x7
-#define PCIX_66MHZ_266          0x9
-#define PCIX_100MHZ_266         0xa
-#define PCIX_133MHZ_266         0xb
-#define PCIX_66MHZ_533          0x11
-#define PCIX_100MHZ_533         0x12
-#define PCIX_133MHZ_533         0x13
-
 /* Slot Configuration */
 #define SLOT_NUM                0x0000001F
 #define FIRST_DEV_NUM           0x00001F00
@@ -231,6 +206,7 @@ static spinlock_t list_lock;
 static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs);
 
 static void start_int_poll_timer(struct php_ctlr_state_s *php_ctlr, int seconds);
+static int hpc_check_cmd_status(struct controller *ctrl);
 
 /* This is the interrupt polling timeout function. */
 static void int_poll_timeout(unsigned long lphp_ctlr)
@@ -303,10 +279,13 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
         int i;
 
         DBG_ENTER_ROUTINE 
-        
+
+        mutex_lock(&slot->ctrl->cmd_lock);
+
         if (!php_ctlr) {
                 err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-                return -1;
+                retval = -EINVAL;
+                goto out;
         }
 
         for (i = 0; i < 10; i++) {
@@ -323,7 +302,8 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
         if (cmd_status & 0x1) { 
                 /* After 1 sec and and the controller is still busy */
                 err("%s : Controller is still busy after 1 sec.\n", __FUNCTION__);
-                return -1;
+                retval = -EBUSY;
+                goto out;
         }
 
         ++t_slot;
@@ -340,6 +320,17 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
          * Wait for command completion.
          */
         retval = shpc_wait_cmd(slot->ctrl);
+        if (retval)
+                goto out;
+
+        cmd_status = hpc_check_cmd_status(slot->ctrl);
+        if (cmd_status) {
+                err("%s: Failed to issued command 0x%x (error code = %d)\n",
+                    __FUNCTION__, cmd, cmd_status);
+                retval = -EIO;
+        }
+ out:
+        mutex_unlock(&slot->ctrl->cmd_lock);
 
         DBG_LEAVE_ROUTINE 
         return retval;
@@ -532,81 +523,41 @@ static int hpc_get_prog_int(struct slot *slot, u8 *prog_int)
 
 static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value)
 {
-        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
-        u32 slot_reg;
-        u16 slot_status, sec_bus_status;
-        u8 m66_cap, pcix_cap, pi;
         int retval = 0;
+        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+        u32 slot_reg = readl(php_ctlr->creg + SLOT1 + 4 * slot->hp_slot);
+        u8 pcix_cap = (slot_reg >> 12) & 7;
+        u8 m66_cap  = (slot_reg >> 9) & 1;
 
         DBG_ENTER_ROUTINE 
 
-        if (!slot->ctrl->hpc_ctlr_handle) {
-                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-                return -1;
-        }
-
-        if (slot->hp_slot >= php_ctlr->num_slots) {
-                err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-                return -1;
-        }
-        
-        pi = readb(php_ctlr->creg + PROG_INTERFACE);
-        slot_reg = readl(php_ctlr->creg + SLOT1 + 4*(slot->hp_slot));
-        dbg("%s: pi = %d, slot_reg = %x\n", __FUNCTION__, pi, slot_reg);
-        slot_status = (u16) slot_reg;
-        dbg("%s: slot_status = %x\n", __FUNCTION__, slot_status);
-        sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
-
-        pcix_cap = (u8) ((slot_status & 0x3000) >> 12);
-        dbg("%s:  pcix_cap = %x\n", __FUNCTION__, pcix_cap);
-        m66_cap = (u8) ((slot_status & 0x0200) >> 9);
-        dbg("%s:  m66_cap = %x\n", __FUNCTION__, m66_cap);
-
+        dbg("%s: slot_reg = %x, pcix_cap = %x, m66_cap = %x\n",
+            __FUNCTION__, slot_reg, pcix_cap, m66_cap);
 
-        if (pi == 2) {
-                switch (pcix_cap) {
-                case 0:
-                        *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
-                        break;
-                case 1:
-                        *value = PCI_SPEED_66MHz_PCIX;
-                        break;
-                case 3:
-                        *value = PCI_SPEED_133MHz_PCIX;
-                        break;
-                case 4:
-                        *value = PCI_SPEED_133MHz_PCIX_266;     
-                        break;
-                case 5:
-                        *value = PCI_SPEED_133MHz_PCIX_533;     
-                        break;
-                case 2: /* Reserved */
-                default:
-                        *value = PCI_SPEED_UNKNOWN;
-                        retval = -ENODEV;
-                        break;
-                }
-        } else {
-                switch (pcix_cap) {
-                case 0:
-                        *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
-                        break;
-                case 1:
-                        *value = PCI_SPEED_66MHz_PCIX;
-                        break;
-                case 3:
-                        *value = PCI_SPEED_133MHz_PCIX; 
-                        break;
-                case 2: /* Reserved */
-                default:
-                        *value = PCI_SPEED_UNKNOWN;
-                        retval = -ENODEV;
-                        break;
-                }
+        switch (pcix_cap) {
+        case 0x0:
+                *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
+                break;
+        case 0x1:
+                *value = PCI_SPEED_66MHz_PCIX;
+                break;
+        case 0x3:
+                *value = PCI_SPEED_133MHz_PCIX;
+                break;
+        case 0x4:
+                *value = PCI_SPEED_133MHz_PCIX_266;
+                break;
+        case 0x5:
+                *value = PCI_SPEED_133MHz_PCIX_533;
+                break;
+        case 0x2:
+        default:
+                *value = PCI_SPEED_UNKNOWN;
+                retval = -ENODEV;
+                break;
         }
 
         dbg("Adapter speed = %d\n", *value);
-        
         DBG_LEAVE_ROUTINE 
         return retval;
 }
@@ -797,6 +748,7 @@ static void hpc_release_ctlr(struct controller *ctrl)
 {
         struct php_ctlr_state_s *php_ctlr = ctrl->hpc_ctlr_handle;
         struct php_ctlr_state_s *p, *p_prev;
+        int i;
 
         DBG_ENTER_ROUTINE 
 
@@ -805,6 +757,14 @@ static void hpc_release_ctlr(struct controller *ctrl)
                 return ;
         }
 
+        /*
+         * Mask all slot event interrupts
+         */
+        for (i = 0; i < ctrl->num_slots; i++)
+                writel(0xffff3fff, php_ctlr->creg + SLOT1 + (4 * i));
+
+        cleanup_slots(ctrl);
+
         if (shpchp_poll_mode) {
             del_timer(&php_ctlr->int_poll_timer);
         } else {        
@@ -814,6 +774,7 @@ static void hpc_release_ctlr(struct controller *ctrl)
                         pci_disable_msi(php_ctlr->pci_dev);
                 }
         }
+
         if (php_ctlr->pci_dev) {
                 iounmap(php_ctlr->creg);
                 release_mem_region(ctrl->mmio_base, ctrl->mmio_size);
@@ -939,98 +900,66 @@ static int hpc_slot_disable(struct slot * slot)
 
 static int hpc_set_bus_speed_mode(struct slot * slot, enum pci_bus_speed value)
 {
-        u8 slot_cmd;
-        u8 pi;
-        int retval = 0;
+        int retval;
         struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+        u8 pi, cmd;
 
         DBG_ENTER_ROUTINE 
-        
-        if (!slot->ctrl->hpc_ctlr_handle) {
-                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-                return -1;
-        }
 
         pi = readb(php_ctlr->creg + PROG_INTERFACE);
-        
-        if (pi == 1) {
-                switch (value) {
-                case 0:
-                        slot_cmd = SETA_PCI_33MHZ;
-                        break;
-                case 1:
-                        slot_cmd = SETA_PCI_66MHZ;
-                        break;
-                case 2:
-                        slot_cmd = SETA_PCIX_66MHZ;
-                        break;
-                case 3:
-                        slot_cmd = SETA_PCIX_100MHZ;    
-                        break;
-                case 4:
-                        slot_cmd = SETA_PCIX_133MHZ;    
-                        break;
-                default:
-                        slot_cmd = PCI_SPEED_UNKNOWN;
-                        retval = -ENODEV;
-                        return retval;  
-                }
-        } else {
-                switch (value) {
-                case 0:
-                        slot_cmd = SETB_PCI_33MHZ;
-                        break;
-                case 1:
-                        slot_cmd = SETB_PCI_66MHZ;
-                        break;
-                case 2:
-                        slot_cmd = SETB_PCIX_66MHZ_PM;
-                        break;
-                case 3:
-                        slot_cmd = SETB_PCIX_100MHZ_PM; 
-                        break;
-                case 4:
-                        slot_cmd = SETB_PCIX_133MHZ_PM; 
-                        break;
-                case 5:
-                        slot_cmd = SETB_PCIX_66MHZ_EM;  
-                        break;
-                case 6:
-                        slot_cmd = SETB_PCIX_100MHZ_EM; 
-                        break;
-                case 7:
-                        slot_cmd = SETB_PCIX_133MHZ_EM; 
-                        break;
-                case 8:
-                        slot_cmd = SETB_PCIX_66MHZ_266; 
-                        break;
-                case 0x9:
-                        slot_cmd = SETB_PCIX_100MHZ_266;        
-                        break;
-                case 0xa:
-                        slot_cmd = SETB_PCIX_133MHZ_266;        
-                        break;
-                case 0xb:
-                        slot_cmd = SETB_PCIX_66MHZ_533; 
-                        break;
-                case 0xc:
-                        slot_cmd = SETB_PCIX_100MHZ_533;        
-                        break;
-                case 0xd:
-                        slot_cmd = SETB_PCIX_133MHZ_533;        
-                        break;
-                default:
-                        slot_cmd = PCI_SPEED_UNKNOWN;
-                        retval = -ENODEV;
-                        return retval;  
-                }
+        if ((pi == 1) && (value > PCI_SPEED_133MHz_PCIX))
+                return -EINVAL;
 
+        switch (value) {
+        case PCI_SPEED_33MHz:
+                cmd = SETA_PCI_33MHZ;
+                break;
+        case PCI_SPEED_66MHz:
+                cmd = SETA_PCI_66MHZ;
+                break;
+        case PCI_SPEED_66MHz_PCIX:
+                cmd = SETA_PCIX_66MHZ;
+                break;
+        case PCI_SPEED_100MHz_PCIX:
+                cmd = SETA_PCIX_100MHZ;
+                break;
+        case PCI_SPEED_133MHz_PCIX:
+                cmd = SETA_PCIX_133MHZ;
+                break;
+        case PCI_SPEED_66MHz_PCIX_ECC:
+                cmd = SETB_PCIX_66MHZ_EM;
+                break;
+        case PCI_SPEED_100MHz_PCIX_ECC:
+                cmd = SETB_PCIX_100MHZ_EM;
+                break;
+        case PCI_SPEED_133MHz_PCIX_ECC:
+                cmd = SETB_PCIX_133MHZ_EM;
+                break;
+        case PCI_SPEED_66MHz_PCIX_266:
+                cmd = SETB_PCIX_66MHZ_266;
+                break;
+        case PCI_SPEED_100MHz_PCIX_266:
+                cmd = SETB_PCIX_100MHZ_266;
+                break;
+        case PCI_SPEED_133MHz_PCIX_266:
+                cmd = SETB_PCIX_133MHZ_266;
+                break;
+        case PCI_SPEED_66MHz_PCIX_533:
+                cmd = SETB_PCIX_66MHZ_533;
+                break;
+        case PCI_SPEED_100MHz_PCIX_533:
+                cmd = SETB_PCIX_100MHZ_533;
+                break;
+        case PCI_SPEED_133MHz_PCIX_533:
+                cmd = SETB_PCIX_133MHZ_533;
+                break;
+        default:
+                return -EINVAL;
         }
-        retval = shpc_write_cmd(slot, 0, slot_cmd);
-        if (retval) {
+
+        retval = shpc_write_cmd(slot, 0, cmd);
+        if (retval)
                 err("%s: Write command failed!\n", __FUNCTION__);
-                return -1;
-        }
 
         DBG_LEAVE_ROUTINE
         return retval;
@@ -1093,14 +1022,8 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
                 wake_up_interruptible(&ctrl->queue);
         }
 
-        if ((intr_loc = (intr_loc >> 1)) == 0) {
-                /* Unmask Global Interrupt Mask */
-                temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-                temp_dword &= 0xfffffffe;
-                writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
-
-                return IRQ_NONE;
-        }
+        if ((intr_loc = (intr_loc >> 1)) == 0)
+                goto out;
 
         for (hp_slot = 0; hp_slot < ctrl->num_slots; hp_slot++) { 
         /* To find out which slot has interrupt pending */
@@ -1130,6 +1053,7 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
                         dbg("%s: intr_loc2 = %x\n",__FUNCTION__, intr_loc2); 
                 }
         }
+ out:
         if (!shpchp_poll_mode) {
                 /* Unmask Global Interrupt Mask */
                 temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
@@ -1142,64 +1066,43 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
 
 static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
+        int retval = 0;
         struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
         enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
-        int retval = 0;
-        u8 pi;
-        u32 slot_avail1, slot_avail2;
+        u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
+        u32 slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
+        u32 slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
 
         DBG_ENTER_ROUTINE 
 
-        if (!slot->ctrl->hpc_ctlr_handle) {
-                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-                return -1;
-        }
-
-        if (slot->hp_slot >= php_ctlr->num_slots) {
-                err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-                return -1;
-        }
-
-        pi = readb(php_ctlr->creg + PROG_INTERFACE);
-        slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
-        slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
-
         if (pi == 2) {
                 if (slot_avail2 & SLOT_133MHZ_PCIX_533)
-                        bus_speed = PCIX_133MHZ_533;
+                        bus_speed = PCI_SPEED_133MHz_PCIX_533;
                 else if (slot_avail2 & SLOT_100MHZ_PCIX_533)
-                        bus_speed = PCIX_100MHZ_533;
+                        bus_speed = PCI_SPEED_100MHz_PCIX_533;
                 else if (slot_avail2 & SLOT_66MHZ_PCIX_533)
-                        bus_speed = PCIX_66MHZ_533;
+                        bus_speed = PCI_SPEED_66MHz_PCIX_533;
                 else if (slot_avail2 & SLOT_133MHZ_PCIX_266)
-                        bus_speed = PCIX_133MHZ_266;
+                        bus_speed = PCI_SPEED_133MHz_PCIX_266;
                 else if (slot_avail2 & SLOT_100MHZ_PCIX_266)
-                        bus_speed = PCIX_100MHZ_266;
+                        bus_speed = PCI_SPEED_100MHz_PCIX_266;
                 else if (slot_avail2 & SLOT_66MHZ_PCIX_266)
-                        bus_speed = PCIX_66MHZ_266;
-                else if (slot_avail1 & SLOT_133MHZ_PCIX)
-                        bus_speed = PCIX_133MHZ;
-                else if (slot_avail1 & SLOT_100MHZ_PCIX)
-                        bus_speed = PCIX_100MHZ;
-                else if (slot_avail1 & SLOT_66MHZ_PCIX)
-                        bus_speed = PCIX_66MHZ;
-                else if (slot_avail2 & SLOT_66MHZ)
-                        bus_speed = PCI_66MHZ;
-                else if (slot_avail1 & SLOT_33MHZ)
-                        bus_speed = PCI_33MHZ;
-                else bus_speed = PCI_SPEED_UNKNOWN;
-        } else {
+                        bus_speed = PCI_SPEED_66MHz_PCIX_266;
+        }
+
+        if (bus_speed == PCI_SPEED_UNKNOWN) {
                 if (slot_avail1 & SLOT_133MHZ_PCIX)
-                        bus_speed = PCIX_133MHZ;
+                        bus_speed = PCI_SPEED_133MHz_PCIX;
                 else if (slot_avail1 & SLOT_100MHZ_PCIX)
-                        bus_speed = PCIX_100MHZ;
+                        bus_speed = PCI_SPEED_100MHz_PCIX;
                 else if (slot_avail1 & SLOT_66MHZ_PCIX)
-                        bus_speed = PCIX_66MHZ;
+                        bus_speed = PCI_SPEED_66MHz_PCIX;
                 else if (slot_avail2 & SLOT_66MHZ)
-                        bus_speed = PCI_66MHZ;
+                        bus_speed = PCI_SPEED_66MHz;
                 else if (slot_avail1 & SLOT_33MHZ)
-                        bus_speed = PCI_33MHZ;
-                else bus_speed = PCI_SPEED_UNKNOWN;
+                        bus_speed = PCI_SPEED_33MHz;
+                else
+                        retval = -ENODEV;
         }
 
         *value = bus_speed;
@@ -1210,111 +1113,69 @@ static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 
 static int hpc_get_cur_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
+        int retval = 0;
         struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
         enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
-        u16 sec_bus_status;
-        int retval = 0;
-        u8 pi;
+        u16 sec_bus_reg = readw(php_ctlr->creg + SEC_BUS_CONFIG);
+        u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
+        u8 speed_mode = (pi == 2) ? (sec_bus_reg & 0xF) : (sec_bus_reg & 0x7);
 
         DBG_ENTER_ROUTINE 
 
-        if (!slot->ctrl->hpc_ctlr_handle) {
-                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-                return -1;
-        }
-
-        if (slot->hp_slot >= php_ctlr->num_slots) {
-                err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-                return -1;
+        if ((pi == 1) && (speed_mode > 4)) {
+                *value = PCI_SPEED_UNKNOWN;
+                return -ENODEV;
         }
 
-        pi = readb(php_ctlr->creg + PROG_INTERFACE);
-        sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
-
-        if (pi == 2) {
-                switch (sec_bus_status & 0x000f) {
-                case 0:
-                        bus_speed = PCI_SPEED_33MHz;
-                        break;
-                case 1:
-                        bus_speed = PCI_SPEED_66MHz;
-                        break;
-                case 2:
-                        bus_speed = PCI_SPEED_66MHz_PCIX;
-                        break;
-                case 3:
-                        bus_speed = PCI_SPEED_100MHz_PCIX;      
-                        break;
-                case 4:
-                        bus_speed = PCI_SPEED_133MHz_PCIX;      
-                        break;
-                case 5:
-                        bus_speed = PCI_SPEED_66MHz_PCIX_ECC;
-                        break;
-                case 6:
-                        bus_speed = PCI_SPEED_100MHz_PCIX_ECC;
-                        break;
-                case 7:
-                        bus_speed = PCI_SPEED_133MHz_PCIX_ECC;  
-                        break;
-                case 8:
-                        bus_speed = PCI_SPEED_66MHz_PCIX_266;   
-                        break;
-                case 9:
-                        bus_speed = PCI_SPEED_100MHz_PCIX_266;  
-                        break;
-                case 0xa:
-                        bus_speed = PCI_SPEED_133MHz_PCIX_266;  
-                        break;
-                case 0xb:
-                        bus_speed = PCI_SPEED_66MHz_PCIX_533;   
-                        break;
-                case 0xc:
-                        bus_speed = PCI_SPEED_100MHz_PCIX_533;  
-                        break;
-                case 0xd:
-                        bus_speed = PCI_SPEED_133MHz_PCIX_533;  
-                        break;
-                case 0xe:
-                case 0xf:
-                default:
-                        bus_speed = PCI_SPEED_UNKNOWN;
-                        break;
-                }
-        } else {
-                /* In the case where pi is undefined, default it to 1 */ 
-                switch (sec_bus_status & 0x0007) {
-                case 0:
-                        bus_speed = PCI_SPEED_33MHz;
-                        break;
-                case 1:
-                        bus_speed = PCI_SPEED_66MHz;
-                        break;
-                case 2:
-                        bus_speed = PCI_SPEED_66MHz_PCIX;
-                        break;
-                case 3:
-                        bus_speed = PCI_SPEED_100MHz_PCIX;      
-                        break;
-                case 4:
-                        bus_speed = PCI_SPEED_133MHz_PCIX;      
-                        break;
-                case 5:
-                        bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
-                        break;
-                case 6:
-                        bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
-                        break;
-                case 7:
-                        bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */     
-                        break;
-                default:
-                        bus_speed = PCI_SPEED_UNKNOWN;
-                        break;
-                }
+        switch (speed_mode) {
+        case 0x0:
+                *value = PCI_SPEED_33MHz;
+                break;
+        case 0x1:
+                *value = PCI_SPEED_66MHz;
+                break;
+        case 0x2:
+                *value = PCI_SPEED_66MHz_PCIX;
+                break;
+        case 0x3:
+                *value = PCI_SPEED_100MHz_PCIX;
+                break;
+        case 0x4:
+                *value = PCI_SPEED_133MHz_PCIX;
+                break;
+        case 0x5:
+                *value = PCI_SPEED_66MHz_PCIX_ECC;
+                break;
+        case 0x6:
+                *value = PCI_SPEED_100MHz_PCIX_ECC;
+                break;
+        case 0x7:
+                *value = PCI_SPEED_133MHz_PCIX_ECC;
+                break;
+        case 0x8:
+                *value = PCI_SPEED_66MHz_PCIX_266;
+                break;
+        case 0x9:
+                *value = PCI_SPEED_100MHz_PCIX_266;
+                break;
+        case 0xa:
+                *value = PCI_SPEED_133MHz_PCIX_266;
+                break;
+        case 0xb:
+                *value = PCI_SPEED_66MHz_PCIX_533;
+                break;
+        case 0xc:
+                *value = PCI_SPEED_100MHz_PCIX_533;
+                break;
+        case 0xd:
+                *value = PCI_SPEED_133MHz_PCIX_533;
+                break;
+        default:
+                *value = PCI_SPEED_UNKNOWN;
+                retval = -ENODEV;
+                break;
         }
 
-        *value = bus_speed;
         dbg("Current bus speed = %d\n", bus_speed);
         DBG_LEAVE_ROUTINE 
         return retval;
@@ -1343,7 +1204,6 @@ static struct hpc_ops shpchp_hpc_ops = {
         .green_led_blink                = hpc_set_green_led_blink,
         
         .release_ctlr                   = hpc_release_ctlr,
-        .check_cmd_status               = hpc_check_cmd_status,
 };
 
 inline static int shpc_indirect_creg_read(struct controller *ctrl, int index,
@@ -1375,15 +1235,13 @@ int shpc_init(struct controller * ctrl, struct pci_dev * pdev)
         ctrl->pci_dev = pdev;  /* pci_dev of the P2P bridge */
 
         spin_lock_init(&list_lock);
-        php_ctlr = (struct php_ctlr_state_s *) kmalloc(sizeof(struct php_ctlr_state_s), GFP_KERNEL);
+        php_ctlr = kzalloc(sizeof(*php_ctlr), GFP_KERNEL);
 
         if (!php_ctlr) {        /* allocate controller state data */
                 err("%s: HPC controller memory allocation error!\n", __FUNCTION__);
                 goto abort;
         }
 
-        memset(php_ctlr, 0, sizeof(struct php_ctlr_state_s));
-
         php_ctlr->pci_dev = pdev;       /* save pci_dev in context */
 
         if ((pdev->vendor == PCI_VENDOR_ID_AMD) || (pdev->device ==
@@ -1454,7 +1312,9 @@ int shpc_init(struct controller * ctrl, struct pci_dev * pdev)
         }
         dbg("%s: php_ctlr->creg %p\n", __FUNCTION__, php_ctlr->creg);
 
-        init_MUTEX(&ctrl->crit_sect);
+        mutex_init(&ctrl->crit_sect);
+        mutex_init(&ctrl->cmd_lock);
+
         /* Setup wait queue */
         init_waitqueue_head(&ctrl->queue);
 
diff --git a/drivers/pci/hotplug/shpchp_pci.c b/drivers/pci/hotplug/shpchp_pci.c
index 19e1a5e1e30b..257adc233996 100644
--- a/drivers/pci/hotplug/shpchp_pci.c
+++ b/drivers/pci/hotplug/shpchp_pci.c
@@ -38,7 +38,7 @@ static void program_fw_provided_values(struct pci_dev *dev)
 {
         u16 pci_cmd, pci_bctl;
         struct pci_dev *cdev;
-        struct hotplug_params hpp = {0x8, 0x40, 0, 0}; /* defaults */
+        struct hotplug_params hpp;
 
         /* Program hpp values for this device */
         if (!(dev->hdr_type == PCI_HEADER_TYPE_NORMAL ||
@@ -46,7 +46,13 @@ static void program_fw_provided_values(struct pci_dev *dev)
                         (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI)))
                 return;
 
-        get_hp_params_from_firmware(dev, &hpp);
+        /* use default values if we can't get them from firmware */
+        if (get_hp_params_from_firmware(dev, &hpp)) {
+                hpp.cache_line_size = 8;
+                hpp.latency_timer = 0x40;
+                hpp.enable_serr = 0;
+                hpp.enable_perr = 0;
+        }
 
         pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, hpp.cache_line_size);
         pci_write_config_byte(dev, PCI_LATENCY_TIMER, hpp.latency_timer);
diff --git a/drivers/pci/hotplug/shpchprm_legacy.c b/drivers/pci/hotplug/shpchprm_legacy.c
deleted file mode 100644
index ed6c1254bf6f..000000000000
--- a/drivers/pci/hotplug/shpchprm_legacy.c
+++ /dev/null
@@ -1,54 +0,0 @@
-/*
- * SHPCHPRM Legacy: PHP Resource Manager for Non-ACPI/Legacy platform
- *
- * Copyright (C) 1995,2001 Compaq Computer Corporation
- * Copyright (C) 2001 Greg Kroah-Hartman (greg@kroah.com)
- * Copyright (C) 2001 IBM Corp.
- * Copyright (C) 2003-2004 Intel Corporation
- *
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT.  See the GNU General Public License for more
- * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Send feedback to <greg@kroah.com>,<kristen.c.accardi@intel.com>
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/types.h>
-#include <linux/pci.h>
-#include "shpchp.h"
-
-int shpchprm_get_physical_slot_number(struct controller *ctrl, u32 *sun, u8 busnum, u8 devnum)
-{
-        int     offset = devnum - ctrl->slot_device_offset;
-
-        *sun = (u8) (ctrl->first_slot + ctrl->slot_num_inc * offset);
-        return 0;
-}
-
-void get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp)
-{
-        return;
-}
-
-void get_hp_hw_control_from_firmware(struct pci_dev *dev)
-{
-        return;
-}
-
diff --git a/drivers/pci/hotplug/shpchprm_nonacpi.c b/drivers/pci/hotplug/shpchprm_nonacpi.c
deleted file mode 100644
index c6b40998eeb3..000000000000
--- a/drivers/pci/hotplug/shpchprm_nonacpi.c
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * SHPCHPRM NONACPI: PHP Resource Manager for Non-ACPI/Legacy platform
- *
- * Copyright (C) 1995,2001 Compaq Computer Corporation
- * Copyright (C) 2001 Greg Kroah-Hartman (greg@kroah.com)
- * Copyright (C) 2001 IBM Corp.
- * Copyright (C) 2003-2004 Intel Corporation
- *
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT.  See the GNU General Public License for more
- * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Send feedback to <greg@kroah.com>, <kristen.c.accardi@intel.com>
- *
- */
-
-#include <linux/config.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/types.h>
-#include <linux/pci.h>
-#include <linux/slab.h>
-
-#include "shpchp.h"
-
-int shpchprm_get_physical_slot_number(struct controller *ctrl, u32 *sun, u8 busnum, u8 devnum)
-{
-        int     offset = devnum - ctrl->slot_device_offset;
-
-        dbg("%s: ctrl->slot_num_inc %d, offset %d\n", __FUNCTION__, ctrl->slot_num_inc, offset);
-        *sun = (u8) (ctrl->first_slot + ctrl->slot_num_inc * offset);
-        return 0;
-}
-
-void get_hp_params_from_firmware(struct pci_dev *dev,
-                struct hotplug_params *hpp)
-{
-        return;
-}
-
-void get_hp_hw_control_from_firmware(struct pci_dev *dev)
-{
-        return;
-}
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 48723d6fa60f..a77e79c8c82e 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -103,9 +103,9 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask)
         switch (entry->msi_attrib.type) {
         case PCI_CAP_ID_MSI:
         {
-                int pos;
+                int pos = pci_find_capability(entry->dev, PCI_CAP_ID_MSI);
 
-                if (!(pos = pci_find_capability(entry->dev, PCI_CAP_ID_MSI)))
+                if (!pos)
                         return;
 
                 pci_read_config_dword(entry->dev, msi_lower_address_reg(pos),
@@ -347,9 +347,9 @@ static int assign_msi_vector(void)
 
 static int get_new_vector(void)
 {
-        int vector;
+        int vector = assign_msi_vector();
 
-        if ((vector = assign_msi_vector()) > 0)
+        if (vector > 0)
                 set_intr_gate(vector, interrupt[vector]);
 
         return vector;
@@ -369,7 +369,8 @@ static int msi_init(void)
                 return status;
         }
 
-        if ((status = msi_cache_init()) < 0) {
+        status = msi_cache_init();
+        if (status < 0) {
                 pci_msi_enable = 0;
                 printk(KERN_WARNING "PCI: MSI cache init failed\n");
                 return status;
@@ -523,10 +524,12 @@ static int msi_capability_init(struct pci_dev *dev)
         pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
         pci_read_config_word(dev, msi_control_reg(pos), &control);
         /* MSI Entry Initialization */
-        if (!(entry = alloc_msi_entry()))
+        entry = alloc_msi_entry();
+        if (!entry)
                 return -ENOMEM;
 
-        if ((vector = get_msi_vector(dev)) < 0) {
+        vector = get_msi_vector(dev);
+        if (vector < 0) {
                 kmem_cache_free(msi_cachep, entry);
                 return -EBUSY;
         }
@@ -597,7 +600,8 @@ static int msix_capability_init(struct pci_dev *dev,
         struct msg_address address;
         struct msg_data data;
         int vector, pos, i, j, nr_entries, temp = 0;
-        u32 phys_addr, table_offset;
+        unsigned long phys_addr;
+        u32 table_offset;
         u16 control;
         u8 bir;
         void __iomem *base;
@@ -606,11 +610,11 @@ static int msix_capability_init(struct pci_dev *dev,
         /* Request & Map MSI-X table region */
         pci_read_config_word(dev, msi_control_reg(pos), &control);
         nr_entries = multi_msix_capable(control);
-        pci_read_config_dword(dev, msix_table_offset_reg(pos),
-                &table_offset);
+
+        pci_read_config_dword(dev, msix_table_offset_reg(pos), &table_offset);
         bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
-        phys_addr = pci_resource_start (dev, bir);
-        phys_addr += (u32)(table_offset & ~PCI_MSIX_FLAGS_BIRMASK);
+        table_offset &= ~PCI_MSIX_FLAGS_BIRMASK;
+        phys_addr = pci_resource_start (dev, bir) + table_offset;
         base = ioremap_nocache(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
         if (base == NULL)
                 return -ENOMEM;
@@ -620,7 +624,8 @@ static int msix_capability_init(struct pci_dev *dev,
                 entry = alloc_msi_entry();
                 if (!entry)
                         break;
-                if ((vector = get_msi_vector(dev)) < 0)
+                vector = get_msi_vector(dev);
+                if (vector < 0)
                         break;
 
                 j = entries[i].entry;
@@ -699,12 +704,17 @@ int pci_enable_msi(struct pci_dev* dev)
         if (dev->no_msi)
                 return status;
 
+        if (dev->bus->bus_flags & PCI_BUS_FLAGS_NO_MSI)
+                return -EINVAL;
+
         temp = dev->irq;
 
-        if ((status = msi_init()) < 0)
+        status = msi_init();
+        if (status < 0)
                 return status;
 
-        if (!(pos = pci_find_capability(dev, PCI_CAP_ID_MSI)))
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
+        if (!pos)
                 return -EINVAL;
 
         pci_read_config_word(dev, msi_control_reg(pos), &control);
@@ -728,8 +738,8 @@ int pci_enable_msi(struct pci_dev* dev)
                 dev->irq = temp;
         }
         /* Check whether driver already requested for MSI-X vectors */
-        if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)) > 0 &&
-                !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+        if (pos > 0 && !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
                         printk(KERN_INFO "PCI: %s: Can't enable MSI.  "
                                "Device already has MSI-X vectors assigned\n",
                                pci_name(dev));
@@ -755,7 +765,13 @@ void pci_disable_msi(struct pci_dev* dev)
         u16 control;
         unsigned long flags;
 
-        if (!dev || !(pos = pci_find_capability(dev, PCI_CAP_ID_MSI)))
+        if (!pci_msi_enable)
+                return;
+        if (!dev)
+                return;
+
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
+        if (!pos)
                 return;
 
         pci_read_config_word(dev, msi_control_reg(pos), &control);
@@ -826,8 +842,10 @@ static int msi_free_vector(struct pci_dev* dev, int vector, int reassign)
                          * Detect last MSI-X vector to be released.
                          * Release the MSI-X memory-mapped table.
                          */
+#if 0
                         int pos, nr_entries;
-                        u32 phys_addr, table_offset;
+                        unsigned long phys_addr;
+                        u32 table_offset;
                         u16 control;
                         u8 bir;
 
@@ -838,9 +856,12 @@ static int msi_free_vector(struct pci_dev* dev, int vector, int reassign)
                         pci_read_config_dword(dev, msix_table_offset_reg(pos),
                                 &table_offset);
                         bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
-                        phys_addr = pci_resource_start (dev, bir);
-                        phys_addr += (u32)(table_offset &
-                                ~PCI_MSIX_FLAGS_BIRMASK);
+                        table_offset &= ~PCI_MSIX_FLAGS_BIRMASK;
+                        phys_addr = pci_resource_start(dev, bir) + table_offset;
+/*
+ * FIXME!  and what did you want to do with phys_addr?
+ */
+#endif
                         iounmap(base);
                 }
         }
@@ -924,10 +945,12 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
         if (!pci_msi_enable || !dev || !entries)
                 return -EINVAL;
 
-        if ((status = msi_init()) < 0)
+        status = msi_init();
+        if (status < 0)
                 return status;
 
-        if (!(pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)))
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+        if (!pos)
                 return -EINVAL;
 
         pci_read_config_word(dev, msi_control_reg(pos), &control);
@@ -1006,7 +1029,13 @@ void pci_disable_msix(struct pci_dev* dev)
         int pos, temp;
         u16 control;
 
-        if (!dev || !(pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)))
+        if (!pci_msi_enable)
+                return;
+        if (!dev)
+                return;
+
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+        if (!pos)
                 return;
 
         pci_read_config_word(dev, msi_control_reg(pos), &control);
@@ -1066,8 +1095,8 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                 return;
 
         temp = dev->irq;                /* Save IOAPIC IRQ */
-        if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSI)) > 0 &&
-                !msi_lookup_vector(dev, PCI_CAP_ID_MSI)) {
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
+        if (pos > 0 && !msi_lookup_vector(dev, PCI_CAP_ID_MSI)) {
                 spin_lock_irqsave(&msi_lock, flags);
                 state = msi_desc[dev->irq]->msi_attrib.state;
                 spin_unlock_irqrestore(&msi_lock, flags);
@@ -1080,8 +1109,8 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                         msi_free_vector(dev, dev->irq, 0);
                 dev->irq = temp;                /* Restore IOAPIC IRQ */
         }
-        if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)) > 0 &&
-                !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
+        pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+        if (pos > 0 && !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
                 int vector, head, tail = 0, warning = 0;
                 void __iomem *base = NULL;
 
@@ -1101,7 +1130,9 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                 msi_free_vector(dev, vector, 0);
                 if (warning) {
                         /* Force to release the MSI-X memory-mapped table */
-                        u32 phys_addr, table_offset;
+#if 0
+                        unsigned long phys_addr;
+                        u32 table_offset;
                         u16 control;
                         u8 bir;
 
@@ -1110,9 +1141,12 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                         pci_read_config_dword(dev, msix_table_offset_reg(pos),
                                 &table_offset);
                         bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
-                        phys_addr = pci_resource_start (dev, bir);
-                        phys_addr += (u32)(table_offset &
-                                ~PCI_MSIX_FLAGS_BIRMASK);
+                        table_offset &= ~PCI_MSIX_FLAGS_BIRMASK;
+                        phys_addr = pci_resource_start(dev, bir) + table_offset;
+/*
+ * FIXME! and what did you want to do with phys_addr?
+ */
+#endif
                         iounmap(base);
                         printk(KERN_WARNING "PCI: %s: msi_remove_pci_irq_vectors() "
                                "called without free_irq() on all MSI-X vectors\n",
@@ -1123,6 +1157,11 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
         }
 }
 
+void pci_no_msi(void)
+{
+        pci_msi_enable = 0;
+}
+
 EXPORT_SYMBOL(pci_enable_msi);
 EXPORT_SYMBOL(pci_disable_msi);
 EXPORT_SYMBOL(pci_enable_msix);
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 0aa14c92b570..f22f69ac6445 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -53,11 +53,10 @@ store_new_id(struct device_driver *driver, const char *buf, size_t count)
         if (fields < 0)
                 return -EINVAL;
 
-        dynid = kmalloc(sizeof(*dynid), GFP_KERNEL);
+        dynid = kzalloc(sizeof(*dynid), GFP_KERNEL);
         if (!dynid)
                 return -ENOMEM;
 
-        memset(dynid, 0, sizeof(*dynid));
         INIT_LIST_HEAD(&dynid->node);
         dynid->id.vendor = vendor;
         dynid->id.device = device;
@@ -380,14 +379,6 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner)
         /* initialize common driver fields */
         drv->driver.name = drv->name;
         drv->driver.bus = &pci_bus_type;
-        /* FIXME, once all of the existing PCI drivers have been fixed to set
-         * the pci shutdown function, this test can go away. */
-        if (!drv->driver.shutdown)
-                drv->driver.shutdown = pci_device_shutdown;
-        else
-                printk(KERN_WARNING "Warning: PCI driver %s has a struct "
-                        "device_driver shutdown method, please update!\n",
-                        drv->name);
         drv->driver.owner = owner;
         drv->driver.kobj.ktype = &pci_driver_kobj_type;
 
@@ -514,6 +505,7 @@ struct bus_type pci_bus_type = {
         .probe          = pci_device_probe,
         .remove         = pci_device_remove,
         .suspend        = pci_device_suspend,
+        .shutdown       = pci_device_shutdown,
         .resume         = pci_device_resume,
         .dev_attrs      = pci_dev_attrs,
 };
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 965a5934623a..56ac2bc003c7 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -501,9 +501,8 @@ int pci_create_sysfs_dev_files (struct pci_dev *pdev)
         if (pci_resource_len(pdev, PCI_ROM_RESOURCE)) {
                 struct bin_attribute *rom_attr;
                 
-                rom_attr = kmalloc(sizeof(*rom_attr), GFP_ATOMIC);
+                rom_attr = kzalloc(sizeof(*rom_attr), GFP_ATOMIC);
                 if (rom_attr) {
-                        memset(rom_attr, 0x00, sizeof(*rom_attr));
                         pdev->rom_attr = rom_attr;
                         rom_attr->size = pci_resource_len(pdev, PCI_ROM_RESOURCE);
                         rom_attr->attr.name = "rom";
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index d2d187916643..bea1ad1ad5ba 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -19,7 +19,6 @@
 #include <asm/dma.h>    /* isa_dma_bridge_buggy */
 #include "pci.h"
 
-#if 0
 
 /**
  * pci_bus_max_busnr - returns maximum PCI bus number of given bus' children
@@ -34,7 +33,7 @@ pci_bus_max_busnr(struct pci_bus* bus)
         struct list_head *tmp;
         unsigned char max, n;
 
-        max = bus->number;
+        max = bus->subordinate;
         list_for_each(tmp, &bus->children) {
                 n = pci_bus_max_busnr(pci_bus_b(tmp));
                 if(n > max)
@@ -42,7 +41,9 @@ pci_bus_max_busnr(struct pci_bus* bus)
         }
         return max;
 }
+EXPORT_SYMBOL_GPL(pci_bus_max_busnr);
 
+#if 0
 /**
  * pci_max_busnr - returns maximum PCI bus number
  *
@@ -495,9 +496,8 @@ pci_enable_device_bars(struct pci_dev *dev, int bars)
 int
 pci_enable_device(struct pci_dev *dev)
 {
-        int err;
-
-        if ((err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1)))
+        int err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
+        if (err)
                 return err;
         pci_fixup_device(pci_fixup_enable, dev);
         dev->is_enabled = 1;
@@ -639,7 +639,7 @@ void pci_release_region(struct pci_dev *pdev, int bar)
  *      Returns 0 on success, or %EBUSY on error.  A warning
  *      message is also printed on failure.
  */
-int pci_request_region(struct pci_dev *pdev, int bar, char *res_name)
+int pci_request_region(struct pci_dev *pdev, int bar, const char *res_name)
 {
         if (pci_resource_len(pdev, bar) == 0)
                 return 0;
@@ -697,7 +697,7 @@ void pci_release_regions(struct pci_dev *pdev)
  *      Returns 0 on success, or %EBUSY on error.  A warning
  *      message is also printed on failure.
  */
-int pci_request_regions(struct pci_dev *pdev, char *res_name)
+int pci_request_regions(struct pci_dev *pdev, const char *res_name)
 {
         int i;
         
@@ -900,8 +900,12 @@ static int __devinit pci_setup(char *str)
                 if (k)
                         *k++ = 0;
                 if (*str && (str = pcibios_setup(str)) && *str) {
-                        /* PCI layer options should be handled here */
-                        printk(KERN_ERR "PCI: Unknown option `%s'\n", str);
+                        if (!strcmp(str, "nomsi")) {
+                                pci_no_msi();
+                        } else {
+                                printk(KERN_ERR "PCI: Unknown option `%s'\n",
+                                                str);
+                        }
                 }
                 str = k;
         }
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a6dfee2f6d2b..8f3fb47ea671 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -50,8 +50,10 @@ extern int pci_msi_quirk;
 
 #ifdef CONFIG_PCI_MSI
 void disable_msi_mode(struct pci_dev *dev, int pos, int type);
+void pci_no_msi(void);
 #else
 static inline void disable_msi_mode(struct pci_dev *dev, int pos, int type) { }
+static inline void pci_no_msi(void) { }
 #endif
 
 extern int pcie_mch_quirk;
diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
index a63bd8f72601..1d317d22ee89 100644
--- a/drivers/pci/pcie/portdrv.h
+++ b/drivers/pci/pcie/portdrv.h
@@ -29,7 +29,6 @@
 
 struct pcie_port_device_ext {
         int interrupt_mode;     /* [0:INTx | 1:MSI | 2:MSI-X] */
-        unsigned int saved_msi_config_space[5];
 };
 
 extern struct bus_type pcie_port_bus_type;
diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index e4e5f1e8d816..55c662267868 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -248,11 +248,10 @@ static struct pcie_device* alloc_pcie_device(struct pci_dev *parent,
 {
         struct pcie_device *device;
 
-        device = kmalloc(sizeof(struct pcie_device), GFP_KERNEL);
+        device = kzalloc(sizeof(struct pcie_device), GFP_KERNEL);
         if (!device)
                 return NULL;
 
-        memset(device, 0, sizeof(struct pcie_device));
         pcie_device_init(parent, device, port_type, service_type, irq,irq_mode);
         printk(KERN_DEBUG "Allocate Port Service[%s]\n", device->device.bus_id);
         return device;
diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 02260141dc81..50bfc1b2f3bf 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -30,75 +30,16 @@ MODULE_LICENSE("GPL");
 /* global data */
 static const char device_name[] = "pcieport-driver";
 
-static void pci_save_msi_state(struct pci_dev *dev)
+static int pcie_portdrv_save_config(struct pci_dev *dev)
 {
-        struct pcie_port_device_ext *p_ext = pci_get_drvdata(dev);
-        int i = 0, pos;
-        u16 control;
-
-        if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSI)) <= 0)
-                return;
-
-        pci_read_config_dword(dev, pos, &p_ext->saved_msi_config_space[i++]);
-        control = p_ext->saved_msi_config_space[0] >> 16;
-        pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
-                &p_ext->saved_msi_config_space[i++]);
-        if (control & PCI_MSI_FLAGS_64BIT) {
-                pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
-                        &p_ext->saved_msi_config_space[i++]);
-                pci_read_config_dword(dev, pos + PCI_MSI_DATA_64,
-                        &p_ext->saved_msi_config_space[i++]);
-        } else
-                pci_read_config_dword(dev, pos + PCI_MSI_DATA_32,
-                        &p_ext->saved_msi_config_space[i++]);
-        if (control & PCI_MSI_FLAGS_MASKBIT)
-                pci_read_config_dword(dev, pos + PCI_MSI_MASK_BIT,
-                        &p_ext->saved_msi_config_space[i++]);
-}
-
-static void pci_restore_msi_state(struct pci_dev *dev)
-{
-        struct pcie_port_device_ext *p_ext = pci_get_drvdata(dev);
-        int i = 0, pos;
-        u16 control;
-
-        if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSI)) <= 0)
-                return;
-
-        control = p_ext->saved_msi_config_space[i++] >> 16;
-        pci_write_config_word(dev, pos + PCI_MSI_FLAGS, control);
-        pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
-                p_ext->saved_msi_config_space[i++]);
-        if (control & PCI_MSI_FLAGS_64BIT) {
-                pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
-                        p_ext->saved_msi_config_space[i++]);
-                pci_write_config_dword(dev, pos + PCI_MSI_DATA_64,
-                        p_ext->saved_msi_config_space[i++]);
-        } else
-                pci_write_config_dword(dev, pos + PCI_MSI_DATA_32,
-                        p_ext->saved_msi_config_space[i++]);
-        if (control & PCI_MSI_FLAGS_MASKBIT)
-                pci_write_config_dword(dev, pos + PCI_MSI_MASK_BIT,
-                        p_ext->saved_msi_config_space[i++]);
-}
-
-static void pcie_portdrv_save_config(struct pci_dev *dev)
-{
-        struct pcie_port_device_ext *p_ext = pci_get_drvdata(dev);
-
-        pci_save_state(dev);
-        if (p_ext->interrupt_mode == PCIE_PORT_MSI_MODE)
-                pci_save_msi_state(dev);
+        return pci_save_state(dev);
 }
 
 static int pcie_portdrv_restore_config(struct pci_dev *dev)
 {
-        struct pcie_port_device_ext *p_ext = pci_get_drvdata(dev);
         int retval;
 
         pci_restore_state(dev);
-        if (p_ext->interrupt_mode == PCIE_PORT_MSI_MODE)
-                pci_restore_msi_state(dev);
         retval = pci_enable_device(dev);
         if (retval)
                 return retval;
@@ -149,7 +90,8 @@ static int pcie_portdrv_suspend (struct pci_dev *dev, pm_message_t state)
 {
         int ret = pcie_port_device_suspend(dev, state);
 
-        pcie_portdrv_save_config(dev);
+        if (!ret)
+                ret = pcie_portdrv_save_config(dev);
         return ret;
 }
 
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index adfad4fd6a13..a10ed9dab2c2 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -33,10 +33,9 @@ LIST_HEAD(pci_devices);
  */
 static void pci_create_legacy_files(struct pci_bus *b)
 {
-        b->legacy_io = kmalloc(sizeof(struct bin_attribute) * 2,
+        b->legacy_io = kzalloc(sizeof(struct bin_attribute) * 2,
                                GFP_ATOMIC);
         if (b->legacy_io) {
-                memset(b->legacy_io, 0, sizeof(struct bin_attribute) * 2);
                 b->legacy_io->attr.name = "legacy_io";
                 b->legacy_io->size = 0xffff;
                 b->legacy_io->attr.mode = S_IRUSR | S_IWUSR;
@@ -320,9 +319,8 @@ static struct pci_bus * __devinit pci_alloc_bus(void)
 {
         struct pci_bus *b;
 
-        b = kmalloc(sizeof(*b), GFP_KERNEL);
+        b = kzalloc(sizeof(*b), GFP_KERNEL);
         if (b) {
-                memset(b, 0, sizeof(*b));
                 INIT_LIST_HEAD(&b->node);
                 INIT_LIST_HEAD(&b->children);
                 INIT_LIST_HEAD(&b->devices);
@@ -347,6 +345,7 @@ pci_alloc_child_bus(struct pci_bus *parent, struct pci_dev *bridge, int busnr)
         child->parent = parent;
         child->ops = parent->ops;
         child->sysdata = parent->sysdata;
+        child->bus_flags = parent->bus_flags;
         child->bridge = get_device(&bridge->dev);
 
         child->class_dev.class = &pcibus_class;
@@ -456,7 +455,7 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                  * pass and just note the configuration.
                  */
                 if (pass)
-                        return max;
+                        goto out;
                 busnr = (buses >> 8) & 0xFF;
 
                 /*
@@ -466,12 +465,12 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                 if (pci_find_bus(pci_domain_nr(bus), busnr)) {
                         printk(KERN_INFO "PCI: Bus %04x:%02x already known\n",
                                         pci_domain_nr(bus), busnr);
-                        return max;
+                        goto out;
                 }
 
                 child = pci_add_new_bus(bus, dev, busnr);
                 if (!child)
-                        return max;
+                        goto out;
                 child->primary = buses & 0xFF;
                 child->subordinate = (buses >> 16) & 0xFF;
                 child->bridge_ctl = bctl;
@@ -496,7 +495,7 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                                    bus ranges. */
                                 pci_write_config_dword(dev, PCI_PRIMARY_BUS,
                                                        buses & ~0xffffff);
-                        return max;
+                        goto out;
                 }
 
                 /* Clear errors */
@@ -505,7 +504,7 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                 /* Prevent assigning a bus number that already exists.
                  * This can happen when a bridge is hot-plugged */
                 if (pci_find_bus(pci_domain_nr(bus), max+1))
-                        return max;
+                        goto out;
                 child = pci_add_new_bus(bus, dev, ++max);
                 buses = (buses & 0xff000000)
                       | ((unsigned int)(child->primary)     <<  0)
@@ -537,6 +536,11 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                         pci_fixup_parent_subordinate_busnr(child, max);
                         /* Now we can scan all subordinate buses... */
                         max = pci_scan_child_bus(child);
+                        /*
+                         * now fix it up again since we have found
+                         * the real value of max.
+                         */
+                        pci_fixup_parent_subordinate_busnr(child, max);
                 } else {
                         /*
                          * For CardBus bridges, we leave 4 bus numbers
@@ -576,8 +580,6 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                 pci_write_config_byte(dev, PCI_SUBORDINATE_BUS, max);
         }
 
-        pci_write_config_word(dev, PCI_BRIDGE_CONTROL, bctl);
-
         sprintf(child->name, (is_cardbus ? "PCI CardBus #%02x" : "PCI Bus #%02x"), child->number);
 
         while (bus->parent) {
@@ -585,17 +587,22 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max
                     (child->number > bus->subordinate) ||
                     (child->number < bus->number) ||
                     (child->subordinate < bus->number)) {
-                        printk(KERN_WARNING "PCI: Bus #%02x (-#%02x) may be "
+                        printk(KERN_WARNING "PCI: Bus #%02x (-#%02x) is "
                                "hidden behind%s bridge #%02x (-#%02x)%s\n",
                                child->number, child->subordinate,
                                bus->self->transparent ? " transparent" : " ",
                                bus->number, bus->subordinate,
                                pcibios_assign_all_busses() ? " " :
                                " (try 'pci=assign-busses')");
+                        printk(KERN_WARNING "Please report the result to "
+                               "linux-kernel to fix this permanently\n");
                 }
                 bus = bus->parent;
         }
 
+out:
+        pci_write_config_word(dev, PCI_BRIDGE_CONTROL, bctl);
+
         return max;
 }
 
@@ -788,11 +795,10 @@ pci_scan_device(struct pci_bus *bus, int devfn)
         if (pci_bus_read_config_byte(bus, devfn, PCI_HEADER_TYPE, &hdr_type))
                 return NULL;
 
-        dev = kmalloc(sizeof(struct pci_dev), GFP_KERNEL);
+        dev = kzalloc(sizeof(struct pci_dev), GFP_KERNEL);
         if (!dev)
                 return NULL;
 
-        memset(dev, 0, sizeof(struct pci_dev));
         dev->bus = bus;
         dev->sysdata = bus->sysdata;
         dev->dev.parent = bus->bridge;
diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
index 92a885760832..54b2ebc9c91a 100644
--- a/drivers/pci/proc.c
+++ b/drivers/pci/proc.c
@@ -458,131 +458,6 @@ int pci_proc_detach_bus(struct pci_bus* bus)
         return 0;
 }
 
-#ifdef CONFIG_PCI_LEGACY_PROC
-
-/*
- *  Backward compatible /proc/pci interface.
- */
-
-/*
- * Convert some of the configuration space registers of the device at
- * address (bus,devfn) into a string (possibly several lines each).
- * The configuration string is stored starting at buf[len].  If the
- * string would exceed the size of the buffer (SIZE), 0 is returned.
- */
-static int show_dev_config(struct seq_file *m, void *v)
-{
-        struct pci_dev *dev = v;
-        struct pci_dev *first_dev;
-        struct pci_driver *drv;
-        u32 class_rev;
-        unsigned char latency, min_gnt, max_lat;
-        int reg;
-
-        first_dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
-        if (dev == first_dev)
-                seq_puts(m, "PCI devices found:\n");
-        pci_dev_put(first_dev);
-
-        drv = pci_dev_driver(dev);
-
-        pci_user_read_config_dword(dev, PCI_CLASS_REVISION, &class_rev);
-        pci_user_read_config_byte (dev, PCI_LATENCY_TIMER, &latency);
-        pci_user_read_config_byte (dev, PCI_MIN_GNT, &min_gnt);
-        pci_user_read_config_byte (dev, PCI_MAX_LAT, &max_lat);
-        seq_printf(m, "  Bus %2d, device %3d, function %2d:\n",
-               dev->bus->number, PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn));
-        seq_printf(m, "    Class %04x", class_rev >> 16);
-        seq_printf(m, ": PCI device %04x:%04x", dev->vendor, dev->device);
-        seq_printf(m, " (rev %d).\n", class_rev & 0xff);
-
-        if (dev->irq)
-                seq_printf(m, "      IRQ %d.\n", dev->irq);
-
-        if (latency || min_gnt || max_lat) {
-                seq_printf(m, "      Master Capable.  ");
-                if (latency)
-                        seq_printf(m, "Latency=%d.  ", latency);
-                else
-                        seq_puts(m, "No bursts.  ");
-                if (min_gnt)
-                        seq_printf(m, "Min Gnt=%d.", min_gnt);
-                if (max_lat)
-                        seq_printf(m, "Max Lat=%d.", max_lat);
-                seq_putc(m, '\n');
-        }
-
-        for (reg = 0; reg < 6; reg++) {
-                struct resource *res = dev->resource + reg;
-                unsigned long base, end, flags;
-
-                base = res->start;
-                end = res->end;
-                flags = res->flags;
-                if (!end)
-                        continue;
-
-                if (flags & PCI_BASE_ADDRESS_SPACE_IO) {
-                        seq_printf(m, "      I/O at 0x%lx [0x%lx].\n",
-                                base, end);
-                } else {
-                        const char *pref, *type = "unknown";
-
-                        if (flags & PCI_BASE_ADDRESS_MEM_PREFETCH)
-                                pref = "P";
-                        else
-                                pref = "Non-p";
-                        switch (flags & PCI_BASE_ADDRESS_MEM_TYPE_MASK) {
-                              case PCI_BASE_ADDRESS_MEM_TYPE_32:
-                                type = "32 bit"; break;
-                              case PCI_BASE_ADDRESS_MEM_TYPE_1M:
-                                type = "20 bit"; break;
-                              case PCI_BASE_ADDRESS_MEM_TYPE_64:
-                                type = "64 bit"; break;
-                        }
-                        seq_printf(m, "      %srefetchable %s memory at "
-                                       "0x%lx [0x%lx].\n", pref, type,
-                                       base,
-                                       end);
-                }
-        }
-        return 0;
-}
-
-static struct seq_operations proc_pci_op = {
-        .start  = pci_seq_start,
-        .next   = pci_seq_next,
-        .stop   = pci_seq_stop,
-        .show   = show_dev_config
-};
-
-static int proc_pci_open(struct inode *inode, struct file *file)
-{
-        return seq_open(file, &proc_pci_op);
-}
-static struct file_operations proc_pci_operations = {
-        .open           = proc_pci_open,
-        .read           = seq_read,
-        .llseek         = seq_lseek,
-        .release        = seq_release,
-};
-
-static void legacy_proc_init(void)
-{
-        struct proc_dir_entry * entry = create_proc_entry("pci", 0, NULL);
-        if (entry)
-                entry->proc_fops = &proc_pci_operations;
-}
-
-#else
-
-static void legacy_proc_init(void)
-{
-
-}
-
-#endif /* CONFIG_PCI_LEGACY_PROC */
-
 static int proc_bus_pci_dev_open(struct inode *inode, struct file *file)
 {
         return seq_open(file, &proc_bus_pci_devices_op);
@@ -606,7 +481,6 @@ static int __init pci_proc_init(void)
         while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
                 pci_proc_attach_device(dev);
         }
-        legacy_proc_init();
         return 0;
 }
 
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index dda6099903c1..4970f47be72c 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -575,8 +575,11 @@ static void __init quirk_amd_8131_ioapic(struct pci_dev *dev)
 { 
         unsigned char revid, tmp;
         
-        pci_msi_quirk = 1;
-        printk(KERN_WARNING "PCI: MSI quirk detected. pci_msi_quirk set.\n");
+        if (dev->subordinate) {
+                printk(KERN_WARNING "PCI: MSI quirk detected. "
+                       "PCI_BUS_FLAGS_NO_MSI set for subordinate bus.\n");
+                dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI;
+        }
 
         if (nr_ioapics == 0) 
                 return;
@@ -934,6 +937,12 @@ static void __init asus_hides_smbus_hostbridge(struct pci_dev *dev)
                         case 0x12bd: /* HP D530 */
                                 asus_hides_smbus = 1;
                         }
+                if (dev->device == PCI_DEVICE_ID_INTEL_82915GM_HB) {
+                        switch (dev->subsystem_device) {
+                        case 0x099c: /* HP Compaq nx6110 */
+                                asus_hides_smbus = 1;
+                        }
+                }
         } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_TOSHIBA)) {
                 if (dev->device == PCI_DEVICE_ID_INTEL_82855GM_HB)
                         switch(dev->subsystem_device) {
@@ -1068,6 +1077,37 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,	PCI_DEVICE_ID_SI_651,		quirk_sis_96x_
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,      PCI_DEVICE_ID_SI_735,           quirk_sis_96x_compatible );
 
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,      PCI_DEVICE_ID_SI_503,           quirk_sis_503 );
+/*
+ * On ASUS A8V and A8V Deluxe boards, the onboard AC97 audio controller
+ * and MC97 modem controller are disabled when a second PCI soundcard is
+ * present. This patch, tweaking the VT8237 ISA bridge, enables them.
+ * -- bjd
+ */
+static void __init asus_hides_ac97_lpc(struct pci_dev *dev)
+{
+        u8 val;
+        int asus_hides_ac97 = 0;
+
+        if (likely(dev->subsystem_vendor == PCI_VENDOR_ID_ASUSTEK)) {
+                if (dev->device == PCI_DEVICE_ID_VIA_8237)
+                        asus_hides_ac97 = 1;
+        }
+
+        if (!asus_hides_ac97)
+                return;
+
+        pci_read_config_byte(dev, 0x50, &val);
+        if (val & 0xc0) {
+                pci_write_config_byte(dev, 0x50, val & (~0xc0));
+                pci_read_config_byte(dev, 0x50, &val);
+                if (val & 0xc0)
+                        printk(KERN_INFO "PCI: onboard AC97/MC97 devices continue to play 'hide and seek'! 0x%x\n", val);
+                else
+                        printk(KERN_INFO "PCI: enabled onboard AC97/MC97 devices\n");
+        }
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_VIA,     PCI_DEVICE_ID_VIA_8237, asus_hides_ac97_lpc );
+
 
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,      PCI_DEVICE_ID_SI_961,           quirk_sis_96x_smbus );
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI,      PCI_DEVICE_ID_SI_962,           quirk_sis_96x_smbus );
@@ -1242,6 +1282,33 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXH_1,	quirk_pc
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,    PCI_DEVICE_ID_INTEL_PXHV,       quirk_pcie_pxh);
 
 
+/*
+ * Fixup the cardbus bridges on the IBM Dock II docking station
+ */
+static void __devinit quirk_ibm_dock2_cardbus(struct pci_dev *dev)
+{
+        u32 val;
+
+        /*
+         * tie the 2 interrupt pins to INTA, and configure the
+         * multifunction routing register to handle this.
+         */
+        if ((dev->subsystem_vendor == PCI_VENDOR_ID_IBM) &&
+                (dev->subsystem_device == 0x0148)) {
+                printk(KERN_INFO "PCI: Found IBM Dock II Cardbus Bridge "
+                        "applying quirk\n");
+                pci_read_config_dword(dev, 0x8c, &val);
+                val = ((val & 0xffffff00) | 0x1002);
+                pci_write_config_dword(dev, 0x8c, val);
+                pci_read_config_dword(dev, 0x80, &val);
+                val = ((val & 0x00ffff00) | 0x2864c077);
+                pci_write_config_dword(dev, 0x80, val);
+        }
+}
+
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_1420,
+                                quirk_ibm_dock2_cardbus);
+
 static void __devinit quirk_netmos(struct pci_dev *dev)
 {
         unsigned int num_parallel = (dev->subsystem_device & 0xf0) >> 4;
diff --git a/drivers/pci/search.c b/drivers/pci/search.c
index 05fa91a31c62..ce7dd6e7be60 100644
--- a/drivers/pci/search.c
+++ b/drivers/pci/search.c
@@ -246,9 +246,9 @@ pci_get_subsys(unsigned int vendor, unsigned int device,
         }
         dev = NULL;
 exit:
-        pci_dev_put(from);
         dev = pci_dev_get(dev);
         spin_unlock(&pci_bus_lock);
+        pci_dev_put(from);
         return dev;
 }
 
@@ -339,9 +339,9 @@ struct pci_dev *pci_get_class(unsigned int class, struct pci_dev *from)
         }
         dev = NULL;
 exit:
-        pci_dev_put(from);
         dev = pci_dev_get(dev);
         spin_unlock(&pci_bus_lock);
+        pci_dev_put(from);
         return dev;
 }
 
diff --git a/drivers/pnp/pnpbios/rsparser.c b/drivers/pnp/pnpbios/rsparser.c
index 5e38cd7335f7..c89c98a2cca8 100644
--- a/drivers/pnp/pnpbios/rsparser.c
+++ b/drivers/pnp/pnpbios/rsparser.c
@@ -448,11 +448,7 @@ pnpbios_parse_resource_option_data(unsigned char * p, unsigned char * end, struc
                         break;
 
                 case SMALL_TAG_END:
-                        if (option_independent != option)
-                                printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
-                        p = p + 2;
-                        return (unsigned char *)p;
-                        break;
+                        return p + 2;
 
                 default: /* an unkown tag */
                         len_err:
diff --git a/drivers/s390/block/dasd_ioctl.c b/drivers/s390/block/dasd_ioctl.c
index fafeeae52675..f9930552ab54 100644
--- a/drivers/s390/block/dasd_ioctl.c
+++ b/drivers/s390/block/dasd_ioctl.c
@@ -151,9 +151,9 @@ dasd_ioctl_enable(struct block_device *bdev, int no, long args)
                 return -ENODEV;
         dasd_enable_device(device);
         /* Formatting the dasd device can change the capacity. */
-        down(&bdev->bd_sem);
+        mutex_lock(&bdev->bd_mutex);
         i_size_write(bdev->bd_inode, (loff_t)get_capacity(device->gdp) << 9);
-        up(&bdev->bd_sem);
+        mutex_unlock(&bdev->bd_mutex);
         return 0;
 }
 
@@ -184,9 +184,9 @@ dasd_ioctl_disable(struct block_device *bdev, int no, long args)
          * Set i_size to zero, since read, write, etc. check against this
          * value.
          */
-        down(&bdev->bd_sem);
+        mutex_lock(&bdev->bd_mutex);
         i_size_write(bdev->bd_inode, 0);
-        up(&bdev->bd_sem);
+        mutex_unlock(&bdev->bd_mutex);
         return 0;
 }
 
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index 0cf0e4c7ac0c..39b760a24241 100644
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -47,6 +47,7 @@
 #include <linux/ide.h>
 #include <linux/scatterlist.h>
 #include <linux/delay.h>
+#include <linux/mutex.h>
 
 #include <asm/io.h>
 #include <asm/bitops.h>
@@ -109,7 +110,7 @@ typedef struct ide_scsi_obj {
         unsigned long log;                      /* log flags */
 } idescsi_scsi_t;
 
-static DECLARE_MUTEX(idescsi_ref_sem);
+static DEFINE_MUTEX(idescsi_ref_mutex);
 
 #define ide_scsi_g(disk) \
         container_of((disk)->private_data, struct ide_scsi_obj, driver)
@@ -118,19 +119,19 @@ static struct ide_scsi_obj *ide_scsi_get(struct gendisk *disk)
 {
         struct ide_scsi_obj *scsi = NULL;
 
-        down(&idescsi_ref_sem);
+        mutex_lock(&idescsi_ref_mutex);
         scsi = ide_scsi_g(disk);
         if (scsi)
                 scsi_host_get(scsi->host);
-        up(&idescsi_ref_sem);
+        mutex_unlock(&idescsi_ref_mutex);
         return scsi;
 }
 
 static void ide_scsi_put(struct ide_scsi_obj *scsi)
 {
-        down(&idescsi_ref_sem);
+        mutex_lock(&idescsi_ref_mutex);
         scsi_host_put(scsi->host);
-        up(&idescsi_ref_sem);
+        mutex_unlock(&idescsi_ref_mutex);
 }
 
 static inline idescsi_scsi_t *scsihost_to_idescsi(struct Scsi_Host *host)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index f9c1192dc15e..7c80711e18ed 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -71,7 +71,7 @@ MODULE_ALIAS_BLOCKDEV_MAJOR(SCSI_CDROM_MAJOR);
 #define SR_CAPABILITIES \
         (CDC_CLOSE_TRAY|CDC_OPEN_TRAY|CDC_LOCK|CDC_SELECT_SPEED| \
          CDC_SELECT_DISC|CDC_MULTI_SESSION|CDC_MCN|CDC_MEDIA_CHANGED| \
-         CDC_PLAY_AUDIO|CDC_RESET|CDC_IOCTLS|CDC_DRIVE_STATUS| \
+         CDC_PLAY_AUDIO|CDC_RESET|CDC_DRIVE_STATUS| \
          CDC_CD_R|CDC_CD_RW|CDC_DVD|CDC_DVD_R|CDC_DVD_RAM|CDC_GENERIC_PACKET| \
          CDC_MRW|CDC_MRW_W|CDC_RAM)
 
@@ -118,7 +118,6 @@ static struct cdrom_device_ops sr_dops = {
         .get_mcn                = sr_get_mcn,
         .reset                  = sr_reset,
         .audio_ioctl            = sr_audio_ioctl,
-        .dev_ioctl              = sr_dev_ioctl,
         .capability             = SR_CAPABILITIES,
         .generic_packet         = sr_packet,
 };
@@ -456,17 +455,33 @@ static int sr_block_ioctl(struct inode *inode, struct file *file, unsigned cmd,
 {
         struct scsi_cd *cd = scsi_cd(inode->i_bdev->bd_disk);
         struct scsi_device *sdev = cd->device;
+        void __user *argp = (void __user *)arg;
+        int ret;
 
-        /*
-         * Send SCSI addressing ioctls directly to mid level, send other
-         * ioctls to cdrom/block level.
-         */
-        switch (cmd) {
-                case SCSI_IOCTL_GET_IDLUN:
-                case SCSI_IOCTL_GET_BUS_NUMBER:
-                        return scsi_ioctl(sdev, cmd, (void __user *)arg);
+        /*
+         * Send SCSI addressing ioctls directly to mid level, send other
+         * ioctls to cdrom/block level.
+         */
+        switch (cmd) {
+        case SCSI_IOCTL_GET_IDLUN:
+        case SCSI_IOCTL_GET_BUS_NUMBER:
+                return scsi_ioctl(sdev, cmd, argp);
         }
-        return cdrom_ioctl(file, &cd->cdi, inode, cmd, arg);
+
+        ret = cdrom_ioctl(file, &cd->cdi, inode, cmd, arg);
+        if (ret != ENOSYS)
+                return ret;
+
+        /*
+         * ENODEV means that we didn't recognise the ioctl, or that we
+         * cannot execute it in the current device state.  In either
+         * case fall through to scsi_ioctl, which will return ENDOEV again
+         * if it doesn't recognise the ioctl
+         */
+        ret = scsi_nonblockable_ioctl(sdev, cmd, argp, NULL);
+        if (ret != -ENODEV)
+                return ret;
+        return scsi_ioctl(sdev, cmd, argp);
 }
 
 static int sr_block_media_changed(struct gendisk *disk)
diff --git a/drivers/scsi/sr.h b/drivers/scsi/sr.h
index d2bcd99c272f..d65de9621b27 100644
--- a/drivers/scsi/sr.h
+++ b/drivers/scsi/sr.h
@@ -55,7 +55,6 @@ int sr_get_mcn(struct cdrom_device_info *, struct cdrom_mcn *);
 int sr_reset(struct cdrom_device_info *);
 int sr_select_speed(struct cdrom_device_info *cdi, int speed);
 int sr_audio_ioctl(struct cdrom_device_info *, unsigned int, void *);
-int sr_dev_ioctl(struct cdrom_device_info *, unsigned int, unsigned long);
 
 int sr_is_xa(Scsi_CD *);
 
diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
index b65462f76484..d1268cb46837 100644
--- a/drivers/scsi/sr_ioctl.c
+++ b/drivers/scsi/sr_ioctl.c
@@ -562,22 +562,3 @@ int sr_is_xa(Scsi_CD *cd)
 #endif
         return is_xa;
 }
-
-int sr_dev_ioctl(struct cdrom_device_info *cdi,
-                 unsigned int cmd, unsigned long arg)
-{
-        Scsi_CD *cd = cdi->handle;
-        int ret;
-        
-        ret = scsi_nonblockable_ioctl(cd->device, cmd,
-                                      (void __user *)arg, NULL);
-        /*
-         * ENODEV means that we didn't recognise the ioctl, or that we
-         * cannot execute it in the current device state.  In either
-         * case fall through to scsi_ioctl, which will return ENDOEV again
-         * if it doesn't recognise the ioctl
-         */
-        if (ret != -ENODEV)
-                return ret;
-        return scsi_ioctl(cd->device, cmd, (void __user *)arg);
-}
diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index 7f0f35a05dca..b88a7c1158af 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -101,8 +101,6 @@ struct tty_driver *serial_driver;
 
 #define RS_ISR_PASS_LIMIT 256
 
-#define _INLINE_ inline
-
 static void change_speed(struct m68k_serial *info);
 
 /*
@@ -262,7 +260,7 @@ static void batten_down_hatches(void)
         /* Drop into the debugger */
 }
 
-static _INLINE_ void status_handle(struct m68k_serial *info, unsigned short status)
+static void status_handle(struct m68k_serial *info, unsigned short status)
 {
 #if 0
         if(status & DCD) {
@@ -289,7 +287,8 @@ static _INLINE_ void status_handle(struct m68k_serial *info, unsigned short stat
         return;
 }
 
-static _INLINE_ void receive_chars(struct m68k_serial *info, struct pt_regs *regs, unsigned short rx)
+static void receive_chars(struct m68k_serial *info, struct pt_regs *regs,
+                          unsigned short rx)
 {
         struct tty_struct *tty = info->tty;
         m68328_uart *uart = &uart_addr[info->line];
@@ -359,7 +358,7 @@ clear_and_exit:
         return;
 }
 
-static _INLINE_ void transmit_chars(struct m68k_serial *info)
+static void transmit_chars(struct m68k_serial *info)
 {
         m68328_uart *uart = &uart_addr[info->line];
 
diff --git a/drivers/serial/au1x00_uart.c b/drivers/serial/au1x00_uart.c
index 29f94bbb79be..948880ac5878 100644
--- a/drivers/serial/au1x00_uart.c
+++ b/drivers/serial/au1x00_uart.c
@@ -133,13 +133,12 @@ static const struct serial_uart_config uart_config[PORT_MAX_8250+1] = {
         { "AU1X00_UART",16,     UART_CLEAR_FIFO | UART_USE_FIFO },
 };
 
-static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset)
+static unsigned int serial_in(struct uart_8250_port *up, int offset)
 {
         return au_readl((unsigned long)up->port.membase + offset);
 }
 
-static _INLINE_ void
-serial_out(struct uart_8250_port *up, int offset, int value)
+static void serial_out(struct uart_8250_port *up, int offset, int value)
 {
         au_writel(value, (unsigned long)up->port.membase + offset);
 }
@@ -237,7 +236,7 @@ static void serial8250_enable_ms(struct uart_port *port)
         serial_out(up, UART_IER, up->ier);
 }
 
-static _INLINE_ void
+static void
 receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
 {
         struct tty_struct *tty = up->port.info->tty;
@@ -312,7 +311,7 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
         spin_lock(&up->port.lock);
 }
 
-static _INLINE_ void transmit_chars(struct uart_8250_port *up)
+static void transmit_chars(struct uart_8250_port *up)
 {
         struct circ_buf *xmit = &up->port.info->xmit;
         int count;
@@ -346,7 +345,7 @@ static _INLINE_ void transmit_chars(struct uart_8250_port *up)
                 serial8250_stop_tx(&up->port);
 }
 
-static _INLINE_ void check_modem_status(struct uart_8250_port *up)
+static void check_modem_status(struct uart_8250_port *up)
 {
         int status;
 
diff --git a/drivers/serial/crisv10.c b/drivers/serial/crisv10.c
index be12623d8544..89700141f87e 100644
--- a/drivers/serial/crisv10.c
+++ b/drivers/serial/crisv10.c
@@ -481,8 +481,6 @@ static char *serial_version = "$Revision: 1.25 $";
 #include "serial_compat.h"
 #endif
 
-#define _INLINE_ inline
-
 struct tty_driver *serial_driver;
 
 /* serial subtype definitions */
@@ -591,8 +589,6 @@ static void rs_throttle(struct tty_struct * tty);
 static void rs_wait_until_sent(struct tty_struct *tty, int timeout);
 static int rs_write(struct tty_struct * tty, int from_user,
                     const unsigned char *buf, int count);
-extern _INLINE_ int rs_raw_write(struct tty_struct * tty, int from_user,
-                            const unsigned char *buf, int count);
 #ifdef CONFIG_ETRAX_RS485
 static int e100_write_rs485(struct tty_struct * tty, int from_user,
                             const unsigned char *buf, int count);
@@ -1538,8 +1534,7 @@ e100_enable_rxdma_irq(struct e100_serial *info)
 
 /* the tx DMA uses only dma_descr interrupt */
 
-static _INLINE_ void
-e100_disable_txdma_irq(struct e100_serial *info)
+static void e100_disable_txdma_irq(struct e100_serial *info)
 {
 #ifdef SERIAL_DEBUG_INTR
         printk("txdma_irq(%d): 0\n",info->line);
@@ -1548,8 +1543,7 @@ e100_disable_txdma_irq(struct e100_serial *info)
         *R_IRQ_MASK2_CLR = info->irq;
 }
 
-static _INLINE_ void
-e100_enable_txdma_irq(struct e100_serial *info)
+static void e100_enable_txdma_irq(struct e100_serial *info)
 {
 #ifdef SERIAL_DEBUG_INTR
         printk("txdma_irq(%d): 1\n",info->line);
@@ -1558,8 +1552,7 @@ e100_enable_txdma_irq(struct e100_serial *info)
         *R_IRQ_MASK2_SET = info->irq;
 }
 
-static _INLINE_ void
-e100_disable_txdma_channel(struct e100_serial *info)
+static void e100_disable_txdma_channel(struct e100_serial *info)
 {
         unsigned long flags;
 
@@ -1599,8 +1592,7 @@ e100_disable_txdma_channel(struct e100_serial *info)
 }
 
 
-static _INLINE_ void
-e100_enable_txdma_channel(struct e100_serial *info)
+static void e100_enable_txdma_channel(struct e100_serial *info)
 {
         unsigned long flags;
 
@@ -1625,8 +1617,7 @@ e100_enable_txdma_channel(struct e100_serial *info)
         restore_flags(flags);
 }
 
-static _INLINE_ void
-e100_disable_rxdma_channel(struct e100_serial *info)
+static void e100_disable_rxdma_channel(struct e100_serial *info)
 {
         unsigned long flags;
 
@@ -1665,8 +1656,7 @@ e100_disable_rxdma_channel(struct e100_serial *info)
 }
 
 
-static _INLINE_ void
-e100_enable_rxdma_channel(struct e100_serial *info)
+static void e100_enable_rxdma_channel(struct e100_serial *info)
 {
         unsigned long flags;
 
@@ -1913,9 +1903,7 @@ rs_start(struct tty_struct *tty)
  * This routine is used by the interrupt handler to schedule
  * processing in the software interrupt portion of the driver.
  */
-static _INLINE_ void
-rs_sched_event(struct e100_serial *info,
-                                    int event)
+static void rs_sched_event(struct e100_serial *info, int event)
 {
         if (info->event & (1 << event))
                 return;
@@ -2155,8 +2143,9 @@ add_char_and_flag(struct e100_serial *info, unsigned char data, unsigned char fl
         return 1;
 }
 
-extern _INLINE_ unsigned int
-handle_descr_data(struct e100_serial *info, struct etrax_dma_descr *descr, unsigned int recvl)
+static unsigned int handle_descr_data(struct e100_serial *info,
+                                      struct etrax_dma_descr *descr,
+                                      unsigned int recvl)
 {
         struct etrax_recv_buffer *buffer = phys_to_virt(descr->buf) - sizeof *buffer;
 
@@ -2182,8 +2171,7 @@ handle_descr_data(struct e100_serial *info, struct etrax_dma_descr *descr, unsig
         return recvl;
 }
 
-static _INLINE_ unsigned int
-handle_all_descr_data(struct e100_serial *info)
+static unsigned int handle_all_descr_data(struct e100_serial *info)
 {
         struct etrax_dma_descr *descr;
         unsigned int recvl;
@@ -2230,8 +2218,7 @@ handle_all_descr_data(struct e100_serial *info)
         return ret;
 }
 
-static _INLINE_ void
-receive_chars_dma(struct e100_serial *info)
+static void receive_chars_dma(struct e100_serial *info)
 {
         struct tty_struct *tty;
         unsigned char rstat;
@@ -2292,8 +2279,7 @@ receive_chars_dma(struct e100_serial *info)
         *info->icmdadr = IO_STATE(R_DMA_CH6_CMD, cmd, restart);
 }
 
-static _INLINE_ int
-start_recv_dma(struct e100_serial *info)
+static int start_recv_dma(struct e100_serial *info)
 {
         struct etrax_dma_descr *descr = info->rec_descr;
         struct etrax_recv_buffer *buffer;
@@ -2348,11 +2334,6 @@ start_receive(struct e100_serial *info)
 }
 
 
-static _INLINE_ void
-status_handle(struct e100_serial *info, unsigned short status)
-{
-}
-
 /* the bits in the MASK2 register are laid out like this:
    DMAI_EOP DMAI_DESCR DMAO_EOP DMAO_DESCR
    where I is the input channel and O is the output channel for the port.
@@ -2454,8 +2435,7 @@ rec_interrupt(int irq, void *dev_id, struct pt_regs * regs)
         return IRQ_RETVAL(handled);
 } /* rec_interrupt */
 
-static _INLINE_ int
-force_eop_if_needed(struct e100_serial *info)
+static int force_eop_if_needed(struct e100_serial *info)
 {
         /* We check data_avail bit to determine if data has
          * arrived since last time
@@ -2499,8 +2479,7 @@ force_eop_if_needed(struct e100_serial *info)
         return 1;
 }
 
-extern _INLINE_ void
-flush_to_flip_buffer(struct e100_serial *info)
+static void flush_to_flip_buffer(struct e100_serial *info)
 {
         struct tty_struct *tty;
         struct etrax_recv_buffer *buffer;
@@ -2611,8 +2590,7 @@ flush_to_flip_buffer(struct e100_serial *info)
         tty_flip_buffer_push(tty);
 }
 
-static _INLINE_ void
-check_flush_timeout(struct e100_serial *info)
+static void check_flush_timeout(struct e100_serial *info)
 {
         /* Flip what we've got (if we can) */
         flush_to_flip_buffer(info);
@@ -2741,7 +2719,7 @@ TODO: The break will be delayed until an F or V character is received.
 
 */
 
-extern _INLINE_
+static
 struct e100_serial * handle_ser_rx_interrupt_no_dma(struct e100_serial *info)
 {
         unsigned long data_read;
@@ -2875,8 +2853,7 @@ more_data:
         return info;
 }
 
-extern _INLINE_
-struct e100_serial* handle_ser_rx_interrupt(struct e100_serial *info)
+static struct e100_serial* handle_ser_rx_interrupt(struct e100_serial *info)
 {
         unsigned char rstat;
 
@@ -2995,7 +2972,7 @@ struct e100_serial* handle_ser_rx_interrupt(struct e100_serial *info)
         return info;
 } /* handle_ser_rx_interrupt */
 
-extern _INLINE_ void handle_ser_tx_interrupt(struct e100_serial *info)
+static void handle_ser_tx_interrupt(struct e100_serial *info)
 {
         unsigned long flags;
 
@@ -3621,9 +3598,8 @@ rs_flush_chars(struct tty_struct *tty)
         restore_flags(flags);
 }
 
-extern _INLINE_ int
-rs_raw_write(struct tty_struct * tty, int from_user,
-          const unsigned char *buf, int count)
+static int rs_raw_write(struct tty_struct * tty, int from_user,
+                        const unsigned char *buf, int count)
 {
         int     c, ret = 0;
         struct e100_serial *info = (struct e100_serial *)tty->driver_data;
@@ -4710,7 +4686,7 @@ rs_open(struct tty_struct *tty, struct file * filp)
  * /proc fs routines....
  */
 
-extern _INLINE_ int line_info(char *buf, struct e100_serial *info)
+static int line_info(char *buf, struct e100_serial *info)
 {
         char    stat_buf[30];
         int     ret;
diff --git a/drivers/serial/m32r_sio.c b/drivers/serial/m32r_sio.c
index 876bc5e027bb..e9c10c0a30fc 100644
--- a/drivers/serial/m32r_sio.c
+++ b/drivers/serial/m32r_sio.c
@@ -248,17 +248,17 @@ static void sio_error(int *status)
 
 #endif /* CONFIG_SERIAL_M32R_PLDSIO */
 
-static _INLINE_ unsigned int sio_in(struct uart_sio_port *up, int offset)
+static unsigned int sio_in(struct uart_sio_port *up, int offset)
 {
         return __sio_in(up->port.iobase + offset);
 }
 
-static _INLINE_ void sio_out(struct uart_sio_port *up, int offset, int value)
+static void sio_out(struct uart_sio_port *up, int offset, int value)
 {
         __sio_out(value, up->port.iobase + offset);
 }
 
-static _INLINE_ unsigned int serial_in(struct uart_sio_port *up, int offset)
+static unsigned int serial_in(struct uart_sio_port *up, int offset)
 {
         if (!offset)
                 return 0;
@@ -266,8 +266,7 @@ static _INLINE_ unsigned int serial_in(struct uart_sio_port *up, int offset)
         return __sio_in(offset);
 }
 
-static _INLINE_ void
-serial_out(struct uart_sio_port *up, int offset, int value)
+static void serial_out(struct uart_sio_port *up, int offset, int value)
 {
         if (!offset)
                 return;
@@ -326,8 +325,8 @@ static void m32r_sio_enable_ms(struct uart_port *port)
         serial_out(up, UART_IER, up->ier);
 }
 
-static _INLINE_ void receive_chars(struct uart_sio_port *up, int *status,
-        struct pt_regs *regs)
+static void receive_chars(struct uart_sio_port *up, int *status,
+                          struct pt_regs *regs)
 {
         struct tty_struct *tty = up->port.info->tty;
         unsigned char ch;
@@ -400,7 +399,7 @@ static _INLINE_ void receive_chars(struct uart_sio_port *up, int *status,
         tty_flip_buffer_push(tty);
 }
 
-static _INLINE_ void transmit_chars(struct uart_sio_port *up)
+static void transmit_chars(struct uart_sio_port *up)
 {
         struct circ_buf *xmit = &up->port.info->xmit;
         int count;
diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index 7fc3d3b41d18..9fe2283d91e5 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -102,9 +102,7 @@ struct uart_sunsu_port {
 #endif
 };
 
-#define _INLINE_
-
-static _INLINE_ unsigned int serial_in(struct uart_sunsu_port *up, int offset)
+static unsigned int serial_in(struct uart_sunsu_port *up, int offset)
 {
         offset <<= up->port.regshift;
 
@@ -121,8 +119,7 @@ static _INLINE_ unsigned int serial_in(struct uart_sunsu_port *up, int offset)
         }
 }
 
-static _INLINE_ void
-serial_out(struct uart_sunsu_port *up, int offset, int value)
+static void serial_out(struct uart_sunsu_port *up, int offset, int value)
 {
 #ifndef CONFIG_SPARC64
         /*
@@ -316,7 +313,7 @@ static void sunsu_enable_ms(struct uart_port *port)
         spin_unlock_irqrestore(&up->port.lock, flags);
 }
 
-static _INLINE_ struct tty_struct *
+static struct tty_struct *
 receive_chars(struct uart_sunsu_port *up, unsigned char *status, struct pt_regs *regs)
 {
         struct tty_struct *tty = up->port.info->tty;
@@ -395,7 +392,7 @@ receive_chars(struct uart_sunsu_port *up, unsigned char *status, struct pt_regs
         return tty;
 }
 
-static _INLINE_ void transmit_chars(struct uart_sunsu_port *up)
+static void transmit_chars(struct uart_sunsu_port *up)
 {
         struct circ_buf *xmit = &up->port.info->xmit;
         int count;
@@ -431,7 +428,7 @@ static _INLINE_ void transmit_chars(struct uart_sunsu_port *up)
                 __stop_tx(up);
 }
 
-static _INLINE_ void check_modem_status(struct uart_sunsu_port *up)
+static void check_modem_status(struct uart_sunsu_port *up)
 {
         int status;
 
diff --git a/drivers/tc/zs.c b/drivers/tc/zs.c
index 6756d0fab6fe..2dffa8e303b2 100644
--- a/drivers/tc/zs.c
+++ b/drivers/tc/zs.c
@@ -186,8 +186,6 @@ static struct tty_driver *serial_driver;
 #define RS_STROBE_TIME 10
 #define RS_ISR_PASS_LIMIT 256
 
-#define _INLINE_ inline
-
 static void probe_sccs(void);
 static void change_speed(struct dec_serial *info);
 static void rs_wait_until_sent(struct tty_struct *tty, int timeout);
@@ -344,14 +342,13 @@ static inline void rs_recv_clear(struct dec_zschannel *zsc)
  * This routine is used by the interrupt handler to schedule
  * processing in the software interrupt portion of the driver.
  */
-static _INLINE_ void rs_sched_event(struct dec_serial *info, int event)
+static void rs_sched_event(struct dec_serial *info, int event)
 {
         info->event |= 1 << event;
         tasklet_schedule(&info->tlet);
 }
 
-static _INLINE_ void receive_chars(struct dec_serial *info,
-                                   struct pt_regs *regs)
+static void receive_chars(struct dec_serial *info, struct pt_regs *regs)
 {
         struct tty_struct *tty = info->tty;
         unsigned char ch, stat, flag;
@@ -441,7 +438,7 @@ static void transmit_chars(struct dec_serial *info)
                 rs_sched_event(info, RS_EVENT_WRITE_WAKEUP);
 }
 
-static _INLINE_ void status_handle(struct dec_serial *info)
+static void status_handle(struct dec_serial *info)
 {
         unsigned char stat;