212 files changed, 17285 insertions, 6210 deletions

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 6a4da417c16b..606f8733a776 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -28,6 +28,7 @@
 #include <linux/list.h>
 #include <linux/sched.h>
 #include <linux/pm.h>
+#include <linux/pm_legacy.h>
 #include <linux/device.h>
 #include <linux/proc_fs.h>
 #ifdef CONFIG_X86
@@ -754,7 +755,7 @@ static int __init acpi_init(void)
         result = acpi_bus_init();
 
         if (!result) {
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
                 if (!PM_IS_ACTIVE())
                         pm_active = 1;
                 else {
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 573b6a97bb1f..70d8a6ec0920 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -514,8 +514,6 @@ static int acpi_processor_set_power_policy(struct acpi_processor *pr)
 
 static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
 {
-        int i;
-
         ACPI_FUNCTION_TRACE("acpi_processor_get_power_info_fadt");
 
         if (!pr)
@@ -524,8 +522,7 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
         if (!pr->pblk)
                 return_VALUE(-ENODEV);
 
-        for (i = 0; i < ACPI_PROCESSOR_MAX_POWER; i++)
-                memset(pr->power.states, 0, sizeof(struct acpi_processor_cx));
+        memset(pr->power.states, 0, sizeof(pr->power.states));
 
         /* if info is obtained from pblk/fadt, type equals state */
         pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
@@ -555,13 +552,9 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
 
 static int acpi_processor_get_power_info_default_c1(struct acpi_processor *pr)
 {
-        int i;
-
         ACPI_FUNCTION_TRACE("acpi_processor_get_power_info_default_c1");
 
-        for (i = 0; i < ACPI_PROCESSOR_MAX_POWER; i++)
-                memset(&(pr->power.states[i]), 0,
-                       sizeof(struct acpi_processor_cx));
+        memset(pr->power.states, 0, sizeof(pr->power.states));
 
         /* if info is obtained from pblk/fadt, type equals state */
         pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
@@ -873,7 +866,8 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
         for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
                 if (pr->power.states[i].valid) {
                         pr->power.count = i;
-                        pr->flags.power = 1;
+                        if (pr->power.states[i].type >= ACPI_STATE_C2)
+                                pr->flags.power = 1;
                 }
         }
 
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 98f6c02d6790..59dacb6552c0 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -526,18 +526,23 @@ request_firmware_work_func(void *arg)
 {
         struct firmware_work *fw_work = arg;
         const struct firmware *fw;
+        int ret;
         if (!arg) {
                 WARN_ON(1);
                 return 0;
         }
         daemonize("%s/%s", "firmware", fw_work->name);
-        _request_firmware(&fw, fw_work->name, fw_work->device,
+        ret = _request_firmware(&fw, fw_work->name, fw_work->device,
                 fw_work->hotplug);
-        fw_work->cont(fw, fw_work->context);
-        release_firmware(fw);
+        if (ret < 0)
+                fw_work->cont(NULL, fw_work->context);
+        else {
+                fw_work->cont(fw, fw_work->context);
+                release_firmware(fw);
+        }
         module_put(fw_work->module);
         kfree(fw_work);
-        return 0;
+        return ret;
 }
 
 /**
@@ -586,6 +591,8 @@ request_firmware_nowait(
 
         if (ret < 0) {
                 fw_work->cont(NULL, fw_work->context);
+                module_put(fw_work->module);
+                kfree(fw_work);
                 return ret;
         }
         return 0;
diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c
index 3226aa11c6ef..2942d32280a5 100644
--- a/drivers/block/cciss_scsi.c
+++ b/drivers/block/cciss_scsi.c
@@ -255,7 +255,7 @@ scsi_cmd_stack_free(int ctlr)
 #define DEVICETYPE(n) (n<0 || n>MAX_SCSI_DEVICE_CODE) ? \
         "Unknown" : scsi_device_types[n]
 
-#if 1
+#if 0
 static int xmargin=8;
 static int amargin=60;
 
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 59e5982a5db3..c0233efabeba 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1188,7 +1188,7 @@ static void pkt_count_states(struct pktcdvd_device *pd, int *states)
         struct packet_data *pkt;
         int i;
 
-        for (i = 0; i <= PACKET_NUM_STATES; i++)
+        for (i = 0; i < PACKET_NUM_STATES; i++)
                 states[i] = 0;
 
         spin_lock(&pd->cdrw.active_list_lock);
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index fdf4370db994..970f70d498f4 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -735,7 +735,7 @@ config SGI_IP27_RTC
 
 config GEN_RTC
         tristate "Generic /dev/rtc emulation"
-        depends on RTC!=y && !IA64 && !ARM && !PPC64 && !M32R && !SPARC32 && !SPARC64
+        depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC32 && !SPARC64
         ---help---
           If you say Y here and create a character special file /dev/rtc with
           major number 10 and minor number 135 using mknod ("man mknod"), you
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index 78ce98a69f37..76589782adcb 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -57,9 +57,8 @@ static int nr_garts;
 static struct pci_dev * hammers[MAX_HAMMER_GARTS];
 
 static struct resource *aperture_resource;
-static int __initdata agp_try_unsupported;
+static int __initdata agp_try_unsupported = 1;
 
-static int gart_iterator;
 #define for_each_nb() for(gart_iterator=0;gart_iterator<nr_garts;gart_iterator++)
 
 static void flush_amd64_tlb(struct pci_dev *dev)
@@ -73,6 +72,7 @@ static void flush_amd64_tlb(struct pci_dev *dev)
 
 static void amd64_tlbflush(struct agp_memory *temp)
 {
+        int gart_iterator;
         for_each_nb()
                 flush_amd64_tlb(hammers[gart_iterator]);
 }
@@ -222,6 +222,7 @@ static struct aper_size_info_32 amd_8151_sizes[7] =
 static int amd_8151_configure(void)
 {
         unsigned long gatt_bus = virt_to_gart(agp_bridge->gatt_table_real);
+        int gart_iterator;
 
         /* Configure AGP regs in each x86-64 host bridge. */
         for_each_nb() {
@@ -235,7 +236,7 @@ static int amd_8151_configure(void)
 static void amd64_cleanup(void)
 {
         u32 tmp;
-
+        int gart_iterator;
         for_each_nb() {
                 /* disable gart translation */
                 pci_read_config_dword (hammers[gart_iterator], AMD64_GARTAPERTURECTL, &tmp);
@@ -697,6 +698,16 @@ static struct pci_device_id agp_amd64_pci_table[] = {
         .subvendor      = PCI_ANY_ID,
         .subdevice      = PCI_ANY_ID,
         },
+        /* ALI/ULI M1695 */
+        {
+        .class          = (PCI_CLASS_BRIDGE_HOST << 8),
+        .class_mask     = ~0,
+        .vendor         = PCI_VENDOR_ID_AL,
+        .device         = 0x1689,
+        .subvendor      = PCI_ANY_ID,
+        .subdevice      = PCI_ANY_ID,
+        },
+
         { }
 };
 
diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
index c8255312b8c1..50947e38501a 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -557,6 +557,10 @@ static struct agp_device_ids uninorth_agp_device_ids[] __devinitdata = {
                 .device_id      = PCI_DEVICE_ID_APPLE_U3H_AGP,
                 .chipset_name   = "U3H",
         },
+        {
+                .device_id      = PCI_DEVICE_ID_APPLE_IPID2_AGP,
+                .chipset_name   = "UniNorth/Intrepid2",
+        },
 };
 
 static int __devinit agp_uninorth_probe(struct pci_dev *pdev,
diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
index 6c4b3f986d0c..f3c3aaf4560e 100644
--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -99,7 +99,9 @@ struct smm_regs {
 
 static inline char *i8k_get_dmi_data(int field)
 {
-        return dmi_get_system_info(field) ? : "N/A";
+        char *dmi_data = dmi_get_system_info(field);
+
+        return dmi_data && *dmi_data ? dmi_data : "?";
 }
 
 /*
@@ -396,7 +398,7 @@ static int i8k_proc_show(struct seq_file *seq, void *offset)
         return seq_printf(seq, "%s %s %s %d %d %d %d %d %d %d\n",
                           I8K_PROC_FMT,
                           bios_version,
-                          dmi_get_system_info(DMI_PRODUCT_SERIAL) ? : "N/A",
+                          i8k_get_dmi_data(DMI_PRODUCT_SERIAL),
                           cpu_temp,
                           left_fan, right_fan, left_speed, right_speed,
                           ac_power, fn_key);
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index d16bd4b5c117..6b302a930e5f 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -48,7 +48,7 @@
 
 #define PFX "IPMI message handler: "
 
-#define IPMI_DRIVER_VERSION "36.0"
+#define IPMI_DRIVER_VERSION "38.0"
 
 static struct ipmi_recv_msg *ipmi_alloc_recv_msg(void);
 static int ipmi_init_msghandler(void);
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index ea89dca3dbb5..01a1f6badb53 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2203,7 +2203,7 @@ static void setup_xaction_handlers(struct smi_info *smi_info)
 
 static inline void wait_for_timer_and_thread(struct smi_info *smi_info)
 {
-        if (smi_info->thread != ERR_PTR(-ENOMEM))
+        if (smi_info->thread != NULL && smi_info->thread != ERR_PTR(-ENOMEM))
                 kthread_stop(smi_info->thread);
         del_timer_sync(&smi_info->si_timer);
 }
diff --git a/drivers/char/pcmcia/Kconfig b/drivers/char/pcmcia/Kconfig
index d22bfdc13563..27c1179ee527 100644
--- a/drivers/char/pcmcia/Kconfig
+++ b/drivers/char/pcmcia/Kconfig
@@ -18,5 +18,29 @@ config SYNCLINK_CS
           The module will be called synclinkmp.  If you want to do that, say M
           here.
 
+config CARDMAN_4000
+        tristate "Omnikey Cardman 4000 support"
+        depends on PCMCIA
+        help
+          Enable support for the Omnikey Cardman 4000 PCMCIA Smartcard
+          reader.
+
+          This kernel driver requires additional userspace support, either
+          by the vendor-provided PC/SC ifd_handler (http://www.omnikey.com/),
+          or via the cm4000 backend of OpenCT (http://www.opensc.com/).
+
+config CARDMAN_4040
+        tristate "Omnikey CardMan 4040 support"
+        depends on PCMCIA
+        help
+          Enable support for the Omnikey CardMan 4040 PCMCIA Smartcard
+          reader.
+
+          This card is basically a USB CCID device connected to a FIFO
+          in I/O space.  To use the kernel driver, you will need either the
+          PC/SC ifdhandler provided from the Omnikey homepage
+          (http://www.omnikey.com/), or a current development version of OpenCT
+          (http://www.opensc.org/).
+
 endmenu
 
diff --git a/drivers/char/pcmcia/Makefile b/drivers/char/pcmcia/Makefile
index 1fcd4c591958..0aae20985d57 100644
--- a/drivers/char/pcmcia/Makefile
+++ b/drivers/char/pcmcia/Makefile
@@ -5,3 +5,5 @@
 #
 
 obj-$(CONFIG_SYNCLINK_CS) += synclink_cs.o
+obj-$(CONFIG_CARDMAN_4000) += cm4000_cs.o
+obj-$(CONFIG_CARDMAN_4040) += cm4040_cs.o
diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
new file mode 100644
index 000000000000..ef011ef5dc46
--- /dev/null
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -0,0 +1,2078 @@
+ /*
+  * A driver for the PCMCIA Smartcard Reader "Omnikey CardMan Mobile 4000"
+  *
+  * cm4000_cs.c support.linux@omnikey.com
+  *
+  * Tue Oct 23 11:32:43 GMT 2001 herp - cleaned up header files
+  * Sun Jan 20 10:11:15 MET 2002 herp - added modversion header files
+  * Thu Nov 14 16:34:11 GMT 2002 mh   - added PPS functionality
+  * Tue Nov 19 16:36:27 GMT 2002 mh   - added SUSPEND/RESUME functionailty
+  * Wed Jul 28 12:55:01 CEST 2004 mh  - kernel 2.6 adjustments
+  *
+  * current version: 2.4.0gm4
+  *
+  * (C) 2000,2001,2002,2003,2004 Omnikey AG
+  *
+  * (C) 2005 Harald Welte <laforge@gnumonks.org>
+  *     - Adhere to Kernel CodingStyle
+  *     - Port to 2.6.13 "new" style PCMCIA
+  *     - Check for copy_{from,to}_user return values
+  *     - Use nonseekable_open()
+  *
+  * All rights reserved. Licensed under dual BSD/GPL license.
+  */
+
+/* #define PCMCIA_DEBUG 6 */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/init.h>
+#include <linux/fs.h>
+#include <linux/delay.h>
+#include <asm/uaccess.h>
+#include <asm/io.h>
+
+#include <pcmcia/cs_types.h>
+#include <pcmcia/cs.h>
+#include <pcmcia/cistpl.h>
+#include <pcmcia/cisreg.h>
+#include <pcmcia/ciscode.h>
+#include <pcmcia/ds.h>
+
+#include <linux/cm4000_cs.h>
+
+/* #define ATR_CSUM */
+
+#ifdef PCMCIA_DEBUG
+#define reader_to_dev(x)        (&handle_to_dev(x->link.handle))
+static int pc_debug = PCMCIA_DEBUG;
+module_param(pc_debug, int, 0600);
+#define DEBUGP(n, rdr, x, args...) do {                                 \
+        if (pc_debug >= (n))                                            \
+                dev_printk(KERN_DEBUG, reader_to_dev(rdr), "%s:" x,     \
+                           __FUNCTION__ , ## args);                     \
+        } while (0)
+#else
+#define DEBUGP(n, rdr, x, args...)
+#endif
+static char *version = "cm4000_cs.c v2.4.0gm5 - All bugs added by Harald Welte";
+
+#define T_1SEC          (HZ)
+#define T_10MSEC        msecs_to_jiffies(10)
+#define T_20MSEC        msecs_to_jiffies(20)
+#define T_40MSEC        msecs_to_jiffies(40)
+#define T_50MSEC        msecs_to_jiffies(50)
+#define T_100MSEC       msecs_to_jiffies(100)
+#define T_500MSEC       msecs_to_jiffies(500)
+
+static void cm4000_detach(dev_link_t *link);
+static void cm4000_release(dev_link_t *link);
+
+static int major;               /* major number we get from the kernel */
+
+/* note: the first state has to have number 0 always */
+
+#define M_FETCH_ATR     0
+#define M_TIMEOUT_WAIT  1
+#define M_READ_ATR_LEN  2
+#define M_READ_ATR      3
+#define M_ATR_PRESENT   4
+#define M_BAD_CARD      5
+#define M_CARDOFF       6
+
+#define LOCK_IO                 0
+#define LOCK_MONITOR            1
+
+#define IS_AUTOPPS_ACT           6
+#define IS_PROCBYTE_PRESENT      7
+#define IS_INVREV                8
+#define IS_ANY_T0                9
+#define IS_ANY_T1               10
+#define IS_ATR_PRESENT          11
+#define IS_ATR_VALID            12
+#define IS_CMM_ABSENT           13
+#define IS_BAD_LENGTH           14
+#define IS_BAD_CSUM             15
+#define IS_BAD_CARD             16
+
+#define REG_FLAGS0(x)           (x + 0)
+#define REG_FLAGS1(x)           (x + 1)
+#define REG_NUM_BYTES(x)        (x + 2)
+#define REG_BUF_ADDR(x)         (x + 3)
+#define REG_BUF_DATA(x)         (x + 4)
+#define REG_NUM_SEND(x)         (x + 5)
+#define REG_BAUDRATE(x)         (x + 6)
+#define REG_STOPBITS(x)         (x + 7)
+
+struct cm4000_dev {
+        dev_link_t link;                /* pcmcia link */
+        dev_node_t node;                /* OS node (major,minor) */
+
+        unsigned char atr[MAX_ATR];
+        unsigned char rbuf[512];
+        unsigned char sbuf[512];
+
+        wait_queue_head_t devq;         /* when removing cardman must not be
+                                           zeroed! */
+
+        wait_queue_head_t ioq;          /* if IO is locked, wait on this Q */
+        wait_queue_head_t atrq;         /* wait for ATR valid */
+        wait_queue_head_t readq;        /* used by write to wake blk.read */
+
+        /* warning: do not move this fields.
+         * initialising to zero depends on it - see ZERO_DEV below.  */
+        unsigned char atr_csum;
+        unsigned char atr_len_retry;
+        unsigned short atr_len;
+        unsigned short rlen;    /* bytes avail. after write */
+        unsigned short rpos;    /* latest read pos. write zeroes */
+        unsigned char procbyte; /* T=0 procedure byte */
+        unsigned char mstate;   /* state of card monitor */
+        unsigned char cwarn;    /* slow down warning */
+        unsigned char flags0;   /* cardman IO-flags 0 */
+        unsigned char flags1;   /* cardman IO-flags 1 */
+        unsigned int mdelay;    /* variable monitor speeds, in jiffies */
+
+        unsigned int baudv;     /* baud value for speed */
+        unsigned char ta1;
+        unsigned char proto;    /* T=0, T=1, ... */
+        unsigned long flags;    /* lock+flags (MONITOR,IO,ATR) * for concurrent
+                                   access */
+
+        unsigned char pts[4];
+
+        struct timer_list timer;        /* used to keep monitor running */
+        int monitor_running;
+};
+
+#define ZERO_DEV(dev)                                           \
+        memset(&dev->atr_csum,0,                                \
+                sizeof(struct cm4000_dev) -                     \
+                /*link*/ sizeof(dev_link_t) -                   \
+                /*node*/ sizeof(dev_node_t) -                   \
+                /*atr*/ MAX_ATR*sizeof(char) -                  \
+                /*rbuf*/ 512*sizeof(char) -                     \
+                /*sbuf*/ 512*sizeof(char) -                     \
+                /*queue*/ 4*sizeof(wait_queue_head_t))
+
+static dev_info_t dev_info = MODULE_NAME;
+static dev_link_t *dev_table[CM4000_MAX_DEV];
+
+/* This table doesn't use spaces after the comma between fields and thus
+ * violates CodingStyle.  However, I don't really think wrapping it around will
+ * make it any clearer to read -HW */
+static unsigned char fi_di_table[10][14] = {
+/*FI     00   01   02   03   04   05   06   07   08   09   10   11   12   13 */
+/*DI */
+/* 0 */ {0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11},
+/* 1 */ {0x01,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x91,0x11,0x11,0x11,0x11},
+/* 2 */ {0x02,0x12,0x22,0x32,0x11,0x11,0x11,0x11,0x11,0x92,0xA2,0xB2,0x11,0x11},
+/* 3 */ {0x03,0x13,0x23,0x33,0x43,0x53,0x63,0x11,0x11,0x93,0xA3,0xB3,0xC3,0xD3},
+/* 4 */ {0x04,0x14,0x24,0x34,0x44,0x54,0x64,0x11,0x11,0x94,0xA4,0xB4,0xC4,0xD4},
+/* 5 */ {0x00,0x15,0x25,0x35,0x45,0x55,0x65,0x11,0x11,0x95,0xA5,0xB5,0xC5,0xD5},
+/* 6 */ {0x06,0x16,0x26,0x36,0x46,0x56,0x66,0x11,0x11,0x96,0xA6,0xB6,0xC6,0xD6},
+/* 7 */ {0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11,0x11},
+/* 8 */ {0x08,0x11,0x28,0x38,0x48,0x58,0x68,0x11,0x11,0x98,0xA8,0xB8,0xC8,0xD8},
+/* 9 */ {0x09,0x19,0x29,0x39,0x49,0x59,0x69,0x11,0x11,0x99,0xA9,0xB9,0xC9,0xD9}
+};
+
+#ifndef PCMCIA_DEBUG
+#define xoutb   outb
+#define xinb    inb
+#else
+static inline void xoutb(unsigned char val, unsigned short port)
+{
+        if (pc_debug >= 7)
+                printk(KERN_DEBUG "outb(val=%.2x,port=%.4x)\n", val, port);
+        outb(val, port);
+}
+static inline unsigned char xinb(unsigned short port)
+{
+        unsigned char val;
+
+        val = inb(port);
+        if (pc_debug >= 7)
+                printk(KERN_DEBUG "%.2x=inb(%.4x)\n", val, port);
+
+        return val;
+}
+#endif
+
+#define b_0000  15
+#define b_0001  14
+#define b_0010  13
+#define b_0011  12
+#define b_0100  11
+#define b_0101  10
+#define b_0110  9
+#define b_0111  8
+#define b_1000  7
+#define b_1001  6
+#define b_1010  5
+#define b_1011  4
+#define b_1100  3
+#define b_1101  2
+#define b_1110  1
+#define b_1111  0
+
+static unsigned char irtab[16] = {
+        b_0000, b_1000, b_0100, b_1100,
+        b_0010, b_1010, b_0110, b_1110,
+        b_0001, b_1001, b_0101, b_1101,
+        b_0011, b_1011, b_0111, b_1111
+};
+
+static void str_invert_revert(unsigned char *b, int len)
+{
+        int i;
+
+        for (i = 0; i < len; i++)
+                b[i] = (irtab[b[i] & 0x0f] << 4) | irtab[b[i] >> 4];
+}
+
+static unsigned char invert_revert(unsigned char ch)
+{
+        return (irtab[ch & 0x0f] << 4) | irtab[ch >> 4];
+}
+
+#define ATRLENCK(dev,pos) \
+        if (pos>=dev->atr_len || pos>=MAX_ATR) \
+                goto return_0;
+
+static unsigned int calc_baudv(unsigned char fidi)
+{
+        unsigned int wcrcf, wbrcf, fi_rfu, di_rfu;
+
+        fi_rfu = 372;
+        di_rfu = 1;
+
+        /* FI */
+        switch ((fidi >> 4) & 0x0F) {
+        case 0x00:
+                wcrcf = 372;
+                break;
+        case 0x01:
+                wcrcf = 372;
+                break;
+        case 0x02:
+                wcrcf = 558;
+                break;
+        case 0x03:
+                wcrcf = 744;
+                break;
+        case 0x04:
+                wcrcf = 1116;
+                break;
+        case 0x05:
+                wcrcf = 1488;
+                break;
+        case 0x06:
+                wcrcf = 1860;
+                break;
+        case 0x07:
+                wcrcf = fi_rfu;
+                break;
+        case 0x08:
+                wcrcf = fi_rfu;
+                break;
+        case 0x09:
+                wcrcf = 512;
+                break;
+        case 0x0A:
+                wcrcf = 768;
+                break;
+        case 0x0B:
+                wcrcf = 1024;
+                break;
+        case 0x0C:
+                wcrcf = 1536;
+                break;
+        case 0x0D:
+                wcrcf = 2048;
+                break;
+        default:
+                wcrcf = fi_rfu;
+                break;
+        }
+
+        /* DI */
+        switch (fidi & 0x0F) {
+        case 0x00:
+                wbrcf = di_rfu;
+                break;
+        case 0x01:
+                wbrcf = 1;
+                break;
+        case 0x02:
+                wbrcf = 2;
+                break;
+        case 0x03:
+                wbrcf = 4;
+                break;
+        case 0x04:
+                wbrcf = 8;
+                break;
+        case 0x05:
+                wbrcf = 16;
+                break;
+        case 0x06:
+                wbrcf = 32;
+                break;
+        case 0x07:
+                wbrcf = di_rfu;
+                break;
+        case 0x08:
+                wbrcf = 12;
+                break;
+        case 0x09:
+                wbrcf = 20;
+                break;
+        default:
+                wbrcf = di_rfu;
+                break;
+        }
+
+        return (wcrcf / wbrcf);
+}
+
+static unsigned short io_read_num_rec_bytes(ioaddr_t iobase, unsigned short *s)
+{
+        unsigned short tmp;
+
+        tmp = *s = 0;
+        do {
+                *s = tmp;
+                tmp = inb(REG_NUM_BYTES(iobase)) |
+                                (inb(REG_FLAGS0(iobase)) & 4 ? 0x100 : 0);
+        } while (tmp != *s);
+
+        return *s;
+}
+
+static int parse_atr(struct cm4000_dev *dev)
+{
+        unsigned char any_t1, any_t0;
+        unsigned char ch, ifno;
+        int ix, done;
+
+        DEBUGP(3, dev, "-> parse_atr: dev->atr_len = %i\n", dev->atr_len);
+
+        if (dev->atr_len < 3) {
+                DEBUGP(5, dev, "parse_atr: atr_len < 3\n");
+                return 0;
+        }
+
+        if (dev->atr[0] == 0x3f)
+                set_bit(IS_INVREV, &dev->flags);
+        else
+                clear_bit(IS_INVREV, &dev->flags);
+        ix = 1;
+        ifno = 1;
+        ch = dev->atr[1];
+        dev->proto = 0;         /* XXX PROTO */
+        any_t1 = any_t0 = done = 0;
+        dev->ta1 = 0x11;        /* defaults to 9600 baud */
+        do {
+                if (ifno == 1 && (ch & 0x10)) {
+                        /* read first interface byte and TA1 is present */
+                        dev->ta1 = dev->atr[2];
+                        DEBUGP(5, dev, "Card says FiDi is 0x%.2x\n", dev->ta1);
+                        ifno++;
+                } else if ((ifno == 2) && (ch & 0x10)) { /* TA(2) */
+                        dev->ta1 = 0x11;
+                        ifno++;
+                }
+
+                DEBUGP(5, dev, "Yi=%.2x\n", ch & 0xf0);
+                ix += ((ch & 0x10) >> 4)        /* no of int.face chars */
+                    +((ch & 0x20) >> 5)
+                    + ((ch & 0x40) >> 6)
+                    + ((ch & 0x80) >> 7);
+                /* ATRLENCK(dev,ix); */
+                if (ch & 0x80) {        /* TDi */
+                        ch = dev->atr[ix];
+                        if ((ch & 0x0f)) {
+                                any_t1 = 1;
+                                DEBUGP(5, dev, "card is capable of T=1\n");
+                        } else {
+                                any_t0 = 1;
+                                DEBUGP(5, dev, "card is capable of T=0\n");
+                        }
+                } else
+                        done = 1;
+        } while (!done);
+
+        DEBUGP(5, dev, "ix=%d noHist=%d any_t1=%d\n",
+              ix, dev->atr[1] & 15, any_t1);
+        if (ix + 1 + (dev->atr[1] & 0x0f) + any_t1 != dev->atr_len) {
+                DEBUGP(5, dev, "length error\n");
+                return 0;
+        }
+        if (any_t0)
+                set_bit(IS_ANY_T0, &dev->flags);
+
+        if (any_t1) {           /* compute csum */
+                dev->atr_csum = 0;
+#ifdef ATR_CSUM
+                for (i = 1; i < dev->atr_len; i++)
+                        dev->atr_csum ^= dev->atr[i];
+                if (dev->atr_csum) {
+                        set_bit(IS_BAD_CSUM, &dev->flags);
+                        DEBUGP(5, dev, "bad checksum\n");
+                        goto return_0;
+                }
+#endif
+                if (any_t0 == 0)
+                        dev->proto = 1; /* XXX PROTO */
+                set_bit(IS_ANY_T1, &dev->flags);
+        }
+
+        return 1;
+}
+
+struct card_fixup {
+        char atr[12];
+        u_int8_t atr_len;
+        u_int8_t stopbits;
+};
+
+static struct card_fixup card_fixups[] = {
+        {       /* ACOS */
+                .atr = { 0x3b, 0xb3, 0x11, 0x00, 0x00, 0x41, 0x01 },
+                .atr_len = 7,
+                .stopbits = 0x03,
+        },
+        {       /* Motorola */
+                .atr = {0x3b, 0x76, 0x13, 0x00, 0x00, 0x80, 0x62, 0x07,
+                        0x41, 0x81, 0x81 },
+                .atr_len = 11,
+                .stopbits = 0x04,
+        },
+};
+
+static void set_cardparameter(struct cm4000_dev *dev)
+{
+        int i;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+        u_int8_t stopbits = 0x02; /* ISO default */
+
+        DEBUGP(3, dev, "-> set_cardparameter\n");
+
+        dev->flags1 = dev->flags1 | (((dev->baudv - 1) & 0x0100) >> 8);
+        xoutb(dev->flags1, REG_FLAGS1(iobase));
+        DEBUGP(5, dev, "flags1 = 0x%02x\n", dev->flags1);
+
+        /* set baudrate */
+        xoutb((unsigned char)((dev->baudv - 1) & 0xFF), REG_BAUDRATE(iobase));
+
+        DEBUGP(5, dev, "baudv = %i -> write 0x%02x\n", dev->baudv,
+              ((dev->baudv - 1) & 0xFF));
+
+        /* set stopbits */
+        for (i = 0; i < ARRAY_SIZE(card_fixups); i++) {
+                if (!memcmp(dev->atr, card_fixups[i].atr,
+                            card_fixups[i].atr_len))
+                        stopbits = card_fixups[i].stopbits;
+        }
+        xoutb(stopbits, REG_STOPBITS(iobase));
+
+        DEBUGP(3, dev, "<- set_cardparameter\n");
+}
+
+static int set_protocol(struct cm4000_dev *dev, struct ptsreq *ptsreq)
+{
+
+        unsigned long tmp, i;
+        unsigned short num_bytes_read;
+        unsigned char pts_reply[4];
+        ssize_t rc;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+
+        rc = 0;
+
+        DEBUGP(3, dev, "-> set_protocol\n");
+        DEBUGP(5, dev, "ptsreq->Protocol = 0x%.8x, ptsreq->Flags=0x%.8x, "
+                 "ptsreq->pts1=0x%.2x, ptsreq->pts2=0x%.2x, "
+                 "ptsreq->pts3=0x%.2x\n", (unsigned int)ptsreq->protocol,
+                 (unsigned int)ptsreq->flags, ptsreq->pts1, ptsreq->pts2,
+                 ptsreq->pts3);
+
+        /* Fill PTS structure */
+        dev->pts[0] = 0xff;
+        dev->pts[1] = 0x00;
+        tmp = ptsreq->protocol;
+        while ((tmp = (tmp >> 1)) > 0)
+                dev->pts[1]++;
+        dev->proto = dev->pts[1];       /* Set new protocol */
+        dev->pts[1] = (0x01 << 4) | (dev->pts[1]);
+
+        /* Correct Fi/Di according to CM4000 Fi/Di table */
+        DEBUGP(5, dev, "Ta(1) from ATR is 0x%.2x\n", dev->ta1);
+        /* set Fi/Di according to ATR TA(1) */
+        dev->pts[2] = fi_di_table[dev->ta1 & 0x0F][(dev->ta1 >> 4) & 0x0F];
+
+        /* Calculate PCK character */
+        dev->pts[3] = dev->pts[0] ^ dev->pts[1] ^ dev->pts[2];
+
+        DEBUGP(5, dev, "pts0=%.2x, pts1=%.2x, pts2=%.2x, pts3=%.2x\n",
+               dev->pts[0], dev->pts[1], dev->pts[2], dev->pts[3]);
+
+        /* check card convention */
+        if (test_bit(IS_INVREV, &dev->flags))
+                str_invert_revert(dev->pts, 4);
+
+        /* reset SM */
+        xoutb(0x80, REG_FLAGS0(iobase));
+
+        /* Enable access to the message buffer */
+        DEBUGP(5, dev, "Enable access to the messages buffer\n");
+        dev->flags1 = 0x20      /* T_Active */
+            | (test_bit(IS_INVREV, &dev->flags) ? 0x02 : 0x00) /* inv parity */
+            | ((dev->baudv >> 8) & 0x01);       /* MSB-baud */
+        xoutb(dev->flags1, REG_FLAGS1(iobase));
+
+        DEBUGP(5, dev, "Enable message buffer -> flags1 = 0x%.2x\n",
+               dev->flags1);
+
+        /* write challenge to the buffer */
+        DEBUGP(5, dev, "Write challenge to buffer: ");
+        for (i = 0; i < 4; i++) {
+                xoutb(i, REG_BUF_ADDR(iobase));
+                xoutb(dev->pts[i], REG_BUF_DATA(iobase));       /* buf data */
+#ifdef PCMCIA_DEBUG
+                if (pc_debug >= 5)
+                        printk("0x%.2x ", dev->pts[i]);
+        }
+        if (pc_debug >= 5)
+                printk("\n");
+#else
+        }
+#endif
+
+        /* set number of bytes to write */
+        DEBUGP(5, dev, "Set number of bytes to write\n");
+        xoutb(0x04, REG_NUM_SEND(iobase));
+
+        /* Trigger CARDMAN CONTROLLER */
+        xoutb(0x50, REG_FLAGS0(iobase));
+
+        /* Monitor progress */
+        /* wait for xmit done */
+        DEBUGP(5, dev, "Waiting for NumRecBytes getting valid\n");
+
+        for (i = 0; i < 100; i++) {
+                if (inb(REG_FLAGS0(iobase)) & 0x08) {
+                        DEBUGP(5, dev, "NumRecBytes is valid\n");
+                        break;
+                }
+                mdelay(10);
+        }
+        if (i == 100) {
+                DEBUGP(5, dev, "Timeout waiting for NumRecBytes getting "
+                       "valid\n");
+                rc = -EIO;
+                goto exit_setprotocol;
+        }
+
+        DEBUGP(5, dev, "Reading NumRecBytes\n");
+        for (i = 0; i < 100; i++) {
+                io_read_num_rec_bytes(iobase, &num_bytes_read);
+                if (num_bytes_read >= 4) {
+                        DEBUGP(2, dev, "NumRecBytes = %i\n", num_bytes_read);
+                        break;
+                }
+                mdelay(10);
+        }
+
+        /* check whether it is a short PTS reply? */
+        if (num_bytes_read == 3)
+                i = 0;
+
+        if (i == 100) {
+                DEBUGP(5, dev, "Timeout reading num_bytes_read\n");
+                rc = -EIO;
+                goto exit_setprotocol;
+        }
+
+        DEBUGP(5, dev, "Reset the CARDMAN CONTROLLER\n");
+        xoutb(0x80, REG_FLAGS0(iobase));
+
+        /* Read PPS reply */
+        DEBUGP(5, dev, "Read PPS reply\n");
+        for (i = 0; i < num_bytes_read; i++) {
+                xoutb(i, REG_BUF_ADDR(iobase));
+                pts_reply[i] = inb(REG_BUF_DATA(iobase));
+        }
+
+#ifdef PCMCIA_DEBUG
+        DEBUGP(2, dev, "PTSreply: ");
+        for (i = 0; i < num_bytes_read; i++) {
+                if (pc_debug >= 5)
+                        printk("0x%.2x ", pts_reply[i]);
+        }
+        printk("\n");
+#endif  /* PCMCIA_DEBUG */
+
+        DEBUGP(5, dev, "Clear Tactive in Flags1\n");
+        xoutb(0x20, REG_FLAGS1(iobase));
+
+        /* Compare ptsreq and ptsreply */
+        if ((dev->pts[0] == pts_reply[0]) &&
+            (dev->pts[1] == pts_reply[1]) &&
+            (dev->pts[2] == pts_reply[2]) && (dev->pts[3] == pts_reply[3])) {
+                /* setcardparameter according to PPS */
+                dev->baudv = calc_baudv(dev->pts[2]);
+                set_cardparameter(dev);
+        } else if ((dev->pts[0] == pts_reply[0]) &&
+                   ((dev->pts[1] & 0xef) == pts_reply[1]) &&
+                   ((pts_reply[0] ^ pts_reply[1]) == pts_reply[2])) {
+                /* short PTS reply, set card parameter to default values */
+                dev->baudv = calc_baudv(0x11);
+                set_cardparameter(dev);
+        } else
+                rc = -EIO;
+
+exit_setprotocol:
+        DEBUGP(3, dev, "<- set_protocol\n");
+        return rc;
+}
+
+static int io_detect_cm4000(ioaddr_t iobase, struct cm4000_dev *dev)
+{
+
+        /* note: statemachine is assumed to be reset */
+        if (inb(REG_FLAGS0(iobase)) & 8) {
+                clear_bit(IS_ATR_VALID, &dev->flags);
+                set_bit(IS_CMM_ABSENT, &dev->flags);
+                return 0;       /* detect CMM = 1 -> failure */
+        }
+        /* xoutb(0x40, REG_FLAGS1(iobase)); detectCMM */
+        xoutb(dev->flags1 | 0x40, REG_FLAGS1(iobase));
+        if ((inb(REG_FLAGS0(iobase)) & 8) == 0) {
+                clear_bit(IS_ATR_VALID, &dev->flags);
+                set_bit(IS_CMM_ABSENT, &dev->flags);
+                return 0;       /* detect CMM=0 -> failure */
+        }
+        /* clear detectCMM again by restoring original flags1 */
+        xoutb(dev->flags1, REG_FLAGS1(iobase));
+        return 1;
+}
+
+static void terminate_monitor(struct cm4000_dev *dev)
+{
+
+        /* tell the monitor to stop and wait until
+         * it terminates.
+         */
+        DEBUGP(3, dev, "-> terminate_monitor\n");
+        wait_event_interruptible(dev->devq,
+                                 test_and_set_bit(LOCK_MONITOR,
+                                                  (void *)&dev->flags));
+
+        /* now, LOCK_MONITOR has been set.
+         * allow a last cycle in the monitor.
+         * the monitor will indicate that it has
+         * finished by clearing this bit.
+         */
+        DEBUGP(5, dev, "Now allow last cycle of monitor!\n");
+        while (test_bit(LOCK_MONITOR, (void *)&dev->flags))
+                msleep(25);
+
+        DEBUGP(5, dev, "Delete timer\n");
+        del_timer_sync(&dev->timer);
+#ifdef PCMCIA_DEBUG
+        dev->monitor_running = 0;
+#endif
+
+        DEBUGP(3, dev, "<- terminate_monitor\n");
+}
+
+/*
+ * monitor the card every 50msec. as a side-effect, retrieve the
+ * atr once a card is inserted. another side-effect of retrieving the
+ * atr is that the card will be powered on, so there is no need to
+ * power on the card explictely from the application: the driver
+ * is already doing that for you.
+ */
+
+static void monitor_card(unsigned long p)
+{
+        struct cm4000_dev *dev = (struct cm4000_dev *) p;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+        unsigned short s;
+        struct ptsreq ptsreq;
+        int i, atrc;
+
+        DEBUGP(7, dev, "->  monitor_card\n");
+
+        /* if someone has set the lock for us: we're done! */
+        if (test_and_set_bit(LOCK_MONITOR, &dev->flags)) {
+                DEBUGP(4, dev, "About to stop monitor\n");
+                /* no */
+                dev->rlen =
+                    dev->rpos =
+                    dev->atr_csum = dev->atr_len_retry = dev->cwarn = 0;
+                dev->mstate = M_FETCH_ATR;
+                clear_bit(LOCK_MONITOR, &dev->flags);
+                /* close et al. are sleeping on devq, so wake it */
+                wake_up_interruptible(&dev->devq);
+                DEBUGP(2, dev, "<- monitor_card (we are done now)\n");
+                return;
+        }
+
+        /* try to lock io: if it is already locked, just add another timer */
+        if (test_and_set_bit(LOCK_IO, (void *)&dev->flags)) {
+                DEBUGP(4, dev, "Couldn't get IO lock\n");
+                goto return_with_timer;
+        }
+
+        /* is a card/a reader inserted at all ? */
+        dev->flags0 = xinb(REG_FLAGS0(iobase));
+        DEBUGP(7, dev, "dev->flags0 = 0x%2x\n", dev->flags0);
+        DEBUGP(7, dev, "smartcard present: %s\n",
+               dev->flags0 & 1 ? "yes" : "no");
+        DEBUGP(7, dev, "cardman present: %s\n",
+               dev->flags0 == 0xff ? "no" : "yes");
+
+        if ((dev->flags0 & 1) == 0      /* no smartcard inserted */
+            || dev->flags0 == 0xff) {   /* no cardman inserted */
+                /* no */
+                dev->rlen =
+                    dev->rpos =
+                    dev->atr_csum = dev->atr_len_retry = dev->cwarn = 0;
+                dev->mstate = M_FETCH_ATR;
+
+                dev->flags &= 0x000000ff; /* only keep IO and MONITOR locks */
+
+                if (dev->flags0 == 0xff) {
+                        DEBUGP(4, dev, "set IS_CMM_ABSENT bit\n");
+                        set_bit(IS_CMM_ABSENT, &dev->flags);
+                } else if (test_bit(IS_CMM_ABSENT, &dev->flags)) {
+                        DEBUGP(4, dev, "clear IS_CMM_ABSENT bit "
+                               "(card is removed)\n");
+                        clear_bit(IS_CMM_ABSENT, &dev->flags);
+                }
+
+                goto release_io;
+        } else if ((dev->flags0 & 1) && test_bit(IS_CMM_ABSENT, &dev->flags)) {
+                /* cardman and card present but cardman was absent before
+                 * (after suspend with inserted card) */
+                DEBUGP(4, dev, "clear IS_CMM_ABSENT bit (card is inserted)\n");
+                clear_bit(IS_CMM_ABSENT, &dev->flags);
+        }
+
+        if (test_bit(IS_ATR_VALID, &dev->flags) == 1) {
+                DEBUGP(7, dev, "believe ATR is already valid (do nothing)\n");
+                goto release_io;
+        }
+
+        switch (dev->mstate) {
+                unsigned char flags0;
+        case M_CARDOFF:
+                DEBUGP(4, dev, "M_CARDOFF\n");
+                flags0 = inb(REG_FLAGS0(iobase));
+                if (flags0 & 0x02) {
+                        /* wait until Flags0 indicate power is off */
+                        dev->mdelay = T_10MSEC;
+                } else {
+                        /* Flags0 indicate power off and no card inserted now;
+                         * Reset CARDMAN CONTROLLER */
+                        xoutb(0x80, REG_FLAGS0(iobase));
+
+                        /* prepare for fetching ATR again: after card off ATR
+                         * is read again automatically */
+                        dev->rlen =
+                            dev->rpos =
+                            dev->atr_csum =
+                            dev->atr_len_retry = dev->cwarn = 0;
+                        dev->mstate = M_FETCH_ATR;
+
+                        /* minimal gap between CARDOFF and read ATR is 50msec */
+                        dev->mdelay = T_50MSEC;
+                }
+                break;
+        case M_FETCH_ATR:
+                DEBUGP(4, dev, "M_FETCH_ATR\n");
+                xoutb(0x80, REG_FLAGS0(iobase));
+                DEBUGP(4, dev, "Reset BAUDV to 9600\n");
+                dev->baudv = 0x173;     /* 9600 */
+                xoutb(0x02, REG_STOPBITS(iobase));      /* stopbits=2 */
+                xoutb(0x73, REG_BAUDRATE(iobase));      /* baud value */
+                xoutb(0x21, REG_FLAGS1(iobase));        /* T_Active=1, baud
+                                                           value */
+                /* warm start vs. power on: */
+                xoutb(dev->flags0 & 2 ? 0x46 : 0x44, REG_FLAGS0(iobase));
+                dev->mdelay = T_40MSEC;
+                dev->mstate = M_TIMEOUT_WAIT;
+                break;
+        case M_TIMEOUT_WAIT:
+                DEBUGP(4, dev, "M_TIMEOUT_WAIT\n");
+                /* numRecBytes */
+                io_read_num_rec_bytes(iobase, &dev->atr_len);
+                dev->mdelay = T_10MSEC;
+                dev->mstate = M_READ_ATR_LEN;
+                break;
+        case M_READ_ATR_LEN:
+                DEBUGP(4, dev, "M_READ_ATR_LEN\n");
+                /* infinite loop possible, since there is no timeout */
+
+#define MAX_ATR_LEN_RETRY       100
+
+                if (dev->atr_len == io_read_num_rec_bytes(iobase, &s)) {
+                        if (dev->atr_len_retry++ >= MAX_ATR_LEN_RETRY) {                                        /* + XX msec */
+                                dev->mdelay = T_10MSEC;
+                                dev->mstate = M_READ_ATR;
+                        }
+                } else {
+                        dev->atr_len = s;
+                        dev->atr_len_retry = 0; /* set new timeout */
+                }
+
+                DEBUGP(4, dev, "Current ATR_LEN = %i\n", dev->atr_len);
+                break;
+        case M_READ_ATR:
+                DEBUGP(4, dev, "M_READ_ATR\n");
+                xoutb(0x80, REG_FLAGS0(iobase));        /* reset SM */
+                for (i = 0; i < dev->atr_len; i++) {
+                        xoutb(i, REG_BUF_ADDR(iobase));
+                        dev->atr[i] = inb(REG_BUF_DATA(iobase));
+                }
+                /* Deactivate T_Active flags */
+                DEBUGP(4, dev, "Deactivate T_Active flags\n");
+                dev->flags1 = 0x01;
+                xoutb(dev->flags1, REG_FLAGS1(iobase));
+
+                /* atr is present (which doesnt mean it's valid) */
+                set_bit(IS_ATR_PRESENT, &dev->flags);
+                if (dev->atr[0] == 0x03)
+                        str_invert_revert(dev->atr, dev->atr_len);
+                atrc = parse_atr(dev);
+                if (atrc == 0) {        /* atr invalid */
+                        dev->mdelay = 0;
+                        dev->mstate = M_BAD_CARD;
+                } else {
+                        dev->mdelay = T_50MSEC;
+                        dev->mstate = M_ATR_PRESENT;
+                        set_bit(IS_ATR_VALID, &dev->flags);
+                }
+
+                if (test_bit(IS_ATR_VALID, &dev->flags) == 1) {
+                        DEBUGP(4, dev, "monitor_card: ATR valid\n");
+                        /* if ta1 == 0x11, no PPS necessary (default values) */
+                        /* do not do PPS with multi protocol cards */
+                        if ((test_bit(IS_AUTOPPS_ACT, &dev->flags) == 0) &&
+                            (dev->ta1 != 0x11) &&
+                            !(test_bit(IS_ANY_T0, &dev->flags) &&
+                            test_bit(IS_ANY_T1, &dev->flags))) {
+                                DEBUGP(4, dev, "Perform AUTOPPS\n");
+                                set_bit(IS_AUTOPPS_ACT, &dev->flags);
+                                ptsreq.protocol = ptsreq.protocol =
+                                    (0x01 << dev->proto);
+                                ptsreq.flags = 0x01;
+                                ptsreq.pts1 = 0x00;
+                                ptsreq.pts2 = 0x00;
+                                ptsreq.pts3 = 0x00;
+                                if (set_protocol(dev, &ptsreq) == 0) {
+                                        DEBUGP(4, dev, "AUTOPPS ret SUCC\n");
+                                        clear_bit(IS_AUTOPPS_ACT, &dev->flags);
+                                        wake_up_interruptible(&dev->atrq);
+                                } else {
+                                        DEBUGP(4, dev, "AUTOPPS failed: "
+                                               "repower using defaults\n");
+                                        /* prepare for repowering  */
+                                        clear_bit(IS_ATR_PRESENT, &dev->flags);
+                                        clear_bit(IS_ATR_VALID, &dev->flags);
+                                        dev->rlen =
+                                            dev->rpos =
+                                            dev->atr_csum =
+                                            dev->atr_len_retry = dev->cwarn = 0;
+                                        dev->mstate = M_FETCH_ATR;
+
+                                        dev->mdelay = T_50MSEC;
+                                }
+                        } else {
+                                /* for cards which use slightly different
+                                 * params (extra guard time) */
+                                set_cardparameter(dev);
+                                if (test_bit(IS_AUTOPPS_ACT, &dev->flags) == 1)
+                                        DEBUGP(4, dev, "AUTOPPS already active "
+                                               "2nd try:use default values\n");
+                                if (dev->ta1 == 0x11)
+                                        DEBUGP(4, dev, "No AUTOPPS necessary "
+                                               "TA(1)==0x11\n");
+                                if (test_bit(IS_ANY_T0, &dev->flags)
+                                    && test_bit(IS_ANY_T1, &dev->flags))
+                                        DEBUGP(4, dev, "Do NOT perform AUTOPPS "
+                                               "with multiprotocol cards\n");
+                                clear_bit(IS_AUTOPPS_ACT, &dev->flags);
+                                wake_up_interruptible(&dev->atrq);
+                        }
+                } else {
+                        DEBUGP(4, dev, "ATR invalid\n");
+                        wake_up_interruptible(&dev->atrq);
+                }
+                break;
+        case M_BAD_CARD:
+                DEBUGP(4, dev, "M_BAD_CARD\n");
+                /* slow down warning, but prompt immediately after insertion */
+                if (dev->cwarn == 0 || dev->cwarn == 10) {
+                        set_bit(IS_BAD_CARD, &dev->flags);
+                        printk(KERN_WARNING MODULE_NAME ": device %s: ",
+                               dev->node.dev_name);
+                        if (test_bit(IS_BAD_CSUM, &dev->flags)) {
+                                DEBUGP(4, dev, "ATR checksum (0x%.2x, should "
+                                       "be zero) failed\n", dev->atr_csum);
+                        }
+#ifdef PCMCIA_DEBUG
+                        else if (test_bit(IS_BAD_LENGTH, &dev->flags)) {
+                                DEBUGP(4, dev, "ATR length error\n");
+                        } else {
+                                DEBUGP(4, dev, "card damaged or wrong way "
+                                        "inserted\n");
+                        }
+#endif
+                        dev->cwarn = 0;
+                        wake_up_interruptible(&dev->atrq);      /* wake open */
+                }
+                dev->cwarn++;
+                dev->mdelay = T_100MSEC;
+                dev->mstate = M_FETCH_ATR;
+                break;
+        default:
+                DEBUGP(7, dev, "Unknown action\n");
+                break;          /* nothing */
+        }
+
+release_io:
+        DEBUGP(7, dev, "release_io\n");
+        clear_bit(LOCK_IO, &dev->flags);
+        wake_up_interruptible(&dev->ioq);       /* whoever needs IO */
+
+return_with_timer:
+        DEBUGP(7, dev, "<- monitor_card (returns with timer)\n");
+        dev->timer.expires = jiffies + dev->mdelay;
+        add_timer(&dev->timer);
+        clear_bit(LOCK_MONITOR, &dev->flags);
+}
+
+/* Interface to userland (file_operations) */
+
+static ssize_t cmm_read(struct file *filp, __user char *buf, size_t count,
+                        loff_t *ppos)
+{
+        struct cm4000_dev *dev = filp->private_data;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+        ssize_t rc;
+        int i, j, k;
+
+        DEBUGP(2, dev, "-> cmm_read(%s,%d)\n", current->comm, current->pid);
+
+        if (count == 0)         /* according to manpage */
+                return 0;
+
+        if ((dev->link.state & DEV_PRESENT) == 0 ||     /* socket removed */
+            test_bit(IS_CMM_ABSENT, &dev->flags))
+                return -ENODEV;
+
+        if (test_bit(IS_BAD_CSUM, &dev->flags))
+                return -EIO;
+
+        /* also see the note about this in cmm_write */
+        if (wait_event_interruptible
+            (dev->atrq,
+             ((filp->f_flags & O_NONBLOCK)
+              || (test_bit(IS_ATR_PRESENT, (void *)&dev->flags) != 0)))) {
+                if (filp->f_flags & O_NONBLOCK)
+                        return -EAGAIN;
+                return -ERESTARTSYS;
+        }
+
+        if (test_bit(IS_ATR_VALID, &dev->flags) == 0)
+                return -EIO;
+
+        /* this one implements blocking IO */
+        if (wait_event_interruptible
+            (dev->readq,
+             ((filp->f_flags & O_NONBLOCK) || (dev->rpos < dev->rlen)))) {
+                if (filp->f_flags & O_NONBLOCK)
+                        return -EAGAIN;
+                return -ERESTARTSYS;
+        }
+
+        /* lock io */
+        if (wait_event_interruptible
+            (dev->ioq,
+             ((filp->f_flags & O_NONBLOCK)
+              || (test_and_set_bit(LOCK_IO, (void *)&dev->flags) == 0)))) {
+                if (filp->f_flags & O_NONBLOCK)
+                        return -EAGAIN;
+                return -ERESTARTSYS;
+        }
+
+        rc = 0;
+        dev->flags0 = inb(REG_FLAGS0(iobase));
+        if ((dev->flags0 & 1) == 0      /* no smartcard inserted */
+            || dev->flags0 == 0xff) {   /* no cardman inserted */
+                clear_bit(IS_ATR_VALID, &dev->flags);
+                if (dev->flags0 & 1) {
+                        set_bit(IS_CMM_ABSENT, &dev->flags);
+                        rc = -ENODEV;
+                }
+                rc = -EIO;
+                goto release_io;
+        }
+
+        DEBUGP(4, dev, "begin read answer\n");
+        j = min(count, (size_t)(dev->rlen - dev->rpos));
+        k = dev->rpos;
+        if (k + j > 255)
+                j = 256 - k;
+        DEBUGP(4, dev, "read1 j=%d\n", j);
+        for (i = 0; i < j; i++) {
+                xoutb(k++, REG_BUF_ADDR(iobase));
+                dev->rbuf[i] = xinb(REG_BUF_DATA(iobase));
+        }
+        j = min(count, (size_t)(dev->rlen - dev->rpos));
+        if (k + j > 255) {
+                DEBUGP(4, dev, "read2 j=%d\n", j);
+                dev->flags1 |= 0x10;    /* MSB buf addr set */
+                xoutb(dev->flags1, REG_FLAGS1(iobase));
+                for (; i < j; i++) {
+                        xoutb(k++, REG_BUF_ADDR(iobase));
+                        dev->rbuf[i] = xinb(REG_BUF_DATA(iobase));
+                }
+        }
+
+        if (dev->proto == 0 && count > dev->rlen - dev->rpos) {
+                DEBUGP(4, dev, "T=0 and count > buffer\n");
+                dev->rbuf[i] = dev->rbuf[i - 1];
+                dev->rbuf[i - 1] = dev->procbyte;
+                j++;
+        }
+        count = j;
+
+        dev->rpos = dev->rlen + 1;
+
+        /* Clear T1Active */
+        DEBUGP(4, dev, "Clear T1Active\n");
+        dev->flags1 &= 0xdf;
+        xoutb(dev->flags1, REG_FLAGS1(iobase));
+
+        xoutb(0, REG_FLAGS1(iobase));   /* clear detectCMM */
+        /* last check before exit */
+        if (!io_detect_cm4000(iobase, dev))
+                count = -ENODEV;
+
+        if (test_bit(IS_INVREV, &dev->flags) && count > 0)
+                str_invert_revert(dev->rbuf, count);
+
+        if (copy_to_user(buf, dev->rbuf, count))
+                return -EFAULT;
+
+release_io:
+        clear_bit(LOCK_IO, &dev->flags);
+        wake_up_interruptible(&dev->ioq);
+
+        DEBUGP(2, dev, "<- cmm_read returns: rc = %Zi\n",
+               (rc < 0 ? rc : count));
+        return rc < 0 ? rc : count;
+}
+
+static ssize_t cmm_write(struct file *filp, const char __user *buf,
+                         size_t count, loff_t *ppos)
+{
+        struct cm4000_dev *dev = (struct cm4000_dev *) filp->private_data;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+        unsigned short s;
+        unsigned char tmp;
+        unsigned char infolen;
+        unsigned char sendT0;
+        unsigned short nsend;
+        unsigned short nr;
+        ssize_t rc;
+        int i;
+
+        DEBUGP(2, dev, "-> cmm_write(%s,%d)\n", current->comm, current->pid);
+
+        if (count == 0)         /* according to manpage */
+                return 0;
+
+        if (dev->proto == 0 && count < 4) {
+                /* T0 must have at least 4 bytes */
+                DEBUGP(4, dev, "T0 short write\n");
+                return -EIO;
+        }
+
+        nr = count & 0x1ff;     /* max bytes to write */
+
+        sendT0 = dev->proto ? 0 : nr > 5 ? 0x08 : 0;
+
+        if ((dev->link.state & DEV_PRESENT) == 0 ||     /* socket removed */
+            test_bit(IS_CMM_ABSENT, &dev->flags))
+                return -ENODEV;
+
+        if (test_bit(IS_BAD_CSUM, &dev->flags)) {
+                DEBUGP(4, dev, "bad csum\n");
+                return -EIO;
+        }
+
+        /*
+         * wait for atr to become valid.
+         * note: it is important to lock this code. if we dont, the monitor
+         * could be run between test_bit and the the call the sleep on the
+         * atr-queue.  if *then* the monitor detects atr valid, it will wake up
+         * any process on the atr-queue, *but* since we have been interrupted,
+         * we do not yet sleep on this queue. this would result in a missed
+         * wake_up and the calling process would sleep forever (until
+         * interrupted).  also, do *not* restore_flags before sleep_on, because
+         * this could result in the same situation!
+         */
+        if (wait_event_interruptible
+            (dev->atrq,
+             ((filp->f_flags & O_NONBLOCK)
+              || (test_bit(IS_ATR_PRESENT, (void *)&dev->flags) != 0)))) {
+                if (filp->f_flags & O_NONBLOCK)
+                        return -EAGAIN;
+                return -ERESTARTSYS;
+        }
+
+        if (test_bit(IS_ATR_VALID, &dev->flags) == 0) { /* invalid atr */
+                DEBUGP(4, dev, "invalid ATR\n");
+                return -EIO;
+        }
+
+        /* lock io */
+        if (wait_event_interruptible
+            (dev->ioq,
+             ((filp->f_flags & O_NONBLOCK)
+              || (test_and_set_bit(LOCK_IO, (void *)&dev->flags) == 0)))) {
+                if (filp->f_flags & O_NONBLOCK)
+                        return -EAGAIN;
+                return -ERESTARTSYS;
+        }
+
+        if (copy_from_user(dev->sbuf, buf, ((count > 512) ? 512 : count)))
+                return -EFAULT;
+
+        rc = 0;
+        dev->flags0 = inb(REG_FLAGS0(iobase));
+        if ((dev->flags0 & 1) == 0      /* no smartcard inserted */
+            || dev->flags0 == 0xff) {   /* no cardman inserted */
+                clear_bit(IS_ATR_VALID, &dev->flags);
+                if (dev->flags0 & 1) {
+                        set_bit(IS_CMM_ABSENT, &dev->flags);
+                        rc = -ENODEV;
+                } else {
+                        DEBUGP(4, dev, "IO error\n");
+                        rc = -EIO;
+                }
+                goto release_io;
+        }
+
+        xoutb(0x80, REG_FLAGS0(iobase));        /* reset SM  */
+
+        if (!io_detect_cm4000(iobase, dev)) {
+                rc = -ENODEV;
+                goto release_io;
+        }
+
+        /* reflect T=0 send/read mode in flags1 */
+        dev->flags1 |= (sendT0);
+
+        set_cardparameter(dev);
+
+        /* dummy read, reset flag procedure received */
+        tmp = inb(REG_FLAGS1(iobase));
+
+        dev->flags1 = 0x20      /* T_Active */
+            | (sendT0)
+            | (test_bit(IS_INVREV, &dev->flags) ? 2 : 0)/* inverse parity  */
+            | (((dev->baudv - 1) & 0x0100) >> 8);       /* MSB-Baud */
+        DEBUGP(1, dev, "set dev->flags1 = 0x%.2x\n", dev->flags1);
+        xoutb(dev->flags1, REG_FLAGS1(iobase));
+
+        /* xmit data */
+        DEBUGP(4, dev, "Xmit data\n");
+        for (i = 0; i < nr; i++) {
+                if (i >= 256) {
+                        dev->flags1 = 0x20      /* T_Active */
+                            | (sendT0)  /* SendT0 */
+                                /* inverse parity: */
+                            | (test_bit(IS_INVREV, &dev->flags) ? 2 : 0)
+                            | (((dev->baudv - 1) & 0x0100) >> 8) /* MSB-Baud */
+                            | 0x10;     /* set address high */
+                        DEBUGP(4, dev, "dev->flags = 0x%.2x - set address "
+                               "high\n", dev->flags1);
+                        xoutb(dev->flags1, REG_FLAGS1(iobase));
+                }
+                if (test_bit(IS_INVREV, &dev->flags)) {
+                        DEBUGP(4, dev, "Apply inverse convention for 0x%.2x "
+                                "-> 0x%.2x\n", (unsigned char)dev->sbuf[i],
+                              invert_revert(dev->sbuf[i]));
+                        xoutb(i, REG_BUF_ADDR(iobase));
+                        xoutb(invert_revert(dev->sbuf[i]),
+                              REG_BUF_DATA(iobase));
+                } else {
+                        xoutb(i, REG_BUF_ADDR(iobase));
+                        xoutb(dev->sbuf[i], REG_BUF_DATA(iobase));
+                }
+        }
+        DEBUGP(4, dev, "Xmit done\n");
+
+        if (dev->proto == 0) {
+                /* T=0 proto: 0 byte reply  */
+                if (nr == 4) {
+                        DEBUGP(4, dev, "T=0 assumes 0 byte reply\n");
+                        xoutb(i, REG_BUF_ADDR(iobase));
+                        if (test_bit(IS_INVREV, &dev->flags))
+                                xoutb(0xff, REG_BUF_DATA(iobase));
+                        else
+                                xoutb(0x00, REG_BUF_DATA(iobase));
+                }
+
+                /* numSendBytes */
+                if (sendT0)
+                        nsend = nr;
+                else {
+                        if (nr == 4)
+                                nsend = 5;
+                        else {
+                                nsend = 5 + (unsigned char)dev->sbuf[4];
+                                if (dev->sbuf[4] == 0)
+                                        nsend += 0x100;
+                        }
+                }
+        } else
+                nsend = nr;
+
+        /* T0: output procedure byte */
+        if (test_bit(IS_INVREV, &dev->flags)) {
+                DEBUGP(4, dev, "T=0 set Procedure byte (inverse-reverse) "
+                       "0x%.2x\n", invert_revert(dev->sbuf[1]));
+                xoutb(invert_revert(dev->sbuf[1]), REG_NUM_BYTES(iobase));
+        } else {
+                DEBUGP(4, dev, "T=0 set Procedure byte 0x%.2x\n", dev->sbuf[1]);
+                xoutb(dev->sbuf[1], REG_NUM_BYTES(iobase));
+        }
+
+        DEBUGP(1, dev, "set NumSendBytes = 0x%.2x\n",
+               (unsigned char)(nsend & 0xff));
+        xoutb((unsigned char)(nsend & 0xff), REG_NUM_SEND(iobase));
+
+        DEBUGP(1, dev, "Trigger CARDMAN CONTROLLER (0x%.2x)\n",
+               0x40     /* SM_Active */
+              | (dev->flags0 & 2 ? 0 : 4)       /* power on if needed */
+              |(dev->proto ? 0x10 : 0x08)       /* T=1/T=0 */
+              |(nsend & 0x100) >> 8 /* MSB numSendBytes */ );
+        xoutb(0x40              /* SM_Active */
+              | (dev->flags0 & 2 ? 0 : 4)       /* power on if needed */
+              |(dev->proto ? 0x10 : 0x08)       /* T=1/T=0 */
+              |(nsend & 0x100) >> 8,    /* MSB numSendBytes */
+              REG_FLAGS0(iobase));
+
+        /* wait for xmit done */
+        if (dev->proto == 1) {
+                DEBUGP(4, dev, "Wait for xmit done\n");
+                for (i = 0; i < 1000; i++) {
+                        if (inb(REG_FLAGS0(iobase)) & 0x08)
+                                break;
+                        msleep_interruptible(10);
+                }
+                if (i == 1000) {
+                        DEBUGP(4, dev, "timeout waiting for xmit done\n");
+                        rc = -EIO;
+                        goto release_io;
+                }
+        }
+
+        /* T=1: wait for infoLen */
+
+        infolen = 0;
+        if (dev->proto) {
+                /* wait until infoLen is valid */
+                for (i = 0; i < 6000; i++) {    /* max waiting time of 1 min */
+                        io_read_num_rec_bytes(iobase, &s);
+                        if (s >= 3) {
+                                infolen = inb(REG_FLAGS1(iobase));
+                                DEBUGP(4, dev, "infolen=%d\n", infolen);
+                                break;
+                        }
+                        msleep_interruptible(10);
+                }
+                if (i == 6000) {
+                        DEBUGP(4, dev, "timeout waiting for infoLen\n");
+                        rc = -EIO;
+                        goto release_io;
+                }
+        } else
+                clear_bit(IS_PROCBYTE_PRESENT, &dev->flags);
+
+        /* numRecBytes | bit9 of numRecytes */
+        io_read_num_rec_bytes(iobase, &dev->rlen);
+        for (i = 0; i < 600; i++) {     /* max waiting time of 2 sec */
+                if (dev->proto) {
+                        if (dev->rlen >= infolen + 4)
+                                break;
+                }
+                msleep_interruptible(10);
+                /* numRecBytes | bit9 of numRecytes */
+                io_read_num_rec_bytes(iobase, &s);
+                if (s > dev->rlen) {
+                        DEBUGP(1, dev, "NumRecBytes inc (reset timeout)\n");
+                        i = 0;  /* reset timeout */
+                        dev->rlen = s;
+                }
+                /* T=0: we are done when numRecBytes doesn't
+                 *      increment any more and NoProcedureByte
+                 *      is set and numRecBytes == bytes sent + 6
+                 *      (header bytes + data + 1 for sw2)
+                 *      except when the card replies an error
+                 *      which means, no data will be sent back.
+                 */
+                else if (dev->proto == 0) {
+                        if ((inb(REG_BUF_ADDR(iobase)) & 0x80)) {
+                                /* no procedure byte received since last read */
+                                DEBUGP(1, dev, "NoProcedure byte set\n");
+                                /* i=0; */
+                        } else {
+                                /* procedure byte received since last read */
+                                DEBUGP(1, dev, "NoProcedure byte unset "
+                                        "(reset timeout)\n");
+                                dev->procbyte = inb(REG_FLAGS1(iobase));
+                                DEBUGP(1, dev, "Read procedure byte 0x%.2x\n",
+                                      dev->procbyte);
+                                i = 0;  /* resettimeout */
+                        }
+                        if (inb(REG_FLAGS0(iobase)) & 0x08) {
+                                DEBUGP(1, dev, "T0Done flag (read reply)\n");
+                                break;
+                        }
+                }
+                if (dev->proto)
+                        infolen = inb(REG_FLAGS1(iobase));
+        }
+        if (i == 600) {
+                DEBUGP(1, dev, "timeout waiting for numRecBytes\n");
+                rc = -EIO;
+                goto release_io;
+        } else {
+                if (dev->proto == 0) {
+                        DEBUGP(1, dev, "Wait for T0Done bit to be  set\n");
+                        for (i = 0; i < 1000; i++) {
+                                if (inb(REG_FLAGS0(iobase)) & 0x08)
+                                        break;
+                                msleep_interruptible(10);
+                        }
+                        if (i == 1000) {
+                                DEBUGP(1, dev, "timeout waiting for T0Done\n");
+                                rc = -EIO;
+                                goto release_io;
+                        }
+
+                        dev->procbyte = inb(REG_FLAGS1(iobase));
+                        DEBUGP(4, dev, "Read procedure byte 0x%.2x\n",
+                              dev->procbyte);
+
+                        io_read_num_rec_bytes(iobase, &dev->rlen);
+                        DEBUGP(4, dev, "Read NumRecBytes = %i\n", dev->rlen);
+
+                }
+        }
+        /* T=1: read offset=zero, T=0: read offset=after challenge */
+        dev->rpos = dev->proto ? 0 : nr == 4 ? 5 : nr > dev->rlen ? 5 : nr;
+        DEBUGP(4, dev, "dev->rlen = %i,  dev->rpos = %i, nr = %i\n",
+              dev->rlen, dev->rpos, nr);
+
+release_io:
+        DEBUGP(4, dev, "Reset SM\n");
+        xoutb(0x80, REG_FLAGS0(iobase));        /* reset SM */
+
+        if (rc < 0) {
+                DEBUGP(4, dev, "Write failed but clear T_Active\n");
+                dev->flags1 &= 0xdf;
+                xoutb(dev->flags1, REG_FLAGS1(iobase));
+        }
+
+        clear_bit(LOCK_IO, &dev->flags);
+        wake_up_interruptible(&dev->ioq);
+        wake_up_interruptible(&dev->readq);     /* tell read we have data */
+
+        /* ITSEC E2: clear write buffer */
+        memset((char *)dev->sbuf, 0, 512);
+
+        /* return error or actually written bytes */
+        DEBUGP(2, dev, "<- cmm_write\n");
+        return rc < 0 ? rc : nr;
+}
+
+static void start_monitor(struct cm4000_dev *dev)
+{
+        DEBUGP(3, dev, "-> start_monitor\n");
+        if (!dev->monitor_running) {
+                DEBUGP(5, dev, "create, init and add timer\n");
+                init_timer(&dev->timer);
+                dev->monitor_running = 1;
+                dev->timer.expires = jiffies;
+                dev->timer.data = (unsigned long) dev;
+                dev->timer.function = monitor_card;
+                add_timer(&dev->timer);
+        } else
+                DEBUGP(5, dev, "monitor already running\n");
+        DEBUGP(3, dev, "<- start_monitor\n");
+}
+
+static void stop_monitor(struct cm4000_dev *dev)
+{
+        DEBUGP(3, dev, "-> stop_monitor\n");
+        if (dev->monitor_running) {
+                DEBUGP(5, dev, "stopping monitor\n");
+                terminate_monitor(dev);
+                /* reset monitor SM */
+                clear_bit(IS_ATR_VALID, &dev->flags);
+                clear_bit(IS_ATR_PRESENT, &dev->flags);
+        } else
+                DEBUGP(5, dev, "monitor already stopped\n");
+        DEBUGP(3, dev, "<- stop_monitor\n");
+}
+
+static int cmm_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
+                     unsigned long arg)
+{
+        struct cm4000_dev *dev = filp->private_data;
+        ioaddr_t iobase = dev->link.io.BasePort1;
+        dev_link_t *link;
+        int size;
+        int rc;
+#ifdef PCMCIA_DEBUG
+        char *ioctl_names[CM_IOC_MAXNR + 1] = {
+                [_IOC_NR(CM_IOCGSTATUS)] "CM_IOCGSTATUS",
+                [_IOC_NR(CM_IOCGATR)] "CM_IOCGATR",
+                [_IOC_NR(CM_IOCARDOFF)] "CM_IOCARDOFF",
+                [_IOC_NR(CM_IOCSPTS)] "CM_IOCSPTS",
+                [_IOC_NR(CM_IOSDBGLVL)] "CM4000_DBGLVL",
+        };
+#endif
+        DEBUGP(3, dev, "cmm_ioctl(device=%d.%d) %s\n", imajor(inode),
+               iminor(inode), ioctl_names[_IOC_NR(cmd)]);
+
+        link = dev_table[iminor(inode)];
+        if (!(DEV_OK(link))) {
+                DEBUGP(4, dev, "DEV_OK false\n");
+                return -ENODEV;
+        }
+
+        if (test_bit(IS_CMM_ABSENT, &dev->flags)) {
+                DEBUGP(4, dev, "CMM_ABSENT flag set\n");
+                return -ENODEV;
+        }
+
+        if (_IOC_TYPE(cmd) != CM_IOC_MAGIC) {
+                DEBUGP(4, dev, "ioctype mismatch\n");
+                return -EINVAL;
+        }
+        if (_IOC_NR(cmd) > CM_IOC_MAXNR) {
+                DEBUGP(4, dev, "iocnr mismatch\n");
+                return -EINVAL;
+        }
+        size = _IOC_SIZE(cmd);
+        rc = 0;
+        DEBUGP(4, dev, "iocdir=%.4x iocr=%.4x iocw=%.4x iocsize=%d cmd=%.4x\n",
+              _IOC_DIR(cmd), _IOC_READ, _IOC_WRITE, size, cmd);
+
+        if (_IOC_DIR(cmd) & _IOC_READ) {
+                if (!access_ok(VERIFY_WRITE, (void *)arg, size))
+                        return -EFAULT;
+        }
+        if (_IOC_DIR(cmd) & _IOC_WRITE) {
+                if (!access_ok(VERIFY_READ, (void *)arg, size))
+                        return -EFAULT;
+        }
+
+        switch (cmd) {
+        case CM_IOCGSTATUS:
+                DEBUGP(4, dev, " ... in CM_IOCGSTATUS\n");
+                {
+                        int status;
+
+                        /* clear other bits, but leave inserted & powered as
+                         * they are */
+                        status = dev->flags0 & 3;
+                        if (test_bit(IS_ATR_PRESENT, &dev->flags))
+                                status |= CM_ATR_PRESENT;
+                        if (test_bit(IS_ATR_VALID, &dev->flags))
+                                status |= CM_ATR_VALID;
+                        if (test_bit(IS_CMM_ABSENT, &dev->flags))
+                                status |= CM_NO_READER;
+                        if (test_bit(IS_BAD_CARD, &dev->flags))
+                                status |= CM_BAD_CARD;
+                        if (copy_to_user((int *)arg, &status, sizeof(int)))
+                                return -EFAULT;
+                }
+                return 0;
+        case CM_IOCGATR:
+                DEBUGP(4, dev, "... in CM_IOCGATR\n");
+                {
+                        struct atreq *atreq = (struct atreq *) arg;
+                        int tmp;
+                        /* allow nonblocking io and being interrupted */
+                        if (wait_event_interruptible
+                            (dev->atrq,
+                             ((filp->f_flags & O_NONBLOCK)
+                              || (test_bit(IS_ATR_PRESENT, (void *)&dev->flags)
+                                  != 0)))) {
+                                if (filp->f_flags & O_NONBLOCK)
+                                        return -EAGAIN;
+                                return -ERESTARTSYS;
+                        }
+
+                        if (test_bit(IS_ATR_VALID, &dev->flags) == 0) {
+                                tmp = -1;
+                                if (copy_to_user(&(atreq->atr_len), &tmp,
+                                                 sizeof(int)))
+                                        return -EFAULT;
+                        } else {
+                                if (copy_to_user(atreq->atr, dev->atr,
+                                                 dev->atr_len))
+                                        return -EFAULT;
+
+                                tmp = dev->atr_len;
+                                if (copy_to_user(&(atreq->atr_len), &tmp, sizeof(int)))
+                                        return -EFAULT;
+                        }
+                        return 0;
+                }
+        case CM_IOCARDOFF:
+
+#ifdef PCMCIA_DEBUG
+                DEBUGP(4, dev, "... in CM_IOCARDOFF\n");
+                if (dev->flags0 & 0x01) {
+                        DEBUGP(4, dev, "    Card inserted\n");
+                } else {
+                        DEBUGP(2, dev, "    No card inserted\n");
+                }
+                if (dev->flags0 & 0x02) {
+                        DEBUGP(4, dev, "    Card powered\n");
+                } else {
+                        DEBUGP(2, dev, "    Card not powered\n");
+                }
+#endif
+
+                /* is a card inserted and powered? */
+                if ((dev->flags0 & 0x01) && (dev->flags0 & 0x02)) {
+
+                        /* get IO lock */
+                        if (wait_event_interruptible
+                            (dev->ioq,
+                             ((filp->f_flags & O_NONBLOCK)
+                              || (test_and_set_bit(LOCK_IO, (void *)&dev->flags)
+                                  == 0)))) {
+                                if (filp->f_flags & O_NONBLOCK)
+                                        return -EAGAIN;
+                                return -ERESTARTSYS;
+                        }
+                        /* Set Flags0 = 0x42 */
+                        DEBUGP(4, dev, "Set Flags0=0x42 \n");
+                        xoutb(0x42, REG_FLAGS0(iobase));
+                        clear_bit(IS_ATR_PRESENT, &dev->flags);
+                        clear_bit(IS_ATR_VALID, &dev->flags);
+                        dev->mstate = M_CARDOFF;
+                        clear_bit(LOCK_IO, &dev->flags);
+                        if (wait_event_interruptible
+                            (dev->atrq,
+                             ((filp->f_flags & O_NONBLOCK)
+                              || (test_bit(IS_ATR_VALID, (void *)&dev->flags) !=
+                                  0)))) {
+                                if (filp->f_flags & O_NONBLOCK)
+                                        return -EAGAIN;
+                                return -ERESTARTSYS;
+                        }
+                }
+                /* release lock */
+                clear_bit(LOCK_IO, &dev->flags);
+                wake_up_interruptible(&dev->ioq);
+
+                return 0;
+        case CM_IOCSPTS:
+                {
+                        struct ptsreq krnptsreq;
+
+                        if (copy_from_user(&krnptsreq, (struct ptsreq *) arg,
+                                           sizeof(struct ptsreq)))
+                                return -EFAULT;
+
+                        rc = 0;
+                        DEBUGP(4, dev, "... in CM_IOCSPTS\n");
+                        /* wait for ATR to get valid */
+                        if (wait_event_interruptible
+                            (dev->atrq,
+                             ((filp->f_flags & O_NONBLOCK)
+                              || (test_bit(IS_ATR_PRESENT, (void *)&dev->flags)
+                                  != 0)))) {
+                                if (filp->f_flags & O_NONBLOCK)
+                                        return -EAGAIN;
+                                return -ERESTARTSYS;
+                        }
+                        /* get IO lock */
+                        if (wait_event_interruptible
+                            (dev->ioq,
+                             ((filp->f_flags & O_NONBLOCK)
+                              || (test_and_set_bit(LOCK_IO, (void *)&dev->flags)
+                                  == 0)))) {
+                                if (filp->f_flags & O_NONBLOCK)
+                                        return -EAGAIN;
+                                return -ERESTARTSYS;
+                        }
+
+                        if ((rc = set_protocol(dev, &krnptsreq)) != 0) {
+                                /* auto power_on again */
+                                dev->mstate = M_FETCH_ATR;
+                                clear_bit(IS_ATR_VALID, &dev->flags);
+                        }
+                        /* release lock */
+                        clear_bit(LOCK_IO, &dev->flags);
+                        wake_up_interruptible(&dev->ioq);
+
+                }
+                return rc;
+#ifdef PCMCIA_DEBUG
+        case CM_IOSDBGLVL:      /* set debug log level */
+                {
+                        int old_pc_debug = 0;
+
+                        old_pc_debug = pc_debug;
+                        if (copy_from_user(&pc_debug, (int *)arg, sizeof(int)))
+                                return -EFAULT;
+
+                        if (old_pc_debug != pc_debug)
+                                DEBUGP(0, dev, "Changed debug log level "
+                                       "to %i\n", pc_debug);
+                }
+                return rc;
+#endif
+        default:
+                DEBUGP(4, dev, "... in default (unknown IOCTL code)\n");
+                return -EINVAL;
+        }
+}
+
+static int cmm_open(struct inode *inode, struct file *filp)
+{
+        struct cm4000_dev *dev;
+        dev_link_t *link;
+        int rc, minor = iminor(inode);
+
+        if (minor >= CM4000_MAX_DEV)
+                return -ENODEV;
+
+        link = dev_table[minor];
+        if (link == NULL || !(DEV_OK(link)))
+                return -ENODEV;
+
+        if (link->open)
+                return -EBUSY;
+
+        dev = link->priv;
+        filp->private_data = dev;
+
+        DEBUGP(2, dev, "-> cmm_open(device=%d.%d process=%s,%d)\n",
+              imajor(inode), minor, current->comm, current->pid);
+
+        /* init device variables, they may be "polluted" after close
+         * or, the device may never have been closed (i.e. open failed)
+         */
+
+        ZERO_DEV(dev);
+
+        /* opening will always block since the
+         * monitor will be started by open, which
+         * means we have to wait for ATR becoming
+         * vaild = block until valid (or card
+         * inserted)
+         */
+        if (filp->f_flags & O_NONBLOCK)
+                return -EAGAIN;
+
+        dev->mdelay = T_50MSEC;
+
+        /* start monitoring the cardstatus */
+        start_monitor(dev);
+
+        link->open = 1;         /* only one open per device */
+        rc = 0;
+
+        DEBUGP(2, dev, "<- cmm_open\n");
+        return nonseekable_open(inode, filp);
+}
+
+static int cmm_close(struct inode *inode, struct file *filp)
+{
+        struct cm4000_dev *dev;
+        dev_link_t *link;
+        int minor = iminor(inode);
+
+        if (minor >= CM4000_MAX_DEV)
+                return -ENODEV;
+
+        link = dev_table[minor];
+        if (link == NULL)
+                return -ENODEV;
+
+        dev = link->priv;
+
+        DEBUGP(2, dev, "-> cmm_close(maj/min=%d.%d)\n",
+               imajor(inode), minor);
+
+        stop_monitor(dev);
+
+        ZERO_DEV(dev);
+
+        link->open = 0;         /* only one open per device */
+        wake_up(&dev->devq);    /* socket removed? */
+
+        DEBUGP(2, dev, "cmm_close\n");
+        return 0;
+}
+
+static void cmm_cm4000_release(dev_link_t * link)
+{
+        struct cm4000_dev *dev = link->priv;
+
+        /* dont terminate the monitor, rather rely on
+         * close doing that for us.
+         */
+        DEBUGP(3, dev, "-> cmm_cm4000_release\n");
+        while (link->open) {
+                printk(KERN_INFO MODULE_NAME ": delaying release until "
+                       "process has terminated\n");
+                /* note: don't interrupt us:
+                 * close the applications which own
+                 * the devices _first_ !
+                 */
+                wait_event(dev->devq, (link->open == 0));
+        }
+        /* dev->devq=NULL;      this cannot be zeroed earlier */
+        DEBUGP(3, dev, "<- cmm_cm4000_release\n");
+        return;
+}
+
+/*==== Interface to PCMCIA Layer =======================================*/
+
+static void cm4000_config(dev_link_t * link, int devno)
+{
+        client_handle_t handle = link->handle;
+        struct cm4000_dev *dev;
+        tuple_t tuple;
+        cisparse_t parse;
+        config_info_t conf;
+        u_char buf[64];
+        int fail_fn, fail_rc;
+        int rc;
+
+        /* read the config-tuples */
+        tuple.DesiredTuple = CISTPL_CONFIG;
+        tuple.Attributes = 0;
+        tuple.TupleData = buf;
+        tuple.TupleDataMax = sizeof(buf);
+        tuple.TupleOffset = 0;
+
+        if ((fail_rc = pcmcia_get_first_tuple(handle, &tuple)) != CS_SUCCESS) {
+                fail_fn = GetFirstTuple;
+                goto cs_failed;
+        }
+        if ((fail_rc = pcmcia_get_tuple_data(handle, &tuple)) != CS_SUCCESS) {
+                fail_fn = GetTupleData;
+                goto cs_failed;
+        }
+        if ((fail_rc =
+             pcmcia_parse_tuple(handle, &tuple, &parse)) != CS_SUCCESS) {
+                fail_fn = ParseTuple;
+                goto cs_failed;
+        }
+        if ((fail_rc =
+             pcmcia_get_configuration_info(handle, &conf)) != CS_SUCCESS) {
+                fail_fn = GetConfigurationInfo;
+                goto cs_failed;
+        }
+
+        link->state |= DEV_CONFIG;
+        link->conf.ConfigBase = parse.config.base;
+        link->conf.Present = parse.config.rmask[0];
+        link->conf.Vcc = conf.Vcc;
+
+        link->io.BasePort2 = 0;
+        link->io.NumPorts2 = 0;
+        link->io.Attributes2 = 0;
+        tuple.DesiredTuple = CISTPL_CFTABLE_ENTRY;
+        for (rc = pcmcia_get_first_tuple(handle, &tuple);
+             rc == CS_SUCCESS; rc = pcmcia_get_next_tuple(handle, &tuple)) {
+
+                rc = pcmcia_get_tuple_data(handle, &tuple);
+                if (rc != CS_SUCCESS)
+                        continue;
+                rc = pcmcia_parse_tuple(handle, &tuple, &parse);
+                if (rc != CS_SUCCESS)
+                        continue;
+
+                link->conf.ConfigIndex = parse.cftable_entry.index;
+
+                if (!parse.cftable_entry.io.nwin)
+                        continue;
+
+                /* Get the IOaddr */
+                link->io.BasePort1 = parse.cftable_entry.io.win[0].base;
+                link->io.NumPorts1 = parse.cftable_entry.io.win[0].len;
+                link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
+                if (!(parse.cftable_entry.io.flags & CISTPL_IO_8BIT))
+                        link->io.Attributes1 = IO_DATA_PATH_WIDTH_16;
+                if (!(parse.cftable_entry.io.flags & CISTPL_IO_16BIT))
+                        link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
+                link->io.IOAddrLines = parse.cftable_entry.io.flags
+                    & CISTPL_IO_LINES_MASK;
+
+                rc = pcmcia_request_io(handle, &link->io);
+                if (rc == CS_SUCCESS)
+                        break;  /* we are done */
+        }
+        if (rc != CS_SUCCESS)
+                goto cs_release;
+
+        link->conf.IntType = 00000002;
+
+        if ((fail_rc =
+             pcmcia_request_configuration(handle, &link->conf)) != CS_SUCCESS) {
+                fail_fn = RequestConfiguration;
+                goto cs_release;
+        }
+
+        dev = link->priv;
+        sprintf(dev->node.dev_name, DEVICE_NAME "%d", devno);
+        dev->node.major = major;
+        dev->node.minor = devno;
+        dev->node.next = NULL;
+        link->dev = &dev->node;
+        link->state &= ~DEV_CONFIG_PENDING;
+
+        return;
+
+cs_failed:
+        cs_error(handle, fail_fn, fail_rc);
+cs_release:
+        cm4000_release(link);
+
+        link->state &= ~DEV_CONFIG_PENDING;
+}
+
+static int cm4000_event(event_t event, int priority,
+                        event_callback_args_t *args)
+{
+        dev_link_t *link;
+        struct cm4000_dev *dev;
+        int devno;
+
+        link = args->client_data;
+        dev = link->priv;
+
+        DEBUGP(3, dev, "-> cm4000_event\n");
+        for (devno = 0; devno < CM4000_MAX_DEV; devno++)
+                if (dev_table[devno] == link)
+                        break;
+
+        if (devno == CM4000_MAX_DEV)
+                return CS_BAD_ADAPTER;
+
+        switch (event) {
+        case CS_EVENT_CARD_INSERTION:
+                DEBUGP(5, dev, "CS_EVENT_CARD_INSERTION\n");
+                link->state |= DEV_PRESENT | DEV_CONFIG_PENDING;
+                cm4000_config(link, devno);
+                break;
+        case CS_EVENT_CARD_REMOVAL:
+                DEBUGP(5, dev, "CS_EVENT_CARD_REMOVAL\n");
+                link->state &= ~DEV_PRESENT;
+                stop_monitor(dev);
+                break;
+        case CS_EVENT_PM_SUSPEND:
+                DEBUGP(5, dev, "CS_EVENT_PM_SUSPEND "
+                      "(fall-through to CS_EVENT_RESET_PHYSICAL)\n");
+                link->state |= DEV_SUSPEND;
+                /* fall-through */
+        case CS_EVENT_RESET_PHYSICAL:
+                DEBUGP(5, dev, "CS_EVENT_RESET_PHYSICAL\n");
+                if (link->state & DEV_CONFIG) {
+                        DEBUGP(5, dev, "ReleaseConfiguration\n");
+                        pcmcia_release_configuration(link->handle);
+                }
+                stop_monitor(dev);
+                break;
+        case CS_EVENT_PM_RESUME:
+                DEBUGP(5, dev, "CS_EVENT_PM_RESUME "
+                      "(fall-through to CS_EVENT_CARD_RESET)\n");
+                link->state &= ~DEV_SUSPEND;
+                /* fall-through */
+        case CS_EVENT_CARD_RESET:
+                DEBUGP(5, dev, "CS_EVENT_CARD_RESET\n");
+                if ((link->state & DEV_CONFIG)) {
+                        DEBUGP(5, dev, "RequestConfiguration\n");
+                        pcmcia_request_configuration(link->handle, &link->conf);
+                }
+                if (link->open)
+                        start_monitor(dev);
+                break;
+        default:
+                DEBUGP(5, dev, "unknown event %.2x\n", event);
+                break;
+        }
+        DEBUGP(3, dev, "<- cm4000_event\n");
+        return CS_SUCCESS;
+}
+
+static void cm4000_release(dev_link_t *link)
+{
+        cmm_cm4000_release(link->priv); /* delay release until device closed */
+        pcmcia_release_configuration(link->handle);
+        pcmcia_release_io(link->handle, &link->io);
+}
+
+static dev_link_t *cm4000_attach(void)
+{
+        struct cm4000_dev *dev;
+        dev_link_t *link;
+        client_reg_t client_reg;
+        int i;
+
+        for (i = 0; i < CM4000_MAX_DEV; i++)
+                if (dev_table[i] == NULL)
+                        break;
+
+        if (i == CM4000_MAX_DEV) {
+                printk(KERN_NOTICE MODULE_NAME ": all devices in use\n");
+                return NULL;
+        }
+
+        /* create a new cm4000_cs device */
+        dev = kzalloc(sizeof(struct cm4000_dev), GFP_KERNEL);
+        if (dev == NULL)
+                return NULL;
+
+        link = &dev->link;
+        link->priv = dev;
+        link->conf.IntType = INT_MEMORY_AND_IO;
+        dev_table[i] = link;
+
+        /* register with card services */
+        client_reg.dev_info = &dev_info;
+        client_reg.EventMask =
+            CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL |
+            CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET |
+            CS_EVENT_PM_SUSPEND | CS_EVENT_PM_RESUME;
+        client_reg.Version = 0x0210;
+        client_reg.event_callback_args.client_data = link;
+
+        i = pcmcia_register_client(&link->handle, &client_reg);
+        if (i) {
+                cs_error(link->handle, RegisterClient, i);
+                cm4000_detach(link);
+                return NULL;
+        }
+
+        init_waitqueue_head(&dev->devq);
+        init_waitqueue_head(&dev->ioq);
+        init_waitqueue_head(&dev->atrq);
+        init_waitqueue_head(&dev->readq);
+
+        return link;
+}
+
+static void cm4000_detach_by_devno(int devno, dev_link_t * link)
+{
+        struct cm4000_dev *dev = link->priv;
+
+        DEBUGP(3, dev, "-> detach_by_devno(devno=%d)\n", devno);
+
+        if (link->state & DEV_CONFIG) {
+                DEBUGP(5, dev, "device still configured (try to release it)\n");
+                cm4000_release(link);
+        }
+
+        if (link->handle) {
+                pcmcia_deregister_client(link->handle);
+        }
+
+        dev_table[devno] = NULL;
+        kfree(dev);
+        return;
+}
+
+static void cm4000_detach(dev_link_t * link)
+{
+        int i;
+
+        /* find device */
+        for (i = 0; i < CM4000_MAX_DEV; i++)
+                if (dev_table[i] == link)
+                        break;
+
+        if (i == CM4000_MAX_DEV)
+                return;
+
+        cm4000_detach_by_devno(i, link);
+        return;
+}
+
+static struct file_operations cm4000_fops = {
+        .owner  = THIS_MODULE,
+        .read   = cmm_read,
+        .write  = cmm_write,
+        .ioctl  = cmm_ioctl,
+        .open   = cmm_open,
+        .release= cmm_close,
+};
+
+static struct pcmcia_device_id cm4000_ids[] = {
+        PCMCIA_DEVICE_MANF_CARD(0x0223, 0x0002),
+        PCMCIA_DEVICE_PROD_ID12("CardMan", "4000", 0x2FB368CA, 0xA2BD8C39),
+        PCMCIA_DEVICE_NULL,
+};
+MODULE_DEVICE_TABLE(pcmcia, cm4000_ids);
+
+static struct pcmcia_driver cm4000_driver = {
+        .owner    = THIS_MODULE,
+        .drv      = {
+                .name = "cm4000_cs",
+                },
+        .attach   = cm4000_attach,
+        .detach   = cm4000_detach,
+        .event    = cm4000_event,
+        .id_table = cm4000_ids,
+};
+
+static int __init cmm_init(void)
+{
+        printk(KERN_INFO "%s\n", version);
+        pcmcia_register_driver(&cm4000_driver);
+        major = register_chrdev(0, DEVICE_NAME, &cm4000_fops);
+        if (major < 0) {
+                printk(KERN_WARNING MODULE_NAME
+                        ": could not get major number\n");
+                return -1;
+        }
+
+        return 0;
+}
+
+static void __exit cmm_exit(void)
+{
+        int i;
+
+        printk(KERN_INFO MODULE_NAME ": unloading\n");
+        pcmcia_unregister_driver(&cm4000_driver);
+        for (i = 0; i < CM4000_MAX_DEV; i++)
+                if (dev_table[i])
+                        cm4000_detach_by_devno(i, dev_table[i]);
+        unregister_chrdev(major, DEVICE_NAME);
+};
+
+module_init(cmm_init);
+module_exit(cmm_exit);
+MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
new file mode 100644
index 000000000000..4c698d908ffa
--- /dev/null
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -0,0 +1,841 @@
+/*
+ * A driver for the Omnikey PCMCIA smartcard reader CardMan 4040
+ *
+ * (c) 2000-2004 Omnikey AG (http://www.omnikey.com/)
+ *
+ * (C) 2005 Harald Welte <laforge@gnumonks.org>
+ *      - add support for poll()
+ *      - driver cleanup
+ *      - add waitqueues
+ *      - adhere to linux kernel coding style and policies
+ *      - support 2.6.13 "new style" pcmcia interface
+ *
+ * The device basically is a USB CCID compliant device that has been
+ * attached to an I/O-Mapped FIFO.
+ *
+ * All rights reserved, Dual BSD/GPL Licensed.
+ */
+
+/* #define PCMCIA_DEBUG 6 */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/init.h>
+#include <linux/fs.h>
+#include <linux/delay.h>
+#include <linux/poll.h>
+#include <linux/wait.h>
+#include <asm/uaccess.h>
+#include <asm/io.h>
+
+#include <pcmcia/cs_types.h>
+#include <pcmcia/cs.h>
+#include <pcmcia/cistpl.h>
+#include <pcmcia/cisreg.h>
+#include <pcmcia/ciscode.h>
+#include <pcmcia/ds.h>
+
+#include "cm4040_cs.h"
+
+
+#ifdef PCMCIA_DEBUG
+#define reader_to_dev(x)        (&handle_to_dev(x->link.handle))
+static int pc_debug = PCMCIA_DEBUG;
+module_param(pc_debug, int, 0600);
+#define DEBUGP(n, rdr, x, args...) do {                                 \
+        if (pc_debug >= (n))                                            \
+                dev_printk(KERN_DEBUG, reader_to_dev(rdr), "%s:" x,     \
+                           __FUNCTION__ , ##args);                      \
+        } while (0)
+#else
+#define DEBUGP(n, rdr, x, args...)
+#endif
+
+static char *version =
+"OMNIKEY CardMan 4040 v1.1.0gm4 - All bugs added by Harald Welte";
+
+#define CCID_DRIVER_BULK_DEFAULT_TIMEOUT        (150*HZ)
+#define CCID_DRIVER_ASYNC_POWERUP_TIMEOUT       (35*HZ)
+#define CCID_DRIVER_MINIMUM_TIMEOUT             (3*HZ)
+#define READ_WRITE_BUFFER_SIZE 512
+#define POLL_LOOP_COUNT                         1000
+
+/* how often to poll for fifo status change */
+#define POLL_PERIOD                             msecs_to_jiffies(10)
+
+static void reader_release(dev_link_t *link);
+static void reader_detach(dev_link_t *link);
+
+static int major;
+
+#define         BS_READABLE     0x01
+#define         BS_WRITABLE     0x02
+
+struct reader_dev {
+        dev_link_t              link;
+        dev_node_t              node;
+        wait_queue_head_t       devq;
+        wait_queue_head_t       poll_wait;
+        wait_queue_head_t       read_wait;
+        wait_queue_head_t       write_wait;
+        unsigned long           buffer_status;
+        unsigned long           timeout;
+        unsigned char           s_buf[READ_WRITE_BUFFER_SIZE];
+        unsigned char           r_buf[READ_WRITE_BUFFER_SIZE];
+        struct timer_list       poll_timer;
+};
+
+static dev_info_t dev_info = MODULE_NAME;
+static dev_link_t *dev_table[CM_MAX_DEV];
+
+#ifndef PCMCIA_DEBUG
+#define xoutb   outb
+#define xinb    inb
+#else
+static inline void xoutb(unsigned char val, unsigned short port)
+{
+        if (pc_debug >= 7)
+                printk(KERN_DEBUG "outb(val=%.2x,port=%.4x)\n", val, port);
+        outb(val, port);
+}
+
+static inline unsigned char xinb(unsigned short port)
+{
+        unsigned char val;
+
+        val = inb(port);
+        if (pc_debug >= 7)
+                printk(KERN_DEBUG "%.2x=inb(%.4x)\n", val, port);
+        return val;
+}
+#endif
+
+/* poll the device fifo status register.  not to be confused with
+ * the poll syscall. */
+static void cm4040_do_poll(unsigned long dummy)
+{
+        struct reader_dev *dev = (struct reader_dev *) dummy;
+        unsigned int obs = xinb(dev->link.io.BasePort1
+                                + REG_OFFSET_BUFFER_STATUS);
+
+        if ((obs & BSR_BULK_IN_FULL)) {
+                set_bit(BS_READABLE, &dev->buffer_status);
+                DEBUGP(4, dev, "waking up read_wait\n");
+                wake_up_interruptible(&dev->read_wait);
+        } else
+                clear_bit(BS_READABLE, &dev->buffer_status);
+
+        if (!(obs & BSR_BULK_OUT_FULL)) {
+                set_bit(BS_WRITABLE, &dev->buffer_status);
+                DEBUGP(4, dev, "waking up write_wait\n");
+                wake_up_interruptible(&dev->write_wait);
+        } else
+                clear_bit(BS_WRITABLE, &dev->buffer_status);
+
+        if (dev->buffer_status)
+                wake_up_interruptible(&dev->poll_wait);
+
+        mod_timer(&dev->poll_timer, jiffies + POLL_PERIOD);
+}
+
+static void cm4040_stop_poll(struct reader_dev *dev)
+{
+        del_timer_sync(&dev->poll_timer);
+}
+
+static int wait_for_bulk_out_ready(struct reader_dev *dev)
+{
+        int i, rc;
+        int iobase = dev->link.io.BasePort1;
+
+        for (i = 0; i < POLL_LOOP_COUNT; i++) {
+                if ((xinb(iobase + REG_OFFSET_BUFFER_STATUS)
+                    & BSR_BULK_OUT_FULL) == 0) {
+                        DEBUGP(4, dev, "BulkOut empty (i=%d)\n", i);
+                        return 1;
+                }
+        }
+
+        DEBUGP(4, dev, "wait_event_interruptible_timeout(timeout=%ld\n",
+                dev->timeout);
+        rc = wait_event_interruptible_timeout(dev->write_wait,
+                                              test_and_clear_bit(BS_WRITABLE,
+                                                       &dev->buffer_status),
+                                              dev->timeout);
+
+        if (rc > 0)
+                DEBUGP(4, dev, "woke up: BulkOut empty\n");
+        else if (rc == 0)
+                DEBUGP(4, dev, "woke up: BulkOut full, returning 0 :(\n");
+        else if (rc < 0)
+                DEBUGP(4, dev, "woke up: signal arrived\n");
+
+        return rc;
+}
+
+/* Write to Sync Control Register */
+static int write_sync_reg(unsigned char val, struct reader_dev *dev)
+{
+        int iobase = dev->link.io.BasePort1;
+        int rc;
+
+        rc = wait_for_bulk_out_ready(dev);
+        if (rc <= 0)
+                return rc;
+
+        xoutb(val, iobase + REG_OFFSET_SYNC_CONTROL);
+        rc = wait_for_bulk_out_ready(dev);
+        if (rc <= 0)
+                return rc;
+
+        return 1;
+}
+
+static int wait_for_bulk_in_ready(struct reader_dev *dev)
+{
+        int i, rc;
+        int iobase = dev->link.io.BasePort1;
+
+        for (i = 0; i < POLL_LOOP_COUNT; i++) {
+                if ((xinb(iobase + REG_OFFSET_BUFFER_STATUS)
+                    & BSR_BULK_IN_FULL) == BSR_BULK_IN_FULL) {
+                        DEBUGP(3, dev, "BulkIn full (i=%d)\n", i);
+                        return 1;
+                }
+        }
+
+        DEBUGP(4, dev, "wait_event_interruptible_timeout(timeout=%ld\n",
+                dev->timeout);
+        rc = wait_event_interruptible_timeout(dev->read_wait,
+                                              test_and_clear_bit(BS_READABLE,
+                                                        &dev->buffer_status),
+                                              dev->timeout);
+        if (rc > 0)
+                DEBUGP(4, dev, "woke up: BulkIn full\n");
+        else if (rc == 0)
+                DEBUGP(4, dev, "woke up: BulkIn not full, returning 0 :(\n");
+        else if (rc < 0)
+                DEBUGP(4, dev, "woke up: signal arrived\n");
+
+        return rc;
+}
+
+static ssize_t cm4040_read(struct file *filp, char __user *buf,
+                        size_t count, loff_t *ppos)
+{
+        struct reader_dev *dev = filp->private_data;
+        int iobase = dev->link.io.BasePort1;
+        size_t bytes_to_read;
+        unsigned long i;
+        size_t min_bytes_to_read;
+        int rc;
+        unsigned char uc;
+
+        DEBUGP(2, dev, "-> cm4040_read(%s,%d)\n", current->comm, current->pid);
+
+        if (count == 0)
+                return 0;
+
+        if (count < 10)
+                return -EFAULT;
+
+        if (filp->f_flags & O_NONBLOCK) {
+                DEBUGP(4, dev, "filep->f_flags O_NONBLOCK set\n");
+                DEBUGP(2, dev, "<- cm4040_read (failure)\n");
+                return -EAGAIN;
+        }
+
+        if ((dev->link.state & DEV_PRESENT)==0)
+                return -ENODEV;
+
+        for (i = 0; i < 5; i++) {
+                rc = wait_for_bulk_in_ready(dev);
+                if (rc <= 0) {
+                        DEBUGP(5, dev, "wait_for_bulk_in_ready rc=%.2x\n", rc);
+                        DEBUGP(2, dev, "<- cm4040_read (failed)\n");
+                        if (rc == -ERESTARTSYS)
+                                return rc;
+                        return -EIO;
+                }
+                dev->r_buf[i] = xinb(iobase + REG_OFFSET_BULK_IN);
+#ifdef PCMCIA_DEBUG
+                if (pc_debug >= 6)
+                        printk(KERN_DEBUG "%lu:%2x ", i, dev->r_buf[i]);
+        }
+        printk("\n");
+#else
+        }
+#endif
+
+        bytes_to_read = 5 + le32_to_cpu(*(__le32 *)&dev->r_buf[1]);
+
+        DEBUGP(6, dev, "BytesToRead=%lu\n", bytes_to_read);
+
+        min_bytes_to_read = min(count, bytes_to_read + 5);
+
+        DEBUGP(6, dev, "Min=%lu\n", min_bytes_to_read);
+
+        for (i = 0; i < (min_bytes_to_read-5); i++) {
+                rc = wait_for_bulk_in_ready(dev);
+                if (rc <= 0) {
+                        DEBUGP(5, dev, "wait_for_bulk_in_ready rc=%.2x\n", rc);
+                        DEBUGP(2, dev, "<- cm4040_read (failed)\n");
+                        if (rc == -ERESTARTSYS)
+                                return rc;
+                        return -EIO;
+                }
+                dev->r_buf[i+5] = xinb(iobase + REG_OFFSET_BULK_IN);
+#ifdef PCMCIA_DEBUG
+                if (pc_debug >= 6)
+                        printk(KERN_DEBUG "%lu:%2x ", i, dev->r_buf[i]);
+        }
+        printk("\n");
+#else
+        }
+#endif
+
+        *ppos = min_bytes_to_read;
+        if (copy_to_user(buf, dev->r_buf, min_bytes_to_read))
+                return -EFAULT;
+
+        rc = wait_for_bulk_in_ready(dev);
+        if (rc <= 0) {
+                DEBUGP(5, dev, "wait_for_bulk_in_ready rc=%.2x\n", rc);
+                DEBUGP(2, dev, "<- cm4040_read (failed)\n");
+                if (rc == -ERESTARTSYS)
+                        return rc;
+                return -EIO;
+        }
+
+        rc = write_sync_reg(SCR_READER_TO_HOST_DONE, dev);
+        if (rc <= 0) {
+                DEBUGP(5, dev, "write_sync_reg c=%.2x\n", rc);
+                DEBUGP(2, dev, "<- cm4040_read (failed)\n");
+                if (rc == -ERESTARTSYS)
+                        return rc;
+                else
+                        return -EIO;
+        }
+
+        uc = xinb(iobase + REG_OFFSET_BULK_IN);
+
+        DEBUGP(2, dev, "<- cm4040_read (successfully)\n");
+        return min_bytes_to_read;
+}
+
+static ssize_t cm4040_write(struct file *filp, const char __user *buf,
+                         size_t count, loff_t *ppos)
+{
+        struct reader_dev *dev = filp->private_data;
+        int iobase = dev->link.io.BasePort1;
+        ssize_t rc;
+        int i;
+        unsigned int bytes_to_write;
+
+        DEBUGP(2, dev, "-> cm4040_write(%s,%d)\n", current->comm, current->pid);
+
+        if (count == 0) {
+                DEBUGP(2, dev, "<- cm4040_write empty read (successfully)\n");
+                return 0;
+        }
+
+        if (count < 5) {
+                DEBUGP(2, dev, "<- cm4040_write buffersize=%Zd < 5\n", count);
+                return -EIO;
+        }
+
+        if (filp->f_flags & O_NONBLOCK) {
+                DEBUGP(4, dev, "filep->f_flags O_NONBLOCK set\n");
+                DEBUGP(4, dev, "<- cm4040_write (failure)\n");
+                return -EAGAIN;
+        }
+
+        if ((dev->link.state & DEV_PRESENT) == 0)
+                return -ENODEV;
+
+        bytes_to_write = count;
+        if (copy_from_user(dev->s_buf, buf, bytes_to_write))
+                return -EFAULT;
+
+        switch (dev->s_buf[0]) {
+                case CMD_PC_TO_RDR_XFRBLOCK:
+                case CMD_PC_TO_RDR_SECURE:
+                case CMD_PC_TO_RDR_TEST_SECURE:
+                case CMD_PC_TO_RDR_OK_SECURE:
+                        dev->timeout = CCID_DRIVER_BULK_DEFAULT_TIMEOUT;
+                        break;
+
+                case CMD_PC_TO_RDR_ICCPOWERON:
+                        dev->timeout = CCID_DRIVER_ASYNC_POWERUP_TIMEOUT;
+                        break;
+
+                case CMD_PC_TO_RDR_GETSLOTSTATUS:
+                case CMD_PC_TO_RDR_ICCPOWEROFF:
+                case CMD_PC_TO_RDR_GETPARAMETERS:
+                case CMD_PC_TO_RDR_RESETPARAMETERS:
+                case CMD_PC_TO_RDR_SETPARAMETERS:
+                case CMD_PC_TO_RDR_ESCAPE:
+                case CMD_PC_TO_RDR_ICCCLOCK:
+                default:
+                        dev->timeout = CCID_DRIVER_MINIMUM_TIMEOUT;
+                        break;
+        }
+
+        rc = write_sync_reg(SCR_HOST_TO_READER_START, dev);
+        if (rc <= 0) {
+                DEBUGP(5, dev, "write_sync_reg c=%.2Zx\n", rc);
+                DEBUGP(2, dev, "<- cm4040_write (failed)\n");
+                if (rc == -ERESTARTSYS)
+                        return rc;
+                else
+                        return -EIO;
+        }
+
+        DEBUGP(4, dev, "start \n");
+
+        for (i = 0; i < bytes_to_write; i++) {
+                rc = wait_for_bulk_out_ready(dev);
+                if (rc <= 0) {
+                        DEBUGP(5, dev, "wait_for_bulk_out_ready rc=%.2Zx\n",
+                               rc);
+                        DEBUGP(2, dev, "<- cm4040_write (failed)\n");
+                        if (rc == -ERESTARTSYS)
+                                return rc;
+                        else
+                                return -EIO;
+                }
+
+                xoutb(dev->s_buf[i],iobase + REG_OFFSET_BULK_OUT);
+        }
+        DEBUGP(4, dev, "end\n");
+
+        rc = write_sync_reg(SCR_HOST_TO_READER_DONE, dev);
+
+        if (rc <= 0) {
+                DEBUGP(5, dev, "write_sync_reg c=%.2Zx\n", rc);
+                DEBUGP(2, dev, "<- cm4040_write (failed)\n");
+                if (rc == -ERESTARTSYS)
+                        return rc;
+                else
+                        return -EIO;
+        }
+
+        DEBUGP(2, dev, "<- cm4040_write (successfully)\n");
+        return count;
+}
+
+static unsigned int cm4040_poll(struct file *filp, poll_table *wait)
+{
+        struct reader_dev *dev = filp->private_data;
+        unsigned int mask = 0;
+
+        poll_wait(filp, &dev->poll_wait, wait);
+
+        if (test_and_clear_bit(BS_READABLE, &dev->buffer_status))
+                mask |= POLLIN | POLLRDNORM;
+        if (test_and_clear_bit(BS_WRITABLE, &dev->buffer_status))
+                mask |= POLLOUT | POLLWRNORM;
+
+        DEBUGP(2, dev, "<- cm4040_poll(%u)\n", mask);
+
+        return mask;
+}
+
+static int cm4040_open(struct inode *inode, struct file *filp)
+{
+        struct reader_dev *dev;
+        dev_link_t *link;
+        int minor = iminor(inode);
+
+        if (minor >= CM_MAX_DEV)
+                return -ENODEV;
+
+        link = dev_table[minor];
+        if (link == NULL || !(DEV_OK(link)))
+                return -ENODEV;
+
+        if (link->open)
+                return -EBUSY;
+
+        dev = link->priv;
+        filp->private_data = dev;
+
+        if (filp->f_flags & O_NONBLOCK) {
+                DEBUGP(4, dev, "filep->f_flags O_NONBLOCK set\n");
+                return -EAGAIN;
+        }
+
+        link->open = 1;
+
+        dev->poll_timer.data = (unsigned long) dev;
+        mod_timer(&dev->poll_timer, jiffies + POLL_PERIOD);
+
+        DEBUGP(2, dev, "<- cm4040_open (successfully)\n");
+        return nonseekable_open(inode, filp);
+}
+
+static int cm4040_close(struct inode *inode, struct file *filp)
+{
+        struct reader_dev *dev = filp->private_data;
+        dev_link_t *link;
+        int minor = iminor(inode);
+
+        DEBUGP(2, dev, "-> cm4040_close(maj/min=%d.%d)\n", imajor(inode),
+              iminor(inode));
+
+        if (minor >= CM_MAX_DEV)
+                return -ENODEV;
+
+        link = dev_table[minor];
+        if (link == NULL)
+                return -ENODEV;
+
+        cm4040_stop_poll(dev);
+
+        link->open = 0;
+        wake_up(&dev->devq);
+
+        DEBUGP(2, dev, "<- cm4040_close\n");
+        return 0;
+}
+
+static void cm4040_reader_release(dev_link_t *link)
+{
+        struct reader_dev *dev = link->priv;
+
+        DEBUGP(3, dev, "-> cm4040_reader_release\n");
+        while (link->open) {
+                DEBUGP(3, dev, KERN_INFO MODULE_NAME ": delaying release "
+                       "until process has terminated\n");
+                wait_event(dev->devq, (link->open == 0));
+        }
+        DEBUGP(3, dev, "<- cm4040_reader_release\n");
+        return;
+}
+
+static void reader_config(dev_link_t *link, int devno)
+{
+        client_handle_t handle;
+        struct reader_dev *dev;
+        tuple_t tuple;
+        cisparse_t parse;
+        config_info_t conf;
+        u_char buf[64];
+        int fail_fn, fail_rc;
+        int rc;
+
+        handle = link->handle;
+
+        tuple.DesiredTuple = CISTPL_CONFIG;
+        tuple.Attributes = 0;
+        tuple.TupleData = buf;
+        tuple.TupleDataMax = sizeof(buf);
+        tuple.TupleOffset = 0;
+
+        if ((fail_rc = pcmcia_get_first_tuple(handle, &tuple)) != CS_SUCCESS) {
+                fail_fn = GetFirstTuple;
+                goto cs_failed;
+        }
+        if ((fail_rc = pcmcia_get_tuple_data(handle, &tuple)) != CS_SUCCESS) {
+                fail_fn = GetTupleData;
+                goto cs_failed;
+        }
+        if ((fail_rc = pcmcia_parse_tuple(handle, &tuple, &parse))
+                                                        != CS_SUCCESS) {
+                fail_fn = ParseTuple;
+                goto cs_failed;
+        }
+        if ((fail_rc = pcmcia_get_configuration_info(handle, &conf))
+                                                        != CS_SUCCESS) {
+                fail_fn = GetConfigurationInfo;
+                goto cs_failed;
+        }
+
+        link->state |= DEV_CONFIG;
+        link->conf.ConfigBase = parse.config.base;
+        link->conf.Present = parse.config.rmask[0];
+        link->conf.Vcc = conf.Vcc;
+
+        link->io.BasePort2 = 0;
+        link->io.NumPorts2 = 0;
+        link->io.Attributes2 = 0;
+        tuple.DesiredTuple = CISTPL_CFTABLE_ENTRY;
+        for (rc = pcmcia_get_first_tuple(handle, &tuple);
+             rc == CS_SUCCESS;
+             rc = pcmcia_get_next_tuple(handle, &tuple)) {
+                rc = pcmcia_get_tuple_data(handle, &tuple);
+                if (rc != CS_SUCCESS)
+                        continue;
+                rc = pcmcia_parse_tuple(handle, &tuple, &parse);
+                if (rc != CS_SUCCESS)
+                        continue;
+
+                link->conf.ConfigIndex = parse.cftable_entry.index;
+
+                if (!parse.cftable_entry.io.nwin)
+                        continue;
+
+                link->io.BasePort1 = parse.cftable_entry.io.win[0].base;
+                link->io.NumPorts1 = parse.cftable_entry.io.win[0].len;
+                link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
+                if (!(parse.cftable_entry.io.flags & CISTPL_IO_8BIT))
+                        link->io.Attributes1 = IO_DATA_PATH_WIDTH_16;
+                if (!(parse.cftable_entry.io.flags & CISTPL_IO_16BIT))
+                        link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
+                link->io.IOAddrLines = parse.cftable_entry.io.flags
+                                                & CISTPL_IO_LINES_MASK;
+                rc = pcmcia_request_io(handle, &link->io);
+
+                dev_printk(KERN_INFO, &handle_to_dev(handle), "foo");
+                if (rc == CS_SUCCESS)
+                        break;
+                else
+                        dev_printk(KERN_INFO, &handle_to_dev(handle),
+                                   "pcmcia_request_io failed 0x%x\n", rc);
+        }
+        if (rc != CS_SUCCESS)
+                goto cs_release;
+
+        link->conf.IntType = 00000002;
+
+        if ((fail_rc = pcmcia_request_configuration(handle,&link->conf))
+                                                                !=CS_SUCCESS) {
+                fail_fn = RequestConfiguration;
+                dev_printk(KERN_INFO, &handle_to_dev(handle),
+                           "pcmcia_request_configuration failed 0x%x\n",
+                           fail_rc);
+                goto cs_release;
+        }
+
+        dev = link->priv;
+        sprintf(dev->node.dev_name, DEVICE_NAME "%d", devno);
+        dev->node.major = major;
+        dev->node.minor = devno;
+        dev->node.next = NULL;
+        link->dev = &dev->node;
+        link->state &= ~DEV_CONFIG_PENDING;
+
+        DEBUGP(2, dev, "device " DEVICE_NAME "%d at 0x%.4x-0x%.4x\n", devno,
+              link->io.BasePort1, link->io.BasePort1+link->io.NumPorts1);
+        DEBUGP(2, dev, "<- reader_config (succ)\n");
+
+        return;
+
+cs_failed:
+        cs_error(handle, fail_fn, fail_rc);
+cs_release:
+        reader_release(link);
+        link->state &= ~DEV_CONFIG_PENDING;
+}
+
+static int reader_event(event_t event, int priority,
+                        event_callback_args_t *args)
+{
+        dev_link_t *link;
+        struct reader_dev *dev;
+        int devno;
+
+        link = args->client_data;
+        dev = link->priv;
+        DEBUGP(3, dev, "-> reader_event\n");
+        for (devno = 0; devno < CM_MAX_DEV; devno++) {
+                if (dev_table[devno] == link)
+                        break;
+        }
+        if (devno == CM_MAX_DEV)
+                return CS_BAD_ADAPTER;
+
+        switch (event) {
+                case CS_EVENT_CARD_INSERTION:
+                        DEBUGP(5, dev, "CS_EVENT_CARD_INSERTION\n");
+                        link->state |= DEV_PRESENT | DEV_CONFIG_PENDING;
+                        reader_config(link, devno);
+                        break;
+                case CS_EVENT_CARD_REMOVAL:
+                        DEBUGP(5, dev, "CS_EVENT_CARD_REMOVAL\n");
+                        link->state &= ~DEV_PRESENT;
+                        break;
+                case CS_EVENT_PM_SUSPEND:
+                        DEBUGP(5, dev, "CS_EVENT_PM_SUSPEND "
+                              "(fall-through to CS_EVENT_RESET_PHYSICAL)\n");
+                        link->state |= DEV_SUSPEND;
+
+                case CS_EVENT_RESET_PHYSICAL:
+                        DEBUGP(5, dev, "CS_EVENT_RESET_PHYSICAL\n");
+                        if (link->state & DEV_CONFIG) {
+                                DEBUGP(5, dev, "ReleaseConfiguration\n");
+                                pcmcia_release_configuration(link->handle);
+                        }
+                        break;
+                case CS_EVENT_PM_RESUME:
+                        DEBUGP(5, dev, "CS_EVENT_PM_RESUME "
+                              "(fall-through to CS_EVENT_CARD_RESET)\n");
+                        link->state &= ~DEV_SUSPEND;
+
+                case CS_EVENT_CARD_RESET:
+                        DEBUGP(5, dev, "CS_EVENT_CARD_RESET\n");
+                        if ((link->state & DEV_CONFIG)) {
+                                DEBUGP(5, dev, "RequestConfiguration\n");
+                                pcmcia_request_configuration(link->handle,
+                                                             &link->conf);
+                        }
+                        break;
+                default:
+                        DEBUGP(5, dev, "reader_event: unknown event %.2x\n",
+                               event);
+                        break;
+        }
+        DEBUGP(3, dev, "<- reader_event\n");
+        return CS_SUCCESS;
+}
+
+static void reader_release(dev_link_t *link)
+{
+        cm4040_reader_release(link->priv);
+        pcmcia_release_configuration(link->handle);
+        pcmcia_release_io(link->handle, &link->io);
+}
+
+static dev_link_t *reader_attach(void)
+{
+        struct reader_dev *dev;
+        dev_link_t *link;
+        client_reg_t client_reg;
+        int i;
+
+        for (i = 0; i < CM_MAX_DEV; i++) {
+                if (dev_table[i] == NULL)
+                        break;
+        }
+
+        if (i == CM_MAX_DEV)
+                return NULL;
+
+        dev = kzalloc(sizeof(struct reader_dev), GFP_KERNEL);
+        if (dev == NULL)
+                return NULL;
+
+        dev->timeout = CCID_DRIVER_MINIMUM_TIMEOUT;
+        dev->buffer_status = 0;
+
+        link = &dev->link;
+        link->priv = dev;
+
+        link->conf.IntType = INT_MEMORY_AND_IO;
+        dev_table[i] = link;
+
+        client_reg.dev_info = &dev_info;
+        client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE;
+        client_reg.EventMask=
+                CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL |
+                CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET |
+                CS_EVENT_PM_SUSPEND | CS_EVENT_PM_RESUME;
+        client_reg.Version = 0x0210;
+        client_reg.event_callback_args.client_data = link;
+        i = pcmcia_register_client(&link->handle, &client_reg);
+        if (i) {
+                cs_error(link->handle, RegisterClient, i);
+                reader_detach(link);
+                return NULL;
+        }
+        init_waitqueue_head(&dev->devq);
+        init_waitqueue_head(&dev->poll_wait);
+        init_waitqueue_head(&dev->read_wait);
+        init_waitqueue_head(&dev->write_wait);
+        init_timer(&dev->poll_timer);
+        dev->poll_timer.function = &cm4040_do_poll;
+
+        return link;
+}
+
+static void reader_detach_by_devno(int devno, dev_link_t *link)
+{
+        struct reader_dev *dev = link->priv;
+
+        if (link->state & DEV_CONFIG) {
+                DEBUGP(5, dev, "device still configured (try to release it)\n");
+                reader_release(link);
+        }
+
+        pcmcia_deregister_client(link->handle);
+        dev_table[devno] = NULL;
+        DEBUGP(5, dev, "freeing dev=%p\n", dev);
+        cm4040_stop_poll(dev);
+        kfree(dev);
+        return;
+}
+
+static void reader_detach(dev_link_t *link)
+{
+        int i;
+
+        /* find device */
+        for (i = 0; i < CM_MAX_DEV; i++) {
+                if (dev_table[i] == link)
+                        break;
+        }
+        if (i == CM_MAX_DEV)
+                return;
+
+        reader_detach_by_devno(i, link);
+        return;
+}
+
+static struct file_operations reader_fops = {
+        .owner          = THIS_MODULE,
+        .read           = cm4040_read,
+        .write          = cm4040_write,
+        .open           = cm4040_open,
+        .release        = cm4040_close,
+        .poll           = cm4040_poll,
+};
+
+static struct pcmcia_device_id cm4040_ids[] = {
+        PCMCIA_DEVICE_MANF_CARD(0x0223, 0x0200),
+        PCMCIA_DEVICE_PROD_ID12("OMNIKEY", "CardMan 4040",
+                                0xE32CDD8C, 0x8F23318B),
+        PCMCIA_DEVICE_NULL,
+};
+MODULE_DEVICE_TABLE(pcmcia, cm4040_ids);
+
+static struct pcmcia_driver reader_driver = {
+        .owner          = THIS_MODULE,
+        .drv            = {
+                .name   = "cm4040_cs",
+        },
+        .attach         = reader_attach,
+        .detach         = reader_detach,
+        .event          = reader_event,
+        .id_table       = cm4040_ids,
+};
+
+static int __init cm4040_init(void)
+{
+        printk(KERN_INFO "%s\n", version);
+        pcmcia_register_driver(&reader_driver);
+        major = register_chrdev(0, DEVICE_NAME, &reader_fops);
+        if (major < 0) {
+                printk(KERN_WARNING MODULE_NAME
+                        ": could not get major number\n");
+                return -1;
+        }
+        return 0;
+}
+
+static void __exit cm4040_exit(void)
+{
+        int i;
+
+        printk(KERN_INFO MODULE_NAME ": unloading\n");
+        pcmcia_unregister_driver(&reader_driver);
+        for (i = 0; i < CM_MAX_DEV; i++) {
+                if (dev_table[i])
+                        reader_detach_by_devno(i, dev_table[i]);
+        }
+        unregister_chrdev(major, DEVICE_NAME);
+}
+
+module_init(cm4040_init);
+module_exit(cm4040_exit);
+MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/char/pcmcia/cm4040_cs.h b/drivers/char/pcmcia/cm4040_cs.h
new file mode 100644
index 000000000000..9a8b805c5095
--- /dev/null
+++ b/drivers/char/pcmcia/cm4040_cs.h
@@ -0,0 +1,47 @@
+#ifndef _CM4040_H_
+#define _CM4040_H_
+
+#define CM_MAX_DEV              4
+
+#define DEVICE_NAME             "cmx"
+#define MODULE_NAME             "cm4040_cs"
+
+#define REG_OFFSET_BULK_OUT      0
+#define REG_OFFSET_BULK_IN       0
+#define REG_OFFSET_BUFFER_STATUS 1
+#define REG_OFFSET_SYNC_CONTROL  2
+
+#define BSR_BULK_IN_FULL  0x02
+#define BSR_BULK_OUT_FULL 0x01
+
+#define SCR_HOST_TO_READER_START 0x80
+#define SCR_ABORT                0x40
+#define SCR_EN_NOTIFY            0x20
+#define SCR_ACK_NOTIFY           0x10
+#define SCR_READER_TO_HOST_DONE  0x08
+#define SCR_HOST_TO_READER_DONE  0x04
+#define SCR_PULSE_INTERRUPT      0x02
+#define SCR_POWER_DOWN           0x01
+
+
+#define  CMD_PC_TO_RDR_ICCPOWERON       0x62
+#define  CMD_PC_TO_RDR_GETSLOTSTATUS    0x65
+#define  CMD_PC_TO_RDR_ICCPOWEROFF      0x63
+#define  CMD_PC_TO_RDR_SECURE           0x69
+#define  CMD_PC_TO_RDR_GETPARAMETERS    0x6C
+#define  CMD_PC_TO_RDR_RESETPARAMETERS  0x6D
+#define  CMD_PC_TO_RDR_SETPARAMETERS    0x61
+#define  CMD_PC_TO_RDR_XFRBLOCK         0x6F
+#define  CMD_PC_TO_RDR_ESCAPE           0x6B
+#define  CMD_PC_TO_RDR_ICCCLOCK         0x6E
+#define  CMD_PC_TO_RDR_TEST_SECURE      0x74
+#define  CMD_PC_TO_RDR_OK_SECURE        0x89
+
+
+#define  CMD_RDR_TO_PC_SLOTSTATUS         0x81
+#define  CMD_RDR_TO_PC_DATABLOCK          0x80
+#define  CMD_RDR_TO_PC_PARAMETERS         0x82
+#define  CMD_RDR_TO_PC_ESCAPE             0x83
+#define  CMD_RDR_TO_PC_OK_SECURE          0x89
+
+#endif  /* _CM4040_H_ */
diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
index 82c6abde68df..62aa0e534a6d 100644
--- a/drivers/char/synclink.c
+++ b/drivers/char/synclink.c
@@ -1,7 +1,7 @@
 /*
  * linux/drivers/char/synclink.c
  *
- * $Id: synclink.c,v 4.37 2005/09/07 13:13:19 paulkf Exp $
+ * $Id: synclink.c,v 4.38 2005/11/07 16:30:34 paulkf Exp $
  *
  * Device driver for Microgate SyncLink ISA and PCI
  * high speed multiprotocol serial adapters.
@@ -101,6 +101,7 @@
 #include <linux/termios.h>
 #include <linux/workqueue.h>
 #include <linux/hdlc.h>
+#include <linux/dma-mapping.h>
 
 #ifdef CONFIG_HDLC_MODULE
 #define CONFIG_HDLC 1
@@ -148,6 +149,7 @@ typedef struct _DMABUFFERENTRY
         u32 link;       /* 32-bit flat link to next buffer entry */
         char *virt_addr;        /* virtual address of data buffer */
         u32 phys_entry; /* physical address of this buffer entry */
+        dma_addr_t dma_addr;
 } DMABUFFERENTRY, *DMAPBUFFERENTRY;
 
 /* The queue of BH actions to be performed */
@@ -233,7 +235,8 @@ struct mgsl_struct {
         int ri_chkcount;
 
         char *buffer_list;              /* virtual address of Rx & Tx buffer lists */
-        unsigned long buffer_list_phys;
+        u32 buffer_list_phys;
+        dma_addr_t buffer_list_dma_addr;
 
         unsigned int rx_buffer_count;   /* count of total allocated Rx buffers */
         DMABUFFERENTRY *rx_buffer_list; /* list of receive buffer entries */
@@ -896,7 +899,7 @@ module_param_array(txdmabufs, int, NULL, 0);
 module_param_array(txholdbufs, int, NULL, 0);
 
 static char *driver_name = "SyncLink serial driver";
-static char *driver_version = "$Revision: 4.37 $";
+static char *driver_version = "$Revision: 4.38 $";
 
 static int synclink_init_one (struct pci_dev *dev,
                                      const struct pci_device_id *ent);
@@ -3811,11 +3814,10 @@ static int mgsl_alloc_buffer_list_memory( struct mgsl_struct *info )
                 /* inspect portions of the buffer while other portions are being */
                 /* updated by the adapter using Bus Master DMA. */
 
-                info->buffer_list = kmalloc(BUFFERLISTSIZE, GFP_KERNEL | GFP_DMA);
-                if ( info->buffer_list == NULL )
+                info->buffer_list = dma_alloc_coherent(NULL, BUFFERLISTSIZE, &info->buffer_list_dma_addr, GFP_KERNEL);
+                if (info->buffer_list == NULL)
                         return -ENOMEM;
-                        
-                info->buffer_list_phys = isa_virt_to_bus(info->buffer_list);
+                info->buffer_list_phys = (u32)(info->buffer_list_dma_addr);
         }
 
         /* We got the memory for the buffer entry lists. */
@@ -3882,8 +3884,8 @@ static int mgsl_alloc_buffer_list_memory( struct mgsl_struct *info )
  */
 static void mgsl_free_buffer_list_memory( struct mgsl_struct *info )
 {
-        if ( info->buffer_list && info->bus_type != MGSL_BUS_TYPE_PCI )
-                kfree(info->buffer_list);
+        if (info->buffer_list && info->bus_type != MGSL_BUS_TYPE_PCI)
+                dma_free_coherent(NULL, BUFFERLISTSIZE, info->buffer_list, info->buffer_list_dma_addr);
                 
         info->buffer_list = NULL;
         info->rx_buffer_list = NULL;
@@ -3910,7 +3912,7 @@ static void mgsl_free_buffer_list_memory( struct mgsl_struct *info )
 static int mgsl_alloc_frame_memory(struct mgsl_struct *info,DMABUFFERENTRY *BufferList,int Buffercount)
 {
         int i;
-        unsigned long phys_addr;
+        u32 phys_addr;
 
         /* Allocate page sized buffers for the receive buffer list */
 
@@ -3922,11 +3924,10 @@ static int mgsl_alloc_frame_memory(struct mgsl_struct *info,DMABUFFERENTRY *Buff
                         info->last_mem_alloc += DMABUFFERSIZE;
                 } else {
                         /* ISA adapter uses system memory. */
-                        BufferList[i].virt_addr = 
-                                kmalloc(DMABUFFERSIZE, GFP_KERNEL | GFP_DMA);
-                        if ( BufferList[i].virt_addr == NULL )
+                        BufferList[i].virt_addr = dma_alloc_coherent(NULL, DMABUFFERSIZE, &BufferList[i].dma_addr, GFP_KERNEL);
+                        if (BufferList[i].virt_addr == NULL)
                                 return -ENOMEM;
-                        phys_addr = isa_virt_to_bus(BufferList[i].virt_addr);
+                        phys_addr = (u32)(BufferList[i].dma_addr);
                 }
                 BufferList[i].phys_addr = phys_addr;
         }
@@ -3957,7 +3958,7 @@ static void mgsl_free_frame_memory(struct mgsl_struct *info, DMABUFFERENTRY *Buf
                 for ( i = 0 ; i < Buffercount ; i++ ) {
                         if ( BufferList[i].virt_addr ) {
                                 if ( info->bus_type != MGSL_BUS_TYPE_PCI )
-                                        kfree(BufferList[i].virt_addr);
+                                        dma_free_coherent(NULL, DMABUFFERSIZE, BufferList[i].virt_addr, BufferList[i].dma_addr);
                                 BufferList[i].virt_addr = NULL;
                         }
                 }
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index b58adfe3ed19..a6873bf89ffa 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,7 +6,7 @@ menu "TPM devices"
 
 config TCG_TPM
         tristate "TPM Hardware Support"
-        depends on EXPERIMENTAL && PCI
+        depends on EXPERIMENTAL
         ---help---
           If you have a TPM security chip in your system, which
           implements the Trusted Computing Group's specification,
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 303f15880466..a9be0e8eaea5 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -43,6 +43,13 @@ static void user_reader_timeout(unsigned long ptr)
 {
         struct tpm_chip *chip = (struct tpm_chip *) ptr;
 
+        schedule_work(&chip->work);
+}
+
+static void timeout_work(void * ptr)
+{
+        struct tpm_chip *chip = ptr;
+
         down(&chip->buffer_mutex);
         atomic_set(&chip->data_pending, 0);
         memset(chip->data_buffer, 0, TPM_BUFSIZE);
@@ -370,6 +377,7 @@ int tpm_release(struct inode *inode, struct file *file)
         file->private_data = NULL;
         chip->num_opens--;
         del_singleshot_timer_sync(&chip->user_read_timer);
+        flush_scheduled_work();
         atomic_set(&chip->data_pending, 0);
         put_device(chip->dev);
         kfree(chip->data_buffer);
@@ -421,6 +429,7 @@ ssize_t tpm_read(struct file * file, char __user *buf,
         int ret_size;
 
         del_singleshot_timer_sync(&chip->user_read_timer);
+        flush_scheduled_work();
         ret_size = atomic_read(&chip->data_pending);
         atomic_set(&chip->data_pending, 0);
         if (ret_size > 0) {     /* relay data */
@@ -428,8 +437,7 @@ ssize_t tpm_read(struct file * file, char __user *buf,
                         ret_size = size;
 
                 down(&chip->buffer_mutex);
-                if (copy_to_user
-                    ((void __user *) buf, chip->data_buffer, ret_size))
+                if (copy_to_user(buf, chip->data_buffer, ret_size))
                         ret_size = -EFAULT;
                 up(&chip->buffer_mutex);
         }
@@ -460,7 +468,7 @@ void tpm_remove_hardware(struct device *dev)
         sysfs_remove_group(&dev->kobj, chip->vendor->attr_group);
 
         dev_mask[chip->dev_num / TPM_NUM_MASK_ENTRIES ] &=
-                !(1 << (chip->dev_num % TPM_NUM_MASK_ENTRIES));
+                ~(1 << (chip->dev_num % TPM_NUM_MASK_ENTRIES));
 
         kfree(chip);
 
@@ -528,6 +536,8 @@ int tpm_register_hardware(struct device *dev, struct tpm_vendor_specific *entry)
         init_MUTEX(&chip->tpm_mutex);
         INIT_LIST_HEAD(&chip->list);
 
+        INIT_WORK(&chip->work, timeout_work, chip);
+
         init_timer(&chip->user_read_timer);
         chip->user_read_timer.function = user_reader_timeout;
         chip->user_read_timer.data = (unsigned long) chip;
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 9293bcc4dc62..159882ca69dd 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -50,7 +50,11 @@ struct tpm_vendor_specific {
         u8 req_complete_mask;
         u8 req_complete_val;
         u8 req_canceled;
-        u16 base;               /* TPM base address */
+        void __iomem *iobase;           /* ioremapped address */
+        unsigned long base;             /* TPM base address */
+
+        int region_size;
+        int have_region;
 
         int (*recv) (struct tpm_chip *, u8 *, size_t);
         int (*send) (struct tpm_chip *, u8 *, size_t);
@@ -73,6 +77,7 @@ struct tpm_chip {
         struct semaphore buffer_mutex;
 
         struct timer_list user_read_timer;      /* user needs to claim result */
+        struct work_struct work;
         struct semaphore tpm_mutex;     /* tpm is processing */
 
         struct tpm_vendor_specific *vendor;
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c
index 32e01450c425..ff3654964fe3 100644
--- a/drivers/char/tpm/tpm_atmel.c
+++ b/drivers/char/tpm/tpm_atmel.c
@@ -19,14 +19,8 @@
  * 
  */
 
-#include <linux/platform_device.h>
 #include "tpm.h"
-
-/* Atmel definitions */
-enum tpm_atmel_addr {
-        TPM_ATMEL_BASE_ADDR_LO = 0x08,
-        TPM_ATMEL_BASE_ADDR_HI = 0x09
-};
+#include "tpm_atmel.h"
 
 /* write status bits */
 enum tpm_atmel_write_status {
@@ -53,13 +47,12 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
                 return -EIO;
 
         for (i = 0; i < 6; i++) {
-                status = inb(chip->vendor->base + 1);
+                status = ioread8(chip->vendor->iobase + 1);
                 if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                        dev_err(chip->dev,
-                                "error reading header\n");
+                        dev_err(chip->dev, "error reading header\n");
                         return -EIO;
                 }
-                *buf++ = inb(chip->vendor->base);
+                *buf++ = ioread8(chip->vendor->iobase);
         }
 
         /* size of the data received */
@@ -70,10 +63,9 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
                 dev_err(chip->dev,
                         "Recv size(%d) less than available space\n", size);
                 for (; i < size; i++) { /* clear the waiting data anyway */
-                        status = inb(chip->vendor->base + 1);
+                        status = ioread8(chip->vendor->iobase + 1);
                         if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                                dev_err(chip->dev,
-                                        "error reading data\n");
+                                dev_err(chip->dev, "error reading data\n");
                                 return -EIO;
                         }
                 }
@@ -82,17 +74,17 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
 
         /* read all the data available */
         for (; i < size; i++) {
-                status = inb(chip->vendor->base + 1);
+                status = ioread8(chip->vendor->iobase + 1);
                 if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                        dev_err(chip->dev,
-                                "error reading data\n");
+                        dev_err(chip->dev, "error reading data\n");
                         return -EIO;
                 }
-                *buf++ = inb(chip->vendor->base);
+                *buf++ = ioread8(chip->vendor->iobase);
         }
 
         /* make sure data available is gone */
-        status = inb(chip->vendor->base + 1);
+        status = ioread8(chip->vendor->iobase + 1);
+
         if (status & ATML_STATUS_DATA_AVAIL) {
                 dev_err(chip->dev, "data available is stuck\n");
                 return -EIO;
@@ -108,7 +100,7 @@ static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
         dev_dbg(chip->dev, "tpm_atml_send:\n");
         for (i = 0; i < count; i++) {
                 dev_dbg(chip->dev, "%d 0x%x(%d)\n",  i, buf[i], buf[i]);
-                outb(buf[i], chip->vendor->base);
+                iowrite8(buf[i], chip->vendor->iobase);
         }
 
         return count;
@@ -116,12 +108,12 @@ static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
 
 static void tpm_atml_cancel(struct tpm_chip *chip)
 {
-        outb(ATML_STATUS_ABORT, chip->vendor->base + 1);
+        iowrite8(ATML_STATUS_ABORT, chip->vendor->iobase + 1);
 }
 
 static u8 tpm_atml_status(struct tpm_chip *chip)
 {
-        return inb(chip->vendor->base + 1);
+        return ioread8(chip->vendor->iobase + 1);
 }
 
 static struct file_operations atmel_ops = {
@@ -162,12 +154,17 @@ static struct tpm_vendor_specific tpm_atmel = {
 
 static struct platform_device *pdev;
 
-static void __devexit tpm_atml_remove(struct device *dev)
+static void atml_plat_remove(void)
 {
-        struct tpm_chip *chip = dev_get_drvdata(dev);
+        struct tpm_chip *chip = dev_get_drvdata(&pdev->dev);
+
         if (chip) {
-                release_region(chip->vendor->base, 2);
+                if (chip->vendor->have_region)
+                        atmel_release_region(chip->vendor->base,
+                                             chip->vendor->region_size);
+                atmel_put_base_addr(chip->vendor);
                 tpm_remove_hardware(chip->dev);
+                platform_device_unregister(pdev);
         }
 }
 
@@ -182,72 +179,46 @@ static struct device_driver atml_drv = {
 static int __init init_atmel(void)
 {
         int rc = 0;
-        int lo, hi;
 
         driver_register(&atml_drv);
 
-        lo = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_LO);
-        hi = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_HI);
-
-        tpm_atmel.base = (hi<<8)|lo;
-
-        /* verify that it is an Atmel part */
-        if (tpm_read_index(TPM_ADDR, 4) != 'A' || tpm_read_index(TPM_ADDR, 5) != 'T'
-            || tpm_read_index(TPM_ADDR, 6) != 'M' || tpm_read_index(TPM_ADDR, 7) != 'L') {
-                return -ENODEV;
+        if ((tpm_atmel.iobase = atmel_get_base_addr(&tpm_atmel)) == NULL) {
+                rc = -ENODEV;
+                goto err_unreg_drv;
         }
 
-        /* verify chip version number is 1.1 */
-        if (    (tpm_read_index(TPM_ADDR, 0x00) != 0x01) ||
-                (tpm_read_index(TPM_ADDR, 0x01) != 0x01 ))
-                return -ENODEV;
-
-        pdev = kzalloc(sizeof(struct platform_device), GFP_KERNEL);
-        if ( !pdev )
-                return -ENOMEM;
-
-        pdev->name = "tpm_atmel0";
-        pdev->id = -1;
-        pdev->num_resources = 0;
-        pdev->dev.release = tpm_atml_remove;
-        pdev->dev.driver = &atml_drv;
-
-        if ((rc = platform_device_register(pdev)) < 0) {
-                kfree(pdev);
-                pdev = NULL;
-                return rc;
-        }
+        tpm_atmel.have_region =
+            (atmel_request_region
+             (tpm_atmel.base, tpm_atmel.region_size,
+              "tpm_atmel0") == NULL) ? 0 : 1;
 
-        if (request_region(tpm_atmel.base, 2, "tpm_atmel0") == NULL ) {
-                platform_device_unregister(pdev);
-                kfree(pdev);
-                pdev = NULL;
-                return -EBUSY;
+        if (IS_ERR
+            (pdev =
+             platform_device_register_simple("tpm_atmel", -1, NULL, 0))) {
+                rc = PTR_ERR(pdev);
+                goto err_rel_reg;
         }
 
-        if ((rc = tpm_register_hardware(&pdev->dev, &tpm_atmel)) < 0) {
-                release_region(tpm_atmel.base, 2);
-                platform_device_unregister(pdev);
-                kfree(pdev);
-                pdev = NULL;
-                return rc;
-        }
-
-        dev_info(&pdev->dev, "Atmel TPM 1.1, Base Address: 0x%x\n",
-                        tpm_atmel.base);
+        if ((rc = tpm_register_hardware(&pdev->dev, &tpm_atmel)) < 0)
+                goto err_unreg_dev;
         return 0;
+
+err_unreg_dev:
+        platform_device_unregister(pdev);
+err_rel_reg:
+        atmel_put_base_addr(&tpm_atmel);
+        if (tpm_atmel.have_region)
+                atmel_release_region(tpm_atmel.base,
+                                     tpm_atmel.region_size);
+err_unreg_drv:
+        driver_unregister(&atml_drv);
+        return rc;
 }
 
 static void __exit cleanup_atmel(void)
 {
-        if (pdev) {
-                tpm_atml_remove(&pdev->dev);
-                platform_device_unregister(pdev);
-                kfree(pdev);
-                pdev = NULL;
-        }
-
         driver_unregister(&atml_drv);
+        atml_plat_remove();
 }
 
 module_init(init_atmel);
diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
new file mode 100644
index 000000000000..d3478aaadd77
--- /dev/null
+++ b/drivers/char/tpm/tpm_atmel.h
@@ -0,0 +1,131 @@
+/*
+ * Copyright (C) 2005 IBM Corporation
+ *
+ * Authors:
+ * Kylene Hall <kjhall@us.ibm.com>
+ *
+ * Maintained by: <tpmdd_devel@lists.sourceforge.net>
+ *
+ * Device driver for TCG/TCPA TPM (trusted platform module).
+ * Specifications at www.trustedcomputinggroup.org
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation, version 2 of the
+ * License.
+ *
+ * These difference are required on power because the device must be
+ * discovered through the device tree and iomap must be used to get
+ * around the need for holes in the io_page_mask.  This does not happen
+ * automatically because the tpm is not a normal pci device and lives
+ * under the root node.
+ *
+ */
+
+#ifdef CONFIG_PPC64
+#define atmel_getb(chip, offset) readb(chip->vendor->iobase + offset);
+#define atmel_putb(val, chip, offset) writeb(val, chip->vendor->iobase + offset)
+#define atmel_request_region request_mem_region
+#define atmel_release_region release_mem_region
+
+static inline void atmel_put_base_addr(struct tpm_vendor_specific
+                                         *vendor)
+{
+        iounmap(vendor->iobase);
+}
+
+static void __iomem * atmel_get_base_addr(struct tpm_vendor_specific *vendor)
+{
+        struct device_node *dn;
+        unsigned long address, size;
+        unsigned int *reg;
+        int reglen;
+        int naddrc;
+        int nsizec;
+
+        dn = of_find_node_by_name(NULL, "tpm");
+
+        if (!dn)
+                return NULL;
+
+        if (!device_is_compatible(dn, "AT97SC3201")) {
+                of_node_put(dn);
+                return NULL;
+        }
+
+        reg = (unsigned int *) get_property(dn, "reg", &reglen);
+        naddrc = prom_n_addr_cells(dn);
+        nsizec = prom_n_size_cells(dn);
+
+        of_node_put(dn);
+
+
+        if (naddrc == 2)
+                address = ((unsigned long) reg[0] << 32) | reg[1];
+        else
+                address = reg[0];
+
+        if (nsizec == 2)
+                size =
+                    ((unsigned long) reg[naddrc] << 32) | reg[naddrc + 1];
+        else
+                size = reg[naddrc];
+
+        vendor->base = address;
+        vendor->region_size = size;
+        return ioremap(vendor->base, vendor->region_size);
+}
+#else
+#define atmel_getb(chip, offset) inb(chip->vendor->base + offset)
+#define atmel_putb(val, chip, offset) outb(val, chip->vendor->base + offset)
+#define atmel_request_region request_region
+#define atmel_release_region release_region
+/* Atmel definitions */
+enum tpm_atmel_addr {
+        TPM_ATMEL_BASE_ADDR_LO = 0x08,
+        TPM_ATMEL_BASE_ADDR_HI = 0x09
+};
+
+/* Verify this is a 1.1 Atmel TPM */
+static int atmel_verify_tpm11(void)
+{
+
+        /* verify that it is an Atmel part */
+        if (tpm_read_index(TPM_ADDR, 4) != 'A' ||
+            tpm_read_index(TPM_ADDR, 5) != 'T' ||
+            tpm_read_index(TPM_ADDR, 6) != 'M' ||
+            tpm_read_index(TPM_ADDR, 7) != 'L')
+                return 1;
+
+        /* query chip for its version number */
+        if (tpm_read_index(TPM_ADDR, 0x00) != 1 ||
+            tpm_read_index(TPM_ADDR, 0x01) != 1)
+                return 1;
+
+        /* This is an atmel supported part */
+        return 0;
+}
+
+static inline void atmel_put_base_addr(struct tpm_vendor_specific
+                                         *vendor)
+{
+}
+
+/* Determine where to talk to device */
+static void __iomem * atmel_get_base_addr(struct tpm_vendor_specific
+                                         *vendor)
+{
+        int lo, hi;
+
+        if (atmel_verify_tpm11() != 0)
+                return NULL;
+
+        lo = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_LO);
+        hi = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_HI);
+
+        vendor->base = (hi << 8) | lo;
+        vendor->region_size = 2;
+
+        return ioport_map(vendor->base, vendor->region_size);
+}
+#endif
diff --git a/drivers/char/watchdog/booke_wdt.c b/drivers/char/watchdog/booke_wdt.c
index abc30cca6645..65830ec71042 100644
--- a/drivers/char/watchdog/booke_wdt.c
+++ b/drivers/char/watchdog/booke_wdt.c
@@ -4,7 +4,7 @@
  * Watchdog timer for PowerPC Book-E systems
  *
  * Author: Matthew McClintock
- * Maintainer: Kumar Gala <kumar.gala@freescale.com>
+ * Maintainer: Kumar Gala <galak@kernel.crashing.org>
  *
  * Copyright 2005 Freescale Semiconductor Inc.
  *
diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
index aa36855fa995..f87220be3c87 100644
--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -35,7 +35,7 @@
 
 #include <asm/hardware.h>       /* Pick up IXP4xx-specific bits */
 
-static struct device_driver ixp4xx_i2c_driver;
+static struct platform_driver ixp4xx_i2c_driver;
 
 static inline int ixp4xx_scl_pin(void *data)
 {
@@ -128,7 +128,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
         drv_data->algo_data.timeout = 100;
 
         drv_data->adapter.id = I2C_HW_B_IXP4XX;
-        strlcpy(drv_data->adapter.name, ixp4xx_i2c_driver.name,
+        strlcpy(drv_data->adapter.name, ixp4xx_i2c_driver.driver.name,
                 I2C_NAME_SIZE);
         drv_data->adapter.algo_data = &drv_data->algo_data;
 
@@ -140,7 +140,8 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
         gpio_line_set(gpio->sda_pin, 0);
 
         if ((err = i2c_bit_add_bus(&drv_data->adapter) != 0)) {
-                printk(KERN_ERR "ERROR: Could not install %s\n", dev->bus_id);
+                printk(KERN_ERR "ERROR: Could not install %s\n", 
+                                plat_dev->dev.bus_id);
 
                 kfree(drv_data);
                 return err;
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 42e5b8175cbf..ed2bc87f475b 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -787,6 +787,10 @@ config BLK_DEV_IDE_PMAC_BLINK
           This option enables the use of the sleep LED as a hard drive
           activity LED.
 
+config BLK_DEV_IDE_SWARM
+        tristate "IDE for Sibyte evaluation boards"
+        depends on SIBYTE_SB1xxx_SOC
+
 config BLK_DEV_IDE_AU1XXX
        bool "IDE for AMD Alchemy Au1200"
        depends on SOC_AU1200
diff --git a/drivers/ide/Makefile b/drivers/ide/Makefile
index cca9c075966d..569fae717503 100644
--- a/drivers/ide/Makefile
+++ b/drivers/ide/Makefile
@@ -48,6 +48,6 @@ obj-$(CONFIG_BLK_DEV_IDECD)		+= ide-cd.o
 obj-$(CONFIG_BLK_DEV_IDETAPE)           += ide-tape.o
 obj-$(CONFIG_BLK_DEV_IDEFLOPPY)         += ide-floppy.o
 
-obj-$(CONFIG_BLK_DEV_IDE)               += legacy/ arm/
+obj-$(CONFIG_BLK_DEV_IDE)               += legacy/ arm/ mips/
 obj-$(CONFIG_BLK_DEV_HD)                += legacy/
 obj-$(CONFIG_ETRAX_IDE)         += cris/
diff --git a/drivers/ide/mips/Makefile b/drivers/ide/mips/Makefile
new file mode 100644
index 000000000000..578e52a59588
--- /dev/null
+++ b/drivers/ide/mips/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_BLK_DEV_IDE_SWARM)         += swarm.o
diff --git a/drivers/ide/mips/swarm.c b/drivers/ide/mips/swarm.c
new file mode 100644
index 000000000000..66f6064f4640
--- /dev/null
+++ b/drivers/ide/mips/swarm.c
@@ -0,0 +1,201 @@
+/*
+ * Copyright (C) 2001, 2002, 2003 Broadcom Corporation
+ * Copyright (C) 2004 MontaVista Software Inc.
+ *      Author: Manish Lachwani, mlachwani@mvista.com
+ * Copyright (C) 2004  MIPS Technologies, Inc.  All rights reserved.
+ *      Author: Maciej W. Rozycki <macro@mips.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+
+/*
+ *  Derived loosely from ide-pmac.c, so:
+ *  Copyright (C) 1998 Paul Mackerras.
+ *  Copyright (C) 1995-1998 Mark Lord
+ */
+
+/*
+ * Boards with SiByte processors so far have supported IDE devices via
+ * the Generic Bus, PCI bus, and built-in PCMCIA interface.  In all
+ * cases, byte-swapping must be avoided for these devices (whereas
+ * other PCI devices, for example, will require swapping).  Any
+ * SiByte-targetted kernel including IDE support will include this
+ * file.  Probing of a Generic Bus for an IDE device is controlled by
+ * the definition of "SIBYTE_HAVE_IDE", which is provided by
+ * <asm/sibyte/board.h> for Broadcom boards.
+ */
+
+#include <linux/ide.h>
+#include <linux/ioport.h>
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/platform_device.h>
+
+#include <asm/io.h>
+
+#include <asm/sibyte/board.h>
+#include <asm/sibyte/sb1250_genbus.h>
+#include <asm/sibyte/sb1250_regs.h>
+
+#define DRV_NAME "ide-swarm"
+
+static char swarm_ide_string[] = DRV_NAME;
+
+static struct resource swarm_ide_resource = {
+        .name   = "SWARM GenBus IDE",
+        .flags  = IORESOURCE_MEM,
+};
+
+static struct platform_device *swarm_ide_dev;
+
+/*
+ * swarm_ide_probe - if the board header indicates the existence of
+ * Generic Bus IDE, allocate a HWIF for it.
+ */
+static int __devinit swarm_ide_probe(struct device *dev)
+{
+        ide_hwif_t *hwif;
+        u8 __iomem *base;
+        phys_t offset, size;
+        int i;
+
+        if (!SIBYTE_HAVE_IDE)
+                return -ENODEV;
+
+        /* Find an empty slot.  */
+        for (i = 0; i < MAX_HWIFS; i++)
+                if (!ide_hwifs[i].io_ports[IDE_DATA_OFFSET])
+                        break;
+        if (i >= MAX_HWIFS) {
+                printk(KERN_ERR DRV_NAME ": no free slot for interface\n");
+                return -ENOMEM;
+        }
+
+        hwif = ide_hwifs + i;
+
+        base = ioremap(A_IO_EXT_BASE, 0x800);
+        offset = __raw_readq(base + R_IO_EXT_REG(R_IO_EXT_START_ADDR, IDE_CS));
+        size = __raw_readq(base + R_IO_EXT_REG(R_IO_EXT_MULT_SIZE, IDE_CS));
+        iounmap(base);
+
+        offset = G_IO_START_ADDR(offset) << S_IO_ADDRBASE;
+        size = (G_IO_MULT_SIZE(size) + 1) << S_IO_REGSIZE;
+        if (offset < A_PHYS_GENBUS || offset >= A_PHYS_GENBUS_END) {
+                printk(KERN_INFO DRV_NAME
+                       ": IDE interface at GenBus disabled\n");
+                return -EBUSY;
+        }
+
+        printk(KERN_INFO DRV_NAME ": IDE interface at GenBus slot %i\n",
+               IDE_CS);
+
+        swarm_ide_resource.start = offset;
+        swarm_ide_resource.end = offset + size - 1;
+        if (request_resource(&iomem_resource, &swarm_ide_resource)) {
+                printk(KERN_ERR DRV_NAME
+                       ": can't request I/O memory resource\n");
+                return -EBUSY;
+        }
+
+        base = ioremap(offset, size);
+
+        /* Setup MMIO ops.  */
+        default_hwif_mmiops(hwif);
+        /* Prevent resource map manipulation.  */
+        hwif->mmio = 2;
+        hwif->noprobe = 0;
+
+        for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++)
+                hwif->hw.io_ports[i] =
+                                (unsigned long)(base + ((0x1f0 + i) << 5));
+        hwif->hw.io_ports[IDE_CONTROL_OFFSET] =
+                                (unsigned long)(base + (0x3f6 << 5));
+        hwif->hw.irq = K_INT_GB_IDE;
+
+        memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports));
+        hwif->irq = hwif->hw.irq;
+
+        dev_set_drvdata(dev, hwif);
+
+        return 0;
+}
+
+static struct device_driver swarm_ide_driver = {
+        .name   = swarm_ide_string,
+        .bus    = &platform_bus_type,
+        .probe  = swarm_ide_probe,
+};
+
+static void swarm_ide_platform_release(struct device *device)
+{
+        struct platform_device *pldev;
+
+        /* free device */
+        pldev = to_platform_device(device);
+        kfree(pldev);
+}
+
+static int __devinit swarm_ide_init_module(void)
+{
+        struct platform_device *pldev;
+        int err;
+
+        printk(KERN_INFO "SWARM IDE driver\n");
+
+        if (driver_register(&swarm_ide_driver)) {
+                printk(KERN_ERR "Driver registration failed\n");
+                err = -ENODEV;
+                goto out;
+        }
+
+        if (!(pldev = kmalloc(sizeof (*pldev), GFP_KERNEL))) {
+                err = -ENOMEM;
+                goto out_unregister_driver;
+        }
+
+        memset (pldev, 0, sizeof (*pldev));
+        pldev->name             = swarm_ide_string;
+        pldev->id               = 0;
+        pldev->dev.release      = swarm_ide_platform_release;
+
+        if (platform_device_register(pldev)) {
+                err = -ENODEV;
+                goto out_free_pldev;
+        }
+
+        if (!pldev->dev.driver) {
+                /*
+                 * The driver was not bound to this device, there was
+                 * no hardware at this address. Unregister it, as the
+                 * release fuction will take care of freeing the
+                 * allocated structure
+                 */
+                platform_device_unregister (pldev);
+        }
+
+        swarm_ide_dev = pldev;
+
+        return 0;
+
+out_free_pldev:
+        kfree(pldev);
+
+out_unregister_driver:
+        driver_unregister(&swarm_ide_driver);
+out:
+        return err;
+}
+
+module_init(swarm_ide_init_module);
diff --git a/drivers/ide/pci/sl82c105.c b/drivers/ide/pci/sl82c105.c
index ea0806c82be0..8a5c7b286b2b 100644
--- a/drivers/ide/pci/sl82c105.c
+++ b/drivers/ide/pci/sl82c105.c
@@ -399,34 +399,6 @@ static unsigned int __devinit init_chipset_sl82c105(struct pci_dev *dev, const c
         return dev->irq;
 }
 
-static void __devinit init_dma_sl82c105(ide_hwif_t *hwif, unsigned long dma_base)
-{
-        unsigned int rev;
-        u8 dma_state;
-
-        DBG(("init_dma_sl82c105(hwif: ide%d, dma_base: 0x%08x)\n", hwif->index, dma_base));
-
-        hwif->autodma = 0;
-
-        if (!dma_base)
-                return;
-
-        dma_state = hwif->INB(dma_base + 2);
-        rev = sl82c105_bridge_revision(hwif->pci_dev);
-        if (rev <= 5) {
-                printk("    %s: Winbond 553 bridge revision %d, BM-DMA disabled\n",
-                       hwif->name, rev);
-                dma_state &= ~0x60;
-        } else {
-                dma_state |= 0x60;
-                if (!noautodma)
-                        hwif->autodma = 1;
-        }
-        hwif->OUTB(dma_state, dma_base + 2);
-
-        ide_setup_dma(hwif, dma_base, 8);
-}
-
 /*
  * Initialise the chip
  */
@@ -434,6 +406,8 @@ static void __devinit init_dma_sl82c105(ide_hwif_t *hwif, unsigned long dma_base
 static void __devinit init_hwif_sl82c105(ide_hwif_t *hwif)
 {
         struct pci_dev *dev = hwif->pci_dev;
+        unsigned int rev;
+        u8 dma_state;
         u32 val;
         
         DBG(("init_hwif_sl82c105(hwif: ide%d)\n", hwif->index));
@@ -455,33 +429,54 @@ static void __devinit init_hwif_sl82c105(ide_hwif_t *hwif)
         pci_read_config_dword(dev, 0x40, &val);
         *((u32 *)&hwif->hwif_data) = val;
         
+        hwif->atapi_dma = 0;
+        hwif->mwdma_mask = 0;
+        hwif->swdma_mask = 0;
+        hwif->autodma = 0;
+
         if (!hwif->dma_base)
                 return;
 
-        hwif->atapi_dma = 1;
-        hwif->mwdma_mask = 0x07;
-        hwif->swdma_mask = 0x07;
-
+        dma_state = hwif->INB(hwif->dma_base + 2) & ~0x60;
+        rev = sl82c105_bridge_revision(hwif->pci_dev);
+        if (rev <= 5) {
+                /*
+                 * Never ever EVER under any circumstances enable
+                 * DMA when the bridge is this old.
+                 */
+                printk("    %s: Winbond 553 bridge revision %d, BM-DMA disabled\n",
+                       hwif->name, rev);
+        } else {
 #ifdef CONFIG_BLK_DEV_IDEDMA
-        hwif->ide_dma_check = &sl82c105_check_drive;
-        hwif->ide_dma_on = &sl82c105_ide_dma_on;
-        hwif->ide_dma_off_quietly = &sl82c105_ide_dma_off_quietly;
-        hwif->ide_dma_lostirq = &sl82c105_ide_dma_lost_irq;
-        hwif->dma_start = &sl82c105_ide_dma_start;
-        hwif->ide_dma_timeout = &sl82c105_ide_dma_timeout;
-
-        if (!noautodma)
-                hwif->autodma = 1;
-        hwif->drives[0].autodma = hwif->autodma;
-        hwif->drives[1].autodma = hwif->autodma;
+                dma_state |= 0x60;
+
+                hwif->atapi_dma = 1;
+                hwif->mwdma_mask = 0x07;
+                hwif->swdma_mask = 0x07;
+
+                hwif->ide_dma_check = &sl82c105_check_drive;
+                hwif->ide_dma_on = &sl82c105_ide_dma_on;
+                hwif->ide_dma_off_quietly = &sl82c105_ide_dma_off_quietly;
+                hwif->ide_dma_lostirq = &sl82c105_ide_dma_lost_irq;
+                hwif->dma_start = &sl82c105_ide_dma_start;
+                hwif->ide_dma_timeout = &sl82c105_ide_dma_timeout;
+
+                if (!noautodma)
+                        hwif->autodma = 1;
+                hwif->drives[0].autodma = hwif->autodma;
+                hwif->drives[1].autodma = hwif->autodma;
+
+                if (hwif->mate)
+                        hwif->serialized = hwif->mate->serialized = 1;
 #endif /* CONFIG_BLK_DEV_IDEDMA */
+        }
+        hwif->OUTB(dma_state, hwif->dma_base + 2);
 }
 
 static ide_pci_device_t sl82c105_chipset __devinitdata = {
         .name           = "W82C105",
         .init_chipset   = init_chipset_sl82c105,
         .init_hwif      = init_hwif_sl82c105,
-        .init_dma       = init_dma_sl82c105,
         .channels       = 2,
         .autodma        = NOAUTODMA,
         .enablebits     = {{0x40,0x01,0x01}, {0x40,0x10,0x10}},
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index b3e65a65d202..136911a86e84 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1667,11 +1667,16 @@ static struct macio_driver pmac_ide_macio_driver =
 };
 
 static struct pci_device_id pmac_ide_pci_match[] = {
-        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_UNI_N_ATA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
-        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_IPID_ATA100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
-        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_K2_ATA100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_UNI_N_ATA,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_IPID_ATA100,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_K2_ATA100,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
         { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_SH_ATA,
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_IPID2_ATA,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 };
 
 static struct pci_driver pmac_ide_pci_driver = {
diff --git a/drivers/isdn/hisax/hfc_usb.c b/drivers/isdn/hisax/hfc_usb.c
index 32bf0d5d0f9a..f8457ef48826 100644
--- a/drivers/isdn/hisax/hfc_usb.c
+++ b/drivers/isdn/hisax/hfc_usb.c
@@ -71,78 +71,68 @@ typedef struct {
 /****************************************/
 static struct usb_device_id hfcusb_idtab[] = {
         {
-         .idVendor = 0x0959,
-         .idProduct = 0x2bd0,
+         USB_DEVICE(0x0959, 0x2bd0),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_OFF, {4, 0, 2, 1},
                            "ISDN USB TA (Cologne Chip HFC-S USB based)"}),
         },
         {
-         .idVendor = 0x0675,
-         .idProduct = 0x1688,
+         USB_DEVICE(0x0675, 0x1688),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {1, 2, 0, 0},
                            "DrayTek miniVigor 128 USB ISDN TA"}),
         },
         {
-         .idVendor = 0x07b0,
-         .idProduct = 0x0007,
+         USB_DEVICE(0x07b0, 0x0007),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {0x80, -64, -32, -16},
                            "Billion tiny USB ISDN TA 128"}),
         },
         {
-         .idVendor = 0x0742,
-         .idProduct = 0x2008,
+         USB_DEVICE(0x0742, 0x2008),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {4, 0, 2, 1},
                            "Stollmann USB TA"}),
          },
         {
-         .idVendor = 0x0742,
-         .idProduct = 0x2009,
+         USB_DEVICE(0x0742, 0x2009),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {4, 0, 2, 1},
                            "Aceex USB ISDN TA"}),
          },
         {
-         .idVendor = 0x0742,
-         .idProduct = 0x200A,
+         USB_DEVICE(0x0742, 0x200A),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {4, 0, 2, 1},
                            "OEM USB ISDN TA"}),
          },
         {
-         .idVendor = 0x08e3,
-         .idProduct = 0x0301,
+         USB_DEVICE(0x08e3, 0x0301),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {2, 0, 1, 4},
                            "Olitec USB RNIS"}),
          },
         {
-         .idVendor = 0x07fa,
-         .idProduct = 0x0846,
+         USB_DEVICE(0x07fa, 0x0846),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {0x80, -64, -32, -16},
                            "Bewan Modem RNIS USB"}),
          },
         {
-         .idVendor = 0x07fa,
-         .idProduct = 0x0847,
+         USB_DEVICE(0x07fa, 0x0847),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {0x80, -64, -32, -16},
                            "Djinn Numeris USB"}),
          },
         {
-         .idVendor = 0x07b0,
-         .idProduct = 0x0006,
+         USB_DEVICE(0x07b0, 0x0006),
          .driver_info = (unsigned long) &((hfcsusb_vdata)
                           {LED_SCHEME1, {0x80, -64, -32, -16},
                            "Twister ISDN TA"}),
          },
+        { }
 };
 
-
 /***************************************************************/
 /* structure defining input+output fifos (interrupt/bulk mode) */
 /***************************************************************/
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 51315302a85e..252d55df9642 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -326,9 +326,9 @@ static int write_page(struct bitmap *bitmap, struct page *page, int wait)
                 }
         }
 
-        ret = page->mapping->a_ops->prepare_write(NULL, page, 0, PAGE_SIZE);
+        ret = page->mapping->a_ops->prepare_write(bitmap->file, page, 0, PAGE_SIZE);
         if (!ret)
-                ret = page->mapping->a_ops->commit_write(NULL, page, 0,
+                ret = page->mapping->a_ops->commit_write(bitmap->file, page, 0,
                         PAGE_SIZE);
         if (ret) {
                 unlock_page(page);
diff --git a/drivers/md/md.c b/drivers/md/md.c
index adf960d8a7c9..78c7418478d6 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3156,7 +3156,7 @@ static int md_ioctl(struct inode *inode, struct file *file,
                 if (cnt > 0 ) {
                         printk(KERN_WARNING
                                "md: %s(pid %d) used deprecated START_ARRAY ioctl. "
-                               "This will not be supported beyond 2.6\n",
+                               "This will not be supported beyond July 2006\n",
                                current->comm, current->pid);
                         cnt--;
                 }
@@ -3437,10 +3437,19 @@ static int md_thread(void * arg)
         allow_signal(SIGKILL);
         while (!kthread_should_stop()) {
 
-                wait_event_timeout(thread->wqueue,
-                                   test_bit(THREAD_WAKEUP, &thread->flags)
-                                   || kthread_should_stop(),
-                                   thread->timeout);
+                /* We need to wait INTERRUPTIBLE so that
+                 * we don't add to the load-average.
+                 * That means we need to be sure no signals are
+                 * pending
+                 */
+                if (signal_pending(current))
+                        flush_signals(current);
+
+                wait_event_interruptible_timeout
+                        (thread->wqueue,
+                         test_bit(THREAD_WAKEUP, &thread->flags)
+                         || kthread_should_stop(),
+                         thread->timeout);
                 try_to_freeze();
 
                 clear_bit(THREAD_WAKEUP, &thread->flags);
@@ -3837,11 +3846,20 @@ static int is_mddev_idle(mddev_t *mddev)
                 curr_events = disk_stat_read(disk, sectors[0]) + 
                                 disk_stat_read(disk, sectors[1]) - 
                                 atomic_read(&disk->sync_io);
-                /* Allow some slack between valud of curr_events and last_events,
-                 * as there are some uninteresting races.
+                /* The difference between curr_events and last_events
+                 * will be affected by any new non-sync IO (making
+                 * curr_events bigger) and any difference in the amount of
+                 * in-flight syncio (making current_events bigger or smaller)
+                 * The amount in-flight is currently limited to
+                 * 32*64K in raid1/10 and 256*PAGE_SIZE in raid5/6
+                 * which is at most 4096 sectors.
+                 * These numbers are fairly fragile and should be made
+                 * more robust, probably by enforcing the
+                 * 'window size' that md_do_sync sort-of uses.
+                 *
                  * Note: the following is an unsigned comparison.
                  */
-                if ((curr_events - rdev->last_events + 32) > 64) {
+                if ((curr_events - rdev->last_events + 4096) > 8192) {
                         rdev->last_events = curr_events;
                         idle = 0;
                 }
@@ -4100,7 +4118,7 @@ static void md_do_sync(mddev_t *mddev)
                 if (currspeed > sysctl_speed_limit_min) {
                         if ((currspeed > sysctl_speed_limit_max) ||
                                         !is_mddev_idle(mddev)) {
-                                msleep(250);
+                                msleep(500);
                                 goto repeat;
                         }
                 }
diff --git a/drivers/media/common/ir-common.c b/drivers/media/common/ir-common.c
index 4b71fd6f7aed..7972c73bc14e 100644
--- a/drivers/media/common/ir-common.c
+++ b/drivers/media/common/ir-common.c
@@ -126,6 +126,66 @@ IR_KEYTAB_TYPE ir_codes_winfast[IR_KEYTAB_SIZE] = {
 };
 EXPORT_SYMBOL_GPL(ir_codes_winfast);
 
+IR_KEYTAB_TYPE ir_codes_pinnacle[IR_KEYTAB_SIZE] = {
+        [ 0x59 ] = KEY_MUTE,
+        [ 0x4a ] = KEY_POWER,
+
+        [ 0x18 ] = KEY_TEXT,
+        [ 0x26 ] = KEY_TV,
+        [ 0x3d ] = KEY_PRINT,
+
+        [ 0x48 ] = KEY_RED,
+        [ 0x04 ] = KEY_GREEN,
+        [ 0x11 ] = KEY_YELLOW,
+        [ 0x00 ] = KEY_BLUE,
+
+        [ 0x2d ] = KEY_VOLUMEUP,
+        [ 0x1e ] = KEY_VOLUMEDOWN,
+
+        [ 0x49 ] = KEY_MENU,
+
+        [ 0x16 ] = KEY_CHANNELUP,
+        [ 0x17 ] = KEY_CHANNELDOWN,
+
+        [ 0x20 ] = KEY_UP,
+        [ 0x21 ] = KEY_DOWN,
+        [ 0x22 ] = KEY_LEFT,
+        [ 0x23 ] = KEY_RIGHT,
+        [ 0x0d ] = KEY_SELECT,
+
+
+
+        [ 0x08 ] = KEY_BACK,
+        [ 0x07 ] = KEY_REFRESH,
+
+        [ 0x2f ] = KEY_ZOOM,
+        [ 0x29 ] = KEY_RECORD,
+
+        [ 0x4b ] = KEY_PAUSE,
+        [ 0x4d ] = KEY_REWIND,
+        [ 0x2e ] = KEY_PLAY,
+        [ 0x4e ] = KEY_FORWARD,
+        [ 0x53 ] = KEY_PREVIOUS,
+        [ 0x4c ] = KEY_STOP,
+        [ 0x54 ] = KEY_NEXT,
+
+        [ 0x69 ] = KEY_KP0,
+        [ 0x6a ] = KEY_KP1,
+        [ 0x6b ] = KEY_KP2,
+        [ 0x6c ] = KEY_KP3,
+        [ 0x6d ] = KEY_KP4,
+        [ 0x6e ] = KEY_KP5,
+        [ 0x6f ] = KEY_KP6,
+        [ 0x70 ] = KEY_KP7,
+        [ 0x71 ] = KEY_KP8,
+        [ 0x72 ] = KEY_KP9,
+
+        [ 0x74 ] = KEY_CHANNEL,
+        [ 0x0a ] = KEY_BACKSPACE,
+};
+
+EXPORT_SYMBOL_GPL(ir_codes_pinnacle);
+
 /* empty keytable, can be used as placeholder for not-yet created keytables */
 IR_KEYTAB_TYPE ir_codes_empty[IR_KEYTAB_SIZE] = {
         [ 42 ] = KEY_COFFEE,
diff --git a/drivers/media/dvb/b2c2/Kconfig b/drivers/media/dvb/b2c2/Kconfig
index d7417eac2aba..2583a865a58e 100644
--- a/drivers/media/dvb/b2c2/Kconfig
+++ b/drivers/media/dvb/b2c2/Kconfig
@@ -7,6 +7,7 @@ config DVB_B2C2_FLEXCOP
         select DVB_NXT2002
         select DVB_STV0297
         select DVB_BCM3510
+        select DVB_LGDT330X
         help
           Support for the digital TV receiver chip made by B2C2 Inc. included in
           Technisats PCI cards and USB boxes.
diff --git a/drivers/media/dvb/cinergyT2/cinergyT2.c b/drivers/media/dvb/cinergyT2/cinergyT2.c
index a1607e7d6d6b..fb394a0d838c 100644
--- a/drivers/media/dvb/cinergyT2/cinergyT2.c
+++ b/drivers/media/dvb/cinergyT2/cinergyT2.c
@@ -276,7 +276,7 @@ static void cinergyt2_free_stream_urbs (struct cinergyt2 *cinergyt2)
                 if (cinergyt2->stream_urb[i])
                         usb_free_urb(cinergyt2->stream_urb[i]);
 
-        pci_free_consistent(NULL, STREAM_URB_COUNT*STREAM_BUF_SIZE,
+        usb_buffer_free(cinergyt2->udev, STREAM_URB_COUNT*STREAM_BUF_SIZE,
                             cinergyt2->streambuf, cinergyt2->streambuf_dmahandle);
 }
 
@@ -284,9 +284,8 @@ static int cinergyt2_alloc_stream_urbs (struct cinergyt2 *cinergyt2)
 {
         int i;
 
-        cinergyt2->streambuf = pci_alloc_consistent(NULL,
-                                              STREAM_URB_COUNT*STREAM_BUF_SIZE,
-                                              &cinergyt2->streambuf_dmahandle);
+        cinergyt2->streambuf = usb_buffer_alloc(cinergyt2->udev, STREAM_URB_COUNT*STREAM_BUF_SIZE,
+                                              SLAB_KERNEL, &cinergyt2->streambuf_dmahandle);
         if (!cinergyt2->streambuf) {
                 dprintk(1, "failed to alloc consistent stream memory area, bailing out!\n");
                 return -ENOMEM;
@@ -780,6 +779,8 @@ static int cinergyt2_register_rc(struct cinergyt2 *cinergyt2)
 
         input_register_device(cinergyt2->rc_input_dev);
         schedule_delayed_work(&cinergyt2->rc_query_work, HZ/2);
+
+        return 0;
 }
 
 static void cinergyt2_unregister_rc(struct cinergyt2 *cinergyt2)
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 199b01188858..1a3b3c7e5e99 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -333,4 +333,18 @@ config VIDEO_M32R_AR_M64278
           Say Y here to use the Renesas M64278E-800 camera module,
           which supports VGA(640x480 pixcels) size of images.
 
+config VIDEO_AUDIO_DECODER
+        tristate "Add support for additional audio chipsets"
+        depends on VIDEO_DEV && I2C && EXPERIMENTAL
+        ---help---
+          Say Y here to compile drivers for WM8775 and CS53L32A audio
+          decoders.
+
+config VIDEO_DECODER
+        tristate "Add support for additional video chipsets"
+        depends on VIDEO_DEV && I2C && EXPERIMENTAL
+        ---help---
+          Say Y here to compile drivers for SAA7115, SAA7127 and CX25840
+          video  decoders.
+
 endmenu
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index 3ac465992400..82060f9909d8 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -36,10 +36,11 @@ obj-$(CONFIG_VIDEO_CPIA) += cpia.o
 obj-$(CONFIG_VIDEO_CPIA_PP) += cpia_pp.o
 obj-$(CONFIG_VIDEO_CPIA_USB) += cpia_usb.o
 obj-$(CONFIG_VIDEO_MEYE) += meye.o
-obj-$(CONFIG_VIDEO_SAA7134) += saa7134/
+obj-$(CONFIG_VIDEO_SAA7134) += ir-kbd-i2c.o saa7134/
 obj-$(CONFIG_VIDEO_CX88) += cx88/
 obj-$(CONFIG_VIDEO_EM28XX) += em28xx/
 obj-$(CONFIG_VIDEO_EM28XX) += saa711x.o tvp5150.o
+obj-$(CONFIG_VIDEO_AUDIO_DECODER) += wm8775.o cs53l32a.o
 obj-$(CONFIG_VIDEO_OVCAMCHIP) += ovcamchip/
 obj-$(CONFIG_VIDEO_MXB) += saa7111.o tuner.o tda9840.o tea6415c.o tea6420.o mxb.o
 obj-$(CONFIG_VIDEO_HEXIUM_ORION) += hexium_orion.o
@@ -55,4 +56,6 @@ obj-$(CONFIG_VIDEO_TVEEPROM) += tveeprom.o
 
 obj-$(CONFIG_VIDEO_M32R_AR_M64278) += arv.o
 
+obj-$(CONFIG_VIDEO_DECODER)     += saa7115.o cx25840/ saa7127.o
+
 EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
diff --git a/drivers/media/video/bttv-cards.c b/drivers/media/video/bttv-cards.c
index 3413bace443a..e31ebb11c468 100644
--- a/drivers/media/video/bttv-cards.c
+++ b/drivers/media/video/bttv-cards.c
@@ -2133,7 +2133,10 @@ struct tvcard bttv_tvcards[] = {
                 .tuner_addr     = ADDR_UNSET,
                 .radio_addr     = ADDR_UNSET,
                 .has_dvb        = 1,
+                .has_remote     = 1,
+                .gpiomask       = 0x1b,
                 .no_gpioirq     = 1,
+                .any_irq                = 1,
         },
         [BTTV_BOARD_PV143] = {
                 /* Jorge Boncompte - DTI2 <jorge@dti2.net> */
@@ -2796,7 +2799,24 @@ struct tvcard bttv_tvcards[] = {
                 .tuner_addr     = ADDR_UNSET,
                 .radio_addr     = ADDR_UNSET,
         },
-
+                /* ---- card 0x8e ---------------------------------- */
+        [BTTV_BOARD_SABRENT_TVFM] = {
+                .name           = "Sabrent TV-FM (bttv version)",
+                .video_inputs   = 3,
+                .audio_inputs   = 1,
+                .tuner          = 0,
+                .svhs           = 2,
+                .gpiomask       = 0x108007,
+                .muxsel         = { 2, 3, 1, 1},
+                .audiomux       = { 100000, 100002, 100002, 100000},
+                .no_msp34xx     = 1,
+                .no_tda9875     = 1,
+                .no_tda7432     = 1,
+                .pll            = PLL_28,
+                .tuner_type     = TUNER_TNF_5335MF,
+                .tuner_addr     = ADDR_UNSET,
+                .has_radio      = 1,
+        },
 };
 
 static const unsigned int bttv_num_tvcards = ARRAY_SIZE(bttv_tvcards);
@@ -3367,6 +3387,8 @@ void __devinit bttv_init_card2(struct bttv *btv)
                 btv->has_remote=1;
         if (!bttv_tvcards[btv->c.type].no_gpioirq)
                 btv->gpioirq=1;
+        if (bttv_tvcards[btv->c.type].any_irq)
+                btv->any_irq = 1;
         if (bttv_tvcards[btv->c.type].audio_hook)
                 btv->audio_hook=bttv_tvcards[btv->c.type].audio_hook;
 
diff --git a/drivers/media/video/bttv-driver.c b/drivers/media/video/bttv-driver.c
index 0005741d5514..709099f03bd2 100644
--- a/drivers/media/video/bttv-driver.c
+++ b/drivers/media/video/bttv-driver.c
@@ -3667,6 +3667,10 @@ static irqreturn_t bttv_irq(int irq, void *dev_id, struct pt_regs * regs)
         int handled = 0;
 
         btv=(struct bttv *)dev_id;
+
+        if (btv->any_irq)
+                handled = bttv_any_irq(&btv->c);
+
         count=0;
         while (1) {
                 /* get/clear interrupt status bits */
diff --git a/drivers/media/video/bttv-gpio.c b/drivers/media/video/bttv-gpio.c
index 575ce8b8e714..616a5b7e510c 100644
--- a/drivers/media/video/bttv-gpio.c
+++ b/drivers/media/video/bttv-gpio.c
@@ -113,6 +113,24 @@ void bttv_gpio_irq(struct bttv_core *core)
         }
 }
 
+int bttv_any_irq(struct bttv_core *core)
+{
+        struct bttv_sub_driver *drv;
+        struct bttv_sub_device *dev;
+        struct list_head *item;
+        int handled = 0;
+
+        list_for_each(item,&core->subs) {
+                dev = list_entry(item,struct bttv_sub_device,list);
+                drv = to_bttv_sub_drv(dev->dev.driver);
+                if (drv && drv->any_irq) {
+                        if (drv->any_irq(dev))
+                                handled = 1;
+                }
+        }
+        return handled;
+}
+
 /* ----------------------------------------------------------------------- */
 /* external: sub-driver register/unregister                                */
 
diff --git a/drivers/media/video/bttv.h b/drivers/media/video/bttv.h
index 124ea41dada4..93298f06e019 100644
--- a/drivers/media/video/bttv.h
+++ b/drivers/media/video/bttv.h
@@ -162,6 +162,7 @@
 #define BTTV_BOARD_PV_M4900                0x8b
 #define BTTV_BOARD_OSPREY440               0x8c
 #define BTTV_BOARD_ASOUND_SKYEYE           0x8d
+#define BTTV_BOARD_SABRENT_TVFM            0x8e
 
 /* i2c address list */
 #define I2C_TSA5522        0xc2
@@ -234,6 +235,7 @@ struct tvcard
         unsigned int has_dvb:1;
         unsigned int has_remote:1;
         unsigned int no_gpioirq:1;
+        unsigned int any_irq:1;
 
         /* other settings */
         unsigned int pll;
@@ -333,6 +335,7 @@ struct bttv_sub_driver {
         struct device_driver   drv;
         char                   wanted[BUS_ID_SIZE];
         void                   (*gpio_irq)(struct bttv_sub_device *sub);
+        int                    (*any_irq)(struct bttv_sub_device *sub);
 };
 #define to_bttv_sub_drv(x) container_of((x), struct bttv_sub_driver, drv)
 
diff --git a/drivers/media/video/bttvp.h b/drivers/media/video/bttvp.h
index 386f546f7d11..3aa9c6e4fc33 100644
--- a/drivers/media/video/bttvp.h
+++ b/drivers/media/video/bttvp.h
@@ -208,6 +208,7 @@ extern struct bus_type bttv_sub_bus_type;
 int bttv_sub_add_device(struct bttv_core *core, char *name);
 int bttv_sub_del_devices(struct bttv_core *core);
 void bttv_gpio_irq(struct bttv_core *core);
+int bttv_any_irq(struct bttv_core *core);
 
 
 /* ---------------------------------------------------------- */
@@ -273,6 +274,7 @@ struct bttv {
         struct bttv_pll_info pll;
         int triton1;
         int gpioirq;
+        int any_irq;
         int use_i2c_hw;
 
         /* old gpio interface */
diff --git a/drivers/media/video/cx25840/Makefile b/drivers/media/video/cx25840/Makefile
new file mode 100644
index 000000000000..543ebacdc9d7
--- /dev/null
+++ b/drivers/media/video/cx25840/Makefile
@@ -0,0 +1,6 @@
+cx25840-objs    := cx25840-core.o cx25840-audio.o cx25840-firmware.o \
+                   cx25840-vbi.o
+
+obj-$(CONFIG_VIDEO_DECODER) += cx25840.o
+
+EXTRA_CFLAGS += -I$(src)/..
diff --git a/drivers/media/video/cx25840/cx25840-audio.c b/drivers/media/video/cx25840/cx25840-audio.c
new file mode 100644
index 000000000000..740908f8027d
--- /dev/null
+++ b/drivers/media/video/cx25840/cx25840-audio.c
@@ -0,0 +1,368 @@
+/* cx25840 audio functions
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/videodev2.h>
+#include <linux/i2c.h>
+#include <media/audiochip.h>
+#include <media/v4l2-common.h>
+
+#include "cx25840.h"
+
+inline static int set_audclk_freq(struct i2c_client *client,
+                                 enum v4l2_audio_clock_freq freq)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        /* assert soft reset */
+        cx25840_and_or(client, 0x810, ~0x1, 0x01);
+
+        /* common for all inputs and rates */
+        /* SA_MCLK_SEL=1, SA_MCLK_DIV=0x10 */
+        cx25840_write(client, 0x127, 0x50);
+
+        switch (state->audio_input) {
+        case AUDIO_TUNER:
+                switch (freq) {
+                case V4L2_AUDCLK_32_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f040610);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0xee39bb01);
+
+                        /* src3/4/6_ctl = 0x0801f77f */
+                        cx25840_write4(client, 0x900, 0x7ff70108);
+                        cx25840_write4(client, 0x904, 0x7ff70108);
+                        cx25840_write4(client, 0x90c, 0x7ff70108);
+                        break;
+
+                case V4L2_AUDCLK_441_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f040910);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0xd66bec00);
+
+                        /* src3/4/6_ctl = 0x08016d59 */
+                        cx25840_write4(client, 0x900, 0x596d0108);
+                        cx25840_write4(client, 0x904, 0x596d0108);
+                        cx25840_write4(client, 0x90c, 0x596d0108);
+                        break;
+
+                case V4L2_AUDCLK_48_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f040a10);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0xe5d69800);
+
+                        /* src3/4/6_ctl = 0x08014faa */
+                        cx25840_write4(client, 0x900, 0xaa4f0108);
+                        cx25840_write4(client, 0x904, 0xaa4f0108);
+                        cx25840_write4(client, 0x90c, 0xaa4f0108);
+                        break;
+                }
+                break;
+
+        case AUDIO_EXTERN_1:
+        case AUDIO_EXTERN_2:
+        case AUDIO_INTERN:
+        case AUDIO_RADIO:
+                switch (freq) {
+                case V4L2_AUDCLK_32_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f04081e);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0x69082a01);
+
+                        /* src1_ctl = 0x08010000 */
+                        cx25840_write4(client, 0x8f8, 0x00000108);
+
+                        /* src3/4/6_ctl = 0x08020000 */
+                        cx25840_write4(client, 0x900, 0x00000208);
+                        cx25840_write4(client, 0x904, 0x00000208);
+                        cx25840_write4(client, 0x90c, 0x00000208);
+
+                        /* SA_MCLK_SEL=1, SA_MCLK_DIV=0x14 */
+                        cx25840_write(client, 0x127, 0x54);
+                        break;
+
+                case V4L2_AUDCLK_441_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f040918);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0xd66bec00);
+
+                        /* src1_ctl = 0x08010000 */
+                        cx25840_write4(client, 0x8f8, 0xcd600108);
+
+                        /* src3/4/6_ctl = 0x08020000 */
+                        cx25840_write4(client, 0x900, 0x85730108);
+                        cx25840_write4(client, 0x904, 0x85730108);
+                        cx25840_write4(client, 0x90c, 0x85730108);
+                        break;
+
+                case V4L2_AUDCLK_48_KHZ:
+                        /* VID_PLL and AUX_PLL */
+                        cx25840_write4(client, 0x108, 0x0f040a18);
+
+                        /* AUX_PLL_FRAC */
+                        cx25840_write4(client, 0x110, 0xe5d69800);
+
+                        /* src1_ctl = 0x08010000 */
+                        cx25840_write4(client, 0x8f8, 0x00800108);
+
+                        /* src3/4/6_ctl = 0x08020000 */
+                        cx25840_write4(client, 0x900, 0x55550108);
+                        cx25840_write4(client, 0x904, 0x55550108);
+                        cx25840_write4(client, 0x90c, 0x55550108);
+                        break;
+                }
+                break;
+        }
+
+        /* deassert soft reset */
+        cx25840_and_or(client, 0x810, ~0x1, 0x00);
+
+        state->audclk_freq = freq;
+
+        return 0;
+}
+
+static int set_input(struct i2c_client *client, int audio_input)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        cx25840_dbg("set audio input (%d)\n", audio_input);
+
+        /* stop microcontroller */
+        cx25840_and_or(client, 0x803, ~0x10, 0);
+
+        /* Mute everything to prevent the PFFT! */
+        cx25840_write(client, 0x8d3, 0x1f);
+
+        switch (audio_input) {
+        case AUDIO_TUNER:
+                /* Set Path1 to Analog Demod Main Channel */
+                cx25840_write4(client, 0x8d0, 0x7038061f);
+
+                /* When the microcontroller detects the
+                 * audio format, it will unmute the lines */
+                cx25840_and_or(client, 0x803, ~0x10, 0x10);
+                break;
+
+        case AUDIO_EXTERN_1:
+        case AUDIO_EXTERN_2:
+        case AUDIO_INTERN:
+        case AUDIO_RADIO:
+                /* Set Path1 to Serial Audio Input */
+                cx25840_write4(client, 0x8d0, 0x12100101);
+
+                /* The microcontroller should not be started for the
+                 * non-tuner inputs: autodetection is specific for
+                 * TV audio. */
+                break;
+
+        default:
+                cx25840_dbg("Invalid audio input selection %d\n", audio_input);
+                return -EINVAL;
+        }
+
+        state->audio_input = audio_input;
+
+        return set_audclk_freq(client, state->audclk_freq);
+}
+
+inline static int get_volume(struct i2c_client *client)
+{
+        /* Volume runs +18dB to -96dB in 1/2dB steps
+         * change to fit the msp3400 -114dB to +12dB range */
+
+        /* check PATH1_VOLUME */
+        int vol = 228 - cx25840_read(client, 0x8d4);
+        vol = (vol / 2) + 23;
+        return vol << 9;
+}
+
+inline static void set_volume(struct i2c_client *client, int volume)
+{
+        /* First convert the volume to msp3400 values (0-127) */
+        int vol = volume >> 9;
+        /* now scale it up to cx25840 values
+         * -114dB to -96dB maps to 0
+         * this should be 19, but in my testing that was 4dB too loud */
+        if (vol <= 23) {
+                vol = 0;
+        } else {
+                vol -= 23;
+        }
+
+        /* PATH1_VOLUME */
+        cx25840_write(client, 0x8d4, 228 - (vol * 2));
+}
+
+inline static int get_bass(struct i2c_client *client)
+{
+        /* bass is 49 steps +12dB to -12dB */
+
+        /* check PATH1_EQ_BASS_VOL */
+        int bass = cx25840_read(client, 0x8d9) & 0x3f;
+        bass = (((48 - bass) * 0xffff) + 47) / 48;
+        return bass;
+}
+
+inline static void set_bass(struct i2c_client *client, int bass)
+{
+        /* PATH1_EQ_BASS_VOL */
+        cx25840_and_or(client, 0x8d9, ~0x3f, 48 - (bass * 48 / 0xffff));
+}
+
+inline static int get_treble(struct i2c_client *client)
+{
+        /* treble is 49 steps +12dB to -12dB */
+
+        /* check PATH1_EQ_TREBLE_VOL */
+        int treble = cx25840_read(client, 0x8db) & 0x3f;
+        treble = (((48 - treble) * 0xffff) + 47) / 48;
+        return treble;
+}
+
+inline static void set_treble(struct i2c_client *client, int treble)
+{
+        /* PATH1_EQ_TREBLE_VOL */
+        cx25840_and_or(client, 0x8db, ~0x3f, 48 - (treble * 48 / 0xffff));
+}
+
+inline static int get_balance(struct i2c_client *client)
+{
+        /* balance is 7 bit, 0 to -96dB */
+
+        /* check PATH1_BAL_LEVEL */
+        int balance = cx25840_read(client, 0x8d5) & 0x7f;
+        /* check PATH1_BAL_LEFT */
+        if ((cx25840_read(client, 0x8d5) & 0x80) == 0)
+                balance = 0x80 - balance;
+        else
+                balance = 0x80 + balance;
+        return balance << 8;
+}
+
+inline static void set_balance(struct i2c_client *client, int balance)
+{
+        int bal = balance >> 8;
+        if (bal > 0x80) {
+                /* PATH1_BAL_LEFT */
+                cx25840_and_or(client, 0x8d5, 0x7f, 0x80);
+                /* PATH1_BAL_LEVEL */
+                cx25840_and_or(client, 0x8d5, ~0x7f, bal & 0x7f);
+        } else {
+                /* PATH1_BAL_LEFT */
+                cx25840_and_or(client, 0x8d5, 0x7f, 0x00);
+                /* PATH1_BAL_LEVEL */
+                cx25840_and_or(client, 0x8d5, ~0x7f, 0x80 - bal);
+        }
+}
+
+inline static int get_mute(struct i2c_client *client)
+{
+        /* check SRC1_MUTE_EN */
+        return cx25840_read(client, 0x8d3) & 0x2 ? 1 : 0;
+}
+
+inline static void set_mute(struct i2c_client *client, int mute)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        if (state->audio_input == AUDIO_TUNER) {
+                /* Must turn off microcontroller in order to mute sound.
+                 * Not sure if this is the best method, but it does work.
+                 * If the microcontroller is running, then it will undo any
+                 * changes to the mute register. */
+                if (mute) {
+                        /* disable microcontroller */
+                        cx25840_and_or(client, 0x803, ~0x10, 0x00);
+                        cx25840_write(client, 0x8d3, 0x1f);
+                } else {
+                        /* enable microcontroller */
+                        cx25840_and_or(client, 0x803, ~0x10, 0x10);
+                }
+        } else {
+                /* SRC1_MUTE_EN */
+                cx25840_and_or(client, 0x8d3, ~0x2, mute ? 0x02 : 0x00);
+        }
+}
+
+int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg)
+{
+        struct v4l2_control *ctrl = arg;
+
+        switch (cmd) {
+        case AUDC_SET_INPUT:
+                return set_input(client, *(int *)arg);
+        case VIDIOC_INT_AUDIO_CLOCK_FREQ:
+                return set_audclk_freq(client, *(enum v4l2_audio_clock_freq *)arg);
+        case VIDIOC_G_CTRL:
+                switch (ctrl->id) {
+                case V4L2_CID_AUDIO_VOLUME:
+                        ctrl->value = get_volume(client);
+                        break;
+                case V4L2_CID_AUDIO_BASS:
+                        ctrl->value = get_bass(client);
+                        break;
+                case V4L2_CID_AUDIO_TREBLE:
+                        ctrl->value = get_treble(client);
+                        break;
+                case V4L2_CID_AUDIO_BALANCE:
+                        ctrl->value = get_balance(client);
+                        break;
+                case V4L2_CID_AUDIO_MUTE:
+                        ctrl->value = get_mute(client);
+                        break;
+                default:
+                        return -EINVAL;
+                }
+                break;
+        case VIDIOC_S_CTRL:
+                switch (ctrl->id) {
+                case V4L2_CID_AUDIO_VOLUME:
+                        set_volume(client, ctrl->value);
+                        break;
+                case V4L2_CID_AUDIO_BASS:
+                        set_bass(client, ctrl->value);
+                        break;
+                case V4L2_CID_AUDIO_TREBLE:
+                        set_treble(client, ctrl->value);
+                        break;
+                case V4L2_CID_AUDIO_BALANCE:
+                        set_balance(client, ctrl->value);
+                        break;
+                case V4L2_CID_AUDIO_MUTE:
+                        set_mute(client, ctrl->value);
+                        break;
+                default:
+                        return -EINVAL;
+                }
+                break;
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
new file mode 100644
index 000000000000..f6afeec499c5
--- /dev/null
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -0,0 +1,1020 @@
+/* cx25840 - Conexant CX25840 audio/video decoder driver
+ *
+ * Copyright (C) 2004 Ulf Eklund
+ *
+ * Based on the saa7115 driver and on the first verison of Chris Kennedy's
+ * cx25840 driver.
+ *
+ * Changes by Tyler Trafford <tatrafford@comcast.net>
+ *    - cleanup/rewrite for V4L2 API (2005)
+ *
+ * VBI support by Hans Verkuil <hverkuil@xs4all.nl>.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/videodev2.h>
+#include <linux/i2c.h>
+#include <media/audiochip.h>
+#include <media/v4l2-common.h>
+
+#include "cx25840.h"
+
+MODULE_DESCRIPTION("Conexant CX25840 audio/video decoder driver");
+MODULE_AUTHOR("Ulf Eklund, Chris Kennedy, Hans Verkuil, Tyler Trafford");
+MODULE_LICENSE("GPL");
+
+static unsigned short normal_i2c[] = { 0x88 >> 1, I2C_CLIENT_END };
+
+
+int cx25840_debug = 0;
+
+module_param(cx25840_debug, bool, 0644);
+
+MODULE_PARM_DESC(cx25840_debug, "Debugging messages [0=Off (default) 1=On]");
+
+I2C_CLIENT_INSMOD;
+
+/* ----------------------------------------------------------------------- */
+
+int cx25840_write(struct i2c_client *client, u16 addr, u8 value)
+{
+        u8 buffer[3];
+        buffer[0] = addr >> 8;
+        buffer[1] = addr & 0xff;
+        buffer[2] = value;
+        return i2c_master_send(client, buffer, 3);
+}
+
+int cx25840_write4(struct i2c_client *client, u16 addr, u32 value)
+{
+        u8 buffer[6];
+        buffer[0] = addr >> 8;
+        buffer[1] = addr & 0xff;
+        buffer[2] = value >> 24;
+        buffer[3] = (value >> 16) & 0xff;
+        buffer[4] = (value >> 8) & 0xff;
+        buffer[5] = value & 0xff;
+        return i2c_master_send(client, buffer, 6);
+}
+
+u8 cx25840_read(struct i2c_client * client, u16 addr)
+{
+        u8 buffer[2];
+        buffer[0] = addr >> 8;
+        buffer[1] = addr & 0xff;
+
+        if (i2c_master_send(client, buffer, 2) < 2)
+                return 0;
+
+        if (i2c_master_recv(client, buffer, 1) < 1)
+                return 0;
+
+        return buffer[0];
+}
+
+u32 cx25840_read4(struct i2c_client * client, u16 addr)
+{
+        u8 buffer[4];
+        buffer[0] = addr >> 8;
+        buffer[1] = addr & 0xff;
+
+        if (i2c_master_send(client, buffer, 2) < 2)
+                return 0;
+
+        if (i2c_master_recv(client, buffer, 4) < 4)
+                return 0;
+
+        return (buffer[0] << 24) | (buffer[1] << 16) |
+            (buffer[2] << 8) | buffer[3];
+}
+
+int cx25840_and_or(struct i2c_client *client, u16 addr, u8 and_mask,
+                   u8 or_value)
+{
+        return cx25840_write(client, addr,
+                             (cx25840_read(client, addr) & and_mask) |
+                             or_value);
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int set_input(struct i2c_client *, enum cx25840_input);
+static void input_change(struct i2c_client *);
+static void log_status(struct i2c_client *client);
+
+/* ----------------------------------------------------------------------- */
+
+static inline void init_dll1(struct i2c_client *client)
+{
+        /* This is the Hauppauge sequence used to
+         * initialize the Delay Lock Loop 1 (ADC DLL). */
+        cx25840_write(client, 0x159, 0x23);
+        cx25840_write(client, 0x15a, 0x87);
+        cx25840_write(client, 0x15b, 0x06);
+        cx25840_write(client, 0x159, 0xe1);
+        cx25840_write(client, 0x15a, 0x86);
+        cx25840_write(client, 0x159, 0xe0);
+        cx25840_write(client, 0x159, 0xe1);
+        cx25840_write(client, 0x15b, 0x10);
+}
+
+static inline void init_dll2(struct i2c_client *client)
+{
+        /* This is the Hauppauge sequence used to
+         * initialize the Delay Lock Loop 2 (ADC DLL). */
+        cx25840_write(client, 0x15d, 0xe3);
+        cx25840_write(client, 0x15e, 0x86);
+        cx25840_write(client, 0x15f, 0x06);
+        cx25840_write(client, 0x15d, 0xe1);
+        cx25840_write(client, 0x15d, 0xe0);
+        cx25840_write(client, 0x15d, 0xe1);
+}
+
+static void cx25840_initialize(struct i2c_client *client, int loadfw)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        /* datasheet startup in numbered steps, refer to page 3-77 */
+        /* 2. */
+        cx25840_and_or(client, 0x803, ~0x10, 0x00);
+        /* The default of this register should be 4, but I get 0 instead.
+         * Set this register to 4 manually. */
+        cx25840_write(client, 0x000, 0x04);
+        /* 3. */
+        init_dll1(client);
+        init_dll2(client);
+        cx25840_write(client, 0x136, 0x0a);
+        /* 4. */
+        cx25840_write(client, 0x13c, 0x01);
+        cx25840_write(client, 0x13c, 0x00);
+        /* 5. */
+        if (loadfw)
+                cx25840_loadfw(client);
+        /* 6. */
+        cx25840_write(client, 0x115, 0x8c);
+        cx25840_write(client, 0x116, 0x07);
+        cx25840_write(client, 0x118, 0x02);
+        /* 7. */
+        cx25840_write(client, 0x4a5, 0x80);
+        cx25840_write(client, 0x4a5, 0x00);
+        cx25840_write(client, 0x402, 0x00);
+        /* 8. */
+        cx25840_write(client, 0x401, 0x18);
+        cx25840_write(client, 0x4a2, 0x10);
+        cx25840_write(client, 0x402, 0x04);
+        /* 10. */
+        cx25840_write(client, 0x8d3, 0x1f);
+        cx25840_write(client, 0x8e3, 0x03);
+
+        cx25840_vbi_setup(client);
+
+        /* trial and error says these are needed to get audio */
+        cx25840_write(client, 0x914, 0xa0);
+        cx25840_write(client, 0x918, 0xa0);
+        cx25840_write(client, 0x919, 0x01);
+
+        /* stereo prefered */
+        cx25840_write(client, 0x809, 0x04);
+        /* AC97 shift */
+        cx25840_write(client, 0x8cf, 0x0f);
+
+        /* (re)set video input */
+        set_input(client, state->input);
+        /* (re)set audio input */
+        cx25840_audio(client, AUDC_SET_INPUT, &state->audio_input);
+
+        /* start microcontroller */
+        cx25840_and_or(client, 0x803, ~0x10, 0x10);
+}
+
+/* ----------------------------------------------------------------------- */
+
+static void input_change(struct i2c_client *client)
+{
+        v4l2_std_id std = cx25840_get_v4lstd(client);
+
+        if (std & V4L2_STD_PAL) {
+                /* Follow tuner change procedure for PAL */
+                cx25840_write(client, 0x808, 0xff);
+                cx25840_write(client, 0x80b, 0x10);
+        } else if (std & V4L2_STD_SECAM) {
+                /* Select autodetect for SECAM */
+                cx25840_write(client, 0x808, 0xff);
+                cx25840_write(client, 0x80b, 0x10);
+        } else if (std & V4L2_STD_NTSC) {
+                /* NTSC */
+                cx25840_write(client, 0x808, 0xf6);
+                cx25840_write(client, 0x80b, 0x00);
+        }
+
+        if (cx25840_read(client, 0x803) & 0x10) {
+                /* restart audio decoder microcontroller */
+                cx25840_and_or(client, 0x803, ~0x10, 0x00);
+                cx25840_and_or(client, 0x803, ~0x10, 0x10);
+        }
+}
+
+static int set_input(struct i2c_client *client, enum cx25840_input input)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        cx25840_dbg("decoder set input (%d)\n", input);
+
+        switch (input) {
+        case CX25840_TUNER:
+                cx25840_dbg("now setting Tuner input\n");
+
+                if (state->cardtype == CARDTYPE_PVR150) {
+                        /* CH_SEL_ADC2=1 */
+                        cx25840_and_or(client, 0x102, ~0x2, 0x02);
+                }
+
+                /* Video Input Control */
+                if (state->cardtype == CARDTYPE_PG600) {
+                        cx25840_write(client, 0x103, 0x11);
+                } else {
+                        cx25840_write(client, 0x103, 0x46);
+                }
+
+                /* INPUT_MODE=0 */
+                cx25840_and_or(client, 0x401, ~0x6, 0x00);
+                break;
+
+        case CX25840_COMPOSITE0:
+        case CX25840_COMPOSITE1:
+                cx25840_dbg("now setting Composite input\n");
+
+                /* Video Input Control */
+                if (state->cardtype == CARDTYPE_PG600) {
+                        cx25840_write(client, 0x103, 0x00);
+                } else {
+                        cx25840_write(client, 0x103, 0x02);
+                }
+
+                /* INPUT_MODE=0 */
+                cx25840_and_or(client, 0x401, ~0x6, 0x00);
+                break;
+
+        case CX25840_SVIDEO0:
+        case CX25840_SVIDEO1:
+                cx25840_dbg("now setting S-Video input\n");
+
+                /* CH_SEL_ADC2=0 */
+                cx25840_and_or(client, 0x102, ~0x2, 0x00);
+
+                /* Video Input Control */
+                if (state->cardtype == CARDTYPE_PG600) {
+                        cx25840_write(client, 0x103, 0x02);
+                } else {
+                        cx25840_write(client, 0x103, 0x10);
+                }
+
+                /* INPUT_MODE=1 */
+                cx25840_and_or(client, 0x401, ~0x6, 0x02);
+                break;
+
+        default:
+                cx25840_err("%d is not a valid input!\n", input);
+                return -EINVAL;
+        }
+
+        state->input = input;
+        input_change(client);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int set_v4lstd(struct i2c_client *client, v4l2_std_id std)
+{
+        u8 fmt;
+
+        switch (std) {
+        /* zero is autodetect */
+        case 0: fmt = 0x0; break;
+        /* default ntsc to ntsc-m */
+        case V4L2_STD_NTSC:
+        case V4L2_STD_NTSC_M: fmt = 0x1; break;
+        case V4L2_STD_NTSC_M_JP: fmt = 0x2; break;
+        case V4L2_STD_NTSC_443: fmt = 0x3; break;
+        case V4L2_STD_PAL: fmt = 0x4; break;
+        case V4L2_STD_PAL_M: fmt = 0x5; break;
+        case V4L2_STD_PAL_N: fmt = 0x6; break;
+        case V4L2_STD_PAL_Nc: fmt = 0x7; break;
+        case V4L2_STD_PAL_60: fmt = 0x8; break;
+        case V4L2_STD_SECAM: fmt = 0xc; break;
+        default:
+                return -ERANGE;
+        }
+
+        cx25840_and_or(client, 0x400, ~0xf, fmt);
+        cx25840_vbi_setup(client);
+        return 0;
+}
+
+v4l2_std_id cx25840_get_v4lstd(struct i2c_client * client)
+{
+        /* check VID_FMT_SEL first */
+        u8 fmt = cx25840_read(client, 0x400) & 0xf;
+
+        if (!fmt) {
+                /* check AFD_FMT_STAT if set to autodetect */
+                fmt = cx25840_read(client, 0x40d) & 0xf;
+        }
+
+        switch (fmt) {
+        case 0x1: return V4L2_STD_NTSC_M;
+        case 0x2: return V4L2_STD_NTSC_M_JP;
+        case 0x3: return V4L2_STD_NTSC_443;
+        case 0x4: return V4L2_STD_PAL;
+        case 0x5: return V4L2_STD_PAL_M;
+        case 0x6: return V4L2_STD_PAL_N;
+        case 0x7: return V4L2_STD_PAL_Nc;
+        case 0x8: return V4L2_STD_PAL_60;
+        case 0xc: return V4L2_STD_SECAM;
+        default: return V4L2_STD_UNKNOWN;
+        }
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case CX25840_CID_CARDTYPE:
+                switch (ctrl->value) {
+                case CARDTYPE_PVR150:
+                case CARDTYPE_PG600:
+                        state->cardtype = ctrl->value;
+                        break;
+                default:
+                        return -ERANGE;
+                }
+
+                set_input(client, state->input);
+                break;
+
+        case V4L2_CID_BRIGHTNESS:
+                if (ctrl->value < 0 || ctrl->value > 255) {
+                        cx25840_err("invalid brightness setting %d\n",
+                                    ctrl->value);
+                        return -ERANGE;
+                }
+
+                cx25840_write(client, 0x414, ctrl->value - 128);
+                break;
+
+        case V4L2_CID_CONTRAST:
+                if (ctrl->value < 0 || ctrl->value > 127) {
+                        cx25840_err("invalid contrast setting %d\n",
+                                    ctrl->value);
+                        return -ERANGE;
+                }
+
+                cx25840_write(client, 0x415, ctrl->value << 1);
+                break;
+
+        case V4L2_CID_SATURATION:
+                if (ctrl->value < 0 || ctrl->value > 127) {
+                        cx25840_err("invalid saturation setting %d\n",
+                                    ctrl->value);
+                        return -ERANGE;
+                }
+
+                cx25840_write(client, 0x420, ctrl->value << 1);
+                cx25840_write(client, 0x421, ctrl->value << 1);
+                break;
+
+        case V4L2_CID_HUE:
+                if (ctrl->value < -127 || ctrl->value > 127) {
+                        cx25840_err("invalid hue setting %d\n", ctrl->value);
+                        return -ERANGE;
+                }
+
+                cx25840_write(client, 0x422, ctrl->value);
+                break;
+
+        case V4L2_CID_AUDIO_VOLUME:
+        case V4L2_CID_AUDIO_BASS:
+        case V4L2_CID_AUDIO_TREBLE:
+        case V4L2_CID_AUDIO_BALANCE:
+        case V4L2_CID_AUDIO_MUTE:
+                return cx25840_audio(client, VIDIOC_S_CTRL, ctrl);
+        }
+
+        return 0;
+}
+
+static int get_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case CX25840_CID_CARDTYPE:
+                ctrl->value = state->cardtype;
+                break;
+        case V4L2_CID_BRIGHTNESS:
+                ctrl->value = cx25840_read(client, 0x414) + 128;
+                break;
+        case V4L2_CID_CONTRAST:
+                ctrl->value = cx25840_read(client, 0x415) >> 1;
+                break;
+        case V4L2_CID_SATURATION:
+                ctrl->value = cx25840_read(client, 0x420) >> 1;
+                break;
+        case V4L2_CID_HUE:
+                ctrl->value = cx25840_read(client, 0x422);
+                break;
+        case V4L2_CID_AUDIO_VOLUME:
+        case V4L2_CID_AUDIO_BASS:
+        case V4L2_CID_AUDIO_TREBLE:
+        case V4L2_CID_AUDIO_BALANCE:
+        case V4L2_CID_AUDIO_MUTE:
+                return cx25840_audio(client, VIDIOC_G_CTRL, ctrl);
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int get_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
+{
+        switch (fmt->type) {
+        case V4L2_BUF_TYPE_SLICED_VBI_CAPTURE:
+                return cx25840_vbi(client, VIDIOC_G_FMT, fmt);
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+static int set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
+{
+        struct v4l2_pix_format *pix;
+        int HSC, VSC, Vsrc, Hsrc, filter, Vlines;
+        int is_pal = !(cx25840_get_v4lstd(client) & V4L2_STD_NTSC);
+
+        switch (fmt->type) {
+        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+                pix = &(fmt->fmt.pix);
+
+                Vsrc = (cx25840_read(client, 0x476) & 0x3f) << 4;
+                Vsrc |= (cx25840_read(client, 0x475) & 0xf0) >> 4;
+
+                Hsrc = (cx25840_read(client, 0x472) & 0x3f) << 4;
+                Hsrc |= (cx25840_read(client, 0x471) & 0xf0) >> 4;
+
+                Vlines = pix->height + (is_pal ? 4 : 7);
+
+                if ((pix->width * 16 < Hsrc) || (Hsrc < pix->width) ||
+                    (Vlines * 8 < Vsrc) || (Vsrc < Vlines)) {
+                        cx25840_err("%dx%d is not a valid size!\n",
+                                    pix->width, pix->height);
+                        return -ERANGE;
+                }
+
+                HSC = (Hsrc * (1 << 20)) / pix->width - (1 << 20);
+                VSC = (1 << 16) - (Vsrc * (1 << 9) / Vlines - (1 << 9));
+                VSC &= 0x1fff;
+
+                if (pix->width >= 385)
+                        filter = 0;
+                else if (pix->width > 192)
+                        filter = 1;
+                else if (pix->width > 96)
+                        filter = 2;
+                else
+                        filter = 3;
+
+                cx25840_dbg("decoder set size %dx%d -> scale  %ux%u\n",
+                            pix->width, pix->height, HSC, VSC);
+
+                /* HSCALE=HSC */
+                cx25840_write(client, 0x418, HSC & 0xff);
+                cx25840_write(client, 0x419, (HSC >> 8) & 0xff);
+                cx25840_write(client, 0x41a, HSC >> 16);
+                /* VSCALE=VSC */
+                cx25840_write(client, 0x41c, VSC & 0xff);
+                cx25840_write(client, 0x41d, VSC >> 8);
+                /* VS_INTRLACE=1 VFILT=filter */
+                cx25840_write(client, 0x41e, 0x8 | filter);
+                break;
+
+        case V4L2_BUF_TYPE_SLICED_VBI_CAPTURE:
+                return cx25840_vbi(client, VIDIOC_S_FMT, fmt);
+
+        case V4L2_BUF_TYPE_VBI_CAPTURE:
+                return cx25840_vbi(client, VIDIOC_S_FMT, fmt);
+
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int cx25840_command(struct i2c_client *client, unsigned int cmd,
+                           void *arg)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+        struct v4l2_tuner *vt = arg;
+        int result = 0;
+
+        switch (cmd) {
+        case 0:
+                break;
+
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+        /* ioctls to allow direct access to the
+         * cx25840 registers for testing */
+        case VIDIOC_INT_G_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_CX25840)
+                        return -EINVAL;
+                reg->val = cx25840_read(client, reg->reg & 0x0fff);
+                break;
+        }
+
+        case VIDIOC_INT_S_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_CX25840)
+                        return -EINVAL;
+                if (!capable(CAP_SYS_ADMIN))
+                        return -EPERM;
+                cx25840_write(client, reg->reg & 0x0fff, reg->val & 0xff);
+                break;
+        }
+#endif
+
+        case VIDIOC_INT_DECODE_VBI_LINE:
+                return cx25840_vbi(client, cmd, arg);
+
+        case VIDIOC_INT_AUDIO_CLOCK_FREQ:
+        case AUDC_SET_INPUT:
+                result = cx25840_audio(client, cmd, arg);
+                break;
+
+        case VIDIOC_STREAMON:
+                cx25840_dbg("enable output\n");
+                cx25840_write(client, 0x115, 0x8c);
+                cx25840_write(client, 0x116, 0x07);
+                break;
+
+        case VIDIOC_STREAMOFF:
+                cx25840_dbg("disable output\n");
+                cx25840_write(client, 0x115, 0x00);
+                cx25840_write(client, 0x116, 0x00);
+                break;
+
+        case VIDIOC_LOG_STATUS:
+                log_status(client);
+                break;
+
+        case VIDIOC_G_CTRL:
+                result = get_v4lctrl(client, (struct v4l2_control *)arg);
+                break;
+
+        case VIDIOC_S_CTRL:
+                result = set_v4lctrl(client, (struct v4l2_control *)arg);
+                break;
+
+        case VIDIOC_G_STD:
+                *(v4l2_std_id *)arg = cx25840_get_v4lstd(client);
+                break;
+
+        case VIDIOC_S_STD:
+                result = set_v4lstd(client, *(v4l2_std_id *)arg);
+                break;
+
+        case VIDIOC_G_INPUT:
+                *(int *)arg = state->input;
+                break;
+
+        case VIDIOC_S_INPUT:
+                result = set_input(client, *(int *)arg);
+                break;
+
+        case VIDIOC_S_FREQUENCY:
+                input_change(client);
+                break;
+
+        case VIDIOC_G_TUNER:
+        {
+                u8 mode = cx25840_read(client, 0x804);
+                u8 pref = cx25840_read(client, 0x809) & 0xf;
+                u8 vpres = cx25840_read(client, 0x80a) & 0x10;
+                int val = 0;
+
+                vt->capability |=
+                    V4L2_TUNER_CAP_STEREO | V4L2_TUNER_CAP_LANG1 |
+                    V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
+
+                vt->signal = vpres ? 0xffff : 0x0;
+
+                /* get rxsubchans and audmode */
+                if ((mode & 0xf) == 1)
+                        val |= V4L2_TUNER_SUB_STEREO;
+                else
+                        val |= V4L2_TUNER_SUB_MONO;
+
+                if (mode == 2 || mode == 4)
+                        val |= V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+
+                if (mode & 0x10)
+                        val |= V4L2_TUNER_SUB_SAP;
+
+                vt->rxsubchans = val;
+
+                switch (pref) {
+                case 0:
+                        vt->audmode = V4L2_TUNER_MODE_MONO;
+                        break;
+                case 1:
+                case 2:
+                        vt->audmode = V4L2_TUNER_MODE_LANG2;
+                        break;
+                case 4:
+                default:
+                        vt->audmode = V4L2_TUNER_MODE_STEREO;
+                }
+                break;
+        }
+
+        case VIDIOC_S_TUNER:
+                switch (vt->audmode) {
+                case V4L2_TUNER_MODE_MONO:
+                case V4L2_TUNER_MODE_LANG1:
+                        /* Force PREF_MODE to MONO */
+                        cx25840_and_or(client, 0x809, ~0xf, 0x00);
+                        break;
+                case V4L2_TUNER_MODE_STEREO:
+                        /* Force PREF_MODE to STEREO */
+                        cx25840_and_or(client, 0x809, ~0xf, 0x04);
+                        break;
+                case V4L2_TUNER_MODE_LANG2:
+                        /* Force PREF_MODE to LANG2 */
+                        cx25840_and_or(client, 0x809, ~0xf, 0x01);
+                        break;
+                }
+                break;
+
+        case VIDIOC_G_FMT:
+                result = get_v4lfmt(client, (struct v4l2_format *)arg);
+                break;
+
+        case VIDIOC_S_FMT:
+                result = set_v4lfmt(client, (struct v4l2_format *)arg);
+                break;
+
+        case VIDIOC_INT_RESET:
+                cx25840_initialize(client, 0);
+                break;
+
+        case VIDIOC_INT_G_CHIP_IDENT:
+                *(enum v4l2_chip_ident *)arg =
+                        V4L2_IDENT_CX25840 + ((cx25840_read(client, 0x100) >> 4) & 0xf);
+                break;
+
+        default:
+                cx25840_err("invalid ioctl %x\n", cmd);
+                return -EINVAL;
+        }
+
+        return result;
+}
+
+/* ----------------------------------------------------------------------- */
+
+struct i2c_driver i2c_driver_cx25840;
+
+static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
+                                 int kind)
+{
+        struct i2c_client *client;
+        struct cx25840_state *state;
+        u16 device_id;
+
+        /* Check if the adapter supports the needed features
+         * Not until kernel version 2.6.11 did the bit-algo
+         * correctly report that it would do an I2C-level xfer */
+        if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
+                return 0;
+
+        client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+        if (client == 0)
+                return -ENOMEM;
+
+        memset(client, 0, sizeof(struct i2c_client));
+        client->addr = address;
+        client->adapter = adapter;
+        client->driver = &i2c_driver_cx25840;
+        client->flags = I2C_CLIENT_ALLOW_USE;
+        snprintf(client->name, sizeof(client->name) - 1, "cx25840");
+
+        cx25840_dbg("detecting cx25840 client on address 0x%x\n", address << 1);
+
+        device_id = cx25840_read(client, 0x101) << 8;
+        device_id |= cx25840_read(client, 0x100);
+
+        /* The high byte of the device ID should be
+         * 0x84 if chip is present */
+        if ((device_id & 0xff00) != 0x8400) {
+                cx25840_dbg("cx25840 not found\n");
+                kfree(client);
+                return 0;
+        }
+
+        cx25840_info("cx25%3x-2%x found @ 0x%x (%s)\n",
+                    (device_id & 0xfff0) >> 4,
+                    (device_id & 0x0f) < 3 ? (device_id & 0x0f) + 1 : 3,
+                    address << 1, adapter->name);
+
+        state = kmalloc(sizeof(struct cx25840_state), GFP_KERNEL);
+        if (state == NULL) {
+                kfree(client);
+                return -ENOMEM;
+        }
+
+        i2c_set_clientdata(client, state);
+        memset(state, 0, sizeof(struct cx25840_state));
+        state->input = CX25840_TUNER;
+        state->audclk_freq = V4L2_AUDCLK_48_KHZ;
+        state->audio_input = AUDIO_TUNER;
+        state->cardtype = CARDTYPE_PVR150;
+
+        cx25840_initialize(client, 1);
+
+        i2c_attach_client(client);
+
+        return 0;
+}
+
+static int cx25840_attach_adapter(struct i2c_adapter *adapter)
+{
+#ifdef I2C_CLASS_TV_ANALOG
+        if (adapter->class & I2C_CLASS_TV_ANALOG)
+#else
+        if (adapter->id == I2C_HW_B_BT848)
+#endif
+                return i2c_probe(adapter, &addr_data, &cx25840_detect_client);
+        return 0;
+}
+
+static int cx25840_detach_client(struct i2c_client *client)
+{
+        struct cx25840_state *state = i2c_get_clientdata(client);
+        int err;
+
+        err = i2c_detach_client(client);
+        if (err) {
+                return err;
+        }
+
+        kfree(state);
+        kfree(client);
+
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+struct i2c_driver i2c_driver_cx25840 = {
+        .name = "cx25840",
+
+        .id = I2C_DRIVERID_CX25840,
+        .flags = I2C_DF_NOTIFY,
+
+        .attach_adapter = cx25840_attach_adapter,
+        .detach_client = cx25840_detach_client,
+        .command = cx25840_command,
+        .owner = THIS_MODULE,
+};
+
+
+static int __init m__init(void)
+{
+        return i2c_add_driver(&i2c_driver_cx25840);
+}
+
+static void __exit m__exit(void)
+{
+        i2c_del_driver(&i2c_driver_cx25840);
+}
+
+module_init(m__init);
+module_exit(m__exit);
+
+/* ----------------------------------------------------------------------- */
+
+static void log_status(struct i2c_client *client)
+{
+        static const char *const fmt_strs[] = {
+                "0x0",
+                "NTSC-M", "NTSC-J", "NTSC-4.43",
+                "PAL-BDGHI", "PAL-M", "PAL-N", "PAL-Nc", "PAL-60",
+                "0x9", "0xA", "0xB",
+                "SECAM",
+                "0xD", "0xE", "0xF"
+        };
+
+        struct cx25840_state *state = i2c_get_clientdata(client);
+        u8 microctrl_vidfmt = cx25840_read(client, 0x80a);
+        u8 vidfmt_sel = cx25840_read(client, 0x400) & 0xf;
+        u8 gen_stat1 = cx25840_read(client, 0x40d);
+        u8 download_ctl = cx25840_read(client, 0x803);
+        u8 mod_det_stat0 = cx25840_read(client, 0x804);
+        u8 mod_det_stat1 = cx25840_read(client, 0x805);
+        u8 audio_config = cx25840_read(client, 0x808);
+        u8 pref_mode = cx25840_read(client, 0x809);
+        u8 afc0 = cx25840_read(client, 0x80b);
+        u8 mute_ctl = cx25840_read(client, 0x8d3);
+        char *p;
+
+        cx25840_info("Video signal:              %spresent\n",
+                    (microctrl_vidfmt & 0x10) ? "" : "not ");
+        cx25840_info("Detected format:           %s\n",
+                    fmt_strs[gen_stat1 & 0xf]);
+
+        switch (mod_det_stat0) {
+        case 0x00: p = "mono"; break;
+        case 0x01: p = "stereo"; break;
+        case 0x02: p = "dual"; break;
+        case 0x04: p = "tri"; break;
+        case 0x10: p = "mono with SAP"; break;
+        case 0x11: p = "stereo with SAP"; break;
+        case 0x12: p = "dual with SAP"; break;
+        case 0x14: p = "tri with SAP"; break;
+        case 0xfe: p = "forced mode"; break;
+        default: p = "not defined";
+        }
+        cx25840_info("Detected audio mode:       %s\n", p);
+
+        switch (mod_det_stat1) {
+        case 0x00: p = "not defined"; break;
+        case 0x01: p = "EIAJ"; break;
+        case 0x02: p = "A2-M"; break;
+        case 0x03: p = "A2-BG"; break;
+        case 0x04: p = "A2-DK1"; break;
+        case 0x05: p = "A2-DK2"; break;
+        case 0x06: p = "A2-DK3"; break;
+        case 0x07: p = "A1 (6.0 MHz FM Mono)"; break;
+        case 0x08: p = "AM-L"; break;
+        case 0x09: p = "NICAM-BG"; break;
+        case 0x0a: p = "NICAM-DK"; break;
+        case 0x0b: p = "NICAM-I"; break;
+        case 0x0c: p = "NICAM-L"; break;
+        case 0x0d: p = "BTSC/EIAJ/A2-M Mono (4.5 MHz FMMono)"; break;
+        case 0x0e: p = "IF FM Radio"; break;
+        case 0x0f: p = "BTSC"; break;
+        case 0x10: p = "high-deviation FM"; break;
+        case 0x11: p = "very high-deviation FM"; break;
+        case 0xfd: p = "unknown audio standard"; break;
+        case 0xfe: p = "forced audio standard"; break;
+        case 0xff: p = "no detected audio standard"; break;
+        default: p = "not defined";
+        }
+        cx25840_info("Detected audio standard:   %s\n", p);
+        cx25840_info("Audio muted:               %s\n",
+                    (mute_ctl & 0x2) ? "yes" : "no");
+        cx25840_info("Audio microcontroller:     %s\n",
+                    (download_ctl & 0x10) ? "running" : "stopped");
+
+        switch (audio_config >> 4) {
+        case 0x00: p = "undefined"; break;
+        case 0x01: p = "BTSC"; break;
+        case 0x02: p = "EIAJ"; break;
+        case 0x03: p = "A2-M"; break;
+        case 0x04: p = "A2-BG"; break;
+        case 0x05: p = "A2-DK1"; break;
+        case 0x06: p = "A2-DK2"; break;
+        case 0x07: p = "A2-DK3"; break;
+        case 0x08: p = "A1 (6.0 MHz FM Mono)"; break;
+        case 0x09: p = "AM-L"; break;
+        case 0x0a: p = "NICAM-BG"; break;
+        case 0x0b: p = "NICAM-DK"; break;
+        case 0x0c: p = "NICAM-I"; break;
+        case 0x0d: p = "NICAM-L"; break;
+        case 0x0e: p = "FM radio"; break;
+        case 0x0f: p = "automatic detection"; break;
+        default: p = "undefined";
+        }
+        cx25840_info("Configured audio standard: %s\n", p);
+
+        if ((audio_config >> 4) < 0xF) {
+                switch (audio_config & 0xF) {
+                case 0x00: p = "MONO1 (LANGUAGE A/Mono L+R channel for BTSC, EIAJ, A2)"; break;
+                case 0x01: p = "MONO2 (LANGUAGE B)"; break;
+                case 0x02: p = "MONO3 (STEREO forced MONO)"; break;
+                case 0x03: p = "MONO4 (NICAM ANALOG-Language C/Analog Fallback)"; break;
+                case 0x04: p = "STEREO"; break;
+                case 0x05: p = "DUAL1 (AB)"; break;
+                case 0x06: p = "DUAL2 (AC) (FM)"; break;
+                case 0x07: p = "DUAL3 (BC) (FM)"; break;
+                case 0x08: p = "DUAL4 (AC) (AM)"; break;
+                case 0x09: p = "DUAL5 (BC) (AM)"; break;
+                case 0x0a: p = "SAP"; break;
+                default: p = "undefined";
+                }
+                cx25840_info("Configured audio mode:     %s\n", p);
+        } else {
+                switch (audio_config & 0xF) {
+                case 0x00: p = "BG"; break;
+                case 0x01: p = "DK1"; break;
+                case 0x02: p = "DK2"; break;
+                case 0x03: p = "DK3"; break;
+                case 0x04: p = "I"; break;
+                case 0x05: p = "L"; break;
+                case 0x06: p = "BTSC"; break;
+                case 0x07: p = "EIAJ"; break;
+                case 0x08: p = "A2-M"; break;
+                case 0x09: p = "FM Radio"; break;
+                case 0x0f: p = "automatic standard and mode detection"; break;
+                default: p = "undefined";
+                }
+                cx25840_info("Configured audio system:   %s\n", p);
+        }
+
+        cx25840_info("Specified standard:        %s\n",
+                    vidfmt_sel ? fmt_strs[vidfmt_sel] : "automatic detection");
+
+        switch (state->input) {
+        case CX25840_COMPOSITE0: p = "Composite 0"; break;
+        case CX25840_COMPOSITE1: p = "Composite 1"; break;
+        case CX25840_SVIDEO0: p = "S-Video 0"; break;
+        case CX25840_SVIDEO1: p = "S-Video 1"; break;
+        case CX25840_TUNER: p = "Tuner"; break;
+        }
+        cx25840_info("Specified input:           %s\n", p);
+        cx25840_info("Specified audio input:     %s\n",
+                    state->audio_input == 0 ? "Tuner" : "External");
+
+        switch (state->audclk_freq) {
+        case V4L2_AUDCLK_441_KHZ: p = "44.1 kHz"; break;
+        case V4L2_AUDCLK_48_KHZ: p = "48 kHz"; break;
+        case V4L2_AUDCLK_32_KHZ: p = "32 kHz"; break;
+        default: p = "undefined";
+        }
+        cx25840_info("Specified audioclock freq: %s\n", p);
+
+        switch (pref_mode & 0xf) {
+        case 0: p = "mono/language A"; break;
+        case 1: p = "language B"; break;
+        case 2: p = "language C"; break;
+        case 3: p = "analog fallback"; break;
+        case 4: p = "stereo"; break;
+        case 5: p = "language AC"; break;
+        case 6: p = "language BC"; break;
+        case 7: p = "language AB"; break;
+        default: p = "undefined";
+        }
+        cx25840_info("Preferred audio mode:      %s\n", p);
+
+        if ((audio_config & 0xf) == 0xf) {
+                switch ((afc0 >> 3) & 0x3) {
+                case 0: p = "system DK"; break;
+                case 1: p = "system L"; break;
+                case 2: p = "autodetect"; break;
+                default: p = "undefined";
+                }
+                cx25840_info("Selected 65 MHz format:    %s\n", p);
+
+                switch (afc0 & 0x7) {
+                case 0: p = "chroma"; break;
+                case 1: p = "BTSC"; break;
+                case 2: p = "EIAJ"; break;
+                case 3: p = "A2-M"; break;
+                case 4: p = "autodetect"; break;
+                default: p = "undefined";
+                }
+                cx25840_info("Selected 45 MHz format:    %s\n", p);
+        }
+}
diff --git a/drivers/media/video/cx25840/cx25840-firmware.c b/drivers/media/video/cx25840/cx25840-firmware.c
new file mode 100644
index 000000000000..df9d50a75542
--- /dev/null
+++ b/drivers/media/video/cx25840/cx25840-firmware.c
@@ -0,0 +1,167 @@
+/* cx25840 firmware functions
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/module.h>
+#include <linux/i2c.h>
+#include <linux/i2c-algo-bit.h>
+#include <linux/firmware.h>
+#include <media/v4l2-common.h>
+
+#include "cx25840.h"
+
+#define FWFILE "v4l-cx25840.fw"
+#define FWSEND 1024
+
+#define FWDEV(x) &((x)->adapter->dev)
+
+static int fastfw = 1;
+static char *firmware = FWFILE;
+
+module_param(fastfw, bool, 0444);
+module_param(firmware, charp, 0444);
+
+MODULE_PARM_DESC(fastfw, "Load firmware fast [0=100MHz 1=333MHz (default)]");
+MODULE_PARM_DESC(firmware, "Firmware image [default: " FWFILE "]");
+
+static inline void set_i2c_delay(struct i2c_client *client, int delay)
+{
+        struct i2c_algo_bit_data *algod = client->adapter->algo_data;
+
+        /* We aren't guaranteed to be using algo_bit,
+         * so avoid the null pointer dereference
+         * and disable the 'fast firmware load' */
+        if (algod) {
+                algod->udelay = delay;
+        } else {
+                fastfw = 0;
+        }
+}
+
+static inline void start_fw_load(struct i2c_client *client)
+{
+        /* DL_ADDR_LB=0 DL_ADDR_HB=0 */
+        cx25840_write(client, 0x800, 0x00);
+        cx25840_write(client, 0x801, 0x00);
+        // DL_MAP=3 DL_AUTO_INC=0 DL_ENABLE=1
+        cx25840_write(client, 0x803, 0x0b);
+        /* AUTO_INC_DIS=1 */
+        cx25840_write(client, 0x000, 0x20);
+
+        if (fastfw)
+                set_i2c_delay(client, 3);
+}
+
+static inline void end_fw_load(struct i2c_client *client)
+{
+        if (fastfw)
+                set_i2c_delay(client, 10);
+
+        /* AUTO_INC_DIS=0 */
+        cx25840_write(client, 0x000, 0x00);
+        /* DL_ENABLE=0 */
+        cx25840_write(client, 0x803, 0x03);
+}
+
+static inline int check_fw_load(struct i2c_client *client, int size)
+{
+        /* DL_ADDR_HB DL_ADDR_LB */
+        int s = cx25840_read(client, 0x801) << 8;
+        s |= cx25840_read(client, 0x800);
+
+        if (size != s) {
+                cx25840_err("firmware %s load failed\n", firmware);
+                return -EINVAL;
+        }
+
+        cx25840_info("loaded %s firmware (%d bytes)\n", firmware, size);
+        return 0;
+}
+
+static inline int fw_write(struct i2c_client *client, u8 * data, int size)
+{
+        if (i2c_master_send(client, data, size) < size) {
+
+                if (fastfw) {
+                        cx25840_err("333MHz i2c firmware load failed\n");
+                        fastfw = 0;
+                        set_i2c_delay(client, 10);
+
+                        if (i2c_master_send(client, data, size) < size) {
+                                cx25840_err
+                                    ("100MHz i2c firmware load failed\n");
+                                return -ENOSYS;
+                        }
+
+                } else {
+                        cx25840_err("firmware load i2c failure\n");
+                        return -ENOSYS;
+                }
+
+        }
+
+        return 0;
+}
+
+int cx25840_loadfw(struct i2c_client *client)
+{
+        const struct firmware *fw = NULL;
+        u8 buffer[4], *ptr;
+        int size, send, retval;
+
+        if (request_firmware(&fw, firmware, FWDEV(client)) != 0) {
+                cx25840_err("unable to open firmware %s\n", firmware);
+                return -EINVAL;
+        }
+
+        start_fw_load(client);
+
+        buffer[0] = 0x08;
+        buffer[1] = 0x02;
+        buffer[2] = fw->data[0];
+        buffer[3] = fw->data[1];
+        retval = fw_write(client, buffer, 4);
+
+        if (retval < 0) {
+                release_firmware(fw);
+                return retval;
+        }
+
+        size = fw->size - 2;
+        ptr = fw->data;
+        while (size > 0) {
+                ptr[0] = 0x08;
+                ptr[1] = 0x02;
+                send = size > (FWSEND - 2) ? FWSEND : size + 2;
+                retval = fw_write(client, ptr, send);
+
+                if (retval < 0) {
+                        release_firmware(fw);
+                        return retval;
+                }
+
+                size -= FWSEND - 2;
+                ptr += FWSEND - 2;
+        }
+
+        end_fw_load(client);
+
+        size = fw->size;
+        release_firmware(fw);
+
+        return check_fw_load(client, size);
+}
diff --git a/drivers/media/video/cx25840/cx25840-vbi.c b/drivers/media/video/cx25840/cx25840-vbi.c
new file mode 100644
index 000000000000..13ba4e15ddea
--- /dev/null
+++ b/drivers/media/video/cx25840/cx25840-vbi.c
@@ -0,0 +1,315 @@
+/* cx25840 VBI functions
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/videodev2.h>
+#include <linux/i2c.h>
+#include <media/v4l2-common.h>
+
+#include "cx25840.h"
+
+static inline int odd_parity(u8 c)
+{
+        c ^= (c >> 4);
+        c ^= (c >> 2);
+        c ^= (c >> 1);
+
+        return c & 1;
+}
+
+static inline int decode_vps(u8 * dst, u8 * p)
+{
+        static const u8 biphase_tbl[] = {
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xd2, 0x5a, 0x52, 0xd2, 0x96, 0x1e, 0x16, 0x96,
+                0x92, 0x1a, 0x12, 0x92, 0xd2, 0x5a, 0x52, 0xd2,
+                0xd0, 0x58, 0x50, 0xd0, 0x94, 0x1c, 0x14, 0x94,
+                0x90, 0x18, 0x10, 0x90, 0xd0, 0x58, 0x50, 0xd0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xe1, 0x69, 0x61, 0xe1, 0xa5, 0x2d, 0x25, 0xa5,
+                0xa1, 0x29, 0x21, 0xa1, 0xe1, 0x69, 0x61, 0xe1,
+                0xc3, 0x4b, 0x43, 0xc3, 0x87, 0x0f, 0x07, 0x87,
+                0x83, 0x0b, 0x03, 0x83, 0xc3, 0x4b, 0x43, 0xc3,
+                0xc1, 0x49, 0x41, 0xc1, 0x85, 0x0d, 0x05, 0x85,
+                0x81, 0x09, 0x01, 0x81, 0xc1, 0x49, 0x41, 0xc1,
+                0xe1, 0x69, 0x61, 0xe1, 0xa5, 0x2d, 0x25, 0xa5,
+                0xa1, 0x29, 0x21, 0xa1, 0xe1, 0x69, 0x61, 0xe1,
+                0xe0, 0x68, 0x60, 0xe0, 0xa4, 0x2c, 0x24, 0xa4,
+                0xa0, 0x28, 0x20, 0xa0, 0xe0, 0x68, 0x60, 0xe0,
+                0xc2, 0x4a, 0x42, 0xc2, 0x86, 0x0e, 0x06, 0x86,
+                0x82, 0x0a, 0x02, 0x82, 0xc2, 0x4a, 0x42, 0xc2,
+                0xc0, 0x48, 0x40, 0xc0, 0x84, 0x0c, 0x04, 0x84,
+                0x80, 0x08, 0x00, 0x80, 0xc0, 0x48, 0x40, 0xc0,
+                0xe0, 0x68, 0x60, 0xe0, 0xa4, 0x2c, 0x24, 0xa4,
+                0xa0, 0x28, 0x20, 0xa0, 0xe0, 0x68, 0x60, 0xe0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xd2, 0x5a, 0x52, 0xd2, 0x96, 0x1e, 0x16, 0x96,
+                0x92, 0x1a, 0x12, 0x92, 0xd2, 0x5a, 0x52, 0xd2,
+                0xd0, 0x58, 0x50, 0xd0, 0x94, 0x1c, 0x14, 0x94,
+                0x90, 0x18, 0x10, 0x90, 0xd0, 0x58, 0x50, 0xd0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+        };
+
+        u8 c, err = 0;
+        int i;
+
+        for (i = 0; i < 2 * 13; i += 2) {
+                err |= biphase_tbl[p[i]] | biphase_tbl[p[i + 1]];
+                c = (biphase_tbl[p[i + 1]] & 0xf) |
+                    ((biphase_tbl[p[i]] & 0xf) << 4);
+                dst[i / 2] = c;
+        }
+
+        return err & 0xf0;
+}
+
+void cx25840_vbi_setup(struct i2c_client *client)
+{
+        v4l2_std_id std = cx25840_get_v4lstd(client);
+
+        if (std & ~V4L2_STD_NTSC) {
+                /* datasheet startup, step 8d */
+                cx25840_write(client, 0x49f, 0x11);
+
+                cx25840_write(client, 0x470, 0x84);
+                cx25840_write(client, 0x471, 0x00);
+                cx25840_write(client, 0x472, 0x2d);
+                cx25840_write(client, 0x473, 0x5d);
+
+                cx25840_write(client, 0x474, 0x24);
+                cx25840_write(client, 0x475, 0x40);
+                cx25840_write(client, 0x476, 0x24);
+                cx25840_write(client, 0x477, 0x28);
+
+                cx25840_write(client, 0x478, 0x1f);
+                cx25840_write(client, 0x479, 0x02);
+
+                if (std & V4L2_STD_SECAM) {
+                        cx25840_write(client, 0x47a, 0x80);
+                        cx25840_write(client, 0x47b, 0x00);
+                        cx25840_write(client, 0x47c, 0x5f);
+                        cx25840_write(client, 0x47d, 0x42);
+                } else {
+                        cx25840_write(client, 0x47a, 0x90);
+                        cx25840_write(client, 0x47b, 0x20);
+                        cx25840_write(client, 0x47c, 0x63);
+                        cx25840_write(client, 0x47d, 0x82);
+                }
+
+                cx25840_write(client, 0x47e, 0x0a);
+                cx25840_write(client, 0x47f, 0x01);
+        } else {
+                /* datasheet startup, step 8d */
+                cx25840_write(client, 0x49f, 0x14);
+
+                cx25840_write(client, 0x470, 0x7a);
+                cx25840_write(client, 0x471, 0x00);
+                cx25840_write(client, 0x472, 0x2d);
+                cx25840_write(client, 0x473, 0x5b);
+
+                cx25840_write(client, 0x474, 0x1a);
+                cx25840_write(client, 0x475, 0x70);
+                cx25840_write(client, 0x476, 0x1e);
+                cx25840_write(client, 0x477, 0x1e);
+
+                cx25840_write(client, 0x478, 0x1f);
+                cx25840_write(client, 0x479, 0x02);
+                cx25840_write(client, 0x47a, 0x50);
+                cx25840_write(client, 0x47b, 0x66);
+
+                cx25840_write(client, 0x47c, 0x1f);
+                cx25840_write(client, 0x47d, 0x7c);
+                cx25840_write(client, 0x47e, 0x08);
+                cx25840_write(client, 0x47f, 0x00);
+        }
+}
+
+int cx25840_vbi(struct i2c_client *client, unsigned int cmd, void *arg)
+{
+        struct v4l2_format *fmt;
+        struct v4l2_sliced_vbi_format *svbi;
+
+        switch (cmd) {
+        case VIDIOC_G_FMT:
+        {
+                static u16 lcr2vbi[] = {
+                        0, V4L2_SLICED_TELETEXT_B, 0,   /* 1 */
+                        0, V4L2_SLICED_WSS_625, 0,      /* 4 */
+                        V4L2_SLICED_CAPTION_525,        /* 6 */
+                        0, 0, V4L2_SLICED_VPS, 0, 0,    /* 9 */
+                        0, 0, 0, 0
+                };
+                int i;
+
+                fmt = arg;
+                if (fmt->type != V4L2_BUF_TYPE_SLICED_VBI_CAPTURE)
+                        return -EINVAL;
+                svbi = &fmt->fmt.sliced;
+                memset(svbi, 0, sizeof(*svbi));
+                /* we're done if raw VBI is active */
+                if ((cx25840_read(client, 0x404) & 0x10) == 0)
+                        break;
+
+                for (i = 7; i <= 23; i++) {
+                        u8 v = cx25840_read(client, 0x424 + i - 7);
+
+                        svbi->service_lines[0][i] = lcr2vbi[v >> 4];
+                        svbi->service_lines[1][i] = lcr2vbi[v & 0xf];
+                        svbi->service_set |=
+                                 svbi->service_lines[0][i] | svbi->service_lines[1][i];
+                }
+                break;
+        }
+
+        case VIDIOC_S_FMT:
+        {
+                int is_pal = !(cx25840_get_v4lstd(client) & V4L2_STD_NTSC);
+                int vbi_offset = is_pal ? 1 : 0;
+                int i, x;
+                u8 lcr[24];
+
+                fmt = arg;
+                if (fmt->type != V4L2_BUF_TYPE_SLICED_VBI_CAPTURE)
+                        return -EINVAL;
+                svbi = &fmt->fmt.sliced;
+                if (svbi->service_set == 0) {
+                        /* raw VBI */
+                        memset(svbi, 0, sizeof(*svbi));
+
+                        /* Setup VBI */
+                        cx25840_vbi_setup(client);
+
+                        /* VBI Offset */
+                        cx25840_write(client, 0x47f, vbi_offset);
+                        cx25840_write(client, 0x404, 0x2e);
+                        break;
+                }
+
+                for (x = 0; x <= 23; x++)
+                        lcr[x] = 0x00;
+
+                /* Setup VBI */
+                cx25840_vbi_setup(client);
+
+                /* Sliced VBI */
+                cx25840_write(client, 0x404, 0x36);     /* Ancillery data */
+                cx25840_write(client, 0x406, 0x13);
+                cx25840_write(client, 0x47f, vbi_offset);
+
+                if (is_pal) {
+                        for (i = 0; i <= 6; i++)
+                                svbi->service_lines[0][i] =
+                                        svbi->service_lines[1][i] = 0;
+                } else {
+                        for (i = 0; i <= 9; i++)
+                                svbi->service_lines[0][i] =
+                                        svbi->service_lines[1][i] = 0;
+
+                        for (i = 22; i <= 23; i++)
+                                svbi->service_lines[0][i] =
+                                        svbi->service_lines[1][i] = 0;
+                }
+
+                for (i = 7; i <= 23; i++) {
+                        for (x = 0; x <= 1; x++) {
+                                switch (svbi->service_lines[1-x][i]) {
+                                case V4L2_SLICED_TELETEXT_B:
+                                        lcr[i] |= 1 << (4 * x);
+                                        break;
+                                case V4L2_SLICED_WSS_625:
+                                        lcr[i] |= 4 << (4 * x);
+                                        break;
+                                case V4L2_SLICED_CAPTION_525:
+                                        lcr[i] |= 6 << (4 * x);
+                                        break;
+                                case V4L2_SLICED_VPS:
+                                        lcr[i] |= 9 << (4 * x);
+                                        break;
+                                }
+                        }
+                }
+
+                for (x = 1, i = 0x424; i <= 0x434; i++, x++) {
+                        cx25840_write(client, i, lcr[6 + x]);
+                }
+
+                cx25840_write(client, 0x43c, 0x16);
+
+                if (is_pal) {
+                        cx25840_write(client, 0x474, 0x2a);
+                } else {
+                        cx25840_write(client, 0x474, 0x1a + 6);
+                }
+                break;
+        }
+
+        case VIDIOC_INT_DECODE_VBI_LINE:
+        {
+                struct v4l2_decode_vbi_line *vbi = arg;
+                u8 *p = vbi->p;
+                int id1, id2, l, err = 0;
+
+                if (p[0] || p[1] != 0xff || p[2] != 0xff ||
+                    (p[3] != 0x55 && p[3] != 0x91)) {
+                        vbi->line = vbi->type = 0;
+                        break;
+                }
+
+                p += 4;
+                id1 = p[-1];
+                id2 = p[0] & 0xf;
+                l = p[2] & 0x3f;
+                l += 5;
+                p += 4;
+
+                switch (id2) {
+                case 1:
+                        id2 = V4L2_SLICED_TELETEXT_B;
+                        break;
+                case 4:
+                        id2 = V4L2_SLICED_WSS_625;
+                        break;
+                case 6:
+                        id2 = V4L2_SLICED_CAPTION_525;
+                        err = !odd_parity(p[0]) || !odd_parity(p[1]);
+                        break;
+                case 9:
+                        id2 = V4L2_SLICED_VPS;
+                        if (decode_vps(p, p) != 0) {
+                                err = 1;
+                        }
+                        break;
+                default:
+                        id2 = 0;
+                        err = 1;
+                        break;
+                }
+
+                vbi->type = err ? 0 : id2;
+                vbi->line = err ? 0 : l;
+                vbi->is_second_field = err ? 0 : (id1 == 0x55);
+                vbi->p = p;
+                break;
+        }
+        }
+
+        return 0;
+}
diff --git a/drivers/media/video/cx25840/cx25840.h b/drivers/media/video/cx25840/cx25840.h
new file mode 100644
index 000000000000..5c3f0639fb77
--- /dev/null
+++ b/drivers/media/video/cx25840/cx25840.h
@@ -0,0 +1,85 @@
+/* cx25840 API header
+ *
+ * Copyright (C) 2003-2004 Chris Kennedy
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+#ifndef _CX25840_H_
+#define _CX25840_H_
+
+
+#include <linux/videodev2.h>
+#include <linux/i2c.h>
+
+extern int cx25840_debug;
+
+#define cx25840_dbg(fmt, arg...) do { if (cx25840_debug) \
+        printk(KERN_INFO "%s debug %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
+#define cx25840_err(fmt, arg...) do { \
+        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
+#define cx25840_info(fmt, arg...) do { \
+        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
+#define CX25840_CID_CARDTYPE (V4L2_CID_PRIVATE_BASE+0)
+
+enum cx25840_cardtype {
+        CARDTYPE_PVR150,
+        CARDTYPE_PG600
+};
+
+enum cx25840_input {
+        CX25840_TUNER,
+        CX25840_COMPOSITE0,
+        CX25840_COMPOSITE1,
+        CX25840_SVIDEO0,
+        CX25840_SVIDEO1
+};
+
+struct cx25840_state {
+        enum cx25840_cardtype cardtype;
+        enum cx25840_input input;
+        int audio_input;
+        enum v4l2_audio_clock_freq audclk_freq;
+};
+
+/* ----------------------------------------------------------------------- */
+/* cx25850-core.c                                                          */
+int cx25840_write(struct i2c_client *client, u16 addr, u8 value);
+int cx25840_write4(struct i2c_client *client, u16 addr, u32 value);
+u8 cx25840_read(struct i2c_client *client, u16 addr);
+u32 cx25840_read4(struct i2c_client *client, u16 addr);
+int cx25840_and_or(struct i2c_client *client, u16 addr, u8 mask, u8 value);
+v4l2_std_id cx25840_get_v4lstd(struct i2c_client *client);
+
+/* ----------------------------------------------------------------------- */
+/* cx25850-firmware.c                                                      */
+int cx25840_loadfw(struct i2c_client *client);
+
+/* ----------------------------------------------------------------------- */
+/* cx25850-audio.c                                                         */
+int cx25840_audio(struct i2c_client *client, unsigned int cmd, void *arg);
+
+/* ----------------------------------------------------------------------- */
+/* cx25850-vbi.c                                                           */
+void cx25840_vbi_setup(struct i2c_client *client);
+int cx25840_vbi(struct i2c_client *client, unsigned int cmd, void *arg);
+
+#endif
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index 9cce91ec334b..99ea955f5987 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -439,9 +439,6 @@ static int dvb_register(struct cx8802_dev *dev)
         /* Put the analog decoder in standby to keep it quiet */
         cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
 
-        /* Put the analog decoder in standby to keep it quiet */
-        cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
-
         /* register everything */
         return videobuf_dvb_register(&dev->dvb, THIS_MODULE, dev);
 }
diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c
index 32c49df58adc..9b94f77d6fd7 100644
--- a/drivers/media/video/em28xx/em28xx-input.c
+++ b/drivers/media/video/em28xx/em28xx-input.c
@@ -120,9 +120,6 @@ static int get_key_em_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
         if (buf[1]==0xff)
                 return 0;
 
-        /* avoid fast reapeating */
-        if (buf[1]==ir->old)
-                return 0;
         ir->old=buf[1];
 
         /* Rearranges bits to the right order */
diff --git a/drivers/media/video/ir-kbd-gpio.c b/drivers/media/video/ir-kbd-gpio.c
index ed81934ef3cd..5abfc0fbf6de 100644
--- a/drivers/media/video/ir-kbd-gpio.c
+++ b/drivers/media/video/ir-kbd-gpio.c
@@ -221,24 +221,99 @@ static IR_KEYTAB_TYPE ir_codes_conceptronic[IR_KEYTAB_SIZE] = {
         [ 24 ] = KEY_MUTE         // mute/unmute
 };
 
+static IR_KEYTAB_TYPE ir_codes_nebula[IR_KEYTAB_SIZE] = {
+        [0x00] = KEY_KP0,
+        [0x01] = KEY_KP1,
+        [0x02] = KEY_KP2,
+        [0x03] = KEY_KP3,
+        [0x04] = KEY_KP4,
+        [0x05] = KEY_KP5,
+        [0x06] = KEY_KP6,
+        [0x07] = KEY_KP7,
+        [0x08] = KEY_KP8,
+        [0x09] = KEY_KP9,
+        [0x0a] = KEY_TV,
+        [0x0b] = KEY_AUX,
+        [0x0c] = KEY_DVD,
+        [0x0d] = KEY_POWER,
+        [0x0e] = KEY_MHP,       /* labelled 'Picture' */
+        [0x0f] = KEY_AUDIO,
+        [0x10] = KEY_INFO,
+        [0x11] = KEY_F13,       /* 16:9 */
+        [0x12] = KEY_F14,       /* 14:9 */
+        [0x13] = KEY_EPG,
+        [0x14] = KEY_EXIT,
+        [0x15] = KEY_MENU,
+        [0x16] = KEY_UP,
+        [0x17] = KEY_DOWN,
+        [0x18] = KEY_LEFT,
+        [0x19] = KEY_RIGHT,
+        [0x1a] = KEY_ENTER,
+        [0x1b] = KEY_CHANNELUP,
+        [0x1c] = KEY_CHANNELDOWN,
+        [0x1d] = KEY_VOLUMEUP,
+        [0x1e] = KEY_VOLUMEDOWN,
+        [0x1f] = KEY_RED,
+        [0x20] = KEY_GREEN,
+        [0x21] = KEY_YELLOW,
+        [0x22] = KEY_BLUE,
+        [0x23] = KEY_SUBTITLE,
+        [0x24] = KEY_F15,       /* AD */
+        [0x25] = KEY_TEXT,
+        [0x26] = KEY_MUTE,
+        [0x27] = KEY_REWIND,
+        [0x28] = KEY_STOP,
+        [0x29] = KEY_PLAY,
+        [0x2a] = KEY_FASTFORWARD,
+        [0x2b] = KEY_F16,       /* chapter */
+        [0x2c] = KEY_PAUSE,
+        [0x2d] = KEY_PLAY,
+        [0x2e] = KEY_RECORD,
+        [0x2f] = KEY_F17,       /* picture in picture */
+        [0x30] = KEY_KPPLUS,    /* zoom in */
+        [0x31] = KEY_KPMINUS,   /* zoom out */
+        [0x32] = KEY_F18,       /* capture */
+        [0x33] = KEY_F19,       /* web */
+        [0x34] = KEY_EMAIL,
+        [0x35] = KEY_PHONE,
+        [0x36] = KEY_PC
+};
+
 struct IR {
         struct bttv_sub_device  *sub;
         struct input_dev        *input;
         struct ir_input_state   ir;
         char                    name[32];
         char                    phys[32];
+
+        /* Usual gpio signalling */
+
         u32                     mask_keycode;
         u32                     mask_keydown;
         u32                     mask_keyup;
-
-        int                     polling;
+        u32                     polling;
         u32                     last_gpio;
         struct work_struct      work;
         struct timer_list       timer;
+
+        /* RC5 gpio */
+
+        u32 rc5_gpio;
+        struct timer_list timer_end;    /* timer_end for code completion */
+        struct timer_list timer_keyup;  /* timer_end for key release */
+        u32 last_rc5;                   /* last good rc5 code */
+        u32 last_bit;                   /* last raw bit seen */
+        u32 code;                       /* raw code under construction */
+        struct timeval base_time;       /* time of last seen code */
+        int active;                     /* building raw code */
 };
 
 static int debug;
 module_param(debug, int, 0644);    /* debug level (0,1,2) */
+static int repeat_delay = 500;
+module_param(repeat_delay, int, 0644);
+static int repeat_period = 33;
+module_param(repeat_period, int, 0644);
 
 #define DEVNAME "ir-kbd-gpio"
 #define dprintk(fmt, arg...)    if (debug) \
@@ -254,7 +329,7 @@ static struct bttv_sub_driver driver = {
                 .probe  = ir_probe,
                 .remove = ir_remove,
         },
-        .gpio_irq       = ir_irq,
+        .gpio_irq       = ir_irq,
 };
 
 /* ---------------------------------------------------------------------- */
@@ -327,6 +402,173 @@ static void ir_work(void *data)
         mod_timer(&ir->timer, timeout);
 }
 
+/* ---------------------------------------------------------------*/
+
+static int rc5_remote_gap = 885;
+module_param(rc5_remote_gap, int, 0644);
+static int rc5_key_timeout = 200;
+module_param(rc5_key_timeout, int, 0644);
+
+#define RC5_START(x)    (((x)>>12)&3)
+#define RC5_TOGGLE(x)   (((x)>>11)&1)
+#define RC5_ADDR(x)     (((x)>>6)&31)
+#define RC5_INSTR(x)    ((x)&63)
+
+/* decode raw bit pattern to RC5 code */
+static u32 rc5_decode(unsigned int code)
+{
+        unsigned int org_code = code;
+        unsigned int pair;
+        unsigned int rc5 = 0;
+        int i;
+
+        code = (code << 1) | 1;
+        for (i = 0; i < 14; ++i) {
+                pair = code & 0x3;
+                code >>= 2;
+
+                rc5 <<= 1;
+                switch (pair) {
+                case 0:
+                case 2:
+                        break;
+                case 1:
+                        rc5 |= 1;
+                        break;
+                case 3:
+                        dprintk("bad code: %x\n", org_code);
+                        return 0;
+                }
+        }
+        dprintk("code=%x, rc5=%x, start=%x, toggle=%x, address=%x, "
+                "instr=%x\n", rc5, org_code, RC5_START(rc5),
+                RC5_TOGGLE(rc5), RC5_ADDR(rc5), RC5_INSTR(rc5));
+        return rc5;
+}
+
+static int ir_rc5_irq(struct bttv_sub_device *sub)
+{
+        struct IR *ir = dev_get_drvdata(&sub->dev);
+        struct timeval tv;
+        u32 gpio;
+        u32 gap;
+        unsigned long current_jiffies, timeout;
+
+        /* read gpio port */
+        gpio = bttv_gpio_read(ir->sub->core);
+
+        /* remote IRQ? */
+        if (!(gpio & 0x20))
+                return 0;
+
+        /* get time of bit */
+        current_jiffies = jiffies;
+        do_gettimeofday(&tv);
+
+        /* avoid overflow with gap >1s */
+        if (tv.tv_sec - ir->base_time.tv_sec > 1) {
+                gap = 200000;
+        } else {
+                gap = 1000000 * (tv.tv_sec - ir->base_time.tv_sec) +
+                    tv.tv_usec - ir->base_time.tv_usec;
+        }
+
+        /* active code => add bit */
+        if (ir->active) {
+                /* only if in the code (otherwise spurious IRQ or timer
+                   late) */
+                if (ir->last_bit < 28) {
+                        ir->last_bit = (gap - rc5_remote_gap / 2) /
+                            rc5_remote_gap;
+                        ir->code |= 1 << ir->last_bit;
+                }
+                /* starting new code */
+        } else {
+                ir->active = 1;
+                ir->code = 0;
+                ir->base_time = tv;
+                ir->last_bit = 0;
+
+                timeout = current_jiffies + (500 + 30 * HZ) / 1000;
+                mod_timer(&ir->timer_end, timeout);
+        }
+
+        /* toggle GPIO pin 4 to reset the irq */
+        bttv_gpio_write(ir->sub->core, gpio & ~(1 << 4));
+        bttv_gpio_write(ir->sub->core, gpio | (1 << 4));
+        return 1;
+}
+
+static void ir_rc5_timer_end(unsigned long data)
+{
+        struct IR *ir = (struct IR *)data;
+        struct timeval tv;
+        unsigned long current_jiffies, timeout;
+        u32 gap;
+
+        /* get time */
+        current_jiffies = jiffies;
+        do_gettimeofday(&tv);
+
+        /* avoid overflow with gap >1s */
+        if (tv.tv_sec - ir->base_time.tv_sec > 1) {
+                gap = 200000;
+        } else {
+                gap = 1000000 * (tv.tv_sec - ir->base_time.tv_sec) +
+                    tv.tv_usec - ir->base_time.tv_usec;
+        }
+
+        /* Allow some timmer jitter (RC5 is ~24ms anyway so this is ok) */
+        if (gap < 28000) {
+                dprintk("spurious timer_end\n");
+                return;
+        }
+
+        ir->active = 0;
+        if (ir->last_bit < 20) {
+                /* ignore spurious codes (caused by light/other remotes) */
+                dprintk("short code: %x\n", ir->code);
+        } else {
+                u32 rc5 = rc5_decode(ir->code);
+
+                /* two start bits? */
+                if (RC5_START(rc5) != 3) {
+                        dprintk("rc5 start bits invalid: %u\n", RC5_START(rc5));
+
+                        /* right address? */
+                } else if (RC5_ADDR(rc5) == 0x0) {
+                        u32 toggle = RC5_TOGGLE(rc5);
+                        u32 instr = RC5_INSTR(rc5);
+
+                        /* Good code, decide if repeat/repress */
+                        if (toggle != RC5_TOGGLE(ir->last_rc5) ||
+                            instr != RC5_INSTR(ir->last_rc5)) {
+                                dprintk("instruction %x, toggle %x\n", instr,
+                                        toggle);
+                                ir_input_nokey(ir->input, &ir->ir);
+                                ir_input_keydown(ir->input, &ir->ir, instr,
+                                                 instr);
+                        }
+
+                        /* Set/reset key-up timer */
+                        timeout = current_jiffies + (500 + rc5_key_timeout
+                                                     * HZ) / 1000;
+                        mod_timer(&ir->timer_keyup, timeout);
+
+                        /* Save code for repeat test */
+                        ir->last_rc5 = rc5;
+                }
+        }
+}
+
+static void ir_rc5_timer_keyup(unsigned long data)
+{
+        struct IR *ir = (struct IR *)data;
+
+        dprintk("key released\n");
+        ir_input_nokey(ir->input, &ir->ir);
+}
+
 /* ---------------------------------------------------------------------- */
 
 static int ir_probe(struct device *dev)
@@ -400,6 +642,12 @@ static int ir_probe(struct device *dev)
                 ir->mask_keyup   = 0x006000;
                 ir->polling      = 50; // ms
                 break;
+        case BTTV_BOARD_NEBULA_DIGITV:
+                ir_codes = ir_codes_nebula;
+                driver.any_irq = ir_rc5_irq;
+                driver.gpio_irq = NULL;
+                ir->rc5_gpio = 1;
+                 break;
         }
         if (NULL == ir_codes) {
                 kfree(ir);
@@ -407,9 +655,17 @@ static int ir_probe(struct device *dev)
                 return -ENODEV;
         }
 
-        /* init hardware-specific stuff */
-        bttv_gpio_inout(sub->core, ir->mask_keycode | ir->mask_keydown, 0);
-        ir->sub = sub;
+        if (ir->rc5_gpio) {
+                u32 gpio;
+                /* enable remote irq */
+                bttv_gpio_inout(sub->core, (1 << 4), 1 << 4);
+                gpio = bttv_gpio_read(sub->core);
+                bttv_gpio_write(sub->core, gpio & ~(1 << 4));
+                bttv_gpio_write(sub->core, gpio | (1 << 4));
+        } else {
+                /* init hardware-specific stuff */
+                bttv_gpio_inout(sub->core, ir->mask_keycode | ir->mask_keydown, 0);
+        }
 
         /* init input device */
         snprintf(ir->name, sizeof(ir->name), "bttv IR (card=%d)",
@@ -417,6 +673,7 @@ static int ir_probe(struct device *dev)
         snprintf(ir->phys, sizeof(ir->phys), "pci-%s/ir0",
                  pci_name(sub->core->pci));
 
+        ir->sub = sub;
         ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
         input_dev->name = ir->name;
         input_dev->phys = ir->phys;
@@ -437,11 +694,25 @@ static int ir_probe(struct device *dev)
                 ir->timer.function = ir_timer;
                 ir->timer.data     = (unsigned long)ir;
                 schedule_work(&ir->work);
+        } else if (ir->rc5_gpio) {
+                /* set timer_end for code completion */
+                init_timer(&ir->timer_end);
+                ir->timer_end.function = ir_rc5_timer_end;
+                ir->timer_end.data = (unsigned long)ir;
+
+                init_timer(&ir->timer_keyup);
+                ir->timer_keyup.function = ir_rc5_timer_keyup;
+                ir->timer_keyup.data = (unsigned long)ir;
         }
 
         /* all done */
         dev_set_drvdata(dev, ir);
         input_register_device(ir->input);
+        printk(DEVNAME ": %s detected at %s\n",ir->name,ir->phys);
+
+        /* the remote isn't as bouncy as a keyboard */
+        ir->input->rep[REP_DELAY] = repeat_delay;
+        ir->input->rep[REP_PERIOD] = repeat_period;
 
         return 0;
 }
@@ -454,6 +725,15 @@ static int ir_remove(struct device *dev)
                 del_timer(&ir->timer);
                 flush_scheduled_work();
         }
+        if (ir->rc5_gpio) {
+                u32 gpio;
+
+                del_timer(&ir->timer_end);
+                flush_scheduled_work();
+
+                gpio = bttv_gpio_read(ir->sub->core);
+                bttv_gpio_write(ir->sub->core, gpio & ~(1 << 4));
+        }
 
         input_unregister_device(ir->input);
         kfree(ir);
diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c
index 0085567a1421..801c736e9328 100644
--- a/drivers/media/video/ir-kbd-i2c.c
+++ b/drivers/media/video/ir-kbd-i2c.c
@@ -183,6 +183,58 @@ static int get_key_knc1(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
         return 1;
 }
 
+/* The new pinnacle PCTV remote (with the colored buttons)
+ *
+ * Ricardo Cerqueira <v4l@cerqueira.org>
+ */
+
+int get_key_pinnacle(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
+{
+        unsigned char b[4];
+        unsigned int start = 0,parity = 0,code = 0;
+
+        /* poll IR chip */
+        if (4 != i2c_master_recv(&ir->c,b,4)) {
+                dprintk(2,"read error\n");
+                return -EIO;
+        }
+
+        for (start = 0; start<4; start++) {
+                if (b[start] == 0x80) {
+                        code=b[(start+3)%4];
+                        parity=b[(start+2)%4];
+                }
+        }
+
+        /* Empty Request */
+        if (parity==0)
+                return 0;
+
+        /* Repeating... */
+        if (ir->old == parity)
+                return 0;
+
+
+        ir->old = parity;
+
+        /* Reduce code value to fit inside IR_KEYTAB_SIZE
+         *
+         * this is the only value that results in 42 unique
+         * codes < 128
+         */
+
+        code %= 0x88;
+
+        *ir_raw = code;
+        *ir_key = code;
+
+        dprintk(1,"Pinnacle PCTV key %02x\n", code);
+
+        return 1;
+}
+
+EXPORT_SYMBOL_GPL(get_key_pinnacle);
+
 /* ----------------------------------------------------------------------- */
 
 static void ir_key_poll(struct IR_i2c *ir)
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
new file mode 100644
index 000000000000..0235cef07b31
--- /dev/null
+++ b/drivers/media/video/saa7115.c
@@ -0,0 +1,1376 @@
+/* saa7115 - Philips SAA7114/SAA7115 video decoder driver
+ *
+ * Based on saa7114 driver by Maxim Yevtyushkin, which is based on
+ * the saa7111 driver by Dave Perks.
+ *
+ * Copyright (C) 1998 Dave Perks <dperks@ibm.net>
+ * Copyright (C) 2002 Maxim Yevtyushkin <max@linuxmedialabs.com>
+ *
+ * Slight changes for video timing and attachment output by
+ * Wolfgang Scherr <scherr@net4you.net>
+ *
+ * Moved over to the linux >= 2.4.x i2c protocol (1/1/2003)
+ * by Ronald Bultje <rbultje@ronald.bitfreak.net>
+ *
+ * Added saa7115 support by Kevin Thayer <nufan_wfk at yahoo.com>
+ * (2/17/2003)
+ *
+ * VBI support (2004) and cleanups (2005) by Hans Verkuil <hverkuil@xs4all.nl>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-common.h>
+
+MODULE_DESCRIPTION("Philips SAA7114/SAA7115 video decoder driver");
+MODULE_AUTHOR("Maxim Yevtyushkin, Kevin Thayer, Chris Kennedy, Hans Verkuil");
+MODULE_LICENSE("GPL");
+
+static int debug = 0;
+module_param(debug, int, 0644);
+
+MODULE_PARM_DESC(debug, "Debug level (0-1)");
+
+#define saa7115_dbg(fmt,arg...) \
+        do { \
+                if (debug) \
+                        printk(KERN_INFO "%s debug %d-%04x: " fmt, client->driver->name, \
+                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
+        } while (0)
+
+#define saa7115_err(fmt, arg...) do { \
+        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+#define saa7115_info(fmt, arg...) do { \
+        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
+static unsigned short normal_i2c[] = { 0x42 >> 1, 0x40 >> 1, I2C_CLIENT_END };
+
+
+I2C_CLIENT_INSMOD;
+
+struct saa7115_state {
+        v4l2_std_id std;
+        int input;
+        int enable;
+        int bright;
+        int contrast;
+        int hue;
+        int sat;
+        enum v4l2_chip_ident ident;
+        enum v4l2_audio_clock_freq audclk_freq;
+};
+
+/* ----------------------------------------------------------------------- */
+
+static inline int saa7115_write(struct i2c_client *client, u8 reg, u8 value)
+{
+        return i2c_smbus_write_byte_data(client, reg, value);
+}
+
+static int saa7115_writeregs(struct i2c_client *client, const unsigned char *regs)
+{
+        unsigned char reg, data;
+
+        while (*regs != 0x00) {
+                reg = *(regs++);
+                data = *(regs++);
+                if (saa7115_write(client, reg, data) < 0)
+                        return -1;
+        }
+        return 0;
+}
+
+static inline int saa7115_read(struct i2c_client *client, u8 reg)
+{
+        return i2c_smbus_read_byte_data(client, reg);
+}
+
+/* ----------------------------------------------------------------------- */
+
+/* If a value differs from the Hauppauge driver values, then the comment starts with
+   'was 0xXX' to denote the Hauppauge value. Otherwise the value is identical to what the
+   Hauppauge driver sets. */
+
+static const unsigned char saa7115_init_auto_input[] = {
+        0x01, 0x48,             /* white peak control disabled */
+        0x03, 0x20,             /* was 0x30. 0x20: long vertical blanking */
+        0x04, 0x90,             /* analog gain set to 0 */
+        0x05, 0x90,             /* analog gain set to 0 */
+        0x06, 0xeb,             /* horiz sync begin = -21 */
+        0x07, 0xe0,             /* horiz sync stop = -17 */
+        0x0a, 0x80,             /* was 0x88. decoder brightness, 0x80 is itu standard */
+        0x0b, 0x44,             /* was 0x48. decoder contrast, 0x44 is itu standard */
+        0x0c, 0x40,             /* was 0x47. decoder saturation, 0x40 is itu standard */
+        0x0d, 0x00,             /* chrominance hue control */
+        0x0f, 0x00,             /* chrominance gain control: use automicatic mode */
+        0x10, 0x06,             /* chrominance/luminance control: active adaptive combfilter */
+        0x11, 0x00,             /* delay control */
+        0x12, 0x9d,             /* RTS0 output control: VGATE */
+        0x13, 0x80,             /* X-port output control: ITU656 standard mode, RTCO output enable RTCE */
+        0x14, 0x00,             /* analog/ADC/auto compatibility control */
+        0x18, 0x40,             /* raw data gain 0x00 = nominal */
+        0x19, 0x80,             /* raw data offset 0x80 = 0 LSB */
+        0x1a, 0x77,             /* color killer level control 0x77 = recommended */
+        0x1b, 0x42,             /* misc chroma control 0x42 = recommended */
+        0x1c, 0xa9,             /* combfilter control 0xA9 = recommended */
+        0x1d, 0x01,             /* combfilter control 0x01 = recommended */
+        0x88, 0xd0,             /* reset device */
+        0x88, 0xf0,             /* set device programmed, all in operational mode */
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_cfg_reset_scaler[] = {
+        0x87, 0x00,             /* disable I-port output */
+        0x88, 0xd0,             /* reset scaler */
+        0x88, 0xf0,             /* activate scaler */
+        0x87, 0x01,             /* enable I-port output */
+        0x00, 0x00
+};
+
+/* ============== SAA7715 VIDEO templates =============  */
+
+static const unsigned char saa7115_cfg_60hz_fullres_x[] = {
+        0xcc, 0xd0,             /* hsize low (output), hor. output window size = 0x2d0 = 720 */
+        0xcd, 0x02,             /* hsize hi (output) */
+
+        /* Why not in 60hz-Land, too? */
+        0xd0, 0x01,             /* downscale = 1 */
+        0xd8, 0x00,             /* hor lum scaling 0x0400 = 1 */
+        0xd9, 0x04,
+        0xdc, 0x00,             /* hor chrom scaling 0x0200. must be hor lum scaling / 2 */
+        0xdd, 0x02,             /* H-scaling incr chroma */
+
+        0x00, 0x00
+};
+static const unsigned char saa7115_cfg_60hz_fullres_y[] = {
+        0xce, 0xf8,             /* vsize low (output), ver. output window size = 248 (but 60hz is 240?) */
+        0xcf, 0x00,             /* vsize hi (output) */
+
+        /* Why not in 60hz-Land, too? */
+        0xd5, 0x40,             /* Lum contrast, nominal value = 0x40 */
+        0xd6, 0x40,             /* Chroma satur. nominal value = 0x80 */
+
+        0xe0, 0x00,             /* V-scaling incr luma low */
+        0xe1, 0x04,             /* " hi */
+        0xe2, 0x00,             /* V-scaling incr chroma low */
+        0xe3, 0x04,             /* " hi */
+
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_cfg_60hz_video[] = {
+        0x80, 0x00,             /* reset tasks */
+        0x88, 0xd0,             /* reset scaler */
+
+        0x15, 0x03,             /* VGATE pulse start */
+        0x16, 0x11,             /* VGATE pulse stop */
+        0x17, 0x9c,             /* VGATE MSB and other values */
+
+        0x08, 0x68,             /* 0xBO: auto detection, 0x68 = NTSC */
+        0x0e, 0x07,             /* lots of different stuff... video autodetection is on */
+
+        0x5a, 0x06,             /* Vertical offset, standard 60hz value for ITU656 line counting */
+
+        /* Task A */
+        0x90, 0x80,             /* Task Handling Control */
+        0x91, 0x48,             /* X-port formats/config */
+        0x92, 0x40,             /* Input Ref. signal Def. */
+        0x93, 0x84,             /* I-port config */
+        0x94, 0x01,             /* hoffset low (input), 0x0002 is minimum */
+        0x95, 0x00,             /* hoffset hi (input) */
+        0x96, 0xd0,             /* hsize low (input), 0x02d0 = 720 */
+        0x97, 0x02,             /* hsize hi (input) */
+        0x98, 0x05,             /* voffset low (input) */
+        0x99, 0x00,             /* voffset hi (input) */
+        0x9a, 0x0c,             /* vsize low (input), 0x0c = 12 */
+        0x9b, 0x00,             /* vsize hi (input) */
+        0x9c, 0xa0,             /* hsize low (output), 0x05a0 = 1440 */
+        0x9d, 0x05,             /* hsize hi (output) */
+        0x9e, 0x0c,             /* vsize low (output), 0x0c = 12 */
+        0x9f, 0x00,             /* vsize hi (output) */
+
+        /* Task B */
+        0xc0, 0x00,             /* Task Handling Control */
+        0xc1, 0x08,             /* X-port formats/config */
+        0xc2, 0x00,             /* Input Ref. signal Def. */
+        0xc3, 0x80,             /* I-port config */
+        0xc4, 0x02,             /* hoffset low (input), 0x0002 is minimum */
+        0xc5, 0x00,             /* hoffset hi (input) */
+        0xc6, 0xd0,             /* hsize low (input), 0x02d0 = 720 */
+        0xc7, 0x02,             /* hsize hi (input) */
+        0xc8, 0x12,             /* voffset low (input), 0x12 = 18 */
+        0xc9, 0x00,             /* voffset hi (input) */
+        0xca, 0xf8,             /* vsize low (input), 0xf8 = 248 */
+        0xcb, 0x00,             /* vsize hi (input) */
+        0xcc, 0xd0,             /* hsize low (output), 0x02d0 = 720 */
+        0xcd, 0x02,             /* hsize hi (output) */
+
+        0xf0, 0xad,             /* Set PLL Register. 60hz 525 lines per frame, 27 MHz */
+        0xf1, 0x05,             /* low bit with 0xF0 */
+        0xf5, 0xad,             /* Set pulse generator register */
+        0xf6, 0x01,
+
+        0x87, 0x00,             /* Disable I-port output */
+        0x88, 0xd0,             /* reset scaler */
+        0x80, 0x20,             /* Activate only task "B", continuous mode (was 0xA0) */
+        0x88, 0xf0,             /* activate scaler */
+        0x87, 0x01,             /* Enable I-port output */
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_cfg_50hz_fullres_x[] = {
+        0xcc, 0xd0,             /* hsize low (output), 720 same as 60hz */
+        0xcd, 0x02,             /* hsize hi (output) */
+
+        0xd0, 0x01,             /* down scale = 1 */
+        0xd8, 0x00,             /* hor lum scaling 0x0400 = 1 */
+        0xd9, 0x04,
+        0xdc, 0x00,             /* hor chrom scaling 0x0200. must be hor lum scaling / 2 */
+        0xdd, 0x02,             /* H-scaling incr chroma */
+
+        0x00, 0x00
+};
+static const unsigned char saa7115_cfg_50hz_fullres_y[] = {
+        0xce, 0x20,             /* vsize low (output), 0x0120 = 288 */
+        0xcf, 0x01,             /* vsize hi (output) */
+
+        0xd5, 0x40,             /* Lum contrast, nominal value = 0x40 */
+        0xd6, 0x40,             /* Chroma satur. nominal value = 0x80 */
+
+        0xe0, 0x00,             /* V-scaling incr luma low */
+        0xe1, 0x04,             /* " hi */
+        0xe2, 0x00,             /* V-scaling incr chroma low */
+        0xe3, 0x04,             /* " hi */
+
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_cfg_50hz_video[] = {
+        0x80, 0x00,             /* reset tasks */
+        0x88, 0xd0,             /* reset scaler */
+
+        0x15, 0x37,             /* VGATE start */
+        0x16, 0x16,             /* VGATE stop */
+        0x17, 0x99,             /* VGATE MSB and other values */
+
+        0x08, 0x28,             /* 0x28 = PAL */
+        0x0e, 0x07,             /* chrominance control 1 */
+
+        0x5a, 0x03,             /* Vertical offset, standard 50hz value */
+
+        /* Task A */
+        0x90, 0x81,             /* Task Handling Control */
+        0x91, 0x48,             /* X-port formats/config */
+        0x92, 0x40,             /* Input Ref. signal Def. */
+        0x93, 0x84,             /* I-port config */
+        /* This is weird: the datasheet says that you should use 2 as the minimum value, */
+        /* but Hauppauge uses 0, and changing that to 2 causes indeed problems (for 50hz) */
+        0x94, 0x00,             /* hoffset low (input), 0x0002 is minimum */
+        0x95, 0x00,             /* hoffset hi (input) */
+        0x96, 0xd0,             /* hsize low (input), 0x02d0 = 720 */
+        0x97, 0x02,             /* hsize hi (input) */
+        0x98, 0x03,             /* voffset low (input) */
+        0x99, 0x00,             /* voffset hi (input) */
+        0x9a, 0x12,             /* vsize low (input), 0x12 = 18 */
+        0x9b, 0x00,             /* vsize hi (input) */
+        0x9c, 0xa0,             /* hsize low (output), 0x05a0 = 1440 */
+        0x9d, 0x05,             /* hsize hi (output) */
+        0x9e, 0x12,             /* vsize low (output), 0x12 = 18 */
+        0x9f, 0x00,             /* vsize hi (output) */
+
+        /* Task B */
+        0xc0, 0x00,             /* Task Handling Control */
+        0xc1, 0x08,             /* X-port formats/config */
+        0xc2, 0x00,             /* Input Ref. signal Def. */
+        0xc3, 0x80,             /* I-port config */
+        0xc4, 0x00,             /* hoffset low (input), 0x0002 is minimum. See comment at 0x94 above. */
+        0xc5, 0x00,             /* hoffset hi (input) */
+        0xc6, 0xd0,             /* hsize low (input), 0x02d0 = 720 */
+        0xc7, 0x02,             /* hsize hi (input) */
+        0xc8, 0x16,             /* voffset low (input), 0x16 = 22 */
+        0xc9, 0x00,             /* voffset hi (input) */
+        0xca, 0x20,             /* vsize low (input), 0x0120 = 288 */
+        0xcb, 0x01,             /* vsize hi (input) */
+        0xcc, 0xd0,             /* hsize low (output), 0x02d0 = 720 */
+        0xcd, 0x02,             /* hsize hi (output) */
+        0xce, 0x20,             /* vsize low (output), 0x0120 = 288 */
+        0xcf, 0x01,             /* vsize hi (output) */
+
+        0xf0, 0xb0,             /* Set PLL Register. 50hz 625 lines per frame, 27 MHz */
+        0xf1, 0x05,             /* low bit with 0xF0, (was 0x05) */
+        0xf5, 0xb0,             /* Set pulse generator register */
+        0xf6, 0x01,
+
+        0x87, 0x00,             /* Disable I-port output */
+        0x88, 0xd0,             /* reset scaler (was 0xD0) */
+        0x80, 0x20,             /* Activate only task "B" */
+        0x88, 0xf0,             /* activate scaler */
+        0x87, 0x01,             /* Enable I-port output */
+        0x00, 0x00
+};
+
+/* ============== SAA7715 VIDEO templates (end) =======  */
+
+static const unsigned char saa7115_cfg_vbi_on[] = {
+        0x80, 0x00,             /* reset tasks */
+        0x88, 0xd0,             /* reset scaler */
+        0x80, 0x30,             /* Activate both tasks */
+        0x88, 0xf0,             /* activate scaler */
+        0x87, 0x01,             /* Enable I-port output */
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_cfg_vbi_off[] = {
+        0x80, 0x00,             /* reset tasks */
+        0x88, 0xd0,             /* reset scaler */
+        0x80, 0x20,             /* Activate only task "B" */
+        0x88, 0xf0,             /* activate scaler */
+        0x87, 0x01,             /* Enable I-port output */
+        0x00, 0x00
+};
+
+static const unsigned char saa7115_init_misc[] = {
+        0x38, 0x03,             /* audio stuff */
+        0x39, 0x10,
+        0x3a, 0x08,
+
+        0x81, 0x01,             /* reg 0x15,0x16 define blanking window */
+        0x82, 0x00,
+        0x83, 0x01,             /* I port settings */
+        0x84, 0x20,
+        0x85, 0x21,
+        0x86, 0xc5,
+        0x87, 0x01,
+
+        /* Task A */
+        0xa0, 0x01,             /* down scale = 1 */
+        0xa1, 0x00,             /* prescale accumulation length = 1 */
+        0xa2, 0x00,             /* dc gain and fir prefilter control */
+        0xa4, 0x80,             /* Lum Brightness, nominal value = 0x80 */
+        0xa5, 0x40,             /* Lum contrast, nominal value = 0x40 */
+        0xa6, 0x40,             /* Chroma satur. nominal value = 0x80 */
+        0xa8, 0x00,             /* hor lum scaling 0x0200 = 2 zoom */
+        0xa9, 0x02,             /* note: 2 x zoom ensures that VBI lines have same length as video lines. */
+        0xaa, 0x00,             /* H-phase offset Luma = 0 */
+        0xac, 0x00,             /* hor chrom scaling 0x0200. must be hor lum scaling / 2 */
+        0xad, 0x01,             /* H-scaling incr chroma */
+        0xae, 0x00,             /* H-phase offset chroma. must be offset luma / 2 */
+
+        0xb0, 0x00,             /* V-scaling incr luma low */
+        0xb1, 0x04,             /* " hi */
+        0xb2, 0x00,             /* V-scaling incr chroma low */
+        0xb3, 0x04,             /* " hi */
+        0xb4, 0x01,             /* V-scaling mode control */
+        0xb8, 0x00,             /* V-phase offset chroma 00 */
+        0xb9, 0x00,             /* V-phase offset chroma 01 */
+        0xba, 0x00,             /* V-phase offset chroma 10 */
+        0xbb, 0x00,             /* V-phase offset chroma 11 */
+        0xbc, 0x00,             /* V-phase offset luma 00 */
+        0xbd, 0x00,             /* V-phase offset luma 01 */
+        0xbe, 0x00,             /* V-phase offset luma 10 */
+        0xbf, 0x00,             /* V-phase offset luma 11 */
+
+        /* Task B */
+        0xd0, 0x01,             /* down scale = 1 */
+        0xd1, 0x00,             /* prescale accumulation length = 1 */
+        0xd2, 0x00,             /* dc gain and fir prefilter control */
+        0xd4, 0x80,             /* Lum Brightness, nominal value = 0x80 */
+        0xd5, 0x40,             /* Lum contrast, nominal value = 0x40 */
+        0xd6, 0x40,             /* Chroma satur. nominal value = 0x80 */
+        0xd8, 0x00,             /* hor lum scaling 0x0400 = 1 */
+        0xd9, 0x04,
+        0xda, 0x00,             /* H-phase offset Luma = 0 */
+        0xdc, 0x00,             /* hor chrom scaling 0x0200. must be hor lum scaling / 2 */
+        0xdd, 0x02,             /* H-scaling incr chroma */
+        0xde, 0x00,             /* H-phase offset chroma. must be offset luma / 2 */
+
+        0xe0, 0x00,             /* V-scaling incr luma low */
+        0xe1, 0x04,             /* " hi */
+        0xe2, 0x00,             /* V-scaling incr chroma low */
+        0xe3, 0x04,             /* " hi */
+        0xe4, 0x01,             /* V-scaling mode control */
+        0xe8, 0x00,             /* V-phase offset chroma 00 */
+        0xe9, 0x00,             /* V-phase offset chroma 01 */
+        0xea, 0x00,             /* V-phase offset chroma 10 */
+        0xeb, 0x00,             /* V-phase offset chroma 11 */
+        0xec, 0x00,             /* V-phase offset luma 00 */
+        0xed, 0x00,             /* V-phase offset luma 01 */
+        0xee, 0x00,             /* V-phase offset luma 10 */
+        0xef, 0x00,             /* V-phase offset luma 11 */
+
+        0xf2, 0x50,             /* crystal clock = 24.576 MHz, target = 27MHz */
+        0xf3, 0x46,
+        0xf4, 0x00,
+        0xf7, 0x4b,             /* not the recommended settings! */
+        0xf8, 0x00,
+        0xf9, 0x4b,
+        0xfa, 0x00,
+        0xfb, 0x4b,
+        0xff, 0x88,             /* PLL2 lock detection settings: 71 lines 50% phase error */
+
+        /* Turn off VBI */
+        0x40, 0x20,             /* No framing code errors allowed. */
+        0x41, 0xff,
+        0x42, 0xff,
+        0x43, 0xff,
+        0x44, 0xff,
+        0x45, 0xff,
+        0x46, 0xff,
+        0x47, 0xff,
+        0x48, 0xff,
+        0x49, 0xff,
+        0x4a, 0xff,
+        0x4b, 0xff,
+        0x4c, 0xff,
+        0x4d, 0xff,
+        0x4e, 0xff,
+        0x4f, 0xff,
+        0x50, 0xff,
+        0x51, 0xff,
+        0x52, 0xff,
+        0x53, 0xff,
+        0x54, 0xff,
+        0x55, 0xff,
+        0x56, 0xff,
+        0x57, 0xff,
+        0x58, 0x40,
+        0x59, 0x47,
+        0x5b, 0x83,
+        0x5d, 0xbd,
+        0x5e, 0x35,
+
+        0x02, 0x84,             /* input tuner -> input 4, amplifier active */
+        0x09, 0x53,             /* 0x53, was 0x56 for 60hz. luminance control */
+
+        0x80, 0x20,             /* enable task B */
+        0x88, 0xd0,
+        0x88, 0xf0,
+        0x00, 0x00
+};
+
+/* ============== SAA7715 AUDIO settings ============= */
+
+/* 48.0 kHz */
+static const unsigned char saa7115_cfg_48_audio[] = {
+        0x34, 0xce,
+        0x35, 0xfb,
+        0x36, 0x30,
+        0x00, 0x00
+};
+
+/* 44.1 kHz */
+static const unsigned char saa7115_cfg_441_audio[] = {
+        0x34, 0xf2,
+        0x35, 0x00,
+        0x36, 0x2d,
+        0x00, 0x00
+};
+
+/* 32.0 kHz */
+static const unsigned char saa7115_cfg_32_audio[] = {
+        0x34, 0xdf,
+        0x35, 0xa7,
+        0x36, 0x20,
+        0x00, 0x00
+};
+
+/* 48.0 kHz 60hz */
+static const unsigned char saa7115_cfg_60hz_48_audio[] = {
+        0x30, 0xcd,
+        0x31, 0x20,
+        0x32, 0x03,
+        0x00, 0x00
+};
+
+/* 48.0 kHz 50hz */
+static const unsigned char saa7115_cfg_50hz_48_audio[] = {
+        0x30, 0x00,
+        0x31, 0xc0,
+        0x32, 0x03,
+        0x00, 0x00
+};
+
+/* 44.1 kHz 60hz */
+static const unsigned char saa7115_cfg_60hz_441_audio[] = {
+        0x30, 0xbc,
+        0x31, 0xdf,
+        0x32, 0x02,
+        0x00, 0x00
+};
+
+/* 44.1 kHz 50hz */
+static const unsigned char saa7115_cfg_50hz_441_audio[] = {
+        0x30, 0x00,
+        0x31, 0x72,
+        0x32, 0x03,
+        0x00, 0x00
+};
+
+/* 32.0 kHz 60hz */
+static const unsigned char saa7115_cfg_60hz_32_audio[] = {
+        0x30, 0xde,
+        0x31, 0x15,
+        0x32, 0x02,
+        0x00, 0x00
+};
+
+/* 32.0 kHz 50hz */
+static const unsigned char saa7115_cfg_50hz_32_audio[] = {
+        0x30, 0x00,
+        0x31, 0x80,
+        0x32, 0x02,
+        0x00, 0x00
+};
+
+static int saa7115_odd_parity(u8 c)
+{
+        c ^= (c >> 4);
+        c ^= (c >> 2);
+        c ^= (c >> 1);
+
+        return c & 1;
+}
+
+static int saa7115_decode_vps(u8 * dst, u8 * p)
+{
+        static const u8 biphase_tbl[] = {
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xd2, 0x5a, 0x52, 0xd2, 0x96, 0x1e, 0x16, 0x96,
+                0x92, 0x1a, 0x12, 0x92, 0xd2, 0x5a, 0x52, 0xd2,
+                0xd0, 0x58, 0x50, 0xd0, 0x94, 0x1c, 0x14, 0x94,
+                0x90, 0x18, 0x10, 0x90, 0xd0, 0x58, 0x50, 0xd0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xe1, 0x69, 0x61, 0xe1, 0xa5, 0x2d, 0x25, 0xa5,
+                0xa1, 0x29, 0x21, 0xa1, 0xe1, 0x69, 0x61, 0xe1,
+                0xc3, 0x4b, 0x43, 0xc3, 0x87, 0x0f, 0x07, 0x87,
+                0x83, 0x0b, 0x03, 0x83, 0xc3, 0x4b, 0x43, 0xc3,
+                0xc1, 0x49, 0x41, 0xc1, 0x85, 0x0d, 0x05, 0x85,
+                0x81, 0x09, 0x01, 0x81, 0xc1, 0x49, 0x41, 0xc1,
+                0xe1, 0x69, 0x61, 0xe1, 0xa5, 0x2d, 0x25, 0xa5,
+                0xa1, 0x29, 0x21, 0xa1, 0xe1, 0x69, 0x61, 0xe1,
+                0xe0, 0x68, 0x60, 0xe0, 0xa4, 0x2c, 0x24, 0xa4,
+                0xa0, 0x28, 0x20, 0xa0, 0xe0, 0x68, 0x60, 0xe0,
+                0xc2, 0x4a, 0x42, 0xc2, 0x86, 0x0e, 0x06, 0x86,
+                0x82, 0x0a, 0x02, 0x82, 0xc2, 0x4a, 0x42, 0xc2,
+                0xc0, 0x48, 0x40, 0xc0, 0x84, 0x0c, 0x04, 0x84,
+                0x80, 0x08, 0x00, 0x80, 0xc0, 0x48, 0x40, 0xc0,
+                0xe0, 0x68, 0x60, 0xe0, 0xa4, 0x2c, 0x24, 0xa4,
+                0xa0, 0x28, 0x20, 0xa0, 0xe0, 0x68, 0x60, 0xe0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+                0xd2, 0x5a, 0x52, 0xd2, 0x96, 0x1e, 0x16, 0x96,
+                0x92, 0x1a, 0x12, 0x92, 0xd2, 0x5a, 0x52, 0xd2,
+                0xd0, 0x58, 0x50, 0xd0, 0x94, 0x1c, 0x14, 0x94,
+                0x90, 0x18, 0x10, 0x90, 0xd0, 0x58, 0x50, 0xd0,
+                0xf0, 0x78, 0x70, 0xf0, 0xb4, 0x3c, 0x34, 0xb4,
+                0xb0, 0x38, 0x30, 0xb0, 0xf0, 0x78, 0x70, 0xf0,
+        };
+        int i;
+        u8 c, err = 0;
+
+        for (i = 0; i < 2 * 13; i += 2) {
+                err |= biphase_tbl[p[i]] | biphase_tbl[p[i + 1]];
+                c = (biphase_tbl[p[i + 1]] & 0xf) | ((biphase_tbl[p[i]] & 0xf) << 4);
+                dst[i / 2] = c;
+        }
+        return err & 0xf0;
+}
+
+static int saa7115_decode_wss(u8 * p)
+{
+        static const int wss_bits[8] = {
+                0, 0, 0, 1, 0, 1, 1, 1
+        };
+        unsigned char parity;
+        int wss = 0;
+        int i;
+
+        for (i = 0; i < 16; i++) {
+                int b1 = wss_bits[p[i] & 7];
+                int b2 = wss_bits[(p[i] >> 3) & 7];
+
+                if (b1 == b2)
+                        return -1;
+                wss |= b2 << i;
+        }
+        parity = wss & 15;
+        parity ^= parity >> 2;
+        parity ^= parity >> 1;
+
+        if (!(parity & 1))
+                return -1;
+
+        return wss;
+}
+
+
+static int saa7115_set_audio_clock_freq(struct i2c_client *client, enum v4l2_audio_clock_freq freq)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+
+        saa7115_dbg("set audio clock freq: %d\n", freq);
+        switch (freq) {
+                case V4L2_AUDCLK_32_KHZ:
+                        saa7115_writeregs(client, saa7115_cfg_32_audio);
+                        if (state->std & V4L2_STD_525_60) {
+                                saa7115_writeregs(client, saa7115_cfg_60hz_32_audio);
+                        } else {
+                                saa7115_writeregs(client, saa7115_cfg_50hz_32_audio);
+                        }
+                        break;
+                case V4L2_AUDCLK_441_KHZ:
+                        saa7115_writeregs(client, saa7115_cfg_441_audio);
+                        if (state->std & V4L2_STD_525_60) {
+                                saa7115_writeregs(client, saa7115_cfg_60hz_441_audio);
+                        } else {
+                                saa7115_writeregs(client, saa7115_cfg_50hz_441_audio);
+                        }
+                        break;
+                case V4L2_AUDCLK_48_KHZ:
+                        saa7115_writeregs(client, saa7115_cfg_48_audio);
+                        if (state->std & V4L2_STD_525_60) {
+                                saa7115_writeregs(client, saa7115_cfg_60hz_48_audio);
+                        } else {
+                                saa7115_writeregs(client, saa7115_cfg_50hz_48_audio);
+                        }
+                        break;
+                default:
+                        saa7115_dbg("invalid audio setting %d\n", freq);
+                        return -EINVAL;
+        }
+        state->audclk_freq = freq;
+        return 0;
+}
+
+static int saa7115_set_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case V4L2_CID_BRIGHTNESS:
+                if (ctrl->value < 0 || ctrl->value > 255) {
+                        saa7115_err("invalid brightness setting %d\n", ctrl->value);
+                        return -ERANGE;
+                }
+
+                state->bright = ctrl->value;
+                saa7115_write(client, 0x0a, state->bright);
+                break;
+
+        case V4L2_CID_CONTRAST:
+                if (ctrl->value < 0 || ctrl->value > 127) {
+                        saa7115_err("invalid contrast setting %d\n", ctrl->value);
+                        return -ERANGE;
+                }
+
+                state->contrast = ctrl->value;
+                saa7115_write(client, 0x0b, state->contrast);
+                break;
+
+        case V4L2_CID_SATURATION:
+                if (ctrl->value < 0 || ctrl->value > 127) {
+                        saa7115_err("invalid saturation setting %d\n", ctrl->value);
+                        return -ERANGE;
+                }
+
+                state->sat = ctrl->value;
+                saa7115_write(client, 0x0c, state->sat);
+                break;
+
+        case V4L2_CID_HUE:
+                if (ctrl->value < -127 || ctrl->value > 127) {
+                        saa7115_err("invalid hue setting %d\n", ctrl->value);
+                        return -ERANGE;
+                }
+
+                state->hue = ctrl->value;
+                saa7115_write(client, 0x0d, state->hue);
+                break;
+        }
+
+        return 0;
+}
+
+static int saa7115_get_v4lctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+
+        switch (ctrl->id) {
+        case V4L2_CID_BRIGHTNESS:
+                ctrl->value = state->bright;
+                break;
+        case V4L2_CID_CONTRAST:
+                ctrl->value = state->contrast;
+                break;
+        case V4L2_CID_SATURATION:
+                ctrl->value = state->sat;
+                break;
+        case V4L2_CID_HUE:
+                ctrl->value = state->hue;
+                break;
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+static void saa7115_set_v4lstd(struct i2c_client *client, v4l2_std_id std)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        int taskb = saa7115_read(client, 0x80) & 0x10;
+
+        // This works for NTSC-M, SECAM-L and the 50Hz PAL variants.
+        if (std & V4L2_STD_525_60) {
+                saa7115_dbg("decoder set standard 60 Hz\n");
+                saa7115_writeregs(client, saa7115_cfg_60hz_video);
+        } else {
+                saa7115_dbg("decoder set standard 50 Hz\n");
+                saa7115_writeregs(client, saa7115_cfg_50hz_video);
+        }
+
+        state->std = std;
+
+        /* restart task B if needed */
+        if (taskb && state->ident == V4L2_IDENT_SAA7114) {
+                saa7115_writeregs(client, saa7115_cfg_vbi_on);
+        }
+
+        /* switch audio mode too! */
+        saa7115_set_audio_clock_freq(client, state->audclk_freq);
+}
+
+static v4l2_std_id saa7115_get_v4lstd(struct i2c_client *client)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+
+        return state->std;
+}
+
+static void saa7115_log_status(struct i2c_client *client)
+{
+        static const char * const audclk_freq_strs[] = {
+                "44.1 kHz",
+                "48 kHz",
+                "32 kHz"
+        };
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        int reg1e, reg1f;
+        int signalOk;
+        int vcr;
+
+        saa7115_info("Audio frequency: %s\n", audclk_freq_strs[state->audclk_freq]);
+        if (client->name[6] == '4') {
+                /* status for the saa7114 */
+                reg1f = saa7115_read(client, 0x1f);
+                signalOk = (reg1f & 0xc1) == 0x81;
+                saa7115_info("Video signal:    %s\n", signalOk ? "ok" : "bad");
+                saa7115_info("Frequency:       %s\n", (reg1f & 0x20) ? "60Hz" : "50Hz");
+                return;
+        }
+
+        /* status for the saa7115 */
+        reg1e = saa7115_read(client, 0x1e);
+        reg1f = saa7115_read(client, 0x1f);
+
+        signalOk = (reg1f & 0xc1) == 0x81 && (reg1e & 0xc0) == 0x80;
+        vcr = !(reg1f & 0x10);
+
+        saa7115_info("Video signal:    %s\n", signalOk ? (vcr ? "VCR" : "broadcast/DVD") : "bad");
+        saa7115_info("Frequency:       %s\n", (reg1f & 0x20) ? "60Hz" : "50Hz");
+
+        switch (reg1e & 0x03) {
+                case 1:
+                        saa7115_info("Detected format: NTSC\n");
+                        break;
+                case 2:
+                        saa7115_info("Detected format: PAL\n");
+                        break;
+                case 3:
+                        saa7115_info("Detected format: SECAM\n");
+                        break;
+                default:
+                        saa7115_info("Detected format: BW/No color\n");
+                        break;
+        }
+}
+
+/* setup the sliced VBI lcr registers according to the sliced VBI format */
+static void saa7115_set_lcr(struct i2c_client *client, struct v4l2_sliced_vbi_format *fmt)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        int is_50hz = (state->std & V4L2_STD_625_50);
+        u8 lcr[24];
+        int i, x;
+
+        /* saa7114 doesn't yet support VBI */
+        if (state->ident == V4L2_IDENT_SAA7114)
+                return;
+
+        for (i = 0; i <= 23; i++)
+                lcr[i] = 0xff;
+
+        if (fmt->service_set == 0) {
+                /* raw VBI */
+                if (is_50hz)
+                        for (i = 6; i <= 23; i++)
+                                lcr[i] = 0xdd;
+                else
+                        for (i = 10; i <= 21; i++)
+                                lcr[i] = 0xdd;
+        } else {
+                /* sliced VBI */
+                /* first clear lines that cannot be captured */
+                if (is_50hz) {
+                        for (i = 0; i <= 5; i++)
+                                fmt->service_lines[0][i] =
+                                        fmt->service_lines[1][i] = 0;
+                }
+                else {
+                        for (i = 0; i <= 9; i++)
+                                fmt->service_lines[0][i] =
+                                        fmt->service_lines[1][i] = 0;
+                        for (i = 22; i <= 23; i++)
+                                fmt->service_lines[0][i] =
+                                        fmt->service_lines[1][i] = 0;
+                }
+
+                /* Now set the lcr values according to the specified service */
+                for (i = 6; i <= 23; i++) {
+                        lcr[i] = 0;
+                        for (x = 0; x <= 1; x++) {
+                                switch (fmt->service_lines[1-x][i]) {
+                                        case 0:
+                                                lcr[i] |= 0xf << (4 * x);
+                                                break;
+                                        case V4L2_SLICED_TELETEXT_B:
+                                                lcr[i] |= 1 << (4 * x);
+                                                break;
+                                        case V4L2_SLICED_CAPTION_525:
+                                                lcr[i] |= 4 << (4 * x);
+                                                break;
+                                        case V4L2_SLICED_WSS_625:
+                                                lcr[i] |= 5 << (4 * x);
+                                                break;
+                                        case V4L2_SLICED_VPS:
+                                                lcr[i] |= 7 << (4 * x);
+                                                break;
+                                }
+                        }
+                }
+        }
+
+        /* write the lcr registers */
+        for (i = 2; i <= 23; i++) {
+                saa7115_write(client, i - 2 + 0x41, lcr[i]);
+        }
+
+        /* enable/disable raw VBI capturing */
+        saa7115_writeregs(client, fmt->service_set == 0 ? saa7115_cfg_vbi_on : saa7115_cfg_vbi_off);
+}
+
+static int saa7115_get_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
+{
+        static u16 lcr2vbi[] = {
+                0, V4L2_SLICED_TELETEXT_B, 0,   /* 1 */
+                0, V4L2_SLICED_CAPTION_525,     /* 4 */
+                V4L2_SLICED_WSS_625, 0,         /* 5 */
+                V4L2_SLICED_VPS, 0, 0, 0, 0,    /* 7 */
+                0, 0, 0, 0
+        };
+        struct v4l2_sliced_vbi_format *sliced = &fmt->fmt.sliced;
+        int i;
+
+        if (fmt->type != V4L2_BUF_TYPE_SLICED_VBI_CAPTURE)
+                return -EINVAL;
+        memset(sliced, 0, sizeof(*sliced));
+        /* done if using raw VBI */
+        if (saa7115_read(client, 0x80) & 0x10)
+                return 0;
+        for (i = 2; i <= 23; i++) {
+                u8 v = saa7115_read(client, i - 2 + 0x41);
+
+                sliced->service_lines[0][i] = lcr2vbi[v >> 4];
+                sliced->service_lines[1][i] = lcr2vbi[v & 0xf];
+                sliced->service_set |=
+                        sliced->service_lines[0][i] | sliced->service_lines[1][i];
+        }
+        return 0;
+}
+
+static int saa7115_set_v4lfmt(struct i2c_client *client, struct v4l2_format *fmt)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        struct v4l2_pix_format *pix;
+        int HPSC, HFSC;
+        int VSCY, Vsrc;
+        int is_50hz = state->std & V4L2_STD_625_50;
+
+        if (fmt->type == V4L2_BUF_TYPE_SLICED_VBI_CAPTURE) {
+                saa7115_set_lcr(client, &fmt->fmt.sliced);
+                return 0;
+        }
+        if (fmt->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+                return -EINVAL;
+
+        pix = &(fmt->fmt.pix);
+
+        saa7115_dbg("decoder set size\n");
+
+        /* FIXME need better bounds checking here */
+        if ((pix->width < 1) || (pix->width > 1440))
+                return -EINVAL;
+        if ((pix->height < 1) || (pix->height > 960))
+                return -EINVAL;
+
+        /* probably have a valid size, let's set it */
+        /* Set output width/height */
+        /* width */
+        saa7115_write(client, 0xcc, (u8) (pix->width & 0xff));
+        saa7115_write(client, 0xcd, (u8) ((pix->width >> 8) & 0xff));
+        /* height */
+        saa7115_write(client, 0xce, (u8) (pix->height & 0xff));
+        saa7115_write(client, 0xcf, (u8) ((pix->height >> 8) & 0xff));
+
+        /* Scaling settings */
+        /* Hprescaler is floor(inres/outres) */
+        /* FIXME hardcoding input res */
+        if (pix->width != 720) {
+                HPSC = (int)(720 / pix->width);
+                /* 0 is not allowed (div. by zero) */
+                HPSC = HPSC ? HPSC : 1;
+                HFSC = (int)((1024 * 720) / (HPSC * pix->width));
+
+                saa7115_dbg("Hpsc: 0x%05x, Hfsc: 0x%05x\n", HPSC, HFSC);
+                /* FIXME hardcodes to "Task B"
+                 * write H prescaler integer */
+                saa7115_write(client, 0xd0, (u8) (HPSC & 0x3f));
+
+                /* write H fine-scaling (luminance) */
+                saa7115_write(client, 0xd8, (u8) (HFSC & 0xff));
+                saa7115_write(client, 0xd9, (u8) ((HFSC >> 8) & 0xff));
+                /* write H fine-scaling (chrominance)
+                 * must be lum/2, so i'll just bitshift :) */
+                saa7115_write(client, 0xDC, (u8) ((HFSC >> 1) & 0xff));
+                saa7115_write(client, 0xDD, (u8) ((HFSC >> 9) & 0xff));
+        } else {
+                if (is_50hz) {
+                        saa7115_dbg("Setting full 50hz width\n");
+                        saa7115_writeregs(client, saa7115_cfg_50hz_fullres_x);
+                } else {
+                        saa7115_dbg("Setting full 60hz width\n");
+                        saa7115_writeregs(client, saa7115_cfg_60hz_fullres_x);
+                }
+        }
+
+        Vsrc = is_50hz ? 576 : 480;
+
+        if (pix->height != Vsrc) {
+                VSCY = (int)((1024 * Vsrc) / pix->height);
+                saa7115_dbg("Vsrc: %d, Vscy: 0x%05x\n", Vsrc, VSCY);
+
+                /* Correct Contrast and Luminance */
+                saa7115_write(client, 0xd5, (u8) (64 * 1024 / VSCY));
+                saa7115_write(client, 0xd6, (u8) (64 * 1024 / VSCY));
+
+                /* write V fine-scaling (luminance) */
+                saa7115_write(client, 0xe0, (u8) (VSCY & 0xff));
+                saa7115_write(client, 0xe1, (u8) ((VSCY >> 8) & 0xff));
+                /* write V fine-scaling (chrominance) */
+                saa7115_write(client, 0xe2, (u8) (VSCY & 0xff));
+                saa7115_write(client, 0xe3, (u8) ((VSCY >> 8) & 0xff));
+        } else {
+                if (is_50hz) {
+                        saa7115_dbg("Setting full 50Hz height\n");
+                        saa7115_writeregs(client, saa7115_cfg_50hz_fullres_y);
+                } else {
+                        saa7115_dbg("Setting full 60hz height\n");
+                        saa7115_writeregs(client, saa7115_cfg_60hz_fullres_y);
+                }
+        }
+
+        saa7115_writeregs(client, saa7115_cfg_reset_scaler);
+        return 0;
+}
+
+/* Decode the sliced VBI data stream as created by the saa7115.
+   The format is described in the saa7115 datasheet in Tables 25 and 26
+   and in Figure 33.
+   The current implementation uses SAV/EAV codes and not the ancillary data
+   headers. The vbi->p pointer points to the SDID byte right after the SAV
+   code. */
+static void saa7115_decode_vbi_line(struct i2c_client *client,
+                                    struct v4l2_decode_vbi_line *vbi)
+{
+        static const char vbi_no_data_pattern[] = {
+                0xa0, 0xa0, 0xa0, 0xa0, 0xa0, 0xa0, 0xa0, 0xa0, 0xa0, 0xa0
+        };
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        u8 *p = vbi->p;
+        u32 wss;
+        int id1, id2;   /* the ID1 and ID2 bytes from the internal header */
+
+        vbi->type = 0;  /* mark result as a failure */
+        id1 = p[2];
+        id2 = p[3];
+        /* Note: the field bit is inverted for 60 Hz video */
+        if (state->std & V4L2_STD_525_60)
+                id1 ^= 0x40;
+
+        /* Skip internal header, p now points to the start of the payload */
+        p += 4;
+        vbi->p = p;
+
+        /* calculate field and line number of the VBI packet (1-23) */
+        vbi->is_second_field = ((id1 & 0x40) != 0);
+        vbi->line = (id1 & 0x3f) << 3;
+        vbi->line |= (id2 & 0x70) >> 4;
+
+        /* Obtain data type */
+        id2 &= 0xf;
+
+        /* If the VBI slicer does not detect any signal it will fill up
+           the payload buffer with 0xa0 bytes. */
+        if (!memcmp(p, vbi_no_data_pattern, sizeof(vbi_no_data_pattern)))
+                return;
+
+        /* decode payloads */
+        switch (id2) {
+        case 1:
+                vbi->type = V4L2_SLICED_TELETEXT_B;
+                break;
+        case 4:
+                if (!saa7115_odd_parity(p[0]) || !saa7115_odd_parity(p[1]))
+                        return;
+                vbi->type = V4L2_SLICED_CAPTION_525;
+                break;
+        case 5:
+                wss = saa7115_decode_wss(p);
+                if (wss == -1)
+                        return;
+                p[0] = wss & 0xff;
+                p[1] = wss >> 8;
+                vbi->type = V4L2_SLICED_WSS_625;
+                break;
+        case 7:
+                if (saa7115_decode_vps(p, p) != 0)
+                        return;
+                vbi->type = V4L2_SLICED_VPS;
+                break;
+        default:
+                return;
+        }
+}
+
+/* ============ SAA7115 AUDIO settings (end) ============= */
+
+static int saa7115_command(struct i2c_client *client, unsigned int cmd, void *arg)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        int *iarg = arg;
+
+        /* ioctls to allow direct access to the saa7115 registers for testing */
+        switch (cmd) {
+        case VIDIOC_S_FMT:
+                return saa7115_set_v4lfmt(client, (struct v4l2_format *)arg);
+
+        case VIDIOC_G_FMT:
+                return saa7115_get_v4lfmt(client, (struct v4l2_format *)arg);
+
+        case VIDIOC_INT_AUDIO_CLOCK_FREQ:
+                return saa7115_set_audio_clock_freq(client, *(enum v4l2_audio_clock_freq *)arg);
+
+        case VIDIOC_G_TUNER:
+        {
+                struct v4l2_tuner *vt = arg;
+                int status;
+
+                status = saa7115_read(client, 0x1f);
+
+                saa7115_dbg("status: 0x%02x\n", status);
+                vt->signal = ((status & (1 << 6)) == 0) ? 0xffff : 0x0;
+                break;
+        }
+
+        case VIDIOC_LOG_STATUS:
+                saa7115_log_status(client);
+                break;
+
+        case VIDIOC_G_CTRL:
+                return saa7115_get_v4lctrl(client, (struct v4l2_control *)arg);
+
+        case VIDIOC_S_CTRL:
+                return saa7115_set_v4lctrl(client, (struct v4l2_control *)arg);
+
+        case VIDIOC_G_STD:
+                *(v4l2_std_id *)arg = saa7115_get_v4lstd(client);
+                break;
+
+        case VIDIOC_S_STD:
+                saa7115_set_v4lstd(client, *(v4l2_std_id *)arg);
+                break;
+
+        case VIDIOC_G_INPUT:
+                *(int *)arg = state->input;
+                break;
+
+        case VIDIOC_S_INPUT:
+                saa7115_dbg("decoder set input %d\n", *iarg);
+                /* inputs from 0-9 are available */
+                if (*iarg < 0 || *iarg > 9) {
+                        return -EINVAL;
+                }
+
+                if (state->input == *iarg)
+                        break;
+                saa7115_dbg("now setting %s input\n",
+                        *iarg >= 6 ? "S-Video" : "Composite");
+                state->input = *iarg;
+
+                /* select mode */
+                saa7115_write(client, 0x02,
+                              (saa7115_read(client, 0x02) & 0xf0) |
+                               state->input);
+
+                /* bypass chrominance trap for modes 6..9 */
+                saa7115_write(client, 0x09,
+                              (saa7115_read(client, 0x09) & 0x7f) |
+                               (state->input < 6 ? 0x0 : 0x80));
+                break;
+
+        case VIDIOC_STREAMON:
+        case VIDIOC_STREAMOFF:
+                saa7115_dbg("%s output\n",
+                        (cmd == VIDIOC_STREAMON) ? "enable" : "disable");
+
+                if (state->enable != (cmd == VIDIOC_STREAMON)) {
+                        state->enable = (cmd == VIDIOC_STREAMON);
+                        saa7115_write(client, 0x87, state->enable);
+                }
+                break;
+
+        case VIDIOC_INT_DECODE_VBI_LINE:
+                saa7115_decode_vbi_line(client, arg);
+                break;
+
+        case VIDIOC_INT_RESET:
+                saa7115_dbg("decoder RESET\n");
+                saa7115_writeregs(client, saa7115_cfg_reset_scaler);
+                break;
+
+        case VIDIOC_INT_G_VBI_DATA:
+        {
+                struct v4l2_sliced_vbi_data *data = arg;
+
+                switch (data->id) {
+                case V4L2_SLICED_WSS_625:
+                        if (saa7115_read(client, 0x6b) & 0xc0)
+                                return -EIO;
+                        data->data[0] = saa7115_read(client, 0x6c);
+                        data->data[1] = saa7115_read(client, 0x6d);
+                        return 0;
+                case V4L2_SLICED_CAPTION_525:
+                        if (data->field == 0) {
+                                /* CC */
+                                if (saa7115_read(client, 0x66) & 0xc0)
+                                        return -EIO;
+                                data->data[0] = saa7115_read(client, 0x67);
+                                data->data[1] = saa7115_read(client, 0x68);
+                                return 0;
+                        }
+                        /* XDS */
+                        if (saa7115_read(client, 0x66) & 0x30)
+                                return -EIO;
+                        data->data[0] = saa7115_read(client, 0x69);
+                        data->data[1] = saa7115_read(client, 0x6a);
+                        return 0;
+                default:
+                        return -EINVAL;
+                }
+                break;
+        }
+
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+        case VIDIOC_INT_G_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_SAA711X)
+                        return -EINVAL;
+                reg->val = saa7115_read(client, reg->reg & 0xff);
+                break;
+        }
+
+        case VIDIOC_INT_S_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_SAA711X)
+                        return -EINVAL;
+                if (!capable(CAP_SYS_ADMIN))
+                        return -EPERM;
+                saa7115_write(client, reg->reg & 0xff, reg->val & 0xff);
+                break;
+        }
+#endif
+
+        case VIDIOC_INT_G_CHIP_IDENT:
+                *iarg = state->ident;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static struct i2c_driver i2c_driver_saa7115;
+
+static int saa7115_attach(struct i2c_adapter *adapter, int address, int kind)
+{
+        struct i2c_client *client;
+        struct saa7115_state *state;
+        u8 chip_id;
+
+        /* Check if the adapter supports the needed features */
+        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
+                return 0;
+
+        client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+        if (client == 0)
+                return -ENOMEM;
+        memset(client, 0, sizeof(struct i2c_client));
+        client->addr = address;
+        client->adapter = adapter;
+        client->driver = &i2c_driver_saa7115;
+        client->flags = I2C_CLIENT_ALLOW_USE;
+        snprintf(client->name, sizeof(client->name) - 1, "saa7115");
+
+        saa7115_dbg("detecting saa7115 client on address 0x%x\n", address << 1);
+
+        saa7115_write(client, 0, 5);
+        chip_id = saa7115_read(client, 0) & 0x0f;
+        if (chip_id != 4 && chip_id != 5) {
+                saa7115_dbg("saa7115 not found\n");
+                kfree(client);
+                return 0;
+        }
+        if (chip_id == 4) {
+                snprintf(client->name, sizeof(client->name) - 1, "saa7114");
+        }
+        saa7115_info("saa711%d found @ 0x%x (%s)\n", chip_id, address << 1, adapter->name);
+
+        state = kmalloc(sizeof(struct saa7115_state), GFP_KERNEL);
+        i2c_set_clientdata(client, state);
+        if (state == NULL) {
+                kfree(client);
+                return -ENOMEM;
+        }
+        memset(state, 0, sizeof(struct saa7115_state));
+        state->std = V4L2_STD_NTSC;
+        state->input = -1;
+        state->enable = 1;
+        state->bright = 128;
+        state->contrast = 64;
+        state->hue = 0;
+        state->sat = 64;
+        state->ident = (chip_id == 4) ? V4L2_IDENT_SAA7114 : V4L2_IDENT_SAA7115;
+        state->audclk_freq = V4L2_AUDCLK_48_KHZ;
+
+        saa7115_dbg("writing init values\n");
+
+        /* init to 60hz/48khz */
+        saa7115_writeregs(client, saa7115_init_auto_input);
+        saa7115_writeregs(client, saa7115_init_misc);
+        saa7115_writeregs(client, saa7115_cfg_60hz_fullres_x);
+        saa7115_writeregs(client, saa7115_cfg_60hz_fullres_y);
+        saa7115_writeregs(client, saa7115_cfg_60hz_video);
+        saa7115_writeregs(client, saa7115_cfg_48_audio);
+        saa7115_writeregs(client, saa7115_cfg_60hz_48_audio);
+        saa7115_writeregs(client, saa7115_cfg_reset_scaler);
+
+        i2c_attach_client(client);
+
+        saa7115_dbg("status: (1E) 0x%02x, (1F) 0x%02x\n",
+                saa7115_read(client, 0x1e), saa7115_read(client, 0x1f));
+
+        return 0;
+}
+
+static int saa7115_probe(struct i2c_adapter *adapter)
+{
+#ifdef I2C_CLASS_TV_ANALOG
+        if (adapter->class & I2C_CLASS_TV_ANALOG)
+#else
+        if (adapter->id == I2C_HW_B_BT848)
+#endif
+                return i2c_probe(adapter, &addr_data, &saa7115_attach);
+        return 0;
+}
+
+static int saa7115_detach(struct i2c_client *client)
+{
+        struct saa7115_state *state = i2c_get_clientdata(client);
+        int err;
+
+        err = i2c_detach_client(client);
+        if (err) {
+                return err;
+        }
+
+        kfree(state);
+        kfree(client);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+/* i2c implementation */
+static struct i2c_driver i2c_driver_saa7115 = {
+        .name = "saa7115",
+        .id = I2C_DRIVERID_SAA711X,
+        .flags = I2C_DF_NOTIFY,
+        .attach_adapter = saa7115_probe,
+        .detach_client = saa7115_detach,
+        .command = saa7115_command,
+        .owner = THIS_MODULE,
+};
+
+
+static int __init saa7115_init_module(void)
+{
+        return i2c_add_driver(&i2c_driver_saa7115);
+}
+
+static void __exit saa7115_cleanup_module(void)
+{
+        i2c_del_driver(&i2c_driver_saa7115);
+}
+
+module_init(saa7115_init_module);
+module_exit(saa7115_cleanup_module);
diff --git a/drivers/media/video/saa711x.c b/drivers/media/video/saa711x.c
index 9aa8827de2c3..25b30f352d84 100644
--- a/drivers/media/video/saa711x.c
+++ b/drivers/media/video/saa711x.c
@@ -36,7 +36,6 @@
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <linux/sched.h>
-#include <asm/segment.h>
 #include <linux/types.h>
 #include <asm/uaccess.h>
 #include <linux/videodev.h>
diff --git a/drivers/media/video/saa7127.c b/drivers/media/video/saa7127.c
new file mode 100644
index 000000000000..843431f10e3b
--- /dev/null
+++ b/drivers/media/video/saa7127.c
@@ -0,0 +1,849 @@
+/*
+ * saa7127 - Philips SAA7127/SAA7129 video encoder driver
+ *
+ * Copyright (C) 2003 Roy Bulter <rbulter@hetnet.nl>
+ *
+ * Based on SAA7126 video encoder driver by Gillem & Andreas Oberritter
+ *
+ * Copyright (C) 2000-2001 Gillem <htoa@gmx.net>
+ * Copyright (C) 2002 Andreas Oberritter <obi@saftware.de>
+ *
+ * Based on Stadis 4:2:2 MPEG-2 Decoder Driver by Nathan Laredo
+ *
+ * Copyright (C) 1999 Nathan Laredo <laredo@gnu.org>
+ *
+ * This driver is designed for the Hauppauge 250/350 Linux driver
+ * from the ivtv Project
+ *
+ * Copyright (C) 2003 Kevin Thayer <nufan_wfk@yahoo.com>
+ *
+ * Dual output support:
+ * Copyright (C) 2004 Eric Varsanyi
+ *
+ * NTSC Tuning and 7.5 IRE Setup
+ * Copyright (C) 2004  Chris Kennedy <c@groovy.org>
+ *
+ * VBI additions & cleanup:
+ * Copyright (C) 2004, 2005 Hans Verkuil <hverkuil@xs4all.nl>
+ *
+ * Note: the saa7126 is identical to the saa7127, and the saa7128 is
+ * identical to the saa7129, except that the saa7126 and saa7128 have
+ * macrovision anti-taping support. This driver will almost certainly
+ * work find for those chips, except of course for the missing anti-taping
+ * support.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-common.h>
+
+static int debug = 0;
+static int test_image = 0;
+
+MODULE_DESCRIPTION("Philips SAA7127/9 video encoder driver");
+MODULE_AUTHOR("Kevin Thayer, Chris Kennedy, Hans Verkuil");
+MODULE_LICENSE("GPL");
+module_param(debug, int, 0644);
+module_param(test_image, int, 0644);
+MODULE_PARM_DESC(debug, "debug level (0-2)");
+MODULE_PARM_DESC(test_image, "test_image (0-1)");
+
+#define saa7127_dbg(fmt, arg...) \
+        do { \
+                if (debug >= 1) \
+                        printk(KERN_INFO "%s debug %d-%04x: " fmt, client->driver->name, \
+                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
+        } while (0)
+
+/* High volume debug. Use with care. */
+#define saa7127_dbg_highvol(fmt, arg...) \
+        do { \
+                if (debug == 2) \
+                        printk(KERN_INFO "%s debug %d-%04x: " fmt, client->driver->name, \
+                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
+        } while (0)
+
+#define saa7127_err(fmt, arg...) do { \
+        printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+#define saa7127_info(fmt, arg...) do { \
+        printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
+static unsigned short normal_i2c[] = { 0x88 >> 1, I2C_CLIENT_END };
+
+
+I2C_CLIENT_INSMOD;
+
+/*
+ * SAA7127 registers
+ */
+
+#define SAA7127_REG_STATUS                           0x00
+#define SAA7127_REG_WIDESCREEN_CONFIG                0x26
+#define SAA7127_REG_WIDESCREEN_ENABLE                0x27
+#define SAA7127_REG_BURST_START                      0x28
+#define SAA7127_REG_BURST_END                        0x29
+#define SAA7127_REG_COPYGEN_0                        0x2a
+#define SAA7127_REG_COPYGEN_1                        0x2b
+#define SAA7127_REG_COPYGEN_2                        0x2c
+#define SAA7127_REG_OUTPUT_PORT_CONTROL              0x2d
+#define SAA7127_REG_GAIN_LUMINANCE_RGB               0x38
+#define SAA7127_REG_GAIN_COLORDIFF_RGB               0x39
+#define SAA7127_REG_INPUT_PORT_CONTROL_1             0x3a
+#define SAA7129_REG_FADE_KEY_COL2                    0x4f
+#define SAA7127_REG_CHROMA_PHASE                     0x5a
+#define SAA7127_REG_GAINU                            0x5b
+#define SAA7127_REG_GAINV                            0x5c
+#define SAA7127_REG_BLACK_LEVEL                      0x5d
+#define SAA7127_REG_BLANKING_LEVEL                   0x5e
+#define SAA7127_REG_VBI_BLANKING                     0x5f
+#define SAA7127_REG_DAC_CONTROL                      0x61
+#define SAA7127_REG_BURST_AMP                        0x62
+#define SAA7127_REG_SUBC3                            0x63
+#define SAA7127_REG_SUBC2                            0x64
+#define SAA7127_REG_SUBC1                            0x65
+#define SAA7127_REG_SUBC0                            0x66
+#define SAA7127_REG_LINE_21_ODD_0                    0x67
+#define SAA7127_REG_LINE_21_ODD_1                    0x68
+#define SAA7127_REG_LINE_21_EVEN_0                   0x69
+#define SAA7127_REG_LINE_21_EVEN_1                   0x6a
+#define SAA7127_REG_RCV_PORT_CONTROL                 0x6b
+#define SAA7127_REG_VTRIG                            0x6c
+#define SAA7127_REG_HTRIG_HI                         0x6d
+#define SAA7127_REG_MULTI                            0x6e
+#define SAA7127_REG_CLOSED_CAPTION                   0x6f
+#define SAA7127_REG_RCV2_OUTPUT_START                0x70
+#define SAA7127_REG_RCV2_OUTPUT_END                  0x71
+#define SAA7127_REG_RCV2_OUTPUT_MSBS                 0x72
+#define SAA7127_REG_TTX_REQUEST_H_START              0x73
+#define SAA7127_REG_TTX_REQUEST_H_DELAY_LENGTH       0x74
+#define SAA7127_REG_CSYNC_ADVANCE_VSYNC_SHIFT        0x75
+#define SAA7127_REG_TTX_ODD_REQ_VERT_START           0x76
+#define SAA7127_REG_TTX_ODD_REQ_VERT_END             0x77
+#define SAA7127_REG_TTX_EVEN_REQ_VERT_START          0x78
+#define SAA7127_REG_TTX_EVEN_REQ_VERT_END            0x79
+#define SAA7127_REG_FIRST_ACTIVE                     0x7a
+#define SAA7127_REG_LAST_ACTIVE                      0x7b
+#define SAA7127_REG_MSB_VERTICAL                     0x7c
+#define SAA7127_REG_DISABLE_TTX_LINE_LO_0            0x7e
+#define SAA7127_REG_DISABLE_TTX_LINE_LO_1            0x7f
+
+/*
+ **********************************************************************
+ *
+ *  Arrays with configuration parameters for the SAA7127
+ *
+ **********************************************************************
+ */
+
+struct i2c_reg_value {
+        unsigned char reg;
+        unsigned char value;
+};
+
+static const struct i2c_reg_value saa7129_init_config_extra[] = {
+        { SAA7127_REG_OUTPUT_PORT_CONTROL,              0x38 },
+        { SAA7127_REG_VTRIG,                            0xfa },
+};
+
+static const struct i2c_reg_value saa7127_init_config_common[] = {
+        { SAA7127_REG_WIDESCREEN_CONFIG,                0x0d },
+        { SAA7127_REG_WIDESCREEN_ENABLE,                0x00 },
+        { SAA7127_REG_COPYGEN_0,                        0x77 },
+        { SAA7127_REG_COPYGEN_1,                        0x41 },
+        { SAA7127_REG_COPYGEN_2,                        0x00 }, /* Macrovision enable/disable */
+        { SAA7127_REG_OUTPUT_PORT_CONTROL,              0x9e },
+        { SAA7127_REG_GAIN_LUMINANCE_RGB,               0x00 },
+        { SAA7127_REG_GAIN_COLORDIFF_RGB,               0x00 },
+        { SAA7127_REG_INPUT_PORT_CONTROL_1,             0x80 }, /* for color bars */
+        { SAA7127_REG_LINE_21_ODD_0,                    0x77 },
+        { SAA7127_REG_LINE_21_ODD_1,                    0x41 },
+        { SAA7127_REG_LINE_21_EVEN_0,                   0x88 },
+        { SAA7127_REG_LINE_21_EVEN_1,                   0x41 },
+        { SAA7127_REG_RCV_PORT_CONTROL,                 0x12 },
+        { SAA7127_REG_VTRIG,                            0xf9 },
+        { SAA7127_REG_HTRIG_HI,                         0x00 },
+        { SAA7127_REG_RCV2_OUTPUT_START,                0x41 },
+        { SAA7127_REG_RCV2_OUTPUT_END,                  0xc3 },
+        { SAA7127_REG_RCV2_OUTPUT_MSBS,                 0x00 },
+        { SAA7127_REG_TTX_REQUEST_H_START,              0x3e },
+        { SAA7127_REG_TTX_REQUEST_H_DELAY_LENGTH,       0xb8 },
+        { SAA7127_REG_CSYNC_ADVANCE_VSYNC_SHIFT,        0x03 },
+        { SAA7127_REG_TTX_ODD_REQ_VERT_START,           0x15 },
+        { SAA7127_REG_TTX_ODD_REQ_VERT_END,             0x16 },
+        { SAA7127_REG_TTX_EVEN_REQ_VERT_START,          0x15 },
+        { SAA7127_REG_TTX_EVEN_REQ_VERT_END,            0x16 },
+        { SAA7127_REG_FIRST_ACTIVE,                     0x1a },
+        { SAA7127_REG_LAST_ACTIVE,                      0x01 },
+        { SAA7127_REG_MSB_VERTICAL,                     0xc0 },
+        { SAA7127_REG_DISABLE_TTX_LINE_LO_0,            0x00 },
+        { SAA7127_REG_DISABLE_TTX_LINE_LO_1,            0x00 },
+        { 0, 0 }
+};
+
+#define SAA7127_60HZ_DAC_CONTROL 0x15
+static const struct i2c_reg_value saa7127_init_config_60hz[] = {
+        { SAA7127_REG_BURST_START,                      0x19 },
+        /* BURST_END is also used as a chip ID in saa7127_detect_client */
+        { SAA7127_REG_BURST_END,                        0x1d },
+        { SAA7127_REG_CHROMA_PHASE,                     0xa3 },
+        { SAA7127_REG_GAINU,                            0x98 },
+        { SAA7127_REG_GAINV,                            0xd3 },
+        { SAA7127_REG_BLACK_LEVEL,                      0x39 },
+        { SAA7127_REG_BLANKING_LEVEL,                   0x2e },
+        { SAA7127_REG_VBI_BLANKING,                     0x2e },
+        { SAA7127_REG_DAC_CONTROL,                      0x15 },
+        { SAA7127_REG_BURST_AMP,                        0x4d },
+        { SAA7127_REG_SUBC3,                            0x1f },
+        { SAA7127_REG_SUBC2,                            0x7c },
+        { SAA7127_REG_SUBC1,                            0xf0 },
+        { SAA7127_REG_SUBC0,                            0x21 },
+        { SAA7127_REG_MULTI,                            0x90 },
+        { SAA7127_REG_CLOSED_CAPTION,                   0x11 },
+        { 0, 0 }
+};
+
+#define SAA7127_50HZ_DAC_CONTROL 0x02
+struct i2c_reg_value saa7127_init_config_50hz[] = {
+        { SAA7127_REG_BURST_START,                      0x21 },
+        /* BURST_END is also used as a chip ID in saa7127_detect_client */
+        { SAA7127_REG_BURST_END,                        0x1d },
+        { SAA7127_REG_CHROMA_PHASE,                     0x3f },
+        { SAA7127_REG_GAINU,                            0x7d },
+        { SAA7127_REG_GAINV,                            0xaf },
+        { SAA7127_REG_BLACK_LEVEL,                      0x33 },
+        { SAA7127_REG_BLANKING_LEVEL,                   0x35 },
+        { SAA7127_REG_VBI_BLANKING,                     0x35 },
+        { SAA7127_REG_DAC_CONTROL,                      0x02 },
+        { SAA7127_REG_BURST_AMP,                        0x2f },
+        { SAA7127_REG_SUBC3,                            0xcb },
+        { SAA7127_REG_SUBC2,                            0x8a },
+        { SAA7127_REG_SUBC1,                            0x09 },
+        { SAA7127_REG_SUBC0,                            0x2a },
+        { SAA7127_REG_MULTI,                            0xa0 },
+        { SAA7127_REG_CLOSED_CAPTION,                   0x00 },
+        { 0, 0 }
+};
+
+/* Enumeration for the Supported input types */
+enum saa7127_input_type {
+        SAA7127_INPUT_TYPE_NORMAL,
+        SAA7127_INPUT_TYPE_TEST_IMAGE
+};
+
+/* Enumeration for the Supported Output signal types */
+enum saa7127_output_type {
+        SAA7127_OUTPUT_TYPE_BOTH,
+        SAA7127_OUTPUT_TYPE_COMPOSITE,
+        SAA7127_OUTPUT_TYPE_SVIDEO,
+        SAA7127_OUTPUT_TYPE_RGB,
+        SAA7127_OUTPUT_TYPE_YUV_C,
+        SAA7127_OUTPUT_TYPE_YUV_V
+};
+
+/*
+ **********************************************************************
+ *
+ *  Encoder Struct, holds the configuration state of the encoder
+ *
+ **********************************************************************
+ */
+
+struct saa7127_state {
+        v4l2_std_id std;
+        enum v4l2_chip_ident ident;
+        enum saa7127_input_type input_type;
+        enum saa7127_output_type output_type;
+        int video_enable;
+        int wss_enable;
+        u16 wss_mode;
+        int cc_enable;
+        u16 cc_data;
+        int xds_enable;
+        u16 xds_data;
+        int vps_enable;
+        u8 vps_data[5];
+        u8 reg_2d;
+        u8 reg_3a;
+        u8 reg_3a_cb;   /* colorbar bit */
+        u8 reg_61;
+};
+
+static const char * const output_strs[] =
+{
+        "S-Video + Composite",
+        "Composite",
+        "S-Video",
+        "RGB",
+        "YUV C",
+        "YUV V"
+};
+
+static const char * const wss_strs[] = {
+        "invalid",
+        "letterbox 14:9 center",
+        "letterbox 14:9 top",
+        "invalid",
+        "letterbox 16:9 top",
+        "invalid",
+        "invalid",
+        "16:9 full format anamorphic"
+        "4:3 full format",
+        "invalid",
+        "invalid",
+        "letterbox 16:9 center",
+        "invalid",
+        "letterbox >16:9 center",
+        "14:9 full format center",
+        "invalid",
+};
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_read(struct i2c_client *client, u8 reg)
+{
+        return i2c_smbus_read_byte_data(client, reg);
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_write(struct i2c_client *client, u8 reg, u8 val)
+{
+        int i;
+
+        for (i = 0; i < 3; i++) {
+                if (i2c_smbus_write_byte_data(client, reg, val) == 0)
+                        return 0;
+        }
+        saa7127_err("I2C Write Problem\n");
+        return -1;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_write_inittab(struct i2c_client *client,
+                                 const struct i2c_reg_value *regs)
+{
+        while (regs->reg != 0) {
+                saa7127_write(client, regs->reg, regs->value);
+                regs++;
+        }
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_vps(struct i2c_client *client, struct v4l2_sliced_vbi_data *data)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        int enable = (data->line != 0);
+
+        if (enable && (data->field != 0 || data->line != 16))
+                return -EINVAL;
+        if (state->vps_enable != enable) {
+                saa7127_dbg("Turn VPS Signal %s\n", enable ? "on" : "off");
+                saa7127_write(client, 0x54, enable << 7);
+                state->vps_enable = enable;
+        }
+        if (!enable)
+                return 0;
+
+        state->vps_data[0] = data->data[4];
+        state->vps_data[1] = data->data[10];
+        state->vps_data[2] = data->data[11];
+        state->vps_data[3] = data->data[12];
+        state->vps_data[4] = data->data[13];
+        saa7127_dbg("Set VPS data %02x %02x %02x %02x %02x\n",
+                state->vps_data[0], state->vps_data[1],
+                state->vps_data[2], state->vps_data[3],
+                state->vps_data[4]);
+        saa7127_write(client, 0x55, state->vps_data[0]);
+        saa7127_write(client, 0x56, state->vps_data[1]);
+        saa7127_write(client, 0x57, state->vps_data[2]);
+        saa7127_write(client, 0x58, state->vps_data[3]);
+        saa7127_write(client, 0x59, state->vps_data[4]);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_cc(struct i2c_client *client, struct v4l2_sliced_vbi_data *data)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        u16 cc = data->data[0] << 8 | data->data[1];
+        int enable = (data->line != 0);
+
+        if (enable && (data->field != 0 || data->line != 21))
+                return -EINVAL;
+        if (state->cc_enable != enable) {
+                saa7127_dbg("Turn CC %s\n", enable ? "on" : "off");
+                saa7127_write(client, SAA7127_REG_CLOSED_CAPTION,
+                                (enable << 6) | 0x11);
+                state->cc_enable = enable;
+        }
+        if (!enable)
+                return 0;
+
+        saa7127_dbg_highvol("CC data: %04x\n", cc);
+        saa7127_write(client, SAA7127_REG_LINE_21_ODD_0, cc & 0xff);
+        saa7127_write(client, SAA7127_REG_LINE_21_ODD_1, cc >> 8);
+        state->cc_data = cc;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_xds(struct i2c_client *client, struct v4l2_sliced_vbi_data *data)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        u16 xds = data->data[1] << 8 | data->data[0];
+        int enable = (data->line != 0);
+
+        if (enable && (data->field != 1 || data->line != 21))
+                return -EINVAL;
+        if (state->xds_enable != enable) {
+                saa7127_dbg("Turn XDS %s\n", enable ? "on" : "off");
+                saa7127_write(client, SAA7127_REG_CLOSED_CAPTION,
+                                (enable << 7) | 0x11);
+                state->xds_enable = enable;
+        }
+        if (!enable)
+                return 0;
+
+        saa7127_dbg_highvol("XDS data: %04x\n", xds);
+        saa7127_write(client, SAA7127_REG_LINE_21_EVEN_0, xds & 0xff);
+        saa7127_write(client, SAA7127_REG_LINE_21_EVEN_1, xds >> 8);
+        state->xds_data = xds;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_wss(struct i2c_client *client, struct v4l2_sliced_vbi_data *data)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        int enable = (data->line != 0);
+
+        if (enable && (data->field != 0 || data->line != 23))
+                return -EINVAL;
+        if (state->wss_enable != enable) {
+                saa7127_dbg("Turn WSS %s\n", enable ? "on" : "off");
+                saa7127_write(client, 0x27, enable << 7);
+                state->wss_enable = enable;
+        }
+        if (!enable)
+                return 0;
+
+        saa7127_write(client, 0x26, data->data[0]);
+        saa7127_write(client, 0x27, 0x80 | (data->data[1] & 0x3f));
+        saa7127_dbg("WSS mode: %s\n", wss_strs[data->data[0] & 0xf]);
+        state->wss_mode = (data->data[1] & 0x3f) << 8 | data->data[0];
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_video_enable(struct i2c_client *client, int enable)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+
+        if (enable) {
+                saa7127_dbg("Enable Video Output\n");
+                saa7127_write(client, 0x2d, state->reg_2d);
+                saa7127_write(client, 0x61, state->reg_61);
+        } else {
+                saa7127_dbg("Disable Video Output\n");
+                saa7127_write(client, 0x2d, (state->reg_2d & 0xf0));
+                saa7127_write(client, 0x61, (state->reg_61 | 0xc0));
+        }
+        state->video_enable = enable;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_std(struct i2c_client *client, v4l2_std_id std)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        const struct i2c_reg_value *inittab;
+
+        if (std & V4L2_STD_525_60) {
+                saa7127_dbg("Selecting 60 Hz video Standard\n");
+                inittab = saa7127_init_config_60hz;
+                state->reg_61 = SAA7127_60HZ_DAC_CONTROL;
+        } else {
+                saa7127_dbg("Selecting 50 Hz video Standard\n");
+                inittab = saa7127_init_config_50hz;
+                state->reg_61 = SAA7127_50HZ_DAC_CONTROL;
+        }
+
+        /* Write Table */
+        saa7127_write_inittab(client, inittab);
+        state->std = std;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_output_type(struct i2c_client *client, int output)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+
+        switch (output) {
+        case SAA7127_OUTPUT_TYPE_RGB:
+                state->reg_2d = 0x0f;   /* RGB + CVBS (for sync) */
+                state->reg_3a = 0x13;   /* by default switch YUV to RGB-matrix on */
+                break;
+
+        case SAA7127_OUTPUT_TYPE_COMPOSITE:
+                state->reg_2d = 0x08;   /* 00001000 CVBS only, RGB DAC's off (high impedance mode) */
+                state->reg_3a = 0x13;   /* by default switch YUV to RGB-matrix on */
+                break;
+
+        case SAA7127_OUTPUT_TYPE_SVIDEO:
+                state->reg_2d = 0xff;   /* 11111111  croma -> R, luma -> CVBS + G + B */
+                state->reg_3a = 0x13;   /* by default switch YUV to RGB-matrix on */
+                break;
+
+        case SAA7127_OUTPUT_TYPE_YUV_V:
+                state->reg_2d = 0x4f;   /* reg 2D = 01001111, all DAC's on, RGB + VBS */
+                state->reg_3a = 0x0b;   /* reg 3A = 00001011, bypass RGB-matrix */
+                break;
+
+        case SAA7127_OUTPUT_TYPE_YUV_C:
+                state->reg_2d = 0x0f;   /* reg 2D = 00001111, all DAC's on, RGB + CVBS */
+                state->reg_3a = 0x0b;   /* reg 3A = 00001011, bypass RGB-matrix */
+                break;
+
+        case SAA7127_OUTPUT_TYPE_BOTH:
+                state->reg_2d = 0xbf;
+                state->reg_3a = 0x13;   /* by default switch YUV to RGB-matrix on */
+                break;
+
+        default:
+                return -EINVAL;
+        }
+        saa7127_dbg("Selecting %s output type\n", output_strs[output]);
+
+        /* Configure Encoder */
+        saa7127_write(client, 0x2d, state->reg_2d);
+        saa7127_write(client, 0x3a, state->reg_3a | state->reg_3a_cb);
+        state->output_type = output;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_set_input_type(struct i2c_client *client, int input)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+
+        switch (input) {
+        case SAA7127_INPUT_TYPE_NORMAL: /* avia */
+                saa7127_dbg("Selecting Normal Encoder Input\n");
+                state->reg_3a_cb = 0;
+                break;
+
+        case SAA7127_INPUT_TYPE_TEST_IMAGE:     /* color bar */
+                saa7127_dbg("Selecting Color Bar generator\n");
+                state->reg_3a_cb = 0x80;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+        saa7127_write(client, 0x3a, state->reg_3a | state->reg_3a_cb);
+        state->input_type = input;
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_command(struct i2c_client *client,
+                           unsigned int cmd, void *arg)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        struct v4l2_format *fmt = arg;
+        int *iarg = arg;
+
+        switch (cmd) {
+        case VIDIOC_S_STD:
+                if (state->std == *(v4l2_std_id *)arg)
+                        break;
+                return saa7127_set_std(client, *(v4l2_std_id *)arg);
+
+        case VIDIOC_G_STD:
+                *(v4l2_std_id *)arg = state->std;
+                break;
+
+        case VIDIOC_S_INPUT:
+                if (state->input_type == *iarg)
+                        break;
+                return saa7127_set_input_type(client, *iarg);
+
+        case VIDIOC_S_OUTPUT:
+                if (state->output_type == *iarg)
+                        break;
+                return saa7127_set_output_type(client, *iarg);
+
+        case VIDIOC_STREAMON:
+        case VIDIOC_STREAMOFF:
+                if (state->video_enable == (cmd == VIDIOC_STREAMON))
+                        break;
+                return saa7127_set_video_enable(client, cmd == VIDIOC_STREAMON);
+
+        case VIDIOC_G_FMT:
+                if (fmt->type != V4L2_BUF_TYPE_SLICED_VBI_CAPTURE)
+                        return -EINVAL;
+
+                memset(&fmt->fmt.sliced, 0, sizeof(fmt->fmt.sliced));
+                if (state->vps_enable)
+                        fmt->fmt.sliced.service_lines[0][16] = V4L2_SLICED_VPS;
+                if (state->wss_enable)
+                        fmt->fmt.sliced.service_lines[0][23] = V4L2_SLICED_WSS_625;
+                if (state->cc_enable) {
+                        fmt->fmt.sliced.service_lines[0][21] = V4L2_SLICED_CAPTION_525;
+                        fmt->fmt.sliced.service_lines[1][21] = V4L2_SLICED_CAPTION_525;
+                }
+                fmt->fmt.sliced.service_set =
+                        (state->vps_enable ? V4L2_SLICED_VPS : 0) |
+                        (state->wss_enable ? V4L2_SLICED_WSS_625 : 0) |
+                        (state->cc_enable ? V4L2_SLICED_CAPTION_525 : 0);
+                break;
+
+        case VIDIOC_LOG_STATUS:
+                saa7127_info("Standard: %s\n", (state->std & V4L2_STD_525_60) ? "60 Hz" : "50 Hz");
+                saa7127_info("Input:    %s\n", state->input_type ?  "color bars" : "normal");
+                saa7127_info("Output:   %s\n", state->video_enable ?
+                        output_strs[state->output_type] : "disabled");
+                saa7127_info("WSS:      %s\n", state->wss_enable ?
+                        wss_strs[state->wss_mode] : "disabled");
+                saa7127_info("VPS:      %s\n", state->vps_enable ? "enabled" : "disabled");
+                saa7127_info("CC:       %s\n", state->cc_enable ? "enabled" : "disabled");
+                break;
+
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+        case VIDIOC_INT_G_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_SAA7127)
+                        return -EINVAL;
+                reg->val = saa7127_read(client, reg->reg & 0xff);
+                break;
+        }
+
+        case VIDIOC_INT_S_REGISTER:
+        {
+                struct v4l2_register *reg = arg;
+
+                if (reg->i2c_id != I2C_DRIVERID_SAA7127)
+                        return -EINVAL;
+                if (!capable(CAP_SYS_ADMIN))
+                        return -EPERM;
+                saa7127_write(client, reg->reg & 0xff, reg->val & 0xff);
+                break;
+        }
+#endif
+
+        case VIDIOC_INT_S_VBI_DATA:
+        {
+                struct v4l2_sliced_vbi_data *data = arg;
+
+                switch (data->id) {
+                        case V4L2_SLICED_WSS_625:
+                                return saa7127_set_wss(client, data);
+                        case V4L2_SLICED_VPS:
+                                return saa7127_set_vps(client, data);
+                        case V4L2_SLICED_CAPTION_525:
+                                if (data->field == 0)
+                                        return saa7127_set_cc(client, data);
+                                return saa7127_set_xds(client, data);
+                        default:
+                                return -EINVAL;
+                }
+                break;
+        }
+
+        case VIDIOC_INT_G_CHIP_IDENT:
+                *(enum v4l2_chip_ident *)arg = state->ident;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+struct i2c_driver i2c_driver_saa7127;
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_attach(struct i2c_adapter *adapter, int address, int kind)
+{
+        struct i2c_client *client;
+        struct saa7127_state *state;
+        struct v4l2_sliced_vbi_data vbi = { 0, 0, 0, 0 };  /* set to disabled */
+        int read_result = 0;
+
+        /* Check if the adapter supports the needed features */
+        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
+                return 0;
+
+        client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+        if (client == 0)
+                return -ENOMEM;
+
+        memset(client, 0, sizeof(struct i2c_client));
+        client->addr = address;
+        client->adapter = adapter;
+        client->driver = &i2c_driver_saa7127;
+        client->flags = I2C_CLIENT_ALLOW_USE;
+        snprintf(client->name, sizeof(client->name) - 1, "saa7127");
+
+        saa7127_dbg("detecting saa7127 client on address 0x%x\n", address << 1);
+
+        /* First test register 0: Bits 5-7 are a version ID (should be 0),
+           and bit 2 should also be 0.
+           This is rather general, so the second test is more specific and
+           looks at the 'ending point of burst in clock cycles' which is
+           0x1d after a reset and not expected to ever change. */
+        if ((saa7127_read(client, 0) & 0xe4) != 0 ||
+                        (saa7127_read(client, 0x29) & 0x3f) != 0x1d) {
+                saa7127_dbg("saa7127 not found\n");
+                kfree(client);
+                return 0;
+        }
+        state = kmalloc(sizeof(struct saa7127_state), GFP_KERNEL);
+
+        if (state == NULL) {
+                kfree(client);
+                return (-ENOMEM);
+        }
+
+        i2c_set_clientdata(client, state);
+        memset(state, 0, sizeof(struct saa7127_state));
+
+        /* Configure Encoder */
+
+        saa7127_dbg("Configuring encoder\n");
+        saa7127_write_inittab(client, saa7127_init_config_common);
+        saa7127_set_std(client, V4L2_STD_NTSC);
+        saa7127_set_output_type(client, SAA7127_OUTPUT_TYPE_BOTH);
+        saa7127_set_vps(client, &vbi);
+        saa7127_set_wss(client, &vbi);
+        saa7127_set_cc(client, &vbi);
+        saa7127_set_xds(client, &vbi);
+        if (test_image == 1) {
+                /* The Encoder has an internal Colorbar generator */
+                /* This can be used for debugging */
+                saa7127_set_input_type(client, SAA7127_INPUT_TYPE_TEST_IMAGE);
+        } else {
+                saa7127_set_input_type(client, SAA7127_INPUT_TYPE_NORMAL);
+        }
+        saa7127_set_video_enable(client, 1);
+
+        /* Detect if it's an saa7129 */
+        read_result = saa7127_read(client, SAA7129_REG_FADE_KEY_COL2);
+        saa7127_write(client, SAA7129_REG_FADE_KEY_COL2, 0xaa);
+        if (saa7127_read(client, SAA7129_REG_FADE_KEY_COL2) == 0xaa) {
+                saa7127_info("saa7129 found @ 0x%x (%s)\n", address << 1, adapter->name);
+                saa7127_write(client, SAA7129_REG_FADE_KEY_COL2, read_result);
+                saa7127_write_inittab(client, saa7129_init_config_extra);
+                state->ident = V4L2_IDENT_SAA7129;
+        } else {
+                saa7127_info("saa7127 found @ 0x%x (%s)\n", address << 1, adapter->name);
+                state->ident = V4L2_IDENT_SAA7127;
+        }
+
+        i2c_attach_client(client);
+
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_probe(struct i2c_adapter *adapter)
+{
+#ifdef I2C_CLASS_TV_ANALOG
+        if (adapter->class & I2C_CLASS_TV_ANALOG)
+#else
+        if (adapter->id == I2C_HW_B_BT848)
+#endif
+                return i2c_probe(adapter, &addr_data, saa7127_attach);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+static int saa7127_detach(struct i2c_client *client)
+{
+        struct saa7127_state *state = i2c_get_clientdata(client);
+        int err;
+
+        /* Turn off TV output */
+        saa7127_set_video_enable(client, 0);
+
+        err = i2c_detach_client(client);
+
+        if (err) {
+                return err;
+        }
+
+        kfree(state);
+        kfree(client);
+        return 0;
+}
+
+/* ----------------------------------------------------------------------- */
+
+struct i2c_driver i2c_driver_saa7127 = {
+        .name = "saa7127",
+        .id = I2C_DRIVERID_SAA7127,
+        .flags = I2C_DF_NOTIFY,
+        .attach_adapter = saa7127_probe,
+        .detach_client = saa7127_detach,
+        .command = saa7127_command,
+        .owner = THIS_MODULE,
+};
+
+
+/* ----------------------------------------------------------------------- */
+
+static int __init saa7127_init_module(void)
+{
+        return i2c_add_driver(&i2c_driver_saa7127);
+}
+
+/* ----------------------------------------------------------------------- */
+
+static void __exit saa7127_cleanup_module(void)
+{
+        i2c_del_driver(&i2c_driver_saa7127);
+}
+
+/* ----------------------------------------------------------------------- */
+
+module_init(saa7127_init_module);
+module_exit(saa7127_cleanup_module);
diff --git a/drivers/media/video/saa7134/Kconfig b/drivers/media/video/saa7134/Kconfig
index 624e8808a517..7bdeabe638ca 100644
--- a/drivers/media/video/saa7134/Kconfig
+++ b/drivers/media/video/saa7134/Kconfig
@@ -1,10 +1,11 @@
 config VIDEO_SAA7134
         tristate "Philips SAA7134 support"
-        depends on VIDEO_DEV && PCI && I2C && SOUND
+        depends on VIDEO_DEV && PCI && I2C && SOUND && SND
         select VIDEO_BUF
         select VIDEO_IR
         select VIDEO_TUNER
         select CRC32
+        select SND_PCM_OSS
         ---help---
           This is a video4linux driver for Philips SAA713x based
           TV cards.
diff --git a/drivers/media/video/saa7134/Makefile b/drivers/media/video/saa7134/Makefile
index e0b28f0533af..4226b61cc613 100644
--- a/drivers/media/video/saa7134/Makefile
+++ b/drivers/media/video/saa7134/Makefile
@@ -1,10 +1,11 @@
 
 saa7134-objs := saa7134-cards.o saa7134-core.o saa7134-i2c.o    \
-                saa7134-oss.o saa7134-ts.o saa7134-tvaudio.o    \
-                saa7134-vbi.o saa7134-video.o saa7134-input.o
+                saa7134-ts.o saa7134-tvaudio.o saa7134-vbi.o    \
+                saa7134-video.o saa7134-input.o
 
 obj-$(CONFIG_VIDEO_SAA7134) +=  saa7134.o saa7134-empress.o \
-                                saa6752hs.o saa7134-alsa.o
+                                saa6752hs.o saa7134-alsa.o \
+                                saa7134-oss.o
 obj-$(CONFIG_VIDEO_SAA7134_DVB) += saa7134-dvb.o
 
 EXTRA_CFLAGS += -I$(src)/..
diff --git a/drivers/media/video/saa7134/saa7134-alsa.c b/drivers/media/video/saa7134/saa7134-alsa.c
index 4f3c42354329..5707c666660b 100644
--- a/drivers/media/video/saa7134/saa7134-alsa.c
+++ b/drivers/media/video/saa7134/saa7134-alsa.c
@@ -30,7 +30,9 @@
 #include <sound/core.h>
 #include <sound/control.h>
 #include <sound/pcm.h>
+#include <sound/pcm_params.h>
 #include <sound/initval.h>
+#include <linux/interrupt.h>
 
 #include "saa7134.h"
 #include "saa7134-reg.h"
@@ -56,6 +58,8 @@ static int enable[SNDRV_CARDS] = {1, [1 ... (SNDRV_CARDS - 1)] = 0};
 module_param_array(index, int, NULL, 0444);
 MODULE_PARM_DESC(index, "Index value for SAA7134 capture interface(s).");
 
+int position;
+
 #define dprintk(fmt, arg...)    if (debug) \
         printk(KERN_DEBUG "%s/alsa: " fmt, dev->name , ## arg)
 
@@ -68,7 +72,7 @@ typedef struct snd_card_saa7134 {
         int mixer_volume[MIXER_ADDR_LAST+1][2];
         int capture_source[MIXER_ADDR_LAST+1][2];
         struct pci_dev *pci;
-        struct saa7134_dev *saadev;
+        struct saa7134_dev *dev;
 
         unsigned long iobase;
         int irq;
@@ -83,12 +87,10 @@ typedef struct snd_card_saa7134 {
  */
 
 typedef struct snd_card_saa7134_pcm {
-        struct saa7134_dev *saadev;
+        struct saa7134_dev *dev;
 
         spinlock_t lock;
-        unsigned int pcm_size;          /* buffer size */
-        unsigned int pcm_count;         /* bytes per period */
-        unsigned int pcm_bps;           /* bytes per second */
+
         snd_pcm_substream_t *substream;
 } snd_card_saa7134_pcm_t;
 
@@ -100,13 +102,11 @@ static snd_card_t *snd_saa7134_cards[SNDRV_CARDS];
  *
  *   Called when the capture device is released or the buffer overflows
  *
- *   - Copied verbatim from saa7134-oss's dsp_dma_stop. Can be dropped
- *     if we just share dsp_dma_stop and use it here
+ *   - Copied verbatim from saa7134-oss's dsp_dma_stop.
  *
  */
 
 static void saa7134_dma_stop(struct saa7134_dev *dev)
-
 {
         dev->dmasound.dma_blk     = -1;
         dev->dmasound.dma_running = 0;
@@ -118,8 +118,7 @@ static void saa7134_dma_stop(struct saa7134_dev *dev)
  *
  *   Called when preparing the capture device for use
  *
- *   - Copied verbatim from saa7134-oss's dsp_dma_start. Can be dropped
- *     if we just share dsp_dma_start and use it here
+ *   - Copied verbatim from saa7134-oss's dsp_dma_start.
  *
  */
 
@@ -170,9 +169,9 @@ void saa7134_irq_alsa_done(struct saa7134_dev *dev, unsigned long status)
         if (dev->dmasound.read_count >= dev->dmasound.blksize * (dev->dmasound.blocks-2)) {
                 dprintk("irq: overrun [full=%d/%d] - Blocks in %d\n",dev->dmasound.read_count,
                         dev->dmasound.bufsize, dev->dmasound.blocks);
+                spin_unlock(&dev->slock);
                 snd_pcm_stop(dev->dmasound.substream,SNDRV_PCM_STATE_XRUN);
-                saa7134_dma_stop(dev);
-                goto done;
+                return;
         }
 
         /* next block addr */
@@ -194,6 +193,7 @@ void saa7134_irq_alsa_done(struct saa7134_dev *dev, unsigned long status)
                 snd_pcm_period_elapsed(dev->dmasound.substream);
                 spin_lock(&dev->slock);
         }
+
  done:
         spin_unlock(&dev->slock);
 
@@ -209,7 +209,9 @@ void saa7134_irq_alsa_done(struct saa7134_dev *dev, unsigned long status)
 
 static irqreturn_t saa7134_alsa_irq(int irq, void *dev_id, struct pt_regs *regs)
 {
-        struct saa7134_dev *dev = (struct saa7134_dev*) dev_id;
+        struct saa7134_dmasound *dmasound = dev_id;
+        struct saa7134_dev *dev = dmasound->priv_data;
+
         unsigned long report, status;
         int loop, handled = 0;
 
@@ -248,56 +250,23 @@ static int snd_card_saa7134_capture_trigger(snd_pcm_substream_t * substream,
                                           int cmd)
 {
         snd_pcm_runtime_t *runtime = substream->runtime;
-        snd_card_saa7134_pcm_t *saapcm = runtime->private_data;
-        struct saa7134_dev *dev=saapcm->saadev;
+        snd_card_saa7134_pcm_t *pcm = runtime->private_data;
+        struct saa7134_dev *dev=pcm->dev;
         int err = 0;
 
-        spin_lock_irq(&dev->slock);
-        if (cmd == SNDRV_PCM_TRIGGER_START) {
+        spin_lock(&dev->slock);
+        if (cmd == SNDRV_PCM_TRIGGER_START) {
                 /* start dma */
                 saa7134_dma_start(dev);
-        } else if (cmd == SNDRV_PCM_TRIGGER_STOP) {
+        } else if (cmd == SNDRV_PCM_TRIGGER_STOP) {
                 /* stop dma */
                 saa7134_dma_stop(dev);
-        } else {
-                err = -EINVAL;
-        }
-        spin_unlock_irq(&dev->slock);
-
-        return err;
-}
-
-/*
- * DMA buffer config
- *
- *   Sets the values that will later be used as the size of the buffer,
- *  size of the fragments, and total number of fragments.
- *   Must be called during the preparation stage, before memory is
- *  allocated
- *
- *   - Copied verbatim from saa7134-oss. Can be dropped
- *     if we just share dsp_buffer_conf from OSS.
- */
+        } else {
+                err = -EINVAL;
+        }
+        spin_unlock(&dev->slock);
 
-static int dsp_buffer_conf(struct saa7134_dev *dev, int blksize, int blocks)
-{
-        if (blksize < 0x100)
-                blksize = 0x100;
-        if (blksize > 0x10000)
-                blksize = 0x10000;
-
-        if (blocks < 2)
-                blocks = 2;
-        if ((blksize * blocks) > 1024*1024)
-                blocks = 1024*1024 / blksize;
-
-        dev->dmasound.blocks  = blocks;
-        dev->dmasound.blksize = blksize;
-        dev->dmasound.bufsize = blksize * blocks;
-
-        dprintk("buffer config: %d blocks / %d bytes, %d kB total\n",
-                blocks,blksize,blksize * blocks / 1024);
-        return 0;
+        return err;
 }
 
 /*
@@ -307,16 +276,16 @@ static int dsp_buffer_conf(struct saa7134_dev *dev, int blksize, int blocks)
  *  ALSA, but I was unable to use ALSA's own DMA, and had to force the
  *  usage of V4L's
  *
- *   - Copied verbatim from saa7134-oss. Can be dropped
- *     if we just share dsp_buffer_init from OSS.
+ *   - Copied verbatim from saa7134-oss.
+ *
  */
 
 static int dsp_buffer_init(struct saa7134_dev *dev)
 {
         int err;
 
-        if (!dev->dmasound.bufsize)
-                BUG();
+        BUG_ON(!dev->dmasound.bufsize);
+
         videobuf_dma_init(&dev->dmasound.dma);
         err = videobuf_dma_init_kernel(&dev->dmasound.dma, PCI_DMA_FROMDEVICE,
                                        (dev->dmasound.bufsize + PAGE_SIZE) >> PAGE_SHIFT);
@@ -326,6 +295,28 @@ static int dsp_buffer_init(struct saa7134_dev *dev)
 }
 
 /*
+ * DMA buffer release
+ *
+ *   Called after closing the device, during snd_card_saa7134_capture_close
+ *
+ */
+
+static int dsp_buffer_free(struct saa7134_dev *dev)
+{
+        if (!dev->dmasound.blksize)
+                BUG();
+
+        videobuf_dma_free(&dev->dmasound.dma);
+
+        dev->dmasound.blocks  = 0;
+        dev->dmasound.blksize = 0;
+        dev->dmasound.bufsize = 0;
+
+       return 0;
+}
+
+
+/*
  * ALSA PCM preparation
  *
  *   - One of the ALSA capture callbacks.
@@ -340,84 +331,30 @@ static int dsp_buffer_init(struct saa7134_dev *dev)
 static int snd_card_saa7134_capture_prepare(snd_pcm_substream_t * substream)
 {
         snd_pcm_runtime_t *runtime = substream->runtime;
-        int err, bswap, sign;
+        int bswap, sign;
         u32 fmt, control;
         snd_card_saa7134_t *saa7134 = snd_pcm_substream_chip(substream);
         struct saa7134_dev *dev;
-        snd_card_saa7134_pcm_t *saapcm = runtime->private_data;
-        unsigned int bps;
-        unsigned long size;
-        unsigned count;
-
-        size = snd_pcm_lib_buffer_bytes(substream);
-        count = snd_pcm_lib_period_bytes(substream);
-
-        saapcm->saadev->dmasound.substream = substream;
-        bps = runtime->rate * runtime->channels;
-        bps *= snd_pcm_format_width(runtime->format);
-        bps /= 8;
-        if (bps <= 0)
-                return -EINVAL;
-        saapcm->pcm_bps = bps;
-        saapcm->pcm_size = snd_pcm_lib_buffer_bytes(substream);
-        saapcm->pcm_count = snd_pcm_lib_period_bytes(substream);
-
+        snd_card_saa7134_pcm_t *pcm = runtime->private_data;
 
-        dev=saa7134->saadev;
+        pcm->dev->dmasound.substream = substream;
 
-        dsp_buffer_conf(dev,saapcm->pcm_count,(saapcm->pcm_size/saapcm->pcm_count));
+        dev = saa7134->dev;
 
-        err = dsp_buffer_init(dev);
-        if (0 != err)
-                goto fail2;
-
-        /* prepare buffer */
-        if (0 != (err = videobuf_dma_pci_map(dev->pci,&dev->dmasound.dma)))
-                return err;
-        if (0 != (err = saa7134_pgtable_alloc(dev->pci,&dev->dmasound.pt)))
-                goto fail1;
-        if (0 != (err = saa7134_pgtable_build(dev->pci,&dev->dmasound.pt,
-                                              dev->dmasound.dma.sglist,
-                                              dev->dmasound.dma.sglen,
-                                              0)))
-                goto fail2;
-
-
-
-        switch (runtime->format) {
-          case SNDRV_PCM_FORMAT_U8:
-          case SNDRV_PCM_FORMAT_S8:
+        if (snd_pcm_format_width(runtime->format) == 8)
                 fmt = 0x00;
-                break;
-          case SNDRV_PCM_FORMAT_U16_LE:
-          case SNDRV_PCM_FORMAT_U16_BE:
-          case SNDRV_PCM_FORMAT_S16_LE:
-          case SNDRV_PCM_FORMAT_S16_BE:
+        else
                 fmt = 0x01;
-                break;
-          default:
-                err = -EINVAL;
-                return 1;
-        }
 
-        switch (runtime->format) {
-          case SNDRV_PCM_FORMAT_S8:
-          case SNDRV_PCM_FORMAT_S16_LE:
-          case SNDRV_PCM_FORMAT_S16_BE:
+        if (snd_pcm_format_signed(runtime->format))
                 sign = 1;
-                break;
-          default:
+        else
                 sign = 0;
-                break;
-        }
 
-        switch (runtime->format) {
-          case SNDRV_PCM_FORMAT_U16_BE:
-          case SNDRV_PCM_FORMAT_S16_BE:
-                bswap = 1; break;
-          default:
-                bswap = 0; break;
-        }
+        if (snd_pcm_format_big_endian(runtime->format))
+                bswap = 1;
+        else
+                bswap = 0;
 
         switch (dev->pci->device) {
           case PCI_DEVICE_ID_PHILIPS_SAA7134:
@@ -445,7 +382,6 @@ static int snd_card_saa7134_capture_prepare(snd_pcm_substream_t * substream)
                         fmt |= 0x04;
                 saa_writel(SAA7133_NUM_SAMPLES, dev->dmasound.blksize -1);
                 saa_writel(SAA7133_AUDIO_CHANNEL, 0x543210 | (fmt << 24));
-                //saa_writel(SAA7133_AUDIO_CHANNEL, 0x543210);
                 break;
         }
 
@@ -459,12 +395,6 @@ static int snd_card_saa7134_capture_prepare(snd_pcm_substream_t * substream)
         if (bswap)
                 control |= SAA7134_RS_CONTROL_BSWAP;
 
-        /* I should be able to use runtime->dma_addr in the control
-           byte, but it doesn't work. So I allocate the DMA using the
-           V4L functions, and force ALSA to use that as the DMA area */
-
-        runtime->dma_area = dev->dmasound.dma.vmalloc;
-
         saa_writel(SAA7134_RS_BA1(6),0);
         saa_writel(SAA7134_RS_BA2(6),dev->dmasound.blksize);
         saa_writel(SAA7134_RS_PITCH(6),0);
@@ -473,12 +403,6 @@ static int snd_card_saa7134_capture_prepare(snd_pcm_substream_t * substream)
         dev->dmasound.rate = runtime->rate;
 
         return 0;
- fail2:
-        saa7134_pgtable_free(dev->pci,&dev->dmasound.pt);
- fail1:
-        videobuf_dma_pci_unmap(dev->pci,&dev->dmasound.dma);
-        return err;
-
 
 }
 
@@ -496,10 +420,8 @@ static int snd_card_saa7134_capture_prepare(snd_pcm_substream_t * substream)
 static snd_pcm_uframes_t snd_card_saa7134_capture_pointer(snd_pcm_substream_t * substream)
 {
         snd_pcm_runtime_t *runtime = substream->runtime;
-        snd_card_saa7134_pcm_t *saapcm = runtime->private_data;
-        struct saa7134_dev *dev=saapcm->saadev;
-
-
+        snd_card_saa7134_pcm_t *pcm = runtime->private_data;
+        struct saa7134_dev *dev=pcm->dev;
 
         if (dev->dmasound.read_count) {
                 dev->dmasound.read_count  -= snd_pcm_lib_period_bytes(substream);
@@ -540,9 +462,9 @@ static snd_pcm_hardware_t snd_card_saa7134_capture =
 
 static void snd_card_saa7134_runtime_free(snd_pcm_runtime_t *runtime)
 {
-        snd_card_saa7134_pcm_t *saapcm = runtime->private_data;
+        snd_card_saa7134_pcm_t *pcm = runtime->private_data;
 
-        kfree(saapcm);
+        kfree(pcm);
 }
 
 
@@ -552,17 +474,76 @@ static void snd_card_saa7134_runtime_free(snd_pcm_runtime_t *runtime)
  *   - One of the ALSA capture callbacks.
  *
  *   Called on initialization, right before the PCM preparation
- *   Usually used in ALSA to allocate the DMA, but since we don't use the
- *  ALSA DMA it does nothing
  *
  */
 
 static int snd_card_saa7134_hw_params(snd_pcm_substream_t * substream,
                                     snd_pcm_hw_params_t * hw_params)
 {
+        snd_card_saa7134_t *saa7134 = snd_pcm_substream_chip(substream);
+        struct saa7134_dev *dev;
+        unsigned int period_size, periods;
+        int err;
 
-        return 0;
+        period_size = params_period_bytes(hw_params);
+        periods = params_periods(hw_params);
+
+        snd_assert(period_size >= 0x100 && period_size <= 0x10000,
+                   return -EINVAL);
+        snd_assert(periods >= 2, return -EINVAL);
+        snd_assert(period_size * periods <= 1024 * 1024, return -EINVAL);
 
+        dev = saa7134->dev;
+
+        if (dev->dmasound.blocks == periods &&
+            dev->dmasound.blksize == period_size)
+                return 0;
+
+        /* release the old buffer */
+        if (substream->runtime->dma_area) {
+                saa7134_pgtable_free(dev->pci, &dev->dmasound.pt);
+                videobuf_dma_pci_unmap(dev->pci, &dev->dmasound.dma);
+                dsp_buffer_free(dev);
+                substream->runtime->dma_area = NULL;
+        }
+        dev->dmasound.blocks  = periods;
+        dev->dmasound.blksize = period_size;
+        dev->dmasound.bufsize = period_size * periods;
+
+        err = dsp_buffer_init(dev);
+        if (0 != err) {
+                dev->dmasound.blocks  = 0;
+                dev->dmasound.blksize = 0;
+                dev->dmasound.bufsize = 0;
+                return err;
+        }
+
+        if (0 != (err = videobuf_dma_pci_map(dev->pci, &dev->dmasound.dma))) {
+                dsp_buffer_free(dev);
+                return err;
+        }
+        if (0 != (err = saa7134_pgtable_alloc(dev->pci,&dev->dmasound.pt))) {
+                videobuf_dma_pci_unmap(dev->pci, &dev->dmasound.dma);
+                dsp_buffer_free(dev);
+                return err;
+        }
+        if (0 != (err = saa7134_pgtable_build(dev->pci,&dev->dmasound.pt,
+                                                dev->dmasound.dma.sglist,
+                                                dev->dmasound.dma.sglen,
+                                                0))) {
+                saa7134_pgtable_free(dev->pci, &dev->dmasound.pt);
+                videobuf_dma_pci_unmap(dev->pci, &dev->dmasound.dma);
+                dsp_buffer_free(dev);
+                return err;
+        }
+
+        /* I should be able to use runtime->dma_addr in the control
+           byte, but it doesn't work. So I allocate the DMA using the
+           V4L functions, and force ALSA to use that as the DMA area */
+
+        substream->runtime->dma_area = dev->dmasound.dma.vmalloc;
+
+        return 1;
 
 }
 
@@ -572,33 +553,23 @@ static int snd_card_saa7134_hw_params(snd_pcm_substream_t * substream,
  *   - One of the ALSA capture callbacks.
  *
  *   Called after closing the device, but before snd_card_saa7134_capture_close
- *   Usually used in ALSA to free the DMA, but since we don't use the
- *  ALSA DMA I'm almost sure this isn't necessary.
+ *   It stops the DMA audio and releases the buffers.
  *
  */
 
 static int snd_card_saa7134_hw_free(snd_pcm_substream_t * substream)
 {
-        return 0;
-}
-
-/*
- * DMA buffer release
- *
- *   Called after closing the device, during snd_card_saa7134_capture_close
- *
- */
-
-static int dsp_buffer_free(struct saa7134_dev *dev)
-{
-        if (!dev->dmasound.blksize)
-                BUG();
+        snd_card_saa7134_t *saa7134 = snd_pcm_substream_chip(substream);
+        struct saa7134_dev *dev;
 
-        videobuf_dma_free(&dev->dmasound.dma);
+        dev = saa7134->dev;
 
-        dev->dmasound.blocks  = 0;
-        dev->dmasound.blksize = 0;
-        dev->dmasound.bufsize = 0;
+        if (substream->runtime->dma_area) {
+                saa7134_pgtable_free(dev->pci, &dev->dmasound.pt);
+                videobuf_dma_pci_unmap(dev->pci, &dev->dmasound.dma);
+                dsp_buffer_free(dev);
+                substream->runtime->dma_area = NULL;
+        }
 
         return 0;
 }
@@ -608,21 +579,12 @@ static int dsp_buffer_free(struct saa7134_dev *dev)
  *
  *   - One of the ALSA capture callbacks.
  *
- *   Called after closing the device. It stops the DMA audio and releases
- *  the buffers
+ *   Called after closing the device.
  *
  */
 
 static int snd_card_saa7134_capture_close(snd_pcm_substream_t * substream)
 {
-        snd_card_saa7134_t *chip = snd_pcm_substream_chip(substream);
-        struct saa7134_dev *dev = chip->saadev;
-
-        /* unlock buffer */
-        saa7134_pgtable_free(dev->pci,&dev->dmasound.pt);
-        videobuf_dma_pci_unmap(dev->pci,&dev->dmasound.dma);
-
-        dsp_buffer_free(dev);
         return 0;
 }
 
@@ -639,29 +601,28 @@ static int snd_card_saa7134_capture_close(snd_pcm_substream_t * substream)
 static int snd_card_saa7134_capture_open(snd_pcm_substream_t * substream)
 {
         snd_pcm_runtime_t *runtime = substream->runtime;
-        snd_card_saa7134_pcm_t *saapcm;
+        snd_card_saa7134_pcm_t *pcm;
         snd_card_saa7134_t *saa7134 = snd_pcm_substream_chip(substream);
-        struct saa7134_dev *dev = saa7134->saadev;
+        struct saa7134_dev *dev = saa7134->dev;
         int err;
 
         down(&dev->dmasound.lock);
 
-        dev->dmasound.afmt        = SNDRV_PCM_FORMAT_U8;
-        dev->dmasound.channels    = 2;
         dev->dmasound.read_count  = 0;
         dev->dmasound.read_offset = 0;
 
         up(&dev->dmasound.lock);
 
-        saapcm = kzalloc(sizeof(*saapcm), GFP_KERNEL);
-        if (saapcm == NULL)
+        pcm = kzalloc(sizeof(*pcm), GFP_KERNEL);
+        if (pcm == NULL)
                 return -ENOMEM;
-        saapcm->saadev=saa7134->saadev;
 
-        spin_lock_init(&saapcm->lock);
+        pcm->dev=saa7134->dev;
 
-        saapcm->substream = substream;
-        runtime->private_data = saapcm;
+        spin_lock_init(&pcm->lock);
+
+        pcm->substream = substream;
+        runtime->private_data = pcm;
         runtime->private_free = snd_card_saa7134_runtime_free;
         runtime->hw = snd_card_saa7134_capture;
 
@@ -736,7 +697,6 @@ static int snd_saa7134_volume_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
 static int snd_saa7134_volume_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
 {
         snd_card_saa7134_t *chip = snd_kcontrol_chip(kcontrol);
-        unsigned long flags;
         int change, addr = kcontrol->private_value;
         int left, right;
 
@@ -750,12 +710,12 @@ static int snd_saa7134_volume_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_
                 right = 0;
         if (right > 20)
                 right = 20;
-        spin_lock_irqsave(&chip->mixer_lock, flags);
+        spin_lock_irq(&chip->mixer_lock);
         change = chip->mixer_volume[addr][0] != left ||
                  chip->mixer_volume[addr][1] != right;
         chip->mixer_volume[addr][0] = left;
         chip->mixer_volume[addr][1] = right;
-        spin_unlock_irqrestore(&chip->mixer_lock, flags);
+        spin_unlock_irq(&chip->mixer_lock);
         return change;
 }
 
@@ -777,38 +737,37 @@ static int snd_saa7134_capsrc_info(snd_kcontrol_t * kcontrol, snd_ctl_elem_info_
 static int snd_saa7134_capsrc_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
 {
         snd_card_saa7134_t *chip = snd_kcontrol_chip(kcontrol);
-        unsigned long flags;
         int addr = kcontrol->private_value;
 
-        spin_lock_irqsave(&chip->mixer_lock, flags);
+        spin_lock_irq(&chip->mixer_lock);
         ucontrol->value.integer.value[0] = chip->capture_source[addr][0];
         ucontrol->value.integer.value[1] = chip->capture_source[addr][1];
-        spin_unlock_irqrestore(&chip->mixer_lock, flags);
+        spin_unlock_irq(&chip->mixer_lock);
+
         return 0;
 }
 
 static int snd_saa7134_capsrc_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
 {
         snd_card_saa7134_t *chip = snd_kcontrol_chip(kcontrol);
-        unsigned long flags;
         int change, addr = kcontrol->private_value;
         int left, right;
         u32 anabar, xbarin;
         int analog_io, rate;
         struct saa7134_dev *dev;
 
-        dev = chip->saadev;
+        dev = chip->dev;
 
         left = ucontrol->value.integer.value[0] & 1;
         right = ucontrol->value.integer.value[1] & 1;
-        spin_lock_irqsave(&chip->mixer_lock, flags);
+        spin_lock_irq(&chip->mixer_lock);
 
         change = chip->capture_source[addr][0] != left ||
                  chip->capture_source[addr][1] != right;
         chip->capture_source[addr][0] = left;
         chip->capture_source[addr][1] = right;
         dev->dmasound.input=addr;
-        spin_unlock_irqrestore(&chip->mixer_lock, flags);
+        spin_unlock_irq(&chip->mixer_lock);
 
 
         if (change) {
@@ -898,43 +857,44 @@ static int snd_card_saa7134_new_mixer(snd_card_saa7134_t * chip)
         return 0;
 }
 
-static int snd_saa7134_free(snd_card_saa7134_t *chip)
+static void snd_saa7134_free(snd_card_t * card)
 {
-        return 0;
-}
+        snd_card_saa7134_t *chip = card->private_data;
+
+        if (chip->dev->dmasound.priv_data == NULL)
+                return;
+
+        if (chip->irq >= 0) {
+                synchronize_irq(chip->irq);
+                free_irq(chip->irq, &chip->dev->dmasound);
+        }
+
+        chip->dev->dmasound.priv_data = NULL;
 
-static int snd_saa7134_dev_free(snd_device_t *device)
-{
-        snd_card_saa7134_t *chip = device->device_data;
-        return snd_saa7134_free(chip);
 }
 
 /*
  * ALSA initialization
  *
- *   Called by saa7134-core, it creates the basic structures and registers
- *  the ALSA devices
+ *   Called by the init routine, once for each saa7134 device present,
+ *  it creates the basic structures and registers the ALSA devices
  *
  */
 
-int alsa_card_saa7134_create (struct saa7134_dev *saadev)
+int alsa_card_saa7134_create(struct saa7134_dev *dev, int devnum)
 {
-        static int dev;
 
         snd_card_t *card;
         snd_card_saa7134_t *chip;
         int err;
-        static snd_device_ops_t ops = {
-                .dev_free =     snd_saa7134_dev_free,
-        };
 
 
-        if (dev >= SNDRV_CARDS)
+        if (devnum >= SNDRV_CARDS)
                 return -ENODEV;
-        if (!enable[dev])
+        if (!enable[devnum])
                 return -ENODEV;
 
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        card = snd_card_new(index[devnum], id[devnum], THIS_MODULE, sizeof(snd_card_saa7134_t));
 
         if (card == NULL)
                 return -ENOMEM;
@@ -943,34 +903,33 @@ int alsa_card_saa7134_create (struct saa7134_dev *saadev)
 
         /* Card "creation" */
 
-        chip = kcalloc(1, sizeof(*chip), GFP_KERNEL);
-        if (chip == NULL) {
-                return -ENOMEM;
-        }
+        card->private_free = snd_saa7134_free;
+        chip = (snd_card_saa7134_t *) card->private_data;
 
         spin_lock_init(&chip->lock);
         spin_lock_init(&chip->mixer_lock);
 
-        chip->saadev = saadev;
+        chip->dev = dev;
 
         chip->card = card;
 
-        chip->pci = saadev->pci;
-        chip->irq = saadev->pci->irq;
-        chip->iobase = pci_resource_start(saadev->pci, 0);
+        chip->pci = dev->pci;
+        chip->iobase = pci_resource_start(dev->pci, 0);
 
-        err = request_irq(saadev->pci->irq, saa7134_alsa_irq,
-                                SA_SHIRQ | SA_INTERRUPT, saadev->name, saadev);
+
+        err = request_irq(dev->pci->irq, saa7134_alsa_irq,
+                                SA_SHIRQ | SA_INTERRUPT, dev->name,
+                                (void*) &dev->dmasound);
 
         if (err < 0) {
                 printk(KERN_ERR "%s: can't get IRQ %d for ALSA\n",
-                        saadev->name, saadev->pci->irq);
+                        dev->name, dev->pci->irq);
                 goto __nodev;
         }
 
-        if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0) {
-                goto __nodev;
-        }
+        chip->irq = dev->pci->irq;
+
+        init_MUTEX(&dev->dmasound.lock);
 
         if ((err = snd_card_saa7134_new_mixer(chip)) < 0)
                 goto __nodev;
@@ -984,16 +943,15 @@ int alsa_card_saa7134_create (struct saa7134_dev *saadev)
 
         strcpy(card->shortname, "SAA7134");
         sprintf(card->longname, "%s at 0x%lx irq %d",
-                chip->saadev->name, chip->iobase, chip->irq);
+                chip->dev->name, chip->iobase, chip->irq);
 
         if ((err = snd_card_register(card)) == 0) {
-                snd_saa7134_cards[dev] = card;
+                snd_saa7134_cards[devnum] = card;
                 return 0;
         }
 
 __nodev:
         snd_card_free(card);
-        kfree(chip);
         return err;
 }
 
@@ -1007,21 +965,29 @@ __nodev:
 
 static int saa7134_alsa_init(void)
 {
-        struct saa7134_dev *saadev = NULL;
-        struct list_head *list;
+        struct saa7134_dev *dev = NULL;
+        struct list_head *list;
 
-        printk(KERN_INFO "saa7134 ALSA driver for DMA sound loaded\n");
+        position = 0;
 
-        list_for_each(list,&saa7134_devlist) {
-                saadev = list_entry(list, struct saa7134_dev, devlist);
-                alsa_card_saa7134_create(saadev);
-        }
+        printk(KERN_INFO "saa7134 ALSA driver for DMA sound loaded\n");
 
-        if (saadev == NULL)
+        list_for_each(list,&saa7134_devlist) {
+                dev = list_entry(list, struct saa7134_dev, devlist);
+                if (dev->dmasound.priv_data == NULL) {
+                        dev->dmasound.priv_data = dev;
+                        alsa_card_saa7134_create(dev,position);
+                        position++;
+                } else {
+                        printk(KERN_ERR "saa7134 ALSA: DMA sound is being handled by OSS. ignoring %s\n",dev->name);
+                        return -EBUSY;
+                }
+        }
+
+        if (dev == NULL)
                 printk(KERN_INFO "saa7134 ALSA: no saa7134 cards found\n");
 
         return 0;
-
 }
 
 /*
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index 663d03e5bc67..75abc20b0ccd 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -2529,6 +2529,32 @@ struct saa7134_board saa7134_boards[] = {
                         .amux   = LINE1,
                 }},
         },
+        [SAA7134_BOARD_MSI_TVATANYWHERE_PLUS] = {
+                .name           = "MSI TV@Anywhere plus",
+                .audio_clock    = 0x00187de7,
+                .tuner_type     = TUNER_PHILIPS_TDA8290,
+                .radio_type     = UNSET,
+                .tuner_addr     = ADDR_UNSET,
+                .radio_addr     = ADDR_UNSET,
+                .inputs = {{
+                        .name   = name_tv,
+                        .vmux   = 1,
+                        .amux   = TV,
+                        .tv     = 1,
+                },{
+                        .name   = name_comp1,
+                        .vmux   = 3,
+                        .amux   = LINE1,
+                },{
+                        .name   = name_svideo,
+                        .vmux   = 0,
+                        .amux   = LINE1,
+                }},
+                .radio = {
+                        .name   = name_radio,
+                        .amux   = LINE1,
+                },
+        },
 };
 
 const unsigned int saa7134_bcount = ARRAY_SIZE(saa7134_boards);
@@ -2970,6 +2996,12 @@ struct pci_device_id saa7134_pci_tbl[] = {
                 .subdevice    = 0x2018,
                 .driver_data  = SAA7134_BOARD_PHILIPS_TIGER,
         },{
+                .vendor       = PCI_VENDOR_ID_PHILIPS,
+                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
+                .subvendor    = 0x1462,
+                .subdevice    = 0x6231,
+                .driver_data  = SAA7134_BOARD_MSI_TVATANYWHERE_PLUS,
+        },{
                 /* --- boards without eeprom + subsystem ID --- */
                 .vendor       = PCI_VENDOR_ID_PHILIPS,
                 .device       = PCI_DEVICE_ID_PHILIPS_SAA7134,
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index 19b88744fb31..4275d2ddb864 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -53,13 +53,13 @@ static unsigned int gpio_tracking = 0;
 module_param(gpio_tracking, int, 0644);
 MODULE_PARM_DESC(gpio_tracking,"enable debug messages [gpio]");
 
-static unsigned int oss = 0;
-module_param(oss, int, 0444);
-MODULE_PARM_DESC(oss,"register oss devices (default: no)");
-
 static unsigned int alsa = 0;
-module_param(alsa, int, 0444);
-MODULE_PARM_DESC(alsa,"register alsa devices (default: no)");
+module_param(alsa, int, 0644);
+MODULE_PARM_DESC(alsa,"enable ALSA DMA sound [dmasound]");
+
+static unsigned int oss = 0;
+module_param(oss, int, 0644);
+MODULE_PARM_DESC(oss,"enable OSS DMA sound [dmasound]");
 
 static unsigned int latency = UNSET;
 module_param(latency, int, 0444);
@@ -68,24 +68,18 @@ MODULE_PARM_DESC(latency,"pci latency timer");
 static unsigned int video_nr[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
 static unsigned int vbi_nr[]   = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
 static unsigned int radio_nr[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
-static unsigned int dsp_nr[]   = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
-static unsigned int mixer_nr[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
 static unsigned int tuner[]    = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
 static unsigned int card[]     = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
 
 module_param_array(video_nr, int, NULL, 0444);
 module_param_array(vbi_nr,   int, NULL, 0444);
 module_param_array(radio_nr, int, NULL, 0444);
-module_param_array(dsp_nr,   int, NULL, 0444);
-module_param_array(mixer_nr, int, NULL, 0444);
 module_param_array(tuner,    int, NULL, 0444);
 module_param_array(card,     int, NULL, 0444);
 
 MODULE_PARM_DESC(video_nr, "video device number");
 MODULE_PARM_DESC(vbi_nr,   "vbi device number");
 MODULE_PARM_DESC(radio_nr, "radio device number");
-MODULE_PARM_DESC(dsp_nr,   "oss dsp device number");
-MODULE_PARM_DESC(mixer_nr, "oss mixer device number");
 MODULE_PARM_DESC(tuner,    "tuner type");
 MODULE_PARM_DESC(card,     "card type");
 
@@ -195,6 +189,7 @@ void saa7134_track_gpio(struct saa7134_dev *dev, char *msg)
 static int need_empress;
 static int need_dvb;
 static int need_alsa;
+static int need_oss;
 
 static int pending_call(struct notifier_block *self, unsigned long state,
                         void *module)
@@ -208,6 +203,8 @@ static int pending_call(struct notifier_block *self, unsigned long state,
                 request_module("saa7134-dvb");
         if (need_alsa)
                 request_module("saa7134-alsa");
+        if (need_oss)
+                request_module("saa7134-oss");
         return NOTIFY_DONE;
 }
 
@@ -218,10 +215,11 @@ static struct notifier_block pending_notifier = {
 
 static void request_module_depend(char *name, int *flag)
 {
+        int err;
         switch (THIS_MODULE->state) {
         case MODULE_STATE_COMING:
                 if (!pending_registered) {
-                        register_module_notifier(&pending_notifier);
+                        err = register_module_notifier(&pending_notifier);
                         pending_registered = 1;
                 }
                 *flag = 1;
@@ -578,12 +576,14 @@ static irqreturn_t saa7134_irq(int irq, void *dev_id, struct pt_regs *regs)
                         goto out;
                 }
 
-                /* If alsa support is active and we get a sound report, exit
-                   and let the saa7134-alsa module deal with it */
+                /* If dmasound support is active and we get a sound report, exit
+                   and let the saa7134-alsa/oss module deal with it */
 
-                if ((report & SAA7134_IRQ_REPORT_DONE_RA3) && alsa)  {
+                if ((report & SAA7134_IRQ_REPORT_DONE_RA3) &&
+                        (dev->dmasound.priv_data != NULL) )
+                {
                         if (irq_debug > 1)
-                                printk(KERN_DEBUG "%s/irq: ignoring interrupt for ALSA\n",
+                                printk(KERN_DEBUG "%s/irq: ignoring interrupt for DMA sound\n",
                                        dev->name);
                         goto out;
                 }
@@ -609,12 +609,6 @@ static irqreturn_t saa7134_irq(int irq, void *dev_id, struct pt_regs *regs)
                     card_has_mpeg(dev))
                         saa7134_irq_ts_done(dev,status);
 
-                if ((report & SAA7134_IRQ_REPORT_DONE_RA3))  {
-                        if (oss) {
-                                saa7134_irq_oss_done(dev,status);
-                        }
-                }
-
                 if ((report & (SAA7134_IRQ_REPORT_GPIO16 |
                                SAA7134_IRQ_REPORT_GPIO18)) &&
                     dev->remote)
@@ -689,14 +683,6 @@ static int saa7134_hwinit1(struct saa7134_dev *dev)
          * audio will not work.
          */
 
-        switch (dev->pci->device) {
-        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-        case PCI_DEVICE_ID_PHILIPS_SAA7133:
-        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-                saa7134_oss_init1(dev);
-                break;
-        }
-
         /* enable peripheral devices */
         saa_writeb(SAA7134_SPECIAL_MODE, 0x01);
 
@@ -728,8 +714,6 @@ static int saa7134_hwinit2(struct saa7134_dev *dev)
                 irq2_mask |= (SAA7134_IRQ2_INTE_GPIO18  |
                               SAA7134_IRQ2_INTE_GPIO18A |
                               SAA7134_IRQ2_INTE_GPIO16  );
-        else if (dev->has_remote == SAA7134_REMOTE_I2C)
-                request_module("ir-kbd-i2c");
 
         saa_writel(SAA7134_IRQ1, 0);
         saa_writel(SAA7134_IRQ2, irq2_mask);
@@ -742,13 +726,6 @@ static int saa7134_hwfini(struct saa7134_dev *dev)
 {
         dprintk("hwfini\n");
 
-        switch (dev->pci->device) {
-        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-        case PCI_DEVICE_ID_PHILIPS_SAA7133:
-        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-                saa7134_oss_fini(dev);
-                break;
-        }
         if (card_has_mpeg(dev))
                 saa7134_ts_fini(dev);
         saa7134_input_fini(dev);
@@ -986,11 +963,12 @@ static int __devinit saa7134_initdev(struct pci_dev *pci_dev,
         if (card_is_dvb(dev))
                 request_module_depend("saa7134-dvb",&need_dvb);
 
-        if (!oss && alsa) {
-                dprintk("Requesting ALSA module\n");
+
+        if (alsa)
                 request_module_depend("saa7134-alsa",&need_alsa);
-        }
 
+        if (oss)
+                request_module_depend("saa7134-oss",&need_oss);
 
         v4l2_prio_init(&dev->prio);
 
@@ -1024,32 +1002,6 @@ static int __devinit saa7134_initdev(struct pci_dev *pci_dev,
                        dev->name,dev->radio_dev->minor & 0x1f);
         }
 
-        /* register oss devices */
-        switch (dev->pci->device) {
-        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-        case PCI_DEVICE_ID_PHILIPS_SAA7133:
-        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-                if (oss) {
-                        err = dev->dmasound.minor_dsp =
-                                register_sound_dsp(&saa7134_dsp_fops,
-                                                   dsp_nr[dev->nr]);
-                        if (err < 0) {
-                                goto fail4;
-                        }
-                        printk(KERN_INFO "%s: registered device dsp%d\n",
-                               dev->name,dev->dmasound.minor_dsp >> 4);
-
-                        err = dev->dmasound.minor_mixer =
-                                register_sound_mixer(&saa7134_mixer_fops,
-                                                     mixer_nr[dev->nr]);
-                        if (err < 0)
-                                goto fail5;
-                        printk(KERN_INFO "%s: registered device mixer%d\n",
-                               dev->name,dev->dmasound.minor_mixer >> 4);
-                }
-                break;
-        }
-
         /* everything worked */
         pci_set_drvdata(pci_dev,dev);
         saa7134_devcount++;
@@ -1064,17 +1016,9 @@ static int __devinit saa7134_initdev(struct pci_dev *pci_dev,
 
         /* check for signal */
         saa7134_irq_video_intl(dev);
+
         return 0;
 
- fail5:
-        switch (dev->pci->device) {
-        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-        case PCI_DEVICE_ID_PHILIPS_SAA7133:
-        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-                if (oss)
-                        unregister_sound_dsp(dev->dmasound.minor_dsp);
-                break;
-        }
  fail4:
         saa7134_unregister_video(dev);
         saa7134_i2c_unregister(dev);
@@ -1125,19 +1069,16 @@ static void __devexit saa7134_finidev(struct pci_dev *pci_dev)
         saa7134_devcount--;
 
         saa7134_i2c_unregister(dev);
-        switch (dev->pci->device) {
-        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-        case PCI_DEVICE_ID_PHILIPS_SAA7133:
-        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-                if (oss) {
-                        unregister_sound_mixer(dev->dmasound.minor_mixer);
-                        unregister_sound_dsp(dev->dmasound.minor_dsp);
-                }
-                break;
-        }
         saa7134_unregister_video(dev);
 
-        /* release ressources */
+        /* the DMA sound modules should be unloaded before reaching
+           this, but just in case they are still present... */
+        if (dev->dmasound.priv_data != NULL) {
+                free_irq(pci_dev->irq, &dev->dmasound);
+                dev->dmasound.priv_data = NULL;
+        }
+
+        /* release resources */
         free_irq(pci_dev->irq, dev);
         iounmap(dev->lmmio);
         release_mem_region(pci_resource_start(pci_dev,0),
@@ -1225,7 +1166,7 @@ EXPORT_SYMBOL(saa7134_i2c_call_clients);
 EXPORT_SYMBOL(saa7134_devlist);
 EXPORT_SYMBOL(saa7134_boards);
 
-/* ----------------- For ALSA -------------------------------- */
+/* ----------------- for the DMA sound modules --------------- */
 
 EXPORT_SYMBOL(saa7134_pgtable_free);
 EXPORT_SYMBOL(saa7134_pgtable_build);
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index 329accda6d45..e648cc3bc96d 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -485,64 +485,6 @@ static IR_KEYTAB_TYPE ir_codes_purpletv[IR_KEYTAB_SIZE] = {
 
 };
 
-static IR_KEYTAB_TYPE ir_codes_pinnacle[IR_KEYTAB_SIZE] = {
-        [ 0x59 ] = KEY_MUTE,
-        [ 0x4a ] = KEY_POWER,
-
-        [ 0x18 ] = KEY_TEXT,
-        [ 0x26 ] = KEY_TV,
-        [ 0x3d ] = KEY_PRINT,
-
-        [ 0x48 ] = KEY_RED,
-        [ 0x04 ] = KEY_GREEN,
-        [ 0x11 ] = KEY_YELLOW,
-        [ 0x00 ] = KEY_BLUE,
-
-        [ 0x2d ] = KEY_VOLUMEUP,
-        [ 0x1e ] = KEY_VOLUMEDOWN,
-
-        [ 0x49 ] = KEY_MENU,
-
-        [ 0x16 ] = KEY_CHANNELUP,
-        [ 0x17 ] = KEY_CHANNELDOWN,
-
-        [ 0x20 ] = KEY_UP,
-        [ 0x21 ] = KEY_DOWN,
-        [ 0x22 ] = KEY_LEFT,
-        [ 0x23 ] = KEY_RIGHT,
-        [ 0x0d ] = KEY_SELECT,
-
-
-
-        [ 0x08 ] = KEY_BACK,
-        [ 0x07 ] = KEY_REFRESH,
-
-        [ 0x2f ] = KEY_ZOOM,
-        [ 0x29 ] = KEY_RECORD,
-
-        [ 0x4b ] = KEY_PAUSE,
-        [ 0x4d ] = KEY_REWIND,
-        [ 0x2e ] = KEY_PLAY,
-        [ 0x4e ] = KEY_FORWARD,
-        [ 0x53 ] = KEY_PREVIOUS,
-        [ 0x4c ] = KEY_STOP,
-        [ 0x54 ] = KEY_NEXT,
-
-        [ 0x69 ] = KEY_KP0,
-        [ 0x6a ] = KEY_KP1,
-        [ 0x6b ] = KEY_KP2,
-        [ 0x6c ] = KEY_KP3,
-        [ 0x6d ] = KEY_KP4,
-        [ 0x6e ] = KEY_KP5,
-        [ 0x6f ] = KEY_KP6,
-        [ 0x70 ] = KEY_KP7,
-        [ 0x71 ] = KEY_KP8,
-        [ 0x72 ] = KEY_KP9,
-
-        [ 0x74 ] = KEY_CHANNEL,
-        [ 0x0a ] = KEY_BACKSPACE,
-};
-
 /* Mapping for the 28 key remote control as seen at
    http://www.sednacomputer.com/photo/cardbus-tv.jpg
    Pavel Mihaylov <bin@bash.info> */
@@ -635,57 +577,6 @@ static int get_key_purpletv(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
         return 1;
 }
 
-/* The new pinnacle PCTV remote (with the colored buttons)
- *
- * Ricardo Cerqueira <v4l@cerqueira.org>
- */
-
-static int get_key_pinnacle(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
-{
-        unsigned char b[4];
-        unsigned int start = 0,parity = 0,code = 0;
-
-        /* poll IR chip */
-        if (4 != i2c_master_recv(&ir->c,b,4)) {
-                i2cdprintk("read error\n");
-                return -EIO;
-        }
-
-        for (start = 0; start<4; start++) {
-                if (b[start] == 0x80) {
-                        code=b[(start+3)%4];
-                        parity=b[(start+2)%4];
-                }
-        }
-
-        /* Empty Request */
-        if (parity==0)
-                return 0;
-
-        /* Repeating... */
-        if (ir->old == parity)
-                return 0;
-
-
-        ir->old = parity;
-
-        /* Reduce code value to fit inside IR_KEYTAB_SIZE
-         *
-         * this is the only value that results in 42 unique
-         * codes < 128
-         */
-
-        code %= 0x88;
-
-        *ir_raw = code;
-        *ir_key = code;
-
-        i2cdprintk("Pinnacle PCTV key %02x\n", code);
-
-        return 1;
-}
-
-
 void saa7134_input_irq(struct saa7134_dev *dev)
 {
         struct saa7134_ir *ir = dev->remote;
diff --git a/drivers/media/video/saa7134/saa7134-oss.c b/drivers/media/video/saa7134/saa7134-oss.c
index fd53dfcc1644..fd9ed11ab1e2 100644
--- a/drivers/media/video/saa7134/saa7134-oss.c
+++ b/drivers/media/video/saa7134/saa7134-oss.c
@@ -4,6 +4,8 @@
  * oss dsp interface
  *
  * (c) 2001,02 Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]
+ *     2005 conversion to standalone module:
+ *         Ricardo Cerqueira <v4l@cerqueira.org>
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -25,7 +27,9 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/kernel.h>
+#include <linux/interrupt.h>
 #include <linux/slab.h>
+#include <linux/sound.h>
 #include <linux/soundcard.h>
 
 #include "saa7134-reg.h"
@@ -33,15 +37,23 @@
 
 /* ------------------------------------------------------------------ */
 
-static unsigned int oss_debug  = 0;
-module_param(oss_debug, int, 0644);
-MODULE_PARM_DESC(oss_debug,"enable debug messages [oss]");
+static unsigned int debug  = 0;
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug,"enable debug messages [oss]");
 
-static unsigned int oss_rate  = 0;
-module_param(oss_rate, int, 0444);
-MODULE_PARM_DESC(oss_rate,"sample rate (valid are: 32000,48000)");
+static unsigned int rate  = 0;
+module_param(rate, int, 0444);
+MODULE_PARM_DESC(rate,"sample rate (valid are: 32000,48000)");
 
-#define dprintk(fmt, arg...)    if (oss_debug) \
+static unsigned int dsp_nr[]   = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
+MODULE_PARM_DESC(dsp_nr, "device numbers for SAA7134 capture interface(s).");
+module_param_array(dsp_nr,   int, NULL, 0444);
+
+static unsigned int mixer_nr[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
+MODULE_PARM_DESC(mixer_nr, "mixer numbers for SAA7134 capture interface(s).");
+module_param_array(mixer_nr, int, NULL, 0444);
+
+#define dprintk(fmt, arg...)    if (debug) \
         printk(KERN_DEBUG "%s/oss: " fmt, dev->name , ## arg)
 
 
@@ -369,7 +381,7 @@ static int dsp_ioctl(struct inode *inode, struct file *file,
         int __user *p = argp;
         int val = 0;
 
-        if (oss_debug > 1)
+        if (debug > 1)
                 saa7134_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case OSS_GETVERSION:
@@ -665,7 +677,7 @@ static int mixer_ioctl(struct inode *inode, struct file *file,
         void __user *argp = (void __user *) arg;
         int __user *p = argp;
 
-        if (oss_debug > 1)
+        if (debug > 1)
                 saa7134_print_ioctl(dev->name,cmd);
         switch (cmd) {
         case OSS_GETVERSION:
@@ -768,8 +780,41 @@ struct file_operations saa7134_mixer_fops = {
 
 /* ------------------------------------------------------------------ */
 
+static irqreturn_t saa7134_oss_irq(int irq, void *dev_id, struct pt_regs *regs)
+{
+        struct saa7134_dmasound *dmasound = dev_id;
+        struct saa7134_dev *dev = dmasound->priv_data;
+        unsigned long report, status;
+        int loop, handled = 0;
+
+        for (loop = 0; loop < 10; loop++) {
+                report = saa_readl(SAA7134_IRQ_REPORT);
+                status = saa_readl(SAA7134_IRQ_STATUS);
+
+                if (report & SAA7134_IRQ_REPORT_DONE_RA3) {
+                        handled = 1;
+                        saa_writel(SAA7134_IRQ_REPORT,report);
+                        saa7134_irq_oss_done(dev, status);
+                } else {
+                        goto out;
+                }
+        }
+
+        if (loop == 10) {
+                dprintk("error! looping IRQ!");
+        }
+out:
+        return IRQ_RETVAL(handled);
+}
+
 int saa7134_oss_init1(struct saa7134_dev *dev)
 {
+
+        if ((request_irq(dev->pci->irq, saa7134_oss_irq,
+                         SA_SHIRQ | SA_INTERRUPT, dev->name,
+                        (void*) &dev->dmasound)) < 0)
+                return -1;
+
         /* general */
         init_MUTEX(&dev->dmasound.lock);
         init_waitqueue_head(&dev->dmasound.wq);
@@ -785,8 +830,8 @@ int saa7134_oss_init1(struct saa7134_dev *dev)
 
         /* dsp */
         dev->dmasound.rate = 32000;
-        if (oss_rate)
-                dev->dmasound.rate = oss_rate;
+        if (rate)
+                dev->dmasound.rate = rate;
         dev->dmasound.rate = (dev->dmasound.rate > 40000) ? 48000 : 32000;
 
         /* mixer */
@@ -840,7 +885,7 @@ void saa7134_irq_oss_done(struct saa7134_dev *dev, unsigned long status)
         /* next block addr */
         next_blk = (dev->dmasound.dma_blk + 2) % dev->dmasound.blocks;
         saa_writel(reg,next_blk * dev->dmasound.blksize);
-        if (oss_debug > 2)
+        if (debug > 2)
                 dprintk("irq: ok, %s, next_blk=%d, addr=%x\n",
                         (status & 0x10000000) ? "even" : "odd ", next_blk,
                         next_blk * dev->dmasound.blksize);
@@ -854,6 +899,98 @@ void saa7134_irq_oss_done(struct saa7134_dev *dev, unsigned long status)
         spin_unlock(&dev->slock);
 }
 
+int saa7134_dsp_create(struct saa7134_dev *dev)
+{
+        int err;
+
+                        err = dev->dmasound.minor_dsp =
+                                register_sound_dsp(&saa7134_dsp_fops,
+                                                   dsp_nr[dev->nr]);
+                        if (err < 0) {
+                                goto fail;
+                        }
+                        printk(KERN_INFO "%s: registered device dsp%d\n",
+                               dev->name,dev->dmasound.minor_dsp >> 4);
+
+                        err = dev->dmasound.minor_mixer =
+                                register_sound_mixer(&saa7134_mixer_fops,
+                                                     mixer_nr[dev->nr]);
+                        if (err < 0)
+                                goto fail;
+                        printk(KERN_INFO "%s: registered device mixer%d\n",
+                               dev->name,dev->dmasound.minor_mixer >> 4);
+
+        return 0;
+
+fail:
+        unregister_sound_dsp(dev->dmasound.minor_dsp);
+        return 0;
+
+
+}
+
+static int saa7134_oss_init(void)
+{
+        struct saa7134_dev *dev = NULL;
+        struct list_head *list;
+
+        printk(KERN_INFO "saa7134 OSS driver for DMA sound loaded\n");
+
+        list_for_each(list,&saa7134_devlist) {
+                dev = list_entry(list, struct saa7134_dev, devlist);
+                if (dev->dmasound.priv_data == NULL) {
+                        dev->dmasound.priv_data = dev;
+                        saa7134_oss_init1(dev);
+                        saa7134_dsp_create(dev);
+                } else {
+                        printk(KERN_ERR "saa7134 OSS: DMA sound is being handled by ALSA, ignoring %s\n",dev->name);
+                        return -EBUSY;
+                }
+        }
+
+        if (dev == NULL)
+                printk(KERN_INFO "saa7134 OSS: no saa7134 cards found\n");
+
+        return 0;
+
+}
+
+void saa7134_oss_exit(void)
+{
+        struct saa7134_dev *dev = NULL;
+        struct list_head *list;
+
+        list_for_each(list,&saa7134_devlist) {
+                dev = list_entry(list, struct saa7134_dev, devlist);
+
+                /* Device isn't registered by OSS, probably ALSA's */
+                if (!dev->dmasound.minor_dsp)
+                        continue;
+
+                unregister_sound_mixer(dev->dmasound.minor_mixer);
+                unregister_sound_dsp(dev->dmasound.minor_dsp);
+
+                saa7134_oss_fini(dev);
+
+                if (dev->pci->irq > 0) {
+                        synchronize_irq(dev->pci->irq);
+                        free_irq(dev->pci->irq,&dev->dmasound);
+                }
+
+                dev->dmasound.priv_data = NULL;
+
+        }
+
+        printk(KERN_INFO "saa7134 OSS driver for DMA sound unloaded\n");
+
+        return;
+}
+
+module_init(saa7134_oss_init);
+module_exit(saa7134_oss_exit);
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
+
 /* ----------------------------------------------------------- */
 /*
  * Local variables:
diff --git a/drivers/media/video/saa7134/saa7134.h b/drivers/media/video/saa7134/saa7134.h
index fb9727471661..244e1973081c 100644
--- a/drivers/media/video/saa7134/saa7134.h
+++ b/drivers/media/video/saa7134/saa7134.h
@@ -208,6 +208,7 @@ struct saa7134_format {
 #define SAA7134_BOARD_SEDNA_PC_TV_CARDBUS     79
 #define SAA7134_BOARD_ASUSTEK_DIGIMATRIX_TV 80
 #define SAA7134_BOARD_PHILIPS_TIGER  81
+#define SAA7134_BOARD_MSI_TVATANYWHERE_PLUS  82
 
 #define SAA7134_MAXBOARDS 8
 #define SAA7134_INPUT_MAX 8
@@ -383,6 +384,7 @@ struct saa7134_dmasound {
         unsigned int               dma_blk;
         unsigned int               read_offset;
         unsigned int               read_count;
+        void *                     priv_data;
         snd_pcm_substream_t        *substream;
 };
 
diff --git a/drivers/media/video/tda8290.c b/drivers/media/video/tda8290.c
index b2dfe07e9f9d..61d94ddaff41 100644
--- a/drivers/media/video/tda8290.c
+++ b/drivers/media/video/tda8290.c
@@ -437,6 +437,10 @@ static void set_audio(struct tuner *t)
                 t->sgIF = 124;
                 t->tda8290_easy_mode = 0x20;
                 mode = "L";
+        } else if (t->std & V4L2_STD_SECAM_LC) {
+                t->sgIF = 20;
+                t->tda8290_easy_mode = 0x40;
+                mode = "LC";
         }
     tuner_dbg("setting tda8290 to system %s\n", mode);
 }
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 73c4041c35d7..e58abdfcaab8 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -251,7 +251,7 @@ static inline int check_mode(struct tuner *t, char *cmd)
 
 static char pal[] = "-";
 module_param_string(pal, pal, sizeof(pal), 0644);
-static char secam[] = "-";
+static char secam[] = "--";
 module_param_string(secam, secam, sizeof(secam), 0644);
 
 /* get more precise norm info from insmod option */
@@ -307,8 +307,13 @@ static int tuner_fixup_std(struct tuner *t)
                         break;
                 case 'l':
                 case 'L':
-                        tuner_dbg ("insmod fixup: SECAM => SECAM-L\n");
-                        t->std = V4L2_STD_SECAM_L;
+                        if ((secam[1]=='C')||(secam[1]=='c')) {
+                                tuner_dbg ("insmod fixup: SECAM => SECAM-L'\n");
+                                t->std = V4L2_STD_SECAM_LC;
+                        } else {
+                                tuner_dbg ("insmod fixup: SECAM => SECAM-L\n");
+                                t->std = V4L2_STD_SECAM_L;
+                        }
                         break;
                 case '-':
                         /* default parameter, do nothing */
diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c
index d832205818f2..e0c9fdb9914a 100644
--- a/drivers/media/video/tuner-simple.c
+++ b/drivers/media/video/tuner-simple.c
@@ -233,7 +233,7 @@ static struct tunertype tuners[] = {
         { "Ymec TVision TVF-5533MF", Philips, NTSC,
           16*160.00,16*454.00,0x01,0x02,0x04,0x8e,732},
 
-        /* 60-68 */
+        /* 60-69 */
         { "Thomson DDT 7611 (ATSC/NTSC)", THOMSON, ATSC,
           16*157.25,16*454.00,0x39,0x3a,0x3c,0x8e,732},
         { "Tena TNF9533-D/IF/TNF9533-B/DF", Philips, PAL,
@@ -252,6 +252,8 @@ static struct tunertype tuners[] = {
           16*160.00,16*442.00,0xa1,0xa2,0xa4,0xc8,623 },
         { "Philips TUV1236D ATSC/NTSC dual in", Philips, ATSC,
           16*157.25,16*454.00,0x01,0x02,0x04,0xce,732 },
+        { "Tena TNF 5335 MF", Philips, NTSC,
+          16*157.25,16*454.00,0x01,0x02,0x04,0x8e,732 },
 };
 
 unsigned const int tuner_count = ARRAY_SIZE(tuners);
diff --git a/drivers/media/video/wm8775.c b/drivers/media/video/wm8775.c
index 22f286222004..a6936ad74fcf 100644
--- a/drivers/media/video/wm8775.c
+++ b/drivers/media/video/wm8775.c
@@ -5,6 +5,11 @@
  *
  * Based on saa7115 driver
  *
+ * Copyright (C) 2005 Hans Verkuil <hverkuil@xs4all.nl>
+ * - Cleanup
+ * - V4L2 API update
+ * - sound fixes
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
@@ -31,7 +36,7 @@
 #include <media/audiochip.h>
 
 MODULE_DESCRIPTION("wm8775 driver");
-MODULE_AUTHOR("Ulf Eklund");
+MODULE_AUTHOR("Ulf Eklund, Hans Verkuil");
 MODULE_LICENSE("GPL");
 
 #define wm8775_err(fmt, arg...) do { \
diff --git a/drivers/mmc/mmci.c b/drivers/mmc/mmci.c
index 1e6bdba26756..166c9b0ad04e 100644
--- a/drivers/mmc/mmci.c
+++ b/drivers/mmc/mmci.c
@@ -22,7 +22,6 @@
 
 #include <asm/div64.h>
 #include <asm/io.h>
-#include <asm/irq.h>
 #include <asm/scatterlist.h>
 #include <asm/sizes.h>
 #include <asm/hardware/amba.h>
diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
index 48638c8097a5..846a533323a8 100644
--- a/drivers/mtd/maps/Kconfig
+++ b/drivers/mtd/maps/Kconfig
@@ -94,7 +94,7 @@ config MTD_NETSC520
 
 config MTD_TS5500
         tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
-        depends on ELAN
+        depends on X86
         select MTD_PARTITIONS
         select MTD_JEDECPROBE
         select MTD_CFI_AMDSTD
diff --git a/drivers/net/3c509.c b/drivers/net/3c509.c
index 977935a3d898..824e430486c2 100644
--- a/drivers/net/3c509.c
+++ b/drivers/net/3c509.c
@@ -84,6 +84,7 @@ static int max_interrupt_work = 10;
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/pm.h>
+#include <linux/pm_legacy.h>
 #include <linux/skbuff.h>
 #include <linux/delay.h>        /* for udelay() */
 #include <linux/spinlock.h>
@@ -173,7 +174,7 @@ struct el3_private {
         /* skb send-queue */
         int head, size;
         struct sk_buff *queue[SKB_QUEUE_SIZE];
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
         struct pm_dev *pmdev;
 #endif
         enum {
@@ -200,7 +201,7 @@ static void el3_tx_timeout (struct net_device *dev);
 static void el3_down(struct net_device *dev);
 static void el3_up(struct net_device *dev);
 static struct ethtool_ops ethtool_ops;
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
 static int el3_suspend(struct pm_dev *pdev);
 static int el3_resume(struct pm_dev *pdev);
 static int el3_pm_callback(struct pm_dev *pdev, pm_request_t rqst, void *data);
@@ -361,7 +362,7 @@ static void el3_common_remove (struct net_device *dev)
         struct el3_private *lp = netdev_priv(dev);
 
         (void) lp;                              /* Keep gcc quiet... */
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
         if (lp->pmdev)
                 pm_unregister(lp->pmdev);
 #endif
@@ -571,7 +572,7 @@ no_pnp:
         if (err)
                 goto out1;
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
         /* register power management */
         lp->pmdev = pm_register(PM_ISA_DEV, card_idx, el3_pm_callback);
         if (lp->pmdev) {
@@ -1479,7 +1480,7 @@ el3_up(struct net_device *dev)
 }
 
 /* Power Management support functions */
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
 
 static int
 el3_suspend(struct pm_dev *pdev)
@@ -1548,7 +1549,7 @@ el3_pm_callback(struct pm_dev *pdev, pm_request_t rqst, void *data)
         return 0;
 }
 
-#endif /* CONFIG_PM */
+#endif /* CONFIG_PM_LEGACY */
 
 /* Parameters that may be passed into the module. */
 static int debug = -1;
diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index 30bee11c48bd..d2102a27d307 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c
@@ -586,16 +586,16 @@ struct rtl8139_private {
         dma_addr_t tx_bufs_dma;
         signed char phys[4];            /* MII device addresses. */
         char twistie, twist_row, twist_col;     /* Twister tune state. */
-        unsigned int default_port:4;    /* Last dev->if_port value. */
+        unsigned int default_port : 4;  /* Last dev->if_port value. */
+        unsigned int have_thread : 1;
         spinlock_t lock;
         spinlock_t rx_lock;
         chip_t chipset;
-        pid_t thr_pid;
-        wait_queue_head_t thr_wait;
-        struct completion thr_exited;
         u32 rx_config;
         struct rtl_extra_stats xstats;
-        int time_to_die;
+
+        struct work_struct thread;
+
         struct mii_if_info mii;
         unsigned int regs_len;
         unsigned long fifo_copy_timeout;
@@ -620,7 +620,7 @@ static int rtl8139_open (struct net_device *dev);
 static int mdio_read (struct net_device *dev, int phy_id, int location);
 static void mdio_write (struct net_device *dev, int phy_id, int location,
                         int val);
-static void rtl8139_start_thread(struct net_device *dev);
+static void rtl8139_start_thread(struct rtl8139_private *tp);
 static void rtl8139_tx_timeout (struct net_device *dev);
 static void rtl8139_init_ring (struct net_device *dev);
 static int rtl8139_start_xmit (struct sk_buff *skb,
@@ -637,6 +637,7 @@ static struct net_device_stats *rtl8139_get_stats (struct net_device *dev);
 static void rtl8139_set_rx_mode (struct net_device *dev);
 static void __set_rx_mode (struct net_device *dev);
 static void rtl8139_hw_start (struct net_device *dev);
+static void rtl8139_thread (void *_data);
 static struct ethtool_ops rtl8139_ethtool_ops;
 
 /* write MMIO register, with flush */
@@ -1007,8 +1008,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
                 (debug < 0 ? RTL8139_DEF_MSG_ENABLE : ((1 << debug) - 1));
         spin_lock_init (&tp->lock);
         spin_lock_init (&tp->rx_lock);
-        init_waitqueue_head (&tp->thr_wait);
-        init_completion (&tp->thr_exited);
+        INIT_WORK(&tp->thread, rtl8139_thread, dev);
         tp->mii.dev = dev;
         tp->mii.mdio_read = mdio_read;
         tp->mii.mdio_write = mdio_write;
@@ -1345,7 +1345,7 @@ static int rtl8139_open (struct net_device *dev)
                         dev->irq, RTL_R8 (MediaStatus),
                         tp->mii.full_duplex ? "full" : "half");
 
-        rtl8139_start_thread(dev);
+        rtl8139_start_thread(tp);
 
         return 0;
 }
@@ -1594,55 +1594,43 @@ static inline void rtl8139_thread_iter (struct net_device *dev,
                  RTL_R8 (Config1));
 }
 
-static int rtl8139_thread (void *data)
+static void rtl8139_thread (void *_data)
 {
-        struct net_device *dev = data;
+        struct net_device *dev = _data;
         struct rtl8139_private *tp = netdev_priv(dev);
-        unsigned long timeout;
-
-        daemonize("%s", dev->name);
-        allow_signal(SIGTERM);
-
-        while (1) {
-                timeout = next_tick;
-                do {
-                        timeout = interruptible_sleep_on_timeout (&tp->thr_wait, timeout);
-                        /* make swsusp happy with our thread */
-                        try_to_freeze();
-                } while (!signal_pending (current) && (timeout > 0));
-
-                if (signal_pending (current)) {
-                        flush_signals(current);
-                }
+        unsigned long thr_delay;
 
-                if (tp->time_to_die)
-                        break;
-
-                if (rtnl_lock_interruptible ())
-                        break;
+        if (rtnl_shlock_nowait() == 0) {
                 rtl8139_thread_iter (dev, tp, tp->mmio_addr);
                 rtnl_unlock ();
+
+                thr_delay = next_tick;
+        } else {
+                /* unlikely race.  mitigate with fast poll. */
+                thr_delay = HZ / 2;
         }
 
-        complete_and_exit (&tp->thr_exited, 0);
+        schedule_delayed_work(&tp->thread, thr_delay);
 }
 
-static void rtl8139_start_thread(struct net_device *dev)
+static void rtl8139_start_thread(struct rtl8139_private *tp)
 {
-        struct rtl8139_private *tp = netdev_priv(dev);
-
-        tp->thr_pid = -1;
         tp->twistie = 0;
-        tp->time_to_die = 0;
         if (tp->chipset == CH_8139_K)
                 tp->twistie = 1;
         else if (tp->drv_flags & HAS_LNK_CHNG)
                 return;
 
-        tp->thr_pid = kernel_thread(rtl8139_thread, dev, CLONE_FS|CLONE_FILES);
-        if (tp->thr_pid < 0) {
-                printk (KERN_WARNING "%s: unable to start kernel thread\n",
-                        dev->name);
+        tp->have_thread = 1;
+
+        schedule_delayed_work(&tp->thread, next_tick);
+}
+
+static void rtl8139_stop_thread(struct rtl8139_private *tp)
+{
+        if (tp->have_thread) {
+                cancel_rearming_delayed_work(&tp->thread);
+                tp->have_thread = 0;
         }
 }
 
@@ -2224,22 +2212,12 @@ static int rtl8139_close (struct net_device *dev)
 {
         struct rtl8139_private *tp = netdev_priv(dev);
         void __iomem *ioaddr = tp->mmio_addr;
-        int ret = 0;
         unsigned long flags;
 
         netif_stop_queue (dev);
 
-        if (tp->thr_pid >= 0) {
-                tp->time_to_die = 1;
-                wmb();
-                ret = kill_proc (tp->thr_pid, SIGTERM, 1);
-                if (ret) {
-                        printk (KERN_ERR "%s: unable to signal thread\n", dev->name);
-                        return ret;
-                }
-                wait_for_completion (&tp->thr_exited);
-        }
-        
+        rtl8139_stop_thread(tp);
+
         if (netif_msg_ifdown(tp))
                 printk(KERN_DEBUG "%s: Shutting down ethercard, status was 0x%4.4x.\n",
                         dev->name, RTL_R16 (IntrStatus));
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index ebd7313d7fc1..39415b5c4569 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2008,7 +2008,25 @@ config SKGE
 
           It does not support the link failover and network management 
           features that "portable" vendor supplied sk98lin driver does.
-        
+
+
+config SKY2
+        tristate "SysKonnect Yukon2 support (EXPERIMENTAL)"
+        depends on PCI && EXPERIMENTAL
+        select CRC32
+        ---help---
+          This driver support the Marvell Yukon 2 Gigabit Ethernet adapter.
+
+          To compile this driver as a module, choose M here: the module
+          will be called sky2.  This is recommended.
+
+config SKY2_EC_A1
+        bool "Support old Yukon-EC A1 chipset"
+        depends on SKY2
+        ---help---
+          Include support for early revisions of the Yukon EC chipset
+          that required extra workarounds. If in doubt, say N.
+
 config SK98LIN
         tristate "Marvell Yukon Chipset / SysKonnect SK-98xx Support"
         depends on PCI
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 4cffd34442aa..27822a2f0683 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -59,6 +59,7 @@ spidernet-y += spider_net.o spider_net_ethtool.o sungem_phy.o
 obj-$(CONFIG_SPIDER_NET) += spidernet.o
 obj-$(CONFIG_TC35815) += tc35815.o
 obj-$(CONFIG_SKGE) += skge.o
+obj-$(CONFIG_SKY2) += sky2.o
 obj-$(CONFIG_SK98LIN) += sk98lin/
 obj-$(CONFIG_SKFP) += skfp/
 obj-$(CONFIG_VIA_RHINE) += via-rhine.o
diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile
index cf50384b469e..5cdae2bc055a 100644
--- a/drivers/net/bonding/Makefile
+++ b/drivers/net/bonding/Makefile
@@ -4,5 +4,5 @@
 
 obj-$(CONFIG_BONDING) += bonding.o
 
-bonding-objs := bond_main.o bond_3ad.o bond_alb.o
+bonding-objs := bond_main.o bond_3ad.o bond_alb.o bond_sysfs.o
 
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index d2f34d5a8083..04705233ca0b 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1198,10 +1198,10 @@ static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port)
                         // detect loopback situation
                         if (!MAC_ADDRESS_COMPARE(&(lacpdu->actor_system), &(port->actor_system))) {
                                 // INFO_RECEIVED_LOOPBACK_FRAMES
-                                printk(KERN_ERR DRV_NAME ": An illegal loopback occurred on adapter (%s)\n",
-                                                port->slave->dev->name);
-                                printk(KERN_ERR "Check the configuration to verify that all Adapters "
-                                                "are connected to 802.3ad compliant switch ports\n");
+                                printk(KERN_ERR DRV_NAME ": %s: An illegal loopback occurred on "
+                                       "adapter (%s). Check the configuration to verify that all "
+                                       "Adapters are connected to 802.3ad compliant switch ports\n",
+                                       port->slave->dev->master->name, port->slave->dev->name);
                                 __release_rx_machine_lock(port);
                                 return;
                         }
@@ -1378,8 +1378,9 @@ static void ad_port_selection_logic(struct port *port)
                         }
                 }
                 if (!curr_port) { // meaning: the port was related to an aggregator but was not on the aggregator port list
-                        printk(KERN_WARNING DRV_NAME ": Warning: Port %d (on %s) was "
+                        printk(KERN_WARNING DRV_NAME ": %s: Warning: Port %d (on %s) was "
                                "related to aggregator %d but was not on its port list\n",
+                               port->slave->dev->master->name,
                                port->actor_port_number, port->slave->dev->name,
                                port->aggregator->aggregator_identifier);
                 }
@@ -1450,7 +1451,8 @@ static void ad_port_selection_logic(struct port *port)
 
                         dprintk("Port %d joined LAG %d(new LAG)\n", port->actor_port_number, port->aggregator->aggregator_identifier);
                 } else {
-                        printk(KERN_ERR DRV_NAME ": Port %d (on %s) did not find a suitable aggregator\n",
+                        printk(KERN_ERR DRV_NAME ": %s: Port %d (on %s) did not find a suitable aggregator\n",
+                               port->slave->dev->master->name,
                                port->actor_port_number, port->slave->dev->name);
                 }
         }
@@ -1582,8 +1584,9 @@ static void ad_agg_selection_logic(struct aggregator *aggregator)
 
                 // check if any partner replys
                 if (best_aggregator->is_individual) {
-                        printk(KERN_WARNING DRV_NAME ": Warning: No 802.3ad response from the link partner "
-                                        "for any adapters in the bond\n");
+                        printk(KERN_WARNING DRV_NAME ": %s: Warning: No 802.3ad response from "
+                               "the link partner for any adapters in the bond\n",
+                               best_aggregator->slave->dev->master->name);
                 }
 
                 // check if there are more than one aggregator
@@ -1915,7 +1918,8 @@ int bond_3ad_bind_slave(struct slave *slave)
         struct aggregator *aggregator;
 
         if (bond == NULL) {
-                printk(KERN_ERR "The slave %s is not attached to its bond\n", slave->dev->name);
+                printk(KERN_ERR DRV_NAME ": %s: The slave %s is not attached to its bond\n",
+                       slave->dev->master->name, slave->dev->name);
                 return -1;
         }
 
@@ -1990,7 +1994,9 @@ void bond_3ad_unbind_slave(struct slave *slave)
 
         // if slave is null, the whole port is not initialized
         if (!port->slave) {
-                printk(KERN_WARNING DRV_NAME ": Trying to unbind an uninitialized port on %s\n", slave->dev->name);
+                printk(KERN_WARNING DRV_NAME ": Warning: %s: Trying to "
+                       "unbind an uninitialized port on %s\n",
+                       slave->dev->master->name, slave->dev->name);
                 return;
         }
 
@@ -2021,7 +2027,8 @@ void bond_3ad_unbind_slave(struct slave *slave)
                                 dprintk("Some port(s) related to LAG %d - replaceing with LAG %d\n", aggregator->aggregator_identifier, new_aggregator->aggregator_identifier);
 
                                 if ((new_aggregator->lag_ports == port) && new_aggregator->is_active) {
-                                        printk(KERN_INFO DRV_NAME ": Removing an active aggregator\n");
+                                        printk(KERN_INFO DRV_NAME ": %s: Removing an active aggregator\n",
+                                               aggregator->slave->dev->master->name);
                                         // select new active aggregator
                                          select_new_active_agg = 1;
                                 }
@@ -2051,15 +2058,17 @@ void bond_3ad_unbind_slave(struct slave *slave)
                                         ad_agg_selection_logic(__get_first_agg(port));
                                 }
                         } else {
-                                printk(KERN_WARNING DRV_NAME ": Warning: unbinding aggregator, "
-                                       "and could not find a new aggregator for its ports\n");
+                                printk(KERN_WARNING DRV_NAME ": %s: Warning: unbinding aggregator, "
+                                       "and could not find a new aggregator for its ports\n",
+                                       slave->dev->master->name);
                         }
                 } else { // in case that the only port related to this aggregator is the one we want to remove
                         select_new_active_agg = aggregator->is_active;
                         // clear the aggregator
                         ad_clear_agg(aggregator);
                         if (select_new_active_agg) {
-                                printk(KERN_INFO "Removing an active aggregator\n");
+                                printk(KERN_INFO DRV_NAME ": %s: Removing an active aggregator\n",
+                                       slave->dev->master->name);
                                 // select new active aggregator
                                 ad_agg_selection_logic(__get_first_agg(port));
                         }
@@ -2085,7 +2094,8 @@ void bond_3ad_unbind_slave(struct slave *slave)
                                         // clear the aggregator
                                         ad_clear_agg(temp_aggregator);
                                         if (select_new_active_agg) {
-                                                printk(KERN_INFO "Removing an active aggregator\n");
+                                                printk(KERN_INFO DRV_NAME ": %s: Removing an active aggregator\n",
+                                                       slave->dev->master->name);
                                                 // select new active aggregator
                                                 ad_agg_selection_logic(__get_first_agg(port));
                                         }
@@ -2131,7 +2141,8 @@ void bond_3ad_state_machine_handler(struct bonding *bond)
                 // select the active aggregator for the bond
                 if ((port = __get_first_port(bond))) {
                         if (!port->slave) {
-                                printk(KERN_WARNING DRV_NAME ": Warning: bond's first port is uninitialized\n");
+                                printk(KERN_WARNING DRV_NAME ": %s: Warning: bond's first port is "
+                                       "uninitialized\n", bond->dev->name);
                                 goto re_arm;
                         }
 
@@ -2143,7 +2154,8 @@ void bond_3ad_state_machine_handler(struct bonding *bond)
         // for each port run the state machines
         for (port = __get_first_port(bond); port; port = __get_next_port(port)) {
                 if (!port->slave) {
-                        printk(KERN_WARNING DRV_NAME ": Warning: Found an uninitialized port\n");
+                        printk(KERN_WARNING DRV_NAME ": %s: Warning: Found an uninitialized "
+                               "port\n", bond->dev->name);
                         goto re_arm;
                 }
 
@@ -2184,7 +2196,8 @@ static void bond_3ad_rx_indication(struct lacpdu *lacpdu, struct slave *slave, u
                 port = &(SLAVE_AD_INFO(slave).port);
 
                 if (!port->slave) {
-                        printk(KERN_WARNING DRV_NAME ": Warning: port of slave %s is uninitialized\n", slave->dev->name);
+                        printk(KERN_WARNING DRV_NAME ": %s: Warning: port of slave %s is "
+                               "uninitialized\n", slave->dev->name, slave->dev->master->name);
                         return;
                 }
 
@@ -2230,8 +2243,9 @@ void bond_3ad_adapter_speed_changed(struct slave *slave)
 
         // if slave is null, the whole port is not initialized
         if (!port->slave) {
-                printk(KERN_WARNING DRV_NAME ": Warning: speed changed for uninitialized port on %s\n",
-                       slave->dev->name);
+                printk(KERN_WARNING DRV_NAME ": Warning: %s: speed "
+                       "changed for uninitialized port on %s\n",
+                       slave->dev->master->name, slave->dev->name);
                 return;
         }
 
@@ -2257,8 +2271,9 @@ void bond_3ad_adapter_duplex_changed(struct slave *slave)
 
         // if slave is null, the whole port is not initialized
         if (!port->slave) {
-                printk(KERN_WARNING DRV_NAME ": Warning: duplex changed for uninitialized port on %s\n",
-                       slave->dev->name);
+                printk(KERN_WARNING DRV_NAME ": %s: Warning: duplex changed "
+                       "for uninitialized port on %s\n",
+                       slave->dev->master->name, slave->dev->name);
                 return;
         }
 
@@ -2285,8 +2300,9 @@ void bond_3ad_handle_link_change(struct slave *slave, char link)
 
         // if slave is null, the whole port is not initialized
         if (!port->slave) {
-                printk(KERN_WARNING DRV_NAME ": Warning: link status changed for uninitialized port on %s\n",
-                        slave->dev->name);
+                printk(KERN_WARNING DRV_NAME ": Warning: %s: link status changed for "
+                       "uninitialized port on %s\n",
+                        slave->dev->master->name, slave->dev->name);
                 return;
         }
 
@@ -2363,7 +2379,8 @@ int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev)
         }
 
         if (bond_3ad_get_active_agg_info(bond, &ad_info)) {
-                printk(KERN_DEBUG "ERROR: bond_3ad_get_active_agg_info failed\n");
+                printk(KERN_DEBUG DRV_NAME ": %s: Error: "
+                       "bond_3ad_get_active_agg_info failed\n", dev->name);
                 goto out;
         }
 
@@ -2372,7 +2389,9 @@ int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev)
 
         if (slaves_in_agg == 0) {
                 /*the aggregator is empty*/
-                printk(KERN_DEBUG "ERROR: active aggregator is empty\n");
+                printk(KERN_DEBUG DRV_NAME ": %s: Error: active "
+                       "aggregator is empty\n",
+                       dev->name);
                 goto out;
         }
 
@@ -2390,7 +2409,8 @@ int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev)
         }
 
         if (slave_agg_no >= 0) {
-                printk(KERN_ERR DRV_NAME ": Error: Couldn't find a slave to tx on for aggregator ID %d\n", agg_id);
+                printk(KERN_ERR DRV_NAME ": %s: Error: Couldn't find a slave to tx on "
+                       "for aggregator ID %d\n", dev->name, agg_id);
                 goto out;
         }
 
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index f8fce3961197..9bd1e104554a 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -198,20 +198,21 @@ static int tlb_initialize(struct bonding *bond)
 {
         struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
         int size = TLB_HASH_TABLE_SIZE * sizeof(struct tlb_client_info);
+        struct tlb_client_info *new_hashtbl;
         int i;
 
         spin_lock_init(&(bond_info->tx_hashtbl_lock));
 
-        _lock_tx_hashtbl(bond);
-
-        bond_info->tx_hashtbl = kmalloc(size, GFP_KERNEL);
-        if (!bond_info->tx_hashtbl) {
+        new_hashtbl = kmalloc(size, GFP_KERNEL);
+        if (!new_hashtbl) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: %s: Failed to allocate TLB hash table\n",
+                       ": %s: Error: Failed to allocate TLB hash table\n",
                        bond->dev->name);
-                _unlock_tx_hashtbl(bond);
                 return -1;
         }
+        _lock_tx_hashtbl(bond);
+
+        bond_info->tx_hashtbl = new_hashtbl;
 
         memset(bond_info->tx_hashtbl, 0, size);
 
@@ -513,7 +514,8 @@ static void rlb_update_client(struct rlb_client_info *client_info)
                                  client_info->mac_dst);
                 if (!skb) {
                         printk(KERN_ERR DRV_NAME
-                               ": Error: failed to create an ARP packet\n");
+                               ": %s: Error: failed to create an ARP packet\n",
+                               client_info->slave->dev->master->name);
                         continue;
                 }
 
@@ -523,7 +525,8 @@ static void rlb_update_client(struct rlb_client_info *client_info)
                         skb = vlan_put_tag(skb, client_info->vlan_id);
                         if (!skb) {
                                 printk(KERN_ERR DRV_NAME
-                                       ": Error: failed to insert VLAN tag\n");
+                                       ": %s: Error: failed to insert VLAN tag\n",
+                                       client_info->slave->dev->master->name);
                                 continue;
                         }
                 }
@@ -606,8 +609,9 @@ static void rlb_req_update_subnet_clients(struct bonding *bond, u32 src_ip)
 
                 if (!client_info->slave) {
                         printk(KERN_ERR DRV_NAME
-                               ": Error: found a client with no channel in "
-                               "the client's hash table\n");
+                               ": %s: Error: found a client with no channel in "
+                               "the client's hash table\n",
+                               bond->dev->name);
                         continue;
                 }
                 /*update all clients using this src_ip, that are not assigned
@@ -797,21 +801,22 @@ static int rlb_initialize(struct bonding *bond)
 {
         struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
         struct packet_type *pk_type = &(BOND_ALB_INFO(bond).rlb_pkt_type);
+        struct rlb_client_info  *new_hashtbl;
         int size = RLB_HASH_TABLE_SIZE * sizeof(struct rlb_client_info);
         int i;
 
         spin_lock_init(&(bond_info->rx_hashtbl_lock));
 
-        _lock_rx_hashtbl(bond);
-
-        bond_info->rx_hashtbl = kmalloc(size, GFP_KERNEL);
-        if (!bond_info->rx_hashtbl) {
+        new_hashtbl = kmalloc(size, GFP_KERNEL);
+        if (!new_hashtbl) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: %s: Failed to allocate RLB hash table\n",
+                       ": %s: Error: Failed to allocate RLB hash table\n",
                        bond->dev->name);
-                _unlock_rx_hashtbl(bond);
                 return -1;
         }
+        _lock_rx_hashtbl(bond);
+
+        bond_info->rx_hashtbl = new_hashtbl;
 
         bond_info->rx_hashtbl_head = RLB_NULL_INDEX;
 
@@ -927,7 +932,8 @@ static void alb_send_learning_packets(struct slave *slave, u8 mac_addr[])
                         skb = vlan_put_tag(skb, vlan->vlan_id);
                         if (!skb) {
                                 printk(KERN_ERR DRV_NAME
-                                       ": Error: failed to insert VLAN tag\n");
+                                       ": %s: Error: failed to insert VLAN tag\n",
+                                       bond->dev->name);
                                 continue;
                         }
                 }
@@ -956,11 +962,11 @@ static int alb_set_slave_mac_addr(struct slave *slave, u8 addr[], int hw)
         s_addr.sa_family = dev->type;
         if (dev_set_mac_address(dev, &s_addr)) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: dev_set_mac_address of dev %s failed! ALB "
+                       ": %s: Error: dev_set_mac_address of dev %s failed! ALB "
                        "mode requires that the base driver support setting "
                        "the hw address also when the network device's "
                        "interface is open\n",
-                       dev->name);
+                       dev->master->name, dev->name);
                 return -EOPNOTSUPP;
         }
         return 0;
@@ -1153,16 +1159,16 @@ static int alb_handle_addr_collision_on_attach(struct bonding *bond, struct slav
                                        bond->alb_info.rlb_enabled);
 
                 printk(KERN_WARNING DRV_NAME
-                       ": Warning: the hw address of slave %s is in use by "
+                       ": %s: Warning: the hw address of slave %s is in use by "
                        "the bond; giving it the hw address of %s\n",
-                       slave->dev->name, free_mac_slave->dev->name);
+                       bond->dev->name, slave->dev->name, free_mac_slave->dev->name);
 
         } else if (has_bond_addr) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: the hw address of slave %s is in use by the "
+                       ": %s: Error: the hw address of slave %s is in use by the "
                        "bond; couldn't find a slave with a free hw address to "
                        "give it (this should not have happened)\n",
-                       slave->dev->name);
+                       bond->dev->name, slave->dev->name);
                 return -EFAULT;
         }
 
@@ -1250,6 +1256,8 @@ int bond_alb_initialize(struct bonding *bond, int rlb_enabled)
                         tlb_deinitialize(bond);
                         return res;
                 }
+        } else {
+                bond->alb_info.rlb_enabled = 0;
         }
 
         return 0;
@@ -1409,7 +1417,7 @@ void bond_alb_monitor(struct bonding *bond)
                 read_lock(&bond->curr_slave_lock);
 
                 bond_for_each_slave(bond, slave, i) {
-                        alb_send_learning_packets(slave,slave->dev->dev_addr);
+                        alb_send_learning_packets(slave, slave->dev->dev_addr);
                 }
 
                 read_unlock(&bond->curr_slave_lock);
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 94cec3cf2a13..40ff79175c4a 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -489,6 +489,28 @@
  *        Set version to 2.6.3.
  * 2005/09/26 - Jay Vosburgh <fubar@us.ibm.com>
  *      - Removed backwards compatibility for old ifenslaves.  Version 2.6.4.
+ * 2005/09/27 - Mitch Williams <mitch.a.williams at intel dot com>
+ *      - Radheka Godse <radheka.godse at intel dot com>
+ *      - Split out bond creation code to allow for sysfs interface.
+ *      - Removed static declaration on some functions and data items.
+ *      - Added sysfs support, including capability to add/remove/change
+ *         any bond at runtime.
+ *
+ *      - Miscellaneous:
+ *      - Added bonding: <bondname>: prefix to sysfs log messages
+ *      - Added arp_ip_targets to /proc entry
+ *      - Allow ARP target table to have empty entries
+ *      - trivial fix: added missing modes description to modinfo
+ *      - Corrected bug in ALB init where kmalloc is called inside
+ *        a held lock
+ *      - Corrected behavior to maintain bond link when changing
+ *        from arp monitor to miimon and vice versa
+ *      - Added missing bonding: <bondname>: prefix to alb, ad log messages
+ *      - Fixed stack dump warnings seen if changing between miimon
+ *        and arp monitoring when the bond interface is down.
+ *      - Fixed stack dump warnings seen when enslaving an e100
+ *        driver
+ *      - Set version to 3.0.0
  */
 
 //#define BONDING_DEBUG 1
@@ -557,6 +579,7 @@ static char *lacp_rate	= NULL;
 static char *xmit_hash_policy = NULL;
 static int arp_interval = BOND_LINK_ARP_INTERV;
 static char *arp_ip_target[BOND_MAX_ARP_TARGETS] = { NULL, };
+struct bond_params bonding_defaults;
 
 module_param(max_bonds, int, 0);
 MODULE_PARM_DESC(max_bonds, "Max number of bonded devices");
@@ -565,17 +588,24 @@ MODULE_PARM_DESC(miimon, "Link check interval in milliseconds");
 module_param(updelay, int, 0);
 MODULE_PARM_DESC(updelay, "Delay before considering link up, in milliseconds");
 module_param(downdelay, int, 0);
-MODULE_PARM_DESC(downdelay, "Delay before considering link down, in milliseconds");
+MODULE_PARM_DESC(downdelay, "Delay before considering link down, "
+                            "in milliseconds");
 module_param(use_carrier, int, 0);
-MODULE_PARM_DESC(use_carrier, "Use netif_carrier_ok (vs MII ioctls) in miimon; 0 for off, 1 for on (default)");
+MODULE_PARM_DESC(use_carrier, "Use netif_carrier_ok (vs MII ioctls) in miimon; "
+                              "0 for off, 1 for on (default)");
 module_param(mode, charp, 0);
-MODULE_PARM_DESC(mode, "Mode of operation : 0 for round robin, 1 for active-backup, 2 for xor");
+MODULE_PARM_DESC(mode, "Mode of operation : 0 for balance-rr, "
+                       "1 for active-backup, 2 for balance-xor, "
+                       "3 for broadcast, 4 for 802.3ad, 5 for balance-tlb, "
+                       "6 for balance-alb");
 module_param(primary, charp, 0);
 MODULE_PARM_DESC(primary, "Primary network device to use");
 module_param(lacp_rate, charp, 0);
-MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner (slow/fast)");
+MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner "
+                            "(slow/fast)");
 module_param(xmit_hash_policy, charp, 0);
-MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method : 0 for layer 2 (default), 1 for layer 3+4");
+MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)"
+                                   ", 1 for layer 3+4");
 module_param(arp_interval, int, 0);
 MODULE_PARM_DESC(arp_interval, "arp interval in milliseconds");
 module_param_array(arp_ip_target, charp, NULL, 0);
@@ -586,30 +616,27 @@ MODULE_PARM_DESC(arp_ip_target, "arp targets in n.n.n.n form");
 static const char *version =
         DRV_DESCRIPTION ": v" DRV_VERSION " (" DRV_RELDATE ")\n";
 
-static LIST_HEAD(bond_dev_list);
+LIST_HEAD(bond_dev_list);
 
 #ifdef CONFIG_PROC_FS
 static struct proc_dir_entry *bond_proc_dir = NULL;
 #endif
 
+extern struct rw_semaphore bonding_rwsem;
 static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
 static int arp_ip_count = 0;
 static int bond_mode    = BOND_MODE_ROUNDROBIN;
 static int xmit_hashtype= BOND_XMIT_POLICY_LAYER2;
 static int lacp_fast    = 0;
 
-struct bond_parm_tbl {
-        char *modename;
-        int mode;
-};
 
-static struct bond_parm_tbl bond_lacp_tbl[] = {
+struct bond_parm_tbl bond_lacp_tbl[] = {
 {       "slow",         AD_LACP_SLOW},
 {       "fast",         AD_LACP_FAST},
 {       NULL,           -1},
 };
 
-static struct bond_parm_tbl bond_mode_tbl[] = {
+struct bond_parm_tbl bond_mode_tbl[] = {
 {       "balance-rr",           BOND_MODE_ROUNDROBIN},
 {       "active-backup",        BOND_MODE_ACTIVEBACKUP},
 {       "balance-xor",          BOND_MODE_XOR},
@@ -620,7 +647,7 @@ static struct bond_parm_tbl bond_mode_tbl[] = {
 {       NULL,                   -1},
 };
 
-static struct bond_parm_tbl xmit_hashtype_tbl[] = {
+struct bond_parm_tbl xmit_hashtype_tbl[] = {
 {       "layer2",               BOND_XMIT_POLICY_LAYER2},
 {       "layer3+4",             BOND_XMIT_POLICY_LAYER34},
 {       NULL,                   -1},
@@ -628,12 +655,11 @@ static struct bond_parm_tbl xmit_hashtype_tbl[] = {
 
 /*-------------------------- Forward declarations ---------------------------*/
 
-static inline void bond_set_mode_ops(struct bonding *bond, int mode);
 static void bond_send_gratuitous_arp(struct bonding *bond);
 
 /*---------------------------- General routines -----------------------------*/
 
-static const char *bond_mode_name(int mode)
+const char *bond_mode_name(int mode)
 {
         switch (mode) {
         case BOND_MODE_ROUNDROBIN :
@@ -910,7 +936,7 @@ static void bond_vlan_rx_add_vid(struct net_device *bond_dev, uint16_t vid)
         res = bond_add_vlan(bond, vid);
         if (res) {
                 printk(KERN_ERR DRV_NAME
-                       ": %s: Failed to add vlan id %d\n",
+                       ": %s: Error: Failed to add vlan id %d\n",
                        bond_dev->name, vid);
         }
 }
@@ -944,7 +970,7 @@ static void bond_vlan_rx_kill_vid(struct net_device *bond_dev, uint16_t vid)
         res = bond_del_vlan(bond, vid);
         if (res) {
                 printk(KERN_ERR DRV_NAME
-                       ": %s: Failed to remove vlan id %d\n",
+                       ": %s: Error: Failed to remove vlan id %d\n",
                        bond_dev->name, vid);
         }
 }
@@ -1449,7 +1475,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond)
  *
  * Warning: Caller must hold curr_slave_lock for writing.
  */
-static void bond_change_active_slave(struct bonding *bond, struct slave *new_active)
+void bond_change_active_slave(struct bonding *bond, struct slave *new_active)
 {
         struct slave *old_active = bond->curr_active_slave;
 
@@ -1523,7 +1549,7 @@ static void bond_change_active_slave(struct bonding *bond, struct slave *new_act
  *
  * Warning: Caller must hold curr_slave_lock for writing.
  */
-static void bond_select_active_slave(struct bonding *bond)
+void bond_select_active_slave(struct bonding *bond)
 {
         struct slave *best_slave;
 
@@ -1591,7 +1617,7 @@ static void bond_detach_slave(struct bonding *bond, struct slave *slave)
 
 /*---------------------------------- IOCTL ----------------------------------*/
 
-static int bond_sethwaddr(struct net_device *bond_dev, struct net_device *slave_dev)
+int bond_sethwaddr(struct net_device *bond_dev, struct net_device *slave_dev)
 {
         dprintk("bond_dev=%p\n", bond_dev);
         dprintk("slave_dev=%p\n", slave_dev);
@@ -1631,7 +1657,7 @@ static int bond_compute_features(struct bonding *bond)
 }
 
 /* enslave device <slave> to bond device <master> */
-static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
+int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
 {
         struct bonding *bond = bond_dev->priv;
         struct slave *new_slave = NULL;
@@ -1644,8 +1670,8 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
         if (!bond->params.use_carrier && slave_dev->ethtool_ops == NULL &&
                 slave_dev->do_ioctl == NULL) {
                 printk(KERN_WARNING DRV_NAME
-                       ": Warning : no link monitoring support for %s\n",
-                       slave_dev->name);
+                       ": %s: Warning: no link monitoring support for %s\n",
+                       bond_dev->name, slave_dev->name);
         }
 
         /* bond must be initialized by bond_open() before enslaving */
@@ -1666,17 +1692,17 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
                 dprintk("%s: NETIF_F_VLAN_CHALLENGED\n", slave_dev->name);
                 if (!list_empty(&bond->vlan_list)) {
                         printk(KERN_ERR DRV_NAME
-                               ": Error: cannot enslave VLAN "
+                               ": %s: Error: cannot enslave VLAN "
                                "challenged slave %s on VLAN enabled "
-                               "bond %s\n", slave_dev->name,
+                               "bond %s\n", bond_dev->name, slave_dev->name,
                                bond_dev->name);
                         return -EPERM;
                 } else {
                         printk(KERN_WARNING DRV_NAME
-                               ": Warning: enslaved VLAN challenged "
+                               ": %s: Warning: enslaved VLAN challenged "
                                "slave %s. Adding VLANs will be blocked as "
                                "long as %s is part of bond %s\n",
-                               slave_dev->name, slave_dev->name,
+                               bond_dev->name, slave_dev->name, slave_dev->name,
                                bond_dev->name);
                         bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
                 }
@@ -1706,12 +1732,11 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
 
         if (slave_dev->set_mac_address == NULL) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: The slave device you specified does "
-                       "not support setting the MAC address.\n");
-                printk(KERN_ERR
-                       "Your kernel likely does not support slave devices.\n");
-
-                res = -EOPNOTSUPP;
+                        ": %s: Error: The slave device you specified does "
+                        "not support setting the MAC address. "
+                        "Your kernel likely does not support slave "
+                        "devices.\n", bond_dev->name);
+                res = -EOPNOTSUPP;
                 goto err_undo_flags;
         }
 
@@ -1827,21 +1852,21 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
                          * the messages for netif_carrier.
                          */
                         printk(KERN_WARNING DRV_NAME
-                               ": Warning: MII and ETHTOOL support not "
+                               ": %s: Warning: MII and ETHTOOL support not "
                                "available for interface %s, and "
                                "arp_interval/arp_ip_target module parameters "
                                "not specified, thus bonding will not detect "
                                "link failures! see bonding.txt for details.\n",
-                               slave_dev->name);
+                               bond_dev->name, slave_dev->name);
                 } else if (link_reporting == -1) {
                         /* unable get link status using mii/ethtool */
                         printk(KERN_WARNING DRV_NAME
-                               ": Warning: can't get link status from "
+                               ": %s: Warning: can't get link status from "
                                "interface %s; the network driver associated "
                                "with this interface does not support MII or "
                                "ETHTOOL link status reporting, thus miimon "
                                "has no effect on this interface.\n",
-                               slave_dev->name);
+                               bond_dev->name, slave_dev->name);
                 }
         }
 
@@ -1868,15 +1893,15 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
         if (bond_update_speed_duplex(new_slave) &&
             (new_slave->link != BOND_LINK_DOWN)) {
                 printk(KERN_WARNING DRV_NAME
-                       ": Warning: failed to get speed and duplex from %s, "
+                       ": %s: Warning: failed to get speed and duplex from %s, "
                        "assumed to be 100Mb/sec and Full.\n",
-                       new_slave->dev->name);
+                       bond_dev->name, new_slave->dev->name);
 
                 if (bond->params.mode == BOND_MODE_8023AD) {
-                        printk(KERN_WARNING
-                               "Operation of 802.3ad mode requires ETHTOOL "
+                        printk(KERN_WARNING DRV_NAME
+                               ": %s: Warning: Operation of 802.3ad mode requires ETHTOOL "
                                "support in base driver for proper aggregator "
-                               "selection.\n");
+                               "selection.\n", bond_dev->name);
                 }
         }
 
@@ -1958,6 +1983,10 @@ static int bond_enslave(struct net_device *bond_dev, struct net_device *slave_de
 
         write_unlock_bh(&bond->lock);
 
+        res = bond_create_slave_symlinks(bond_dev, slave_dev);
+        if (res)
+                goto err_unset_master;
+
         printk(KERN_INFO DRV_NAME
                ": %s: enslaving %s as a%s interface with a%s link.\n",
                bond_dev->name, slave_dev->name,
@@ -1999,7 +2028,7 @@ err_undo_flags:
  *   for Bonded connections:
  *     The first up interface should be left on and all others downed.
  */
-static int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
+int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
 {
         struct bonding *bond = bond_dev->priv;
         struct slave *slave, *oldcurrent;
@@ -2010,7 +2039,7 @@ static int bond_release(struct net_device *bond_dev, struct net_device *slave_de
         if (!(slave_dev->flags & IFF_SLAVE) ||
             (slave_dev->master != bond_dev)) {
                 printk(KERN_ERR DRV_NAME
-                       ": Error: %s: cannot release %s.\n",
+                       ": %s: Error: cannot release %s.\n",
                        bond_dev->name, slave_dev->name);
                 return -EINVAL;
         }
@@ -2031,11 +2060,12 @@ static int bond_release(struct net_device *bond_dev, struct net_device *slave_de
                                  ETH_ALEN);
         if (!mac_addr_differ && (bond->slave_cnt > 1)) {
                 printk(KERN_WARNING DRV_NAME
-                       ": Warning: the permanent HWaddr of %s "
+                       ": %s: Warning: the permanent HWaddr of %s "
                        "- %02X:%02X:%02X:%02X:%02X:%02X - is "
                        "still in use by %s. Set the HWaddr of "
                        "%s to a different address to avoid "
                        "conflicts.\n",
+                       bond_dev->name,
                        slave_dev->name,
                        slave->perm_hwaddr[0],
                        slave->perm_hwaddr[1],
@@ -2111,24 +2141,28 @@ static int bond_release(struct net_device *bond_dev, struct net_device *slave_de
                         bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
                 } else {
                         printk(KERN_WARNING DRV_NAME
-                               ": Warning: clearing HW address of %s while it "
+                               ": %s: Warning: clearing HW address of %s while it "
                                "still has VLANs.\n",
-                               bond_dev->name);
+                               bond_dev->name, bond_dev->name);
                         printk(KERN_WARNING DRV_NAME
-                               ": When re-adding slaves, make sure the bond's "
-                               "HW address matches its VLANs'.\n");
+                               ": %s: When re-adding slaves, make sure the bond's "
+                               "HW address matches its VLANs'.\n",
+                               bond_dev->name);
                 }
         } else if ((bond_dev->features & NETIF_F_VLAN_CHALLENGED) &&
                    !bond_has_challenged_slaves(bond)) {
                 printk(KERN_INFO DRV_NAME
-                       ": last VLAN challenged slave %s "
+                       ": %s: last VLAN challenged slave %s "
                        "left bond %s. VLAN blocking is removed\n",
-                       slave_dev->name, bond_dev->name);
+                       bond_dev->name, slave_dev->name, bond_dev->name);
                 bond_dev->features &= ~NETIF_F_VLAN_CHALLENGED;
         }
 
         write_unlock_bh(&bond->lock);
 
+        /* must do this from outside any spinlocks */
+        bond_destroy_slave_symlinks(bond_dev, slave_dev);
+
         bond_del_vlans_from_slave(bond, slave_dev);
 
         /* If the mode USES_PRIMARY, then we should only remove its
@@ -2220,6 +2254,7 @@ static int bond_release_all(struct net_device *bond_dev)
                  */
                 write_unlock_bh(&bond->lock);
 
+                bond_destroy_slave_symlinks(bond_dev, slave_dev);
                 bond_del_vlans_from_slave(bond, slave_dev);
 
                 /* If the mode USES_PRIMARY, then we should only remove its
@@ -2274,12 +2309,13 @@ static int bond_release_all(struct net_device *bond_dev)
                 bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
         } else {
                 printk(KERN_WARNING DRV_NAME
-                       ": Warning: clearing HW address of %s while it "
+                       ": %s: Warning: clearing HW address of %s while it "
                        "still has VLANs.\n",
-                       bond_dev->name);
+                       bond_dev->name, bond_dev->name);
                 printk(KERN_WARNING DRV_NAME
-                       ": When re-adding slaves, make sure the bond's "
-                       "HW address matches its VLANs'.\n");
+                       ": %s: When re-adding slaves, make sure the bond's "
+                       "HW address matches its VLANs'.\n",
+                       bond_dev->name);
         }
 
         printk(KERN_INFO DRV_NAME
@@ -2397,7 +2433,7 @@ static int bond_slave_info_query(struct net_device *bond_dev, struct ifslave *in
 /*-------------------------------- Monitoring -------------------------------*/
 
 /* this function is called regularly to monitor each slave's link. */
-static void bond_mii_monitor(struct net_device *bond_dev)
+void bond_mii_monitor(struct net_device *bond_dev)
 {
         struct bonding *bond = bond_dev->priv;
         struct slave *slave, *oldcurrent;
@@ -2596,8 +2632,11 @@ static void bond_mii_monitor(struct net_device *bond_dev)
                         break;
                 default:
                         /* Should not happen */
-                        printk(KERN_ERR "bonding: Error: %s  Illegal value (link=%d)\n",
-                               slave->dev->name, slave->link);
+                        printk(KERN_ERR DRV_NAME
+                               ": %s: Error: %s Illegal value (link=%d)\n",
+                               bond_dev->name,
+                               slave->dev->name,
+                               slave->link);
                         goto out;
                 } /* end of switch (slave->link) */
 
@@ -2721,7 +2760,9 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
         struct flowi fl;
         struct rtable *rt;
 
-        for (i = 0; (i < BOND_MAX_ARP_TARGETS) && targets[i]; i++) {
+        for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) {
+                if (!targets[i])
+                        continue;
                 dprintk("basa: target %x\n", targets[i]);
                 if (list_empty(&bond->vlan_list)) {
                         dprintk("basa: empty vlan: arp_send\n");
@@ -2825,7 +2866,7 @@ static void bond_send_gratuitous_arp(struct bonding *bond)
  * arp is transmitted to generate traffic. see activebackup_arp_monitor for
  * arp monitoring in active backup mode.
  */
-static void bond_loadbalance_arp_mon(struct net_device *bond_dev)
+void bond_loadbalance_arp_mon(struct net_device *bond_dev)
 {
         struct bonding *bond = bond_dev->priv;
         struct slave *slave, *oldcurrent;
@@ -2963,7 +3004,7 @@ out:
  * may have received.
  * see loadbalance_arp_monitor for arp monitoring in load balancing mode
  */
-static void bond_activebackup_arp_mon(struct net_device *bond_dev)
+void bond_activebackup_arp_mon(struct net_device *bond_dev)
 {
         struct bonding *bond = bond_dev->priv;
         struct slave *slave;
@@ -3249,6 +3290,8 @@ static void bond_info_show_master(struct seq_file *seq)
 {
         struct bonding *bond = seq->private;
         struct slave *curr;
+        int i;
+        u32 target;
 
         read_lock(&bond->curr_slave_lock);
         curr = bond->curr_active_slave;
@@ -3257,10 +3300,17 @@ static void bond_info_show_master(struct seq_file *seq)
         seq_printf(seq, "Bonding Mode: %s\n",
                    bond_mode_name(bond->params.mode));
 
+        if (bond->params.mode == BOND_MODE_XOR ||
+                bond->params.mode == BOND_MODE_8023AD) {
+                seq_printf(seq, "Transmit Hash Policy: %s (%d)\n",
+                        xmit_hashtype_tbl[bond->params.xmit_policy].modename,
+                        bond->params.xmit_policy);
+        }
+
         if (USES_PRIMARY(bond->params.mode)) {
                 seq_printf(seq, "Primary Slave: %s\n",
-                           (bond->params.primary[0]) ?
-                                bond->params.primary : "None");
+                           (bond->primary_slave) ?
+                           bond->primary_slave->dev->name : "None");
 
                 seq_printf(seq, "Currently Active Slave: %s\n",
                            (curr) ? curr->dev->name : "None");
@@ -3273,6 +3323,27 @@ static void bond_info_show_master(struct seq_file *seq)
         seq_printf(seq, "Down Delay (ms): %d\n",
                    bond->params.downdelay * bond->params.miimon);
 
+
+        /* ARP information */
+        if(bond->params.arp_interval > 0) {
+                int printed=0;
+                seq_printf(seq, "ARP Polling Interval (ms): %d\n",
+                                bond->params.arp_interval);
+
+                seq_printf(seq, "ARP IP target/s (n.n.n.n form):");
+
+                for(i = 0; (i < BOND_MAX_ARP_TARGETS) ;i++) {
+                        if (!bond->params.arp_targets[i])
+                                continue;
+                        if (printed)
+                                seq_printf(seq, ",");
+                        target = ntohl(bond->params.arp_targets[i]);
+                        seq_printf(seq, " %d.%d.%d.%d", HIPQUAD(target));
+                        printed = 1;
+                }
+                seq_printf(seq, "\n");
+        }
+
         if (bond->params.mode == BOND_MODE_8023AD) {
                 struct ad_info ad_info;
 
@@ -3478,7 +3549,10 @@ static int bond_event_changename(struct bonding *bond)
         bond_remove_proc_entry(bond);
         bond_create_proc_entry(bond);
 #endif
-
+        down_write(&(bonding_rwsem));
+        bond_destroy_sysfs_entry(bond);
+        bond_create_sysfs_entry(bond);
+        up_write(&(bonding_rwsem));
         return NOTIFY_DONE;
 }
 
@@ -3955,6 +4029,7 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmd
                 return -EPERM;
         }
 
+        down_write(&(bonding_rwsem));
         slave_dev = dev_get_by_name(ifr->ifr_slave);
 
         dprintk("slave_dev=%p: \n", slave_dev);
@@ -3987,6 +4062,7 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmd
                 dev_put(slave_dev);
         }
 
+        up_write(&(bonding_rwsem));
         return res;
 }
 
@@ -4071,6 +4147,7 @@ static int bond_change_mtu(struct net_device *bond_dev, int new_mtu)
         bond_for_each_slave(bond, slave, i) {
                 dprintk("s %p s->p %p c_m %p\n", slave,
                         slave->prev, slave->dev->change_mtu);
+
                 res = dev_set_mtu(slave->dev, new_mtu);
 
                 if (res) {
@@ -4397,8 +4474,9 @@ static int bond_xmit_broadcast(struct sk_buff *skb, struct net_device *bond_dev)
                                 struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
                                 if (!skb2) {
                                         printk(KERN_ERR DRV_NAME
-                                               ": Error: bond_xmit_broadcast(): "
-                                               "skb_clone() failed\n");
+                                               ": %s: Error: bond_xmit_broadcast(): "
+                                               "skb_clone() failed\n",
+                                               bond_dev->name);
                                         continue;
                                 }
 
@@ -4431,7 +4509,7 @@ out:
 /*
  * set bond mode specific net device operations
  */
-static inline void bond_set_mode_ops(struct bonding *bond, int mode)
+void bond_set_mode_ops(struct bonding *bond, int mode)
 {
         struct net_device *bond_dev = bond->dev;
 
@@ -4467,7 +4545,8 @@ static inline void bond_set_mode_ops(struct bonding *bond, int mode)
         default:
                 /* Should never happen, mode already checked */
                 printk(KERN_ERR DRV_NAME
-                       ": Error: Unknown bonding mode %d\n",
+                       ": %s: Error: Unknown bonding mode %d\n",
+                       bond_dev->name,
                        mode);
                 break;
         }
@@ -4491,7 +4570,7 @@ static struct ethtool_ops bond_ethtool_ops = {
  * Does not allocate but creates a /proc entry.
  * Allowed to fail.
  */
-static int __init bond_init(struct net_device *bond_dev, struct bond_params *params)
+static int bond_init(struct net_device *bond_dev, struct bond_params *params)
 {
         struct bonding *bond = bond_dev->priv;
 
@@ -4565,7 +4644,7 @@ static int __init bond_init(struct net_device *bond_dev, struct bond_params *par
 /* De-initialize device specific data.
  * Caller must hold rtnl_lock.
  */
-static inline void bond_deinit(struct net_device *bond_dev)
+void bond_deinit(struct net_device *bond_dev)
 {
         struct bonding *bond = bond_dev->priv;
 
@@ -4601,7 +4680,7 @@ static void bond_free_all(void)
  * Convert string input module parms.  Accept either the
  * number of the mode or its string name.
  */
-static inline int bond_parse_parm(char *mode_arg, struct bond_parm_tbl *tbl)
+int bond_parse_parm(char *mode_arg, struct bond_parm_tbl *tbl)
 {
         int i;
 
@@ -4670,7 +4749,7 @@ static int bond_check_params(struct bond_params *params)
         if (max_bonds < 1 || max_bonds > INT_MAX) {
                 printk(KERN_WARNING DRV_NAME
                        ": Warning: max_bonds (%d) not in range %d-%d, so it "
-                       "was reset to BOND_DEFAULT_MAX_BONDS (%d)",
+                       "was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",
                        max_bonds, 1, INT_MAX, BOND_DEFAULT_MAX_BONDS);
                 max_bonds = BOND_DEFAULT_MAX_BONDS;
         }
@@ -4881,81 +4960,96 @@ static int bond_check_params(struct bond_params *params)
         return 0;
 }
 
+/* Create a new bond based on the specified name and bonding parameters.
+ * Caller must NOT hold rtnl_lock; we need to release it here before we
+ * set up our sysfs entries.
+ */
+int bond_create(char *name, struct bond_params *params, struct bonding **newbond)
+{
+        struct net_device *bond_dev;
+        int res;
+
+        rtnl_lock();
+        bond_dev = alloc_netdev(sizeof(struct bonding), name, ether_setup);
+        if (!bond_dev) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: eek! can't alloc netdev!\n",
+                       name);
+                res = -ENOMEM;
+                goto out_rtnl;
+        }
+
+        /* bond_init() must be called after dev_alloc_name() (for the
+         * /proc files), but before register_netdevice(), because we
+         * need to set function pointers.
+         */
+
+        res = bond_init(bond_dev, params);
+        if (res < 0) {
+                goto out_netdev;
+        }
+
+        SET_MODULE_OWNER(bond_dev);
+
+        res = register_netdevice(bond_dev);
+        if (res < 0) {
+                goto out_bond;
+        }
+        if (newbond)
+                *newbond = bond_dev->priv;
+
+        rtnl_unlock(); /* allows sysfs registration of net device */
+        res = bond_create_sysfs_entry(bond_dev->priv);
+        goto done;
+out_bond:
+        bond_deinit(bond_dev);
+out_netdev:
+        free_netdev(bond_dev);
+out_rtnl:
+        rtnl_unlock();
+done:
+        return res;
+}
+
 static int __init bonding_init(void)
 {
-        struct bond_params params;
         int i;
         int res;
+        char new_bond_name[8];  /* Enough room for 999 bonds at init. */
 
         printk(KERN_INFO "%s", version);
 
-        res = bond_check_params(&params);
+        res = bond_check_params(&bonding_defaults);
         if (res) {
-                return res;
+                goto out;
         }
 
-        rtnl_lock();
-
 #ifdef CONFIG_PROC_FS
         bond_create_proc_dir();
 #endif
-
         for (i = 0; i < max_bonds; i++) {
-                struct net_device *bond_dev;
-
-                bond_dev = alloc_netdev(sizeof(struct bonding), "", ether_setup);
-                if (!bond_dev) {
-                        res = -ENOMEM;
-                        goto out_err;
-                }
-
-                res = dev_alloc_name(bond_dev, "bond%d");
-                if (res < 0) {
-                        free_netdev(bond_dev);
-                        goto out_err;
-                }
-
-                /* bond_init() must be called after dev_alloc_name() (for the
-                 * /proc files), but before register_netdevice(), because we
-                 * need to set function pointers.
-                 */
-                res = bond_init(bond_dev, &params);
-                if (res < 0) {
-                        free_netdev(bond_dev);
-                        goto out_err;
-                }
-
-                SET_MODULE_OWNER(bond_dev);
-
-                res = register_netdevice(bond_dev);
-                if (res < 0) {
-                        bond_deinit(bond_dev);
-                        free_netdev(bond_dev);
-                        goto out_err;
-                }
+                sprintf(new_bond_name, "bond%d",i);
+                res = bond_create(new_bond_name,&bonding_defaults, NULL);
+                if (res)
+                        goto err;
         }
 
-        rtnl_unlock();
+        res = bond_create_sysfs();
+        if (res)
+                goto err;
+
         register_netdevice_notifier(&bond_netdev_notifier);
         register_inetaddr_notifier(&bond_inetaddr_notifier);
 
-        return 0;
-
-out_err:
-        /*
-         * rtnl_unlock() will run netdev_run_todo(), putting the
-         * thus-far-registered bonding devices into a state which
-         * unregigister_netdevice() will accept
-         */
-        rtnl_unlock();
+        goto out;
+err:
         rtnl_lock();
-
-        /* free and unregister all bonds that were successfully added */
         bond_free_all();
-
+        bond_destroy_sysfs();
         rtnl_unlock();
-
+out:
         return res;
+
 }
 
 static void __exit bonding_exit(void)
@@ -4965,6 +5059,7 @@ static void __exit bonding_exit(void)
 
         rtnl_lock();
         bond_free_all();
+        bond_destroy_sysfs();
         rtnl_unlock();
 }
 
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
new file mode 100644
index 000000000000..c5f1c52863cb
--- /dev/null
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -0,0 +1,1399 @@
+
+/*
+ * Copyright(c) 2004-2005 Intel Corporation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ *
+ * Changes:
+ *
+ * 2004/12/12 - Mitch Williams <mitch.a.williams at intel dot com>
+ *      - Initial creation of sysfs interface.
+ *
+ * 2005/06/22 - Radheka Godse <radheka.godse at intel dot com>
+ *      - Added ifenslave -c type functionality to sysfs
+ *      - Added sysfs files for attributes such as  MII Status and
+ *        802.3ad aggregator that are displayed in /proc
+ *      - Added "name value" format to sysfs "mode" and
+ *        "lacp_rate", for e.g., "active-backup 1" or "slow 0" for
+ *        consistency and ease of script parsing
+ *      - Fixed reversal of octets in arp_ip_targets via sysfs
+ *      - sysfs support to handle bond interface re-naming
+ *      - Moved all sysfs entries into /sys/class/net instead of
+ *        of using a standalone subsystem.
+ *      - Added sysfs symlinks between masters and slaves
+ *      - Corrected bugs in sysfs unload path when creating bonds
+ *        with existing interface names.
+ *      - Removed redundant sysfs stat file since it duplicates slave info
+ *        from the proc file
+ *      - Fixed errors in sysfs show/store arp targets.
+ *      - For consistency with ifenslave, instead of exiting
+ *        with an error, updated bonding sysfs to
+ *        close and attempt to enslave an up adapter.
+ *      - Fixed NULL dereference when adding a slave interface
+ *        that does not exist.
+ *      - Added checks in sysfs bonding to reject invalid ip addresses
+ *      - Synch up with post linux-2.6.12 bonding changes
+ *      - Created sysfs bond attrib for xmit_hash_policy
+ *
+ * 2005/09/19 - Mitch Williams <mitch.a.williams at intel dot com>
+ *      - Changed semantics of multi-item files to be command-based
+ *        instead of list-based.
+ *      - Changed ARP target handler to use in_aton instead of sscanf
+ *      - Style changes.
+ * 2005/09/27 - Mitch Williams <mitch.a.williams at intel dot com>
+ *      - Made line endings consistent.
+ *      - Removed "none" from primary output - just put blank instead
+ *      - Fixed bug with long interface names
+ */
+#include <linux/config.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/sched.h>
+#include <linux/device.h>
+#include <linux/sysdev.h>
+#include <linux/fs.h>
+#include <linux/types.h>
+#include <linux/string.h>
+#include <linux/netdevice.h>
+#include <linux/inetdevice.h>
+#include <linux/in.h>
+#include <linux/sysfs.h>
+#include <linux/string.h>
+#include <linux/ctype.h>
+#include <linux/inet.h>
+#include <linux/rtnetlink.h>
+
+/* #define BONDING_DEBUG 1 */
+#include "bonding.h"
+#define to_class_dev(obj) container_of(obj,struct class_device,kobj)
+#define to_net_dev(class) container_of(class, struct net_device, class_dev)
+#define to_bond(cd)     ((struct bonding *)(to_net_dev(cd)->priv))
+
+/*---------------------------- Declarations -------------------------------*/
+
+
+extern struct list_head bond_dev_list;
+extern struct bond_params bonding_defaults;
+extern struct bond_parm_tbl bond_mode_tbl[];
+extern struct bond_parm_tbl bond_lacp_tbl[];
+extern struct bond_parm_tbl xmit_hashtype_tbl[];
+
+static int expected_refcount = -1;
+static struct class *netdev_class;
+/*--------------------------- Data Structures -----------------------------*/
+
+/* Bonding sysfs lock.  Why can't we just use the subsytem lock?
+ * Because kobject_register tries to acquire the subsystem lock.  If
+ * we already hold the lock (which we would if the user was creating
+ * a new bond through the sysfs interface), we deadlock.
+ * This lock is only needed when deleting a bond - we need to make sure
+ * that we don't collide with an ongoing ioctl.
+ */
+
+struct rw_semaphore bonding_rwsem;
+
+
+
+
+/*------------------------------ Functions --------------------------------*/
+
+/*
+ * "show" function for the bond_masters attribute.
+ * The class parameter is ignored.
+ */
+static ssize_t bonding_show_bonds(struct class *cls, char *buffer)
+{
+        int res = 0;
+        struct bonding *bond;
+
+        down_read(&(bonding_rwsem));
+
+        list_for_each_entry(bond, &bond_dev_list, bond_list) {
+                if (res > (PAGE_SIZE - IFNAMSIZ)) {
+                        /* not enough space for another interface name */
+                        if ((PAGE_SIZE - res) > 10)
+                                res = PAGE_SIZE - 10;
+                        res += sprintf(buffer + res, "++more++");
+                        break;
+                }
+                res += sprintf(buffer + res, "%s ",
+                               bond->dev->name);
+        }
+        res += sprintf(buffer + res, "\n");
+        res++;
+        up_read(&(bonding_rwsem));
+        return res;
+}
+
+/*
+ * "store" function for the bond_masters attribute.  This is what
+ * creates and deletes entire bonds.
+ *
+ * The class parameter is ignored.
+ *
+ */
+
+static ssize_t bonding_store_bonds(struct class *cls, const char *buffer, size_t count)
+{
+        char command[IFNAMSIZ + 1] = {0, };
+        char *ifname;
+        int res = count;
+        struct bonding *bond;
+        struct bonding *nxt;
+
+        down_write(&(bonding_rwsem));
+        sscanf(buffer, "%16s", command); /* IFNAMSIZ*/
+        ifname = command + 1;
+        if ((strlen(command) <= 1) ||
+            !dev_valid_name(ifname))
+                goto err_no_cmd;
+
+        if (command[0] == '+') {
+
+                /* Check to see if the bond already exists. */
+                list_for_each_entry_safe(bond, nxt, &bond_dev_list, bond_list)
+                        if (strnicmp(bond->dev->name, ifname, IFNAMSIZ) == 0) {
+                                printk(KERN_ERR DRV_NAME
+                                        ": cannot add bond %s; it already exists\n",
+                                        ifname);
+                                res = -EPERM;
+                                goto out;
+                        }
+
+                printk(KERN_INFO DRV_NAME
+                        ": %s is being created...\n", ifname);
+                if (bond_create(ifname, &bonding_defaults, &bond)) {
+                        printk(KERN_INFO DRV_NAME
+                        ": %s interface already exists. Bond creation failed.\n",
+                        ifname);
+                        res = -EPERM;
+                }
+                goto out;
+        }
+
+        if (command[0] == '-') {
+                list_for_each_entry_safe(bond, nxt, &bond_dev_list, bond_list)
+                        if (strnicmp(bond->dev->name, ifname, IFNAMSIZ) == 0) {
+                                rtnl_lock();
+                                /* check the ref count on the bond's kobject.
+                                 * If it's > expected, then there's a file open,
+                                 * and we have to fail.
+                                 */
+                                if (atomic_read(&bond->dev->class_dev.kobj.kref.refcount)
+                                                        > expected_refcount){
+                                        rtnl_unlock();
+                                        printk(KERN_INFO DRV_NAME
+                                                ": Unable remove bond %s due to open references.\n",
+                                                ifname);
+                                        res = -EPERM;
+                                        goto out;
+                                }
+                                printk(KERN_INFO DRV_NAME
+                                        ": %s is being deleted...\n",
+                                        bond->dev->name);
+                                unregister_netdevice(bond->dev);
+                                bond_deinit(bond->dev);
+                                bond_destroy_sysfs_entry(bond);
+                                rtnl_unlock();
+                                goto out;
+                        }
+
+                printk(KERN_ERR DRV_NAME
+                        ": unable to delete non-existent bond %s\n", ifname);
+                res = -ENODEV;
+                goto out;
+        }
+
+err_no_cmd:
+        printk(KERN_ERR DRV_NAME
+                ": no command found in bonding_masters. Use +ifname or -ifname.\n");
+        res = -EPERM;
+
+        /* Always return either count or an error.  If you return 0, you'll
+         * get called forever, which is bad.
+         */
+out:
+        up_write(&(bonding_rwsem));
+        return res;
+}
+/* class attribute for bond_masters file.  This ends up in /sys/class/net */
+static CLASS_ATTR(bonding_masters,  S_IWUSR | S_IRUGO,
+                  bonding_show_bonds, bonding_store_bonds);
+
+int bond_create_slave_symlinks(struct net_device *master, struct net_device *slave)
+{
+        char linkname[IFNAMSIZ+7];
+        int ret = 0;
+
+        /* first, create a link from the slave back to the master */
+        ret = sysfs_create_link(&(slave->class_dev.kobj), &(master->class_dev.kobj),
+                                "master");
+        if (ret)
+                return ret;
+        /* next, create a link from the master to the slave */
+        sprintf(linkname,"slave_%s",slave->name);
+        ret = sysfs_create_link(&(master->class_dev.kobj), &(slave->class_dev.kobj),
+                                linkname);
+        return ret;
+
+}
+
+void bond_destroy_slave_symlinks(struct net_device *master, struct net_device *slave)
+{
+        char linkname[IFNAMSIZ+7];
+
+        sysfs_remove_link(&(slave->class_dev.kobj), "master");
+        sprintf(linkname,"slave_%s",slave->name);
+        sysfs_remove_link(&(master->class_dev.kobj), linkname);
+}
+
+
+/*
+ * Show the slaves in the current bond.
+ */
+static ssize_t bonding_show_slaves(struct class_device *cd, char *buf)
+{
+        struct slave *slave;
+        int i, res = 0;
+        struct bonding *bond = to_bond(cd);
+
+        read_lock_bh(&bond->lock);
+        bond_for_each_slave(bond, slave, i) {
+                if (res > (PAGE_SIZE - IFNAMSIZ)) {
+                        /* not enough space for another interface name */
+                        if ((PAGE_SIZE - res) > 10)
+                                res = PAGE_SIZE - 10;
+                        res += sprintf(buf + res, "++more++");
+                        break;
+                }
+                res += sprintf(buf + res, "%s ", slave->dev->name);
+        }
+        read_unlock_bh(&bond->lock);
+        res += sprintf(buf + res, "\n");
+        res++;
+        return res;
+}
+
+/*
+ * Set the slaves in the current bond.  The bond interface must be
+ * up for this to succeed.
+ * This function is largely the same flow as bonding_update_bonds().
+ */
+static ssize_t bonding_store_slaves(struct class_device *cd, const char *buffer, size_t count)
+{
+        char command[IFNAMSIZ + 1] = { 0, };
+        char *ifname;
+        int i, res, found, ret = count;
+        struct slave *slave;
+        struct net_device *dev = 0;
+        struct bonding *bond = to_bond(cd);
+
+        /* Quick sanity check -- is the bond interface up? */
+        if (!(bond->dev->flags & IFF_UP)) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Unable to update slaves because interface is down.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        /* Note:  We can't hold bond->lock here, as bond_create grabs it. */
+
+        sscanf(buffer, "%16s", command); /* IFNAMSIZ*/
+        ifname = command + 1;
+        if ((strlen(command) <= 1) ||
+            !dev_valid_name(ifname))
+                goto err_no_cmd;
+
+        if (command[0] == '+') {
+
+                /* Got a slave name in ifname.  Is it already in the list? */
+                found = 0;
+                read_lock_bh(&bond->lock);
+                bond_for_each_slave(bond, slave, i)
+                        if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
+                                printk(KERN_ERR DRV_NAME
+                                       ": %s: Interface %s is already enslaved!\n",
+                                       bond->dev->name, ifname);
+                                ret = -EPERM;
+                                read_unlock_bh(&bond->lock);
+                                goto out;
+                        }
+
+                read_unlock_bh(&bond->lock);
+                printk(KERN_INFO DRV_NAME ": %s: Adding slave %s.\n",
+                       bond->dev->name, ifname);
+                dev = dev_get_by_name(ifname);
+                if (!dev) {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: Interface %s does not exist!\n",
+                               bond->dev->name, ifname);
+                        ret = -EPERM;
+                        goto out;
+                }
+                else
+                        dev_put(dev);
+
+                if (dev->flags & IFF_UP) {
+                        printk(KERN_ERR DRV_NAME
+                               ": %s: Error: Unable to enslave %s "
+                               "because it is already up.\n",
+                               bond->dev->name, dev->name);
+                        ret = -EPERM;
+                        goto out;
+                }
+                /* If this is the first slave, then we need to set
+                   the master's hardware address to be the same as the
+                   slave's. */
+                if (!(*((u32 *) & (bond->dev->dev_addr[0])))) {
+                        memcpy(bond->dev->dev_addr, dev->dev_addr,
+                               dev->addr_len);
+                }
+
+                /* Set the slave's MTU to match the bond */
+                if (dev->mtu != bond->dev->mtu) {
+                        if (dev->change_mtu) {
+                                res = dev->change_mtu(dev,
+                                                      bond->dev->mtu);
+                                if (res) {
+                                        ret = res;
+                                        goto out;
+                                }
+                        } else {
+                                dev->mtu = bond->dev->mtu;
+                        }
+                }
+                rtnl_lock();
+                res = bond_enslave(bond->dev, dev);
+                rtnl_unlock();
+                if (res) {
+                        ret = res;
+                }
+                goto out;
+        }
+
+        if (command[0] == '-') {
+                dev = NULL;
+                bond_for_each_slave(bond, slave, i)
+                        if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
+                                dev = slave->dev;
+                                break;
+                        }
+                if (dev) {
+                        printk(KERN_INFO DRV_NAME ": %s: Removing slave %s\n",
+                                bond->dev->name, dev->name);
+                        rtnl_lock();
+                        res = bond_release(bond->dev, dev);
+                        rtnl_unlock();
+                        if (res) {
+                                ret = res;
+                                goto out;
+                        }
+                        /* set the slave MTU to the default */
+                        if (dev->change_mtu) {
+                                dev->change_mtu(dev, 1500);
+                        } else {
+                                dev->mtu = 1500;
+                        }
+                }
+                else {
+                        printk(KERN_ERR DRV_NAME ": unable to remove non-existent slave %s for bond %s.\n",
+                                ifname, bond->dev->name);
+                        ret = -ENODEV;
+                }
+                goto out;
+        }
+
+err_no_cmd:
+        printk(KERN_ERR DRV_NAME ": no command found in slaves file for bond %s. Use +ifname or -ifname.\n", bond->dev->name);
+        ret = -EPERM;
+
+out:
+        return ret;
+}
+
+static CLASS_DEVICE_ATTR(slaves, S_IRUGO | S_IWUSR, bonding_show_slaves, bonding_store_slaves);
+
+/*
+ * Show and set the bonding mode.  The bond interface must be down to
+ * change the mode.
+ */
+static ssize_t bonding_show_mode(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%s %d\n",
+                        bond_mode_tbl[bond->params.mode].modename,
+                        bond->params.mode) + 1;
+}
+
+static ssize_t bonding_store_mode(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->dev->flags & IFF_UP) {
+                printk(KERN_ERR DRV_NAME
+                       ": unable to update mode of %s because interface is up.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        new_value = bond_parse_parm((char *)buf, bond_mode_tbl);
+        if (new_value < 0)  {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Ignoring invalid mode value %.*s.\n",
+                       bond->dev->name,
+                       (int)strlen(buf) - 1, buf);
+                ret = -EINVAL;
+                goto out;
+        } else {
+                bond->params.mode = new_value;
+                bond_set_mode_ops(bond, bond->params.mode);
+                printk(KERN_INFO DRV_NAME ": %s: setting mode to %s (%d).\n",
+                        bond->dev->name, bond_mode_tbl[new_value].modename, new_value);
+        }
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(mode, S_IRUGO | S_IWUSR, bonding_show_mode, bonding_store_mode);
+
+/*
+ * Show and set the bonding transmit hash method.  The bond interface must be down to
+ * change the xmit hash policy.
+ */
+static ssize_t bonding_show_xmit_hash(struct class_device *cd, char *buf)
+{
+        int count;
+        struct bonding *bond = to_bond(cd);
+
+        if ((bond->params.mode != BOND_MODE_XOR) &&
+            (bond->params.mode != BOND_MODE_8023AD)) {
+                // Not Applicable
+                count = sprintf(buf, "NA\n") + 1;
+        } else {
+                count = sprintf(buf, "%s %d\n",
+                        xmit_hashtype_tbl[bond->params.xmit_policy].modename,
+                        bond->params.xmit_policy) + 1;
+        }
+
+        return count;
+}
+
+static ssize_t bonding_store_xmit_hash(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->dev->flags & IFF_UP) {
+                printk(KERN_ERR DRV_NAME
+                       "%s: Interface is up. Unable to update xmit policy.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        if ((bond->params.mode != BOND_MODE_XOR) &&
+            (bond->params.mode != BOND_MODE_8023AD)) {
+                printk(KERN_ERR DRV_NAME
+                       "%s: Transmit hash policy is irrelevant in this mode.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        new_value = bond_parse_parm((char *)buf, xmit_hashtype_tbl);
+        if (new_value < 0)  {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Ignoring invalid xmit hash policy value %.*s.\n",
+                       bond->dev->name,
+                       (int)strlen(buf) - 1, buf);
+                ret = -EINVAL;
+                goto out;
+        } else {
+                bond->params.xmit_policy = new_value;
+                bond_set_mode_ops(bond, bond->params.mode);
+                printk(KERN_INFO DRV_NAME ": %s: setting xmit hash policy to %s (%d).\n",
+                        bond->dev->name, xmit_hashtype_tbl[new_value].modename, new_value);
+        }
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(xmit_hash_policy, S_IRUGO | S_IWUSR, bonding_show_xmit_hash, bonding_store_xmit_hash);
+
+/*
+ * Show and set the arp timer interval.  There are two tricky bits
+ * here.  First, if ARP monitoring is activated, then we must disable
+ * MII monitoring.  Second, if the ARP timer isn't running, we must
+ * start it.
+ */
+static ssize_t bonding_show_arp_interval(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%d\n", bond->params.arp_interval) + 1;
+}
+
+static ssize_t bonding_store_arp_interval(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (sscanf(buf, "%d", &new_value) != 1) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: no arp_interval value specified.\n",
+                       bond->dev->name);
+                ret = -EINVAL;
+                goto out;
+        }
+        if (new_value < 0) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Invalid arp_interval value %d not in range 1-%d; rejected.\n",
+                       bond->dev->name, new_value, INT_MAX);
+                ret = -EINVAL;
+                goto out;
+        }
+
+        printk(KERN_INFO DRV_NAME
+               ": %s: Setting ARP monitoring interval to %d.\n",
+               bond->dev->name, new_value);
+        bond->params.arp_interval = new_value;
+        if (bond->params.miimon) {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: ARP monitoring cannot be used with MII monitoring. "
+                       "%s Disabling MII monitoring.\n",
+                       bond->dev->name, bond->dev->name);
+                bond->params.miimon = 0;
+                /* Kill MII timer, else it brings bond's link down */
+                if (bond->arp_timer.function) {
+                        printk(KERN_INFO DRV_NAME
+                        ": %s: Kill MII timer, else it brings bond's link down...\n",
+                       bond->dev->name);
+                        del_timer_sync(&bond->mii_timer);
+                }
+        }
+        if (!bond->params.arp_targets[0]) {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: ARP monitoring has been set up, "
+                       "but no ARP targets have been specified.\n",
+                       bond->dev->name);
+        }
+        if (bond->dev->flags & IFF_UP) {
+                /* If the interface is up, we may need to fire off
+                 * the ARP timer.  If the interface is down, the
+                 * timer will get fired off when the open function
+                 * is called.
+                 */
+                if (bond->arp_timer.function) {
+                        /* The timer's already set up, so fire it off */
+                        mod_timer(&bond->arp_timer, jiffies + 1);
+                } else {
+                        /* Set up the timer. */
+                        init_timer(&bond->arp_timer);
+                        bond->arp_timer.expires = jiffies + 1;
+                        bond->arp_timer.data =
+                                (unsigned long) bond->dev;
+                        if (bond->params.mode == BOND_MODE_ACTIVEBACKUP) {
+                                bond->arp_timer.function =
+                                        (void *)
+                                        &bond_activebackup_arp_mon;
+                        } else {
+                                bond->arp_timer.function =
+                                        (void *)
+                                        &bond_loadbalance_arp_mon;
+                        }
+                        add_timer(&bond->arp_timer);
+                }
+        }
+
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(arp_interval, S_IRUGO | S_IWUSR , bonding_show_arp_interval, bonding_store_arp_interval);
+
+/*
+ * Show and set the arp targets.
+ */
+static ssize_t bonding_show_arp_targets(struct class_device *cd, char *buf)
+{
+        int i, res = 0;
+        struct bonding *bond = to_bond(cd);
+
+        for (i = 0; i < BOND_MAX_ARP_TARGETS; i++) {
+                if (bond->params.arp_targets[i])
+                        res += sprintf(buf + res, "%u.%u.%u.%u ",
+                               NIPQUAD(bond->params.arp_targets[i]));
+        }
+        if (res)
+                res--;  /* eat the leftover space */
+        res += sprintf(buf + res, "\n");
+        res++;
+        return res;
+}
+
+static ssize_t bonding_store_arp_targets(struct class_device *cd, const char *buf, size_t count)
+{
+        u32 newtarget;
+        int i = 0, done = 0, ret = count;
+        struct bonding *bond = to_bond(cd);
+        u32 *targets;
+
+        targets = bond->params.arp_targets;
+        newtarget = in_aton(buf + 1);
+        /* look for adds */
+        if (buf[0] == '+') {
+                if ((newtarget == 0) || (newtarget == INADDR_BROADCAST)) {
+                        printk(KERN_ERR DRV_NAME
+                               ": %s: invalid ARP target %u.%u.%u.%u specified for addition\n",
+                               bond->dev->name, NIPQUAD(newtarget));
+                        ret = -EINVAL;
+                        goto out;
+                }
+                /* look for an empty slot to put the target in, and check for dupes */
+                for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) {
+                        if (targets[i] == newtarget) { /* duplicate */
+                                printk(KERN_ERR DRV_NAME
+                                       ": %s: ARP target %u.%u.%u.%u is already present\n",
+                                       bond->dev->name, NIPQUAD(newtarget));
+                                if (done)
+                                        targets[i] = 0;
+                                ret = -EINVAL;
+                                goto out;
+                        }
+                        if (targets[i] == 0 && !done) {
+                                printk(KERN_INFO DRV_NAME
+                                       ": %s: adding ARP target %d.%d.%d.%d.\n",
+                                       bond->dev->name, NIPQUAD(newtarget));
+                                done = 1;
+                                targets[i] = newtarget;
+                        }
+                }
+                if (!done) {
+                        printk(KERN_ERR DRV_NAME
+                               ": %s: ARP target table is full!\n",
+                               bond->dev->name);
+                        ret = -EINVAL;
+                        goto out;
+                }
+
+        }
+        else if (buf[0] == '-') {
+                if ((newtarget == 0) || (newtarget == INADDR_BROADCAST)) {
+                        printk(KERN_ERR DRV_NAME
+                               ": %s: invalid ARP target %d.%d.%d.%d specified for removal\n",
+                               bond->dev->name, NIPQUAD(newtarget));
+                        ret = -EINVAL;
+                        goto out;
+                }
+
+                for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) {
+                        if (targets[i] == newtarget) {
+                                printk(KERN_INFO DRV_NAME
+                                       ": %s: removing ARP target %d.%d.%d.%d.\n",
+                                       bond->dev->name, NIPQUAD(newtarget));
+                                targets[i] = 0;
+                                done = 1;
+                        }
+                }
+                if (!done) {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: unable to remove nonexistent ARP target %d.%d.%d.%d.\n",
+                               bond->dev->name, NIPQUAD(newtarget));
+                        ret = -EINVAL;
+                        goto out;
+                }
+        }
+        else {
+                printk(KERN_ERR DRV_NAME ": no command found in arp_ip_targets file for bond %s. Use +<addr> or -<addr>.\n",
+                        bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(arp_ip_target, S_IRUGO | S_IWUSR , bonding_show_arp_targets, bonding_store_arp_targets);
+
+/*
+ * Show and set the up and down delays.  These must be multiples of the
+ * MII monitoring value, and are stored internally as the multiplier.
+ * Thus, we must translate to MS for the real world.
+ */
+static ssize_t bonding_show_downdelay(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%d\n", bond->params.downdelay * bond->params.miimon) + 1;
+}
+
+static ssize_t bonding_store_downdelay(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (!(bond->params.miimon)) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Unable to set down delay as MII monitoring is disabled\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        if (sscanf(buf, "%d", &new_value) != 1) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: no down delay value specified.\n",
+                       bond->dev->name);
+                ret = -EINVAL;
+                goto out;
+        }
+        if (new_value < 0) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
+                       bond->dev->name, new_value, 1, INT_MAX);
+                ret = -EINVAL;
+                goto out;
+        } else {
+                if ((new_value % bond->params.miimon) != 0) {
+                        printk(KERN_WARNING DRV_NAME
+                               ": %s: Warning: down delay (%d) is not a multiple "
+                               "of miimon (%d), delay rounded to %d ms\n",
+                               bond->dev->name, new_value, bond->params.miimon,
+                               (new_value / bond->params.miimon) *
+                               bond->params.miimon);
+                }
+                bond->params.downdelay = new_value / bond->params.miimon;
+                printk(KERN_INFO DRV_NAME ": %s: Setting down delay to %d.\n",
+                       bond->dev->name, bond->params.downdelay * bond->params.miimon);
+
+        }
+
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(downdelay, S_IRUGO | S_IWUSR , bonding_show_downdelay, bonding_store_downdelay);
+
+static ssize_t bonding_show_updelay(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%d\n", bond->params.updelay * bond->params.miimon) + 1;
+
+}
+
+static ssize_t bonding_store_updelay(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (!(bond->params.miimon)) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Unable to set up delay as MII monitoring is disabled\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        if (sscanf(buf, "%d", &new_value) != 1) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: no up delay value specified.\n",
+                       bond->dev->name);
+                ret = -EINVAL;
+                goto out;
+        }
+        if (new_value < 0) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
+                       bond->dev->name, new_value, 1, INT_MAX);
+                ret = -EINVAL;
+                goto out;
+        } else {
+                if ((new_value % bond->params.miimon) != 0) {
+                        printk(KERN_WARNING DRV_NAME
+                               ": %s: Warning: up delay (%d) is not a multiple "
+                               "of miimon (%d), updelay rounded to %d ms\n",
+                               bond->dev->name, new_value, bond->params.miimon,
+                               (new_value / bond->params.miimon) *
+                               bond->params.miimon);
+                }
+                bond->params.updelay = new_value / bond->params.miimon;
+                printk(KERN_INFO DRV_NAME ": %s: Setting up delay to %d.\n",
+                       bond->dev->name, bond->params.updelay * bond->params.miimon);
+
+        }
+
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(updelay, S_IRUGO | S_IWUSR , bonding_show_updelay, bonding_store_updelay);
+
+/*
+ * Show and set the LACP interval.  Interface must be down, and the mode
+ * must be set to 802.3ad mode.
+ */
+static ssize_t bonding_show_lacp(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%s %d\n",
+                bond_lacp_tbl[bond->params.lacp_fast].modename,
+                bond->params.lacp_fast) + 1;
+}
+
+static ssize_t bonding_store_lacp(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->dev->flags & IFF_UP) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Unable to update LACP rate because interface is up.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        if (bond->params.mode != BOND_MODE_8023AD) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Unable to update LACP rate because bond is not in 802.3ad mode.\n",
+                       bond->dev->name);
+                ret = -EPERM;
+                goto out;
+        }
+
+        new_value = bond_parse_parm((char *)buf, bond_lacp_tbl);
+
+        if ((new_value == 1) || (new_value == 0)) {
+                bond->params.lacp_fast = new_value;
+                printk(KERN_INFO DRV_NAME
+                       ": %s: Setting LACP rate to %s (%d).\n",
+                       bond->dev->name, bond_lacp_tbl[new_value].modename, new_value);
+        } else {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Ignoring invalid LACP rate value %.*s.\n",
+                        bond->dev->name, (int)strlen(buf) - 1, buf);
+                ret = -EINVAL;
+        }
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(lacp_rate, S_IRUGO | S_IWUSR, bonding_show_lacp, bonding_store_lacp);
+
+/*
+ * Show and set the MII monitor interval.  There are two tricky bits
+ * here.  First, if MII monitoring is activated, then we must disable
+ * ARP monitoring.  Second, if the timer isn't running, we must
+ * start it.
+ */
+static ssize_t bonding_show_miimon(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%d\n", bond->params.miimon) + 1;
+}
+
+static ssize_t bonding_store_miimon(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+        if (sscanf(buf, "%d", &new_value) != 1) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: no miimon value specified.\n",
+                       bond->dev->name);
+                ret = -EINVAL;
+                goto out;
+        }
+        if (new_value < 0) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: Invalid miimon value %d not in range %d-%d; rejected.\n",
+                       bond->dev->name, new_value, 1, INT_MAX);
+                ret = -EINVAL;
+                goto out;
+        } else {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: Setting MII monitoring interval to %d.\n",
+                       bond->dev->name, new_value);
+                bond->params.miimon = new_value;
+                if(bond->params.updelay)
+                        printk(KERN_INFO DRV_NAME
+                              ": %s: Note: Updating updelay (to %d) "
+                              "since it is a multiple of the miimon value.\n",
+                              bond->dev->name,
+                              bond->params.updelay * bond->params.miimon);
+                if(bond->params.downdelay)
+                        printk(KERN_INFO DRV_NAME
+                              ": %s: Note: Updating downdelay (to %d) "
+                              "since it is a multiple of the miimon value.\n",
+                              bond->dev->name,
+                              bond->params.downdelay * bond->params.miimon);
+                if (bond->params.arp_interval) {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: MII monitoring cannot be used with "
+                               "ARP monitoring. Disabling ARP monitoring...\n",
+                               bond->dev->name);
+                        bond->params.arp_interval = 0;
+                        /* Kill ARP timer, else it brings bond's link down */
+                        if (bond->mii_timer.function) {
+                                printk(KERN_INFO DRV_NAME
+                                ": %s: Kill ARP timer, else it brings bond's link down...\n",
+                               bond->dev->name);
+                                del_timer_sync(&bond->arp_timer);
+                        }
+                }
+
+                if (bond->dev->flags & IFF_UP) {
+                        /* If the interface is up, we may need to fire off
+                         * the MII timer. If the interface is down, the
+                         * timer will get fired off when the open function
+                         * is called.
+                         */
+                        if (bond->mii_timer.function) {
+                                /* The timer's already set up, so fire it off */
+                                mod_timer(&bond->mii_timer, jiffies + 1);
+                        } else {
+                                /* Set up the timer. */
+                                init_timer(&bond->mii_timer);
+                                bond->mii_timer.expires = jiffies + 1;
+                                bond->mii_timer.data =
+                                        (unsigned long) bond->dev;
+                                bond->mii_timer.function =
+                                        (void *) &bond_mii_monitor;
+                                add_timer(&bond->mii_timer);
+                        }
+                }
+        }
+out:
+        return ret;
+}
+static CLASS_DEVICE_ATTR(miimon, S_IRUGO | S_IWUSR, bonding_show_miimon, bonding_store_miimon);
+
+/*
+ * Show and set the primary slave.  The store function is much
+ * simpler than bonding_store_slaves function because it only needs to
+ * handle one interface name.
+ * The bond must be a mode that supports a primary for this be
+ * set.
+ */
+static ssize_t bonding_show_primary(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->primary_slave)
+                count = sprintf(buf, "%s\n", bond->primary_slave->dev->name) + 1;
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+
+static ssize_t bonding_store_primary(struct class_device *cd, const char *buf, size_t count)
+{
+        int i;
+        struct slave *slave;
+        struct bonding *bond = to_bond(cd);
+
+        write_lock_bh(&bond->lock);
+        if (!USES_PRIMARY(bond->params.mode)) {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: Unable to set primary slave; %s is in mode %d\n",
+                       bond->dev->name, bond->dev->name, bond->params.mode);
+        } else {
+                bond_for_each_slave(bond, slave, i) {
+                        if (strnicmp
+                            (slave->dev->name, buf,
+                             strlen(slave->dev->name)) == 0) {
+                                printk(KERN_INFO DRV_NAME
+                                       ": %s: Setting %s as primary slave.\n",
+                                       bond->dev->name, slave->dev->name);
+                                bond->primary_slave = slave;
+                                bond_select_active_slave(bond);
+                                goto out;
+                        }
+                }
+
+                /* if we got here, then we didn't match the name of any slave */
+
+                if (strlen(buf) == 0 || buf[0] == '\n') {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: Setting primary slave to None.\n",
+                               bond->dev->name);
+                        bond->primary_slave = 0;
+                                bond_select_active_slave(bond);
+                } else {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: Unable to set %.*s as primary slave as it is not a slave.\n",
+                               bond->dev->name, (int)strlen(buf) - 1, buf);
+                }
+        }
+out:
+        write_unlock_bh(&bond->lock);
+        return count;
+}
+static CLASS_DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, bonding_store_primary);
+
+/*
+ * Show and set the use_carrier flag.
+ */
+static ssize_t bonding_show_carrier(struct class_device *cd, char *buf)
+{
+        struct bonding *bond = to_bond(cd);
+
+        return sprintf(buf, "%d\n", bond->params.use_carrier) + 1;
+}
+
+static ssize_t bonding_store_carrier(struct class_device *cd, const char *buf, size_t count)
+{
+        int new_value, ret = count;
+        struct bonding *bond = to_bond(cd);
+
+
+        if (sscanf(buf, "%d", &new_value) != 1) {
+                printk(KERN_ERR DRV_NAME
+                       ": %s: no use_carrier value specified.\n",
+                       bond->dev->name);
+                ret = -EINVAL;
+                goto out;
+        }
+        if ((new_value == 0) || (new_value == 1)) {
+                bond->params.use_carrier = new_value;
+                printk(KERN_INFO DRV_NAME ": %s: Setting use_carrier to %d.\n",
+                       bond->dev->name, new_value);
+        } else {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: Ignoring invalid use_carrier value %d.\n",
+                       bond->dev->name, new_value);
+        }
+out:
+        return count;
+}
+static CLASS_DEVICE_ATTR(use_carrier, S_IRUGO | S_IWUSR, bonding_show_carrier, bonding_store_carrier);
+
+
+/*
+ * Show and set currently active_slave.
+ */
+static ssize_t bonding_show_active_slave(struct class_device *cd, char *buf)
+{
+        struct slave *curr;
+        struct bonding *bond = to_bond(cd);
+        int count;
+
+
+        read_lock(&bond->curr_slave_lock);
+        curr = bond->curr_active_slave;
+        read_unlock(&bond->curr_slave_lock);
+
+        if (USES_PRIMARY(bond->params.mode) && curr)
+                count = sprintf(buf, "%s\n", curr->dev->name) + 1;
+        else
+                count = sprintf(buf, "\n") + 1;
+        return count;
+}
+
+static ssize_t bonding_store_active_slave(struct class_device *cd, const char *buf, size_t count)
+{
+        int i;
+        struct slave *slave;
+        struct slave *old_active = NULL;
+        struct slave *new_active = NULL;
+        struct bonding *bond = to_bond(cd);
+
+        write_lock_bh(&bond->lock);
+        if (!USES_PRIMARY(bond->params.mode)) {
+                printk(KERN_INFO DRV_NAME
+                       ": %s: Unable to change active slave; %s is in mode %d\n",
+                       bond->dev->name, bond->dev->name, bond->params.mode);
+        } else {
+                bond_for_each_slave(bond, slave, i) {
+                        if (strnicmp
+                            (slave->dev->name, buf,
+                             strlen(slave->dev->name)) == 0) {
+                                old_active = bond->curr_active_slave;
+                                new_active = slave;
+                                if (new_active && (new_active == old_active)) {
+                                        /* do nothing */
+                                        printk(KERN_INFO DRV_NAME
+                                               ": %s: %s is already the current active slave.\n",
+                                               bond->dev->name, slave->dev->name);
+                                        goto out;
+                                }
+                                else {
+                                        if ((new_active) &&
+                                            (old_active) &&
+                                            (new_active->link == BOND_LINK_UP) &&
+                                            IS_UP(new_active->dev)) {
+                                                printk(KERN_INFO DRV_NAME
+                                                      ": %s: Setting %s as active slave.\n",
+                                                      bond->dev->name, slave->dev->name);
+                                                bond_change_active_slave(bond, new_active);
+                                        }
+                                        else {
+                                                printk(KERN_INFO DRV_NAME
+                                                      ": %s: Could not set %s as active slave; "
+                                                      "either %s is down or the link is down.\n",
+                                                      bond->dev->name, slave->dev->name,
+                                                      slave->dev->name);
+                                        }
+                                        goto out;
+                                }
+                        }
+                }
+
+                /* if we got here, then we didn't match the name of any slave */
+
+                if (strlen(buf) == 0 || buf[0] == '\n') {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: Setting active slave to None.\n",
+                               bond->dev->name);
+                        bond->primary_slave = 0;
+                                bond_select_active_slave(bond);
+                } else {
+                        printk(KERN_INFO DRV_NAME
+                               ": %s: Unable to set %.*s as active slave as it is not a slave.\n",
+                               bond->dev->name, (int)strlen(buf) - 1, buf);
+                }
+        }
+out:
+        write_unlock_bh(&bond->lock);
+        return count;
+
+}
+static CLASS_DEVICE_ATTR(active_slave, S_IRUGO | S_IWUSR, bonding_show_active_slave, bonding_store_active_slave);
+
+
+/*
+ * Show link status of the bond interface.
+ */
+static ssize_t bonding_show_mii_status(struct class_device *cd, char *buf)
+{
+        struct slave *curr;
+        struct bonding *bond = to_bond(cd);
+
+        read_lock(&bond->curr_slave_lock);
+        curr = bond->curr_active_slave;
+        read_unlock(&bond->curr_slave_lock);
+
+        return sprintf(buf, "%s\n", (curr) ? "up" : "down") + 1;
+}
+static CLASS_DEVICE_ATTR(mii_status, S_IRUGO, bonding_show_mii_status, NULL);
+
+
+/*
+ * Show current 802.3ad aggregator ID.
+ */
+static ssize_t bonding_show_ad_aggregator(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->params.mode == BOND_MODE_8023AD) {
+                struct ad_info ad_info;
+                count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ?  0 : ad_info.aggregator_id) + 1;
+        }
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+static CLASS_DEVICE_ATTR(ad_aggregator, S_IRUGO, bonding_show_ad_aggregator, NULL);
+
+
+/*
+ * Show number of active 802.3ad ports.
+ */
+static ssize_t bonding_show_ad_num_ports(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->params.mode == BOND_MODE_8023AD) {
+                struct ad_info ad_info;
+                count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ?  0: ad_info.ports) + 1;
+        }
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+static CLASS_DEVICE_ATTR(ad_num_ports, S_IRUGO, bonding_show_ad_num_ports, NULL);
+
+
+/*
+ * Show current 802.3ad actor key.
+ */
+static ssize_t bonding_show_ad_actor_key(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->params.mode == BOND_MODE_8023AD) {
+                struct ad_info ad_info;
+                count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ?  0 : ad_info.actor_key) + 1;
+        }
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+static CLASS_DEVICE_ATTR(ad_actor_key, S_IRUGO, bonding_show_ad_actor_key, NULL);
+
+
+/*
+ * Show current 802.3ad partner key.
+ */
+static ssize_t bonding_show_ad_partner_key(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->params.mode == BOND_MODE_8023AD) {
+                struct ad_info ad_info;
+                count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ?  0 : ad_info.partner_key) + 1;
+        }
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+static CLASS_DEVICE_ATTR(ad_partner_key, S_IRUGO, bonding_show_ad_partner_key, NULL);
+
+
+/*
+ * Show current 802.3ad partner mac.
+ */
+static ssize_t bonding_show_ad_partner_mac(struct class_device *cd, char *buf)
+{
+        int count = 0;
+        struct bonding *bond = to_bond(cd);
+
+        if (bond->params.mode == BOND_MODE_8023AD) {
+                struct ad_info ad_info;
+                if (!bond_3ad_get_active_agg_info(bond, &ad_info)) {
+                        count = sprintf(buf,"%02x:%02x:%02x:%02x:%02x:%02x\n",
+                                       ad_info.partner_system[0],
+                                       ad_info.partner_system[1],
+                                       ad_info.partner_system[2],
+                                       ad_info.partner_system[3],
+                                       ad_info.partner_system[4],
+                                       ad_info.partner_system[5]) + 1;
+                }
+        }
+        else
+                count = sprintf(buf, "\n") + 1;
+
+        return count;
+}
+static CLASS_DEVICE_ATTR(ad_partner_mac, S_IRUGO, bonding_show_ad_partner_mac, NULL);
+
+
+
+static struct attribute *per_bond_attrs[] = {
+        &class_device_attr_slaves.attr,
+        &class_device_attr_mode.attr,
+        &class_device_attr_arp_interval.attr,
+        &class_device_attr_arp_ip_target.attr,
+        &class_device_attr_downdelay.attr,
+        &class_device_attr_updelay.attr,
+        &class_device_attr_lacp_rate.attr,
+        &class_device_attr_xmit_hash_policy.attr,
+        &class_device_attr_miimon.attr,
+        &class_device_attr_primary.attr,
+        &class_device_attr_use_carrier.attr,
+        &class_device_attr_active_slave.attr,
+        &class_device_attr_mii_status.attr,
+        &class_device_attr_ad_aggregator.attr,
+        &class_device_attr_ad_num_ports.attr,
+        &class_device_attr_ad_actor_key.attr,
+        &class_device_attr_ad_partner_key.attr,
+        &class_device_attr_ad_partner_mac.attr,
+        NULL,
+};
+
+static struct attribute_group bonding_group = {
+        .name = "bonding",
+        .attrs = per_bond_attrs,
+};
+
+/*
+ * Initialize sysfs.  This sets up the bonding_masters file in
+ * /sys/class/net.
+ */
+int bond_create_sysfs(void)
+{
+        int ret = 0;
+        struct bonding *firstbond;
+
+        init_rwsem(&bonding_rwsem);
+
+        /* get the netdev class pointer */
+        firstbond = container_of(bond_dev_list.next, struct bonding, bond_list);
+        if (!firstbond)
+                return -ENODEV;
+
+        netdev_class = firstbond->dev->class_dev.class;
+        if (!netdev_class)
+                return -ENODEV;
+
+        ret = class_create_file(netdev_class, &class_attr_bonding_masters);
+
+        return ret;
+
+}
+
+/*
+ * Remove /sys/class/net/bonding_masters.
+ */
+void bond_destroy_sysfs(void)
+{
+        if (netdev_class)
+                class_remove_file(netdev_class, &class_attr_bonding_masters);
+}
+
+/*
+ * Initialize sysfs for each bond.  This sets up and registers
+ * the 'bondctl' directory for each individual bond under /sys/class/net.
+ */
+int bond_create_sysfs_entry(struct bonding *bond)
+{
+        struct net_device *dev = bond->dev;
+        int err;
+
+        err = sysfs_create_group(&(dev->class_dev.kobj), &bonding_group);
+        if (err) {
+                printk(KERN_EMERG "eek! didn't create group!\n");
+        }
+
+        if (expected_refcount < 1)
+                expected_refcount = atomic_read(&bond->dev->class_dev.kobj.kref.refcount);
+
+        return err;
+}
+/*
+ * Remove sysfs entries for each bond.
+ */
+void bond_destroy_sysfs_entry(struct bonding *bond)
+{
+        struct net_device *dev = bond->dev;
+
+        sysfs_remove_group(&(dev->class_dev.kobj), &bonding_group);
+}
+
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 1433e91db0f7..d6d085480f21 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -29,6 +29,10 @@
  * 2005/05/05 - Jason Gabler <jygabler at lbl dot gov>
  *      - added "xmit_policy" kernel parameter for alternate hashing policy
  *        support for mode 2
+ *
+ * 2005/09/27 - Mitch Williams <mitch.a.williams at intel dot com>
+ *              Radheka Godse <radheka.godse at intel dot com>
+ *      - Added bonding sysfs interface
  */
 
 #ifndef _LINUX_BONDING_H
@@ -37,11 +41,12 @@
 #include <linux/timer.h>
 #include <linux/proc_fs.h>
 #include <linux/if_bonding.h>
+#include <linux/kobject.h>
 #include "bond_3ad.h"
 #include "bond_alb.h"
 
-#define DRV_VERSION     "2.6.5"
-#define DRV_RELDATE     "November 4, 2005"
+#define DRV_VERSION     "3.0.0"
+#define DRV_RELDATE     "November 8, 2005"
 #define DRV_NAME        "bonding"
 #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver"
 
@@ -152,6 +157,11 @@ struct bond_params {
         u32 arp_targets[BOND_MAX_ARP_TARGETS];
 };
 
+struct bond_parm_tbl {
+        char *modename;
+        int mode;
+};
+
 struct vlan_entry {
         struct list_head vlan_list;
         u32 vlan_ip;
@@ -159,7 +169,7 @@ struct vlan_entry {
 };
 
 struct slave {
-        struct net_device *dev; /* first - usefull for panic debug */
+        struct net_device *dev; /* first - useful for panic debug */
         struct slave *next;
         struct slave *prev;
         s16    delay;
@@ -185,7 +195,7 @@ struct slave {
  *    beforehand.
  */
 struct bonding {
-        struct   net_device *dev; /* first - usefull for panic debug */
+        struct   net_device *dev; /* first - useful for panic debug */
         struct   slave *first_slave;
         struct   slave *curr_active_slave;
         struct   slave *current_arp_slave;
@@ -255,6 +265,25 @@ extern inline void bond_set_slave_active_flags(struct slave *slave)
 
 struct vlan_entry *bond_next_vlan(struct bonding *bond, struct vlan_entry *curr);
 int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, struct net_device *slave_dev);
+int bond_create(char *name, struct bond_params *params, struct bonding **newbond);
+void bond_deinit(struct net_device *bond_dev);
+int bond_create_sysfs(void);
+void bond_destroy_sysfs(void);
+void bond_destroy_sysfs_entry(struct bonding *bond);
+int bond_create_sysfs_entry(struct bonding *bond);
+int bond_create_slave_symlinks(struct net_device *master, struct net_device *slave);
+void bond_destroy_slave_symlinks(struct net_device *master, struct net_device *slave);
+int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev);
+int bond_release(struct net_device *bond_dev, struct net_device *slave_dev);
+int bond_sethwaddr(struct net_device *bond_dev, struct net_device *slave_dev);
+void bond_mii_monitor(struct net_device *bond_dev);
+void bond_loadbalance_arp_mon(struct net_device *bond_dev);
+void bond_activebackup_arp_mon(struct net_device *bond_dev);
+void bond_set_mode_ops(struct bonding *bond, int mode);
+int bond_parse_parm(char *mode_arg, struct bond_parm_tbl *tbl);
+const char *bond_mode_name(int mode);
+void bond_select_active_slave(struct bonding *bond);
+void bond_change_active_slave(struct bonding *bond, struct slave *new_active);
 
 #endif /* _LINUX_BONDING_H */
 
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index e3a329539f1c..0f030b73cbb3 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -6,7 +6,7 @@
  * Based on 8260_io/fcc_enet.c
  *
  * Author: Andy Fleming
- * Maintainer: Kumar Gala (kumar.gala@freescale.com)
+ * Maintainer: Kumar Gala
  *
  * Copyright (c) 2002-2004 Freescale Semiconductor, Inc.
  *
diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index 220084e53341..5065ba82cb76 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -6,7 +6,7 @@
  * Based on 8260_io/fcc_enet.c
  *
  * Author: Andy Fleming
- * Maintainer: Kumar Gala (kumar.gala@freescale.com)
+ * Maintainer: Kumar Gala
  *
  * Copyright (c) 2002-2004 Freescale Semiconductor, Inc.
  *
diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index 5a2d810ce575..cfa3cd7c91a0 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -6,7 +6,7 @@
  *  Based on e1000 ethtool support
  *
  *  Author: Andy Fleming
- *  Maintainer: Kumar Gala (kumar.gala@freescale.com)
+ *  Maintainer: Kumar Gala
  *
  *  Copyright (c) 2003,2004 Freescale Semiconductor, Inc.
  *
diff --git a/drivers/net/gianfar_mii.c b/drivers/net/gianfar_mii.c
index 9544279e8bcd..04a462c2a5b7 100644
--- a/drivers/net/gianfar_mii.c
+++ b/drivers/net/gianfar_mii.c
@@ -5,7 +5,7 @@
  * Provides Bus interface for MIIM regs
  *
  * Author: Andy Fleming
- * Maintainer: Kumar Gala (kumar.gala@freescale.com)
+ * Maintainer: Kumar Gala
  *
  * Copyright (c) 2002-2004 Freescale Semiconductor, Inc.
  *
diff --git a/drivers/net/gianfar_mii.h b/drivers/net/gianfar_mii.h
index 56e5665d5c9b..e85eb216fb5b 100644
--- a/drivers/net/gianfar_mii.h
+++ b/drivers/net/gianfar_mii.h
@@ -5,7 +5,7 @@
  * Driver for the MDIO bus controller in the Gianfar register space
  *
  * Author: Andy Fleming
- * Maintainer: Kumar Gala (kumar.gala@freescale.com)
+ * Maintainer: Kumar Gala
  *
  * Copyright (c) 2002-2004 Freescale Semiconductor, Inc.
  *
diff --git a/drivers/net/irda/ali-ircc.c b/drivers/net/irda/ali-ircc.c
index 9bf34681d3df..2e7882eb7d6f 100644
--- a/drivers/net/irda/ali-ircc.c
+++ b/drivers/net/irda/ali-ircc.c
@@ -40,6 +40,7 @@
 #include <asm/byteorder.h>
 
 #include <linux/pm.h>
+#include <linux/pm_legacy.h>
 
 #include <net/irda/wrapper.h>
 #include <net/irda/irda.h>
diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c
index 805714ec9a8a..ee717d0e939e 100644
--- a/drivers/net/irda/nsc-ircc.c
+++ b/drivers/net/irda/nsc-ircc.c
@@ -59,6 +59,7 @@
 #include <asm/byteorder.h>
 
 #include <linux/pm.h>
+#include <linux/pm_legacy.h>
 
 #include <net/irda/wrapper.h>
 #include <net/irda/irda.h>
diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c
index 1d4d88680db1..3d95fa20cd88 100644
--- a/drivers/net/sis900.c
+++ b/drivers/net/sis900.c
@@ -1,6 +1,6 @@
 /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
    Copyright 1999 Silicon Integrated System Corporation 
-   Revision:    1.08.08 Jan. 22 2005
+   Revision:    1.08.09 Sep. 19 2005
    
    Modified from the driver which is originally written by Donald Becker.
    
@@ -17,6 +17,7 @@
    SiS 7014 Single Chip 100BASE-TX/10BASE-T Physical Layer Solution,
    preliminary Rev. 1.0 Jan. 18, 1998
 
+   Rev 1.08.09 Sep. 19 2005 Daniele Venzano add Wake on LAN support
    Rev 1.08.08 Jan. 22 2005 Daniele Venzano use netif_msg for debugging messages
    Rev 1.08.07 Nov.  2 2003 Daniele Venzano <webvenza@libero.it> add suspend/resume support
    Rev 1.08.06 Sep. 24 2002 Mufasa Yang bug fix for Tx timeout & add SiS963 support
@@ -76,7 +77,7 @@
 #include "sis900.h"
 
 #define SIS900_MODULE_NAME "sis900"
-#define SIS900_DRV_VERSION "v1.08.08 Jan. 22 2005"
+#define SIS900_DRV_VERSION "v1.08.09 Sep. 19 2005"
 
 static char version[] __devinitdata =
 KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";
@@ -538,6 +539,11 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
                 printk("%2.2x:", (u8)net_dev->dev_addr[i]);
         printk("%2.2x.\n", net_dev->dev_addr[i]);
 
+        /* Detect Wake on Lan support */
+        ret = inl(CFGPMC & PMESP);
+        if (netif_msg_probe(sis_priv) && (ret & PME_D3C) == 0)
+                printk(KERN_INFO "%s: Wake on LAN only available from suspend to RAM.", net_dev->name);
+
         return 0;
 
  err_unmap_rx:
@@ -2015,6 +2021,67 @@ static int sis900_nway_reset(struct net_device *net_dev)
         return mii_nway_restart(&sis_priv->mii_info);
 }
 
+/**
+ *      sis900_set_wol - Set up Wake on Lan registers
+ *      @net_dev: the net device to probe
+ *      @wol: container for info passed to the driver
+ *
+ *      Process ethtool command "wol" to setup wake on lan features.
+ *      SiS900 supports sending WoL events if a correct packet is received,
+ *      but there is no simple way to filter them to only a subset (broadcast,
+ *      multicast, unicast or arp).
+ */
+ 
+static int sis900_set_wol(struct net_device *net_dev, struct ethtool_wolinfo *wol)
+{
+        struct sis900_private *sis_priv = net_dev->priv;
+        long pmctrl_addr = net_dev->base_addr + pmctrl;
+        u32 cfgpmcsr = 0, pmctrl_bits = 0;
+
+        if (wol->wolopts == 0) {
+                pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR, &cfgpmcsr);
+                cfgpmcsr |= ~PME_EN;
+                pci_write_config_dword(sis_priv->pci_dev, CFGPMCSR, cfgpmcsr);
+                outl(pmctrl_bits, pmctrl_addr);
+                if (netif_msg_wol(sis_priv))
+                        printk(KERN_DEBUG "%s: Wake on LAN disabled\n", net_dev->name);
+                return 0;
+        }
+
+        if (wol->wolopts & (WAKE_MAGICSECURE | WAKE_UCAST | WAKE_MCAST
+                                | WAKE_BCAST | WAKE_ARP))
+                return -EINVAL;
+
+        if (wol->wolopts & WAKE_MAGIC)
+                pmctrl_bits |= MAGICPKT;
+        if (wol->wolopts & WAKE_PHY)
+                pmctrl_bits |= LINKON;
+        
+        outl(pmctrl_bits, pmctrl_addr);
+
+        pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR, &cfgpmcsr);
+        cfgpmcsr |= PME_EN;
+        pci_write_config_dword(sis_priv->pci_dev, CFGPMCSR, cfgpmcsr);
+        if (netif_msg_wol(sis_priv))
+                printk(KERN_DEBUG "%s: Wake on LAN enabled\n", net_dev->name);
+
+        return 0;
+}
+
+static void sis900_get_wol(struct net_device *net_dev, struct ethtool_wolinfo *wol)
+{
+        long pmctrl_addr = net_dev->base_addr + pmctrl;
+        u32 pmctrl_bits;
+
+        pmctrl_bits = inl(pmctrl_addr);
+        if (pmctrl_bits & MAGICPKT)
+                wol->wolopts |= WAKE_MAGIC;
+        if (pmctrl_bits & LINKON)
+                wol->wolopts |= WAKE_PHY;
+
+        wol->supported = (WAKE_PHY | WAKE_MAGIC);
+}
+
 static struct ethtool_ops sis900_ethtool_ops = {
         .get_drvinfo    = sis900_get_drvinfo,
         .get_msglevel   = sis900_get_msglevel,
@@ -2023,6 +2090,8 @@ static struct ethtool_ops sis900_ethtool_ops = {
         .get_settings   = sis900_get_settings,
         .set_settings   = sis900_set_settings,
         .nway_reset     = sis900_nway_reset,
+        .get_wol        = sis900_get_wol,
+        .set_wol        = sis900_set_wol
 };
 
 /**
diff --git a/drivers/net/sis900.h b/drivers/net/sis900.h
index de3c06735d15..4233ea55670f 100644
--- a/drivers/net/sis900.h
+++ b/drivers/net/sis900.h
@@ -33,6 +33,7 @@ enum sis900_registers {
         rxcfg=0x34,             //Receive Configuration Register
         flctrl=0x38,            //Flow Control Register
         rxlen=0x3c,             //Receive Packet Length Register
+        cfgpmcsr=0x44,          //Configuration Power Management Control/Status Register
         rfcr=0x48,              //Receive Filter Control Register
         rfdr=0x4C,              //Receive Filter Data Register
         pmctrl=0xB0,            //Power Management Control Register
@@ -140,6 +141,50 @@ enum sis96x_eeprom_command {
         EEREQ = 0x00000400, EEDONE = 0x00000200, EEGNT = 0x00000100
 };
 
+/* PCI Registers */
+enum sis900_pci_registers {
+        CFGPMC   = 0x40,
+        CFGPMCSR = 0x44
+};
+
+/* Power management capabilities bits */
+enum sis900_cfgpmc_register_bits {
+        PMVER   = 0x00070000, 
+        DSI     = 0x00100000,
+        PMESP   = 0xf8000000
+};
+
+enum sis900_pmesp_bits {
+        PME_D0 = 0x1,
+        PME_D1 = 0x2,
+        PME_D2 = 0x4,
+        PME_D3H = 0x8,
+        PME_D3C = 0x10
+};
+
+/* Power management control/status bits */
+enum sis900_cfgpmcsr_register_bits {
+        PMESTS = 0x00004000,
+        PME_EN = 0x00000100, // Power management enable
+        PWR_STA = 0x00000003 // Current power state
+};
+
+/* Wake-on-LAN support. */
+enum sis900_power_management_control_register_bits {
+        LINKLOSS  = 0x00000001,
+        LINKON    = 0x00000002,
+        MAGICPKT  = 0x00000400,
+        ALGORITHM = 0x00000800,
+        FRM1EN    = 0x00100000,
+        FRM2EN    = 0x00200000,
+        FRM3EN    = 0x00400000,
+        FRM1ACS   = 0x01000000,
+        FRM2ACS   = 0x02000000,
+        FRM3ACS   = 0x04000000,
+        WAKEALL   = 0x40000000,
+        GATECLK   = 0x80000000
+};
+
 /* Management Data I/O (mdio) frame */
 #define MIIread         0x6000
 #define MIIwrite        0x5002
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
new file mode 100644
index 000000000000..9f89000e5ad5
--- /dev/null
+++ b/drivers/net/sky2.c
@@ -0,0 +1,3039 @@
+/*
+ * New driver for Marvell Yukon 2 chipset.
+ * Based on earlier sk98lin, and skge driver.
+ *
+ * This driver intentionally does not support all the features
+ * of the original driver such as link fail-over and link management because
+ * those should be done at higher levels.
+ *
+ * Copyright (C) 2005 Stephen Hemminger <shemminger@osdl.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+/*
+ * TODO
+ *      - coalescing setting?
+ *
+ * TOTEST
+ *      - speed setting
+ *      - suspend/resume
+ */
+
+#include <linux/config.h>
+#include <linux/crc32.h>
+#include <linux/kernel.h>
+#include <linux/version.h>
+#include <linux/module.h>
+#include <linux/netdevice.h>
+#include <linux/dma-mapping.h>
+#include <linux/etherdevice.h>
+#include <linux/ethtool.h>
+#include <linux/pci.h>
+#include <linux/ip.h>
+#include <linux/tcp.h>
+#include <linux/in.h>
+#include <linux/delay.h>
+#include <linux/if_vlan.h>
+
+#include <asm/irq.h>
+
+#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
+#define SKY2_VLAN_TAG_USED 1
+#endif
+
+#include "sky2.h"
+
+#define DRV_NAME                "sky2"
+#define DRV_VERSION             "0.7"
+#define PFX                     DRV_NAME " "
+
+/*
+ * The Yukon II chipset takes 64 bit command blocks (called list elements)
+ * that are organized into three (receive, transmit, status) different rings
+ * similar to Tigon3. A transmit can require several elements;
+ * a receive requires one (or two if using 64 bit dma).
+ */
+
+#ifdef CONFIG_SKY2_EC_A1
+#define is_ec_a1(hw) \
+        ((hw)->chip_id == CHIP_ID_YUKON_EC && \
+         (hw)->chip_rev == CHIP_REV_YU_EC_A1)
+#else
+#define is_ec_a1(hw)    0
+#endif
+
+#define RX_LE_SIZE              256
+#define RX_LE_BYTES             (RX_LE_SIZE*sizeof(struct sky2_rx_le))
+#define RX_MAX_PENDING          (RX_LE_SIZE/2 - 2)
+#define RX_DEF_PENDING          128
+#define RX_COPY_THRESHOLD       256
+
+#define TX_RING_SIZE            512
+#define TX_DEF_PENDING          (TX_RING_SIZE - 1)
+#define TX_MIN_PENDING          64
+#define MAX_SKB_TX_LE           (4 + 2*MAX_SKB_FRAGS)
+
+#define STATUS_RING_SIZE        2048    /* 2 ports * (TX + 2*RX) */
+#define STATUS_LE_BYTES         (STATUS_RING_SIZE*sizeof(struct sky2_status_le))
+#define ETH_JUMBO_MTU           9000
+#define TX_WATCHDOG             (5 * HZ)
+#define NAPI_WEIGHT             64
+#define PHY_RETRIES             1000
+
+static const u32 default_msg =
+    NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK
+    | NETIF_MSG_TIMER | NETIF_MSG_TX_ERR | NETIF_MSG_RX_ERR
+    | NETIF_MSG_IFUP | NETIF_MSG_IFDOWN | NETIF_MSG_INTR;
+
+static int debug = -1;          /* defaults above */
+module_param(debug, int, 0);
+MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
+
+static const struct pci_device_id sky2_id_table[] = {
+        { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9000) },
+        { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9E00) },
+        { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b00) },
+        { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4340) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4341) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4342) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4343) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4344) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4345) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4346) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4347) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4350) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4351) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4360) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4361) },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4362) },
+        { 0 }
+};
+
+MODULE_DEVICE_TABLE(pci, sky2_id_table);
+
+/* Avoid conditionals by using array */
+static const unsigned txqaddr[] = { Q_XA1, Q_XA2 };
+static const unsigned rxqaddr[] = { Q_R1, Q_R2 };
+
+static const char *yukon_name[] = {
+        [CHIP_ID_YUKON_LITE - CHIP_ID_YUKON] = "Lite",  /* 0xb0 */
+        [CHIP_ID_YUKON_LP - CHIP_ID_YUKON] = "LP",      /* 0xb2 */
+        [CHIP_ID_YUKON_XL - CHIP_ID_YUKON] = "XL",      /* 0xb3 */
+
+        [CHIP_ID_YUKON_EC - CHIP_ID_YUKON] = "EC",      /* 0xb6 */
+        [CHIP_ID_YUKON_FE - CHIP_ID_YUKON] = "FE",      /* 0xb7 */
+};
+
+
+/* Access to external PHY */
+static void gm_phy_write(struct sky2_hw *hw, unsigned port, u16 reg, u16 val)
+{
+        int i;
+
+        gma_write16(hw, port, GM_SMI_DATA, val);
+        gma_write16(hw, port, GM_SMI_CTRL,
+                    GM_SMI_CT_PHY_AD(PHY_ADDR_MARV) | GM_SMI_CT_REG_AD(reg));
+
+        for (i = 0; i < PHY_RETRIES; i++) {
+                if (!(gma_read16(hw, port, GM_SMI_CTRL) & GM_SMI_CT_BUSY))
+                        return;
+                udelay(1);
+        }
+        printk(KERN_WARNING PFX "%s: phy write timeout\n", hw->dev[port]->name);
+}
+
+static u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg)
+{
+        int i;
+
+        gma_write16(hw, port, GM_SMI_CTRL, GM_SMI_CT_PHY_AD(PHY_ADDR_MARV)
+                    | GM_SMI_CT_REG_AD(reg) | GM_SMI_CT_OP_RD);
+
+        for (i = 0; i < PHY_RETRIES; i++) {
+                if (gma_read16(hw, port, GM_SMI_CTRL) & GM_SMI_CT_RD_VAL)
+                        goto ready;
+                udelay(1);
+        }
+
+        printk(KERN_WARNING PFX "%s: phy read timeout\n", hw->dev[port]->name);
+ready:
+        return gma_read16(hw, port, GM_SMI_DATA);
+}
+
+static int sky2_set_power_state(struct sky2_hw *hw, pci_power_t state)
+{
+        u16 power_control;
+        u32 reg1;
+        int vaux;
+        int ret = 0;
+
+        pr_debug("sky2_set_power_state %d\n", state);
+        sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+
+        pci_read_config_word(hw->pdev, hw->pm_cap + PCI_PM_PMC, &power_control);
+        vaux = (sky2_read8(hw, B0_CTST) & Y2_VAUX_AVAIL) &&
+                (power_control & PCI_PM_CAP_PME_D3cold);
+
+        pci_read_config_word(hw->pdev, hw->pm_cap + PCI_PM_CTRL, &power_control);
+
+        power_control |= PCI_PM_CTRL_PME_STATUS;
+        power_control &= ~(PCI_PM_CTRL_STATE_MASK);
+
+        switch (state) {
+        case PCI_D0:
+                /* switch power to VCC (WA for VAUX problem) */
+                sky2_write8(hw, B0_POWER_CTRL,
+                            PC_VAUX_ENA | PC_VCC_ENA | PC_VAUX_OFF | PC_VCC_ON);
+
+                /* disable Core Clock Division, */
+                sky2_write32(hw, B2_Y2_CLK_CTRL, Y2_CLK_DIV_DIS);
+
+                if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev > 1)
+                        /* enable bits are inverted */
+                        sky2_write8(hw, B2_Y2_CLK_GATE,
+                                    Y2_PCI_CLK_LNK1_DIS | Y2_COR_CLK_LNK1_DIS |
+                                    Y2_CLK_GAT_LNK1_DIS | Y2_PCI_CLK_LNK2_DIS |
+                                    Y2_COR_CLK_LNK2_DIS | Y2_CLK_GAT_LNK2_DIS);
+                else
+                        sky2_write8(hw, B2_Y2_CLK_GATE, 0);
+
+                /* Turn off phy power saving */
+                pci_read_config_dword(hw->pdev, PCI_DEV_REG1, &reg1);
+                reg1 &= ~(PCI_Y2_PHY1_POWD | PCI_Y2_PHY2_POWD);
+
+                /* looks like this XL is back asswards .. */
+                if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev > 1) {
+                        reg1 |= PCI_Y2_PHY1_COMA;
+                        if (hw->ports > 1)
+                                reg1 |= PCI_Y2_PHY2_COMA;
+                }
+                pci_write_config_dword(hw->pdev, PCI_DEV_REG1, reg1);
+                break;
+
+        case PCI_D3hot:
+        case PCI_D3cold:
+                /* Turn on phy power saving */
+                pci_read_config_dword(hw->pdev, PCI_DEV_REG1, &reg1);
+                if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev > 1)
+                        reg1 &= ~(PCI_Y2_PHY1_POWD | PCI_Y2_PHY2_POWD);
+                else
+                        reg1 |= (PCI_Y2_PHY1_POWD | PCI_Y2_PHY2_POWD);
+                pci_write_config_dword(hw->pdev, PCI_DEV_REG1, reg1);
+
+                if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev > 1)
+                        sky2_write8(hw, B2_Y2_CLK_GATE, 0);
+                else
+                        /* enable bits are inverted */
+                        sky2_write8(hw, B2_Y2_CLK_GATE,
+                                    Y2_PCI_CLK_LNK1_DIS | Y2_COR_CLK_LNK1_DIS |
+                                    Y2_CLK_GAT_LNK1_DIS | Y2_PCI_CLK_LNK2_DIS |
+                                    Y2_COR_CLK_LNK2_DIS | Y2_CLK_GAT_LNK2_DIS);
+
+                /* switch power to VAUX */
+                if (vaux && state != PCI_D3cold)
+                        sky2_write8(hw, B0_POWER_CTRL,
+                                    (PC_VAUX_ENA | PC_VCC_ENA |
+                                     PC_VAUX_ON | PC_VCC_OFF));
+                break;
+        default:
+                printk(KERN_ERR PFX "Unknown power state %d\n", state);
+                ret = -1;
+        }
+
+        pci_write_config_byte(hw->pdev, hw->pm_cap + PCI_PM_CTRL, power_control);
+        sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
+        return ret;
+}
+
+static void sky2_phy_reset(struct sky2_hw *hw, unsigned port)
+{
+        u16 reg;
+
+        /* disable all GMAC IRQ's */
+        sky2_write8(hw, SK_REG(port, GMAC_IRQ_MSK), 0);
+        /* disable PHY IRQs */
+        gm_phy_write(hw, port, PHY_MARV_INT_MASK, 0);
+
+        gma_write16(hw, port, GM_MC_ADDR_H1, 0);        /* clear MC hash */
+        gma_write16(hw, port, GM_MC_ADDR_H2, 0);
+        gma_write16(hw, port, GM_MC_ADDR_H3, 0);
+        gma_write16(hw, port, GM_MC_ADDR_H4, 0);
+
+        reg = gma_read16(hw, port, GM_RX_CTRL);
+        reg |= GM_RXCR_UCF_ENA | GM_RXCR_MCF_ENA;
+        gma_write16(hw, port, GM_RX_CTRL, reg);
+}
+
+static void sky2_phy_init(struct sky2_hw *hw, unsigned port)
+{
+        struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
+        u16 ctrl, ct1000, adv, pg, ledctrl, ledover;
+
+        if (sky2->autoneg == AUTONEG_ENABLE && hw->chip_id != CHIP_ID_YUKON_XL) {
+                u16 ectrl = gm_phy_read(hw, port, PHY_MARV_EXT_CTRL);
+
+                ectrl &= ~(PHY_M_EC_M_DSC_MSK | PHY_M_EC_S_DSC_MSK |
+                           PHY_M_EC_MAC_S_MSK);
+                ectrl |= PHY_M_EC_MAC_S(MAC_TX_CLK_25_MHZ);
+
+                if (hw->chip_id == CHIP_ID_YUKON_EC)
+                        ectrl |= PHY_M_EC_DSC_2(2) | PHY_M_EC_DOWN_S_ENA;
+                else
+                        ectrl |= PHY_M_EC_M_DSC(2) | PHY_M_EC_S_DSC(3);
+
+                gm_phy_write(hw, port, PHY_MARV_EXT_CTRL, ectrl);
+        }
+
+        ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
+        if (hw->copper) {
+                if (hw->chip_id == CHIP_ID_YUKON_FE) {
+                        /* enable automatic crossover */
+                        ctrl |= PHY_M_PC_MDI_XMODE(PHY_M_PC_ENA_AUTO) >> 1;
+                } else {
+                        /* disable energy detect */
+                        ctrl &= ~PHY_M_PC_EN_DET_MSK;
+
+                        /* enable automatic crossover */
+                        ctrl |= PHY_M_PC_MDI_XMODE(PHY_M_PC_ENA_AUTO);
+
+                        if (sky2->autoneg == AUTONEG_ENABLE &&
+                            hw->chip_id == CHIP_ID_YUKON_XL) {
+                                ctrl &= ~PHY_M_PC_DSC_MSK;
+                                ctrl |= PHY_M_PC_DSC(2) | PHY_M_PC_DOWN_S_ENA;
+                        }
+                }
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl);
+        } else {
+                /* workaround for deviation #4.88 (CRC errors) */
+                /* disable Automatic Crossover */
+
+                ctrl &= ~PHY_M_PC_MDIX_MSK;
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl);
+
+                if (hw->chip_id == CHIP_ID_YUKON_XL) {
+                        /* Fiber: select 1000BASE-X only mode MAC Specific Ctrl Reg. */
+                        gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 2);
+                        ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
+                        ctrl &= ~PHY_M_MAC_MD_MSK;
+                        ctrl |= PHY_M_MAC_MODE_SEL(PHY_M_MAC_MD_1000BX);
+                        gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl);
+
+                        /* select page 1 to access Fiber registers */
+                        gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 1);
+                }
+        }
+
+        ctrl = gm_phy_read(hw, port, PHY_MARV_CTRL);
+        if (sky2->autoneg == AUTONEG_DISABLE)
+                ctrl &= ~PHY_CT_ANE;
+        else
+                ctrl |= PHY_CT_ANE;
+
+        ctrl |= PHY_CT_RESET;
+        gm_phy_write(hw, port, PHY_MARV_CTRL, ctrl);
+
+        ctrl = 0;
+        ct1000 = 0;
+        adv = PHY_AN_CSMA;
+
+        if (sky2->autoneg == AUTONEG_ENABLE) {
+                if (hw->copper) {
+                        if (sky2->advertising & ADVERTISED_1000baseT_Full)
+                                ct1000 |= PHY_M_1000C_AFD;
+                        if (sky2->advertising & ADVERTISED_1000baseT_Half)
+                                ct1000 |= PHY_M_1000C_AHD;
+                        if (sky2->advertising & ADVERTISED_100baseT_Full)
+                                adv |= PHY_M_AN_100_FD;
+                        if (sky2->advertising & ADVERTISED_100baseT_Half)
+                                adv |= PHY_M_AN_100_HD;
+                        if (sky2->advertising & ADVERTISED_10baseT_Full)
+                                adv |= PHY_M_AN_10_FD;
+                        if (sky2->advertising & ADVERTISED_10baseT_Half)
+                                adv |= PHY_M_AN_10_HD;
+                } else          /* special defines for FIBER (88E1011S only) */
+                        adv |= PHY_M_AN_1000X_AHD | PHY_M_AN_1000X_AFD;
+
+                /* Set Flow-control capabilities */
+                if (sky2->tx_pause && sky2->rx_pause)
+                        adv |= PHY_AN_PAUSE_CAP;        /* symmetric */
+                else if (sky2->rx_pause && !sky2->tx_pause)
+                        adv |= PHY_AN_PAUSE_ASYM | PHY_AN_PAUSE_CAP;
+                else if (!sky2->rx_pause && sky2->tx_pause)
+                        adv |= PHY_AN_PAUSE_ASYM;       /* local */
+
+                /* Restart Auto-negotiation */
+                ctrl |= PHY_CT_ANE | PHY_CT_RE_CFG;
+        } else {
+                /* forced speed/duplex settings */
+                ct1000 = PHY_M_1000C_MSE;
+
+                if (sky2->duplex == DUPLEX_FULL)
+                        ctrl |= PHY_CT_DUP_MD;
+
+                switch (sky2->speed) {
+                case SPEED_1000:
+                        ctrl |= PHY_CT_SP1000;
+                        break;
+                case SPEED_100:
+                        ctrl |= PHY_CT_SP100;
+                        break;
+                }
+
+                ctrl |= PHY_CT_RESET;
+        }
+
+        if (hw->chip_id != CHIP_ID_YUKON_FE)
+                gm_phy_write(hw, port, PHY_MARV_1000T_CTRL, ct1000);
+
+        gm_phy_write(hw, port, PHY_MARV_AUNE_ADV, adv);
+        gm_phy_write(hw, port, PHY_MARV_CTRL, ctrl);
+
+        /* Setup Phy LED's */
+        ledctrl = PHY_M_LED_PULS_DUR(PULS_170MS);
+        ledover = 0;
+
+        switch (hw->chip_id) {
+        case CHIP_ID_YUKON_FE:
+                /* on 88E3082 these bits are at 11..9 (shifted left) */
+                ledctrl |= PHY_M_LED_BLINK_RT(BLINK_84MS) << 1;
+
+                ctrl = gm_phy_read(hw, port, PHY_MARV_FE_LED_PAR);
+
+                /* delete ACT LED control bits */
+                ctrl &= ~PHY_M_FELP_LED1_MSK;
+                /* change ACT LED control to blink mode */
+                ctrl |= PHY_M_FELP_LED1_CTRL(LED_PAR_CTRL_ACT_BL);
+                gm_phy_write(hw, port, PHY_MARV_FE_LED_PAR, ctrl);
+                break;
+
+        case CHIP_ID_YUKON_XL:
+                pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
+
+                /* select page 3 to access LED control register */
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
+
+                /* set LED Function Control register */
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, (PHY_M_LEDC_LOS_CTRL(1) |     /* LINK/ACT */
+                                                           PHY_M_LEDC_INIT_CTRL(7) |    /* 10 Mbps */
+                                                           PHY_M_LEDC_STA1_CTRL(7) |    /* 100 Mbps */
+                                                           PHY_M_LEDC_STA0_CTRL(7)));   /* 1000 Mbps */
+
+                /* set Polarity Control register */
+                gm_phy_write(hw, port, PHY_MARV_PHY_STAT,
+                             (PHY_M_POLC_LS1_P_MIX(4) |
+                              PHY_M_POLC_IS0_P_MIX(4) |
+                              PHY_M_POLC_LOS_CTRL(2) |
+                              PHY_M_POLC_INIT_CTRL(2) |
+                              PHY_M_POLC_STA1_CTRL(2) |
+                              PHY_M_POLC_STA0_CTRL(2)));
+
+                /* restore page register */
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
+                break;
+
+        default:
+                /* set Tx LED (LED_TX) to blink mode on Rx OR Tx activity */
+                ledctrl |= PHY_M_LED_BLINK_RT(BLINK_84MS) | PHY_M_LEDC_TX_CTRL;
+                /* turn off the Rx LED (LED_RX) */
+                ledover |= PHY_M_LED_MO_RX(MO_LED_OFF);
+        }
+
+        gm_phy_write(hw, port, PHY_MARV_LED_CTRL, ledctrl);
+
+        if (sky2->autoneg == AUTONEG_DISABLE || sky2->speed == SPEED_100) {
+                /* turn on 100 Mbps LED (LED_LINK100) */
+                ledover |= PHY_M_LED_MO_100(MO_LED_ON);
+        }
+
+        if (ledover)
+                gm_phy_write(hw, port, PHY_MARV_LED_OVER, ledover);
+
+        /* Enable phy interrupt on auto-negotiation complete (or link up) */
+        if (sky2->autoneg == AUTONEG_ENABLE)
+                gm_phy_write(hw, port, PHY_MARV_INT_MASK, PHY_M_IS_AN_COMPL);
+        else
+                gm_phy_write(hw, port, PHY_MARV_INT_MASK, PHY_M_DEF_MSK);
+}
+
+static void sky2_mac_init(struct sky2_hw *hw, unsigned port)
+{
+        struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
+        u16 reg;
+        int i;
+        const u8 *addr = hw->dev[port]->dev_addr;
+
+        sky2_write8(hw, SK_REG(port, GPHY_CTRL), GPC_RST_SET);
+        sky2_write8(hw, SK_REG(port, GPHY_CTRL), GPC_RST_CLR);
+
+        sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_RST_CLR);
+
+        if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev == 0 && port == 1) {
+                /* WA DEV_472 -- looks like crossed wires on port 2 */
+                /* clear GMAC 1 Control reset */
+                sky2_write8(hw, SK_REG(0, GMAC_CTRL), GMC_RST_CLR);
+                do {
+                        sky2_write8(hw, SK_REG(1, GMAC_CTRL), GMC_RST_SET);
+                        sky2_write8(hw, SK_REG(1, GMAC_CTRL), GMC_RST_CLR);
+                } while (gm_phy_read(hw, 1, PHY_MARV_ID0) != PHY_MARV_ID0_VAL ||
+                         gm_phy_read(hw, 1, PHY_MARV_ID1) != PHY_MARV_ID1_Y2 ||
+                         gm_phy_read(hw, 1, PHY_MARV_INT_MASK) != 0);
+        }
+
+        if (sky2->autoneg == AUTONEG_DISABLE) {
+                reg = gma_read16(hw, port, GM_GP_CTRL);
+                reg |= GM_GPCR_AU_ALL_DIS;
+                gma_write16(hw, port, GM_GP_CTRL, reg);
+                gma_read16(hw, port, GM_GP_CTRL);
+
+                switch (sky2->speed) {
+                case SPEED_1000:
+                        reg |= GM_GPCR_SPEED_1000;
+                        /* fallthru */
+                case SPEED_100:
+                        reg |= GM_GPCR_SPEED_100;
+                }
+
+                if (sky2->duplex == DUPLEX_FULL)
+                        reg |= GM_GPCR_DUP_FULL;
+        } else
+                reg = GM_GPCR_SPEED_1000 | GM_GPCR_SPEED_100 | GM_GPCR_DUP_FULL;
+
+        if (!sky2->tx_pause && !sky2->rx_pause) {
+                sky2_write32(hw, SK_REG(port, GMAC_CTRL), GMC_PAUSE_OFF);
+                reg |=
+                    GM_GPCR_FC_TX_DIS | GM_GPCR_FC_RX_DIS | GM_GPCR_AU_FCT_DIS;
+        } else if (sky2->tx_pause && !sky2->rx_pause) {
+                /* disable Rx flow-control */
+                reg |= GM_GPCR_FC_RX_DIS | GM_GPCR_AU_FCT_DIS;
+        }
+
+        gma_write16(hw, port, GM_GP_CTRL, reg);
+
+        sky2_read16(hw, SK_REG(port, GMAC_IRQ_SRC));
+
+        spin_lock_bh(&hw->phy_lock);
+        sky2_phy_init(hw, port);
+        spin_unlock_bh(&hw->phy_lock);
+
+        /* MIB clear */
+        reg = gma_read16(hw, port, GM_PHY_ADDR);
+        gma_write16(hw, port, GM_PHY_ADDR, reg | GM_PAR_MIB_CLR);
+
+        for (i = 0; i < GM_MIB_CNT_SIZE; i++)
+                gma_read16(hw, port, GM_MIB_CNT_BASE + 8 * i);
+        gma_write16(hw, port, GM_PHY_ADDR, reg);
+
+        /* transmit control */
+        gma_write16(hw, port, GM_TX_CTRL, TX_COL_THR(TX_COL_DEF));
+
+        /* receive control reg: unicast + multicast + no FCS  */
+        gma_write16(hw, port, GM_RX_CTRL,
+                    GM_RXCR_UCF_ENA | GM_RXCR_CRC_DIS | GM_RXCR_MCF_ENA);
+
+        /* transmit flow control */
+        gma_write16(hw, port, GM_TX_FLOW_CTRL, 0xffff);
+
+        /* transmit parameter */
+        gma_write16(hw, port, GM_TX_PARAM,
+                    TX_JAM_LEN_VAL(TX_JAM_LEN_DEF) |
+                    TX_JAM_IPG_VAL(TX_JAM_IPG_DEF) |
+                    TX_IPG_JAM_DATA(TX_IPG_JAM_DEF) |
+                    TX_BACK_OFF_LIM(TX_BOF_LIM_DEF));
+
+        /* serial mode register */
+        reg = DATA_BLIND_VAL(DATA_BLIND_DEF) |
+                GM_SMOD_VLAN_ENA | IPG_DATA_VAL(IPG_DATA_DEF);
+
+        if (hw->dev[port]->mtu > ETH_DATA_LEN)
+                reg |= GM_SMOD_JUMBO_ENA;
+
+        gma_write16(hw, port, GM_SERIAL_MODE, reg);
+
+        /* virtual address for data */
+        gma_set_addr(hw, port, GM_SRC_ADDR_2L, addr);
+
+        /* physical address: used for pause frames */
+        gma_set_addr(hw, port, GM_SRC_ADDR_1L, addr);
+
+        /* ignore counter overflows */
+        gma_write16(hw, port, GM_TX_IRQ_MSK, 0);
+        gma_write16(hw, port, GM_RX_IRQ_MSK, 0);
+        gma_write16(hw, port, GM_TR_IRQ_MSK, 0);
+
+        /* Configure Rx MAC FIFO */
+        sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RST_CLR);
+        sky2_write16(hw, SK_REG(port, RX_GMF_CTRL_T),
+                     GMF_RX_CTRL_DEF);
+
+        /* Flush Rx MAC FIFO on any flow control or error */
+        reg = GMR_FS_ANY_ERR;
+        if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev <= 1)
+                reg = 0;        /* WA dev #4.115 */
+
+        sky2_write16(hw, SK_REG(port, RX_GMF_FL_MSK), reg);
+        /* Set threshold to 0xa (64 bytes)
+         *  ASF disabled so no need to do WA dev #4.30
+         */
+        sky2_write16(hw, SK_REG(port, RX_GMF_FL_THR), RX_GMF_FL_THR_DEF);
+
+        /* Configure Tx MAC FIFO */
+        sky2_write8(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_RST_CLR);
+        sky2_write16(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_OPER_ON);
+}
+
+static void sky2_ramset(struct sky2_hw *hw, u16 q, u32 start, size_t len)
+{
+        u32 end;
+
+        start /= 8;
+        len /= 8;
+        end = start + len - 1;
+
+        sky2_write8(hw, RB_ADDR(q, RB_CTRL), RB_RST_CLR);
+        sky2_write32(hw, RB_ADDR(q, RB_START), start);
+        sky2_write32(hw, RB_ADDR(q, RB_END), end);
+        sky2_write32(hw, RB_ADDR(q, RB_WP), start);
+        sky2_write32(hw, RB_ADDR(q, RB_RP), start);
+
+        if (q == Q_R1 || q == Q_R2) {
+                u32 rxup, rxlo;
+
+                rxlo = len/2;
+                rxup = rxlo + len/4;
+
+                /* Set thresholds on receive queue's */
+                sky2_write32(hw, RB_ADDR(q, RB_RX_UTPP), rxup);
+                sky2_write32(hw, RB_ADDR(q, RB_RX_LTPP), rxlo);
+        } else {
+                /* Enable store & forward on Tx queue's because
+                 * Tx FIFO is only 1K on Yukon
+                 */
+                sky2_write8(hw, RB_ADDR(q, RB_CTRL), RB_ENA_STFWD);
+        }
+
+        sky2_write8(hw, RB_ADDR(q, RB_CTRL), RB_ENA_OP_MD);
+        sky2_read8(hw, RB_ADDR(q, RB_CTRL));
+}
+
+/* Setup Bus Memory Interface */
+static void sky2_qset(struct sky2_hw *hw, u16 q, u32 wm)
+{
+        sky2_write32(hw, Q_ADDR(q, Q_CSR), BMU_CLR_RESET);
+        sky2_write32(hw, Q_ADDR(q, Q_CSR), BMU_OPER_INIT);
+        sky2_write32(hw, Q_ADDR(q, Q_CSR), BMU_FIFO_OP_ON);
+        sky2_write32(hw, Q_ADDR(q, Q_WM), wm);
+}
+
+/* Setup prefetch unit registers. This is the interface between
+ * hardware and driver list elements
+ */
+static inline void sky2_prefetch_init(struct sky2_hw *hw, u32 qaddr,
+                                      u64 addr, u32 last)
+{
+        sky2_write32(hw, Y2_QADDR(qaddr, PREF_UNIT_CTRL), PREF_UNIT_RST_SET);
+        sky2_write32(hw, Y2_QADDR(qaddr, PREF_UNIT_CTRL), PREF_UNIT_RST_CLR);
+        sky2_write32(hw, Y2_QADDR(qaddr, PREF_UNIT_ADDR_HI), addr >> 32);
+        sky2_write32(hw, Y2_QADDR(qaddr, PREF_UNIT_ADDR_LO), (u32) addr);
+        sky2_write16(hw, Y2_QADDR(qaddr, PREF_UNIT_LAST_IDX), last);
+        sky2_write32(hw, Y2_QADDR(qaddr, PREF_UNIT_CTRL), PREF_UNIT_OP_ON);
+
+        sky2_read32(hw, Y2_QADDR(qaddr, PREF_UNIT_CTRL));
+}
+
+static inline struct sky2_tx_le *get_tx_le(struct sky2_port *sky2)
+{
+        struct sky2_tx_le *le = sky2->tx_le + sky2->tx_prod;
+
+        sky2->tx_prod = (sky2->tx_prod + 1) % TX_RING_SIZE;
+        return le;
+}
+
+/*
+ * This is a workaround code taken from SysKonnect sk98lin driver
+ * to deal with chip bug on Yukon EC rev 0 in the wraparound case.
+ */
+static inline void sky2_put_idx(struct sky2_hw *hw, unsigned q,
+                                u16 idx, u16 *last, u16 size)
+{
+        if (is_ec_a1(hw) && idx < *last) {
+                u16 hwget = sky2_read16(hw, Y2_QADDR(q, PREF_UNIT_GET_IDX));
+
+                if (hwget == 0) {
+                        /* Start prefetching again */
+                        sky2_write8(hw, Y2_QADDR(q, PREF_UNIT_FIFO_WM), 0xe0);
+                        goto setnew;
+                }
+
+                if (hwget == size - 1) {
+                        /* set watermark to one list element */
+                        sky2_write8(hw, Y2_QADDR(q, PREF_UNIT_FIFO_WM), 8);
+
+                        /* set put index to first list element */
+                        sky2_write16(hw, Y2_QADDR(q, PREF_UNIT_PUT_IDX), 0);
+                } else          /* have hardware go to end of list */
+                        sky2_write16(hw, Y2_QADDR(q, PREF_UNIT_PUT_IDX),
+                                     size - 1);
+        } else {
+setnew:
+                sky2_write16(hw, Y2_QADDR(q, PREF_UNIT_PUT_IDX), idx);
+        }
+        *last = idx;
+}
+
+
+static inline struct sky2_rx_le *sky2_next_rx(struct sky2_port *sky2)
+{
+        struct sky2_rx_le *le = sky2->rx_le + sky2->rx_put;
+        sky2->rx_put = (sky2->rx_put + 1) % RX_LE_SIZE;
+        return le;
+}
+
+/* Build description to hardware about buffer */
+static inline void sky2_rx_add(struct sky2_port *sky2, struct ring_info *re)
+{
+        struct sky2_rx_le *le;
+        u32 hi = (re->mapaddr >> 16) >> 16;
+
+        re->idx = sky2->rx_put;
+        if (sky2->rx_addr64 != hi) {
+                le = sky2_next_rx(sky2);
+                le->addr = cpu_to_le32(hi);
+                le->ctrl = 0;
+                le->opcode = OP_ADDR64 | HW_OWNER;
+                sky2->rx_addr64 = hi;
+        }
+
+        le = sky2_next_rx(sky2);
+        le->addr = cpu_to_le32((u32) re->mapaddr);
+        le->length = cpu_to_le16(re->maplen);
+        le->ctrl = 0;
+        le->opcode = OP_PACKET | HW_OWNER;
+}
+
+
+/* Tell chip where to start receive checksum.
+ * Actually has two checksums, but set both same to avoid possible byte
+ * order problems.
+ */
+static void rx_set_checksum(struct sky2_port *sky2)
+{
+        struct sky2_rx_le *le;
+
+        le = sky2_next_rx(sky2);
+        le->addr = (ETH_HLEN << 16) | ETH_HLEN;
+        le->ctrl = 0;
+        le->opcode = OP_TCPSTART | HW_OWNER;
+
+        sky2_write32(sky2->hw,
+                     Q_ADDR(rxqaddr[sky2->port], Q_CSR),
+                     sky2->rx_csum ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
+
+}
+
+/*
+ * The RX Stop command will not work for Yukon-2 if the BMU does not
+ * reach the end of packet and since we can't make sure that we have
+ * incoming data, we must reset the BMU while it is not doing a DMA
+ * transfer. Since it is possible that the RX path is still active,
+ * the RX RAM buffer will be stopped first, so any possible incoming
+ * data will not trigger a DMA. After the RAM buffer is stopped, the
+ * BMU is polled until any DMA in progress is ended and only then it
+ * will be reset.
+ */
+static void sky2_rx_stop(struct sky2_port *sky2)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned rxq = rxqaddr[sky2->port];
+        int i;
+
+        /* disable the RAM Buffer receive queue */
+        sky2_write8(hw, RB_ADDR(rxq, RB_CTRL), RB_DIS_OP_MD);
+
+        for (i = 0; i < 0xffff; i++)
+                if (sky2_read8(hw, RB_ADDR(rxq, Q_RSL))
+                    == sky2_read8(hw, RB_ADDR(rxq, Q_RL)))
+                        goto stopped;
+
+        printk(KERN_WARNING PFX "%s: receiver stop failed\n",
+               sky2->netdev->name);
+stopped:
+        sky2_write32(hw, Q_ADDR(rxq, Q_CSR), BMU_RST_SET | BMU_FIFO_RST);
+
+        /* reset the Rx prefetch unit */
+        sky2_write32(hw, Y2_QADDR(rxq, PREF_UNIT_CTRL), PREF_UNIT_RST_SET);
+}
+
+/* Clean out receive buffer area, assumes receiver hardware stopped */
+static void sky2_rx_clean(struct sky2_port *sky2)
+{
+        unsigned i;
+
+        memset(sky2->rx_le, 0, RX_LE_BYTES);
+        for (i = 0; i < sky2->rx_pending; i++) {
+                struct ring_info *re = sky2->rx_ring + i;
+
+                if (re->skb) {
+                        pci_unmap_single(sky2->hw->pdev,
+                                         re->mapaddr, re->maplen,
+                                         PCI_DMA_FROMDEVICE);
+                        kfree_skb(re->skb);
+                        re->skb = NULL;
+                }
+        }
+}
+
+#ifdef SKY2_VLAN_TAG_USED
+static void sky2_vlan_rx_register(struct net_device *dev, struct vlan_group *grp)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        u16 port = sky2->port;
+        unsigned long flags;
+
+        spin_lock_irqsave(&sky2->tx_lock, flags);
+
+        sky2_write32(hw, SK_REG(port, RX_GMF_CTRL_T), RX_VLAN_STRIP_ON);
+        sky2_write32(hw, SK_REG(port, TX_GMF_CTRL_T), TX_VLAN_TAG_ON);
+        sky2->vlgrp = grp;
+
+        spin_unlock_irqrestore(&sky2->tx_lock, flags);
+}
+
+static void sky2_vlan_rx_kill_vid(struct net_device *dev, unsigned short vid)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        u16 port = sky2->port;
+        unsigned long flags;
+
+        spin_lock_irqsave(&sky2->tx_lock, flags);
+
+        sky2_write32(hw, SK_REG(port, RX_GMF_CTRL_T), RX_VLAN_STRIP_OFF);
+        sky2_write32(hw, SK_REG(port, TX_GMF_CTRL_T), TX_VLAN_TAG_OFF);
+        if (sky2->vlgrp)
+                sky2->vlgrp->vlan_devices[vid] = NULL;
+
+        spin_unlock_irqrestore(&sky2->tx_lock, flags);
+}
+#endif
+
+#define roundup(x, y)   ((((x)+((y)-1))/(y))*(y))
+static inline unsigned rx_size(const struct sky2_port *sky2)
+{
+        return roundup(sky2->netdev->mtu + ETH_HLEN + 4, 8);
+}
+
+/*
+ * Allocate and setup receiver buffer pool.
+ * In case of 64 bit dma, there are 2X as many list elements
+ * available as ring entries
+ * and need to reserve one list element so we don't wrap around.
+ *
+ * It appears the hardware has a bug in the FIFO logic that
+ * cause it to hang if the FIFO gets overrun and the receive buffer
+ * is not aligned.  This means we can't use skb_reserve to align
+ * the IP header.
+ */
+static int sky2_rx_start(struct sky2_port *sky2)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned size = rx_size(sky2);
+        unsigned rxq = rxqaddr[sky2->port];
+        int i;
+
+        sky2->rx_put = sky2->rx_next = 0;
+        sky2_qset(hw, rxq, is_pciex(hw) ? 0x80 : 0x600);
+        sky2_prefetch_init(hw, rxq, sky2->rx_le_map, RX_LE_SIZE - 1);
+
+        rx_set_checksum(sky2);
+        for (i = 0; i < sky2->rx_pending; i++) {
+                struct ring_info *re = sky2->rx_ring + i;
+
+                re->skb = dev_alloc_skb(size);
+                if (!re->skb)
+                        goto nomem;
+
+                re->mapaddr = pci_map_single(hw->pdev, re->skb->data,
+                                             size, PCI_DMA_FROMDEVICE);
+                re->maplen = size;
+                sky2_rx_add(sky2, re);
+        }
+
+        /* Tell chip about available buffers */
+        sky2_write16(hw, Y2_QADDR(rxq, PREF_UNIT_PUT_IDX), sky2->rx_put);
+        sky2->rx_last_put = sky2_read16(hw, Y2_QADDR(rxq, PREF_UNIT_PUT_IDX));
+        return 0;
+nomem:
+        sky2_rx_clean(sky2);
+        return -ENOMEM;
+}
+
+/* Bring up network interface. */
+static int sky2_up(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u32 ramsize, rxspace;
+        int err = -ENOMEM;
+
+        if (netif_msg_ifup(sky2))
+                printk(KERN_INFO PFX "%s: enabling interface\n", dev->name);
+
+        /* must be power of 2 */
+        sky2->tx_le = pci_alloc_consistent(hw->pdev,
+                                           TX_RING_SIZE *
+                                           sizeof(struct sky2_tx_le),
+                                           &sky2->tx_le_map);
+        if (!sky2->tx_le)
+                goto err_out;
+
+        sky2->tx_ring = kzalloc(TX_RING_SIZE * sizeof(struct ring_info),
+                                GFP_KERNEL);
+        if (!sky2->tx_ring)
+                goto err_out;
+        sky2->tx_prod = sky2->tx_cons = 0;
+
+        sky2->rx_le = pci_alloc_consistent(hw->pdev, RX_LE_BYTES,
+                                           &sky2->rx_le_map);
+        if (!sky2->rx_le)
+                goto err_out;
+        memset(sky2->rx_le, 0, RX_LE_BYTES);
+
+        sky2->rx_ring = kzalloc(sky2->rx_pending * sizeof(struct ring_info),
+                                GFP_KERNEL);
+        if (!sky2->rx_ring)
+                goto err_out;
+
+        sky2_mac_init(hw, port);
+
+        /* Configure RAM buffers */
+        if (hw->chip_id == CHIP_ID_YUKON_FE ||
+            (hw->chip_id == CHIP_ID_YUKON_EC && hw->chip_rev == 2))
+                ramsize = 4096;
+        else {
+                u8 e0 = sky2_read8(hw, B2_E_0);
+                ramsize = (e0 == 0) ? (128 * 1024) : (e0 * 4096);
+        }
+
+        /* 2/3 for Rx */
+        rxspace = (2 * ramsize) / 3;
+        sky2_ramset(hw, rxqaddr[port], 0, rxspace);
+        sky2_ramset(hw, txqaddr[port], rxspace, ramsize - rxspace);
+
+        /* Make sure SyncQ is disabled */
+        sky2_write8(hw, RB_ADDR(port == 0 ? Q_XS1 : Q_XS2, RB_CTRL),
+                    RB_RST_SET);
+
+        sky2_qset(hw, txqaddr[port], 0x600);
+        sky2_prefetch_init(hw, txqaddr[port], sky2->tx_le_map,
+                           TX_RING_SIZE - 1);
+
+        err = sky2_rx_start(sky2);
+        if (err)
+                goto err_out;
+
+        /* Enable interrupts from phy/mac for port */
+        hw->intr_mask |= (port == 0) ? Y2_IS_PORT_1 : Y2_IS_PORT_2;
+        sky2_write32(hw, B0_IMSK, hw->intr_mask);
+        return 0;
+
+err_out:
+        if (sky2->rx_le)
+                pci_free_consistent(hw->pdev, RX_LE_BYTES,
+                                    sky2->rx_le, sky2->rx_le_map);
+        if (sky2->tx_le)
+                pci_free_consistent(hw->pdev,
+                                    TX_RING_SIZE * sizeof(struct sky2_tx_le),
+                                    sky2->tx_le, sky2->tx_le_map);
+        if (sky2->tx_ring)
+                kfree(sky2->tx_ring);
+        if (sky2->rx_ring)
+                kfree(sky2->rx_ring);
+
+        return err;
+}
+
+/* Modular subtraction in ring */
+static inline int tx_dist(unsigned tail, unsigned head)
+{
+        return (head >= tail ? head : head + TX_RING_SIZE) - tail;
+}
+
+/* Number of list elements available for next tx */
+static inline int tx_avail(const struct sky2_port *sky2)
+{
+        return sky2->tx_pending - tx_dist(sky2->tx_cons, sky2->tx_prod);
+}
+
+/* Estimate of number of transmit list elements required */
+static inline unsigned tx_le_req(const struct sk_buff *skb)
+{
+        unsigned count;
+
+        count = sizeof(dma_addr_t) / sizeof(u32);
+        count += skb_shinfo(skb)->nr_frags * count;
+
+        if (skb_shinfo(skb)->tso_size)
+                ++count;
+
+        if (skb->ip_summed)
+                ++count;
+
+        return count;
+}
+
+/*
+ * Put one packet in ring for transmit.
+ * A single packet can generate multiple list elements, and
+ * the number of ring elements will probably be less than the number
+ * of list elements used.
+ */
+static int sky2_xmit_frame(struct sk_buff *skb, struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        struct sky2_tx_le *le = NULL;
+        struct ring_info *re;
+        unsigned long flags;
+        unsigned i, len;
+        dma_addr_t mapping;
+        u32 addr64;
+        u16 mss;
+        u8 ctrl;
+
+        local_irq_save(flags);
+        if (!spin_trylock(&sky2->tx_lock)) {
+                local_irq_restore(flags);
+                return NETDEV_TX_LOCKED;
+        }
+
+        if (unlikely(tx_avail(sky2) < tx_le_req(skb))) {
+                netif_stop_queue(dev);
+                spin_unlock_irqrestore(&sky2->tx_lock, flags);
+
+                printk(KERN_WARNING PFX "%s: ring full when queue awake!\n",
+                       dev->name);
+                return NETDEV_TX_BUSY;
+        }
+
+        if (unlikely(netif_msg_tx_queued(sky2)))
+                printk(KERN_DEBUG "%s: tx queued, slot %u, len %d\n",
+                       dev->name, sky2->tx_prod, skb->len);
+
+        len = skb_headlen(skb);
+        mapping = pci_map_single(hw->pdev, skb->data, len, PCI_DMA_TODEVICE);
+        addr64 = (mapping >> 16) >> 16;
+
+        re = sky2->tx_ring + sky2->tx_prod;
+
+        /* Send high bits if changed */
+        if (addr64 != sky2->tx_addr64) {
+                le = get_tx_le(sky2);
+                le->tx.addr = cpu_to_le32(addr64);
+                le->ctrl = 0;
+                le->opcode = OP_ADDR64 | HW_OWNER;
+                sky2->tx_addr64 = addr64;
+        }
+
+        /* Check for TCP Segmentation Offload */
+        mss = skb_shinfo(skb)->tso_size;
+        if (mss != 0) {
+                /* just drop the packet if non-linear expansion fails */
+                if (skb_header_cloned(skb) &&
+                    pskb_expand_head(skb, 0, 0, GFP_ATOMIC)) {
+                        dev_kfree_skb_any(skb);
+                        goto out_unlock;
+                }
+
+                mss += ((skb->h.th->doff - 5) * 4);     /* TCP options */
+                mss += (skb->nh.iph->ihl * 4) + sizeof(struct tcphdr);
+                mss += ETH_HLEN;
+        }
+
+        if (mss != sky2->tx_last_mss) {
+                le = get_tx_le(sky2);
+                le->tx.tso.size = cpu_to_le16(mss);
+                le->tx.tso.rsvd = 0;
+                le->opcode = OP_LRGLEN | HW_OWNER;
+                le->ctrl = 0;
+                sky2->tx_last_mss = mss;
+        }
+
+        ctrl = 0;
+#ifdef SKY2_VLAN_TAG_USED
+        /* Add VLAN tag, can piggyback on LRGLEN or ADDR64 */
+        if (sky2->vlgrp && vlan_tx_tag_present(skb)) {
+                if (!le) {
+                        le = get_tx_le(sky2);
+                        le->tx.addr = 0;
+                        le->opcode = OP_VLAN|HW_OWNER;
+                        le->ctrl = 0;
+                } else
+                        le->opcode |= OP_VLAN;
+                le->length = cpu_to_be16(vlan_tx_tag_get(skb));
+                ctrl |= INS_VLAN;
+        }
+#endif
+
+        /* Handle TCP checksum offload */
+        if (skb->ip_summed == CHECKSUM_HW) {
+                u16 hdr = skb->h.raw - skb->data;
+                u16 offset = hdr + skb->csum;
+
+                ctrl = CALSUM | WR_SUM | INIT_SUM | LOCK_SUM;
+                if (skb->nh.iph->protocol == IPPROTO_UDP)
+                        ctrl |= UDPTCP;
+
+                le = get_tx_le(sky2);
+                le->tx.csum.start = cpu_to_le16(hdr);
+                le->tx.csum.offset = cpu_to_le16(offset);
+                le->length = 0; /* initial checksum value */
+                le->ctrl = 1;   /* one packet */
+                le->opcode = OP_TCPLISW | HW_OWNER;
+        }
+
+        le = get_tx_le(sky2);
+        le->tx.addr = cpu_to_le32((u32) mapping);
+        le->length = cpu_to_le16(len);
+        le->ctrl = ctrl;
+        le->opcode = mss ? (OP_LARGESEND | HW_OWNER) : (OP_PACKET | HW_OWNER);
+
+        /* Record the transmit mapping info */
+        re->skb = skb;
+        re->mapaddr = mapping;
+        re->maplen = len;
+
+        for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) {
+                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
+                struct ring_info *fre;
+
+                mapping = pci_map_page(hw->pdev, frag->page, frag->page_offset,
+                                       frag->size, PCI_DMA_TODEVICE);
+                addr64 = (mapping >> 16) >> 16;
+                if (addr64 != sky2->tx_addr64) {
+                        le = get_tx_le(sky2);
+                        le->tx.addr = cpu_to_le32(addr64);
+                        le->ctrl = 0;
+                        le->opcode = OP_ADDR64 | HW_OWNER;
+                        sky2->tx_addr64 = addr64;
+                }
+
+                le = get_tx_le(sky2);
+                le->tx.addr = cpu_to_le32((u32) mapping);
+                le->length = cpu_to_le16(frag->size);
+                le->ctrl = ctrl;
+                le->opcode = OP_BUFFER | HW_OWNER;
+
+                fre = sky2->tx_ring
+                    + ((re - sky2->tx_ring) + i + 1) % TX_RING_SIZE;
+                fre->skb = NULL;
+                fre->mapaddr = mapping;
+                fre->maplen = frag->size;
+        }
+        re->idx = sky2->tx_prod;
+        le->ctrl |= EOP;
+
+        sky2_put_idx(hw, txqaddr[sky2->port], sky2->tx_prod,
+                     &sky2->tx_last_put, TX_RING_SIZE);
+
+        if (tx_avail(sky2) < MAX_SKB_TX_LE + 1)
+                netif_stop_queue(dev);
+
+out_unlock:
+        mmiowb();
+        spin_unlock_irqrestore(&sky2->tx_lock, flags);
+
+        dev->trans_start = jiffies;
+        return NETDEV_TX_OK;
+}
+
+/*
+ * Free ring elements from starting at tx_cons until "done"
+ *
+ * NB: the hardware will tell us about partial completion of multi-part
+ *     buffers; these are deferred until completion.
+ */
+static void sky2_tx_complete(struct sky2_port *sky2, u16 done)
+{
+        struct net_device *dev = sky2->netdev;
+        unsigned i;
+
+        if (unlikely(netif_msg_tx_done(sky2)))
+                printk(KERN_DEBUG "%s: tx done, up to %u\n",
+                       dev->name, done);
+
+        spin_lock(&sky2->tx_lock);
+
+        while (sky2->tx_cons != done) {
+                struct ring_info *re = sky2->tx_ring + sky2->tx_cons;
+                struct sk_buff *skb;
+
+                /* Check for partial status */
+                if (tx_dist(sky2->tx_cons, done)
+                    < tx_dist(sky2->tx_cons, re->idx))
+                        goto out;
+
+                skb = re->skb;
+                pci_unmap_single(sky2->hw->pdev,
+                                 re->mapaddr, re->maplen, PCI_DMA_TODEVICE);
+
+                for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) {
+                        struct ring_info *fre;
+                        fre =
+                            sky2->tx_ring + (sky2->tx_cons + i +
+                                             1) % TX_RING_SIZE;
+                        pci_unmap_page(sky2->hw->pdev, fre->mapaddr,
+                                       fre->maplen, PCI_DMA_TODEVICE);
+                }
+
+                dev_kfree_skb_any(skb);
+
+                sky2->tx_cons = re->idx;
+        }
+out:
+
+        if (netif_queue_stopped(dev) && tx_avail(sky2) > MAX_SKB_TX_LE)
+                netif_wake_queue(dev);
+        spin_unlock(&sky2->tx_lock);
+}
+
+/* Cleanup all untransmitted buffers, assume transmitter not running */
+static inline void sky2_tx_clean(struct sky2_port *sky2)
+{
+        sky2_tx_complete(sky2, sky2->tx_prod);
+}
+
+/* Network shutdown */
+static int sky2_down(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u16 ctrl;
+
+        if (netif_msg_ifdown(sky2))
+                printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
+
+        netif_stop_queue(dev);
+
+        sky2_phy_reset(hw, port);
+
+        /* Stop transmitter */
+        sky2_write32(hw, Q_ADDR(txqaddr[port], Q_CSR), BMU_STOP);
+        sky2_read32(hw, Q_ADDR(txqaddr[port], Q_CSR));
+
+        sky2_write32(hw, RB_ADDR(txqaddr[port], RB_CTRL),
+                     RB_RST_SET | RB_DIS_OP_MD);
+
+        ctrl = gma_read16(hw, port, GM_GP_CTRL);
+        ctrl &= ~(GM_GPCR_TX_ENA | GM_GPCR_RX_ENA);
+        gma_write16(hw, port, GM_GP_CTRL, ctrl);
+
+        sky2_write8(hw, SK_REG(port, GPHY_CTRL), GPC_RST_SET);
+
+        /* Workaround shared GMAC reset */
+        if (!(hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev == 0
+              && port == 0 && hw->dev[1] && netif_running(hw->dev[1])))
+                sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_RST_SET);
+
+        /* Disable Force Sync bit and Enable Alloc bit */
+        sky2_write8(hw, SK_REG(port, TXA_CTRL),
+                    TXA_DIS_FSYNC | TXA_DIS_ALLOC | TXA_STOP_RC);
+
+        /* Stop Interval Timer and Limit Counter of Tx Arbiter */
+        sky2_write32(hw, SK_REG(port, TXA_ITI_INI), 0L);
+        sky2_write32(hw, SK_REG(port, TXA_LIM_INI), 0L);
+
+        /* Reset the PCI FIFO of the async Tx queue */
+        sky2_write32(hw, Q_ADDR(txqaddr[port], Q_CSR),
+                     BMU_RST_SET | BMU_FIFO_RST);
+
+        /* Reset the Tx prefetch units */
+        sky2_write32(hw, Y2_QADDR(txqaddr[port], PREF_UNIT_CTRL),
+                     PREF_UNIT_RST_SET);
+
+        sky2_write32(hw, RB_ADDR(txqaddr[port], RB_CTRL), RB_RST_SET);
+
+        sky2_rx_stop(sky2);
+
+        sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RST_SET);
+        sky2_write8(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_RST_SET);
+
+        /* turn off LED's */
+        sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
+
+        sky2_tx_clean(sky2);
+        sky2_rx_clean(sky2);
+
+        pci_free_consistent(hw->pdev, RX_LE_BYTES,
+                            sky2->rx_le, sky2->rx_le_map);
+        kfree(sky2->rx_ring);
+
+        pci_free_consistent(hw->pdev,
+                            TX_RING_SIZE * sizeof(struct sky2_tx_le),
+                            sky2->tx_le, sky2->tx_le_map);
+        kfree(sky2->tx_ring);
+
+        return 0;
+}
+
+static u16 sky2_phy_speed(const struct sky2_hw *hw, u16 aux)
+{
+        if (!hw->copper)
+                return SPEED_1000;
+
+        if (hw->chip_id == CHIP_ID_YUKON_FE)
+                return (aux & PHY_M_PS_SPEED_100) ? SPEED_100 : SPEED_10;
+
+        switch (aux & PHY_M_PS_SPEED_MSK) {
+        case PHY_M_PS_SPEED_1000:
+                return SPEED_1000;
+        case PHY_M_PS_SPEED_100:
+                return SPEED_100;
+        default:
+                return SPEED_10;
+        }
+}
+
+static void sky2_link_up(struct sky2_port *sky2)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u16 reg;
+
+        /* disable Rx GMAC FIFO flush mode */
+        sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RX_F_FL_OFF);
+
+        /* Enable Transmit FIFO Underrun */
+        sky2_write8(hw, SK_REG(port, GMAC_IRQ_MSK), GMAC_DEF_MSK);
+
+        reg = gma_read16(hw, port, GM_GP_CTRL);
+        if (sky2->duplex == DUPLEX_FULL || sky2->autoneg == AUTONEG_ENABLE)
+                reg |= GM_GPCR_DUP_FULL;
+
+        /* enable Rx/Tx */
+        reg |= GM_GPCR_RX_ENA | GM_GPCR_TX_ENA;
+        gma_write16(hw, port, GM_GP_CTRL, reg);
+        gma_read16(hw, port, GM_GP_CTRL);
+
+        gm_phy_write(hw, port, PHY_MARV_INT_MASK, PHY_M_DEF_MSK);
+
+        netif_carrier_on(sky2->netdev);
+        netif_wake_queue(sky2->netdev);
+
+        /* Turn on link LED */
+        sky2_write8(hw, SK_REG(port, LNK_LED_REG),
+                    LINKLED_ON | LINKLED_BLINK_OFF | LINKLED_LINKSYNC_OFF);
+
+        if (hw->chip_id == CHIP_ID_YUKON_XL) {
+                u16 pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
+
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, PHY_M_LEDC_LOS_CTRL(1) |      /* LINK/ACT */
+                             PHY_M_LEDC_INIT_CTRL(sky2->speed ==
+                                                  SPEED_10 ? 7 : 0) |
+                             PHY_M_LEDC_STA1_CTRL(sky2->speed ==
+                                                  SPEED_100 ? 7 : 0) |
+                             PHY_M_LEDC_STA0_CTRL(sky2->speed ==
+                                                  SPEED_1000 ? 7 : 0));
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
+        }
+
+        if (netif_msg_link(sky2))
+                printk(KERN_INFO PFX
+                       "%s: Link is up at %d Mbps, %s duplex, flow control %s\n",
+                       sky2->netdev->name, sky2->speed,
+                       sky2->duplex == DUPLEX_FULL ? "full" : "half",
+                       (sky2->tx_pause && sky2->rx_pause) ? "both" :
+                       sky2->tx_pause ? "tx" : sky2->rx_pause ? "rx" : "none");
+}
+
+static void sky2_link_down(struct sky2_port *sky2)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u16 reg;
+
+        gm_phy_write(hw, port, PHY_MARV_INT_MASK, 0);
+
+        reg = gma_read16(hw, port, GM_GP_CTRL);
+        reg &= ~(GM_GPCR_RX_ENA | GM_GPCR_TX_ENA);
+        gma_write16(hw, port, GM_GP_CTRL, reg);
+        gma_read16(hw, port, GM_GP_CTRL);       /* PCI post */
+
+        if (sky2->rx_pause && !sky2->tx_pause) {
+                /* restore Asymmetric Pause bit */
+                gm_phy_write(hw, port, PHY_MARV_AUNE_ADV,
+                             gm_phy_read(hw, port, PHY_MARV_AUNE_ADV)
+                             | PHY_M_AN_ASP);
+        }
+
+        sky2_phy_reset(hw, port);
+
+        netif_carrier_off(sky2->netdev);
+        netif_stop_queue(sky2->netdev);
+
+        /* Turn on link LED */
+        sky2_write8(hw, SK_REG(port, LNK_LED_REG), LINKLED_OFF);
+
+        if (netif_msg_link(sky2))
+                printk(KERN_INFO PFX "%s: Link is down.\n", sky2->netdev->name);
+        sky2_phy_init(hw, port);
+}
+
+static int sky2_autoneg_done(struct sky2_port *sky2, u16 aux)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u16 lpa;
+
+        lpa = gm_phy_read(hw, port, PHY_MARV_AUNE_LP);
+
+        if (lpa & PHY_M_AN_RF) {
+                printk(KERN_ERR PFX "%s: remote fault", sky2->netdev->name);
+                return -1;
+        }
+
+        if (hw->chip_id != CHIP_ID_YUKON_FE &&
+            gm_phy_read(hw, port, PHY_MARV_1000T_STAT) & PHY_B_1000S_MSF) {
+                printk(KERN_ERR PFX "%s: master/slave fault",
+                       sky2->netdev->name);
+                return -1;
+        }
+
+        if (!(aux & PHY_M_PS_SPDUP_RES)) {
+                printk(KERN_ERR PFX "%s: speed/duplex mismatch",
+                       sky2->netdev->name);
+                return -1;
+        }
+
+        sky2->duplex = (aux & PHY_M_PS_FULL_DUP) ? DUPLEX_FULL : DUPLEX_HALF;
+
+        sky2->speed = sky2_phy_speed(hw, aux);
+
+        /* Pause bits are offset (9..8) */
+        if (hw->chip_id == CHIP_ID_YUKON_XL)
+                aux >>= 6;
+
+        sky2->rx_pause = (aux & PHY_M_PS_RX_P_EN) != 0;
+        sky2->tx_pause = (aux & PHY_M_PS_TX_P_EN) != 0;
+
+        if ((sky2->tx_pause || sky2->rx_pause)
+            && !(sky2->speed < SPEED_1000 && sky2->duplex == DUPLEX_HALF))
+                sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_PAUSE_ON);
+        else
+                sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_PAUSE_OFF);
+
+        return 0;
+}
+
+/*
+ * Interrupt from PHY are handled in tasklet (soft irq)
+ * because accessing phy registers requires spin wait which might
+ * cause excess interrupt latency.
+ */
+static void sky2_phy_task(unsigned long data)
+{
+        struct sky2_port *sky2 = (struct sky2_port *)data;
+        struct sky2_hw *hw = sky2->hw;
+        u16 istatus, phystat;
+
+        spin_lock(&hw->phy_lock);
+        istatus = gm_phy_read(hw, sky2->port, PHY_MARV_INT_STAT);
+        phystat = gm_phy_read(hw, sky2->port, PHY_MARV_PHY_STAT);
+
+        if (netif_msg_intr(sky2))
+                printk(KERN_INFO PFX "%s: phy interrupt status 0x%x 0x%x\n",
+                       sky2->netdev->name, istatus, phystat);
+
+        if (istatus & PHY_M_IS_AN_COMPL) {
+                if (sky2_autoneg_done(sky2, phystat) == 0)
+                        sky2_link_up(sky2);
+                goto out;
+        }
+
+        if (istatus & PHY_M_IS_LSP_CHANGE)
+                sky2->speed = sky2_phy_speed(hw, phystat);
+
+        if (istatus & PHY_M_IS_DUP_CHANGE)
+                sky2->duplex =
+                    (phystat & PHY_M_PS_FULL_DUP) ? DUPLEX_FULL : DUPLEX_HALF;
+
+        if (istatus & PHY_M_IS_LST_CHANGE) {
+                if (phystat & PHY_M_PS_LINK_UP)
+                        sky2_link_up(sky2);
+                else
+                        sky2_link_down(sky2);
+        }
+out:
+        spin_unlock(&hw->phy_lock);
+
+        local_irq_disable();
+        hw->intr_mask |= (sky2->port == 0) ? Y2_IS_IRQ_PHY1 : Y2_IS_IRQ_PHY2;
+        sky2_write32(hw, B0_IMSK, hw->intr_mask);
+        local_irq_enable();
+}
+
+static void sky2_tx_timeout(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        if (netif_msg_timer(sky2))
+                printk(KERN_ERR PFX "%s: tx timeout\n", dev->name);
+
+        sky2_write32(sky2->hw, Q_ADDR(txqaddr[sky2->port], Q_CSR), BMU_STOP);
+        sky2_read32(sky2->hw, Q_ADDR(txqaddr[sky2->port], Q_CSR));
+
+        sky2_tx_clean(sky2);
+}
+
+static int sky2_change_mtu(struct net_device *dev, int new_mtu)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        int err;
+        u16 ctl, mode;
+
+        if (new_mtu < ETH_ZLEN || new_mtu > ETH_JUMBO_MTU)
+                return -EINVAL;
+
+        if (!netif_running(dev)) {
+                dev->mtu = new_mtu;
+                return 0;
+        }
+
+        local_irq_disable();
+        sky2_write32(hw, B0_IMSK, 0);
+
+        ctl = gma_read16(hw, sky2->port, GM_GP_CTRL);
+        gma_write16(hw, sky2->port, GM_GP_CTRL, ctl & ~GM_GPCR_RX_ENA);
+        sky2_rx_stop(sky2);
+        sky2_rx_clean(sky2);
+
+        dev->mtu = new_mtu;
+        mode = DATA_BLIND_VAL(DATA_BLIND_DEF) |
+                GM_SMOD_VLAN_ENA | IPG_DATA_VAL(IPG_DATA_DEF);
+
+        if (dev->mtu > ETH_DATA_LEN)
+                mode |= GM_SMOD_JUMBO_ENA;
+
+        gma_write16(hw, sky2->port, GM_SERIAL_MODE, mode);
+
+        sky2_write8(hw, RB_ADDR(rxqaddr[sky2->port], RB_CTRL), RB_ENA_OP_MD);
+
+        err = sky2_rx_start(sky2);
+        gma_write16(hw, sky2->port, GM_GP_CTRL, ctl);
+
+        sky2_write32(hw, B0_IMSK, hw->intr_mask);
+        sky2_read32(hw, B0_IMSK);
+        local_irq_enable();
+        return err;
+}
+
+/*
+ * Receive one packet.
+ * For small packets or errors, just reuse existing skb.
+ * For larger packets, get new buffer.
+ */
+static struct sk_buff *sky2_receive(struct sky2_port *sky2,
+                                    u16 length, u32 status)
+{
+        struct ring_info *re = sky2->rx_ring + sky2->rx_next;
+        struct sk_buff *skb = NULL;
+        struct net_device *dev;
+        const unsigned int bufsize = rx_size(sky2);
+
+        if (unlikely(netif_msg_rx_status(sky2)))
+                printk(KERN_DEBUG PFX "%s: rx slot %u status 0x%x len %d\n",
+                       sky2->netdev->name, sky2->rx_next, status, length);
+
+        sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
+
+        if (!(status & GMR_FS_RX_OK) || (status & GMR_FS_ANY_ERR))
+                goto error;
+
+        if (length < RX_COPY_THRESHOLD) {
+                skb = alloc_skb(length + 2, GFP_ATOMIC);
+                if (!skb)
+                        goto resubmit;
+
+                skb_reserve(skb, 2);
+                pci_dma_sync_single_for_cpu(sky2->hw->pdev, re->mapaddr,
+                                            length, PCI_DMA_FROMDEVICE);
+                memcpy(skb->data, re->skb->data, length);
+                skb->ip_summed = re->skb->ip_summed;
+                skb->csum = re->skb->csum;
+                pci_dma_sync_single_for_device(sky2->hw->pdev, re->mapaddr,
+                                               length, PCI_DMA_FROMDEVICE);
+        } else {
+                struct sk_buff *nskb;
+
+                nskb = dev_alloc_skb(bufsize);
+                if (!nskb)
+                        goto resubmit;
+
+                skb = re->skb;
+                re->skb = nskb;
+                pci_unmap_single(sky2->hw->pdev, re->mapaddr,
+                                 re->maplen, PCI_DMA_FROMDEVICE);
+                prefetch(skb->data);
+
+                re->mapaddr = pci_map_single(sky2->hw->pdev, nskb->data,
+                                             bufsize, PCI_DMA_FROMDEVICE);
+                re->maplen = bufsize;
+        }
+
+        skb_put(skb, length);
+        dev = sky2->netdev;
+        skb->dev = dev;
+        skb->protocol = eth_type_trans(skb, dev);
+        dev->last_rx = jiffies;
+
+resubmit:
+        re->skb->ip_summed = CHECKSUM_NONE;
+        sky2_rx_add(sky2, re);
+
+        /* Tell receiver about new buffers. */
+        sky2_put_idx(sky2->hw, rxqaddr[sky2->port], sky2->rx_put,
+                     &sky2->rx_last_put, RX_LE_SIZE);
+
+        return skb;
+
+error:
+        if (status & GMR_FS_GOOD_FC)
+                goto resubmit;
+
+        if (netif_msg_rx_err(sky2))
+                printk(KERN_INFO PFX "%s: rx error, status 0x%x length %d\n",
+                       sky2->netdev->name, status, length);
+
+        if (status & (GMR_FS_LONG_ERR | GMR_FS_UN_SIZE))
+                sky2->net_stats.rx_length_errors++;
+        if (status & GMR_FS_FRAGMENT)
+                sky2->net_stats.rx_frame_errors++;
+        if (status & GMR_FS_CRC_ERR)
+                sky2->net_stats.rx_crc_errors++;
+        if (status & GMR_FS_RX_FF_OV)
+                sky2->net_stats.rx_fifo_errors++;
+
+        goto resubmit;
+}
+
+/* Transmit ring index in reported status block is encoded as:
+ *
+ *   | TXS2 | TXA2 | TXS1 | TXA1
+ */
+static inline u16 tx_index(u8 port, u32 status, u16 len)
+{
+        if (port == 0)
+                return status & 0xfff;
+        else
+                return ((status >> 24) & 0xff) | (len & 0xf) << 8;
+}
+
+/*
+ * Both ports share the same status interrupt, therefore there is only
+ * one poll routine.
+ */
+static int sky2_poll(struct net_device *dev0, int *budget)
+{
+        struct sky2_hw *hw = ((struct sky2_port *) netdev_priv(dev0))->hw;
+        unsigned int to_do = min(dev0->quota, *budget);
+        unsigned int work_done = 0;
+        u16 hwidx;
+
+        hwidx = sky2_read16(hw, STAT_PUT_IDX);
+        BUG_ON(hwidx >= STATUS_RING_SIZE);
+        rmb();
+
+        do {
+                struct sky2_status_le *le = hw->st_le + hw->st_idx;
+                struct sky2_port *sky2;
+                struct sk_buff *skb;
+                u32 status;
+                u16 length;
+
+                /* Are we done yet? */
+                if (hw->st_idx == hwidx) {
+                        sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ);
+                        hwidx = sky2_read16(hw, STAT_PUT_IDX);
+                        if (hwidx == hw->st_idx)
+                                break;
+                }
+
+                hw->st_idx = (hw->st_idx + 1) % STATUS_RING_SIZE;
+                prefetch(&hw->st_le[hw->st_idx]);
+
+                BUG_ON(le->link >= hw->ports || !hw->dev[le->link]);
+
+                sky2 = netdev_priv(hw->dev[le->link]);
+                status = le32_to_cpu(le->status);
+                length = le16_to_cpu(le->length);
+
+                switch (le->opcode & ~HW_OWNER) {
+                case OP_RXSTAT:
+                        skb = sky2_receive(sky2, length, status);
+                        if (!skb)
+                                break;
+#ifdef SKY2_VLAN_TAG_USED
+                        if (sky2->vlgrp && (status & GMR_FS_VLAN)) {
+                                vlan_hwaccel_receive_skb(skb,
+                                                         sky2->vlgrp,
+                                                         be16_to_cpu(sky2->rx_tag));
+                        } else
+#endif
+                                netif_receive_skb(skb);
+                        ++work_done;
+                        break;
+
+#ifdef SKY2_VLAN_TAG_USED
+                case OP_RXVLAN:
+                        sky2->rx_tag = length;
+                        break;
+
+                case OP_RXCHKSVLAN:
+                        sky2->rx_tag = length;
+                        /* fall through */
+#endif
+                case OP_RXCHKS:
+                        skb = sky2->rx_ring[sky2->rx_next].skb;
+                        skb->ip_summed = CHECKSUM_HW;
+                        skb->csum = le16_to_cpu(status);
+                        break;
+
+                case OP_TXINDEXLE:
+                        sky2_tx_complete(sky2,
+                                         tx_index(sky2->port, status, length));
+                        break;
+
+                default:
+                        if (net_ratelimit())
+                                printk(KERN_WARNING PFX
+                                       "unknown status opcode 0x%x\n",
+                                       le->opcode);
+                        break;
+                }
+
+                le->opcode = 0; /* paranoia */
+        } while (work_done < to_do);
+
+        mmiowb();
+
+        *budget -= work_done;
+        dev0->quota -= work_done;
+        if (work_done < to_do) {
+                /*
+                 * Another chip workaround, need to restart TX timer if status
+                 * LE was handled. WA_DEV_43_418
+                 */
+                if (is_ec_a1(hw)) {
+                        sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_STOP);
+                        sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START);
+                }
+
+                netif_rx_complete(dev0);
+                hw->intr_mask |= Y2_IS_STAT_BMU;
+                sky2_write32(hw, B0_IMSK, hw->intr_mask);
+                sky2_read32(hw, B0_IMSK);
+        }
+
+        return work_done >= to_do;
+
+}
+
+static void sky2_hw_error(struct sky2_hw *hw, unsigned port, u32 status)
+{
+        struct net_device *dev = hw->dev[port];
+
+        printk(KERN_INFO PFX "%s: hw error interrupt status 0x%x\n",
+               dev->name, status);
+
+        if (status & Y2_IS_PAR_RD1) {
+                printk(KERN_ERR PFX "%s: ram data read parity error\n",
+                       dev->name);
+                /* Clear IRQ */
+                sky2_write16(hw, RAM_BUFFER(port, B3_RI_CTRL), RI_CLR_RD_PERR);
+        }
+
+        if (status & Y2_IS_PAR_WR1) {
+                printk(KERN_ERR PFX "%s: ram data write parity error\n",
+                       dev->name);
+
+                sky2_write16(hw, RAM_BUFFER(port, B3_RI_CTRL), RI_CLR_WR_PERR);
+        }
+
+        if (status & Y2_IS_PAR_MAC1) {
+                printk(KERN_ERR PFX "%s: MAC parity error\n", dev->name);
+                sky2_write8(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_CLI_TX_PE);
+        }
+
+        if (status & Y2_IS_PAR_RX1) {
+                printk(KERN_ERR PFX "%s: RX parity error\n", dev->name);
+                sky2_write32(hw, Q_ADDR(rxqaddr[port], Q_CSR), BMU_CLR_IRQ_PAR);
+        }
+
+        if (status & Y2_IS_TCP_TXA1) {
+                printk(KERN_ERR PFX "%s: TCP segmentation error\n", dev->name);
+                sky2_write32(hw, Q_ADDR(txqaddr[port], Q_CSR), BMU_CLR_IRQ_TCP);
+        }
+}
+
+static void sky2_hw_intr(struct sky2_hw *hw)
+{
+        u32 status = sky2_read32(hw, B0_HWE_ISRC);
+
+        if (status & Y2_IS_TIST_OV)
+                sky2_write8(hw, GMAC_TI_ST_CTRL, GMT_ST_CLR_IRQ);
+
+        if (status & (Y2_IS_MST_ERR | Y2_IS_IRQ_STAT)) {
+                u16 pci_err;
+
+                pci_read_config_word(hw->pdev, PCI_STATUS, &pci_err);
+                printk(KERN_ERR PFX "%s: pci hw error (0x%x)\n",
+                       pci_name(hw->pdev), pci_err);
+
+                sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+                pci_write_config_word(hw->pdev, PCI_STATUS,
+                                      pci_err | PCI_STATUS_ERROR_BITS);
+                sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
+        }
+
+        if (status & Y2_IS_PCI_EXP) {
+                /* PCI-Express uncorrectable Error occurred */
+                u32 pex_err;
+
+                pci_read_config_dword(hw->pdev, PEX_UNC_ERR_STAT, &pex_err);
+
+                printk(KERN_ERR PFX "%s: pci express error (0x%x)\n",
+                       pci_name(hw->pdev), pex_err);
+
+                /* clear the interrupt */
+                sky2_write32(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+                pci_write_config_dword(hw->pdev, PEX_UNC_ERR_STAT,
+                                       0xffffffffUL);
+                sky2_write32(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
+
+                if (pex_err & PEX_FATAL_ERRORS) {
+                        u32 hwmsk = sky2_read32(hw, B0_HWE_IMSK);
+                        hwmsk &= ~Y2_IS_PCI_EXP;
+                        sky2_write32(hw, B0_HWE_IMSK, hwmsk);
+                }
+        }
+
+        if (status & Y2_HWE_L1_MASK)
+                sky2_hw_error(hw, 0, status);
+        status >>= 8;
+        if (status & Y2_HWE_L1_MASK)
+                sky2_hw_error(hw, 1, status);
+}
+
+static void sky2_mac_intr(struct sky2_hw *hw, unsigned port)
+{
+        struct net_device *dev = hw->dev[port];
+        struct sky2_port *sky2 = netdev_priv(dev);
+        u8 status = sky2_read8(hw, SK_REG(port, GMAC_IRQ_SRC));
+
+        if (netif_msg_intr(sky2))
+                printk(KERN_INFO PFX "%s: mac interrupt status 0x%x\n",
+                       dev->name, status);
+
+        if (status & GM_IS_RX_FF_OR) {
+                ++sky2->net_stats.rx_fifo_errors;
+                sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_CLI_RX_FO);
+        }
+
+        if (status & GM_IS_TX_FF_UR) {
+                ++sky2->net_stats.tx_fifo_errors;
+                sky2_write8(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_CLI_TX_FU);
+        }
+}
+
+static void sky2_phy_intr(struct sky2_hw *hw, unsigned port)
+{
+        struct net_device *dev = hw->dev[port];
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        hw->intr_mask &= ~(port == 0 ? Y2_IS_IRQ_PHY1 : Y2_IS_IRQ_PHY2);
+        sky2_write32(hw, B0_IMSK, hw->intr_mask);
+        tasklet_schedule(&sky2->phy_task);
+}
+
+static irqreturn_t sky2_intr(int irq, void *dev_id, struct pt_regs *regs)
+{
+        struct sky2_hw *hw = dev_id;
+        struct net_device *dev0 = hw->dev[0];
+        u32 status;
+
+        status = sky2_read32(hw, B0_Y2_SP_ISRC2);
+        if (status == 0 || status == ~0)
+                return IRQ_NONE;
+
+        if (status & Y2_IS_HW_ERR)
+                sky2_hw_intr(hw);
+
+        /* Do NAPI for Rx and Tx status */
+        if (status & Y2_IS_STAT_BMU) {
+                hw->intr_mask &= ~Y2_IS_STAT_BMU;
+                sky2_write32(hw, B0_IMSK, hw->intr_mask);
+                prefetch(&hw->st_le[hw->st_idx]);
+
+                if (netif_rx_schedule_test(dev0))
+                        __netif_rx_schedule(dev0);
+        }
+
+        if (status & Y2_IS_IRQ_PHY1)
+                sky2_phy_intr(hw, 0);
+
+        if (status & Y2_IS_IRQ_PHY2)
+                sky2_phy_intr(hw, 1);
+
+        if (status & Y2_IS_IRQ_MAC1)
+                sky2_mac_intr(hw, 0);
+
+        if (status & Y2_IS_IRQ_MAC2)
+                sky2_mac_intr(hw, 1);
+
+        sky2_write32(hw, B0_Y2_SP_ICR, 2);
+
+        sky2_read32(hw, B0_IMSK);
+
+        return IRQ_HANDLED;
+}
+
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void sky2_netpoll(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        sky2_intr(sky2->hw->pdev->irq, sky2->hw, NULL);
+}
+#endif
+
+/* Chip internal frequency for clock calculations */
+static inline u32 sky2_khz(const struct sky2_hw *hw)
+{
+        switch (hw->chip_id) {
+        case CHIP_ID_YUKON_EC:
+                return 125000;  /* 125 Mhz */
+        case CHIP_ID_YUKON_FE:
+                return 100000;  /* 100 Mhz */
+        default:                /* YUKON_XL */
+                return 156000;  /* 156 Mhz */
+        }
+}
+
+static inline u32 sky2_ms2clk(const struct sky2_hw *hw, u32 ms)
+{
+        return sky2_khz(hw) * ms;
+}
+
+static inline u32 sky2_us2clk(const struct sky2_hw *hw, u32 us)
+{
+        return (sky2_khz(hw) * us) / 1000;
+}
+
+static int sky2_reset(struct sky2_hw *hw)
+{
+        u32 ctst;
+        u16 status;
+        u8 t8, pmd_type;
+        int i;
+
+        ctst = sky2_read32(hw, B0_CTST);
+
+        sky2_write8(hw, B0_CTST, CS_RST_CLR);
+        hw->chip_id = sky2_read8(hw, B2_CHIP_ID);
+        if (hw->chip_id < CHIP_ID_YUKON_XL || hw->chip_id > CHIP_ID_YUKON_FE) {
+                printk(KERN_ERR PFX "%s: unsupported chip type 0x%x\n",
+                       pci_name(hw->pdev), hw->chip_id);
+                return -EOPNOTSUPP;
+        }
+
+        /* ring for status responses */
+        hw->st_le = pci_alloc_consistent(hw->pdev, STATUS_LE_BYTES,
+                                         &hw->st_dma);
+        if (!hw->st_le)
+                return -ENOMEM;
+
+        /* disable ASF */
+        if (hw->chip_id <= CHIP_ID_YUKON_EC) {
+                sky2_write8(hw, B28_Y2_ASF_STAT_CMD, Y2_ASF_RESET);
+                sky2_write16(hw, B0_CTST, Y2_ASF_DISABLE);
+        }
+
+        /* do a SW reset */
+        sky2_write8(hw, B0_CTST, CS_RST_SET);
+        sky2_write8(hw, B0_CTST, CS_RST_CLR);
+
+        /* clear PCI errors, if any */
+        pci_read_config_word(hw->pdev, PCI_STATUS, &status);
+        sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+        pci_write_config_word(hw->pdev, PCI_STATUS,
+                              status | PCI_STATUS_ERROR_BITS);
+
+        sky2_write8(hw, B0_CTST, CS_MRST_CLR);
+
+        /* clear any PEX errors */
+        if (is_pciex(hw)) {
+                u16 lstat;
+                pci_write_config_dword(hw->pdev, PEX_UNC_ERR_STAT,
+                                       0xffffffffUL);
+                pci_read_config_word(hw->pdev, PEX_LNK_STAT, &lstat);
+        }
+
+        pmd_type = sky2_read8(hw, B2_PMD_TYP);
+        hw->copper = !(pmd_type == 'L' || pmd_type == 'S');
+
+        hw->ports = 1;
+        t8 = sky2_read8(hw, B2_Y2_HW_RES);
+        if ((t8 & CFG_DUAL_MAC_MSK) == CFG_DUAL_MAC_MSK) {
+                if (!(sky2_read8(hw, B2_Y2_CLK_GATE) & Y2_STATUS_LNK2_INAC))
+                        ++hw->ports;
+        }
+        hw->chip_rev = (sky2_read8(hw, B2_MAC_CFG) & CFG_CHIP_R_MSK) >> 4;
+
+        sky2_set_power_state(hw, PCI_D0);
+
+        for (i = 0; i < hw->ports; i++) {
+                sky2_write8(hw, SK_REG(i, GMAC_LINK_CTRL), GMLC_RST_SET);
+                sky2_write8(hw, SK_REG(i, GMAC_LINK_CTRL), GMLC_RST_CLR);
+        }
+
+        sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
+
+        /* Clear I2C IRQ noise */
+        sky2_write32(hw, B2_I2C_IRQ, 1);
+
+        /* turn off hardware timer (unused) */
+        sky2_write8(hw, B2_TI_CTRL, TIM_STOP);
+        sky2_write8(hw, B2_TI_CTRL, TIM_CLR_IRQ);
+
+        sky2_write8(hw, B0_Y2LED, LED_STAT_ON);
+
+        /* Turn on descriptor polling (every 75us) */
+        sky2_write32(hw, B28_DPT_INI, sky2_us2clk(hw, 75));
+        sky2_write8(hw, B28_DPT_CTRL, DPT_START);
+
+        /* Turn off receive timestamp */
+        sky2_write8(hw, GMAC_TI_ST_CTRL, GMT_ST_STOP);
+        sky2_write8(hw, GMAC_TI_ST_CTRL, GMT_ST_CLR_IRQ);
+
+        /* enable the Tx Arbiters */
+        for (i = 0; i < hw->ports; i++)
+                sky2_write8(hw, SK_REG(i, TXA_CTRL), TXA_ENA_ARB);
+
+        /* Initialize ram interface */
+        for (i = 0; i < hw->ports; i++) {
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_CTRL), RI_RST_CLR);
+
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_R1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_XA1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_XS1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_R1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_XA1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_XS1), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_R2), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_XA2), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_WTO_XS2), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_R2), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_XA2), SK_RI_TO_53);
+                sky2_write8(hw, RAM_BUFFER(i, B3_RI_RTO_XS2), SK_RI_TO_53);
+        }
+
+        if (is_pciex(hw)) {
+                u16 pctrl;
+
+                /* change Max. Read Request Size to 2048 bytes */
+                pci_read_config_word(hw->pdev, PEX_DEV_CTRL, &pctrl);
+                pctrl &= ~PEX_DC_MAX_RRS_MSK;
+                pctrl |= PEX_DC_MAX_RD_RQ_SIZE(4);
+
+
+                sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+                pci_write_config_word(hw->pdev, PEX_DEV_CTRL, pctrl);
+                sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
+        }
+
+        sky2_write32(hw, B0_HWE_IMSK, Y2_HWE_ALL_MASK);
+
+        spin_lock_bh(&hw->phy_lock);
+        for (i = 0; i < hw->ports; i++)
+                sky2_phy_reset(hw, i);
+        spin_unlock_bh(&hw->phy_lock);
+
+        memset(hw->st_le, 0, STATUS_LE_BYTES);
+        hw->st_idx = 0;
+
+        sky2_write32(hw, STAT_CTRL, SC_STAT_RST_SET);
+        sky2_write32(hw, STAT_CTRL, SC_STAT_RST_CLR);
+
+        sky2_write32(hw, STAT_LIST_ADDR_LO, hw->st_dma);
+        sky2_write32(hw, STAT_LIST_ADDR_HI, (u64) hw->st_dma >> 32);
+
+        /* Set the list last index */
+        sky2_write16(hw, STAT_LAST_IDX, STATUS_RING_SIZE - 1);
+
+        sky2_write32(hw, STAT_TX_TIMER_INI, sky2_ms2clk(hw, 10));
+
+        /* These status setup values are copied from SysKonnect's driver */
+        if (is_ec_a1(hw)) {
+                /* WA for dev. #4.3 */
+                sky2_write16(hw, STAT_TX_IDX_TH, 0xfff);        /* Tx Threshold */
+
+                /* set Status-FIFO watermark */
+                sky2_write8(hw, STAT_FIFO_WM, 0x21);    /* WA for dev. #4.18 */
+
+                /* set Status-FIFO ISR watermark */
+                sky2_write8(hw, STAT_FIFO_ISR_WM, 0x07);        /* WA for dev. #4.18 */
+
+        } else {
+                sky2_write16(hw, STAT_TX_IDX_TH, 0x000a);
+
+                /* set Status-FIFO watermark */
+                sky2_write8(hw, STAT_FIFO_WM, 0x10);
+
+                /* set Status-FIFO ISR watermark */
+                if (hw->chip_id == CHIP_ID_YUKON_XL && hw->chip_rev == 0)
+                        sky2_write8(hw, STAT_FIFO_ISR_WM, 0x10);
+
+                else            /* WA dev 4.109 */
+                        sky2_write8(hw, STAT_FIFO_ISR_WM, 0x04);
+
+                sky2_write32(hw, STAT_ISR_TIMER_INI, 0x0190);
+        }
+
+        /* enable status unit */
+        sky2_write32(hw, STAT_CTRL, SC_STAT_OP_ON);
+
+        sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START);
+        sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_START);
+        sky2_write8(hw, STAT_ISR_TIMER_CTRL, TIM_START);
+
+        return 0;
+}
+
+static inline u32 sky2_supported_modes(const struct sky2_hw *hw)
+{
+        u32 modes;
+        if (hw->copper) {
+                modes = SUPPORTED_10baseT_Half
+                    | SUPPORTED_10baseT_Full
+                    | SUPPORTED_100baseT_Half
+                    | SUPPORTED_100baseT_Full
+                    | SUPPORTED_Autoneg | SUPPORTED_TP;
+
+                if (hw->chip_id != CHIP_ID_YUKON_FE)
+                        modes |= SUPPORTED_1000baseT_Half
+                            | SUPPORTED_1000baseT_Full;
+        } else
+                modes = SUPPORTED_1000baseT_Full | SUPPORTED_FIBRE
+                    | SUPPORTED_Autoneg;
+        return modes;
+}
+
+static int sky2_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+
+        ecmd->transceiver = XCVR_INTERNAL;
+        ecmd->supported = sky2_supported_modes(hw);
+        ecmd->phy_address = PHY_ADDR_MARV;
+        if (hw->copper) {
+                ecmd->supported = SUPPORTED_10baseT_Half
+                    | SUPPORTED_10baseT_Full
+                    | SUPPORTED_100baseT_Half
+                    | SUPPORTED_100baseT_Full
+                    | SUPPORTED_1000baseT_Half
+                    | SUPPORTED_1000baseT_Full
+                    | SUPPORTED_Autoneg | SUPPORTED_TP;
+                ecmd->port = PORT_TP;
+        } else
+                ecmd->port = PORT_FIBRE;
+
+        ecmd->advertising = sky2->advertising;
+        ecmd->autoneg = sky2->autoneg;
+        ecmd->speed = sky2->speed;
+        ecmd->duplex = sky2->duplex;
+        return 0;
+}
+
+static int sky2_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        const struct sky2_hw *hw = sky2->hw;
+        u32 supported = sky2_supported_modes(hw);
+
+        if (ecmd->autoneg == AUTONEG_ENABLE) {
+                ecmd->advertising = supported;
+                sky2->duplex = -1;
+                sky2->speed = -1;
+        } else {
+                u32 setting;
+
+                switch (ecmd->speed) {
+                case SPEED_1000:
+                        if (ecmd->duplex == DUPLEX_FULL)
+                                setting = SUPPORTED_1000baseT_Full;
+                        else if (ecmd->duplex == DUPLEX_HALF)
+                                setting = SUPPORTED_1000baseT_Half;
+                        else
+                                return -EINVAL;
+                        break;
+                case SPEED_100:
+                        if (ecmd->duplex == DUPLEX_FULL)
+                                setting = SUPPORTED_100baseT_Full;
+                        else if (ecmd->duplex == DUPLEX_HALF)
+                                setting = SUPPORTED_100baseT_Half;
+                        else
+                                return -EINVAL;
+                        break;
+
+                case SPEED_10:
+                        if (ecmd->duplex == DUPLEX_FULL)
+                                setting = SUPPORTED_10baseT_Full;
+                        else if (ecmd->duplex == DUPLEX_HALF)
+                                setting = SUPPORTED_10baseT_Half;
+                        else
+                                return -EINVAL;
+                        break;
+                default:
+                        return -EINVAL;
+                }
+
+                if ((setting & supported) == 0)
+                        return -EINVAL;
+
+                sky2->speed = ecmd->speed;
+                sky2->duplex = ecmd->duplex;
+        }
+
+        sky2->autoneg = ecmd->autoneg;
+        sky2->advertising = ecmd->advertising;
+
+        if (netif_running(dev)) {
+                sky2_down(dev);
+                sky2_up(dev);
+        }
+
+        return 0;
+}
+
+static void sky2_get_drvinfo(struct net_device *dev,
+                             struct ethtool_drvinfo *info)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        strcpy(info->driver, DRV_NAME);
+        strcpy(info->version, DRV_VERSION);
+        strcpy(info->fw_version, "N/A");
+        strcpy(info->bus_info, pci_name(sky2->hw->pdev));
+}
+
+static const struct sky2_stat {
+        char name[ETH_GSTRING_LEN];
+        u16 offset;
+} sky2_stats[] = {
+        { "tx_bytes",      GM_TXO_OK_HI },
+        { "rx_bytes",      GM_RXO_OK_HI },
+        { "tx_broadcast",  GM_TXF_BC_OK },
+        { "rx_broadcast",  GM_RXF_BC_OK },
+        { "tx_multicast",  GM_TXF_MC_OK },
+        { "rx_multicast",  GM_RXF_MC_OK },
+        { "tx_unicast",    GM_TXF_UC_OK },
+        { "rx_unicast",    GM_RXF_UC_OK },
+        { "tx_mac_pause",  GM_TXF_MPAUSE },
+        { "rx_mac_pause",  GM_RXF_MPAUSE },
+        { "collisions",    GM_TXF_SNG_COL },
+        { "late_collision",GM_TXF_LAT_COL },
+        { "aborted",       GM_TXF_ABO_COL },
+        { "multi_collisions", GM_TXF_MUL_COL },
+        { "fifo_underrun", GM_TXE_FIFO_UR },
+        { "fifo_overflow", GM_RXE_FIFO_OV },
+        { "rx_toolong",    GM_RXF_LNG_ERR },
+        { "rx_jabber",     GM_RXF_JAB_PKT },
+        { "rx_runt",       GM_RXE_FRAG },
+        { "rx_too_long",   GM_RXF_LNG_ERR },
+        { "rx_fcs_error",   GM_RXF_FCS_ERR },
+};
+
+static u32 sky2_get_rx_csum(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        return sky2->rx_csum;
+}
+
+static int sky2_set_rx_csum(struct net_device *dev, u32 data)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        sky2->rx_csum = data;
+
+        sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
+                     data ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
+
+        return 0;
+}
+
+static u32 sky2_get_msglevel(struct net_device *netdev)
+{
+        struct sky2_port *sky2 = netdev_priv(netdev);
+        return sky2->msg_enable;
+}
+
+static int sky2_nway_reset(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+
+        if (sky2->autoneg != AUTONEG_ENABLE)
+                return -EINVAL;
+
+        netif_stop_queue(dev);
+
+        spin_lock_irq(&hw->phy_lock);
+        sky2_phy_reset(hw, sky2->port);
+        sky2_phy_init(hw, sky2->port);
+        spin_unlock_irq(&hw->phy_lock);
+
+        return 0;
+}
+
+static void sky2_phy_stats(struct sky2_port *sky2, u64 * data, unsigned count)
+{
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        int i;
+
+        data[0] = (u64) gma_read32(hw, port, GM_TXO_OK_HI) << 32
+            | (u64) gma_read32(hw, port, GM_TXO_OK_LO);
+        data[1] = (u64) gma_read32(hw, port, GM_RXO_OK_HI) << 32
+            | (u64) gma_read32(hw, port, GM_RXO_OK_LO);
+
+        for (i = 2; i < count; i++)
+                data[i] = (u64) gma_read32(hw, port, sky2_stats[i].offset);
+}
+
+static void sky2_set_msglevel(struct net_device *netdev, u32 value)
+{
+        struct sky2_port *sky2 = netdev_priv(netdev);
+        sky2->msg_enable = value;
+}
+
+static int sky2_get_stats_count(struct net_device *dev)
+{
+        return ARRAY_SIZE(sky2_stats);
+}
+
+static void sky2_get_ethtool_stats(struct net_device *dev,
+                                   struct ethtool_stats *stats, u64 * data)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        sky2_phy_stats(sky2, data, ARRAY_SIZE(sky2_stats));
+}
+
+static void sky2_get_strings(struct net_device *dev, u32 stringset, u8 * data)
+{
+        int i;
+
+        switch (stringset) {
+        case ETH_SS_STATS:
+                for (i = 0; i < ARRAY_SIZE(sky2_stats); i++)
+                        memcpy(data + i * ETH_GSTRING_LEN,
+                               sky2_stats[i].name, ETH_GSTRING_LEN);
+                break;
+        }
+}
+
+/* Use hardware MIB variables for critical path statistics and
+ * transmit feedback not reported at interrupt.
+ * Other errors are accounted for in interrupt handler.
+ */
+static struct net_device_stats *sky2_get_stats(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        u64 data[13];
+
+        sky2_phy_stats(sky2, data, ARRAY_SIZE(data));
+
+        sky2->net_stats.tx_bytes = data[0];
+        sky2->net_stats.rx_bytes = data[1];
+        sky2->net_stats.tx_packets = data[2] + data[4] + data[6];
+        sky2->net_stats.rx_packets = data[3] + data[5] + data[7];
+        sky2->net_stats.multicast = data[5] + data[7];
+        sky2->net_stats.collisions = data[10];
+        sky2->net_stats.tx_aborted_errors = data[12];
+
+        return &sky2->net_stats;
+}
+
+static int sky2_set_mac_address(struct net_device *dev, void *p)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sockaddr *addr = p;
+        int err = 0;
+
+        if (!is_valid_ether_addr(addr->sa_data))
+                return -EADDRNOTAVAIL;
+
+        sky2_down(dev);
+        memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+        memcpy_toio(sky2->hw->regs + B2_MAC_1 + sky2->port * 8,
+                    dev->dev_addr, ETH_ALEN);
+        memcpy_toio(sky2->hw->regs + B2_MAC_2 + sky2->port * 8,
+                    dev->dev_addr, ETH_ALEN);
+        if (dev->flags & IFF_UP)
+                err = sky2_up(dev);
+        return err;
+}
+
+static void sky2_set_multicast(struct net_device *dev)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        struct dev_mc_list *list = dev->mc_list;
+        u16 reg;
+        u8 filter[8];
+
+        memset(filter, 0, sizeof(filter));
+
+        reg = gma_read16(hw, port, GM_RX_CTRL);
+        reg |= GM_RXCR_UCF_ENA;
+
+        if (dev->flags & IFF_PROMISC)   /* promiscuous */
+                reg &= ~(GM_RXCR_UCF_ENA | GM_RXCR_MCF_ENA);
+        else if ((dev->flags & IFF_ALLMULTI) || dev->mc_count > 16)     /* all multicast */
+                memset(filter, 0xff, sizeof(filter));
+        else if (dev->mc_count == 0)    /* no multicast */
+                reg &= ~GM_RXCR_MCF_ENA;
+        else {
+                int i;
+                reg |= GM_RXCR_MCF_ENA;
+
+                for (i = 0; list && i < dev->mc_count; i++, list = list->next) {
+                        u32 bit = ether_crc(ETH_ALEN, list->dmi_addr) & 0x3f;
+                        filter[bit / 8] |= 1 << (bit % 8);
+                }
+        }
+
+        gma_write16(hw, port, GM_MC_ADDR_H1,
+                    (u16) filter[0] | ((u16) filter[1] << 8));
+        gma_write16(hw, port, GM_MC_ADDR_H2,
+                    (u16) filter[2] | ((u16) filter[3] << 8));
+        gma_write16(hw, port, GM_MC_ADDR_H3,
+                    (u16) filter[4] | ((u16) filter[5] << 8));
+        gma_write16(hw, port, GM_MC_ADDR_H4,
+                    (u16) filter[6] | ((u16) filter[7] << 8));
+
+        gma_write16(hw, port, GM_RX_CTRL, reg);
+}
+
+/* Can have one global because blinking is controlled by
+ * ethtool and that is always under RTNL mutex
+ */
+static inline void sky2_led(struct sky2_hw *hw, unsigned port, int on)
+{
+        u16 pg;
+
+        spin_lock_bh(&hw->phy_lock);
+        switch (hw->chip_id) {
+        case CHIP_ID_YUKON_XL:
+                pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL,
+                             on ? (PHY_M_LEDC_LOS_CTRL(1) |
+                                   PHY_M_LEDC_INIT_CTRL(7) |
+                                   PHY_M_LEDC_STA1_CTRL(7) |
+                                   PHY_M_LEDC_STA0_CTRL(7))
+                             : 0);
+
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
+                break;
+
+        default:
+                gm_phy_write(hw, port, PHY_MARV_LED_CTRL, 0);
+                gm_phy_write(hw, port, PHY_MARV_LED_OVER,
+                             on ? PHY_M_LED_MO_DUP(MO_LED_ON) |
+                             PHY_M_LED_MO_10(MO_LED_ON) |
+                             PHY_M_LED_MO_100(MO_LED_ON) |
+                             PHY_M_LED_MO_1000(MO_LED_ON) |
+                             PHY_M_LED_MO_RX(MO_LED_ON)
+                             : PHY_M_LED_MO_DUP(MO_LED_OFF) |
+                             PHY_M_LED_MO_10(MO_LED_OFF) |
+                             PHY_M_LED_MO_100(MO_LED_OFF) |
+                             PHY_M_LED_MO_1000(MO_LED_OFF) |
+                             PHY_M_LED_MO_RX(MO_LED_OFF));
+
+        }
+        spin_unlock_bh(&hw->phy_lock);
+}
+
+/* blink LED's for finding board */
+static int sky2_phys_id(struct net_device *dev, u32 data)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+        unsigned port = sky2->port;
+        u16 ledctrl, ledover = 0;
+        long ms;
+        int onoff = 1;
+
+        if (!data || data > (u32) (MAX_SCHEDULE_TIMEOUT / HZ))
+                ms = jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT);
+        else
+                ms = data * 1000;
+
+        /* save initial values */
+        spin_lock_bh(&hw->phy_lock);
+        if (hw->chip_id == CHIP_ID_YUKON_XL) {
+                u16 pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
+                ledctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
+        } else {
+                ledctrl = gm_phy_read(hw, port, PHY_MARV_LED_CTRL);
+                ledover = gm_phy_read(hw, port, PHY_MARV_LED_OVER);
+        }
+        spin_unlock_bh(&hw->phy_lock);
+
+        while (ms > 0) {
+                sky2_led(hw, port, onoff);
+                onoff = !onoff;
+
+                if (msleep_interruptible(250))
+                        break;  /* interrupted */
+                ms -= 250;
+        }
+
+        /* resume regularly scheduled programming */
+        spin_lock_bh(&hw->phy_lock);
+        if (hw->chip_id == CHIP_ID_YUKON_XL) {
+                u16 pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
+                gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ledctrl);
+                gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
+        } else {
+                gm_phy_write(hw, port, PHY_MARV_LED_CTRL, ledctrl);
+                gm_phy_write(hw, port, PHY_MARV_LED_OVER, ledover);
+        }
+        spin_unlock_bh(&hw->phy_lock);
+
+        return 0;
+}
+
+static void sky2_get_pauseparam(struct net_device *dev,
+                                struct ethtool_pauseparam *ecmd)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        ecmd->tx_pause = sky2->tx_pause;
+        ecmd->rx_pause = sky2->rx_pause;
+        ecmd->autoneg = sky2->autoneg;
+}
+
+static int sky2_set_pauseparam(struct net_device *dev,
+                               struct ethtool_pauseparam *ecmd)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        int err = 0;
+
+        sky2->autoneg = ecmd->autoneg;
+        sky2->tx_pause = ecmd->tx_pause != 0;
+        sky2->rx_pause = ecmd->rx_pause != 0;
+
+        if (netif_running(dev)) {
+                sky2_down(dev);
+                err = sky2_up(dev);
+        }
+
+        return err;
+}
+
+#ifdef CONFIG_PM
+static void sky2_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        wol->supported = WAKE_MAGIC;
+        wol->wolopts = sky2->wol ? WAKE_MAGIC : 0;
+}
+
+static int sky2_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        struct sky2_hw *hw = sky2->hw;
+
+        if (wol->wolopts != WAKE_MAGIC && wol->wolopts != 0)
+                return -EOPNOTSUPP;
+
+        sky2->wol = wol->wolopts == WAKE_MAGIC;
+
+        if (sky2->wol) {
+                memcpy_toio(hw->regs + WOL_MAC_ADDR, dev->dev_addr, ETH_ALEN);
+
+                sky2_write16(hw, WOL_CTRL_STAT,
+                             WOL_CTL_ENA_PME_ON_MAGIC_PKT |
+                             WOL_CTL_ENA_MAGIC_PKT_UNIT);
+        } else
+                sky2_write16(hw, WOL_CTRL_STAT, WOL_CTL_DEFAULT);
+
+        return 0;
+}
+#endif
+
+static void sky2_get_ringparam(struct net_device *dev,
+                               struct ethtool_ringparam *ering)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+
+        ering->rx_max_pending = RX_MAX_PENDING;
+        ering->rx_mini_max_pending = 0;
+        ering->rx_jumbo_max_pending = 0;
+        ering->tx_max_pending = TX_RING_SIZE - 1;
+
+        ering->rx_pending = sky2->rx_pending;
+        ering->rx_mini_pending = 0;
+        ering->rx_jumbo_pending = 0;
+        ering->tx_pending = sky2->tx_pending;
+}
+
+static int sky2_set_ringparam(struct net_device *dev,
+                              struct ethtool_ringparam *ering)
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        int err = 0;
+
+        if (ering->rx_pending > RX_MAX_PENDING ||
+            ering->rx_pending < 8 ||
+            ering->tx_pending < MAX_SKB_TX_LE ||
+            ering->tx_pending > TX_RING_SIZE - 1)
+                return -EINVAL;
+
+        if (netif_running(dev))
+                sky2_down(dev);
+
+        sky2->rx_pending = ering->rx_pending;
+        sky2->tx_pending = ering->tx_pending;
+
+        if (netif_running(dev))
+                err = sky2_up(dev);
+
+        return err;
+}
+
+static int sky2_get_regs_len(struct net_device *dev)
+{
+        return 0x4000;
+}
+
+/*
+ * Returns copy of control register region
+ * Note: access to the RAM address register set will cause timeouts.
+ */
+static void sky2_get_regs(struct net_device *dev, struct ethtool_regs *regs,
+                          void *p)
+{
+        const struct sky2_port *sky2 = netdev_priv(dev);
+        const void __iomem *io = sky2->hw->regs;
+
+        BUG_ON(regs->len < B3_RI_WTO_R1);
+        regs->version = 1;
+        memset(p, 0, regs->len);
+
+        memcpy_fromio(p, io, B3_RAM_ADDR);
+
+        memcpy_fromio(p + B3_RI_WTO_R1,
+                      io + B3_RI_WTO_R1,
+                      regs->len - B3_RI_WTO_R1);
+}
+
+static struct ethtool_ops sky2_ethtool_ops = {
+        .get_settings = sky2_get_settings,
+        .set_settings = sky2_set_settings,
+        .get_drvinfo = sky2_get_drvinfo,
+        .get_msglevel = sky2_get_msglevel,
+        .set_msglevel = sky2_set_msglevel,
+        .nway_reset   = sky2_nway_reset,
+        .get_regs_len = sky2_get_regs_len,
+        .get_regs = sky2_get_regs,
+        .get_link = ethtool_op_get_link,
+        .get_sg = ethtool_op_get_sg,
+        .set_sg = ethtool_op_set_sg,
+        .get_tx_csum = ethtool_op_get_tx_csum,
+        .set_tx_csum = ethtool_op_set_tx_csum,
+        .get_tso = ethtool_op_get_tso,
+        .set_tso = ethtool_op_set_tso,
+        .get_rx_csum = sky2_get_rx_csum,
+        .set_rx_csum = sky2_set_rx_csum,
+        .get_strings = sky2_get_strings,
+        .get_ringparam = sky2_get_ringparam,
+        .set_ringparam = sky2_set_ringparam,
+        .get_pauseparam = sky2_get_pauseparam,
+        .set_pauseparam = sky2_set_pauseparam,
+#ifdef CONFIG_PM
+        .get_wol = sky2_get_wol,
+        .set_wol = sky2_set_wol,
+#endif
+        .phys_id = sky2_phys_id,
+        .get_stats_count = sky2_get_stats_count,
+        .get_ethtool_stats = sky2_get_ethtool_stats,
+        .get_perm_addr  = ethtool_op_get_perm_addr,
+};
+
+/* Initialize network device */
+static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
+                                                     unsigned port, int highmem)
+{
+        struct sky2_port *sky2;
+        struct net_device *dev = alloc_etherdev(sizeof(*sky2));
+
+        if (!dev) {
+                printk(KERN_ERR "sky2 etherdev alloc failed");
+                return NULL;
+        }
+
+        SET_MODULE_OWNER(dev);
+        SET_NETDEV_DEV(dev, &hw->pdev->dev);
+        dev->open = sky2_up;
+        dev->stop = sky2_down;
+        dev->hard_start_xmit = sky2_xmit_frame;
+        dev->get_stats = sky2_get_stats;
+        dev->set_multicast_list = sky2_set_multicast;
+        dev->set_mac_address = sky2_set_mac_address;
+        dev->change_mtu = sky2_change_mtu;
+        SET_ETHTOOL_OPS(dev, &sky2_ethtool_ops);
+        dev->tx_timeout = sky2_tx_timeout;
+        dev->watchdog_timeo = TX_WATCHDOG;
+        if (port == 0)
+                dev->poll = sky2_poll;
+        dev->weight = NAPI_WEIGHT;
+#ifdef CONFIG_NET_POLL_CONTROLLER
+        dev->poll_controller = sky2_netpoll;
+#endif
+
+        sky2 = netdev_priv(dev);
+        sky2->netdev = dev;
+        sky2->hw = hw;
+        sky2->msg_enable = netif_msg_init(debug, default_msg);
+
+        spin_lock_init(&sky2->tx_lock);
+        /* Auto speed and flow control */
+        sky2->autoneg = AUTONEG_ENABLE;
+        sky2->tx_pause = 0;
+        sky2->rx_pause = 1;
+        sky2->duplex = -1;
+        sky2->speed = -1;
+        sky2->advertising = sky2_supported_modes(hw);
+        sky2->rx_csum = 1;
+        tasklet_init(&sky2->phy_task, sky2_phy_task, (unsigned long)sky2);
+        sky2->tx_pending = TX_DEF_PENDING;
+        sky2->rx_pending = is_ec_a1(hw) ? 8 : RX_DEF_PENDING;
+
+        hw->dev[port] = dev;
+
+        sky2->port = port;
+
+        dev->features |= NETIF_F_LLTX | NETIF_F_TSO;
+        if (highmem)
+                dev->features |= NETIF_F_HIGHDMA;
+        dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
+
+#ifdef SKY2_VLAN_TAG_USED
+        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        dev->vlan_rx_register = sky2_vlan_rx_register;
+        dev->vlan_rx_kill_vid = sky2_vlan_rx_kill_vid;
+#endif
+
+        /* read the mac address */
+        memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8, ETH_ALEN);
+        memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
+
+        /* device is off until link detection */
+        netif_carrier_off(dev);
+        netif_stop_queue(dev);
+
+        return dev;
+}
+
+static inline void sky2_show_addr(struct net_device *dev)
+{
+        const struct sky2_port *sky2 = netdev_priv(dev);
+
+        if (netif_msg_probe(sky2))
+                printk(KERN_INFO PFX "%s: addr %02x:%02x:%02x:%02x:%02x:%02x\n",
+                       dev->name,
+                       dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2],
+                       dev->dev_addr[3], dev->dev_addr[4], dev->dev_addr[5]);
+}
+
+static int __devinit sky2_probe(struct pci_dev *pdev,
+                                const struct pci_device_id *ent)
+{
+        struct net_device *dev, *dev1 = NULL;
+        struct sky2_hw *hw;
+        int err, pm_cap, using_dac = 0;
+
+        err = pci_enable_device(pdev);
+        if (err) {
+                printk(KERN_ERR PFX "%s cannot enable PCI device\n",
+                       pci_name(pdev));
+                goto err_out;
+        }
+
+        err = pci_request_regions(pdev, DRV_NAME);
+        if (err) {
+                printk(KERN_ERR PFX "%s cannot obtain PCI resources\n",
+                       pci_name(pdev));
+                goto err_out;
+        }
+
+        pci_set_master(pdev);
+
+        /* Find power-management capability. */
+        pm_cap = pci_find_capability(pdev, PCI_CAP_ID_PM);
+        if (pm_cap == 0) {
+                printk(KERN_ERR PFX "Cannot find PowerManagement capability, "
+                       "aborting.\n");
+                err = -EIO;
+                goto err_out_free_regions;
+        }
+
+        if (sizeof(dma_addr_t) > sizeof(u32)) {
+                err = pci_set_dma_mask(pdev, DMA_64BIT_MASK);
+                if (!err)
+                        using_dac = 1;
+        }
+
+        if (!using_dac) {
+                err = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
+                if (err) {
+                        printk(KERN_ERR PFX "%s no usable DMA configuration\n",
+                               pci_name(pdev));
+                        goto err_out_free_regions;
+                }
+        }
+#ifdef __BIG_ENDIAN
+        /* byte swap descriptors in hardware */
+        {
+                u32 reg;
+
+                pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);
+                reg |= PCI_REV_DESC;
+                pci_write_config_dword(pdev, PCI_DEV_REG2, reg);
+        }
+#endif
+
+        err = -ENOMEM;
+        hw = kmalloc(sizeof(*hw), GFP_KERNEL);
+        if (!hw) {
+                printk(KERN_ERR PFX "%s: cannot allocate hardware struct\n",
+                       pci_name(pdev));
+                goto err_out_free_regions;
+        }
+
+        memset(hw, 0, sizeof(*hw));
+        hw->pdev = pdev;
+        spin_lock_init(&hw->phy_lock);
+
+        hw->regs = ioremap_nocache(pci_resource_start(pdev, 0), 0x4000);
+        if (!hw->regs) {
+                printk(KERN_ERR PFX "%s: cannot map device registers\n",
+                       pci_name(pdev));
+                goto err_out_free_hw;
+        }
+        hw->pm_cap = pm_cap;
+
+        err = sky2_reset(hw);
+        if (err)
+                goto err_out_iounmap;
+
+        printk(KERN_INFO PFX "addr 0x%lx irq %d Yukon-%s (0x%x) rev %d\n",
+               pci_resource_start(pdev, 0), pdev->irq,
+               yukon_name[hw->chip_id - CHIP_ID_YUKON],
+               hw->chip_id, hw->chip_rev);
+
+        dev = sky2_init_netdev(hw, 0, using_dac);
+        if (!dev)
+                goto err_out_free_pci;
+
+        err = register_netdev(dev);
+        if (err) {
+                printk(KERN_ERR PFX "%s: cannot register net device\n",
+                       pci_name(pdev));
+                goto err_out_free_netdev;
+        }
+
+        sky2_show_addr(dev);
+
+        if (hw->ports > 1 && (dev1 = sky2_init_netdev(hw, 1, using_dac))) {
+                if (register_netdev(dev1) == 0)
+                        sky2_show_addr(dev1);
+                else {
+                        /* Failure to register second port need not be fatal */
+                        printk(KERN_WARNING PFX
+                               "register of second port failed\n");
+                        hw->dev[1] = NULL;
+                        free_netdev(dev1);
+                }
+        }
+
+        err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw);
+        if (err) {
+                printk(KERN_ERR PFX "%s: cannot assign irq %d\n",
+                       pci_name(pdev), pdev->irq);
+                goto err_out_unregister;
+        }
+
+        hw->intr_mask = Y2_IS_BASE;
+        sky2_write32(hw, B0_IMSK, hw->intr_mask);
+
+        pci_set_drvdata(pdev, hw);
+
+        return 0;
+
+err_out_unregister:
+        if (dev1) {
+                unregister_netdev(dev1);
+                free_netdev(dev1);
+        }
+        unregister_netdev(dev);
+err_out_free_netdev:
+        free_netdev(dev);
+err_out_free_pci:
+        sky2_write8(hw, B0_CTST, CS_RST_SET);
+        pci_free_consistent(hw->pdev, STATUS_LE_BYTES, hw->st_le, hw->st_dma);
+err_out_iounmap:
+        iounmap(hw->regs);
+err_out_free_hw:
+        kfree(hw);
+err_out_free_regions:
+        pci_release_regions(pdev);
+        pci_disable_device(pdev);
+err_out:
+        return err;
+}
+
+static void __devexit sky2_remove(struct pci_dev *pdev)
+{
+        struct sky2_hw *hw = pci_get_drvdata(pdev);
+        struct net_device *dev0, *dev1;
+
+        if (!hw)
+                return;
+
+        dev0 = hw->dev[0];
+        dev1 = hw->dev[1];
+        if (dev1)
+                unregister_netdev(dev1);
+        unregister_netdev(dev0);
+
+        sky2_write32(hw, B0_IMSK, 0);
+        sky2_set_power_state(hw, PCI_D3hot);
+        sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
+        sky2_write8(hw, B0_CTST, CS_RST_SET);
+        sky2_read8(hw, B0_CTST);
+
+        free_irq(pdev->irq, hw);
+        pci_free_consistent(pdev, STATUS_LE_BYTES, hw->st_le, hw->st_dma);
+        pci_release_regions(pdev);
+        pci_disable_device(pdev);
+
+        if (dev1)
+                free_netdev(dev1);
+        free_netdev(dev0);
+        iounmap(hw->regs);
+        kfree(hw);
+
+        pci_set_drvdata(pdev, NULL);
+}
+
+#ifdef CONFIG_PM
+static int sky2_suspend(struct pci_dev *pdev, pm_message_t state)
+{
+        struct sky2_hw *hw = pci_get_drvdata(pdev);
+        int i;
+
+        for (i = 0; i < 2; i++) {
+                struct net_device *dev = hw->dev[i];
+
+                if (dev) {
+                        if (!netif_running(dev))
+                                continue;
+
+                        sky2_down(dev);
+                        netif_device_detach(dev);
+                }
+        }
+
+        return sky2_set_power_state(hw, pci_choose_state(pdev, state));
+}
+
+static int sky2_resume(struct pci_dev *pdev)
+{
+        struct sky2_hw *hw = pci_get_drvdata(pdev);
+        int i;
+
+        pci_restore_state(pdev);
+        pci_enable_wake(pdev, PCI_D0, 0);
+        sky2_set_power_state(hw, PCI_D0);
+
+        sky2_reset(hw);
+
+        for (i = 0; i < 2; i++) {
+                struct net_device *dev = hw->dev[i];
+                if (dev) {
+                        if (netif_running(dev)) {
+                                netif_device_attach(dev);
+                                sky2_up(dev);
+                        }
+                }
+        }
+        return 0;
+}
+#endif
+
+static struct pci_driver sky2_driver = {
+        .name = DRV_NAME,
+        .id_table = sky2_id_table,
+        .probe = sky2_probe,
+        .remove = __devexit_p(sky2_remove),
+#ifdef CONFIG_PM
+        .suspend = sky2_suspend,
+        .resume = sky2_resume,
+#endif
+};
+
+static int __init sky2_init_module(void)
+{
+        return pci_module_init(&sky2_driver);
+}
+
+static void __exit sky2_cleanup_module(void)
+{
+        pci_unregister_driver(&sky2_driver);
+}
+
+module_init(sky2_init_module);
+module_exit(sky2_cleanup_module);
+
+MODULE_DESCRIPTION("Marvell Yukon 2 Gigabit Ethernet driver");
+MODULE_AUTHOR("Stephen Hemminger <shemminger@osdl.org>");
+MODULE_LICENSE("GPL");
diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
new file mode 100644
index 000000000000..629d08f170fd
--- /dev/null
+++ b/drivers/net/sky2.h
@@ -0,0 +1,1910 @@
+/*
+ * Definitions for the new Marvell Yukon 2 driver.
+ */
+#ifndef _SKY2_H
+#define _SKY2_H
+
+/* PCI config registers */
+#define PCI_DEV_REG1    0x40
+#define PCI_DEV_REG2    0x44
+#define PCI_DEV_STATUS  0x7c
+#define PCI_OS_PCI_X    (1<<26)
+
+#define PEX_LNK_STAT    0xf2
+#define PEX_UNC_ERR_STAT 0x104
+#define PEX_DEV_CTRL    0xe8
+
+/* Yukon-2 */
+enum pci_dev_reg_1 {
+        PCI_Y2_PIG_ENA   = 1<<31, /* Enable Plug-in-Go (YUKON-2) */
+        PCI_Y2_DLL_DIS   = 1<<30, /* Disable PCI DLL (YUKON-2) */
+        PCI_Y2_PHY2_COMA = 1<<29, /* Set PHY 2 to Coma Mode (YUKON-2) */
+        PCI_Y2_PHY1_COMA = 1<<28, /* Set PHY 1 to Coma Mode (YUKON-2) */
+        PCI_Y2_PHY2_POWD = 1<<27, /* Set PHY 2 to Power Down (YUKON-2) */
+        PCI_Y2_PHY1_POWD = 1<<26, /* Set PHY 1 to Power Down (YUKON-2) */
+};
+
+enum pci_dev_reg_2 {
+        PCI_VPD_WR_THR  = 0xffL<<24,    /* Bit 31..24:  VPD Write Threshold */
+        PCI_DEV_SEL     = 0x7fL<<17,    /* Bit 23..17:  EEPROM Device Select */
+        PCI_VPD_ROM_SZ  = 7L<<14,       /* Bit 16..14:  VPD ROM Size    */
+
+        PCI_PATCH_DIR   = 0xfL<<8,      /* Bit 11.. 8:  Ext Patches dir 3..0 */
+        PCI_EXT_PATCHS  = 0xfL<<4,      /* Bit  7.. 4:  Extended Patches 3..0 */
+        PCI_EN_DUMMY_RD = 1<<3,         /* Enable Dummy Read */
+        PCI_REV_DESC    = 1<<2,         /* Reverse Desc. Bytes */
+
+        PCI_USEDATA64   = 1<<0,         /* Use 64Bit Data bus ext */
+};
+
+
+#define PCI_STATUS_ERROR_BITS (PCI_STATUS_DETECTED_PARITY | \
+                               PCI_STATUS_SIG_SYSTEM_ERROR | \
+                               PCI_STATUS_REC_MASTER_ABORT | \
+                               PCI_STATUS_REC_TARGET_ABORT | \
+                               PCI_STATUS_PARITY)
+
+enum pex_dev_ctrl {
+        PEX_DC_MAX_RRS_MSK      = 7<<12, /* Bit 14..12: Max. Read Request Size */
+        PEX_DC_EN_NO_SNOOP      = 1<<11,/* Enable No Snoop */
+        PEX_DC_EN_AUX_POW       = 1<<10,/* Enable AUX Power */
+        PEX_DC_EN_PHANTOM       = 1<<9, /* Enable Phantom Functions */
+        PEX_DC_EN_EXT_TAG       = 1<<8, /* Enable Extended Tag Field */
+        PEX_DC_MAX_PLS_MSK      = 7<<5, /* Bit  7.. 5:  Max. Payload Size Mask */
+        PEX_DC_EN_REL_ORD       = 1<<4, /* Enable Relaxed Ordering */
+        PEX_DC_EN_UNS_RQ_RP     = 1<<3, /* Enable Unsupported Request Reporting */
+        PEX_DC_EN_FAT_ER_RP     = 1<<2, /* Enable Fatal Error Reporting */
+        PEX_DC_EN_NFA_ER_RP     = 1<<1, /* Enable Non-Fatal Error Reporting */
+        PEX_DC_EN_COR_ER_RP     = 1<<0, /* Enable Correctable Error Reporting */
+};
+#define  PEX_DC_MAX_RD_RQ_SIZE(x) (((x)<<12) & PEX_DC_MAX_RRS_MSK)
+
+/* PEX_UNC_ERR_STAT      PEX Uncorrectable Errors Status Register (Yukon-2) */
+enum pex_err {
+        PEX_UNSUP_REQ   = 1<<20, /* Unsupported Request Error */
+
+        PEX_MALFOR_TLP  = 1<<18, /* Malformed TLP */
+
+        PEX_UNEXP_COMP  = 1<<16, /* Unexpected Completion */
+
+        PEX_COMP_TO     = 1<<14, /* Completion Timeout */
+        PEX_FLOW_CTRL_P = 1<<13, /* Flow Control Protocol Error */
+        PEX_POIS_TLP    = 1<<12, /* Poisoned TLP */
+
+        PEX_DATA_LINK_P = 1<<4, /* Data Link Protocol Error */
+        PEX_FATAL_ERRORS= (PEX_MALFOR_TLP | PEX_FLOW_CTRL_P | PEX_DATA_LINK_P),
+};
+
+
+enum csr_regs {
+        B0_RAP          = 0x0000,
+        B0_CTST         = 0x0004,
+        B0_Y2LED        = 0x0005,
+        B0_POWER_CTRL   = 0x0007,
+        B0_ISRC         = 0x0008,
+        B0_IMSK         = 0x000c,
+        B0_HWE_ISRC     = 0x0010,
+        B0_HWE_IMSK     = 0x0014,
+
+        /* Special ISR registers (Yukon-2 only) */
+        B0_Y2_SP_ISRC2  = 0x001c,
+        B0_Y2_SP_ISRC3  = 0x0020,
+        B0_Y2_SP_EISR   = 0x0024,
+        B0_Y2_SP_LISR   = 0x0028,
+        B0_Y2_SP_ICR    = 0x002c,
+
+        B2_MAC_1        = 0x0100,
+        B2_MAC_2        = 0x0108,
+        B2_MAC_3        = 0x0110,
+        B2_CONN_TYP     = 0x0118,
+        B2_PMD_TYP      = 0x0119,
+        B2_MAC_CFG      = 0x011a,
+        B2_CHIP_ID      = 0x011b,
+        B2_E_0          = 0x011c,
+
+        B2_Y2_CLK_GATE  = 0x011d,
+        B2_Y2_HW_RES    = 0x011e,
+        B2_E_3          = 0x011f,
+        B2_Y2_CLK_CTRL  = 0x0120,
+
+        B2_TI_INI       = 0x0130,
+        B2_TI_VAL       = 0x0134,
+        B2_TI_CTRL      = 0x0138,
+        B2_TI_TEST      = 0x0139,
+
+        B2_TST_CTRL1    = 0x0158,
+        B2_TST_CTRL2    = 0x0159,
+        B2_GP_IO        = 0x015c,
+
+        B2_I2C_CTRL     = 0x0160,
+        B2_I2C_DATA     = 0x0164,
+        B2_I2C_IRQ      = 0x0168,
+        B2_I2C_SW       = 0x016c,
+
+        B3_RAM_ADDR     = 0x0180,
+        B3_RAM_DATA_LO  = 0x0184,
+        B3_RAM_DATA_HI  = 0x0188,
+
+/* RAM Interface Registers */
+/* Yukon-2: use RAM_BUFFER() to access the RAM buffer */
+/*
+ * The HW-Spec. calls this registers Timeout Value 0..11. But this names are
+ * not usable in SW. Please notice these are NOT real timeouts, these are
+ * the number of qWords transferred continuously.
+ */
+#define RAM_BUFFER(port, reg)   (reg | (port <<6))
+
+        B3_RI_WTO_R1    = 0x0190,
+        B3_RI_WTO_XA1   = 0x0191,
+        B3_RI_WTO_XS1   = 0x0192,
+        B3_RI_RTO_R1    = 0x0193,
+        B3_RI_RTO_XA1   = 0x0194,
+        B3_RI_RTO_XS1   = 0x0195,
+        B3_RI_WTO_R2    = 0x0196,
+        B3_RI_WTO_XA2   = 0x0197,
+        B3_RI_WTO_XS2   = 0x0198,
+        B3_RI_RTO_R2    = 0x0199,
+        B3_RI_RTO_XA2   = 0x019a,
+        B3_RI_RTO_XS2   = 0x019b,
+        B3_RI_TO_VAL    = 0x019c,
+        B3_RI_CTRL      = 0x01a0,
+        B3_RI_TEST      = 0x01a2,
+        B3_MA_TOINI_RX1 = 0x01b0,
+        B3_MA_TOINI_RX2 = 0x01b1,
+        B3_MA_TOINI_TX1 = 0x01b2,
+        B3_MA_TOINI_TX2 = 0x01b3,
+        B3_MA_TOVAL_RX1 = 0x01b4,
+        B3_MA_TOVAL_RX2 = 0x01b5,
+        B3_MA_TOVAL_TX1 = 0x01b6,
+        B3_MA_TOVAL_TX2 = 0x01b7,
+        B3_MA_TO_CTRL   = 0x01b8,
+        B3_MA_TO_TEST   = 0x01ba,
+        B3_MA_RCINI_RX1 = 0x01c0,
+        B3_MA_RCINI_RX2 = 0x01c1,
+        B3_MA_RCINI_TX1 = 0x01c2,
+        B3_MA_RCINI_TX2 = 0x01c3,
+        B3_MA_RCVAL_RX1 = 0x01c4,
+        B3_MA_RCVAL_RX2 = 0x01c5,
+        B3_MA_RCVAL_TX1 = 0x01c6,
+        B3_MA_RCVAL_TX2 = 0x01c7,
+        B3_MA_RC_CTRL   = 0x01c8,
+        B3_MA_RC_TEST   = 0x01ca,
+        B3_PA_TOINI_RX1 = 0x01d0,
+        B3_PA_TOINI_RX2 = 0x01d4,
+        B3_PA_TOINI_TX1 = 0x01d8,
+        B3_PA_TOINI_TX2 = 0x01dc,
+        B3_PA_TOVAL_RX1 = 0x01e0,
+        B3_PA_TOVAL_RX2 = 0x01e4,
+        B3_PA_TOVAL_TX1 = 0x01e8,
+        B3_PA_TOVAL_TX2 = 0x01ec,
+        B3_PA_CTRL      = 0x01f0,
+        B3_PA_TEST      = 0x01f2,
+
+        Y2_CFG_SPC      = 0x1c00,
+};
+
+/*      B0_CTST                 16 bit  Control/Status register */
+enum {
+        Y2_VMAIN_AVAIL  = 1<<17,/* VMAIN available (YUKON-2 only) */
+        Y2_VAUX_AVAIL   = 1<<16,/* VAUX available (YUKON-2 only) */
+        Y2_ASF_ENABLE   = 1<<13,/* ASF Unit Enable (YUKON-2 only) */
+        Y2_ASF_DISABLE  = 1<<12,/* ASF Unit Disable (YUKON-2 only) */
+        Y2_CLK_RUN_ENA  = 1<<11,/* CLK_RUN Enable  (YUKON-2 only) */
+        Y2_CLK_RUN_DIS  = 1<<10,/* CLK_RUN Disable (YUKON-2 only) */
+        Y2_LED_STAT_ON  = 1<<9, /* Status LED On  (YUKON-2 only) */
+        Y2_LED_STAT_OFF = 1<<8, /* Status LED Off (YUKON-2 only) */
+
+        CS_ST_SW_IRQ    = 1<<7, /* Set IRQ SW Request */
+        CS_CL_SW_IRQ    = 1<<6, /* Clear IRQ SW Request */
+        CS_STOP_DONE    = 1<<5, /* Stop Master is finished */
+        CS_STOP_MAST    = 1<<4, /* Command Bit to stop the master */
+        CS_MRST_CLR     = 1<<3, /* Clear Master reset   */
+        CS_MRST_SET     = 1<<2, /* Set Master reset     */
+        CS_RST_CLR      = 1<<1, /* Clear Software reset */
+        CS_RST_SET      = 1,    /* Set   Software reset */
+};
+
+/*      B0_LED                   8 Bit  LED register */
+enum {
+/* Bit  7.. 2:  reserved */
+        LED_STAT_ON     = 1<<1, /* Status LED on        */
+        LED_STAT_OFF    = 1,    /* Status LED off       */
+};
+
+/*      B0_POWER_CTRL    8 Bit  Power Control reg (YUKON only) */
+enum {
+        PC_VAUX_ENA     = 1<<7, /* Switch VAUX Enable  */
+        PC_VAUX_DIS     = 1<<6, /* Switch VAUX Disable */
+        PC_VCC_ENA      = 1<<5, /* Switch VCC Enable  */
+        PC_VCC_DIS      = 1<<4, /* Switch VCC Disable */
+        PC_VAUX_ON      = 1<<3, /* Switch VAUX On  */
+        PC_VAUX_OFF     = 1<<2, /* Switch VAUX Off */
+        PC_VCC_ON       = 1<<1, /* Switch VCC On  */
+        PC_VCC_OFF      = 1<<0, /* Switch VCC Off */
+};
+
+/*      B2_IRQM_MSK     32 bit  IRQ Moderation Mask */
+
+/*      B0_Y2_SP_ISRC2  32 bit  Special Interrupt Source Reg 2 */
+/*      B0_Y2_SP_ISRC3  32 bit  Special Interrupt Source Reg 3 */
+/*      B0_Y2_SP_EISR   32 bit  Enter ISR Reg */
+/*      B0_Y2_SP_LISR   32 bit  Leave ISR Reg */
+enum {
+        Y2_IS_HW_ERR    = 1<<31,        /* Interrupt HW Error */
+        Y2_IS_STAT_BMU  = 1<<30,        /* Status BMU Interrupt */
+        Y2_IS_ASF       = 1<<29,        /* ASF subsystem Interrupt */
+
+        Y2_IS_POLL_CHK  = 1<<27,        /* Check IRQ from polling unit */
+        Y2_IS_TWSI_RDY  = 1<<26,        /* IRQ on end of TWSI Tx */
+        Y2_IS_IRQ_SW    = 1<<25,        /* SW forced IRQ        */
+        Y2_IS_TIMINT    = 1<<24,        /* IRQ from Timer       */
+
+        Y2_IS_IRQ_PHY2  = 1<<12,        /* Interrupt from PHY 2 */
+        Y2_IS_IRQ_MAC2  = 1<<11,        /* Interrupt from MAC 2 */
+        Y2_IS_CHK_RX2   = 1<<10,        /* Descriptor error Rx 2 */
+        Y2_IS_CHK_TXS2  = 1<<9,         /* Descriptor error TXS 2 */
+        Y2_IS_CHK_TXA2  = 1<<8,         /* Descriptor error TXA 2 */
+
+        Y2_IS_IRQ_PHY1  = 1<<4,         /* Interrupt from PHY 1 */
+        Y2_IS_IRQ_MAC1  = 1<<3,         /* Interrupt from MAC 1 */
+        Y2_IS_CHK_RX1   = 1<<2,         /* Descriptor error Rx 1 */
+        Y2_IS_CHK_TXS1  = 1<<1,         /* Descriptor error TXS 1 */
+        Y2_IS_CHK_TXA1  = 1<<0,         /* Descriptor error TXA 1 */
+
+        Y2_IS_BASE      = Y2_IS_HW_ERR | Y2_IS_STAT_BMU |
+                          Y2_IS_POLL_CHK | Y2_IS_TWSI_RDY |
+                          Y2_IS_IRQ_SW | Y2_IS_TIMINT,
+        Y2_IS_PORT_1    = Y2_IS_IRQ_PHY1 | Y2_IS_IRQ_MAC1 |
+                          Y2_IS_CHK_RX1 | Y2_IS_CHK_TXA1 | Y2_IS_CHK_TXS1,
+        Y2_IS_PORT_2    = Y2_IS_IRQ_PHY2 | Y2_IS_IRQ_MAC2 |
+                          Y2_IS_CHK_RX2 | Y2_IS_CHK_TXA2 | Y2_IS_CHK_TXS2,
+};
+
+/*      B2_IRQM_HWE_MSK 32 bit  IRQ Moderation HW Error Mask */
+enum {
+        IS_ERR_MSK      = 0x00003fff,/*                 All Error bits */
+
+        IS_IRQ_TIST_OV  = 1<<13, /* Time Stamp Timer Overflow (YUKON only) */
+        IS_IRQ_SENSOR   = 1<<12, /* IRQ from Sensor (YUKON only) */
+        IS_IRQ_MST_ERR  = 1<<11, /* IRQ master error detected */
+        IS_IRQ_STAT     = 1<<10, /* IRQ status exception */
+        IS_NO_STAT_M1   = 1<<9, /* No Rx Status from MAC 1 */
+        IS_NO_STAT_M2   = 1<<8, /* No Rx Status from MAC 2 */
+        IS_NO_TIST_M1   = 1<<7, /* No Time Stamp from MAC 1 */
+        IS_NO_TIST_M2   = 1<<6, /* No Time Stamp from MAC 2 */
+        IS_RAM_RD_PAR   = 1<<5, /* RAM Read  Parity Error */
+        IS_RAM_WR_PAR   = 1<<4, /* RAM Write Parity Error */
+        IS_M1_PAR_ERR   = 1<<3, /* MAC 1 Parity Error */
+        IS_M2_PAR_ERR   = 1<<2, /* MAC 2 Parity Error */
+        IS_R1_PAR_ERR   = 1<<1, /* Queue R1 Parity Error */
+        IS_R2_PAR_ERR   = 1<<0, /* Queue R2 Parity Error */
+};
+
+/* Hardware error interrupt mask for Yukon 2 */
+enum {
+        Y2_IS_TIST_OV   = 1<<29,/* Time Stamp Timer overflow interrupt */
+        Y2_IS_SENSOR    = 1<<28, /* Sensor interrupt */
+        Y2_IS_MST_ERR   = 1<<27, /* Master error interrupt */
+        Y2_IS_IRQ_STAT  = 1<<26, /* Status exception interrupt */
+        Y2_IS_PCI_EXP   = 1<<25, /* PCI-Express interrupt */
+        Y2_IS_PCI_NEXP  = 1<<24, /* PCI-Express error similar to PCI error */
+                                                /* Link 2 */
+        Y2_IS_PAR_RD2   = 1<<13, /* Read RAM parity error interrupt */
+        Y2_IS_PAR_WR2   = 1<<12, /* Write RAM parity error interrupt */
+        Y2_IS_PAR_MAC2  = 1<<11, /* MAC hardware fault interrupt */
+        Y2_IS_PAR_RX2   = 1<<10, /* Parity Error Rx Queue 2 */
+        Y2_IS_TCP_TXS2  = 1<<9, /* TCP length mismatch sync Tx queue IRQ */
+        Y2_IS_TCP_TXA2  = 1<<8, /* TCP length mismatch async Tx queue IRQ */
+                                                /* Link 1 */
+        Y2_IS_PAR_RD1   = 1<<5, /* Read RAM parity error interrupt */
+        Y2_IS_PAR_WR1   = 1<<4, /* Write RAM parity error interrupt */
+        Y2_IS_PAR_MAC1  = 1<<3, /* MAC hardware fault interrupt */
+        Y2_IS_PAR_RX1   = 1<<2, /* Parity Error Rx Queue 1 */
+        Y2_IS_TCP_TXS1  = 1<<1, /* TCP length mismatch sync Tx queue IRQ */
+        Y2_IS_TCP_TXA1  = 1<<0, /* TCP length mismatch async Tx queue IRQ */
+
+        Y2_HWE_L1_MASK  = Y2_IS_PAR_RD1 | Y2_IS_PAR_WR1 | Y2_IS_PAR_MAC1 |
+                          Y2_IS_PAR_RX1 | Y2_IS_TCP_TXS1| Y2_IS_TCP_TXA1,
+        Y2_HWE_L2_MASK  = Y2_IS_PAR_RD2 | Y2_IS_PAR_WR2 | Y2_IS_PAR_MAC2 |
+                          Y2_IS_PAR_RX2 | Y2_IS_TCP_TXS2| Y2_IS_TCP_TXA2,
+
+        Y2_HWE_ALL_MASK = Y2_IS_TIST_OV | Y2_IS_MST_ERR | Y2_IS_IRQ_STAT |
+                          Y2_IS_PCI_EXP | Y2_IS_PCI_NEXP |
+                          Y2_HWE_L1_MASK | Y2_HWE_L2_MASK,
+};
+
+/*      B28_DPT_CTRL     8 bit  Descriptor Poll Timer Ctrl Reg */
+enum {
+        DPT_START       = 1<<1,
+        DPT_STOP        = 1<<0,
+};
+
+/*      B2_TST_CTRL1     8 bit  Test Control Register 1 */
+enum {
+        TST_FRC_DPERR_MR = 1<<7, /* force DATAPERR on MST RD */
+        TST_FRC_DPERR_MW = 1<<6, /* force DATAPERR on MST WR */
+        TST_FRC_DPERR_TR = 1<<5, /* force DATAPERR on TRG RD */
+        TST_FRC_DPERR_TW = 1<<4, /* force DATAPERR on TRG WR */
+        TST_FRC_APERR_M  = 1<<3, /* force ADDRPERR on MST */
+        TST_FRC_APERR_T  = 1<<2, /* force ADDRPERR on TRG */
+        TST_CFG_WRITE_ON = 1<<1, /* Enable  Config Reg WR */
+        TST_CFG_WRITE_OFF= 1<<0, /* Disable Config Reg WR */
+};
+
+/*      B2_MAC_CFG               8 bit  MAC Configuration / Chip Revision */
+enum {
+        CFG_CHIP_R_MSK    = 0xf<<4,     /* Bit 7.. 4: Chip Revision */
+                                        /* Bit 3.. 2:   reserved */
+        CFG_DIS_M2_CLK    = 1<<1,       /* Disable Clock for 2nd MAC */
+        CFG_SNG_MAC       = 1<<0,       /* MAC Config: 0=2 MACs / 1=1 MAC*/
+};
+
+/*      B2_CHIP_ID               8 bit  Chip Identification Number */
+enum {
+        CHIP_ID_GENESIS    = 0x0a, /* Chip ID for GENESIS */
+        CHIP_ID_YUKON      = 0xb0, /* Chip ID for YUKON */
+        CHIP_ID_YUKON_LITE = 0xb1, /* Chip ID for YUKON-Lite (Rev. A1-A3) */
+        CHIP_ID_YUKON_LP   = 0xb2, /* Chip ID for YUKON-LP */
+        CHIP_ID_YUKON_XL   = 0xb3, /* Chip ID for YUKON-2 XL */
+        CHIP_ID_YUKON_EC   = 0xb6, /* Chip ID for YUKON-2 EC */
+        CHIP_ID_YUKON_FE   = 0xb7, /* Chip ID for YUKON-2 FE */
+
+        CHIP_REV_YU_EC_A1    = 0,  /* Chip Rev. for Yukon-EC A1/A0 */
+        CHIP_REV_YU_EC_A2    = 1,  /* Chip Rev. for Yukon-EC A2 */
+        CHIP_REV_YU_EC_A3    = 2,  /* Chip Rev. for Yukon-EC A3 */
+};
+
+/*      B2_Y2_CLK_GATE   8 bit  Clock Gating (Yukon-2 only) */
+enum {
+        Y2_STATUS_LNK2_INAC     = 1<<7, /* Status Link 2 inactive (0 = active) */
+        Y2_CLK_GAT_LNK2_DIS     = 1<<6, /* Disable clock gating Link 2 */
+        Y2_COR_CLK_LNK2_DIS     = 1<<5, /* Disable Core clock Link 2 */
+        Y2_PCI_CLK_LNK2_DIS     = 1<<4, /* Disable PCI clock Link 2 */
+        Y2_STATUS_LNK1_INAC     = 1<<3, /* Status Link 1 inactive (0 = active) */
+        Y2_CLK_GAT_LNK1_DIS     = 1<<2, /* Disable clock gating Link 1 */
+        Y2_COR_CLK_LNK1_DIS     = 1<<1, /* Disable Core clock Link 1 */
+        Y2_PCI_CLK_LNK1_DIS     = 1<<0, /* Disable PCI clock Link 1 */
+};
+
+/*      B2_Y2_HW_RES    8 bit   HW Resources (Yukon-2 only) */
+enum {
+        CFG_LED_MODE_MSK        = 7<<2, /* Bit  4.. 2:  LED Mode Mask */
+        CFG_LINK_2_AVAIL        = 1<<1, /* Link 2 available */
+        CFG_LINK_1_AVAIL        = 1<<0, /* Link 1 available */
+};
+#define CFG_LED_MODE(x)         (((x) & CFG_LED_MODE_MSK) >> 2)
+#define CFG_DUAL_MAC_MSK        (CFG_LINK_2_AVAIL | CFG_LINK_1_AVAIL)
+
+
+/* B2_Y2_CLK_CTRL       32 bit  Clock Frequency Control Register (Yukon-2/EC) */
+enum {
+        Y2_CLK_DIV_VAL_MSK      = 0xff<<16,/* Bit 23..16: Clock Divisor Value */
+#define Y2_CLK_DIV_VAL(x)       (((x)<<16) & Y2_CLK_DIV_VAL_MSK)
+        Y2_CLK_DIV_VAL2_MSK     = 7<<21,   /* Bit 23..21: Clock Divisor Value */
+        Y2_CLK_SELECT2_MSK      = 0x1f<<16,/* Bit 20..16: Clock Select */
+#define Y2_CLK_DIV_VAL_2(x)     (((x)<<21) & Y2_CLK_DIV_VAL2_MSK)
+#define Y2_CLK_SEL_VAL_2(x)     (((x)<<16) & Y2_CLK_SELECT2_MSK)
+        Y2_CLK_DIV_ENA          = 1<<1, /* Enable  Core Clock Division */
+        Y2_CLK_DIV_DIS          = 1<<0, /* Disable Core Clock Division */
+};
+
+/*      B2_TI_CTRL               8 bit  Timer control */
+/*      B2_IRQM_CTRL     8 bit  IRQ Moderation Timer Control */
+enum {
+        TIM_START       = 1<<2, /* Start Timer */
+        TIM_STOP        = 1<<1, /* Stop  Timer */
+        TIM_CLR_IRQ     = 1<<0, /* Clear Timer IRQ (!IRQM) */
+};
+
+/*      B2_TI_TEST               8 Bit  Timer Test */
+/*      B2_IRQM_TEST     8 bit  IRQ Moderation Timer Test */
+/*      B28_DPT_TST              8 bit  Descriptor Poll Timer Test Reg */
+enum {
+        TIM_T_ON        = 1<<2, /* Test mode on */
+        TIM_T_OFF       = 1<<1, /* Test mode off */
+        TIM_T_STEP      = 1<<0, /* Test step */
+};
+
+/*      B3_RAM_ADDR             32 bit  RAM Address, to read or write */
+                                        /* Bit 31..19:  reserved */
+#define RAM_ADR_RAN     0x0007ffffL     /* Bit 18.. 0:  RAM Address Range */
+/* RAM Interface Registers */
+
+/*      B3_RI_CTRL              16 bit  RAM Interface Control Register */
+enum {
+        RI_CLR_RD_PERR  = 1<<9, /* Clear IRQ RAM Read Parity Err */
+        RI_CLR_WR_PERR  = 1<<8, /* Clear IRQ RAM Write Parity Err*/
+
+        RI_RST_CLR      = 1<<1, /* Clear RAM Interface Reset */
+        RI_RST_SET      = 1<<0, /* Set   RAM Interface Reset */
+};
+
+#define SK_RI_TO_53     36              /* RAM interface timeout */
+
+
+/* Port related registers FIFO, and Arbiter */
+#define SK_REG(port,reg)        (((port)<<7)+(reg))
+
+/* Transmit Arbiter Registers MAC 1 and 2, use SK_REG() to access */
+/*      TXA_ITI_INI             32 bit  Tx Arb Interval Timer Init Val */
+/*      TXA_ITI_VAL             32 bit  Tx Arb Interval Timer Value */
+/*      TXA_LIM_INI             32 bit  Tx Arb Limit Counter Init Val */
+/*      TXA_LIM_VAL             32 bit  Tx Arb Limit Counter Value */
+
+#define TXA_MAX_VAL     0x00ffffffUL    /* Bit 23.. 0:  Max TXA Timer/Cnt Val */
+
+/*      TXA_CTRL                 8 bit  Tx Arbiter Control Register */
+enum {
+        TXA_ENA_FSYNC   = 1<<7, /* Enable  force of sync Tx queue */
+        TXA_DIS_FSYNC   = 1<<6, /* Disable force of sync Tx queue */
+        TXA_ENA_ALLOC   = 1<<5, /* Enable  alloc of free bandwidth */
+        TXA_DIS_ALLOC   = 1<<4, /* Disable alloc of free bandwidth */
+        TXA_START_RC    = 1<<3, /* Start sync Rate Control */
+        TXA_STOP_RC     = 1<<2, /* Stop  sync Rate Control */
+        TXA_ENA_ARB     = 1<<1, /* Enable  Tx Arbiter */
+        TXA_DIS_ARB     = 1<<0, /* Disable Tx Arbiter */
+};
+
+/*
+ *      Bank 4 - 5
+ */
+/* Transmit Arbiter Registers MAC 1 and 2, use SK_REG() to access */
+enum {
+        TXA_ITI_INI     = 0x0200,/* 32 bit      Tx Arb Interval Timer Init Val*/
+        TXA_ITI_VAL     = 0x0204,/* 32 bit      Tx Arb Interval Timer Value */
+        TXA_LIM_INI     = 0x0208,/* 32 bit      Tx Arb Limit Counter Init Val */
+        TXA_LIM_VAL     = 0x020c,/* 32 bit      Tx Arb Limit Counter Value */
+        TXA_CTRL        = 0x0210,/*  8 bit      Tx Arbiter Control Register */
+        TXA_TEST        = 0x0211,/*  8 bit      Tx Arbiter Test Register */
+        TXA_STAT        = 0x0212,/*  8 bit      Tx Arbiter Status Register */
+};
+
+
+enum {
+        B6_EXT_REG      = 0x0300,/* External registers (GENESIS only) */
+        B7_CFG_SPC      = 0x0380,/* copy of the Configuration register */
+        B8_RQ1_REGS     = 0x0400,/* Receive Queue 1 */
+        B8_RQ2_REGS     = 0x0480,/* Receive Queue 2 */
+        B8_TS1_REGS     = 0x0600,/* Transmit sync queue 1 */
+        B8_TA1_REGS     = 0x0680,/* Transmit async queue 1 */
+        B8_TS2_REGS     = 0x0700,/* Transmit sync queue 2 */
+        B8_TA2_REGS     = 0x0780,/* Transmit sync queue 2 */
+        B16_RAM_REGS    = 0x0800,/* RAM Buffer Registers */
+};
+
+/* Queue Register Offsets, use Q_ADDR() to access */
+enum {
+        B8_Q_REGS = 0x0400, /* base of Queue registers */
+        Q_D     = 0x00, /* 8*32 bit     Current Descriptor */
+        Q_DA_L  = 0x20, /* 32 bit       Current Descriptor Address Low dWord */
+        Q_DA_H  = 0x24, /* 32 bit       Current Descriptor Address High dWord */
+        Q_AC_L  = 0x28, /* 32 bit       Current Address Counter Low dWord */
+        Q_AC_H  = 0x2c, /* 32 bit       Current Address Counter High dWord */
+        Q_BC    = 0x30, /* 32 bit       Current Byte Counter */
+        Q_CSR   = 0x34, /* 32 bit       BMU Control/Status Register */
+        Q_F     = 0x38, /* 32 bit       Flag Register */
+        Q_T1    = 0x3c, /* 32 bit       Test Register 1 */
+        Q_T1_TR = 0x3c, /*  8 bit       Test Register 1 Transfer SM */
+        Q_T1_WR = 0x3d, /*  8 bit       Test Register 1 Write Descriptor SM */
+        Q_T1_RD = 0x3e, /*  8 bit       Test Register 1 Read Descriptor SM */
+        Q_T1_SV = 0x3f, /*  8 bit       Test Register 1 Supervisor SM */
+        Q_T2    = 0x40, /* 32 bit       Test Register 2 */
+        Q_T3    = 0x44, /* 32 bit       Test Register 3 */
+
+/* Yukon-2 */
+        Q_DONE  = 0x24, /* 16 bit       Done Index              (Yukon-2 only) */
+        Q_WM    = 0x40, /* 16 bit       FIFO Watermark */
+        Q_AL    = 0x42, /*  8 bit       FIFO Alignment */
+        Q_RSP   = 0x44, /* 16 bit       FIFO Read Shadow Pointer */
+        Q_RSL   = 0x46, /*  8 bit       FIFO Read Shadow Level */
+        Q_RP    = 0x48, /*  8 bit       FIFO Read Pointer */
+        Q_RL    = 0x4a, /*  8 bit       FIFO Read Level */
+        Q_WP    = 0x4c, /*  8 bit       FIFO Write Pointer */
+        Q_WSP   = 0x4d, /*  8 bit       FIFO Write Shadow Pointer */
+        Q_WL    = 0x4e, /*  8 bit       FIFO Write Level */
+        Q_WSL   = 0x4f, /*  8 bit       FIFO Write Shadow Level */
+};
+#define Q_ADDR(reg, offs) (B8_Q_REGS + (reg) + (offs))
+
+
+/* Queue Prefetch Unit Offsets, use Y2_QADDR() to address (Yukon-2 only)*/
+enum {
+        Y2_B8_PREF_REGS         = 0x0450,
+
+        PREF_UNIT_CTRL          = 0x00, /* 32 bit       Control register */
+        PREF_UNIT_LAST_IDX      = 0x04, /* 16 bit       Last Index */
+        PREF_UNIT_ADDR_LO       = 0x08, /* 32 bit       List start addr, low part */
+        PREF_UNIT_ADDR_HI       = 0x0c, /* 32 bit       List start addr, high part*/
+        PREF_UNIT_GET_IDX       = 0x10, /* 16 bit       Get Index */
+        PREF_UNIT_PUT_IDX       = 0x14, /* 16 bit       Put Index */
+        PREF_UNIT_FIFO_WP       = 0x20, /*  8 bit       FIFO write pointer */
+        PREF_UNIT_FIFO_RP       = 0x24, /*  8 bit       FIFO read pointer */
+        PREF_UNIT_FIFO_WM       = 0x28, /*  8 bit       FIFO watermark */
+        PREF_UNIT_FIFO_LEV      = 0x2c, /*  8 bit       FIFO level */
+
+        PREF_UNIT_MASK_IDX      = 0x0fff,
+};
+#define Y2_QADDR(q,reg)         (Y2_B8_PREF_REGS + (q) + (reg))
+
+/* RAM Buffer Register Offsets */
+enum {
+
+        RB_START        = 0x00,/* 32 bit        RAM Buffer Start Address */
+        RB_END  = 0x04,/* 32 bit        RAM Buffer End Address */
+        RB_WP   = 0x08,/* 32 bit        RAM Buffer Write Pointer */
+        RB_RP   = 0x0c,/* 32 bit        RAM Buffer Read Pointer */
+        RB_RX_UTPP      = 0x10,/* 32 bit        Rx Upper Threshold, Pause Packet */
+        RB_RX_LTPP      = 0x14,/* 32 bit        Rx Lower Threshold, Pause Packet */
+        RB_RX_UTHP      = 0x18,/* 32 bit        Rx Upper Threshold, High Prio */
+        RB_RX_LTHP      = 0x1c,/* 32 bit        Rx Lower Threshold, High Prio */
+        /* 0x10 - 0x1f: reserved at Tx RAM Buffer Registers */
+        RB_PC   = 0x20,/* 32 bit        RAM Buffer Packet Counter */
+        RB_LEV  = 0x24,/* 32 bit        RAM Buffer Level Register */
+        RB_CTRL = 0x28,/* 32 bit        RAM Buffer Control Register */
+        RB_TST1 = 0x29,/*  8 bit        RAM Buffer Test Register 1 */
+        RB_TST2 = 0x2a,/*  8 bit        RAM Buffer Test Register 2 */
+};
+
+/* Receive and Transmit Queues */
+enum {
+        Q_R1    = 0x0000,       /* Receive Queue 1 */
+        Q_R2    = 0x0080,       /* Receive Queue 2 */
+        Q_XS1   = 0x0200,       /* Synchronous Transmit Queue 1 */
+        Q_XA1   = 0x0280,       /* Asynchronous Transmit Queue 1 */
+        Q_XS2   = 0x0300,       /* Synchronous Transmit Queue 2 */
+        Q_XA2   = 0x0380,       /* Asynchronous Transmit Queue 2 */
+};
+
+/* Different PHY Types */
+enum {
+        PHY_ADDR_MARV   = 0,
+};
+
+#define RB_ADDR(offs, queue) (B16_RAM_REGS + (queue) + (offs))
+
+
+enum {
+        LNK_SYNC_INI    = 0x0c30,/* 32 bit      Link Sync Cnt Init Value */
+        LNK_SYNC_VAL    = 0x0c34,/* 32 bit      Link Sync Cnt Current Value */
+        LNK_SYNC_CTRL   = 0x0c38,/*  8 bit      Link Sync Cnt Control Register */
+        LNK_SYNC_TST    = 0x0c39,/*  8 bit      Link Sync Cnt Test Register */
+
+        LNK_LED_REG     = 0x0c3c,/*  8 bit      Link LED Register */
+
+/* Receive GMAC FIFO (YUKON and Yukon-2) */
+
+        RX_GMF_EA       = 0x0c40,/* 32 bit      Rx GMAC FIFO End Address */
+        RX_GMF_AF_THR   = 0x0c44,/* 32 bit      Rx GMAC FIFO Almost Full Thresh. */
+        RX_GMF_CTRL_T   = 0x0c48,/* 32 bit      Rx GMAC FIFO Control/Test */
+        RX_GMF_FL_MSK   = 0x0c4c,/* 32 bit      Rx GMAC FIFO Flush Mask */
+        RX_GMF_FL_THR   = 0x0c50,/* 32 bit      Rx GMAC FIFO Flush Threshold */
+        RX_GMF_TR_THR   = 0x0c54,/* 32 bit      Rx Truncation Threshold (Yukon-2) */
+
+        RX_GMF_VLAN     = 0x0c5c,/* 32 bit      Rx VLAN Type Register (Yukon-2) */
+        RX_GMF_WP       = 0x0c60,/* 32 bit      Rx GMAC FIFO Write Pointer */
+
+        RX_GMF_WLEV     = 0x0c68,/* 32 bit      Rx GMAC FIFO Write Level */
+
+        RX_GMF_RP       = 0x0c70,/* 32 bit      Rx GMAC FIFO Read Pointer */
+
+        RX_GMF_RLEV     = 0x0c78,/* 32 bit      Rx GMAC FIFO Read Level */
+};
+
+
+/*      Q_BC                    32 bit  Current Byte Counter */
+
+/* BMU Control Status Registers */
+/*      B0_R1_CSR               32 bit  BMU Ctrl/Stat Rx Queue 1 */
+/*      B0_R2_CSR               32 bit  BMU Ctrl/Stat Rx Queue 2 */
+/*      B0_XA1_CSR              32 bit  BMU Ctrl/Stat Sync Tx Queue 1 */
+/*      B0_XS1_CSR              32 bit  BMU Ctrl/Stat Async Tx Queue 1 */
+/*      B0_XA2_CSR              32 bit  BMU Ctrl/Stat Sync Tx Queue 2 */
+/*      B0_XS2_CSR              32 bit  BMU Ctrl/Stat Async Tx Queue 2 */
+/*      Q_CSR                   32 bit  BMU Control/Status Register */
+
+/* Rx BMU Control / Status Registers (Yukon-2) */
+enum {
+        BMU_IDLE        = 1<<31, /* BMU Idle State */
+        BMU_RX_TCP_PKT  = 1<<30, /* Rx TCP Packet (when RSS Hash enabled) */
+        BMU_RX_IP_PKT   = 1<<29, /* Rx IP  Packet (when RSS Hash enabled) */
+
+        BMU_ENA_RX_RSS_HASH = 1<<15, /* Enable  Rx RSS Hash */
+        BMU_DIS_RX_RSS_HASH = 1<<14, /* Disable Rx RSS Hash */
+        BMU_ENA_RX_CHKSUM = 1<<13, /* Enable  Rx TCP/IP Checksum Check */
+        BMU_DIS_RX_CHKSUM = 1<<12, /* Disable Rx TCP/IP Checksum Check */
+        BMU_CLR_IRQ_PAR = 1<<11, /* Clear IRQ on Parity errors (Rx) */
+        BMU_CLR_IRQ_TCP = 1<<11, /* Clear IRQ on TCP segment. error (Tx) */
+        BMU_CLR_IRQ_CHK = 1<<10, /* Clear IRQ Check */
+        BMU_STOP        = 1<<9, /* Stop  Rx/Tx Queue */
+        BMU_START       = 1<<8, /* Start Rx/Tx Queue */
+        BMU_FIFO_OP_ON  = 1<<7, /* FIFO Operational On */
+        BMU_FIFO_OP_OFF = 1<<6, /* FIFO Operational Off */
+        BMU_FIFO_ENA    = 1<<5, /* Enable FIFO */
+        BMU_FIFO_RST    = 1<<4, /* Reset  FIFO */
+        BMU_OP_ON       = 1<<3, /* BMU Operational On */
+        BMU_OP_OFF      = 1<<2, /* BMU Operational Off */
+        BMU_RST_CLR     = 1<<1, /* Clear BMU Reset (Enable) */
+        BMU_RST_SET     = 1<<0, /* Set   BMU Reset */
+
+        BMU_CLR_RESET   = BMU_FIFO_RST | BMU_OP_OFF | BMU_RST_CLR,
+        BMU_OPER_INIT   = BMU_CLR_IRQ_PAR | BMU_CLR_IRQ_CHK | BMU_START |
+                          BMU_FIFO_ENA | BMU_OP_ON,
+};
+
+/* Tx BMU Control / Status Registers (Yukon-2) */
+                                                                /* Bit 31: same as for Rx */
+enum {
+        BMU_TX_IPIDINCR_ON      = 1<<13, /* Enable  IP ID Increment */
+        BMU_TX_IPIDINCR_OFF     = 1<<12, /* Disable IP ID Increment */
+        BMU_TX_CLR_IRQ_TCP      = 1<<11, /* Clear IRQ on TCP segment length mismatch */
+};
+
+/* Queue Prefetch Unit Offsets, use Y2_QADDR() to address (Yukon-2 only)*/
+/* PREF_UNIT_CTRL       32 bit  Prefetch Control register */
+enum {
+        PREF_UNIT_OP_ON         = 1<<3, /* prefetch unit operational */
+        PREF_UNIT_OP_OFF        = 1<<2, /* prefetch unit not operational */
+        PREF_UNIT_RST_CLR       = 1<<1, /* Clear Prefetch Unit Reset */
+        PREF_UNIT_RST_SET       = 1<<0, /* Set   Prefetch Unit Reset */
+};
+
+/* RAM Buffer Register Offsets, use RB_ADDR(Queue, Offs) to access */
+/*      RB_START                32 bit  RAM Buffer Start Address */
+/*      RB_END                  32 bit  RAM Buffer End Address */
+/*      RB_WP                   32 bit  RAM Buffer Write Pointer */
+/*      RB_RP                   32 bit  RAM Buffer Read Pointer */
+/*      RB_RX_UTPP              32 bit  Rx Upper Threshold, Pause Pack */
+/*      RB_RX_LTPP              32 bit  Rx Lower Threshold, Pause Pack */
+/*      RB_RX_UTHP              32 bit  Rx Upper Threshold, High Prio */
+/*      RB_RX_LTHP              32 bit  Rx Lower Threshold, High Prio */
+/*      RB_PC                   32 bit  RAM Buffer Packet Counter */
+/*      RB_LEV                  32 bit  RAM Buffer Level Register */
+
+#define RB_MSK  0x0007ffff      /* Bit 18.. 0:  RAM Buffer Pointer Bits */
+/*      RB_TST2                  8 bit  RAM Buffer Test Register 2 */
+/*      RB_TST1                  8 bit  RAM Buffer Test Register 1 */
+
+/*      RB_CTRL                  8 bit  RAM Buffer Control Register */
+enum {
+        RB_ENA_STFWD    = 1<<5, /* Enable  Store & Forward */
+        RB_DIS_STFWD    = 1<<4, /* Disable Store & Forward */
+        RB_ENA_OP_MD    = 1<<3, /* Enable  Operation Mode */
+        RB_DIS_OP_MD    = 1<<2, /* Disable Operation Mode */
+        RB_RST_CLR      = 1<<1, /* Clear RAM Buf STM Reset */
+        RB_RST_SET      = 1<<0, /* Set   RAM Buf STM Reset */
+};
+
+
+/* Transmit GMAC FIFO (YUKON only) */
+enum {
+        TX_GMF_EA       = 0x0d40,/* 32 bit      Tx GMAC FIFO End Address */
+        TX_GMF_AE_THR   = 0x0d44,/* 32 bit      Tx GMAC FIFO Almost Empty Thresh.*/
+        TX_GMF_CTRL_T   = 0x0d48,/* 32 bit      Tx GMAC FIFO Control/Test */
+
+        TX_GMF_WP       = 0x0d60,/* 32 bit      Tx GMAC FIFO Write Pointer */
+        TX_GMF_WSP      = 0x0d64,/* 32 bit      Tx GMAC FIFO Write Shadow Ptr. */
+        TX_GMF_WLEV     = 0x0d68,/* 32 bit      Tx GMAC FIFO Write Level */
+
+        TX_GMF_RP       = 0x0d70,/* 32 bit      Tx GMAC FIFO Read Pointer */
+        TX_GMF_RSTP     = 0x0d74,/* 32 bit      Tx GMAC FIFO Restart Pointer */
+        TX_GMF_RLEV     = 0x0d78,/* 32 bit      Tx GMAC FIFO Read Level */
+};
+
+/* Descriptor Poll Timer Registers */
+enum {
+        B28_DPT_INI     = 0x0e00,/* 24 bit      Descriptor Poll Timer Init Val */
+        B28_DPT_VAL     = 0x0e04,/* 24 bit      Descriptor Poll Timer Curr Val */
+        B28_DPT_CTRL    = 0x0e08,/*  8 bit      Descriptor Poll Timer Ctrl Reg */
+
+        B28_DPT_TST     = 0x0e0a,/*  8 bit      Descriptor Poll Timer Test Reg */
+};
+
+/* Time Stamp Timer Registers (YUKON only) */
+enum {
+        GMAC_TI_ST_VAL  = 0x0e14,/* 32 bit      Time Stamp Timer Curr Val */
+        GMAC_TI_ST_CTRL = 0x0e18,/*  8 bit      Time Stamp Timer Ctrl Reg */
+        GMAC_TI_ST_TST  = 0x0e1a,/*  8 bit      Time Stamp Timer Test Reg */
+};
+
+/* Polling Unit Registers (Yukon-2 only) */
+enum {
+        POLL_CTRL       = 0x0e20, /* 32 bit     Polling Unit Control Reg */
+        POLL_LAST_IDX   = 0x0e24,/* 16 bit      Polling Unit List Last Index */
+
+        POLL_LIST_ADDR_LO= 0x0e28,/* 32 bit     Poll. List Start Addr (low) */
+        POLL_LIST_ADDR_HI= 0x0e2c,/* 32 bit     Poll. List Start Addr (high) */
+};
+
+/* ASF Subsystem Registers (Yukon-2 only) */
+enum {
+        B28_Y2_SMB_CONFIG  = 0x0e40,/* 32 bit   ASF SMBus Config Register */
+        B28_Y2_SMB_CSD_REG = 0x0e44,/* 32 bit   ASF SMB Control/Status/Data */
+        B28_Y2_ASF_IRQ_V_BASE=0x0e60,/* 32 bit  ASF IRQ Vector Base */
+
+        B28_Y2_ASF_STAT_CMD= 0x0e68,/* 32 bit   ASF Status and Command Reg */
+        B28_Y2_ASF_HOST_COM= 0x0e6c,/* 32 bit   ASF Host Communication Reg */
+        B28_Y2_DATA_REG_1  = 0x0e70,/* 32 bit   ASF/Host Data Register 1 */
+        B28_Y2_DATA_REG_2  = 0x0e74,/* 32 bit   ASF/Host Data Register 2 */
+        B28_Y2_DATA_REG_3  = 0x0e78,/* 32 bit   ASF/Host Data Register 3 */
+        B28_Y2_DATA_REG_4  = 0x0e7c,/* 32 bit   ASF/Host Data Register 4 */
+};
+
+/* Status BMU Registers (Yukon-2 only)*/
+enum {
+        STAT_CTRL       = 0x0e80,/* 32 bit      Status BMU Control Reg */
+        STAT_LAST_IDX   = 0x0e84,/* 16 bit      Status BMU Last Index */
+
+        STAT_LIST_ADDR_LO= 0x0e88,/* 32 bit     Status List Start Addr (low) */
+        STAT_LIST_ADDR_HI= 0x0e8c,/* 32 bit     Status List Start Addr (high) */
+        STAT_TXA1_RIDX  = 0x0e90,/* 16 bit      Status TxA1 Report Index Reg */
+        STAT_TXS1_RIDX  = 0x0e92,/* 16 bit      Status TxS1 Report Index Reg */
+        STAT_TXA2_RIDX  = 0x0e94,/* 16 bit      Status TxA2 Report Index Reg */
+        STAT_TXS2_RIDX  = 0x0e96,/* 16 bit      Status TxS2 Report Index Reg */
+        STAT_TX_IDX_TH  = 0x0e98,/* 16 bit      Status Tx Index Threshold Reg */
+        STAT_PUT_IDX    = 0x0e9c,/* 16 bit      Status Put Index Reg */
+
+/* FIFO Control/Status Registers (Yukon-2 only)*/
+        STAT_FIFO_WP    = 0x0ea0,/*  8 bit      Status FIFO Write Pointer Reg */
+        STAT_FIFO_RP    = 0x0ea4,/*  8 bit      Status FIFO Read Pointer Reg */
+        STAT_FIFO_RSP   = 0x0ea6,/*  8 bit      Status FIFO Read Shadow Ptr */
+        STAT_FIFO_LEVEL = 0x0ea8,/*  8 bit      Status FIFO Level Reg */
+        STAT_FIFO_SHLVL = 0x0eaa,/*  8 bit      Status FIFO Shadow Level Reg */
+        STAT_FIFO_WM    = 0x0eac,/*  8 bit      Status FIFO Watermark Reg */
+        STAT_FIFO_ISR_WM= 0x0ead,/*  8 bit      Status FIFO ISR Watermark Reg */
+
+/* Level and ISR Timer Registers (Yukon-2 only)*/
+        STAT_LEV_TIMER_INI= 0x0eb0,/* 32 bit    Level Timer Init. Value Reg */
+        STAT_LEV_TIMER_CNT= 0x0eb4,/* 32 bit    Level Timer Counter Reg */
+        STAT_LEV_TIMER_CTRL= 0x0eb8,/*  8 bit   Level Timer Control Reg */
+        STAT_LEV_TIMER_TEST= 0x0eb9,/*  8 bit   Level Timer Test Reg */
+        STAT_TX_TIMER_INI  = 0x0ec0,/* 32 bit   Tx Timer Init. Value Reg */
+        STAT_TX_TIMER_CNT  = 0x0ec4,/* 32 bit   Tx Timer Counter Reg */
+        STAT_TX_TIMER_CTRL = 0x0ec8,/*  8 bit   Tx Timer Control Reg */
+        STAT_TX_TIMER_TEST = 0x0ec9,/*  8 bit   Tx Timer Test Reg */
+        STAT_ISR_TIMER_INI = 0x0ed0,/* 32 bit   ISR Timer Init. Value Reg */
+        STAT_ISR_TIMER_CNT = 0x0ed4,/* 32 bit   ISR Timer Counter Reg */
+        STAT_ISR_TIMER_CTRL= 0x0ed8,/*  8 bit   ISR Timer Control Reg */
+        STAT_ISR_TIMER_TEST= 0x0ed9,/*  8 bit   ISR Timer Test Reg */
+};
+
+enum {
+        LINKLED_OFF          = 0x01,
+        LINKLED_ON           = 0x02,
+        LINKLED_LINKSYNC_OFF = 0x04,
+        LINKLED_LINKSYNC_ON  = 0x08,
+        LINKLED_BLINK_OFF    = 0x10,
+        LINKLED_BLINK_ON     = 0x20,
+};
+
+/* GMAC and GPHY Control Registers (YUKON only) */
+enum {
+        GMAC_CTRL       = 0x0f00,/* 32 bit      GMAC Control Reg */
+        GPHY_CTRL       = 0x0f04,/* 32 bit      GPHY Control Reg */
+        GMAC_IRQ_SRC    = 0x0f08,/*  8 bit      GMAC Interrupt Source Reg */
+        GMAC_IRQ_MSK    = 0x0f0c,/*  8 bit      GMAC Interrupt Mask Reg */
+        GMAC_LINK_CTRL  = 0x0f10,/* 16 bit      Link Control Reg */
+
+/* Wake-up Frame Pattern Match Control Registers (YUKON only) */
+
+        WOL_REG_OFFS    = 0x20,/* HW-Bug: Address is + 0x20 against spec. */
+
+        WOL_CTRL_STAT   = 0x0f20,/* 16 bit      WOL Control/Status Reg */
+        WOL_MATCH_CTL   = 0x0f22,/*  8 bit      WOL Match Control Reg */
+        WOL_MATCH_RES   = 0x0f23,/*  8 bit      WOL Match Result Reg */
+        WOL_MAC_ADDR    = 0x0f24,/* 32 bit      WOL MAC Address */
+        WOL_PATT_PME    = 0x0f2a,/*  8 bit      WOL PME Match Enable (Yukon-2) */
+        WOL_PATT_ASFM   = 0x0f2b,/*  8 bit      WOL ASF Match Enable (Yukon-2) */
+        WOL_PATT_RPTR   = 0x0f2c,/*  8 bit      WOL Pattern Read Pointer */
+
+/* WOL Pattern Length Registers (YUKON only) */
+
+        WOL_PATT_LEN_LO = 0x0f30,/* 32 bit      WOL Pattern Length 3..0 */
+        WOL_PATT_LEN_HI = 0x0f34,/* 24 bit      WOL Pattern Length 6..4 */
+
+/* WOL Pattern Counter Registers (YUKON only) */
+
+
+        WOL_PATT_CNT_0  = 0x0f38,/* 32 bit      WOL Pattern Counter 3..0 */
+        WOL_PATT_CNT_4  = 0x0f3c,/* 24 bit      WOL Pattern Counter 6..4 */
+};
+
+enum {
+        WOL_PATT_RAM_1  = 0x1000,/*  WOL Pattern RAM Link 1 */
+        WOL_PATT_RAM_2  = 0x1400,/*  WOL Pattern RAM Link 2 */
+};
+
+enum {
+        BASE_GMAC_1     = 0x2800,/* GMAC 1 registers */
+        BASE_GMAC_2     = 0x3800,/* GMAC 2 registers */
+};
+
+/*
+ * Marvel-PHY Registers, indirect addressed over GMAC
+ */
+enum {
+        PHY_MARV_CTRL           = 0x00,/* 16 bit r/w    PHY Control Register */
+        PHY_MARV_STAT           = 0x01,/* 16 bit r/o    PHY Status Register */
+        PHY_MARV_ID0            = 0x02,/* 16 bit r/o    PHY ID0 Register */
+        PHY_MARV_ID1            = 0x03,/* 16 bit r/o    PHY ID1 Register */
+        PHY_MARV_AUNE_ADV       = 0x04,/* 16 bit r/w    Auto-Neg. Advertisement */
+        PHY_MARV_AUNE_LP        = 0x05,/* 16 bit r/o    Link Part Ability Reg */
+        PHY_MARV_AUNE_EXP       = 0x06,/* 16 bit r/o    Auto-Neg. Expansion Reg */
+        PHY_MARV_NEPG           = 0x07,/* 16 bit r/w    Next Page Register */
+        PHY_MARV_NEPG_LP        = 0x08,/* 16 bit r/o    Next Page Link Partner */
+        /* Marvel-specific registers */
+        PHY_MARV_1000T_CTRL     = 0x09,/* 16 bit r/w    1000Base-T Control Reg */
+        PHY_MARV_1000T_STAT     = 0x0a,/* 16 bit r/o    1000Base-T Status Reg */
+        PHY_MARV_EXT_STAT       = 0x0f,/* 16 bit r/o    Extended Status Reg */
+        PHY_MARV_PHY_CTRL       = 0x10,/* 16 bit r/w    PHY Specific Ctrl Reg */
+        PHY_MARV_PHY_STAT       = 0x11,/* 16 bit r/o    PHY Specific Stat Reg */
+        PHY_MARV_INT_MASK       = 0x12,/* 16 bit r/w    Interrupt Mask Reg */
+        PHY_MARV_INT_STAT       = 0x13,/* 16 bit r/o    Interrupt Status Reg */
+        PHY_MARV_EXT_CTRL       = 0x14,/* 16 bit r/w    Ext. PHY Specific Ctrl */
+        PHY_MARV_RXE_CNT        = 0x15,/* 16 bit r/w    Receive Error Counter */
+        PHY_MARV_EXT_ADR        = 0x16,/* 16 bit r/w    Ext. Ad. for Cable Diag. */
+        PHY_MARV_PORT_IRQ       = 0x17,/* 16 bit r/o    Port 0 IRQ (88E1111 only) */
+        PHY_MARV_LED_CTRL       = 0x18,/* 16 bit r/w    LED Control Reg */
+        PHY_MARV_LED_OVER       = 0x19,/* 16 bit r/w    Manual LED Override Reg */
+        PHY_MARV_EXT_CTRL_2     = 0x1a,/* 16 bit r/w    Ext. PHY Specific Ctrl 2 */
+        PHY_MARV_EXT_P_STAT     = 0x1b,/* 16 bit r/w    Ext. PHY Spec. Stat Reg */
+        PHY_MARV_CABLE_DIAG     = 0x1c,/* 16 bit r/o    Cable Diagnostic Reg */
+        PHY_MARV_PAGE_ADDR      = 0x1d,/* 16 bit r/w    Extended Page Address Reg */
+        PHY_MARV_PAGE_DATA      = 0x1e,/* 16 bit r/w    Extended Page Data Reg */
+
+/* for 10/100 Fast Ethernet PHY (88E3082 only) */
+        PHY_MARV_FE_LED_PAR     = 0x16,/* 16 bit r/w    LED Parallel Select Reg. */
+        PHY_MARV_FE_LED_SER     = 0x17,/* 16 bit r/w    LED Stream Select S. LED */
+        PHY_MARV_FE_VCT_TX      = 0x1a,/* 16 bit r/w    VCT Reg. for TXP/N Pins */
+        PHY_MARV_FE_VCT_RX      = 0x1b,/* 16 bit r/o    VCT Reg. for RXP/N Pins */
+        PHY_MARV_FE_SPEC_2      = 0x1c,/* 16 bit r/w    Specific Control Reg. 2 */
+};
+
+enum {
+        PHY_CT_RESET    = 1<<15, /* Bit 15: (sc)        clear all PHY related regs */
+        PHY_CT_LOOP     = 1<<14, /* Bit 14:     enable Loopback over PHY */
+        PHY_CT_SPS_LSB  = 1<<13, /* Bit 13:     Speed select, lower bit */
+        PHY_CT_ANE      = 1<<12, /* Bit 12:     Auto-Negotiation Enabled */
+        PHY_CT_PDOWN    = 1<<11, /* Bit 11:     Power Down Mode */
+        PHY_CT_ISOL     = 1<<10, /* Bit 10:     Isolate Mode */
+        PHY_CT_RE_CFG   = 1<<9, /* Bit  9:      (sc) Restart Auto-Negotiation */
+        PHY_CT_DUP_MD   = 1<<8, /* Bit  8:      Duplex Mode */
+        PHY_CT_COL_TST  = 1<<7, /* Bit  7:      Collision Test enabled */
+        PHY_CT_SPS_MSB  = 1<<6, /* Bit  6:      Speed select, upper bit */
+};
+
+enum {
+        PHY_CT_SP1000   = PHY_CT_SPS_MSB, /* enable speed of 1000 Mbps */
+        PHY_CT_SP100    = PHY_CT_SPS_LSB, /* enable speed of  100 Mbps */
+        PHY_CT_SP10     = 0,              /* enable speed of   10 Mbps */
+};
+
+enum {
+        PHY_ST_EXT_ST   = 1<<8, /* Bit  8:      Extended Status Present */
+
+        PHY_ST_PRE_SUP  = 1<<6, /* Bit  6:      Preamble Suppression */
+        PHY_ST_AN_OVER  = 1<<5, /* Bit  5:      Auto-Negotiation Over */
+        PHY_ST_REM_FLT  = 1<<4, /* Bit  4:      Remote Fault Condition Occured */
+        PHY_ST_AN_CAP   = 1<<3, /* Bit  3:      Auto-Negotiation Capability */
+        PHY_ST_LSYNC    = 1<<2, /* Bit  2:      Link Synchronized */
+        PHY_ST_JAB_DET  = 1<<1, /* Bit  1:      Jabber Detected */
+        PHY_ST_EXT_REG  = 1<<0, /* Bit  0:      Extended Register available */
+};
+
+enum {
+        PHY_I1_OUI_MSK  = 0x3f<<10, /* Bit 15..10:      Organization Unique ID */
+        PHY_I1_MOD_NUM  = 0x3f<<4, /* Bit  9.. 4:       Model Number */
+        PHY_I1_REV_MSK  = 0xf, /* Bit  3.. 0:   Revision Number */
+};
+
+/* different Marvell PHY Ids */
+enum {
+        PHY_MARV_ID0_VAL= 0x0141, /* Marvell Unique Identifier */
+
+        PHY_BCOM_ID1_A1 = 0x6041,
+        PHY_BCOM_ID1_B2 = 0x6043,
+        PHY_BCOM_ID1_C0 = 0x6044,
+        PHY_BCOM_ID1_C5 = 0x6047,
+
+        PHY_MARV_ID1_B0 = 0x0C23, /* Yukon (PHY 88E1011) */
+        PHY_MARV_ID1_B2 = 0x0C25, /* Yukon-Plus (PHY 88E1011) */
+        PHY_MARV_ID1_C2 = 0x0CC2, /* Yukon-EC (PHY 88E1111) */
+        PHY_MARV_ID1_Y2 = 0x0C91, /* Yukon-2 (PHY 88E1112) */
+};
+
+/* Advertisement register bits */
+enum {
+        PHY_AN_NXT_PG   = 1<<15, /* Bit 15:     Request Next Page */
+        PHY_AN_ACK      = 1<<14, /* Bit 14:     (ro) Acknowledge Received */
+        PHY_AN_RF       = 1<<13, /* Bit 13:     Remote Fault Bits */
+
+        PHY_AN_PAUSE_ASYM = 1<<11,/* Bit 11:    Try for asymmetric */
+        PHY_AN_PAUSE_CAP = 1<<10, /* Bit 10:    Try for pause */
+        PHY_AN_100BASE4 = 1<<9, /* Bit 9:       Try for 100mbps 4k packets */
+        PHY_AN_100FULL  = 1<<8, /* Bit 8:       Try for 100mbps full-duplex */
+        PHY_AN_100HALF  = 1<<7, /* Bit 7:       Try for 100mbps half-duplex */
+        PHY_AN_10FULL   = 1<<6, /* Bit 6:       Try for 10mbps full-duplex */
+        PHY_AN_10HALF   = 1<<5, /* Bit 5:       Try for 10mbps half-duplex */
+        PHY_AN_CSMA     = 1<<0, /* Bit 0:       Only selector supported */
+        PHY_AN_SEL      = 0x1f, /* Bit 4..0:    Selector Field, 00001=Ethernet*/
+        PHY_AN_FULL     = PHY_AN_100FULL | PHY_AN_10FULL | PHY_AN_CSMA,
+        PHY_AN_ALL      = PHY_AN_10HALF | PHY_AN_10FULL |
+                          PHY_AN_100HALF | PHY_AN_100FULL,
+};
+
+/*****  PHY_BCOM_1000T_STAT     16 bit r/o      1000Base-T Status Reg *****/
+/*****  PHY_MARV_1000T_STAT     16 bit r/o      1000Base-T Status Reg *****/
+enum {
+        PHY_B_1000S_MSF = 1<<15, /* Bit 15:     Master/Slave Fault */
+        PHY_B_1000S_MSR = 1<<14, /* Bit 14:     Master/Slave Result */
+        PHY_B_1000S_LRS = 1<<13, /* Bit 13:     Local Receiver Status */
+        PHY_B_1000S_RRS = 1<<12, /* Bit 12:     Remote Receiver Status */
+        PHY_B_1000S_LP_FD       = 1<<11, /* Bit 11:     Link Partner can FD */
+        PHY_B_1000S_LP_HD       = 1<<10, /* Bit 10:     Link Partner can HD */
+                                                                        /* Bit  9..8:   reserved */
+        PHY_B_1000S_IEC = 0xff, /* Bit  7..0:   Idle Error Count */
+};
+
+/** Marvell-Specific */
+enum {
+        PHY_M_AN_NXT_PG = 1<<15, /* Request Next Page */
+        PHY_M_AN_ACK    = 1<<14, /* (ro)        Acknowledge Received */
+        PHY_M_AN_RF     = 1<<13, /* Remote Fault */
+
+        PHY_M_AN_ASP    = 1<<11, /* Asymmetric Pause */
+        PHY_M_AN_PC     = 1<<10, /* MAC Pause implemented */
+        PHY_M_AN_100_T4 = 1<<9, /* Not cap. 100Base-T4 (always 0) */
+        PHY_M_AN_100_FD = 1<<8, /* Advertise 100Base-TX Full Duplex */
+        PHY_M_AN_100_HD = 1<<7, /* Advertise 100Base-TX Half Duplex */
+        PHY_M_AN_10_FD  = 1<<6, /* Advertise 10Base-TX Full Duplex */
+        PHY_M_AN_10_HD  = 1<<5, /* Advertise 10Base-TX Half Duplex */
+        PHY_M_AN_SEL_MSK =0x1f<<4,      /* Bit  4.. 0: Selector Field Mask */
+};
+
+/* special defines for FIBER (88E1011S only) */
+enum {
+        PHY_M_AN_ASP_X  = 1<<8, /* Asymmetric Pause */
+        PHY_M_AN_PC_X   = 1<<7, /* MAC Pause implemented */
+        PHY_M_AN_1000X_AHD      = 1<<6, /* Advertise 10000Base-X Half Duplex */
+        PHY_M_AN_1000X_AFD      = 1<<5, /* Advertise 10000Base-X Full Duplex */
+};
+
+/* Pause Bits (PHY_M_AN_ASP_X and PHY_M_AN_PC_X) encoding */
+enum {
+        PHY_M_P_NO_PAUSE_X      = 0<<7,/* Bit  8.. 7:   no Pause Mode */
+        PHY_M_P_SYM_MD_X        = 1<<7, /* Bit  8.. 7:  symmetric Pause Mode */
+        PHY_M_P_ASYM_MD_X       = 2<<7,/* Bit  8.. 7:   asymmetric Pause Mode */
+        PHY_M_P_BOTH_MD_X       = 3<<7,/* Bit  8.. 7:   both Pause Mode */
+};
+
+/*****  PHY_MARV_1000T_CTRL     16 bit r/w      1000Base-T Control Reg *****/
+enum {
+        PHY_M_1000C_TEST        = 7<<13,/* Bit 15..13:  Test Modes */
+        PHY_M_1000C_MSE = 1<<12, /* Manual Master/Slave Enable */
+        PHY_M_1000C_MSC = 1<<11, /* M/S Configuration (1=Master) */
+        PHY_M_1000C_MPD = 1<<10, /* Multi-Port Device */
+        PHY_M_1000C_AFD = 1<<9, /* Advertise Full Duplex */
+        PHY_M_1000C_AHD = 1<<8, /* Advertise Half Duplex */
+};
+
+/*****  PHY_MARV_PHY_CTRL       16 bit r/w      PHY Specific Ctrl Reg *****/
+enum {
+        PHY_M_PC_TX_FFD_MSK     = 3<<14,/* Bit 15..14: Tx FIFO Depth Mask */
+        PHY_M_PC_RX_FFD_MSK     = 3<<12,/* Bit 13..12: Rx FIFO Depth Mask */
+        PHY_M_PC_ASS_CRS_TX     = 1<<11, /* Assert CRS on Transmit */
+        PHY_M_PC_FL_GOOD        = 1<<10, /* Force Link Good */
+        PHY_M_PC_EN_DET_MSK     = 3<<8,/* Bit  9.. 8: Energy Detect Mask */
+        PHY_M_PC_ENA_EXT_D      = 1<<7, /* Enable Ext. Distance (10BT) */
+        PHY_M_PC_MDIX_MSK       = 3<<5,/* Bit  6.. 5: MDI/MDIX Config. Mask */
+        PHY_M_PC_DIS_125CLK     = 1<<4, /* Disable 125 CLK */
+        PHY_M_PC_MAC_POW_UP     = 1<<3, /* MAC Power up */
+        PHY_M_PC_SQE_T_ENA      = 1<<2, /* SQE Test Enabled */
+        PHY_M_PC_POL_R_DIS      = 1<<1, /* Polarity Reversal Disabled */
+        PHY_M_PC_DIS_JABBER     = 1<<0, /* Disable Jabber */
+};
+
+enum {
+        PHY_M_PC_EN_DET         = 2<<8, /* Energy Detect (Mode 1) */
+        PHY_M_PC_EN_DET_PLUS    = 3<<8, /* Energy Detect Plus (Mode 2) */
+};
+
+#define PHY_M_PC_MDI_XMODE(x)   (((x)<<5) & PHY_M_PC_MDIX_MSK)
+
+enum {
+        PHY_M_PC_MAN_MDI        = 0, /* 00 = Manual MDI configuration */
+        PHY_M_PC_MAN_MDIX       = 1, /* 01 = Manual MDIX configuration */
+        PHY_M_PC_ENA_AUTO       = 3, /* 11 = Enable Automatic Crossover */
+};
+
+/* for 10/100 Fast Ethernet PHY (88E3082 only) */
+enum {
+        PHY_M_PC_ENA_DTE_DT     = 1<<15, /* Enable Data Terminal Equ. (DTE) Detect */
+        PHY_M_PC_ENA_ENE_DT     = 1<<14, /* Enable Energy Detect (sense & pulse) */
+        PHY_M_PC_DIS_NLP_CK     = 1<<13, /* Disable Normal Link Puls (NLP) Check */
+        PHY_M_PC_ENA_LIP_NP     = 1<<12, /* Enable Link Partner Next Page Reg. */
+        PHY_M_PC_DIS_NLP_GN     = 1<<11, /* Disable Normal Link Puls Generation */
+
+        PHY_M_PC_DIS_SCRAMB     = 1<<9, /* Disable Scrambler */
+        PHY_M_PC_DIS_FEFI       = 1<<8, /* Disable Far End Fault Indic. (FEFI) */
+
+        PHY_M_PC_SH_TP_SEL      = 1<<6, /* Shielded Twisted Pair Select */
+        PHY_M_PC_RX_FD_MSK      = 3<<2,/* Bit  3.. 2: Rx FIFO Depth Mask */
+};
+
+/*****  PHY_MARV_PHY_STAT       16 bit r/o      PHY Specific Status Reg *****/
+enum {
+        PHY_M_PS_SPEED_MSK      = 3<<14, /* Bit 15..14: Speed Mask */
+        PHY_M_PS_SPEED_1000     = 1<<15, /*             10 = 1000 Mbps */
+        PHY_M_PS_SPEED_100      = 1<<14, /*             01 =  100 Mbps */
+        PHY_M_PS_SPEED_10       = 0,     /*             00 =   10 Mbps */
+        PHY_M_PS_FULL_DUP       = 1<<13, /* Full Duplex */
+        PHY_M_PS_PAGE_REC       = 1<<12, /* Page Received */
+        PHY_M_PS_SPDUP_RES      = 1<<11, /* Speed & Duplex Resolved */
+        PHY_M_PS_LINK_UP        = 1<<10, /* Link Up */
+        PHY_M_PS_CABLE_MSK      = 7<<7,  /* Bit  9.. 7: Cable Length Mask */
+        PHY_M_PS_MDI_X_STAT     = 1<<6,  /* MDI Crossover Stat (1=MDIX) */
+        PHY_M_PS_DOWNS_STAT     = 1<<5,  /* Downshift Status (1=downsh.) */
+        PHY_M_PS_ENDET_STAT     = 1<<4,  /* Energy Detect Status (1=act) */
+        PHY_M_PS_TX_P_EN        = 1<<3,  /* Tx Pause Enabled */
+        PHY_M_PS_RX_P_EN        = 1<<2,  /* Rx Pause Enabled */
+        PHY_M_PS_POL_REV        = 1<<1,  /* Polarity Reversed */
+        PHY_M_PS_JABBER         = 1<<0,  /* Jabber */
+};
+
+#define PHY_M_PS_PAUSE_MSK      (PHY_M_PS_TX_P_EN | PHY_M_PS_RX_P_EN)
+
+/* for 10/100 Fast Ethernet PHY (88E3082 only) */
+enum {
+        PHY_M_PS_DTE_DETECT     = 1<<15, /* Data Terminal Equipment (DTE) Detected */
+        PHY_M_PS_RES_SPEED      = 1<<14, /* Resolved Speed (1=100 Mbps, 0=10 Mbps */
+};
+
+enum {
+        PHY_M_IS_AN_ERROR       = 1<<15, /* Auto-Negotiation Error */
+        PHY_M_IS_LSP_CHANGE     = 1<<14, /* Link Speed Changed */
+        PHY_M_IS_DUP_CHANGE     = 1<<13, /* Duplex Mode Changed */
+        PHY_M_IS_AN_PR          = 1<<12, /* Page Received */
+        PHY_M_IS_AN_COMPL       = 1<<11, /* Auto-Negotiation Completed */
+        PHY_M_IS_LST_CHANGE     = 1<<10, /* Link Status Changed */
+        PHY_M_IS_SYMB_ERROR     = 1<<9, /* Symbol Error */
+        PHY_M_IS_FALSE_CARR     = 1<<8, /* False Carrier */
+        PHY_M_IS_FIFO_ERROR     = 1<<7, /* FIFO Overflow/Underrun Error */
+        PHY_M_IS_MDI_CHANGE     = 1<<6, /* MDI Crossover Changed */
+        PHY_M_IS_DOWNSH_DET     = 1<<5, /* Downshift Detected */
+        PHY_M_IS_END_CHANGE     = 1<<4, /* Energy Detect Changed */
+
+        PHY_M_IS_DTE_CHANGE     = 1<<2, /* DTE Power Det. Status Changed */
+        PHY_M_IS_POL_CHANGE     = 1<<1, /* Polarity Changed */
+        PHY_M_IS_JABBER         = 1<<0, /* Jabber */
+
+        PHY_M_DEF_MSK           = PHY_M_IS_LSP_CHANGE | PHY_M_IS_LST_CHANGE
+                                 | PHY_M_IS_FIFO_ERROR,
+        PHY_M_AN_MSK           = PHY_M_IS_AN_ERROR | PHY_M_IS_AN_COMPL,
+};
+
+
+/*****  PHY_MARV_EXT_CTRL       16 bit r/w      Ext. PHY Specific Ctrl *****/
+enum {
+        PHY_M_EC_ENA_BC_EXT = 1<<15, /* Enable Block Carr. Ext. (88E1111 only) */
+        PHY_M_EC_ENA_LIN_LB = 1<<14, /* Enable Line Loopback (88E1111 only) */
+
+        PHY_M_EC_DIS_LINK_P = 1<<12, /* Disable Link Pulses (88E1111 only) */
+        PHY_M_EC_M_DSC_MSK  = 3<<10, /* Bit 11..10:     Master Downshift Counter */
+                                        /* (88E1011 only) */
+        PHY_M_EC_S_DSC_MSK  = 3<<8,/* Bit  9.. 8:       Slave  Downshift Counter */
+                                       /* (88E1011 only) */
+        PHY_M_EC_M_DSC_MSK2 = 7<<9,/* Bit 11.. 9:       Master Downshift Counter */
+                                        /* (88E1111 only) */
+        PHY_M_EC_DOWN_S_ENA = 1<<8, /* Downshift Enable (88E1111 only) */
+                                        /* !!! Errata in spec. (1 = disable) */
+        PHY_M_EC_RX_TIM_CT  = 1<<7, /* RGMII Rx Timing Control*/
+        PHY_M_EC_MAC_S_MSK  = 7<<4,/* Bit  6.. 4:       Def. MAC interface speed */
+        PHY_M_EC_FIB_AN_ENA = 1<<3, /* Fiber Auto-Neg. Enable (88E1011S only) */
+        PHY_M_EC_DTE_D_ENA  = 1<<2, /* DTE Detect Enable (88E1111 only) */
+        PHY_M_EC_TX_TIM_CT  = 1<<1, /* RGMII Tx Timing Control */
+        PHY_M_EC_TRANS_DIS  = 1<<0, /* Transmitter Disable (88E1111 only) */};
+
+#define PHY_M_EC_M_DSC(x)       ((x)<<10 & PHY_M_EC_M_DSC_MSK)
+                                        /* 00=1x; 01=2x; 10=3x; 11=4x */
+#define PHY_M_EC_S_DSC(x)       ((x)<<8 & PHY_M_EC_S_DSC_MSK)
+                                        /* 00=dis; 01=1x; 10=2x; 11=3x */
+#define PHY_M_EC_DSC_2(x)       ((x)<<9 & PHY_M_EC_M_DSC_MSK2)
+                                        /* 000=1x; 001=2x; 010=3x; 011=4x */
+#define PHY_M_EC_MAC_S(x)       ((x)<<4 & PHY_M_EC_MAC_S_MSK)
+                                        /* 01X=0; 110=2.5; 111=25 (MHz) */
+
+/* for Yukon-2 Gigabit Ethernet PHY (88E1112 only) */
+enum {
+        PHY_M_PC_DIS_LINK_Pa    = 1<<15,/* Disable Link Pulses */
+        PHY_M_PC_DSC_MSK        = 7<<12,/* Bit 14..12:  Downshift Counter */
+        PHY_M_PC_DOWN_S_ENA     = 1<<11,/* Downshift Enable */
+};
+/* !!! Errata in spec. (1 = disable) */
+
+#define PHY_M_PC_DSC(x)                 (((x)<<12) & PHY_M_PC_DSC_MSK)
+                                                                                        /* 100=5x; 101=6x; 110=7x; 111=8x */
+enum {
+        MAC_TX_CLK_0_MHZ        = 2,
+        MAC_TX_CLK_2_5_MHZ      = 6,
+        MAC_TX_CLK_25_MHZ       = 7,
+};
+
+/*****  PHY_MARV_LED_CTRL       16 bit r/w      LED Control Reg *****/
+enum {
+        PHY_M_LEDC_DIS_LED      = 1<<15, /* Disable LED */
+        PHY_M_LEDC_PULS_MSK     = 7<<12,/* Bit 14..12: Pulse Stretch Mask */
+        PHY_M_LEDC_F_INT        = 1<<11, /* Force Interrupt */
+        PHY_M_LEDC_BL_R_MSK     = 7<<8,/* Bit 10.. 8: Blink Rate Mask */
+        PHY_M_LEDC_DP_C_LSB     = 1<<7, /* Duplex Control (LSB, 88E1111 only) */
+        PHY_M_LEDC_TX_C_LSB     = 1<<6, /* Tx Control (LSB, 88E1111 only) */
+        PHY_M_LEDC_LK_C_MSK     = 7<<3,/* Bit  5.. 3: Link Control Mask */
+                                        /* (88E1111 only) */
+};
+
+enum {
+        PHY_M_LEDC_LINK_MSK     = 3<<3,/* Bit  4.. 3: Link Control Mask */
+                                                                        /* (88E1011 only) */
+        PHY_M_LEDC_DP_CTRL      = 1<<2, /* Duplex Control */
+        PHY_M_LEDC_DP_C_MSB     = 1<<2, /* Duplex Control (MSB, 88E1111 only) */
+        PHY_M_LEDC_RX_CTRL      = 1<<1, /* Rx Activity / Link */
+        PHY_M_LEDC_TX_CTRL      = 1<<0, /* Tx Activity / Link */
+        PHY_M_LEDC_TX_C_MSB     = 1<<0, /* Tx Control (MSB, 88E1111 only) */
+};
+
+#define PHY_M_LED_PULS_DUR(x)   (((x)<<12) & PHY_M_LEDC_PULS_MSK)
+
+/*****  PHY_MARV_PHY_STAT (page 3)16 bit r/w    Polarity Control Reg. *****/
+enum {
+        PHY_M_POLC_LS1M_MSK     = 0xf<<12, /* Bit 15..12: LOS,STAT1 Mix % Mask */
+        PHY_M_POLC_IS0M_MSK     = 0xf<<8,  /* Bit 11.. 8: INIT,STAT0 Mix % Mask */
+        PHY_M_POLC_LOS_MSK      = 0x3<<6,  /* Bit  7.. 6: LOS Pol. Ctrl. Mask */
+        PHY_M_POLC_INIT_MSK     = 0x3<<4,  /* Bit  5.. 4: INIT Pol. Ctrl. Mask */
+        PHY_M_POLC_STA1_MSK     = 0x3<<2,  /* Bit  3.. 2: STAT1 Pol. Ctrl. Mask */
+        PHY_M_POLC_STA0_MSK     = 0x3,     /* Bit  1.. 0: STAT0 Pol. Ctrl. Mask */
+};
+
+#define PHY_M_POLC_LS1_P_MIX(x) (((x)<<12) & PHY_M_POLC_LS1M_MSK)
+#define PHY_M_POLC_IS0_P_MIX(x) (((x)<<8) & PHY_M_POLC_IS0M_MSK)
+#define PHY_M_POLC_LOS_CTRL(x)  (((x)<<6) & PHY_M_POLC_LOS_MSK)
+#define PHY_M_POLC_INIT_CTRL(x) (((x)<<4) & PHY_M_POLC_INIT_MSK)
+#define PHY_M_POLC_STA1_CTRL(x) (((x)<<2) & PHY_M_POLC_STA1_MSK)
+#define PHY_M_POLC_STA0_CTRL(x) (((x)<<0) & PHY_M_POLC_STA0_MSK)
+
+enum {
+        PULS_NO_STR     = 0,/* no pulse stretching */
+        PULS_21MS       = 1,/* 21 ms to 42 ms */
+        PULS_42MS       = 2,/* 42 ms to 84 ms */
+        PULS_84MS       = 3,/* 84 ms to 170 ms */
+        PULS_170MS      = 4,/* 170 ms to 340 ms */
+        PULS_340MS      = 5,/* 340 ms to 670 ms */
+        PULS_670MS      = 6,/* 670 ms to 1.3 s */
+        PULS_1300MS     = 7,/* 1.3 s to 2.7 s */
+};
+
+#define PHY_M_LED_BLINK_RT(x)   (((x)<<8) & PHY_M_LEDC_BL_R_MSK)
+
+enum {
+        BLINK_42MS      = 0,/* 42 ms */
+        BLINK_84MS      = 1,/* 84 ms */
+        BLINK_170MS     = 2,/* 170 ms */
+        BLINK_340MS     = 3,/* 340 ms */
+        BLINK_670MS     = 4,/* 670 ms */
+};
+
+/*****  PHY_MARV_LED_OVER       16 bit r/w      Manual LED Override Reg *****/
+#define PHY_M_LED_MO_SGMII(x)   ((x)<<14) /* Bit 15..14:  SGMII AN Timer */
+                                                                                /* Bit 13..12:  reserved */
+#define PHY_M_LED_MO_DUP(x)     ((x)<<10) /* Bit 11..10:  Duplex */
+#define PHY_M_LED_MO_10(x)      ((x)<<8) /* Bit  9.. 8:  Link 10 */
+#define PHY_M_LED_MO_100(x)     ((x)<<6) /* Bit  7.. 6:  Link 100 */
+#define PHY_M_LED_MO_1000(x)    ((x)<<4) /* Bit  5.. 4:  Link 1000 */
+#define PHY_M_LED_MO_RX(x)      ((x)<<2) /* Bit  3.. 2:  Rx */
+#define PHY_M_LED_MO_TX(x)      ((x)<<0) /* Bit  1.. 0:  Tx */
+
+enum {
+        MO_LED_NORM     = 0,
+        MO_LED_BLINK    = 1,
+        MO_LED_OFF      = 2,
+        MO_LED_ON       = 3,
+};
+
+/*****  PHY_MARV_EXT_CTRL_2     16 bit r/w      Ext. PHY Specific Ctrl 2 *****/
+enum {
+        PHY_M_EC2_FI_IMPED      = 1<<6, /* Fiber Input  Impedance */
+        PHY_M_EC2_FO_IMPED      = 1<<5, /* Fiber Output Impedance */
+        PHY_M_EC2_FO_M_CLK      = 1<<4, /* Fiber Mode Clock Enable */
+        PHY_M_EC2_FO_BOOST      = 1<<3, /* Fiber Output Boost */
+        PHY_M_EC2_FO_AM_MSK     = 7,/* Bit  2.. 0:      Fiber Output Amplitude */
+};
+
+/*****  PHY_MARV_EXT_P_STAT 16 bit r/w  Ext. PHY Specific Status *****/
+enum {
+        PHY_M_FC_AUTO_SEL       = 1<<15, /* Fiber/Copper Auto Sel. Dis. */
+        PHY_M_FC_AN_REG_ACC     = 1<<14, /* Fiber/Copper AN Reg. Access */
+        PHY_M_FC_RESOLUTION     = 1<<13, /* Fiber/Copper Resolution */
+        PHY_M_SER_IF_AN_BP      = 1<<12, /* Ser. IF AN Bypass Enable */
+        PHY_M_SER_IF_BP_ST      = 1<<11, /* Ser. IF AN Bypass Status */
+        PHY_M_IRQ_POLARITY      = 1<<10, /* IRQ polarity */
+        PHY_M_DIS_AUT_MED       = 1<<9, /* Disable Aut. Medium Reg. Selection */
+        /* (88E1111 only) */
+
+        PHY_M_UNDOC1            = 1<<7, /* undocumented bit !! */
+        PHY_M_DTE_POW_STAT      = 1<<4, /* DTE Power Status (88E1111 only) */
+        PHY_M_MODE_MASK = 0xf, /* Bit  3.. 0: copy of HWCFG MODE[3:0] */
+};
+
+/* for 10/100 Fast Ethernet PHY (88E3082 only) */
+/*****  PHY_MARV_FE_LED_PAR             16 bit r/w      LED Parallel Select Reg. *****/
+                                                                        /* Bit 15..12: reserved (used internally) */
+enum {
+        PHY_M_FELP_LED2_MSK = 0xf<<8,   /* Bit 11.. 8: LED2 Mask (LINK) */
+        PHY_M_FELP_LED1_MSK = 0xf<<4,   /* Bit  7.. 4: LED1 Mask (ACT) */
+        PHY_M_FELP_LED0_MSK = 0xf, /* Bit  3.. 0: LED0 Mask (SPEED) */
+};
+
+#define PHY_M_FELP_LED2_CTRL(x) (((x)<<8) & PHY_M_FELP_LED2_MSK)
+#define PHY_M_FELP_LED1_CTRL(x) (((x)<<4) & PHY_M_FELP_LED1_MSK)
+#define PHY_M_FELP_LED0_CTRL(x) (((x)<<0) & PHY_M_FELP_LED0_MSK)
+
+enum {
+        LED_PAR_CTRL_COLX       = 0x00,
+        LED_PAR_CTRL_ERROR      = 0x01,
+        LED_PAR_CTRL_DUPLEX     = 0x02,
+        LED_PAR_CTRL_DP_COL     = 0x03,
+        LED_PAR_CTRL_SPEED      = 0x04,
+        LED_PAR_CTRL_LINK       = 0x05,
+        LED_PAR_CTRL_TX         = 0x06,
+        LED_PAR_CTRL_RX         = 0x07,
+        LED_PAR_CTRL_ACT        = 0x08,
+        LED_PAR_CTRL_LNK_RX     = 0x09,
+        LED_PAR_CTRL_LNK_AC     = 0x0a,
+        LED_PAR_CTRL_ACT_BL     = 0x0b,
+        LED_PAR_CTRL_TX_BL      = 0x0c,
+        LED_PAR_CTRL_RX_BL      = 0x0d,
+        LED_PAR_CTRL_COL_BL     = 0x0e,
+        LED_PAR_CTRL_INACT      = 0x0f
+};
+
+/*****,PHY_MARV_FE_SPEC_2               16 bit r/w      Specific Control Reg. 2 *****/
+enum {
+        PHY_M_FESC_DIS_WAIT     = 1<<2, /* Disable TDR Waiting Period */
+        PHY_M_FESC_ENA_MCLK     = 1<<1, /* Enable MAC Rx Clock in sleep mode */
+        PHY_M_FESC_SEL_CL_A     = 1<<0, /* Select Class A driver (100B-TX) */
+};
+
+/* for Yukon-2 Gigabit Ethernet PHY (88E1112 only) */
+/*****  PHY_MARV_PHY_CTRL (page 2)              16 bit r/w      MAC Specific Ctrl *****/
+enum {
+        PHY_M_MAC_MD_MSK        = 7<<7, /* Bit  9.. 7: Mode Select Mask */
+        PHY_M_MAC_MD_AUTO       = 3,/* Auto Copper/1000Base-X */
+        PHY_M_MAC_MD_COPPER     = 5,/* Copper only */
+        PHY_M_MAC_MD_1000BX     = 7,/* 1000Base-X only */
+};
+#define PHY_M_MAC_MODE_SEL(x)   (((x)<<7) & PHY_M_MAC_MD_MSK)
+
+/*****  PHY_MARV_PHY_CTRL (page 3)              16 bit r/w      LED Control Reg. *****/
+enum {
+        PHY_M_LEDC_LOS_MSK      = 0xf<<12,/* Bit 15..12: LOS LED Ctrl. Mask */
+        PHY_M_LEDC_INIT_MSK     = 0xf<<8, /* Bit 11.. 8: INIT LED Ctrl. Mask */
+        PHY_M_LEDC_STA1_MSK     = 0xf<<4,/* Bit  7.. 4: STAT1 LED Ctrl. Mask */
+        PHY_M_LEDC_STA0_MSK     = 0xf, /* Bit  3.. 0: STAT0 LED Ctrl. Mask */
+};
+
+#define PHY_M_LEDC_LOS_CTRL(x)  (((x)<<12) & PHY_M_LEDC_LOS_MSK)
+#define PHY_M_LEDC_INIT_CTRL(x) (((x)<<8) & PHY_M_LEDC_INIT_MSK)
+#define PHY_M_LEDC_STA1_CTRL(x) (((x)<<4) & PHY_M_LEDC_STA1_MSK)
+#define PHY_M_LEDC_STA0_CTRL(x) (((x)<<0) & PHY_M_LEDC_STA0_MSK)
+
+/* GMAC registers  */
+/* Port Registers */
+enum {
+        GM_GP_STAT      = 0x0000,       /* 16 bit r/o   General Purpose Status */
+        GM_GP_CTRL      = 0x0004,       /* 16 bit r/w   General Purpose Control */
+        GM_TX_CTRL      = 0x0008,       /* 16 bit r/w   Transmit Control Reg. */
+        GM_RX_CTRL      = 0x000c,       /* 16 bit r/w   Receive Control Reg. */
+        GM_TX_FLOW_CTRL = 0x0010,       /* 16 bit r/w   Transmit Flow-Control */
+        GM_TX_PARAM     = 0x0014,       /* 16 bit r/w   Transmit Parameter Reg. */
+        GM_SERIAL_MODE  = 0x0018,       /* 16 bit r/w   Serial Mode Register */
+/* Source Address Registers */
+        GM_SRC_ADDR_1L  = 0x001c,       /* 16 bit r/w   Source Address 1 (low) */
+        GM_SRC_ADDR_1M  = 0x0020,       /* 16 bit r/w   Source Address 1 (middle) */
+        GM_SRC_ADDR_1H  = 0x0024,       /* 16 bit r/w   Source Address 1 (high) */
+        GM_SRC_ADDR_2L  = 0x0028,       /* 16 bit r/w   Source Address 2 (low) */
+        GM_SRC_ADDR_2M  = 0x002c,       /* 16 bit r/w   Source Address 2 (middle) */
+        GM_SRC_ADDR_2H  = 0x0030,       /* 16 bit r/w   Source Address 2 (high) */
+
+/* Multicast Address Hash Registers */
+        GM_MC_ADDR_H1   = 0x0034,       /* 16 bit r/w   Multicast Address Hash 1 */
+        GM_MC_ADDR_H2   = 0x0038,       /* 16 bit r/w   Multicast Address Hash 2 */
+        GM_MC_ADDR_H3   = 0x003c,       /* 16 bit r/w   Multicast Address Hash 3 */
+        GM_MC_ADDR_H4   = 0x0040,       /* 16 bit r/w   Multicast Address Hash 4 */
+
+/* Interrupt Source Registers */
+        GM_TX_IRQ_SRC   = 0x0044,       /* 16 bit r/o   Tx Overflow IRQ Source */
+        GM_RX_IRQ_SRC   = 0x0048,       /* 16 bit r/o   Rx Overflow IRQ Source */
+        GM_TR_IRQ_SRC   = 0x004c,       /* 16 bit r/o   Tx/Rx Over. IRQ Source */
+
+/* Interrupt Mask Registers */
+        GM_TX_IRQ_MSK   = 0x0050,       /* 16 bit r/w   Tx Overflow IRQ Mask */
+        GM_RX_IRQ_MSK   = 0x0054,       /* 16 bit r/w   Rx Overflow IRQ Mask */
+        GM_TR_IRQ_MSK   = 0x0058,       /* 16 bit r/w   Tx/Rx Over. IRQ Mask */
+
+/* Serial Management Interface (SMI) Registers */
+        GM_SMI_CTRL     = 0x0080,       /* 16 bit r/w   SMI Control Register */
+        GM_SMI_DATA     = 0x0084,       /* 16 bit r/w   SMI Data Register */
+        GM_PHY_ADDR     = 0x0088,       /* 16 bit r/w   GPHY Address Register */
+};
+
+/* MIB Counters */
+#define GM_MIB_CNT_BASE 0x0100          /* Base Address of MIB Counters */
+#define GM_MIB_CNT_SIZE 44              /* Number of MIB Counters */
+
+/*
+ * MIB Counters base address definitions (low word) -
+ * use offset 4 for access to high word (32 bit r/o)
+ */
+enum {
+        GM_RXF_UC_OK  = GM_MIB_CNT_BASE + 0,    /* Unicast Frames Received OK */
+        GM_RXF_BC_OK    = GM_MIB_CNT_BASE + 8,  /* Broadcast Frames Received OK */
+        GM_RXF_MPAUSE   = GM_MIB_CNT_BASE + 16, /* Pause MAC Ctrl Frames Received */
+        GM_RXF_MC_OK    = GM_MIB_CNT_BASE + 24, /* Multicast Frames Received OK */
+        GM_RXF_FCS_ERR  = GM_MIB_CNT_BASE + 32, /* Rx Frame Check Seq. Error */
+        /* GM_MIB_CNT_BASE + 40:        reserved */
+        GM_RXO_OK_LO    = GM_MIB_CNT_BASE + 48, /* Octets Received OK Low */
+        GM_RXO_OK_HI    = GM_MIB_CNT_BASE + 56, /* Octets Received OK High */
+        GM_RXO_ERR_LO   = GM_MIB_CNT_BASE + 64, /* Octets Received Invalid Low */
+        GM_RXO_ERR_HI   = GM_MIB_CNT_BASE + 72, /* Octets Received Invalid High */
+        GM_RXF_SHT      = GM_MIB_CNT_BASE + 80, /* Frames <64 Byte Received OK */
+        GM_RXE_FRAG     = GM_MIB_CNT_BASE + 88, /* Frames <64 Byte Received with FCS Err */
+        GM_RXF_64B      = GM_MIB_CNT_BASE + 96, /* 64 Byte Rx Frame */
+        GM_RXF_127B     = GM_MIB_CNT_BASE + 104,        /* 65-127 Byte Rx Frame */
+        GM_RXF_255B     = GM_MIB_CNT_BASE + 112,        /* 128-255 Byte Rx Frame */
+        GM_RXF_511B     = GM_MIB_CNT_BASE + 120,        /* 256-511 Byte Rx Frame */
+        GM_RXF_1023B    = GM_MIB_CNT_BASE + 128,        /* 512-1023 Byte Rx Frame */
+        GM_RXF_1518B    = GM_MIB_CNT_BASE + 136,        /* 1024-1518 Byte Rx Frame */
+        GM_RXF_MAX_SZ   = GM_MIB_CNT_BASE + 144,        /* 1519-MaxSize Byte Rx Frame */
+        GM_RXF_LNG_ERR  = GM_MIB_CNT_BASE + 152,        /* Rx Frame too Long Error */
+        GM_RXF_JAB_PKT  = GM_MIB_CNT_BASE + 160,        /* Rx Jabber Packet Frame */
+        /* GM_MIB_CNT_BASE + 168:       reserved */
+        GM_RXE_FIFO_OV  = GM_MIB_CNT_BASE + 176,        /* Rx FIFO overflow Event */
+        /* GM_MIB_CNT_BASE + 184:       reserved */
+        GM_TXF_UC_OK    = GM_MIB_CNT_BASE + 192,        /* Unicast Frames Xmitted OK */
+        GM_TXF_BC_OK    = GM_MIB_CNT_BASE + 200,        /* Broadcast Frames Xmitted OK */
+        GM_TXF_MPAUSE   = GM_MIB_CNT_BASE + 208,        /* Pause MAC Ctrl Frames Xmitted */
+        GM_TXF_MC_OK    = GM_MIB_CNT_BASE + 216,        /* Multicast Frames Xmitted OK */
+        GM_TXO_OK_LO    = GM_MIB_CNT_BASE + 224,        /* Octets Transmitted OK Low */
+        GM_TXO_OK_HI    = GM_MIB_CNT_BASE + 232,        /* Octets Transmitted OK High */
+        GM_TXF_64B      = GM_MIB_CNT_BASE + 240,        /* 64 Byte Tx Frame */
+        GM_TXF_127B     = GM_MIB_CNT_BASE + 248,        /* 65-127 Byte Tx Frame */
+        GM_TXF_255B     = GM_MIB_CNT_BASE + 256,        /* 128-255 Byte Tx Frame */
+        GM_TXF_511B     = GM_MIB_CNT_BASE + 264,        /* 256-511 Byte Tx Frame */
+        GM_TXF_1023B    = GM_MIB_CNT_BASE + 272,        /* 512-1023 Byte Tx Frame */
+        GM_TXF_1518B    = GM_MIB_CNT_BASE + 280,        /* 1024-1518 Byte Tx Frame */
+        GM_TXF_MAX_SZ   = GM_MIB_CNT_BASE + 288,        /* 1519-MaxSize Byte Tx Frame */
+
+        GM_TXF_COL      = GM_MIB_CNT_BASE + 304,        /* Tx Collision */
+        GM_TXF_LAT_COL  = GM_MIB_CNT_BASE + 312,        /* Tx Late Collision */
+        GM_TXF_ABO_COL  = GM_MIB_CNT_BASE + 320,        /* Tx aborted due to Exces. Col. */
+        GM_TXF_MUL_COL  = GM_MIB_CNT_BASE + 328,        /* Tx Multiple Collision */
+        GM_TXF_SNG_COL  = GM_MIB_CNT_BASE + 336,        /* Tx Single Collision */
+        GM_TXE_FIFO_UR  = GM_MIB_CNT_BASE + 344,        /* Tx FIFO Underrun Event */
+};
+
+/* GMAC Bit Definitions */
+/*      GM_GP_STAT      16 bit r/o      General Purpose Status Register */
+enum {
+        GM_GPSR_SPEED           = 1<<15, /* Bit 15:     Port Speed (1 = 100 Mbps) */
+        GM_GPSR_DUPLEX          = 1<<14, /* Bit 14:     Duplex Mode (1 = Full) */
+        GM_GPSR_FC_TX_DIS       = 1<<13, /* Bit 13:     Tx Flow-Control Mode Disabled */
+        GM_GPSR_LINK_UP         = 1<<12, /* Bit 12:     Link Up Status */
+        GM_GPSR_PAUSE           = 1<<11, /* Bit 11:     Pause State */
+        GM_GPSR_TX_ACTIVE       = 1<<10, /* Bit 10:     Tx in Progress */
+        GM_GPSR_EXC_COL         = 1<<9, /* Bit  9:      Excessive Collisions Occured */
+        GM_GPSR_LAT_COL         = 1<<8, /* Bit  8:      Late Collisions Occured */
+
+        GM_GPSR_PHY_ST_CH       = 1<<5, /* Bit  5:      PHY Status Change */
+        GM_GPSR_GIG_SPEED       = 1<<4, /* Bit  4:      Gigabit Speed (1 = 1000 Mbps) */
+        GM_GPSR_PART_MODE       = 1<<3, /* Bit  3:      Partition mode */
+        GM_GPSR_FC_RX_DIS       = 1<<2, /* Bit  2:      Rx Flow-Control Mode Disabled */
+        GM_GPSR_PROM_EN         = 1<<1, /* Bit  1:      Promiscuous Mode Enabled */
+};
+
+/*      GM_GP_CTRL      16 bit r/w      General Purpose Control Register */
+enum {
+        GM_GPCR_PROM_ENA        = 1<<14,        /* Bit 14:      Enable Promiscuous Mode */
+        GM_GPCR_FC_TX_DIS       = 1<<13, /* Bit 13:     Disable Tx Flow-Control Mode */
+        GM_GPCR_TX_ENA          = 1<<12, /* Bit 12:     Enable Transmit */
+        GM_GPCR_RX_ENA          = 1<<11, /* Bit 11:     Enable Receive */
+        GM_GPCR_BURST_ENA       = 1<<10, /* Bit 10:     Enable Burst Mode */
+        GM_GPCR_LOOP_ENA        = 1<<9, /* Bit  9:      Enable MAC Loopback Mode */
+        GM_GPCR_PART_ENA        = 1<<8, /* Bit  8:      Enable Partition Mode */
+        GM_GPCR_GIGS_ENA        = 1<<7, /* Bit  7:      Gigabit Speed (1000 Mbps) */
+        GM_GPCR_FL_PASS         = 1<<6, /* Bit  6:      Force Link Pass */
+        GM_GPCR_DUP_FULL        = 1<<5, /* Bit  5:      Full Duplex Mode */
+        GM_GPCR_FC_RX_DIS       = 1<<4, /* Bit  4:      Disable Rx Flow-Control Mode */
+        GM_GPCR_SPEED_100       = 1<<3,   /* Bit  3:    Port Speed 100 Mbps */
+        GM_GPCR_AU_DUP_DIS      = 1<<2, /* Bit  2:      Disable Auto-Update Duplex */
+        GM_GPCR_AU_FCT_DIS      = 1<<1, /* Bit  1:      Disable Auto-Update Flow-C. */
+        GM_GPCR_AU_SPD_DIS      = 1<<0, /* Bit  0:      Disable Auto-Update Speed */
+};
+
+#define GM_GPCR_SPEED_1000      (GM_GPCR_GIGS_ENA | GM_GPCR_SPEED_100)
+#define GM_GPCR_AU_ALL_DIS      (GM_GPCR_AU_DUP_DIS | GM_GPCR_AU_FCT_DIS|GM_GPCR_AU_SPD_DIS)
+
+/*      GM_TX_CTRL                      16 bit r/w      Transmit Control Register */
+enum {
+        GM_TXCR_FORCE_JAM       = 1<<15, /* Bit 15:     Force Jam / Flow-Control */
+        GM_TXCR_CRC_DIS         = 1<<14, /* Bit 14:     Disable insertion of CRC */
+        GM_TXCR_PAD_DIS         = 1<<13, /* Bit 13:     Disable padding of packets */
+        GM_TXCR_COL_THR_MSK     = 1<<10, /* Bit 12..10: Collision Threshold */
+};
+
+#define TX_COL_THR(x)           (((x)<<10) & GM_TXCR_COL_THR_MSK)
+#define TX_COL_DEF              0x04
+
+/*      GM_RX_CTRL                      16 bit r/w      Receive Control Register */
+enum {
+        GM_RXCR_UCF_ENA = 1<<15, /* Bit 15:     Enable Unicast filtering */
+        GM_RXCR_MCF_ENA = 1<<14, /* Bit 14:     Enable Multicast filtering */
+        GM_RXCR_CRC_DIS = 1<<13, /* Bit 13:     Remove 4-byte CRC */
+        GM_RXCR_PASS_FC = 1<<12, /* Bit 12:     Pass FC packets to FIFO */
+};
+
+/*      GM_TX_PARAM             16 bit r/w      Transmit Parameter Register */
+enum {
+        GM_TXPA_JAMLEN_MSK      = 0x03<<14,     /* Bit 15..14:  Jam Length */
+        GM_TXPA_JAMIPG_MSK      = 0x1f<<9,      /* Bit 13..9:   Jam IPG */
+        GM_TXPA_JAMDAT_MSK      = 0x1f<<4,      /* Bit  8..4:   IPG Jam to Data */
+        GM_TXPA_BO_LIM_MSK      = 0x0f,         /* Bit  3.. 0: Backoff Limit Mask */
+
+        TX_JAM_LEN_DEF          = 0x03,
+        TX_JAM_IPG_DEF          = 0x0b,
+        TX_IPG_JAM_DEF          = 0x1c,
+        TX_BOF_LIM_DEF          = 0x04,
+};
+
+#define TX_JAM_LEN_VAL(x)       (((x)<<14) & GM_TXPA_JAMLEN_MSK)
+#define TX_JAM_IPG_VAL(x)       (((x)<<9)  & GM_TXPA_JAMIPG_MSK)
+#define TX_IPG_JAM_DATA(x)      (((x)<<4)  & GM_TXPA_JAMDAT_MSK)
+#define TX_BACK_OFF_LIM(x)      ((x) & GM_TXPA_BO_LIM_MSK)
+
+
+/*      GM_SERIAL_MODE                  16 bit r/w      Serial Mode Register */
+enum {
+        GM_SMOD_DATABL_MSK      = 0x1f<<11, /* Bit 15..11:      Data Blinder (r/o) */
+        GM_SMOD_LIMIT_4         = 1<<10, /* Bit 10:     4 consecutive Tx trials */
+        GM_SMOD_VLAN_ENA        = 1<<9, /* Bit  9:      Enable VLAN  (Max. Frame Len) */
+        GM_SMOD_JUMBO_ENA       = 1<<8, /* Bit  8:      Enable Jumbo (Max. Frame Len) */
+         GM_SMOD_IPG_MSK        = 0x1f  /* Bit 4..0:    Inter-Packet Gap (IPG) */
+};
+
+#define DATA_BLIND_VAL(x)       (((x)<<11) & GM_SMOD_DATABL_MSK)
+#define DATA_BLIND_DEF          0x04
+
+#define IPG_DATA_VAL(x)         (x & GM_SMOD_IPG_MSK)
+#define IPG_DATA_DEF            0x1e
+
+/*      GM_SMI_CTRL                     16 bit r/w      SMI Control Register */
+enum {
+        GM_SMI_CT_PHY_A_MSK     = 0x1f<<11,/* Bit 15..11:       PHY Device Address */
+        GM_SMI_CT_REG_A_MSK     = 0x1f<<6,/* Bit 10.. 6:        PHY Register Address */
+        GM_SMI_CT_OP_RD         = 1<<5, /* Bit  5:      OpCode Read (0=Write)*/
+        GM_SMI_CT_RD_VAL        = 1<<4, /* Bit  4:      Read Valid (Read completed) */
+        GM_SMI_CT_BUSY          = 1<<3, /* Bit  3:      Busy (Operation in progress) */
+};
+
+#define GM_SMI_CT_PHY_AD(x)     (((x)<<11) & GM_SMI_CT_PHY_A_MSK)
+#define GM_SMI_CT_REG_AD(x)     (((x)<<6) & GM_SMI_CT_REG_A_MSK)
+
+/*      GM_PHY_ADDR                             16 bit r/w      GPHY Address Register */
+enum {
+        GM_PAR_MIB_CLR  = 1<<5, /* Bit  5:      Set MIB Clear Counter Mode */
+        GM_PAR_MIB_TST  = 1<<4, /* Bit  4:      MIB Load Counter (Test Mode) */
+};
+
+/* Receive Frame Status Encoding */
+enum {
+        GMR_FS_LEN      = 0xffff<<16, /* Bit 31..16:    Rx Frame Length */
+        GMR_FS_VLAN     = 1<<13, /* VLAN Packet */
+        GMR_FS_JABBER   = 1<<12, /* Jabber Packet */
+        GMR_FS_UN_SIZE  = 1<<11, /* Undersize Packet */
+        GMR_FS_MC       = 1<<10, /* Multicast Packet */
+        GMR_FS_BC       = 1<<9,  /* Broadcast Packet */
+        GMR_FS_RX_OK    = 1<<8,  /* Receive OK (Good Packet) */
+        GMR_FS_GOOD_FC  = 1<<7,  /* Good Flow-Control Packet */
+        GMR_FS_BAD_FC   = 1<<6,  /* Bad  Flow-Control Packet */
+        GMR_FS_MII_ERR  = 1<<5,  /* MII Error */
+        GMR_FS_LONG_ERR = 1<<4,  /* Too Long Packet */
+        GMR_FS_FRAGMENT = 1<<3,  /* Fragment */
+
+        GMR_FS_CRC_ERR  = 1<<1,  /* CRC Error */
+        GMR_FS_RX_FF_OV = 1<<0,  /* Rx FIFO Overflow */
+
+        GMR_FS_ANY_ERR  = GMR_FS_RX_FF_OV | GMR_FS_CRC_ERR |
+                          GMR_FS_FRAGMENT | GMR_FS_LONG_ERR |
+                          GMR_FS_MII_ERR | GMR_FS_BAD_FC | GMR_FS_GOOD_FC |
+                          GMR_FS_UN_SIZE | GMR_FS_JABBER,
+};
+
+/*      RX_GMF_CTRL_T   32 bit  Rx GMAC FIFO Control/Test */
+enum {
+        RX_TRUNC_ON     = 1<<27,        /* enable  packet truncation */
+        RX_TRUNC_OFF    = 1<<26,        /* disable packet truncation */
+        RX_VLAN_STRIP_ON = 1<<25,       /* enable  VLAN stripping */
+        RX_VLAN_STRIP_OFF = 1<<24,      /* disable VLAN stripping */
+
+        GMF_WP_TST_ON   = 1<<14,        /* Write Pointer Test On */
+        GMF_WP_TST_OFF  = 1<<13,        /* Write Pointer Test Off */
+        GMF_WP_STEP     = 1<<12,        /* Write Pointer Step/Increment */
+
+        GMF_RP_TST_ON   = 1<<10,        /* Read Pointer Test On */
+        GMF_RP_TST_OFF  = 1<<9,         /* Read Pointer Test Off */
+        GMF_RP_STEP     = 1<<8,         /* Read Pointer Step/Increment */
+        GMF_RX_F_FL_ON  = 1<<7,         /* Rx FIFO Flush Mode On */
+        GMF_RX_F_FL_OFF = 1<<6,         /* Rx FIFO Flush Mode Off */
+        GMF_CLI_RX_FO   = 1<<5,         /* Clear IRQ Rx FIFO Overrun */
+        GMF_CLI_RX_C    = 1<<4,         /* Clear IRQ Rx Frame Complete */
+
+        GMF_OPER_ON     = 1<<3,         /* Operational Mode On */
+        GMF_OPER_OFF    = 1<<2,         /* Operational Mode Off */
+        GMF_RST_CLR     = 1<<1,         /* Clear GMAC FIFO Reset */
+        GMF_RST_SET     = 1<<0,         /* Set   GMAC FIFO Reset */
+
+        RX_GMF_FL_THR_DEF = 0xa,        /* flush threshold (default) */
+
+        GMF_RX_CTRL_DEF = GMF_OPER_ON | GMF_RX_F_FL_ON,
+};
+
+
+/*      TX_GMF_CTRL_T   32 bit  Tx GMAC FIFO Control/Test */
+enum {
+        TX_VLAN_TAG_ON  = 1<<25,/* enable  VLAN tagging */
+        TX_VLAN_TAG_OFF = 1<<24,/* disable VLAN tagging */
+
+        GMF_WSP_TST_ON  = 1<<18,/* Write Shadow Pointer Test On */
+        GMF_WSP_TST_OFF = 1<<17,/* Write Shadow Pointer Test Off */
+        GMF_WSP_STEP    = 1<<16,/* Write Shadow Pointer Step/Increment */
+
+        GMF_CLI_TX_FU   = 1<<6, /* Clear IRQ Tx FIFO Underrun */
+        GMF_CLI_TX_FC   = 1<<5, /* Clear IRQ Tx Frame Complete */
+        GMF_CLI_TX_PE   = 1<<4, /* Clear IRQ Tx Parity Error */
+};
+
+/*      GMAC_TI_ST_CTRL  8 bit  Time Stamp Timer Ctrl Reg (YUKON only) */
+enum {
+        GMT_ST_START    = 1<<2, /* Start Time Stamp Timer */
+        GMT_ST_STOP     = 1<<1, /* Stop  Time Stamp Timer */
+        GMT_ST_CLR_IRQ  = 1<<0, /* Clear Time Stamp Timer IRQ */
+};
+
+/* B28_Y2_ASF_STAT_CMD          32 bit  ASF Status and Command Reg */
+enum {
+        Y2_ASF_OS_PRES  = 1<<4, /* ASF operation system present */
+        Y2_ASF_RESET    = 1<<3, /* ASF system in reset state */
+        Y2_ASF_RUNNING  = 1<<2, /* ASF system operational */
+        Y2_ASF_CLR_HSTI = 1<<1, /* Clear ASF IRQ */
+        Y2_ASF_IRQ      = 1<<0, /* Issue an IRQ to ASF system */
+
+        Y2_ASF_UC_STATE = 3<<2, /* ASF uC State */
+        Y2_ASF_CLK_HALT = 0,    /* ASF system clock stopped */
+};
+
+/* B28_Y2_ASF_HOST_COM  32 bit  ASF Host Communication Reg */
+enum {
+        Y2_ASF_CLR_ASFI = 1<<1, /* Clear host IRQ */
+        Y2_ASF_HOST_IRQ = 1<<0, /* Issue an IRQ to HOST system */
+};
+
+/*      STAT_CTRL               32 bit  Status BMU control register (Yukon-2 only) */
+enum {
+        SC_STAT_CLR_IRQ = 1<<4, /* Status Burst IRQ clear */
+        SC_STAT_OP_ON   = 1<<3, /* Operational Mode On */
+        SC_STAT_OP_OFF  = 1<<2, /* Operational Mode Off */
+        SC_STAT_RST_CLR = 1<<1, /* Clear Status Unit Reset (Enable) */
+        SC_STAT_RST_SET = 1<<0, /* Set   Status Unit Reset */
+};
+
+/*      GMAC_CTRL               32 bit  GMAC Control Reg (YUKON only) */
+enum {
+        GMC_H_BURST_ON  = 1<<7, /* Half Duplex Burst Mode On */
+        GMC_H_BURST_OFF = 1<<6, /* Half Duplex Burst Mode Off */
+        GMC_F_LOOPB_ON  = 1<<5, /* FIFO Loopback On */
+        GMC_F_LOOPB_OFF = 1<<4, /* FIFO Loopback Off */
+        GMC_PAUSE_ON    = 1<<3, /* Pause On */
+        GMC_PAUSE_OFF   = 1<<2, /* Pause Off */
+        GMC_RST_CLR     = 1<<1, /* Clear GMAC Reset */
+        GMC_RST_SET     = 1<<0, /* Set   GMAC Reset */
+};
+
+/*      GPHY_CTRL               32 bit  GPHY Control Reg (YUKON only) */
+enum {
+        GPC_SEL_BDT     = 1<<28, /* Select Bi-Dir. Transfer for MDC/MDIO */
+        GPC_INT_POL_HI  = 1<<27, /* IRQ Polarity is Active HIGH */
+        GPC_75_OHM      = 1<<26, /* Use 75 Ohm Termination instead of 50 */
+        GPC_DIS_FC      = 1<<25, /* Disable Automatic Fiber/Copper Detection */
+        GPC_DIS_SLEEP   = 1<<24, /* Disable Energy Detect */
+        GPC_HWCFG_M_3   = 1<<23, /* HWCFG_MODE[3] */
+        GPC_HWCFG_M_2   = 1<<22, /* HWCFG_MODE[2] */
+        GPC_HWCFG_M_1   = 1<<21, /* HWCFG_MODE[1] */
+        GPC_HWCFG_M_0   = 1<<20, /* HWCFG_MODE[0] */
+        GPC_ANEG_0      = 1<<19, /* ANEG[0] */
+        GPC_ENA_XC      = 1<<18, /* Enable MDI crossover */
+        GPC_DIS_125     = 1<<17, /* Disable 125 MHz clock */
+        GPC_ANEG_3      = 1<<16, /* ANEG[3] */
+        GPC_ANEG_2      = 1<<15, /* ANEG[2] */
+        GPC_ANEG_1      = 1<<14, /* ANEG[1] */
+        GPC_ENA_PAUSE   = 1<<13, /* Enable Pause (SYM_OR_REM) */
+        GPC_PHYADDR_4   = 1<<12, /* Bit 4 of Phy Addr */
+        GPC_PHYADDR_3   = 1<<11, /* Bit 3 of Phy Addr */
+        GPC_PHYADDR_2   = 1<<10, /* Bit 2 of Phy Addr */
+        GPC_PHYADDR_1   = 1<<9,  /* Bit 1 of Phy Addr */
+        GPC_PHYADDR_0   = 1<<8,  /* Bit 0 of Phy Addr */
+                                                /* Bits  7..2:  reserved */
+        GPC_RST_CLR     = 1<<1, /* Clear GPHY Reset */
+        GPC_RST_SET     = 1<<0, /* Set   GPHY Reset */
+};
+
+/*      GMAC_IRQ_SRC     8 bit  GMAC Interrupt Source Reg (YUKON only) */
+/*      GMAC_IRQ_MSK     8 bit  GMAC Interrupt Mask   Reg (YUKON only) */
+enum {
+        GM_IS_TX_CO_OV  = 1<<5, /* Transmit Counter Overflow IRQ */
+        GM_IS_RX_CO_OV  = 1<<4, /* Receive Counter Overflow IRQ */
+        GM_IS_TX_FF_UR  = 1<<3, /* Transmit FIFO Underrun */
+        GM_IS_TX_COMPL  = 1<<2, /* Frame Transmission Complete */
+        GM_IS_RX_FF_OR  = 1<<1, /* Receive FIFO Overrun */
+        GM_IS_RX_COMPL  = 1<<0, /* Frame Reception Complete */
+
+#define GMAC_DEF_MSK     GM_IS_TX_FF_UR
+
+/*      GMAC_LINK_CTRL  16 bit  GMAC Link Control Reg (YUKON only) */
+                                                /* Bits 15.. 2: reserved */
+        GMLC_RST_CLR    = 1<<1, /* Clear GMAC Link Reset */
+        GMLC_RST_SET    = 1<<0, /* Set   GMAC Link Reset */
+
+
+/*      WOL_CTRL_STAT   16 bit  WOL Control/Status Reg */
+        WOL_CTL_LINK_CHG_OCC            = 1<<15,
+        WOL_CTL_MAGIC_PKT_OCC           = 1<<14,
+        WOL_CTL_PATTERN_OCC             = 1<<13,
+        WOL_CTL_CLEAR_RESULT            = 1<<12,
+        WOL_CTL_ENA_PME_ON_LINK_CHG     = 1<<11,
+        WOL_CTL_DIS_PME_ON_LINK_CHG     = 1<<10,
+        WOL_CTL_ENA_PME_ON_MAGIC_PKT    = 1<<9,
+        WOL_CTL_DIS_PME_ON_MAGIC_PKT    = 1<<8,
+        WOL_CTL_ENA_PME_ON_PATTERN      = 1<<7,
+        WOL_CTL_DIS_PME_ON_PATTERN      = 1<<6,
+        WOL_CTL_ENA_LINK_CHG_UNIT       = 1<<5,
+        WOL_CTL_DIS_LINK_CHG_UNIT       = 1<<4,
+        WOL_CTL_ENA_MAGIC_PKT_UNIT      = 1<<3,
+        WOL_CTL_DIS_MAGIC_PKT_UNIT      = 1<<2,
+        WOL_CTL_ENA_PATTERN_UNIT        = 1<<1,
+        WOL_CTL_DIS_PATTERN_UNIT        = 1<<0,
+};
+
+#define WOL_CTL_DEFAULT                         \
+        (WOL_CTL_DIS_PME_ON_LINK_CHG |  \
+        WOL_CTL_DIS_PME_ON_PATTERN |    \
+        WOL_CTL_DIS_PME_ON_MAGIC_PKT |  \
+        WOL_CTL_DIS_LINK_CHG_UNIT |             \
+        WOL_CTL_DIS_PATTERN_UNIT |              \
+        WOL_CTL_DIS_MAGIC_PKT_UNIT)
+
+/*      WOL_MATCH_CTL    8 bit  WOL Match Control Reg */
+#define WOL_CTL_PATT_ENA(x)     (1 << (x))
+
+
+/* Control flags */
+enum {
+        UDPTCP  = 1<<0,
+        CALSUM  = 1<<1,
+        WR_SUM  = 1<<2,
+        INIT_SUM= 1<<3,
+        LOCK_SUM= 1<<4,
+        INS_VLAN= 1<<5,
+        FRC_STAT= 1<<6,
+        EOP     = 1<<7,
+};
+
+enum {
+        HW_OWNER        = 1<<7,
+        OP_TCPWRITE     = 0x11,
+        OP_TCPSTART     = 0x12,
+        OP_TCPINIT      = 0x14,
+        OP_TCPLCK       = 0x18,
+        OP_TCPCHKSUM    = OP_TCPSTART,
+        OP_TCPIS        = OP_TCPINIT | OP_TCPSTART,
+        OP_TCPLW        = OP_TCPLCK | OP_TCPWRITE,
+        OP_TCPLSW       = OP_TCPLCK | OP_TCPSTART | OP_TCPWRITE,
+        OP_TCPLISW      = OP_TCPLCK | OP_TCPINIT | OP_TCPSTART | OP_TCPWRITE,
+
+        OP_ADDR64       = 0x21,
+        OP_VLAN         = 0x22,
+        OP_ADDR64VLAN   = OP_ADDR64 | OP_VLAN,
+        OP_LRGLEN       = 0x24,
+        OP_LRGLENVLAN   = OP_LRGLEN | OP_VLAN,
+        OP_BUFFER       = 0x40,
+        OP_PACKET       = 0x41,
+        OP_LARGESEND    = 0x43,
+
+/* YUKON-2 STATUS opcodes defines */
+        OP_RXSTAT       = 0x60,
+        OP_RXTIMESTAMP  = 0x61,
+        OP_RXVLAN       = 0x62,
+        OP_RXCHKS       = 0x64,
+        OP_RXCHKSVLAN   = OP_RXCHKS | OP_RXVLAN,
+        OP_RXTIMEVLAN   = OP_RXTIMESTAMP | OP_RXVLAN,
+        OP_RSS_HASH     = 0x65,
+        OP_TXINDEXLE    = 0x68,
+};
+
+/* Yukon 2 hardware interface
+ * Not tested on big endian
+ */
+struct sky2_tx_le {
+        union {
+                u32     addr;
+                struct {
+                        u16     offset;
+                        u16     start;
+                } csum  __attribute((packed));
+                struct {
+                        u16     size;
+                        u16     rsvd;
+                } tso  __attribute((packed));
+        } tx;
+        u16     length; /* also vlan tag or checksum start */
+        u8      ctrl;
+        u8      opcode;
+} __attribute((packed));
+
+struct sky2_rx_le {
+        u32     addr;
+        u16     length;
+        u8      ctrl;
+        u8      opcode;
+} __attribute((packed));;
+
+struct sky2_status_le {
+        u32     status; /* also checksum */
+        u16     length; /* also vlan tag */
+        u8      link;
+        u8      opcode;
+} __attribute((packed));
+
+struct ring_info {
+        struct sk_buff  *skb;
+        dma_addr_t      mapaddr;
+        u16             maplen;
+        u16             idx;
+};
+
+struct sky2_port {
+        struct sky2_hw       *hw;
+        struct net_device    *netdev;
+        unsigned             port;
+        u32                  msg_enable;
+
+        struct ring_info  *tx_ring;
+        struct sky2_tx_le    *tx_le;
+        spinlock_t           tx_lock;
+        u32                  tx_addr64;
+        u16                  tx_cons;           /* next le to check */
+        u16                  tx_prod;           /* next le to use */
+        u16                  tx_pending;
+        u16                  tx_last_put;
+        u16                  tx_last_mss;
+
+        struct ring_info  *rx_ring;
+        struct sky2_rx_le    *rx_le;
+        u32                  rx_addr64;
+        u16                  rx_next;           /* next re to check */
+        u16                  rx_put;            /* next le index to use */
+        u16                  rx_pending;
+        u16                  rx_last_put;
+#ifdef SKY2_VLAN_TAG_USED
+        u16                  rx_tag;
+        struct vlan_group    *vlgrp;
+#endif
+
+        dma_addr_t           rx_le_map;
+        dma_addr_t           tx_le_map;
+        u32                  advertising;       /* ADVERTISED_ bits */
+        u16                  speed;     /* SPEED_1000, SPEED_100, ... */
+        u8                   autoneg;   /* AUTONEG_ENABLE, AUTONEG_DISABLE */
+        u8                   duplex;    /* DUPLEX_HALF, DUPLEX_FULL */
+        u8                   rx_pause;
+        u8                   tx_pause;
+        u8                   rx_csum;
+        u8                   wol;
+
+        struct tasklet_struct phy_task;
+        struct net_device_stats net_stats;
+};
+
+struct sky2_hw {
+        void __iomem         *regs;
+        struct pci_dev       *pdev;
+        u32                  intr_mask;
+        struct net_device    *dev[2];
+
+        int                  pm_cap;
+        u8                   chip_id;
+        u8                   chip_rev;
+        u8                   copper;
+        u8                   ports;
+
+        struct sky2_status_le *st_le;
+        u32                  st_idx;
+        dma_addr_t           st_dma;
+
+        spinlock_t           phy_lock;
+};
+
+/* Register accessor for memory mapped device */
+static inline u32 sky2_read32(const struct sky2_hw *hw, unsigned reg)
+{
+        return readl(hw->regs + reg);
+}
+
+static inline u16 sky2_read16(const struct sky2_hw *hw, unsigned reg)
+{
+        return readw(hw->regs + reg);
+}
+
+static inline u8 sky2_read8(const struct sky2_hw *hw, unsigned reg)
+{
+        return readb(hw->regs + reg);
+}
+
+/* This should probably go away, bus based tweeks suck */
+static inline int is_pciex(const struct sky2_hw *hw)
+{
+        u32 status;
+        pci_read_config_dword(hw->pdev, PCI_DEV_STATUS, &status);
+        return (status & PCI_OS_PCI_X) == 0;
+}
+
+static inline void sky2_write32(const struct sky2_hw *hw, unsigned reg, u32 val)
+{
+        writel(val, hw->regs + reg);
+}
+
+static inline void sky2_write16(const struct sky2_hw *hw, unsigned reg, u16 val)
+{
+        writew(val, hw->regs + reg);
+}
+
+static inline void sky2_write8(const struct sky2_hw *hw, unsigned reg, u8 val)
+{
+        writeb(val, hw->regs + reg);
+}
+
+/* Yukon PHY related registers */
+#define SK_GMAC_REG(port,reg) \
+        (BASE_GMAC_1 + (port) * (BASE_GMAC_2-BASE_GMAC_1) + (reg))
+#define GM_PHY_RETRIES  100
+
+static inline u16 gma_read16(const struct sky2_hw *hw, unsigned port, unsigned reg)
+{
+        return sky2_read16(hw, SK_GMAC_REG(port,reg));
+}
+
+static inline u32 gma_read32(struct sky2_hw *hw, unsigned port, unsigned reg)
+{
+        unsigned base = SK_GMAC_REG(port, reg);
+        return (u32) sky2_read16(hw, base)
+                | (u32) sky2_read16(hw, base+4) << 16;
+}
+
+static inline void gma_write16(const struct sky2_hw *hw, unsigned port, int r, u16 v)
+{
+        sky2_write16(hw, SK_GMAC_REG(port,r), v);
+}
+
+static inline void gma_set_addr(struct sky2_hw *hw, unsigned port, unsigned reg,
+                                    const u8 *addr)
+{
+        gma_write16(hw, port, reg,  (u16) addr[0] | ((u16) addr[1] << 8));
+        gma_write16(hw, port, reg+4,(u16) addr[2] | ((u16) addr[3] << 8));
+        gma_write16(hw, port, reg+8,(u16) addr[4] | ((u16) addr[5] << 8));
+}
+#endif
diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
index a10cd184d597..5c2824be4ee6 100644
--- a/drivers/net/smc91x.h
+++ b/drivers/net/smc91x.h
@@ -100,14 +100,14 @@
 #define SMC_IO_SHIFT            0
 #define SMC_NOWAIT              1
 
-#define SMC_inb(a, r)           inb((a) + (r))
-#define SMC_insb(a, r, p, l)    insb((a) + (r), p, (l))
-#define SMC_inw(a, r)           inw((a) + (r))
-#define SMC_insw(a, r, p, l)    insw((a) + (r), p, l)
-#define SMC_outb(v, a, r)       outb(v, (a) + (r))
-#define SMC_outsb(a, r, p, l)   outsb((a) + (r), p, (l))
-#define SMC_outw(v, a, r)       outw(v, (a) + (r))
-#define SMC_outsw(a, r, p, l)   outsw((a) + (r), p, l)
+#define SMC_inb(a, r)           readb((a) + (r))
+#define SMC_insb(a, r, p, l)    readsb((a) + (r), p, (l))
+#define SMC_inw(a, r)           readw((a) + (r))
+#define SMC_insw(a, r, p, l)    readsw((a) + (r), p, l)
+#define SMC_outb(v, a, r)       writeb(v, (a) + (r))
+#define SMC_outsb(a, r, p, l)   writesb((a) + (r), p, (l))
+#define SMC_outw(v, a, r)       writew(v, (a) + (r))
+#define SMC_outsw(a, r, p, l)   writesw((a) + (r), p, l)
 
 #define set_irq_type(irq, type) do {} while (0)
 
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index de399563a9db..081717d01374 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -128,6 +128,8 @@ static struct pci_device_id gem_pci_tbl[] = {
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
         { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_SH_SUNGEM,
           PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
+        { PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_IPID2_GMAC,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
         {0, }
 };
 
diff --git a/drivers/net/wan/sdladrv.c b/drivers/net/wan/sdladrv.c
index 7c2cf2e76300..032c0f81928e 100644
--- a/drivers/net/wan/sdladrv.c
+++ b/drivers/net/wan/sdladrv.c
@@ -1994,7 +1994,7 @@ static int detect_s514 (sdlahw_t* hw)
                 modname, hw->irq);
 
         /* map the physical PCI memory to virtual memory */
-        (void *)hw->dpmbase = ioremap((unsigned long)S514_mem_base_addr,
+        hw->dpmbase = ioremap((unsigned long)S514_mem_base_addr,
                 (unsigned long)MAX_SIZEOF_S514_MEMORY);
         /* map the physical control register memory to virtual memory */
         hw->vector = (unsigned long)ioremap(
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index b0d195d1721a..5e7c7e944c9d 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -1110,8 +1110,7 @@ static struct ipw_fw_error *ipw_alloc_error_log(struct ipw_priv *priv)
         error->elem_len = elem_len;
         error->log_len = log_len;
         error->elem = (struct ipw_error_elem *)error->payload;
-        error->log = (struct ipw_event *)(error->elem +
-                                          (sizeof(*error->elem) * elem_len));
+        error->log = (struct ipw_event *)(error->elem + elem_len);
 
         ipw_capture_event_log(priv, log_len, error->log);
 
@@ -8926,6 +8925,10 @@ static int ipw_request_direct_scan(struct ipw_priv *priv, char *essid,
         struct ipw_scan_request_ext scan;
         int err = 0, scan_type;
 
+        if (!(priv->status & STATUS_INIT) ||
+            (priv->status & STATUS_EXIT_PENDING))
+                return 0;
+
         down(&priv->sem);
 
         if (priv->status & STATUS_RF_KILL_MASK) {
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 4a3cecca012c..2387e75da0fe 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -31,6 +31,8 @@
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/pci.h>
+#include <linux/interrupt.h>
+
 #include "../pci.h"
 #include "pciehp.h"
 
diff --git a/drivers/pci/hotplug/rpaphp_pci.c b/drivers/pci/hotplug/rpaphp_pci.c
index a7859a84d1ae..4b35097b3d9f 100644
--- a/drivers/pci/hotplug/rpaphp_pci.c
+++ b/drivers/pci/hotplug/rpaphp_pci.c
@@ -253,7 +253,7 @@ rpaphp_pci_config_slot(struct pci_bus *bus)
         if (!dn || !dn->child)
                 return NULL;
 
-        if (systemcfg->platform == PLATFORM_PSERIES_LPAR) {
+        if (_machine == PLATFORM_PSERIES_LPAR) {
                 of_scan_bus(dn, bus);
                 if (list_empty(&bus->devices)) {
                         err("%s: No new device found\n", __FUNCTION__);
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index 40905a6c8094..9987a6fd65b8 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -31,6 +31,8 @@
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/pci.h>
+#include <linux/interrupt.h>
+
 #include "shpchp.h"
 
 #ifdef DEBUG
diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
index 234cdca6fe13..a30aa74304a2 100644
--- a/drivers/pcmcia/cs.c
+++ b/drivers/pcmcia/cs.c
@@ -513,6 +513,11 @@ static int socket_insert(struct pcmcia_socket *skt)
         ret = socket_setup(skt, setup_delay);
         if (ret == CS_SUCCESS) {
                 skt->state |= SOCKET_PRESENT;
+
+                printk(KERN_NOTICE "pccard: %s card inserted into slot %d\n",
+                       (skt->state & SOCKET_CARDBUS) ? "CardBus" : "PCMCIA",
+                       skt->sock);
+
 #ifdef CONFIG_CARDBUS
                 if (skt->state & SOCKET_CARDBUS) {
                         cb_alloc(skt);
@@ -598,6 +603,7 @@ static int socket_resume(struct pcmcia_socket *skt)
 
 static void socket_remove(struct pcmcia_socket *skt)
 {
+        printk(KERN_NOTICE "pccard: card ejected from slot %d\n", skt->sock);
         socket_shutdown(skt);
         cs_socket_put(skt);
 }
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 39d096b52926..7f8219f3fd9e 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -544,6 +544,9 @@ struct pcmcia_device * pcmcia_device_add(struct pcmcia_socket *s, unsigned int f
         list_add_tail(&p_dev->socket_device_list, &s->devices_list);
         spin_unlock_irqrestore(&pcmcia_dev_list_lock, flags);
 
+        printk(KERN_NOTICE "pcmcia: registering new device %s\n",
+               p_dev->devname);
+
         pcmcia_device_query(p_dev);
 
         if (device_register(&p_dev->dev)) {
diff --git a/drivers/pcmcia/i82365.c b/drivers/pcmcia/i82365.c
index 4ddd76239b34..4d56bc9926d6 100644
--- a/drivers/pcmcia/i82365.c
+++ b/drivers/pcmcia/i82365.c
@@ -1339,10 +1339,7 @@ static struct device_driver i82365_driver = {
         .resume = pcmcia_socket_dev_resume,
 };
 
-static struct platform_device i82365_device = {
-        .name = "i82365",
-        .id = 0,
-};
+static struct platform_device *i82365_device;
 
 static int __init init_i82365(void)
 {
@@ -1352,7 +1349,14 @@ static int __init init_i82365(void)
     if (ret)
         return ret;
 
-    ret = platform_device_register(&i82365_device);
+    i82365_device = platform_device_alloc("i82365", 0);
+    if (i82365_device) {
+            ret = platform_device_add(i82365_device);
+            if (ret)
+                    platform_device_put(i82365_device);
+    } else
+            ret = -ENOMEM;
+
     if (ret) {
         driver_unregister(&i82365_driver);
         return ret;
@@ -1365,7 +1369,7 @@ static int __init init_i82365(void)
 
     if (sockets == 0) {
         printk("not found.\n");
-        platform_device_unregister(&i82365_device);
+        platform_device_unregister(i82365_device);
         release_region(i365_base, 2);
         driver_unregister(&i82365_driver);
         return -ENODEV;
@@ -1377,7 +1381,7 @@ static int __init init_i82365(void)
     
     /* register sockets with the pcmcia core */
     for (i = 0; i < sockets; i++) {
-            socket[i].socket.dev.dev = &i82365_device.dev;
+            socket[i].socket.dev.dev = &i82365_device->dev;
             socket[i].socket.ops = &pcic_operations;
             socket[i].socket.resource_ops = &pccard_nonstatic_ops;
             socket[i].socket.owner = THIS_MODULE;
@@ -1415,7 +1419,7 @@ static void __exit exit_i82365(void)
             if (socket[i].flags & IS_REGISTERED)
                     pcmcia_unregister_socket(&socket[i].socket);
     }
-    platform_device_unregister(&i82365_device);
+    platform_device_unregister(i82365_device);
     if (poll_interval != 0)
         del_timer_sync(&poll_timer);
     if (grab_irq != 0)
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index f5b7d360fc10..1026f2bc3185 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1179,12 +1179,12 @@ raw3270_create_attributes(struct raw3270 *rp)
         //FIXME: check return code
         sysfs_create_group(&rp->cdev->dev.kobj, &raw3270_attr_group);
         rp->clttydev =
-                class_device_create(class3270,
+                class_device_create(class3270, NULL,
                                     MKDEV(IBM_TTY3270_MAJOR, rp->minor),
                                     &rp->cdev->dev, "tty%s",
                                     rp->cdev->dev.bus_id);
         rp->cltubdev =
-                class_device_create(class3270,
+                class_device_create(class3270, NULL,
                                     MKDEV(IBM_FS3270_MAJOR, rp->minor),
                                     &rp->cdev->dev, "tub%s",
                                     rp->cdev->dev.bus_id);
diff --git a/drivers/sbus/char/rtc.c b/drivers/sbus/char/rtc.c
index 5774bdd0e26f..9b988baf0b51 100644
--- a/drivers/sbus/char/rtc.c
+++ b/drivers/sbus/char/rtc.c
@@ -210,27 +210,6 @@ static int rtc_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
         }
 }
 
-static long rtc_compat_ioctl(struct file *file, unsigned int cmd,
-        unsigned long arg)
-{
-        int rval = -ENOIOCTLCMD;
-
-        switch (cmd) {
-        /*
-         * These two are specific to this driver, the generic rtc ioctls
-         * are hanlded elsewhere.
-         */
-        case RTCGET:
-        case RTCSET:
-                lock_kernel();
-                rval = rtc_ioctl(file->f_dentry->d_inode, file, cmd, arg);
-                unlock_kernel();
-                break;
-        }
-
-        return rval;
-}
-
 static int rtc_open(struct inode *inode, struct file *file)
 {
         int ret;
@@ -258,7 +237,6 @@ static struct file_operations rtc_fops = {
         .owner =        THIS_MODULE,
         .llseek =       no_llseek,
         .ioctl =        rtc_ioctl,
-        .compat_ioctl = rtc_compat_ioctl,
         .open =         rtc_open,
         .release =      rtc_release,
 };
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 84c42c44e04d..20dd85a77813 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -497,7 +497,7 @@ config SCSI_ATA_PIIX
           If unsure, say N.
 
 config SCSI_SATA_MV
-        tristate "Marvell SATA support"
+        tristate "Marvell SATA support (HIGHLY EXPERIMENTAL)"
         depends on SCSI_SATA && PCI && EXPERIMENTAL
         help
           This option enables support for the Marvell Serial ATA family.
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 57ef7ae387d9..83467a05dc8e 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -48,7 +48,7 @@
 #include <asm/io.h>
 
 #define DRV_NAME        "ahci"
-#define DRV_VERSION     "1.01"
+#define DRV_VERSION     "1.2"
 
 
 enum {
@@ -134,6 +134,7 @@ enum {
                                   PORT_IRQ_D2H_REG_FIS,
 
         /* PORT_CMD bits */
+        PORT_CMD_ATAPI          = (1 << 24), /* Device is ATAPI */
         PORT_CMD_LIST_ON        = (1 << 15), /* cmd list DMA engine running */
         PORT_CMD_FIS_ON         = (1 << 14), /* FIS DMA engine running */
         PORT_CMD_FIS_RX         = (1 << 4), /* Enable FIS receive DMA engine */
@@ -441,7 +442,7 @@ static void ahci_phy_reset(struct ata_port *ap)
         void __iomem *port_mmio = (void __iomem *) ap->ioaddr.cmd_addr;
         struct ata_taskfile tf;
         struct ata_device *dev = &ap->device[0];
-        u32 tmp;
+        u32 new_tmp, tmp;
 
         __sata_phy_reset(ap);
 
@@ -455,8 +456,21 @@ static void ahci_phy_reset(struct ata_port *ap)
         tf.nsect        = (tmp)         & 0xff;
 
         dev->class = ata_dev_classify(&tf);
-        if (!ata_dev_present(dev))
+        if (!ata_dev_present(dev)) {
                 ata_port_disable(ap);
+                return;
+        }
+
+        /* Make sure port's ATAPI bit is set appropriately */
+        new_tmp = tmp = readl(port_mmio + PORT_CMD);
+        if (dev->class == ATA_DEV_ATAPI)
+                new_tmp |= PORT_CMD_ATAPI;
+        else
+                new_tmp &= ~PORT_CMD_ATAPI;
+        if (new_tmp != tmp) {
+                writel(new_tmp, port_mmio + PORT_CMD);
+                readl(port_mmio + PORT_CMD); /* flush */
+        }
 }
 
 static u8 ahci_check_status(struct ata_port *ap)
@@ -474,11 +488,12 @@ static void ahci_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
         ata_tf_from_fis(d2h_fis, tf);
 }
 
-static void ahci_fill_sg(struct ata_queued_cmd *qc)
+static unsigned int ahci_fill_sg(struct ata_queued_cmd *qc)
 {
         struct ahci_port_priv *pp = qc->ap->private_data;
         struct scatterlist *sg;
         struct ahci_sg *ahci_sg;
+        unsigned int n_sg = 0;
 
         VPRINTK("ENTER\n");
 
@@ -493,8 +508,12 @@ static void ahci_fill_sg(struct ata_queued_cmd *qc)
                 ahci_sg->addr = cpu_to_le32(addr & 0xffffffff);
                 ahci_sg->addr_hi = cpu_to_le32((addr >> 16) >> 16);
                 ahci_sg->flags_size = cpu_to_le32(sg_len - 1);
+
                 ahci_sg++;
+                n_sg++;
         }
+
+        return n_sg;
 }
 
 static void ahci_qc_prep(struct ata_queued_cmd *qc)
@@ -503,13 +522,14 @@ static void ahci_qc_prep(struct ata_queued_cmd *qc)
         struct ahci_port_priv *pp = ap->private_data;
         u32 opts;
         const u32 cmd_fis_len = 5; /* five dwords */
+        unsigned int n_elem;
 
         /*
          * Fill in command slot information (currently only one slot,
          * slot 0, is currently since we don't do queueing)
          */
 
-        opts = (qc->n_elem << 16) | cmd_fis_len;
+        opts = cmd_fis_len;
         if (qc->tf.flags & ATA_TFLAG_WRITE)
                 opts |= AHCI_CMD_WRITE;
         if (is_atapi_taskfile(&qc->tf))
@@ -533,16 +553,31 @@ static void ahci_qc_prep(struct ata_queued_cmd *qc)
         if (!(qc->flags & ATA_QCFLAG_DMAMAP))
                 return;
 
-        ahci_fill_sg(qc);
+        n_elem = ahci_fill_sg(qc);
+
+        pp->cmd_slot[0].opts |= cpu_to_le32(n_elem << 16);
 }
 
-static void ahci_intr_error(struct ata_port *ap, u32 irq_stat)
+static void ahci_restart_port(struct ata_port *ap, u32 irq_stat)
 {
         void __iomem *mmio = ap->host_set->mmio_base;
         void __iomem *port_mmio = ahci_port_base(mmio, ap->port_no);
         u32 tmp;
         int work;
 
+        if ((ap->device[0].class != ATA_DEV_ATAPI) ||
+            ((irq_stat & PORT_IRQ_TF_ERR) == 0))
+                printk(KERN_WARNING "ata%u: port reset, "
+                       "p_is %x is %x pis %x cmd %x tf %x ss %x se %x\n",
+                        ap->id,
+                        irq_stat,
+                        readl(mmio + HOST_IRQ_STAT),
+                        readl(port_mmio + PORT_IRQ_STAT),
+                        readl(port_mmio + PORT_CMD),
+                        readl(port_mmio + PORT_TFDATA),
+                        readl(port_mmio + PORT_SCR_STAT),
+                        readl(port_mmio + PORT_SCR_ERR));
+
         /* stop DMA */
         tmp = readl(port_mmio + PORT_CMD);
         tmp &= ~PORT_CMD_START;
@@ -580,8 +615,6 @@ static void ahci_intr_error(struct ata_port *ap, u32 irq_stat)
         tmp |= PORT_CMD_START;
         writel(tmp, port_mmio + PORT_CMD);
         readl(port_mmio + PORT_CMD); /* flush */
-
-        printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);
 }
 
 static void ahci_eng_timeout(struct ata_port *ap)
@@ -592,17 +625,17 @@ static void ahci_eng_timeout(struct ata_port *ap)
         struct ata_queued_cmd *qc;
         unsigned long flags;
 
-        DPRINTK("ENTER\n");
+        printk(KERN_WARNING "ata%u: handling error/timeout\n", ap->id);
 
         spin_lock_irqsave(&host_set->lock, flags);
 
-        ahci_intr_error(ap, readl(port_mmio + PORT_IRQ_STAT));
-
         qc = ata_qc_from_tag(ap, ap->active_tag);
         if (!qc) {
                 printk(KERN_ERR "ata%u: BUG: timeout without command\n",
                        ap->id);
         } else {
+                ahci_restart_port(ap, readl(port_mmio + PORT_IRQ_STAT));
+
                 /* hack alert!  We cannot use the supplied completion
                  * function from inside the ->eh_strategy_handler() thread.
                  * libata is the only user of ->eh_strategy_handler() in
@@ -637,9 +670,19 @@ static inline int ahci_host_intr(struct ata_port *ap, struct ata_queued_cmd *qc)
         }
 
         if (status & PORT_IRQ_FATAL) {
-                ahci_intr_error(ap, status);
+                unsigned int err_mask;
+                if (status & PORT_IRQ_TF_ERR)
+                        err_mask = AC_ERR_DEV;
+                else if (status & PORT_IRQ_IF_ERR)
+                        err_mask = AC_ERR_ATA_BUS;
+                else
+                        err_mask = AC_ERR_HOST_BUS;
+
+                /* command processing has stopped due to error; restart */
+                ahci_restart_port(ap, status);
+
                 if (qc)
-                        ata_qc_complete(qc, AC_ERR_OTHER);
+                        ata_qc_complete(qc, err_mask);
         }
 
         return 1;
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c
index 855428ff37e9..333d69dd84ef 100644
--- a/drivers/scsi/ata_piix.c
+++ b/drivers/scsi/ata_piix.c
@@ -50,7 +50,7 @@
 #include <linux/libata.h>
 
 #define DRV_NAME        "ata_piix"
-#define DRV_VERSION     "1.04"
+#define DRV_VERSION     "1.05"
 
 enum {
         PIIX_IOCFG              = 0x54, /* IDE I/O configuration register */
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index e51d9a8a2796..665ae79e1fd6 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -532,8 +532,7 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 *fis, u8 pmp)
  *      @fis: Buffer from which data will be input
  *      @tf: Taskfile to output
  *
- *      Converts a standard ATA taskfile to a Serial ATA
- *      FIS structure (Register - Host to Device).
+ *      Converts a serial ATA FIS structure to a standard ATA taskfile.
  *
  *      LOCKING:
  *      Inherited from caller.
@@ -1047,6 +1046,30 @@ static unsigned int ata_pio_modes(const struct ata_device *adev)
         return modes;
 }
 
+static int ata_qc_wait_err(struct ata_queued_cmd *qc,
+                           struct completion *wait)
+{
+        int rc = 0;
+
+        if (wait_for_completion_timeout(wait, 30 * HZ) < 1) {
+                /* timeout handling */
+                unsigned int err_mask = ac_err_mask(ata_chk_status(qc->ap));
+
+                if (!err_mask) {
+                        printk(KERN_WARNING "ata%u: slow completion (cmd %x)\n",
+                               qc->ap->id, qc->tf.command);
+                } else {
+                        printk(KERN_WARNING "ata%u: qc timeout (cmd %x)\n",
+                               qc->ap->id, qc->tf.command);
+                        rc = -EIO;
+                }
+
+                ata_qc_complete(qc, err_mask);
+        }
+
+        return rc;
+}
+
 /**
  *      ata_dev_identify - obtain IDENTIFY x DEVICE page
  *      @ap: port on which device we wish to probe resides
@@ -1126,7 +1149,7 @@ retry:
         if (rc)
                 goto err_out;
         else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
 
         spin_lock_irqsave(&ap->host_set->lock, flags);
         ap->ops->tf_read(ap, &qc->tf);
@@ -1264,7 +1287,7 @@ retry:
         }
 
         /* ATAPI-specific feature tests */
-        else {
+        else if (dev->class == ATA_DEV_ATAPI) {
                 if (ata_id_is_ata(dev->id))             /* sanity check */
                         goto err_out_nosup;
 
@@ -1571,11 +1594,13 @@ int ata_timing_compute(struct ata_device *adev, unsigned short speed,
 
         /*
          * Find the mode. 
-        */
+         */
 
         if (!(s = ata_timing_find_mode(speed)))
                 return -EINVAL;
 
+        memcpy(t, s, sizeof(*s));
+
         /*
          * If the drive is an EIDE drive, it can tell us it needs extended
          * PIO/MW_DMA cycle timing.
@@ -1596,7 +1621,7 @@ int ata_timing_compute(struct ata_device *adev, unsigned short speed,
          * Convert the timing to bus clock counts.
          */
 
-        ata_timing_quantize(s, t, T, UT);
+        ata_timing_quantize(t, t, T, UT);
 
         /*
          * Even in DMA/UDMA modes we still use PIO access for IDENTIFY, S.M.A.R.T
@@ -2268,7 +2293,7 @@ static void ata_dev_set_xfermode(struct ata_port *ap, struct ata_device *dev)
         if (rc)
                 ata_port_disable(ap);
         else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
 
         DPRINTK("EXIT\n");
 }
@@ -2316,7 +2341,7 @@ static void ata_dev_reread_id(struct ata_port *ap, struct ata_device *dev)
         if (rc)
                 goto err_out;
 
-        wait_for_completion(&wait);
+        ata_qc_wait_err(qc, &wait);
 
         swap_buf_le16(dev->id, ATA_ID_WORDS);
 
@@ -2372,7 +2397,7 @@ static void ata_dev_init_params(struct ata_port *ap, struct ata_device *dev)
         if (rc)
                 ata_port_disable(ap);
         else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
 
         DPRINTK("EXIT\n");
 }
@@ -2400,7 +2425,7 @@ static void ata_sg_clean(struct ata_queued_cmd *qc)
         if (qc->flags & ATA_QCFLAG_SINGLE)
                 assert(qc->n_elem == 1);
 
-        DPRINTK("unmapping %u sg elements\n", qc->n_elem);
+        VPRINTK("unmapping %u sg elements\n", qc->n_elem);
 
         /* if we padded the buffer out to 32-bit bound, and data
          * xfer direction is from-device, we must copy from the
@@ -2410,7 +2435,8 @@ static void ata_sg_clean(struct ata_queued_cmd *qc)
                 pad_buf = ap->pad + (qc->tag * ATA_DMA_PAD_SZ);
 
         if (qc->flags & ATA_QCFLAG_SG) {
-                dma_unmap_sg(ap->host_set->dev, sg, qc->n_elem, dir);
+                if (qc->n_elem)
+                        dma_unmap_sg(ap->host_set->dev, sg, qc->n_elem, dir);
                 /* restore last sg */
                 sg[qc->orig_n_elem - 1].length += qc->pad_len;
                 if (pad_buf) {
@@ -2420,8 +2446,10 @@ static void ata_sg_clean(struct ata_queued_cmd *qc)
                         kunmap_atomic(psg->page, KM_IRQ0);
                 }
         } else {
-                dma_unmap_single(ap->host_set->dev, sg_dma_address(&sg[0]),
-                                 sg_dma_len(&sg[0]), dir);
+                if (sg_dma_len(&sg[0]) > 0)
+                        dma_unmap_single(ap->host_set->dev,
+                                sg_dma_address(&sg[0]), sg_dma_len(&sg[0]),
+                                dir);
                 /* restore sg */
                 sg->length += qc->pad_len;
                 if (pad_buf)
@@ -2620,6 +2648,11 @@ static int ata_sg_setup_one(struct ata_queued_cmd *qc)
                         sg->length, qc->pad_len);
         }
 
+        if (!sg->length) {
+                sg_dma_address(sg) = 0;
+                goto skip_map;
+        }
+
         dma_address = dma_map_single(ap->host_set->dev, qc->buf_virt,
                                      sg->length, dir);
         if (dma_mapping_error(dma_address)) {
@@ -2629,6 +2662,7 @@ static int ata_sg_setup_one(struct ata_queued_cmd *qc)
         }
 
         sg_dma_address(sg) = dma_address;
+skip_map:
         sg_dma_len(sg) = sg->length;
 
         DPRINTK("mapped buffer of %d bytes for %s\n", sg_dma_len(sg),
@@ -2656,7 +2690,7 @@ static int ata_sg_setup(struct ata_queued_cmd *qc)
         struct ata_port *ap = qc->ap;
         struct scatterlist *sg = qc->__sg;
         struct scatterlist *lsg = &sg[qc->n_elem - 1];
-        int n_elem, dir;
+        int n_elem, pre_n_elem, dir, trim_sg = 0;
 
         VPRINTK("ENTER, ata%u\n", ap->id);
         assert(qc->flags & ATA_QCFLAG_SG);
@@ -2690,13 +2724,24 @@ static int ata_sg_setup(struct ata_queued_cmd *qc)
                 sg_dma_len(psg) = ATA_DMA_PAD_SZ;
                 /* trim last sg */
                 lsg->length -= qc->pad_len;
+                if (lsg->length == 0)
+                        trim_sg = 1;
 
                 DPRINTK("padding done, sg[%d].length=%u pad_len=%u\n",
                         qc->n_elem - 1, lsg->length, qc->pad_len);
         }
 
+        pre_n_elem = qc->n_elem;
+        if (trim_sg && pre_n_elem)
+                pre_n_elem--;
+
+        if (!pre_n_elem) {
+                n_elem = 0;
+                goto skip_map;
+        }
+
         dir = qc->dma_dir;
-        n_elem = dma_map_sg(ap->host_set->dev, sg, qc->n_elem, dir);
+        n_elem = dma_map_sg(ap->host_set->dev, sg, pre_n_elem, dir);
         if (n_elem < 1) {
                 /* restore last sg */
                 lsg->length += qc->pad_len;
@@ -2705,6 +2750,7 @@ static int ata_sg_setup(struct ata_queued_cmd *qc)
 
         DPRINTK("%d sg elements mapped\n", n_elem);
 
+skip_map:
         qc->n_elem = n_elem;
 
         return 0;
@@ -3264,32 +3310,11 @@ static void ata_qc_timeout(struct ata_queued_cmd *qc)
 {
         struct ata_port *ap = qc->ap;
         struct ata_host_set *host_set = ap->host_set;
-        struct ata_device *dev = qc->dev;
         u8 host_stat = 0, drv_stat;
         unsigned long flags;
 
         DPRINTK("ENTER\n");
 
-        /* FIXME: doesn't this conflict with timeout handling? */
-        if (qc->dev->class == ATA_DEV_ATAPI && qc->scsicmd) {
-                struct scsi_cmnd *cmd = qc->scsicmd;
-
-                if (!(cmd->eh_eflags & SCSI_EH_CANCEL_CMD)) {
-
-                        /* finish completing original command */
-                        spin_lock_irqsave(&host_set->lock, flags);
-                        __ata_qc_complete(qc);
-                        spin_unlock_irqrestore(&host_set->lock, flags);
-
-                        atapi_request_sense(ap, dev, cmd);
-
-                        cmd->result = (CHECK_CONDITION << 1) | (DID_OK << 16);
-                        scsi_finish_command(cmd);
-
-                        goto out;
-                }
-        }
-
         spin_lock_irqsave(&host_set->lock, flags);
 
         /* hack alert!  We cannot use the supplied completion
@@ -3328,7 +3353,6 @@ static void ata_qc_timeout(struct ata_queued_cmd *qc)
 
         spin_unlock_irqrestore(&host_set->lock, flags);
 
-out:
         DPRINTK("EXIT\n");
 }
 
@@ -3412,16 +3436,11 @@ struct ata_queued_cmd *ata_qc_new_init(struct ata_port *ap,
 
         qc = ata_qc_new(ap);
         if (qc) {
-                qc->__sg = NULL;
-                qc->flags = 0;
                 qc->scsicmd = NULL;
                 qc->ap = ap;
                 qc->dev = dev;
-                qc->cursect = qc->cursg = qc->cursg_ofs = 0;
-                qc->nsect = 0;
-                qc->nbytes = qc->curbytes = 0;
 
-                ata_tf_init(ap, &qc->tf, dev->devno);
+                ata_qc_reinit(qc);
         }
 
         return qc;
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
index 261be24e1df3..3b4ca55a3332 100644
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -1955,22 +1955,44 @@ void ata_scsi_badcmd(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *), u8
         done(cmd);
 }
 
-void atapi_request_sense(struct ata_port *ap, struct ata_device *dev,
-                         struct scsi_cmnd *cmd)
+static int atapi_sense_complete(struct ata_queued_cmd *qc,unsigned int err_mask)
 {
-        DECLARE_COMPLETION(wait);
-        struct ata_queued_cmd *qc;
-        unsigned long flags;
-        int rc;
+        if (err_mask && ((err_mask & AC_ERR_DEV) == 0))
+                /* FIXME: not quite right; we don't want the
+                 * translation of taskfile registers into
+                 * a sense descriptors, since that's only
+                 * correct for ATA, not ATAPI
+                 */
+                ata_gen_ata_desc_sense(qc);
 
-        DPRINTK("ATAPI request sense\n");
+        qc->scsidone(qc->scsicmd);
+        return 0;
+}
 
-        qc = ata_qc_new_init(ap, dev);
-        BUG_ON(qc == NULL);
+/* is it pointless to prefer PIO for "safety reasons"? */
+static inline int ata_pio_use_silly(struct ata_port *ap)
+{
+        return (ap->flags & ATA_FLAG_PIO_DMA);
+}
+
+static void atapi_request_sense(struct ata_queued_cmd *qc)
+{
+        struct ata_port *ap = qc->ap;
+        struct scsi_cmnd *cmd = qc->scsicmd;
+
+        DPRINTK("ATAPI request sense\n");
 
         /* FIXME: is this needed? */
         memset(cmd->sense_buffer, 0, sizeof(cmd->sense_buffer));
 
+        ap->ops->tf_read(ap, &qc->tf);
+
+        /* fill these in, for the case where they are -not- overwritten */
+        cmd->sense_buffer[0] = 0x70;
+        cmd->sense_buffer[2] = qc->tf.feature >> 4;
+
+        ata_qc_reinit(qc);
+
         ata_sg_init_one(qc, cmd->sense_buffer, sizeof(cmd->sense_buffer));
         qc->dma_dir = DMA_FROM_DEVICE;
 
@@ -1981,22 +2003,20 @@ void atapi_request_sense(struct ata_port *ap, struct ata_device *dev,
         qc->tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
         qc->tf.command = ATA_CMD_PACKET;
 
-        qc->tf.protocol = ATA_PROT_ATAPI;
-        qc->tf.lbam = (8 * 1024) & 0xff;
-        qc->tf.lbah = (8 * 1024) >> 8;
+        if (ata_pio_use_silly(ap)) {
+                qc->tf.protocol = ATA_PROT_ATAPI_DMA;
+                qc->tf.feature |= ATAPI_PKT_DMA;
+        } else {
+                qc->tf.protocol = ATA_PROT_ATAPI;
+                qc->tf.lbam = (8 * 1024) & 0xff;
+                qc->tf.lbah = (8 * 1024) >> 8;
+        }
         qc->nbytes = SCSI_SENSE_BUFFERSIZE;
 
-        qc->waiting = &wait;
-        qc->complete_fn = ata_qc_complete_noop;
-
-        spin_lock_irqsave(&ap->host_set->lock, flags);
-        rc = ata_qc_issue(qc);
-        spin_unlock_irqrestore(&ap->host_set->lock, flags);
+        qc->complete_fn = atapi_sense_complete;
 
-        if (rc)
-                ata_port_disable(ap);
-        else
-                wait_for_completion(&wait);
+        if (ata_qc_issue(qc))
+                ata_qc_complete(qc, AC_ERR_OTHER);
 
         DPRINTK("EXIT\n");
 }
@@ -2008,19 +2028,8 @@ static int atapi_qc_complete(struct ata_queued_cmd *qc, unsigned int err_mask)
         VPRINTK("ENTER, err_mask 0x%X\n", err_mask);
 
         if (unlikely(err_mask & AC_ERR_DEV)) {
-                DPRINTK("request check condition\n");
-
-                /* FIXME: command completion with check condition
-                 * but no sense causes the error handler to run,
-                 * which then issues REQUEST SENSE, fills in the sense 
-                 * buffer, and completes the command (for the second
-                 * time).  We need to issue REQUEST SENSE some other
-                 * way, to avoid completing the command twice.
-                 */
                 cmd->result = SAM_STAT_CHECK_CONDITION;
-
-                qc->scsidone(cmd);
-
+                atapi_request_sense(qc);
                 return 1;
         }
 
@@ -2276,6 +2285,12 @@ ata_scsi_pass_thru(struct ata_queued_cmd *qc, const u8 *scsicmd)
                 tf->device = scsicmd[8];
                 tf->command = scsicmd[9];
         }
+        /*
+         * If slave is possible, enforce correct master/slave bit
+        */
+        if (qc->ap->flags & ATA_FLAG_SLAVE_POSS)
+                tf->device = qc->dev->devno ?
+                        tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;
 
         /*
          * Filter SET_FEATURES - XFER MODE command -- otherwise,
diff --git a/drivers/scsi/libata.h b/drivers/scsi/libata.h
index fad051ca4672..8ebaa694d18e 100644
--- a/drivers/scsi/libata.h
+++ b/drivers/scsi/libata.h
@@ -29,7 +29,7 @@
 #define __LIBATA_H__
 
 #define DRV_NAME        "libata"
-#define DRV_VERSION     "1.12"  /* must be exactly four chars */
+#define DRV_VERSION     "1.20"  /* must be exactly four chars */
 
 struct ata_scsi_args {
         u16                     *id;
@@ -54,8 +54,6 @@ extern int ata_cmd_ioctl(struct scsi_device *scsidev, void __user *arg);
 
 
 /* libata-scsi.c */
-extern void atapi_request_sense(struct ata_port *ap, struct ata_device *dev,
-                         struct scsi_cmnd *cmd);
 extern void ata_scsi_scan_host(struct ata_port *ap);
 extern int ata_scsi_error(struct Scsi_Host *host);
 extern unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf,
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index 257c128f4aaa..ac184e60797e 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -1,7 +1,7 @@
 /*
  * sata_mv.c - Marvell SATA support
  *
- * Copyright 2005: EMC Corporation, all rights reserved. 
+ * Copyright 2005: EMC Corporation, all rights reserved.
  *
  * Please ALWAYS copy linux-ide@vger.kernel.org on emails.
  *
@@ -50,6 +50,9 @@ enum {
         MV_PCI_REG_BASE         = 0,
         MV_IRQ_COAL_REG_BASE    = 0x18000,      /* 6xxx part only */
         MV_SATAHC0_REG_BASE     = 0x20000,
+        MV_FLASH_CTL            = 0x1046c,
+        MV_GPIO_PORT_CTL        = 0x104f0,
+        MV_RESET_CFG            = 0x180d8,
 
         MV_PCI_REG_SZ           = MV_MAJOR_REG_AREA_SZ,
         MV_SATAHC_REG_SZ        = MV_MAJOR_REG_AREA_SZ,
@@ -72,11 +75,6 @@ enum {
         MV_SG_TBL_SZ            = (16 * MV_MAX_SG_CT),
         MV_PORT_PRIV_DMA_SZ     = (MV_CRQB_Q_SZ + MV_CRPB_Q_SZ + MV_SG_TBL_SZ),
 
-        /* Our DMA boundary is determined by an ePRD being unable to handle
-         * anything larger than 64KB
-         */
-        MV_DMA_BOUNDARY         = 0xffffU,
-
         MV_PORTS_PER_HC         = 4,
         /* == (port / MV_PORTS_PER_HC) to determine HC from 0-7 port */
         MV_PORT_HC_SHIFT        = 2,
@@ -86,16 +84,9 @@ enum {
         /* Host Flags */
         MV_FLAG_DUAL_HC         = (1 << 30),  /* two SATA Host Controllers */
         MV_FLAG_IRQ_COALESCE    = (1 << 29),  /* IRQ coalescing capability */
-        MV_FLAG_GLBL_SFT_RST    = (1 << 28),  /* Global Soft Reset support */
         MV_COMMON_FLAGS         = (ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
                                    ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO),
-        MV_6XXX_FLAGS           = (MV_FLAG_IRQ_COALESCE | 
-                                   MV_FLAG_GLBL_SFT_RST),
-
-        chip_504x               = 0,
-        chip_508x               = 1,
-        chip_604x               = 2,
-        chip_608x               = 3,
+        MV_6XXX_FLAGS           = MV_FLAG_IRQ_COALESCE,
 
         CRQB_FLAG_READ          = (1 << 0),
         CRQB_TAG_SHIFT          = 1,
@@ -116,8 +107,19 @@ enum {
         PCI_MASTER_EMPTY        = (1 << 3),
         GLOB_SFT_RST            = (1 << 4),
 
-        PCI_IRQ_CAUSE_OFS       = 0x1d58,
-        PCI_IRQ_MASK_OFS        = 0x1d5c,
+        MV_PCI_MODE             = 0xd00,
+        MV_PCI_EXP_ROM_BAR_CTL  = 0xd2c,
+        MV_PCI_DISC_TIMER       = 0xd04,
+        MV_PCI_MSI_TRIGGER      = 0xc38,
+        MV_PCI_SERR_MASK        = 0xc28,
+        MV_PCI_XBAR_TMOUT       = 0x1d04,
+        MV_PCI_ERR_LOW_ADDRESS  = 0x1d40,
+        MV_PCI_ERR_HIGH_ADDRESS = 0x1d44,
+        MV_PCI_ERR_ATTRIBUTE    = 0x1d48,
+        MV_PCI_ERR_COMMAND      = 0x1d50,
+
+        PCI_IRQ_CAUSE_OFS               = 0x1d58,
+        PCI_IRQ_MASK_OFS                = 0x1d5c,
         PCI_UNMASK_ALL_IRQS     = 0x7fffff,     /* bits 22-0 */
 
         HC_MAIN_IRQ_CAUSE_OFS   = 0x1d60,
@@ -134,7 +136,7 @@ enum {
         SELF_INT                = (1 << 23),
         TWSI_INT                = (1 << 24),
         HC_MAIN_RSVD            = (0x7f << 25), /* bits 31-25 */
-        HC_MAIN_MASKED_IRQS     = (TRAN_LO_DONE | TRAN_HI_DONE | 
+        HC_MAIN_MASKED_IRQS     = (TRAN_LO_DONE | TRAN_HI_DONE |
                                    PORTS_0_7_COAL_DONE | GPIO_INT | TWSI_INT |
                                    HC_MAIN_RSVD),
 
@@ -153,6 +155,15 @@ enum {
         /* SATA registers */
         SATA_STATUS_OFS         = 0x300,  /* ctrl, err regs follow status */
         SATA_ACTIVE_OFS         = 0x350,
+        PHY_MODE3               = 0x310,
+        PHY_MODE4               = 0x314,
+        PHY_MODE2               = 0x330,
+        MV5_PHY_MODE            = 0x74,
+        MV5_LT_MODE             = 0x30,
+        MV5_PHY_CTL             = 0x0C,
+        SATA_INTERFACE_CTL      = 0x050,
+
+        MV_M2_PREAMP_MASK       = 0x7e0,
 
         /* Port registers */
         EDMA_CFG_OFS            = 0,
@@ -182,17 +193,16 @@ enum {
         EDMA_ERR_LNK_CTRL_TX    = (0x1f << 21),
         EDMA_ERR_LNK_DATA_TX    = (0x1f << 26),
         EDMA_ERR_TRANS_PROTO    = (1 << 31),
-        EDMA_ERR_FATAL          = (EDMA_ERR_D_PAR | EDMA_ERR_PRD_PAR | 
+        EDMA_ERR_FATAL          = (EDMA_ERR_D_PAR | EDMA_ERR_PRD_PAR |
                                    EDMA_ERR_DEV_DCON | EDMA_ERR_CRBQ_PAR |
                                    EDMA_ERR_CRPB_PAR | EDMA_ERR_INTRL_PAR |
-                                   EDMA_ERR_IORDY | EDMA_ERR_LNK_CTRL_RX_2 | 
+                                   EDMA_ERR_IORDY | EDMA_ERR_LNK_CTRL_RX_2 |
                                    EDMA_ERR_LNK_DATA_RX |
-                                   EDMA_ERR_LNK_DATA_TX | 
+                                   EDMA_ERR_LNK_DATA_TX |
                                    EDMA_ERR_TRANS_PROTO),
 
         EDMA_REQ_Q_BASE_HI_OFS  = 0x10,
         EDMA_REQ_Q_IN_PTR_OFS   = 0x14,         /* also contains BASE_LO */
-        EDMA_REQ_Q_BASE_LO_MASK = 0xfffffc00U,
 
         EDMA_REQ_Q_OUT_PTR_OFS  = 0x18,
         EDMA_REQ_Q_PTR_SHIFT    = 5,
@@ -200,7 +210,6 @@ enum {
         EDMA_RSP_Q_BASE_HI_OFS  = 0x1c,
         EDMA_RSP_Q_IN_PTR_OFS   = 0x20,
         EDMA_RSP_Q_OUT_PTR_OFS  = 0x24,         /* also contains BASE_LO */
-        EDMA_RSP_Q_BASE_LO_MASK = 0xffffff00U,
         EDMA_RSP_Q_PTR_SHIFT    = 3,
 
         EDMA_CMD_OFS            = 0x28,
@@ -208,14 +217,44 @@ enum {
         EDMA_DS                 = (1 << 1),
         ATA_RST                 = (1 << 2),
 
+        EDMA_IORDY_TMOUT        = 0x34,
+        EDMA_ARB_CFG            = 0x38,
+
         /* Host private flags (hp_flags) */
         MV_HP_FLAG_MSI          = (1 << 0),
+        MV_HP_ERRATA_50XXB0     = (1 << 1),
+        MV_HP_ERRATA_50XXB2     = (1 << 2),
+        MV_HP_ERRATA_60X1B2     = (1 << 3),
+        MV_HP_ERRATA_60X1C0     = (1 << 4),
+        MV_HP_50XX              = (1 << 5),
 
         /* Port private flags (pp_flags) */
         MV_PP_FLAG_EDMA_EN      = (1 << 0),
         MV_PP_FLAG_EDMA_DS_ACT  = (1 << 1),
 };
 
+#define IS_50XX(hpriv) ((hpriv)->hp_flags & MV_HP_50XX)
+#define IS_60XX(hpriv) (((hpriv)->hp_flags & MV_HP_50XX) == 0)
+
+enum {
+        /* Our DMA boundary is determined by an ePRD being unable to handle
+         * anything larger than 64KB
+         */
+        MV_DMA_BOUNDARY         = 0xffffU,
+
+        EDMA_REQ_Q_BASE_LO_MASK = 0xfffffc00U,
+
+        EDMA_RSP_Q_BASE_LO_MASK = 0xffffff00U,
+};
+
+enum chip_type {
+        chip_504x,
+        chip_508x,
+        chip_5080,
+        chip_604x,
+        chip_608x,
+};
+
 /* Command ReQuest Block: 32B */
 struct mv_crqb {
         u32                     sg_addr;
@@ -252,14 +291,37 @@ struct mv_port_priv {
         u32                     pp_flags;
 };
 
+struct mv_port_signal {
+        u32                     amps;
+        u32                     pre;
+};
+
+struct mv_host_priv;
+struct mv_hw_ops {
+        void (*phy_errata)(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+        void (*enable_leds)(struct mv_host_priv *hpriv, void __iomem *mmio);
+        void (*read_preamp)(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+        int (*reset_hc)(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+        void (*reset_flash)(struct mv_host_priv *hpriv, void __iomem *mmio);
+        void (*reset_bus)(struct pci_dev *pdev, void __iomem *mmio);
+};
+
 struct mv_host_priv {
         u32                     hp_flags;
+        struct mv_port_signal   signal[8];
+        const struct mv_hw_ops  *ops;
 };
 
 static void mv_irq_clear(struct ata_port *ap);
 static u32 mv_scr_read(struct ata_port *ap, unsigned int sc_reg_in);
 static void mv_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val);
+static u32 mv5_scr_read(struct ata_port *ap, unsigned int sc_reg_in);
+static void mv5_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val);
 static void mv_phy_reset(struct ata_port *ap);
+static void __mv_phy_reset(struct ata_port *ap, int can_sleep);
 static void mv_host_stop(struct ata_host_set *host_set);
 static int mv_port_start(struct ata_port *ap);
 static void mv_port_stop(struct ata_port *ap);
@@ -270,6 +332,29 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
 static void mv_eng_timeout(struct ata_port *ap);
 static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
 
+static void mv5_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv5_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+static int mv5_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+static void mv5_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv5_reset_bus(struct pci_dev *pdev, void __iomem *mmio);
+
+static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+static void mv6_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv6_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+static int mv6_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv_reset_pci_bus(struct pci_dev *pdev, void __iomem *mmio);
+static void mv_channel_reset(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port_no);
+static void mv_stop_and_reset(struct ata_port *ap);
+
 static struct scsi_host_template mv_sht = {
         .module                 = THIS_MODULE,
         .name                   = DRV_NAME,
@@ -278,7 +363,7 @@ static struct scsi_host_template mv_sht = {
         .eh_strategy_handler    = ata_scsi_error,
         .can_queue              = MV_USE_Q_DEPTH,
         .this_id                = ATA_SHT_THIS_ID,
-        .sg_tablesize           = MV_MAX_SG_CT,
+        .sg_tablesize           = MV_MAX_SG_CT / 2,
         .max_sectors            = ATA_MAX_SECTORS,
         .cmd_per_lun            = ATA_SHT_CMD_PER_LUN,
         .emulated               = ATA_SHT_EMULATED,
@@ -290,7 +375,34 @@ static struct scsi_host_template mv_sht = {
         .ordered_flush          = 1,
 };
 
-static const struct ata_port_operations mv_ops = {
+static const struct ata_port_operations mv5_ops = {
+        .port_disable           = ata_port_disable,
+
+        .tf_load                = ata_tf_load,
+        .tf_read                = ata_tf_read,
+        .check_status           = ata_check_status,
+        .exec_command           = ata_exec_command,
+        .dev_select             = ata_std_dev_select,
+
+        .phy_reset              = mv_phy_reset,
+
+        .qc_prep                = mv_qc_prep,
+        .qc_issue               = mv_qc_issue,
+
+        .eng_timeout            = mv_eng_timeout,
+
+        .irq_handler            = mv_interrupt,
+        .irq_clear              = mv_irq_clear,
+
+        .scr_read               = mv5_scr_read,
+        .scr_write              = mv5_scr_write,
+
+        .port_start             = mv_port_start,
+        .port_stop              = mv_port_stop,
+        .host_stop              = mv_host_stop,
+};
+
+static const struct ata_port_operations mv6_ops = {
         .port_disable           = ata_port_disable,
 
         .tf_load                = ata_tf_load,
@@ -322,37 +434,44 @@ static struct ata_port_info mv_port_info[] = {
                 .sht            = &mv_sht,
                 .host_flags     = MV_COMMON_FLAGS,
                 .pio_mask       = 0x1f, /* pio0-4 */
-                .udma_mask      = 0,    /* 0x7f (udma0-6 disabled for now) */
-                .port_ops       = &mv_ops,
+                .udma_mask      = 0x7f, /* udma0-6 */
+                .port_ops       = &mv5_ops,
         },
         {  /* chip_508x */
                 .sht            = &mv_sht,
                 .host_flags     = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC),
                 .pio_mask       = 0x1f, /* pio0-4 */
-                .udma_mask      = 0,    /* 0x7f (udma0-6 disabled for now) */
-                .port_ops       = &mv_ops,
+                .udma_mask      = 0x7f, /* udma0-6 */
+                .port_ops       = &mv5_ops,
+        },
+        {  /* chip_5080 */
+                .sht            = &mv_sht,
+                .host_flags     = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC),
+                .pio_mask       = 0x1f, /* pio0-4 */
+                .udma_mask      = 0x7f, /* udma0-6 */
+                .port_ops       = &mv5_ops,
         },
         {  /* chip_604x */
                 .sht            = &mv_sht,
                 .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS),
                 .pio_mask       = 0x1f, /* pio0-4 */
                 .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv6_ops,
         },
         {  /* chip_608x */
                 .sht            = &mv_sht,
-                .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS | 
+                .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS |
                                    MV_FLAG_DUAL_HC),
                 .pio_mask       = 0x1f, /* pio0-4 */
                 .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv6_ops,
         },
 };
 
 static const struct pci_device_id mv_pci_tbl[] = {
         {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5040), 0, 0, chip_504x},
         {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5041), 0, 0, chip_504x},
-        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5080), 0, 0, chip_508x},
+        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5080), 0, 0, chip_5080},
         {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5081), 0, 0, chip_508x},
 
         {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x6040), 0, 0, chip_604x},
@@ -371,6 +490,24 @@ static struct pci_driver mv_pci_driver = {
         .remove                 = ata_pci_remove_one,
 };
 
+static const struct mv_hw_ops mv5xxx_ops = {
+        .phy_errata             = mv5_phy_errata,
+        .enable_leds            = mv5_enable_leds,
+        .read_preamp            = mv5_read_preamp,
+        .reset_hc               = mv5_reset_hc,
+        .reset_flash            = mv5_reset_flash,
+        .reset_bus              = mv5_reset_bus,
+};
+
+static const struct mv_hw_ops mv6xxx_ops = {
+        .phy_errata             = mv6_phy_errata,
+        .enable_leds            = mv6_enable_leds,
+        .read_preamp            = mv6_read_preamp,
+        .reset_hc               = mv6_reset_hc,
+        .reset_flash            = mv6_reset_flash,
+        .reset_bus              = mv_reset_pci_bus,
+};
+
 /*
  * Functions
  */
@@ -386,11 +523,27 @@ static inline void __iomem *mv_hc_base(void __iomem *base, unsigned int hc)
         return (base + MV_SATAHC0_REG_BASE + (hc * MV_SATAHC_REG_SZ));
 }
 
+static inline unsigned int mv_hc_from_port(unsigned int port)
+{
+        return port >> MV_PORT_HC_SHIFT;
+}
+
+static inline unsigned int mv_hardport_from_port(unsigned int port)
+{
+        return port & MV_PORT_MASK;
+}
+
+static inline void __iomem *mv_hc_base_from_port(void __iomem *base,
+                                                 unsigned int port)
+{
+        return mv_hc_base(base, mv_hc_from_port(port));
+}
+
 static inline void __iomem *mv_port_base(void __iomem *base, unsigned int port)
 {
-        return (mv_hc_base(base, port >> MV_PORT_HC_SHIFT) +
-                MV_SATAHC_ARBTR_REG_SZ + 
-                ((port & MV_PORT_MASK) * MV_PORT_REG_SZ));
+        return  mv_hc_base_from_port(base, port) +
+                MV_SATAHC_ARBTR_REG_SZ +
+                (mv_hardport_from_port(port) * MV_PORT_REG_SZ);
 }
 
 static inline void __iomem *mv_ap_base(struct ata_port *ap)
@@ -398,9 +551,9 @@ static inline void __iomem *mv_ap_base(struct ata_port *ap)
         return mv_port_base(ap->host_set->mmio_base, ap->port_no);
 }
 
-static inline int mv_get_hc_count(unsigned long hp_flags)
+static inline int mv_get_hc_count(unsigned long host_flags)
 {
-        return ((hp_flags & MV_FLAG_DUAL_HC) ? 2 : 1);
+        return ((host_flags & MV_FLAG_DUAL_HC) ? 2 : 1);
 }
 
 static void mv_irq_clear(struct ata_port *ap)
@@ -452,7 +605,7 @@ static void mv_stop_dma(struct ata_port *ap)
         } else {
                 assert(!(EDMA_EN & readl(port_mmio + EDMA_CMD_OFS)));
         }
-        
+
         /* now properly wait for the eDMA to stop */
         for (i = 1000; i > 0; i--) {
                 reg = readl(port_mmio + EDMA_CMD_OFS);
@@ -503,7 +656,7 @@ static void mv_dump_all_regs(void __iomem *mmio_base, int port,
                              struct pci_dev *pdev)
 {
 #ifdef ATA_DEBUG
-        void __iomem *hc_base = mv_hc_base(mmio_base, 
+        void __iomem *hc_base = mv_hc_base(mmio_base,
                                            port >> MV_PORT_HC_SHIFT);
         void __iomem *port_base;
         int start_port, num_ports, p, start_hc, num_hcs, hc;
@@ -517,7 +670,7 @@ static void mv_dump_all_regs(void __iomem *mmio_base, int port,
                 start_port = port;
                 num_ports = num_hcs = 1;
         }
-        DPRINTK("All registers for port(s) %u-%u:\n", start_port, 
+        DPRINTK("All registers for port(s) %u-%u:\n", start_port,
                 num_ports > 1 ? num_ports - 1 : start_port);
 
         if (NULL != pdev) {
@@ -585,70 +738,6 @@ static void mv_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val)
 }
 
 /**
- *      mv_global_soft_reset - Perform the 6xxx global soft reset
- *      @mmio_base: base address of the HBA
- *
- *      This routine only applies to 6xxx parts.
- *
- *      LOCKING:
- *      Inherited from caller.
- */
-static int mv_global_soft_reset(void __iomem *mmio_base)
-{
-        void __iomem *reg = mmio_base + PCI_MAIN_CMD_STS_OFS;
-        int i, rc = 0;
-        u32 t;
-
-        /* Following procedure defined in PCI "main command and status
-         * register" table.
-         */
-        t = readl(reg);
-        writel(t | STOP_PCI_MASTER, reg);
-
-        for (i = 0; i < 1000; i++) {
-                udelay(1);
-                t = readl(reg);
-                if (PCI_MASTER_EMPTY & t) {
-                        break;
-                }
-        }
-        if (!(PCI_MASTER_EMPTY & t)) {
-                printk(KERN_ERR DRV_NAME ": PCI master won't flush\n");
-                rc = 1;
-                goto done;
-        }
-
-        /* set reset */
-        i = 5;
-        do {
-                writel(t | GLOB_SFT_RST, reg);
-                t = readl(reg);
-                udelay(1);
-        } while (!(GLOB_SFT_RST & t) && (i-- > 0));
-
-        if (!(GLOB_SFT_RST & t)) {
-                printk(KERN_ERR DRV_NAME ": can't set global reset\n");
-                rc = 1;
-                goto done;
-        }
-
-        /* clear reset and *reenable the PCI master* (not mentioned in spec) */
-        i = 5;
-        do {
-                writel(t & ~(GLOB_SFT_RST | STOP_PCI_MASTER), reg);
-                t = readl(reg);
-                udelay(1);
-        } while ((GLOB_SFT_RST & t) && (i-- > 0));
-
-        if (GLOB_SFT_RST & t) {
-                printk(KERN_ERR DRV_NAME ": can't clear global reset\n");
-                rc = 1;
-        }
-done:
-        return rc;
-}
-
-/**
  *      mv_host_stop - Host specific cleanup/stop routine.
  *      @host_set: host data structure
  *
@@ -701,7 +790,7 @@ static int mv_port_start(struct ata_port *ap)
                 goto err_out;
         memset(pp, 0, sizeof(*pp));
 
-        mem = dma_alloc_coherent(dev, MV_PORT_PRIV_DMA_SZ, &mem_dma, 
+        mem = dma_alloc_coherent(dev, MV_PORT_PRIV_DMA_SZ, &mem_dma,
                                  GFP_KERNEL);
         if (!mem)
                 goto err_out_pp;
@@ -711,7 +800,7 @@ static int mv_port_start(struct ata_port *ap)
         if (rc)
                 goto err_out_priv;
 
-        /* First item in chunk of DMA memory: 
+        /* First item in chunk of DMA memory:
          * 32-slot command request table (CRQB), 32 bytes each in size
          */
         pp->crqb = mem;
@@ -719,7 +808,7 @@ static int mv_port_start(struct ata_port *ap)
         mem += MV_CRQB_Q_SZ;
         mem_dma += MV_CRQB_Q_SZ;
 
-        /* Second item: 
+        /* Second item:
          * 32-slot command response table (CRPB), 8 bytes each in size
          */
         pp->crpb = mem;
@@ -733,18 +822,18 @@ static int mv_port_start(struct ata_port *ap)
         pp->sg_tbl = mem;
         pp->sg_tbl_dma = mem_dma;
 
-        writelfl(EDMA_CFG_Q_DEPTH | EDMA_CFG_RD_BRST_EXT | 
+        writelfl(EDMA_CFG_Q_DEPTH | EDMA_CFG_RD_BRST_EXT |
                  EDMA_CFG_WR_BUFF_LEN, port_mmio + EDMA_CFG_OFS);
 
         writel((pp->crqb_dma >> 16) >> 16, port_mmio + EDMA_REQ_Q_BASE_HI_OFS);
-        writelfl(pp->crqb_dma & EDMA_REQ_Q_BASE_LO_MASK, 
+        writelfl(pp->crqb_dma & EDMA_REQ_Q_BASE_LO_MASK,
                  port_mmio + EDMA_REQ_Q_IN_PTR_OFS);
 
         writelfl(0, port_mmio + EDMA_REQ_Q_OUT_PTR_OFS);
         writelfl(0, port_mmio + EDMA_RSP_Q_IN_PTR_OFS);
 
         writel((pp->crpb_dma >> 16) >> 16, port_mmio + EDMA_RSP_Q_BASE_HI_OFS);
-        writelfl(pp->crpb_dma & EDMA_RSP_Q_BASE_LO_MASK, 
+        writelfl(pp->crpb_dma & EDMA_RSP_Q_BASE_LO_MASK,
                  port_mmio + EDMA_RSP_Q_OUT_PTR_OFS);
 
         pp->req_producer = pp->rsp_consumer = 0;
@@ -805,20 +894,30 @@ static void mv_fill_sg(struct ata_queued_cmd *qc)
         struct scatterlist *sg;
 
         ata_for_each_sg(sg, qc) {
-                u32 sg_len;
                 dma_addr_t addr;
+                u32 sg_len, len, offset;
 
                 addr = sg_dma_address(sg);
                 sg_len = sg_dma_len(sg);
 
-                pp->sg_tbl[i].addr = cpu_to_le32(addr & 0xffffffff);
-                pp->sg_tbl[i].addr_hi = cpu_to_le32((addr >> 16) >> 16);
-                assert(0 == (sg_len & ~MV_DMA_BOUNDARY));
-                pp->sg_tbl[i].flags_size = cpu_to_le32(sg_len);
-                if (ata_sg_is_last(sg, qc))
-                        pp->sg_tbl[i].flags_size |= cpu_to_le32(EPRD_FLAG_END_OF_TBL);
+                while (sg_len) {
+                        offset = addr & MV_DMA_BOUNDARY;
+                        len = sg_len;
+                        if ((offset + sg_len) > 0x10000)
+                                len = 0x10000 - offset;
+
+                        pp->sg_tbl[i].addr = cpu_to_le32(addr & 0xffffffff);
+                        pp->sg_tbl[i].addr_hi = cpu_to_le32((addr >> 16) >> 16);
+                        pp->sg_tbl[i].flags_size = cpu_to_le32(len);
+
+                        sg_len -= len;
+                        addr += len;
+
+                        if (!sg_len && ata_sg_is_last(sg, qc))
+                                pp->sg_tbl[i].flags_size |= cpu_to_le32(EPRD_FLAG_END_OF_TBL);
 
-                i++;
+                        i++;
+                }
         }
 }
 
@@ -859,7 +958,7 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
         }
 
         /* the req producer index should be the same as we remember it */
-        assert(((readl(mv_ap_base(qc->ap) + EDMA_REQ_Q_IN_PTR_OFS) >> 
+        assert(((readl(mv_ap_base(qc->ap) + EDMA_REQ_Q_IN_PTR_OFS) >>
                  EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
                pp->req_producer);
 
@@ -871,9 +970,9 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
         assert(MV_MAX_Q_DEPTH > qc->tag);
         flags |= qc->tag << CRQB_TAG_SHIFT;
 
-        pp->crqb[pp->req_producer].sg_addr = 
+        pp->crqb[pp->req_producer].sg_addr =
                 cpu_to_le32(pp->sg_tbl_dma & 0xffffffff);
-        pp->crqb[pp->req_producer].sg_addr_hi = 
+        pp->crqb[pp->req_producer].sg_addr_hi =
                 cpu_to_le32((pp->sg_tbl_dma >> 16) >> 16);
         pp->crqb[pp->req_producer].ctrl_flags = cpu_to_le16(flags);
 
@@ -896,7 +995,7 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
 #ifdef LIBATA_NCQ               /* FIXME: remove this line when NCQ added */
         case ATA_CMD_FPDMA_READ:
         case ATA_CMD_FPDMA_WRITE:
-                mv_crqb_pack_cmd(cw++, tf->hob_feature, ATA_REG_FEATURE, 0); 
+                mv_crqb_pack_cmd(cw++, tf->hob_feature, ATA_REG_FEATURE, 0);
                 mv_crqb_pack_cmd(cw++, tf->feature, ATA_REG_FEATURE, 0);
                 break;
 #endif                          /* FIXME: remove this line when NCQ added */
@@ -962,7 +1061,7 @@ static int mv_qc_issue(struct ata_queued_cmd *qc)
                pp->req_producer);
         /* until we do queuing, the queue should be empty at this point */
         assert(((in_ptr >> EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
-               ((readl(port_mmio + EDMA_REQ_Q_OUT_PTR_OFS) >> 
+               ((readl(port_mmio + EDMA_REQ_Q_OUT_PTR_OFS) >>
                  EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK));
 
         mv_inc_q_index(&pp->req_producer);      /* now incr producer index */
@@ -999,15 +1098,15 @@ static u8 mv_get_crpb_status(struct ata_port *ap)
         out_ptr = readl(port_mmio + EDMA_RSP_Q_OUT_PTR_OFS);
 
         /* the response consumer index should be the same as we remember it */
-        assert(((out_ptr >> EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) == 
+        assert(((out_ptr >> EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
                pp->rsp_consumer);
 
         /* increment our consumer index... */
         pp->rsp_consumer = mv_inc_q_index(&pp->rsp_consumer);
-        
+
         /* and, until we do NCQ, there should only be 1 CRPB waiting */
-        assert(((readl(port_mmio + EDMA_RSP_Q_IN_PTR_OFS) >> 
-                 EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) == 
+        assert(((readl(port_mmio + EDMA_RSP_Q_IN_PTR_OFS) >>
+                 EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
                pp->rsp_consumer);
 
         /* write out our inc'd consumer index so EDMA knows we're caught up */
@@ -1055,7 +1154,7 @@ static void mv_err_intr(struct ata_port *ap)
 
         /* check for fatal here and recover if needed */
         if (EDMA_ERR_FATAL & edma_err_cause) {
-                mv_phy_reset(ap);
+                mv_stop_and_reset(ap);
         }
 }
 
@@ -1120,6 +1219,10 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
                         handled++;
                 }
 
+                if (ap &&
+                    (ap->flags & (ATA_FLAG_PORT_DISABLED | ATA_FLAG_NOINTR)))
+                        continue;
+
                 err_mask = ac_err_mask(ata_status);
 
                 shift = port << 1;              /* (port * 2) */
@@ -1131,14 +1234,15 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
                         err_mask |= AC_ERR_OTHER;
                         handled++;
                 }
-                
+
                 if (handled && ap) {
                         qc = ata_qc_from_tag(ap, ap->active_tag);
                         if (NULL != qc) {
                                 VPRINTK("port %u IRQ found for qc, "
                                         "ata_status 0x%x\n", port,ata_status);
                                 /* mark qc status appropriately */
-                                ata_qc_complete(qc, err_mask);
+                                if (!(qc->tf.ctl & ATA_NIEN))
+                                        ata_qc_complete(qc, err_mask);
                         }
                 }
         }
@@ -1146,7 +1250,7 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
 }
 
 /**
- *      mv_interrupt - 
+ *      mv_interrupt -
  *      @irq: unused
  *      @dev_instance: private data; in this case the host structure
  *      @regs: unused
@@ -1156,7 +1260,7 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
  *      routine to handle.  Also check for PCI errors which are only
  *      reported here.
  *
- *      LOCKING: 
+ *      LOCKING:
  *      This routine holds the host_set lock while processing pending
  *      interrupts.
  */
@@ -1202,8 +1306,422 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
         return IRQ_RETVAL(handled);
 }
 
+static void __iomem *mv5_phy_base(void __iomem *mmio, unsigned int port)
+{
+        void __iomem *hc_mmio = mv_hc_base_from_port(mmio, port);
+        unsigned long ofs = (mv_hardport_from_port(port) + 1) * 0x100UL;
+
+        return hc_mmio + ofs;
+}
+
+static unsigned int mv5_scr_offset(unsigned int sc_reg_in)
+{
+        unsigned int ofs;
+
+        switch (sc_reg_in) {
+        case SCR_STATUS:
+        case SCR_ERROR:
+        case SCR_CONTROL:
+                ofs = sc_reg_in * sizeof(u32);
+                break;
+        default:
+                ofs = 0xffffffffU;
+                break;
+        }
+        return ofs;
+}
+
+static u32 mv5_scr_read(struct ata_port *ap, unsigned int sc_reg_in)
+{
+        void __iomem *mmio = mv5_phy_base(ap->host_set->mmio_base, ap->port_no);
+        unsigned int ofs = mv5_scr_offset(sc_reg_in);
+
+        if (ofs != 0xffffffffU)
+                return readl(mmio + ofs);
+        else
+                return (u32) ofs;
+}
+
+static void mv5_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val)
+{
+        void __iomem *mmio = mv5_phy_base(ap->host_set->mmio_base, ap->port_no);
+        unsigned int ofs = mv5_scr_offset(sc_reg_in);
+
+        if (ofs != 0xffffffffU)
+                writelfl(val, mmio + ofs);
+}
+
+static void mv5_reset_bus(struct pci_dev *pdev, void __iomem *mmio)
+{
+        u8 rev_id;
+        int early_5080;
+
+        pci_read_config_byte(pdev, PCI_REVISION_ID, &rev_id);
+
+        early_5080 = (pdev->device == 0x5080) && (rev_id == 0);
+
+        if (!early_5080) {
+                u32 tmp = readl(mmio + MV_PCI_EXP_ROM_BAR_CTL);
+                tmp |= (1 << 0);
+                writel(tmp, mmio + MV_PCI_EXP_ROM_BAR_CTL);
+        }
+
+        mv_reset_pci_bus(pdev, mmio);
+}
+
+static void mv5_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        writel(0x0fcfffff, mmio + MV_FLASH_CTL);
+}
+
+static void mv5_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio)
+{
+        void __iomem *phy_mmio = mv5_phy_base(mmio, idx);
+        u32 tmp;
+
+        tmp = readl(phy_mmio + MV5_PHY_MODE);
+
+        hpriv->signal[idx].pre = tmp & 0x1800;  /* bits 12:11 */
+        hpriv->signal[idx].amps = tmp & 0xe0;   /* bits 7:5 */
+}
+
+static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        u32 tmp;
+
+        writel(0, mmio + MV_GPIO_PORT_CTL);
+
+        /* FIXME: handle MV_HP_ERRATA_50XXB2 errata */
+
+        tmp = readl(mmio + MV_PCI_EXP_ROM_BAR_CTL);
+        tmp |= ~(1 << 0);
+        writel(tmp, mmio + MV_PCI_EXP_ROM_BAR_CTL);
+}
+
+static void mv5_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port)
+{
+        void __iomem *phy_mmio = mv5_phy_base(mmio, port);
+        const u32 mask = (1<<12) | (1<<11) | (1<<7) | (1<<6) | (1<<5);
+        u32 tmp;
+        int fix_apm_sq = (hpriv->hp_flags & MV_HP_ERRATA_50XXB0);
+
+        if (fix_apm_sq) {
+                tmp = readl(phy_mmio + MV5_LT_MODE);
+                tmp |= (1 << 19);
+                writel(tmp, phy_mmio + MV5_LT_MODE);
+
+                tmp = readl(phy_mmio + MV5_PHY_CTL);
+                tmp &= ~0x3;
+                tmp |= 0x1;
+                writel(tmp, phy_mmio + MV5_PHY_CTL);
+        }
+
+        tmp = readl(phy_mmio + MV5_PHY_MODE);
+        tmp &= ~mask;
+        tmp |= hpriv->signal[port].pre;
+        tmp |= hpriv->signal[port].amps;
+        writel(tmp, phy_mmio + MV5_PHY_MODE);
+}
+
+
+#undef ZERO
+#define ZERO(reg) writel(0, port_mmio + (reg))
+static void mv5_reset_hc_port(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port);
+
+        writelfl(EDMA_DS, port_mmio + EDMA_CMD_OFS);
+
+        mv_channel_reset(hpriv, mmio, port);
+
+        ZERO(0x028);    /* command */
+        writel(0x11f, port_mmio + EDMA_CFG_OFS);
+        ZERO(0x004);    /* timer */
+        ZERO(0x008);    /* irq err cause */
+        ZERO(0x00c);    /* irq err mask */
+        ZERO(0x010);    /* rq bah */
+        ZERO(0x014);    /* rq inp */
+        ZERO(0x018);    /* rq outp */
+        ZERO(0x01c);    /* respq bah */
+        ZERO(0x024);    /* respq outp */
+        ZERO(0x020);    /* respq inp */
+        ZERO(0x02c);    /* test control */
+        writel(0xbc, port_mmio + EDMA_IORDY_TMOUT);
+}
+#undef ZERO
+
+#define ZERO(reg) writel(0, hc_mmio + (reg))
+static void mv5_reset_one_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int hc)
+{
+        void __iomem *hc_mmio = mv_hc_base(mmio, hc);
+        u32 tmp;
+
+        ZERO(0x00c);
+        ZERO(0x010);
+        ZERO(0x014);
+        ZERO(0x018);
+
+        tmp = readl(hc_mmio + 0x20);
+        tmp &= 0x1c1c1c1c;
+        tmp |= 0x03030303;
+        writel(tmp, hc_mmio + 0x20);
+}
+#undef ZERO
+
+static int mv5_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc)
+{
+        unsigned int hc, port;
+
+        for (hc = 0; hc < n_hc; hc++) {
+                for (port = 0; port < MV_PORTS_PER_HC; port++)
+                        mv5_reset_hc_port(hpriv, mmio,
+                                          (hc * MV_PORTS_PER_HC) + port);
+
+                mv5_reset_one_hc(hpriv, mmio, hc);
+        }
+
+        return 0;
+}
+
+#undef ZERO
+#define ZERO(reg) writel(0, mmio + (reg))
+static void mv_reset_pci_bus(struct pci_dev *pdev, void __iomem *mmio)
+{
+        u32 tmp;
+
+        tmp = readl(mmio + MV_PCI_MODE);
+        tmp &= 0xff00ffff;
+        writel(tmp, mmio + MV_PCI_MODE);
+
+        ZERO(MV_PCI_DISC_TIMER);
+        ZERO(MV_PCI_MSI_TRIGGER);
+        writel(0x000100ff, mmio + MV_PCI_XBAR_TMOUT);
+        ZERO(HC_MAIN_IRQ_MASK_OFS);
+        ZERO(MV_PCI_SERR_MASK);
+        ZERO(PCI_IRQ_CAUSE_OFS);
+        ZERO(PCI_IRQ_MASK_OFS);
+        ZERO(MV_PCI_ERR_LOW_ADDRESS);
+        ZERO(MV_PCI_ERR_HIGH_ADDRESS);
+        ZERO(MV_PCI_ERR_ATTRIBUTE);
+        ZERO(MV_PCI_ERR_COMMAND);
+}
+#undef ZERO
+
+static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        u32 tmp;
+
+        mv5_reset_flash(hpriv, mmio);
+
+        tmp = readl(mmio + MV_GPIO_PORT_CTL);
+        tmp &= 0x3;
+        tmp |= (1 << 5) | (1 << 6);
+        writel(tmp, mmio + MV_GPIO_PORT_CTL);
+}
+
+/**
+ *      mv6_reset_hc - Perform the 6xxx global soft reset
+ *      @mmio: base address of the HBA
+ *
+ *      This routine only applies to 6xxx parts.
+ *
+ *      LOCKING:
+ *      Inherited from caller.
+ */
+static int mv6_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc)
+{
+        void __iomem *reg = mmio + PCI_MAIN_CMD_STS_OFS;
+        int i, rc = 0;
+        u32 t;
+
+        /* Following procedure defined in PCI "main command and status
+         * register" table.
+         */
+        t = readl(reg);
+        writel(t | STOP_PCI_MASTER, reg);
+
+        for (i = 0; i < 1000; i++) {
+                udelay(1);
+                t = readl(reg);
+                if (PCI_MASTER_EMPTY & t) {
+                        break;
+                }
+        }
+        if (!(PCI_MASTER_EMPTY & t)) {
+                printk(KERN_ERR DRV_NAME ": PCI master won't flush\n");
+                rc = 1;
+                goto done;
+        }
+
+        /* set reset */
+        i = 5;
+        do {
+                writel(t | GLOB_SFT_RST, reg);
+                t = readl(reg);
+                udelay(1);
+        } while (!(GLOB_SFT_RST & t) && (i-- > 0));
+
+        if (!(GLOB_SFT_RST & t)) {
+                printk(KERN_ERR DRV_NAME ": can't set global reset\n");
+                rc = 1;
+                goto done;
+        }
+
+        /* clear reset and *reenable the PCI master* (not mentioned in spec) */
+        i = 5;
+        do {
+                writel(t & ~(GLOB_SFT_RST | STOP_PCI_MASTER), reg);
+                t = readl(reg);
+                udelay(1);
+        } while ((GLOB_SFT_RST & t) && (i-- > 0));
+
+        if (GLOB_SFT_RST & t) {
+                printk(KERN_ERR DRV_NAME ": can't clear global reset\n");
+                rc = 1;
+        }
+done:
+        return rc;
+}
+
+static void mv6_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio)
+{
+        void __iomem *port_mmio;
+        u32 tmp;
+
+        tmp = readl(mmio + MV_RESET_CFG);
+        if ((tmp & (1 << 0)) == 0) {
+                hpriv->signal[idx].amps = 0x7 << 8;
+                hpriv->signal[idx].pre = 0x1 << 5;
+                return;
+        }
+
+        port_mmio = mv_port_base(mmio, idx);
+        tmp = readl(port_mmio + PHY_MODE2);
+
+        hpriv->signal[idx].amps = tmp & 0x700;  /* bits 10:8 */
+        hpriv->signal[idx].pre = tmp & 0xe0;    /* bits 7:5 */
+}
+
+static void mv6_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        writel(0x00000060, mmio + MV_GPIO_PORT_CTL);
+}
+
+static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port);
+
+        u32 hp_flags = hpriv->hp_flags;
+        int fix_phy_mode2 =
+                hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
+        int fix_phy_mode4 =
+                hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
+        u32 m2, tmp;
+
+        if (fix_phy_mode2) {
+                m2 = readl(port_mmio + PHY_MODE2);
+                m2 &= ~(1 << 16);
+                m2 |= (1 << 31);
+                writel(m2, port_mmio + PHY_MODE2);
+
+                udelay(200);
+
+                m2 = readl(port_mmio + PHY_MODE2);
+                m2 &= ~((1 << 16) | (1 << 31));
+                writel(m2, port_mmio + PHY_MODE2);
+
+                udelay(200);
+        }
+
+        /* who knows what this magic does */
+        tmp = readl(port_mmio + PHY_MODE3);
+        tmp &= ~0x7F800000;
+        tmp |= 0x2A800000;
+        writel(tmp, port_mmio + PHY_MODE3);
+
+        if (fix_phy_mode4) {
+                u32 m4;
+
+                m4 = readl(port_mmio + PHY_MODE4);
+
+                if (hp_flags & MV_HP_ERRATA_60X1B2)
+                        tmp = readl(port_mmio + 0x310);
+
+                m4 = (m4 & ~(1 << 1)) | (1 << 0);
+
+                writel(m4, port_mmio + PHY_MODE4);
+
+                if (hp_flags & MV_HP_ERRATA_60X1B2)
+                        writel(tmp, port_mmio + 0x310);
+        }
+
+        /* Revert values of pre-emphasis and signal amps to the saved ones */
+        m2 = readl(port_mmio + PHY_MODE2);
+
+        m2 &= ~MV_M2_PREAMP_MASK;
+        m2 |= hpriv->signal[port].amps;
+        m2 |= hpriv->signal[port].pre;
+        m2 &= ~(1 << 16);
+
+        writel(m2, port_mmio + PHY_MODE2);
+}
+
+static void mv_channel_reset(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port_no)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port_no);
+
+        writelfl(ATA_RST, port_mmio + EDMA_CMD_OFS);
+
+        if (IS_60XX(hpriv)) {
+                u32 ifctl = readl(port_mmio + SATA_INTERFACE_CTL);
+                ifctl |= (1 << 12) | (1 << 7);
+                writelfl(ifctl, port_mmio + SATA_INTERFACE_CTL);
+        }
+
+        udelay(25);             /* allow reset propagation */
+
+        /* Spec never mentions clearing the bit.  Marvell's driver does
+         * clear the bit, however.
+         */
+        writelfl(0, port_mmio + EDMA_CMD_OFS);
+
+        hpriv->ops->phy_errata(hpriv, mmio, port_no);
+
+        if (IS_50XX(hpriv))
+                mdelay(1);
+}
+
+static void mv_stop_and_reset(struct ata_port *ap)
+{
+        struct mv_host_priv *hpriv = ap->host_set->private_data;
+        void __iomem *mmio = ap->host_set->mmio_base;
+
+        mv_stop_dma(ap);
+
+        mv_channel_reset(hpriv, mmio, ap->port_no);
+
+        __mv_phy_reset(ap, 0);
+}
+
+static inline void __msleep(unsigned int msec, int can_sleep)
+{
+        if (can_sleep)
+                msleep(msec);
+        else
+                mdelay(msec);
+}
+
 /**
- *      mv_phy_reset - Perform eDMA reset followed by COMRESET
+ *      __mv_phy_reset - Perform eDMA reset followed by COMRESET
  *      @ap: ATA channel to manipulate
  *
  *      Part of this is taken from __sata_phy_reset and modified to
@@ -1213,41 +1731,47 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
  *      Inherited from caller.  This is coded to safe to call at
  *      interrupt level, i.e. it does not sleep.
  */
-static void mv_phy_reset(struct ata_port *ap)
+static void __mv_phy_reset(struct ata_port *ap, int can_sleep)
 {
+        struct mv_port_priv *pp = ap->private_data;
+        struct mv_host_priv *hpriv = ap->host_set->private_data;
         void __iomem *port_mmio = mv_ap_base(ap);
         struct ata_taskfile tf;
         struct ata_device *dev = &ap->device[0];
         unsigned long timeout;
+        int retry = 5;
+        u32 sstatus;
 
         VPRINTK("ENTER, port %u, mmio 0x%p\n", ap->port_no, port_mmio);
 
-        mv_stop_dma(ap);
-
-        writelfl(ATA_RST, port_mmio + EDMA_CMD_OFS);
-        udelay(25);             /* allow reset propagation */
-
-        /* Spec never mentions clearing the bit.  Marvell's driver does
-         * clear the bit, however.
-         */
-        writelfl(0, port_mmio + EDMA_CMD_OFS);
-
-        VPRINTK("S-regs after ATA_RST: SStat 0x%08x SErr 0x%08x "
+        DPRINTK("S-regs after ATA_RST: SStat 0x%08x SErr 0x%08x "
                 "SCtrl 0x%08x\n", mv_scr_read(ap, SCR_STATUS),
                 mv_scr_read(ap, SCR_ERROR), mv_scr_read(ap, SCR_CONTROL));
 
-        /* proceed to init communications via the scr_control reg */
+        /* Issue COMRESET via SControl */
+comreset_retry:
         scr_write_flush(ap, SCR_CONTROL, 0x301);
-        mdelay(1);
+        __msleep(1, can_sleep);
+
         scr_write_flush(ap, SCR_CONTROL, 0x300);
-        timeout = jiffies + (HZ * 1);
+        __msleep(20, can_sleep);
+
+        timeout = jiffies + msecs_to_jiffies(200);
         do {
-                mdelay(10);
-                if ((scr_read(ap, SCR_STATUS) & 0xf) != 1)
+                sstatus = scr_read(ap, SCR_STATUS) & 0x3;
+                if ((sstatus == 3) || (sstatus == 0))
                         break;
+
+                __msleep(1, can_sleep);
         } while (time_before(jiffies, timeout));
 
-        VPRINTK("S-regs after PHY wake: SStat 0x%08x SErr 0x%08x "
+        /* work around errata */
+        if (IS_60XX(hpriv) &&
+            (sstatus != 0x0) && (sstatus != 0x113) && (sstatus != 0x123) &&
+            (retry-- > 0))
+                goto comreset_retry;
+
+        DPRINTK("S-regs after PHY wake: SStat 0x%08x SErr 0x%08x "
                 "SCtrl 0x%08x\n", mv_scr_read(ap, SCR_STATUS),
                 mv_scr_read(ap, SCR_ERROR), mv_scr_read(ap, SCR_CONTROL));
 
@@ -1261,6 +1785,21 @@ static void mv_phy_reset(struct ata_port *ap)
         }
         ap->cbl = ATA_CBL_SATA;
 
+        /* even after SStatus reflects that device is ready,
+         * it seems to take a while for link to be fully
+         * established (and thus Status no longer 0x80/0x7F),
+         * so we poll a bit for that, here.
+         */
+        retry = 20;
+        while (1) {
+                u8 drv_stat = ata_check_status(ap);
+                if ((drv_stat != 0x80) && (drv_stat != 0x7f))
+                        break;
+                __msleep(500, can_sleep);
+                if (retry-- <= 0)
+                        break;
+        }
+
         tf.lbah = readb((void __iomem *) ap->ioaddr.lbah_addr);
         tf.lbam = readb((void __iomem *) ap->ioaddr.lbam_addr);
         tf.lbal = readb((void __iomem *) ap->ioaddr.lbal_addr);
@@ -1271,9 +1810,19 @@ static void mv_phy_reset(struct ata_port *ap)
                 VPRINTK("Port disabled post-sig: No device present.\n");
                 ata_port_disable(ap);
         }
+
+        writelfl(0, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);
+
+        pp->pp_flags &= ~MV_PP_FLAG_EDMA_EN;
+
         VPRINTK("EXIT\n");
 }
 
+static void mv_phy_reset(struct ata_port *ap)
+{
+        __mv_phy_reset(ap, 1);
+}
+
 /**
  *      mv_eng_timeout - Routine called by libata when SCSI times out I/O
  *      @ap: ATA channel to manipulate
@@ -1291,16 +1840,16 @@ static void mv_eng_timeout(struct ata_port *ap)
 
         printk(KERN_ERR "ata%u: Entering mv_eng_timeout\n",ap->id);
         DPRINTK("All regs @ start of eng_timeout\n");
-        mv_dump_all_regs(ap->host_set->mmio_base, ap->port_no, 
+        mv_dump_all_regs(ap->host_set->mmio_base, ap->port_no,
                          to_pci_dev(ap->host_set->dev));
 
         qc = ata_qc_from_tag(ap, ap->active_tag);
         printk(KERN_ERR "mmio_base %p ap %p qc %p scsi_cmnd %p &cmnd %p\n",
-               ap->host_set->mmio_base, ap, qc, qc->scsicmd, 
+               ap->host_set->mmio_base, ap, qc, qc->scsicmd,
                &qc->scsicmd->cmnd);
 
         mv_err_intr(ap);
-        mv_phy_reset(ap);
+        mv_stop_and_reset(ap);
 
         if (!qc) {
                 printk(KERN_ERR "ata%u: BUG: timeout without command\n",
@@ -1336,17 +1885,17 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
         unsigned long shd_base = (unsigned long) port_mmio + SHD_BLK_OFS;
         unsigned serr_ofs;
 
-        /* PIO related setup 
+        /* PIO related setup
          */
         port->data_addr = shd_base + (sizeof(u32) * ATA_REG_DATA);
-        port->error_addr = 
+        port->error_addr =
                 port->feature_addr = shd_base + (sizeof(u32) * ATA_REG_ERR);
         port->nsect_addr = shd_base + (sizeof(u32) * ATA_REG_NSECT);
         port->lbal_addr = shd_base + (sizeof(u32) * ATA_REG_LBAL);
         port->lbam_addr = shd_base + (sizeof(u32) * ATA_REG_LBAM);
         port->lbah_addr = shd_base + (sizeof(u32) * ATA_REG_LBAH);
         port->device_addr = shd_base + (sizeof(u32) * ATA_REG_DEVICE);
-        port->status_addr = 
+        port->status_addr =
                 port->command_addr = shd_base + (sizeof(u32) * ATA_REG_STATUS);
         /* special case: control/altstatus doesn't have ATA_REG_ address */
         port->altstatus_addr = port->ctl_addr = shd_base + SHD_CTL_AST_OFS;
@@ -1362,14 +1911,92 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
         /* unmask all EDMA error interrupts */
         writelfl(~0, port_mmio + EDMA_ERR_IRQ_MASK_OFS);
 
-        VPRINTK("EDMA cfg=0x%08x EDMA IRQ err cause/mask=0x%08x/0x%08x\n", 
+        VPRINTK("EDMA cfg=0x%08x EDMA IRQ err cause/mask=0x%08x/0x%08x\n",
                 readl(port_mmio + EDMA_CFG_OFS),
                 readl(port_mmio + EDMA_ERR_IRQ_CAUSE_OFS),
                 readl(port_mmio + EDMA_ERR_IRQ_MASK_OFS));
 }
 
+static int mv_chip_id(struct pci_dev *pdev, struct mv_host_priv *hpriv,
+                      unsigned int board_idx)
+{
+        u8 rev_id;
+        u32 hp_flags = hpriv->hp_flags;
+
+        pci_read_config_byte(pdev, PCI_REVISION_ID, &rev_id);
+
+        switch(board_idx) {
+        case chip_5080:
+                hpriv->ops = &mv5xxx_ops;
+                hp_flags |= MV_HP_50XX;
+
+                switch (rev_id) {
+                case 0x1:
+                        hp_flags |= MV_HP_ERRATA_50XXB0;
+                        break;
+                case 0x3:
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                           "Applying 50XXB2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                }
+                break;
+
+        case chip_504x:
+        case chip_508x:
+                hpriv->ops = &mv5xxx_ops;
+                hp_flags |= MV_HP_50XX;
+
+                switch (rev_id) {
+                case 0x0:
+                        hp_flags |= MV_HP_ERRATA_50XXB0;
+                        break;
+                case 0x3:
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                           "Applying B2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                }
+                break;
+
+        case chip_604x:
+        case chip_608x:
+                hpriv->ops = &mv6xxx_ops;
+
+                switch (rev_id) {
+                case 0x7:
+                        hp_flags |= MV_HP_ERRATA_60X1B2;
+                        break;
+                case 0x9:
+                        hp_flags |= MV_HP_ERRATA_60X1C0;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                                   "Applying B2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_60X1B2;
+                        break;
+                }
+                break;
+
+        default:
+                printk(KERN_ERR DRV_NAME ": BUG: invalid board index %u\n", board_idx);
+                return 1;
+        }
+
+        hpriv->hp_flags = hp_flags;
+
+        return 0;
+}
+
 /**
- *      mv_host_init - Perform some early initialization of the host.
+ *      mv_init_host - Perform some early initialization of the host.
+ *      @pdev: host PCI device
  *      @probe_ent: early data struct representing the host
  *
  *      If possible, do an early global reset of the host.  Then do
@@ -1378,23 +2005,48 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
  *      LOCKING:
  *      Inherited from caller.
  */
-static int mv_host_init(struct ata_probe_ent *probe_ent)
+static int mv_init_host(struct pci_dev *pdev, struct ata_probe_ent *probe_ent,
+                        unsigned int board_idx)
 {
         int rc = 0, n_hc, port, hc;
         void __iomem *mmio = probe_ent->mmio_base;
-        void __iomem *port_mmio;
+        struct mv_host_priv *hpriv = probe_ent->private_data;
 
-        if ((MV_FLAG_GLBL_SFT_RST & probe_ent->host_flags) && 
-            mv_global_soft_reset(probe_ent->mmio_base)) {
-                rc = 1;
+        /* global interrupt mask */
+        writel(0, mmio + HC_MAIN_IRQ_MASK_OFS);
+
+        rc = mv_chip_id(pdev, hpriv, board_idx);
+        if (rc)
                 goto done;
-        }
 
         n_hc = mv_get_hc_count(probe_ent->host_flags);
         probe_ent->n_ports = MV_PORTS_PER_HC * n_hc;
 
+        for (port = 0; port < probe_ent->n_ports; port++)
+                hpriv->ops->read_preamp(hpriv, port, mmio);
+
+        rc = hpriv->ops->reset_hc(hpriv, mmio, n_hc);
+        if (rc)
+                goto done;
+
+        hpriv->ops->reset_flash(hpriv, mmio);
+        hpriv->ops->reset_bus(pdev, mmio);
+        hpriv->ops->enable_leds(hpriv, mmio);
+
         for (port = 0; port < probe_ent->n_ports; port++) {
-                port_mmio = mv_port_base(mmio, port);
+                if (IS_60XX(hpriv)) {
+                        void __iomem *port_mmio = mv_port_base(mmio, port);
+
+                        u32 ifctl = readl(port_mmio + SATA_INTERFACE_CTL);
+                        ifctl |= (1 << 12);
+                        writelfl(ifctl, port_mmio + SATA_INTERFACE_CTL);
+                }
+
+                hpriv->ops->phy_errata(hpriv, mmio, port);
+        }
+
+        for (port = 0; port < probe_ent->n_ports; port++) {
+                void __iomem *port_mmio = mv_port_base(mmio, port);
                 mv_port_init(&probe_ent->port[port], port_mmio);
         }
 
@@ -1418,11 +2070,12 @@ static int mv_host_init(struct ata_probe_ent *probe_ent)
         writelfl(~HC_MAIN_MASKED_IRQS, mmio + HC_MAIN_IRQ_MASK_OFS);
 
         VPRINTK("HC MAIN IRQ cause/mask=0x%08x/0x%08x "
-                "PCI int cause/mask=0x%08x/0x%08x\n", 
+                "PCI int cause/mask=0x%08x/0x%08x\n",
                 readl(mmio + HC_MAIN_IRQ_CAUSE_OFS),
                 readl(mmio + HC_MAIN_IRQ_MASK_OFS),
                 readl(mmio + PCI_IRQ_CAUSE_OFS),
                 readl(mmio + PCI_IRQ_MASK_OFS));
+
 done:
         return rc;
 }
@@ -1458,7 +2111,7 @@ static void mv_print_info(struct ata_probe_ent *probe_ent)
 
         dev_printk(KERN_INFO, &pdev->dev,
                "%u slots %u ports %s mode IRQ via %s\n",
-               (unsigned)MV_MAX_Q_DEPTH, probe_ent->n_ports, 
+               (unsigned)MV_MAX_Q_DEPTH, probe_ent->n_ports,
                scc_s, (MV_HP_FLAG_MSI & hpriv->hp_flags) ? "MSI" : "INTx");
 }
 
@@ -1528,7 +2181,7 @@ static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
         probe_ent->private_data = hpriv;
 
         /* initialize adapter */
-        rc = mv_host_init(probe_ent);
+        rc = mv_init_host(pdev, probe_ent, board_idx);
         if (rc) {
                 goto err_out_hpriv;
         }
diff --git a/drivers/scsi/sata_promise.c b/drivers/scsi/sata_promise.c
index 242d906987ad..8a8e3e3ef0ed 100644
--- a/drivers/scsi/sata_promise.c
+++ b/drivers/scsi/sata_promise.c
@@ -46,7 +46,7 @@
 #include "sata_promise.h"
 
 #define DRV_NAME        "sata_promise"
-#define DRV_VERSION     "1.02"
+#define DRV_VERSION     "1.03"
 
 
 enum {
diff --git a/drivers/scsi/sata_qstor.c b/drivers/scsi/sata_qstor.c
index b2f6324a2eb2..a8987f5ff5cc 100644
--- a/drivers/scsi/sata_qstor.c
+++ b/drivers/scsi/sata_qstor.c
@@ -41,7 +41,7 @@
 #include <linux/libata.h>
 
 #define DRV_NAME        "sata_qstor"
-#define DRV_VERSION     "0.04"
+#define DRV_VERSION     "0.05"
 
 enum {
         QS_PORTS                = 4,
@@ -268,7 +268,7 @@ static void qs_scr_write (struct ata_port *ap, unsigned int sc_reg, u32 val)
         writel(val, (void __iomem *)(ap->ioaddr.scr_addr + (sc_reg * 8)));
 }
 
-static void qs_fill_sg(struct ata_queued_cmd *qc)
+static unsigned int qs_fill_sg(struct ata_queued_cmd *qc)
 {
         struct scatterlist *sg;
         struct ata_port *ap = qc->ap;
@@ -296,6 +296,8 @@ static void qs_fill_sg(struct ata_queued_cmd *qc)
                                         (unsigned long long)addr, len);
                 nelem++;
         }
+
+        return nelem;
 }
 
 static void qs_qc_prep(struct ata_queued_cmd *qc)
@@ -304,6 +306,7 @@ static void qs_qc_prep(struct ata_queued_cmd *qc)
         u8 dflags = QS_DF_PORD, *buf = pp->pkt;
         u8 hflags = QS_HF_DAT | QS_HF_IEN | QS_HF_VLD;
         u64 addr;
+        unsigned int nelem;
 
         VPRINTK("ENTER\n");
 
@@ -313,7 +316,7 @@ static void qs_qc_prep(struct ata_queued_cmd *qc)
                 return;
         }
 
-        qs_fill_sg(qc);
+        nelem = qs_fill_sg(qc);
 
         if ((qc->tf.flags & ATA_TFLAG_WRITE))
                 hflags |= QS_HF_DIRO;
@@ -324,7 +327,7 @@ static void qs_qc_prep(struct ata_queued_cmd *qc)
         buf[ 0] = QS_HCB_HDR;
         buf[ 1] = hflags;
         *(__le32 *)(&buf[ 4]) = cpu_to_le32(qc->nsect * ATA_SECT_SIZE);
-        *(__le32 *)(&buf[ 8]) = cpu_to_le32(qc->n_elem);
+        *(__le32 *)(&buf[ 8]) = cpu_to_le32(nelem);
         addr = ((u64)pp->pkt_dma) + QS_CPB_BYTES;
         *(__le64 *)(&buf[16]) = cpu_to_le64(addr);
 
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index d3198d9a72c1..cb1933a3bd55 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -139,6 +139,7 @@ enum {
         PORT_CS_DEV_RST         = (1 << 1), /* device reset */
         PORT_CS_INIT            = (1 << 2), /* port initialize */
         PORT_CS_IRQ_WOC         = (1 << 3), /* interrupt write one to clear */
+        PORT_CS_CDB16           = (1 << 5), /* 0=12b cdb, 1=16b cdb */
         PORT_CS_RESUME          = (1 << 6), /* port resume */
         PORT_CS_32BIT_ACTV      = (1 << 10), /* 32-bit activation */
         PORT_CS_PM_EN           = (1 << 13), /* port multiplier enable */
@@ -188,11 +189,29 @@ enum {
         PORT_CERR_XFR_PCIPERR   = 35, /* PSD ecode 11 - PCI prity err during transfer */
         PORT_CERR_SENDSERVICE   = 36, /* FIS received while sending service */
 
+        /* bits of PRB control field */
+        PRB_CTRL_PROTOCOL       = (1 << 0), /* override def. ATA protocol */
+        PRB_CTRL_PACKET_READ    = (1 << 4), /* PACKET cmd read */
+        PRB_CTRL_PACKET_WRITE   = (1 << 5), /* PACKET cmd write */
+        PRB_CTRL_NIEN           = (1 << 6), /* Mask completion irq */
+        PRB_CTRL_SRST           = (1 << 7), /* Soft reset request (ign BSY?) */
+
+        /* PRB protocol field */
+        PRB_PROT_PACKET         = (1 << 0),
+        PRB_PROT_TCQ            = (1 << 1),
+        PRB_PROT_NCQ            = (1 << 2),
+        PRB_PROT_READ           = (1 << 3),
+        PRB_PROT_WRITE          = (1 << 4),
+        PRB_PROT_TRANSPARENT    = (1 << 5),
+
         /*
          * Other constants
          */
         SGE_TRM                 = (1 << 31), /* Last SGE in chain */
-        PRB_SOFT_RST            = (1 << 7),  /* Soft reset request (ign BSY?) */
+        SGE_LNK                 = (1 << 30), /* linked list
+                                                Points to SGT, not SGE */
+        SGE_DRD                 = (1 << 29), /* discard data read (/dev/null)
+                                                data address ignored */
 
         /* board id */
         BID_SIL3124             = 0,
@@ -687,6 +706,7 @@ static void sil24_port_stop(struct ata_port *ap)
         struct sil24_port_priv *pp = ap->private_data;
 
         sil24_cblk_free(pp, dev);
+        ata_pad_free(ap, dev);
         kfree(pp);
 }
 
diff --git a/drivers/scsi/sata_svw.c b/drivers/scsi/sata_svw.c
index 57e5a9d964c3..6e7f7c83a75a 100644
--- a/drivers/scsi/sata_svw.c
+++ b/drivers/scsi/sata_svw.c
@@ -54,7 +54,7 @@
 #endif /* CONFIG_PPC_OF */
 
 #define DRV_NAME        "sata_svw"
-#define DRV_VERSION     "1.06"
+#define DRV_VERSION     "1.07"
 
 /* Taskfile registers offsets */
 #define K2_SATA_TF_CMD_OFFSET           0x00
diff --git a/drivers/scsi/sata_sx4.c b/drivers/scsi/sata_sx4.c
index b4bbe48acab0..dcc3ad9a9d6e 100644
--- a/drivers/scsi/sata_sx4.c
+++ b/drivers/scsi/sata_sx4.c
@@ -46,7 +46,7 @@
 #include "sata_promise.h"
 
 #define DRV_NAME        "sata_sx4"
-#define DRV_VERSION     "0.7"
+#define DRV_VERSION     "0.8"
 
 
 enum {
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
index 77a6e4b9262d..fcfa486965b4 100644
--- a/drivers/scsi/sata_vsc.c
+++ b/drivers/scsi/sata_vsc.c
@@ -47,7 +47,7 @@
 #include <linux/libata.h>
 
 #define DRV_NAME        "sata_vsc"
-#define DRV_VERSION     "1.0"
+#define DRV_VERSION     "1.1"
 
 /* Interrupt register offsets (from chip base address) */
 #define VSC_SATA_INT_STAT_OFFSET        0x00
diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index 2efb317153ce..67e9afa000c1 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -34,6 +34,7 @@
 #include <linux/keyboard.h>
 #include <linux/init.h>
 #include <linux/pm.h>
+#include <linux/pm_legacy.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 
@@ -1343,7 +1344,7 @@ static void show_serial_version(void)
         printk("MC68328 serial driver version 1.00\n");
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
 /* Serial Power management
  *  The console (currently fixed at line 0) is a special case for power
  *  management because the kernel is so chatty. The console will be 
@@ -1393,7 +1394,7 @@ void startup_console(void)
         struct m68k_serial *info = &m68k_soft[0];
         startup(info);
 }
-#endif
+#endif /* CONFIG_PM_LEGACY */
 
 
 static struct tty_operations rs_ops = {
@@ -1486,7 +1487,7 @@ rs68328_init(void)
                             IRQ_FLG_STD,
                             "M68328_UART", NULL))
                 panic("Unable to attach 68328 serial interrupt\n");
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_LEGACY
             serial_pm[i] = pm_register(PM_SYS_DEV, PM_SYS_COM, serial_pm_callback);
             if (serial_pm[i])
                     serial_pm[i]->data = info;
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 3742753241ee..e08510d09ff6 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -999,7 +999,10 @@ static void autoconfig(struct uart_8250_port *up, unsigned int probeflags)
         serial_outp(up, UART_MCR, save_mcr);
         serial8250_clear_fifos(up);
         (void)serial_in(up, UART_RX);
-        serial_outp(up, UART_IER, 0);
+        if (up->capabilities & UART_CAP_UUE)
+                serial_outp(up, UART_IER, UART_IER_UUE);
+        else
+                serial_outp(up, UART_IER, 0);
 
  out:   
         spin_unlock_irqrestore(&up->port.lock, flags);
diff --git a/drivers/serial/8250_pnp.c b/drivers/serial/8250_pnp.c
index 5d8660a42b77..b79ed0665d51 100644
--- a/drivers/serial/8250_pnp.c
+++ b/drivers/serial/8250_pnp.c
@@ -323,6 +323,8 @@ static const struct pnp_device_id pnp_dev_table[] = {
         {       "USR9180",              0       },
         /* U.S. Robotics 56K Voice INT PnP*/
         {       "USR9190",              0       },
+        /* HP Compaq Tablet PC tc1100 Wacom tablet */
+        {       "WACF005",              0       },
         /* Rockwell's (PORALiNK) 33600 INT PNP */
         {       "WCI0003",              0       },
         /* Unkown PnP modems */
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c
index 25825f2aba22..987d22b53c22 100644
--- a/drivers/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/serial/cpm_uart/cpm_uart_core.c
@@ -7,7 +7,7 @@
  *  Based on ppc8xx.c by Thomas Gleixner
  *  Based on drivers/serial/amba.c by Russell King
  *
- *  Maintainer: Kumar Gala (kumar.gala@freescale.com) (CPM2)
+ *  Maintainer: Kumar Gala (galak@kernel.crashing.org) (CPM2)
  *              Pantelis Antoniou (panto@intracom.gr) (CPM1)
  *
  *  Copyright (C) 2004 Freescale Semiconductor, Inc.
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm1.c b/drivers/serial/cpm_uart/cpm_uart_cpm1.c
index 4b0786e7eb7f..d789ee55cbb7 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm1.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm1.c
@@ -3,7 +3,7 @@
  *
  *  Driver for CPM (SCC/SMC) serial ports; CPM1 definitions
  *
- *  Maintainer: Kumar Gala (kumar.gala@freescale.com) (CPM2)
+ *  Maintainer: Kumar Gala (galak@kernel.crashing.org) (CPM2)
  *              Pantelis Antoniou (panto@intracom.gr) (CPM1)
  *
  *  Copyright (C) 2004 Freescale Semiconductor, Inc.
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
index 15ad58d94889..fd9e53ed3feb 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
@@ -3,7 +3,7 @@
  *
  *  Driver for CPM (SCC/SMC) serial ports; CPM2 definitions
  *
- *  Maintainer: Kumar Gala (kumar.gala@freescale.com) (CPM2)
+ *  Maintainer: Kumar Gala (galak@kernel.crashing.org) (CPM2)
  *              Pantelis Antoniou (panto@intracom.gr) (CPM1)
  * 
  *  Copyright (C) 2004 Freescale Semiconductor, Inc.
diff --git a/drivers/serial/dz.c b/drivers/serial/dz.c
index e63b9dffc8d7..4d8516d1bb71 100644
--- a/drivers/serial/dz.c
+++ b/drivers/serial/dz.c
@@ -1,9 +1,9 @@
 /*
- * dz.c: Serial port driver for DECStations equiped 
+ * dz.c: Serial port driver for DECStations equiped
  *       with the DZ chipset.
  *
- * Copyright (C) 1998 Olivier A. D. Lebaillif 
- *             
+ * Copyright (C) 1998 Olivier A. D. Lebaillif
+ *
  * Email: olivier.lebaillif@ifrsys.com
  *
  * [31-AUG-98] triemer
@@ -11,14 +11,14 @@
  * removed base_addr code - moving address assignment to setup.c
  * Changed name of dz_init to rs_init to be consistent with tc code
  * [13-NOV-98] triemer fixed code to receive characters
- *    after patches by harald to irq code.  
+ *    after patches by harald to irq code.
  * [09-JAN-99] triemer minor fix for schedule - due to removal of timeout
  *            field from "current" - somewhere between 2.1.121 and 2.1.131
  Qua Jun 27 15:02:26 BRT 2001
  * [27-JUN-2001] Arnaldo Carvalho de Melo <acme@conectiva.com.br> - cleanups
- *  
- * Parts (C) 1999 David Airlie, airlied@linux.ie 
- * [07-SEP-99] Bugfixes 
+ *
+ * Parts (C) 1999 David Airlie, airlied@linux.ie
+ * [07-SEP-99] Bugfixes
  *
  * [06-Jan-2002] Russell King <rmk@arm.linux.org.uk>
  * Converted to new serial core
@@ -64,7 +64,7 @@ static struct dz_port dz_ports[DZ_NB_PORT];
 
 #ifdef DEBUG_DZ
 /*
- * debugging code to send out chars via prom 
+ * debugging code to send out chars via prom
  */
 static void debug_console(const char *s, int count)
 {
@@ -82,7 +82,7 @@ static void debug_console(const char *s, int count)
  * ------------------------------------------------------------
  * dz_in () and dz_out ()
  *
- * These routines are used to access the registers of the DZ 
+ * These routines are used to access the registers of the DZ
  * chip, hiding relocation differences between implementation.
  * ------------------------------------------------------------
  */
@@ -106,8 +106,8 @@ static inline void dz_out(struct dz_port *dport, unsigned offset,
  * ------------------------------------------------------------
  * rs_stop () and rs_start ()
  *
- * These routines are called before setting or resetting 
- * tty->stopped. They enable or disable transmitter interrupts, 
+ * These routines are called before setting or resetting
+ * tty->stopped. They enable or disable transmitter interrupts,
  * as necessary.
  * ------------------------------------------------------------
  */
@@ -156,17 +156,17 @@ static void dz_enable_ms(struct uart_port *port)
 
 /*
  * ------------------------------------------------------------
- * Here starts the interrupt handling routines.  All of the 
- * following subroutines are declared as inline and are folded 
- * into dz_interrupt.  They were separated out for readability's 
- * sake. 
+ * Here starts the interrupt handling routines.  All of the
+ * following subroutines are declared as inline and are folded
+ * into dz_interrupt.  They were separated out for readability's
+ * sake.
  *
  * Note: rs_interrupt() is a "fast" interrupt, which means that it
  * runs with interrupts turned off.  People who may want to modify
  * rs_interrupt() should try to keep the interrupt handler as fast as
  * possible.  After you are done making modifications, it is not a bad
  * idea to do:
- * 
+ *
  *      make drivers/serial/dz.s
  *
  * and look at the resulting assemble code in dz.s.
@@ -403,7 +403,7 @@ static void dz_set_mctrl(struct uart_port *uport, unsigned int mctrl)
  * startup ()
  *
  * various initialization tasks
- * ------------------------------------------------------------------- 
+ * -------------------------------------------------------------------
  */
 static int dz_startup(struct uart_port *uport)
 {
@@ -430,13 +430,13 @@ static int dz_startup(struct uart_port *uport)
         return 0;
 }
 
-/* 
+/*
  * -------------------------------------------------------------------
  * shutdown ()
  *
  * This routine will shutdown a serial port; interrupts are disabled, and
  * DTR is dropped if the hangup on close termio flag is on.
- * ------------------------------------------------------------------- 
+ * -------------------------------------------------------------------
  */
 static void dz_shutdown(struct uart_port *uport)
 {
@@ -451,7 +451,7 @@ static void dz_shutdown(struct uart_port *uport)
  *          release the bus after transmitting. This must be done when
  *          the transmit shift register is empty, not be done when the
  *          transmit holding register is empty.  This functionality
- *          allows an RS485 driver to be written in user space. 
+ *          allows an RS485 driver to be written in user space.
  */
 static unsigned int dz_tx_empty(struct uart_port *uport)
 {
@@ -645,9 +645,9 @@ static void __init dz_init_ports(void)
 
         if (mips_machtype == MACH_DS23100 ||
             mips_machtype == MACH_DS5100)
-                base = (unsigned long) KN01_DZ11_BASE;
+                base = CKSEG1ADDR(KN01_SLOT_BASE + KN01_DZ11);
         else
-                base = (unsigned long) KN02_DZ11_BASE;
+                base = CKSEG1ADDR(KN02_SLOT_BASE + KN02_DZ11);
 
         for (i = 0, dport = dz_ports; i < DZ_NB_PORT; i++, dport++) {
                 spin_lock_init(&dport->port.lock);
@@ -695,13 +695,13 @@ static void dz_console_put_char(struct dz_port *dport, unsigned char ch)
 
         spin_unlock_irqrestore(&dport->port.lock, flags);
 }
-/* 
+/*
  * -------------------------------------------------------------------
  * dz_console_print ()
  *
  * dz_console_print is registered for printk.
  * The console must be locked when we get here.
- * ------------------------------------------------------------------- 
+ * -------------------------------------------------------------------
  */
 static void dz_console_print(struct console *cons,
                              const char *str,
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 5d3cb8486447..b8727d9bf690 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -725,7 +725,7 @@ mpc52xx_uart_probe(struct platform_device *dev)
         int i, idx, ret;
 
         /* Check validity & presence */
-        idx = pdev->id;
+        idx = dev->id;
         if (idx < 0 || idx >= MPC52xx_PSC_MAXNUM)
                 return -EINVAL;
 
@@ -748,7 +748,7 @@ mpc52xx_uart_probe(struct platform_device *dev)
         port->ops       = &mpc52xx_uart_ops;
 
         /* Search for IRQ and mapbase */
-        for (i=0 ; i<pdev->num_resources ; i++, res++) {
+        for (i=0 ; i<dev->num_resources ; i++, res++) {
                 if (res->flags & IORESOURCE_MEM)
                         port->mapbase = res->start;
                 else if (res->flags & IORESOURCE_IRQ)
diff --git a/drivers/serial/sa1100.c b/drivers/serial/sa1100.c
index fd9deee20e05..0e3daf6d7b50 100644
--- a/drivers/serial/sa1100.c
+++ b/drivers/serial/sa1100.c
@@ -156,7 +156,7 @@ static void sa1100_stop_tx(struct uart_port *port)
 }
 
 /*
- * interrupts may not be disabled on entry
+ * port locked and interrupts disabled
  */
 static void sa1100_start_tx(struct uart_port *port)
 {
@@ -164,11 +164,9 @@ static void sa1100_start_tx(struct uart_port *port)
         unsigned long flags;
         u32 utcr3;
 
-        spin_lock_irqsave(&sport->port.lock, flags);
         utcr3 = UART_GET_UTCR3(sport);
         sport->port.read_status_mask |= UTSR0_TO_SM(UTSR0_TFS);
         UART_PUT_UTCR3(sport, utcr3 | UTCR3_TIE);
-        spin_unlock_irqrestore(&sport->port.lock, flags);
 }
 
 /*
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 427a23858076..2331296e1e17 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -209,33 +209,45 @@ static void uart_shutdown(struct uart_state *state)
         struct uart_info *info = state->info;
         struct uart_port *port = state->port;
 
-        if (!(info->flags & UIF_INITIALIZED))
-                return;
-
         /*
-         * Turn off DTR and RTS early.
+         * Set the TTY IO error marker
          */
-        if (!info->tty || (info->tty->termios->c_cflag & HUPCL))
-                uart_clear_mctrl(port, TIOCM_DTR | TIOCM_RTS);
+        if (info->tty)
+                set_bit(TTY_IO_ERROR, &info->tty->flags);
 
-        /*
-         * clear delta_msr_wait queue to avoid mem leaks: we may free
-         * the irq here so the queue might never be woken up.  Note
-         * that we won't end up waiting on delta_msr_wait again since
-         * any outstanding file descriptors should be pointing at
-         * hung_up_tty_fops now.
-         */
-        wake_up_interruptible(&info->delta_msr_wait);
+        if (info->flags & UIF_INITIALIZED) {
+                info->flags &= ~UIF_INITIALIZED;
 
-        /*
-         * Free the IRQ and disable the port.
-         */
-        port->ops->shutdown(port);
+                /*
+                 * Turn off DTR and RTS early.
+                 */
+                if (!info->tty || (info->tty->termios->c_cflag & HUPCL))
+                        uart_clear_mctrl(port, TIOCM_DTR | TIOCM_RTS);
+
+                /*
+                 * clear delta_msr_wait queue to avoid mem leaks: we may free
+                 * the irq here so the queue might never be woken up.  Note
+                 * that we won't end up waiting on delta_msr_wait again since
+                 * any outstanding file descriptors should be pointing at
+                 * hung_up_tty_fops now.
+                 */
+                wake_up_interruptible(&info->delta_msr_wait);
+
+                /*
+                 * Free the IRQ and disable the port.
+                 */
+                port->ops->shutdown(port);
+
+                /*
+                 * Ensure that the IRQ handler isn't running on another CPU.
+                 */
+                synchronize_irq(port->irq);
+        }
 
         /*
-         * Ensure that the IRQ handler isn't running on another CPU.
+         * kill off our tasklet
          */
-        synchronize_irq(port->irq);
+        tasklet_kill(&info->tlet);
 
         /*
          * Free the transmit buffer page.
@@ -244,15 +256,6 @@ static void uart_shutdown(struct uart_state *state)
                 free_page((unsigned long)info->xmit.buf);
                 info->xmit.buf = NULL;
         }
-
-        /*
-         * kill off our tasklet
-         */
-        tasklet_kill(&info->tlet);
-        if (info->tty)
-                set_bit(TTY_IO_ERROR, &info->tty->flags);
-
-        info->flags &= ~UIF_INITIALIZED;
 }
 
 /**
@@ -1928,14 +1931,25 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *port)
 
         if (state->info && state->info->flags & UIF_INITIALIZED) {
                 struct uart_ops *ops = port->ops;
+                int ret;
 
                 ops->set_mctrl(port, 0);
-                ops->startup(port);
-                uart_change_speed(state, NULL);
-                spin_lock_irq(&port->lock);
-                ops->set_mctrl(port, port->mctrl);
-                ops->start_tx(port);
-                spin_unlock_irq(&port->lock);
+                ret = ops->startup(port);
+                if (ret == 0) {
+                        uart_change_speed(state, NULL);
+                        spin_lock_irq(&port->lock);
+                        ops->set_mctrl(port, port->mctrl);
+                        ops->start_tx(port);
+                        spin_unlock_irq(&port->lock);
+                } else {
+                        /*
+                         * Failed to resume - maybe hardware went away?
+                         * Clear the "initialized" flag so we won't try
+                         * to call the low level drivers shutdown method.
+                         */
+                        state->info->flags &= ~UIF_INITIALIZED;
+                        uart_shutdown(state);
+                }
         }
 
         up(&state->sem);
diff --git a/drivers/tc/zs.c b/drivers/tc/zs.c
index c52af73a251b..6756d0fab6fe 100644
--- a/drivers/tc/zs.c
+++ b/drivers/tc/zs.c
@@ -6,7 +6,7 @@
  *
  * DECstation changes
  * Copyright (C) 1998-2000 Harald Koerfgen
- * Copyright (C) 2000, 2001, 2002, 2003, 2004  Maciej W. Rozycki
+ * Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005  Maciej W. Rozycki
  *
  * For the rest of the code the original Copyright applies:
  * Copyright (C) 1996 Paul Mackerras (Paul.Mackerras@cs.anu.edu.au)
@@ -55,6 +55,7 @@
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/spinlock.h>
 #ifdef CONFIG_SERIAL_DEC_CONSOLE
 #include <linux/console.h>
 #endif
@@ -63,7 +64,6 @@
 #include <asm/pgtable.h>
 #include <asm/irq.h>
 #include <asm/system.h>
-#include <asm/uaccess.h>
 #include <asm/bootinfo.h>
 
 #include <asm/dec/interrupts.h>
@@ -128,6 +128,8 @@ static struct zs_parms ds_parms = {
 
 #define BUS_PRESENT (DS_BUS_PRESENT)
 
+DEFINE_SPINLOCK(zs_lock);
+
 struct dec_zschannel zs_channels[NUM_CHANNELS];
 struct dec_serial zs_soft[NUM_CHANNELS];
 int zs_channels_found;
@@ -159,8 +161,6 @@ static unsigned char zs_init_regs[16] __initdata = {
         0                               /* write 15 */
 };
 
-DECLARE_TASK_QUEUE(tq_zs_serial);
-
 static struct tty_driver *serial_driver;
 
 /* serial subtype definitions */
@@ -294,8 +294,7 @@ static inline void zs_rtsdtr(struct dec_serial *info, int which, int set)
 {
         unsigned long flags;
 
-
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
         if (info->zs_channel != info->zs_chan_a) {
                 if (set) {
                         info->zs_chan_a->curregs[5] |= (which & (RTS | DTR));
@@ -304,7 +303,7 @@ static inline void zs_rtsdtr(struct dec_serial *info, int which, int set)
                 }
                 write_zsreg(info->zs_chan_a, 5, info->zs_chan_a->curregs[5]);
         }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 /* Utility routines for the Zilog */
@@ -345,12 +344,10 @@ static inline void rs_recv_clear(struct dec_zschannel *zsc)
  * This routine is used by the interrupt handler to schedule
  * processing in the software interrupt portion of the driver.
  */
-static _INLINE_ void rs_sched_event(struct dec_serial *info,
-                                  int event)
+static _INLINE_ void rs_sched_event(struct dec_serial *info, int event)
 {
         info->event |= 1 << event;
-        queue_task(&info->tqueue, &tq_zs_serial);
-        mark_bh(SERIAL_BH);
+        tasklet_schedule(&info->tlet);
 }
 
 static _INLINE_ void receive_chars(struct dec_serial *info,
@@ -497,9 +494,10 @@ static _INLINE_ void status_handle(struct dec_serial *info)
 /*
  * This is the serial driver's generic interrupt routine
  */
-void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
+static irqreturn_t rs_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
         struct dec_serial *info = (struct dec_serial *) dev_id;
+        irqreturn_t status = IRQ_NONE;
         unsigned char zs_intreg;
         int shift;
 
@@ -521,6 +519,8 @@ void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
                 if ((zs_intreg & CHAN_IRQMASK) == 0)
                         break;
 
+                status = IRQ_HANDLED;
+
                 if (zs_intreg & CHBRxIP) {
                         receive_chars(info, regs);
                 }
@@ -534,6 +534,8 @@ void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
 
         /* Why do we need this ? */
         write_zsreg(info->zs_channel, 0, RES_H_IUS);
+
+        return status;
 }
 
 #ifdef ZS_DEBUG_REGS
@@ -578,12 +580,12 @@ static void rs_stop(struct tty_struct *tty)
                 return;
 
 #if 1
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
         if (info->zs_channel->curregs[5] & TxENAB) {
                 info->zs_channel->curregs[5] &= ~TxENAB;
                 write_zsreg(info->zs_channel, 5, info->zs_channel->curregs[5]);
         }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 #endif
 }
 
@@ -595,7 +597,7 @@ static void rs_start(struct tty_struct *tty)
         if (serial_paranoia_check(info, tty->name, "rs_start"))
                 return;
 
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
 #if 1
         if (info->xmit_cnt && info->xmit_buf && !(info->zs_channel->curregs[5] & TxENAB)) {
                 info->zs_channel->curregs[5] |= TxENAB;
@@ -606,7 +608,7 @@ static void rs_start(struct tty_struct *tty)
                 transmit_chars(info);
         }
 #endif
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 /*
@@ -618,12 +620,8 @@ static void rs_start(struct tty_struct *tty)
  * interrupt driver proper are done; the interrupt driver schedules
  * them using rs_sched_event(), and they get done here.
  */
-static void do_serial_bh(void)
-{
-        run_task_queue(&tq_zs_serial);
-}
 
-static void do_softint(void *private_)
+static void do_softint(unsigned long private_)
 {
         struct dec_serial       *info = (struct dec_serial *) private_;
         struct tty_struct       *tty;
@@ -634,10 +632,11 @@ static void do_softint(void *private_)
 
         if (test_and_clear_bit(RS_EVENT_WRITE_WAKEUP, &info->event)) {
                 tty_wakeup(tty);
+                wake_up_interruptible(&tty->write_wait);
         }
 }
 
-int zs_startup(struct dec_serial * info)
+static int zs_startup(struct dec_serial * info)
 {
         unsigned long flags;
 
@@ -650,7 +649,7 @@ int zs_startup(struct dec_serial * info)
                         return -ENOMEM;
         }
 
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
 
 #ifdef SERIAL_DEBUG_OPEN
         printk("starting up ttyS%d (irq %d)...", info->line, info->irq);
@@ -706,7 +705,7 @@ int zs_startup(struct dec_serial * info)
         info->xmit_cnt = info->xmit_head = info->xmit_tail = 0;
 
         info->flags |= ZILOG_INITIALIZED;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
         return 0;
 }
 
@@ -726,7 +725,7 @@ static void shutdown(struct dec_serial * info)
                info->irq);
 #endif
 
-        save_flags(flags); cli(); /* Disable interrupts */
+        spin_lock_irqsave(&zs_lock, flags);
 
         if (info->xmit_buf) {
                 free_page((unsigned long) info->xmit_buf);
@@ -749,7 +748,7 @@ static void shutdown(struct dec_serial * info)
                 set_bit(TTY_IO_ERROR, &info->tty->flags);
 
         info->flags &= ~ZILOG_INITIALIZED;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 /*
@@ -785,7 +784,7 @@ static void change_speed(struct dec_serial *info)
                         i += 15;
         }
 
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
         info->zs_baud = baud_table[i];
         if (info->zs_baud) {
                 brg = BPS_TO_BRG(info->zs_baud, zs_parms->clock/info->clk_divisor);
@@ -858,7 +857,7 @@ static void change_speed(struct dec_serial *info)
         /* Load up the new values */
         load_zsregs(info->zs_channel, info->zs_channel->curregs);
 
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 static void rs_flush_chars(struct tty_struct *tty)
@@ -874,9 +873,9 @@ static void rs_flush_chars(struct tty_struct *tty)
                 return;
 
         /* Enable transmitter */
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
         transmit_chars(info);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 static int rs_write(struct tty_struct * tty,
@@ -892,26 +891,17 @@ static int rs_write(struct tty_struct * tty,
         if (!tty || !info->xmit_buf)
                 return 0;
 
-        save_flags(flags);
         while (1) {
-                cli();
+                spin_lock_irqsave(&zs_lock, flags);
                 c = min(count, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1,
                                    SERIAL_XMIT_SIZE - info->xmit_head));
                 if (c <= 0)
                         break;
 
-                if (from_user) {
-                        down(&tmp_buf_sem);
-                        copy_from_user(tmp_buf, buf, c);
-                        c = min(c, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1,
-                                       SERIAL_XMIT_SIZE - info->xmit_head));
-                        memcpy(info->xmit_buf + info->xmit_head, tmp_buf, c);
-                        up(&tmp_buf_sem);
-                } else
-                        memcpy(info->xmit_buf + info->xmit_head, buf, c);
+                memcpy(info->xmit_buf + info->xmit_head, buf, c);
                 info->xmit_head = (info->xmit_head + c) & (SERIAL_XMIT_SIZE-1);
                 info->xmit_cnt += c;
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                 buf += c;
                 count -= c;
                 total += c;
@@ -920,7 +910,7 @@ static int rs_write(struct tty_struct * tty,
         if (info->xmit_cnt && !tty->stopped && !info->tx_stopped
             && !info->tx_active)
                 transmit_chars(info);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
         return total;
 }
 
@@ -952,9 +942,9 @@ static void rs_flush_buffer(struct tty_struct *tty)
 
         if (serial_paranoia_check(info, tty->name, "rs_flush_buffer"))
                 return;
-        cli();
+        spin_lock_irq(&zs_lock);
         info->xmit_cnt = info->xmit_head = info->xmit_tail = 0;
-        sti();
+        spin_unlock_irq(&zs_lock);
         tty_wakeup(tty);
 }
 
@@ -982,11 +972,11 @@ static void rs_throttle(struct tty_struct * tty)
                 return;
 
         if (I_IXOFF(tty)) {
-                save_flags(flags); cli();
+                spin_lock_irqsave(&zs_lock, flags);
                 info->x_char = STOP_CHAR(tty);
                 if (!info->tx_active)
                         transmit_chars(info);
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
         }
 
         if (C_CRTSCTS(tty)) {
@@ -1010,7 +1000,7 @@ static void rs_unthrottle(struct tty_struct * tty)
                 return;
 
         if (I_IXOFF(tty)) {
-                save_flags(flags); cli();
+                spin_lock_irqsave(&zs_lock, flags);
                 if (info->x_char)
                         info->x_char = 0;
                 else {
@@ -1018,7 +1008,7 @@ static void rs_unthrottle(struct tty_struct * tty)
                         if (!info->tx_active)
                                 transmit_chars(info);
                 }
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
         }
 
         if (C_CRTSCTS(tty)) {
@@ -1111,9 +1101,9 @@ static int get_lsr_info(struct dec_serial * info, unsigned int *value)
 {
         unsigned char status;
 
-        cli();
+        spin_lock(&zs_lock);
         status = read_zsreg(info->zs_channel, 0);
-        sti();
+        spin_unlock_irq(&zs_lock);
         put_user(status,value);
         return 0;
 }
@@ -1136,11 +1126,11 @@ static int rs_tiocmget(struct tty_struct *tty, struct file *file)
         if (info->zs_channel == info->zs_chan_a)
                 result = 0;
         else {
-                cli();
+                spin_lock(&zs_lock);
                 control = info->zs_chan_a->curregs[5];
                 status_a = read_zsreg(info->zs_chan_a, 0);
                 status_b = read_zsreg(info->zs_channel, 0);
-                sti();
+                spin_unlock_irq(&zs_lock);
                 result =  ((control  & RTS) ? TIOCM_RTS: 0)
                         | ((control  & DTR) ? TIOCM_DTR: 0)
                         | ((status_b & DCD) ? TIOCM_CAR: 0)
@@ -1155,8 +1145,6 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
                        unsigned int set, unsigned int clear)
 {
         struct dec_serial * info = (struct dec_serial *)tty->driver_data;
-        int error;
-        unsigned int arg, bits;
 
         if (info->hook)
                 return -ENODEV;
@@ -1170,8 +1158,7 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
         if (info->zs_channel == info->zs_chan_a)
                 return 0;
 
-        get_user(arg, value);
-        cli();
+        spin_lock(&zs_lock);
         if (set & TIOCM_RTS)
                 info->zs_chan_a->curregs[5] |= RTS;
         if (set & TIOCM_DTR)
@@ -1181,7 +1168,7 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
         if (clear & TIOCM_DTR)
                 info->zs_chan_a->curregs[5] &= ~DTR;
         write_zsreg(info->zs_chan_a, 5, info->zs_chan_a->curregs[5]);
-        sti();
+        spin_unlock_irq(&zs_lock);
         return 0;
 }
 
@@ -1198,19 +1185,18 @@ static void rs_break(struct tty_struct *tty, int break_state)
         if (!info->port)
                 return;
 
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
         if (break_state == -1)
                 info->zs_channel->curregs[5] |= SND_BRK;
         else
                 info->zs_channel->curregs[5] &= ~SND_BRK;
         write_zsreg(info->zs_channel, 5, info->zs_channel->curregs[5]);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 static int rs_ioctl(struct tty_struct *tty, struct file * file,
                     unsigned int cmd, unsigned long arg)
 {
-        int error;
         struct dec_serial * info = (struct dec_serial *)tty->driver_data;
 
         if (info->hook)
@@ -1287,10 +1273,10 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
         if (!info || serial_paranoia_check(info, tty->name, "rs_close"))
                 return;
 
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
 
         if (tty_hung_up_p(filp)) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                 return;
         }
 
@@ -1315,7 +1301,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
                 info->count = 0;
         }
         if (info->count) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                 return;
         }
         info->flags |= ZILOG_CLOSING;
@@ -1358,7 +1344,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
         }
         info->flags &= ~(ZILOG_NORMAL_ACTIVE|ZILOG_CLOSING);
         wake_up_interruptible(&info->close_wait);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 /*
@@ -1398,7 +1384,7 @@ static void rs_wait_until_sent(struct tty_struct *tty, int timeout)
 /*
  * rs_hangup() --- called by tty_hangup() when a hangup is signaled.
  */
-void rs_hangup(struct tty_struct *tty)
+static void rs_hangup(struct tty_struct *tty)
 {
         struct dec_serial * info = (struct dec_serial *)tty->driver_data;
 
@@ -1466,16 +1452,16 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
         printk("block_til_ready before block: ttyS%d, count = %d\n",
                info->line, info->count);
 #endif
-        cli();
+        spin_lock(&zs_lock);
         if (!tty_hung_up_p(filp))
                 info->count--;
-        sti();
+        spin_unlock_irq(&zs_lock);
         info->blocked_open++;
         while (1) {
-                cli();
+                spin_lock(&zs_lock);
                 if (tty->termios->c_cflag & CBAUD)
                         zs_rtsdtr(info, RTS | DTR, 1);
-                sti();
+                spin_unlock_irq(&zs_lock);
                 set_current_state(TASK_INTERRUPTIBLE);
                 if (tty_hung_up_p(filp) ||
                     !(info->flags & ZILOG_INITIALIZED)) {
@@ -1523,7 +1509,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
  * the IRQ chain.   It also performs the serial-specific
  * initialization for the tty structure.
  */
-int rs_open(struct tty_struct *tty, struct file * filp)
+static int rs_open(struct tty_struct *tty, struct file * filp)
 {
         struct dec_serial       *info;
         int                     retval, line;
@@ -1706,7 +1692,7 @@ static void __init probe_sccs(void)
                 }
         }
 
-        save_and_cli(flags);
+        spin_lock_irqsave(&zs_lock, flags);
         for (n = 0; n < zs_channels_found; n++) {
                 if (n % 2 == 0) {
                         write_zsreg(zs_soft[n].zs_chan_a, R9, FHWRES);
@@ -1716,7 +1702,7 @@ static void __init probe_sccs(void)
                 load_zsregs(zs_soft[n].zs_channel,
                             zs_soft[n].zs_channel->curregs);
         }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 
 static struct tty_operations serial_ops = {
@@ -1749,9 +1735,6 @@ int __init zs_init(void)
         if(!BUS_PRESENT)
                 return -ENODEV;
 
-        /* Setup base handler, and timer table. */
-        init_bh(SERIAL_BH, do_serial_bh);
-
         /* Find out how many Z8530 SCCs we have */
         if (zs_chain == 0)
                 probe_sccs();
@@ -1800,8 +1783,7 @@ int __init zs_init(void)
                 info->event = 0;
                 info->count = 0;
                 info->blocked_open = 0;
-                info->tqueue.routine = do_softint;
-                info->tqueue.data = info;
+                tasklet_init(&info->tlet, do_softint, (unsigned long)info);
                 init_waitqueue_head(&info->open_wait);
                 init_waitqueue_head(&info->close_wait);
                 printk("ttyS%02d at 0x%08x (irq = %d) is a Z85C30 SCC\n",
@@ -1833,8 +1815,7 @@ int __init zs_init(void)
 /*
  * polling I/O routines
  */
-static int
-zs_poll_tx_char(void *handle, unsigned char ch)
+static int zs_poll_tx_char(void *handle, unsigned char ch)
 {
         struct dec_serial *info = handle;
         struct dec_zschannel *chan = info->zs_channel;
@@ -1857,8 +1838,7 @@ zs_poll_tx_char(void *handle, unsigned char ch)
                 return -ENODEV;
 }
 
-static int
-zs_poll_rx_char(void *handle)
+static int zs_poll_rx_char(void *handle)
 {
         struct dec_serial *info = handle;
         struct dec_zschannel *chan = info->zs_channel;
@@ -2037,7 +2017,7 @@ static int __init serial_console_setup(struct console *co, char *options)
         }
         co->cflag = cflag;
 
-        save_and_cli(flags);
+        spin_lock_irqsave(&zs_lock, flags);
 
         /*
          * Set up the baud rate generator.
@@ -2092,7 +2072,7 @@ static int __init serial_console_setup(struct console *co, char *options)
         zs_soft[co->index].clk_divisor = clk_divisor;
         zs_soft[co->index].zs_baud = get_zsbaud(&zs_soft[co->index]);
 
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 
         return 0;
 }
@@ -2229,5 +2209,3 @@ void __init zs_kgdb_hook(int tty_num)
         set_debug_traps(); /* init stub */
 }
 #endif /* ifdef CONFIG_KGDB */
-
-
diff --git a/drivers/tc/zs.h b/drivers/tc/zs.h
index c52edffa6049..13512200ceba 100644
--- a/drivers/tc/zs.h
+++ b/drivers/tc/zs.h
@@ -6,14 +6,14 @@
  *
  * Copyright (C) 1996 Paul Mackerras (Paul.Mackerras@cs.anu.edu.au)
  * Copyright (C) 1995 David S. Miller (davem@caip.rutgers.edu)
- * Copyright (C) 2004  Maciej W. Rozycki
+ * Copyright (C) 2004, 2005  Maciej W. Rozycki
  */
 #ifndef _DECSERIAL_H
 #define _DECSERIAL_H
 
 #include <asm/dec/serial.h>
 
-#define NUM_ZSREGS    16
+#define NUM_ZSREGS 16
 
 struct serial_struct {
         int     type;
@@ -139,8 +139,7 @@ struct dec_serial {
         int                     xmit_head;
         int                     xmit_tail;
         int                     xmit_cnt;
-        struct tq_struct        tqueue;
-        struct tq_struct        tqueue_hangup;
+        struct tasklet_struct   tlet;
         wait_queue_head_t       open_wait;
         wait_queue_head_t       close_wait;
 };
@@ -282,7 +281,7 @@ struct dec_serial {
 #define DLC     4       /* Disable Lower Chain */
 #define MIE     8       /* Master Interrupt Enable */
 #define STATHI  0x10    /* Status high */
-#define SOFTACK 0x20    /* Software Interrupt Acknowledge */
+#define SOFTACK 0x20    /* Software Interrupt Acknowledge */
 #define NORESET 0       /* No reset on write to R9 */
 #define CHRB    0x40    /* Reset channel B */
 #define CHRA    0x80    /* Reset channel A */
@@ -395,8 +394,8 @@ struct dec_serial {
 /* Read Register 15 (value of WR 15) */
 
 /* Misc macros */
-#define ZS_CLEARERR(channel)    (write_zsreg(channel, 0, ERR_RES))
-#define ZS_CLEARFIFO(channel)   do { volatile unsigned char garbage; \
+#define ZS_CLEARERR(channel)    (write_zsreg(channel, 0, ERR_RES))
+#define ZS_CLEARFIFO(channel)   do { volatile unsigned char garbage; \
                                      garbage = read_zsdata(channel); \
                                      garbage = read_zsdata(channel); \
                                      garbage = read_zsdata(channel); \
diff --git a/drivers/usb/atm/Makefile b/drivers/usb/atm/Makefile
index 751f297be2ef..85099718c683 100644
--- a/drivers/usb/atm/Makefile
+++ b/drivers/usb/atm/Makefile
@@ -6,3 +6,7 @@ obj-$(CONFIG_USB_CXACRU)	+= cxacru.o
 obj-$(CONFIG_USB_SPEEDTOUCH)    += speedtch.o
 obj-$(CONFIG_USB_ATM)           += usbatm.o
 obj-$(CONFIG_USB_XUSBATM)       += xusbatm.o
+
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/atm/usbatm.h b/drivers/usb/atm/usbatm.h
index 936646457935..1adacd60d713 100644
--- a/drivers/usb/atm/usbatm.h
+++ b/drivers/usb/atm/usbatm.h
@@ -27,14 +27,9 @@
 #include <linux/config.h>
 
 /*
-#define DEBUG
 #define VERBOSE_DEBUG
 */
 
-#if !defined (DEBUG) && defined (CONFIG_USB_DEBUG)
-#       define DEBUG
-#endif
-
 #include <asm/semaphore.h>
 #include <linux/atm.h>
 #include <linux/atmdev.h>
diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile
index dd1c4d2a0c31..86d5c380892d 100644
--- a/drivers/usb/core/Makefile
+++ b/drivers/usb/core/Makefile
@@ -14,3 +14,7 @@ ifeq ($(CONFIG_USB_DEVICEFS),y)
 endif
 
 obj-$(CONFIG_USB)       += usbcore.o
+
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 57e800ac3cee..419c9943a7cb 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -15,14 +15,6 @@
 #include <asm/scatterlist.h>
 #include <linux/dma-mapping.h>
 #include <linux/dmapool.h>
-
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/usb.h>
 #include "hcd.h"
 
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 993019500cc3..a9d89c78cc20 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -1,9 +1,4 @@
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG
-#endif
-
 #include <linux/usb.h>
 #include <linux/module.h>
 #include <linux/init.h>
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 942cd437dc48..b1d6e9af732d 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1392,13 +1392,13 @@ static int proc_ioctl_default(struct dev_state *ps, void __user *arg)
 }
 
 #ifdef CONFIG_COMPAT
-static int proc_ioctl_compat(struct dev_state *ps, void __user *arg)
+static int proc_ioctl_compat(struct dev_state *ps, compat_uptr_t arg)
 {
         struct usbdevfs_ioctl32 __user *uioc;
         struct usbdevfs_ioctl ctrl;
         u32 udata;
 
-        uioc = compat_ptr(arg);
+        uioc = compat_ptr((long)arg);
         if (get_user(ctrl.ifno, &uioc->ifno) ||
             get_user(ctrl.ioctl_code, &uioc->ioctl_code) ||
             __get_user(udata, &uioc->data))
@@ -1511,7 +1511,7 @@ static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
 
         case USBDEVFS_IOCTL32:
                 snoop(&dev->dev, "%s: IOCTL\n", __FUNCTION__);
-                ret = proc_ioctl_compat(ps, p);
+                ret = proc_ioctl_compat(ps, (compat_uptr_t)(long)p);
                 break;
 #endif
 
diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c
index e695308095ae..37b13368c814 100644
--- a/drivers/usb/core/file.c
+++ b/drivers/usb/core/file.c
@@ -19,12 +19,6 @@
 #include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/errno.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 
 #include "usb.h"
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 84d9e69329bb..7feb829362d6 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -17,13 +17,6 @@
  */
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/pci.h>
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 6c7ca5b08cd6..5e5f65a475ab 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -23,11 +23,6 @@
  */
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG
-#endif
-
 #include <linux/module.h>
 #include <linux/version.h>
 #include <linux/kernel.h>
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 256d9f698715..840727948d84 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -9,11 +9,6 @@
  */
 
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/module.h>
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
index 12f490fdee8f..c44bbedec817 100644
--- a/drivers/usb/core/inode.c
+++ b/drivers/usb/core/inode.c
@@ -46,7 +46,6 @@
 
 static struct super_operations usbfs_ops;
 static struct file_operations default_file_operations;
-static struct inode_operations usbfs_dir_inode_operations;
 static struct vfsmount *usbfs_mount;
 static int usbfs_mount_count;   /* = 0 */
 static int ignore_mount = 0;
@@ -262,7 +261,7 @@ static struct inode *usbfs_get_inode (struct super_block *sb, int mode, dev_t de
                         inode->i_fop = &default_file_operations;
                         break;
                 case S_IFDIR:
-                        inode->i_op = &usbfs_dir_inode_operations;
+                        inode->i_op = &simple_dir_inode_operations;
                         inode->i_fop = &simple_dir_operations;
 
                         /* directory inodes start off with i_nlink == 2 (for "." entry) */
@@ -417,10 +416,6 @@ static struct file_operations default_file_operations = {
         .llseek =       default_file_lseek,
 };
 
-static struct inode_operations usbfs_dir_inode_operations = {
-        .lookup =       simple_lookup,
-};
-
 static struct super_operations usbfs_ops = {
         .statfs =       simple_statfs,
         .drop_inode =   generic_delete_inode,
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 644a3d4f12aa..fe74f99ca5f4 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -3,13 +3,6 @@
  */
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/pci.h>  /* for scatterlist macros */
 #include <linux/usb.h>
 #include <linux/module.h>
@@ -1457,12 +1450,11 @@ free_interfaces:
                  */
                 for (i = 0; i < nintf; ++i) {
                         struct usb_interface *intf = cp->interface[i];
-                        struct usb_host_interface *alt = intf->cur_altsetting;
 
                         dev_dbg (&dev->dev,
                                 "adding %s (config #%d, interface %d)\n",
                                 intf->dev.bus_id, configuration,
-                                alt->desc.bInterfaceNumber);
+                                intf->cur_altsetting->desc.bInterfaceNumber);
                         ret = device_add (&intf->dev);
                         if (ret != 0) {
                                 dev_err(&dev->dev,
diff --git a/drivers/usb/core/notify.c b/drivers/usb/core/notify.c
index 37da059eced7..fbbebab52fbd 100644
--- a/drivers/usb/core/notify.c
+++ b/drivers/usb/core/notify.c
@@ -12,13 +12,7 @@
 #include <linux/config.h>
 #include <linux/kernel.h>
 #include <linux/notifier.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
-
 #include "usb.h"
 
 
diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index edd83e014452..71d881327e88 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -12,14 +12,7 @@
 
 #include <linux/config.h>
 #include <linux/kernel.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
-
 #include "usb.h"
 
 /* endpoint stuff */
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index f2a1fed2a802..081796726b95 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -4,12 +4,6 @@
 #include <linux/bitops.h>
 #include <linux/slab.h>
 #include <linux/init.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "hcd.h"
 
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 0eefff7bcb3c..e197ce9353de 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -22,13 +22,6 @@
  */
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/module.h>
 #include <linux/string.h>
 #include <linux/bitops.h>
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 1e407745c115..c655d46c8aed 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -944,7 +944,7 @@ static int dummy_udc_suspend (struct platform_device *dev, pm_message_t state)
         set_link_state (dum);
         spin_unlock_irq (&dum->lock);
 
-        dev->power.power_state = state;
+        dev->dev.power.power_state = state;
         usb_hcd_poll_rh_status (dummy_to_hcd (dum));
         return 0;
 }
@@ -1904,7 +1904,7 @@ static int dummy_hcd_probe (struct platform_device *dev)
         struct usb_hcd          *hcd;
         int                     retval;
 
-        dev_info (dev, "%s, driver " DRIVER_VERSION "\n", driver_desc);
+        dev_info(&dev->dev, "%s, driver " DRIVER_VERSION "\n", driver_desc);
 
         hcd = usb_create_hcd (&dummy_hcd, &dev->dev, dev->dev.bus_id);
         if (!hcd)
diff --git a/drivers/usb/host/ohci-lh7a404.c b/drivers/usb/host/ohci-lh7a404.c
index 081ec3f5cff4..3959ccc88332 100644
--- a/drivers/usb/host/ohci-lh7a404.c
+++ b/drivers/usb/host/ohci-lh7a404.c
@@ -219,7 +219,7 @@ static int ohci_hcd_lh7a404_drv_probe(struct platform_device *pdev)
 
 static int ohci_hcd_lh7a404_drv_remove(struct platform_device *pdev)
 {
-        struct usb_hcd *hcd = platform_get_drvdata(dev);
+        struct usb_hcd *hcd = platform_get_drvdata(pdev);
 
         usb_hcd_lh7a404_remove(hcd, pdev);
         return 0;
diff --git a/drivers/usb/host/ohci-ppc-soc.c b/drivers/usb/host/ohci-ppc-soc.c
index 18755766e406..2ec6a78bd65e 100644
--- a/drivers/usb/host/ohci-ppc-soc.c
+++ b/drivers/usb/host/ohci-ppc-soc.c
@@ -185,7 +185,7 @@ static int ohci_hcd_ppc_soc_drv_probe(struct platform_device *pdev)
 
 static int ohci_hcd_ppc_soc_drv_remove(struct platform_device *pdev)
 {
-        struct usb_hcd *hcd = platform_get_drvdata(dev);
+        struct usb_hcd *hcd = platform_get_drvdata(pdev);
 
         usb_hcd_ppc_soc_remove(hcd, pdev);
         return 0;
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
index 61a2604cce4f..950543aa5ac7 100644
--- a/drivers/usb/image/microtek.c
+++ b/drivers/usb/image/microtek.c
@@ -327,6 +327,18 @@ static inline void mts_urb_abort(struct mts_desc* desc) {
         usb_kill_urb( desc->urb );
 }
 
+static int mts_slave_alloc (struct scsi_device *s)
+{
+        s->inquiry_len = 0x24;
+        return 0;
+}
+
+static int mts_slave_configure (struct scsi_device *s)
+{
+        blk_queue_dma_alignment(s->request_queue, (512 - 1));
+        return 0;
+}
+
 static int mts_scsi_abort (Scsi_Cmnd *srb)
 {
         struct mts_desc* desc = (struct mts_desc*)(srb->device->host->hostdata[0]);
@@ -411,7 +423,7 @@ static void mts_transfer_done( struct urb *transfer, struct pt_regs *regs )
         MTS_INT_INIT();
 
         context->srb->result &= MTS_SCSI_ERR_MASK;
-        context->srb->result |= (unsigned)context->status<<1;
+        context->srb->result |= (unsigned)(*context->scsi_status)<<1;
 
         mts_transfer_cleanup(transfer);
 
@@ -427,7 +439,7 @@ static void mts_get_status( struct urb *transfer )
         mts_int_submit_urb(transfer,
                            usb_rcvbulkpipe(context->instance->usb_dev,
                                            context->instance->ep_response),
-                           &context->status,
+                           context->scsi_status,
                            1,
                            mts_transfer_done );
 }
@@ -481,7 +493,7 @@ static void mts_command_done( struct urb *transfer, struct pt_regs *regs )
                                            context->data_pipe,
                                            context->data,
                                            context->data_length,
-                                           context->srb->use_sg ? mts_do_sg : mts_data_done);
+                                           context->srb->use_sg > 1 ? mts_do_sg : mts_data_done);
                 } else {
                         mts_get_status(transfer);
                 }
@@ -627,7 +639,6 @@ int mts_scsi_queuecommand( Scsi_Cmnd *srb, mts_scsi_cmnd_callback callback )
                         callback(srb);
 
         }
-
 out:
         return err;
 }
@@ -645,6 +656,9 @@ static struct scsi_host_template mts_scsi_host_template = {
         .cmd_per_lun =          1,
         .use_clustering =       1,
         .emulated =             1,
+        .slave_alloc =          mts_slave_alloc,
+        .slave_configure =      mts_slave_configure,
+        .max_sectors=           256, /* 128 K */
 };
 
 struct vendor_product
@@ -771,8 +785,8 @@ static int mts_usb_probe(struct usb_interface *intf,
                 MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );
                 return -ENODEV;
         }
-        
-        
+
+
         new_desc = kzalloc(sizeof(struct mts_desc), GFP_KERNEL);
         if (!new_desc)
                 goto out;
@@ -781,6 +795,10 @@ static int mts_usb_probe(struct usb_interface *intf,
         if (!new_desc->urb)
                 goto out_kfree;
 
+        new_desc->context.scsi_status = kmalloc(1, GFP_KERNEL);
+        if (!new_desc->context.scsi_status)
+                goto out_kfree2;
+
         new_desc->usb_dev = dev;
         new_desc->usb_intf = intf;
         init_MUTEX(&new_desc->lock);
@@ -817,6 +835,8 @@ static int mts_usb_probe(struct usb_interface *intf,
         usb_set_intfdata(intf, new_desc);
         return 0;
 
+ out_kfree2:
+        kfree(new_desc->context.scsi_status);
  out_free_urb:
         usb_free_urb(new_desc->urb);
  out_kfree:
@@ -836,6 +856,7 @@ static void mts_usb_disconnect (struct usb_interface *intf)
 
         scsi_host_put(desc->host);
         usb_free_urb(desc->urb);
+        kfree(desc->context.scsi_status);
         kfree(desc);
 }
 
@@ -856,5 +877,3 @@ module_exit(microtek_drv_exit);
 MODULE_AUTHOR( DRIVER_AUTHOR );
 MODULE_DESCRIPTION( DRIVER_DESC );
 MODULE_LICENSE("GPL");
-
-
diff --git a/drivers/usb/image/microtek.h b/drivers/usb/image/microtek.h
index 3271deb8c001..926d4bdc6746 100644
--- a/drivers/usb/image/microtek.h
+++ b/drivers/usb/image/microtek.h
@@ -22,7 +22,7 @@ struct mts_transfer_context
         int data_pipe;
         int fragment;
 
-        u8 status; /* status returned from ep_response after command completion */
+        u8 *scsi_status; /* status returned from ep_response after command completion */
 };
 
 
diff --git a/drivers/usb/input/Makefile b/drivers/usb/input/Makefile
index 5e03b93f29f6..07cb17db42fc 100644
--- a/drivers/usb/input/Makefile
+++ b/drivers/usb/input/Makefile
@@ -42,3 +42,7 @@ obj-$(CONFIG_USB_ACECAD)	+= acecad.o
 obj-$(CONFIG_USB_YEALINK)       += yealink.o
 obj-$(CONFIG_USB_XPAD)          += xpad.o
 obj-$(CONFIG_USB_APPLETOUCH)    += appletouch.o
+
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
index 79ddce4555ab..45f3130fadea 100644
--- a/drivers/usb/input/hid-core.c
+++ b/drivers/usb/input/hid-core.c
@@ -1318,6 +1318,7 @@ void hid_init_reports(struct hid_device *hid)
 #define USB_DEVICE_ID_WACOM_PTU         0x0003
 #define USB_DEVICE_ID_WACOM_INTUOS3     0x00B0
 #define USB_DEVICE_ID_WACOM_CINTIQ      0x003F
+#define USB_DEVICE_ID_WACOM_DTF         0x00C0
 
 #define USB_VENDOR_ID_ACECAD            0x0460
 #define USB_DEVICE_ID_ACECAD_FLAIR      0x0004
@@ -1524,6 +1525,9 @@ static struct hid_blacklist {
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 3, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 4, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 5, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 7, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 8, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 9, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 1, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 2, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 3, HID_QUIRK_IGNORE },
@@ -1531,11 +1535,19 @@ static struct hid_blacklist {
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 5, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 7, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 1, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 2, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 3, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 4, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE + 5, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE + 6, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PTU, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 1, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 2, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 5, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_CINTIQ, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_DTF, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_4_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_1_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
 
diff --git a/drivers/usb/input/itmtouch.c b/drivers/usb/input/itmtouch.c
index 3b581853cf10..4a50acb39d29 100644
--- a/drivers/usb/input/itmtouch.c
+++ b/drivers/usb/input/itmtouch.c
@@ -40,13 +40,6 @@
  *****************************************************************************/
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/input.h>
diff --git a/drivers/usb/input/keyspan_remote.c b/drivers/usb/input/keyspan_remote.c
index 5b8d65f62abf..a32cfe51b77d 100644
--- a/drivers/usb/input/keyspan_remote.c
+++ b/drivers/usb/input/keyspan_remote.c
@@ -160,7 +160,8 @@ static int keyspan_load_tester(struct usb_keyspan* dev, int bits_needed)
          * though so it's not too big a deal
          */
         if (dev->data.pos >= dev->data.len) {
-                dev_dbg(&dev->udev, "%s - Error ran out of data. pos: %d, len: %d\n",
+                dev_dbg(&dev->udev->dev,
+                        "%s - Error ran out of data. pos: %d, len: %d\n",
                         __FUNCTION__, dev->data.pos, dev->data.len);
                 return -1;
         }
@@ -306,7 +307,7 @@ static void keyspan_check_data(struct usb_keyspan *remote, struct pt_regs *regs)
                         err("Bad message recieved, no stop bit found.\n");
                 }
 
-                dev_dbg(&remote->udev,
+                dev_dbg(&remote->udev->dev,
                         "%s found valid message: system: %d, button: %d, toggle: %d\n",
                         __FUNCTION__, message.system, message.button, message.toggle);
 
diff --git a/drivers/usb/input/mtouchusb.c b/drivers/usb/input/mtouchusb.c
index 7fce526560ca..52cc18cd247d 100644
--- a/drivers/usb/input/mtouchusb.c
+++ b/drivers/usb/input/mtouchusb.c
@@ -40,13 +40,6 @@
  *****************************************************************************/
 
 #include <linux/config.h>
-
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
-
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/input.h>
diff --git a/drivers/usb/input/pid.c b/drivers/usb/input/pid.c
index dca5ee93a4ef..19e015d171aa 100644
--- a/drivers/usb/input/pid.c
+++ b/drivers/usb/input/pid.c
@@ -37,8 +37,6 @@
 #include "hid.h"
 #include "pid.h"
 
-#define DEBUG
-
 #define CHECK_OWNERSHIP(i, hid_pid)     \
         ((i) < FF_EFFECTS_MAX && i >= 0 && \
         test_bit(FF_PID_FLAGS_USED, &hid_pid->effects[(i)].flags) && \
diff --git a/drivers/usb/input/touchkitusb.c b/drivers/usb/input/touchkitusb.c
index 0043e6ebcd1f..7420c6b84284 100644
--- a/drivers/usb/input/touchkitusb.c
+++ b/drivers/usb/input/touchkitusb.c
@@ -30,10 +30,6 @@
 #include <linux/input.h>
 #include <linux/module.h>
 #include <linux/init.h>
-
-#if !defined(DEBUG) && defined(CONFIG_USB_DEBUG)
-#define DEBUG
-#endif
 #include <linux/usb.h>
 #include <linux/usb_input.h>
 
diff --git a/drivers/usb/input/wacom.c b/drivers/usb/input/wacom.c
index ea0f75773ae1..aea1cfae34cc 100644
--- a/drivers/usb/input/wacom.c
+++ b/drivers/usb/input/wacom.c
@@ -52,8 +52,10 @@
  *    v1.30.1 (pi) - Added Graphire3 support
  *      v1.40 (pc) - Add support for several new devices, fix eraser reporting, ...
  *      v1.43 (pc) - Added support for Cintiq 21UX
-                   - Fixed a Graphire bug
-                   - Merged wacom_intuos3_irq into wacom_intuos_irq
+ *                 - Fixed a Graphire bug
+ *                 - Merged wacom_intuos3_irq into wacom_intuos_irq
+ *      v1.44 (pc) - Added support for Graphire4, Cintiq 710, Intuos3 6x11, etc.
+ *                 - Report Device IDs
  */
 
 /*
@@ -76,7 +78,7 @@
 /*
  * Version Information
  */
-#define DRIVER_VERSION "v1.43"
+#define DRIVER_VERSION "v1.44"
 #define DRIVER_AUTHOR "Vojtech Pavlik <vojtech@ucw.cz>"
 #define DRIVER_DESC "USB Wacom Graphire and Wacom Intuos tablet driver"
 #define DRIVER_LICENSE "GPL"
@@ -86,10 +88,14 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE(DRIVER_LICENSE);
 
 #define USB_VENDOR_ID_WACOM     0x056a
+#define STYLUS_DEVICE_ID        0x02
+#define CURSOR_DEVICE_ID        0x06
+#define ERASER_DEVICE_ID        0x0A
 
 enum {
         PENPARTNER = 0,
         GRAPHIRE,
+        G4,
         PL,
         INTUOS,
         INTUOS3,
@@ -116,6 +122,7 @@ struct wacom {
         struct urb *irq;
         struct wacom_features *features;
         int tool[2];
+        int id[2];
         __u32 serial[2];
         char phys[32];
 };
@@ -136,7 +143,7 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
         struct wacom *wacom = urb->context;
         unsigned char *data = wacom->data;
         struct input_dev *dev = wacom->dev;
-        int prox, pressure;
+        int prox, pressure, id;
         int retval;
 
         switch (urb->status) {
@@ -163,6 +170,7 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
 
         input_regs(dev, regs);
 
+        id = ERASER_DEVICE_ID;
         if (prox) {
 
                 pressure = (signed char)((data[7] << 1) | ((data[4] >> 2) & 1));
@@ -177,11 +185,15 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
                  * an out of proximity for previous tool then a in for new tool.
                  */
                 if (!wacom->tool[0]) {
-                        /* Going into proximity select tool */
-                        wacom->tool[1] = (data[4] & 0x20)? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
+                        /* Eraser bit set for DTF */
+                        if (data[1] & 0x10)
+                                wacom->tool[1] = BTN_TOOL_RUBBER;
+                        else
+                                /* Going into proximity select tool */
+                                wacom->tool[1] = (data[4] & 0x20) ? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
                 } else {
                         /* was entered with stylus2 pressed */
-                        if (wacom->tool[1] == BTN_TOOL_RUBBER && !(data[4] & 0x20) ) {
+                        if (wacom->tool[1] == BTN_TOOL_RUBBER && !(data[4] & 0x20)) {
                                 /* report out proximity for previous tool */
                                 input_report_key(dev, wacom->tool[1], 0);
                                 input_sync(dev);
@@ -192,8 +204,9 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
                 if (wacom->tool[1] != BTN_TOOL_RUBBER) {
                         /* Unknown tool selected default to pen tool */
                         wacom->tool[1] = BTN_TOOL_PEN;
+                        id = STYLUS_DEVICE_ID;
                 }
-                input_report_key(dev, wacom->tool[1], prox); /* report in proximity for tool */
+                input_report_key(dev, wacom->tool[1], id); /* report in proximity for tool */
                 input_report_abs(dev, ABS_X, data[3] | (data[2] << 7) | ((data[1] & 0x03) << 14));
                 input_report_abs(dev, ABS_Y, data[6] | (data[5] << 7) | ((data[4] & 0x03) << 14));
                 input_report_abs(dev, ABS_PRESSURE, pressure);
@@ -250,10 +263,10 @@ static void wacom_ptu_irq(struct urb *urb, struct pt_regs *regs)
 
         input_regs(dev, regs);
         if (data[1] & 0x04) {
-                input_report_key(dev, BTN_TOOL_RUBBER, data[1] & 0x20);
+                input_report_key(dev, BTN_TOOL_RUBBER, (data[1] & 0x20) ? ERASER_DEVICE_ID : 0);
                 input_report_key(dev, BTN_TOUCH, data[1] & 0x08);
         } else {
-                input_report_key(dev, BTN_TOOL_PEN, data[1] & 0x20);
+                input_report_key(dev, BTN_TOOL_PEN, (data[1] & 0x20) ? STYLUS_DEVICE_ID : 0);
                 input_report_key(dev, BTN_TOUCH, data[1] & 0x01);
         }
         input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[2]));
@@ -299,7 +312,7 @@ static void wacom_penpartner_irq(struct urb *urb, struct pt_regs *regs)
         }
 
         input_regs(dev, regs);
-        input_report_key(dev, BTN_TOOL_PEN, 1);
+        input_report_key(dev, BTN_TOOL_PEN, STYLUS_DEVICE_ID);
         input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[1]));
         input_report_abs(dev, ABS_Y, le16_to_cpu(*(__le16 *) &data[3]));
         input_report_abs(dev, ABS_PRESSURE, (signed char)data[6] + 127);
@@ -319,7 +332,7 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
         struct wacom *wacom = urb->context;
         unsigned char *data = wacom->data;
         struct input_dev *dev = wacom->dev;
-        int x, y;
+        int x, y, id, rw;
         int retval;
 
         switch (urb->status) {
@@ -344,6 +357,7 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
 
         input_regs(dev, regs);
 
+        id = STYLUS_DEVICE_ID;
         if (data[1] & 0x10) { /* in prox */
 
                 switch ((data[1] >> 5) & 3) {
@@ -354,18 +368,27 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
 
                         case 1: /* Rubber */
                                 wacom->tool[0] = BTN_TOOL_RUBBER;
+                                id = ERASER_DEVICE_ID;
                                 break;
 
                         case 2: /* Mouse with wheel */
                                 input_report_key(dev, BTN_MIDDLE, data[1] & 0x04);
-                                input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
+                                if (wacom->features->type == G4) {
+                                        rw = data[7] & 0x04 ? -(data[7] & 0x03) : (data[7] & 0x03);
+                                        input_report_rel(dev, REL_WHEEL, rw);
+                                } else
+                                        input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
                                 /* fall through */
 
                         case 3: /* Mouse without wheel */
                                 wacom->tool[0] = BTN_TOOL_MOUSE;
+                                id = CURSOR_DEVICE_ID;
                                 input_report_key(dev, BTN_LEFT, data[1] & 0x01);
                                 input_report_key(dev, BTN_RIGHT, data[1] & 0x02);
-                                input_report_abs(dev, ABS_DISTANCE, data[7]);
+                                if (wacom->features->type == G4)
+                                        input_report_abs(dev, ABS_DISTANCE, data[6]);
+                                else
+                                        input_report_abs(dev, ABS_DISTANCE, data[7]);
                                 break;
                 }
         }
@@ -376,16 +399,50 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                 input_report_abs(dev, ABS_X, x);
                 input_report_abs(dev, ABS_Y, y);
                 if (wacom->tool[0] != BTN_TOOL_MOUSE) {
-                        input_report_abs(dev, ABS_PRESSURE, le16_to_cpu(*(__le16 *) &data[6]));
+                        input_report_abs(dev, ABS_PRESSURE, data[6] | ((data[7] & 0x01) << 8));
                         input_report_key(dev, BTN_TOUCH, data[1] & 0x01);
                         input_report_key(dev, BTN_STYLUS, data[1] & 0x02);
                         input_report_key(dev, BTN_STYLUS2, data[1] & 0x04);
                 }
         }
 
-        input_report_key(dev, wacom->tool[0], data[1] & 0x10);
+        input_report_key(dev, wacom->tool[0], (data[1] & 0x10) ? id : 0);
         input_sync(dev);
 
+        /* send pad data */
+        if (wacom->features->type == G4) {
+                /* fist time sending pad data */
+                if (wacom->tool[1] != BTN_TOOL_FINGER) {
+                        wacom->id[1] = 0;
+                        wacom->serial[1] = (data[7] & 0x38) >> 2;
+                }
+                if (data[7] & 0xf8) {
+                        input_report_key(dev, BTN_0, (data[7] & 0x40));
+                        input_report_key(dev, BTN_4, (data[7] & 0x80));
+                        if (((data[7] & 0x38) >> 2) == (wacom->serial[1] & 0x0e))
+                                /* alter REL_WHEEL value so X apps can get it */
+                                wacom->serial[1] += (wacom->serial[1] & 0x01) ? -1 : 1;
+                        else
+                                 wacom->serial[1] = (data[7] & 0x38 ) >> 2;
+
+                        /* don't alter the value when there is no wheel event */
+                        if (wacom->serial[1] == 1)
+                                wacom->serial[1] = 0;
+                        rw = wacom->serial[1];
+                        rw = (rw & 0x08) ? -(rw & 0x07) : (rw & 0x07);
+                        input_report_rel(dev, REL_WHEEL, rw);
+                        wacom->tool[1] = BTN_TOOL_FINGER;
+                        wacom->id[1] = data[7] & 0xf8;
+                        input_report_key(dev, wacom->tool[1], 0xf0);
+                        input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
+                } else if (wacom->id[1]) {
+                        wacom->id[1] = 0;
+                        wacom->serial[1] = 0;
+                        input_report_key(dev, wacom->tool[1], 0);
+                        input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
+                }
+                input_sync(dev);
+        }
  exit:
         retval = usb_submit_urb (urb, GFP_ATOMIC);
         if (retval)
@@ -410,7 +467,8 @@ static int wacom_intuos_inout(struct urb *urb)
                         (data[4] << 20) + (data[5] << 12) +
                         (data[6] << 4) + (data[7] >> 4);
 
-                switch ((data[2] << 4) | (data[3] >> 4)) {
+                wacom->id[idx] = (data[2] << 4) | (data[3] >> 4);
+                switch (wacom->id[idx]) {
                         case 0x812: /* Inking pen */
                         case 0x801: /* Intuos3 Inking pen */
                         case 0x012:
@@ -458,7 +516,7 @@ static int wacom_intuos_inout(struct urb *urb)
                         default: /* Unknown tool */
                                 wacom->tool[idx] = BTN_TOOL_PEN;
                 }
-                input_report_key(dev, wacom->tool[idx], 1);
+                input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
                 input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
                 input_sync(dev);
                 return 1;
@@ -637,7 +695,7 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
                 }
         }
 
-        input_report_key(dev, wacom->tool[idx], 1);
+        input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
         input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
         input_sync(dev);
 
@@ -655,6 +713,13 @@ static struct wacom_features wacom_features[] = {
         { "Wacom Graphire2 5x7", 8,  13918, 10206,  511, 32, GRAPHIRE,   wacom_graphire_irq },
         { "Wacom Graphire3",     8,  10208,  7424,  511, 32, GRAPHIRE,   wacom_graphire_irq },
         { "Wacom Graphire3 6x8", 8,  16704, 12064,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Graphire4 4x5", 8,  10208,  7424,  511, 32, G4,         wacom_graphire_irq },
+        { "Wacom Graphire4 6x8", 8,  16704, 12064,  511, 32, G4,         wacom_graphire_irq },
+        { "Wacom Volito",        8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom PenStation2",   8,   3250,  2320,  255, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Volito2 4x5",   8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Volito2 2x3",   8,   3248,  2320,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom PenPartner2",   8,   3250,  2320,  255, 32, GRAPHIRE,   wacom_graphire_irq },
         { "Wacom Intuos 4x5",   10,  12700, 10600, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos 6x8",   10,  20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos 9x12",  10,  30480, 24060, 1023, 15, INTUOS,     wacom_intuos_irq },
@@ -666,16 +731,20 @@ static struct wacom_features wacom_features[] = {
         { "Wacom PL600SX",       8,   6260,  5016,  255, 32, PL,         wacom_pl_irq },
         { "Wacom PL550",         8,   6144,  4608,  511, 32, PL,         wacom_pl_irq },
         { "Wacom PL800",         8,   7220,  5780,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL700",         8,   6758,  5406,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL510",         8,   6282,  4762,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL710",         8,  34080, 27660,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom DTF720",        8,   6858,  5506,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom Cintiq Partner",8,  20480, 15360,  511, 32, PL,         wacom_ptu_irq },
         { "Wacom Intuos2 4x5",   10, 12700, 10600, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos2 9x12",  10, 30480, 24060, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos2 12x12", 10, 30480, 31680, 1023, 15, INTUOS,     wacom_intuos_irq },
         { "Wacom Intuos2 12x18", 10, 45720, 31680, 1023, 15, INTUOS,     wacom_intuos_irq },
-        { "Wacom Volito",        8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
-        { "Wacom Cintiq Partner",8,  20480, 15360,  511, 32, PL,         wacom_ptu_irq },
         { "Wacom Intuos3 4x5",   10, 25400, 20320, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Intuos3 6x8",   10, 40640, 30480, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Intuos3 9x12",  10, 60960, 45720, 1023, 15, INTUOS3,    wacom_intuos_irq },
+        { "Wacom Intuos3 6x11",  10, 54204, 31750, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Cintiq 21UX",   10, 87200, 65600, 1023, 15, CINTIQ,     wacom_intuos_irq },
         { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
         { }
@@ -688,6 +757,13 @@ static struct usb_device_id wacom_ids[] = {
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x12) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x13) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x14) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x15) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x16) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x60) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x61) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x62) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x63) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x64) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x20) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x21) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x22) },
@@ -699,16 +775,20 @@ static struct usb_device_id wacom_ids[] = {
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x33) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x34) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x35) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x37) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x38) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x39) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC0) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x41) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x42) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x43) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x44) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x45) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x60) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB0) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB1) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB2) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB5) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x3F) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x47) },
         { }
@@ -779,6 +859,13 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
         input_set_abs_params(input_dev, ABS_PRESSURE, 0, wacom->features->pressure_max, 0, 0);
 
         switch (wacom->features->type) {
+                case G4:
+                        input_dev->evbit[0] |= BIT(EV_MSC);
+                        input_dev->mscbit[0] |= BIT(MSC_SERIAL);
+                        input_dev->keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_FINGER);
+                        input_dev->keybit[LONG(BTN_LEFT)] |= BIT(BTN_0) | BIT(BTN_1) | BIT(BTN_2) | BIT(BTN_3) | BIT(BTN_4) | BIT(BTN_5) | BIT(BTN_6) | BIT(BTN_7);
+                        /* fall through */
+
                 case GRAPHIRE:
                         input_dev->evbit[0] |= BIT(EV_REL);
                         input_dev->relbit[0] |= BIT(REL_WHEEL);
diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
index 862e40a83689..6c693bc68e2e 100644
--- a/drivers/usb/misc/Makefile
+++ b/drivers/usb/misc/Makefile
@@ -18,4 +18,8 @@ obj-$(CONFIG_USB_RIO500)	+= rio500.o
 obj-$(CONFIG_USB_TEST)          += usbtest.o
 obj-$(CONFIG_USB_USS720)        += uss720.o
 
-obj-$(CONFIG_USB_SISUSBVGA)     += sisusbvga/
\ No newline at end of file
+obj-$(CONFIG_USB_SISUSBVGA)     += sisusbvga/
+
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/misc/auerswald.c b/drivers/usb/misc/auerswald.c
index 5f33f7c64885..2a28ceeaa66a 100644
--- a/drivers/usb/misc/auerswald.c
+++ b/drivers/usb/misc/auerswald.c
@@ -30,7 +30,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/wait.h>
-#undef DEBUG            /* include debug macros until it's done */
 #include <linux/usb.h>
 
 /*-------------------------------------------------------------------*/
diff --git a/drivers/usb/misc/phidgetservo.c b/drivers/usb/misc/phidgetservo.c
index b84eda631ab5..a30d4a6ee824 100644
--- a/drivers/usb/misc/phidgetservo.c
+++ b/drivers/usb/misc/phidgetservo.c
@@ -26,9 +26,6 @@
  */
 
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG   1
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc/rio500.c
index 7d02d8ec6b1a..9590dbac5d9a 100644
--- a/drivers/usb/misc/rio500.c
+++ b/drivers/usb/misc/rio500.c
@@ -393,7 +393,7 @@ read_rio(struct file *file, char __user *buffer, size_t count, loff_t * ppos)
                                       ibuf, this_read, &partial,
                                       8000);
 
-                dbg(KERN_DEBUG "read stats: result:%d this_read:%u partial:%u",
+                dbg("read stats: result:%d this_read:%u partial:%u",
                        result, this_read, partial);
 
                 if (partial) {
diff --git a/drivers/usb/misc/usbled.c b/drivers/usb/misc/usbled.c
index f6ba4c788dbc..3c93921cb6b3 100644
--- a/drivers/usb/misc/usbled.c
+++ b/drivers/usb/misc/usbled.c
@@ -10,9 +10,6 @@
  */
 
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG   1
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
index 2997f558159b..605a2afe34ed 100644
--- a/drivers/usb/misc/usbtest.c
+++ b/drivers/usb/misc/usbtest.c
@@ -1,7 +1,4 @@
 #include <linux/config.h>
-#if !defined (DEBUG) && defined (CONFIG_USB_DEBUG)
-#   define DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 0592cb5e6c4d..1cabe7ed91f5 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -41,8 +41,6 @@
 
 /*****************************************************************************/
 
-#define DEBUG
-
 #include <linux/module.h>
 #include <linux/socket.h>
 #include <linux/parport.h>
diff --git a/drivers/usb/net/Makefile b/drivers/usb/net/Makefile
index 222c0495f791..a21e6eaabaf6 100644
--- a/drivers/usb/net/Makefile
+++ b/drivers/usb/net/Makefile
@@ -16,3 +16,7 @@ obj-$(CONFIG_USB_NET_CDC_SUBSET)	+= cdc_subset.o
 obj-$(CONFIG_USB_NET_ZAURUS)    += zaurus.o
 obj-$(CONFIG_USB_USBNET)        += usbnet.o
 obj-$(CONFIG_USB_ZD1201)        += zd1201.o
+
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/net/asix.c b/drivers/usb/net/asix.c
index 252a34fbb42c..542120ef1fd2 100644
--- a/drivers/usb/net/asix.c
+++ b/drivers/usb/net/asix.c
@@ -23,9 +23,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/kmod.h>
 #include <linux/sched.h>
diff --git a/drivers/usb/net/cdc_ether.c b/drivers/usb/net/cdc_ether.c
index 652b04bbf6af..c008c981862b 100644
--- a/drivers/usb/net/cdc_ether.c
+++ b/drivers/usb/net/cdc_ether.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/cdc_subset.c b/drivers/usb/net/cdc_subset.c
index f1730b685fd2..f05cfb83c82d 100644
--- a/drivers/usb/net/cdc_subset.c
+++ b/drivers/usb/net/cdc_subset.c
@@ -18,9 +18,6 @@
  */
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/kmod.h>
 #include <linux/sched.h>
diff --git a/drivers/usb/net/gl620a.c b/drivers/usb/net/gl620a.c
index c0f263b202a6..2455e9a85674 100644
--- a/drivers/usb/net/gl620a.c
+++ b/drivers/usb/net/gl620a.c
@@ -22,9 +22,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
index 6bef1be6b36c..b5776518020f 100644
--- a/drivers/usb/net/kaweth.c
+++ b/drivers/usb/net/kaweth.c
@@ -219,7 +219,6 @@ struct kaweth_device
 
         __u32 status;
         int end;
-        int removed;
         int suspend_lowmem_rx;
         int suspend_lowmem_ctrl;
         int linkstate;
@@ -699,6 +698,7 @@ static int kaweth_close(struct net_device *net)
 
         usb_kill_urb(kaweth->irq_urb);
         usb_kill_urb(kaweth->rx_urb);
+        usb_kill_urb(kaweth->tx_urb);
 
         flush_scheduled_work();
 
@@ -750,13 +750,6 @@ static int kaweth_start_xmit(struct sk_buff *skb, struct net_device *net)
 
         spin_lock(&kaweth->device_lock);
 
-        if (kaweth->removed) {
-        /* our device is undergoing disconnection - we bail out */
-                spin_unlock(&kaweth->device_lock);
-                dev_kfree_skb_irq(skb);
-                return 0;
-        }
-
         kaweth_async_set_rx_mode(kaweth);
         netif_stop_queue(net);
 
@@ -1136,10 +1129,6 @@ static void kaweth_disconnect(struct usb_interface *intf)
                 return;
         }
         netdev = kaweth->net;
-        kaweth->removed = 1;
-        usb_kill_urb(kaweth->irq_urb);
-        usb_kill_urb(kaweth->rx_urb);
-        usb_kill_urb(kaweth->tx_urb);
 
         kaweth_dbg("Unregistering net device");
         unregister_netdev(netdev);
diff --git a/drivers/usb/net/net1080.c b/drivers/usb/net/net1080.c
index cee55f8cf64f..b3799b1a2b0d 100644
--- a/drivers/usb/net/net1080.c
+++ b/drivers/usb/net/net1080.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/pegasus.c b/drivers/usb/net/pegasus.c
index 537eb181d985..683e3df5d607 100644
--- a/drivers/usb/net/pegasus.c
+++ b/drivers/usb/net/pegasus.c
@@ -28,8 +28,6 @@
  *                      is out of the interrupt routine.
  */
 
-#undef  DEBUG
-
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/plusb.c b/drivers/usb/net/plusb.c
index 74c2b3581c76..89856aa0e3b8 100644
--- a/drivers/usb/net/plusb.c
+++ b/drivers/usb/net/plusb.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/rndis_host.c b/drivers/usb/net/rndis_host.c
index b5a925dc1beb..c0ecbab6f6ba 100644
--- a/drivers/usb/net/rndis_host.c
+++ b/drivers/usb/net/rndis_host.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c
index 74f05c9c84d5..362d6907c9bb 100644
--- a/drivers/usb/net/usbnet.c
+++ b/drivers/usb/net/usbnet.c
@@ -34,9 +34,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/zaurus.c b/drivers/usb/net/zaurus.c
index 5d4b7d55b097..680d13957af4 100644
--- a/drivers/usb/net/zaurus.c
+++ b/drivers/usb/net/zaurus.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/serial/ChangeLog.old b/drivers/usb/serial/ChangeLog.history
index c1b279939bbf..52c4f7bd7a80 100644
--- a/drivers/usb/serial/ChangeLog.old
+++ b/drivers/usb/serial/ChangeLog.history
@@ -400,7 +400,7 @@ visor.c Change Log comments:
 
  (11/11/2001) gkh
         Added support for the m125 devices, and added check to prevent oopses
-        for Clié devices that lie about the number of ports they have.
+        for Clié devices that lie about the number of ports they have.
 
  (08/30/2001) gkh
         Added support for the Clie devices, both the 3.5 and 4.0 os versions.
diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
index 7b5e8e4ee2bb..14f55fd26a64 100644
--- a/drivers/usb/serial/Kconfig
+++ b/drivers/usb/serial/Kconfig
@@ -62,6 +62,15 @@ config USB_SERIAL_AIRPRIME
           To compile this driver as a module, choose M here: the
           module will be called airprime.
 
+config USB_SERIAL_ANYDATA
+        tristate "USB AnyData CDMA Wireless Driver"
+        depends on USB_SERIAL
+        help
+          Say Y here if you want to use a AnyData CDMA device.
+
+          To compile this driver as a module, choose M here: the
+          module will be called anydata.
+
 config USB_SERIAL_BELKIN
         tristate "USB Belkin and Peracom Single Port Serial Driver"
         depends on USB_SERIAL
@@ -394,15 +403,6 @@ config USB_SERIAL_MCT_U232
           To compile this driver as a module, choose M here: the
           module will be called mct_u232.
 
-config USB_SERIAL_NOKIA_DKU2
-        tristate "USB Nokia DKU2 Driver"
-        depends on USB_SERIAL
-        help
-          Say Y here if you want to use a Nokia DKU2 device.
-
-          To compile this driver as a module, choose M here: the
-          module will be called nokia_dku2.
-
 config USB_SERIAL_PL2303
         tristate "USB Prolific 2303 Single Port Serial Driver"
         depends on USB_SERIAL
diff --git a/drivers/usb/serial/Makefile b/drivers/usb/serial/Makefile
index 55fd461793b7..f0b04420cea1 100644
--- a/drivers/usb/serial/Makefile
+++ b/drivers/usb/serial/Makefile
@@ -12,6 +12,7 @@ usbserial-obj-$(CONFIG_USB_EZUSB)		+= ezusb.o
 usbserial-objs  := usb-serial.o generic.o bus.o $(usbserial-obj-y)
 
 obj-$(CONFIG_USB_SERIAL_AIRPRIME)               += airprime.o
+obj-$(CONFIG_USB_SERIAL_ANYDATA)                += anydata.o
 obj-$(CONFIG_USB_SERIAL_BELKIN)                 += belkin_sa.o
 obj-$(CONFIG_USB_SERIAL_CP2101)                 += cp2101.o
 obj-$(CONFIG_USB_SERIAL_CYBERJACK)              += cyberjack.o
@@ -31,7 +32,6 @@ obj-$(CONFIG_USB_SERIAL_KEYSPAN_PDA)		+= keyspan_pda.o
 obj-$(CONFIG_USB_SERIAL_KLSI)                   += kl5kusb105.o
 obj-$(CONFIG_USB_SERIAL_KOBIL_SCT)              += kobil_sct.o
 obj-$(CONFIG_USB_SERIAL_MCT_U232)               += mct_u232.o
-obj-$(CONFIG_USB_SERIAL_NOKIA_DKU2)             += nokia_dku2.o
 obj-$(CONFIG_USB_SERIAL_OMNINET)                += omninet.o
 obj-$(CONFIG_USB_SERIAL_OPTION)                 += option.o
 obj-$(CONFIG_USB_SERIAL_PL2303)                 += pl2303.o
diff --git a/drivers/usb/serial/anydata.c b/drivers/usb/serial/anydata.c
new file mode 100644
index 000000000000..18022a74a3dc
--- /dev/null
+++ b/drivers/usb/serial/anydata.c
@@ -0,0 +1,123 @@
+/*
+ * AnyData CDMA Serial USB driver
+ *
+ * Copyright (C) 2005 Greg Kroah-Hartman <gregkh@suse.de>
+ *
+ *      This program is free software; you can redistribute it and/or
+ *      modify it under the terms of the GNU General Public License version
+ *      2 as published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/tty.h>
+#include <linux/module.h>
+#include <linux/usb.h>
+#include "usb-serial.h"
+
+static struct usb_device_id id_table [] = {
+        { USB_DEVICE(0x16d5, 0x6501) }, /* AirData CDMA device */
+        { },
+};
+MODULE_DEVICE_TABLE(usb, id_table);
+
+/* if overridden by the user, then use their value for the size of the
+ * read and write urbs */
+static int buffer_size;
+static int debug;
+
+static struct usb_driver anydata_driver = {
+        .owner =        THIS_MODULE,
+        .name =         "anydata",
+        .probe =        usb_serial_probe,
+        .disconnect =   usb_serial_disconnect,
+        .id_table =     id_table,
+};
+
+static int anydata_open(struct usb_serial_port *port, struct file *filp)
+{
+        char *buffer;
+        int result = 0;
+
+        dbg("%s - port %d", __FUNCTION__, port->number);
+
+        if (buffer_size) {
+                /* override the default buffer sizes */
+                buffer = kmalloc(buffer_size, GFP_KERNEL);
+                if (!buffer) {
+                        dev_err(&port->dev, "%s - out of memory.\n",
+                                __FUNCTION__);
+                        return -ENOMEM;
+                }
+                kfree (port->read_urb->transfer_buffer);
+                port->read_urb->transfer_buffer = buffer;
+                port->read_urb->transfer_buffer_length = buffer_size;
+
+                buffer = kmalloc(buffer_size, GFP_KERNEL);
+                if (!buffer) {
+                        dev_err(&port->dev, "%s - out of memory.\n",
+                                __FUNCTION__);
+                        return -ENOMEM;
+                }
+                kfree (port->write_urb->transfer_buffer);
+                port->write_urb->transfer_buffer = buffer;
+                port->write_urb->transfer_buffer_length = buffer_size;
+                port->bulk_out_size = buffer_size;
+        }
+
+        /* Start reading from the device */
+        usb_fill_bulk_urb(port->read_urb, port->serial->dev,
+                          usb_rcvbulkpipe(port->serial->dev,
+                                          port->bulk_in_endpointAddress),
+                          port->read_urb->transfer_buffer,
+                          port->read_urb->transfer_buffer_length,
+                          usb_serial_generic_write_bulk_callback, port);
+        result = usb_submit_urb(port->read_urb, GFP_KERNEL);
+        if (result)
+                dev_err(&port->dev,
+                        "%s - failed submitting read urb, error %d\n",
+                        __FUNCTION__, result);
+
+        return result;
+}
+
+static struct usb_serial_driver anydata_device = {
+        .driver = {
+                .owner =        THIS_MODULE,
+                .name =         "anydata",
+        },
+        .id_table =             id_table,
+        .num_interrupt_in =     NUM_DONT_CARE,
+        .num_bulk_in =          NUM_DONT_CARE,
+        .num_bulk_out =         NUM_DONT_CARE,
+        .num_ports =            1,
+        .open =                 anydata_open,
+};
+
+static int __init anydata_init(void)
+{
+        int retval;
+
+        retval = usb_serial_register(&anydata_device);
+        if (retval)
+                return retval;
+        retval = usb_register(&anydata_driver);
+        if (retval)
+                usb_serial_deregister(&anydata_device);
+        return retval;
+}
+
+static void __exit anydata_exit(void)
+{
+        usb_deregister(&anydata_driver);
+        usb_serial_deregister(&anydata_device);
+}
+
+module_init(anydata_init);
+module_exit(anydata_exit);
+MODULE_LICENSE("GPL");
+
+module_param(debug, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(debug, "Debug enabled or not");
+module_param(buffer_size, int, 0);
+MODULE_PARM_DESC(buffer_size, "Size of the transfer buffers");
diff --git a/drivers/usb/serial/cp2101.c b/drivers/usb/serial/cp2101.c
index c5334dd89b12..c9787001cf2a 100644
--- a/drivers/usb/serial/cp2101.c
+++ b/drivers/usb/serial/cp2101.c
@@ -60,6 +60,7 @@ static struct usb_device_id id_table [] = {
         { USB_DEVICE(0x10C4, 0x80F6) }, /* Suunto sports instrument */
         { USB_DEVICE(0x10A6, 0xAA26) }, /* Knock-off DCU-11 cable */
         { USB_DEVICE(0x10AB, 0x10C5) }, /* Siemens MC60 Cable */
+        { USB_DEVICE(0x16D6, 0x0001) }, /* Jablotron serial interface */
         { } /* Terminating Entry */
 };
 
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 8909208f506a..53a47c31cd0e 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -309,6 +309,7 @@ void usb_serial_generic_write_bulk_callback (struct urb *urb, struct pt_regs *re
 
         schedule_work(&port->work);
 }
+EXPORT_SYMBOL_GPL(usb_serial_generic_write_bulk_callback);
 
 void usb_serial_generic_shutdown (struct usb_serial *serial)
 {
diff --git a/drivers/usb/serial/nokia_dku2.c b/drivers/usb/serial/nokia_dku2.c
deleted file mode 100644
index fad01bef3a64..000000000000
--- a/drivers/usb/serial/nokia_dku2.c
+++ /dev/null
@@ -1,142 +0,0 @@
-/*
- *  Nokia DKU2 USB driver
- *
- *  Copyright (C) 2004
- *  Author: C Kemp
- *
- *  This program is largely derived from work by the linux-usb group
- *  and associated source files.  Please see the usb/serial files for
- *  individual credits and copyrights.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *
- *  20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- *  Added short name to device structure to make driver load into kernel 2.6.13
- *
- *  20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- *  Added usb_deregister to exit code - to allow remove and reinsert of module
- */
-
-
-#include <linux/config.h>
-#include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/init.h>
-#include <linux/slab.h>
-#include <linux/tty.h>
-#include <linux/tty_driver.h>
-#include <linux/tty_flip.h>
-#include <linux/module.h>
-#include <linux/usb.h>
-#include "usb-serial.h"
-
-
-#define NOKIA_VENDOR_ID         0x0421
-#define NOKIA7600_PRODUCT_ID    0x0400
-#define NOKIA6230_PRODUCT_ID    0x040f
-#define NOKIA6170_PRODUCT_ID    0x0416
-#define NOKIA6670_PRODUCT_ID    0x041d
-#define NOKIA6680_PRODUCT_ID    0x041e
-#define NOKIA6230i_PRODUCT_ID   0x0428
-
-#define NOKIA_AT_PORT   0x82
-#define NOKIA_FBUS_PORT 0x86
-
-/*
- * Version Information
- */
-#define DRIVER_VERSION  "v0.2"
-#define DRIVER_AUTHOR   "C Kemp"
-#define DRIVER_DESC     "Nokia DKU2 Driver"
-
-static struct usb_device_id id_table [] = {
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA7600_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6170_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6670_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6680_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230i_PRODUCT_ID) },
-        { }                     /* Terminating entry */
-};
-MODULE_DEVICE_TABLE(usb, id_table);
-
-/* The only thing which makes this device different from a generic
- * device is that we have to set an alternative configuration to make
- * the relevant endpoints available. In 2.6 this is really easy... */
-static int nokia_probe(struct usb_serial *serial,
-                       const struct usb_device_id *id)
-{
-        int retval = -ENODEV;
-
-        if (serial->interface->altsetting[0].endpoint[0].desc.bEndpointAddress == NOKIA_AT_PORT) {
-                /* the AT port */
-                dev_info(&serial->dev->dev, "Nokia AT Port:\n");
-                retval = 0;
-        } else if (serial->interface->num_altsetting == 2 &&
-                   serial->interface->altsetting[1].endpoint[0].desc.bEndpointAddress == NOKIA_FBUS_PORT) {
-                /* the FBUS port */
-                dev_info(&serial->dev->dev, "Nokia FBUS Port:\n");
-                usb_set_interface(serial->dev, 10, 1);
-                retval = 0;
-        }
-
-        return retval;
-}
-
-static struct usb_driver nokia_driver = {
-        .owner =        THIS_MODULE,
-        .name =         "nokia_dku2",
-        .probe =        usb_serial_probe,
-        .disconnect =   usb_serial_disconnect,
-        .id_table =     id_table,
-};
-
-static struct usb_serial_driver nokia_serial_driver = {
-        .driver = {
-                .owner =        THIS_MODULE,
-                .name =         "nokia_dku2",
-        },
-        .description =          "Nokia 7600/6230(i)/6170/66x0 DKU2 driver",
-        .id_table =             id_table,
-        .num_interrupt_in =     1,
-        .num_bulk_in =          1,
-        .num_bulk_out =         1,
-        .num_ports =            1,
-        .probe =                nokia_probe,
-};
-
-static int __init nokia_init(void)
-{
-        int retval;
-
-        retval = usb_serial_register(&nokia_serial_driver);
-        if (retval)
-                return retval;
-
-        retval = usb_register(&nokia_driver);
-        if (retval) {
-                usb_serial_deregister(&nokia_serial_driver);
-                return retval;
-        }
-
-        info(DRIVER_VERSION " " DRIVER_AUTHOR);
-        info(DRIVER_DESC);
-
-        return retval;
-}
-
-static void __exit nokia_exit(void)
-{
-        usb_deregister(&nokia_driver);
-        usb_serial_deregister(&nokia_serial_driver);
-}
-
-module_init(nokia_init);
-module_exit(nokia_exit);
-
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 165c119bf10e..41a45a5025b2 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -71,7 +71,9 @@ static struct usb_device_id id_table [] = {
         { USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
         { USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
         { USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
+        { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1) },
         { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65) },
+        { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X75) },
         { USB_DEVICE(SYNTECH_VENDOR_ID, SYNTECH_PRODUCT_ID) },
         { USB_DEVICE( NOKIA_CA42_VENDOR_ID, NOKIA_CA42_PRODUCT_ID ) },
         { }                                     /* Terminating entry */
@@ -811,7 +813,9 @@ static void pl2303_update_line_status(struct usb_serial_port *port,
         u8 length = UART_STATE;
 
         if ((le16_to_cpu(port->serial->dev->descriptor.idVendor) == SIEMENS_VENDOR_ID) &&
-            (le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X65)) {
+            (le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X65 ||
+             le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_SX1 ||
+             le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X75)) {
                 length = 1;
                 status_idx = 0;
         }
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index 7be9644f5a03..21d434d81813 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -54,7 +54,9 @@
 #define SAMSUNG_PRODUCT_ID      0x8001
 
 #define SIEMENS_VENDOR_ID       0x11f5
+#define SIEMENS_PRODUCT_ID_SX1  0x0001
 #define SIEMENS_PRODUCT_ID_X65  0x0003
+#define SIEMENS_PRODUCT_ID_X75  0x0004
 
 #define SYNTECH_VENDOR_ID       0x0745
 #define SYNTECH_PRODUCT_ID      0x0001
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index 1a9679f76f5a..c41d64dbb0f0 100644
--- a/drivers/usb/storage/Kconfig
+++ b/drivers/usb/storage/Kconfig
@@ -115,7 +115,7 @@ config USB_STORAGE_JUMPSHOT
 
 config USB_STORAGE_ONETOUCH
         bool "Support OneTouch Button on Maxtor Hard Drives (EXPERIMENTAL)"
-        depends on USB_STORAGE && INPUT_EVDEV && EXPERIMENTAL
+        depends on USB_STORAGE && INPUT_EVDEV && EXPERIMENTAL && !PM
         help
           Say Y here to include additional code to support the Maxtor OneTouch
           USB hard drive's onetouch button.
diff --git a/drivers/usb/storage/shuttle_usbat.c b/drivers/usb/storage/shuttle_usbat.c
index 33c55a6261bb..fea176d7e79a 100644
--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -853,7 +853,7 @@ static int usbat_identify_device(struct us_data *us,
         rc = usbat_device_reset(us);
         if (rc != USB_STOR_TRANSPORT_GOOD)
                 return rc;
-        msleep(25);
+        msleep(500);
 
         /*
          * In attempt to distinguish between HP CDRW's and Flash readers, we now
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 9e926a8f2116..0a9858f69a9b 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -710,11 +710,6 @@ UNUSUAL_DEV(  0x0686, 0x4017, 0x0001, 0x0001,
                 "DIMAGE E223",
                 US_SC_SCSI, US_PR_DEVICE, NULL, 0 ),
 
-UNUSUAL_DEV(  0x0693, 0x0002, 0x0100, 0x0100, 
-                "Hagiwara",
-                "FlashGate SmartMedia",
-                US_SC_SCSI, US_PR_BULK, NULL, 0 ),
-
 UNUSUAL_DEV(  0x0693, 0x0005, 0x0100, 0x0100,
                 "Hagiwara",
                 "Flashgate",
@@ -1008,6 +1003,11 @@ UNUSUAL_DEV( 0x0c0b, 0xa109, 0x0000, 0xffff,
  *
  */
 #ifdef CONFIG_USB_STORAGE_ONETOUCH
+        UNUSUAL_DEV(  0x0d49, 0x7000, 0x0000, 0x9999,
+                        "Maxtor",
+                        "OneTouch External Harddrive",
+                        US_SC_DEVICE, US_PR_DEVICE, onetouch_connect_input,
+                        0),
         UNUSUAL_DEV(  0x0d49, 0x7010, 0x0000, 0x9999,
                         "Maxtor",
                         "OneTouch External Harddrive",
diff --git a/drivers/video/bw2.c b/drivers/video/bw2.c
index f53bf3ba1278..d3728f60961e 100644
--- a/drivers/video/bw2.c
+++ b/drivers/video/bw2.c
@@ -51,6 +51,9 @@ static struct fb_ops bw2_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = bw2_mmap,
         .fb_ioctl               = bw2_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 /* OBio addresses for the bwtwo registers */
diff --git a/drivers/video/cg14.c b/drivers/video/cg14.c
index 030d4b13b1c2..1bed50f2a276 100644
--- a/drivers/video/cg14.c
+++ b/drivers/video/cg14.c
@@ -49,6 +49,9 @@ static struct fb_ops cg14_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = cg14_mmap,
         .fb_ioctl               = cg14_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 #define CG14_MCR_INTENABLE_SHIFT        7
diff --git a/drivers/video/cg3.c b/drivers/video/cg3.c
index b94eee8c42d5..a1354e7e0513 100644
--- a/drivers/video/cg3.c
+++ b/drivers/video/cg3.c
@@ -50,6 +50,9 @@ static struct fb_ops cg3_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = cg3_mmap,
         .fb_ioctl               = cg3_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 
diff --git a/drivers/video/cg6.c b/drivers/video/cg6.c
index 414c4409e924..9debe642fd2f 100644
--- a/drivers/video/cg6.c
+++ b/drivers/video/cg6.c
@@ -54,6 +54,9 @@ static struct fb_ops cg6_ops = {
         .fb_sync                = cg6_sync,
         .fb_mmap                = cg6_mmap,
         .fb_ioctl               = cg6_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 /* Offset of interesting structures in the OBIO space */
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index 94c5f1392cce..5f74df993406 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -215,12 +215,5 @@ config FONT_10x18
           big letters. It fits between the sun 12x22 and the normal 8x16 font.
           If other fonts are too big or too small for you, say Y, otherwise say N.
 
-config FONT_RL
-        bool "console Roman Large 8x16 font" if FONTS
-        depends on FRAMEBUFFER_CONSOLE
-        help
-          This is the visually-appealing "RL" console font that is
-          included with the kbd package.
-
 endmenu
 
diff --git a/drivers/video/console/Makefile b/drivers/video/console/Makefile
index fed600c9ca55..9b26dda18a38 100644
--- a/drivers/video/console/Makefile
+++ b/drivers/video/console/Makefile
@@ -15,7 +15,6 @@ font-objs-$(CONFIG_FONT_10x18)     += font_10x18.o
 font-objs-$(CONFIG_FONT_PEARL_8x8) += font_pearl_8x8.o
 font-objs-$(CONFIG_FONT_ACORN_8x8) += font_acorn_8x8.o
 font-objs-$(CONFIG_FONT_MINI_4x6)  += font_mini_4x6.o
-font-objs-$(CONFIG_FONT_RL)  += font_rl.o
 
 font-objs += $(font-objs-y)
 
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index e7802ffe549a..bcea87c3cc06 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -106,8 +106,7 @@ enum {
         FBCON_LOGO_DONTSHOW     = -3    /* do not show the logo */
 };
 
-struct display fb_display[MAX_NR_CONSOLES];
-EXPORT_SYMBOL(fb_display);
+static struct display fb_display[MAX_NR_CONSOLES];
 
 static signed char con2fb_map[MAX_NR_CONSOLES];
 static signed char con2fb_map_boot[MAX_NR_CONSOLES];
@@ -653,13 +652,12 @@ static void set_blitting_type(struct vc_data *vc, struct fb_info *info,
 {
         struct fbcon_ops *ops = info->fbcon_par;
 
+        ops->p = (p) ? p : &fb_display[vc->vc_num];
+
         if ((info->flags & FBINFO_MISC_TILEBLITTING))
                 fbcon_set_tileops(vc, info, p, ops);
         else {
-                struct display *disp;
-
-                disp = (p) ? p : &fb_display[vc->vc_num];
-                fbcon_set_rotation(info, disp);
+                fbcon_set_rotation(info, ops->p);
                 fbcon_set_bitops(ops);
         }
 }
@@ -668,11 +666,10 @@ static void set_blitting_type(struct vc_data *vc, struct fb_info *info,
                               struct display *p)
 {
         struct fbcon_ops *ops = info->fbcon_par;
-        struct display *disp;
 
         info->flags &= ~FBINFO_MISC_TILEBLITTING;
-        disp = (p) ? p : &fb_display[vc->vc_num];
-        fbcon_set_rotation(info, disp);
+        ops->p = (p) ? p : &fb_display[vc->vc_num];
+        fbcon_set_rotation(info, ops->p);
         fbcon_set_bitops(ops);
 }
 #endif /* CONFIG_MISC_TILEBLITTING */
diff --git a/drivers/video/console/fbcon.h b/drivers/video/console/fbcon.h
index accfd7bd8e93..6892e7ff34de 100644
--- a/drivers/video/console/fbcon.h
+++ b/drivers/video/console/fbcon.h
@@ -52,8 +52,6 @@ struct display {
     struct fb_videomode *mode;
 };
 
-extern struct display fb_display[];
-
 struct fbcon_ops {
         void (*bmove)(struct vc_data *vc, struct fb_info *info, int sy,
                       int sx, int dy, int dx, int height, int width);
@@ -73,6 +71,7 @@ struct fbcon_ops {
         struct fb_var_screeninfo var;  /* copy of the current fb_var_screeninfo */
         struct timer_list cursor_timer; /* Cursor timer */
         struct fb_cursor cursor_state;
+        struct display *p;
         int    currcon;                 /* Current VC. */
         int    cursor_flash;
         int    cursor_reset;
diff --git a/drivers/video/console/fbcon_ccw.c b/drivers/video/console/fbcon_ccw.c
index 680aabab73c5..3afd1eeb1ade 100644
--- a/drivers/video/console/fbcon_ccw.c
+++ b/drivers/video/console/fbcon_ccw.c
@@ -63,9 +63,9 @@ static inline void ccw_update_attr(u8 *dst, u8 *src, int attribute,
 static void ccw_bmove(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int dy, int dx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_copyarea area;
-        u32 vyres = GETVYRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
 
         area.sx = sy * vc->vc_font.height;
         area.sy = vyres - ((sx + width) * vc->vc_font.width);
@@ -80,10 +80,10 @@ static void ccw_bmove(struct vc_data *vc, struct fb_info *info, int sy,
 static void ccw_clear(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_fillrect region;
         int bgshift = (vc->vc_hi_font_mask) ? 13 : 12;
-        u32 vyres = GETVYRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
 
         region.color = attr_bgcol_ec(bgshift,vc);
         region.dx = sy * vc->vc_font.height;
@@ -131,7 +131,6 @@ static void ccw_putcs(struct vc_data *vc, struct fb_info *info,
                       int fg, int bg)
 {
         struct fb_image image;
-        struct display *p = &fb_display[vc->vc_num];
         struct fbcon_ops *ops = info->fbcon_par;
         u32 width = (vc->vc_font.height + 7)/8;
         u32 cellsize = width * vc->vc_font.width;
@@ -141,7 +140,7 @@ static void ccw_putcs(struct vc_data *vc, struct fb_info *info,
         u32 cnt, pitch, size;
         u32 attribute = get_attribute(info, scr_readw(s));
         u8 *dst, *buf = NULL;
-        u32 vyres = GETVYRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
 
         if (!ops->fontbuffer)
                 return;
@@ -397,9 +396,8 @@ static void ccw_cursor(struct vc_data *vc, struct fb_info *info,
 int ccw_update_start(struct fb_info *info)
 {
         struct fbcon_ops *ops = info->fbcon_par;
-        struct display *p = &fb_display[ops->currcon];
         u32 yoffset;
-        u32 vyres = GETVYRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
         int err;
 
         yoffset = (vyres - info->var.yres) - ops->var.xoffset;
diff --git a/drivers/video/console/fbcon_cw.c b/drivers/video/console/fbcon_cw.c
index 6c6f3b6dd175..6d92b8456206 100644
--- a/drivers/video/console/fbcon_cw.c
+++ b/drivers/video/console/fbcon_cw.c
@@ -49,9 +49,9 @@ static inline void cw_update_attr(u8 *dst, u8 *src, int attribute,
 static void cw_bmove(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int dy, int dx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_copyarea area;
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         area.sx = vxres - ((sy + height) * vc->vc_font.height);
         area.sy = sx * vc->vc_font.width;
@@ -66,10 +66,10 @@ static void cw_bmove(struct vc_data *vc, struct fb_info *info, int sy,
 static void cw_clear(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_fillrect region;
         int bgshift = (vc->vc_hi_font_mask) ? 13 : 12;
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         region.color = attr_bgcol_ec(bgshift,vc);
         region.dx = vxres - ((sy + height) * vc->vc_font.height);
@@ -117,7 +117,6 @@ static void cw_putcs(struct vc_data *vc, struct fb_info *info,
                       int fg, int bg)
 {
         struct fb_image image;
-        struct display *p = &fb_display[vc->vc_num];
         struct fbcon_ops *ops = info->fbcon_par;
         u32 width = (vc->vc_font.height + 7)/8;
         u32 cellsize = width * vc->vc_font.width;
@@ -127,7 +126,7 @@ static void cw_putcs(struct vc_data *vc, struct fb_info *info,
         u32 cnt, pitch, size;
         u32 attribute = get_attribute(info, scr_readw(s));
         u8 *dst, *buf = NULL;
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         if (!ops->fontbuffer)
                 return;
@@ -381,8 +380,7 @@ static void cw_cursor(struct vc_data *vc, struct fb_info *info,
 int cw_update_start(struct fb_info *info)
 {
         struct fbcon_ops *ops = info->fbcon_par;
-        struct display *p = &fb_display[ops->currcon];
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
         u32 xoffset;
         int err;
 
diff --git a/drivers/video/console/fbcon_ud.c b/drivers/video/console/fbcon_ud.c
index 2e1d9d4249cd..c4d7c89212b4 100644
--- a/drivers/video/console/fbcon_ud.c
+++ b/drivers/video/console/fbcon_ud.c
@@ -48,10 +48,10 @@ static inline void ud_update_attr(u8 *dst, u8 *src, int attribute,
 static void ud_bmove(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int dy, int dx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_copyarea area;
-        u32 vyres = GETVYRES(p->scrollmode, info);
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         area.sy = vyres - ((sy + height) * vc->vc_font.height);
         area.sx = vxres - ((sx + width) * vc->vc_font.width);
@@ -66,11 +66,11 @@ static void ud_bmove(struct vc_data *vc, struct fb_info *info, int sy,
 static void ud_clear(struct vc_data *vc, struct fb_info *info, int sy,
                      int sx, int height, int width)
 {
-        struct display *p = &fb_display[vc->vc_num];
+        struct fbcon_ops *ops = info->fbcon_par;
         struct fb_fillrect region;
         int bgshift = (vc->vc_hi_font_mask) ? 13 : 12;
-        u32 vyres = GETVYRES(p->scrollmode, info);
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         region.color = attr_bgcol_ec(bgshift,vc);
         region.dy = vyres - ((sy + height) * vc->vc_font.height);
@@ -153,7 +153,6 @@ static void ud_putcs(struct vc_data *vc, struct fb_info *info,
                       int fg, int bg)
 {
         struct fb_image image;
-        struct display *p = &fb_display[vc->vc_num];
         struct fbcon_ops *ops = info->fbcon_par;
         u32 width = (vc->vc_font.width + 7)/8;
         u32 cellsize = width * vc->vc_font.height;
@@ -163,8 +162,8 @@ static void ud_putcs(struct vc_data *vc, struct fb_info *info,
         u32 mod = vc->vc_font.width % 8, cnt, pitch, size;
         u32 attribute = get_attribute(info, scr_readw(s));
         u8 *dst, *buf = NULL;
-        u32 vyres = GETVYRES(p->scrollmode, info);
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
 
         if (!ops->fontbuffer)
                 return;
@@ -421,10 +420,9 @@ static void ud_cursor(struct vc_data *vc, struct fb_info *info,
 int ud_update_start(struct fb_info *info)
 {
         struct fbcon_ops *ops = info->fbcon_par;
-        struct display *p = &fb_display[ops->currcon];
         u32 xoffset, yoffset;
-        u32 vyres = GETVYRES(p->scrollmode, info);
-        u32 vxres = GETVXRES(p->scrollmode, info);
+        u32 vyres = GETVYRES(ops->p->scrollmode, info);
+        u32 vxres = GETVXRES(ops->p->scrollmode, info);
         int err;
 
         xoffset = (vxres - info->var.xres) - ops->var.xoffset;
diff --git a/drivers/video/console/font_rl.c b/drivers/video/console/font_rl.c
deleted file mode 100644
index dfecc27d8ded..000000000000
--- a/drivers/video/console/font_rl.c
+++ /dev/null
@@ -1,4374 +0,0 @@
-
-/* This font is simply the "rl.fnt" console font from the kbd utility.
- * Converted by Zack T Smith, fbui@comcast.net.
- * The original binary file is covered under the GNU Public License.
- */
-
-#include <linux/font.h>
-
-#define FONTDATAMAX 4096
-
-static unsigned char patterns[4096] = {
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x3c,
-0x42,
-0x81,
-0xe7,
-0xa5,
-0x99,
-0x81,
-0x81,
-0x99,
-0x42,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x3c,
-0x7e,
-0xff,
-0x99,
-0xdb,
-0xe7,
-0xff,
-0xff,
-0xe7,
-0x7e,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x6c,
-0xfe,
-0xfe,
-0xfe,
-0xfe,
-0xfe,
-0x7c,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x7c,
-0xfe,
-0x7c,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x38,
-0x38,
-0x10,
-0xd6,
-0xfe,
-0xd6,
-0x10,
-0x10,
-0x38,
-0x7c,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x38,
-0x7c,
-0xfe,
-0xfe,
-0x54,
-0x10,
-0x10,
-0x38,
-0x7c,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x3c,
-0x3c,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xe7,
-0xc3,
-0xc3,
-0xe7,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x42,
-0x42,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xc3,
-0x99,
-0xbd,
-0xbd,
-0x99,
-0xc3,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-
-0x00,
-0x00,
-0x0f,
-0x07,
-0x0d,
-0x18,
-0x78,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0x78,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x18,
-0x7e,
-0x18,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x08,
-0x0c,
-0x0a,
-0x0a,
-0x0a,
-0x08,
-0x08,
-0x08,
-0x38,
-0x78,
-0x30,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x10,
-0x18,
-0x1c,
-0x1e,
-0x1e,
-0x16,
-0x12,
-0x72,
-0xf2,
-0x62,
-0x0e,
-0x1e,
-0x0c,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x10,
-0x92,
-0x54,
-0x38,
-0xfe,
-0x38,
-0x54,
-0x92,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x80,
-0xc0,
-0xe0,
-0xb8,
-0x8e,
-0xb8,
-0xe0,
-0xc0,
-0x80,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x02,
-0x06,
-0x0e,
-0x3a,
-0xe2,
-0x3a,
-0x0e,
-0x06,
-0x02,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x38,
-0x7c,
-0xd6,
-0x10,
-0x10,
-0x10,
-0x10,
-0xd6,
-0x7c,
-0x38,
-0x10,
-0x00,
-0x00,
-
-0x00,
-0x42,
-0xe7,
-0xe7,
-0xe7,
-0xe7,
-0x42,
-0x42,
-0x42,
-0x00,
-0x66,
-0x66,
-0x66,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x7f,
-0xca,
-0xca,
-0xca,
-0xca,
-0x7a,
-0x0a,
-0x0a,
-0x0a,
-0x0a,
-0x0a,
-0x1b,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1e,
-0x31,
-0x78,
-0xcc,
-0xc6,
-0xc3,
-0x63,
-0x33,
-0x1e,
-0x8c,
-0x78,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0xfe,
-0xfe,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x38,
-0x7c,
-0xd6,
-0x10,
-0x10,
-0x10,
-0x10,
-0xd6,
-0x7c,
-0x38,
-0x10,
-0xfe,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x38,
-0x7c,
-0xd6,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0x10,
-0xd6,
-0x7c,
-0x38,
-0x10,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x08,
-0x0c,
-0x06,
-0xff,
-0x06,
-0x0c,
-0x08,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x30,
-0x60,
-0xff,
-0x60,
-0x30,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x22,
-0x44,
-0x88,
-0xcc,
-0xee,
-0x44,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x24,
-0x42,
-0xff,
-0x42,
-0x24,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x38,
-0x6c,
-0x6c,
-0xc6,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0xfe,
-0xc6,
-0x6c,
-0x6c,
-0x38,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x3c,
-0x3c,
-0x3c,
-0x3c,
-0x18,
-0x18,
-0x18,
-0x10,
-0x00,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x22,
-0x77,
-0x33,
-0x11,
-0x22,
-0x44,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x12,
-0x12,
-0x12,
-0x7f,
-0x24,
-0x24,
-0x24,
-0xfe,
-0x48,
-0x48,
-0x48,
-0x00,
-0x00,
-0x00,
-
-0x10,
-0x10,
-0x7c,
-0xd2,
-0xd0,
-0xd0,
-0xd0,
-0x7c,
-0x16,
-0x16,
-0x16,
-0x96,
-0x7c,
-0x10,
-0x10,
-0x00,
-
-0x00,
-0x42,
-0xbe,
-0x44,
-0x0c,
-0x08,
-0x18,
-0x10,
-0x30,
-0x20,
-0x64,
-0x4a,
-0xc4,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x38,
-0x6c,
-0x6c,
-0x6c,
-0x38,
-0x37,
-0x72,
-0xdc,
-0xcc,
-0xcc,
-0xcc,
-0x77,
-0x00,
-0x00,
-0x00,
-
-0x10,
-0x38,
-0x18,
-0x08,
-0x10,
-0x20,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x04,
-0x08,
-0x10,
-0x10,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x10,
-0x10,
-0x08,
-0x04,
-0x00,
-0x00,
-
-0x00,
-0x20,
-0x10,
-0x08,
-0x08,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x08,
-0x08,
-0x10,
-0x20,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x44,
-0x28,
-0x38,
-0xfe,
-0x38,
-0x28,
-0x44,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x18,
-0x7e,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x18,
-0x08,
-0x10,
-0x20,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x06,
-0x06,
-0x0c,
-0x0c,
-0x18,
-0x18,
-0x30,
-0x30,
-0x60,
-0x60,
-0xc0,
-0xc0,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x46,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc4,
-0x78,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x08,
-0x18,
-0x78,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x7e,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x7c,
-0x86,
-0x06,
-0x0c,
-0x18,
-0x20,
-0x40,
-0xc1,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x46,
-0x04,
-0x08,
-0x1c,
-0x06,
-0x06,
-0x06,
-0x06,
-0x0c,
-0x70,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x04,
-0x08,
-0x10,
-0x2c,
-0x4c,
-0x8c,
-0x8c,
-0xfe,
-0x0c,
-0x0c,
-0x0c,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x02,
-0x3c,
-0x20,
-0x20,
-0x70,
-0x0c,
-0x06,
-0x06,
-0x06,
-0x06,
-0x0c,
-0x70,
-0x00,
-
-0x00,
-0x00,
-0x18,
-0x20,
-0x40,
-0xc0,
-0xdc,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0x44,
-0x38,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x40,
-0x7e,
-0x82,
-0x06,
-0x04,
-0x0c,
-0x18,
-0x18,
-0x30,
-0x30,
-0x30,
-0x30,
-0x00,
-
-0x00,
-0x00,
-0x7c,
-0xc6,
-0xc6,
-0x64,
-0x38,
-0x4c,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0x7c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x38,
-0x44,
-0xc6,
-0xc6,
-0x76,
-0x06,
-0x06,
-0x06,
-0x04,
-0x08,
-0x30,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x18,
-0x08,
-0x10,
-0x20,
-
-0x00,
-0x06,
-0x0c,
-0x18,
-0x30,
-0x60,
-0xa0,
-0xa0,
-0x60,
-0x30,
-0x18,
-0x0c,
-0x06,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x60,
-0x30,
-0x18,
-0x0c,
-0x06,
-0x05,
-0x05,
-0x06,
-0x0c,
-0x18,
-0x30,
-0x60,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x7c,
-0x86,
-0xc6,
-0x06,
-0x04,
-0x08,
-0x10,
-0x10,
-0x18,
-0x00,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x3c,
-0x46,
-0xc6,
-0xce,
-0xd6,
-0xd6,
-0xd6,
-0xdc,
-0xc0,
-0xc4,
-0x78,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x2c,
-0x2c,
-0x2c,
-0x7e,
-0x46,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xfc,
-0x66,
-0x66,
-0x66,
-0x66,
-0x7c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xfc,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3a,
-0x66,
-0xc2,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xfc,
-0x66,
-0x63,
-0x63,
-0x63,
-0x63,
-0x63,
-0x63,
-0x63,
-0x63,
-0x66,
-0xfc,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xff,
-0x61,
-0x60,
-0x60,
-0x64,
-0x7c,
-0x64,
-0x60,
-0x60,
-0x60,
-0x61,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xff,
-0x61,
-0x61,
-0x60,
-0x64,
-0x7c,
-0x64,
-0x60,
-0x60,
-0x60,
-0x60,
-0xf0,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3a,
-0x66,
-0xc2,
-0xc0,
-0xc0,
-0xc0,
-0xcf,
-0xc6,
-0xc6,
-0xc6,
-0x66,
-0x38,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x62,
-0x7e,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1e,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x08,
-0xf0,
-
-0x00,
-0xf7,
-0x64,
-0x6c,
-0x68,
-0x68,
-0x78,
-0x6c,
-0x6c,
-0x6c,
-0x66,
-0x66,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf8,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x61,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xc3,
-0x66,
-0x76,
-0x7e,
-0x56,
-0x56,
-0x46,
-0x46,
-0x46,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xe7,
-0x62,
-0x62,
-0x72,
-0x52,
-0x5a,
-0x4a,
-0x4e,
-0x46,
-0x46,
-0x42,
-0xe2,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x66,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xfc,
-0x66,
-0x66,
-0x66,
-0x66,
-0x6c,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0xf0,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x66,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0x66,
-0x3c,
-0x10,
-0x39,
-0x0e,
-
-0x00,
-0xfc,
-0x66,
-0x66,
-0x66,
-0x66,
-0x7c,
-0x6c,
-0x66,
-0x66,
-0x66,
-0x66,
-0xf3,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x7a,
-0xc6,
-0xc2,
-0xc0,
-0x70,
-0x3c,
-0x0e,
-0x06,
-0x06,
-0x86,
-0xc6,
-0xbc,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xff,
-0x99,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x76,
-0x34,
-0x34,
-0x34,
-0x3c,
-0x18,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x62,
-0x6a,
-0x6a,
-0x6a,
-0x6a,
-0x7e,
-0x7e,
-0x34,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x34,
-0x34,
-0x18,
-0x18,
-0x2c,
-0x2c,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x34,
-0x34,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x7f,
-0x46,
-0x86,
-0x0c,
-0x0c,
-0x18,
-0x18,
-0x30,
-0x30,
-0x61,
-0x62,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xc0,
-0xc0,
-0x60,
-0x60,
-0x30,
-0x30,
-0x18,
-0x18,
-0x0c,
-0x0c,
-0x06,
-0x06,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x10,
-0x38,
-0x4c,
-0x86,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x20,
-0x30,
-0x38,
-0x10,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x20,
-0xe0,
-0x60,
-0x60,
-0x6c,
-0x76,
-0x66,
-0x66,
-0x66,
-0x66,
-0x76,
-0x6c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x60,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x04,
-0x1c,
-0x0c,
-0x0c,
-0x6c,
-0xdc,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0xdc,
-0x66,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x7e,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1e,
-0x31,
-0x33,
-0x30,
-0x30,
-0x78,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x78,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7b,
-0xce,
-0xcc,
-0xcc,
-0xcc,
-0x78,
-0x60,
-0x7c,
-0x86,
-0xc6,
-0x7c,
-
-0x00,
-0x20,
-0xe0,
-0x60,
-0x60,
-0x6c,
-0x76,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x10,
-0x38,
-0x10,
-0x00,
-0x18,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x08,
-0x1c,
-0x08,
-0x00,
-0x0c,
-0x1c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x0c,
-0x6c,
-0x4c,
-0x38,
-0x00,
-
-0x00,
-0x20,
-0xe0,
-0x60,
-0x60,
-0x67,
-0x66,
-0x6c,
-0x78,
-0x6c,
-0x6c,
-0x66,
-0xe7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x08,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x6a,
-0xfe,
-0x6a,
-0x6a,
-0x6a,
-0x62,
-0x62,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x5c,
-0xf6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x5c,
-0xe6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x7c,
-0x60,
-0x60,
-0xf0,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x76,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0x7c,
-0x0c,
-0x0c,
-0x1e,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x5e,
-0xf6,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0xf0,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7a,
-0xc6,
-0x72,
-0x1c,
-0x06,
-0x86,
-0xc6,
-0xbc,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x10,
-0x30,
-0x7c,
-0x30,
-0x30,
-0x30,
-0x30,
-0x30,
-0x34,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xee,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x3a,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf7,
-0x62,
-0x76,
-0x34,
-0x34,
-0x3c,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf7,
-0x62,
-0x6a,
-0x6a,
-0x6a,
-0x6a,
-0x7e,
-0x24,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf7,
-0x62,
-0x34,
-0x18,
-0x2c,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf7,
-0x62,
-0x62,
-0x34,
-0x34,
-0x18,
-0x18,
-0x18,
-0x10,
-0xb0,
-0xe0,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0x8c,
-0x18,
-0x30,
-0x30,
-0x60,
-0xc2,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x0e,
-0x18,
-0x10,
-0x10,
-0x08,
-0x70,
-0x70,
-0x08,
-0x10,
-0x10,
-0x18,
-0x0e,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x00,
-0x00,
-
-0x00,
-0x70,
-0x18,
-0x08,
-0x08,
-0x10,
-0x0e,
-0x0e,
-0x10,
-0x08,
-0x08,
-0x18,
-0x70,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x76,
-0xdc,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x10,
-0x38,
-0x6c,
-0xc6,
-0xc6,
-0xc6,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x3a,
-0x66,
-0xc2,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0x62,
-0x3c,
-0x18,
-0x0c,
-0x24,
-0x18,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0xee,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3b,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x0c,
-0x18,
-0x20,
-0x00,
-0x3c,
-0x66,
-0x7e,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x58,
-0x8c,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x18,
-0x04,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x38,
-0x44,
-0x44,
-0x38,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x60,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x08,
-0x24,
-0x18,
-
-0x00,
-0x18,
-0x2c,
-0x46,
-0x00,
-0x3c,
-0x66,
-0x7e,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x7e,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x18,
-0x04,
-0x00,
-0x3c,
-0x66,
-0x7e,
-0x60,
-0x60,
-0x60,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x2c,
-0x46,
-0x00,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x60,
-0x30,
-0x08,
-0x00,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x66,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x2c,
-0x2c,
-0x2c,
-0x7e,
-0x46,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x24,
-0x18,
-0x18,
-0x3c,
-0x2c,
-0x2c,
-0x2c,
-0x7e,
-0x46,
-0x46,
-0x46,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x0c,
-0x18,
-0xff,
-0x61,
-0x60,
-0x60,
-0x64,
-0x7c,
-0x64,
-0x60,
-0x60,
-0x61,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x76,
-0x9b,
-0x1b,
-0x3f,
-0xd8,
-0xd8,
-0xd9,
-0x6e,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1f,
-0x1d,
-0x1d,
-0x3c,
-0x2c,
-0x2e,
-0x2c,
-0x7c,
-0x4c,
-0x4c,
-0x4d,
-0xef,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x2c,
-0x46,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x18,
-0x04,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x2c,
-0x46,
-0x00,
-0xee,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x3a,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x18,
-0x04,
-0x00,
-0xee,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x3a,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x66,
-0x00,
-0x00,
-0xf7,
-0x62,
-0x62,
-0x34,
-0x34,
-0x18,
-0x18,
-0x18,
-0x10,
-0xb0,
-0xe0,
-
-0x66,
-0x00,
-0x3c,
-0x66,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x66,
-0x00,
-0xf7,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x62,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x10,
-0x10,
-0x10,
-0x7c,
-0xc6,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0xc2,
-0x7c,
-0x10,
-0x10,
-0x00,
-
-0x00,
-0x38,
-0x64,
-0x6c,
-0x60,
-0x60,
-0xf0,
-0x60,
-0x60,
-0x60,
-0x60,
-0x66,
-0xfc,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x81,
-0xc3,
-0x66,
-0x3c,
-0x18,
-0xff,
-0x18,
-0x18,
-0xff,
-0x18,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xfe,
-0x63,
-0x63,
-0x63,
-0x63,
-0x6e,
-0x60,
-0x64,
-0x6e,
-0x64,
-0x64,
-0xf5,
-0x06,
-0x00,
-0x00,
-
-0x00,
-0x0e,
-0x19,
-0x1b,
-0x18,
-0x18,
-0x3c,
-0x18,
-0x18,
-0x18,
-0x18,
-0xd8,
-0x98,
-0x70,
-0x00,
-0x00,
-
-0x00,
-0x0c,
-0x18,
-0x20,
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x06,
-0x0c,
-0x10,
-0x00,
-0x38,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x0c,
-0x18,
-0x20,
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x0c,
-0x18,
-0x20,
-0x00,
-0xee,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x3a,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x32,
-0x4c,
-0x00,
-0x5c,
-0xf6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xf7,
-0x00,
-0x00,
-0x00,
-
-0x32,
-0x4c,
-0x00,
-0xe7,
-0x72,
-0x52,
-0x5a,
-0x4a,
-0x4e,
-0x46,
-0x46,
-0x42,
-0xe2,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x78,
-0x8c,
-0x0c,
-0x3c,
-0xcc,
-0xcc,
-0xcd,
-0x76,
-0x00,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x30,
-0x30,
-0x00,
-0x30,
-0x10,
-0x10,
-0x20,
-0x40,
-0xc0,
-0xc6,
-0xc2,
-0x7c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0xc0,
-0xc0,
-0xc0,
-0xc0,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0x06,
-0x06,
-0x06,
-0x06,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x20,
-0xe0,
-0x63,
-0x66,
-0xfc,
-0x18,
-0x30,
-0x60,
-0xce,
-0x93,
-0x06,
-0x0c,
-0x1f,
-0x00,
-0x00,
-
-0x00,
-0x20,
-0xe0,
-0x63,
-0x66,
-0xfc,
-0x18,
-0x30,
-0x64,
-0xc8,
-0x96,
-0x3f,
-0x06,
-0x06,
-0x00,
-0x00,
-
-0x00,
-0x18,
-0x18,
-0x00,
-0x08,
-0x18,
-0x18,
-0x18,
-0x3c,
-0x3c,
-0x3c,
-0x3c,
-0x18,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x36,
-0x6c,
-0xd8,
-0xd8,
-0x6c,
-0x36,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xd8,
-0x6c,
-0x36,
-0x36,
-0x6c,
-0xd8,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-0x82,
-0x10,
-
-0x00,
-0x95,
-0x00,
-0xa9,
-0x00,
-0x95,
-0x00,
-0xa9,
-0x00,
-0x95,
-0x00,
-0xa9,
-0x00,
-0x95,
-0x00,
-0xa9,
-
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-0x92,
-0x49,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xf8,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xf8,
-0x18,
-0x18,
-0xf8,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xe6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf8,
-0x18,
-0x18,
-0xf8,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xe6,
-0x06,
-0x06,
-0xe6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xfe,
-0x06,
-0x06,
-0xe6,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xe6,
-0x06,
-0x06,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xf8,
-0x18,
-0x18,
-0xf8,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xf8,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x1f,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x1f,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xff,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x1f,
-0x18,
-0x18,
-0x1f,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x60,
-0x60,
-0x7f,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7f,
-0x60,
-0x60,
-0x67,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xe7,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0xe7,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x67,
-0x60,
-0x60,
-0x67,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xe7,
-0x00,
-0x00,
-0xe7,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xff,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x00,
-0x00,
-0xff,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x7f,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x1f,
-0x18,
-0x18,
-0x1f,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x1f,
-0x18,
-0x18,
-0x1f,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7f,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0xff,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xff,
-0x00,
-0x00,
-0xff,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xf8,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x1f,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-0xf0,
-
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-0x0f,
-
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0xff,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x77,
-0xcc,
-0xcc,
-0xcc,
-0xcc,
-0xde,
-0x73,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x7c,
-0xc6,
-0xc6,
-0xc6,
-0xc4,
-0xc8,
-0xc4,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xdc,
-0xc0,
-0xc0,
-0x00,
-
-0x00,
-0xff,
-0x61,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0x60,
-0xf0,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x01,
-0x7e,
-0xa4,
-0x24,
-0x2c,
-0x6c,
-0x6c,
-0x6c,
-0x48,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xff,
-0xc1,
-0x60,
-0x30,
-0x18,
-0x0c,
-0x18,
-0x30,
-0x60,
-0xc0,
-0xc1,
-0xfe,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7f,
-0xc8,
-0xc8,
-0xc8,
-0xc8,
-0xc8,
-0xc8,
-0x70,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x22,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x7c,
-0x60,
-0x60,
-0x60,
-0xc0,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x76,
-0xdc,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x10,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x38,
-0x10,
-0x7c,
-0xd6,
-0xd6,
-0xd6,
-0xd6,
-0xd6,
-0xd6,
-0x7c,
-0x10,
-0x38,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x38,
-0x6c,
-0xc6,
-0xc6,
-0xc6,
-0xfe,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0x6c,
-0x38,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x3c,
-0x66,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0xc3,
-0x66,
-0x24,
-0x24,
-0xa5,
-0xe7,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1e,
-0x31,
-0x30,
-0x18,
-0x0c,
-0x3e,
-0x66,
-0x66,
-0x66,
-0x66,
-0x66,
-0x3c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x6e,
-0xff,
-0x99,
-0x99,
-0x99,
-0x99,
-0xff,
-0x76,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x02,
-0x04,
-0x7c,
-0xca,
-0x92,
-0xa6,
-0x7c,
-0x40,
-0x80,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x1c,
-0x30,
-0x60,
-0x60,
-0x60,
-0x7c,
-0x60,
-0x60,
-0x60,
-0x60,
-0x30,
-0x1c,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x7c,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0xc6,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x7c,
-0x00,
-0x00,
-0x00,
-0xfe,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x18,
-0x7e,
-0x18,
-0x18,
-0x00,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x30,
-0x18,
-0x0c,
-0x06,
-0x0c,
-0x18,
-0x30,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x0c,
-0x18,
-0x30,
-0x60,
-0x30,
-0x18,
-0x0c,
-0x00,
-0x7e,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x0e,
-0x19,
-0x1b,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0x18,
-0xd8,
-0x98,
-0x70,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x18,
-0x00,
-0x7e,
-0x00,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x76,
-0xdc,
-0x00,
-0x00,
-0x76,
-0xdc,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x38,
-0x44,
-0x44,
-0x44,
-0x38,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x18,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x07,
-0x06,
-0x06,
-0x0c,
-0x0c,
-0x08,
-0x98,
-0xd0,
-0xf0,
-0x60,
-0x20,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0xcc,
-0x76,
-0x66,
-0x66,
-0x66,
-0x66,
-0xf7,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x70,
-0x98,
-0x18,
-0x30,
-0x60,
-0x88,
-0xf8,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x7c,
-0x64,
-0x64,
-0x64,
-0x64,
-0x64,
-0x7c,
-0x00,
-0x00,
-0x00,
-0x00,
-
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-0x00,
-
-};
-
-
-const struct font_desc font_rl = {
-        RL_IDX,
-        "RomanLarge",
-        8,
-        16,
-        patterns,
-        -1
-};
diff --git a/drivers/video/console/fonts.c b/drivers/video/console/fonts.c
index 9be83bed1959..4fd07d9eca03 100644
--- a/drivers/video/console/fonts.c
+++ b/drivers/video/console/fonts.c
@@ -64,10 +64,6 @@ static const struct font_desc *fonts[] = {
 #undef NO_FONTS
     &font_mini_4x6,
 #endif
-#ifdef CONFIG_FONT_RL
-#undef NO_FONTS
-    &font_rl,
-#endif
 };
 
 #define num_fonts (sizeof(fonts)/sizeof(*fonts))
diff --git a/drivers/video/ffb.c b/drivers/video/ffb.c
index 04417dc16c2e..2584daec7bbf 100644
--- a/drivers/video/ffb.c
+++ b/drivers/video/ffb.c
@@ -57,6 +57,9 @@ static struct fb_ops ffb_ops = {
         .fb_sync                = ffb_sync,
         .fb_mmap                = ffb_mmap,
         .fb_ioctl               = ffb_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 /* Register layout and definitions */
diff --git a/drivers/video/leo.c b/drivers/video/leo.c
index 84a7fe435bb8..376d4a171ec7 100644
--- a/drivers/video/leo.c
+++ b/drivers/video/leo.c
@@ -51,6 +51,9 @@ static struct fb_ops leo_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = leo_mmap,
         .fb_ioctl               = leo_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 #define LEO_OFF_LC_SS0_KRN      0x00200000UL
diff --git a/drivers/video/nvidia/nv_proto.h b/drivers/video/nvidia/nv_proto.h
index f60b1f432270..3353103e8b0b 100644
--- a/drivers/video/nvidia/nv_proto.h
+++ b/drivers/video/nvidia/nv_proto.h
@@ -42,7 +42,7 @@ int nvidia_probe_i2c_connector(struct fb_info *info, int conn,
 #define nvidia_probe_i2c_connector(p, c, edid) (-1)
 #endif
 
-#ifdef CONFIG_FB_OF
+#ifdef CONFIG_PPC_OF
 int nvidia_probe_of_connector(struct fb_info *info, int conn,
                               u8 ** out_edid);
 #else
diff --git a/drivers/video/nvidia/nvidia.c b/drivers/video/nvidia/nvidia.c
index 0b40a2a721c1..bee09c6e48f6 100644
--- a/drivers/video/nvidia/nvidia.c
+++ b/drivers/video/nvidia/nvidia.c
@@ -1301,7 +1301,7 @@ static int nvidiafb_pan_display(struct fb_var_screeninfo *var,
         struct nvidia_par *par = info->par;
         u32 total;
 
-        total = info->var.yoffset * info->fix.line_length + info->var.xoffset;
+        total = var->yoffset * info->fix.line_length + var->xoffset;
 
         NVSetStartAddress(par, total);
 
diff --git a/drivers/video/offb.c b/drivers/video/offb.c
index 2c856838694e..00d87f5bb7be 100644
--- a/drivers/video/offb.c
+++ b/drivers/video/offb.c
@@ -26,6 +26,7 @@
 #include <linux/fb.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/pci.h>
 #include <asm/io.h>
 #include <asm/prom.h>
 
@@ -325,8 +326,8 @@ static void __init offb_init_nodriver(struct device_node *dp)
         int *pp, i;
         unsigned int len;
         int width = 640, height = 480, depth = 8, pitch;
-        unsigned *up;
-        unsigned long address;
+        unsigned int rsize, *up;
+        unsigned long address = 0;
 
         if ((pp = (int *) get_property(dp, "depth", &len)) != NULL
             && len == sizeof(int))
@@ -344,10 +345,40 @@ static void __init offb_init_nodriver(struct device_node *dp)
                         pitch = 0x1000;
         } else
                 pitch = width;
-        if ((up = (unsigned *) get_property(dp, "address", &len)) != NULL
-            && len == sizeof(unsigned))
+
+       rsize = (unsigned long)pitch * (unsigned long)height *
+               (unsigned long)(depth / 8);
+
+       /* Try to match device to a PCI device in order to get a properly
+        * translated address rather then trying to decode the open firmware
+        * stuff in various incorrect ways
+        */
+#ifdef CONFIG_PCI
+       /* First try to locate the PCI device if any */
+       {
+               struct pci_dev *pdev = NULL;
+
+               for_each_pci_dev(pdev) {
+                       if (dp == pci_device_to_OF_node(pdev))
+                               break;
+               }
+               if (pdev) {
+                       for (i = 0; i < 6 && address == 0; i++) {
+                               if ((pci_resource_flags(pdev, i) &
+                                    IORESOURCE_MEM) &&
+                                   (pci_resource_len(pdev, i) >= rsize))
+                                       address = pci_resource_start(pdev, i);
+                       }
+                       pci_dev_put(pdev);
+               }
+        }
+#endif /* CONFIG_PCI */
+
+        if (address == 0 &&
+            (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
+            len == sizeof(unsigned))
                 address = (u_long) * up;
-        else {
+        if (address == 0) {
                 for (i = 0; i < dp->n_addrs; ++i)
                         if (dp->addrs[i].size >=
                             pitch * height * depth / 8)
diff --git a/drivers/video/p9100.c b/drivers/video/p9100.c
index 9aaf65fb623a..18bcda23d2cf 100644
--- a/drivers/video/p9100.c
+++ b/drivers/video/p9100.c
@@ -48,6 +48,9 @@ static struct fb_ops p9100_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = p9100_mmap,
         .fb_ioctl               = p9100_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 /* P9100 control registers */
diff --git a/drivers/video/sbuslib.c b/drivers/video/sbuslib.c
index 34f72edba820..646c43f921c5 100644
--- a/drivers/video/sbuslib.c
+++ b/drivers/video/sbuslib.c
@@ -3,6 +3,7 @@
  * Copyright (C) 2003 David S. Miller (davem@redhat.com)
  */
 
+#include <linux/compat.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/string.h>
@@ -182,3 +183,109 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg,
         };
 }
 EXPORT_SYMBOL(sbusfb_ioctl_helper);
+
+#ifdef CONFIG_COMPAT
+struct  fbcmap32 {
+        int             index;          /* first element (0 origin) */
+        int             count;
+        u32             red;
+        u32             green;
+        u32             blue;
+};
+
+#define FBIOPUTCMAP32   _IOW('F', 3, struct fbcmap32)
+#define FBIOGETCMAP32   _IOW('F', 4, struct fbcmap32)
+
+static int fbiogetputcmap(struct file *file, struct fb_info *info,
+                unsigned int cmd, unsigned long arg)
+{
+        struct fbcmap32 __user *argp = (void __user *)arg;
+        struct fbcmap __user *p = compat_alloc_user_space(sizeof(*p));
+        u32 addr;
+        int ret;
+
+        ret = copy_in_user(p, argp, 2 * sizeof(int));
+        ret |= get_user(addr, &argp->red);
+        ret |= put_user(compat_ptr(addr), &p->red);
+        ret |= get_user(addr, &argp->green);
+        ret |= put_user(compat_ptr(addr), &p->green);
+        ret |= get_user(addr, &argp->blue);
+        ret |= put_user(compat_ptr(addr), &p->blue);
+        if (ret)
+                return -EFAULT;
+        return info->fbops->fb_ioctl(file->f_dentry->d_inode, file,
+                        (cmd == FBIOPUTCMAP32) ?
+                        FBIOPUTCMAP_SPARC : FBIOGETCMAP_SPARC,
+                        (unsigned long)p, info);
+}
+
+struct fbcursor32 {
+        short set;              /* what to set, choose from the list above */
+        short enable;           /* cursor on/off */
+        struct fbcurpos pos;    /* cursor position */
+        struct fbcurpos hot;    /* cursor hot spot */
+        struct fbcmap32 cmap;   /* color map info */
+        struct fbcurpos size;   /* cursor bit map size */
+        u32     image;          /* cursor image bits */
+        u32     mask;           /* cursor mask bits */
+};
+
+#define FBIOSCURSOR32   _IOW('F', 24, struct fbcursor32)
+#define FBIOGCURSOR32   _IOW('F', 25, struct fbcursor32)
+
+static int fbiogscursor(struct file *file, struct fb_info *info,
+                unsigned long arg)
+{
+        struct fbcursor __user *p = compat_alloc_user_space(sizeof(*p));
+        struct fbcursor32 __user *argp =  (void __user *)arg;
+        compat_uptr_t addr;
+        int ret;
+
+        ret = copy_in_user(p, argp,
+                              2 * sizeof (short) + 2 * sizeof(struct fbcurpos));
+        ret |= copy_in_user(&p->size, &argp->size, sizeof(struct fbcurpos));
+        ret |= copy_in_user(&p->cmap, &argp->cmap, 2 * sizeof(int));
+        ret |= get_user(addr, &argp->cmap.red);
+        ret |= put_user(compat_ptr(addr), &p->cmap.red);
+        ret |= get_user(addr, &argp->cmap.green);
+        ret |= put_user(compat_ptr(addr), &p->cmap.green);
+        ret |= get_user(addr, &argp->cmap.blue);
+        ret |= put_user(compat_ptr(addr), &p->cmap.blue);
+        ret |= get_user(addr, &argp->mask);
+        ret |= put_user(compat_ptr(addr), &p->mask);
+        ret |= get_user(addr, &argp->image);
+        ret |= put_user(compat_ptr(addr), &p->image);
+        if (ret)
+                return -EFAULT;
+        return info->fbops->fb_ioctl(file->f_dentry->d_inode, file,
+                        FBIOSCURSOR, (unsigned long)p, info);
+}
+
+long sbusfb_compat_ioctl(struct file *file, unsigned int cmd,
+                unsigned long arg, struct fb_info *info)
+{
+        switch (cmd) {
+        case FBIOGTYPE:
+        case FBIOSATTR:
+        case FBIOGATTR:
+        case FBIOSVIDEO:
+        case FBIOGVIDEO:
+        case FBIOGCURSOR32:     /* This is not implemented yet.
+                                   Later it should be converted... */
+        case FBIOSCURPOS:
+        case FBIOGCURPOS:
+        case FBIOGCURMAX:
+                return info->fbops->fb_ioctl(file->f_dentry->d_inode,
+                                file, cmd, arg, info);
+        case FBIOPUTCMAP32:
+                return fbiogetputcmap(file, info, cmd, arg);
+        case FBIOGETCMAP32:
+                return fbiogetputcmap(file, info, cmd, arg);
+        case FBIOSCURSOR32:
+                return fbiogscursor(file, info, arg);
+        default:
+                return -ENOIOCTLCMD;
+        }
+}
+EXPORT_SYMBOL(sbusfb_compat_ioctl);
+#endif
diff --git a/drivers/video/sbuslib.h b/drivers/video/sbuslib.h
index a6aa33ba09d6..b470e52ce9e2 100644
--- a/drivers/video/sbuslib.h
+++ b/drivers/video/sbuslib.h
@@ -20,5 +20,7 @@ extern int sbusfb_mmap_helper(struct sbus_mmap_map *map,
 int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg,
                         struct fb_info *info,
                         int type, int fb_depth, unsigned long fb_size);
+long sbusfb_compat_ioctl(struct file *file, unsigned int cmd,
+                unsigned long arg, struct fb_info *info);
 
 #endif /* _SBUSLIB_H */
diff --git a/drivers/video/tcx.c b/drivers/video/tcx.c
index 59fff29bc02e..fe4f63f3849d 100644
--- a/drivers/video/tcx.c
+++ b/drivers/video/tcx.c
@@ -52,6 +52,9 @@ static struct fb_ops tcx_ops = {
         .fb_imageblit           = cfb_imageblit,
         .fb_mmap                = tcx_mmap,
         .fb_ioctl               = tcx_ioctl,
+#ifdef CONFIG_COMPAT
+        .fb_compat_ioctl        = sbusfb_compat_ioctl,
+#endif
 };
 
 /* THC definitions */
diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
index 2c3aa2fcfd91..3e58ddc2bc38 100644
--- a/drivers/video/vesafb.c
+++ b/drivers/video/vesafb.c
@@ -413,6 +413,7 @@ static int __init vesafb_probe(struct platform_device *dev)
          * region already (FIXME) */
         request_region(0x3c0, 32, "vesafb");
 
+#ifdef CONFIG_MTRR
         if (mtrr) {
                 unsigned int temp_size = size_total;
                 unsigned int type = 0;
@@ -450,6 +451,7 @@ static int __init vesafb_probe(struct platform_device *dev)
                         } while (temp_size >= PAGE_SIZE && rc == -EINVAL);
                 }
         }
+#endif
         
         info->fbops = &vesafb_ops;
         info->var = vesafb_defined;
diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
index daa46051f55d..f6e24ee85f07 100644
--- a/drivers/video/w100fb.c
+++ b/drivers/video/w100fb.c
@@ -514,7 +514,7 @@ int __init w100fb_probe(struct platform_device *pdev)
         if (remapped_fbuf == NULL)
                 goto out;
 
-        info=framebuffer_alloc(sizeof(struct w100fb_par), dev);
+        info=framebuffer_alloc(sizeof(struct w100fb_par), &pdev->dev);
         if (!info) {
                 err = -ENOMEM;
                 goto out;