diff options
Diffstat (limited to 'drivers')
82 files changed, 401 insertions, 339 deletions
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 22327e6a7236..5ea5c32609ac 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig | |||
| @@ -24,7 +24,7 @@ menuconfig ACPI | |||
| 24 | are configured, ACPI is used. | 24 | are configured, ACPI is used. |
| 25 | 25 | ||
| 26 | The project home page for the Linux ACPI subsystem is here: | 26 | The project home page for the Linux ACPI subsystem is here: |
| 27 | <http://www.lesswatts.org/projects/acpi/> | 27 | <https://01.org/linux-acpi> |
| 28 | 28 | ||
| 29 | Linux support for ACPI is based on Intel Corporation's ACPI | 29 | Linux support for ACPI is based on Intel Corporation's ACPI |
| 30 | Component Architecture (ACPI CA). For more information on the | 30 | Component Architecture (ACPI CA). For more information on the |
diff --git a/drivers/char/random.c b/drivers/char/random.c index 7737b5bd26af..7a744d391756 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c | |||
| @@ -640,7 +640,7 @@ struct timer_rand_state { | |||
| 640 | */ | 640 | */ |
| 641 | void add_device_randomness(const void *buf, unsigned int size) | 641 | void add_device_randomness(const void *buf, unsigned int size) |
| 642 | { | 642 | { |
| 643 | unsigned long time = get_cycles() ^ jiffies; | 643 | unsigned long time = random_get_entropy() ^ jiffies; |
| 644 | 644 | ||
| 645 | mix_pool_bytes(&input_pool, buf, size, NULL); | 645 | mix_pool_bytes(&input_pool, buf, size, NULL); |
| 646 | mix_pool_bytes(&input_pool, &time, sizeof(time), NULL); | 646 | mix_pool_bytes(&input_pool, &time, sizeof(time), NULL); |
| @@ -677,7 +677,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num) | |||
| 677 | goto out; | 677 | goto out; |
| 678 | 678 | ||
| 679 | sample.jiffies = jiffies; | 679 | sample.jiffies = jiffies; |
| 680 | sample.cycles = get_cycles(); | 680 | sample.cycles = random_get_entropy(); |
| 681 | sample.num = num; | 681 | sample.num = num; |
| 682 | mix_pool_bytes(&input_pool, &sample, sizeof(sample), NULL); | 682 | mix_pool_bytes(&input_pool, &sample, sizeof(sample), NULL); |
| 683 | 683 | ||
| @@ -744,7 +744,7 @@ void add_interrupt_randomness(int irq, int irq_flags) | |||
| 744 | struct fast_pool *fast_pool = &__get_cpu_var(irq_randomness); | 744 | struct fast_pool *fast_pool = &__get_cpu_var(irq_randomness); |
| 745 | struct pt_regs *regs = get_irq_regs(); | 745 | struct pt_regs *regs = get_irq_regs(); |
| 746 | unsigned long now = jiffies; | 746 | unsigned long now = jiffies; |
| 747 | __u32 input[4], cycles = get_cycles(); | 747 | __u32 input[4], cycles = random_get_entropy(); |
| 748 | 748 | ||
| 749 | input[0] = cycles ^ jiffies; | 749 | input[0] = cycles ^ jiffies; |
| 750 | input[1] = irq; | 750 | input[1] = irq; |
| @@ -1459,12 +1459,11 @@ struct ctl_table random_table[] = { | |||
| 1459 | 1459 | ||
| 1460 | static u32 random_int_secret[MD5_MESSAGE_BYTES / 4] ____cacheline_aligned; | 1460 | static u32 random_int_secret[MD5_MESSAGE_BYTES / 4] ____cacheline_aligned; |
| 1461 | 1461 | ||
| 1462 | static int __init random_int_secret_init(void) | 1462 | int random_int_secret_init(void) |
| 1463 | { | 1463 | { |
| 1464 | get_random_bytes(random_int_secret, sizeof(random_int_secret)); | 1464 | get_random_bytes(random_int_secret, sizeof(random_int_secret)); |
| 1465 | return 0; | 1465 | return 0; |
| 1466 | } | 1466 | } |
| 1467 | late_initcall(random_int_secret_init); | ||
| 1468 | 1467 | ||
| 1469 | /* | 1468 | /* |
| 1470 | * Get a random word for internal kernel use only. Similar to urandom but | 1469 | * Get a random word for internal kernel use only. Similar to urandom but |
| @@ -1483,7 +1482,7 @@ unsigned int get_random_int(void) | |||
| 1483 | 1482 | ||
| 1484 | hash = get_cpu_var(get_random_int_hash); | 1483 | hash = get_cpu_var(get_random_int_hash); |
| 1485 | 1484 | ||
| 1486 | hash[0] += current->pid + jiffies + get_cycles(); | 1485 | hash[0] += current->pid + jiffies + random_get_entropy(); |
| 1487 | md5_transform(hash, random_int_secret); | 1486 | md5_transform(hash, random_int_secret); |
| 1488 | ret = hash[0]; | 1487 | ret = hash[0]; |
| 1489 | put_cpu_var(get_random_int_hash); | 1488 | put_cpu_var(get_random_int_hash); |
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 098a8da450f0..3519111c566b 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c | |||
| @@ -306,6 +306,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( | |||
| 306 | EDMA_SLOT_ANY); | 306 | EDMA_SLOT_ANY); |
| 307 | if (echan->slot[i] < 0) { | 307 | if (echan->slot[i] < 0) { |
| 308 | dev_err(dev, "Failed to allocate slot\n"); | 308 | dev_err(dev, "Failed to allocate slot\n"); |
| 309 | kfree(edesc); | ||
| 309 | return NULL; | 310 | return NULL; |
| 310 | } | 311 | } |
| 311 | } | 312 | } |
diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c index 45a520281ce1..ebad84591a6e 100644 --- a/drivers/dma/sh/rcar-hpbdma.c +++ b/drivers/dma/sh/rcar-hpbdma.c | |||
| @@ -93,6 +93,7 @@ struct hpb_dmae_chan { | |||
| 93 | void __iomem *base; | 93 | void __iomem *base; |
| 94 | const struct hpb_dmae_slave_config *cfg; | 94 | const struct hpb_dmae_slave_config *cfg; |
| 95 | char dev_id[16]; /* unique name per DMAC of channel */ | 95 | char dev_id[16]; /* unique name per DMAC of channel */ |
| 96 | dma_addr_t slave_addr; | ||
| 96 | }; | 97 | }; |
| 97 | 98 | ||
| 98 | struct hpb_dmae_device { | 99 | struct hpb_dmae_device { |
| @@ -432,7 +433,6 @@ hpb_dmae_alloc_chan_resources(struct hpb_dmae_chan *hpb_chan, | |||
| 432 | hpb_chan->xfer_mode = XFER_DOUBLE; | 433 | hpb_chan->xfer_mode = XFER_DOUBLE; |
| 433 | } else { | 434 | } else { |
| 434 | dev_err(hpb_chan->shdma_chan.dev, "DCR setting error"); | 435 | dev_err(hpb_chan->shdma_chan.dev, "DCR setting error"); |
| 435 | shdma_free_irq(&hpb_chan->shdma_chan); | ||
| 436 | return -EINVAL; | 436 | return -EINVAL; |
| 437 | } | 437 | } |
| 438 | 438 | ||
| @@ -446,7 +446,8 @@ hpb_dmae_alloc_chan_resources(struct hpb_dmae_chan *hpb_chan, | |||
| 446 | return 0; | 446 | return 0; |
| 447 | } | 447 | } |
| 448 | 448 | ||
| 449 | static int hpb_dmae_set_slave(struct shdma_chan *schan, int slave_id, bool try) | 449 | static int hpb_dmae_set_slave(struct shdma_chan *schan, int slave_id, |
| 450 | dma_addr_t slave_addr, bool try) | ||
| 450 | { | 451 | { |
| 451 | struct hpb_dmae_chan *chan = to_chan(schan); | 452 | struct hpb_dmae_chan *chan = to_chan(schan); |
| 452 | const struct hpb_dmae_slave_config *sc = | 453 | const struct hpb_dmae_slave_config *sc = |
| @@ -457,6 +458,7 @@ static int hpb_dmae_set_slave(struct shdma_chan *schan, int slave_id, bool try) | |||
| 457 | if (try) | 458 | if (try) |
| 458 | return 0; | 459 | return 0; |
| 459 | chan->cfg = sc; | 460 | chan->cfg = sc; |
| 461 | chan->slave_addr = slave_addr ? : sc->addr; | ||
| 460 | return hpb_dmae_alloc_chan_resources(chan, sc); | 462 | return hpb_dmae_alloc_chan_resources(chan, sc); |
| 461 | } | 463 | } |
| 462 | 464 | ||
| @@ -468,7 +470,7 @@ static dma_addr_t hpb_dmae_slave_addr(struct shdma_chan *schan) | |||
| 468 | { | 470 | { |
| 469 | struct hpb_dmae_chan *chan = to_chan(schan); | 471 | struct hpb_dmae_chan *chan = to_chan(schan); |
| 470 | 472 | ||
| 471 | return chan->cfg->addr; | 473 | return chan->slave_addr; |
| 472 | } | 474 | } |
| 473 | 475 | ||
| 474 | static struct shdma_desc *hpb_dmae_embedded_desc(void *buf, int i) | 476 | static struct shdma_desc *hpb_dmae_embedded_desc(void *buf, int i) |
| @@ -614,7 +616,6 @@ static void hpb_dmae_chan_remove(struct hpb_dmae_device *hpbdev) | |||
| 614 | shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) { | 616 | shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) { |
| 615 | BUG_ON(!schan); | 617 | BUG_ON(!schan); |
| 616 | 618 | ||
| 617 | shdma_free_irq(schan); | ||
| 618 | shdma_chan_remove(schan); | 619 | shdma_chan_remove(schan); |
| 619 | } | 620 | } |
| 620 | dma_dev->chancnt = 0; | 621 | dma_dev->chancnt = 0; |
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1688ff500513..830f7501cb4d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c | |||
| @@ -2925,6 +2925,8 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb) | |||
| 2925 | /* Speaker Allocation Data Block */ | 2925 | /* Speaker Allocation Data Block */ |
| 2926 | if (dbl == 3) { | 2926 | if (dbl == 3) { |
| 2927 | *sadb = kmalloc(dbl, GFP_KERNEL); | 2927 | *sadb = kmalloc(dbl, GFP_KERNEL); |
| 2928 | if (!*sadb) | ||
| 2929 | return -ENOMEM; | ||
| 2928 | memcpy(*sadb, &db[1], dbl); | 2930 | memcpy(*sadb, &db[1], dbl); |
| 2929 | count = dbl; | 2931 | count = dbl; |
| 2930 | break; | 2932 | break; |
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6f6cc7fc133..3d13ca6e257f 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c | |||
| @@ -416,14 +416,6 @@ static void drm_fb_helper_dpms(struct fb_info *info, int dpms_mode) | |||
| 416 | return; | 416 | return; |
| 417 | 417 | ||
| 418 | /* | 418 | /* |
| 419 | * fbdev->blank can be called from irq context in case of a panic. | ||
| 420 | * Since we already have our own special panic handler which will | ||
| 421 | * restore the fbdev console mode completely, just bail out early. | ||
| 422 | */ | ||
| 423 | if (oops_in_progress) | ||
| 424 | return; | ||
| 425 | |||
| 426 | /* | ||
| 427 | * For each CRTC in this fb, turn the connectors on/off. | 419 | * For each CRTC in this fb, turn the connectors on/off. |
| 428 | */ | 420 | */ |
| 429 | drm_modeset_lock_all(dev); | 421 | drm_modeset_lock_all(dev); |
diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 92babac362ec..2db731f00930 100644 --- a/drivers/gpu/drm/gma500/gtt.c +++ b/drivers/gpu/drm/gma500/gtt.c | |||
| @@ -204,6 +204,7 @@ static int psb_gtt_attach_pages(struct gtt_range *gt) | |||
| 204 | if (IS_ERR(pages)) | 204 | if (IS_ERR(pages)) |
| 205 | return PTR_ERR(pages); | 205 | return PTR_ERR(pages); |
| 206 | 206 | ||
| 207 | gt->npage = gt->gem.size / PAGE_SIZE; | ||
| 207 | gt->pages = pages; | 208 | gt->pages = pages; |
| 208 | 209 | ||
| 209 | return 0; | 210 | return 0; |
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index c27a21034a5e..d5c784d48671 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c | |||
| @@ -1290,12 +1290,9 @@ static int i915_load_modeset_init(struct drm_device *dev) | |||
| 1290 | * then we do not take part in VGA arbitration and the | 1290 | * then we do not take part in VGA arbitration and the |
| 1291 | * vga_client_register() fails with -ENODEV. | 1291 | * vga_client_register() fails with -ENODEV. |
| 1292 | */ | 1292 | */ |
| 1293 | if (!HAS_PCH_SPLIT(dev)) { | 1293 | ret = vga_client_register(dev->pdev, dev, NULL, i915_vga_set_decode); |
| 1294 | ret = vga_client_register(dev->pdev, dev, NULL, | 1294 | if (ret && ret != -ENODEV) |
| 1295 | i915_vga_set_decode); | 1295 | goto out; |
| 1296 | if (ret && ret != -ENODEV) | ||
| 1297 | goto out; | ||
| 1298 | } | ||
| 1299 | 1296 | ||
| 1300 | intel_register_dsm_handler(); | 1297 | intel_register_dsm_handler(); |
| 1301 | 1298 | ||
| @@ -1351,12 +1348,6 @@ static int i915_load_modeset_init(struct drm_device *dev) | |||
| 1351 | */ | 1348 | */ |
| 1352 | intel_fbdev_initial_config(dev); | 1349 | intel_fbdev_initial_config(dev); |
| 1353 | 1350 | ||
| 1354 | /* | ||
| 1355 | * Must do this after fbcon init so that | ||
| 1356 | * vgacon_save_screen() works during the handover. | ||
| 1357 | */ | ||
| 1358 | i915_disable_vga_mem(dev); | ||
| 1359 | |||
| 1360 | /* Only enable hotplug handling once the fbdev is fully set up. */ | 1351 | /* Only enable hotplug handling once the fbdev is fully set up. */ |
| 1361 | dev_priv->enable_hotplug_processing = true; | 1352 | dev_priv->enable_hotplug_processing = true; |
| 1362 | 1353 | ||
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c159e1a6810f..38f96f65d87a 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h | |||
| @@ -3881,6 +3881,9 @@ | |||
| 3881 | #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030 | 3881 | #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030 |
| 3882 | #define GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB (1<<11) | 3882 | #define GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB (1<<11) |
| 3883 | 3883 | ||
| 3884 | #define HSW_SCRATCH1 0xb038 | ||
| 3885 | #define HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE (1<<27) | ||
| 3886 | |||
| 3884 | #define HSW_FUSE_STRAP 0x42014 | 3887 | #define HSW_FUSE_STRAP 0x42014 |
| 3885 | #define HSW_CDCLK_LIMIT (1 << 24) | 3888 | #define HSW_CDCLK_LIMIT (1 << 24) |
| 3886 | 3889 | ||
| @@ -4728,6 +4731,9 @@ | |||
| 4728 | #define GEN7_ROW_CHICKEN2_GT2 0xf4f4 | 4731 | #define GEN7_ROW_CHICKEN2_GT2 0xf4f4 |
| 4729 | #define DOP_CLOCK_GATING_DISABLE (1<<0) | 4732 | #define DOP_CLOCK_GATING_DISABLE (1<<0) |
| 4730 | 4733 | ||
| 4734 | #define HSW_ROW_CHICKEN3 0xe49c | ||
| 4735 | #define HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE (1 << 6) | ||
| 4736 | |||
| 4731 | #define G4X_AUD_VID_DID (dev_priv->info->display_mmio_offset + 0x62020) | 4737 | #define G4X_AUD_VID_DID (dev_priv->info->display_mmio_offset + 0x62020) |
| 4732 | #define INTEL_AUDIO_DEVCL 0x808629FB | 4738 | #define INTEL_AUDIO_DEVCL 0x808629FB |
| 4733 | #define INTEL_AUDIO_DEVBLC 0x80862801 | 4739 | #define INTEL_AUDIO_DEVBLC 0x80862801 |
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e5822e79f912..581fb4b2f766 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
| @@ -3941,8 +3941,6 @@ static void intel_connector_check_state(struct intel_connector *connector) | |||
| 3941 | * consider. */ | 3941 | * consider. */ |
| 3942 | void intel_connector_dpms(struct drm_connector *connector, int mode) | 3942 | void intel_connector_dpms(struct drm_connector *connector, int mode) |
| 3943 | { | 3943 | { |
| 3944 | struct intel_encoder *encoder = intel_attached_encoder(connector); | ||
| 3945 | |||
| 3946 | /* All the simple cases only support two dpms states. */ | 3944 | /* All the simple cases only support two dpms states. */ |
| 3947 | if (mode != DRM_MODE_DPMS_ON) | 3945 | if (mode != DRM_MODE_DPMS_ON) |
| 3948 | mode = DRM_MODE_DPMS_OFF; | 3946 | mode = DRM_MODE_DPMS_OFF; |
| @@ -3953,10 +3951,8 @@ void intel_connector_dpms(struct drm_connector *connector, int mode) | |||
| 3953 | connector->dpms = mode; | 3951 | connector->dpms = mode; |
| 3954 | 3952 | ||
| 3955 | /* Only need to change hw state when actually enabled */ | 3953 | /* Only need to change hw state when actually enabled */ |
| 3956 | if (encoder->base.crtc) | 3954 | if (connector->encoder) |
| 3957 | intel_encoder_dpms(encoder, mode); | 3955 | intel_encoder_dpms(to_intel_encoder(connector->encoder), mode); |
| 3958 | else | ||
| 3959 | WARN_ON(encoder->connectors_active != false); | ||
| 3960 | 3956 | ||
| 3961 | intel_modeset_check_state(connector->dev); | 3957 | intel_modeset_check_state(connector->dev); |
| 3962 | } | 3958 | } |
| @@ -10049,33 +10045,6 @@ static void i915_disable_vga(struct drm_device *dev) | |||
| 10049 | POSTING_READ(vga_reg); | 10045 | POSTING_READ(vga_reg); |
| 10050 | } | 10046 | } |
| 10051 | 10047 | ||
| 10052 | static void i915_enable_vga_mem(struct drm_device *dev) | ||
| 10053 | { | ||
| 10054 | /* Enable VGA memory on Intel HD */ | ||
| 10055 | if (HAS_PCH_SPLIT(dev)) { | ||
| 10056 | vga_get_uninterruptible(dev->pdev, VGA_RSRC_LEGACY_IO); | ||
| 10057 | outb(inb(VGA_MSR_READ) | VGA_MSR_MEM_EN, VGA_MSR_WRITE); | ||
| 10058 | vga_set_legacy_decoding(dev->pdev, VGA_RSRC_LEGACY_IO | | ||
| 10059 | VGA_RSRC_LEGACY_MEM | | ||
| 10060 | VGA_RSRC_NORMAL_IO | | ||
| 10061 | VGA_RSRC_NORMAL_MEM); | ||
| 10062 | vga_put(dev->pdev, VGA_RSRC_LEGACY_IO); | ||
| 10063 | } | ||
| 10064 | } | ||
| 10065 | |||
| 10066 | void i915_disable_vga_mem(struct drm_device *dev) | ||
| 10067 | { | ||
| 10068 | /* Disable VGA memory on Intel HD */ | ||
| 10069 | if (HAS_PCH_SPLIT(dev)) { | ||
| 10070 | vga_get_uninterruptible(dev->pdev, VGA_RSRC_LEGACY_IO); | ||
| 10071 | outb(inb(VGA_MSR_READ) & ~VGA_MSR_MEM_EN, VGA_MSR_WRITE); | ||
| 10072 | vga_set_legacy_decoding(dev->pdev, VGA_RSRC_LEGACY_IO | | ||
| 10073 | VGA_RSRC_NORMAL_IO | | ||
| 10074 | VGA_RSRC_NORMAL_MEM); | ||
| 10075 | vga_put(dev->pdev, VGA_RSRC_LEGACY_IO); | ||
| 10076 | } | ||
| 10077 | } | ||
| 10078 | |||
| 10079 | void intel_modeset_init_hw(struct drm_device *dev) | 10048 | void intel_modeset_init_hw(struct drm_device *dev) |
| 10080 | { | 10049 | { |
| 10081 | intel_init_power_well(dev); | 10050 | intel_init_power_well(dev); |
| @@ -10354,7 +10323,6 @@ void i915_redisable_vga(struct drm_device *dev) | |||
| 10354 | if (I915_READ(vga_reg) != VGA_DISP_DISABLE) { | 10323 | if (I915_READ(vga_reg) != VGA_DISP_DISABLE) { |
| 10355 | DRM_DEBUG_KMS("Something enabled VGA plane, disabling it\n"); | 10324 | DRM_DEBUG_KMS("Something enabled VGA plane, disabling it\n"); |
| 10356 | i915_disable_vga(dev); | 10325 | i915_disable_vga(dev); |
| 10357 | i915_disable_vga_mem(dev); | ||
| 10358 | } | 10326 | } |
| 10359 | } | 10327 | } |
| 10360 | 10328 | ||
| @@ -10568,8 +10536,6 @@ void intel_modeset_cleanup(struct drm_device *dev) | |||
| 10568 | 10536 | ||
| 10569 | intel_disable_fbc(dev); | 10537 | intel_disable_fbc(dev); |
| 10570 | 10538 | ||
| 10571 | i915_enable_vga_mem(dev); | ||
| 10572 | |||
| 10573 | intel_disable_gt_powersave(dev); | 10539 | intel_disable_gt_powersave(dev); |
| 10574 | 10540 | ||
| 10575 | ironlake_teardown_rc6(dev); | 10541 | ironlake_teardown_rc6(dev); |
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 79c14e298ba6..2c555f91bfae 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
| @@ -1467,7 +1467,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp) | |||
| 1467 | 1467 | ||
| 1468 | /* Avoid continuous PSR exit by masking memup and hpd */ | 1468 | /* Avoid continuous PSR exit by masking memup and hpd */ |
| 1469 | I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP | | 1469 | I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP | |
| 1470 | EDP_PSR_DEBUG_MASK_HPD); | 1470 | EDP_PSR_DEBUG_MASK_HPD | EDP_PSR_DEBUG_MASK_LPSP); |
| 1471 | 1471 | ||
| 1472 | intel_dp->psr_setup_done = true; | 1472 | intel_dp->psr_setup_done = true; |
| 1473 | } | 1473 | } |
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 28cae80495e2..9b7b68fd5d47 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
| @@ -793,6 +793,5 @@ extern void hsw_pc8_disable_interrupts(struct drm_device *dev); | |||
| 793 | extern void hsw_pc8_restore_interrupts(struct drm_device *dev); | 793 | extern void hsw_pc8_restore_interrupts(struct drm_device *dev); |
| 794 | extern void intel_aux_display_runtime_get(struct drm_i915_private *dev_priv); | 794 | extern void intel_aux_display_runtime_get(struct drm_i915_private *dev_priv); |
| 795 | extern void intel_aux_display_runtime_put(struct drm_i915_private *dev_priv); | 795 | extern void intel_aux_display_runtime_put(struct drm_i915_private *dev_priv); |
| 796 | extern void i915_disable_vga_mem(struct drm_device *dev); | ||
| 797 | 796 | ||
| 798 | #endif /* __INTEL_DRV_H__ */ | 797 | #endif /* __INTEL_DRV_H__ */ |
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index dd176b7296c1..f4c5e95b2d6f 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c | |||
| @@ -3864,8 +3864,6 @@ static void valleyview_enable_rps(struct drm_device *dev) | |||
| 3864 | dev_priv->rps.rpe_delay), | 3864 | dev_priv->rps.rpe_delay), |
| 3865 | dev_priv->rps.rpe_delay); | 3865 | dev_priv->rps.rpe_delay); |
| 3866 | 3866 | ||
| 3867 | INIT_DELAYED_WORK(&dev_priv->rps.vlv_work, vlv_rps_timer_work); | ||
| 3868 | |||
| 3869 | valleyview_set_rps(dev_priv->dev, dev_priv->rps.rpe_delay); | 3867 | valleyview_set_rps(dev_priv->dev, dev_priv->rps.rpe_delay); |
| 3870 | 3868 | ||
| 3871 | gen6_enable_rps_interrupts(dev); | 3869 | gen6_enable_rps_interrupts(dev); |
| @@ -4955,6 +4953,11 @@ static void haswell_init_clock_gating(struct drm_device *dev) | |||
| 4955 | I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, | 4953 | I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, |
| 4956 | GEN7_WA_L3_CHICKEN_MODE); | 4954 | GEN7_WA_L3_CHICKEN_MODE); |
| 4957 | 4955 | ||
| 4956 | /* L3 caching of data atomics doesn't work -- disable it. */ | ||
| 4957 | I915_WRITE(HSW_SCRATCH1, HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE); | ||
| 4958 | I915_WRITE(HSW_ROW_CHICKEN3, | ||
| 4959 | _MASKED_BIT_ENABLE(HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE)); | ||
| 4960 | |||
| 4958 | /* This is required by WaCatErrorRejectionIssue:hsw */ | 4961 | /* This is required by WaCatErrorRejectionIssue:hsw */ |
| 4959 | I915_WRITE(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG, | 4962 | I915_WRITE(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG, |
| 4960 | I915_READ(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG) | | 4963 | I915_READ(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG) | |
| @@ -5681,5 +5684,7 @@ void intel_pm_init(struct drm_device *dev) | |||
| 5681 | 5684 | ||
| 5682 | INIT_DELAYED_WORK(&dev_priv->rps.delayed_resume_work, | 5685 | INIT_DELAYED_WORK(&dev_priv->rps.delayed_resume_work, |
| 5683 | intel_gen6_powersave_work); | 5686 | intel_gen6_powersave_work); |
| 5687 | |||
| 5688 | INIT_DELAYED_WORK(&dev_priv->rps.vlv_work, vlv_rps_timer_work); | ||
| 5684 | } | 5689 | } |
| 5685 | 5690 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/base.c b/drivers/gpu/drm/nouveau/core/subdev/mc/base.c index 37712a6df923..e290cfa4acee 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/base.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/base.c | |||
| @@ -113,7 +113,7 @@ nouveau_mc_create_(struct nouveau_object *parent, struct nouveau_object *engine, | |||
| 113 | pmc->use_msi = false; | 113 | pmc->use_msi = false; |
| 114 | break; | 114 | break; |
| 115 | default: | 115 | default: |
| 116 | pmc->use_msi = nouveau_boolopt(device->cfgopt, "NvMSI", true); | 116 | pmc->use_msi = nouveau_boolopt(device->cfgopt, "NvMSI", false); |
| 117 | if (pmc->use_msi) { | 117 | if (pmc->use_msi) { |
| 118 | pmc->use_msi = pci_enable_msi(device->pdev) == 0; | 118 | pmc->use_msi = pci_enable_msi(device->pdev) == 0; |
| 119 | if (pmc->use_msi) { | 119 | if (pmc->use_msi) { |
diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c index b162e98a2953..9b6950d9b3c0 100644 --- a/drivers/gpu/drm/radeon/btc_dpm.c +++ b/drivers/gpu/drm/radeon/btc_dpm.c | |||
| @@ -1930,7 +1930,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev, | |||
| 1930 | } | 1930 | } |
| 1931 | j++; | 1931 | j++; |
| 1932 | 1932 | ||
| 1933 | if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) | 1933 | if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) |
| 1934 | return -EINVAL; | 1934 | return -EINVAL; |
| 1935 | 1935 | ||
| 1936 | tmp = RREG32(MC_PMG_CMD_MRS); | 1936 | tmp = RREG32(MC_PMG_CMD_MRS); |
| @@ -1945,7 +1945,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev, | |||
| 1945 | } | 1945 | } |
| 1946 | j++; | 1946 | j++; |
| 1947 | 1947 | ||
| 1948 | if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) | 1948 | if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) |
| 1949 | return -EINVAL; | 1949 | return -EINVAL; |
| 1950 | break; | 1950 | break; |
| 1951 | case MC_SEQ_RESERVE_M >> 2: | 1951 | case MC_SEQ_RESERVE_M >> 2: |
| @@ -1959,7 +1959,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev, | |||
| 1959 | } | 1959 | } |
| 1960 | j++; | 1960 | j++; |
| 1961 | 1961 | ||
| 1962 | if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) | 1962 | if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE) |
| 1963 | return -EINVAL; | 1963 | return -EINVAL; |
| 1964 | break; | 1964 | break; |
| 1965 | default: | 1965 | default: |
diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index d02fd1c045d5..b874ccdf52f7 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c | |||
| @@ -77,6 +77,8 @@ static void cik_pcie_gen3_enable(struct radeon_device *rdev); | |||
| 77 | static void cik_program_aspm(struct radeon_device *rdev); | 77 | static void cik_program_aspm(struct radeon_device *rdev); |
| 78 | static void cik_init_pg(struct radeon_device *rdev); | 78 | static void cik_init_pg(struct radeon_device *rdev); |
| 79 | static void cik_init_cg(struct radeon_device *rdev); | 79 | static void cik_init_cg(struct radeon_device *rdev); |
| 80 | static void cik_fini_pg(struct radeon_device *rdev); | ||
| 81 | static void cik_fini_cg(struct radeon_device *rdev); | ||
| 80 | static void cik_enable_gui_idle_interrupt(struct radeon_device *rdev, | 82 | static void cik_enable_gui_idle_interrupt(struct radeon_device *rdev, |
| 81 | bool enable); | 83 | bool enable); |
| 82 | 84 | ||
| @@ -4185,6 +4187,10 @@ static void cik_gpu_soft_reset(struct radeon_device *rdev, u32 reset_mask) | |||
| 4185 | dev_info(rdev->dev, " VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x%08X\n", | 4187 | dev_info(rdev->dev, " VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x%08X\n", |
| 4186 | RREG32(VM_CONTEXT1_PROTECTION_FAULT_STATUS)); | 4188 | RREG32(VM_CONTEXT1_PROTECTION_FAULT_STATUS)); |
| 4187 | 4189 | ||
| 4190 | /* disable CG/PG */ | ||
| 4191 | cik_fini_pg(rdev); | ||
| 4192 | cik_fini_cg(rdev); | ||
| 4193 | |||
| 4188 | /* stop the rlc */ | 4194 | /* stop the rlc */ |
| 4189 | cik_rlc_stop(rdev); | 4195 | cik_rlc_stop(rdev); |
| 4190 | 4196 | ||
diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 555164e270a7..b5c67a99dda9 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c | |||
| @@ -3131,7 +3131,7 @@ static void evergreen_gpu_init(struct radeon_device *rdev) | |||
| 3131 | rdev->config.evergreen.sx_max_export_size = 256; | 3131 | rdev->config.evergreen.sx_max_export_size = 256; |
| 3132 | rdev->config.evergreen.sx_max_export_pos_size = 64; | 3132 | rdev->config.evergreen.sx_max_export_pos_size = 64; |
| 3133 | rdev->config.evergreen.sx_max_export_smx_size = 192; | 3133 | rdev->config.evergreen.sx_max_export_smx_size = 192; |
| 3134 | rdev->config.evergreen.max_hw_contexts = 8; | 3134 | rdev->config.evergreen.max_hw_contexts = 4; |
| 3135 | rdev->config.evergreen.sq_num_cf_insts = 2; | 3135 | rdev->config.evergreen.sq_num_cf_insts = 2; |
| 3136 | 3136 | ||
| 3137 | rdev->config.evergreen.sc_prim_fifo_size = 0x40; | 3137 | rdev->config.evergreen.sc_prim_fifo_size = 0x40; |
diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c index f71ce390aebe..f815c20640bd 100644 --- a/drivers/gpu/drm/radeon/evergreen_hdmi.c +++ b/drivers/gpu/drm/radeon/evergreen_hdmi.c | |||
| @@ -288,8 +288,7 @@ void evergreen_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode | |||
| 288 | /* fglrx clears sth in AFMT_AUDIO_PACKET_CONTROL2 here */ | 288 | /* fglrx clears sth in AFMT_AUDIO_PACKET_CONTROL2 here */ |
| 289 | 289 | ||
| 290 | WREG32(HDMI_ACR_PACKET_CONTROL + offset, | 290 | WREG32(HDMI_ACR_PACKET_CONTROL + offset, |
| 291 | HDMI_ACR_AUTO_SEND | /* allow hw to sent ACR packets when required */ | 291 | HDMI_ACR_AUTO_SEND); /* allow hw to sent ACR packets when required */ |
| 292 | HDMI_ACR_SOURCE); /* select SW CTS value */ | ||
| 293 | 292 | ||
| 294 | evergreen_hdmi_update_ACR(encoder, mode->clock); | 293 | evergreen_hdmi_update_ACR(encoder, mode->clock); |
| 295 | 294 | ||
diff --git a/drivers/gpu/drm/radeon/evergreend.h b/drivers/gpu/drm/radeon/evergreend.h index 8768fd6a1e27..4f6d2962767d 100644 --- a/drivers/gpu/drm/radeon/evergreend.h +++ b/drivers/gpu/drm/radeon/evergreend.h | |||
| @@ -1501,7 +1501,7 @@ | |||
| 1501 | * 6. COMMAND [29:22] | BYTE_COUNT [20:0] | 1501 | * 6. COMMAND [29:22] | BYTE_COUNT [20:0] |
| 1502 | */ | 1502 | */ |
| 1503 | # define PACKET3_CP_DMA_DST_SEL(x) ((x) << 20) | 1503 | # define PACKET3_CP_DMA_DST_SEL(x) ((x) << 20) |
| 1504 | /* 0 - SRC_ADDR | 1504 | /* 0 - DST_ADDR |
| 1505 | * 1 - GDS | 1505 | * 1 - GDS |
| 1506 | */ | 1506 | */ |
| 1507 | # define PACKET3_CP_DMA_ENGINE(x) ((x) << 27) | 1507 | # define PACKET3_CP_DMA_ENGINE(x) ((x) << 27) |
| @@ -1516,7 +1516,7 @@ | |||
| 1516 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) | 1516 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) |
| 1517 | /* COMMAND */ | 1517 | /* COMMAND */ |
| 1518 | # define PACKET3_CP_DMA_DIS_WC (1 << 21) | 1518 | # define PACKET3_CP_DMA_DIS_WC (1 << 21) |
| 1519 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 23) | 1519 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 22) |
| 1520 | /* 0 - none | 1520 | /* 0 - none |
| 1521 | * 1 - 8 in 16 | 1521 | * 1 - 8 in 16 |
| 1522 | * 2 - 8 in 32 | 1522 | * 2 - 8 in 32 |
diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index b0fa6002af3e..5b729319f27b 100644 --- a/drivers/gpu/drm/radeon/r600_hdmi.c +++ b/drivers/gpu/drm/radeon/r600_hdmi.c | |||
| @@ -57,15 +57,15 @@ enum r600_hdmi_iec_status_bits { | |||
| 57 | static const struct radeon_hdmi_acr r600_hdmi_predefined_acr[] = { | 57 | static const struct radeon_hdmi_acr r600_hdmi_predefined_acr[] = { |
| 58 | /* 32kHz 44.1kHz 48kHz */ | 58 | /* 32kHz 44.1kHz 48kHz */ |
| 59 | /* Clock N CTS N CTS N CTS */ | 59 | /* Clock N CTS N CTS N CTS */ |
| 60 | { 25174, 4576, 28125, 7007, 31250, 6864, 28125 }, /* 25,20/1.001 MHz */ | 60 | { 25175, 4576, 28125, 7007, 31250, 6864, 28125 }, /* 25,20/1.001 MHz */ |
| 61 | { 25200, 4096, 25200, 6272, 28000, 6144, 25200 }, /* 25.20 MHz */ | 61 | { 25200, 4096, 25200, 6272, 28000, 6144, 25200 }, /* 25.20 MHz */ |
| 62 | { 27000, 4096, 27000, 6272, 30000, 6144, 27000 }, /* 27.00 MHz */ | 62 | { 27000, 4096, 27000, 6272, 30000, 6144, 27000 }, /* 27.00 MHz */ |
| 63 | { 27027, 4096, 27027, 6272, 30030, 6144, 27027 }, /* 27.00*1.001 MHz */ | 63 | { 27027, 4096, 27027, 6272, 30030, 6144, 27027 }, /* 27.00*1.001 MHz */ |
| 64 | { 54000, 4096, 54000, 6272, 60000, 6144, 54000 }, /* 54.00 MHz */ | 64 | { 54000, 4096, 54000, 6272, 60000, 6144, 54000 }, /* 54.00 MHz */ |
| 65 | { 54054, 4096, 54054, 6272, 60060, 6144, 54054 }, /* 54.00*1.001 MHz */ | 65 | { 54054, 4096, 54054, 6272, 60060, 6144, 54054 }, /* 54.00*1.001 MHz */ |
| 66 | { 74175, 11648, 210937, 17836, 234375, 11648, 140625 }, /* 74.25/1.001 MHz */ | 66 | { 74176, 11648, 210937, 17836, 234375, 11648, 140625 }, /* 74.25/1.001 MHz */ |
| 67 | { 74250, 4096, 74250, 6272, 82500, 6144, 74250 }, /* 74.25 MHz */ | 67 | { 74250, 4096, 74250, 6272, 82500, 6144, 74250 }, /* 74.25 MHz */ |
| 68 | { 148351, 11648, 421875, 8918, 234375, 5824, 140625 }, /* 148.50/1.001 MHz */ | 68 | { 148352, 11648, 421875, 8918, 234375, 5824, 140625 }, /* 148.50/1.001 MHz */ |
| 69 | { 148500, 4096, 148500, 6272, 165000, 6144, 148500 }, /* 148.50 MHz */ | 69 | { 148500, 4096, 148500, 6272, 165000, 6144, 148500 }, /* 148.50 MHz */ |
| 70 | { 0, 4096, 0, 6272, 0, 6144, 0 } /* Other */ | 70 | { 0, 4096, 0, 6272, 0, 6144, 0 } /* Other */ |
| 71 | }; | 71 | }; |
| @@ -75,8 +75,15 @@ static const struct radeon_hdmi_acr r600_hdmi_predefined_acr[] = { | |||
| 75 | */ | 75 | */ |
| 76 | static void r600_hdmi_calc_cts(uint32_t clock, int *CTS, int N, int freq) | 76 | static void r600_hdmi_calc_cts(uint32_t clock, int *CTS, int N, int freq) |
| 77 | { | 77 | { |
| 78 | if (*CTS == 0) | 78 | u64 n; |
| 79 | *CTS = clock * N / (128 * freq) * 1000; | 79 | u32 d; |
| 80 | |||
| 81 | if (*CTS == 0) { | ||
| 82 | n = (u64)clock * (u64)N * 1000ULL; | ||
| 83 | d = 128 * freq; | ||
| 84 | do_div(n, d); | ||
| 85 | *CTS = n; | ||
| 86 | } | ||
| 80 | DRM_DEBUG("Using ACR timing N=%d CTS=%d for frequency %d\n", | 87 | DRM_DEBUG("Using ACR timing N=%d CTS=%d for frequency %d\n", |
| 81 | N, *CTS, freq); | 88 | N, *CTS, freq); |
| 82 | } | 89 | } |
| @@ -444,8 +451,8 @@ void r600_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *mod | |||
| 444 | } | 451 | } |
| 445 | 452 | ||
| 446 | WREG32(HDMI0_ACR_PACKET_CONTROL + offset, | 453 | WREG32(HDMI0_ACR_PACKET_CONTROL + offset, |
| 447 | HDMI0_ACR_AUTO_SEND | /* allow hw to sent ACR packets when required */ | 454 | HDMI0_ACR_SOURCE | /* select SW CTS value - XXX verify that hw CTS works on all families */ |
| 448 | HDMI0_ACR_SOURCE); /* select SW CTS value */ | 455 | HDMI0_ACR_AUTO_SEND); /* allow hw to sent ACR packets when required */ |
| 449 | 456 | ||
| 450 | WREG32(HDMI0_VBI_PACKET_CONTROL + offset, | 457 | WREG32(HDMI0_VBI_PACKET_CONTROL + offset, |
| 451 | HDMI0_NULL_SEND | /* send null packets when required */ | 458 | HDMI0_NULL_SEND | /* send null packets when required */ |
diff --git a/drivers/gpu/drm/radeon/r600d.h b/drivers/gpu/drm/radeon/r600d.h index e673fe26ea84..7b3c7b5932c5 100644 --- a/drivers/gpu/drm/radeon/r600d.h +++ b/drivers/gpu/drm/radeon/r600d.h | |||
| @@ -1523,7 +1523,7 @@ | |||
| 1523 | */ | 1523 | */ |
| 1524 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) | 1524 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) |
| 1525 | /* COMMAND */ | 1525 | /* COMMAND */ |
| 1526 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 23) | 1526 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 22) |
| 1527 | /* 0 - none | 1527 | /* 0 - none |
| 1528 | * 1 - 8 in 16 | 1528 | * 1 - 8 in 16 |
| 1529 | * 2 - 8 in 32 | 1529 | * 2 - 8 in 32 |
diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c index ac07ad1d4f8c..4f6b7fc7ad3c 100644 --- a/drivers/gpu/drm/radeon/radeon_pm.c +++ b/drivers/gpu/drm/radeon/radeon_pm.c | |||
| @@ -945,6 +945,8 @@ void radeon_dpm_enable_uvd(struct radeon_device *rdev, bool enable) | |||
| 945 | if (enable) { | 945 | if (enable) { |
| 946 | mutex_lock(&rdev->pm.mutex); | 946 | mutex_lock(&rdev->pm.mutex); |
| 947 | rdev->pm.dpm.uvd_active = true; | 947 | rdev->pm.dpm.uvd_active = true; |
| 948 | /* disable this for now */ | ||
| 949 | #if 0 | ||
| 948 | if ((rdev->pm.dpm.sd == 1) && (rdev->pm.dpm.hd == 0)) | 950 | if ((rdev->pm.dpm.sd == 1) && (rdev->pm.dpm.hd == 0)) |
| 949 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_SD; | 951 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_SD; |
| 950 | else if ((rdev->pm.dpm.sd == 2) && (rdev->pm.dpm.hd == 0)) | 952 | else if ((rdev->pm.dpm.sd == 2) && (rdev->pm.dpm.hd == 0)) |
| @@ -954,6 +956,7 @@ void radeon_dpm_enable_uvd(struct radeon_device *rdev, bool enable) | |||
| 954 | else if ((rdev->pm.dpm.sd == 0) && (rdev->pm.dpm.hd == 2)) | 956 | else if ((rdev->pm.dpm.sd == 0) && (rdev->pm.dpm.hd == 2)) |
| 955 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_HD2; | 957 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_HD2; |
| 956 | else | 958 | else |
| 959 | #endif | ||
| 957 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD; | 960 | dpm_state = POWER_STATE_TYPE_INTERNAL_UVD; |
| 958 | rdev->pm.dpm.state = dpm_state; | 961 | rdev->pm.dpm.state = dpm_state; |
| 959 | mutex_unlock(&rdev->pm.mutex); | 962 | mutex_unlock(&rdev->pm.mutex); |
diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_test.c index f4d6bcee9006..12e8099a0823 100644 --- a/drivers/gpu/drm/radeon/radeon_test.c +++ b/drivers/gpu/drm/radeon/radeon_test.c | |||
| @@ -36,8 +36,8 @@ static void radeon_do_test_moves(struct radeon_device *rdev, int flag) | |||
| 36 | struct radeon_bo *vram_obj = NULL; | 36 | struct radeon_bo *vram_obj = NULL; |
| 37 | struct radeon_bo **gtt_obj = NULL; | 37 | struct radeon_bo **gtt_obj = NULL; |
| 38 | uint64_t gtt_addr, vram_addr; | 38 | uint64_t gtt_addr, vram_addr; |
| 39 | unsigned i, n, size; | 39 | unsigned n, size; |
| 40 | int r, ring; | 40 | int i, r, ring; |
| 41 | 41 | ||
| 42 | switch (flag) { | 42 | switch (flag) { |
| 43 | case RADEON_TEST_COPY_DMA: | 43 | case RADEON_TEST_COPY_DMA: |
diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index a0f11856ddde..4f2e73f79638 100644 --- a/drivers/gpu/drm/radeon/radeon_uvd.c +++ b/drivers/gpu/drm/radeon/radeon_uvd.c | |||
| @@ -798,7 +798,8 @@ void radeon_uvd_note_usage(struct radeon_device *rdev) | |||
| 798 | (rdev->pm.dpm.hd != hd)) { | 798 | (rdev->pm.dpm.hd != hd)) { |
| 799 | rdev->pm.dpm.sd = sd; | 799 | rdev->pm.dpm.sd = sd; |
| 800 | rdev->pm.dpm.hd = hd; | 800 | rdev->pm.dpm.hd = hd; |
| 801 | streams_changed = true; | 801 | /* disable this for now */ |
| 802 | /*streams_changed = true;*/ | ||
| 802 | } | 803 | } |
| 803 | } | 804 | } |
| 804 | 805 | ||
diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index c354c1094967..d4652af425b8 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c | |||
| @@ -85,6 +85,9 @@ extern void si_dma_vm_set_page(struct radeon_device *rdev, | |||
| 85 | uint32_t incr, uint32_t flags); | 85 | uint32_t incr, uint32_t flags); |
| 86 | static void si_enable_gui_idle_interrupt(struct radeon_device *rdev, | 86 | static void si_enable_gui_idle_interrupt(struct radeon_device *rdev, |
| 87 | bool enable); | 87 | bool enable); |
| 88 | static void si_fini_pg(struct radeon_device *rdev); | ||
| 89 | static void si_fini_cg(struct radeon_device *rdev); | ||
| 90 | static void si_rlc_stop(struct radeon_device *rdev); | ||
| 88 | 91 | ||
| 89 | static const u32 verde_rlc_save_restore_register_list[] = | 92 | static const u32 verde_rlc_save_restore_register_list[] = |
| 90 | { | 93 | { |
| @@ -3608,6 +3611,13 @@ static void si_gpu_soft_reset(struct radeon_device *rdev, u32 reset_mask) | |||
| 3608 | dev_info(rdev->dev, " VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x%08X\n", | 3611 | dev_info(rdev->dev, " VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x%08X\n", |
| 3609 | RREG32(VM_CONTEXT1_PROTECTION_FAULT_STATUS)); | 3612 | RREG32(VM_CONTEXT1_PROTECTION_FAULT_STATUS)); |
| 3610 | 3613 | ||
| 3614 | /* disable PG/CG */ | ||
| 3615 | si_fini_pg(rdev); | ||
| 3616 | si_fini_cg(rdev); | ||
| 3617 | |||
| 3618 | /* stop the rlc */ | ||
| 3619 | si_rlc_stop(rdev); | ||
| 3620 | |||
| 3611 | /* Disable CP parsing/prefetching */ | 3621 | /* Disable CP parsing/prefetching */ |
| 3612 | WREG32(CP_ME_CNTL, CP_ME_HALT | CP_PFP_HALT | CP_CE_HALT); | 3622 | WREG32(CP_ME_CNTL, CP_ME_HALT | CP_PFP_HALT | CP_CE_HALT); |
| 3613 | 3623 | ||
diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 9ace28702c76..2332aa1bf93c 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c | |||
| @@ -5208,7 +5208,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5208 | table->mc_reg_table_entry[k].mc_data[j] |= 0x100; | 5208 | table->mc_reg_table_entry[k].mc_data[j] |= 0x100; |
| 5209 | } | 5209 | } |
| 5210 | j++; | 5210 | j++; |
| 5211 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5211 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5212 | return -EINVAL; | 5212 | return -EINVAL; |
| 5213 | 5213 | ||
| 5214 | if (!pi->mem_gddr5) { | 5214 | if (!pi->mem_gddr5) { |
| @@ -5218,7 +5218,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5218 | table->mc_reg_table_entry[k].mc_data[j] = | 5218 | table->mc_reg_table_entry[k].mc_data[j] = |
| 5219 | (table->mc_reg_table_entry[k].mc_data[i] & 0xffff0000) >> 16; | 5219 | (table->mc_reg_table_entry[k].mc_data[i] & 0xffff0000) >> 16; |
| 5220 | j++; | 5220 | j++; |
| 5221 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5221 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5222 | return -EINVAL; | 5222 | return -EINVAL; |
| 5223 | } | 5223 | } |
| 5224 | break; | 5224 | break; |
| @@ -5231,7 +5231,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5231 | (temp_reg & 0xffff0000) | | 5231 | (temp_reg & 0xffff0000) | |
| 5232 | (table->mc_reg_table_entry[k].mc_data[i] & 0x0000ffff); | 5232 | (table->mc_reg_table_entry[k].mc_data[i] & 0x0000ffff); |
| 5233 | j++; | 5233 | j++; |
| 5234 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5234 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5235 | return -EINVAL; | 5235 | return -EINVAL; |
| 5236 | break; | 5236 | break; |
| 5237 | default: | 5237 | default: |
diff --git a/drivers/gpu/drm/radeon/sid.h b/drivers/gpu/drm/radeon/sid.h index 52d2ab6b67a0..7e2e0ea66a00 100644 --- a/drivers/gpu/drm/radeon/sid.h +++ b/drivers/gpu/drm/radeon/sid.h | |||
| @@ -1553,7 +1553,7 @@ | |||
| 1553 | * 6. COMMAND [30:21] | BYTE_COUNT [20:0] | 1553 | * 6. COMMAND [30:21] | BYTE_COUNT [20:0] |
| 1554 | */ | 1554 | */ |
| 1555 | # define PACKET3_CP_DMA_DST_SEL(x) ((x) << 20) | 1555 | # define PACKET3_CP_DMA_DST_SEL(x) ((x) << 20) |
| 1556 | /* 0 - SRC_ADDR | 1556 | /* 0 - DST_ADDR |
| 1557 | * 1 - GDS | 1557 | * 1 - GDS |
| 1558 | */ | 1558 | */ |
| 1559 | # define PACKET3_CP_DMA_ENGINE(x) ((x) << 27) | 1559 | # define PACKET3_CP_DMA_ENGINE(x) ((x) << 27) |
| @@ -1568,7 +1568,7 @@ | |||
| 1568 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) | 1568 | # define PACKET3_CP_DMA_CP_SYNC (1 << 31) |
| 1569 | /* COMMAND */ | 1569 | /* COMMAND */ |
| 1570 | # define PACKET3_CP_DMA_DIS_WC (1 << 21) | 1570 | # define PACKET3_CP_DMA_DIS_WC (1 << 21) |
| 1571 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 23) | 1571 | # define PACKET3_CP_DMA_CMD_SRC_SWAP(x) ((x) << 22) |
| 1572 | /* 0 - none | 1572 | /* 0 - none |
| 1573 | * 1 - 8 in 16 | 1573 | * 1 - 8 in 16 |
| 1574 | * 2 - 8 in 32 | 1574 | * 2 - 8 in 32 |
diff --git a/drivers/gpu/drm/radeon/trinity_dpm.c b/drivers/gpu/drm/radeon/trinity_dpm.c index 7f998bf1cc9d..9364129ba292 100644 --- a/drivers/gpu/drm/radeon/trinity_dpm.c +++ b/drivers/gpu/drm/radeon/trinity_dpm.c | |||
| @@ -1868,7 +1868,7 @@ int trinity_dpm_init(struct radeon_device *rdev) | |||
| 1868 | for (i = 0; i < SUMO_MAX_HARDWARE_POWERLEVELS; i++) | 1868 | for (i = 0; i < SUMO_MAX_HARDWARE_POWERLEVELS; i++) |
| 1869 | pi->at[i] = TRINITY_AT_DFLT; | 1869 | pi->at[i] = TRINITY_AT_DFLT; |
| 1870 | 1870 | ||
| 1871 | pi->enable_bapm = true; | 1871 | pi->enable_bapm = false; |
| 1872 | pi->enable_nbps_policy = true; | 1872 | pi->enable_nbps_policy = true; |
| 1873 | pi->enable_sclk_ds = true; | 1873 | pi->enable_sclk_ds = true; |
| 1874 | pi->enable_gfx_power_gating = true; | 1874 | pi->enable_gfx_power_gating = true; |
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 71b70e3a7a71..c91d547191dd 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig | |||
| @@ -241,6 +241,7 @@ config HID_HOLTEK | |||
| 241 | - Sharkoon Drakonia / Perixx MX-2000 gaming mice | 241 | - Sharkoon Drakonia / Perixx MX-2000 gaming mice |
| 242 | - Tracer Sniper TRM-503 / NOVA Gaming Slider X200 / | 242 | - Tracer Sniper TRM-503 / NOVA Gaming Slider X200 / |
| 243 | Zalman ZM-GM1 | 243 | Zalman ZM-GM1 |
| 244 | - SHARKOON DarkGlider Gaming mouse | ||
| 244 | 245 | ||
| 245 | config HOLTEK_FF | 246 | config HOLTEK_FF |
| 246 | bool "Holtek On Line Grip force feedback support" | 247 | bool "Holtek On Line Grip force feedback support" |
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index b8470b1a10fe..5a8c01112a23 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c | |||
| @@ -1715,6 +1715,7 @@ static const struct hid_device_id hid_have_special_driver[] = { | |||
| 1715 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD) }, | 1715 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD) }, |
| 1716 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A) }, | 1716 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A) }, |
| 1717 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067) }, | 1717 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067) }, |
| 1718 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081) }, | ||
| 1718 | { HID_USB_DEVICE(USB_VENDOR_ID_HUION, USB_DEVICE_ID_HUION_580) }, | 1719 | { HID_USB_DEVICE(USB_VENDOR_ID_HUION, USB_DEVICE_ID_HUION_580) }, |
| 1719 | { HID_USB_DEVICE(USB_VENDOR_ID_JESS2, USB_DEVICE_ID_JESS2_COLOR_RUMBLE_PAD) }, | 1720 | { HID_USB_DEVICE(USB_VENDOR_ID_JESS2, USB_DEVICE_ID_JESS2_COLOR_RUMBLE_PAD) }, |
| 1720 | { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ION, USB_DEVICE_ID_ICADE) }, | 1721 | { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ION, USB_DEVICE_ID_ICADE) }, |
diff --git a/drivers/hid/hid-holtek-mouse.c b/drivers/hid/hid-holtek-mouse.c index 7e6db3cf46f9..e696566cde46 100644 --- a/drivers/hid/hid-holtek-mouse.c +++ b/drivers/hid/hid-holtek-mouse.c | |||
| @@ -27,6 +27,7 @@ | |||
| 27 | * - USB ID 04d9:a067, sold as Sharkoon Drakonia and Perixx MX-2000 | 27 | * - USB ID 04d9:a067, sold as Sharkoon Drakonia and Perixx MX-2000 |
| 28 | * - USB ID 04d9:a04a, sold as Tracer Sniper TRM-503, NOVA Gaming Slider X200 | 28 | * - USB ID 04d9:a04a, sold as Tracer Sniper TRM-503, NOVA Gaming Slider X200 |
| 29 | * and Zalman ZM-GM1 | 29 | * and Zalman ZM-GM1 |
| 30 | * - USB ID 04d9:a081, sold as SHARKOON DarkGlider Gaming mouse | ||
| 30 | */ | 31 | */ |
| 31 | 32 | ||
| 32 | static __u8 *holtek_mouse_report_fixup(struct hid_device *hdev, __u8 *rdesc, | 33 | static __u8 *holtek_mouse_report_fixup(struct hid_device *hdev, __u8 *rdesc, |
| @@ -46,6 +47,7 @@ static __u8 *holtek_mouse_report_fixup(struct hid_device *hdev, __u8 *rdesc, | |||
| 46 | } | 47 | } |
| 47 | break; | 48 | break; |
| 48 | case USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A: | 49 | case USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A: |
| 50 | case USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081: | ||
| 49 | if (*rsize >= 113 && rdesc[106] == 0xff && rdesc[107] == 0x7f | 51 | if (*rsize >= 113 && rdesc[106] == 0xff && rdesc[107] == 0x7f |
| 50 | && rdesc[111] == 0xff && rdesc[112] == 0x7f) { | 52 | && rdesc[111] == 0xff && rdesc[112] == 0x7f) { |
| 51 | hid_info(hdev, "Fixing up report descriptor\n"); | 53 | hid_info(hdev, "Fixing up report descriptor\n"); |
| @@ -63,6 +65,8 @@ static const struct hid_device_id holtek_mouse_devices[] = { | |||
| 63 | USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067) }, | 65 | USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067) }, |
| 64 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, | 66 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, |
| 65 | USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A) }, | 67 | USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A) }, |
| 68 | { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, | ||
| 69 | USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081) }, | ||
| 66 | { } | 70 | { } |
| 67 | }; | 71 | }; |
| 68 | MODULE_DEVICE_TABLE(hid, holtek_mouse_devices); | 72 | MODULE_DEVICE_TABLE(hid, holtek_mouse_devices); |
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index e60e8d530697..9cbc7ab07dfa 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h | |||
| @@ -450,6 +450,7 @@ | |||
| 450 | #define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD 0xa055 | 450 | #define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD 0xa055 |
| 451 | #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067 0xa067 | 451 | #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A067 0xa067 |
| 452 | #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A 0xa04a | 452 | #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A04A 0xa04a |
| 453 | #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081 0xa081 | ||
| 453 | 454 | ||
| 454 | #define USB_VENDOR_ID_IMATION 0x0718 | 455 | #define USB_VENDOR_ID_IMATION 0x0718 |
| 455 | #define USB_DEVICE_ID_DISC_STAKKA 0xd000 | 456 | #define USB_DEVICE_ID_DISC_STAKKA 0xd000 |
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c index 602c188e9d86..6101816a7ddd 100644 --- a/drivers/hid/hid-roccat-kone.c +++ b/drivers/hid/hid-roccat-kone.c | |||
| @@ -382,7 +382,7 @@ static ssize_t kone_sysfs_write_profilex(struct file *fp, | |||
| 382 | } | 382 | } |
| 383 | #define PROFILE_ATTR(number) \ | 383 | #define PROFILE_ATTR(number) \ |
| 384 | static struct bin_attribute bin_attr_profile##number = { \ | 384 | static struct bin_attribute bin_attr_profile##number = { \ |
| 385 | .attr = { .name = "profile##number", .mode = 0660 }, \ | 385 | .attr = { .name = "profile" #number, .mode = 0660 }, \ |
| 386 | .size = sizeof(struct kone_profile), \ | 386 | .size = sizeof(struct kone_profile), \ |
| 387 | .read = kone_sysfs_read_profilex, \ | 387 | .read = kone_sysfs_read_profilex, \ |
| 388 | .write = kone_sysfs_write_profilex, \ | 388 | .write = kone_sysfs_write_profilex, \ |
diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c index 5ddf605b6b89..5e99fcdc71b9 100644 --- a/drivers/hid/hid-roccat-koneplus.c +++ b/drivers/hid/hid-roccat-koneplus.c | |||
| @@ -229,13 +229,13 @@ static ssize_t koneplus_sysfs_read_profilex_buttons(struct file *fp, | |||
| 229 | 229 | ||
| 230 | #define PROFILE_ATTR(number) \ | 230 | #define PROFILE_ATTR(number) \ |
| 231 | static struct bin_attribute bin_attr_profile##number##_settings = { \ | 231 | static struct bin_attribute bin_attr_profile##number##_settings = { \ |
| 232 | .attr = { .name = "profile##number##_settings", .mode = 0440 }, \ | 232 | .attr = { .name = "profile" #number "_settings", .mode = 0440 }, \ |
| 233 | .size = KONEPLUS_SIZE_PROFILE_SETTINGS, \ | 233 | .size = KONEPLUS_SIZE_PROFILE_SETTINGS, \ |
| 234 | .read = koneplus_sysfs_read_profilex_settings, \ | 234 | .read = koneplus_sysfs_read_profilex_settings, \ |
| 235 | .private = &profile_numbers[number-1], \ | 235 | .private = &profile_numbers[number-1], \ |
| 236 | }; \ | 236 | }; \ |
| 237 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ | 237 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ |
| 238 | .attr = { .name = "profile##number##_buttons", .mode = 0440 }, \ | 238 | .attr = { .name = "profile" #number "_buttons", .mode = 0440 }, \ |
| 239 | .size = KONEPLUS_SIZE_PROFILE_BUTTONS, \ | 239 | .size = KONEPLUS_SIZE_PROFILE_BUTTONS, \ |
| 240 | .read = koneplus_sysfs_read_profilex_buttons, \ | 240 | .read = koneplus_sysfs_read_profilex_buttons, \ |
| 241 | .private = &profile_numbers[number-1], \ | 241 | .private = &profile_numbers[number-1], \ |
diff --git a/drivers/hid/hid-roccat-kovaplus.c b/drivers/hid/hid-roccat-kovaplus.c index 515bc03136c0..0c8e1ef0b67d 100644 --- a/drivers/hid/hid-roccat-kovaplus.c +++ b/drivers/hid/hid-roccat-kovaplus.c | |||
| @@ -257,13 +257,13 @@ static ssize_t kovaplus_sysfs_read_profilex_buttons(struct file *fp, | |||
| 257 | 257 | ||
| 258 | #define PROFILE_ATTR(number) \ | 258 | #define PROFILE_ATTR(number) \ |
| 259 | static struct bin_attribute bin_attr_profile##number##_settings = { \ | 259 | static struct bin_attribute bin_attr_profile##number##_settings = { \ |
| 260 | .attr = { .name = "profile##number##_settings", .mode = 0440 }, \ | 260 | .attr = { .name = "profile" #number "_settings", .mode = 0440 }, \ |
| 261 | .size = KOVAPLUS_SIZE_PROFILE_SETTINGS, \ | 261 | .size = KOVAPLUS_SIZE_PROFILE_SETTINGS, \ |
| 262 | .read = kovaplus_sysfs_read_profilex_settings, \ | 262 | .read = kovaplus_sysfs_read_profilex_settings, \ |
| 263 | .private = &profile_numbers[number-1], \ | 263 | .private = &profile_numbers[number-1], \ |
| 264 | }; \ | 264 | }; \ |
| 265 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ | 265 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ |
| 266 | .attr = { .name = "profile##number##_buttons", .mode = 0440 }, \ | 266 | .attr = { .name = "profile" #number "_buttons", .mode = 0440 }, \ |
| 267 | .size = KOVAPLUS_SIZE_PROFILE_BUTTONS, \ | 267 | .size = KOVAPLUS_SIZE_PROFILE_BUTTONS, \ |
| 268 | .read = kovaplus_sysfs_read_profilex_buttons, \ | 268 | .read = kovaplus_sysfs_read_profilex_buttons, \ |
| 269 | .private = &profile_numbers[number-1], \ | 269 | .private = &profile_numbers[number-1], \ |
diff --git a/drivers/hid/hid-roccat-pyra.c b/drivers/hid/hid-roccat-pyra.c index 5a6dbbeee790..1a07e07d99a0 100644 --- a/drivers/hid/hid-roccat-pyra.c +++ b/drivers/hid/hid-roccat-pyra.c | |||
| @@ -225,13 +225,13 @@ static ssize_t pyra_sysfs_read_profilex_buttons(struct file *fp, | |||
| 225 | 225 | ||
| 226 | #define PROFILE_ATTR(number) \ | 226 | #define PROFILE_ATTR(number) \ |
| 227 | static struct bin_attribute bin_attr_profile##number##_settings = { \ | 227 | static struct bin_attribute bin_attr_profile##number##_settings = { \ |
| 228 | .attr = { .name = "profile##number##_settings", .mode = 0440 }, \ | 228 | .attr = { .name = "profile" #number "_settings", .mode = 0440 }, \ |
| 229 | .size = PYRA_SIZE_PROFILE_SETTINGS, \ | 229 | .size = PYRA_SIZE_PROFILE_SETTINGS, \ |
| 230 | .read = pyra_sysfs_read_profilex_settings, \ | 230 | .read = pyra_sysfs_read_profilex_settings, \ |
| 231 | .private = &profile_numbers[number-1], \ | 231 | .private = &profile_numbers[number-1], \ |
| 232 | }; \ | 232 | }; \ |
| 233 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ | 233 | static struct bin_attribute bin_attr_profile##number##_buttons = { \ |
| 234 | .attr = { .name = "profile##number##_buttons", .mode = 0440 }, \ | 234 | .attr = { .name = "profile" #number "_buttons", .mode = 0440 }, \ |
| 235 | .size = PYRA_SIZE_PROFILE_BUTTONS, \ | 235 | .size = PYRA_SIZE_PROFILE_BUTTONS, \ |
| 236 | .read = pyra_sysfs_read_profilex_buttons, \ | 236 | .read = pyra_sysfs_read_profilex_buttons, \ |
| 237 | .private = &profile_numbers[number-1], \ | 237 | .private = &profile_numbers[number-1], \ |
diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c index 2e7d644dba18..71adf9e60b13 100644 --- a/drivers/hid/hid-wiimote-modules.c +++ b/drivers/hid/hid-wiimote-modules.c | |||
| @@ -119,12 +119,22 @@ static const struct wiimod_ops wiimod_keys = { | |||
| 119 | * the rumble motor, this flag shouldn't be set. | 119 | * the rumble motor, this flag shouldn't be set. |
| 120 | */ | 120 | */ |
| 121 | 121 | ||
| 122 | /* used by wiimod_rumble and wiipro_rumble */ | ||
| 123 | static void wiimod_rumble_worker(struct work_struct *work) | ||
| 124 | { | ||
| 125 | struct wiimote_data *wdata = container_of(work, struct wiimote_data, | ||
| 126 | rumble_worker); | ||
| 127 | |||
| 128 | spin_lock_irq(&wdata->state.lock); | ||
| 129 | wiiproto_req_rumble(wdata, wdata->state.cache_rumble); | ||
| 130 | spin_unlock_irq(&wdata->state.lock); | ||
| 131 | } | ||
| 132 | |||
| 122 | static int wiimod_rumble_play(struct input_dev *dev, void *data, | 133 | static int wiimod_rumble_play(struct input_dev *dev, void *data, |
| 123 | struct ff_effect *eff) | 134 | struct ff_effect *eff) |
| 124 | { | 135 | { |
| 125 | struct wiimote_data *wdata = input_get_drvdata(dev); | 136 | struct wiimote_data *wdata = input_get_drvdata(dev); |
| 126 | __u8 value; | 137 | __u8 value; |
| 127 | unsigned long flags; | ||
| 128 | 138 | ||
| 129 | /* | 139 | /* |
| 130 | * The wiimote supports only a single rumble motor so if any magnitude | 140 | * The wiimote supports only a single rumble motor so if any magnitude |
| @@ -137,9 +147,10 @@ static int wiimod_rumble_play(struct input_dev *dev, void *data, | |||
| 137 | else | 147 | else |
| 138 | value = 0; | 148 | value = 0; |
| 139 | 149 | ||
| 140 | spin_lock_irqsave(&wdata->state.lock, flags); | 150 | /* Locking state.lock here might deadlock with input_event() calls. |
| 141 | wiiproto_req_rumble(wdata, value); | 151 | * schedule_work acts as barrier. Merging multiple changes is fine. */ |
| 142 | spin_unlock_irqrestore(&wdata->state.lock, flags); | 152 | wdata->state.cache_rumble = value; |
| 153 | schedule_work(&wdata->rumble_worker); | ||
| 143 | 154 | ||
| 144 | return 0; | 155 | return 0; |
| 145 | } | 156 | } |
| @@ -147,6 +158,8 @@ static int wiimod_rumble_play(struct input_dev *dev, void *data, | |||
| 147 | static int wiimod_rumble_probe(const struct wiimod_ops *ops, | 158 | static int wiimod_rumble_probe(const struct wiimod_ops *ops, |
| 148 | struct wiimote_data *wdata) | 159 | struct wiimote_data *wdata) |
| 149 | { | 160 | { |
| 161 | INIT_WORK(&wdata->rumble_worker, wiimod_rumble_worker); | ||
| 162 | |||
| 150 | set_bit(FF_RUMBLE, wdata->input->ffbit); | 163 | set_bit(FF_RUMBLE, wdata->input->ffbit); |
| 151 | if (input_ff_create_memless(wdata->input, NULL, wiimod_rumble_play)) | 164 | if (input_ff_create_memless(wdata->input, NULL, wiimod_rumble_play)) |
| 152 | return -ENOMEM; | 165 | return -ENOMEM; |
| @@ -159,6 +172,8 @@ static void wiimod_rumble_remove(const struct wiimod_ops *ops, | |||
| 159 | { | 172 | { |
| 160 | unsigned long flags; | 173 | unsigned long flags; |
| 161 | 174 | ||
| 175 | cancel_work_sync(&wdata->rumble_worker); | ||
| 176 | |||
| 162 | spin_lock_irqsave(&wdata->state.lock, flags); | 177 | spin_lock_irqsave(&wdata->state.lock, flags); |
| 163 | wiiproto_req_rumble(wdata, 0); | 178 | wiiproto_req_rumble(wdata, 0); |
| 164 | spin_unlock_irqrestore(&wdata->state.lock, flags); | 179 | spin_unlock_irqrestore(&wdata->state.lock, flags); |
| @@ -1731,7 +1746,6 @@ static int wiimod_pro_play(struct input_dev *dev, void *data, | |||
| 1731 | { | 1746 | { |
| 1732 | struct wiimote_data *wdata = input_get_drvdata(dev); | 1747 | struct wiimote_data *wdata = input_get_drvdata(dev); |
| 1733 | __u8 value; | 1748 | __u8 value; |
| 1734 | unsigned long flags; | ||
| 1735 | 1749 | ||
| 1736 | /* | 1750 | /* |
| 1737 | * The wiimote supports only a single rumble motor so if any magnitude | 1751 | * The wiimote supports only a single rumble motor so if any magnitude |
| @@ -1744,9 +1758,10 @@ static int wiimod_pro_play(struct input_dev *dev, void *data, | |||
| 1744 | else | 1758 | else |
| 1745 | value = 0; | 1759 | value = 0; |
| 1746 | 1760 | ||
| 1747 | spin_lock_irqsave(&wdata->state.lock, flags); | 1761 | /* Locking state.lock here might deadlock with input_event() calls. |
| 1748 | wiiproto_req_rumble(wdata, value); | 1762 | * schedule_work acts as barrier. Merging multiple changes is fine. */ |
| 1749 | spin_unlock_irqrestore(&wdata->state.lock, flags); | 1763 | wdata->state.cache_rumble = value; |
| 1764 | schedule_work(&wdata->rumble_worker); | ||
| 1750 | 1765 | ||
| 1751 | return 0; | 1766 | return 0; |
| 1752 | } | 1767 | } |
| @@ -1756,6 +1771,8 @@ static int wiimod_pro_probe(const struct wiimod_ops *ops, | |||
| 1756 | { | 1771 | { |
| 1757 | int ret, i; | 1772 | int ret, i; |
| 1758 | 1773 | ||
| 1774 | INIT_WORK(&wdata->rumble_worker, wiimod_rumble_worker); | ||
| 1775 | |||
| 1759 | wdata->extension.input = input_allocate_device(); | 1776 | wdata->extension.input = input_allocate_device(); |
| 1760 | if (!wdata->extension.input) | 1777 | if (!wdata->extension.input) |
| 1761 | return -ENOMEM; | 1778 | return -ENOMEM; |
| @@ -1817,12 +1834,13 @@ static void wiimod_pro_remove(const struct wiimod_ops *ops, | |||
| 1817 | if (!wdata->extension.input) | 1834 | if (!wdata->extension.input) |
| 1818 | return; | 1835 | return; |
| 1819 | 1836 | ||
| 1837 | input_unregister_device(wdata->extension.input); | ||
| 1838 | wdata->extension.input = NULL; | ||
| 1839 | cancel_work_sync(&wdata->rumble_worker); | ||
| 1840 | |||
| 1820 | spin_lock_irqsave(&wdata->state.lock, flags); | 1841 | spin_lock_irqsave(&wdata->state.lock, flags); |
| 1821 | wiiproto_req_rumble(wdata, 0); | 1842 | wiiproto_req_rumble(wdata, 0); |
| 1822 | spin_unlock_irqrestore(&wdata->state.lock, flags); | 1843 | spin_unlock_irqrestore(&wdata->state.lock, flags); |
| 1823 | |||
| 1824 | input_unregister_device(wdata->extension.input); | ||
| 1825 | wdata->extension.input = NULL; | ||
| 1826 | } | 1844 | } |
| 1827 | 1845 | ||
| 1828 | static const struct wiimod_ops wiimod_pro = { | 1846 | static const struct wiimod_ops wiimod_pro = { |
diff --git a/drivers/hid/hid-wiimote.h b/drivers/hid/hid-wiimote.h index f1474f372c0b..75db0c400037 100644 --- a/drivers/hid/hid-wiimote.h +++ b/drivers/hid/hid-wiimote.h | |||
| @@ -133,13 +133,15 @@ struct wiimote_state { | |||
| 133 | __u8 *cmd_read_buf; | 133 | __u8 *cmd_read_buf; |
| 134 | __u8 cmd_read_size; | 134 | __u8 cmd_read_size; |
| 135 | 135 | ||
| 136 | /* calibration data */ | 136 | /* calibration/cache data */ |
| 137 | __u16 calib_bboard[4][3]; | 137 | __u16 calib_bboard[4][3]; |
| 138 | __u8 cache_rumble; | ||
| 138 | }; | 139 | }; |
| 139 | 140 | ||
| 140 | struct wiimote_data { | 141 | struct wiimote_data { |
| 141 | struct hid_device *hdev; | 142 | struct hid_device *hdev; |
| 142 | struct input_dev *input; | 143 | struct input_dev *input; |
| 144 | struct work_struct rumble_worker; | ||
| 143 | struct led_classdev *leds[4]; | 145 | struct led_classdev *leds[4]; |
| 144 | struct input_dev *accel; | 146 | struct input_dev *accel; |
| 145 | struct input_dev *ir; | 147 | struct input_dev *ir; |
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 8918dd12bb69..6a6dd5cd7833 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c | |||
| @@ -308,18 +308,25 @@ static int hidraw_fasync(int fd, struct file *file, int on) | |||
| 308 | static void drop_ref(struct hidraw *hidraw, int exists_bit) | 308 | static void drop_ref(struct hidraw *hidraw, int exists_bit) |
| 309 | { | 309 | { |
| 310 | if (exists_bit) { | 310 | if (exists_bit) { |
| 311 | hid_hw_close(hidraw->hid); | ||
| 312 | hidraw->exist = 0; | 311 | hidraw->exist = 0; |
| 313 | if (hidraw->open) | 312 | if (hidraw->open) { |
| 313 | hid_hw_close(hidraw->hid); | ||
| 314 | wake_up_interruptible(&hidraw->wait); | 314 | wake_up_interruptible(&hidraw->wait); |
| 315 | } | ||
| 315 | } else { | 316 | } else { |
| 316 | --hidraw->open; | 317 | --hidraw->open; |
| 317 | } | 318 | } |
| 318 | 319 | if (!hidraw->open) { | |
| 319 | if (!hidraw->open && !hidraw->exist) { | 320 | if (!hidraw->exist) { |
| 320 | device_destroy(hidraw_class, MKDEV(hidraw_major, hidraw->minor)); | 321 | device_destroy(hidraw_class, |
| 321 | hidraw_table[hidraw->minor] = NULL; | 322 | MKDEV(hidraw_major, hidraw->minor)); |
| 322 | kfree(hidraw); | 323 | hidraw_table[hidraw->minor] = NULL; |
| 324 | kfree(hidraw); | ||
| 325 | } else { | ||
| 326 | /* close device for last reader */ | ||
| 327 | hid_hw_power(hidraw->hid, PM_HINT_NORMAL); | ||
| 328 | hid_hw_close(hidraw->hid); | ||
| 329 | } | ||
| 323 | } | 330 | } |
| 324 | } | 331 | } |
| 325 | 332 | ||
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 5bf2fb785844..93b00d76374c 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c | |||
| @@ -615,7 +615,7 @@ static const struct file_operations uhid_fops = { | |||
| 615 | 615 | ||
| 616 | static struct miscdevice uhid_misc = { | 616 | static struct miscdevice uhid_misc = { |
| 617 | .fops = &uhid_fops, | 617 | .fops = &uhid_fops, |
| 618 | .minor = MISC_DYNAMIC_MINOR, | 618 | .minor = UHID_MINOR, |
| 619 | .name = UHID_NAME, | 619 | .name = UHID_NAME, |
| 620 | }; | 620 | }; |
| 621 | 621 | ||
| @@ -634,4 +634,5 @@ module_exit(uhid_exit); | |||
| 634 | MODULE_LICENSE("GPL"); | 634 | MODULE_LICENSE("GPL"); |
| 635 | MODULE_AUTHOR("David Herrmann <dh.herrmann@gmail.com>"); | 635 | MODULE_AUTHOR("David Herrmann <dh.herrmann@gmail.com>"); |
| 636 | MODULE_DESCRIPTION("User-space I/O driver support for HID subsystem"); | 636 | MODULE_DESCRIPTION("User-space I/O driver support for HID subsystem"); |
| 637 | MODULE_ALIAS_MISCDEV(UHID_MINOR); | ||
| 637 | MODULE_ALIAS("devname:" UHID_NAME); | 638 | MODULE_ALIAS("devname:" UHID_NAME); |
diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 98814d12a604..3288f13d2d87 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c | |||
| @@ -230,6 +230,7 @@ static int send_argument(const char *key) | |||
| 230 | 230 | ||
| 231 | static int read_smc(u8 cmd, const char *key, u8 *buffer, u8 len) | 231 | static int read_smc(u8 cmd, const char *key, u8 *buffer, u8 len) |
| 232 | { | 232 | { |
| 233 | u8 status, data = 0; | ||
| 233 | int i; | 234 | int i; |
| 234 | 235 | ||
| 235 | if (send_command(cmd) || send_argument(key)) { | 236 | if (send_command(cmd) || send_argument(key)) { |
| @@ -237,6 +238,7 @@ static int read_smc(u8 cmd, const char *key, u8 *buffer, u8 len) | |||
| 237 | return -EIO; | 238 | return -EIO; |
| 238 | } | 239 | } |
| 239 | 240 | ||
| 241 | /* This has no effect on newer (2012) SMCs */ | ||
| 240 | if (send_byte(len, APPLESMC_DATA_PORT)) { | 242 | if (send_byte(len, APPLESMC_DATA_PORT)) { |
| 241 | pr_warn("%.4s: read len fail\n", key); | 243 | pr_warn("%.4s: read len fail\n", key); |
| 242 | return -EIO; | 244 | return -EIO; |
| @@ -250,6 +252,17 @@ static int read_smc(u8 cmd, const char *key, u8 *buffer, u8 len) | |||
| 250 | buffer[i] = inb(APPLESMC_DATA_PORT); | 252 | buffer[i] = inb(APPLESMC_DATA_PORT); |
| 251 | } | 253 | } |
| 252 | 254 | ||
| 255 | /* Read the data port until bit0 is cleared */ | ||
| 256 | for (i = 0; i < 16; i++) { | ||
| 257 | udelay(APPLESMC_MIN_WAIT); | ||
| 258 | status = inb(APPLESMC_CMD_PORT); | ||
| 259 | if (!(status & 0x01)) | ||
| 260 | break; | ||
| 261 | data = inb(APPLESMC_DATA_PORT); | ||
| 262 | } | ||
| 263 | if (i) | ||
| 264 | pr_warn("flushed %d bytes, last value is: %d\n", i, data); | ||
| 265 | |||
| 253 | return 0; | 266 | return 0; |
| 254 | } | 267 | } |
| 255 | 268 | ||
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 4c1b60539a25..0aa01136f8d9 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c | |||
| @@ -270,7 +270,8 @@ static SIMPLE_DEV_PM_OPS(dw_i2c_dev_pm_ops, dw_i2c_suspend, dw_i2c_resume); | |||
| 270 | MODULE_ALIAS("platform:i2c_designware"); | 270 | MODULE_ALIAS("platform:i2c_designware"); |
| 271 | 271 | ||
| 272 | static struct platform_driver dw_i2c_driver = { | 272 | static struct platform_driver dw_i2c_driver = { |
| 273 | .remove = dw_i2c_remove, | 273 | .probe = dw_i2c_probe, |
| 274 | .remove = dw_i2c_remove, | ||
| 274 | .driver = { | 275 | .driver = { |
| 275 | .name = "i2c_designware", | 276 | .name = "i2c_designware", |
| 276 | .owner = THIS_MODULE, | 277 | .owner = THIS_MODULE, |
| @@ -282,7 +283,7 @@ static struct platform_driver dw_i2c_driver = { | |||
| 282 | 283 | ||
| 283 | static int __init dw_i2c_init_driver(void) | 284 | static int __init dw_i2c_init_driver(void) |
| 284 | { | 285 | { |
| 285 | return platform_driver_probe(&dw_i2c_driver, dw_i2c_probe); | 286 | return platform_driver_register(&dw_i2c_driver); |
| 286 | } | 287 | } |
| 287 | subsys_initcall(dw_i2c_init_driver); | 288 | subsys_initcall(dw_i2c_init_driver); |
| 288 | 289 | ||
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index ccf46656bdad..1d7efa3169cd 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c | |||
| @@ -365,7 +365,7 @@ static void i2c_imx_stop(struct imx_i2c_struct *i2c_imx) | |||
| 365 | clk_disable_unprepare(i2c_imx->clk); | 365 | clk_disable_unprepare(i2c_imx->clk); |
| 366 | } | 366 | } |
| 367 | 367 | ||
| 368 | static void __init i2c_imx_set_clk(struct imx_i2c_struct *i2c_imx, | 368 | static void i2c_imx_set_clk(struct imx_i2c_struct *i2c_imx, |
| 369 | unsigned int rate) | 369 | unsigned int rate) |
| 370 | { | 370 | { |
| 371 | struct imx_i2c_clk_pair *i2c_clk_div = i2c_imx->hwdata->clk_div; | 371 | struct imx_i2c_clk_pair *i2c_clk_div = i2c_imx->hwdata->clk_div; |
| @@ -589,7 +589,7 @@ static struct i2c_algorithm i2c_imx_algo = { | |||
| 589 | .functionality = i2c_imx_func, | 589 | .functionality = i2c_imx_func, |
| 590 | }; | 590 | }; |
| 591 | 591 | ||
| 592 | static int __init i2c_imx_probe(struct platform_device *pdev) | 592 | static int i2c_imx_probe(struct platform_device *pdev) |
| 593 | { | 593 | { |
| 594 | const struct of_device_id *of_id = of_match_device(i2c_imx_dt_ids, | 594 | const struct of_device_id *of_id = of_match_device(i2c_imx_dt_ids, |
| 595 | &pdev->dev); | 595 | &pdev->dev); |
| @@ -697,7 +697,7 @@ static int __init i2c_imx_probe(struct platform_device *pdev) | |||
| 697 | return 0; /* Return OK */ | 697 | return 0; /* Return OK */ |
| 698 | } | 698 | } |
| 699 | 699 | ||
| 700 | static int __exit i2c_imx_remove(struct platform_device *pdev) | 700 | static int i2c_imx_remove(struct platform_device *pdev) |
| 701 | { | 701 | { |
| 702 | struct imx_i2c_struct *i2c_imx = platform_get_drvdata(pdev); | 702 | struct imx_i2c_struct *i2c_imx = platform_get_drvdata(pdev); |
| 703 | 703 | ||
| @@ -715,7 +715,8 @@ static int __exit i2c_imx_remove(struct platform_device *pdev) | |||
| 715 | } | 715 | } |
| 716 | 716 | ||
| 717 | static struct platform_driver i2c_imx_driver = { | 717 | static struct platform_driver i2c_imx_driver = { |
| 718 | .remove = __exit_p(i2c_imx_remove), | 718 | .probe = i2c_imx_probe, |
| 719 | .remove = i2c_imx_remove, | ||
| 719 | .driver = { | 720 | .driver = { |
| 720 | .name = DRIVER_NAME, | 721 | .name = DRIVER_NAME, |
| 721 | .owner = THIS_MODULE, | 722 | .owner = THIS_MODULE, |
| @@ -726,7 +727,7 @@ static struct platform_driver i2c_imx_driver = { | |||
| 726 | 727 | ||
| 727 | static int __init i2c_adap_imx_init(void) | 728 | static int __init i2c_adap_imx_init(void) |
| 728 | { | 729 | { |
| 729 | return platform_driver_probe(&i2c_imx_driver, i2c_imx_probe); | 730 | return platform_driver_register(&i2c_imx_driver); |
| 730 | } | 731 | } |
| 731 | subsys_initcall(i2c_adap_imx_init); | 732 | subsys_initcall(i2c_adap_imx_init); |
| 732 | 733 | ||
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index f4a01675fa71..b7c857774708 100644 --- a/drivers/i2c/busses/i2c-mxs.c +++ b/drivers/i2c/busses/i2c-mxs.c | |||
| @@ -780,12 +780,13 @@ static struct platform_driver mxs_i2c_driver = { | |||
| 780 | .owner = THIS_MODULE, | 780 | .owner = THIS_MODULE, |
| 781 | .of_match_table = mxs_i2c_dt_ids, | 781 | .of_match_table = mxs_i2c_dt_ids, |
| 782 | }, | 782 | }, |
| 783 | .probe = mxs_i2c_probe, | ||
| 783 | .remove = mxs_i2c_remove, | 784 | .remove = mxs_i2c_remove, |
| 784 | }; | 785 | }; |
| 785 | 786 | ||
| 786 | static int __init mxs_i2c_init(void) | 787 | static int __init mxs_i2c_init(void) |
| 787 | { | 788 | { |
| 788 | return platform_driver_probe(&mxs_i2c_driver, mxs_i2c_probe); | 789 | return platform_driver_register(&mxs_i2c_driver); |
| 789 | } | 790 | } |
| 790 | subsys_initcall(mxs_i2c_init); | 791 | subsys_initcall(mxs_i2c_init); |
| 791 | 792 | ||
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 6d8308d5dc4e..9967a6f9c2ff 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c | |||
| @@ -939,6 +939,9 @@ omap_i2c_isr_thread(int this_irq, void *dev_id) | |||
| 939 | /* | 939 | /* |
| 940 | * ProDB0017052: Clear ARDY bit twice | 940 | * ProDB0017052: Clear ARDY bit twice |
| 941 | */ | 941 | */ |
| 942 | if (stat & OMAP_I2C_STAT_ARDY) | ||
| 943 | omap_i2c_ack_stat(dev, OMAP_I2C_STAT_ARDY); | ||
| 944 | |||
| 942 | if (stat & (OMAP_I2C_STAT_ARDY | OMAP_I2C_STAT_NACK | | 945 | if (stat & (OMAP_I2C_STAT_ARDY | OMAP_I2C_STAT_NACK | |
| 943 | OMAP_I2C_STAT_AL)) { | 946 | OMAP_I2C_STAT_AL)) { |
| 944 | omap_i2c_ack_stat(dev, (OMAP_I2C_STAT_RRDY | | 947 | omap_i2c_ack_stat(dev, (OMAP_I2C_STAT_RRDY | |
diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index f8f6f2e552db..04a17b9b38bb 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c | |||
| @@ -859,8 +859,7 @@ static const struct i2c_algorithm stu300_algo = { | |||
| 859 | .functionality = stu300_func, | 859 | .functionality = stu300_func, |
| 860 | }; | 860 | }; |
| 861 | 861 | ||
| 862 | static int __init | 862 | static int stu300_probe(struct platform_device *pdev) |
| 863 | stu300_probe(struct platform_device *pdev) | ||
| 864 | { | 863 | { |
| 865 | struct stu300_dev *dev; | 864 | struct stu300_dev *dev; |
| 866 | struct i2c_adapter *adap; | 865 | struct i2c_adapter *adap; |
| @@ -966,8 +965,7 @@ static SIMPLE_DEV_PM_OPS(stu300_pm, stu300_suspend, stu300_resume); | |||
| 966 | #define STU300_I2C_PM NULL | 965 | #define STU300_I2C_PM NULL |
| 967 | #endif | 966 | #endif |
| 968 | 967 | ||
| 969 | static int __exit | 968 | static int stu300_remove(struct platform_device *pdev) |
| 970 | stu300_remove(struct platform_device *pdev) | ||
| 971 | { | 969 | { |
| 972 | struct stu300_dev *dev = platform_get_drvdata(pdev); | 970 | struct stu300_dev *dev = platform_get_drvdata(pdev); |
| 973 | 971 | ||
| @@ -989,13 +987,14 @@ static struct platform_driver stu300_i2c_driver = { | |||
| 989 | .pm = STU300_I2C_PM, | 987 | .pm = STU300_I2C_PM, |
| 990 | .of_match_table = stu300_dt_match, | 988 | .of_match_table = stu300_dt_match, |
| 991 | }, | 989 | }, |
| 992 | .remove = __exit_p(stu300_remove), | 990 | .probe = stu300_probe, |
| 991 | .remove = stu300_remove, | ||
| 993 | 992 | ||
| 994 | }; | 993 | }; |
| 995 | 994 | ||
| 996 | static int __init stu300_init(void) | 995 | static int __init stu300_init(void) |
| 997 | { | 996 | { |
| 998 | return platform_driver_probe(&stu300_i2c_driver, stu300_probe); | 997 | return platform_driver_register(&stu300_i2c_driver); |
| 999 | } | 998 | } |
| 1000 | 999 | ||
| 1001 | static void __exit stu300_exit(void) | 1000 | static void __exit stu300_exit(void) |
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 29d3f045a2bf..3be58f89ac77 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c | |||
| @@ -1134,6 +1134,9 @@ static void acpi_i2c_register_devices(struct i2c_adapter *adap) | |||
| 1134 | acpi_handle handle; | 1134 | acpi_handle handle; |
| 1135 | acpi_status status; | 1135 | acpi_status status; |
| 1136 | 1136 | ||
| 1137 | if (!adap->dev.parent) | ||
| 1138 | return; | ||
| 1139 | |||
| 1137 | handle = ACPI_HANDLE(adap->dev.parent); | 1140 | handle = ACPI_HANDLE(adap->dev.parent); |
| 1138 | if (!handle) | 1141 | if (!handle) |
| 1139 | return; | 1142 | return; |
diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c index 74b41ae690f3..928656e241dd 100644 --- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c +++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c | |||
| @@ -200,7 +200,7 @@ static int i2c_arbitrator_probe(struct platform_device *pdev) | |||
| 200 | arb->parent = of_find_i2c_adapter_by_node(parent_np); | 200 | arb->parent = of_find_i2c_adapter_by_node(parent_np); |
| 201 | if (!arb->parent) { | 201 | if (!arb->parent) { |
| 202 | dev_err(dev, "Cannot find parent bus\n"); | 202 | dev_err(dev, "Cannot find parent bus\n"); |
| 203 | return -EINVAL; | 203 | return -EPROBE_DEFER; |
| 204 | } | 204 | } |
| 205 | 205 | ||
| 206 | /* Actually add the mux adapter */ | 206 | /* Actually add the mux adapter */ |
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 5d4a99ba743e..a764da777f08 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c | |||
| @@ -66,7 +66,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, | |||
| 66 | struct device_node *adapter_np, *child; | 66 | struct device_node *adapter_np, *child; |
| 67 | struct i2c_adapter *adapter; | 67 | struct i2c_adapter *adapter; |
| 68 | unsigned *values, *gpios; | 68 | unsigned *values, *gpios; |
| 69 | int i = 0; | 69 | int i = 0, ret; |
| 70 | 70 | ||
| 71 | if (!np) | 71 | if (!np) |
| 72 | return -ENODEV; | 72 | return -ENODEV; |
| @@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, | |||
| 79 | adapter = of_find_i2c_adapter_by_node(adapter_np); | 79 | adapter = of_find_i2c_adapter_by_node(adapter_np); |
| 80 | if (!adapter) { | 80 | if (!adapter) { |
| 81 | dev_err(&pdev->dev, "Cannot find parent bus\n"); | 81 | dev_err(&pdev->dev, "Cannot find parent bus\n"); |
| 82 | return -ENODEV; | 82 | return -EPROBE_DEFER; |
| 83 | } | 83 | } |
| 84 | mux->data.parent = i2c_adapter_id(adapter); | 84 | mux->data.parent = i2c_adapter_id(adapter); |
| 85 | put_device(&adapter->dev); | 85 | put_device(&adapter->dev); |
| @@ -116,8 +116,12 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, | |||
| 116 | return -ENOMEM; | 116 | return -ENOMEM; |
| 117 | } | 117 | } |
| 118 | 118 | ||
| 119 | for (i = 0; i < mux->data.n_gpios; i++) | 119 | for (i = 0; i < mux->data.n_gpios; i++) { |
| 120 | gpios[i] = of_get_named_gpio(np, "mux-gpios", i); | 120 | ret = of_get_named_gpio(np, "mux-gpios", i); |
| 121 | if (ret < 0) | ||
| 122 | return ret; | ||
| 123 | gpios[i] = ret; | ||
| 124 | } | ||
| 121 | 125 | ||
| 122 | mux->data.gpios = gpios; | 126 | mux->data.gpios = gpios; |
| 123 | 127 | ||
| @@ -177,7 +181,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) | |||
| 177 | if (!parent) { | 181 | if (!parent) { |
| 178 | dev_err(&pdev->dev, "Parent adapter (%d) not found\n", | 182 | dev_err(&pdev->dev, "Parent adapter (%d) not found\n", |
| 179 | mux->data.parent); | 183 | mux->data.parent); |
| 180 | return -ENODEV; | 184 | return -EPROBE_DEFER; |
| 181 | } | 185 | } |
| 182 | 186 | ||
| 183 | mux->parent = parent; | 187 | mux->parent = parent; |
diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c index 69a91732ae65..68a37157377d 100644 --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c | |||
| @@ -113,7 +113,7 @@ static int i2c_mux_pinctrl_parse_dt(struct i2c_mux_pinctrl *mux, | |||
| 113 | adapter = of_find_i2c_adapter_by_node(adapter_np); | 113 | adapter = of_find_i2c_adapter_by_node(adapter_np); |
| 114 | if (!adapter) { | 114 | if (!adapter) { |
| 115 | dev_err(mux->dev, "Cannot find parent bus\n"); | 115 | dev_err(mux->dev, "Cannot find parent bus\n"); |
| 116 | return -ENODEV; | 116 | return -EPROBE_DEFER; |
| 117 | } | 117 | } |
| 118 | mux->pdata->parent_bus_num = i2c_adapter_id(adapter); | 118 | mux->pdata->parent_bus_num = i2c_adapter_id(adapter); |
| 119 | put_device(&adapter->dev); | 119 | put_device(&adapter->dev); |
| @@ -211,7 +211,7 @@ static int i2c_mux_pinctrl_probe(struct platform_device *pdev) | |||
| 211 | if (!mux->parent) { | 211 | if (!mux->parent) { |
| 212 | dev_err(&pdev->dev, "Parent adapter (%d) not found\n", | 212 | dev_err(&pdev->dev, "Parent adapter (%d) not found\n", |
| 213 | mux->pdata->parent_bus_num); | 213 | mux->pdata->parent_bus_num); |
| 214 | ret = -ENODEV; | 214 | ret = -EPROBE_DEFER; |
| 215 | goto err; | 215 | goto err; |
| 216 | } | 216 | } |
| 217 | 217 | ||
diff --git a/drivers/infiniband/hw/amso1100/c2_ae.c b/drivers/infiniband/hw/amso1100/c2_ae.c index d5d1929753e4..cedda25232be 100644 --- a/drivers/infiniband/hw/amso1100/c2_ae.c +++ b/drivers/infiniband/hw/amso1100/c2_ae.c | |||
| @@ -141,7 +141,7 @@ static const char *to_qp_state_str(int state) | |||
| 141 | return "C2_QP_STATE_ERROR"; | 141 | return "C2_QP_STATE_ERROR"; |
| 142 | default: | 142 | default: |
| 143 | return "<invalid QP state>"; | 143 | return "<invalid QP state>"; |
| 144 | }; | 144 | } |
| 145 | } | 145 | } |
| 146 | 146 | ||
| 147 | void c2_ae_event(struct c2_dev *c2dev, u32 mq_index) | 147 | void c2_ae_event(struct c2_dev *c2dev, u32 mq_index) |
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 3f831de9a4d8..b1a6cb3a2809 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c | |||
| @@ -164,6 +164,7 @@ int mlx5_vector2eqn(struct mlx5_ib_dev *dev, int vector, int *eqn, int *irqn) | |||
| 164 | static int alloc_comp_eqs(struct mlx5_ib_dev *dev) | 164 | static int alloc_comp_eqs(struct mlx5_ib_dev *dev) |
| 165 | { | 165 | { |
| 166 | struct mlx5_eq_table *table = &dev->mdev.priv.eq_table; | 166 | struct mlx5_eq_table *table = &dev->mdev.priv.eq_table; |
| 167 | char name[MLX5_MAX_EQ_NAME]; | ||
| 167 | struct mlx5_eq *eq, *n; | 168 | struct mlx5_eq *eq, *n; |
| 168 | int ncomp_vec; | 169 | int ncomp_vec; |
| 169 | int nent; | 170 | int nent; |
| @@ -180,11 +181,10 @@ static int alloc_comp_eqs(struct mlx5_ib_dev *dev) | |||
| 180 | goto clean; | 181 | goto clean; |
| 181 | } | 182 | } |
| 182 | 183 | ||
| 183 | snprintf(eq->name, MLX5_MAX_EQ_NAME, "mlx5_comp%d", i); | 184 | snprintf(name, MLX5_MAX_EQ_NAME, "mlx5_comp%d", i); |
| 184 | err = mlx5_create_map_eq(&dev->mdev, eq, | 185 | err = mlx5_create_map_eq(&dev->mdev, eq, |
| 185 | i + MLX5_EQ_VEC_COMP_BASE, nent, 0, | 186 | i + MLX5_EQ_VEC_COMP_BASE, nent, 0, |
| 186 | eq->name, | 187 | name, &dev->mdev.priv.uuari.uars[0]); |
| 187 | &dev->mdev.priv.uuari.uars[0]); | ||
| 188 | if (err) { | 188 | if (err) { |
| 189 | kfree(eq); | 189 | kfree(eq); |
| 190 | goto clean; | 190 | goto clean; |
| @@ -301,9 +301,8 @@ static int mlx5_ib_query_device(struct ib_device *ibdev, | |||
| 301 | props->max_srq_sge = max_rq_sg - 1; | 301 | props->max_srq_sge = max_rq_sg - 1; |
| 302 | props->max_fast_reg_page_list_len = (unsigned int)-1; | 302 | props->max_fast_reg_page_list_len = (unsigned int)-1; |
| 303 | props->local_ca_ack_delay = dev->mdev.caps.local_ca_ack_delay; | 303 | props->local_ca_ack_delay = dev->mdev.caps.local_ca_ack_delay; |
| 304 | props->atomic_cap = dev->mdev.caps.flags & MLX5_DEV_CAP_FLAG_ATOMIC ? | 304 | props->atomic_cap = IB_ATOMIC_NONE; |
| 305 | IB_ATOMIC_HCA : IB_ATOMIC_NONE; | 305 | props->masked_atomic_cap = IB_ATOMIC_NONE; |
| 306 | props->masked_atomic_cap = IB_ATOMIC_HCA; | ||
| 307 | props->max_pkeys = be16_to_cpup((__be16 *)(out_mad->data + 28)); | 306 | props->max_pkeys = be16_to_cpup((__be16 *)(out_mad->data + 28)); |
| 308 | props->max_mcast_grp = 1 << dev->mdev.caps.log_max_mcg; | 307 | props->max_mcast_grp = 1 << dev->mdev.caps.log_max_mcg; |
| 309 | props->max_mcast_qp_attach = dev->mdev.caps.max_qp_mcg; | 308 | props->max_mcast_qp_attach = dev->mdev.caps.max_qp_mcg; |
| @@ -1006,6 +1005,11 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, enum mlx5_dev_event event, | |||
| 1006 | ibev.device = &ibdev->ib_dev; | 1005 | ibev.device = &ibdev->ib_dev; |
| 1007 | ibev.element.port_num = port; | 1006 | ibev.element.port_num = port; |
| 1008 | 1007 | ||
| 1008 | if (port < 1 || port > ibdev->num_ports) { | ||
| 1009 | mlx5_ib_warn(ibdev, "warning: event on port %d\n", port); | ||
| 1010 | return; | ||
| 1011 | } | ||
| 1012 | |||
| 1009 | if (ibdev->ib_active) | 1013 | if (ibdev->ib_active) |
| 1010 | ib_dispatch_event(&ibev); | 1014 | ib_dispatch_event(&ibev); |
| 1011 | } | 1015 | } |
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index bd41df95b6f0..3453580b1eb2 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c | |||
| @@ -42,6 +42,10 @@ enum { | |||
| 42 | DEF_CACHE_SIZE = 10, | 42 | DEF_CACHE_SIZE = 10, |
| 43 | }; | 43 | }; |
| 44 | 44 | ||
| 45 | enum { | ||
| 46 | MLX5_UMR_ALIGN = 2048 | ||
| 47 | }; | ||
| 48 | |||
| 45 | static __be64 *mr_align(__be64 *ptr, int align) | 49 | static __be64 *mr_align(__be64 *ptr, int align) |
| 46 | { | 50 | { |
| 47 | unsigned long mask = align - 1; | 51 | unsigned long mask = align - 1; |
| @@ -61,13 +65,11 @@ static int order2idx(struct mlx5_ib_dev *dev, int order) | |||
| 61 | 65 | ||
| 62 | static int add_keys(struct mlx5_ib_dev *dev, int c, int num) | 66 | static int add_keys(struct mlx5_ib_dev *dev, int c, int num) |
| 63 | { | 67 | { |
| 64 | struct device *ddev = dev->ib_dev.dma_device; | ||
| 65 | struct mlx5_mr_cache *cache = &dev->cache; | 68 | struct mlx5_mr_cache *cache = &dev->cache; |
| 66 | struct mlx5_cache_ent *ent = &cache->ent[c]; | 69 | struct mlx5_cache_ent *ent = &cache->ent[c]; |
| 67 | struct mlx5_create_mkey_mbox_in *in; | 70 | struct mlx5_create_mkey_mbox_in *in; |
| 68 | struct mlx5_ib_mr *mr; | 71 | struct mlx5_ib_mr *mr; |
| 69 | int npages = 1 << ent->order; | 72 | int npages = 1 << ent->order; |
| 70 | int size = sizeof(u64) * npages; | ||
| 71 | int err = 0; | 73 | int err = 0; |
| 72 | int i; | 74 | int i; |
| 73 | 75 | ||
| @@ -83,21 +85,6 @@ static int add_keys(struct mlx5_ib_dev *dev, int c, int num) | |||
| 83 | } | 85 | } |
| 84 | mr->order = ent->order; | 86 | mr->order = ent->order; |
| 85 | mr->umred = 1; | 87 | mr->umred = 1; |
| 86 | mr->pas = kmalloc(size + 0x3f, GFP_KERNEL); | ||
| 87 | if (!mr->pas) { | ||
| 88 | kfree(mr); | ||
| 89 | err = -ENOMEM; | ||
| 90 | goto out; | ||
| 91 | } | ||
| 92 | mr->dma = dma_map_single(ddev, mr_align(mr->pas, 0x40), size, | ||
| 93 | DMA_TO_DEVICE); | ||
| 94 | if (dma_mapping_error(ddev, mr->dma)) { | ||
| 95 | kfree(mr->pas); | ||
| 96 | kfree(mr); | ||
| 97 | err = -ENOMEM; | ||
| 98 | goto out; | ||
| 99 | } | ||
| 100 | |||
| 101 | in->seg.status = 1 << 6; | 88 | in->seg.status = 1 << 6; |
| 102 | in->seg.xlt_oct_size = cpu_to_be32((npages + 1) / 2); | 89 | in->seg.xlt_oct_size = cpu_to_be32((npages + 1) / 2); |
| 103 | in->seg.qpn_mkey7_0 = cpu_to_be32(0xffffff << 8); | 90 | in->seg.qpn_mkey7_0 = cpu_to_be32(0xffffff << 8); |
| @@ -108,8 +95,6 @@ static int add_keys(struct mlx5_ib_dev *dev, int c, int num) | |||
| 108 | sizeof(*in)); | 95 | sizeof(*in)); |
| 109 | if (err) { | 96 | if (err) { |
| 110 | mlx5_ib_warn(dev, "create mkey failed %d\n", err); | 97 | mlx5_ib_warn(dev, "create mkey failed %d\n", err); |
| 111 | dma_unmap_single(ddev, mr->dma, size, DMA_TO_DEVICE); | ||
| 112 | kfree(mr->pas); | ||
| 113 | kfree(mr); | 98 | kfree(mr); |
| 114 | goto out; | 99 | goto out; |
| 115 | } | 100 | } |
| @@ -129,11 +114,9 @@ out: | |||
| 129 | 114 | ||
| 130 | static void remove_keys(struct mlx5_ib_dev *dev, int c, int num) | 115 | static void remove_keys(struct mlx5_ib_dev *dev, int c, int num) |
| 131 | { | 116 | { |
| 132 | struct device *ddev = dev->ib_dev.dma_device; | ||
| 133 | struct mlx5_mr_cache *cache = &dev->cache; | 117 | struct mlx5_mr_cache *cache = &dev->cache; |
| 134 | struct mlx5_cache_ent *ent = &cache->ent[c]; | 118 | struct mlx5_cache_ent *ent = &cache->ent[c]; |
| 135 | struct mlx5_ib_mr *mr; | 119 | struct mlx5_ib_mr *mr; |
| 136 | int size; | ||
| 137 | int err; | 120 | int err; |
| 138 | int i; | 121 | int i; |
| 139 | 122 | ||
| @@ -149,14 +132,10 @@ static void remove_keys(struct mlx5_ib_dev *dev, int c, int num) | |||
| 149 | ent->size--; | 132 | ent->size--; |
| 150 | spin_unlock(&ent->lock); | 133 | spin_unlock(&ent->lock); |
| 151 | err = mlx5_core_destroy_mkey(&dev->mdev, &mr->mmr); | 134 | err = mlx5_core_destroy_mkey(&dev->mdev, &mr->mmr); |
| 152 | if (err) { | 135 | if (err) |
| 153 | mlx5_ib_warn(dev, "failed destroy mkey\n"); | 136 | mlx5_ib_warn(dev, "failed destroy mkey\n"); |
| 154 | } else { | 137 | else |
| 155 | size = ALIGN(sizeof(u64) * (1 << mr->order), 0x40); | ||
| 156 | dma_unmap_single(ddev, mr->dma, size, DMA_TO_DEVICE); | ||
| 157 | kfree(mr->pas); | ||
| 158 | kfree(mr); | 138 | kfree(mr); |
| 159 | } | ||
| 160 | } | 139 | } |
| 161 | } | 140 | } |
| 162 | 141 | ||
| @@ -408,13 +387,12 @@ static void free_cached_mr(struct mlx5_ib_dev *dev, struct mlx5_ib_mr *mr) | |||
| 408 | 387 | ||
| 409 | static void clean_keys(struct mlx5_ib_dev *dev, int c) | 388 | static void clean_keys(struct mlx5_ib_dev *dev, int c) |
| 410 | { | 389 | { |
| 411 | struct device *ddev = dev->ib_dev.dma_device; | ||
| 412 | struct mlx5_mr_cache *cache = &dev->cache; | 390 | struct mlx5_mr_cache *cache = &dev->cache; |
| 413 | struct mlx5_cache_ent *ent = &cache->ent[c]; | 391 | struct mlx5_cache_ent *ent = &cache->ent[c]; |
| 414 | struct mlx5_ib_mr *mr; | 392 | struct mlx5_ib_mr *mr; |
| 415 | int size; | ||
| 416 | int err; | 393 | int err; |
| 417 | 394 | ||
| 395 | cancel_delayed_work(&ent->dwork); | ||
| 418 | while (1) { | 396 | while (1) { |
| 419 | spin_lock(&ent->lock); | 397 | spin_lock(&ent->lock); |
| 420 | if (list_empty(&ent->head)) { | 398 | if (list_empty(&ent->head)) { |
| @@ -427,14 +405,10 @@ static void clean_keys(struct mlx5_ib_dev *dev, int c) | |||
| 427 | ent->size--; | 405 | ent->size--; |
| 428 | spin_unlock(&ent->lock); | 406 | spin_unlock(&ent->lock); |
| 429 | err = mlx5_core_destroy_mkey(&dev->mdev, &mr->mmr); | 407 | err = mlx5_core_destroy_mkey(&dev->mdev, &mr->mmr); |
| 430 | if (err) { | 408 | if (err) |
| 431 | mlx5_ib_warn(dev, "failed destroy mkey\n"); | 409 | mlx5_ib_warn(dev, "failed destroy mkey\n"); |
| 432 | } else { | 410 | else |
| 433 | size = ALIGN(sizeof(u64) * (1 << mr->order), 0x40); | ||
| 434 | dma_unmap_single(ddev, mr->dma, size, DMA_TO_DEVICE); | ||
| 435 | kfree(mr->pas); | ||
| 436 | kfree(mr); | 411 | kfree(mr); |
| 437 | } | ||
| 438 | } | 412 | } |
| 439 | } | 413 | } |
| 440 | 414 | ||
| @@ -540,13 +514,15 @@ int mlx5_mr_cache_cleanup(struct mlx5_ib_dev *dev) | |||
| 540 | int i; | 514 | int i; |
| 541 | 515 | ||
| 542 | dev->cache.stopped = 1; | 516 | dev->cache.stopped = 1; |
| 543 | destroy_workqueue(dev->cache.wq); | 517 | flush_workqueue(dev->cache.wq); |
| 544 | 518 | ||
| 545 | mlx5_mr_cache_debugfs_cleanup(dev); | 519 | mlx5_mr_cache_debugfs_cleanup(dev); |
| 546 | 520 | ||
| 547 | for (i = 0; i < MAX_MR_CACHE_ENTRIES; i++) | 521 | for (i = 0; i < MAX_MR_CACHE_ENTRIES; i++) |
| 548 | clean_keys(dev, i); | 522 | clean_keys(dev, i); |
| 549 | 523 | ||
| 524 | destroy_workqueue(dev->cache.wq); | ||
| 525 | |||
| 550 | return 0; | 526 | return 0; |
| 551 | } | 527 | } |
| 552 | 528 | ||
| @@ -675,10 +651,12 @@ static struct mlx5_ib_mr *reg_umr(struct ib_pd *pd, struct ib_umem *umem, | |||
| 675 | int page_shift, int order, int access_flags) | 651 | int page_shift, int order, int access_flags) |
| 676 | { | 652 | { |
| 677 | struct mlx5_ib_dev *dev = to_mdev(pd->device); | 653 | struct mlx5_ib_dev *dev = to_mdev(pd->device); |
| 654 | struct device *ddev = dev->ib_dev.dma_device; | ||
| 678 | struct umr_common *umrc = &dev->umrc; | 655 | struct umr_common *umrc = &dev->umrc; |
| 679 | struct ib_send_wr wr, *bad; | 656 | struct ib_send_wr wr, *bad; |
| 680 | struct mlx5_ib_mr *mr; | 657 | struct mlx5_ib_mr *mr; |
| 681 | struct ib_sge sg; | 658 | struct ib_sge sg; |
| 659 | int size = sizeof(u64) * npages; | ||
| 682 | int err; | 660 | int err; |
| 683 | int i; | 661 | int i; |
| 684 | 662 | ||
| @@ -697,7 +675,22 @@ static struct mlx5_ib_mr *reg_umr(struct ib_pd *pd, struct ib_umem *umem, | |||
| 697 | if (!mr) | 675 | if (!mr) |
| 698 | return ERR_PTR(-EAGAIN); | 676 | return ERR_PTR(-EAGAIN); |
| 699 | 677 | ||
| 700 | mlx5_ib_populate_pas(dev, umem, page_shift, mr_align(mr->pas, 0x40), 1); | 678 | mr->pas = kmalloc(size + MLX5_UMR_ALIGN - 1, GFP_KERNEL); |
| 679 | if (!mr->pas) { | ||
| 680 | err = -ENOMEM; | ||
| 681 | goto error; | ||
| 682 | } | ||
| 683 | |||
| 684 | mlx5_ib_populate_pas(dev, umem, page_shift, | ||
| 685 | mr_align(mr->pas, MLX5_UMR_ALIGN), 1); | ||
| 686 | |||
| 687 | mr->dma = dma_map_single(ddev, mr_align(mr->pas, MLX5_UMR_ALIGN), size, | ||
| 688 | DMA_TO_DEVICE); | ||
| 689 | if (dma_mapping_error(ddev, mr->dma)) { | ||
| 690 | kfree(mr->pas); | ||
| 691 | err = -ENOMEM; | ||
| 692 | goto error; | ||
| 693 | } | ||
| 701 | 694 | ||
| 702 | memset(&wr, 0, sizeof(wr)); | 695 | memset(&wr, 0, sizeof(wr)); |
| 703 | wr.wr_id = (u64)(unsigned long)mr; | 696 | wr.wr_id = (u64)(unsigned long)mr; |
| @@ -718,6 +711,9 @@ static struct mlx5_ib_mr *reg_umr(struct ib_pd *pd, struct ib_umem *umem, | |||
| 718 | wait_for_completion(&mr->done); | 711 | wait_for_completion(&mr->done); |
| 719 | up(&umrc->sem); | 712 | up(&umrc->sem); |
| 720 | 713 | ||
| 714 | dma_unmap_single(ddev, mr->dma, size, DMA_TO_DEVICE); | ||
| 715 | kfree(mr->pas); | ||
| 716 | |||
| 721 | if (mr->status != IB_WC_SUCCESS) { | 717 | if (mr->status != IB_WC_SUCCESS) { |
| 722 | mlx5_ib_warn(dev, "reg umr failed\n"); | 718 | mlx5_ib_warn(dev, "reg umr failed\n"); |
| 723 | err = -EFAULT; | 719 | err = -EFAULT; |
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 045f8cdbd303..5659ea880741 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c | |||
| @@ -203,7 +203,7 @@ static int sq_overhead(enum ib_qp_type qp_type) | |||
| 203 | 203 | ||
| 204 | switch (qp_type) { | 204 | switch (qp_type) { |
| 205 | case IB_QPT_XRC_INI: | 205 | case IB_QPT_XRC_INI: |
| 206 | size = sizeof(struct mlx5_wqe_xrc_seg); | 206 | size += sizeof(struct mlx5_wqe_xrc_seg); |
| 207 | /* fall through */ | 207 | /* fall through */ |
| 208 | case IB_QPT_RC: | 208 | case IB_QPT_RC: |
| 209 | size += sizeof(struct mlx5_wqe_ctrl_seg) + | 209 | size += sizeof(struct mlx5_wqe_ctrl_seg) + |
| @@ -211,20 +211,23 @@ static int sq_overhead(enum ib_qp_type qp_type) | |||
| 211 | sizeof(struct mlx5_wqe_raddr_seg); | 211 | sizeof(struct mlx5_wqe_raddr_seg); |
| 212 | break; | 212 | break; |
| 213 | 213 | ||
| 214 | case IB_QPT_XRC_TGT: | ||
| 215 | return 0; | ||
| 216 | |||
| 214 | case IB_QPT_UC: | 217 | case IB_QPT_UC: |
| 215 | size = sizeof(struct mlx5_wqe_ctrl_seg) + | 218 | size += sizeof(struct mlx5_wqe_ctrl_seg) + |
| 216 | sizeof(struct mlx5_wqe_raddr_seg); | 219 | sizeof(struct mlx5_wqe_raddr_seg); |
| 217 | break; | 220 | break; |
| 218 | 221 | ||
| 219 | case IB_QPT_UD: | 222 | case IB_QPT_UD: |
| 220 | case IB_QPT_SMI: | 223 | case IB_QPT_SMI: |
| 221 | case IB_QPT_GSI: | 224 | case IB_QPT_GSI: |
| 222 | size = sizeof(struct mlx5_wqe_ctrl_seg) + | 225 | size += sizeof(struct mlx5_wqe_ctrl_seg) + |
| 223 | sizeof(struct mlx5_wqe_datagram_seg); | 226 | sizeof(struct mlx5_wqe_datagram_seg); |
| 224 | break; | 227 | break; |
| 225 | 228 | ||
| 226 | case MLX5_IB_QPT_REG_UMR: | 229 | case MLX5_IB_QPT_REG_UMR: |
| 227 | size = sizeof(struct mlx5_wqe_ctrl_seg) + | 230 | size += sizeof(struct mlx5_wqe_ctrl_seg) + |
| 228 | sizeof(struct mlx5_wqe_umr_ctrl_seg) + | 231 | sizeof(struct mlx5_wqe_umr_ctrl_seg) + |
| 229 | sizeof(struct mlx5_mkey_seg); | 232 | sizeof(struct mlx5_mkey_seg); |
| 230 | break; | 233 | break; |
| @@ -270,7 +273,8 @@ static int calc_sq_size(struct mlx5_ib_dev *dev, struct ib_qp_init_attr *attr, | |||
| 270 | return wqe_size; | 273 | return wqe_size; |
| 271 | 274 | ||
| 272 | if (wqe_size > dev->mdev.caps.max_sq_desc_sz) { | 275 | if (wqe_size > dev->mdev.caps.max_sq_desc_sz) { |
| 273 | mlx5_ib_dbg(dev, "\n"); | 276 | mlx5_ib_dbg(dev, "wqe_size(%d) > max_sq_desc_sz(%d)\n", |
| 277 | wqe_size, dev->mdev.caps.max_sq_desc_sz); | ||
| 274 | return -EINVAL; | 278 | return -EINVAL; |
| 275 | } | 279 | } |
| 276 | 280 | ||
| @@ -280,9 +284,15 @@ static int calc_sq_size(struct mlx5_ib_dev *dev, struct ib_qp_init_attr *attr, | |||
| 280 | 284 | ||
| 281 | wq_size = roundup_pow_of_two(attr->cap.max_send_wr * wqe_size); | 285 | wq_size = roundup_pow_of_two(attr->cap.max_send_wr * wqe_size); |
| 282 | qp->sq.wqe_cnt = wq_size / MLX5_SEND_WQE_BB; | 286 | qp->sq.wqe_cnt = wq_size / MLX5_SEND_WQE_BB; |
| 287 | if (qp->sq.wqe_cnt > dev->mdev.caps.max_wqes) { | ||
| 288 | mlx5_ib_dbg(dev, "wqe count(%d) exceeds limits(%d)\n", | ||
| 289 | qp->sq.wqe_cnt, dev->mdev.caps.max_wqes); | ||
| 290 | return -ENOMEM; | ||
| 291 | } | ||
| 283 | qp->sq.wqe_shift = ilog2(MLX5_SEND_WQE_BB); | 292 | qp->sq.wqe_shift = ilog2(MLX5_SEND_WQE_BB); |
| 284 | qp->sq.max_gs = attr->cap.max_send_sge; | 293 | qp->sq.max_gs = attr->cap.max_send_sge; |
| 285 | qp->sq.max_post = 1 << ilog2(wq_size / wqe_size); | 294 | qp->sq.max_post = wq_size / wqe_size; |
| 295 | attr->cap.max_send_wr = qp->sq.max_post; | ||
| 286 | 296 | ||
| 287 | return wq_size; | 297 | return wq_size; |
| 288 | } | 298 | } |
| @@ -1280,6 +1290,11 @@ static enum mlx5_qp_optpar opt_mask[MLX5_QP_NUM_STATE][MLX5_QP_NUM_STATE][MLX5_Q | |||
| 1280 | MLX5_QP_OPTPAR_Q_KEY, | 1290 | MLX5_QP_OPTPAR_Q_KEY, |
| 1281 | [MLX5_QP_ST_MLX] = MLX5_QP_OPTPAR_PKEY_INDEX | | 1291 | [MLX5_QP_ST_MLX] = MLX5_QP_OPTPAR_PKEY_INDEX | |
| 1282 | MLX5_QP_OPTPAR_Q_KEY, | 1292 | MLX5_QP_OPTPAR_Q_KEY, |
| 1293 | [MLX5_QP_ST_XRC] = MLX5_QP_OPTPAR_ALT_ADDR_PATH | | ||
| 1294 | MLX5_QP_OPTPAR_RRE | | ||
| 1295 | MLX5_QP_OPTPAR_RAE | | ||
| 1296 | MLX5_QP_OPTPAR_RWE | | ||
| 1297 | MLX5_QP_OPTPAR_PKEY_INDEX, | ||
| 1283 | }, | 1298 | }, |
| 1284 | }, | 1299 | }, |
| 1285 | [MLX5_QP_STATE_RTR] = { | 1300 | [MLX5_QP_STATE_RTR] = { |
| @@ -1314,6 +1329,11 @@ static enum mlx5_qp_optpar opt_mask[MLX5_QP_NUM_STATE][MLX5_QP_NUM_STATE][MLX5_Q | |||
| 1314 | [MLX5_QP_STATE_RTS] = { | 1329 | [MLX5_QP_STATE_RTS] = { |
| 1315 | [MLX5_QP_ST_UD] = MLX5_QP_OPTPAR_Q_KEY, | 1330 | [MLX5_QP_ST_UD] = MLX5_QP_OPTPAR_Q_KEY, |
| 1316 | [MLX5_QP_ST_MLX] = MLX5_QP_OPTPAR_Q_KEY, | 1331 | [MLX5_QP_ST_MLX] = MLX5_QP_OPTPAR_Q_KEY, |
| 1332 | [MLX5_QP_ST_UC] = MLX5_QP_OPTPAR_RWE, | ||
| 1333 | [MLX5_QP_ST_RC] = MLX5_QP_OPTPAR_RNR_TIMEOUT | | ||
| 1334 | MLX5_QP_OPTPAR_RWE | | ||
| 1335 | MLX5_QP_OPTPAR_RAE | | ||
| 1336 | MLX5_QP_OPTPAR_RRE, | ||
| 1317 | }, | 1337 | }, |
| 1318 | }, | 1338 | }, |
| 1319 | }; | 1339 | }; |
| @@ -1651,29 +1671,6 @@ static __always_inline void set_raddr_seg(struct mlx5_wqe_raddr_seg *rseg, | |||
| 1651 | rseg->reserved = 0; | 1671 | rseg->reserved = 0; |
| 1652 | } | 1672 | } |
| 1653 | 1673 | ||
| 1654 | static void set_atomic_seg(struct mlx5_wqe_atomic_seg *aseg, struct ib_send_wr *wr) | ||
| 1655 | { | ||
| 1656 | if (wr->opcode == IB_WR_ATOMIC_CMP_AND_SWP) { | ||
| 1657 | aseg->swap_add = cpu_to_be64(wr->wr.atomic.swap); | ||
| 1658 | aseg->compare = cpu_to_be64(wr->wr.atomic.compare_add); | ||
| 1659 | } else if (wr->opcode == IB_WR_MASKED_ATOMIC_FETCH_AND_ADD) { | ||
| 1660 | aseg->swap_add = cpu_to_be64(wr->wr.atomic.compare_add); | ||
| 1661 | aseg->compare = cpu_to_be64(wr->wr.atomic.compare_add_mask); | ||
| 1662 | } else { | ||
| 1663 | aseg->swap_add = cpu_to_be64(wr->wr.atomic.compare_add); | ||
| 1664 | aseg->compare = 0; | ||
| 1665 | } | ||
| 1666 | } | ||
| 1667 | |||
| 1668 | static void set_masked_atomic_seg(struct mlx5_wqe_masked_atomic_seg *aseg, | ||
| 1669 | struct ib_send_wr *wr) | ||
| 1670 | { | ||
| 1671 | aseg->swap_add = cpu_to_be64(wr->wr.atomic.swap); | ||
| 1672 | aseg->swap_add_mask = cpu_to_be64(wr->wr.atomic.swap_mask); | ||
| 1673 | aseg->compare = cpu_to_be64(wr->wr.atomic.compare_add); | ||
| 1674 | aseg->compare_mask = cpu_to_be64(wr->wr.atomic.compare_add_mask); | ||
| 1675 | } | ||
| 1676 | |||
| 1677 | static void set_datagram_seg(struct mlx5_wqe_datagram_seg *dseg, | 1674 | static void set_datagram_seg(struct mlx5_wqe_datagram_seg *dseg, |
| 1678 | struct ib_send_wr *wr) | 1675 | struct ib_send_wr *wr) |
| 1679 | { | 1676 | { |
| @@ -2063,28 +2060,11 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, | |||
| 2063 | 2060 | ||
| 2064 | case IB_WR_ATOMIC_CMP_AND_SWP: | 2061 | case IB_WR_ATOMIC_CMP_AND_SWP: |
| 2065 | case IB_WR_ATOMIC_FETCH_AND_ADD: | 2062 | case IB_WR_ATOMIC_FETCH_AND_ADD: |
| 2066 | set_raddr_seg(seg, wr->wr.atomic.remote_addr, | ||
| 2067 | wr->wr.atomic.rkey); | ||
| 2068 | seg += sizeof(struct mlx5_wqe_raddr_seg); | ||
| 2069 | |||
| 2070 | set_atomic_seg(seg, wr); | ||
| 2071 | seg += sizeof(struct mlx5_wqe_atomic_seg); | ||
| 2072 | |||
| 2073 | size += (sizeof(struct mlx5_wqe_raddr_seg) + | ||
| 2074 | sizeof(struct mlx5_wqe_atomic_seg)) / 16; | ||
| 2075 | break; | ||
| 2076 | |||
| 2077 | case IB_WR_MASKED_ATOMIC_CMP_AND_SWP: | 2063 | case IB_WR_MASKED_ATOMIC_CMP_AND_SWP: |
| 2078 | set_raddr_seg(seg, wr->wr.atomic.remote_addr, | 2064 | mlx5_ib_warn(dev, "Atomic operations are not supported yet\n"); |
| 2079 | wr->wr.atomic.rkey); | 2065 | err = -ENOSYS; |
| 2080 | seg += sizeof(struct mlx5_wqe_raddr_seg); | 2066 | *bad_wr = wr; |
| 2081 | 2067 | goto out; | |
| 2082 | set_masked_atomic_seg(seg, wr); | ||
| 2083 | seg += sizeof(struct mlx5_wqe_masked_atomic_seg); | ||
| 2084 | |||
| 2085 | size += (sizeof(struct mlx5_wqe_raddr_seg) + | ||
| 2086 | sizeof(struct mlx5_wqe_masked_atomic_seg)) / 16; | ||
| 2087 | break; | ||
| 2088 | 2068 | ||
| 2089 | case IB_WR_LOCAL_INV: | 2069 | case IB_WR_LOCAL_INV: |
| 2090 | next_fence = MLX5_FENCE_MODE_INITIATOR_SMALL; | 2070 | next_fence = MLX5_FENCE_MODE_INITIATOR_SMALL; |
diff --git a/drivers/infiniband/hw/mlx5/srq.c b/drivers/infiniband/hw/mlx5/srq.c index 84d297afd6a9..0aa478bc291a 100644 --- a/drivers/infiniband/hw/mlx5/srq.c +++ b/drivers/infiniband/hw/mlx5/srq.c | |||
| @@ -295,7 +295,7 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd, | |||
| 295 | mlx5_vfree(in); | 295 | mlx5_vfree(in); |
| 296 | if (err) { | 296 | if (err) { |
| 297 | mlx5_ib_dbg(dev, "create SRQ failed, err %d\n", err); | 297 | mlx5_ib_dbg(dev, "create SRQ failed, err %d\n", err); |
| 298 | goto err_srq; | 298 | goto err_usr_kern_srq; |
| 299 | } | 299 | } |
| 300 | 300 | ||
| 301 | mlx5_ib_dbg(dev, "create SRQ with srqn 0x%x\n", srq->msrq.srqn); | 301 | mlx5_ib_dbg(dev, "create SRQ with srqn 0x%x\n", srq->msrq.srqn); |
| @@ -316,6 +316,8 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd, | |||
| 316 | 316 | ||
| 317 | err_core: | 317 | err_core: |
| 318 | mlx5_core_destroy_srq(&dev->mdev, &srq->msrq); | 318 | mlx5_core_destroy_srq(&dev->mdev, &srq->msrq); |
| 319 | |||
| 320 | err_usr_kern_srq: | ||
| 319 | if (pd->uobject) | 321 | if (pd->uobject) |
| 320 | destroy_srq_user(pd, srq); | 322 | destroy_srq_user(pd, srq); |
| 321 | else | 323 | else |
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c index 7c9d35f39d75..690201738993 100644 --- a/drivers/infiniband/hw/mthca/mthca_eq.c +++ b/drivers/infiniband/hw/mthca/mthca_eq.c | |||
| @@ -357,7 +357,7 @@ static int mthca_eq_int(struct mthca_dev *dev, struct mthca_eq *eq) | |||
| 357 | mthca_warn(dev, "Unhandled event %02x(%02x) on EQ %d\n", | 357 | mthca_warn(dev, "Unhandled event %02x(%02x) on EQ %d\n", |
| 358 | eqe->type, eqe->subtype, eq->eqn); | 358 | eqe->type, eqe->subtype, eq->eqn); |
| 359 | break; | 359 | break; |
| 360 | }; | 360 | } |
| 361 | 361 | ||
| 362 | set_eqe_hw(eqe); | 362 | set_eqe_hw(eqe); |
| 363 | ++eq->cons_index; | 363 | ++eq->cons_index; |
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 4ed8235d2d36..50219ab2279d 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c | |||
| @@ -150,7 +150,7 @@ enum ib_qp_state get_ibqp_state(enum ocrdma_qp_state qps) | |||
| 150 | return IB_QPS_SQE; | 150 | return IB_QPS_SQE; |
| 151 | case OCRDMA_QPS_ERR: | 151 | case OCRDMA_QPS_ERR: |
| 152 | return IB_QPS_ERR; | 152 | return IB_QPS_ERR; |
| 153 | }; | 153 | } |
| 154 | return IB_QPS_ERR; | 154 | return IB_QPS_ERR; |
| 155 | } | 155 | } |
| 156 | 156 | ||
| @@ -171,7 +171,7 @@ static enum ocrdma_qp_state get_ocrdma_qp_state(enum ib_qp_state qps) | |||
| 171 | return OCRDMA_QPS_SQE; | 171 | return OCRDMA_QPS_SQE; |
| 172 | case IB_QPS_ERR: | 172 | case IB_QPS_ERR: |
| 173 | return OCRDMA_QPS_ERR; | 173 | return OCRDMA_QPS_ERR; |
| 174 | }; | 174 | } |
| 175 | return OCRDMA_QPS_ERR; | 175 | return OCRDMA_QPS_ERR; |
| 176 | } | 176 | } |
| 177 | 177 | ||
| @@ -1982,7 +1982,7 @@ int ocrdma_mbx_create_qp(struct ocrdma_qp *qp, struct ib_qp_init_attr *attrs, | |||
| 1982 | break; | 1982 | break; |
| 1983 | default: | 1983 | default: |
| 1984 | return -EINVAL; | 1984 | return -EINVAL; |
| 1985 | }; | 1985 | } |
| 1986 | 1986 | ||
| 1987 | cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_CREATE_QP, sizeof(*cmd)); | 1987 | cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_CREATE_QP, sizeof(*cmd)); |
| 1988 | if (!cmd) | 1988 | if (!cmd) |
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index 56e004940f18..0ce7674621ea 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c | |||
| @@ -531,7 +531,7 @@ static void ocrdma_event_handler(struct ocrdma_dev *dev, u32 event) | |||
| 531 | case BE_DEV_DOWN: | 531 | case BE_DEV_DOWN: |
| 532 | ocrdma_close(dev); | 532 | ocrdma_close(dev); |
| 533 | break; | 533 | break; |
| 534 | }; | 534 | } |
| 535 | } | 535 | } |
| 536 | 536 | ||
| 537 | static struct ocrdma_driver ocrdma_drv = { | 537 | static struct ocrdma_driver ocrdma_drv = { |
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index 6e982bb43c31..69f1d1221a6b 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | |||
| @@ -141,7 +141,7 @@ static inline void get_link_speed_and_width(struct ocrdma_dev *dev, | |||
| 141 | /* Unsupported */ | 141 | /* Unsupported */ |
| 142 | *ib_speed = IB_SPEED_SDR; | 142 | *ib_speed = IB_SPEED_SDR; |
| 143 | *ib_width = IB_WIDTH_1X; | 143 | *ib_width = IB_WIDTH_1X; |
| 144 | }; | 144 | } |
| 145 | } | 145 | } |
| 146 | 146 | ||
| 147 | 147 | ||
| @@ -2331,7 +2331,7 @@ static enum ib_wc_status ocrdma_to_ibwc_err(u16 status) | |||
| 2331 | default: | 2331 | default: |
| 2332 | ibwc_status = IB_WC_GENERAL_ERR; | 2332 | ibwc_status = IB_WC_GENERAL_ERR; |
| 2333 | break; | 2333 | break; |
| 2334 | }; | 2334 | } |
| 2335 | return ibwc_status; | 2335 | return ibwc_status; |
| 2336 | } | 2336 | } |
| 2337 | 2337 | ||
| @@ -2370,7 +2370,7 @@ static void ocrdma_update_wc(struct ocrdma_qp *qp, struct ib_wc *ibwc, | |||
| 2370 | pr_err("%s() invalid opcode received = 0x%x\n", | 2370 | pr_err("%s() invalid opcode received = 0x%x\n", |
| 2371 | __func__, hdr->cw & OCRDMA_WQE_OPCODE_MASK); | 2371 | __func__, hdr->cw & OCRDMA_WQE_OPCODE_MASK); |
| 2372 | break; | 2372 | break; |
| 2373 | }; | 2373 | } |
| 2374 | } | 2374 | } |
| 2375 | 2375 | ||
| 2376 | static void ocrdma_set_cqe_status_flushed(struct ocrdma_qp *qp, | 2376 | static void ocrdma_set_cqe_status_flushed(struct ocrdma_qp *qp, |
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index fe302e33f72e..c880ebaf1553 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig | |||
| @@ -52,7 +52,7 @@ config AMD_IOMMU | |||
| 52 | select PCI_PRI | 52 | select PCI_PRI |
| 53 | select PCI_PASID | 53 | select PCI_PASID |
| 54 | select IOMMU_API | 54 | select IOMMU_API |
| 55 | depends on X86_64 && PCI && ACPI && X86_IO_APIC | 55 | depends on X86_64 && PCI && ACPI |
| 56 | ---help--- | 56 | ---help--- |
| 57 | With this option you can enable support for AMD IOMMU hardware in | 57 | With this option you can enable support for AMD IOMMU hardware in |
| 58 | your system. An IOMMU is a hardware component which provides | 58 | your system. An IOMMU is a hardware component which provides |
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index 71eb233b9ace..b6a74bcbb08f 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c | |||
| @@ -996,6 +996,7 @@ static void request_write(struct cached_dev *dc, struct search *s) | |||
| 996 | closure_bio_submit(bio, cl, s->d); | 996 | closure_bio_submit(bio, cl, s->d); |
| 997 | } else { | 997 | } else { |
| 998 | bch_writeback_add(dc); | 998 | bch_writeback_add(dc); |
| 999 | s->op.cache_bio = bio; | ||
| 999 | 1000 | ||
| 1000 | if (bio->bi_rw & REQ_FLUSH) { | 1001 | if (bio->bi_rw & REQ_FLUSH) { |
| 1001 | /* Also need to send a flush to the backing device */ | 1002 | /* Also need to send a flush to the backing device */ |
| @@ -1008,8 +1009,6 @@ static void request_write(struct cached_dev *dc, struct search *s) | |||
| 1008 | flush->bi_private = cl; | 1009 | flush->bi_private = cl; |
| 1009 | 1010 | ||
| 1010 | closure_bio_submit(flush, cl, s->d); | 1011 | closure_bio_submit(flush, cl, s->d); |
| 1011 | } else { | ||
| 1012 | s->op.cache_bio = bio; | ||
| 1013 | } | 1012 | } |
| 1014 | } | 1013 | } |
| 1015 | out: | 1014 | out: |
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 26b14f9fcac6..6bc9618af094 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c | |||
| @@ -168,12 +168,25 @@ static inline int write_disable(struct m25p *flash) | |||
| 168 | */ | 168 | */ |
| 169 | static inline int set_4byte(struct m25p *flash, u32 jedec_id, int enable) | 169 | static inline int set_4byte(struct m25p *flash, u32 jedec_id, int enable) |
| 170 | { | 170 | { |
| 171 | int status; | ||
| 172 | bool need_wren = false; | ||
| 173 | |||
| 171 | switch (JEDEC_MFR(jedec_id)) { | 174 | switch (JEDEC_MFR(jedec_id)) { |
| 172 | case CFI_MFR_MACRONIX: | ||
| 173 | case CFI_MFR_ST: /* Micron, actually */ | 175 | case CFI_MFR_ST: /* Micron, actually */ |
| 176 | /* Some Micron need WREN command; all will accept it */ | ||
| 177 | need_wren = true; | ||
| 178 | case CFI_MFR_MACRONIX: | ||
| 174 | case 0xEF /* winbond */: | 179 | case 0xEF /* winbond */: |
| 180 | if (need_wren) | ||
| 181 | write_enable(flash); | ||
| 182 | |||
| 175 | flash->command[0] = enable ? OPCODE_EN4B : OPCODE_EX4B; | 183 | flash->command[0] = enable ? OPCODE_EN4B : OPCODE_EX4B; |
| 176 | return spi_write(flash->spi, flash->command, 1); | 184 | status = spi_write(flash->spi, flash->command, 1); |
| 185 | |||
| 186 | if (need_wren) | ||
| 187 | write_disable(flash); | ||
| 188 | |||
| 189 | return status; | ||
| 177 | default: | 190 | default: |
| 178 | /* Spansion style */ | 191 | /* Spansion style */ |
| 179 | flash->command[0] = OPCODE_BRWR; | 192 | flash->command[0] = OPCODE_BRWR; |
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 7ed4841327f2..d340b2f198c6 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c | |||
| @@ -2869,10 +2869,8 @@ static int nand_flash_detect_ext_param_page(struct mtd_info *mtd, | |||
| 2869 | 2869 | ||
| 2870 | len = le16_to_cpu(p->ext_param_page_length) * 16; | 2870 | len = le16_to_cpu(p->ext_param_page_length) * 16; |
| 2871 | ep = kmalloc(len, GFP_KERNEL); | 2871 | ep = kmalloc(len, GFP_KERNEL); |
| 2872 | if (!ep) { | 2872 | if (!ep) |
| 2873 | ret = -ENOMEM; | 2873 | return -ENOMEM; |
| 2874 | goto ext_out; | ||
| 2875 | } | ||
| 2876 | 2874 | ||
| 2877 | /* Send our own NAND_CMD_PARAM. */ | 2875 | /* Send our own NAND_CMD_PARAM. */ |
| 2878 | chip->cmdfunc(mtd, NAND_CMD_PARAM, 0, -1); | 2876 | chip->cmdfunc(mtd, NAND_CMD_PARAM, 0, -1); |
| @@ -2920,7 +2918,7 @@ static int nand_flash_detect_ext_param_page(struct mtd_info *mtd, | |||
| 2920 | } | 2918 | } |
| 2921 | 2919 | ||
| 2922 | pr_info("ONFI extended param page detected.\n"); | 2920 | pr_info("ONFI extended param page detected.\n"); |
| 2923 | return 0; | 2921 | ret = 0; |
| 2924 | 2922 | ||
| 2925 | ext_out: | 2923 | ext_out: |
| 2926 | kfree(ep); | 2924 | kfree(ep); |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c index 5472cbd34028..6ca30739625f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c | |||
| @@ -180,28 +180,32 @@ static int verify_block_sig(struct mlx5_cmd_prot_block *block) | |||
| 180 | return 0; | 180 | return 0; |
| 181 | } | 181 | } |
| 182 | 182 | ||
| 183 | static void calc_block_sig(struct mlx5_cmd_prot_block *block, u8 token) | 183 | static void calc_block_sig(struct mlx5_cmd_prot_block *block, u8 token, |
| 184 | int csum) | ||
| 184 | { | 185 | { |
| 185 | block->token = token; | 186 | block->token = token; |
| 186 | block->ctrl_sig = ~xor8_buf(block->rsvd0, sizeof(*block) - sizeof(block->data) - 2); | 187 | if (csum) { |
| 187 | block->sig = ~xor8_buf(block, sizeof(*block) - 1); | 188 | block->ctrl_sig = ~xor8_buf(block->rsvd0, sizeof(*block) - |
| 189 | sizeof(block->data) - 2); | ||
| 190 | block->sig = ~xor8_buf(block, sizeof(*block) - 1); | ||
| 191 | } | ||
| 188 | } | 192 | } |
| 189 | 193 | ||
| 190 | static void calc_chain_sig(struct mlx5_cmd_msg *msg, u8 token) | 194 | static void calc_chain_sig(struct mlx5_cmd_msg *msg, u8 token, int csum) |
| 191 | { | 195 | { |
| 192 | struct mlx5_cmd_mailbox *next = msg->next; | 196 | struct mlx5_cmd_mailbox *next = msg->next; |
| 193 | 197 | ||
| 194 | while (next) { | 198 | while (next) { |
| 195 | calc_block_sig(next->buf, token); | 199 | calc_block_sig(next->buf, token, csum); |
| 196 | next = next->next; | 200 | next = next->next; |
| 197 | } | 201 | } |
| 198 | } | 202 | } |
| 199 | 203 | ||
| 200 | static void set_signature(struct mlx5_cmd_work_ent *ent) | 204 | static void set_signature(struct mlx5_cmd_work_ent *ent, int csum) |
| 201 | { | 205 | { |
| 202 | ent->lay->sig = ~xor8_buf(ent->lay, sizeof(*ent->lay)); | 206 | ent->lay->sig = ~xor8_buf(ent->lay, sizeof(*ent->lay)); |
| 203 | calc_chain_sig(ent->in, ent->token); | 207 | calc_chain_sig(ent->in, ent->token, csum); |
| 204 | calc_chain_sig(ent->out, ent->token); | 208 | calc_chain_sig(ent->out, ent->token, csum); |
| 205 | } | 209 | } |
| 206 | 210 | ||
| 207 | static void poll_timeout(struct mlx5_cmd_work_ent *ent) | 211 | static void poll_timeout(struct mlx5_cmd_work_ent *ent) |
| @@ -539,8 +543,7 @@ static void cmd_work_handler(struct work_struct *work) | |||
| 539 | lay->type = MLX5_PCI_CMD_XPORT; | 543 | lay->type = MLX5_PCI_CMD_XPORT; |
| 540 | lay->token = ent->token; | 544 | lay->token = ent->token; |
| 541 | lay->status_own = CMD_OWNER_HW; | 545 | lay->status_own = CMD_OWNER_HW; |
| 542 | if (!cmd->checksum_disabled) | 546 | set_signature(ent, !cmd->checksum_disabled); |
| 543 | set_signature(ent); | ||
| 544 | dump_command(dev, ent, 1); | 547 | dump_command(dev, ent, 1); |
| 545 | ktime_get_ts(&ent->ts1); | 548 | ktime_get_ts(&ent->ts1); |
| 546 | 549 | ||
| @@ -773,8 +776,6 @@ static int mlx5_copy_from_msg(void *to, struct mlx5_cmd_msg *from, int size) | |||
| 773 | 776 | ||
| 774 | copy = min_t(int, size, MLX5_CMD_DATA_BLOCK_SIZE); | 777 | copy = min_t(int, size, MLX5_CMD_DATA_BLOCK_SIZE); |
| 775 | block = next->buf; | 778 | block = next->buf; |
| 776 | if (xor8_buf(block, sizeof(*block)) != 0xff) | ||
| 777 | return -EINVAL; | ||
| 778 | 779 | ||
| 779 | memcpy(to, block->data, copy); | 780 | memcpy(to, block->data, copy); |
| 780 | to += copy; | 781 | to += copy; |
| @@ -1361,6 +1362,7 @@ int mlx5_cmd_init(struct mlx5_core_dev *dev) | |||
| 1361 | goto err_map; | 1362 | goto err_map; |
| 1362 | } | 1363 | } |
| 1363 | 1364 | ||
| 1365 | cmd->checksum_disabled = 1; | ||
| 1364 | cmd->max_reg_cmds = (1 << cmd->log_sz) - 1; | 1366 | cmd->max_reg_cmds = (1 << cmd->log_sz) - 1; |
| 1365 | cmd->bitmask = (1 << cmd->max_reg_cmds) - 1; | 1367 | cmd->bitmask = (1 << cmd->max_reg_cmds) - 1; |
| 1366 | 1368 | ||
| @@ -1510,7 +1512,7 @@ int mlx5_cmd_status_to_err(struct mlx5_outbox_hdr *hdr) | |||
| 1510 | case MLX5_CMD_STAT_BAD_SYS_STATE_ERR: return -EIO; | 1512 | case MLX5_CMD_STAT_BAD_SYS_STATE_ERR: return -EIO; |
| 1511 | case MLX5_CMD_STAT_BAD_RES_ERR: return -EINVAL; | 1513 | case MLX5_CMD_STAT_BAD_RES_ERR: return -EINVAL; |
| 1512 | case MLX5_CMD_STAT_RES_BUSY: return -EBUSY; | 1514 | case MLX5_CMD_STAT_RES_BUSY: return -EBUSY; |
| 1513 | case MLX5_CMD_STAT_LIM_ERR: return -EINVAL; | 1515 | case MLX5_CMD_STAT_LIM_ERR: return -ENOMEM; |
| 1514 | case MLX5_CMD_STAT_BAD_RES_STATE_ERR: return -EINVAL; | 1516 | case MLX5_CMD_STAT_BAD_RES_STATE_ERR: return -EINVAL; |
| 1515 | case MLX5_CMD_STAT_IX_ERR: return -EINVAL; | 1517 | case MLX5_CMD_STAT_IX_ERR: return -EINVAL; |
| 1516 | case MLX5_CMD_STAT_NO_RES_ERR: return -EAGAIN; | 1518 | case MLX5_CMD_STAT_NO_RES_ERR: return -EAGAIN; |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index 443cc4d7b024..2231d93cc7ad 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c | |||
| @@ -366,9 +366,11 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx, | |||
| 366 | goto err_in; | 366 | goto err_in; |
| 367 | } | 367 | } |
| 368 | 368 | ||
| 369 | snprintf(eq->name, MLX5_MAX_EQ_NAME, "%s@pci:%s", | ||
| 370 | name, pci_name(dev->pdev)); | ||
| 369 | eq->eqn = out.eq_number; | 371 | eq->eqn = out.eq_number; |
| 370 | err = request_irq(table->msix_arr[vecidx].vector, mlx5_msix_handler, 0, | 372 | err = request_irq(table->msix_arr[vecidx].vector, mlx5_msix_handler, 0, |
| 371 | name, eq); | 373 | eq->name, eq); |
| 372 | if (err) | 374 | if (err) |
| 373 | goto err_eq; | 375 | goto err_eq; |
| 374 | 376 | ||
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index b47739b0b5f6..bc0f5fb66e24 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c | |||
| @@ -165,9 +165,7 @@ static int handle_hca_cap(struct mlx5_core_dev *dev) | |||
| 165 | struct mlx5_cmd_set_hca_cap_mbox_in *set_ctx = NULL; | 165 | struct mlx5_cmd_set_hca_cap_mbox_in *set_ctx = NULL; |
| 166 | struct mlx5_cmd_query_hca_cap_mbox_in query_ctx; | 166 | struct mlx5_cmd_query_hca_cap_mbox_in query_ctx; |
| 167 | struct mlx5_cmd_set_hca_cap_mbox_out set_out; | 167 | struct mlx5_cmd_set_hca_cap_mbox_out set_out; |
| 168 | struct mlx5_profile *prof = dev->profile; | ||
| 169 | u64 flags; | 168 | u64 flags; |
| 170 | int csum = 1; | ||
| 171 | int err; | 169 | int err; |
| 172 | 170 | ||
| 173 | memset(&query_ctx, 0, sizeof(query_ctx)); | 171 | memset(&query_ctx, 0, sizeof(query_ctx)); |
| @@ -197,20 +195,14 @@ static int handle_hca_cap(struct mlx5_core_dev *dev) | |||
| 197 | memcpy(&set_ctx->hca_cap, &query_out->hca_cap, | 195 | memcpy(&set_ctx->hca_cap, &query_out->hca_cap, |
| 198 | sizeof(set_ctx->hca_cap)); | 196 | sizeof(set_ctx->hca_cap)); |
| 199 | 197 | ||
| 200 | if (prof->mask & MLX5_PROF_MASK_CMDIF_CSUM) { | ||
| 201 | csum = !!prof->cmdif_csum; | ||
| 202 | flags = be64_to_cpu(set_ctx->hca_cap.flags); | ||
| 203 | if (csum) | ||
| 204 | flags |= MLX5_DEV_CAP_FLAG_CMDIF_CSUM; | ||
| 205 | else | ||
| 206 | flags &= ~MLX5_DEV_CAP_FLAG_CMDIF_CSUM; | ||
| 207 | |||
| 208 | set_ctx->hca_cap.flags = cpu_to_be64(flags); | ||
| 209 | } | ||
| 210 | |||
| 211 | if (dev->profile->mask & MLX5_PROF_MASK_QP_SIZE) | 198 | if (dev->profile->mask & MLX5_PROF_MASK_QP_SIZE) |
| 212 | set_ctx->hca_cap.log_max_qp = dev->profile->log_max_qp; | 199 | set_ctx->hca_cap.log_max_qp = dev->profile->log_max_qp; |
| 213 | 200 | ||
| 201 | flags = be64_to_cpu(query_out->hca_cap.flags); | ||
| 202 | /* disable checksum */ | ||
| 203 | flags &= ~MLX5_DEV_CAP_FLAG_CMDIF_CSUM; | ||
| 204 | |||
| 205 | set_ctx->hca_cap.flags = cpu_to_be64(flags); | ||
| 214 | memset(&set_out, 0, sizeof(set_out)); | 206 | memset(&set_out, 0, sizeof(set_out)); |
| 215 | set_ctx->hca_cap.log_uar_page_sz = cpu_to_be16(PAGE_SHIFT - 12); | 207 | set_ctx->hca_cap.log_uar_page_sz = cpu_to_be16(PAGE_SHIFT - 12); |
| 216 | set_ctx->hdr.opcode = cpu_to_be16(MLX5_CMD_OP_SET_HCA_CAP); | 208 | set_ctx->hdr.opcode = cpu_to_be16(MLX5_CMD_OP_SET_HCA_CAP); |
| @@ -225,9 +217,6 @@ static int handle_hca_cap(struct mlx5_core_dev *dev) | |||
| 225 | if (err) | 217 | if (err) |
| 226 | goto query_ex; | 218 | goto query_ex; |
| 227 | 219 | ||
| 228 | if (!csum) | ||
| 229 | dev->cmd.checksum_disabled = 1; | ||
| 230 | |||
| 231 | query_ex: | 220 | query_ex: |
| 232 | kfree(query_out); | 221 | kfree(query_out); |
| 233 | kfree(set_ctx); | 222 | kfree(set_ctx); |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c index 3a2408d44820..7b12acf210f8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | |||
| @@ -90,6 +90,10 @@ struct mlx5_manage_pages_outbox { | |||
| 90 | __be64 pas[0]; | 90 | __be64 pas[0]; |
| 91 | }; | 91 | }; |
| 92 | 92 | ||
| 93 | enum { | ||
| 94 | MAX_RECLAIM_TIME_MSECS = 5000, | ||
| 95 | }; | ||
| 96 | |||
| 93 | static int insert_page(struct mlx5_core_dev *dev, u64 addr, struct page *page, u16 func_id) | 97 | static int insert_page(struct mlx5_core_dev *dev, u64 addr, struct page *page, u16 func_id) |
| 94 | { | 98 | { |
| 95 | struct rb_root *root = &dev->priv.page_root; | 99 | struct rb_root *root = &dev->priv.page_root; |
| @@ -279,6 +283,9 @@ static int reclaim_pages(struct mlx5_core_dev *dev, u32 func_id, int npages, | |||
| 279 | int err; | 283 | int err; |
| 280 | int i; | 284 | int i; |
| 281 | 285 | ||
| 286 | if (nclaimed) | ||
| 287 | *nclaimed = 0; | ||
| 288 | |||
| 282 | memset(&in, 0, sizeof(in)); | 289 | memset(&in, 0, sizeof(in)); |
| 283 | outlen = sizeof(*out) + npages * sizeof(out->pas[0]); | 290 | outlen = sizeof(*out) + npages * sizeof(out->pas[0]); |
| 284 | out = mlx5_vzalloc(outlen); | 291 | out = mlx5_vzalloc(outlen); |
| @@ -388,20 +395,25 @@ static int optimal_reclaimed_pages(void) | |||
| 388 | 395 | ||
| 389 | int mlx5_reclaim_startup_pages(struct mlx5_core_dev *dev) | 396 | int mlx5_reclaim_startup_pages(struct mlx5_core_dev *dev) |
| 390 | { | 397 | { |
| 391 | unsigned long end = jiffies + msecs_to_jiffies(5000); | 398 | unsigned long end = jiffies + msecs_to_jiffies(MAX_RECLAIM_TIME_MSECS); |
| 392 | struct fw_page *fwp; | 399 | struct fw_page *fwp; |
| 393 | struct rb_node *p; | 400 | struct rb_node *p; |
| 401 | int nclaimed = 0; | ||
| 394 | int err; | 402 | int err; |
| 395 | 403 | ||
| 396 | do { | 404 | do { |
| 397 | p = rb_first(&dev->priv.page_root); | 405 | p = rb_first(&dev->priv.page_root); |
| 398 | if (p) { | 406 | if (p) { |
| 399 | fwp = rb_entry(p, struct fw_page, rb_node); | 407 | fwp = rb_entry(p, struct fw_page, rb_node); |
| 400 | err = reclaim_pages(dev, fwp->func_id, optimal_reclaimed_pages(), NULL); | 408 | err = reclaim_pages(dev, fwp->func_id, |
| 409 | optimal_reclaimed_pages(), | ||
| 410 | &nclaimed); | ||
| 401 | if (err) { | 411 | if (err) { |
| 402 | mlx5_core_warn(dev, "failed reclaiming pages (%d)\n", err); | 412 | mlx5_core_warn(dev, "failed reclaiming pages (%d)\n", err); |
| 403 | return err; | 413 | return err; |
| 404 | } | 414 | } |
| 415 | if (nclaimed) | ||
| 416 | end = jiffies + msecs_to_jiffies(MAX_RECLAIM_TIME_MSECS); | ||
| 405 | } | 417 | } |
| 406 | if (time_after(jiffies, end)) { | 418 | if (time_after(jiffies, end)) { |
| 407 | mlx5_core_warn(dev, "FW did not return all pages. giving up...\n"); | 419 | mlx5_core_warn(dev, "FW did not return all pages. giving up...\n"); |
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 0b7d23b4ad95..be12fbfcae10 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
| @@ -994,14 +994,16 @@ void acpiphp_enumerate_slots(struct pci_bus *bus) | |||
| 994 | 994 | ||
| 995 | /* | 995 | /* |
| 996 | * This bridge should have been registered as a hotplug function | 996 | * This bridge should have been registered as a hotplug function |
| 997 | * under its parent, so the context has to be there. If not, we | 997 | * under its parent, so the context should be there, unless the |
| 998 | * are in deep goo. | 998 | * parent is going to be handled by pciehp, in which case this |
| 999 | * bridge is not interesting to us either. | ||
| 999 | */ | 1000 | */ |
| 1000 | mutex_lock(&acpiphp_context_lock); | 1001 | mutex_lock(&acpiphp_context_lock); |
| 1001 | context = acpiphp_get_context(handle); | 1002 | context = acpiphp_get_context(handle); |
| 1002 | if (WARN_ON(!context)) { | 1003 | if (!context) { |
| 1003 | mutex_unlock(&acpiphp_context_lock); | 1004 | mutex_unlock(&acpiphp_context_lock); |
| 1004 | put_device(&bus->dev); | 1005 | put_device(&bus->dev); |
| 1006 | pci_dev_put(bridge->pci_dev); | ||
| 1005 | kfree(bridge); | 1007 | kfree(bridge); |
| 1006 | return; | 1008 | return; |
| 1007 | } | 1009 | } |
diff --git a/drivers/s390/char/sclp_cmd.c b/drivers/s390/char/sclp_cmd.c index 8cd34bf644b3..77df9cb00688 100644 --- a/drivers/s390/char/sclp_cmd.c +++ b/drivers/s390/char/sclp_cmd.c | |||
| @@ -145,9 +145,11 @@ bool __init sclp_has_linemode(void) | |||
| 145 | 145 | ||
| 146 | if (sccb->header.response_code != 0x20) | 146 | if (sccb->header.response_code != 0x20) |
| 147 | return 0; | 147 | return 0; |
| 148 | if (sccb->sclp_send_mask & (EVTYP_MSG_MASK | EVTYP_PMSGCMD_MASK)) | 148 | if (!(sccb->sclp_send_mask & (EVTYP_OPCMD_MASK | EVTYP_PMSGCMD_MASK))) |
| 149 | return 1; | 149 | return 0; |
| 150 | return 0; | 150 | if (!(sccb->sclp_receive_mask & (EVTYP_MSG_MASK | EVTYP_PMSGCMD_MASK))) |
| 151 | return 0; | ||
| 152 | return 1; | ||
| 151 | } | 153 | } |
| 152 | 154 | ||
| 153 | bool __init sclp_has_vt220(void) | 155 | bool __init sclp_has_vt220(void) |
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c index a0f47c83fd62..3f4ca4e09a4c 100644 --- a/drivers/s390/char/tty3270.c +++ b/drivers/s390/char/tty3270.c | |||
| @@ -810,7 +810,7 @@ static void tty3270_resize_work(struct work_struct *work) | |||
| 810 | struct winsize ws; | 810 | struct winsize ws; |
| 811 | 811 | ||
| 812 | screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols); | 812 | screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols); |
| 813 | if (!screen) | 813 | if (IS_ERR(screen)) |
| 814 | return; | 814 | return; |
| 815 | /* Switch to new output size */ | 815 | /* Switch to new output size */ |
| 816 | spin_lock_bh(&tp->view.lock); | 816 | spin_lock_bh(&tp->view.lock); |
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index fd7cc566095a..d4ac60b4a56e 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c | |||
| @@ -1583,7 +1583,7 @@ static int atmel_spi_probe(struct platform_device *pdev) | |||
| 1583 | /* Initialize the hardware */ | 1583 | /* Initialize the hardware */ |
| 1584 | ret = clk_prepare_enable(clk); | 1584 | ret = clk_prepare_enable(clk); |
| 1585 | if (ret) | 1585 | if (ret) |
| 1586 | goto out_unmap_regs; | 1586 | goto out_free_irq; |
| 1587 | spi_writel(as, CR, SPI_BIT(SWRST)); | 1587 | spi_writel(as, CR, SPI_BIT(SWRST)); |
| 1588 | spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ | 1588 | spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ |
| 1589 | if (as->caps.has_wdrbt) { | 1589 | if (as->caps.has_wdrbt) { |
| @@ -1614,6 +1614,7 @@ out_free_dma: | |||
| 1614 | spi_writel(as, CR, SPI_BIT(SWRST)); | 1614 | spi_writel(as, CR, SPI_BIT(SWRST)); |
| 1615 | spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ | 1615 | spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ |
| 1616 | clk_disable_unprepare(clk); | 1616 | clk_disable_unprepare(clk); |
| 1617 | out_free_irq: | ||
| 1617 | free_irq(irq, master); | 1618 | free_irq(irq, master); |
| 1618 | out_unmap_regs: | 1619 | out_unmap_regs: |
| 1619 | iounmap(as->regs); | 1620 | iounmap(as->regs); |
diff --git a/drivers/spi/spi-clps711x.c b/drivers/spi/spi-clps711x.c index 5655acf55bfe..6416798828e7 100644 --- a/drivers/spi/spi-clps711x.c +++ b/drivers/spi/spi-clps711x.c | |||
| @@ -226,7 +226,6 @@ static int spi_clps711x_probe(struct platform_device *pdev) | |||
| 226 | dev_name(&pdev->dev), hw); | 226 | dev_name(&pdev->dev), hw); |
| 227 | if (ret) { | 227 | if (ret) { |
| 228 | dev_err(&pdev->dev, "Can't request IRQ\n"); | 228 | dev_err(&pdev->dev, "Can't request IRQ\n"); |
| 229 | clk_put(hw->spi_clk); | ||
| 230 | goto clk_out; | 229 | goto clk_out; |
| 231 | } | 230 | } |
| 232 | 231 | ||
| @@ -247,7 +246,6 @@ err_out: | |||
| 247 | gpio_free(hw->chipselect[i]); | 246 | gpio_free(hw->chipselect[i]); |
| 248 | 247 | ||
| 249 | spi_master_put(master); | 248 | spi_master_put(master); |
| 250 | kfree(master); | ||
| 251 | 249 | ||
| 252 | return ret; | 250 | return ret; |
| 253 | } | 251 | } |
| @@ -263,7 +261,6 @@ static int spi_clps711x_remove(struct platform_device *pdev) | |||
| 263 | gpio_free(hw->chipselect[i]); | 261 | gpio_free(hw->chipselect[i]); |
| 264 | 262 | ||
| 265 | spi_unregister_master(master); | 263 | spi_unregister_master(master); |
| 266 | kfree(master); | ||
| 267 | 264 | ||
| 268 | return 0; | 265 | return 0; |
| 269 | } | 266 | } |
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 6cd07d13ecab..4e44575bd87a 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c | |||
| @@ -476,15 +476,9 @@ static int dspi_probe(struct platform_device *pdev) | |||
| 476 | master->bus_num = bus_num; | 476 | master->bus_num = bus_num; |
| 477 | 477 | ||
| 478 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 478 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| 479 | if (!res) { | ||
| 480 | dev_err(&pdev->dev, "can't get platform resource\n"); | ||
| 481 | ret = -EINVAL; | ||
| 482 | goto out_master_put; | ||
| 483 | } | ||
| 484 | |||
| 485 | dspi->base = devm_ioremap_resource(&pdev->dev, res); | 479 | dspi->base = devm_ioremap_resource(&pdev->dev, res); |
| 486 | if (!dspi->base) { | 480 | if (IS_ERR(dspi->base)) { |
| 487 | ret = -EINVAL; | 481 | ret = PTR_ERR(dspi->base); |
| 488 | goto out_master_put; | 482 | goto out_master_put; |
| 489 | } | 483 | } |
| 490 | 484 | ||
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index dbc5e999a1f5..6adf4e35816d 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c | |||
| @@ -522,8 +522,10 @@ static int mpc512x_psc_spi_do_probe(struct device *dev, u32 regaddr, | |||
| 522 | psc_num = master->bus_num; | 522 | psc_num = master->bus_num; |
| 523 | snprintf(clk_name, sizeof(clk_name), "psc%d_mclk", psc_num); | 523 | snprintf(clk_name, sizeof(clk_name), "psc%d_mclk", psc_num); |
| 524 | clk = devm_clk_get(dev, clk_name); | 524 | clk = devm_clk_get(dev, clk_name); |
| 525 | if (IS_ERR(clk)) | 525 | if (IS_ERR(clk)) { |
| 526 | ret = PTR_ERR(clk); | ||
| 526 | goto free_irq; | 527 | goto free_irq; |
| 528 | } | ||
| 527 | ret = clk_prepare_enable(clk); | 529 | ret = clk_prepare_enable(clk); |
| 528 | if (ret) | 530 | if (ret) |
| 529 | goto free_irq; | 531 | goto free_irq; |
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 2eb06ee0b326..c1a50674c1e3 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c | |||
| @@ -546,8 +546,17 @@ static irqreturn_t ssp_int(int irq, void *dev_id) | |||
| 546 | if (pm_runtime_suspended(&drv_data->pdev->dev)) | 546 | if (pm_runtime_suspended(&drv_data->pdev->dev)) |
| 547 | return IRQ_NONE; | 547 | return IRQ_NONE; |
| 548 | 548 | ||
| 549 | sccr1_reg = read_SSCR1(reg); | 549 | /* |
| 550 | * If the device is not yet in RPM suspended state and we get an | ||
| 551 | * interrupt that is meant for another device, check if status bits | ||
| 552 | * are all set to one. That means that the device is already | ||
| 553 | * powered off. | ||
| 554 | */ | ||
| 550 | status = read_SSSR(reg); | 555 | status = read_SSSR(reg); |
| 556 | if (status == ~0) | ||
| 557 | return IRQ_NONE; | ||
| 558 | |||
| 559 | sccr1_reg = read_SSCR1(reg); | ||
| 551 | 560 | ||
| 552 | /* Ignore possible writes if we don't need to write */ | 561 | /* Ignore possible writes if we don't need to write */ |
| 553 | if (!(sccr1_reg & SSCR1_TIE)) | 562 | if (!(sccr1_reg & SSCR1_TIE)) |
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 512b8893893b..a80376dc3a10 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c | |||
| @@ -1428,6 +1428,8 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) | |||
| 1428 | S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN, | 1428 | S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN, |
| 1429 | sdd->regs + S3C64XX_SPI_INT_EN); | 1429 | sdd->regs + S3C64XX_SPI_INT_EN); |
| 1430 | 1430 | ||
| 1431 | pm_runtime_enable(&pdev->dev); | ||
| 1432 | |||
| 1431 | if (spi_register_master(master)) { | 1433 | if (spi_register_master(master)) { |
| 1432 | dev_err(&pdev->dev, "cannot register SPI master\n"); | 1434 | dev_err(&pdev->dev, "cannot register SPI master\n"); |
| 1433 | ret = -EBUSY; | 1435 | ret = -EBUSY; |
| @@ -1440,8 +1442,6 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) | |||
| 1440 | mem_res, | 1442 | mem_res, |
| 1441 | sdd->rx_dma.dmach, sdd->tx_dma.dmach); | 1443 | sdd->rx_dma.dmach, sdd->tx_dma.dmach); |
| 1442 | 1444 | ||
| 1443 | pm_runtime_enable(&pdev->dev); | ||
| 1444 | |||
| 1445 | return 0; | 1445 | return 0; |
| 1446 | 1446 | ||
| 1447 | err3: | 1447 | err3: |
diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 0b68cb592fa4..e488a90a98b8 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c | |||
| @@ -296,6 +296,8 @@ static int hspi_probe(struct platform_device *pdev) | |||
| 296 | goto error1; | 296 | goto error1; |
| 297 | } | 297 | } |
| 298 | 298 | ||
| 299 | pm_runtime_enable(&pdev->dev); | ||
| 300 | |||
| 299 | master->num_chipselect = 1; | 301 | master->num_chipselect = 1; |
| 300 | master->bus_num = pdev->id; | 302 | master->bus_num = pdev->id; |
| 301 | master->setup = hspi_setup; | 303 | master->setup = hspi_setup; |
| @@ -309,8 +311,6 @@ static int hspi_probe(struct platform_device *pdev) | |||
| 309 | goto error1; | 311 | goto error1; |
| 310 | } | 312 | } |
| 311 | 313 | ||
| 312 | pm_runtime_enable(&pdev->dev); | ||
| 313 | |||
| 314 | return 0; | 314 | return 0; |
| 315 | 315 | ||
| 316 | error1: | 316 | error1: |
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index a9807dea3887..4fb7a8f83c8a 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c | |||
| @@ -545,6 +545,8 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 545 | long npage; | 545 | long npage; |
| 546 | int ret = 0, prot = 0; | 546 | int ret = 0, prot = 0; |
| 547 | uint64_t mask; | 547 | uint64_t mask; |
| 548 | struct vfio_dma *dma = NULL; | ||
| 549 | unsigned long pfn; | ||
| 548 | 550 | ||
| 549 | end = map->iova + map->size; | 551 | end = map->iova + map->size; |
| 550 | 552 | ||
| @@ -587,8 +589,6 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 587 | } | 589 | } |
| 588 | 590 | ||
| 589 | for (iova = map->iova; iova < end; iova += size, vaddr += size) { | 591 | for (iova = map->iova; iova < end; iova += size, vaddr += size) { |
| 590 | struct vfio_dma *dma = NULL; | ||
| 591 | unsigned long pfn; | ||
| 592 | long i; | 592 | long i; |
| 593 | 593 | ||
| 594 | /* Pin a contiguous chunk of memory */ | 594 | /* Pin a contiguous chunk of memory */ |
| @@ -597,16 +597,15 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 597 | if (npage <= 0) { | 597 | if (npage <= 0) { |
| 598 | WARN_ON(!npage); | 598 | WARN_ON(!npage); |
| 599 | ret = (int)npage; | 599 | ret = (int)npage; |
| 600 | break; | 600 | goto out; |
| 601 | } | 601 | } |
| 602 | 602 | ||
| 603 | /* Verify pages are not already mapped */ | 603 | /* Verify pages are not already mapped */ |
| 604 | for (i = 0; i < npage; i++) { | 604 | for (i = 0; i < npage; i++) { |
| 605 | if (iommu_iova_to_phys(iommu->domain, | 605 | if (iommu_iova_to_phys(iommu->domain, |
| 606 | iova + (i << PAGE_SHIFT))) { | 606 | iova + (i << PAGE_SHIFT))) { |
| 607 | vfio_unpin_pages(pfn, npage, prot, true); | ||
| 608 | ret = -EBUSY; | 607 | ret = -EBUSY; |
| 609 | break; | 608 | goto out_unpin; |
| 610 | } | 609 | } |
| 611 | } | 610 | } |
| 612 | 611 | ||
| @@ -616,8 +615,7 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 616 | if (ret) { | 615 | if (ret) { |
| 617 | if (ret != -EBUSY || | 616 | if (ret != -EBUSY || |
| 618 | map_try_harder(iommu, iova, pfn, npage, prot)) { | 617 | map_try_harder(iommu, iova, pfn, npage, prot)) { |
| 619 | vfio_unpin_pages(pfn, npage, prot, true); | 618 | goto out_unpin; |
| 620 | break; | ||
| 621 | } | 619 | } |
| 622 | } | 620 | } |
| 623 | 621 | ||
| @@ -672,9 +670,8 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 672 | dma = kzalloc(sizeof(*dma), GFP_KERNEL); | 670 | dma = kzalloc(sizeof(*dma), GFP_KERNEL); |
| 673 | if (!dma) { | 671 | if (!dma) { |
| 674 | iommu_unmap(iommu->domain, iova, size); | 672 | iommu_unmap(iommu->domain, iova, size); |
| 675 | vfio_unpin_pages(pfn, npage, prot, true); | ||
| 676 | ret = -ENOMEM; | 673 | ret = -ENOMEM; |
| 677 | break; | 674 | goto out_unpin; |
| 678 | } | 675 | } |
| 679 | 676 | ||
| 680 | dma->size = size; | 677 | dma->size = size; |
| @@ -685,16 +682,21 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, | |||
| 685 | } | 682 | } |
| 686 | } | 683 | } |
| 687 | 684 | ||
| 688 | if (ret) { | 685 | WARN_ON(ret); |
| 689 | struct vfio_dma *tmp; | 686 | mutex_unlock(&iommu->lock); |
| 690 | iova = map->iova; | 687 | return ret; |
| 691 | size = map->size; | 688 | |
| 692 | while ((tmp = vfio_find_dma(iommu, iova, size))) { | 689 | out_unpin: |
| 693 | int r = vfio_remove_dma_overlap(iommu, iova, | 690 | vfio_unpin_pages(pfn, npage, prot, true); |
| 694 | &size, tmp); | 691 | |
| 695 | if (WARN_ON(r || !size)) | 692 | out: |
| 696 | break; | 693 | iova = map->iova; |
| 697 | } | 694 | size = map->size; |
| 695 | while ((dma = vfio_find_dma(iommu, iova, size))) { | ||
| 696 | int r = vfio_remove_dma_overlap(iommu, iova, | ||
| 697 | &size, dma); | ||
| 698 | if (WARN_ON(r || !size)) | ||
| 699 | break; | ||
| 698 | } | 700 | } |
| 699 | 701 | ||
| 700 | mutex_unlock(&iommu->lock); | 702 | mutex_unlock(&iommu->lock); |
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 5be5e3d14f79..19f3c3fc65f4 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c | |||
| @@ -802,6 +802,12 @@ static int hpwdt_init_one(struct pci_dev *dev, | |||
| 802 | return -ENODEV; | 802 | return -ENODEV; |
| 803 | } | 803 | } |
| 804 | 804 | ||
| 805 | /* | ||
| 806 | * Ignore all auxilary iLO devices with the following PCI ID | ||
| 807 | */ | ||
| 808 | if (dev->subsystem_device == 0x1979) | ||
| 809 | return -ENODEV; | ||
| 810 | |||
| 805 | if (pci_enable_device(dev)) { | 811 | if (pci_enable_device(dev)) { |
| 806 | dev_warn(&dev->dev, | 812 | dev_warn(&dev->dev, |
| 807 | "Not possible to enable PCI Device: 0x%x:0x%x.\n", | 813 | "Not possible to enable PCI Device: 0x%x:0x%x.\n", |
diff --git a/drivers/watchdog/kempld_wdt.c b/drivers/watchdog/kempld_wdt.c index 491419e0772a..5c3d4df63e68 100644 --- a/drivers/watchdog/kempld_wdt.c +++ b/drivers/watchdog/kempld_wdt.c | |||
| @@ -35,7 +35,7 @@ | |||
| 35 | #define KEMPLD_WDT_STAGE_TIMEOUT(x) (0x1b + (x) * 4) | 35 | #define KEMPLD_WDT_STAGE_TIMEOUT(x) (0x1b + (x) * 4) |
| 36 | #define KEMPLD_WDT_STAGE_CFG(x) (0x18 + (x)) | 36 | #define KEMPLD_WDT_STAGE_CFG(x) (0x18 + (x)) |
| 37 | #define STAGE_CFG_GET_PRESCALER(x) (((x) & 0x30) >> 4) | 37 | #define STAGE_CFG_GET_PRESCALER(x) (((x) & 0x30) >> 4) |
| 38 | #define STAGE_CFG_SET_PRESCALER(x) (((x) & 0x30) << 4) | 38 | #define STAGE_CFG_SET_PRESCALER(x) (((x) & 0x3) << 4) |
| 39 | #define STAGE_CFG_PRESCALER_MASK 0x30 | 39 | #define STAGE_CFG_PRESCALER_MASK 0x30 |
| 40 | #define STAGE_CFG_ACTION_MASK 0x7 | 40 | #define STAGE_CFG_ACTION_MASK 0x7 |
| 41 | #define STAGE_CFG_ASSERT (1 << 3) | 41 | #define STAGE_CFG_ASSERT (1 << 3) |
diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c index 1f94b42764aa..f6caa77151c7 100644 --- a/drivers/watchdog/sunxi_wdt.c +++ b/drivers/watchdog/sunxi_wdt.c | |||
| @@ -146,7 +146,7 @@ static const struct watchdog_ops sunxi_wdt_ops = { | |||
| 146 | .set_timeout = sunxi_wdt_set_timeout, | 146 | .set_timeout = sunxi_wdt_set_timeout, |
| 147 | }; | 147 | }; |
| 148 | 148 | ||
| 149 | static int __init sunxi_wdt_probe(struct platform_device *pdev) | 149 | static int sunxi_wdt_probe(struct platform_device *pdev) |
| 150 | { | 150 | { |
| 151 | struct sunxi_wdt_dev *sunxi_wdt; | 151 | struct sunxi_wdt_dev *sunxi_wdt; |
| 152 | struct resource *res; | 152 | struct resource *res; |
| @@ -187,7 +187,7 @@ static int __init sunxi_wdt_probe(struct platform_device *pdev) | |||
| 187 | return 0; | 187 | return 0; |
| 188 | } | 188 | } |
| 189 | 189 | ||
| 190 | static int __exit sunxi_wdt_remove(struct platform_device *pdev) | 190 | static int sunxi_wdt_remove(struct platform_device *pdev) |
| 191 | { | 191 | { |
| 192 | struct sunxi_wdt_dev *sunxi_wdt = platform_get_drvdata(pdev); | 192 | struct sunxi_wdt_dev *sunxi_wdt = platform_get_drvdata(pdev); |
| 193 | 193 | ||
diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c index 42913f131dc2..c9b0c627fe7e 100644 --- a/drivers/watchdog/ts72xx_wdt.c +++ b/drivers/watchdog/ts72xx_wdt.c | |||
| @@ -310,7 +310,8 @@ static long ts72xx_wdt_ioctl(struct file *file, unsigned int cmd, | |||
| 310 | 310 | ||
| 311 | case WDIOC_GETSTATUS: | 311 | case WDIOC_GETSTATUS: |
| 312 | case WDIOC_GETBOOTSTATUS: | 312 | case WDIOC_GETBOOTSTATUS: |
| 313 | return put_user(0, p); | 313 | error = put_user(0, p); |
| 314 | break; | ||
| 314 | 315 | ||
| 315 | case WDIOC_KEEPALIVE: | 316 | case WDIOC_KEEPALIVE: |
| 316 | ts72xx_wdt_kick(wdt); | 317 | ts72xx_wdt_kick(wdt); |
