6 files changed, 133 insertions, 84 deletions

diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index e9ee4c52a5f6..c7ac9297a204 100644
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -138,6 +138,7 @@ struct asus_hotk {
                 S2x,            //S200 (J1 reported), Victor MP-XP7210
                 W1N,            //W1000N
                 W5A,            //W5A
+                W3V,            //W3030V
                 xxN,            //M2400N, M3700N, M5200N, M6800N, S1300N, S5200N
                 //(Centrino)
                 END_MODEL
@@ -376,6 +377,17 @@ static struct model_data model_conf[END_MODEL] = {
          .display_get = "\\ADVG"},
 
         {
+         .name = "W3V",
+         .mt_mled = "MLED",
+         .mt_wled = "WLED",
+         .mt_lcd_switch = xxN_PREFIX "_Q10",
+         .lcd_status = "\\BKLT",
+         .brightness_set = "SPLV",
+         .brightness_get = "GPLV",
+         .display_set = "SDSP",
+         .display_get = "\\INFB"},
+
+       {
          .name = "xxN",
          .mt_mled = "MLED",
 /* WLED present, but not controlled by ACPI */
@@ -555,11 +567,11 @@ static int
 write_led(const char __user * buffer, unsigned long count,
           char *ledname, int ledmask, int invert)
 {
-        int value;
+        int rv, value;
         int led_out = 0;
 
-        count = parse_arg(buffer, count, &value);
-        if (count > 0)
+        rv = parse_arg(buffer, count, &value);
+        if (rv > 0)
                 led_out = value ? 1 : 0;
 
         hotk->status =
@@ -572,7 +584,7 @@ write_led(const char __user * buffer, unsigned long count,
                 printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
                        ledname);
 
-        return count;
+        return rv;
 }
 
 /*
@@ -607,20 +619,18 @@ static int
 proc_write_ledd(struct file *file, const char __user * buffer,
                 unsigned long count, void *data)
 {
-        int value;
+        int rv, value;
 
-        count = parse_arg(buffer, count, &value);
-        if (count > 0) {
+        rv = parse_arg(buffer, count, &value);
+        if (rv > 0) {
                 if (!write_acpi_int
                     (hotk->handle, hotk->methods->mt_ledd, value, NULL))
                         printk(KERN_WARNING
                                "Asus ACPI: LED display write failed\n");
                 else
                         hotk->ledd_status = (u32) value;
-        } else if (count < 0)
-                printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
-        return count;
+        }
+        return rv;
 }
 
 /*
@@ -761,12 +771,12 @@ static int
 proc_write_lcd(struct file *file, const char __user * buffer,
                unsigned long count, void *data)
 {
-        int value;
+        int rv, value;
 
-        count = parse_arg(buffer, count, &value);
-        if (count > 0)
+        rv = parse_arg(buffer, count, &value);
+        if (rv > 0)
                 set_lcd_state(value);
-        return count;
+        return rv;
 }
 
 static int read_brightness(void)
@@ -830,18 +840,15 @@ static int
 proc_write_brn(struct file *file, const char __user * buffer,
                unsigned long count, void *data)
 {
-        int value;
+        int rv, value;
 
-        count = parse_arg(buffer, count, &value);
-        if (count > 0) {
+        rv = parse_arg(buffer, count, &value);
+        if (rv > 0) {
                 value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
                 /* 0 <= value <= 15 */
                 set_brightness(value);
-        } else if (count < 0) {
-                printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
         }
-
-        return count;
+        return rv;
 }
 
 static void set_display(int value)
@@ -880,15 +887,12 @@ static int
 proc_write_disp(struct file *file, const char __user * buffer,
                 unsigned long count, void *data)
 {
-        int value;
+        int rv, value;
 
-        count = parse_arg(buffer, count, &value);
-        if (count > 0)
+        rv = parse_arg(buffer, count, &value);
+        if (rv > 0)
                 set_display(value);
-        else if (count < 0)
-                printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
-        return count;
+        return rv;
 }
 
 typedef int (proc_readfunc) (char *page, char **start, off_t off, int count,
@@ -1097,6 +1101,8 @@ static int asus_model_match(char *model)
                 return A4G;
         else if (strncmp(model, "W1N", 3) == 0)
                 return W1N;
+        else if (strncmp(model, "W3V", 3) == 0)
+                return W3V;
         else if (strncmp(model, "W5A", 3) == 0)
                 return W5A;
         else
@@ -1200,9 +1206,10 @@ static int asus_hotk_get_info(void)
                 hotk->methods->mt_wled = NULL;
         /* L5D's WLED is not controlled by ACPI */
         else if (strncmp(string, "M2N", 3) == 0 ||
+                 strncmp(string, "W3V", 3) == 0 ||
                  strncmp(string, "S1N", 3) == 0)
                 hotk->methods->mt_wled = "WLED";
-        /* M2N and S1N have a usable WLED */
+        /* M2N, S1N and W3V have a usable WLED */
         else if (asus_info) {
                 if (strncmp(asus_info->oem_table_id, "L1", 2) == 0)
                         hotk->methods->mled_status = NULL;
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 9810e2a55d0a..026e40755cdd 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -64,6 +64,7 @@ extern void *acpi_unlock_battery_dir(struct proc_dir_entry *acpi_battery_dir);
 
 static int acpi_battery_add(struct acpi_device *device);
 static int acpi_battery_remove(struct acpi_device *device, int type);
+static int acpi_battery_resume(struct acpi_device *device, int status);
 
 static struct acpi_driver acpi_battery_driver = {
         .name = ACPI_BATTERY_DRIVER_NAME,
@@ -71,6 +72,7 @@ static struct acpi_driver acpi_battery_driver = {
         .ids = ACPI_BATTERY_HID,
         .ops = {
                 .add = acpi_battery_add,
+                .resume = acpi_battery_resume,
                 .remove = acpi_battery_remove,
                 },
 };
@@ -753,6 +755,18 @@ static int acpi_battery_remove(struct acpi_device *device, int type)
         return 0;
 }
 
+/* this is needed to learn about changes made in suspended state */
+static int acpi_battery_resume(struct acpi_device *device, int state)
+{
+        struct acpi_battery *battery;
+
+        if (!device)
+                return -EINVAL;
+
+        battery = device->driver_data;
+        return acpi_battery_check(battery);
+}
+
 static int __init acpi_battery_init(void)
 {
         int result;
diff --git a/drivers/acpi/events/evrgnini.c b/drivers/acpi/events/evrgnini.c
index 5b3c7a85eb9a..203d1359190a 100644
--- a/drivers/acpi/events/evrgnini.c
+++ b/drivers/acpi/events/evrgnini.c
@@ -225,13 +225,12 @@ acpi_ev_pci_config_region_setup(acpi_handle handle,
                                 if (!
                                     (ACPI_STRNCMP
                                      (object_hID.value, PCI_ROOT_HID_STRING,
-                                      sizeof(PCI_ROOT_HID_STRING))
-                                     ||
-                                     !(ACPI_STRNCMP
-                                       (object_hID.value,
-                                        PCI_EXPRESS_ROOT_HID_STRING,
-                                        sizeof(PCI_EXPRESS_ROOT_HID_STRING)))))
-                                {
+                                      sizeof(PCI_ROOT_HID_STRING)))
+                                    ||
+                                    !(ACPI_STRNCMP
+                                      (object_hID.value,
+                                       PCI_EXPRESS_ROOT_HID_STRING,
+                                       sizeof(PCI_EXPRESS_ROOT_HID_STRING)))) {
 
                                         /* Install a handler for this PCI root bridge */
 
diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 15fc12482ba0..003a9876c968 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1702,13 +1702,11 @@ static struct ibm_struct ibms[] = {
          .name = "brightness",
          .read = brightness_read,
          .write = brightness_write,
-         .experimental = 1,
          },
         {
          .name = "volume",
          .read = volume_read,
          .write = volume_write,
-         .experimental = 1,
          },
         {
          .name = "fan",
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 0a395fca843b..429a39dbd75d 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -219,6 +219,23 @@ static void acpi_safe_halt(void)
 
 static atomic_t c3_cpu_count;
 
+/* Common C-state entry for C2, C3, .. */
+static void acpi_cstate_enter(struct acpi_processor_cx *cstate)
+{
+        if (cstate->space_id == ACPI_CSTATE_FFH) {
+                /* Call into architectural FFH based C-state */
+                acpi_processor_ffh_cstate_enter(cstate);
+        } else {
+                int unused;
+                /* IO port based C-state */
+                inb(cstate->address);
+                /* Dummy wait op - must do something useless after P_LVL2 read
+                   because chipsets cannot guarantee that STPCLK# signal
+                   gets asserted in time to freeze execution properly. */
+                unused = inl(acpi_fadt.xpm_tmr_blk.address);
+        }
+}
+
 static void acpi_processor_idle(void)
 {
         struct acpi_processor *pr = NULL;
@@ -361,11 +378,7 @@ static void acpi_processor_idle(void)
                 /* Get start time (ticks) */
                 t1 = inl(acpi_fadt.xpm_tmr_blk.address);
                 /* Invoke C2 */
-                inb(cx->address);
-                /* Dummy wait op - must do something useless after P_LVL2 read
-                   because chipsets cannot guarantee that STPCLK# signal
-                   gets asserted in time to freeze execution properly. */
-                t2 = inl(acpi_fadt.xpm_tmr_blk.address);
+                acpi_cstate_enter(cx);
                 /* Get end time (ticks) */
                 t2 = inl(acpi_fadt.xpm_tmr_blk.address);
 
@@ -401,9 +414,7 @@ static void acpi_processor_idle(void)
                 /* Get start time (ticks) */
                 t1 = inl(acpi_fadt.xpm_tmr_blk.address);
                 /* Invoke C3 */
-                inb(cx->address);
-                /* Dummy wait op (see above) */
-                t2 = inl(acpi_fadt.xpm_tmr_blk.address);
+                acpi_cstate_enter(cx);
                 /* Get end time (ticks) */
                 t2 = inl(acpi_fadt.xpm_tmr_blk.address);
                 if (pr->flags.bm_check) {
@@ -628,20 +639,16 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
         return 0;
 }
 
-static int acpi_processor_get_power_info_default_c1(struct acpi_processor *pr)
+static int acpi_processor_get_power_info_default(struct acpi_processor *pr)
 {
-
-        /* Zero initialize all the C-states info. */
-        memset(pr->power.states, 0, sizeof(pr->power.states));
-
-        /* set the first C-State to C1 */
-        pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
-
-        /* the C0 state only exists as a filler in our array,
-         * and all processors need to support C1 */
+        if (!pr->power.states[ACPI_STATE_C1].valid) {
+                /* set the first C-State to C1 */
+                /* all processors need to support C1 */
+                pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
+                pr->power.states[ACPI_STATE_C1].valid = 1;
+        }
+        /* the C0 state only exists as a filler in our array */
         pr->power.states[ACPI_STATE_C0].valid = 1;
-        pr->power.states[ACPI_STATE_C1].valid = 1;
-
         return 0;
 }
 
@@ -658,12 +665,7 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
         if (nocst)
                 return -ENODEV;
 
-        current_count = 1;
-
-        /* Zero initialize C2 onwards and prepare for fresh CST lookup */
-        for (i = 2; i < ACPI_PROCESSOR_MAX_POWER; i++)
-                memset(&(pr->power.states[i]), 0, 
-                                sizeof(struct acpi_processor_cx));
+        current_count = 0;
 
         status = acpi_evaluate_object(pr->handle, "_CST", NULL, &buffer);
         if (ACPI_FAILURE(status)) {
@@ -718,22 +720,39 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
                     (reg->space_id != ACPI_ADR_SPACE_FIXED_HARDWARE))
                         continue;
 
-                cx.address = (reg->space_id == ACPI_ADR_SPACE_FIXED_HARDWARE) ?
-                    0 : reg->address;
-
                 /* There should be an easy way to extract an integer... */
                 obj = (union acpi_object *)&(element->package.elements[1]);
                 if (obj->type != ACPI_TYPE_INTEGER)
                         continue;
 
                 cx.type = obj->integer.value;
-
-                if ((cx.type != ACPI_STATE_C1) &&
-                    (reg->space_id != ACPI_ADR_SPACE_SYSTEM_IO))
-                        continue;
-
-                if ((cx.type < ACPI_STATE_C2) || (cx.type > ACPI_STATE_C3))
-                        continue;
+                /*
+                 * Some buggy BIOSes won't list C1 in _CST -
+                 * Let acpi_processor_get_power_info_default() handle them later
+                 */
+                if (i == 1 && cx.type != ACPI_STATE_C1)
+                        current_count++;
+
+                cx.address = reg->address;
+                cx.index = current_count + 1;
+
+                cx.space_id = ACPI_CSTATE_SYSTEMIO;
+                if (reg->space_id == ACPI_ADR_SPACE_FIXED_HARDWARE) {
+                        if (acpi_processor_ffh_cstate_probe
+                                        (pr->id, &cx, reg) == 0) {
+                                cx.space_id = ACPI_CSTATE_FFH;
+                        } else if (cx.type != ACPI_STATE_C1) {
+                                /*
+                                 * C1 is a special case where FIXED_HARDWARE
+                                 * can be handled in non-MWAIT way as well.
+                                 * In that case, save this _CST entry info.
+                                 * That is, we retain space_id of SYSTEM_IO for
+                                 * halt based C1.
+                                 * Otherwise, ignore this info and continue.
+                                 */
+                                continue;
+                        }
+                }
 
                 obj = (union acpi_object *)&(element->package.elements[2]);
                 if (obj->type != ACPI_TYPE_INTEGER)
@@ -938,12 +957,18 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
         /* NOTE: the idle thread may not be running while calling
          * this function */
 
-        /* Adding C1 state */
-        acpi_processor_get_power_info_default_c1(pr);
+        /* Zero initialize all the C-states info. */
+        memset(pr->power.states, 0, sizeof(pr->power.states));
+
         result = acpi_processor_get_power_info_cst(pr);
         if (result == -ENODEV)
                 acpi_processor_get_power_info_fadt(pr);
 
+        if (result)
+                return result;
+
+        acpi_processor_get_power_info_default(pr);
+
         pr->power.count = acpi_processor_power_verify(pr);
 
         /*
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index 62bef0b3b614..8908a975e575 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -98,11 +98,11 @@ static int update_info_mode = UPDATE_INFO_MODE;
 static int update_time = UPDATE_TIME;
 static int update_time2 = UPDATE_TIME2;
 
-module_param(capacity_mode, int, CAPACITY_UNIT);
-module_param(update_mode, int, UPDATE_MODE);
-module_param(update_info_mode, int, UPDATE_INFO_MODE);
-module_param(update_time, int, UPDATE_TIME);
-module_param(update_time2, int, UPDATE_TIME2);
+module_param(capacity_mode, int, 0);
+module_param(update_mode, int, 0);
+module_param(update_info_mode, int, 0);
+module_param(update_time, int, 0);
+module_param(update_time2, int, 0);
 
 static int acpi_sbs_add(struct acpi_device *device);
 static int acpi_sbs_remove(struct acpi_device *device, int type);
@@ -1685,10 +1685,16 @@ static int acpi_sbs_add(struct acpi_device *device)
 
 int acpi_sbs_remove(struct acpi_device *device, int type)
 {
-        struct acpi_sbs *sbs = (struct acpi_sbs *)acpi_driver_data(device);
+        struct acpi_sbs *sbs = NULL;
         int id;
 
-        if (!device || !sbs) {
+        if (!device) {
+                return -EINVAL;
+        }
+
+        sbs = (struct acpi_sbs *)acpi_driver_data(device);
+
+        if (!sbs) {
                 return -EINVAL;
         }