5 files changed, 105 insertions, 17 deletions

diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
index 96109a9972b6..84b4bfb84344 100644
--- a/drivers/xen/events/events_fifo.c
+++ b/drivers/xen/events/events_fifo.c
@@ -66,7 +66,22 @@ static DEFINE_PER_CPU(struct evtchn_fifo_queue, cpu_queue);
 static event_word_t *event_array[MAX_EVENT_ARRAY_PAGES] __read_mostly;
 static unsigned event_array_pages __read_mostly;
 
+/*
+ * sync_set_bit() and friends must be unsigned long aligned on non-x86
+ * platforms.
+ */
+#if !defined(CONFIG_X86) && BITS_PER_LONG > 32
+
+#define BM(w) (unsigned long *)((unsigned long)w & ~0x7UL)
+#define EVTCHN_FIFO_BIT(b, w) \
+    (((unsigned long)w & 0x4UL) ? (EVTCHN_FIFO_ ##b + 32) : EVTCHN_FIFO_ ##b)
+
+#else
+
 #define BM(w) ((unsigned long *)(w))
+#define EVTCHN_FIFO_BIT(b, w) EVTCHN_FIFO_ ##b
+
+#endif
 
 static inline event_word_t *event_word_from_port(unsigned port)
 {
@@ -161,33 +176,38 @@ static void evtchn_fifo_bind_to_cpu(struct irq_info *info, unsigned cpu)
 static void evtchn_fifo_clear_pending(unsigned port)
 {
         event_word_t *word = event_word_from_port(port);
-        sync_clear_bit(EVTCHN_FIFO_PENDING, BM(word));
+        sync_clear_bit(EVTCHN_FIFO_BIT(PENDING, word), BM(word));
 }
 
 static void evtchn_fifo_set_pending(unsigned port)
 {
         event_word_t *word = event_word_from_port(port);
-        sync_set_bit(EVTCHN_FIFO_PENDING, BM(word));
+        sync_set_bit(EVTCHN_FIFO_BIT(PENDING, word), BM(word));
 }
 
 static bool evtchn_fifo_is_pending(unsigned port)
 {
         event_word_t *word = event_word_from_port(port);
-        return sync_test_bit(EVTCHN_FIFO_PENDING, BM(word));
+        return sync_test_bit(EVTCHN_FIFO_BIT(PENDING, word), BM(word));
 }
 
 static bool evtchn_fifo_test_and_set_mask(unsigned port)
 {
         event_word_t *word = event_word_from_port(port);
-        return sync_test_and_set_bit(EVTCHN_FIFO_MASKED, BM(word));
+        return sync_test_and_set_bit(EVTCHN_FIFO_BIT(MASKED, word), BM(word));
 }
 
 static void evtchn_fifo_mask(unsigned port)
 {
         event_word_t *word = event_word_from_port(port);
-        sync_set_bit(EVTCHN_FIFO_MASKED, BM(word));
+        sync_set_bit(EVTCHN_FIFO_BIT(MASKED, word), BM(word));
 }
 
+static bool evtchn_fifo_is_masked(unsigned port)
+{
+        event_word_t *word = event_word_from_port(port);
+        return sync_test_bit(EVTCHN_FIFO_BIT(MASKED, word), BM(word));
+}
 /*
  * Clear MASKED, spinning if BUSY is set.
  */
@@ -211,7 +231,7 @@ static void evtchn_fifo_unmask(unsigned port)
         BUG_ON(!irqs_disabled());
 
         clear_masked(word);
-        if (sync_test_bit(EVTCHN_FIFO_PENDING, BM(word))) {
+        if (evtchn_fifo_is_pending(port)) {
                 struct evtchn_unmask unmask = { .port = port };
                 (void)HYPERVISOR_event_channel_op(EVTCHNOP_unmask, &unmask);
         }
@@ -243,7 +263,7 @@ static void handle_irq_for_port(unsigned port)
 
 static void consume_one_event(unsigned cpu,
                               struct evtchn_fifo_control_block *control_block,
-                              unsigned priority, uint32_t *ready)
+                              unsigned priority, unsigned long *ready)
 {
         struct evtchn_fifo_queue *q = &per_cpu(cpu_queue, cpu);
         uint32_t head;
@@ -273,10 +293,9 @@ static void consume_one_event(unsigned cpu,
          * copy of the ready word.
          */
         if (head == 0)
-                clear_bit(priority, BM(ready));
+                clear_bit(priority, ready);
 
-        if (sync_test_bit(EVTCHN_FIFO_PENDING, BM(word))
-            && !sync_test_bit(EVTCHN_FIFO_MASKED, BM(word)))
+        if (evtchn_fifo_is_pending(port) && !evtchn_fifo_is_masked(port))
                 handle_irq_for_port(port);
 
         q->head[priority] = head;
@@ -285,7 +304,7 @@ static void consume_one_event(unsigned cpu,
 static void evtchn_fifo_handle_events(unsigned cpu)
 {
         struct evtchn_fifo_control_block *control_block;
-        uint32_t ready;
+        unsigned long ready;
         unsigned q;
 
         control_block = per_cpu(cpu_control_block, cpu);
diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index fc6c94c0b436..32f9236c959f 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -198,10 +198,32 @@ struct shutdown_handler {
         void (*cb)(void);
 };
 
+static int poweroff_nb(struct notifier_block *cb, unsigned long code, void *unused)
+{
+        switch (code) {
+        case SYS_DOWN:
+        case SYS_HALT:
+        case SYS_POWER_OFF:
+                shutting_down = SHUTDOWN_POWEROFF;
+        default:
+                break;
+        }
+        return NOTIFY_DONE;
+}
 static void do_poweroff(void)
 {
-        shutting_down = SHUTDOWN_POWEROFF;
-        orderly_poweroff(false);
+        switch (system_state) {
+        case SYSTEM_BOOTING:
+                orderly_poweroff(true);
+                break;
+        case SYSTEM_RUNNING:
+                orderly_poweroff(false);
+                break;
+        default:
+                /* Don't do it when we are halting/rebooting. */
+                pr_info("Ignoring Xen toolstack shutdown.\n");
+                break;
+        }
 }
 
 static void do_reboot(void)
@@ -307,6 +329,10 @@ static struct xenbus_watch shutdown_watch = {
         .callback = shutdown_handler
 };
 
+static struct notifier_block xen_reboot_nb = {
+        .notifier_call = poweroff_nb,
+};
+
 static int setup_shutdown_watcher(void)
 {
         int err;
@@ -317,6 +343,7 @@ static int setup_shutdown_watcher(void)
                 return err;
         }
 
+
 #ifdef CONFIG_MAGIC_SYSRQ
         err = register_xenbus_watch(&sysrq_watch);
         if (err) {
@@ -345,6 +372,7 @@ int xen_setup_shutdown_event(void)
         if (!xen_domain())
                 return -ENODEV;
         register_xenstore_notifier(&xenstore_notifier);
+        register_reboot_notifier(&xen_reboot_nb);
 
         return 0;
 }
diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 929dd46bb40c..607e41460c0d 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -217,7 +217,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
         if (result == 0) {
                 for (i = 0; i < op->value; i++) {
                         op->msix_entries[i].entry = entries[i].entry;
-                        if (entries[i].vector)
+                        if (entries[i].vector) {
                                 op->msix_entries[i].vector =
                                         xen_pirq_from_irq(entries[i].vector);
                                 if (unlikely(verbose_request))
@@ -225,6 +225,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
                                                 "MSI-X[%d]: %d\n",
                                                 pci_name(dev), i,
                                                 op->msix_entries[i].vector);
+                        }
                 }
         } else
                 pr_warn_ratelimited("%s: error enabling MSI-X for guest %u: err %d!\n",
diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c
index 3165ce361b00..51afff96c515 100644
--- a/drivers/xen/xen-pciback/vpci.c
+++ b/drivers/xen/xen-pciback/vpci.c
@@ -137,6 +137,8 @@ unlock:
         /* Publish this device. */
         if (!err)
                 err = publish_cb(pdev, 0, 0, PCI_DEVFN(slot, func), devid);
+        else
+                kfree(dev_entry);
 
 out:
         return err;
diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
index b6d5fff43d16..ba804f3d8278 100644
--- a/drivers/xen/xenbus/xenbus_xs.c
+++ b/drivers/xen/xenbus/xenbus_xs.c
@@ -50,6 +50,7 @@
 #include <xen/xenbus.h>
 #include <xen/xen.h>
 #include "xenbus_comms.h"
+#include "xenbus_probe.h"
 
 struct xs_stored_msg {
         struct list_head list;
@@ -139,6 +140,29 @@ static int get_error(const char *errorstring)
         return xsd_errors[i].errnum;
 }
 
+static bool xenbus_ok(void)
+{
+        switch (xen_store_domain_type) {
+        case XS_LOCAL:
+                switch (system_state) {
+                case SYSTEM_POWER_OFF:
+                case SYSTEM_RESTART:
+                case SYSTEM_HALT:
+                        return false;
+                default:
+                        break;
+                }
+                return true;
+        case XS_PV:
+        case XS_HVM:
+                /* FIXME: Could check that the remote domain is alive,
+                 * but it is normally initial domain. */
+                return true;
+        default:
+                break;
+        }
+        return false;
+}
 static void *read_reply(enum xsd_sockmsg_type *type, unsigned int *len)
 {
         struct xs_stored_msg *msg;
@@ -148,9 +172,20 @@ static void *read_reply(enum xsd_sockmsg_type *type, unsigned int *len)
 
         while (list_empty(&xs_state.reply_list)) {
                 spin_unlock(&xs_state.reply_lock);
-                /* XXX FIXME: Avoid synchronous wait for response here. */
-                wait_event(xs_state.reply_waitq,
-                           !list_empty(&xs_state.reply_list));
+                if (xenbus_ok())
+                        /* XXX FIXME: Avoid synchronous wait for response here. */
+                        wait_event_timeout(xs_state.reply_waitq,
+                                           !list_empty(&xs_state.reply_list),
+                                           msecs_to_jiffies(500));
+                else {
+                        /*
+                         * If we are in the process of being shut-down there is
+                         * no point of trying to contact XenBus - it is either
+                         * killed (xenstored application) or the other domain
+                         * has been killed or is unreachable.
+                         */
+                        return ERR_PTR(-EIO);
+                }
                 spin_lock(&xs_state.reply_lock);
         }
 
@@ -215,6 +250,9 @@ void *xenbus_dev_request_and_reply(struct xsd_sockmsg *msg)
 
         mutex_unlock(&xs_state.request_mutex);
 
+        if (IS_ERR(ret))
+                return ret;
+
         if ((msg->type == XS_TRANSACTION_END) ||
             ((req_msg.type == XS_TRANSACTION_START) &&
              (msg->type == XS_ERROR)))