aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/xen
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/mcelog.c18
1 files changed, 11 insertions, 7 deletions
diff --git a/drivers/xen/mcelog.c b/drivers/xen/mcelog.c
index 72e87d2f1929..804aa3c181c2 100644
--- a/drivers/xen/mcelog.c
+++ b/drivers/xen/mcelog.c
@@ -55,7 +55,7 @@ static struct mc_info g_mi;
55static struct mcinfo_logical_cpu *g_physinfo; 55static struct mcinfo_logical_cpu *g_physinfo;
56static uint32_t ncpus; 56static uint32_t ncpus;
57 57
58static DEFINE_SPINLOCK(mcelog_lock); 58static DEFINE_MUTEX(mcelog_lock);
59 59
60static struct xen_mce_log xen_mcelog = { 60static struct xen_mce_log xen_mcelog = {
61 .signature = XEN_MCE_LOG_SIGNATURE, 61 .signature = XEN_MCE_LOG_SIGNATURE,
@@ -106,7 +106,7 @@ static ssize_t xen_mce_chrdev_read(struct file *filp, char __user *ubuf,
106 unsigned num; 106 unsigned num;
107 int i, err; 107 int i, err;
108 108
109 spin_lock(&mcelog_lock); 109 mutex_lock(&mcelog_lock);
110 110
111 num = xen_mcelog.next; 111 num = xen_mcelog.next;
112 112
@@ -130,7 +130,7 @@ static ssize_t xen_mce_chrdev_read(struct file *filp, char __user *ubuf,
130 err = -EFAULT; 130 err = -EFAULT;
131 131
132out: 132out:
133 spin_unlock(&mcelog_lock); 133 mutex_unlock(&mcelog_lock);
134 134
135 return err ? err : buf - ubuf; 135 return err ? err : buf - ubuf;
136} 136}
@@ -310,12 +310,11 @@ static int mc_queue_handle(uint32_t flags)
310} 310}
311 311
312/* virq handler for machine check error info*/ 312/* virq handler for machine check error info*/
313static irqreturn_t xen_mce_interrupt(int irq, void *dev_id) 313static void xen_mce_work_fn(struct work_struct *work)
314{ 314{
315 int err; 315 int err;
316 unsigned long tmp;
317 316
318 spin_lock_irqsave(&mcelog_lock, tmp); 317 mutex_lock(&mcelog_lock);
319 318
320 /* urgent mc_info */ 319 /* urgent mc_info */
321 err = mc_queue_handle(XEN_MC_URGENT); 320 err = mc_queue_handle(XEN_MC_URGENT);
@@ -330,8 +329,13 @@ static irqreturn_t xen_mce_interrupt(int irq, void *dev_id)
330 pr_err(XEN_MCELOG 329 pr_err(XEN_MCELOG
331 "Failed to handle nonurgent mc_info queue.\n"); 330 "Failed to handle nonurgent mc_info queue.\n");
332 331
333 spin_unlock_irqrestore(&mcelog_lock, tmp); 332 mutex_unlock(&mcelog_lock);
333}
334static DECLARE_WORK(xen_mce_work, xen_mce_work_fn);
334 335
336static irqreturn_t xen_mce_interrupt(int irq, void *dev_id)
337{
338 schedule_work(&xen_mce_work);
335 return IRQ_HANDLED; 339 return IRQ_HANDLED;
336} 340}
337 341