diff options
Diffstat (limited to 'drivers/w1/w1_int.c')
| -rw-r--r-- | drivers/w1/w1_int.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c index 68565aacec7b..357a2e0f637a 100644 --- a/drivers/w1/w1_int.c +++ b/drivers/w1/w1_int.c | |||
| @@ -65,7 +65,7 @@ static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl, | |||
| 65 | atomic_set(&dev->refcnt, 2); | 65 | atomic_set(&dev->refcnt, 2); |
| 66 | 66 | ||
| 67 | INIT_LIST_HEAD(&dev->slist); | 67 | INIT_LIST_HEAD(&dev->slist); |
| 68 | init_MUTEX(&dev->mutex); | 68 | mutex_init(&dev->mutex); |
| 69 | 69 | ||
| 70 | memcpy(&dev->dev, device, sizeof(struct device)); | 70 | memcpy(&dev->dev, device, sizeof(struct device)); |
| 71 | snprintf(dev->dev.bus_id, sizeof(dev->dev.bus_id), | 71 | snprintf(dev->dev.bus_id, sizeof(dev->dev.bus_id), |
| @@ -74,16 +74,11 @@ static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl, | |||
| 74 | 74 | ||
| 75 | dev->driver = driver; | 75 | dev->driver = driver; |
| 76 | 76 | ||
| 77 | dev->groups = 1; | ||
| 78 | dev->seq = 1; | 77 | dev->seq = 1; |
| 79 | dev_init_netlink(dev); | ||
| 80 | 78 | ||
| 81 | err = device_register(&dev->dev); | 79 | err = device_register(&dev->dev); |
| 82 | if (err) { | 80 | if (err) { |
| 83 | printk(KERN_ERR "Failed to register master device. err=%d\n", err); | 81 | printk(KERN_ERR "Failed to register master device. err=%d\n", err); |
| 84 | |||
| 85 | dev_fini_netlink(dev); | ||
| 86 | |||
| 87 | memset(dev, 0, sizeof(struct w1_master)); | 82 | memset(dev, 0, sizeof(struct w1_master)); |
| 88 | kfree(dev); | 83 | kfree(dev); |
| 89 | dev = NULL; | 84 | dev = NULL; |
| @@ -131,12 +126,12 @@ int w1_add_master_device(struct w1_bus_master *master) | |||
| 131 | 126 | ||
| 132 | dev->initialized = 1; | 127 | dev->initialized = 1; |
| 133 | 128 | ||
| 134 | spin_lock(&w1_mlock); | 129 | mutex_lock(&w1_mlock); |
| 135 | list_add(&dev->w1_master_entry, &w1_masters); | 130 | list_add(&dev->w1_master_entry, &w1_masters); |
| 136 | spin_unlock(&w1_mlock); | 131 | mutex_unlock(&w1_mlock); |
| 137 | 132 | ||
| 133 | memset(&msg, 0, sizeof(msg)); | ||
| 138 | msg.id.mst.id = dev->id; | 134 | msg.id.mst.id = dev->id; |
| 139 | msg.id.mst.pid = dev->thread->pid; | ||
| 140 | msg.type = W1_MASTER_ADD; | 135 | msg.type = W1_MASTER_ADD; |
| 141 | w1_netlink_send(dev, &msg); | 136 | w1_netlink_send(dev, &msg); |
| 142 | 137 | ||
| @@ -153,7 +148,6 @@ err_out_free_dev: | |||
| 153 | void __w1_remove_master_device(struct w1_master *dev) | 148 | void __w1_remove_master_device(struct w1_master *dev) |
| 154 | { | 149 | { |
| 155 | struct w1_netlink_msg msg; | 150 | struct w1_netlink_msg msg; |
| 156 | pid_t pid = dev->thread->pid; | ||
| 157 | 151 | ||
| 158 | set_bit(W1_MASTER_NEED_EXIT, &dev->flags); | 152 | set_bit(W1_MASTER_NEED_EXIT, &dev->flags); |
| 159 | kthread_stop(dev->thread); | 153 | kthread_stop(dev->thread); |
| @@ -166,8 +160,8 @@ void __w1_remove_master_device(struct w1_master *dev) | |||
| 166 | flush_signals(current); | 160 | flush_signals(current); |
| 167 | } | 161 | } |
| 168 | 162 | ||
| 163 | memset(&msg, 0, sizeof(msg)); | ||
| 169 | msg.id.mst.id = dev->id; | 164 | msg.id.mst.id = dev->id; |
| 170 | msg.id.mst.pid = pid; | ||
| 171 | msg.type = W1_MASTER_REMOVE; | 165 | msg.type = W1_MASTER_REMOVE; |
| 172 | w1_netlink_send(dev, &msg); | 166 | w1_netlink_send(dev, &msg); |
| 173 | 167 | ||
