1 files changed, 95 insertions, 13 deletions

diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
index d58c68cd456e..15a0ee6d8e23 100644
--- a/drivers/video/imxfb.c
+++ b/drivers/video/imxfb.c
@@ -14,7 +14,6 @@
  *      linux-arm-kernel@lists.arm.linux.org.uk
  */
 
-
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/errno.h>
@@ -27,9 +26,11 @@
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/cpufreq.h>
+#include <linux/clk.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/io.h>
+#include <linux/math64.h>
 
 #include <mach/imxfb.h>
 
@@ -44,7 +45,12 @@
 
 #define LCDC_SIZE       0x04
 #define SIZE_XMAX(x)    ((((x) >> 4) & 0x3f) << 20)
+
+#ifdef CONFIG_ARCH_MX1
 #define SIZE_YMAX(y)    ((y) & 0x1ff)
+#else
+#define SIZE_YMAX(y)    ((y) & 0x3ff)
+#endif
 
 #define LCDC_VPW        0x08
 #define VPW_VPW(x)      ((x) & 0x3ff)
@@ -54,7 +60,12 @@
 #define CPOS_CC0        (1<<30)
 #define CPOS_OP         (1<<28)
 #define CPOS_CXP(x)     (((x) & 3ff) << 16)
+
+#ifdef CONFIG_ARCH_MX1
 #define CPOS_CYP(y)     ((y) & 0x1ff)
+#else
+#define CPOS_CYP(y)     ((y) & 0x3ff)
+#endif
 
 #define LCDC_LCWHB      0x10
 #define LCWHB_BK_EN     (1<<31)
@@ -63,9 +74,16 @@
 #define LCWHB_BD(x)     ((x) & 0xff)
 
 #define LCDC_LCHCC      0x14
+
+#ifdef CONFIG_ARCH_MX1
 #define LCHCC_CUR_COL_R(r) (((r) & 0x1f) << 11)
 #define LCHCC_CUR_COL_G(g) (((g) & 0x3f) << 5)
 #define LCHCC_CUR_COL_B(b) ((b) & 0x1f)
+#else
+#define LCHCC_CUR_COL_R(r) (((r) & 0x3f) << 12)
+#define LCHCC_CUR_COL_G(g) (((g) & 0x3f) << 6)
+#define LCHCC_CUR_COL_B(b) ((b) & 0x3f)
+#endif
 
 #define LCDC_PCR        0x18
 
@@ -92,7 +110,13 @@
 /* bit fields in imxfb.h */
 
 #define LCDC_RMCR       0x34
+
+#ifdef CONFIG_ARCH_MX1
 #define RMCR_LCDC_EN    (1<<1)
+#else
+#define RMCR_LCDC_EN    0
+#endif
+
 #define RMCR_SELF_REF   (1<<0)
 
 #define LCDC_LCDICR     0x38
@@ -119,6 +143,7 @@ struct imxfb_rgb {
 struct imxfb_info {
         struct platform_device  *pdev;
         void __iomem            *regs;
+        struct clk              *clk;
 
         u_int                   max_bpp;
         u_int                   max_xres;
@@ -159,6 +184,17 @@ struct imxfb_info {
 #define MIN_XRES        64
 #define MIN_YRES        64
 
+/* Actually this really is 18bit support, the lowest 2 bits of each colour
+ * are unused in hardware. We claim to have 24bit support to make software
+ * like X work, which does not support 18bit.
+ */
+static struct imxfb_rgb def_rgb_18 = {
+        .red    = {.offset = 16, .length = 8,},
+        .green  = {.offset = 8, .length = 8,},
+        .blue   = {.offset = 0, .length = 8,},
+        .transp = {.offset = 0, .length = 0,},
+};
+
 static struct imxfb_rgb def_rgb_16_tft = {
         .red    = {.offset = 11, .length = 5,},
         .green  = {.offset = 5, .length = 6,},
@@ -286,9 +322,12 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 
         pr_debug("var->bits_per_pixel=%d\n", var->bits_per_pixel);
         switch (var->bits_per_pixel) {
+        case 32:
+                rgb = &def_rgb_18;
+                break;
         case 16:
         default:
-                if (readl(fbi->regs + LCDC_PCR) & PCR_TFT)
+                if (fbi->pcr & PCR_TFT)
                         rgb = &def_rgb_16_tft;
                 else
                         rgb = &def_rgb_16_stn;
@@ -327,9 +366,7 @@ static int imxfb_set_par(struct fb_info *info)
         struct imxfb_info *fbi = info->par;
         struct fb_var_screeninfo *var = &info->var;
 
-        pr_debug("set_par\n");
-
-        if (var->bits_per_pixel == 16)
+        if (var->bits_per_pixel == 16 || var->bits_per_pixel == 32)
                 info->fix.visual = FB_VISUAL_TRUECOLOR;
         else if (!fbi->cmap_static)
                 info->fix.visual = FB_VISUAL_PSEUDOCOLOR;
@@ -354,10 +391,6 @@ static void imxfb_enable_controller(struct imxfb_info *fbi)
 {
         pr_debug("Enabling LCD controller\n");
 
-        /* initialize LCDC */
-        writel(readl(fbi->regs + LCDC_RMCR) & ~RMCR_LCDC_EN,
-                fbi->regs + LCDC_RMCR); /* just to be safe... */
-
         writel(fbi->screen_dma, fbi->regs + LCDC_SSA);
 
         /* physical screen start address            */
@@ -373,6 +406,8 @@ static void imxfb_enable_controller(struct imxfb_info *fbi)
 
         writel(RMCR_LCDC_EN, fbi->regs + LCDC_RMCR);
 
+        clk_enable(fbi->clk);
+
         if (fbi->backlight_power)
                 fbi->backlight_power(1);
         if (fbi->lcd_power)
@@ -388,6 +423,8 @@ static void imxfb_disable_controller(struct imxfb_info *fbi)
         if (fbi->lcd_power)
                 fbi->lcd_power(0);
 
+        clk_disable(fbi->clk);
+
         writel(0, fbi->regs + LCDC_RMCR);
 }
 
@@ -431,6 +468,9 @@ static struct fb_ops imxfb_ops = {
 static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *info)
 {
         struct imxfb_info *fbi = info->par;
+        unsigned int pcr, lcd_clk;
+        unsigned long long tmp;
+
         pr_debug("var: xres=%d hslen=%d lm=%d rm=%d\n",
                 var->xres, var->hsync_len,
                 var->left_margin, var->right_margin);
@@ -465,9 +505,9 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
                         info->fix.id, var->lower_margin);
 #endif
 
-        writel(HCR_H_WIDTH(var->hsync_len) |
-                HCR_H_WAIT_1(var->right_margin) |
-                HCR_H_WAIT_2(var->left_margin),
+        writel(HCR_H_WIDTH(var->hsync_len - 1) |
+                HCR_H_WAIT_1(var->right_margin - 1) |
+                HCR_H_WAIT_2(var->left_margin - 3),
                 fbi->regs + LCDC_HCR);
 
         writel(VCR_V_WIDTH(var->vsync_len) |
@@ -477,7 +517,23 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 
         writel(SIZE_XMAX(var->xres) | SIZE_YMAX(var->yres),
                         fbi->regs + LCDC_SIZE);
-        writel(fbi->pcr, fbi->regs + LCDC_PCR);
+
+        lcd_clk = clk_get_rate(fbi->clk);
+        tmp = var->pixclock * (unsigned long long)lcd_clk;
+        do_div(tmp, 1000000);
+        if (do_div(tmp, 1000000) > 500000)
+                tmp++;
+        pcr = (unsigned int)tmp;
+        if (--pcr > 0x3F) {
+                pcr = 0x3F;
+                printk(KERN_WARNING "Must limit pixel clock to %uHz\n",
+                                lcd_clk / pcr);
+        }
+
+        /* add sync polarities */
+        pcr |= fbi->pcr & ~0x3F;
+
+        writel(pcr, fbi->regs + LCDC_PCR);
         writel(fbi->pwmr, fbi->regs + LCDC_PWMR);
         writel(fbi->lscr1, fbi->regs + LCDC_LSCR1);
         writel(fbi->dmacr, fbi->regs + LCDC_DMACR);
@@ -619,6 +675,13 @@ static int __init imxfb_probe(struct platform_device *pdev)
                 goto failed_req;
         }
 
+        fbi->clk = clk_get(&pdev->dev, NULL);
+        if (IS_ERR(fbi->clk)) {
+                ret = PTR_ERR(fbi->clk);;
+                dev_err(&pdev->dev, "unable to get clock: %d\n", ret);
+                goto failed_getclock;
+        }
+
         fbi->regs = ioremap(res->start, resource_size(res));
         if (fbi->regs == NULL) {
                 printk(KERN_ERR"Cannot map frame buffer registers\n");
@@ -650,6 +713,12 @@ static int __init imxfb_probe(struct platform_device *pdev)
                 info->fix.smem_start = fbi->screen_dma;
         }
 
+        if (pdata->init) {
+                ret = pdata->init(fbi->pdev);
+                if (ret)
+                        goto failed_platform_init;
+        }
+
         /*
          * This makes sure that our colour bitfield
          * descriptors are correctly initialised.
@@ -674,10 +743,15 @@ static int __init imxfb_probe(struct platform_device *pdev)
 failed_register:
         fb_dealloc_cmap(&info->cmap);
 failed_cmap:
+        if (pdata->exit)
+                pdata->exit(fbi->pdev);
+failed_platform_init:
         if (!pdata->fixed_screen_cpu)
                 dma_free_writecombine(&pdev->dev,fbi->map_size,fbi->map_cpu,
                         fbi->map_dma);
 failed_map:
+        clk_put(fbi->clk);
+failed_getclock:
         iounmap(fbi->regs);
 failed_ioremap:
         release_mem_region(res->start, res->end - res->start);
@@ -691,6 +765,7 @@ failed_init:
 
 static int __devexit imxfb_remove(struct platform_device *pdev)
 {
+        struct imx_fb_platform_data *pdata;
         struct fb_info *info = platform_get_drvdata(pdev);
         struct imxfb_info *fbi = info->par;
         struct resource *res;
@@ -701,12 +776,19 @@ static int __devexit imxfb_remove(struct platform_device *pdev)
 
         unregister_framebuffer(info);
 
+        pdata = pdev->dev.platform_data;
+        if (pdata->exit)
+                pdata->exit(fbi->pdev);
+
         fb_dealloc_cmap(&info->cmap);
         kfree(info->pseudo_palette);
         framebuffer_release(info);
 
         iounmap(fbi->regs);
         release_mem_region(res->start, res->end - res->start + 1);
+        clk_disable(fbi->clk);
+        clk_put(fbi->clk);
+
         platform_set_drvdata(pdev, NULL);
 
         return 0;