diff options
Diffstat (limited to 'drivers/video/bf54x-lq043fb.c')
-rw-r--r-- | drivers/video/bf54x-lq043fb.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c index 37e60b1d2ed9..e49ae5edcc00 100644 --- a/drivers/video/bf54x-lq043fb.c +++ b/drivers/video/bf54x-lq043fb.c | |||
@@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct fb_info *info, int user) | |||
323 | bfin_write_EPPI0_CONTROL(0); | 323 | bfin_write_EPPI0_CONTROL(0); |
324 | SSYNC(); | 324 | SSYNC(); |
325 | disable_dma(CH_EPPI0); | 325 | disable_dma(CH_EPPI0); |
326 | memset(fbi->fb_buffer, 0, info->fix.smem_len); | ||
327 | } | 326 | } |
328 | 327 | ||
329 | spin_unlock(&fbi->lock); | 328 | spin_unlock(&fbi->lock); |
@@ -530,7 +529,7 @@ static irqreturn_t bfin_bf54x_irq_error(int irq, void *dev_id) | |||
530 | return IRQ_HANDLED; | 529 | return IRQ_HANDLED; |
531 | } | 530 | } |
532 | 531 | ||
533 | static int __init bfin_bf54x_probe(struct platform_device *pdev) | 532 | static int __devinit bfin_bf54x_probe(struct platform_device *pdev) |
534 | { | 533 | { |
535 | struct bfin_bf54xfb_info *info; | 534 | struct bfin_bf54xfb_info *info; |
536 | struct fb_info *fbinfo; | 535 | struct fb_info *fbinfo; |
@@ -626,14 +625,12 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev) | |||
626 | goto out3; | 625 | goto out3; |
627 | } | 626 | } |
628 | 627 | ||
629 | memset(info->fb_buffer, 0, fbinfo->fix.smem_len); | ||
630 | |||
631 | fbinfo->screen_base = (void *)info->fb_buffer; | 628 | fbinfo->screen_base = (void *)info->fb_buffer; |
632 | fbinfo->fix.smem_start = (int)info->fb_buffer; | 629 | fbinfo->fix.smem_start = (int)info->fb_buffer; |
633 | 630 | ||
634 | fbinfo->fbops = &bfin_bf54x_fb_ops; | 631 | fbinfo->fbops = &bfin_bf54x_fb_ops; |
635 | 632 | ||
636 | fbinfo->pseudo_palette = kmalloc(sizeof(u32) * 16, GFP_KERNEL); | 633 | fbinfo->pseudo_palette = kzalloc(sizeof(u32) * 16, GFP_KERNEL); |
637 | if (!fbinfo->pseudo_palette) { | 634 | if (!fbinfo->pseudo_palette) { |
638 | printk(KERN_ERR DRIVER_NAME | 635 | printk(KERN_ERR DRIVER_NAME |
639 | "Fail to allocate pseudo_palette\n"); | 636 | "Fail to allocate pseudo_palette\n"); |
@@ -642,8 +639,6 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev) | |||
642 | goto out4; | 639 | goto out4; |
643 | } | 640 | } |
644 | 641 | ||
645 | memset(fbinfo->pseudo_palette, 0, sizeof(u32) * 16); | ||
646 | |||
647 | if (fb_alloc_cmap(&fbinfo->cmap, BFIN_LCD_NBR_PALETTE_ENTRIES, 0) | 642 | if (fb_alloc_cmap(&fbinfo->cmap, BFIN_LCD_NBR_PALETTE_ENTRIES, 0) |
648 | < 0) { | 643 | < 0) { |
649 | printk(KERN_ERR DRIVER_NAME | 644 | printk(KERN_ERR DRIVER_NAME |
@@ -712,7 +707,7 @@ out1: | |||
712 | return ret; | 707 | return ret; |
713 | } | 708 | } |
714 | 709 | ||
715 | static int bfin_bf54x_remove(struct platform_device *pdev) | 710 | static int __devexit bfin_bf54x_remove(struct platform_device *pdev) |
716 | { | 711 | { |
717 | 712 | ||
718 | struct fb_info *fbinfo = platform_get_drvdata(pdev); | 713 | struct fb_info *fbinfo = platform_get_drvdata(pdev); |
@@ -781,7 +776,7 @@ static int bfin_bf54x_resume(struct platform_device *pdev) | |||
781 | 776 | ||
782 | static struct platform_driver bfin_bf54x_driver = { | 777 | static struct platform_driver bfin_bf54x_driver = { |
783 | .probe = bfin_bf54x_probe, | 778 | .probe = bfin_bf54x_probe, |
784 | .remove = bfin_bf54x_remove, | 779 | .remove = __devexit_p(bfin_bf54x_remove), |
785 | .suspend = bfin_bf54x_suspend, | 780 | .suspend = bfin_bf54x_suspend, |
786 | .resume = bfin_bf54x_resume, | 781 | .resume = bfin_bf54x_resume, |
787 | .driver = { | 782 | .driver = { |
@@ -790,7 +785,7 @@ static struct platform_driver bfin_bf54x_driver = { | |||
790 | }, | 785 | }, |
791 | }; | 786 | }; |
792 | 787 | ||
793 | static int __devinit bfin_bf54x_driver_init(void) | 788 | static int __init bfin_bf54x_driver_init(void) |
794 | { | 789 | { |
795 | return platform_driver_register(&bfin_bf54x_driver); | 790 | return platform_driver_register(&bfin_bf54x_driver); |
796 | } | 791 | } |