diff options
Diffstat (limited to 'drivers/uwb/est.c')
-rw-r--r-- | drivers/uwb/est.c | 38 |
1 files changed, 15 insertions, 23 deletions
diff --git a/drivers/uwb/est.c b/drivers/uwb/est.c index 3791cd95b63d..5fe566b7c845 100644 --- a/drivers/uwb/est.c +++ b/drivers/uwb/est.c | |||
@@ -363,22 +363,17 @@ ssize_t uwb_est_get_size(struct uwb_rc *uwb_rc, struct uwb_est *est, | |||
363 | 363 | ||
364 | size = -ENOENT; | 364 | size = -ENOENT; |
365 | if (event_low >= est->entries) { /* in range? */ | 365 | if (event_low >= est->entries) { /* in range? */ |
366 | if (printk_ratelimit()) | 366 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: event %u out of range\n", |
367 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: " | 367 | est, est->type_event_high, est->vendor, est->product, |
368 | "event %u out of range\n", | 368 | est->entries, event_low); |
369 | est, est->type_event_high, est->vendor, | ||
370 | est->product, est->entries, | ||
371 | event_low); | ||
372 | goto out; | 369 | goto out; |
373 | } | 370 | } |
374 | size = -ENOENT; | 371 | size = -ENOENT; |
375 | entry = &est->entry[event_low]; | 372 | entry = &est->entry[event_low]; |
376 | if (entry->size == 0 && entry->offset == 0) { /* unknown? */ | 373 | if (entry->size == 0 && entry->offset == 0) { /* unknown? */ |
377 | if (printk_ratelimit()) | 374 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: event %u unknown\n", |
378 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: " | 375 | est, est->type_event_high, est->vendor, est->product, |
379 | "event %u unknown\n", | 376 | est->entries, event_low); |
380 | est, est->type_event_high, est->vendor, | ||
381 | est->product, est->entries, event_low); | ||
382 | goto out; | 377 | goto out; |
383 | } | 378 | } |
384 | offset = entry->offset; /* extra fries with that? */ | 379 | offset = entry->offset; /* extra fries with that? */ |
@@ -396,11 +391,10 @@ ssize_t uwb_est_get_size(struct uwb_rc *uwb_rc, struct uwb_est *est, | |||
396 | default: BUG(); | 391 | default: BUG(); |
397 | } | 392 | } |
398 | if (offset + type_size > rceb_size) { | 393 | if (offset + type_size > rceb_size) { |
399 | if (printk_ratelimit()) | 394 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: " |
400 | dev_err(dev, "EST %p 0x%04x/%04x/%04x[%u]: " | 395 | "not enough data to read extra size\n", |
401 | "not enough data to read extra size\n", | 396 | est, est->type_event_high, est->vendor, |
402 | est, est->type_event_high, est->vendor, | 397 | est->product, est->entries); |
403 | est->product, est->entries); | ||
404 | goto out; | 398 | goto out; |
405 | } | 399 | } |
406 | size = entry->size; | 400 | size = entry->size; |
@@ -469,14 +463,12 @@ ssize_t uwb_est_find_size(struct uwb_rc *rc, const struct uwb_rceb *rceb, | |||
469 | if (size != -ENOENT) | 463 | if (size != -ENOENT) |
470 | goto out; | 464 | goto out; |
471 | } | 465 | } |
472 | /* FIXME: downgrade to _dbg() */ | 466 | dev_dbg(dev, "event 0x%02x/%04x/%02x: no handlers available; " |
473 | if (printk_ratelimit()) | ||
474 | dev_err(dev, "event 0x%02x/%04x/%02x: no handlers available; " | ||
475 | "RCEB %02x %02x %02x %02x\n", | 467 | "RCEB %02x %02x %02x %02x\n", |
476 | (unsigned) rceb->bEventType, | 468 | (unsigned) rceb->bEventType, |
477 | (unsigned) le16_to_cpu(rceb->wEvent), | 469 | (unsigned) le16_to_cpu(rceb->wEvent), |
478 | (unsigned) rceb->bEventContext, | 470 | (unsigned) rceb->bEventContext, |
479 | ptr[0], ptr[1], ptr[2], ptr[3]); | 471 | ptr[0], ptr[1], ptr[2], ptr[3]); |
480 | size = -ENOENT; | 472 | size = -ENOENT; |
481 | out: | 473 | out: |
482 | read_unlock_irqrestore(&uwb_est_lock, flags); | 474 | read_unlock_irqrestore(&uwb_est_lock, flags); |