3 files changed, 25 insertions, 35 deletions

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 8586817698ad..c51f8e9312e0 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -585,9 +585,6 @@ static int usb_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
         struct usb_device *usb_dev;
 
-        if (!dev)
-                return -ENODEV;
-
         /* driver is often null here; dev_dbg() would oops */
         pr_debug ("usb %s: uevent\n", dev->bus_id);
 
@@ -631,14 +628,6 @@ static int usb_uevent(struct device *dev, struct kobj_uevent_env *env)
                            usb_dev->descriptor.bDeviceProtocol))
                 return -ENOMEM;
 
-        if (add_uevent_var(env, "BUSNUM=%03d",
-                           usb_dev->bus->busnum))
-                return -ENOMEM;
-
-        if (add_uevent_var(env, "DEVNUM=%03d",
-                           usb_dev->devnum))
-                return -ENOMEM;
-
         return 0;
 }
 
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 40fd39de5bf9..fcd40ecbeecc 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -1346,34 +1346,10 @@ static int usb_if_uevent(struct device *dev, struct kobj_uevent_env *env)
         struct usb_interface *intf;
         struct usb_host_interface *alt;
 
-        if (!dev)
-                return -ENODEV;
-
-        /* driver is often null here; dev_dbg() would oops */
-        pr_debug ("usb %s: uevent\n", dev->bus_id);
-
         intf = to_usb_interface(dev);
         usb_dev = interface_to_usbdev(intf);
         alt = intf->cur_altsetting;
 
-#ifdef CONFIG_USB_DEVICEFS
-        if (add_uevent_var(env, "DEVICE=/proc/bus/usb/%03d/%03d",
-                           usb_dev->bus->busnum, usb_dev->devnum))
-                return -ENOMEM;
-#endif
-
-        if (add_uevent_var(env, "PRODUCT=%x/%x/%x",
-                           le16_to_cpu(usb_dev->descriptor.idVendor),
-                           le16_to_cpu(usb_dev->descriptor.idProduct),
-                           le16_to_cpu(usb_dev->descriptor.bcdDevice)))
-                return -ENOMEM;
-
-        if (add_uevent_var(env, "TYPE=%d/%d/%d",
-                           usb_dev->descriptor.bDeviceClass,
-                           usb_dev->descriptor.bDeviceSubClass,
-                           usb_dev->descriptor.bDeviceProtocol))
-                return -ENOMEM;
-
         if (add_uevent_var(env, "INTERFACE=%d/%d/%d",
                    alt->desc.bInterfaceClass,
                    alt->desc.bInterfaceSubClass,
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index c4a6f1095b8b..8f142370103d 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -192,9 +192,34 @@ static void usb_release_dev(struct device *dev)
         kfree(udev);
 }
 
+#ifdef  CONFIG_HOTPLUG
+static int usb_dev_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+        struct usb_device *usb_dev;
+
+        usb_dev = to_usb_device(dev);
+
+        if (add_uevent_var(env, "BUSNUM=%03d", usb_dev->bus->busnum))
+                return -ENOMEM;
+
+        if (add_uevent_var(env, "DEVNUM=%03d", usb_dev->devnum))
+                return -ENOMEM;
+
+        return 0;
+}
+
+#else
+
+static int usb_dev_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+        return -ENODEV;
+}
+#endif  /* CONFIG_HOTPLUG */
+
 struct device_type usb_device_type = {
         .name =         "usb_device",
         .release =      usb_release_dev,
+        .uevent =       usb_dev_uevent,
 };
 
 #ifdef  CONFIG_PM