1 files changed, 299 insertions, 219 deletions

diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index f07e8a4c1f3d..3a9d14384a43 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -12,29 +12,31 @@
  *      the Free Software Foundation; either version 2 of the License, or
  *      (at your option) any later version.
  *
- * See Documentation/usb/usb-serial.txt for more information on using this driver
+ * See Documentation/usb/usb-serial.txt for more information on using this
+ * driver
  *
  * (10/09/2002) Stuart MacDonald (stuartm@connecttech.com)
  *      Upgrade to full working driver
  *
  * (05/30/2001) gkh
- *      switched from using spinlock to a semaphore, which fixes lots of problems.
+ *      switched from using spinlock to a semaphore, which fixes lots of
+ *      problems.
  *
  * (04/08/2001) gb
  *      Identify version on module load.
- * 
+ *
  * 2001_Mar_19 gkh
- *      Fixed MOD_INC and MOD_DEC logic, the ability to open a port more 
+ *      Fixed MOD_INC and MOD_DEC logic, the ability to open a port more
  *      than once, and the got the proper usb_device_id table entries so
  *      the driver works again.
  *
  * (11/01/2000) Adam J. Richter
  *      usb_device_id table support
- * 
+ *
  * (10/05/2000) gkh
  *      Fixed bug with urb->dev not being set properly, now that the usb
  *      core needs it.
- * 
+ *
  * (10/03/2000) smd
  *      firmware is improved to guard against crap sent to device
  *      firmware now replies CMD_FAILURE on bad things
@@ -52,9 +54,9 @@
  *      Fixed bug with port->minor that was found by Al Borchers
  *
  * (07/04/2000) gkh
- *      Added support for port settings. Baud rate can now be changed. Line signals
- *      are not transferred to and from the tty layer yet, but things seem to be 
- *      working well now.
+ *      Added support for port settings. Baud rate can now be changed. Line
+ *      signals are not transferred to and from the tty layer yet, but things
+ *      seem to be working well now.
  *
  * (05/04/2000) gkh
  *      First cut at open and close commands. Data can flow through the ports at
@@ -62,7 +64,7 @@
  *
  * (03/26/2000) gkh
  *      Split driver up into device specific pieces.
- * 
+ *
  */
 
 #include <linux/kernel.h>
@@ -75,13 +77,14 @@
 #include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/mutex.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <asm/termbits.h>
 #include <linux/usb.h>
 #include <linux/serial_reg.h>
 #include <linux/serial.h>
 #include <linux/usb/serial.h>
-#include "whiteheat_fw.h"               /* firmware for the ConnectTech WhiteHEAT device */
+#include <linux/firmware.h>
+#include <linux/ihex.h>
 #include "whiteheat.h"                  /* WhiteHEAT specific commands */
 
 static int debug;
@@ -124,7 +127,7 @@ static struct usb_device_id id_table_combined [] = {
         { }                                             /* Terminating entry */
 };
 
-MODULE_DEVICE_TABLE (usb, id_table_combined);
+MODULE_DEVICE_TABLE(usb, id_table_combined);
 
 static struct usb_driver whiteheat_driver = {
         .name =         "whiteheat",
@@ -135,26 +138,34 @@ static struct usb_driver whiteheat_driver = {
 };
 
 /* function prototypes for the Connect Tech WhiteHEAT prerenumeration device */
-static int  whiteheat_firmware_download (struct usb_serial *serial, const struct usb_device_id *id);
-static int  whiteheat_firmware_attach   (struct usb_serial *serial);
+static int  whiteheat_firmware_download(struct usb_serial *serial,
+                                        const struct usb_device_id *id);
+static int  whiteheat_firmware_attach(struct usb_serial *serial);
 
 /* function prototypes for the Connect Tech WhiteHEAT serial converter */
-static int  whiteheat_attach            (struct usb_serial *serial);
-static void whiteheat_shutdown          (struct usb_serial *serial);
-static int  whiteheat_open              (struct usb_serial_port *port, struct file *filp);
-static void whiteheat_close             (struct usb_serial_port *port, struct file *filp);
-static int  whiteheat_write             (struct usb_serial_port *port, const unsigned char *buf, int count);
-static int  whiteheat_write_room        (struct usb_serial_port *port);
-static int  whiteheat_ioctl             (struct usb_serial_port *port, struct file * file, unsigned int cmd, unsigned long arg);
-static void whiteheat_set_termios       (struct usb_serial_port *port, struct ktermios * old);
-static int  whiteheat_tiocmget          (struct usb_serial_port *port, struct file *file);
-static int  whiteheat_tiocmset          (struct usb_serial_port *port, struct file *file, unsigned int set, unsigned int clear);
-static void whiteheat_break_ctl         (struct usb_serial_port *port, int break_state);
-static int  whiteheat_chars_in_buffer   (struct usb_serial_port *port);
-static void whiteheat_throttle          (struct usb_serial_port *port);
-static void whiteheat_unthrottle        (struct usb_serial_port *port);
-static void whiteheat_read_callback     (struct urb *urb);
-static void whiteheat_write_callback    (struct urb *urb);
+static int  whiteheat_attach(struct usb_serial *serial);
+static void whiteheat_shutdown(struct usb_serial *serial);
+static int  whiteheat_open(struct tty_struct *tty,
+                        struct usb_serial_port *port, struct file *filp);
+static void whiteheat_close(struct tty_struct *tty,
+                        struct usb_serial_port *port, struct file *filp);
+static int  whiteheat_write(struct tty_struct *tty,
+                        struct usb_serial_port *port,
+                        const unsigned char *buf, int count);
+static int  whiteheat_write_room(struct tty_struct *tty);
+static int  whiteheat_ioctl(struct tty_struct *tty, struct file *file,
+                        unsigned int cmd, unsigned long arg);
+static void whiteheat_set_termios(struct tty_struct *tty,
+                        struct usb_serial_port *port, struct ktermios *old);
+static int  whiteheat_tiocmget(struct tty_struct *tty, struct file *file);
+static int  whiteheat_tiocmset(struct tty_struct *tty, struct file *file,
+                        unsigned int set, unsigned int clear);
+static void whiteheat_break_ctl(struct tty_struct *tty, int break_state);
+static int  whiteheat_chars_in_buffer(struct tty_struct *tty);
+static void whiteheat_throttle(struct tty_struct *tty);
+static void whiteheat_unthrottle(struct tty_struct *tty);
+static void whiteheat_read_callback(struct urb *urb);
+static void whiteheat_write_callback(struct urb *urb);
 
 static struct usb_serial_driver whiteheat_fake_device = {
         .driver = {
@@ -201,7 +212,9 @@ struct whiteheat_command_private {
         struct mutex            mutex;
         __u8                    port_running;
         __u8                    command_finished;
-        wait_queue_head_t       wait_command;   /* for handling sleeping while waiting for a command to finish */
+        wait_queue_head_t       wait_command; /* for handling sleeping whilst
+                                                 waiting for a command to
+                                                 finish */
         __u8                    result_buffer[64];
 };
 
@@ -238,14 +251,16 @@ static void command_port_write_callback(struct urb *urb);
 static void command_port_read_callback(struct urb *urb);
 
 static int start_port_read(struct usb_serial_port *port);
-static struct whiteheat_urb_wrap *urb_to_wrap(struct urb *urb, struct list_head *head);
+static struct whiteheat_urb_wrap *urb_to_wrap(struct urb *urb,
+                                                struct list_head *head);
 static struct list_head *list_first(struct list_head *head);
 static void rx_data_softint(struct work_struct *work);
 
-static int firm_send_command(struct usb_serial_port *port, __u8 command, __u8 *data, __u8 datasize);
+static int firm_send_command(struct usb_serial_port *port, __u8 command,
+                                                __u8 *data, __u8 datasize);
 static int firm_open(struct usb_serial_port *port);
 static int firm_close(struct usb_serial_port *port);
-static int firm_setup_port(struct usb_serial_port *port);
+static int firm_setup_port(struct tty_struct *tty);
 static int firm_set_rts(struct usb_serial_port *port, __u8 onoff);
 static int firm_set_dtr(struct usb_serial_port *port, __u8 onoff);
 static int firm_set_break(struct usb_serial_port *port, __u8 onoff);
@@ -277,65 +292,85 @@ static int firm_report_tx_done(struct usb_serial_port *port);
  - device renumerated itself and comes up as new device id with all
    firmware download completed.
 */
-static int whiteheat_firmware_download (struct usb_serial *serial, const struct usb_device_id *id)
+static int whiteheat_firmware_download(struct usb_serial *serial,
+                                        const struct usb_device_id *id)
 {
-        int response;
-        const struct whiteheat_hex_record *record;
-        
+        int response, ret = -ENOENT;
+        const struct firmware *loader_fw = NULL, *firmware_fw = NULL;
+        const struct ihex_binrec *record;
+
         dbg("%s", __func__);
-        
+
+        if (request_ihex_firmware(&firmware_fw, "whiteheat.fw",
+                                  &serial->dev->dev)) {
+                err("%s - request \"whiteheat.fw\" failed", __func__);
+                goto out;
+        }
+        if (request_ihex_firmware(&loader_fw, "whiteheat_loader.fw",
+                             &serial->dev->dev)) {
+                err("%s - request \"whiteheat_loader.fw\" failed", __func__);
+                goto out;
+        }
+        ret = 0;
         response = ezusb_set_reset (serial, 1);
 
-        record = &whiteheat_loader[0];
-        while (record->address != 0xffff) {
-                response = ezusb_writememory (serial, record->address, 
-                                (unsigned char *)record->data, record->data_size, 0xa0);
+        record = (const struct ihex_binrec *)loader_fw->data;
+        while (record) {
+                response = ezusb_writememory (serial, be32_to_cpu(record->addr),
+                                              (unsigned char *)record->data,
+                                              be16_to_cpu(record->len), 0xa0);
                 if (response < 0) {
                         err("%s - ezusb_writememory failed for loader (%d %04X %p %d)",
-                                __func__, response, record->address, record->data, record->data_size);
+                            __func__, response, be32_to_cpu(record->addr),
+                            record->data, be16_to_cpu(record->len));
                         break;
                 }
-                ++record;
+                record = ihex_next_binrec(record);
         }
 
-        response = ezusb_set_reset (serial, 0);
+        response = ezusb_set_reset(serial, 0);
 
-        record = &whiteheat_firmware[0];
-        while (record->address < 0x1b40) {
-                ++record;
-        }
-        while (record->address != 0xffff) {
-                response = ezusb_writememory (serial, record->address, 
-                                (unsigned char *)record->data, record->data_size, 0xa3);
+        record = (const struct ihex_binrec *)firmware_fw->data;
+        while (record && be32_to_cpu(record->addr) < 0x1b40)
+                record = ihex_next_binrec(record);
+        while (record) {
+                response = ezusb_writememory (serial, be32_to_cpu(record->addr),
+                                              (unsigned char *)record->data,
+                                              be16_to_cpu(record->len), 0xa3);
                 if (response < 0) {
                         err("%s - ezusb_writememory failed for first firmware step (%d %04X %p %d)", 
-                                __func__, response, record->address, record->data, record->data_size);
+                            __func__, response, be32_to_cpu(record->addr),
+                            record->data, be16_to_cpu(record->len));
                         break;
                 }
                 ++record;
         }
-        
-        response = ezusb_set_reset (serial, 1);
 
-        record = &whiteheat_firmware[0];
-        while (record->address < 0x1b40) {
-                response = ezusb_writememory (serial, record->address, 
-                                (unsigned char *)record->data, record->data_size, 0xa0);
+        response = ezusb_set_reset(serial, 1);
+
+        record = (const struct ihex_binrec *)firmware_fw->data;
+        while (record && be32_to_cpu(record->addr) < 0x1b40) {
+                response = ezusb_writememory (serial, be32_to_cpu(record->addr),
+                                              (unsigned char *)record->data,
+                                              be16_to_cpu(record->len), 0xa0);
                 if (response < 0) {
                         err("%s - ezusb_writememory failed for second firmware step (%d %04X %p %d)", 
-                                __func__, response, record->address, record->data, record->data_size);
+                            __func__, response, be32_to_cpu(record->addr),
+                            record->data, be16_to_cpu(record->len));
                         break;
                 }
                 ++record;
         }
-
+        ret = 0;
         response = ezusb_set_reset (serial, 0);
-
-        return 0;
+ out:
+        release_firmware(loader_fw);
+        release_firmware(firmware_fw);
+        return ret;
 }
 
 
-static int whiteheat_firmware_attach (struct usb_serial *serial)
+static int whiteheat_firmware_attach(struct usb_serial *serial)
 {
         /* We want this device to fail to have a driver assigned to it */
         return 1;
@@ -345,7 +380,7 @@ static int whiteheat_firmware_attach (struct usb_serial *serial)
 /*****************************************************************************
  * Connect Tech's White Heat serial driver functions
  *****************************************************************************/
-static int whiteheat_attach (struct usb_serial *serial)
+static int whiteheat_attach(struct usb_serial *serial)
 {
         struct usb_serial_port *command_port;
         struct whiteheat_command_private *command_info;
@@ -366,43 +401,52 @@ static int whiteheat_attach (struct usb_serial *serial)
 
         command_port = serial->port[COMMAND_PORT];
 
-        pipe = usb_sndbulkpipe (serial->dev, command_port->bulk_out_endpointAddress);
+        pipe = usb_sndbulkpipe(serial->dev,
+                        command_port->bulk_out_endpointAddress);
         command = kmalloc(2, GFP_KERNEL);
         if (!command)
                 goto no_command_buffer;
         command[0] = WHITEHEAT_GET_HW_INFO;
         command[1] = 0;
-        
+
         result = kmalloc(sizeof(*hw_info) + 1, GFP_KERNEL);
         if (!result)
                 goto no_result_buffer;
         /*
          * When the module is reloaded the firmware is still there and
          * the endpoints are still in the usb core unchanged. This is the
-         * unlinking bug in disguise. Same for the call below.
-         */
+         * unlinking bug in disguise. Same for the call below.
+         */
         usb_clear_halt(serial->dev, pipe);
-        ret = usb_bulk_msg (serial->dev, pipe, command, 2, &alen, COMMAND_TIMEOUT_MS);
+        ret = usb_bulk_msg(serial->dev, pipe, command, 2,
+                                                &alen, COMMAND_TIMEOUT_MS);
         if (ret) {
-                err("%s: Couldn't send command [%d]", serial->type->description, ret);
+                err("%s: Couldn't send command [%d]",
+                                serial->type->description, ret);
                 goto no_firmware;
         } else if (alen != 2) {
-                err("%s: Send command incomplete [%d]", serial->type->description, alen);
+                err("%s: Send command incomplete [%d]",
+                                serial->type->description, alen);
                 goto no_firmware;
         }
 
-        pipe = usb_rcvbulkpipe (serial->dev, command_port->bulk_in_endpointAddress);
+        pipe = usb_rcvbulkpipe(serial->dev,
+                                command_port->bulk_in_endpointAddress);
         /* See the comment on the usb_clear_halt() above */
         usb_clear_halt(serial->dev, pipe);
-        ret = usb_bulk_msg (serial->dev, pipe, result, sizeof(*hw_info) + 1, &alen, COMMAND_TIMEOUT_MS);
+        ret = usb_bulk_msg(serial->dev, pipe, result,
+                        sizeof(*hw_info) + 1, &alen, COMMAND_TIMEOUT_MS);
         if (ret) {
-                err("%s: Couldn't get results [%d]", serial->type->description, ret);
+                err("%s: Couldn't get results [%d]",
+                                serial->type->description, ret);
                 goto no_firmware;
         } else if (alen != sizeof(*hw_info) + 1) {
-                err("%s: Get results incomplete [%d]", serial->type->description, alen);
+                err("%s: Get results incomplete [%d]",
+                                serial->type->description, alen);
                 goto no_firmware;
         } else if (result[0] != command[0]) {
-                err("%s: Command failed [%d]", serial->type->description, result[0]);
+                err("%s: Command failed [%d]",
+                                serial->type->description, result[0]);
                 goto no_firmware;
         }
 
@@ -416,7 +460,8 @@ static int whiteheat_attach (struct usb_serial *serial)
 
                 info = kmalloc(sizeof(struct whiteheat_private), GFP_KERNEL);
                 if (info == NULL) {
-                        err("%s: Out of memory for port structures\n", serial->type->description);
+                        err("%s: Out of memory for port structures\n",
+                                        serial->type->description);
                         goto no_private;
                 }
 
@@ -486,9 +531,11 @@ static int whiteheat_attach (struct usb_serial *serial)
                 usb_set_serial_port_data(port, info);
         }
 
-        command_info = kmalloc(sizeof(struct whiteheat_command_private), GFP_KERNEL);
+        command_info = kmalloc(sizeof(struct whiteheat_command_private),
+                                                                GFP_KERNEL);
         if (command_info == NULL) {
-                err("%s: Out of memory for port structures\n", serial->type->description);
+                err("%s: Out of memory for port structures\n",
+                                        serial->type->description);
                 goto no_command_private;
         }
 
@@ -505,9 +552,12 @@ static int whiteheat_attach (struct usb_serial *serial)
 
 no_firmware:
         /* Firmware likely not running */
-        err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description);
-        err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description);
-        err("%s: please contact support@connecttech.com\n", serial->type->description);
+        err("%s: Unable to retrieve firmware version, try replugging\n",
+                                        serial->type->description);
+        err("%s: If the firmware is not running (status led not blinking)\n",
+                                        serial->type->description);
+        err("%s: please contact support@connecttech.com\n",
+                                        serial->type->description);
         kfree(result);
         return -ENODEV;
 
@@ -550,7 +600,7 @@ no_command_buffer:
 }
 
 
-static void whiteheat_shutdown (struct usb_serial *serial)
+static void whiteheat_shutdown(struct usb_serial *serial)
 {
         struct usb_serial_port *command_port;
         struct usb_serial_port *port;
@@ -565,7 +615,7 @@ static void whiteheat_shutdown (struct usb_serial *serial)
 
         /* free up our private data for our command port */
         command_port = serial->port[COMMAND_PORT];
-        kfree (usb_get_serial_port_data(command_port));
+        kfree(usb_get_serial_port_data(command_port));
 
         for (i = 0; i < serial->num_ports; i++) {
                 port = serial->port[i];
@@ -592,11 +642,10 @@ static void whiteheat_shutdown (struct usb_serial *serial)
         return;
 }
 
-
-static int whiteheat_open (struct usb_serial_port *port, struct file *filp)
+static int whiteheat_open(struct tty_struct *tty,
+                        struct usb_serial_port *port, struct file *filp)
 {
         int             retval = 0;
-        struct ktermios old_term;
 
         dbg("%s - port %d", __func__, port->number);
 
@@ -604,7 +653,8 @@ static int whiteheat_open (struct usb_serial_port *port, struct file *filp)
         if (retval)
                 goto exit;
 
-        port->tty->low_latency = 1;
+        if (tty)
+                tty->low_latency = 1;
 
         /* send an open port command */
         retval = firm_open(port);
@@ -620,9 +670,8 @@ static int whiteheat_open (struct usb_serial_port *port, struct file *filp)
                 goto exit;
         }
 
-        old_term.c_cflag = ~port->tty->termios->c_cflag;
-        old_term.c_iflag = ~port->tty->termios->c_iflag;
-        whiteheat_set_termios(port, &old_term);
+        if (tty)
+                firm_setup_port(tty);
 
         /* Work around HCD bugs */
         usb_clear_halt(port->serial->dev, port->read_urb->pipe);
@@ -631,7 +680,8 @@ static int whiteheat_open (struct usb_serial_port *port, struct file *filp)
         /* Start reading from the device */
         retval = start_port_read(port);
         if (retval) {
-                err("%s - failed submitting read urb, error %d", __func__, retval);
+                err("%s - failed submitting read urb, error %d",
+                                __func__, retval);
                 firm_close(port);
                 stop_command_port(port->serial);
                 goto exit;
@@ -643,7 +693,8 @@ exit:
 }
 
 
-static void whiteheat_close(struct usb_serial_port *port, struct file * filp)
+static void whiteheat_close(struct tty_struct *tty,
+                        struct usb_serial_port *port, struct file *filp)
 {
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         struct whiteheat_urb_wrap *wrap;
@@ -661,7 +712,7 @@ static void whiteheat_close(struct usb_serial_port *port, struct file * filp)
         }
         mutex_unlock(&port->serial->disc_mutex);
 
-        port->tty->closing = 1;
+        tty->closing = 1;
 
 /*
  * Not currently in use; tty_wait_until_sent() calls
@@ -669,12 +720,12 @@ static void whiteheat_close(struct usb_serial_port *port, struct file * filp)
  * acquisition. This should be fixed at some point. Greg's been
  * notified.
         if ((filp->f_flags & (O_NDELAY | O_NONBLOCK)) == 0) {
-                tty_wait_until_sent(port->tty, CLOSING_DELAY);
+                tty_wait_until_sent(tty, CLOSING_DELAY);
         }
 */
 
-        tty_driver_flush_buffer(port->tty);
-        tty_ldisc_flush(port->tty);
+        tty_driver_flush_buffer(tty);
+        tty_ldisc_flush(tty);
 
         firm_report_tx_done(port);
 
@@ -708,11 +759,12 @@ static void whiteheat_close(struct usb_serial_port *port, struct file * filp)
 
         stop_command_port(port->serial);
 
-        port->tty->closing = 0;
+        tty->closing = 0;
 }
 
 
-static int whiteheat_write(struct usb_serial_port *port, const unsigned char *buf, int count)
+static int whiteheat_write(struct tty_struct *tty,
+        struct usb_serial_port *port, const unsigned char *buf, int count)
 {
         struct usb_serial *serial = port->serial;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
@@ -743,16 +795,19 @@ static int whiteheat_write(struct usb_serial_port *port, const unsigned char *bu
 
                 wrap = list_entry(tmp, struct whiteheat_urb_wrap, list);
                 urb = wrap->urb;
-                bytes = (count > port->bulk_out_size) ? port->bulk_out_size : count;
-                memcpy (urb->transfer_buffer, buf + sent, bytes);
+                bytes = (count > port->bulk_out_size) ?
+                                        port->bulk_out_size : count;
+                memcpy(urb->transfer_buffer, buf + sent, bytes);
 
-                usb_serial_debug_data(debug, &port->dev, __func__, bytes, urb->transfer_buffer);
+                usb_serial_debug_data(debug, &port->dev,
+                                __func__, bytes, urb->transfer_buffer);
 
                 urb->dev = serial->dev;
                 urb->transfer_buffer_length = bytes;
                 result = usb_submit_urb(urb, GFP_ATOMIC);
                 if (result) {
-                        err("%s - failed submitting write urb, error %d", __func__, result);
+                        err("%s - failed submitting write urb, error %d",
+                                                        __func__, result);
                         sent = result;
                         spin_lock_irqsave(&info->lock, flags);
                         list_add(tmp, &info->tx_urbs_free);
@@ -770,16 +825,16 @@ static int whiteheat_write(struct usb_serial_port *port, const unsigned char *bu
         return sent;
 }
 
-
-static int whiteheat_write_room(struct usb_serial_port *port)
+static int whiteheat_write_room(struct tty_struct *tty)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         struct list_head *tmp;
         int room = 0;
         unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
-        
+
         spin_lock_irqsave(&info->lock, flags);
         list_for_each(tmp, &info->tx_urbs_free)
                 room++;
@@ -790,9 +845,9 @@ static int whiteheat_write_room(struct usb_serial_port *port)
         return (room);
 }
 
-
-static int whiteheat_tiocmget (struct usb_serial_port *port, struct file *file)
+static int whiteheat_tiocmget(struct tty_struct *tty, struct file *file)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         unsigned int modem_signals = 0;
 
@@ -807,10 +862,10 @@ static int whiteheat_tiocmget (struct usb_serial_port *port, struct file *file)
         return modem_signals;
 }
 
-
-static int whiteheat_tiocmset (struct usb_serial_port *port, struct file *file,
+static int whiteheat_tiocmset(struct tty_struct *tty, struct file *file,
                                unsigned int set, unsigned int clear)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
 
         dbg("%s - port %d", __func__, port->number);
@@ -831,65 +886,55 @@ static int whiteheat_tiocmset (struct usb_serial_port *port, struct file *file,
 }
 
 
-static int whiteheat_ioctl (struct usb_serial_port *port, struct file * file, unsigned int cmd, unsigned long arg)
+static int whiteheat_ioctl(struct tty_struct *tty, struct file *file,
+                                        unsigned int cmd, unsigned long arg)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct serial_struct serstruct;
         void __user *user_arg = (void __user *)arg;
 
         dbg("%s - port %d, cmd 0x%.4x", __func__, port->number, cmd);
 
         switch (cmd) {
-                case TIOCGSERIAL:
-                        memset(&serstruct, 0, sizeof(serstruct));
-                        serstruct.type = PORT_16654;
-                        serstruct.line = port->serial->minor;
-                        serstruct.port = port->number;
-                        serstruct.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ;
-                        serstruct.xmit_fifo_size = port->bulk_out_size;
-                        serstruct.custom_divisor = 0;
-                        serstruct.baud_base = 460800;
-                        serstruct.close_delay = CLOSING_DELAY;
-                        serstruct.closing_wait = CLOSING_DELAY;
-
-                        if (copy_to_user(user_arg, &serstruct, sizeof(serstruct)))
-                                return -EFAULT;
-
-                        break;
-
-                case TIOCSSERIAL:
-                        if (copy_from_user(&serstruct, user_arg, sizeof(serstruct)))
-                                return -EFAULT;
-
-                        /*
-                         * For now this is ignored. dip sets the ASYNC_[V]HI flags
-                         * but this isn't used by us at all. Maybe someone somewhere
-                         * will need the custom_divisor setting.
-                         */
-
-                        break;
-
-                default:
-                        break;
+        case TIOCGSERIAL:
+                memset(&serstruct, 0, sizeof(serstruct));
+                serstruct.type = PORT_16654;
+                serstruct.line = port->serial->minor;
+                serstruct.port = port->number;
+                serstruct.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ;
+                serstruct.xmit_fifo_size = port->bulk_out_size;
+                serstruct.custom_divisor = 0;
+                serstruct.baud_base = 460800;
+                serstruct.close_delay = CLOSING_DELAY;
+                serstruct.closing_wait = CLOSING_DELAY;
+
+                if (copy_to_user(user_arg, &serstruct, sizeof(serstruct)))
+                        return -EFAULT;
+                break;
+        default:
+                break;
         }
 
         return -ENOIOCTLCMD;
 }
 
 
-static void whiteheat_set_termios(struct usb_serial_port *port, struct ktermios *old_termios)
+static void whiteheat_set_termios(struct tty_struct *tty,
+        struct usb_serial_port *port, struct ktermios *old_termios)
 {
-        dbg("%s -port %d", __func__, port->number);
-        firm_setup_port(port);
+        firm_setup_port(tty);
 }
 
-
-static void whiteheat_break_ctl(struct usb_serial_port *port, int break_state) {
+static void whiteheat_break_ctl(struct tty_struct *tty, int break_state)
+{
+        struct usb_serial_port *port = tty->driver_data;
         firm_set_break(port, break_state);
 }
 
 
-static int whiteheat_chars_in_buffer(struct usb_serial_port *port)
+static int whiteheat_chars_in_buffer(struct tty_struct *tty)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         struct list_head *tmp;
         struct whiteheat_urb_wrap *wrap;
@@ -905,13 +950,14 @@ static int whiteheat_chars_in_buffer(struct usb_serial_port *port)
         }
         spin_unlock_irqrestore(&info->lock, flags);
 
-        dbg ("%s - returns %d", __func__, chars);
+        dbg("%s - returns %d", __func__, chars);
         return chars;
 }
 
 
-static void whiteheat_throttle (struct usb_serial_port *port)
+static void whiteheat_throttle(struct tty_struct *tty)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         unsigned long flags;
 
@@ -925,8 +971,9 @@ static void whiteheat_throttle (struct usb_serial_port *port)
 }
 
 
-static void whiteheat_unthrottle (struct usb_serial_port *port)
+static void whiteheat_unthrottle(struct tty_struct *tty)
 {
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         int actually_throttled;
         unsigned long flags;
@@ -973,7 +1020,7 @@ static void command_port_read_callback(struct urb *urb)
 
         command_info = usb_get_serial_port_data(command_port);
         if (!command_info) {
-                dbg ("%s - command_info is NULL, exiting.", __func__);
+                dbg("%s - command_info is NULL, exiting.", __func__);
                 return;
         }
         if (status) {
@@ -984,7 +1031,8 @@ static void command_port_read_callback(struct urb *urb)
                 return;
         }
 
-        usb_serial_debug_data(debug, &command_port->dev, __func__, urb->actual_length, data);
+        usb_serial_debug_data(debug, &command_port->dev,
+                                __func__, urb->actual_length, data);
 
         if (data[0] == WHITEHEAT_CMD_COMPLETE) {
                 command_info->command_finished = WHITEHEAT_CMD_COMPLETE;
@@ -993,21 +1041,23 @@ static void command_port_read_callback(struct urb *urb)
                 command_info->command_finished = WHITEHEAT_CMD_FAILURE;
                 wake_up(&command_info->wait_command);
         } else if (data[0] == WHITEHEAT_EVENT) {
-                /* These are unsolicited reports from the firmware, hence no waiting command to wakeup */
+                /* These are unsolicited reports from the firmware, hence no
+                   waiting command to wakeup */
                 dbg("%s - event received", __func__);
         } else if (data[0] == WHITEHEAT_GET_DTR_RTS) {
-                memcpy(command_info->result_buffer, &data[1], urb->actual_length - 1);
+                memcpy(command_info->result_buffer, &data[1],
+                                                urb->actual_length - 1);
                 command_info->command_finished = WHITEHEAT_CMD_COMPLETE;
                 wake_up(&command_info->wait_command);
-        } else {
+        } else
                 dbg("%s - bad reply from firmware", __func__);
-        }
-        
+
         /* Continue trying to always read */
         command_port->read_urb->dev = command_port->serial->dev;
         result = usb_submit_urb(command_port->read_urb, GFP_ATOMIC);
         if (result)
-                dbg("%s - failed resubmitting read urb, error %d", __func__, result);
+                dbg("%s - failed resubmitting read urb, error %d",
+                        __func__, result);
 }
 
 
@@ -1040,7 +1090,8 @@ static void whiteheat_read_callback(struct urb *urb)
                 return;
         }
 
-        usb_serial_debug_data(debug, &port->dev, __func__, urb->actual_length, data);
+        usb_serial_debug_data(debug, &port->dev,
+                                __func__, urb->actual_length, data);
 
         spin_lock(&info->lock);
         list_add_tail(&wrap->list, &info->rx_urb_q);
@@ -1087,7 +1138,8 @@ static void whiteheat_write_callback(struct urb *urb)
 /*****************************************************************************
  * Connect Tech's White Heat firmware interface
  *****************************************************************************/
-static int firm_send_command(struct usb_serial_port *port, __u8 command, __u8 *data, __u8 datasize)
+static int firm_send_command(struct usb_serial_port *port, __u8 command,
+                                                __u8 *data, __u8 datasize)
 {
         struct usb_serial_port *command_port;
         struct whiteheat_command_private *command_info;
@@ -1102,13 +1154,13 @@ static int firm_send_command(struct usb_serial_port *port, __u8 command, __u8 *d
         command_info = usb_get_serial_port_data(command_port);
         mutex_lock(&command_info->mutex);
         command_info->command_finished = false;
-        
+
         transfer_buffer = (__u8 *)command_port->write_urb->transfer_buffer;
         transfer_buffer[0] = command;
-        memcpy (&transfer_buffer[1], data, datasize);
+        memcpy(&transfer_buffer[1], data, datasize);
         command_port->write_urb->transfer_buffer_length = datasize + 1;
         command_port->write_urb->dev = port->serial->dev;
-        retval = usb_submit_urb (command_port->write_urb, GFP_NOIO);
+        retval = usb_submit_urb(command_port->write_urb, GFP_NOIO);
         if (retval) {
                 dbg("%s - submit urb failed", __func__);
                 goto exit;
@@ -1135,51 +1187,57 @@ static int firm_send_command(struct usb_serial_port *port, __u8 command, __u8 *d
         if (command_info->command_finished == WHITEHEAT_CMD_COMPLETE) {
                 dbg("%s - command completed.", __func__);
                 switch (command) {
-                        case WHITEHEAT_GET_DTR_RTS:
-                                info = usb_get_serial_port_data(port);
-                                memcpy(&info->mcr, command_info->result_buffer, sizeof(struct whiteheat_dr_info));
+                case WHITEHEAT_GET_DTR_RTS:
+                        info = usb_get_serial_port_data(port);
+                        memcpy(&info->mcr, command_info->result_buffer,
+                                        sizeof(struct whiteheat_dr_info));
                                 break;
                 }
         }
-
 exit:
         mutex_unlock(&command_info->mutex);
         return retval;
 }
 
 
-static int firm_open(struct usb_serial_port *port) {
+static int firm_open(struct usb_serial_port *port)
+{
         struct whiteheat_simple open_command;
 
         open_command.port = port->number - port->serial->minor + 1;
-        return firm_send_command(port, WHITEHEAT_OPEN, (__u8 *)&open_command, sizeof(open_command));
+        return firm_send_command(port, WHITEHEAT_OPEN,
+                (__u8 *)&open_command, sizeof(open_command));
 }
 
 
-static int firm_close(struct usb_serial_port *port) {
+static int firm_close(struct usb_serial_port *port)
+{
         struct whiteheat_simple close_command;
 
         close_command.port = port->number - port->serial->minor + 1;
-        return firm_send_command(port, WHITEHEAT_CLOSE, (__u8 *)&close_command, sizeof(close_command));
+        return firm_send_command(port, WHITEHEAT_CLOSE,
+                        (__u8 *)&close_command, sizeof(close_command));
 }
 
 
-static int firm_setup_port(struct usb_serial_port *port) {
+static int firm_setup_port(struct tty_struct *tty)
+{
+        struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_port_settings port_settings;
-        unsigned int cflag = port->tty->termios->c_cflag;
+        unsigned int cflag = tty->termios->c_cflag;
 
         port_settings.port = port->number + 1;
 
         /* get the byte size */
         switch (cflag & CSIZE) {
-                case CS5:       port_settings.bits = 5;   break;
-                case CS6:       port_settings.bits = 6;   break;
-                case CS7:       port_settings.bits = 7;   break;
-                default:
-                case CS8:       port_settings.bits = 8;   break;
+        case CS5:       port_settings.bits = 5;   break;
+        case CS6:       port_settings.bits = 6;   break;
+        case CS7:       port_settings.bits = 7;   break;
+        default:
+        case CS8:       port_settings.bits = 8;   break;
         }
         dbg("%s - data bits = %d", __func__, port_settings.bits);
-        
+
         /* determine the parity */
         if (cflag & PARENB)
                 if (cflag & CMSPAR)
@@ -1205,7 +1263,8 @@ static int firm_setup_port(struct usb_serial_port *port) {
 
         /* figure out the flow control settings */
         if (cflag & CRTSCTS)
-                port_settings.hflow = (WHITEHEAT_HFLOW_CTS | WHITEHEAT_HFLOW_RTS);
+                port_settings.hflow = (WHITEHEAT_HFLOW_CTS |
+                                                WHITEHEAT_HFLOW_RTS);
         else
                 port_settings.hflow = WHITEHEAT_HFLOW_NONE;
         dbg("%s - hardware flow control = %s %s %s %s", __func__,
@@ -1213,81 +1272,95 @@ static int firm_setup_port(struct usb_serial_port *port) {
             (port_settings.hflow & WHITEHEAT_HFLOW_RTS) ? "RTS" : "",
             (port_settings.hflow & WHITEHEAT_HFLOW_DSR) ? "DSR" : "",
             (port_settings.hflow & WHITEHEAT_HFLOW_DTR) ? "DTR" : "");
-        
+
         /* determine software flow control */
-        if (I_IXOFF(port->tty))
+        if (I_IXOFF(tty))
                 port_settings.sflow = WHITEHEAT_SFLOW_RXTX;
         else
                 port_settings.sflow = WHITEHEAT_SFLOW_NONE;
         dbg("%s - software flow control = %c", __func__, port_settings.sflow);
-        
-        port_settings.xon = START_CHAR(port->tty);
-        port_settings.xoff = STOP_CHAR(port->tty);
-        dbg("%s - XON = %2x, XOFF = %2x", __func__, port_settings.xon, port_settings.xoff);
+
+        port_settings.xon = START_CHAR(tty);
+        port_settings.xoff = STOP_CHAR(tty);
+        dbg("%s - XON = %2x, XOFF = %2x",
+                        __func__, port_settings.xon, port_settings.xoff);
 
         /* get the baud rate wanted */
-        port_settings.baud = tty_get_baud_rate(port->tty);
+        port_settings.baud = tty_get_baud_rate(tty);
         dbg("%s - baud rate = %d", __func__, port_settings.baud);
 
         /* fixme: should set validated settings */
-        tty_encode_baud_rate(port->tty, port_settings.baud, port_settings.baud);
+        tty_encode_baud_rate(tty, port_settings.baud, port_settings.baud);
         /* handle any settings that aren't specified in the tty structure */
         port_settings.lloop = 0;
-        
+
         /* now send the message to the device */
-        return firm_send_command(port, WHITEHEAT_SETUP_PORT, (__u8 *)&port_settings, sizeof(port_settings));
+        return firm_send_command(port, WHITEHEAT_SETUP_PORT,
+                        (__u8 *)&port_settings, sizeof(port_settings));
 }
 
 
-static int firm_set_rts(struct usb_serial_port *port, __u8 onoff) {
+static int firm_set_rts(struct usb_serial_port *port, __u8 onoff)
+{
         struct whiteheat_set_rdb rts_command;
 
         rts_command.port = port->number - port->serial->minor + 1;
         rts_command.state = onoff;
-        return firm_send_command(port, WHITEHEAT_SET_RTS, (__u8 *)&rts_command, sizeof(rts_command));
+        return firm_send_command(port, WHITEHEAT_SET_RTS,
+                        (__u8 *)&rts_command, sizeof(rts_command));
 }
 
 
-static int firm_set_dtr(struct usb_serial_port *port, __u8 onoff) {
+static int firm_set_dtr(struct usb_serial_port *port, __u8 onoff)
+{
         struct whiteheat_set_rdb dtr_command;
 
         dtr_command.port = port->number - port->serial->minor + 1;
         dtr_command.state = onoff;
-        return firm_send_command(port, WHITEHEAT_SET_RTS, (__u8 *)&dtr_command, sizeof(dtr_command));
+        return firm_send_command(port, WHITEHEAT_SET_DTR,
+                        (__u8 *)&dtr_command, sizeof(dtr_command));
 }
 
 
-static int firm_set_break(struct usb_serial_port *port, __u8 onoff) {
+static int firm_set_break(struct usb_serial_port *port, __u8 onoff)
+{
         struct whiteheat_set_rdb break_command;
 
         break_command.port = port->number - port->serial->minor + 1;
         break_command.state = onoff;
-        return firm_send_command(port, WHITEHEAT_SET_RTS, (__u8 *)&break_command, sizeof(break_command));
+        return firm_send_command(port, WHITEHEAT_SET_BREAK,
+                        (__u8 *)&break_command, sizeof(break_command));
 }
 
 
-static int firm_purge(struct usb_serial_port *port, __u8 rxtx) {
+static int firm_purge(struct usb_serial_port *port, __u8 rxtx)
+{
         struct whiteheat_purge purge_command;
 
         purge_command.port = port->number - port->serial->minor + 1;
         purge_command.what = rxtx;
-        return firm_send_command(port, WHITEHEAT_PURGE, (__u8 *)&purge_command, sizeof(purge_command));
+        return firm_send_command(port, WHITEHEAT_PURGE,
+                        (__u8 *)&purge_command, sizeof(purge_command));
 }
 
 
-static int firm_get_dtr_rts(struct usb_serial_port *port) {
+static int firm_get_dtr_rts(struct usb_serial_port *port)
+{
         struct whiteheat_simple get_dr_command;
 
         get_dr_command.port = port->number - port->serial->minor + 1;
-        return firm_send_command(port, WHITEHEAT_GET_DTR_RTS, (__u8 *)&get_dr_command, sizeof(get_dr_command));
+        return firm_send_command(port, WHITEHEAT_GET_DTR_RTS,
+                        (__u8 *)&get_dr_command, sizeof(get_dr_command));
 }
 
 
-static int firm_report_tx_done(struct usb_serial_port *port) {
+static int firm_report_tx_done(struct usb_serial_port *port)
+{
         struct whiteheat_simple close_command;
 
         close_command.port = port->number - port->serial->minor + 1;
-        return firm_send_command(port, WHITEHEAT_REPORT_TX_DONE, (__u8 *)&close_command, sizeof(close_command));
+        return firm_send_command(port, WHITEHEAT_REPORT_TX_DONE,
+                        (__u8 *)&close_command, sizeof(close_command));
 }
 
 
@@ -1299,7 +1372,7 @@ static int start_command_port(struct usb_serial *serial)
         struct usb_serial_port *command_port;
         struct whiteheat_command_private *command_info;
         int retval = 0;
-        
+
         command_port = serial->port[COMMAND_PORT];
         command_info = usb_get_serial_port_data(command_port);
         mutex_lock(&command_info->mutex);
@@ -1310,7 +1383,8 @@ static int start_command_port(struct usb_serial *serial)
                 command_port->read_urb->dev = serial->dev;
                 retval = usb_submit_urb(command_port->read_urb, GFP_KERNEL);
                 if (retval) {
-                        err("%s - failed submitting read urb, error %d", __func__, retval);
+                        err("%s - failed submitting read urb, error %d",
+                                                        __func__, retval);
                         goto exit;
                 }
         }
@@ -1380,7 +1454,8 @@ static int start_port_read(struct usb_serial_port *port)
 }
 
 
-static struct whiteheat_urb_wrap *urb_to_wrap(struct urb* urb, struct list_head *head)
+static struct whiteheat_urb_wrap *urb_to_wrap(struct urb *urb,
+                                                struct list_head *head)
 {
         struct whiteheat_urb_wrap *wrap;
         struct list_head *tmp;
@@ -1406,7 +1481,7 @@ static void rx_data_softint(struct work_struct *work)
         struct whiteheat_private *info =
                 container_of(work, struct whiteheat_private, rx_work);
         struct usb_serial_port *port = info->port;
-        struct tty_struct *tty = port->tty;
+        struct tty_struct *tty = port->port.tty;
         struct whiteheat_urb_wrap *wrap;
         struct urb *urb;
         unsigned long flags;
@@ -1429,7 +1504,8 @@ static void rx_data_softint(struct work_struct *work)
                 urb = wrap->urb;
 
                 if (tty && urb->actual_length) {
-                        int len = tty_buffer_request_room(tty, urb->actual_length);
+                        int len = tty_buffer_request_room(tty,
+                                                        urb->actual_length);
                         /* This stuff can go away now I suspect */
                         if (unlikely(len < urb->actual_length)) {
                                 spin_lock_irqsave(&info->lock, flags);
@@ -1446,7 +1522,8 @@ static void rx_data_softint(struct work_struct *work)
                 urb->dev = port->serial->dev;
                 result = usb_submit_urb(urb, GFP_ATOMIC);
                 if (result) {
-                        err("%s - failed resubmitting read urb, error %d", __func__, result);
+                        err("%s - failed resubmitting read urb, error %d",
+                                __func__, result);
                         spin_lock_irqsave(&info->lock, flags);
                         list_add(tmp, &info->rx_urbs_free);
                         continue;
@@ -1465,7 +1542,7 @@ static void rx_data_softint(struct work_struct *work)
 /*****************************************************************************
  * Connect Tech's White Heat module functions
  *****************************************************************************/
-static int __init whiteheat_init (void)
+static int __init whiteheat_init(void)
 {
         int retval;
         retval = usb_serial_register(&whiteheat_fake_device);
@@ -1488,21 +1565,24 @@ failed_fake_register:
 }
 
 
-static void __exit whiteheat_exit (void)
+static void __exit whiteheat_exit(void)
 {
-        usb_deregister (&whiteheat_driver);
-        usb_serial_deregister (&whiteheat_fake_device);
-        usb_serial_deregister (&whiteheat_device);
+        usb_deregister(&whiteheat_driver);
+        usb_serial_deregister(&whiteheat_fake_device);
+        usb_serial_deregister(&whiteheat_device);
 }
 
 
 module_init(whiteheat_init);
 module_exit(whiteheat_exit);
 
-MODULE_AUTHOR( DRIVER_AUTHOR );
-MODULE_DESCRIPTION( DRIVER_DESC );
+MODULE_AUTHOR(DRIVER_AUTHOR);
+MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
 
+MODULE_FIRMWARE("whiteheat.fw");
+MODULE_FIRMWARE("whiteheat_loader.fw");
+
 module_param(urb_pool_size, int, 0);
 MODULE_PARM_DESC(urb_pool_size, "Number of urbs to use for buffering");