1 files changed, 22 insertions, 16 deletions

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 45883988a005..5019325ba25d 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -296,7 +296,6 @@ struct sierra_port_private {
         int dsr_state;
         int dcd_state;
         int ri_state;
-
         unsigned int opened:1;
 };
 
@@ -306,6 +305,8 @@ static int sierra_send_setup(struct usb_serial_port *port)
         struct sierra_port_private *portdata;
         __u16 interface = 0;
         int val = 0;
+        int do_send = 0;
+        int retval;
 
         dev_dbg(&port->dev, "%s\n", __func__);
 
@@ -324,10 +325,7 @@ static int sierra_send_setup(struct usb_serial_port *port)
                  */
                 if (port->interrupt_in_urb) {
                         /* send control message */
-                        return usb_control_msg(serial->dev,
-                                usb_rcvctrlpipe(serial->dev, 0),
-                                0x22, 0x21, val, interface,
-                                NULL, 0, USB_CTRL_SET_TIMEOUT);
+                        do_send = 1;
                 }
         }
 
@@ -339,12 +337,18 @@ static int sierra_send_setup(struct usb_serial_port *port)
                         interface = 1;
                 else if (port->bulk_out_endpointAddress == 5)
                         interface = 2;
-                return usb_control_msg(serial->dev,
-                        usb_rcvctrlpipe(serial->dev, 0),
-                        0x22, 0x21, val, interface,
-                        NULL, 0, USB_CTRL_SET_TIMEOUT);
+
+                do_send = 1;
         }
-        return 0;
+        if (!do_send)
+                return 0;
+
+        usb_autopm_get_interface(serial->interface);
+        retval = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
+                0x22, 0x21, val, interface, NULL, 0, USB_CTRL_SET_TIMEOUT);
+        usb_autopm_put_interface(serial->interface);
+
+        return retval;
 }
 
 static void sierra_set_termios(struct tty_struct *tty,
@@ -773,8 +777,11 @@ static void sierra_close(struct usb_serial_port *port)
 
         if (serial->dev) {
                 mutex_lock(&serial->disc_mutex);
-                if (!serial->disconnected)
+                if (!serial->disconnected) {
+                        serial->interface->needs_remote_wakeup = 0;
+                        usb_autopm_get_interface(serial->interface);
                         sierra_send_setup(port);
+                }
                 mutex_unlock(&serial->disc_mutex);
                 spin_lock_irq(&intfdata->susp_lock);
                 portdata->opened = 0;
@@ -788,8 +795,6 @@ static void sierra_close(struct usb_serial_port *port)
                         sierra_release_urb(portdata->in_urbs[i]);
                         portdata->in_urbs[i] = NULL;
                 }
-                usb_autopm_get_interface(serial->interface);
-                serial->interface->needs_remote_wakeup = 0;
         }
 }
 
@@ -827,6 +832,8 @@ static int sierra_open(struct tty_struct *tty, struct usb_serial_port *port)
         if (err) {
                 /* get rid of everything as in close */
                 sierra_close(port);
+                /* restore balance for autopm */
+                usb_autopm_put_interface(serial->interface);
                 return err;
         }
         sierra_send_setup(port);
@@ -915,7 +922,7 @@ static void sierra_release(struct usb_serial *serial)
 #ifdef CONFIG_PM
 static void stop_read_write_urbs(struct usb_serial *serial)
 {
-        int i, j;
+        int i;
         struct usb_serial_port *port;
         struct sierra_port_private *portdata;
 
@@ -923,8 +930,7 @@ static void stop_read_write_urbs(struct usb_serial *serial)
         for (i = 0; i < serial->num_ports; ++i) {
                 port = serial->port[i];
                 portdata = usb_get_serial_port_data(port);
-                for (j = 0; j < N_IN_URB; j++)
-                        usb_kill_urb(portdata->in_urbs[j]);
+                sierra_stop_rx_urbs(port);
                 usb_kill_anchored_urbs(&portdata->active);
         }
 }