8 files changed, 740 insertions, 85 deletions

diff --git a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
index 5246b35301de..650103bc9618 100644
--- a/drivers/usb/input/Kconfig
+++ b/drivers/usb/input/Kconfig
@@ -200,45 +200,41 @@ config USB_POWERMATE
           To compile this driver as a module, choose M here: the
           module will be called powermate.
 
-config USB_MTOUCH
-        tristate "MicroTouch USB Touchscreen Driver"
+config USB_TOUCHSCREEN
+        tristate "USB Touchscreen Driver"
         depends on USB && INPUT
         ---help---
-          Say Y here if you want to use a MicroTouch (Now 3M) USB 
-          Touchscreen controller.
+          USB Touchscreen driver for:
+          - eGalax Touchkit USB
+          - PanJit TouchSet USB
+          - 3M MicroTouch USB
+          - ITM
 
-          See <file:Documentation/usb/mtouch.txt> for additional information.
-
-          To compile this driver as a module, choose M here: the
-          module will be called mtouchusb.
-
-config USB_ITMTOUCH
-        tristate "ITM Touch USB Touchscreen Driver"
-        depends on USB && INPUT
-        ---help---
-          Say Y here if you want to use a ITM Touch USB
-          Touchscreen controller.
-
-          This touchscreen is used in LG 1510SF monitors.
+          Have a look at <http://linux.chapter7.ch/touchkit/> for
+          a usage description and the required user-space stuff.
 
           To compile this driver as a module, choose M here: the
-          module will be called itmtouch.
+          module will be called usbtouchscreen.
 
-config USB_EGALAX
-        tristate "eGalax TouchKit USB Touchscreen Driver"
-        depends on USB && INPUT
-        ---help---
-          Say Y here if you want to use a eGalax TouchKit USB
-          Touchscreen controller.
+config USB_TOUCHSCREEN_EGALAX
+        default y
+        bool "eGalax device support" if EMBEDDED
+        depends on USB_TOUCHSCREEN
 
-          The driver has been tested on a Xenarc 700TSV monitor
-          with eGalax touchscreen.
+config USB_TOUCHSCREEN_PANJIT
+        default y
+        bool "PanJit device support" if EMBEDDED
+        depends on USB_TOUCHSCREEN
 
-          Have a look at <http://linux.chapter7.ch/touchkit/> for
-          a usage description and the required user-space stuff.
+config USB_TOUCHSCREEN_3M
+        default y
+        bool "3M/Microtouch device support" if EMBEDDED
+        depends on USB_TOUCHSCREEN
 
-          To compile this driver as a module, choose M here: the
-          module will be called touchkitusb.
+config USB_TOUCHSCREEN_ITM
+        default y
+        bool "ITM device support" if EMBEDDED
+        depends on USB_TOUCHSCREEN
 
 config USB_YEALINK
         tristate "Yealink usb-p1k voip phone"
diff --git a/drivers/usb/input/Makefile b/drivers/usb/input/Makefile
index d512d9f488fe..764114529c56 100644
--- a/drivers/usb/input/Makefile
+++ b/drivers/usb/input/Makefile
@@ -37,6 +37,7 @@ obj-$(CONFIG_USB_MOUSE)		+= usbmouse.o
 obj-$(CONFIG_USB_MTOUCH)        += mtouchusb.o
 obj-$(CONFIG_USB_ITMTOUCH)      += itmtouch.o
 obj-$(CONFIG_USB_EGALAX)        += touchkitusb.o
+obj-$(CONFIG_USB_TOUCHSCREEN)   += usbtouchscreen.o
 obj-$(CONFIG_USB_POWERMATE)     += powermate.o
 obj-$(CONFIG_USB_WACOM)         += wacom.o
 obj-$(CONFIG_USB_ACECAD)        += acecad.o
diff --git a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
index d4bf1701046b..f419bd82ab7f 100644
--- a/drivers/usb/input/hid-core.c
+++ b/drivers/usb/input/hid-core.c
@@ -1372,6 +1372,11 @@ void hid_close(struct hid_device *hid)
                 usb_kill_urb(hid->urbin);
 }
 
+#define USB_VENDOR_ID_PANJIT            0x134c
+
+#define USB_VENDOR_ID_SILVERCREST       0x062a
+#define USB_DEVICE_ID_SILVERCREST_KB    0x0201
+
 /*
  * Initialize all reports
  */
@@ -1655,9 +1660,12 @@ static const struct hid_blacklist {
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 1, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 2, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 3, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 4, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 5, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_CINTIQ, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_DTF, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_DTF + 3, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_4_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_1_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
 
@@ -1675,6 +1683,7 @@ static const struct hid_blacklist {
         { USB_VENDOR_ID_HP, USB_DEVICE_ID_HP_USBHUB_KB, HID_QUIRK_NOGET },
         { USB_VENDOR_ID_TANGTOP, USB_DEVICE_ID_TANGTOP_USBPS2, HID_QUIRK_NOGET },
         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_USB_JOYPAD, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
+        { USB_VENDOR_ID_SILVERCREST, USB_DEVICE_ID_SILVERCREST_KB, HID_QUIRK_NOGET },
 
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_POWERMOUSE, HID_QUIRK_2WHEEL_POWERMOUSE },
         { USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_WCP32PU, HID_QUIRK_2WHEEL_MOUSE_HACK_7 },
@@ -1701,6 +1710,11 @@ static const struct hid_blacklist {
         { USB_VENDOR_ID_APPLE, 0x030A, HID_QUIRK_POWERBOOK_HAS_FN },
         { USB_VENDOR_ID_APPLE, 0x030B, HID_QUIRK_POWERBOOK_HAS_FN },
 
+        { USB_VENDOR_ID_PANJIT, 0x0001, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_PANJIT, 0x0002, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_PANJIT, 0x0003, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_PANJIT, 0x0004, HID_QUIRK_IGNORE },
+
         { 0, 0 }
 };
 
diff --git a/drivers/usb/input/hid-ff.c b/drivers/usb/input/hid-ff.c
index 72e698658b53..d5c91ee67991 100644
--- a/drivers/usb/input/hid-ff.c
+++ b/drivers/usb/input/hid-ff.c
@@ -34,12 +34,6 @@
 
 #include "hid.h"
 
-/* Drivers' initializing functions */
-extern int hid_lgff_init(struct hid_device* hid);
-extern int hid_lg3d_init(struct hid_device* hid);
-extern int hid_pid_init(struct hid_device* hid);
-extern int hid_tmff_init(struct hid_device* hid);
-
 /*
  * This table contains pointers to initializers. To add support for new
  * devices, you need to add the USB vendor and product ids here.
diff --git a/drivers/usb/input/hid.h b/drivers/usb/input/hid.h
index 4e1b784fe527..9c62837b5b89 100644
--- a/drivers/usb/input/hid.h
+++ b/drivers/usb/input/hid.h
@@ -533,3 +533,8 @@ static inline int hid_ff_event(struct hid_device *hid, struct input_dev *input,
                 return hid->ff_event(hid, input, type, code, value);
         return -ENOSYS;
 }
+
+int hid_lgff_init(struct hid_device* hid);
+int hid_tmff_init(struct hid_device* hid);
+int hid_pid_init(struct hid_device* hid);
+
diff --git a/drivers/usb/input/keyspan_remote.c b/drivers/usb/input/keyspan_remote.c
index b4a051b549d1..3d911976f378 100644
--- a/drivers/usb/input/keyspan_remote.c
+++ b/drivers/usb/input/keyspan_remote.c
@@ -297,6 +297,8 @@ static void keyspan_check_data(struct usb_keyspan *remote, struct pt_regs *regs)
                         remote->data.bits_left -= 6;
                 } else {
                         err("%s - Error in message, invalid toggle.\n", __FUNCTION__);
+                        remote->stage = 0;
+                        return;
                 }
 
                 keyspan_load_tester(remote, 5);
diff --git a/drivers/usb/input/usbtouchscreen.c b/drivers/usb/input/usbtouchscreen.c
new file mode 100644
index 000000000000..e9a07c1e905b
--- /dev/null
+++ b/drivers/usb/input/usbtouchscreen.c
@@ -0,0 +1,605 @@
+/******************************************************************************
+ * usbtouchscreen.c
+ * Driver for USB Touchscreens, supporting those devices:
+ *  - eGalax Touchkit
+ *  - 3M/Microtouch
+ *  - ITM
+ *  - PanJit TouchSet
+ *
+ * Copyright (C) 2004-2006 by Daniel Ritz <daniel.ritz@gmx.ch>
+ * Copyright (C) by Todd E. Johnson (mtouchusb.c)
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * Driver is based on touchkitusb.c
+ * - ITM parts are from itmtouch.c
+ * - 3M parts are from mtouchusb.c
+ * - PanJit parts are from an unmerged driver by Lanslott Gish
+ *
+ *****************************************************************************/
+
+//#define DEBUG
+
+#include <linux/config.h>
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/usb.h>
+#include <linux/usb_input.h>
+
+
+#define DRIVER_VERSION          "v0.3"
+#define DRIVER_AUTHOR           "Daniel Ritz <daniel.ritz@gmx.ch>"
+#define DRIVER_DESC             "USB Touchscreen Driver"
+
+static int swap_xy;
+module_param(swap_xy, bool, 0644);
+MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped.");
+
+/* device specifc data/functions */
+struct usbtouch_usb;
+struct usbtouch_device_info {
+        int min_xc, max_xc;
+        int min_yc, max_yc;
+        int min_press, max_press;
+        int rept_size;
+        int flags;
+
+        void (*process_pkt) (struct usbtouch_usb *usbtouch, struct pt_regs *regs, unsigned char *pkt, int len);
+        int  (*read_data)   (unsigned char *pkt, int *x, int *y, int *touch, int *press);
+        int  (*init)        (struct usbtouch_usb *usbtouch);
+};
+
+#define USBTOUCH_FLG_BUFFER     0x01
+
+
+/* a usbtouch device */
+struct usbtouch_usb {
+        unsigned char *data;
+        dma_addr_t data_dma;
+        unsigned char *buffer;
+        int buf_len;
+        struct urb *irq;
+        struct usb_device *udev;
+        struct input_dev *input;
+        struct usbtouch_device_info *type;
+        char name[128];
+        char phys[64];
+};
+
+static void usbtouch_process_pkt(struct usbtouch_usb *usbtouch,
+                                 struct pt_regs *regs, unsigned char *pkt, int len);
+
+/* device types */
+enum {
+        DEVTPYE_DUMMY = -1,
+        DEVTYPE_EGALAX,
+        DEVTYPE_PANJIT,
+        DEVTYPE_3M,
+        DEVTYPE_ITM,
+};
+
+static struct usb_device_id usbtouch_devices[] = {
+#ifdef CONFIG_USB_TOUCHSCREEN_EGALAX
+        {USB_DEVICE(0x3823, 0x0001), .driver_info = DEVTYPE_EGALAX},
+        {USB_DEVICE(0x0123, 0x0001), .driver_info = DEVTYPE_EGALAX},
+        {USB_DEVICE(0x0eef, 0x0001), .driver_info = DEVTYPE_EGALAX},
+        {USB_DEVICE(0x0eef, 0x0002), .driver_info = DEVTYPE_EGALAX},
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_PANJIT
+        {USB_DEVICE(0x134c, 0x0001), .driver_info = DEVTYPE_PANJIT},
+        {USB_DEVICE(0x134c, 0x0002), .driver_info = DEVTYPE_PANJIT},
+        {USB_DEVICE(0x134c, 0x0003), .driver_info = DEVTYPE_PANJIT},
+        {USB_DEVICE(0x134c, 0x0004), .driver_info = DEVTYPE_PANJIT},
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_3M
+        {USB_DEVICE(0x0596, 0x0001), .driver_info = DEVTYPE_3M},
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_ITM
+        {USB_DEVICE(0x0403, 0xf9e9), .driver_info = DEVTYPE_ITM},
+#endif
+
+        {}
+};
+
+
+/*****************************************************************************
+ * eGalax part
+ */
+
+#ifdef CONFIG_USB_TOUCHSCREEN_EGALAX
+
+#define EGALAX_PKT_TYPE_MASK            0xFE
+#define EGALAX_PKT_TYPE_REPT            0x80
+#define EGALAX_PKT_TYPE_DIAG            0x0A
+
+static int egalax_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
+{
+        if ((pkt[0] & EGALAX_PKT_TYPE_MASK) != EGALAX_PKT_TYPE_REPT)
+                return 0;
+
+        *x = ((pkt[3] & 0x0F) << 7) | (pkt[4] & 0x7F);
+        *y = ((pkt[1] & 0x0F) << 7) | (pkt[2] & 0x7F);
+        *touch = pkt[0] & 0x01;
+
+        return 1;
+
+}
+
+static int egalax_get_pkt_len(unsigned char *buf)
+{
+        switch (buf[0] & EGALAX_PKT_TYPE_MASK) {
+        case EGALAX_PKT_TYPE_REPT:
+                return 5;
+
+        case EGALAX_PKT_TYPE_DIAG:
+                return buf[1] + 2;
+        }
+
+        return 0;
+}
+
+static void egalax_process(struct usbtouch_usb *usbtouch, struct pt_regs *regs,
+                           unsigned char *pkt, int len)
+{
+        unsigned char *buffer;
+        int pkt_len, buf_len, pos;
+
+        /* if the buffer contains data, append */
+        if (unlikely(usbtouch->buf_len)) {
+                int tmp;
+
+                /* if only 1 byte in buffer, add another one to get length */
+                if (usbtouch->buf_len == 1)
+                        usbtouch->buffer[1] = pkt[0];
+
+                pkt_len = egalax_get_pkt_len(usbtouch->buffer);
+
+                /* unknown packet: drop everything */
+                if (!pkt_len)
+                        return;
+
+                /* append, process */
+                tmp = pkt_len - usbtouch->buf_len;
+                memcpy(usbtouch->buffer + usbtouch->buf_len, pkt, tmp);
+                usbtouch_process_pkt(usbtouch, regs, usbtouch->buffer, pkt_len);
+
+                buffer = pkt + tmp;
+                buf_len = len - tmp;
+        } else {
+                buffer = pkt;
+                buf_len = len;
+        }
+
+        /* only one byte left in buffer */
+        if (unlikely(buf_len == 1)) {
+                usbtouch->buffer[0] = buffer[0];
+                usbtouch->buf_len = 1;
+                return;
+        }
+
+        /* loop over the buffer */
+        pos = 0;
+        while (pos < buf_len) {
+                /* get packet len */
+                pkt_len = egalax_get_pkt_len(buffer + pos);
+
+                /* unknown packet: drop everything */
+                if (unlikely(!pkt_len))
+                        return;
+
+                /* full packet: process */
+                if (likely(pkt_len <= buf_len)) {
+                        usbtouch_process_pkt(usbtouch, regs, buffer + pos, pkt_len);
+                } else {
+                        /* incomplete packet: save in buffer */
+                        memcpy(usbtouch->buffer, buffer + pos, buf_len - pos);
+                        usbtouch->buf_len = buf_len - pos;
+                }
+                pos += pkt_len;
+        }
+}
+#endif
+
+
+/*****************************************************************************
+ * PanJit Part
+ */
+#ifdef CONFIG_USB_TOUCHSCREEN_PANJIT
+static int panjit_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
+{
+        *x = ((pkt[2] & 0x0F) << 8) | pkt[1];
+        *y = ((pkt[4] & 0x0F) << 8) | pkt[3];
+        *touch = pkt[0] & 0x01;
+
+        return 1;
+}
+#endif
+
+
+/*****************************************************************************
+ * 3M/Microtouch Part
+ */
+#ifdef CONFIG_USB_TOUCHSCREEN_3M
+
+#define MTOUCHUSB_ASYNC_REPORT          1
+#define MTOUCHUSB_RESET                 7
+#define MTOUCHUSB_REQ_CTRLLR_ID         10
+
+static int mtouch_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
+{
+        *x = (pkt[8] << 8) | pkt[7];
+        *y = (pkt[10] << 8) | pkt[9];
+        *touch = (pkt[2] & 0x40) ? 1 : 0;
+
+        return 1;
+}
+
+static int mtouch_init(struct usbtouch_usb *usbtouch)
+{
+        int ret;
+
+        ret = usb_control_msg(usbtouch->udev, usb_rcvctrlpipe(usbtouch->udev, 0),
+                              MTOUCHUSB_RESET,
+                              USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+                              1, 0, NULL, 0, USB_CTRL_SET_TIMEOUT);
+        dbg("%s - usb_control_msg - MTOUCHUSB_RESET - bytes|err: %d",
+            __FUNCTION__, ret);
+        if (ret < 0)
+                return ret;
+
+        ret = usb_control_msg(usbtouch->udev, usb_rcvctrlpipe(usbtouch->udev, 0),
+                              MTOUCHUSB_ASYNC_REPORT,
+                              USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+                              1, 1, NULL, 0, USB_CTRL_SET_TIMEOUT);
+        dbg("%s - usb_control_msg - MTOUCHUSB_ASYNC_REPORT - bytes|err: %d",
+            __FUNCTION__, ret);
+        if (ret < 0)
+                return ret;
+
+        return 0;
+}
+#endif
+
+
+/*****************************************************************************
+ * ITM Part
+ */
+#ifdef CONFIG_USB_TOUCHSCREEN_ITM
+static int itm_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
+{
+        *x = ((pkt[0] & 0x1F) << 7) | (pkt[3] & 0x7F);
+        *x = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
+        *press = ((pkt[2] & 0x1F) << 7) | (pkt[5] & 0x7F);
+        *touch = ~pkt[7] & 0x20;
+
+        return 1;
+}
+#endif
+
+
+/*****************************************************************************
+ * the different device descriptors
+ */
+static struct usbtouch_device_info usbtouch_dev_info[] = {
+#ifdef CONFIG_USB_TOUCHSCREEN_EGALAX
+        [DEVTYPE_EGALAX] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x07ff,
+                .min_yc         = 0x0,
+                .max_yc         = 0x07ff,
+                .rept_size      = 16,
+                .flags          = USBTOUCH_FLG_BUFFER,
+                .process_pkt    = egalax_process,
+                .read_data      = egalax_read_data,
+        },
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_PANJIT
+        [DEVTYPE_PANJIT] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x0fff,
+                .min_yc         = 0x0,
+                .max_yc         = 0x0fff,
+                .rept_size      = 8,
+                .read_data      = panjit_read_data,
+        },
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_3M
+        [DEVTYPE_3M] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x4000,
+                .min_yc         = 0x0,
+                .max_yc         = 0x4000,
+                .rept_size      = 11,
+                .read_data      = mtouch_read_data,
+                .init           = mtouch_init,
+        },
+#endif
+
+#ifdef CONFIG_USB_TOUCHSCREEN_ITM
+        [DEVTYPE_ITM] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x0fff,
+                .min_yc         = 0x0,
+                .max_yc         = 0x0fff,
+                .max_press      = 0xff,
+                .rept_size      = 8,
+                .read_data      = itm_read_data,
+        },
+#endif
+};
+
+
+/*****************************************************************************
+ * Generic Part
+ */
+static void usbtouch_process_pkt(struct usbtouch_usb *usbtouch,
+                                 struct pt_regs *regs, unsigned char *pkt, int len)
+{
+        int x, y, touch, press;
+        struct usbtouch_device_info *type = usbtouch->type;
+
+        if (!type->read_data(pkt, &x, &y, &touch, &press))
+                        return;
+
+        input_regs(usbtouch->input, regs);
+        input_report_key(usbtouch->input, BTN_TOUCH, touch);
+
+        if (swap_xy) {
+                input_report_abs(usbtouch->input, ABS_X, y);
+                input_report_abs(usbtouch->input, ABS_Y, x);
+        } else {
+                input_report_abs(usbtouch->input, ABS_X, x);
+                input_report_abs(usbtouch->input, ABS_Y, y);
+        }
+        if (type->max_press)
+                input_report_abs(usbtouch->input, ABS_PRESSURE, press);
+        input_sync(usbtouch->input);
+}
+
+
+static void usbtouch_irq(struct urb *urb, struct pt_regs *regs)
+{
+        struct usbtouch_usb *usbtouch = urb->context;
+        int retval;
+
+        switch (urb->status) {
+        case 0:
+                /* success */
+                break;
+        case -ETIMEDOUT:
+                /* this urb is timing out */
+                dbg("%s - urb timed out - was the device unplugged?",
+                    __FUNCTION__);
+                return;
+        case -ECONNRESET:
+        case -ENOENT:
+        case -ESHUTDOWN:
+                /* this urb is terminated, clean up */
+                dbg("%s - urb shutting down with status: %d",
+                    __FUNCTION__, urb->status);
+                return;
+        default:
+                dbg("%s - nonzero urb status received: %d",
+                    __FUNCTION__, urb->status);
+                goto exit;
+        }
+
+        usbtouch->type->process_pkt(usbtouch, regs, usbtouch->data, urb->actual_length);
+
+exit:
+        retval = usb_submit_urb(urb, GFP_ATOMIC);
+        if (retval)
+                err("%s - usb_submit_urb failed with result: %d",
+                    __FUNCTION__, retval);
+}
+
+static int usbtouch_open(struct input_dev *input)
+{
+        struct usbtouch_usb *usbtouch = input->private;
+
+        usbtouch->irq->dev = usbtouch->udev;
+
+        if (usb_submit_urb(usbtouch->irq, GFP_KERNEL))
+                return -EIO;
+
+        return 0;
+}
+
+static void usbtouch_close(struct input_dev *input)
+{
+        struct usbtouch_usb *usbtouch = input->private;
+
+        usb_kill_urb(usbtouch->irq);
+}
+
+
+static void usbtouch_free_buffers(struct usb_device *udev,
+                                  struct usbtouch_usb *usbtouch)
+{
+        if (usbtouch->data)
+                usb_buffer_free(udev, usbtouch->type->rept_size,
+                                usbtouch->data, usbtouch->data_dma);
+        kfree(usbtouch->buffer);
+}
+
+
+static int usbtouch_probe(struct usb_interface *intf,
+                          const struct usb_device_id *id)
+{
+        struct usbtouch_usb *usbtouch;
+        struct input_dev *input_dev;
+        struct usb_host_interface *interface;
+        struct usb_endpoint_descriptor *endpoint;
+        struct usb_device *udev = interface_to_usbdev(intf);
+        struct usbtouch_device_info *type;
+        int err;
+
+        interface = intf->cur_altsetting;
+        endpoint = &interface->endpoint[0].desc;
+
+        usbtouch = kzalloc(sizeof(struct usbtouch_usb), GFP_KERNEL);
+        input_dev = input_allocate_device();
+        if (!usbtouch || !input_dev)
+                goto out_free;
+
+        type = &usbtouch_dev_info[id->driver_info];
+        usbtouch->type = type;
+        if (!type->process_pkt)
+                type->process_pkt = usbtouch_process_pkt;
+
+        usbtouch->data = usb_buffer_alloc(udev, type->rept_size,
+                                          SLAB_KERNEL, &usbtouch->data_dma);
+        if (!usbtouch->data)
+                goto out_free;
+
+        if (type->flags & USBTOUCH_FLG_BUFFER) {
+                usbtouch->buffer = kmalloc(type->rept_size, GFP_KERNEL);
+                if (!usbtouch->buffer)
+                        goto out_free_buffers;
+        }
+
+        usbtouch->irq = usb_alloc_urb(0, GFP_KERNEL);
+        if (!usbtouch->irq) {
+                dbg("%s - usb_alloc_urb failed: usbtouch->irq", __FUNCTION__);
+                goto out_free_buffers;
+        }
+
+        usbtouch->udev = udev;
+        usbtouch->input = input_dev;
+
+        if (udev->manufacturer)
+                strlcpy(usbtouch->name, udev->manufacturer, sizeof(usbtouch->name));
+
+        if (udev->product) {
+                if (udev->manufacturer)
+                        strlcat(usbtouch->name, " ", sizeof(usbtouch->name));
+                strlcat(usbtouch->name, udev->product, sizeof(usbtouch->name));
+        }
+
+        if (!strlen(usbtouch->name))
+                snprintf(usbtouch->name, sizeof(usbtouch->name),
+                        "USB Touchscreen %04x:%04x",
+                         le16_to_cpu(udev->descriptor.idVendor),
+                         le16_to_cpu(udev->descriptor.idProduct));
+
+        usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
+        strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+
+        input_dev->name = usbtouch->name;
+        input_dev->phys = usbtouch->phys;
+        usb_to_input_id(udev, &input_dev->id);
+        input_dev->cdev.dev = &intf->dev;
+        input_dev->private = usbtouch;
+        input_dev->open = usbtouch_open;
+        input_dev->close = usbtouch_close;
+
+        input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_ABS);
+        input_dev->keybit[LONG(BTN_TOUCH)] = BIT(BTN_TOUCH);
+        input_set_abs_params(input_dev, ABS_X, type->min_xc, type->max_xc, 0, 0);
+        input_set_abs_params(input_dev, ABS_Y, type->min_yc, type->max_yc, 0, 0);
+        if (type->max_press)
+                input_set_abs_params(input_dev, ABS_PRESSURE, type->min_press,
+                                     type->max_press, 0, 0);
+
+        usb_fill_int_urb(usbtouch->irq, usbtouch->udev,
+                         usb_rcvintpipe(usbtouch->udev, 0x81),
+                         usbtouch->data, type->rept_size,
+                         usbtouch_irq, usbtouch, endpoint->bInterval);
+
+        usbtouch->irq->transfer_dma = usbtouch->data_dma;
+        usbtouch->irq->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
+
+        /* device specific init */
+        if (type->init) {
+                err = type->init(usbtouch);
+                if (err) {
+                        dbg("%s - type->init() failed, err: %d", __FUNCTION__, err);
+                        goto out_free_buffers;
+                }
+        }
+
+        err = input_register_device(usbtouch->input);
+        if (err) {
+                dbg("%s - input_register_device failed, err: %d", __FUNCTION__, err);
+                goto out_free_buffers;
+        }
+
+        usb_set_intfdata(intf, usbtouch);
+
+        return 0;
+
+out_free_buffers:
+        usbtouch_free_buffers(udev, usbtouch);
+out_free:
+        input_free_device(input_dev);
+        kfree(usbtouch);
+        return -ENOMEM;
+}
+
+static void usbtouch_disconnect(struct usb_interface *intf)
+{
+        struct usbtouch_usb *usbtouch = usb_get_intfdata(intf);
+
+        dbg("%s - called", __FUNCTION__);
+
+        if (!usbtouch)
+                return;
+
+        dbg("%s - usbtouch is initialized, cleaning up", __FUNCTION__);
+        usb_set_intfdata(intf, NULL);
+        usb_kill_urb(usbtouch->irq);
+        input_unregister_device(usbtouch->input);
+        usb_free_urb(usbtouch->irq);
+        usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);
+        kfree(usbtouch);
+}
+
+MODULE_DEVICE_TABLE(usb, usbtouch_devices);
+
+static struct usb_driver usbtouch_driver = {
+        .name           = "usbtouchscreen",
+        .probe          = usbtouch_probe,
+        .disconnect     = usbtouch_disconnect,
+        .id_table       = usbtouch_devices,
+};
+
+static int __init usbtouch_init(void)
+{
+        return usb_register(&usbtouch_driver);
+}
+
+static void __exit usbtouch_cleanup(void)
+{
+        usb_deregister(&usbtouch_driver);
+}
+
+module_init(usbtouch_init);
+module_exit(usbtouch_cleanup);
+
+MODULE_AUTHOR(DRIVER_AUTHOR);
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
+
+MODULE_ALIAS("touchkitusb");
+MODULE_ALIAS("itmtouch");
+MODULE_ALIAS("mtouchusb");
diff --git a/drivers/usb/input/wacom.c b/drivers/usb/input/wacom.c
index d3e15df9e815..cf84c6096f29 100644
--- a/drivers/usb/input/wacom.c
+++ b/drivers/usb/input/wacom.c
@@ -9,7 +9,7 @@
  *  Copyright (c) 2000 Daniel Egger             <egger@suse.de>
  *  Copyright (c) 2001 Frederic Lepied          <flepied@mandrakesoft.com>
  *  Copyright (c) 2004 Panagiotis Issaris       <panagiotis.issaris@mech.kuleuven.ac.be>
- *  Copyright (c) 2002-2005 Ping Cheng          <pingc@wacom.com>
+ *  Copyright (c) 2002-2006 Ping Cheng          <pingc@wacom.com>
  *
  *  ChangeLog:
  *      v0.1 (vp)  - Initial release
@@ -56,6 +56,8 @@
  *                 - Merged wacom_intuos3_irq into wacom_intuos_irq
  *      v1.44 (pc) - Added support for Graphire4, Cintiq 710, Intuos3 6x11, etc.
  *                 - Report Device IDs
+ *      v1.45 (pc) - Added support for DTF 521, Intuos3 12x12 and 12x19
+ *                 - Minor data report fix
  */
 
 /*
@@ -78,7 +80,7 @@
 /*
  * Version Information
  */
-#define DRIVER_VERSION "v1.44"
+#define DRIVER_VERSION "v1.45"
 #define DRIVER_AUTHOR "Vojtech Pavlik <vojtech@ucw.cz>"
 #define DRIVER_DESC "USB Wacom Graphire and Wacom Intuos tablet driver"
 #define DRIVER_LICENSE "GPL"
@@ -99,6 +101,8 @@ enum {
         PL,
         INTUOS,
         INTUOS3,
+        INTUOS312,
+        INTUOS319,
         CINTIQ,
         MAX_TYPE
 };
@@ -127,7 +131,19 @@ struct wacom {
         char phys[32];
 };
 
+#define USB_REQ_GET_REPORT      0x01
 #define USB_REQ_SET_REPORT      0x09
+
+static int usb_get_report(struct usb_interface *intf, unsigned char type,
+                                unsigned char id, void *buf, int size)
+{
+        return usb_control_msg(interface_to_usbdev(intf),
+                usb_rcvctrlpipe(interface_to_usbdev(intf), 0),
+                USB_REQ_GET_REPORT, USB_TYPE_CLASS | USB_RECIP_INTERFACE,
+                (type << 8) + id, intf->altsetting[0].desc.bInterfaceNumber,
+                buf, size, 100);
+}
+
 static int usb_set_report(struct usb_interface *intf, unsigned char type,
                                 unsigned char id, void *buf, int size)
 {
@@ -206,7 +222,8 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
                         wacom->tool[1] = BTN_TOOL_PEN;
                         id = STYLUS_DEVICE_ID;
                 }
-                input_report_key(dev, wacom->tool[1], id); /* report in proximity for tool */
+                input_report_key(dev, wacom->tool[1], prox); /* report in proximity for tool */
+                input_report_abs(dev, ABS_MISC, id); /* report tool id */
                 input_report_abs(dev, ABS_X, data[3] | (data[2] << 7) | ((data[1] & 0x03) << 14));
                 input_report_abs(dev, ABS_Y, data[6] | (data[5] << 7) | ((data[4] & 0x03) << 14));
                 input_report_abs(dev, ABS_PRESSURE, pressure);
@@ -239,7 +256,7 @@ static void wacom_ptu_irq(struct urb *urb, struct pt_regs *regs)
         struct wacom *wacom = urb->context;
         unsigned char *data = wacom->data;
         struct input_dev *dev = wacom->dev;
-        int retval;
+        int retval, id;
 
         switch (urb->status) {
         case 0:
@@ -263,12 +280,15 @@ static void wacom_ptu_irq(struct urb *urb, struct pt_regs *regs)
 
         input_regs(dev, regs);
         if (data[1] & 0x04) {
-                input_report_key(dev, BTN_TOOL_RUBBER, (data[1] & 0x20) ? ERASER_DEVICE_ID : 0);
+                input_report_key(dev, BTN_TOOL_RUBBER, data[1] & 0x20);
                 input_report_key(dev, BTN_TOUCH, data[1] & 0x08);
+                id = ERASER_DEVICE_ID;
         } else {
-                input_report_key(dev, BTN_TOOL_PEN, (data[1] & 0x20) ? STYLUS_DEVICE_ID : 0);
+                input_report_key(dev, BTN_TOOL_PEN, data[1] & 0x20);
                 input_report_key(dev, BTN_TOUCH, data[1] & 0x01);
+                id = STYLUS_DEVICE_ID;
         }
+        input_report_abs(dev, ABS_MISC, id); /* report tool id */
         input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[2]));
         input_report_abs(dev, ABS_Y, le16_to_cpu(*(__le16 *) &data[4]));
         input_report_abs(dev, ABS_PRESSURE, le16_to_cpu(*(__le16 *) &data[6]));
@@ -312,7 +332,8 @@ static void wacom_penpartner_irq(struct urb *urb, struct pt_regs *regs)
         }
 
         input_regs(dev, regs);
-        input_report_key(dev, BTN_TOOL_PEN, STYLUS_DEVICE_ID);
+        input_report_key(dev, BTN_TOOL_PEN, 1);
+        input_report_abs(dev, ABS_MISC, STYLUS_DEVICE_ID); /* report tool id */
         input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[1]));
         input_report_abs(dev, ABS_Y, le16_to_cpu(*(__le16 *) &data[3]));
         input_report_abs(dev, ABS_PRESSURE, (signed char)data[6] + 127);
@@ -350,6 +371,8 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                 goto exit;
         }
 
+        if (data[0] == 99) return; /* for Volito tablets */
+
         if (data[0] != 2) {
                 dbg("wacom_graphire_irq: received unknown report #%d", data[0]);
                 goto exit;
@@ -374,10 +397,10 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                         case 2: /* Mouse with wheel */
                                 input_report_key(dev, BTN_MIDDLE, data[1] & 0x04);
                                 if (wacom->features->type == WACOM_G4) {
-                                        rw = data[7] & 0x04 ? -(data[7] & 0x03) : (data[7] & 0x03);
-                                        input_report_rel(dev, REL_WHEEL, rw);
+                                        rw = data[7] & 0x04 ? (data[7] & 0x03)-4 : (data[7] & 0x03);
+                                        input_report_rel(dev, REL_WHEEL, -rw);
                                 } else
-                                        input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
+                                        input_report_rel(dev, REL_WHEEL, -(signed char) data[6]);
                                 /* fall through */
 
                         case 3: /* Mouse without wheel */
@@ -406,39 +429,27 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                 }
         }
 
-        input_report_key(dev, wacom->tool[0], (data[1] & 0x10) ? id : 0);
+        if (data[1] & 0x10)
+                input_report_abs(dev, ABS_MISC, id); /* report tool id */
+        else
+                input_report_abs(dev, ABS_MISC, 0); /* reset tool id */
+        input_report_key(dev, wacom->tool[0], data[1] & 0x10);
         input_sync(dev);
 
         /* send pad data */
         if (wacom->features->type == WACOM_G4) {
-                /* fist time sending pad data */
-                if (wacom->tool[1] != BTN_TOOL_FINGER) {
-                        wacom->id[1] = 0;
-                        wacom->serial[1] = (data[7] & 0x38) >> 2;
-                }
-                if (data[7] & 0xf8) {
+                if ((wacom->serial[1] & 0xc0) != (data[7] & 0xf8)) {
+                        wacom->id[1] = 1;
+                        wacom->serial[1] = (data[7] & 0xf8);
                         input_report_key(dev, BTN_0, (data[7] & 0x40));
                         input_report_key(dev, BTN_4, (data[7] & 0x80));
-                        if (((data[7] & 0x38) >> 2) == (wacom->serial[1] & 0x0e))
-                                /* alter REL_WHEEL value so X apps can get it */
-                                wacom->serial[1] += (wacom->serial[1] & 0x01) ? -1 : 1;
-                        else
-                                 wacom->serial[1] = (data[7] & 0x38 ) >> 2;
-
-                        /* don't alter the value when there is no wheel event */
-                        if (wacom->serial[1] == 1)
-                                wacom->serial[1] = 0;
-                        rw = wacom->serial[1];
-                        rw = (rw & 0x08) ? -(rw & 0x07) : (rw & 0x07);
+                        rw = ((data[7] & 0x18) >> 3) - ((data[7] & 0x20) >> 3);
                         input_report_rel(dev, REL_WHEEL, rw);
-                        wacom->tool[1] = BTN_TOOL_FINGER;
-                        wacom->id[1] = data[7] & 0xf8;
-                        input_report_key(dev, wacom->tool[1], 0xf0);
+                        input_report_key(dev, BTN_TOOL_FINGER, 0xf0);
                         input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
                 } else if (wacom->id[1]) {
                         wacom->id[1] = 0;
-                        wacom->serial[1] = 0;
-                        input_report_key(dev, wacom->tool[1], 0);
+                        input_report_key(dev, BTN_TOOL_FINGER, 0);
                         input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
                 }
                 input_sync(dev);
@@ -516,21 +527,31 @@ static int wacom_intuos_inout(struct urb *urb)
                         default: /* Unknown tool */
                                 wacom->tool[idx] = BTN_TOOL_PEN;
                 }
-                input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
-                input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
-                input_sync(dev);
+                if(!((wacom->tool[idx] == BTN_TOOL_LENS) &&
+                                ((wacom->features->type == INTUOS312)
+                                        || (wacom->features->type == INTUOS319)))) {
+                        input_report_abs(dev, ABS_MISC, wacom->id[idx]); /* report tool id */
+                        input_report_key(dev, wacom->tool[idx], 1);
+                        input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
+                        input_sync(dev);
+                }
                 return 1;
         }
 
         /* Exit report */
         if ((data[1] & 0xfe) == 0x80) {
                 input_report_key(dev, wacom->tool[idx], 0);
+                input_report_abs(dev, ABS_MISC, 0); /* reset tool id */
                 input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
                 input_sync(dev);
                 return 1;
         }
 
-        return 0;
+        if((wacom->tool[idx] == BTN_TOOL_LENS) && ((wacom->features->type == INTUOS312)
+                        || (wacom->features->type == INTUOS319)))
+                return 1;
+        else
+                return 0;
 }
 
 static void wacom_intuos_general(struct urb *urb)
@@ -600,10 +621,9 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
         /* pad packets. Works as a second tool and is always in prox */
         if (data[0] == 12) {
                 /* initiate the pad as a device */
-                if (wacom->tool[1] != BTN_TOOL_FINGER) {
+                if (wacom->tool[1] != BTN_TOOL_FINGER)
                         wacom->tool[1] = BTN_TOOL_FINGER;
-                        input_report_key(dev, wacom->tool[1], 1);
-                }
+
                 input_report_key(dev, BTN_0, (data[5] & 0x01));
                 input_report_key(dev, BTN_1, (data[5] & 0x02));
                 input_report_key(dev, BTN_2, (data[5] & 0x04));
@@ -614,6 +634,11 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
                 input_report_key(dev, BTN_7, (data[6] & 0x08));
                 input_report_abs(dev, ABS_RX, ((data[1] & 0x1f) << 8) | data[2]);
                 input_report_abs(dev, ABS_RY, ((data[3] & 0x1f) << 8) | data[4]);
+
+                if((data[5] & 0x0f) | (data[6] & 0x0f) | (data[1] & 0x1f) | data[2])
+                        input_report_key(dev, wacom->tool[1], 1);
+                else
+                        input_report_key(dev, wacom->tool[1], 0);
                 input_event(dev, EV_MSC, MSC_SERIAL, 0xffffffff);
                 input_sync(dev);
                 goto exit;
@@ -676,8 +701,8 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
                         input_report_key(dev, BTN_LEFT,   data[8] & 0x04);
                         input_report_key(dev, BTN_MIDDLE, data[8] & 0x08);
                         input_report_key(dev, BTN_RIGHT,  data[8] & 0x10);
-                        input_report_rel(dev, REL_WHEEL, ((data[8] & 0x02) >> 1)
-                                                 - (data[8] & 0x01));
+                        input_report_rel(dev, REL_WHEEL, (data[8] & 0x01)
+                                                 - ((data[8] & 0x02) >> 1));
 
                         /* I3 2D mouse side buttons */
                         if (wacom->features->type == INTUOS3) {
@@ -695,7 +720,8 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
                 }
         }
 
-        input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
+        input_report_abs(dev, ABS_MISC, wacom->id[idx]); /* report tool id */
+        input_report_key(dev, wacom->tool[idx], 1);
         input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
         input_sync(dev);
 
@@ -733,7 +759,8 @@ static struct wacom_features wacom_features[] = {
         { "Wacom PL800",         8,   7220,  5780,  511, 32, PL,         wacom_pl_irq },
         { "Wacom PL700",         8,   6758,  5406,  511, 32, PL,         wacom_pl_irq },
         { "Wacom PL510",         8,   6282,  4762,  511, 32, PL,         wacom_pl_irq },
-        { "Wacom PL710",         8,  34080, 27660,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom DTU710",        8,  34080, 27660,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom DTF521",        8,   6282,  4762,  511, 32, PL,         wacom_pl_irq },
         { "Wacom DTF720",        8,   6858,  5506,  511, 32, PL,         wacom_pl_irq },
         { "Wacom Cintiq Partner",8,  20480, 15360,  511, 32, PL,         wacom_ptu_irq },
         { "Wacom Intuos2 4x5",   10, 12700, 10600, 1023, 15, INTUOS,     wacom_intuos_irq },
@@ -744,6 +771,8 @@ static struct wacom_features wacom_features[] = {
         { "Wacom Intuos3 4x5",   10, 25400, 20320, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Intuos3 6x8",   10, 40640, 30480, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Intuos3 9x12",  10, 60960, 45720, 1023, 15, INTUOS3,    wacom_intuos_irq },
+        { "Wacom Intuos3 12x12", 10, 60960, 60960, 1023, 15, INTUOS312,  wacom_intuos_irq },
+        { "Wacom Intuos3 12x19", 10, 97536, 60960, 1023, 15, INTUOS319,  wacom_intuos_irq },
         { "Wacom Intuos3 6x11",  10, 54204, 31750, 1023, 15, INTUOS3,    wacom_intuos_irq },
         { "Wacom Cintiq 21UX",   10, 87200, 65600, 1023, 15, CINTIQ,     wacom_intuos_irq },
         { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
@@ -779,6 +808,7 @@ static struct usb_device_id wacom_ids[] = {
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x38) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x39) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC0) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC3) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x41) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x42) },
@@ -788,6 +818,8 @@ static struct usb_device_id wacom_ids[] = {
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB0) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB1) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB2) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB3) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB4) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB5) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x3F) },
         { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x47) },
@@ -820,7 +852,7 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
         struct usb_endpoint_descriptor *endpoint;
         struct wacom *wacom;
         struct input_dev *input_dev;
-        char rep_data[2] = {0x02, 0x02};
+        char rep_data[2], limit = 0;
 
         wacom = kzalloc(sizeof(struct wacom), GFP_KERNEL);
         input_dev = input_allocate_device();
@@ -857,6 +889,7 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
         input_set_abs_params(input_dev, ABS_X, 0, wacom->features->x_max, 4, 0);
         input_set_abs_params(input_dev, ABS_Y, 0, wacom->features->y_max, 4, 0);
         input_set_abs_params(input_dev, ABS_PRESSURE, 0, wacom->features->pressure_max, 0, 0);
+        input_dev->absbit[LONG(ABS_MISC)] |= BIT(ABS_MISC);
 
         switch (wacom->features->type) {
                 case WACOM_G4:
@@ -875,6 +908,8 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
                         break;
 
                 case INTUOS3:
+                case INTUOS312:
+                case INTUOS319:
                 case CINTIQ:
                         input_dev->keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_FINGER);
                         input_dev->keybit[LONG(BTN_LEFT)] |= BIT(BTN_0) | BIT(BTN_1) | BIT(BTN_2) | BIT(BTN_3) | BIT(BTN_4) | BIT(BTN_5) | BIT(BTN_6) | BIT(BTN_7);
@@ -916,10 +951,13 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
 
         input_register_device(wacom->dev);
 
-        /* ask the tablet to report tablet data */
-        usb_set_report(intf, 3, 2, rep_data, 2);
-        /* repeat once (not sure why the first call often fails) */
-        usb_set_report(intf, 3, 2, rep_data, 2);
+        /* Ask the tablet to report tablet data. Repeat until it succeeds */
+        do {
+                rep_data[0] = 2;
+                rep_data[1] = 2;
+                usb_set_report(intf, 3, 2, rep_data, 2);
+                usb_get_report(intf, 3, 2, rep_data, 2);
+        } while (rep_data[1] != 2 && limit++ < 5);
 
         usb_set_intfdata(intf, wacom);
         return 0;