4 files changed, 29 insertions, 36 deletions

diff --git a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
index a91e72c41415..6f7a684c3e07 100644
--- a/drivers/usb/input/hid-core.c
+++ b/drivers/usb/input/hid-core.c
@@ -1307,7 +1307,7 @@ void hid_init_reports(struct hid_device *hid)
         }
 
         if (err)
-                warn("timeout initializing reports\n");
+                warn("timeout initializing reports");
 }
 
 #define USB_VENDOR_ID_WACOM             0x056a
@@ -1453,6 +1453,9 @@ void hid_init_reports(struct hid_device *hid)
 #define USB_VENDOR_ID_CHERRY            0x046a
 #define USB_DEVICE_ID_CHERRY_CYMOTION   0x0023
 
+#define USB_VENDOR_ID_HP                0x03f0
+#define USB_DEVICE_ID_HP_USBHUB_KB      0x020c
+
 /*
  * Alphabetically sorted blacklist by quirk type.
  */
@@ -1566,6 +1569,7 @@ static const struct hid_blacklist {
         { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVMC, HID_QUIRK_NOGET },
         { USB_VENDOR_ID_BTC, USB_DEVICE_ID_BTC_KEYBOARD, HID_QUIRK_NOGET},
         { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_USBHUB_KB, HID_QUIRK_NOGET},
+        { USB_VENDOR_ID_HP, USB_DEVICE_ID_HP_USBHUB_KB, HID_QUIRK_NOGET },
         { USB_VENDOR_ID_TANGTOP, USB_DEVICE_ID_TANGTOP_USBPS2, HID_QUIRK_NOGET },
 
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_POWERMOUSE, HID_QUIRK_2WHEEL_POWERMOUSE },
@@ -1828,9 +1832,6 @@ static struct hid_device *usb_hid_configure(struct usb_interface *intf)
         hid->urbctrl->transfer_dma = hid->ctrlbuf_dma;
         hid->urbctrl->transfer_flags |= (URB_NO_TRANSFER_DMA_MAP | URB_NO_SETUP_DMA_MAP);
 
-        /* May be needed for some devices */
-        usb_clear_halt(hid->dev, hid->urbin->pipe);
-
         return hid;
 
 fail:
diff --git a/drivers/usb/input/hiddev.c b/drivers/usb/input/hiddev.c
index 4dff8473553d..925f5aba06f5 100644
--- a/drivers/usb/input/hiddev.c
+++ b/drivers/usb/input/hiddev.c
@@ -35,7 +35,6 @@
 #include <linux/usb.h>
 #include "hid.h"
 #include <linux/hiddev.h>
-#include <linux/devfs_fs_kernel.h>
 
 #ifdef CONFIG_USB_DYNAMIC_MINORS
 #define HIDDEV_MINOR_BASE       0
@@ -632,7 +631,7 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
 
                         else if ((cmd == HIDIOCGUSAGES || cmd == HIDIOCSUSAGES) &&
                                  (uref_multi->num_values > HID_MAX_MULTI_USAGES ||
-                                  uref->usage_index + uref_multi->num_values >= field->report_count))
+                                  uref->usage_index + uref_multi->num_values > field->report_count))
                                 goto inval;
                         }
 
@@ -832,12 +831,10 @@ static /* const */ struct usb_driver hiddev_driver = {
 
 int __init hiddev_init(void)
 {
-        devfs_mk_dir("usb/hid");
         return usb_register(&hiddev_driver);
 }
 
 void hiddev_exit(void)
 {
         usb_deregister(&hiddev_driver);
-        devfs_remove("usb/hid");
 }
diff --git a/drivers/usb/input/touchkitusb.c b/drivers/usb/input/touchkitusb.c
index 3b3c7b4120a2..697c5e573a11 100644
--- a/drivers/usb/input/touchkitusb.c
+++ b/drivers/usb/input/touchkitusb.c
@@ -337,6 +337,9 @@ static int touchkit_probe(struct usb_interface *intf,
                          touchkit->data, TOUCHKIT_REPORT_DATA_SIZE,
                          touchkit_irq, touchkit, endpoint->bInterval);
 
+        touchkit->irq->transfer_dma = touchkit->data_dma;
+        touchkit->irq->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
+
         input_register_device(touchkit->input);
 
         usb_set_intfdata(intf, touchkit);
diff --git a/drivers/usb/input/yealink.c b/drivers/usb/input/yealink.c
index 1bfc105ad4d6..37d2f0ba0319 100644
--- a/drivers/usb/input/yealink.c
+++ b/drivers/usb/input/yealink.c
@@ -59,7 +59,7 @@
 #include "map_to_7segment.h"
 #include "yealink.h"
 
-#define DRIVER_VERSION "yld-20050816"
+#define DRIVER_VERSION "yld-20051230"
 #define DRIVER_AUTHOR "Henk Vergonet"
 #define DRIVER_DESC "Yealink phone driver"
 
@@ -786,16 +786,25 @@ static struct attribute_group yld_attr_group = {
  * Linux interface and usb initialisation
  ******************************************************************************/
 
-static const struct yld_device {
-        u16 idVendor;
-        u16 idProduct;
+struct driver_info {
         char *name;
-} yld_device[] = {
-        { 0x6993, 0xb001, "Yealink usb-p1k" },
 };
 
-static struct usb_device_id usb_table [] = {
-        { USB_INTERFACE_INFO(USB_CLASS_HID, 0, 0) },
+static const struct driver_info info_P1K = {
+        .name   = "Yealink usb-p1k",
+};
+
+static const struct usb_device_id usb_table [] = {
+        {
+                .match_flags            = USB_DEVICE_ID_MATCH_DEVICE |
+                                                USB_DEVICE_ID_MATCH_INT_INFO,
+                .idVendor               = 0x6993,
+                .idProduct              = 0xb001,
+                .bInterfaceClass        = USB_CLASS_HID,
+                .bInterfaceSubClass     = 0,
+                .bInterfaceProtocol     = 0,
+                .driver_info            = (kernel_ulong_t)&info_P1K
+        },
         { }
 };
 
@@ -842,33 +851,16 @@ static void usb_disconnect(struct usb_interface *intf)
         usb_cleanup(yld, 0);
 }
 
-static int usb_match(struct usb_device *udev)
-{
-        int i;
-        u16 idVendor = le16_to_cpu(udev->descriptor.idVendor);
-        u16 idProduct = le16_to_cpu(udev->descriptor.idProduct);
-
-        for (i = 0; i < ARRAY_SIZE(yld_device); i++) {
-                if ((idVendor == yld_device[i].idVendor) &&
-                    (idProduct == yld_device[i].idProduct))
-                        return i;
-        }
-        return -ENODEV;
-}
-
 static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
 {
         struct usb_device *udev = interface_to_usbdev (intf);
+        struct driver_info *nfo = (struct driver_info *)id->driver_info;
         struct usb_host_interface *interface;
         struct usb_endpoint_descriptor *endpoint;
         struct yealink_dev *yld;
         struct input_dev *input_dev;
         int ret, pipe, i;
 
-        i = usb_match(udev);
-        if (i < 0)
-                return -ENODEV;
-
         interface = intf->cur_altsetting;
         endpoint = &interface->endpoint[0].desc;
         if (!(endpoint->bEndpointAddress & USB_DIR_IN))
@@ -915,7 +907,7 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
         pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress);
         ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe));
         if (ret != USB_PKT_LEN)
-                err("invalid payload size %d, expected %d", ret, USB_PKT_LEN);
+                err("invalid payload size %d, expected %zd", ret, USB_PKT_LEN);
 
         /* initialise irq urb */
         usb_fill_int_urb(yld->urb_irq, udev, pipe, yld->irq_data,
@@ -948,7 +940,7 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
         strlcat(yld->phys,  "/input0", sizeof(yld->phys));
 
         /* register settings for the input device */
-        input_dev->name = yld_device[i].name;
+        input_dev->name = nfo->name;
         input_dev->phys = yld->phys;
         usb_to_input_id(udev, &input_dev->id);
         input_dev->cdev.dev = &intf->dev;